From xen-devel-bounces@lists.xenproject.org Tue Nov 01 01:10:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 01:10:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433271.686224 (Exim 4.92) (envelope-from ) id 1opfn4-0007th-Vu; Tue, 01 Nov 2022 01:10:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433271.686224; Tue, 01 Nov 2022 01:10:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opfn4-0007ta-Qv; Tue, 01 Nov 2022 01:10:06 +0000 Received: by outflank-mailman (input) for mailman id 433271; Tue, 01 Nov 2022 01:10:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opfn3-0007j0-M7; Tue, 01 Nov 2022 01:10:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opfn3-0004gC-GX; Tue, 01 Nov 2022 01:10:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opfn2-0002uK-Tv; Tue, 01 Nov 2022 01:10:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1opfn2-0006wn-TR; Tue, 01 Nov 2022 01:10:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hOEir+rsoKEMmHkK1lxeeVa8mgsfkL4d+SGUEZL2kVg=; b=feVCm9Qp4SMSw5qB5m3bNbg88q ya7xeO2zO2/a1rZS6UPSh/2K2+Y9uvDgIopXljtPLsVNnZv1GQ6U4MwRuY9FsPF5WLqkQWf2xCPe0 mM3aCevhgKbKEBJatspdbOZ7hrimzkQvkzNToOFK+y5eddjhj+16rVI3fqQiykeizFJI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 174555: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.15-testing:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-4.15-testing:test-amd64-amd64-pair:guests-nbd-mirror/debian:fail:heisenbug xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ddab5b1e001366258c0bfc7d5995b9d548e6042b X-Osstest-Versions-That: xen=f8915cd5dbe0f51e9bb31a54fe40600b839dd707 From: osstest service owner Date: Tue, 01 Nov 2022 01:10:04 +0000 flight 174555 xen-4.15-testing real [real] flight 174561 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174555/ http://logs.test-lab.xenproject.org/osstest/logs/174561/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 10 xen-install/src_host fail pass in 174561-retest test-amd64-amd64-pair 22 guests-nbd-mirror/debian fail pass in 174561-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174415 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174415 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174415 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174415 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174415 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174415 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174415 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174415 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174415 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174415 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174415 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174415 test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen ddab5b1e001366258c0bfc7d5995b9d548e6042b baseline version: xen f8915cd5dbe0f51e9bb31a54fe40600b839dd707 Last test of basis 174415 2022-10-25 20:13:09 Z 6 days Testing same since 174555 2022-10-31 13:08:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Dario Faggioli Igor Druzhinin Jan Beulich Jason Andryuk Juergen Gross Julien Grall Marek Marczykowski-Górecki Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f8915cd5db..ddab5b1e00 ddab5b1e001366258c0bfc7d5995b9d548e6042b -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 03:51:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 03:51:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433312.686288 (Exim 4.92) (envelope-from ) id 1opiJ2-0000zx-TD; Tue, 01 Nov 2022 03:51:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433312.686288; Tue, 01 Nov 2022 03:51:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opiJ2-0000zp-MT; Tue, 01 Nov 2022 03:51:16 +0000 Received: by outflank-mailman (input) for mailman id 433312; Tue, 01 Nov 2022 03:51:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opiJ1-0000zf-DE; Tue, 01 Nov 2022 03:51:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opiJ1-0004Fj-8F; Tue, 01 Nov 2022 03:51:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opiJ0-0000ao-NZ; Tue, 01 Nov 2022 03:51:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1opiJ0-0007SC-Ls; Tue, 01 Nov 2022 03:51:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XymWof9tppcqUqbUhagK9zQfXyjMi0YNCFAyaJA7oPE=; b=Q1g7svxbJYkoPUkvsd5qLXQCp0 be1RqjZBibWq35ExZU9VTdLQVyd7BT4tuRdpFksLXgPuKseSWYKhYiKMvf97z9CPjUDg5q0F2JxN6 T/GXHveiFjVIIite5Qn+QHvuoxvsAyz83mhWiBhAZwSd/AB8rboZeRZOaupo/iQk8L7I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174562: all pass - PUSHED X-Osstest-Versions-This: ovmf=df7ce74e6c75e19a528d5b4921e5b3d0260e45fe X-Osstest-Versions-That: ovmf=66772bc8523ce7898eb470efc7aef65c2062b2aa From: osstest service owner Date: Tue, 01 Nov 2022 03:51:14 +0000 flight 174562 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174562/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf df7ce74e6c75e19a528d5b4921e5b3d0260e45fe baseline version: ovmf 66772bc8523ce7898eb470efc7aef65c2062b2aa Last test of basis 174557 2022-10-31 17:42:01 Z 0 days Testing same since 174562 2022-11-01 01:43:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 66772bc852..df7ce74e6c df7ce74e6c75e19a528d5b4921e5b3d0260e45fe -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Nov 01 04:13:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 04:13:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433318.686299 (Exim 4.92) (envelope-from ) id 1opieG-0003rU-Ko; Tue, 01 Nov 2022 04:13:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433318.686299; Tue, 01 Nov 2022 04:13:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opieG-0003rN-Gk; Tue, 01 Nov 2022 04:13:12 +0000 Received: by outflank-mailman (input) for mailman id 433318; Tue, 01 Nov 2022 04:13:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opieF-0003rD-5S; Tue, 01 Nov 2022 04:13:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opieF-0004jV-1G; Tue, 01 Nov 2022 04:13:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opieE-0001Zc-FV; Tue, 01 Nov 2022 04:13:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1opieE-0005lK-B4; Tue, 01 Nov 2022 04:13:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=E9bYkqaeVzC76cjIyRKr6lHZyP9Jrg3QXhenSXex+/E=; b=LE/QOPr7cNtZXkfYEV8VVgBC99 JkENHJn1Mcp0vlNR/qSopEwRY87NrAluDNc5fCCsBZAoS2d9/3hiv7LMtFIf25AQtW16kWJOc0PEu fXFcFaaDVK232GcruybCu2Q/3Ew6dEnGuW6VP+oEGBIpXZEM+0jaJnc950jvWO96b3iM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174556: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=30a0b95b1335e12efef89dd78518ed3e4a71a763 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 01 Nov 2022 04:13:10 +0000 flight 174556 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174556/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 30a0b95b1335e12efef89dd78518ed3e4a71a763 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 24 days Failing since 173470 2022-10-08 06:21:34 Z 23 days 37 attempts Testing same since 174550 2022-10-31 05:53:03 Z 0 days 2 attempts ------------------------------------------------------------ 1528 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 143060 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Nov 01 04:53:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 04:53:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433330.686310 (Exim 4.92) (envelope-from ) id 1opjH9-0000co-Sg; Tue, 01 Nov 2022 04:53:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433330.686310; Tue, 01 Nov 2022 04:53:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opjH9-0000ch-Q2; Tue, 01 Nov 2022 04:53:23 +0000 Received: by outflank-mailman (input) for mailman id 433330; Tue, 01 Nov 2022 04:53:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opjH8-0000cX-5E; Tue, 01 Nov 2022 04:53:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opjH8-0005aE-2c; Tue, 01 Nov 2022 04:53:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opjH7-0005Gg-J5; Tue, 01 Nov 2022 04:53:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1opjH7-0001ue-Ib; Tue, 01 Nov 2022 04:53:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3eJ60bnzDd71tj/gI1x3YfOIte8/gbpPDQkXlRdaEGI=; b=UWwmOdhOLQxbCyge8QIRbGCgJb XWJ8iUqXFva3GULaG9f9xJZIgHiIkSabzTQlHB0AJUsUKMxA3GnMuau+X+cAZM6azV3V4j5GJrDkg GRR8WfhxekXCmTYBXhW+1gzj+dT0N5EOpUt+SynXhHoZ2szKkgLy7EUZsXYNXeHC+PfQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174560: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=5107fd3effb1cfec3b96d9e819f1605048640e31 X-Osstest-Versions-That: qemuu=7208429223963c405c62fa2611398f1aa8033593 From: osstest service owner Date: Tue, 01 Nov 2022 04:53:21 +0000 flight 174560 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174560/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174552 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174552 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174552 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174552 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174552 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174552 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174552 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174552 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 5107fd3effb1cfec3b96d9e819f1605048640e31 baseline version: qemuu 7208429223963c405c62fa2611398f1aa8033593 Last test of basis 174552 2022-10-31 10:40:22 Z 0 days Testing same since 174560 2022-10-31 20:38:40 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki BALATON Zoltan Bernhard Beschow Bin Meng Brad Smith Christian Borntraeger Claudio Imbrenda Cornelia Huck Daniel Henrique Barboza David Daney David Hildenbrand Ilya Leoshkevich Jiaxun Yang Jonathan Cameron Leandro Lupori Lucas Mateus Castro (alqotel) Matheus Ferst Milica Lazarevic Muhammad Moinur Rahman Nico Boehr Peter Maydell Philippe Mathieu-Daudé Philippe Mathieu-Daudé Philippe Mathieu-Daudé Richard Henderson Stefan Hajnoczi Stefan Weil Thomas Huth Víctor Colombo Warner Losh Xuzhou Cheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 7208429223..5107fd3eff 5107fd3effb1cfec3b96d9e819f1605048640e31 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Nov 01 07:08:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 07:08:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433342.686320 (Exim 4.92) (envelope-from ) id 1oplNv-0007Uo-IG; Tue, 01 Nov 2022 07:08:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433342.686320; Tue, 01 Nov 2022 07:08:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oplNv-0007Uh-Fa; Tue, 01 Nov 2022 07:08:31 +0000 Received: by outflank-mailman (input) for mailman id 433342; Tue, 01 Nov 2022 07:08:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oplNt-0007Ub-P9 for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 07:08:29 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fbd3300d-59b3-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 08:08:28 +0100 (CET) Received: by mail-ed1-x52c.google.com with SMTP id 21so20585935edv.3 for ; Tue, 01 Nov 2022 00:08:28 -0700 (PDT) Received: from [192.168.1.93] (adsl-235.109.242.227.tellas.gr. [109.242.227.235]) by smtp.gmail.com with ESMTPSA id f14-20020a056402150e00b004610899742asm4120503edw.13.2022.11.01.00.08.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 00:08:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fbd3300d-59b3-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OE5nUEXCoGJTQIxnJ6QxeDcCeetfHlEtd4i1iX4NJvE=; b=lC5WXkEYCyogMF5KDuV2BjapNnYHA8wyKrU4ISZGwhnhjsCgCVzhsgF3NfrMG8kXzb VMLqUUC6+ceeCCjuLsaLwiIFLculq+tpYOeQ0NIFti8EC8cxRkomWzR0RZOuQWQOB8wC exz7RUlj46FhAmvYa+RonecjO2837Rgbf9WNw1eZ0fQQQPf/1XBvPQcnMpxS9BvtOq0e gYcq/s+H12bHSEDQ3yxJk+A3qjxnEkSqJmV95jTbRaj/hrEzceDRbQ38YUBNJxkyj2LN jjYj32TWq6Jq7OsMsFhcNlG4WxqiVx2fICf3iQfDHHZVSAYX79I5LHlMIXc3ifaKVWvv xdQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OE5nUEXCoGJTQIxnJ6QxeDcCeetfHlEtd4i1iX4NJvE=; b=8MLrTXJyTX++FLGYrBPKzOoa6qKnpo37bqrYIN2mcNWUhm1DWa7hfaivy3SN/wt2VR OVPTFyzljJuN5I52ICxsO7d1nBuZSNfD1Z/zFEz/NmXi5yk8MwCegC8LV2CQopUQew+s fleuno2mqVedZqkOxkva9QIgWmMDmeqnE9323NmSplCq4+F9Rqd7ahhnYH9haA9Y1D6W 1j1vHqRCKkLMHkztwD2x4PiEdgvOP1ISnXJIpnxjmb0YFJQ+4dZRy6KmpUoecci5q5Vz xx3O6bIWGAhQw2oNf7VseHIwwjkXe1MifI91gXFvgc4a9Fj07Ds5v3EfsyBr4l3MPLoz rS/A== X-Gm-Message-State: ACrzQf3KzP8zE/8l3w2KkUHQoxKlvRJE1B7TDGOJanL2MZ6sDnatzkaG XVqXGUi39/p1x6ID4zrQg9E= X-Google-Smtp-Source: AMsMyM4a4CfeWzdQOzdSI95DDPT3ciy9u3s5Iv4flcBeuAUiyrkEFAh/Mq7np1YepV61eIDGe8B6hQ== X-Received: by 2002:a05:6402:1d4e:b0:461:c7bd:7d9c with SMTP id dz14-20020a0564021d4e00b00461c7bd7d9cmr17551263edb.284.1667286507630; Tue, 01 Nov 2022 00:08:27 -0700 (PDT) Message-ID: <956195e5-0409-1da0-f0db-a0192061d29d@gmail.com> Date: Tue, 1 Nov 2022 09:08:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [XEN v2 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-12-ayankuma@amd.com> From: Xenia Ragiadakou In-Reply-To: <20221031151326.22634-12-ayankuma@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 10/31/22 17:13, Ayan Kumar Halder wrote: > Defined readq_relaxed()/writeq_relaxed() to read and write 64 bit regs. > This uses ldrd/strd instructions. > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from :- > v1 - 1. Use ldrd/strd for readq_relaxed()/writeq_relaxed(). > 2. No need to use le64_to_cpu() as the returned byte order is already in cpu > endianess. > > xen/arch/arm/include/asm/arm32/io.h | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/xen/arch/arm/include/asm/arm32/io.h b/xen/arch/arm/include/asm/arm32/io.h > index 73a879e9fb..d9d19ad764 100644 > --- a/xen/arch/arm/include/asm/arm32/io.h > +++ b/xen/arch/arm/include/asm/arm32/io.h > @@ -72,6 +72,22 @@ static inline u32 __raw_readl(const volatile void __iomem *addr) > return val; > } > > +static inline u64 __raw_readq(const volatile void __iomem *addr) > +{ > + u64 val; > + asm volatile("ldrd %Q1, %R1, %0" > + : "+Qo" (*(volatile u64 __force *)addr), > + "=r" (val)); > + return val; > +} > + > +static inline void __raw_writeq(u64 val, const volatile void __iomem *addr) > +{ > + asm volatile("strd %Q1, %R1, %0" > + : "+Q" (*(volatile u64 __force *)addr) > + : "r" (val)); > +} > + > #define __iormb() rmb() > #define __iowmb() wmb() > > @@ -80,17 +96,22 @@ static inline u32 __raw_readl(const volatile void __iomem *addr) > __raw_readw(c)); __r; }) > #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \ > __raw_readl(c)); __r; }) > +#define readq_relaxed(c) ({ u64 __r = le64_to_cpu((__force __le64) \ > + __raw_readq(c)); __r; }) > > #define writeb_relaxed(v,c) __raw_writeb(v,c) > #define writew_relaxed(v,c) __raw_writew((__force u16) cpu_to_le16(v),c) > #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c) > +#define writeq_relaxed(v,c) __raw_writeq((__force u64) cpu_to_le64(v),c) > > #define readb(c) ({ u8 __v = readb_relaxed(c); __iormb(); __v; }) > #define readw(c) ({ u16 __v = readw_relaxed(c); __iormb(); __v; }) > #define readl(c) ({ u32 __v = readl_relaxed(c); __iormb(); __v; }) > +#define readq(c) ({ u64 __v = readq_relaxed(c); __iormb(); __v; }) > > #define writeb(v,c) ({ __iowmb(); writeb_relaxed(v,c); }) > #define writew(v,c) ({ __iowmb(); writew_relaxed(v,c); }) > #define writel(v,c) ({ __iowmb(); writel_relaxed(v,c); }) > +#define writeq(v,c) ({ __iowmb(); writeq_relaxed(v,c); }) > > #endif /* _ARM_ARM32_IO_H */ AFAIU, ldrd/strd accesses to MMIO are not guaranteed to be 64-bit single-copy atomic. So, as Julien suggested, you still need to use a different name to reflect this. Also, having nested virtualization in mind, since these instructions can't be virtualized, maybe it would be better to avoid using them for MMIO accesses. -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Nov 01 07:56:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 07:56:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433359.686332 (Exim 4.92) (envelope-from ) id 1opm81-00051M-7B; Tue, 01 Nov 2022 07:56:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433359.686332; Tue, 01 Nov 2022 07:56:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opm81-00051F-48; Tue, 01 Nov 2022 07:56:09 +0000 Received: by outflank-mailman (input) for mailman id 433359; Tue, 01 Nov 2022 07:56:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opm7z-000519-Kb for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 07:56:07 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a06a520d-59ba-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 08:56:02 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A87AF33982; Tue, 1 Nov 2022 07:56:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8EC9B13AAF; Tue, 1 Nov 2022 07:56:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id k4ZaIRLRYGOcFwAAMHmgww (envelope-from ); Tue, 01 Nov 2022 07:56:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a06a520d-59ba-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667289362; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FhA0lkFE3ehJRTOuZvzMI+szc0yJt9Js+RvntOlYpGk=; b=J0ZXtEe0alc3g5ng7lrO6egtdq+mMXi7PVBjlcFGBCRxn9jPv4DkomnMcMiu2C9TUkD5Ts ykvUfvnBqVNZlWoQfa3/b10WZuhcer6kPl8/6cvOxZA/yvPi5rc3X2Zm30Eci/fVXUYfjI t8oCeTO4UQ2mmV/oCF+MYw94ffCZxho= Message-ID: <3c8a3be2-db65-253d-94ae-1bfcad1b94e2@suse.com> Date: Tue, 1 Nov 2022 08:56:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [linux-linus test] 174539: regressions - FAIL To: osstest service owner , xen-devel@lists.xenproject.org References: Content-Language: en-US From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------YOonz3PkZkSEnL3i3OYV22s9" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------YOonz3PkZkSEnL3i3OYV22s9 Content-Type: multipart/mixed; boundary="------------PlmKIhi0yXpu0KpeGpl0UY48"; protected-headers="v1" From: Juergen Gross To: osstest service owner , xen-devel@lists.xenproject.org Message-ID: <3c8a3be2-db65-253d-94ae-1bfcad1b94e2@suse.com> Subject: Re: [linux-linus test] 174539: regressions - FAIL References: In-Reply-To: --------------PlmKIhi0yXpu0KpeGpl0UY48 Content-Type: multipart/mixed; boundary="------------egLvjb7GefCbgNDbst4STKfx" --------------egLvjb7GefCbgNDbst4STKfx Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjkuMTAuMjIgMjM6NTAsIG9zc3Rlc3Qgc2VydmljZSBvd25lciB3cm90ZToNCj4gZmxp Z2h0IDE3NDUzOSBsaW51eC1saW51cyByZWFsIFtyZWFsXQ0KPiBodHRwOi8vbG9ncy50ZXN0 LWxhYi54ZW5wcm9qZWN0Lm9yZy9vc3N0ZXN0L2xvZ3MvMTc0NTM5Lw0KPiANCj4gUmVncmVz c2lvbnMgOi0oDQoNCkknbSByYXRoZXIgc3VyZSB0aGlzIGlzIG5vdCBrZXJuZWwgcmVsYXRl ZCwgYXMgdGhlIGlzc3VlIGlzIG9jY3VycmluZyBvbmx5IG9uDQpBcm0gYW5kIGl0IGRvZXNu J3Qgc2VlbSB0byBiZSBhbiBhcmNoaXRlY3R1cmUgcmVsYXRlZCBpc3N1ZSAodGhlIHZvbHVt ZSBncm91cA0KY29udGFpbmluZyB0aGUgcm9vdCBmaWxlIHN5c3RlbSBjb3VsZG4ndCBiZSBm b3VuZCkuDQoNCkNvdWxkIGl0IGJlIGFuIGluZnJhc3RydWN0dXJlIHByb2JsZW0/DQoNCg0K SnVlcmdlbg0K --------------egLvjb7GefCbgNDbst4STKfx Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------egLvjb7GefCbgNDbst4STKfx-- --------------PlmKIhi0yXpu0KpeGpl0UY48-- --------------YOonz3PkZkSEnL3i3OYV22s9 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNg0RIFAwAAAAAACgkQsN6d1ii/Ey/F Xwf9GtlRXwXrji0k6F1DrQf4win+Cbw4yLA+ZUfwMqFWroAOuxQvcdxvBS+TNhTTdq7TLnWjtOs4 G5GWUl00E9jfa4zeeYCNmTVQ10d8RAhwGqItCea69gvCmtEUE2bE+3nmtfTYI0bnKCruEdbGtKp0 e2RPYCAKy6BtILy1OLZVSy/PG7V+fJcYQ4ULdmU42HCh/wOIm5MXEkCFoGMAsnAGFmnZSegpGJgJ a6a7CFDOIYv2OQdLGZnsMXaotzKJTovmmOTTPPudWieqTjP5dmIbOyVSQYb8FOUu+VaP4qI+Uft7 rrcQIs/gHwyjLUObbrpGmY+Bfdv1KTbeM+WY9HHVGA== =r3gk -----END PGP SIGNATURE----- --------------YOonz3PkZkSEnL3i3OYV22s9-- From xen-devel-bounces@lists.xenproject.org Tue Nov 01 08:58:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 08:58:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433372.686343 (Exim 4.92) (envelope-from ) id 1opn6M-0004Hj-7i; Tue, 01 Nov 2022 08:58:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433372.686343; Tue, 01 Nov 2022 08:58:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opn6M-0004Hc-3U; Tue, 01 Nov 2022 08:58:30 +0000 Received: by outflank-mailman (input) for mailman id 433372; Tue, 01 Nov 2022 08:58:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opn6J-0004HW-Vr for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 08:58:28 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2077.outbound.protection.outlook.com [40.107.212.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57fcfda4-59c3-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 09:58:25 +0100 (CET) Received: from DM6PR18CA0002.namprd18.prod.outlook.com (2603:10b6:5:15b::15) by CH2PR12MB4071.namprd12.prod.outlook.com (2603:10b6:610:7b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Tue, 1 Nov 2022 08:58:22 +0000 Received: from DM6NAM11FT100.eop-nam11.prod.protection.outlook.com (2603:10b6:5:15b:cafe::ee) by DM6PR18CA0002.outlook.office365.com (2603:10b6:5:15b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend Transport; Tue, 1 Nov 2022 08:58:22 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT100.mail.protection.outlook.com (10.13.172.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5769.14 via Frontend Transport; Tue, 1 Nov 2022 08:58:22 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 03:58:21 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 01:58:21 -0700 Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Tue, 1 Nov 2022 03:58:19 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57fcfda4-59c3-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JauM+JLftHdMKWSjuM7HxcIocdigQYqt80qduB5yjvYmEza5maZMrcvbaDuJhdOScXRuZ/moDUP4wZf5dWFcWCvKAoHPmJ4HhrqDBNlFkRV5TVjukDhy8EBss/Q61H40DGO2UIXy/H+f/dkc/8DQfl2FHXFgtn0Ym8UWGSzSlX+s6RWLqFB9D//GJnwY5wg3jhw9FXiyT+6viuOzMeguQSxoDE0EtDBlG3pVa52eNG2eX0iHRJwamJQTaGyrsqoI8bBJMfgiEHC1BgLt9u3nns2OGk+bRh0vm8OH8K7AmcJKvdxZFwMl4sptkpPe10tt2P+IpNrxLYg+45g4gQBowg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ihZ6D3XwiQaBzze2onm8m0Z/6iwE3d4+vSCAl91VIEo=; b=OOQulLRqrRDfwKAu4AxnH+PM8/98pHjdurxVQ8wBxdGdjkkMmDZ2ZNXNZWWupjlS+xKdVmyZw6kwBtFlTzE0ef6z/IVJ5Fhl1c03ZtpiwdNwALPra/n+5bgUZfixMXypBoNqgXyL01P3g6mmCHa4mobxbCmfUK5Fr5ALJupkOvmY1bKFcGGSfTbtz4WfpDktZyOEMBBQ4l/wB5uzROJRt6ssEhsf8TQsIUtSaaq33BClFPYg26CrMSG/ocwHv3tb5ItIzFkD6CXRX/k08bZOCQrOrVqRlwZu1xYo6oj7T1eBEPO1UG8opO7tqpJ+Y+aquWVLBdUEc6QxIVbjgETUzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ihZ6D3XwiQaBzze2onm8m0Z/6iwE3d4+vSCAl91VIEo=; b=4RNH2Owvw6hxsNl+UjTQ4KDJiOhvqwBrdy1Z0LTVmeK0CGe/fhtSCwVRReBaSagwyf/sDFkpJG7xYGXsQCS3Vy82VFjQ/f4JtVlMMi3PfFeopVFj3z1w1M24OQ3/Ty7eNkT3XMHXSmJSCd/fGgxG8DW036KsJIjuEIDf3UC49SQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Tue, 1 Nov 2022 09:58:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 02/12] xen/Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32 From: Michal Orzel To: Ayan Kumar Halder , CC: , , , , , References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-3-ayankuma@amd.com> <4271ac3e-04bf-7bbb-2db9-3216ac19e778@amd.com> Content-Language: en-US In-Reply-To: <4271ac3e-04bf-7bbb-2db9-3216ac19e778@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT100:EE_|CH2PR12MB4071:EE_ X-MS-Office365-Filtering-Correlation-Id: 560e5eb4-f8a3-4b28-6665-08dabbe73aad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DVFj3qu/oGkO6AceTdlY9wJN1THJm5neUhEhEBpsrMST8NEEXSxVv+vdrpZHZEehxRNqv813qlaOzwJIIRXEiY6m316QqX8bXYISmWxo6DxAxIx52au8X6f34xZXXXpci392QGhynRQbM+h2Xgkqm5Gj3Y9DRsFBqkr0Ke64quLZGmBPVyZV1UWRDxRK1QUqYdPxY6lWjQYPVmy+EUPdaCCfOEy88BhdMs/5vT9wDj6+VkBJKNTk+ibUd90l2voABn3fydzHbdBC/acheQkca/XcmvsnB4Vy+rLG+TMjoFfTT1XGDdAGTukkhFSd3NqPMxvdJiYszW/q1RnbcUpS5cVTg42vsk0OoDyC93bwuasHUiSdWFxsSRrcc7hoV0nG4NQswlT2RMj0Kq63yeoYdTB8ch8bSWtbn0SUd7pSxtkHG/5Hx+DrBq59GtictWnQRSO8bv9eTKC9l7gWkTQ1OW4XSzdayV988MEMU0Ed0r/SMNZYq8nIvZgNFmrJQYn1z0mWvNDRlgE0nH6EZqmq7g3F7x8p9orcDgpxNk70K94I+dHVRaklaha8i1AR01e8OD51RRBA/DeBB1+X+nBt8fQ83l4a4WoJu9mVt1vBU4RTMcOkaSjF9YIdj5yFdhTxNYe7ZIC5cbYHHUPGp2pemfhTlhjQY2tcFfOv59iJzxpMh2aaZBixsnURrRCo5B8VNDL4T91yYMPne6IUoJPdCAszF6Mo7s1ihg5onfZpSyWd3ZNto7yKNJte6sLVUzO49koVoz7f+2PJ0G9UkorvJJiO5ZmFD+aIISRHAeXt/xxtvk+G7C19bXaQ4b9KzHxaY057TdOG8OKcLBme1kMmrL+6YodDTz3a9xSqrkSg/2Douo4PVy1CO8OvFFXZ9mDB1CEXXKVKu818FuqK0z8nCw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(396003)(376002)(451199015)(46966006)(36840700001)(40470700004)(40460700003)(45080400002)(8936002)(5660300002)(83380400001)(54906003)(110136005)(26005)(2906002)(966005)(31696002)(47076005)(40480700001)(186003)(53546011)(336012)(426003)(478600001)(44832011)(86362001)(2616005)(36756003)(31686004)(82740400003)(70586007)(70206006)(356005)(81166007)(36860700001)(82310400005)(16576012)(316002)(41300700001)(8676002)(4326008)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 08:58:22.1847 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 560e5eb4-f8a3-4b28-6665-08dabbe73aad X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT100.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4071 On 31/10/2022 18:53, Michal Orzel wrote: > > > Hi Ayan, > > On 31/10/2022 16:13, Ayan Kumar Halder wrote: >> >> >> Refer https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv6.1-rc1%2Fsource%2Farch%2Farm64%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7C0b2a0d1537104c2391d008dabb68eabb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638028356554609284%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RhhL0XWxLJsO7vsP0DoP1QMvUMwGV%2F4FPJwAyvStj4k%3D&reserved=0 \ > You should not split the link as it is becoming unusable in that form. > >> include/asm/cputype.h#L14 , for the macros specific for arm64. >> >> Refer https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv6.1-rc1%2Fsource%2Farch%2Farm%2Finclude%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7C0b2a0d1537104c2391d008dabb68eabb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638028356554609284%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gLsNWm5%2BSyy51rn%2BA6H8PrWg8Yv%2BERicyyDjshOd3hc%3D&reserved=0 \ > Same here. > >> asm/cputype.h#L54 , for the macros specific for arm32. >> >> MPIDR_LEVEL_SHIFT() differs between 64 and 32 bit. >> For 64 bit :- >> >> aff_lev3 aff_lev2 aff_lev1 aff_lev0 >> |________|________|________|________|________| >> 40 32 24 16 8 0 >> >> For 32 bit :- >> >> aff_lev3 aff_lev2 aff_lev1 aff_lev0 >> |________|________|________|________| >> 32 24 16 8 0 >> > > Where did you get this info from? > FWICS by looking at ARM ARM DDI 0487I.a D17-6118, > "Aff3 is not supported in AArch32 state." We're talking about arm32 and not AArch32. My bad. Nevertheless, looking at ARM ARM DDI 0406C.d B4-1644, MPIDR for Armv7A/R also does not have aff3. > > >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changes from :- >> v1 - 1. Rearranged the macro defines so that the common code (between arm32 >> and arm64) is placed in "arm/include/asm/processor.h". >> >> xen/arch/arm/include/asm/arm32/processor.h | 5 +++++ >> xen/arch/arm/include/asm/arm64/processor.h | 8 ++++++++ >> xen/arch/arm/include/asm/processor.h | 6 ------ >> 3 files changed, 13 insertions(+), 6 deletions(-) >> >> diff --git a/xen/arch/arm/include/asm/arm32/processor.h b/xen/arch/arm/include/asm/arm32/processor.h >> index 4e679f3273..82aa7f8d9d 100644 >> --- a/xen/arch/arm/include/asm/arm32/processor.h >> +++ b/xen/arch/arm/include/asm/arm32/processor.h >> @@ -56,6 +56,11 @@ struct cpu_user_regs >> uint32_t pad1; /* Doubleword-align the user half of the frame */ >> }; >> >> +/* >> + * Macros to extract affinity level. Picked from kernel >> + */ > No need for a multiline comment here and everywhere else. > >> +#define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * (level)) >> + >> #endif >> >> #endif /* __ASM_ARM_ARM32_PROCESSOR_H */ >> diff --git a/xen/arch/arm/include/asm/arm64/processor.h b/xen/arch/arm/include/asm/arm64/processor.h >> index c749f80ad9..295483a9dd 100644 >> --- a/xen/arch/arm/include/asm/arm64/processor.h >> +++ b/xen/arch/arm/include/asm/arm64/processor.h >> @@ -84,6 +84,14 @@ struct cpu_user_regs >> uint64_t sp_el1, elr_el1; >> }; >> >> +/* >> + * Macros to extract affinity level. picked from kernel >> + */ >> +#define MPIDR_LEVEL_BITS_SHIFT 3 >> + >> +#define MPIDR_LEVEL_SHIFT(level) \ >> + (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT) >> + > You should move these macros below __DECL_REG as they do not require having it defined. > >> #undef __DECL_REG >> >> #endif /* __ASSEMBLY__ */ >> diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h >> index 1dd81d7d52..ecfb62bbbe 100644 >> --- a/xen/arch/arm/include/asm/processor.h >> +++ b/xen/arch/arm/include/asm/processor.h >> @@ -122,13 +122,7 @@ >> /* >> * Macros to extract affinity level. picked from kernel >> */ >> - >> -#define MPIDR_LEVEL_BITS_SHIFT 3 >> #define MPIDR_LEVEL_MASK ((1 << MPIDR_LEVEL_BITS) - 1) >> - >> -#define MPIDR_LEVEL_SHIFT(level) \ >> - (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT) >> - >> #define MPIDR_AFFINITY_LEVEL(mpidr, level) \ >> (((mpidr) >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK) >> >> -- >> 2.17.1 >> >> > > ~Michal > From xen-devel-bounces@lists.xenproject.org Tue Nov 01 09:50:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 09:50:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433395.686353 (Exim 4.92) (envelope-from ) id 1opnui-0002dR-1k; Tue, 01 Nov 2022 09:50:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433395.686353; Tue, 01 Nov 2022 09:50:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opnuh-0002dK-VB; Tue, 01 Nov 2022 09:50:31 +0000 Received: by outflank-mailman (input) for mailman id 433395; Tue, 01 Nov 2022 09:50:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opnuh-0002dE-FL for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 09:50:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opnug-0003KN-C0; Tue, 01 Nov 2022 09:50:30 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.18.67]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1opnug-0007ff-3L; Tue, 01 Nov 2022 09:50:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=o0tHR/Chxdt9EgzDLGv94TBnplvlBFiaBmJXvadZ21Q=; b=HFnRtVR4Eove0Fgcc3kXEDs2r3 XCUVmVQMJgvLHoiAahFwtmqm+Z9pXC+STh3ShNT9V1NbxHXC1mhXjWFEqGJ+Ybdyrx2ldRv7pvZxr Pun1/5n5XOIPiqKlEIl7qaUqDEcv8sD7BCrn9aXiBhsm9xGGMlYwvZmUI/ClKMy0caU8=; Message-ID: Date: Tue, 1 Nov 2022 09:50:27 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit Content-Language: en-US To: Xenia Ragiadakou , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-12-ayankuma@amd.com> <956195e5-0409-1da0-f0db-a0192061d29d@gmail.com> From: Julien Grall In-Reply-To: <956195e5-0409-1da0-f0db-a0192061d29d@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 01/11/2022 07:08, Xenia Ragiadakou wrote: > On 10/31/22 17:13, Ayan Kumar Halder wrote: >> Defined readq_relaxed()/writeq_relaxed() to read and write 64 bit regs. >> This uses ldrd/strd instructions. >> >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changes from :- >> v1 - 1. Use ldrd/strd for readq_relaxed()/writeq_relaxed(). >> 2. No need to use le64_to_cpu() as the returned byte order is already >> in cpu >> endianess. >> >>   xen/arch/arm/include/asm/arm32/io.h | 21 +++++++++++++++++++++ >>   1 file changed, 21 insertions(+) >> >> diff --git a/xen/arch/arm/include/asm/arm32/io.h >> b/xen/arch/arm/include/asm/arm32/io.h >> index 73a879e9fb..d9d19ad764 100644 >> --- a/xen/arch/arm/include/asm/arm32/io.h >> +++ b/xen/arch/arm/include/asm/arm32/io.h >> @@ -72,6 +72,22 @@ static inline u32 __raw_readl(const volatile void >> __iomem *addr) >>           return val; >>   } >> +static inline u64 __raw_readq(const volatile void __iomem *addr) >> +{ >> +        u64 val; >> +        asm volatile("ldrd %Q1, %R1, %0" >> +                     : "+Qo" (*(volatile u64 __force *)addr), >> +                       "=r" (val)); >> +        return val; >> +} >> + >> +static inline void __raw_writeq(u64 val, const volatile void __iomem >> *addr) >> +{ >> +    asm volatile("strd %Q1, %R1, %0" >> +                 : "+Q" (*(volatile u64 __force *)addr) >> +                 : "r" (val)); >> +} >> + >>   #define __iormb()               rmb() >>   #define __iowmb()               wmb() >> @@ -80,17 +96,22 @@ static inline u32 __raw_readl(const volatile void >> __iomem *addr) >>                                           __raw_readw(c)); __r; }) >>   #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \ >>                                           __raw_readl(c)); __r; }) >> +#define readq_relaxed(c) ({ u64 __r = le64_to_cpu((__force __le64) \ >> +                                        __raw_readq(c)); __r; }) >>   #define writeb_relaxed(v,c)     __raw_writeb(v,c) >>   #define writew_relaxed(v,c)     __raw_writew((__force u16) >> cpu_to_le16(v),c) >>   #define writel_relaxed(v,c)     __raw_writel((__force u32) >> cpu_to_le32(v),c) >> +#define writeq_relaxed(v,c)     __raw_writeq((__force u64) >> cpu_to_le64(v),c) >>   #define readb(c)                ({ u8  __v = readb_relaxed(c); >> __iormb(); __v; }) >>   #define readw(c)                ({ u16 __v = readw_relaxed(c); >> __iormb(); __v; }) >>   #define readl(c)                ({ u32 __v = readl_relaxed(c); >> __iormb(); __v; }) >> +#define readq(c)                ({ u64 __v = readq_relaxed(c); >> __iormb(); __v; }) >>   #define writeb(v,c)             ({ __iowmb(); writeb_relaxed(v,c); }) >>   #define writew(v,c)             ({ __iowmb(); writew_relaxed(v,c); }) >>   #define writel(v,c)             ({ __iowmb(); writel_relaxed(v,c); }) >> +#define writeq(v,c)             ({ __iowmb(); writeq_relaxed(v,c); }) >>   #endif /* _ARM_ARM32_IO_H */ > > AFAIU, ldrd/strd accesses to MMIO are not guaranteed to be 64-bit > single-copy atomic. So, as Julien suggested, you still need to use a > different name to reflect this. > Also, having nested virtualization in mind, since these instructions > can't be virtualized, maybe it would be better to avoid using them for > MMIO accesses. +1. The previous version was actually using 32-bit access and it is not clear to me why the new version is using 64-bit access. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 01 09:56:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 09:56:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433402.686365 (Exim 4.92) (envelope-from ) id 1opo0G-0003QY-NQ; Tue, 01 Nov 2022 09:56:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433402.686365; Tue, 01 Nov 2022 09:56:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opo0G-0003QR-K3; Tue, 01 Nov 2022 09:56:16 +0000 Received: by outflank-mailman (input) for mailman id 433402; Tue, 01 Nov 2022 09:56:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opo0F-0003QH-PZ; Tue, 01 Nov 2022 09:56:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opo0F-0003Q6-MJ; Tue, 01 Nov 2022 09:56:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opo0F-0001y4-6C; Tue, 01 Nov 2022 09:56:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1opo0F-0001Ff-5k; Tue, 01 Nov 2022 09:56:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wT7U0U5M6MbWBePSVGRIXilk1YJBfAMy2yM7mN60/vE=; b=zbfrroEPuKN3DnY3T5zXpMlLp6 1JLonWIx+70O9D3Yy6rUXLsRx+tfkY0Zme5IEBtOlQx4ojfdjGMW1rmcu68psj9nrb76/t7bwwz6V YOqXottFkFUYEqfBjqzJZCK/wJFFLe9LtDEh567C+WWJgi2Ct3AFw/3DhHtNPSXZFEEA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174563: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1 X-Osstest-Versions-That: xen=1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1 From: osstest service owner Date: Tue, 01 Nov 2022 09:56:15 +0000 flight 174563 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174563/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174547 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174547 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174547 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174547 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174547 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174547 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174547 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174547 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174547 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174547 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174547 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174547 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1 baseline version: xen 1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1 Last test of basis 174563 2022-11-01 01:51:51 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Nov 01 10:04:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 10:04:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433410.686376 (Exim 4.92) (envelope-from ) id 1opo7h-00051J-JO; Tue, 01 Nov 2022 10:03:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433410.686376; Tue, 01 Nov 2022 10:03:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opo7h-00051C-GX; Tue, 01 Nov 2022 10:03:57 +0000 Received: by outflank-mailman (input) for mailman id 433410; Tue, 01 Nov 2022 10:03:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opo7g-000516-6W for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 10:03:56 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e75f2d1-59cc-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 11:03:55 +0100 (CET) Received: by mail-ej1-x62b.google.com with SMTP id ud5so35788427ejc.4 for ; Tue, 01 Nov 2022 03:03:54 -0700 (PDT) Received: from [192.168.1.93] (adsl-235.109.242.227.tellas.gr. [109.242.227.235]) by smtp.gmail.com with ESMTPSA id c6-20020a056402120600b0045d74aa401fsm4252237edw.60.2022.11.01.03.03.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 03:03:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e75f2d1-59cc-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pLZyi3m4upOobw/vrzl2QEmnc3If0RLESFCBklnfykE=; b=of0y8ico/TkElz8j7a/DqF1Lcp0s/JuPZnqMS0gmmV2q5SOdRvizShcK9IpRLIl9yJ 1XOtGT/wIwW4g8+Ajh6x6DqkFsj0ejlmigKyxRHKH/Khsx2yHgfptMxQwT0Ij5I56Sfd plyLkZqcABasXNMRtofNzv6T9M0ezy6DsGxqEEFsvhzl97kEKlZVbn2OlYR6tn2ftjsL tCSKdVSRITrCZtwKMArotEUWkvlF5a1+Q/QbacfgqAH6zjATyD3PLAoaC3CO3e+EtSf9 RG8TpNOIcNBYKCj+cQAQnM7qDsg7nSooQa+YVK9dxBJ8GqYqkQOylBF+iqfElgu819qp eryg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pLZyi3m4upOobw/vrzl2QEmnc3If0RLESFCBklnfykE=; b=5o+FBgYahWLWmXWePx6D7B9+84tVzNVA1+f1338LS+POwsIxxxNfXWFVyNMiFTpPAN PsFEBjkWWHkQR/a741drCUS86rnZdeITupdc+jAHMg5i+ZQ8seFCWS74gzoOple7xQCc mk+nTpWCwbKl1FEx3gy3OD3ZDboLiziWo0KjdaiV6T9WezXeBbTDAIUvcoECLZdG4i3B +xP6kzBLjLYj4BWWCALoEpi/UCG7p+7C0K+EMAJquq6TSa+qjJ8cHKs4pi99CIvKFx4a byspjNdNyvS+ALopDEv6CoNN6S+mgBXbQYUUomMbLwSMFbLyCKPKq+sG2zj5R4SBcjXB 7UqA== X-Gm-Message-State: ACrzQf0zDbCYH3xi3Z4tUSK7aKETdDMLX7uvLQOW/qGFEee30uvGNBwu NFEVuIaRywIQkTcJEpjCJq4= X-Google-Smtp-Source: AMsMyM6GHVGZaP6VAV7CT6oJmlkhOYz1A3Kc8V+53SX6rkcJB+AEA8lTU3yTW0fta/aCOgEZeHPNBw== X-Received: by 2002:a17:907:2c47:b0:7a4:7673:d6ee with SMTP id hf7-20020a1709072c4700b007a47673d6eemr17751568ejc.397.1667297034309; Tue, 01 Nov 2022 03:03:54 -0700 (PDT) Message-ID: Date: Tue, 1 Nov 2022 12:03:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [XEN v2 10/12] xen/Arm: GICv3: Use ULL instead of UL for 64bits Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-11-ayankuma@amd.com> From: Xenia Ragiadakou In-Reply-To: <20221031151326.22634-11-ayankuma@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 10/31/22 17:13, Ayan Kumar Halder wrote: > "unsigned long long" is defined as 64 bits on AArch64 and AArch32 > Thus, one should this instead of "unsigned long" which is 32 bits > on AArch32. > > Also use 'PRIx64' instead of 'lx' or 'llx' to print uint64_t. > > Signed-off-by: Ayan Kumar Halder > --- > > Changed from :- > v1 - 1. Replace PRIu64 with PRIx64 so that the values are printed in hex as > desired. > 2. Use ULL in GITS_BASER_RO_MASK as MMIO registers are always unsigned. > > xen/arch/arm/gic-v3-lpi.c | 8 ++++---- > xen/arch/arm/gic-v3.c | 4 ++-- > xen/arch/arm/include/asm/gic_v3_defs.h | 2 +- > xen/arch/arm/include/asm/gic_v3_its.h | 2 +- > xen/arch/arm/vgic-v3-its.c | 17 +++++++++-------- > 5 files changed, 17 insertions(+), 16 deletions(-) > > diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c > index 61d90eb386..9ca74bc321 100644 > --- a/xen/arch/arm/gic-v3-lpi.c > +++ b/xen/arch/arm/gic-v3-lpi.c > @@ -134,7 +134,7 @@ void gicv3_set_redist_address(paddr_t address, unsigned int redist_id) > uint64_t gicv3_get_redist_address(unsigned int cpu, bool use_pta) > { > if ( use_pta ) > - return per_cpu(lpi_redist, cpu).redist_addr & GENMASK(51, 16); > + return per_cpu(lpi_redist, cpu).redist_addr & GENMASK_ULL(51, 16); > else > return per_cpu(lpi_redist, cpu).redist_id << 16; > } > @@ -253,7 +253,7 @@ static int gicv3_lpi_allocate_pendtable(unsigned int cpu) > return -ENOMEM; > > /* Make sure the physical address can be encoded in the register. */ > - if ( virt_to_maddr(pendtable) & ~GENMASK(51, 16) ) > + if ( virt_to_maddr(pendtable) & ~GENMASK_ULL(51, 16) ) > { > xfree(pendtable); > return -ERANGE; > @@ -281,7 +281,7 @@ static int gicv3_lpi_set_pendtable(void __iomem *rdist_base) > return -ENOMEM; > } > > - ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK(51, 16))); > + ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK_ULL(51, 16))); > > val = GIC_BASER_CACHE_RaWaWb << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT; > val |= GIC_BASER_CACHE_SameAsInner << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT; > @@ -329,7 +329,7 @@ static int gicv3_lpi_set_proptable(void __iomem * rdist_base) > return -ENOMEM; > > /* Make sure the physical address can be encoded in the register. */ > - if ( (virt_to_maddr(table) & ~GENMASK(51, 12)) ) > + if ( (virt_to_maddr(table) & ~GENMASK_ULL(51, 12)) ) > { > xfree(table); > return -ERANGE; > diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c > index 8b4b168e78..d8ce0f46c6 100644 > --- a/xen/arch/arm/gic-v3.c > +++ b/xen/arch/arm/gic-v3.c > @@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v) > if ( v == current ) > { > for ( i = 0; i < gicv3_info.nr_lrs; i++ ) > - printk(" HW_LR[%d]=%llx\n", i, gicv3_ich_read_lr(i)); > + printk(" HW_LR[%d]=%" PRIx64 "\n", i, gicv3_ich_read_lr(i)); > } > else > { > for ( i = 0; i < gicv3_info.nr_lrs; i++ ) > - printk(" VCPU_LR[%d]=%llx\n", i, v->arch.gic.v3.lr[i]); > + printk(" VCPU_LR[%d]=%" PRIx64 "\n", i, v->arch.gic.v3.lr[i]); > } > } > > diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h > index 87115f8b25..3a24bd4825 100644 > --- a/xen/arch/arm/include/asm/gic_v3_defs.h > +++ b/xen/arch/arm/include/asm/gic_v3_defs.h > @@ -195,7 +195,7 @@ > > #define ICH_SGI_IRQMODE_SHIFT 40 > #define ICH_SGI_IRQMODE_MASK 0x1 > -#define ICH_SGI_TARGET_OTHERS 1UL > +#define ICH_SGI_TARGET_OTHERS 1ULL > #define ICH_SGI_TARGET_LIST 0 > #define ICH_SGI_IRQ_SHIFT 24 > #define ICH_SGI_IRQ_MASK 0xf > diff --git a/xen/arch/arm/include/asm/gic_v3_its.h b/xen/arch/arm/include/asm/gic_v3_its.h > index fae3f6ecef..5ae50b18ea 100644 > --- a/xen/arch/arm/include/asm/gic_v3_its.h > +++ b/xen/arch/arm/include/asm/gic_v3_its.h > @@ -38,7 +38,7 @@ > #define GITS_PIDR2 GICR_PIDR2 > > /* Register bits */ > -#define GITS_VALID_BIT BIT(63, UL) > +#define GITS_VALID_BIT BIT(63, ULL) > > #define GITS_CTLR_QUIESCENT BIT(31, UL) > #define GITS_CTLR_ENABLE BIT(0, UL) It seems that you forgot GITS_BASER_INDIRECT, that is BIT(62, UL). > diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c > index 58d939b85f..c5e02b2c41 100644 > --- a/xen/arch/arm/vgic-v3-its.c > +++ b/xen/arch/arm/vgic-v3-its.c > @@ -96,13 +96,13 @@ typedef uint16_t coll_table_entry_t; > * in the lowest 5 bits of the word. > */ > typedef uint64_t dev_table_entry_t; > -#define DEV_TABLE_ITT_ADDR(x) ((x) & GENMASK(51, 8)) > +#define DEV_TABLE_ITT_ADDR(x) ((x) & GENMASK_ULL(51, 8)) > #define DEV_TABLE_ITT_SIZE(x) (BIT(((x) & GENMASK(4, 0)) + 1, UL)) > #define DEV_TABLE_ENTRY(addr, bits) \ > (((addr) & GENMASK(51, 8)) | (((bits) - 1) & GENMASK(4, 0))) > > #define GITS_BASER_RO_MASK (GITS_BASER_TYPE_MASK | \ > - (0x1fL << GITS_BASER_ENTRY_SIZE_SHIFT)) > + (0x1ULL << GITS_BASER_ENTRY_SIZE_SHIFT)) You have accidently dropped 'f' from the mask. I noticed that you change to ULL only a part of GENMASK and BIT occurences, I cannot see why. Maybe I m missing sth. Also, with patch [XEN v2 12/12] xen/Arm: GICv3: Enable GICv3 for AArch32, you disable ITS support for arm32, so it seems that those changes in ITS related files are not required (not that do any harm to have). > > /* > * The physical address is encoded slightly differently depending on > @@ -112,10 +112,10 @@ typedef uint64_t dev_table_entry_t; > static paddr_t get_baser_phys_addr(uint64_t reg) > { > if ( reg & BIT(9, UL) ) > - return (reg & GENMASK(47, 16)) | > + return (reg & GENMASK_ULL(47, 16)) | > ((reg & GENMASK(15, 12)) << 36); > else > - return reg & GENMASK(47, 12); > + return reg & GENMASK_ULL(47, 12); > } > > /* Must be called with the ITS lock held. */ > @@ -414,7 +414,7 @@ static int update_lpi_property(struct domain *d, struct pending_irq *p) > if ( !d->arch.vgic.rdists_enabled ) > return 0; > > - addr = d->arch.vgic.rdist_propbase & GENMASK(51, 12); > + addr = d->arch.vgic.rdist_propbase & GENMASK_ULL(51, 12); > > ret = access_guest_memory_by_ipa(d, addr + p->irq - LPI_OFFSET, > &property, sizeof(property), false); > @@ -897,7 +897,8 @@ out_unlock: > > static void dump_its_command(uint64_t *command) > { > - gdprintk(XENLOG_WARNING, " cmd 0x%02lx: %016lx %016lx %016lx %016lx\n", > + gdprintk(XENLOG_WARNING, " cmd 0x%" PRIx64 ": %" PRIx64 > + "%" PRIx64 "%" PRIx64 "%" PRIx64 "\n", > its_cmd_get_command(command), > command[0], command[1], command[2], command[3]); > } > @@ -909,7 +910,7 @@ static void dump_its_command(uint64_t *command) > */ > static int vgic_its_handle_cmds(struct domain *d, struct virt_its *its) > { > - paddr_t addr = its->cbaser & GENMASK(51, 12); > + paddr_t addr = its->cbaser & GENMASK_ULL(51, 12); > uint64_t command[4]; > > ASSERT(spin_is_locked(&its->vcmd_lock)); > @@ -1122,7 +1123,7 @@ read_as_zero_64: > > read_impl_defined: > printk(XENLOG_G_DEBUG > - "%pv: vGITS: RAZ on implementation defined register offset %#04lx\n", > + "%pv: vGITS: RAZ on implementation defined register offset %" PRIx64 "#04llx\n", > v, info->gpa & 0xffff); > *r = 0; > return 1; -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Nov 01 10:59:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 10:59:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433425.686386 (Exim 4.92) (envelope-from ) id 1opozm-00030h-PU; Tue, 01 Nov 2022 10:59:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433425.686386; Tue, 01 Nov 2022 10:59:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opozm-00030a-Ms; Tue, 01 Nov 2022 10:59:50 +0000 Received: by outflank-mailman (input) for mailman id 433425; Tue, 01 Nov 2022 10:59:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opozl-00030U-7i for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 10:59:49 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2085.outbound.protection.outlook.com [40.107.220.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4b981083-59d4-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 11:59:46 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by DM8PR12MB5493.namprd12.prod.outlook.com (2603:10b6:8:3d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Tue, 1 Nov 2022 10:59:42 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 10:59:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b981083-59d4-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YNKTsCdZpfo5JK1kI1PwOlBwdMdzUXS5tcRexGMQ47v6EWL8HCIejc/fHhO6dOmrEbzz7NcIx2LNY/JzuOWNOgGZaXsa6mmT7DteVJbZ8WjL525e+XmlUOTs6T8m2EU/zvaZovXV3c7yS+yqeykShlOJgDTnWPd5gOpUuCABK5BiZPPmRaSDMHdKC1UW67iAlN2AIdn0P9IRnQPZ/KcPQVjnorbnCLZZus9C86YdC6AQVCaPma+DXKA8jxauzrbBGZGVzvBu/EQMERtAZHs5TDiiuMdSMNpWfVKnpgma9xJCvArlruMgi3uVAfhomvewjXGupGtUzhi2ZF5dShHgzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=92MM6Y3qeU8ZLpoKH5/bRJXDBpmw4g92wlw3A2KNwPk=; b=EOxyDz4fiwch+mYXojzjBHnva6kFM9IN2xt/pweTiaYEtd2NLtDS6xxgpvfXRE+aWFiM9jNcSLyn5UKD9Ee5BHHbBxfCtEFV+KsXrLvJVDxu55FlvFnuO3xyA0qPHwi2wL4HA2CyA/Iy5/40YQJkRnJlwTgzjiPV7KDN7lohM42w+adisiyLom3B2jBoVocsOSc4FD0niAgxPNqQHNj4QQm8h/bw9hxdZpDGDJ7eBsHcgdUMXoDmpWh1TPst1KwdkIy/bpKwYy0QWZpk3VYsBfB9uIoVyuKAKnAABSNmqbIUB/eNU1+gQBwE5RqOguOh+6IcEIRAVUJGqoTecTJ8Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=92MM6Y3qeU8ZLpoKH5/bRJXDBpmw4g92wlw3A2KNwPk=; b=kdrQy7kVKb/bj5vVc52xsNZyUrzMip1ousvQMGfxjy/LXz4rSXYOZJFURT41yv0Bcv2/wUqksAjoz0KOZQkJxTU/LU82YzAk81RrZEzQBD9kEKy/mL4ShGKvLu77btxMtASCX0LIaSkqquzH6o7TiRJfIVHQEOtmVsZd9YweyG0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <5b5df2ee-b1b4-bfd8-b6bf-6bf5cb92f557@amd.com> Date: Tue, 1 Nov 2022 10:59:36 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit To: Julien Grall , Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-12-ayankuma@amd.com> <956195e5-0409-1da0-f0db-a0192061d29d@gmail.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0357.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::20) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM8PR12MB5493:EE_ X-MS-Office365-Filtering-Correlation-Id: aa769f0b-4fc4-446e-aa8c-08dabbf82de7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zeSHAq8ODvqLwmuP4N0r7srRlA0MUoqvyu4/uHdvddxZ/Tvp8ANeaH7OlHxjamMiZRoLqLz6zHOxTUL6hgFLweqGvlyRMrBToj/JP65IMpqJi2f289SzEMuSn0/ms5Tl54KgkF5qfvQ38jOYe7taCAj5ttMhiV1H2IfQtWJXdDPQxHSXvYhyMSL/ZAcsL46YlzACl3LajxumHyPVX33Mi+kBgzC49v93PFJn2xervh6Ok6umW+YZEoYCkb+gfXdb1BeUg/dKIhBEwTlSKrp98uX2E1pzhxIqw4Sl+D7VWLGji8hF/LyhSOlpy8XrJ4ycHSnrb/9DTqf4h8556njwOsmg0SIv9qAN0rNp0zP34qUafKSlzfaIQ+fTaTr/47koDR4YRdGUcr3Lz8H6/Ydc9LV+L7Jk4WmtE42abr2ALWG/ERuSMI0PkDGZi+lWTqG3/eb+jexQd43PYOcSxym9JpJpExkYanRnhBZ3ZexmKOdkRyumUzbiqA3QHaa+qC+0ugkGkoCR847Npm+i935VU2s7I81ll4ZrMN+SrQV0UAUFyBOyKouC7HFHg/G26qz4deYIXKWtiZEozkVA8GWD+QPAOn+oBrqxDyF8PE9EpXty55snEQIHIsPx9DYdNz/C42Vu0gMbxq5HCU+tngitxjzeLwubVK95PqqLQ3R468c5BCCbE7++kjXzR1u58cYXnXjFF6QFR0llA5ab2ErfMGTtVlgfl6g0SxlPBPFE45gAF+RoTzvA6PzalWp5JjHBXALHXUAlYw+0v/7GqGtIxy7xAz7ebQrrVnXkDkcQLv5YPMZk4MvqR4GuudEhnzI/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(396003)(346002)(366004)(39860400002)(451199015)(5660300002)(8936002)(36756003)(6512007)(186003)(38100700002)(2906002)(31696002)(2616005)(83380400001)(41300700001)(31686004)(6486002)(478600001)(966005)(6666004)(53546011)(8676002)(26005)(110136005)(4326008)(66556008)(66476007)(316002)(66946007)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVk4SGZRVTQvb0VJeUtCN1FjRS91em5GVUxNejkyWUJzNk00YlBTenNtWG93?= =?utf-8?B?eTBxWjQ3bzJyKytiWkE1NmVzbWovYkZTcWY2a1g3Y01Mb1NXTk1PQzFCcUhJ?= =?utf-8?B?bENQeFhZc3VSYXlzRnJrNy9yYjdoWTljWXcxL3lkbkx5UnhFTUN5b0FCN1ha?= =?utf-8?B?R0F4YXFJWWpOVWR6ZnRJTUxpWndWcmFhUDZTcmRtUFVJbXhaOVJNSzN3UGlB?= =?utf-8?B?VTdVR0RHYUJieHE5dytXYXR2SkZUWWR0cmR5ZlRzdURkVG1QY0FVZHNOUnZs?= =?utf-8?B?OWs2cmRLVUxRZ2w0RUdiOVhjTWI5NDBLM21JTnlIZ2Jac2gzam1FVTc0TWIw?= =?utf-8?B?aDBsR2JZWmVrTDNhSktRaDNaUzdrT3AwQ2hRK1ExT00ydlk3Y0pDNjdub29i?= =?utf-8?B?VW85OGtHcWY4cGwxa0U3enhRa084QjdtRnNlVVhjaXFTZmJKZWZxaEpsRGg0?= =?utf-8?B?NEU5UVhiVzcvQ0dqZDQ3c21mdm1KRkVRSmQ0dzIwcDBhU2NzY2dHYnFFZ2hI?= =?utf-8?B?RlhIN3U4ZDAzdnFsSytyNGlLTFllNHFhSEsyR0Z0TXpBNFZjeFlSUmxadHU4?= =?utf-8?B?RHUvVlJtRVhyMlJZWXZsYzZBSkRpSGVncjFDOXc5OU80b1NITjViSlpxQ0tC?= =?utf-8?B?dXc3V2xRbTJ0UDhUUFpVaFFlVDNiS25FM2dXTkRVZFNEaFpTNnB3K0pES2hk?= =?utf-8?B?L0l3RTBTb21FVlIwOHU5a0xFVlhueXNCT2d0ZzVKMmJCZnQ5VEN0Ry9NU3Ri?= =?utf-8?B?Y0RIa2Y2cVFPbFkxWndMVlhhd21wZitCVDlrUzFEdGRqd1EyTWJneU43NFI0?= =?utf-8?B?cTNhUzFnbm1RV3lyNUoveWh3WFFKbzh3ZDk2MkRRZlZ1TzVJTW8rb3I2OXFx?= =?utf-8?B?TG5wbVBOT3lCc1dGa3FmZjlyMnBGTGx1NHp4OEtvVFRTeTUrZFM3WTFBbk9Q?= =?utf-8?B?ZzQyOW9PNGlXdU03UVJkUjA4UHAwL3BTYWp0bWVMNTdPLzhqNVJmOFpiMVZV?= =?utf-8?B?ZmNEYlpYVmR5bkpVWHJOL0RXeGtBV1NRbUpyOGNDelQ1RlRjSkd6bWc0VTkv?= =?utf-8?B?Umd5NHI2OHhzK1BqY3QvRVRPeUpENjhpSHdESThlMnZRWkhvb01kc09ReGsw?= =?utf-8?B?T3JyVzdaRTJVTTBNVGMzSVRKdFR6NXo2L2FiMU90WUhxSm9SRXpMQXA2bFVR?= =?utf-8?B?M1IwR2hBc0xxczlyb2dEbzJ1WUVoMUFabkF2VlQ0aXdyekg4alNUUW1Mci9W?= =?utf-8?B?V0J3V3JwQmJzVUVGOXZVSHVNblhBSzl4RStHVmhkbmMyaGtTRG4rajJPQVNo?= =?utf-8?B?ZlU4d21iL0xwZ0JvN1poQXczWVpnTG01ci9SSjhGM09KZXpOZmp3c2tFYWVR?= =?utf-8?B?R0VvSWdWcXYxZWtvSkQ2ZERFd3RYSW1ZclpsbWJTK1NvcWZzZkVQZjR2eUxN?= =?utf-8?B?NDVmcTZPYjAzMHhLcTc5a0Q2djhSYisxbzh0VG1NVGZ6ZDRWZU1EZWpUMlRu?= =?utf-8?B?QUQ3djBkOTU3RmtxcUovV2t4QlR0TmVRenhyVXd4QU9vQW14bUNCQ3NEK2M5?= =?utf-8?B?QVhOeEtZejF4cHB4aXhhd25lUit3WlBGZkFsVTFjSUp2QS9nQmpLSzUxRUxw?= =?utf-8?B?STMyRjBRd2owVzA2RWQvZmViQzZWZC9RcXhTcHFPWHpxQnhtK2NGNEFBVUVL?= =?utf-8?B?SzJ5MGNNMmxYNUpMcENwLzREK0lGYWEzNWRScGNoM0F5Z0lOSUxmdy9zSmsy?= =?utf-8?B?UHFjbVVnTWo4cGxFOGdZYjJYRmF2TzQ5ZVl1SC9lYmpMVUZ1aFJ6cnFFOGxm?= =?utf-8?B?MythTlREMVdBY3M4YjVwNk5tenczbGJUTnN6d0RQanhSelBmWjhSdWo1Wmkw?= =?utf-8?B?dGdPUXZvcENtVElZRzhZWldodEVXWGpWY2F4ZXNmSWp6aG9EQVlSSmZ4SzNV?= =?utf-8?B?WGJMRGJWSU5GMjI5T1NZQTZ4eTNJaURwb0VKNWs4RlZuUFN5cEhiT0dndVRE?= =?utf-8?B?a2ZKdGx4M3RXMTZtZFF3SlpWb1pwc0JiWHNCTGMzcmFEVTQvRjJDSExLYWl0?= =?utf-8?B?a3hTRnhWTjRLbi9lZXRhckV5RjJMSHNnSnVqRG5vZzJZNUt2M0FOdVUwdWxi?= =?utf-8?Q?s8eu0K/6kXHFshjYCQnQ2YQwA?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa769f0b-4fc4-446e-aa8c-08dabbf82de7 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 10:59:42.4818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g9l1ZZrMG2AO2gblhv0jksJ5py70ziGGq38huOjkunxErzYySnXrJHOyrr1rxr0NW8FUUYZ4KivrE8Tp49Dz1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5493 On 01/11/2022 09:50, Julien Grall wrote: > Hi, Hi Xenia, Julien, I have few clarifications. > > On 01/11/2022 07:08, Xenia Ragiadakou wrote: >> On 10/31/22 17:13, Ayan Kumar Halder wrote: >>> Defined readq_relaxed()/writeq_relaxed() to read and write 64 bit regs. >>> This uses ldrd/strd instructions. >>> >>> Signed-off-by: Ayan Kumar Halder >>> --- >>> >>> Changes from :- >>> v1 - 1. Use ldrd/strd for readq_relaxed()/writeq_relaxed(). >>> 2. No need to use le64_to_cpu() as the returned byte order is >>> already in cpu >>> endianess. >>> >>>   xen/arch/arm/include/asm/arm32/io.h | 21 +++++++++++++++++++++ >>>   1 file changed, 21 insertions(+) >>> >>> diff --git a/xen/arch/arm/include/asm/arm32/io.h >>> b/xen/arch/arm/include/asm/arm32/io.h >>> index 73a879e9fb..d9d19ad764 100644 >>> --- a/xen/arch/arm/include/asm/arm32/io.h >>> +++ b/xen/arch/arm/include/asm/arm32/io.h >>> @@ -72,6 +72,22 @@ static inline u32 __raw_readl(const volatile void >>> __iomem *addr) >>>           return val; >>>   } >>> +static inline u64 __raw_readq(const volatile void __iomem *addr) Rename this to __raw_readq_nonatomic() >>> +{ >>> +        u64 val; >>> +        asm volatile("ldrd %Q1, %R1, %0" >>> +                     : "+Qo" (*(volatile u64 __force *)addr), >>> +                       "=r" (val)); >>> +        return val; >>> +} >>> + >>> +static inline void __raw_writeq(u64 val, const volatile void >>> __iomem *addr) Rename to __raw_writeq_nonatomic() >>> +{ >>> +    asm volatile("strd %Q1, %R1, %0" >>> +                 : "+Q" (*(volatile u64 __force *)addr) >>> +                 : "r" (val)); >>> +} >>> + >>>   #define __iormb()               rmb() >>>   #define __iowmb()               wmb() >>> @@ -80,17 +96,22 @@ static inline u32 __raw_readl(const volatile >>> void __iomem *addr) >>>                                           __raw_readw(c)); __r; }) >>>   #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \ >>>                                           __raw_readl(c)); __r; }) >>> +#define readq_relaxed(c) ({ u64 __r = le64_to_cpu((__force __le64) \ >>> +                                        __raw_readq(c)); __r; }) >>>   #define writeb_relaxed(v,c)     __raw_writeb(v,c) >>>   #define writew_relaxed(v,c)     __raw_writew((__force u16) >>> cpu_to_le16(v),c) >>>   #define writel_relaxed(v,c)     __raw_writel((__force u32) >>> cpu_to_le32(v),c) >>> +#define writeq_relaxed(v,c)     __raw_writeq((__force u64) >>> cpu_to_le64(v),c) >>>   #define readb(c)                ({ u8  __v = readb_relaxed(c); >>> __iormb(); __v; }) >>>   #define readw(c)                ({ u16 __v = readw_relaxed(c); >>> __iormb(); __v; }) >>>   #define readl(c)                ({ u32 __v = readl_relaxed(c); >>> __iormb(); __v; }) >>> +#define readq(c)                ({ u64 __v = readq_relaxed(c); >>> __iormb(); __v; }) >>>   #define writeb(v,c)             ({ __iowmb(); writeb_relaxed(v,c); }) >>>   #define writew(v,c)             ({ __iowmb(); writew_relaxed(v,c); }) >>>   #define writel(v,c)             ({ __iowmb(); writel_relaxed(v,c); }) >>> +#define writeq(v,c)             ({ __iowmb(); writeq_relaxed(v,c); }) >>>   #endif /* _ARM_ARM32_IO_H */ >> >> AFAIU, ldrd/strd accesses to MMIO are not guaranteed to be 64-bit >> single-copy atomic. So, as Julien suggested, you still need to use a >> different name to reflect this. Yes you are correct, ldrd/strd for system ram are guaranteed to be atomic. Here we are accessing MMIO, so atomicity is not guaranteed. I wasn't very sure if {read/write}*_relaxed are always atomic. Does this look correct ? #define writeq_relaxed(v,c) __raw_writeq_nonatomic((__force u64) cpu_to_le64(v),c) #define readq_relaxed(c) ({ u64 __r = le64_to_cpu((__force __le64) \                                         __raw_readq_nonatomic(c)); __r; }) We can remove "#define readq()/writeq() ..." as they are not used. >> Also, having nested virtualization in mind, since these instructions >> can't be virtualized, maybe it would be better to avoid using them >> for MMIO accesses. Does nested virtualization apply to Arm ? Reading https://wiki.xenproject.org/wiki/Nested_Virtualization_in_Xen , I find two points of interest "Only 64-bit hypervisors are supported at this time." "See below for more details on tested hypervisior / guest combinations, and known issues on Intel CPUs" Thus, I understand that nested virtualization is supported only on x86 machines and that too 64bit only. Thus, it does not apply to AArch32. Let me know if I misunderstood something. > > +1. The previous version was actually using 32-bit access and it is > not clear to me why the new version is using 64-bit access. IMO, I made a mistake in my previous patch of using 2 32bit access for a 64 bit register. ldrd/strd is not supported for AArch32 guests in EL1 mode when they access emulated MMIO region (which traps to EL2). However, ldrd/strd is supported for AArch32 hypervisors running in EL2 mode. Let me know if I am missing something. - Ayan > > Cheers, > From xen-devel-bounces@lists.xenproject.org Tue Nov 01 11:31:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 11:31:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433442.686397 (Exim 4.92) (envelope-from ) id 1oppU9-0007tm-53; Tue, 01 Nov 2022 11:31:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433442.686397; Tue, 01 Nov 2022 11:31:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppU9-0007tf-2I; Tue, 01 Nov 2022 11:31:13 +0000 Received: by outflank-mailman (input) for mailman id 433442; Tue, 01 Nov 2022 11:31:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppU6-0007tX-QA for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 11:31:10 +0000 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [2a00:1450:4864:20::333]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id abc83830-59d8-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 12:31:05 +0100 (CET) Received: by mail-wm1-x333.google.com with SMTP id 5so8689878wmo.1 for ; Tue, 01 Nov 2022 04:31:05 -0700 (PDT) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id h4-20020a05600c350400b003c6b7f5567csm1860167wmq.0.2022.11.01.04.31.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 04:31:03 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 29C4E1FFB7; Tue, 1 Nov 2022 11:31:03 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abc83830-59d8-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=E0Gwj+KeVcMKcKQsIbe887gWwyMnAmJOUQ2Xug3392E=; b=P6PZjdiM+qVmj8ifokapnJ0O85Cpi0z8a3AnsFf/eXW7GRR4YEQg65+f6JuX9HqkTk rGxPOO7Bj3m3WLToJ5inAQKfzrLyS1yLrRw/zeRGFDHJB1xOM5zJT5x85gu3aHHSZZch utntvjrbRln7F5zcQofHW0BMSKRak1FAE0u9/duJxmjPtwbYWmwUkRSQ4OrkVOXWOesl Gj5bVA1jiABEnOB2+mg/XRPqAOcp2M+mXVZsl6FIIfgeXpeHxm7ziDOExU8yXhcxQqLg 6z/sZyTNuc0f6YSFgp3zG0FEoCY+WkMpw+F93YzxCfAJvE1NgkEdYzjoOc1fpqds8eXe z15Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=E0Gwj+KeVcMKcKQsIbe887gWwyMnAmJOUQ2Xug3392E=; b=p/+g3oW73A+mjkDA+YDcOBxuf6Iy7kea5/kIk5wZrGBXzyToFlzEqmngc/OkUs5y9s sQYybJ2Nb6cT81McgpIkcuJNWJCCOR/9/oHQAJKqeUCRjMjRoxvQwvgOkSgm2a9oRgxh ESDq7UFn5TnfiqAVjzCrBhxYDJvl67hfrDyon2SnC8oKnVF8tCa+u+xZKHEuIxUXfoBs GWYIW8Mg2OVb0DjtSi5EKjr17juj163RdQHZgqcP9Z6z+eqHDrv1ibHNyB/7pDgh428x diXcyFtGXUzzPlFPQKINXMIhiZvfs/xb+46TMqS1J1TJNE3MCKL6w9TE/MOZM3TSr93c L17g== X-Gm-Message-State: ACrzQf0lWMFvjEqy5cqYVCHWJEbPajr6yJoD3gCkZtpkwiNVYTpP8SSZ 7qPKKxoCGciibYPc4FMwrFpwvw== X-Google-Smtp-Source: AMsMyM5o0tJvfqIBKDk20jbvxUN/qzPCBYCI8jWf41WcQUsgAdoz5Pi9lOd/2xFvWmS+JJHQAY5UNQ== X-Received: by 2002:a1c:7207:0:b0:3cf:8115:b39a with SMTP id n7-20020a1c7207000000b003cf8115b39amr1287369wmc.80.1667302264398; Tue, 01 Nov 2022 04:31:04 -0700 (PDT) References: <20221015050750.4185-1-vikram.garhwal@amd.com> <20221015050750.4185-10-vikram.garhwal@amd.com> <87pmed1uww.fsf@linaro.org> User-agent: mu4e 1.9.1; emacs 28.2.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: "Garhwal, Vikram" Cc: "qemu-devel@nongnu.org" , "Stabellini, Stefano" , Stefano Stabellini , Anthony Perard , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v1 09/12] accel/xen/xen-all: export xenstore_record_dm_state Date: Tue, 01 Nov 2022 11:29:03 +0000 In-reply-to: Message-ID: <87iljylxmw.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Garhwal, Vikram" writes: > Thanks, Alex, for reviewing this one. I built for all the archs and it wa= s fine. Can you please share more about what > environment builds are breaking? So, I can test the changes for v2. My cross build environment failed: ../../configure' '--disable-docs' '--disable-tools' '--cross-prefix=3Daar= ch64-linux-gnu-' '--enable-xen' '--target-list=3Di386-softmmu,x86_64-softmm= u,arm-softmmu,aarch64-softmmu' '--disable-tpm' On a Debian Bullseye with: 11:30:20 [root@zen:~] # dpkg -l libxen\* Desired=3DUnknown/Install/Remove/Purge/Hold | Status=3DNot/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Tr= ig-pend |/ Err?=3D(none)/Reinst-required (Status,Err: uppercase=3Dbad) ||/ Name Version Architecture Descr= iption +++-=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D-=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D-=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D-=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D ii libxen-dev:arm64 4.14.5+24-g87d90d511c-1 arm64 Publi= c headers and libs for Xen ii libxencall1:amd64 4.14.5+24-g87d90d511c-1 amd64 Xen r= untime library - libxencall ii libxencall1:arm64 4.14.5+24-g87d90d511c-1 arm64 Xen r= untime library - libxencall ii libxendevicemodel1:amd64 4.14.5+24-g87d90d511c-1 amd64 Xen r= untime libraries - libxendevicemodel ii libxendevicemodel1:arm64 4.14.5+24-g87d90d511c-1 arm64 Xen r= untime libraries - libxendevicemodel ii libxenevtchn1:amd64 4.14.5+24-g87d90d511c-1 amd64 Xen r= untime libraries - libxenevtchn ii libxenevtchn1:arm64 4.14.5+24-g87d90d511c-1 arm64 Xen r= untime libraries - libxenevtchn ii libxenforeignmemory1:amd64 4.14.5+24-g87d90d511c-1 amd64 Xen r= untime libraries - libxenforeignmemory ii libxenforeignmemory1:arm64 4.14.5+24-g87d90d511c-1 arm64 Xen r= untime libraries - libxenforeignmemory ii libxengnttab1:amd64 4.14.5+24-g87d90d511c-1 amd64 Xen r= untime libraries - libxengnttab ii libxengnttab1:arm64 4.14.5+24-g87d90d511c-1 arm64 Xen r= untime libraries - libxengnttab ii libxenhypfs1:amd64 4.14.5+24-g87d90d511c-1 amd64 Xen r= untime library - libxenhypfs ii libxenhypfs1:arm64 4.14.5+24-g87d90d511c-1 arm64 Xen r= untime library - libxenhypfs ii libxenmisc4.14:amd64 4.14.5+24-g87d90d511c-1 amd64 Xen r= untime libraries - miscellaneous, versioned ABI ii libxenmisc4.14:arm64 4.14.5+24-g87d90d511c-1 arm64 Xen r= untime libraries - miscellaneous, versioned ABI ii libxenstore3.0:amd64 4.14.5+24-g87d90d511c-1 amd64 Xen r= untime libraries - libxenstore ii libxenstore3.0:arm64 4.14.5+24-g87d90d511c-1 arm64 Xen r= untime libraries - libxenstore ii libxentoolcore1:amd64 4.14.5+24-g87d90d511c-1 amd64 Xen r= untime libraries - libxentoolcore ii libxentoolcore1:arm64 4.14.5+24-g87d90d511c-1 arm64 Xen r= untime libraries - libxentoolcore ii libxentoollog1:amd64 4.14.5+24-g87d90d511c-1 amd64 Xen r= untime libraries - libxentoollog ii libxentoollog1:arm64 4.14.5+24-g87d90d511c-1 arm64 Xen r= untime libraries - libxentoollog But also a bunch of cross builds on the CI system: https://gitlab.com/stsquad/qemu/-/pipelines/677956972/failures > >=20=20 > > Regards, > > Vikram > >=20=20 > > From: Alex Benn=C3=A9e > Date: Thursday, October 27, 2022 at 2:24 AM > To: Garhwal, Vikram > Cc: qemu-devel@nongnu.org , Stabellini, Stefano , Stefano > Stabellini , Anthony Perard , Paul Durrant , > xen-devel@lists.xenproject.org > Subject: Re: [PATCH v1 09/12] accel/xen/xen-all: export xenstore_record_d= m_state > > Vikram Garhwal writes: > >> xenstore_record_dm_state() will also be used in aarch64 xenpv machine. >> >> Signed-off-by: Vikram Garhwal >> Signed-off-by: Stefano Stabellini >> --- >> accel/xen/xen-all.c | 2 +- >> include/hw/xen/xen.h | 2 ++ >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c >> index 69aa7d018b..276625b78b 100644 >> --- a/accel/xen/xen-all.c >> +++ b/accel/xen/xen-all.c >> @@ -100,7 +100,7 @@ void xenstore_store_pv_console_info(int i, Chardev *= chr) >> } >>=20=20 >>=20=20 >> -static void xenstore_record_dm_state(struct xs_handle *xs, const char *= state) >> +void xenstore_record_dm_state(struct xs_handle *xs, const char *state) >> { >> char path[50]; >>=20=20 >> diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h >> index afdf9c436a..31e9538a5c 100644 >> --- a/include/hw/xen/xen.h >> +++ b/include/hw/xen/xen.h >> @@ -9,6 +9,7 @@ >> */ >>=20=20 >> #include "exec/cpu-common.h" >> +#include > > This is breaking a bunch of the builds and generally we try and avoid > adding system includes in headers (apart from osdep.h) for this reason. > In fact there is a comment just above to that fact. > > I think you can just add struct xs_handle to typedefs.h (or maybe just > xen.h) and directly include xenstore.h in xen-all.c following the usual > rules: > > https://qemu.readthedocs.io/en/latest/devel/style.html#include-directiv= es > > It might be worth doing an audit to see what else is including xen.h > needlessly or should be using sysemu/xen.h.=20 > >>=20=20 >> /* xen-machine.c */ >> enum xen_mode { >> @@ -31,5 +32,6 @@ qemu_irq *xen_interrupt_controller_init(void); >> void xenstore_store_pv_console_info(int i, Chardev *chr); >>=20=20 >> void xen_register_framebuffer(struct MemoryRegion *mr); >> +void xenstore_record_dm_state(struct xs_handle *xs, const char *state); >>=20=20 >> #endif /* QEMU_HW_XEN_H */ --=20 Alex Benn=C3=A9e From xen-devel-bounces@lists.xenproject.org Tue Nov 01 11:33:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 11:33:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433447.686409 (Exim 4.92) (envelope-from ) id 1oppVr-000068-LD; Tue, 01 Nov 2022 11:32:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433447.686409; Tue, 01 Nov 2022 11:32:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppVr-00005y-Hu; Tue, 01 Nov 2022 11:32:59 +0000 Received: by outflank-mailman (input) for mailman id 433447; Tue, 01 Nov 2022 11:32:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppVq-00005o-4o for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 11:32:58 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2069.outbound.protection.outlook.com [40.107.223.69]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ee3937a8-59d8-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 12:32:56 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by IA1PR12MB7565.namprd12.prod.outlook.com (2603:10b6:208:42f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 1 Nov 2022 11:32:53 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 11:32:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee3937a8-59d8-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E5WopR3lK93Xynmteh9HeA0LibmW7LQKLoQ4ImnsgT8GIyUqda/2KLdczITAKWAtEvcFi8YFHE3XK/imYUsBvvT3RgBYKPFMf+NRWDZF46MilBYyFdj0kW1jRnCN+xXrNy5D3Yqar31yl7sftrLqXsV51pdbv2RklqsgQndsBGIuP7+sVhqxCwpa1nJjMbWAQWlQGBmSkEWNkw0rlvpfBxsjzRAGV6RgkTglL58iGk2aiP4P52MqlGvwI7nkV8WnCl9tHlQE/SyUQmCQPlwzKCh0Di6ESt4sWhVvsk8m5Y5SCcRkjC560Lsu8tMhVbCC9UH70ZaDS2/vonME4GTpNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MS9+q/e9ffF8uufoLoRlMZ9DGfA/Ym7sA/HZ6k8qIx4=; b=n16RQZEgMHIsnwXwycS7EJ+zoPZ74SfFeD9WEKMnaaXHHF+3GyZUO42N9aFgezajl1YmUCmGcN8zycKsnY4+M4bT0aqXc5Gj3Wi+cBJt8U37zngiexRzv2i2zI5hViPTIzssXx6iUBQTeGmwqYKS4niCOuFL2qzY5JGSNzvIqnX9eW0U2imxjgUtfYfjXKCfxDwc0V6DqP2Y0/3cJNRRgVJIGnjaM9vqz28Tt5/KAy4NtBgAWJQgreuTkTBpSF9vTBDG1ewbKTDvv4hPz/Tnp1QlUZKEy/nsWSvW3sm7jTL8C+yOJVwN/obwOa9DKX2f/HLIo6FXdwnxObyEjkAu6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MS9+q/e9ffF8uufoLoRlMZ9DGfA/Ym7sA/HZ6k8qIx4=; b=V3e+a0qvMhVRLiBvY0/FLvTdkZ90lsF8DXgAOeEtOCaCUlsWh7w/GeqrxBzN3YNGiJDXoLvsnT23+lpGLmcU4I39Qa4J4rS55OL1GUiz6qzxUSiQNhvBNy3xiSGDfkWLNO1FqkPwmgZuSF4YPNwcThEk8Fr+eGOH+O6gaTN8G/A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Tue, 1 Nov 2022 11:32:46 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 02/12] xen/Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32 To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-3-ayankuma@amd.com> <4271ac3e-04bf-7bbb-2db9-3216ac19e778@amd.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0086.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::26) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|IA1PR12MB7565:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c51606c-b442-4453-b2ed-08dabbfcd055 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Wy+8qL3HvbI1oWmudEoyT3PnuR1y9mlAr+BQQwwpYh/l8aEU3wB6OTk/twdt0hh6D9fQWl0xZ8zvqDF+EdwmL4TNDmCcau0NZjW1N6Lttf26TxXvzkzdDcCfa2KRsyV4Fwp4re2EDIuO4R9V1PF0Es5BW4gTVLP29UtkryEdB9yTzICrzWpJDzBcW95p3x13sFhKU2cGNnzO+W4wxsTeXMsm62vhDqHFjrMsj1MQLrtgNfz/bUniZhT9PsgLe1jFyn29I5iicnbMfssSoj+oCG1QHrpLbvlFCCsif6LycOq5AT7HNdVud6IJjDas8s2YiRtf6Icz96PHseYb01nMIuQ8CHmjeNyVHJuxzK8odASYY7I6wtV53o1V1gj6qjFNHN4j05qcJuIHDXuNEZS0AEVCH7BPRNA8MJsFSlqrDUYfh42izfrCXHFLPtvrJSWlzWi3W7Y2KEeRrjh5Mrb0YzEURgW8PSbAKSr+o7pVEOUdOZSW7VOY0QHlFiE3RLOs4u1bRRy+7S8Rghdu5jSi7URLwf1PjoiaB2TZfH47KlyKxaLZeMw7qecO53HVnh9zI+P/cQk7+/T5LnQDVvwZbstXnJc0UfuE7eALJBblOcLbCATyYBrehzs8HDQnTMBwCxTWy2un1HoL/qPuunnZrWjDKqClXea3MAZCpIU9gCsoaC7zShw2pEx/oULNbS85/+8zjz5mTM19riY1pfMB3+DiKKVmaOS2ck0MBJslKaorC0YzY7d88eV5ZWUVMTUAbBEexzDCM/DGCU1/CahUA1f4Dde9WM3MQ4RO+XkmnK/XqNltMGa9lFx8qdussV8a+EU//LHI3Itl7CSvr700smGICW+ZOA0LSeUUrWe9mlr0+v24X5lsh3mbw4HtGMVA X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(39860400002)(136003)(396003)(346002)(451199015)(2906002)(31696002)(38100700002)(36756003)(31686004)(8676002)(83380400001)(26005)(5660300002)(8936002)(2616005)(478600001)(186003)(6666004)(6506007)(6512007)(66556008)(966005)(4326008)(41300700001)(66476007)(45080400002)(316002)(66946007)(6486002)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXZjSWNLUkk4L0o1ZDZySDBXY0hGQnJWMHZUSG8zYWloRW5sbkQvV0pVdmsw?= =?utf-8?B?RzV2MUl3MmlGL2dBOTlyOXBEeXpsNmRTdzJQeEdoSFNMTGMzUEJRdXZMc3lR?= =?utf-8?B?bnZ5M1VnUnFMSlJ2TGF3NUlZZUFvVmJ4STBpV1ZyRmM2MG5LVElsSkUxRGNB?= =?utf-8?B?NDNjbnpoQlRKNU9XQytSSWdYQ25uVEdyZ0ZhcGVOa3JXODJOOGp5VDBzUlA2?= =?utf-8?B?RjFHZG5ueWVpbis0VzRqYjcvSDB6N1Z4NElLbnF0RkF3OEJIdE8yZFBKaEE5?= =?utf-8?B?TzlyV0RDV3lxZEtsaU9NZTRmUjNacG5MWUpUbDF4VG9aZ2pnQUVGbDNmQkhJ?= =?utf-8?B?RmlVWGxOc25VendKMzdIaC9xbStNdWxFc1J6eHA3b2Z6Tm0vVktlQUtLa0k0?= =?utf-8?B?RWVWVzk2YWdUZmJCTXduZlpyRFZwdTdPeUVBOU0vQVdGYUtMMloyOVFuNmlW?= =?utf-8?B?S3FITk1JcGJySWhQZEpObEduMXozUEFOcHRTc3owcGllN09memRLdmIyZGNJ?= =?utf-8?B?VW1LdUZzWnFIajJtMVJ1ZXVPeHQrSEY5T1VFZDF1U0w1cHRieXFBYW1URnl5?= =?utf-8?B?b1RnSGpiZ2lnTERyRnI5WFo2WjNZeG5zRDRGQi9wMElqeG5VSi9BRXk3ZXg4?= =?utf-8?B?TmR3VXlxbjdybXVydVptL2pNRGFyWUxHMjNBMS9vVjZtYml0REM2cEFFUWFu?= =?utf-8?B?L0NUakFIbDQ5d3BrVUJ2VmxXWlhQbEhpd3lCVjBreDh4aXUwLzNJMWJaenZq?= =?utf-8?B?Um5VQjBON050YmFTbjYweUtVdVF4OC9DM1VveUJ6b3VVeE5JSjhUR2VFU2Zu?= =?utf-8?B?WFVrUUZHQnR5OUJKWEg1RUZVY0Z5MklJSEEyM2tJY1pycUl0cHFLRFJ0aU05?= =?utf-8?B?SU9za1BOVXYxem9hTWszTVRKb3k3eGtEUnBkdmJXQzYzY3M3b2hLUjN5WDFF?= =?utf-8?B?czJHcXFvUnB6TElLMXpndUxma3BNUy9nZVQ0RXBuUjZoY3FVL3QxSVpyblVW?= =?utf-8?B?dXZsMGI4dHBBQzVIZkc0eFVVYTV1NWNlaTBIbFhFb01VQUVCTjNEWlFMRFpq?= =?utf-8?B?Nkw5SzNPZmxzNG1TaFNOVnI2OUN5bWtwbmFaQmNhejQrM3lobVVPWnhRajBL?= =?utf-8?B?T0wwamcwM2JmellPU3BSYjdycE5kMU01bHJIcTRsYUc0K0JGU05WbUlSL0Zl?= =?utf-8?B?SEo4Q2w2Tkp2Y2U1NXB0SWgxakRuNnB0Si9NWmRkVDAxODhpWDVzeTNSQ2dC?= =?utf-8?B?dEZldUR5UVk0N201WGVkQU1DSFdFWWpZOFVlZkdDT1BSRXVNTGdoWXJjWjdW?= =?utf-8?B?U3BlQnlpdkY4ckh2TzVqYWtlTHYwTmtIZnNFditwbnNnRHZqT1FYRDYvRVo5?= =?utf-8?B?VnoyTXppUExCakh6MlVRYjBzQllnbE5yYndWV3gzajdLUDJ4SUI5NmVyTzRx?= =?utf-8?B?cEFaSk45MjZyYjFEY3d2SkZEbGh1RW9XSXJSUC9hUVhVL21LczNRNlVlNWU0?= =?utf-8?B?Z0FUQUh1QzliYWltMlZ3cmFVVHA5eW1GcDJZRi94TzFRVkhDQWpzRkJsYjh2?= =?utf-8?B?UWRJUzRhUnU5RDBOMEFaWU1rbUdkc1MxVk8rbmxpR1VWZVNVQmpnZGU4TlpL?= =?utf-8?B?QUtEWEZrbzZWNFpEMFVpU3g1bVhLNjNZSGg1cjVFNVNDZFQydHlHRVo4N0Nz?= =?utf-8?B?VEFrMVhTdXBESmhYbDNxdk83N1JtUGxNdXRrSGpqRnJudXN5RjZUZjJiZm5G?= =?utf-8?B?bC96bjZQSlVpRjFveDExekpWRlZaa1RaZWpIVkV3ZHZZaG5OOUU1Z1dJZzFX?= =?utf-8?B?WGhHQVdJbCs0MXFFVHJoRmU4dFNVdGJEWmNzdWUzRWF6TENrOERSbzVSbE1G?= =?utf-8?B?RGs3TUhKQ2F0VFVQNHM5ZXllR2pRb1ZiT1dNY094Z21nOTNYYmlCNkd5c0Q3?= =?utf-8?B?WnZYOXFLNGlvNnJjU2JiczBEMTFIUDJDcXlaQjZTUjd3NGZaakxoQ2FUQ2M2?= =?utf-8?B?NlNZUmRkclE1OWJmUkRFU1I3UTE0Z0Z0V3VhV1grQTYyQlQzeU1sSCtzLys3?= =?utf-8?B?R1grQ1lEZndvNmN6TUVaWjJyOGQrcFNQQXZJWHFnV1hRME5DY25QZURGaTFs?= =?utf-8?Q?tOklQh3bfOF4MKuWq8lEV9OBm?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c51606c-b442-4453-b2ed-08dabbfcd055 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 11:32:53.0276 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9vKRiigGhhcVJLKmhWejkD7A92521RWXvRCkE7UUrfYtF7pMhyEukFo4z4+vjtGluZ3gtNPZGUXEeMCfIK4yWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7565 On 01/11/2022 08:58, Michal Orzel wrote: > > On 31/10/2022 18:53, Michal Orzel wrote: >> >> Hi Ayan, Hi Michal, >> >> On 31/10/2022 16:13, Ayan Kumar Halder wrote: >>> >>> Refer https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv6.1-rc1%2Fsource%2Farch%2Farm64%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7C0b2a0d1537104c2391d008dabb68eabb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638028356554609284%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RhhL0XWxLJsO7vsP0DoP1QMvUMwGV%2F4FPJwAyvStj4k%3D&reserved=0 \ >> You should not split the link as it is becoming unusable in that form. >> >>> include/asm/cputype.h#L14 , for the macros specific for arm64. >>> >>> Refer https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv6.1-rc1%2Fsource%2Farch%2Farm%2Finclude%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7C0b2a0d1537104c2391d008dabb68eabb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638028356554609284%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gLsNWm5%2BSyy51rn%2BA6H8PrWg8Yv%2BERicyyDjshOd3hc%3D&reserved=0 \ >> Same here. >> >>> asm/cputype.h#L54 , for the macros specific for arm32. >>> >>> MPIDR_LEVEL_SHIFT() differs between 64 and 32 bit. >>> For 64 bit :- >>> >>> aff_lev3 aff_lev2 aff_lev1 aff_lev0 >>> |________|________|________|________|________| >>> 40 32 24 16 8 0 >>> >>> For 32 bit :- >>> >>> aff_lev3 aff_lev2 aff_lev1 aff_lev0 >>> |________|________|________|________| >>> 32 24 16 8 0 >>> >> Where did you get this info from? >> FWICS by looking at ARM ARM DDI 0487I.a D17-6118, >> "Aff3 is not supported in AArch32 state." > We're talking about arm32 and not AArch32. My bad. > Nevertheless, looking at ARM ARM DDI 0406C.d B4-1644, > MPIDR for Armv7A/R also does not have aff3. I was illustrating how the bits are represented in software Refer https://elixir.bootlin.com/linux/latest/source/drivers/irqchip/irq-gic-v3.c#L625 I was trying to depict how "u64 aff " bit representation differs between arm32 and arm64. - Ayan > >> >>> Signed-off-by: Ayan Kumar Halder >>> --- >>> >>> Changes from :- >>> v1 - 1. Rearranged the macro defines so that the common code (between arm32 >>> and arm64) is placed in "arm/include/asm/processor.h". >>> >>> xen/arch/arm/include/asm/arm32/processor.h | 5 +++++ >>> xen/arch/arm/include/asm/arm64/processor.h | 8 ++++++++ >>> xen/arch/arm/include/asm/processor.h | 6 ------ >>> 3 files changed, 13 insertions(+), 6 deletions(-) >>> >>> diff --git a/xen/arch/arm/include/asm/arm32/processor.h b/xen/arch/arm/include/asm/arm32/processor.h >>> index 4e679f3273..82aa7f8d9d 100644 >>> --- a/xen/arch/arm/include/asm/arm32/processor.h >>> +++ b/xen/arch/arm/include/asm/arm32/processor.h >>> @@ -56,6 +56,11 @@ struct cpu_user_regs >>> uint32_t pad1; /* Doubleword-align the user half of the frame */ >>> }; >>> >>> +/* >>> + * Macros to extract affinity level. Picked from kernel >>> + */ >> No need for a multiline comment here and everywhere else. >> >>> +#define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * (level)) >>> + >>> #endif >>> >>> #endif /* __ASM_ARM_ARM32_PROCESSOR_H */ >>> diff --git a/xen/arch/arm/include/asm/arm64/processor.h b/xen/arch/arm/include/asm/arm64/processor.h >>> index c749f80ad9..295483a9dd 100644 >>> --- a/xen/arch/arm/include/asm/arm64/processor.h >>> +++ b/xen/arch/arm/include/asm/arm64/processor.h >>> @@ -84,6 +84,14 @@ struct cpu_user_regs >>> uint64_t sp_el1, elr_el1; >>> }; >>> >>> +/* >>> + * Macros to extract affinity level. picked from kernel >>> + */ >>> +#define MPIDR_LEVEL_BITS_SHIFT 3 >>> + >>> +#define MPIDR_LEVEL_SHIFT(level) \ >>> + (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT) >>> + >> You should move these macros below __DECL_REG as they do not require having it defined. >> >>> #undef __DECL_REG >>> >>> #endif /* __ASSEMBLY__ */ >>> diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h >>> index 1dd81d7d52..ecfb62bbbe 100644 >>> --- a/xen/arch/arm/include/asm/processor.h >>> +++ b/xen/arch/arm/include/asm/processor.h >>> @@ -122,13 +122,7 @@ >>> /* >>> * Macros to extract affinity level. picked from kernel >>> */ >>> - >>> -#define MPIDR_LEVEL_BITS_SHIFT 3 >>> #define MPIDR_LEVEL_MASK ((1 << MPIDR_LEVEL_BITS) - 1) >>> - >>> -#define MPIDR_LEVEL_SHIFT(level) \ >>> - (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT) >>> - >>> #define MPIDR_AFFINITY_LEVEL(mpidr, level) \ >>> (((mpidr) >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK) >>> >>> -- >>> 2.17.1 >>> >>> >> ~Michal >> From xen-devel-bounces@lists.xenproject.org Tue Nov 01 11:58:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 11:58:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433465.686419 (Exim 4.92) (envelope-from ) id 1oppu6-0003Nm-Kf; Tue, 01 Nov 2022 11:58:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433465.686419; Tue, 01 Nov 2022 11:58:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppu6-0003Nf-Hi; Tue, 01 Nov 2022 11:58:02 +0000 Received: by outflank-mailman (input) for mailman id 433465; Tue, 01 Nov 2022 11:58:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppu5-0003NZ-IQ for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 11:58:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppu5-0005SK-4j; Tue, 01 Nov 2022 11:58:01 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.18.67]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oppu4-0004yf-S8; Tue, 01 Nov 2022 11:58:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=BWiPBULFzFkGLvElLtqT+C9OQ+xir0x8h/71rV+M2jc=; b=NtlTHV81a1qLLBTSjxZd3i8Zmf +fI9XvdLFSI5AYramHva0MKChpTXzzDB/btAnBpCE/mYR4WDd1HCqoB6GoA4Yjb1mkVo4XR7PdeKm CLShwX+OuT5x84g3o4cz62kGKbinGioPFJl1iQ8s0uAMsM+YZpVFC58X0HrxcBS/NeKk=; Message-ID: <01a22605-4ae4-d5ba-205c-ab2c1f7d24c2@xen.org> Date: Tue, 1 Nov 2022 11:57:58 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit Content-Language: en-US To: Ayan Kumar Halder , Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-12-ayankuma@amd.com> <956195e5-0409-1da0-f0db-a0192061d29d@gmail.com> <5b5df2ee-b1b4-bfd8-b6bf-6bf5cb92f557@amd.com> From: Julien Grall In-Reply-To: <5b5df2ee-b1b4-bfd8-b6bf-6bf5cb92f557@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Ayan, On 01/11/2022 10:59, Ayan Kumar Halder wrote: > > On 01/11/2022 09:50, Julien Grall wrote: >> Hi, > > Hi Xenia, Julien, > > I have few clarifications. > >> >> On 01/11/2022 07:08, Xenia Ragiadakou wrote: >>> On 10/31/22 17:13, Ayan Kumar Halder wrote: >>>> Defined readq_relaxed()/writeq_relaxed() to read and write 64 bit regs. >>>> This uses ldrd/strd instructions. >>>> >>>> Signed-off-by: Ayan Kumar Halder >>>> --- >>>> >>>> Changes from :- >>>> v1 - 1. Use ldrd/strd for readq_relaxed()/writeq_relaxed(). >>>> 2. No need to use le64_to_cpu() as the returned byte order is >>>> already in cpu >>>> endianess. >>>> >>>>   xen/arch/arm/include/asm/arm32/io.h | 21 +++++++++++++++++++++ >>>>   1 file changed, 21 insertions(+) >>>> >>>> diff --git a/xen/arch/arm/include/asm/arm32/io.h >>>> b/xen/arch/arm/include/asm/arm32/io.h >>>> index 73a879e9fb..d9d19ad764 100644 >>>> --- a/xen/arch/arm/include/asm/arm32/io.h >>>> +++ b/xen/arch/arm/include/asm/arm32/io.h >>>> @@ -72,6 +72,22 @@ static inline u32 __raw_readl(const volatile void >>>> __iomem *addr) >>>>           return val; >>>>   } >>>> +static inline u64 __raw_readq(const volatile void __iomem *addr) > Rename this to __raw_readq_nonatomic() >>>> +{ >>>> +        u64 val; >>>> +        asm volatile("ldrd %Q1, %R1, %0" >>>> +                     : "+Qo" (*(volatile u64 __force *)addr), >>>> +                       "=r" (val)); >>>> +        return val; >>>> +} >>>> + >>>> +static inline void __raw_writeq(u64 val, const volatile void >>>> __iomem *addr) > Rename to __raw_writeq_nonatomic() >>>> +{ >>>> +    asm volatile("strd %Q1, %R1, %0" >>>> +                 : "+Q" (*(volatile u64 __force *)addr) >>>> +                 : "r" (val)); >>>> +} >>>> + >>>>   #define __iormb()               rmb() >>>>   #define __iowmb()               wmb() >>>> @@ -80,17 +96,22 @@ static inline u32 __raw_readl(const volatile >>>> void __iomem *addr) >>>>                                           __raw_readw(c)); __r; }) >>>>   #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \ >>>>                                           __raw_readl(c)); __r; }) >>>> +#define readq_relaxed(c) ({ u64 __r = le64_to_cpu((__force __le64) \ >>>> +                                        __raw_readq(c)); __r; }) >>>>   #define writeb_relaxed(v,c)     __raw_writeb(v,c) >>>>   #define writew_relaxed(v,c)     __raw_writew((__force u16) >>>> cpu_to_le16(v),c) >>>>   #define writel_relaxed(v,c)     __raw_writel((__force u32) >>>> cpu_to_le32(v),c) >>>> +#define writeq_relaxed(v,c)     __raw_writeq((__force u64) >>>> cpu_to_le64(v),c) >>>>   #define readb(c)                ({ u8  __v = readb_relaxed(c); >>>> __iormb(); __v; }) >>>>   #define readw(c)                ({ u16 __v = readw_relaxed(c); >>>> __iormb(); __v; }) >>>>   #define readl(c)                ({ u32 __v = readl_relaxed(c); >>>> __iormb(); __v; }) >>>> +#define readq(c)                ({ u64 __v = readq_relaxed(c); >>>> __iormb(); __v; }) >>>>   #define writeb(v,c)             ({ __iowmb(); writeb_relaxed(v,c); }) >>>>   #define writew(v,c)             ({ __iowmb(); writew_relaxed(v,c); }) >>>>   #define writel(v,c)             ({ __iowmb(); writel_relaxed(v,c); }) >>>> +#define writeq(v,c)             ({ __iowmb(); writeq_relaxed(v,c); }) >>>>   #endif /* _ARM_ARM32_IO_H */ >>> >>> AFAIU, ldrd/strd accesses to MMIO are not guaranteed to be 64-bit >>> single-copy atomic. So, as Julien suggested, you still need to use a >>> different name to reflect this. > > Yes you are correct, ldrd/strd for system ram are guaranteed to be > atomic. Here we are accessing MMIO, so atomicity is not guaranteed. > > I wasn't very sure if {read/write}*_relaxed are always atomic. All the current use are atomic. > #define writeq_relaxed(v,c) __raw_writeq_nonatomic((__force u64) > cpu_to_le64(v),c) > > #define readq_relaxed(c) ({ u64 __r = le64_to_cpu((__force __le64) \ >                                         __raw_readq_nonatomic(c)); __r; }) > > We can remove "#define readq()/writeq() ..." as they are not used. > >>> Also, having nested virtualization in mind, since these instructions >>> can't be virtualized, maybe it would be better to avoid using them >>> for MMIO accesses. > > Does nested virtualization apply to Arm ? This is supported by the Architecture although not implemented in Xen. > > Reading https://wiki.xenproject.org/wiki/Nested_Virtualization_in_Xen , > I find two points of interest > > "Only 64-bit hypervisors are supported at this time." > > "See below for more details on tested hypervisior / guest combinations, > and known issues on Intel CPUs" > > Thus, I understand that nested virtualization is supported only on x86 > machines and that too 64bit only. Thus, it does not apply to AArch32. The wiki page is describing the case where another hypervisor is running on top of Xen. But there is no support necessary in Xen to run it on top of another hypervisor. I haven't looked whether the architecture allows to use nested on 32-bit though... > > Let me know if I misunderstood something. > >> >> +1. The previous version was actually using 32-bit access and it is >> not clear to me why the new version is using 64-bit access. > > IMO, I made a mistake in my previous patch of using 2 32bit access for a > 64 bit register. > > ldrd/strd is not supported for AArch32 guests in EL1 mode when they > access emulated MMIO region (which traps to EL2). > > However, ldrd/strd is supported for AArch32 hypervisors running in EL2 > mode. That's not what I understood from previous discussion [1]. ldrd/strd would be atomic on system RAM but there is no guarantee they would be for MMIO access. I know this was Andre's interpretation. However, the HW architects may have interpreted the same way... So I think we should be convervative in Xen. AFAICT, in the case of GICv3, we don't need the atomicity for the 64-bit registers. Therefore, I would rather prefer if we introduce an helper that do two 32-bit read. Cheers, [1] https://lore.kernel.org/xen-devel/20221027153632.0cf7d004@donnerap.cambridge.arm.com/ -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 01 12:01:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 12:01:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433479.686469 (Exim 4.92) (envelope-from ) id 1oppwy-0005Y4-8R; Tue, 01 Nov 2022 12:01:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433479.686469; Tue, 01 Nov 2022 12:01:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppwx-0005WL-TA; Tue, 01 Nov 2022 12:00:59 +0000 Received: by outflank-mailman (input) for mailman id 433479; Tue, 01 Nov 2022 12:00:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppww-0004y3-By for xen-devel@lists.xen.org; Tue, 01 Nov 2022 12:00:58 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d6d206bc-59dc-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 13:00:56 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppwh-0005XG-N2; Tue, 01 Nov 2022 12:00:43 +0000 Received: from jgross by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oppwh-0005PS-M8; Tue, 01 Nov 2022 12:00:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6d206bc-59dc-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=AH/j94KkZfS2zE+nUaiOPhdMtZkHUY+OiHTksg14QRQ=; b=NHgg/Soi67ZndehJbymFyQ92nv zVxsy5EEJbMUAsxbHUQU9HCSdEX140njp45UTgvFGvxKrq4i0snyiogBozqPO95LhScBX+QJcUzBi 7E1yAZxVBbXvKGTgziG3BPjTFYFyZPxwFET4ENUMmMV6IS8Ds1+oVhF5znP4sVybR8hg=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 414 v2 (CVE-2022-42309) - Xenstore: Guests can crash xenstored Message-Id: Date: Tue, 01 Nov 2022 12:00:43 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-42309 / XSA-414 version 2 Xenstore: Guests can crash xenstored UPDATES IN VERSION 2 ==================== Public release. ISSUE DESCRIPTION ================= Due to a bug in the fix of XSA-115 a malicious guest can cause xenstored to use a wrong pointer during node creation in an error path, resulting in a crash of xenstored or a memory corruption in xenstored causing further damage. Entering the error path can be controlled by the guest e.g. by exceeding the quota value of maximum nodes per domain. IMPACT ====== A malicious guest can cause xenstored to crash, resulting in the inability to create new guests or to change the configuration of running guests. Memory corruption in xenstored or privilege escalation of a guest can't be ruled out. VULNERABLE SYSTEMS ================== All Xen versions with the fix for XSA-115 running the C variant of Xenstore (xenstored or xenstore-stubdom) are vulnerable. Systems using the Ocaml variant of Xenstore (oxenstored) are not vulnerable. MITIGATION ========== Using oxenstored instead of xenstored will avoid the vulnerability. CREDITS ======= This issue was discovered by Julien Grall of Amazon. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa414.patch xen-unstable, Xen 4.16.x - 4.15.x xsa414-4.14.patch Xen 4.14.x - 4.13.x $ sha256sum xsa414* aad9be1af22eec504bf45ff651509be9106e7d4ceb7552befcf3152a17e5efbe xsa414.meta f0683bce3b27dd516367091e845559359c12a193b4e051867b580ea46d58359f xsa414.patch 6eb053052786c738abaf747ea69384fd47525186fa6b6ea247383c7cbfbf3e07 xsa414-4.14.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNg+58MHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZYVAH/1m7ox0cI4jg17wM8ri+cWi0O4bp68MFQKG887DJ 2WZsObdY3SYkUO1YBMg9qu9l5G11+z3UW8KBznafVPweyt35CZJdq6E82SfNc+uf 6/9hmDvXl3fwNJDP9AQBEKMXHPMjRYmIPaniuQdRgnqKSZNUXefbyHZFuHqKabSq cIEJebNHyNWYmC5fulu53YHuX2WHCkUhlcYYLfqbqd+THGt6Aqj+1NxS3QZ/7zBC Jiw1eLjzyOGeARkmobl9FJuQpyB9ZmiyenrJCzFMR3uh0njMnMys95VgWxBH+uBe ooe2vvcoE9EpY8MPmV3UhA+q3JsIis+dkZ2vJQAjaQAomXQ= =NNSk -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa414.meta" Content-Disposition: attachment; filename="xsa414.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MTQsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIw YmU2M2MyNjE1YjI2ODAwMWY3Y2M5YjcyY2UyNWVlZDk1MjczN2RjIiwKICAg ICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICA0MTQKICAgICAgICAg IF0sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQx NC00LjE0LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQog ICAgfSwKICAgICI0LjE0IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAg ICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIwMTZkZTYyNzQ3 YjI2ZWFkNWE1Yzc2M2I2NDBmZThlMjA1Y2QxODJiIiwKICAgICAgICAgICJQ cmVyZXFzIjogWwogICAgICAgICAgICA0MTQKICAgICAgICAgIF0sCiAgICAg ICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQxNC00LjE0LnBh dGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAg ICI0LjE1IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjog ewogICAgICAgICAgIlN0YWJsZVJlZiI6ICI4MTY1ODBhZmRkMTczMGQ0Zjg1 ZjY0NDc3YTI0MmE0MzlhZjFjZGY4IiwKICAgICAgICAgICJQcmVyZXFzIjog WwogICAgICAgICAgICA0MTQKICAgICAgICAgIF0sCiAgICAgICAgICAiUGF0 Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQxNC5wYXRjaCIKICAgICAgICAg IF0KICAgICAgICB9CiAgICAgIH0KICAgIH0sCiAgICAiNC4xNiI6IHsKICAg ICAgIlJlY2lwZXMiOiB7CiAgICAgICAgInhlbiI6IHsKICAgICAgICAgICJT dGFibGVSZWYiOiAiMWJjZTdmYjFmNzAyZGE0ZjdhNzQ5YzZmMTQ1N2VjYjIw YmY3NGZjYSIsCiAgICAgICAgICAiUHJlcmVxcyI6IFsKICAgICAgICAgICAg NDEyLAogICAgICAgICAgICA0MTQKICAgICAgICAgIF0sCiAgICAgICAgICAi UGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQxNC5wYXRjaCIKICAgICAg ICAgIF0KICAgICAgICB9CiAgICAgIH0KICAgIH0sCiAgICAibWFzdGVyIjog ewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAg ICAgIlN0YWJsZVJlZiI6ICJjYzQ3NDdiZThiYTE1N2EzYjMxMDkyMWU5ZWUw N2ZiODU0NWFhMjA2IiwKICAgICAgICAgICJQcmVyZXFzIjogWwogICAgICAg ICAgICA0MTIsCiAgICAgICAgICAgIDQxNAogICAgICAgICAgXSwKICAgICAg ICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhNDE0LnBhdGNoIgog ICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfQogIH0KfQ== --=separator Content-Type: application/octet-stream; name="xsa414.patch" Content-Disposition: attachment; filename="xsa414.patch" Content-Transfer-Encoding: base64 RnJvbTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU3ViamVj dDogdG9vbHMveGVuc3RvcmU6IGNyZWF0ZV9ub2RlOiBEb24ndCBkZWZlciB3 b3JrIHRvIHVuZG8gYW55IGNoYW5nZXMgb24KIGZhaWx1cmUKClhTQS0xMTUg ZXh0ZW5kZWQgZGVzdHJveV9ub2RlKCkgdG8gdXBkYXRlIHRoZSBub2RlIGFj Y291bnRpbmcgZm9yIHRoZQpjb25uZWN0aW9uLiBUaGUgaW1wbGVtZW50YXRp b24gaXMgYXNzdW1pbmcgdGhlIGNvbm5lY3Rpb24gaXMgdGhlIHBhcmVudApv ZiB0aGUgbm9kZSwgaG93ZXZlciBhbGwgdGhlIG5vZGVzIGFyZSBhbGxvY2F0 ZWQgdXNpbmcgYSBzZXBhcmF0ZSBjb250ZXh0CihzZWUgcHJvY2Vzc19tZXNz YWdlKCkpLiBUaGlzIHdpbGwgcmVzdWx0IHRvIGNyYXNoIChvciBjb3JydXB0 KSB4ZW5zdG9yZWQKYXMgdGhlIHBvaW50ZXIgaXMgd3JvbmdseSB1c2VkLgoK SW4gY2FzZSBvZiBhbiBlcnJvciwgYW55IGNoYW5nZXMgdG8gdGhlIGRhdGFi YXNlIG9yIHVwZGF0ZSB0byB0aGUKYWNjb3VudGluZyB3aWxsIG5vdyBiZSBy ZXZlcnRlZCBpbiBjcmVhdGVfbm9kZSgpIGJ5IGNhbGxpbmcgZGlyZWN0bHkK ZGVzdHJveV9ub2RlKCkuIFRoaXMgaGFzIHRoZSBuaWNlIGFkdmFudGFnZSB0 byByZW1vdmUgdGhlIGxvb3AgdG8gdW5zZXQKdGhlIGRlc3RydWN0b3JzIGlu IGNhc2Ugb2Ygc3VjY2Vzcy4KClRha2UgdGhlIG9wcG9ydHVuaXR5IHRvIGZy ZWUgdGhlIG5vZGVzIHJpZ2h0IG5vdyBhcyB0aGV5IGFyZSBub3QKZ29pbmcg dG8gYmUgcmVhY2hhYmxlICh0aGUgZnVuY3Rpb24gcmV0dXJucyBOVUxMKSBh bmQgYXJlIGp1c3Qgd2FzdGluZwpyZXNvdXJjZXMuCgpUaGlzIGlzIFhTQS00 MTQgLyBDVkUtMjAyMi00MjMwOS4KClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3Jh bGwgPGpncmFsbEBhbWF6b24uY29tPgpGaXhlczogMGJmYjIxMDFmMjQzICgi dG9vbHMveGVuc3RvcmU6IGZpeCBub2RlIGFjY291bnRpbmcgYWZ0ZXIgZmFp bGVkIG5vZGUgY3JlYXRpb24iKQpTaWduZWQtb2ZmLWJ5OiBKdWxpZW4gR3Jh bGwgPGpncmFsbEBhbWF6b24uY29tPgpSZXZpZXdlZC1ieTogSnVlcmdlbiBH cm9zcyA8amdyb3NzQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfY29yZS5jCmluZGV4IDg4NjdmOTM0MzFkNC4uYzMwZDE0Y2JmMmFi IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5j CisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTEw ODQsOSArMTA4NCw4IEBAIHN0YXRpYyBzdHJ1Y3Qgbm9kZSAqY29uc3RydWN0 X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0 eCwKIAlyZXR1cm4gTlVMTDsKIH0KIAotc3RhdGljIGludCBkZXN0cm95X25v ZGUodm9pZCAqX25vZGUpCitzdGF0aWMgaW50IGRlc3Ryb3lfbm9kZShzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKm5vZGUpCiB7Ci0J c3RydWN0IG5vZGUgKm5vZGUgPSBfbm9kZTsKIAlUREJfREFUQSBrZXk7CiAK IAlpZiAoc3RyZXEobm9kZS0+bmFtZSwgIi8iKSkKQEAgLTEwOTUsNyArMTA5 NCw3IEBAIHN0YXRpYyBpbnQgZGVzdHJveV9ub2RlKHZvaWQgKl9ub2RlKQog CXNldF90ZGJfa2V5KG5vZGUtPm5hbWUsICZrZXkpOwogCXRkYl9kZWxldGUo dGRiX2N0eCwga2V5KTsKIAotCWRvbWFpbl9lbnRyeV9kZWModGFsbG9jX3Bh cmVudChub2RlKSwgbm9kZSk7CisJZG9tYWluX2VudHJ5X2RlYyhjb25uLCBu b2RlKTsKIAogCXJldHVybiAwOwogfQpAQCAtMTEwNCw3ICsxMTAzLDggQEAg c3RhdGljIHN0cnVjdCBub2RlICpjcmVhdGVfbm9kZShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCQkJCWNvbnN0IGNoYXIg Km5hbWUsCiAJCQkJdm9pZCAqZGF0YSwgdW5zaWduZWQgaW50IGRhdGFsZW4p CiB7Ci0Jc3RydWN0IG5vZGUgKm5vZGUsICppOworCXN0cnVjdCBub2RlICpu b2RlLCAqaSwgKmo7CisJaW50IHJldDsKIAogCW5vZGUgPSBjb25zdHJ1Y3Rf bm9kZShjb25uLCBjdHgsIG5hbWUpOwogCWlmICghbm9kZSkKQEAgLTExMjYs MjMgKzExMjYsNDAgQEAgc3RhdGljIHN0cnVjdCBub2RlICpjcmVhdGVfbm9k ZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAog CQkvKiBpLT5wYXJlbnQgaXMgc2V0IGZvciBlYWNoIG5ldyBub2RlLCBzbyBj aGVjayBxdW90YS4gKi8KIAkJaWYgKGktPnBhcmVudCAmJgogCQkgICAgZG9t YWluX2VudHJ5KGNvbm4pID49IHF1b3RhX25iX2VudHJ5X3Blcl9kb21haW4p IHsKLQkJCWVycm5vID0gRU5PU1BDOwotCQkJcmV0dXJuIE5VTEw7CisJCQly ZXQgPSBFTk9TUEM7CisJCQlnb3RvIGVycjsKIAkJfQotCQlpZiAod3JpdGVf bm9kZShjb25uLCBpLCBmYWxzZSkpCi0JCQlyZXR1cm4gTlVMTDsKIAotCQkv KiBBY2NvdW50IGZvciBuZXcgbm9kZSwgc2V0IGRlc3RydWN0b3IgZm9yIGVy cm9yIGNhc2UuICovCi0JCWlmIChpLT5wYXJlbnQpIHsKKwkJcmV0ID0gd3Jp dGVfbm9kZShjb25uLCBpLCBmYWxzZSk7CisJCWlmIChyZXQpCisJCQlnb3Rv IGVycjsKKworCQkvKiBBY2NvdW50IGZvciBuZXcgbm9kZSAqLworCQlpZiAo aS0+cGFyZW50KQogCQkJZG9tYWluX2VudHJ5X2luYyhjb25uLCBpKTsKLQkJ CXRhbGxvY19zZXRfZGVzdHJ1Y3RvcihpLCBkZXN0cm95X25vZGUpOwotCQl9 CiAJfQogCi0JLyogT0ssIG5vdyByZW1vdmUgZGVzdHJ1Y3RvcnMgc28gdGhl eSBzdGF5IGFyb3VuZCAqLwotCWZvciAoaSA9IG5vZGU7IGktPnBhcmVudDsg aSA9IGktPnBhcmVudCkKLQkJdGFsbG9jX3NldF9kZXN0cnVjdG9yKGksIE5V TEwpOwogCXJldHVybiBub2RlOworCitlcnI6CisJLyoKKwkgKiBXZSBmYWls ZWQgdG8gdXBkYXRlIFREQiBmb3Igc29tZSBvZiB0aGUgbm9kZXMuIFVuZG8g YW55IHdvcmsgdGhhdAorCSAqIGhhdmUgYWxyZWFkeSBiZWVuIGRvbmUuCisJ ICovCisJZm9yIChqID0gbm9kZTsgaiAhPSBpOyBqID0gai0+cGFyZW50KQor CQlkZXN0cm95X25vZGUoY29ubiwgaik7CisKKwkvKiBXZSBkb24ndCBuZWVk IHRvIGtlZXAgdGhlIG5vZGVzIGFyb3VuZCwgc28gZnJlZSB0aGVtLiAqLwor CWkgPSBub2RlOworCXdoaWxlIChpKSB7CisJCWogPSBpOworCQlpID0gaS0+ cGFyZW50OworCQl0YWxsb2NfZnJlZShqKTsKKwl9CisKKwllcnJubyA9IHJl dDsKKworCXJldHVybiBOVUxMOwogfQogCiAvKiBwYXRoLCBkYXRhLi4uICov Cg== --=separator Content-Type: application/octet-stream; name="xsa414-4.14.patch" Content-Disposition: attachment; filename="xsa414-4.14.patch" Content-Transfer-Encoding: base64 RnJvbTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU3ViamVj dDogdG9vbHMveGVuc3RvcmU6IGNyZWF0ZV9ub2RlOiBEb24ndCBkZWZlciB3 b3JrIHRvIHVuZG8gYW55IGNoYW5nZXMgb24KIGZhaWx1cmUKClhTQS0xMTUg ZXh0ZW5kZWQgZGVzdHJveV9ub2RlKCkgdG8gdXBkYXRlIHRoZSBub2RlIGFj Y291bnRpbmcgZm9yIHRoZQpjb25uZWN0aW9uLiBUaGUgaW1wbGVtZW50YXRp b24gaXMgYXNzdW1pbmcgdGhlIGNvbm5lY3Rpb24gaXMgdGhlIHBhcmVudApv ZiB0aGUgbm9kZSwgaG93ZXZlciBhbGwgdGhlIG5vZGVzIGFyZSBhbGxvY2F0 ZWQgdXNpbmcgYSBzZXBhcmF0ZSBjb250ZXh0CihzZWUgcHJvY2Vzc19tZXNz YWdlKCkpLiBUaGlzIHdpbGwgcmVzdWx0IHRvIGNyYXNoIChvciBjb3JydXB0 KSB4ZW5zdG9yZWQKYXMgdGhlIHBvaW50ZXIgaXMgd3JvbmdseSB1c2VkLgoK SW4gY2FzZSBvZiBhbiBlcnJvciwgYW55IGNoYW5nZXMgdG8gdGhlIGRhdGFi YXNlIG9yIHVwZGF0ZSB0byB0aGUKYWNjb3VudGluZyB3aWxsIG5vdyBiZSBy ZXZlcnRlZCBpbiBjcmVhdGVfbm9kZSgpIGJ5IGNhbGxpbmcgZGlyZWN0bHkK ZGVzdHJveV9ub2RlKCkuIFRoaXMgaGFzIHRoZSBuaWNlIGFkdmFudGFnZSB0 byByZW1vdmUgdGhlIGxvb3AgdG8gdW5zZXQKdGhlIGRlc3RydWN0b3JzIGlu IGNhc2Ugb2Ygc3VjY2Vzcy4KClRha2UgdGhlIG9wcG9ydHVuaXR5IHRvIGZy ZWUgdGhlIG5vZGVzIHJpZ2h0IG5vdyBhcyB0aGV5IGFyZSBub3QKZ29pbmcg dG8gYmUgcmVhY2hhYmxlICh0aGUgZnVuY3Rpb24gcmV0dXJucyBOVUxMKSBh bmQgYXJlIGp1c3Qgd2FzdGluZwpyZXNvdXJjZXMuCgpUaGlzIGlzIFhTQS00 MTQgLyBDVkUtMjAyMi00MjMwOS4KClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3Jh bGwgPGpncmFsbEBhbWF6b24uY29tPgpGaXhlczogMGJmYjIxMDFmMjQzICgi dG9vbHMveGVuc3RvcmU6IGZpeCBub2RlIGFjY291bnRpbmcgYWZ0ZXIgZmFp bGVkIG5vZGUgY3JlYXRpb24iKQpTaWduZWQtb2ZmLWJ5OiBKdWxpZW4gR3Jh bGwgPGpncmFsbEBhbWF6b24uY29tPgpSZXZpZXdlZC1ieTogSnVlcmdlbiBH cm9zcyA8amdyb3NzQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfY29yZS5jCmluZGV4IDFkMDVkMjVhNDg2NC4uNmFmZThjYjU5ZDdl IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5j CisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTk3 Nyw5ICs5NzcsOCBAQCBzdGF0aWMgc3RydWN0IG5vZGUgKmNvbnN0cnVjdF9u b2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgs CiAJcmV0dXJuIE5VTEw7CiB9CiAKLXN0YXRpYyBpbnQgZGVzdHJveV9ub2Rl KHZvaWQgKl9ub2RlKQorc3RhdGljIGludCBkZXN0cm95X25vZGUoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQogewotCXN0 cnVjdCBub2RlICpub2RlID0gX25vZGU7CiAJVERCX0RBVEEga2V5OwogCiAJ aWYgKHN0cmVxKG5vZGUtPm5hbWUsICIvIikpCkBAIC05OTAsNyArOTg5LDcg QEAgc3RhdGljIGludCBkZXN0cm95X25vZGUodm9pZCAqX25vZGUpCiAKIAl0 ZGJfZGVsZXRlKHRkYl9jdHgsIGtleSk7CiAKLQlkb21haW5fZW50cnlfZGVj KHRhbGxvY19wYXJlbnQobm9kZSksIG5vZGUpOworCWRvbWFpbl9lbnRyeV9k ZWMoY29ubiwgbm9kZSk7CiAKIAlyZXR1cm4gMDsKIH0KQEAgLTk5OSw3ICs5 OTgsOCBAQCBzdGF0aWMgc3RydWN0IG5vZGUgKmNyZWF0ZV9ub2RlKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsCiAJCQkJY29u c3QgY2hhciAqbmFtZSwKIAkJCQl2b2lkICpkYXRhLCB1bnNpZ25lZCBpbnQg ZGF0YWxlbikKIHsKLQlzdHJ1Y3Qgbm9kZSAqbm9kZSwgKmk7CisJc3RydWN0 IG5vZGUgKm5vZGUsICppLCAqajsKKwlpbnQgcmV0OwogCiAJbm9kZSA9IGNv bnN0cnVjdF9ub2RlKGNvbm4sIGN0eCwgbmFtZSk7CiAJaWYgKCFub2RlKQpA QCAtMTAyMSwyMyArMTAyMSw0MCBAQCBzdGF0aWMgc3RydWN0IG5vZGUgKmNy ZWF0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lk ICpjdHgsCiAJCS8qIGktPnBhcmVudCBpcyBzZXQgZm9yIGVhY2ggbmV3IG5v ZGUsIHNvIGNoZWNrIHF1b3RhLiAqLwogCQlpZiAoaS0+cGFyZW50ICYmCiAJ CSAgICBkb21haW5fZW50cnkoY29ubikgPj0gcXVvdGFfbmJfZW50cnlfcGVy X2RvbWFpbikgewotCQkJZXJybm8gPSBFTk9TUEM7Ci0JCQlyZXR1cm4gTlVM TDsKKwkJCXJldCA9IEVOT1NQQzsKKwkJCWdvdG8gZXJyOwogCQl9Ci0JCWlm ICh3cml0ZV9ub2RlKGNvbm4sIGksIGZhbHNlKSkKLQkJCXJldHVybiBOVUxM OwogCi0JCS8qIEFjY291bnQgZm9yIG5ldyBub2RlLCBzZXQgZGVzdHJ1Y3Rv ciBmb3IgZXJyb3IgY2FzZS4gKi8KLQkJaWYgKGktPnBhcmVudCkgeworCQly ZXQgPSB3cml0ZV9ub2RlKGNvbm4sIGksIGZhbHNlKTsKKwkJaWYgKHJldCkK KwkJCWdvdG8gZXJyOworCisJCS8qIEFjY291bnQgZm9yIG5ldyBub2RlICov CisJCWlmIChpLT5wYXJlbnQpCiAJCQlkb21haW5fZW50cnlfaW5jKGNvbm4s IGkpOwotCQkJdGFsbG9jX3NldF9kZXN0cnVjdG9yKGksIGRlc3Ryb3lfbm9k ZSk7Ci0JCX0KIAl9CiAKLQkvKiBPSywgbm93IHJlbW92ZSBkZXN0cnVjdG9y cyBzbyB0aGV5IHN0YXkgYXJvdW5kICovCi0JZm9yIChpID0gbm9kZTsgaS0+ cGFyZW50OyBpID0gaS0+cGFyZW50KQotCQl0YWxsb2Nfc2V0X2Rlc3RydWN0 b3IoaSwgTlVMTCk7CiAJcmV0dXJuIG5vZGU7CisKK2VycjoKKwkvKgorCSAq IFdlIGZhaWxlZCB0byB1cGRhdGUgVERCIGZvciBzb21lIG9mIHRoZSBub2Rl cy4gVW5kbyBhbnkgd29yayB0aGF0CisJICogaGF2ZSBhbHJlYWR5IGJlZW4g ZG9uZS4KKwkgKi8KKwlmb3IgKGogPSBub2RlOyBqICE9IGk7IGogPSBqLT5w YXJlbnQpCisJCWRlc3Ryb3lfbm9kZShjb25uLCBqKTsKKworCS8qIFdlIGRv bid0IG5lZWQgdG8ga2VlcCB0aGUgbm9kZXMgYXJvdW5kLCBzbyBmcmVlIHRo ZW0uICovCisJaSA9IG5vZGU7CisJd2hpbGUgKGkpIHsKKwkJaiA9IGk7CisJ CWkgPSBpLT5wYXJlbnQ7CisJCXRhbGxvY19mcmVlKGopOworCX0KKworCWVy cm5vID0gcmV0OworCisJcmV0dXJuIE5VTEw7CiB9CiAKIC8qIHBhdGgsIGRh dGEuLi4gKi8K --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Nov 01 12:01:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 12:01:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433478.686463 (Exim 4.92) (envelope-from ) id 1oppwx-0005Sr-NM; Tue, 01 Nov 2022 12:00:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433478.686463; Tue, 01 Nov 2022 12:00:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppwx-0005SF-Ei; Tue, 01 Nov 2022 12:00:59 +0000 Received: by outflank-mailman (input) for mailman id 433478; Tue, 01 Nov 2022 12:00:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppwv-0004vc-SF for xen-devel@lists.xen.org; Tue, 01 Nov 2022 12:00:58 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d6e218a4-59dc-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 13:00:55 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppwj-0005YG-On; Tue, 01 Nov 2022 12:00:45 +0000 Received: from jgross by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oppwj-0005Sr-O2; Tue, 01 Nov 2022 12:00:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6e218a4-59dc-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=LulF0SjJkPbTMdPOIUhIbTFk50qgFW4z7xiLfy7d2C0=; b=5VdXa1F/bsRS12I2XWPcJY13oK zNgx2hyEW7Cj5F0DQpSZTrpqa0snkIk15RQHCR3JSM4dITRV9MY8WyXI4YILPhmMccdxN1V0QLTDy addMTGCGxOWhwCcnNis0EnQcN7X6BetBfo5qgIhtT5GYUEo3myJl/0nhHu7mVfGF+PVA=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 417 v2 (CVE-2022-42320) - Xenstore: Guests can get access to Xenstore nodes of deleted domains Message-Id: Date: Tue, 01 Nov 2022 12:00:45 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-42320 / XSA-417 version 2 Xenstore: Guests can get access to Xenstore nodes of deleted domains UPDATES IN VERSION 2 ==================== Public release. ISSUE DESCRIPTION ================= Access rights of Xenstore nodes are per domid. When a domain is gone, there might be Xenstore nodes left with access rights containing the domid of the removed domain. This is normally no problem, as those access right entries will be corrected when such a node is written later. There is a small time window when a new domain is created, where the access rights of a past domain with the same domid as the new one will be regarded to be still valid, leading to the new domain being able to get access to a node which was meant to be accessible by the removed domain. For this to happen another domain needs to write the node before the newly created domain is being introduced to Xenstore by dom0. IMPACT ====== In some circumstances, it might be possible for a new guest domain to access resources belonging to a previous domain. The impact would depend on the software in use and the configuration, but might include any of denial of service, information leak, or privilege escalation. VULNERABLE SYSTEMS ================== All versions of Xen are in principle vulnerable. Only systems running the C variant of Xenstore (xenstored or xenstore- stubdom) are vulnerable. Systems using the Ocaml variant of Xenstore (oxenstored) are not vulnerable. Vulnerable systems are only those running software where one domain is granted access to another's xenstore nodes, without complete cleanup of those nodes on domain destruction. No such software is enabled in default configurations of upstream Xen. Therefore upstream Xen, without additional management software (in host or guest(s)), is not vulnerable in the default (host and guest) configuration. MITIGATION ========== Running oxenstored instead of xenstored will avoid the vulnerability. CREDITS ======= This issue was discovered by Jürgen Groß of SUSE. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa417.patch xen-unstable, Xen 4.16.x - 4.13.x $ sha256sum xsa417* 62b37c77cc97374685d1df31da57809ddd6c9ad2272fb3380555e81dc85f0cd8 xsa417.meta b0c3bdc1723ead350c86b5a42f5e28445fa331ba5f463d82385fdaeb80119b30 xsa417.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQE/BAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNg+6gMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZCj8H93lp5U3OwMNzzrurILUGMY/N6rcGnuoWqa91FslA C7PSK+A51TvrODUi7bo3YQ1mImW75NmyasMey7/I78DUdHuRwj4L9XOI+W9J5ePk oSVBja6jUC6LawLxj21DBP1rhufqVnJ0lOsO6rK+v/awJOkANH1nstUksqvxPmKa ESMDudyo4+2wWH/DKizq6FYexyEQ/rlCktWZTQi1T1PXFX5xMOk+dzd+SSxifX/7 BSLc/HdRzNt1UemKtKvw7KJqCys0Sw8EWAwu6vpQCqczNbkM8CmhzapSWc+IyCZ3 RMOxk9OuW8+6/9D0s4oqWJ7lV4UfW1kZ8euPeybEhLXo5w== =Kkzx -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa417.meta" Content-Disposition: attachment; filename="xsa417.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MTcsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIw YmU2M2MyNjE1YjI2ODAwMWY3Y2M5YjcyY2UyNWVlZDk1MjczN2RjIiwKICAg ICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICA0MTQsCiAgICAgICAg ICAgIDQxNSwKICAgICAgICAgICAgMzI2LAogICAgICAgICAgICA0MTYKICAg ICAgICAgIF0sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAg InhzYTQxNy5wYXRjaCIKICAgICAgICAgIF0KICAgICAgICB9CiAgICAgIH0K ICAgIH0sCiAgICAiNC4xNCI6IHsKICAgICAgIlJlY2lwZXMiOiB7CiAgICAg ICAgInhlbiI6IHsKICAgICAgICAgICJTdGFibGVSZWYiOiAiMDE2ZGU2Mjc0 N2IyNmVhZDVhNWM3NjNiNjQwZmU4ZTIwNWNkMTgyYiIsCiAgICAgICAgICAi UHJlcmVxcyI6IFsKICAgICAgICAgICAgNDE0LAogICAgICAgICAgICA0MTUs CiAgICAgICAgICAgIDMyNiwKICAgICAgICAgICAgNDE2CiAgICAgICAgICBd LAogICAgICAgICAgIlBhdGNoZXMiOiBbCiAgICAgICAgICAgICJ4c2E0MTcu cGF0Y2giCiAgICAgICAgICBdCiAgICAgICAgfQogICAgICB9CiAgICB9LAog ICAgIjQuMTUiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4i OiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogIjgxNjU4MGFmZGQxNzMwZDRm ODVmNjQ0NzdhMjQyYTQzOWFmMWNkZjgiLAogICAgICAgICAgIlByZXJlcXMi OiBbCiAgICAgICAgICAgIDQxNCwKICAgICAgICAgICAgNDE1LAogICAgICAg ICAgICAzMjYsCiAgICAgICAgICAgIDQxNgogICAgICAgICAgXSwKICAgICAg ICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhNDE3LnBhdGNoIgog ICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE2 IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAg ICAgICAgIlN0YWJsZVJlZiI6ICIxYmNlN2ZiMWY3MDJkYTRmN2E3NDljNmYx NDU3ZWNiMjBiZjc0ZmNhIiwKICAgICAgICAgICJQcmVyZXFzIjogWwogICAg ICAgICAgICA0MTIsCiAgICAgICAgICAgIDQxNCwKICAgICAgICAgICAgNDE1 LAogICAgICAgICAgICAzMjYsCiAgICAgICAgICAgIDQxNgogICAgICAgICAg XSwKICAgICAgICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhNDE3 LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwK ICAgICJtYXN0ZXIiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4 ZW4iOiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogImNjNDc0N2JlOGJhMTU3 YTNiMzEwOTIxZTllZTA3ZmI4NTQ1YWEyMDYiLAogICAgICAgICAgIlByZXJl cXMiOiBbCiAgICAgICAgICAgIDQxMiwKICAgICAgICAgICAgNDE0LAogICAg ICAgICAgICA0MTUsCiAgICAgICAgICAgIDMyNiwKICAgICAgICAgICAgNDE2 CiAgICAgICAgICBdLAogICAgICAgICAgIlBhdGNoZXMiOiBbCiAgICAgICAg ICAgICJ4c2E0MTcucGF0Y2giCiAgICAgICAgICBdCiAgICAgICAgfQogICAg ICB9CiAgICB9CiAgfQp9 --=separator Content-Type: application/octet-stream; name="xsa417.patch" Content-Disposition: attachment; filename="xsa417.patch" Content-Transfer-Encoding: base64 RnJvbSA2N2Q1ZWNkNjA5YjhmMTIzNDZlYWRiNDBlNTQ3Y2Q3ZTAxZDgyNWRj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGZpeCBjaGVj a2luZyBub2RlIHBlcm1pc3Npb25zCgpUb2RheSBjaGtfZG9tYWluX2dlbmVy YXRpb24oKSBpcyBiZWluZyB1c2VkIHRvIGNoZWNrIHdoZXRoZXIgYSBub2Rl CnBlcm1pc3Npb24gZW50cnkgaXMgc3RpbGwgdmFsaWQgb3Igd2hldGhlciBp dCBpcyByZWZlcnJpbmcgdG8gYSBkb21haW4Kbm8gbG9uZ2VyIGV4aXN0aW5n LiBUaGlzIGlzIGRvbmUgYnkgY29tcGFyaW5nIHRoZSBub2RlJ3MgYW5kIHRo ZQpkb21haW4ncyBnZW5lcmF0aW9uIGNvdW50LgoKSW4gY2FzZSBubyBzdHJ1 Y3QgZG9tYWluIGlzIGV4aXN0aW5nIGZvciBhIGNoZWNrZWQgZG9tYWluLCBi dXQgdGhlCmRvbWFpbiBpdHNlbGYgaXMgdmFsaWQsIGNoa19kb21haW5fZ2Vu ZXJhdGlvbigpIGFzc3VtZXMgaXQgaXMgYmVpbmcKY2FsbGVkIGR1ZSB0byB0 aGUgZmlyc3Qgbm9kZSBjcmVhdGVkIGZvciBhIG5ldyBkb21haW4gYW5kIGl0 IHdpbGwKcmV0dXJuIHN1Y2Nlc3MuCgpUaGlzIG1pZ2h0IGJlIHdyb25nIGlu IGNhc2UgdGhlIGNoZWNrZWQgcGVybWlzc2lvbiBpcyByZWxhdGVkIHRvIGFu Cm9sZCBkb21haW4sIHdoaWNoIGhhcyBqdXN0IGJlZW4gcmVwbGFjZWQgd2l0 aCBhIG5ldyBkb21haW4gdXNpbmcgdGhlCnNhbWUgZG9taWQuCgpGaXggdGhh dCBieSBsZXR0aW5nIGNoa19kb21haW5fZ2VuZXJhdGlvbigpIGZhaWwgaW4g Y2FzZSBhIHN0cnVjdApkb21haW4gaXNuJ3QgZm91bmQuIEluIG9yZGVyIHRv IGNvdmVyIHRoZSBjYXNlIG9mIHRoZSBmaXJzdCBub2RlIGZvcgphIG5ldyBk b21haW4gdHJ5IHRvIGFsbG9jYXRlIHRoZSBuZWVkZWQgc3RydWN0IGRvbWFp biBleHBsaWNpdGx5IHdoZW4KcHJvY2Vzc2luZyB0aGUgcmVsYXRlZCBTRVRf UEVSTVMgY29tbWFuZC4gSW4gY2FzZSBhIHJlZmVyZW5jZWQgZG9tYWluCmlz bid0IGV4aXN0aW5nLCBmbGFnIHRoZSByZWxhdGVkIHBlcm1pc3Npb24gdG8g YmUgaWdub3JlZCByaWdodCBhd2F5LgoKVGhpcyBpcyBYU0EtNDE3IC8gQ1ZF LTIwMjItNDIzMjAuCgpSZXBvcnRlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdy b3NzQHN1c2UuY29tPgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxq Z3Jvc3NAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpn cmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5jCmluZGV4IDY2YmJlYWY2YmZiMC4uYTBjMTc2ZmEyMDNlIDEwMDY0 NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBi L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTE3NTMsNiAr MTc1MywxMSBAQCBzdGF0aWMgaW50IGRvX3NldF9wZXJtcyhjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCWlmICgheHNfc3Ry aW5nc190b19wZXJtcyhwZXJtcy5wLCBwZXJtcy5udW0sIHBlcm1zdHIpKQog CQlyZXR1cm4gZXJybm87CiAKKwlpZiAoZG9tYWluX2FsbG9jX3Blcm1yZWZz KCZwZXJtcykgPCAwKQorCQlyZXR1cm4gRU5PTUVNOworCWlmIChwZXJtcy5w WzBdLnBlcm1zICYgWFNfUEVSTV9JR05PUkUpCisJCXJldHVybiBFTk9FTlQ7 CisKIAkvKiBGaXJzdCBhcmcgaXMgbm9kZSBuYW1lLiAqLwogCWlmIChzdHJz dGFydHMoaW4tPmJ1ZmZlciwgIkAiKSkgewogCQlpZiAoc2V0X3Blcm1zX3Nw ZWNpYWwoY29ubiwgaW4tPmJ1ZmZlciwgJnBlcm1zKSkKZGlmZiAtLWdpdCBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYwppbmRleCBiOWZmNGRlZDgzNjAu Ljk4YjQwMWZkZWMzMCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2RvbWFpbi5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9kb21haW4uYwpAQCAtOTA3LDcgKzkwNyw2IEBAIGludCBkb21haW5fZW50 cnlfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAq bm9kZSkKICAqIGNvdW50ICh1c2VkIGZvciB0ZXN0aW5nIHdoZXRoZXIgYSBu b2RlIHBlcm1pc3Npb24gaXMgb2xkZXIgdGhhbiBhIGRvbWFpbikuCiAgKgog ICogUmV0dXJuIHZhbHVlczoKLSAqIC0xOiBlcnJvcgogICogIDA6IGRvbWFp biBoYXMgaGlnaGVyIGdlbmVyYXRpb24gY291bnQgKGl0IGlzIHlvdW5nZXIg dGhhbiBhIG5vZGUgd2l0aCB0aGUKICAqICAgICBnaXZlbiBjb3VudCksIG9y IGRvbWFpbiBpc24ndCBleGlzdGluZyBhbnkgbG9uZ2VyCiAgKiAgMTogZG9t YWluIGlzIG9sZGVyIHRoYW4gdGhlIG5vZGUKQEAgLTkxNSwyMCArOTE0LDM4 IEBAIGludCBkb21haW5fZW50cnlfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSkKIHN0YXRpYyBpbnQgY2hrX2RvbWFp bl9nZW5lcmF0aW9uKHVuc2lnbmVkIGludCBkb21pZCwgdWludDY0X3QgZ2Vu KQogewogCXN0cnVjdCBkb21haW4gKmQ7Ci0JeGNfZG9taW5mb190IGRvbWlu Zm87CiAKIAlpZiAoIXhjX2hhbmRsZSAmJiBkb21pZCA9PSAwKQogCQlyZXR1 cm4gMTsKIAogCWQgPSBmaW5kX2RvbWFpbl9zdHJ1Y3QoZG9taWQpOwotCWlm IChkKQotCQlyZXR1cm4gKGQtPmdlbmVyYXRpb24gPD0gZ2VuKSA/IDEgOiAw OwogCi0JaWYgKCFnZXRfZG9tYWluX2luZm8oZG9taWQsICZkb21pbmZvKSkK LQkJcmV0dXJuIDA7CisJcmV0dXJuIChkICYmIGQtPmdlbmVyYXRpb24gPD0g Z2VuKSA/IDEgOiAwOworfQogCi0JZCA9IGFsbG9jX2RvbWFpbihOVUxMLCBk b21pZCk7Ci0JcmV0dXJuIGQgPyAxIDogLTE7CisvKgorICogQWxsb2NhdGUg YWxsIG1pc3Npbmcgc3RydWN0IGRvbWFpbiByZWZlcmVuY2VkIGJ5IGEgcGVy bWlzc2lvbiBzZXQuCisgKiBBbnkgcGVybWlzc2lvbiBlbnRyaWVzIGZvciBu b3QgZXhpc3RpbmcgZG9tYWlucyB3aWxsIGJlIG1hcmtlZCB0byBiZQorICog aWdub3JlZC4KKyAqLworaW50IGRvbWFpbl9hbGxvY19wZXJtcmVmcyhzdHJ1 Y3Qgbm9kZV9wZXJtcyAqcGVybXMpCit7CisJdW5zaWduZWQgaW50IGksIGRv bWlkOworCXN0cnVjdCBkb21haW4gKmQ7CisJeGNfZG9taW5mb190IGRvbWlu Zm87CisKKwlmb3IgKGkgPSAwOyBpIDwgcGVybXMtPm51bTsgaSsrKSB7CisJ CWRvbWlkID0gcGVybXMtPnBbaV0uaWQ7CisJCWQgPSBmaW5kX2RvbWFpbl9z dHJ1Y3QoZG9taWQpOworCQlpZiAoIWQpIHsKKwkJCWlmICghZ2V0X2RvbWFp bl9pbmZvKGRvbWlkLCAmZG9taW5mbykpCisJCQkJcGVybXMtPnBbaV0ucGVy bXMgfD0gWFNfUEVSTV9JR05PUkU7CisJCQllbHNlIGlmICghYWxsb2NfZG9t YWluKE5VTEwsIGRvbWlkKSkKKwkJCQlyZXR1cm4gRU5PTUVNOworCQl9CisJ fQorCisJcmV0dXJuIDA7CiB9CiAKIC8qCkBAIC05NDEsOCArOTU4LDYgQEAg aW50IGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwgc3RydWN0IG5vZGUgKm5vZGUpCiAJaW50IHJldDsKIAogCXJl dCA9IGNoa19kb21haW5fZ2VuZXJhdGlvbihub2RlLT5wZXJtcy5wWzBdLmlk LCBub2RlLT5nZW5lcmF0aW9uKTsKLQlpZiAocmV0IDwgMCkKLQkJcmV0dXJu IGVycm5vOwogCiAJLyogSWYgdGhlIG93bmVyIGRvZXNuJ3QgZXhpc3QgYW55 IGxvbmdlciBnaXZlIGl0IHRvIHByaXYgZG9tYWluLiAqLwogCWlmICghcmV0 KSB7CkBAIC05NTksOCArOTc0LDYgQEAgaW50IGRvbWFpbl9hZGp1c3Rfbm9k ZV9wZXJtcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUg Km5vZGUpCiAJCQljb250aW51ZTsKIAkJcmV0ID0gY2hrX2RvbWFpbl9nZW5l cmF0aW9uKG5vZGUtPnBlcm1zLnBbaV0uaWQsCiAJCQkJCSAgICBub2RlLT5n ZW5lcmF0aW9uKTsKLQkJaWYgKHJldCA8IDApCi0JCQlyZXR1cm4gZXJybm87 CiAJCWlmICghcmV0KQogCQkJbm9kZS0+cGVybXMucFtpXS5wZXJtcyB8PSBY U19QRVJNX0lHTk9SRTsKIAl9CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfZG9tYWluLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfZG9tYWluLmgKaW5kZXggMjA5NDQyMTkwOTExLi43ZmUwYTIxZDllNDUg MTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4u aAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgKQEAg LTYzLDYgKzYzLDcgQEAgYm9vbCBkb21haW5faXNfdW5wcml2aWxlZ2VkKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uKTsKIAogLyogUmVtb3ZlIG5vZGUgcGVy bWlzc2lvbnMgZm9yIG5vIGxvbmdlciBleGlzdGluZyBkb21haW5zLiAqLwog aW50IGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwgc3RydWN0IG5vZGUgKm5vZGUpOworaW50IGRvbWFpbl9hbGxv Y19wZXJtcmVmcyhzdHJ1Y3Qgbm9kZV9wZXJtcyAqcGVybXMpOwogCiAvKiBR dW90YSBtYW5pcHVsYXRpb24gKi8KIGludCBkb21haW5fZW50cnlfaW5jKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqKTsK --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Nov 01 12:01:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 12:01:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433486.686547 (Exim 4.92) (envelope-from ) id 1oppx5-0007Ia-Ot; Tue, 01 Nov 2022 12:01:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433486.686547; Tue, 01 Nov 2022 12:01:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppx5-0007DR-2B; Tue, 01 Nov 2022 12:01:07 +0000 Received: by outflank-mailman (input) for mailman id 433486; Tue, 01 Nov 2022 12:01:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppwz-0004vc-Sr for xen-devel@lists.xen.org; Tue, 01 Nov 2022 12:01:02 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d6c52020-59dc-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 13:00:55 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppwi-0005XO-C4; Tue, 01 Nov 2022 12:00:44 +0000 Received: from jgross by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oppwi-0005Qa-B7; Tue, 01 Nov 2022 12:00:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6c52020-59dc-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=P1WSI5ToCUEuNy5hlvA47raF1Y2sdRmq+Wlh4C0fNKw=; b=Pb1hS0308upS676kzKcc1WKhnD /68De2GRULM8HBK1UXtY2eAQ075VzpaV5/DgnuP3SBvnNs08oUZU6aokASjkbmvgTQSJ9DM+p0dU5 uQHCcUBZfBjhlkxOZSEVVozGdznrhXmaaCtorW0SYKGqe+URGlY/o1SBfmRm4HwGVVmg=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 415 v2 (CVE-2022-42310) - Xenstore: Guests can create orphaned Xenstore nodes Message-Id: Date: Tue, 01 Nov 2022 12:00:44 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-42310 / XSA-415 version 2 Xenstore: Guests can create orphaned Xenstore nodes UPDATES IN VERSION 2 ==================== Public release. ISSUE DESCRIPTION ================= By creating multiple nodes inside a transaction resulting in an error, a malicious guest can create orphaned nodes in the Xenstore data base, as the cleanup after the error will not remove all nodes already created. When the transaction is committed after this situation, nodes without a valid parent can be made permanent in the data base. IMPACT ====== A malicious guest can cause inconsistencies in the xenstored data base, resulting in unusual error responses or memory leaks in xenstored. This can finally cause Denial of Service situations or long running error recoveries of xenstored. VULNERABLE SYSTEMS ================== Systems with Xen version 4.9 and newer running the C variant of Xenstore (xenstored or xenstore-stubdom) are vulnerable. Systems using the Ocaml variant of Xenstore (oxenstored) are not vulnerable. MITIGATION ========== Using oxenstored will avoid the vulnerability. CREDITS ======= This issue was discovered by Julien Grall of Amazon. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa415.patch xen-unstable, Xen 4.16.x xsa415-4.15.patch Xen 4.15.x xsa415-4.14.patch Xen 4.14.x - 4.13.x $ sha256sum xsa415* ff973fd3d0af2b45ba46ba74410204a60fcba30b0d0830c591dc827eac9ae484 xsa415.meta bc5b33bbef18c0fb15d6da6760ece9ef7f6f2cfab78664aee533ff717b379e3b xsa415.patch 243e7e35ba94973252a6381977af2cf70774abfd0bfd5d0015179b94c832453e xsa415-4.14.patch 7b18b510b811551025cd2a86d654ee776b5003172ab468e7e86a0c6d892f4629 xsa415-4.15.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNg+6IMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZm88H/inrzV4zw8Po/g59rq1hUrCE/L4KwAemf5ZmWMK8 Unka74TyN2j47wous4EbBstzQQtOvf7GP2OT68qpIlqaZSAGcu+7x6TPx3M8q8kM ZFzqcDYvNye8KrUCNp9pVJIV2Y8b3JLAZXCvxxGK++yECGMjTh5ZkxzdiNK/t9NO +TmhH7CHFzkiO25Ch/8+vlwMs6eH/rKFLUVbEU/ZiD9L/P84xQr1EORhAhDJorx1 SLyprG0BlaCUIA/YbQVEftqHiG0J6ikuBYJGBHyQGVEV/MqSXGCUB/Eee6nzH4fH 1USXmeQ27OMsKwOJXyxFvrCgmKdeTNDcx0KSzSPFrED9rSc= =hu/k -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa415.meta" Content-Disposition: attachment; filename="xsa415.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MTUsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIw YmU2M2MyNjE1YjI2ODAwMWY3Y2M5YjcyY2UyNWVlZDk1MjczN2RjIiwKICAg ICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICA0MTQKICAgICAgICAg IF0sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQx NS00LjE0LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQog ICAgfSwKICAgICI0LjE0IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAg ICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIwMTZkZTYyNzQ3 YjI2ZWFkNWE1Yzc2M2I2NDBmZThlMjA1Y2QxODJiIiwKICAgICAgICAgICJQ cmVyZXFzIjogWwogICAgICAgICAgICA0MTQKICAgICAgICAgIF0sCiAgICAg ICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQxNS00LjE0LnBh dGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAg ICI0LjE1IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjog ewogICAgICAgICAgIlN0YWJsZVJlZiI6ICI4MTY1ODBhZmRkMTczMGQ0Zjg1 ZjY0NDc3YTI0MmE0MzlhZjFjZGY4IiwKICAgICAgICAgICJQcmVyZXFzIjog WwogICAgICAgICAgICA0MTQKICAgICAgICAgIF0sCiAgICAgICAgICAiUGF0 Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQxNS00LjE1LnBhdGNoIgogICAg ICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE2Ijog ewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAg ICAgIlN0YWJsZVJlZiI6ICIxYmNlN2ZiMWY3MDJkYTRmN2E3NDljNmYxNDU3 ZWNiMjBiZjc0ZmNhIiwKICAgICAgICAgICJQcmVyZXFzIjogWwogICAgICAg ICAgICA0MTIsCiAgICAgICAgICAgIDQxNAogICAgICAgICAgXSwKICAgICAg ICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhNDE1LnBhdGNoIgog ICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICJtYXN0 ZXIiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4iOiB7CiAg ICAgICAgICAiU3RhYmxlUmVmIjogImNjNDc0N2JlOGJhMTU3YTNiMzEwOTIx ZTllZTA3ZmI4NTQ1YWEyMDYiLAogICAgICAgICAgIlByZXJlcXMiOiBbCiAg ICAgICAgICAgIDQxMiwKICAgICAgICAgICAgNDE0CiAgICAgICAgICBdLAog ICAgICAgICAgIlBhdGNoZXMiOiBbCiAgICAgICAgICAgICJ4c2E0MTUucGF0 Y2giCiAgICAgICAgICBdCiAgICAgICAgfQogICAgICB9CiAgICB9CiAgfQp9 --=separator Content-Type: application/octet-stream; name="xsa415.patch" Content-Disposition: attachment; filename="xsa415.patch" Content-Transfer-Encoding: base64 RnJvbTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU3ViamVj dDogdG9vbHMveGVuc3RvcmU6IEZhaWwgYSB0cmFuc2FjdGlvbiBpZiBpdCBp cyBub3QgcG9zc2libGUgdG8gY3JlYXRlIGEKIG5vZGUKCkNvbW1pdCBmMmJl YmY3MmM0ZDUgInhlbnN0b3JlOiByZXdvcmsgb2YgdHJhbnNhY3Rpb24gaGFu ZGxpbmciIG1vdmVkCm91dCBmcm9tIGNvcHlpbmcgdGhlIGVudGlyZSBkYXRh YmFzZSBldmVyeXRpbWUgYSBuZXcgdHJhbnNhY3Rpb24gaXMKb3BlbmVkIHRv IHRyYWNrIHRoZSBsaXN0IG9mIG5vZGVzIGNoYW5nZWQuCgpUaGUgY29udGVu dCBvZiBhbGwgdGhlIG5vZGVzIGFjY2Vzc2VkIGR1cmluZyBhIHRyYW5zYWN0 aW9uIHdpbGwgYmUKdGVtcG9yYXJpbHkgc3RvcmVkIGluIFREQiB1c2luZyBh IGRpZmZlcmVudCBrZXkuCgpUaGUgZnVuY3Rpb24gY3JlYXRlX25vZGUoKSBt YXkgd3JpdGUvdXBkYXRlIG11bHRpcGxlIG5vZGVzIGlmIHRoZSBjaGlsZApk b2Vzbid0IGV4aXN0LiBJbiBjYXNlIG9mIGEgZmFpbHVyZSwgdGhlIGZ1bmN0 aW9uIHdpbGwgcmV2ZXJ0IGFueQpjaGFuZ2VzICh0aGlzIGluY2x1ZGUgYW55 IHVwZGF0ZSB0byBUREIpLiBVbmZvcnR1bmF0ZWx5LCB0aGUgZnVuY3Rpb24K d2hpY2ggcmV2ZXJ0cyB0aGUgY2hhbmdlcyAoaS5lLiBkZXN0cm95X25vZGUo KSkgd2lsbCBub3QgdXNlIHRoZSBjb3JyZWN0CmtleSB0byBkZWxldGUgYW55 IHVwZGF0ZSBvciBldmVuIHJlcXVlc3QgdGhlIHRyYW5zYWN0aW9uIHRvIGZh aWwuCgpUaGlzIG1lYW5zIHRoYXQgaWYgYSBjbGllbnQgZGVjaWRlIHRvIGdv IGFoZWFkIHdpdGggY29tbWl0dGluZyB0aGUKdHJhbnNhY3Rpb24sIG9ycGhh biBub2RlcyB3aWxsIGJlIGNyZWF0ZWQgYmVjYXVzZSB0aGV5IHdlcmUgbm90 IGxpbmtlZAp0byBhbiBleGlzdGluZyBub2RlIChjcmVhdGVfbm9kZSgpIHdp bGwgd3JpdGUgdGhlIG5vZGVzIGJhY2t3YXJkcykuCgpPbmNlIHNvbWUgbm9k ZXMgaGF2ZSBiZWVuIHBhcnRpYWxseSB1cGRhdGVkIGluIGEgdHJhbnNhY3Rp b24sIGl0IGlzIG5vdAplYXNpbHkgcG9zc2libGUgdG8gdW5kbyBhbnkgY2hh bmdlcy4gU28gcmF0aGVyIHRoYW4gY29udGludWluZyBhbmQgaGl0CndlaXJk IGlzc3VlIHdoaWxlIGNvbW1pdHRpbmcsIGl0IGlzIG11Y2ggc2FuZXIgdG8g ZmFpbCB0aGUgdHJhbnNhY3Rpb24uCgpUaGlzIHdpbGwgaGF2ZSBhbiBpbXBh Y3Qgb24gYW55IGNsaWVudCB0aGF0IGRlY2lkZXMgdG8gY29tbWl0IGV2ZW4g aWYgaXQKY2FuJ3Qgd3JpdGUgYSBub2RlLiBBbHRob3VnaCwgaXQgaXMgbm90 IGNsZWFyIHdoeSBhIG5vcm1hbCBjbGllbnQgd291bGQKd2FudCB0byBkbyB0 aGF0Li4uCgpMYXN0bHksIHVwZGF0ZSBkZXN0cm95X25vZGUoKSB0byB1c2Ug dGhlIGNvcnJlY3Qga2V5IGZvciBkZWxldGluZyB0aGUKbm9kZS4gUmF0aGVy IHRoYW4gcmVjcmVhdGluZyBpdCAodGhpcyB3aWxsIGFsbG9jYXRlIG1lbW9y eSBhbmQKdGhlcmVmb3JlIGZhaWwpLCBzdGFzaCB0aGUga2V5IGluIHRoZSBz dHJ1Y3R1cmUgbm9kZS4KClRoaXMgaXMgWFNBLTQxNSAvIENWRS0yMDIyLTQy MzEwLgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpv bi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+ClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NA c3VzZS5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMK aW5kZXggYzMwZDE0Y2JmMmFiLi41NWI3OWU0YzAzMmUgMTAwNjQ0Ci0tLSBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtNTYyLDE1ICs1NjIsMTcg QEAgaW50IHdyaXRlX25vZGVfcmF3KHN0cnVjdCBjb25uZWN0aW9uICpjb25u LCBUREJfREFUQSAqa2V5LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIAlyZXR1cm4g MDsKIH0KIAorLyoKKyAqIFdyaXRlIHRoZSBub2RlLiBJZiB0aGUgbm9kZSBp cyB3cml0dGVuLCBjYWxsZXIgY2FuIGZpbmQgdGhlIGtleSB1c2VkIGluCisg KiBub2RlLT5rZXkuIFRoaXMgY2FuIGxhdGVyIGJlIHVzZWQgaWYgdGhlIGNo YW5nZSBuZWVkcyB0byBiZSByZXZlcnRlZC4KKyAqLwogc3RhdGljIGludCB3 cml0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9k ZSAqbm9kZSwKIAkJICAgICAgYm9vbCBub19xdW90YV9jaGVjaykKIHsKLQlU REJfREFUQSBrZXk7Ci0KLQlpZiAoYWNjZXNzX25vZGUoY29ubiwgbm9kZSwg Tk9ERV9BQ0NFU1NfV1JJVEUsICZrZXkpKQorCWlmIChhY2Nlc3Nfbm9kZShj b25uLCBub2RlLCBOT0RFX0FDQ0VTU19XUklURSwgJm5vZGUtPmtleSkpCiAJ CXJldHVybiBlcnJubzsKIAotCXJldHVybiB3cml0ZV9ub2RlX3Jhdyhjb25u LCAma2V5LCBub2RlLCBub19xdW90YV9jaGVjayk7CisJcmV0dXJuIHdyaXRl X25vZGVfcmF3KGNvbm4sICZub2RlLT5rZXksIG5vZGUsIG5vX3F1b3RhX2No ZWNrKTsKIH0KIAogdW5zaWduZWQgaW50IHBlcm1fZm9yX2Nvbm4oc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sCkBAIC0xMDg2LDE2ICsxMDg4LDIxIEBAIHN0 YXRpYyBzdHJ1Y3Qgbm9kZSAqY29uc3RydWN0X25vZGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAogc3RhdGljIGludCBk ZXN0cm95X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlKQogewotCVREQl9EQVRBIGtleTsKLQogCWlmIChzdHJlcShu b2RlLT5uYW1lLCAiLyIpKQogCQljb3JydXB0KE5VTEwsICJEZXN0cm95aW5n IHJvb3Qgbm9kZSEiKTsKIAotCXNldF90ZGJfa2V5KG5vZGUtPm5hbWUsICZr ZXkpOwotCXRkYl9kZWxldGUodGRiX2N0eCwga2V5KTsKKwl0ZGJfZGVsZXRl KHRkYl9jdHgsIG5vZGUtPmtleSk7CiAKIAlkb21haW5fZW50cnlfZGVjKGNv bm4sIG5vZGUpOwogCisJLyoKKwkgKiBJdCBpcyBub3QgcG9zc2libGUgdG8g ZWFzaWx5IHJldmVydCB0aGUgY2hhbmdlcyBpbiBhIHRyYW5zYWN0aW9uLgor CSAqIFNvIGlmIHRoZSBmYWlsdXJlIGhhcHBlbnMgaW4gYSB0cmFuc2FjdGlv biwgbWFyayBpdCBhcyBmYWlsIHRvCisJICogcHJldmVudCBhbnkgY29tbWl0 LgorCSAqLworCWlmICggY29ubi0+dHJhbnNhY3Rpb24gKQorCQlmYWlsX3Ry YW5zYWN0aW9uKGNvbm4tPnRyYW5zYWN0aW9uKTsKKwogCXJldHVybiAwOwog fQogCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29y ZS5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCA3 NDI4MTJhOTc0NjkuLjdkMGZlNzdlNzk4OSAxMDA2NDQKLS0tIGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAorKysgYi90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfY29yZS5oCkBAIC0xNTUsNiArMTU1LDggQEAgc3RydWN0 IG5vZGVfcGVybXMgewogCiBzdHJ1Y3Qgbm9kZSB7CiAJY29uc3QgY2hhciAq bmFtZTsKKwkvKiBLZXkgdXNlZCB0byB1cGRhdGUgVERCICovCisJVERCX0RB VEEga2V5OwogCiAJLyogUGFyZW50IChvcHRpb25hbCkgKi8KIAlzdHJ1Y3Qg bm9kZSAqcGFyZW50OwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX3RyYW5zYWN0aW9uLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfdHJhbnNhY3Rpb24uYwppbmRleCBjZDA3ZmIwZjIxOGIuLmZhZjZjOTMw ZTQyYSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3Ry YW5zYWN0aW9uLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3Ry YW5zYWN0aW9uLmMKQEAgLTU4MCw2ICs1ODAsMTEgQEAgdm9pZCB0cmFuc2Fj dGlvbl9lbnRyeV9kZWMoc3RydWN0IHRyYW5zYWN0aW9uICp0cmFucywgdW5z aWduZWQgaW50IGRvbWlkKQogCWxpc3RfYWRkX3RhaWwoJmQtPmxpc3QsICZ0 cmFucy0+Y2hhbmdlZF9kb21haW5zKTsKIH0KIAordm9pZCBmYWlsX3RyYW5z YWN0aW9uKHN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnMpCit7CisJdHJhbnMt PmZhaWwgPSB0cnVlOworfQorCiB2b2lkIGNvbm5fZGVsZXRlX2FsbF90cmFu c2FjdGlvbnMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCiB7CiAJc3RydWN0 IHRyYW5zYWN0aW9uICp0cmFuczsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKaW5kZXggNDNhMTYyYmVhM2YzLi4x NDA2MjczMGUzYzkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF90cmFuc2FjdGlvbi5oCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF90cmFuc2FjdGlvbi5oCkBAIC00Niw2ICs0Niw5IEBAIGludCBhY2Nl c3Nfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUg Km5vZGUsCiBpbnQgdHJhbnNhY3Rpb25fcHJlcGVuZChzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgY29uc3QgY2hhciAqbmFtZSwKICAgICAgICAgICAgICAg ICAgICAgICAgIFREQl9EQVRBICprZXkpOwogCisvKiBNYXJrIHRoZSB0cmFu c2FjdGlvbiBhcyBmYWlsZWQuIFRoaXMgd2lsbCBwcmV2ZW50IGl0IHRvIGJl IGNvbW1pdHRlZC4gKi8KK3ZvaWQgZmFpbF90cmFuc2FjdGlvbihzdHJ1Y3Qg dHJhbnNhY3Rpb24gKnRyYW5zKTsKKwogdm9pZCBjb25uX2RlbGV0ZV9hbGxf dHJhbnNhY3Rpb25zKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsKIGludCBj aGVja190cmFuc2FjdGlvbnMoc3RydWN0IGhhc2h0YWJsZSAqaGFzaCk7CiAK --=separator Content-Type: application/octet-stream; name="xsa415-4.14.patch" Content-Disposition: attachment; filename="xsa415-4.14.patch" Content-Transfer-Encoding: base64 RnJvbTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU3ViamVj dDogdG9vbHMveGVuc3RvcmU6IEZhaWwgYSB0cmFuc2FjdGlvbiBpZiBpdCBp cyBub3QgcG9zc2libGUgdG8gY3JlYXRlIGEKIG5vZGUKCkNvbW1pdCBmMmJl YmY3MmM0ZDUgInhlbnN0b3JlOiByZXdvcmsgb2YgdHJhbnNhY3Rpb24gaGFu ZGxpbmciIG1vdmVkCm91dCBmcm9tIGNvcHlpbmcgdGhlIGVudGlyZSBkYXRh YmFzZSBldmVyeXRpbWUgYSBuZXcgdHJhbnNhY3Rpb24gaXMKb3BlbmVkIHRv IHRyYWNrIHRoZSBsaXN0IG9mIG5vZGVzIGNoYW5nZWQuCgpUaGUgY29udGVu dCBvZiBhbGwgdGhlIG5vZGVzIGFjY2Vzc2VkIGR1cmluZyBhIHRyYW5zYWN0 aW9uIHdpbGwgYmUKdGVtcG9yYXJpbHkgc3RvcmVkIGluIFREQiB1c2luZyBh IGRpZmZlcmVudCBrZXkuCgpUaGUgZnVuY3Rpb24gY3JlYXRlX25vZGUoKSBt YXkgd3JpdGUvdXBkYXRlIG11bHRpcGxlIG5vZGVzIGlmIHRoZSBjaGlsZApk b2Vzbid0IGV4aXN0LiBJbiBjYXNlIG9mIGEgZmFpbHVyZSwgdGhlIGZ1bmN0 aW9uIHdpbGwgcmV2ZXJ0IGFueQpjaGFuZ2VzICh0aGlzIGluY2x1ZGUgYW55 IHVwZGF0ZSB0byBUREIpLiBVbmZvcnR1bmF0ZWx5LCB0aGUgZnVuY3Rpb24K d2hpY2ggcmV2ZXJ0cyB0aGUgY2hhbmdlcyAoaS5lLiBkZXN0cm95X25vZGUo KSkgd2lsbCBub3QgdXNlIHRoZSBjb3JyZWN0CmtleSB0byBkZWxldGUgYW55 IHVwZGF0ZSBvciBldmVuIHJlcXVlc3QgdGhlIHRyYW5zYWN0aW9uIHRvIGZh aWwuCgpUaGlzIG1lYW5zIHRoYXQgaWYgYSBjbGllbnQgZGVjaWRlIHRvIGdv IGFoZWFkIHdpdGggY29tbWl0dGluZyB0aGUKdHJhbnNhY3Rpb24sIG9ycGhh biBub2RlcyB3aWxsIGJlIGNyZWF0ZWQgYmVjYXVzZSB0aGV5IHdlcmUgbm90 IGxpbmtlZAp0byBhbiBleGlzdGluZyBub2RlIChjcmVhdGVfbm9kZSgpIHdp bGwgd3JpdGUgdGhlIG5vZGVzIGJhY2t3YXJkcykuCgpPbmNlIHNvbWUgbm9k ZXMgaGF2ZSBiZWVuIHBhcnRpYWxseSB1cGRhdGVkIGluIGEgdHJhbnNhY3Rp b24sIGl0IGlzIG5vdAplYXNpbHkgcG9zc2libGUgdG8gdW5kbyBhbnkgY2hh bmdlcy4gU28gcmF0aGVyIHRoYW4gY29udGludWluZyBhbmQgaGl0CndlaXJk IGlzc3VlIHdoaWxlIGNvbW1pdHRpbmcsIGl0IGlzIG11Y2ggc2FuZXIgdG8g ZmFpbCB0aGUgdHJhbnNhY3Rpb24uCgpUaGlzIHdpbGwgaGF2ZSBhbiBpbXBh Y3Qgb24gYW55IGNsaWVudCB0aGF0IGRlY2lkZXMgdG8gY29tbWl0IGV2ZW4g aWYgaXQKY2FuJ3Qgd3JpdGUgYSBub2RlLiBBbHRob3VnaCwgaXQgaXMgbm90 IGNsZWFyIHdoeSBhIG5vcm1hbCBjbGllbnQgd291bGQKd2FudCB0byBkbyB0 aGF0Li4uCgpMYXN0bHksIHVwZGF0ZSBkZXN0cm95X25vZGUoKSB0byB1c2Ug dGhlIGNvcnJlY3Qga2V5IGZvciBkZWxldGluZyB0aGUKbm9kZS4gUmF0aGVy IHRoYW4gcmVjcmVhdGluZyBpdCAodGhpcyB3aWxsIGFsbG9jYXRlIG1lbW9y eSBhbmQKdGhlcmVmb3JlIGZhaWwpLCBzdGFzaCB0aGUga2V5IGluIHRoZSBz dHJ1Y3R1cmUgbm9kZS4KClRoaXMgaXMgWFNBLTQxNSAvIENWRS0yMDIyLTQy MzEwLgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpv bi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+ClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NA c3VzZS5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMK aW5kZXggNmFmZThjYjU5ZDdlLi44ZTkxYjU1NDk4NGQgMTAwNjQ0Ci0tLSBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtNDY4LDE1ICs0NjgsMTcg QEAgaW50IHdyaXRlX25vZGVfcmF3KHN0cnVjdCBjb25uZWN0aW9uICpjb25u LCBUREJfREFUQSAqa2V5LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIAlyZXR1cm4g MDsKIH0KIAorLyoKKyAqIFdyaXRlIHRoZSBub2RlLiBJZiB0aGUgbm9kZSBp cyB3cml0dGVuLCBjYWxsZXIgY2FuIGZpbmQgdGhlIGtleSB1c2VkIGluCisg KiBub2RlLT5rZXkuIFRoaXMgY2FuIGxhdGVyIGJlIHVzZWQgaWYgdGhlIGNo YW5nZSBuZWVkcyB0byBiZSByZXZlcnRlZC4KKyAqLwogc3RhdGljIGludCB3 cml0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9k ZSAqbm9kZSwKIAkJICAgICAgYm9vbCBub19xdW90YV9jaGVjaykKIHsKLQlU REJfREFUQSBrZXk7Ci0KLQlpZiAoYWNjZXNzX25vZGUoY29ubiwgbm9kZSwg Tk9ERV9BQ0NFU1NfV1JJVEUsICZrZXkpKQorCWlmIChhY2Nlc3Nfbm9kZShj b25uLCBub2RlLCBOT0RFX0FDQ0VTU19XUklURSwgJm5vZGUtPmtleSkpCiAJ CXJldHVybiBlcnJubzsKIAotCXJldHVybiB3cml0ZV9ub2RlX3Jhdyhjb25u LCAma2V5LCBub2RlLCBub19xdW90YV9jaGVjayk7CisJcmV0dXJuIHdyaXRl X25vZGVfcmF3KGNvbm4sICZub2RlLT5rZXksIG5vZGUsIG5vX3F1b3RhX2No ZWNrKTsKIH0KIAogZW51bSB4c19wZXJtX3R5cGUgcGVybV9mb3JfY29ubihz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKQEAgLTk3OSwxOCArOTgxLDIxIEBA IHN0YXRpYyBzdHJ1Y3Qgbm9kZSAqY29uc3RydWN0X25vZGUoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAogc3RhdGljIGlu dCBkZXN0cm95X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBub2RlICpub2RlKQogewotCVREQl9EQVRBIGtleTsKLQogCWlmIChzdHJl cShub2RlLT5uYW1lLCAiLyIpKQogCQljb3JydXB0KE5VTEwsICJEZXN0cm95 aW5nIHJvb3Qgbm9kZSEiKTsKIAotCWtleS5kcHRyID0gKHZvaWQgKilub2Rl LT5uYW1lOwotCWtleS5kc2l6ZSA9IHN0cmxlbihub2RlLT5uYW1lKTsKLQot CXRkYl9kZWxldGUodGRiX2N0eCwga2V5KTsKKwl0ZGJfZGVsZXRlKHRkYl9j dHgsIG5vZGUtPmtleSk7CiAKIAlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5v ZGUpOwogCisJLyoKKwkgKiBJdCBpcyBub3QgcG9zc2libGUgdG8gZWFzaWx5 IHJldmVydCB0aGUgY2hhbmdlcyBpbiBhIHRyYW5zYWN0aW9uLgorCSAqIFNv IGlmIHRoZSBmYWlsdXJlIGhhcHBlbnMgaW4gYSB0cmFuc2FjdGlvbiwgbWFy ayBpdCBhcyBmYWlsIHRvCisJICogcHJldmVudCBhbnkgY29tbWl0LgorCSAq LworCWlmICggY29ubi0+dHJhbnNhY3Rpb24gKQorCQlmYWlsX3RyYW5zYWN0 aW9uKGNvbm4tPnRyYW5zYWN0aW9uKTsKKwogCXJldHVybiAwOwogfQogCmRp ZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCAxOTZhNmZk MmIwYmUuLjkzNjljNGNiZmQyNiAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfY29yZS5oCkBAIC0xMTksNiArMTE5LDggQEAgc3RydWN0IG5vZGVf cGVybXMgewogCiBzdHJ1Y3Qgbm9kZSB7CiAJY29uc3QgY2hhciAqbmFtZTsK KwkvKiBLZXkgdXNlZCB0byB1cGRhdGUgVERCICovCisJVERCX0RBVEEga2V5 OwogCiAJLyogUGFyZW50IChvcHRpb25hbCkgKi8KIAlzdHJ1Y3Qgbm9kZSAq cGFyZW50OwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X3RyYW5zYWN0aW9uLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJh bnNhY3Rpb24uYwppbmRleCAyODgxZjNiMmU0NGQuLjRmZmExODMxMTEyMCAx MDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0 aW9uLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0 aW9uLmMKQEAgLTU4Miw2ICs1ODIsMTEgQEAgdm9pZCB0cmFuc2FjdGlvbl9l bnRyeV9kZWMoc3RydWN0IHRyYW5zYWN0aW9uICp0cmFucywgdW5zaWduZWQg aW50IGRvbWlkKQogCWxpc3RfYWRkX3RhaWwoJmQtPmxpc3QsICZ0cmFucy0+ Y2hhbmdlZF9kb21haW5zKTsKIH0KIAordm9pZCBmYWlsX3RyYW5zYWN0aW9u KHN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnMpCit7CisJdHJhbnMtPmZhaWwg PSB0cnVlOworfQorCiB2b2lkIGNvbm5fZGVsZXRlX2FsbF90cmFuc2FjdGlv bnMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCiB7CiAJc3RydWN0IHRyYW5z YWN0aW9uICp0cmFuczsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF90cmFuc2FjdGlvbi5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX3RyYW5zYWN0aW9uLmgKaW5kZXggNDNhMTYyYmVhM2YzLi4xNDA2Mjcz MGUzYzkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90 cmFuc2FjdGlvbi5oCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90 cmFuc2FjdGlvbi5oCkBAIC00Niw2ICs0Niw5IEBAIGludCBhY2Nlc3Nfbm9k ZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKm5vZGUs CiBpbnQgdHJhbnNhY3Rpb25fcHJlcGVuZChzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgY29uc3QgY2hhciAqbmFtZSwKICAgICAgICAgICAgICAgICAgICAg ICAgIFREQl9EQVRBICprZXkpOwogCisvKiBNYXJrIHRoZSB0cmFuc2FjdGlv biBhcyBmYWlsZWQuIFRoaXMgd2lsbCBwcmV2ZW50IGl0IHRvIGJlIGNvbW1p dHRlZC4gKi8KK3ZvaWQgZmFpbF90cmFuc2FjdGlvbihzdHJ1Y3QgdHJhbnNh Y3Rpb24gKnRyYW5zKTsKKwogdm9pZCBjb25uX2RlbGV0ZV9hbGxfdHJhbnNh Y3Rpb25zKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsKIGludCBjaGVja190 cmFuc2FjdGlvbnMoc3RydWN0IGhhc2h0YWJsZSAqaGFzaCk7CiAK --=separator Content-Type: application/octet-stream; name="xsa415-4.15.patch" Content-Disposition: attachment; filename="xsa415-4.15.patch" Content-Transfer-Encoding: base64 RnJvbTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU3ViamVj dDogdG9vbHMveGVuc3RvcmU6IEZhaWwgYSB0cmFuc2FjdGlvbiBpZiBpdCBp cyBub3QgcG9zc2libGUgdG8gY3JlYXRlIGEKIG5vZGUKCkNvbW1pdCBmMmJl YmY3MmM0ZDUgInhlbnN0b3JlOiByZXdvcmsgb2YgdHJhbnNhY3Rpb24gaGFu ZGxpbmciIG1vdmVkCm91dCBmcm9tIGNvcHlpbmcgdGhlIGVudGlyZSBkYXRh YmFzZSBldmVyeXRpbWUgYSBuZXcgdHJhbnNhY3Rpb24gaXMKb3BlbmVkIHRv IHRyYWNrIHRoZSBsaXN0IG9mIG5vZGVzIGNoYW5nZWQuCgpUaGUgY29udGVu dCBvZiBhbGwgdGhlIG5vZGVzIGFjY2Vzc2VkIGR1cmluZyBhIHRyYW5zYWN0 aW9uIHdpbGwgYmUKdGVtcG9yYXJpbHkgc3RvcmVkIGluIFREQiB1c2luZyBh IGRpZmZlcmVudCBrZXkuCgpUaGUgZnVuY3Rpb24gY3JlYXRlX25vZGUoKSBt YXkgd3JpdGUvdXBkYXRlIG11bHRpcGxlIG5vZGVzIGlmIHRoZSBjaGlsZApk b2Vzbid0IGV4aXN0LiBJbiBjYXNlIG9mIGEgZmFpbHVyZSwgdGhlIGZ1bmN0 aW9uIHdpbGwgcmV2ZXJ0IGFueQpjaGFuZ2VzICh0aGlzIGluY2x1ZGUgYW55 IHVwZGF0ZSB0byBUREIpLiBVbmZvcnR1bmF0ZWx5LCB0aGUgZnVuY3Rpb24K d2hpY2ggcmV2ZXJ0cyB0aGUgY2hhbmdlcyAoaS5lLiBkZXN0cm95X25vZGUo KSkgd2lsbCBub3QgdXNlIHRoZSBjb3JyZWN0CmtleSB0byBkZWxldGUgYW55 IHVwZGF0ZSBvciBldmVuIHJlcXVlc3QgdGhlIHRyYW5zYWN0aW9uIHRvIGZh aWwuCgpUaGlzIG1lYW5zIHRoYXQgaWYgYSBjbGllbnQgZGVjaWRlIHRvIGdv IGFoZWFkIHdpdGggY29tbWl0dGluZyB0aGUKdHJhbnNhY3Rpb24sIG9ycGhh biBub2RlcyB3aWxsIGJlIGNyZWF0ZWQgYmVjYXVzZSB0aGV5IHdlcmUgbm90 IGxpbmtlZAp0byBhbiBleGlzdGluZyBub2RlIChjcmVhdGVfbm9kZSgpIHdp bGwgd3JpdGUgdGhlIG5vZGVzIGJhY2t3YXJkcykuCgpPbmNlIHNvbWUgbm9k ZXMgaGF2ZSBiZWVuIHBhcnRpYWxseSB1cGRhdGVkIGluIGEgdHJhbnNhY3Rp b24sIGl0IGlzIG5vdAplYXNpbHkgcG9zc2libGUgdG8gdW5kbyBhbnkgY2hh bmdlcy4gU28gcmF0aGVyIHRoYW4gY29udGludWluZyBhbmQgaGl0CndlaXJk IGlzc3VlIHdoaWxlIGNvbW1pdHRpbmcsIGl0IGlzIG11Y2ggc2FuZXIgdG8g ZmFpbCB0aGUgdHJhbnNhY3Rpb24uCgpUaGlzIHdpbGwgaGF2ZSBhbiBpbXBh Y3Qgb24gYW55IGNsaWVudCB0aGF0IGRlY2lkZXMgdG8gY29tbWl0IGV2ZW4g aWYgaXQKY2FuJ3Qgd3JpdGUgYSBub2RlLiBBbHRob3VnaCwgaXQgaXMgbm90 IGNsZWFyIHdoeSBhIG5vcm1hbCBjbGllbnQgd291bGQKd2FudCB0byBkbyB0 aGF0Li4uCgpMYXN0bHksIHVwZGF0ZSBkZXN0cm95X25vZGUoKSB0byB1c2Ug dGhlIGNvcnJlY3Qga2V5IGZvciBkZWxldGluZyB0aGUKbm9kZS4gUmF0aGVy IHRoYW4gcmVjcmVhdGluZyBpdCAodGhpcyB3aWxsIGFsbG9jYXRlIG1lbW9y eSBhbmQKdGhlcmVmb3JlIGZhaWwpLCBzdGFzaCB0aGUga2V5IGluIHRoZSBz dHJ1Y3R1cmUgbm9kZS4KClRoaXMgaXMgWFNBLTQxNSAvIENWRS0yMDIyLTQy MzEwLgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpv bi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+ClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NA c3VzZS5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMK aW5kZXggYTAwYzQ5ZTQwNGExLi5iMjhjMmM2NmI1M2IgMTAwNjQ0Ci0tLSBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtNTMxLDE1ICs1MzEsMTcg QEAgaW50IHdyaXRlX25vZGVfcmF3KHN0cnVjdCBjb25uZWN0aW9uICpjb25u LCBUREJfREFUQSAqa2V5LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIAlyZXR1cm4g MDsKIH0KIAorLyoKKyAqIFdyaXRlIHRoZSBub2RlLiBJZiB0aGUgbm9kZSBp cyB3cml0dGVuLCBjYWxsZXIgY2FuIGZpbmQgdGhlIGtleSB1c2VkIGluCisg KiBub2RlLT5rZXkuIFRoaXMgY2FuIGxhdGVyIGJlIHVzZWQgaWYgdGhlIGNo YW5nZSBuZWVkcyB0byBiZSByZXZlcnRlZC4KKyAqLwogc3RhdGljIGludCB3 cml0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9k ZSAqbm9kZSwKIAkJICAgICAgYm9vbCBub19xdW90YV9jaGVjaykKIHsKLQlU REJfREFUQSBrZXk7Ci0KLQlpZiAoYWNjZXNzX25vZGUoY29ubiwgbm9kZSwg Tk9ERV9BQ0NFU1NfV1JJVEUsICZrZXkpKQorCWlmIChhY2Nlc3Nfbm9kZShj b25uLCBub2RlLCBOT0RFX0FDQ0VTU19XUklURSwgJm5vZGUtPmtleSkpCiAJ CXJldHVybiBlcnJubzsKIAotCXJldHVybiB3cml0ZV9ub2RlX3Jhdyhjb25u LCAma2V5LCBub2RlLCBub19xdW90YV9jaGVjayk7CisJcmV0dXJuIHdyaXRl X25vZGVfcmF3KGNvbm4sICZub2RlLT5rZXksIG5vZGUsIG5vX3F1b3RhX2No ZWNrKTsKIH0KIAogZW51bSB4c19wZXJtX3R5cGUgcGVybV9mb3JfY29ubihz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKQEAgLTEwNTYsMTYgKzEwNTgsMjEg QEAgc3RhdGljIHN0cnVjdCBub2RlICpjb25zdHJ1Y3Rfbm9kZShzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCiBzdGF0aWMg aW50IGRlc3Ryb3lfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3Ry dWN0IG5vZGUgKm5vZGUpCiB7Ci0JVERCX0RBVEEga2V5OwotCiAJaWYgKHN0 cmVxKG5vZGUtPm5hbWUsICIvIikpCiAJCWNvcnJ1cHQoTlVMTCwgIkRlc3Ry b3lpbmcgcm9vdCBub2RlISIpOwogCi0Jc2V0X3RkYl9rZXkobm9kZS0+bmFt ZSwgJmtleSk7Ci0JdGRiX2RlbGV0ZSh0ZGJfY3R4LCBrZXkpOworCXRkYl9k ZWxldGUodGRiX2N0eCwgbm9kZS0+a2V5KTsKIAogCWRvbWFpbl9lbnRyeV9k ZWMoY29ubiwgbm9kZSk7CiAKKwkvKgorCSAqIEl0IGlzIG5vdCBwb3NzaWJs ZSB0byBlYXNpbHkgcmV2ZXJ0IHRoZSBjaGFuZ2VzIGluIGEgdHJhbnNhY3Rp b24uCisJICogU28gaWYgdGhlIGZhaWx1cmUgaGFwcGVucyBpbiBhIHRyYW5z YWN0aW9uLCBtYXJrIGl0IGFzIGZhaWwgdG8KKwkgKiBwcmV2ZW50IGFueSBj b21taXQuCisJICovCisJaWYgKCBjb25uLT50cmFuc2FjdGlvbiApCisJCWZh aWxfdHJhbnNhY3Rpb24oY29ubi0+dHJhbnNhY3Rpb24pOworCiAJcmV0dXJu IDA7CiB9CiAKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCmlu ZGV4IDBjOWEwOTYxYjU3ZS4uOTAwMzM2YWZhNDI2IDEwMDY0NAotLS0gYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCisrKyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKQEAgLTE0OCw2ICsxNDgsOCBAQCBz dHJ1Y3Qgbm9kZV9wZXJtcyB7CiAKIHN0cnVjdCBub2RlIHsKIAljb25zdCBj aGFyICpuYW1lOworCS8qIEtleSB1c2VkIHRvIHVwZGF0ZSBUREIgKi8KKwlU REJfREFUQSBrZXk7CiAKIAkvKiBQYXJlbnQgKG9wdGlvbmFsKSAqLwogCXN0 cnVjdCBub2RlICpwYXJlbnQ7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4IGNkMDdmYjBmMjE4Yi4uZmFm NmM5MzBlNDJhIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfdHJhbnNhY3Rpb24uYwpAQCAtNTgwLDYgKzU4MCwxMSBAQCB2b2lkIHRy YW5zYWN0aW9uX2VudHJ5X2RlYyhzdHJ1Y3QgdHJhbnNhY3Rpb24gKnRyYW5z LCB1bnNpZ25lZCBpbnQgZG9taWQpCiAJbGlzdF9hZGRfdGFpbCgmZC0+bGlz dCwgJnRyYW5zLT5jaGFuZ2VkX2RvbWFpbnMpOwogfQogCit2b2lkIGZhaWxf dHJhbnNhY3Rpb24oc3RydWN0IHRyYW5zYWN0aW9uICp0cmFucykKK3sKKwl0 cmFucy0+ZmFpbCA9IHRydWU7Cit9CisKIHZvaWQgY29ubl9kZWxldGVfYWxs X3RyYW5zYWN0aW9ucyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubikKIHsKIAlz dHJ1Y3QgdHJhbnNhY3Rpb24gKnRyYW5zOwpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmggYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uaAppbmRleCA0M2ExNjJiZWEz ZjMuLjE0MDYyNzMwZTNjOSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKKysrIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKQEAgLTQ2LDYgKzQ2LDkgQEAgaW50 IGFjY2Vzc19ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qg bm9kZSAqbm9kZSwKIGludCB0cmFuc2FjdGlvbl9wcmVwZW5kKHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpuYW1lLAogICAgICAgICAg ICAgICAgICAgICAgICAgVERCX0RBVEEgKmtleSk7CiAKKy8qIE1hcmsgdGhl IHRyYW5zYWN0aW9uIGFzIGZhaWxlZC4gVGhpcyB3aWxsIHByZXZlbnQgaXQg dG8gYmUgY29tbWl0dGVkLiAqLwordm9pZCBmYWlsX3RyYW5zYWN0aW9uKHN0 cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnMpOworCiB2b2lkIGNvbm5fZGVsZXRl X2FsbF90cmFuc2FjdGlvbnMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pOwog aW50IGNoZWNrX3RyYW5zYWN0aW9ucyhzdHJ1Y3QgaGFzaHRhYmxlICpoYXNo KTsKIAo= --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Nov 01 12:01:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 12:01:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433487.686558 (Exim 4.92) (envelope-from ) id 1oppx6-0007Vf-Mn; Tue, 01 Nov 2022 12:01:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433487.686558; Tue, 01 Nov 2022 12:01:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppx5-0007Rc-Se; Tue, 01 Nov 2022 12:01:07 +0000 Received: by outflank-mailman (input) for mailman id 433487; Tue, 01 Nov 2022 12:01:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppx0-0004y3-Bo for xen-devel@lists.xen.org; Tue, 01 Nov 2022 12:01:02 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d8049bf5-59dc-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 13:00:57 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppwk-0005Ye-Il; Tue, 01 Nov 2022 12:00:46 +0000 Received: from jgross by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oppwk-0005VB-Hi; Tue, 01 Nov 2022 12:00:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8049bf5-59dc-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=GylNXLxh0WKf8ueCpUP0PjKoFAT0J9e6v1pJlyo4sNo=; b=xMhsMVbaoDArcp8i/UPYaagm7M Mm3+V7arD+1CqKkCWlvA7+OvsKc1xpnMUT1h84IoeCroYtf+8GdupKnsaZi7XbC/N0qECkjcuVYoL 9mlaPjd8nPr+p4T1Xbh0Rr90x8X9qq1puE59MBhpkrZokOli4rw0STy7DpLWp1W+MYXs=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 418 v2 (CVE-2022-42321) - Xenstore: Guests can crash xenstored via exhausting the stack Message-Id: Date: Tue, 01 Nov 2022 12:00:46 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-42321 / XSA-418 version 2 Xenstore: Guests can crash xenstored via exhausting the stack UPDATES IN VERSION 2 ==================== Public release. ISSUE DESCRIPTION ================= Xenstored is using recursion for some Xenstore operations (e.g. for deleting a sub-tree of Xenstore nodes). With sufficiently deep nesting levels this can result in stack exhaustion on xenstored, leading to a crash of xenstored. IMPACT ====== A malicious guest creating very deep nesting levels of Xenstore nodes might be able to crash xenstored, resulting in a Denial of Service (DoS) of Xenstore. This will inhibit creation of new guests or changing the configuration of already running guests. VULNERABLE SYSTEMS ================== All versions of Xen are affected. Only systems running the C variant of Xenstore (xenstored or xenstore- stubdom) are vulnerable. Systems using the Ocaml variant of Xenstore (oxenstored) are not vulnerable. MITIGATION ========== Running oxenstored instead of xenstored will avoid the vulnerability. CREDITS ======= This issue was discovered by David Vrabel of Amazon. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa418/xsa418-??.patch xen-unstable xsa418/xsa418-4.16-??.patch Xen 4.16.x xsa418/xsa418-4.15-??.patch Xen 4.15.x xsa418/xsa418-4.14-??.patch Xen 4.14.x - 4.13.x $ sha256sum xsa418* xsa418*/* dba8cf354728d5b9248d9649d042835b2f5f96dd995d0fe23a07a157cba68500 xsa418.meta d13f084bbca78d35b991fe5347297d13f77b4e49ad816344363a61a8335e6632 xsa418/xsa418-01.patch ac9acb8cda844e3873ec0a77fb9bd58581d6f1084f8a38fa494bff548c9232ae xsa418/xsa418-02.patch bc29743d71eed3ba41d1ec732e5c0011107dcc06d945ec554ef04314e0272898 xsa418/xsa418-03.patch bba67ab17c8c132258b0cfbc701e2b79ae6ea5ef507f4c09e103c19a9c729b03 xsa418/xsa418-4.14-01.patch 79eadfee1eeae340256331b5e189f1c8514106dae5ca208b0f4965ba6f6e9e51 xsa418/xsa418-4.14-02.patch 6a96c8636fc3c2a1539b9c21d3af4e0a68124dc4a7219c5eacd685f7d0543dd7 xsa418/xsa418-4.14-03.patch fe4ad75c34ceba6427c6f2ea7ad86af4a25ba3f5f9dc42fdd4ef7bf4fa60d39d xsa418/xsa418-4.14-04.patch 7884b7850d991d098409a3a9a27050f3d34486a3b459e0c2047d1dc43e13515f xsa418/xsa418-4.14-05.patch 27c070655bf27a2ca84506703d76ab5b3c9fd22155a29af5c882013cd5580640 xsa418/xsa418-4.14-06.patch 313707f2b0738680015a38ec50d93f149c386c72c809cd17de8f52e2d883b8e0 xsa418/xsa418-4.15-01.patch 4628506b3f4407034b7c6e0159a6719225f6a4c70fe12b30375f515bb6ce5d93 xsa418/xsa418-4.15-02.patch a59fed27d614de06a8d508da6345dda7260d2ac7ff9762372b34c4e6a5dfa432 xsa418/xsa418-4.15-03.patch 99ea45e5f877afe01af189ebfe3114edc8d3283829424adc53760d385b8a202e xsa418/xsa418-4.15-04.patch dd10d3c3af942fd941604029a5b5262ae6d8f7c7a9071b243904bc34c8d14ab2 xsa418/xsa418-4.15-05.patch 1a50edee9d3a04a982ba22bcf150475f396494c03b4b6eaf18b45561f0d005fc xsa418/xsa418-4.15-06.patch 042cf55472e911b871a8062613b604e7a4641505bae4e6505a176b2976906739 xsa418/xsa418-4.15-07.patch 669e8fc1637b92846ad7b72eb510c05920b267bc54340e83b3f1c8df2092ecbc xsa418/xsa418-4.16-01.patch b382431343ab873d6ab88557b09891dc821a497200c1b61e7b64286bba899ea9 xsa418/xsa418-4.16-02.patch 27737bfa0d3e475ba0e468ab3dcf0274bde40948e5f669f179d2964f6cfab4cf xsa418/xsa418-4.16-03.patch 5677156c12063d0cbad273d45800bb25176308ffd7b660d73aac3a36e4099055 xsa418/xsa418-4.16-04.patch 3c3b0282cbc50da485f6b7a871e0cc318725db2b3debf098b0fc6d0598488a48 xsa418/xsa418-4.16-05.patch d871d0e38f6db4cc86591c63cb37c63aed9ed0ba88429236eb91d142090da529 xsa418/xsa418-4.16-06.patch 145a98f2540b5c17c7d262e1df80103c4478d622a4eeba07d1566679d81a4542 xsa418/xsa418-4.16-07.patch 70874f345806b376fea1b02b0ed4d493d792a43f5c6fc29c13e0658350086f92 xsa418/xsa418-04.patch 8d94a7c6e9e484569c6eb98f274fa7489e68a9f16d12092839bb519cfc32a7b3 xsa418/xsa418-05.patch e5ecc6d3756a485114b57e0d02ff53d6eb3b312fac117a99c05bc392faa45d27 xsa418/xsa418-06.patch 77695fa2f1bfeee051d4a0e0d1e0b654f5177ce104a72635c2f1bafb1d6631cb xsa418/xsa418-07.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNg+6sMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZ0wAH/36wusPv68bogxxnnNwL6eFmZZ1Rd90mAMfw6Qyt OYo3tOWhnZVVH3uC84S7s/zWsZWJaaWxTnGW03Gxnep3GstufnWnV0m/VsmXsI9L /W0C23SgWxao+Bc819TRWF3JTcSb/wdbBbgHOJbu8gzLQc7T8xsgUeOr34fpAtZv qr2fExhKrlxdWYodDJLdZryZRBQ1ZKbO+Rihpv23FKst4HhlQvCvWr99oK6/ubkp 2mzLjeotWxT2G+RnQNJp4JqgXaYr6972/Q5h75lCxQZWxw7baIS62gTaFfK8cD4p j4gVo2zYtMBivUZngmTF36iRN743NAOz3HsvU1pEphbc24o= =6SQq -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa418.meta" Content-Disposition: attachment; filename="xsa418.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MTgsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIw YmU2M2MyNjE1YjI2ODAwMWY3Y2M5YjcyY2UyNWVlZDk1MjczN2RjIiwKICAg ICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICA0MTQsCiAgICAgICAg ICAgIDQxNSwKICAgICAgICAgICAgMzI2LAogICAgICAgICAgICA0MTYsCiAg ICAgICAgICAgIDQxNwogICAgICAgICAgXSwKICAgICAgICAgICJQYXRjaGVz IjogWwogICAgICAgICAgICAieHNhNDE4L3hzYTQxOC00LjE0LT8/LnBhdGNo IgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0 LjE0IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewog ICAgICAgICAgIlN0YWJsZVJlZiI6ICIwMTZkZTYyNzQ3YjI2ZWFkNWE1Yzc2 M2I2NDBmZThlMjA1Y2QxODJiIiwKICAgICAgICAgICJQcmVyZXFzIjogWwog ICAgICAgICAgICA0MTQsCiAgICAgICAgICAgIDQxNSwKICAgICAgICAgICAg MzI2LAogICAgICAgICAgICA0MTYsCiAgICAgICAgICAgIDQxNwogICAgICAg ICAgXSwKICAgICAgICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNh NDE4L3hzYTQxOC00LjE0LT8/LnBhdGNoIgogICAgICAgICAgXQogICAgICAg IH0KICAgICAgfQogICAgfSwKICAgICI0LjE1IjogewogICAgICAiUmVjaXBl cyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6 ICI4MTY1ODBhZmRkMTczMGQ0Zjg1ZjY0NDc3YTI0MmE0MzlhZjFjZGY4IiwK ICAgICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICA0MTQsCiAgICAg ICAgICAgIDQxNSwKICAgICAgICAgICAgMzI2LAogICAgICAgICAgICA0MTYs CiAgICAgICAgICAgIDQxNwogICAgICAgICAgXSwKICAgICAgICAgICJQYXRj aGVzIjogWwogICAgICAgICAgICAieHNhNDE4L3hzYTQxOC00LjE1LT8/LnBh dGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAg ICI0LjE2IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjog ewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIxYmNlN2ZiMWY3MDJkYTRmN2E3 NDljNmYxNDU3ZWNiMjBiZjc0ZmNhIiwKICAgICAgICAgICJQcmVyZXFzIjog WwogICAgICAgICAgICA0MTIsCiAgICAgICAgICAgIDQxNCwKICAgICAgICAg ICAgNDE1LAogICAgICAgICAgICAzMjYsCiAgICAgICAgICAgIDQxNiwKICAg ICAgICAgICAgNDE3CiAgICAgICAgICBdLAogICAgICAgICAgIlBhdGNoZXMi OiBbCiAgICAgICAgICAgICJ4c2E0MTgveHNhNDE4LTQuMTYtPz8ucGF0Y2gi CiAgICAgICAgICBdCiAgICAgICAgfQogICAgICB9CiAgICB9LAogICAgIm1h c3RlciI6IHsKICAgICAgIlJlY2lwZXMiOiB7CiAgICAgICAgInhlbiI6IHsK ICAgICAgICAgICJTdGFibGVSZWYiOiAiY2M0NzQ3YmU4YmExNTdhM2IzMTA5 MjFlOWVlMDdmYjg1NDVhYTIwNiIsCiAgICAgICAgICAiUHJlcmVxcyI6IFsK ICAgICAgICAgICAgNDEyLAogICAgICAgICAgICA0MTQsCiAgICAgICAgICAg IDQxNSwKICAgICAgICAgICAgMzI2LAogICAgICAgICAgICA0MTYsCiAgICAg ICAgICAgIDQxNwogICAgICAgICAgXSwKICAgICAgICAgICJQYXRjaGVzIjog WwogICAgICAgICAgICAieHNhNDE4L3hzYTQxOC0/Py5wYXRjaCIKICAgICAg ICAgIF0KICAgICAgICB9CiAgICAgIH0KICAgIH0KICB9Cn0= --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-01.patch" Content-Disposition: attachment; filename="xsa418/xsa418-01.patch" Content-Transfer-Encoding: base64 RnJvbSA5OTIzYzA2YTRmMTljNWE0NjkyN2UzNWYxMDNlYzY1YjY1ZTQxNmMy IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTEgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHJlbW92ZSBy ZWN1cnNpb24gZnJvbSBjb25zdHJ1Y3Rfbm9kZSgpCgpJbiBvcmRlciB0byBy ZWR1Y2Ugc3RhY2sgdXNhZ2UgZHVlIHRvIHJlY3Vyc2lvbiwgc3dpdGNoCmNv bnN0cnVjdF9ub2RlKCkgdG8gdXNlIGEgbG9vcCBpbnN0ZWFkLgoKVGhpcyBp cyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9ydGVk LWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpTaWdu ZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJl dmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoK ZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IGEwYzE3 NmZhMjAzZS4uY2I1MmY2OGQ0ZGRmIDEwMDY0NAotLS0gYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKQEAgLTEzNzMsNDUgKzEzNzMsNjkgQEAgc3RhdGlj IGludCBhZGRfY2hpbGQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3Qgbm9kZSAq cGFyZW50LCBjb25zdCBjaGFyICpuYW1lKQogc3RhdGljIHN0cnVjdCBub2Rl ICpjb25zdHJ1Y3Rfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29u c3Qgdm9pZCAqY3R4LAogCQkJCSAgIGNvbnN0IGNoYXIgKm5hbWUpCiB7Ci0J c3RydWN0IG5vZGUgKnBhcmVudCwgKm5vZGU7Ci0JY2hhciAqcGFyZW50bmFt ZSA9IGdldF9wYXJlbnQoY3R4LCBuYW1lKTsKKwljb25zdCBjaGFyICoqbmFt ZXMgPSBOVUxMOworCXVuc2lnbmVkIGludCBsZXZlbHMgPSAwOworCXN0cnVj dCBub2RlICpub2RlID0gTlVMTDsKKwlzdHJ1Y3Qgbm9kZSAqcGFyZW50ID0g TlVMTDsKKwljb25zdCBjaGFyICpwYXJlbnRuYW1lID0gdGFsbG9jX3N0cmR1 cChjdHgsIG5hbWUpOwogCiAJaWYgKCFwYXJlbnRuYW1lKQogCQlyZXR1cm4g TlVMTDsKIAotCS8qIElmIHBhcmVudCBkb2Vzbid0IGV4aXN0LCBjcmVhdGUg aXQuICovCi0JcGFyZW50ID0gcmVhZF9ub2RlKGNvbm4sIHBhcmVudG5hbWUs IHBhcmVudG5hbWUpOwotCWlmICghcGFyZW50ICYmIGVycm5vID09IEVOT0VO VCkKLQkJcGFyZW50ID0gY29uc3RydWN0X25vZGUoY29ubiwgY3R4LCBwYXJl bnRuYW1lKTsKLQlpZiAoIXBhcmVudCkKLQkJcmV0dXJuIE5VTEw7CisJLyog V2FsayB0aGUgcGF0aCB1cCB1bnRpbCBhbiBleGlzdGluZyBub2RlIGlzIGZv dW5kLiAqLworCXdoaWxlICghcGFyZW50KSB7CisJCW5hbWVzID0gdGFsbG9j X3JlYWxsb2MoY3R4LCBuYW1lcywgY29uc3QgY2hhciAqLCBsZXZlbHMgKyAx KTsKKwkJaWYgKCFuYW1lcykKKwkJCWdvdG8gbm9tZW07CiAKLQkvKiBBZGQg Y2hpbGQgdG8gcGFyZW50LiAqLwotCWlmIChhZGRfY2hpbGQoY3R4LCBwYXJl bnQsIG5hbWUpKQotCQlnb3RvIG5vbWVtOworCQkvKgorCQkgKiBuYW1lc1sw XSBpcyB0aGUgbmFtZSBvZiB0aGUgbm9kZSB0byBjb25zdHJ1Y3QgaW5pdGlh bGx5LAorCQkgKiBuYW1lc1sxXSBpcyBpdHMgcGFyZW50LCBhbmQgc28gb24u CisJCSAqLworCQluYW1lc1tsZXZlbHNdID0gcGFyZW50bmFtZTsKKwkJcGFy ZW50bmFtZSA9IGdldF9wYXJlbnQoY3R4LCBwYXJlbnRuYW1lKTsKKwkJaWYg KCFwYXJlbnRuYW1lKQorCQkJcmV0dXJuIE5VTEw7CiAKLQkvKiBBbGxvY2F0 ZSBub2RlICovCi0Jbm9kZSA9IHRhbGxvYyhjdHgsIHN0cnVjdCBub2RlKTsK LQlpZiAoIW5vZGUpCi0JCWdvdG8gbm9tZW07Ci0Jbm9kZS0+bmFtZSA9IHRh bGxvY19zdHJkdXAobm9kZSwgbmFtZSk7Ci0JaWYgKCFub2RlLT5uYW1lKQot CQlnb3RvIG5vbWVtOworCQkvKiBUcnkgdG8gcmVhZCBwYXJlbnQgbm9kZSB1 bnRpbCB3ZSBmb3VuZCBhbiBleGlzdGluZyBvbmUuICovCisJCXBhcmVudCA9 IHJlYWRfbm9kZShjb25uLCBjdHgsIHBhcmVudG5hbWUpOworCQlpZiAoIXBh cmVudCAmJiAoZXJybm8gIT0gRU5PRU5UIHx8ICFzdHJjbXAocGFyZW50bmFt ZSwgIi8iKSkpCisJCQlyZXR1cm4gTlVMTDsKIAotCS8qIEluaGVyaXQgcGVy bWlzc2lvbnMsIGV4Y2VwdCB1bnByaXZpbGVnZWQgZG9tYWlucyBvd24gd2hh dCB0aGV5IGNyZWF0ZSAqLwotCW5vZGUtPnBlcm1zLm51bSA9IHBhcmVudC0+ cGVybXMubnVtOwotCW5vZGUtPnBlcm1zLnAgPSB0YWxsb2NfbWVtZHVwKG5v ZGUsIHBhcmVudC0+cGVybXMucCwKLQkJCQkgICAgICBub2RlLT5wZXJtcy5u dW0gKiBzaXplb2YoKm5vZGUtPnBlcm1zLnApKTsKLQlpZiAoIW5vZGUtPnBl cm1zLnApCi0JCWdvdG8gbm9tZW07Ci0JaWYgKGRvbWFpbl9pc191bnByaXZp bGVnZWQoY29ubikpCi0JCW5vZGUtPnBlcm1zLnBbMF0uaWQgPSBjb25uLT5p ZDsKKwkJbGV2ZWxzKys7CisJfQorCisJLyogV2FsayB0aGUgcGF0aCBkb3du IGFnYWluIGNvbnN0cnVjdGluZyB0aGUgbWlzc2luZyBub2Rlcy4gKi8KKwlm b3IgKDsgbGV2ZWxzID4gMDsgbGV2ZWxzLS0pIHsKKwkJLyogQWRkIGNoaWxk IHRvIHBhcmVudC4gKi8KKwkJaWYgKGFkZF9jaGlsZChjdHgsIHBhcmVudCwg bmFtZXNbbGV2ZWxzIC0gMV0pKQorCQkJZ290byBub21lbTsKKworCQkvKiBB bGxvY2F0ZSBub2RlICovCisJCW5vZGUgPSB0YWxsb2MoY3R4LCBzdHJ1Y3Qg bm9kZSk7CisJCWlmICghbm9kZSkKKwkJCWdvdG8gbm9tZW07CisJCW5vZGUt Pm5hbWUgPSB0YWxsb2Nfc3RlYWwobm9kZSwgbmFtZXNbbGV2ZWxzIC0gMV0p OworCisJCS8qIEluaGVyaXQgcGVybWlzc2lvbnMsIHVucHJpdiBkb21haW5z IG93biB3aGF0IHRoZXkgY3JlYXRlLiAqLworCQlub2RlLT5wZXJtcy5udW0g PSBwYXJlbnQtPnBlcm1zLm51bTsKKwkJbm9kZS0+cGVybXMucCA9IHRhbGxv Y19tZW1kdXAobm9kZSwgcGFyZW50LT5wZXJtcy5wLAorCQkJCQkgICAgICBu b2RlLT5wZXJtcy5udW0gKgorCQkJCQkgICAgICBzaXplb2YoKm5vZGUtPnBl cm1zLnApKTsKKwkJaWYgKCFub2RlLT5wZXJtcy5wKQorCQkJZ290byBub21l bTsKKwkJaWYgKGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikpCisJCQlu b2RlLT5wZXJtcy5wWzBdLmlkID0gY29ubi0+aWQ7CisKKwkJLyogTm8gY2hp bGRyZW4sIG5vIGRhdGEgKi8KKwkJbm9kZS0+Y2hpbGRyZW4gPSBub2RlLT5k YXRhID0gTlVMTDsKKwkJbm9kZS0+Y2hpbGRsZW4gPSBub2RlLT5kYXRhbGVu ID0gMDsKKwkJbm9kZS0+YWNjLm1lbW9yeSA9IDA7CisJCW5vZGUtPnBhcmVu dCA9IHBhcmVudDsKKworCQlwYXJlbnQgPSBub2RlOworCX0KIAotCS8qIE5v IGNoaWxkcmVuLCBubyBkYXRhICovCi0Jbm9kZS0+Y2hpbGRyZW4gPSBub2Rl LT5kYXRhID0gTlVMTDsKLQlub2RlLT5jaGlsZGxlbiA9IG5vZGUtPmRhdGFs ZW4gPSAwOwotCW5vZGUtPmFjYy5tZW1vcnkgPSAwOwotCW5vZGUtPnBhcmVu dCA9IHBhcmVudDsKIAlyZXR1cm4gbm9kZTsKIAogbm9tZW06Cg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-02.patch" Content-Disposition: attachment; filename="xsa418/xsa418-02.patch" Content-Transfer-Encoding: base64 RnJvbSA4NmM2ZWU0ODM1NDdhNjEzNTViMzIxMTdlNDM5ZDQ3YjRkYWNjYmRj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTEgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGRvbid0IGxl dCByZW1vdmVfY2hpbGRfZW50cnkoKSBjYWxsIGNvcnJ1cHQoKQoKSW4gY2Fz ZSBvZiB3cml0ZV9ub2RlKCkgcmV0dXJuaW5nIGFuIGVycm9yLCByZW1vdmVf Y2hpbGRfZW50cnkoKSB3aWxsCmNhbGwgY29ycnVwdCgpIHRvZGF5LiBUaGlz IGNvdWxkIHJlc3VsdCBpbiBhbiBlbmRsZXNzIHJlY3Vyc2lvbiwgYXMKcmVt b3ZlX2NoaWxkX2VudHJ5KCkgaXMgY2FsbGVkIGJ5IGNvcnJ1cHQoKSwgdG9v OgoKY29ycnVwdCgpCiAgY2hlY2tfc3RvcmUoKQogICAgY2hlY2tfc3RvcmVf KCkKICAgICAgcmVtb3ZlX2NoaWxkX2VudHJ5KCkKCkZpeCB0aGF0IGJ5IGxl dHRpbmcgcmVtb3ZlX2NoaWxkX2VudHJ5KCkgcmV0dXJuIGFuIGVycm9yIGlu c3RlYWQgYW5kCmxldCB0aGUgY2FsbGVyIGRlY2lkZSB3aGF0IHRvIGRvLgoK VGhpcyBpcyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJl cG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVr PgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5j b20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24u Y29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4 IGNiNTJmNjhkNGRkZi4uNTY0MjkxN2U2N2RiIDEwMDY0NAotLS0gYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTE2MDQsMTUgKzE2MDQsMTUgQEAg c3RhdGljIHZvaWQgbWVtZGVsKHZvaWQgKm1lbSwgdW5zaWduZWQgb2ZmLCB1 bnNpZ25lZCBsZW4sIHVuc2lnbmVkIHRvdGFsKQogCW1lbW1vdmUobWVtICsg b2ZmLCBtZW0gKyBvZmYgKyBsZW4sIHRvdGFsIC0gb2ZmIC0gbGVuKTsKIH0K IAotc3RhdGljIHZvaWQgcmVtb3ZlX2NoaWxkX2VudHJ5KHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKLQkJCSAgICAgICBz aXplX3Qgb2Zmc2V0KQorc3RhdGljIGludCByZW1vdmVfY2hpbGRfZW50cnko c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAor CQkJICAgICAgc2l6ZV90IG9mZnNldCkKIHsKIAlzaXplX3QgY2hpbGRsZW4g PSBzdHJsZW4obm9kZS0+Y2hpbGRyZW4gKyBvZmZzZXQpOwogCiAJbWVtZGVs KG5vZGUtPmNoaWxkcmVuLCBvZmZzZXQsIGNoaWxkbGVuICsgMSwgbm9kZS0+ Y2hpbGRsZW4pOwogCW5vZGUtPmNoaWxkbGVuIC09IGNoaWxkbGVuICsgMTsK LQlpZiAod3JpdGVfbm9kZShjb25uLCBub2RlLCB0cnVlKSkKLQkJY29ycnVw dChjb25uLCAiQ2FuJ3QgdXBkYXRlIHBhcmVudCBub2RlICclcyciLCBub2Rl LT5uYW1lKTsKKworCXJldHVybiB3cml0ZV9ub2RlKGNvbm4sIG5vZGUsIHRy dWUpOwogfQogCiBzdGF0aWMgdm9pZCBkZWxldGVfY2hpbGQoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCkBAIC0xNjIyLDcgKzE2MjIsOSBAQCBzdGF0aWMg dm9pZCBkZWxldGVfY2hpbGQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAK IAlmb3IgKGkgPSAwOyBpIDwgbm9kZS0+Y2hpbGRsZW47IGkgKz0gc3RybGVu KG5vZGUtPmNoaWxkcmVuK2kpICsgMSkgewogCQlpZiAoc3RyZXEobm9kZS0+ Y2hpbGRyZW4raSwgY2hpbGRuYW1lKSkgewotCQkJcmVtb3ZlX2NoaWxkX2Vu dHJ5KGNvbm4sIG5vZGUsIGkpOworCQkJaWYgKHJlbW92ZV9jaGlsZF9lbnRy eShjb25uLCBub2RlLCBpKSkKKwkJCQljb3JydXB0KGNvbm4sICJDYW4ndCB1 cGRhdGUgcGFyZW50IG5vZGUgJyVzJyIsCisJCQkJCW5vZGUtPm5hbWUpOwog CQkJcmV0dXJuOwogCQl9CiAJfQpAQCAtMjMwNCw2ICsyMzA2LDE3IEBAIGlu dCByZW1lbWJlcl9zdHJpbmcoc3RydWN0IGhhc2h0YWJsZSAqaGFzaCwgY29u c3QgY2hhciAqc3RyKQogCXJldHVybiBoYXNodGFibGVfaW5zZXJ0KGhhc2gs IGssICh2b2lkICopMSk7CiB9CiAKK3N0YXRpYyBpbnQgcm1fY2hpbGRfZW50 cnkoc3RydWN0IG5vZGUgKm5vZGUsIHNpemVfdCBvZmYsIHNpemVfdCBsZW4p Cit7CisJaWYgKCFyZWNvdmVyeSkKKwkJcmV0dXJuIG9mZjsKKworCWlmIChy ZW1vdmVfY2hpbGRfZW50cnkoTlVMTCwgbm9kZSwgb2ZmKSkKKwkJbG9nKCJj aGVja19zdG9yZTogY2hpbGQgZW50cnkgY291bGQgbm90IGJlIHJlbW92ZWQg ZnJvbSAnJXMnIiwKKwkJICAgIG5vZGUtPm5hbWUpOworCisJcmV0dXJuIG9m ZiAtIGxlbiAtIDE7Cit9CiAKIC8qKgogICogQSBub2RlIGhhcyBhIGNoaWxk cmVuIGZpZWxkIHRoYXQgbmFtZXMgdGhlIGNoaWxkcmVuIG9mIHRoZSBub2Rl LCBzZXBhcmF0ZWQKQEAgLTIzNTYsMTIgKzIzNjksNyBAQCBzdGF0aWMgaW50 IGNoZWNrX3N0b3JlXyhjb25zdCBjaGFyICpuYW1lLCBzdHJ1Y3QgaGFzaHRh YmxlICpyZWFjaGFibGUpCiAJCQkJaWYgKGhhc2h0YWJsZV9zZWFyY2goY2hp bGRyZW4sIGNoaWxkbmFtZSkpIHsKIAkJCQkJbG9nKCJjaGVja19zdG9yZTog JyVzJyBpcyBkdXBsaWNhdGVkISIsCiAJCQkJCSAgICBjaGlsZG5hbWUpOwot Ci0JCQkJCWlmIChyZWNvdmVyeSkgewotCQkJCQkJcmVtb3ZlX2NoaWxkX2Vu dHJ5KE5VTEwsIG5vZGUsCi0JCQkJCQkJCSAgIGkpOwotCQkJCQkJaSAtPSBj aGlsZGxlbiArIDE7Ci0JCQkJCX0KKwkJCQkJaSA9IHJtX2NoaWxkX2VudHJ5 KG5vZGUsIGksIGNoaWxkbGVuKTsKIAkJCQl9CiAJCQkJZWxzZSB7CiAJCQkJ CWlmICghcmVtZW1iZXJfc3RyaW5nKGNoaWxkcmVuLApAQCAtMjM3OCwxMSAr MjM4Niw3IEBAIHN0YXRpYyBpbnQgY2hlY2tfc3RvcmVfKGNvbnN0IGNoYXIg Km5hbWUsIHN0cnVjdCBoYXNodGFibGUgKnJlYWNoYWJsZSkKIAkJCX0gZWxz ZSBpZiAoZXJybm8gIT0gRU5PTUVNKSB7CiAJCQkJbG9nKCJjaGVja19zdG9y ZTogTm8gY2hpbGQgJyVzJyBmb3VuZCFcbiIsCiAJCQkJICAgIGNoaWxkbmFt ZSk7Ci0KLQkJCQlpZiAocmVjb3ZlcnkpIHsKLQkJCQkJcmVtb3ZlX2NoaWxk X2VudHJ5KE5VTEwsIG5vZGUsIGkpOwotCQkJCQlpIC09IGNoaWxkbGVuICsg MTsKLQkJCQl9CisJCQkJaSA9IHJtX2NoaWxkX2VudHJ5KG5vZGUsIGksIGNo aWxkbGVuKTsKIAkJCX0gZWxzZSB7CiAJCQkJbG9nKCJjaGVja19zdG9yZTog RU5PTUVNIik7CiAJCQkJcmV0ID0gRU5PTUVNOwo= --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-03.patch" Content-Disposition: attachment; filename="xsa418/xsa418-03.patch" Content-Transfer-Encoding: base64 RnJvbSA1NjdhYzI1MWE2NTdmOGMxODQ3YWJiNWExNWZmYTY4NmI1YWVkNmZi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTEgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBnZW5l cmljIHRyZWV3YWxrIGZ1bmN0aW9uCgpBZGQgYSBnZW5lcmljIGZ1bmN0aW9u IHRvIHdhbGsgdGhlIGNvbXBsZXRlIG5vZGUgdHJlZS4gSXQgd2lsbCBzdGFy dAphdCAiLyIgYW5kIGRlc2NlbmQgcmVjdXJzaXZlbHkgaW50byBlYWNoIGNo aWxkLCBjYWxsaW5nIGEgZnVuY3Rpb24Kc3BlY2lmaWVkIGJ5IHRoZSBjYWxs ZXIuIERlcGVuZGluZyBvbiB0aGUgcmV0dXJuIHZhbHVlIG9mIHRoZSB1c2Vy CnNwZWNpZmllZCBmdW5jdGlvbiB0aGUgd2FsayB3aWxsIGJlIGFib3J0ZWQs IGNvbnRpbnVlZCwgb3IgdGhlIGN1cnJlbnQKY2hpbGQgd2lsbCBiZSBza2lw cGVkIGJ5IG5vdCBkZXNjZW5kaW5nIGludG8gaXRzIGNoaWxkcmVuLgoKVGhp cyBpcyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9y dGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpT aWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ CkFja2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoK ZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IDU2NDI5 MTdlNjdkYi4uZjc4ZmFmMGMzZTA2IDEwMDY0NAotLS0gYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKQEAgLTE4MzQsNiArMTgzNCwxMzUgQEAgc3RhdGlj IGludCBkb19zZXRfcGVybXMoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwKIAlyZXR1cm4gMDsKIH0KIAorc3RhdGljIGNoYXIg KmNoaWxkX25hbWUoY29uc3Qgdm9pZCAqY3R4LCBjb25zdCBjaGFyICpzMSwg Y29uc3QgY2hhciAqczIpCit7CisJaWYgKHN0cmNtcChzMSwgIi8iKSkKKwkJ cmV0dXJuIHRhbGxvY19hc3ByaW50ZihjdHgsICIlcy8lcyIsIHMxLCBzMik7 CisJcmV0dXJuIHRhbGxvY19hc3ByaW50ZihjdHgsICIvJXMiLCBzMik7Cit9 CisKK3N0YXRpYyBpbnQgcm1fZnJvbV9wYXJlbnQoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIHN0cnVjdCBub2RlICpwYXJlbnQsCisJCQkgIGNvbnN0IGNo YXIgKm5hbWUpCit7CisJc2l6ZV90IG9mZjsKKworCWlmICghcGFyZW50KQor CQlyZXR1cm4gV0FMS19UUkVFX0VSUk9SX1NUT1A7CisKKwlmb3IgKG9mZiA9 IHBhcmVudC0+Y2hpbGRvZmYgLSAxOyBvZmYgJiYgcGFyZW50LT5jaGlsZHJl bltvZmYgLSAxXTsKKwkgICAgIG9mZi0tKTsKKwlpZiAocmVtb3ZlX2NoaWxk X2VudHJ5KGNvbm4sIHBhcmVudCwgb2ZmKSkgeworCQlsb2coInRyZWV3YWxr OiBjaGlsZCBlbnRyeSBjb3VsZCBub3QgYmUgcmVtb3ZlZCBmcm9tICclcyci LAorCQkgICAgcGFyZW50LT5uYW1lKTsKKwkJcmV0dXJuIFdBTEtfVFJFRV9F UlJPUl9TVE9QOworCX0KKwlwYXJlbnQtPmNoaWxkb2ZmID0gb2ZmOworCisJ cmV0dXJuIFdBTEtfVFJFRV9PSzsKK30KKworc3RhdGljIGludCB3YWxrX2Nh bGxfZnVuYyhjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpj b25uLAorCQkJICBzdHJ1Y3Qgbm9kZSAqbm9kZSwgc3RydWN0IG5vZGUgKnBh cmVudCwgdm9pZCAqYXJnLAorCQkJICBpbnQgKCpmdW5jKShjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkJCSAgICAgIHN0 cnVjdCBub2RlICpub2RlLCB2b2lkICphcmcpKQoreworCWludCByZXQ7CisK KwlpZiAoIWZ1bmMpCisJCXJldHVybiBXQUxLX1RSRUVfT0s7CisKKwlyZXQg PSBmdW5jKGN0eCwgY29ubiwgbm9kZSwgYXJnKTsKKwlpZiAocmV0ID09IFdB TEtfVFJFRV9STV9DSElMREVOVFJZICYmIHBhcmVudCkKKwkJcmV0ID0gcm1f ZnJvbV9wYXJlbnQoY29ubiwgcGFyZW50LCBub2RlLT5uYW1lKTsKKworCXJl dHVybiByZXQ7Cit9CisKK2ludCB3YWxrX25vZGVfdHJlZShjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpy b290LAorCQkgICBzdHJ1Y3Qgd2Fsa19mdW5jcyAqZnVuY3MsIHZvaWQgKmFy ZykKK3sKKwlpbnQgcmV0ID0gMDsKKwl2b2lkICp0bXBjdHg7CisJY2hhciAq bmFtZTsKKwlzdHJ1Y3Qgbm9kZSAqbm9kZSA9IE5VTEw7CisJc3RydWN0IG5v ZGUgKnBhcmVudCA9IE5VTEw7CisKKwl0bXBjdHggPSB0YWxsb2NfbmV3KGN0 eCk7CisJaWYgKCF0bXBjdHgpIHsKKwkJZXJybm8gPSBFTk9NRU07CisJCXJl dHVybiBXQUxLX1RSRUVfRVJST1JfU1RPUDsKKwl9CisJbmFtZSA9IHRhbGxv Y19zdHJkdXAodG1wY3R4LCByb290KTsKKwlpZiAoIW5hbWUpIHsKKwkJZXJy bm8gPSBFTk9NRU07CisJCXRhbGxvY19mcmVlKHRtcGN0eCk7CisJCXJldHVy biBXQUxLX1RSRUVfRVJST1JfU1RPUDsKKwl9CisKKwkvKiBDb250aW51ZSB0 aGUgd2FsayB1bnRpbCBhbiBlcnJvciBpcyByZXR1cm5lZC4gKi8KKwl3aGls ZSAocmV0ID49IDApIHsKKwkJLyogbm9kZSA9PSBOVUxMIHBvc3NpYmxlIG9u bHkgZm9yIHRoZSBpbml0aWFsIGxvb3AgaXRlcmF0aW9uLiAqLworCQlpZiAo bm9kZSkgeworCQkJLyogR28gb25lIHN0ZXAgdXAgaWYgcmV0IG9yIGlmIGxh c3QgY2hpbGQgZmluaXNoZWQuICovCisJCQlpZiAocmV0IHx8IG5vZGUtPmNo aWxkb2ZmID49IG5vZGUtPmNoaWxkbGVuKSB7CisJCQkJcGFyZW50ID0gbm9k ZS0+cGFyZW50OworCQkJCS8qIENhbGwgZnVuY3Rpb24gQUZURVIgcHJvY2Vz c2luZyBhIG5vZGUuICovCisJCQkJcmV0ID0gd2Fsa19jYWxsX2Z1bmMoY3R4 LCBjb25uLCBub2RlLCBwYXJlbnQsCisJCQkJCQkgICAgIGFyZywgZnVuY3Mt PmV4aXQpOworCQkJCS8qIExhc3Qgbm9kZSwgc28gZXhpdCBsb29wLiAqLwor CQkJCWlmICghcGFyZW50KQorCQkJCQlicmVhazsKKwkJCQl0YWxsb2NfZnJl ZShub2RlKTsKKwkJCQkvKiBDb250aW51ZSB3aXRoIHBhcmVudC4gKi8KKwkJ CQlub2RlID0gcGFyZW50OworCQkJCWNvbnRpbnVlOworCQkJfQorCQkJLyog R2V0IG5leHQgY2hpbGQgb2YgY3VycmVudCBub2RlLiAqLworCQkJbmFtZSA9 IGNoaWxkX25hbWUodG1wY3R4LCBub2RlLT5uYW1lLAorCQkJCQkgIG5vZGUt PmNoaWxkcmVuICsgbm9kZS0+Y2hpbGRvZmYpOworCQkJaWYgKCFuYW1lKSB7 CisJCQkJcmV0ID0gV0FMS19UUkVFX0VSUk9SX1NUT1A7CisJCQkJYnJlYWs7 CisJCQl9CisJCQkvKiBQb2ludCB0byBuZXh0IGNoaWxkLiAqLworCQkJbm9k ZS0+Y2hpbGRvZmYgKz0gc3RybGVuKG5vZGUtPmNoaWxkcmVuICsKKwkJCQkJ CSBub2RlLT5jaGlsZG9mZikgKyAxOworCQkJLyogRGVzY2VudCBpbnRvIGNo aWxkcmVuLiAqLworCQkJcGFyZW50ID0gbm9kZTsKKwkJfQorCQkvKiBSZWFk IG5leHQgbm9kZSAocm9vdCBub2RlIG9yIG5leHQgY2hpbGQpLiAqLworCQlu b2RlID0gcmVhZF9ub2RlKGNvbm4sIHRtcGN0eCwgbmFtZSk7CisJCWlmICgh bm9kZSkgeworCQkJLyogQ2hpbGQgbm90IGZvdW5kIC0gc2hvdWxkIG5vdCBo YXBwZW4hICovCisJCQkvKiBFTk9FTlQgY2FzZSBjYW4gYmUgaGFuZGxlZCBi eSBzdXBwbGllZCBmdW5jdGlvbi4gKi8KKwkJCWlmIChlcnJubyA9PSBFTk9F TlQgJiYgZnVuY3MtPmVub2VudCkKKwkJCQlyZXQgPSBmdW5jcy0+ZW5vZW50 KGN0eCwgY29ubiwgcGFyZW50LCBuYW1lLAorCQkJCQkJICAgIGFyZyk7CisJ CQllbHNlCisJCQkJcmV0ID0gV0FMS19UUkVFX0VSUk9SX1NUT1A7CisJCQlp ZiAoIXBhcmVudCkKKwkJCQlicmVhazsKKwkJCWlmIChyZXQgPT0gV0FMS19U UkVFX1JNX0NISUxERU5UUlkpCisJCQkJcmV0ID0gcm1fZnJvbV9wYXJlbnQo Y29ubiwgcGFyZW50LCBuYW1lKTsKKwkJCWlmIChyZXQgPCAwKQorCQkJCWJy ZWFrOworCQkJdGFsbG9jX2ZyZWUobmFtZSk7CisJCQlub2RlID0gcGFyZW50 OworCQkJY29udGludWU7CisJCX0KKwkJdGFsbG9jX2ZyZWUobmFtZSk7CisJ CW5vZGUtPnBhcmVudCA9IHBhcmVudDsKKwkJbm9kZS0+Y2hpbGRvZmYgPSAw OworCQkvKiBDYWxsIGZ1bmN0aW9uIEJFRk9SRSBwcm9jZXNzaW5nIGEgbm9k ZS4gKi8KKwkJcmV0ID0gd2Fsa19jYWxsX2Z1bmMoY3R4LCBjb25uLCBub2Rl LCBwYXJlbnQsIGFyZywKKwkJCQkgICAgIGZ1bmNzLT5lbnRlcik7CisJfQor CisJdGFsbG9jX2ZyZWUodG1wY3R4KTsKKworCXJldHVybiByZXQgPCAwID8g cmV0IDogV0FMS19UUkVFX09LOworfQorCiBzdGF0aWMgc3RydWN0IHsKIAlj b25zdCBjaGFyICpzdHI7CiAJaW50ICgqZnVuYykoY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKQEAgLTIyODQsMTggKzI0MTMs NiBAQCBzdGF0aWMgaW50IGtleXNfZXF1YWxfZm4odm9pZCAqa2V5MSwgdm9p ZCAqa2V5MikKIAlyZXR1cm4gMCA9PSBzdHJjbXAoKGNoYXIgKilrZXkxLCAo Y2hhciAqKWtleTIpOwogfQogCi0KLXN0YXRpYyBjaGFyICpjaGlsZF9uYW1l KGNvbnN0IGNoYXIgKnMxLCBjb25zdCBjaGFyICpzMikKLXsKLQlpZiAoc3Ry Y21wKHMxLCAiLyIpKSB7Ci0JCXJldHVybiB0YWxsb2NfYXNwcmludGYoTlVM TCwgIiVzLyVzIiwgczEsIHMyKTsKLQl9Ci0JZWxzZSB7Ci0JCXJldHVybiB0 YWxsb2NfYXNwcmludGYoTlVMTCwgIi8lcyIsIHMyKTsKLQl9Ci19Ci0KLQog aW50IHJlbWVtYmVyX3N0cmluZyhzdHJ1Y3QgaGFzaHRhYmxlICpoYXNoLCBj b25zdCBjaGFyICpzdHIpCiB7CiAJY2hhciAqayA9IG1hbGxvYyhzdHJsZW4o c3RyKSArIDEpOwpAQCAtMjM1NSw3ICsyNDcyLDcgQEAgc3RhdGljIGludCBj aGVja19zdG9yZV8oY29uc3QgY2hhciAqbmFtZSwgc3RydWN0IGhhc2h0YWJs ZSAqcmVhY2hhYmxlKQogCQl3aGlsZSAoaSA8IG5vZGUtPmNoaWxkbGVuICYm ICFyZXQpIHsKIAkJCXN0cnVjdCBub2RlICpjaGlsZG5vZGU7CiAJCQlzaXpl X3QgY2hpbGRsZW4gPSBzdHJsZW4obm9kZS0+Y2hpbGRyZW4gKyBpKTsKLQkJ CWNoYXIgKiBjaGlsZG5hbWUgPSBjaGlsZF9uYW1lKG5vZGUtPm5hbWUsCisJ CQljaGFyICogY2hpbGRuYW1lID0gY2hpbGRfbmFtZShOVUxMLCBub2RlLT5u YW1lLAogCQkJCQkJICAgICAgbm9kZS0+Y2hpbGRyZW4gKyBpKTsKIAogCQkJ aWYgKCFjaGlsZG5hbWUpIHsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5oCmluZGV4IGY3YzM3ZmUzYjU2NS4uYWNiMDBhZDk2OTE0IDEwMDY0 NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCisrKyBi L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKQEAgLTIwMiw2ICsy MDIsNyBAQCBzdHJ1Y3Qgbm9kZSB7CiAKIAkvKiBDaGlsZHJlbiwgZWFjaCBu dWwtdGVybWluYXRlZC4gKi8KIAl1bnNpZ25lZCBpbnQgY2hpbGRsZW47CisJ dW5zaWduZWQgaW50IGNoaWxkb2ZmOwkvKiBVc2VkIGJ5IHdhbGtfbm9kZV90 cmVlKCkgaW50ZXJuYWxseS4gKi8KIAljaGFyICpjaGlsZHJlbjsKIAogCS8q IEFsbG9jYXRpb24gaW5mb3JtYXRpb24gZm9yIG5vZGUgY3VycmVudGx5IGlu IHN0b3JlLiAqLwpAQCAtMzMzLDYgKzMzNCw0NSBAQCB2b2lkIHJlYWRfc3Rh dGVfYnVmZmVyZWRfZGF0YShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLAogCQkJICAgICAgY29uc3Qgc3RydWN0IHhzX3N0YXRl X2Nvbm5lY3Rpb24gKnNjKTsKIHZvaWQgcmVhZF9zdGF0ZV9ub2RlKGNvbnN0 IHZvaWQgKmN0eCwgY29uc3Qgdm9pZCAqc3RhdGUpOwogCisvKgorICogV2Fs ayB0aGUgbm9kZSB0cmVlIGJlbG93IHJvb3QgY2FsbGluZyBmdW5jcy0+ZW50 ZXIoKSBhbmQgZnVuY3MtPmV4aXQoKSBmb3IKKyAqIGVhY2ggbm9kZS4gZnVu Y3MtPmVudGVyKCkgaXMgYmVpbmcgY2FsbGVkIHdoZW4gZW50ZXJpbmcgYSBu b2RlLCBzbyBiZWZvcmUKKyAqIGFueSBvZiB0aGUgY2hpbGRyZW4gb2YgdGhl IG5vZGUgaXMgcHJvY2Vzc2VkLiBmdW5jcy0+ZXhpdCgpIGlzIGJlaW5nCisg KiBjYWxsZWQgd2hlbiBsZWF2aW5nIHRoZSBub2RlLCBzbyBhZnRlciBhbGwg Y2hpbGRyZW4gaGF2ZSBiZWVuIHByb2Nlc3NlZC4KKyAqIGZ1bmNzLT5lbm9l bnQoKSBpcyBiZWluZyBjYWxsZWQgd2hlbiBhIG5vZGUgaXNuJ3QgZXhpc3Rp bmcuCisgKiBmdW5jcy0+KigpIHJldHVybiB2YWx1ZXM6CisgKiAgPCAwOiB0 cmVlIHdhbGsgaXMgc3RvcHBlZCwgd2Fsa19ub2RlX3RyZWUoKSByZXR1cm5z IGZ1bmNzLT4qKCkgcmV0dXJuIHZhbHVlCisgKiAgICAgICBpbiBjYXNlIFdB TEtfVFJFRV9FUlJPUl9TVE9QIGlzIHJldHVybmVkLCBlcnJubyBzaG91bGQg YmUgc2V0CisgKiAgV0FMS19UUkVFX09LOiB0cmVlIHdhbGsgaXMgY29udGlu dWluZworICogIFdBTEtfVFJFRV9TS0lQX0NISUxEUkVOOiB0cmVlIHdhbGsg d29uJ3QgZGVzY2VuZCBiZWxvdyBjdXJyZW50IG5vZGUsIGJ1dAorICogICAg ICAgd2FsayBjb250aW51ZXMKKyAqICBXQUxLX1RSRUVfUk1fQ0hJTERFTlRS WTogUmVtb3ZlIHRoZSBjaGlsZCBlbnRyeSBmcm9tIGl0cyBwYXJlbnQgYW5k IHdyaXRlCisgKiAgICAgICB0aGUgbW9kaWZpZWQgcGFyZW50IG5vZGUgYmFj ayB0byB0aGUgZGF0YSBiYXNlLCBpbXBsaWVzIHRvIG5vdCBkZXNjZW5kCisg KiAgICAgICBiZWxvdyB0aGUgY3VycmVudCBub2RlLCBidXQgdG8gY29udGlu dWUgdGhlIHdhbGsKKyAqIGZ1bmNzLT4qKCkgaXMgYWxsb3dlZCB0byBtb2Rp ZnkgdGhlIG5vZGUgaXQgaXMgY2FsbGVkIGZvciBpbiB0aGUgZGF0YSBiYXNl LgorICogSW4gY2FzZSBmdW5jcy0+ZW50ZXIoKSBpcyBkZWxldGluZyB0aGUg bm9kZSwgaXQgbXVzdCBub3QgcmV0dXJuIFdBTEtfVFJFRV9PSworICogaW4g b3JkZXIgdG8gYXZvaWQgZGVzY2VuZGluZyBpbnRvIG5vIGxvbmdlciBleGlz dGluZyBjaGlsZHJlbi4KKyAqLworLyogUmV0dXJuIHZhbHVlcyBmb3IgZnVu Y3MtPiooKSBhbmQgd2Fsa19ub2RlX3RyZWUoKS4gKi8KKyNkZWZpbmUgV0FM S19UUkVFX1NVQ0NFU1NfU1RPUCAgLTEwMCAgICAvKiBTdG9wIHdhbGsgZWFy bHksIG5vIGVycm9yLiAqLworI2RlZmluZSBXQUxLX1RSRUVfRVJST1JfU1RP UCAgICAtMSAgICAgIC8qIFN0b3Agd2FsayBkdWUgdG8gZXJyb3IuICovCisj ZGVmaW5lIFdBTEtfVFJFRV9PSyAgICAgICAgICAgIDAgICAgICAgLyogTm8g ZXJyb3IuICovCisvKiBSZXR1cm4gdmFsdWUgZm9yIGZ1bmNzLT4qKCkgb25s eS4gKi8KKyNkZWZpbmUgV0FMS19UUkVFX1NLSVBfQ0hJTERSRU4gMSAgICAg ICAvKiBEb24ndCByZWN1cnNlIGJlbG93IGN1cnJlbnQgbm9kZS4gKi8KKyNk ZWZpbmUgV0FMS19UUkVFX1JNX0NISUxERU5UUlkgMiAgICAgICAvKiBSZW1v dmUgY2hpbGQgZW50cnkgZnJvbSBwYXJlbnQuICovCisKK3N0cnVjdCB3YWxr X2Z1bmNzIHsKKwlpbnQgKCplbnRlcikoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICAgICBzdHJ1Y3Qgbm9kZSAqbm9k ZSwgdm9pZCAqYXJnKTsKKwlpbnQgKCpleGl0KShjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgICAgc3RydWN0IG5vZGUg Km5vZGUsIHZvaWQgKmFyZyk7CisJaW50ICgqZW5vZW50KShjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgICAgICBzdHJ1 Y3Qgbm9kZSAqcGFyZW50LCBjaGFyICpuYW1lLCB2b2lkICphcmcpOworfTsK KworaW50IHdhbGtfbm9kZV90cmVlKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IGNoYXIgKnJvb3QsCisJCSAgIHN0 cnVjdCB3YWxrX2Z1bmNzICpmdW5jcywgdm9pZCAqYXJnKTsKKwogI2VuZGlm IC8qIF9YRU5TVE9SRURfQ09SRV9IICovCiAKIC8qCg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.14-01.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.14-01.patch" Content-Transfer-Encoding: base64 RnJvbSAwZDRmNDQyYjg4M2EyNzk4NjExMWZjNTI0ZDQ1NzVhMzU2OTU5YmFl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTEgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHJlbW92ZSBy ZWN1cnNpb24gZnJvbSBjb25zdHJ1Y3Rfbm9kZSgpCgpJbiBvcmRlciB0byBy ZWR1Y2Ugc3RhY2sgdXNhZ2UgZHVlIHRvIHJlY3Vyc2lvbiwgc3dpdGNoCmNv bnN0cnVjdF9ub2RlKCkgdG8gdXNlIGEgbG9vcCBpbnN0ZWFkLgoKVGhpcyBp cyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9ydGVk LWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpTaWdu ZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJl dmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoK ZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IDM0YTg0 NjlkZDY5ZC4uZTc5NzFjODI4ZThiIDEwMDY0NAotLS0gYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKQEAgLTEyNTQsNTcgKzEyNTQsOTEgQEAgc3RhdGlj IGNoYXIgKmJhc2VuYW1lKGNvbnN0IGNoYXIgKm5hbWUpCiAJcmV0dXJuIHN0 cnJjaHIobmFtZSwgJy8nKSArIDE7CiB9CiAKLXN0YXRpYyBzdHJ1Y3Qgbm9k ZSAqY29uc3RydWN0X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNv bnN0IHZvaWQgKmN0eCwKLQkJCQkgICBjb25zdCBjaGFyICpuYW1lKQorc3Rh dGljIGludCBhZGRfY2hpbGQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3Qgbm9k ZSAqcGFyZW50LCBjb25zdCBjaGFyICpuYW1lKQogewogCWNvbnN0IGNoYXIg KmJhc2U7CiAJdW5zaWduZWQgaW50IGJhc2VsZW47Ci0Jc3RydWN0IG5vZGUg KnBhcmVudCwgKm5vZGU7Ci0JY2hhciAqY2hpbGRyZW4sICpwYXJlbnRuYW1l ID0gZ2V0X3BhcmVudChjdHgsIG5hbWUpOwotCi0JaWYgKCFwYXJlbnRuYW1l KQotCQlyZXR1cm4gTlVMTDsKKwljaGFyICpjaGlsZHJlbjsKIAotCS8qIElm IHBhcmVudCBkb2Vzbid0IGV4aXN0LCBjcmVhdGUgaXQuICovCi0JcGFyZW50 ID0gcmVhZF9ub2RlKGNvbm4sIHBhcmVudG5hbWUsIHBhcmVudG5hbWUpOwot CWlmICghcGFyZW50ICYmIGVycm5vID09IEVOT0VOVCkKLQkJcGFyZW50ID0g Y29uc3RydWN0X25vZGUoY29ubiwgY3R4LCBwYXJlbnRuYW1lKTsKLQlpZiAo IXBhcmVudCkKLQkJcmV0dXJuIE5VTEw7Ci0KLQkvKiBBZGQgY2hpbGQgdG8g cGFyZW50LiAqLwogCWJhc2UgPSBiYXNlbmFtZShuYW1lKTsKIAliYXNlbGVu ID0gc3RybGVuKGJhc2UpICsgMTsKIAljaGlsZHJlbiA9IHRhbGxvY19hcnJh eShjdHgsIGNoYXIsIHBhcmVudC0+Y2hpbGRsZW4gKyBiYXNlbGVuKTsKIAlp ZiAoIWNoaWxkcmVuKQotCQlnb3RvIG5vbWVtOworCQlyZXR1cm4gRU5PTUVN OwogCW1lbWNweShjaGlsZHJlbiwgcGFyZW50LT5jaGlsZHJlbiwgcGFyZW50 LT5jaGlsZGxlbik7CiAJbWVtY3B5KGNoaWxkcmVuICsgcGFyZW50LT5jaGls ZGxlbiwgYmFzZSwgYmFzZWxlbik7CiAJcGFyZW50LT5jaGlsZHJlbiA9IGNo aWxkcmVuOwogCXBhcmVudC0+Y2hpbGRsZW4gKz0gYmFzZWxlbjsKIAotCS8q IEFsbG9jYXRlIG5vZGUgKi8KLQlub2RlID0gdGFsbG9jKGN0eCwgc3RydWN0 IG5vZGUpOwotCWlmICghbm9kZSkKLQkJZ290byBub21lbTsKLQlub2RlLT5u YW1lID0gdGFsbG9jX3N0cmR1cChub2RlLCBuYW1lKTsKLQlpZiAoIW5vZGUt Pm5hbWUpCi0JCWdvdG8gbm9tZW07Ci0KLQkvKiBJbmhlcml0IHBlcm1pc3Np b25zLCBleGNlcHQgdW5wcml2aWxlZ2VkIGRvbWFpbnMgb3duIHdoYXQgdGhl eSBjcmVhdGUgKi8KLQlub2RlLT5wZXJtcy5udW0gPSBwYXJlbnQtPnBlcm1z Lm51bTsKLQlub2RlLT5wZXJtcy5wID0gdGFsbG9jX21lbWR1cChub2RlLCBw YXJlbnQtPnBlcm1zLnAsCi0JCQkJICAgICAgbm9kZS0+cGVybXMubnVtICog c2l6ZW9mKCpub2RlLT5wZXJtcy5wKSk7Ci0JaWYgKCFub2RlLT5wZXJtcy5w KQotCQlnb3RvIG5vbWVtOwotCWlmIChkb21haW5faXNfdW5wcml2aWxlZ2Vk KGNvbm4pKQotCQlub2RlLT5wZXJtcy5wWzBdLmlkID0gY29ubi0+aWQ7Ci0K LQkvKiBObyBjaGlsZHJlbiwgbm8gZGF0YSAqLwotCW5vZGUtPmNoaWxkcmVu ID0gbm9kZS0+ZGF0YSA9IE5VTEw7Ci0Jbm9kZS0+Y2hpbGRsZW4gPSBub2Rl LT5kYXRhbGVuID0gMDsKLQlub2RlLT5hY2MubWVtb3J5ID0gMDsKLQlub2Rl LT5wYXJlbnQgPSBwYXJlbnQ7CisJcmV0dXJuIDA7Cit9CisKK3N0YXRpYyBz dHJ1Y3Qgbm9kZSAqY29uc3RydWN0X25vZGUoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKKwkJCQkgICBjb25zdCBjaGFyICpu YW1lKQoreworCWNvbnN0IGNoYXIgKipuYW1lcyA9IE5VTEw7CisJdW5zaWdu ZWQgaW50IGxldmVscyA9IDA7CisJc3RydWN0IG5vZGUgKm5vZGUgPSBOVUxM OworCXN0cnVjdCBub2RlICpwYXJlbnQgPSBOVUxMOworCWNvbnN0IGNoYXIg KnBhcmVudG5hbWUgPSB0YWxsb2Nfc3RyZHVwKGN0eCwgbmFtZSk7CisKKwlp ZiAoIXBhcmVudG5hbWUpCisJCXJldHVybiBOVUxMOworCisJLyogV2FsayB0 aGUgcGF0aCB1cCB1bnRpbCBhbiBleGlzdGluZyBub2RlIGlzIGZvdW5kLiAq LworCXdoaWxlICghcGFyZW50KSB7CisJCW5hbWVzID0gdGFsbG9jX3JlYWxs b2MoY3R4LCBuYW1lcywgY29uc3QgY2hhciAqLCBsZXZlbHMgKyAxKTsKKwkJ aWYgKCFuYW1lcykKKwkJCWdvdG8gbm9tZW07CisKKwkJLyoKKwkJICogbmFt ZXNbMF0gaXMgdGhlIG5hbWUgb2YgdGhlIG5vZGUgdG8gY29uc3RydWN0IGlu aXRpYWxseSwKKwkJICogbmFtZXNbMV0gaXMgaXRzIHBhcmVudCwgYW5kIHNv IG9uLgorCQkgKi8KKwkJbmFtZXNbbGV2ZWxzXSA9IHBhcmVudG5hbWU7CisJ CXBhcmVudG5hbWUgPSBnZXRfcGFyZW50KGN0eCwgcGFyZW50bmFtZSk7CisJ CWlmICghcGFyZW50bmFtZSkKKwkJCXJldHVybiBOVUxMOworCisJCS8qIFRy eSB0byByZWFkIHBhcmVudCBub2RlIHVudGlsIHdlIGZvdW5kIGFuIGV4aXN0 aW5nIG9uZS4gKi8KKwkJcGFyZW50ID0gcmVhZF9ub2RlKGNvbm4sIGN0eCwg cGFyZW50bmFtZSk7CisJCWlmICghcGFyZW50ICYmIChlcnJubyAhPSBFTk9F TlQgfHwgIXN0cmNtcChwYXJlbnRuYW1lLCAiLyIpKSkKKwkJCXJldHVybiBO VUxMOworCisJCWxldmVscysrOworCX0KKworCS8qIFdhbGsgdGhlIHBhdGgg ZG93biBhZ2FpbiBjb25zdHJ1Y3RpbmcgdGhlIG1pc3Npbmcgbm9kZXMuICov CisJZm9yICg7IGxldmVscyA+IDA7IGxldmVscy0tKSB7CisJCS8qIEFkZCBj aGlsZCB0byBwYXJlbnQuICovCisJCWlmIChhZGRfY2hpbGQoY3R4LCBwYXJl bnQsIG5hbWVzW2xldmVscyAtIDFdKSkKKwkJCWdvdG8gbm9tZW07CisKKwkJ LyogQWxsb2NhdGUgbm9kZSAqLworCQlub2RlID0gdGFsbG9jKGN0eCwgc3Ry dWN0IG5vZGUpOworCQlpZiAoIW5vZGUpCisJCQlnb3RvIG5vbWVtOworCQlu b2RlLT5uYW1lID0gdGFsbG9jX3N0ZWFsKG5vZGUsIG5hbWVzW2xldmVscyAt IDFdKTsKKworCQkvKiBJbmhlcml0IHBlcm1pc3Npb25zLCB1bnByaXYgZG9t YWlucyBvd24gd2hhdCB0aGV5IGNyZWF0ZS4gKi8KKwkJbm9kZS0+cGVybXMu bnVtID0gcGFyZW50LT5wZXJtcy5udW07CisJCW5vZGUtPnBlcm1zLnAgPSB0 YWxsb2NfbWVtZHVwKG5vZGUsIHBhcmVudC0+cGVybXMucCwKKwkJCQkJICAg ICAgbm9kZS0+cGVybXMubnVtICoKKwkJCQkJICAgICAgc2l6ZW9mKCpub2Rl LT5wZXJtcy5wKSk7CisJCWlmICghbm9kZS0+cGVybXMucCkKKwkJCWdvdG8g bm9tZW07CisJCWlmIChkb21haW5faXNfdW5wcml2aWxlZ2VkKGNvbm4pKQor CQkJbm9kZS0+cGVybXMucFswXS5pZCA9IGNvbm4tPmlkOworCisJCS8qIE5v IGNoaWxkcmVuLCBubyBkYXRhICovCisJCW5vZGUtPmNoaWxkcmVuID0gbm9k ZS0+ZGF0YSA9IE5VTEw7CisJCW5vZGUtPmNoaWxkbGVuID0gbm9kZS0+ZGF0 YWxlbiA9IDA7CisJCW5vZGUtPmFjYy5tZW1vcnkgPSAwOworCQlub2RlLT5w YXJlbnQgPSBwYXJlbnQ7CisKKwkJcGFyZW50ID0gbm9kZTsKKwl9CisKIAly ZXR1cm4gbm9kZTsKIAogbm9tZW06Cg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.14-02.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.14-02.patch" Content-Transfer-Encoding: base64 RnJvbSBiODA3NTU1M2VhYjllZGQ4ZTQwZjRjNmRhNmM0NDM5ODM1YWExZWVh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTEgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGRvbid0IGxl dCByZW1vdmVfY2hpbGRfZW50cnkoKSBjYWxsIGNvcnJ1cHQoKQoKSW4gY2Fz ZSBvZiB3cml0ZV9ub2RlKCkgcmV0dXJuaW5nIGFuIGVycm9yLCByZW1vdmVf Y2hpbGRfZW50cnkoKSB3aWxsCmNhbGwgY29ycnVwdCgpIHRvZGF5LiBUaGlz IGNvdWxkIHJlc3VsdCBpbiBhbiBlbmRsZXNzIHJlY3Vyc2lvbiwgYXMKcmVt b3ZlX2NoaWxkX2VudHJ5KCkgaXMgY2FsbGVkIGJ5IGNvcnJ1cHQoKSwgdG9v OgoKY29ycnVwdCgpCiAgY2hlY2tfc3RvcmUoKQogICAgY2hlY2tfc3RvcmVf KCkKICAgICAgcmVtb3ZlX2NoaWxkX2VudHJ5KCkKCkZpeCB0aGF0IGJ5IGxl dHRpbmcgcmVtb3ZlX2NoaWxkX2VudHJ5KCkgcmV0dXJuIGFuIGVycm9yIGlu c3RlYWQgYW5kCmxldCB0aGUgY2FsbGVyIGRlY2lkZSB3aGF0IHRvIGRvLgoK VGhpcyBpcyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJl cG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVr PgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5j b20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24u Y29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4 IGU3OTcxYzgyOGU4Yi4uY2VmOWZjMWMxZTEyIDEwMDY0NAotLS0gYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTE1MDUsMTUgKzE1MDUsMTUgQEAg c3RhdGljIHZvaWQgbWVtZGVsKHZvaWQgKm1lbSwgdW5zaWduZWQgb2ZmLCB1 bnNpZ25lZCBsZW4sIHVuc2lnbmVkIHRvdGFsKQogCW1lbW1vdmUobWVtICsg b2ZmLCBtZW0gKyBvZmYgKyBsZW4sIHRvdGFsIC0gb2ZmIC0gbGVuKTsKIH0K IAotc3RhdGljIHZvaWQgcmVtb3ZlX2NoaWxkX2VudHJ5KHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKLQkJCSAgICAgICBz aXplX3Qgb2Zmc2V0KQorc3RhdGljIGludCByZW1vdmVfY2hpbGRfZW50cnko c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAor CQkJICAgICAgc2l6ZV90IG9mZnNldCkKIHsKIAlzaXplX3QgY2hpbGRsZW4g PSBzdHJsZW4obm9kZS0+Y2hpbGRyZW4gKyBvZmZzZXQpOwogCiAJbWVtZGVs KG5vZGUtPmNoaWxkcmVuLCBvZmZzZXQsIGNoaWxkbGVuICsgMSwgbm9kZS0+ Y2hpbGRsZW4pOwogCW5vZGUtPmNoaWxkbGVuIC09IGNoaWxkbGVuICsgMTsK LQlpZiAod3JpdGVfbm9kZShjb25uLCBub2RlLCB0cnVlKSkKLQkJY29ycnVw dChjb25uLCAiQ2FuJ3QgdXBkYXRlIHBhcmVudCBub2RlICclcyciLCBub2Rl LT5uYW1lKTsKKworCXJldHVybiB3cml0ZV9ub2RlKGNvbm4sIG5vZGUsIHRy dWUpOwogfQogCiBzdGF0aWMgdm9pZCBkZWxldGVfY2hpbGQoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCkBAIC0xNTIzLDcgKzE1MjMsOSBAQCBzdGF0aWMg dm9pZCBkZWxldGVfY2hpbGQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAK IAlmb3IgKGkgPSAwOyBpIDwgbm9kZS0+Y2hpbGRsZW47IGkgKz0gc3RybGVu KG5vZGUtPmNoaWxkcmVuK2kpICsgMSkgewogCQlpZiAoc3RyZXEobm9kZS0+ Y2hpbGRyZW4raSwgY2hpbGRuYW1lKSkgewotCQkJcmVtb3ZlX2NoaWxkX2Vu dHJ5KGNvbm4sIG5vZGUsIGkpOworCQkJaWYgKHJlbW92ZV9jaGlsZF9lbnRy eShjb25uLCBub2RlLCBpKSkKKwkJCQljb3JydXB0KGNvbm4sICJDYW4ndCB1 cGRhdGUgcGFyZW50IG5vZGUgJyVzJyIsCisJCQkJCW5vZGUtPm5hbWUpOwog CQkJcmV0dXJuOwogCQl9CiAJfQpAQCAtMjEyNSw2ICsyMTI3LDE3IEBAIGlu dCByZW1lbWJlcl9zdHJpbmcoc3RydWN0IGhhc2h0YWJsZSAqaGFzaCwgY29u c3QgY2hhciAqc3RyKQogCXJldHVybiBoYXNodGFibGVfaW5zZXJ0KGhhc2gs IGssICh2b2lkICopMSk7CiB9CiAKK3N0YXRpYyBpbnQgcm1fY2hpbGRfZW50 cnkoc3RydWN0IG5vZGUgKm5vZGUsIHNpemVfdCBvZmYsIHNpemVfdCBsZW4p Cit7CisJaWYgKCFyZWNvdmVyeSkKKwkJcmV0dXJuIG9mZjsKKworCWlmIChy ZW1vdmVfY2hpbGRfZW50cnkoTlVMTCwgbm9kZSwgb2ZmKSkKKwkJbG9nKCJj aGVja19zdG9yZTogY2hpbGQgZW50cnkgY291bGQgbm90IGJlIHJlbW92ZWQg ZnJvbSAnJXMnIiwKKwkJICAgIG5vZGUtPm5hbWUpOworCisJcmV0dXJuIG9m ZiAtIGxlbiAtIDE7Cit9CiAKIC8qKgogICogQSBub2RlIGhhcyBhIGNoaWxk cmVuIGZpZWxkIHRoYXQgbmFtZXMgdGhlIGNoaWxkcmVuIG9mIHRoZSBub2Rl LCBzZXBhcmF0ZWQKQEAgLTIxNzMsMTIgKzIxODYsNyBAQCBzdGF0aWMgaW50 IGNoZWNrX3N0b3JlXyhjb25zdCBjaGFyICpuYW1lLCBzdHJ1Y3QgaGFzaHRh YmxlICpyZWFjaGFibGUpCiAJCQkJaWYgKGhhc2h0YWJsZV9zZWFyY2goY2hp bGRyZW4sIGNoaWxkbmFtZSkpIHsKIAkJCQkJbG9nKCJjaGVja19zdG9yZTog JyVzJyBpcyBkdXBsaWNhdGVkISIsCiAJCQkJCSAgICBjaGlsZG5hbWUpOwot Ci0JCQkJCWlmIChyZWNvdmVyeSkgewotCQkJCQkJcmVtb3ZlX2NoaWxkX2Vu dHJ5KE5VTEwsIG5vZGUsCi0JCQkJCQkJCSAgIGkpOwotCQkJCQkJaSAtPSBj aGlsZGxlbiArIDE7Ci0JCQkJCX0KKwkJCQkJaSA9IHJtX2NoaWxkX2VudHJ5 KG5vZGUsIGksIGNoaWxkbGVuKTsKIAkJCQl9CiAJCQkJZWxzZSB7CiAJCQkJ CWlmICghcmVtZW1iZXJfc3RyaW5nKGNoaWxkcmVuLApAQCAtMjE5NSwxMSAr MjIwMyw3IEBAIHN0YXRpYyBpbnQgY2hlY2tfc3RvcmVfKGNvbnN0IGNoYXIg Km5hbWUsIHN0cnVjdCBoYXNodGFibGUgKnJlYWNoYWJsZSkKIAkJCX0gZWxz ZSBpZiAoZXJybm8gIT0gRU5PTUVNKSB7CiAJCQkJbG9nKCJjaGVja19zdG9y ZTogTm8gY2hpbGQgJyVzJyBmb3VuZCFcbiIsCiAJCQkJICAgIGNoaWxkbmFt ZSk7Ci0KLQkJCQlpZiAocmVjb3ZlcnkpIHsKLQkJCQkJcmVtb3ZlX2NoaWxk X2VudHJ5KE5VTEwsIG5vZGUsIGkpOwotCQkJCQlpIC09IGNoaWxkbGVuICsg MTsKLQkJCQl9CisJCQkJaSA9IHJtX2NoaWxkX2VudHJ5KG5vZGUsIGksIGNo aWxkbGVuKTsKIAkJCX0gZWxzZSB7CiAJCQkJbG9nKCJjaGVja19zdG9yZTog RU5PTUVNIik7CiAJCQkJcmV0ID0gRU5PTUVNOwo= --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.14-03.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.14-03.patch" Content-Transfer-Encoding: base64 RnJvbSA2MGU1YTFkZDQzNmEwZDU3NzgyMDhkZjczNDA0NGU2YzYxMGI4YTgx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTEgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBnZW5l cmljIHRyZWV3YWxrIGZ1bmN0aW9uCgpBZGQgYSBnZW5lcmljIGZ1bmN0aW9u IHRvIHdhbGsgdGhlIGNvbXBsZXRlIG5vZGUgdHJlZS4gSXQgd2lsbCBzdGFy dAphdCAiLyIgYW5kIGRlc2NlbmQgcmVjdXJzaXZlbHkgaW50byBlYWNoIGNo aWxkLCBjYWxsaW5nIGEgZnVuY3Rpb24Kc3BlY2lmaWVkIGJ5IHRoZSBjYWxs ZXIuIERlcGVuZGluZyBvbiB0aGUgcmV0dXJuIHZhbHVlIG9mIHRoZSB1c2Vy CnNwZWNpZmllZCBmdW5jdGlvbiB0aGUgd2FsayB3aWxsIGJlIGFib3J0ZWQs IGNvbnRpbnVlZCwgb3IgdGhlIGN1cnJlbnQKY2hpbGQgd2lsbCBiZSBza2lw cGVkIGJ5IG5vdCBkZXNjZW5kaW5nIGludG8gaXRzIGNoaWxkcmVuLgoKVGhp cyBpcyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9y dGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpT aWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ CkFja2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoK ZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IGNlZjlm YzFjMWUxMi4uNDc1NTlhODVkNGMyIDEwMDY0NAotLS0gYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKQEAgLTE3MzMsNiArMTczMywxMzUgQEAgc3RhdGlj IGludCBkb19zZXRfcGVybXMoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwKIAlyZXR1cm4gMDsKIH0KIAorc3RhdGljIGNoYXIg KmNoaWxkX25hbWUoY29uc3Qgdm9pZCAqY3R4LCBjb25zdCBjaGFyICpzMSwg Y29uc3QgY2hhciAqczIpCit7CisJaWYgKHN0cmNtcChzMSwgIi8iKSkKKwkJ cmV0dXJuIHRhbGxvY19hc3ByaW50ZihjdHgsICIlcy8lcyIsIHMxLCBzMik7 CisJcmV0dXJuIHRhbGxvY19hc3ByaW50ZihjdHgsICIvJXMiLCBzMik7Cit9 CisKK3N0YXRpYyBpbnQgcm1fZnJvbV9wYXJlbnQoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIHN0cnVjdCBub2RlICpwYXJlbnQsCisJCQkgIGNvbnN0IGNo YXIgKm5hbWUpCit7CisJc2l6ZV90IG9mZjsKKworCWlmICghcGFyZW50KQor CQlyZXR1cm4gV0FMS19UUkVFX0VSUk9SX1NUT1A7CisKKwlmb3IgKG9mZiA9 IHBhcmVudC0+Y2hpbGRvZmYgLSAxOyBvZmYgJiYgcGFyZW50LT5jaGlsZHJl bltvZmYgLSAxXTsKKwkgICAgIG9mZi0tKTsKKwlpZiAocmVtb3ZlX2NoaWxk X2VudHJ5KGNvbm4sIHBhcmVudCwgb2ZmKSkgeworCQlsb2coInRyZWV3YWxr OiBjaGlsZCBlbnRyeSBjb3VsZCBub3QgYmUgcmVtb3ZlZCBmcm9tICclcyci LAorCQkgICAgcGFyZW50LT5uYW1lKTsKKwkJcmV0dXJuIFdBTEtfVFJFRV9F UlJPUl9TVE9QOworCX0KKwlwYXJlbnQtPmNoaWxkb2ZmID0gb2ZmOworCisJ cmV0dXJuIFdBTEtfVFJFRV9PSzsKK30KKworc3RhdGljIGludCB3YWxrX2Nh bGxfZnVuYyhjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpj b25uLAorCQkJICBzdHJ1Y3Qgbm9kZSAqbm9kZSwgc3RydWN0IG5vZGUgKnBh cmVudCwgdm9pZCAqYXJnLAorCQkJICBpbnQgKCpmdW5jKShjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkJCSAgICAgIHN0 cnVjdCBub2RlICpub2RlLCB2b2lkICphcmcpKQoreworCWludCByZXQ7CisK KwlpZiAoIWZ1bmMpCisJCXJldHVybiBXQUxLX1RSRUVfT0s7CisKKwlyZXQg PSBmdW5jKGN0eCwgY29ubiwgbm9kZSwgYXJnKTsKKwlpZiAocmV0ID09IFdB TEtfVFJFRV9STV9DSElMREVOVFJZICYmIHBhcmVudCkKKwkJcmV0ID0gcm1f ZnJvbV9wYXJlbnQoY29ubiwgcGFyZW50LCBub2RlLT5uYW1lKTsKKworCXJl dHVybiByZXQ7Cit9CisKK2ludCB3YWxrX25vZGVfdHJlZShjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpy b290LAorCQkgICBzdHJ1Y3Qgd2Fsa19mdW5jcyAqZnVuY3MsIHZvaWQgKmFy ZykKK3sKKwlpbnQgcmV0ID0gMDsKKwl2b2lkICp0bXBjdHg7CisJY2hhciAq bmFtZTsKKwlzdHJ1Y3Qgbm9kZSAqbm9kZSA9IE5VTEw7CisJc3RydWN0IG5v ZGUgKnBhcmVudCA9IE5VTEw7CisKKwl0bXBjdHggPSB0YWxsb2NfbmV3KGN0 eCk7CisJaWYgKCF0bXBjdHgpIHsKKwkJZXJybm8gPSBFTk9NRU07CisJCXJl dHVybiBXQUxLX1RSRUVfRVJST1JfU1RPUDsKKwl9CisJbmFtZSA9IHRhbGxv Y19zdHJkdXAodG1wY3R4LCByb290KTsKKwlpZiAoIW5hbWUpIHsKKwkJZXJy bm8gPSBFTk9NRU07CisJCXRhbGxvY19mcmVlKHRtcGN0eCk7CisJCXJldHVy biBXQUxLX1RSRUVfRVJST1JfU1RPUDsKKwl9CisKKwkvKiBDb250aW51ZSB0 aGUgd2FsayB1bnRpbCBhbiBlcnJvciBpcyByZXR1cm5lZC4gKi8KKwl3aGls ZSAocmV0ID49IDApIHsKKwkJLyogbm9kZSA9PSBOVUxMIHBvc3NpYmxlIG9u bHkgZm9yIHRoZSBpbml0aWFsIGxvb3AgaXRlcmF0aW9uLiAqLworCQlpZiAo bm9kZSkgeworCQkJLyogR28gb25lIHN0ZXAgdXAgaWYgcmV0IG9yIGlmIGxh c3QgY2hpbGQgZmluaXNoZWQuICovCisJCQlpZiAocmV0IHx8IG5vZGUtPmNo aWxkb2ZmID49IG5vZGUtPmNoaWxkbGVuKSB7CisJCQkJcGFyZW50ID0gbm9k ZS0+cGFyZW50OworCQkJCS8qIENhbGwgZnVuY3Rpb24gQUZURVIgcHJvY2Vz c2luZyBhIG5vZGUuICovCisJCQkJcmV0ID0gd2Fsa19jYWxsX2Z1bmMoY3R4 LCBjb25uLCBub2RlLCBwYXJlbnQsCisJCQkJCQkgICAgIGFyZywgZnVuY3Mt PmV4aXQpOworCQkJCS8qIExhc3Qgbm9kZSwgc28gZXhpdCBsb29wLiAqLwor CQkJCWlmICghcGFyZW50KQorCQkJCQlicmVhazsKKwkJCQl0YWxsb2NfZnJl ZShub2RlKTsKKwkJCQkvKiBDb250aW51ZSB3aXRoIHBhcmVudC4gKi8KKwkJ CQlub2RlID0gcGFyZW50OworCQkJCWNvbnRpbnVlOworCQkJfQorCQkJLyog R2V0IG5leHQgY2hpbGQgb2YgY3VycmVudCBub2RlLiAqLworCQkJbmFtZSA9 IGNoaWxkX25hbWUodG1wY3R4LCBub2RlLT5uYW1lLAorCQkJCQkgIG5vZGUt PmNoaWxkcmVuICsgbm9kZS0+Y2hpbGRvZmYpOworCQkJaWYgKCFuYW1lKSB7 CisJCQkJcmV0ID0gV0FMS19UUkVFX0VSUk9SX1NUT1A7CisJCQkJYnJlYWs7 CisJCQl9CisJCQkvKiBQb2ludCB0byBuZXh0IGNoaWxkLiAqLworCQkJbm9k ZS0+Y2hpbGRvZmYgKz0gc3RybGVuKG5vZGUtPmNoaWxkcmVuICsKKwkJCQkJ CSBub2RlLT5jaGlsZG9mZikgKyAxOworCQkJLyogRGVzY2VudCBpbnRvIGNo aWxkcmVuLiAqLworCQkJcGFyZW50ID0gbm9kZTsKKwkJfQorCQkvKiBSZWFk IG5leHQgbm9kZSAocm9vdCBub2RlIG9yIG5leHQgY2hpbGQpLiAqLworCQlu b2RlID0gcmVhZF9ub2RlKGNvbm4sIHRtcGN0eCwgbmFtZSk7CisJCWlmICgh bm9kZSkgeworCQkJLyogQ2hpbGQgbm90IGZvdW5kIC0gc2hvdWxkIG5vdCBo YXBwZW4hICovCisJCQkvKiBFTk9FTlQgY2FzZSBjYW4gYmUgaGFuZGxlZCBi eSBzdXBwbGllZCBmdW5jdGlvbi4gKi8KKwkJCWlmIChlcnJubyA9PSBFTk9F TlQgJiYgZnVuY3MtPmVub2VudCkKKwkJCQlyZXQgPSBmdW5jcy0+ZW5vZW50 KGN0eCwgY29ubiwgcGFyZW50LCBuYW1lLAorCQkJCQkJICAgIGFyZyk7CisJ CQllbHNlCisJCQkJcmV0ID0gV0FMS19UUkVFX0VSUk9SX1NUT1A7CisJCQlp ZiAoIXBhcmVudCkKKwkJCQlicmVhazsKKwkJCWlmIChyZXQgPT0gV0FMS19U UkVFX1JNX0NISUxERU5UUlkpCisJCQkJcmV0ID0gcm1fZnJvbV9wYXJlbnQo Y29ubiwgcGFyZW50LCBuYW1lKTsKKwkJCWlmIChyZXQgPCAwKQorCQkJCWJy ZWFrOworCQkJdGFsbG9jX2ZyZWUobmFtZSk7CisJCQlub2RlID0gcGFyZW50 OworCQkJY29udGludWU7CisJCX0KKwkJdGFsbG9jX2ZyZWUobmFtZSk7CisJ CW5vZGUtPnBhcmVudCA9IHBhcmVudDsKKwkJbm9kZS0+Y2hpbGRvZmYgPSAw OworCQkvKiBDYWxsIGZ1bmN0aW9uIEJFRk9SRSBwcm9jZXNzaW5nIGEgbm9k ZS4gKi8KKwkJcmV0ID0gd2Fsa19jYWxsX2Z1bmMoY3R4LCBjb25uLCBub2Rl LCBwYXJlbnQsIGFyZywKKwkJCQkgICAgIGZ1bmNzLT5lbnRlcik7CisJfQor CisJdGFsbG9jX2ZyZWUodG1wY3R4KTsKKworCXJldHVybiByZXQgPCAwID8g cmV0IDogV0FMS19UUkVFX09LOworfQorCiBzdGF0aWMgc3RydWN0IHsKIAlj b25zdCBjaGFyICpzdHI7CiAJaW50ICgqZnVuYykoY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKQEAgLTIxMDUsMTggKzIyMzQs NiBAQCBzdGF0aWMgaW50IGtleXNfZXF1YWxfZm4odm9pZCAqa2V5MSwgdm9p ZCAqa2V5MikKIAlyZXR1cm4gMCA9PSBzdHJjbXAoKGNoYXIgKilrZXkxLCAo Y2hhciAqKWtleTIpOwogfQogCi0KLXN0YXRpYyBjaGFyICpjaGlsZF9uYW1l KGNvbnN0IGNoYXIgKnMxLCBjb25zdCBjaGFyICpzMikKLXsKLQlpZiAoc3Ry Y21wKHMxLCAiLyIpKSB7Ci0JCXJldHVybiB0YWxsb2NfYXNwcmludGYoTlVM TCwgIiVzLyVzIiwgczEsIHMyKTsKLQl9Ci0JZWxzZSB7Ci0JCXJldHVybiB0 YWxsb2NfYXNwcmludGYoTlVMTCwgIi8lcyIsIHMyKTsKLQl9Ci19Ci0KLQog aW50IHJlbWVtYmVyX3N0cmluZyhzdHJ1Y3QgaGFzaHRhYmxlICpoYXNoLCBj b25zdCBjaGFyICpzdHIpCiB7CiAJY2hhciAqayA9IG1hbGxvYyhzdHJsZW4o c3RyKSArIDEpOwpAQCAtMjE3Miw3ICsyMjg5LDcgQEAgc3RhdGljIGludCBj aGVja19zdG9yZV8oY29uc3QgY2hhciAqbmFtZSwgc3RydWN0IGhhc2h0YWJs ZSAqcmVhY2hhYmxlKQogCQl3aGlsZSAoaSA8IG5vZGUtPmNoaWxkbGVuICYm ICFyZXQpIHsKIAkJCXN0cnVjdCBub2RlICpjaGlsZG5vZGU7CiAJCQlzaXpl X3QgY2hpbGRsZW4gPSBzdHJsZW4obm9kZS0+Y2hpbGRyZW4gKyBpKTsKLQkJ CWNoYXIgKiBjaGlsZG5hbWUgPSBjaGlsZF9uYW1lKG5vZGUtPm5hbWUsCisJ CQljaGFyICogY2hpbGRuYW1lID0gY2hpbGRfbmFtZShOVUxMLCBub2RlLT5u YW1lLAogCQkJCQkJICAgICAgbm9kZS0+Y2hpbGRyZW4gKyBpKTsKIAogCQkJ aWYgKCFjaGlsZG5hbWUpIHsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5oCmluZGV4IDVhYmYwNmMyMWM5OC4uZmM5ODgyYWMzN2Q1IDEwMDY0 NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCisrKyBi L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKQEAgLTE2Nyw2ICsx NjcsNyBAQCBzdHJ1Y3Qgbm9kZSB7CiAKIAkvKiBDaGlsZHJlbiwgZWFjaCBu dWwtdGVybWluYXRlZC4gKi8KIAl1bnNpZ25lZCBpbnQgY2hpbGRsZW47CisJ dW5zaWduZWQgaW50IGNoaWxkb2ZmOwkvKiBVc2VkIGJ5IHdhbGtfbm9kZV90 cmVlKCkgaW50ZXJuYWxseS4gKi8KIAljaGFyICpjaGlsZHJlbjsKIAogCS8q IEFsbG9jYXRpb24gaW5mb3JtYXRpb24gZm9yIG5vZGUgY3VycmVudGx5IGlu IHN0b3JlLiAqLwpAQCAtMjc4LDYgKzI3OSw0NSBAQCBpbnQgZG9fdGRiX2Rl bGV0ZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgVERCX0RBVEEgKmtleSwK IAogdm9pZCBjb25uX2ZyZWVfYnVmZmVyZWRfZGF0YShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubik7CiAKKy8qCisgKiBXYWxrIHRoZSBub2RlIHRyZWUgYmVs b3cgcm9vdCBjYWxsaW5nIGZ1bmNzLT5lbnRlcigpIGFuZCBmdW5jcy0+ZXhp dCgpIGZvcgorICogZWFjaCBub2RlLiBmdW5jcy0+ZW50ZXIoKSBpcyBiZWlu ZyBjYWxsZWQgd2hlbiBlbnRlcmluZyBhIG5vZGUsIHNvIGJlZm9yZQorICog YW55IG9mIHRoZSBjaGlsZHJlbiBvZiB0aGUgbm9kZSBpcyBwcm9jZXNzZWQu IGZ1bmNzLT5leGl0KCkgaXMgYmVpbmcKKyAqIGNhbGxlZCB3aGVuIGxlYXZp bmcgdGhlIG5vZGUsIHNvIGFmdGVyIGFsbCBjaGlsZHJlbiBoYXZlIGJlZW4g cHJvY2Vzc2VkLgorICogZnVuY3MtPmVub2VudCgpIGlzIGJlaW5nIGNhbGxl ZCB3aGVuIGEgbm9kZSBpc24ndCBleGlzdGluZy4KKyAqIGZ1bmNzLT4qKCkg cmV0dXJuIHZhbHVlczoKKyAqICA8IDA6IHRyZWUgd2FsayBpcyBzdG9wcGVk LCB3YWxrX25vZGVfdHJlZSgpIHJldHVybnMgZnVuY3MtPiooKSByZXR1cm4g dmFsdWUKKyAqICAgICAgIGluIGNhc2UgV0FMS19UUkVFX0VSUk9SX1NUT1Ag aXMgcmV0dXJuZWQsIGVycm5vIHNob3VsZCBiZSBzZXQKKyAqICBXQUxLX1RS RUVfT0s6IHRyZWUgd2FsayBpcyBjb250aW51aW5nCisgKiAgV0FMS19UUkVF X1NLSVBfQ0hJTERSRU46IHRyZWUgd2FsayB3b24ndCBkZXNjZW5kIGJlbG93 IGN1cnJlbnQgbm9kZSwgYnV0CisgKiAgICAgICB3YWxrIGNvbnRpbnVlcwor ICogIFdBTEtfVFJFRV9STV9DSElMREVOVFJZOiBSZW1vdmUgdGhlIGNoaWxk IGVudHJ5IGZyb20gaXRzIHBhcmVudCBhbmQgd3JpdGUKKyAqICAgICAgIHRo ZSBtb2RpZmllZCBwYXJlbnQgbm9kZSBiYWNrIHRvIHRoZSBkYXRhIGJhc2Us IGltcGxpZXMgdG8gbm90IGRlc2NlbmQKKyAqICAgICAgIGJlbG93IHRoZSBj dXJyZW50IG5vZGUsIGJ1dCB0byBjb250aW51ZSB0aGUgd2FsaworICogZnVu Y3MtPiooKSBpcyBhbGxvd2VkIHRvIG1vZGlmeSB0aGUgbm9kZSBpdCBpcyBj YWxsZWQgZm9yIGluIHRoZSBkYXRhIGJhc2UuCisgKiBJbiBjYXNlIGZ1bmNz LT5lbnRlcigpIGlzIGRlbGV0aW5nIHRoZSBub2RlLCBpdCBtdXN0IG5vdCBy ZXR1cm4gV0FMS19UUkVFX09LCisgKiBpbiBvcmRlciB0byBhdm9pZCBkZXNj ZW5kaW5nIGludG8gbm8gbG9uZ2VyIGV4aXN0aW5nIGNoaWxkcmVuLgorICov CisvKiBSZXR1cm4gdmFsdWVzIGZvciBmdW5jcy0+KigpIGFuZCB3YWxrX25v ZGVfdHJlZSgpLiAqLworI2RlZmluZSBXQUxLX1RSRUVfU1VDQ0VTU19TVE9Q ICAtMTAwICAgIC8qIFN0b3Agd2FsayBlYXJseSwgbm8gZXJyb3IuICovCisj ZGVmaW5lIFdBTEtfVFJFRV9FUlJPUl9TVE9QICAgIC0xICAgICAgLyogU3Rv cCB3YWxrIGR1ZSB0byBlcnJvci4gKi8KKyNkZWZpbmUgV0FMS19UUkVFX09L ICAgICAgICAgICAgMCAgICAgICAvKiBObyBlcnJvci4gKi8KKy8qIFJldHVy biB2YWx1ZSBmb3IgZnVuY3MtPiooKSBvbmx5LiAqLworI2RlZmluZSBXQUxL X1RSRUVfU0tJUF9DSElMRFJFTiAxICAgICAgIC8qIERvbid0IHJlY3Vyc2Ug YmVsb3cgY3VycmVudCBub2RlLiAqLworI2RlZmluZSBXQUxLX1RSRUVfUk1f Q0hJTERFTlRSWSAyICAgICAgIC8qIFJlbW92ZSBjaGlsZCBlbnRyeSBmcm9t IHBhcmVudC4gKi8KKworc3RydWN0IHdhbGtfZnVuY3MgeworCWludCAoKmVu dGVyKShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25u LAorCQkgICAgIHN0cnVjdCBub2RlICpub2RlLCB2b2lkICphcmcpOworCWlu dCAoKmV4aXQpKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sCisJCSAgICBzdHJ1Y3Qgbm9kZSAqbm9kZSwgdm9pZCAqYXJnKTsK KwlpbnQgKCplbm9lbnQpKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sCisJCSAgICAgIHN0cnVjdCBub2RlICpwYXJlbnQsIGNo YXIgKm5hbWUsIHZvaWQgKmFyZyk7Cit9OworCitpbnQgd2Fsa19ub2RlX3Ry ZWUoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3QgY2hhciAqcm9vdCwKKwkJICAgc3RydWN0IHdhbGtfZnVuY3MgKmZ1 bmNzLCB2b2lkICphcmcpOworCiAjZW5kaWYgLyogX1hFTlNUT1JFRF9DT1JF X0ggKi8KIAogLyoK --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.14-04.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.14-04.patch" Content-Transfer-Encoding: base64 RnJvbSBkNThkMDY5YjBhZjVlNjRiNjY3NjA5NzIzYmEyNGFkNTI0MmZjOTIw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHNpbXBsaWZ5 IGNoZWNrX3N0b3JlKCkKCmNoZWNrX3N0b3JlKCkgaXMgdXNpbmcgYSBoYXNo IHRhYmxlIGZvciBzdG9yaW5nIGFsbCBub2RlIG5hbWVzIGl0IGhhcwpmb3Vu ZCB2aWEgd2Fsa2luZyB0aGUgdHJlZS4gQWRkaXRpb25hbGx5IGl0IHVzaW5n IGFub3RoZXIgaGFzaCB0YWJsZQpmb3IgYWxsIGNoaWxkcmVuIG9mIGEgbm9k ZSB0byBkZXRlY3QgZHVwbGljYXRlIGNoaWxkIG5hbWVzLgoKU2ltcGxpZnkg dGhhdCBieSBkcm9wcGluZyB0aGUgc2Vjb25kIGhhc2ggdGFibGUgYXMgdGhl IGZpcnN0IG9uZSBpcwphbHJlYWR5IGhvbGRpbmcgYWxsIHRoZSBuZWVkZWQg aW5mb3JtYXRpb24uCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQxOCAvIENWRS0y MDIyLTQyMzIxLgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8ZHZyYWJl bEBhbWF6b24uY28udWs+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3Mg PGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmMKaW5kZXggNDc1NTlhODVkNGMyLi4zMDJmYjViOTNjOWIgMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtMjI3Nyw0 NiArMjI3NywzNCBAQCBzdGF0aWMgaW50IGNoZWNrX3N0b3JlXyhjb25zdCBj aGFyICpuYW1lLCBzdHJ1Y3QgaGFzaHRhYmxlICpyZWFjaGFibGUpCiAJaWYg KG5vZGUpIHsKIAkJc2l6ZV90IGkgPSAwOwogCi0JCXN0cnVjdCBoYXNodGFi bGUgKiBjaGlsZHJlbiA9Ci0JCQljcmVhdGVfaGFzaHRhYmxlKDE2LCBoYXNo X2Zyb21fa2V5X2ZuLCBrZXlzX2VxdWFsX2ZuKTsKLQogCQlpZiAoIXJlbWVt YmVyX3N0cmluZyhyZWFjaGFibGUsIG5hbWUpKSB7Ci0JCQloYXNodGFibGVf ZGVzdHJveShjaGlsZHJlbiwgMCk7CiAJCQlsb2coImNoZWNrX3N0b3JlOiBF Tk9NRU0iKTsKIAkJCXJldHVybiBFTk9NRU07CiAJCX0KIAogCQl3aGlsZSAo aSA8IG5vZGUtPmNoaWxkbGVuICYmICFyZXQpIHsKLQkJCXN0cnVjdCBub2Rl ICpjaGlsZG5vZGU7CisJCQlzdHJ1Y3Qgbm9kZSAqY2hpbGRub2RlID0gTlVM TDsKIAkJCXNpemVfdCBjaGlsZGxlbiA9IHN0cmxlbihub2RlLT5jaGlsZHJl biArIGkpOwotCQkJY2hhciAqIGNoaWxkbmFtZSA9IGNoaWxkX25hbWUoTlVM TCwgbm9kZS0+bmFtZSwKLQkJCQkJCSAgICAgIG5vZGUtPmNoaWxkcmVuICsg aSk7CisJCQljaGFyICpjaGlsZG5hbWUgPSBjaGlsZF9uYW1lKE5VTEwsIG5v ZGUtPm5hbWUsCisJCQkJCQkgICAgIG5vZGUtPmNoaWxkcmVuICsgaSk7CiAK IAkJCWlmICghY2hpbGRuYW1lKSB7CiAJCQkJbG9nKCJjaGVja19zdG9yZTog RU5PTUVNIik7CiAJCQkJcmV0ID0gRU5PTUVNOwogCQkJCWJyZWFrOwogCQkJ fQorCisJCQlpZiAoaGFzaHRhYmxlX3NlYXJjaChyZWFjaGFibGUsIGNoaWxk bmFtZSkpIHsKKwkJCQlsb2coImNoZWNrX3N0b3JlOiAnJXMnIGlzIGR1cGxp Y2F0ZWQhIiwKKwkJCQkgICAgY2hpbGRuYW1lKTsKKwkJCQlpID0gcm1fY2hp bGRfZW50cnkobm9kZSwgaSwgY2hpbGRsZW4pOworCQkJCWdvdG8gbmV4dDsK KwkJCX0KKwogCQkJY2hpbGRub2RlID0gcmVhZF9ub2RlKE5VTEwsIGNoaWxk bmFtZSwgY2hpbGRuYW1lKTsKLQkJCQorCiAJCQlpZiAoY2hpbGRub2RlKSB7 Ci0JCQkJaWYgKGhhc2h0YWJsZV9zZWFyY2goY2hpbGRyZW4sIGNoaWxkbmFt ZSkpIHsKLQkJCQkJbG9nKCJjaGVja19zdG9yZTogJyVzJyBpcyBkdXBsaWNh dGVkISIsCi0JCQkJCSAgICBjaGlsZG5hbWUpOwotCQkJCQlpID0gcm1fY2hp bGRfZW50cnkobm9kZSwgaSwgY2hpbGRsZW4pOwotCQkJCX0KLQkJCQllbHNl IHsKLQkJCQkJaWYgKCFyZW1lbWJlcl9zdHJpbmcoY2hpbGRyZW4sCi0JCQkJ CQkJICAgICBjaGlsZG5hbWUpKSB7Ci0JCQkJCQlsb2coImNoZWNrX3N0b3Jl OiBFTk9NRU0iKTsKLQkJCQkJCXRhbGxvY19mcmVlKGNoaWxkbm9kZSk7Ci0J CQkJCQl0YWxsb2NfZnJlZShjaGlsZG5hbWUpOwotCQkJCQkJcmV0ID0gRU5P TUVNOwotCQkJCQkJYnJlYWs7Ci0JCQkJCX0KLQkJCQkJcmV0ID0gY2hlY2tf c3RvcmVfKGNoaWxkbmFtZSwKLQkJCQkJCQkgICByZWFjaGFibGUpOwotCQkJ CX0KKwkJCQlyZXQgPSBjaGVja19zdG9yZV8oY2hpbGRuYW1lLCByZWFjaGFi bGUpOwogCQkJfSBlbHNlIGlmIChlcnJubyAhPSBFTk9NRU0pIHsKIAkJCQls b2coImNoZWNrX3N0b3JlOiBObyBjaGlsZCAnJXMnIGZvdW5kIVxuIiwKIAkJ CQkgICAgY2hpbGRuYW1lKTsKQEAgLTIzMjYsMTkgKzIzMTQsMTggQEAgc3Rh dGljIGludCBjaGVja19zdG9yZV8oY29uc3QgY2hhciAqbmFtZSwgc3RydWN0 IGhhc2h0YWJsZSAqcmVhY2hhYmxlKQogCQkJCXJldCA9IEVOT01FTTsKIAkJ CX0KIAorIG5leHQ6CiAJCQl0YWxsb2NfZnJlZShjaGlsZG5vZGUpOwogCQkJ dGFsbG9jX2ZyZWUoY2hpbGRuYW1lKTsKIAkJCWkgKz0gY2hpbGRsZW4gKyAx OwogCQl9CiAKLQkJaGFzaHRhYmxlX2Rlc3Ryb3koY2hpbGRyZW4sIDAgLyog RG9uJ3QgZnJlZSB2YWx1ZXMgKHRoZXkgYXJlCi0JCQkJCQkgYWxsICh2b2lk ICopMSkgKi8pOwogCQl0YWxsb2NfZnJlZShub2RlKTsKIAl9IGVsc2UgaWYg KGVycm5vICE9IEVOT01FTSkgewogCQkvKiBJbXBvc3NpYmxlLCBiZWNhdXNl IG5vIGRhdGFiYXNlIHNob3VsZCBldmVyIGJlIHdpdGhvdXQgdGhlCiAJCSAg IHJvb3QsIGFuZCBvdGhlcndpc2UsIHdlJ3ZlIGp1c3QgY2hlY2tlZCBpbiBv dXIgY2FsbGVyCiAJCSAgICh3aGljaCBtYWRlIGEgcmVjdXJzaXZlIGNhbGwg dG8gZ2V0IGhlcmUpLiAqLwotCQkgICAKKwogCQlsb2coImNoZWNrX3N0b3Jl OiBObyBjaGlsZCAnJXMnIGZvdW5kOiBpbXBvc3NpYmxlISIsIG5hbWUpOwog CX0gZWxzZSB7CiAJCWxvZygiY2hlY2tfc3RvcmU6IEVOT01FTSIpOwo= --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.14-05.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.14-05.patch" Content-Transfer-Encoding: base64 RnJvbSBhYzI0ZGEzZmRlMTYyMTViNGJhNWYwY2M4ZDk2ODY4ODFlOTdiYjQy IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHVzZSB0cmVl d2FsayBmb3IgY2hlY2tfc3RvcmUoKQoKSW5zdGVhZCBvZiBkb2luZyBhbiBv cGVuIHRyZWUgd2FsayB1c2luZyBjYWxsIHJlY3Vyc2lvbiwgdXNlCndhbGtf bm9kZV90cmVlKCkgd2hlbiBjaGVja2luZyB0aGUgc3RvcmUgZm9yIGluY29u c2lzdGVuY2llcy4KClRoaXMgd2lsbCByZWR1Y2UgY29kZSBzaXplIGFuZCBh dm9pZCBtYW55IG5lc3RpbmcgbGV2ZWxzIG9mIGZ1bmN0aW9uCmNhbGxzIHdo aWNoIGNvdWxkIHBvdGVudGlhbGx5IGV4aGF1c3QgdGhlIHN0YWNrLgoKVGhp cyBpcyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9y dGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpT aWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ ClJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29t PgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IDMw MmZiNWI5M2M5Yi4uMWNjMTFkMGIxYzMwIDEwMDY0NAotLS0gYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMKQEAgLTIyNDQsMTggKzIyNDQsNiBAQCBpbnQg cmVtZW1iZXJfc3RyaW5nKHN0cnVjdCBoYXNodGFibGUgKmhhc2gsIGNvbnN0 IGNoYXIgKnN0cikKIAlyZXR1cm4gaGFzaHRhYmxlX2luc2VydChoYXNoLCBr LCAodm9pZCAqKTEpOwogfQogCi1zdGF0aWMgaW50IHJtX2NoaWxkX2VudHJ5 KHN0cnVjdCBub2RlICpub2RlLCBzaXplX3Qgb2ZmLCBzaXplX3QgbGVuKQot ewotCWlmICghcmVjb3ZlcnkpCi0JCXJldHVybiBvZmY7Ci0KLQlpZiAocmVt b3ZlX2NoaWxkX2VudHJ5KE5VTEwsIG5vZGUsIG9mZikpCi0JCWxvZygiY2hl Y2tfc3RvcmU6IGNoaWxkIGVudHJ5IGNvdWxkIG5vdCBiZSByZW1vdmVkIGZy b20gJyVzJyIsCi0JCSAgICBub2RlLT5uYW1lKTsKLQotCXJldHVybiBvZmYg LSBsZW4gLSAxOwotfQotCiAvKioKICAqIEEgbm9kZSBoYXMgYSBjaGlsZHJl biBmaWVsZCB0aGF0IG5hbWVzIHRoZSBjaGlsZHJlbiBvZiB0aGUgbm9kZSwg c2VwYXJhdGVkCiAgKiBieSBOVUxzLiAgV2UgY2hlY2sgd2hldGhlciB0aGVy ZSBhcmUgZW50cmllcyBpbiB0aGVyZSB0aGF0IGFyZSBkdXBsaWNhdGVkCkBA IC0yMjY5LDcwICsyMjU3LDI5IEBAIHN0YXRpYyBpbnQgcm1fY2hpbGRfZW50 cnkoc3RydWN0IG5vZGUgKm5vZGUsIHNpemVfdCBvZmYsIHNpemVfdCBsZW4p CiAgKiBBcyB3ZSBnbywgd2UgcmVjb3JkIGVhY2ggbm9kZSBpbiB0aGUgZ2l2 ZW4gcmVhY2hhYmxlIGhhc2h0YWJsZS4gIFRoZXNlCiAgKiBlbnRyaWVzIHdp bGwgYmUgdXNlZCBsYXRlciBpbiBjbGVhbl9zdG9yZS4KICAqLwotc3RhdGlj IGludCBjaGVja19zdG9yZV8oY29uc3QgY2hhciAqbmFtZSwgc3RydWN0IGhh c2h0YWJsZSAqcmVhY2hhYmxlKQorc3RhdGljIGludCBjaGVja19zdG9yZV9z dGVwKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s CisJCQkgICAgc3RydWN0IG5vZGUgKm5vZGUsIHZvaWQgKmFyZykKIHsKLQlz dHJ1Y3Qgbm9kZSAqbm9kZSA9IHJlYWRfbm9kZShOVUxMLCBuYW1lLCBuYW1l KTsKLQlpbnQgcmV0ID0gMDsKLQotCWlmIChub2RlKSB7Ci0JCXNpemVfdCBp ID0gMDsKLQotCQlpZiAoIXJlbWVtYmVyX3N0cmluZyhyZWFjaGFibGUsIG5h bWUpKSB7Ci0JCQlsb2coImNoZWNrX3N0b3JlOiBFTk9NRU0iKTsKLQkJCXJl dHVybiBFTk9NRU07Ci0JCX0KLQotCQl3aGlsZSAoaSA8IG5vZGUtPmNoaWxk bGVuICYmICFyZXQpIHsKLQkJCXN0cnVjdCBub2RlICpjaGlsZG5vZGUgPSBO VUxMOwotCQkJc2l6ZV90IGNoaWxkbGVuID0gc3RybGVuKG5vZGUtPmNoaWxk cmVuICsgaSk7Ci0JCQljaGFyICpjaGlsZG5hbWUgPSBjaGlsZF9uYW1lKE5V TEwsIG5vZGUtPm5hbWUsCi0JCQkJCQkgICAgIG5vZGUtPmNoaWxkcmVuICsg aSk7Ci0KLQkJCWlmICghY2hpbGRuYW1lKSB7Ci0JCQkJbG9nKCJjaGVja19z dG9yZTogRU5PTUVNIik7Ci0JCQkJcmV0ID0gRU5PTUVNOwotCQkJCWJyZWFr OwotCQkJfQotCi0JCQlpZiAoaGFzaHRhYmxlX3NlYXJjaChyZWFjaGFibGUs IGNoaWxkbmFtZSkpIHsKLQkJCQlsb2coImNoZWNrX3N0b3JlOiAnJXMnIGlz IGR1cGxpY2F0ZWQhIiwKLQkJCQkgICAgY2hpbGRuYW1lKTsKLQkJCQlpID0g cm1fY2hpbGRfZW50cnkobm9kZSwgaSwgY2hpbGRsZW4pOwotCQkJCWdvdG8g bmV4dDsKLQkJCX0KKwlzdHJ1Y3QgaGFzaHRhYmxlICpyZWFjaGFibGUgPSBh cmc7CiAKLQkJCWNoaWxkbm9kZSA9IHJlYWRfbm9kZShOVUxMLCBjaGlsZG5h bWUsIGNoaWxkbmFtZSk7Ci0KLQkJCWlmIChjaGlsZG5vZGUpIHsKLQkJCQly ZXQgPSBjaGVja19zdG9yZV8oY2hpbGRuYW1lLCByZWFjaGFibGUpOwotCQkJ fSBlbHNlIGlmIChlcnJubyAhPSBFTk9NRU0pIHsKLQkJCQlsb2coImNoZWNr X3N0b3JlOiBObyBjaGlsZCAnJXMnIGZvdW5kIVxuIiwKLQkJCQkgICAgY2hp bGRuYW1lKTsKLQkJCQlpID0gcm1fY2hpbGRfZW50cnkobm9kZSwgaSwgY2hp bGRsZW4pOwotCQkJfSBlbHNlIHsKLQkJCQlsb2coImNoZWNrX3N0b3JlOiBF Tk9NRU0iKTsKLQkJCQlyZXQgPSBFTk9NRU07Ci0JCQl9CisJaWYgKGhhc2h0 YWJsZV9zZWFyY2gocmVhY2hhYmxlLCAodm9pZCAqKW5vZGUtPm5hbWUpKSB7 CisJCWxvZygiY2hlY2tfc3RvcmU6ICclcycgaXMgZHVwbGljYXRlZCEiLCBu b2RlLT5uYW1lKTsKKwkJcmV0dXJuIHJlY292ZXJ5ID8gV0FMS19UUkVFX1JN X0NISUxERU5UUlkKKwkJCQk6IFdBTEtfVFJFRV9TS0lQX0NISUxEUkVOOwor CX0KIAotIG5leHQ6Ci0JCQl0YWxsb2NfZnJlZShjaGlsZG5vZGUpOwotCQkJ dGFsbG9jX2ZyZWUoY2hpbGRuYW1lKTsKLQkJCWkgKz0gY2hpbGRsZW4gKyAx OwotCQl9CisJaWYgKCFyZW1lbWJlcl9zdHJpbmcocmVhY2hhYmxlLCBub2Rl LT5uYW1lKSkKKwkJcmV0dXJuIFdBTEtfVFJFRV9FUlJPUl9TVE9QOwogCi0J CXRhbGxvY19mcmVlKG5vZGUpOwotCX0gZWxzZSBpZiAoZXJybm8gIT0gRU5P TUVNKSB7Ci0JCS8qIEltcG9zc2libGUsIGJlY2F1c2Ugbm8gZGF0YWJhc2Ug c2hvdWxkIGV2ZXIgYmUgd2l0aG91dCB0aGUKLQkJICAgcm9vdCwgYW5kIG90 aGVyd2lzZSwgd2UndmUganVzdCBjaGVja2VkIGluIG91ciBjYWxsZXIKLQkJ ICAgKHdoaWNoIG1hZGUgYSByZWN1cnNpdmUgY2FsbCB0byBnZXQgaGVyZSku ICovCisJcmV0dXJuIFdBTEtfVFJFRV9PSzsKK30KIAotCQlsb2coImNoZWNr X3N0b3JlOiBObyBjaGlsZCAnJXMnIGZvdW5kOiBpbXBvc3NpYmxlISIsIG5h bWUpOwotCX0gZWxzZSB7Ci0JCWxvZygiY2hlY2tfc3RvcmU6IEVOT01FTSIp OwotCQlyZXQgPSBFTk9NRU07Ci0JfQorc3RhdGljIGludCBjaGVja19zdG9y ZV9lbm9lbnQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwKKwkJCSAgICAgIHN0cnVjdCBub2RlICpwYXJlbnQsIGNoYXIgKm5h bWUsIHZvaWQgKmFyZykKK3sKKwlsb2coImNoZWNrX3N0b3JlOiBub2RlICcl cycgbm90IGZvdW5kIiwgbmFtZSk7CiAKLQlyZXR1cm4gcmV0OworCXJldHVy biByZWNvdmVyeSA/IFdBTEtfVFJFRV9STV9DSElMREVOVFJZIDogV0FMS19U UkVFX09LOwogfQogCiAKQEAgLTIzODEsMjQgKzIzMjgsMjggQEAgc3RhdGlj IHZvaWQgY2xlYW5fc3RvcmUoc3RydWN0IGhhc2h0YWJsZSAqcmVhY2hhYmxl KQogCiB2b2lkIGNoZWNrX3N0b3JlKHZvaWQpCiB7Ci0JY2hhciAqIHJvb3Qg PSB0YWxsb2Nfc3RyZHVwKE5VTEwsICIvIik7Ci0Jc3RydWN0IGhhc2h0YWJs ZSAqIHJlYWNoYWJsZSA9Ci0JCWNyZWF0ZV9oYXNodGFibGUoMTYsIGhhc2hf ZnJvbV9rZXlfZm4sIGtleXNfZXF1YWxfZm4pOwotIAorCXN0cnVjdCBoYXNo dGFibGUgKnJlYWNoYWJsZTsKKwlzdHJ1Y3Qgd2Fsa19mdW5jcyB3YWxrZnVu Y3MgPSB7CisJCS5lbnRlciA9IGNoZWNrX3N0b3JlX3N0ZXAsCisJCS5lbm9l bnQgPSBjaGVja19zdG9yZV9lbm9lbnQsCisJfTsKKworCXJlYWNoYWJsZSA9 IGNyZWF0ZV9oYXNodGFibGUoMTYsIGhhc2hfZnJvbV9rZXlfZm4sIGtleXNf ZXF1YWxfZm4pOwogCWlmICghcmVhY2hhYmxlKSB7CiAJCWxvZygiY2hlY2tf c3RvcmU6IEVOT01FTSIpOwogCQlyZXR1cm47CiAJfQogCiAJbG9nKCJDaGVj a2luZyBzdG9yZSAuLi4iKTsKLQlpZiAoIWNoZWNrX3N0b3JlXyhyb290LCBy ZWFjaGFibGUpICYmCi0JICAgICFjaGVja190cmFuc2FjdGlvbnMocmVhY2hh YmxlKSkKKwlpZiAod2Fsa19ub2RlX3RyZWUoTlVMTCwgTlVMTCwgIi8iLCAm d2Fsa2Z1bmNzLCByZWFjaGFibGUpKSB7CisJCWlmIChlcnJubyA9PSBFTk9N RU0pCisJCQlsb2coImNoZWNrX3N0b3JlOiBFTk9NRU0iKTsKKwl9IGVsc2Ug aWYgKCFjaGVja190cmFuc2FjdGlvbnMocmVhY2hhYmxlKSkKIAkJY2xlYW5f c3RvcmUocmVhY2hhYmxlKTsKIAlsb2coIkNoZWNraW5nIHN0b3JlIGNvbXBs ZXRlLiIpOwogCiAJaGFzaHRhYmxlX2Rlc3Ryb3kocmVhY2hhYmxlLCAwIC8q IERvbid0IGZyZWUgdmFsdWVzICh0aGV5IGFyZSBhbGwKIAkJCQkJICAodm9p ZCAqKTEpICovKTsKLQl0YWxsb2NfZnJlZShyb290KTsKIH0KIAogCg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.14-06.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.14-06.patch" Content-Transfer-Encoding: base64 RnJvbSA1NmQwMmVlYTRlNzc0MGU0ZTE0MGNmMzE3YzZlYzNkYWE3NGEzZTg5 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHVzZSB0cmVl d2FsayBmb3IgZGVsZXRpbmcgbm9kZXMKCkluc3RlYWQgb2YgZG9pbmcgYW4g b3BlbiB0cmVlIHdhbGsgdXNpbmcgY2FsbCByZWN1cnNpb24sIHVzZQp3YWxr X25vZGVfdHJlZSgpIHdoZW4gZGVsZXRpbmcgYSBzdWItdHJlZSBvZiBub2Rl cy4KClRoaXMgd2lsbCByZWR1Y2UgY29kZSBzaXplIGFuZCBhdm9pZCBtYW55 IG5lc3RpbmcgbGV2ZWxzIG9mIGZ1bmN0aW9uCmNhbGxzIHdoaWNoIGNvdWxk IHBvdGVudGlhbGx5IGV4aGF1c3QgdGhlIHN0YWNrLgoKVGhpcyBpcyBwYXJ0 IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9ydGVkLWJ5OiBK dWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpTaWduZWQtb2Zm LWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+CkFja2VkLWJ5 OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdp dCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IDFjYzExZDBiMWMzMC4u NWJiN2I4NTIxMzI0IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMKQEAgLTEyMzMsMjEgKzEyMzMsNiBAQCBzdGF0aWMgaW50IGRvX3Jl YWQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwK IAlyZXR1cm4gMDsKIH0KIAotc3RhdGljIHZvaWQgZGVsZXRlX25vZGVfc2lu Z2xlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9k ZSkKLXsKLQlUREJfREFUQSBrZXk7Ci0KLQlpZiAoYWNjZXNzX25vZGUoY29u biwgbm9kZSwgTk9ERV9BQ0NFU1NfREVMRVRFLCAma2V5KSkKLQkJcmV0dXJu OwotCi0JaWYgKGRvX3RkYl9kZWxldGUoY29ubiwgJmtleSwgJm5vZGUtPmFj YykgIT0gMCkgewotCQljb3JydXB0KGNvbm4sICJDb3VsZCBub3QgZGVsZXRl ICclcyciLCBub2RlLT5uYW1lKTsKLQkJcmV0dXJuOwotCX0KLQotCWRvbWFp bl9lbnRyeV9kZWMoY29ubiwgbm9kZSk7Ci19Ci0KIC8qIE11c3Qgbm90IGJl IC8gKi8KIHN0YXRpYyBjaGFyICpiYXNlbmFtZShjb25zdCBjaGFyICpuYW1l KQogewpAQCAtMTUxNiw2OSArMTUwMSw1OSBAQCBzdGF0aWMgaW50IHJlbW92 ZV9jaGlsZF9lbnRyeShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0 IG5vZGUgKm5vZGUsCiAJcmV0dXJuIHdyaXRlX25vZGUoY29ubiwgbm9kZSwg dHJ1ZSk7CiB9CiAKLXN0YXRpYyB2b2lkIGRlbGV0ZV9jaGlsZChzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKLQkJCSBzdHJ1Y3Qgbm9kZSAqbm9kZSwgY29u c3QgY2hhciAqY2hpbGRuYW1lKQorc3RhdGljIGludCBkZWxldGVfY2hpbGQo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCQlzdHJ1Y3Qgbm9kZSAqbm9k ZSwgY29uc3QgY2hhciAqY2hpbGRuYW1lKQogewogCXVuc2lnbmVkIGludCBp OwogCiAJZm9yIChpID0gMDsgaSA8IG5vZGUtPmNoaWxkbGVuOyBpICs9IHN0 cmxlbihub2RlLT5jaGlsZHJlbitpKSArIDEpIHsKIAkJaWYgKHN0cmVxKG5v ZGUtPmNoaWxkcmVuK2ksIGNoaWxkbmFtZSkpIHsKLQkJCWlmIChyZW1vdmVf Y2hpbGRfZW50cnkoY29ubiwgbm9kZSwgaSkpCi0JCQkJY29ycnVwdChjb25u LCAiQ2FuJ3QgdXBkYXRlIHBhcmVudCBub2RlICclcyciLAotCQkJCQlub2Rl LT5uYW1lKTsKLQkJCXJldHVybjsKKwkJCWVycm5vID0gcmVtb3ZlX2NoaWxk X2VudHJ5KGNvbm4sIG5vZGUsIGkpID8gRUlPIDogMDsKKwkJCXJldHVybiBl cnJubzsKIAkJfQogCX0KIAljb3JydXB0KGNvbm4sICJDYW4ndCBmaW5kIGNo aWxkICclcycgaW4gJXMiLCBjaGlsZG5hbWUsIG5vZGUtPm5hbWUpOworCisJ ZXJybm8gPSBFSU87CisJcmV0dXJuIGVycm5vOwogfQogCi1zdGF0aWMgaW50 IGRlbGV0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2 b2lkICpjdHgsCi0JCSAgICAgICBzdHJ1Y3Qgbm9kZSAqcGFyZW50LCBzdHJ1 Y3Qgbm9kZSAqbm9kZSwgYm9vbCB3YXRjaF9leGFjdCkKK3N0YXRpYyBpbnQg ZGVsbm9kZV9zdWIoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwKKwkJICAgICAgIHN0cnVjdCBub2RlICpub2RlLCB2b2lkICph cmcpCiB7Ci0JY2hhciAqbmFtZTsKKwljb25zdCBjaGFyICpyb290ID0gYXJn OworCWJvb2wgd2F0Y2hfZXhhY3Q7CisJaW50IHJldDsKKwlUREJfREFUQSBr ZXk7CiAKLQkvKiBEZWxldGUgY2hpbGRyZW4uICovCi0Jd2hpbGUgKG5vZGUt PmNoaWxkbGVuKSB7Ci0JCXN0cnVjdCBub2RlICpjaGlsZDsKKwkvKiBBbnkg ZXJyb3IgaGVyZSB3aWxsIHByb2JhYmx5IGJlIHJlcGVhdGVkIGZvciBhbGwg Zm9sbG93aW5nIGNhbGxzLiAqLworCXJldCA9IGFjY2Vzc19ub2RlKGNvbm4s IG5vZGUsIE5PREVfQUNDRVNTX0RFTEVURSwgJmtleSk7CisJaWYgKHJldCA+ IDApCisJCXJldHVybiBXQUxLX1RSRUVfU1VDQ0VTU19TVE9QOwogCi0JCW5h bWUgPSB0YWxsb2NfYXNwcmludGYobm9kZSwgIiVzLyVzIiwgbm9kZS0+bmFt ZSwKLQkJCQkgICAgICAgbm9kZS0+Y2hpbGRyZW4pOwotCQljaGlsZCA9IG5h bWUgPyByZWFkX25vZGUoY29ubiwgbm9kZSwgbmFtZSkgOiBOVUxMOwotCQlp ZiAoY2hpbGQpIHsKLQkJCWlmIChkZWxldGVfbm9kZShjb25uLCBjdHgsIG5v ZGUsIGNoaWxkLCB0cnVlKSkKLQkJCQlyZXR1cm4gZXJybm87Ci0JCX0gZWxz ZSB7Ci0JCQl0cmFjZSgiZGVsZXRlX25vZGU6IEVycm9yIGRlbGV0aW5nIGNo aWxkICclcy8lcychXG4iLAotCQkJICAgICAgbm9kZS0+bmFtZSwgbm9kZS0+ Y2hpbGRyZW4pOwotCQkJLyogUXVpdCBkZWxldGluZy4gKi8KLQkJCWVycm5v ID0gRU5PTUVNOwotCQkJcmV0dXJuIGVycm5vOwotCQl9Ci0JCXRhbGxvY19m cmVlKG5hbWUpOwotCX0KKwkvKiBJbiBjYXNlIG9mIGVycm9yIHN0b3AgdGhl IHdhbGsuICovCisJaWYgKCFyZXQgJiYgZG9fdGRiX2RlbGV0ZShjb25uLCAm a2V5LCAmbm9kZS0+YWNjKSkKKwkJcmV0dXJuIFdBTEtfVFJFRV9TVUNDRVNT X1NUT1A7CiAKIAkvKgogCSAqIEZpcmUgdGhlIHdhdGNoZXMgbm93LCB3aGVu IHdlIGNhbiBzdGlsbCBzZWUgdGhlIG5vZGUgcGVybWlzc2lvbnMuCiAJICog VGhpcyBmaW5lIGFzIHdlIGFyZSBzaW5nbGUgdGhyZWFkZWQgYW5kIHRoZSBu ZXh0IHBvc3NpYmxlIHJlYWQgd2lsbAogCSAqIGJlIGhhbmRsZWQgb25seSBh ZnRlciB0aGUgbm9kZSBoYXMgYmVlbiByZWFsbHkgcmVtb3ZlZC4KLQkgKi8K KwkqLworCXdhdGNoX2V4YWN0ID0gc3RyY21wKHJvb3QsIG5vZGUtPm5hbWUp OwogCWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5vZGUtPm5hbWUsIG5vZGUs IHdhdGNoX2V4YWN0LCBOVUxMKTsKLQlkZWxldGVfbm9kZV9zaW5nbGUoY29u biwgbm9kZSk7Ci0JZGVsZXRlX2NoaWxkKGNvbm4sIHBhcmVudCwgYmFzZW5h bWUobm9kZS0+bmFtZSkpOwotCXRhbGxvY19mcmVlKG5vZGUpOwogCi0JcmV0 dXJuIDA7CisJZG9tYWluX2VudHJ5X2RlYyhjb25uLCBub2RlKTsKKworCXJl dHVybiBXQUxLX1RSRUVfUk1fQ0hJTERFTlRSWTsKIH0KIAotc3RhdGljIGlu dCBfcm0oc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0 eCwgc3RydWN0IG5vZGUgKm5vZGUsCi0JICAgICAgIGNvbnN0IGNoYXIgKm5h bWUpCitzdGF0aWMgaW50IF9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3Qgdm9pZCAqY3R4LCBjb25zdCBjaGFyICpuYW1lKQogewotCS8qCi0J ICogRGVsZXRpbmcgbm9kZSBieSBub2RlLCBzbyB0aGUgcmVzdWx0IGlzIGFs d2F5cyBjb25zaXN0ZW50IGV2ZW4gaW4KLQkgKiBjYXNlIG9mIGEgZmFpbHVy ZS4KLQkgKi8KIAlzdHJ1Y3Qgbm9kZSAqcGFyZW50OwogCWNoYXIgKnBhcmVu dG5hbWUgPSBnZXRfcGFyZW50KGN0eCwgbmFtZSk7CisJc3RydWN0IHdhbGtf ZnVuY3Mgd2Fsa2Z1bmNzID0geyAuZXhpdCA9IGRlbG5vZGVfc3ViIH07CisJ aW50IHJldDsKIAogCWlmICghcGFyZW50bmFtZSkKIAkJcmV0dXJuIGVycm5v OwpAQCAtMTU4Niw5ICsxNTYxLDIxIEBAIHN0YXRpYyBpbnQgX3JtKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBu b2RlICpub2RlLAogCXBhcmVudCA9IHJlYWRfbm9kZShjb25uLCBjdHgsIHBh cmVudG5hbWUpOwogCWlmICghcGFyZW50KQogCQlyZXR1cm4gcmVhZF9ub2Rl X2Nhbl9wcm9wYWdhdGVfZXJybm8oKSA/IGVycm5vIDogRUlOVkFMOwotCW5v ZGUtPnBhcmVudCA9IHBhcmVudDsKIAotCXJldHVybiBkZWxldGVfbm9kZShj b25uLCBjdHgsIHBhcmVudCwgbm9kZSwgZmFsc2UpOworCXJldCA9IHdhbGtf bm9kZV90cmVlKGN0eCwgY29ubiwgbmFtZSwgJndhbGtmdW5jcywgKHZvaWQg KiluYW1lKTsKKwlpZiAocmV0IDwgMCkgeworCQlpZiAocmV0ID09IFdBTEtf VFJFRV9FUlJPUl9TVE9QKSB7CisJCQljb3JydXB0KGNvbm4sICJlcnJvciB3 aGVuIGRlbGV0aW5nIHN1Yi1ub2RlcyBvZiAlc1xuIiwKKwkJCQluYW1lKTsK KwkJCWVycm5vID0gRUlPOworCQl9CisJCXJldHVybiBlcnJubzsKKwl9CisK KwlpZiAoZGVsZXRlX2NoaWxkKGNvbm4sIHBhcmVudCwgYmFzZW5hbWUobmFt ZSkpKQorCQlyZXR1cm4gZXJybm87CisKKwlyZXR1cm4gMDsKIH0KIAogCkBA IC0xNjIzLDcgKzE2MTAsNyBAQCBzdGF0aWMgaW50IGRvX3JtKGNvbnN0IHZv aWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJaWYgKHN0cmVx KG5hbWUsICIvIikpCiAJCXJldHVybiBFSU5WQUw7CiAKLQlyZXQgPSBfcm0o Y29ubiwgY3R4LCBub2RlLCBuYW1lKTsKKwlyZXQgPSBfcm0oY29ubiwgY3R4 LCBuYW1lKTsKIAlpZiAocmV0KQogCQlyZXR1cm4gcmV0OwogCg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.15-01.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.15-01.patch" Content-Transfer-Encoding: base64 RnJvbSA5MmZhNDg5MjFjMTdjZWJlNmI2MWMxNjFmN2ZmNWRmYTI3OTc1YTE4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTEgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHJlbW92ZSBy ZWN1cnNpb24gZnJvbSBjb25zdHJ1Y3Rfbm9kZSgpCgpJbiBvcmRlciB0byBy ZWR1Y2Ugc3RhY2sgdXNhZ2UgZHVlIHRvIHJlY3Vyc2lvbiwgc3dpdGNoCmNv bnN0cnVjdF9ub2RlKCkgdG8gdXNlIGEgbG9vcCBpbnN0ZWFkLgoKVGhpcyBp cyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9ydGVk LWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpTaWdu ZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJl dmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoK ZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IDhhZWNk NDI1ZjI3NC4uNDZhMzdlNTI1N2U1IDEwMDY0NAotLS0gYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKQEAgLTEzNDMsNDUgKzEzNDMsNjkgQEAgc3RhdGlj IGludCBhZGRfY2hpbGQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3Qgbm9kZSAq cGFyZW50LCBjb25zdCBjaGFyICpuYW1lKQogc3RhdGljIHN0cnVjdCBub2Rl ICpjb25zdHJ1Y3Rfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29u c3Qgdm9pZCAqY3R4LAogCQkJCSAgIGNvbnN0IGNoYXIgKm5hbWUpCiB7Ci0J c3RydWN0IG5vZGUgKnBhcmVudCwgKm5vZGU7Ci0JY2hhciAqcGFyZW50bmFt ZSA9IGdldF9wYXJlbnQoY3R4LCBuYW1lKTsKKwljb25zdCBjaGFyICoqbmFt ZXMgPSBOVUxMOworCXVuc2lnbmVkIGludCBsZXZlbHMgPSAwOworCXN0cnVj dCBub2RlICpub2RlID0gTlVMTDsKKwlzdHJ1Y3Qgbm9kZSAqcGFyZW50ID0g TlVMTDsKKwljb25zdCBjaGFyICpwYXJlbnRuYW1lID0gdGFsbG9jX3N0cmR1 cChjdHgsIG5hbWUpOwogCiAJaWYgKCFwYXJlbnRuYW1lKQogCQlyZXR1cm4g TlVMTDsKIAotCS8qIElmIHBhcmVudCBkb2Vzbid0IGV4aXN0LCBjcmVhdGUg aXQuICovCi0JcGFyZW50ID0gcmVhZF9ub2RlKGNvbm4sIHBhcmVudG5hbWUs IHBhcmVudG5hbWUpOwotCWlmICghcGFyZW50ICYmIGVycm5vID09IEVOT0VO VCkKLQkJcGFyZW50ID0gY29uc3RydWN0X25vZGUoY29ubiwgY3R4LCBwYXJl bnRuYW1lKTsKLQlpZiAoIXBhcmVudCkKLQkJcmV0dXJuIE5VTEw7CisJLyog V2FsayB0aGUgcGF0aCB1cCB1bnRpbCBhbiBleGlzdGluZyBub2RlIGlzIGZv dW5kLiAqLworCXdoaWxlICghcGFyZW50KSB7CisJCW5hbWVzID0gdGFsbG9j X3JlYWxsb2MoY3R4LCBuYW1lcywgY29uc3QgY2hhciAqLCBsZXZlbHMgKyAx KTsKKwkJaWYgKCFuYW1lcykKKwkJCWdvdG8gbm9tZW07CiAKLQkvKiBBZGQg Y2hpbGQgdG8gcGFyZW50LiAqLwotCWlmIChhZGRfY2hpbGQoY3R4LCBwYXJl bnQsIG5hbWUpKQotCQlnb3RvIG5vbWVtOworCQkvKgorCQkgKiBuYW1lc1sw XSBpcyB0aGUgbmFtZSBvZiB0aGUgbm9kZSB0byBjb25zdHJ1Y3QgaW5pdGlh bGx5LAorCQkgKiBuYW1lc1sxXSBpcyBpdHMgcGFyZW50LCBhbmQgc28gb24u CisJCSAqLworCQluYW1lc1tsZXZlbHNdID0gcGFyZW50bmFtZTsKKwkJcGFy ZW50bmFtZSA9IGdldF9wYXJlbnQoY3R4LCBwYXJlbnRuYW1lKTsKKwkJaWYg KCFwYXJlbnRuYW1lKQorCQkJcmV0dXJuIE5VTEw7CiAKLQkvKiBBbGxvY2F0 ZSBub2RlICovCi0Jbm9kZSA9IHRhbGxvYyhjdHgsIHN0cnVjdCBub2RlKTsK LQlpZiAoIW5vZGUpCi0JCWdvdG8gbm9tZW07Ci0Jbm9kZS0+bmFtZSA9IHRh bGxvY19zdHJkdXAobm9kZSwgbmFtZSk7Ci0JaWYgKCFub2RlLT5uYW1lKQot CQlnb3RvIG5vbWVtOworCQkvKiBUcnkgdG8gcmVhZCBwYXJlbnQgbm9kZSB1 bnRpbCB3ZSBmb3VuZCBhbiBleGlzdGluZyBvbmUuICovCisJCXBhcmVudCA9 IHJlYWRfbm9kZShjb25uLCBjdHgsIHBhcmVudG5hbWUpOworCQlpZiAoIXBh cmVudCAmJiAoZXJybm8gIT0gRU5PRU5UIHx8ICFzdHJjbXAocGFyZW50bmFt ZSwgIi8iKSkpCisJCQlyZXR1cm4gTlVMTDsKIAotCS8qIEluaGVyaXQgcGVy bWlzc2lvbnMsIGV4Y2VwdCB1bnByaXZpbGVnZWQgZG9tYWlucyBvd24gd2hh dCB0aGV5IGNyZWF0ZSAqLwotCW5vZGUtPnBlcm1zLm51bSA9IHBhcmVudC0+ cGVybXMubnVtOwotCW5vZGUtPnBlcm1zLnAgPSB0YWxsb2NfbWVtZHVwKG5v ZGUsIHBhcmVudC0+cGVybXMucCwKLQkJCQkgICAgICBub2RlLT5wZXJtcy5u dW0gKiBzaXplb2YoKm5vZGUtPnBlcm1zLnApKTsKLQlpZiAoIW5vZGUtPnBl cm1zLnApCi0JCWdvdG8gbm9tZW07Ci0JaWYgKGRvbWFpbl9pc191bnByaXZp bGVnZWQoY29ubikpCi0JCW5vZGUtPnBlcm1zLnBbMF0uaWQgPSBjb25uLT5p ZDsKKwkJbGV2ZWxzKys7CisJfQorCisJLyogV2FsayB0aGUgcGF0aCBkb3du IGFnYWluIGNvbnN0cnVjdGluZyB0aGUgbWlzc2luZyBub2Rlcy4gKi8KKwlm b3IgKDsgbGV2ZWxzID4gMDsgbGV2ZWxzLS0pIHsKKwkJLyogQWRkIGNoaWxk IHRvIHBhcmVudC4gKi8KKwkJaWYgKGFkZF9jaGlsZChjdHgsIHBhcmVudCwg bmFtZXNbbGV2ZWxzIC0gMV0pKQorCQkJZ290byBub21lbTsKKworCQkvKiBB bGxvY2F0ZSBub2RlICovCisJCW5vZGUgPSB0YWxsb2MoY3R4LCBzdHJ1Y3Qg bm9kZSk7CisJCWlmICghbm9kZSkKKwkJCWdvdG8gbm9tZW07CisJCW5vZGUt Pm5hbWUgPSB0YWxsb2Nfc3RlYWwobm9kZSwgbmFtZXNbbGV2ZWxzIC0gMV0p OworCisJCS8qIEluaGVyaXQgcGVybWlzc2lvbnMsIHVucHJpdiBkb21haW5z IG93biB3aGF0IHRoZXkgY3JlYXRlLiAqLworCQlub2RlLT5wZXJtcy5udW0g PSBwYXJlbnQtPnBlcm1zLm51bTsKKwkJbm9kZS0+cGVybXMucCA9IHRhbGxv Y19tZW1kdXAobm9kZSwgcGFyZW50LT5wZXJtcy5wLAorCQkJCQkgICAgICBu b2RlLT5wZXJtcy5udW0gKgorCQkJCQkgICAgICBzaXplb2YoKm5vZGUtPnBl cm1zLnApKTsKKwkJaWYgKCFub2RlLT5wZXJtcy5wKQorCQkJZ290byBub21l bTsKKwkJaWYgKGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikpCisJCQlu b2RlLT5wZXJtcy5wWzBdLmlkID0gY29ubi0+aWQ7CisKKwkJLyogTm8gY2hp bGRyZW4sIG5vIGRhdGEgKi8KKwkJbm9kZS0+Y2hpbGRyZW4gPSBub2RlLT5k YXRhID0gTlVMTDsKKwkJbm9kZS0+Y2hpbGRsZW4gPSBub2RlLT5kYXRhbGVu ID0gMDsKKwkJbm9kZS0+YWNjLm1lbW9yeSA9IDA7CisJCW5vZGUtPnBhcmVu dCA9IHBhcmVudDsKKworCQlwYXJlbnQgPSBub2RlOworCX0KIAotCS8qIE5v IGNoaWxkcmVuLCBubyBkYXRhICovCi0Jbm9kZS0+Y2hpbGRyZW4gPSBub2Rl LT5kYXRhID0gTlVMTDsKLQlub2RlLT5jaGlsZGxlbiA9IG5vZGUtPmRhdGFs ZW4gPSAwOwotCW5vZGUtPmFjYy5tZW1vcnkgPSAwOwotCW5vZGUtPnBhcmVu dCA9IHBhcmVudDsKIAlyZXR1cm4gbm9kZTsKIAogbm9tZW06Cg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.15-02.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.15-02.patch" Content-Transfer-Encoding: base64 RnJvbSBkZjQ1ZWEzNzljNjhlNjc1Y2U4OGJiZTI1ZTE3Y2ZlNDllYzEwOGI3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTEgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGRvbid0IGxl dCByZW1vdmVfY2hpbGRfZW50cnkoKSBjYWxsIGNvcnJ1cHQoKQoKSW4gY2Fz ZSBvZiB3cml0ZV9ub2RlKCkgcmV0dXJuaW5nIGFuIGVycm9yLCByZW1vdmVf Y2hpbGRfZW50cnkoKSB3aWxsCmNhbGwgY29ycnVwdCgpIHRvZGF5LiBUaGlz IGNvdWxkIHJlc3VsdCBpbiBhbiBlbmRsZXNzIHJlY3Vyc2lvbiwgYXMKcmVt b3ZlX2NoaWxkX2VudHJ5KCkgaXMgY2FsbGVkIGJ5IGNvcnJ1cHQoKSwgdG9v OgoKY29ycnVwdCgpCiAgY2hlY2tfc3RvcmUoKQogICAgY2hlY2tfc3RvcmVf KCkKICAgICAgcmVtb3ZlX2NoaWxkX2VudHJ5KCkKCkZpeCB0aGF0IGJ5IGxl dHRpbmcgcmVtb3ZlX2NoaWxkX2VudHJ5KCkgcmV0dXJuIGFuIGVycm9yIGlu c3RlYWQgYW5kCmxldCB0aGUgY2FsbGVyIGRlY2lkZSB3aGF0IHRvIGRvLgoK VGhpcyBpcyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJl cG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVr PgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5j b20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24u Y29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4 IDQ2YTM3ZTUyNTdlNS4uNGMzODk3NzIxYmRkIDEwMDY0NAotLS0gYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTE1NzQsMTUgKzE1NzQsMTUgQEAg c3RhdGljIHZvaWQgbWVtZGVsKHZvaWQgKm1lbSwgdW5zaWduZWQgb2ZmLCB1 bnNpZ25lZCBsZW4sIHVuc2lnbmVkIHRvdGFsKQogCW1lbW1vdmUobWVtICsg b2ZmLCBtZW0gKyBvZmYgKyBsZW4sIHRvdGFsIC0gb2ZmIC0gbGVuKTsKIH0K IAotc3RhdGljIHZvaWQgcmVtb3ZlX2NoaWxkX2VudHJ5KHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKLQkJCSAgICAgICBz aXplX3Qgb2Zmc2V0KQorc3RhdGljIGludCByZW1vdmVfY2hpbGRfZW50cnko c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAor CQkJICAgICAgc2l6ZV90IG9mZnNldCkKIHsKIAlzaXplX3QgY2hpbGRsZW4g PSBzdHJsZW4obm9kZS0+Y2hpbGRyZW4gKyBvZmZzZXQpOwogCiAJbWVtZGVs KG5vZGUtPmNoaWxkcmVuLCBvZmZzZXQsIGNoaWxkbGVuICsgMSwgbm9kZS0+ Y2hpbGRsZW4pOwogCW5vZGUtPmNoaWxkbGVuIC09IGNoaWxkbGVuICsgMTsK LQlpZiAod3JpdGVfbm9kZShjb25uLCBub2RlLCB0cnVlKSkKLQkJY29ycnVw dChjb25uLCAiQ2FuJ3QgdXBkYXRlIHBhcmVudCBub2RlICclcyciLCBub2Rl LT5uYW1lKTsKKworCXJldHVybiB3cml0ZV9ub2RlKGNvbm4sIG5vZGUsIHRy dWUpOwogfQogCiBzdGF0aWMgdm9pZCBkZWxldGVfY2hpbGQoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCkBAIC0xNTkyLDcgKzE1OTIsOSBAQCBzdGF0aWMg dm9pZCBkZWxldGVfY2hpbGQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAK IAlmb3IgKGkgPSAwOyBpIDwgbm9kZS0+Y2hpbGRsZW47IGkgKz0gc3RybGVu KG5vZGUtPmNoaWxkcmVuK2kpICsgMSkgewogCQlpZiAoc3RyZXEobm9kZS0+ Y2hpbGRyZW4raSwgY2hpbGRuYW1lKSkgewotCQkJcmVtb3ZlX2NoaWxkX2Vu dHJ5KGNvbm4sIG5vZGUsIGkpOworCQkJaWYgKHJlbW92ZV9jaGlsZF9lbnRy eShjb25uLCBub2RlLCBpKSkKKwkJCQljb3JydXB0KGNvbm4sICJDYW4ndCB1 cGRhdGUgcGFyZW50IG5vZGUgJyVzJyIsCisJCQkJCW5vZGUtPm5hbWUpOwog CQkJcmV0dXJuOwogCQl9CiAJfQpAQCAtMjIyNiw2ICsyMjI4LDE3IEBAIGlu dCByZW1lbWJlcl9zdHJpbmcoc3RydWN0IGhhc2h0YWJsZSAqaGFzaCwgY29u c3QgY2hhciAqc3RyKQogCXJldHVybiBoYXNodGFibGVfaW5zZXJ0KGhhc2gs IGssICh2b2lkICopMSk7CiB9CiAKK3N0YXRpYyBpbnQgcm1fY2hpbGRfZW50 cnkoc3RydWN0IG5vZGUgKm5vZGUsIHNpemVfdCBvZmYsIHNpemVfdCBsZW4p Cit7CisJaWYgKCFyZWNvdmVyeSkKKwkJcmV0dXJuIG9mZjsKKworCWlmIChy ZW1vdmVfY2hpbGRfZW50cnkoTlVMTCwgbm9kZSwgb2ZmKSkKKwkJbG9nKCJj aGVja19zdG9yZTogY2hpbGQgZW50cnkgY291bGQgbm90IGJlIHJlbW92ZWQg ZnJvbSAnJXMnIiwKKwkJICAgIG5vZGUtPm5hbWUpOworCisJcmV0dXJuIG9m ZiAtIGxlbiAtIDE7Cit9CiAKIC8qKgogICogQSBub2RlIGhhcyBhIGNoaWxk cmVuIGZpZWxkIHRoYXQgbmFtZXMgdGhlIGNoaWxkcmVuIG9mIHRoZSBub2Rl LCBzZXBhcmF0ZWQKQEAgLTIyNzgsMTIgKzIyOTEsNyBAQCBzdGF0aWMgaW50 IGNoZWNrX3N0b3JlXyhjb25zdCBjaGFyICpuYW1lLCBzdHJ1Y3QgaGFzaHRh YmxlICpyZWFjaGFibGUpCiAJCQkJaWYgKGhhc2h0YWJsZV9zZWFyY2goY2hp bGRyZW4sIGNoaWxkbmFtZSkpIHsKIAkJCQkJbG9nKCJjaGVja19zdG9yZTog JyVzJyBpcyBkdXBsaWNhdGVkISIsCiAJCQkJCSAgICBjaGlsZG5hbWUpOwot Ci0JCQkJCWlmIChyZWNvdmVyeSkgewotCQkJCQkJcmVtb3ZlX2NoaWxkX2Vu dHJ5KE5VTEwsIG5vZGUsCi0JCQkJCQkJCSAgIGkpOwotCQkJCQkJaSAtPSBj aGlsZGxlbiArIDE7Ci0JCQkJCX0KKwkJCQkJaSA9IHJtX2NoaWxkX2VudHJ5 KG5vZGUsIGksIGNoaWxkbGVuKTsKIAkJCQl9CiAJCQkJZWxzZSB7CiAJCQkJ CWlmICghcmVtZW1iZXJfc3RyaW5nKGNoaWxkcmVuLApAQCAtMjMwMCwxMSAr MjMwOCw3IEBAIHN0YXRpYyBpbnQgY2hlY2tfc3RvcmVfKGNvbnN0IGNoYXIg Km5hbWUsIHN0cnVjdCBoYXNodGFibGUgKnJlYWNoYWJsZSkKIAkJCX0gZWxz ZSBpZiAoZXJybm8gIT0gRU5PTUVNKSB7CiAJCQkJbG9nKCJjaGVja19zdG9y ZTogTm8gY2hpbGQgJyVzJyBmb3VuZCFcbiIsCiAJCQkJICAgIGNoaWxkbmFt ZSk7Ci0KLQkJCQlpZiAocmVjb3ZlcnkpIHsKLQkJCQkJcmVtb3ZlX2NoaWxk X2VudHJ5KE5VTEwsIG5vZGUsIGkpOwotCQkJCQlpIC09IGNoaWxkbGVuICsg MTsKLQkJCQl9CisJCQkJaSA9IHJtX2NoaWxkX2VudHJ5KG5vZGUsIGksIGNo aWxkbGVuKTsKIAkJCX0gZWxzZSB7CiAJCQkJbG9nKCJjaGVja19zdG9yZTog RU5PTUVNIik7CiAJCQkJcmV0ID0gRU5PTUVNOwo= --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.15-03.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.15-03.patch" Content-Transfer-Encoding: base64 RnJvbSA3OGQ4NmQ3NjM0NWRmNDRkNDFmYWQ4NjU5ZjYzN2E5M2NjZDg0OWI3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTEgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBnZW5l cmljIHRyZWV3YWxrIGZ1bmN0aW9uCgpBZGQgYSBnZW5lcmljIGZ1bmN0aW9u IHRvIHdhbGsgdGhlIGNvbXBsZXRlIG5vZGUgdHJlZS4gSXQgd2lsbCBzdGFy dAphdCAiLyIgYW5kIGRlc2NlbmQgcmVjdXJzaXZlbHkgaW50byBlYWNoIGNo aWxkLCBjYWxsaW5nIGEgZnVuY3Rpb24Kc3BlY2lmaWVkIGJ5IHRoZSBjYWxs ZXIuIERlcGVuZGluZyBvbiB0aGUgcmV0dXJuIHZhbHVlIG9mIHRoZSB1c2Vy CnNwZWNpZmllZCBmdW5jdGlvbiB0aGUgd2FsayB3aWxsIGJlIGFib3J0ZWQs IGNvbnRpbnVlZCwgb3IgdGhlIGN1cnJlbnQKY2hpbGQgd2lsbCBiZSBza2lw cGVkIGJ5IG5vdCBkZXNjZW5kaW5nIGludG8gaXRzIGNoaWxkcmVuLgoKVGhp cyBpcyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9y dGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpT aWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ CkFja2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoK ZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IDRjMzg5 NzcyMWJkZC4uNzQ2M2QwYTAwMmQ3IDEwMDY0NAotLS0gYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKQEAgLTE4MDQsNiArMTgwNCwxMzUgQEAgc3RhdGlj IGludCBkb19zZXRfcGVybXMoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwKIAlyZXR1cm4gMDsKIH0KIAorc3RhdGljIGNoYXIg KmNoaWxkX25hbWUoY29uc3Qgdm9pZCAqY3R4LCBjb25zdCBjaGFyICpzMSwg Y29uc3QgY2hhciAqczIpCit7CisJaWYgKHN0cmNtcChzMSwgIi8iKSkKKwkJ cmV0dXJuIHRhbGxvY19hc3ByaW50ZihjdHgsICIlcy8lcyIsIHMxLCBzMik7 CisJcmV0dXJuIHRhbGxvY19hc3ByaW50ZihjdHgsICIvJXMiLCBzMik7Cit9 CisKK3N0YXRpYyBpbnQgcm1fZnJvbV9wYXJlbnQoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIHN0cnVjdCBub2RlICpwYXJlbnQsCisJCQkgIGNvbnN0IGNo YXIgKm5hbWUpCit7CisJc2l6ZV90IG9mZjsKKworCWlmICghcGFyZW50KQor CQlyZXR1cm4gV0FMS19UUkVFX0VSUk9SX1NUT1A7CisKKwlmb3IgKG9mZiA9 IHBhcmVudC0+Y2hpbGRvZmYgLSAxOyBvZmYgJiYgcGFyZW50LT5jaGlsZHJl bltvZmYgLSAxXTsKKwkgICAgIG9mZi0tKTsKKwlpZiAocmVtb3ZlX2NoaWxk X2VudHJ5KGNvbm4sIHBhcmVudCwgb2ZmKSkgeworCQlsb2coInRyZWV3YWxr OiBjaGlsZCBlbnRyeSBjb3VsZCBub3QgYmUgcmVtb3ZlZCBmcm9tICclcyci LAorCQkgICAgcGFyZW50LT5uYW1lKTsKKwkJcmV0dXJuIFdBTEtfVFJFRV9F UlJPUl9TVE9QOworCX0KKwlwYXJlbnQtPmNoaWxkb2ZmID0gb2ZmOworCisJ cmV0dXJuIFdBTEtfVFJFRV9PSzsKK30KKworc3RhdGljIGludCB3YWxrX2Nh bGxfZnVuYyhjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpj b25uLAorCQkJICBzdHJ1Y3Qgbm9kZSAqbm9kZSwgc3RydWN0IG5vZGUgKnBh cmVudCwgdm9pZCAqYXJnLAorCQkJICBpbnQgKCpmdW5jKShjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkJCSAgICAgIHN0 cnVjdCBub2RlICpub2RlLCB2b2lkICphcmcpKQoreworCWludCByZXQ7CisK KwlpZiAoIWZ1bmMpCisJCXJldHVybiBXQUxLX1RSRUVfT0s7CisKKwlyZXQg PSBmdW5jKGN0eCwgY29ubiwgbm9kZSwgYXJnKTsKKwlpZiAocmV0ID09IFdB TEtfVFJFRV9STV9DSElMREVOVFJZICYmIHBhcmVudCkKKwkJcmV0ID0gcm1f ZnJvbV9wYXJlbnQoY29ubiwgcGFyZW50LCBub2RlLT5uYW1lKTsKKworCXJl dHVybiByZXQ7Cit9CisKK2ludCB3YWxrX25vZGVfdHJlZShjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpy b290LAorCQkgICBzdHJ1Y3Qgd2Fsa19mdW5jcyAqZnVuY3MsIHZvaWQgKmFy ZykKK3sKKwlpbnQgcmV0ID0gMDsKKwl2b2lkICp0bXBjdHg7CisJY2hhciAq bmFtZTsKKwlzdHJ1Y3Qgbm9kZSAqbm9kZSA9IE5VTEw7CisJc3RydWN0IG5v ZGUgKnBhcmVudCA9IE5VTEw7CisKKwl0bXBjdHggPSB0YWxsb2NfbmV3KGN0 eCk7CisJaWYgKCF0bXBjdHgpIHsKKwkJZXJybm8gPSBFTk9NRU07CisJCXJl dHVybiBXQUxLX1RSRUVfRVJST1JfU1RPUDsKKwl9CisJbmFtZSA9IHRhbGxv Y19zdHJkdXAodG1wY3R4LCByb290KTsKKwlpZiAoIW5hbWUpIHsKKwkJZXJy bm8gPSBFTk9NRU07CisJCXRhbGxvY19mcmVlKHRtcGN0eCk7CisJCXJldHVy biBXQUxLX1RSRUVfRVJST1JfU1RPUDsKKwl9CisKKwkvKiBDb250aW51ZSB0 aGUgd2FsayB1bnRpbCBhbiBlcnJvciBpcyByZXR1cm5lZC4gKi8KKwl3aGls ZSAocmV0ID49IDApIHsKKwkJLyogbm9kZSA9PSBOVUxMIHBvc3NpYmxlIG9u bHkgZm9yIHRoZSBpbml0aWFsIGxvb3AgaXRlcmF0aW9uLiAqLworCQlpZiAo bm9kZSkgeworCQkJLyogR28gb25lIHN0ZXAgdXAgaWYgcmV0IG9yIGlmIGxh c3QgY2hpbGQgZmluaXNoZWQuICovCisJCQlpZiAocmV0IHx8IG5vZGUtPmNo aWxkb2ZmID49IG5vZGUtPmNoaWxkbGVuKSB7CisJCQkJcGFyZW50ID0gbm9k ZS0+cGFyZW50OworCQkJCS8qIENhbGwgZnVuY3Rpb24gQUZURVIgcHJvY2Vz c2luZyBhIG5vZGUuICovCisJCQkJcmV0ID0gd2Fsa19jYWxsX2Z1bmMoY3R4 LCBjb25uLCBub2RlLCBwYXJlbnQsCisJCQkJCQkgICAgIGFyZywgZnVuY3Mt PmV4aXQpOworCQkJCS8qIExhc3Qgbm9kZSwgc28gZXhpdCBsb29wLiAqLwor CQkJCWlmICghcGFyZW50KQorCQkJCQlicmVhazsKKwkJCQl0YWxsb2NfZnJl ZShub2RlKTsKKwkJCQkvKiBDb250aW51ZSB3aXRoIHBhcmVudC4gKi8KKwkJ CQlub2RlID0gcGFyZW50OworCQkJCWNvbnRpbnVlOworCQkJfQorCQkJLyog R2V0IG5leHQgY2hpbGQgb2YgY3VycmVudCBub2RlLiAqLworCQkJbmFtZSA9 IGNoaWxkX25hbWUodG1wY3R4LCBub2RlLT5uYW1lLAorCQkJCQkgIG5vZGUt PmNoaWxkcmVuICsgbm9kZS0+Y2hpbGRvZmYpOworCQkJaWYgKCFuYW1lKSB7 CisJCQkJcmV0ID0gV0FMS19UUkVFX0VSUk9SX1NUT1A7CisJCQkJYnJlYWs7 CisJCQl9CisJCQkvKiBQb2ludCB0byBuZXh0IGNoaWxkLiAqLworCQkJbm9k ZS0+Y2hpbGRvZmYgKz0gc3RybGVuKG5vZGUtPmNoaWxkcmVuICsKKwkJCQkJ CSBub2RlLT5jaGlsZG9mZikgKyAxOworCQkJLyogRGVzY2VudCBpbnRvIGNo aWxkcmVuLiAqLworCQkJcGFyZW50ID0gbm9kZTsKKwkJfQorCQkvKiBSZWFk IG5leHQgbm9kZSAocm9vdCBub2RlIG9yIG5leHQgY2hpbGQpLiAqLworCQlu b2RlID0gcmVhZF9ub2RlKGNvbm4sIHRtcGN0eCwgbmFtZSk7CisJCWlmICgh bm9kZSkgeworCQkJLyogQ2hpbGQgbm90IGZvdW5kIC0gc2hvdWxkIG5vdCBo YXBwZW4hICovCisJCQkvKiBFTk9FTlQgY2FzZSBjYW4gYmUgaGFuZGxlZCBi eSBzdXBwbGllZCBmdW5jdGlvbi4gKi8KKwkJCWlmIChlcnJubyA9PSBFTk9F TlQgJiYgZnVuY3MtPmVub2VudCkKKwkJCQlyZXQgPSBmdW5jcy0+ZW5vZW50 KGN0eCwgY29ubiwgcGFyZW50LCBuYW1lLAorCQkJCQkJICAgIGFyZyk7CisJ CQllbHNlCisJCQkJcmV0ID0gV0FMS19UUkVFX0VSUk9SX1NUT1A7CisJCQlp ZiAoIXBhcmVudCkKKwkJCQlicmVhazsKKwkJCWlmIChyZXQgPT0gV0FMS19U UkVFX1JNX0NISUxERU5UUlkpCisJCQkJcmV0ID0gcm1fZnJvbV9wYXJlbnQo Y29ubiwgcGFyZW50LCBuYW1lKTsKKwkJCWlmIChyZXQgPCAwKQorCQkJCWJy ZWFrOworCQkJdGFsbG9jX2ZyZWUobmFtZSk7CisJCQlub2RlID0gcGFyZW50 OworCQkJY29udGludWU7CisJCX0KKwkJdGFsbG9jX2ZyZWUobmFtZSk7CisJ CW5vZGUtPnBhcmVudCA9IHBhcmVudDsKKwkJbm9kZS0+Y2hpbGRvZmYgPSAw OworCQkvKiBDYWxsIGZ1bmN0aW9uIEJFRk9SRSBwcm9jZXNzaW5nIGEgbm9k ZS4gKi8KKwkJcmV0ID0gd2Fsa19jYWxsX2Z1bmMoY3R4LCBjb25uLCBub2Rl LCBwYXJlbnQsIGFyZywKKwkJCQkgICAgIGZ1bmNzLT5lbnRlcik7CisJfQor CisJdGFsbG9jX2ZyZWUodG1wY3R4KTsKKworCXJldHVybiByZXQgPCAwID8g cmV0IDogV0FMS19UUkVFX09LOworfQorCiBzdGF0aWMgc3RydWN0IHsKIAlj b25zdCBjaGFyICpzdHI7CiAJaW50ICgqZnVuYykoY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKQEAgLTIyMDYsMTggKzIzMzUs NiBAQCBzdGF0aWMgaW50IGtleXNfZXF1YWxfZm4odm9pZCAqa2V5MSwgdm9p ZCAqa2V5MikKIAlyZXR1cm4gMCA9PSBzdHJjbXAoKGNoYXIgKilrZXkxLCAo Y2hhciAqKWtleTIpOwogfQogCi0KLXN0YXRpYyBjaGFyICpjaGlsZF9uYW1l KGNvbnN0IGNoYXIgKnMxLCBjb25zdCBjaGFyICpzMikKLXsKLQlpZiAoc3Ry Y21wKHMxLCAiLyIpKSB7Ci0JCXJldHVybiB0YWxsb2NfYXNwcmludGYoTlVM TCwgIiVzLyVzIiwgczEsIHMyKTsKLQl9Ci0JZWxzZSB7Ci0JCXJldHVybiB0 YWxsb2NfYXNwcmludGYoTlVMTCwgIi8lcyIsIHMyKTsKLQl9Ci19Ci0KLQog aW50IHJlbWVtYmVyX3N0cmluZyhzdHJ1Y3QgaGFzaHRhYmxlICpoYXNoLCBj b25zdCBjaGFyICpzdHIpCiB7CiAJY2hhciAqayA9IG1hbGxvYyhzdHJsZW4o c3RyKSArIDEpOwpAQCAtMjI3Nyw3ICsyMzk0LDcgQEAgc3RhdGljIGludCBj aGVja19zdG9yZV8oY29uc3QgY2hhciAqbmFtZSwgc3RydWN0IGhhc2h0YWJs ZSAqcmVhY2hhYmxlKQogCQl3aGlsZSAoaSA8IG5vZGUtPmNoaWxkbGVuICYm ICFyZXQpIHsKIAkJCXN0cnVjdCBub2RlICpjaGlsZG5vZGU7CiAJCQlzaXpl X3QgY2hpbGRsZW4gPSBzdHJsZW4obm9kZS0+Y2hpbGRyZW4gKyBpKTsKLQkJ CWNoYXIgKiBjaGlsZG5hbWUgPSBjaGlsZF9uYW1lKG5vZGUtPm5hbWUsCisJ CQljaGFyICogY2hpbGRuYW1lID0gY2hpbGRfbmFtZShOVUxMLCBub2RlLT5u YW1lLAogCQkJCQkJICAgICAgbm9kZS0+Y2hpbGRyZW4gKyBpKTsKIAogCQkJ aWYgKCFjaGlsZG5hbWUpIHsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5oCmluZGV4IDFlYjM3MDhmODJkZC4uZjBmZDhjMzUyODU3IDEwMDY0 NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCisrKyBi L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKQEAgLTE5NSw2ICsx OTUsNyBAQCBzdHJ1Y3Qgbm9kZSB7CiAKIAkvKiBDaGlsZHJlbiwgZWFjaCBu dWwtdGVybWluYXRlZC4gKi8KIAl1bnNpZ25lZCBpbnQgY2hpbGRsZW47CisJ dW5zaWduZWQgaW50IGNoaWxkb2ZmOwkvKiBVc2VkIGJ5IHdhbGtfbm9kZV90 cmVlKCkgaW50ZXJuYWxseS4gKi8KIAljaGFyICpjaGlsZHJlbjsKIAogCS8q IEFsbG9jYXRpb24gaW5mb3JtYXRpb24gZm9yIG5vZGUgY3VycmVudGx5IGlu IHN0b3JlLiAqLwpAQCAtMzM0LDYgKzMzNSw0NSBAQCB2b2lkIHJlYWRfc3Rh dGVfYnVmZmVyZWRfZGF0YShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLAogCQkJICAgICAgY29uc3Qgc3RydWN0IHhzX3N0YXRl X2Nvbm5lY3Rpb24gKnNjKTsKIHZvaWQgcmVhZF9zdGF0ZV9ub2RlKGNvbnN0 IHZvaWQgKmN0eCwgY29uc3Qgdm9pZCAqc3RhdGUpOwogCisvKgorICogV2Fs ayB0aGUgbm9kZSB0cmVlIGJlbG93IHJvb3QgY2FsbGluZyBmdW5jcy0+ZW50 ZXIoKSBhbmQgZnVuY3MtPmV4aXQoKSBmb3IKKyAqIGVhY2ggbm9kZS4gZnVu Y3MtPmVudGVyKCkgaXMgYmVpbmcgY2FsbGVkIHdoZW4gZW50ZXJpbmcgYSBu b2RlLCBzbyBiZWZvcmUKKyAqIGFueSBvZiB0aGUgY2hpbGRyZW4gb2YgdGhl IG5vZGUgaXMgcHJvY2Vzc2VkLiBmdW5jcy0+ZXhpdCgpIGlzIGJlaW5nCisg KiBjYWxsZWQgd2hlbiBsZWF2aW5nIHRoZSBub2RlLCBzbyBhZnRlciBhbGwg Y2hpbGRyZW4gaGF2ZSBiZWVuIHByb2Nlc3NlZC4KKyAqIGZ1bmNzLT5lbm9l bnQoKSBpcyBiZWluZyBjYWxsZWQgd2hlbiBhIG5vZGUgaXNuJ3QgZXhpc3Rp bmcuCisgKiBmdW5jcy0+KigpIHJldHVybiB2YWx1ZXM6CisgKiAgPCAwOiB0 cmVlIHdhbGsgaXMgc3RvcHBlZCwgd2Fsa19ub2RlX3RyZWUoKSByZXR1cm5z IGZ1bmNzLT4qKCkgcmV0dXJuIHZhbHVlCisgKiAgICAgICBpbiBjYXNlIFdB TEtfVFJFRV9FUlJPUl9TVE9QIGlzIHJldHVybmVkLCBlcnJubyBzaG91bGQg YmUgc2V0CisgKiAgV0FMS19UUkVFX09LOiB0cmVlIHdhbGsgaXMgY29udGlu dWluZworICogIFdBTEtfVFJFRV9TS0lQX0NISUxEUkVOOiB0cmVlIHdhbGsg d29uJ3QgZGVzY2VuZCBiZWxvdyBjdXJyZW50IG5vZGUsIGJ1dAorICogICAg ICAgd2FsayBjb250aW51ZXMKKyAqICBXQUxLX1RSRUVfUk1fQ0hJTERFTlRS WTogUmVtb3ZlIHRoZSBjaGlsZCBlbnRyeSBmcm9tIGl0cyBwYXJlbnQgYW5k IHdyaXRlCisgKiAgICAgICB0aGUgbW9kaWZpZWQgcGFyZW50IG5vZGUgYmFj ayB0byB0aGUgZGF0YSBiYXNlLCBpbXBsaWVzIHRvIG5vdCBkZXNjZW5kCisg KiAgICAgICBiZWxvdyB0aGUgY3VycmVudCBub2RlLCBidXQgdG8gY29udGlu dWUgdGhlIHdhbGsKKyAqIGZ1bmNzLT4qKCkgaXMgYWxsb3dlZCB0byBtb2Rp ZnkgdGhlIG5vZGUgaXQgaXMgY2FsbGVkIGZvciBpbiB0aGUgZGF0YSBiYXNl LgorICogSW4gY2FzZSBmdW5jcy0+ZW50ZXIoKSBpcyBkZWxldGluZyB0aGUg bm9kZSwgaXQgbXVzdCBub3QgcmV0dXJuIFdBTEtfVFJFRV9PSworICogaW4g b3JkZXIgdG8gYXZvaWQgZGVzY2VuZGluZyBpbnRvIG5vIGxvbmdlciBleGlz dGluZyBjaGlsZHJlbi4KKyAqLworLyogUmV0dXJuIHZhbHVlcyBmb3IgZnVu Y3MtPiooKSBhbmQgd2Fsa19ub2RlX3RyZWUoKS4gKi8KKyNkZWZpbmUgV0FM S19UUkVFX1NVQ0NFU1NfU1RPUCAgLTEwMCAgICAvKiBTdG9wIHdhbGsgZWFy bHksIG5vIGVycm9yLiAqLworI2RlZmluZSBXQUxLX1RSRUVfRVJST1JfU1RP UCAgICAtMSAgICAgIC8qIFN0b3Agd2FsayBkdWUgdG8gZXJyb3IuICovCisj ZGVmaW5lIFdBTEtfVFJFRV9PSyAgICAgICAgICAgIDAgICAgICAgLyogTm8g ZXJyb3IuICovCisvKiBSZXR1cm4gdmFsdWUgZm9yIGZ1bmNzLT4qKCkgb25s eS4gKi8KKyNkZWZpbmUgV0FMS19UUkVFX1NLSVBfQ0hJTERSRU4gMSAgICAg ICAvKiBEb24ndCByZWN1cnNlIGJlbG93IGN1cnJlbnQgbm9kZS4gKi8KKyNk ZWZpbmUgV0FMS19UUkVFX1JNX0NISUxERU5UUlkgMiAgICAgICAvKiBSZW1v dmUgY2hpbGQgZW50cnkgZnJvbSBwYXJlbnQuICovCisKK3N0cnVjdCB3YWxr X2Z1bmNzIHsKKwlpbnQgKCplbnRlcikoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICAgICBzdHJ1Y3Qgbm9kZSAqbm9k ZSwgdm9pZCAqYXJnKTsKKwlpbnQgKCpleGl0KShjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgICAgc3RydWN0IG5vZGUg Km5vZGUsIHZvaWQgKmFyZyk7CisJaW50ICgqZW5vZW50KShjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgICAgICBzdHJ1 Y3Qgbm9kZSAqcGFyZW50LCBjaGFyICpuYW1lLCB2b2lkICphcmcpOworfTsK KworaW50IHdhbGtfbm9kZV90cmVlKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IGNoYXIgKnJvb3QsCisJCSAgIHN0 cnVjdCB3YWxrX2Z1bmNzICpmdW5jcywgdm9pZCAqYXJnKTsKKwogI2VuZGlm IC8qIF9YRU5TVE9SRURfQ09SRV9IICovCiAKIC8qCg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.15-04.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.15-04.patch" Content-Transfer-Encoding: base64 RnJvbSAxZTcyYWEzYzUwN2M5ZTliYjQ5NWQxMjkwNzE4OTAzNGJjOGIxZTdh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHNpbXBsaWZ5 IGNoZWNrX3N0b3JlKCkKCmNoZWNrX3N0b3JlKCkgaXMgdXNpbmcgYSBoYXNo IHRhYmxlIGZvciBzdG9yaW5nIGFsbCBub2RlIG5hbWVzIGl0IGhhcwpmb3Vu ZCB2aWEgd2Fsa2luZyB0aGUgdHJlZS4gQWRkaXRpb25hbGx5IGl0IHVzaW5n IGFub3RoZXIgaGFzaCB0YWJsZQpmb3IgYWxsIGNoaWxkcmVuIG9mIGEgbm9k ZSB0byBkZXRlY3QgZHVwbGljYXRlIGNoaWxkIG5hbWVzLgoKU2ltcGxpZnkg dGhhdCBieSBkcm9wcGluZyB0aGUgc2Vjb25kIGhhc2ggdGFibGUgYXMgdGhl IGZpcnN0IG9uZSBpcwphbHJlYWR5IGhvbGRpbmcgYWxsIHRoZSBuZWVkZWQg aW5mb3JtYXRpb24uCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQxOCAvIENWRS0y MDIyLTQyMzIxLgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8ZHZyYWJl bEBhbWF6b24uY28udWs+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3Mg PGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmMKaW5kZXggNzQ2M2QwYTAwMmQ3Li5hNDgyNTVjNjRjYWQgMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtMjM3OCw1 MCArMjM3OCwzNCBAQCBzdGF0aWMgaW50IGNoZWNrX3N0b3JlXyhjb25zdCBj aGFyICpuYW1lLCBzdHJ1Y3QgaGFzaHRhYmxlICpyZWFjaGFibGUpCiAJaWYg KG5vZGUpIHsKIAkJc2l6ZV90IGkgPSAwOwogCi0JCXN0cnVjdCBoYXNodGFi bGUgKiBjaGlsZHJlbiA9Ci0JCQljcmVhdGVfaGFzaHRhYmxlKDE2LCBoYXNo X2Zyb21fa2V5X2ZuLCBrZXlzX2VxdWFsX2ZuKTsKLQkJaWYgKCFjaGlsZHJl bikgewotCQkJbG9nKCJjaGVja19zdG9yZSBjcmVhdGUgdGFibGU6IEVOT01F TSIpOwotCQkJcmV0dXJuIEVOT01FTTsKLQkJfQotCiAJCWlmICghcmVtZW1i ZXJfc3RyaW5nKHJlYWNoYWJsZSwgbmFtZSkpIHsKLQkJCWhhc2h0YWJsZV9k ZXN0cm95KGNoaWxkcmVuLCAwKTsKIAkJCWxvZygiY2hlY2tfc3RvcmU6IEVO T01FTSIpOwogCQkJcmV0dXJuIEVOT01FTTsKIAkJfQogCiAJCXdoaWxlIChp IDwgbm9kZS0+Y2hpbGRsZW4gJiYgIXJldCkgewotCQkJc3RydWN0IG5vZGUg KmNoaWxkbm9kZTsKKwkJCXN0cnVjdCBub2RlICpjaGlsZG5vZGUgPSBOVUxM OwogCQkJc2l6ZV90IGNoaWxkbGVuID0gc3RybGVuKG5vZGUtPmNoaWxkcmVu ICsgaSk7Ci0JCQljaGFyICogY2hpbGRuYW1lID0gY2hpbGRfbmFtZShOVUxM LCBub2RlLT5uYW1lLAotCQkJCQkJICAgICAgbm9kZS0+Y2hpbGRyZW4gKyBp KTsKKwkJCWNoYXIgKmNoaWxkbmFtZSA9IGNoaWxkX25hbWUoTlVMTCwgbm9k ZS0+bmFtZSwKKwkJCQkJCSAgICAgbm9kZS0+Y2hpbGRyZW4gKyBpKTsKIAog CQkJaWYgKCFjaGlsZG5hbWUpIHsKIAkJCQlsb2coImNoZWNrX3N0b3JlOiBF Tk9NRU0iKTsKIAkJCQlyZXQgPSBFTk9NRU07CiAJCQkJYnJlYWs7CiAJCQl9 CisKKwkJCWlmIChoYXNodGFibGVfc2VhcmNoKHJlYWNoYWJsZSwgY2hpbGRu YW1lKSkgeworCQkJCWxvZygiY2hlY2tfc3RvcmU6ICclcycgaXMgZHVwbGlj YXRlZCEiLAorCQkJCSAgICBjaGlsZG5hbWUpOworCQkJCWkgPSBybV9jaGls ZF9lbnRyeShub2RlLCBpLCBjaGlsZGxlbik7CisJCQkJZ290byBuZXh0Owor CQkJfQorCiAJCQljaGlsZG5vZGUgPSByZWFkX25vZGUoTlVMTCwgY2hpbGRu YW1lLCBjaGlsZG5hbWUpOwotCQkJCisKIAkJCWlmIChjaGlsZG5vZGUpIHsK LQkJCQlpZiAoaGFzaHRhYmxlX3NlYXJjaChjaGlsZHJlbiwgY2hpbGRuYW1l KSkgewotCQkJCQlsb2coImNoZWNrX3N0b3JlOiAnJXMnIGlzIGR1cGxpY2F0 ZWQhIiwKLQkJCQkJICAgIGNoaWxkbmFtZSk7Ci0JCQkJCWkgPSBybV9jaGls ZF9lbnRyeShub2RlLCBpLCBjaGlsZGxlbik7Ci0JCQkJfQotCQkJCWVsc2Ug ewotCQkJCQlpZiAoIXJlbWVtYmVyX3N0cmluZyhjaGlsZHJlbiwKLQkJCQkJ CQkgICAgIGNoaWxkbmFtZSkpIHsKLQkJCQkJCWxvZygiY2hlY2tfc3RvcmU6 IEVOT01FTSIpOwotCQkJCQkJdGFsbG9jX2ZyZWUoY2hpbGRub2RlKTsKLQkJ CQkJCXRhbGxvY19mcmVlKGNoaWxkbmFtZSk7Ci0JCQkJCQlyZXQgPSBFTk9N RU07Ci0JCQkJCQlicmVhazsKLQkJCQkJfQotCQkJCQlyZXQgPSBjaGVja19z dG9yZV8oY2hpbGRuYW1lLAotCQkJCQkJCSAgIHJlYWNoYWJsZSk7Ci0JCQkJ fQorCQkJCXJldCA9IGNoZWNrX3N0b3JlXyhjaGlsZG5hbWUsIHJlYWNoYWJs ZSk7CiAJCQl9IGVsc2UgaWYgKGVycm5vICE9IEVOT01FTSkgewogCQkJCWxv ZygiY2hlY2tfc3RvcmU6IE5vIGNoaWxkICclcycgZm91bmQhXG4iLAogCQkJ CSAgICBjaGlsZG5hbWUpOwpAQCAtMjQzMSwxOSArMjQxNSwxOCBAQCBzdGF0 aWMgaW50IGNoZWNrX3N0b3JlXyhjb25zdCBjaGFyICpuYW1lLCBzdHJ1Y3Qg aGFzaHRhYmxlICpyZWFjaGFibGUpCiAJCQkJcmV0ID0gRU5PTUVNOwogCQkJ fQogCisgbmV4dDoKIAkJCXRhbGxvY19mcmVlKGNoaWxkbm9kZSk7CiAJCQl0 YWxsb2NfZnJlZShjaGlsZG5hbWUpOwogCQkJaSArPSBjaGlsZGxlbiArIDE7 CiAJCX0KIAotCQloYXNodGFibGVfZGVzdHJveShjaGlsZHJlbiwgMCAvKiBE b24ndCBmcmVlIHZhbHVlcyAodGhleSBhcmUKLQkJCQkJCSBhbGwgKHZvaWQg KikxKSAqLyk7CiAJCXRhbGxvY19mcmVlKG5vZGUpOwogCX0gZWxzZSBpZiAo ZXJybm8gIT0gRU5PTUVNKSB7CiAJCS8qIEltcG9zc2libGUsIGJlY2F1c2Ug bm8gZGF0YWJhc2Ugc2hvdWxkIGV2ZXIgYmUgd2l0aG91dCB0aGUKIAkJICAg cm9vdCwgYW5kIG90aGVyd2lzZSwgd2UndmUganVzdCBjaGVja2VkIGluIG91 ciBjYWxsZXIKIAkJICAgKHdoaWNoIG1hZGUgYSByZWN1cnNpdmUgY2FsbCB0 byBnZXQgaGVyZSkuICovCi0JCSAgIAorCiAJCWxvZygiY2hlY2tfc3RvcmU6 IE5vIGNoaWxkICclcycgZm91bmQ6IGltcG9zc2libGUhIiwgbmFtZSk7CiAJ fSBlbHNlIHsKIAkJbG9nKCJjaGVja19zdG9yZTogRU5PTUVNIik7Cg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.15-05.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.15-05.patch" Content-Transfer-Encoding: base64 RnJvbSAzNThjMzkyMzU5YTI5ZDI4NzUxOTA3MzAzZGMxODEwNzNhNDJhYjMz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHVzZSB0cmVl d2FsayBmb3IgY2hlY2tfc3RvcmUoKQoKSW5zdGVhZCBvZiBkb2luZyBhbiBv cGVuIHRyZWUgd2FsayB1c2luZyBjYWxsIHJlY3Vyc2lvbiwgdXNlCndhbGtf bm9kZV90cmVlKCkgd2hlbiBjaGVja2luZyB0aGUgc3RvcmUgZm9yIGluY29u c2lzdGVuY2llcy4KClRoaXMgd2lsbCByZWR1Y2UgY29kZSBzaXplIGFuZCBh dm9pZCBtYW55IG5lc3RpbmcgbGV2ZWxzIG9mIGZ1bmN0aW9uCmNhbGxzIHdo aWNoIGNvdWxkIHBvdGVudGlhbGx5IGV4aGF1c3QgdGhlIHN0YWNrLgoKVGhp cyBpcyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9y dGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpT aWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ ClJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29t PgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IGE0 ODI1NWM2NGNhZC4uZWQ4YmM5YjAyZWQyIDEwMDY0NAotLS0gYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMKQEAgLTIzNDUsMTggKzIzNDUsNiBAQCBpbnQg cmVtZW1iZXJfc3RyaW5nKHN0cnVjdCBoYXNodGFibGUgKmhhc2gsIGNvbnN0 IGNoYXIgKnN0cikKIAlyZXR1cm4gaGFzaHRhYmxlX2luc2VydChoYXNoLCBr LCAodm9pZCAqKTEpOwogfQogCi1zdGF0aWMgaW50IHJtX2NoaWxkX2VudHJ5 KHN0cnVjdCBub2RlICpub2RlLCBzaXplX3Qgb2ZmLCBzaXplX3QgbGVuKQot ewotCWlmICghcmVjb3ZlcnkpCi0JCXJldHVybiBvZmY7Ci0KLQlpZiAocmVt b3ZlX2NoaWxkX2VudHJ5KE5VTEwsIG5vZGUsIG9mZikpCi0JCWxvZygiY2hl Y2tfc3RvcmU6IGNoaWxkIGVudHJ5IGNvdWxkIG5vdCBiZSByZW1vdmVkIGZy b20gJyVzJyIsCi0JCSAgICBub2RlLT5uYW1lKTsKLQotCXJldHVybiBvZmYg LSBsZW4gLSAxOwotfQotCiAvKioKICAqIEEgbm9kZSBoYXMgYSBjaGlsZHJl biBmaWVsZCB0aGF0IG5hbWVzIHRoZSBjaGlsZHJlbiBvZiB0aGUgbm9kZSwg c2VwYXJhdGVkCiAgKiBieSBOVUxzLiAgV2UgY2hlY2sgd2hldGhlciB0aGVy ZSBhcmUgZW50cmllcyBpbiB0aGVyZSB0aGF0IGFyZSBkdXBsaWNhdGVkCkBA IC0yMzcwLDcwICsyMzU4LDI5IEBAIHN0YXRpYyBpbnQgcm1fY2hpbGRfZW50 cnkoc3RydWN0IG5vZGUgKm5vZGUsIHNpemVfdCBvZmYsIHNpemVfdCBsZW4p CiAgKiBBcyB3ZSBnbywgd2UgcmVjb3JkIGVhY2ggbm9kZSBpbiB0aGUgZ2l2 ZW4gcmVhY2hhYmxlIGhhc2h0YWJsZS4gIFRoZXNlCiAgKiBlbnRyaWVzIHdp bGwgYmUgdXNlZCBsYXRlciBpbiBjbGVhbl9zdG9yZS4KICAqLwotc3RhdGlj IGludCBjaGVja19zdG9yZV8oY29uc3QgY2hhciAqbmFtZSwgc3RydWN0IGhh c2h0YWJsZSAqcmVhY2hhYmxlKQorc3RhdGljIGludCBjaGVja19zdG9yZV9z dGVwKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s CisJCQkgICAgc3RydWN0IG5vZGUgKm5vZGUsIHZvaWQgKmFyZykKIHsKLQlz dHJ1Y3Qgbm9kZSAqbm9kZSA9IHJlYWRfbm9kZShOVUxMLCBuYW1lLCBuYW1l KTsKLQlpbnQgcmV0ID0gMDsKLQotCWlmIChub2RlKSB7Ci0JCXNpemVfdCBp ID0gMDsKLQotCQlpZiAoIXJlbWVtYmVyX3N0cmluZyhyZWFjaGFibGUsIG5h bWUpKSB7Ci0JCQlsb2coImNoZWNrX3N0b3JlOiBFTk9NRU0iKTsKLQkJCXJl dHVybiBFTk9NRU07Ci0JCX0KLQotCQl3aGlsZSAoaSA8IG5vZGUtPmNoaWxk bGVuICYmICFyZXQpIHsKLQkJCXN0cnVjdCBub2RlICpjaGlsZG5vZGUgPSBO VUxMOwotCQkJc2l6ZV90IGNoaWxkbGVuID0gc3RybGVuKG5vZGUtPmNoaWxk cmVuICsgaSk7Ci0JCQljaGFyICpjaGlsZG5hbWUgPSBjaGlsZF9uYW1lKE5V TEwsIG5vZGUtPm5hbWUsCi0JCQkJCQkgICAgIG5vZGUtPmNoaWxkcmVuICsg aSk7Ci0KLQkJCWlmICghY2hpbGRuYW1lKSB7Ci0JCQkJbG9nKCJjaGVja19z dG9yZTogRU5PTUVNIik7Ci0JCQkJcmV0ID0gRU5PTUVNOwotCQkJCWJyZWFr OwotCQkJfQotCi0JCQlpZiAoaGFzaHRhYmxlX3NlYXJjaChyZWFjaGFibGUs IGNoaWxkbmFtZSkpIHsKLQkJCQlsb2coImNoZWNrX3N0b3JlOiAnJXMnIGlz IGR1cGxpY2F0ZWQhIiwKLQkJCQkgICAgY2hpbGRuYW1lKTsKLQkJCQlpID0g cm1fY2hpbGRfZW50cnkobm9kZSwgaSwgY2hpbGRsZW4pOwotCQkJCWdvdG8g bmV4dDsKLQkJCX0KLQotCQkJY2hpbGRub2RlID0gcmVhZF9ub2RlKE5VTEws IGNoaWxkbmFtZSwgY2hpbGRuYW1lKTsKKwlzdHJ1Y3QgaGFzaHRhYmxlICpy ZWFjaGFibGUgPSBhcmc7CiAKLQkJCWlmIChjaGlsZG5vZGUpIHsKLQkJCQly ZXQgPSBjaGVja19zdG9yZV8oY2hpbGRuYW1lLCByZWFjaGFibGUpOwotCQkJ fSBlbHNlIGlmIChlcnJubyAhPSBFTk9NRU0pIHsKLQkJCQlsb2coImNoZWNr X3N0b3JlOiBObyBjaGlsZCAnJXMnIGZvdW5kIVxuIiwKLQkJCQkgICAgY2hp bGRuYW1lKTsKLQkJCQlpID0gcm1fY2hpbGRfZW50cnkobm9kZSwgaSwgY2hp bGRsZW4pOwotCQkJfSBlbHNlIHsKLQkJCQlsb2coImNoZWNrX3N0b3JlOiBF Tk9NRU0iKTsKLQkJCQlyZXQgPSBFTk9NRU07Ci0JCQl9CisJaWYgKGhhc2h0 YWJsZV9zZWFyY2gocmVhY2hhYmxlLCAodm9pZCAqKW5vZGUtPm5hbWUpKSB7 CisJCWxvZygiY2hlY2tfc3RvcmU6ICclcycgaXMgZHVwbGljYXRlZCEiLCBu b2RlLT5uYW1lKTsKKwkJcmV0dXJuIHJlY292ZXJ5ID8gV0FMS19UUkVFX1JN X0NISUxERU5UUlkKKwkJCQk6IFdBTEtfVFJFRV9TS0lQX0NISUxEUkVOOwor CX0KIAotIG5leHQ6Ci0JCQl0YWxsb2NfZnJlZShjaGlsZG5vZGUpOwotCQkJ dGFsbG9jX2ZyZWUoY2hpbGRuYW1lKTsKLQkJCWkgKz0gY2hpbGRsZW4gKyAx OwotCQl9CisJaWYgKCFyZW1lbWJlcl9zdHJpbmcocmVhY2hhYmxlLCBub2Rl LT5uYW1lKSkKKwkJcmV0dXJuIFdBTEtfVFJFRV9FUlJPUl9TVE9QOwogCi0J CXRhbGxvY19mcmVlKG5vZGUpOwotCX0gZWxzZSBpZiAoZXJybm8gIT0gRU5P TUVNKSB7Ci0JCS8qIEltcG9zc2libGUsIGJlY2F1c2Ugbm8gZGF0YWJhc2Ug c2hvdWxkIGV2ZXIgYmUgd2l0aG91dCB0aGUKLQkJICAgcm9vdCwgYW5kIG90 aGVyd2lzZSwgd2UndmUganVzdCBjaGVja2VkIGluIG91ciBjYWxsZXIKLQkJ ICAgKHdoaWNoIG1hZGUgYSByZWN1cnNpdmUgY2FsbCB0byBnZXQgaGVyZSku ICovCisJcmV0dXJuIFdBTEtfVFJFRV9PSzsKK30KIAotCQlsb2coImNoZWNr X3N0b3JlOiBObyBjaGlsZCAnJXMnIGZvdW5kOiBpbXBvc3NpYmxlISIsIG5h bWUpOwotCX0gZWxzZSB7Ci0JCWxvZygiY2hlY2tfc3RvcmU6IEVOT01FTSIp OwotCQlyZXQgPSBFTk9NRU07Ci0JfQorc3RhdGljIGludCBjaGVja19zdG9y ZV9lbm9lbnQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwKKwkJCSAgICAgIHN0cnVjdCBub2RlICpwYXJlbnQsIGNoYXIgKm5h bWUsIHZvaWQgKmFyZykKK3sKKwlsb2coImNoZWNrX3N0b3JlOiBub2RlICcl cycgbm90IGZvdW5kIiwgbmFtZSk7CiAKLQlyZXR1cm4gcmV0OworCXJldHVy biByZWNvdmVyeSA/IFdBTEtfVFJFRV9STV9DSElMREVOVFJZIDogV0FMS19U UkVFX09LOwogfQogCiAKQEAgLTI0ODIsMjQgKzI0MjksMjggQEAgc3RhdGlj IHZvaWQgY2xlYW5fc3RvcmUoc3RydWN0IGhhc2h0YWJsZSAqcmVhY2hhYmxl KQogCiB2b2lkIGNoZWNrX3N0b3JlKHZvaWQpCiB7Ci0JY2hhciAqIHJvb3Qg PSB0YWxsb2Nfc3RyZHVwKE5VTEwsICIvIik7Ci0Jc3RydWN0IGhhc2h0YWJs ZSAqIHJlYWNoYWJsZSA9Ci0JCWNyZWF0ZV9oYXNodGFibGUoMTYsIGhhc2hf ZnJvbV9rZXlfZm4sIGtleXNfZXF1YWxfZm4pOwotIAorCXN0cnVjdCBoYXNo dGFibGUgKnJlYWNoYWJsZTsKKwlzdHJ1Y3Qgd2Fsa19mdW5jcyB3YWxrZnVu Y3MgPSB7CisJCS5lbnRlciA9IGNoZWNrX3N0b3JlX3N0ZXAsCisJCS5lbm9l bnQgPSBjaGVja19zdG9yZV9lbm9lbnQsCisJfTsKKworCXJlYWNoYWJsZSA9 IGNyZWF0ZV9oYXNodGFibGUoMTYsIGhhc2hfZnJvbV9rZXlfZm4sIGtleXNf ZXF1YWxfZm4pOwogCWlmICghcmVhY2hhYmxlKSB7CiAJCWxvZygiY2hlY2tf c3RvcmU6IEVOT01FTSIpOwogCQlyZXR1cm47CiAJfQogCiAJbG9nKCJDaGVj a2luZyBzdG9yZSAuLi4iKTsKLQlpZiAoIWNoZWNrX3N0b3JlXyhyb290LCBy ZWFjaGFibGUpICYmCi0JICAgICFjaGVja190cmFuc2FjdGlvbnMocmVhY2hh YmxlKSkKKwlpZiAod2Fsa19ub2RlX3RyZWUoTlVMTCwgTlVMTCwgIi8iLCAm d2Fsa2Z1bmNzLCByZWFjaGFibGUpKSB7CisJCWlmIChlcnJubyA9PSBFTk9N RU0pCisJCQlsb2coImNoZWNrX3N0b3JlOiBFTk9NRU0iKTsKKwl9IGVsc2Ug aWYgKCFjaGVja190cmFuc2FjdGlvbnMocmVhY2hhYmxlKSkKIAkJY2xlYW5f c3RvcmUocmVhY2hhYmxlKTsKIAlsb2coIkNoZWNraW5nIHN0b3JlIGNvbXBs ZXRlLiIpOwogCiAJaGFzaHRhYmxlX2Rlc3Ryb3kocmVhY2hhYmxlLCAwIC8q IERvbid0IGZyZWUgdmFsdWVzICh0aGV5IGFyZSBhbGwKIAkJCQkJICAodm9p ZCAqKTEpICovKTsKLQl0YWxsb2NfZnJlZShyb290KTsKIH0KIAogCg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.15-06.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.15-06.patch" Content-Transfer-Encoding: base64 RnJvbSBjNDc4MjhjNzI4NjQ3OGE5ZGMwNDAxMGFlNDE5MWM0YzAyM2YyZmE4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHVzZSB0cmVl d2FsayBmb3IgZGVsZXRpbmcgbm9kZXMKCkluc3RlYWQgb2YgZG9pbmcgYW4g b3BlbiB0cmVlIHdhbGsgdXNpbmcgY2FsbCByZWN1cnNpb24sIHVzZQp3YWxr X25vZGVfdHJlZSgpIHdoZW4gZGVsZXRpbmcgYSBzdWItdHJlZSBvZiBub2Rl cy4KClRoaXMgd2lsbCByZWR1Y2UgY29kZSBzaXplIGFuZCBhdm9pZCBtYW55 IG5lc3RpbmcgbGV2ZWxzIG9mIGZ1bmN0aW9uCmNhbGxzIHdoaWNoIGNvdWxk IHBvdGVudGlhbGx5IGV4aGF1c3QgdGhlIHN0YWNrLgoKVGhpcyBpcyBwYXJ0 IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9ydGVkLWJ5OiBK dWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpTaWduZWQtb2Zm LWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+CkFja2VkLWJ5 OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdp dCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IGVkOGJjOWIwMmVkMi4u OTU3NjQxMTc1N2ZhIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMKQEAgLTEzMDAsMjEgKzEzMDAsNiBAQCBzdGF0aWMgaW50IGRvX3Jl YWQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwK IAlyZXR1cm4gMDsKIH0KIAotc3RhdGljIHZvaWQgZGVsZXRlX25vZGVfc2lu Z2xlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9k ZSkKLXsKLQlUREJfREFUQSBrZXk7Ci0KLQlpZiAoYWNjZXNzX25vZGUoY29u biwgbm9kZSwgTk9ERV9BQ0NFU1NfREVMRVRFLCAma2V5KSkKLQkJcmV0dXJu OwotCi0JaWYgKGRvX3RkYl9kZWxldGUoY29ubiwgJmtleSwgJm5vZGUtPmFj YykgIT0gMCkgewotCQljb3JydXB0KGNvbm4sICJDb3VsZCBub3QgZGVsZXRl ICclcyciLCBub2RlLT5uYW1lKTsKLQkJcmV0dXJuOwotCX0KLQotCWRvbWFp bl9lbnRyeV9kZWMoY29ubiwgbm9kZSk7Ci19Ci0KIC8qIE11c3Qgbm90IGJl IC8gKi8KIHN0YXRpYyBjaGFyICpiYXNlbmFtZShjb25zdCBjaGFyICpuYW1l KQogewpAQCAtMTU4NSw2OSArMTU3MCw1OSBAQCBzdGF0aWMgaW50IHJlbW92 ZV9jaGlsZF9lbnRyeShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0 IG5vZGUgKm5vZGUsCiAJcmV0dXJuIHdyaXRlX25vZGUoY29ubiwgbm9kZSwg dHJ1ZSk7CiB9CiAKLXN0YXRpYyB2b2lkIGRlbGV0ZV9jaGlsZChzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKLQkJCSBzdHJ1Y3Qgbm9kZSAqbm9kZSwgY29u c3QgY2hhciAqY2hpbGRuYW1lKQorc3RhdGljIGludCBkZWxldGVfY2hpbGQo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCQlzdHJ1Y3Qgbm9kZSAqbm9k ZSwgY29uc3QgY2hhciAqY2hpbGRuYW1lKQogewogCXVuc2lnbmVkIGludCBp OwogCiAJZm9yIChpID0gMDsgaSA8IG5vZGUtPmNoaWxkbGVuOyBpICs9IHN0 cmxlbihub2RlLT5jaGlsZHJlbitpKSArIDEpIHsKIAkJaWYgKHN0cmVxKG5v ZGUtPmNoaWxkcmVuK2ksIGNoaWxkbmFtZSkpIHsKLQkJCWlmIChyZW1vdmVf Y2hpbGRfZW50cnkoY29ubiwgbm9kZSwgaSkpCi0JCQkJY29ycnVwdChjb25u LCAiQ2FuJ3QgdXBkYXRlIHBhcmVudCBub2RlICclcyciLAotCQkJCQlub2Rl LT5uYW1lKTsKLQkJCXJldHVybjsKKwkJCWVycm5vID0gcmVtb3ZlX2NoaWxk X2VudHJ5KGNvbm4sIG5vZGUsIGkpID8gRUlPIDogMDsKKwkJCXJldHVybiBl cnJubzsKIAkJfQogCX0KIAljb3JydXB0KGNvbm4sICJDYW4ndCBmaW5kIGNo aWxkICclcycgaW4gJXMiLCBjaGlsZG5hbWUsIG5vZGUtPm5hbWUpOworCisJ ZXJybm8gPSBFSU87CisJcmV0dXJuIGVycm5vOwogfQogCi1zdGF0aWMgaW50 IGRlbGV0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2 b2lkICpjdHgsCi0JCSAgICAgICBzdHJ1Y3Qgbm9kZSAqcGFyZW50LCBzdHJ1 Y3Qgbm9kZSAqbm9kZSwgYm9vbCB3YXRjaF9leGFjdCkKK3N0YXRpYyBpbnQg ZGVsbm9kZV9zdWIoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwKKwkJICAgICAgIHN0cnVjdCBub2RlICpub2RlLCB2b2lkICph cmcpCiB7Ci0JY2hhciAqbmFtZTsKKwljb25zdCBjaGFyICpyb290ID0gYXJn OworCWJvb2wgd2F0Y2hfZXhhY3Q7CisJaW50IHJldDsKKwlUREJfREFUQSBr ZXk7CiAKLQkvKiBEZWxldGUgY2hpbGRyZW4uICovCi0Jd2hpbGUgKG5vZGUt PmNoaWxkbGVuKSB7Ci0JCXN0cnVjdCBub2RlICpjaGlsZDsKKwkvKiBBbnkg ZXJyb3IgaGVyZSB3aWxsIHByb2JhYmx5IGJlIHJlcGVhdGVkIGZvciBhbGwg Zm9sbG93aW5nIGNhbGxzLiAqLworCXJldCA9IGFjY2Vzc19ub2RlKGNvbm4s IG5vZGUsIE5PREVfQUNDRVNTX0RFTEVURSwgJmtleSk7CisJaWYgKHJldCA+ IDApCisJCXJldHVybiBXQUxLX1RSRUVfU1VDQ0VTU19TVE9QOwogCi0JCW5h bWUgPSB0YWxsb2NfYXNwcmludGYobm9kZSwgIiVzLyVzIiwgbm9kZS0+bmFt ZSwKLQkJCQkgICAgICAgbm9kZS0+Y2hpbGRyZW4pOwotCQljaGlsZCA9IG5h bWUgPyByZWFkX25vZGUoY29ubiwgbm9kZSwgbmFtZSkgOiBOVUxMOwotCQlp ZiAoY2hpbGQpIHsKLQkJCWlmIChkZWxldGVfbm9kZShjb25uLCBjdHgsIG5v ZGUsIGNoaWxkLCB0cnVlKSkKLQkJCQlyZXR1cm4gZXJybm87Ci0JCX0gZWxz ZSB7Ci0JCQl0cmFjZSgiZGVsZXRlX25vZGU6IEVycm9yIGRlbGV0aW5nIGNo aWxkICclcy8lcychXG4iLAotCQkJICAgICAgbm9kZS0+bmFtZSwgbm9kZS0+ Y2hpbGRyZW4pOwotCQkJLyogUXVpdCBkZWxldGluZy4gKi8KLQkJCWVycm5v ID0gRU5PTUVNOwotCQkJcmV0dXJuIGVycm5vOwotCQl9Ci0JCXRhbGxvY19m cmVlKG5hbWUpOwotCX0KKwkvKiBJbiBjYXNlIG9mIGVycm9yIHN0b3AgdGhl IHdhbGsuICovCisJaWYgKCFyZXQgJiYgZG9fdGRiX2RlbGV0ZShjb25uLCAm a2V5LCAmbm9kZS0+YWNjKSkKKwkJcmV0dXJuIFdBTEtfVFJFRV9TVUNDRVNT X1NUT1A7CiAKIAkvKgogCSAqIEZpcmUgdGhlIHdhdGNoZXMgbm93LCB3aGVu IHdlIGNhbiBzdGlsbCBzZWUgdGhlIG5vZGUgcGVybWlzc2lvbnMuCiAJICog VGhpcyBmaW5lIGFzIHdlIGFyZSBzaW5nbGUgdGhyZWFkZWQgYW5kIHRoZSBu ZXh0IHBvc3NpYmxlIHJlYWQgd2lsbAogCSAqIGJlIGhhbmRsZWQgb25seSBh ZnRlciB0aGUgbm9kZSBoYXMgYmVlbiByZWFsbHkgcmVtb3ZlZC4KLQkgKi8K KwkqLworCXdhdGNoX2V4YWN0ID0gc3RyY21wKHJvb3QsIG5vZGUtPm5hbWUp OwogCWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5vZGUtPm5hbWUsIG5vZGUs IHdhdGNoX2V4YWN0LCBOVUxMKTsKLQlkZWxldGVfbm9kZV9zaW5nbGUoY29u biwgbm9kZSk7Ci0JZGVsZXRlX2NoaWxkKGNvbm4sIHBhcmVudCwgYmFzZW5h bWUobm9kZS0+bmFtZSkpOwotCXRhbGxvY19mcmVlKG5vZGUpOwogCi0JcmV0 dXJuIDA7CisJZG9tYWluX2VudHJ5X2RlYyhjb25uLCBub2RlKTsKKworCXJl dHVybiBXQUxLX1RSRUVfUk1fQ0hJTERFTlRSWTsKIH0KIAotc3RhdGljIGlu dCBfcm0oc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0 eCwgc3RydWN0IG5vZGUgKm5vZGUsCi0JICAgICAgIGNvbnN0IGNoYXIgKm5h bWUpCitzdGF0aWMgaW50IF9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3Qgdm9pZCAqY3R4LCBjb25zdCBjaGFyICpuYW1lKQogewotCS8qCi0J ICogRGVsZXRpbmcgbm9kZSBieSBub2RlLCBzbyB0aGUgcmVzdWx0IGlzIGFs d2F5cyBjb25zaXN0ZW50IGV2ZW4gaW4KLQkgKiBjYXNlIG9mIGEgZmFpbHVy ZS4KLQkgKi8KIAlzdHJ1Y3Qgbm9kZSAqcGFyZW50OwogCWNoYXIgKnBhcmVu dG5hbWUgPSBnZXRfcGFyZW50KGN0eCwgbmFtZSk7CisJc3RydWN0IHdhbGtf ZnVuY3Mgd2Fsa2Z1bmNzID0geyAuZXhpdCA9IGRlbG5vZGVfc3ViIH07CisJ aW50IHJldDsKIAogCWlmICghcGFyZW50bmFtZSkKIAkJcmV0dXJuIGVycm5v OwpAQCAtMTY1NSw5ICsxNjMwLDIxIEBAIHN0YXRpYyBpbnQgX3JtKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBu b2RlICpub2RlLAogCXBhcmVudCA9IHJlYWRfbm9kZShjb25uLCBjdHgsIHBh cmVudG5hbWUpOwogCWlmICghcGFyZW50KQogCQlyZXR1cm4gcmVhZF9ub2Rl X2Nhbl9wcm9wYWdhdGVfZXJybm8oKSA/IGVycm5vIDogRUlOVkFMOwotCW5v ZGUtPnBhcmVudCA9IHBhcmVudDsKIAotCXJldHVybiBkZWxldGVfbm9kZShj b25uLCBjdHgsIHBhcmVudCwgbm9kZSwgZmFsc2UpOworCXJldCA9IHdhbGtf bm9kZV90cmVlKGN0eCwgY29ubiwgbmFtZSwgJndhbGtmdW5jcywgKHZvaWQg KiluYW1lKTsKKwlpZiAocmV0IDwgMCkgeworCQlpZiAocmV0ID09IFdBTEtf VFJFRV9FUlJPUl9TVE9QKSB7CisJCQljb3JydXB0KGNvbm4sICJlcnJvciB3 aGVuIGRlbGV0aW5nIHN1Yi1ub2RlcyBvZiAlc1xuIiwKKwkJCQluYW1lKTsK KwkJCWVycm5vID0gRUlPOworCQl9CisJCXJldHVybiBlcnJubzsKKwl9CisK KwlpZiAoZGVsZXRlX2NoaWxkKGNvbm4sIHBhcmVudCwgYmFzZW5hbWUobmFt ZSkpKQorCQlyZXR1cm4gZXJybm87CisKKwlyZXR1cm4gMDsKIH0KIAogCkBA IC0xNjk0LDcgKzE2ODEsNyBAQCBzdGF0aWMgaW50IGRvX3JtKGNvbnN0IHZv aWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJaWYgKHN0cmVx KG5hbWUsICIvIikpCiAJCXJldHVybiBFSU5WQUw7CiAKLQlyZXQgPSBfcm0o Y29ubiwgY3R4LCBub2RlLCBuYW1lKTsKKwlyZXQgPSBfcm0oY29ubiwgY3R4 LCBuYW1lKTsKIAlpZiAocmV0KQogCQlyZXR1cm4gcmV0OwogCg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.15-07.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.15-07.patch" Content-Transfer-Encoding: base64 RnJvbSBhNGEwY2Q0MzVhMmQ3NGZjODkwMWNjNzk3OWNjMzc3NDUzODlmOTZl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHVzZSB0cmVl d2FsayBmb3IgY3JlYXRpbmcgbm9kZSByZWNvcmRzCgpJbnN0ZWFkIG9mIGRv aW5nIGFuIG9wZW4gdHJlZSB3YWxrIHVzaW5nIGNhbGwgcmVjdXJzaW9uLCB1 c2UKd2Fsa19ub2RlX3RyZWUoKSB3aGVuIGNyZWF0aW5nIHRoZSBub2RlIHJl Y29yZHMgZHVyaW5nIGEgbGl2ZSB1cGRhdGUuCgpUaGlzIHdpbGwgcmVkdWNl IGNvZGUgc2l6ZSBhbmQgYXZvaWQgbWFueSBuZXN0aW5nIGxldmVscyBvZiBm dW5jdGlvbgpjYWxscyB3aGljaCBjb3VsZCBwb3RlbnRpYWxseSBleGhhdXN0 IHRoZSBzdGFjay4KClRoaXMgaXMgcGFydCBvZiBYU0EtNDE4IC8gQ1ZFLTIw MjItNDIzMjEuCgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxkdnJhYmVs QGFtYXpvbi5jby51az4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8 amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxq Z3JhbGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2NvcmUuYwppbmRleCA5NTc2NDExNzU3ZmEuLmU4Y2RmZWVmNTBjNyAxMDA2 NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0yOTkwLDEz MiArMjk5MCwxMDkgQEAgY29uc3QgY2hhciAqZHVtcF9zdGF0ZV9idWZmZXJl ZF9kYXRhKEZJTEUgKmZwLCBjb25zdCBzdHJ1Y3QgY29ubmVjdGlvbiAqYywK IAlyZXR1cm4gTlVMTDsKIH0KIAotY29uc3QgY2hhciAqZHVtcF9zdGF0ZV9u b2RlX3Blcm1zKEZJTEUgKmZwLCBzdHJ1Y3QgeHNfc3RhdGVfbm9kZSAqc24s Ci0JCQkJICBjb25zdCBzdHJ1Y3QgeHNfcGVybWlzc2lvbnMgKnBlcm1zLAor Y29uc3QgY2hhciAqZHVtcF9zdGF0ZV9ub2RlX3Blcm1zKEZJTEUgKmZwLCBj b25zdCBzdHJ1Y3QgeHNfcGVybWlzc2lvbnMgKnBlcm1zLAogCQkJCSAgdW5z aWduZWQgaW50IG5fcGVybXMpCiB7CiAJdW5zaWduZWQgaW50IHA7CiAKIAlm b3IgKHAgPSAwOyBwIDwgbl9wZXJtczsgcCsrKSB7CisJCXN0cnVjdCB4c19z dGF0ZV9ub2RlX3Blcm0gc3A7CisKIAkJc3dpdGNoICgoaW50KXBlcm1zW3Bd LnBlcm1zICYgflhTX1BFUk1fSUdOT1JFKSB7CiAJCWNhc2UgWFNfUEVSTV9S RUFEOgotCQkJc24tPnBlcm1zW3BdLmFjY2VzcyA9IFhTX1NUQVRFX05PREVf UEVSTV9SRUFEOworCQkJc3AuYWNjZXNzID0gWFNfU1RBVEVfTk9ERV9QRVJN X1JFQUQ7CiAJCQlicmVhazsKIAkJY2FzZSBYU19QRVJNX1dSSVRFOgotCQkJ c24tPnBlcm1zW3BdLmFjY2VzcyA9IFhTX1NUQVRFX05PREVfUEVSTV9XUklU RTsKKwkJCXNwLmFjY2VzcyA9IFhTX1NUQVRFX05PREVfUEVSTV9XUklURTsK IAkJCWJyZWFrOwogCQljYXNlIFhTX1BFUk1fUkVBRCB8IFhTX1BFUk1fV1JJ VEU6Ci0JCQlzbi0+cGVybXNbcF0uYWNjZXNzID0gWFNfU1RBVEVfTk9ERV9Q RVJNX0JPVEg7CisJCQlzcC5hY2Nlc3MgPSBYU19TVEFURV9OT0RFX1BFUk1f Qk9USDsKIAkJCWJyZWFrOwogCQlkZWZhdWx0OgotCQkJc24tPnBlcm1zW3Bd LmFjY2VzcyA9IFhTX1NUQVRFX05PREVfUEVSTV9OT05FOworCQkJc3AuYWNj ZXNzID0gWFNfU1RBVEVfTk9ERV9QRVJNX05PTkU7CiAJCQlicmVhazsKIAkJ fQotCQlzbi0+cGVybXNbcF0uZmxhZ3MgPSAocGVybXNbcF0ucGVybXMgJiBY U19QRVJNX0lHTk9SRSkKKwkJc3AuZmxhZ3MgPSAocGVybXNbcF0ucGVybXMg JiBYU19QRVJNX0lHTk9SRSkKIAkJCQkgICAgID8gWFNfU1RBVEVfTk9ERV9Q RVJNX0lHTk9SRSA6IDA7Ci0JCXNuLT5wZXJtc1twXS5kb21pZCA9IHBlcm1z W3BdLmlkOwotCX0KKwkJc3AuZG9taWQgPSBwZXJtc1twXS5pZDsKIAotCWlm IChmd3JpdGUoc24tPnBlcm1zLCBzaXplb2YoKnNuLT5wZXJtcyksIG5fcGVy bXMsIGZwKSAhPSBuX3Blcm1zKQotCQlyZXR1cm4gIkR1bXAgbm9kZSBwZXJt aXNzaW9ucyBlcnJvciI7CisJCWlmIChmd3JpdGUoJnNwLCBzaXplb2Yoc3Ap LCAxLCBmcCkgIT0gMSkKKwkJCXJldHVybiAiRHVtcCBub2RlIHBlcm1pc3Np b25zIGVycm9yIjsKKwl9CiAKIAlyZXR1cm4gTlVMTDsKIH0KIAotc3RhdGlj IGNvbnN0IGNoYXIgKmR1bXBfc3RhdGVfbm9kZV90cmVlKEZJTEUgKmZwLCBj aGFyICpwYXRoKQorc3RydWN0IGR1bXBfbm9kZV9kYXRhIHsKKwlGSUxFICpm cDsKKwljb25zdCBjaGFyICplcnI7Cit9OworCitzdGF0aWMgaW50IGR1bXBf c3RhdGVfbm9kZV9lcnIoc3RydWN0IGR1bXBfbm9kZV9kYXRhICpkYXRhLCBj b25zdCBjaGFyICplcnIpCit7CisJZGF0YS0+ZXJyID0gZXJyOworCXJldHVy biBXQUxLX1RSRUVfRVJST1JfU1RPUDsKK30KKworc3RhdGljIGludCBkdW1w X3N0YXRlX25vZGUoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwKKwkJCSAgIHN0cnVjdCBub2RlICpub2RlLCB2b2lkICphcmcp CiB7Ci0JdW5zaWduZWQgaW50IHBhdGhsZW4sIGNoaWxkbGVuLCBwID0gMDsK KwlzdHJ1Y3QgZHVtcF9ub2RlX2RhdGEgKmRhdGEgPSBhcmc7CisJRklMRSAq ZnAgPSBkYXRhLT5mcDsKKwl1bnNpZ25lZCBpbnQgcGF0aGxlbjsKIAlzdHJ1 Y3QgeHNfc3RhdGVfcmVjb3JkX2hlYWRlciBoZWFkOwogCXN0cnVjdCB4c19z dGF0ZV9ub2RlIHNuOwotCVREQl9EQVRBIGtleSwgZGF0YTsKLQljb25zdCBz dHJ1Y3QgeHNfdGRiX3JlY29yZF9oZHIgKmhkcjsKLQljb25zdCBjaGFyICpj aGlsZDsKIAljb25zdCBjaGFyICpyZXQ7CiAKLQlwYXRobGVuID0gc3RybGVu KHBhdGgpICsgMTsKLQotCXNldF90ZGJfa2V5KHBhdGgsICZrZXkpOwotCWRh dGEgPSB0ZGJfZmV0Y2godGRiX2N0eCwga2V5KTsKLQlpZiAoZGF0YS5kcHRy ID09IE5VTEwpCi0JCXJldHVybiAiRXJyb3IgcmVhZGluZyBub2RlIjsKLQot CS8qIENsZWFuIHVwIGluIGNhc2Ugb2YgZmFpbHVyZS4gKi8KLQl0YWxsb2Nf c3RlYWwocGF0aCwgZGF0YS5kcHRyKTsKLQotCWhkciA9ICh2b2lkICopZGF0 YS5kcHRyOworCXBhdGhsZW4gPSBzdHJsZW4obm9kZS0+bmFtZSkgKyAxOwog CiAJaGVhZC50eXBlID0gWFNfU1RBVEVfVFlQRV9OT0RFOwogCWhlYWQubGVu Z3RoID0gc2l6ZW9mKHNuKTsKIAlzbi5jb25uX2lkID0gMDsKIAlzbi50YV9p ZCA9IDA7CiAJc24udGFfYWNjZXNzID0gMDsKLQlzbi5wZXJtX24gPSBoZHIt Pm51bV9wZXJtczsKKwlzbi5wZXJtX24gPSBub2RlLT5wZXJtcy5udW07CiAJ c24ucGF0aF9sZW4gPSBwYXRobGVuOwotCXNuLmRhdGFfbGVuID0gaGRyLT5k YXRhbGVuOwotCWhlYWQubGVuZ3RoICs9IGhkci0+bnVtX3Blcm1zICogc2l6 ZW9mKCpzbi5wZXJtcyk7CisJc24uZGF0YV9sZW4gPSBub2RlLT5kYXRhbGVu OworCWhlYWQubGVuZ3RoICs9IG5vZGUtPnBlcm1zLm51bSAqIHNpemVvZigq c24ucGVybXMpOwogCWhlYWQubGVuZ3RoICs9IHBhdGhsZW47Ci0JaGVhZC5s ZW5ndGggKz0gaGRyLT5kYXRhbGVuOworCWhlYWQubGVuZ3RoICs9IG5vZGUt PmRhdGFsZW47CiAJaGVhZC5sZW5ndGggPSBST1VORFVQKGhlYWQubGVuZ3Ro LCAzKTsKIAogCWlmIChmd3JpdGUoJmhlYWQsIHNpemVvZihoZWFkKSwgMSwg ZnApICE9IDEpCi0JCXJldHVybiAiRHVtcCBub2RlIHN0YXRlIGVycm9yIjsK KwkJcmV0dXJuIGR1bXBfc3RhdGVfbm9kZV9lcnIoZGF0YSwgIkR1bXAgbm9k ZSBoZWFkIGVycm9yIik7CiAJaWYgKGZ3cml0ZSgmc24sIHNpemVvZihzbiks IDEsIGZwKSAhPSAxKQotCQlyZXR1cm4gIkR1bXAgbm9kZSBzdGF0ZSBlcnJv ciI7CisJCXJldHVybiBkdW1wX3N0YXRlX25vZGVfZXJyKGRhdGEsICJEdW1w IG5vZGUgc3RhdGUgZXJyb3IiKTsKIAotCXJldCA9IGR1bXBfc3RhdGVfbm9k ZV9wZXJtcyhmcCwgJnNuLCBoZHItPnBlcm1zLCBoZHItPm51bV9wZXJtcyk7 CisJcmV0ID0gZHVtcF9zdGF0ZV9ub2RlX3Blcm1zKGZwLCBub2RlLT5wZXJt cy5wLCBub2RlLT5wZXJtcy5udW0pOwogCWlmIChyZXQpCi0JCXJldHVybiBy ZXQ7CisJCXJldHVybiBkdW1wX3N0YXRlX25vZGVfZXJyKGRhdGEsIHJldCk7 CiAKLQlpZiAoZndyaXRlKHBhdGgsIHBhdGhsZW4sIDEsIGZwKSAhPSAxKQot CQlyZXR1cm4gIkR1bXAgbm9kZSBwYXRoIGVycm9yIjsKLQlpZiAoaGRyLT5k YXRhbGVuICYmCi0JICAgIGZ3cml0ZShoZHItPnBlcm1zICsgaGRyLT5udW1f cGVybXMsIGhkci0+ZGF0YWxlbiwgMSwgZnApICE9IDEpCi0JCXJldHVybiAi RHVtcCBub2RlIGRhdGEgZXJyb3IiOworCWlmIChmd3JpdGUobm9kZS0+bmFt ZSwgcGF0aGxlbiwgMSwgZnApICE9IDEpCisJCXJldHVybiBkdW1wX3N0YXRl X25vZGVfZXJyKGRhdGEsICJEdW1wIG5vZGUgcGF0aCBlcnJvciIpOworCisJ aWYgKG5vZGUtPmRhdGFsZW4gJiYgZndyaXRlKG5vZGUtPmRhdGEsIG5vZGUt PmRhdGFsZW4sIDEsIGZwKSAhPSAxKQorCQlyZXR1cm4gZHVtcF9zdGF0ZV9u b2RlX2VycihkYXRhLCAiRHVtcCBub2RlIGRhdGEgZXJyb3IiKTsKIAogCXJl dCA9IGR1bXBfc3RhdGVfYWxpZ24oZnApOwogCWlmIChyZXQpCi0JCXJldHVy biByZXQ7Ci0KLQljaGlsZCA9IChjaGFyICopKGhkci0+cGVybXMgKyBoZHIt Pm51bV9wZXJtcykgKyBoZHItPmRhdGFsZW47Ci0KLQkvKgotCSAqIFVzZSBw YXRoIGZvciBjb25zdHJ1Y3RpbmcgY2hpbGRyZW4gcGF0aHMuCi0JICogQXMg d2UgZG9uJ3Qgd3JpdGUgb3V0IG5vZGVzIHdpdGhvdXQgaGF2aW5nIHdyaXR0 ZW4gdGhlaXIgcGFyZW50Ci0JICogYWxyZWFkeSB3ZSB3aWxsIG5ldmVyIGNs b2JiZXIgYSBwYXJ0IG9mIHRoZSBwYXRoIHdlJ2xsIG5lZWQgbGF0ZXIuCi0J ICovCi0JcGF0aGxlbi0tOwotCWlmIChwYXRoW3BhdGhsZW4gLSAxXSAhPSAn LycpIHsKLQkJcGF0aFtwYXRobGVuXSA9ICcvJzsKLQkJcGF0aGxlbisrOwot CX0KLQl3aGlsZSAocCA8IGhkci0+Y2hpbGRsZW4pIHsKLQkJY2hpbGRsZW4g PSBzdHJsZW4oY2hpbGQpICsgMTsKLQkJaWYgKHBhdGhsZW4gKyBjaGlsZGxl biA+IFhFTlNUT1JFX0FCU19QQVRIX01BWCkKLQkJCXJldHVybiAiRHVtcCBu b2RlIHBhdGggbGVuZ3RoIGVycm9yIjsKLQkJc3RyY3B5KHBhdGggKyBwYXRo bGVuLCBjaGlsZCk7Ci0JCXJldCA9IGR1bXBfc3RhdGVfbm9kZV90cmVlKGZw LCBwYXRoKTsKLQkJaWYgKHJldCkKLQkJCXJldHVybiByZXQ7Ci0JCXAgKz0g Y2hpbGRsZW47Ci0JCWNoaWxkICs9IGNoaWxkbGVuOwotCX0KLQotCXRhbGxv Y19mcmVlKGRhdGEuZHB0cik7CisJCXJldHVybiBkdW1wX3N0YXRlX25vZGVf ZXJyKGRhdGEsIHJldCk7CiAKLQlyZXR1cm4gTlVMTDsKKwlyZXR1cm4gV0FM S19UUkVFX09LOwogfQogCiBjb25zdCBjaGFyICpkdW1wX3N0YXRlX25vZGVz KEZJTEUgKmZwLCBjb25zdCB2b2lkICpjdHgpCiB7Ci0JY2hhciAqcGF0aDsK LQotCXBhdGggPSB0YWxsb2Nfc2l6ZShjdHgsIFhFTlNUT1JFX0FCU19QQVRI X01BWCk7Ci0JaWYgKCFwYXRoKQotCQlyZXR1cm4gIlBhdGggYnVmZmVyIGFs bG9jYXRpb24gZXJyb3IiOworCXN0cnVjdCBkdW1wX25vZGVfZGF0YSBkYXRh ID0geworCQkuZnAgPSBmcCwKKwkJLmVyciA9ICJEdW1wIG5vZGUgd2FsayBl cnJvciIKKwl9OworCXN0cnVjdCB3YWxrX2Z1bmNzIHdhbGtmdW5jcyA9IHsg LmVudGVyID0gZHVtcF9zdGF0ZV9ub2RlIH07CiAKLQlzdHJjcHkocGF0aCwg Ii8iKTsKKwlpZiAod2Fsa19ub2RlX3RyZWUoY3R4LCBOVUxMLCAiLyIsICZ3 YWxrZnVuY3MsICZkYXRhKSkKKwkJcmV0dXJuIGRhdGEuZXJyOwogCi0JcmV0 dXJuIGR1bXBfc3RhdGVfbm9kZV90cmVlKGZwLCBwYXRoKTsKKwlyZXR1cm4g TlVMTDsKIH0KIAogdm9pZCByZWFkX3N0YXRlX2dsb2JhbChjb25zdCB2b2lk ICpjdHgsIGNvbnN0IHZvaWQgKnN0YXRlKQpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmgKaW5kZXggZjBmZDhjMzUyODU3Li4zMTkwNDk0YmJl YjUgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAt MzI2LDggKzMyNiw3IEBAIGNvbnN0IGNoYXIgKmR1bXBfc3RhdGVfYnVmZmVy ZWRfZGF0YShGSUxFICpmcCwgY29uc3Qgc3RydWN0IGNvbm5lY3Rpb24gKmMs CiAJCQkJICAgICBjb25zdCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJ CQkgICAgIHN0cnVjdCB4c19zdGF0ZV9jb25uZWN0aW9uICpzYyk7CiBjb25z dCBjaGFyICpkdW1wX3N0YXRlX25vZGVzKEZJTEUgKmZwLCBjb25zdCB2b2lk ICpjdHgpOwotY29uc3QgY2hhciAqZHVtcF9zdGF0ZV9ub2RlX3Blcm1zKEZJ TEUgKmZwLCBzdHJ1Y3QgeHNfc3RhdGVfbm9kZSAqc24sCi0JCQkJICBjb25z dCBzdHJ1Y3QgeHNfcGVybWlzc2lvbnMgKnBlcm1zLAorY29uc3QgY2hhciAq ZHVtcF9zdGF0ZV9ub2RlX3Blcm1zKEZJTEUgKmZwLCBjb25zdCBzdHJ1Y3Qg eHNfcGVybWlzc2lvbnMgKnBlcm1zLAogCQkJCSAgdW5zaWduZWQgaW50IG5f cGVybXMpOwogCiB2b2lkIHJlYWRfc3RhdGVfZ2xvYmFsKGNvbnN0IHZvaWQg KmN0eCwgY29uc3Qgdm9pZCAqc3RhdGUpOwpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IDhiNTAzYzJkZmUwNy4uYTkxY2M3 NWFiNTliIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFp bi5jCkBAIC0xNDQ5LDcgKzE0NDksNyBAQCBzdGF0aWMgY29uc3QgY2hhciAq ZHVtcF9zdGF0ZV9zcGVjaWFsX25vZGUoRklMRSAqZnAsIGNvbnN0IGNoYXIg Km5hbWUsCiAJaWYgKGZ3cml0ZSgmc24sIHNpemVvZihzbiksIDEsIGZwKSAh PSAxKQogCQlyZXR1cm4gIkR1bXAgc3BlY2lhbCBub2RlIGVycm9yIjsKIAot CXJldCA9IGR1bXBfc3RhdGVfbm9kZV9wZXJtcyhmcCwgJnNuLCBwZXJtcy0+ cCwgcGVybXMtPm51bSk7CisJcmV0ID0gZHVtcF9zdGF0ZV9ub2RlX3Blcm1z KGZwLCBwZXJtcy0+cCwgcGVybXMtPm51bSk7CiAJaWYgKHJldCkKIAkJcmV0 dXJuIHJldDsKIAo= --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.16-01.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.16-01.patch" Content-Transfer-Encoding: base64 RnJvbSBkMWU2ZGNhNDg2NTk5YWI5MTRhZjdiMzhiMzc4MmIyMzdkM2Q2MDNi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTEgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHJlbW92ZSBy ZWN1cnNpb24gZnJvbSBjb25zdHJ1Y3Rfbm9kZSgpCgpJbiBvcmRlciB0byBy ZWR1Y2Ugc3RhY2sgdXNhZ2UgZHVlIHRvIHJlY3Vyc2lvbiwgc3dpdGNoCmNv bnN0cnVjdF9ub2RlKCkgdG8gdXNlIGEgbG9vcCBpbnN0ZWFkLgoKVGhpcyBp cyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9ydGVk LWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpTaWdu ZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJl dmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoK ZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IGM2NzZl ZTRlNGU0Zi4uMzkwN2MzNTY0M2U5IDEwMDY0NAotLS0gYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKQEAgLTEzNzcsNDUgKzEzNzcsNjkgQEAgc3RhdGlj IGludCBhZGRfY2hpbGQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3Qgbm9kZSAq cGFyZW50LCBjb25zdCBjaGFyICpuYW1lKQogc3RhdGljIHN0cnVjdCBub2Rl ICpjb25zdHJ1Y3Rfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29u c3Qgdm9pZCAqY3R4LAogCQkJCSAgIGNvbnN0IGNoYXIgKm5hbWUpCiB7Ci0J c3RydWN0IG5vZGUgKnBhcmVudCwgKm5vZGU7Ci0JY2hhciAqcGFyZW50bmFt ZSA9IGdldF9wYXJlbnQoY3R4LCBuYW1lKTsKKwljb25zdCBjaGFyICoqbmFt ZXMgPSBOVUxMOworCXVuc2lnbmVkIGludCBsZXZlbHMgPSAwOworCXN0cnVj dCBub2RlICpub2RlID0gTlVMTDsKKwlzdHJ1Y3Qgbm9kZSAqcGFyZW50ID0g TlVMTDsKKwljb25zdCBjaGFyICpwYXJlbnRuYW1lID0gdGFsbG9jX3N0cmR1 cChjdHgsIG5hbWUpOwogCiAJaWYgKCFwYXJlbnRuYW1lKQogCQlyZXR1cm4g TlVMTDsKIAotCS8qIElmIHBhcmVudCBkb2Vzbid0IGV4aXN0LCBjcmVhdGUg aXQuICovCi0JcGFyZW50ID0gcmVhZF9ub2RlKGNvbm4sIHBhcmVudG5hbWUs IHBhcmVudG5hbWUpOwotCWlmICghcGFyZW50ICYmIGVycm5vID09IEVOT0VO VCkKLQkJcGFyZW50ID0gY29uc3RydWN0X25vZGUoY29ubiwgY3R4LCBwYXJl bnRuYW1lKTsKLQlpZiAoIXBhcmVudCkKLQkJcmV0dXJuIE5VTEw7CisJLyog V2FsayB0aGUgcGF0aCB1cCB1bnRpbCBhbiBleGlzdGluZyBub2RlIGlzIGZv dW5kLiAqLworCXdoaWxlICghcGFyZW50KSB7CisJCW5hbWVzID0gdGFsbG9j X3JlYWxsb2MoY3R4LCBuYW1lcywgY29uc3QgY2hhciAqLCBsZXZlbHMgKyAx KTsKKwkJaWYgKCFuYW1lcykKKwkJCWdvdG8gbm9tZW07CiAKLQkvKiBBZGQg Y2hpbGQgdG8gcGFyZW50LiAqLwotCWlmIChhZGRfY2hpbGQoY3R4LCBwYXJl bnQsIG5hbWUpKQotCQlnb3RvIG5vbWVtOworCQkvKgorCQkgKiBuYW1lc1sw XSBpcyB0aGUgbmFtZSBvZiB0aGUgbm9kZSB0byBjb25zdHJ1Y3QgaW5pdGlh bGx5LAorCQkgKiBuYW1lc1sxXSBpcyBpdHMgcGFyZW50LCBhbmQgc28gb24u CisJCSAqLworCQluYW1lc1tsZXZlbHNdID0gcGFyZW50bmFtZTsKKwkJcGFy ZW50bmFtZSA9IGdldF9wYXJlbnQoY3R4LCBwYXJlbnRuYW1lKTsKKwkJaWYg KCFwYXJlbnRuYW1lKQorCQkJcmV0dXJuIE5VTEw7CiAKLQkvKiBBbGxvY2F0 ZSBub2RlICovCi0Jbm9kZSA9IHRhbGxvYyhjdHgsIHN0cnVjdCBub2RlKTsK LQlpZiAoIW5vZGUpCi0JCWdvdG8gbm9tZW07Ci0Jbm9kZS0+bmFtZSA9IHRh bGxvY19zdHJkdXAobm9kZSwgbmFtZSk7Ci0JaWYgKCFub2RlLT5uYW1lKQot CQlnb3RvIG5vbWVtOworCQkvKiBUcnkgdG8gcmVhZCBwYXJlbnQgbm9kZSB1 bnRpbCB3ZSBmb3VuZCBhbiBleGlzdGluZyBvbmUuICovCisJCXBhcmVudCA9 IHJlYWRfbm9kZShjb25uLCBjdHgsIHBhcmVudG5hbWUpOworCQlpZiAoIXBh cmVudCAmJiAoZXJybm8gIT0gRU5PRU5UIHx8ICFzdHJjbXAocGFyZW50bmFt ZSwgIi8iKSkpCisJCQlyZXR1cm4gTlVMTDsKIAotCS8qIEluaGVyaXQgcGVy bWlzc2lvbnMsIGV4Y2VwdCB1bnByaXZpbGVnZWQgZG9tYWlucyBvd24gd2hh dCB0aGV5IGNyZWF0ZSAqLwotCW5vZGUtPnBlcm1zLm51bSA9IHBhcmVudC0+ cGVybXMubnVtOwotCW5vZGUtPnBlcm1zLnAgPSB0YWxsb2NfbWVtZHVwKG5v ZGUsIHBhcmVudC0+cGVybXMucCwKLQkJCQkgICAgICBub2RlLT5wZXJtcy5u dW0gKiBzaXplb2YoKm5vZGUtPnBlcm1zLnApKTsKLQlpZiAoIW5vZGUtPnBl cm1zLnApCi0JCWdvdG8gbm9tZW07Ci0JaWYgKGRvbWFpbl9pc191bnByaXZp bGVnZWQoY29ubikpCi0JCW5vZGUtPnBlcm1zLnBbMF0uaWQgPSBjb25uLT5p ZDsKKwkJbGV2ZWxzKys7CisJfQorCisJLyogV2FsayB0aGUgcGF0aCBkb3du IGFnYWluIGNvbnN0cnVjdGluZyB0aGUgbWlzc2luZyBub2Rlcy4gKi8KKwlm b3IgKDsgbGV2ZWxzID4gMDsgbGV2ZWxzLS0pIHsKKwkJLyogQWRkIGNoaWxk IHRvIHBhcmVudC4gKi8KKwkJaWYgKGFkZF9jaGlsZChjdHgsIHBhcmVudCwg bmFtZXNbbGV2ZWxzIC0gMV0pKQorCQkJZ290byBub21lbTsKKworCQkvKiBB bGxvY2F0ZSBub2RlICovCisJCW5vZGUgPSB0YWxsb2MoY3R4LCBzdHJ1Y3Qg bm9kZSk7CisJCWlmICghbm9kZSkKKwkJCWdvdG8gbm9tZW07CisJCW5vZGUt Pm5hbWUgPSB0YWxsb2Nfc3RlYWwobm9kZSwgbmFtZXNbbGV2ZWxzIC0gMV0p OworCisJCS8qIEluaGVyaXQgcGVybWlzc2lvbnMsIHVucHJpdiBkb21haW5z IG93biB3aGF0IHRoZXkgY3JlYXRlLiAqLworCQlub2RlLT5wZXJtcy5udW0g PSBwYXJlbnQtPnBlcm1zLm51bTsKKwkJbm9kZS0+cGVybXMucCA9IHRhbGxv Y19tZW1kdXAobm9kZSwgcGFyZW50LT5wZXJtcy5wLAorCQkJCQkgICAgICBu b2RlLT5wZXJtcy5udW0gKgorCQkJCQkgICAgICBzaXplb2YoKm5vZGUtPnBl cm1zLnApKTsKKwkJaWYgKCFub2RlLT5wZXJtcy5wKQorCQkJZ290byBub21l bTsKKwkJaWYgKGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikpCisJCQlu b2RlLT5wZXJtcy5wWzBdLmlkID0gY29ubi0+aWQ7CisKKwkJLyogTm8gY2hp bGRyZW4sIG5vIGRhdGEgKi8KKwkJbm9kZS0+Y2hpbGRyZW4gPSBub2RlLT5k YXRhID0gTlVMTDsKKwkJbm9kZS0+Y2hpbGRsZW4gPSBub2RlLT5kYXRhbGVu ID0gMDsKKwkJbm9kZS0+YWNjLm1lbW9yeSA9IDA7CisJCW5vZGUtPnBhcmVu dCA9IHBhcmVudDsKKworCQlwYXJlbnQgPSBub2RlOworCX0KIAotCS8qIE5v IGNoaWxkcmVuLCBubyBkYXRhICovCi0Jbm9kZS0+Y2hpbGRyZW4gPSBub2Rl LT5kYXRhID0gTlVMTDsKLQlub2RlLT5jaGlsZGxlbiA9IG5vZGUtPmRhdGFs ZW4gPSAwOwotCW5vZGUtPmFjYy5tZW1vcnkgPSAwOwotCW5vZGUtPnBhcmVu dCA9IHBhcmVudDsKIAlyZXR1cm4gbm9kZTsKIAogbm9tZW06Cg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.16-02.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.16-02.patch" Content-Transfer-Encoding: base64 RnJvbSBjMTNkODVhMmZlOTRiYmYzY2I4MTg2Yjg5MzI0YzVkMWI0ZjlhNjFm IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTEgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGRvbid0IGxl dCByZW1vdmVfY2hpbGRfZW50cnkoKSBjYWxsIGNvcnJ1cHQoKQoKSW4gY2Fz ZSBvZiB3cml0ZV9ub2RlKCkgcmV0dXJuaW5nIGFuIGVycm9yLCByZW1vdmVf Y2hpbGRfZW50cnkoKSB3aWxsCmNhbGwgY29ycnVwdCgpIHRvZGF5LiBUaGlz IGNvdWxkIHJlc3VsdCBpbiBhbiBlbmRsZXNzIHJlY3Vyc2lvbiwgYXMKcmVt b3ZlX2NoaWxkX2VudHJ5KCkgaXMgY2FsbGVkIGJ5IGNvcnJ1cHQoKSwgdG9v OgoKY29ycnVwdCgpCiAgY2hlY2tfc3RvcmUoKQogICAgY2hlY2tfc3RvcmVf KCkKICAgICAgcmVtb3ZlX2NoaWxkX2VudHJ5KCkKCkZpeCB0aGF0IGJ5IGxl dHRpbmcgcmVtb3ZlX2NoaWxkX2VudHJ5KCkgcmV0dXJuIGFuIGVycm9yIGlu c3RlYWQgYW5kCmxldCB0aGUgY2FsbGVyIGRlY2lkZSB3aGF0IHRvIGRvLgoK VGhpcyBpcyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJl cG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVr PgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5j b20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24u Y29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4 IDM5MDdjMzU2NDNlOS4uZjQzM2E0NWRjMjE3IDEwMDY0NAotLS0gYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTE2MDgsMTUgKzE2MDgsMTUgQEAg c3RhdGljIHZvaWQgbWVtZGVsKHZvaWQgKm1lbSwgdW5zaWduZWQgb2ZmLCB1 bnNpZ25lZCBsZW4sIHVuc2lnbmVkIHRvdGFsKQogCW1lbW1vdmUobWVtICsg b2ZmLCBtZW0gKyBvZmYgKyBsZW4sIHRvdGFsIC0gb2ZmIC0gbGVuKTsKIH0K IAotc3RhdGljIHZvaWQgcmVtb3ZlX2NoaWxkX2VudHJ5KHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKLQkJCSAgICAgICBz aXplX3Qgb2Zmc2V0KQorc3RhdGljIGludCByZW1vdmVfY2hpbGRfZW50cnko c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAor CQkJICAgICAgc2l6ZV90IG9mZnNldCkKIHsKIAlzaXplX3QgY2hpbGRsZW4g PSBzdHJsZW4obm9kZS0+Y2hpbGRyZW4gKyBvZmZzZXQpOwogCiAJbWVtZGVs KG5vZGUtPmNoaWxkcmVuLCBvZmZzZXQsIGNoaWxkbGVuICsgMSwgbm9kZS0+ Y2hpbGRsZW4pOwogCW5vZGUtPmNoaWxkbGVuIC09IGNoaWxkbGVuICsgMTsK LQlpZiAod3JpdGVfbm9kZShjb25uLCBub2RlLCB0cnVlKSkKLQkJY29ycnVw dChjb25uLCAiQ2FuJ3QgdXBkYXRlIHBhcmVudCBub2RlICclcyciLCBub2Rl LT5uYW1lKTsKKworCXJldHVybiB3cml0ZV9ub2RlKGNvbm4sIG5vZGUsIHRy dWUpOwogfQogCiBzdGF0aWMgdm9pZCBkZWxldGVfY2hpbGQoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCkBAIC0xNjI2LDcgKzE2MjYsOSBAQCBzdGF0aWMg dm9pZCBkZWxldGVfY2hpbGQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAK IAlmb3IgKGkgPSAwOyBpIDwgbm9kZS0+Y2hpbGRsZW47IGkgKz0gc3RybGVu KG5vZGUtPmNoaWxkcmVuK2kpICsgMSkgewogCQlpZiAoc3RyZXEobm9kZS0+ Y2hpbGRyZW4raSwgY2hpbGRuYW1lKSkgewotCQkJcmVtb3ZlX2NoaWxkX2Vu dHJ5KGNvbm4sIG5vZGUsIGkpOworCQkJaWYgKHJlbW92ZV9jaGlsZF9lbnRy eShjb25uLCBub2RlLCBpKSkKKwkJCQljb3JydXB0KGNvbm4sICJDYW4ndCB1 cGRhdGUgcGFyZW50IG5vZGUgJyVzJyIsCisJCQkJCW5vZGUtPm5hbWUpOwog CQkJcmV0dXJuOwogCQl9CiAJfQpAQCAtMjMyNSw2ICsyMzI3LDE3IEBAIGlu dCByZW1lbWJlcl9zdHJpbmcoc3RydWN0IGhhc2h0YWJsZSAqaGFzaCwgY29u c3QgY2hhciAqc3RyKQogCXJldHVybiBoYXNodGFibGVfaW5zZXJ0KGhhc2gs IGssICh2b2lkICopMSk7CiB9CiAKK3N0YXRpYyBpbnQgcm1fY2hpbGRfZW50 cnkoc3RydWN0IG5vZGUgKm5vZGUsIHNpemVfdCBvZmYsIHNpemVfdCBsZW4p Cit7CisJaWYgKCFyZWNvdmVyeSkKKwkJcmV0dXJuIG9mZjsKKworCWlmIChy ZW1vdmVfY2hpbGRfZW50cnkoTlVMTCwgbm9kZSwgb2ZmKSkKKwkJbG9nKCJj aGVja19zdG9yZTogY2hpbGQgZW50cnkgY291bGQgbm90IGJlIHJlbW92ZWQg ZnJvbSAnJXMnIiwKKwkJICAgIG5vZGUtPm5hbWUpOworCisJcmV0dXJuIG9m ZiAtIGxlbiAtIDE7Cit9CiAKIC8qKgogICogQSBub2RlIGhhcyBhIGNoaWxk cmVuIGZpZWxkIHRoYXQgbmFtZXMgdGhlIGNoaWxkcmVuIG9mIHRoZSBub2Rl LCBzZXBhcmF0ZWQKQEAgLTIzNzcsMTIgKzIzOTAsNyBAQCBzdGF0aWMgaW50 IGNoZWNrX3N0b3JlXyhjb25zdCBjaGFyICpuYW1lLCBzdHJ1Y3QgaGFzaHRh YmxlICpyZWFjaGFibGUpCiAJCQkJaWYgKGhhc2h0YWJsZV9zZWFyY2goY2hp bGRyZW4sIGNoaWxkbmFtZSkpIHsKIAkJCQkJbG9nKCJjaGVja19zdG9yZTog JyVzJyBpcyBkdXBsaWNhdGVkISIsCiAJCQkJCSAgICBjaGlsZG5hbWUpOwot Ci0JCQkJCWlmIChyZWNvdmVyeSkgewotCQkJCQkJcmVtb3ZlX2NoaWxkX2Vu dHJ5KE5VTEwsIG5vZGUsCi0JCQkJCQkJCSAgIGkpOwotCQkJCQkJaSAtPSBj aGlsZGxlbiArIDE7Ci0JCQkJCX0KKwkJCQkJaSA9IHJtX2NoaWxkX2VudHJ5 KG5vZGUsIGksIGNoaWxkbGVuKTsKIAkJCQl9CiAJCQkJZWxzZSB7CiAJCQkJ CWlmICghcmVtZW1iZXJfc3RyaW5nKGNoaWxkcmVuLApAQCAtMjM5OSwxMSAr MjQwNyw3IEBAIHN0YXRpYyBpbnQgY2hlY2tfc3RvcmVfKGNvbnN0IGNoYXIg Km5hbWUsIHN0cnVjdCBoYXNodGFibGUgKnJlYWNoYWJsZSkKIAkJCX0gZWxz ZSBpZiAoZXJybm8gIT0gRU5PTUVNKSB7CiAJCQkJbG9nKCJjaGVja19zdG9y ZTogTm8gY2hpbGQgJyVzJyBmb3VuZCFcbiIsCiAJCQkJICAgIGNoaWxkbmFt ZSk7Ci0KLQkJCQlpZiAocmVjb3ZlcnkpIHsKLQkJCQkJcmVtb3ZlX2NoaWxk X2VudHJ5KE5VTEwsIG5vZGUsIGkpOwotCQkJCQlpIC09IGNoaWxkbGVuICsg MTsKLQkJCQl9CisJCQkJaSA9IHJtX2NoaWxkX2VudHJ5KG5vZGUsIGksIGNo aWxkbGVuKTsKIAkJCX0gZWxzZSB7CiAJCQkJbG9nKCJjaGVja19zdG9yZTog RU5PTUVNIik7CiAJCQkJcmV0ID0gRU5PTUVNOwo= --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.16-03.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.16-03.patch" Content-Transfer-Encoding: base64 RnJvbSBhYWM5YjUxYjZmYmJiZDE2YzkxMGY2OTM2NTM0NTUyOGM1YmVjMTA2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTEgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBnZW5l cmljIHRyZWV3YWxrIGZ1bmN0aW9uCgpBZGQgYSBnZW5lcmljIGZ1bmN0aW9u IHRvIHdhbGsgdGhlIGNvbXBsZXRlIG5vZGUgdHJlZS4gSXQgd2lsbCBzdGFy dAphdCAiLyIgYW5kIGRlc2NlbmQgcmVjdXJzaXZlbHkgaW50byBlYWNoIGNo aWxkLCBjYWxsaW5nIGEgZnVuY3Rpb24Kc3BlY2lmaWVkIGJ5IHRoZSBjYWxs ZXIuIERlcGVuZGluZyBvbiB0aGUgcmV0dXJuIHZhbHVlIG9mIHRoZSB1c2Vy CnNwZWNpZmllZCBmdW5jdGlvbiB0aGUgd2FsayB3aWxsIGJlIGFib3J0ZWQs IGNvbnRpbnVlZCwgb3IgdGhlIGN1cnJlbnQKY2hpbGQgd2lsbCBiZSBza2lw cGVkIGJ5IG5vdCBkZXNjZW5kaW5nIGludG8gaXRzIGNoaWxkcmVuLgoKVGhp cyBpcyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9y dGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpT aWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ CkFja2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoK ZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IGY0MzNh NDVkYzIxNy4uMmNkYTNlZTM3NWFiIDEwMDY0NAotLS0gYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKQEAgLTE4MzgsNiArMTgzOCwxMzUgQEAgc3RhdGlj IGludCBkb19zZXRfcGVybXMoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwKIAlyZXR1cm4gMDsKIH0KIAorc3RhdGljIGNoYXIg KmNoaWxkX25hbWUoY29uc3Qgdm9pZCAqY3R4LCBjb25zdCBjaGFyICpzMSwg Y29uc3QgY2hhciAqczIpCit7CisJaWYgKHN0cmNtcChzMSwgIi8iKSkKKwkJ cmV0dXJuIHRhbGxvY19hc3ByaW50ZihjdHgsICIlcy8lcyIsIHMxLCBzMik7 CisJcmV0dXJuIHRhbGxvY19hc3ByaW50ZihjdHgsICIvJXMiLCBzMik7Cit9 CisKK3N0YXRpYyBpbnQgcm1fZnJvbV9wYXJlbnQoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIHN0cnVjdCBub2RlICpwYXJlbnQsCisJCQkgIGNvbnN0IGNo YXIgKm5hbWUpCit7CisJc2l6ZV90IG9mZjsKKworCWlmICghcGFyZW50KQor CQlyZXR1cm4gV0FMS19UUkVFX0VSUk9SX1NUT1A7CisKKwlmb3IgKG9mZiA9 IHBhcmVudC0+Y2hpbGRvZmYgLSAxOyBvZmYgJiYgcGFyZW50LT5jaGlsZHJl bltvZmYgLSAxXTsKKwkgICAgIG9mZi0tKTsKKwlpZiAocmVtb3ZlX2NoaWxk X2VudHJ5KGNvbm4sIHBhcmVudCwgb2ZmKSkgeworCQlsb2coInRyZWV3YWxr OiBjaGlsZCBlbnRyeSBjb3VsZCBub3QgYmUgcmVtb3ZlZCBmcm9tICclcyci LAorCQkgICAgcGFyZW50LT5uYW1lKTsKKwkJcmV0dXJuIFdBTEtfVFJFRV9F UlJPUl9TVE9QOworCX0KKwlwYXJlbnQtPmNoaWxkb2ZmID0gb2ZmOworCisJ cmV0dXJuIFdBTEtfVFJFRV9PSzsKK30KKworc3RhdGljIGludCB3YWxrX2Nh bGxfZnVuYyhjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpj b25uLAorCQkJICBzdHJ1Y3Qgbm9kZSAqbm9kZSwgc3RydWN0IG5vZGUgKnBh cmVudCwgdm9pZCAqYXJnLAorCQkJICBpbnQgKCpmdW5jKShjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkJCSAgICAgIHN0 cnVjdCBub2RlICpub2RlLCB2b2lkICphcmcpKQoreworCWludCByZXQ7CisK KwlpZiAoIWZ1bmMpCisJCXJldHVybiBXQUxLX1RSRUVfT0s7CisKKwlyZXQg PSBmdW5jKGN0eCwgY29ubiwgbm9kZSwgYXJnKTsKKwlpZiAocmV0ID09IFdB TEtfVFJFRV9STV9DSElMREVOVFJZICYmIHBhcmVudCkKKwkJcmV0ID0gcm1f ZnJvbV9wYXJlbnQoY29ubiwgcGFyZW50LCBub2RlLT5uYW1lKTsKKworCXJl dHVybiByZXQ7Cit9CisKK2ludCB3YWxrX25vZGVfdHJlZShjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpy b290LAorCQkgICBzdHJ1Y3Qgd2Fsa19mdW5jcyAqZnVuY3MsIHZvaWQgKmFy ZykKK3sKKwlpbnQgcmV0ID0gMDsKKwl2b2lkICp0bXBjdHg7CisJY2hhciAq bmFtZTsKKwlzdHJ1Y3Qgbm9kZSAqbm9kZSA9IE5VTEw7CisJc3RydWN0IG5v ZGUgKnBhcmVudCA9IE5VTEw7CisKKwl0bXBjdHggPSB0YWxsb2NfbmV3KGN0 eCk7CisJaWYgKCF0bXBjdHgpIHsKKwkJZXJybm8gPSBFTk9NRU07CisJCXJl dHVybiBXQUxLX1RSRUVfRVJST1JfU1RPUDsKKwl9CisJbmFtZSA9IHRhbGxv Y19zdHJkdXAodG1wY3R4LCByb290KTsKKwlpZiAoIW5hbWUpIHsKKwkJZXJy bm8gPSBFTk9NRU07CisJCXRhbGxvY19mcmVlKHRtcGN0eCk7CisJCXJldHVy biBXQUxLX1RSRUVfRVJST1JfU1RPUDsKKwl9CisKKwkvKiBDb250aW51ZSB0 aGUgd2FsayB1bnRpbCBhbiBlcnJvciBpcyByZXR1cm5lZC4gKi8KKwl3aGls ZSAocmV0ID49IDApIHsKKwkJLyogbm9kZSA9PSBOVUxMIHBvc3NpYmxlIG9u bHkgZm9yIHRoZSBpbml0aWFsIGxvb3AgaXRlcmF0aW9uLiAqLworCQlpZiAo bm9kZSkgeworCQkJLyogR28gb25lIHN0ZXAgdXAgaWYgcmV0IG9yIGlmIGxh c3QgY2hpbGQgZmluaXNoZWQuICovCisJCQlpZiAocmV0IHx8IG5vZGUtPmNo aWxkb2ZmID49IG5vZGUtPmNoaWxkbGVuKSB7CisJCQkJcGFyZW50ID0gbm9k ZS0+cGFyZW50OworCQkJCS8qIENhbGwgZnVuY3Rpb24gQUZURVIgcHJvY2Vz c2luZyBhIG5vZGUuICovCisJCQkJcmV0ID0gd2Fsa19jYWxsX2Z1bmMoY3R4 LCBjb25uLCBub2RlLCBwYXJlbnQsCisJCQkJCQkgICAgIGFyZywgZnVuY3Mt PmV4aXQpOworCQkJCS8qIExhc3Qgbm9kZSwgc28gZXhpdCBsb29wLiAqLwor CQkJCWlmICghcGFyZW50KQorCQkJCQlicmVhazsKKwkJCQl0YWxsb2NfZnJl ZShub2RlKTsKKwkJCQkvKiBDb250aW51ZSB3aXRoIHBhcmVudC4gKi8KKwkJ CQlub2RlID0gcGFyZW50OworCQkJCWNvbnRpbnVlOworCQkJfQorCQkJLyog R2V0IG5leHQgY2hpbGQgb2YgY3VycmVudCBub2RlLiAqLworCQkJbmFtZSA9 IGNoaWxkX25hbWUodG1wY3R4LCBub2RlLT5uYW1lLAorCQkJCQkgIG5vZGUt PmNoaWxkcmVuICsgbm9kZS0+Y2hpbGRvZmYpOworCQkJaWYgKCFuYW1lKSB7 CisJCQkJcmV0ID0gV0FMS19UUkVFX0VSUk9SX1NUT1A7CisJCQkJYnJlYWs7 CisJCQl9CisJCQkvKiBQb2ludCB0byBuZXh0IGNoaWxkLiAqLworCQkJbm9k ZS0+Y2hpbGRvZmYgKz0gc3RybGVuKG5vZGUtPmNoaWxkcmVuICsKKwkJCQkJ CSBub2RlLT5jaGlsZG9mZikgKyAxOworCQkJLyogRGVzY2VudCBpbnRvIGNo aWxkcmVuLiAqLworCQkJcGFyZW50ID0gbm9kZTsKKwkJfQorCQkvKiBSZWFk IG5leHQgbm9kZSAocm9vdCBub2RlIG9yIG5leHQgY2hpbGQpLiAqLworCQlu b2RlID0gcmVhZF9ub2RlKGNvbm4sIHRtcGN0eCwgbmFtZSk7CisJCWlmICgh bm9kZSkgeworCQkJLyogQ2hpbGQgbm90IGZvdW5kIC0gc2hvdWxkIG5vdCBo YXBwZW4hICovCisJCQkvKiBFTk9FTlQgY2FzZSBjYW4gYmUgaGFuZGxlZCBi eSBzdXBwbGllZCBmdW5jdGlvbi4gKi8KKwkJCWlmIChlcnJubyA9PSBFTk9F TlQgJiYgZnVuY3MtPmVub2VudCkKKwkJCQlyZXQgPSBmdW5jcy0+ZW5vZW50 KGN0eCwgY29ubiwgcGFyZW50LCBuYW1lLAorCQkJCQkJICAgIGFyZyk7CisJ CQllbHNlCisJCQkJcmV0ID0gV0FMS19UUkVFX0VSUk9SX1NUT1A7CisJCQlp ZiAoIXBhcmVudCkKKwkJCQlicmVhazsKKwkJCWlmIChyZXQgPT0gV0FMS19U UkVFX1JNX0NISUxERU5UUlkpCisJCQkJcmV0ID0gcm1fZnJvbV9wYXJlbnQo Y29ubiwgcGFyZW50LCBuYW1lKTsKKwkJCWlmIChyZXQgPCAwKQorCQkJCWJy ZWFrOworCQkJdGFsbG9jX2ZyZWUobmFtZSk7CisJCQlub2RlID0gcGFyZW50 OworCQkJY29udGludWU7CisJCX0KKwkJdGFsbG9jX2ZyZWUobmFtZSk7CisJ CW5vZGUtPnBhcmVudCA9IHBhcmVudDsKKwkJbm9kZS0+Y2hpbGRvZmYgPSAw OworCQkvKiBDYWxsIGZ1bmN0aW9uIEJFRk9SRSBwcm9jZXNzaW5nIGEgbm9k ZS4gKi8KKwkJcmV0ID0gd2Fsa19jYWxsX2Z1bmMoY3R4LCBjb25uLCBub2Rl LCBwYXJlbnQsIGFyZywKKwkJCQkgICAgIGZ1bmNzLT5lbnRlcik7CisJfQor CisJdGFsbG9jX2ZyZWUodG1wY3R4KTsKKworCXJldHVybiByZXQgPCAwID8g cmV0IDogV0FMS19UUkVFX09LOworfQorCiBzdGF0aWMgc3RydWN0IHsKIAlj b25zdCBjaGFyICpzdHI7CiAJaW50ICgqZnVuYykoY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKQEAgLTIzMDUsMTggKzI0MzQs NiBAQCBzdGF0aWMgaW50IGtleXNfZXF1YWxfZm4odm9pZCAqa2V5MSwgdm9p ZCAqa2V5MikKIAlyZXR1cm4gMCA9PSBzdHJjbXAoKGNoYXIgKilrZXkxLCAo Y2hhciAqKWtleTIpOwogfQogCi0KLXN0YXRpYyBjaGFyICpjaGlsZF9uYW1l KGNvbnN0IGNoYXIgKnMxLCBjb25zdCBjaGFyICpzMikKLXsKLQlpZiAoc3Ry Y21wKHMxLCAiLyIpKSB7Ci0JCXJldHVybiB0YWxsb2NfYXNwcmludGYoTlVM TCwgIiVzLyVzIiwgczEsIHMyKTsKLQl9Ci0JZWxzZSB7Ci0JCXJldHVybiB0 YWxsb2NfYXNwcmludGYoTlVMTCwgIi8lcyIsIHMyKTsKLQl9Ci19Ci0KLQog aW50IHJlbWVtYmVyX3N0cmluZyhzdHJ1Y3QgaGFzaHRhYmxlICpoYXNoLCBj b25zdCBjaGFyICpzdHIpCiB7CiAJY2hhciAqayA9IG1hbGxvYyhzdHJsZW4o c3RyKSArIDEpOwpAQCAtMjM3Niw3ICsyNDkzLDcgQEAgc3RhdGljIGludCBj aGVja19zdG9yZV8oY29uc3QgY2hhciAqbmFtZSwgc3RydWN0IGhhc2h0YWJs ZSAqcmVhY2hhYmxlKQogCQl3aGlsZSAoaSA8IG5vZGUtPmNoaWxkbGVuICYm ICFyZXQpIHsKIAkJCXN0cnVjdCBub2RlICpjaGlsZG5vZGU7CiAJCQlzaXpl X3QgY2hpbGRsZW4gPSBzdHJsZW4obm9kZS0+Y2hpbGRyZW4gKyBpKTsKLQkJ CWNoYXIgKiBjaGlsZG5hbWUgPSBjaGlsZF9uYW1lKG5vZGUtPm5hbWUsCisJ CQljaGFyICogY2hpbGRuYW1lID0gY2hpbGRfbmFtZShOVUxMLCBub2RlLT5u YW1lLAogCQkJCQkJICAgICAgbm9kZS0+Y2hpbGRyZW4gKyBpKTsKIAogCQkJ aWYgKCFjaGlsZG5hbWUpIHsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5oCmluZGV4IGJmZDNmYzFlOWRmMy4uMmQ5OTQyMTcxZDkyIDEwMDY0 NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCisrKyBi L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKQEAgLTIwMiw2ICsy MDIsNyBAQCBzdHJ1Y3Qgbm9kZSB7CiAKIAkvKiBDaGlsZHJlbiwgZWFjaCBu dWwtdGVybWluYXRlZC4gKi8KIAl1bnNpZ25lZCBpbnQgY2hpbGRsZW47CisJ dW5zaWduZWQgaW50IGNoaWxkb2ZmOwkvKiBVc2VkIGJ5IHdhbGtfbm9kZV90 cmVlKCkgaW50ZXJuYWxseS4gKi8KIAljaGFyICpjaGlsZHJlbjsKIAogCS8q IEFsbG9jYXRpb24gaW5mb3JtYXRpb24gZm9yIG5vZGUgY3VycmVudGx5IGlu IHN0b3JlLiAqLwpAQCAtMzM4LDYgKzMzOSw0NSBAQCB2b2lkIHJlYWRfc3Rh dGVfYnVmZmVyZWRfZGF0YShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLAogCQkJICAgICAgY29uc3Qgc3RydWN0IHhzX3N0YXRl X2Nvbm5lY3Rpb24gKnNjKTsKIHZvaWQgcmVhZF9zdGF0ZV9ub2RlKGNvbnN0 IHZvaWQgKmN0eCwgY29uc3Qgdm9pZCAqc3RhdGUpOwogCisvKgorICogV2Fs ayB0aGUgbm9kZSB0cmVlIGJlbG93IHJvb3QgY2FsbGluZyBmdW5jcy0+ZW50 ZXIoKSBhbmQgZnVuY3MtPmV4aXQoKSBmb3IKKyAqIGVhY2ggbm9kZS4gZnVu Y3MtPmVudGVyKCkgaXMgYmVpbmcgY2FsbGVkIHdoZW4gZW50ZXJpbmcgYSBu b2RlLCBzbyBiZWZvcmUKKyAqIGFueSBvZiB0aGUgY2hpbGRyZW4gb2YgdGhl IG5vZGUgaXMgcHJvY2Vzc2VkLiBmdW5jcy0+ZXhpdCgpIGlzIGJlaW5nCisg KiBjYWxsZWQgd2hlbiBsZWF2aW5nIHRoZSBub2RlLCBzbyBhZnRlciBhbGwg Y2hpbGRyZW4gaGF2ZSBiZWVuIHByb2Nlc3NlZC4KKyAqIGZ1bmNzLT5lbm9l bnQoKSBpcyBiZWluZyBjYWxsZWQgd2hlbiBhIG5vZGUgaXNuJ3QgZXhpc3Rp bmcuCisgKiBmdW5jcy0+KigpIHJldHVybiB2YWx1ZXM6CisgKiAgPCAwOiB0 cmVlIHdhbGsgaXMgc3RvcHBlZCwgd2Fsa19ub2RlX3RyZWUoKSByZXR1cm5z IGZ1bmNzLT4qKCkgcmV0dXJuIHZhbHVlCisgKiAgICAgICBpbiBjYXNlIFdB TEtfVFJFRV9FUlJPUl9TVE9QIGlzIHJldHVybmVkLCBlcnJubyBzaG91bGQg YmUgc2V0CisgKiAgV0FMS19UUkVFX09LOiB0cmVlIHdhbGsgaXMgY29udGlu dWluZworICogIFdBTEtfVFJFRV9TS0lQX0NISUxEUkVOOiB0cmVlIHdhbGsg d29uJ3QgZGVzY2VuZCBiZWxvdyBjdXJyZW50IG5vZGUsIGJ1dAorICogICAg ICAgd2FsayBjb250aW51ZXMKKyAqICBXQUxLX1RSRUVfUk1fQ0hJTERFTlRS WTogUmVtb3ZlIHRoZSBjaGlsZCBlbnRyeSBmcm9tIGl0cyBwYXJlbnQgYW5k IHdyaXRlCisgKiAgICAgICB0aGUgbW9kaWZpZWQgcGFyZW50IG5vZGUgYmFj ayB0byB0aGUgZGF0YSBiYXNlLCBpbXBsaWVzIHRvIG5vdCBkZXNjZW5kCisg KiAgICAgICBiZWxvdyB0aGUgY3VycmVudCBub2RlLCBidXQgdG8gY29udGlu dWUgdGhlIHdhbGsKKyAqIGZ1bmNzLT4qKCkgaXMgYWxsb3dlZCB0byBtb2Rp ZnkgdGhlIG5vZGUgaXQgaXMgY2FsbGVkIGZvciBpbiB0aGUgZGF0YSBiYXNl LgorICogSW4gY2FzZSBmdW5jcy0+ZW50ZXIoKSBpcyBkZWxldGluZyB0aGUg bm9kZSwgaXQgbXVzdCBub3QgcmV0dXJuIFdBTEtfVFJFRV9PSworICogaW4g b3JkZXIgdG8gYXZvaWQgZGVzY2VuZGluZyBpbnRvIG5vIGxvbmdlciBleGlz dGluZyBjaGlsZHJlbi4KKyAqLworLyogUmV0dXJuIHZhbHVlcyBmb3IgZnVu Y3MtPiooKSBhbmQgd2Fsa19ub2RlX3RyZWUoKS4gKi8KKyNkZWZpbmUgV0FM S19UUkVFX1NVQ0NFU1NfU1RPUCAgLTEwMCAgICAvKiBTdG9wIHdhbGsgZWFy bHksIG5vIGVycm9yLiAqLworI2RlZmluZSBXQUxLX1RSRUVfRVJST1JfU1RP UCAgICAtMSAgICAgIC8qIFN0b3Agd2FsayBkdWUgdG8gZXJyb3IuICovCisj ZGVmaW5lIFdBTEtfVFJFRV9PSyAgICAgICAgICAgIDAgICAgICAgLyogTm8g ZXJyb3IuICovCisvKiBSZXR1cm4gdmFsdWUgZm9yIGZ1bmNzLT4qKCkgb25s eS4gKi8KKyNkZWZpbmUgV0FMS19UUkVFX1NLSVBfQ0hJTERSRU4gMSAgICAg ICAvKiBEb24ndCByZWN1cnNlIGJlbG93IGN1cnJlbnQgbm9kZS4gKi8KKyNk ZWZpbmUgV0FMS19UUkVFX1JNX0NISUxERU5UUlkgMiAgICAgICAvKiBSZW1v dmUgY2hpbGQgZW50cnkgZnJvbSBwYXJlbnQuICovCisKK3N0cnVjdCB3YWxr X2Z1bmNzIHsKKwlpbnQgKCplbnRlcikoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICAgICBzdHJ1Y3Qgbm9kZSAqbm9k ZSwgdm9pZCAqYXJnKTsKKwlpbnQgKCpleGl0KShjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgICAgc3RydWN0IG5vZGUg Km5vZGUsIHZvaWQgKmFyZyk7CisJaW50ICgqZW5vZW50KShjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgICAgICBzdHJ1 Y3Qgbm9kZSAqcGFyZW50LCBjaGFyICpuYW1lLCB2b2lkICphcmcpOworfTsK KworaW50IHdhbGtfbm9kZV90cmVlKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IGNoYXIgKnJvb3QsCisJCSAgIHN0 cnVjdCB3YWxrX2Z1bmNzICpmdW5jcywgdm9pZCAqYXJnKTsKKwogI2VuZGlm IC8qIF9YRU5TVE9SRURfQ09SRV9IICovCiAKIC8qCg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.16-04.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.16-04.patch" Content-Transfer-Encoding: base64 RnJvbSBiZGM5MzFmYjVkY2ViYmQ4ZDBlNDRiNWQ4YmQzZmI5MTA2ZWU4NTk2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHNpbXBsaWZ5 IGNoZWNrX3N0b3JlKCkKCmNoZWNrX3N0b3JlKCkgaXMgdXNpbmcgYSBoYXNo IHRhYmxlIGZvciBzdG9yaW5nIGFsbCBub2RlIG5hbWVzIGl0IGhhcwpmb3Vu ZCB2aWEgd2Fsa2luZyB0aGUgdHJlZS4gQWRkaXRpb25hbGx5IGl0IHVzaW5n IGFub3RoZXIgaGFzaCB0YWJsZQpmb3IgYWxsIGNoaWxkcmVuIG9mIGEgbm9k ZSB0byBkZXRlY3QgZHVwbGljYXRlIGNoaWxkIG5hbWVzLgoKU2ltcGxpZnkg dGhhdCBieSBkcm9wcGluZyB0aGUgc2Vjb25kIGhhc2ggdGFibGUgYXMgdGhl IGZpcnN0IG9uZSBpcwphbHJlYWR5IGhvbGRpbmcgYWxsIHRoZSBuZWVkZWQg aW5mb3JtYXRpb24uCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQxOCAvIENWRS0y MDIyLTQyMzIxLgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8ZHZyYWJl bEBhbWF6b24uY28udWs+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3Mg PGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmMKaW5kZXggMmNkYTNlZTM3NWFiLi43NjBmM2MxNmM3OTQgMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtMjQ3Nyw1 MCArMjQ3NywzNCBAQCBzdGF0aWMgaW50IGNoZWNrX3N0b3JlXyhjb25zdCBj aGFyICpuYW1lLCBzdHJ1Y3QgaGFzaHRhYmxlICpyZWFjaGFibGUpCiAJaWYg KG5vZGUpIHsKIAkJc2l6ZV90IGkgPSAwOwogCi0JCXN0cnVjdCBoYXNodGFi bGUgKiBjaGlsZHJlbiA9Ci0JCQljcmVhdGVfaGFzaHRhYmxlKDE2LCBoYXNo X2Zyb21fa2V5X2ZuLCBrZXlzX2VxdWFsX2ZuKTsKLQkJaWYgKCFjaGlsZHJl bikgewotCQkJbG9nKCJjaGVja19zdG9yZSBjcmVhdGUgdGFibGU6IEVOT01F TSIpOwotCQkJcmV0dXJuIEVOT01FTTsKLQkJfQotCiAJCWlmICghcmVtZW1i ZXJfc3RyaW5nKHJlYWNoYWJsZSwgbmFtZSkpIHsKLQkJCWhhc2h0YWJsZV9k ZXN0cm95KGNoaWxkcmVuLCAwKTsKIAkJCWxvZygiY2hlY2tfc3RvcmU6IEVO T01FTSIpOwogCQkJcmV0dXJuIEVOT01FTTsKIAkJfQogCiAJCXdoaWxlIChp IDwgbm9kZS0+Y2hpbGRsZW4gJiYgIXJldCkgewotCQkJc3RydWN0IG5vZGUg KmNoaWxkbm9kZTsKKwkJCXN0cnVjdCBub2RlICpjaGlsZG5vZGUgPSBOVUxM OwogCQkJc2l6ZV90IGNoaWxkbGVuID0gc3RybGVuKG5vZGUtPmNoaWxkcmVu ICsgaSk7Ci0JCQljaGFyICogY2hpbGRuYW1lID0gY2hpbGRfbmFtZShOVUxM LCBub2RlLT5uYW1lLAotCQkJCQkJICAgICAgbm9kZS0+Y2hpbGRyZW4gKyBp KTsKKwkJCWNoYXIgKmNoaWxkbmFtZSA9IGNoaWxkX25hbWUoTlVMTCwgbm9k ZS0+bmFtZSwKKwkJCQkJCSAgICAgbm9kZS0+Y2hpbGRyZW4gKyBpKTsKIAog CQkJaWYgKCFjaGlsZG5hbWUpIHsKIAkJCQlsb2coImNoZWNrX3N0b3JlOiBF Tk9NRU0iKTsKIAkJCQlyZXQgPSBFTk9NRU07CiAJCQkJYnJlYWs7CiAJCQl9 CisKKwkJCWlmIChoYXNodGFibGVfc2VhcmNoKHJlYWNoYWJsZSwgY2hpbGRu YW1lKSkgeworCQkJCWxvZygiY2hlY2tfc3RvcmU6ICclcycgaXMgZHVwbGlj YXRlZCEiLAorCQkJCSAgICBjaGlsZG5hbWUpOworCQkJCWkgPSBybV9jaGls ZF9lbnRyeShub2RlLCBpLCBjaGlsZGxlbik7CisJCQkJZ290byBuZXh0Owor CQkJfQorCiAJCQljaGlsZG5vZGUgPSByZWFkX25vZGUoTlVMTCwgY2hpbGRu YW1lLCBjaGlsZG5hbWUpOwotCQkJCisKIAkJCWlmIChjaGlsZG5vZGUpIHsK LQkJCQlpZiAoaGFzaHRhYmxlX3NlYXJjaChjaGlsZHJlbiwgY2hpbGRuYW1l KSkgewotCQkJCQlsb2coImNoZWNrX3N0b3JlOiAnJXMnIGlzIGR1cGxpY2F0 ZWQhIiwKLQkJCQkJICAgIGNoaWxkbmFtZSk7Ci0JCQkJCWkgPSBybV9jaGls ZF9lbnRyeShub2RlLCBpLCBjaGlsZGxlbik7Ci0JCQkJfQotCQkJCWVsc2Ug ewotCQkJCQlpZiAoIXJlbWVtYmVyX3N0cmluZyhjaGlsZHJlbiwKLQkJCQkJ CQkgICAgIGNoaWxkbmFtZSkpIHsKLQkJCQkJCWxvZygiY2hlY2tfc3RvcmU6 IEVOT01FTSIpOwotCQkJCQkJdGFsbG9jX2ZyZWUoY2hpbGRub2RlKTsKLQkJ CQkJCXRhbGxvY19mcmVlKGNoaWxkbmFtZSk7Ci0JCQkJCQlyZXQgPSBFTk9N RU07Ci0JCQkJCQlicmVhazsKLQkJCQkJfQotCQkJCQlyZXQgPSBjaGVja19z dG9yZV8oY2hpbGRuYW1lLAotCQkJCQkJCSAgIHJlYWNoYWJsZSk7Ci0JCQkJ fQorCQkJCXJldCA9IGNoZWNrX3N0b3JlXyhjaGlsZG5hbWUsIHJlYWNoYWJs ZSk7CiAJCQl9IGVsc2UgaWYgKGVycm5vICE9IEVOT01FTSkgewogCQkJCWxv ZygiY2hlY2tfc3RvcmU6IE5vIGNoaWxkICclcycgZm91bmQhXG4iLAogCQkJ CSAgICBjaGlsZG5hbWUpOwpAQCAtMjUzMCwxOSArMjUxNCwxOCBAQCBzdGF0 aWMgaW50IGNoZWNrX3N0b3JlXyhjb25zdCBjaGFyICpuYW1lLCBzdHJ1Y3Qg aGFzaHRhYmxlICpyZWFjaGFibGUpCiAJCQkJcmV0ID0gRU5PTUVNOwogCQkJ fQogCisgbmV4dDoKIAkJCXRhbGxvY19mcmVlKGNoaWxkbm9kZSk7CiAJCQl0 YWxsb2NfZnJlZShjaGlsZG5hbWUpOwogCQkJaSArPSBjaGlsZGxlbiArIDE7 CiAJCX0KIAotCQloYXNodGFibGVfZGVzdHJveShjaGlsZHJlbiwgMCAvKiBE b24ndCBmcmVlIHZhbHVlcyAodGhleSBhcmUKLQkJCQkJCSBhbGwgKHZvaWQg KikxKSAqLyk7CiAJCXRhbGxvY19mcmVlKG5vZGUpOwogCX0gZWxzZSBpZiAo ZXJybm8gIT0gRU5PTUVNKSB7CiAJCS8qIEltcG9zc2libGUsIGJlY2F1c2Ug bm8gZGF0YWJhc2Ugc2hvdWxkIGV2ZXIgYmUgd2l0aG91dCB0aGUKIAkJICAg cm9vdCwgYW5kIG90aGVyd2lzZSwgd2UndmUganVzdCBjaGVja2VkIGluIG91 ciBjYWxsZXIKIAkJICAgKHdoaWNoIG1hZGUgYSByZWN1cnNpdmUgY2FsbCB0 byBnZXQgaGVyZSkuICovCi0JCSAgIAorCiAJCWxvZygiY2hlY2tfc3RvcmU6 IE5vIGNoaWxkICclcycgZm91bmQ6IGltcG9zc2libGUhIiwgbmFtZSk7CiAJ fSBlbHNlIHsKIAkJbG9nKCJjaGVja19zdG9yZTogRU5PTUVNIik7Cg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.16-05.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.16-05.patch" Content-Transfer-Encoding: base64 RnJvbSAyNzgxN2YwYTdkNjgwMmJlMDRlOGY0M2EwOTAwYjAyZjg4MWIyOGIy IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHVzZSB0cmVl d2FsayBmb3IgY2hlY2tfc3RvcmUoKQoKSW5zdGVhZCBvZiBkb2luZyBhbiBv cGVuIHRyZWUgd2FsayB1c2luZyBjYWxsIHJlY3Vyc2lvbiwgdXNlCndhbGtf bm9kZV90cmVlKCkgd2hlbiBjaGVja2luZyB0aGUgc3RvcmUgZm9yIGluY29u c2lzdGVuY2llcy4KClRoaXMgd2lsbCByZWR1Y2UgY29kZSBzaXplIGFuZCBh dm9pZCBtYW55IG5lc3RpbmcgbGV2ZWxzIG9mIGZ1bmN0aW9uCmNhbGxzIHdo aWNoIGNvdWxkIHBvdGVudGlhbGx5IGV4aGF1c3QgdGhlIHN0YWNrLgoKVGhp cyBpcyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9y dGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpT aWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ ClJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29t PgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IDc2 MGYzYzE2Yzc5NC4uZWZkZDE4ODhmZDc4IDEwMDY0NAotLS0gYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMKQEAgLTI0NDQsMTggKzI0NDQsNiBAQCBpbnQg cmVtZW1iZXJfc3RyaW5nKHN0cnVjdCBoYXNodGFibGUgKmhhc2gsIGNvbnN0 IGNoYXIgKnN0cikKIAlyZXR1cm4gaGFzaHRhYmxlX2luc2VydChoYXNoLCBr LCAodm9pZCAqKTEpOwogfQogCi1zdGF0aWMgaW50IHJtX2NoaWxkX2VudHJ5 KHN0cnVjdCBub2RlICpub2RlLCBzaXplX3Qgb2ZmLCBzaXplX3QgbGVuKQot ewotCWlmICghcmVjb3ZlcnkpCi0JCXJldHVybiBvZmY7Ci0KLQlpZiAocmVt b3ZlX2NoaWxkX2VudHJ5KE5VTEwsIG5vZGUsIG9mZikpCi0JCWxvZygiY2hl Y2tfc3RvcmU6IGNoaWxkIGVudHJ5IGNvdWxkIG5vdCBiZSByZW1vdmVkIGZy b20gJyVzJyIsCi0JCSAgICBub2RlLT5uYW1lKTsKLQotCXJldHVybiBvZmYg LSBsZW4gLSAxOwotfQotCiAvKioKICAqIEEgbm9kZSBoYXMgYSBjaGlsZHJl biBmaWVsZCB0aGF0IG5hbWVzIHRoZSBjaGlsZHJlbiBvZiB0aGUgbm9kZSwg c2VwYXJhdGVkCiAgKiBieSBOVUxzLiAgV2UgY2hlY2sgd2hldGhlciB0aGVy ZSBhcmUgZW50cmllcyBpbiB0aGVyZSB0aGF0IGFyZSBkdXBsaWNhdGVkCkBA IC0yNDY5LDcwICsyNDU3LDI5IEBAIHN0YXRpYyBpbnQgcm1fY2hpbGRfZW50 cnkoc3RydWN0IG5vZGUgKm5vZGUsIHNpemVfdCBvZmYsIHNpemVfdCBsZW4p CiAgKiBBcyB3ZSBnbywgd2UgcmVjb3JkIGVhY2ggbm9kZSBpbiB0aGUgZ2l2 ZW4gcmVhY2hhYmxlIGhhc2h0YWJsZS4gIFRoZXNlCiAgKiBlbnRyaWVzIHdp bGwgYmUgdXNlZCBsYXRlciBpbiBjbGVhbl9zdG9yZS4KICAqLwotc3RhdGlj IGludCBjaGVja19zdG9yZV8oY29uc3QgY2hhciAqbmFtZSwgc3RydWN0IGhh c2h0YWJsZSAqcmVhY2hhYmxlKQorc3RhdGljIGludCBjaGVja19zdG9yZV9z dGVwKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s CisJCQkgICAgc3RydWN0IG5vZGUgKm5vZGUsIHZvaWQgKmFyZykKIHsKLQlz dHJ1Y3Qgbm9kZSAqbm9kZSA9IHJlYWRfbm9kZShOVUxMLCBuYW1lLCBuYW1l KTsKLQlpbnQgcmV0ID0gMDsKLQotCWlmIChub2RlKSB7Ci0JCXNpemVfdCBp ID0gMDsKLQotCQlpZiAoIXJlbWVtYmVyX3N0cmluZyhyZWFjaGFibGUsIG5h bWUpKSB7Ci0JCQlsb2coImNoZWNrX3N0b3JlOiBFTk9NRU0iKTsKLQkJCXJl dHVybiBFTk9NRU07Ci0JCX0KLQotCQl3aGlsZSAoaSA8IG5vZGUtPmNoaWxk bGVuICYmICFyZXQpIHsKLQkJCXN0cnVjdCBub2RlICpjaGlsZG5vZGUgPSBO VUxMOwotCQkJc2l6ZV90IGNoaWxkbGVuID0gc3RybGVuKG5vZGUtPmNoaWxk cmVuICsgaSk7Ci0JCQljaGFyICpjaGlsZG5hbWUgPSBjaGlsZF9uYW1lKE5V TEwsIG5vZGUtPm5hbWUsCi0JCQkJCQkgICAgIG5vZGUtPmNoaWxkcmVuICsg aSk7Ci0KLQkJCWlmICghY2hpbGRuYW1lKSB7Ci0JCQkJbG9nKCJjaGVja19z dG9yZTogRU5PTUVNIik7Ci0JCQkJcmV0ID0gRU5PTUVNOwotCQkJCWJyZWFr OwotCQkJfQorCXN0cnVjdCBoYXNodGFibGUgKnJlYWNoYWJsZSA9IGFyZzsK IAotCQkJaWYgKGhhc2h0YWJsZV9zZWFyY2gocmVhY2hhYmxlLCBjaGlsZG5h bWUpKSB7Ci0JCQkJbG9nKCJjaGVja19zdG9yZTogJyVzJyBpcyBkdXBsaWNh dGVkISIsCi0JCQkJICAgIGNoaWxkbmFtZSk7Ci0JCQkJaSA9IHJtX2NoaWxk X2VudHJ5KG5vZGUsIGksIGNoaWxkbGVuKTsKLQkJCQlnb3RvIG5leHQ7Ci0J CQl9Ci0KLQkJCWNoaWxkbm9kZSA9IHJlYWRfbm9kZShOVUxMLCBjaGlsZG5h bWUsIGNoaWxkbmFtZSk7Ci0KLQkJCWlmIChjaGlsZG5vZGUpIHsKLQkJCQly ZXQgPSBjaGVja19zdG9yZV8oY2hpbGRuYW1lLCByZWFjaGFibGUpOwotCQkJ fSBlbHNlIGlmIChlcnJubyAhPSBFTk9NRU0pIHsKLQkJCQlsb2coImNoZWNr X3N0b3JlOiBObyBjaGlsZCAnJXMnIGZvdW5kIVxuIiwKLQkJCQkgICAgY2hp bGRuYW1lKTsKLQkJCQlpID0gcm1fY2hpbGRfZW50cnkobm9kZSwgaSwgY2hp bGRsZW4pOwotCQkJfSBlbHNlIHsKLQkJCQlsb2coImNoZWNrX3N0b3JlOiBF Tk9NRU0iKTsKLQkJCQlyZXQgPSBFTk9NRU07Ci0JCQl9CisJaWYgKGhhc2h0 YWJsZV9zZWFyY2gocmVhY2hhYmxlLCAodm9pZCAqKW5vZGUtPm5hbWUpKSB7 CisJCWxvZygiY2hlY2tfc3RvcmU6ICclcycgaXMgZHVwbGljYXRlZCEiLCBu b2RlLT5uYW1lKTsKKwkJcmV0dXJuIHJlY292ZXJ5ID8gV0FMS19UUkVFX1JN X0NISUxERU5UUlkKKwkJCQk6IFdBTEtfVFJFRV9TS0lQX0NISUxEUkVOOwor CX0KIAotIG5leHQ6Ci0JCQl0YWxsb2NfZnJlZShjaGlsZG5vZGUpOwotCQkJ dGFsbG9jX2ZyZWUoY2hpbGRuYW1lKTsKLQkJCWkgKz0gY2hpbGRsZW4gKyAx OwotCQl9CisJaWYgKCFyZW1lbWJlcl9zdHJpbmcocmVhY2hhYmxlLCBub2Rl LT5uYW1lKSkKKwkJcmV0dXJuIFdBTEtfVFJFRV9FUlJPUl9TVE9QOwogCi0J CXRhbGxvY19mcmVlKG5vZGUpOwotCX0gZWxzZSBpZiAoZXJybm8gIT0gRU5P TUVNKSB7Ci0JCS8qIEltcG9zc2libGUsIGJlY2F1c2Ugbm8gZGF0YWJhc2Ug c2hvdWxkIGV2ZXIgYmUgd2l0aG91dCB0aGUKLQkJICAgcm9vdCwgYW5kIG90 aGVyd2lzZSwgd2UndmUganVzdCBjaGVja2VkIGluIG91ciBjYWxsZXIKLQkJ ICAgKHdoaWNoIG1hZGUgYSByZWN1cnNpdmUgY2FsbCB0byBnZXQgaGVyZSku ICovCisJcmV0dXJuIFdBTEtfVFJFRV9PSzsKK30KIAotCQlsb2coImNoZWNr X3N0b3JlOiBObyBjaGlsZCAnJXMnIGZvdW5kOiBpbXBvc3NpYmxlISIsIG5h bWUpOwotCX0gZWxzZSB7Ci0JCWxvZygiY2hlY2tfc3RvcmU6IEVOT01FTSIp OwotCQlyZXQgPSBFTk9NRU07Ci0JfQorc3RhdGljIGludCBjaGVja19zdG9y ZV9lbm9lbnQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwKKwkJCSAgICAgIHN0cnVjdCBub2RlICpwYXJlbnQsIGNoYXIgKm5h bWUsIHZvaWQgKmFyZykKK3sKKwlsb2coImNoZWNrX3N0b3JlOiBub2RlICcl cycgbm90IGZvdW5kIiwgbmFtZSk7CiAKLQlyZXR1cm4gcmV0OworCXJldHVy biByZWNvdmVyeSA/IFdBTEtfVFJFRV9STV9DSElMREVOVFJZIDogV0FMS19U UkVFX09LOwogfQogCiAKQEAgLTI1ODEsMjQgKzI1MjgsMjggQEAgc3RhdGlj IHZvaWQgY2xlYW5fc3RvcmUoc3RydWN0IGhhc2h0YWJsZSAqcmVhY2hhYmxl KQogCiB2b2lkIGNoZWNrX3N0b3JlKHZvaWQpCiB7Ci0JY2hhciAqIHJvb3Qg PSB0YWxsb2Nfc3RyZHVwKE5VTEwsICIvIik7Ci0Jc3RydWN0IGhhc2h0YWJs ZSAqIHJlYWNoYWJsZSA9Ci0JCWNyZWF0ZV9oYXNodGFibGUoMTYsIGhhc2hf ZnJvbV9rZXlfZm4sIGtleXNfZXF1YWxfZm4pOwotIAorCXN0cnVjdCBoYXNo dGFibGUgKnJlYWNoYWJsZTsKKwlzdHJ1Y3Qgd2Fsa19mdW5jcyB3YWxrZnVu Y3MgPSB7CisJCS5lbnRlciA9IGNoZWNrX3N0b3JlX3N0ZXAsCisJCS5lbm9l bnQgPSBjaGVja19zdG9yZV9lbm9lbnQsCisJfTsKKworCXJlYWNoYWJsZSA9 IGNyZWF0ZV9oYXNodGFibGUoMTYsIGhhc2hfZnJvbV9rZXlfZm4sIGtleXNf ZXF1YWxfZm4pOwogCWlmICghcmVhY2hhYmxlKSB7CiAJCWxvZygiY2hlY2tf c3RvcmU6IEVOT01FTSIpOwogCQlyZXR1cm47CiAJfQogCiAJbG9nKCJDaGVj a2luZyBzdG9yZSAuLi4iKTsKLQlpZiAoIWNoZWNrX3N0b3JlXyhyb290LCBy ZWFjaGFibGUpICYmCi0JICAgICFjaGVja190cmFuc2FjdGlvbnMocmVhY2hh YmxlKSkKKwlpZiAod2Fsa19ub2RlX3RyZWUoTlVMTCwgTlVMTCwgIi8iLCAm d2Fsa2Z1bmNzLCByZWFjaGFibGUpKSB7CisJCWlmIChlcnJubyA9PSBFTk9N RU0pCisJCQlsb2coImNoZWNrX3N0b3JlOiBFTk9NRU0iKTsKKwl9IGVsc2Ug aWYgKCFjaGVja190cmFuc2FjdGlvbnMocmVhY2hhYmxlKSkKIAkJY2xlYW5f c3RvcmUocmVhY2hhYmxlKTsKIAlsb2coIkNoZWNraW5nIHN0b3JlIGNvbXBs ZXRlLiIpOwogCiAJaGFzaHRhYmxlX2Rlc3Ryb3kocmVhY2hhYmxlLCAwIC8q IERvbid0IGZyZWUgdmFsdWVzICh0aGV5IGFyZSBhbGwKIAkJCQkJICAodm9p ZCAqKTEpICovKTsKLQl0YWxsb2NfZnJlZShyb290KTsKIH0KIAogCg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.16-06.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.16-06.patch" Content-Transfer-Encoding: base64 RnJvbSA2ZWEwZmZiZDg4YjExZjIzNzc5ZDc2MzUwMWVjMTM3MGI1OTBiYjJh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHVzZSB0cmVl d2FsayBmb3IgZGVsZXRpbmcgbm9kZXMKCkluc3RlYWQgb2YgZG9pbmcgYW4g b3BlbiB0cmVlIHdhbGsgdXNpbmcgY2FsbCByZWN1cnNpb24sIHVzZQp3YWxr X25vZGVfdHJlZSgpIHdoZW4gZGVsZXRpbmcgYSBzdWItdHJlZSBvZiBub2Rl cy4KClRoaXMgd2lsbCByZWR1Y2UgY29kZSBzaXplIGFuZCBhdm9pZCBtYW55 IG5lc3RpbmcgbGV2ZWxzIG9mIGZ1bmN0aW9uCmNhbGxzIHdoaWNoIGNvdWxk IHBvdGVudGlhbGx5IGV4aGF1c3QgdGhlIHN0YWNrLgoKVGhpcyBpcyBwYXJ0 IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9ydGVkLWJ5OiBK dWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpTaWduZWQtb2Zm LWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+CkFja2VkLWJ5 OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdp dCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IGVmZGQxODg4ZmQ3OC4u NThmYjY1MTU0MmVjIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMKQEAgLTEzMzQsMjEgKzEzMzQsNiBAQCBzdGF0aWMgaW50IGRvX3Jl YWQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwK IAlyZXR1cm4gMDsKIH0KIAotc3RhdGljIHZvaWQgZGVsZXRlX25vZGVfc2lu Z2xlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9k ZSkKLXsKLQlUREJfREFUQSBrZXk7Ci0KLQlpZiAoYWNjZXNzX25vZGUoY29u biwgbm9kZSwgTk9ERV9BQ0NFU1NfREVMRVRFLCAma2V5KSkKLQkJcmV0dXJu OwotCi0JaWYgKGRvX3RkYl9kZWxldGUoY29ubiwgJmtleSwgJm5vZGUtPmFj YykgIT0gMCkgewotCQljb3JydXB0KGNvbm4sICJDb3VsZCBub3QgZGVsZXRl ICclcyciLCBub2RlLT5uYW1lKTsKLQkJcmV0dXJuOwotCX0KLQotCWRvbWFp bl9lbnRyeV9kZWMoY29ubiwgbm9kZSk7Ci19Ci0KIC8qIE11c3Qgbm90IGJl IC8gKi8KIHN0YXRpYyBjaGFyICpiYXNlbmFtZShjb25zdCBjaGFyICpuYW1l KQogewpAQCAtMTYxOSw2OSArMTYwNCw1OSBAQCBzdGF0aWMgaW50IHJlbW92 ZV9jaGlsZF9lbnRyeShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0 IG5vZGUgKm5vZGUsCiAJcmV0dXJuIHdyaXRlX25vZGUoY29ubiwgbm9kZSwg dHJ1ZSk7CiB9CiAKLXN0YXRpYyB2b2lkIGRlbGV0ZV9jaGlsZChzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKLQkJCSBzdHJ1Y3Qgbm9kZSAqbm9kZSwgY29u c3QgY2hhciAqY2hpbGRuYW1lKQorc3RhdGljIGludCBkZWxldGVfY2hpbGQo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCQlzdHJ1Y3Qgbm9kZSAqbm9k ZSwgY29uc3QgY2hhciAqY2hpbGRuYW1lKQogewogCXVuc2lnbmVkIGludCBp OwogCiAJZm9yIChpID0gMDsgaSA8IG5vZGUtPmNoaWxkbGVuOyBpICs9IHN0 cmxlbihub2RlLT5jaGlsZHJlbitpKSArIDEpIHsKIAkJaWYgKHN0cmVxKG5v ZGUtPmNoaWxkcmVuK2ksIGNoaWxkbmFtZSkpIHsKLQkJCWlmIChyZW1vdmVf Y2hpbGRfZW50cnkoY29ubiwgbm9kZSwgaSkpCi0JCQkJY29ycnVwdChjb25u LCAiQ2FuJ3QgdXBkYXRlIHBhcmVudCBub2RlICclcyciLAotCQkJCQlub2Rl LT5uYW1lKTsKLQkJCXJldHVybjsKKwkJCWVycm5vID0gcmVtb3ZlX2NoaWxk X2VudHJ5KGNvbm4sIG5vZGUsIGkpID8gRUlPIDogMDsKKwkJCXJldHVybiBl cnJubzsKIAkJfQogCX0KIAljb3JydXB0KGNvbm4sICJDYW4ndCBmaW5kIGNo aWxkICclcycgaW4gJXMiLCBjaGlsZG5hbWUsIG5vZGUtPm5hbWUpOworCisJ ZXJybm8gPSBFSU87CisJcmV0dXJuIGVycm5vOwogfQogCi1zdGF0aWMgaW50 IGRlbGV0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2 b2lkICpjdHgsCi0JCSAgICAgICBzdHJ1Y3Qgbm9kZSAqcGFyZW50LCBzdHJ1 Y3Qgbm9kZSAqbm9kZSwgYm9vbCB3YXRjaF9leGFjdCkKK3N0YXRpYyBpbnQg ZGVsbm9kZV9zdWIoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwKKwkJICAgICAgIHN0cnVjdCBub2RlICpub2RlLCB2b2lkICph cmcpCiB7Ci0JY2hhciAqbmFtZTsKKwljb25zdCBjaGFyICpyb290ID0gYXJn OworCWJvb2wgd2F0Y2hfZXhhY3Q7CisJaW50IHJldDsKKwlUREJfREFUQSBr ZXk7CiAKLQkvKiBEZWxldGUgY2hpbGRyZW4uICovCi0Jd2hpbGUgKG5vZGUt PmNoaWxkbGVuKSB7Ci0JCXN0cnVjdCBub2RlICpjaGlsZDsKKwkvKiBBbnkg ZXJyb3IgaGVyZSB3aWxsIHByb2JhYmx5IGJlIHJlcGVhdGVkIGZvciBhbGwg Zm9sbG93aW5nIGNhbGxzLiAqLworCXJldCA9IGFjY2Vzc19ub2RlKGNvbm4s IG5vZGUsIE5PREVfQUNDRVNTX0RFTEVURSwgJmtleSk7CisJaWYgKHJldCA+ IDApCisJCXJldHVybiBXQUxLX1RSRUVfU1VDQ0VTU19TVE9QOwogCi0JCW5h bWUgPSB0YWxsb2NfYXNwcmludGYobm9kZSwgIiVzLyVzIiwgbm9kZS0+bmFt ZSwKLQkJCQkgICAgICAgbm9kZS0+Y2hpbGRyZW4pOwotCQljaGlsZCA9IG5h bWUgPyByZWFkX25vZGUoY29ubiwgbm9kZSwgbmFtZSkgOiBOVUxMOwotCQlp ZiAoY2hpbGQpIHsKLQkJCWlmIChkZWxldGVfbm9kZShjb25uLCBjdHgsIG5v ZGUsIGNoaWxkLCB0cnVlKSkKLQkJCQlyZXR1cm4gZXJybm87Ci0JCX0gZWxz ZSB7Ci0JCQl0cmFjZSgiZGVsZXRlX25vZGU6IEVycm9yIGRlbGV0aW5nIGNo aWxkICclcy8lcychXG4iLAotCQkJICAgICAgbm9kZS0+bmFtZSwgbm9kZS0+ Y2hpbGRyZW4pOwotCQkJLyogUXVpdCBkZWxldGluZy4gKi8KLQkJCWVycm5v ID0gRU5PTUVNOwotCQkJcmV0dXJuIGVycm5vOwotCQl9Ci0JCXRhbGxvY19m cmVlKG5hbWUpOwotCX0KKwkvKiBJbiBjYXNlIG9mIGVycm9yIHN0b3AgdGhl IHdhbGsuICovCisJaWYgKCFyZXQgJiYgZG9fdGRiX2RlbGV0ZShjb25uLCAm a2V5LCAmbm9kZS0+YWNjKSkKKwkJcmV0dXJuIFdBTEtfVFJFRV9TVUNDRVNT X1NUT1A7CiAKIAkvKgogCSAqIEZpcmUgdGhlIHdhdGNoZXMgbm93LCB3aGVu IHdlIGNhbiBzdGlsbCBzZWUgdGhlIG5vZGUgcGVybWlzc2lvbnMuCiAJICog VGhpcyBmaW5lIGFzIHdlIGFyZSBzaW5nbGUgdGhyZWFkZWQgYW5kIHRoZSBu ZXh0IHBvc3NpYmxlIHJlYWQgd2lsbAogCSAqIGJlIGhhbmRsZWQgb25seSBh ZnRlciB0aGUgbm9kZSBoYXMgYmVlbiByZWFsbHkgcmVtb3ZlZC4KLQkgKi8K KwkqLworCXdhdGNoX2V4YWN0ID0gc3RyY21wKHJvb3QsIG5vZGUtPm5hbWUp OwogCWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5vZGUtPm5hbWUsIG5vZGUs IHdhdGNoX2V4YWN0LCBOVUxMKTsKLQlkZWxldGVfbm9kZV9zaW5nbGUoY29u biwgbm9kZSk7Ci0JZGVsZXRlX2NoaWxkKGNvbm4sIHBhcmVudCwgYmFzZW5h bWUobm9kZS0+bmFtZSkpOwotCXRhbGxvY19mcmVlKG5vZGUpOwogCi0JcmV0 dXJuIDA7CisJZG9tYWluX2VudHJ5X2RlYyhjb25uLCBub2RlKTsKKworCXJl dHVybiBXQUxLX1RSRUVfUk1fQ0hJTERFTlRSWTsKIH0KIAotc3RhdGljIGlu dCBfcm0oc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0 eCwgc3RydWN0IG5vZGUgKm5vZGUsCi0JICAgICAgIGNvbnN0IGNoYXIgKm5h bWUpCitzdGF0aWMgaW50IF9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3Qgdm9pZCAqY3R4LCBjb25zdCBjaGFyICpuYW1lKQogewotCS8qCi0J ICogRGVsZXRpbmcgbm9kZSBieSBub2RlLCBzbyB0aGUgcmVzdWx0IGlzIGFs d2F5cyBjb25zaXN0ZW50IGV2ZW4gaW4KLQkgKiBjYXNlIG9mIGEgZmFpbHVy ZS4KLQkgKi8KIAlzdHJ1Y3Qgbm9kZSAqcGFyZW50OwogCWNoYXIgKnBhcmVu dG5hbWUgPSBnZXRfcGFyZW50KGN0eCwgbmFtZSk7CisJc3RydWN0IHdhbGtf ZnVuY3Mgd2Fsa2Z1bmNzID0geyAuZXhpdCA9IGRlbG5vZGVfc3ViIH07CisJ aW50IHJldDsKIAogCWlmICghcGFyZW50bmFtZSkKIAkJcmV0dXJuIGVycm5v OwpAQCAtMTY4OSw5ICsxNjY0LDIxIEBAIHN0YXRpYyBpbnQgX3JtKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBu b2RlICpub2RlLAogCXBhcmVudCA9IHJlYWRfbm9kZShjb25uLCBjdHgsIHBh cmVudG5hbWUpOwogCWlmICghcGFyZW50KQogCQlyZXR1cm4gcmVhZF9ub2Rl X2Nhbl9wcm9wYWdhdGVfZXJybm8oKSA/IGVycm5vIDogRUlOVkFMOwotCW5v ZGUtPnBhcmVudCA9IHBhcmVudDsKIAotCXJldHVybiBkZWxldGVfbm9kZShj b25uLCBjdHgsIHBhcmVudCwgbm9kZSwgZmFsc2UpOworCXJldCA9IHdhbGtf bm9kZV90cmVlKGN0eCwgY29ubiwgbmFtZSwgJndhbGtmdW5jcywgKHZvaWQg KiluYW1lKTsKKwlpZiAocmV0IDwgMCkgeworCQlpZiAocmV0ID09IFdBTEtf VFJFRV9FUlJPUl9TVE9QKSB7CisJCQljb3JydXB0KGNvbm4sICJlcnJvciB3 aGVuIGRlbGV0aW5nIHN1Yi1ub2RlcyBvZiAlc1xuIiwKKwkJCQluYW1lKTsK KwkJCWVycm5vID0gRUlPOworCQl9CisJCXJldHVybiBlcnJubzsKKwl9CisK KwlpZiAoZGVsZXRlX2NoaWxkKGNvbm4sIHBhcmVudCwgYmFzZW5hbWUobmFt ZSkpKQorCQlyZXR1cm4gZXJybm87CisKKwlyZXR1cm4gMDsKIH0KIAogCkBA IC0xNzI4LDcgKzE3MTUsNyBAQCBzdGF0aWMgaW50IGRvX3JtKGNvbnN0IHZv aWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJaWYgKHN0cmVx KG5hbWUsICIvIikpCiAJCXJldHVybiBFSU5WQUw7CiAKLQlyZXQgPSBfcm0o Y29ubiwgY3R4LCBub2RlLCBuYW1lKTsKKwlyZXQgPSBfcm0oY29ubiwgY3R4 LCBuYW1lKTsKIAlpZiAocmV0KQogCQlyZXR1cm4gcmV0OwogCg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-4.16-07.patch" Content-Disposition: attachment; filename="xsa418/xsa418-4.16-07.patch" Content-Transfer-Encoding: base64 RnJvbSAxZWUyODFiMThiNTJiZWM4NzMzNWVhNjRlZTc0Y2MxNTllNjNkMDM2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHVzZSB0cmVl d2FsayBmb3IgY3JlYXRpbmcgbm9kZSByZWNvcmRzCgpJbnN0ZWFkIG9mIGRv aW5nIGFuIG9wZW4gdHJlZSB3YWxrIHVzaW5nIGNhbGwgcmVjdXJzaW9uLCB1 c2UKd2Fsa19ub2RlX3RyZWUoKSB3aGVuIGNyZWF0aW5nIHRoZSBub2RlIHJl Y29yZHMgZHVyaW5nIGEgbGl2ZSB1cGRhdGUuCgpUaGlzIHdpbGwgcmVkdWNl IGNvZGUgc2l6ZSBhbmQgYXZvaWQgbWFueSBuZXN0aW5nIGxldmVscyBvZiBm dW5jdGlvbgpjYWxscyB3aGljaCBjb3VsZCBwb3RlbnRpYWxseSBleGhhdXN0 IHRoZSBzdGFjay4KClRoaXMgaXMgcGFydCBvZiBYU0EtNDE4IC8gQ1ZFLTIw MjItNDIzMjEuCgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxkdnJhYmVs QGFtYXpvbi5jby51az4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8 amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxq Z3JhbGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2NvcmUuYwppbmRleCA1OGZiNjUxNTQyZWMuLjA1ZDM0OTc3OGJiNCAxMDA2 NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0zMTIwLDEw MSArMzEyMCw3NiBAQCBjb25zdCBjaGFyICpkdW1wX3N0YXRlX25vZGVfcGVy bXMoRklMRSAqZnAsIGNvbnN0IHN0cnVjdCB4c19wZXJtaXNzaW9ucyAqcGVy bXMsCiAJcmV0dXJuIE5VTEw7CiB9CiAKLXN0YXRpYyBjb25zdCBjaGFyICpk dW1wX3N0YXRlX25vZGVfdHJlZShGSUxFICpmcCwgY2hhciAqcGF0aCwKLQkJ CQkJdW5zaWduZWQgaW50IHBhdGhfbWF4X2xlbikKK3N0cnVjdCBkdW1wX25v ZGVfZGF0YSB7CisJRklMRSAqZnA7CisJY29uc3QgY2hhciAqZXJyOworfTsK Kworc3RhdGljIGludCBkdW1wX3N0YXRlX25vZGVfZXJyKHN0cnVjdCBkdW1w X25vZGVfZGF0YSAqZGF0YSwgY29uc3QgY2hhciAqZXJyKQogewotCXVuc2ln bmVkIGludCBwYXRobGVuLCBjaGlsZGxlbiwgcCA9IDA7CisJZGF0YS0+ZXJy ID0gZXJyOworCXJldHVybiBXQUxLX1RSRUVfRVJST1JfU1RPUDsKK30KKwor c3RhdGljIGludCBkdW1wX3N0YXRlX25vZGUoY29uc3Qgdm9pZCAqY3R4LCBz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJCSAgIHN0cnVjdCBub2RlICpu b2RlLCB2b2lkICphcmcpCit7CisJc3RydWN0IGR1bXBfbm9kZV9kYXRhICpk YXRhID0gYXJnOworCUZJTEUgKmZwID0gZGF0YS0+ZnA7CisJdW5zaWduZWQg aW50IHBhdGhsZW47CiAJc3RydWN0IHhzX3N0YXRlX3JlY29yZF9oZWFkZXIg aGVhZDsKIAlzdHJ1Y3QgeHNfc3RhdGVfbm9kZSBzbjsKLQlUREJfREFUQSBr ZXksIGRhdGE7Ci0JY29uc3Qgc3RydWN0IHhzX3RkYl9yZWNvcmRfaGRyICpo ZHI7Ci0JY29uc3QgY2hhciAqY2hpbGQ7CiAJY29uc3QgY2hhciAqcmV0Owog Ci0JcGF0aGxlbiA9IHN0cmxlbihwYXRoKSArIDE7Ci0KLQlzZXRfdGRiX2tl eShwYXRoLCAma2V5KTsKLQlkYXRhID0gdGRiX2ZldGNoKHRkYl9jdHgsIGtl eSk7Ci0JaWYgKGRhdGEuZHB0ciA9PSBOVUxMKQotCQlyZXR1cm4gIkVycm9y IHJlYWRpbmcgbm9kZSI7Ci0KLQkvKiBDbGVhbiB1cCBpbiBjYXNlIG9mIGZh aWx1cmUuICovCi0JdGFsbG9jX3N0ZWFsKHBhdGgsIGRhdGEuZHB0cik7Ci0K LQloZHIgPSAodm9pZCAqKWRhdGEuZHB0cjsKKwlwYXRobGVuID0gc3RybGVu KG5vZGUtPm5hbWUpICsgMTsKIAogCWhlYWQudHlwZSA9IFhTX1NUQVRFX1RZ UEVfTk9ERTsKIAloZWFkLmxlbmd0aCA9IHNpemVvZihzbik7CiAJc24uY29u bl9pZCA9IDA7CiAJc24udGFfaWQgPSAwOwogCXNuLnRhX2FjY2VzcyA9IDA7 Ci0Jc24ucGVybV9uID0gaGRyLT5udW1fcGVybXM7CisJc24ucGVybV9uID0g bm9kZS0+cGVybXMubnVtOwogCXNuLnBhdGhfbGVuID0gcGF0aGxlbjsKLQlz bi5kYXRhX2xlbiA9IGhkci0+ZGF0YWxlbjsKLQloZWFkLmxlbmd0aCArPSBo ZHItPm51bV9wZXJtcyAqIHNpemVvZigqc24ucGVybXMpOworCXNuLmRhdGFf bGVuID0gbm9kZS0+ZGF0YWxlbjsKKwloZWFkLmxlbmd0aCArPSBub2RlLT5w ZXJtcy5udW0gKiBzaXplb2YoKnNuLnBlcm1zKTsKIAloZWFkLmxlbmd0aCAr PSBwYXRobGVuOwotCWhlYWQubGVuZ3RoICs9IGhkci0+ZGF0YWxlbjsKKwlo ZWFkLmxlbmd0aCArPSBub2RlLT5kYXRhbGVuOwogCWhlYWQubGVuZ3RoID0g Uk9VTkRVUChoZWFkLmxlbmd0aCwgMyk7CiAKIAlpZiAoZndyaXRlKCZoZWFk LCBzaXplb2YoaGVhZCksIDEsIGZwKSAhPSAxKQotCQlyZXR1cm4gIkR1bXAg bm9kZSBzdGF0ZSBlcnJvciI7CisJCXJldHVybiBkdW1wX3N0YXRlX25vZGVf ZXJyKGRhdGEsICJEdW1wIG5vZGUgaGVhZCBlcnJvciIpOwogCWlmIChmd3Jp dGUoJnNuLCBzaXplb2Yoc24pLCAxLCBmcCkgIT0gMSkKLQkJcmV0dXJuICJE dW1wIG5vZGUgc3RhdGUgZXJyb3IiOworCQlyZXR1cm4gZHVtcF9zdGF0ZV9u b2RlX2VycihkYXRhLCAiRHVtcCBub2RlIHN0YXRlIGVycm9yIik7CiAKLQly ZXQgPSBkdW1wX3N0YXRlX25vZGVfcGVybXMoZnAsIGhkci0+cGVybXMsIGhk ci0+bnVtX3Blcm1zKTsKKwlyZXQgPSBkdW1wX3N0YXRlX25vZGVfcGVybXMo ZnAsIG5vZGUtPnBlcm1zLnAsIG5vZGUtPnBlcm1zLm51bSk7CiAJaWYgKHJl dCkKLQkJcmV0dXJuIHJldDsKKwkJcmV0dXJuIGR1bXBfc3RhdGVfbm9kZV9l cnIoZGF0YSwgcmV0KTsKKworCWlmIChmd3JpdGUobm9kZS0+bmFtZSwgcGF0 aGxlbiwgMSwgZnApICE9IDEpCisJCXJldHVybiBkdW1wX3N0YXRlX25vZGVf ZXJyKGRhdGEsICJEdW1wIG5vZGUgcGF0aCBlcnJvciIpOwogCi0JaWYgKGZ3 cml0ZShwYXRoLCBwYXRobGVuLCAxLCBmcCkgIT0gMSkKLQkJcmV0dXJuICJE dW1wIG5vZGUgcGF0aCBlcnJvciI7Ci0JaWYgKGhkci0+ZGF0YWxlbiAmJgot CSAgICBmd3JpdGUoaGRyLT5wZXJtcyArIGhkci0+bnVtX3Blcm1zLCBoZHIt PmRhdGFsZW4sIDEsIGZwKSAhPSAxKQotCQlyZXR1cm4gIkR1bXAgbm9kZSBk YXRhIGVycm9yIjsKKwlpZiAobm9kZS0+ZGF0YWxlbiAmJiBmd3JpdGUobm9k ZS0+ZGF0YSwgbm9kZS0+ZGF0YWxlbiwgMSwgZnApICE9IDEpCisJCXJldHVy biBkdW1wX3N0YXRlX25vZGVfZXJyKGRhdGEsICJEdW1wIG5vZGUgZGF0YSBl cnJvciIpOwogCiAJcmV0ID0gZHVtcF9zdGF0ZV9hbGlnbihmcCk7CiAJaWYg KHJldCkKLQkJcmV0dXJuIHJldDsKKwkJcmV0dXJuIGR1bXBfc3RhdGVfbm9k ZV9lcnIoZGF0YSwgcmV0KTsKIAotCWNoaWxkID0gKGNoYXIgKikoaGRyLT5w ZXJtcyArIGhkci0+bnVtX3Blcm1zKSArIGhkci0+ZGF0YWxlbjsKLQotCS8q Ci0JICogVXNlIHBhdGggZm9yIGNvbnN0cnVjdGluZyBjaGlsZHJlbiBwYXRo cy4KLQkgKiBBcyB3ZSBkb24ndCB3cml0ZSBvdXQgbm9kZXMgd2l0aG91dCBo YXZpbmcgd3JpdHRlbiB0aGVpciBwYXJlbnQKLQkgKiBhbHJlYWR5IHdlIHdp bGwgbmV2ZXIgY2xvYmJlciBhIHBhcnQgb2YgdGhlIHBhdGggd2UnbGwgbmVl ZCBsYXRlci4KLQkgKi8KLQlwYXRobGVuLS07Ci0JaWYgKHBhdGhbcGF0aGxl biAtIDFdICE9ICcvJykgewotCQlwYXRoW3BhdGhsZW5dID0gJy8nOwotCQlw YXRobGVuKys7Ci0JfQotCXdoaWxlIChwIDwgaGRyLT5jaGlsZGxlbikgewot CQljaGlsZGxlbiA9IHN0cmxlbihjaGlsZCkgKyAxOwotCQlpZiAocGF0aGxl biArIGNoaWxkbGVuID4gcGF0aF9tYXhfbGVuKQotCQkJcmV0dXJuICJEdW1w IG5vZGUgcGF0aCBsZW5ndGggZXJyb3IiOwotCQlzdHJjcHkocGF0aCArIHBh dGhsZW4sIGNoaWxkKTsKLQkJcmV0ID0gZHVtcF9zdGF0ZV9ub2RlX3RyZWUo ZnAsIHBhdGgsIHBhdGhfbWF4X2xlbik7Ci0JCWlmIChyZXQpCi0JCQlyZXR1 cm4gcmV0OwotCQlwICs9IGNoaWxkbGVuOwotCQljaGlsZCArPSBjaGlsZGxl bjsKLQl9Ci0KLQl0YWxsb2NfZnJlZShkYXRhLmRwdHIpOwotCi0JcmV0dXJu IE5VTEw7CisJcmV0dXJuIFdBTEtfVFJFRV9PSzsKIH0KIAogY29uc3QgY2hh ciAqZHVtcF9zdGF0ZV9ub2RlcyhGSUxFICpmcCwgY29uc3Qgdm9pZCAqY3R4 KQogewotCWNoYXIgKnBhdGg7Ci0KLQlwYXRoID0gdGFsbG9jX3NpemUoY3R4 LCBYRU5TVE9SRV9BQlNfUEFUSF9NQVggKyAxKTsKLQlpZiAoIXBhdGgpCi0J CXJldHVybiAiUGF0aCBidWZmZXIgYWxsb2NhdGlvbiBlcnJvciI7CisJc3Ry dWN0IGR1bXBfbm9kZV9kYXRhIGRhdGEgPSB7CisJCS5mcCA9IGZwLAorCQku ZXJyID0gIkR1bXAgbm9kZSB3YWxrIGVycm9yIgorCX07CisJc3RydWN0IHdh bGtfZnVuY3Mgd2Fsa2Z1bmNzID0geyAuZW50ZXIgPSBkdW1wX3N0YXRlX25v ZGUgfTsKIAotCXN0cmNweShwYXRoLCAiLyIpOworCWlmICh3YWxrX25vZGVf dHJlZShjdHgsIE5VTEwsICIvIiwgJndhbGtmdW5jcywgJmRhdGEpKQorCQly ZXR1cm4gZGF0YS5lcnI7CiAKLQlyZXR1cm4gZHVtcF9zdGF0ZV9ub2RlX3Ry ZWUoZnAsIHBhdGgsIFhFTlNUT1JFX0FCU19QQVRIX01BWCArIDEpOworCXJl dHVybiBOVUxMOwogfQogCiB2b2lkIHJlYWRfc3RhdGVfZ2xvYmFsKGNvbnN0 IHZvaWQgKmN0eCwgY29uc3Qgdm9pZCAqc3RhdGUpCg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-04.patch" Content-Disposition: attachment; filename="xsa418/xsa418-04.patch" Content-Transfer-Encoding: base64 RnJvbSBmZmQxYmE2Yjk3ZjI0YzNiZjI5YjQ5NTU3YzEzN2Q3MGEzODE5ZDA3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHNpbXBsaWZ5 IGNoZWNrX3N0b3JlKCkKCmNoZWNrX3N0b3JlKCkgaXMgdXNpbmcgYSBoYXNo IHRhYmxlIGZvciBzdG9yaW5nIGFsbCBub2RlIG5hbWVzIGl0IGhhcwpmb3Vu ZCB2aWEgd2Fsa2luZyB0aGUgdHJlZS4gQWRkaXRpb25hbGx5IGl0IHVzaW5n IGFub3RoZXIgaGFzaCB0YWJsZQpmb3IgYWxsIGNoaWxkcmVuIG9mIGEgbm9k ZSB0byBkZXRlY3QgZHVwbGljYXRlIGNoaWxkIG5hbWVzLgoKU2ltcGxpZnkg dGhhdCBieSBkcm9wcGluZyB0aGUgc2Vjb25kIGhhc2ggdGFibGUgYXMgdGhl IGZpcnN0IG9uZSBpcwphbHJlYWR5IGhvbGRpbmcgYWxsIHRoZSBuZWVkZWQg aW5mb3JtYXRpb24uCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQxOCAvIENWRS0y MDIyLTQyMzIxLgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8ZHZyYWJl bEBhbWF6b24uY28udWs+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3Mg PGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmMKaW5kZXggZjc4ZmFmMGMzZTA2Li5iMzU5NmM3ZWViOTkgMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtMjQ1Niw1 MCArMjQ1NiwzNCBAQCBzdGF0aWMgaW50IGNoZWNrX3N0b3JlXyhjb25zdCBj aGFyICpuYW1lLCBzdHJ1Y3QgaGFzaHRhYmxlICpyZWFjaGFibGUpCiAJaWYg KG5vZGUpIHsKIAkJc2l6ZV90IGkgPSAwOwogCi0JCXN0cnVjdCBoYXNodGFi bGUgKiBjaGlsZHJlbiA9Ci0JCQljcmVhdGVfaGFzaHRhYmxlKDE2LCBoYXNo X2Zyb21fa2V5X2ZuLCBrZXlzX2VxdWFsX2ZuKTsKLQkJaWYgKCFjaGlsZHJl bikgewotCQkJbG9nKCJjaGVja19zdG9yZSBjcmVhdGUgdGFibGU6IEVOT01F TSIpOwotCQkJcmV0dXJuIEVOT01FTTsKLQkJfQotCiAJCWlmICghcmVtZW1i ZXJfc3RyaW5nKHJlYWNoYWJsZSwgbmFtZSkpIHsKLQkJCWhhc2h0YWJsZV9k ZXN0cm95KGNoaWxkcmVuLCAwKTsKIAkJCWxvZygiY2hlY2tfc3RvcmU6IEVO T01FTSIpOwogCQkJcmV0dXJuIEVOT01FTTsKIAkJfQogCiAJCXdoaWxlIChp IDwgbm9kZS0+Y2hpbGRsZW4gJiYgIXJldCkgewotCQkJc3RydWN0IG5vZGUg KmNoaWxkbm9kZTsKKwkJCXN0cnVjdCBub2RlICpjaGlsZG5vZGUgPSBOVUxM OwogCQkJc2l6ZV90IGNoaWxkbGVuID0gc3RybGVuKG5vZGUtPmNoaWxkcmVu ICsgaSk7Ci0JCQljaGFyICogY2hpbGRuYW1lID0gY2hpbGRfbmFtZShOVUxM LCBub2RlLT5uYW1lLAotCQkJCQkJICAgICAgbm9kZS0+Y2hpbGRyZW4gKyBp KTsKKwkJCWNoYXIgKmNoaWxkbmFtZSA9IGNoaWxkX25hbWUoTlVMTCwgbm9k ZS0+bmFtZSwKKwkJCQkJCSAgICAgbm9kZS0+Y2hpbGRyZW4gKyBpKTsKIAog CQkJaWYgKCFjaGlsZG5hbWUpIHsKIAkJCQlsb2coImNoZWNrX3N0b3JlOiBF Tk9NRU0iKTsKIAkJCQlyZXQgPSBFTk9NRU07CiAJCQkJYnJlYWs7CiAJCQl9 CisKKwkJCWlmIChoYXNodGFibGVfc2VhcmNoKHJlYWNoYWJsZSwgY2hpbGRu YW1lKSkgeworCQkJCWxvZygiY2hlY2tfc3RvcmU6ICclcycgaXMgZHVwbGlj YXRlZCEiLAorCQkJCSAgICBjaGlsZG5hbWUpOworCQkJCWkgPSBybV9jaGls ZF9lbnRyeShub2RlLCBpLCBjaGlsZGxlbik7CisJCQkJZ290byBuZXh0Owor CQkJfQorCiAJCQljaGlsZG5vZGUgPSByZWFkX25vZGUoTlVMTCwgY2hpbGRu YW1lLCBjaGlsZG5hbWUpOwotCQkJCisKIAkJCWlmIChjaGlsZG5vZGUpIHsK LQkJCQlpZiAoaGFzaHRhYmxlX3NlYXJjaChjaGlsZHJlbiwgY2hpbGRuYW1l KSkgewotCQkJCQlsb2coImNoZWNrX3N0b3JlOiAnJXMnIGlzIGR1cGxpY2F0 ZWQhIiwKLQkJCQkJICAgIGNoaWxkbmFtZSk7Ci0JCQkJCWkgPSBybV9jaGls ZF9lbnRyeShub2RlLCBpLCBjaGlsZGxlbik7Ci0JCQkJfQotCQkJCWVsc2Ug ewotCQkJCQlpZiAoIXJlbWVtYmVyX3N0cmluZyhjaGlsZHJlbiwKLQkJCQkJ CQkgICAgIGNoaWxkbmFtZSkpIHsKLQkJCQkJCWxvZygiY2hlY2tfc3RvcmU6 IEVOT01FTSIpOwotCQkJCQkJdGFsbG9jX2ZyZWUoY2hpbGRub2RlKTsKLQkJ CQkJCXRhbGxvY19mcmVlKGNoaWxkbmFtZSk7Ci0JCQkJCQlyZXQgPSBFTk9N RU07Ci0JCQkJCQlicmVhazsKLQkJCQkJfQotCQkJCQlyZXQgPSBjaGVja19z dG9yZV8oY2hpbGRuYW1lLAotCQkJCQkJCSAgIHJlYWNoYWJsZSk7Ci0JCQkJ fQorCQkJCXJldCA9IGNoZWNrX3N0b3JlXyhjaGlsZG5hbWUsIHJlYWNoYWJs ZSk7CiAJCQl9IGVsc2UgaWYgKGVycm5vICE9IEVOT01FTSkgewogCQkJCWxv ZygiY2hlY2tfc3RvcmU6IE5vIGNoaWxkICclcycgZm91bmQhXG4iLAogCQkJ CSAgICBjaGlsZG5hbWUpOwpAQCAtMjUwOSwxOSArMjQ5MywxOCBAQCBzdGF0 aWMgaW50IGNoZWNrX3N0b3JlXyhjb25zdCBjaGFyICpuYW1lLCBzdHJ1Y3Qg aGFzaHRhYmxlICpyZWFjaGFibGUpCiAJCQkJcmV0ID0gRU5PTUVNOwogCQkJ fQogCisgbmV4dDoKIAkJCXRhbGxvY19mcmVlKGNoaWxkbm9kZSk7CiAJCQl0 YWxsb2NfZnJlZShjaGlsZG5hbWUpOwogCQkJaSArPSBjaGlsZGxlbiArIDE7 CiAJCX0KIAotCQloYXNodGFibGVfZGVzdHJveShjaGlsZHJlbiwgMCAvKiBE b24ndCBmcmVlIHZhbHVlcyAodGhleSBhcmUKLQkJCQkJCSBhbGwgKHZvaWQg KikxKSAqLyk7CiAJCXRhbGxvY19mcmVlKG5vZGUpOwogCX0gZWxzZSBpZiAo ZXJybm8gIT0gRU5PTUVNKSB7CiAJCS8qIEltcG9zc2libGUsIGJlY2F1c2Ug bm8gZGF0YWJhc2Ugc2hvdWxkIGV2ZXIgYmUgd2l0aG91dCB0aGUKIAkJICAg cm9vdCwgYW5kIG90aGVyd2lzZSwgd2UndmUganVzdCBjaGVja2VkIGluIG91 ciBjYWxsZXIKIAkJICAgKHdoaWNoIG1hZGUgYSByZWN1cnNpdmUgY2FsbCB0 byBnZXQgaGVyZSkuICovCi0JCSAgIAorCiAJCWxvZygiY2hlY2tfc3RvcmU6 IE5vIGNoaWxkICclcycgZm91bmQ6IGltcG9zc2libGUhIiwgbmFtZSk7CiAJ fSBlbHNlIHsKIAkJbG9nKCJjaGVja19zdG9yZTogRU5PTUVNIik7Cg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-05.patch" Content-Disposition: attachment; filename="xsa418/xsa418-05.patch" Content-Transfer-Encoding: base64 RnJvbSA0Nzg1NGE1MmViOGE1YzMxZTZjMGMxNTBhODdjODY3ODdlY2RlMWM2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHVzZSB0cmVl d2FsayBmb3IgY2hlY2tfc3RvcmUoKQoKSW5zdGVhZCBvZiBkb2luZyBhbiBv cGVuIHRyZWUgd2FsayB1c2luZyBjYWxsIHJlY3Vyc2lvbiwgdXNlCndhbGtf bm9kZV90cmVlKCkgd2hlbiBjaGVja2luZyB0aGUgc3RvcmUgZm9yIGluY29u c2lzdGVuY2llcy4KClRoaXMgd2lsbCByZWR1Y2UgY29kZSBzaXplIGFuZCBh dm9pZCBtYW55IG5lc3RpbmcgbGV2ZWxzIG9mIGZ1bmN0aW9uCmNhbGxzIHdo aWNoIGNvdWxkIHBvdGVudGlhbGx5IGV4aGF1c3QgdGhlIHN0YWNrLgoKVGhp cyBpcyBwYXJ0IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9y dGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpT aWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ ClJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29t PgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IGIz NTk2YzdlZWI5OS4uYjA4ODkxODZiNjFhIDEwMDY0NAotLS0gYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMKQEAgLTI0MjMsMTggKzI0MjMsNiBAQCBpbnQg cmVtZW1iZXJfc3RyaW5nKHN0cnVjdCBoYXNodGFibGUgKmhhc2gsIGNvbnN0 IGNoYXIgKnN0cikKIAlyZXR1cm4gaGFzaHRhYmxlX2luc2VydChoYXNoLCBr LCAodm9pZCAqKTEpOwogfQogCi1zdGF0aWMgaW50IHJtX2NoaWxkX2VudHJ5 KHN0cnVjdCBub2RlICpub2RlLCBzaXplX3Qgb2ZmLCBzaXplX3QgbGVuKQot ewotCWlmICghcmVjb3ZlcnkpCi0JCXJldHVybiBvZmY7Ci0KLQlpZiAocmVt b3ZlX2NoaWxkX2VudHJ5KE5VTEwsIG5vZGUsIG9mZikpCi0JCWxvZygiY2hl Y2tfc3RvcmU6IGNoaWxkIGVudHJ5IGNvdWxkIG5vdCBiZSByZW1vdmVkIGZy b20gJyVzJyIsCi0JCSAgICBub2RlLT5uYW1lKTsKLQotCXJldHVybiBvZmYg LSBsZW4gLSAxOwotfQotCiAvKioKICAqIEEgbm9kZSBoYXMgYSBjaGlsZHJl biBmaWVsZCB0aGF0IG5hbWVzIHRoZSBjaGlsZHJlbiBvZiB0aGUgbm9kZSwg c2VwYXJhdGVkCiAgKiBieSBOVUxzLiAgV2UgY2hlY2sgd2hldGhlciB0aGVy ZSBhcmUgZW50cmllcyBpbiB0aGVyZSB0aGF0IGFyZSBkdXBsaWNhdGVkCkBA IC0yNDQ4LDcwICsyNDM2LDI5IEBAIHN0YXRpYyBpbnQgcm1fY2hpbGRfZW50 cnkoc3RydWN0IG5vZGUgKm5vZGUsIHNpemVfdCBvZmYsIHNpemVfdCBsZW4p CiAgKiBBcyB3ZSBnbywgd2UgcmVjb3JkIGVhY2ggbm9kZSBpbiB0aGUgZ2l2 ZW4gcmVhY2hhYmxlIGhhc2h0YWJsZS4gIFRoZXNlCiAgKiBlbnRyaWVzIHdp bGwgYmUgdXNlZCBsYXRlciBpbiBjbGVhbl9zdG9yZS4KICAqLwotc3RhdGlj IGludCBjaGVja19zdG9yZV8oY29uc3QgY2hhciAqbmFtZSwgc3RydWN0IGhh c2h0YWJsZSAqcmVhY2hhYmxlKQorc3RhdGljIGludCBjaGVja19zdG9yZV9z dGVwKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s CisJCQkgICAgc3RydWN0IG5vZGUgKm5vZGUsIHZvaWQgKmFyZykKIHsKLQlz dHJ1Y3Qgbm9kZSAqbm9kZSA9IHJlYWRfbm9kZShOVUxMLCBuYW1lLCBuYW1l KTsKLQlpbnQgcmV0ID0gMDsKLQotCWlmIChub2RlKSB7Ci0JCXNpemVfdCBp ID0gMDsKLQotCQlpZiAoIXJlbWVtYmVyX3N0cmluZyhyZWFjaGFibGUsIG5h bWUpKSB7Ci0JCQlsb2coImNoZWNrX3N0b3JlOiBFTk9NRU0iKTsKLQkJCXJl dHVybiBFTk9NRU07Ci0JCX0KLQotCQl3aGlsZSAoaSA8IG5vZGUtPmNoaWxk bGVuICYmICFyZXQpIHsKLQkJCXN0cnVjdCBub2RlICpjaGlsZG5vZGUgPSBO VUxMOwotCQkJc2l6ZV90IGNoaWxkbGVuID0gc3RybGVuKG5vZGUtPmNoaWxk cmVuICsgaSk7Ci0JCQljaGFyICpjaGlsZG5hbWUgPSBjaGlsZF9uYW1lKE5V TEwsIG5vZGUtPm5hbWUsCi0JCQkJCQkgICAgIG5vZGUtPmNoaWxkcmVuICsg aSk7Ci0KLQkJCWlmICghY2hpbGRuYW1lKSB7Ci0JCQkJbG9nKCJjaGVja19z dG9yZTogRU5PTUVNIik7Ci0JCQkJcmV0ID0gRU5PTUVNOwotCQkJCWJyZWFr OwotCQkJfQotCi0JCQlpZiAoaGFzaHRhYmxlX3NlYXJjaChyZWFjaGFibGUs IGNoaWxkbmFtZSkpIHsKLQkJCQlsb2coImNoZWNrX3N0b3JlOiAnJXMnIGlz IGR1cGxpY2F0ZWQhIiwKLQkJCQkgICAgY2hpbGRuYW1lKTsKLQkJCQlpID0g cm1fY2hpbGRfZW50cnkobm9kZSwgaSwgY2hpbGRsZW4pOwotCQkJCWdvdG8g bmV4dDsKLQkJCX0KKwlzdHJ1Y3QgaGFzaHRhYmxlICpyZWFjaGFibGUgPSBh cmc7CiAKLQkJCWNoaWxkbm9kZSA9IHJlYWRfbm9kZShOVUxMLCBjaGlsZG5h bWUsIGNoaWxkbmFtZSk7Ci0KLQkJCWlmIChjaGlsZG5vZGUpIHsKLQkJCQly ZXQgPSBjaGVja19zdG9yZV8oY2hpbGRuYW1lLCByZWFjaGFibGUpOwotCQkJ fSBlbHNlIGlmIChlcnJubyAhPSBFTk9NRU0pIHsKLQkJCQlsb2coImNoZWNr X3N0b3JlOiBObyBjaGlsZCAnJXMnIGZvdW5kIVxuIiwKLQkJCQkgICAgY2hp bGRuYW1lKTsKLQkJCQlpID0gcm1fY2hpbGRfZW50cnkobm9kZSwgaSwgY2hp bGRsZW4pOwotCQkJfSBlbHNlIHsKLQkJCQlsb2coImNoZWNrX3N0b3JlOiBF Tk9NRU0iKTsKLQkJCQlyZXQgPSBFTk9NRU07Ci0JCQl9CisJaWYgKGhhc2h0 YWJsZV9zZWFyY2gocmVhY2hhYmxlLCAodm9pZCAqKW5vZGUtPm5hbWUpKSB7 CisJCWxvZygiY2hlY2tfc3RvcmU6ICclcycgaXMgZHVwbGljYXRlZCEiLCBu b2RlLT5uYW1lKTsKKwkJcmV0dXJuIHJlY292ZXJ5ID8gV0FMS19UUkVFX1JN X0NISUxERU5UUlkKKwkJCQk6IFdBTEtfVFJFRV9TS0lQX0NISUxEUkVOOwor CX0KIAotIG5leHQ6Ci0JCQl0YWxsb2NfZnJlZShjaGlsZG5vZGUpOwotCQkJ dGFsbG9jX2ZyZWUoY2hpbGRuYW1lKTsKLQkJCWkgKz0gY2hpbGRsZW4gKyAx OwotCQl9CisJaWYgKCFyZW1lbWJlcl9zdHJpbmcocmVhY2hhYmxlLCBub2Rl LT5uYW1lKSkKKwkJcmV0dXJuIFdBTEtfVFJFRV9FUlJPUl9TVE9QOwogCi0J CXRhbGxvY19mcmVlKG5vZGUpOwotCX0gZWxzZSBpZiAoZXJybm8gIT0gRU5P TUVNKSB7Ci0JCS8qIEltcG9zc2libGUsIGJlY2F1c2Ugbm8gZGF0YWJhc2Ug c2hvdWxkIGV2ZXIgYmUgd2l0aG91dCB0aGUKLQkJICAgcm9vdCwgYW5kIG90 aGVyd2lzZSwgd2UndmUganVzdCBjaGVja2VkIGluIG91ciBjYWxsZXIKLQkJ ICAgKHdoaWNoIG1hZGUgYSByZWN1cnNpdmUgY2FsbCB0byBnZXQgaGVyZSku ICovCisJcmV0dXJuIFdBTEtfVFJFRV9PSzsKK30KIAotCQlsb2coImNoZWNr X3N0b3JlOiBObyBjaGlsZCAnJXMnIGZvdW5kOiBpbXBvc3NpYmxlISIsIG5h bWUpOwotCX0gZWxzZSB7Ci0JCWxvZygiY2hlY2tfc3RvcmU6IEVOT01FTSIp OwotCQlyZXQgPSBFTk9NRU07Ci0JfQorc3RhdGljIGludCBjaGVja19zdG9y ZV9lbm9lbnQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwKKwkJCSAgICAgIHN0cnVjdCBub2RlICpwYXJlbnQsIGNoYXIgKm5h bWUsIHZvaWQgKmFyZykKK3sKKwlsb2coImNoZWNrX3N0b3JlOiBub2RlICcl cycgbm90IGZvdW5kIiwgbmFtZSk7CiAKLQlyZXR1cm4gcmV0OworCXJldHVy biByZWNvdmVyeSA/IFdBTEtfVFJFRV9STV9DSElMREVOVFJZIDogV0FMS19U UkVFX09LOwogfQogCiAKQEAgLTI1NjAsMjkgKzI1MDcsMjggQEAgc3RhdGlj IHZvaWQgY2xlYW5fc3RvcmUoc3RydWN0IGhhc2h0YWJsZSAqcmVhY2hhYmxl KQogCiB2b2lkIGNoZWNrX3N0b3JlKHZvaWQpCiB7Ci0JY2hhciAqcm9vdCA9 IHRhbGxvY19zdHJkdXAoTlVMTCwgIi8iKTsKIAlzdHJ1Y3QgaGFzaHRhYmxl ICpyZWFjaGFibGU7CisJc3RydWN0IHdhbGtfZnVuY3Mgd2Fsa2Z1bmNzID0g eworCQkuZW50ZXIgPSBjaGVja19zdG9yZV9zdGVwLAorCQkuZW5vZW50ID0g Y2hlY2tfc3RvcmVfZW5vZW50LAorCX07CiAKLQlpZiAoIXJvb3QpIHsKLQkJ bG9nKCJjaGVja19zdG9yZTogRU5PTUVNIik7Ci0JCXJldHVybjsKLQl9CiAJ cmVhY2hhYmxlID0gY3JlYXRlX2hhc2h0YWJsZSgxNiwgaGFzaF9mcm9tX2tl eV9mbiwga2V5c19lcXVhbF9mbik7CiAJaWYgKCFyZWFjaGFibGUpIHsKIAkJ bG9nKCJjaGVja19zdG9yZTogRU5PTUVNIik7Ci0JCWdvdG8gb3V0X3Jvb3Q7 CisJCXJldHVybjsKIAl9CiAKIAlsb2coIkNoZWNraW5nIHN0b3JlIC4uLiIp OwotCWlmICghY2hlY2tfc3RvcmVfKHJvb3QsIHJlYWNoYWJsZSkgJiYKLQkg ICAgIWNoZWNrX3RyYW5zYWN0aW9ucyhyZWFjaGFibGUpKQorCWlmICh3YWxr X25vZGVfdHJlZShOVUxMLCBOVUxMLCAiLyIsICZ3YWxrZnVuY3MsIHJlYWNo YWJsZSkpIHsKKwkJaWYgKGVycm5vID09IEVOT01FTSkKKwkJCWxvZygiY2hl Y2tfc3RvcmU6IEVOT01FTSIpOworCX0gZWxzZSBpZiAoIWNoZWNrX3RyYW5z YWN0aW9ucyhyZWFjaGFibGUpKQogCQljbGVhbl9zdG9yZShyZWFjaGFibGUp OwogCWxvZygiQ2hlY2tpbmcgc3RvcmUgY29tcGxldGUuIik7CiAKIAloYXNo dGFibGVfZGVzdHJveShyZWFjaGFibGUsIDAgLyogRG9uJ3QgZnJlZSB2YWx1 ZXMgKHRoZXkgYXJlIGFsbAogCQkJCQkgICh2b2lkICopMSkgKi8pOwotIG91 dF9yb290OgotCXRhbGxvY19mcmVlKHJvb3QpOwogfQogCiAK --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-06.patch" Content-Disposition: attachment; filename="xsa418/xsa418-06.patch" Content-Transfer-Encoding: base64 RnJvbSAwNmM4OWRkNDhjMDhmMWVhYTJlNWJjYzE0MDc1NTRlZTNlMGI0ZTI3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHVzZSB0cmVl d2FsayBmb3IgZGVsZXRpbmcgbm9kZXMKCkluc3RlYWQgb2YgZG9pbmcgYW4g b3BlbiB0cmVlIHdhbGsgdXNpbmcgY2FsbCByZWN1cnNpb24sIHVzZQp3YWxr X25vZGVfdHJlZSgpIHdoZW4gZGVsZXRpbmcgYSBzdWItdHJlZSBvZiBub2Rl cy4KClRoaXMgd2lsbCByZWR1Y2UgY29kZSBzaXplIGFuZCBhdm9pZCBtYW55 IG5lc3RpbmcgbGV2ZWxzIG9mIGZ1bmN0aW9uCmNhbGxzIHdoaWNoIGNvdWxk IHBvdGVudGlhbGx5IGV4aGF1c3QgdGhlIHN0YWNrLgoKVGhpcyBpcyBwYXJ0 IG9mIFhTQS00MTggLyBDVkUtMjAyMi00MjMyMS4KClJlcG9ydGVkLWJ5OiBK dWxpZW4gR3JhbGwgPGR2cmFiZWxAYW1hem9uLmNvLnVrPgpTaWduZWQtb2Zm LWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+CkFja2VkLWJ5 OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdp dCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IGIwODg5MTg2YjYxYS4u ZmEyNGJjZmVhNGZiIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMKQEAgLTEzMzAsMjEgKzEzMzAsNiBAQCBzdGF0aWMgaW50IGRvX3Jl YWQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwK IAlyZXR1cm4gMDsKIH0KIAotc3RhdGljIHZvaWQgZGVsZXRlX25vZGVfc2lu Z2xlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9k ZSkKLXsKLQlUREJfREFUQSBrZXk7Ci0KLQlpZiAoYWNjZXNzX25vZGUoY29u biwgbm9kZSwgTk9ERV9BQ0NFU1NfREVMRVRFLCAma2V5KSkKLQkJcmV0dXJu OwotCi0JaWYgKGRvX3RkYl9kZWxldGUoY29ubiwgJmtleSwgJm5vZGUtPmFj YykgIT0gMCkgewotCQljb3JydXB0KGNvbm4sICJDb3VsZCBub3QgZGVsZXRl ICclcyciLCBub2RlLT5uYW1lKTsKLQkJcmV0dXJuOwotCX0KLQotCWRvbWFp bl9lbnRyeV9kZWMoY29ubiwgbm9kZSk7Ci19Ci0KIC8qIE11c3Qgbm90IGJl IC8gKi8KIHN0YXRpYyBjaGFyICpiYXNlbmFtZShjb25zdCBjaGFyICpuYW1l KQogewpAQCAtMTYxNSw2OSArMTYwMCw1OSBAQCBzdGF0aWMgaW50IHJlbW92 ZV9jaGlsZF9lbnRyeShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0 IG5vZGUgKm5vZGUsCiAJcmV0dXJuIHdyaXRlX25vZGUoY29ubiwgbm9kZSwg dHJ1ZSk7CiB9CiAKLXN0YXRpYyB2b2lkIGRlbGV0ZV9jaGlsZChzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKLQkJCSBzdHJ1Y3Qgbm9kZSAqbm9kZSwgY29u c3QgY2hhciAqY2hpbGRuYW1lKQorc3RhdGljIGludCBkZWxldGVfY2hpbGQo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCQlzdHJ1Y3Qgbm9kZSAqbm9k ZSwgY29uc3QgY2hhciAqY2hpbGRuYW1lKQogewogCXVuc2lnbmVkIGludCBp OwogCiAJZm9yIChpID0gMDsgaSA8IG5vZGUtPmNoaWxkbGVuOyBpICs9IHN0 cmxlbihub2RlLT5jaGlsZHJlbitpKSArIDEpIHsKIAkJaWYgKHN0cmVxKG5v ZGUtPmNoaWxkcmVuK2ksIGNoaWxkbmFtZSkpIHsKLQkJCWlmIChyZW1vdmVf Y2hpbGRfZW50cnkoY29ubiwgbm9kZSwgaSkpCi0JCQkJY29ycnVwdChjb25u LCAiQ2FuJ3QgdXBkYXRlIHBhcmVudCBub2RlICclcyciLAotCQkJCQlub2Rl LT5uYW1lKTsKLQkJCXJldHVybjsKKwkJCWVycm5vID0gcmVtb3ZlX2NoaWxk X2VudHJ5KGNvbm4sIG5vZGUsIGkpID8gRUlPIDogMDsKKwkJCXJldHVybiBl cnJubzsKIAkJfQogCX0KIAljb3JydXB0KGNvbm4sICJDYW4ndCBmaW5kIGNo aWxkICclcycgaW4gJXMiLCBjaGlsZG5hbWUsIG5vZGUtPm5hbWUpOworCisJ ZXJybm8gPSBFSU87CisJcmV0dXJuIGVycm5vOwogfQogCi1zdGF0aWMgaW50 IGRlbGV0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2 b2lkICpjdHgsCi0JCSAgICAgICBzdHJ1Y3Qgbm9kZSAqcGFyZW50LCBzdHJ1 Y3Qgbm9kZSAqbm9kZSwgYm9vbCB3YXRjaF9leGFjdCkKK3N0YXRpYyBpbnQg ZGVsbm9kZV9zdWIoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwKKwkJICAgICAgIHN0cnVjdCBub2RlICpub2RlLCB2b2lkICph cmcpCiB7Ci0JY2hhciAqbmFtZTsKKwljb25zdCBjaGFyICpyb290ID0gYXJn OworCWJvb2wgd2F0Y2hfZXhhY3Q7CisJaW50IHJldDsKKwlUREJfREFUQSBr ZXk7CiAKLQkvKiBEZWxldGUgY2hpbGRyZW4uICovCi0Jd2hpbGUgKG5vZGUt PmNoaWxkbGVuKSB7Ci0JCXN0cnVjdCBub2RlICpjaGlsZDsKKwkvKiBBbnkg ZXJyb3IgaGVyZSB3aWxsIHByb2JhYmx5IGJlIHJlcGVhdGVkIGZvciBhbGwg Zm9sbG93aW5nIGNhbGxzLiAqLworCXJldCA9IGFjY2Vzc19ub2RlKGNvbm4s IG5vZGUsIE5PREVfQUNDRVNTX0RFTEVURSwgJmtleSk7CisJaWYgKHJldCA+ IDApCisJCXJldHVybiBXQUxLX1RSRUVfU1VDQ0VTU19TVE9QOwogCi0JCW5h bWUgPSB0YWxsb2NfYXNwcmludGYobm9kZSwgIiVzLyVzIiwgbm9kZS0+bmFt ZSwKLQkJCQkgICAgICAgbm9kZS0+Y2hpbGRyZW4pOwotCQljaGlsZCA9IG5h bWUgPyByZWFkX25vZGUoY29ubiwgbm9kZSwgbmFtZSkgOiBOVUxMOwotCQlp ZiAoY2hpbGQpIHsKLQkJCWlmIChkZWxldGVfbm9kZShjb25uLCBjdHgsIG5v ZGUsIGNoaWxkLCB0cnVlKSkKLQkJCQlyZXR1cm4gZXJybm87Ci0JCX0gZWxz ZSB7Ci0JCQl0cmFjZSgiZGVsZXRlX25vZGU6IEVycm9yIGRlbGV0aW5nIGNo aWxkICclcy8lcychXG4iLAotCQkJICAgICAgbm9kZS0+bmFtZSwgbm9kZS0+ Y2hpbGRyZW4pOwotCQkJLyogUXVpdCBkZWxldGluZy4gKi8KLQkJCWVycm5v ID0gRU5PTUVNOwotCQkJcmV0dXJuIGVycm5vOwotCQl9Ci0JCXRhbGxvY19m cmVlKG5hbWUpOwotCX0KKwkvKiBJbiBjYXNlIG9mIGVycm9yIHN0b3AgdGhl IHdhbGsuICovCisJaWYgKCFyZXQgJiYgZG9fdGRiX2RlbGV0ZShjb25uLCAm a2V5LCAmbm9kZS0+YWNjKSkKKwkJcmV0dXJuIFdBTEtfVFJFRV9TVUNDRVNT X1NUT1A7CiAKIAkvKgogCSAqIEZpcmUgdGhlIHdhdGNoZXMgbm93LCB3aGVu IHdlIGNhbiBzdGlsbCBzZWUgdGhlIG5vZGUgcGVybWlzc2lvbnMuCiAJICog VGhpcyBmaW5lIGFzIHdlIGFyZSBzaW5nbGUgdGhyZWFkZWQgYW5kIHRoZSBu ZXh0IHBvc3NpYmxlIHJlYWQgd2lsbAogCSAqIGJlIGhhbmRsZWQgb25seSBh ZnRlciB0aGUgbm9kZSBoYXMgYmVlbiByZWFsbHkgcmVtb3ZlZC4KLQkgKi8K KwkqLworCXdhdGNoX2V4YWN0ID0gc3RyY21wKHJvb3QsIG5vZGUtPm5hbWUp OwogCWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5vZGUtPm5hbWUsIG5vZGUs IHdhdGNoX2V4YWN0LCBOVUxMKTsKLQlkZWxldGVfbm9kZV9zaW5nbGUoY29u biwgbm9kZSk7Ci0JZGVsZXRlX2NoaWxkKGNvbm4sIHBhcmVudCwgYmFzZW5h bWUobm9kZS0+bmFtZSkpOwotCXRhbGxvY19mcmVlKG5vZGUpOwogCi0JcmV0 dXJuIDA7CisJZG9tYWluX2VudHJ5X2RlYyhjb25uLCBub2RlKTsKKworCXJl dHVybiBXQUxLX1RSRUVfUk1fQ0hJTERFTlRSWTsKIH0KIAotc3RhdGljIGlu dCBfcm0oc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0 eCwgc3RydWN0IG5vZGUgKm5vZGUsCi0JICAgICAgIGNvbnN0IGNoYXIgKm5h bWUpCitzdGF0aWMgaW50IF9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3Qgdm9pZCAqY3R4LCBjb25zdCBjaGFyICpuYW1lKQogewotCS8qCi0J ICogRGVsZXRpbmcgbm9kZSBieSBub2RlLCBzbyB0aGUgcmVzdWx0IGlzIGFs d2F5cyBjb25zaXN0ZW50IGV2ZW4gaW4KLQkgKiBjYXNlIG9mIGEgZmFpbHVy ZS4KLQkgKi8KIAlzdHJ1Y3Qgbm9kZSAqcGFyZW50OwogCWNoYXIgKnBhcmVu dG5hbWUgPSBnZXRfcGFyZW50KGN0eCwgbmFtZSk7CisJc3RydWN0IHdhbGtf ZnVuY3Mgd2Fsa2Z1bmNzID0geyAuZXhpdCA9IGRlbG5vZGVfc3ViIH07CisJ aW50IHJldDsKIAogCWlmICghcGFyZW50bmFtZSkKIAkJcmV0dXJuIGVycm5v OwpAQCAtMTY4NSw5ICsxNjYwLDIxIEBAIHN0YXRpYyBpbnQgX3JtKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBu b2RlICpub2RlLAogCXBhcmVudCA9IHJlYWRfbm9kZShjb25uLCBjdHgsIHBh cmVudG5hbWUpOwogCWlmICghcGFyZW50KQogCQlyZXR1cm4gcmVhZF9ub2Rl X2Nhbl9wcm9wYWdhdGVfZXJybm8oKSA/IGVycm5vIDogRUlOVkFMOwotCW5v ZGUtPnBhcmVudCA9IHBhcmVudDsKIAotCXJldHVybiBkZWxldGVfbm9kZShj b25uLCBjdHgsIHBhcmVudCwgbm9kZSwgZmFsc2UpOworCXJldCA9IHdhbGtf bm9kZV90cmVlKGN0eCwgY29ubiwgbmFtZSwgJndhbGtmdW5jcywgKHZvaWQg KiluYW1lKTsKKwlpZiAocmV0IDwgMCkgeworCQlpZiAocmV0ID09IFdBTEtf VFJFRV9FUlJPUl9TVE9QKSB7CisJCQljb3JydXB0KGNvbm4sICJlcnJvciB3 aGVuIGRlbGV0aW5nIHN1Yi1ub2RlcyBvZiAlc1xuIiwKKwkJCQluYW1lKTsK KwkJCWVycm5vID0gRUlPOworCQl9CisJCXJldHVybiBlcnJubzsKKwl9CisK KwlpZiAoZGVsZXRlX2NoaWxkKGNvbm4sIHBhcmVudCwgYmFzZW5hbWUobmFt ZSkpKQorCQlyZXR1cm4gZXJybm87CisKKwlyZXR1cm4gMDsKIH0KIAogCkBA IC0xNzI0LDcgKzE3MTEsNyBAQCBzdGF0aWMgaW50IGRvX3JtKGNvbnN0IHZv aWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJaWYgKHN0cmVx KG5hbWUsICIvIikpCiAJCXJldHVybiBFSU5WQUw7CiAKLQlyZXQgPSBfcm0o Y29ubiwgY3R4LCBub2RlLCBuYW1lKTsKKwlyZXQgPSBfcm0oY29ubiwgY3R4 LCBuYW1lKTsKIAlpZiAocmV0KQogCQlyZXR1cm4gcmV0OwogCg== --=separator Content-Type: application/octet-stream; name="xsa418/xsa418-07.patch" Content-Disposition: attachment; filename="xsa418/xsa418-07.patch" Content-Transfer-Encoding: base64 RnJvbSA3NDJiOGIzZTRjMmY3NzVlNDc4MTk3NTRjYTkxNGU2MWFhYTA3OGMz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHVzZSB0cmVl d2FsayBmb3IgY3JlYXRpbmcgbm9kZSByZWNvcmRzCgpJbnN0ZWFkIG9mIGRv aW5nIGFuIG9wZW4gdHJlZSB3YWxrIHVzaW5nIGNhbGwgcmVjdXJzaW9uLCB1 c2UKd2Fsa19ub2RlX3RyZWUoKSB3aGVuIGNyZWF0aW5nIHRoZSBub2RlIHJl Y29yZHMgZHVyaW5nIGEgbGl2ZSB1cGRhdGUuCgpUaGlzIHdpbGwgcmVkdWNl IGNvZGUgc2l6ZSBhbmQgYXZvaWQgbWFueSBuZXN0aW5nIGxldmVscyBvZiBm dW5jdGlvbgpjYWxscyB3aGljaCBjb3VsZCBwb3RlbnRpYWxseSBleGhhdXN0 IHRoZSBzdGFjay4KClRoaXMgaXMgcGFydCBvZiBYU0EtNDE4IC8gQ1ZFLTIw MjItNDIzMjEuCgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxkdnJhYmVs QGFtYXpvbi5jby51az4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8 amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxq Z3JhbGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2NvcmUuYwppbmRleCBmYTI0YmNmZWE0ZmIuLmJkYzE0Njc5YWRmNSAxMDA2 NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0zMDg4LDEw MSArMzA4OCw3NiBAQCBjb25zdCBjaGFyICpkdW1wX3N0YXRlX25vZGVfcGVy bXMoRklMRSAqZnAsIGNvbnN0IHN0cnVjdCB4c19wZXJtaXNzaW9ucyAqcGVy bXMsCiAJcmV0dXJuIE5VTEw7CiB9CiAKLXN0YXRpYyBjb25zdCBjaGFyICpk dW1wX3N0YXRlX25vZGVfdHJlZShGSUxFICpmcCwgY2hhciAqcGF0aCwKLQkJ CQkJdW5zaWduZWQgaW50IHBhdGhfbWF4X2xlbikKK3N0cnVjdCBkdW1wX25v ZGVfZGF0YSB7CisJRklMRSAqZnA7CisJY29uc3QgY2hhciAqZXJyOworfTsK Kworc3RhdGljIGludCBkdW1wX3N0YXRlX25vZGVfZXJyKHN0cnVjdCBkdW1w X25vZGVfZGF0YSAqZGF0YSwgY29uc3QgY2hhciAqZXJyKQogewotCXVuc2ln bmVkIGludCBwYXRobGVuLCBjaGlsZGxlbiwgcCA9IDA7CisJZGF0YS0+ZXJy ID0gZXJyOworCXJldHVybiBXQUxLX1RSRUVfRVJST1JfU1RPUDsKK30KKwor c3RhdGljIGludCBkdW1wX3N0YXRlX25vZGUoY29uc3Qgdm9pZCAqY3R4LCBz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJCSAgIHN0cnVjdCBub2RlICpu b2RlLCB2b2lkICphcmcpCit7CisJc3RydWN0IGR1bXBfbm9kZV9kYXRhICpk YXRhID0gYXJnOworCUZJTEUgKmZwID0gZGF0YS0+ZnA7CisJdW5zaWduZWQg aW50IHBhdGhsZW47CiAJc3RydWN0IHhzX3N0YXRlX3JlY29yZF9oZWFkZXIg aGVhZDsKIAlzdHJ1Y3QgeHNfc3RhdGVfbm9kZSBzbjsKLQlUREJfREFUQSBr ZXksIGRhdGE7Ci0JY29uc3Qgc3RydWN0IHhzX3RkYl9yZWNvcmRfaGRyICpo ZHI7Ci0JY29uc3QgY2hhciAqY2hpbGQ7CiAJY29uc3QgY2hhciAqcmV0Owog Ci0JcGF0aGxlbiA9IHN0cmxlbihwYXRoKSArIDE7Ci0KLQlzZXRfdGRiX2tl eShwYXRoLCAma2V5KTsKLQlkYXRhID0gdGRiX2ZldGNoKHRkYl9jdHgsIGtl eSk7Ci0JaWYgKGRhdGEuZHB0ciA9PSBOVUxMKQotCQlyZXR1cm4gIkVycm9y IHJlYWRpbmcgbm9kZSI7Ci0KLQkvKiBDbGVhbiB1cCBpbiBjYXNlIG9mIGZh aWx1cmUuICovCi0JdGFsbG9jX3N0ZWFsKHBhdGgsIGRhdGEuZHB0cik7Ci0K LQloZHIgPSAodm9pZCAqKWRhdGEuZHB0cjsKKwlwYXRobGVuID0gc3RybGVu KG5vZGUtPm5hbWUpICsgMTsKIAogCWhlYWQudHlwZSA9IFhTX1NUQVRFX1RZ UEVfTk9ERTsKIAloZWFkLmxlbmd0aCA9IHNpemVvZihzbik7CiAJc24uY29u bl9pZCA9IDA7CiAJc24udGFfaWQgPSAwOwogCXNuLnRhX2FjY2VzcyA9IDA7 Ci0Jc24ucGVybV9uID0gaGRyLT5udW1fcGVybXM7CisJc24ucGVybV9uID0g bm9kZS0+cGVybXMubnVtOwogCXNuLnBhdGhfbGVuID0gcGF0aGxlbjsKLQlz bi5kYXRhX2xlbiA9IGhkci0+ZGF0YWxlbjsKLQloZWFkLmxlbmd0aCArPSBo ZHItPm51bV9wZXJtcyAqIHNpemVvZigqc24ucGVybXMpOworCXNuLmRhdGFf bGVuID0gbm9kZS0+ZGF0YWxlbjsKKwloZWFkLmxlbmd0aCArPSBub2RlLT5w ZXJtcy5udW0gKiBzaXplb2YoKnNuLnBlcm1zKTsKIAloZWFkLmxlbmd0aCAr PSBwYXRobGVuOwotCWhlYWQubGVuZ3RoICs9IGhkci0+ZGF0YWxlbjsKKwlo ZWFkLmxlbmd0aCArPSBub2RlLT5kYXRhbGVuOwogCWhlYWQubGVuZ3RoID0g Uk9VTkRVUChoZWFkLmxlbmd0aCwgMyk7CiAKIAlpZiAoZndyaXRlKCZoZWFk LCBzaXplb2YoaGVhZCksIDEsIGZwKSAhPSAxKQotCQlyZXR1cm4gIkR1bXAg bm9kZSBzdGF0ZSBlcnJvciI7CisJCXJldHVybiBkdW1wX3N0YXRlX25vZGVf ZXJyKGRhdGEsICJEdW1wIG5vZGUgaGVhZCBlcnJvciIpOwogCWlmIChmd3Jp dGUoJnNuLCBzaXplb2Yoc24pLCAxLCBmcCkgIT0gMSkKLQkJcmV0dXJuICJE dW1wIG5vZGUgc3RhdGUgZXJyb3IiOworCQlyZXR1cm4gZHVtcF9zdGF0ZV9u b2RlX2VycihkYXRhLCAiRHVtcCBub2RlIHN0YXRlIGVycm9yIik7CiAKLQly ZXQgPSBkdW1wX3N0YXRlX25vZGVfcGVybXMoZnAsIGhkci0+cGVybXMsIGhk ci0+bnVtX3Blcm1zKTsKKwlyZXQgPSBkdW1wX3N0YXRlX25vZGVfcGVybXMo ZnAsIG5vZGUtPnBlcm1zLnAsIG5vZGUtPnBlcm1zLm51bSk7CiAJaWYgKHJl dCkKLQkJcmV0dXJuIHJldDsKKwkJcmV0dXJuIGR1bXBfc3RhdGVfbm9kZV9l cnIoZGF0YSwgcmV0KTsKKworCWlmIChmd3JpdGUobm9kZS0+bmFtZSwgcGF0 aGxlbiwgMSwgZnApICE9IDEpCisJCXJldHVybiBkdW1wX3N0YXRlX25vZGVf ZXJyKGRhdGEsICJEdW1wIG5vZGUgcGF0aCBlcnJvciIpOwogCi0JaWYgKGZ3 cml0ZShwYXRoLCBwYXRobGVuLCAxLCBmcCkgIT0gMSkKLQkJcmV0dXJuICJE dW1wIG5vZGUgcGF0aCBlcnJvciI7Ci0JaWYgKGhkci0+ZGF0YWxlbiAmJgot CSAgICBmd3JpdGUoaGRyLT5wZXJtcyArIGhkci0+bnVtX3Blcm1zLCBoZHIt PmRhdGFsZW4sIDEsIGZwKSAhPSAxKQotCQlyZXR1cm4gIkR1bXAgbm9kZSBk YXRhIGVycm9yIjsKKwlpZiAobm9kZS0+ZGF0YWxlbiAmJiBmd3JpdGUobm9k ZS0+ZGF0YSwgbm9kZS0+ZGF0YWxlbiwgMSwgZnApICE9IDEpCisJCXJldHVy biBkdW1wX3N0YXRlX25vZGVfZXJyKGRhdGEsICJEdW1wIG5vZGUgZGF0YSBl cnJvciIpOwogCiAJcmV0ID0gZHVtcF9zdGF0ZV9hbGlnbihmcCk7CiAJaWYg KHJldCkKLQkJcmV0dXJuIHJldDsKKwkJcmV0dXJuIGR1bXBfc3RhdGVfbm9k ZV9lcnIoZGF0YSwgcmV0KTsKIAotCWNoaWxkID0gKGNoYXIgKikoaGRyLT5w ZXJtcyArIGhkci0+bnVtX3Blcm1zKSArIGhkci0+ZGF0YWxlbjsKLQotCS8q Ci0JICogVXNlIHBhdGggZm9yIGNvbnN0cnVjdGluZyBjaGlsZHJlbiBwYXRo cy4KLQkgKiBBcyB3ZSBkb24ndCB3cml0ZSBvdXQgbm9kZXMgd2l0aG91dCBo YXZpbmcgd3JpdHRlbiB0aGVpciBwYXJlbnQKLQkgKiBhbHJlYWR5IHdlIHdp bGwgbmV2ZXIgY2xvYmJlciBhIHBhcnQgb2YgdGhlIHBhdGggd2UnbGwgbmVl ZCBsYXRlci4KLQkgKi8KLQlwYXRobGVuLS07Ci0JaWYgKHBhdGhbcGF0aGxl biAtIDFdICE9ICcvJykgewotCQlwYXRoW3BhdGhsZW5dID0gJy8nOwotCQlw YXRobGVuKys7Ci0JfQotCXdoaWxlIChwIDwgaGRyLT5jaGlsZGxlbikgewot CQljaGlsZGxlbiA9IHN0cmxlbihjaGlsZCkgKyAxOwotCQlpZiAocGF0aGxl biArIGNoaWxkbGVuID4gcGF0aF9tYXhfbGVuKQotCQkJcmV0dXJuICJEdW1w IG5vZGUgcGF0aCBsZW5ndGggZXJyb3IiOwotCQlzdHJjcHkocGF0aCArIHBh dGhsZW4sIGNoaWxkKTsKLQkJcmV0ID0gZHVtcF9zdGF0ZV9ub2RlX3RyZWUo ZnAsIHBhdGgsIHBhdGhfbWF4X2xlbik7Ci0JCWlmIChyZXQpCi0JCQlyZXR1 cm4gcmV0OwotCQlwICs9IGNoaWxkbGVuOwotCQljaGlsZCArPSBjaGlsZGxl bjsKLQl9Ci0KLQl0YWxsb2NfZnJlZShkYXRhLmRwdHIpOwotCi0JcmV0dXJu IE5VTEw7CisJcmV0dXJuIFdBTEtfVFJFRV9PSzsKIH0KIAogY29uc3QgY2hh ciAqZHVtcF9zdGF0ZV9ub2RlcyhGSUxFICpmcCwgY29uc3Qgdm9pZCAqY3R4 KQogewotCWNoYXIgKnBhdGg7Ci0KLQlwYXRoID0gdGFsbG9jX3NpemUoY3R4 LCBYRU5TVE9SRV9BQlNfUEFUSF9NQVggKyAxKTsKLQlpZiAoIXBhdGgpCi0J CXJldHVybiAiUGF0aCBidWZmZXIgYWxsb2NhdGlvbiBlcnJvciI7CisJc3Ry dWN0IGR1bXBfbm9kZV9kYXRhIGRhdGEgPSB7CisJCS5mcCA9IGZwLAorCQku ZXJyID0gIkR1bXAgbm9kZSB3YWxrIGVycm9yIgorCX07CisJc3RydWN0IHdh bGtfZnVuY3Mgd2Fsa2Z1bmNzID0geyAuZW50ZXIgPSBkdW1wX3N0YXRlX25v ZGUgfTsKIAotCXN0cmNweShwYXRoLCAiLyIpOworCWlmICh3YWxrX25vZGVf dHJlZShjdHgsIE5VTEwsICIvIiwgJndhbGtmdW5jcywgJmRhdGEpKQorCQly ZXR1cm4gZGF0YS5lcnI7CiAKLQlyZXR1cm4gZHVtcF9zdGF0ZV9ub2RlX3Ry ZWUoZnAsIHBhdGgsIFhFTlNUT1JFX0FCU19QQVRIX01BWCArIDEpOworCXJl dHVybiBOVUxMOwogfQogCiB2b2lkIHJlYWRfc3RhdGVfZ2xvYmFsKGNvbnN0 IHZvaWQgKmN0eCwgY29uc3Qgdm9pZCAqc3RhdGUpCg== --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Nov 01 12:01:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 12:01:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433491.686601 (Exim 4.92) (envelope-from ) id 1oppxB-0000HS-Ow; Tue, 01 Nov 2022 12:01:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433491.686601; Tue, 01 Nov 2022 12:01:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppxA-0000E6-JD; Tue, 01 Nov 2022 12:01:12 +0000 Received: by outflank-mailman (input) for mailman id 433491; Tue, 01 Nov 2022 12:01:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppx1-0004vc-TN for xen-devel@lists.xen.org; Tue, 01 Nov 2022 12:01:04 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d5b0e54b-59dc-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 13:00:55 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppwh-0005XA-1h; Tue, 01 Nov 2022 12:00:43 +0000 Received: from jgross by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oppwh-0005OH-0o; Tue, 01 Nov 2022 12:00:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5b0e54b-59dc-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=cYWLXiz72JZLCDESZftqFXmN8rvmSaPJT54jKoMnGiI=; b=lfJC+7HQv5FNwZeX8lO02aSbcZ cFDTosRIBRSRORV0Gq07MloOrfVKm69/zFcAtqUa19/TCDkbxfX5VdzuDQr5PyPC0DehGk/Tu1QTJ rpPhRdJkuFGsDU+hbAvQ2ShPOngk2U+nKXvzxjH0LWqYzxSFBsAUs89wYGjudFc4MELg=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 412 v2 (CVE-2022-42327) - x86: unintended memory sharing between guests Message-Id: Date: Tue, 01 Nov 2022 12:00:43 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-42327 / XSA-412 version 2 x86: unintended memory sharing between guests UPDATES IN VERSION 2 ==================== Public release. ISSUE DESCRIPTION ================= On Intel systems that support the "virtualize APIC accesses" feature, a guest can read and write the global shared xAPIC page by moving the local APIC out of xAPIC mode. Access to this shared page bypasses the expected isolation that should exist between two guests. IMPACT ====== Guests are able to access an unintended shared memory page. Note the contents of the page are not interpreted by Xen or hardware. VULNERABLE SYSTEMS ================== Only Xen version 4.16 is vulnerable. Other Xen versions are not vulnerable. x86 HVM or PVH guests running on Intel systems with the "virtualize APIC accesses" feature are affected. This is believed to be all 64-bit capable Intel CPUs. x86 HVM or PVH guests running on AMD hardware, Arm or x86 PV guests are not affected. MITIGATION ========== Only running PV guests will mitigate the vulnerability on affected hardware. CREDITS ======= This issue was discovered by Andrew Cooper of Citrix. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa412.patch xen-unstable xsa412-4.16.patch Xen 4.16.x $ sha256sum xsa412* 64107d4a185dc3cdbc59400d724fe2ada490d39c14ab354aa73bb67a94ca0f65 xsa412.meta 425c1cc3e25f67746a3074aa6304dd0d915f503ea57440b9ecdb583e1547a8fe xsa412.patch b030bebbc4798e1d1ad75d763294ce25609f9f895402272a1f354d781f6f5f00 xsa412-4.16.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNg+5sMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZF10H/2C2pgVmiJWW6iZNMTDHuV4EyZJTFPCBnKR3qirj 3fffRN15gjzPLZZH+Ivwj3ZeWyQBLkGqC1EFemLtWpQePYlcRoH4mCyE4jc8dx89 Ejh2Zfaib0GIJoHqqDYnRQV8/BusGjIRNgWG2zAEuj+ElHRYtXcd4G5/swtcmKyN /lSn5VMVrTGdfyGmQtcou24fK5sfzDrfCJm8pThUT6x+ERAUtCYWx2SG3fA1x55R hWc846qJPXay/BOI0F/d23QkOP+jZsCjhbe+xnTEfgGEq32ZvwhFgkz1/DuXHl0j hBrWjRzhLd8+mCmnXeXURDHbPmyg47TDsSg4n1VeRBJUKrc= =as4H -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa412.meta" Content-Disposition: attachment; filename="xsa412.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MTIsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4 ZW4iCiAgXSwKICAiUmVjaXBlcyI6IHsKICAgICI0LjE2IjogewogICAgICAi UmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJs ZVJlZiI6ICIxYmNlN2ZiMWY3MDJkYTRmN2E3NDljNmYxNDU3ZWNiMjBiZjc0 ZmNhIiwKICAgICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0 Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQxMi00LjE2LnBhdGNoIgogICAg ICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICJtYXN0ZXIi OiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4iOiB7CiAgICAg ICAgICAiU3RhYmxlUmVmIjogImNjNDc0N2JlOGJhMTU3YTNiMzEwOTIxZTll ZTA3ZmI4NTQ1YWEyMDYiLAogICAgICAgICAgIlByZXJlcXMiOiBbXSwKICAg ICAgICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhNDEyLnBhdGNo IgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfQogIH0KfQ== --=separator Content-Type: application/octet-stream; name="xsa412.patch" Content-Disposition: attachment; filename="xsa412.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3ZteDogUmV2ZXJ0ICJWTVg6IHVzZSBhIHNpbmds ZSwgZ2xvYmFsIEFQSUMgYWNjZXNzIHBhZ2UiCgpUaGUgY2xhaW0gIk5vIGFj Y2Vzc2VzIHdvdWxkIGV2ZXIgZ28gdG8gdGhpcyBwYWdlLiIgaXMgZmFsc2Uu ICBBIGNvbnNlcXVlbmNlCm9mIGhvdyBJbnRlbCdzIEFQSUMgQWNjZWxlcmF0 aW9uIHdvcmtzLCBhbmQgWGVuJ3MgY2hvaWNlIHRvIGhhdmUgcGVyLWRvbWFp bgpQMk1zIChyYXRoZXIgdGhhbiBwZXItdkNQVSBQMk1zKSBtZWFucyB0aGF0 IHRoZSBBUElDIHBhZ2UgaXMgZnVsbHkgcmVhZC13cml0ZQp0byBhbnkgdkNQ VSB3aGljaCBpcyBub3QgaW4geEFQSUMgbW9kZS4KClRoaXMgcmV2ZXJ0cyBj b21taXQgNTg4NTBiOTA3NGQzZTdhZmZkZjNiYzk0Yzg0ZTQxN2VjZmE0ZDE2 NS4KClRoaXMgaXMgWFNBLTQxMiAvIENWRS0yMDIyLTQyMzI3LgoKU2lnbmVk LW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4 LmNvbT4KUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl LmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3ZteC92bXgu YyBiL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jCmluZGV4IDE3ZTEwMzE4 OGE1My4uZTYyNGI0MTVjOTEzIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYv aHZtL3ZteC92bXguYworKysgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bXgu YwpAQCAtNjYsNyArNjYsOCBAQCBib29sZWFuX3BhcmFtKCJmb3JjZS1lcHQi LCBvcHRfZm9yY2VfZXB0KTsKIHN0YXRpYyB2b2lkIGNmX2NoZWNrIHZteF9j dHh0X3N3aXRjaF9mcm9tKHN0cnVjdCB2Y3B1ICp2KTsKIHN0YXRpYyB2b2lk IGNmX2NoZWNrIHZteF9jdHh0X3N3aXRjaF90byhzdHJ1Y3QgdmNwdSAqdik7 CiAKLXN0YXRpYyBpbnQgYWxsb2NfdmxhcGljX21hcHBpbmcodm9pZCk7Citz dGF0aWMgaW50ICB2bXhfYWxsb2NfdmxhcGljX21hcHBpbmcoc3RydWN0IGRv bWFpbiAqZCk7CitzdGF0aWMgdm9pZCB2bXhfZnJlZV92bGFwaWNfbWFwcGlu ZyhzdHJ1Y3QgZG9tYWluICpkKTsKIHN0YXRpYyB2b2lkIHZteF9pbnN0YWxs X3ZsYXBpY19tYXBwaW5nKHN0cnVjdCB2Y3B1ICp2KTsKIHN0YXRpYyB2b2lk IGNmX2NoZWNrIHZteF91cGRhdGVfZ3Vlc3RfY3IoCiAgICAgc3RydWN0IHZj cHUgKnYsIHVuc2lnbmVkIGludCBjciwgdW5zaWduZWQgaW50IGZsYWdzKTsK QEAgLTc5LDggKzgwLDYgQEAgc3RhdGljIGludCBjZl9jaGVjayB2bXhfbXNy X3dyaXRlX2ludGVyY2VwdCgKICAgICB1bnNpZ25lZCBpbnQgbXNyLCB1aW50 NjRfdCBtc3JfY29udGVudCk7CiBzdGF0aWMgdm9pZCBjZl9jaGVjayB2bXhf aW52bHBnKHN0cnVjdCB2Y3B1ICp2LCB1bnNpZ25lZCBsb25nIGxpbmVhcik7 CiAKLXN0YXRpYyBtZm5fdCBfX3JlYWRfbW9zdGx5IGFwaWNfYWNjZXNzX21m biA9IElOVkFMSURfTUZOX0lOSVRJQUxJWkVSOwotCiAvKiBWYWx1ZXMgZm9y IGRvbWFpbidzIC0+YXJjaC5odm1fZG9tYWluLnBpX29wcy5mbGFncy4gKi8K ICNkZWZpbmUgUElfQ1NXX0ZST00gKDF1IDw8IDApCiAjZGVmaW5lIFBJX0NT V19UTyAgICgxdSA8PCAxKQpAQCAtNDA0LDYgKzQwMyw3IEBAIHN0YXRpYyBp bnQgY2ZfY2hlY2sgdm14X2RvbWFpbl9pbml0aWFsaXNlKHN0cnVjdCBkb21h aW4gKmQpCiAgICAgICAgIC50byAgID0gdm14X2N0eHRfc3dpdGNoX3RvLAog ICAgICAgICAudGFpbCA9IHZteF9kb19yZXN1bWUsCiAgICAgfTsKKyAgICBp bnQgcmM7CiAKICAgICBkLT5hcmNoLmN0eHRfc3dpdGNoID0gJmNzdzsKIApA QCAtNDEzLDE1ICs0MTMsMjQgQEAgc3RhdGljIGludCBjZl9jaGVjayB2bXhf ZG9tYWluX2luaXRpYWxpc2Uoc3RydWN0IGRvbWFpbiAqZCkKICAgICAgKi8K ICAgICBkLT5hcmNoLmh2bS52bXguZXhlY19zcCA9IGlzX2hhcmR3YXJlX2Rv bWFpbihkKSB8fCBvcHRfZXB0X2V4ZWNfc3A7CiAKKyAgICBpZiAoIChyYyA9 IHZteF9hbGxvY192bGFwaWNfbWFwcGluZyhkKSkgIT0gMCApCisgICAgICAg IHJldHVybiByYzsKKwogICAgIHJldHVybiAwOwogfQogCitzdGF0aWMgdm9p ZCBjZl9jaGVjayB2bXhfZG9tYWluX3JlbGlucXVpc2hfcmVzb3VyY2VzKHN0 cnVjdCBkb21haW4gKmQpCit7CisgICAgdm14X2ZyZWVfdmxhcGljX21hcHBp bmcoZCk7Cit9CisKIHN0YXRpYyB2b2lkIGNmX2NoZWNrIGRvbWFpbl9jcmVh dGlvbl9maW5pc2hlZChzdHJ1Y3QgZG9tYWluICpkKQogewogICAgIGdmbl90 IGdmbiA9IGdhZGRyX3RvX2dmbihBUElDX0RFRkFVTFRfUEhZU19CQVNFKTsK KyAgICBtZm5fdCBhcGljX2FjY2Vzc19tZm4gPSBkLT5hcmNoLmh2bS52bXgu YXBpY19hY2Nlc3NfbWZuOwogICAgIGJvb2wgaXBhdDsKIAotICAgIGlmICgg bWZuX2VxKGFwaWNfYWNjZXNzX21mbiwgSU5WQUxJRF9NRk4pICkKKyAgICBp ZiAoIG1mbl9lcShhcGljX2FjY2Vzc19tZm4sIF9tZm4oMCkpICkKICAgICAg ICAgcmV0dXJuOwogCiAgICAgQVNTRVJUKGVwdGVfZ2V0X2VudHJ5X2VtdChk LCBnZm4sIGFwaWNfYWNjZXNzX21mbiwgMCwgJmlwYXQsCkBAIC0yNTEwLDYg KzI1MTksNyBAQCBzdGF0aWMgc3RydWN0IGh2bV9mdW5jdGlvbl90YWJsZSBf X2luaXRkYXRhX2NmX2Nsb2JiZXIgdm14X2Z1bmN0aW9uX3RhYmxlID0gewog ICAgIC5jcHVfdXBfcHJlcGFyZSAgICAgICA9IHZteF9jcHVfdXBfcHJlcGFy ZSwKICAgICAuY3B1X2RlYWQgICAgICAgICAgICAgPSB2bXhfY3B1X2RlYWQs CiAgICAgLmRvbWFpbl9pbml0aWFsaXNlICAgID0gdm14X2RvbWFpbl9pbml0 aWFsaXNlLAorICAgIC5kb21haW5fcmVsaW5xdWlzaF9yZXNvdXJjZXMgPSB2 bXhfZG9tYWluX3JlbGlucXVpc2hfcmVzb3VyY2VzLAogICAgIC5kb21haW5f Y3JlYXRpb25fZmluaXNoZWQgPSBkb21haW5fY3JlYXRpb25fZmluaXNoZWQs CiAgICAgLnZjcHVfaW5pdGlhbGlzZSAgICAgID0gdm14X3ZjcHVfaW5pdGlh bGlzZSwKICAgICAudmNwdV9kZXN0cm95ICAgICAgICAgPSB2bXhfdmNwdV9k ZXN0cm95LApAQCAtMjc2MCw3ICsyNzcwLDcgQEAgY29uc3Qgc3RydWN0IGh2 bV9mdW5jdGlvbl90YWJsZSAqIF9faW5pdCBzdGFydF92bXgodm9pZCkKIHsK ICAgICBzZXRfaW5fY3I0KFg4Nl9DUjRfVk1YRSk7CiAKLSAgICBpZiAoIHZt eF92bWNzX2luaXQoKSB8fCBhbGxvY192bGFwaWNfbWFwcGluZygpICkKKyAg ICBpZiAoIHZteF92bWNzX2luaXQoKSApCiAgICAgewogICAgICAgICBwcmlu dGsoIlZNWDogZmFpbGVkIHRvIGluaXRpYWxpc2UuXG4iKTsKICAgICAgICAg cmV0dXJuIE5VTEw7CkBAIC0zMzMxLDM2ICszMzQxLDU1IEBAIHN0YXRpYyBp bnQgY2ZfY2hlY2sgdm14X21zcl9yZWFkX2ludGVyY2VwdCgKICAgICByZXR1 cm4gWDg2RU1VTF9FWENFUFRJT047CiB9CiAKLXN0YXRpYyBpbnQgX19pbml0 IGFsbG9jX3ZsYXBpY19tYXBwaW5nKHZvaWQpCitzdGF0aWMgaW50IHZteF9h bGxvY192bGFwaWNfbWFwcGluZyhzdHJ1Y3QgZG9tYWluICpkKQogewogICAg IHN0cnVjdCBwYWdlX2luZm8gKnBnOwogICAgIG1mbl90IG1mbjsKIAotICAg IGlmICggIWNwdV9oYXNfdm14X3ZpcnR1YWxpemVfYXBpY19hY2Nlc3NlcyAp CisgICAgaWYgKCAhaGFzX3ZsYXBpYyhkKSB8fCAhY3B1X2hhc192bXhfdmly dHVhbGl6ZV9hcGljX2FjY2Vzc2VzICkKICAgICAgICAgcmV0dXJuIDA7CiAK LSAgICBwZyA9IGFsbG9jX2RvbWhlYXBfcGFnZShOVUxMLCAwKTsKKyAgICBw ZyA9IGFsbG9jX2RvbWhlYXBfcGFnZShkLCBNRU1GX25vX3JlZmNvdW50KTsK ICAgICBpZiAoICFwZyApCiAgICAgICAgIHJldHVybiAtRU5PTUVNOwogCi0g ICAgLyoKLSAgICAgKiBTaWduYWwgdG8gc2hhZG93IGNvZGUgdGhhdCB0aGlz IHBhZ2UgY2Fubm90IGJlIHJlZmNvdW50ZWQuIFRoaXMgYWxzbwotICAgICAq IG1ha2VzIGVwdGVfZ2V0X2VudHJ5X2VtdCgpIHJlY29nbml6ZSB0aGlzIHBh Z2UgYXMgInNwZWNpYWwiLgotICAgICAqLwotICAgIHBhZ2Vfc3VwcHJlc3Nf cmVmY291bnRpbmcocGcpOworICAgIGlmICggIWdldF9wYWdlX2FuZF90eXBl KHBnLCBkLCBQR1Rfd3JpdGFibGVfcGFnZSkgKQorICAgIHsKKyAgICAgICAg LyoKKyAgICAgICAgICogVGhlIGRvbWFpbiBjYW4ndCBwb3NzaWJseSBrbm93 IGFib3V0IHRoaXMgcGFnZSB5ZXQsIHNvIGZhaWx1cmUKKyAgICAgICAgICog aGVyZSBpcyBhIGNsZWFyIGluZGljYXRpb24gb2Ygc29tZXRoaW5nIGZpc2h5 IGdvaW5nIG9uLgorICAgICAgICAgKi8KKyAgICAgICAgZG9tYWluX2NyYXNo KGQpOworICAgICAgICByZXR1cm4gLUVOT0RBVEE7CisgICAgfQogCiAgICAg bWZuID0gcGFnZV90b19tZm4ocGcpOwogICAgIGNsZWFyX2RvbWFpbl9wYWdl KG1mbik7Ci0gICAgYXBpY19hY2Nlc3NfbWZuID0gbWZuOworICAgIGQtPmFy Y2guaHZtLnZteC5hcGljX2FjY2Vzc19tZm4gPSBtZm47CiAKICAgICByZXR1 cm4gMDsKIH0KIAorc3RhdGljIHZvaWQgdm14X2ZyZWVfdmxhcGljX21hcHBp bmcoc3RydWN0IGRvbWFpbiAqZCkKK3sKKyAgICBtZm5fdCBtZm4gPSBkLT5h cmNoLmh2bS52bXguYXBpY19hY2Nlc3NfbWZuOworCisgICAgZC0+YXJjaC5o dm0udm14LmFwaWNfYWNjZXNzX21mbiA9IF9tZm4oMCk7CisgICAgaWYgKCAh bWZuX2VxKG1mbiwgX21mbigwKSkgKQorICAgIHsKKyAgICAgICAgc3RydWN0 IHBhZ2VfaW5mbyAqcGcgPSBtZm5fdG9fcGFnZShtZm4pOworCisgICAgICAg IHB1dF9wYWdlX2FsbG9jX3JlZihwZyk7CisgICAgICAgIHB1dF9wYWdlX2Fu ZF90eXBlKHBnKTsKKyAgICB9Cit9CisKIHN0YXRpYyB2b2lkIHZteF9pbnN0 YWxsX3ZsYXBpY19tYXBwaW5nKHN0cnVjdCB2Y3B1ICp2KQogeworICAgIG1m bl90IGFwaWNfYWNjZXNzX21mbiA9IHYtPmRvbWFpbi0+YXJjaC5odm0udm14 LmFwaWNfYWNjZXNzX21mbjsKICAgICBwYWRkcl90IHZpcnRfcGFnZV9tYSwg YXBpY19wYWdlX21hOwogCi0gICAgaWYgKCBtZm5fZXEoYXBpY19hY2Nlc3Nf bWZuLCBJTlZBTElEX01GTikgKQorICAgIGlmICggbWZuX2VxKGFwaWNfYWNj ZXNzX21mbiwgX21mbigwKSkgKQogICAgICAgICByZXR1cm47CiAKICAgICBB U1NFUlQoY3B1X2hhc192bXhfdmlydHVhbGl6ZV9hcGljX2FjY2Vzc2VzKTsK ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9odm0vdm14 L3ZtY3MuaCBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9odm0vdm14L3Zt Y3MuaAppbmRleCA5MTE5YWE4NTM2ZGYuLjc1Zjk5MjhhYmZhZCAxMDA2NDQK LS0tIGEveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2h2bS92bXgvdm1jcy5o CisrKyBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9odm0vdm14L3ZtY3Mu aApAQCAtNTgsNiArNTgsNyBAQCBzdHJ1Y3QgZXB0X2RhdGEgewogI2RlZmlu ZSBfVk1YX0RPTUFJTl9QTUxfRU5BQkxFRCAgICAwCiAjZGVmaW5lIFZNWF9E T01BSU5fUE1MX0VOQUJMRUQgICAgICgxdWwgPDwgX1ZNWF9ET01BSU5fUE1M X0VOQUJMRUQpCiBzdHJ1Y3Qgdm14X2RvbWFpbiB7CisgICAgbWZuX3QgYXBp Y19hY2Nlc3NfbWZuOwogICAgIC8qIFZNWF9ET01BSU5fKiAqLwogICAgIHVu c2lnbmVkIGludCBzdGF0dXM7CiAKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4 Ni9pbmNsdWRlL2FzbS9tbS5oIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNt L21tLmgKaW5kZXggMGZjODI2ZGU0NmQ4Li5kNzIzYzdjMzhmMGUgMTAwNjQ0 Ci0tLSBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9tbS5oCisrKyBiL3hl bi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9tbS5oCkBAIC04Myw3ICs4Myw3IEBA CiAjZGVmaW5lIFBHQ19zdGF0ZV9vZmZsaW5lZCAgUEdfbWFzaygyLCA2KQog I2RlZmluZSBQR0Nfc3RhdGVfZnJlZSAgICAgIFBHX21hc2soMywgNikKICNk ZWZpbmUgcGFnZV9zdGF0ZV9pcyhwZywgc3QpICgoKHBnKS0+Y291bnRfaW5m byZQR0Nfc3RhdGUpID09IFBHQ19zdGF0ZV8jI3N0KQotLyogUGFnZSBpcyBu b3QgcmVmZXJlbmNlIGNvdW50ZWQgKHNlZSBiZWxvdyBmb3IgY2F2ZWF0cykg Ki8KKy8qIFBhZ2UgaXMgbm90IHJlZmVyZW5jZSBjb3VudGVkICovCiAjZGVm aW5lIF9QR0NfZXh0cmEgICAgICAgIFBHX3NoaWZ0KDcpCiAjZGVmaW5lIFBH Q19leHRyYSAgICAgICAgIFBHX21hc2soMSwgNykKIApAQCAtMzc1LDI0ICsz NzUsNiBAQCB2b2lkIHphcF9yb19tcHQobWZuX3QgbWZuKTsKIAogYm9vbCBp c19pb21lbV9wYWdlKG1mbl90IG1mbik7CiAKLS8qCi0gKiBQYWdlcyB3aXRo IG5vIG93bmVyIHdoaWNoIG1heSBnZXQgcGFzc2VkIHRvIGZ1bmN0aW9ucyB3 YW50aW5nIHRvCi0gKiByZWZjb3VudCB0aGVtIGNhbiBiZSBtYXJrZWQgUEdD X2V4dHJhIHRvIGJ5cGFzcyB0aGlzIHJlZmNvdW50aW5nICh3aGljaAotICog d291bGQgZmFpbCBkdWUgdG8gdGhlIGxhY2sgb2YgYW4gb3duZXIpLgotICoK LSAqIChGb3IgcGFnZXMgd2l0aCBvd25lciBQR0NfZXh0cmEgaGFzIGRpZmZl cmVudCBtZWFuaW5nLikKLSAqLwotc3RhdGljIGlubGluZSB2b2lkIHBhZ2Vf c3VwcHJlc3NfcmVmY291bnRpbmcoc3RydWN0IHBhZ2VfaW5mbyAqcGcpCi17 Ci0gICBBU1NFUlQoIXBhZ2VfZ2V0X293bmVyKHBnKSk7Ci0gICBwZy0+Y291 bnRfaW5mbyB8PSBQR0NfZXh0cmE7Ci19Ci0KLXN0YXRpYyBpbmxpbmUgYm9v bCBwYWdlX3JlZmNvdW50aW5nX3N1cHByZXNzZWQoY29uc3Qgc3RydWN0IHBh Z2VfaW5mbyAqcGcpCi17Ci0gICAgcmV0dXJuICFwYWdlX2dldF9vd25lcihw ZykgJiYgKHBnLT5jb3VudF9pbmZvICYgUEdDX2V4dHJhKTsKLX0KLQogc3Ry dWN0IHBsYXRmb3JtX2JhZF9wYWdlIHsKICAgICB1bnNpZ25lZCBsb25nIG1m bjsKICAgICB1bnNpZ25lZCBpbnQgb3JkZXI7CmRpZmYgLS1naXQgYS94ZW4v YXJjaC94ODYvbW0vc2hhZG93L3NldC5jIGIveGVuL2FyY2gveDg2L21tL3No YWRvdy9zZXQuYwppbmRleCA4N2U5YzZlZWIyMTkuLmJkNmM2OGI1NDdjOSAx MDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L21tL3NoYWRvdy9zZXQuYworKysg Yi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L3NldC5jCkBAIC0xMDEsMTQgKzEw MSw2IEBAIHNoYWRvd19nZXRfcGFnZV9mcm9tX2wxZShzaGFkb3dfbDFlX3Qg c2wxZSwgc3RydWN0IGRvbWFpbiAqZCwgcDJtX3R5cGVfdCB0eXBlKQogICAg ICAgICBvd25lciA9IHBhZ2VfZ2V0X293bmVyKHBnKTsKICAgICB9CiAKLSAg ICAvKgotICAgICAqIENoZWNrIHdoZXRoZXIgcmVmY291bnRpbmcgaXMgc3Vw cHJlc3NlZCBvbiB0aGlzIHBhZ2UuIEZvciBleGFtcGxlLAotICAgICAqIFZN WCdlcyBBUElDIGFjY2VzcyBNRk4gaXMganVzdCBhIHN1cnJvZ2F0ZSBwYWdl LiAgSXQgZG9lc24ndCBhY3R1YWxseQotICAgICAqIGdldCBhY2Nlc3NlZCwg YW5kIGhlbmNlIHRoZXJlJ3Mgbm8gbmVlZCB0byByZWZjb3VudCBpdC4KLSAg ICAgKi8KLSAgICBpZiAoIHBnICYmIHBhZ2VfcmVmY291bnRpbmdfc3VwcHJl c3NlZChwZykgKQotICAgICAgICByZXR1cm4gMDsKLQogICAgIGlmICggb3du ZXIgPT0gZG9tX2lvICkKICAgICAgICAgb3duZXIgPSBOVUxMOwogCmRpZmYg LS1naXQgYS94ZW4vYXJjaC94ODYvbW0vc2hhZG93L3R5cGVzLmggYi94ZW4v YXJjaC94ODYvbW0vc2hhZG93L3R5cGVzLmgKaW5kZXggNjk3MGU3ZDZlYTRh Li44MTRhNDAxODUzNWEgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9z aGFkb3cvdHlwZXMuaAorKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L3R5 cGVzLmgKQEAgLTI3NiwxNiArMjc2LDkgQEAgaW50IHNoYWRvd19zZXRfbDRl KHN0cnVjdCBkb21haW4gKmQsIHNoYWRvd19sNGVfdCAqc2w0ZSwKIHN0YXRp YyB2b2lkIGlubGluZQogc2hhZG93X3B1dF9wYWdlX2Zyb21fbDFlKHNoYWRv d19sMWVfdCBzbDFlLCBzdHJ1Y3QgZG9tYWluICpkKQogewotICAgIG1mbl90 IG1mbiA9IHNoYWRvd19sMWVfZ2V0X21mbihzbDFlKTsKLQogICAgIGlmICgg IXNoYWRvd19tb2RlX3JlZmNvdW50cyhkKSApCiAgICAgICAgIHJldHVybjsK IAotICAgIGlmICggbWZuX3ZhbGlkKG1mbikgJiYKLSAgICAgICAgIC8qIFNl ZSB0aGUgcmVzcGVjdGl2ZSBjb21tZW50IGluIHNoYWRvd19nZXRfcGFnZV9m cm9tX2wxZSgpLiAqLwotICAgICAgICAgcGFnZV9yZWZjb3VudGluZ19zdXBw cmVzc2VkKG1mbl90b19wYWdlKG1mbikpICkKLSAgICAgICAgcmV0dXJuOwot CiAgICAgcHV0X3BhZ2VfZnJvbV9sMWUoc2wxZSwgZCk7CiB9CiAK --=separator Content-Type: application/octet-stream; name="xsa412-4.16.patch" Content-Disposition: attachment; filename="xsa412-4.16.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3ZteDogUmV2ZXJ0ICJWTVg6IHVzZSBhIHNpbmds ZSwgZ2xvYmFsIEFQSUMgYWNjZXNzIHBhZ2UiCgpUaGUgY2xhaW0gIk5vIGFj Y2Vzc2VzIHdvdWxkIGV2ZXIgZ28gdG8gdGhpcyBwYWdlLiIgaXMgZmFsc2Uu ICBBIGNvbnNlcXVlbmNlCm9mIGhvdyBJbnRlbCdzIEFQSUMgQWNjZWxlcmF0 aW9uIHdvcmtzLCBhbmQgWGVuJ3MgY2hvaWNlIHRvIGhhdmUgcGVyLWRvbWFp bgpQMk1zIChyYXRoZXIgdGhhbiBwZXItdkNQVSBQMk1zKSBtZWFucyB0aGF0 IHRoZSBBUElDIHBhZ2UgaXMgZnVsbHkgcmVhZC13cml0ZQp0byBhbnkgdkNQ VSB3aGljaCBpcyBub3QgaW4geEFQSUMgbW9kZS4KClRoaXMgcmV2ZXJ0cyBj b21taXQgNTg4NTBiOTA3NGQzZTdhZmZkZjNiYzk0Yzg0ZTQxN2VjZmE0ZDE2 NS4KClRoaXMgaXMgWFNBLTQxMiAvIENWRS0yMDIyLTQyMzI3LgoKU2lnbmVk LW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4 LmNvbT4KUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl LmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3ZteC92bXgu YyBiL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jCmluZGV4IGQ0MjlkNzZj MThjOS4uM2Y0Mjc2NTMxMzIyIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYv aHZtL3ZteC92bXguYworKysgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bXgu YwpAQCAtNjYsNyArNjYsOCBAQCBib29sZWFuX3BhcmFtKCJmb3JjZS1lcHQi LCBvcHRfZm9yY2VfZXB0KTsKIHN0YXRpYyB2b2lkIHZteF9jdHh0X3N3aXRj aF9mcm9tKHN0cnVjdCB2Y3B1ICp2KTsKIHN0YXRpYyB2b2lkIHZteF9jdHh0 X3N3aXRjaF90byhzdHJ1Y3QgdmNwdSAqdik7CiAKLXN0YXRpYyBpbnQgYWxs b2NfdmxhcGljX21hcHBpbmcodm9pZCk7CitzdGF0aWMgaW50ICB2bXhfYWxs b2NfdmxhcGljX21hcHBpbmcoc3RydWN0IGRvbWFpbiAqZCk7CitzdGF0aWMg dm9pZCB2bXhfZnJlZV92bGFwaWNfbWFwcGluZyhzdHJ1Y3QgZG9tYWluICpk KTsKIHN0YXRpYyB2b2lkIHZteF9pbnN0YWxsX3ZsYXBpY19tYXBwaW5nKHN0 cnVjdCB2Y3B1ICp2KTsKIHN0YXRpYyB2b2lkIHZteF91cGRhdGVfZ3Vlc3Rf Y3Ioc3RydWN0IHZjcHUgKnYsIHVuc2lnbmVkIGludCBjciwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGZsYWdzKTsK QEAgLTc3LDggKzc4LDYgQEAgc3RhdGljIGludCB2bXhfbXNyX3JlYWRfaW50 ZXJjZXB0KHVuc2lnbmVkIGludCBtc3IsIHVpbnQ2NF90ICptc3JfY29udGVu dCk7CiBzdGF0aWMgaW50IHZteF9tc3Jfd3JpdGVfaW50ZXJjZXB0KHVuc2ln bmVkIGludCBtc3IsIHVpbnQ2NF90IG1zcl9jb250ZW50KTsKIHN0YXRpYyB2 b2lkIHZteF9pbnZscGcoc3RydWN0IHZjcHUgKnYsIHVuc2lnbmVkIGxvbmcg bGluZWFyKTsKIAotc3RhdGljIG1mbl90IF9fcmVhZF9tb3N0bHkgYXBpY19h Y2Nlc3NfbWZuID0gSU5WQUxJRF9NRk5fSU5JVElBTElaRVI7Ci0KIC8qIFZh bHVlcyBmb3IgZG9tYWluJ3MgLT5hcmNoLmh2bV9kb21haW4ucGlfb3BzLmZs YWdzLiAqLwogI2RlZmluZSBQSV9DU1dfRlJPTSAoMXUgPDwgMCkKICNkZWZp bmUgUElfQ1NXX1RPICAgKDF1IDw8IDEpCkBAIC00MDIsNiArNDAxLDcgQEAg c3RhdGljIGludCB2bXhfZG9tYWluX2luaXRpYWxpc2Uoc3RydWN0IGRvbWFp biAqZCkKICAgICAgICAgLnRvICAgPSB2bXhfY3R4dF9zd2l0Y2hfdG8sCiAg ICAgICAgIC50YWlsID0gdm14X2RvX3Jlc3VtZSwKICAgICB9OworICAgIGlu dCByYzsKIAogICAgIGQtPmFyY2guY3R4dF9zd2l0Y2ggPSAmY3N3OwogCkBA IC00MTEsMTUgKzQxMSwyNCBAQCBzdGF0aWMgaW50IHZteF9kb21haW5faW5p dGlhbGlzZShzdHJ1Y3QgZG9tYWluICpkKQogICAgICAqLwogICAgIGQtPmFy Y2guaHZtLnZteC5leGVjX3NwID0gaXNfaGFyZHdhcmVfZG9tYWluKGQpIHx8 IG9wdF9lcHRfZXhlY19zcDsKIAorICAgIGlmICggKHJjID0gdm14X2FsbG9j X3ZsYXBpY19tYXBwaW5nKGQpKSAhPSAwICkKKyAgICAgICAgcmV0dXJuIHJj OworCiAgICAgcmV0dXJuIDA7CiB9CiAKK3N0YXRpYyB2b2lkIHZteF9kb21h aW5fcmVsaW5xdWlzaF9yZXNvdXJjZXMoc3RydWN0IGRvbWFpbiAqZCkKK3sK KyAgICB2bXhfZnJlZV92bGFwaWNfbWFwcGluZyhkKTsKK30KKwogc3RhdGlj IHZvaWQgZG9tYWluX2NyZWF0aW9uX2ZpbmlzaGVkKHN0cnVjdCBkb21haW4g KmQpCiB7CiAgICAgZ2ZuX3QgZ2ZuID0gZ2FkZHJfdG9fZ2ZuKEFQSUNfREVG QVVMVF9QSFlTX0JBU0UpOworICAgIG1mbl90IGFwaWNfYWNjZXNzX21mbiA9 IGQtPmFyY2guaHZtLnZteC5hcGljX2FjY2Vzc19tZm47CiAgICAgYm9vbCBp cGF0OwogCi0gICAgaWYgKCAhaGFzX3ZsYXBpYyhkKSB8fCBtZm5fZXEoYXBp Y19hY2Nlc3NfbWZuLCBJTlZBTElEX01GTikgKQorICAgIGlmICggbWZuX2Vx KGFwaWNfYWNjZXNzX21mbiwgX21mbigwKSkgKQogICAgICAgICByZXR1cm47 CiAKICAgICBBU1NFUlQoZXB0ZV9nZXRfZW50cnlfZW10KGQsIGdmbiwgYXBp Y19hY2Nlc3NfbWZuLCAwLCAmaXBhdCwKQEAgLTI0ODEsNiArMjQ5MCw3IEBA IHN0YXRpYyBzdHJ1Y3QgaHZtX2Z1bmN0aW9uX3RhYmxlIF9faW5pdGRhdGEg dm14X2Z1bmN0aW9uX3RhYmxlID0gewogICAgIC5jcHVfdXBfcHJlcGFyZSAg ICAgICA9IHZteF9jcHVfdXBfcHJlcGFyZSwKICAgICAuY3B1X2RlYWQgICAg ICAgICAgICAgPSB2bXhfY3B1X2RlYWQsCiAgICAgLmRvbWFpbl9pbml0aWFs aXNlICAgID0gdm14X2RvbWFpbl9pbml0aWFsaXNlLAorICAgIC5kb21haW5f cmVsaW5xdWlzaF9yZXNvdXJjZXMgPSB2bXhfZG9tYWluX3JlbGlucXVpc2hf cmVzb3VyY2VzLAogICAgIC5kb21haW5fY3JlYXRpb25fZmluaXNoZWQgPSBk b21haW5fY3JlYXRpb25fZmluaXNoZWQsCiAgICAgLnZjcHVfaW5pdGlhbGlz ZSAgICAgID0gdm14X3ZjcHVfaW5pdGlhbGlzZSwKICAgICAudmNwdV9kZXN0 cm95ICAgICAgICAgPSB2bXhfdmNwdV9kZXN0cm95LApAQCAtMjczMSw3ICsy NzQxLDcgQEAgY29uc3Qgc3RydWN0IGh2bV9mdW5jdGlvbl90YWJsZSAqIF9f aW5pdCBzdGFydF92bXgodm9pZCkKIHsKICAgICBzZXRfaW5fY3I0KFg4Nl9D UjRfVk1YRSk7CiAKLSAgICBpZiAoIHZteF92bWNzX2luaXQoKSB8fCBhbGxv Y192bGFwaWNfbWFwcGluZygpICkKKyAgICBpZiAoIHZteF92bWNzX2luaXQo KSApCiAgICAgewogICAgICAgICBwcmludGsoIlZNWDogZmFpbGVkIHRvIGlu aXRpYWxpc2UuXG4iKTsKICAgICAgICAgcmV0dXJuIE5VTEw7CkBAIC0zMzA1 LDM2ICszMzE1LDU1IEBAIHN0YXRpYyBpbnQgdm14X21zcl9yZWFkX2ludGVy Y2VwdCh1bnNpZ25lZCBpbnQgbXNyLCB1aW50NjRfdCAqbXNyX2NvbnRlbnQp CiAgICAgcmV0dXJuIFg4NkVNVUxfRVhDRVBUSU9OOwogfQogCi1zdGF0aWMg aW50IF9faW5pdCBhbGxvY192bGFwaWNfbWFwcGluZyh2b2lkKQorc3RhdGlj IGludCB2bXhfYWxsb2NfdmxhcGljX21hcHBpbmcoc3RydWN0IGRvbWFpbiAq ZCkKIHsKICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZzsKICAgICBtZm5fdCBt Zm47CiAKLSAgICBpZiAoICFjcHVfaGFzX3ZteF92aXJ0dWFsaXplX2FwaWNf YWNjZXNzZXMgKQorICAgIGlmICggIWhhc192bGFwaWMoZCkgfHwgIWNwdV9o YXNfdm14X3ZpcnR1YWxpemVfYXBpY19hY2Nlc3NlcyApCiAgICAgICAgIHJl dHVybiAwOwogCi0gICAgcGcgPSBhbGxvY19kb21oZWFwX3BhZ2UoTlVMTCwg MCk7CisgICAgcGcgPSBhbGxvY19kb21oZWFwX3BhZ2UoZCwgTUVNRl9ub19y ZWZjb3VudCk7CiAgICAgaWYgKCAhcGcgKQogICAgICAgICByZXR1cm4gLUVO T01FTTsKIAotICAgIC8qCi0gICAgICogU2lnbmFsIHRvIHNoYWRvdyBjb2Rl IHRoYXQgdGhpcyBwYWdlIGNhbm5vdCBiZSByZWZjb3VudGVkLiBUaGlzIGFs c28KLSAgICAgKiBtYWtlcyBlcHRlX2dldF9lbnRyeV9lbXQoKSByZWNvZ25p emUgdGhpcyBwYWdlIGFzICJzcGVjaWFsIi4KLSAgICAgKi8KLSAgICBwYWdl X3N1cHByZXNzX3JlZmNvdW50aW5nKHBnKTsKKyAgICBpZiAoICFnZXRfcGFn ZV9hbmRfdHlwZShwZywgZCwgUEdUX3dyaXRhYmxlX3BhZ2UpICkKKyAgICB7 CisgICAgICAgIC8qCisgICAgICAgICAqIFRoZSBkb21haW4gY2FuJ3QgcG9z c2libHkga25vdyBhYm91dCB0aGlzIHBhZ2UgeWV0LCBzbyBmYWlsdXJlCisg ICAgICAgICAqIGhlcmUgaXMgYSBjbGVhciBpbmRpY2F0aW9uIG9mIHNvbWV0 aGluZyBmaXNoeSBnb2luZyBvbi4KKyAgICAgICAgICovCisgICAgICAgIGRv bWFpbl9jcmFzaChkKTsKKyAgICAgICAgcmV0dXJuIC1FTk9EQVRBOworICAg IH0KIAogICAgIG1mbiA9IHBhZ2VfdG9fbWZuKHBnKTsKICAgICBjbGVhcl9k b21haW5fcGFnZShtZm4pOwotICAgIGFwaWNfYWNjZXNzX21mbiA9IG1mbjsK KyAgICBkLT5hcmNoLmh2bS52bXguYXBpY19hY2Nlc3NfbWZuID0gbWZuOwog CiAgICAgcmV0dXJuIDA7CiB9CiAKK3N0YXRpYyB2b2lkIHZteF9mcmVlX3Zs YXBpY19tYXBwaW5nKHN0cnVjdCBkb21haW4gKmQpCit7CisgICAgbWZuX3Qg bWZuID0gZC0+YXJjaC5odm0udm14LmFwaWNfYWNjZXNzX21mbjsKKworICAg IGQtPmFyY2guaHZtLnZteC5hcGljX2FjY2Vzc19tZm4gPSBfbWZuKDApOwor ICAgIGlmICggIW1mbl9lcShtZm4sIF9tZm4oMCkpICkKKyAgICB7CisgICAg ICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnID0gbWZuX3RvX3BhZ2UobWZuKTsK KworICAgICAgICBwdXRfcGFnZV9hbGxvY19yZWYocGcpOworICAgICAgICBw dXRfcGFnZV9hbmRfdHlwZShwZyk7CisgICAgfQorfQorCiBzdGF0aWMgdm9p ZCB2bXhfaW5zdGFsbF92bGFwaWNfbWFwcGluZyhzdHJ1Y3QgdmNwdSAqdikK IHsKKyAgICBtZm5fdCBhcGljX2FjY2Vzc19tZm4gPSB2LT5kb21haW4tPmFy Y2guaHZtLnZteC5hcGljX2FjY2Vzc19tZm47CiAgICAgcGFkZHJfdCB2aXJ0 X3BhZ2VfbWEsIGFwaWNfcGFnZV9tYTsKIAotICAgIGlmICggIWhhc192bGFw aWModi0+ZG9tYWluKSB8fCBtZm5fZXEoYXBpY19hY2Nlc3NfbWZuLCBJTlZB TElEX01GTikgKQorICAgIGlmICggbWZuX2VxKGFwaWNfYWNjZXNzX21mbiwg X21mbigwKSkgKQogICAgICAgICByZXR1cm47CiAKICAgICBBU1NFUlQoY3B1 X2hhc192bXhfdmlydHVhbGl6ZV9hcGljX2FjY2Vzc2VzKTsKZGlmZiAtLWdp dCBhL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvc2V0LmMgYi94ZW4vYXJjaC94 ODYvbW0vc2hhZG93L3NldC5jCmluZGV4IDg3ZTljNmVlYjIxOS4uYmQ2YzY4 YjU0N2M5IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYvbW0vc2hhZG93L3Nl dC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvc2V0LmMKQEAgLTEw MSwxNCArMTAxLDYgQEAgc2hhZG93X2dldF9wYWdlX2Zyb21fbDFlKHNoYWRv d19sMWVfdCBzbDFlLCBzdHJ1Y3QgZG9tYWluICpkLCBwMm1fdHlwZV90IHR5 cGUpCiAgICAgICAgIG93bmVyID0gcGFnZV9nZXRfb3duZXIocGcpOwogICAg IH0KIAotICAgIC8qCi0gICAgICogQ2hlY2sgd2hldGhlciByZWZjb3VudGlu ZyBpcyBzdXBwcmVzc2VkIG9uIHRoaXMgcGFnZS4gRm9yIGV4YW1wbGUsCi0g ICAgICogVk1YJ2VzIEFQSUMgYWNjZXNzIE1GTiBpcyBqdXN0IGEgc3Vycm9n YXRlIHBhZ2UuICBJdCBkb2Vzbid0IGFjdHVhbGx5Ci0gICAgICogZ2V0IGFj Y2Vzc2VkLCBhbmQgaGVuY2UgdGhlcmUncyBubyBuZWVkIHRvIHJlZmNvdW50 IGl0LgotICAgICAqLwotICAgIGlmICggcGcgJiYgcGFnZV9yZWZjb3VudGlu Z19zdXBwcmVzc2VkKHBnKSApCi0gICAgICAgIHJldHVybiAwOwotCiAgICAg aWYgKCBvd25lciA9PSBkb21faW8gKQogICAgICAgICBvd25lciA9IE5VTEw7 CiAKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvdHlwZXMu aCBiL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvdHlwZXMuaAppbmRleCA2OTcw ZTdkNmVhNGEuLjgxNGE0MDE4NTM1YSAxMDA2NDQKLS0tIGEveGVuL2FyY2gv eDg2L21tL3NoYWRvdy90eXBlcy5oCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9z aGFkb3cvdHlwZXMuaApAQCAtMjc2LDE2ICsyNzYsOSBAQCBpbnQgc2hhZG93 X3NldF9sNGUoc3RydWN0IGRvbWFpbiAqZCwgc2hhZG93X2w0ZV90ICpzbDRl LAogc3RhdGljIHZvaWQgaW5saW5lCiBzaGFkb3dfcHV0X3BhZ2VfZnJvbV9s MWUoc2hhZG93X2wxZV90IHNsMWUsIHN0cnVjdCBkb21haW4gKmQpCiB7Ci0g ICAgbWZuX3QgbWZuID0gc2hhZG93X2wxZV9nZXRfbWZuKHNsMWUpOwotCiAg ICAgaWYgKCAhc2hhZG93X21vZGVfcmVmY291bnRzKGQpICkKICAgICAgICAg cmV0dXJuOwogCi0gICAgaWYgKCBtZm5fdmFsaWQobWZuKSAmJgotICAgICAg ICAgLyogU2VlIHRoZSByZXNwZWN0aXZlIGNvbW1lbnQgaW4gc2hhZG93X2dl dF9wYWdlX2Zyb21fbDFlKCkuICovCi0gICAgICAgICBwYWdlX3JlZmNvdW50 aW5nX3N1cHByZXNzZWQobWZuX3RvX3BhZ2UobWZuKSkgKQotICAgICAgICBy ZXR1cm47Ci0KICAgICBwdXRfcGFnZV9mcm9tX2wxZShzbDFlLCBkKTsKIH0K IApkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9odm0vdm14L3Zt Y3MuaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL3ZteC92bWNzLmgKaW5k ZXggMDNjOWNjZjYyN2FiLi44MDczYWYzMjNiOTYgMTAwNjQ0Ci0tLSBhL3hl bi9pbmNsdWRlL2FzbS14ODYvaHZtL3ZteC92bWNzLmgKKysrIGIveGVuL2lu Y2x1ZGUvYXNtLXg4Ni9odm0vdm14L3ZtY3MuaApAQCAtNTgsNiArNTgsNyBA QCBzdHJ1Y3QgZXB0X2RhdGEgewogI2RlZmluZSBfVk1YX0RPTUFJTl9QTUxf RU5BQkxFRCAgICAwCiAjZGVmaW5lIFZNWF9ET01BSU5fUE1MX0VOQUJMRUQg ICAgICgxdWwgPDwgX1ZNWF9ET01BSU5fUE1MX0VOQUJMRUQpCiBzdHJ1Y3Qg dm14X2RvbWFpbiB7CisgICAgbWZuX3QgYXBpY19hY2Nlc3NfbWZuOwogICAg IC8qIFZNWF9ET01BSU5fKiAqLwogICAgIHVuc2lnbmVkIGludCBzdGF0dXM7 CiAKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS14ODYvbW0uaCBiL3hl bi9pbmNsdWRlL2FzbS14ODYvbW0uaAppbmRleCA3YmRmOWMyMjkwZDguLmUx YmNlYTU3YThmNSAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9t bS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvbW0uaApAQCAtODMsNyAr ODMsNyBAQAogI2RlZmluZSBQR0Nfc3RhdGVfb2ZmbGluZWQgIFBHX21hc2so MiwgNikKICNkZWZpbmUgUEdDX3N0YXRlX2ZyZWUgICAgICBQR19tYXNrKDMs IDYpCiAjZGVmaW5lIHBhZ2Vfc3RhdGVfaXMocGcsIHN0KSAoKChwZyktPmNv dW50X2luZm8mUEdDX3N0YXRlKSA9PSBQR0Nfc3RhdGVfIyNzdCkKLS8qIFBh Z2UgaXMgbm90IHJlZmVyZW5jZSBjb3VudGVkIChzZWUgYmVsb3cgZm9yIGNh dmVhdHMpICovCisvKiBQYWdlIGlzIG5vdCByZWZlcmVuY2UgY291bnRlZCAq LwogI2RlZmluZSBfUEdDX2V4dHJhICAgICAgICBQR19zaGlmdCg3KQogI2Rl ZmluZSBQR0NfZXh0cmEgICAgICAgICBQR19tYXNrKDEsIDcpCiAKQEAgLTM3 NSwyNCArMzc1LDYgQEAgdm9pZCB6YXBfcm9fbXB0KG1mbl90IG1mbik7CiAK IGJvb2wgaXNfaW9tZW1fcGFnZShtZm5fdCBtZm4pOwogCi0vKgotICogUGFn ZXMgd2l0aCBubyBvd25lciB3aGljaCBtYXkgZ2V0IHBhc3NlZCB0byBmdW5j dGlvbnMgd2FudGluZyB0bwotICogcmVmY291bnQgdGhlbSBjYW4gYmUgbWFy a2VkIFBHQ19leHRyYSB0byBieXBhc3MgdGhpcyByZWZjb3VudGluZyAod2hp Y2gKLSAqIHdvdWxkIGZhaWwgZHVlIHRvIHRoZSBsYWNrIG9mIGFuIG93bmVy KS4KLSAqCi0gKiAoRm9yIHBhZ2VzIHdpdGggb3duZXIgUEdDX2V4dHJhIGhh cyBkaWZmZXJlbnQgbWVhbmluZy4pCi0gKi8KLXN0YXRpYyBpbmxpbmUgdm9p ZCBwYWdlX3N1cHByZXNzX3JlZmNvdW50aW5nKHN0cnVjdCBwYWdlX2luZm8g KnBnKQotewotICAgQVNTRVJUKCFwYWdlX2dldF9vd25lcihwZykpOwotICAg cGctPmNvdW50X2luZm8gfD0gUEdDX2V4dHJhOwotfQotCi1zdGF0aWMgaW5s aW5lIGJvb2wgcGFnZV9yZWZjb3VudGluZ19zdXBwcmVzc2VkKGNvbnN0IHN0 cnVjdCBwYWdlX2luZm8gKnBnKQotewotICAgIHJldHVybiAhcGFnZV9nZXRf b3duZXIocGcpICYmIChwZy0+Y291bnRfaW5mbyAmIFBHQ19leHRyYSk7Ci19 Ci0KIHN0cnVjdCBwbGF0Zm9ybV9iYWRfcGFnZSB7CiAgICAgdW5zaWduZWQg bG9uZyBtZm47CiAgICAgdW5zaWduZWQgaW50IG9yZGVyOwo= --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Nov 01 12:01:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 12:01:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433506.686652 (Exim 4.92) (envelope-from ) id 1oppxK-0002Gh-JY; Tue, 01 Nov 2022 12:01:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433506.686652; Tue, 01 Nov 2022 12:01:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppxJ-0002AE-CT; Tue, 01 Nov 2022 12:01:21 +0000 Received: by outflank-mailman (input) for mailman id 433506; Tue, 01 Nov 2022 12:01:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppxF-0000IJ-VE for xen-devel@lists.xen.org; Tue, 01 Nov 2022 12:01:18 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d875f2c6-59dc-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 13:00:58 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppwl-0005Z9-C4; Tue, 01 Nov 2022 12:00:47 +0000 Received: from jgross by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oppwl-0005X2-BC; Tue, 01 Nov 2022 12:00:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d875f2c6-59dc-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=vcKamV/Zln9VvC5u2VXjgagwehiHOwuSW7zKIZUmA6A=; b=rRWlynkr1La4Ti+YL2mPRhsceZ akeJnhgQantDXDGpjZEcb6Ezn0nvQWCizu+4U6SVCd0+UnlLjLpELvbQDflesPOqmo7Vvqp90P0F8 LJF6w2d8YfvQ3cyt2c+rOQyROgpUM57vxb6WWC6nk3DseJoo061ajz4RWpTU1lWnVMjA=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 419 v2 (CVE-2022-42322,CVE-2022-42323) - Xenstore: Cooperating guests can create arbitrary numbers of nodes Message-Id: Date: Tue, 01 Nov 2022 12:00:47 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-42322,CVE-2022-42323 / XSA-419 version 2 Xenstore: Cooperating guests can create arbitrary numbers of nodes UPDATES IN VERSION 2 ==================== Public release. ISSUE DESCRIPTION ================= Since the fix of XSA-322 any Xenstore node owned by a removed domain will be modified to be owned by Dom0. This will allow two malicious guests working together to create an arbitrary number of Xenstore nodes. This is possible by domain A letting domain B write into domain A's local Xenstore tree. Domain B can then create many nodes and reboot. The nodes created by domain B will now be owned by Dom0. By repeating this process over and over again an arbitrary number of nodes can be created, as Dom0's number of nodes isn't limited by Xenstore quota. IMPACT ====== Two malicious guests working together can drive xenstored into an out of memory situation, resulting in a Denial of Service (DoS) of xenstored. This inhibits creation of new guests and changing the configuration of already running guests. VULNERABLE SYSTEMS ================== All versions of Xen with the fix for XSA-322 are in principle vulnerable. Both Xenstore implementations (C and Ocaml) are vulnerable. MITIGATION ========== There is no mitigation available. CREDITS ======= This issue was discovered by Jürgen Groß of SUSE. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa419/xsa419-oxenstored.patch xen-unstable xsa419/xsa419-xenstored-??.patch xen-unstable, Xen 4.16.x xsa419/xsa419-4.15-oxenstored.patch Xen 4.15.x xsa419/xsa419-4.15-xenstored-??.patch Xen 4.15.x xsa419/xsa419-4.14-oxenstored.patch Xen 4.14.x xsa419/xsa419-4.14-xenstored-??.patch Xen 4.14.x xsa419/xsa419-4.13-oxenstored.patch Xen 4.13.x xsa419/xsa419-4.13-xenstored-??.patch Xen 4.13.x $ sha256sum xsa419* xsa419*/* eaeb2a67accac70743cd9bed055b31bee2402600b7452f79da4bb969d7b5607f xsa419.meta 34abd947ceaf1251afc81356a3ff374bc06c046651f5f9d0894d90c93295d1ca xsa419/xsa419-4.13-oxenstored.patch 713eea1d9be7a5bef7a681a10648d2ea7db36c961cc8a9c55e147db14f59fbc2 xsa419/xsa419-4.13-xenstored-01.patch d7b0369ee1c87a08783c0484ae5f62f1c61be9c405e6568085052867bb520b2a xsa419/xsa419-4.13-xenstored-02.patch f6e0cd7491d602db3a7ac9b9e94afb59c30bf8690cd116850d8eafc481f022a9 xsa419/xsa419-4.13-xenstored-03.patch 18daa2d6b9d243bfd81e221af9ae1d74cbc621614b78dc751bb6ccdba3d66451 xsa419/xsa419-4.14-oxenstored.patch d631f12da2a8fcf674aeed33d0037bfff4b11587d6d52e4709739a8d1e90f33a xsa419/xsa419-4.14-xenstored-01.patch dc3834b30ac15d31ad1a13a8b4925229f13ce7955f2cc2223651764c55d41e64 xsa419/xsa419-4.14-xenstored-02.patch f15d02bfc9ee5119347708fd2e4d26c6b4aa18827afab1a10b9139344ca88861 xsa419/xsa419-4.14-xenstored-03.patch 95c35f32cf64229df2768109acc360a6f6ec4ddfdcbde4f0d8165f67432d3eef xsa419/xsa419-4.15-oxenstored.patch 773e98ee9ddb37e4a743d4435340066aabdc5fb41b6ff12e6b91c709484204ab xsa419/xsa419-4.15-xenstored-01.patch 4d1f9135be43e121576909787a6403aa1c1e5fa72ead8764326e21beb48d83d4 xsa419/xsa419-4.15-xenstored-02.patch 484bdddae7a750cbddeddb93be5840e3cfdda5799f667c6b5d66c3c9b7217d55 xsa419/xsa419-4.15-xenstored-03.patch 1c790ddc8cbabb32012c7636c46e017b0cbdd1cc23c56baabda4d5dca9531454 xsa419/xsa419-oxenstored.patch 3c53e103f7927ae28ab5c7a3954c7d0a6fbbdce0340816936adb5938cd48c776 xsa419/xsa419-xenstored-01.patch 978e3100b20e0126ee238d3e1c2036b25582b1c3333a028e120d700bac8d2a13 xsa419/xsa419-xenstored-02.patch 57f7015289a940e7f2dc66aedb1c04d37d0aef687a7b91453582e960b7f93076 xsa419/xsa419-xenstored-03.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of patches or mitigations is NOT permitted (except where all the affected systems and VMs are administered and used only by organisations which are members of the Xen Project Security Issues Predisclosure List). Specifically, deployment on public cloud systems is NOT permitted. This is because the patches will result in a guest visible change of behavior of Xenstore. Deployment is permitted only AFTER the embargo ends. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNg+64MHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZR4gIAI+TcWgMKtaJ6G6MeakBbgxliMCO7+C01+94H6ZH 7dC57n3Qm12t3q6WGnPG1YYzKGWT2hsSU8/JtIkuZFe2qyvuG5cVhVcrdOGGkhsZ 4ui517R76Ldb/cBtraX6QRJni+T58ZdQGAChr6KuD8cyMgXAl1gtto9+/rQtsDzr 7XxKcR/+CcNWAOpZTNJ6DtS8V1RuRNtMSuoTCpC3Ph+Edir05bPlz6BF8EnV0cqU +Jk9nYHGg5H11L0K+yx4cIAWfaP/n/Z2AoND23tV3T4o3U3zQR9xNBvcY1zuvioG rEfzGNQx9ECQLHYPTzHNNWs+9Fb8eHyiRvkS6SKGolxpj9A= =nNvr -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa419.meta" Content-Disposition: attachment; filename="xsa419.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MTksCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIw YmU2M2MyNjE1YjI2ODAwMWY3Y2M5YjcyY2UyNWVlZDk1MjczN2RjIiwKICAg ICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICA0MTQsCiAgICAgICAg ICAgIDQxNSwKICAgICAgICAgICAgMzI2LAogICAgICAgICAgICA0MTYsCiAg ICAgICAgICAgIDQxNywKICAgICAgICAgICAgNDE4CiAgICAgICAgICBdLAog ICAgICAgICAgIlBhdGNoZXMiOiBbCiAgICAgICAgICAgICJ4c2E0MTkveHNh NDE5LTQuMTMteGVuc3RvcmVkLT8/LnBhdGNoIiwKICAgICAgICAgICAgInhz YTQxOS94c2E0MTktNC4xMy1veGVuc3RvcmVkLnBhdGNoIgogICAgICAgICAg XQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE0IjogewogICAg ICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0 YWJsZVJlZiI6ICIwMTZkZTYyNzQ3YjI2ZWFkNWE1Yzc2M2I2NDBmZThlMjA1 Y2QxODJiIiwKICAgICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICA0 MTQsCiAgICAgICAgICAgIDQxNSwKICAgICAgICAgICAgMzI2LAogICAgICAg ICAgICA0MTYsCiAgICAgICAgICAgIDQxNywKICAgICAgICAgICAgNDE4CiAg ICAgICAgICBdLAogICAgICAgICAgIlBhdGNoZXMiOiBbCiAgICAgICAgICAg ICJ4c2E0MTkveHNhNDE5LTQuMTQteGVuc3RvcmVkLT8/LnBhdGNoIiwKICAg ICAgICAgICAgInhzYTQxOS94c2E0MTktNC4xNC1veGVuc3RvcmVkLnBhdGNo IgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0 LjE1IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewog ICAgICAgICAgIlN0YWJsZVJlZiI6ICI4MTY1ODBhZmRkMTczMGQ0Zjg1ZjY0 NDc3YTI0MmE0MzlhZjFjZGY4IiwKICAgICAgICAgICJQcmVyZXFzIjogWwog ICAgICAgICAgICA0MTQsCiAgICAgICAgICAgIDQxNSwKICAgICAgICAgICAg MzI2LAogICAgICAgICAgICA0MTYsCiAgICAgICAgICAgIDQxNywKICAgICAg ICAgICAgNDE4CiAgICAgICAgICBdLAogICAgICAgICAgIlBhdGNoZXMiOiBb CiAgICAgICAgICAgICJ4c2E0MTkveHNhNDE5LTQuMTUteGVuc3RvcmVkLT8/ LnBhdGNoIiwKICAgICAgICAgICAgInhzYTQxOS94c2E0MTktNC4xNS1veGVu c3RvcmVkLnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQog ICAgfSwKICAgICI0LjE2IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAg ICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIxYmNlN2ZiMWY3 MDJkYTRmN2E3NDljNmYxNDU3ZWNiMjBiZjc0ZmNhIiwKICAgICAgICAgICJQ cmVyZXFzIjogWwogICAgICAgICAgICA0MTIsCiAgICAgICAgICAgIDQxNCwK ICAgICAgICAgICAgNDE1LAogICAgICAgICAgICAzMjYsCiAgICAgICAgICAg IDQxNiwKICAgICAgICAgICAgNDE3LAogICAgICAgICAgICA0MTgKICAgICAg ICAgIF0sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhz YTQxOS94c2E0MTkteGVuc3RvcmVkLT8/LnBhdGNoIiwKICAgICAgICAgICAg InhzYTQxOS94c2E0MTktb3hlbnN0b3JlZC5wYXRjaCIKICAgICAgICAgIF0K ICAgICAgICB9CiAgICAgIH0KICAgIH0sCiAgICAibWFzdGVyIjogewogICAg ICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0 YWJsZVJlZiI6ICJjYzQ3NDdiZThiYTE1N2EzYjMxMDkyMWU5ZWUwN2ZiODU0 NWFhMjA2IiwKICAgICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICA0 MTIsCiAgICAgICAgICAgIDQxNCwKICAgICAgICAgICAgNDE1LAogICAgICAg ICAgICAzMjYsCiAgICAgICAgICAgIDQxNiwKICAgICAgICAgICAgNDE3LAog ICAgICAgICAgICA0MTgKICAgICAgICAgIF0sCiAgICAgICAgICAiUGF0Y2hl cyI6IFsKICAgICAgICAgICAgInhzYTQxOS94c2E0MTkteGVuc3RvcmVkLT8/ LnBhdGNoIiwKICAgICAgICAgICAgInhzYTQxOS94c2E0MTktb3hlbnN0b3Jl ZC5wYXRjaCIKICAgICAgICAgIF0KICAgICAgICB9CiAgICAgIH0KICAgIH0K ICB9Cn0= --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-4.13-oxenstored.patch" Content-Disposition: attachment; filename="xsa419/xsa419-4.13-oxenstored.patch" Content-Transfer-Encoding: base64 RnJvbSBhMjFkY2Q1ZGVkYzdhZjBlNzMzOTVlOGJkNmFmM2RjZGVmMWRjOWU1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNiArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IEZpeCBxdW90YSBieXBhc3Mg b24gZG9tYWluIHNodXRkb3duCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQt VHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5z ZmVyLUVuY29kaW5nOiA4Yml0CgpYU0EtMzIyIGZpeGVkIGEgZG9taWQgcmV1 c2UgdnVsbmVyYWJpbGl0eSBieSBhc3NpZ25pbmcgRG9tMCBhcyB0aGUgb3du ZXIgb2YKYW55IG5vZGVzIGxlZnQgYWZ0ZXIgYSBkb21haW4gaXMgc2h1dGRv d24gKGUuZy4gb3V0c2lkZSBpdHMgL2xvY2FsL2RvbWFpbi9OCnRyZWUpLgoK SG93ZXZlciBEb20wIGhhcyBubyBxdW90YSBvbiBwdXJwb3NlLCBzbyB0aGlz IG9wZW5lZCB1cCBhbm90aGVyIHBvdGVudGlhbAphdHRhY2sgdmVjdG9yLiBB dm9pZCBpdCBieSBkZWxldGluZyB0aGVzZSBub2RlcyBpbnN0ZWFkIG9mIGFz c2lnbmluZyB0aGVtIHRvCkRvbTAuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQx OSAvIENWRS0yMDIyLTQyMzIzLgoKUmVwb3J0ZWQtYnk6IEp1ZXJnZW4gR3Jv c3MgPGpncm9zc0BzdXNlLmNvbT4KRml4ZXM6IGM0NmVmZjkyMTIwOSAoInRv b2xzL29jYW1sL3hlbnN0b3JlZDogY2xlYW4gdXAgcGVybWlzc2lvbnMgZm9y IGRlYWQgZG9tYWlucyIpClNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLDtmsg PGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJpc3RpYW4g TGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+CgpkaWZmIC0t Z2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Blcm1zLm1sIGIvdG9vbHMv b2NhbWwveGVuc3RvcmVkL3Blcm1zLm1sCmluZGV4IGU4YTE2MjIxZjhmYS4u ODRmMjUwM2U4ZTI5IDEwMDY0NAotLS0gYS90b29scy9vY2FtbC94ZW5zdG9y ZWQvcGVybXMubWwKKysrIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Blcm1z Lm1sCkBAIC02NCw4ICs2NCw3IEBAIGxldCBnZXRfb3duZXIgcGVybSA9IHBl cm0ub3duZXIKICogKikKIGxldCByZW1vdmVfZG9taWQgfmRvbWlkIHBlcm0g PQogCWxldCBhY2wgPSBMaXN0LmZpbHRlciAoZnVuIChhY2xfZG9taWQsIF8p IC0+IGFjbF9kb21pZCA8PiBkb21pZCkgcGVybS5hY2wgaW4KLQlsZXQgb3du ZXIgPSBpZiBwZXJtLm93bmVyID0gZG9taWQgdGhlbiAwIGVsc2UgcGVybS5v d25lciBpbgotCXsgcGVybSB3aXRoIGFjbDsgb3duZXIgfQorCWlmIHBlcm0u b3duZXIgPSBkb21pZCB0aGVuIE5vbmUgZWxzZSBTb21lIHsgcGVybSB3aXRo IGFjbDsgb3duZXIgPSBwZXJtLm93bmVyIH0KIAogbGV0IGRlZmF1bHQwID0g Y3JlYXRlIDAgTk9ORSBbXQogCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94 ZW5zdG9yZWQvc3RvcmUubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvc3Rv cmUubWwKaW5kZXggMzI4ZDNhNTE5ODRmLi5kODI3NjRmNjBmYjQgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9zdG9yZS5tbAorKysgYi90 b29scy9vY2FtbC94ZW5zdG9yZWQvc3RvcmUubWwKQEAgLTg5LDEwICs4OSwy MSBAQCBsZXQgY2hlY2tfb3duZXIgbm9kZSBjb25uZWN0aW9uID0KIAogbGV0 IHJlYyByZWN1cnNlIGZjdCBub2RlID0gZmN0IG5vZGU7IExpc3QuaXRlciAo cmVjdXJzZSBmY3QpIG5vZGUuY2hpbGRyZW4KIAotKCoqIFtyZWN1cnNlX21h cCBmIHRyZWVdIGFwcGxpZXMgW2ZdIG9uIGVhY2ggbm9kZSBpbiB0aGUgdHJl ZSByZWN1cnNpdmVseSAqKQotbGV0IHJlY3Vyc2VfbWFwIGYgPQorKCoqIFty ZWN1cnNlX2ZpbHRlcl9tYXAgZiB0cmVlXSBhcHBsaWVzIFtmXSBvbiBlYWNo IG5vZGUgaW4gdGhlIHRyZWUgcmVjdXJzaXZlbHksCisgICAgcG9zc2libHkg cmVtb3Zpbmcgc29tZSBub2Rlcy4KKyAgICBOb3RlIHRoYXQgdGhlIG5vZGVz IHJlbW92ZWQgdGhpcyB3YXkgd29uJ3QgZ2VuZXJhdGUgd2F0Y2ggZXZlbnRz LgorKikKK2xldCByZWN1cnNlX2ZpbHRlcl9tYXAgZiA9CisJbGV0IGludmFs aWQgPSAtMSBpbgorCWxldCBpc192YWxpZCBub2RlID0gbm9kZS5wZXJtcy5v d25lciA8PiBpbnZhbGlkIGluCiAJbGV0IHJlYyB3YWxrIG5vZGUgPQotCQlm IHsgbm9kZSB3aXRoIGNoaWxkcmVuID0gTGlzdC5yZXZfbWFwIHdhbGsgbm9k ZS5jaGlsZHJlbiB8PiBMaXN0LnJldiB9CisJCSgqIE1hcC5maWx0ZXJfbWFw IGlzIE9jYW1sIDQuMTErIG9ubHkgKikKKwkJbGV0IG5vZGUgPQorCQl7IG5v ZGUgd2l0aCBjaGlsZHJlbiA9CisJCQlMaXN0LnJldl9tYXAgd2FsayBub2Rl LmNoaWxkcmVuIHw+IExpc3QuZmlsdGVyIGlzX3ZhbGlkIHw+IExpc3QucmV2 IH0gaW4KKwkJbWF0Y2ggZiBub2RlIHdpdGgKKwkJfCBTb21lIGtlZXAgLT4g a2VlcAorCQl8IE5vbmUgLT4geyBub2RlIHdpdGggcGVybXMgPSB7bm9kZS5w ZXJtcyB3aXRoIG93bmVyID0gaW52YWxpZCB9IH0KIAlpbgogCXdhbGsKIApA QCAtNDQ2LDExICs0NTcsMTMgQEAgbGV0IHNldHBlcm1zIHN0b3JlIHBlcm0g cGF0aCBucGVybXMgPQogCiBsZXQgcmVzZXRfcGVybWlzc2lvbnMgc3RvcmUg ZG9taWQgPQogCUxvZ2dpbmcuaW5mbyAic3RvcmV8bm9kZSIgIkNsZWFuaW5n IHVwIHhlbnN0b3JlIEFDTHMgZm9yIGRvbWlkICVkIiBkb21pZDsKLQlzdG9y ZS5yb290IDwtIE5vZGUucmVjdXJzZV9tYXAgKGZ1biBub2RlIC0+Ci0JCWxl dCBwZXJtcyA9IFBlcm1zLk5vZGUucmVtb3ZlX2RvbWlkIH5kb21pZCBub2Rl LnBlcm1zIGluCi0JCWlmIHBlcm1zIDw+IG5vZGUucGVybXMgdGhlbgotCQkJ TG9nZ2luZy5kZWJ1ZyAic3RvcmV8bm9kZSIgIkNoYW5nZWQgcGVybWlzc2lv bnMgZm9yIG5vZGUgJXMiIChOb2RlLmdldF9uYW1lIG5vZGUpOwotCQl7IG5v ZGUgd2l0aCBwZXJtcyB9CisJc3RvcmUucm9vdCA8LSBOb2RlLnJlY3Vyc2Vf ZmlsdGVyX21hcCAoZnVuIG5vZGUgLT4KKwkJbWF0Y2ggUGVybXMuTm9kZS5y ZW1vdmVfZG9taWQgfmRvbWlkIG5vZGUucGVybXMgd2l0aAorCQl8IE5vbmUg LT4gTm9uZQorCQl8IFNvbWUgcGVybXMgLT4KKwkJCWlmIHBlcm1zIDw+IG5v ZGUucGVybXMgdGhlbgorCQkJCUxvZ2dpbmcuZGVidWcgInN0b3JlfG5vZGUi ICJDaGFuZ2VkIHBlcm1pc3Npb25zIGZvciBub2RlICVzIiAoTm9kZS5nZXRf bmFtZSBub2RlKTsKKwkJCVNvbWUgeyBub2RlIHdpdGggcGVybXMgfQogCSkg c3RvcmUucm9vdAogCiB0eXBlIG9wcyA9IHsK --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-4.13-xenstored-01.patch" Content-Disposition: attachment; filename="xsa419/xsa419-4.13-xenstored-01.patch" Content-Transfer-Encoding: base64 RnJvbSAxMDRhZmI4ODZmMWQ5MjQzZjk5ZTBmZDk5OGQ3Yzg5OGJjODM0ODMx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHJlbW92ZSBu b2RlcyBvd25lZCBieSBkZXN0cm95ZWQgZG9tYWluCgpJbiBjYXNlIGEgZG9t YWluIGlzIHJlbW92ZWQgZnJvbSBYZW5zdG9yZSwgcmVtb3ZlIGFsbCBub2Rl cyBvd25lZCBieQppdCBwZXIgZGVmYXVsdC4KClRoaXMgdGFja2xlcyB0aGUg cHJvYmxlbSB0aGF0IG5vZGVzIG1pZ2h0IGJlIGNyZWF0ZWQgYnkgYSBkb21h aW4Kb3V0c2lkZSBpdHMgaG9tZSBwYXRoIGluIFhlbnN0b3JlLCBsZWFkaW5n IHRvIFhlbnN0b3JlIGhvZ2dpbmcgbW9yZQphbmQgbW9yZSBtZW1vcnkuIERv bWFpbiBxdW90YSBkb24ndCB3b3JrIGluIHRoaXMgY2FzZSBpZiB0aGUgZ3Vl c3QgaXMKcmVib290aW5nIGluIGJldHdlZW4uCgpTaW5jZSBYU0EtMzIyIG93 bmVyc2hpcCBvZiBzdWNoIHN0YWxlIG5vZGVzIGlzIHRyYW5zZmVycmVkIHRv IGRvbTAsCndoaWNoIGlzIGhlbHBpbmcgYWdhaW5zdCB1bmludGVuZGVkIGFj Y2VzcywgYnV0IG5vdCBhZ2FpbnN0IE9PTSBvZgpYZW5zdG9yZS4KCkFzIGEg ZmFsbGJhY2sgZm9yIHdlaXJkIGNhc2VzIGFkZCBhIFhlbnN0b3JlIHN0YXJ0 IHBhcmFtZXRlciBmb3IKa2VlcGluZyB0b2RheSdzIHdheSB0byBoYW5kbGUg c3RhbGUgbm9kZXMsIGFkZGluZyB0aGUgcmlzayBvZiBYZW5zdG9yZQpoaXR0 aW5nIGFuIE9PTSBzaXR1YXRpb24uCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQx OSAvIENWRS0yMDIyLTQyMzIyLgoKUmVwb3J0ZWQtYnk6IEp1ZXJnZW4gR3Jv c3MgPGpncm9zc0BzdXNlLmNvbT4KRml4ZXM6IDQ5NjMwNjMyNGQ4ZCAoInRv b2xzL3hlbnN0b3JlOiByZXZva2UgYWNjZXNzIHJpZ2h0cyBmb3IgcmVtb3Zl ZCBkb21haW5zIikKU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdy b3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3Jh bGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuYwppbmRleCA5NjU1YWY0YzAxZmEuLjdlYjY5OGUxZmMyMiAxMDA2NDQK LS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC03Niw2ICs3Niw3 IEBAIHN0YXRpYyBib29sIHZlcmJvc2UgPSBmYWxzZTsKIExJU1RfSEVBRChj b25uZWN0aW9ucyk7CiBpbnQgdHJhY2VmZCA9IC0xOwogc3RhdGljIGJvb2wg cmVjb3ZlcnkgPSB0cnVlOworYm9vbCBrZWVwX29ycGhhbnMgPSBmYWxzZTsK IHN0YXRpYyBpbnQgcmVvcGVuX2xvZ19waXBlWzJdOwogc3RhdGljIGludCBy ZW9wZW5fbG9nX3BpcGUwX3BvbGxmZF9pZHggPSAtMTsKIGNoYXIgKnRyYWNl ZmlsZSA9IE5VTEw7CkBAIC02NjIsNyArNjYzLDcgQEAgc3RydWN0IG5vZGUg KnJlYWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9p ZCAqY3R4LAogCW5vZGUtPnBlcm1zLnAgPSBoZHItPnBlcm1zOwogCW5vZGUt PmFjYy5kb21pZCA9IG5vZGUtPnBlcm1zLnBbMF0uaWQ7CiAJbm9kZS0+YWNj Lm1lbW9yeSA9IGRhdGEuZHNpemU7Ci0JaWYgKGRvbWFpbl9hZGp1c3Rfbm9k ZV9wZXJtcyhjb25uLCBub2RlKSkKKwlpZiAoZG9tYWluX2FkanVzdF9ub2Rl X3Blcm1zKG5vZGUpKQogCQlnb3RvIGVycm9yOwogCiAJLyogSWYgb3duZXIg aXMgZ29uZSByZXNldCBjdXJyZW50bHkgYWNjb3VudGVkIG1lbW9yeSBzaXpl LiAqLwpAQCAtNzA1LDcgKzcwNiw3IEBAIGludCB3cml0ZV9ub2RlX3Jhdyhz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgVERCX0RBVEEgKmtleSwgc3RydWN0 IG5vZGUgKm5vZGUsCiAJdm9pZCAqcDsKIAlzdHJ1Y3QgeHNfdGRiX3JlY29y ZF9oZHIgKmhkcjsKIAotCWlmIChkb21haW5fYWRqdXN0X25vZGVfcGVybXMo Y29ubiwgbm9kZSkpCisJaWYgKGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhu b2RlKSkKIAkJcmV0dXJuIGVycm5vOwogCiAJZGF0YS5kc2l6ZSA9IHNpemVv ZigqaGRyKQpAQCAtMTU0Niw3ICsxNTQ3LDcgQEAgc3RhdGljIGludCBkZWxu b2RlX3N1Yihjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpj b25uLAogCXJldHVybiBXQUxLX1RSRUVfUk1fQ0hJTERFTlRSWTsKIH0KIAot c3RhdGljIGludCBfcm0oc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0 IHZvaWQgKmN0eCwgY29uc3QgY2hhciAqbmFtZSkKK2ludCBybV9ub2RlKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsIGNvbnN0 IGNoYXIgKm5hbWUpCiB7CiAJc3RydWN0IG5vZGUgKnBhcmVudDsKIAljaGFy ICpwYXJlbnRuYW1lID0gZ2V0X3BhcmVudChjdHgsIG5hbWUpOwpAQCAtMTYw OCw3ICsxNjA5LDcgQEAgc3RhdGljIGludCBkb19ybShjb25zdCB2b2lkICpj dHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCWlmIChzdHJlcShuYW1l LCAiLyIpKQogCQlyZXR1cm4gRUlOVkFMOwogCi0JcmV0ID0gX3JtKGNvbm4s IGN0eCwgbmFtZSk7CisJcmV0ID0gcm1fbm9kZShjb25uLCBjdHgsIG5hbWUp OwogCWlmIChyZXQpCiAJCXJldHVybiByZXQ7CiAKQEAgLTI0NjEsNiArMjQ2 Miw4IEBAIHN0YXRpYyB2b2lkIHVzYWdlKHZvaWQpCiAiICAtUiwgLS1uby1y ZWNvdmVyeSAgICAgICB0byByZXF1ZXN0IHRoYXQgbm8gcmVjb3Zlcnkgc2hv dWxkIGJlIGF0dGVtcHRlZCB3aGVuXG4iCiAiICAgICAgICAgICAgICAgICAg ICAgICAgICB0aGUgc3RvcmUgaXMgY29ycnVwdGVkIChkZWJ1ZyBvbmx5KSxc biIKICIgIC1JLCAtLWludGVybmFsLWRiICAgICAgIHN0b3JlIGRhdGFiYXNl IGluIG1lbW9yeSwgbm90IG9uIGRpc2tcbiIKKyIgIC1LLCAtLWtlZXAtb3Jw aGFucyAgICAgIGRvbid0IGRlbGV0ZSBub2RlcyBvd25lZCBieSBhIGRvbWFp biB3aGVuIHRoZVxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgZG9t YWluIGlzIGRlbGV0ZWQgKHRoaXMgaXMgYSBzZWN1cml0eSByaXNrISlcbiIK ICIgIC1WLCAtLXZlcmJvc2UgICAgICAgICAgIHRvIHJlcXVlc3QgdmVyYm9z ZSBleGVjdXRpb24uXG4iKTsKIH0KIApAQCAtMjQ4NCw2ICsyNDg3LDcgQEAg c3RhdGljIHN0cnVjdCBvcHRpb24gb3B0aW9uc1tdID0gewogCXsgInRpbWVv dXQiLCAxLCBOVUxMLCAndycgfSwKIAl7ICJuby1yZWNvdmVyeSIsIDAsIE5V TEwsICdSJyB9LAogCXsgImludGVybmFsLWRiIiwgMCwgTlVMTCwgJ0knIH0s CisJeyAia2VlcC1vcnBoYW5zIiwgMCwgTlVMTCwgJ0snIH0sCiAJeyAidmVy Ym9zZSIsIDAsIE5VTEwsICdWJyB9LAogCXsgIndhdGNoLW5iIiwgMSwgTlVM TCwgJ1cnIH0sCiAJeyBOVUxMLCAwLCBOVUxMLCAwIH0gfTsKQEAgLTI1NTgs NyArMjU2Miw3IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10p CiAJaW50IHRpbWVvdXQ7CiAKIAotCXdoaWxlICgob3B0ID0gZ2V0b3B0X2xv bmcoYXJnYywgYXJndiwgIkRFOkY6SE5QUzp0OkE6UTpxOlQ6UlZXOnc6Iiwg b3B0aW9ucywKKwl3aGlsZSAoKG9wdCA9IGdldG9wdF9sb25nKGFyZ2MsIGFy Z3YsICJERTpGOkhLTlBTOnQ6QTpROnE6VDpSVlc6dzoiLCBvcHRpb25zLAog CQkJCSAgTlVMTCkpICE9IC0xKSB7CiAJCXN3aXRjaCAob3B0KSB7CiAJCWNh c2UgJ0QnOgpAQCAtMjU5NCw2ICsyNTk4LDkgQEAgaW50IG1haW4oaW50IGFy Z2MsIGNoYXIgKmFyZ3ZbXSkKIAkJY2FzZSAnSSc6CiAJCQl0ZGJfZmxhZ3Mg PSBUREJfSU5URVJOQUx8VERCX05PTE9DSzsKIAkJCWJyZWFrOworCQljYXNl ICdLJzoKKwkJCWtlZXBfb3JwaGFucyA9IHRydWU7CisJCQlicmVhazsKIAkJ Y2FzZSAnVic6CiAJCQl2ZXJib3NlID0gdHJ1ZTsKIAkJCWJyZWFrOwpkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKaW5kZXggZmM5ODgyYWMz N2Q1Li5lYzI0YzI3YWMyNDAgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuaApAQCAtMjA0LDYgKzIwNCw5IEBAIGludCB3cml0ZV9ub2Rl X3JhdyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgVERCX0RBVEEgKmtleSwg c3RydWN0IG5vZGUgKm5vZGUsCiBzdHJ1Y3Qgbm9kZSAqcmVhZF9ub2RlKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsCiAJCSAg ICAgICBjb25zdCBjaGFyICpuYW1lKTsKIAorLyogUmVtb3ZlIGEgbm9kZSBh bmQgaXRzIGNoaWxkcmVuLiAqLworaW50IHJtX25vZGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwgY29uc3QgY2hhciAqbmFt ZSk7CisKIHZvaWQgc2V0dXBfc3RydWN0dXJlKHZvaWQpOwogc3RydWN0IGNv bm5lY3Rpb24gKm5ld19jb25uZWN0aW9uKGNvbm53cml0ZWZuX3QgKndyaXRl LCBjb25ucmVhZGZuX3QgKnJlYWQpOwogdm9pZCBjaGVja19zdG9yZSh2b2lk KTsKQEAgLTI0Miw2ICsyNDUsNyBAQCBleHRlcm4gaW50IHF1b3RhX3JlcV9v dXRzdGFuZGluZzsKIGV4dGVybiBpbnQgcXVvdGFfdHJhbnNfbm9kZXM7CiBl eHRlcm4gaW50IHF1b3RhX21lbW9yeV9wZXJfZG9tYWluX3NvZnQ7CiBleHRl cm4gaW50IHF1b3RhX21lbW9yeV9wZXJfZG9tYWluX2hhcmQ7CitleHRlcm4g Ym9vbCBrZWVwX29ycGhhbnM7CiAKIGV4dGVybiB1bnNpZ25lZCBpbnQgdGlt ZW91dF93YXRjaF9ldmVudF9tc2VjOwogCmRpZmYgLS1naXQgYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMgYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfZG9tYWluLmMKaW5kZXggNGEwZTZhMDViOGNiLi5jYTYzOWNm NDMzY2YgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9k b21haW4uYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWlu LmMKQEAgLTIwNCwxMCArMjA0LDY1IEBAIHN0YXRpYyB2b2lkIHVubWFwX2lu dGVyZmFjZSh2b2lkICppbnRlcmZhY2UpCiAJeGVuZ250dGFiX3VubWFwKCp4 Z3RfaGFuZGxlLCBpbnRlcmZhY2UsIDEpOwogfQogCitzdGF0aWMgaW50IGRv bWFpbl90cmVlX3JlbW92ZV9zdWIoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKKwkJCQkgIHN0cnVjdCBub2RlICpub2RlLCB2 b2lkICphcmcpCit7CisJc3RydWN0IGRvbWFpbiAqZG9tYWluID0gYXJnOwor CVREQl9EQVRBIGtleTsKKwlpbnQgcmV0ID0gV0FMS19UUkVFX09LOworCisJ aWYgKG5vZGUtPnBlcm1zLnBbMF0uaWQgIT0gZG9tYWluLT5kb21pZCkKKwkJ cmV0dXJuIFdBTEtfVFJFRV9PSzsKKworCWlmIChrZWVwX29ycGhhbnMpIHsK KwkJa2V5LmRwdHIgPSAoY2hhciAqKW5vZGUtPm5hbWU7CisJCWtleS5kc2l6 ZSA9IHN0cmxlbihub2RlLT5uYW1lKTsKKwkJZG9tYWluLT5uYmVudHJ5LS07 CisJCW5vZGUtPnBlcm1zLnBbMF0uaWQgPSBwcml2X2RvbWlkOworCQlub2Rl LT5hY2MubWVtb3J5ID0gMDsKKwkJZG9tYWluX2VudHJ5X2luYyhOVUxMLCBu b2RlKTsKKwkJaWYgKHdyaXRlX25vZGVfcmF3KE5VTEwsICZrZXksIG5vZGUs IHRydWUpKSB7CisJCQkvKiBUaGF0J3MgdW5mb3J0dW5hdGUuIFdlIG9ubHkg Y2FuIHRyeSB0byBjb250aW51ZS4gKi8KKwkJCXN5c2xvZyhMT0dfRVJSLAor CQkJICAgICAgICJlcnJvciB3aGVuIG1vdmluZyBvcnBoYW5lZCBub2RlICVz IHRvIGRvbTBcbiIsCisJCQkgICAgICAgbm9kZS0+bmFtZSk7CisJCX0gZWxz ZQorCQkJdHJhY2UoIm9ycGhhbmVkIG5vZGUgJXMgbW92ZWQgdG8gZG9tMFxu Iiwgbm9kZS0+bmFtZSk7CisJfSBlbHNlIHsKKwkJaWYgKHJtX25vZGUoTlVM TCwgY3R4LCBub2RlLT5uYW1lKSkgeworCQkJLyogVGhhdCdzIHVuZm9ydHVu YXRlLiBXZSBvbmx5IGNhbiB0cnkgdG8gY29udGludWUuICovCisJCQlzeXNs b2coTE9HX0VSUiwKKwkJCSAgICAgICAiZXJyb3Igd2hlbiBkZWxldGluZyBv cnBoYW5lZCBub2RlICVzXG4iLAorCQkJICAgICAgIG5vZGUtPm5hbWUpOwor CQl9IGVsc2UKKwkJCXRyYWNlKCJvcnBoYW5lZCBub2RlICVzIGRlbGV0ZWRc biIsIG5vZGUtPm5hbWUpOworCisJCS8qIFNraXAgY2hpbGRyZW4gaW4gYWxs IGNhc2VzIGluIG9yZGVyIHRvIGF2b2lkIG1vcmUgZXJyb3JzLiAqLworCQly ZXQgPSBXQUxLX1RSRUVfU0tJUF9DSElMRFJFTjsKKwl9CisKKwlyZXR1cm4g ZG9tYWluLT5uYmVudHJ5ID4gMCA/IHJldCA6IFdBTEtfVFJFRV9TVUNDRVNT X1NUT1A7Cit9CisKK3N0YXRpYyB2b2lkIGRvbWFpbl90cmVlX3JlbW92ZShz dHJ1Y3QgZG9tYWluICpkb21haW4pCit7CisJaW50IHJldDsKKwlzdHJ1Y3Qg d2Fsa19mdW5jcyB3YWxrZnVuY3MgPSB7IC5lbnRlciA9IGRvbWFpbl90cmVl X3JlbW92ZV9zdWIgfTsKKworCWlmIChkb21haW4tPm5iZW50cnkgPiAwKSB7 CisJCXJldCA9IHdhbGtfbm9kZV90cmVlKGRvbWFpbiwgTlVMTCwgIi8iLCAm d2Fsa2Z1bmNzLCBkb21haW4pOworCQlpZiAocmV0ID09IFdBTEtfVFJFRV9F UlJPUl9TVE9QKQorCQkJc3lzbG9nKExPR19FUlIsCisJCQkgICAgICAgImVy cm9yIHdoZW4gbG9va2luZyBmb3Igb3JwaGFuZWQgbm9kZXNcbiIpOworCX0K K30KKwogc3RhdGljIGludCBkZXN0cm95X2RvbWFpbih2b2lkICpfZG9tYWlu KQogewogCXN0cnVjdCBkb21haW4gKmRvbWFpbiA9IF9kb21haW47CiAKKwlk b21haW5fdHJlZV9yZW1vdmUoZG9tYWluKTsKKwogCWxpc3RfZGVsKCZkb21h aW4tPmxpc3QpOwogCiAJaWYgKCFkb21haW4tPmludHJvZHVjZWQpCkBAIC04 NDUsMTUgKzkwMCwxNSBAQCBpbnQgZG9tYWluX2VudHJ5X2luYyhzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKm5vZGUpCiAJc3RydWN0 IGRvbWFpbiAqZDsKIAl1bnNpZ25lZCBpbnQgZG9taWQ7CiAKLQlpZiAoIWNv bm4pCisJaWYgKCFub2RlLT5wZXJtcy5wKQogCQlyZXR1cm4gMDsKIAotCWRv bWlkID0gbm9kZS0+cGVybXMucCA/IG5vZGUtPnBlcm1zLnBbMF0uaWQgOiBj b25uLT5pZDsKKwlkb21pZCA9IG5vZGUtPnBlcm1zLnBbMF0uaWQ7CiAKLQlp ZiAoY29ubi0+dHJhbnNhY3Rpb24pIHsKKwlpZiAoY29ubiAmJiBjb25uLT50 cmFuc2FjdGlvbikgewogCQl0cmFuc2FjdGlvbl9lbnRyeV9pbmMoY29ubi0+ dHJhbnNhY3Rpb24sIGRvbWlkKTsKIAl9IGVsc2UgewotCQlkID0gKGRvbWlk ID09IGNvbm4tPmlkICYmIGNvbm4tPmRvbWFpbikgPyBjb25uLT5kb21haW4K KwkJZCA9IChjb25uICYmIGRvbWlkID09IGNvbm4tPmlkICYmIGNvbm4tPmRv bWFpbikgPyBjb25uLT5kb21haW4KIAkJICAgIDogZmluZF9vcl9hbGxvY19l eGlzdGluZ19kb21haW4oZG9taWQpOwogCQlpZiAoZCkKIAkJCWQtPm5iZW50 cnkrKzsKQEAgLTkxNCwyMyArOTY5LDExIEBAIGludCBkb21haW5fYWxsb2Nf cGVybXJlZnMoc3RydWN0IG5vZGVfcGVybXMgKnBlcm1zKQogICogUmVtb3Zl IHBlcm1pc3Npb25zIGZvciBubyBsb25nZXIgZXhpc3RpbmcgZG9tYWlucyBp biBvcmRlciB0byBhdm9pZCBhIG5ldwogICogZG9tYWluIHdpdGggdGhlIHNh bWUgZG9taWQgaW5oZXJpdGluZyB0aGUgcGVybWlzc2lvbnMuCiAgKi8KLWlu dCBkb21haW5fYWRqdXN0X25vZGVfcGVybXMoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQoraW50IGRvbWFpbl9hZGp1c3Rf bm9kZV9wZXJtcyhzdHJ1Y3Qgbm9kZSAqbm9kZSkKIHsKIAl1bnNpZ25lZCBp bnQgaTsKIAlpbnQgcmV0OwogCi0JcmV0ID0gY2hrX2RvbWFpbl9nZW5lcmF0 aW9uKG5vZGUtPnBlcm1zLnBbMF0uaWQsIG5vZGUtPmdlbmVyYXRpb24pOwot Ci0JLyogSWYgdGhlIG93bmVyIGRvZXNuJ3QgZXhpc3QgYW55IGxvbmdlciBn aXZlIGl0IHRvIHByaXYgZG9tYWluLiAqLwotCWlmICghcmV0KSB7Ci0JCS8q Ci0JCSAqIEluIHRoZW9yeSB3ZSdkIG5lZWQgdG8gdXBkYXRlIHRoZSBudW1i ZXIgb2YgZG9tMCBub2RlcyBoZXJlLAotCQkgKiBidXQgd2UgY291bGQgYmUg Y2FsbGVkIGZvciBhIHJlYWQgb2YgdGhlIG5vZGUuIFNvIGJldHRlcgotCQkg KiBhdm9pZCB0aGUgcmlzayB0byBvdmVyZmxvdyB0aGUgbm9kZSBjb3VudCBv ZiBkb20wLgotCQkgKi8KLQkJbm9kZS0+cGVybXMucFswXS5pZCA9IHByaXZf ZG9taWQ7Ci0JfQotCiAJZm9yIChpID0gMTsgaSA8IG5vZGUtPnBlcm1zLm51 bTsgaSsrKSB7CiAJCWlmIChub2RlLT5wZXJtcy5wW2ldLnBlcm1zICYgWFNf UEVSTV9JR05PUkUpCiAJCQljb250aW51ZTsKQEAgLTk0OCwxNSArOTkxLDE1 IEBAIHZvaWQgZG9tYWluX2VudHJ5X2RlYyhzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgc3RydWN0IG5vZGUgKm5vZGUpCiAJc3RydWN0IGRvbWFpbiAqZDsK IAl1bnNpZ25lZCBpbnQgZG9taWQ7CiAKLQlpZiAoIWNvbm4pCisJaWYgKCFu b2RlLT5wZXJtcy5wKQogCQlyZXR1cm47CiAKIAlkb21pZCA9IG5vZGUtPnBl cm1zLnAgPyBub2RlLT5wZXJtcy5wWzBdLmlkIDogY29ubi0+aWQ7CiAKLQlp ZiAoY29ubi0+dHJhbnNhY3Rpb24pIHsKKwlpZiAoY29ubiAmJiBjb25uLT50 cmFuc2FjdGlvbikgewogCQl0cmFuc2FjdGlvbl9lbnRyeV9kZWMoY29ubi0+ dHJhbnNhY3Rpb24sIGRvbWlkKTsKIAl9IGVsc2UgewotCQlkID0gKGRvbWlk ID09IGNvbm4tPmlkICYmIGNvbm4tPmRvbWFpbikgPyBjb25uLT5kb21haW4K KwkJZCA9IChjb25uICYmIGRvbWlkID09IGNvbm4tPmlkICYmIGNvbm4tPmRv bWFpbikgPyBjb25uLT5kb21haW4KIAkJICAgIDogZmluZF9kb21haW5fc3Ry dWN0KGRvbWlkKTsKIAkJaWYgKGQpIHsKIAkJCWQtPm5iZW50cnktLTsKQEAg LTEwNzUsNyArMTExOCw3IEBAIGludCBkb21haW5fbWVtb3J5X2FkZCh1bnNp Z25lZCBpbnQgZG9taWQsIGludCBtZW0sIGJvb2wgbm9fcXVvdGFfY2hlY2sp CiAJCSAqIGV4aXN0LCBhcyBhY2NvdW50aW5nIGlzIGRvbmUgZWl0aGVyIGZv ciBhIGRvbWFpbiByZWxhdGVkIHRvCiAJCSAqIHRoZSBjdXJyZW50IGNvbm5l Y3Rpb24sIG9yIGZvciB0aGUgZG9tYWluIG93bmluZyBhIG5vZGUKIAkJICog KHdoaWNoIGlzIGFsd2F5cyBleGlzdGluZywgYXMgdGhlIG93bmVyIG9mIHRo ZSBub2RlIGlzCi0JCSAqIHRlc3RlZCB0byBleGlzdCBhbmQgcmVwbGFjZWQg YnkgZG9taWQgMCBpZiBub3QpLgorCQkgKiB0ZXN0ZWQgdG8gZXhpc3QgYW5k IGRlbGV0ZWQgb3IgcmVwbGFjZWQgYnkgZG9taWQgMCBpZiBub3QpLgogCQkg KiBTbyBub3QgZmluZGluZyB0aGUgcmVsYXRlZCBkb21haW4gTVVTVCBiZSBh biBlcnJvciBpbiB0aGUKIAkJICogZGF0YSBiYXNlLgogCQkgKi8KZGlmZiAt LWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaCBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaAppbmRleCBiYWI0MDUy MDllMmEuLjViZDI1MzM5NWQ3NyAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2RvbWFpbi5oCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9kb21haW4uaApAQCAtNjQsNyArNjQsNyBAQCBib29sIGRvbWFp bl9jYW5fd3JpdGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pOwogYm9vbCBk b21haW5faXNfdW5wcml2aWxlZ2VkKHN0cnVjdCBjb25uZWN0aW9uICpjb25u KTsKIAogLyogUmVtb3ZlIG5vZGUgcGVybWlzc2lvbnMgZm9yIG5vIGxvbmdl ciBleGlzdGluZyBkb21haW5zLiAqLwotaW50IGRvbWFpbl9hZGp1c3Rfbm9k ZV9wZXJtcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUg Km5vZGUpOworaW50IGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhzdHJ1Y3Qg bm9kZSAqbm9kZSk7CiBpbnQgZG9tYWluX2FsbG9jX3Blcm1yZWZzKHN0cnVj dCBub2RlX3Blcm1zICpwZXJtcyk7CiAKIC8qIFF1b3RhIG1hbmlwdWxhdGlv biAqLwo= --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-4.13-xenstored-02.patch" Content-Disposition: attachment; filename="xsa419/xsa419-4.13-xenstored-02.patch" Content-Transfer-Encoding: base64 RnJvbSA2NTY4NDhhNWRjMzE0ZDgzMDAzOGRmMmFjNmM4NmU0MmE2YTg5NTU3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTMgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IG1ha2UgdGhl IGludGVybmFsIG1lbW9yeSBkYXRhIGJhc2UgdGhlIGRlZmF1bHQKCkhhdmlu ZyBhIGZpbGUgYmFja2VkIGRhdGEgYmFzZSBoYXMgdGhlIG9ubHkgYWR2YW50 YWdlIG9mIGJlaW5nIGNhcGFibGUKdG8gZHVtcCB0aGUgY29udGVudHMgb2Yg aXQgd2hpbGUgWGVuc3RvcmUgaXMgcnVubmluZywgYW5kIHBvdGVudGlhbGx5 CnVzaW5nIGxlc3Mgc3dhcCBzcGFjZSBpbiBjYXNlIHRoZSBkYXRhIGJhc2Ug Y2FuJ3QgYmUga2VwdCBpbiBtZW1vcnkuCgpJdCBoYXMgdGhlIG1ham9yIGRp c2FkdmFudGFnZSBvZiBhIGh1Z2UgcGVyZm9ybWFuY2Ugb3ZlcmhlYWQ6IHN3 aXRjaGluZwp0byBrZWVwIHRoZSBkYXRhIGJhc2UgaW4gbWVtb3J5IG9ubHkg c3BlZWRzIHVwIGxpdmUgdXBkYXRlIG9mIHhlbnN0b3JlZAp3aXRoIDEyMDAw MCBub2RlcyBmcm9tIDIwIG1pbnV0ZXMgdG8gMTEgc2Vjb25kcy4gQSBjb21w bGV0ZSB0cmVlIHdhbGsKb2YgdGhpcyBjb25maWd1cmF0aW9uIHdpbGwgYmUg cmVkdWNlZCBmcm9tIDcgc2Vjb25kcyB0byAyODAgbXNlY3MKKG1lYXN1cmVk IGJ5ICJ4ZW5zdG9yZS1jb250cm9sIGNoZWNrIikuCgpTbyBtYWtlIHRoZSBp bnRlcm5hbCBtZW1vcnkgZGF0YSBiYXNlIHRoZSBkZWZhdWx0IGFuZCBlbmhh bmNlIHRoZQoiLS1pbnRlcm5hbC1kYiIgY29tbWFuZCBsaW5lIHBhcmFtZXRl ciB0byB0YWtlIGFuIG9wdGlvbmFsIHBhcmFtZXRlcgphbGxvd2luZyB0byBz d2l0Y2ggdGhlIGludGVybmFsIGRhdGEgYmFzZSBiYWNrIHRvIHRoZSBmaWxl IGJhc2VkIG9uZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtNDE5LgoKUmVwb3J0 ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KU2lnbmVk LW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZp ZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCmRp ZmYgLS1naXQgYS90b29scy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWlu LmMgYi90b29scy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWluLmMKaW5k ZXggYWRiODQwOGI2M2MyLi5iNGQ3ZWQ1NzNlY2MgMTAwNjQ0Ci0tLSBhL3Rv b2xzL2hlbHBlcnMvaW5pdC14ZW5zdG9yZS1kb21haW4uYworKysgYi90b29s cy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWluLmMKQEAgLTEyOCw5ICsx MjgsOSBAQCBzdGF0aWMgaW50IGJ1aWxkKHhjX2ludGVyZmFjZSAqeGNoKQog ICAgIH0KIAogICAgIGlmICggcGFyYW0gKQotICAgICAgICBzbnByaW50Zihj bWRsaW5lLCA1MTIsICItLWV2ZW50ICVkIC0taW50ZXJuYWwtZGIgJXMiLCBy diwgcGFyYW0pOworICAgICAgICBzbnByaW50ZihjbWRsaW5lLCA1MTIsICIt LWV2ZW50ICVkICVzIiwgcnYsIHBhcmFtKTsKICAgICBlbHNlCi0gICAgICAg IHNucHJpbnRmKGNtZGxpbmUsIDUxMiwgIi0tZXZlbnQgJWQgLS1pbnRlcm5h bC1kYiIsIHJ2KTsKKyAgICAgICAgc25wcmludGYoY21kbGluZSwgNTEyLCAi LS1ldmVudCAlZCIsIHJ2KTsKIAogICAgIGRvbSA9IHhjX2RvbV9hbGxvY2F0 ZSh4Y2gsIGNtZGxpbmUsIE5VTEwpOwogICAgIHJ2ID0geGNfZG9tX2tlcm5l bF9maWxlKGRvbSwga2VybmVsKTsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5jCmluZGV4IDdlYjY5OGUxZmMyMi4uNjgzNTU0ZmYyY2RlIDEw MDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisr KyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTIxMzIs NyArMjEzMiw3IEBAIHN0YXRpYyB2b2lkIGFjY2VwdF9jb25uZWN0aW9uKGlu dCBzb2NrLCBib29sIGNhbndyaXRlKQogfQogI2VuZGlmCiAKLXN0YXRpYyBp bnQgdGRiX2ZsYWdzOworc3RhdGljIGludCB0ZGJfZmxhZ3MgPSBUREJfSU5U RVJOQUwgfCBUREJfTk9MT0NLOwogCiAvKiBXZSBjcmVhdGUgaW5pdGlhbCBu b2RlcyBtYW51YWxseS4gKi8KIHN0YXRpYyB2b2lkIG1hbnVhbF9ub2RlKGNv bnN0IGNoYXIgKm5hbWUsIGNvbnN0IGNoYXIgKmNoaWxkKQpAQCAtMjQ2MSw3 ICsyNDYxLDggQEAgc3RhdGljIHZvaWQgdXNhZ2Uodm9pZCkKICIgICAgICAg ICAgICAgICAgICAgICAgICAgIHdhdGNoLWV2ZW50OiB0aW1lIGEgd2F0Y2gt ZXZlbnQgaXMga2VwdCBwZW5kaW5nXG4iCiAiICAtUiwgLS1uby1yZWNvdmVy eSAgICAgICB0byByZXF1ZXN0IHRoYXQgbm8gcmVjb3Zlcnkgc2hvdWxkIGJl IGF0dGVtcHRlZCB3aGVuXG4iCiAiICAgICAgICAgICAgICAgICAgICAgICAg ICB0aGUgc3RvcmUgaXMgY29ycnVwdGVkIChkZWJ1ZyBvbmx5KSxcbiIKLSIg IC1JLCAtLWludGVybmFsLWRiICAgICAgIHN0b3JlIGRhdGFiYXNlIGluIG1l bW9yeSwgbm90IG9uIGRpc2tcbiIKKyIgIC1JLCAtLWludGVybmFsLWRiIFtv bnxvZmZdIHN0b3JlIGRhdGFiYXNlIGluIG1lbW9yeSwgbm90IG9uIGRpc2ss IGRlZmF1bHQgaXNcbiIKKyIgICAgICAgICAgICAgICAgICAgICAgICAgIG1l bW9yeSwgd2l0aCBcIi0taW50ZXJuYWwtZGIgb2ZmXCIgaXQgaXMgb24gZGlz a1xuIgogIiAgLUssIC0ta2VlcC1vcnBoYW5zICAgICAgZG9uJ3QgZGVsZXRl IG5vZGVzIG93bmVkIGJ5IGEgZG9tYWluIHdoZW4gdGhlXG4iCiAiICAgICAg ICAgICAgICAgICAgICAgICAgICBkb21haW4gaXMgZGVsZXRlZCAodGhpcyBp cyBhIHNlY3VyaXR5IHJpc2shKVxuIgogIiAgLVYsIC0tdmVyYm9zZSAgICAg ICAgICAgdG8gcmVxdWVzdCB2ZXJib3NlIGV4ZWN1dGlvbi5cbiIpOwpAQCAt MjQ4Niw3ICsyNDg3LDcgQEAgc3RhdGljIHN0cnVjdCBvcHRpb24gb3B0aW9u c1tdID0gewogCXsgInF1b3RhLXNvZnQiLCAxLCBOVUxMLCAncScgfSwKIAl7 ICJ0aW1lb3V0IiwgMSwgTlVMTCwgJ3cnIH0sCiAJeyAibm8tcmVjb3Zlcnki LCAwLCBOVUxMLCAnUicgfSwKLQl7ICJpbnRlcm5hbC1kYiIsIDAsIE5VTEws ICdJJyB9LAorCXsgImludGVybmFsLWRiIiwgMiwgTlVMTCwgJ0knIH0sCiAJ eyAia2VlcC1vcnBoYW5zIiwgMCwgTlVMTCwgJ0snIH0sCiAJeyAidmVyYm9z ZSIsIDAsIE5VTEwsICdWJyB9LAogCXsgIndhdGNoLW5iIiwgMSwgTlVMTCwg J1cnIH0sCkBAIC0yNTYyLDcgKzI1NjMsOCBAQCBpbnQgbWFpbihpbnQgYXJn YywgY2hhciAqYXJndltdKQogCWludCB0aW1lb3V0OwogCiAKLQl3aGlsZSAo KG9wdCA9IGdldG9wdF9sb25nKGFyZ2MsIGFyZ3YsICJERTpGOkhLTlBTOnQ6 QTpROnE6VDpSVlc6dzoiLCBvcHRpb25zLAorCXdoaWxlICgob3B0ID0gZ2V0 b3B0X2xvbmcoYXJnYywgYXJndiwKKwkJCQkgICJERTpGOkhJOjpLTlBTOnQ6 QTpROnE6VDpSVlc6dzoiLCBvcHRpb25zLAogCQkJCSAgTlVMTCkpICE9IC0x KSB7CiAJCXN3aXRjaCAob3B0KSB7CiAJCWNhc2UgJ0QnOgpAQCAtMjU5Niw3 ICsyNTk4LDggQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkK IAkJCXRyYWNlZmlsZSA9IG9wdGFyZzsKIAkJCWJyZWFrOwogCQljYXNlICdJ JzoKLQkJCXRkYl9mbGFncyA9IFREQl9JTlRFUk5BTHxUREJfTk9MT0NLOwor CQkJaWYgKG9wdGFyZyAmJiAhc3RyY21wKG9wdGFyZywgIm9mZiIpKQorCQkJ CXRkYl9mbGFncyA9IDA7CiAJCQlicmVhazsKIAkJY2FzZSAnSyc6CiAJCQlr ZWVwX29ycGhhbnMgPSB0cnVlOwo= --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-4.13-xenstored-03.patch" Content-Disposition: attachment; filename="xsa419/xsa419-4.13-xenstored-03.patch" Content-Transfer-Encoding: base64 RnJvbSBkYTRlMzM5MjFjNDhiYTVmN2IyMDZlMzAzNGIyMWRiNTU4NmE2OTAw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTMgKzAyMDAKU3ViamVjdDogZG9jczogZW5oYW5jZSB4ZW5zdG9yZS50 eHQgd2l0aCBwZXJtaXNzaW9ucyBkZXNjcmlwdGlvbgpNSU1FLVZlcnNpb246 IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgK Q29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKVGhlIHBlcm1pc3Np b24gc2NoZW1lIG9mIFhlbnN0b3JlIG5vZGVzIGlzIG5vdCByZWFsbHkgY292 ZXJlZCBieQpkb2NzL21pc2MveGVuc3RvcmUudHh0LCBvdGhlciB0aGFuIHJl ZmVycmluZyB0byB0aGUgWGVuIHdpa2kuCgpBZGQgYSBwYXJhZ3JhcGggZXhw bGFpbmluZyB0aGUgcGVybWlzc2lvbnMgb2Ygbm9kZXMsIGFuZCBlc3BlY2lh bGx5Cm1lbnRpb25pbmcgcmVtb3ZhbCBvZiBub2RlcyB3aGVuIGEgZG9tYWlu IGhhcyBiZWVuIHJlbW92ZWQgZnJvbQpYZW5zdG9yZS4KClRoaXMgaXMgcGFy dCBvZiBYU0EtNDE5LgoKUmVwb3J0ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpn cm9zc0BzdXNlLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8 amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogRWR3aW4gVMO2csO2ayA8 ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvZG9jcy9taXNj L3hlbnN0b3JlLnR4dCBiL2RvY3MvbWlzYy94ZW5zdG9yZS50eHQKaW5kZXgg MGRiYWM0NDJkNzlkLi5kNTA4NGJjYmFhMDEgMTAwNjQ0Ci0tLSBhL2RvY3Mv bWlzYy94ZW5zdG9yZS50eHQKKysrIGIvZG9jcy9taXNjL3hlbnN0b3JlLnR4 dApAQCAtNDMsNiArNDMsMTcgQEAgYnl0ZXMgYXJlIGZvcmJpZGRlbjsgY2xp ZW50cyBzcGVjaWZ5aW5nIHJlbGF0aXZlIHBhdGhzIHNob3VsZCBrZWVwCiB0 aGVtIHRvIHdpdGhpbiAyMDQ4IGJ5dGVzLiAgKFNlZSBYRU5TVE9SRV8qX1BB VEhfTUFYIGluIHhzX3dpcmUuaC4pCiAKIAorRWFjaCBub2RlIGhhcyBvbmUg b3IgbXVsdGlwbGUgcGVybWlzc2lvbiBlbnRyaWVzLiAgUGVybWlzc2lvbnMg YXJlCitncmFudGVkIGJ5IGRvbWFpbi1pZCwgdGhlIGZpcnN0IHBlcm1pc3Np b24gZW50cnkgb2YgZWFjaCBub2RlIHNwZWNpZmllcwordGhlIG93bmVyIG9m IHRoZSBub2RlLiAgUGVybWlzc2lvbnMgb2YgYSBub2RlIGNhbiBiZSBjaGFu Z2VkIGJ5IHRoZQorb3duZXIgb2YgdGhlIG5vZGUsIHRoZSBvd25lciBjYW4g b25seSBiZSBtb2RpZmllZCBieSB0aGUgY29udHJvbAorZG9tYWluICh1c3Vh bGx5IGRvbWFpbiBpZCAwKS4gIFRoZSBvd25lciBhbHdheXMgaGFzIHRoZSBy aWdodCB0byByZWFkCithbmQgd3JpdGUgdGhlIG5vZGUsIHdoaWxlIG90aGVy IHBlcm1pc3Npb25zIGNhbiBiZSBzZXR1cCB0byBhbGxvdworcmVhZCBhbmQv b3Igd3JpdGUgYWNjZXNzLiAgV2hlbiBhIGRvbWFpbiBpcyBiZWluZyByZW1v dmVkIGZyb20gWGVuc3RvcmUKK25vZGVzIG93bmVkIGJ5IHRoYXQgZG9tYWlu IHdpbGwgYmUgcmVtb3ZlZCB0b2dldGhlciB3aXRoIGFsbCBvZiB0aG9zZQor bm9kZXMnIGNoaWxkcmVuLgorCisKIENvbW11bmljYXRpb24gd2l0aCB4ZW5z dG9yZSBpcyB2aWEgZWl0aGVyIHNvY2tldHMsIG9yIGV2ZW50IGNoYW5uZWwK IGFuZCBzaGFyZWQgbWVtb3J5LCBhcyBzcGVjaWZpZWQgaW4gaW8veHNfd2ly ZS5oOiBlYWNoIG1lc3NhZ2UgaW4KIGVpdGhlciBkaXJlY3Rpb24gaXMgYSBo ZWFkZXIgZm9ybWF0dGVkIGFzIGEgc3RydWN0IHhzZF9zb2NrbXNnCg== --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-4.14-oxenstored.patch" Content-Disposition: attachment; filename="xsa419/xsa419-4.14-oxenstored.patch" Content-Transfer-Encoding: base64 RnJvbSAyZDZmZTQzOTM2YWIwMGJlZjlhODRiMGE2MGIxNTQ2NzMxNDMzOTIw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNiArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IEZpeCBxdW90YSBieXBhc3Mg b24gZG9tYWluIHNodXRkb3duCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQt VHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5z ZmVyLUVuY29kaW5nOiA4Yml0CgpYU0EtMzIyIGZpeGVkIGEgZG9taWQgcmV1 c2UgdnVsbmVyYWJpbGl0eSBieSBhc3NpZ25pbmcgRG9tMCBhcyB0aGUgb3du ZXIgb2YKYW55IG5vZGVzIGxlZnQgYWZ0ZXIgYSBkb21haW4gaXMgc2h1dGRv d24gKGUuZy4gb3V0c2lkZSBpdHMgL2xvY2FsL2RvbWFpbi9OCnRyZWUpLgoK SG93ZXZlciBEb20wIGhhcyBubyBxdW90YSBvbiBwdXJwb3NlLCBzbyB0aGlz IG9wZW5lZCB1cCBhbm90aGVyIHBvdGVudGlhbAphdHRhY2sgdmVjdG9yLiBB dm9pZCBpdCBieSBkZWxldGluZyB0aGVzZSBub2RlcyBpbnN0ZWFkIG9mIGFz c2lnbmluZyB0aGVtIHRvCkRvbTAuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQx OSAvIENWRS0yMDIyLTQyMzIzLgoKUmVwb3J0ZWQtYnk6IEp1ZXJnZW4gR3Jv c3MgPGpncm9zc0BzdXNlLmNvbT4KRml4ZXM6IGM0NmVmZjkyMTIwOSAoInRv b2xzL29jYW1sL3hlbnN0b3JlZDogY2xlYW4gdXAgcGVybWlzc2lvbnMgZm9y IGRlYWQgZG9tYWlucyIpClNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLDtmsg PGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJpc3RpYW4g TGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+CgpkaWZmIC0t Z2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Blcm1zLm1sIGIvdG9vbHMv b2NhbWwveGVuc3RvcmVkL3Blcm1zLm1sCmluZGV4IGU4YTE2MjIxZjhmYS4u ODRmMjUwM2U4ZTI5IDEwMDY0NAotLS0gYS90b29scy9vY2FtbC94ZW5zdG9y ZWQvcGVybXMubWwKKysrIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Blcm1z Lm1sCkBAIC02NCw4ICs2NCw3IEBAIGxldCBnZXRfb3duZXIgcGVybSA9IHBl cm0ub3duZXIKICogKikKIGxldCByZW1vdmVfZG9taWQgfmRvbWlkIHBlcm0g PQogCWxldCBhY2wgPSBMaXN0LmZpbHRlciAoZnVuIChhY2xfZG9taWQsIF8p IC0+IGFjbF9kb21pZCA8PiBkb21pZCkgcGVybS5hY2wgaW4KLQlsZXQgb3du ZXIgPSBpZiBwZXJtLm93bmVyID0gZG9taWQgdGhlbiAwIGVsc2UgcGVybS5v d25lciBpbgotCXsgcGVybSB3aXRoIGFjbDsgb3duZXIgfQorCWlmIHBlcm0u b3duZXIgPSBkb21pZCB0aGVuIE5vbmUgZWxzZSBTb21lIHsgcGVybSB3aXRo IGFjbDsgb3duZXIgPSBwZXJtLm93bmVyIH0KIAogbGV0IGRlZmF1bHQwID0g Y3JlYXRlIDAgTk9ORSBbXQogCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94 ZW5zdG9yZWQvc3RvcmUubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvc3Rv cmUubWwKaW5kZXggMzI4ZDNhNTE5ODRmLi5kODI3NjRmNjBmYjQgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9zdG9yZS5tbAorKysgYi90 b29scy9vY2FtbC94ZW5zdG9yZWQvc3RvcmUubWwKQEAgLTg5LDEwICs4OSwy MSBAQCBsZXQgY2hlY2tfb3duZXIgbm9kZSBjb25uZWN0aW9uID0KIAogbGV0 IHJlYyByZWN1cnNlIGZjdCBub2RlID0gZmN0IG5vZGU7IExpc3QuaXRlciAo cmVjdXJzZSBmY3QpIG5vZGUuY2hpbGRyZW4KIAotKCoqIFtyZWN1cnNlX21h cCBmIHRyZWVdIGFwcGxpZXMgW2ZdIG9uIGVhY2ggbm9kZSBpbiB0aGUgdHJl ZSByZWN1cnNpdmVseSAqKQotbGV0IHJlY3Vyc2VfbWFwIGYgPQorKCoqIFty ZWN1cnNlX2ZpbHRlcl9tYXAgZiB0cmVlXSBhcHBsaWVzIFtmXSBvbiBlYWNo IG5vZGUgaW4gdGhlIHRyZWUgcmVjdXJzaXZlbHksCisgICAgcG9zc2libHkg cmVtb3Zpbmcgc29tZSBub2Rlcy4KKyAgICBOb3RlIHRoYXQgdGhlIG5vZGVz IHJlbW92ZWQgdGhpcyB3YXkgd29uJ3QgZ2VuZXJhdGUgd2F0Y2ggZXZlbnRz LgorKikKK2xldCByZWN1cnNlX2ZpbHRlcl9tYXAgZiA9CisJbGV0IGludmFs aWQgPSAtMSBpbgorCWxldCBpc192YWxpZCBub2RlID0gbm9kZS5wZXJtcy5v d25lciA8PiBpbnZhbGlkIGluCiAJbGV0IHJlYyB3YWxrIG5vZGUgPQotCQlm IHsgbm9kZSB3aXRoIGNoaWxkcmVuID0gTGlzdC5yZXZfbWFwIHdhbGsgbm9k ZS5jaGlsZHJlbiB8PiBMaXN0LnJldiB9CisJCSgqIE1hcC5maWx0ZXJfbWFw IGlzIE9jYW1sIDQuMTErIG9ubHkgKikKKwkJbGV0IG5vZGUgPQorCQl7IG5v ZGUgd2l0aCBjaGlsZHJlbiA9CisJCQlMaXN0LnJldl9tYXAgd2FsayBub2Rl LmNoaWxkcmVuIHw+IExpc3QuZmlsdGVyIGlzX3ZhbGlkIHw+IExpc3QucmV2 IH0gaW4KKwkJbWF0Y2ggZiBub2RlIHdpdGgKKwkJfCBTb21lIGtlZXAgLT4g a2VlcAorCQl8IE5vbmUgLT4geyBub2RlIHdpdGggcGVybXMgPSB7bm9kZS5w ZXJtcyB3aXRoIG93bmVyID0gaW52YWxpZCB9IH0KIAlpbgogCXdhbGsKIApA QCAtNDQ2LDExICs0NTcsMTMgQEAgbGV0IHNldHBlcm1zIHN0b3JlIHBlcm0g cGF0aCBucGVybXMgPQogCiBsZXQgcmVzZXRfcGVybWlzc2lvbnMgc3RvcmUg ZG9taWQgPQogCUxvZ2dpbmcuaW5mbyAic3RvcmV8bm9kZSIgIkNsZWFuaW5n IHVwIHhlbnN0b3JlIEFDTHMgZm9yIGRvbWlkICVkIiBkb21pZDsKLQlzdG9y ZS5yb290IDwtIE5vZGUucmVjdXJzZV9tYXAgKGZ1biBub2RlIC0+Ci0JCWxl dCBwZXJtcyA9IFBlcm1zLk5vZGUucmVtb3ZlX2RvbWlkIH5kb21pZCBub2Rl LnBlcm1zIGluCi0JCWlmIHBlcm1zIDw+IG5vZGUucGVybXMgdGhlbgotCQkJ TG9nZ2luZy5kZWJ1ZyAic3RvcmV8bm9kZSIgIkNoYW5nZWQgcGVybWlzc2lv bnMgZm9yIG5vZGUgJXMiIChOb2RlLmdldF9uYW1lIG5vZGUpOwotCQl7IG5v ZGUgd2l0aCBwZXJtcyB9CisJc3RvcmUucm9vdCA8LSBOb2RlLnJlY3Vyc2Vf ZmlsdGVyX21hcCAoZnVuIG5vZGUgLT4KKwkJbWF0Y2ggUGVybXMuTm9kZS5y ZW1vdmVfZG9taWQgfmRvbWlkIG5vZGUucGVybXMgd2l0aAorCQl8IE5vbmUg LT4gTm9uZQorCQl8IFNvbWUgcGVybXMgLT4KKwkJCWlmIHBlcm1zIDw+IG5v ZGUucGVybXMgdGhlbgorCQkJCUxvZ2dpbmcuZGVidWcgInN0b3JlfG5vZGUi ICJDaGFuZ2VkIHBlcm1pc3Npb25zIGZvciBub2RlICVzIiAoTm9kZS5nZXRf bmFtZSBub2RlKTsKKwkJCVNvbWUgeyBub2RlIHdpdGggcGVybXMgfQogCSkg c3RvcmUucm9vdAogCiB0eXBlIG9wcyA9IHsK --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-4.14-xenstored-01.patch" Content-Disposition: attachment; filename="xsa419/xsa419-4.14-xenstored-01.patch" Content-Transfer-Encoding: base64 RnJvbSA1NGY3Nzc3MmU4YWZjYzE1ZTNhMzg0MjE2NjQxZWFiYmU5YTA4ZGE4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHJlbW92ZSBu b2RlcyBvd25lZCBieSBkZXN0cm95ZWQgZG9tYWluCgpJbiBjYXNlIGEgZG9t YWluIGlzIHJlbW92ZWQgZnJvbSBYZW5zdG9yZSwgcmVtb3ZlIGFsbCBub2Rl cyBvd25lZCBieQppdCBwZXIgZGVmYXVsdC4KClRoaXMgdGFja2xlcyB0aGUg cHJvYmxlbSB0aGF0IG5vZGVzIG1pZ2h0IGJlIGNyZWF0ZWQgYnkgYSBkb21h aW4Kb3V0c2lkZSBpdHMgaG9tZSBwYXRoIGluIFhlbnN0b3JlLCBsZWFkaW5n IHRvIFhlbnN0b3JlIGhvZ2dpbmcgbW9yZQphbmQgbW9yZSBtZW1vcnkuIERv bWFpbiBxdW90YSBkb24ndCB3b3JrIGluIHRoaXMgY2FzZSBpZiB0aGUgZ3Vl c3QgaXMKcmVib290aW5nIGluIGJldHdlZW4uCgpTaW5jZSBYU0EtMzIyIG93 bmVyc2hpcCBvZiBzdWNoIHN0YWxlIG5vZGVzIGlzIHRyYW5zZmVycmVkIHRv IGRvbTAsCndoaWNoIGlzIGhlbHBpbmcgYWdhaW5zdCB1bmludGVuZGVkIGFj Y2VzcywgYnV0IG5vdCBhZ2FpbnN0IE9PTSBvZgpYZW5zdG9yZS4KCkFzIGEg ZmFsbGJhY2sgZm9yIHdlaXJkIGNhc2VzIGFkZCBhIFhlbnN0b3JlIHN0YXJ0 IHBhcmFtZXRlciBmb3IKa2VlcGluZyB0b2RheSdzIHdheSB0byBoYW5kbGUg c3RhbGUgbm9kZXMsIGFkZGluZyB0aGUgcmlzayBvZiBYZW5zdG9yZQpoaXR0 aW5nIGFuIE9PTSBzaXR1YXRpb24uCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQx OSAvIENWRS0yMDIyLTQyMzIyLgoKUmVwb3J0ZWQtYnk6IEp1ZXJnZW4gR3Jv c3MgPGpncm9zc0BzdXNlLmNvbT4KRml4ZXM6IDQ5NjMwNjMyNGQ4ZCAoInRv b2xzL3hlbnN0b3JlOiByZXZva2UgYWNjZXNzIHJpZ2h0cyBmb3IgcmVtb3Zl ZCBkb21haW5zIikKU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdy b3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3Jh bGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuYwppbmRleCA1YmI3Yjg1MjEzMjQuLmViMWQ3YzJiM2I5YiAxMDA2NDQK LS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC03OSw2ICs3OSw3 IEBAIHN0YXRpYyBib29sIHZlcmJvc2UgPSBmYWxzZTsKIExJU1RfSEVBRChj b25uZWN0aW9ucyk7CiBpbnQgdHJhY2VmZCA9IC0xOwogc3RhdGljIGJvb2wg cmVjb3ZlcnkgPSB0cnVlOworYm9vbCBrZWVwX29ycGhhbnMgPSBmYWxzZTsK IHN0YXRpYyBpbnQgcmVvcGVuX2xvZ19waXBlWzJdOwogc3RhdGljIGludCBy ZW9wZW5fbG9nX3BpcGUwX3BvbGxmZF9pZHggPSAtMTsKIGNoYXIgKnRyYWNl ZmlsZSA9IE5VTEw7CkBAIC02NjQsNyArNjY1LDcgQEAgc3RydWN0IG5vZGUg KnJlYWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9p ZCAqY3R4LAogCW5vZGUtPnBlcm1zLnAgPSBoZHItPnBlcm1zOwogCW5vZGUt PmFjYy5kb21pZCA9IG5vZGUtPnBlcm1zLnBbMF0uaWQ7CiAJbm9kZS0+YWNj Lm1lbW9yeSA9IGRhdGEuZHNpemU7Ci0JaWYgKGRvbWFpbl9hZGp1c3Rfbm9k ZV9wZXJtcyhjb25uLCBub2RlKSkKKwlpZiAoZG9tYWluX2FkanVzdF9ub2Rl X3Blcm1zKG5vZGUpKQogCQlnb3RvIGVycm9yOwogCiAJLyogSWYgb3duZXIg aXMgZ29uZSByZXNldCBjdXJyZW50bHkgYWNjb3VudGVkIG1lbW9yeSBzaXpl LiAqLwpAQCAtNzA3LDcgKzcwOCw3IEBAIGludCB3cml0ZV9ub2RlX3Jhdyhz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgVERCX0RBVEEgKmtleSwgc3RydWN0 IG5vZGUgKm5vZGUsCiAJdm9pZCAqcDsKIAlzdHJ1Y3QgeHNfdGRiX3JlY29y ZF9oZHIgKmhkcjsKIAotCWlmIChkb21haW5fYWRqdXN0X25vZGVfcGVybXMo Y29ubiwgbm9kZSkpCisJaWYgKGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhu b2RlKSkKIAkJcmV0dXJuIGVycm5vOwogCiAJZGF0YS5kc2l6ZSA9IHNpemVv ZigqaGRyKQpAQCAtMTU0OCw3ICsxNTQ5LDcgQEAgc3RhdGljIGludCBkZWxu b2RlX3N1Yihjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpj b25uLAogCXJldHVybiBXQUxLX1RSRUVfUk1fQ0hJTERFTlRSWTsKIH0KIAot c3RhdGljIGludCBfcm0oc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0 IHZvaWQgKmN0eCwgY29uc3QgY2hhciAqbmFtZSkKK2ludCBybV9ub2RlKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsIGNvbnN0 IGNoYXIgKm5hbWUpCiB7CiAJc3RydWN0IG5vZGUgKnBhcmVudDsKIAljaGFy ICpwYXJlbnRuYW1lID0gZ2V0X3BhcmVudChjdHgsIG5hbWUpOwpAQCAtMTYx MCw3ICsxNjExLDcgQEAgc3RhdGljIGludCBkb19ybShjb25zdCB2b2lkICpj dHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCWlmIChzdHJlcShuYW1l LCAiLyIpKQogCQlyZXR1cm4gRUlOVkFMOwogCi0JcmV0ID0gX3JtKGNvbm4s IGN0eCwgbmFtZSk7CisJcmV0ID0gcm1fbm9kZShjb25uLCBjdHgsIG5hbWUp OwogCWlmIChyZXQpCiAJCXJldHVybiByZXQ7CiAKQEAgLTI0NDYsNiArMjQ0 Nyw4IEBAIHN0YXRpYyB2b2lkIHVzYWdlKHZvaWQpCiAiICAtUiwgLS1uby1y ZWNvdmVyeSAgICAgICB0byByZXF1ZXN0IHRoYXQgbm8gcmVjb3Zlcnkgc2hv dWxkIGJlIGF0dGVtcHRlZCB3aGVuXG4iCiAiICAgICAgICAgICAgICAgICAg ICAgICAgICB0aGUgc3RvcmUgaXMgY29ycnVwdGVkIChkZWJ1ZyBvbmx5KSxc biIKICIgIC1JLCAtLWludGVybmFsLWRiICAgICAgIHN0b3JlIGRhdGFiYXNl IGluIG1lbW9yeSwgbm90IG9uIGRpc2tcbiIKKyIgIC1LLCAtLWtlZXAtb3Jw aGFucyAgICAgIGRvbid0IGRlbGV0ZSBub2RlcyBvd25lZCBieSBhIGRvbWFp biB3aGVuIHRoZVxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgZG9t YWluIGlzIGRlbGV0ZWQgKHRoaXMgaXMgYSBzZWN1cml0eSByaXNrISlcbiIK ICIgIC1WLCAtLXZlcmJvc2UgICAgICAgICAgIHRvIHJlcXVlc3QgdmVyYm9z ZSBleGVjdXRpb24uXG4iKTsKIH0KIApAQCAtMjQ2OSw2ICsyNDcyLDcgQEAg c3RhdGljIHN0cnVjdCBvcHRpb24gb3B0aW9uc1tdID0gewogCXsgInRpbWVv dXQiLCAxLCBOVUxMLCAndycgfSwKIAl7ICJuby1yZWNvdmVyeSIsIDAsIE5V TEwsICdSJyB9LAogCXsgImludGVybmFsLWRiIiwgMCwgTlVMTCwgJ0knIH0s CisJeyAia2VlcC1vcnBoYW5zIiwgMCwgTlVMTCwgJ0snIH0sCiAJeyAidmVy Ym9zZSIsIDAsIE5VTEwsICdWJyB9LAogCXsgIndhdGNoLW5iIiwgMSwgTlVM TCwgJ1cnIH0sCiAJeyBOVUxMLCAwLCBOVUxMLCAwIH0gfTsKQEAgLTI1NDMs NyArMjU0Nyw3IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10p CiAJaW50IHRpbWVvdXQ7CiAKIAotCXdoaWxlICgob3B0ID0gZ2V0b3B0X2xv bmcoYXJnYywgYXJndiwgIkRFOkY6SE5QUzp0OkE6UTpxOlQ6UlZXOnc6Iiwg b3B0aW9ucywKKwl3aGlsZSAoKG9wdCA9IGdldG9wdF9sb25nKGFyZ2MsIGFy Z3YsICJERTpGOkhLTlBTOnQ6QTpROnE6VDpSVlc6dzoiLCBvcHRpb25zLAog CQkJCSAgTlVMTCkpICE9IC0xKSB7CiAJCXN3aXRjaCAob3B0KSB7CiAJCWNh c2UgJ0QnOgpAQCAtMjU3OSw2ICsyNTgzLDkgQEAgaW50IG1haW4oaW50IGFy Z2MsIGNoYXIgKmFyZ3ZbXSkKIAkJY2FzZSAnSSc6CiAJCQl0ZGJfZmxhZ3Mg PSBUREJfSU5URVJOQUx8VERCX05PTE9DSzsKIAkJCWJyZWFrOworCQljYXNl ICdLJzoKKwkJCWtlZXBfb3JwaGFucyA9IHRydWU7CisJCQlicmVhazsKIAkJ Y2FzZSAnVic6CiAJCQl2ZXJib3NlID0gdHJ1ZTsKIAkJCWJyZWFrOwpkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKaW5kZXggZmM5ODgyYWMz N2Q1Li5lYzI0YzI3YWMyNDAgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuaApAQCAtMjA0LDYgKzIwNCw5IEBAIGludCB3cml0ZV9ub2Rl X3JhdyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgVERCX0RBVEEgKmtleSwg c3RydWN0IG5vZGUgKm5vZGUsCiBzdHJ1Y3Qgbm9kZSAqcmVhZF9ub2RlKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsCiAJCSAg ICAgICBjb25zdCBjaGFyICpuYW1lKTsKIAorLyogUmVtb3ZlIGEgbm9kZSBh bmQgaXRzIGNoaWxkcmVuLiAqLworaW50IHJtX25vZGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwgY29uc3QgY2hhciAqbmFt ZSk7CisKIHZvaWQgc2V0dXBfc3RydWN0dXJlKHZvaWQpOwogc3RydWN0IGNv bm5lY3Rpb24gKm5ld19jb25uZWN0aW9uKGNvbm53cml0ZWZuX3QgKndyaXRl LCBjb25ucmVhZGZuX3QgKnJlYWQpOwogdm9pZCBjaGVja19zdG9yZSh2b2lk KTsKQEAgLTI0Miw2ICsyNDUsNyBAQCBleHRlcm4gaW50IHF1b3RhX3JlcV9v dXRzdGFuZGluZzsKIGV4dGVybiBpbnQgcXVvdGFfdHJhbnNfbm9kZXM7CiBl eHRlcm4gaW50IHF1b3RhX21lbW9yeV9wZXJfZG9tYWluX3NvZnQ7CiBleHRl cm4gaW50IHF1b3RhX21lbW9yeV9wZXJfZG9tYWluX2hhcmQ7CitleHRlcm4g Ym9vbCBrZWVwX29ycGhhbnM7CiAKIGV4dGVybiB1bnNpZ25lZCBpbnQgdGlt ZW91dF93YXRjaF9ldmVudF9tc2VjOwogCmRpZmYgLS1naXQgYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMgYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfZG9tYWluLmMKaW5kZXggMWMyOWY2ODU0MTE5Li45ZTYzZWMy M2E5MjIgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9k b21haW4uYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWlu LmMKQEAgLTIwMCwxMCArMjAwLDY1IEBAIHN0YXRpYyB2b2lkIHVubWFwX2lu dGVyZmFjZSh2b2lkICppbnRlcmZhY2UpCiAJeGVuZ250dGFiX3VubWFwKCp4 Z3RfaGFuZGxlLCBpbnRlcmZhY2UsIDEpOwogfQogCitzdGF0aWMgaW50IGRv bWFpbl90cmVlX3JlbW92ZV9zdWIoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKKwkJCQkgIHN0cnVjdCBub2RlICpub2RlLCB2 b2lkICphcmcpCit7CisJc3RydWN0IGRvbWFpbiAqZG9tYWluID0gYXJnOwor CVREQl9EQVRBIGtleTsKKwlpbnQgcmV0ID0gV0FMS19UUkVFX09LOworCisJ aWYgKG5vZGUtPnBlcm1zLnBbMF0uaWQgIT0gZG9tYWluLT5kb21pZCkKKwkJ cmV0dXJuIFdBTEtfVFJFRV9PSzsKKworCWlmIChrZWVwX29ycGhhbnMpIHsK KwkJa2V5LmRwdHIgPSAoY2hhciAqKW5vZGUtPm5hbWU7CisJCWtleS5kc2l6 ZSA9IHN0cmxlbihub2RlLT5uYW1lKTsKKwkJZG9tYWluLT5uYmVudHJ5LS07 CisJCW5vZGUtPnBlcm1zLnBbMF0uaWQgPSBwcml2X2RvbWlkOworCQlub2Rl LT5hY2MubWVtb3J5ID0gMDsKKwkJZG9tYWluX2VudHJ5X2luYyhOVUxMLCBu b2RlKTsKKwkJaWYgKHdyaXRlX25vZGVfcmF3KE5VTEwsICZrZXksIG5vZGUs IHRydWUpKSB7CisJCQkvKiBUaGF0J3MgdW5mb3J0dW5hdGUuIFdlIG9ubHkg Y2FuIHRyeSB0byBjb250aW51ZS4gKi8KKwkJCXN5c2xvZyhMT0dfRVJSLAor CQkJICAgICAgICJlcnJvciB3aGVuIG1vdmluZyBvcnBoYW5lZCBub2RlICVz IHRvIGRvbTBcbiIsCisJCQkgICAgICAgbm9kZS0+bmFtZSk7CisJCX0gZWxz ZQorCQkJdHJhY2UoIm9ycGhhbmVkIG5vZGUgJXMgbW92ZWQgdG8gZG9tMFxu Iiwgbm9kZS0+bmFtZSk7CisJfSBlbHNlIHsKKwkJaWYgKHJtX25vZGUoTlVM TCwgY3R4LCBub2RlLT5uYW1lKSkgeworCQkJLyogVGhhdCdzIHVuZm9ydHVu YXRlLiBXZSBvbmx5IGNhbiB0cnkgdG8gY29udGludWUuICovCisJCQlzeXNs b2coTE9HX0VSUiwKKwkJCSAgICAgICAiZXJyb3Igd2hlbiBkZWxldGluZyBv cnBoYW5lZCBub2RlICVzXG4iLAorCQkJICAgICAgIG5vZGUtPm5hbWUpOwor CQl9IGVsc2UKKwkJCXRyYWNlKCJvcnBoYW5lZCBub2RlICVzIGRlbGV0ZWRc biIsIG5vZGUtPm5hbWUpOworCisJCS8qIFNraXAgY2hpbGRyZW4gaW4gYWxs IGNhc2VzIGluIG9yZGVyIHRvIGF2b2lkIG1vcmUgZXJyb3JzLiAqLworCQly ZXQgPSBXQUxLX1RSRUVfU0tJUF9DSElMRFJFTjsKKwl9CisKKwlyZXR1cm4g ZG9tYWluLT5uYmVudHJ5ID4gMCA/IHJldCA6IFdBTEtfVFJFRV9TVUNDRVNT X1NUT1A7Cit9CisKK3N0YXRpYyB2b2lkIGRvbWFpbl90cmVlX3JlbW92ZShz dHJ1Y3QgZG9tYWluICpkb21haW4pCit7CisJaW50IHJldDsKKwlzdHJ1Y3Qg d2Fsa19mdW5jcyB3YWxrZnVuY3MgPSB7IC5lbnRlciA9IGRvbWFpbl90cmVl X3JlbW92ZV9zdWIgfTsKKworCWlmIChkb21haW4tPm5iZW50cnkgPiAwKSB7 CisJCXJldCA9IHdhbGtfbm9kZV90cmVlKGRvbWFpbiwgTlVMTCwgIi8iLCAm d2Fsa2Z1bmNzLCBkb21haW4pOworCQlpZiAocmV0ID09IFdBTEtfVFJFRV9F UlJPUl9TVE9QKQorCQkJc3lzbG9nKExPR19FUlIsCisJCQkgICAgICAgImVy cm9yIHdoZW4gbG9va2luZyBmb3Igb3JwaGFuZWQgbm9kZXNcbiIpOworCX0K K30KKwogc3RhdGljIGludCBkZXN0cm95X2RvbWFpbih2b2lkICpfZG9tYWlu KQogewogCXN0cnVjdCBkb21haW4gKmRvbWFpbiA9IF9kb21haW47CiAKKwlk b21haW5fdHJlZV9yZW1vdmUoZG9tYWluKTsKKwogCWxpc3RfZGVsKCZkb21h aW4tPmxpc3QpOwogCiAJaWYgKCFkb21haW4tPmludHJvZHVjZWQpCkBAIC04 MzgsMTUgKzg5MywxNSBAQCBpbnQgZG9tYWluX2VudHJ5X2luYyhzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKm5vZGUpCiAJc3RydWN0 IGRvbWFpbiAqZDsKIAl1bnNpZ25lZCBpbnQgZG9taWQ7CiAKLQlpZiAoIWNv bm4pCisJaWYgKCFub2RlLT5wZXJtcy5wKQogCQlyZXR1cm4gMDsKIAotCWRv bWlkID0gbm9kZS0+cGVybXMucCA/IG5vZGUtPnBlcm1zLnBbMF0uaWQgOiBj b25uLT5pZDsKKwlkb21pZCA9IG5vZGUtPnBlcm1zLnBbMF0uaWQ7CiAKLQlp ZiAoY29ubi0+dHJhbnNhY3Rpb24pIHsKKwlpZiAoY29ubiAmJiBjb25uLT50 cmFuc2FjdGlvbikgewogCQl0cmFuc2FjdGlvbl9lbnRyeV9pbmMoY29ubi0+ dHJhbnNhY3Rpb24sIGRvbWlkKTsKIAl9IGVsc2UgewotCQlkID0gKGRvbWlk ID09IGNvbm4tPmlkICYmIGNvbm4tPmRvbWFpbikgPyBjb25uLT5kb21haW4K KwkJZCA9IChjb25uICYmIGRvbWlkID09IGNvbm4tPmlkICYmIGNvbm4tPmRv bWFpbikgPyBjb25uLT5kb21haW4KIAkJICAgIDogZmluZF9vcl9hbGxvY19l eGlzdGluZ19kb21haW4oZG9taWQpOwogCQlpZiAoZCkKIAkJCWQtPm5iZW50 cnkrKzsKQEAgLTkwNywyMyArOTYyLDExIEBAIGludCBkb21haW5fYWxsb2Nf cGVybXJlZnMoc3RydWN0IG5vZGVfcGVybXMgKnBlcm1zKQogICogUmVtb3Zl IHBlcm1pc3Npb25zIGZvciBubyBsb25nZXIgZXhpc3RpbmcgZG9tYWlucyBp biBvcmRlciB0byBhdm9pZCBhIG5ldwogICogZG9tYWluIHdpdGggdGhlIHNh bWUgZG9taWQgaW5oZXJpdGluZyB0aGUgcGVybWlzc2lvbnMuCiAgKi8KLWlu dCBkb21haW5fYWRqdXN0X25vZGVfcGVybXMoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQoraW50IGRvbWFpbl9hZGp1c3Rf bm9kZV9wZXJtcyhzdHJ1Y3Qgbm9kZSAqbm9kZSkKIHsKIAl1bnNpZ25lZCBp bnQgaTsKIAlpbnQgcmV0OwogCi0JcmV0ID0gY2hrX2RvbWFpbl9nZW5lcmF0 aW9uKG5vZGUtPnBlcm1zLnBbMF0uaWQsIG5vZGUtPmdlbmVyYXRpb24pOwot Ci0JLyogSWYgdGhlIG93bmVyIGRvZXNuJ3QgZXhpc3QgYW55IGxvbmdlciBn aXZlIGl0IHRvIHByaXYgZG9tYWluLiAqLwotCWlmICghcmV0KSB7Ci0JCS8q Ci0JCSAqIEluIHRoZW9yeSB3ZSdkIG5lZWQgdG8gdXBkYXRlIHRoZSBudW1i ZXIgb2YgZG9tMCBub2RlcyBoZXJlLAotCQkgKiBidXQgd2UgY291bGQgYmUg Y2FsbGVkIGZvciBhIHJlYWQgb2YgdGhlIG5vZGUuIFNvIGJldHRlcgotCQkg KiBhdm9pZCB0aGUgcmlzayB0byBvdmVyZmxvdyB0aGUgbm9kZSBjb3VudCBv ZiBkb20wLgotCQkgKi8KLQkJbm9kZS0+cGVybXMucFswXS5pZCA9IHByaXZf ZG9taWQ7Ci0JfQotCiAJZm9yIChpID0gMTsgaSA8IG5vZGUtPnBlcm1zLm51 bTsgaSsrKSB7CiAJCWlmIChub2RlLT5wZXJtcy5wW2ldLnBlcm1zICYgWFNf UEVSTV9JR05PUkUpCiAJCQljb250aW51ZTsKQEAgLTk0MSwxNSArOTg0LDE1 IEBAIHZvaWQgZG9tYWluX2VudHJ5X2RlYyhzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgc3RydWN0IG5vZGUgKm5vZGUpCiAJc3RydWN0IGRvbWFpbiAqZDsK IAl1bnNpZ25lZCBpbnQgZG9taWQ7CiAKLQlpZiAoIWNvbm4pCisJaWYgKCFu b2RlLT5wZXJtcy5wKQogCQlyZXR1cm47CiAKIAlkb21pZCA9IG5vZGUtPnBl cm1zLnAgPyBub2RlLT5wZXJtcy5wWzBdLmlkIDogY29ubi0+aWQ7CiAKLQlp ZiAoY29ubi0+dHJhbnNhY3Rpb24pIHsKKwlpZiAoY29ubiAmJiBjb25uLT50 cmFuc2FjdGlvbikgewogCQl0cmFuc2FjdGlvbl9lbnRyeV9kZWMoY29ubi0+ dHJhbnNhY3Rpb24sIGRvbWlkKTsKIAl9IGVsc2UgewotCQlkID0gKGRvbWlk ID09IGNvbm4tPmlkICYmIGNvbm4tPmRvbWFpbikgPyBjb25uLT5kb21haW4K KwkJZCA9IChjb25uICYmIGRvbWlkID09IGNvbm4tPmlkICYmIGNvbm4tPmRv bWFpbikgPyBjb25uLT5kb21haW4KIAkJICAgIDogZmluZF9kb21haW5fc3Ry dWN0KGRvbWlkKTsKIAkJaWYgKGQpIHsKIAkJCWQtPm5iZW50cnktLTsKQEAg LTEwNjgsNyArMTExMSw3IEBAIGludCBkb21haW5fbWVtb3J5X2FkZCh1bnNp Z25lZCBpbnQgZG9taWQsIGludCBtZW0sIGJvb2wgbm9fcXVvdGFfY2hlY2sp CiAJCSAqIGV4aXN0LCBhcyBhY2NvdW50aW5nIGlzIGRvbmUgZWl0aGVyIGZv ciBhIGRvbWFpbiByZWxhdGVkIHRvCiAJCSAqIHRoZSBjdXJyZW50IGNvbm5l Y3Rpb24sIG9yIGZvciB0aGUgZG9tYWluIG93bmluZyBhIG5vZGUKIAkJICog KHdoaWNoIGlzIGFsd2F5cyBleGlzdGluZywgYXMgdGhlIG93bmVyIG9mIHRo ZSBub2RlIGlzCi0JCSAqIHRlc3RlZCB0byBleGlzdCBhbmQgcmVwbGFjZWQg YnkgZG9taWQgMCBpZiBub3QpLgorCQkgKiB0ZXN0ZWQgdG8gZXhpc3QgYW5k IGRlbGV0ZWQgb3IgcmVwbGFjZWQgYnkgZG9taWQgMCBpZiBub3QpLgogCQkg KiBTbyBub3QgZmluZGluZyB0aGUgcmVsYXRlZCBkb21haW4gTVVTVCBiZSBh biBlcnJvciBpbiB0aGUKIAkJICogZGF0YSBiYXNlLgogCQkgKi8KZGlmZiAt LWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaCBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaAppbmRleCBiYWI0MDUy MDllMmEuLjViZDI1MzM5NWQ3NyAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2RvbWFpbi5oCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9kb21haW4uaApAQCAtNjQsNyArNjQsNyBAQCBib29sIGRvbWFp bl9jYW5fd3JpdGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pOwogYm9vbCBk b21haW5faXNfdW5wcml2aWxlZ2VkKHN0cnVjdCBjb25uZWN0aW9uICpjb25u KTsKIAogLyogUmVtb3ZlIG5vZGUgcGVybWlzc2lvbnMgZm9yIG5vIGxvbmdl ciBleGlzdGluZyBkb21haW5zLiAqLwotaW50IGRvbWFpbl9hZGp1c3Rfbm9k ZV9wZXJtcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUg Km5vZGUpOworaW50IGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhzdHJ1Y3Qg bm9kZSAqbm9kZSk7CiBpbnQgZG9tYWluX2FsbG9jX3Blcm1yZWZzKHN0cnVj dCBub2RlX3Blcm1zICpwZXJtcyk7CiAKIC8qIFF1b3RhIG1hbmlwdWxhdGlv biAqLwo= --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-4.14-xenstored-02.patch" Content-Disposition: attachment; filename="xsa419/xsa419-4.14-xenstored-02.patch" Content-Transfer-Encoding: base64 RnJvbSA0NmFlOTNmZGZkYWM3ZGMwODhhNWY3YjExYjdjYjI1YzQ4NzE3NzI3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTMgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IG1ha2UgdGhl IGludGVybmFsIG1lbW9yeSBkYXRhIGJhc2UgdGhlIGRlZmF1bHQKCkhhdmlu ZyBhIGZpbGUgYmFja2VkIGRhdGEgYmFzZSBoYXMgdGhlIG9ubHkgYWR2YW50 YWdlIG9mIGJlaW5nIGNhcGFibGUKdG8gZHVtcCB0aGUgY29udGVudHMgb2Yg aXQgd2hpbGUgWGVuc3RvcmUgaXMgcnVubmluZywgYW5kIHBvdGVudGlhbGx5 CnVzaW5nIGxlc3Mgc3dhcCBzcGFjZSBpbiBjYXNlIHRoZSBkYXRhIGJhc2Ug Y2FuJ3QgYmUga2VwdCBpbiBtZW1vcnkuCgpJdCBoYXMgdGhlIG1ham9yIGRp c2FkdmFudGFnZSBvZiBhIGh1Z2UgcGVyZm9ybWFuY2Ugb3ZlcmhlYWQ6IHN3 aXRjaGluZwp0byBrZWVwIHRoZSBkYXRhIGJhc2UgaW4gbWVtb3J5IG9ubHkg c3BlZWRzIHVwIGxpdmUgdXBkYXRlIG9mIHhlbnN0b3JlZAp3aXRoIDEyMDAw MCBub2RlcyBmcm9tIDIwIG1pbnV0ZXMgdG8gMTEgc2Vjb25kcy4gQSBjb21w bGV0ZSB0cmVlIHdhbGsKb2YgdGhpcyBjb25maWd1cmF0aW9uIHdpbGwgYmUg cmVkdWNlZCBmcm9tIDcgc2Vjb25kcyB0byAyODAgbXNlY3MKKG1lYXN1cmVk IGJ5ICJ4ZW5zdG9yZS1jb250cm9sIGNoZWNrIikuCgpTbyBtYWtlIHRoZSBp bnRlcm5hbCBtZW1vcnkgZGF0YSBiYXNlIHRoZSBkZWZhdWx0IGFuZCBlbmhh bmNlIHRoZQoiLS1pbnRlcm5hbC1kYiIgY29tbWFuZCBsaW5lIHBhcmFtZXRl ciB0byB0YWtlIGFuIG9wdGlvbmFsIHBhcmFtZXRlcgphbGxvd2luZyB0byBz d2l0Y2ggdGhlIGludGVybmFsIGRhdGEgYmFzZSBiYWNrIHRvIHRoZSBmaWxl IGJhc2VkIG9uZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtNDE5LgoKUmVwb3J0 ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KU2lnbmVk LW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZp ZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCmRp ZmYgLS1naXQgYS90b29scy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWlu LmMgYi90b29scy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWluLmMKaW5k ZXggNGNlODI5OWMzYzM2Li4yZGZjNzhkNGRlNTYgMTAwNjQ0Ci0tLSBhL3Rv b2xzL2hlbHBlcnMvaW5pdC14ZW5zdG9yZS1kb21haW4uYworKysgYi90b29s cy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWluLmMKQEAgLTEzNyw5ICsx MzcsOSBAQCBzdGF0aWMgaW50IGJ1aWxkKHhjX2ludGVyZmFjZSAqeGNoKQog ICAgIH0KIAogICAgIGlmICggcGFyYW0gKQotICAgICAgICBzbnByaW50Zihj bWRsaW5lLCA1MTIsICItLWV2ZW50ICVkIC0taW50ZXJuYWwtZGIgJXMiLCBy diwgcGFyYW0pOworICAgICAgICBzbnByaW50ZihjbWRsaW5lLCA1MTIsICIt LWV2ZW50ICVkICVzIiwgcnYsIHBhcmFtKTsKICAgICBlbHNlCi0gICAgICAg IHNucHJpbnRmKGNtZGxpbmUsIDUxMiwgIi0tZXZlbnQgJWQgLS1pbnRlcm5h bC1kYiIsIHJ2KTsKKyAgICAgICAgc25wcmludGYoY21kbGluZSwgNTEyLCAi LS1ldmVudCAlZCIsIHJ2KTsKIAogICAgIGRvbSA9IHhjX2RvbV9hbGxvY2F0 ZSh4Y2gsIGNtZGxpbmUsIE5VTEwpOwogICAgIGlmICggIWRvbSApCmRpZmYg LS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwppbmRleCBlYjFkN2MyYjNi OWIuLjdlZDg1MmZkNzk1OCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5jCkBAIC0yMTM0LDcgKzIxMzQsNyBAQCBzdGF0aWMgdm9pZCBh Y2NlcHRfY29ubmVjdGlvbihpbnQgc29jaywgYm9vbCBjYW53cml0ZSkKIH0K ICNlbmRpZgogCi1zdGF0aWMgaW50IHRkYl9mbGFnczsKK3N0YXRpYyBpbnQg dGRiX2ZsYWdzID0gVERCX0lOVEVSTkFMIHwgVERCX05PTE9DSzsKIAogLyog V2UgY3JlYXRlIGluaXRpYWwgbm9kZXMgbWFudWFsbHkuICovCiBzdGF0aWMg dm9pZCBtYW51YWxfbm9kZShjb25zdCBjaGFyICpuYW1lLCBjb25zdCBjaGFy ICpjaGlsZCkKQEAgLTI0NDYsNyArMjQ0Niw4IEBAIHN0YXRpYyB2b2lkIHVz YWdlKHZvaWQpCiAiICAgICAgICAgICAgICAgICAgICAgICAgICB3YXRjaC1l dmVudDogdGltZSBhIHdhdGNoLWV2ZW50IGlzIGtlcHQgcGVuZGluZ1xuIgog IiAgLVIsIC0tbm8tcmVjb3ZlcnkgICAgICAgdG8gcmVxdWVzdCB0aGF0IG5v IHJlY292ZXJ5IHNob3VsZCBiZSBhdHRlbXB0ZWQgd2hlblxuIgogIiAgICAg ICAgICAgICAgICAgICAgICAgICAgdGhlIHN0b3JlIGlzIGNvcnJ1cHRlZCAo ZGVidWcgb25seSksXG4iCi0iICAtSSwgLS1pbnRlcm5hbC1kYiAgICAgICBz dG9yZSBkYXRhYmFzZSBpbiBtZW1vcnksIG5vdCBvbiBkaXNrXG4iCisiICAt SSwgLS1pbnRlcm5hbC1kYiBbb258b2ZmXSBzdG9yZSBkYXRhYmFzZSBpbiBt ZW1vcnksIG5vdCBvbiBkaXNrLCBkZWZhdWx0IGlzXG4iCisiICAgICAgICAg ICAgICAgICAgICAgICAgICBtZW1vcnksIHdpdGggXCItLWludGVybmFsLWRi IG9mZlwiIGl0IGlzIG9uIGRpc2tcbiIKICIgIC1LLCAtLWtlZXAtb3JwaGFu cyAgICAgIGRvbid0IGRlbGV0ZSBub2RlcyBvd25lZCBieSBhIGRvbWFpbiB3 aGVuIHRoZVxuIgogIiAgICAgICAgICAgICAgICAgICAgICAgICAgZG9tYWlu IGlzIGRlbGV0ZWQgKHRoaXMgaXMgYSBzZWN1cml0eSByaXNrISlcbiIKICIg IC1WLCAtLXZlcmJvc2UgICAgICAgICAgIHRvIHJlcXVlc3QgdmVyYm9zZSBl eGVjdXRpb24uXG4iKTsKQEAgLTI0NzEsNyArMjQ3Miw3IEBAIHN0YXRpYyBz dHJ1Y3Qgb3B0aW9uIG9wdGlvbnNbXSA9IHsKIAl7ICJxdW90YS1zb2Z0Iiwg MSwgTlVMTCwgJ3EnIH0sCiAJeyAidGltZW91dCIsIDEsIE5VTEwsICd3JyB9 LAogCXsgIm5vLXJlY292ZXJ5IiwgMCwgTlVMTCwgJ1InIH0sCi0JeyAiaW50 ZXJuYWwtZGIiLCAwLCBOVUxMLCAnSScgfSwKKwl7ICJpbnRlcm5hbC1kYiIs IDIsIE5VTEwsICdJJyB9LAogCXsgImtlZXAtb3JwaGFucyIsIDAsIE5VTEws ICdLJyB9LAogCXsgInZlcmJvc2UiLCAwLCBOVUxMLCAnVicgfSwKIAl7ICJ3 YXRjaC1uYiIsIDEsIE5VTEwsICdXJyB9LApAQCAtMjU0Nyw3ICsyNTQ4LDgg QEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAlpbnQgdGlt ZW91dDsKIAogCi0Jd2hpbGUgKChvcHQgPSBnZXRvcHRfbG9uZyhhcmdjLCBh cmd2LCAiREU6RjpIS05QUzp0OkE6UTpxOlQ6UlZXOnc6Iiwgb3B0aW9ucywK Kwl3aGlsZSAoKG9wdCA9IGdldG9wdF9sb25nKGFyZ2MsIGFyZ3YsCisJCQkJ ICAiREU6RjpISTo6S05QUzp0OkE6UTpxOlQ6UlZXOnc6Iiwgb3B0aW9ucywK IAkJCQkgIE5VTEwpKSAhPSAtMSkgewogCQlzd2l0Y2ggKG9wdCkgewogCQlj YXNlICdEJzoKQEAgLTI1ODEsNyArMjU4Myw4IEBAIGludCBtYWluKGludCBh cmdjLCBjaGFyICphcmd2W10pCiAJCQl0cmFjZWZpbGUgPSBvcHRhcmc7CiAJ CQlicmVhazsKIAkJY2FzZSAnSSc6Ci0JCQl0ZGJfZmxhZ3MgPSBUREJfSU5U RVJOQUx8VERCX05PTE9DSzsKKwkJCWlmIChvcHRhcmcgJiYgIXN0cmNtcChv cHRhcmcsICJvZmYiKSkKKwkJCQl0ZGJfZmxhZ3MgPSAwOwogCQkJYnJlYWs7 CiAJCWNhc2UgJ0snOgogCQkJa2VlcF9vcnBoYW5zID0gdHJ1ZTsK --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-4.14-xenstored-03.patch" Content-Disposition: attachment; filename="xsa419/xsa419-4.14-xenstored-03.patch" Content-Transfer-Encoding: base64 RnJvbSBiZThhY2E0YjQ2YmRkYzY2ZTg1OTZiNmRkOTIwYzIzZDUzMzllMmYw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTMgKzAyMDAKU3ViamVjdDogZG9jczogZW5oYW5jZSB4ZW5zdG9yZS50 eHQgd2l0aCBwZXJtaXNzaW9ucyBkZXNjcmlwdGlvbgpNSU1FLVZlcnNpb246 IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgK Q29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKVGhlIHBlcm1pc3Np b24gc2NoZW1lIG9mIFhlbnN0b3JlIG5vZGVzIGlzIG5vdCByZWFsbHkgY292 ZXJlZCBieQpkb2NzL21pc2MveGVuc3RvcmUudHh0LCBvdGhlciB0aGFuIHJl ZmVycmluZyB0byB0aGUgWGVuIHdpa2kuCgpBZGQgYSBwYXJhZ3JhcGggZXhw bGFpbmluZyB0aGUgcGVybWlzc2lvbnMgb2Ygbm9kZXMsIGFuZCBlc3BlY2lh bGx5Cm1lbnRpb25pbmcgcmVtb3ZhbCBvZiBub2RlcyB3aGVuIGEgZG9tYWlu IGhhcyBiZWVuIHJlbW92ZWQgZnJvbQpYZW5zdG9yZS4KClRoaXMgaXMgcGFy dCBvZiBYU0EtNDE5LgoKUmVwb3J0ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpn cm9zc0BzdXNlLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8 amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogRWR3aW4gVMO2csO2ayA8 ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvZG9jcy9taXNj L3hlbnN0b3JlLnR4dCBiL2RvY3MvbWlzYy94ZW5zdG9yZS50eHQKaW5kZXgg MWY0MmEzNzdjMTBmLi42YWEwN2M1ZWQ4MGIgMTAwNjQ0Ci0tLSBhL2RvY3Mv bWlzYy94ZW5zdG9yZS50eHQKKysrIGIvZG9jcy9taXNjL3hlbnN0b3JlLnR4 dApAQCAtNDMsNiArNDMsMTcgQEAgYnl0ZXMgYXJlIGZvcmJpZGRlbjsgY2xp ZW50cyBzcGVjaWZ5aW5nIHJlbGF0aXZlIHBhdGhzIHNob3VsZCBrZWVwCiB0 aGVtIHRvIHdpdGhpbiAyMDQ4IGJ5dGVzLiAgKFNlZSBYRU5TVE9SRV8qX1BB VEhfTUFYIGluIHhzX3dpcmUuaC4pCiAKIAorRWFjaCBub2RlIGhhcyBvbmUg b3IgbXVsdGlwbGUgcGVybWlzc2lvbiBlbnRyaWVzLiAgUGVybWlzc2lvbnMg YXJlCitncmFudGVkIGJ5IGRvbWFpbi1pZCwgdGhlIGZpcnN0IHBlcm1pc3Np b24gZW50cnkgb2YgZWFjaCBub2RlIHNwZWNpZmllcwordGhlIG93bmVyIG9m IHRoZSBub2RlLiAgUGVybWlzc2lvbnMgb2YgYSBub2RlIGNhbiBiZSBjaGFu Z2VkIGJ5IHRoZQorb3duZXIgb2YgdGhlIG5vZGUsIHRoZSBvd25lciBjYW4g b25seSBiZSBtb2RpZmllZCBieSB0aGUgY29udHJvbAorZG9tYWluICh1c3Vh bGx5IGRvbWFpbiBpZCAwKS4gIFRoZSBvd25lciBhbHdheXMgaGFzIHRoZSBy aWdodCB0byByZWFkCithbmQgd3JpdGUgdGhlIG5vZGUsIHdoaWxlIG90aGVy IHBlcm1pc3Npb25zIGNhbiBiZSBzZXR1cCB0byBhbGxvdworcmVhZCBhbmQv b3Igd3JpdGUgYWNjZXNzLiAgV2hlbiBhIGRvbWFpbiBpcyBiZWluZyByZW1v dmVkIGZyb20gWGVuc3RvcmUKK25vZGVzIG93bmVkIGJ5IHRoYXQgZG9tYWlu IHdpbGwgYmUgcmVtb3ZlZCB0b2dldGhlciB3aXRoIGFsbCBvZiB0aG9zZQor bm9kZXMnIGNoaWxkcmVuLgorCisKIENvbW11bmljYXRpb24gd2l0aCB4ZW5z dG9yZSBpcyB2aWEgZWl0aGVyIHNvY2tldHMsIG9yIGV2ZW50IGNoYW5uZWwK IGFuZCBzaGFyZWQgbWVtb3J5LCBhcyBzcGVjaWZpZWQgaW4gaW8veHNfd2ly ZS5oOiBlYWNoIG1lc3NhZ2UgaW4KIGVpdGhlciBkaXJlY3Rpb24gaXMgYSBo ZWFkZXIgZm9ybWF0dGVkIGFzIGEgc3RydWN0IHhzZF9zb2NrbXNnCg== --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-4.15-oxenstored.patch" Content-Disposition: attachment; filename="xsa419/xsa419-4.15-oxenstored.patch" Content-Transfer-Encoding: base64 RnJvbSAwNGQwNDU0NWNhMWIyODE1OTZlMWUxM2IzOTExM2Y2YTM3MjU5YWIx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNiArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IEZpeCBxdW90YSBieXBhc3Mg b24gZG9tYWluIHNodXRkb3duCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQt VHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5z ZmVyLUVuY29kaW5nOiA4Yml0CgpYU0EtMzIyIGZpeGVkIGEgZG9taWQgcmV1 c2UgdnVsbmVyYWJpbGl0eSBieSBhc3NpZ25pbmcgRG9tMCBhcyB0aGUgb3du ZXIgb2YKYW55IG5vZGVzIGxlZnQgYWZ0ZXIgYSBkb21haW4gaXMgc2h1dGRv d24gKGUuZy4gb3V0c2lkZSBpdHMgL2xvY2FsL2RvbWFpbi9OCnRyZWUpLgoK SG93ZXZlciBEb20wIGhhcyBubyBxdW90YSBvbiBwdXJwb3NlLCBzbyB0aGlz IG9wZW5lZCB1cCBhbm90aGVyIHBvdGVudGlhbAphdHRhY2sgdmVjdG9yLiBB dm9pZCBpdCBieSBkZWxldGluZyB0aGVzZSBub2RlcyBpbnN0ZWFkIG9mIGFz c2lnbmluZyB0aGVtIHRvCkRvbTAuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQx OSAvIENWRS0yMDIyLTQyMzIzLgoKUmVwb3J0ZWQtYnk6IEp1ZXJnZW4gR3Jv c3MgPGpncm9zc0BzdXNlLmNvbT4KRml4ZXM6IGM0NmVmZjkyMTIwOSAoInRv b2xzL29jYW1sL3hlbnN0b3JlZDogY2xlYW4gdXAgcGVybWlzc2lvbnMgZm9y IGRlYWQgZG9tYWlucyIpClNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLDtmsg PGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJpc3RpYW4g TGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+CgpkaWZmIC0t Z2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Blcm1zLm1sIGIvdG9vbHMv b2NhbWwveGVuc3RvcmVkL3Blcm1zLm1sCmluZGV4IGU4YTE2MjIxZjhmYS4u ODRmMjUwM2U4ZTI5IDEwMDY0NAotLS0gYS90b29scy9vY2FtbC94ZW5zdG9y ZWQvcGVybXMubWwKKysrIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Blcm1z Lm1sCkBAIC02NCw4ICs2NCw3IEBAIGxldCBnZXRfb3duZXIgcGVybSA9IHBl cm0ub3duZXIKICogKikKIGxldCByZW1vdmVfZG9taWQgfmRvbWlkIHBlcm0g PQogCWxldCBhY2wgPSBMaXN0LmZpbHRlciAoZnVuIChhY2xfZG9taWQsIF8p IC0+IGFjbF9kb21pZCA8PiBkb21pZCkgcGVybS5hY2wgaW4KLQlsZXQgb3du ZXIgPSBpZiBwZXJtLm93bmVyID0gZG9taWQgdGhlbiAwIGVsc2UgcGVybS5v d25lciBpbgotCXsgcGVybSB3aXRoIGFjbDsgb3duZXIgfQorCWlmIHBlcm0u b3duZXIgPSBkb21pZCB0aGVuIE5vbmUgZWxzZSBTb21lIHsgcGVybSB3aXRo IGFjbDsgb3duZXIgPSBwZXJtLm93bmVyIH0KIAogbGV0IGRlZmF1bHQwID0g Y3JlYXRlIDAgTk9ORSBbXQogCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94 ZW5zdG9yZWQvc3RvcmUubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvc3Rv cmUubWwKaW5kZXggMjBlNjdiMTQyNzQ2Li43MGYwYzgzZGU0MDQgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9zdG9yZS5tbAorKysgYi90 b29scy9vY2FtbC94ZW5zdG9yZWQvc3RvcmUubWwKQEAgLTg3LDEwICs4Nywy MSBAQCBsZXQgY2hlY2tfb3duZXIgbm9kZSBjb25uZWN0aW9uID0KIAogbGV0 IHJlYyByZWN1cnNlIGZjdCBub2RlID0gZmN0IG5vZGU7IFN5bWJvbE1hcC5p dGVyIChmdW4gXyAtPiByZWN1cnNlIGZjdCkgbm9kZS5jaGlsZHJlbgogCi0o KiogW3JlY3Vyc2VfbWFwIGYgdHJlZV0gYXBwbGllcyBbZl0gb24gZWFjaCBu b2RlIGluIHRoZSB0cmVlIHJlY3Vyc2l2ZWx5ICopCi1sZXQgcmVjdXJzZV9t YXAgZiA9CisoKiogW3JlY3Vyc2VfZmlsdGVyX21hcCBmIHRyZWVdIGFwcGxp ZXMgW2ZdIG9uIGVhY2ggbm9kZSBpbiB0aGUgdHJlZSByZWN1cnNpdmVseSwK KyAgICBwb3NzaWJseSByZW1vdmluZyBzb21lIG5vZGVzLgorICAgIE5vdGUg dGhhdCB0aGUgbm9kZXMgcmVtb3ZlZCB0aGlzIHdheSB3b24ndCBnZW5lcmF0 ZSB3YXRjaCBldmVudHMuCisqKQorbGV0IHJlY3Vyc2VfZmlsdGVyX21hcCBm ID0KKwlsZXQgaW52YWxpZCA9IC0xIGluCisJbGV0IGlzX3ZhbGlkIF8gbm9k ZSA9IG5vZGUucGVybXMub3duZXIgPD4gaW52YWxpZCBpbgogCWxldCByZWMg d2FsayBub2RlID0KLQkJZiB7IG5vZGUgd2l0aCBjaGlsZHJlbiA9IFN5bWJv bE1hcC5tYXAgd2FsayBub2RlLmNoaWxkcmVuIH0KKwkJKCogTWFwLmZpbHRl cl9tYXAgaXMgT2NhbWwgNC4xMSsgb25seSAqKQorCQlsZXQgbm9kZSA9CisJ CXsgbm9kZSB3aXRoIGNoaWxkcmVuID0KKwkJCVN5bWJvbE1hcC5tYXAgd2Fs ayBub2RlLmNoaWxkcmVuIHw+IFN5bWJvbE1hcC5maWx0ZXIgaXNfdmFsaWQg fSBpbgorCQltYXRjaCBmIG5vZGUgd2l0aAorCQl8IFNvbWUga2VlcCAtPiBr ZWVwCisJCXwgTm9uZSAtPiB7IG5vZGUgd2l0aCBwZXJtcyA9IHtub2RlLnBl cm1zIHdpdGggb3duZXIgPSBpbnZhbGlkIH0gfQogCWluCiAJd2FsawogCkBA IC00NDQsMTEgKzQ1NSwxMyBAQCBsZXQgc2V0cGVybXMgc3RvcmUgcGVybSBw YXRoIG5wZXJtcyA9CiAKIGxldCByZXNldF9wZXJtaXNzaW9ucyBzdG9yZSBk b21pZCA9CiAJTG9nZ2luZy5pbmZvICJzdG9yZXxub2RlIiAiQ2xlYW5pbmcg dXAgeGVuc3RvcmUgQUNMcyBmb3IgZG9taWQgJWQiIGRvbWlkOwotCXN0b3Jl LnJvb3QgPC0gTm9kZS5yZWN1cnNlX21hcCAoZnVuIG5vZGUgLT4KLQkJbGV0 IHBlcm1zID0gUGVybXMuTm9kZS5yZW1vdmVfZG9taWQgfmRvbWlkIG5vZGUu cGVybXMgaW4KLQkJaWYgcGVybXMgPD4gbm9kZS5wZXJtcyB0aGVuCi0JCQlM b2dnaW5nLmRlYnVnICJzdG9yZXxub2RlIiAiQ2hhbmdlZCBwZXJtaXNzaW9u cyBmb3Igbm9kZSAlcyIgKE5vZGUuZ2V0X25hbWUgbm9kZSk7Ci0JCXsgbm9k ZSB3aXRoIHBlcm1zIH0KKwlzdG9yZS5yb290IDwtIE5vZGUucmVjdXJzZV9m aWx0ZXJfbWFwIChmdW4gbm9kZSAtPgorCQltYXRjaCBQZXJtcy5Ob2RlLnJl bW92ZV9kb21pZCB+ZG9taWQgbm9kZS5wZXJtcyB3aXRoCisJCXwgTm9uZSAt PiBOb25lCisJCXwgU29tZSBwZXJtcyAtPgorCQkJaWYgcGVybXMgPD4gbm9k ZS5wZXJtcyB0aGVuCisJCQkJTG9nZ2luZy5kZWJ1ZyAic3RvcmV8bm9kZSIg IkNoYW5nZWQgcGVybWlzc2lvbnMgZm9yIG5vZGUgJXMiIChOb2RlLmdldF9u YW1lIG5vZGUpOworCQkJU29tZSB7IG5vZGUgd2l0aCBwZXJtcyB9CiAJKSBz dG9yZS5yb290CiAKIHR5cGUgb3BzID0gewo= --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-4.15-xenstored-01.patch" Content-Disposition: attachment; filename="xsa419/xsa419-4.15-xenstored-01.patch" Content-Transfer-Encoding: base64 RnJvbSA0OTYzN2YyMTFhODg2NzI3MDZjMWM5ODBmMDM0OGJmODM2ZDUxNmJk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHJlbW92ZSBu b2RlcyBvd25lZCBieSBkZXN0cm95ZWQgZG9tYWluCgpJbiBjYXNlIGEgZG9t YWluIGlzIHJlbW92ZWQgZnJvbSBYZW5zdG9yZSwgcmVtb3ZlIGFsbCBub2Rl cyBvd25lZCBieQppdCBwZXIgZGVmYXVsdC4KClRoaXMgdGFja2xlcyB0aGUg cHJvYmxlbSB0aGF0IG5vZGVzIG1pZ2h0IGJlIGNyZWF0ZWQgYnkgYSBkb21h aW4Kb3V0c2lkZSBpdHMgaG9tZSBwYXRoIGluIFhlbnN0b3JlLCBsZWFkaW5n IHRvIFhlbnN0b3JlIGhvZ2dpbmcgbW9yZQphbmQgbW9yZSBtZW1vcnkuIERv bWFpbiBxdW90YSBkb24ndCB3b3JrIGluIHRoaXMgY2FzZSBpZiB0aGUgZ3Vl c3QgaXMKcmVib290aW5nIGluIGJldHdlZW4uCgpTaW5jZSBYU0EtMzIyIG93 bmVyc2hpcCBvZiBzdWNoIHN0YWxlIG5vZGVzIGlzIHRyYW5zZmVycmVkIHRv IGRvbTAsCndoaWNoIGlzIGhlbHBpbmcgYWdhaW5zdCB1bmludGVuZGVkIGFj Y2VzcywgYnV0IG5vdCBhZ2FpbnN0IE9PTSBvZgpYZW5zdG9yZS4KCkFzIGEg ZmFsbGJhY2sgZm9yIHdlaXJkIGNhc2VzIGFkZCBhIFhlbnN0b3JlIHN0YXJ0 IHBhcmFtZXRlciBmb3IKa2VlcGluZyB0b2RheSdzIHdheSB0byBoYW5kbGUg c3RhbGUgbm9kZXMsIGFkZGluZyB0aGUgcmlzayBvZiBYZW5zdG9yZQpoaXR0 aW5nIGFuIE9PTSBzaXR1YXRpb24uCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQx OSAvIENWRS0yMDIyLTQyMzIyLgoKUmVwb3J0ZWQtYnk6IEp1ZXJnZW4gR3Jv c3MgPGpncm9zc0BzdXNlLmNvbT4KRml4ZXM6IDQ5NjMwNjMyNGQ4ZCAoInRv b2xzL3hlbnN0b3JlOiByZXZva2UgYWNjZXNzIHJpZ2h0cyBmb3IgcmVtb3Zl ZCBkb21haW5zIikKU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdy b3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3Jh bGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuYwppbmRleCBlOGNkZmVlZjUwYzcuLmQ1YjJlNTliMGRiNiAxMDA2NDQK LS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC04MCw2ICs4MCw3 IEBAIHN0YXRpYyBib29sIHZlcmJvc2UgPSBmYWxzZTsKIExJU1RfSEVBRChj b25uZWN0aW9ucyk7CiBpbnQgdHJhY2VmZCA9IC0xOwogc3RhdGljIGJvb2wg cmVjb3ZlcnkgPSB0cnVlOworYm9vbCBrZWVwX29ycGhhbnMgPSBmYWxzZTsK IHN0YXRpYyBpbnQgcmVvcGVuX2xvZ19waXBlWzJdOwogc3RhdGljIGludCBy ZW9wZW5fbG9nX3BpcGUwX3BvbGxmZF9pZHggPSAtMTsKIGNoYXIgKnRyYWNl ZmlsZSA9IE5VTEw7CkBAIC03MjIsNyArNzIzLDcgQEAgc3RydWN0IG5vZGUg KnJlYWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9p ZCAqY3R4LAogCW5vZGUtPnBlcm1zLnAgPSBoZHItPnBlcm1zOwogCW5vZGUt PmFjYy5kb21pZCA9IG5vZGUtPnBlcm1zLnBbMF0uaWQ7CiAJbm9kZS0+YWNj Lm1lbW9yeSA9IGRhdGEuZHNpemU7Ci0JaWYgKGRvbWFpbl9hZGp1c3Rfbm9k ZV9wZXJtcyhjb25uLCBub2RlKSkKKwlpZiAoZG9tYWluX2FkanVzdF9ub2Rl X3Blcm1zKG5vZGUpKQogCQlnb3RvIGVycm9yOwogCiAJLyogSWYgb3duZXIg aXMgZ29uZSByZXNldCBjdXJyZW50bHkgYWNjb3VudGVkIG1lbW9yeSBzaXpl LiAqLwpAQCAtNzY1LDcgKzc2Niw3IEBAIGludCB3cml0ZV9ub2RlX3Jhdyhz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgVERCX0RBVEEgKmtleSwgc3RydWN0 IG5vZGUgKm5vZGUsCiAJdm9pZCAqcDsKIAlzdHJ1Y3QgeHNfdGRiX3JlY29y ZF9oZHIgKmhkcjsKIAotCWlmIChkb21haW5fYWRqdXN0X25vZGVfcGVybXMo Y29ubiwgbm9kZSkpCisJaWYgKGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhu b2RlKSkKIAkJcmV0dXJuIGVycm5vOwogCiAJZGF0YS5kc2l6ZSA9IHNpemVv ZigqaGRyKQpAQCAtMTYxNyw3ICsxNjE4LDcgQEAgc3RhdGljIGludCBkZWxu b2RlX3N1Yihjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpj b25uLAogCXJldHVybiBXQUxLX1RSRUVfUk1fQ0hJTERFTlRSWTsKIH0KIAot c3RhdGljIGludCBfcm0oc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0 IHZvaWQgKmN0eCwgY29uc3QgY2hhciAqbmFtZSkKK2ludCBybV9ub2RlKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsIGNvbnN0 IGNoYXIgKm5hbWUpCiB7CiAJc3RydWN0IG5vZGUgKnBhcmVudDsKIAljaGFy ICpwYXJlbnRuYW1lID0gZ2V0X3BhcmVudChjdHgsIG5hbWUpOwpAQCAtMTY4 MSw3ICsxNjgyLDcgQEAgc3RhdGljIGludCBkb19ybShjb25zdCB2b2lkICpj dHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCWlmIChzdHJlcShuYW1l LCAiLyIpKQogCQlyZXR1cm4gRUlOVkFMOwogCi0JcmV0ID0gX3JtKGNvbm4s IGN0eCwgbmFtZSk7CisJcmV0ID0gcm1fbm9kZShjb25uLCBjdHgsIG5hbWUp OwogCWlmIChyZXQpCiAJCXJldHVybiByZXQ7CiAKQEAgLTI1MzcsNiArMjUz OCw4IEBAIHN0YXRpYyB2b2lkIHVzYWdlKHZvaWQpCiAiICAtUiwgLS1uby1y ZWNvdmVyeSAgICAgICB0byByZXF1ZXN0IHRoYXQgbm8gcmVjb3Zlcnkgc2hv dWxkIGJlIGF0dGVtcHRlZCB3aGVuXG4iCiAiICAgICAgICAgICAgICAgICAg ICAgICAgICB0aGUgc3RvcmUgaXMgY29ycnVwdGVkIChkZWJ1ZyBvbmx5KSxc biIKICIgIC1JLCAtLWludGVybmFsLWRiICAgICAgIHN0b3JlIGRhdGFiYXNl IGluIG1lbW9yeSwgbm90IG9uIGRpc2tcbiIKKyIgIC1LLCAtLWtlZXAtb3Jw aGFucyAgICAgIGRvbid0IGRlbGV0ZSBub2RlcyBvd25lZCBieSBhIGRvbWFp biB3aGVuIHRoZVxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgZG9t YWluIGlzIGRlbGV0ZWQgKHRoaXMgaXMgYSBzZWN1cml0eSByaXNrISlcbiIK ICIgIC1WLCAtLXZlcmJvc2UgICAgICAgICAgIHRvIHJlcXVlc3QgdmVyYm9z ZSBleGVjdXRpb24uXG4iKTsKIH0KIApAQCAtMjU2MSw2ICsyNTY0LDcgQEAg c3RhdGljIHN0cnVjdCBvcHRpb24gb3B0aW9uc1tdID0gewogCXsgInRpbWVv dXQiLCAxLCBOVUxMLCAndycgfSwKIAl7ICJuby1yZWNvdmVyeSIsIDAsIE5V TEwsICdSJyB9LAogCXsgImludGVybmFsLWRiIiwgMCwgTlVMTCwgJ0knIH0s CisJeyAia2VlcC1vcnBoYW5zIiwgMCwgTlVMTCwgJ0snIH0sCiAJeyAidmVy Ym9zZSIsIDAsIE5VTEwsICdWJyB9LAogCXsgIndhdGNoLW5iIiwgMSwgTlVM TCwgJ1cnIH0sCiAjaWZuZGVmIE5PX0xJVkVfVVBEQVRFCkBAIC0yNjQxLDcg KzI2NDUsNyBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQog CW9yaWdfYXJnYyA9IGFyZ2M7CiAJb3JpZ19hcmd2ID0gYXJndjsKIAotCXdo aWxlICgob3B0ID0gZ2V0b3B0X2xvbmcoYXJnYywgYXJndiwgIkRFOkY6SE5Q Uzp0OkE6TTpROnE6VDpSVlc6dzpVIiwKKwl3aGlsZSAoKG9wdCA9IGdldG9w dF9sb25nKGFyZ2MsIGFyZ3YsICJERTpGOkhLTlBTOnQ6QTpNOlE6cTpUOlJW Vzp3OlUiLAogCQkJCSAgb3B0aW9ucywgTlVMTCkpICE9IC0xKSB7CiAJCXN3 aXRjaCAob3B0KSB7CiAJCWNhc2UgJ0QnOgpAQCAtMjY3Nyw2ICsyNjgxLDkg QEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAkJY2FzZSAn SSc6CiAJCQl0ZGJfZmxhZ3MgPSBUREJfSU5URVJOQUx8VERCX05PTE9DSzsK IAkJCWJyZWFrOworCQljYXNlICdLJzoKKwkJCWtlZXBfb3JwaGFucyA9IHRy dWU7CisJCQlicmVhazsKIAkJY2FzZSAnVic6CiAJCQl2ZXJib3NlID0gdHJ1 ZTsKIAkJCWJyZWFrOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmgKaW5kZXggMzE5MDQ5NGJiZWI1Li45YTlkYmIyYzNjODYgMTAwNjQ0Ci0t LSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKKysrIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMjMzLDYgKzIzMyw5 IEBAIGludCB3cml0ZV9ub2RlX3JhdyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgVERCX0RBVEEgKmtleSwgc3RydWN0IG5vZGUgKm5vZGUsCiBzdHJ1Y3Qg bm9kZSAqcmVhZF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25z dCB2b2lkICpjdHgsCiAJCSAgICAgICBjb25zdCBjaGFyICpuYW1lKTsKIAor LyogUmVtb3ZlIGEgbm9kZSBhbmQgaXRzIGNoaWxkcmVuLiAqLworaW50IHJt X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0 eCwgY29uc3QgY2hhciAqbmFtZSk7CisKIHZvaWQgc2V0dXBfc3RydWN0dXJl KGJvb2wgbGl2ZV91cGRhdGUpOwogc3RydWN0IGNvbm5lY3Rpb24gKm5ld19j b25uZWN0aW9uKGNvbm53cml0ZWZuX3QgKndyaXRlLCBjb25ucmVhZGZuX3Qg KnJlYWQpOwogc3RydWN0IGNvbm5lY3Rpb24gKmdldF9jb25uZWN0aW9uX2J5 X2lkKHVuc2lnbmVkIGludCBjb25uX2lkKTsKQEAgLTI3OSw2ICsyODIsNyBA QCBleHRlcm4gaW50IHF1b3RhX3JlcV9vdXRzdGFuZGluZzsKIGV4dGVybiBp bnQgcXVvdGFfdHJhbnNfbm9kZXM7CiBleHRlcm4gaW50IHF1b3RhX21lbW9y eV9wZXJfZG9tYWluX3NvZnQ7CiBleHRlcm4gaW50IHF1b3RhX21lbW9yeV9w ZXJfZG9tYWluX2hhcmQ7CitleHRlcm4gYm9vbCBrZWVwX29ycGhhbnM7CiAK IGV4dGVybiB1bnNpZ25lZCBpbnQgdGltZW91dF93YXRjaF9ldmVudF9tc2Vj OwogCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9t YWluLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMKaW5k ZXggYTkxY2M3NWFiNTliLi5lZTRiMTkzODdkYjggMTAwNjQ0Ci0tLSBhL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYworKysgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMKQEAgLTE5NiwxMCArMTk2LDY0 IEBAIHN0YXRpYyB2b2lkIHVubWFwX2ludGVyZmFjZSh2b2lkICppbnRlcmZh Y2UpCiAJeGVuZ250dGFiX3VubWFwKCp4Z3RfaGFuZGxlLCBpbnRlcmZhY2Us IDEpOwogfQogCitzdGF0aWMgaW50IGRvbWFpbl90cmVlX3JlbW92ZV9zdWIo Y29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJ CQkgIHN0cnVjdCBub2RlICpub2RlLCB2b2lkICphcmcpCit7CisJc3RydWN0 IGRvbWFpbiAqZG9tYWluID0gYXJnOworCVREQl9EQVRBIGtleTsKKwlpbnQg cmV0ID0gV0FMS19UUkVFX09LOworCisJaWYgKG5vZGUtPnBlcm1zLnBbMF0u aWQgIT0gZG9tYWluLT5kb21pZCkKKwkJcmV0dXJuIFdBTEtfVFJFRV9PSzsK KworCWlmIChrZWVwX29ycGhhbnMpIHsKKwkJc2V0X3RkYl9rZXkobm9kZS0+ bmFtZSwgJmtleSk7CisJCWRvbWFpbi0+bmJlbnRyeS0tOworCQlub2RlLT5w ZXJtcy5wWzBdLmlkID0gcHJpdl9kb21pZDsKKwkJbm9kZS0+YWNjLm1lbW9y eSA9IDA7CisJCWRvbWFpbl9lbnRyeV9pbmMoTlVMTCwgbm9kZSk7CisJCWlm ICh3cml0ZV9ub2RlX3JhdyhOVUxMLCAma2V5LCBub2RlLCB0cnVlKSkgewor CQkJLyogVGhhdCdzIHVuZm9ydHVuYXRlLiBXZSBvbmx5IGNhbiB0cnkgdG8g Y29udGludWUuICovCisJCQlzeXNsb2coTE9HX0VSUiwKKwkJCSAgICAgICAi ZXJyb3Igd2hlbiBtb3Zpbmcgb3JwaGFuZWQgbm9kZSAlcyB0byBkb20wXG4i LAorCQkJICAgICAgIG5vZGUtPm5hbWUpOworCQl9IGVsc2UKKwkJCXRyYWNl KCJvcnBoYW5lZCBub2RlICVzIG1vdmVkIHRvIGRvbTBcbiIsIG5vZGUtPm5h bWUpOworCX0gZWxzZSB7CisJCWlmIChybV9ub2RlKE5VTEwsIGN0eCwgbm9k ZS0+bmFtZSkpIHsKKwkJCS8qIFRoYXQncyB1bmZvcnR1bmF0ZS4gV2Ugb25s eSBjYW4gdHJ5IHRvIGNvbnRpbnVlLiAqLworCQkJc3lzbG9nKExPR19FUlIs CisJCQkgICAgICAgImVycm9yIHdoZW4gZGVsZXRpbmcgb3JwaGFuZWQgbm9k ZSAlc1xuIiwKKwkJCSAgICAgICBub2RlLT5uYW1lKTsKKwkJfSBlbHNlCisJ CQl0cmFjZSgib3JwaGFuZWQgbm9kZSAlcyBkZWxldGVkXG4iLCBub2RlLT5u YW1lKTsKKworCQkvKiBTa2lwIGNoaWxkcmVuIGluIGFsbCBjYXNlcyBpbiBv cmRlciB0byBhdm9pZCBtb3JlIGVycm9ycy4gKi8KKwkJcmV0ID0gV0FMS19U UkVFX1NLSVBfQ0hJTERSRU47CisJfQorCisJcmV0dXJuIGRvbWFpbi0+bmJl bnRyeSA+IDAgPyByZXQgOiBXQUxLX1RSRUVfU1VDQ0VTU19TVE9QOworfQor CitzdGF0aWMgdm9pZCBkb21haW5fdHJlZV9yZW1vdmUoc3RydWN0IGRvbWFp biAqZG9tYWluKQoreworCWludCByZXQ7CisJc3RydWN0IHdhbGtfZnVuY3Mg d2Fsa2Z1bmNzID0geyAuZW50ZXIgPSBkb21haW5fdHJlZV9yZW1vdmVfc3Vi IH07CisKKwlpZiAoZG9tYWluLT5uYmVudHJ5ID4gMCkgeworCQlyZXQgPSB3 YWxrX25vZGVfdHJlZShkb21haW4sIE5VTEwsICIvIiwgJndhbGtmdW5jcywg ZG9tYWluKTsKKwkJaWYgKHJldCA9PSBXQUxLX1RSRUVfRVJST1JfU1RPUCkK KwkJCXN5c2xvZyhMT0dfRVJSLAorCQkJICAgICAgICJlcnJvciB3aGVuIGxv b2tpbmcgZm9yIG9ycGhhbmVkIG5vZGVzXG4iKTsKKwl9Cit9CisKIHN0YXRp YyBpbnQgZGVzdHJveV9kb21haW4odm9pZCAqX2RvbWFpbikKIHsKIAlzdHJ1 Y3QgZG9tYWluICpkb21haW4gPSBfZG9tYWluOwogCisJZG9tYWluX3RyZWVf cmVtb3ZlKGRvbWFpbik7CisKIAlsaXN0X2RlbCgmZG9tYWluLT5saXN0KTsK IAogCWlmICghZG9tYWluLT5pbnRyb2R1Y2VkKQpAQCAtODU3LDE1ICs5MTEs MTUgQEAgaW50IGRvbWFpbl9lbnRyeV9pbmMoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQogCXN0cnVjdCBkb21haW4gKmQ7 CiAJdW5zaWduZWQgaW50IGRvbWlkOwogCi0JaWYgKCFjb25uKQorCWlmICgh bm9kZS0+cGVybXMucCkKIAkJcmV0dXJuIDA7CiAKLQlkb21pZCA9IG5vZGUt PnBlcm1zLnAgPyBub2RlLT5wZXJtcy5wWzBdLmlkIDogY29ubi0+aWQ7CisJ ZG9taWQgPSBub2RlLT5wZXJtcy5wWzBdLmlkOwogCi0JaWYgKGNvbm4tPnRy YW5zYWN0aW9uKSB7CisJaWYgKGNvbm4gJiYgY29ubi0+dHJhbnNhY3Rpb24p IHsKIAkJdHJhbnNhY3Rpb25fZW50cnlfaW5jKGNvbm4tPnRyYW5zYWN0aW9u LCBkb21pZCk7CiAJfSBlbHNlIHsKLQkJZCA9IChkb21pZCA9PSBjb25uLT5p ZCAmJiBjb25uLT5kb21haW4pID8gY29ubi0+ZG9tYWluCisJCWQgPSAoY29u biAmJiBkb21pZCA9PSBjb25uLT5pZCAmJiBjb25uLT5kb21haW4pID8gY29u bi0+ZG9tYWluCiAJCSAgICA6IGZpbmRfb3JfYWxsb2NfZXhpc3RpbmdfZG9t YWluKGRvbWlkKTsKIAkJaWYgKGQpCiAJCQlkLT5uYmVudHJ5Kys7CkBAIC05 MjYsMjMgKzk4MCwxMSBAQCBpbnQgZG9tYWluX2FsbG9jX3Blcm1yZWZzKHN0 cnVjdCBub2RlX3Blcm1zICpwZXJtcykKICAqIFJlbW92ZSBwZXJtaXNzaW9u cyBmb3Igbm8gbG9uZ2VyIGV4aXN0aW5nIGRvbWFpbnMgaW4gb3JkZXIgdG8g YXZvaWQgYSBuZXcKICAqIGRvbWFpbiB3aXRoIHRoZSBzYW1lIGRvbWlkIGlu aGVyaXRpbmcgdGhlIHBlcm1pc3Npb25zLgogICovCi1pbnQgZG9tYWluX2Fk anVzdF9ub2RlX3Blcm1zKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1 Y3Qgbm9kZSAqbm9kZSkKK2ludCBkb21haW5fYWRqdXN0X25vZGVfcGVybXMo c3RydWN0IG5vZGUgKm5vZGUpCiB7CiAJdW5zaWduZWQgaW50IGk7CiAJaW50 IHJldDsKIAotCXJldCA9IGNoa19kb21haW5fZ2VuZXJhdGlvbihub2RlLT5w ZXJtcy5wWzBdLmlkLCBub2RlLT5nZW5lcmF0aW9uKTsKLQotCS8qIElmIHRo ZSBvd25lciBkb2Vzbid0IGV4aXN0IGFueSBsb25nZXIgZ2l2ZSBpdCB0byBw cml2IGRvbWFpbi4gKi8KLQlpZiAoIXJldCkgewotCQkvKgotCQkgKiBJbiB0 aGVvcnkgd2UnZCBuZWVkIHRvIHVwZGF0ZSB0aGUgbnVtYmVyIG9mIGRvbTAg bm9kZXMgaGVyZSwKLQkJICogYnV0IHdlIGNvdWxkIGJlIGNhbGxlZCBmb3Ig YSByZWFkIG9mIHRoZSBub2RlLiBTbyBiZXR0ZXIKLQkJICogYXZvaWQgdGhl IHJpc2sgdG8gb3ZlcmZsb3cgdGhlIG5vZGUgY291bnQgb2YgZG9tMC4KLQkJ ICovCi0JCW5vZGUtPnBlcm1zLnBbMF0uaWQgPSBwcml2X2RvbWlkOwotCX0K LQogCWZvciAoaSA9IDE7IGkgPCBub2RlLT5wZXJtcy5udW07IGkrKykgewog CQlpZiAobm9kZS0+cGVybXMucFtpXS5wZXJtcyAmIFhTX1BFUk1fSUdOT1JF KQogCQkJY29udGludWU7CkBAIC05NjAsMTUgKzEwMDIsMTUgQEAgdm9pZCBk b21haW5fZW50cnlfZGVjKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1 Y3Qgbm9kZSAqbm9kZSkKIAlzdHJ1Y3QgZG9tYWluICpkOwogCXVuc2lnbmVk IGludCBkb21pZDsKIAotCWlmICghY29ubikKKwlpZiAoIW5vZGUtPnBlcm1z LnApCiAJCXJldHVybjsKIAogCWRvbWlkID0gbm9kZS0+cGVybXMucCA/IG5v ZGUtPnBlcm1zLnBbMF0uaWQgOiBjb25uLT5pZDsKIAotCWlmIChjb25uLT50 cmFuc2FjdGlvbikgeworCWlmIChjb25uICYmIGNvbm4tPnRyYW5zYWN0aW9u KSB7CiAJCXRyYW5zYWN0aW9uX2VudHJ5X2RlYyhjb25uLT50cmFuc2FjdGlv biwgZG9taWQpOwogCX0gZWxzZSB7Ci0JCWQgPSAoZG9taWQgPT0gY29ubi0+ aWQgJiYgY29ubi0+ZG9tYWluKSA/IGNvbm4tPmRvbWFpbgorCQlkID0gKGNv bm4gJiYgZG9taWQgPT0gY29ubi0+aWQgJiYgY29ubi0+ZG9tYWluKSA/IGNv bm4tPmRvbWFpbgogCQkgICAgOiBmaW5kX2RvbWFpbl9zdHJ1Y3QoZG9taWQp OwogCQlpZiAoZCkgewogCQkJZC0+bmJlbnRyeS0tOwpAQCAtMTA4Nyw3ICsx MTI5LDcgQEAgaW50IGRvbWFpbl9tZW1vcnlfYWRkKHVuc2lnbmVkIGludCBk b21pZCwgaW50IG1lbSwgYm9vbCBub19xdW90YV9jaGVjaykKIAkJICogZXhp c3QsIGFzIGFjY291bnRpbmcgaXMgZG9uZSBlaXRoZXIgZm9yIGEgZG9tYWlu IHJlbGF0ZWQgdG8KIAkJICogdGhlIGN1cnJlbnQgY29ubmVjdGlvbiwgb3Ig Zm9yIHRoZSBkb21haW4gb3duaW5nIGEgbm9kZQogCQkgKiAod2hpY2ggaXMg YWx3YXlzIGV4aXN0aW5nLCBhcyB0aGUgb3duZXIgb2YgdGhlIG5vZGUgaXMK LQkJICogdGVzdGVkIHRvIGV4aXN0IGFuZCByZXBsYWNlZCBieSBkb21pZCAw IGlmIG5vdCkuCisJCSAqIHRlc3RlZCB0byBleGlzdCBhbmQgZGVsZXRlZCBv ciByZXBsYWNlZCBieSBkb21pZCAwIGlmIG5vdCkuCiAJCSAqIFNvIG5vdCBm aW5kaW5nIHRoZSByZWxhdGVkIGRvbWFpbiBNVVNUIGJlIGFuIGVycm9yIGlu IHRoZQogCQkgKiBkYXRhIGJhc2UuCiAJCSAqLwpkaWZmIC0tZ2l0IGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oIGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2RvbWFpbi5oCmluZGV4IDBiNGY1NmI4MTQ2Yy4uNDkx ZDdhMzI1YmQzIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfZG9tYWluLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Rv bWFpbi5oCkBAIC02NSw3ICs2NSw3IEBAIGJvb2wgZG9tYWluX2Nhbl93cml0 ZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7CiBib29sIGRvbWFpbl9pc191 bnByaXZpbGVnZWQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pOwogCiAvKiBS ZW1vdmUgbm9kZSBwZXJtaXNzaW9ucyBmb3Igbm8gbG9uZ2VyIGV4aXN0aW5n IGRvbWFpbnMuICovCi1pbnQgZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSk7Citp bnQgZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKHN0cnVjdCBub2RlICpub2Rl KTsKIGludCBkb21haW5fYWxsb2NfcGVybXJlZnMoc3RydWN0IG5vZGVfcGVy bXMgKnBlcm1zKTsKIAogLyogUXVvdGEgbWFuaXB1bGF0aW9uICovCg== --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-4.15-xenstored-02.patch" Content-Disposition: attachment; filename="xsa419/xsa419-4.15-xenstored-02.patch" Content-Transfer-Encoding: base64 RnJvbSA5NWE2Yzg1YjBhNGJkNzgyOGNmOTg2MDc3MDI1NGNlZTc4MTBlOGIw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTMgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IG1ha2UgdGhl IGludGVybmFsIG1lbW9yeSBkYXRhIGJhc2UgdGhlIGRlZmF1bHQKCkhhdmlu ZyBhIGZpbGUgYmFja2VkIGRhdGEgYmFzZSBoYXMgdGhlIG9ubHkgYWR2YW50 YWdlIG9mIGJlaW5nIGNhcGFibGUKdG8gZHVtcCB0aGUgY29udGVudHMgb2Yg aXQgd2hpbGUgWGVuc3RvcmUgaXMgcnVubmluZywgYW5kIHBvdGVudGlhbGx5 CnVzaW5nIGxlc3Mgc3dhcCBzcGFjZSBpbiBjYXNlIHRoZSBkYXRhIGJhc2Ug Y2FuJ3QgYmUga2VwdCBpbiBtZW1vcnkuCgpJdCBoYXMgdGhlIG1ham9yIGRp c2FkdmFudGFnZSBvZiBhIGh1Z2UgcGVyZm9ybWFuY2Ugb3ZlcmhlYWQ6IHN3 aXRjaGluZwp0byBrZWVwIHRoZSBkYXRhIGJhc2UgaW4gbWVtb3J5IG9ubHkg c3BlZWRzIHVwIGxpdmUgdXBkYXRlIG9mIHhlbnN0b3JlZAp3aXRoIDEyMDAw MCBub2RlcyBmcm9tIDIwIG1pbnV0ZXMgdG8gMTEgc2Vjb25kcy4gQSBjb21w bGV0ZSB0cmVlIHdhbGsKb2YgdGhpcyBjb25maWd1cmF0aW9uIHdpbGwgYmUg cmVkdWNlZCBmcm9tIDcgc2Vjb25kcyB0byAyODAgbXNlY3MKKG1lYXN1cmVk IGJ5ICJ4ZW5zdG9yZS1jb250cm9sIGNoZWNrIikuCgpTbyBtYWtlIHRoZSBp bnRlcm5hbCBtZW1vcnkgZGF0YSBiYXNlIHRoZSBkZWZhdWx0IGFuZCBlbmhh bmNlIHRoZQoiLS1pbnRlcm5hbC1kYiIgY29tbWFuZCBsaW5lIHBhcmFtZXRl ciB0byB0YWtlIGFuIG9wdGlvbmFsIHBhcmFtZXRlcgphbGxvd2luZyB0byBz d2l0Y2ggdGhlIGludGVybmFsIGRhdGEgYmFzZSBiYWNrIHRvIHRoZSBmaWxl IGJhc2VkIG9uZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtNDE5LgoKUmVwb3J0 ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KU2lnbmVk LW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZp ZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCmRp ZmYgLS1naXQgYS90b29scy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWlu LmMgYi90b29scy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWluLmMKaW5k ZXggMzI2ODlhYmQ3NDc5Li5kMDgwZGFlNWQzYjggMTAwNjQ0Ci0tLSBhL3Rv b2xzL2hlbHBlcnMvaW5pdC14ZW5zdG9yZS1kb21haW4uYworKysgYi90b29s cy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWluLmMKQEAgLTIxNCw5ICsy MTQsOSBAQCBzdGF0aWMgaW50IGJ1aWxkKHhjX2ludGVyZmFjZSAqeGNoKQog ICAgIH0KIAogICAgIGlmICggcGFyYW0gKQotICAgICAgICBzbnByaW50Zihj bWRsaW5lLCA1MTIsICItLWV2ZW50ICVkIC0taW50ZXJuYWwtZGIgJXMiLCBy diwgcGFyYW0pOworICAgICAgICBzbnByaW50ZihjbWRsaW5lLCA1MTIsICIt LWV2ZW50ICVkICVzIiwgcnYsIHBhcmFtKTsKICAgICBlbHNlCi0gICAgICAg IHNucHJpbnRmKGNtZGxpbmUsIDUxMiwgIi0tZXZlbnQgJWQgLS1pbnRlcm5h bC1kYiIsIHJ2KTsKKyAgICAgICAgc25wcmludGYoY21kbGluZSwgNTEyLCAi LS1ldmVudCAlZCIsIHJ2KTsKIAogICAgIGRvbS0+Y21kbGluZSA9IHhjX2Rv bV9zdHJkdXAoZG9tLCBjbWRsaW5lKTsKICAgICBkb20tPnhlbnN0b3JlX2Rv bWlkID0gZG9taWQ7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUu YwppbmRleCBkNWIyZTU5YjBkYjYuLjlkZGJkOTM0Zjc5NCAxMDA2NDQKLS0t IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0yMjMwLDcgKzIyMzAs NyBAQCBzdGF0aWMgdm9pZCBhY2NlcHRfY29ubmVjdGlvbihpbnQgc29jaykK IH0KICNlbmRpZgogCi1zdGF0aWMgaW50IHRkYl9mbGFnczsKK3N0YXRpYyBp bnQgdGRiX2ZsYWdzID0gVERCX0lOVEVSTkFMIHwgVERCX05PTE9DSzsKIAog LyogV2UgY3JlYXRlIGluaXRpYWwgbm9kZXMgbWFudWFsbHkuICovCiBzdGF0 aWMgdm9pZCBtYW51YWxfbm9kZShjb25zdCBjaGFyICpuYW1lLCBjb25zdCBj aGFyICpjaGlsZCkKQEAgLTI1MzcsNyArMjUzNyw4IEBAIHN0YXRpYyB2b2lk IHVzYWdlKHZvaWQpCiAiICAgICAgICAgICAgICAgICAgICAgICAgICB3YXRj aC1ldmVudDogdGltZSBhIHdhdGNoLWV2ZW50IGlzIGtlcHQgcGVuZGluZ1xu IgogIiAgLVIsIC0tbm8tcmVjb3ZlcnkgICAgICAgdG8gcmVxdWVzdCB0aGF0 IG5vIHJlY292ZXJ5IHNob3VsZCBiZSBhdHRlbXB0ZWQgd2hlblxuIgogIiAg ICAgICAgICAgICAgICAgICAgICAgICAgdGhlIHN0b3JlIGlzIGNvcnJ1cHRl ZCAoZGVidWcgb25seSksXG4iCi0iICAtSSwgLS1pbnRlcm5hbC1kYiAgICAg ICBzdG9yZSBkYXRhYmFzZSBpbiBtZW1vcnksIG5vdCBvbiBkaXNrXG4iCisi ICAtSSwgLS1pbnRlcm5hbC1kYiBbb258b2ZmXSBzdG9yZSBkYXRhYmFzZSBp biBtZW1vcnksIG5vdCBvbiBkaXNrLCBkZWZhdWx0IGlzXG4iCisiICAgICAg ICAgICAgICAgICAgICAgICAgICBtZW1vcnksIHdpdGggXCItLWludGVybmFs LWRiIG9mZlwiIGl0IGlzIG9uIGRpc2tcbiIKICIgIC1LLCAtLWtlZXAtb3Jw aGFucyAgICAgIGRvbid0IGRlbGV0ZSBub2RlcyBvd25lZCBieSBhIGRvbWFp biB3aGVuIHRoZVxuIgogIiAgICAgICAgICAgICAgICAgICAgICAgICAgZG9t YWluIGlzIGRlbGV0ZWQgKHRoaXMgaXMgYSBzZWN1cml0eSByaXNrISlcbiIK ICIgIC1WLCAtLXZlcmJvc2UgICAgICAgICAgIHRvIHJlcXVlc3QgdmVyYm9z ZSBleGVjdXRpb24uXG4iKTsKQEAgLTI1NjMsNyArMjU2NCw3IEBAIHN0YXRp YyBzdHJ1Y3Qgb3B0aW9uIG9wdGlvbnNbXSA9IHsKIAl7ICJxdW90YS1zb2Z0 IiwgMSwgTlVMTCwgJ3EnIH0sCiAJeyAidGltZW91dCIsIDEsIE5VTEwsICd3 JyB9LAogCXsgIm5vLXJlY292ZXJ5IiwgMCwgTlVMTCwgJ1InIH0sCi0JeyAi aW50ZXJuYWwtZGIiLCAwLCBOVUxMLCAnSScgfSwKKwl7ICJpbnRlcm5hbC1k YiIsIDIsIE5VTEwsICdJJyB9LAogCXsgImtlZXAtb3JwaGFucyIsIDAsIE5V TEwsICdLJyB9LAogCXsgInZlcmJvc2UiLCAwLCBOVUxMLCAnVicgfSwKIAl7 ICJ3YXRjaC1uYiIsIDEsIE5VTEwsICdXJyB9LApAQCAtMjY0NSw3ICsyNjQ2 LDggQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAlvcmln X2FyZ2MgPSBhcmdjOwogCW9yaWdfYXJndiA9IGFyZ3Y7CiAKLQl3aGlsZSAo KG9wdCA9IGdldG9wdF9sb25nKGFyZ2MsIGFyZ3YsICJERTpGOkhLTlBTOnQ6 QTpNOlE6cTpUOlJWVzp3OlUiLAorCXdoaWxlICgob3B0ID0gZ2V0b3B0X2xv bmcoYXJnYywgYXJndiwKKwkJCQkgICJERTpGOkhJOjpLTlBTOnQ6QTpNOlE6 cTpUOlJWVzp3OlUiLAogCQkJCSAgb3B0aW9ucywgTlVMTCkpICE9IC0xKSB7 CiAJCXN3aXRjaCAob3B0KSB7CiAJCWNhc2UgJ0QnOgpAQCAtMjY3OSw3ICsy NjgxLDggQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAkJ CXRyYWNlZmlsZSA9IG9wdGFyZzsKIAkJCWJyZWFrOwogCQljYXNlICdJJzoK LQkJCXRkYl9mbGFncyA9IFREQl9JTlRFUk5BTHxUREJfTk9MT0NLOworCQkJ aWYgKG9wdGFyZyAmJiAhc3RyY21wKG9wdGFyZywgIm9mZiIpKQorCQkJCXRk Yl9mbGFncyA9IDA7CiAJCQlicmVhazsKIAkJY2FzZSAnSyc6CiAJCQlrZWVw X29ycGhhbnMgPSB0cnVlOwo= --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-4.15-xenstored-03.patch" Content-Disposition: attachment; filename="xsa419/xsa419-4.15-xenstored-03.patch" Content-Transfer-Encoding: base64 RnJvbSBkNGY3YjE1MGQzOGM2NDRhNmVmYjRhMTkzODVmOWJiOTJjNzY4NDJk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTMgKzAyMDAKU3ViamVjdDogZG9jczogZW5oYW5jZSB4ZW5zdG9yZS50 eHQgd2l0aCBwZXJtaXNzaW9ucyBkZXNjcmlwdGlvbgpNSU1FLVZlcnNpb246 IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgK Q29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKVGhlIHBlcm1pc3Np b24gc2NoZW1lIG9mIFhlbnN0b3JlIG5vZGVzIGlzIG5vdCByZWFsbHkgY292 ZXJlZCBieQpkb2NzL21pc2MveGVuc3RvcmUudHh0LCBvdGhlciB0aGFuIHJl ZmVycmluZyB0byB0aGUgWGVuIHdpa2kuCgpBZGQgYSBwYXJhZ3JhcGggZXhw bGFpbmluZyB0aGUgcGVybWlzc2lvbnMgb2Ygbm9kZXMsIGFuZCBlc3BlY2lh bGx5Cm1lbnRpb25pbmcgcmVtb3ZhbCBvZiBub2RlcyB3aGVuIGEgZG9tYWlu IGhhcyBiZWVuIHJlbW92ZWQgZnJvbQpYZW5zdG9yZS4KClRoaXMgaXMgcGFy dCBvZiBYU0EtNDE5LgoKUmVwb3J0ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpn cm9zc0BzdXNlLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8 amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogRWR3aW4gVMO2csO2ayA8 ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvZG9jcy9taXNj L3hlbnN0b3JlLnR4dCBiL2RvY3MvbWlzYy94ZW5zdG9yZS50eHQKaW5kZXgg YTdkMDA2NTE5YWU4Li5lY2NkNTk2ZWUzOGMgMTAwNjQ0Ci0tLSBhL2RvY3Mv bWlzYy94ZW5zdG9yZS50eHQKKysrIGIvZG9jcy9taXNjL3hlbnN0b3JlLnR4 dApAQCAtNDMsNiArNDMsMTcgQEAgYnl0ZXMgYXJlIGZvcmJpZGRlbjsgY2xp ZW50cyBzcGVjaWZ5aW5nIHJlbGF0aXZlIHBhdGhzIHNob3VsZCBrZWVwCiB0 aGVtIHRvIHdpdGhpbiAyMDQ4IGJ5dGVzLiAgKFNlZSBYRU5TVE9SRV8qX1BB VEhfTUFYIGluIHhzX3dpcmUuaC4pCiAKIAorRWFjaCBub2RlIGhhcyBvbmUg b3IgbXVsdGlwbGUgcGVybWlzc2lvbiBlbnRyaWVzLiAgUGVybWlzc2lvbnMg YXJlCitncmFudGVkIGJ5IGRvbWFpbi1pZCwgdGhlIGZpcnN0IHBlcm1pc3Np b24gZW50cnkgb2YgZWFjaCBub2RlIHNwZWNpZmllcwordGhlIG93bmVyIG9m IHRoZSBub2RlLiAgUGVybWlzc2lvbnMgb2YgYSBub2RlIGNhbiBiZSBjaGFu Z2VkIGJ5IHRoZQorb3duZXIgb2YgdGhlIG5vZGUsIHRoZSBvd25lciBjYW4g b25seSBiZSBtb2RpZmllZCBieSB0aGUgY29udHJvbAorZG9tYWluICh1c3Vh bGx5IGRvbWFpbiBpZCAwKS4gIFRoZSBvd25lciBhbHdheXMgaGFzIHRoZSBy aWdodCB0byByZWFkCithbmQgd3JpdGUgdGhlIG5vZGUsIHdoaWxlIG90aGVy IHBlcm1pc3Npb25zIGNhbiBiZSBzZXR1cCB0byBhbGxvdworcmVhZCBhbmQv b3Igd3JpdGUgYWNjZXNzLiAgV2hlbiBhIGRvbWFpbiBpcyBiZWluZyByZW1v dmVkIGZyb20gWGVuc3RvcmUKK25vZGVzIG93bmVkIGJ5IHRoYXQgZG9tYWlu IHdpbGwgYmUgcmVtb3ZlZCB0b2dldGhlciB3aXRoIGFsbCBvZiB0aG9zZQor bm9kZXMnIGNoaWxkcmVuLgorCisKIENvbW11bmljYXRpb24gd2l0aCB4ZW5z dG9yZSBpcyB2aWEgZWl0aGVyIHNvY2tldHMsIG9yIGV2ZW50IGNoYW5uZWwK IGFuZCBzaGFyZWQgbWVtb3J5LCBhcyBzcGVjaWZpZWQgaW4gaW8veHNfd2ly ZS5oOiBlYWNoIG1lc3NhZ2UgaW4KIGVpdGhlciBkaXJlY3Rpb24gaXMgYSBo ZWFkZXIgZm9ybWF0dGVkIGFzIGEgc3RydWN0IHhzZF9zb2NrbXNnCg== --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-oxenstored.patch" Content-Disposition: attachment; filename="xsa419/xsa419-oxenstored.patch" Content-Transfer-Encoding: base64 RnJvbSAwOTIyODM2OWE1NDk0MjcyOTRmZWJlMzUxMzcyZDcyMjdlNjI0ZGEx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNiArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IEZpeCBxdW90YSBieXBhc3Mg b24gZG9tYWluIHNodXRkb3duCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQt VHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5z ZmVyLUVuY29kaW5nOiA4Yml0CgpYU0EtMzIyIGZpeGVkIGEgZG9taWQgcmV1 c2UgdnVsbmVyYWJpbGl0eSBieSBhc3NpZ25pbmcgRG9tMCBhcyB0aGUgb3du ZXIgb2YKYW55IG5vZGVzIGxlZnQgYWZ0ZXIgYSBkb21haW4gaXMgc2h1dGRv d24gKGUuZy4gb3V0c2lkZSBpdHMgL2xvY2FsL2RvbWFpbi9OCnRyZWUpLgoK SG93ZXZlciBEb20wIGhhcyBubyBxdW90YSBvbiBwdXJwb3NlLCBzbyB0aGlz IG9wZW5lZCB1cCBhbm90aGVyIHBvdGVudGlhbAphdHRhY2sgdmVjdG9yLiBB dm9pZCBpdCBieSBkZWxldGluZyB0aGVzZSBub2RlcyBpbnN0ZWFkIG9mIGFz c2lnbmluZyB0aGVtIHRvCkRvbTAuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQx OSAvIENWRS0yMDIyLTQyMzIzLgoKUmVwb3J0ZWQtYnk6IEp1ZXJnZW4gR3Jv c3MgPGpncm9zc0BzdXNlLmNvbT4KRml4ZXM6IGM0NmVmZjkyMTIwOSAoInRv b2xzL29jYW1sL3hlbnN0b3JlZDogY2xlYW4gdXAgcGVybWlzc2lvbnMgZm9y IGRlYWQgZG9tYWlucyIpClNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLDtmsg PGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJpc3RpYW4g TGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+CgpkaWZmIC0t Z2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Blcm1zLm1sIGIvdG9vbHMv b2NhbWwveGVuc3RvcmVkL3Blcm1zLm1sCmluZGV4IGU4YTE2MjIxZjhmYS4u ODRmMjUwM2U4ZTI5IDEwMDY0NAotLS0gYS90b29scy9vY2FtbC94ZW5zdG9y ZWQvcGVybXMubWwKKysrIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Blcm1z Lm1sCkBAIC02NCw4ICs2NCw3IEBAIGxldCBnZXRfb3duZXIgcGVybSA9IHBl cm0ub3duZXIKICogKikKIGxldCByZW1vdmVfZG9taWQgfmRvbWlkIHBlcm0g PQogCWxldCBhY2wgPSBMaXN0LmZpbHRlciAoZnVuIChhY2xfZG9taWQsIF8p IC0+IGFjbF9kb21pZCA8PiBkb21pZCkgcGVybS5hY2wgaW4KLQlsZXQgb3du ZXIgPSBpZiBwZXJtLm93bmVyID0gZG9taWQgdGhlbiAwIGVsc2UgcGVybS5v d25lciBpbgotCXsgcGVybSB3aXRoIGFjbDsgb3duZXIgfQorCWlmIHBlcm0u b3duZXIgPSBkb21pZCB0aGVuIE5vbmUgZWxzZSBTb21lIHsgcGVybSB3aXRo IGFjbDsgb3duZXIgPSBwZXJtLm93bmVyIH0KIAogbGV0IGRlZmF1bHQwID0g Y3JlYXRlIDAgTk9ORSBbXQogCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94 ZW5zdG9yZWQvc3RvcmUubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvc3Rv cmUubWwKaW5kZXggMjBlNjdiMTQyNzQ2Li43MGYwYzgzZGU0MDQgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9zdG9yZS5tbAorKysgYi90 b29scy9vY2FtbC94ZW5zdG9yZWQvc3RvcmUubWwKQEAgLTg3LDEwICs4Nywy MSBAQCBsZXQgY2hlY2tfb3duZXIgbm9kZSBjb25uZWN0aW9uID0KIAogbGV0 IHJlYyByZWN1cnNlIGZjdCBub2RlID0gZmN0IG5vZGU7IFN5bWJvbE1hcC5p dGVyIChmdW4gXyAtPiByZWN1cnNlIGZjdCkgbm9kZS5jaGlsZHJlbgogCi0o KiogW3JlY3Vyc2VfbWFwIGYgdHJlZV0gYXBwbGllcyBbZl0gb24gZWFjaCBu b2RlIGluIHRoZSB0cmVlIHJlY3Vyc2l2ZWx5ICopCi1sZXQgcmVjdXJzZV9t YXAgZiA9CisoKiogW3JlY3Vyc2VfZmlsdGVyX21hcCBmIHRyZWVdIGFwcGxp ZXMgW2ZdIG9uIGVhY2ggbm9kZSBpbiB0aGUgdHJlZSByZWN1cnNpdmVseSwK KyAgICBwb3NzaWJseSByZW1vdmluZyBzb21lIG5vZGVzLgorICAgIE5vdGUg dGhhdCB0aGUgbm9kZXMgcmVtb3ZlZCB0aGlzIHdheSB3b24ndCBnZW5lcmF0 ZSB3YXRjaCBldmVudHMuCisqKQorbGV0IHJlY3Vyc2VfZmlsdGVyX21hcCBm ID0KKwlsZXQgaW52YWxpZCA9IC0xIGluCisJbGV0IGlzX3ZhbGlkIF8gbm9k ZSA9IG5vZGUucGVybXMub3duZXIgPD4gaW52YWxpZCBpbgogCWxldCByZWMg d2FsayBub2RlID0KLQkJZiB7IG5vZGUgd2l0aCBjaGlsZHJlbiA9IFN5bWJv bE1hcC5tYXAgd2FsayBub2RlLmNoaWxkcmVuIH0KKwkJKCogTWFwLmZpbHRl cl9tYXAgaXMgT2NhbWwgNC4xMSsgb25seSAqKQorCQlsZXQgbm9kZSA9CisJ CXsgbm9kZSB3aXRoIGNoaWxkcmVuID0KKwkJCVN5bWJvbE1hcC5tYXAgd2Fs ayBub2RlLmNoaWxkcmVuIHw+IFN5bWJvbE1hcC5maWx0ZXIgaXNfdmFsaWQg fSBpbgorCQltYXRjaCBmIG5vZGUgd2l0aAorCQl8IFNvbWUga2VlcCAtPiBr ZWVwCisJCXwgTm9uZSAtPiB7IG5vZGUgd2l0aCBwZXJtcyA9IHtub2RlLnBl cm1zIHdpdGggb3duZXIgPSBpbnZhbGlkIH0gfQogCWluCiAJd2FsawogCkBA IC00NDQsMTEgKzQ1NSwxMyBAQCBsZXQgc2V0cGVybXMgc3RvcmUgcGVybSBw YXRoIG5wZXJtcyA9CiAKIGxldCByZXNldF9wZXJtaXNzaW9ucyBzdG9yZSBk b21pZCA9CiAJTG9nZ2luZy5pbmZvICJzdG9yZXxub2RlIiAiQ2xlYW5pbmcg dXAgeGVuc3RvcmUgQUNMcyBmb3IgZG9taWQgJWQiIGRvbWlkOwotCXN0b3Jl LnJvb3QgPC0gTm9kZS5yZWN1cnNlX21hcCAoZnVuIG5vZGUgLT4KLQkJbGV0 IHBlcm1zID0gUGVybXMuTm9kZS5yZW1vdmVfZG9taWQgfmRvbWlkIG5vZGUu cGVybXMgaW4KLQkJaWYgcGVybXMgPD4gbm9kZS5wZXJtcyB0aGVuCi0JCQlM b2dnaW5nLmRlYnVnICJzdG9yZXxub2RlIiAiQ2hhbmdlZCBwZXJtaXNzaW9u cyBmb3Igbm9kZSAlcyIgKE5vZGUuZ2V0X25hbWUgbm9kZSk7Ci0JCXsgbm9k ZSB3aXRoIHBlcm1zIH0KKwlzdG9yZS5yb290IDwtIE5vZGUucmVjdXJzZV9m aWx0ZXJfbWFwIChmdW4gbm9kZSAtPgorCQltYXRjaCBQZXJtcy5Ob2RlLnJl bW92ZV9kb21pZCB+ZG9taWQgbm9kZS5wZXJtcyB3aXRoCisJCXwgTm9uZSAt PiBOb25lCisJCXwgU29tZSBwZXJtcyAtPgorCQkJaWYgcGVybXMgPD4gbm9k ZS5wZXJtcyB0aGVuCisJCQkJTG9nZ2luZy5kZWJ1ZyAic3RvcmV8bm9kZSIg IkNoYW5nZWQgcGVybWlzc2lvbnMgZm9yIG5vZGUgJXMiIChOb2RlLmdldF9u YW1lIG5vZGUpOworCQkJU29tZSB7IG5vZGUgd2l0aCBwZXJtcyB9CiAJKSBz dG9yZS5yb290CiAKIHR5cGUgb3BzID0gewo= --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-xenstored-01.patch" Content-Disposition: attachment; filename="xsa419/xsa419-xenstored-01.patch" Content-Transfer-Encoding: base64 RnJvbSBlNDI1MGJmOGIzOWVkNzM2MjNjNzViMGYxNDM2YWM3YzFkNDVhYmE3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTIgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHJlbW92ZSBu b2RlcyBvd25lZCBieSBkZXN0cm95ZWQgZG9tYWluCgpJbiBjYXNlIGEgZG9t YWluIGlzIHJlbW92ZWQgZnJvbSBYZW5zdG9yZSwgcmVtb3ZlIGFsbCBub2Rl cyBvd25lZCBieQppdCBwZXIgZGVmYXVsdC4KClRoaXMgdGFja2xlcyB0aGUg cHJvYmxlbSB0aGF0IG5vZGVzIG1pZ2h0IGJlIGNyZWF0ZWQgYnkgYSBkb21h aW4Kb3V0c2lkZSBpdHMgaG9tZSBwYXRoIGluIFhlbnN0b3JlLCBsZWFkaW5n IHRvIFhlbnN0b3JlIGhvZ2dpbmcgbW9yZQphbmQgbW9yZSBtZW1vcnkuIERv bWFpbiBxdW90YSBkb24ndCB3b3JrIGluIHRoaXMgY2FzZSBpZiB0aGUgZ3Vl c3QgaXMKcmVib290aW5nIGluIGJldHdlZW4uCgpTaW5jZSBYU0EtMzIyIG93 bmVyc2hpcCBvZiBzdWNoIHN0YWxlIG5vZGVzIGlzIHRyYW5zZmVycmVkIHRv IGRvbTAsCndoaWNoIGlzIGhlbHBpbmcgYWdhaW5zdCB1bmludGVuZGVkIGFj Y2VzcywgYnV0IG5vdCBhZ2FpbnN0IE9PTSBvZgpYZW5zdG9yZS4KCkFzIGEg ZmFsbGJhY2sgZm9yIHdlaXJkIGNhc2VzIGFkZCBhIFhlbnN0b3JlIHN0YXJ0 IHBhcmFtZXRlciBmb3IKa2VlcGluZyB0b2RheSdzIHdheSB0byBoYW5kbGUg c3RhbGUgbm9kZXMsIGFkZGluZyB0aGUgcmlzayBvZiBYZW5zdG9yZQpoaXR0 aW5nIGFuIE9PTSBzaXR1YXRpb24uCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQx OSAvIENWRS0yMDIyLTQyMzIyLgoKUmVwb3J0ZWQtYnk6IEp1ZXJnZW4gR3Jv c3MgPGpncm9zc0BzdXNlLmNvbT4KRml4ZXM6IDQ5NjMwNjMyNGQ4ZCAoInRv b2xzL3hlbnN0b3JlOiByZXZva2UgYWNjZXNzIHJpZ2h0cyBmb3IgcmVtb3Zl ZCBkb21haW5zIikKU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdy b3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3Jh bGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuYwppbmRleCBiZGMxNDY3OWFkZjUuLjEzZTQ4YWFhNzMxYyAxMDA2NDQK LS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC04MCw2ICs4MCw3 IEBAIHN0YXRpYyBib29sIHZlcmJvc2UgPSBmYWxzZTsKIExJU1RfSEVBRChj b25uZWN0aW9ucyk7CiBpbnQgdHJhY2VmZCA9IC0xOwogc3RhdGljIGJvb2wg cmVjb3ZlcnkgPSB0cnVlOworYm9vbCBrZWVwX29ycGhhbnMgPSBmYWxzZTsK IHN0YXRpYyBpbnQgcmVvcGVuX2xvZ19waXBlWzJdOwogc3RhdGljIGludCBy ZW9wZW5fbG9nX3BpcGUwX3BvbGxmZF9pZHggPSAtMTsKIGNoYXIgKnRyYWNl ZmlsZSA9IE5VTEw7CkBAIC03NTMsNyArNzU0LDcgQEAgc3RydWN0IG5vZGUg KnJlYWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9p ZCAqY3R4LAogCW5vZGUtPnBlcm1zLnAgPSBoZHItPnBlcm1zOwogCW5vZGUt PmFjYy5kb21pZCA9IG5vZGUtPnBlcm1zLnBbMF0uaWQ7CiAJbm9kZS0+YWNj Lm1lbW9yeSA9IGRhdGEuZHNpemU7Ci0JaWYgKGRvbWFpbl9hZGp1c3Rfbm9k ZV9wZXJtcyhjb25uLCBub2RlKSkKKwlpZiAoZG9tYWluX2FkanVzdF9ub2Rl X3Blcm1zKG5vZGUpKQogCQlnb3RvIGVycm9yOwogCiAJLyogSWYgb3duZXIg aXMgZ29uZSByZXNldCBjdXJyZW50bHkgYWNjb3VudGVkIG1lbW9yeSBzaXpl LiAqLwpAQCAtNzk2LDcgKzc5Nyw3IEBAIGludCB3cml0ZV9ub2RlX3Jhdyhz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgVERCX0RBVEEgKmtleSwgc3RydWN0 IG5vZGUgKm5vZGUsCiAJdm9pZCAqcDsKIAlzdHJ1Y3QgeHNfdGRiX3JlY29y ZF9oZHIgKmhkcjsKIAotCWlmIChkb21haW5fYWRqdXN0X25vZGVfcGVybXMo Y29ubiwgbm9kZSkpCisJaWYgKGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhu b2RlKSkKIAkJcmV0dXJuIGVycm5vOwogCiAJZGF0YS5kc2l6ZSA9IHNpemVv ZigqaGRyKQpAQCAtMTY0Nyw3ICsxNjQ4LDcgQEAgc3RhdGljIGludCBkZWxu b2RlX3N1Yihjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpj b25uLAogCXJldHVybiBXQUxLX1RSRUVfUk1fQ0hJTERFTlRSWTsKIH0KIAot c3RhdGljIGludCBfcm0oc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0 IHZvaWQgKmN0eCwgY29uc3QgY2hhciAqbmFtZSkKK2ludCBybV9ub2RlKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsIGNvbnN0 IGNoYXIgKm5hbWUpCiB7CiAJc3RydWN0IG5vZGUgKnBhcmVudDsKIAljaGFy ICpwYXJlbnRuYW1lID0gZ2V0X3BhcmVudChjdHgsIG5hbWUpOwpAQCAtMTcx MSw3ICsxNzEyLDcgQEAgc3RhdGljIGludCBkb19ybShjb25zdCB2b2lkICpj dHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCWlmIChzdHJlcShuYW1l LCAiLyIpKQogCQlyZXR1cm4gRUlOVkFMOwogCi0JcmV0ID0gX3JtKGNvbm4s IGN0eCwgbmFtZSk7CisJcmV0ID0gcm1fbm9kZShjb25uLCBjdHgsIG5hbWUp OwogCWlmIChyZXQpCiAJCXJldHVybiByZXQ7CiAKQEAgLTI2MTgsNiArMjYx OSw4IEBAIHN0YXRpYyB2b2lkIHVzYWdlKHZvaWQpCiAiICAtUiwgLS1uby1y ZWNvdmVyeSAgICAgICB0byByZXF1ZXN0IHRoYXQgbm8gcmVjb3Zlcnkgc2hv dWxkIGJlIGF0dGVtcHRlZCB3aGVuXG4iCiAiICAgICAgICAgICAgICAgICAg ICAgICAgICB0aGUgc3RvcmUgaXMgY29ycnVwdGVkIChkZWJ1ZyBvbmx5KSxc biIKICIgIC1JLCAtLWludGVybmFsLWRiICAgICAgIHN0b3JlIGRhdGFiYXNl IGluIG1lbW9yeSwgbm90IG9uIGRpc2tcbiIKKyIgIC1LLCAtLWtlZXAtb3Jw aGFucyAgICAgIGRvbid0IGRlbGV0ZSBub2RlcyBvd25lZCBieSBhIGRvbWFp biB3aGVuIHRoZVxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgZG9t YWluIGlzIGRlbGV0ZWQgKHRoaXMgaXMgYSBzZWN1cml0eSByaXNrISlcbiIK ICIgIC1WLCAtLXZlcmJvc2UgICAgICAgICAgIHRvIHJlcXVlc3QgdmVyYm9z ZSBleGVjdXRpb24uXG4iKTsKIH0KIApAQCAtMjY0Miw2ICsyNjQ1LDcgQEAg c3RhdGljIHN0cnVjdCBvcHRpb24gb3B0aW9uc1tdID0gewogCXsgInRpbWVv dXQiLCAxLCBOVUxMLCAndycgfSwKIAl7ICJuby1yZWNvdmVyeSIsIDAsIE5V TEwsICdSJyB9LAogCXsgImludGVybmFsLWRiIiwgMCwgTlVMTCwgJ0knIH0s CisJeyAia2VlcC1vcnBoYW5zIiwgMCwgTlVMTCwgJ0snIH0sCiAJeyAidmVy Ym9zZSIsIDAsIE5VTEwsICdWJyB9LAogCXsgIndhdGNoLW5iIiwgMSwgTlVM TCwgJ1cnIH0sCiAjaWZuZGVmIE5PX0xJVkVfVVBEQVRFCkBAIC0yNzIxLDcg KzI3MjUsNyBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQog CW9yaWdfYXJnYyA9IGFyZ2M7CiAJb3JpZ19hcmd2ID0gYXJndjsKIAotCXdo aWxlICgob3B0ID0gZ2V0b3B0X2xvbmcoYXJnYywgYXJndiwgIkRFOkY6SE5Q Uzp0OkE6TTpROnE6VDpSVlc6dzpVIiwKKwl3aGlsZSAoKG9wdCA9IGdldG9w dF9sb25nKGFyZ2MsIGFyZ3YsICJERTpGOkhLTlBTOnQ6QTpNOlE6cTpUOlJW Vzp3OlUiLAogCQkJCSAgb3B0aW9ucywgTlVMTCkpICE9IC0xKSB7CiAJCXN3 aXRjaCAob3B0KSB7CiAJCWNhc2UgJ0QnOgpAQCAtMjc1Nyw2ICsyNzYxLDkg QEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAkJY2FzZSAn SSc6CiAJCQl0ZGJfZmxhZ3MgPSBUREJfSU5URVJOQUx8VERCX05PTE9DSzsK IAkJCWJyZWFrOworCQljYXNlICdLJzoKKwkJCWtlZXBfb3JwaGFucyA9IHRy dWU7CisJCQlicmVhazsKIAkJY2FzZSAnVic6CiAJCQl2ZXJib3NlID0gdHJ1 ZTsKIAkJCWJyZWFrOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmgKaW5kZXggYWNiMDBhZDk2OTE0Li4zNzAwNmQ1MDhkYmYgMTAwNjQ0Ci0t LSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKKysrIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMjQwLDYgKzI0MCw5 IEBAIGludCB3cml0ZV9ub2RlX3JhdyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgVERCX0RBVEEgKmtleSwgc3RydWN0IG5vZGUgKm5vZGUsCiBzdHJ1Y3Qg bm9kZSAqcmVhZF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25z dCB2b2lkICpjdHgsCiAJCSAgICAgICBjb25zdCBjaGFyICpuYW1lKTsKIAor LyogUmVtb3ZlIGEgbm9kZSBhbmQgaXRzIGNoaWxkcmVuLiAqLworaW50IHJt X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0 eCwgY29uc3QgY2hhciAqbmFtZSk7CisKIHZvaWQgc2V0dXBfc3RydWN0dXJl KGJvb2wgbGl2ZV91cGRhdGUpOwogc3RydWN0IGNvbm5lY3Rpb24gKm5ld19j b25uZWN0aW9uKGNvbnN0IHN0cnVjdCBpbnRlcmZhY2VfZnVuY3MgKmZ1bmNz KTsKIHN0cnVjdCBjb25uZWN0aW9uICpnZXRfY29ubmVjdGlvbl9ieV9pZCh1 bnNpZ25lZCBpbnQgY29ubl9pZCk7CkBAIC0yODQsNiArMjg3LDcgQEAgZXh0 ZXJuIGludCBxdW90YV9yZXFfb3V0c3RhbmRpbmc7CiBleHRlcm4gaW50IHF1 b3RhX3RyYW5zX25vZGVzOwogZXh0ZXJuIGludCBxdW90YV9tZW1vcnlfcGVy X2RvbWFpbl9zb2Z0OwogZXh0ZXJuIGludCBxdW90YV9tZW1vcnlfcGVyX2Rv bWFpbl9oYXJkOworZXh0ZXJuIGJvb2wga2VlcF9vcnBoYW5zOwogCiBleHRl cm4gdW5zaWduZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIApk aWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5j IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IDk4 YjQwMWZkZWMzMC4uODRiNzgxN2NkNWU2IDEwMDY0NAotLS0gYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2RvbWFpbi5jCkBAIC0yMjcsMTAgKzIyNyw2NCBAQCBz dGF0aWMgdm9pZCB1bm1hcF9pbnRlcmZhY2Uodm9pZCAqaW50ZXJmYWNlKQog CXhlbmdudHRhYl91bm1hcCgqeGd0X2hhbmRsZSwgaW50ZXJmYWNlLCAxKTsK IH0KIAorc3RhdGljIGludCBkb21haW5fdHJlZV9yZW1vdmVfc3ViKGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCQkJICBz dHJ1Y3Qgbm9kZSAqbm9kZSwgdm9pZCAqYXJnKQoreworCXN0cnVjdCBkb21h aW4gKmRvbWFpbiA9IGFyZzsKKwlUREJfREFUQSBrZXk7CisJaW50IHJldCA9 IFdBTEtfVFJFRV9PSzsKKworCWlmIChub2RlLT5wZXJtcy5wWzBdLmlkICE9 IGRvbWFpbi0+ZG9taWQpCisJCXJldHVybiBXQUxLX1RSRUVfT0s7CisKKwlp ZiAoa2VlcF9vcnBoYW5zKSB7CisJCXNldF90ZGJfa2V5KG5vZGUtPm5hbWUs ICZrZXkpOworCQlkb21haW4tPm5iZW50cnktLTsKKwkJbm9kZS0+cGVybXMu cFswXS5pZCA9IHByaXZfZG9taWQ7CisJCW5vZGUtPmFjYy5tZW1vcnkgPSAw OworCQlkb21haW5fZW50cnlfaW5jKE5VTEwsIG5vZGUpOworCQlpZiAod3Jp dGVfbm9kZV9yYXcoTlVMTCwgJmtleSwgbm9kZSwgdHJ1ZSkpIHsKKwkJCS8q IFRoYXQncyB1bmZvcnR1bmF0ZS4gV2Ugb25seSBjYW4gdHJ5IHRvIGNvbnRp bnVlLiAqLworCQkJc3lzbG9nKExPR19FUlIsCisJCQkgICAgICAgImVycm9y IHdoZW4gbW92aW5nIG9ycGhhbmVkIG5vZGUgJXMgdG8gZG9tMFxuIiwKKwkJ CSAgICAgICBub2RlLT5uYW1lKTsKKwkJfSBlbHNlCisJCQl0cmFjZSgib3Jw aGFuZWQgbm9kZSAlcyBtb3ZlZCB0byBkb20wXG4iLCBub2RlLT5uYW1lKTsK Kwl9IGVsc2UgeworCQlpZiAocm1fbm9kZShOVUxMLCBjdHgsIG5vZGUtPm5h bWUpKSB7CisJCQkvKiBUaGF0J3MgdW5mb3J0dW5hdGUuIFdlIG9ubHkgY2Fu IHRyeSB0byBjb250aW51ZS4gKi8KKwkJCXN5c2xvZyhMT0dfRVJSLAorCQkJ ICAgICAgICJlcnJvciB3aGVuIGRlbGV0aW5nIG9ycGhhbmVkIG5vZGUgJXNc biIsCisJCQkgICAgICAgbm9kZS0+bmFtZSk7CisJCX0gZWxzZQorCQkJdHJh Y2UoIm9ycGhhbmVkIG5vZGUgJXMgZGVsZXRlZFxuIiwgbm9kZS0+bmFtZSk7 CisKKwkJLyogU2tpcCBjaGlsZHJlbiBpbiBhbGwgY2FzZXMgaW4gb3JkZXIg dG8gYXZvaWQgbW9yZSBlcnJvcnMuICovCisJCXJldCA9IFdBTEtfVFJFRV9T S0lQX0NISUxEUkVOOworCX0KKworCXJldHVybiBkb21haW4tPm5iZW50cnkg PiAwID8gcmV0IDogV0FMS19UUkVFX1NVQ0NFU1NfU1RPUDsKK30KKworc3Rh dGljIHZvaWQgZG9tYWluX3RyZWVfcmVtb3ZlKHN0cnVjdCBkb21haW4gKmRv bWFpbikKK3sKKwlpbnQgcmV0OworCXN0cnVjdCB3YWxrX2Z1bmNzIHdhbGtm dW5jcyA9IHsgLmVudGVyID0gZG9tYWluX3RyZWVfcmVtb3ZlX3N1YiB9Owor CisJaWYgKGRvbWFpbi0+bmJlbnRyeSA+IDApIHsKKwkJcmV0ID0gd2Fsa19u b2RlX3RyZWUoZG9tYWluLCBOVUxMLCAiLyIsICZ3YWxrZnVuY3MsIGRvbWFp bik7CisJCWlmIChyZXQgPT0gV0FMS19UUkVFX0VSUk9SX1NUT1ApCisJCQlz eXNsb2coTE9HX0VSUiwKKwkJCSAgICAgICAiZXJyb3Igd2hlbiBsb29raW5n IGZvciBvcnBoYW5lZCBub2Rlc1xuIik7CisJfQorfQorCiBzdGF0aWMgaW50 IGRlc3Ryb3lfZG9tYWluKHZvaWQgKl9kb21haW4pCiB7CiAJc3RydWN0IGRv bWFpbiAqZG9tYWluID0gX2RvbWFpbjsKIAorCWRvbWFpbl90cmVlX3JlbW92 ZShkb21haW4pOworCiAJbGlzdF9kZWwoJmRvbWFpbi0+bGlzdCk7CiAKIAlp ZiAoIWRvbWFpbi0+aW50cm9kdWNlZCkKQEAgLTg4MywxNSArOTM3LDE1IEBA IGludCBkb21haW5fZW50cnlfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25u LCBzdHJ1Y3Qgbm9kZSAqbm9kZSkKIAlzdHJ1Y3QgZG9tYWluICpkOwogCXVu c2lnbmVkIGludCBkb21pZDsKIAotCWlmICghY29ubikKKwlpZiAoIW5vZGUt PnBlcm1zLnApCiAJCXJldHVybiAwOwogCi0JZG9taWQgPSBub2RlLT5wZXJt cy5wID8gbm9kZS0+cGVybXMucFswXS5pZCA6IGNvbm4tPmlkOworCWRvbWlk ID0gbm9kZS0+cGVybXMucFswXS5pZDsKIAotCWlmIChjb25uLT50cmFuc2Fj dGlvbikgeworCWlmIChjb25uICYmIGNvbm4tPnRyYW5zYWN0aW9uKSB7CiAJ CXRyYW5zYWN0aW9uX2VudHJ5X2luYyhjb25uLT50cmFuc2FjdGlvbiwgZG9t aWQpOwogCX0gZWxzZSB7Ci0JCWQgPSAoZG9taWQgPT0gY29ubi0+aWQgJiYg Y29ubi0+ZG9tYWluKSA/IGNvbm4tPmRvbWFpbgorCQlkID0gKGNvbm4gJiYg ZG9taWQgPT0gY29ubi0+aWQgJiYgY29ubi0+ZG9tYWluKSA/IGNvbm4tPmRv bWFpbgogCQkgICAgOiBmaW5kX29yX2FsbG9jX2V4aXN0aW5nX2RvbWFpbihk b21pZCk7CiAJCWlmIChkKQogCQkJZC0+bmJlbnRyeSsrOwpAQCAtOTUyLDIz ICsxMDA2LDExIEBAIGludCBkb21haW5fYWxsb2NfcGVybXJlZnMoc3RydWN0 IG5vZGVfcGVybXMgKnBlcm1zKQogICogUmVtb3ZlIHBlcm1pc3Npb25zIGZv ciBubyBsb25nZXIgZXhpc3RpbmcgZG9tYWlucyBpbiBvcmRlciB0byBhdm9p ZCBhIG5ldwogICogZG9tYWluIHdpdGggdGhlIHNhbWUgZG9taWQgaW5oZXJp dGluZyB0aGUgcGVybWlzc2lvbnMuCiAgKi8KLWludCBkb21haW5fYWRqdXN0 X25vZGVfcGVybXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlKQoraW50IGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhzdHJ1 Y3Qgbm9kZSAqbm9kZSkKIHsKIAl1bnNpZ25lZCBpbnQgaTsKIAlpbnQgcmV0 OwogCi0JcmV0ID0gY2hrX2RvbWFpbl9nZW5lcmF0aW9uKG5vZGUtPnBlcm1z LnBbMF0uaWQsIG5vZGUtPmdlbmVyYXRpb24pOwotCi0JLyogSWYgdGhlIG93 bmVyIGRvZXNuJ3QgZXhpc3QgYW55IGxvbmdlciBnaXZlIGl0IHRvIHByaXYg ZG9tYWluLiAqLwotCWlmICghcmV0KSB7Ci0JCS8qCi0JCSAqIEluIHRoZW9y eSB3ZSdkIG5lZWQgdG8gdXBkYXRlIHRoZSBudW1iZXIgb2YgZG9tMCBub2Rl cyBoZXJlLAotCQkgKiBidXQgd2UgY291bGQgYmUgY2FsbGVkIGZvciBhIHJl YWQgb2YgdGhlIG5vZGUuIFNvIGJldHRlcgotCQkgKiBhdm9pZCB0aGUgcmlz ayB0byBvdmVyZmxvdyB0aGUgbm9kZSBjb3VudCBvZiBkb20wLgotCQkgKi8K LQkJbm9kZS0+cGVybXMucFswXS5pZCA9IHByaXZfZG9taWQ7Ci0JfQotCiAJ Zm9yIChpID0gMTsgaSA8IG5vZGUtPnBlcm1zLm51bTsgaSsrKSB7CiAJCWlm IChub2RlLT5wZXJtcy5wW2ldLnBlcm1zICYgWFNfUEVSTV9JR05PUkUpCiAJ CQljb250aW51ZTsKQEAgLTk4NiwxNSArMTAyOCwxNSBAQCB2b2lkIGRvbWFp bl9lbnRyeV9kZWMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlKQogCXN0cnVjdCBkb21haW4gKmQ7CiAJdW5zaWduZWQgaW50 IGRvbWlkOwogCi0JaWYgKCFjb25uKQorCWlmICghbm9kZS0+cGVybXMucCkK IAkJcmV0dXJuOwogCiAJZG9taWQgPSBub2RlLT5wZXJtcy5wID8gbm9kZS0+ cGVybXMucFswXS5pZCA6IGNvbm4tPmlkOwogCi0JaWYgKGNvbm4tPnRyYW5z YWN0aW9uKSB7CisJaWYgKGNvbm4gJiYgY29ubi0+dHJhbnNhY3Rpb24pIHsK IAkJdHJhbnNhY3Rpb25fZW50cnlfZGVjKGNvbm4tPnRyYW5zYWN0aW9uLCBk b21pZCk7CiAJfSBlbHNlIHsKLQkJZCA9IChkb21pZCA9PSBjb25uLT5pZCAm JiBjb25uLT5kb21haW4pID8gY29ubi0+ZG9tYWluCisJCWQgPSAoY29ubiAm JiBkb21pZCA9PSBjb25uLT5pZCAmJiBjb25uLT5kb21haW4pID8gY29ubi0+ ZG9tYWluCiAJCSAgICA6IGZpbmRfZG9tYWluX3N0cnVjdChkb21pZCk7CiAJ CWlmIChkKSB7CiAJCQlkLT5uYmVudHJ5LS07CkBAIC0xMTEzLDcgKzExNTUs NyBAQCBpbnQgZG9tYWluX21lbW9yeV9hZGQodW5zaWduZWQgaW50IGRvbWlk LCBpbnQgbWVtLCBib29sIG5vX3F1b3RhX2NoZWNrKQogCQkgKiBleGlzdCwg YXMgYWNjb3VudGluZyBpcyBkb25lIGVpdGhlciBmb3IgYSBkb21haW4gcmVs YXRlZCB0bwogCQkgKiB0aGUgY3VycmVudCBjb25uZWN0aW9uLCBvciBmb3Ig dGhlIGRvbWFpbiBvd25pbmcgYSBub2RlCiAJCSAqICh3aGljaCBpcyBhbHdh eXMgZXhpc3RpbmcsIGFzIHRoZSBvd25lciBvZiB0aGUgbm9kZSBpcwotCQkg KiB0ZXN0ZWQgdG8gZXhpc3QgYW5kIHJlcGxhY2VkIGJ5IGRvbWlkIDAgaWYg bm90KS4KKwkJICogdGVzdGVkIHRvIGV4aXN0IGFuZCBkZWxldGVkIG9yIHJl cGxhY2VkIGJ5IGRvbWlkIDAgaWYgbm90KS4KIAkJICogU28gbm90IGZpbmRp bmcgdGhlIHJlbGF0ZWQgZG9tYWluIE1VU1QgYmUgYW4gZXJyb3IgaW4gdGhl CiAJCSAqIGRhdGEgYmFzZS4KIAkJICovCmRpZmYgLS1naXQgYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmggYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfZG9tYWluLmgKaW5kZXggN2ZlMGEyMWQ5ZTQ1Li5iMzhjODI5 OTFkYzYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9k b21haW4uaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWlu LmgKQEAgLTYyLDcgKzYyLDcgQEAgY29uc3QgY2hhciAqZ2V0X2ltcGxpY2l0 X3BhdGgoY29uc3Qgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pOwogYm9vbCBk b21haW5faXNfdW5wcml2aWxlZ2VkKHN0cnVjdCBjb25uZWN0aW9uICpjb25u KTsKIAogLyogUmVtb3ZlIG5vZGUgcGVybWlzc2lvbnMgZm9yIG5vIGxvbmdl ciBleGlzdGluZyBkb21haW5zLiAqLwotaW50IGRvbWFpbl9hZGp1c3Rfbm9k ZV9wZXJtcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUg Km5vZGUpOworaW50IGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhzdHJ1Y3Qg bm9kZSAqbm9kZSk7CiBpbnQgZG9tYWluX2FsbG9jX3Blcm1yZWZzKHN0cnVj dCBub2RlX3Blcm1zICpwZXJtcyk7CiAKIC8qIFF1b3RhIG1hbmlwdWxhdGlv biAqLwo= --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-xenstored-02.patch" Content-Disposition: attachment; filename="xsa419/xsa419-xenstored-02.patch" Content-Transfer-Encoding: base64 RnJvbSA5MjlkYTU1N2VmZWE2YzdkMjM0MDQ2N2Q5YTdmZGFlN2ZkYTZkMmIx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTMgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IG1ha2UgdGhl IGludGVybmFsIG1lbW9yeSBkYXRhIGJhc2UgdGhlIGRlZmF1bHQKCkhhdmlu ZyBhIGZpbGUgYmFja2VkIGRhdGEgYmFzZSBoYXMgdGhlIG9ubHkgYWR2YW50 YWdlIG9mIGJlaW5nIGNhcGFibGUKdG8gZHVtcCB0aGUgY29udGVudHMgb2Yg aXQgd2hpbGUgWGVuc3RvcmUgaXMgcnVubmluZywgYW5kIHBvdGVudGlhbGx5 CnVzaW5nIGxlc3Mgc3dhcCBzcGFjZSBpbiBjYXNlIHRoZSBkYXRhIGJhc2Ug Y2FuJ3QgYmUga2VwdCBpbiBtZW1vcnkuCgpJdCBoYXMgdGhlIG1ham9yIGRp c2FkdmFudGFnZSBvZiBhIGh1Z2UgcGVyZm9ybWFuY2Ugb3ZlcmhlYWQ6IHN3 aXRjaGluZwp0byBrZWVwIHRoZSBkYXRhIGJhc2UgaW4gbWVtb3J5IG9ubHkg c3BlZWRzIHVwIGxpdmUgdXBkYXRlIG9mIHhlbnN0b3JlZAp3aXRoIDEyMDAw MCBub2RlcyBmcm9tIDIwIG1pbnV0ZXMgdG8gMTEgc2Vjb25kcy4gQSBjb21w bGV0ZSB0cmVlIHdhbGsKb2YgdGhpcyBjb25maWd1cmF0aW9uIHdpbGwgYmUg cmVkdWNlZCBmcm9tIDcgc2Vjb25kcyB0byAyODAgbXNlY3MKKG1lYXN1cmVk IGJ5ICJ4ZW5zdG9yZS1jb250cm9sIGNoZWNrIikuCgpTbyBtYWtlIHRoZSBp bnRlcm5hbCBtZW1vcnkgZGF0YSBiYXNlIHRoZSBkZWZhdWx0IGFuZCBlbmhh bmNlIHRoZQoiLS1pbnRlcm5hbC1kYiIgY29tbWFuZCBsaW5lIHBhcmFtZXRl ciB0byB0YWtlIGFuIG9wdGlvbmFsIHBhcmFtZXRlcgphbGxvd2luZyB0byBz d2l0Y2ggdGhlIGludGVybmFsIGRhdGEgYmFzZSBiYWNrIHRvIHRoZSBmaWxl IGJhc2VkIG9uZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtNDE5LgoKUmVwb3J0 ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KU2lnbmVk LW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZp ZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCmRp ZmYgLS1naXQgYS90b29scy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWlu LmMgYi90b29scy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWluLmMKaW5k ZXggMmQ5YWI2ZjFjNTgzLi4wNGUzNTFjYTI5YTggMTAwNjQ0Ci0tLSBhL3Rv b2xzL2hlbHBlcnMvaW5pdC14ZW5zdG9yZS1kb21haW4uYworKysgYi90b29s cy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWluLmMKQEAgLTIyMiw5ICsy MjIsOSBAQCBzdGF0aWMgaW50IGJ1aWxkKHhjX2ludGVyZmFjZSAqeGNoKQog ICAgIH0KIAogICAgIGlmICggcGFyYW0gKQotICAgICAgICBzbnByaW50Zihj bWRsaW5lLCA1MTIsICItLWV2ZW50ICVkIC0taW50ZXJuYWwtZGIgJXMiLCBy diwgcGFyYW0pOworICAgICAgICBzbnByaW50ZihjbWRsaW5lLCA1MTIsICIt LWV2ZW50ICVkICVzIiwgcnYsIHBhcmFtKTsKICAgICBlbHNlCi0gICAgICAg IHNucHJpbnRmKGNtZGxpbmUsIDUxMiwgIi0tZXZlbnQgJWQgLS1pbnRlcm5h bC1kYiIsIHJ2KTsKKyAgICAgICAgc25wcmludGYoY21kbGluZSwgNTEyLCAi LS1ldmVudCAlZCIsIHJ2KTsKIAogICAgIGRvbS0+Z3Vlc3RfZG9taWQgPSBk b21pZDsKICAgICBkb20tPmNtZGxpbmUgPSB4Y19kb21fc3RyZHVwKGRvbSwg Y21kbGluZSk7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpp bmRleCAxM2U0OGFhYTczMWMuLjM2ZmI0YTgzMjgzNCAxMDA2NDQKLS0tIGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0yMzA4LDcgKzIzMDgsNyBA QCBzdGF0aWMgdm9pZCBhY2NlcHRfY29ubmVjdGlvbihpbnQgc29jaykKIH0K ICNlbmRpZgogCi1zdGF0aWMgaW50IHRkYl9mbGFnczsKK3N0YXRpYyBpbnQg dGRiX2ZsYWdzID0gVERCX0lOVEVSTkFMIHwgVERCX05PTE9DSzsKIAogLyog V2UgY3JlYXRlIGluaXRpYWwgbm9kZXMgbWFudWFsbHkuICovCiBzdGF0aWMg dm9pZCBtYW51YWxfbm9kZShjb25zdCBjaGFyICpuYW1lLCBjb25zdCBjaGFy ICpjaGlsZCkKQEAgLTI2MTgsNyArMjYxOCw4IEBAIHN0YXRpYyB2b2lkIHVz YWdlKHZvaWQpCiAiICAgICAgICAgICAgICAgICAgICAgICAgICB3YXRjaC1l dmVudDogdGltZSBhIHdhdGNoLWV2ZW50IGlzIGtlcHQgcGVuZGluZ1xuIgog IiAgLVIsIC0tbm8tcmVjb3ZlcnkgICAgICAgdG8gcmVxdWVzdCB0aGF0IG5v IHJlY292ZXJ5IHNob3VsZCBiZSBhdHRlbXB0ZWQgd2hlblxuIgogIiAgICAg ICAgICAgICAgICAgICAgICAgICAgdGhlIHN0b3JlIGlzIGNvcnJ1cHRlZCAo ZGVidWcgb25seSksXG4iCi0iICAtSSwgLS1pbnRlcm5hbC1kYiAgICAgICBz dG9yZSBkYXRhYmFzZSBpbiBtZW1vcnksIG5vdCBvbiBkaXNrXG4iCisiICAt SSwgLS1pbnRlcm5hbC1kYiBbb258b2ZmXSBzdG9yZSBkYXRhYmFzZSBpbiBt ZW1vcnksIG5vdCBvbiBkaXNrLCBkZWZhdWx0IGlzXG4iCisiICAgICAgICAg ICAgICAgICAgICAgICAgICBtZW1vcnksIHdpdGggXCItLWludGVybmFsLWRi IG9mZlwiIGl0IGlzIG9uIGRpc2tcbiIKICIgIC1LLCAtLWtlZXAtb3JwaGFu cyAgICAgIGRvbid0IGRlbGV0ZSBub2RlcyBvd25lZCBieSBhIGRvbWFpbiB3 aGVuIHRoZVxuIgogIiAgICAgICAgICAgICAgICAgICAgICAgICAgZG9tYWlu IGlzIGRlbGV0ZWQgKHRoaXMgaXMgYSBzZWN1cml0eSByaXNrISlcbiIKICIg IC1WLCAtLXZlcmJvc2UgICAgICAgICAgIHRvIHJlcXVlc3QgdmVyYm9zZSBl eGVjdXRpb24uXG4iKTsKQEAgLTI2NDQsNyArMjY0NSw3IEBAIHN0YXRpYyBz dHJ1Y3Qgb3B0aW9uIG9wdGlvbnNbXSA9IHsKIAl7ICJxdW90YS1zb2Z0Iiwg MSwgTlVMTCwgJ3EnIH0sCiAJeyAidGltZW91dCIsIDEsIE5VTEwsICd3JyB9 LAogCXsgIm5vLXJlY292ZXJ5IiwgMCwgTlVMTCwgJ1InIH0sCi0JeyAiaW50 ZXJuYWwtZGIiLCAwLCBOVUxMLCAnSScgfSwKKwl7ICJpbnRlcm5hbC1kYiIs IDIsIE5VTEwsICdJJyB9LAogCXsgImtlZXAtb3JwaGFucyIsIDAsIE5VTEws ICdLJyB9LAogCXsgInZlcmJvc2UiLCAwLCBOVUxMLCAnVicgfSwKIAl7ICJ3 YXRjaC1uYiIsIDEsIE5VTEwsICdXJyB9LApAQCAtMjcyNSw3ICsyNzI2LDgg QEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAlvcmlnX2Fy Z2MgPSBhcmdjOwogCW9yaWdfYXJndiA9IGFyZ3Y7CiAKLQl3aGlsZSAoKG9w dCA9IGdldG9wdF9sb25nKGFyZ2MsIGFyZ3YsICJERTpGOkhLTlBTOnQ6QTpN OlE6cTpUOlJWVzp3OlUiLAorCXdoaWxlICgob3B0ID0gZ2V0b3B0X2xvbmco YXJnYywgYXJndiwKKwkJCQkgICJERTpGOkhJOjpLTlBTOnQ6QTpNOlE6cTpU OlJWVzp3OlUiLAogCQkJCSAgb3B0aW9ucywgTlVMTCkpICE9IC0xKSB7CiAJ CXN3aXRjaCAob3B0KSB7CiAJCWNhc2UgJ0QnOgpAQCAtMjc1OSw3ICsyNzYx LDggQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAkJCXRy YWNlZmlsZSA9IG9wdGFyZzsKIAkJCWJyZWFrOwogCQljYXNlICdJJzoKLQkJ CXRkYl9mbGFncyA9IFREQl9JTlRFUk5BTHxUREJfTk9MT0NLOworCQkJaWYg KG9wdGFyZyAmJiAhc3RyY21wKG9wdGFyZywgIm9mZiIpKQorCQkJCXRkYl9m bGFncyA9IDA7CiAJCQlicmVhazsKIAkJY2FzZSAnSyc6CiAJCQlrZWVwX29y cGhhbnMgPSB0cnVlOwo= --=separator Content-Type: application/octet-stream; name="xsa419/xsa419-xenstored-03.patch" Content-Disposition: attachment; filename="xsa419/xsa419-xenstored-03.patch" Content-Transfer-Encoding: base64 RnJvbSA1NGU2M2I3ZTdjNDJlNGY5NzUxNjM4MDlhMDE1NzRlNzg1NTJhNmFi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTMgKzAyMDAKU3ViamVjdDogZG9jczogZW5oYW5jZSB4ZW5zdG9yZS50 eHQgd2l0aCBwZXJtaXNzaW9ucyBkZXNjcmlwdGlvbgpNSU1FLVZlcnNpb246 IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgK Q29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKVGhlIHBlcm1pc3Np b24gc2NoZW1lIG9mIFhlbnN0b3JlIG5vZGVzIGlzIG5vdCByZWFsbHkgY292 ZXJlZCBieQpkb2NzL21pc2MveGVuc3RvcmUudHh0LCBvdGhlciB0aGFuIHJl ZmVycmluZyB0byB0aGUgWGVuIHdpa2kuCgpBZGQgYSBwYXJhZ3JhcGggZXhw bGFpbmluZyB0aGUgcGVybWlzc2lvbnMgb2Ygbm9kZXMsIGFuZCBlc3BlY2lh bGx5Cm1lbnRpb25pbmcgcmVtb3ZhbCBvZiBub2RlcyB3aGVuIGEgZG9tYWlu IGhhcyBiZWVuIHJlbW92ZWQgZnJvbQpYZW5zdG9yZS4KClRoaXMgaXMgcGFy dCBvZiBYU0EtNDE5LgoKUmVwb3J0ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpn cm9zc0BzdXNlLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8 amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogRWR3aW4gVMO2csO2ayA8 ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvZG9jcy9taXNj L3hlbnN0b3JlLnR4dCBiL2RvY3MvbWlzYy94ZW5zdG9yZS50eHQKaW5kZXgg OTg4ZWY4OWNiYTJkLi40NDQyOGFlM2E3NTUgMTAwNjQ0Ci0tLSBhL2RvY3Mv bWlzYy94ZW5zdG9yZS50eHQKKysrIGIvZG9jcy9taXNjL3hlbnN0b3JlLnR4 dApAQCAtNDMsNiArNDMsMTcgQEAgYnl0ZXMgYXJlIGZvcmJpZGRlbjsgY2xp ZW50cyBzcGVjaWZ5aW5nIHJlbGF0aXZlIHBhdGhzIHNob3VsZCBrZWVwCiB0 aGVtIHRvIHdpdGhpbiAyMDQ4IGJ5dGVzLiAgKFNlZSBYRU5TVE9SRV8qX1BB VEhfTUFYIGluIHhzX3dpcmUuaC4pCiAKIAorRWFjaCBub2RlIGhhcyBvbmUg b3IgbXVsdGlwbGUgcGVybWlzc2lvbiBlbnRyaWVzLiAgUGVybWlzc2lvbnMg YXJlCitncmFudGVkIGJ5IGRvbWFpbi1pZCwgdGhlIGZpcnN0IHBlcm1pc3Np b24gZW50cnkgb2YgZWFjaCBub2RlIHNwZWNpZmllcwordGhlIG93bmVyIG9m IHRoZSBub2RlLiAgUGVybWlzc2lvbnMgb2YgYSBub2RlIGNhbiBiZSBjaGFu Z2VkIGJ5IHRoZQorb3duZXIgb2YgdGhlIG5vZGUsIHRoZSBvd25lciBjYW4g b25seSBiZSBtb2RpZmllZCBieSB0aGUgY29udHJvbAorZG9tYWluICh1c3Vh bGx5IGRvbWFpbiBpZCAwKS4gIFRoZSBvd25lciBhbHdheXMgaGFzIHRoZSBy aWdodCB0byByZWFkCithbmQgd3JpdGUgdGhlIG5vZGUsIHdoaWxlIG90aGVy IHBlcm1pc3Npb25zIGNhbiBiZSBzZXR1cCB0byBhbGxvdworcmVhZCBhbmQv b3Igd3JpdGUgYWNjZXNzLiAgV2hlbiBhIGRvbWFpbiBpcyBiZWluZyByZW1v dmVkIGZyb20gWGVuc3RvcmUKK25vZGVzIG93bmVkIGJ5IHRoYXQgZG9tYWlu IHdpbGwgYmUgcmVtb3ZlZCB0b2dldGhlciB3aXRoIGFsbCBvZiB0aG9zZQor bm9kZXMnIGNoaWxkcmVuLgorCisKIENvbW11bmljYXRpb24gd2l0aCB4ZW5z dG9yZSBpcyB2aWEgZWl0aGVyIHNvY2tldHMsIG9yIGV2ZW50IGNoYW5uZWwK IGFuZCBzaGFyZWQgbWVtb3J5LCBhcyBzcGVjaWZpZWQgaW4gaW8veHNfd2ly ZS5oOiBlYWNoIG1lc3NhZ2UgaW4KIGVpdGhlciBkaXJlY3Rpb24gaXMgYSBo ZWFkZXIgZm9ybWF0dGVkIGFzIGEgc3RydWN0IHhzZF9zb2NrbXNnCg== --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Nov 01 12:01:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 12:01:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433509.686671 (Exim 4.92) (envelope-from ) id 1oppxR-0003Hk-12; Tue, 01 Nov 2022 12:01:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433509.686671; Tue, 01 Nov 2022 12:01:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppxP-0003Ah-L5; Tue, 01 Nov 2022 12:01:27 +0000 Received: by outflank-mailman (input) for mailman id 433509; Tue, 01 Nov 2022 12:01:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppxI-0000IJ-VZ for xen-devel@lists.xen.org; Tue, 01 Nov 2022 12:01:21 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d8973328-59dc-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 13:00:58 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppwj-0005Xg-3a; Tue, 01 Nov 2022 12:00:45 +0000 Received: from jgross by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oppwj-0005Rp-2T; Tue, 01 Nov 2022 12:00:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8973328-59dc-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=5J8Vh2XLLnRFL3tL5UuK6QowUl/ysp9mydg4XFdyJW4=; b=K5+AuxUM7txumEHhLAEnySAaNb RsFvMRDjQTMMvzl14PoRXTxBRADdxPf4AbBctNnRB75i+07DtAs96fRYBpV1cqDjfrgIZDPRccXSZ SeaO2ckv2Cp58DtfpHohybxkC/s63O61UjXa7wX9VUhSOAQH9aqNXzMvSxmQs0BwYFl4=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 416 v2 (CVE-2022-42319) - Xenstore: Guests can cause Xenstore to not free temporary memory Message-Id: Date: Tue, 01 Nov 2022 12:00:45 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-42319 / XSA-416 version 2 Xenstore: Guests can cause Xenstore to not free temporary memory UPDATES IN VERSION 2 ==================== Public release. ISSUE DESCRIPTION ================= When working on a request of a guest, xenstored might need to allocate quite large amounts of memory temporarily. This memory is freed only after the request has been finished completely. A request is regarded to be finished only after the guest has read the response message of the request from the ring page. Thus a guest not reading the response can cause xenstored to not free the temporary memory. This can result in memory shortages causing Denial of Service (DoS) of xenstored. IMPACT ====== A malicious guest can cause DoS of xenstored, resulting in the inability to create new guests or to change the configuration of already running guests. VULNERABLE SYSTEMS ================== Xen systems with version 4.9 and newer running the C variant of Xenstore (xenstored or xenstore-stubdom) are vulnerable. Systems using the Ocaml variant of Xenstore (oxenstored) are not vulnerable. MITIGATION ========== Using oxenstored instead of xenstored will avoid the vulnerability. CREDITS ======= This issue was discovered by Julien Grall of Amazon. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa416.patch xen-unstable xsa416-4.16.patch Xen 4.16.x xsa416-4.15.patch Xen 4.15.x xsa416-4.14.patch Xen 4.14.x xsa416-4.13.patch Xen 4.13.x $ sha256sum xsa416* 9f5f459b0c5b71ba25503d176c59732baf2ed174688b59e51010f22f8eecd218 xsa416.meta 6a28884392997baaea046ac8f1df86ffaec64febdabf17a8753e451ef3cab0f7 xsa416.patch 5838de576be5a71be46ab2e58287ea7d9c774f68f588c7d1f472a190b5923446 xsa416-4.13.patch cb06c57ff0158899e61b26901e06d931838f68958d610fbeff1c76edb9c8b4e1 xsa416-4.14.patch 68b7128b0f1e1d6de345dbc47dfdd583beff840c96e625fcf6e6a82679ff3732 xsa416-4.15.patch c4bb88546b272925d85d75d62f552d91698a10faaac1a0ce6cac3c54eeeda6a2 xsa416-4.16.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNg+6UMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZx0IH/0A0O9/AnlHpVEM8RUVrHqDLbVozGVbroH/OsA05 Fgj5kCqgRQs03H2uMnIboDL9RbgnjqRkU1cVf0gG2MWRzvMofxjLykUN8fUxcax0 6qCnAPF1m5kFA/LE6iyjWem6949n7B/LZb2NCJ9EFwb+W1/g6/skTj82ngvlSO+6 svxuK+BnTUshcDI6b3MSos4CPVpF4VMYB8JogUo9XANUdu7mblV4jMPn/wt712MA tEOcxeIPvzkYpPTzV5bEQGKmRy4WpnpSKDPDL8+PVFMFdyMartx98RoZFnldTmlN fifLfsTq3h3NxTA7V0KUXdO5tb0ZPLQiN/8fn7AwO/2HtdY= =YXaE -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa416.meta" Content-Disposition: attachment; filename="xsa416.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MTYsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIw YmU2M2MyNjE1YjI2ODAwMWY3Y2M5YjcyY2UyNWVlZDk1MjczN2RjIiwKICAg ICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICA0MTQsCiAgICAgICAg ICAgIDQxNSwKICAgICAgICAgICAgMzI2CiAgICAgICAgICBdLAogICAgICAg ICAgIlBhdGNoZXMiOiBbCiAgICAgICAgICAgICJ4c2E0MTYtNC4xMy5wYXRj aCIKICAgICAgICAgIF0KICAgICAgICB9CiAgICAgIH0KICAgIH0sCiAgICAi NC4xNCI6IHsKICAgICAgIlJlY2lwZXMiOiB7CiAgICAgICAgInhlbiI6IHsK ICAgICAgICAgICJTdGFibGVSZWYiOiAiMDE2ZGU2Mjc0N2IyNmVhZDVhNWM3 NjNiNjQwZmU4ZTIwNWNkMTgyYiIsCiAgICAgICAgICAiUHJlcmVxcyI6IFsK ICAgICAgICAgICAgNDE0LAogICAgICAgICAgICA0MTUsCiAgICAgICAgICAg IDMyNgogICAgICAgICAgXSwKICAgICAgICAgICJQYXRjaGVzIjogWwogICAg ICAgICAgICAieHNhNDE2LTQuMTQucGF0Y2giCiAgICAgICAgICBdCiAgICAg ICAgfQogICAgICB9CiAgICB9LAogICAgIjQuMTUiOiB7CiAgICAgICJSZWNp cGVzIjogewogICAgICAgICJ4ZW4iOiB7CiAgICAgICAgICAiU3RhYmxlUmVm IjogIjgxNjU4MGFmZGQxNzMwZDRmODVmNjQ0NzdhMjQyYTQzOWFmMWNkZjgi LAogICAgICAgICAgIlByZXJlcXMiOiBbCiAgICAgICAgICAgIDQxNCwKICAg ICAgICAgICAgNDE1LAogICAgICAgICAgICAzMjYKICAgICAgICAgIF0sCiAg ICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQxNi00LjE1 LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwK ICAgICI0LjE2IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVu IjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIxYmNlN2ZiMWY3MDJkYTRm N2E3NDljNmYxNDU3ZWNiMjBiZjc0ZmNhIiwKICAgICAgICAgICJQcmVyZXFz IjogWwogICAgICAgICAgICA0MTIsCiAgICAgICAgICAgIDQxNCwKICAgICAg ICAgICAgNDE1LAogICAgICAgICAgICAzMjYKICAgICAgICAgIF0sCiAgICAg ICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQxNi00LjE2LnBh dGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAg ICJtYXN0ZXIiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4i OiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogImNjNDc0N2JlOGJhMTU3YTNi MzEwOTIxZTllZTA3ZmI4NTQ1YWEyMDYiLAogICAgICAgICAgIlByZXJlcXMi OiBbCiAgICAgICAgICAgIDQxMiwKICAgICAgICAgICAgNDE0LAogICAgICAg ICAgICA0MTUsCiAgICAgICAgICAgIDMyNgogICAgICAgICAgXSwKICAgICAg ICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhNDE2LnBhdGNoIgog ICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfQogIH0KfQ== --=separator Content-Type: application/octet-stream; name="xsa416.patch" Content-Disposition: attachment; filename="xsa416.patch" Content-Transfer-Encoding: base64 RnJvbSBjNzYxYTMyZDFjYzliNDBhYzk1NjAwMjY4YmE1ZjAwYmJlYzg4OTI1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGRvbid0IHVz ZSBjb25uLT5pbiBhcyBjb250ZXh0IGZvciB0ZW1wb3JhcnkKIGFsbG9jYXRp b25zCgpVc2luZyB0aGUgc3RydWN0IGJ1ZmZlcmVkIGRhdGEgcG9pbnRlciBv ZiB0aGUgY3VycmVudCBwcm9jZXNzZWQgcmVxdWVzdApmb3IgdGVtcG9yYXJ5 IGRhdGEgYWxsb2NhdGlvbnMgaGFzIGEgbWFqb3IgZHJhd2JhY2s6IHRoZSB1 c2VkIGFyZWEgKGFuZAp3aXRoIHRoYXQgdGhlIHRlbXBvcmFyeSBkYXRhKSBp cyBmcmVlZCBvbmx5IGFmdGVyIHRoZSByZXNwb25zZSBvZiB0aGUKcmVxdWVz dCBoYXMgYmVlbiB3cml0dGVuIHRvIHRoZSByaW5nIHBhZ2Ugb3IgaGFzIGJl ZW4gcmVhZCB2aWEgdGhlCnNvY2tldC4gVGhpcyBjYW4gaGFwcGVuIG11Y2gg bGF0ZXIgaW4gY2FzZSBhIGd1ZXN0IGlzbid0IHJlYWRpbmcgaXRzCnJlc3Bv bnNlcyBmYXN0IGVub3VnaC4KCkFzIHRoZSB0ZW1wb3JhcnkgZGF0YSBjYW4g YmUgc2FmZWx5IGZyZWVkIGFmdGVyIGNyZWF0aW5nIHRoZSByZXNwb25zZSwK YWRkIGEgdGVtcG9yYXJ5IGNvbnRleHQgZm9yIHRoYXQgcHVycG9zZSBhbmQg dXNlIHRoYXQgZm9yIGFsbG9jYXRpbmcKdGhlIHRlbXBvcmFyeSBtZW1vcnks IGFzIGl0IHdhcyBhbHJlYWR5IHRoZSBjYXNlIGJlZm9yZSBjb21taXQKY2Mw NjEyNDY0ODk2ICgieGVuc3RvcmU6IGFkZCBzbWFsbCBkZWZhdWx0IGRhdGEg YnVmZmVyIHRvIGludGVybmFsCnN0cnVjdCIpLgoKU29tZSBzdWItZnVuY3Rp b25zIG5lZWQgdG8gZ2FpbiB0aGUgImNvbnN0IiBhdHRyaWJ1dGUgZm9yIHRo ZSB0YWxsb2MKY29udGV4dC4KClRoaXMgaXMgWFNBLTQxNiAvIENWRS0yMDIy LTQyMzE5LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+CkZpeGVzOiBjYzA2MTI0NjQ4OTYgKCJ4ZW5zdG9yZTogYWRk IHNtYWxsIGRlZmF1bHQgZGF0YSBidWZmZXIgdG8gaW50ZXJuYWwgc3RydWN0 IikKU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29udHJvbC5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wu YwppbmRleCAyNjRiYjM5ZDdiMGUuLmQxYWFhMDBiZjQ0YSAxMDA2NDQKLS0t IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuYworKysgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jCkBAIC0xNTUsNyAr MTU1LDcgQEAgYm9vbCBsdV9pc19wZW5kaW5nKHZvaWQpCiAKIHN0cnVjdCBj bWRfcyB7CiAJY2hhciAqY21kOwotCWludCAoKmZ1bmMpKHZvaWQgKiwgc3Ry dWN0IGNvbm5lY3Rpb24gKiwgY2hhciAqKiwgaW50KTsKKwlpbnQgKCpmdW5j KShjb25zdCB2b2lkICosIHN0cnVjdCBjb25uZWN0aW9uICosIGNoYXIgKios IGludCk7CiAJY2hhciAqcGFyczsKIAkvKgogCSAqIG1heF9wYXJzIGNhbiBi ZSB1c2VkIHRvIGxpbWl0IHRoZSBzaXplIG9mIHRoZSBwYXJhbWV0ZXIgdmVj dG9yLApAQCAtMTY3LDcgKzE2Nyw3IEBAIHN0cnVjdCBjbWRfcyB7CiAJdW5z aWduZWQgaW50IG1heF9wYXJzOwogfTsKIAotc3RhdGljIGludCBkb19jb250 cm9sX2NoZWNrKHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s CitzdGF0aWMgaW50IGRvX2NvbnRyb2xfY2hlY2soY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJCSAgICBjaGFyICoqdmVj LCBpbnQgbnVtKQogewogCWlmIChudW0pCkBAIC0xNzksNyArMTc5LDcgQEAg c3RhdGljIGludCBkb19jb250cm9sX2NoZWNrKHZvaWQgKmN0eCwgc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sCiAJcmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBp bnQgZG9fY29udHJvbF9sb2codm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwKK3N0YXRpYyBpbnQgZG9fY29udHJvbF9sb2coY29uc3Qgdm9p ZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJCSAgY2hhciAq KnZlYywgaW50IG51bSkKIHsKIAlpZiAobnVtICE9IDEpCkBAIC0yODEsNyAr MjgxLDcgQEAgc3RhdGljIGludCBxdW90YV9nZXQoY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAlyZXR1cm4gZG9tYWluX2dl dF9xdW90YShjdHgsIGNvbm4sIGF0b2kodmVjWzBdKSk7CiB9CiAKLXN0YXRp YyBpbnQgZG9fY29udHJvbF9xdW90YSh2b2lkICpjdHgsIHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLAorc3RhdGljIGludCBkb19jb250cm9sX3F1b3RhKGNv bnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQkg ICAgY2hhciAqKnZlYywgaW50IG51bSkKIHsKIAlpZiAobnVtID09IDApCkBA IC0yOTMsNyArMjkzLDcgQEAgc3RhdGljIGludCBkb19jb250cm9sX3F1b3Rh KHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJcmV0dXJu IHF1b3RhX2dldChjdHgsIGNvbm4sIHZlYywgbnVtKTsKIH0KIAotc3RhdGlj IGludCBkb19jb250cm9sX3F1b3RhX3Modm9pZCAqY3R4LCBzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwKK3N0YXRpYyBpbnQgZG9fY29udHJvbF9xdW90YV9z KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJ CQkgICAgICBjaGFyICoqdmVjLCBpbnQgbnVtKQogewogCWlmIChudW0gPT0g MCkKQEAgLTMwNiw3ICszMDYsNyBAQCBzdGF0aWMgaW50IGRvX2NvbnRyb2xf cXVvdGFfcyh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAog fQogCiAjaWZkZWYgX19NSU5JT1NfXwotc3RhdGljIGludCBkb19jb250cm9s X21lbXJlcG9ydCh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25u LAorc3RhdGljIGludCBkb19jb250cm9sX21lbXJlcG9ydChjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCQkJCWNoYXIgKip2 ZWMsIGludCBudW0pCiB7CiAJaWYgKG51bSkKQEAgLTMxOCw3ICszMTgsNyBA QCBzdGF0aWMgaW50IGRvX2NvbnRyb2xfbWVtcmVwb3J0KHZvaWQgKmN0eCwg c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJcmV0dXJuIDA7CiB9CiAjZWxz ZQotc3RhdGljIGludCBkb19jb250cm9sX2xvZ2ZpbGUodm9pZCAqY3R4LCBz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKK3N0YXRpYyBpbnQgZG9fY29udHJv bF9sb2dmaWxlKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sCiAJCQkgICAgICBjaGFyICoqdmVjLCBpbnQgbnVtKQogewogCWlm IChudW0gIT0gMSkKQEAgLTMzMyw3ICszMzMsNyBAQCBzdGF0aWMgaW50IGRv X2NvbnRyb2xfbG9nZmlsZSh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAogCXJldHVybiAwOwogfQogCi1zdGF0aWMgaW50IGRvX2NvbnRy b2xfbWVtcmVwb3J0KHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sCitzdGF0aWMgaW50IGRvX2NvbnRyb2xfbWVtcmVwb3J0KGNvbnN0IHZv aWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQkJY2hhciAq KnZlYywgaW50IG51bSkKIHsKIAlGSUxFICpmcDsKQEAgLTM3Myw3ICszNzMs NyBAQCBzdGF0aWMgaW50IGRvX2NvbnRyb2xfbWVtcmVwb3J0KHZvaWQgKmN0 eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiB9CiAjZW5kaWYKIAotc3Rh dGljIGludCBkb19jb250cm9sX3ByaW50KHZvaWQgKmN0eCwgc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCitzdGF0aWMgaW50IGRvX2NvbnRyb2xfcHJpbnQo Y29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJ CSAgICBjaGFyICoqdmVjLCBpbnQgbnVtKQogewogCWlmIChudW0gIT0gMSkK QEAgLTg3NSw3ICs4NzUsNyBAQCBzdGF0aWMgY29uc3QgY2hhciAqbHVfc3Rh cnQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwK IAlyZXR1cm4gTlVMTDsKIH0KIAotc3RhdGljIGludCBkb19jb250cm9sX2x1 KHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCitzdGF0aWMg aW50IGRvX2NvbnRyb2xfbHUoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwKIAkJCSBjaGFyICoqdmVjLCBpbnQgbnVtKQogewog CWNvbnN0IGNoYXIgKnJldCA9IE5VTEw7CkBAIC05MjIsNyArOTIyLDcgQEAg c3RhdGljIGludCBkb19jb250cm9sX2x1KHZvaWQgKmN0eCwgc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCiB9CiAjZW5kaWYKIAotc3RhdGljIGludCBkb19j b250cm9sX2hlbHAodm9pZCAqLCBzdHJ1Y3QgY29ubmVjdGlvbiAqLCBjaGFy ICoqLCBpbnQpOworc3RhdGljIGludCBkb19jb250cm9sX2hlbHAoY29uc3Qg dm9pZCAqLCBzdHJ1Y3QgY29ubmVjdGlvbiAqLCBjaGFyICoqLCBpbnQpOwog CiBzdGF0aWMgc3RydWN0IGNtZF9zIGNtZHNbXSA9IHsKIAl7ICJjaGVjayIs IGRvX2NvbnRyb2xfY2hlY2ssICIiIH0sCkBAIC05NjEsNyArOTYxLDcgQEAg c3RhdGljIHN0cnVjdCBjbWRfcyBjbWRzW10gPSB7CiAJeyAiaGVscCIsIGRv X2NvbnRyb2xfaGVscCwgIiIgfSwKIH07CiAKLXN0YXRpYyBpbnQgZG9fY29u dHJvbF9oZWxwKHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s CitzdGF0aWMgaW50IGRvX2NvbnRyb2xfaGVscChjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCQkJICAgY2hhciAqKnZlYywg aW50IG51bSkKIHsKIAlpbnQgY21kOwpAQCAtOTg0LDcgKzk4NCw4IEBAIHN0 YXRpYyBpbnQgZG9fY29udHJvbF9oZWxwKHZvaWQgKmN0eCwgc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCiAJcmV0dXJuIDA7CiB9CiAKLWludCBkb19jb250 cm9sKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRf ZGF0YSAqaW4pCitpbnQgZG9fY29udHJvbChjb25zdCB2b2lkICpjdHgsIHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLAorCSAgICAgICBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pCiB7CiAJdW5zaWduZWQgaW50IGNtZCwgbnVtLCBvZmY7 CiAJY2hhciAqKnZlYyA9IE5VTEw7CkBAIC0xMDA0LDExICsxMDA1LDExIEBA IGludCBkb19jb250cm9sKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJbnVtID0geHNfY291bnRfc3RyaW5n cyhpbi0+YnVmZmVyLCBpbi0+dXNlZCk7CiAJaWYgKGNtZHNbY21kXS5tYXhf cGFycykKIAkJbnVtID0gbWluKG51bSwgY21kc1tjbWRdLm1heF9wYXJzKTsK LQl2ZWMgPSB0YWxsb2NfYXJyYXkoaW4sIGNoYXIgKiwgbnVtKTsKKwl2ZWMg PSB0YWxsb2NfYXJyYXkoY3R4LCBjaGFyICosIG51bSk7CiAJaWYgKCF2ZWMp CiAJCXJldHVybiBFTk9NRU07CiAJaWYgKGdldF9zdHJpbmdzKGluLCB2ZWMs IG51bSkgPCBudW0pCiAJCXJldHVybiBFSU87CiAKLQlyZXR1cm4gY21kc1tj bWRdLmZ1bmMoaW4sIGNvbm4sIHZlYyArIDEsIG51bSAtIDEpOworCXJldHVy biBjbWRzW2NtZF0uZnVuYyhjdHgsIGNvbm4sIHZlYyArIDEsIG51bSAtIDEp OwogfQpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv bnRyb2wuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmgK aW5kZXggOThiNmZiY2VhMmIxLi5hOGNiNzY1NTliYTEgMTAwNjQ0Ci0tLSBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmgKKysrIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuaApAQCAtMTYsNyArMTYs OCBAQAogICAgIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtOyBJZiBub3QsIHNl ZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCiAqLwogCi1pbnQg ZG9fY29udHJvbChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKmluKTsKK2ludCBkb19jb250cm9sKGNvbnN0IHZvaWQg KmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJICAgICAgIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbik7CiB2b2lkIGx1X3JlYWRfc3RhdGUodm9p ZCk7CiAKIHN0cnVjdCBjb25uZWN0aW9uICpsdV9nZXRfY29ubmVjdGlvbih2 b2lkKTsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4 IGY3ZjFlMDBjNzE1Yi4uNjZiYmVhZjZiZmIwIDEwMDY0NAotLS0gYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTEyNDQsMTEgKzEyNDQsMTMgQEAg c3RhdGljIHN0cnVjdCBub2RlICpnZXRfbm9kZV9jYW5vbmljYWxpemVkKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLAogCXJldHVybiBnZXRfbm9kZShjb25u LCBjdHgsICpjYW5vbmljYWxfbmFtZSwgcGVybSk7CiB9CiAKLXN0YXRpYyBp bnQgc2VuZF9kaXJlY3Rvcnkoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBidWZmZXJlZF9kYXRhICppbikKK3N0YXRpYyBpbnQgc2VuZF9kaXJl Y3RvcnkoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwKKwkJCSAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCXN0cnVj dCBub2RlICpub2RlOwogCi0Jbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6 ZWQoY29ubiwgaW4sIG9uZWFyZyhpbiksIE5VTEwsIFhTX1BFUk1fUkVBRCk7 CisJbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgY3R4LCBv bmVhcmcoaW4pLCBOVUxMLAorCQkJCSAgICAgIFhTX1BFUk1fUkVBRCk7CiAJ aWYgKCFub2RlKQogCQlyZXR1cm4gZXJybm87CiAKQEAgLTEyNTcsNyArMTI1 OSw3IEBAIHN0YXRpYyBpbnQgc2VuZF9kaXJlY3Rvcnkoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlyZXR1 cm4gMDsKIH0KIAotc3RhdGljIGludCBzZW5kX2RpcmVjdG9yeV9wYXJ0KHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLAorc3RhdGljIGludCBzZW5kX2RpcmVj dG9yeV9wYXJ0KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sCiAJCQkgICAgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQog ewogCXVuc2lnbmVkIGludCBvZmYsIGxlbiwgbWF4bGVuLCBnZW5sZW47CkBA IC0xMjY5LDcgKzEyNzEsOCBAQCBzdGF0aWMgaW50IHNlbmRfZGlyZWN0b3J5 X3BhcnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCXJldHVybiBFSU5W QUw7CiAKIAkvKiBGaXJzdCBhcmcgaXMgbm9kZSBuYW1lLiAqLwotCW5vZGUg PSBnZXRfbm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGluLCBpbi0+YnVmZmVy LCBOVUxMLCBYU19QRVJNX1JFQUQpOworCW5vZGUgPSBnZXRfbm9kZV9jYW5v bmljYWxpemVkKGNvbm4sIGN0eCwgaW4tPmJ1ZmZlciwgTlVMTCwKKwkJCQkg ICAgICBYU19QRVJNX1JFQUQpOwogCWlmICghbm9kZSkKIAkJcmV0dXJuIGVy cm5vOwogCkBAIC0xMjk2LDcgKzEyOTksNyBAQCBzdGF0aWMgaW50IHNlbmRf ZGlyZWN0b3J5X3BhcnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQli cmVhazsKIAl9CiAKLQlkYXRhID0gdGFsbG9jX2FycmF5KGluLCBjaGFyLCBn ZW5sZW4gKyBsZW4gKyAxKTsKKwlkYXRhID0gdGFsbG9jX2FycmF5KGN0eCwg Y2hhciwgZ2VubGVuICsgbGVuICsgMSk7CiAJaWYgKCFkYXRhKQogCQlyZXR1 cm4gRU5PTUVNOwogCkBAIC0xMzEyLDExICsxMzE1LDEzIEBAIHN0YXRpYyBp bnQgc2VuZF9kaXJlY3RvcnlfcGFydChzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwKIAlyZXR1cm4gMDsKIH0KIAotc3RhdGljIGludCBkb19yZWFkKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CitzdGF0aWMgaW50IGRvX3JlYWQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKKwkJICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEg KmluKQogewogCXN0cnVjdCBub2RlICpub2RlOwogCi0Jbm9kZSA9IGdldF9u b2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgaW4sIG9uZWFyZyhpbiksIE5VTEws IFhTX1BFUk1fUkVBRCk7CisJbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6 ZWQoY29ubiwgY3R4LCBvbmVhcmcoaW4pLCBOVUxMLAorCQkJCSAgICAgIFhT X1BFUk1fUkVBRCk7CiAJaWYgKCFub2RlKQogCQlyZXR1cm4gZXJybm87CiAK QEAgLTE1MDYsNyArMTUxMSw4IEBAIHN0YXRpYyBzdHJ1Y3Qgbm9kZSAqY3Jl YXRlX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQg KmN0eCwKIH0KIAogLyogcGF0aCwgZGF0YS4uLiAqLwotc3RhdGljIGludCBk b193cml0ZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZl cmVkX2RhdGEgKmluKQorc3RhdGljIGludCBkb193cml0ZShjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgICAgc3RydWN0 IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCXVuc2lnbmVkIGludCBvZmZzZXQs IGRhdGFsZW47CiAJc3RydWN0IG5vZGUgKm5vZGU7CkBAIC0xNTIwLDEyICsx NTI2LDEyIEBAIHN0YXRpYyBpbnQgZG9fd3JpdGUoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlvZmZzZXQg PSBzdHJsZW4odmVjWzBdKSArIDE7CiAJZGF0YWxlbiA9IGluLT51c2VkIC0g b2Zmc2V0OwogCi0Jbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29u biwgaW4sIHZlY1swXSwgJm5hbWUsIFhTX1BFUk1fV1JJVEUpOworCW5vZGUg PSBnZXRfbm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGN0eCwgdmVjWzBdLCAm bmFtZSwgWFNfUEVSTV9XUklURSk7CiAJaWYgKCFub2RlKSB7CiAJCS8qIE5v IHBlcm1pc3Npb25zLCBpbnZhbGlkIGlucHV0PyAqLwogCQlpZiAoZXJybm8g IT0gRU5PRU5UKQogCQkJcmV0dXJuIGVycm5vOwotCQlub2RlID0gY3JlYXRl X25vZGUoY29ubiwgaW4sIG5hbWUsIGluLT5idWZmZXIgKyBvZmZzZXQsCisJ CW5vZGUgPSBjcmVhdGVfbm9kZShjb25uLCBjdHgsIG5hbWUsIGluLT5idWZm ZXIgKyBvZmZzZXQsCiAJCQkJICAgZGF0YWxlbik7CiAJCWlmICghbm9kZSkK IAkJCXJldHVybiBlcnJubzsKQEAgLTE1MzYsMTggKzE1NDIsMTkgQEAgc3Rh dGljIGludCBkb193cml0ZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCQkJcmV0dXJuIGVycm5vOwogCX0K IAotCWZpcmVfd2F0Y2hlcyhjb25uLCBpbiwgbmFtZSwgbm9kZSwgZmFsc2Us IE5VTEwpOworCWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5hbWUsIG5vZGUs IGZhbHNlLCBOVUxMKTsKIAlzZW5kX2Fjayhjb25uLCBYU19XUklURSk7CiAK IAlyZXR1cm4gMDsKIH0KIAotc3RhdGljIGludCBkb19ta2RpcihzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQor c3RhdGljIGludCBkb19ta2Rpcihjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBj b25uZWN0aW9uICpjb25uLAorCQkgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEg KmluKQogewogCXN0cnVjdCBub2RlICpub2RlOwogCWNoYXIgKm5hbWU7CiAK LQlub2RlID0gZ2V0X25vZGVfY2Fub25pY2FsaXplZChjb25uLCBpbiwgb25l YXJnKGluKSwgJm5hbWUsCisJbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6 ZWQoY29ubiwgY3R4LCBvbmVhcmcoaW4pLCAmbmFtZSwKIAkJCQkgICAgICBY U19QRVJNX1dSSVRFKTsKIAogCS8qIElmIGl0IGFscmVhZHkgZXhpc3RzLCBm aW5lLiAqLwpAQCAtMTU1NywxMCArMTU2NCwxMCBAQCBzdGF0aWMgaW50IGRv X21rZGlyKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pCiAJCQlyZXR1cm4gZXJybm87CiAJCWlmICghbmFtZSkK IAkJCXJldHVybiBFTk9NRU07Ci0JCW5vZGUgPSBjcmVhdGVfbm9kZShjb25u LCBpbiwgbmFtZSwgTlVMTCwgMCk7CisJCW5vZGUgPSBjcmVhdGVfbm9kZShj b25uLCBjdHgsIG5hbWUsIE5VTEwsIDApOwogCQlpZiAoIW5vZGUpCiAJCQly ZXR1cm4gZXJybm87Ci0JCWZpcmVfd2F0Y2hlcyhjb25uLCBpbiwgbmFtZSwg bm9kZSwgZmFsc2UsIE5VTEwpOworCQlmaXJlX3dhdGNoZXMoY29ubiwgY3R4 LCBuYW1lLCBub2RlLCBmYWxzZSwgTlVMTCk7CiAJfQogCXNlbmRfYWNrKGNv bm4sIFhTX01LRElSKTsKIApAQCAtMTY1OCwyNCArMTY2NSwyNSBAQCBzdGF0 aWMgaW50IF9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9p ZCAqY3R4LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIH0KIAogCi1zdGF0aWMgaW50 IGRvX3JtKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pCitzdGF0aWMgaW50IGRvX3JtKGNvbnN0IHZvaWQgKmN0 eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pCiB7CiAJc3RydWN0IG5vZGUgKm5vZGU7CiAJaW50IHJl dDsKIAljaGFyICpuYW1lOwogCWNoYXIgKnBhcmVudG5hbWU7CiAKLQlub2Rl ID0gZ2V0X25vZGVfY2Fub25pY2FsaXplZChjb25uLCBpbiwgb25lYXJnKGlu KSwgJm5hbWUsCisJbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29u biwgY3R4LCBvbmVhcmcoaW4pLCAmbmFtZSwKIAkJCQkgICAgICBYU19QRVJN X1dSSVRFKTsKIAlpZiAoIW5vZGUpIHsKIAkJLyogRGlkbid0IGV4aXN0IGFs cmVhZHk/ICBGaW5lLCBpZiBwYXJlbnQgZXhpc3RzLiAqLwogCQlpZiAoZXJy bm8gPT0gRU5PRU5UKSB7CiAJCQlpZiAoIW5hbWUpCiAJCQkJcmV0dXJuIEVO T01FTTsKLQkJCXBhcmVudG5hbWUgPSBnZXRfcGFyZW50KGluLCBuYW1lKTsK KwkJCXBhcmVudG5hbWUgPSBnZXRfcGFyZW50KGN0eCwgbmFtZSk7CiAJCQlp ZiAoIXBhcmVudG5hbWUpCiAJCQkJcmV0dXJuIGVycm5vOwotCQkJbm9kZSA9 IHJlYWRfbm9kZShjb25uLCBpbiwgcGFyZW50bmFtZSk7CisJCQlub2RlID0g cmVhZF9ub2RlKGNvbm4sIGN0eCwgcGFyZW50bmFtZSk7CiAJCQlpZiAobm9k ZSkgewogCQkJCXNlbmRfYWNrKGNvbm4sIFhTX1JNKTsKIAkJCQlyZXR1cm4g MDsKQEAgLTE2OTAsNyArMTY5OCw3IEBAIHN0YXRpYyBpbnQgZG9fcm0oc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICpp bikKIAlpZiAoc3RyZXEobmFtZSwgIi8iKSkKIAkJcmV0dXJuIEVJTlZBTDsK IAotCXJldCA9IF9ybShjb25uLCBpbiwgbm9kZSwgbmFtZSk7CisJcmV0ID0g X3JtKGNvbm4sIGN0eCwgbm9kZSwgbmFtZSk7CiAJaWYgKHJldCkKIAkJcmV0 dXJuIHJldDsKIApAQCAtMTcwMCwxMyArMTcwOCwxNSBAQCBzdGF0aWMgaW50 IGRvX3JtKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pCiB9CiAKIAotc3RhdGljIGludCBkb19nZXRfcGVybXMo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRh ICppbikKK3N0YXRpYyBpbnQgZG9fZ2V0X3Blcm1zKGNvbnN0IHZvaWQgKmN0 eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCQlzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pCiB7CiAJc3RydWN0IG5vZGUgKm5vZGU7CiAJY2hhciAq c3RyaW5nczsKIAl1bnNpZ25lZCBpbnQgbGVuOwogCi0Jbm9kZSA9IGdldF9u b2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgaW4sIG9uZWFyZyhpbiksIE5VTEws IFhTX1BFUk1fUkVBRCk7CisJbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6 ZWQoY29ubiwgY3R4LCBvbmVhcmcoaW4pLCBOVUxMLAorCQkJCSAgICAgIFhT X1BFUk1fUkVBRCk7CiAJaWYgKCFub2RlKQogCQlyZXR1cm4gZXJybm87CiAK QEAgLTE3MTksNyArMTcyOSw4IEBAIHN0YXRpYyBpbnQgZG9fZ2V0X3Blcm1z KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSAqaW4pCiAJcmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBpbnQgZG9fc2V0X3Bl cm1zKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRf ZGF0YSAqaW4pCitzdGF0aWMgaW50IGRvX3NldF9wZXJtcyhjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkJc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKmluKQogewogCXN0cnVjdCBub2RlX3Blcm1zIHBlcm1z LCBvbGRfcGVybXM7CiAJY2hhciAqbmFtZSwgKnBlcm1zdHI7CkBAIC0xNzM2 LDcgKzE3NDcsNyBAQCBzdGF0aWMgaW50IGRvX3NldF9wZXJtcyhzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQog CiAJcGVybXN0ciA9IGluLT5idWZmZXIgKyBzdHJsZW4oaW4tPmJ1ZmZlcikg KyAxOwogCi0JcGVybXMucCA9IHRhbGxvY19hcnJheShpbiwgc3RydWN0IHhz X3Blcm1pc3Npb25zLCBwZXJtcy5udW0pOworCXBlcm1zLnAgPSB0YWxsb2Nf YXJyYXkoY3R4LCBzdHJ1Y3QgeHNfcGVybWlzc2lvbnMsIHBlcm1zLm51bSk7 CiAJaWYgKCFwZXJtcy5wKQogCQlyZXR1cm4gRU5PTUVNOwogCWlmICgheHNf c3RyaW5nc190b19wZXJtcyhwZXJtcy5wLCBwZXJtcy5udW0sIHBlcm1zdHIp KQpAQCAtMTc1MSw3ICsxNzYyLDcgQEAgc3RhdGljIGludCBkb19zZXRfcGVy bXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbikKIAl9CiAKIAkvKiBXZSBtdXN0IG93biBub2RlIHRvIGRvIHRo aXMgKHRvb2xzIGNhbiBkbyB0aGlzIHRvbykuICovCi0Jbm9kZSA9IGdldF9u b2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgaW4sIGluLT5idWZmZXIsICZuYW1l LAorCW5vZGUgPSBnZXRfbm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGN0eCwg aW4tPmJ1ZmZlciwgJm5hbWUsCiAJCQkJICAgICAgWFNfUEVSTV9XUklURSB8 IFhTX1BFUk1fT1dORVIpOwogCWlmICghbm9kZSkKIAkJcmV0dXJuIGVycm5v OwpAQCAtMTc4Niw3ICsxNzk3LDcgQEAgc3RhdGljIGludCBkb19zZXRfcGVy bXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbikKIAkJcmV0dXJuIGVycm5vOwogCX0KIAotCWZpcmVfd2F0Y2hl cyhjb25uLCBpbiwgbmFtZSwgbm9kZSwgZmFsc2UsICZvbGRfcGVybXMpOwor CWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5hbWUsIG5vZGUsIGZhbHNlLCAm b2xkX3Blcm1zKTsKIAlzZW5kX2Fjayhjb25uLCBYU19TRVRfUEVSTVMpOwog CiAJcmV0dXJuIDA7CkBAIC0xNzk0LDcgKzE4MDUsOCBAQCBzdGF0aWMgaW50 IGRvX3NldF9wZXJtcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0 IGJ1ZmZlcmVkX2RhdGEgKmluKQogCiBzdGF0aWMgc3RydWN0IHsKIAljb25z dCBjaGFyICpzdHI7Ci0JaW50ICgqZnVuYykoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CisJaW50ICgqZnVu YykoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwK KwkJICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CiAJdW5zaWduZWQg aW50IGZsYWdzOwogI2RlZmluZSBYU19GTEFHX05PVElECQkoMVUgPDwgMCkJ LyogSWdub3JlIHRyYW5zYWN0aW9uIGlkLiAqLwogI2RlZmluZSBYU19GTEFH X1BSSVYJCSgxVSA8PCAxKQkvKiBQcml2aWxlZ2VkIGRvbWFpbiBvbmx5LiAq LwpAQCAtMTg0Nyw2ICsxODU5LDcgQEAgc3RhdGljIHZvaWQgcHJvY2Vzc19t ZXNzYWdlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pCiAJc3RydWN0IHRyYW5zYWN0aW9uICp0cmFuczsKIAll bnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSA9IGluLT5oZHIubXNnLnR5cGU7 CiAJaW50IHJldDsKKwl2b2lkICpjdHg7CiAKIAkvKiBBdCBsZWFzdCBzZW5k X2Vycm9yKCkgYW5kIHNlbmRfcmVwbHkoKSBleHBlY3RzIGNvbm4tPmluID09 IGluICovCiAJYXNzZXJ0KGNvbm4tPmluID09IGluKTsKQEAgLTE4NzEsMTAg KzE4ODQsMTcgQEAgc3RhdGljIHZvaWQgcHJvY2Vzc19tZXNzYWdlKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CiAJCXJldHVybjsKIAl9CiAKKwljdHggPSB0YWxsb2NfbmV3KE5VTEwpOwor CWlmICghY3R4KSB7CisJCXNlbmRfZXJyb3IoY29ubiwgRU5PTUVNKTsKKwkJ cmV0dXJuOworCX0KKwogCWFzc2VydChjb25uLT50cmFuc2FjdGlvbiA9PSBO VUxMKTsKIAljb25uLT50cmFuc2FjdGlvbiA9IHRyYW5zOwogCi0JcmV0ID0g d2lyZV9mdW5jc1t0eXBlXS5mdW5jKGNvbm4sIGluKTsKKwlyZXQgPSB3aXJl X2Z1bmNzW3R5cGVdLmZ1bmMoY3R4LCBjb25uLCBpbik7CisJdGFsbG9jX2Zy ZWUoY3R4KTsKIAlpZiAocmV0KQogCQlzZW5kX2Vycm9yKGNvbm4sIHJldCk7 CiAKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21h aW4uYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYwppbmRl eCA5ODNiMzQ4ZWU1OWMuLmI5ZmY0ZGVkODM2MCAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCisrKyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYwpAQCAtMzMwLDcgKzMzMCw3IEBA IGJvb2wgZG9tYWluX2lzX3VucHJpdmlsZWdlZChzdHJ1Y3QgY29ubmVjdGlv biAqY29ubikKIAkgICAgICAgZG9taWRfaXNfdW5wcml2aWxlZ2VkKGNvbm4t PmRvbWFpbi0+ZG9taWQpOwogfQogCi1zdGF0aWMgY2hhciAqdGFsbG9jX2Rv bWFpbl9wYXRoKHZvaWQgKmNvbnRleHQsIHVuc2lnbmVkIGludCBkb21pZCkK K3N0YXRpYyBjaGFyICp0YWxsb2NfZG9tYWluX3BhdGgoY29uc3Qgdm9pZCAq Y29udGV4dCwgdW5zaWduZWQgaW50IGRvbWlkKQogewogCXJldHVybiB0YWxs b2NfYXNwcmludGYoY29udGV4dCwgIi9sb2NhbC9kb21haW4vJXUiLCBkb21p ZCk7CiB9CkBAIC01NjYsNyArNTY2LDggQEAgc3RhdGljIHN0cnVjdCBkb21h aW4gKmludHJvZHVjZV9kb21haW4oY29uc3Qgdm9pZCAqY3R4LAogfQogCiAv KiBkb21pZCwgZ2ZuLCBldnRjaG4sIHBhdGggKi8KLWludCBkb19pbnRyb2R1 Y2Uoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbikKK2ludCBkb19pbnRyb2R1Y2UoY29uc3Qgdm9pZCAqY3R4LCBz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbikKIHsKIAlzdHJ1Y3QgZG9tYWluICpkb21haW47CiAJY2hhciAq dmVjWzNdOwpAQCAtNTg0LDcgKzU4NSw3IEBAIGludCBkb19pbnRyb2R1Y2Uo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRh ICppbikKIAlpZiAocG9ydCA8PSAwKQogCQlyZXR1cm4gRUlOVkFMOwogCi0J ZG9tYWluID0gaW50cm9kdWNlX2RvbWFpbihpbiwgZG9taWQsIHBvcnQsIGZh bHNlKTsKKwlkb21haW4gPSBpbnRyb2R1Y2VfZG9tYWluKGN0eCwgZG9taWQs IHBvcnQsIGZhbHNlKTsKIAlpZiAoIWRvbWFpbikKIAkJcmV0dXJuIGVycm5v OwogCkBAIC02MDcsNyArNjA4LDggQEAgc3RhdGljIHN0cnVjdCBkb21haW4g KmZpbmRfY29ubmVjdGVkX2RvbWFpbih1bnNpZ25lZCBpbnQgZG9taWQpCiAJ cmV0dXJuIGRvbWFpbjsKIH0KIAotaW50IGRvX3NldF90YXJnZXQoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikK K2ludCBkb19zZXRfdGFyZ2V0KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCisJCSAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmlu KQogewogCWNoYXIgKnZlY1syXTsKIAl1bnNpZ25lZCBpbnQgZG9taWQsIHRk b21pZDsKQEAgLTY1MSw3ICs2NTMsOCBAQCBzdGF0aWMgc3RydWN0IGRvbWFp biAqb25lYXJnX2RvbWFpbihzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIH0K IAogLyogZG9taWQgKi8KLWludCBkb19yZWxlYXNlKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitpbnQgZG9f cmVsZWFzZShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpj b25uLAorCSAgICAgICBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJ c3RydWN0IGRvbWFpbiAqZG9tYWluOwogCkBAIC02NjYsNyArNjY5LDggQEAg aW50IGRvX3JlbGVhc2Uoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbikKIAlyZXR1cm4gMDsKIH0KIAotaW50IGRv X3Jlc3VtZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZl cmVkX2RhdGEgKmluKQoraW50IGRvX3Jlc3VtZShjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCSAgICAgIHN0cnVjdCBidWZm ZXJlZF9kYXRhICppbikKIHsKIAlzdHJ1Y3QgZG9tYWluICpkb21haW47CiAK QEAgLTY4MSw3ICs2ODUsOCBAQCBpbnQgZG9fcmVzdW1lKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJcmV0 dXJuIDA7CiB9CiAKLWludCBkb19nZXRfZG9tYWluX3BhdGgoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKK2lu dCBkb19nZXRfZG9tYWluX3BhdGgoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKKwkJICAgICAgIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbikKIHsKIAljaGFyICpwYXRoOwogCWNvbnN0IGNoYXIgKmRvbWlk X3N0ciA9IG9uZWFyZyhpbik7CkBAIC02ODksMTggKzY5NCwxNyBAQCBpbnQg ZG9fZ2V0X2RvbWFpbl9wYXRoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJaWYgKCFkb21pZF9zdHIpCiAJ CXJldHVybiBFSU5WQUw7CiAKLQlwYXRoID0gdGFsbG9jX2RvbWFpbl9wYXRo KGNvbm4sIGF0b2koZG9taWRfc3RyKSk7CisJcGF0aCA9IHRhbGxvY19kb21h aW5fcGF0aChjdHgsIGF0b2koZG9taWRfc3RyKSk7CiAJaWYgKCFwYXRoKQog CQlyZXR1cm4gZXJybm87CiAKIAlzZW5kX3JlcGx5KGNvbm4sIFhTX0dFVF9E T01BSU5fUEFUSCwgcGF0aCwgc3RybGVuKHBhdGgpICsgMSk7CiAKLQl0YWxs b2NfZnJlZShwYXRoKTsKLQogCXJldHVybiAwOwogfQogCi1pbnQgZG9faXNf ZG9tYWluX2ludHJvZHVjZWQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBidWZmZXJlZF9kYXRhICppbikKK2ludCBkb19pc19kb21haW5faW50 cm9kdWNlZChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpj b25uLAorCQkJICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIHsKIAlp bnQgcmVzdWx0OwogCXVuc2lnbmVkIGludCBkb21pZDsKQEAgLTcyMSw3ICs3 MjUsOCBAQCBpbnQgZG9faXNfZG9tYWluX2ludHJvZHVjZWQoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIH0K IAogLyogQWxsb3cgZ3Vlc3QgdG8gcmVzZXQgYWxsIHdhdGNoZXMgKi8KLWlu dCBkb19yZXNldF93YXRjaGVzKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitpbnQgZG9fcmVzZXRfd2F0Y2hl cyhjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAor CQkgICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIHsKIAljb25uX2Rl bGV0ZV9hbGxfd2F0Y2hlcyhjb25uKTsKIAljb25uX2RlbGV0ZV9hbGxfdHJh bnNhY3Rpb25zKGNvbm4pOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2RvbWFpbi5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2RvbWFpbi5oCmluZGV4IDViODZhOTJlMWI1Yi4uMjA5NDQyMTkwOTExIDEw MDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgK KysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oCkBAIC0y NCwyNSArMjQsMzIgQEAgdm9pZCBoYW5kbGVfZXZlbnQodm9pZCk7CiB2b2lk IGNoZWNrX2RvbWFpbnModm9pZCk7CiAKIC8qIGRvbWlkLCBtZm4sIGV2ZW50 Y2huLCBwYXRoICovCi1pbnQgZG9faW50cm9kdWNlKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOworaW50IGRv X2ludHJvZHVjZShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAorCQkgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKIAogLyog ZG9taWQgKi8KLWludCBkb19pc19kb21haW5faW50cm9kdWNlZChzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsK K2ludCBkb19pc19kb21haW5faW50cm9kdWNlZChjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkJICAgIHN0cnVjdCBidWZm ZXJlZF9kYXRhICppbik7CiAKIC8qIGRvbWlkICovCi1pbnQgZG9fcmVsZWFz ZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2Rh dGEgKmluKTsKK2ludCBkb19yZWxlYXNlKGNvbnN0IHZvaWQgKmN0eCwgc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJICAgICAgIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbik7CiAKIC8qIGRvbWlkICovCi1pbnQgZG9fcmVzdW1lKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAq aW4pOworaW50IGRvX3Jlc3VtZShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBj b25uZWN0aW9uICpjb25uLAorCSAgICAgIHN0cnVjdCBidWZmZXJlZF9kYXRh ICppbik7CiAKIC8qIGRvbWlkLCB0YXJnZXQgKi8KLWludCBkb19zZXRfdGFy Z2V0KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRf ZGF0YSAqaW4pOworaW50IGRvX3NldF90YXJnZXQoY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pOwogCiAvKiBkb21pZCAqLwotaW50IGRvX2dldF9kb21h aW5fcGF0aChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZl cmVkX2RhdGEgKmluKTsKK2ludCBkb19nZXRfZG9tYWluX3BhdGgoY29uc3Qg dm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICAgICAg IHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CiAKIC8qIEFsbG93IGd1ZXN0 IHRvIHJlc2V0IGFsbCB3YXRjaGVzICovCi1pbnQgZG9fcmVzZXRfd2F0Y2hl cyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2Rh dGEgKmluKTsKK2ludCBkb19yZXNldF93YXRjaGVzKGNvbnN0IHZvaWQgKmN0 eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICAgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKmluKTsKIAogdm9pZCBkb21haW5faW5pdChpbnQgZXZ0 ZmQpOwogdm9pZCBkb20wX2luaXQodm9pZCk7CmRpZmYgLS1naXQgYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4IDI4Nzc0ODEz ZGU4My4uM2UzZWI0NzMyNmNjIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpAQCAtNDgxLDcgKzQ4MSw4IEBA IHN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnNhY3Rpb25fbG9va3VwKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCB1aW50MzJfdCBpZCkKIAlyZXR1cm4gRVJS X1BUUigtRU5PRU5UKTsKIH0KIAotaW50IGRvX3RyYW5zYWN0aW9uX3N0YXJ0 KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSAqaW4pCitpbnQgZG9fdHJhbnNhY3Rpb25fc3RhcnQoY29uc3Qgdm9pZCAq Y3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJCSBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqaW4pCiB7CiAJc3RydWN0IHRyYW5zYWN0aW9uICp0cmFu cywgKmV4aXN0czsKIAljaGFyIGlkX3N0clsyMF07CkBAIC00OTQsOCArNDk1 LDggQEAgaW50IGRvX3RyYW5zYWN0aW9uX3N0YXJ0KHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJICAgIGNv bm4tPnRyYW5zYWN0aW9uX3N0YXJ0ZWQgPiBxdW90YV9tYXhfdHJhbnNhY3Rp b24pCiAJCXJldHVybiBFTk9TUEM7CiAKLQkvKiBBdHRhY2ggdHJhbnNhY3Rp b24gdG8gaW5wdXQgZm9yIGF1dG9mcmVlIHVudGlsIGl0J3MgY29tcGxldGUg Ki8KLQl0cmFucyA9IHRhbGxvY196ZXJvKGluLCBzdHJ1Y3QgdHJhbnNhY3Rp b24pOworCS8qIEF0dGFjaCB0cmFuc2FjdGlvbiB0byBjdHggZm9yIGF1dG9m cmVlIHVudGlsIGl0J3MgY29tcGxldGUgKi8KKwl0cmFucyA9IHRhbGxvY196 ZXJvKGN0eCwgc3RydWN0IHRyYW5zYWN0aW9uKTsKIAlpZiAoIXRyYW5zKQog CQlyZXR1cm4gRU5PTUVNOwogCkBAIC01NDQsNyArNTQ1LDggQEAgc3RhdGlj IGludCB0cmFuc2FjdGlvbl9maXhfZG9tYWlucyhzdHJ1Y3QgdHJhbnNhY3Rp b24gKnRyYW5zLCBib29sIHVwZGF0ZSkKIAlyZXR1cm4gMDsKIH0KIAotaW50 IGRvX3RyYW5zYWN0aW9uX2VuZChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg c3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQoraW50IGRvX3RyYW5zYWN0aW9u X2VuZChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25u LAorCQkgICAgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCWNv bnN0IGNoYXIgKmFyZyA9IG9uZWFyZyhpbik7CiAJc3RydWN0IHRyYW5zYWN0 aW9uICp0cmFuczsKQEAgLTU2Miw4ICs1NjQsOCBAQCBpbnQgZG9fdHJhbnNh Y3Rpb25fZW5kKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqaW4pCiAJaWYgKCFjb25uLT50cmFuc2FjdGlvbl9zdGFy dGVkKQogCQljb25uLT50YV9zdGFydF90aW1lID0gMDsKIAotCS8qIEF0dGFj aCB0cmFuc2FjdGlvbiB0byBpbiBmb3IgYXV0by1jbGVhbnVwICovCi0JdGFs bG9jX3N0ZWFsKGluLCB0cmFucyk7CisJLyogQXR0YWNoIHRyYW5zYWN0aW9u IHRvIGN0eCBmb3IgYXV0by1jbGVhbnVwICovCisJdGFsbG9jX3N0ZWFsKGN0 eCwgdHJhbnMpOwogCiAJaWYgKHN0cmVxKGFyZywgIlQiKSkgewogCQlpZiAo dHJhbnMtPmZhaWwpCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfdHJhbnNhY3Rpb24uaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF90cmFuc2FjdGlvbi5oCmluZGV4IGUzY2JkNmIyMzA5NS4uMzlkN2Y4MWM1 MTI3IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJh bnNhY3Rpb24uaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJh bnNhY3Rpb24uaApAQCAtMjksOCArMjksMTAgQEAgc3RydWN0IHRyYW5zYWN0 aW9uOwogCiBleHRlcm4gdWludDY0X3QgZ2VuZXJhdGlvbjsKIAotaW50IGRv X3RyYW5zYWN0aW9uX3N0YXJ0KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqbm9kZSk7Ci1pbnQgZG9fdHJhbnNhY3Rp b25fZW5kKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pOworaW50IGRvX3RyYW5zYWN0aW9uX3N0YXJ0KGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCQkgc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKm5vZGUpOworaW50IGRvX3RyYW5zYWN0aW9u X2VuZChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25u LAorCQkgICAgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKIAogc3Ry dWN0IHRyYW5zYWN0aW9uICp0cmFuc2FjdGlvbl9sb29rdXAoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHVpbnQzMl90IGlkKTsKIApkaWZmIC0tZ2l0IGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmMgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfd2F0Y2guYwppbmRleCA4NTM2MmJjY2UzMTQuLjMx NmMwOGI3Zjc1NCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX3dhdGNoLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dh dGNoLmMKQEAgLTI0Myw3ICsyNDMsNyBAQCBzdGF0aWMgc3RydWN0IHdhdGNo ICphZGRfd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNoYXIgKnBh dGgsIGNoYXIgKnRva2VuLAogCXJldHVybiBOVUxMOwogfQogCi1pbnQgZG9f d2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbikKK2ludCBkb193YXRjaChjb25zdCB2b2lkICpjdHgsIHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAq aW4pCiB7CiAJc3RydWN0IHdhdGNoICp3YXRjaDsKIAljaGFyICp2ZWNbMl07 CkBAIC0yNTIsNyArMjUyLDcgQEAgaW50IGRvX3dhdGNoKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJaWYg KGdldF9zdHJpbmdzKGluLCB2ZWMsIEFSUkFZX1NJWkUodmVjKSkgIT0gQVJS QVlfU0laRSh2ZWMpKQogCQlyZXR1cm4gRUlOVkFMOwogCi0JZXJybm8gPSBj aGVja193YXRjaF9wYXRoKGNvbm4sIGluLCAmKHZlY1swXSksICZyZWxhdGl2 ZSk7CisJZXJybm8gPSBjaGVja193YXRjaF9wYXRoKGNvbm4sIGN0eCwgJih2 ZWNbMF0pLCAmcmVsYXRpdmUpOwogCWlmIChlcnJubykKIAkJcmV0dXJuIGVy cm5vOwogCkBAIC0yODMsNyArMjgzLDggQEAgaW50IGRvX3dhdGNoKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CiAJcmV0dXJuIDA7CiB9CiAKLWludCBkb191bndhdGNoKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitpbnQg ZG9fdW53YXRjaChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAorCSAgICAgICBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7 CiAJc3RydWN0IHdhdGNoICp3YXRjaDsKIAljaGFyICpub2RlLCAqdmVjWzJd OwpAQCAtMjkxLDcgKzI5Miw3IEBAIGludCBkb191bndhdGNoKHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJ aWYgKGdldF9zdHJpbmdzKGluLCB2ZWMsIEFSUkFZX1NJWkUodmVjKSkgIT0g QVJSQVlfU0laRSh2ZWMpKQogCQlyZXR1cm4gRUlOVkFMOwogCi0Jbm9kZSA9 IGNhbm9uaWNhbGl6ZShjb25uLCBpbiwgdmVjWzBdKTsKKwlub2RlID0gY2Fu b25pY2FsaXplKGNvbm4sIGN0eCwgdmVjWzBdKTsKIAlpZiAoIW5vZGUpCiAJ CXJldHVybiBFTk9NRU07CiAJbGlzdF9mb3JfZWFjaF9lbnRyeSh3YXRjaCwg JmNvbm4tPndhdGNoZXMsIGxpc3QpIHsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF93YXRjaC5oIGIvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX3dhdGNoLmgKaW5kZXggMGU2OTNmMDgzOWNkLi4wOTE4OTBlZGNh OTYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRj aC5oCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5oCkBA IC0yMSw4ICsyMSwxMCBAQAogCiAjaW5jbHVkZSAieGVuc3RvcmVkX2NvcmUu aCIKIAotaW50IGRvX3dhdGNoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOwotaW50IGRvX3Vud2F0Y2goc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICpp bik7CitpbnQgZG9fd2F0Y2goY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwKKwkgICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICpp bik7CitpbnQgZG9fdW53YXRjaChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBj b25uZWN0aW9uICpjb25uLAorCSAgICAgICBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSAqaW4pOwogCiAvKiBGaXJlIGFsbCB3YXRjaGVzOiAhZXhhY3QgbWVhbnMg YWxsIHRoZSBjaGlsZHJlbiBhcmUgYWZmZWN0ZWQgKGllLiBybSkuICovCiB2 b2lkIGZpcmVfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29u c3Qgdm9pZCAqdG1wLCBjb25zdCBjaGFyICpuYW1lLAo= --=separator Content-Type: application/octet-stream; name="xsa416-4.13.patch" Content-Disposition: attachment; filename="xsa416-4.13.patch" Content-Transfer-Encoding: base64 RnJvbSAxYTU4ZmZlZjk5M2ZlODZmZThhN2MxMzQ5ODgxNjUwZTliMGZlOGE3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGRvbid0IHVz ZSBjb25uLT5pbiBhcyBjb250ZXh0IGZvciB0ZW1wb3JhcnkKIGFsbG9jYXRp b25zCgpVc2luZyB0aGUgc3RydWN0IGJ1ZmZlcmVkIGRhdGEgcG9pbnRlciBv ZiB0aGUgY3VycmVudCBwcm9jZXNzZWQgcmVxdWVzdApmb3IgdGVtcG9yYXJ5 IGRhdGEgYWxsb2NhdGlvbnMgaGFzIGEgbWFqb3IgZHJhd2JhY2s6IHRoZSB1 c2VkIGFyZWEgKGFuZAp3aXRoIHRoYXQgdGhlIHRlbXBvcmFyeSBkYXRhKSBp cyBmcmVlZCBvbmx5IGFmdGVyIHRoZSByZXNwb25zZSBvZiB0aGUKcmVxdWVz dCBoYXMgYmVlbiB3cml0dGVuIHRvIHRoZSByaW5nIHBhZ2Ugb3IgaGFzIGJl ZW4gcmVhZCB2aWEgdGhlCnNvY2tldC4gVGhpcyBjYW4gaGFwcGVuIG11Y2gg bGF0ZXIgaW4gY2FzZSBhIGd1ZXN0IGlzbid0IHJlYWRpbmcgaXRzCnJlc3Bv bnNlcyBmYXN0IGVub3VnaC4KCkFzIHRoZSB0ZW1wb3JhcnkgZGF0YSBjYW4g YmUgc2FmZWx5IGZyZWVkIGFmdGVyIGNyZWF0aW5nIHRoZSByZXNwb25zZSwK YWRkIGEgdGVtcG9yYXJ5IGNvbnRleHQgZm9yIHRoYXQgcHVycG9zZSBhbmQg dXNlIHRoYXQgZm9yIGFsbG9jYXRpbmcKdGhlIHRlbXBvcmFyeSBtZW1vcnks IGFzIGl0IHdhcyBhbHJlYWR5IHRoZSBjYXNlIGJlZm9yZSBjb21taXQKY2Mw NjEyNDY0ODk2ICgieGVuc3RvcmU6IGFkZCBzbWFsbCBkZWZhdWx0IGRhdGEg YnVmZmVyIHRvIGludGVybmFsCnN0cnVjdCIpLgoKU29tZSBzdWItZnVuY3Rp b25zIG5lZWQgdG8gZ2FpbiB0aGUgImNvbnN0IiBhdHRyaWJ1dGUgZm9yIHRo ZSB0YWxsb2MKY29udGV4dC4KClRoaXMgaXMgWFNBLTQxNiAvIENWRS0yMDIy LTQyMzE5LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+CkZpeGVzOiBjYzA2MTI0NjQ4OTYgKCJ4ZW5zdG9yZTogYWRk IHNtYWxsIGRlZmF1bHQgZGF0YSBidWZmZXIgdG8gaW50ZXJuYWwgc3RydWN0 IikKU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29udHJvbC5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wu YwppbmRleCA0NTRmZTlkNWFiMTguLjM1ODVkN2M2OTUwZCAxMDA2NDQKLS0t IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuYworKysgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jCkBAIC0zMCwxMSAr MzAsMTEgQEAKIAogc3RydWN0IGNtZF9zIHsKIAljaGFyICpjbWQ7Ci0JaW50 ICgqZnVuYykodm9pZCAqLCBzdHJ1Y3QgY29ubmVjdGlvbiAqLCBjaGFyICoq LCBpbnQpOworCWludCAoKmZ1bmMpKGNvbnN0IHZvaWQgKiwgc3RydWN0IGNv bm5lY3Rpb24gKiwgY2hhciAqKiwgaW50KTsKIAljaGFyICpwYXJzOwogfTsK IAotc3RhdGljIGludCBkb19jb250cm9sX2NoZWNrKHZvaWQgKmN0eCwgc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sCitzdGF0aWMgaW50IGRvX2NvbnRyb2xf Y2hlY2soY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwKIAkJCSAgICBjaGFyICoqdmVjLCBpbnQgbnVtKQogewogCWlmIChudW0p CkBAIC00Niw3ICs0Niw3IEBAIHN0YXRpYyBpbnQgZG9fY29udHJvbF9jaGVj ayh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCXJldHVy biAwOwogfQogCi1zdGF0aWMgaW50IGRvX2NvbnRyb2xfbG9nKHZvaWQgKmN0 eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCitzdGF0aWMgaW50IGRvX2Nv bnRyb2xfbG9nKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sCiAJCQkgIGNoYXIgKip2ZWMsIGludCBudW0pCiB7CiAJaWYgKG51 bSAhPSAxKQpAQCAtNjMsNyArNjMsNyBAQCBzdGF0aWMgaW50IGRvX2NvbnRy b2xfbG9nKHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJ cmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBpbnQgZG9fY29udHJvbF9sb2dmaWxl KHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCitzdGF0aWMg aW50IGRvX2NvbnRyb2xfbG9nZmlsZShjb25zdCB2b2lkICpjdHgsIHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAogCQkJICAgICAgY2hhciAqKnZlYywgaW50 IG51bSkKIHsKIAlpZiAobnVtICE9IDEpCkBAIC0xNjIsNyArMTYyLDcgQEAg c3RhdGljIGludCBxdW90YV9nZXQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKIAlyZXR1cm4gZG9tYWluX2dldF9xdW90YShj dHgsIGNvbm4sIGF0b2kodmVjWzBdKSk7CiB9CiAKLXN0YXRpYyBpbnQgZG9f Y29udHJvbF9xdW90YSh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpj b25uLAorc3RhdGljIGludCBkb19jb250cm9sX3F1b3RhKGNvbnN0IHZvaWQg KmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQkgICAgY2hhciAq KnZlYywgaW50IG51bSkKIHsKIAlpZiAobnVtID09IDApCkBAIC0xNzQsNyAr MTc0LDcgQEAgc3RhdGljIGludCBkb19jb250cm9sX3F1b3RhKHZvaWQgKmN0 eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJcmV0dXJuIHF1b3RhX2dl dChjdHgsIGNvbm4sIHZlYywgbnVtKTsKIH0KIAotc3RhdGljIGludCBkb19j b250cm9sX3F1b3RhX3Modm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwKK3N0YXRpYyBpbnQgZG9fY29udHJvbF9xdW90YV9zKGNvbnN0IHZv aWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQkgICAgICBj aGFyICoqdmVjLCBpbnQgbnVtKQogewogCWlmIChudW0gPT0gMCkKQEAgLTE4 Niw3ICsxODYsNyBAQCBzdGF0aWMgaW50IGRvX2NvbnRyb2xfcXVvdGFfcyh2 b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCXJldHVybiBF SU5WQUw7CiB9CiAKLXN0YXRpYyBpbnQgZG9fY29udHJvbF9tZW1yZXBvcnQo dm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKK3N0YXRpYyBp bnQgZG9fY29udHJvbF9tZW1yZXBvcnQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJCQljaGFyICoqdmVjLCBpbnQgbnVt KQogewogCUZJTEUgKmZwOwpAQCAtMjI1LDcgKzIyNSw3IEBAIHN0YXRpYyBp bnQgZG9fY29udHJvbF9tZW1yZXBvcnQodm9pZCAqY3R4LCBzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwKIAlyZXR1cm4gMDsKIH0KIAotc3RhdGljIGludCBk b19jb250cm9sX3ByaW50KHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sCitzdGF0aWMgaW50IGRvX2NvbnRyb2xfcHJpbnQoY29uc3Qgdm9p ZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJCSAgICBjaGFy ICoqdmVjLCBpbnQgbnVtKQogewogCWlmIChudW0gIT0gMSkKQEAgLTIzNyw3 ICsyMzcsNyBAQCBzdGF0aWMgaW50IGRvX2NvbnRyb2xfcHJpbnQodm9pZCAq Y3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAlyZXR1cm4gMDsKIH0K IAotc3RhdGljIGludCBkb19jb250cm9sX2hlbHAodm9pZCAqLCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqLCBjaGFyICoqLCBpbnQpOworc3RhdGljIGludCBkb19j b250cm9sX2hlbHAoY29uc3Qgdm9pZCAqLCBzdHJ1Y3QgY29ubmVjdGlvbiAq LCBjaGFyICoqLCBpbnQpOwogCiBzdGF0aWMgc3RydWN0IGNtZF9zIGNtZHNb XSA9IHsKIAl7ICJjaGVjayIsIGRvX2NvbnRyb2xfY2hlY2ssICIiIH0sCkBA IC0yNTAsNyArMjUwLDcgQEAgc3RhdGljIHN0cnVjdCBjbWRfcyBjbWRzW10g PSB7CiAJeyAiaGVscCIsIGRvX2NvbnRyb2xfaGVscCwgIiIgfSwKIH07CiAK LXN0YXRpYyBpbnQgZG9fY29udHJvbF9oZWxwKHZvaWQgKmN0eCwgc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sCitzdGF0aWMgaW50IGRvX2NvbnRyb2xfaGVs cChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAog CQkJICAgY2hhciAqKnZlYywgaW50IG51bSkKIHsKIAlpbnQgY21kLCBsZW4g PSAwOwpAQCAtMjg2LDcgKzI4Niw4IEBAIHN0YXRpYyBpbnQgZG9fY29udHJv bF9oZWxwKHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJ cmV0dXJuIDA7CiB9CiAKLWludCBkb19jb250cm9sKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitpbnQgZG9f Y29udHJvbChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpj b25uLAorCSAgICAgICBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJ aW50IG51bTsKIAlpbnQgY21kOwpAQCAtMjk4LDcgKzI5OSw3IEBAIGludCBk b19jb250cm9sKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqaW4pCiAJbnVtID0geHNfY291bnRfc3RyaW5ncyhpbi0+ YnVmZmVyLCBpbi0+dXNlZCk7CiAJaWYgKG51bSA8IDEpCiAJCXJldHVybiBF SU5WQUw7Ci0JdmVjID0gdGFsbG9jX2FycmF5KGluLCBjaGFyICosIG51bSk7 CisJdmVjID0gdGFsbG9jX2FycmF5KGN0eCwgY2hhciAqLCBudW0pOwogCWlm ICghdmVjKQogCQlyZXR1cm4gRU5PTUVNOwogCWlmIChnZXRfc3RyaW5ncyhp biwgdmVjLCBudW0pICE9IG51bSkKQEAgLTMwNiw3ICszMDcsNyBAQCBpbnQg ZG9fY29udHJvbChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKmluKQogCiAJZm9yIChjbWQgPSAwOyBjbWQgPCBBUlJB WV9TSVpFKGNtZHMpOyBjbWQrKykKIAkJaWYgKHN0cmVxKHZlY1swXSwgY21k c1tjbWRdLmNtZCkpCi0JCQlyZXR1cm4gY21kc1tjbWRdLmZ1bmMoaW4sIGNv bm4sIHZlYyArIDEsIG51bSAtIDEpOworCQkJcmV0dXJuIGNtZHNbY21kXS5m dW5jKGN0eCwgY29ubiwgdmVjICsgMSwgbnVtIC0gMSk7CiAKIAlyZXR1cm4g RUlOVkFMOwogfQpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvbnRyb2wuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250 cm9sLmgKaW5kZXggMjA3ZTBhNmZhMzUyLi5mYWE5NTU5NjhkYjEgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmgKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuaApAQCAtMTYs NCArMTYsNSBAQAogICAgIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtOyBJZiBu b3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCiAqLwog Ci1pbnQgZG9fY29udHJvbChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKK2ludCBkb19jb250cm9sKGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJICAgICAg IHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CmRpZmYgLS1naXQgYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2NvcmUuYwppbmRleCAyYzBmOGZkOTliYmQuLmQ2YmJiNTMy ZmIxOCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCkBA IC0xMTQ1LDExICsxMTQ1LDEzIEBAIHN0YXRpYyBzdHJ1Y3Qgbm9kZSAqZ2V0 X25vZGVfY2Fub25pY2FsaXplZChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwK IAlyZXR1cm4gZ2V0X25vZGUoY29ubiwgY3R4LCAqY2Fub25pY2FsX25hbWUs IHBlcm0pOwogfQogCi1zdGF0aWMgaW50IHNlbmRfZGlyZWN0b3J5KHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CitzdGF0aWMgaW50IHNlbmRfZGlyZWN0b3J5KGNvbnN0IHZvaWQgKmN0eCwg c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCQkgIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbikKIHsKIAlzdHJ1Y3Qgbm9kZSAqbm9kZTsKIAotCW5vZGUg PSBnZXRfbm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGluLCBvbmVhcmcoaW4p LCBOVUxMLCBYU19QRVJNX1JFQUQpOworCW5vZGUgPSBnZXRfbm9kZV9jYW5v bmljYWxpemVkKGNvbm4sIGN0eCwgb25lYXJnKGluKSwgTlVMTCwKKwkJCQkg ICAgICBYU19QRVJNX1JFQUQpOwogCWlmICghbm9kZSkKIAkJcmV0dXJuIGVy cm5vOwogCkBAIC0xMTU4LDcgKzExNjAsNyBAQCBzdGF0aWMgaW50IHNlbmRf ZGlyZWN0b3J5KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqaW4pCiAJcmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBpbnQg c2VuZF9kaXJlY3RvcnlfcGFydChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwK K3N0YXRpYyBpbnQgc2VuZF9kaXJlY3RvcnlfcGFydChjb25zdCB2b2lkICpj dHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCQkJICAgICAgIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbikKIHsKIAl1bnNpZ25lZCBpbnQgb2ZmLCBs ZW4sIG1heGxlbiwgZ2VubGVuOwpAQCAtMTE3MCw3ICsxMTcyLDggQEAgc3Rh dGljIGludCBzZW5kX2RpcmVjdG9yeV9wYXJ0KHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAogCQlyZXR1cm4gRUlOVkFMOwogCiAJLyogRmlyc3QgYXJnIGlz IG5vZGUgbmFtZS4gKi8KLQlub2RlID0gZ2V0X25vZGVfY2Fub25pY2FsaXpl ZChjb25uLCBpbiwgaW4tPmJ1ZmZlciwgTlVMTCwgWFNfUEVSTV9SRUFEKTsK Kwlub2RlID0gZ2V0X25vZGVfY2Fub25pY2FsaXplZChjb25uLCBjdHgsIGlu LT5idWZmZXIsIE5VTEwsCisJCQkJICAgICAgWFNfUEVSTV9SRUFEKTsKIAlp ZiAoIW5vZGUpCiAJCXJldHVybiBlcnJubzsKIApAQCAtMTE5Nyw3ICsxMjAw LDcgQEAgc3RhdGljIGludCBzZW5kX2RpcmVjdG9yeV9wYXJ0KHN0cnVjdCBj b25uZWN0aW9uICpjb25uLAogCQkJYnJlYWs7CiAJfQogCi0JZGF0YSA9IHRh bGxvY19hcnJheShpbiwgY2hhciwgZ2VubGVuICsgbGVuICsgMSk7CisJZGF0 YSA9IHRhbGxvY19hcnJheShjdHgsIGNoYXIsIGdlbmxlbiArIGxlbiArIDEp OwogCWlmICghZGF0YSkKIAkJcmV0dXJuIEVOT01FTTsKIApAQCAtMTIxMywx MSArMTIxNiwxMyBAQCBzdGF0aWMgaW50IHNlbmRfZGlyZWN0b3J5X3BhcnQo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJcmV0dXJuIDA7CiB9CiAKLXN0 YXRpYyBpbnQgZG9fcmVhZChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQorc3RhdGljIGludCBkb19yZWFkKGNv bnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAg IHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIHsKIAlzdHJ1Y3Qgbm9kZSAq bm9kZTsKIAotCW5vZGUgPSBnZXRfbm9kZV9jYW5vbmljYWxpemVkKGNvbm4s IGluLCBvbmVhcmcoaW4pLCBOVUxMLCBYU19QRVJNX1JFQUQpOworCW5vZGUg PSBnZXRfbm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGN0eCwgb25lYXJnKGlu KSwgTlVMTCwKKwkJCQkgICAgICBYU19QRVJNX1JFQUQpOwogCWlmICghbm9k ZSkKIAkJcmV0dXJuIGVycm5vOwogCkBAIC0xMzk3LDcgKzE0MDIsOCBAQCBz dGF0aWMgc3RydWN0IG5vZGUgKmNyZWF0ZV9ub2RlKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsCiB9CiAKIC8qIHBhdGgsIGRh dGEuLi4gKi8KLXN0YXRpYyBpbnQgZG9fd3JpdGUoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKK3N0YXRpYyBp bnQgZG9fd3JpdGUoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwKKwkJICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIHsK IAl1bnNpZ25lZCBpbnQgb2Zmc2V0LCBkYXRhbGVuOwogCXN0cnVjdCBub2Rl ICpub2RlOwpAQCAtMTQxMSwxMiArMTQxNywxMiBAQCBzdGF0aWMgaW50IGRv X3dyaXRlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pCiAJb2Zmc2V0ID0gc3RybGVuKHZlY1swXSkgKyAxOwog CWRhdGFsZW4gPSBpbi0+dXNlZCAtIG9mZnNldDsKIAotCW5vZGUgPSBnZXRf bm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGluLCB2ZWNbMF0sICZuYW1lLCBY U19QRVJNX1dSSVRFKTsKKwlub2RlID0gZ2V0X25vZGVfY2Fub25pY2FsaXpl ZChjb25uLCBjdHgsIHZlY1swXSwgJm5hbWUsIFhTX1BFUk1fV1JJVEUpOwog CWlmICghbm9kZSkgewogCQkvKiBObyBwZXJtaXNzaW9ucywgaW52YWxpZCBp bnB1dD8gKi8KIAkJaWYgKGVycm5vICE9IEVOT0VOVCkKIAkJCXJldHVybiBl cnJubzsKLQkJbm9kZSA9IGNyZWF0ZV9ub2RlKGNvbm4sIGluLCBuYW1lLCBp bi0+YnVmZmVyICsgb2Zmc2V0LAorCQlub2RlID0gY3JlYXRlX25vZGUoY29u biwgY3R4LCBuYW1lLCBpbi0+YnVmZmVyICsgb2Zmc2V0LAogCQkJCSAgIGRh dGFsZW4pOwogCQlpZiAoIW5vZGUpCiAJCQlyZXR1cm4gZXJybm87CkBAIC0x NDI3LDE4ICsxNDMzLDE5IEBAIHN0YXRpYyBpbnQgZG9fd3JpdGUoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikK IAkJCXJldHVybiBlcnJubzsKIAl9CiAKLQlmaXJlX3dhdGNoZXMoY29ubiwg aW4sIG5hbWUsIG5vZGUsIGZhbHNlLCBOVUxMKTsKKwlmaXJlX3dhdGNoZXMo Y29ubiwgY3R4LCBuYW1lLCBub2RlLCBmYWxzZSwgTlVMTCk7CiAJc2VuZF9h Y2soY29ubiwgWFNfV1JJVEUpOwogCiAJcmV0dXJuIDA7CiB9CiAKLXN0YXRp YyBpbnQgZG9fbWtkaXIoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbikKK3N0YXRpYyBpbnQgZG9fbWtkaXIoY29u c3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICAg IHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIHsKIAlzdHJ1Y3Qgbm9kZSAq bm9kZTsKIAljaGFyICpuYW1lOwogCi0Jbm9kZSA9IGdldF9ub2RlX2Nhbm9u aWNhbGl6ZWQoY29ubiwgaW4sIG9uZWFyZyhpbiksICZuYW1lLAorCW5vZGUg PSBnZXRfbm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGN0eCwgb25lYXJnKGlu KSwgJm5hbWUsCiAJCQkJICAgICAgWFNfUEVSTV9XUklURSk7CiAKIAkvKiBJ ZiBpdCBhbHJlYWR5IGV4aXN0cywgZmluZS4gKi8KQEAgLTE0NDYsMTAgKzE0 NTMsMTAgQEAgc3RhdGljIGludCBkb19ta2RpcihzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCQkvKiBObyBw ZXJtaXNzaW9ucz8gKi8KIAkJaWYgKGVycm5vICE9IEVOT0VOVCkKIAkJCXJl dHVybiBlcnJubzsKLQkJbm9kZSA9IGNyZWF0ZV9ub2RlKGNvbm4sIGluLCBu YW1lLCBOVUxMLCAwKTsKKwkJbm9kZSA9IGNyZWF0ZV9ub2RlKGNvbm4sIGN0 eCwgbmFtZSwgTlVMTCwgMCk7CiAJCWlmICghbm9kZSkKIAkJCXJldHVybiBl cnJubzsKLQkJZmlyZV93YXRjaGVzKGNvbm4sIGluLCBuYW1lLCBub2RlLCBm YWxzZSwgTlVMTCk7CisJCWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5hbWUs IG5vZGUsIGZhbHNlLCBOVUxMKTsKIAl9CiAJc2VuZF9hY2soY29ubiwgWFNf TUtESVIpOwogCkBAIC0xNTQ3LDIyICsxNTU0LDIzIEBAIHN0YXRpYyBpbnQg X3JtKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBub2RlICpub2RlLAogfQogCiAKLXN0YXRpYyBpbnQgZG9fcm0o c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRh ICppbikKK3N0YXRpYyBpbnQgZG9fcm0oY29uc3Qgdm9pZCAqY3R4LCBzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJIHN0cnVjdCBidWZmZXJlZF9kYXRh ICppbikKIHsKIAlzdHJ1Y3Qgbm9kZSAqbm9kZTsKIAlpbnQgcmV0OwogCWNo YXIgKm5hbWU7CiAJY2hhciAqcGFyZW50bmFtZTsKIAotCW5vZGUgPSBnZXRf bm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGluLCBvbmVhcmcoaW4pLCAmbmFt ZSwKKwlub2RlID0gZ2V0X25vZGVfY2Fub25pY2FsaXplZChjb25uLCBjdHgs IG9uZWFyZyhpbiksICZuYW1lLAogCQkJCSAgICAgIFhTX1BFUk1fV1JJVEUp OwogCWlmICghbm9kZSkgewogCQkvKiBEaWRuJ3QgZXhpc3QgYWxyZWFkeT8g IEZpbmUsIGlmIHBhcmVudCBleGlzdHMuICovCiAJCWlmIChlcnJubyA9PSBF Tk9FTlQpIHsKLQkJCXBhcmVudG5hbWUgPSBnZXRfcGFyZW50KGluLCBuYW1l KTsKKwkJCXBhcmVudG5hbWUgPSBnZXRfcGFyZW50KGN0eCwgbmFtZSk7CiAJ CQlpZiAoIXBhcmVudG5hbWUpCiAJCQkJcmV0dXJuIGVycm5vOwotCQkJbm9k ZSA9IHJlYWRfbm9kZShjb25uLCBpbiwgcGFyZW50bmFtZSk7CisJCQlub2Rl ID0gcmVhZF9ub2RlKGNvbm4sIGN0eCwgcGFyZW50bmFtZSk7CiAJCQlpZiAo bm9kZSkgewogCQkJCXNlbmRfYWNrKGNvbm4sIFhTX1JNKTsKIAkJCQlyZXR1 cm4gMDsKQEAgLTE1NzcsNyArMTU4NSw3IEBAIHN0YXRpYyBpbnQgZG9fcm0o c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRh ICppbikKIAlpZiAoc3RyZXEobmFtZSwgIi8iKSkKIAkJcmV0dXJuIEVJTlZB TDsKIAotCXJldCA9IF9ybShjb25uLCBpbiwgbm9kZSwgbmFtZSk7CisJcmV0 ID0gX3JtKGNvbm4sIGN0eCwgbm9kZSwgbmFtZSk7CiAJaWYgKHJldCkKIAkJ cmV0dXJuIHJldDsKIApAQCAtMTU4NywxMyArMTU5NSwxNSBAQCBzdGF0aWMg aW50IGRvX3JtKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqaW4pCiB9CiAKIAotc3RhdGljIGludCBkb19nZXRfcGVy bXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbikKK3N0YXRpYyBpbnQgZG9fZ2V0X3Blcm1zKGNvbnN0IHZvaWQg KmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCQlzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqaW4pCiB7CiAJc3RydWN0IG5vZGUgKm5vZGU7CiAJY2hh ciAqc3RyaW5nczsKIAl1bnNpZ25lZCBpbnQgbGVuOwogCi0Jbm9kZSA9IGdl dF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgaW4sIG9uZWFyZyhpbiksIE5V TEwsIFhTX1BFUk1fUkVBRCk7CisJbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNh bGl6ZWQoY29ubiwgY3R4LCBvbmVhcmcoaW4pLCBOVUxMLAorCQkJCSAgICAg IFhTX1BFUk1fUkVBRCk7CiAJaWYgKCFub2RlKQogCQlyZXR1cm4gZXJybm87 CiAKQEAgLTE2MDYsNyArMTYxNiw4IEBAIHN0YXRpYyBpbnQgZG9fZ2V0X3Bl cm1zKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRf ZGF0YSAqaW4pCiAJcmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBpbnQgZG9fc2V0 X3Blcm1zKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pCitzdGF0aWMgaW50IGRvX3NldF9wZXJtcyhjb25zdCB2 b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkJc3RydWN0 IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCXN0cnVjdCBub2RlX3Blcm1zIHBl cm1zLCBvbGRfcGVybXM7CiAJY2hhciAqbmFtZSwgKnBlcm1zdHI7CkBAIC0x NjIzLDcgKzE2MzQsNyBAQCBzdGF0aWMgaW50IGRvX3NldF9wZXJtcyhzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmlu KQogCiAJcGVybXN0ciA9IGluLT5idWZmZXIgKyBzdHJsZW4oaW4tPmJ1ZmZl cikgKyAxOwogCi0JcGVybXMucCA9IHRhbGxvY19hcnJheShpbiwgc3RydWN0 IHhzX3Blcm1pc3Npb25zLCBwZXJtcy5udW0pOworCXBlcm1zLnAgPSB0YWxs b2NfYXJyYXkoY3R4LCBzdHJ1Y3QgeHNfcGVybWlzc2lvbnMsIHBlcm1zLm51 bSk7CiAJaWYgKCFwZXJtcy5wKQogCQlyZXR1cm4gRU5PTUVNOwogCWlmICgh eHNfc3RyaW5nc190b19wZXJtcyhwZXJtcy5wLCBwZXJtcy5udW0sIHBlcm1z dHIpKQpAQCAtMTYzOCw3ICsxNjQ5LDcgQEAgc3RhdGljIGludCBkb19zZXRf cGVybXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbikKIAl9CiAKIAkvKiBXZSBtdXN0IG93biBub2RlIHRvIGRv IHRoaXMgKHRvb2xzIGNhbiBkbyB0aGlzIHRvbykuICovCi0Jbm9kZSA9IGdl dF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgaW4sIGluLT5idWZmZXIsICZu YW1lLAorCW5vZGUgPSBnZXRfbm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGN0 eCwgaW4tPmJ1ZmZlciwgJm5hbWUsCiAJCQkJICAgICAgWFNfUEVSTV9XUklU RSB8IFhTX1BFUk1fT1dORVIpOwogCWlmICghbm9kZSkKIAkJcmV0dXJuIGVy cm5vOwpAQCAtMTY3Myw3ICsxNjg0LDcgQEAgc3RhdGljIGludCBkb19zZXRf cGVybXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbikKIAkJcmV0dXJuIGVycm5vOwogCX0KIAotCWZpcmVfd2F0 Y2hlcyhjb25uLCBpbiwgbmFtZSwgbm9kZSwgZmFsc2UsICZvbGRfcGVybXMp OworCWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5hbWUsIG5vZGUsIGZhbHNl LCAmb2xkX3Blcm1zKTsKIAlzZW5kX2Fjayhjb25uLCBYU19TRVRfUEVSTVMp OwogCiAJcmV0dXJuIDA7CkBAIC0xNjgxLDcgKzE2OTIsOCBAQCBzdGF0aWMg aW50IGRvX3NldF9wZXJtcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCiBzdGF0aWMgc3RydWN0IHsKIAlj b25zdCBjaGFyICpzdHI7Ci0JaW50ICgqZnVuYykoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CisJaW50ICgq ZnVuYykoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwKKwkJICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CiAJdW5zaWdu ZWQgaW50IGZsYWdzOwogI2RlZmluZSBYU19GTEFHX05PVElECQkoMVUgPDwg MCkJLyogSWdub3JlIHRyYW5zYWN0aW9uIGlkLiAqLwogI2RlZmluZSBYU19G TEFHX1BSSVYJCSgxVSA8PCAxKQkvKiBQcml2aWxlZ2VkIGRvbWFpbiBvbmx5 LiAqLwpAQCAtMTc1NCw2ICsxNzY2LDcgQEAgc3RhdGljIHZvaWQgcHJvY2Vz c19tZXNzYWdlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqaW4pCiAJc3RydWN0IHRyYW5zYWN0aW9uICp0cmFuczsK IAllbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSA9IGluLT5oZHIubXNnLnR5 cGU7CiAJaW50IHJldDsKKwl2b2lkICpjdHg7CiAKIAlpZiAoKHVuc2lnbmVk IGludCl0eXBlID49IFhTX1RZUEVfQ09VTlQgfHwgIXdpcmVfZnVuY3NbdHlw ZV0uZnVuYykgewogCQllcHJpbnRmKCJDbGllbnQgdW5rbm93biBvcGVyYXRp b24gJWkiLCB0eXBlKTsKQEAgLTE3NzQsMTAgKzE3ODcsMTcgQEAgc3RhdGlj IHZvaWQgcHJvY2Vzc19tZXNzYWdlKHN0cnVjdCBjb25uZWN0aW9uICpjb25u LCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJCXJldHVybjsKIAl9CiAK KwljdHggPSB0YWxsb2NfbmV3KE5VTEwpOworCWlmICghY3R4KSB7CisJCXNl bmRfZXJyb3IoY29ubiwgRU5PTUVNKTsKKwkJcmV0dXJuOworCX0KKwogCWFz c2VydChjb25uLT50cmFuc2FjdGlvbiA9PSBOVUxMKTsKIAljb25uLT50cmFu c2FjdGlvbiA9IHRyYW5zOwogCi0JcmV0ID0gd2lyZV9mdW5jc1t0eXBlXS5m dW5jKGNvbm4sIGluKTsKKwlyZXQgPSB3aXJlX2Z1bmNzW3R5cGVdLmZ1bmMo Y3R4LCBjb25uLCBpbik7CisJdGFsbG9jX2ZyZWUoY3R4KTsKIAlpZiAocmV0 KQogCQlzZW5kX2Vycm9yKGNvbm4sIHJldCk7CiAKZGlmZiAtLWdpdCBhL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYyBiL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9kb21haW4uYwppbmRleCBmNDU4MzE0YzhlMDEuLjA0 YmRmNTE3OTIyNyAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2RvbWFpbi5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9k b21haW4uYwpAQCAtMzM3LDcgKzMzNyw3IEBAIGJvb2wgZG9tYWluX2Nhbl93 cml0ZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubikKIAlyZXR1cm4gKChpbnRm LT5yc3BfcHJvZCAtIGludGYtPnJzcF9jb25zKSAhPSBYRU5TVE9SRV9SSU5H X1NJWkUpOwogfQogCi1zdGF0aWMgY2hhciAqdGFsbG9jX2RvbWFpbl9wYXRo KHZvaWQgKmNvbnRleHQsIHVuc2lnbmVkIGludCBkb21pZCkKK3N0YXRpYyBj aGFyICp0YWxsb2NfZG9tYWluX3BhdGgoY29uc3Qgdm9pZCAqY29udGV4dCwg dW5zaWduZWQgaW50IGRvbWlkKQogewogCXJldHVybiB0YWxsb2NfYXNwcmlu dGYoY29udGV4dCwgIi9sb2NhbC9kb21haW4vJXUiLCBkb21pZCk7CiB9CkBA IC00NzksNyArNDc5LDggQEAgc3RhdGljIHZvaWQgZG9tYWluX2Nvbm5fcmVz ZXQoc3RydWN0IGRvbWFpbiAqZG9tYWluKQogfQogCiAvKiBkb21pZCwgbWZu LCBldnRjaG4sIHBhdGggKi8KLWludCBkb19pbnRyb2R1Y2Uoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKK2lu dCBkb19pbnRyb2R1Y2UoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwKKwkJIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIHsK IAlzdHJ1Y3QgZG9tYWluICpkb21haW47CiAJY2hhciAqdmVjWzNdOwpAQCAt NTYzLDcgKzU2NCw4IEBAIHN0YXRpYyBzdHJ1Y3QgZG9tYWluICpmaW5kX2Nv bm5lY3RlZF9kb21haW4odW5zaWduZWQgaW50IGRvbWlkKQogCXJldHVybiBk b21haW47CiB9CiAKLWludCBkb19zZXRfdGFyZ2V0KHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitpbnQgZG9f c2V0X3RhcmdldChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAorCQkgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIHsKIAlj aGFyICp2ZWNbMl07CiAJdW5zaWduZWQgaW50IGRvbWlkLCB0ZG9taWQ7CkBA IC02MTAsNyArNjEyLDggQEAgc3RhdGljIHN0cnVjdCBkb21haW4gKm9uZWFy Z19kb21haW4oc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiB9CiAKIC8qIGRv bWlkICovCi1pbnQgZG9fcmVsZWFzZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQoraW50IGRvX3JlbGVhc2Uo Y29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkg ICAgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCXN0cnVjdCBk b21haW4gKmRvbWFpbjsKIApAQCAtNjI1LDcgKzYyOCw4IEBAIGludCBkb19y ZWxlYXNlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pCiAJcmV0dXJuIDA7CiB9CiAKLWludCBkb19yZXN1bWUo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRh ICppbikKK2ludCBkb19yZXN1bWUoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKKwkgICAgICBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSAqaW4pCiB7CiAJc3RydWN0IGRvbWFpbiAqZG9tYWluOwogCkBAIC02NDAs NyArNjQ0LDggQEAgaW50IGRvX3Jlc3VtZShzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCXJldHVybiAwOwog fQogCi1pbnQgZG9fZ2V0X2RvbWFpbl9wYXRoKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitpbnQgZG9fZ2V0 X2RvbWFpbl9wYXRoKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sCisJCSAgICAgICBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CiB7CiAJY2hhciAqcGF0aDsKIAljb25zdCBjaGFyICpkb21pZF9zdHIgPSBv bmVhcmcoaW4pOwpAQCAtNjQ4LDE4ICs2NTMsMTcgQEAgaW50IGRvX2dldF9k b21haW5fcGF0aChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKmluKQogCWlmICghZG9taWRfc3RyKQogCQlyZXR1cm4g RUlOVkFMOwogCi0JcGF0aCA9IHRhbGxvY19kb21haW5fcGF0aChjb25uLCBh dG9pKGRvbWlkX3N0cikpOworCXBhdGggPSB0YWxsb2NfZG9tYWluX3BhdGgo Y3R4LCBhdG9pKGRvbWlkX3N0cikpOwogCWlmICghcGF0aCkKIAkJcmV0dXJu IGVycm5vOwogCiAJc2VuZF9yZXBseShjb25uLCBYU19HRVRfRE9NQUlOX1BB VEgsIHBhdGgsIHN0cmxlbihwYXRoKSArIDEpOwogCi0JdGFsbG9jX2ZyZWUo cGF0aCk7Ci0KIAlyZXR1cm4gMDsKIH0KIAotaW50IGRvX2lzX2RvbWFpbl9p bnRyb2R1Y2VkKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqaW4pCitpbnQgZG9faXNfZG9tYWluX2ludHJvZHVjZWQo Y29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJ CSAgICBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJaW50IHJlc3Vs dDsKIAl1bnNpZ25lZCBpbnQgZG9taWQ7CkBAIC02ODAsNyArNjg0LDggQEAg aW50IGRvX2lzX2RvbWFpbl9pbnRyb2R1Y2VkKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB9CiAKIC8qIEFs bG93IGd1ZXN0IHRvIHJlc2V0IGFsbCB3YXRjaGVzICovCi1pbnQgZG9fcmVz ZXRfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKmluKQoraW50IGRvX3Jlc2V0X3dhdGNoZXMoY29uc3Qg dm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICAgICBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJY29ubl9kZWxldGVfYWxs X3dhdGNoZXMoY29ubik7CiAJY29ubl9kZWxldGVfYWxsX3RyYW5zYWN0aW9u cyhjb25uKTsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9kb21haW4uaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4u aAppbmRleCBlMDEzYTk5OTFjYTguLjczMmViOGZhNzVlMSAxMDA2NDQKLS0t IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oCisrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaApAQCAtMjIsMjUgKzIy LDMyIEBACiB2b2lkIGhhbmRsZV9ldmVudCh2b2lkKTsKIAogLyogZG9taWQs IG1mbiwgZXZlbnRjaG4sIHBhdGggKi8KLWludCBkb19pbnRyb2R1Y2Uoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICpp bik7CitpbnQgZG9faW50cm9kdWNlKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sCisJCSBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAq aW4pOwogCiAvKiBkb21pZCAqLwotaW50IGRvX2lzX2RvbWFpbl9pbnRyb2R1 Y2VkKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRf ZGF0YSAqaW4pOworaW50IGRvX2lzX2RvbWFpbl9pbnRyb2R1Y2VkKGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCQkgICAg c3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKIAogLyogZG9taWQgKi8KLWlu dCBkb19yZWxlYXNlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qg YnVmZmVyZWRfZGF0YSAqaW4pOworaW50IGRvX3JlbGVhc2UoY29uc3Qgdm9p ZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkgICAgICAgc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKIAogLyogZG9taWQgKi8KLWludCBk b19yZXN1bWUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZm ZXJlZF9kYXRhICppbik7CitpbnQgZG9fcmVzdW1lKGNvbnN0IHZvaWQgKmN0 eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJICAgICAgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKmluKTsKIAogLyogZG9taWQsIHRhcmdldCAqLwotaW50 IGRvX3NldF90YXJnZXQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbik7CitpbnQgZG9fc2V0X3RhcmdldChjb25z dCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgIHN0 cnVjdCBidWZmZXJlZF9kYXRhICppbik7CiAKIC8qIGRvbWlkICovCi1pbnQg ZG9fZ2V0X2RvbWFpbl9wYXRoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOworaW50IGRvX2dldF9kb21haW5f cGF0aChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25u LAorCQkgICAgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKIAogLyog QWxsb3cgZ3Vlc3QgdG8gcmVzZXQgYWxsIHdhdGNoZXMgKi8KLWludCBkb19y ZXNldF93YXRjaGVzKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qg YnVmZmVyZWRfZGF0YSAqaW4pOworaW50IGRvX3Jlc2V0X3dhdGNoZXMoY29u c3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICAg ICBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOwogCiB2b2lkIGRvbWFpbl9p bml0KHZvaWQpOwogCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF90cmFuc2FjdGlvbi5jCmluZGV4IDZlMjkxMThjODAwZC4uY2Q1OTI4NDVl N2NhIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJh bnNhY3Rpb24uYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJh bnNhY3Rpb24uYwpAQCAtNDg3LDcgKzQ4Nyw4IEBAIHN0cnVjdCB0cmFuc2Fj dGlvbiAqdHJhbnNhY3Rpb25fbG9va3VwKHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCB1aW50MzJfdCBpZCkKIAlyZXR1cm4gRVJSX1BUUigtRU5PRU5UKTsK IH0KIAotaW50IGRvX3RyYW5zYWN0aW9uX3N0YXJ0KHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitpbnQgZG9f dHJhbnNhY3Rpb25fc3RhcnQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwKKwkJCSBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CiB7CiAJc3RydWN0IHRyYW5zYWN0aW9uICp0cmFucywgKmV4aXN0czsKIAlj aGFyIGlkX3N0clsyMF07CkBAIC01MDAsOCArNTAxLDggQEAgaW50IGRvX3Ry YW5zYWN0aW9uX3N0YXJ0KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJICAgIGNvbm4tPnRyYW5zYWN0aW9u X3N0YXJ0ZWQgPiBxdW90YV9tYXhfdHJhbnNhY3Rpb24pCiAJCXJldHVybiBF Tk9TUEM7CiAKLQkvKiBBdHRhY2ggdHJhbnNhY3Rpb24gdG8gaW5wdXQgZm9y IGF1dG9mcmVlIHVudGlsIGl0J3MgY29tcGxldGUgKi8KLQl0cmFucyA9IHRh bGxvY196ZXJvKGluLCBzdHJ1Y3QgdHJhbnNhY3Rpb24pOworCS8qIEF0dGFj aCB0cmFuc2FjdGlvbiB0byBjdHggZm9yIGF1dG9mcmVlIHVudGlsIGl0J3Mg Y29tcGxldGUgKi8KKwl0cmFucyA9IHRhbGxvY196ZXJvKGN0eCwgc3RydWN0 IHRyYW5zYWN0aW9uKTsKIAlpZiAoIXRyYW5zKQogCQlyZXR1cm4gRU5PTUVN OwogCkBAIC01NDgsNyArNTQ5LDggQEAgc3RhdGljIGludCB0cmFuc2FjdGlv bl9maXhfZG9tYWlucyhzdHJ1Y3QgdHJhbnNhY3Rpb24gKnRyYW5zLCBib29s IHVwZGF0ZSkKIAlyZXR1cm4gMDsKIH0KIAotaW50IGRvX3RyYW5zYWN0aW9u X2VuZChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVk X2RhdGEgKmluKQoraW50IGRvX3RyYW5zYWN0aW9uX2VuZChjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgICAgICAgc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCWNvbnN0IGNoYXIgKmFyZyA9 IG9uZWFyZyhpbik7CiAJc3RydWN0IHRyYW5zYWN0aW9uICp0cmFuczsKQEAg LTU2NCw4ICs1NjYsOCBAQCBpbnQgZG9fdHJhbnNhY3Rpb25fZW5kKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CiAJbGlzdF9kZWwoJnRyYW5zLT5saXN0KTsKIAljb25uLT50cmFuc2FjdGlv bl9zdGFydGVkLS07CiAKLQkvKiBBdHRhY2ggdHJhbnNhY3Rpb24gdG8gaW4g Zm9yIGF1dG8tY2xlYW51cCAqLwotCXRhbGxvY19zdGVhbChpbiwgdHJhbnMp OworCS8qIEF0dGFjaCB0cmFuc2FjdGlvbiB0byBjdHggZm9yIGF1dG8tY2xl YW51cCAqLworCXRhbGxvY19zdGVhbChjdHgsIHRyYW5zKTsKIAogCWlmIChz dHJlcShhcmcsICJUIikpIHsKIAkJaWYgKHRyYW5zLT5mYWlsKQpkaWZmIC0t Z2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uaAppbmRl eCBlM2NiZDZiMjMwOTUuLjM5ZDdmODFjNTEyNyAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKKysrIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKQEAgLTI5LDgg KzI5LDEwIEBAIHN0cnVjdCB0cmFuc2FjdGlvbjsKIAogZXh0ZXJuIHVpbnQ2 NF90IGdlbmVyYXRpb247CiAKLWludCBkb190cmFuc2FjdGlvbl9zdGFydChz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEg Km5vZGUpOwotaW50IGRvX3RyYW5zYWN0aW9uX2VuZChzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKK2ludCBk b190cmFuc2FjdGlvbl9zdGFydChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBj b25uZWN0aW9uICpjb25uLAorCQkJIHN0cnVjdCBidWZmZXJlZF9kYXRhICpu b2RlKTsKK2ludCBkb190cmFuc2FjdGlvbl9lbmQoY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICAgICAgIHN0cnVjdCBi dWZmZXJlZF9kYXRhICppbik7CiAKIHN0cnVjdCB0cmFuc2FjdGlvbiAqdHJh bnNhY3Rpb25fbG9va3VwKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCB1aW50 MzJfdCBpZCk7CiAKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF93YXRjaC5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNo LmMKaW5kZXggMTlkMGZiMDFiMWM0Li4xMzYyN2NlOTcyNjYgMTAwNjQ0Ci0t LSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCisrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCkBAIC0xODQsNyArMTg0 LDcgQEAgc3RhdGljIGludCBkZXN0cm95X3dhdGNoKHZvaWQgKl93YXRjaCkK IAlyZXR1cm4gMDsKIH0KIAotaW50IGRvX3dhdGNoKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitpbnQgZG9f d2F0Y2goY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCXN0cnVjdCB3YXRj aCAqd2F0Y2g7CiAJY2hhciAqdmVjWzJdOwpAQCAtMjAwLDcgKzIwMCw3IEBA IGludCBkb193YXRjaChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0 IGJ1ZmZlcmVkX2RhdGEgKmluKQogCQkvKiBjaGVjayBpZiB2YWxpZCBldmVu dCAqLwogCX0gZWxzZSB7CiAJCXJlbGF0aXZlID0gIXN0cnN0YXJ0cyh2ZWNb MF0sICIvIik7Ci0JCXZlY1swXSA9IGNhbm9uaWNhbGl6ZShjb25uLCBpbiwg dmVjWzBdKTsKKwkJdmVjWzBdID0gY2Fub25pY2FsaXplKGNvbm4sIGN0eCwg dmVjWzBdKTsKIAkJaWYgKCF2ZWNbMF0pCiAJCQlyZXR1cm4gRU5PTUVNOwog CQlpZiAoIWlzX3ZhbGlkX25vZGVuYW1lKHZlY1swXSkpCkBAIC0yNTAsNyAr MjUwLDggQEAgaW50IGRvX3dhdGNoKHN0cnVjdCBjb25uZWN0aW9uICpjb25u LCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJcmV0dXJuIDA7CiB9CiAK LWludCBkb191bndhdGNoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitpbnQgZG9fdW53YXRjaChjb25zdCB2 b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCSAgICAgICBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJc3RydWN0IHdhdGNoICp3 YXRjaDsKIAljaGFyICpub2RlLCAqdmVjWzJdOwpAQCAtMjU4LDcgKzI1OSw3 IEBAIGludCBkb191bndhdGNoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJaWYgKGdldF9zdHJpbmdzKGlu LCB2ZWMsIEFSUkFZX1NJWkUodmVjKSkgIT0gQVJSQVlfU0laRSh2ZWMpKQog CQlyZXR1cm4gRUlOVkFMOwogCi0Jbm9kZSA9IGNhbm9uaWNhbGl6ZShjb25u LCBpbiwgdmVjWzBdKTsKKwlub2RlID0gY2Fub25pY2FsaXplKGNvbm4sIGN0 eCwgdmVjWzBdKTsKIAlpZiAoIW5vZGUpCiAJCXJldHVybiBFTk9NRU07CiAJ bGlzdF9mb3JfZWFjaF9lbnRyeSh3YXRjaCwgJmNvbm4tPndhdGNoZXMsIGxp c3QpIHsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93 YXRjaC5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmgKaW5k ZXggMDMwOTQzNzRmMzc5Li40MDQ1NWRmZjVkMmIgMTAwNjQ0Ci0tLSBhL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5oCisrKyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF93YXRjaC5oCkBAIC0yMSw4ICsyMSwxMCBAQAog CiAjaW5jbHVkZSAieGVuc3RvcmVkX2NvcmUuaCIKIAotaW50IGRvX3dhdGNo KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSAqaW4pOwotaW50IGRvX3Vud2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CitpbnQgZG9fd2F0Y2go Y29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkg ICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CitpbnQgZG9fdW53YXRj aChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAor CSAgICAgICBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOwogCiAvKiBGaXJl IGFsbCB3YXRjaGVzOiAhZXhhY3QgbWVhbnMgYWxsIHRoZSBjaGlsZHJlbiBh cmUgYWZmZWN0ZWQgKGllLiBybSkuICovCiB2b2lkIGZpcmVfd2F0Y2hlcyhz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqdG1wLCBjb25z dCBjaGFyICpuYW1lLAo= --=separator Content-Type: application/octet-stream; name="xsa416-4.14.patch" Content-Disposition: attachment; filename="xsa416-4.14.patch" Content-Transfer-Encoding: base64 RnJvbSAzZmMxNDc4YWQ0NWEzM2RlMDU4ZGJhOTI1NWE3NjcyZjgwYTZjYmRk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGRvbid0IHVz ZSBjb25uLT5pbiBhcyBjb250ZXh0IGZvciB0ZW1wb3JhcnkKIGFsbG9jYXRp b25zCgpVc2luZyB0aGUgc3RydWN0IGJ1ZmZlcmVkIGRhdGEgcG9pbnRlciBv ZiB0aGUgY3VycmVudCBwcm9jZXNzZWQgcmVxdWVzdApmb3IgdGVtcG9yYXJ5 IGRhdGEgYWxsb2NhdGlvbnMgaGFzIGEgbWFqb3IgZHJhd2JhY2s6IHRoZSB1 c2VkIGFyZWEgKGFuZAp3aXRoIHRoYXQgdGhlIHRlbXBvcmFyeSBkYXRhKSBp cyBmcmVlZCBvbmx5IGFmdGVyIHRoZSByZXNwb25zZSBvZiB0aGUKcmVxdWVz dCBoYXMgYmVlbiB3cml0dGVuIHRvIHRoZSByaW5nIHBhZ2Ugb3IgaGFzIGJl ZW4gcmVhZCB2aWEgdGhlCnNvY2tldC4gVGhpcyBjYW4gaGFwcGVuIG11Y2gg bGF0ZXIgaW4gY2FzZSBhIGd1ZXN0IGlzbid0IHJlYWRpbmcgaXRzCnJlc3Bv bnNlcyBmYXN0IGVub3VnaC4KCkFzIHRoZSB0ZW1wb3JhcnkgZGF0YSBjYW4g YmUgc2FmZWx5IGZyZWVkIGFmdGVyIGNyZWF0aW5nIHRoZSByZXNwb25zZSwK YWRkIGEgdGVtcG9yYXJ5IGNvbnRleHQgZm9yIHRoYXQgcHVycG9zZSBhbmQg dXNlIHRoYXQgZm9yIGFsbG9jYXRpbmcKdGhlIHRlbXBvcmFyeSBtZW1vcnks IGFzIGl0IHdhcyBhbHJlYWR5IHRoZSBjYXNlIGJlZm9yZSBjb21taXQKY2Mw NjEyNDY0ODk2ICgieGVuc3RvcmU6IGFkZCBzbWFsbCBkZWZhdWx0IGRhdGEg YnVmZmVyIHRvIGludGVybmFsCnN0cnVjdCIpLgoKU29tZSBzdWItZnVuY3Rp b25zIG5lZWQgdG8gZ2FpbiB0aGUgImNvbnN0IiBhdHRyaWJ1dGUgZm9yIHRo ZSB0YWxsb2MKY29udGV4dC4KClRoaXMgaXMgWFNBLTQxNiAvIENWRS0yMDIy LTQyMzE5LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+CkZpeGVzOiBjYzA2MTI0NjQ4OTYgKCJ4ZW5zdG9yZTogYWRk IHNtYWxsIGRlZmF1bHQgZGF0YSBidWZmZXIgdG8gaW50ZXJuYWwgc3RydWN0 IikKU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29udHJvbC5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wu YwppbmRleCAwMjI3YTU1NjU2NTcuLjA1ZTM4ZTU3NmEzZCAxMDA2NDQKLS0t IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuYworKysgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jCkBAIC0zMCwxMSAr MzAsMTEgQEAKIAogc3RydWN0IGNtZF9zIHsKIAljaGFyICpjbWQ7Ci0JaW50 ICgqZnVuYykodm9pZCAqLCBzdHJ1Y3QgY29ubmVjdGlvbiAqLCBjaGFyICoq LCBpbnQpOworCWludCAoKmZ1bmMpKGNvbnN0IHZvaWQgKiwgc3RydWN0IGNv bm5lY3Rpb24gKiwgY2hhciAqKiwgaW50KTsKIAljaGFyICpwYXJzOwogfTsK IAotc3RhdGljIGludCBkb19jb250cm9sX2NoZWNrKHZvaWQgKmN0eCwgc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sCitzdGF0aWMgaW50IGRvX2NvbnRyb2xf Y2hlY2soY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwKIAkJCSAgICBjaGFyICoqdmVjLCBpbnQgbnVtKQogewogCWlmIChudW0p CkBAIC00Niw3ICs0Niw3IEBAIHN0YXRpYyBpbnQgZG9fY29udHJvbF9jaGVj ayh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCXJldHVy biAwOwogfQogCi1zdGF0aWMgaW50IGRvX2NvbnRyb2xfbG9nKHZvaWQgKmN0 eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCitzdGF0aWMgaW50IGRvX2Nv bnRyb2xfbG9nKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sCiAJCQkgIGNoYXIgKip2ZWMsIGludCBudW0pCiB7CiAJaWYgKG51 bSAhPSAxKQpAQCAtMTQ3LDcgKzE0Nyw3IEBAIHN0YXRpYyBpbnQgcXVvdGFf Z2V0KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s CiAJcmV0dXJuIGRvbWFpbl9nZXRfcXVvdGEoY3R4LCBjb25uLCBhdG9pKHZl Y1swXSkpOwogfQogCi1zdGF0aWMgaW50IGRvX2NvbnRyb2xfcXVvdGEodm9p ZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKK3N0YXRpYyBpbnQg ZG9fY29udHJvbF9xdW90YShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLAogCQkJICAgIGNoYXIgKip2ZWMsIGludCBudW0pCiB7 CiAJaWYgKG51bSA9PSAwKQpAQCAtMTU5LDcgKzE1OSw3IEBAIHN0YXRpYyBp bnQgZG9fY29udHJvbF9xdW90YSh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLAogCXJldHVybiBxdW90YV9nZXQoY3R4LCBjb25uLCB2ZWMs IG51bSk7CiB9CiAKLXN0YXRpYyBpbnQgZG9fY29udHJvbF9xdW90YV9zKHZv aWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCitzdGF0aWMgaW50 IGRvX2NvbnRyb2xfcXVvdGFfcyhjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBj b25uZWN0aW9uICpjb25uLAogCQkJICAgICAgY2hhciAqKnZlYywgaW50IG51 bSkKIHsKIAlpZiAobnVtID09IDApCkBAIC0xNzIsNyArMTcyLDcgQEAgc3Rh dGljIGludCBkb19jb250cm9sX3F1b3RhX3Modm9pZCAqY3R4LCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKIH0KIAogI2lmZGVmIF9fTUlOSU9TX18KLXN0 YXRpYyBpbnQgZG9fY29udHJvbF9tZW1yZXBvcnQodm9pZCAqY3R4LCBzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKK3N0YXRpYyBpbnQgZG9fY29udHJvbF9t ZW1yZXBvcnQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwKIAkJCQljaGFyICoqdmVjLCBpbnQgbnVtKQogewogCWlmIChudW0p CkBAIC0xODQsNyArMTg0LDcgQEAgc3RhdGljIGludCBkb19jb250cm9sX21l bXJlcG9ydCh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAog CXJldHVybiAwOwogfQogI2Vsc2UKLXN0YXRpYyBpbnQgZG9fY29udHJvbF9s b2dmaWxlKHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCitz dGF0aWMgaW50IGRvX2NvbnRyb2xfbG9nZmlsZShjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCQkJICAgICAgY2hhciAqKnZl YywgaW50IG51bSkKIHsKIAlpZiAobnVtICE9IDEpCkBAIC0xOTksNyArMTk5 LDcgQEAgc3RhdGljIGludCBkb19jb250cm9sX2xvZ2ZpbGUodm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAlyZXR1cm4gMDsKIH0KIAot c3RhdGljIGludCBkb19jb250cm9sX21lbXJlcG9ydCh2b2lkICpjdHgsIHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLAorc3RhdGljIGludCBkb19jb250cm9s X21lbXJlcG9ydChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAogCQkJCWNoYXIgKip2ZWMsIGludCBudW0pCiB7CiAJRklMRSAq ZnA7CkBAIC0yMzksNyArMjM5LDcgQEAgc3RhdGljIGludCBkb19jb250cm9s X21lbXJlcG9ydCh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25u LAogfQogI2VuZGlmCiAKLXN0YXRpYyBpbnQgZG9fY29udHJvbF9wcmludCh2 b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorc3RhdGljIGlu dCBkb19jb250cm9sX3ByaW50KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCiAJCQkgICAgY2hhciAqKnZlYywgaW50IG51bSkK IHsKIAlpZiAobnVtICE9IDEpCkBAIC0yNTEsNyArMjUxLDcgQEAgc3RhdGlj IGludCBkb19jb250cm9sX3ByaW50KHZvaWQgKmN0eCwgc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sCiAJcmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBpbnQgZG9f Y29udHJvbF9oZWxwKHZvaWQgKiwgc3RydWN0IGNvbm5lY3Rpb24gKiwgY2hh ciAqKiwgaW50KTsKK3N0YXRpYyBpbnQgZG9fY29udHJvbF9oZWxwKGNvbnN0 IHZvaWQgKiwgc3RydWN0IGNvbm5lY3Rpb24gKiwgY2hhciAqKiwgaW50KTsK IAogc3RhdGljIHN0cnVjdCBjbWRfcyBjbWRzW10gPSB7CiAJeyAiY2hlY2si LCBkb19jb250cm9sX2NoZWNrLCAiIiB9LApAQCAtMjY4LDcgKzI2OCw3IEBA IHN0YXRpYyBzdHJ1Y3QgY21kX3MgY21kc1tdID0gewogCXsgImhlbHAiLCBk b19jb250cm9sX2hlbHAsICIiIH0sCiB9OwogCi1zdGF0aWMgaW50IGRvX2Nv bnRyb2xfaGVscCh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25u LAorc3RhdGljIGludCBkb19jb250cm9sX2hlbHAoY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJCSAgIGNoYXIgKip2ZWMs IGludCBudW0pCiB7CiAJaW50IGNtZCwgbGVuID0gMDsKQEAgLTMwNCw3ICsz MDQsOCBAQCBzdGF0aWMgaW50IGRvX2NvbnRyb2xfaGVscCh2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCXJldHVybiAwOwogfQogCi1p bnQgZG9fY29udHJvbChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0 IGJ1ZmZlcmVkX2RhdGEgKmluKQoraW50IGRvX2NvbnRyb2woY29uc3Qgdm9p ZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkgICAgICAgc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCWludCBudW07CiAJaW50IGNt ZDsKQEAgLTMxNiw3ICszMTcsNyBAQCBpbnQgZG9fY29udHJvbChzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQog CW51bSA9IHhzX2NvdW50X3N0cmluZ3MoaW4tPmJ1ZmZlciwgaW4tPnVzZWQp OwogCWlmIChudW0gPCAxKQogCQlyZXR1cm4gRUlOVkFMOwotCXZlYyA9IHRh bGxvY19hcnJheShpbiwgY2hhciAqLCBudW0pOworCXZlYyA9IHRhbGxvY19h cnJheShjdHgsIGNoYXIgKiwgbnVtKTsKIAlpZiAoIXZlYykKIAkJcmV0dXJu IEVOT01FTTsKIAlpZiAoZ2V0X3N0cmluZ3MoaW4sIHZlYywgbnVtKSAhPSBu dW0pCkBAIC0zMjQsNyArMzI1LDcgQEAgaW50IGRvX2NvbnRyb2woc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikK IAogCWZvciAoY21kID0gMDsgY21kIDwgQVJSQVlfU0laRShjbWRzKTsgY21k KyspCiAJCWlmIChzdHJlcSh2ZWNbMF0sIGNtZHNbY21kXS5jbWQpKQotCQkJ cmV0dXJuIGNtZHNbY21kXS5mdW5jKGluLCBjb25uLCB2ZWMgKyAxLCBudW0g LSAxKTsKKwkJCXJldHVybiBjbWRzW2NtZF0uZnVuYyhjdHgsIGNvbm4sIHZl YyArIDEsIG51bSAtIDEpOwogCiAJcmV0dXJuIEVJTlZBTDsKIH0KZGlmZiAt LWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmggYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5oCmluZGV4IDIwN2Uw YTZmYTM1Mi4uZmFhOTU1OTY4ZGIxIDEwMDY0NAotLS0gYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29udHJvbC5oCisrKyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb250cm9sLmgKQEAgLTE2LDQgKzE2LDUgQEAKICAgICBh bG9uZyB3aXRoIHRoaXMgcHJvZ3JhbTsgSWYgbm90LCBzZWUgPGh0dHA6Ly93 d3cuZ251Lm9yZy9saWNlbnNlcy8+LgogKi8KIAotaW50IGRvX2NvbnRyb2wo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRh ICppbik7CitpbnQgZG9fY29udHJvbChjb25zdCB2b2lkICpjdHgsIHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAorCSAgICAgICBzdHJ1Y3QgYnVmZmVyZWRf ZGF0YSAqaW4pOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMK aW5kZXggNmVkMWFlMjYxNDcwLi4yODcyNGVmMTBhNGIgMTAwNjQ0Ci0tLSBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtMTE0NywxMSArMTE0Nywx MyBAQCBzdGF0aWMgc3RydWN0IG5vZGUgKmdldF9ub2RlX2Nhbm9uaWNhbGl6 ZWQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJcmV0dXJuIGdldF9ub2Rl KGNvbm4sIGN0eCwgKmNhbm9uaWNhbF9uYW1lLCBwZXJtKTsKIH0KIAotc3Rh dGljIGludCBzZW5kX2RpcmVjdG9yeShzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQorc3RhdGljIGludCBzZW5k X2RpcmVjdG9yeShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAorCQkJICBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJ c3RydWN0IG5vZGUgKm5vZGU7CiAKLQlub2RlID0gZ2V0X25vZGVfY2Fub25p Y2FsaXplZChjb25uLCBpbiwgb25lYXJnKGluKSwgTlVMTCwgWFNfUEVSTV9S RUFEKTsKKwlub2RlID0gZ2V0X25vZGVfY2Fub25pY2FsaXplZChjb25uLCBj dHgsIG9uZWFyZyhpbiksIE5VTEwsCisJCQkJICAgICAgWFNfUEVSTV9SRUFE KTsKIAlpZiAoIW5vZGUpCiAJCXJldHVybiBlcnJubzsKIApAQCAtMTE2MCw3 ICsxMTYyLDcgQEAgc3RhdGljIGludCBzZW5kX2RpcmVjdG9yeShzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQog CXJldHVybiAwOwogfQogCi1zdGF0aWMgaW50IHNlbmRfZGlyZWN0b3J5X3Bh cnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCitzdGF0aWMgaW50IHNlbmRf ZGlyZWN0b3J5X3BhcnQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwKIAkJCSAgICAgICBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAq aW4pCiB7CiAJdW5zaWduZWQgaW50IG9mZiwgbGVuLCBtYXhsZW4sIGdlbmxl bjsKQEAgLTExNzIsNyArMTE3NCw4IEBAIHN0YXRpYyBpbnQgc2VuZF9kaXJl Y3RvcnlfcGFydChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJcmV0dXJu IEVJTlZBTDsKIAogCS8qIEZpcnN0IGFyZyBpcyBub2RlIG5hbWUuICovCi0J bm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgaW4sIGluLT5i dWZmZXIsIE5VTEwsIFhTX1BFUk1fUkVBRCk7CisJbm9kZSA9IGdldF9ub2Rl X2Nhbm9uaWNhbGl6ZWQoY29ubiwgY3R4LCBpbi0+YnVmZmVyLCBOVUxMLAor CQkJCSAgICAgIFhTX1BFUk1fUkVBRCk7CiAJaWYgKCFub2RlKQogCQlyZXR1 cm4gZXJybm87CiAKQEAgLTExOTksNyArMTIwMiw3IEBAIHN0YXRpYyBpbnQg c2VuZF9kaXJlY3RvcnlfcGFydChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwK IAkJCWJyZWFrOwogCX0KIAotCWRhdGEgPSB0YWxsb2NfYXJyYXkoaW4sIGNo YXIsIGdlbmxlbiArIGxlbiArIDEpOworCWRhdGEgPSB0YWxsb2NfYXJyYXko Y3R4LCBjaGFyLCBnZW5sZW4gKyBsZW4gKyAxKTsKIAlpZiAoIWRhdGEpCiAJ CXJldHVybiBFTk9NRU07CiAKQEAgLTEyMTUsMTEgKzEyMTgsMTMgQEAgc3Rh dGljIGludCBzZW5kX2RpcmVjdG9yeV9wYXJ0KHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAogCXJldHVybiAwOwogfQogCi1zdGF0aWMgaW50IGRvX3JlYWQo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRh ICppbikKK3N0YXRpYyBpbnQgZG9fcmVhZChjb25zdCB2b2lkICpjdHgsIHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgICBzdHJ1Y3QgYnVmZmVyZWRf ZGF0YSAqaW4pCiB7CiAJc3RydWN0IG5vZGUgKm5vZGU7CiAKLQlub2RlID0g Z2V0X25vZGVfY2Fub25pY2FsaXplZChjb25uLCBpbiwgb25lYXJnKGluKSwg TlVMTCwgWFNfUEVSTV9SRUFEKTsKKwlub2RlID0gZ2V0X25vZGVfY2Fub25p Y2FsaXplZChjb25uLCBjdHgsIG9uZWFyZyhpbiksIE5VTEwsCisJCQkJICAg ICAgWFNfUEVSTV9SRUFEKTsKIAlpZiAoIW5vZGUpCiAJCXJldHVybiBlcnJu bzsKIApAQCAtMTM5OSw3ICsxNDA0LDggQEAgc3RhdGljIHN0cnVjdCBub2Rl ICpjcmVhdGVfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qg dm9pZCAqY3R4LAogfQogCiAvKiBwYXRoLCBkYXRhLi4uICovCi1zdGF0aWMg aW50IGRvX3dyaXRlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qg YnVmZmVyZWRfZGF0YSAqaW4pCitzdGF0aWMgaW50IGRvX3dyaXRlKGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJdW5zaWduZWQgaW50IG9m ZnNldCwgZGF0YWxlbjsKIAlzdHJ1Y3Qgbm9kZSAqbm9kZTsKQEAgLTE0MTMs MTIgKzE0MTksMTIgQEAgc3RhdGljIGludCBkb193cml0ZShzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCW9m ZnNldCA9IHN0cmxlbih2ZWNbMF0pICsgMTsKIAlkYXRhbGVuID0gaW4tPnVz ZWQgLSBvZmZzZXQ7CiAKLQlub2RlID0gZ2V0X25vZGVfY2Fub25pY2FsaXpl ZChjb25uLCBpbiwgdmVjWzBdLCAmbmFtZSwgWFNfUEVSTV9XUklURSk7CisJ bm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgY3R4LCB2ZWNb MF0sICZuYW1lLCBYU19QRVJNX1dSSVRFKTsKIAlpZiAoIW5vZGUpIHsKIAkJ LyogTm8gcGVybWlzc2lvbnMsIGludmFsaWQgaW5wdXQ/ICovCiAJCWlmIChl cnJubyAhPSBFTk9FTlQpCiAJCQlyZXR1cm4gZXJybm87Ci0JCW5vZGUgPSBj cmVhdGVfbm9kZShjb25uLCBpbiwgbmFtZSwgaW4tPmJ1ZmZlciArIG9mZnNl dCwKKwkJbm9kZSA9IGNyZWF0ZV9ub2RlKGNvbm4sIGN0eCwgbmFtZSwgaW4t PmJ1ZmZlciArIG9mZnNldCwKIAkJCQkgICBkYXRhbGVuKTsKIAkJaWYgKCFu b2RlKQogCQkJcmV0dXJuIGVycm5vOwpAQCAtMTQyOSwxOCArMTQzNSwxOSBA QCBzdGF0aWMgaW50IGRvX3dyaXRlKHN0cnVjdCBjb25uZWN0aW9uICpjb25u LCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJCQlyZXR1cm4gZXJybm87 CiAJfQogCi0JZmlyZV93YXRjaGVzKGNvbm4sIGluLCBuYW1lLCBub2RlLCBm YWxzZSwgTlVMTCk7CisJZmlyZV93YXRjaGVzKGNvbm4sIGN0eCwgbmFtZSwg bm9kZSwgZmFsc2UsIE5VTEwpOwogCXNlbmRfYWNrKGNvbm4sIFhTX1dSSVRF KTsKIAogCXJldHVybiAwOwogfQogCi1zdGF0aWMgaW50IGRvX21rZGlyKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAq aW4pCitzdGF0aWMgaW50IGRvX21rZGlyKGNvbnN0IHZvaWQgKmN0eCwgc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICBzdHJ1Y3QgYnVmZmVyZWRf ZGF0YSAqaW4pCiB7CiAJc3RydWN0IG5vZGUgKm5vZGU7CiAJY2hhciAqbmFt ZTsKIAotCW5vZGUgPSBnZXRfbm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGlu LCBvbmVhcmcoaW4pLCAmbmFtZSwKKwlub2RlID0gZ2V0X25vZGVfY2Fub25p Y2FsaXplZChjb25uLCBjdHgsIG9uZWFyZyhpbiksICZuYW1lLAogCQkJCSAg ICAgIFhTX1BFUk1fV1JJVEUpOwogCiAJLyogSWYgaXQgYWxyZWFkeSBleGlz dHMsIGZpbmUuICovCkBAIC0xNDQ4LDEwICsxNDU1LDEwIEBAIHN0YXRpYyBp bnQgZG9fbWtkaXIoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBi dWZmZXJlZF9kYXRhICppbikKIAkJLyogTm8gcGVybWlzc2lvbnM/ICovCiAJ CWlmIChlcnJubyAhPSBFTk9FTlQpCiAJCQlyZXR1cm4gZXJybm87Ci0JCW5v ZGUgPSBjcmVhdGVfbm9kZShjb25uLCBpbiwgbmFtZSwgTlVMTCwgMCk7CisJ CW5vZGUgPSBjcmVhdGVfbm9kZShjb25uLCBjdHgsIG5hbWUsIE5VTEwsIDAp OwogCQlpZiAoIW5vZGUpCiAJCQlyZXR1cm4gZXJybm87Ci0JCWZpcmVfd2F0 Y2hlcyhjb25uLCBpbiwgbmFtZSwgbm9kZSwgZmFsc2UsIE5VTEwpOworCQlm aXJlX3dhdGNoZXMoY29ubiwgY3R4LCBuYW1lLCBub2RlLCBmYWxzZSwgTlVM TCk7CiAJfQogCXNlbmRfYWNrKGNvbm4sIFhTX01LRElSKTsKIApAQCAtMTU0 OSwyMiArMTU1NiwyMyBAQCBzdGF0aWMgaW50IF9ybShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3Qgbm9kZSAqbm9k ZSwKIH0KIAogCi1zdGF0aWMgaW50IGRvX3JtKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitzdGF0aWMgaW50 IGRvX3JtKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sCisJCSBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJc3RydWN0 IG5vZGUgKm5vZGU7CiAJaW50IHJldDsKIAljaGFyICpuYW1lOwogCWNoYXIg KnBhcmVudG5hbWU7CiAKLQlub2RlID0gZ2V0X25vZGVfY2Fub25pY2FsaXpl ZChjb25uLCBpbiwgb25lYXJnKGluKSwgJm5hbWUsCisJbm9kZSA9IGdldF9u b2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgY3R4LCBvbmVhcmcoaW4pLCAmbmFt ZSwKIAkJCQkgICAgICBYU19QRVJNX1dSSVRFKTsKIAlpZiAoIW5vZGUpIHsK IAkJLyogRGlkbid0IGV4aXN0IGFscmVhZHk/ICBGaW5lLCBpZiBwYXJlbnQg ZXhpc3RzLiAqLwogCQlpZiAoZXJybm8gPT0gRU5PRU5UKSB7Ci0JCQlwYXJl bnRuYW1lID0gZ2V0X3BhcmVudChpbiwgbmFtZSk7CisJCQlwYXJlbnRuYW1l ID0gZ2V0X3BhcmVudChjdHgsIG5hbWUpOwogCQkJaWYgKCFwYXJlbnRuYW1l KQogCQkJCXJldHVybiBlcnJubzsKLQkJCW5vZGUgPSByZWFkX25vZGUoY29u biwgaW4sIHBhcmVudG5hbWUpOworCQkJbm9kZSA9IHJlYWRfbm9kZShjb25u LCBjdHgsIHBhcmVudG5hbWUpOwogCQkJaWYgKG5vZGUpIHsKIAkJCQlzZW5k X2Fjayhjb25uLCBYU19STSk7CiAJCQkJcmV0dXJuIDA7CkBAIC0xNTc5LDcg KzE1ODcsNyBAQCBzdGF0aWMgaW50IGRvX3JtKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJaWYgKHN0cmVx KG5hbWUsICIvIikpCiAJCXJldHVybiBFSU5WQUw7CiAKLQlyZXQgPSBfcm0o Y29ubiwgaW4sIG5vZGUsIG5hbWUpOworCXJldCA9IF9ybShjb25uLCBjdHgs IG5vZGUsIG5hbWUpOwogCWlmIChyZXQpCiAJCXJldHVybiByZXQ7CiAKQEAg LTE1ODksMTMgKzE1OTcsMTUgQEAgc3RhdGljIGludCBkb19ybShzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQog fQogCiAKLXN0YXRpYyBpbnQgZG9fZ2V0X3Blcm1zKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitzdGF0aWMg aW50IGRvX2dldF9wZXJtcyhjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLAorCQkJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQog ewogCXN0cnVjdCBub2RlICpub2RlOwogCWNoYXIgKnN0cmluZ3M7CiAJdW5z aWduZWQgaW50IGxlbjsKIAotCW5vZGUgPSBnZXRfbm9kZV9jYW5vbmljYWxp emVkKGNvbm4sIGluLCBvbmVhcmcoaW4pLCBOVUxMLCBYU19QRVJNX1JFQUQp OworCW5vZGUgPSBnZXRfbm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGN0eCwg b25lYXJnKGluKSwgTlVMTCwKKwkJCQkgICAgICBYU19QRVJNX1JFQUQpOwog CWlmICghbm9kZSkKIAkJcmV0dXJuIGVycm5vOwogCkBAIC0xNjA4LDcgKzE2 MTgsOCBAQCBzdGF0aWMgaW50IGRvX2dldF9wZXJtcyhzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCXJldHVy biAwOwogfQogCi1zdGF0aWMgaW50IGRvX3NldF9wZXJtcyhzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQorc3Rh dGljIGludCBkb19zZXRfcGVybXMoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKKwkJCXN0cnVjdCBidWZmZXJlZF9kYXRhICpp bikKIHsKIAlzdHJ1Y3Qgbm9kZV9wZXJtcyBwZXJtcywgb2xkX3Blcm1zOwog CWNoYXIgKm5hbWUsICpwZXJtc3RyOwpAQCAtMTYyNSw3ICsxNjM2LDcgQEAg c3RhdGljIGludCBkb19zZXRfcGVybXMoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAogCXBlcm1zdHIgPSBp bi0+YnVmZmVyICsgc3RybGVuKGluLT5idWZmZXIpICsgMTsKIAotCXBlcm1z LnAgPSB0YWxsb2NfYXJyYXkoaW4sIHN0cnVjdCB4c19wZXJtaXNzaW9ucywg cGVybXMubnVtKTsKKwlwZXJtcy5wID0gdGFsbG9jX2FycmF5KGN0eCwgc3Ry dWN0IHhzX3Blcm1pc3Npb25zLCBwZXJtcy5udW0pOwogCWlmICghcGVybXMu cCkKIAkJcmV0dXJuIEVOT01FTTsKIAlpZiAoIXhzX3N0cmluZ3NfdG9fcGVy bXMocGVybXMucCwgcGVybXMubnVtLCBwZXJtc3RyKSkKQEAgLTE2NDAsNyAr MTY1MSw3IEBAIHN0YXRpYyBpbnQgZG9fc2V0X3Blcm1zKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJfQog CiAJLyogV2UgbXVzdCBvd24gbm9kZSB0byBkbyB0aGlzICh0b29scyBjYW4g ZG8gdGhpcyB0b28pLiAqLwotCW5vZGUgPSBnZXRfbm9kZV9jYW5vbmljYWxp emVkKGNvbm4sIGluLCBpbi0+YnVmZmVyLCAmbmFtZSwKKwlub2RlID0gZ2V0 X25vZGVfY2Fub25pY2FsaXplZChjb25uLCBjdHgsIGluLT5idWZmZXIsICZu YW1lLAogCQkJCSAgICAgIFhTX1BFUk1fV1JJVEUgfCBYU19QRVJNX09XTkVS KTsKIAlpZiAoIW5vZGUpCiAJCXJldHVybiBlcnJubzsKQEAgLTE2NzUsNyAr MTY4Niw3IEBAIHN0YXRpYyBpbnQgZG9fc2V0X3Blcm1zKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJCXJl dHVybiBlcnJubzsKIAl9CiAKLQlmaXJlX3dhdGNoZXMoY29ubiwgaW4sIG5h bWUsIG5vZGUsIGZhbHNlLCAmb2xkX3Blcm1zKTsKKwlmaXJlX3dhdGNoZXMo Y29ubiwgY3R4LCBuYW1lLCBub2RlLCBmYWxzZSwgJm9sZF9wZXJtcyk7CiAJ c2VuZF9hY2soY29ubiwgWFNfU0VUX1BFUk1TKTsKIAogCXJldHVybiAwOwpA QCAtMTY4Myw3ICsxNjk0LDggQEAgc3RhdGljIGludCBkb19zZXRfcGVybXMo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRh ICppbikKIAogc3RhdGljIHN0cnVjdCB7CiAJY29uc3QgY2hhciAqc3RyOwot CWludCAoKmZ1bmMpKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qg YnVmZmVyZWRfZGF0YSAqaW4pOworCWludCAoKmZ1bmMpKGNvbnN0IHZvaWQg KmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICBzdHJ1Y3Qg YnVmZmVyZWRfZGF0YSAqaW4pOwogCXVuc2lnbmVkIGludCBmbGFnczsKICNk ZWZpbmUgWFNfRkxBR19OT1RJRAkJKDFVIDw8IDApCS8qIElnbm9yZSB0cmFu c2FjdGlvbiBpZC4gKi8KICNkZWZpbmUgWFNfRkxBR19QUklWCQkoMVUgPDwg MSkJLyogUHJpdmlsZWdlZCBkb21haW4gb25seS4gKi8KQEAgLTE3NTYsNiAr MTc2OCw3IEBAIHN0YXRpYyB2b2lkIHByb2Nlc3NfbWVzc2FnZShzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQog CXN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnM7CiAJZW51bSB4c2Rfc29ja21z Z190eXBlIHR5cGUgPSBpbi0+aGRyLm1zZy50eXBlOwogCWludCByZXQ7CisJ dm9pZCAqY3R4OwogCiAJaWYgKCh1bnNpZ25lZCBpbnQpdHlwZSA+PSBYU19U WVBFX0NPVU5UIHx8ICF3aXJlX2Z1bmNzW3R5cGVdLmZ1bmMpIHsKIAkJZXBy aW50ZigiQ2xpZW50IHVua25vd24gb3BlcmF0aW9uICVpIiwgdHlwZSk7CkBA IC0xNzc2LDEwICsxNzg5LDE3IEBAIHN0YXRpYyB2b2lkIHByb2Nlc3NfbWVz c2FnZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVk X2RhdGEgKmluKQogCQlyZXR1cm47CiAJfQogCisJY3R4ID0gdGFsbG9jX25l dyhOVUxMKTsKKwlpZiAoIWN0eCkgeworCQlzZW5kX2Vycm9yKGNvbm4sIEVO T01FTSk7CisJCXJldHVybjsKKwl9CisKIAlhc3NlcnQoY29ubi0+dHJhbnNh Y3Rpb24gPT0gTlVMTCk7CiAJY29ubi0+dHJhbnNhY3Rpb24gPSB0cmFuczsK IAotCXJldCA9IHdpcmVfZnVuY3NbdHlwZV0uZnVuYyhjb25uLCBpbik7CisJ cmV0ID0gd2lyZV9mdW5jc1t0eXBlXS5mdW5jKGN0eCwgY29ubiwgaW4pOwor CXRhbGxvY19mcmVlKGN0eCk7CiAJaWYgKHJldCkKIAkJc2VuZF9lcnJvcihj b25uLCByZXQpOwogCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9t YWluLmMKaW5kZXggZGQzYWUxNWVhNGZkLi4yYmRkOGU1ODlkOGEgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYworKysg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMKQEAgLTMzMyw3 ICszMzMsNyBAQCBib29sIGRvbWFpbl9jYW5fd3JpdGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pCiAJcmV0dXJuICgoaW50Zi0+cnNwX3Byb2QgLSBpbnRm LT5yc3BfY29ucykgIT0gWEVOU1RPUkVfUklOR19TSVpFKTsKIH0KIAotc3Rh dGljIGNoYXIgKnRhbGxvY19kb21haW5fcGF0aCh2b2lkICpjb250ZXh0LCB1 bnNpZ25lZCBpbnQgZG9taWQpCitzdGF0aWMgY2hhciAqdGFsbG9jX2RvbWFp bl9wYXRoKGNvbnN0IHZvaWQgKmNvbnRleHQsIHVuc2lnbmVkIGludCBkb21p ZCkKIHsKIAlyZXR1cm4gdGFsbG9jX2FzcHJpbnRmKGNvbnRleHQsICIvbG9j YWwvZG9tYWluLyV1IiwgZG9taWQpOwogfQpAQCAtNDc1LDcgKzQ3NSw4IEBA IHN0YXRpYyB2b2lkIGRvbWFpbl9jb25uX3Jlc2V0KHN0cnVjdCBkb21haW4g KmRvbWFpbikKIH0KIAogLyogZG9taWQsIGdmbiwgZXZ0Y2huLCBwYXRoICov Ci1pbnQgZG9faW50cm9kdWNlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitpbnQgZG9faW50cm9kdWNlKGNv bnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJc3RydWN0IGRvbWFpbiAq ZG9tYWluOwogCWNoYXIgKnZlY1szXTsKQEAgLTU1Niw3ICs1NTcsOCBAQCBz dGF0aWMgc3RydWN0IGRvbWFpbiAqZmluZF9jb25uZWN0ZWRfZG9tYWluKHVu c2lnbmVkIGludCBkb21pZCkKIAlyZXR1cm4gZG9tYWluOwogfQogCi1pbnQg ZG9fc2V0X3RhcmdldChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0 IGJ1ZmZlcmVkX2RhdGEgKmluKQoraW50IGRvX3NldF90YXJnZXQoY29uc3Qg dm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJY2hhciAqdmVjWzJdOwogCXVu c2lnbmVkIGludCBkb21pZCwgdGRvbWlkOwpAQCAtNjAzLDcgKzYwNSw4IEBA IHN0YXRpYyBzdHJ1Y3QgZG9tYWluICpvbmVhcmdfZG9tYWluKHN0cnVjdCBj b25uZWN0aW9uICpjb25uLAogfQogCiAvKiBkb21pZCAqLwotaW50IGRvX3Jl bGVhc2Uoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbikKK2ludCBkb19yZWxlYXNlKGNvbnN0IHZvaWQgKmN0eCwg c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJICAgICAgIHN0cnVjdCBidWZm ZXJlZF9kYXRhICppbikKIHsKIAlzdHJ1Y3QgZG9tYWluICpkb21haW47CiAK QEAgLTYxOCw3ICs2MjEsOCBAQCBpbnQgZG9fcmVsZWFzZShzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCXJl dHVybiAwOwogfQogCi1pbnQgZG9fcmVzdW1lKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitpbnQgZG9fcmVz dW1lKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s CisJICAgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCXN0cnVj dCBkb21haW4gKmRvbWFpbjsKIApAQCAtNjMzLDcgKzYzNyw4IEBAIGludCBk b19yZXN1bWUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZm ZXJlZF9kYXRhICppbikKIAlyZXR1cm4gMDsKIH0KIAotaW50IGRvX2dldF9k b21haW5fcGF0aChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKmluKQoraW50IGRvX2dldF9kb21haW5fcGF0aChjb25z dCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgICAg ICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCWNoYXIgKnBhdGg7 CiAJY29uc3QgY2hhciAqZG9taWRfc3RyID0gb25lYXJnKGluKTsKQEAgLTY0 MSwxOCArNjQ2LDE3IEBAIGludCBkb19nZXRfZG9tYWluX3BhdGgoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikK IAlpZiAoIWRvbWlkX3N0cikKIAkJcmV0dXJuIEVJTlZBTDsKIAotCXBhdGgg PSB0YWxsb2NfZG9tYWluX3BhdGgoY29ubiwgYXRvaShkb21pZF9zdHIpKTsK KwlwYXRoID0gdGFsbG9jX2RvbWFpbl9wYXRoKGN0eCwgYXRvaShkb21pZF9z dHIpKTsKIAlpZiAoIXBhdGgpCiAJCXJldHVybiBlcnJubzsKIAogCXNlbmRf cmVwbHkoY29ubiwgWFNfR0VUX0RPTUFJTl9QQVRILCBwYXRoLCBzdHJsZW4o cGF0aCkgKyAxKTsKIAotCXRhbGxvY19mcmVlKHBhdGgpOwotCiAJcmV0dXJu IDA7CiB9CiAKLWludCBkb19pc19kb21haW5faW50cm9kdWNlZChzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQor aW50IGRvX2lzX2RvbWFpbl9pbnRyb2R1Y2VkKGNvbnN0IHZvaWQgKmN0eCwg c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCQkgICAgc3RydWN0IGJ1ZmZl cmVkX2RhdGEgKmluKQogewogCWludCByZXN1bHQ7CiAJdW5zaWduZWQgaW50 IGRvbWlkOwpAQCAtNjczLDcgKzY3Nyw4IEBAIGludCBkb19pc19kb21haW5f aW50cm9kdWNlZChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKmluKQogfQogCiAvKiBBbGxvdyBndWVzdCB0byByZXNl dCBhbGwgd2F0Y2hlcyAqLwotaW50IGRvX3Jlc2V0X3dhdGNoZXMoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikK K2ludCBkb19yZXNldF93YXRjaGVzKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICAgc3RydWN0IGJ1ZmZlcmVkX2Rh dGEgKmluKQogewogCWNvbm5fZGVsZXRlX2FsbF93YXRjaGVzKGNvbm4pOwog CWNvbm5fZGVsZXRlX2FsbF90cmFuc2FjdGlvbnMoY29ubik7CmRpZmYgLS1n aXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmggYi90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgKaW5kZXggZTAxM2E5OTkx Y2E4Li43MzJlYjhmYTc1ZTEgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9kb21haW4uaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmgKQEAgLTIyLDI1ICsyMiwzMiBAQAogdm9pZCBoYW5k bGVfZXZlbnQodm9pZCk7CiAKIC8qIGRvbWlkLCBtZm4sIGV2ZW50Y2huLCBw YXRoICovCi1pbnQgZG9faW50cm9kdWNlKHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOworaW50IGRvX2ludHJv ZHVjZShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25u LAorCQkgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKIAogLyogZG9taWQg Ki8KLWludCBkb19pc19kb21haW5faW50cm9kdWNlZChzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKK2ludCBk b19pc19kb21haW5faW50cm9kdWNlZChjb25zdCB2b2lkICpjdHgsIHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAorCQkJICAgIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbik7CiAKIC8qIGRvbWlkICovCi1pbnQgZG9fcmVsZWFzZShzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmlu KTsKK2ludCBkb19yZWxlYXNlKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCisJICAgICAgIHN0cnVjdCBidWZmZXJlZF9kYXRh ICppbik7CiAKIC8qIGRvbWlkICovCi1pbnQgZG9fcmVzdW1lKHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOwor aW50IGRvX3Jlc3VtZShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLAorCSAgICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7 CiAKIC8qIGRvbWlkLCB0YXJnZXQgKi8KLWludCBkb19zZXRfdGFyZ2V0KHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAq aW4pOworaW50IGRvX3NldF90YXJnZXQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSAqaW4pOwogCiAvKiBkb21pZCAqLwotaW50IGRvX2dldF9kb21haW5fcGF0 aChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2Rh dGEgKmluKTsKK2ludCBkb19nZXRfZG9tYWluX3BhdGgoY29uc3Qgdm9pZCAq Y3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICAgICAgIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbik7CiAKIC8qIEFsbG93IGd1ZXN0IHRvIHJl c2V0IGFsbCB3YXRjaGVzICovCi1pbnQgZG9fcmVzZXRfd2F0Y2hlcyhzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmlu KTsKK2ludCBkb19yZXNldF93YXRjaGVzKGNvbnN0IHZvaWQgKmN0eCwgc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICAgc3RydWN0IGJ1ZmZlcmVk X2RhdGEgKmluKTsKIAogdm9pZCBkb21haW5faW5pdCh2b2lkKTsKIApkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9u LmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpp bmRleCA2ZTI5MTE4YzgwMGQuLmNkNTkyODQ1ZTdjYSAxMDA2NDQKLS0tIGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKKysrIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKQEAgLTQ4 Nyw3ICs0ODcsOCBAQCBzdHJ1Y3QgdHJhbnNhY3Rpb24gKnRyYW5zYWN0aW9u X2xvb2t1cChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgdWludDMyX3QgaWQp CiAJcmV0dXJuIEVSUl9QVFIoLUVOT0VOVCk7CiB9CiAKLWludCBkb190cmFu c2FjdGlvbl9zdGFydChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0 IGJ1ZmZlcmVkX2RhdGEgKmluKQoraW50IGRvX3RyYW5zYWN0aW9uX3N0YXJ0 KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJ CQkgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCXN0cnVjdCB0cmFu c2FjdGlvbiAqdHJhbnMsICpleGlzdHM7CiAJY2hhciBpZF9zdHJbMjBdOwpA QCAtNTAwLDggKzUwMSw4IEBAIGludCBkb190cmFuc2FjdGlvbl9zdGFydChz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEg KmluKQogCSAgICBjb25uLT50cmFuc2FjdGlvbl9zdGFydGVkID4gcXVvdGFf bWF4X3RyYW5zYWN0aW9uKQogCQlyZXR1cm4gRU5PU1BDOwogCi0JLyogQXR0 YWNoIHRyYW5zYWN0aW9uIHRvIGlucHV0IGZvciBhdXRvZnJlZSB1bnRpbCBp dCdzIGNvbXBsZXRlICovCi0JdHJhbnMgPSB0YWxsb2NfemVybyhpbiwgc3Ry dWN0IHRyYW5zYWN0aW9uKTsKKwkvKiBBdHRhY2ggdHJhbnNhY3Rpb24gdG8g Y3R4IGZvciBhdXRvZnJlZSB1bnRpbCBpdCdzIGNvbXBsZXRlICovCisJdHJh bnMgPSB0YWxsb2NfemVybyhjdHgsIHN0cnVjdCB0cmFuc2FjdGlvbik7CiAJ aWYgKCF0cmFucykKIAkJcmV0dXJuIEVOT01FTTsKIApAQCAtNTQ4LDcgKzU0 OSw4IEBAIHN0YXRpYyBpbnQgdHJhbnNhY3Rpb25fZml4X2RvbWFpbnMoc3Ry dWN0IHRyYW5zYWN0aW9uICp0cmFucywgYm9vbCB1cGRhdGUpCiAJcmV0dXJu IDA7CiB9CiAKLWludCBkb190cmFuc2FjdGlvbl9lbmQoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKK2ludCBk b190cmFuc2FjdGlvbl9lbmQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwKKwkJICAgICAgIHN0cnVjdCBidWZmZXJlZF9kYXRh ICppbikKIHsKIAljb25zdCBjaGFyICphcmcgPSBvbmVhcmcoaW4pOwogCXN0 cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnM7CkBAIC01NjQsOCArNTY2LDggQEAg aW50IGRvX3RyYW5zYWN0aW9uX2VuZChzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCWxpc3RfZGVsKCZ0cmFu cy0+bGlzdCk7CiAJY29ubi0+dHJhbnNhY3Rpb25fc3RhcnRlZC0tOwogCi0J LyogQXR0YWNoIHRyYW5zYWN0aW9uIHRvIGluIGZvciBhdXRvLWNsZWFudXAg Ki8KLQl0YWxsb2Nfc3RlYWwoaW4sIHRyYW5zKTsKKwkvKiBBdHRhY2ggdHJh bnNhY3Rpb24gdG8gY3R4IGZvciBhdXRvLWNsZWFudXAgKi8KKwl0YWxsb2Nf c3RlYWwoY3R4LCB0cmFucyk7CiAKIAlpZiAoc3RyZXEoYXJnLCAiVCIpKSB7 CiAJCWlmICh0cmFucy0+ZmFpbCkKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKaW5kZXggZTNjYmQ2YjIzMDk1Li4z OWQ3ZjgxYzUxMjcgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF90cmFuc2FjdGlvbi5oCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF90cmFuc2FjdGlvbi5oCkBAIC0yOSw4ICsyOSwxMCBAQCBzdHJ1Y3Qg dHJhbnNhY3Rpb247CiAKIGV4dGVybiB1aW50NjRfdCBnZW5lcmF0aW9uOwog Ci1pbnQgZG9fdHJhbnNhY3Rpb25fc3RhcnQoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICpub2RlKTsKLWludCBkb190 cmFuc2FjdGlvbl9lbmQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbik7CitpbnQgZG9fdHJhbnNhY3Rpb25fc3Rh cnQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwK KwkJCSBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqbm9kZSk7CitpbnQgZG9fdHJh bnNhY3Rpb25fZW5kKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sCisJCSAgICAgICBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p OwogCiBzdHJ1Y3QgdHJhbnNhY3Rpb24gKnRyYW5zYWN0aW9uX2xvb2t1cChz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgdWludDMyX3QgaWQpOwogCmRpZmYg LS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCmluZGV4IDE5ZDBmYjAx YjFjNC4uMTM2MjdjZTk3MjY2IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfd2F0Y2guYworKysgYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfd2F0Y2guYwpAQCAtMTg0LDcgKzE4NCw3IEBAIHN0YXRpYyBpbnQg ZGVzdHJveV93YXRjaCh2b2lkICpfd2F0Y2gpCiAJcmV0dXJuIDA7CiB9CiAK LWludCBkb193YXRjaChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0 IGJ1ZmZlcmVkX2RhdGEgKmluKQoraW50IGRvX3dhdGNoKGNvbnN0IHZvaWQg KmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbikKIHsKIAlzdHJ1Y3Qgd2F0Y2ggKndhdGNoOwogCWNoYXIg KnZlY1syXTsKQEAgLTIwMCw3ICsyMDAsNyBAQCBpbnQgZG9fd2F0Y2goc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICpp bikKIAkJLyogY2hlY2sgaWYgdmFsaWQgZXZlbnQgKi8KIAl9IGVsc2Ugewog CQlyZWxhdGl2ZSA9ICFzdHJzdGFydHModmVjWzBdLCAiLyIpOwotCQl2ZWNb MF0gPSBjYW5vbmljYWxpemUoY29ubiwgaW4sIHZlY1swXSk7CisJCXZlY1sw XSA9IGNhbm9uaWNhbGl6ZShjb25uLCBjdHgsIHZlY1swXSk7CiAJCWlmICgh dmVjWzBdKQogCQkJcmV0dXJuIEVOT01FTTsKIAkJaWYgKCFpc192YWxpZF9u b2RlbmFtZSh2ZWNbMF0pKQpAQCAtMjUwLDcgKzI1MCw4IEBAIGludCBkb193 YXRjaChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVk X2RhdGEgKmluKQogCXJldHVybiAwOwogfQogCi1pbnQgZG9fdW53YXRjaChz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEg KmluKQoraW50IGRvX3Vud2F0Y2goY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKKwkgICAgICAgc3RydWN0IGJ1ZmZlcmVkX2Rh dGEgKmluKQogewogCXN0cnVjdCB3YXRjaCAqd2F0Y2g7CiAJY2hhciAqbm9k ZSwgKnZlY1syXTsKQEAgLTI1OCw3ICsyNTksNyBAQCBpbnQgZG9fdW53YXRj aChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2Rh dGEgKmluKQogCWlmIChnZXRfc3RyaW5ncyhpbiwgdmVjLCBBUlJBWV9TSVpF KHZlYykpICE9IEFSUkFZX1NJWkUodmVjKSkKIAkJcmV0dXJuIEVJTlZBTDsK IAotCW5vZGUgPSBjYW5vbmljYWxpemUoY29ubiwgaW4sIHZlY1swXSk7CisJ bm9kZSA9IGNhbm9uaWNhbGl6ZShjb25uLCBjdHgsIHZlY1swXSk7CiAJaWYg KCFub2RlKQogCQlyZXR1cm4gRU5PTUVNOwogCWxpc3RfZm9yX2VhY2hfZW50 cnkod2F0Y2gsICZjb25uLT53YXRjaGVzLCBsaXN0KSB7CmRpZmYgLS1naXQg YS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guaCBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF93YXRjaC5oCmluZGV4IDAzMDk0Mzc0ZjM3OS4u NDA0NTVkZmY1ZDJiIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfd2F0Y2guaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf d2F0Y2guaApAQCAtMjEsOCArMjEsMTAgQEAKIAogI2luY2x1ZGUgInhlbnN0 b3JlZF9jb3JlLmgiCiAKLWludCBkb193YXRjaChzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKLWludCBkb191 bndhdGNoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pOworaW50IGRvX3dhdGNoKGNvbnN0IHZvaWQgKmN0eCwg c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJICAgICBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pOworaW50IGRvX3Vud2F0Y2goY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkgICAgICAgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKmluKTsKIAogLyogRmlyZSBhbGwgd2F0Y2hlczogIWV4 YWN0IG1lYW5zIGFsbCB0aGUgY2hpbGRyZW4gYXJlIGFmZmVjdGVkIChpZS4g cm0pLiAqLwogdm9pZCBmaXJlX3dhdGNoZXMoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIGNvbnN0IHZvaWQgKnRtcCwgY29uc3QgY2hhciAqbmFtZSwK --=separator Content-Type: application/octet-stream; name="xsa416-4.15.patch" Content-Disposition: attachment; filename="xsa416-4.15.patch" Content-Transfer-Encoding: base64 RnJvbSBkYTg1ZGQyODExMTkzOTAyMTYwODFiY2UxNDYzZjNkOWIxMGJhMWM3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGRvbid0IHVz ZSBjb25uLT5pbiBhcyBjb250ZXh0IGZvciB0ZW1wb3JhcnkKIGFsbG9jYXRp b25zCgpVc2luZyB0aGUgc3RydWN0IGJ1ZmZlcmVkIGRhdGEgcG9pbnRlciBv ZiB0aGUgY3VycmVudCBwcm9jZXNzZWQgcmVxdWVzdApmb3IgdGVtcG9yYXJ5 IGRhdGEgYWxsb2NhdGlvbnMgaGFzIGEgbWFqb3IgZHJhd2JhY2s6IHRoZSB1 c2VkIGFyZWEgKGFuZAp3aXRoIHRoYXQgdGhlIHRlbXBvcmFyeSBkYXRhKSBp cyBmcmVlZCBvbmx5IGFmdGVyIHRoZSByZXNwb25zZSBvZiB0aGUKcmVxdWVz dCBoYXMgYmVlbiB3cml0dGVuIHRvIHRoZSByaW5nIHBhZ2Ugb3IgaGFzIGJl ZW4gcmVhZCB2aWEgdGhlCnNvY2tldC4gVGhpcyBjYW4gaGFwcGVuIG11Y2gg bGF0ZXIgaW4gY2FzZSBhIGd1ZXN0IGlzbid0IHJlYWRpbmcgaXRzCnJlc3Bv bnNlcyBmYXN0IGVub3VnaC4KCkFzIHRoZSB0ZW1wb3JhcnkgZGF0YSBjYW4g YmUgc2FmZWx5IGZyZWVkIGFmdGVyIGNyZWF0aW5nIHRoZSByZXNwb25zZSwK YWRkIGEgdGVtcG9yYXJ5IGNvbnRleHQgZm9yIHRoYXQgcHVycG9zZSBhbmQg dXNlIHRoYXQgZm9yIGFsbG9jYXRpbmcKdGhlIHRlbXBvcmFyeSBtZW1vcnks IGFzIGl0IHdhcyBhbHJlYWR5IHRoZSBjYXNlIGJlZm9yZSBjb21taXQKY2Mw NjEyNDY0ODk2ICgieGVuc3RvcmU6IGFkZCBzbWFsbCBkZWZhdWx0IGRhdGEg YnVmZmVyIHRvIGludGVybmFsCnN0cnVjdCIpLgoKU29tZSBzdWItZnVuY3Rp b25zIG5lZWQgdG8gZ2FpbiB0aGUgImNvbnN0IiBhdHRyaWJ1dGUgZm9yIHRo ZSB0YWxsb2MKY29udGV4dC4KClRoaXMgaXMgWFNBLTQxNiAvIENWRS0yMDIy LTQyMzE5LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+CkZpeGVzOiBjYzA2MTI0NjQ4OTYgKCJ4ZW5zdG9yZTogYWRk IHNtYWxsIGRlZmF1bHQgZGF0YSBidWZmZXIgdG8gaW50ZXJuYWwgc3RydWN0 IikKU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29udHJvbC5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wu YwppbmRleCA5ODAyNzlmYTUzZmYuLjk1YTYwYmY1Nzg1OCAxMDA2NDQKLS0t IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuYworKysgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jCkBAIC0xMDcsNyAr MTA3LDcgQEAgc3RhdGljIGNvbnN0IGNoYXIgKmx1X2JlZ2luKHN0cnVjdCBj b25uZWN0aW9uICpjb25uKQogCiBzdHJ1Y3QgY21kX3MgewogCWNoYXIgKmNt ZDsKLQlpbnQgKCpmdW5jKSh2b2lkICosIHN0cnVjdCBjb25uZWN0aW9uICos IGNoYXIgKiosIGludCk7CisJaW50ICgqZnVuYykoY29uc3Qgdm9pZCAqLCBz dHJ1Y3QgY29ubmVjdGlvbiAqLCBjaGFyICoqLCBpbnQpOwogCWNoYXIgKnBh cnM7CiAJLyoKIAkgKiBtYXhfcGFycyBjYW4gYmUgdXNlZCB0byBsaW1pdCB0 aGUgc2l6ZSBvZiB0aGUgcGFyYW1ldGVyIHZlY3RvciwKQEAgLTExOSw3ICsx MTksNyBAQCBzdHJ1Y3QgY21kX3MgewogCXVuc2lnbmVkIGludCBtYXhfcGFy czsKIH07CiAKLXN0YXRpYyBpbnQgZG9fY29udHJvbF9jaGVjayh2b2lkICpj dHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorc3RhdGljIGludCBkb19j b250cm9sX2NoZWNrKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sCiAJCQkgICAgY2hhciAqKnZlYywgaW50IG51bSkKIHsKIAlp ZiAobnVtKQpAQCAtMTMxLDcgKzEzMSw3IEBAIHN0YXRpYyBpbnQgZG9fY29u dHJvbF9jaGVjayh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25u LAogCXJldHVybiAwOwogfQogCi1zdGF0aWMgaW50IGRvX2NvbnRyb2xfbG9n KHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCitzdGF0aWMg aW50IGRvX2NvbnRyb2xfbG9nKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCiAJCQkgIGNoYXIgKip2ZWMsIGludCBudW0pCiB7 CiAJaWYgKG51bSAhPSAxKQpAQCAtMjMzLDcgKzIzMyw3IEBAIHN0YXRpYyBp bnQgcXVvdGFfZ2V0KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sCiAJcmV0dXJuIGRvbWFpbl9nZXRfcXVvdGEoY3R4LCBjb25u LCBhdG9pKHZlY1swXSkpOwogfQogCi1zdGF0aWMgaW50IGRvX2NvbnRyb2xf cXVvdGEodm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKK3N0 YXRpYyBpbnQgZG9fY29udHJvbF9xdW90YShjb25zdCB2b2lkICpjdHgsIHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLAogCQkJICAgIGNoYXIgKip2ZWMsIGlu dCBudW0pCiB7CiAJaWYgKG51bSA9PSAwKQpAQCAtMjQ1LDcgKzI0NSw3IEBA IHN0YXRpYyBpbnQgZG9fY29udHJvbF9xdW90YSh2b2lkICpjdHgsIHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAogCXJldHVybiBxdW90YV9nZXQoY3R4LCBj b25uLCB2ZWMsIG51bSk7CiB9CiAKLXN0YXRpYyBpbnQgZG9fY29udHJvbF9x dW90YV9zKHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCitz dGF0aWMgaW50IGRvX2NvbnRyb2xfcXVvdGFfcyhjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCQkJICAgICAgY2hhciAqKnZl YywgaW50IG51bSkKIHsKIAlpZiAobnVtID09IDApCkBAIC0yNTgsNyArMjU4 LDcgQEAgc3RhdGljIGludCBkb19jb250cm9sX3F1b3RhX3Modm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIH0KIAogI2lmZGVmIF9fTUlO SU9TX18KLXN0YXRpYyBpbnQgZG9fY29udHJvbF9tZW1yZXBvcnQodm9pZCAq Y3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKK3N0YXRpYyBpbnQgZG9f Y29udHJvbF9tZW1yZXBvcnQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwKIAkJCQljaGFyICoqdmVjLCBpbnQgbnVtKQogewog CWlmIChudW0pCkBAIC0yNzAsNyArMjcwLDcgQEAgc3RhdGljIGludCBkb19j b250cm9sX21lbXJlcG9ydCh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAogCXJldHVybiAwOwogfQogI2Vsc2UKLXN0YXRpYyBpbnQgZG9f Y29udHJvbF9sb2dmaWxlKHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sCitzdGF0aWMgaW50IGRvX2NvbnRyb2xfbG9nZmlsZShjb25zdCB2 b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCQkJICAgICAg Y2hhciAqKnZlYywgaW50IG51bSkKIHsKIAlpZiAobnVtICE9IDEpCkBAIC0y ODUsNyArMjg1LDcgQEAgc3RhdGljIGludCBkb19jb250cm9sX2xvZ2ZpbGUo dm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAlyZXR1cm4g MDsKIH0KIAotc3RhdGljIGludCBkb19jb250cm9sX21lbXJlcG9ydCh2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorc3RhdGljIGludCBk b19jb250cm9sX21lbXJlcG9ydChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBj b25uZWN0aW9uICpjb25uLAogCQkJCWNoYXIgKip2ZWMsIGludCBudW0pCiB7 CiAJRklMRSAqZnA7CkBAIC0zMjUsNyArMzI1LDcgQEAgc3RhdGljIGludCBk b19jb250cm9sX21lbXJlcG9ydCh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLAogfQogI2VuZGlmCiAKLXN0YXRpYyBpbnQgZG9fY29udHJv bF9wcmludCh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAor c3RhdGljIGludCBkb19jb250cm9sX3ByaW50KGNvbnN0IHZvaWQgKmN0eCwg c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQkgICAgY2hhciAqKnZlYywg aW50IG51bSkKIHsKIAlpZiAobnVtICE9IDEpCkBAIC04MDIsNyArODAyLDcg QEAgc3RhdGljIGNvbnN0IGNoYXIgKmx1X3N0YXJ0KGNvbnN0IHZvaWQgKmN0 eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJcmV0dXJuIE5VTEw7CiB9 CiAKLXN0YXRpYyBpbnQgZG9fY29udHJvbF9sdSh2b2lkICpjdHgsIHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAorc3RhdGljIGludCBkb19jb250cm9sX2x1 KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJ CQkgY2hhciAqKnZlYywgaW50IG51bSkKIHsKIAljb25zdCBjaGFyICpyZXQg PSBOVUxMOwpAQCAtODUyLDcgKzg1Miw3IEBAIHN0YXRpYyBpbnQgZG9fY29u dHJvbF9sdSh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAog fQogI2VuZGlmCiAKLXN0YXRpYyBpbnQgZG9fY29udHJvbF9oZWxwKHZvaWQg Kiwgc3RydWN0IGNvbm5lY3Rpb24gKiwgY2hhciAqKiwgaW50KTsKK3N0YXRp YyBpbnQgZG9fY29udHJvbF9oZWxwKGNvbnN0IHZvaWQgKiwgc3RydWN0IGNv bm5lY3Rpb24gKiwgY2hhciAqKiwgaW50KTsKIAogc3RhdGljIHN0cnVjdCBj bWRfcyBjbWRzW10gPSB7CiAJeyAiY2hlY2siLCBkb19jb250cm9sX2NoZWNr LCAiIiB9LApAQCAtODkxLDcgKzg5MSw3IEBAIHN0YXRpYyBzdHJ1Y3QgY21k X3MgY21kc1tdID0gewogCXsgImhlbHAiLCBkb19jb250cm9sX2hlbHAsICIi IH0sCiB9OwogCi1zdGF0aWMgaW50IGRvX2NvbnRyb2xfaGVscCh2b2lkICpj dHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorc3RhdGljIGludCBkb19j b250cm9sX2hlbHAoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwKIAkJCSAgIGNoYXIgKip2ZWMsIGludCBudW0pCiB7CiAJaW50 IGNtZCwgbGVuID0gMDsKQEAgLTkyNyw3ICs5MjcsOCBAQCBzdGF0aWMgaW50 IGRvX2NvbnRyb2xfaGVscCh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAogCXJldHVybiAwOwogfQogCi1pbnQgZG9fY29udHJvbChzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmlu KQoraW50IGRvX2NvbnRyb2woY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwKKwkgICAgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEg KmluKQogewogCXVuc2lnbmVkIGludCBjbWQsIG51bSwgb2ZmOwogCWNoYXIg Kip2ZWMgPSBOVUxMOwpAQCAtOTQ3LDExICs5NDgsMTEgQEAgaW50IGRvX2Nv bnRyb2woc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbikKIAludW0gPSB4c19jb3VudF9zdHJpbmdzKGluLT5idWZm ZXIsIGluLT51c2VkKTsKIAlpZiAoY21kc1tjbWRdLm1heF9wYXJzKQogCQlu dW0gPSBtaW4obnVtLCBjbWRzW2NtZF0ubWF4X3BhcnMpOwotCXZlYyA9IHRh bGxvY19hcnJheShpbiwgY2hhciAqLCBudW0pOworCXZlYyA9IHRhbGxvY19h cnJheShjdHgsIGNoYXIgKiwgbnVtKTsKIAlpZiAoIXZlYykKIAkJcmV0dXJu IEVOT01FTTsKIAlpZiAoZ2V0X3N0cmluZ3MoaW4sIHZlYywgbnVtKSA8IG51 bSkKIAkJcmV0dXJuIEVJTzsKIAotCXJldHVybiBjbWRzW2NtZF0uZnVuYyhp biwgY29ubiwgdmVjICsgMSwgbnVtIC0gMSk7CisJcmV0dXJuIGNtZHNbY21k XS5mdW5jKGN0eCwgY29ubiwgdmVjICsgMSwgbnVtIC0gMSk7CiB9CmRpZmYg LS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5oIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuaAppbmRleCBhYWM2 MWYwNTkwOGYuLjY0MzBjMzc2OTM2MSAxMDA2NDQKLS0tIGEvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuaAorKysgYi90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfY29udHJvbC5oCkBAIC0xNiw1ICsxNiw2IEBACiAgICAg YWxvbmcgd2l0aCB0aGlzIHByb2dyYW07IElmIG5vdCwgc2VlIDxodHRwOi8v d3d3LmdudS5vcmcvbGljZW5zZXMvPi4KICovCiAKLWludCBkb19jb250cm9s KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSAqaW4pOworaW50IGRvX2NvbnRyb2woY29uc3Qgdm9pZCAqY3R4LCBzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkgICAgICAgc3RydWN0IGJ1ZmZlcmVk X2RhdGEgKmluKTsKIHZvaWQgbHVfcmVhZF9zdGF0ZSh2b2lkKTsKZGlmZiAt LWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IGYyN2Q1YzAxMDFi Yy4uODA2ZjI0YmJhYjhiIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmMKQEAgLTEyMTQsMTEgKzEyMTQsMTMgQEAgc3RhdGljIHN0cnVj dCBub2RlICpnZXRfbm9kZV9jYW5vbmljYWxpemVkKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLAogCXJldHVybiBnZXRfbm9kZShjb25uLCBjdHgsICpjYW5v bmljYWxfbmFtZSwgcGVybSk7CiB9CiAKLXN0YXRpYyBpbnQgc2VuZF9kaXJl Y3Rvcnkoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbikKK3N0YXRpYyBpbnQgc2VuZF9kaXJlY3RvcnkoY29uc3Qg dm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJCSAgc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCXN0cnVjdCBub2RlICpub2Rl OwogCi0Jbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgaW4s IG9uZWFyZyhpbiksIE5VTEwsIFhTX1BFUk1fUkVBRCk7CisJbm9kZSA9IGdl dF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgY3R4LCBvbmVhcmcoaW4pLCBO VUxMLAorCQkJCSAgICAgIFhTX1BFUk1fUkVBRCk7CiAJaWYgKCFub2RlKQog CQlyZXR1cm4gZXJybm87CiAKQEAgLTEyMjcsNyArMTIyOSw3IEBAIHN0YXRp YyBpbnQgc2VuZF9kaXJlY3Rvcnkoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlyZXR1cm4gMDsKIH0KIAot c3RhdGljIGludCBzZW5kX2RpcmVjdG9yeV9wYXJ0KHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLAorc3RhdGljIGludCBzZW5kX2RpcmVjdG9yeV9wYXJ0KGNv bnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQkg ICAgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCXVuc2lnbmVk IGludCBvZmYsIGxlbiwgbWF4bGVuLCBnZW5sZW47CkBAIC0xMjM5LDcgKzEy NDEsOCBAQCBzdGF0aWMgaW50IHNlbmRfZGlyZWN0b3J5X3BhcnQoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sCiAJCXJldHVybiBFSU5WQUw7CiAKIAkvKiBG aXJzdCBhcmcgaXMgbm9kZSBuYW1lLiAqLwotCW5vZGUgPSBnZXRfbm9kZV9j YW5vbmljYWxpemVkKGNvbm4sIGluLCBpbi0+YnVmZmVyLCBOVUxMLCBYU19Q RVJNX1JFQUQpOworCW5vZGUgPSBnZXRfbm9kZV9jYW5vbmljYWxpemVkKGNv bm4sIGN0eCwgaW4tPmJ1ZmZlciwgTlVMTCwKKwkJCQkgICAgICBYU19QRVJN X1JFQUQpOwogCWlmICghbm9kZSkKIAkJcmV0dXJuIGVycm5vOwogCkBAIC0x MjY2LDcgKzEyNjksNyBAQCBzdGF0aWMgaW50IHNlbmRfZGlyZWN0b3J5X3Bh cnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQlicmVhazsKIAl9CiAK LQlkYXRhID0gdGFsbG9jX2FycmF5KGluLCBjaGFyLCBnZW5sZW4gKyBsZW4g KyAxKTsKKwlkYXRhID0gdGFsbG9jX2FycmF5KGN0eCwgY2hhciwgZ2VubGVu ICsgbGVuICsgMSk7CiAJaWYgKCFkYXRhKQogCQlyZXR1cm4gRU5PTUVNOwog CkBAIC0xMjgyLDExICsxMjg1LDEzIEBAIHN0YXRpYyBpbnQgc2VuZF9kaXJl Y3RvcnlfcGFydChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAlyZXR1cm4g MDsKIH0KIAotc3RhdGljIGludCBkb19yZWFkKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitzdGF0aWMgaW50 IGRvX3JlYWQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwKKwkJICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCXN0 cnVjdCBub2RlICpub2RlOwogCi0Jbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNh bGl6ZWQoY29ubiwgaW4sIG9uZWFyZyhpbiksIE5VTEwsIFhTX1BFUk1fUkVB RCk7CisJbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgY3R4 LCBvbmVhcmcoaW4pLCBOVUxMLAorCQkJCSAgICAgIFhTX1BFUk1fUkVBRCk7 CiAJaWYgKCFub2RlKQogCQlyZXR1cm4gZXJybm87CiAKQEAgLTE0NzYsNyAr MTQ4MSw4IEBAIHN0YXRpYyBzdHJ1Y3Qgbm9kZSAqY3JlYXRlX25vZGUoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIH0KIAog LyogcGF0aCwgZGF0YS4uLiAqLwotc3RhdGljIGludCBkb193cml0ZShzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmlu KQorc3RhdGljIGludCBkb193cml0ZShjb25zdCB2b2lkICpjdHgsIHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAorCQkgICAgc3RydWN0IGJ1ZmZlcmVkX2Rh dGEgKmluKQogewogCXVuc2lnbmVkIGludCBvZmZzZXQsIGRhdGFsZW47CiAJ c3RydWN0IG5vZGUgKm5vZGU7CkBAIC0xNDkwLDEyICsxNDk2LDEyIEBAIHN0 YXRpYyBpbnQgZG9fd3JpdGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlvZmZzZXQgPSBzdHJsZW4odmVj WzBdKSArIDE7CiAJZGF0YWxlbiA9IGluLT51c2VkIC0gb2Zmc2V0OwogCi0J bm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgaW4sIHZlY1sw XSwgJm5hbWUsIFhTX1BFUk1fV1JJVEUpOworCW5vZGUgPSBnZXRfbm9kZV9j YW5vbmljYWxpemVkKGNvbm4sIGN0eCwgdmVjWzBdLCAmbmFtZSwgWFNfUEVS TV9XUklURSk7CiAJaWYgKCFub2RlKSB7CiAJCS8qIE5vIHBlcm1pc3Npb25z LCBpbnZhbGlkIGlucHV0PyAqLwogCQlpZiAoZXJybm8gIT0gRU5PRU5UKQog CQkJcmV0dXJuIGVycm5vOwotCQlub2RlID0gY3JlYXRlX25vZGUoY29ubiwg aW4sIG5hbWUsIGluLT5idWZmZXIgKyBvZmZzZXQsCisJCW5vZGUgPSBjcmVh dGVfbm9kZShjb25uLCBjdHgsIG5hbWUsIGluLT5idWZmZXIgKyBvZmZzZXQs CiAJCQkJICAgZGF0YWxlbik7CiAJCWlmICghbm9kZSkKIAkJCXJldHVybiBl cnJubzsKQEAgLTE1MDYsMTggKzE1MTIsMTkgQEAgc3RhdGljIGludCBkb193 cml0ZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVk X2RhdGEgKmluKQogCQkJcmV0dXJuIGVycm5vOwogCX0KIAotCWZpcmVfd2F0 Y2hlcyhjb25uLCBpbiwgbmFtZSwgbm9kZSwgZmFsc2UsIE5VTEwpOworCWZp cmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5hbWUsIG5vZGUsIGZhbHNlLCBOVUxM KTsKIAlzZW5kX2Fjayhjb25uLCBYU19XUklURSk7CiAKIAlyZXR1cm4gMDsK IH0KIAotc3RhdGljIGludCBkb19ta2RpcihzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQorc3RhdGljIGludCBk b19ta2Rpcihjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpj b25uLAorCQkgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCXN0 cnVjdCBub2RlICpub2RlOwogCWNoYXIgKm5hbWU7CiAKLQlub2RlID0gZ2V0 X25vZGVfY2Fub25pY2FsaXplZChjb25uLCBpbiwgb25lYXJnKGluKSwgJm5h bWUsCisJbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgY3R4 LCBvbmVhcmcoaW4pLCAmbmFtZSwKIAkJCQkgICAgICBYU19QRVJNX1dSSVRF KTsKIAogCS8qIElmIGl0IGFscmVhZHkgZXhpc3RzLCBmaW5lLiAqLwpAQCAt MTUyNywxMCArMTUzNCwxMCBAQCBzdGF0aWMgaW50IGRvX21rZGlyKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CiAJCQlyZXR1cm4gZXJybm87CiAJCWlmICghbmFtZSkKIAkJCXJldHVybiBF Tk9NRU07Ci0JCW5vZGUgPSBjcmVhdGVfbm9kZShjb25uLCBpbiwgbmFtZSwg TlVMTCwgMCk7CisJCW5vZGUgPSBjcmVhdGVfbm9kZShjb25uLCBjdHgsIG5h bWUsIE5VTEwsIDApOwogCQlpZiAoIW5vZGUpCiAJCQlyZXR1cm4gZXJybm87 Ci0JCWZpcmVfd2F0Y2hlcyhjb25uLCBpbiwgbmFtZSwgbm9kZSwgZmFsc2Us IE5VTEwpOworCQlmaXJlX3dhdGNoZXMoY29ubiwgY3R4LCBuYW1lLCBub2Rl LCBmYWxzZSwgTlVMTCk7CiAJfQogCXNlbmRfYWNrKGNvbm4sIFhTX01LRElS KTsKIApAQCAtMTYyOCwyNCArMTYzNSwyNSBAQCBzdGF0aWMgaW50IF9ybShz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LCBzdHJ1 Y3Qgbm9kZSAqbm9kZSwKIH0KIAogCi1zdGF0aWMgaW50IGRvX3JtKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CitzdGF0aWMgaW50IGRvX3JtKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCisJCSBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CiB7CiAJc3RydWN0IG5vZGUgKm5vZGU7CiAJaW50IHJldDsKIAljaGFyICpu YW1lOwogCWNoYXIgKnBhcmVudG5hbWU7CiAKLQlub2RlID0gZ2V0X25vZGVf Y2Fub25pY2FsaXplZChjb25uLCBpbiwgb25lYXJnKGluKSwgJm5hbWUsCisJ bm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgY3R4LCBvbmVh cmcoaW4pLCAmbmFtZSwKIAkJCQkgICAgICBYU19QRVJNX1dSSVRFKTsKIAlp ZiAoIW5vZGUpIHsKIAkJLyogRGlkbid0IGV4aXN0IGFscmVhZHk/ICBGaW5l LCBpZiBwYXJlbnQgZXhpc3RzLiAqLwogCQlpZiAoZXJybm8gPT0gRU5PRU5U KSB7CiAJCQlpZiAoIW5hbWUpCiAJCQkJcmV0dXJuIEVOT01FTTsKLQkJCXBh cmVudG5hbWUgPSBnZXRfcGFyZW50KGluLCBuYW1lKTsKKwkJCXBhcmVudG5h bWUgPSBnZXRfcGFyZW50KGN0eCwgbmFtZSk7CiAJCQlpZiAoIXBhcmVudG5h bWUpCiAJCQkJcmV0dXJuIGVycm5vOwotCQkJbm9kZSA9IHJlYWRfbm9kZShj b25uLCBpbiwgcGFyZW50bmFtZSk7CisJCQlub2RlID0gcmVhZF9ub2RlKGNv bm4sIGN0eCwgcGFyZW50bmFtZSk7CiAJCQlpZiAobm9kZSkgewogCQkJCXNl bmRfYWNrKGNvbm4sIFhTX1JNKTsKIAkJCQlyZXR1cm4gMDsKQEAgLTE2NjAs NyArMTY2OCw3IEBAIHN0YXRpYyBpbnQgZG9fcm0oc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlpZiAoc3Ry ZXEobmFtZSwgIi8iKSkKIAkJcmV0dXJuIEVJTlZBTDsKIAotCXJldCA9IF9y bShjb25uLCBpbiwgbm9kZSwgbmFtZSk7CisJcmV0ID0gX3JtKGNvbm4sIGN0 eCwgbm9kZSwgbmFtZSk7CiAJaWYgKHJldCkKIAkJcmV0dXJuIHJldDsKIApA QCAtMTY3MCwxMyArMTY3OCwxNSBAQCBzdGF0aWMgaW50IGRvX3JtKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CiB9CiAKIAotc3RhdGljIGludCBkb19nZXRfcGVybXMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKK3N0YXRp YyBpbnQgZG9fZ2V0X3Blcm1zKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCisJCQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CiB7CiAJc3RydWN0IG5vZGUgKm5vZGU7CiAJY2hhciAqc3RyaW5nczsKIAl1 bnNpZ25lZCBpbnQgbGVuOwogCi0Jbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNh bGl6ZWQoY29ubiwgaW4sIG9uZWFyZyhpbiksIE5VTEwsIFhTX1BFUk1fUkVB RCk7CisJbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgY3R4 LCBvbmVhcmcoaW4pLCBOVUxMLAorCQkJCSAgICAgIFhTX1BFUk1fUkVBRCk7 CiAJaWYgKCFub2RlKQogCQlyZXR1cm4gZXJybm87CiAKQEAgLTE2ODksNyAr MTY5OSw4IEBAIHN0YXRpYyBpbnQgZG9fZ2V0X3Blcm1zKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJcmV0 dXJuIDA7CiB9CiAKLXN0YXRpYyBpbnQgZG9fc2V0X3Blcm1zKHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitz dGF0aWMgaW50IGRvX3NldF9wZXJtcyhjb25zdCB2b2lkICpjdHgsIHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAorCQkJc3RydWN0IGJ1ZmZlcmVkX2RhdGEg KmluKQogewogCXN0cnVjdCBub2RlX3Blcm1zIHBlcm1zLCBvbGRfcGVybXM7 CiAJY2hhciAqbmFtZSwgKnBlcm1zdHI7CkBAIC0xNzA2LDcgKzE3MTcsNyBA QCBzdGF0aWMgaW50IGRvX3NldF9wZXJtcyhzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCiAJcGVybXN0ciA9 IGluLT5idWZmZXIgKyBzdHJsZW4oaW4tPmJ1ZmZlcikgKyAxOwogCi0JcGVy bXMucCA9IHRhbGxvY19hcnJheShpbiwgc3RydWN0IHhzX3Blcm1pc3Npb25z LCBwZXJtcy5udW0pOworCXBlcm1zLnAgPSB0YWxsb2NfYXJyYXkoY3R4LCBz dHJ1Y3QgeHNfcGVybWlzc2lvbnMsIHBlcm1zLm51bSk7CiAJaWYgKCFwZXJt cy5wKQogCQlyZXR1cm4gRU5PTUVNOwogCWlmICgheHNfc3RyaW5nc190b19w ZXJtcyhwZXJtcy5wLCBwZXJtcy5udW0sIHBlcm1zdHIpKQpAQCAtMTcyMSw3 ICsxNzMyLDcgQEAgc3RhdGljIGludCBkb19zZXRfcGVybXMoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAl9 CiAKIAkvKiBXZSBtdXN0IG93biBub2RlIHRvIGRvIHRoaXMgKHRvb2xzIGNh biBkbyB0aGlzIHRvbykuICovCi0Jbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNh bGl6ZWQoY29ubiwgaW4sIGluLT5idWZmZXIsICZuYW1lLAorCW5vZGUgPSBn ZXRfbm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGN0eCwgaW4tPmJ1ZmZlciwg Jm5hbWUsCiAJCQkJICAgICAgWFNfUEVSTV9XUklURSB8IFhTX1BFUk1fT1dO RVIpOwogCWlmICghbm9kZSkKIAkJcmV0dXJuIGVycm5vOwpAQCAtMTc1Niw3 ICsxNzY3LDcgQEAgc3RhdGljIGludCBkb19zZXRfcGVybXMoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAkJ cmV0dXJuIGVycm5vOwogCX0KIAotCWZpcmVfd2F0Y2hlcyhjb25uLCBpbiwg bmFtZSwgbm9kZSwgZmFsc2UsICZvbGRfcGVybXMpOworCWZpcmVfd2F0Y2hl cyhjb25uLCBjdHgsIG5hbWUsIG5vZGUsIGZhbHNlLCAmb2xkX3Blcm1zKTsK IAlzZW5kX2Fjayhjb25uLCBYU19TRVRfUEVSTVMpOwogCiAJcmV0dXJuIDA7 CkBAIC0xNzY0LDcgKzE3NzUsOCBAQCBzdGF0aWMgaW50IGRvX3NldF9wZXJt cyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2Rh dGEgKmluKQogCiBzdGF0aWMgc3RydWN0IHsKIAljb25zdCBjaGFyICpzdHI7 Ci0JaW50ICgqZnVuYykoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbik7CisJaW50ICgqZnVuYykoY29uc3Qgdm9p ZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICAgIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbik7CiAJdW5zaWduZWQgaW50IGZsYWdzOwog I2RlZmluZSBYU19GTEFHX05PVElECQkoMVUgPDwgMCkJLyogSWdub3JlIHRy YW5zYWN0aW9uIGlkLiAqLwogI2RlZmluZSBYU19GTEFHX1BSSVYJCSgxVSA8 PCAxKQkvKiBQcml2aWxlZ2VkIGRvbWFpbiBvbmx5LiAqLwpAQCAtMTg0MCw2 ICsxODUyLDcgQEAgc3RhdGljIHZvaWQgcHJvY2Vzc19tZXNzYWdlKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CiAJc3RydWN0IHRyYW5zYWN0aW9uICp0cmFuczsKIAllbnVtIHhzZF9zb2Nr bXNnX3R5cGUgdHlwZSA9IGluLT5oZHIubXNnLnR5cGU7CiAJaW50IHJldDsK Kwl2b2lkICpjdHg7CiAKIAlpZiAoKHVuc2lnbmVkIGludCl0eXBlID49IFhT X1RZUEVfQ09VTlQgfHwgIXdpcmVfZnVuY3NbdHlwZV0uZnVuYykgewogCQll cHJpbnRmKCJDbGllbnQgdW5rbm93biBvcGVyYXRpb24gJWkiLCB0eXBlKTsK QEAgLTE4NjAsMTAgKzE4NzMsMTcgQEAgc3RhdGljIHZvaWQgcHJvY2Vzc19t ZXNzYWdlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pCiAJCXJldHVybjsKIAl9CiAKKwljdHggPSB0YWxsb2Nf bmV3KE5VTEwpOworCWlmICghY3R4KSB7CisJCXNlbmRfZXJyb3IoY29ubiwg RU5PTUVNKTsKKwkJcmV0dXJuOworCX0KKwogCWFzc2VydChjb25uLT50cmFu c2FjdGlvbiA9PSBOVUxMKTsKIAljb25uLT50cmFuc2FjdGlvbiA9IHRyYW5z OwogCi0JcmV0ID0gd2lyZV9mdW5jc1t0eXBlXS5mdW5jKGNvbm4sIGluKTsK KwlyZXQgPSB3aXJlX2Z1bmNzW3R5cGVdLmZ1bmMoY3R4LCBjb25uLCBpbik7 CisJdGFsbG9jX2ZyZWUoY3R4KTsKIAlpZiAocmV0KQogCQlzZW5kX2Vycm9y KGNvbm4sIHJldCk7CiAKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9kb21haW4uYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9k b21haW4uYwppbmRleCAzZDUxNDI1ODEzMzIuLmQyNjJmNGU5ZGJkZiAxMDA2 NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCisr KyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYwpAQCAtMzM2 LDcgKzMzNiw3IEBAIGJvb2wgZG9tYWluX2Nhbl93cml0ZShzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubikKIAlyZXR1cm4gKChpbnRmLT5yc3BfcHJvZCAtIGlu dGYtPnJzcF9jb25zKSAhPSBYRU5TVE9SRV9SSU5HX1NJWkUpOwogfQogCi1z dGF0aWMgY2hhciAqdGFsbG9jX2RvbWFpbl9wYXRoKHZvaWQgKmNvbnRleHQs IHVuc2lnbmVkIGludCBkb21pZCkKK3N0YXRpYyBjaGFyICp0YWxsb2NfZG9t YWluX3BhdGgoY29uc3Qgdm9pZCAqY29udGV4dCwgdW5zaWduZWQgaW50IGRv bWlkKQogewogCXJldHVybiB0YWxsb2NfYXNwcmludGYoY29udGV4dCwgIi9s b2NhbC9kb21haW4vJXUiLCBkb21pZCk7CiB9CkBAIC01NDAsNyArNTQwLDgg QEAgc3RhdGljIHN0cnVjdCBkb21haW4gKmludHJvZHVjZV9kb21haW4oY29u c3Qgdm9pZCAqY3R4LAogfQogCiAvKiBkb21pZCwgZ2ZuLCBldnRjaG4sIHBh dGggKi8KLWludCBkb19pbnRyb2R1Y2Uoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKK2ludCBkb19pbnRyb2R1 Y2UoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwK KwkJIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIHsKIAlzdHJ1Y3QgZG9t YWluICpkb21haW47CiAJY2hhciAqdmVjWzNdOwpAQCAtNTU4LDcgKzU1OSw3 IEBAIGludCBkb19pbnRyb2R1Y2Uoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlpZiAocG9ydCA8PSAwKQog CQlyZXR1cm4gRUlOVkFMOwogCi0JZG9tYWluID0gaW50cm9kdWNlX2RvbWFp bihpbiwgZG9taWQsIHBvcnQsIGZhbHNlKTsKKwlkb21haW4gPSBpbnRyb2R1 Y2VfZG9tYWluKGN0eCwgZG9taWQsIHBvcnQsIGZhbHNlKTsKIAlpZiAoIWRv bWFpbikKIAkJcmV0dXJuIGVycm5vOwogCkBAIC01ODEsNyArNTgyLDggQEAg c3RhdGljIHN0cnVjdCBkb21haW4gKmZpbmRfY29ubmVjdGVkX2RvbWFpbih1 bnNpZ25lZCBpbnQgZG9taWQpCiAJcmV0dXJuIGRvbWFpbjsKIH0KIAotaW50 IGRvX3NldF90YXJnZXQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbikKK2ludCBkb19zZXRfdGFyZ2V0KGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCWNoYXIgKnZlY1syXTsKIAl1 bnNpZ25lZCBpbnQgZG9taWQsIHRkb21pZDsKQEAgLTYyNSw3ICs2MjcsOCBA QCBzdGF0aWMgc3RydWN0IGRvbWFpbiAqb25lYXJnX2RvbWFpbihzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKIH0KIAogLyogZG9taWQgKi8KLWludCBkb19y ZWxlYXNlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pCitpbnQgZG9fcmVsZWFzZShjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCSAgICAgICBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqaW4pCiB7CiAJc3RydWN0IGRvbWFpbiAqZG9tYWluOwog CkBAIC02NDAsNyArNjQzLDggQEAgaW50IGRvX3JlbGVhc2Uoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAly ZXR1cm4gMDsKIH0KIAotaW50IGRvX3Jlc3VtZShzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQoraW50IGRvX3Jl c3VtZShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25u LAorCSAgICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIHsKIAlzdHJ1 Y3QgZG9tYWluICpkb21haW47CiAKQEAgLTY1NSw3ICs2NTksOCBAQCBpbnQg ZG9fcmVzdW1lKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqaW4pCiAJcmV0dXJuIDA7CiB9CiAKLWludCBkb19nZXRf ZG9tYWluX3BhdGgoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBi dWZmZXJlZF9kYXRhICppbikKK2ludCBkb19nZXRfZG9tYWluX3BhdGgoY29u c3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICAg ICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIHsKIAljaGFyICpwYXRo OwogCWNvbnN0IGNoYXIgKmRvbWlkX3N0ciA9IG9uZWFyZyhpbik7CkBAIC02 NjMsMTggKzY2OCwxNyBAQCBpbnQgZG9fZ2V0X2RvbWFpbl9wYXRoKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CiAJaWYgKCFkb21pZF9zdHIpCiAJCXJldHVybiBFSU5WQUw7CiAKLQlwYXRo ID0gdGFsbG9jX2RvbWFpbl9wYXRoKGNvbm4sIGF0b2koZG9taWRfc3RyKSk7 CisJcGF0aCA9IHRhbGxvY19kb21haW5fcGF0aChjdHgsIGF0b2koZG9taWRf c3RyKSk7CiAJaWYgKCFwYXRoKQogCQlyZXR1cm4gZXJybm87CiAKIAlzZW5k X3JlcGx5KGNvbm4sIFhTX0dFVF9ET01BSU5fUEFUSCwgcGF0aCwgc3RybGVu KHBhdGgpICsgMSk7CiAKLQl0YWxsb2NfZnJlZShwYXRoKTsKLQogCXJldHVy biAwOwogfQogCi1pbnQgZG9faXNfZG9tYWluX2ludHJvZHVjZWQoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikK K2ludCBkb19pc19kb21haW5faW50cm9kdWNlZChjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkJICAgIHN0cnVjdCBidWZm ZXJlZF9kYXRhICppbikKIHsKIAlpbnQgcmVzdWx0OwogCXVuc2lnbmVkIGlu dCBkb21pZDsKQEAgLTY5NSw3ICs2OTksOCBAQCBpbnQgZG9faXNfZG9tYWlu X2ludHJvZHVjZWQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBi dWZmZXJlZF9kYXRhICppbikKIH0KIAogLyogQWxsb3cgZ3Vlc3QgdG8gcmVz ZXQgYWxsIHdhdGNoZXMgKi8KLWludCBkb19yZXNldF93YXRjaGVzKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CitpbnQgZG9fcmVzZXRfd2F0Y2hlcyhjb25zdCB2b2lkICpjdHgsIHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAorCQkgICAgIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbikKIHsKIAljb25uX2RlbGV0ZV9hbGxfd2F0Y2hlcyhjb25uKTsK IAljb25uX2RlbGV0ZV9hbGxfdHJhbnNhY3Rpb25zKGNvbm4pOwpkaWZmIC0t Z2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oCmluZGV4IDBmODgzOTM2 ZjQxMy4uZGE1MTM0NDNjZDQ2IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfZG9tYWluLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2RvbWFpbi5oCkBAIC0yNCwyNSArMjQsMzIgQEAgdm9pZCBoYW5k bGVfZXZlbnQodm9pZCk7CiB2b2lkIGNoZWNrX2RvbWFpbnMoYm9vbCByZXN0 b3JlKTsKIAogLyogZG9taWQsIG1mbiwgZXZlbnRjaG4sIHBhdGggKi8KLWlu dCBkb19pbnRyb2R1Y2Uoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbik7CitpbnQgZG9faW50cm9kdWNlKGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOwogCiAvKiBkb21pZCAqLwotaW50IGRv X2lzX2RvbWFpbl9pbnRyb2R1Y2VkKHN0cnVjdCBjb25uZWN0aW9uICpjb25u LCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOworaW50IGRvX2lzX2RvbWFp bl9pbnRyb2R1Y2VkKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sCisJCQkgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsK IAogLyogZG9taWQgKi8KLWludCBkb19yZWxlYXNlKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOworaW50IGRv X3JlbGVhc2UoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwKKwkgICAgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKIAog LyogZG9taWQgKi8KLWludCBkb19yZXN1bWUoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CitpbnQgZG9fcmVz dW1lKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s CisJICAgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKIAogLyogZG9t aWQsIHRhcmdldCAqLwotaW50IGRvX3NldF90YXJnZXQoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CitpbnQg ZG9fc2V0X3RhcmdldChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLAorCQkgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CiAK IC8qIGRvbWlkICovCi1pbnQgZG9fZ2V0X2RvbWFpbl9wYXRoKHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOwor aW50IGRvX2dldF9kb21haW5fcGF0aChjb25zdCB2b2lkICpjdHgsIHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAorCQkgICAgICAgc3RydWN0IGJ1ZmZlcmVk X2RhdGEgKmluKTsKIAogLyogQWxsb3cgZ3Vlc3QgdG8gcmVzZXQgYWxsIHdh dGNoZXMgKi8KLWludCBkb19yZXNldF93YXRjaGVzKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOworaW50IGRv X3Jlc2V0X3dhdGNoZXMoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwKKwkJICAgICBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p OwogCiB2b2lkIGRvbWFpbl9pbml0KGludCBldnRmZCk7CiB2b2lkIGRvbTBf aW5pdCh2b2lkKTsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF90cmFuc2FjdGlvbi5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X3RyYW5zYWN0aW9uLmMKaW5kZXggMjg3NzQ4MTNkZTgzLi4zZTNlYjQ3MzI2 Y2MgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFu c2FjdGlvbi5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFu c2FjdGlvbi5jCkBAIC00ODEsNyArNDgxLDggQEAgc3RydWN0IHRyYW5zYWN0 aW9uICp0cmFuc2FjdGlvbl9sb29rdXAoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sIHVpbnQzMl90IGlkKQogCXJldHVybiBFUlJfUFRSKC1FTk9FTlQpOwog fQogCi1pbnQgZG9fdHJhbnNhY3Rpb25fc3RhcnQoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKK2ludCBkb190 cmFuc2FjdGlvbl9zdGFydChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLAorCQkJIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikK IHsKIAlzdHJ1Y3QgdHJhbnNhY3Rpb24gKnRyYW5zLCAqZXhpc3RzOwogCWNo YXIgaWRfc3RyWzIwXTsKQEAgLTQ5NCw4ICs0OTUsOCBAQCBpbnQgZG9fdHJh bnNhY3Rpb25fc3RhcnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbikKIAkgICAgY29ubi0+dHJhbnNhY3Rpb25f c3RhcnRlZCA+IHF1b3RhX21heF90cmFuc2FjdGlvbikKIAkJcmV0dXJuIEVO T1NQQzsKIAotCS8qIEF0dGFjaCB0cmFuc2FjdGlvbiB0byBpbnB1dCBmb3Ig YXV0b2ZyZWUgdW50aWwgaXQncyBjb21wbGV0ZSAqLwotCXRyYW5zID0gdGFs bG9jX3plcm8oaW4sIHN0cnVjdCB0cmFuc2FjdGlvbik7CisJLyogQXR0YWNo IHRyYW5zYWN0aW9uIHRvIGN0eCBmb3IgYXV0b2ZyZWUgdW50aWwgaXQncyBj b21wbGV0ZSAqLworCXRyYW5zID0gdGFsbG9jX3plcm8oY3R4LCBzdHJ1Y3Qg dHJhbnNhY3Rpb24pOwogCWlmICghdHJhbnMpCiAJCXJldHVybiBFTk9NRU07 CiAKQEAgLTU0NCw3ICs1NDUsOCBAQCBzdGF0aWMgaW50IHRyYW5zYWN0aW9u X2ZpeF9kb21haW5zKHN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnMsIGJvb2wg dXBkYXRlKQogCXJldHVybiAwOwogfQogCi1pbnQgZG9fdHJhbnNhY3Rpb25f ZW5kKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRf ZGF0YSAqaW4pCitpbnQgZG9fdHJhbnNhY3Rpb25fZW5kKGNvbnN0IHZvaWQg KmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICAgICBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJY29uc3QgY2hhciAqYXJnID0g b25lYXJnKGluKTsKIAlzdHJ1Y3QgdHJhbnNhY3Rpb24gKnRyYW5zOwpAQCAt NTYyLDggKzU2NCw4IEBAIGludCBkb190cmFuc2FjdGlvbl9lbmQoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikK IAlpZiAoIWNvbm4tPnRyYW5zYWN0aW9uX3N0YXJ0ZWQpCiAJCWNvbm4tPnRh X3N0YXJ0X3RpbWUgPSAwOwogCi0JLyogQXR0YWNoIHRyYW5zYWN0aW9uIHRv IGluIGZvciBhdXRvLWNsZWFudXAgKi8KLQl0YWxsb2Nfc3RlYWwoaW4sIHRy YW5zKTsKKwkvKiBBdHRhY2ggdHJhbnNhY3Rpb24gdG8gY3R4IGZvciBhdXRv LWNsZWFudXAgKi8KKwl0YWxsb2Nfc3RlYWwoY3R4LCB0cmFucyk7CiAKIAlp ZiAoc3RyZXEoYXJnLCAiVCIpKSB7CiAJCWlmICh0cmFucy0+ZmFpbCkKZGlm ZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlv bi5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgK aW5kZXggZTNjYmQ2YjIzMDk1Li4zOWQ3ZjgxYzUxMjcgMTAwNjQ0Ci0tLSBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCisrKyBi L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCkBAIC0y OSw4ICsyOSwxMCBAQCBzdHJ1Y3QgdHJhbnNhY3Rpb247CiAKIGV4dGVybiB1 aW50NjRfdCBnZW5lcmF0aW9uOwogCi1pbnQgZG9fdHJhbnNhY3Rpb25fc3Rh cnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9k YXRhICpub2RlKTsKLWludCBkb190cmFuc2FjdGlvbl9lbmQoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7Citp bnQgZG9fdHJhbnNhY3Rpb25fc3RhcnQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJCSBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSAqbm9kZSk7CitpbnQgZG9fdHJhbnNhY3Rpb25fZW5kKGNvbnN0IHZvaWQg KmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICAgICBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOwogCiBzdHJ1Y3QgdHJhbnNhY3Rpb24g KnRyYW5zYWN0aW9uX2xvb2t1cChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg dWludDMyX3QgaWQpOwogCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfd2F0Y2guYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93 YXRjaC5jCmluZGV4IDQ5NzBlOWYxYTFiOS4uODU0YmJjYWQ2ZTQ1IDEwMDY0 NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYworKysg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYwpAQCAtMjQzLDcg KzI0Myw3IEBAIHN0YXRpYyBzdHJ1Y3Qgd2F0Y2ggKmFkZF93YXRjaChzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgY2hhciAqcGF0aCwgY2hhciAqdG9rZW4s CiAJcmV0dXJuIE5VTEw7CiB9CiAKLWludCBkb193YXRjaChzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQoraW50 IGRvX3dhdGNoKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIHsKIAlzdHJ1Y3Qg d2F0Y2ggKndhdGNoOwogCWNoYXIgKnZlY1syXTsKQEAgLTI1Miw3ICsyNTIs NyBAQCBpbnQgZG9fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlpZiAoZ2V0X3N0cmluZ3MoaW4s IHZlYywgQVJSQVlfU0laRSh2ZWMpKSAhPSBBUlJBWV9TSVpFKHZlYykpCiAJ CXJldHVybiBFSU5WQUw7CiAKLQllcnJubyA9IGNoZWNrX3dhdGNoX3BhdGgo Y29ubiwgaW4sICYodmVjWzBdKSwgJnJlbGF0aXZlKTsKKwllcnJubyA9IGNo ZWNrX3dhdGNoX3BhdGgoY29ubiwgY3R4LCAmKHZlY1swXSksICZyZWxhdGl2 ZSk7CiAJaWYgKGVycm5vKQogCQlyZXR1cm4gZXJybm87CiAKQEAgLTI4Myw3 ICsyODMsOCBAQCBpbnQgZG9fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlyZXR1cm4gMDsKIH0K IAotaW50IGRvX3Vud2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBidWZmZXJlZF9kYXRhICppbikKK2ludCBkb191bndhdGNoKGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJICAgICAg IHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIHsKIAlzdHJ1Y3Qgd2F0Y2gg KndhdGNoOwogCWNoYXIgKm5vZGUsICp2ZWNbMl07CkBAIC0yOTEsNyArMjky LDcgQEAgaW50IGRvX3Vud2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlpZiAoZ2V0X3N0cmluZ3Mo aW4sIHZlYywgQVJSQVlfU0laRSh2ZWMpKSAhPSBBUlJBWV9TSVpFKHZlYykp CiAJCXJldHVybiBFSU5WQUw7CiAKLQlub2RlID0gY2Fub25pY2FsaXplKGNv bm4sIGluLCB2ZWNbMF0pOworCW5vZGUgPSBjYW5vbmljYWxpemUoY29ubiwg Y3R4LCB2ZWNbMF0pOwogCWlmICghbm9kZSkKIAkJcmV0dXJuIEVOT01FTTsK IAlsaXN0X2Zvcl9lYWNoX2VudHJ5KHdhdGNoLCAmY29ubi0+d2F0Y2hlcywg bGlzdCkgewpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X3dhdGNoLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guaApp bmRleCAwZTY5M2YwODM5Y2QuLjA5MTg5MGVkY2E5NiAxMDA2NDQKLS0tIGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmgKKysrIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmgKQEAgLTIxLDggKzIxLDEwIEBA CiAKICNpbmNsdWRlICJ4ZW5zdG9yZWRfY29yZS5oIgogCi1pbnQgZG9fd2F0 Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbik7Ci1pbnQgZG9fdW53YXRjaChzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKK2ludCBkb193YXRj aChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAor CSAgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKK2ludCBkb191bndh dGNoKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s CisJICAgICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CiAKIC8qIEZp cmUgYWxsIHdhdGNoZXM6ICFleGFjdCBtZWFucyBhbGwgdGhlIGNoaWxkcmVu IGFyZSBhZmZlY3RlZCAoaWUuIHJtKS4gKi8KIHZvaWQgZmlyZV93YXRjaGVz KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICp0bXAsIGNv bnN0IGNoYXIgKm5hbWUsCg== --=separator Content-Type: application/octet-stream; name="xsa416-4.16.patch" Content-Disposition: attachment; filename="xsa416-4.16.patch" Content-Transfer-Encoding: base64 RnJvbSA4MGQxMjhiMTQ0ODJkMmU5MzQyMTg0ZDJkOTk0OTM2Nzg1MWM0ZDE0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGRvbid0IHVz ZSBjb25uLT5pbiBhcyBjb250ZXh0IGZvciB0ZW1wb3JhcnkKIGFsbG9jYXRp b25zCgpVc2luZyB0aGUgc3RydWN0IGJ1ZmZlcmVkIGRhdGEgcG9pbnRlciBv ZiB0aGUgY3VycmVudCBwcm9jZXNzZWQgcmVxdWVzdApmb3IgdGVtcG9yYXJ5 IGRhdGEgYWxsb2NhdGlvbnMgaGFzIGEgbWFqb3IgZHJhd2JhY2s6IHRoZSB1 c2VkIGFyZWEgKGFuZAp3aXRoIHRoYXQgdGhlIHRlbXBvcmFyeSBkYXRhKSBp cyBmcmVlZCBvbmx5IGFmdGVyIHRoZSByZXNwb25zZSBvZiB0aGUKcmVxdWVz dCBoYXMgYmVlbiB3cml0dGVuIHRvIHRoZSByaW5nIHBhZ2Ugb3IgaGFzIGJl ZW4gcmVhZCB2aWEgdGhlCnNvY2tldC4gVGhpcyBjYW4gaGFwcGVuIG11Y2gg bGF0ZXIgaW4gY2FzZSBhIGd1ZXN0IGlzbid0IHJlYWRpbmcgaXRzCnJlc3Bv bnNlcyBmYXN0IGVub3VnaC4KCkFzIHRoZSB0ZW1wb3JhcnkgZGF0YSBjYW4g YmUgc2FmZWx5IGZyZWVkIGFmdGVyIGNyZWF0aW5nIHRoZSByZXNwb25zZSwK YWRkIGEgdGVtcG9yYXJ5IGNvbnRleHQgZm9yIHRoYXQgcHVycG9zZSBhbmQg dXNlIHRoYXQgZm9yIGFsbG9jYXRpbmcKdGhlIHRlbXBvcmFyeSBtZW1vcnks IGFzIGl0IHdhcyBhbHJlYWR5IHRoZSBjYXNlIGJlZm9yZSBjb21taXQKY2Mw NjEyNDY0ODk2ICgieGVuc3RvcmU6IGFkZCBzbWFsbCBkZWZhdWx0IGRhdGEg YnVmZmVyIHRvIGludGVybmFsCnN0cnVjdCIpLgoKU29tZSBzdWItZnVuY3Rp b25zIG5lZWQgdG8gZ2FpbiB0aGUgImNvbnN0IiBhdHRyaWJ1dGUgZm9yIHRo ZSB0YWxsb2MKY29udGV4dC4KClRoaXMgaXMgWFNBLTQxNiAvIENWRS0yMDIy LTQyMzE5LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+CkZpeGVzOiBjYzA2MTI0NjQ4OTYgKCJ4ZW5zdG9yZTogYWRk IHNtYWxsIGRlZmF1bHQgZGF0YSBidWZmZXIgdG8gaW50ZXJuYWwgc3RydWN0 IikKU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29udHJvbC5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wu YwppbmRleCAxMDMxYTgxYzM4NzQuLmQwMzUwYzZhZDg2MSAxMDA2NDQKLS0t IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuYworKysgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jCkBAIC0xNTUsNyAr MTU1LDcgQEAgYm9vbCBsdV9pc19wZW5kaW5nKHZvaWQpCiAKIHN0cnVjdCBj bWRfcyB7CiAJY2hhciAqY21kOwotCWludCAoKmZ1bmMpKHZvaWQgKiwgc3Ry dWN0IGNvbm5lY3Rpb24gKiwgY2hhciAqKiwgaW50KTsKKwlpbnQgKCpmdW5j KShjb25zdCB2b2lkICosIHN0cnVjdCBjb25uZWN0aW9uICosIGNoYXIgKios IGludCk7CiAJY2hhciAqcGFyczsKIAkvKgogCSAqIG1heF9wYXJzIGNhbiBi ZSB1c2VkIHRvIGxpbWl0IHRoZSBzaXplIG9mIHRoZSBwYXJhbWV0ZXIgdmVj dG9yLApAQCAtMTY3LDcgKzE2Nyw3IEBAIHN0cnVjdCBjbWRfcyB7CiAJdW5z aWduZWQgaW50IG1heF9wYXJzOwogfTsKIAotc3RhdGljIGludCBkb19jb250 cm9sX2NoZWNrKHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s CitzdGF0aWMgaW50IGRvX2NvbnRyb2xfY2hlY2soY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJCSAgICBjaGFyICoqdmVj LCBpbnQgbnVtKQogewogCWlmIChudW0pCkBAIC0xNzksNyArMTc5LDcgQEAg c3RhdGljIGludCBkb19jb250cm9sX2NoZWNrKHZvaWQgKmN0eCwgc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sCiAJcmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBp bnQgZG9fY29udHJvbF9sb2codm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwKK3N0YXRpYyBpbnQgZG9fY29udHJvbF9sb2coY29uc3Qgdm9p ZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJCSAgY2hhciAq KnZlYywgaW50IG51bSkKIHsKIAlpZiAobnVtICE9IDEpCkBAIC0yODEsNyAr MjgxLDcgQEAgc3RhdGljIGludCBxdW90YV9nZXQoY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAlyZXR1cm4gZG9tYWluX2dl dF9xdW90YShjdHgsIGNvbm4sIGF0b2kodmVjWzBdKSk7CiB9CiAKLXN0YXRp YyBpbnQgZG9fY29udHJvbF9xdW90YSh2b2lkICpjdHgsIHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLAorc3RhdGljIGludCBkb19jb250cm9sX3F1b3RhKGNv bnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQkg ICAgY2hhciAqKnZlYywgaW50IG51bSkKIHsKIAlpZiAobnVtID09IDApCkBA IC0yOTMsNyArMjkzLDcgQEAgc3RhdGljIGludCBkb19jb250cm9sX3F1b3Rh KHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJcmV0dXJu IHF1b3RhX2dldChjdHgsIGNvbm4sIHZlYywgbnVtKTsKIH0KIAotc3RhdGlj IGludCBkb19jb250cm9sX3F1b3RhX3Modm9pZCAqY3R4LCBzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwKK3N0YXRpYyBpbnQgZG9fY29udHJvbF9xdW90YV9z KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJ CQkgICAgICBjaGFyICoqdmVjLCBpbnQgbnVtKQogewogCWlmIChudW0gPT0g MCkKQEAgLTMwNiw3ICszMDYsNyBAQCBzdGF0aWMgaW50IGRvX2NvbnRyb2xf cXVvdGFfcyh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAog fQogCiAjaWZkZWYgX19NSU5JT1NfXwotc3RhdGljIGludCBkb19jb250cm9s X21lbXJlcG9ydCh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25u LAorc3RhdGljIGludCBkb19jb250cm9sX21lbXJlcG9ydChjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCQkJCWNoYXIgKip2 ZWMsIGludCBudW0pCiB7CiAJaWYgKG51bSkKQEAgLTMxOCw3ICszMTgsNyBA QCBzdGF0aWMgaW50IGRvX2NvbnRyb2xfbWVtcmVwb3J0KHZvaWQgKmN0eCwg c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJcmV0dXJuIDA7CiB9CiAjZWxz ZQotc3RhdGljIGludCBkb19jb250cm9sX2xvZ2ZpbGUodm9pZCAqY3R4LCBz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKK3N0YXRpYyBpbnQgZG9fY29udHJv bF9sb2dmaWxlKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sCiAJCQkgICAgICBjaGFyICoqdmVjLCBpbnQgbnVtKQogewogCWlm IChudW0gIT0gMSkKQEAgLTMzMyw3ICszMzMsNyBAQCBzdGF0aWMgaW50IGRv X2NvbnRyb2xfbG9nZmlsZSh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAogCXJldHVybiAwOwogfQogCi1zdGF0aWMgaW50IGRvX2NvbnRy b2xfbWVtcmVwb3J0KHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sCitzdGF0aWMgaW50IGRvX2NvbnRyb2xfbWVtcmVwb3J0KGNvbnN0IHZv aWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQkJY2hhciAq KnZlYywgaW50IG51bSkKIHsKIAlGSUxFICpmcDsKQEAgLTM3Myw3ICszNzMs NyBAQCBzdGF0aWMgaW50IGRvX2NvbnRyb2xfbWVtcmVwb3J0KHZvaWQgKmN0 eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiB9CiAjZW5kaWYKIAotc3Rh dGljIGludCBkb19jb250cm9sX3ByaW50KHZvaWQgKmN0eCwgc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCitzdGF0aWMgaW50IGRvX2NvbnRyb2xfcHJpbnQo Y29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJ CSAgICBjaGFyICoqdmVjLCBpbnQgbnVtKQogewogCWlmIChudW0gIT0gMSkK QEAgLTg3NSw3ICs4NzUsNyBAQCBzdGF0aWMgY29uc3QgY2hhciAqbHVfc3Rh cnQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwK IAlyZXR1cm4gTlVMTDsKIH0KIAotc3RhdGljIGludCBkb19jb250cm9sX2x1 KHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCitzdGF0aWMg aW50IGRvX2NvbnRyb2xfbHUoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwKIAkJCSBjaGFyICoqdmVjLCBpbnQgbnVtKQogewog CWNvbnN0IGNoYXIgKnJldCA9IE5VTEw7CkBAIC05MjIsNyArOTIyLDcgQEAg c3RhdGljIGludCBkb19jb250cm9sX2x1KHZvaWQgKmN0eCwgc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCiB9CiAjZW5kaWYKIAotc3RhdGljIGludCBkb19j b250cm9sX2hlbHAodm9pZCAqLCBzdHJ1Y3QgY29ubmVjdGlvbiAqLCBjaGFy ICoqLCBpbnQpOworc3RhdGljIGludCBkb19jb250cm9sX2hlbHAoY29uc3Qg dm9pZCAqLCBzdHJ1Y3QgY29ubmVjdGlvbiAqLCBjaGFyICoqLCBpbnQpOwog CiBzdGF0aWMgc3RydWN0IGNtZF9zIGNtZHNbXSA9IHsKIAl7ICJjaGVjayIs IGRvX2NvbnRyb2xfY2hlY2ssICIiIH0sCkBAIC05NjEsNyArOTYxLDcgQEAg c3RhdGljIHN0cnVjdCBjbWRfcyBjbWRzW10gPSB7CiAJeyAiaGVscCIsIGRv X2NvbnRyb2xfaGVscCwgIiIgfSwKIH07CiAKLXN0YXRpYyBpbnQgZG9fY29u dHJvbF9oZWxwKHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s CitzdGF0aWMgaW50IGRvX2NvbnRyb2xfaGVscChjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCQkJICAgY2hhciAqKnZlYywg aW50IG51bSkKIHsKIAlpbnQgY21kLCBsZW4gPSAwOwpAQCAtOTk3LDcgKzk5 Nyw4IEBAIHN0YXRpYyBpbnQgZG9fY29udHJvbF9oZWxwKHZvaWQgKmN0eCwg c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJcmV0dXJuIDA7CiB9CiAKLWlu dCBkb19jb250cm9sKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qg YnVmZmVyZWRfZGF0YSAqaW4pCitpbnQgZG9fY29udHJvbChjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCSAgICAgICBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJdW5zaWduZWQgaW50IGNtZCwg bnVtLCBvZmY7CiAJY2hhciAqKnZlYyA9IE5VTEw7CkBAIC0xMDE3LDExICsx MDE4LDExIEBAIGludCBkb19jb250cm9sKHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJbnVtID0geHNfY291 bnRfc3RyaW5ncyhpbi0+YnVmZmVyLCBpbi0+dXNlZCk7CiAJaWYgKGNtZHNb Y21kXS5tYXhfcGFycykKIAkJbnVtID0gbWluKG51bSwgY21kc1tjbWRdLm1h eF9wYXJzKTsKLQl2ZWMgPSB0YWxsb2NfYXJyYXkoaW4sIGNoYXIgKiwgbnVt KTsKKwl2ZWMgPSB0YWxsb2NfYXJyYXkoY3R4LCBjaGFyICosIG51bSk7CiAJ aWYgKCF2ZWMpCiAJCXJldHVybiBFTk9NRU07CiAJaWYgKGdldF9zdHJpbmdz KGluLCB2ZWMsIG51bSkgPCBudW0pCiAJCXJldHVybiBFSU87CiAKLQlyZXR1 cm4gY21kc1tjbWRdLmZ1bmMoaW4sIGNvbm4sIHZlYyArIDEsIG51bSAtIDEp OworCXJldHVybiBjbWRzW2NtZF0uZnVuYyhjdHgsIGNvbm4sIHZlYyArIDEs IG51bSAtIDEpOwogfQpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvbnRyb2wuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b250cm9sLmgKaW5kZXggOThiNmZiY2VhMmIxLi5hOGNiNzY1NTliYTEgMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmgK KysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuaApAQCAt MTYsNyArMTYsOCBAQAogICAgIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtOyBJ ZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCiAq LwogCi1pbnQgZG9fY29udHJvbChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg c3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKK2ludCBkb19jb250cm9sKGNv bnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJICAg ICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CiB2b2lkIGx1X3JlYWRf c3RhdGUodm9pZCk7CiAKIHN0cnVjdCBjb25uZWN0aW9uICpsdV9nZXRfY29u bmVjdGlvbih2b2lkKTsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29y ZS5jCmluZGV4IDE2NTA0ZGU0MjAxNy4uNDExY2MwZTQ0NzE0IDEwMDY0NAot LS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTEyNDgsMTEgKzEy NDgsMTMgQEAgc3RhdGljIHN0cnVjdCBub2RlICpnZXRfbm9kZV9jYW5vbmlj YWxpemVkKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCXJldHVybiBnZXRf bm9kZShjb25uLCBjdHgsICpjYW5vbmljYWxfbmFtZSwgcGVybSk7CiB9CiAK LXN0YXRpYyBpbnQgc2VuZF9kaXJlY3Rvcnkoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKK3N0YXRpYyBpbnQg c2VuZF9kaXJlY3RvcnkoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwKKwkJCSAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQog ewogCXN0cnVjdCBub2RlICpub2RlOwogCi0Jbm9kZSA9IGdldF9ub2RlX2Nh bm9uaWNhbGl6ZWQoY29ubiwgaW4sIG9uZWFyZyhpbiksIE5VTEwsIFhTX1BF Uk1fUkVBRCk7CisJbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29u biwgY3R4LCBvbmVhcmcoaW4pLCBOVUxMLAorCQkJCSAgICAgIFhTX1BFUk1f UkVBRCk7CiAJaWYgKCFub2RlKQogCQlyZXR1cm4gZXJybm87CiAKQEAgLTEy NjEsNyArMTI2Myw3IEBAIHN0YXRpYyBpbnQgc2VuZF9kaXJlY3Rvcnkoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICpp bikKIAlyZXR1cm4gMDsKIH0KIAotc3RhdGljIGludCBzZW5kX2RpcmVjdG9y eV9wYXJ0KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorc3RhdGljIGludCBz ZW5kX2RpcmVjdG9yeV9wYXJ0KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCiAJCQkgICAgICAgc3RydWN0IGJ1ZmZlcmVkX2Rh dGEgKmluKQogewogCXVuc2lnbmVkIGludCBvZmYsIGxlbiwgbWF4bGVuLCBn ZW5sZW47CkBAIC0xMjczLDcgKzEyNzUsOCBAQCBzdGF0aWMgaW50IHNlbmRf ZGlyZWN0b3J5X3BhcnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCXJl dHVybiBFSU5WQUw7CiAKIAkvKiBGaXJzdCBhcmcgaXMgbm9kZSBuYW1lLiAq LwotCW5vZGUgPSBnZXRfbm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGluLCBp bi0+YnVmZmVyLCBOVUxMLCBYU19QRVJNX1JFQUQpOworCW5vZGUgPSBnZXRf bm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGN0eCwgaW4tPmJ1ZmZlciwgTlVM TCwKKwkJCQkgICAgICBYU19QRVJNX1JFQUQpOwogCWlmICghbm9kZSkKIAkJ cmV0dXJuIGVycm5vOwogCkBAIC0xMzAwLDcgKzEzMDMsNyBAQCBzdGF0aWMg aW50IHNlbmRfZGlyZWN0b3J5X3BhcnQoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sCiAJCQlicmVhazsKIAl9CiAKLQlkYXRhID0gdGFsbG9jX2FycmF5KGlu LCBjaGFyLCBnZW5sZW4gKyBsZW4gKyAxKTsKKwlkYXRhID0gdGFsbG9jX2Fy cmF5KGN0eCwgY2hhciwgZ2VubGVuICsgbGVuICsgMSk7CiAJaWYgKCFkYXRh KQogCQlyZXR1cm4gRU5PTUVNOwogCkBAIC0xMzE2LDExICsxMzE5LDEzIEBA IHN0YXRpYyBpbnQgc2VuZF9kaXJlY3RvcnlfcGFydChzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwKIAlyZXR1cm4gMDsKIH0KIAotc3RhdGljIGludCBkb19y ZWFkKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRf ZGF0YSAqaW4pCitzdGF0aWMgaW50IGRvX3JlYWQoY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICAgc3RydWN0IGJ1ZmZl cmVkX2RhdGEgKmluKQogewogCXN0cnVjdCBub2RlICpub2RlOwogCi0Jbm9k ZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgaW4sIG9uZWFyZyhp biksIE5VTEwsIFhTX1BFUk1fUkVBRCk7CisJbm9kZSA9IGdldF9ub2RlX2Nh bm9uaWNhbGl6ZWQoY29ubiwgY3R4LCBvbmVhcmcoaW4pLCBOVUxMLAorCQkJ CSAgICAgIFhTX1BFUk1fUkVBRCk7CiAJaWYgKCFub2RlKQogCQlyZXR1cm4g ZXJybm87CiAKQEAgLTE1MTAsNyArMTUxNSw4IEBAIHN0YXRpYyBzdHJ1Y3Qg bm9kZSAqY3JlYXRlX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNv bnN0IHZvaWQgKmN0eCwKIH0KIAogLyogcGF0aCwgZGF0YS4uLiAqLwotc3Rh dGljIGludCBkb193cml0ZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQorc3RhdGljIGludCBkb193cml0ZShj b25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkg ICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCXVuc2lnbmVkIGlu dCBvZmZzZXQsIGRhdGFsZW47CiAJc3RydWN0IG5vZGUgKm5vZGU7CkBAIC0x NTI0LDEyICsxNTMwLDEyIEBAIHN0YXRpYyBpbnQgZG9fd3JpdGUoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikK IAlvZmZzZXQgPSBzdHJsZW4odmVjWzBdKSArIDE7CiAJZGF0YWxlbiA9IGlu LT51c2VkIC0gb2Zmc2V0OwogCi0Jbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNh bGl6ZWQoY29ubiwgaW4sIHZlY1swXSwgJm5hbWUsIFhTX1BFUk1fV1JJVEUp OworCW5vZGUgPSBnZXRfbm9kZV9jYW5vbmljYWxpemVkKGNvbm4sIGN0eCwg dmVjWzBdLCAmbmFtZSwgWFNfUEVSTV9XUklURSk7CiAJaWYgKCFub2RlKSB7 CiAJCS8qIE5vIHBlcm1pc3Npb25zLCBpbnZhbGlkIGlucHV0PyAqLwogCQlp ZiAoZXJybm8gIT0gRU5PRU5UKQogCQkJcmV0dXJuIGVycm5vOwotCQlub2Rl ID0gY3JlYXRlX25vZGUoY29ubiwgaW4sIG5hbWUsIGluLT5idWZmZXIgKyBv ZmZzZXQsCisJCW5vZGUgPSBjcmVhdGVfbm9kZShjb25uLCBjdHgsIG5hbWUs IGluLT5idWZmZXIgKyBvZmZzZXQsCiAJCQkJICAgZGF0YWxlbik7CiAJCWlm ICghbm9kZSkKIAkJCXJldHVybiBlcnJubzsKQEAgLTE1NDAsMTggKzE1NDYs MTkgQEAgc3RhdGljIGludCBkb193cml0ZShzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCQkJcmV0dXJuIGVy cm5vOwogCX0KIAotCWZpcmVfd2F0Y2hlcyhjb25uLCBpbiwgbmFtZSwgbm9k ZSwgZmFsc2UsIE5VTEwpOworCWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5h bWUsIG5vZGUsIGZhbHNlLCBOVUxMKTsKIAlzZW5kX2Fjayhjb25uLCBYU19X UklURSk7CiAKIAlyZXR1cm4gMDsKIH0KIAotc3RhdGljIGludCBkb19ta2Rp cihzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2Rh dGEgKmluKQorc3RhdGljIGludCBkb19ta2Rpcihjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgICAgc3RydWN0IGJ1ZmZl cmVkX2RhdGEgKmluKQogewogCXN0cnVjdCBub2RlICpub2RlOwogCWNoYXIg Km5hbWU7CiAKLQlub2RlID0gZ2V0X25vZGVfY2Fub25pY2FsaXplZChjb25u LCBpbiwgb25lYXJnKGluKSwgJm5hbWUsCisJbm9kZSA9IGdldF9ub2RlX2Nh bm9uaWNhbGl6ZWQoY29ubiwgY3R4LCBvbmVhcmcoaW4pLCAmbmFtZSwKIAkJ CQkgICAgICBYU19QRVJNX1dSSVRFKTsKIAogCS8qIElmIGl0IGFscmVhZHkg ZXhpc3RzLCBmaW5lLiAqLwpAQCAtMTU2MSwxMCArMTU2OCwxMCBAQCBzdGF0 aWMgaW50IGRvX21rZGlyKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJCQlyZXR1cm4gZXJybm87CiAJCWlm ICghbmFtZSkKIAkJCXJldHVybiBFTk9NRU07Ci0JCW5vZGUgPSBjcmVhdGVf bm9kZShjb25uLCBpbiwgbmFtZSwgTlVMTCwgMCk7CisJCW5vZGUgPSBjcmVh dGVfbm9kZShjb25uLCBjdHgsIG5hbWUsIE5VTEwsIDApOwogCQlpZiAoIW5v ZGUpCiAJCQlyZXR1cm4gZXJybm87Ci0JCWZpcmVfd2F0Y2hlcyhjb25uLCBp biwgbmFtZSwgbm9kZSwgZmFsc2UsIE5VTEwpOworCQlmaXJlX3dhdGNoZXMo Y29ubiwgY3R4LCBuYW1lLCBub2RlLCBmYWxzZSwgTlVMTCk7CiAJfQogCXNl bmRfYWNrKGNvbm4sIFhTX01LRElSKTsKIApAQCAtMTY2MiwyNCArMTY2OSwy NSBAQCBzdGF0aWMgaW50IF9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIH0KIAogCi1z dGF0aWMgaW50IGRvX3JtKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitzdGF0aWMgaW50IGRvX3JtKGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJc3RydWN0IG5vZGUgKm5vZGU7 CiAJaW50IHJldDsKIAljaGFyICpuYW1lOwogCWNoYXIgKnBhcmVudG5hbWU7 CiAKLQlub2RlID0gZ2V0X25vZGVfY2Fub25pY2FsaXplZChjb25uLCBpbiwg b25lYXJnKGluKSwgJm5hbWUsCisJbm9kZSA9IGdldF9ub2RlX2Nhbm9uaWNh bGl6ZWQoY29ubiwgY3R4LCBvbmVhcmcoaW4pLCAmbmFtZSwKIAkJCQkgICAg ICBYU19QRVJNX1dSSVRFKTsKIAlpZiAoIW5vZGUpIHsKIAkJLyogRGlkbid0 IGV4aXN0IGFscmVhZHk/ICBGaW5lLCBpZiBwYXJlbnQgZXhpc3RzLiAqLwog CQlpZiAoZXJybm8gPT0gRU5PRU5UKSB7CiAJCQlpZiAoIW5hbWUpCiAJCQkJ cmV0dXJuIEVOT01FTTsKLQkJCXBhcmVudG5hbWUgPSBnZXRfcGFyZW50KGlu LCBuYW1lKTsKKwkJCXBhcmVudG5hbWUgPSBnZXRfcGFyZW50KGN0eCwgbmFt ZSk7CiAJCQlpZiAoIXBhcmVudG5hbWUpCiAJCQkJcmV0dXJuIGVycm5vOwot CQkJbm9kZSA9IHJlYWRfbm9kZShjb25uLCBpbiwgcGFyZW50bmFtZSk7CisJ CQlub2RlID0gcmVhZF9ub2RlKGNvbm4sIGN0eCwgcGFyZW50bmFtZSk7CiAJ CQlpZiAobm9kZSkgewogCQkJCXNlbmRfYWNrKGNvbm4sIFhTX1JNKTsKIAkJ CQlyZXR1cm4gMDsKQEAgLTE2OTQsNyArMTcwMiw3IEBAIHN0YXRpYyBpbnQg ZG9fcm0oc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbikKIAlpZiAoc3RyZXEobmFtZSwgIi8iKSkKIAkJcmV0dXJu IEVJTlZBTDsKIAotCXJldCA9IF9ybShjb25uLCBpbiwgbm9kZSwgbmFtZSk7 CisJcmV0ID0gX3JtKGNvbm4sIGN0eCwgbm9kZSwgbmFtZSk7CiAJaWYgKHJl dCkKIAkJcmV0dXJuIHJldDsKIApAQCAtMTcwNCwxMyArMTcxMiwxNSBAQCBz dGF0aWMgaW50IGRvX3JtKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB9CiAKIAotc3RhdGljIGludCBkb19n ZXRfcGVybXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZm ZXJlZF9kYXRhICppbikKK3N0YXRpYyBpbnQgZG9fZ2V0X3Blcm1zKGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCQlzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJc3RydWN0IG5vZGUgKm5vZGU7 CiAJY2hhciAqc3RyaW5nczsKIAl1bnNpZ25lZCBpbnQgbGVuOwogCi0Jbm9k ZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgaW4sIG9uZWFyZyhp biksIE5VTEwsIFhTX1BFUk1fUkVBRCk7CisJbm9kZSA9IGdldF9ub2RlX2Nh bm9uaWNhbGl6ZWQoY29ubiwgY3R4LCBvbmVhcmcoaW4pLCBOVUxMLAorCQkJ CSAgICAgIFhTX1BFUk1fUkVBRCk7CiAJaWYgKCFub2RlKQogCQlyZXR1cm4g ZXJybm87CiAKQEAgLTE3MjMsNyArMTczMyw4IEBAIHN0YXRpYyBpbnQgZG9f Z2V0X3Blcm1zKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqaW4pCiAJcmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBpbnQg ZG9fc2V0X3Blcm1zKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qg YnVmZmVyZWRfZGF0YSAqaW4pCitzdGF0aWMgaW50IGRvX3NldF9wZXJtcyhj b25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkJ c3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogewogCXN0cnVjdCBub2RlX3Bl cm1zIHBlcm1zLCBvbGRfcGVybXM7CiAJY2hhciAqbmFtZSwgKnBlcm1zdHI7 CkBAIC0xNzQwLDcgKzE3NTEsNyBAQCBzdGF0aWMgaW50IGRvX3NldF9wZXJt cyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2Rh dGEgKmluKQogCiAJcGVybXN0ciA9IGluLT5idWZmZXIgKyBzdHJsZW4oaW4t PmJ1ZmZlcikgKyAxOwogCi0JcGVybXMucCA9IHRhbGxvY19hcnJheShpbiwg c3RydWN0IHhzX3Blcm1pc3Npb25zLCBwZXJtcy5udW0pOworCXBlcm1zLnAg PSB0YWxsb2NfYXJyYXkoY3R4LCBzdHJ1Y3QgeHNfcGVybWlzc2lvbnMsIHBl cm1zLm51bSk7CiAJaWYgKCFwZXJtcy5wKQogCQlyZXR1cm4gRU5PTUVNOwog CWlmICgheHNfc3RyaW5nc190b19wZXJtcyhwZXJtcy5wLCBwZXJtcy5udW0s IHBlcm1zdHIpKQpAQCAtMTc1NSw3ICsxNzY2LDcgQEAgc3RhdGljIGludCBk b19zZXRfcGVybXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBi dWZmZXJlZF9kYXRhICppbikKIAl9CiAKIAkvKiBXZSBtdXN0IG93biBub2Rl IHRvIGRvIHRoaXMgKHRvb2xzIGNhbiBkbyB0aGlzIHRvbykuICovCi0Jbm9k ZSA9IGdldF9ub2RlX2Nhbm9uaWNhbGl6ZWQoY29ubiwgaW4sIGluLT5idWZm ZXIsICZuYW1lLAorCW5vZGUgPSBnZXRfbm9kZV9jYW5vbmljYWxpemVkKGNv bm4sIGN0eCwgaW4tPmJ1ZmZlciwgJm5hbWUsCiAJCQkJICAgICAgWFNfUEVS TV9XUklURSB8IFhTX1BFUk1fT1dORVIpOwogCWlmICghbm9kZSkKIAkJcmV0 dXJuIGVycm5vOwpAQCAtMTc5MCw3ICsxODAxLDcgQEAgc3RhdGljIGludCBk b19zZXRfcGVybXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBi dWZmZXJlZF9kYXRhICppbikKIAkJcmV0dXJuIGVycm5vOwogCX0KIAotCWZp cmVfd2F0Y2hlcyhjb25uLCBpbiwgbmFtZSwgbm9kZSwgZmFsc2UsICZvbGRf cGVybXMpOworCWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5hbWUsIG5vZGUs IGZhbHNlLCAmb2xkX3Blcm1zKTsKIAlzZW5kX2Fjayhjb25uLCBYU19TRVRf UEVSTVMpOwogCiAJcmV0dXJuIDA7CkBAIC0xNzk4LDcgKzE4MDksOCBAQCBz dGF0aWMgaW50IGRvX3NldF9wZXJtcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCiBzdGF0aWMgc3RydWN0 IHsKIAljb25zdCBjaGFyICpzdHI7Ci0JaW50ICgqZnVuYykoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CisJ aW50ICgqZnVuYykoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwKKwkJICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CiAJ dW5zaWduZWQgaW50IGZsYWdzOwogI2RlZmluZSBYU19GTEFHX05PVElECQko MVUgPDwgMCkJLyogSWdub3JlIHRyYW5zYWN0aW9uIGlkLiAqLwogI2RlZmlu ZSBYU19GTEFHX1BSSVYJCSgxVSA8PCAxKQkvKiBQcml2aWxlZ2VkIGRvbWFp biBvbmx5LiAqLwpAQCAtMTg3NCw2ICsxODg2LDcgQEAgc3RhdGljIHZvaWQg cHJvY2Vzc19tZXNzYWdlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJc3RydWN0IHRyYW5zYWN0aW9uICp0 cmFuczsKIAllbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSA9IGluLT5oZHIu bXNnLnR5cGU7CiAJaW50IHJldDsKKwl2b2lkICpjdHg7CiAKIAkvKiBBdCBs ZWFzdCBzZW5kX2Vycm9yKCkgYW5kIHNlbmRfcmVwbHkoKSBleHBlY3RzIGNv bm4tPmluID09IGluICovCiAJYXNzZXJ0KGNvbm4tPmluID09IGluKTsKQEAg LTE4OTgsMTAgKzE5MTEsMTcgQEAgc3RhdGljIHZvaWQgcHJvY2Vzc19tZXNz YWdlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRf ZGF0YSAqaW4pCiAJCXJldHVybjsKIAl9CiAKKwljdHggPSB0YWxsb2NfbmV3 KE5VTEwpOworCWlmICghY3R4KSB7CisJCXNlbmRfZXJyb3IoY29ubiwgRU5P TUVNKTsKKwkJcmV0dXJuOworCX0KKwogCWFzc2VydChjb25uLT50cmFuc2Fj dGlvbiA9PSBOVUxMKTsKIAljb25uLT50cmFuc2FjdGlvbiA9IHRyYW5zOwog Ci0JcmV0ID0gd2lyZV9mdW5jc1t0eXBlXS5mdW5jKGNvbm4sIGluKTsKKwly ZXQgPSB3aXJlX2Z1bmNzW3R5cGVdLmZ1bmMoY3R4LCBjb25uLCBpbik7CisJ dGFsbG9jX2ZyZWUoY3R4KTsKIAlpZiAocmV0KQogCQlzZW5kX2Vycm9yKGNv bm4sIHJldCk7CiAKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9kb21haW4uYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21h aW4uYwppbmRleCBlN2M2ODg2Y2NmNDcuLmZiNzMyZDBhMTRjMyAxMDA2NDQK LS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCisrKyBi L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYwpAQCAtMzMwLDcg KzMzMCw3IEBAIGJvb2wgZG9tYWluX2lzX3VucHJpdmlsZWdlZChzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubikKIAkgICAgICAgZG9taWRfaXNfdW5wcml2aWxl Z2VkKGNvbm4tPmRvbWFpbi0+ZG9taWQpOwogfQogCi1zdGF0aWMgY2hhciAq dGFsbG9jX2RvbWFpbl9wYXRoKHZvaWQgKmNvbnRleHQsIHVuc2lnbmVkIGlu dCBkb21pZCkKK3N0YXRpYyBjaGFyICp0YWxsb2NfZG9tYWluX3BhdGgoY29u c3Qgdm9pZCAqY29udGV4dCwgdW5zaWduZWQgaW50IGRvbWlkKQogewogCXJl dHVybiB0YWxsb2NfYXNwcmludGYoY29udGV4dCwgIi9sb2NhbC9kb21haW4v JXUiLCBkb21pZCk7CiB9CkBAIC01MzQsNyArNTM0LDggQEAgc3RhdGljIHN0 cnVjdCBkb21haW4gKmludHJvZHVjZV9kb21haW4oY29uc3Qgdm9pZCAqY3R4 LAogfQogCiAvKiBkb21pZCwgZ2ZuLCBldnRjaG4sIHBhdGggKi8KLWludCBk b19pbnRyb2R1Y2Uoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBi dWZmZXJlZF9kYXRhICppbikKK2ludCBkb19pbnRyb2R1Y2UoY29uc3Qgdm9p ZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJIHN0cnVjdCBi dWZmZXJlZF9kYXRhICppbikKIHsKIAlzdHJ1Y3QgZG9tYWluICpkb21haW47 CiAJY2hhciAqdmVjWzNdOwpAQCAtNTUyLDcgKzU1Myw3IEBAIGludCBkb19p bnRyb2R1Y2Uoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZm ZXJlZF9kYXRhICppbikKIAlpZiAocG9ydCA8PSAwKQogCQlyZXR1cm4gRUlO VkFMOwogCi0JZG9tYWluID0gaW50cm9kdWNlX2RvbWFpbihpbiwgZG9taWQs IHBvcnQsIGZhbHNlKTsKKwlkb21haW4gPSBpbnRyb2R1Y2VfZG9tYWluKGN0 eCwgZG9taWQsIHBvcnQsIGZhbHNlKTsKIAlpZiAoIWRvbWFpbikKIAkJcmV0 dXJuIGVycm5vOwogCkBAIC01NzUsNyArNTc2LDggQEAgc3RhdGljIHN0cnVj dCBkb21haW4gKmZpbmRfY29ubmVjdGVkX2RvbWFpbih1bnNpZ25lZCBpbnQg ZG9taWQpCiAJcmV0dXJuIGRvbWFpbjsKIH0KIAotaW50IGRvX3NldF90YXJn ZXQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbikKK2ludCBkb19zZXRfdGFyZ2V0KGNvbnN0IHZvaWQgKmN0eCwg c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgc3RydWN0IGJ1ZmZlcmVk X2RhdGEgKmluKQogewogCWNoYXIgKnZlY1syXTsKIAl1bnNpZ25lZCBpbnQg ZG9taWQsIHRkb21pZDsKQEAgLTYxOSw3ICs2MjEsOCBAQCBzdGF0aWMgc3Ry dWN0IGRvbWFpbiAqb25lYXJnX2RvbWFpbihzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwKIH0KIAogLyogZG9taWQgKi8KLWludCBkb19yZWxlYXNlKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CitpbnQgZG9fcmVsZWFzZShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLAorCSAgICAgICBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAq aW4pCiB7CiAJc3RydWN0IGRvbWFpbiAqZG9tYWluOwogCkBAIC02MzQsNyAr NjM3LDggQEAgaW50IGRvX3JlbGVhc2Uoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlyZXR1cm4gMDsKIH0K IAotaW50IGRvX3Jlc3VtZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQoraW50IGRvX3Jlc3VtZShjb25zdCB2 b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCSAgICAgIHN0 cnVjdCBidWZmZXJlZF9kYXRhICppbikKIHsKIAlzdHJ1Y3QgZG9tYWluICpk b21haW47CiAKQEAgLTY0OSw3ICs2NTMsOCBAQCBpbnQgZG9fcmVzdW1lKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAq aW4pCiAJcmV0dXJuIDA7CiB9CiAKLWludCBkb19nZXRfZG9tYWluX3BhdGgo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRh ICppbikKK2ludCBkb19nZXRfZG9tYWluX3BhdGgoY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICAgICAgIHN0cnVjdCBi dWZmZXJlZF9kYXRhICppbikKIHsKIAljaGFyICpwYXRoOwogCWNvbnN0IGNo YXIgKmRvbWlkX3N0ciA9IG9uZWFyZyhpbik7CkBAIC02NTcsMTggKzY2Miwx NyBAQCBpbnQgZG9fZ2V0X2RvbWFpbl9wYXRoKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJaWYgKCFkb21p ZF9zdHIpCiAJCXJldHVybiBFSU5WQUw7CiAKLQlwYXRoID0gdGFsbG9jX2Rv bWFpbl9wYXRoKGNvbm4sIGF0b2koZG9taWRfc3RyKSk7CisJcGF0aCA9IHRh bGxvY19kb21haW5fcGF0aChjdHgsIGF0b2koZG9taWRfc3RyKSk7CiAJaWYg KCFwYXRoKQogCQlyZXR1cm4gZXJybm87CiAKIAlzZW5kX3JlcGx5KGNvbm4s IFhTX0dFVF9ET01BSU5fUEFUSCwgcGF0aCwgc3RybGVuKHBhdGgpICsgMSk7 CiAKLQl0YWxsb2NfZnJlZShwYXRoKTsKLQogCXJldHVybiAwOwogfQogCi1p bnQgZG9faXNfZG9tYWluX2ludHJvZHVjZWQoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKK2ludCBkb19pc19k b21haW5faW50cm9kdWNlZChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLAorCQkJICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICpp bikKIHsKIAlpbnQgcmVzdWx0OwogCXVuc2lnbmVkIGludCBkb21pZDsKQEAg LTY4OSw3ICs2OTMsOCBAQCBpbnQgZG9faXNfZG9tYWluX2ludHJvZHVjZWQo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRh ICppbikKIH0KIAogLyogQWxsb3cgZ3Vlc3QgdG8gcmVzZXQgYWxsIHdhdGNo ZXMgKi8KLWludCBkb19yZXNldF93YXRjaGVzKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCitpbnQgZG9fcmVz ZXRfd2F0Y2hlcyhjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAorCQkgICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIHsK IAljb25uX2RlbGV0ZV9hbGxfd2F0Y2hlcyhjb25uKTsKIAljb25uX2RlbGV0 ZV9hbGxfdHJhbnNhY3Rpb25zKGNvbm4pOwpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2RvbWFpbi5oCmluZGV4IDkwNGZhYTkyM2FmYi4uYjllMTUy ODkwMTQ5IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFp bi5oCkBAIC0yNCwyNSArMjQsMzIgQEAgdm9pZCBoYW5kbGVfZXZlbnQodm9p ZCk7CiB2b2lkIGNoZWNrX2RvbWFpbnModm9pZCk7CiAKIC8qIGRvbWlkLCBt Zm4sIGV2ZW50Y2huLCBwYXRoICovCi1pbnQgZG9faW50cm9kdWNlKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p OworaW50IGRvX2ludHJvZHVjZShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBj b25uZWN0aW9uICpjb25uLAorCQkgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmlu KTsKIAogLyogZG9taWQgKi8KLWludCBkb19pc19kb21haW5faW50cm9kdWNl ZChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2Rh dGEgKmluKTsKK2ludCBkb19pc19kb21haW5faW50cm9kdWNlZChjb25zdCB2 b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkJICAgIHN0 cnVjdCBidWZmZXJlZF9kYXRhICppbik7CiAKIC8qIGRvbWlkICovCi1pbnQg ZG9fcmVsZWFzZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKmluKTsKK2ludCBkb19yZWxlYXNlKGNvbnN0IHZvaWQg KmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJICAgICAgIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbik7CiAKIC8qIGRvbWlkICovCi1pbnQgZG9f cmVzdW1lKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pOworaW50IGRvX3Jlc3VtZShjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCSAgICAgIHN0cnVjdCBidWZm ZXJlZF9kYXRhICppbik7CiAKIC8qIGRvbWlkLCB0YXJnZXQgKi8KLWludCBk b19zZXRfdGFyZ2V0KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qg YnVmZmVyZWRfZGF0YSAqaW4pOworaW50IGRvX3NldF90YXJnZXQoY29uc3Qg dm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJICBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOwogCiAvKiBkb21pZCAqLwotaW50IGRv X2dldF9kb21haW5fcGF0aChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKK2ludCBkb19nZXRfZG9tYWluX3Bh dGgoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwK KwkJICAgICAgIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbik7CiAKIC8qIEFs bG93IGd1ZXN0IHRvIHJlc2V0IGFsbCB3YXRjaGVzICovCi1pbnQgZG9fcmVz ZXRfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKmluKTsKK2ludCBkb19yZXNldF93YXRjaGVzKGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICAg c3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKTsKIAogdm9pZCBkb21haW5faW5p dChpbnQgZXZ0ZmQpOwogdm9pZCBkb20wX2luaXQodm9pZCk7CmRpZmYgLS1n aXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBi L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4 IDI4Nzc0ODEzZGU4My4uM2UzZWI0NzMyNmNjIDEwMDY0NAotLS0gYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpAQCAtNDgxLDcg KzQ4MSw4IEBAIHN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnNhY3Rpb25fbG9v a3VwKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCB1aW50MzJfdCBpZCkKIAly ZXR1cm4gRVJSX1BUUigtRU5PRU5UKTsKIH0KIAotaW50IGRvX3RyYW5zYWN0 aW9uX3N0YXJ0KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqaW4pCitpbnQgZG9fdHJhbnNhY3Rpb25fc3RhcnQoY29u c3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJCSBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiB7CiAJc3RydWN0IHRyYW5zYWN0 aW9uICp0cmFucywgKmV4aXN0czsKIAljaGFyIGlkX3N0clsyMF07CkBAIC00 OTQsOCArNDk1LDggQEAgaW50IGRvX3RyYW5zYWN0aW9uX3N0YXJ0KHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4p CiAJICAgIGNvbm4tPnRyYW5zYWN0aW9uX3N0YXJ0ZWQgPiBxdW90YV9tYXhf dHJhbnNhY3Rpb24pCiAJCXJldHVybiBFTk9TUEM7CiAKLQkvKiBBdHRhY2gg dHJhbnNhY3Rpb24gdG8gaW5wdXQgZm9yIGF1dG9mcmVlIHVudGlsIGl0J3Mg Y29tcGxldGUgKi8KLQl0cmFucyA9IHRhbGxvY196ZXJvKGluLCBzdHJ1Y3Qg dHJhbnNhY3Rpb24pOworCS8qIEF0dGFjaCB0cmFuc2FjdGlvbiB0byBjdHgg Zm9yIGF1dG9mcmVlIHVudGlsIGl0J3MgY29tcGxldGUgKi8KKwl0cmFucyA9 IHRhbGxvY196ZXJvKGN0eCwgc3RydWN0IHRyYW5zYWN0aW9uKTsKIAlpZiAo IXRyYW5zKQogCQlyZXR1cm4gRU5PTUVNOwogCkBAIC01NDQsNyArNTQ1LDgg QEAgc3RhdGljIGludCB0cmFuc2FjdGlvbl9maXhfZG9tYWlucyhzdHJ1Y3Qg dHJhbnNhY3Rpb24gKnRyYW5zLCBib29sIHVwZGF0ZSkKIAlyZXR1cm4gMDsK IH0KIAotaW50IGRvX3RyYW5zYWN0aW9uX2VuZChzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQoraW50IGRvX3Ry YW5zYWN0aW9uX2VuZChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLAorCQkgICAgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmlu KQogewogCWNvbnN0IGNoYXIgKmFyZyA9IG9uZWFyZyhpbik7CiAJc3RydWN0 IHRyYW5zYWN0aW9uICp0cmFuczsKQEAgLTU2Miw4ICs1NjQsOCBAQCBpbnQg ZG9fdHJhbnNhY3Rpb25fZW5kKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJaWYgKCFjb25uLT50cmFuc2Fj dGlvbl9zdGFydGVkKQogCQljb25uLT50YV9zdGFydF90aW1lID0gMDsKIAot CS8qIEF0dGFjaCB0cmFuc2FjdGlvbiB0byBpbiBmb3IgYXV0by1jbGVhbnVw ICovCi0JdGFsbG9jX3N0ZWFsKGluLCB0cmFucyk7CisJLyogQXR0YWNoIHRy YW5zYWN0aW9uIHRvIGN0eCBmb3IgYXV0by1jbGVhbnVwICovCisJdGFsbG9j X3N0ZWFsKGN0eCwgdHJhbnMpOwogCiAJaWYgKHN0cmVxKGFyZywgIlQiKSkg ewogCQlpZiAodHJhbnMtPmZhaWwpCmRpZmYgLS1naXQgYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uaCBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCmluZGV4IGUzY2JkNmIyMzA5NS4u MzlkN2Y4MWM1MTI3IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfdHJhbnNhY3Rpb24uaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfdHJhbnNhY3Rpb24uaApAQCAtMjksOCArMjksMTAgQEAgc3RydWN0 IHRyYW5zYWN0aW9uOwogCiBleHRlcm4gdWludDY0X3QgZ2VuZXJhdGlvbjsK IAotaW50IGRvX3RyYW5zYWN0aW9uX3N0YXJ0KHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqbm9kZSk7Ci1pbnQgZG9f dHJhbnNhY3Rpb25fZW5kKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOworaW50IGRvX3RyYW5zYWN0aW9uX3N0 YXJ0KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s CisJCQkgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKm5vZGUpOworaW50IGRvX3Ry YW5zYWN0aW9uX2VuZChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLAorCQkgICAgICAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmlu KTsKIAogc3RydWN0IHRyYW5zYWN0aW9uICp0cmFuc2FjdGlvbl9sb29rdXAo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHVpbnQzMl90IGlkKTsKIApkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmMgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYwppbmRleCA4NTM2MmJj Y2UzMTQuLjMxNmMwOGI3Zjc1NCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX3dhdGNoLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX3dhdGNoLmMKQEAgLTI0Myw3ICsyNDMsNyBAQCBzdGF0aWMgc3Ry dWN0IHdhdGNoICphZGRfd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IGNoYXIgKnBhdGgsIGNoYXIgKnRva2VuLAogCXJldHVybiBOVUxMOwogfQog Ci1pbnQgZG9fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbikKK2ludCBkb193YXRjaChjb25zdCB2b2lk ICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YSAqaW4pCiB7CiAJc3RydWN0IHdhdGNoICp3YXRjaDsKIAljaGFy ICp2ZWNbMl07CkBAIC0yNTIsNyArMjUyLDcgQEAgaW50IGRvX3dhdGNoKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAq aW4pCiAJaWYgKGdldF9zdHJpbmdzKGluLCB2ZWMsIEFSUkFZX1NJWkUodmVj KSkgIT0gQVJSQVlfU0laRSh2ZWMpKQogCQlyZXR1cm4gRUlOVkFMOwogCi0J ZXJybm8gPSBjaGVja193YXRjaF9wYXRoKGNvbm4sIGluLCAmKHZlY1swXSks ICZyZWxhdGl2ZSk7CisJZXJybm8gPSBjaGVja193YXRjaF9wYXRoKGNvbm4s IGN0eCwgJih2ZWNbMF0pLCAmcmVsYXRpdmUpOwogCWlmIChlcnJubykKIAkJ cmV0dXJuIGVycm5vOwogCkBAIC0yODMsNyArMjgzLDggQEAgaW50IGRvX3dh dGNoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRf ZGF0YSAqaW4pCiAJcmV0dXJuIDA7CiB9CiAKLWludCBkb191bndhdGNoKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAq aW4pCitpbnQgZG9fdW53YXRjaChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBj b25uZWN0aW9uICpjb25uLAorCSAgICAgICBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSAqaW4pCiB7CiAJc3RydWN0IHdhdGNoICp3YXRjaDsKIAljaGFyICpub2Rl LCAqdmVjWzJdOwpAQCAtMjkxLDcgKzI5Miw3IEBAIGludCBkb191bndhdGNo KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSAqaW4pCiAJaWYgKGdldF9zdHJpbmdzKGluLCB2ZWMsIEFSUkFZX1NJWkUo dmVjKSkgIT0gQVJSQVlfU0laRSh2ZWMpKQogCQlyZXR1cm4gRUlOVkFMOwog Ci0Jbm9kZSA9IGNhbm9uaWNhbGl6ZShjb25uLCBpbiwgdmVjWzBdKTsKKwlu b2RlID0gY2Fub25pY2FsaXplKGNvbm4sIGN0eCwgdmVjWzBdKTsKIAlpZiAo IW5vZGUpCiAJCXJldHVybiBFTk9NRU07CiAJbGlzdF9mb3JfZWFjaF9lbnRy eSh3YXRjaCwgJmNvbm4tPndhdGNoZXMsIGxpc3QpIHsKZGlmZiAtLWdpdCBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5oIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX3dhdGNoLmgKaW5kZXggMGU2OTNmMDgzOWNkLi4w OTE4OTBlZGNhOTYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF93YXRjaC5oCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93 YXRjaC5oCkBAIC0yMSw4ICsyMSwxMCBAQAogCiAjaW5jbHVkZSAieGVuc3Rv cmVkX2NvcmUuaCIKIAotaW50IGRvX3dhdGNoKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pOwotaW50IGRvX3Vu d2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbik7CitpbnQgZG9fd2F0Y2goY29uc3Qgdm9pZCAqY3R4LCBz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkgICAgIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbik7CitpbnQgZG9fdW53YXRjaChjb25zdCB2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCSAgICAgICBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqaW4pOwogCiAvKiBGaXJlIGFsbCB3YXRjaGVzOiAhZXhh Y3QgbWVhbnMgYWxsIHRoZSBjaGlsZHJlbiBhcmUgYWZmZWN0ZWQgKGllLiBy bSkuICovCiB2b2lkIGZpcmVfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgY29uc3Qgdm9pZCAqdG1wLCBjb25zdCBjaGFyICpuYW1lLAo= --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Nov 01 12:06:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 12:06:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433790.686718 (Exim 4.92) (envelope-from ) id 1opq1l-0004Hm-9d; Tue, 01 Nov 2022 12:05:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433790.686718; Tue, 01 Nov 2022 12:05:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opq1l-0004Ha-3q; Tue, 01 Nov 2022 12:05:57 +0000 Received: by outflank-mailman (input) for mailman id 433790; Tue, 01 Nov 2022 12:05:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppx4-0004vc-Tz for xen-devel@lists.xen.org; Tue, 01 Nov 2022 12:01:07 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d751b0c6-59dc-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 13:00:56 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppwm-0005ZZ-0t; Tue, 01 Nov 2022 12:00:48 +0000 Received: from jgross by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oppwm-0005Y4-0C; Tue, 01 Nov 2022 12:00:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d751b0c6-59dc-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=21s15ERchiw4PqUfHttR5tSjM7ku7FiDMNkcgB7n5dk=; b=RdINySdOmxocMWLisN/iWqmFlv +AGfcxKrdDmOt3r6G5M7Q4arP+3z6/Ip/yCWO/prUG1tgsWjOOybw0GU1FcD+Rv6s+S3xQHO9iGfo PzZIPAiRnGulTcS/VmECBLwqh8xAAMFm3zSAArd+rsfydxWaBMjio5266jT4FWyGxhpo=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 420 v2 (CVE-2022-42324) - Oxenstored 32->31 bit integer truncation issues Message-Id: Date: Tue, 01 Nov 2022 12:00:48 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-42324 / XSA-420 version 2 Oxenstored 32->31 bit integer truncation issues UPDATES IN VERSION 2 ==================== Public release. ISSUE DESCRIPTION ================= Integers in Ocaml are 63 or 31 bits of signed precision. The Ocaml Xenbus library takes a C uint32_t out of the ring and casts it directly to an Ocaml integer. In 64-bit Ocaml builds this is fine, but in 32-bit builds, it truncates off the most significant bit, and then creates unsigned/signed confusion in the remainder. This in turn can feed a negative value into logic not expecting a negative value, resulting in unexpected exceptions being thrown. The unexpected exception is not handled suitably, creating a busy-loop trying (and failing) to take the bad packet out of the xenstore ring. IMPACT ====== A malicious or buggy guest can write a packet into the xenstore ring which causes 32-bit builds of oxenstored to busy loop. VULNERABLE SYSTEMS ================== All versions of Xen are affected. Systems running a 32-bit build of oxenstored are affected. Systems running a 64-bit build of oxenstored, or systems running (C) xenstored are not affected. MITIGATION ========== Running xenstored instead of oxenstored will avoid the vulnerability. CREDITS ======= This issue was discovered by Jürgen Groß of SUSE. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa420.patch xen-unstable - Xen 4.13.x $ sha256sum xsa420* 565b332d325fd0fdeb5fee890c0cd9b53c4478c46c6b7ec7b24fd3444d2dc812 xsa420.meta bfa83ca1e78ef81f93c3d94cb1522d1cffed8b9989c5639e8ec663fad0a71027 xsa420.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNg+68MHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZWJ8H/33T8Ub00BrIWdWSvajjRA4oLamGKRg5uJoI5peJ cpgKB7iFcoOZcM+G2YfYjm8W2ckoEHXQkJ7fJEbAW0rHc8+WyWl2ulklZSpyi9RX B6jloIo+5pFoenShirPrJNyfbCmgJduRiUcIzPMRg6vgTmS1RO1W2x3/A6haxez5 LOJCm8dhUBbrp83KH7MgVBlUXIlVQ1irKBmCps11lFG7LaMWjLtScPI4qCpFbMf/ Cmd91Jw6EpzfOWcqohbRabqXXrPZJqSe+EwqrEJsVkkEIK2y2e/kUWcy/9shr9a2 YtudokkROE+bJGbpM9bbucCu/Rnwqj20fDIztR0soCtPbOM= =QFv9 -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa420.meta" Content-Disposition: attachment; filename="xsa420.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MjAsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIw YmU2M2MyNjE1YjI2ODAwMWY3Y2M5YjcyY2UyNWVlZDk1MjczN2RjIiwKICAg ICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICA0MTQsCiAgICAgICAg ICAgIDQxNSwKICAgICAgICAgICAgMzI2LAogICAgICAgICAgICA0MTYsCiAg ICAgICAgICAgIDQxNywKICAgICAgICAgICAgNDE4LAogICAgICAgICAgICA0 MTkKICAgICAgICAgIF0sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAg ICAgICAgInhzYTQyMC5wYXRjaCIKICAgICAgICAgIF0KICAgICAgICB9CiAg ICAgIH0KICAgIH0sCiAgICAiNC4xNCI6IHsKICAgICAgIlJlY2lwZXMiOiB7 CiAgICAgICAgInhlbiI6IHsKICAgICAgICAgICJTdGFibGVSZWYiOiAiMDE2 ZGU2Mjc0N2IyNmVhZDVhNWM3NjNiNjQwZmU4ZTIwNWNkMTgyYiIsCiAgICAg ICAgICAiUHJlcmVxcyI6IFsKICAgICAgICAgICAgNDE0LAogICAgICAgICAg ICA0MTUsCiAgICAgICAgICAgIDMyNiwKICAgICAgICAgICAgNDE2LAogICAg ICAgICAgICA0MTcsCiAgICAgICAgICAgIDQxOCwKICAgICAgICAgICAgNDE5 CiAgICAgICAgICBdLAogICAgICAgICAgIlBhdGNoZXMiOiBbCiAgICAgICAg ICAgICJ4c2E0MjAucGF0Y2giCiAgICAgICAgICBdCiAgICAgICAgfQogICAg ICB9CiAgICB9LAogICAgIjQuMTUiOiB7CiAgICAgICJSZWNpcGVzIjogewog ICAgICAgICJ4ZW4iOiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogIjgxNjU4 MGFmZGQxNzMwZDRmODVmNjQ0NzdhMjQyYTQzOWFmMWNkZjgiLAogICAgICAg ICAgIlByZXJlcXMiOiBbCiAgICAgICAgICAgIDQxNCwKICAgICAgICAgICAg NDE1LAogICAgICAgICAgICAzMjYsCiAgICAgICAgICAgIDQxNiwKICAgICAg ICAgICAgNDE3LAogICAgICAgICAgICA0MTgsCiAgICAgICAgICAgIDQxOQog ICAgICAgICAgXSwKICAgICAgICAgICJQYXRjaGVzIjogWwogICAgICAgICAg ICAieHNhNDIwLnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAg fQogICAgfSwKICAgICI0LjE2IjogewogICAgICAiUmVjaXBlcyI6IHsKICAg ICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIxYmNlN2Zi MWY3MDJkYTRmN2E3NDljNmYxNDU3ZWNiMjBiZjc0ZmNhIiwKICAgICAgICAg ICJQcmVyZXFzIjogWwogICAgICAgICAgICA0MTIsCiAgICAgICAgICAgIDQx NCwKICAgICAgICAgICAgNDE1LAogICAgICAgICAgICAzMjYsCiAgICAgICAg ICAgIDQxNiwKICAgICAgICAgICAgNDE3LAogICAgICAgICAgICA0MTgsCiAg ICAgICAgICAgIDQxOQogICAgICAgICAgXSwKICAgICAgICAgICJQYXRjaGVz IjogWwogICAgICAgICAgICAieHNhNDIwLnBhdGNoIgogICAgICAgICAgXQog ICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICJtYXN0ZXIiOiB7CiAgICAg ICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4iOiB7CiAgICAgICAgICAiU3Rh YmxlUmVmIjogImNjNDc0N2JlOGJhMTU3YTNiMzEwOTIxZTllZTA3ZmI4NTQ1 YWEyMDYiLAogICAgICAgICAgIlByZXJlcXMiOiBbCiAgICAgICAgICAgIDQx MiwKICAgICAgICAgICAgNDE0LAogICAgICAgICAgICA0MTUsCiAgICAgICAg ICAgIDMyNiwKICAgICAgICAgICAgNDE2LAogICAgICAgICAgICA0MTcsCiAg ICAgICAgICAgIDQxOCwKICAgICAgICAgICAgNDE5CiAgICAgICAgICBdLAog ICAgICAgICAgIlBhdGNoZXMiOiBbCiAgICAgICAgICAgICJ4c2E0MjAucGF0 Y2giCiAgICAgICAgICBdCiAgICAgICAgfQogICAgICB9CiAgICB9CiAgfQp9 --=separator Content-Type: application/octet-stream; name="xsa420.patch" Content-Disposition: attachment; filename="xsa420.patch" Content-Transfer-Encoding: base64 RnJvbSAyMTA4Nzk0NTY3NjljYTIxMWM2NjMwZjQ3Mzk5Y2E3YTYxYTM3ZjM1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogRW5zdXJlIHBhY2tldCBzaXplIGlzIG5ldmVy IG5lZ2F0aXZlCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4 dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29k aW5nOiA4Yml0CgpJbnRlZ2VycyBpbiBPY2FtbCBoYXZlIDYzIG9yIDMxIGJp dHMgb2Ygc2lnbmVkIHByZWNpc2lvbi4KCk9uIDY0LWJpdCBidWlsZHMgb2Yg T2NhbWwsIHRoaXMgaXMgZmluZSBiZWNhdXNlIGEgQyB1aW50MzJfdCBhbHdh eXMgZml0cwp3aXRoaW4gYSA2My1iaXQgc2lnbmVkIGludGVnZXIuCgpJbiAz Mi1iaXQgYnVpbGRzIG9mIE9jYW1sLCB0aGlzIGdvZXMgd3JvbmcuICBUaGUg QyB1aW50MzJfdCBpcyB0cnVuY2F0ZWQKZmlyc3QgKGxvc2VzIHRoZSB0b3Ag Yml0KSwgdGhlbiBoYXMgYSB1bnNpZ25lZC9zaWduZWQgbWlzbWF0Y2guCgpB ICJuZWdhdGl2ZSIgdmFsdWUgKGkuZS4gYSBwYWNrZXQgb24gdGhlIHJpbmcg b2YgYmV0d2VlbiAxRyBhbmQgMkcgaW4gc2l6ZSkKd2lsbCB0cmlnZ2VyIGFu IGV4Y2VwdGlvbiBsYXRlciBpbiBCeXRlcy5tYWtlIGluIHhiLm1sLCBhbmQg YmVjYXVzZSB0aGUgcGFja2V0CmlzIG5vdCByZW1vdmVkIGZyb20gdGhlIHJp bmcsIHRoZSBleGNlcHRpb24gcmUtdHJpZ2dlcnMgb24gZXZlcnkgc3Vic2Vx dWVudApxdWVyeSwgY3JlYXRpbmcgYSBsaXZlbG9jay4KCkZpeCBib3RoIHRo ZSBzb3VyY2Ugb2YgdGhlIGV4Y2VwdGlvbiBpbiBYYiwgYW5kIGFzIGRlZmVu Y2UgaW4gZGVwdGgsIG1hcmsgdGhlCmRvbWFpbiBhcyBiYWQgZm9yIGFueSBJ bnZhbGlkX2FyZ3VtZW50IGV4Y2VwdGlvbnMgdG8gYXZvaWQgdGhlIHJpc2sg b2YKbGl2ZWxvY2suCgpUaGlzIGlzIFhTQS00MjAgLyBDVkUtMjAyMi00MjMy NC4KClJlcG9ydGVkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5j b20+ClNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9r QGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJp c3RpYW4ubGluZGlnQGNpdHJpeC5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMv b2NhbWwvbGlicy94Yi9wYXJ0aWFsLm1sIGIvdG9vbHMvb2NhbWwvbGlicy94 Yi9wYXJ0aWFsLm1sCmluZGV4IGI2ZTJhNzE2ZTI2My4uM2FhODkyN2ViN2Yw IDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9saWJzL3hiL3BhcnRpYWwubWwK KysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi9wYXJ0aWFsLm1sCkBAIC0zNiw3 ICszNiw3IEBAIGxldCBvZl9zdHJpbmcgcyA9CiAJICAgVGhpcyB3aWxsIGxl YXZlIHRoZSBndWVzdCBjb25uZWN0aW9uIGlzIGEgYmFkIHN0YXRlIGFuZCB3 aWxsCiAJICAgYmUgaGFyZCB0byByZWNvdmVyIGZyb20gd2l0aG91dCByZXN0 YXJ0aW5nIHRoZSBjb25uZWN0aW9uCiAJICAgKGllIHJlYm9vdGluZyB0aGUg Z3Vlc3QpICopCi0JbGV0IGRsZW4gPSBtaW4geGVuc3RvcmVfcGF5bG9hZF9t YXggZGxlbiBpbgorCWxldCBkbGVuID0gbWF4IDAgKG1pbiB4ZW5zdG9yZV9w YXlsb2FkX21heCBkbGVuKSBpbgogCXsKIAkJdGlkID0gdGlkOwogCQlyaWQg PSByaWQ7CkBAIC00Niw4ICs0Niw4IEBAIGxldCBvZl9zdHJpbmcgcyA9CiAJ fQogCiBsZXQgYXBwZW5kIHBrdCBzIHN6ID0KLQlpZiBwa3QubGVuID4gNDA5 NiB0aGVuIGZhaWx3aXRoICJCdWZmZXIuYWRkOiBjYW5ub3QgZ3JvdyBidWZm ZXIiOwotCUJ1ZmZlci5hZGRfc3RyaW5nIHBrdC5idWYgKFN0cmluZy5zdWIg cyAwIHN6KQorCWlmIEJ1ZmZlci5sZW5ndGggcGt0LmJ1ZiArIHN6ID4geGVu c3RvcmVfcGF5bG9hZF9tYXggdGhlbiBmYWlsd2l0aCAiQnVmZmVyLmFkZDog Y2Fubm90IGdyb3cgYnVmZmVyIjsKKwlCdWZmZXIuYWRkX3N1YnN0cmluZyBw a3QuYnVmIHMgMCBzegogCiBsZXQgdG9fY29tcGxldGUgcGt0ID0KIAlwa3Qu bGVuIC0gKEJ1ZmZlci5sZW5ndGggcGt0LmJ1ZikKZGlmZiAtLWdpdCBhL3Rv b2xzL29jYW1sL3hlbnN0b3JlZC9wcm9jZXNzLm1sIGIvdG9vbHMvb2NhbWwv eGVuc3RvcmVkL3Byb2Nlc3MubWwKaW5kZXggNWY0MzlmZTU5ZjQ3Li5mM2E3 MWIyNGFkOTQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9w cm9jZXNzLm1sCisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9wcm9jZXNz Lm1sCkBAIC03MjIsNyArNzIyLDcgQEAgbGV0IGRvX2lucHV0IHN0b3JlIGNv bnMgZG9tcyBjb24gPQogCQkJSGlzdG9yeS5yZWNvbm5lY3QgY29uOwogCQkJ aW5mbyAiJXMgcmVjb25uZWN0aW9uIGNvbXBsZXRlIiAoQ29ubmVjdGlvbi5n ZXRfZG9tc3RyIGNvbik7CiAJCQlOb25lCi0JCXwgRmFpbHVyZSBleHAgLT4K KwkJfCBJbnZhbGlkX2FyZ3VtZW50IGV4cCB8IEZhaWx1cmUgZXhwIC0+CiAJ CQllcnJvciAiY2F1Z2h0IGV4Y2VwdGlvbiAlcyIgZXhwOwogCQkJZXJyb3Ig ImdvdCBhIGJhZCBjbGllbnQgJXMiIChzcHJpbnRmICIlLThzIiAoQ29ubmVj dGlvbi5nZXRfZG9tc3RyIGNvbikpOwogCQkJQ29ubmVjdGlvbi5tYXJrX2Fz X2JhZCBjb247Cg== --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Nov 01 12:07:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 12:07:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.433670.686788 (Exim 4.92) (envelope-from ) id 1opq2l-0007hQ-TW; Tue, 01 Nov 2022 12:06:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 433670.686788; Tue, 01 Nov 2022 12:06:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opq2l-0007hD-NL; Tue, 01 Nov 2022 12:06:59 +0000 Received: by outflank-mailman (input) for mailman id 433670; Tue, 01 Nov 2022 12:05:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppxN-0004vc-VG for xen-devel@lists.xen.org; Tue, 01 Nov 2022 12:01:26 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d8314b20-59dc-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 13:00:57 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppwX-0005Wm-QW; Tue, 01 Nov 2022 12:00:33 +0000 Received: from jgross by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oppwX-0005Mu-KO; Tue, 01 Nov 2022 12:00:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8314b20-59dc-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=Y3sX+miHJ9pbCRo6V9bOybFfQ+2ooMH2mCcZpQotb48=; b=TtQOcaK+Tx+bV0Oju/n1WREyU5 Z22ykYdBJt1ECXEG0K36YCx5gR/sMUbegxOSDEHknIyRPEDHmzySeSyujfvmai7ieTqfSKF0DCaCk AQtRQS+OGhl8HOuCEd04JjZXr2lr4xTj7pYYAiWW2qdpolPpouKTyNgtlK8CYywb5Kvg=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 326 v4 (CVE-2022-42311,CVE-2022-42312,CVE-2022-42313,CVE-2022-42314,CVE-2022-42315,CVE-2022-42316,CVE-2022-42317,CVE-2022-42318) - Xenstore: guests can let run xenstored out of memory Message-Id: Date: Tue, 01 Nov 2022 12:00:33 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-42311,CVE-2022-42312,CVE-2022-42313,CVE-2022-42314,CVE-2022-42315,CVE-2022-42316,CVE-2022-42317,CVE-2022-42318 / XSA-326 version 4 Xenstore: guests can let run xenstored out of memory UPDATES IN VERSION 4 ==================== Public release. ISSUE DESCRIPTION ================= Malicious guests can cause xenstored to allocate vast amounts of memory, eventually resulting in a Denial of Service (DoS) of xenstored. There are multiple ways how guests can cause large memory allocations in xenstored: - - by issuing new requests to xenstored without reading the responses, causing the responses to be buffered in memory - - by causing large number of watch events to be generated via setting up multiple xenstore watches and then e.g. deleting many xenstore nodes below the watched path - - by creating as many nodes as allowed with the maximum allowed size and path length in as many transactions as possible - - by accessing many nodes inside a transaction IMPACT ====== Unprivileged guests can cause a DoS of xenstored, resulting in the inability to create new guests or modify the configuration of running guests. VULNERABLE SYSTEMS ================== All Xen versions are vulnerable. Both Xenstore implementations (C and Ocaml) are vulnerable. MITIGATION ========== There is no mitigation available. CREDITS ======= This issue was discovered by Julien Grall of Amazon. RESOLUTION ========== Applying the appropriate attached patches resolve this issue. Note that the final oxenstored patch (7 or 8, as applicable) is limiting the security support for oxenstored to trusted driver domains only. C xenstored Patches 15 and 16 are not part of the XSA, but are useful for administrators to change current xenstored quota settings and to audit per-guest resource usage in xenstored. Note that the patches are based on top of the patches for XSA-414 and XSA-415. There is a subtle dependency on XSA-419, which can't be resolved easily, so the patches of XSA-326 should always be applied together with those of XSA-419. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa326/xsa326-xenstored-??.patch xen-unstable xsa326/xsa326-oxenstored-??.patch xen-unstable xsa326/xsa326-4.16-xenstored-??.patch Xen 4.16.x xsa326/xsa326-4.16-oxenstored-??.patch Xen 4.16.x xsa326/xsa326-4.15-xenstored-??.patch Xen 4.15.x xsa326/xsa326-4.15-oxenstored-??.patch Xen 4.15.x xsa326/xsa326-4.14-xenstored-??.patch Xen 4.14.x xsa326/xsa326-4.14-oxenstored-??.patch Xen 4.14.x xsa326/xsa326-4.13-xenstored-??.patch Xen 4.13.x xsa326/xsa326-4.13-oxenstored-??.patch Xen 4.13.x $ sha256sum xsa326* xsa326*/* fbeb48f2137ead7e933d487b95d819b4adec29e33141655dfb40e66861f8d005 xsa326.meta 5da5e9d053a51faba9a553970d53736b333ce713793ed3cf3fefc19943a3ba3d xsa326/xsa326-4.13-oxenstored-01.patch 6c65b043f5a9a8963c74b22df2187be7936c1228b1dee7b3cd32ea2f207520d0 xsa326/xsa326-4.13-oxenstored-02.patch f04f4c29f8a63ff7f08af4d9a99b5da9c44eface3523e2dd9da7119d85445d42 xsa326/xsa326-4.13-oxenstored-03.patch 438ddd4a5fb1b4c9bb5bc911052cbb84b3fbe2ce4c2559ec112b7e9cd6c3c436 xsa326/xsa326-4.13-oxenstored-04.patch e57d98b53c5b03e34a2e554097b634bbf568d9e336ee0ef7ec703d3ff153dd8a xsa326/xsa326-4.13-oxenstored-05.patch 0b13429993ab1bb5a2a58edeeebfc8bc50987e5d86dddfd6f7108259c31aed97 xsa326/xsa326-4.13-oxenstored-06.patch e5c995a8eeea776e57c9878b612f17f2d8cad2538897d8cf385a9f9570ecd076 xsa326/xsa326-4.13-oxenstored-07.patch 247d2461b80884a1bbc063074b89beb769243f82f0de61fe0a45fb438b4a6d38 xsa326/xsa326-4.13-oxenstored-08.patch 928c1b4d624b73fab33af936ba520402d0010956939ed4f17f42c8a476e7dd02 xsa326/xsa326-4.13-xenstored-01.patch 4918eab37b70914a01b3277d83d56a20a877982fac8c5c9533afcdc8c16c4123 xsa326/xsa326-4.13-xenstored-02.patch 1b2df2030bbb91729b16174026127f1a056e011814e2c0b14e6b9430c00f6c41 xsa326/xsa326-4.13-xenstored-03.patch e05aec57d8cdc1f3151cf6a2cfd8fdf10b9776e3ba564ff934d1dd51692c2f12 xsa326/xsa326-4.13-xenstored-04.patch 197e76c74166fc686fd5b1faf6e025abd9a3e1019ebc7954f63d3561b50aa13c xsa326/xsa326-4.13-xenstored-05.patch 75dd40b36c3c8f43c8387402221caf05c7dd3b842caf88f59a5420039f63279f xsa326/xsa326-4.13-xenstored-06.patch 979224585e94d6ba01c8faf2ce4378993aace0057b2377a3ef65aea522912787 xsa326/xsa326-4.13-xenstored-07.patch ca15279f2d11ca693c1bf4f716835e029f200dab7ad07a12c5d4e9a9199d35ea xsa326/xsa326-4.13-xenstored-08.patch 7a041894a74bed53ed9951b62725535915398a1dd90d825514d338264b80f3cc xsa326/xsa326-4.13-xenstored-09.patch 19273b8a79da99ebfbe166e7eb2ec2ea4e68352d90535cc9e1ca154b6cdcab42 xsa326/xsa326-4.13-xenstored-10.patch 4fa07eb6d5fe1d0d49c1e7ad28e106a57f5785cae3a1ff8fd81a0192f0e1ed70 xsa326/xsa326-4.13-xenstored-11.patch 750984eee04854a09ea053213a7b3d411dc487a45056295e943ff4c5e7c8fa10 xsa326/xsa326-4.13-xenstored-12.patch 1aa1458b82fac3b1dbf71f0ad2d8f29203e95ffc8bbe61e3f8aa0895613cb5f8 xsa326/xsa326-4.13-xenstored-13.patch 791f86db3611e226801bf562cf93a4bcd5dd25070e65b6490d1a520e5570cda4 xsa326/xsa326-4.13-xenstored-14.patch e78ea12c7446a773fb670d674d40cef195bb98f2776c4b43e3737f9cb2742182 xsa326/xsa326-4.13-xenstored-15.patch 3dc9ceed291b414931984952c9bc506e4686cf780a33cd338e1cec254831dc35 xsa326/xsa326-4.13-xenstored-16.patch 19952c1d5a9979cea871323a14ab390e239865e1323193eb46891b365ec4ed9c xsa326/xsa326-4.14-oxenstored-01.patch d29ad0d60c3fb07b0f6004bca7cb2457d88c4dd589ccf60261954905f27da982 xsa326/xsa326-4.14-oxenstored-02.patch 124ebbbd5e240113ee0b17fd45d0b8b8ab2fa185197bee9293be109ff209cedb xsa326/xsa326-4.14-oxenstored-03.patch 8dc1e435dbe7b8ba439117c37e5115784942f0c9724b2976eb9b71eaaf4dacc4 xsa326/xsa326-4.14-oxenstored-04.patch 601dd879e100eb73d13018ba7f36a9e7b1e3d1fa82e0b09ab2e9e5eb9f1d901e xsa326/xsa326-4.14-oxenstored-05.patch 1744a454249f2e93ca3b01442f9efe3ed699764780a58a99b23358f752d46b1c xsa326/xsa326-4.14-oxenstored-06.patch 54cd2c156db841c66a1081c8c66b87442bf47d7e0375a311f786527a17feada5 xsa326/xsa326-4.14-oxenstored-07.patch d6560f5aef9e8e28a4f9773bcc8dd89fd81be1d0a7267b6eba9e9b200c65d4df xsa326/xsa326-4.14-oxenstored-08.patch 981c67cad44b33660e9e0e7fb6877659da05266a31affb54916cdbf2670ae435 xsa326/xsa326-4.14-xenstored-01.patch 0defc4dc7007d67d217de657305c9f3dce84dc8f9905fe82db5460cfdab48e8a xsa326/xsa326-4.14-xenstored-02.patch 3b885e855debf116585f27e5c8a9e6e77575c25b4c729b8b50a9457ea815204e xsa326/xsa326-4.14-xenstored-03.patch 167f178880e606f914bbd6a12cb0e6f56b4551d441d4ca4afa341978973e0fcc xsa326/xsa326-4.14-xenstored-04.patch 101dda8679ca2c22a0cc7c38d8701dfb6a082e7bfc67846cf48d4eb9e35bfdc9 xsa326/xsa326-4.14-xenstored-05.patch ad28cc050cdc76c8db6bacefe5d2084ec5ca2f0023ed6a463b9843f8a835173e xsa326/xsa326-4.14-xenstored-06.patch 29c234ea29713c997e4686a13c8c6ef1eaa12cc0ba6ed49e729922435e3902f3 xsa326/xsa326-4.14-xenstored-07.patch b20de5fd7d00218eb8f1e5014c06bc8397c6f93876a7328c61e99b010ad0814d xsa326/xsa326-4.14-xenstored-08.patch c1568765f386a9d70b9fb59d532c239c7ef9af5fda544518de13f6b16806e099 xsa326/xsa326-4.14-xenstored-09.patch a99500c0d25f61c3bf4a29dc4c3a3d9457476c014c279267e2acea7714f5b92e xsa326/xsa326-4.14-xenstored-10.patch efa8ec1b0e8ff5f3bcb951e1838641480bb67af68fa6dddeed9a6ea6af45ac7b xsa326/xsa326-4.14-xenstored-11.patch fd40770a8cf1365034c76c99c26170ae23055000fbcad389ddad1b2d16426768 xsa326/xsa326-4.14-xenstored-12.patch 905525ab516cdc5104558667810ec0de8626e495ba70d571fc4afc8159768cee xsa326/xsa326-4.14-xenstored-13.patch 4d1037a90a345ae71719abcacee274cbed35d05838659a0a4ab33951ee2418b5 xsa326/xsa326-4.14-xenstored-14.patch bea121de03b5c2e4736020264b949c66bb5c18edfc3f17c5591cb9a42499f469 xsa326/xsa326-4.14-xenstored-15.patch 86376255e4b514ec77ce759321131271b8aa0075ac14116a7d49a36ac5debcc0 xsa326/xsa326-4.14-xenstored-16.patch 30d14a68dcd80fb3f9d4df12aed6897c0ddce12e5155ac844a42b776611769cc xsa326/xsa326-4.15-oxenstored-01.patch 958e12676110ce2ad79103ac69c1b468dc792c40ebeb4a7898878d05661b865f xsa326/xsa326-4.15-oxenstored-02.patch 5f9bd4a0bc12db5c9bf89259f1d2ea76b28308ac6f1a74292284c45d88dadd30 xsa326/xsa326-4.15-oxenstored-03.patch b02baaad64ea00e3e05ab8de2b5c0bb1047792870f57c1974ae9cef43fc3201e xsa326/xsa326-4.15-oxenstored-04.patch 644d84f59dca4d55894ec4851c11d4fc0a15203319a9016fd5476fb4a4c43ca7 xsa326/xsa326-4.15-oxenstored-05.patch 9a93874c9c63bd5a418160d2973517302c926cfaeaa22afab5dbe9da54399697 xsa326/xsa326-4.15-oxenstored-06.patch 7dbf0a1d70aa943ea7b0be69d16027239d7f965e3994a95b47d8822d7b0c3d84 xsa326/xsa326-4.15-oxenstored-07.patch 3809e21e09ff741448b3126bb2fb7979a67e430ca6d5b2a70fd22bd210ca276d xsa326/xsa326-4.15-oxenstored-08.patch b05a06e5f29c97192710376ce89e80962a893827a30911087a6b883ff644cef6 xsa326/xsa326-4.15-xenstored-01.patch e0b3249792c03b9dd0e8820e5db9f6e08b38ea5182a60baff1d9264dcf6f1b16 xsa326/xsa326-4.15-xenstored-02.patch d94f34802f4ed302f44823b1a47c25792b5e1d040d3e04878a53b006339b4654 xsa326/xsa326-4.15-xenstored-03.patch ec414451bbec7229282e4db650b0b298d89c1881720886569b2a1210576398bd xsa326/xsa326-4.15-xenstored-04.patch ab25a8817732f5e9f4dd3cb3cf2130de50dbe39d284c0ac80ce210b738a6a3fa xsa326/xsa326-4.15-xenstored-05.patch a7c0151d34d7b340ccb02780dfc3267e654b4423cdfff32650577a4da519677e xsa326/xsa326-4.15-xenstored-06.patch a4933e62317428fc8d8a5ba12a653613ee3e54ad89f26831736f0b12bb18d68e xsa326/xsa326-4.15-xenstored-07.patch 0b365ea9d0dfd2b2773b42a19826e369bb6e79c88f118ec41a80570be93d2c26 xsa326/xsa326-4.15-xenstored-08.patch dd04f56f28a6943a141f425ce3b45ebc370c559e33dab2db48f89d077cde24bf xsa326/xsa326-4.15-xenstored-09.patch d2260693e4d94b4707459bf277c6a23f322fcd3fa58091cdac896b39a61a890f xsa326/xsa326-4.15-xenstored-10.patch 97dfa89180a20cc3e3d03edaf2cc48a343d4f07e7982b5ee1e4c61afa3103a6f xsa326/xsa326-4.15-xenstored-11.patch acd6041a412fc584ccd9376f1e17f51cf40708ec3fa1c0ce64a9c9cdb393e727 xsa326/xsa326-4.15-xenstored-12.patch ef00a409abfeb078a1e29abf3bd12c017440cb4db09b00a7cab875bb7a920788 xsa326/xsa326-4.15-xenstored-13.patch e33042c8f63426a3ef75a884b00aaddd7f143324efbb216dae92155b3a6d23c8 xsa326/xsa326-4.15-xenstored-14.patch e2ab4d46a6d836f485a062eddae2ea3e554da55c68551db22c40b19edc366a56 xsa326/xsa326-4.15-xenstored-15.patch fb5eac62c4dd11e1a7e998a1b293e1b36998ec7540137790c66ee3e756ee7d7b xsa326/xsa326-4.15-xenstored-16.patch 22188213c6caf1a9f84e0babdb3c35e9e828424e3bfced237036856291ec86c5 xsa326/xsa326-4.16-oxenstored-01.patch 631891588ca285eb44ebc393a13bfb7fd3da473db031aca612770ccb6e502447 xsa326/xsa326-4.16-oxenstored-02.patch 32f43582d2f25c46a837f36cca54d85a14afe0c04489597fe564bc688ead1dba xsa326/xsa326-4.16-oxenstored-03.patch 9ea1efcf2260b2170318467a1ae99e898024a3ee139b61570838115a1de8b956 xsa326/xsa326-4.16-oxenstored-04.patch 03eb654ebacfef7e3a91234deb7bc4687f80762ca68b00b7fe23eb273ef8b9f1 xsa326/xsa326-4.16-oxenstored-05.patch 5b771df5d23ecd6a66de93b6d5a5ab3821a3f57770d6a8d9473eb18f4bf1ee9c xsa326/xsa326-4.16-oxenstored-06.patch eddf43db08e7c46a15f589f7be3ac64c3967c345b520dd5b4813117332da4b1a xsa326/xsa326-4.16-oxenstored-07.patch 8c5b11c0a0af8f5f9dff4d64482377f0706c455e65a106f309c9ad56eea1adc6 xsa326/xsa326-4.16-oxenstored-08.patch a4542bd9278ac83c0e633bbff7d3f446a03b4dac70269c0f079c980d58d9a5ae xsa326/xsa326-4.16-xenstored-01.patch 6f7b7d523b0b085d2b7f371ec4477859212a265ae9a52f1f8c8f54e62f02a05e xsa326/xsa326-4.16-xenstored-02.patch 2b9a3f2e1764fedc08aa335603fe7c253e67496534a29ffae8fe6e9c1ba0ce19 xsa326/xsa326-4.16-xenstored-03.patch 0fc9759eb7e6504b9f54090b5d249d602968df8db6de6dff32a84a9134317e72 xsa326/xsa326-4.16-xenstored-04.patch 6962f7381bc11df4fdccb89013968c583c708677d14f5ef57c07e945eaa7bcc6 xsa326/xsa326-4.16-xenstored-05.patch d30bdd689b0a32b09ec8916917fe5297a1b3dd2f6c93e39fad2864fcd862b4bf xsa326/xsa326-4.16-xenstored-06.patch ecc07fc6f1ae78ea8455344e785d1c359fe0c5b3c4be97346812b5aa5dd3a19f xsa326/xsa326-4.16-xenstored-07.patch a0f0316c955a7a8a8e74509d9db052ab1560dd132b2e931121368338cd65e5b5 xsa326/xsa326-4.16-xenstored-08.patch ccced498d856519df82836acb7dccd155b858c62cdab84d95e6aac12ca7e9963 xsa326/xsa326-4.16-xenstored-09.patch 5bc89ffba64be315264cf695a62e27ebb55879eff9d97e8bf0d71ee01eff78af xsa326/xsa326-4.16-xenstored-10.patch c25bd21bc05f93622dd9025e787ba60955dc6df0c74db915acd821ab7ecea733 xsa326/xsa326-4.16-xenstored-11.patch 5eec3bb81c5d3a3588bf30a754f630b3d08628c66c35a8d00823d1726591bae0 xsa326/xsa326-4.16-xenstored-12.patch 6f484f7c237c7e92d3ff225e4732b0496a5e899de02812fedfbbcdc5712fff03 xsa326/xsa326-4.16-xenstored-13.patch e8382b1f37177d3dca5e66adce13e1cec4a320b0865f09535bf51a1d4662bb1c xsa326/xsa326-4.16-xenstored-14.patch 274708be8a5951eaaa2adb61974c3a1529c35dc1f293cc2e9d4759a2d8e20693 xsa326/xsa326-4.16-xenstored-15.patch cebadbd9b303551e0208eaefd831608c47056d27f05dcea97cee3cd761eb3f70 xsa326/xsa326-4.16-xenstored-16.patch 16248584282597dd5b405c8ced0d7d8ad644b68b9dbe13dbaa65ad9080fbbbc4 xsa326/xsa326-oxenstored-01.patch 8f1346250c54accdd4da3cbfb29c98bdf8511974e75e6433374e772c4a7f3b88 xsa326/xsa326-oxenstored-02.patch bc59dbfbd41a95d73c81ecd011c3a3d2cc62f373e1ea0f79792a78572ca06af1 xsa326/xsa326-oxenstored-03.patch b3e383389d3743809422a4e5a364bad10249531bd64d0af2873294cb9abbcb10 xsa326/xsa326-oxenstored-04.patch ad9160630efefece9eb59e144e01911dc69d625acca2a5562a1640bc8823bcf0 xsa326/xsa326-oxenstored-05.patch 4279925ed16d89d3f26ecb4a71d2215547088c8f733c4bce596e29b1916e01cf xsa326/xsa326-oxenstored-06.patch de8faa4b114faef576024da5f99b7a961efd9f7de5fa6ba60160fe932af36494 xsa326/xsa326-oxenstored-07.patch b4582a663bf5cc8ef7ab5dccaab1e5b686da6584a5cab3339319c66726535e8e xsa326/xsa326-xenstored-01.patch 8a5699af6c6d0497f6b16030db31c59cf8b172c21a78d1d2d36f0c590a5f2319 xsa326/xsa326-xenstored-02.patch b8a9286af5d14e35a9ec541afc20b2ca40550ac0a6e83fc012be396ba42a939b xsa326/xsa326-xenstored-03.patch 10d4c34475550c7dcf808747a4a44ce74ed42d8c0b0c209c6dc318c397a4ba8f xsa326/xsa326-xenstored-04.patch 3fba2fc49d5af5466452d4ddfa730194686ff8dbb5a96b29e4d89032e0135a78 xsa326/xsa326-xenstored-05.patch 57e008a2a8921186b797abe068f0ef9d39ea23dcd0f4cb8a4c20a022d17aff77 xsa326/xsa326-xenstored-06.patch da69f7577dd38fc109e6271d583b3cd19197b6777e70191e079e2e120631d6cf xsa326/xsa326-xenstored-07.patch a2ab8f1307609dcfb66abf12c82e8f273f12e1c92f05b350933a73794b02ad73 xsa326/xsa326-xenstored-08.patch 417baecd2b6e10456ef6501619ba617e2c24a32bcad025df3f683f17334e42f9 xsa326/xsa326-xenstored-09.patch 2ccd4bd9524971d140568d9d0cee49931bcf85596744a13ac3520e1e67c71fd8 xsa326/xsa326-xenstored-10.patch bf119e0c13e4f77d1029410be71987b51c48eb5bfa72c445394e2e2eea004e9c xsa326/xsa326-xenstored-11.patch 70dadf62eca8bd119ff84d4efdb0c863f8ddaf58e25e29ef6d3b7bc92fc2f0fa xsa326/xsa326-xenstored-12.patch 6fdd871d77b699fbb4df8efc18fd772131a216e9ac9387832ae66a3af6d58e07 xsa326/xsa326-xenstored-13.patch 49a22d518921be7688cbe5dced9c842b3f0c67f678f3d113bbe5fce36a59d775 xsa326/xsa326-xenstored-14.patch a8ef297722bb4c5778d3e0f80ab16cdb6024cdb3a349789182d2167409cf1aa2 xsa326/xsa326-xenstored-15.patch bf20cd4808cba1506ed7404af050d9b05619b48d2d8eda7e166050540b8f25e2 xsa326/xsa326-xenstored-16.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNg+5QMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZrb0IAKWuWJpPThwmSEFjzNMwdQ+L/xip0AEnl3aVC5UD DEGtB7mETVnwsUYZYee9+OEWOjHJJ//4eENeaziGvzfPG5scGUjcdMeNrIhPtdqB jgjrjfE/z+pTQvbQhu5vvjR/m0K+PHgBejiSfKC7K87+yhcuTaMFoUejBoQ2ZzZ0 h5UfEiTktdWRTwQ4HrofgJKKIfhXGBRRXJbzNysNZ2k8eSpq6ALjgEPpmhalBS/t n1UPKGyToXhVnAwDkV8Bo54EOjhkppIwYuOiGEi4O+weHIq0Oqi9pqpkzCC5QO3q muUGHYRjJ7yDWzo+gpr27O8949gPXPfDMTKLiWYCXGaw4CA= =Eyn8 -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa326.meta" Content-Disposition: attachment; filename="xsa326.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiAzMjYsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIw YmU2M2MyNjE1YjI2ODAwMWY3Y2M5YjcyY2UyNWVlZDk1MjczN2RjIiwKICAg ICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICA0MTQsCiAgICAgICAg ICAgIDQxNQogICAgICAgICAgXSwKICAgICAgICAgICJQYXRjaGVzIjogWwog ICAgICAgICAgICAieHNhMzI2L3hzYTMyNi00LjEzLXhlbnN0b3JlZC0/Py5w YXRjaCIsCiAgICAgICAgICAgICJ4c2EzMjYveHNhMzI2LTQuMTMtb3hlbnN0 b3JlZC0/Py5wYXRjaCIKICAgICAgICAgIF0KICAgICAgICB9CiAgICAgIH0K ICAgIH0sCiAgICAiNC4xNCI6IHsKICAgICAgIlJlY2lwZXMiOiB7CiAgICAg ICAgInhlbiI6IHsKICAgICAgICAgICJTdGFibGVSZWYiOiAiMDE2ZGU2Mjc0 N2IyNmVhZDVhNWM3NjNiNjQwZmU4ZTIwNWNkMTgyYiIsCiAgICAgICAgICAi UHJlcmVxcyI6IFsKICAgICAgICAgICAgNDE0LAogICAgICAgICAgICA0MTUK ICAgICAgICAgIF0sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAg ICAgInhzYTMyNi94c2EzMjYtNC4xNC14ZW5zdG9yZWQtPz8ucGF0Y2giLAog ICAgICAgICAgICAieHNhMzI2L3hzYTMyNi00LjE0LW94ZW5zdG9yZWQtPz8u cGF0Y2giCiAgICAgICAgICBdCiAgICAgICAgfQogICAgICB9CiAgICB9LAog ICAgIjQuMTUiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4i OiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogIjgxNjU4MGFmZGQxNzMwZDRm ODVmNjQ0NzdhMjQyYTQzOWFmMWNkZjgiLAogICAgICAgICAgIlByZXJlcXMi OiBbCiAgICAgICAgICAgIDQxNCwKICAgICAgICAgICAgNDE1CiAgICAgICAg ICBdLAogICAgICAgICAgIlBhdGNoZXMiOiBbCiAgICAgICAgICAgICJ4c2Ez MjYveHNhMzI2LTQuMTUteGVuc3RvcmVkLT8/LnBhdGNoIiwKICAgICAgICAg ICAgInhzYTMyNi94c2EzMjYtNC4xNS1veGVuc3RvcmVkLT8/LnBhdGNoIgog ICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE2 IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAg ICAgICAgIlN0YWJsZVJlZiI6ICIxYmNlN2ZiMWY3MDJkYTRmN2E3NDljNmYx NDU3ZWNiMjBiZjc0ZmNhIiwKICAgICAgICAgICJQcmVyZXFzIjogWwogICAg ICAgICAgICA0MTIsCiAgICAgICAgICAgIDQxNCwKICAgICAgICAgICAgNDE1 CiAgICAgICAgICBdLAogICAgICAgICAgIlBhdGNoZXMiOiBbCiAgICAgICAg ICAgICJ4c2EzMjYveHNhMzI2LTQuMTYteGVuc3RvcmVkLT8/LnBhdGNoIiwK ICAgICAgICAgICAgInhzYTMyNi94c2EzMjYtNC4xNi1veGVuc3RvcmVkLT8/ LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwK ICAgICJtYXN0ZXIiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4 ZW4iOiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogImNjNDc0N2JlOGJhMTU3 YTNiMzEwOTIxZTllZTA3ZmI4NTQ1YWEyMDYiLAogICAgICAgICAgIlByZXJl cXMiOiBbCiAgICAgICAgICAgIDQxMiwKICAgICAgICAgICAgNDE0LAogICAg ICAgICAgICA0MTUKICAgICAgICAgIF0sCiAgICAgICAgICAiUGF0Y2hlcyI6 IFsKICAgICAgICAgICAgInhzYTMyNi94c2EzMjYteGVuc3RvcmVkLT8/LnBh dGNoIiwKICAgICAgICAgICAgInhzYTMyNi94c2EzMjYtb3hlbnN0b3JlZC0/ Py5wYXRjaCIKICAgICAgICAgIF0KICAgICAgICB9CiAgICAgIH0KICAgIH0K ICB9Cn0= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-oxenstored-01.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-oxenstored-01.patch" Content-Transfer-Encoding: base64 RnJvbSAyNGQ2ZTkxMjYyMWRiMjQyYThmZGZmMjliODM1MmI1MTZlMWU5ZDFl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IFN5bmNocm9uaXNlIGRlZmF1 bHRzIHdpdGggb3hlbnN0b3JlLmNvbmYuaW4KTUlNRS1WZXJzaW9uOiAxLjAK Q29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRl bnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCldlIGN1cnJlbnRseSBoYXZl IDIgZGlmZmVyZW50IHNldCBvZiBkZWZhdWx0cyBpbiB1cHN0cmVhbSBYZW4g Z2l0IHRyZWU6CiogZGVmaW5lZCBpbiB0aGUgc291cmNlIGNvZGUsIG9ubHkg dXNlZCBpZiB0aGVyZSBpcyBubyBjb25maWcgZmlsZQoqIGRlZmluZWQgaW4g dGhlIG94ZW5zdG9yZWQuY29uZi5pbiB1cHN0cmVhbSBYZW4KCkFuIG94ZW5z dG9yZWQuY29uZiBmaWxlIGlzIG5vdCBtYW5kYXRvcnksIGFuZCBpZiBtaXNz aW5nLCBtYXhyZXF1ZXN0cyBpbgpwYXJ0aWN1bGFyIGhhcyBhbiB1bnNhZmUg ZGVmYXVsdC4KClJlc3luYyB0aGUgZGVmYXVsdHMgZnJvbSBveGVuc3RvcmVk LmNvbmYuaW4gaW50byB0aGUgc291cmNlIGNvZGUuCgpUaGlzIGlzIHBhcnQg b2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzE2LgoKUmVwb3J0ZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6 IEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2Vk LWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJp eC5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Rl ZmluZS5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKaW5k ZXggZjU3NDM5N2E0YzBiLi45NmMxMjVhOTY5ZGEgMTAwNjQ0Ci0tLSBhL3Rv b2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKKysrIGIvdG9vbHMvb2Nh bWwveGVuc3RvcmVkL2RlZmluZS5tbApAQCAtMjIsOSArMjIsOSBAQCBsZXQg eHNfZGFlbW9uX3NvY2tldF9ybyA9IFBhdGhzLnhlbl9ydW5fc3RvcmVkIF4g Ii9zb2NrZXRfcm8iCiAKIGxldCBkZWZhdWx0X2NvbmZpZ19kaXIgPSBQYXRo cy54ZW5fY29uZmlnX2RpcgogCi1sZXQgbWF4d2F0Y2ggPSByZWYgKDUwKQot bGV0IG1heHRyYW5zYWN0aW9uID0gcmVmICgyMCkKLWxldCBtYXhyZXF1ZXN0 cyA9IHJlZiAoLTEpICAgKCogbWF4aW11bSByZXF1ZXN0cyBwZXIgdHJhbnNh Y3Rpb24gKikKK2xldCBtYXh3YXRjaCA9IHJlZiAoMTAwKQorbGV0IG1heHRy YW5zYWN0aW9uID0gcmVmICgxMCkKK2xldCBtYXhyZXF1ZXN0cyA9IHJlZiAo MTAyNCkgICAoKiBtYXhpbXVtIHJlcXVlc3RzIHBlciB0cmFuc2FjdGlvbiAq KQogCiBsZXQgY29uZmxpY3RfYnVyc3RfbGltaXQgPSByZWYgNS4wCiBsZXQg Y29uZmxpY3RfbWF4X2hpc3Rvcnlfc2Vjb25kcyA9IHJlZiAwLjA1CmRpZmYg LS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvcXVvdGEubWwgYi90b29s cy9vY2FtbC94ZW5zdG9yZWQvcXVvdGEubWwKaW5kZXggYWJjYWM5MTI4MDVh Li42ZTNkNjQwMWFlODkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0 b3JlZC9xdW90YS5tbAorKysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvcXVv dGEubWwKQEAgLTIwLDggKzIwLDggQEAgZXhjZXB0aW9uIFRyYW5zYWN0aW9u X29wZW5lZAogCiBsZXQgd2FybiBmbXQgPSBMb2dnaW5nLndhcm4gInF1b3Rh IiBmbXQKIGxldCBhY3RpdmF0ZSA9IHJlZiB0cnVlCi1sZXQgbWF4ZW50ID0g cmVmICgxMDAwMCkKLWxldCBtYXhzaXplID0gcmVmICg0MDk2KQorbGV0IG1h eGVudCA9IHJlZiAoMTAwMCkKK2xldCBtYXhzaXplID0gcmVmICgyMDQ4KQog CiB0eXBlIHQgPSB7CiAJbWF4ZW50OiBpbnQ7ICAgICAgICAgICAgICAgKCog bWF4IGVudGl0aWVzIHBlciBkb21VICopCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-oxenstored-02.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-oxenstored-02.patch" Content-Transfer-Encoding: base64 RnJvbSBlMzM1NzJmMjg1ZDNlNGI0YWFjODQ5MzAwMDQ0ODMwOTQzMjAxZDk0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogVGh1LCAyOCBKdWwgMjAyMiAxNzowODoxNSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IENoZWNrIGZvciBtYXhyZXF1 ZXN0cyBiZWZvcmUgcGVyZm9ybWluZwogb3BlcmF0aW9ucwpNSU1FLVZlcnNp b246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRG LTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKUHJldmlvdXNs eSB3ZSdkIHBlcmZvcm0gdGhlIG9wZXJhdGlvbiwgcmVjb3JkIHRoZSB1cGRh dGVkIHRyZWUgaW4gdGhlCnRyYW5zYWN0aW9uIHJlY29yZCwgdGhlbiB0cnkg dG8gaW5zZXJ0IGEgd2F0Y2hvcCBwYXRoIGFuZCB0aGUgcmVwbHkgcGFja2V0 LgoKSWYgd2UgZXhjZWVkZWQgbWF4IHJlcXVlc3RzIHdlIHdvdWxkJ3ZlIHJl dHVybmVkIEVRVU9UQSwgYnV0IHN0aWxsOgoqIGhhdmUgcGVyZm9ybWVkIHRo ZSBvcGVyYXRpb24gb24gdGhlIHRyYW5zYWN0aW9uJ3MgdHJlZQoqIGhhdmUg cmVjb3JkZWQgdGhlIHdhdGNob3AsIG1ha2luZyB0aGlzIHF1ZXVlIGVmZmVj dGl2ZWx5IHVuYm91bmRlZAoKSXQgaXMgYmV0dGVyIGlmIHdlIGNoZWNrIHdo ZXRoZXIgd2UnZCBoYXZlIHJvb20gdG8gc3RvcmUgdGhlIG9wZXJhdGlvbiBi ZWZvcmUKcGVyZm9ybWluZyB0aGUgdHJhbnNhY3Rpb24sIGFuZCByYWlzZSBF UVVPVEEgdGhlcmUuICBUaGVuIHRoZSB0cmFuc2FjdGlvbgpyZWNvcmQgd29u J3QgZ3Jvdy4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2IC8gQ1ZFLTIwMjIt NDIzMTcuCgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1h em9uLmNvbT4KU2lnbmVkLW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4u dG9yb2tAY2l0cml4LmNvbT4KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcg PGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbCBiL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9wcm9jZXNzLm1sCmluZGV4IDNhYjA5YzZjZTkyNi4uMzI3 OWIxOWIxYmZmIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQv cHJvY2Vzcy5tbAorKysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vz cy5tbApAQCAtMjUzLDYgKzI1Myw3IEBAIGxldCBpbnB1dF9oYW5kbGVfZXJy b3IgfmNvbnMgfmRvbXMgfmZjdCB+Y29uIH50IH5yZXEgPQogCWxldCByZXBs eV9lcnJvciBlID0KIAkJUGFja2V0LkVycm9yIGUgaW4KIAl0cnkKKwkJVHJh bnNhY3Rpb24uY2hlY2tfcXVvdGFfZXhuIH5wZXJtOihDb25uZWN0aW9uLmdl dF9wZXJtIGNvbikgdDsKIAkJZmN0IGNvbiB0IGRvbXMgY29ucyByZXEuUGFj a2V0LmRhdGEKIAl3aXRoCiAJfCBEZWZpbmUuSW52YWxpZF9wYXRoICAgICAg ICAgIC0+IHJlcGx5X2Vycm9yICJFSU5WQUwiCkBAIC01NDUsOSArNTQ2LDEw IEBAIGxldCBwcm9jZXNzX3BhY2tldCB+c3RvcmUgfmNvbnMgfmRvbXMgfmNv biB+cmVxID0KIAkJaW4KIAogCQlsZXQgcmVzcG9uc2UgPSB0cnkKKwkJCVRy YW5zYWN0aW9uLmNoZWNrX3F1b3RhX2V4biB+cGVybTooQ29ubmVjdGlvbi5n ZXRfcGVybSBjb24pIHQ7CiAJCQlpZiB0aWQgPD4gVHJhbnNhY3Rpb24ubm9u ZSB0aGVuCiAJCQkJKCogUmVtZW1iZXIgdGhlIHJlcXVlc3QgYW5kIHJlc3Bv bnNlIGZvciB0aGlzIG9wZXJhdGlvbiBpbiBjYXNlIHdlIG5lZWQgdG8gcmVw bGF5IHRoZSB0cmFuc2FjdGlvbiAqKQotCQkJCVRyYW5zYWN0aW9uLmFkZF9v cGVyYXRpb24gfnBlcm06KENvbm5lY3Rpb24uZ2V0X3Blcm0gY29uKSB0IHJl cSByZXNwb25zZTsKKwkJCQlUcmFuc2FjdGlvbi5hZGRfb3BlcmF0aW9uIHQg cmVxIHJlc3BvbnNlOwogCQkJcmVzcG9uc2UKIAkJd2l0aCBRdW90YS5MaW1p dF9yZWFjaGVkIC0+CiAJCQlQYWNrZXQuRXJyb3IgIkVRVU9UQSIKZGlmZiAt LWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbCBi L3Rvb2xzL29jYW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbAppbmRleCAx N2IxYmRmMmVhZjkuLjI5NDE0M2UyMzM1YiAxMDA2NDQKLS0tIGEvdG9vbHMv b2NhbWwveGVuc3RvcmVkL3RyYW5zYWN0aW9uLm1sCisrKyBiL3Rvb2xzL29j YW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbApAQCAtODUsNiArODUsNyBA QCB0eXBlIHQgPSB7CiAJb2xkcm9vdDogU3RvcmUuTm9kZS50OwogCW11dGFi bGUgcGF0aHM6IChYZW5idXMuWGIuT3Aub3BlcmF0aW9uICogU3RvcmUuUGF0 aC50KSBsaXN0OwogCW11dGFibGUgb3BlcmF0aW9uczogKFBhY2tldC5yZXF1 ZXN0ICogUGFja2V0LnJlc3BvbnNlKSBsaXN0OworCW11dGFibGUgcXVvdGFf cmVhY2hlZDogYm9vbDsKIAltdXRhYmxlIHJlYWRfbG93cGF0aDogU3RvcmUu UGF0aC50IG9wdGlvbjsKIAltdXRhYmxlIHdyaXRlX2xvd3BhdGg6IFN0b3Jl LlBhdGgudCBvcHRpb247CiB9CkBAIC0xMjcsNiArMTI4LDcgQEAgbGV0IG1h a2UgPyhpbnRlcm5hbD1mYWxzZSkgaWQgc3RvcmUgPQogCQlvbGRyb290ID0g U3RvcmUuZ2V0X3Jvb3Qgc3RvcmU7CiAJCXBhdGhzID0gW107CiAJCW9wZXJh dGlvbnMgPSBbXTsKKwkJcXVvdGFfcmVhY2hlZCA9IGZhbHNlOwogCQlyZWFk X2xvd3BhdGggPSBOb25lOwogCQl3cml0ZV9sb3dwYXRoID0gTm9uZTsKIAl9 IGluCkBAIC0xNDMsMTMgKzE0NSwxOSBAQCBsZXQgZ2V0X3Jvb3QgdCA9IFN0 b3JlLmdldF9yb290IHQuc3RvcmUKIAogbGV0IGlzX3JlYWRfb25seSB0ID0g dC5wYXRocyA9IFtdCiBsZXQgYWRkX3dvcCB0IHR5IHBhdGggPSB0LnBhdGhz IDwtICh0eSwgcGF0aCkgOjogdC5wYXRocwotbGV0IGFkZF9vcGVyYXRpb24g fnBlcm0gdCByZXF1ZXN0IHJlc3BvbnNlID0KK2xldCBnZXRfb3BlcmF0aW9u cyB0ID0gTGlzdC5yZXYgdC5vcGVyYXRpb25zCisKK2xldCBjaGVja19xdW90 YV9leG4gfnBlcm0gdCA9CiAJaWYgIURlZmluZS5tYXhyZXF1ZXN0cyA+PSAw CiAJCSYmIG5vdCAoUGVybXMuQ29ubmVjdGlvbi5pc19kb20wIHBlcm0pCi0J CSYmIExpc3QubGVuZ3RoIHQub3BlcmF0aW9ucyA+PSAhRGVmaW5lLm1heHJl cXVlc3RzCi0JCXRoZW4gcmFpc2UgUXVvdGEuTGltaXRfcmVhY2hlZDsKKwkJ JiYgKHQucXVvdGFfcmVhY2hlZCB8fCBMaXN0Lmxlbmd0aCB0Lm9wZXJhdGlv bnMgPj0gIURlZmluZS5tYXhyZXF1ZXN0cykKKwkJdGhlbiBiZWdpbgorCQkJ dC5xdW90YV9yZWFjaGVkIDwtIHRydWU7CisJCQlyYWlzZSBRdW90YS5MaW1p dF9yZWFjaGVkOworCQllbmQKKworbGV0IGFkZF9vcGVyYXRpb24gdCByZXF1 ZXN0IHJlc3BvbnNlID0KIAl0Lm9wZXJhdGlvbnMgPC0gKHJlcXVlc3QsIHJl c3BvbnNlKSA6OiB0Lm9wZXJhdGlvbnMKLWxldCBnZXRfb3BlcmF0aW9ucyB0 ID0gTGlzdC5yZXYgdC5vcGVyYXRpb25zCiBsZXQgc2V0X3JlYWRfbG93cGF0 aCB0IHBhdGggPSB0LnJlYWRfbG93cGF0aCA8LSBnZXRfbG93ZXN0IHBhdGgg dC5yZWFkX2xvd3BhdGgKIGxldCBzZXRfd3JpdGVfbG93cGF0aCB0IHBhdGgg PSB0LndyaXRlX2xvd3BhdGggPC0gZ2V0X2xvd2VzdCBwYXRoIHQud3JpdGVf bG93cGF0aAogCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-oxenstored-03.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-oxenstored-03.patch" Content-Transfer-Encoding: base64 RnJvbSA5YjFkNTc5NTU2M2FkMjMxNTVhYmM5NWIwNTMwODFmZjZlODUwZDNh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNyArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogR0MgcGFyYW1ldGVyIHR1bmluZwpNSU1FLVZl cnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9 VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKQnkgZGVm YXVsdCB0aGUgT0NhbWwgZ2FyYmFnZSBjb2xsZWN0b3Igd291bGQgcmV0dXJu IG1lbW9yeSB0byB0aGUgT1Mgb25seQphZnRlciB1bnVzZWQgbWVtb3J5IGlz IDV4IGxpdmUgbWVtb3J5LiAgVHdlYWsgdGhpcyB0byAxMjAlIGluc3RlYWQs IHdoaWNoCndvdWxkIG1hdGNoIHRoZSBtYWpvciBHQyBzcGVlZC4KClRoaXMg aXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEVkd2luIFTD tnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJp c3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+Cgpk aWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RlZmluZS5tbCBi L3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKaW5kZXggOTZjMTI1 YTk2OWRhLi4xYTVkMmYzNGE2NzggMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9kZWZpbmUubWwKKysrIGIvdG9vbHMvb2NhbWwveGVuc3Rv cmVkL2RlZmluZS5tbApAQCAtMjYsNiArMjYsNyBAQCBsZXQgbWF4d2F0Y2gg PSByZWYgKDEwMCkKIGxldCBtYXh0cmFuc2FjdGlvbiA9IHJlZiAoMTApCiBs ZXQgbWF4cmVxdWVzdHMgPSByZWYgKDEwMjQpICAgKCogbWF4aW11bSByZXF1 ZXN0cyBwZXIgdHJhbnNhY3Rpb24gKikKIAorbGV0IGdjX21heF9vdmVyaGVh ZCA9IHJlZiAxMjAgKCogMTIwJSBzZWUgY29tbWVudCBpbiB4ZW5zdG9yZWQu bWwgKikKIGxldCBjb25mbGljdF9idXJzdF9saW1pdCA9IHJlZiA1LjAKIGxl dCBjb25mbGljdF9tYXhfaGlzdG9yeV9zZWNvbmRzID0gcmVmIDAuMDUKIGxl dCBjb25mbGljdF9yYXRlX2xpbWl0X2lzX2FnZ3JlZ2F0ZSA9IHJlZiB0cnVl CmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQveGVuc3RvcmVk Lm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbAppbmRl eCAzNjliNTAzNmY0M2QuLjBiNjM0M2RmYzc4OSAxMDA2NDQKLS0tIGEvdG9v bHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbAorKysgYi90b29scy9v Y2FtbC94ZW5zdG9yZWQveGVuc3RvcmVkLm1sCkBAIC0xMDMsNiArMTAzLDcg QEAgbGV0IHBhcnNlX2NvbmZpZyBmaWxlbmFtZSA9CiAJCSgicXVvdGEtbWF4 c2l6ZSIsIENvbmZpZy5TZXRfaW50IFF1b3RhLm1heHNpemUpOwogCQkoInF1 b3RhLW1heHJlcXVlc3RzIiwgQ29uZmlnLlNldF9pbnQgRGVmaW5lLm1heHJl cXVlc3RzKTsKIAkJKCJxdW90YS1wYXRoLW1heCIsIENvbmZpZy5TZXRfaW50 IERlZmluZS5wYXRoX21heCk7CisJCSgiZ2MtbWF4LW92ZXJoZWFkIiwgQ29u ZmlnLlNldF9pbnQgRGVmaW5lLmdjX21heF9vdmVyaGVhZCk7CiAJCSgidGVz dC1lYWdhaW4iLCBDb25maWcuU2V0X2Jvb2wgVHJhbnNhY3Rpb24udGVzdF9l YWdhaW4pOwogCQkoInBlcnNpc3RlbnQiLCBDb25maWcuU2V0X2Jvb2wgRGlz ay5lbmFibGUpOwogCQkoInhlbnN0b3JlZC1sb2ctZmlsZSIsIENvbmZpZy5T dHJpbmcgTG9nZ2luZy5zZXRfeGVuc3RvcmVkX2xvZ19kZXN0aW5hdGlvbik7 CkBAIC0yMjksNiArMjMwLDY3IEBAIGxldCB0b19maWxlIHN0b3JlIGNvbnMg ZmlsZSA9CiAJICAgICAgICAoZnVuICgpIC0+IGNsb3NlX291dCBjaGFubmVs KQogZW5kCiAKKygqCisJQnkgZGVmYXVsdCBPQ2FtbCdzIEdDIG9ubHkgcmV0 dXJucyBtZW1vcnkgdG8gdGhlIE9TIHdoZW4gaXQgZXhjZWVkcyBhCisJY29u ZmlndXJhYmxlICdtYXggb3ZlcmhlYWQnIHNldHRpbmcuCisJVGhlIGRlZmF1 bHQgaXMgNTAwJSwgdGhhdCBpcyA1LzZ0aCBvZiB0aGUgT0NhbWwgaGVhcCBu ZWVkcyB0byBiZSBmcmVlCisJYW5kIG9ubHkgMS82dGggbGl2ZSBmb3IgYSBj b21wYWN0aW9uIHRvIGJlIHRyaWdnZXJyZWQgdGhhdCB3b3VsZAorCXJlbGVh c2UgbWVtb3J5IGJhY2sgdG8gdGhlIE9TLgorCUlmIHRoZSBsaW1pdCBpcyBu b3QgaGl0IHRoZW4gdGhlIE9DYW1sIHByb2Nlc3MgY2FuIHJldXNlIHRoYXQg bWVtb3J5CisJZm9yIGl0cyBvd24gcHVycG9zZXMsIGJ1dCBvdGhlciBwcm9j ZXNzZXMgd29uJ3QgYmUgYWJsZSB0byB1c2UgaXQuCisKKwlUaGVyZSBpcyBh bHNvIGEgJ3NwYWNlIG92ZXJoZWFkJyBzZXR0aW5nIHRoYXQgY29udHJvbHMg aG93IG11Y2ggd29yaworCWVhY2ggbWFqb3IgR0Mgc2xpY2UgZG9lcywgYW5k IGJ5IGRlZmF1bHQgYWltcyBhdCBoYXZpbmcgbm8gbW9yZSB0aGFuCisJODAl IG9yIDEyMCUgKGRlcGVuZGluZyBvbiB2ZXJzaW9uKSBnYXJiYWdlIHZhbHVl cyBjb21wYXJlZCB0byBsaXZlCisJdmFsdWVzLgorCVRoaXMgZG9lc24ndCBo YXZlIGFzIG11Y2ggcmVsZXZhbmNlIHRvIG1lbW9yeSByZXR1cm5lZCB0byB0 aGUgT1MgYXMKKwlsb25nIGFzIHNwYWNlX292ZXJoZWFkIDw9IG1heF9vdmVy aGVhZCwgYmVjYXVzZSBjb21wYWN0aW9uIGlzIG9ubHkKKwl0cmlnZ2VycmVk IGF0IHRoZSBlbmQgb2YgbWFqb3IgR0MgY3ljbGVzLgorCisJVGhlIGRlZmF1 bHRzIGFyZSB0b28gbGFyZ2Ugb25jZSB0aGUgcHJvZ3JhbSBzdGFydHMgdXNp bmcgfjEwME1pQiBvZgorCW1lbW9yeSwgYXQgd2hpY2ggcG9pbnQgfjUwME1p QiB3b3VsZCBiZSB1bmF2YWlsYWJsZSB0byBvdGhlciBwcm9jZXNzZXMKKwko d2hpY2ggd291bGQgYmUgZmluZSBpZiB0aGlzIHdhcyB0aGUgbWFpbiBwcm9j ZXNzIGluIHRoaXMgVk0sIGJ1dCBpdCBpcworCW5vdCkuCisKKwlNYXggb3Zl cmhlYWQgY2FuIGFsc28gYmUgc2V0IHRvIDAsIGhvd2V2ZXIgdGhpcyBpcyBm b3IgdGVzdGluZyBwdXJwb3NlcworCW9ubHkgKHNldHRpbmcgaXQgbG93ZXIg dGhhbiAnc3BhY2Ugb3ZlcmhlYWQnIHdvdWxkbid0IGhlbHAgYmVjYXVzZSB0 aGUKKwltYWpvciBHQyB3b3VsZG4ndCBydW4gZmFzdCBlbm91Z2gsIGFuZCBj b21wYWN0aW9uIGRvZXMgaGF2ZSBhCisJcGVyZm9ybWFuY2UgY29zdDogd2Ug Y2FuIG9ubHkgY29tcGFjdCBjb250aWd1b3VzIHJlZ2lvbnMsIHNvIG1lbW9y eSBoYXMKKwl0byBiZSBtb3ZlZCBhcm91bmQpLgorCisJTWF4IG92ZXJoZWFk IGNvbnRyb2xzIGhvdyBvZnRlbiB0aGUgaGVhcCBpcyBjb21wYWN0ZWQsIHdo aWNoIGlzIHVzZWZ1bAorCWlmIHRoZXJlIGFyZSBidXJzdCBvZiBhY3Rpdml0 eSBmb2xsb3dlZCBieSBsb25nIHBlcmlvZHMgb2YgaWRsZSBzdGF0ZSwKKwlv ciBpZiBhIGRvbWFpbiBxdWl0cywgZXRjLiBDb21wYWN0aW9uIHJldHVybnMg bWVtb3J5IHRvIHRoZSBPUy4KKworCXdhc3RlZCA9IGxpdmUgKiBzcGFjZV9v dmVyaGVhZCAvIDEwMAorCisJRm9yIGdsb2JhbGx5IG92ZXJyaWRpbmcgdGhl IEdDIHNldHRpbmdzIG9uZSBjYW4gdXNlIE9DQU1MUlVOUEFSQU0sCisJaG93 ZXZlciB3ZSBwcm92aWRlIGEgY29uZmlnIGZpbGUgb3ZlcnJpZGUgdG8gYmUg Y29uc2lzdGVudCB3aXRoIG90aGVyCisJb3hlbnN0b3JlZCBzZXR0aW5ncy4K KworCU9uZSBtaWdodCB3YW50IHRvIGR5bmFtaWNhbGx5IGFkanVzdCB0aGUg b3ZlcmhlYWQgc2V0dGluZyBiYXNlZCBvbiB1c2VkCisJbWVtb3J5LCBpLmUu IHRvIHVzZSBhIGZpeGVkIHVwcGVyIGJvdW5kIGluIGJ5dGVzLCBub3QgcGVy Y2VudGFnZS4gSG93ZXZlcgorCW1lYXN1cmVtZW50cyBzaG93IHRoYXQgc3Vj aCBhZGp1c3RtZW50cyBpbmNyZWFzZSBHQyBvdmVyaGVhZCBtYXNzaXZlbHks CisJd2hpbGUgc3RpbGwgbm90IGd1YXJhbnRlZWluZyB0aGF0IG1lbW9yeSBp cyByZXR1cm5lZCBhbnkgbW9yZSBxdWlja2x5CisJdGhhbiB3aXRoIGEgcGVy Y2VudGFnZSBiYXNlZCBzZXR0aW5nLgorCisJVGhlIGFsbG9jYXRpb24gcG9s aWN5IGNvdWxkIGFsc28gYmUgdHdlYWtlZCwgZS5nLiBmaXJzdCBmaXQgd291 bGQgcmVkdWNlCisJZnJhZ21lbnRhdGlvbiBhbmQgdGh1cyBtZW1vcnkgdXNh Z2UsIGJ1dCB0aGUgZG9jdW1lbnRhdGlvbiB3YXJucyB0aGF0IGl0CisJY2Fu IGJlIHNlbnNpYmx5IHNsb3dlciwgYW5kIGluZGVlZCBvbmUgb2Ygb3VyIG93 biB0ZXN0Y2FzZXMgY2FuIHRyaWdnZXIKKwlzdWNoIGEgY29ybmVyIGNhc2Ug d2hlcmUgaXQgaXMgbXVsdGlwbGUgdGltZXMgc2xvd2VyLCBzbyBpdCBpcyBi ZXN0IHRvIGtlZXAKKwl0aGUgZGVmYXVsdCBhbGxvY2F0aW9uIHBvbGljeSAo bmV4dC1maXQvYmVzdC1maXQgZGVwZW5kaW5nIG9uIHZlcnNpb24pLgorCisJ VGhlcmUgYXJlIG90aGVyIHR3ZWFrcyB0aGF0IGNhbiBiZSBhdHRlbXB0ZWQg aW4gdGhlIGZ1dHVyZSwgZS5nLiBzZXR0aW5nCisJJ3VsaW1pdCAtdicgdG8g NzUlIG9mIFJBTSwgaG93ZXZlciBnZXR0aW5nIHRoZSBrZXJuZWwgdG8gYWN0 dWFsbHkgcmV0dXJuCisJTlVMTCBmcm9tIGFsbG9jYXRpb25zIGlzIGRpZmZp Y3VsdCBldmVuIHdpdGggdGhhdCBzZXR0aW5nLCBhbmQgd2l0aG91dCBhCisJ TlVMTCB0aGUgZW1lcmdlbmN5IEdDIHdvbid0IGJlIHRyaWdnZXJyZWQuCisJ UGVyaGFwcyBjZ3JvdXAgbGltaXRzIGNvdWxkIGhlbHAsIGJ1dCBmb3Igbm93 IHR3ZWFrIHRoZSBzYWZlc3Qgb25seS4KKyopCisKK2xldCB0d2Vha19nYyAo KSA9CisJR2Muc2V0IHsgKEdjLmdldCAoKSkgd2l0aCBHYy5tYXhfb3Zlcmhl YWQgPSAhRGVmaW5lLmdjX21heF9vdmVyaGVhZCB9CisKKwogbGV0IF8gPQog CWxldCBjZiA9IGRvX2FyZ3YgaW4KIAlsZXQgcGlkZmlsZSA9CkBAIC0yMzgs NiArMzAwLDggQEAgbGV0IF8gPQogCQkJZGVmYXVsdF9waWRmaWxlCiAJCWlu CiAKKwl0d2Vha19nYyAoKTsKKwogCSh0cnkKIAkJVW5peGV4dC5ta2Rpcl9y ZWMgKEZpbGVuYW1lLmRpcm5hbWUgcGlkZmlsZSkgMG83NTUKIAl3aXRoIF8g LT4K --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-oxenstored-04.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-oxenstored-04.patch" Content-Transfer-Encoding: base64 RnJvbSA3NmZkMjk0YzkzNGEzMjRhNjYxMjUwZjU3ZTI2MDJlY2E5NjNjNDlk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogRnJpLCAyOSBKdWwgMjAyMiAxODo1MzoyOSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC9saWJzL3hiOiBoaWRlIHR5cGUgb2YgWGIudApN SU1FLVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNo YXJzZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoK SGlkaW5nIHRoZSB0eXBlIHdpbGwgbWFrZSBpdCBlYXNpZXIgdG8gY2hhbmdl IHRoZSBpbXBsZW1lbnRhdGlvbgppbiB0aGUgZnV0dXJlIHdpdGhvdXQgYnJl YWtpbmcgY29kZSB0aGF0IHJlbGllcyBvbiBpdC4KCk5vIGZ1bmN0aW9uYWwg Y2hhbmdlLgoKU2lnbmVkLW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4u dG9yb2tAY2l0cml4LmNvbT4KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcg PGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4KKGNoZXJyeSBwaWNrZWQg ZnJvbSBjb21taXQgN2FkZTMwYTE0NTE3MzRkMDQxMzYzYzc1MGE2NWQzMjJl MjViNDdiYSkKClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBh bWF6b24uY29tPgpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yi94 Yi5tbCBiL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWwKaW5kZXggMTA0ZDMx OWQ3NzQ3Li44NDA0ZGRkOGE2ODIgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1s L2xpYnMveGIveGIubWwKKysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5t bApAQCAtMTk2LDYgKzE5Niw5IEBAIGxldCBwZWVrX291dHB1dCBjb24gPSBR dWV1ZS5wZWVrIGNvbi5wa3Rfb3V0CiBsZXQgaW5wdXRfbGVuIGNvbiA9IFF1 ZXVlLmxlbmd0aCBjb24ucGt0X2luCiBsZXQgaGFzX2luX3BhY2tldCBjb24g PSBRdWV1ZS5sZW5ndGggY29uLnBrdF9pbiA+IDAKIGxldCBnZXRfaW5fcGFj a2V0IGNvbiA9IFF1ZXVlLnBvcCBjb24ucGt0X2luCitsZXQgaGFzX3BhcnRp YWxfaW5wdXQgY29uID0gbWF0Y2ggY29uLnBhcnRpYWxfaW4gd2l0aAorCXwg SGF2ZUhkciBfIC0+IHRydWUKKwl8IE5vSGRyIChuLCBfKSAtPiBuIDwgUGFy dGlhbC5oZWFkZXJfc2l6ZSAoKQogbGV0IGhhc19tb3JlX2lucHV0IGNvbiA9 CiAJbWF0Y2ggY29uLmJhY2tlbmQgd2l0aAogCXwgRmQgXyAgICAgICAgIC0+ IGZhbHNlCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aSBiL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWxpCmluZGV4IDNhMDBkYTZj ZGRjMS4uNzk0ZTM1YmIzNDNlIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9s aWJzL3hiL3hiLm1saQorKysgYi90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aQpAQCAtNjYsMTMgKzY2LDcgQEAgdHlwZSBiYWNrZW5kX21tYXAgPSB7CiB0 eXBlIGJhY2tlbmRfZmQgPSB7IGZkIDogVW5peC5maWxlX2Rlc2NyOyB9CiB0 eXBlIGJhY2tlbmQgPSBGZCBvZiBiYWNrZW5kX2ZkIHwgWGVubW1hcCBvZiBi YWNrZW5kX21tYXAKIHR5cGUgcGFydGlhbF9idWYgPSBIYXZlSGRyIG9mIFBh cnRpYWwucGt0IHwgTm9IZHIgb2YgaW50ICogYnl0ZXMKLXR5cGUgdCA9IHsK LSAgYmFja2VuZCA6IGJhY2tlbmQ7Ci0gIHBrdF9pbiA6IFBhY2tldC50IFF1 ZXVlLnQ7Ci0gIHBrdF9vdXQgOiBQYWNrZXQudCBRdWV1ZS50OwotICBtdXRh YmxlIHBhcnRpYWxfaW4gOiBwYXJ0aWFsX2J1ZjsKLSAgbXV0YWJsZSBwYXJ0 aWFsX291dCA6IHN0cmluZzsKLX0KK3R5cGUgdAogdmFsIGluaXRfcGFydGlh bF9pbiA6IHVuaXQgLT4gcGFydGlhbF9idWYKIHZhbCByZWNvbm5lY3QgOiB0 IC0+IHVuaXQKIHZhbCBxdWV1ZSA6IHQgLT4gUGFja2V0LnQgLT4gdW5pdApA QCAtOTcsNiArOTEsNyBAQCB2YWwgaGFzX291dHB1dCA6IHQgLT4gYm9vbAog dmFsIHBlZWtfb3V0cHV0IDogdCAtPiBQYWNrZXQudAogdmFsIGlucHV0X2xl biA6IHQgLT4gaW50CiB2YWwgaGFzX2luX3BhY2tldCA6IHQgLT4gYm9vbAor dmFsIGhhc19wYXJ0aWFsX2lucHV0IDogdCAtPiBib29sCiB2YWwgZ2V0X2lu X3BhY2tldCA6IHQgLT4gUGFja2V0LnQKIHZhbCBoYXNfbW9yZV9pbnB1dCA6 IHQgLT4gYm9vbAogdmFsIGlzX3NlbGVjdGFibGUgOiB0IC0+IGJvb2wKZGlm ZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9uLm1s IGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Nvbm5lY3Rpb24ubWwKaW5kZXgg ZGFmOGQ4MDRmN2VmLi43MGM0MzQ4NTUyOGMgMTAwNjQ0Ci0tLSBhL3Rvb2xz L29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9uLm1sCisrKyBiL3Rvb2xzL29j YW1sL3hlbnN0b3JlZC9jb25uZWN0aW9uLm1sCkBAIC0xMjUsOSArMTI1LDcg QEAgbGV0IGdldF9wZXJtIGNvbiA9CiBsZXQgc2V0X3RhcmdldCBjb24gdGFy Z2V0X2RvbWlkID0KIAljb24ucGVybSA8LSBQZXJtcy5Db25uZWN0aW9uLnNl dF90YXJnZXQgKGdldF9wZXJtIGNvbikgfnBlcm1zOltQZXJtcy5SRUFEOyBQ ZXJtcy5XUklURV0gdGFyZ2V0X2RvbWlkCiAKLWxldCBpc19iYWNrZW5kX21t YXAgY29uID0gbWF0Y2ggY29uLnhiLlhlbmJ1cy5YYi5iYWNrZW5kIHdpdGgK LQl8IFhlbmJ1cy5YYi5YZW5tbWFwIF8gLT4gdHJ1ZQotCXwgXyAtPiBmYWxz ZQorbGV0IGlzX2JhY2tlbmRfbW1hcCBjb24gPSBYZW5idXMuWGIuaXNfbW1h cCBjb24ueGIKIAogbGV0IHNlbmRfcmVwbHkgY29uIHRpZCByaWQgdHkgZGF0 YSA9CiAJaWYgKFN0cmluZy5sZW5ndGggZGF0YSkgPiB4ZW5zdG9yZV9wYXls b2FkX21heCAmJiAoaXNfYmFja2VuZF9tbWFwIGNvbikgdGhlbgo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-oxenstored-05.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-oxenstored-05.patch" Content-Transfer-Encoding: base64 RnJvbSA3NjkyOTM4MGQ5MTAxYTcwN2E0YTUzMjdkMjQwOWJjMWZmNTkwMGY1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMiArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogQ2hhbmdlIFhiLmlucHV0IHRvIHJldHVybiBQ YWNrZXQudCBvcHRpb24KTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBl OiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXIt RW5jb2Rpbmc6IDhiaXQKClRoZSBxdWV1ZSBoZXJlIHdvdWxkIG9ubHkgZXZl ciBob2xkIGF0IG1vc3Qgb25lIGVsZW1lbnQuICBUaGlzIHdpbGwgc2ltcGxp ZnkKZm9sbG93LXVwIHBhdGNoZXMuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMy Ni4KClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24u Y29tPgpTaWduZWQtb2ZmLWJ5OiBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jv a0BjaXRyaXguY29tPgpBY2tlZC1ieTogQ2hyaXN0aWFuIExpbmRpZyA8Y2hy aXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xz L29jYW1sL2xpYnMveGIveGIubWwgYi90b29scy9vY2FtbC9saWJzL3hiL3hi Lm1sCmluZGV4IDg0MDRkZGQ4YTY4Mi4uMTY1ZmQ0YTFlZGY0IDEwMDY0NAot LS0gYS90b29scy9vY2FtbC9saWJzL3hiL3hiLm1sCisrKyBiL3Rvb2xzL29j YW1sL2xpYnMveGIveGIubWwKQEAgLTQ1LDcgKzQ1LDYgQEAgdHlwZSBwYXJ0 aWFsX2J1ZiA9IEhhdmVIZHIgb2YgUGFydGlhbC5wa3QgfCBOb0hkciBvZiBp bnQgKiBieXRlcwogdHlwZSB0ID0KIHsKIAliYWNrZW5kOiBiYWNrZW5kOwot CXBrdF9pbjogUGFja2V0LnQgUXVldWUudDsKIAlwa3Rfb3V0OiBQYWNrZXQu dCBRdWV1ZS50OwogCW11dGFibGUgcGFydGlhbF9pbjogcGFydGlhbF9idWY7 CiAJbXV0YWJsZSBwYXJ0aWFsX291dDogc3RyaW5nOwpAQCAtNjIsNyArNjEs NiBAQCBsZXQgcmVjb25uZWN0IHQgPSBtYXRjaCB0LmJhY2tlbmQgd2l0aAog CQlYc19yaW5nLmNsb3NlIGJhY2tlbmQubW1hcDsKIAkJYmFja2VuZC5ldmVu dGNobl9ub3RpZnkgKCk7CiAJCSgqIENsZWFyIG91ciBvbGQgY29ubmVjdGlv biBzdGF0ZSAqKQotCQlRdWV1ZS5jbGVhciB0LnBrdF9pbjsKIAkJUXVldWUu Y2xlYXIgdC5wa3Rfb3V0OwogCQl0LnBhcnRpYWxfaW4gPC0gaW5pdF9wYXJ0 aWFsX2luICgpOwogCQl0LnBhcnRpYWxfb3V0IDwtICIiCkBAIC0xMjQsNyAr MTIyLDYgQEAgbGV0IG91dHB1dCBjb24gPQogCiAoKiBOQjogY2FuIHRocm93 IFJlY29ubmVjdCAqKQogbGV0IGlucHV0IGNvbiA9Ci0JbGV0IG5ld3BhY2tl dCA9IHJlZiBmYWxzZSBpbgogCWxldCB0b19yZWFkID0KIAkJbWF0Y2ggY29u LnBhcnRpYWxfaW4gd2l0aAogCQl8IEhhdmVIZHIgcGFydGlhbF9wa3QgLT4g UGFydGlhbC50b19jb21wbGV0ZSBwYXJ0aWFsX3BrdApAQCAtMTQzLDIxICsx NDAsMTkgQEAgbGV0IGlucHV0IGNvbiA9CiAJCWlmIFBhcnRpYWwudG9fY29t cGxldGUgcGFydGlhbF9wa3QgPSAwIHRoZW4gKAogCQkJbGV0IHBrdCA9IFBh Y2tldC5vZl9wYXJ0aWFscGt0IHBhcnRpYWxfcGt0IGluCiAJCQljb24ucGFy dGlhbF9pbiA8LSBpbml0X3BhcnRpYWxfaW4gKCk7Ci0JCQlRdWV1ZS5wdXNo IHBrdCBjb24ucGt0X2luOwotCQkJbmV3cGFja2V0IDo9IHRydWUKLQkJKQor CQkJU29tZSBwa3QKKwkJKSBlbHNlIE5vbmUKIAl8IE5vSGRyIChpLCBidWYp ICAgICAgLT4KIAkJKCogd2UgY29tcGxldGUgdGhlIHBhcnRpYWwgaGVhZGVy ICopCiAJCWlmIHN6ID4gMCB0aGVuCiAJCQlCeXRlcy5ibGl0IGIgMCBidWYg KFBhcnRpYWwuaGVhZGVyX3NpemUgKCkgLSBpKSBzejsKIAkJY29uLnBhcnRp YWxfaW4gPC0gaWYgc3ogPSBpIHRoZW4KLQkJCUhhdmVIZHIgKFBhcnRpYWwu b2Zfc3RyaW5nIChCeXRlcy50b19zdHJpbmcgYnVmKSkgZWxzZSBOb0hkciAo aSAtIHN6LCBidWYpCi0JKTsKLQkhbmV3cGFja2V0CisJCQlIYXZlSGRyIChQ YXJ0aWFsLm9mX3N0cmluZyAoQnl0ZXMudG9fc3RyaW5nIGJ1ZikpIGVsc2Ug Tm9IZHIgKGkgLSBzeiwgYnVmKTsKKwkJTm9uZQorCSkKIAogbGV0IG5ld2Nv biBiYWNrZW5kID0gewogCWJhY2tlbmQgPSBiYWNrZW5kOwotCXBrdF9pbiA9 IFF1ZXVlLmNyZWF0ZSAoKTsKIAlwa3Rfb3V0ID0gUXVldWUuY3JlYXRlICgp OwogCXBhcnRpYWxfaW4gPSBpbml0X3BhcnRpYWxfaW4gKCk7CiAJcGFydGlh bF9vdXQgPSAiIjsKQEAgLTE5Myw5ICsxODgsNiBAQCBsZXQgaGFzX291dHB1 dCBjb24gPSBoYXNfbmV3X291dHB1dCBjb24gfHwgaGFzX29sZF9vdXRwdXQg Y29uCiAKIGxldCBwZWVrX291dHB1dCBjb24gPSBRdWV1ZS5wZWVrIGNvbi5w a3Rfb3V0CiAKLWxldCBpbnB1dF9sZW4gY29uID0gUXVldWUubGVuZ3RoIGNv bi5wa3RfaW4KLWxldCBoYXNfaW5fcGFja2V0IGNvbiA9IFF1ZXVlLmxlbmd0 aCBjb24ucGt0X2luID4gMAotbGV0IGdldF9pbl9wYWNrZXQgY29uID0gUXVl dWUucG9wIGNvbi5wa3RfaW4KIGxldCBoYXNfcGFydGlhbF9pbnB1dCBjb24g PSBtYXRjaCBjb24ucGFydGlhbF9pbiB3aXRoCiAJfCBIYXZlSGRyIF8gLT4g dHJ1ZQogCXwgTm9IZHIgKG4sIF8pIC0+IG4gPCBQYXJ0aWFsLmhlYWRlcl9z aXplICgpCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aSBiL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWxpCmluZGV4IDc5NGUzNWJi MzQzZS4uOTFjNjgyMTYyY2VhIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9s aWJzL3hiL3hiLm1saQorKysgYi90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aQpAQCAtNzcsNyArNzcsNyBAQCB2YWwgd3JpdGVfZmQgOiBiYWNrZW5kX2Zk IC0+ICdhIC0+IHN0cmluZyAtPiBpbnQgLT4gaW50CiB2YWwgd3JpdGVfbW1h cCA6IGJhY2tlbmRfbW1hcCAtPiAnYSAtPiBzdHJpbmcgLT4gaW50IC0+IGlu dAogdmFsIHdyaXRlIDogdCAtPiBzdHJpbmcgLT4gaW50IC0+IGludAogdmFs IG91dHB1dCA6IHQgLT4gYm9vbAotdmFsIGlucHV0IDogdCAtPiBib29sCit2 YWwgaW5wdXQgOiB0IC0+IFBhY2tldC50IG9wdGlvbgogdmFsIG5ld2NvbiA6 IGJhY2tlbmQgLT4gdAogdmFsIG9wZW5fZmQgOiBVbml4LmZpbGVfZGVzY3Ig LT4gdAogdmFsIG9wZW5fbW1hcCA6IFhlbm1tYXAubW1hcF9pbnRlcmZhY2Ug LT4gKHVuaXQgLT4gdW5pdCkgLT4gdApAQCAtODksMTAgKzg5LDcgQEAgdmFs IGhhc19uZXdfb3V0cHV0IDogdCAtPiBib29sCiB2YWwgaGFzX29sZF9vdXRw dXQgOiB0IC0+IGJvb2wKIHZhbCBoYXNfb3V0cHV0IDogdCAtPiBib29sCiB2 YWwgcGVla19vdXRwdXQgOiB0IC0+IFBhY2tldC50Ci12YWwgaW5wdXRfbGVu IDogdCAtPiBpbnQKLXZhbCBoYXNfaW5fcGFja2V0IDogdCAtPiBib29sCiB2 YWwgaGFzX3BhcnRpYWxfaW5wdXQgOiB0IC0+IGJvb2wKLXZhbCBnZXRfaW5f cGFja2V0IDogdCAtPiBQYWNrZXQudAogdmFsIGhhc19tb3JlX2lucHV0IDog dCAtPiBib29sCiB2YWwgaXNfc2VsZWN0YWJsZSA6IHQgLT4gYm9vbAogdmFs IGdldF9mZCA6IHQgLT4gVW5peC5maWxlX2Rlc2NyCmRpZmYgLS1naXQgYS90 b29scy9vY2FtbC9saWJzL3hzL3hzcmF3Lm1sIGIvdG9vbHMvb2NhbWwvbGli cy94cy94c3Jhdy5tbAppbmRleCBkOTgyZmIyNGRiYjEuLjQ1MWY4YjM4ZGJj YyAxMDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94cy94c3Jhdy5tbAor KysgYi90b29scy9vY2FtbC9saWJzL3hzL3hzcmF3Lm1sCkBAIC05NCwyNiAr OTQsMTggQEAgbGV0IHBrdF9zZW5kIGNvbiA9CiAJZG9uZQogCiAoKiByZWNl aXZlIG9uZSBwYWNrZXQgLSBjYW4gc2xlZXAgKikKLWxldCBwa3RfcmVjdiBj b24gPQotCWxldCB3b3JrZG9uZSA9IHJlZiBmYWxzZSBpbgotCXdoaWxlIG5v dCAhd29ya2RvbmUKLQlkbwotCQl3b3JrZG9uZSA6PSBYYi5pbnB1dCBjb24u eGIKLQlkb25lOwotCVhiLmdldF9pbl9wYWNrZXQgY29uLnhiCitsZXQgcmVj IHBrdF9yZWN2IGNvbiA9CisJbWF0Y2ggWGIuaW5wdXQgY29uLnhiIHdpdGgK Kwl8IFNvbWUgcGFja2V0IC0+IHBhY2tldAorCXwgTm9uZSAtPiBwa3RfcmVj diBjb24KIAogbGV0IHBrdF9yZWN2X3RpbWVvdXQgY29uIHRpbWVvdXQgPQog CWxldCBmZCA9IFhiLmdldF9mZCBjb24ueGIgaW4KIAlsZXQgciwgXywgXyA9 IFVuaXguc2VsZWN0IFsgZmQgXSBbXSBbXSB0aW1lb3V0IGluCiAJaWYgciA9 IFtdIHRoZW4KIAkJdHJ1ZSwgTm9uZQotCWVsc2UgKAotCQlsZXQgd29ya2Rv bmUgPSBYYi5pbnB1dCBjb24ueGIgaW4KLQkJaWYgd29ya2RvbmUgdGhlbgot CQkJZmFsc2UsIChTb21lIChYYi5nZXRfaW5fcGFja2V0IGNvbi54YikpCi0J CWVsc2UKLQkJCWZhbHNlLCBOb25lCi0JKQorCWVsc2UKKwkJZmFsc2UsIFhi LmlucHV0IGNvbi54YgogCiBsZXQgcXVldWVfd2F0Y2hldmVudCBjb24gZGF0 YSA9CiAJbGV0IGxzID0gc3BsaXRfc3RyaW5nIH5saW1pdDoyICdcMDAwJyBk YXRhIGluCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvY29u bmVjdGlvbi5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9u Lm1sCmluZGV4IDcwYzQzNDg1NTI4Yy4uYWNlMmFhNWI0ZjUzIDEwMDY0NAot LS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQvY29ubmVjdGlvbi5tbAorKysg Yi90b29scy9vY2FtbC94ZW5zdG9yZWQvY29ubmVjdGlvbi5tbApAQCAtMjc3 LDggKzI3Nyw2IEBAIGxldCBnZXRfdHJhbnNhY3Rpb24gY29uIHRpZCA9CiAJ SGFzaHRibC5maW5kIGNvbi50cmFuc2FjdGlvbnMgdGlkCiAKIGxldCBkb19p bnB1dCBjb24gPSBYZW5idXMuWGIuaW5wdXQgY29uLnhiCi1sZXQgaGFzX2lu cHV0IGNvbiA9IFhlbmJ1cy5YYi5oYXNfaW5fcGFja2V0IGNvbi54YgotbGV0 IHBvcF9pbiBjb24gPSBYZW5idXMuWGIuZ2V0X2luX3BhY2tldCBjb24ueGIK IGxldCBoYXNfbW9yZV9pbnB1dCBjb24gPSBYZW5idXMuWGIuaGFzX21vcmVf aW5wdXQgY29uLnhiCiAKIGxldCBoYXNfb3V0cHV0IGNvbiA9IFhlbmJ1cy5Y Yi5oYXNfb3V0cHV0IGNvbi54YgpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwv eGVuc3RvcmVkL3Byb2Nlc3MubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQv cHJvY2Vzcy5tbAppbmRleCAwZGYzZGY0MDFkYjYuLmE3MjgxMGQwNmY0MyAx MDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3MubWwK KysrIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3MubWwKQEAgLTU2 OSwxNiArNTY5LDE3IEBAIGxldCBkb19pbnB1dCBzdG9yZSBjb25zIGRvbXMg Y29uID0KIAkJCWluZm8gIiVzIHJlcXVlc3RzIGEgcmVjb25uZWN0IiAoQ29u bmVjdGlvbi5nZXRfZG9tc3RyIGNvbik7CiAJCQlIaXN0b3J5LnJlY29ubmVj dCBjb247CiAJCQlpbmZvICIlcyByZWNvbm5lY3Rpb24gY29tcGxldGUiIChD b25uZWN0aW9uLmdldF9kb21zdHIgY29uKTsKLQkJCWZhbHNlCisJCQlOb25l CiAJCXwgRmFpbHVyZSBleHAgLT4KIAkJCWVycm9yICJjYXVnaHQgZXhjZXB0 aW9uICVzIiBleHA7CiAJCQllcnJvciAiZ290IGEgYmFkIGNsaWVudCAlcyIg KHNwcmludGYgIiUtOHMiIChDb25uZWN0aW9uLmdldF9kb21zdHIgY29uKSk7 CiAJCQlDb25uZWN0aW9uLm1hcmtfYXNfYmFkIGNvbjsKLQkJCWZhbHNlCisJ CQlOb25lCiAJaW4KIAotCWlmIG5ld3BhY2tldCB0aGVuICgKLQkJbGV0IHBh Y2tldCA9IENvbm5lY3Rpb24ucG9wX2luIGNvbiBpbgorCW1hdGNoIG5ld3Bh Y2tldCB3aXRoCisJfCBOb25lIC0+ICgpCisJfCBTb21lIHBhY2tldCAtPgog CQlsZXQgdGlkLCByaWQsIHR5LCBkYXRhID0gWGVuYnVzLlhiLlBhY2tldC51 bnBhY2sgcGFja2V0IGluCiAJCWxldCByZXEgPSB7UGFja2V0LnRpZD10aWQ7 IFBhY2tldC5yaWQ9cmlkOyBQYWNrZXQudHk9dHk7IFBhY2tldC5kYXRhPWRh dGF9IGluCiAKQEAgLTU4OCw4ICs1ODksNyBAQCBsZXQgZG9faW5wdXQgc3Rv cmUgY29ucyBkb21zIGNvbiA9CiAJCSAgICAgICAgIChYZW5idXMuWGIuT3Au dG9fc3RyaW5nIHR5KSAoc2FuaXRpemVfZGF0YSBkYXRhKTsgKikKIAkJcHJv Y2Vzc19wYWNrZXQgfnN0b3JlIH5jb25zIH5kb21zIH5jb24gfnJlcTsKIAkJ d3JpdGVfYWNjZXNzX2xvZyB+dHkgfnRpZCB+Y29uOihDb25uZWN0aW9uLmdl dF9kb21zdHIgY29uKSB+ZGF0YTsKLQkJQ29ubmVjdGlvbi5pbmNyX29wcyBj b247Ci0JKQorCQlDb25uZWN0aW9uLmluY3Jfb3BzIGNvbgogCiBsZXQgZG9f b3V0cHV0IF9zdG9yZSBfY29ucyBfZG9tcyBjb24gPQogCWlmIENvbm5lY3Rp b24uaGFzX291dHB1dCBjb24gdGhlbiAoCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-oxenstored-06.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-oxenstored-06.patch" Content-Transfer-Encoding: base64 RnJvbSBmYjU2MTA5YTcwMDRkZTkyOWM2NTk2ZTEyNGViYjBmMTYyZmI1ODU2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMyArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94YjogQWRkIEJvdW5kZWRRdWV1ZQpNSU1FLVZl cnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9 VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKRW5zdXJl cyB3ZSBjYW5ub3Qgc3RvcmUgbW9yZSB0aGFuIFtjYXBhY2l0eV0gZWxlbWVu dHMgaW4gYSBbUXVldWVdLiAgUmVwbGFjaW5nCmFsbCBRdWV1ZSB3aXRoIHRo aXMgbW9kdWxlIHdpbGwgdGhlbiBlbnN1cmUgYXQgY29tcGlsZSB0aW1lIHRo YXQgYWxsIFF1ZXVlcwphcmUgY29ycmVjdGx5IGJvdW5kIGNoZWNrZWQuCgpF YWNoIGVsZW1lbnQgaW4gdGhlIHF1ZXVlIGhhcyBhIGNsYXNzIHdpdGggaXRz IG93biBsaW1pdHMuICBUaGlzLCBpbiBhCnN1YnNlcXVlbnQgY2hhbmdlLCB3 aWxsIGVuc3VyZSB0aGF0IGNvbW1hbmQgcmVzcG9uc2VzIGNhbiBwcm9jZWVk IGR1cmluZyBhCmZsb29kIG9mIHdhdGNoIGV2ZW50cy4KCk5vIGZ1bmN0aW9u YWwgY2hhbmdlLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRl ZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVk LW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5k aWdAY2l0cml4LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJz L3hiL3hiLm1sIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbAppbmRleCAx NjVmZDRhMWVkZjQuLjQxOTdhMzg4OGE2OCAxMDA2NDQKLS0tIGEvdG9vbHMv b2NhbWwvbGlicy94Yi94Yi5tbAorKysgYi90b29scy9vY2FtbC9saWJzL3hi L3hiLm1sCkBAIC0xNyw2ICsxNyw5OCBAQAogbW9kdWxlIE9wID0gc3RydWN0 IGluY2x1ZGUgT3AgZW5kCiBtb2R1bGUgUGFja2V0ID0gc3RydWN0IGluY2x1 ZGUgUGFja2V0IGVuZAogCittb2R1bGUgQm91bmRlZFF1ZXVlIDogc2lnCisJ dHlwZSAoJ2EsICdiKSB0CisKKwkoKiogW2NyZWF0ZSB+Y2FwYWNpdHkgfmNs YXNzaWZ5IH5saW1pdF0gY3JlYXRlcyBhIHF1ZXVlIHdpdGggbWF4aW11bSBb Y2FwYWNpdHldIGVsZW1lbnRzLgorCSAgICBUaGlzIGlzIGJ1cnN0IGNhcGFj aXR5LCBlYWNoIGVsZW1lbnQgaXMgZnVydGhlciBjbGFzc2lmaWVkIGFjY29y ZGluZyB0byBbY2xhc3NpZnldLAorCSAgICBhbmQgZWFjaCBjbGFzcyBjYW4g aGF2ZSBpdHMgb3duIFtsaW1pdF0uCisJICAgIFtjYXBhY2l0eV0gaXMgZW5m b3JjZWQgYXMgYW4gb3ZlcmFsbCBsaW1pdC4KKwkgICAgVGhlIFtsaW1pdF0g Y2FuIGJlIGR5bmFtaWMsIGFuZCBjYW4gYmUgc21hbGxlciB0aGFuIHRoZSBu dW1iZXIgb2YgZWxlbWVudHMgYWxyZWFkeSBxdWV1ZWQgb2YgdGhhdCBjbGFz cywKKwkgICAgaW4gd2hpY2ggY2FzZSB0aG9zZSBlbGVtZW50cyBhcmUgY29u c2lkZXJlZCB0byB1c2UgImJ1cnN0IGNhcGFjaXR5Ii4KKwkgICopCisJdmFs IGNyZWF0ZTogY2FwYWNpdHk6aW50IC0+IGNsYXNzaWZ5OignYSAtPiAnYikg LT4gbGltaXQ6KCdiIC0+IGludCkgLT4gKCdhLCAnYikgdAorCisJKCoqIFtj bGVhciBxXSBkaXNjYXJkcyBhbGwgZWxlbWVudHMgZnJvbSBbcV0gKikKKwl2 YWwgY2xlYXI6ICgnYSwgJ2IpIHQgLT4gdW5pdAorCisJKCoqIFtjYW5fcHVz aCBxXSB3aGVuIFtsZW5ndGggcSA8IGNhcGFjaXR5XS4JKikKKwl2YWwgY2Fu X3B1c2g6ICgnYSwgJ2IpIHQgLT4gJ2IgLT4gYm9vbAorCisJKCoqIFtwdXNo IGUgcV0gYWRkcyBbZV0gYXQgdGhlIGVuZCBvZiBxdWV1ZSBbcV0gaWYgW2Nh bl9wdXNoIHFdLCBvciByZXR1cm5zIFtOb25lXS4gKikKKwl2YWwgcHVzaDog J2EgLT4gKCdhLCAnYikgdCAtPiB1bml0IG9wdGlvbgorCisJKCoqIFtwb3Ag cV0gcmVtb3ZlcyBhbmQgcmV0dXJucyBmaXJzdCBlbGVtZW50IGluIFtxXSwg b3IgcmFpc2VzIFtRdWV1ZS5FbXB0eV0uICopCisJdmFsIHBvcDogKCdhLCAn YikgdCAtPiAnYQorCisJKCoqIFtwZWVrIHFdIHJldHVybnMgdGhlIGZpcnN0 IGVsZW1lbnQgaW4gW3FdLCBvciByYWlzZXMgW1F1ZXVlLkVtcHR5XS4gICop CisJdmFsIHBlZWsgOiAoJ2EsICdiKSB0IC0+ICdhCisKKwkoKiogW2xlbmd0 aCBxXSByZXR1cm5zIHRoZSBjdXJyZW50IG51bWJlciBvZiBlbGVtZW50cyBp biBbcV0gKikKKwl2YWwgbGVuZ3RoOiAoJ2EsICdiKSB0IC0+IGludAorCisJ KCoqIFtkZWJ1ZyBzdHJpbmdfb2ZfY2xhc3MgcV0gcHJpbnRzIHF1ZXVlIHVz YWdlIHN0YXRpc3RpY3MgaW4gYW4gdW5zcGVjaWZpZWQgaW50ZXJuYWwgZm9y bWF0LiAqKQorCXZhbCBkZWJ1ZzogKCdiIC0+IHN0cmluZykgLT4gKF8sICdi KSB0IC0+IHN0cmluZworZW5kID0gc3RydWN0CisJdHlwZSAoJ2EsICdiKSB0 ID0KKwkJeyBxOiAnYSBRdWV1ZS50CisJCTsgY2FwYWNpdHk6IGludAorCQk7 IGNsYXNzaWZ5OiAnYSAtPiAnYgorCQk7IGxpbWl0OiAnYiAtPiBpbnQKKwkJ OyBjbGFzc19jb3VudDogKCdiLCBpbnQpIEhhc2h0YmwudAorCQl9CisKKwls ZXQgY3JlYXRlIH5jYXBhY2l0eSB+Y2xhc3NpZnkgfmxpbWl0ID0KKwkJeyBj YXBhY2l0eTsgcSA9IFF1ZXVlLmNyZWF0ZSAoKTsgY2xhc3NpZnk7IGxpbWl0 OyBjbGFzc19jb3VudCA9IEhhc2h0YmwuY3JlYXRlIDMgfQorCisJbGV0IGdl dF9jb3VudCB0IGNsYXNzaWZpY2F0aW9uID0gdHJ5IEhhc2h0YmwuZmluZCB0 LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0aW9uIHdpdGggTm90X2ZvdW5kIC0+ IDAKKworCWxldCBjYW5fcHVzaF9pbnRlcm5hbCB0IGNsYXNzaWZpY2F0aW9u IGNsYXNzX2NvdW50ID0KKwkJUXVldWUubGVuZ3RoIHQucSA8IHQuY2FwYWNp dHkgJiYgY2xhc3NfY291bnQgPCB0LmxpbWl0IGNsYXNzaWZpY2F0aW9uCisK KwlsZXQgb2sgPSBTb21lICgpCisKKwlsZXQgcHVzaCBlIHQgPQorCQlsZXQg Y2xhc3NpZmljYXRpb24gPSB0LmNsYXNzaWZ5IGUgaW4KKwkJbGV0IGNsYXNz X2NvdW50ID0gZ2V0X2NvdW50IHQgY2xhc3NpZmljYXRpb24gaW4KKwkJaWYg Y2FuX3B1c2hfaW50ZXJuYWwgdCBjbGFzc2lmaWNhdGlvbiBjbGFzc19jb3Vu dCB0aGVuIGJlZ2luCisJCQlRdWV1ZS5wdXNoIGUgdC5xOworCQkJSGFzaHRi bC5yZXBsYWNlIHQuY2xhc3NfY291bnQgY2xhc3NpZmljYXRpb24gKGNsYXNz X2NvdW50ICsgMSk7CisJCQlvaworCQllbmQKKwkJZWxzZQorCQkJTm9uZQor CisJbGV0IGNhbl9wdXNoIHQgY2xhc3NpZmljYXRpb24gPQorCQljYW5fcHVz aF9pbnRlcm5hbCB0IGNsYXNzaWZpY2F0aW9uIEBAIGdldF9jb3VudCB0IGNs YXNzaWZpY2F0aW9uCisKKwlsZXQgY2xlYXIgdCA9CisJCVF1ZXVlLmNsZWFy IHQucTsKKwkJSGFzaHRibC5yZXNldCB0LmNsYXNzX2NvdW50CisKKwlsZXQg cG9wIHQgPQorCQlsZXQgZSA9IFF1ZXVlLnBvcCB0LnEgaW4KKwkJbGV0IGNs YXNzaWZpY2F0aW9uID0gdC5jbGFzc2lmeSBlIGluCisJCWxldCAoKSA9IG1h dGNoIGdldF9jb3VudCB0IGNsYXNzaWZpY2F0aW9uIC0gMSB3aXRoCisJCXwg MCAtPiBIYXNodGJsLnJlbW92ZSB0LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0 aW9uICgqIHJlZHVjZXMgbWVtdXNhZ2UgKikKKwkJfCBuIC0+IEhhc2h0Ymwu cmVwbGFjZSB0LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0aW9uIG4KKwkJaW4K KwkJZQorCisJbGV0IHBlZWsgdCA9IFF1ZXVlLnBlZWsgdC5xCisJbGV0IGxl bmd0aCB0ID0gUXVldWUubGVuZ3RoIHQucQorCisJbGV0IGRlYnVnIHN0cmlu Z19vZl9jbGFzcyB0ID0KKwkJbGV0IGIgPSBCdWZmZXIuY3JlYXRlIDEyOCBp bgorCQlQcmludGYuYnByaW50ZiBiICJCb3VuZGVkUXVldWUgY2FwYWNpdHk6 ICVkLCB1c2VkOiB7IiB0LmNhcGFjaXR5OworCQlIYXNodGJsLml0ZXIgKGZ1 biBwYWNrZXRfY2xhc3MgY291bnQgLT4KKwkJCVByaW50Zi5icHJpbnRmIGIg IgklczogJWQiIChzdHJpbmdfb2ZfY2xhc3MgcGFja2V0X2NsYXNzKSBjb3Vu dAorCQkpIHQuY2xhc3NfY291bnQ7CisJCVByaW50Zi5icHJpbnRmIGIgIn0i OworCQlCdWZmZXIuY29udGVudHMgYgorZW5kCisKKwogZXhjZXB0aW9uIEVu ZF9vZl9maWxlCiBleGNlcHRpb24gRWFnYWluCiBleGNlcHRpb24gTm9lbnQK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-oxenstored-07.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-oxenstored-07.patch" Content-Transfer-Encoding: base64 RnJvbSA5ZDU1YWViZGFmYzBkYzQ4NjBkYThmMDBhZDQ4NDQwNzg1MGQzNjQ3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNCArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogTGltaXQgbWF4aW11bSBpbi1mbGlnaHQgcmVx dWVzdHMgLyBvdXRzdGFuZGluZyByZXBsaWVzCk1JTUUtVmVyc2lvbjogMS4w CkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250 ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgpJbnRyb2R1Y2UgYSBsaW1p dCBvbiB0aGUgbnVtYmVyIG9mIG91dHN0YW5kaW5nIHJlcGx5IHBhY2tldHMg aW4gdGhlIHhlbmJ1cwpxdWV1ZS4gIFRoaXMgbGltaXRzIHRoZSBudW1iZXIg b2YgaW4tZmxpZ2h0IHJlcXVlc3RzOiB3aGVuIHRoZSBvdXRwdXQgcXVldWUg aXMKZnVsbCB3ZSdsbCBzdG9wIHByb2Nlc3NpbmcgaW5wdXRzIHVudGlsIHRo ZSBvdXRwdXQgcXVldWUgaGFzIHJvb20gYWdhaW4uCgpUbyBhdm9pZCBhIGJ1 c3kgbG9vcCBvbiB0aGUgVW5peCBzb2NrZXQgd2Ugb25seSBhZGQgaXQgdG8g dGhlIHdhdGNoZWQgaW5wdXQKZmlsZSBkZXNjcmlwdG9yIHNldCBpZiB3ZSdk IGJlIGFibGUgdG8gY2FsbCBgaW5wdXRgIG9uIGl0LiAgRXZlbiB0aG91Z2gg RG9tMAppcyB0cnVzdGVkIGFuZCBleGVtcHQgZnJvbSBxdW90YXMgYSBmbG9v ZCBvZiBldmVudHMgbWlnaHQgY2F1c2UgYSBiYWNrbG9nCndoZXJlIGV2ZW50 cyBhcmUgcHJvZHVjZWQgZmFzdGVyIHRoYW4gZGFlbW9ucyBpbiBEb20wIGNh biBjb25zdW1lIHRoZW0sIHdoaWNoCmNvdWxkIGxlYWQgdG8gYW4gdW5ib3Vu ZGVkIHF1ZXVlIHNpemUgYW5kIE9PTS4KClRoZXJlZm9yZSB0aGUgeGVuYnVz IHF1ZXVlIGxpbWl0IG11c3QgYXBwbHkgdG8gYWxsIGNvbm5lY3Rpb25zLCBE b20wIGlzIG5vdApleGVtcHQgZnJvbSBpdCwgYWx0aG91Z2ggaWYgZXZlcnl0 aGluZyB3b3JrcyBjb3JyZWN0bHkgaXQgd2lsbCBldmVudHVhbGx5CmNhdGNo IHVwLgoKVGhpcyBwcmV2ZW50cyBhIG1hbGljaW91cyBndWVzdCBmcm9tIHNl bmRpbmcgbW9yZSBjb21tYW5kcyB3aGlsZSBpdCBoYXMKb3V0c3RhbmRpbmcg d2F0Y2ggZXZlbnRzIG9yIGNvbW1hbmQgcmVwbGllcyBpbiBpdHMgaW5wdXQg cmluZy4gIEhvd2V2ZXIgaWYgaXQKY2FuIGNhdXNlIHRoZSBnZW5lcmF0aW9u IG9mIHdhdGNoIGV2ZW50cyBieSBvdGhlciBtZWFucyAoZS5nLiBieSBEb20w LCBvcgphbm90aGVyIGNvb3BlcmF0aXZlIGd1ZXN0KSBhbmQgc3RvcCByZWFk aW5nIGl0cyBvd24gcmluZyB0aGVuIHdhdGNoIGV2ZW50cwp3b3VsZCd2ZSBx dWV1ZWQgdXAgd2l0aG91dCBsaW1pdC4KClRoZSB4ZW5zdG9yZSBwcm90b2Nv bCBkb2Vzbid0IGhhdmUgYSBiYWNrLXByZXNzdXJlIG1lY2hhbmlzbSwgYW5k IGRvZXNuJ3QKYWxsb3cgZHJvcHBpbmcgd2F0Y2ggZXZlbnRzLiAgSW4gZmFj dCwgZHJvcHBpbmcgd2F0Y2ggZXZlbnRzIGlzIGtub3duIHRvIGJyZWFrCnNv bWUgcGllY2VzIG9mIG5vcm1hbCBmdW5jdGlvbmFsaXR5LiAgVGhpcyBsZWF2 ZXMgbGl0dGxlIGNob2ljZSB0byBzYWZlbHkKaW1wbGVtZW50IHRoZSB4ZW5z dG9yZSBwcm90b2NvbCB3aXRob3V0IGV4cG9zaW5nIHRoZSB4ZW5zdG9yZSBk YWVtb24gdG8Kb3V0LW9mLW1lbW9yeSBhdHRhY2tzLgoKSW1wbGVtZW50IHRo ZSBmaXggYXMgcGlwZXMgd2l0aCBib3VuZGVkIGJ1ZmZlcnM6CiogVXNlIGEg Ym91bmRlZCBidWZmZXIgZm9yIHdhdGNoIGV2ZW50cwoqIFRoZSB3YXRjaCBz dHJ1Y3R1cmUgd2lsbCBoYXZlIGEgYm91bmRlZCByZWNlaXZpbmcgcGlwZSBv ZiB3YXRjaCBldmVudHMKKiBUaGUgc291cmNlIHdpbGwgaGF2ZSBhbiAib3Zl cmZsb3ciIHBpcGUgb2YgcGVuZGluZyB3YXRjaCBldmVudHMgaXQgY291bGRu J3QKICBkZWxpdmVyCgpJdGVtcyBhcmUgcXVldWVkIHVwIG9uIG9uZSBlbmQg YW5kIGFyZSBzZW50IGFzIGZhciBhbG9uZyB0aGUgcGlwZSBhcyBwb3NzaWJs ZToKCiAgc291cmNlIGRvbWFpbiAtPiB3YXRjaCAtPiB4ZW5idXMgb2YgdGFy Z2V0IC0+IHhlbnN0b3JlIHJpbmcvc29ja2V0IG9mIHRhcmdldAoKSWYgdGhl IHBpcGUgaXMgImZ1bGwiIGF0IGFueSBwb2ludCB0aGVuIGJhY2stcHJlc3N1 cmUgaXMgYXBwbGllZCBhbmQgd2UgcHJldmVudAptb3JlIGl0ZW1zIGZyb20g YmVpbmcgcXVldWVkIHVwLiAgRm9yIHRoZSBzb3VyY2UgZG9tYWluIHRoaXMg bWVhbnMgdGhhdCB3ZSdsbApzdG9wIGFjY2VwdGluZyBuZXcgY29tbWFuZHMg YXMgbG9uZyBhcyBpdHMgcGlwZSBidWZmZXIgaXMgbm90IGVtcHR5LgoKQmVm b3JlIHdlIHRyeSB0byBlbnF1ZXVlIGFuIGl0ZW0gd2UgZmlyc3QgY2hlY2sg d2hldGhlciBpdCBpcyBwb3NzaWJsZSB0byBzZW5kCml0IGZ1cnRoZXIgZG93 biB0aGUgcGlwZSwgYnkgYXR0ZW1wdGluZyB0byByZWN1cnNpdmVseSBmbHVz aCB0aGUgcGlwZXMuIFRoaXMKZW5zdXJlcyB0aGF0IHdlIHJldGFpbiB0aGUg b3JkZXIgb2YgZXZlbnRzIGFzIG11Y2ggYXMgcG9zc2libGUuCgpXZSBtaWdo dCBicmVhayBjYXVzYWxpdHkgb2Ygd2F0Y2ggZXZlbnRzIGlmIHRoZSB0YXJn ZXQgZG9tYWluJ3MgcXVldWUgaXMgZnVsbAphbmQgd2UgbmVlZCB0byBzdGFy dCB1c2luZyB0aGUgd2F0Y2gncyBxdWV1ZS4gIFRoaXMgaXMgYSBicmVha2lu ZyBjaGFuZ2UgaW4KdGhlIHhlbnN0b3JlIHByb3RvY29sLCBidXQgb25seSBm b3IgZG9tYWlucyB3aGljaCBhcmUgbm90IHByb2Nlc3NpbmcgdGhlaXIKaW5j b21pbmcgcmluZyBhcyBleHBlY3RlZC4KCldoZW4gYSB3YXRjaCBpcyBkZWxl dGVkIGl0cyBlbnRpcmUgcGVuZGluZyBxdWV1ZSBpcyBkcm9wcGVkIChubyBj b2RlIGlzIG5lZWRlZApmb3IgdGhhdCwgYmVjYXVzZSBpdCBpcyBwYXJ0IG9m IHRoZSAnd2F0Y2gnIHR5cGUpLgoKVGhlcmUgaXMgYSBjYWNoZSBvZiB3YXRj aGVzIHRoYXQgaGF2ZSBwZW5kaW5nIGV2ZW50cyB0aGF0IHdlIGF0dGVtcHQg dG8gZmx1c2gKYXQgZXZlcnkgY3ljbGUgaWYgcG9zc2libGUuCgpJbnRyb2R1 Y2UgMyBsaW1pdHMgaGVyZToKKiBxdW90YS1tYXh3YXRjaGV2ZW50cyBvbiB3 YXRjaCBldmVudCBkZXN0aW5hdGlvbjogd2hlbiB0aGlzIGlzIGhpdCB0aGUK ICBzb3VyY2Ugd2lsbCBub3QgYmUgYWxsb3dlZCB0byBxdWV1ZSB1cCBtb3Jl IHdhdGNoIGV2ZW50cy4KKiBxdW90YS1tYXhvdXN0YW5kaW5nIHdoaWNoIGlz IHRoZSBudW1iZXIgb2YgcmVzcG9uc2VzIG5vdCByZWFkIGZyb20gdGhlIHJp bmc6CiAgb25jZSBleGNlZWRlZCwgbm8gbW9yZSBpbnB1dHMgYXJlIHByb2Nl c3NlZCB1bnRpbCBhbGwgb3V0c3RhbmRpbmcgcmVwbGllcwogIGFyZSBjb25z dW1lZCBieSB0aGUgY2xpZW50LgoqIG92ZXJmbG93IHF1ZXVlIG9uIHRoZSB3 YXRjaCBldmVudCBzb3VyY2U6IGFsbCB3YXRjaGVzIHRoYXQgY2Fubm90IGJl IHN0b3JlZAogIG9uIGRlc3RpbmF0aW9uIGFyZSBxdWV1ZWQgdXAgaGVyZSwg YSBzaW5nbGUgY29tbWFuZCBjYW4gdHJpZ2dlciBtdWx0aXBsZQogIHdhdGNo ZXMgKGUuZy4gZHVlIHRvIHJlY3Vyc2lvbikuCgpUaGUgb3ZlcmZsb3cgcXVl dWUgY3VycmVudGx5IGRvZXNuJ3QgaGF2ZSBhbiB1cHBlciBib3VuZCwgaXQg aXMgZGlmZmljdWx0IHRvCmFjY3VyYXRlbHkgY2FsY3VsYXRlIG9uZSBhcyBp dCBkZXBlbmRzIG9uIHdoZXRoZXIgeW91IGFyZSBEb20wIGFuZCBob3cgbWFu eQp3YXRjaGVzIGVhY2ggcGF0aCBoYXMgcmVnaXN0ZXJlZCBhbmQgaG93IG1h bnkgd2F0Y2ggZXZlbnRzIHlvdSBjYW4gdHJpZ2dlcgp3aXRoIGEgc2luZ2xl IGNvbW1hbmQgKGUuZy4gYSBjb21taXQpLiAgSG93ZXZlciB0aGVzZSBldmVu dHMgd2VyZSBhbHJlYWR5CnVzaW5nIG1lbW9yeSwgdGhpcyBqdXN0IG1vdmVz IHRoZW0gZWxzZXdoZXJlLCBhbmQgYXMgbG9uZyBhcyB3ZSBjb3JyZWN0bHkK YmxvY2sgYSBkb21haW4gaXQgc2hvdWxkbid0IHJlc3VsdCBpbiB1bmJvdW5k ZWQgbWVtb3J5IHVzYWdlLgoKTm90ZSB0aGF0IERvbTAgaXMgbm90IGV4Y2x1 ZGVkIGZyb20gdGhlc2UgY2hlY2tzLCBpdCBpcyBpbXBvcnRhbnQgdGhhdCBE b20wIGlzCmVzcGVjaWFsbHkgbm90IGV4Y2x1ZGVkIHdoZW4gaXQgaXMgdGhl IHNvdXJjZSwgc2luY2UgdGhlcmUgYXJlIG1hbnkgd2F5cyBpbgp3aGljaCBh IGd1ZXN0IGNvdWxkIHRyaWdnZXIgRG9tMCB0byBzZW5kIGl0IHdhdGNoIGV2 ZW50cy4KClRoaXMgc2hvdWxkIHByb3RlY3QgYWdhaW5zdCBtYWxpY2lvdXMg ZnJvbnRlbmRzIGFzIGxvbmcgYXMgdGhlIGJhY2tlbmQgZm9sbG93cwp0aGUg UFYgeGVuc3RvcmUgcHJvdG9jb2wgYW5kIG9ubHkgZXhwb3NlcyBwYXRocyBu ZWVkZWQgYnkgdGhlIGZyb250ZW5kLCBhbmQKY2hhbmdlcyB0aG9zZSBwYXRo cyBhdCBtb3N0IG9uY2UgYXMgYSByZWFjdGlvbiB0byBndWVzdCBldmVudHMs IG9yIHByb3RvY29sCnN0YXRlLgoKVGhlIHF1ZXVlIGxpbWl0cyBhcmUgcGVy IHdhdGNoLCBhbmQgcGVyIGRvbWFpbi1wYWlyLCBzbyBldmVuIGlmIG9uZQpj b21tdW5pY2F0aW9uIGNoYW5uZWwgd291bGQgYmUgImJsb2NrZWQiLCBvdGhl cnMgd291bGQga2VlcCB3b3JraW5nLCBhbmQgdGhlCmRvbWFpbiBpdHNlbGYg d29uJ3QgZ2V0IGJsb2NrZWQgYXMgbG9uZyBhcyBpdCBkb2Vzbid0IG92ZXJm bG93IHRoZSBxdWV1ZSBvZgp3YXRjaCBldmVudHMuCgpTaW1pbGFybHkgYSBt YWxpY2lvdXMgYmFja2VuZCBjb3VsZCBjYXVzZSB0aGUgZnJvbnRlbmQgdG8g Z2V0IGJsb2NrZWQsIGJ1dAp0aGlzIHdhdGNoIHF1ZXVlIHByb3RlY3RzIHRo ZSBmcm9udGVuZCBhcyB3ZWxsIGFzIGxvbmcgYXMgaXQgZm9sbG93cyB0aGUg UFYKcHJvdG9jb2wuICAoQWx0aG91Z2ggbm90ZSB0aGF0IHByb3RlY3Rpb24g YWdhaW5zdCBtYWxpY2lvdXMgYmFja2VuZHMgaXMgb25seSBhCmJlc3QgZWZm b3J0IGF0IHRoZSBtb21lbnQpCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNiAv IENWRS0yMDIyLTQyMzE4LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLD tmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJpc3Rp YW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbCBiL3Rvb2xzL29j YW1sL2xpYnMveGIveGIubWwKaW5kZXggNDE5N2EzODg4YTY4Li5iMjkyZWQ3 YTg3NGQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWwK KysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbApAQCAtMTM0LDE0ICsx MzQsNDQgQEAgdHlwZSBiYWNrZW5kID0gRmQgb2YgYmFja2VuZF9mZCB8IFhl bm1tYXAgb2YgYmFja2VuZF9tbWFwCiAKIHR5cGUgcGFydGlhbF9idWYgPSBI YXZlSGRyIG9mIFBhcnRpYWwucGt0IHwgTm9IZHIgb2YgaW50ICogYnl0ZXMK IAorKCoKKwlzZXBhcmF0ZSBjYXBhY2l0eSByZXNlcnZhdGlvbiBmb3IgcmVw bGllcyBhbmQgd2F0Y2ggZXZlbnRzOgorCXRoaXMgYWxsb3dzIGEgZG9tYWlu IHRvIGtlZXAgd29ya2luZyBldmVuIHdoZW4gdW5kZXIgYSBjb25zdGFudCBm bG9vZCBvZgorCXdhdGNoIGV2ZW50cworKikKK3R5cGUgY2FwYWNpdHkgPSB7 IG1heG91dHN0YW5kaW5nOiBpbnQ7IG1heHdhdGNoZXZlbnRzOiBpbnQgfQor Cittb2R1bGUgUXVldWUgPSBCb3VuZGVkUXVldWUKKwordHlwZSBwYWNrZXRf Y2xhc3MgPQorCXwgQ29tbWFuZFJlcGx5CisJfCBXYXRjaGV2ZW50CisKK2xl dCBzdHJpbmdfb2ZfcGFja2V0X2NsYXNzID0gZnVuY3Rpb24KKwl8IENvbW1h bmRSZXBseSAtPiAiY29tbWFuZF9yZXBseSIKKwl8IFdhdGNoZXZlbnQgLT4g IndhdGNoX2V2ZW50IgorCiB0eXBlIHQgPQogewogCWJhY2tlbmQ6IGJhY2tl bmQ7Ci0JcGt0X291dDogUGFja2V0LnQgUXVldWUudDsKKwlwa3Rfb3V0OiAo UGFja2V0LnQsIHBhY2tldF9jbGFzcykgUXVldWUudDsKIAltdXRhYmxlIHBh cnRpYWxfaW46IHBhcnRpYWxfYnVmOwogCW11dGFibGUgcGFydGlhbF9vdXQ6 IHN0cmluZzsKKwljYXBhY2l0eTogY2FwYWNpdHkKIH0KIAorbGV0IHRvX3Jl YWQgY29uID0KKwltYXRjaCBjb24ucGFydGlhbF9pbiB3aXRoCisJCXwgSGF2 ZUhkciBwYXJ0aWFsX3BrdCAtPiBQYXJ0aWFsLnRvX2NvbXBsZXRlIHBhcnRp YWxfcGt0CisJCXwgTm9IZHIgICAoaSwgXykgICAgLT4gaQorCitsZXQgZGVi dWcgdCA9CisJUHJpbnRmLnNwcmludGYgIlhlbkJ1cyBzdGF0ZTogcGFydGlh bF9pbjogJWQgbmVlZGVkLCBwYXJ0aWFsX291dDogJWQgYnl0ZXMsIHBrdF9v dXQ6ICVkIHBhY2tldHMsICVzIgorCQkodG9fcmVhZCB0KQorCQkoU3RyaW5n Lmxlbmd0aCB0LnBhcnRpYWxfb3V0KQorCQkoUXVldWUubGVuZ3RoIHQucGt0 X291dCkKKwkJKEJvdW5kZWRRdWV1ZS5kZWJ1ZyBzdHJpbmdfb2ZfcGFja2V0 X2NsYXNzIHQucGt0X291dCkKKwogbGV0IGluaXRfcGFydGlhbF9pbiAoKSA9 IE5vSGRyCiAJKFBhcnRpYWwuaGVhZGVyX3NpemUgKCksIEJ5dGVzLm1ha2Ug KFBhcnRpYWwuaGVhZGVyX3NpemUoKSkgJ1wwMDAnKQogCkBAIC0xOTksNyAr MjI5LDggQEAgbGV0IG91dHB1dCBjb24gPQogCWxldCBzID0gaWYgU3RyaW5n Lmxlbmd0aCBjb24ucGFydGlhbF9vdXQgPiAwIHRoZW4KIAkJCWNvbi5wYXJ0 aWFsX291dAogCQllbHNlIGlmIFF1ZXVlLmxlbmd0aCBjb24ucGt0X291dCA+ IDAgdGhlbgotCQkJUGFja2V0LnRvX3N0cmluZyAoUXVldWUucG9wIGNvbi5w a3Rfb3V0KQorCQkJbGV0IHBrdCA9IFF1ZXVlLnBvcCBjb24ucGt0X291dCBp bgorCQkJUGFja2V0LnRvX3N0cmluZyBwa3QKIAkJZWxzZQogCQkJIiIgaW4K IAkoKiBzZW5kIGRhdGEgZnJvbSBzLCBhbmQgc2F2ZSB0aGUgdW5zZW50IGRh dGEgdG8gcGFydGlhbF9vdXQgKikKQEAgLTIxMiwxMiArMjQzLDE1IEBAIGxl dCBvdXRwdXQgY29uID0KIAkoKiBhZnRlciBzZW5kaW5nIG9uZSBwYWNrZXQs IHBhcnRpYWwgaXMgZW1wdHkgKikKIAljb24ucGFydGlhbF9vdXQgPSAiIgog CisoKiB3ZSBjYW4gb25seSBwcm9jZXNzIGFuIGlucHV0IHBhY2tldCBpZiB3 ZSdyZSBndWFyYW50ZWVkIHRvIGhhdmUgcm9vbQorICAgdG8gc3RvcmUgdGhl IHJlc3BvbnNlIHBhY2tldCAqKQorbGV0IGNhbl9pbnB1dCBjb24gPSBRdWV1 ZS5jYW5fcHVzaCBjb24ucGt0X291dCBDb21tYW5kUmVwbHkKKwogKCogTkI6 IGNhbiB0aHJvdyBSZWNvbm5lY3QgKikKIGxldCBpbnB1dCBjb24gPQotCWxl dCB0b19yZWFkID0KLQkJbWF0Y2ggY29uLnBhcnRpYWxfaW4gd2l0aAotCQl8 IEhhdmVIZHIgcGFydGlhbF9wa3QgLT4gUGFydGlhbC50b19jb21wbGV0ZSBw YXJ0aWFsX3BrdAotCQl8IE5vSGRyICAgKGksIF8pICAgIC0+IGkgaW4KKwlp ZiBub3QgKGNhbl9pbnB1dCBjb24pIHRoZW4gTm9uZQorCWVsc2UKKwlsZXQg dG9fcmVhZCA9IHRvX3JlYWQgY29uIGluCiAKIAkoKiB0cnkgdG8gZ2V0IG1v cmUgZGF0YSBmcm9tIGlucHV0IHN0cmVhbSAqKQogCWxldCBiID0gQnl0ZXMu bWFrZSB0b19yZWFkICdcMDAwJyBpbgpAQCAtMjQzLDExICsyNzcsMjIgQEAg bGV0IGlucHV0IGNvbiA9CiAJCU5vbmUKIAkpCiAKLWxldCBuZXdjb24gYmFj a2VuZCA9IHsKK2xldCBjbGFzc2lmeSB0ID0KKwltYXRjaCB0LlBhY2tldC50 eSB3aXRoCisJfCBPcC5XYXRjaGV2ZW50IC0+IFdhdGNoZXZlbnQKKwl8IF8g LT4gQ29tbWFuZFJlcGx5CisKK2xldCBuZXdjb24gfmNhcGFjaXR5IGJhY2tl bmQgPQorCWxldCBsaW1pdCA9IGZ1bmN0aW9uCisJCXwgQ29tbWFuZFJlcGx5 IC0+IGNhcGFjaXR5Lm1heG91dHN0YW5kaW5nCisJCXwgV2F0Y2hldmVudCAt PiBjYXBhY2l0eS5tYXh3YXRjaGV2ZW50cworCWluCisJewogCWJhY2tlbmQg PSBiYWNrZW5kOwotCXBrdF9vdXQgPSBRdWV1ZS5jcmVhdGUgKCk7CisJcGt0 X291dCA9IFF1ZXVlLmNyZWF0ZSB+Y2FwYWNpdHk6KGNhcGFjaXR5Lm1heG91 dHN0YW5kaW5nICsgY2FwYWNpdHkubWF4d2F0Y2hldmVudHMpIH5jbGFzc2lm eSB+bGltaXQ7CiAJcGFydGlhbF9pbiA9IGluaXRfcGFydGlhbF9pbiAoKTsK IAlwYXJ0aWFsX291dCA9ICIiOworCWNhcGFjaXR5ID0gY2FwYWNpdHk7CiAJ fQogCiBsZXQgb3Blbl9mZCBmZCA9IG5ld2NvbiAoRmQgeyBmZCA9IGZkOyB9 KQpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbGkgYi90 b29scy9vY2FtbC9saWJzL3hiL3hiLm1saQppbmRleCA5MWM2ODIxNjJjZWEu LjcxYjI3NTRjYTc4OCAxMDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94 Yi94Yi5tbGkKKysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbGkKQEAg LTY2LDEwICs2NiwxMSBAQCB0eXBlIGJhY2tlbmRfbW1hcCA9IHsKIHR5cGUg YmFja2VuZF9mZCA9IHsgZmQgOiBVbml4LmZpbGVfZGVzY3I7IH0KIHR5cGUg YmFja2VuZCA9IEZkIG9mIGJhY2tlbmRfZmQgfCBYZW5tbWFwIG9mIGJhY2tl bmRfbW1hcAogdHlwZSBwYXJ0aWFsX2J1ZiA9IEhhdmVIZHIgb2YgUGFydGlh bC5wa3QgfCBOb0hkciBvZiBpbnQgKiBieXRlcwordHlwZSBjYXBhY2l0eSA9 IHsgbWF4b3V0c3RhbmRpbmc6IGludDsgbWF4d2F0Y2hldmVudHM6IGludCB9 CiB0eXBlIHQKIHZhbCBpbml0X3BhcnRpYWxfaW4gOiB1bml0IC0+IHBhcnRp YWxfYnVmCiB2YWwgcmVjb25uZWN0IDogdCAtPiB1bml0Ci12YWwgcXVldWUg OiB0IC0+IFBhY2tldC50IC0+IHVuaXQKK3ZhbCBxdWV1ZSA6IHQgLT4gUGFj a2V0LnQgLT4gdW5pdCBvcHRpb24KIHZhbCByZWFkX2ZkIDogYmFja2VuZF9m ZCAtPiAnYSAtPiBieXRlcyAtPiBpbnQgLT4gaW50CiB2YWwgcmVhZF9tbWFw IDogYmFja2VuZF9tbWFwIC0+ICdhIC0+IGJ5dGVzIC0+IGludCAtPiBpbnQK IHZhbCByZWFkIDogdCAtPiBieXRlcyAtPiBpbnQgLT4gaW50CkBAIC03OCwx MyArNzksMTQgQEAgdmFsIHdyaXRlX21tYXAgOiBiYWNrZW5kX21tYXAgLT4g J2EgLT4gc3RyaW5nIC0+IGludCAtPiBpbnQKIHZhbCB3cml0ZSA6IHQgLT4g c3RyaW5nIC0+IGludCAtPiBpbnQKIHZhbCBvdXRwdXQgOiB0IC0+IGJvb2wK IHZhbCBpbnB1dCA6IHQgLT4gUGFja2V0LnQgb3B0aW9uCi12YWwgbmV3Y29u IDogYmFja2VuZCAtPiB0Ci12YWwgb3Blbl9mZCA6IFVuaXguZmlsZV9kZXNj ciAtPiB0Ci12YWwgb3Blbl9tbWFwIDogWGVubW1hcC5tbWFwX2ludGVyZmFj ZSAtPiAodW5pdCAtPiB1bml0KSAtPiB0Cit2YWwgbmV3Y29uIDogY2FwYWNp dHk6Y2FwYWNpdHkgLT4gYmFja2VuZCAtPiB0Cit2YWwgb3Blbl9mZCA6IFVu aXguZmlsZV9kZXNjciAtPiBjYXBhY2l0eTpjYXBhY2l0eSAtPiB0Cit2YWwg b3Blbl9tbWFwIDogWGVubW1hcC5tbWFwX2ludGVyZmFjZSAtPiAodW5pdCAt PiB1bml0KSAtPiBjYXBhY2l0eTpjYXBhY2l0eSAtPiB0CiB2YWwgY2xvc2Ug OiB0IC0+IHVuaXQKIHZhbCBpc19mZCA6IHQgLT4gYm9vbAogdmFsIGlzX21t YXAgOiB0IC0+IGJvb2wKIHZhbCBvdXRwdXRfbGVuIDogdCAtPiBpbnQKK3Zh bCBjYW5faW5wdXQ6IHQgLT4gYm9vbAogdmFsIGhhc19uZXdfb3V0cHV0IDog dCAtPiBib29sCiB2YWwgaGFzX29sZF9vdXRwdXQgOiB0IC0+IGJvb2wKIHZh bCBoYXNfb3V0cHV0IDogdCAtPiBib29sCkBAIC05MywzICs5NSw0IEBAIHZh bCBoYXNfcGFydGlhbF9pbnB1dCA6IHQgLT4gYm9vbAogdmFsIGhhc19tb3Jl X2lucHV0IDogdCAtPiBib29sCiB2YWwgaXNfc2VsZWN0YWJsZSA6IHQgLT4g Ym9vbAogdmFsIGdldF9mZCA6IHQgLT4gVW5peC5maWxlX2Rlc2NyCit2YWwg ZGVidWc6IHQgLT4gc3RyaW5nCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9s aWJzL3hzL3F1ZXVlb3AubWwgYi90b29scy9vY2FtbC9saWJzL3hzL3F1ZXVl b3AubWwKaW5kZXggOWZmNWJiZDUyOWNlLi40ZTUzMmNkYWVhY2IgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveHMvcXVldWVvcC5tbAorKysgYi90 b29scy9vY2FtbC9saWJzL3hzL3F1ZXVlb3AubWwKQEAgLTE2LDkgKzE2LDEw IEBACiBvcGVuIFhlbmJ1cwogCiBsZXQgZGF0YV9jb25jYXQgbHMgPSAoU3Ry aW5nLmNvbmNhdCAiXDAwMCIgbHMpIF4gIlwwMDAiCitsZXQgcXVldWUgY29u IHBrdCA9IGxldCByID0gWGIucXVldWUgY29uIHBrdCBpbiBhc3NlcnQgKHIg PD4gTm9uZSkKIGxldCBxdWV1ZV9wYXRoIHR5ICh0aWQ6IGludCkgKHBhdGg6 IHN0cmluZykgY29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgcGF0 aDsgXSBpbgotCVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSB0aWQg MCB0eSBkYXRhKQorCXF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSB0aWQg MCB0eSBkYXRhKQogCiAoKiBvcGVyYXRpb25zICopCiBsZXQgZGlyZWN0b3J5 IHRpZCBwYXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuRGlyZWN0b3J5IHRp ZCBwYXRoIGNvbgpAQCAtMjcsNDggKzI4LDQ4IEBAIGxldCByZWFkIHRpZCBw YXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuUmVhZCB0aWQgcGF0aCBjb24K IGxldCBnZXRwZXJtcyB0aWQgcGF0aCBjb24gPSBxdWV1ZV9wYXRoIFhiLk9w LkdldHBlcm1zIHRpZCBwYXRoIGNvbgogCiBsZXQgZGVidWcgY29tbWFuZHMg Y29uID0KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhi Lk9wLkRlYnVnIChkYXRhX2NvbmNhdCBjb21tYW5kcykpCisJcXVldWUgY29u IChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5EZWJ1ZyAoZGF0YV9jb25j YXQgY29tbWFuZHMpKQogCiBsZXQgd2F0Y2ggcGF0aCBkYXRhIGNvbiA9CiAJ bGV0IGRhdGEgPSBkYXRhX2NvbmNhdCBbIHBhdGg7IGRhdGE7IF0gaW4KLQlY Yi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhiLk9wLldhdGNo IGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5P cC5XYXRjaCBkYXRhKQogCiBsZXQgdW53YXRjaCBwYXRoIGRhdGEgY29uID0K IAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgcGF0aDsgZGF0YTsgXSBpbgot CVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuVW53 YXRjaCBkYXRhKQorCXF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAg WGIuT3AuVW53YXRjaCBkYXRhKQogCiBsZXQgdHJhbnNhY3Rpb25fc3RhcnQg Y29uID0KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhi Lk9wLlRyYW5zYWN0aW9uX3N0YXJ0IChkYXRhX2NvbmNhdCBbXSkpCisJcXVl dWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5UcmFuc2FjdGlv bl9zdGFydCAoZGF0YV9jb25jYXQgW10pKQogCiBsZXQgdHJhbnNhY3Rpb25f ZW5kIHRpZCBjb21taXQgY29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0 IFsgKGlmIGNvbW1pdCB0aGVuICJUIiBlbHNlICJGIik7IF0gaW4KLQlYYi5x dWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuVHJhbnNh Y3Rpb25fZW5kIGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRl IHRpZCAwIFhiLk9wLlRyYW5zYWN0aW9uX2VuZCBkYXRhKQogCiBsZXQgaW50 cm9kdWNlIGRvbWlkIG1mbiBwb3J0IGNvbiA9CiAJbGV0IGRhdGEgPSBkYXRh X2NvbmNhdCBbIFByaW50Zi5zcHJpbnRmICIldSIgZG9taWQ7CiAJICAgICAg ICAgICAgICAgICAgICAgICAgIFByaW50Zi5zcHJpbnRmICIlbnUiIG1mbjsK IAkgICAgICAgICAgICAgICAgICAgICAgICAgc3RyaW5nX29mX2ludCBwb3J0 OyBdIGluCi0JWGIucXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBY Yi5PcC5JbnRyb2R1Y2UgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBhY2tldC5j cmVhdGUgMCAwIFhiLk9wLkludHJvZHVjZSBkYXRhKQogCiBsZXQgcmVsZWFz ZSBkb21pZCBjb24gPQogCWxldCBkYXRhID0gZGF0YV9jb25jYXQgWyBQcmlu dGYuc3ByaW50ZiAiJXUiIGRvbWlkOyBdIGluCi0JWGIucXVldWUgY29uIChY Yi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5SZWxlYXNlIGRhdGEpCisJcXVl dWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5SZWxlYXNlIGRh dGEpCiAKIGxldCByZXN1bWUgZG9taWQgY29uID0KIAlsZXQgZGF0YSA9IGRh dGFfY29uY2F0IFsgUHJpbnRmLnNwcmludGYgIiV1IiBkb21pZDsgXSBpbgot CVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuUmVz dW1lIGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBY Yi5PcC5SZXN1bWUgZGF0YSkKIAogbGV0IGdldGRvbWFpbnBhdGggZG9taWQg Y29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgUHJpbnRmLnNwcmlu dGYgIiV1IiBkb21pZDsgXSBpbgotCVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0 LmNyZWF0ZSAwIDAgWGIuT3AuR2V0ZG9tYWlucGF0aCBkYXRhKQorCXF1ZXVl IGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuR2V0ZG9tYWlucGF0 aCBkYXRhKQogCiBsZXQgd3JpdGUgdGlkIHBhdGggdmFsdWUgY29uID0KIAls ZXQgZGF0YSA9IHBhdGggXiAiXDAwMCIgXiB2YWx1ZSAoKiBubyBOVUxMIGF0 IHRoZSBlbmQgKikgaW4KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVh dGUgdGlkIDAgWGIuT3AuV3JpdGUgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBh Y2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuV3JpdGUgZGF0YSkKIAogbGV0IG1r ZGlyIHRpZCBwYXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuTWtkaXIgdGlk IHBhdGggY29uCiBsZXQgcm0gdGlkIHBhdGggY29uID0gcXVldWVfcGF0aCBY Yi5PcC5SbSB0aWQgcGF0aCBjb24KIAogbGV0IHNldHBlcm1zIHRpZCBwYXRo IHBlcm1zIGNvbiA9CiAJbGV0IGRhdGEgPSBkYXRhX2NvbmNhdCBbIHBhdGg7 IHBlcm1zIF0gaW4KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUg dGlkIDAgWGIuT3AuU2V0cGVybXMgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBh Y2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuU2V0cGVybXMgZGF0YSkKZGlmZiAt LWdpdCBhL3Rvb2xzL29jYW1sL2xpYnMveHMveHNyYXcubWwgYi90b29scy9v Y2FtbC9saWJzL3hzL3hzcmF3Lm1sCmluZGV4IDQ1MWY4YjM4ZGJjYy4uY2Jk MTcyODA2MDBjIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9saWJzL3hzL3hz cmF3Lm1sCisrKyBiL3Rvb2xzL29jYW1sL2xpYnMveHMveHNyYXcubWwKQEAg LTM2LDggKzM2LDEwIEBAIHR5cGUgY29uID0gewogbGV0IGNsb3NlIGNvbiA9 CiAJWGIuY2xvc2UgY29uLnhiCiAKK2xldCBjYXBhY2l0eSA9IHsgWGIubWF4 b3V0c3RhbmRpbmcgPSAxOyBtYXh3YXRjaGV2ZW50cyA9IDA7IH0KKwogbGV0 IG9wZW5fZmQgZmQgPSB7Ci0JeGIgPSBYYi5vcGVuX2ZkIGZkOworCXhiID0g WGIub3Blbl9mZCB+Y2FwYWNpdHkgZmQ7CiAJd2F0Y2hldmVudHMgPSBRdWV1 ZS5jcmVhdGUgKCk7CiB9CiAKZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hl bnN0b3JlZC9jb25uZWN0aW9uLm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVk L2Nvbm5lY3Rpb24ubWwKaW5kZXggYWNlMmFhNWI0ZjUzLi45YWFkNDUxYTJk YmQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0 aW9uLm1sCisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9u Lm1sCkBAIC0yMCwxMiArMjAsODQgQEAgb3BlbiBTdGRleHQKIAogbGV0IHhl bnN0b3JlX3BheWxvYWRfbWF4ID0gNDA5NiAoKiB4ZW4vaW5jbHVkZS9wdWJs aWMvaW8veHNfd2lyZS5oICopCiAKK3R5cGUgJ2EgYm91bmRlZF9zZW5kZXIg PSAnYSAtPiB1bml0IG9wdGlvbgorKCoqIGEgYm91bmRlZCBzZW5kZXIgYWNj ZXB0cyBhbiBbJ2FdIGl0ZW0gYW5kIHJldHVybnM6CisgICAgTm9uZSAtIGlm IHRoZXJlIGlzIG5vIHJvb20gdG8gYWNjZXB0IHRoZSBpdGVtCisgICAgU29t ZSAoKSAtICBpZiBpdCBoYXMgc3VjY2Vzc2Z1bGx5IGFjY2VwdGVkL3NlbnQg dGhlIGl0ZW0KKyAqKQorCittb2R1bGUgQm91bmRlZFBpcGUgOiBzaWcKKwl0 eXBlICdhIHQKKworCSgqKiBbY3JlYXRlIH5jYXBhY2l0eSB+ZGVzdGluYXRp b25dIGNyZWF0ZXMgYSBib3VuZGVkIHBpcGUgd2l0aCBhCisJICAgIGxvY2Fs IGJ1ZmZlciBob2xkaW5nIGF0IG1vc3QgW2NhcGFjaXR5XSBpdGVtcy4gIE9u Y2UgdGhlIGJ1ZmZlciBpcworCSAgICBmdWxsIGl0IHdpbGwgbm90IGFjY2Vw dCBmdXJ0aGVyIGl0ZW1zLiAgaXRlbXMgZnJvbSB0aGUgcGlwZSBhcmUKKwkg ICAgZmx1c2hlZCBpbnRvIFtkZXN0aW5hdGlvbl0gYXMgbG9uZyBhcyBpdCBh Y2NlcHRzIGl0ZW1zLiAgVGhlCisJICAgIGRlc3RpbmF0aW9uIGNvdWxkIGJl IGFub3RoZXIgcGlwZS4KKwkgKikKKwl2YWwgY3JlYXRlOiBjYXBhY2l0eTpp bnQgLT4gZGVzdGluYXRpb246J2EgYm91bmRlZF9zZW5kZXIgLT4gJ2EgdAor CisJKCoqIFtpc19lbXB0eSB0XSByZXR1cm5zIHdoZXRoZXIgdGhlIGxvY2Fs IGJ1ZmZlciBvZiBbdF0gaXMgZW1wdHkuICopCisJdmFsIGlzX2VtcHR5IDog XyB0IC0+IGJvb2wKKworCSgqKiBbbGVuZ3RoIHRdIHRoZSBudW1iZXIgb2Yg aXRlbXMgaW4gdGhlIGludGVybmFsIGJ1ZmZlciAqKQorCXZhbCBsZW5ndGg6 IF8gdCAtPiBpbnQKKworCSgqKiBbZmx1c2hfcGlwZSB0XSBzZW5kcyBhcyBt YW55IGl0ZW1zIGZyb20gdGhlIGxvY2FsIGJ1ZmZlciBhcyBwb3NzaWJsZSwK KwkJCXdoaWNoIGNvdWxkIGJlIG5vbmUuICopCisJdmFsIGZsdXNoX3BpcGU6 IF8gdCAtPiB1bml0CisKKwkoKiogW3B1c2ggdCBpdGVtXSB0cmllcyB0byBb Zmx1c2hfcGlwZV0gYW5kIHRoZW4gcHVzaCBbaXRlbV0KKwkgICAgaW50byB0 aGUgcGlwZSBpZiBpdHMgW2NhcGFjaXR5XSBhbGxvd3MuCisJICAgIFJldHVy bnMgW05vbmVdIGlmIHRoZXJlIGlzIG5vIG1vcmUgcm9vbQorCSAqKQorCXZh bCBwdXNoIDogJ2EgdCAtPiAnYSBib3VuZGVkX3NlbmRlcgorZW5kID0gc3Ry dWN0CisJKCogaXRlbXMgYXJlIGVucXVldWVkIGluIFtxXSwgYW5kIHRoZW4g Zmx1c2hlZCB0byBbY29ubmVjdF90b10gKikKKwl0eXBlICdhIHQgPQorCQl7 IHE6ICdhIFF1ZXVlLnQKKwkJOyBkZXN0aW5hdGlvbjogJ2EgYm91bmRlZF9z ZW5kZXIKKwkJOyBjYXBhY2l0eTogaW50CisJCX0KKworCWxldCBjcmVhdGUg fmNhcGFjaXR5IH5kZXN0aW5hdGlvbiA9CisJCXsgcSA9IFF1ZXVlLmNyZWF0 ZSAoKTsgY2FwYWNpdHk7IGRlc3RpbmF0aW9uIH0KKworCWxldCByZWMgZmx1 c2hfcGlwZSB0ID0KKwkJaWYgbm90IFF1ZXVlLihpc19lbXB0eSB0LnEpIHRo ZW4KKwkJCWxldCBpdGVtID0gUXVldWUucGVlayB0LnEgaW4KKwkJCW1hdGNo IHQuZGVzdGluYXRpb24gaXRlbSB3aXRoCisJCQl8IE5vbmUgLT4gKCkgKCog bm8gcm9vbSAqKQorCQkJfCBTb21lICgpIC0+CisJCQkJKCogc3VjY2Vzc2Z1 bGx5IHNlbnQgaXRlbSB0byBuZXh0IHN0YWdlICopCisJCQkJbGV0IF8gPSBR dWV1ZS5wb3AgdC5xIGluCisJCQkJKCogY29udGludWUgdHJ5aW5nIHRvIHNl bmQgbW9yZSBpdGVtcyAqKQorCQkJCWZsdXNoX3BpcGUgdAorCisJbGV0IHB1 c2ggdCBpdGVtID0KKwkJKCogZmlyc3QgdHJ5IHRvIGZsdXNoIGFzIG1hbnkg aXRlbXMgZnJvbSB0aGlzIHBpcGUgYXMgcG9zc2libGUgdG8gbWFrZSByb29t LAorCQkgICBpdCBpcyBpbXBvcnRhbnQgdG8gZG8gdGhpcyBmaXJzdCB0byBw cmVzZXJ2ZSB0aGUgb3JkZXIgb2YgdGhlIGl0ZW1zCisJCSAqKQorCQlmbHVz aF9waXBlIHQ7CisJCWlmIFF1ZXVlLmxlbmd0aCB0LnEgPCB0LmNhcGFjaXR5 IHRoZW4gYmVnaW4KKwkJCSgqIGVucXVldWUsIGluc3RlYWQgb2Ygc2VuZGlu ZyBkaXJlY3RseS4KKwkJCSAgIHRoaXMgZW5zdXJlcyB0aGF0IFtvdXRdIHNl ZXMgdGhlIGl0ZW1zIGluIHRoZSBzYW1lIG9yZGVyIGFzIHdlIHJlY2VpdmUg dGhlbQorCQkJICopCisJCQlRdWV1ZS5wdXNoIGl0ZW0gdC5xOworCQkJU29t ZSAoZmx1c2hfcGlwZSB0KQorCQllbmQgZWxzZSBOb25lCisKKwlsZXQgaXNf ZW1wdHkgdCA9IFF1ZXVlLmlzX2VtcHR5IHQucQorCWxldCBsZW5ndGggdCA9 IFF1ZXVlLmxlbmd0aCB0LnEKK2VuZAorCiB0eXBlIHdhdGNoID0gewogCWNv bjogdDsKIAl0b2tlbjogc3RyaW5nOwogCXBhdGg6IHN0cmluZzsKIAliYXNl OiBzdHJpbmc7CiAJaXNfcmVsYXRpdmU6IGJvb2w7CisJcGVuZGluZ193YXRj aGV2ZW50czogWGVuYnVzLlhiLlBhY2tldC50IEJvdW5kZWRQaXBlLnQ7CiB9 CiAKIGFuZCB0ID0gewpAQCAtMzgsOCArMTEwLDM2IEBAIGFuZCB0ID0gewog CWFub25pZDogaW50OwogCW11dGFibGUgc3RhdF9uYl9vcHM6IGludDsKIAlt dXRhYmxlIHBlcm06IFBlcm1zLkNvbm5lY3Rpb24udDsKKwlwZW5kaW5nX3Nv dXJjZV93YXRjaGV2ZW50czogKHdhdGNoICogWGVuYnVzLlhiLlBhY2tldC50 KSBCb3VuZGVkUGlwZS50CiB9CiAKK21vZHVsZSBXYXRjaCA9IHN0cnVjdAor CW1vZHVsZSBUID0gc3RydWN0CisJCXR5cGUgdCA9IHdhdGNoCisKKwkJbGV0 IGNvbXBhcmUgdzEgdzIgPQorCQkJKCogY2Fubm90IGNvbXBhcmUgd2F0Y2hl cyBmcm9tIGRpZmZlcmVudCBjb25uZWN0aW9ucyAqKQorCQkJYXNzZXJ0ICh3 MS5jb24gPT0gdzIuY29uKTsKKwkJCW1hdGNoIFN0cmluZy5jb21wYXJlIHcx LnRva2VuIHcyLnRva2VuIHdpdGgKKwkJCXwgMCAtPiBTdHJpbmcuY29tcGFy ZSB3MS5wYXRoIHcyLnBhdGgKKwkJCXwgbiAtPiBuCisJZW5kCisJbW9kdWxl IFNldCA9IFNldC5NYWtlKFQpCisKKwlsZXQgZmx1c2hfZXZlbnRzIHQgPQor CQlCb3VuZGVkUGlwZS5mbHVzaF9waXBlIHQucGVuZGluZ193YXRjaGV2ZW50 czsKKwkJbm90IChCb3VuZGVkUGlwZS5pc19lbXB0eSB0LnBlbmRpbmdfd2F0 Y2hldmVudHMpCisKKwlsZXQgcGVuZGluZ193YXRjaGV2ZW50cyB0ID0KKwkJ Qm91bmRlZFBpcGUubGVuZ3RoIHQucGVuZGluZ193YXRjaGV2ZW50cworZW5k CisKK2xldCBzb3VyY2VfZmx1c2hfd2F0Y2hldmVudHMgdCA9CisJQm91bmRl ZFBpcGUuZmx1c2hfcGlwZSB0LnBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRz CisKK2xldCBzb3VyY2VfcGVuZGluZ193YXRjaGV2ZW50cyB0ID0KKwlCb3Vu ZGVkUGlwZS5sZW5ndGggdC5wZW5kaW5nX3NvdXJjZV93YXRjaGV2ZW50cwor CiBsZXQgbWFya19hc19iYWQgY29uID0KIAltYXRjaCBjb24uZG9tIHdpdGgK IAl8Tm9uZSAtPiAoKQpAQCAtNjcsNyArMTY3LDggQEAgbGV0IHdhdGNoX2Ny ZWF0ZSB+Y29uIH5wYXRoIH50b2tlbiA9IHsKIAl0b2tlbiA9IHRva2VuOwog CXBhdGggPSBwYXRoOwogCWJhc2UgPSBnZXRfcGF0aCBjb247Ci0JaXNfcmVs YXRpdmUgPSBwYXRoLlswXSA8PiAnLycgJiYgcGF0aC5bMF0gPD4gJ0AnCisJ aXNfcmVsYXRpdmUgPSBwYXRoLlswXSA8PiAnLycgJiYgcGF0aC5bMF0gPD4g J0AnOworCXBlbmRpbmdfd2F0Y2hldmVudHMgPSBCb3VuZGVkUGlwZS5jcmVh dGUgfmNhcGFjaXR5OiFEZWZpbmUubWF4d2F0Y2hldmVudHMgfmRlc3RpbmF0 aW9uOihYZW5idXMuWGIucXVldWUgY29uLnhiKQogfQogCiBsZXQgZ2V0X2Nv biB3ID0gdy5jb24KQEAgLTkzLDYgKzE5NCw5IEBAIGxldCBtYWtlX3Blcm0g ZG9tID0KIAlQZXJtcy5Db25uZWN0aW9uLmNyZWF0ZSB+cGVybXM6W1Blcm1z LlJFQUQ7IFBlcm1zLldSSVRFXSBkb21pZAogCiBsZXQgY3JlYXRlIHhiY29u IGRvbSA9CisJbGV0IGRlc3RpbmF0aW9uICh3YXRjaCwgcGt0KSA9CisJCUJv dW5kZWRQaXBlLnB1c2ggd2F0Y2gucGVuZGluZ193YXRjaGV2ZW50cyBwa3QK KwlpbgogCWxldCBpZCA9CiAJCW1hdGNoIGRvbSB3aXRoCiAJCXwgTm9uZSAt PiBsZXQgb2xkID0gIWFub25faWRfbmV4dCBpbiBpbmNyIGFub25faWRfbmV4 dDsgb2xkCkBAIC0xMDksNiArMjEzLDE2IEBAIGxldCBjcmVhdGUgeGJjb24g ZG9tID0KIAlhbm9uaWQgPSBpZDsKIAlzdGF0X25iX29wcyA9IDA7CiAJcGVy bSA9IG1ha2VfcGVybSBkb207CisKKwkoKiB0aGUgYWN0dWFsIGNhcGFjaXR5 IHdpbGwgYmUgbG93ZXIsIHRoaXMgaXMgdXNlZCBhcyBhbiBvdmVyZmxvdwor CSAgIGJ1ZmZlcjogYW55dGhpbmcgdGhhdCBkb2Vzbid0IGZpdCBlbHNld2hl cmUgZ2V0cyBwdXQgaGVyZSwgb25seQorCSAgIGxpbWl0ZWQgYnkgdGhlIGFt b3VudCBvZiB3YXRjaGVzIHRoYXQgeW91IGNhbiBnZW5lcmF0ZSB3aXRoIGEK KwkgICBzaW5nbGUgeGVuc3RvcmUgY29tbWFuZCAod2hpY2ggaXMgZmluaXRl LCBhbHRob3VnaCBwb3NzaWJseSB2ZXJ5CisJICAgbGFyZ2UgaW4gdGhlb3J5 IGZvciBEb20wKS4gIE9uY2UgdGhlIHBpcGUgaGVyZSBoYXMgYW55IGNvbnRl bnRzIHRoZQorCSAgIGRvbWFpbiBpcyBibG9ja2VkIGZyb20gc2VuZGluZyBt b3JlIGNvbW1hbmRzIHVudGlsIGl0IGlzIGVtcHR5CisJICAgYWdhaW4gdGhv dWdoLgorCSAqKQorCXBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRzID0gQm91 bmRlZFBpcGUuY3JlYXRlIH5jYXBhY2l0eTpTeXMubWF4X2FycmF5X2xlbmd0 aCB+ZGVzdGluYXRpb24KIAl9CiAJaW4KIAlMb2dnaW5nLm5ld19jb25uZWN0 aW9uIH50aWQ6VHJhbnNhY3Rpb24ubm9uZSB+Y29uOihnZXRfZG9tc3RyIGNv bik7CkBAIC0xMjcsMTEgKzI0MSwxNyBAQCBsZXQgc2V0X3RhcmdldCBjb24g dGFyZ2V0X2RvbWlkID0KIAogbGV0IGlzX2JhY2tlbmRfbW1hcCBjb24gPSBY ZW5idXMuWGIuaXNfbW1hcCBjb24ueGIKIAotbGV0IHNlbmRfcmVwbHkgY29u IHRpZCByaWQgdHkgZGF0YSA9CitsZXQgcGFja2V0X29mIGNvbiB0aWQgcmlk IHR5IGRhdGEgPQogCWlmIChTdHJpbmcubGVuZ3RoIGRhdGEpID4geGVuc3Rv cmVfcGF5bG9hZF9tYXggJiYgKGlzX2JhY2tlbmRfbW1hcCBjb24pIHRoZW4K LQkJWGVuYnVzLlhiLnF1ZXVlIGNvbi54YiAoWGVuYnVzLlhiLlBhY2tldC5j cmVhdGUgdGlkIHJpZCBYZW5idXMuWGIuT3AuRXJyb3IgIkUyQklHXDAwMCIp CisJCVhlbmJ1cy5YYi5QYWNrZXQuY3JlYXRlIHRpZCByaWQgWGVuYnVzLlhi Lk9wLkVycm9yICJFMkJJR1wwMDAiCiAJZWxzZQotCQlYZW5idXMuWGIucXVl dWUgY29uLnhiIChYZW5idXMuWGIuUGFja2V0LmNyZWF0ZSB0aWQgcmlkIHR5 IGRhdGEpCisJCVhlbmJ1cy5YYi5QYWNrZXQuY3JlYXRlIHRpZCByaWQgdHkg ZGF0YQorCitsZXQgc2VuZF9yZXBseSBjb24gdGlkIHJpZCB0eSBkYXRhID0K KwlsZXQgcmVzdWx0ID0gWGVuYnVzLlhiLnF1ZXVlIGNvbi54YiAocGFja2V0 X29mIGNvbiB0aWQgcmlkIHR5IGRhdGEpIGluCisJKCogc2hvdWxkIG5ldmVy IGhhcHBlbjogd2Ugb25seSBwcm9jZXNzIGFuIGlucHV0IHBhY2tldCB3aGVu IHRoZXJlIGlzIHJvb20gZm9yIGFuIG91dHB1dCBwYWNrZXQgKikKKwkoKiBh bmQgdGhlIGxpbWl0IGZvciByZXBsaWVzIGlzIGRpZmZlcmVudCBmcm9tIHRo ZSBsaW1pdCBmb3Igd2F0Y2ggZXZlbnRzICopCisJYXNzZXJ0IChyZXN1bHQg PD4gTm9uZSkKIAogbGV0IHNlbmRfZXJyb3IgY29uIHRpZCByaWQgZXJyID0g c2VuZF9yZXBseSBjb24gdGlkIHJpZCBYZW5idXMuWGIuT3AuRXJyb3IgKGVy ciBeICJcMDAwIikKIGxldCBzZW5kX2FjayBjb24gdGlkIHJpZCB0eSA9IHNl bmRfcmVwbHkgY29uIHRpZCByaWQgdHkgIk9LXDAwMCIKQEAgLTE4MSwxMSAr MzAxLDExIEBAIGxldCBkZWxfd2F0Y2ggY29uIHBhdGggdG9rZW4gPQogCWFw YXRoLCB3CiAKIGxldCBkZWxfd2F0Y2hlcyBjb24gPQotICBIYXNodGJsLmNs ZWFyIGNvbi53YXRjaGVzOworICBIYXNodGJsLnJlc2V0IGNvbi53YXRjaGVz OwogICBjb24ubmJfd2F0Y2hlcyA8LSAwCiAKIGxldCBkZWxfdHJhbnNhY3Rp b25zIGNvbiA9Ci0gIEhhc2h0YmwuY2xlYXIgY29uLnRyYW5zYWN0aW9ucwor ICBIYXNodGJsLnJlc2V0IGNvbi50cmFuc2FjdGlvbnMKIAogbGV0IGxpc3Rf d2F0Y2hlcyBjb24gPQogCWxldCBsbCA9IEhhc2h0YmwuZm9sZApAQCAtMjA4 LDIxICszMjgsMjkgQEAgbGV0IGxvb2t1cF93YXRjaF9wZXJtIHBhdGggPSBm dW5jdGlvbgogbGV0IGxvb2t1cF93YXRjaF9wZXJtcyBvbGRyb290IHJvb3Qg cGF0aCA9CiAJbG9va3VwX3dhdGNoX3Blcm0gcGF0aCBvbGRyb290IEAgbG9v a3VwX3dhdGNoX3Blcm0gcGF0aCAoU29tZSByb290KQogCi1sZXQgZmlyZV9z aW5nbGVfd2F0Y2hfdW5jaGVja2VkIHdhdGNoID0KK2xldCBmaXJlX3Npbmds ZV93YXRjaF91bmNoZWNrZWQgc291cmNlIHdhdGNoID0KIAlsZXQgZGF0YSA9 IFV0aWxzLmpvaW5fYnlfbnVsbCBbd2F0Y2gucGF0aDsgd2F0Y2gudG9rZW47 ICIiXSBpbgotCXNlbmRfcmVwbHkgd2F0Y2guY29uIFRyYW5zYWN0aW9uLm5v bmUgMCBYZW5idXMuWGIuT3AuV2F0Y2hldmVudCBkYXRhCisJbGV0IHBrdCA9 IHBhY2tldF9vZiB3YXRjaC5jb24gVHJhbnNhY3Rpb24ubm9uZSAwIFhlbmJ1 cy5YYi5PcC5XYXRjaGV2ZW50IGRhdGEgaW4KKworCW1hdGNoIEJvdW5kZWRQ aXBlLnB1c2ggc291cmNlLnBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRzICh3 YXRjaCwgcGt0KSB3aXRoCisJfCBTb21lICgpIC0+ICgpICgqIHBhY2tldCBx dWV1ZWQgKikKKwl8IE5vbmUgLT4KKwkJCSgqIGEgd2VsbCBiZWhhdmVkIERv bTAgc2hvdWxkbid0IGJlIGFibGUgdG8gdHJpZ2dlciB0aGlzLAorCQkJICAg aWYgaXQgaGFwcGVucyBpdCBpcyBsaWtlbHkgYSBEb20wIGJ1ZyBjYXVzaW5n IHJ1bmF3YXkgbWVtb3J5IHVzYWdlCisJCQkgKikKKwkJCWZhaWx3aXRoICJ3 YXRjaCBldmVudCBvdmVyZmxvdywgY2Fubm90IGhhcHBlbiIKIAotbGV0IGZp cmVfc2luZ2xlX3dhdGNoIChvbGRyb290LCByb290KSB3YXRjaCA9CitsZXQg ZmlyZV9zaW5nbGVfd2F0Y2ggc291cmNlIChvbGRyb290LCByb290KSB3YXRj aCA9CiAJbGV0IGFic3BhdGggPSBnZXRfd2F0Y2hfcGF0aCB3YXRjaC5jb24g d2F0Y2gucGF0aCB8PiBTdG9yZS5QYXRoLm9mX3N0cmluZyBpbgogCWxldCBw ZXJtcyA9IGxvb2t1cF93YXRjaF9wZXJtcyBvbGRyb290IHJvb3QgYWJzcGF0 aCBpbgogCWlmIFBlcm1zLmNhbl9maXJlX3dhdGNoIHdhdGNoLmNvbi5wZXJt IHBlcm1zIHRoZW4KLQkJZmlyZV9zaW5nbGVfd2F0Y2hfdW5jaGVja2VkIHdh dGNoCisJCWZpcmVfc2luZ2xlX3dhdGNoX3VuY2hlY2tlZCBzb3VyY2Ugd2F0 Y2gKIAllbHNlCiAJCWxldCBwZXJtcyA9IHBlcm1zIHw+IExpc3QubWFwIChQ ZXJtcy5Ob2RlLnRvX3N0cmluZyB+c2VwOiIgIikgfD4gU3RyaW5nLmNvbmNh dCAiLCAiIGluCiAJCWxldCBjb24gPSBnZXRfZG9tc3RyIHdhdGNoLmNvbiBp bgogCQlMb2dnaW5nLndhdGNoX25vdF9maXJlZCB+Y29uIHBlcm1zIChTdG9y ZS5QYXRoLnRvX3N0cmluZyBhYnNwYXRoKQogCi1sZXQgZmlyZV93YXRjaCBy b290cyB3YXRjaCBwYXRoID0KK2xldCBmaXJlX3dhdGNoIHNvdXJjZSByb290 cyB3YXRjaCBwYXRoID0KIAlsZXQgbmV3X3BhdGggPQogCQlpZiB3YXRjaC5p c19yZWxhdGl2ZSAmJiBwYXRoLlswXSA9ICcvJwogCQl0aGVuIGJlZ2luCkBA IC0yMzIsNyArMzYwLDcgQEAgbGV0IGZpcmVfd2F0Y2ggcm9vdHMgd2F0Y2gg cGF0aCA9CiAJCWVuZCBlbHNlCiAJCQlwYXRoCiAJaW4KLQlmaXJlX3Npbmds ZV93YXRjaCByb290cyB7IHdhdGNoIHdpdGggcGF0aCA9IG5ld19wYXRoIH0K KwlmaXJlX3NpbmdsZV93YXRjaCBzb3VyY2Ugcm9vdHMgeyB3YXRjaCB3aXRo IHBhdGggPSBuZXdfcGF0aCB9CiAKICgqIFNlYXJjaCBmb3IgYSB2YWxpZCB1 bnVzZWQgdHJhbnNhY3Rpb24gaWQuICopCiBsZXQgcmVjIHZhbGlkX3RyYW5z YWN0aW9uX2lkIGNvbiBwcm9wb3NlZF9pZCA9CkBAIC0yNzksNiArNDA3LDcg QEAgbGV0IGdldF90cmFuc2FjdGlvbiBjb24gdGlkID0KIGxldCBkb19pbnB1 dCBjb24gPSBYZW5idXMuWGIuaW5wdXQgY29uLnhiCiBsZXQgaGFzX21vcmVf aW5wdXQgY29uID0gWGVuYnVzLlhiLmhhc19tb3JlX2lucHV0IGNvbi54Ygog CitsZXQgY2FuX2lucHV0IGNvbiA9IFhlbmJ1cy5YYi5jYW5faW5wdXQgY29u LnhiICYmIEJvdW5kZWRQaXBlLmlzX2VtcHR5IGNvbi5wZW5kaW5nX3NvdXJj ZV93YXRjaGV2ZW50cwogbGV0IGhhc19vdXRwdXQgY29uID0gWGVuYnVzLlhi Lmhhc19vdXRwdXQgY29uLnhiCiBsZXQgaGFzX29sZF9vdXRwdXQgY29uID0g WGVuYnVzLlhiLmhhc19vbGRfb3V0cHV0IGNvbi54YgogbGV0IGhhc19uZXdf b3V0cHV0IGNvbiA9IFhlbmJ1cy5YYi5oYXNfbmV3X291dHB1dCBjb24ueGIK QEAgLTI4Niw3ICs0MTUsNyBAQCBsZXQgcGVla19vdXRwdXQgY29uID0gWGVu YnVzLlhiLnBlZWtfb3V0cHV0IGNvbi54YgogbGV0IGRvX291dHB1dCBjb24g PSBYZW5idXMuWGIub3V0cHV0IGNvbi54YgogCiBsZXQgaGFzX21vcmVfd29y ayBjb24gPQotCWhhc19tb3JlX2lucHV0IGNvbiB8fCBub3QgKGhhc19vbGRf b3V0cHV0IGNvbikgJiYgaGFzX25ld19vdXRwdXQgY29uCisJKGhhc19tb3Jl X2lucHV0IGNvbiAmJiBjYW5faW5wdXQgY29uKSB8fCBub3QgKGhhc19vbGRf b3V0cHV0IGNvbikgJiYgaGFzX25ld19vdXRwdXQgY29uCiAKIGxldCBpbmNy X29wcyBjb24gPSBjb24uc3RhdF9uYl9vcHMgPC0gY29uLnN0YXRfbmJfb3Bz ICsgMQogCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvY29u bmVjdGlvbnMubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvY29ubmVjdGlv bnMubWwKaW5kZXggN2VmZGYzZTVlMDVlLi4zOTE5MGMxOWVjNTggMTAwNjQ0 Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9ucy5tbAor KysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvY29ubmVjdGlvbnMubWwKQEAg LTIyLDIyICsyMiwzMCBAQCB0eXBlIHQgPSB7CiAJZG9tYWluczogKGludCwg Q29ubmVjdGlvbi50KSBIYXNodGJsLnQ7CiAJcG9ydHM6IChYZW5ldmVudGNo bi50LCBDb25uZWN0aW9uLnQpIEhhc2h0YmwudDsKIAltdXRhYmxlIHdhdGNo ZXM6IChzdHJpbmcsIENvbm5lY3Rpb24ud2F0Y2ggbGlzdCkgVHJpZS50Owor CW11dGFibGUgaGFzX3BlbmRpbmdfd2F0Y2hldmVudHM6IENvbm5lY3Rpb24u V2F0Y2guU2V0LnQKIH0KIAogbGV0IGNyZWF0ZSAoKSA9IHsKIAlhbm9ueW1v dXMgPSBIYXNodGJsLmNyZWF0ZSAzNzsKIAlkb21haW5zID0gSGFzaHRibC5j cmVhdGUgMzc7CiAJcG9ydHMgPSBIYXNodGJsLmNyZWF0ZSAzNzsKLQl3YXRj aGVzID0gVHJpZS5jcmVhdGUgKCkKKwl3YXRjaGVzID0gVHJpZS5jcmVhdGUg KCk7CisJaGFzX3BlbmRpbmdfd2F0Y2hldmVudHMgPSBDb25uZWN0aW9uLldh dGNoLlNldC5lbXB0eTsKIH0KIAorbGV0IGdldF9jYXBhY2l0eSAoKSA9CisJ KCogbm90IG11bHRpcGxpZWQgYnkgbWF4d2F0Y2ggb24gcHVycG9zZTogMm5k IHF1ZXVlIGluIHdhdGNoIGl0c2VsZiEgKikKKwl7IFhlbmJ1cy5YYi5tYXhv dXRzdGFuZGluZyA9ICFEZWZpbmUubWF4b3V0c3RhbmRpbmc7IG1heHdhdGNo ZXZlbnRzID0gIURlZmluZS5tYXh3YXRjaGV2ZW50cyB9CisKIGxldCBhZGRf YW5vbnltb3VzIGNvbnMgZmQgX2Nhbl93cml0ZSA9Ci0JbGV0IHhiY29uID0g WGVuYnVzLlhiLm9wZW5fZmQgZmQgaW4KKwlsZXQgY2FwYWNpdHkgPSBnZXRf Y2FwYWNpdHkgKCkgaW4KKwlsZXQgeGJjb24gPSBYZW5idXMuWGIub3Blbl9m ZCBmZCB+Y2FwYWNpdHkgaW4KIAlsZXQgY29uID0gQ29ubmVjdGlvbi5jcmVh dGUgeGJjb24gTm9uZSBpbgogCUhhc2h0YmwuYWRkIGNvbnMuYW5vbnltb3Vz IChYZW5idXMuWGIuZ2V0X2ZkIHhiY29uKSBjb24KIAogbGV0IGFkZF9kb21h aW4gY29ucyBkb20gPQotCWxldCB4YmNvbiA9IFhlbmJ1cy5YYi5vcGVuX21t YXAgKERvbWFpbi5nZXRfaW50ZXJmYWNlIGRvbSkgKGZ1biAoKSAtPiBEb21h aW4ubm90aWZ5IGRvbSkgaW4KKwlsZXQgY2FwYWNpdHkgPSBnZXRfY2FwYWNp dHkgKCkgaW4KKwlsZXQgeGJjb24gPSBYZW5idXMuWGIub3Blbl9tbWFwIH5j YXBhY2l0eSAoRG9tYWluLmdldF9pbnRlcmZhY2UgZG9tKSAoZnVuICgpIC0+ IERvbWFpbi5ub3RpZnkgZG9tKSBpbgogCWxldCBjb24gPSBDb25uZWN0aW9u LmNyZWF0ZSB4YmNvbiAoU29tZSBkb20pIGluCiAJSGFzaHRibC5hZGQgY29u cy5kb21haW5zIChEb21haW4uZ2V0X2lkIGRvbSkgY29uOwogCW1hdGNoIERv bWFpbi5nZXRfcG9ydCBkb20gd2l0aApAQCAtNDgsNyArNTYsOSBAQCBsZXQg c2VsZWN0ID8ob25seV9pZiA9IChmdW4gXyAtPiB0cnVlKSkgY29ucyA9CiAJ SGFzaHRibC5mb2xkIChmdW4gXyBjb24gKGlucywgb3V0cykgLT4KIAkJaWYg KG9ubHlfaWYgY29uKSB0aGVuICgKIAkJCWxldCBmZCA9IENvbm5lY3Rpb24u Z2V0X2ZkIGNvbiBpbgotCQkJKGZkIDo6IGlucywgIGlmIENvbm5lY3Rpb24u aGFzX291dHB1dCBjb24gdGhlbiBmZCA6OiBvdXRzIGVsc2Ugb3V0cykKKwkJ CWxldCBpbl9mZHMgPSBpZiBDb25uZWN0aW9uLmNhbl9pbnB1dCBjb24gdGhl biBmZCA6OiBpbnMgZWxzZSBpbnMgaW4KKwkJCWxldCBvdXRfZmRzID0gaWYg Q29ubmVjdGlvbi5oYXNfb3V0cHV0IGNvbiB0aGVuIGZkIDo6IG91dHMgZWxz ZSBvdXRzIGluCisJCQlpbl9mZHMsIG91dF9mZHMKIAkJKSBlbHNlIChpbnMs IG91dHMpCiAJKQogCWNvbnMuYW5vbnltb3VzIChbXSwgW10pCkBAIC02Nywx MCArNzcsMTcgQEAgbGV0IGRlbF93YXRjaGVzX29mX2NvbiBjb24gd2F0Y2hl cyA9CiAJfCBbXSAtPiBOb25lCiAJfCB3cyAtPiBTb21lIHdzCiAKK2xldCBk ZWxfd2F0Y2hlcyBjb25zIGNvbiA9CisJQ29ubmVjdGlvbi5kZWxfd2F0Y2hl cyBjb247CisJY29ucy53YXRjaGVzIDwtIFRyaWUubWFwIChkZWxfd2F0Y2hl c19vZl9jb24gY29uKSBjb25zLndhdGNoZXM7CisJY29ucy5oYXNfcGVuZGlu Z193YXRjaGV2ZW50cyA8LQorCQljb25zLmhhc19wZW5kaW5nX3dhdGNoZXZl bnRzIHw+IENvbm5lY3Rpb24uV2F0Y2guU2V0LmZpbHRlciBAQCBmdW4gdyAt PgorCQlDb25uZWN0aW9uLmdldF9jb24gdyAhPSBjb24KKwogbGV0IGRlbF9h bm9ueW1vdXMgY29ucyBjb24gPQogCXRyeQogCQlIYXNodGJsLnJlbW92ZSBj b25zLmFub255bW91cyAoQ29ubmVjdGlvbi5nZXRfZmQgY29uKTsKLQkJY29u cy53YXRjaGVzIDwtIFRyaWUubWFwIChkZWxfd2F0Y2hlc19vZl9jb24gY29u KSBjb25zLndhdGNoZXM7CisJCWRlbF93YXRjaGVzIGNvbnMgY29uOwogCQlD b25uZWN0aW9uLmNsb3NlIGNvbgogCXdpdGggZXhuIC0+CiAJCWRlYnVnICJk ZWwgYW5vbnltb3VzICVzIiAoUHJpbnRleGMudG9fc3RyaW5nIGV4bikKQEAg LTg1LDcgKzEwMiw3IEBAIGxldCBkZWxfZG9tYWluIGNvbnMgaWQgPQogCQkg ICAgfCBTb21lIHAgLT4gSGFzaHRibC5yZW1vdmUgY29ucy5wb3J0cyBwCiAJ CSAgICB8IE5vbmUgLT4gKCkpCiAJCSB8IE5vbmUgLT4gKCkpOwotCQljb25z LndhdGNoZXMgPC0gVHJpZS5tYXAgKGRlbF93YXRjaGVzX29mX2NvbiBjb24p IGNvbnMud2F0Y2hlczsKKwkJZGVsX3dhdGNoZXMgY29ucyBjb247CiAJCUNv bm5lY3Rpb24uY2xvc2UgY29uCiAJd2l0aCBleG4gLT4KIAkJZGVidWcgImRl bCBkb21haW4gJXU6ICVzIiBpZCAoUHJpbnRleGMudG9fc3RyaW5nIGV4bikK QEAgLTEzNiwzMSArMTUzLDMzIEBAIGxldCBkZWxfd2F0Y2ggY29ucyBjb24g cGF0aCB0b2tlbiA9CiAJCWNvbnMud2F0Y2hlcyA8LSBUcmllLnNldCBjb25z LndhdGNoZXMga2V5IHdhdGNoZXM7CiAgCXdhdGNoCiAKLWxldCBkZWxfd2F0 Y2hlcyBjb25zIGNvbiA9Ci0JQ29ubmVjdGlvbi5kZWxfd2F0Y2hlcyBjb247 Ci0JY29ucy53YXRjaGVzIDwtIFRyaWUubWFwIChkZWxfd2F0Y2hlc19vZl9j b24gY29uKSBjb25zLndhdGNoZXMKLQogKCogcGF0aCBpcyBhYnNvbHV0ZSAq KQotbGV0IGZpcmVfd2F0Y2hlcyA/b2xkcm9vdCByb290IGNvbnMgcGF0aCBy ZWN1cnNlID0KK2xldCBmaXJlX3dhdGNoZXMgP29sZHJvb3Qgc291cmNlIHJv b3QgY29ucyBwYXRoIHJlY3Vyc2UgPQogCWxldCBrZXkgPSBrZXlfb2ZfcGF0 aCBwYXRoIGluCiAJbGV0IHBhdGggPSBTdG9yZS5QYXRoLnRvX3N0cmluZyBw YXRoIGluCiAJbGV0IHJvb3RzID0gb2xkcm9vdCwgcm9vdCBpbgogCWxldCBm aXJlX3dhdGNoIF8gPSBmdW5jdGlvbgogCQl8IE5vbmUgICAgICAgICAtPiAo KQotCQl8IFNvbWUgd2F0Y2hlcyAtPiBMaXN0Lml0ZXIgKGZ1biB3IC0+IENv bm5lY3Rpb24uZmlyZV93YXRjaCByb290cyB3IHBhdGgpIHdhdGNoZXMKKwkJ fCBTb21lIHdhdGNoZXMgLT4gTGlzdC5pdGVyIChmdW4gdyAtPiBDb25uZWN0 aW9uLmZpcmVfd2F0Y2ggc291cmNlIHJvb3RzIHcgcGF0aCkgd2F0Y2hlcwog CWluCiAJbGV0IGZpcmVfcmVjIF94ID0gZnVuY3Rpb24KIAkJfCBOb25lICAg ICAgICAgLT4gKCkKIAkJfCBTb21lIHdhdGNoZXMgLT4KLQkJCUxpc3QuaXRl ciAoQ29ubmVjdGlvbi5maXJlX3NpbmdsZV93YXRjaCByb290cykgd2F0Y2hl cworCQkJTGlzdC5pdGVyIChDb25uZWN0aW9uLmZpcmVfc2luZ2xlX3dhdGNo IHNvdXJjZSByb290cykgd2F0Y2hlcwogCWluCiAJVHJpZS5pdGVyX3BhdGgg ZmlyZV93YXRjaCBjb25zLndhdGNoZXMga2V5OwogCWlmIHJlY3Vyc2UgdGhl bgogCQlUcmllLml0ZXIgZmlyZV9yZWMgKFRyaWUuc3ViIGNvbnMud2F0Y2hl cyBrZXkpCiAKK2xldCBzZW5kX3dhdGNoZXZlbnRzIGNvbnMgY29uID0KKwlj b25zLmhhc19wZW5kaW5nX3dhdGNoZXZlbnRzIDwtCisJCWNvbnMuaGFzX3Bl bmRpbmdfd2F0Y2hldmVudHMgfD4gQ29ubmVjdGlvbi5XYXRjaC5TZXQuZmls dGVyIENvbm5lY3Rpb24uV2F0Y2guZmx1c2hfZXZlbnRzOworCUNvbm5lY3Rp b24uc291cmNlX2ZsdXNoX3dhdGNoZXZlbnRzIGNvbgorCiBsZXQgZmlyZV9z cGVjX3dhdGNoZXMgcm9vdCBjb25zIHNwZWNwYXRoID0KKwlsZXQgc291cmNl ID0gZmluZF9kb21haW4gY29ucyAwIGluCiAJaXRlciBjb25zIChmdW4gY29u IC0+Ci0JCUxpc3QuaXRlciAoQ29ubmVjdGlvbi5maXJlX3NpbmdsZV93YXRj aCAoTm9uZSwgcm9vdCkpIChDb25uZWN0aW9uLmdldF93YXRjaGVzIGNvbiBz cGVjcGF0aCkpCisJCUxpc3QuaXRlciAoQ29ubmVjdGlvbi5maXJlX3Npbmds ZV93YXRjaCBzb3VyY2UgKE5vbmUsIHJvb3QpKSAoQ29ubmVjdGlvbi5nZXRf d2F0Y2hlcyBjb24gc3BlY3BhdGgpKQogCiBsZXQgc2V0X3RhcmdldCBjb25z IGRvbWFpbiB0YXJnZXRfZG9tYWluID0KIAlsZXQgY29uID0gZmluZF9kb21h aW4gY29ucyBkb21haW4gaW4KQEAgLTE5NiwzICsyMTUsMTMgQEAgbGV0IGRl YnVnIGNvbnMgPQogCWxldCBhbm9ueW1vdXMgPSBIYXNodGJsLmZvbGQgKGZ1 biBfIGNvbiBhY2N1IC0+IENvbm5lY3Rpb24uZGVidWcgY29uIDo6IGFjY3Up IGNvbnMuYW5vbnltb3VzIFtdIGluCiAJbGV0IGRvbWFpbnMgPSBIYXNodGJs LmZvbGQgKGZ1biBfIGNvbiBhY2N1IC0+IENvbm5lY3Rpb24uZGVidWcgY29u IDo6IGFjY3UpIGNvbnMuZG9tYWlucyBbXSBpbgogCVN0cmluZy5jb25jYXQg IiIgKGRvbWFpbnMgQCBhbm9ueW1vdXMpCisKK2xldCBkZWJ1Z193YXRjaGV2 ZW50cyBjb25zIGNvbiA9CisJKCogPT0gKHBoeXNpY2FsIGVxdWFsaXR5KQor CSAgIGhhcyB0byBiZSB1c2VkIGhlcmUgYmVjYXVzZSB3LmNvbi54Yi5iYWNr ZW5kIG1pZ2h0IGNvbnRhaW4gYSBbdW5pdC0+dW5pdF0gdmFsdWUgY2F1c2lu ZyByZWd1bGFyCisJICAgY29tcGFyaXNvbiB0byBmYWlsIGR1ZSB0byBoYXZp bmcgYSAnZnVuY3Rpb25hbCB2YWx1ZScgd2hpY2ggY2Fubm90IGJlIGNvbXBh cmVkLgorCSAqKQorCWxldCBzID0gY29ucy5oYXNfcGVuZGluZ193YXRjaGV2 ZW50cyB8PiBDb25uZWN0aW9uLldhdGNoLlNldC5maWx0ZXIgKGZ1biB3IC0+ IHcuY29uID09IGNvbikgaW4KKwlsZXQgcGVuZGluZyA9IHMgfD4gQ29ubmVj dGlvbi5XYXRjaC5TZXQuZWxlbWVudHMKKwkJfD4gTGlzdC5tYXAgKGZ1biB3 IC0+IENvbm5lY3Rpb24uV2F0Y2gucGVuZGluZ193YXRjaGV2ZW50cyB3KSB8 PiBMaXN0LmZvbGRfbGVmdCAoKykgMCBpbgorCVByaW50Zi5zcHJpbnRmICJX YXRjaGVzIHdpdGggcGVuZGluZyBldmVudHM6ICVkLCBwZW5kaW5nIGV2ZW50 cyB0b3RhbDogJWQiIChDb25uZWN0aW9uLldhdGNoLlNldC5jYXJkaW5hbCBz KSBwZW5kaW5nCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQv ZGVmaW5lLm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RlZmluZS5tbApp bmRleCAxYTVkMmYzNGE2NzguLjllNTIzNjcwOTQ3NCAxMDA2NDQKLS0tIGEv dG9vbHMvb2NhbWwveGVuc3RvcmVkL2RlZmluZS5tbAorKysgYi90b29scy9v Y2FtbC94ZW5zdG9yZWQvZGVmaW5lLm1sCkBAIC0yNSw2ICsyNSwxMyBAQCBs ZXQgZGVmYXVsdF9jb25maWdfZGlyID0gUGF0aHMueGVuX2NvbmZpZ19kaXIK IGxldCBtYXh3YXRjaCA9IHJlZiAoMTAwKQogbGV0IG1heHRyYW5zYWN0aW9u ID0gcmVmICgxMCkKIGxldCBtYXhyZXF1ZXN0cyA9IHJlZiAoMTAyNCkgICAo KiBtYXhpbXVtIHJlcXVlc3RzIHBlciB0cmFuc2FjdGlvbiAqKQorbGV0IG1h eG91dHN0YW5kaW5nID0gcmVmICgxMDI0KSAoKiBtYXhpbXVtIG91dHN0YW5k aW5nIHJlcXVlc3RzLCBpLmUuIGluLWZsaWdodCByZXF1ZXN0cyAvIGRvbWFp biAqKQorbGV0IG1heHdhdGNoZXZlbnRzID0gcmVmICgxMDI0KQorKCoKKwlt YXhpbXVtIG91dHN0YW5kaW5nIHdhdGNoIGV2ZW50cyBwZXIgd2F0Y2gsCisJ cmVjb21tZW5kZWQgPj0gbWF4b3V0c3RhbmRpbmcgdG8gYXZvaWQgYmxvY2tp bmcgYmFja2VuZCB0cmFuc2FjdGlvbnMgZHVlIHRvCisJbWFsaWNpb3VzIGZy b250ZW5kcworICopCiAKIGxldCBnY19tYXhfb3ZlcmhlYWQgPSByZWYgMTIw ICgqIDEyMCUgc2VlIGNvbW1lbnQgaW4geGVuc3RvcmVkLm1sICopCiBsZXQg Y29uZmxpY3RfYnVyc3RfbGltaXQgPSByZWYgNS4wCmRpZmYgLS1naXQgYS90 b29scy9vY2FtbC94ZW5zdG9yZWQvb3hlbnN0b3JlZC5jb25mLmluIGIvdG9v bHMvb2NhbWwveGVuc3RvcmVkL294ZW5zdG9yZWQuY29uZi5pbgppbmRleCA0 YWU0OGU0MmQ0N2QuLjlkMDM0ZTc0NGI0YiAxMDA2NDQKLS0tIGEvdG9vbHMv b2NhbWwveGVuc3RvcmVkL294ZW5zdG9yZWQuY29uZi5pbgorKysgYi90b29s cy9vY2FtbC94ZW5zdG9yZWQvb3hlbnN0b3JlZC5jb25mLmluCkBAIC02Miw2 ICs2Miw4IEBAIHF1b3RhLW1heHdhdGNoID0gMTAwCiBxdW90YS10cmFuc2Fj dGlvbiA9IDEwCiBxdW90YS1tYXhyZXF1ZXN0cyA9IDEwMjQKIHF1b3RhLXBh dGgtbWF4ID0gMTAyNAorcXVvdGEtbWF4b3V0c3RhbmRpbmcgPSAxMDI0Citx dW90YS1tYXh3YXRjaGV2ZW50cyA9IDEwMjQKIAogIyBBY3RpdmF0ZSBmaWxl ZCBiYXNlIGJhY2tlbmQKIHBlcnNpc3RlbnQgPSBmYWxzZQpkaWZmIC0tZ2l0 IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3MubWwgYi90b29scy9v Y2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbAppbmRleCBhNzI4MTBkMDZmNDMu LjA4MmM5M2ZhOWQzZiAxMDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwveGVuc3Rv cmVkL3Byb2Nlc3MubWwKKysrIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3By b2Nlc3MubWwKQEAgLTU2LDcgKzU2LDcgQEAgbGV0IHNwbGl0X29uZV9wYXRo IGRhdGEgY29uID0KIAl8IHBhdGggOjogIiIgOjogW10gLT4gU3RvcmUuUGF0 aC5jcmVhdGUgcGF0aCAoQ29ubmVjdGlvbi5nZXRfcGF0aCBjb24pCiAJfCBf ICAgICAgICAgICAgICAgIC0+IHJhaXNlIEludmFsaWRfQ21kX0FyZ3MKIAot bGV0IHByb2Nlc3Nfd2F0Y2ggdCBjb25zID0KK2xldCBwcm9jZXNzX3dhdGNo IHNvdXJjZSB0IGNvbnMgPQogCWxldCBvbGRyb290ID0gdC5UcmFuc2FjdGlv bi5vbGRyb290IGluCiAJbGV0IG5ld3Jvb3QgPSBTdG9yZS5nZXRfcm9vdCB0 LnN0b3JlIGluCiAJbGV0IG9wcyA9IFRyYW5zYWN0aW9uLmdldF9wYXRocyB0 IHw+IExpc3QucmV2IGluCkBAIC02Niw4ICs2Niw5IEBAIGxldCBwcm9jZXNz X3dhdGNoIHQgY29ucyA9CiAJCXwgWGVuYnVzLlhiLk9wLlJtICAgICAgIC0+ IHRydWUsIE5vbmUsIG9sZHJvb3QKIAkJfCBYZW5idXMuWGIuT3AuU2V0cGVy bXMgLT4gZmFsc2UsIFNvbWUgb2xkcm9vdCwgbmV3cm9vdAogCQl8IF8gICAg ICAgICAgICAgIC0+IHJhaXNlIChGYWlsdXJlICJodWggPyIpIGluCi0JCUNv bm5lY3Rpb25zLmZpcmVfd2F0Y2hlcyA/b2xkcm9vdCByb290IGNvbnMgKHNu ZCBvcCkgcmVjdXJzZSBpbgotCUxpc3QuaXRlciAoZnVuIG9wIC0+IGRvX29w X3dhdGNoIG9wIGNvbnMpIG9wcworCQlDb25uZWN0aW9ucy5maXJlX3dhdGNo ZXMgP29sZHJvb3Qgc291cmNlIHJvb3QgY29ucyAoc25kIG9wKSByZWN1cnNl IGluCisJTGlzdC5pdGVyIChmdW4gb3AgLT4gZG9fb3Bfd2F0Y2ggb3AgY29u cykgb3BzOworCUNvbm5lY3Rpb25zLnNlbmRfd2F0Y2hldmVudHMgY29ucyBz b3VyY2UKIAogbGV0IGNyZWF0ZV9pbXBsaWNpdF9wYXRoIHQgcGVybSBwYXRo ID0KIAlsZXQgZGlybmFtZSA9IFN0b3JlLlBhdGguZ2V0X3BhcmVudCBwYXRo IGluCkBAIC05OSw2ICsxMDAsMjAgQEAgbGV0IGRvX2RlYnVnIGNvbiB0IF9k b21haW5zIGNvbnMgZGF0YSA9CiAJfCAid2F0Y2hlcyIgOjogXyAtPgogCQls ZXQgd2F0Y2hlcyA9IENvbm5lY3Rpb25zLmRlYnVnIGNvbnMgaW4KIAkJU29t ZSAod2F0Y2hlcyBeICJcMDAwIikKKwl8ICJ4ZW5idXMiIDo6IGRvbWlkIDo6 IF8gLT4KKwkJbGV0IGRvbWlkID0gaW50X29mX3N0cmluZyBkb21pZCBpbgor CQlsZXQgY29uID0gQ29ubmVjdGlvbnMuZmluZF9kb21haW4gY29ucyBkb21p ZCBpbgorCQlsZXQgcyA9IFByaW50Zi5zcHJpbnRmICJ4ZW5idXM6ICVzOyBv dmVyZmxvdyBxdWV1ZSBsZW5ndGg6ICVkLCBjYW5faW5wdXQ6ICViLCBoYXNf bW9yZV9pbnB1dDogJWIsIGhhc19vbGRfb3V0cHV0OiAlYiwgaGFzX25ld19v dXRwdXQ6ICViLCBoYXNfbW9yZV93b3JrOiAlYi4gcGVuZGluZzogJXMiCisJ CQkoWGVuYnVzLlhiLmRlYnVnIGNvbi54YikKKwkJCShDb25uZWN0aW9uLnNv dXJjZV9wZW5kaW5nX3dhdGNoZXZlbnRzIGNvbikKKwkJCShDb25uZWN0aW9u LmNhbl9pbnB1dCBjb24pCisJCQkoQ29ubmVjdGlvbi5oYXNfbW9yZV9pbnB1 dCBjb24pCisJCQkoQ29ubmVjdGlvbi5oYXNfb2xkX291dHB1dCBjb24pCisJ CQkoQ29ubmVjdGlvbi5oYXNfbmV3X291dHB1dCBjb24pCisJCQkoQ29ubmVj dGlvbi5oYXNfbW9yZV93b3JrIGNvbikKKwkJCShDb25uZWN0aW9ucy5kZWJ1 Z193YXRjaGV2ZW50cyBjb25zIGNvbikKKwkJaW4KKwkJU29tZSBzCiAJfCAi bWZuIiA6OiBkb21pZCA6OiBfIC0+CiAJCWxldCBkb21pZCA9IGludF9vZl9z dHJpbmcgZG9taWQgaW4KIAkJbGV0IGNvbiA9IENvbm5lY3Rpb25zLmZpbmRf ZG9tYWluIGNvbnMgZG9taWQgaW4KQEAgLTIwNyw3ICsyMjIsNyBAQCBsZXQg cmVwbHlfYWNrIGZjdCBjb24gdCBkb21zIGNvbnMgZGF0YSA9CiAJZmN0IGNv biB0IGRvbXMgY29ucyBkYXRhOwogCVBhY2tldC5BY2sgKGZ1biAoKSAtPgog CQlpZiBUcmFuc2FjdGlvbi5nZXRfaWQgdCA9IFRyYW5zYWN0aW9uLm5vbmUg dGhlbgotCQkJcHJvY2Vzc193YXRjaCB0IGNvbnMKKwkJCXByb2Nlc3Nfd2F0 Y2ggY29uIHQgY29ucwogCSkKIAogbGV0IHJlcGx5X2RhdGEgZmN0IGNvbiB0 IGRvbXMgY29ucyBkYXRhID0KQEAgLTM2Niw3ICszODEsNyBAQCBsZXQgZG9f d2F0Y2ggY29uIHQgX2RvbWFpbnMgY29ucyBkYXRhID0KIAlQYWNrZXQuQWNr IChmdW4gKCkgLT4KIAkJKCogeGVuc3RvcmUudHh0IHNheXMgdGhpcyB3YXRj aCBpcyBmaXJlZCBpbW1lZGlhdGVseSwKIAkJICAgaW1wbHlpbmcgZXZlbiBp ZiBwYXRoIGRvZXNuJ3QgZXhpc3Qgb3IgaXMgdW5yZWFkYWJsZSAqKQotCQlD b25uZWN0aW9uLmZpcmVfc2luZ2xlX3dhdGNoX3VuY2hlY2tlZCB3YXRjaCkK KwkJQ29ubmVjdGlvbi5maXJlX3NpbmdsZV93YXRjaF91bmNoZWNrZWQgY29u IHdhdGNoKQogCiBsZXQgZG9fdW53YXRjaCBjb24gX3QgX2RvbWFpbnMgY29u cyBkYXRhID0KIAlsZXQgKG5vZGUsIHRva2VuKSA9CkBAIC0zOTcsNyArNDEy LDcgQEAgbGV0IGRvX3RyYW5zYWN0aW9uX2VuZCBjb24gdCBkb21haW5zIGNv bnMgZGF0YSA9CiAJaWYgbm90IHN1Y2Nlc3MgdGhlbgogCQlyYWlzZSBUcmFu c2FjdGlvbl9hZ2FpbjsKIAlpZiBjb21taXQgdGhlbiBiZWdpbgotCQlwcm9j ZXNzX3dhdGNoIHQgY29uczsKKwkJcHJvY2Vzc193YXRjaCBjb24gdCBjb25z OwogCQltYXRjaCB0LlRyYW5zYWN0aW9uLnR5IHdpdGgKIAkJfCBUcmFuc2Fj dGlvbi5ObyAtPgogCQkJKCkgKCogbm8gbmVlZCB0byByZWNvcmQgYW55dGhp bmcgKikKQEAgLTU2NCw3ICs1NzksOCBAQCBsZXQgcHJvY2Vzc19wYWNrZXQg fnN0b3JlIH5jb25zIH5kb21zIH5jb24gfnJlcSA9CiBsZXQgZG9faW5wdXQg c3RvcmUgY29ucyBkb21zIGNvbiA9CiAJbGV0IG5ld3BhY2tldCA9CiAJCXRy eQotCQkJQ29ubmVjdGlvbi5kb19pbnB1dCBjb24KKwkJCWlmIENvbm5lY3Rp b24uY2FuX2lucHV0IGNvbiB0aGVuIENvbm5lY3Rpb24uZG9faW5wdXQgY29u CisJCQllbHNlIE5vbmUKIAkJd2l0aCBYZW5idXMuWGIuUmVjb25uZWN0IC0+ CiAJCQlpbmZvICIlcyByZXF1ZXN0cyBhIHJlY29ubmVjdCIgKENvbm5lY3Rp b24uZ2V0X2RvbXN0ciBjb24pOwogCQkJSGlzdG9yeS5yZWNvbm5lY3QgY29u OwpAQCAtNTkyLDYgKzYwOCw3IEBAIGxldCBkb19pbnB1dCBzdG9yZSBjb25z IGRvbXMgY29uID0KIAkJQ29ubmVjdGlvbi5pbmNyX29wcyBjb24KIAogbGV0 IGRvX291dHB1dCBfc3RvcmUgX2NvbnMgX2RvbXMgY29uID0KKwlDb25uZWN0 aW9uLnNvdXJjZV9mbHVzaF93YXRjaGV2ZW50cyBjb247CiAJaWYgQ29ubmVj dGlvbi5oYXNfb3V0cHV0IGNvbiB0aGVuICgKIAkJaWYgQ29ubmVjdGlvbi5o YXNfbmV3X291dHB1dCBjb24gdGhlbiAoCiAJCQlsZXQgcGFja2V0ID0gQ29u bmVjdGlvbi5wZWVrX291dHB1dCBjb24gaW4KZGlmZiAtLWdpdCBhL3Rvb2xz L29jYW1sL3hlbnN0b3JlZC94ZW5zdG9yZWQubWwgYi90b29scy9vY2FtbC94 ZW5zdG9yZWQveGVuc3RvcmVkLm1sCmluZGV4IDBiNjM0M2RmYzc4OS4uNGY4 ZmFiMmRkMTNhIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQv eGVuc3RvcmVkLm1sCisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC94ZW5z dG9yZWQubWwKQEAgLTEwMiw2ICsxMDIsOCBAQCBsZXQgcGFyc2VfY29uZmln IGZpbGVuYW1lID0KIAkJKCJxdW90YS1tYXhlbnRpdHkiLCBDb25maWcuU2V0 X2ludCBRdW90YS5tYXhlbnQpOwogCQkoInF1b3RhLW1heHNpemUiLCBDb25m aWcuU2V0X2ludCBRdW90YS5tYXhzaXplKTsKIAkJKCJxdW90YS1tYXhyZXF1 ZXN0cyIsIENvbmZpZy5TZXRfaW50IERlZmluZS5tYXhyZXF1ZXN0cyk7CisJ CSgicXVvdGEtbWF4b3V0c3RhbmRpbmciLCBDb25maWcuU2V0X2ludCBEZWZp bmUubWF4b3V0c3RhbmRpbmcpOworCQkoInF1b3RhLW1heHdhdGNoZXZlbnRz IiwgQ29uZmlnLlNldF9pbnQgRGVmaW5lLm1heHdhdGNoZXZlbnRzKTsKIAkJ KCJxdW90YS1wYXRoLW1heCIsIENvbmZpZy5TZXRfaW50IERlZmluZS5wYXRo X21heCk7CiAJCSgiZ2MtbWF4LW92ZXJoZWFkIiwgQ29uZmlnLlNldF9pbnQg RGVmaW5lLmdjX21heF9vdmVyaGVhZCk7CiAJCSgidGVzdC1lYWdhaW4iLCBD b25maWcuU2V0X2Jvb2wgVHJhbnNhY3Rpb24udGVzdF9lYWdhaW4pOwo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-oxenstored-08.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-oxenstored-08.patch" Content-Transfer-Encoding: base64 RnJvbSBiNWJiODBhMGFkMTliZDE1ZjYxMTU4NjFlYmIzMWY0MWFkNzliYTAw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFRodSwgMjkgU2VwIDIwMjIgMTM6 MDc6MzUgKzAyMDAKU3ViamVjdDogU1VQUE9SVC5tZDogY2xhcmlmeSBzdXBw b3J0IG9mIHVudHJ1c3RlZCBkcml2ZXIgZG9tYWlucyB3aXRoCiBveGVuc3Rv cmVkCgpBZGQgYSBzdXBwb3J0IHN0YXRlbWVudCBmb3IgdGhlIHNjb3BlIG9m IHN1cHBvcnQgcmVnYXJkaW5nIGRpZmZlcmVudApYZW5zdG9yZSB2YXJpYW50 cy4gRXNwZWNpYWxseSBveGVuc3RvcmVkIGRvZXMgbm90ICh5ZXQpIGhhdmUg c2VjdXJpdHkKc3VwcG9ydCBvZiB1bnRydXN0ZWQgZHJpdmVyIGRvbWFpbnMs IGFzIHRob3NlIG1pZ2h0IGRyaXZlIG94ZW5zdG9yZWQKb3V0IG9mIG1lbW9y eSBieSBjcmVhdGluZyBsb3RzIG9mIHdhdGNoIGV2ZW50cyBmb3IgdGhlIGd1 ZXN0cyB0aGV5IGFyZQpzZXJ2aWNpbmcuCgpBZGQgYSBzdGF0ZW1lbnQgcmVn YXJkaW5nIExpdmUgVXBkYXRlIHN1cHBvcnQgb2Ygb3hlbnN0b3JlZC4KClRo aXMgaXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEdlb3JnZSBE dW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClJldmlld2VkLWJ5OiBD aHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+ CgpkaWZmIC0tZ2l0IGEvU1VQUE9SVC5tZCBiL1NVUFBPUlQubWQKaW5kZXgg M2Y0YTAxMTAxZTUzLi4yZGIzNDFjMWQ4NTMgMTAwNjQ0Ci0tLSBhL1NVUFBP UlQubWQKKysrIGIvU1VQUE9SVC5tZApAQCAtMTQ5LDYgKzE0OSwxNyBAQCBP dXRwdXQgb2YgaW5mb3JtYXRpb24gaW4gbWFjaGluZS1wYXJzZWFibGUgSlNP TiBmb3JtYXQKIAogICAgIFN0YXR1czogU3VwcG9ydGVkCiAKKyMjIFhlbnN0 b3JlCisKKyMjIyBDIHhlbnN0b3JlZCBkYWVtb24KKworICAgIFN0YXR1czog U3VwcG9ydGVkCisKKyMjIyBPQ2FtbCB4ZW5zdG9yZWQgZGFlbW9uCisKKyAg ICBTdGF0dXM6IFN1cHBvcnRlZAorICAgIFN0YXR1cywgdW50cnVzdGVkIGRy aXZlciBkb21haW5zOiBTdXBwb3J0ZWQsIG5vdCBzZWN1cml0eSBzdXBwb3J0 ZWQKKwogIyMgVG9vbHN0YWNrLzNyZCBwYXJ0eQogCiAjIyMgbGlidmlydCBk cml2ZXIgZm9yIHhsCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-01.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-01.patch" Content-Transfer-Encoding: base64 RnJvbSA0MTc2M2NhNGM3ODg2Mzg3NTFmYjU1NTJiNjBjYzkzMmMzNzViYmI5 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHNwbGl0IHVw IHNlbmRfcmVwbHkoKQoKVG9kYXkgc2VuZF9yZXBseSgpIGlzIHVzZWQgZm9y IGJvdGgsIG5vcm1hbCByZXF1ZXN0IHJlcGxpZXMgYW5kIHdhdGNoCmV2ZW50 cy4KClNwbGl0IGl0IHVwIGludG8gc2VuZF9yZXBseSgpIGFuZCBzZW5kX2V2 ZW50KCkuIFRoaXMgd2lsbCBiZSB1c2VkIHRvCmFkZCBzb21lIGV2ZW50IHNw ZWNpZmljIGhhbmRsaW5nLgoKYWRkX2V2ZW50KCkgY2FuIGJlIG1lcmdlZCBp bnRvIHNlbmRfZXZlbnQoKSwgcmVtb3ZpbmcgdGhlIG5lZWQgZm9yIGFuCmlu dGVybWVkaWF0ZSBtZW1vcnkgYWxsb2NhdGlvbi4KClRoaXMgaXMgcGFydCBv ZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxs QGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpn cm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdy YWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMKaW5kZXggZTBkNmQyM2YzYjc2Li45N2ZmMzVjZDJiMTEgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtNjcyLDQ5ICs2 NzIsMzIgQEAgc3RhdGljIHZvaWQgc2VuZF9lcnJvcihzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgaW50IGVycm9yKQogdm9pZCBzZW5kX3JlcGx5KHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlw ZSwKIAkJY29uc3Qgdm9pZCAqZGF0YSwgdW5zaWduZWQgaW50IGxlbikKIHsK LQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRhdGE7CisJc3RydWN0IGJ1ZmZl cmVkX2RhdGEgKmJkYXRhID0gY29ubi0+aW47CisKKwlhc3NlcnQodHlwZSAh PSBYU19XQVRDSF9FVkVOVCk7CiAKIAlpZiAoIGxlbiA+IFhFTlNUT1JFX1BB WUxPQURfTUFYICkgewogCQlzZW5kX2Vycm9yKGNvbm4sIEUyQklHKTsKIAkJ cmV0dXJuOwogCX0KIAotCS8qIFJlcGxpZXMgcmV1c2UgdGhlIHJlcXVlc3Qg YnVmZmVyLCBldmVudHMgbmVlZCBhIG5ldyBvbmUuICovCi0JaWYgKHR5cGUg IT0gWFNfV0FUQ0hfRVZFTlQpIHsKLQkJYmRhdGEgPSBjb25uLT5pbjsKLQkJ LyogRHJvcCBhc3luY2hyb25vdXMgcmVzcG9uc2VzLCBlLmcuIGVycm9ycyBm b3Igd2F0Y2ggZXZlbnRzLiAqLwotCQlpZiAoIWJkYXRhKQotCQkJcmV0dXJu OwotCQliZGF0YS0+aW5oZHIgPSB0cnVlOwotCQliZGF0YS0+dXNlZCA9IDA7 Ci0JCWNvbm4tPmluID0gTlVMTDsKLQl9IGVsc2UgewotCQkvKiBNZXNzYWdl IGlzIGEgY2hpbGQgb2YgdGhlIGNvbm5lY3Rpb24gZm9yIGF1dG8tY2xlYW51 cC4gKi8KLQkJYmRhdGEgPSBuZXdfYnVmZmVyKGNvbm4pOworCWlmICghYmRh dGEpCisJCXJldHVybjsKKwliZGF0YS0+aW5oZHIgPSB0cnVlOworCWJkYXRh LT51c2VkID0gMDsKIAotCQkvKgotCQkgKiBBbGxvY2F0aW9uIGZhaWx1cmUg aGVyZSBpcyB1bmZvcnR1bmF0ZTogd2UgaGF2ZSBubyB3YXkgdG8KLQkJICog dGVsbCBhbnlib2R5IGFib3V0IGl0LgotCQkgKi8KLQkJaWYgKCFiZGF0YSkK LQkJCXJldHVybjsKLQl9CiAJaWYgKGxlbiA8PSBERUZBVUxUX0JVRkZFUl9T SVpFKQogCQliZGF0YS0+YnVmZmVyID0gYmRhdGEtPmRlZmF1bHRfYnVmZmVy OwotCWVsc2UKKwllbHNlIHsKIAkJYmRhdGEtPmJ1ZmZlciA9IHRhbGxvY19h cnJheShiZGF0YSwgY2hhciwgbGVuKTsKLQlpZiAoIWJkYXRhLT5idWZmZXIp IHsKLQkJaWYgKHR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQpIHsKLQkJCS8qIFNh bWUgYXMgYWJvdmU6IG5vIHdheSB0byB0ZWxsIHNvbWVvbmUuICovCi0JCQl0 YWxsb2NfZnJlZShiZGF0YSk7CisJCWlmICghYmRhdGEtPmJ1ZmZlcikgewor CQkJc2VuZF9lcnJvcihjb25uLCBFTk9NRU0pOwogCQkJcmV0dXJuOwogCQl9 Ci0JCS8qIHJlLWVzdGFibGlzaCByZXF1ZXN0IGJ1ZmZlciBmb3Igc2VuZGlu ZyBFTk9NRU0uICovCi0JCWNvbm4tPmluID0gYmRhdGE7Ci0JCXNlbmRfZXJy b3IoY29ubiwgRU5PTUVNKTsKLQkJcmV0dXJuOwogCX0KIAorCWNvbm4tPmlu ID0gTlVMTDsKKwogCS8qIFVwZGF0ZSByZWxldmFudCBoZWFkZXIgZmllbGRz IGFuZCBmaWxsIGluIHRoZSBtZXNzYWdlIGJvZHkuICovCiAJYmRhdGEtPmhk ci5tc2cudHlwZSA9IHR5cGU7CiAJYmRhdGEtPmhkci5tc2cubGVuID0gbGVu OwpAQCAtNzIyLDggKzcwNSwzOSBAQCB2b2lkIHNlbmRfcmVwbHkoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBl LAogCiAJLyogUXVldWUgZm9yIGxhdGVyIHRyYW5zbWlzc2lvbi4gKi8KIAls aXN0X2FkZF90YWlsKCZiZGF0YS0+bGlzdCwgJmNvbm4tPm91dF9saXN0KTsK K30KIAotCXJldHVybjsKKy8qCisgKiBTZW5kIGEgd2F0Y2ggZXZlbnQuCisg KiBBcyB0aGlzIGlzIG5vdCBkaXJlY3RseSByZWxhdGVkIHRvIHRoZSBjdXJy ZW50IGNvbW1hbmQsIGVycm9ycyBjYW4ndCBiZQorICogcmVwb3J0ZWQuCisg Ki8KK3ZvaWQgc2VuZF9ldmVudChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3QgY2hhciAqcGF0aCwgY29uc3QgY2hhciAqdG9rZW4pCit7CisJc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmJkYXRhOworCXVuc2lnbmVkIGludCBsZW47 CisKKwlsZW4gPSBzdHJsZW4ocGF0aCkgKyAxICsgc3RybGVuKHRva2VuKSAr IDE7CisJLyogRG9uJ3QgdHJ5IHRvIHNlbmQgb3Zlci1sb25nIGV2ZW50cy4g Ki8KKwlpZiAobGVuID4gWEVOU1RPUkVfUEFZTE9BRF9NQVgpCisJCXJldHVy bjsKKworCWJkYXRhID0gbmV3X2J1ZmZlcihjb25uKTsKKwlpZiAoIWJkYXRh KQorCQlyZXR1cm47CisKKwliZGF0YS0+YnVmZmVyID0gdGFsbG9jX2FycmF5 KGJkYXRhLCBjaGFyLCBsZW4pOworCWlmICghYmRhdGEtPmJ1ZmZlcikgewor CQl0YWxsb2NfZnJlZShiZGF0YSk7CisJCXJldHVybjsKKwl9CisJc3RyY3B5 KGJkYXRhLT5idWZmZXIsIHBhdGgpOworCXN0cmNweShiZGF0YS0+YnVmZmVy ICsgc3RybGVuKHBhdGgpICsgMSwgdG9rZW4pOworCWJkYXRhLT5oZHIubXNn LnR5cGUgPSBYU19XQVRDSF9FVkVOVDsKKwliZGF0YS0+aGRyLm1zZy5sZW4g PSBsZW47CisKKwkvKiBRdWV1ZSBmb3IgbGF0ZXIgdHJhbnNtaXNzaW9uLiAq LworCWxpc3RfYWRkX3RhaWwoJmJkYXRhLT5saXN0LCAmY29ubi0+b3V0X2xp c3QpOwogfQogCiAvKiBTb21lIHJvdXRpbmVzICh3cml0ZSwgbWtkaXIsIGV0 YykganVzdCBuZWVkIGEgbm9uLWVycm9yIHJldHVybiAqLwpkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKaW5kZXggOTM2OWM0Y2JmZDI2Li4y YjBmNzk2ZDliYjEgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuaApAQCAtMTUwLDYgKzE1MCw3IEBAIHVuc2lnbmVkIGludCBnZXRfc3Ry aW5ncyhzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqZGF0YSwKIAogdm9pZCBzZW5k X3JlcGx5KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2Nr bXNnX3R5cGUgdHlwZSwKIAkJY29uc3Qgdm9pZCAqZGF0YSwgdW5zaWduZWQg aW50IGxlbik7Cit2b2lkIHNlbmRfZXZlbnQoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIGNvbnN0IGNoYXIgKnBhdGgsIGNvbnN0IGNoYXIgKnRva2VuKTsK IAogLyogU29tZSByb3V0aW5lcyAod3JpdGUsIG1rZGlyLCBldGMpIGp1c3Qg bmVlZCBhIG5vbi1lcnJvciByZXR1cm4gKi8KIHZvaWQgc2VuZF9hY2soc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0 eXBlKTsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93 YXRjaC5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmMKaW5k ZXggOWZmMjA2OTBjMDAwLi42ZDgwOTczNzZlNDcgMTAwNjQ0Ci0tLSBhL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCisrKyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCkBAIC03MiwzNyArNzIsMTcgQEAg c3RhdGljIGJvb2wgaXNfY2hpbGQoY29uc3QgY2hhciAqY2hpbGQsIGNvbnN0 IGNoYXIgKnBhcmVudCkKIAlyZXR1cm4gY2hpbGRbbGVuXSA9PSAnLycgfHwg Y2hpbGRbbGVuXSA9PSAnXDAnOwogfQogCi0vKgotICogU2VuZCBhIHdhdGNo IGV2ZW50LgotICogVGVtcG9yYXJ5IG1lbW9yeSBhbGxvY2F0aW9ucyBhcmUg ZG9uZSB3aXRoIGN0eC4KLSAqLwotc3RhdGljIHZvaWQgYWRkX2V2ZW50KHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLAotCQkgICAgICBjb25zdCB2b2lkICpj dHgsCi0JCSAgICAgIHN0cnVjdCB3YXRjaCAqd2F0Y2gsCi0JCSAgICAgIGNv bnN0IGNoYXIgKm5hbWUpCitzdGF0aWMgY29uc3QgY2hhciAqZ2V0X3dhdGNo X3BhdGgoY29uc3Qgc3RydWN0IHdhdGNoICp3YXRjaCwgY29uc3QgY2hhciAq bmFtZSkKIHsKLQkvKiBEYXRhIHRvIHNlbmQgKG5vZGVcMHRva2VuXDApLiAq LwotCXVuc2lnbmVkIGludCBsZW47Ci0JY2hhciAqZGF0YTsKKwljb25zdCBj aGFyICpwYXRoID0gbmFtZTsKIAogCWlmICh3YXRjaC0+cmVsYXRpdmVfcGF0 aCkgewotCQluYW1lICs9IHN0cmxlbih3YXRjaC0+cmVsYXRpdmVfcGF0aCk7 Ci0JCWlmICgqbmFtZSA9PSAnLycpIC8qIENvdWxkIGJlICIiICovCi0JCQlu YW1lKys7CisJCXBhdGggKz0gc3RybGVuKHdhdGNoLT5yZWxhdGl2ZV9wYXRo KTsKKwkJaWYgKCpwYXRoID09ICcvJykgLyogQ291bGQgYmUgIiIgKi8KKwkJ CXBhdGgrKzsKIAl9CiAKLQlsZW4gPSBzdHJsZW4obmFtZSkgKyAxICsgc3Ry bGVuKHdhdGNoLT50b2tlbikgKyAxOwotCS8qIERvbid0IHRyeSB0byBzZW5k IG92ZXItbG9uZyBldmVudHMuICovCi0JaWYgKGxlbiA+IFhFTlNUT1JFX1BB WUxPQURfTUFYKQotCQlyZXR1cm47Ci0KLQlkYXRhID0gdGFsbG9jX2FycmF5 KGN0eCwgY2hhciwgbGVuKTsKLQlpZiAoIWRhdGEpCi0JCXJldHVybjsKLQlz dHJjcHkoZGF0YSwgbmFtZSk7Ci0Jc3RyY3B5KGRhdGEgKyBzdHJsZW4obmFt ZSkgKyAxLCB3YXRjaC0+dG9rZW4pOwotCXNlbmRfcmVwbHkoY29ubiwgWFNf V0FUQ0hfRVZFTlQsIGRhdGEsIGxlbik7Ci0JdGFsbG9jX2ZyZWUoZGF0YSk7 CisJcmV0dXJuIHBhdGg7CiB9CiAKIC8qCkBAIC0xODEsMTAgKzE2MSwxNCBA QCB2b2lkIGZpcmVfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3Qgdm9pZCAqY3R4LCBjb25zdCBjaGFyICpuYW1lLAogCQlsaXN0X2Zv cl9lYWNoX2VudHJ5KHdhdGNoLCAmaS0+d2F0Y2hlcywgbGlzdCkgewogCQkJ aWYgKGV4YWN0KSB7CiAJCQkJaWYgKHN0cmVxKG5hbWUsIHdhdGNoLT5ub2Rl KSkKLQkJCQkJYWRkX2V2ZW50KGksIGN0eCwgd2F0Y2gsIG5hbWUpOworCQkJ CQlzZW5kX2V2ZW50KGksCisJCQkJCQkgICBnZXRfd2F0Y2hfcGF0aCh3YXRj aCwgbmFtZSksCisJCQkJCQkgICB3YXRjaC0+dG9rZW4pOwogCQkJfSBlbHNl IHsKIAkJCQlpZiAoaXNfY2hpbGQobmFtZSwgd2F0Y2gtPm5vZGUpKQotCQkJ CQlhZGRfZXZlbnQoaSwgY3R4LCB3YXRjaCwgbmFtZSk7CisJCQkJCXNlbmRf ZXZlbnQoaSwKKwkJCQkJCSAgIGdldF93YXRjaF9wYXRoKHdhdGNoLCBuYW1l KSwKKwkJCQkJCSAgIHdhdGNoLT50b2tlbik7CiAJCQl9CiAJCX0KIAl9CkBA IC0yNTIsNyArMjM2LDcgQEAgaW50IGRvX3dhdGNoKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJc2VuZF9h Y2soY29ubiwgWFNfV0FUQ0gpOwogCiAJLyogV2UgZmlyZSBvbmNlIHVwIGZy b250OiBzaW1wbGlmaWVzIGNsaWVudHMgYW5kIHJlc3RhcnQuICovCi0JYWRk X2V2ZW50KGNvbm4sIGluLCB3YXRjaCwgd2F0Y2gtPm5vZGUpOworCXNlbmRf ZXZlbnQoY29ubiwgZ2V0X3dhdGNoX3BhdGgod2F0Y2gsIHdhdGNoLT5ub2Rl KSwgd2F0Y2gtPnRva2VuKTsKIAogCXJldHVybiAwOwogfQo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-02.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-02.patch" Content-Transfer-Encoding: base64 RnJvbSBlY2EzMTA4ODM0YmYxZDExNWIyNDAyOGY5NDNlYWE3ZTkyNDAzMGNk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBoZWxw ZXJzIHRvIGZyZWUgc3RydWN0IGJ1ZmZlcmVkX2RhdGEKCkFkZCB0d28gaGVs cGVycyBmb3IgZnJlZWluZyBzdHJ1Y3QgYnVmZmVyZWRfZGF0YTogZnJlZV9i dWZmZXJlZF9kYXRhKCkKZm9yIGZyZWVpbmcgb25lIGluc3RhbmNlIGFuZCBj b25uX2ZyZWVfYnVmZmVyZWRfZGF0YSgpIGZvciBmcmVlaW5nIGFsbAppbnN0 YW5jZXMgZm9yIGEgY29ubmVjdGlvbi4KClRoaXMgaXMgYXZvaWRpbmcgZHVw bGljYXRlZCBjb2RlIGFuZCB3aWxsIGhlbHAgbGF0ZXIgd2hlbiBtb3JlIGFj dGlvbnMKYXJlIG5lZWRlZCB3aGVuIGZyZWVpbmcgYSBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQt Ynk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1v ZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3 ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggOTdmZjM1Y2Qy YjExLi4xMWI4ZDk4NjM0MGYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYwpAQCAtMjA1LDYgKzIwNSwyMSBAQCB2b2lkIHJlb3Blbl9s b2codm9pZCkKIAl9CiB9CiAKK3N0YXRpYyB2b2lkIGZyZWVfYnVmZmVyZWRf ZGF0YShzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqb3V0LAorCQkJICAgICAgIHN0 cnVjdCBjb25uZWN0aW9uICpjb25uKQoreworCWxpc3RfZGVsKCZvdXQtPmxp c3QpOworCXRhbGxvY19mcmVlKG91dCk7Cit9CisKK3ZvaWQgY29ubl9mcmVl X2J1ZmZlcmVkX2RhdGEoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCit7CisJ c3RydWN0IGJ1ZmZlcmVkX2RhdGEgKm91dDsKKworCXdoaWxlICgob3V0ID0g bGlzdF90b3AoJmNvbm4tPm91dF9saXN0LCBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSwgbGlzdCkpKQorCQlmcmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBjb25uKTsK K30KKwogc3RhdGljIGJvb2wgd3JpdGVfbWVzc2FnZXMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pCiB7CiAJaW50IHJldDsKQEAgLTI0OCw4ICsyNjMsNyBA QCBzdGF0aWMgYm9vbCB3cml0ZV9tZXNzYWdlcyhzdHJ1Y3QgY29ubmVjdGlv biAqY29ubikKIAogCXRyYWNlX2lvKGNvbm4sIG91dCwgMSk7CiAKLQlsaXN0 X2RlbCgmb3V0LT5saXN0KTsKLQl0YWxsb2NfZnJlZShvdXQpOworCWZyZWVf YnVmZmVyZWRfZGF0YShvdXQsIGNvbm4pOwogCiAJcmV0dXJuIHRydWU7CiB9 CkBAIC0xMzg5LDE4ICsxNDAzLDEyIEBAIHN0YXRpYyBzdHJ1Y3QgewogICov CiBzdGF0aWMgdm9pZCBpZ25vcmVfY29ubmVjdGlvbihzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubikKIHsKLQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqb3V0LCAq dG1wOwotCiAJdHJhY2UoIkNPTk4gJXAgaWdub3JlZFxuIiwgY29ubik7CiAK IAljb25uLT5pc19pZ25vcmVkID0gdHJ1ZTsKIAljb25uX2RlbGV0ZV9hbGxf d2F0Y2hlcyhjb25uKTsKIAljb25uX2RlbGV0ZV9hbGxfdHJhbnNhY3Rpb25z KGNvbm4pOwotCi0JbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKG91dCwgdG1w LCAmY29ubi0+b3V0X2xpc3QsIGxpc3QpIHsKLQkJbGlzdF9kZWwoJm91dC0+ bGlzdCk7Ci0JCXRhbGxvY19mcmVlKG91dCk7Ci0JfQorCWNvbm5fZnJlZV9i dWZmZXJlZF9kYXRhKGNvbm4pOwogCiAJdGFsbG9jX2ZyZWUoY29ubi0+aW4p OwogCWNvbm4tPmluID0gTlVMTDsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5oCmluZGV4IDJiMGY3OTZkOWJiMS4uODNkNDk2OTNmYzE5IDEw MDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCisr KyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKQEAgLTIyNiw2 ICsyMjYsOCBAQCBleHRlcm4geGVuZ250dGFiX2hhbmRsZSAqKnhndF9oYW5k bGU7CiAKIGludCByZW1lbWJlcl9zdHJpbmcoc3RydWN0IGhhc2h0YWJsZSAq aGFzaCwgY29uc3QgY2hhciAqc3RyKTsKIAordm9pZCBjb25uX2ZyZWVfYnVm ZmVyZWRfZGF0YShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7CisKICNlbmRp ZiAvKiBfWEVOU1RPUkVEX0NPUkVfSCAqLwogCiAvKgpkaWZmIC0tZ2l0IGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IGNiZDhlNmI3NDdiZC4u NDE2YjkyY2FkNGIyIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2RvbWFpbi5jCkBAIC00MDYsMTUgKzQwNiwxMCBAQCBzdGF0aWMgc3RydWN0 IGRvbWFpbiAqZmluZF9kb21haW5fYnlfZG9taWQodW5zaWduZWQgaW50IGRv bWlkKQogc3RhdGljIHZvaWQgZG9tYWluX2Nvbm5fcmVzZXQoc3RydWN0IGRv bWFpbiAqZG9tYWluKQogewogCXN0cnVjdCBjb25uZWN0aW9uICpjb25uID0g ZG9tYWluLT5jb25uOwotCXN0cnVjdCBidWZmZXJlZF9kYXRhICpvdXQ7CiAK IAljb25uX2RlbGV0ZV9hbGxfd2F0Y2hlcyhjb25uKTsKIAljb25uX2RlbGV0 ZV9hbGxfdHJhbnNhY3Rpb25zKGNvbm4pOwotCi0Jd2hpbGUgKChvdXQgPSBs aXN0X3RvcCgmY29ubi0+b3V0X2xpc3QsIHN0cnVjdCBidWZmZXJlZF9kYXRh LCBsaXN0KSkpIHsKLQkJbGlzdF9kZWwoJm91dC0+bGlzdCk7Ci0JCXRhbGxv Y19mcmVlKG91dCk7Ci0JfQorCWNvbm5fZnJlZV9idWZmZXJlZF9kYXRhKGNv bm4pOwogCiAJdGFsbG9jX2ZyZWUoY29ubi0+aW4pOwogCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-03.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-03.patch" Content-Transfer-Encoding: base64 RnJvbSBmMDA4MWRhOWRkNzIxOGY0ODY4NDFkYzZjYWNiZTcxZDJmYzc2MWU4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHJlZHVjZSBu dW1iZXIgb2Ygd2F0Y2ggZXZlbnRzCgpXaGVuIHJlbW92aW5nIGEgd2F0Y2hl ZCBub2RlIG91dHNpZGUgb2YgYSB0cmFuc2FjdGlvbiwgdHdvIHdhdGNoIGV2 ZW50cwphcmUgYmVpbmcgcHJvZHVjZWQgaW5zdGVhZCBvZiBqdXN0IGEgc2lu Z2xlIG9uZS4KCldoZW4gZmluYWxpemluZyBhIHRyYW5zYWN0aW9uIHdhdGNo IGV2ZW50cyBjYW4gYmUgZ2VuZXJhdGVkIGZvciBlYWNoCm5vZGUgd2hpY2gg aXMgYmVpbmcgbW9kaWZpZWQsIGV2ZW4gaWYgb3V0c2lkZSBhIHRyYW5zYWN0 aW9uIHN1Y2gKbW9kaWZpY2F0aW9ucyBtaWdodCBub3QgaGF2ZSByZXN1bHRl ZCBpbiBhIHdhdGNoIGV2ZW50LgoKVGhpcyBoYXBwZW5zIGUuZy46CgotIGZv ciBub2RlcyB3aGljaCBhcmUgb25seSBtb2RpZmllZCBkdWUgdG8gYWRkZWQv cmVtb3ZlZCBjaGlsZCBlbnRyaWVzCi0gZm9yIG5vZGVzIGJlaW5nIHJlbW92 ZWQgb3IgY3JlYXRlZCBpbXBsaWNpdGx5IChlLmcuIGNyZWF0aW9uIG9mIGEv Yi9jCiAgaXMgaW1wbGljaXRseSBjcmVhdGluZyBhL2IsIHJlc3VsdGluZyBp biB3YXRjaCBldmVudHMgZm9yIGEsIGEvYiBhbmQKICBhL2IvYyBpbnN0ZWFk IG9mIGEvYi9jIG9ubHkpCgpBdm9pZCB0aGVzZSBhZGRpdGlvbmFsIHdhdGNo IGV2ZW50cywgaW4gb3JkZXIgdG8gcmVkdWNlIHRoZSBuZWVkZWQKbWVtb3J5 IGluc2lkZSBYZW5zdG9yZSBmb3IgcXVldWVpbmcgdGhlbS4KClRoaXMgaXMg YmVpbmcgYWNoaWV2ZWQgYnkgYWRkaW5nIGV2ZW50IGZsYWdzIHRvIHN0cnVj dCBhY2Nlc3NlZF9ub2RlCnNwZWNpZnlpbmcgd2hldGhlciBhbiBldmVudCBz aG91bGQgYmUgdHJpZ2dlcmVkLCBhbmQgd2hldGhlciBpdCBzaG91bGQKYmUg YW4gZXhhY3QgbWF0Y2ggb2YgdGhlIG1vZGlmaWVkIHBhdGguIEJvdGggZmxh Z3MgY2FuIGJlIHNldCBmcm9tCmZpcmVfd2F0Y2hlcygpIGluc3RlYWQgb2Yg aW1wbHlpbmcgdGhlbSBvbmx5LgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYu CgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNv bT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwppbmRl eCAxMWI4ZDk4NjM0MGYuLjhmOGQxMGNlZTk1ZSAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0xMTgwLDcgKzExODAsNyBAQCBz dGF0aWMgdm9pZCBkZWxldGVfY2hpbGQoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sCiB9CiAKIHN0YXRpYyBpbnQgZGVsZXRlX25vZGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKLQkJICAgICAgIHN0cnVj dCBub2RlICpwYXJlbnQsIHN0cnVjdCBub2RlICpub2RlKQorCQkgICAgICAg c3RydWN0IG5vZGUgKnBhcmVudCwgc3RydWN0IG5vZGUgKm5vZGUsIGJvb2wg d2F0Y2hfZXhhY3QpCiB7CiAJY2hhciAqbmFtZTsKIApAQCAtMTE5Miw3ICsx MTkyLDcgQEAgc3RhdGljIGludCBkZWxldGVfbm9kZShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCQkJCSAgICAgICBub2Rl LT5jaGlsZHJlbik7CiAJCWNoaWxkID0gbmFtZSA/IHJlYWRfbm9kZShjb25u LCBub2RlLCBuYW1lKSA6IE5VTEw7CiAJCWlmIChjaGlsZCkgewotCQkJaWYg KGRlbGV0ZV9ub2RlKGNvbm4sIGN0eCwgbm9kZSwgY2hpbGQpKQorCQkJaWYg KGRlbGV0ZV9ub2RlKGNvbm4sIGN0eCwgbm9kZSwgY2hpbGQsIHRydWUpKQog CQkJCXJldHVybiBlcnJubzsKIAkJfSBlbHNlIHsKIAkJCXRyYWNlKCJkZWxl dGVfbm9kZTogRXJyb3IgZGVsZXRpbmcgY2hpbGQgJyVzLyVzJyFcbiIsCkBA IC0xMjA0LDcgKzEyMDQsMTIgQEAgc3RhdGljIGludCBkZWxldGVfbm9kZShz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCQl0 YWxsb2NfZnJlZShuYW1lKTsKIAl9CiAKLQlmaXJlX3dhdGNoZXMoY29ubiwg Y3R4LCBub2RlLT5uYW1lLCBub2RlLCB0cnVlLCBOVUxMKTsKKwkvKgorCSAq IEZpcmUgdGhlIHdhdGNoZXMgbm93LCB3aGVuIHdlIGNhbiBzdGlsbCBzZWUg dGhlIG5vZGUgcGVybWlzc2lvbnMuCisJICogVGhpcyBmaW5lIGFzIHdlIGFy ZSBzaW5nbGUgdGhyZWFkZWQgYW5kIHRoZSBuZXh0IHBvc3NpYmxlIHJlYWQg d2lsbAorCSAqIGJlIGhhbmRsZWQgb25seSBhZnRlciB0aGUgbm9kZSBoYXMg YmVlbiByZWFsbHkgcmVtb3ZlZC4KKwkgKi8KKwlmaXJlX3dhdGNoZXMoY29u biwgY3R4LCBub2RlLT5uYW1lLCBub2RlLCB3YXRjaF9leGFjdCwgTlVMTCk7 CiAJZGVsZXRlX25vZGVfc2luZ2xlKGNvbm4sIG5vZGUpOwogCWRlbGV0ZV9j aGlsZChjb25uLCBwYXJlbnQsIGJhc2VuYW1lKG5vZGUtPm5hbWUpKTsKIAl0 YWxsb2NfZnJlZShub2RlKTsKQEAgLTEyMzAsMTMgKzEyMzUsNyBAQCBzdGF0 aWMgaW50IF9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9p ZCAqY3R4LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIAkJcmV0dXJuIChlcnJubyA9 PSBFTk9NRU0pID8gRU5PTUVNIDogRUlOVkFMOwogCW5vZGUtPnBhcmVudCA9 IHBhcmVudDsKIAotCS8qCi0JICogRmlyZSB0aGUgd2F0Y2hlcyBub3csIHdo ZW4gd2UgY2FuIHN0aWxsIHNlZSB0aGUgbm9kZSBwZXJtaXNzaW9ucy4KLQkg KiBUaGlzIGZpbmUgYXMgd2UgYXJlIHNpbmdsZSB0aHJlYWRlZCBhbmQgdGhl IG5leHQgcG9zc2libGUgcmVhZCB3aWxsCi0JICogYmUgaGFuZGxlZCBvbmx5 IGFmdGVyIHRoZSBub2RlIGhhcyBiZWVuIHJlYWxseSByZW1vdmVkLgotCSAq LwotCWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5hbWUsIG5vZGUsIGZhbHNl LCBOVUxMKTsKLQlyZXR1cm4gZGVsZXRlX25vZGUoY29ubiwgY3R4LCBwYXJl bnQsIG5vZGUpOworCXJldHVybiBkZWxldGVfbm9kZShjb25uLCBjdHgsIHBh cmVudCwgbm9kZSwgZmFsc2UpOwogfQogCiAKZGlmZiAtLWdpdCBhL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKaW5kZXggNGZmYTE4MzEx MTIwLi42ZmJkYjI5ZGNkZDcgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCisrKyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCkBAIC0xMzAsNiArMTMwLDEwIEBA IHN0cnVjdCBhY2Nlc3NlZF9ub2RlCiAKIAkvKiBUcmFuc2FjdGlvbiBub2Rl IGluIGRhdGEgYmFzZT8gKi8KIAlib29sIHRhX25vZGU7CisKKwkvKiBXYXRj aCBldmVudCBmbGFncy4gKi8KKwlib29sIGZpcmVfd2F0Y2g7CisJYm9vbCB3 YXRjaF9leGFjdDsKIH07CiAKIHN0cnVjdCBjaGFuZ2VkX2RvbWFpbgpAQCAt MzMwLDYgKzMzNCwyOSBAQCBpbnQgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAogfQogCiAvKgorICog QSB3YXRjaCBldmVudCBzaG91bGQgYmUgZmlyZWQgZm9yIGEgbm9kZSBtb2Rp ZmllZCBpbnNpZGUgYSB0cmFuc2FjdGlvbi4KKyAqIFNldCB0aGUgY29ycmVz cG9uZGluZyBpbmZvcm1hdGlvbi4gQSBub24tZXhhY3QgZXZlbnQgaXMgcmVw bGFjaW5nIGFuIGV4YWN0CisgKiBvbmUsIGJ1dCBub3QgdGhlIG90aGVyIHdh eSByb3VuZC4KKyAqLwordm9pZCBxdWV1ZV93YXRjaGVzKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpuYW1lLCBib29sIHdhdGNoX2V4 YWN0KQoreworCXN0cnVjdCBhY2Nlc3NlZF9ub2RlICppOworCisJaSA9IGZp bmRfYWNjZXNzZWRfbm9kZShjb25uLT50cmFuc2FjdGlvbiwgbmFtZSk7CisJ aWYgKCFpKSB7CisJCWNvbm4tPnRyYW5zYWN0aW9uLT5mYWlsID0gdHJ1ZTsK KwkJcmV0dXJuOworCX0KKworCWlmICghaS0+ZmlyZV93YXRjaCkgeworCQlp LT5maXJlX3dhdGNoID0gdHJ1ZTsKKwkJaS0+d2F0Y2hfZXhhY3QgPSB3YXRj aF9leGFjdDsKKwl9IGVsc2UgaWYgKCF3YXRjaF9leGFjdCkgeworCQlpLT53 YXRjaF9leGFjdCA9IGZhbHNlOworCX0KK30KKworLyoKICAqIEZpbmFsaXpl IHRyYW5zYWN0aW9uOgogICogV2FsayB0aHJvdWdoIGFjY2Vzc2VkIG5vZGVz IGFuZCBjaGVjayBnZW5lcmF0aW9uIGFnYWluc3QgZ2xvYmFsIGRhdGEuCiAg KiBJZiBhbGwgZW50cmllcyBtYXRjaCwgcmVhZCB0aGUgdHJhbnNhY3Rpb24g ZW50cmllcyBhbmQgd3JpdGUgdGhlbSB3aXRob3V0CkBAIC0zODMsMTUgKzQx MCwxNSBAQCBzdGF0aWMgaW50IGZpbmFsaXplX3RyYW5zYWN0aW9uKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAogCQkJCXJldCA9IHRkYl9zdG9yZSh0ZGJf Y3R4LCBrZXksIGRhdGEsCiAJCQkJCQlUREJfUkVQTEFDRSk7CiAJCQkJdGFs bG9jX2ZyZWUoZGF0YS5kcHRyKTsKLQkJCQlpZiAocmV0KQotCQkJCQlnb3Rv IGVycjsKLQkJCQlmaXJlX3dhdGNoZXMoY29ubiwgdHJhbnMsIGktPm5vZGUs IE5VTEwsIGZhbHNlLAotCQkJCQkgICAgIGktPnBlcm1zLnAgPyAmaS0+cGVy bXMgOiBOVUxMKTsKIAkJCX0gZWxzZSB7Ci0JCQkJZmlyZV93YXRjaGVzKGNv bm4sIHRyYW5zLCBpLT5ub2RlLCBOVUxMLCBmYWxzZSwKKwkJCQlyZXQgPSB0 ZGJfZGVsZXRlKHRkYl9jdHgsIGtleSk7CisJCQl9CisJCQlpZiAocmV0KQor CQkJCWdvdG8gZXJyOworCQkJaWYgKGktPmZpcmVfd2F0Y2gpIHsKKwkJCQlm aXJlX3dhdGNoZXMoY29ubiwgdHJhbnMsIGktPm5vZGUsIE5VTEwsCisJCQkJ CSAgICAgaS0+d2F0Y2hfZXhhY3QsCiAJCQkJCSAgICAgaS0+cGVybXMucCA/ ICZpLT5wZXJtcyA6IE5VTEwpOwotCQkJCWlmICh0ZGJfZGVsZXRlKHRkYl9j dHgsIGtleSkpCi0JCQkJCWdvdG8gZXJyOwogCQkJfQogCQl9CiAKZGlmZiAt LWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5o IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKaW5k ZXggMTQwNjI3MzBlM2M5Li4wMDkzY2FjODA3ZTMgMTAwNjQ0Ci0tLSBhL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCisrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCkBAIC00Miw2 ICs0Miw5IEBAIHZvaWQgdHJhbnNhY3Rpb25fZW50cnlfZGVjKHN0cnVjdCB0 cmFuc2FjdGlvbiAqdHJhbnMsIHVuc2lnbmVkIGludCBkb21pZCk7CiBpbnQg YWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlLAogICAgICAgICAgICAgICAgIGVudW0gbm9kZV9hY2Nlc3Nf dHlwZSB0eXBlLCBUREJfREFUQSAqa2V5KTsKIAorLyogUXVldWUgd2F0Y2hl cyBmb3IgYSBtb2RpZmllZCBub2RlLiAqLwordm9pZCBxdWV1ZV93YXRjaGVz KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpuYW1lLCBi b29sIHdhdGNoX2V4YWN0KTsKKwogLyogUHJlcGVuZCB0aGUgdHJhbnNhY3Rp b24gdG8gbmFtZSBpZiBhcHByb3ByaWF0ZS4gKi8KIGludCB0cmFuc2FjdGlv bl9wcmVwZW5kKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFy ICpuYW1lLAogICAgICAgICAgICAgICAgICAgICAgICAgVERCX0RBVEEgKmtl eSk7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0 Y2guYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCmluZGV4 IDZkODA5NzM3NmU0Ny4uMmY5MzY3NzY3ZTQ0IDEwMDY0NAotLS0gYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfd2F0Y2guYwpAQCAtMjksNiArMjksNyBAQAogI2lu Y2x1ZGUgInhlbnN0b3JlX2xpYi5oIgogI2luY2x1ZGUgInV0aWxzLmgiCiAj aW5jbHVkZSAieGVuc3RvcmVkX2RvbWFpbi5oIgorI2luY2x1ZGUgInhlbnN0 b3JlZF90cmFuc2FjdGlvbi5oIgogCiBleHRlcm4gaW50IHF1b3RhX25iX3dh dGNoX3Blcl9kb21haW47CiAKQEAgLTE0Myw5ICsxNDQsMTEgQEAgdm9pZCBm aXJlX3dhdGNoZXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZv aWQgKmN0eCwgY29uc3QgY2hhciAqbmFtZSwKIAlzdHJ1Y3QgY29ubmVjdGlv biAqaTsKIAlzdHJ1Y3Qgd2F0Y2ggKndhdGNoOwogCi0JLyogRHVyaW5nIHRy YW5zYWN0aW9ucywgZG9uJ3QgZmlyZSB3YXRjaGVzLiAqLwotCWlmIChjb25u ICYmIGNvbm4tPnRyYW5zYWN0aW9uKQorCS8qIER1cmluZyB0cmFuc2FjdGlv bnMsIGRvbid0IGZpcmUgd2F0Y2hlcywgYnV0IHF1ZXVlIHRoZW0uICovCisJ aWYgKGNvbm4gJiYgY29ubi0+dHJhbnNhY3Rpb24pIHsKKwkJcXVldWVfd2F0 Y2hlcyhjb25uLCBuYW1lLCBleGFjdCk7CiAJCXJldHVybjsKKwl9CiAKIAkv KiBDcmVhdGUgYW4gZXZlbnQgZm9yIGVhY2ggd2F0Y2guICovCiAJbGlzdF9m b3JfZWFjaF9lbnRyeShpLCAmY29ubmVjdGlvbnMsIGxpc3QpIHsK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-04.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-04.patch" Content-Transfer-Encoding: base64 RnJvbSBkYzg5ZTI3MTcyMzdkYWQ1NDg4YjUwOTRkNmRlZjBkYjU0MzhhZmJh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxldCB1bnJl YWQgd2F0Y2ggZXZlbnRzIHRpbWUgb3V0CgpBIGZ1dHVyZSBtb2RpZmljYXRp b24gd2lsbCBsaW1pdCB0aGUgbnVtYmVyIG9mIG91dHN0YW5kaW5nIHJlcXVl c3RzCmZvciBhIGRvbWFpbiwgd2hlcmUgIm91dHN0YW5kaW5nIiBtZWFucyB0 aGF0IHRoZSByZXNwb25zZSBvZiB0aGUKcmVxdWVzdCBvciBhbnkgcmVzdWx0 aW5nIHdhdGNoIGV2ZW50IGhhc24ndCBiZWVuIGNvbnN1bWVkIHlldC4KCklu IG9yZGVyIHRvIGF2b2lkIGEgbWFsaWNpb3VzIGd1ZXN0IGJlaW5nIGNhcGFi bGUgdG8gYmxvY2sgb3RoZXIgZ3Vlc3RzCmJ5IG5vdCByZWFkaW5nIHdhdGNo IGV2ZW50cywgYWRkIGEgdGltZW91dCBmb3Igd2F0Y2ggZXZlbnRzLiBJbiBj YXNlIGEKd2F0Y2ggZXZlbnQgaGFzbid0IGJlZW4gY29uc3VtZWQgYWZ0ZXIg dGhpcyB0aW1lb3V0LCBpdCBpcyBiZWluZwpkZWxldGVkLiBTZXQgdGhlIGRl ZmF1bHQgdGltZW91dCB0byAyMCBzZWNvbmRzIChhIHJhbmRvbSB2YWx1ZSBi ZWluZwpub3QgdG9vIGhpZ2gpLgoKSW4gb3JkZXIgdG8gc3VwcG9ydCB0byBz cGVjaWZ5IG90aGVyIHRpbWVvdXQgdmFsdWVzIGluIGZ1dHVyZSwgdXNlIGEK Z2VuZXJpYyBjb21tYW5kIGxpbmUgb3B0aW9uIGZvciB0aGF0IHB1cnBvc2U6 CgotLXRpbWVvdXR8LXcgd2F0Y2gtZXZlbnQ9PHNlY29uZHM+CgpUaGlzIGlz IHBhcnQgb2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzExLgoKUmVwb3J0ZWQt Ynk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1v ZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3 ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggOGY4ZDEwY2Vl OTVlLi41ZmI0NzE0YjM1NmYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYwpAQCAtMTAzLDYgKzEwMyw4IEBAIGludCBxdW90YV9tYXhf ZW50cnlfc2l6ZSA9IDIwNDg7IC8qIDJLICovCiBpbnQgcXVvdGFfbWF4X3Ry YW5zYWN0aW9uID0gMTA7CiBpbnQgcXVvdGFfbmJfcGVybXNfcGVyX25vZGUg PSA1OwogCit1bnNpZ25lZCBpbnQgdGltZW91dF93YXRjaF9ldmVudF9tc2Vj ID0gMjAwMDA7CisKIHZvaWQgdHJhY2UoY29uc3QgY2hhciAqZm10LCAuLi4p CiB7CiAJdmFfbGlzdCBhcmdsaXN0OwpAQCAtMjA1LDE5ICsyMDcsOTIgQEAg dm9pZCByZW9wZW5fbG9nKHZvaWQpCiAJfQogfQogCitzdGF0aWMgdWludDY0 X3QgZ2V0X25vd19tc2VjKHZvaWQpCit7CisJc3RydWN0IHRpbWVzcGVjIG5v d190czsKKworCWlmIChjbG9ja19nZXR0aW1lKENMT0NLX01PTk9UT05JQywg Jm5vd190cykpCisJCWJhcmZfcGVycm9yKCJDb3VsZCBub3QgZmluZCB0aW1l IChjbG9ja19nZXR0aW1lIGZhaWxlZCkiKTsKKworCXJldHVybiBub3dfdHMu dHZfc2VjICogMTAwMCArIG5vd190cy50dl9uc2VjIC8gMTAwMDAwMDsKK30K Kwogc3RhdGljIHZvaWQgZnJlZV9idWZmZXJlZF9kYXRhKHN0cnVjdCBidWZm ZXJlZF9kYXRhICpvdXQsCiAJCQkgICAgICAgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pCiB7CisJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKnJlcTsKKwogCWxp c3RfZGVsKCZvdXQtPmxpc3QpOworCisJLyoKKwkgKiBVcGRhdGUgY29ubi0+ dGltZW91dF9tc2VjIHdpdGggdGhlIG5leHQgZm91bmQgdGltZW91dCB2YWx1 ZSBpbiB0aGUKKwkgKiBxdWV1ZWQgcGVuZGluZyByZXF1ZXN0cy4KKwkgKi8K KwlpZiAob3V0LT50aW1lb3V0X21zZWMpIHsKKwkJY29ubi0+dGltZW91dF9t c2VjID0gMDsKKwkJbGlzdF9mb3JfZWFjaF9lbnRyeShyZXEsICZjb25uLT5v dXRfbGlzdCwgbGlzdCkgeworCQkJaWYgKHJlcS0+dGltZW91dF9tc2VjKSB7 CisJCQkJY29ubi0+dGltZW91dF9tc2VjID0gcmVxLT50aW1lb3V0X21zZWM7 CisJCQkJYnJlYWs7CisJCQl9CisJCX0KKwl9CisKIAl0YWxsb2NfZnJlZShv dXQpOwogfQogCitzdGF0aWMgdm9pZCBjaGVja19ldmVudF90aW1lb3V0KHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCB1aW50NjRfdCBtc2VjcywKKwkJCQlp bnQgKnB0aW1lb3V0KQoreworCXVpbnQ2NF90IGRlbHRhOworCXN0cnVjdCBi dWZmZXJlZF9kYXRhICpvdXQsICp0bXA7CisKKwlpZiAoIWNvbm4tPnRpbWVv dXRfbXNlYykKKwkJcmV0dXJuOworCisJZGVsdGEgPSBjb25uLT50aW1lb3V0 X21zZWMgLSBtc2VjczsKKwlpZiAoY29ubi0+dGltZW91dF9tc2VjIDw9IG1z ZWNzKSB7CisJCWRlbHRhID0gMDsKKwkJbGlzdF9mb3JfZWFjaF9lbnRyeV9z YWZlKG91dCwgdG1wLCAmY29ubi0+b3V0X2xpc3QsIGxpc3QpIHsKKwkJCS8q CisJCQkgKiBPbmx5IGxvb2sgYXQgYnVmZmVycyB3aXRoIHRpbWVvdXQgYW5k IG5vIGRhdGEKKwkJCSAqIGFscmVhZHkgd3JpdHRlbiB0byB0aGUgcmluZy4K KwkJCSAqLworCQkJaWYgKG91dC0+dGltZW91dF9tc2VjICYmIG91dC0+aW5o ZHIgJiYgIW91dC0+dXNlZCkgeworCQkJCWlmIChvdXQtPnRpbWVvdXRfbXNl YyA+IG1zZWNzKSB7CisJCQkJCWNvbm4tPnRpbWVvdXRfbXNlYyA9IG91dC0+ dGltZW91dF9tc2VjOworCQkJCQlkZWx0YSA9IGNvbm4tPnRpbWVvdXRfbXNl YyAtIG1zZWNzOworCQkJCQlicmVhazsKKwkJCQl9CisKKwkJCQkvKgorCQkJ CSAqIEZyZWUgb3V0IHdpdGhvdXQgdXBkYXRpbmcgY29ubi0+dGltZW91dF9t c2VjLAorCQkJCSAqIGFzIHRoZSB1cGRhdGUgaXMgZG9uZSBpbiB0aGlzIGxv b3AgYWxyZWFkeS4KKwkJCQkgKi8KKwkJCQlvdXQtPnRpbWVvdXRfbXNlYyA9 IDA7CisJCQkJdHJhY2UoIndhdGNoIGV2ZW50IHBhdGggJXMgZm9yIGRvbWFp biAldSB0aW1lZCBvdXRcbiIsCisJCQkJICAgICAgb3V0LT5idWZmZXIsIGNv bm4tPmlkKTsKKwkJCQlmcmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBjb25uKTsK KwkJCX0KKwkJfQorCQlpZiAoIWRlbHRhKSB7CisJCQljb25uLT50aW1lb3V0 X21zZWMgPSAwOworCQkJcmV0dXJuOworCQl9CisJfQorCisJaWYgKCpwdGlt ZW91dCA9PSAtMSB8fCAqcHRpbWVvdXQgPiBkZWx0YSkKKwkJKnB0aW1lb3V0 ID0gZGVsdGE7Cit9CisKIHZvaWQgY29ubl9mcmVlX2J1ZmZlcmVkX2RhdGEo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCiB7CiAJc3RydWN0IGJ1ZmZlcmVk X2RhdGEgKm91dDsKIAogCXdoaWxlICgob3V0ID0gbGlzdF90b3AoJmNvbm4t Pm91dF9saXN0LCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSwgbGlzdCkpKQogCQlm cmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBjb25uKTsKKworCWNvbm4tPnRpbWVv dXRfbXNlYyA9IDA7CiB9CiAKIHN0YXRpYyBib29sIHdyaXRlX21lc3NhZ2Vz KHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQpAQCAtMzMxLDYgKzQwNiw3IEBA IHN0YXRpYyB2b2lkIGluaXRpYWxpemVfZmRzKGludCBzb2NrLCBpbnQgKnBf c29ja19wb2xsZmRfaWR4LAogewogCXN0cnVjdCBjb25uZWN0aW9uICpjb25u OwogCXN0cnVjdCB3cmxfdGltZXN0YW1wdCBub3c7CisJdWludDY0X3QgbXNl Y3M7CiAKIAlpZiAoZmRzKQogCQltZW1zZXQoZmRzLCAwLCBzaXplb2Yoc3Ry dWN0IHBvbGxmZCkgKiBjdXJyZW50X2FycmF5X3NpemUpOwpAQCAtMzUyLDEw ICs0MjgsMTIgQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZV9mZHMoaW50IHNv Y2ssIGludCAqcF9zb2NrX3BvbGxmZF9pZHgsCiAKIAl3cmxfZ2V0dGltZV9u b3coJm5vdyk7CiAJd3JsX2xvZ19wZXJpb2RpYyhub3cpOworCW1zZWNzID0g Z2V0X25vd19tc2VjKCk7CiAKIAlsaXN0X2Zvcl9lYWNoX2VudHJ5KGNvbm4s ICZjb25uZWN0aW9ucywgbGlzdCkgewogCQlpZiAoY29ubi0+ZG9tYWluKSB7 CiAJCQl3cmxfY2hlY2tfdGltZW91dChjb25uLT5kb21haW4sIG5vdywgcHRp bWVvdXQpOworCQkJY2hlY2tfZXZlbnRfdGltZW91dChjb25uLCBtc2Vjcywg cHRpbWVvdXQpOwogCQkJaWYgKGRvbWFpbl9jYW5fcmVhZChjb25uKSB8fAog CQkJICAgIChkb21haW5fY2FuX3dyaXRlKGNvbm4pICYmCiAJCQkgICAgICFs aXN0X2VtcHR5KCZjb25uLT5vdXRfbGlzdCkpKQpAQCAtNjk5LDYgKzc3Nyw3 IEBAIHZvaWQgc2VuZF9yZXBseShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg ZW51bSB4c2Rfc29ja21zZ190eXBlIHR5cGUsCiAJCXJldHVybjsKIAliZGF0 YS0+aW5oZHIgPSB0cnVlOwogCWJkYXRhLT51c2VkID0gMDsKKwliZGF0YS0+ dGltZW91dF9tc2VjID0gMDsKIAogCWlmIChsZW4gPD0gREVGQVVMVF9CVUZG RVJfU0laRSkKIAkJYmRhdGEtPmJ1ZmZlciA9IGJkYXRhLT5kZWZhdWx0X2J1 ZmZlcjsKQEAgLTc1MCw2ICs4MjksMTIgQEAgdm9pZCBzZW5kX2V2ZW50KHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpwYXRoLCBjb25z dCBjaGFyICp0b2tlbikKIAliZGF0YS0+aGRyLm1zZy50eXBlID0gWFNfV0FU Q0hfRVZFTlQ7CiAJYmRhdGEtPmhkci5tc2cubGVuID0gbGVuOwogCisJaWYg KHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyAmJiBkb21haW5faXNfdW5wcml2 aWxlZ2VkKGNvbm4pKSB7CisJCWJkYXRhLT50aW1lb3V0X21zZWMgPSBnZXRf bm93X21zZWMoKSArIHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKKwkJaWYg KCFjb25uLT50aW1lb3V0X21zZWMpCisJCQljb25uLT50aW1lb3V0X21zZWMg PSBiZGF0YS0+dGltZW91dF9tc2VjOworCX0KKwogCS8qIFF1ZXVlIGZvciBs YXRlciB0cmFuc21pc3Npb24uICovCiAJbGlzdF9hZGRfdGFpbCgmYmRhdGEt Pmxpc3QsICZjb25uLT5vdXRfbGlzdCk7CiB9CkBAIC0yMDA5LDYgKzIwOTQs OSBAQCBzdGF0aWMgdm9pZCB1c2FnZSh2b2lkKQogIiAgLVcsIC0td2F0Y2gt bmIgPG5iPiAgICAgbGltaXQgdGhlIG51bWJlciBvZiB3YXRjaGVzIHBlciBk b21haW4sXG4iCiAiICAtdCwgLS10cmFuc2FjdGlvbiA8bmI+ICBsaW1pdCB0 aGUgbnVtYmVyIG9mIHRyYW5zYWN0aW9uIGFsbG93ZWQgcGVyIGRvbWFpbixc biIKICIgIC1BLCAtLXBlcm0tbmIgPG5iPiAgICAgIGxpbWl0IHRoZSBudW1i ZXIgb2YgcGVybWlzc2lvbnMgcGVyIG5vZGUsXG4iCisiICAtdywgLS10aW1l b3V0IDx3aGF0Pj08c2Vjb25kcz4gICBzZXQgdGhlIHRpbWVvdXQgaW4gc2Vj b25kcyBmb3IgPHdoYXQ+LFxuIgorIiAgICAgICAgICAgICAgICAgICAgICAg ICAgYWxsb3dlZCB0aW1lb3V0IGNhbmRpZGF0ZXMgYXJlOlxuIgorIiAgICAg ICAgICAgICAgICAgICAgICAgICAgd2F0Y2gtZXZlbnQ6IHRpbWUgYSB3YXRj aC1ldmVudCBpcyBrZXB0IHBlbmRpbmdcbiIKICIgIC1SLCAtLW5vLXJlY292 ZXJ5ICAgICAgIHRvIHJlcXVlc3QgdGhhdCBubyByZWNvdmVyeSBzaG91bGQg YmUgYXR0ZW1wdGVkIHdoZW5cbiIKICIgICAgICAgICAgICAgICAgICAgICAg ICAgIHRoZSBzdG9yZSBpcyBjb3JydXB0ZWQgKGRlYnVnIG9ubHkpLFxuIgog IiAgLUksIC0taW50ZXJuYWwtZGIgICAgICAgc3RvcmUgZGF0YWJhc2UgaW4g bWVtb3J5LCBub3Qgb24gZGlza1xuIgpAQCAtMjAzMCw2ICsyMTE4LDcgQEAg c3RhdGljIHN0cnVjdCBvcHRpb24gb3B0aW9uc1tdID0gewogCXsgInRyYWNl LWZpbGUiLCAxLCBOVUxMLCAnVCcgfSwKIAl7ICJ0cmFuc2FjdGlvbiIsIDEs IE5VTEwsICd0JyB9LAogCXsgInBlcm0tbmIiLCAxLCBOVUxMLCAnQScgfSwK Kwl7ICJ0aW1lb3V0IiwgMSwgTlVMTCwgJ3cnIH0sCiAJeyAibm8tcmVjb3Zl cnkiLCAwLCBOVUxMLCAnUicgfSwKIAl7ICJpbnRlcm5hbC1kYiIsIDAsIE5V TEwsICdJJyB9LAogCXsgInZlcmJvc2UiLCAwLCBOVUxMLCAnVicgfSwKQEAg LTIwNDEsNiArMjEzMCwzOSBAQCBpbnQgZG9tMF9kb21pZCA9IDA7CiBpbnQg ZG9tMF9ldmVudCA9IDA7CiBpbnQgcHJpdl9kb21pZCA9IDA7CiAKK3N0YXRp YyBpbnQgZ2V0X29wdHZhbF9pbnQoY29uc3QgY2hhciAqYXJnKQoreworCWNo YXIgKmVuZDsKKwlsb25nIHZhbDsKKworCXZhbCA9IHN0cnRvbChhcmcsICZl bmQsIDEwKTsKKwlpZiAoISphcmcgfHwgKmVuZCB8fCB2YWwgPCAwIHx8IHZh bCA+IElOVF9NQVgpCisJCWJhcmYoImludmFsaWQgcGFyYW1ldGVyIHZhbHVl IFwiJXNcIlxuIiwgYXJnKTsKKworCXJldHVybiB2YWw7Cit9CisKK3N0YXRp YyBib29sIHdoYXRfbWF0Y2hlcyhjb25zdCBjaGFyICphcmcsIGNvbnN0IGNo YXIgKndoYXQpCit7CisJdW5zaWduZWQgaW50IHdoYXRfbGVuID0gc3RybGVu KHdoYXQpOworCisJcmV0dXJuICFzdHJuY21wKGFyZywgd2hhdCwgd2hhdF9s ZW4pICYmIGFyZ1t3aGF0X2xlbl0gPT0gJz0nOworfQorCitzdGF0aWMgdm9p ZCBzZXRfdGltZW91dChjb25zdCBjaGFyICphcmcpCit7CisJY29uc3QgY2hh ciAqZXEgPSBzdHJjaHIoYXJnLCAnPScpOworCWludCB2YWw7CisKKwlpZiAo IWVxKQorCQliYXJmKCJxdW90YXMgbXVzdCBiZSBzcGVjaWZpZWQgdmlhIDx3 aGF0Pj08c2Vjb25kcz5cbiIpOworCXZhbCA9IGdldF9vcHR2YWxfaW50KGVx ICsgMSk7CisJaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJ3YXRjaC1ldmVudCIp KQorCQl0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWMgPSB2YWwgKiAxMDAwOwor CWVsc2UKKwkJYmFyZigidW5rbm93biB0aW1lb3V0IFwiJXNcIlxuIiwgYXJn KTsKK30KKwogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIHsK IAlpbnQgb3B0LCAqc29jayA9IE5VTEwsICpyb19zb2NrID0gTlVMTDsKQEAg LTIwNTIsNyArMjE3NCw3IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICph cmd2W10pCiAJaW50IHRpbWVvdXQ7CiAKIAotCXdoaWxlICgob3B0ID0gZ2V0 b3B0X2xvbmcoYXJnYywgYXJndiwgIkRFOkY6SE5QUzp0OkE6VDpSVlc6Iiwg b3B0aW9ucywKKwl3aGlsZSAoKG9wdCA9IGdldG9wdF9sb25nKGFyZ2MsIGFy Z3YsICJERTpGOkhOUFM6dDpBOlQ6UlZXOnc6Iiwgb3B0aW9ucywKIAkJCQkg IE5VTEwpKSAhPSAtMSkgewogCQlzd2l0Y2ggKG9wdCkgewogCQljYXNlICdE JzoKQEAgLTIwOTcsNiArMjIxOSw5IEBAIGludCBtYWluKGludCBhcmdjLCBj aGFyICphcmd2W10pCiAJCWNhc2UgJ0EnOgogCQkJcXVvdGFfbmJfcGVybXNf cGVyX25vZGUgPSBzdHJ0b2wob3B0YXJnLCBOVUxMLCAxMCk7CiAJCQlicmVh azsKKwkJY2FzZSAndyc6CisJCQlzZXRfdGltZW91dChvcHRhcmcpOworCQkJ YnJlYWs7CiAJCWNhc2UgJ2UnOgogCQkJZG9tMF9ldmVudCA9IHN0cnRvbChv cHRhcmcsIE5VTEwsIDEwKTsKIAkJCWJyZWFrOwpkaWZmIC0tZ2l0IGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmgKaW5kZXggODNkNDk2OTNmYzE5Li4zMTEyYzEx ODExZTUgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApA QCAtMjcsNiArMjcsNyBAQAogI2luY2x1ZGUgPGRpcmVudC5oPgogI2luY2x1 ZGUgPHN0ZGJvb2wuaD4KICNpbmNsdWRlIDxzdGRpbnQuaD4KKyNpbmNsdWRl IDx0aW1lLmg+CiAjaW5jbHVkZSA8ZXJybm8uaD4KIAogI2luY2x1ZGUgInhl bnN0b3JlX2xpYi5oIgpAQCAtNTYsNiArNTcsOCBAQCBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YQogCQljaGFyIHJhd1tzaXplb2Yoc3RydWN0IHhzZF9zb2NrbXNn KV07CiAJfSBoZHI7CiAKKwl1aW50NjRfdCB0aW1lb3V0X21zZWM7CisKIAkv KiBUaGUgYWN0dWFsIGRhdGEuICovCiAJY2hhciAqYnVmZmVyOwogCWNoYXIg ZGVmYXVsdF9idWZmZXJbREVGQVVMVF9CVUZGRVJfU0laRV07CkBAIC04OCw2 ICs5MSw3IEBAIHN0cnVjdCBjb25uZWN0aW9uCiAKIAkvKiBCdWZmZXJlZCBv dXRwdXQgZGF0YSAqLwogCXN0cnVjdCBsaXN0X2hlYWQgb3V0X2xpc3Q7CisJ dWludDY0X3QgdGltZW91dF9tc2VjOwogCiAJLyogVHJhbnNhY3Rpb24gY29u dGV4dCBmb3IgY3VycmVudCByZXF1ZXN0IChOVUxMIGlmIG5vbmUpLiAqLwog CXN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnNhY3Rpb247CkBAIC0xOTksNiAr MjAzLDggQEAgZXh0ZXJuIGludCBkb20wX2V2ZW50OwogZXh0ZXJuIGludCBw cml2X2RvbWlkOwogZXh0ZXJuIGludCBxdW90YV9uYl9lbnRyeV9wZXJfZG9t YWluOwogCitleHRlcm4gdW5zaWduZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZl bnRfbXNlYzsKKwogLyogTWFwIHRoZSBrZXJuZWwncyB4ZW5zdG9yZSBwYWdl LiAqLwogdm9pZCAqeGVuYnVzX21hcCh2b2lkKTsKIHZvaWQgdW5tYXBfeGVu YnVzKHZvaWQgKmludGVyZmFjZSk7Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-05.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-05.patch" Content-Transfer-Encoding: base64 RnJvbSBjM2UzOTdmMmQ3NzY0NTU4NGNjOTU1YzIyM2IyODk0YTQyMzllYTRj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxpbWl0IG91 dHN0YW5kaW5nIHJlcXVlc3RzCgpBZGQgYW5vdGhlciBxdW90YSBmb3IgbGlt aXRpbmcgdGhlIG51bWJlciBvZiBvdXRzdGFuZGluZyByZXF1ZXN0cyBvZiBh Cmd1ZXN0LiBBcyB0aGUgd2F5IHRvIHNwZWNpZnkgcXVvdGFzIG9uIHRoZSBj b21tYW5kIGxpbmUgaXMgYmVjb21pbmcKcmF0aGVyIG5hc3R5LCBzd2l0Y2gg dG8gYSBuZXcgc2NoZW1lIHVzaW5nIFstLXF1b3RhfC1RXSA8d2hhdD49PHZh bD4KYWxsb3dpbmcgdG8gYWRkIG1vcmUgcXVvdGFzIGluIGZ1dHVyZSBlYXNp bHkuCgpTZXQgdGhlIGRlZmF1bHQgdmFsdWUgdG8gMjAgKGJhc2ljYWxseSBh IHJhbmRvbSB2YWx1ZSBub3Qgc2VlbWluZyB0bwpiZSB0b28gaGlnaCBvciB0 b28gbG93KS4KCkEgcmVxdWVzdCBpcyBzYWlkIHRvIGJlIG91dHN0YW5kaW5n IGlmIGFueSBtZXNzYWdlIGdlbmVyYXRlZCBieSB0aGlzCnJlcXVlc3QgKHRo ZSBkaXJlY3QgcmVzcG9uc2UgcGx1cyBwb3RlbnRpYWwgd2F0Y2ggZXZlbnRz KSBpcyBub3QgeWV0CmNvbXBsZXRlbHkgc3RvcmVkIGludG8gYSByaW5nIGJ1 ZmZlci4gVGhlIGluaXRpYWwgd2F0Y2ggZXZlbnQgc2VudCBhcwphIHJlc3Vs dCBvZiByZWdpc3RlcmluZyBhIHdhdGNoIGlzIGFuIGV4Y2VwdGlvbi4KCk5v dGUgdGhhdCBhY3Jvc3MgYSBsaXZlIHVwZGF0ZSB0aGUgcmVsYXRpb24gdG8g YnVmZmVyZWQgd2F0Y2ggZXZlbnRzCmZvciBvdGhlciBkb21haW5zIGlzIGxv c3QuCgpVc2UgdGFsbG9jX3plcm8oKSBmb3IgYWxsb2NhdGluZyB0aGUgZG9t YWluIHN0cnVjdHVyZSBpbiBvcmRlciB0byBoYXZlCmFsbCBwZXItZG9tYWlu IHF1b3RhIHplcm9lZCBpbml0aWFsbHkuCgpUaGlzIGlzIHBhcnQgb2YgWFNB LTMyNiAvIENWRS0yMDIyLTQyMzEyLgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKaW5kZXggNWZiNDcxNGIzNTZmLi41ZjE3MzMxMTJh NGYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAt MTAyLDYgKzEwMiw3IEBAIGludCBxdW90YV9uYl93YXRjaF9wZXJfZG9tYWlu ID0gMTI4OwogaW50IHF1b3RhX21heF9lbnRyeV9zaXplID0gMjA0ODsgLyog MksgKi8KIGludCBxdW90YV9tYXhfdHJhbnNhY3Rpb24gPSAxMDsKIGludCBx dW90YV9uYl9wZXJtc19wZXJfbm9kZSA9IDU7CitpbnQgcXVvdGFfcmVxX291 dHN0YW5kaW5nID0gMjA7CiAKIHVuc2lnbmVkIGludCB0aW1lb3V0X3dhdGNo X2V2ZW50X21zZWMgPSAyMDAwMDsKIApAQCAtMjE3LDEyICsyMTgsMjQgQEAg c3RhdGljIHVpbnQ2NF90IGdldF9ub3dfbXNlYyh2b2lkKQogCXJldHVybiBu b3dfdHMudHZfc2VjICogMTAwMCArIG5vd190cy50dl9uc2VjIC8gMTAwMDAw MDsKIH0KIAorLyoKKyAqIFJlbW92ZSBhIHN0cnVjdCBidWZmZXJlZF9kYXRh IGZyb20gdGhlIGxpc3Qgb2Ygb3V0Z29pbmcgZGF0YS4KKyAqIEEgc3RydWN0 IGJ1ZmZlcmVkX2RhdGEgcmVsYXRlZCB0byBhIHJlcXVlc3QgaGF2aW5nIGNh dXNlZCB3YXRjaCBldmVudHMgdG8gYmUKKyAqIHNlbnQgaXMga2VwdCB1bnRp bCBhbGwgdGhvc2UgZXZlbnRzIGhhdmUgYmVlbiB3cml0dGVuIG91dC4KKyAq IEVhY2ggd2F0Y2ggZXZlbnQgaXMgcmVmZXJlbmNpbmcgdGhlIHJlbGF0ZWQg cmVxdWVzdCB2aWEgcGVuZC5yZXEsIHdoaWxlIHRoZQorICogbnVtYmVyIG9m IHdhdGNoIGV2ZW50cyBjYXVzZWQgYnkgYSByZXF1ZXN0IGlzIGtlcHQgaW4g cGVuZC5yZWYuZXZlbnRfY250CisgKiAodGhvc2UgdHdvIGNhc2VzIGFyZSBt dXR1YWxseSBleGNsdXNpdmUsIHNvIHRoZSB0d28gZmllbGRzIGNhbiBzaGFy ZSBtZW1vcnkKKyAqIHZpYSBhIHVuaW9uKS4KKyAqIFRoZSBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSBpcyBmcmVlZCBvbmx5IGlmIG5vIHJlbGF0ZWQgd2F0Y2gg ZXZlbnQgaXMKKyAqIHJlZmVyZW5jaW5nIGl0LiBUaGUgcmVsYXRlZCByZXR1 cm4gZGF0YSBjYW4gYmUgZnJlZWQgcmlnaHQgYXdheS4KKyAqLwogc3RhdGlj IHZvaWQgZnJlZV9idWZmZXJlZF9kYXRhKHN0cnVjdCBidWZmZXJlZF9kYXRh ICpvdXQsCiAJCQkgICAgICAgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCiB7 CiAJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKnJlcTsKIAogCWxpc3RfZGVsKCZv dXQtPmxpc3QpOworCW91dC0+b25fb3V0X2xpc3QgPSBmYWxzZTsKIAogCS8q CiAJICogVXBkYXRlIGNvbm4tPnRpbWVvdXRfbXNlYyB3aXRoIHRoZSBuZXh0 IGZvdW5kIHRpbWVvdXQgdmFsdWUgaW4gdGhlCkBAIC0yMzgsNiArMjUxLDMw IEBAIHN0YXRpYyB2b2lkIGZyZWVfYnVmZmVyZWRfZGF0YShzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqb3V0LAogCQl9CiAJfQogCisJaWYgKG91dC0+aGRyLm1z Zy50eXBlID09IFhTX1dBVENIX0VWRU5UKSB7CisJCXJlcSA9IG91dC0+cGVu ZC5yZXE7CisJCWlmIChyZXEpIHsKKwkJCXJlcS0+cGVuZC5yZWYuZXZlbnRf Y250LS07CisJCQlpZiAoIXJlcS0+cGVuZC5yZWYuZXZlbnRfY250ICYmICFy ZXEtPm9uX291dF9saXN0KSB7CisJCQkJaWYgKHJlcS0+b25fcmVmX2xpc3Qp IHsKKwkJCQkJZG9tYWluX291dHN0YW5kaW5nX2RvbWlkX2RlYygKKwkJCQkJ CXJlcS0+cGVuZC5yZWYuZG9taWQpOworCQkJCQlsaXN0X2RlbCgmcmVxLT5s aXN0KTsKKwkJCQl9CisJCQkJdGFsbG9jX2ZyZWUocmVxKTsKKwkJCX0KKwkJ fQorCX0gZWxzZSBpZiAob3V0LT5wZW5kLnJlZi5ldmVudF9jbnQpIHsKKwkJ LyogSGFuZyBvdXQgb2ZmIGZyb20gY29ubi4gKi8KKwkJdGFsbG9jX3N0ZWFs KE5VTEwsIG91dCk7CisJCWlmIChvdXQtPmJ1ZmZlciAhPSBvdXQtPmRlZmF1 bHRfYnVmZmVyKQorCQkJdGFsbG9jX2ZyZWUob3V0LT5idWZmZXIpOworCQls aXN0X2FkZCgmb3V0LT5saXN0LCAmY29ubi0+cmVmX2xpc3QpOworCQlvdXQt Pm9uX3JlZl9saXN0ID0gdHJ1ZTsKKwkJcmV0dXJuOworCX0gZWxzZQorCQlk b21haW5fb3V0c3RhbmRpbmdfZGVjKGNvbm4pOworCiAJdGFsbG9jX2ZyZWUo b3V0KTsKIH0KIApAQCAtMzQ2LDYgKzM4Myw3IEBAIHN0YXRpYyBib29sIHdy aXRlX21lc3NhZ2VzKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQogc3RhdGlj IGludCBkZXN0cm95X2Nvbm4odm9pZCAqX2Nvbm4pCiB7CiAJc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4gPSBfY29ubjsKKwlzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSAqcmVxOwogCiAJLyogRmx1c2ggb3V0Z29pbmcgaWYgcG9zc2libGUsIGJ1 dCBkb24ndCBibG9jay4gKi8KIAlpZiAoIWNvbm4tPmRvbWFpbikgewpAQCAt MzU5LDYgKzM5NywxMSBAQCBzdGF0aWMgaW50IGRlc3Ryb3lfY29ubih2b2lk ICpfY29ubikKIAkJCQlicmVhazsKIAkJY2xvc2UoY29ubi0+ZmQpOwogCX0K KworCWNvbm5fZnJlZV9idWZmZXJlZF9kYXRhKGNvbm4pOworCWxpc3RfZm9y X2VhY2hfZW50cnkocmVxLCAmY29ubi0+cmVmX2xpc3QsIGxpc3QpCisJCXJl cS0+b25fcmVmX2xpc3QgPSBmYWxzZTsKKwogICAgICAgICBpZiAoY29ubi0+ dGFyZ2V0KQogICAgICAgICAgICAgICAgIHRhbGxvY191bmxpbmsoY29ubiwg Y29ubi0+dGFyZ2V0KTsKIAlsaXN0X2RlbCgmY29ubi0+bGlzdCk7CkBAIC03 OTgsNiArODQxLDggQEAgdm9pZCBzZW5kX3JlcGx5KHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSwKIAogCS8q IFF1ZXVlIGZvciBsYXRlciB0cmFuc21pc3Npb24uICovCiAJbGlzdF9hZGRf dGFpbCgmYmRhdGEtPmxpc3QsICZjb25uLT5vdXRfbGlzdCk7CisJYmRhdGEt Pm9uX291dF9saXN0ID0gdHJ1ZTsKKwlkb21haW5fb3V0c3RhbmRpbmdfaW5j KGNvbm4pOwogfQogCiAvKgpAQCAtODA1LDcgKzg1MCw4IEBAIHZvaWQgc2Vu ZF9yZXBseShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgZW51bSB4c2Rfc29j a21zZ190eXBlIHR5cGUsCiAgKiBBcyB0aGlzIGlzIG5vdCBkaXJlY3RseSBy ZWxhdGVkIHRvIHRoZSBjdXJyZW50IGNvbW1hbmQsIGVycm9ycyBjYW4ndCBi ZQogICogcmVwb3J0ZWQuCiAgKi8KLXZvaWQgc2VuZF9ldmVudChzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgY29uc3QgY2hhciAqcGF0aCwgY29uc3QgY2hh ciAqdG9rZW4pCit2b2lkIHNlbmRfZXZlbnQoc3RydWN0IGJ1ZmZlcmVkX2Rh dGEgKnJlcSwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCWNvbnN0IGNo YXIgKnBhdGgsIGNvbnN0IGNoYXIgKnRva2VuKQogewogCXN0cnVjdCBidWZm ZXJlZF9kYXRhICpiZGF0YTsKIAl1bnNpZ25lZCBpbnQgbGVuOwpAQCAtODM1 LDggKzg4MSwxMyBAQCB2b2lkIHNlbmRfZXZlbnQoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIGNvbnN0IGNoYXIgKnBhdGgsIGNvbnN0IGNoYXIgKnRva2Vu KQogCQkJY29ubi0+dGltZW91dF9tc2VjID0gYmRhdGEtPnRpbWVvdXRfbXNl YzsKIAl9CiAKKwliZGF0YS0+cGVuZC5yZXEgPSByZXE7CisJaWYgKHJlcSkK KwkJcmVxLT5wZW5kLnJlZi5ldmVudF9jbnQrKzsKKwogCS8qIFF1ZXVlIGZv ciBsYXRlciB0cmFuc21pc3Npb24uICovCiAJbGlzdF9hZGRfdGFpbCgmYmRh dGEtPmxpc3QsICZjb25uLT5vdXRfbGlzdCk7CisJYmRhdGEtPm9uX291dF9s aXN0ID0gdHJ1ZTsKIH0KIAogLyogU29tZSByb3V0aW5lcyAod3JpdGUsIG1r ZGlyLCBldGMpIGp1c3QgbmVlZCBhIG5vbi1lcnJvciByZXR1cm4gKi8KQEAg LTE1NzIsNiArMTYyMyw3IEBAIHN0YXRpYyB2b2lkIGhhbmRsZV9pbnB1dChz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubikKIAkJCXJldHVybjsKIAl9CiAJaW4g PSBjb25uLT5pbjsKKwlpbi0+cGVuZC5yZWYuZG9taWQgPSBjb25uLT5pZDsK IAogCS8qIE5vdCBmaW5pc2hlZCBoZWFkZXIgeWV0PyAqLwogCWlmIChpbi0+ aW5oZHIpIHsKQEAgLTE2NDIsNiArMTY5NCw3IEBAIHN0cnVjdCBjb25uZWN0 aW9uICpuZXdfY29ubmVjdGlvbihjb25ud3JpdGVmbl90ICp3cml0ZSwgY29u bnJlYWRmbl90ICpyZWFkKQogCW5ldy0+aXNfaWdub3JlZCA9IGZhbHNlOwog CW5ldy0+dHJhbnNhY3Rpb25fc3RhcnRlZCA9IDA7CiAJSU5JVF9MSVNUX0hF QUQoJm5ldy0+b3V0X2xpc3QpOworCUlOSVRfTElTVF9IRUFEKCZuZXctPnJl Zl9saXN0KTsKIAlJTklUX0xJU1RfSEVBRCgmbmV3LT53YXRjaGVzKTsKIAlJ TklUX0xJU1RfSEVBRCgmbmV3LT50cmFuc2FjdGlvbl9saXN0KTsKIApAQCAt MjA5NCw2ICsyMTQ3LDkgQEAgc3RhdGljIHZvaWQgdXNhZ2Uodm9pZCkKICIg IC1XLCAtLXdhdGNoLW5iIDxuYj4gICAgIGxpbWl0IHRoZSBudW1iZXIgb2Yg d2F0Y2hlcyBwZXIgZG9tYWluLFxuIgogIiAgLXQsIC0tdHJhbnNhY3Rpb24g PG5iPiAgbGltaXQgdGhlIG51bWJlciBvZiB0cmFuc2FjdGlvbiBhbGxvd2Vk IHBlciBkb21haW4sXG4iCiAiICAtQSwgLS1wZXJtLW5iIDxuYj4gICAgICBs aW1pdCB0aGUgbnVtYmVyIG9mIHBlcm1pc3Npb25zIHBlciBub2RlLFxuIgor IiAgLVEsIC0tcXVvdGEgPHdoYXQ+PTxuYj4gc2V0IHRoZSBxdW90YSA8d2hh dD4gdG8gdGhlIHZhbHVlIDxuYj4sIGFsbG93ZWRcbiIKKyIgICAgICAgICAg ICAgICAgICAgICAgICAgIHF1b3RhcyBhcmU6XG4iCisiICAgICAgICAgICAg ICAgICAgICAgICAgICBvdXRzdGFuZGluZzogbnVtYmVyIG9mIG91dHN0YW5k aW5nIHJlcXVlc3RzXG4iCiAiICAtdywgLS10aW1lb3V0IDx3aGF0Pj08c2Vj b25kcz4gICBzZXQgdGhlIHRpbWVvdXQgaW4gc2Vjb25kcyBmb3IgPHdoYXQ+ LFxuIgogIiAgICAgICAgICAgICAgICAgICAgICAgICAgYWxsb3dlZCB0aW1l b3V0IGNhbmRpZGF0ZXMgYXJlOlxuIgogIiAgICAgICAgICAgICAgICAgICAg ICAgICAgd2F0Y2gtZXZlbnQ6IHRpbWUgYSB3YXRjaC1ldmVudCBpcyBrZXB0 IHBlbmRpbmdcbiIKQEAgLTIxMTgsNiArMjE3NCw3IEBAIHN0YXRpYyBzdHJ1 Y3Qgb3B0aW9uIG9wdGlvbnNbXSA9IHsKIAl7ICJ0cmFjZS1maWxlIiwgMSwg TlVMTCwgJ1QnIH0sCiAJeyAidHJhbnNhY3Rpb24iLCAxLCBOVUxMLCAndCcg fSwKIAl7ICJwZXJtLW5iIiwgMSwgTlVMTCwgJ0EnIH0sCisJeyAicXVvdGEi LCAxLCBOVUxMLCAnUScgfSwKIAl7ICJ0aW1lb3V0IiwgMSwgTlVMTCwgJ3cn IH0sCiAJeyAibm8tcmVjb3ZlcnkiLCAwLCBOVUxMLCAnUicgfSwKIAl7ICJp bnRlcm5hbC1kYiIsIDAsIE5VTEwsICdJJyB9LApAQCAtMjE2Myw2ICsyMjIw LDIwIEBAIHN0YXRpYyB2b2lkIHNldF90aW1lb3V0KGNvbnN0IGNoYXIgKmFy ZykKIAkJYmFyZigidW5rbm93biB0aW1lb3V0IFwiJXNcIlxuIiwgYXJnKTsK IH0KIAorc3RhdGljIHZvaWQgc2V0X3F1b3RhKGNvbnN0IGNoYXIgKmFyZykK K3sKKwljb25zdCBjaGFyICplcSA9IHN0cmNocihhcmcsICc9Jyk7CisJaW50 IHZhbDsKKworCWlmICghZXEpCisJCWJhcmYoInF1b3RhcyBtdXN0IGJlIHNw ZWNpZmllZCB2aWEgPHdoYXQ+PTxuYj5cbiIpOworCXZhbCA9IGdldF9vcHR2 YWxfaW50KGVxICsgMSk7CisJaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJvdXRz dGFuZGluZyIpKQorCQlxdW90YV9yZXFfb3V0c3RhbmRpbmcgPSB2YWw7CisJ ZWxzZQorCQliYXJmKCJ1bmtub3duIHF1b3RhIFwiJXNcIlxuIiwgYXJnKTsK K30KKwogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIHsKIAlp bnQgb3B0LCAqc29jayA9IE5VTEwsICpyb19zb2NrID0gTlVMTDsKQEAgLTIx NzQsNyArMjI0NSw3IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2 W10pCiAJaW50IHRpbWVvdXQ7CiAKIAotCXdoaWxlICgob3B0ID0gZ2V0b3B0 X2xvbmcoYXJnYywgYXJndiwgIkRFOkY6SE5QUzp0OkE6VDpSVlc6dzoiLCBv cHRpb25zLAorCXdoaWxlICgob3B0ID0gZ2V0b3B0X2xvbmcoYXJnYywgYXJn diwgIkRFOkY6SE5QUzp0OkE6UTpUOlJWVzp3OiIsIG9wdGlvbnMsCiAJCQkJ ICBOVUxMKSkgIT0gLTEpIHsKIAkJc3dpdGNoIChvcHQpIHsKIAkJY2FzZSAn RCc6CkBAIC0yMjE5LDYgKzIyOTAsOSBAQCBpbnQgbWFpbihpbnQgYXJnYywg Y2hhciAqYXJndltdKQogCQljYXNlICdBJzoKIAkJCXF1b3RhX25iX3Blcm1z X3Blcl9ub2RlID0gc3RydG9sKG9wdGFyZywgTlVMTCwgMTApOwogCQkJYnJl YWs7CisJCWNhc2UgJ1EnOgorCQkJc2V0X3F1b3RhKG9wdGFyZyk7CisJCQli cmVhazsKIAkJY2FzZSAndyc6CiAJCQlzZXRfdGltZW91dChvcHRhcmcpOwog CQkJYnJlYWs7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApp bmRleCAzMTEyYzExODExZTUuLmVkZWFhOTZkZDEwYiAxMDA2NDQKLS0tIGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAorKysgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCkBAIC00NSw2ICs0NSw4IEBAIHR5 cGVkZWYgaW50MzJfdCB3cmxfY3JlZGl0dDsKIHN0cnVjdCBidWZmZXJlZF9k YXRhCiB7CiAJc3RydWN0IGxpc3RfaGVhZCBsaXN0OworCWJvb2wgb25fb3V0 X2xpc3Q7CisJYm9vbCBvbl9yZWZfbGlzdDsKIAogCS8qIEFyZSB3ZSBzdGls bCBkb2luZyB0aGUgaGVhZGVyPyAqLwogCWJvb2wgaW5oZHI7CkBAIC01Miw2 ICs1NCwxNyBAQCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YQogCS8qIEhvdyBmYXIg YXJlIHdlPyAqLwogCXVuc2lnbmVkIGludCB1c2VkOwogCisJLyogT3V0c3Rh bmRpbmcgcmVxdWVzdCBhY2NvdW50aW5nLiAqLworCXVuaW9uIHsKKwkJLyog cmVmIGlzIGJlaW5nIHVzZWQgZm9yIHJlcXVlc3RzLiAqLworCQlzdHJ1Y3Qg eworCQkJdW5zaWduZWQgaW50IGV2ZW50X2NudDsgLyogIyBvZiBvdXRzdGFu ZGluZyBldmVudHMuICovCisJCQl1bnNpZ25lZCBpbnQgZG9taWQ7ICAgICAv KiBkb21pZCBvZiByZXF1ZXN0LiAqLworCQl9IHJlZjsKKwkJLyogcmVxIGlz IGJlaW5nIHVzZWQgZm9yIHdhdGNoIGV2ZW50cy4gKi8KKwkJc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKnJlcTsgICAgICAvKiByZXF1ZXN0IGNhdXNpbmcgZXZl bnQuICovCisJfSBwZW5kOworCiAJdW5pb24gewogCQlzdHJ1Y3QgeHNkX3Nv Y2ttc2cgbXNnOwogCQljaGFyIHJhd1tzaXplb2Yoc3RydWN0IHhzZF9zb2Nr bXNnKV07CkBAIC05Myw2ICsxMDYsOSBAQCBzdHJ1Y3QgY29ubmVjdGlvbgog CXN0cnVjdCBsaXN0X2hlYWQgb3V0X2xpc3Q7CiAJdWludDY0X3QgdGltZW91 dF9tc2VjOwogCisJLyogUmVmZXJlbmNlZCByZXF1ZXN0cyBubyBsb25nZXIg cGVuZGluZy4gKi8KKwlzdHJ1Y3QgbGlzdF9oZWFkIHJlZl9saXN0OworCiAJ LyogVHJhbnNhY3Rpb24gY29udGV4dCBmb3IgY3VycmVudCByZXF1ZXN0IChO VUxMIGlmIG5vbmUpLiAqLwogCXN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnNh Y3Rpb247CiAKQEAgLTE1NCw3ICsxNzAsOCBAQCB1bnNpZ25lZCBpbnQgZ2V0 X3N0cmluZ3Moc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmRhdGEsCiAKIHZvaWQg c2VuZF9yZXBseShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgZW51bSB4c2Rf c29ja21zZ190eXBlIHR5cGUsCiAJCWNvbnN0IHZvaWQgKmRhdGEsIHVuc2ln bmVkIGludCBsZW4pOwotdm9pZCBzZW5kX2V2ZW50KHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBjb25zdCBjaGFyICpwYXRoLCBjb25zdCBjaGFyICp0b2tl bik7Cit2b2lkIHNlbmRfZXZlbnQoc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKnJl cSwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCWNvbnN0IGNoYXIgKnBh dGgsIGNvbnN0IGNoYXIgKnRva2VuKTsKIAogLyogU29tZSByb3V0aW5lcyAo d3JpdGUsIG1rZGlyLCBldGMpIGp1c3QgbmVlZCBhIG5vbi1lcnJvciByZXR1 cm4gKi8KIHZvaWQgc2VuZF9hY2soc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlKTsKQEAgLTIwMiw2ICsyMTks NyBAQCBleHRlcm4gaW50IGRvbTBfZG9taWQ7CiBleHRlcm4gaW50IGRvbTBf ZXZlbnQ7CiBleHRlcm4gaW50IHByaXZfZG9taWQ7CiBleHRlcm4gaW50IHF1 b3RhX25iX2VudHJ5X3Blcl9kb21haW47CitleHRlcm4gaW50IHF1b3RhX3Jl cV9vdXRzdGFuZGluZzsKIAogZXh0ZXJuIHVuc2lnbmVkIGludCB0aW1lb3V0 X3dhdGNoX2V2ZW50X21zZWM7CiAKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9kb21haW4uYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9kb21haW4uYwppbmRleCA0MTZiOTJjYWQ0YjIuLjU4YjdlMGZlMmZh NyAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFp bi5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYwpA QCAtODYsNiArODYsOSBAQCBzdHJ1Y3QgZG9tYWluCiAJLyogbnVtYmVyIG9m IHdhdGNoIGZvciB0aGlzIGRvbWFpbiAqLwogCWludCBuYndhdGNoOwogCisJ LyogTnVtYmVyIG9mIG91dHN0YW5kaW5nIHJlcXVlc3RzLiAqLworCWludCBu Ym91dHN0YW5kaW5nOworCiAJLyogd3JpdGUgcmF0ZSBsaW1pdCAqLwogCXdy bF9jcmVkaXR0IHdybF9jcmVkaXQ7IC8qIFsgLXdybF9jb25maWdfd3JpdGVj b3N0LCArX2RidXJzdCBdICovCiAJc3RydWN0IHdybF90aW1lc3RhbXB0IHdy bF90aW1lc3RhbXA7CkBAIC0yODgsOCArMjkxLDEyIEBAIGJvb2wgZG9tYWlu X2Nhbl9yZWFkKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQogewogCXN0cnVj dCB4ZW5zdG9yZV9kb21haW5faW50ZXJmYWNlICppbnRmID0gY29ubi0+ZG9t YWluLT5pbnRlcmZhY2U7CiAKLQlpZiAoZG9tYWluX2lzX3VucHJpdmlsZWdl ZChjb25uKSAmJiBjb25uLT5kb21haW4tPndybF9jcmVkaXQgPCAwKQotCQly ZXR1cm4gZmFsc2U7CisJaWYgKGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29u bikpIHsKKwkJaWYgKGNvbm4tPmRvbWFpbi0+d3JsX2NyZWRpdCA8IDApCisJ CQlyZXR1cm4gZmFsc2U7CisJCWlmIChjb25uLT5kb21haW4tPm5ib3V0c3Rh bmRpbmcgPj0gcXVvdGFfcmVxX291dHN0YW5kaW5nKQorCQkJcmV0dXJuIGZh bHNlOworCX0KIAogCWlmIChjb25uLT5pc19pZ25vcmVkKQogCQlyZXR1cm4g ZmFsc2U7CkBAIC0zMzgsNyArMzQ1LDcgQEAgc3RhdGljIHN0cnVjdCBkb21h aW4gKmFsbG9jX2RvbWFpbih2b2lkICpjb250ZXh0LCB1bnNpZ25lZCBpbnQg ZG9taWQpCiB7CiAJc3RydWN0IGRvbWFpbiAqZG9tYWluOwogCi0JZG9tYWlu ID0gdGFsbG9jKGNvbnRleHQsIHN0cnVjdCBkb21haW4pOworCWRvbWFpbiA9 IHRhbGxvY196ZXJvKGNvbnRleHQsIHN0cnVjdCBkb21haW4pOwogCWlmICgh ZG9tYWluKSB7CiAJCWVycm5vID0gRU5PTUVNOwogCQlyZXR1cm4gTlVMTDsK QEAgLTM4Nyw4ICszOTQsNiBAQCBzdGF0aWMgaW50IG5ld19kb21haW4oc3Ry dWN0IGRvbWFpbiAqZG9tYWluLCBpbnQgcG9ydCkKIAlkb21haW4tPmNvbm4t PmlkID0gZG9tYWluLT5kb21pZDsKIAogCWRvbWFpbi0+cmVtb3RlX3BvcnQg PSBwb3J0OwotCWRvbWFpbi0+bmJlbnRyeSA9IDA7Ci0JZG9tYWluLT5uYndh dGNoID0gMDsKIAogCXJldHVybiAwOwogfQpAQCAtOTI5LDYgKzkzNCwyOCBA QCBpbnQgZG9tYWluX3dhdGNoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQog CQk6IDA7CiB9CiAKK3ZvaWQgZG9tYWluX291dHN0YW5kaW5nX2luYyhzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubikKK3sKKwlpZiAoIWNvbm4gfHwgIWNvbm4t PmRvbWFpbikKKwkJcmV0dXJuOworCWNvbm4tPmRvbWFpbi0+bmJvdXRzdGFu ZGluZysrOworfQorCit2b2lkIGRvbWFpbl9vdXRzdGFuZGluZ19kZWMoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4pCit7CisJaWYgKCFjb25uIHx8ICFjb25u LT5kb21haW4pCisJCXJldHVybjsKKwljb25uLT5kb21haW4tPm5ib3V0c3Rh bmRpbmctLTsKK30KKwordm9pZCBkb21haW5fb3V0c3RhbmRpbmdfZG9taWRf ZGVjKHVuc2lnbmVkIGludCBkb21pZCkKK3sKKwlzdHJ1Y3QgZG9tYWluICpk ID0gZmluZF9kb21haW5fYnlfZG9taWQoZG9taWQpOworCisJaWYgKGQpCisJ CWQtPm5ib3V0c3RhbmRpbmctLTsKK30KKwogc3RhdGljIHdybF9jcmVkaXR0 IHdybF9jb25maWdfd3JpdGVjb3N0ICAgICAgPSBXUkxfRkFDVE9SOwogc3Rh dGljIHdybF9jcmVkaXR0IHdybF9jb25maWdfcmF0ZSAgICAgICAgICAgPSBX UkxfUkFURSAgICogV1JMX0ZBQ1RPUjsKIHN0YXRpYyB3cmxfY3JlZGl0dCB3 cmxfY29uZmlnX2RidXJzdCAgICAgICAgID0gV1JMX0RCVVJTVCAqIFdSTF9G QUNUT1I7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgK aW5kZXggNWUwMDA4NzIwNmM3Li40YmZmMmU2NTViOWIgMTAwNjQ0Ci0tLSBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaAorKysgYi90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgKQEAgLTY3LDYgKzY3LDkg QEAgaW50IGRvbWFpbl9lbnRyeShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7 CiB2b2lkIGRvbWFpbl93YXRjaF9pbmMoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4pOwogdm9pZCBkb21haW5fd2F0Y2hfZGVjKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uKTsKIGludCBkb21haW5fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pOwordm9pZCBkb21haW5fb3V0c3RhbmRpbmdfaW5jKHN0cnVjdCBj b25uZWN0aW9uICpjb25uKTsKK3ZvaWQgZG9tYWluX291dHN0YW5kaW5nX2Rl YyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7Cit2b2lkIGRvbWFpbl9vdXRz dGFuZGluZ19kb21pZF9kZWModW5zaWduZWQgaW50IGRvbWlkKTsKIAogLyog U3BlY2lhbCBub2RlIHBlcm1pc3Npb24gaGFuZGxpbmcuICovCiBpbnQgc2V0 X3Blcm1zX3NwZWNpYWwoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0 IGNoYXIgKm5hbWUsCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfd2F0Y2guYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRj aC5jCmluZGV4IDJmOTM2Nzc2N2U0NC4uYzUwYzA1NzVmMGYxIDEwMDY0NAot LS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYworKysgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYwpAQCAtMTQyLDYgKzE0 Miw3IEBAIHZvaWQgZmlyZV93YXRjaGVzKHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCBjb25zdCB2b2lkICpjdHgsIGNvbnN0IGNoYXIgKm5hbWUsCiAJCSAg c3RydWN0IG5vZGUgKm5vZGUsIGJvb2wgZXhhY3QsIHN0cnVjdCBub2RlX3Bl cm1zICpwZXJtcykKIHsKIAlzdHJ1Y3QgY29ubmVjdGlvbiAqaTsKKwlzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqcmVxOwogCXN0cnVjdCB3YXRjaCAqd2F0Y2g7 CiAKIAkvKiBEdXJpbmcgdHJhbnNhY3Rpb25zLCBkb24ndCBmaXJlIHdhdGNo ZXMsIGJ1dCBxdWV1ZSB0aGVtLiAqLwpAQCAtMTUwLDYgKzE1MSw4IEBAIHZv aWQgZmlyZV93YXRjaGVzKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25z dCB2b2lkICpjdHgsIGNvbnN0IGNoYXIgKm5hbWUsCiAJCXJldHVybjsKIAl9 CiAKKwlyZXEgPSBkb21haW5faXNfdW5wcml2aWxlZ2VkKGNvbm4pID8gY29u bi0+aW4gOiBOVUxMOworCiAJLyogQ3JlYXRlIGFuIGV2ZW50IGZvciBlYWNo IHdhdGNoLiAqLwogCWxpc3RfZm9yX2VhY2hfZW50cnkoaSwgJmNvbm5lY3Rp b25zLCBsaXN0KSB7CiAJCS8qIGludHJvZHVjZS9yZWxlYXNlIGRvbWFpbiB3 YXRjaGVzICovCkBAIC0xNjQsMTIgKzE2NywxMiBAQCB2b2lkIGZpcmVfd2F0 Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4 LCBjb25zdCBjaGFyICpuYW1lLAogCQlsaXN0X2Zvcl9lYWNoX2VudHJ5KHdh dGNoLCAmaS0+d2F0Y2hlcywgbGlzdCkgewogCQkJaWYgKGV4YWN0KSB7CiAJ CQkJaWYgKHN0cmVxKG5hbWUsIHdhdGNoLT5ub2RlKSkKLQkJCQkJc2VuZF9l dmVudChpLAorCQkJCQlzZW5kX2V2ZW50KHJlcSwgaSwKIAkJCQkJCSAgIGdl dF93YXRjaF9wYXRoKHdhdGNoLCBuYW1lKSwKIAkJCQkJCSAgIHdhdGNoLT50 b2tlbik7CiAJCQl9IGVsc2UgewogCQkJCWlmIChpc19jaGlsZChuYW1lLCB3 YXRjaC0+bm9kZSkpCi0JCQkJCXNlbmRfZXZlbnQoaSwKKwkJCQkJc2VuZF9l dmVudChyZXEsIGksCiAJCQkJCQkgICBnZXRfd2F0Y2hfcGF0aCh3YXRjaCwg bmFtZSksCiAJCQkJCQkgICB3YXRjaC0+dG9rZW4pOwogCQkJfQpAQCAtMjM4 LDggKzI0MSwxMiBAQCBpbnQgZG9fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAl0YWxsb2Nfc2V0 X2Rlc3RydWN0b3Iod2F0Y2gsIGRlc3Ryb3lfd2F0Y2gpOwogCXNlbmRfYWNr KGNvbm4sIFhTX1dBVENIKTsKIAotCS8qIFdlIGZpcmUgb25jZSB1cCBmcm9u dDogc2ltcGxpZmllcyBjbGllbnRzIGFuZCByZXN0YXJ0LiAqLwotCXNlbmRf ZXZlbnQoY29ubiwgZ2V0X3dhdGNoX3BhdGgod2F0Y2gsIHdhdGNoLT5ub2Rl KSwgd2F0Y2gtPnRva2VuKTsKKwkvKgorCSAqIFdlIGZpcmUgb25jZSB1cCBm cm9udDogc2ltcGxpZmllcyBjbGllbnRzIGFuZCByZXN0YXJ0LgorCSAqIFRo aXMgZXZlbnQgd2lsbCBub3QgYmUgbGlua2VkIHRvIHRoZSBYU19XQVRDSCBy ZXF1ZXN0LgorCSAqLworCXNlbmRfZXZlbnQoTlVMTCwgY29ubiwgZ2V0X3dh dGNoX3BhdGgod2F0Y2gsIHdhdGNoLT5ub2RlKSwKKwkJICAgd2F0Y2gtPnRv a2VuKTsKIAogCXJldHVybiAwOwogfQo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-06.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-06.patch" Content-Transfer-Encoding: base64 RnJvbSA1YzE4YWU1ZWQ5NmZkNjJmNDYyYjRiZTlhOTUwMjJmMTQzZjZkZWU0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGRvbid0IGJ1 ZmZlciBtdWx0aXBsZSBpZGVudGljYWwgd2F0Y2ggZXZlbnRzCgpBIGd1ZXN0 IG5vdCByZWFkaW5nIGl0cyBYZW5zdG9yZSByZXNwb25zZSBidWZmZXIgZmFz dCBlbm91Z2ggbWlnaHQKcGlsZSB1cCBsb3RzIG9mIFhlbnN0b3JlIHdhdGNo IGV2ZW50cyBidWZmZXJlZC4gUmVkdWNlIHRoZSBnZW5lcmF0ZWQKbG9hZCBi eSBkcm9wcGluZyBuZXcgZXZlbnRzIHdoaWNoIGFscmVhZHkgaGF2ZSBhbiBp ZGVudGljYWwgY29weQpwZW5kaW5nLgoKVGhlIHNwZWNpYWwgZXZlbnRzICJA Li4uIiBhcmUgZXhjbHVkZWQgZnJvbSB0aGF0IGhhbmRsaW5nIGFzIHRoZXJl IGFyZQprbm93biB1c2UgY2FzZXMgd2hlcmUgdGhlIGhhbmRsZXIgaXMgcmVs eWluZyBvbiBlYWNoIGV2ZW50IHRvIGJlIHNlbnQKaW5kaXZpZHVhbGx5LgoK VGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRlZC1ieTogSnVsaWVu IEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVs aWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuYwppbmRleCA1ZjE3MzMxMTJhNGYuLjA2MjEw MjNiY2ExNiAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2NvcmUuYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5j CkBAIC04MjEsNiArODIxLDcgQEAgdm9pZCBzZW5kX3JlcGx5KHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSwK IAliZGF0YS0+aW5oZHIgPSB0cnVlOwogCWJkYXRhLT51c2VkID0gMDsKIAli ZGF0YS0+dGltZW91dF9tc2VjID0gMDsKKwliZGF0YS0+d2F0Y2hfZXZlbnQg PSBmYWxzZTsKIAogCWlmIChsZW4gPD0gREVGQVVMVF9CVUZGRVJfU0laRSkK IAkJYmRhdGEtPmJ1ZmZlciA9IGJkYXRhLT5kZWZhdWx0X2J1ZmZlcjsKQEAg LTg1Myw3ICs4NTQsNyBAQCB2b2lkIHNlbmRfcmVwbHkoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlLAogdm9p ZCBzZW5kX2V2ZW50KHN0cnVjdCBidWZmZXJlZF9kYXRhICpyZXEsIHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAogCQljb25zdCBjaGFyICpwYXRoLCBjb25z dCBjaGFyICp0b2tlbikKIHsKLQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRh dGE7CisJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmJkYXRhLCAqYmQ7CiAJdW5z aWduZWQgaW50IGxlbjsKIAogCWxlbiA9IHN0cmxlbihwYXRoKSArIDEgKyBz dHJsZW4odG9rZW4pICsgMTsKQEAgLTg3NSwxMiArODc2LDI5IEBAIHZvaWQg c2VuZF9ldmVudChzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqcmVxLCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKIAliZGF0YS0+aGRyLm1zZy50eXBlID0gWFNf V0FUQ0hfRVZFTlQ7CiAJYmRhdGEtPmhkci5tc2cubGVuID0gbGVuOwogCisJ LyoKKwkgKiBDaGVjayB3aGV0aGVyIGFuIGlkZW50aWNhbCBldmVudCBpcyBw ZW5kaW5nIGFscmVhZHkuCisJICogU3BlY2lhbCBldmVudHMgYXJlIGV4Y2x1 ZGVkIGZyb20gdGhhdCBjaGVjay4KKwkgKi8KKwlpZiAocGF0aFswXSAhPSAn QCcpIHsKKwkJbGlzdF9mb3JfZWFjaF9lbnRyeShiZCwgJmNvbm4tPm91dF9s aXN0LCBsaXN0KSB7CisJCQlpZiAoYmQtPndhdGNoX2V2ZW50ICYmIGJkLT5o ZHIubXNnLmxlbiA9PSBsZW4gJiYKKwkJCSAgICAhbWVtY21wKGJkYXRhLT5i dWZmZXIsIGJkLT5idWZmZXIsIGxlbikpIHsKKwkJCQl0cmFjZSgiZHJvcHBp bmcgZHVwbGljYXRlIHdhdGNoICVzICVzIGZvciBkb21haW4gJXVcbiIsCisJ CQkJICAgICAgcGF0aCwgdG9rZW4sIGNvbm4tPmlkKTsKKwkJCQl0YWxsb2Nf ZnJlZShiZGF0YSk7CisJCQkJcmV0dXJuOworCQkJfQorCQl9CisJfQorCiAJ aWYgKHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyAmJiBkb21haW5faXNfdW5w cml2aWxlZ2VkKGNvbm4pKSB7CiAJCWJkYXRhLT50aW1lb3V0X21zZWMgPSBn ZXRfbm93X21zZWMoKSArIHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIAkJ aWYgKCFjb25uLT50aW1lb3V0X21zZWMpCiAJCQljb25uLT50aW1lb3V0X21z ZWMgPSBiZGF0YS0+dGltZW91dF9tc2VjOwogCX0KIAorCWJkYXRhLT53YXRj aF9ldmVudCA9IHRydWU7CiAJYmRhdGEtPnBlbmQucmVxID0gcmVxOwogCWlm IChyZXEpCiAJCXJlcS0+cGVuZC5yZWYuZXZlbnRfY250Kys7CmRpZmYgLS1n aXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCBlZGVhYTk2ZGQxMGIu LjFlYjYxMzFmYzg4ZCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5oCkBAIC01MSw2ICs1MSw5IEBAIHN0cnVjdCBidWZmZXJlZF9kYXRh CiAJLyogQXJlIHdlIHN0aWxsIGRvaW5nIHRoZSBoZWFkZXI/ICovCiAJYm9v bCBpbmhkcjsKIAorCS8qIElzIHRoaXMgYSB3YXRjaCBldmVudD8gKi8KKwli b29sIHdhdGNoX2V2ZW50OworCiAJLyogSG93IGZhciBhcmUgd2U/ICovCiAJ dW5zaWduZWQgaW50IHVzZWQ7CiAK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-07.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-07.patch" Content-Transfer-Encoding: base64 RnJvbSA2NjVhNmFlN2E0ZWIzOTc3NTY0YTZmMDBjOTE3NThmOTg4ZTM1YmU4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGZpeCBjb25u ZWN0aW9uLT5pZCB1c2FnZQoKRG9uJ3QgdXNlIGNvbm4tPmlkIGZvciBwcml2 aWxlZ2UgY2hlY2tzLCBidXQgZG9tYWluX2lzX3VucHJpdmlsZWdlZCgpLgoK VGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRlZC1ieTogSnVsaWVu IEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVs aWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuYwppbmRleCBlNGI4YWE5NWFiZmQu LmQzMjcyZTJlZjliNSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvbnRyb2wuYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29udHJvbC5jCkBAIC0xODAsNyArMTgwLDcgQEAgaW50IGRvX2NvbnRy b2woc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbikKIAlpbnQgY21kOwogCWNoYXIgKip2ZWM7CiAKLQlpZiAoY29u bi0+aWQgIT0gMCkKKwlpZiAoZG9tYWluX2lzX3VucHJpdmlsZWdlZChjb25u KSkKIAkJcmV0dXJuIEVBQ0NFUzsKIAogCW51bSA9IHhzX2NvdW50X3N0cmlu Z3MoaW4tPmJ1ZmZlciwgaW4tPnVzZWQpOwpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmgKaW5kZXggMWViNjEzMWZjODhkLi45OGRiNGFmY2Fh YmYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAt OTMsNyArOTMsNyBAQCBzdHJ1Y3QgY29ubmVjdGlvbgogCS8qIFRoZSBpbmRl eCBvZiBwb2xsZmQgaW4gZ2xvYmFsIHBvbGxmZCBhcnJheSAqLwogCWludCBw b2xsZmRfaWR4OwogCi0JLyogV2hvIGFtIEk/IDAgZm9yIHNvY2tldCBjb25u ZWN0aW9ucy4gKi8KKwkvKiBXaG8gYW0gST8gRG9taWQgb2YgY29ubmVjdGlv bi4gKi8KIAl1bnNpZ25lZCBpbnQgaWQ7CiAKIAkvKiBJcyB0aGlzIGEgcmVh ZC1vbmx5IGNvbm5lY3Rpb24/ICovCmRpZmYgLS1naXQgYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4IDZmYmRiMjlkY2RkNy4u OWJlZjZlNzJhNTY2IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfdHJhbnNhY3Rpb24uYwpAQCAtNDgzLDcgKzQ4Myw4IEBAIGludCBk b190cmFuc2FjdGlvbl9zdGFydChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg c3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCWlmIChjb25uLT50cmFuc2Fj dGlvbikKIAkJcmV0dXJuIEVCVVNZOwogCi0JaWYgKGNvbm4tPmlkICYmIGNv bm4tPnRyYW5zYWN0aW9uX3N0YXJ0ZWQgPiBxdW90YV9tYXhfdHJhbnNhY3Rp b24pCisJaWYgKGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikgJiYKKwkg ICAgY29ubi0+dHJhbnNhY3Rpb25fc3RhcnRlZCA+IHF1b3RhX21heF90cmFu c2FjdGlvbikKIAkJcmV0dXJuIEVOT1NQQzsKIAogCS8qIEF0dGFjaCB0cmFu c2FjdGlvbiB0byBpbnB1dCBmb3IgYXV0b2ZyZWUgdW50aWwgaXQncyBjb21w bGV0ZSAqLwo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-08.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-08.patch" Content-Transfer-Encoding: base64 RnJvbSBiZmRhYjM5NWIwODk5M2M2YmRhN2M1NDZkNmQxOTMyZDdjYWI4ODM0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHNpbXBsaWZ5 IGFuZCBmaXggcGVyIGRvbWFpbiBub2RlIGFjY291bnRpbmcKClRoZSBhY2Nv dW50aW5nIG9mIG5vZGVzIGNhbiBiZSBzaW1wbGlmaWVkIG5vdyB0aGF0IGVh Y2ggY29ubmVjdGlvbgpob2xkcyB0aGUgYXNzb2NpYXRlZCBkb21pZC4KCkZp eCB0aGUgbm9kZSBhY2NvdW50aW5nIHRvIGNvdmVyIG5vZGVzIGNyZWF0ZWQg Zm9yIGEgZG9tYWluIGJlZm9yZSBpdApoYXMgYmVlbiBpbnRyb2R1Y2VkLiBU aGlzIHJlcXVpcmVzIHRvIHJlYWN0IHByb3Blcmx5IHRvIGFuIGFsbG9jYXRp b24KZmFpbHVyZSBpbnNpZGUgZG9tYWluX2VudHJ5X2luYygpIGJ5IHJldHVy bmluZyBhbiBlcnJvciBjb2RlLgoKRXNwZWNpYWxseSBpbiBlcnJvciBwYXRo cyB0aGUgbm9kZSBhY2NvdW50aW5nIGhhcyB0byBiZSBmaXhlZCBpbiBzb21l CmNhc2VzLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYgLyBDVkUtMjAyMi00 MjMxMy4KClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6 b24uY29tPgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NA c3VzZS5jb20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBh bWF6b24uY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb250cm9sLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29u dHJvbC5jCmluZGV4IGQzMjcyZTJlZjliNS4uNzE1ZTBkMmE5ZTAzIDEwMDY0 NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jCisr KyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmMKQEAgLTI1 LDYgKzI1LDcgQEAKICNpbmNsdWRlICJ0YWxsb2MuaCIKICNpbmNsdWRlICJ4 ZW5zdG9yZWRfY29yZS5oIgogI2luY2x1ZGUgInhlbnN0b3JlZF9jb250cm9s LmgiCisjaW5jbHVkZSAieGVuc3RvcmVkX2RvbWFpbi5oIgogCiBzdHJ1Y3Qg Y21kX3MgewogCWNoYXIgKmNtZDsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5jCmluZGV4IDA2MjEwMjNiY2ExNi4uOThkMjQyZTA2MjQxIDEw MDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisr KyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTU0Myw3 ICs1NDMsNyBAQCBzdHJ1Y3Qgbm9kZSAqcmVhZF9ub2RlKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsCiAKIAkvKiBQZXJtaXNz aW9ucyBhcmUgc3RydWN0IHhzX3Blcm1pc3Npb25zLiAqLwogCW5vZGUtPnBl cm1zLnAgPSBoZHItPnBlcm1zOwotCWlmIChkb21haW5fYWRqdXN0X25vZGVf cGVybXMobm9kZSkpIHsKKwlpZiAoZG9tYWluX2FkanVzdF9ub2RlX3Blcm1z KGNvbm4sIG5vZGUpKSB7CiAJCXRhbGxvY19mcmVlKG5vZGUpOwogCQlyZXR1 cm4gTlVMTDsKIAl9CkBAIC01NjUsNyArNTY1LDcgQEAgaW50IHdyaXRlX25v ZGVfcmF3KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5 LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIAl2b2lkICpwOwogCXN0cnVjdCB4c190 ZGJfcmVjb3JkX2hkciAqaGRyOwogCi0JaWYgKGRvbWFpbl9hZGp1c3Rfbm9k ZV9wZXJtcyhub2RlKSkKKwlpZiAoZG9tYWluX2FkanVzdF9ub2RlX3Blcm1z KGNvbm4sIG5vZGUpKQogCQlyZXR1cm4gZXJybm87CiAKIAlkYXRhLmRzaXpl ID0gc2l6ZW9mKCpoZHIpCkBAIC0xMTU5LDEzICsxMTU5LDE3IEBAIHN0YXRp YyBzdHJ1Y3Qgbm9kZSAqY29uc3RydWN0X25vZGUoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAlyZXR1cm4gTlVMTDsKIH0K IAotc3RhdGljIGludCBkZXN0cm95X25vZGUoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQorc3RhdGljIHZvaWQgZGVzdHJv eV9ub2RlX3JtKHN0cnVjdCBub2RlICpub2RlKQogewogCWlmIChzdHJlcShu b2RlLT5uYW1lLCAiLyIpKQogCQljb3JydXB0KE5VTEwsICJEZXN0cm95aW5n IHJvb3Qgbm9kZSEiKTsKIAogCXRkYl9kZWxldGUodGRiX2N0eCwgbm9kZS0+ a2V5KTsKK30KIAorc3RhdGljIGludCBkZXN0cm95X25vZGUoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQoreworCWRlc3Ry b3lfbm9kZV9ybShub2RlKTsKIAlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5v ZGUpOwogCiAJLyoKQEAgLTEyMTUsOCArMTIxOSwxMiBAQCBzdGF0aWMgc3Ry dWN0IG5vZGUgKmNyZWF0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25u LCBjb25zdCB2b2lkICpjdHgsCiAJCQlnb3RvIGVycjsKIAogCQkvKiBBY2Nv dW50IGZvciBuZXcgbm9kZSAqLwotCQlpZiAoaS0+cGFyZW50KQotCQkJZG9t YWluX2VudHJ5X2luYyhjb25uLCBpKTsKKwkJaWYgKGktPnBhcmVudCkgewor CQkJaWYgKGRvbWFpbl9lbnRyeV9pbmMoY29ubiwgaSkpIHsKKwkJCQlkZXN0 cm95X25vZGVfcm0oaSk7CisJCQkJcmV0dXJuIE5VTEw7CisJCQl9CisJCX0K IAl9CiAKIAlyZXR1cm4gbm9kZTsKQEAgLTE0OTcsMTAgKzE1MDUsMjcgQEAg c3RhdGljIGludCBkb19zZXRfcGVybXMoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlvbGRfcGVybXMgPSBu b2RlLT5wZXJtczsKIAlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5vZGUpOwog CW5vZGUtPnBlcm1zID0gcGVybXM7Ci0JZG9tYWluX2VudHJ5X2luYyhjb25u LCBub2RlKTsKKwlpZiAoZG9tYWluX2VudHJ5X2luYyhjb25uLCBub2RlKSkg eworCQlub2RlLT5wZXJtcyA9IG9sZF9wZXJtczsKKwkJLyoKKwkJICogVGhp cyBzaG91bGQgbmV2ZXIgZmFpbCBiZWNhdXNlIHdlIGhhZCBhIHJlZmVyZW5j ZSBvbiB0aGUKKwkJICogZG9tYWluIGJlZm9yZSBhbmQgWGVuc3RvcmVkIGlz IHNpbmdsZS10aHJlYWRlZC4KKwkJICovCisJCWRvbWFpbl9lbnRyeV9pbmMo Y29ubiwgbm9kZSk7CisJCXJldHVybiBFTk9NRU07CisJfQogCi0JaWYgKHdy aXRlX25vZGUoY29ubiwgbm9kZSwgZmFsc2UpKQorCWlmICh3cml0ZV9ub2Rl KGNvbm4sIG5vZGUsIGZhbHNlKSkgeworCQlpbnQgc2F2ZWRfZXJybm8gPSBl cnJubzsKKworCQlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5vZGUpOworCQlu b2RlLT5wZXJtcyA9IG9sZF9wZXJtczsKKwkJLyogTm8gZmFpbHVyZSBwb3Nz aWJsZSBhcyBhYm92ZS4gKi8KKwkJZG9tYWluX2VudHJ5X2luYyhjb25uLCBu b2RlKTsKKworCQllcnJubyA9IHNhdmVkX2Vycm5vOwogCQlyZXR1cm4gZXJy bm87CisJfQogCiAJZmlyZV93YXRjaGVzKGNvbm4sIGluLCBuYW1lLCBub2Rl LCBmYWxzZSwgJm9sZF9wZXJtcyk7CiAJc2VuZF9hY2soY29ubiwgWFNfU0VU X1BFUk1TKTsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9kb21haW4uYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4u YwppbmRleCA1OGI3ZTBmZTJmYTcuLmY0MTM0ZGIzZTczYSAxMDA2NDQKLS0t IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCisrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYwpAQCAtMTYsNiArMTYs NyBAQAogICAgIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtOyBJZiBub3QsIHNl ZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCiAqLwogCisjaW5j bHVkZSA8YXNzZXJ0Lmg+CiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNsdWRl IDxzeXMvbW1hbi5oPgogI2luY2x1ZGUgPHVuaXN0ZC5oPgpAQCAtMzYyLDYg KzM2MywxOCBAQCBzdGF0aWMgc3RydWN0IGRvbWFpbiAqYWxsb2NfZG9tYWlu KHZvaWQgKmNvbnRleHQsIHVuc2lnbmVkIGludCBkb21pZCkKIAlyZXR1cm4g ZG9tYWluOwogfQogCitzdGF0aWMgc3RydWN0IGRvbWFpbiAqZmluZF9vcl9h bGxvY19leGlzdGluZ19kb21haW4odW5zaWduZWQgaW50IGRvbWlkKQorewor CXN0cnVjdCBkb21haW4gKmRvbWFpbjsKKwl4Y19kb21pbmZvX3QgZG9taW5m bzsKKworCWRvbWFpbiA9IGZpbmRfZG9tYWluX3N0cnVjdChkb21pZCk7CisJ aWYgKCFkb21haW4gJiYgZ2V0X2RvbWFpbl9pbmZvKGRvbWlkLCAmZG9taW5m bykpCisJCWRvbWFpbiA9IGFsbG9jX2RvbWFpbihOVUxMLCBkb21pZCk7CisK KwlyZXR1cm4gZG9tYWluOworfQorCiBzdGF0aWMgaW50IG5ld19kb21haW4o c3RydWN0IGRvbWFpbiAqZG9tYWluLCBpbnQgcG9ydCkKIHsKIAlpbnQgcmM7 CkBAIC03NzQsMzAgKzc4NywyOCBAQCB2b2lkIGRvbWFpbl9pbml0KHZvaWQp CiAJdmlycV9wb3J0ID0gcmM7CiB9CiAKLXZvaWQgZG9tYWluX2VudHJ5X2lu YyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKm5vZGUp CitpbnQgZG9tYWluX2VudHJ5X2luYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgc3RydWN0IG5vZGUgKm5vZGUpCiB7CiAJc3RydWN0IGRvbWFpbiAqZDsK Kwl1bnNpZ25lZCBpbnQgZG9taWQ7CiAKIAlpZiAoIWNvbm4pCi0JCXJldHVy bjsKKwkJcmV0dXJuIDA7CiAKLQlpZiAobm9kZS0+cGVybXMucCAmJiBub2Rl LT5wZXJtcy5wWzBdLmlkICE9IGNvbm4tPmlkKSB7Ci0JCWlmIChjb25uLT50 cmFuc2FjdGlvbikgewotCQkJdHJhbnNhY3Rpb25fZW50cnlfaW5jKGNvbm4t PnRyYW5zYWN0aW9uLAotCQkJCW5vZGUtPnBlcm1zLnBbMF0uaWQpOwotCQl9 IGVsc2UgewotCQkJZCA9IGZpbmRfZG9tYWluX2J5X2RvbWlkKG5vZGUtPnBl cm1zLnBbMF0uaWQpOwotCQkJaWYgKGQpCi0JCQkJZC0+bmJlbnRyeSsrOwot CQl9Ci0JfSBlbHNlIGlmIChjb25uLT5kb21haW4pIHsKLQkJaWYgKGNvbm4t PnRyYW5zYWN0aW9uKSB7Ci0JCQl0cmFuc2FjdGlvbl9lbnRyeV9pbmMoY29u bi0+dHJhbnNhY3Rpb24sCi0JCQkJY29ubi0+ZG9tYWluLT5kb21pZCk7Ci0g CQl9IGVsc2UgewotIAkJCWNvbm4tPmRvbWFpbi0+bmJlbnRyeSsrOwotCQl9 CisJZG9taWQgPSBub2RlLT5wZXJtcy5wID8gbm9kZS0+cGVybXMucFswXS5p ZCA6IGNvbm4tPmlkOworCisJaWYgKGNvbm4tPnRyYW5zYWN0aW9uKSB7CisJ CXRyYW5zYWN0aW9uX2VudHJ5X2luYyhjb25uLT50cmFuc2FjdGlvbiwgZG9t aWQpOworCX0gZWxzZSB7CisJCWQgPSAoZG9taWQgPT0gY29ubi0+aWQgJiYg Y29ubi0+ZG9tYWluKSA/IGNvbm4tPmRvbWFpbgorCQkgICAgOiBmaW5kX29y X2FsbG9jX2V4aXN0aW5nX2RvbWFpbihkb21pZCk7CisJCWlmIChkKQorCQkJ ZC0+bmJlbnRyeSsrOworCQllbHNlCisJCQlyZXR1cm4gRU5PTUVNOwogCX0K KworCXJldHVybiAwOwogfQogCiAvKgpAQCAtODMzLDcgKzg0NCw3IEBAIHN0 YXRpYyBpbnQgY2hrX2RvbWFpbl9nZW5lcmF0aW9uKHVuc2lnbmVkIGludCBk b21pZCwgdWludDY0X3QgZ2VuKQogICogUmVtb3ZlIHBlcm1pc3Npb25zIGZv ciBubyBsb25nZXIgZXhpc3RpbmcgZG9tYWlucyBpbiBvcmRlciB0byBhdm9p ZCBhIG5ldwogICogZG9tYWluIHdpdGggdGhlIHNhbWUgZG9taWQgaW5oZXJp dGluZyB0aGUgcGVybWlzc2lvbnMuCiAgKi8KLWludCBkb21haW5fYWRqdXN0 X25vZGVfcGVybXMoc3RydWN0IG5vZGUgKm5vZGUpCitpbnQgZG9tYWluX2Fk anVzdF9ub2RlX3Blcm1zKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1 Y3Qgbm9kZSAqbm9kZSkKIHsKIAl1bnNpZ25lZCBpbnQgaTsKIAlpbnQgcmV0 OwpAQCAtODQzLDggKzg1NCwxNCBAQCBpbnQgZG9tYWluX2FkanVzdF9ub2Rl X3Blcm1zKHN0cnVjdCBub2RlICpub2RlKQogCQlyZXR1cm4gZXJybm87CiAK IAkvKiBJZiB0aGUgb3duZXIgZG9lc24ndCBleGlzdCBhbnkgbG9uZ2VyIGdp dmUgaXQgdG8gcHJpdiBkb21haW4uICovCi0JaWYgKCFyZXQpCisJaWYgKCFy ZXQpIHsKKwkJLyoKKwkJICogSW4gdGhlb3J5IHdlJ2QgbmVlZCB0byB1cGRh dGUgdGhlIG51bWJlciBvZiBkb20wIG5vZGVzIGhlcmUsCisJCSAqIGJ1dCB3 ZSBjb3VsZCBiZSBjYWxsZWQgZm9yIGEgcmVhZCBvZiB0aGUgbm9kZS4gU28g YmV0dGVyCisJCSAqIGF2b2lkIHRoZSByaXNrIHRvIG92ZXJmbG93IHRoZSBu b2RlIGNvdW50IG9mIGRvbTAuCisJCSAqLwogCQlub2RlLT5wZXJtcy5wWzBd LmlkID0gcHJpdl9kb21pZDsKKwl9CiAKIAlmb3IgKGkgPSAxOyBpIDwgbm9k ZS0+cGVybXMubnVtOyBpKyspIHsKIAkJaWYgKG5vZGUtPnBlcm1zLnBbaV0u cGVybXMgJiBYU19QRVJNX0lHTk9SRSkKQEAgLTg2MywyNSArODgwLDI1IEBA IGludCBkb21haW5fYWRqdXN0X25vZGVfcGVybXMoc3RydWN0IG5vZGUgKm5v ZGUpCiB2b2lkIGRvbWFpbl9lbnRyeV9kZWMoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQogewogCXN0cnVjdCBkb21haW4g KmQ7CisJdW5zaWduZWQgaW50IGRvbWlkOwogCiAJaWYgKCFjb25uKQogCQly ZXR1cm47CiAKLQlpZiAobm9kZS0+cGVybXMucCAmJiBub2RlLT5wZXJtcy5w WzBdLmlkICE9IGNvbm4tPmlkKSB7Ci0JCWlmIChjb25uLT50cmFuc2FjdGlv bikgewotCQkJdHJhbnNhY3Rpb25fZW50cnlfZGVjKGNvbm4tPnRyYW5zYWN0 aW9uLAotCQkJCW5vZGUtPnBlcm1zLnBbMF0uaWQpOwotCQl9IGVsc2Ugewot CQkJZCA9IGZpbmRfZG9tYWluX2J5X2RvbWlkKG5vZGUtPnBlcm1zLnBbMF0u aWQpOwotCQkJaWYgKGQgJiYgZC0+bmJlbnRyeSkKLQkJCQlkLT5uYmVudHJ5 LS07Ci0JCX0KLQl9IGVsc2UgaWYgKGNvbm4tPmRvbWFpbiAmJiBjb25uLT5k b21haW4tPm5iZW50cnkpIHsKLQkJaWYgKGNvbm4tPnRyYW5zYWN0aW9uKSB7 Ci0JCQl0cmFuc2FjdGlvbl9lbnRyeV9kZWMoY29ubi0+dHJhbnNhY3Rpb24s Ci0JCQkJY29ubi0+ZG9tYWluLT5kb21pZCk7CisJZG9taWQgPSBub2RlLT5w ZXJtcy5wID8gbm9kZS0+cGVybXMucFswXS5pZCA6IGNvbm4tPmlkOworCisJ aWYgKGNvbm4tPnRyYW5zYWN0aW9uKSB7CisJCXRyYW5zYWN0aW9uX2VudHJ5 X2RlYyhjb25uLT50cmFuc2FjdGlvbiwgZG9taWQpOworCX0gZWxzZSB7CisJ CWQgPSAoZG9taWQgPT0gY29ubi0+aWQgJiYgY29ubi0+ZG9tYWluKSA/IGNv bm4tPmRvbWFpbgorCQkgICAgOiBmaW5kX2RvbWFpbl9zdHJ1Y3QoZG9taWQp OworCQlpZiAoZCkgeworCQkJZC0+bmJlbnRyeS0tOwogCQl9IGVsc2Ugewot CQkJY29ubi0+ZG9tYWluLT5uYmVudHJ5LS07CisJCQllcnJubyA9IEVOT0VO VDsKKwkJCWNvcnJ1cHQoY29ubiwKKwkJCQkiTm9kZSBcIiVzXCIgb3duZWQg Ynkgbm9uLWV4aXN0aW5nIGRvbWFpbiAldVxuIiwKKwkJCQlub2RlLT5uYW1l LCBkb21pZCk7CiAJCX0KIAl9CiB9CkBAIC04OTEsMTMgKzkwOCwyMyBAQCBp bnQgZG9tYWluX2VudHJ5X2ZpeCh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBu dW0sIGJvb2wgdXBkYXRlKQogCXN0cnVjdCBkb21haW4gKmQ7CiAJaW50IGNu dDsKIAotCWQgPSBmaW5kX2RvbWFpbl9ieV9kb21pZChkb21pZCk7Ci0JaWYg KCFkKQotCQlyZXR1cm4gMDsKKwlpZiAodXBkYXRlKSB7CisJCWQgPSBmaW5k X2RvbWFpbl9zdHJ1Y3QoZG9taWQpOworCQlhc3NlcnQoZCk7CisJfSBlbHNl IHsKKwkJLyoKKwkJICogV2UgYXJlIGNhbGxlZCBmaXJzdCB3aXRoIHVwZGF0 ZSA9PSBmYWxzZSBpbiBvcmRlciB0byBjYXRjaAorCQkgKiBhbnkgZXJyb3Iu IFNvIGRvIGEgcG9zc2libGUgYWxsb2NhdGlvbiBhbmQgY2hlY2sgZm9yIGVy cm9yCisJCSAqIG9ubHkgaW4gdGhpcyBjYXNlLCBhcyBpbiB0aGUgY2FzZSBv ZiB1cGRhdGUgPT0gdHJ1ZSBub3RoaW5nCisJCSAqIGNhbiBnbyB3cm9uZyBh bnltb3JlIGFzIHRoZSBhbGxvY2F0aW9uIGFscmVhZHkgaGFwcGVuZWQuCisJ CSAqLworCQlkID0gZmluZF9vcl9hbGxvY19leGlzdGluZ19kb21haW4oZG9t aWQpOworCQlpZiAoIWQpCisJCQlyZXR1cm4gLTE7CisJfQogCiAJY250ID0g ZC0+bmJlbnRyeSArIG51bTsKLQlpZiAoY250IDwgMCkKLQkJY250ID0gMDsK Kwlhc3NlcnQoY250ID49IDApOwogCiAJaWYgKHVwZGF0ZSkKIAkJZC0+bmJl bnRyeSA9IGNudDsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9kb21haW4uaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21h aW4uaAppbmRleCA0YmZmMmU2NTViOWIuLjRlZGYxZGJhOTQyNSAxMDA2NDQK LS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oCisrKyBi L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaApAQCAtNTcsMTAg KzU3LDEwIEBAIGJvb2wgZG9tYWluX2Nhbl93cml0ZShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubik7CiBib29sIGRvbWFpbl9pc191bnByaXZpbGVnZWQoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4pOwogCiAvKiBSZW1vdmUgbm9kZSBwZXJt aXNzaW9ucyBmb3Igbm8gbG9uZ2VyIGV4aXN0aW5nIGRvbWFpbnMuICovCi1p bnQgZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKHN0cnVjdCBub2RlICpub2Rl KTsKK2ludCBkb21haW5fYWRqdXN0X25vZGVfcGVybXMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlKTsKIAogLyogUXVvdGEg bWFuaXB1bGF0aW9uICovCi12b2lkIGRvbWFpbl9lbnRyeV9pbmMoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICopOworaW50IGRvbWFp bl9lbnRyeV9pbmMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICopOwogdm9pZCBkb21haW5fZW50cnlfZGVjKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqKTsKIGludCBkb21haW5fZW50cnlf Zml4KHVuc2lnbmVkIGludCBkb21pZCwgaW50IG51bSwgYm9vbCB1cGRhdGUp OwogaW50IGRvbWFpbl9lbnRyeShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7 CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNh Y3Rpb24uYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlv bi5jCmluZGV4IDliZWY2ZTcyYTU2Ni4uYmYyZmRhODIzNGIzIDEwMDY0NAot LS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwor KysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpA QCAtNTIzLDggKzUyMywxMiBAQCBzdGF0aWMgaW50IHRyYW5zYWN0aW9uX2Zp eF9kb21haW5zKHN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnMsIGJvb2wgdXBk YXRlKQogCiAJbGlzdF9mb3JfZWFjaF9lbnRyeShkLCAmdHJhbnMtPmNoYW5n ZWRfZG9tYWlucywgbGlzdCkgewogCQljbnQgPSBkb21haW5fZW50cnlfZml4 KGQtPmRvbWlkLCBkLT5uYmVudHJ5LCB1cGRhdGUpOwotCQlpZiAoIXVwZGF0 ZSAmJiBjbnQgPj0gcXVvdGFfbmJfZW50cnlfcGVyX2RvbWFpbikKLQkJCXJl dHVybiBFTk9TUEM7CisJCWlmICghdXBkYXRlKSB7CisJCQlpZiAoY250ID49 IHF1b3RhX25iX2VudHJ5X3Blcl9kb21haW4pCisJCQkJcmV0dXJuIEVOT1NQ QzsKKwkJCWlmIChjbnQgPCAwKQorCQkJCXJldHVybiBFTk9NRU07CisJCX0K IAl9CiAKIAlyZXR1cm4gMDsK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-09.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-09.patch" Content-Transfer-Encoding: base64 RnJvbSA3ZDMxM2Y0MzIyZTQ0NDI1ODgyYjIxNzY0YmM5YzQyYTc5MGQwMzBh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxpbWl0IG1h eCBudW1iZXIgb2Ygbm9kZXMgYWNjZXNzZWQgaW4gYSB0cmFuc2FjdGlvbgoK VG9kYXkgYSBndWVzdCBpcyBmcmVlIHRvIGFjY2VzcyBhcyBtYW55IG5vZGVz IGluIGEgc2luZ2xlIHRyYW5zYWN0aW9uCmFzIGl0IHdhbnRzLiBUaGlzIGNh biBsZWFkIHRvIHVuYm91bmRlZCBtZW1vcnkgY29uc3VtcHRpb24gaW4gWGVu c3RvcmUKYXMgdGhlcmUgaXMgdGhlIG5lZWQgdG8ga2VlcCB0cmFjayBvZiBh bGwgbm9kZXMgaGF2aW5nIGJlZW4gYWNjZXNzZWQKZHVyaW5nIGEgdHJhbnNh Y3Rpb24uCgpJbiBveGVuc3RvcmVkIHRoZSBudW1iZXIgb2YgcmVxdWVzdHMg aW4gYSB0cmFuc2FjdGlvbiBpcyBiZWluZyBsaW1pdGVkCnZpYSBhIHF1b3Rh IG1heHJlcXVlc3RzIChkZWZhdWx0IGlzIDEwMjQpLiBBcyBtdWx0aXBsZSBh Y2Nlc3NlcyBvZiBhCm5vZGUgYXJlIG5vdCBwcm9ibGVtYXRpYyBpbiBDIFhl bnN0b3JlLCBsaW1pdCB0aGUgbnVtYmVyIG9mIGFjY2Vzc2VkCm5vZGVzLgoK SW4gb3JkZXIgdG8gbGV0IHJlYWRfbm9kZSgpIGRldGVjdCBhIHF1b3RhIGVy cm9yIGluIGNhc2UgdG9vIG1hbnkgbm9kZXMKYXJlIGJlaW5nIGFjY2Vzc2Vk LCBjaGVjayB0aGUgcmV0dXJuIHZhbHVlIG9mIGFjY2Vzc19ub2RlKCkgYW5k IHJldHVybgpOVUxMIGluIGNhc2UgYW4gZXJyb3IgaGFzIGJlZW4gc2Vlbi4g SW50cm9kdWNlIF9fbXVzdF9jaGVjayBhbmQgYWRkIGl0CnRvIHRoZSBhY2Nl c3Nfbm9kZSgpIHByb3RvdHlwZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2 IC8gQ1ZFLTIwMjItNDIzMTQuCgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxs IDxqZ3JhbGxAYW1hem9uLmNvbT4KU3VnZ2VzdGVkLWJ5OiBKdWxpZW4gR3Jh bGwgPGp1bGllbkB4ZW4ub3JnPgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdy b3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3Jh bGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL2lu Y2x1ZGUveGVuLXRvb2xzL2xpYnMuaCBiL3Rvb2xzL2luY2x1ZGUveGVuLXRv b2xzL2xpYnMuaAppbmRleCBjYzdkZmM4YzY0NTMuLjM0ZGIzYjc4NDczMiAx MDA2NDQKLS0tIGEvdG9vbHMvaW5jbHVkZS94ZW4tdG9vbHMvbGlicy5oCisr KyBiL3Rvb2xzL2luY2x1ZGUveGVuLXRvb2xzL2xpYnMuaApAQCAtNTksNCAr NTksOCBAQAogICAgIH0pCiAjZW5kaWYKIAorI2lmbmRlZiBfX211c3RfY2hl Y2sKKyNkZWZpbmUgX19tdXN0X2NoZWNrIF9fYXR0cmlidXRlX18oKF9fd2Fy bl91bnVzZWRfcmVzdWx0X18pKQorI2VuZGlmCisKICNlbmRpZgkvKiBfX1hF Tl9UT09MU19MSUJTX18gKi8KZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5jCmluZGV4IDk4ZDI0MmUwNjI0MS4uNTdjOTk5MTI5MjE1IDEwMDY0 NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBi L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTEwMiw2ICsx MDIsNyBAQCBpbnQgcXVvdGFfbmJfd2F0Y2hfcGVyX2RvbWFpbiA9IDEyODsK IGludCBxdW90YV9tYXhfZW50cnlfc2l6ZSA9IDIwNDg7IC8qIDJLICovCiBp bnQgcXVvdGFfbWF4X3RyYW5zYWN0aW9uID0gMTA7CiBpbnQgcXVvdGFfbmJf cGVybXNfcGVyX25vZGUgPSA1OworaW50IHF1b3RhX3RyYW5zX25vZGVzID0g MTAyNDsKIGludCBxdW90YV9yZXFfb3V0c3RhbmRpbmcgPSAyMDsKIAogdW5z aWduZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyA9IDIwMDAwOwpA QCAtNTAwLDYgKzUwMSw3IEBAIHN0cnVjdCBub2RlICpyZWFkX25vZGUoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAlUREJf REFUQSBrZXksIGRhdGE7CiAJc3RydWN0IHhzX3RkYl9yZWNvcmRfaGRyICpo ZHI7CiAJc3RydWN0IG5vZGUgKm5vZGU7CisJaW50IGVycjsKIAogCW5vZGUg PSB0YWxsb2MoY3R4LCBzdHJ1Y3Qgbm9kZSk7CiAJaWYgKCFub2RlKSB7CkBA IC01MjEsMTQgKzUyMywxMyBAQCBzdHJ1Y3Qgbm9kZSAqcmVhZF9ub2RlKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsCiAJaWYg KGRhdGEuZHB0ciA9PSBOVUxMKSB7CiAJCWlmICh0ZGJfZXJyb3IodGRiX2N0 eCkgPT0gVERCX0VSUl9OT0VYSVNUKSB7CiAJCQlub2RlLT5nZW5lcmF0aW9u ID0gTk9fR0VORVJBVElPTjsKLQkJCWFjY2Vzc19ub2RlKGNvbm4sIG5vZGUs IE5PREVfQUNDRVNTX1JFQUQsIE5VTEwpOwotCQkJZXJybm8gPSBFTk9FTlQ7 CisJCQllcnIgPSBhY2Nlc3Nfbm9kZShjb25uLCBub2RlLCBOT0RFX0FDQ0VT U19SRUFELCBOVUxMKTsKKwkJCWVycm5vID0gZXJyID8gOiBFTk9FTlQ7CiAJ CX0gZWxzZSB7CiAJCQlsb2coIlREQiBlcnJvciBvbiByZWFkOiAlcyIsIHRk Yl9lcnJvcnN0cih0ZGJfY3R4KSk7CiAJCQllcnJubyA9IEVJTzsKIAkJfQot CQl0YWxsb2NfZnJlZShub2RlKTsKLQkJcmV0dXJuIE5VTEw7CisJCWdvdG8g ZXJyb3I7CiAJfQogCiAJbm9kZS0+cGFyZW50ID0gTlVMTDsKQEAgLTU0Mywx OSArNTQ0LDM2IEBAIHN0cnVjdCBub2RlICpyZWFkX25vZGUoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAogCS8qIFBlcm1p c3Npb25zIGFyZSBzdHJ1Y3QgeHNfcGVybWlzc2lvbnMuICovCiAJbm9kZS0+ cGVybXMucCA9IGhkci0+cGVybXM7Ci0JaWYgKGRvbWFpbl9hZGp1c3Rfbm9k ZV9wZXJtcyhjb25uLCBub2RlKSkgewotCQl0YWxsb2NfZnJlZShub2RlKTsK LQkJcmV0dXJuIE5VTEw7Ci0JfQorCWlmIChkb21haW5fYWRqdXN0X25vZGVf cGVybXMoY29ubiwgbm9kZSkpCisJCWdvdG8gZXJyb3I7CiAKIAkvKiBEYXRh IGlzIGJpbmFyeSBibG9iICh1c3VhbGx5IGFzY2lpLCBubyBudWwpLiAqLwog CW5vZGUtPmRhdGEgPSBub2RlLT5wZXJtcy5wICsgaGRyLT5udW1fcGVybXM7 CiAJLyogQ2hpbGRyZW4gaXMgc3RyaW5ncywgbnVsIHNlcGFyYXRlZC4gKi8K IAlub2RlLT5jaGlsZHJlbiA9IG5vZGUtPmRhdGEgKyBub2RlLT5kYXRhbGVu OwogCi0JYWNjZXNzX25vZGUoY29ubiwgbm9kZSwgTk9ERV9BQ0NFU1NfUkVB RCwgTlVMTCk7CisJaWYgKGFjY2Vzc19ub2RlKGNvbm4sIG5vZGUsIE5PREVf QUNDRVNTX1JFQUQsIE5VTEwpKQorCQlnb3RvIGVycm9yOwogCiAJcmV0dXJu IG5vZGU7CisKKyBlcnJvcjoKKwllcnIgPSBlcnJubzsKKwl0YWxsb2NfZnJl ZShub2RlKTsKKwllcnJubyA9IGVycjsKKwlyZXR1cm4gTlVMTDsKK30KKwor c3RhdGljIGJvb2wgcmVhZF9ub2RlX2Nhbl9wcm9wYWdhdGVfZXJybm8odm9p ZCkKK3sKKwkvKgorCSAqIDIgZXJyb3IgY2FzZXMgZm9yIHJlYWRfbm9kZSgp IGNhbiBhbHdheXMgYmUgcHJvcGFnYXRlZCB1cDoKKwkgKiBFTk9NRU0sIGJl Y2F1c2UgdGhpcyBoYXMgbm90aGluZyB0byBkbyB3aXRoIHRoZSBub2RlIGJl aW5nIGluIHRoZQorCSAqIGRhdGEgYmFzZSBvciBub3QsIGJ1dCBpcyBjYXVz ZWQgYnkgYSBnZW5lcmFsIGxhY2sgb2YgbWVtb3J5LgorCSAqIEVOT1NQQywg YmVjYXVzZSB0aGlzIGlzIHJlbGF0ZWQgdG8gaGl0dGluZyBxdW90YSBsaW1p dHMgd2hpY2ggbmVlZAorCSAqIHRvIGJlIHJlc3BlY3RlZC4KKwkgKi8KKwly ZXR1cm4gZXJybm8gPT0gRU5PTUVNIHx8IGVycm5vID09IEVOT1NQQzsKIH0K IAogaW50IHdyaXRlX25vZGVfcmF3KHN0cnVjdCBjb25uZWN0aW9uICpjb25u LCBUREJfREFUQSAqa2V5LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKQEAgLTY3MCw3 ICs2ODgsNyBAQCBzdGF0aWMgaW50IGFza19wYXJlbnRzKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsCiAJCW5vZGUgPSByZWFk X25vZGUoY29ubiwgY3R4LCBuYW1lKTsKIAkJaWYgKG5vZGUpCiAJCQlicmVh azsKLQkJaWYgKGVycm5vID09IEVOT01FTSkKKwkJaWYgKHJlYWRfbm9kZV9j YW5fcHJvcGFnYXRlX2Vycm5vKCkpCiAJCQlyZXR1cm4gZXJybm87CiAJfSB3 aGlsZSAoIXN0cmVxKG5hbWUsICIvIikpOwogCkBAIC03MzMsNyArNzUxLDcg QEAgc3RhdGljIHN0cnVjdCBub2RlICpnZXRfbm9kZShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwKIAkJfQogCX0KIAkvKiBDbGVhbiB1cCBlcnJubyBpZiB0 aGV5IHdlcmVuJ3Qgc3VwcG9zZWQgdG8ga25vdy4gKi8KLQlpZiAoIW5vZGUg JiYgZXJybm8gIT0gRU5PTUVNKQorCWlmICghbm9kZSAmJiAhcmVhZF9ub2Rl X2Nhbl9wcm9wYWdhdGVfZXJybm8oKSkKIAkJZXJybm8gPSBlcnJub19mcm9t X3BhcmVudHMoY29ubiwgY3R4LCBuYW1lLCBlcnJubywgcGVybSk7CiAJcmV0 dXJuIG5vZGU7CiB9CkBAIC0xMTE1LDcgKzExMzMsNyBAQCBzdGF0aWMgc3Ry dWN0IG5vZGUgKmNvbnN0cnVjdF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCBjb25zdCB2b2lkICpjdHgsCiAKIAkvKiBJZiBwYXJlbnQgZG9lc24n dCBleGlzdCwgY3JlYXRlIGl0LiAqLwogCXBhcmVudCA9IHJlYWRfbm9kZShj b25uLCBwYXJlbnRuYW1lLCBwYXJlbnRuYW1lKTsKLQlpZiAoIXBhcmVudCkK KwlpZiAoIXBhcmVudCAmJiBlcnJubyA9PSBFTk9FTlQpCiAJCXBhcmVudCA9 IGNvbnN0cnVjdF9ub2RlKGNvbm4sIGN0eCwgcGFyZW50bmFtZSk7CiAJaWYg KCFwYXJlbnQpCiAJCXJldHVybiBOVUxMOwpAQCAtMTM5NCw3ICsxNDEyLDcg QEAgc3RhdGljIGludCBfcm0oc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNv bnN0IHZvaWQgKmN0eCwgc3RydWN0IG5vZGUgKm5vZGUsCiAKIAlwYXJlbnQg PSByZWFkX25vZGUoY29ubiwgY3R4LCBwYXJlbnRuYW1lKTsKIAlpZiAoIXBh cmVudCkKLQkJcmV0dXJuIChlcnJubyA9PSBFTk9NRU0pID8gRU5PTUVNIDog RUlOVkFMOworCQlyZXR1cm4gcmVhZF9ub2RlX2Nhbl9wcm9wYWdhdGVfZXJy bm8oKSA/IGVycm5vIDogRUlOVkFMOwogCW5vZGUtPnBhcmVudCA9IHBhcmVu dDsKIAogCXJldHVybiBkZWxldGVfbm9kZShjb25uLCBjdHgsIHBhcmVudCwg bm9kZSwgZmFsc2UpOwpAQCAtMTQyMiw3ICsxNDQwLDcgQEAgc3RhdGljIGlu dCBkb19ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZl cmVkX2RhdGEgKmluKQogCQkJCXJldHVybiAwOwogCQkJfQogCQkJLyogUmVz dG9yZSBlcnJubywganVzdCBpbiBjYXNlLiAqLwotCQkJaWYgKGVycm5vICE9 IEVOT01FTSkKKwkJCWlmICghcmVhZF9ub2RlX2Nhbl9wcm9wYWdhdGVfZXJy bm8oKSkKIAkJCQllcnJubyA9IEVOT0VOVDsKIAkJfQogCQlyZXR1cm4gZXJy bm87CkBAIC0yMTkyLDYgKzIyMTAsOCBAQCBzdGF0aWMgdm9pZCB1c2FnZSh2 b2lkKQogIiAgLUEsIC0tcGVybS1uYiA8bmI+ICAgICAgbGltaXQgdGhlIG51 bWJlciBvZiBwZXJtaXNzaW9ucyBwZXIgbm9kZSxcbiIKICIgIC1RLCAtLXF1 b3RhIDx3aGF0Pj08bmI+IHNldCB0aGUgcXVvdGEgPHdoYXQ+IHRvIHRoZSB2 YWx1ZSA8bmI+LCBhbGxvd2VkXG4iCiAiICAgICAgICAgICAgICAgICAgICAg ICAgICBxdW90YXMgYXJlOlxuIgorIiAgICAgICAgICAgICAgICAgICAgICAg ICAgdHJhbnNhY3Rpb24tbm9kZXM6IG51bWJlciBvZiBhY2Nlc3NlZCBub2Rl IHBlclxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHRyYW5zYWN0aW9uXG4iCiAiICAgICAgICAgICAgICAgICAg ICAgICAgICBvdXRzdGFuZGluZzogbnVtYmVyIG9mIG91dHN0YW5kaW5nIHJl cXVlc3RzXG4iCiAiICAtdywgLS10aW1lb3V0IDx3aGF0Pj08c2Vjb25kcz4g ICBzZXQgdGhlIHRpbWVvdXQgaW4gc2Vjb25kcyBmb3IgPHdoYXQ+LFxuIgog IiAgICAgICAgICAgICAgICAgICAgICAgICAgYWxsb3dlZCB0aW1lb3V0IGNh bmRpZGF0ZXMgYXJlOlxuIgpAQCAtMjI3Myw2ICsyMjkzLDggQEAgc3RhdGlj IHZvaWQgc2V0X3F1b3RhKGNvbnN0IGNoYXIgKmFyZykKIAl2YWwgPSBnZXRf b3B0dmFsX2ludChlcSArIDEpOwogCWlmICh3aGF0X21hdGNoZXMoYXJnLCAi b3V0c3RhbmRpbmciKSkKIAkJcXVvdGFfcmVxX291dHN0YW5kaW5nID0gdmFs OworCWVsc2UgaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJ0cmFuc2FjdGlvbi1u b2RlcyIpKQorCQlxdW90YV90cmFuc19ub2RlcyA9IHZhbDsKIAllbHNlCiAJ CWJhcmYoInVua25vd24gcXVvdGEgXCIlc1wiXG4iLCBhcmcpOwogfQpkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKaW5kZXggOThkYjRhZmNh YWJmLi43ZTM3MTI1M2QyZDEgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuaApAQCAtMzQsNiArMzQsNyBAQAogI2luY2x1ZGUgImxpc3Qu aCIKICNpbmNsdWRlICJ0ZGIuaCIKICNpbmNsdWRlICJoYXNodGFibGUuaCIK KyNpbmNsdWRlICJ1dGlscy5oIgogCiAvKiBERUZBVUxUX0JVRkZFUl9TSVpF IHNob3VsZCBiZSBsYXJnZSBlbm91Z2ggZm9yIGVhY2ggZXJybm8gc3RyaW5n LiAqLwogI2RlZmluZSBERUZBVUxUX0JVRkZFUl9TSVpFIDE2CkBAIC0yMjMs NiArMjI0LDcgQEAgZXh0ZXJuIGludCBkb20wX2V2ZW50OwogZXh0ZXJuIGlu dCBwcml2X2RvbWlkOwogZXh0ZXJuIGludCBxdW90YV9uYl9lbnRyeV9wZXJf ZG9tYWluOwogZXh0ZXJuIGludCBxdW90YV9yZXFfb3V0c3RhbmRpbmc7Citl eHRlcm4gaW50IHF1b3RhX3RyYW5zX25vZGVzOwogCiBleHRlcm4gdW5zaWdu ZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIApkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwppbmRleCBi ZjJmZGE4MjM0YjMuLjc3OGI3ZTQzOWNiMyAxMDA2NDQKLS0tIGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKKysrIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKQEAgLTE1Niw2ICsx NTYsOSBAQCBzdHJ1Y3QgdHJhbnNhY3Rpb24KIAkvKiBDb25uZWN0aW9uLWxv Y2FsIGlkZW50aWZpZXIgZm9yIHRoaXMgdHJhbnNhY3Rpb24uICovCiAJdWlu dDMyX3QgaWQ7CiAKKwkvKiBOb2RlIGNvdW50ZXIuICovCisJdW5zaWduZWQg aW50IG5vZGVzOworCiAJLyogR2VuZXJhdGlvbiB3aGVuIHRyYW5zYWN0aW9u IHN0YXJ0ZWQuICovCiAJdWludDY0X3QgZ2VuZXJhdGlvbjsKIApAQCAtMjY2 LDYgKzI2OSwxMSBAQCBpbnQgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAogCiAJaSA9IGZpbmRfYWNj ZXNzZWRfbm9kZSh0cmFucywgbm9kZS0+bmFtZSk7CiAJaWYgKCFpKSB7CisJ CWlmICh0cmFucy0+bm9kZXMgPj0gcXVvdGFfdHJhbnNfbm9kZXMgJiYKKwkJ ICAgIGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikpIHsKKwkJCXJldCA9 IEVOT1NQQzsKKwkJCWdvdG8gZXJyOworCQl9CiAJCWkgPSB0YWxsb2NfemVy byh0cmFucywgc3RydWN0IGFjY2Vzc2VkX25vZGUpOwogCQlpZiAoIWkpCiAJ CQlnb3RvIG5vbWVtOwpAQCAtMzAzLDYgKzMxMSw3IEBAIGludCBhY2Nlc3Nf bm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKm5v ZGUsCiAJCQkJaS0+dGFfbm9kZSA9IHRydWU7CiAJCQl9CiAJCX0KKwkJdHJh bnMtPm5vZGVzKys7CiAJCWxpc3RfYWRkX3RhaWwoJmktPmxpc3QsICZ0cmFu cy0+YWNjZXNzZWQpOwogCX0KIApkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmggYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfdHJhbnNhY3Rpb24uaAppbmRleCAwMDkzY2FjODA3ZTMuLmUz Y2JkNmIyMzA5NSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX3RyYW5zYWN0aW9uLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX3RyYW5zYWN0aW9uLmgKQEAgLTM5LDggKzM5LDggQEAgdm9pZCB0cmFu c2FjdGlvbl9lbnRyeV9pbmMoc3RydWN0IHRyYW5zYWN0aW9uICp0cmFucywg dW5zaWduZWQgaW50IGRvbWlkKTsKIHZvaWQgdHJhbnNhY3Rpb25fZW50cnlf ZGVjKHN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnMsIHVuc2lnbmVkIGludCBk b21pZCk7CiAKIC8qIFRoaXMgbm9kZSB3YXMgYWNjZXNzZWQuICovCi1pbnQg YWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlLAotICAgICAgICAgICAgICAgIGVudW0gbm9kZV9hY2Nlc3Nf dHlwZSB0eXBlLCBUREJfREFUQSAqa2V5KTsKK2ludCBfX211c3RfY2hlY2sg YWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbnVt IG5vZGVfYWNjZXNzX3R5cGUgdHlwZSwgVERCX0RBVEEgKmtleSk7CiAKIC8q IFF1ZXVlIHdhdGNoZXMgZm9yIGEgbW9kaWZpZWQgbm9kZS4gKi8KIHZvaWQg cXVldWVfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qg Y2hhciAqbmFtZSwgYm9vbCB3YXRjaF9leGFjdCk7Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-10.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-10.patch" Content-Transfer-Encoding: base64 RnJvbSBhMGQzYmNlODI3Y2E2NTZmYjVkOGY0NjJiYjY3ODZmOTU2N2RkZGZh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IG1vdmUgdGhl IGNhbGwgb2Ygc2V0dXBfc3RydWN0dXJlKCkgdG8gZG9tMAogaW50cm9kdWN0 aW9uCgpTZXR0aW5nIHVwIHRoZSBiYXNpYyBzdHJ1Y3R1cmUgd2hlbiBpbnRy b2R1Y2luZyBkb20wIGhhcyB0aGUgYWR2YW50YWdlCnRvIGJlIGFibGUgdG8g YWRkIHByb3BlciBub2RlIG1lbW9yeSBhY2NvdW50aW5nIGZvciB0aGUgYWRk ZWQgbm9kZXMKbGF0ZXIuCgpUaGlzIG1ha2VzIGl0IHBvc3NpYmxlIHRvIGRv IHByb3BlciBub2RlIGFjY291bnRpbmcsIHRvby4KCkFuIGFkZGl0aW9uYWwg cmVxdWlyZW1lbnQgdG8gbWFrZSB0aGF0IHdvcmsgZmluZSBpcyB0byBjb3Jy ZWN0IHRoZQpvd25lciBvZiB0aGUgY3JlYXRlZCBub2RlcyB0byBiZSBkb20w X2RvbWlkIGluc3RlYWQgb2YgZG9taWQgMC4KClRoaXMgaXMgcGFydCBvZiBY U0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMK aW5kZXggNTdjOTk5MTI5Mi4uMTMzNTA1MWE1MyAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0xODMyLDcgKzE4MzIsOCBAQCBz dGF0aWMgaW50IHRkYl9mbGFnczsKIHN0YXRpYyB2b2lkIG1hbnVhbF9ub2Rl KGNvbnN0IGNoYXIgKm5hbWUsIGNvbnN0IGNoYXIgKmNoaWxkKQogewogCXN0 cnVjdCBub2RlICpub2RlOwotCXN0cnVjdCB4c19wZXJtaXNzaW9ucyBwZXJt cyA9IHsgLmlkID0gMCwgLnBlcm1zID0gWFNfUEVSTV9OT05FIH07CisJc3Ry dWN0IHhzX3Blcm1pc3Npb25zIHBlcm1zID0geyAuaWQgPSBkb20wX2RvbWlk LAorCQkJCQkucGVybXMgPSBYU19QRVJNX05PTkUgfTsKIAogCW5vZGUgPSB0 YWxsb2NfemVybyhOVUxMLCBzdHJ1Y3Qgbm9kZSk7CiAJaWYgKCFub2RlKQpA QCAtMTg3MSw3ICsxODcyLDcgQEAgc3RhdGljIHZvaWQgdGRiX2xvZ2dlcihU REJfQ09OVEVYVCAqdGRiLCBpbnQgbGV2ZWwsIGNvbnN0IGNoYXIgKiBmbXQs IC4uLikKIAl9CiB9CiAKLXN0YXRpYyB2b2lkIHNldHVwX3N0cnVjdHVyZSh2 b2lkKQordm9pZCBzZXR1cF9zdHJ1Y3R1cmUodm9pZCkKIHsKIAljaGFyICp0 ZGJuYW1lOwogCXRkYm5hbWUgPSB0YWxsb2Nfc3RyZHVwKHRhbGxvY19hdXRv ZnJlZV9jb250ZXh0KCksIHhzX2RhZW1vbl90ZGIoKSk7CkBAIC0xODg5LDYg KzE4OTAsNyBAQCBzdGF0aWMgdm9pZCBzZXR1cF9zdHJ1Y3R1cmUodm9pZCkK IAltYW51YWxfbm9kZSgiLyIsICJ0b29sIik7CiAJbWFudWFsX25vZGUoIi90 b29sIiwgInhlbnN0b3JlZCIpOwogCW1hbnVhbF9ub2RlKCIvdG9vbC94ZW5z dG9yZWQiLCBOVUxMKTsKKwlkb21haW5fZW50cnlfZml4KGRvbTBfZG9taWQs IDMsIHRydWUpOwogCiAJY2hlY2tfc3RvcmUoKTsKIH0KQEAgLTI0MDIsOSAr MjQwNCw2IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAK IAlpbml0X3BpcGUocmVvcGVuX2xvZ19waXBlKTsKIAotCS8qIFNldHVwIHRo ZSBkYXRhYmFzZSAqLwotCXNldHVwX3N0cnVjdHVyZSgpOwotCiAJLyogTGlz dGVuIHRvIGh5cGVydmlzb3IuICovCiAJaWYgKCFub19kb21haW5faW5pdCkK IAkJZG9tYWluX2luaXQoKTsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5oCmluZGV4IDdlMzcxMjUzZDIuLmQ5NWU0MjYyYTkgMTAwNjQ0Ci0t LSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKKysrIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMTk1LDYgKzE5NSw3 IEBAIGludCB3cml0ZV9ub2RlX3JhdyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgVERCX0RBVEEgKmtleSwgc3RydWN0IG5vZGUgKm5vZGUsCiBzdHJ1Y3Qg bm9kZSAqcmVhZF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25z dCB2b2lkICpjdHgsCiAJCSAgICAgICBjb25zdCBjaGFyICpuYW1lKTsKIAor dm9pZCBzZXR1cF9zdHJ1Y3R1cmUodm9pZCk7CiBzdHJ1Y3QgY29ubmVjdGlv biAqbmV3X2Nvbm5lY3Rpb24oY29ubndyaXRlZm5fdCAqd3JpdGUsIGNvbm5y ZWFkZm5fdCAqcmVhZCk7CiB2b2lkIGNoZWNrX3N0b3JlKHZvaWQpOwogdm9p ZCBjb3JydXB0KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFy ICpmbXQsIC4uLik7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9t YWluLmMKaW5kZXggZjQxMzRkYjNlNy4uOGJmOWRiMmQ5NiAxMDA2NDQKLS0t IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCisrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYwpAQCAtNzM5LDYgKzcz OSw4IEBAIHN0YXRpYyBpbnQgZG9tMF9pbml0KHZvaWQpCiAJaWYgKGRvbTAt PmludGVyZmFjZSA9PSBOVUxMKQogCQlyZXR1cm4gLTE7CiAKKwlzZXR1cF9z dHJ1Y3R1cmUoKTsKKwogCXRhbGxvY19zdGVhbChkb20wLT5jb25uLCBkb20w KTsgCiAKIAl4ZW5ldnRjaG5fbm90aWZ5KHhjZV9oYW5kbGUsIGRvbTAtPnBv cnQpOwotLSAKMi4zNS4zCgo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-11.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-11.patch" Content-Transfer-Encoding: base64 RnJvbSBhYzM2MzU0YzhmYWJmNThiMTI3ODEzNThkZWMzOWFlY2MzYTYzNzZi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBpbmZy YXN0cnVjdHVyZSB0byBrZWVwIHRyYWNrIG9mIHBlciBkb21haW4gbWVtb3J5 CiB1c2FnZQoKVGhlIGFtb3VudCBvZiBtZW1vcnkgYSBkb21haW4gY2FuIGNv bnN1bWUgaW4gWGVuc3RvcmUgaXMgbGltaXRlZCBieQp2YXJpb3VzIHF1b3Rh IHRvZGF5LCBidXQgZXZlbiB3aXRoIHNhbmUgcXVvdGEgYSBkb21haW4gY2Fu IHN0aWxsCmNvbnN1bWUgcmF0aGVyIGxhcmdlIG1lbW9yeSBxdWFudGl0aWVz LgoKQWRkIHRoZSBpbmZyYXN0cnVjdHVyZSBmb3Iga2VlcGluZyB0cmFjayBv ZiB0aGUgYW1vdW50IG9mIG1lbW9yeSBhCmRvbWFpbiBpcyBjb25zdW1pbmcg aW4gWGVuc3RvcmUuIE5vdGUgdGhhdCB0aGlzIGlzIG9ubHkgdGhlIG1lbW9y eSBhCmRvbWFpbiBoYXMgZGlyZWN0IGNvbnRyb2wgb3Zlciwgc28gYW55IGlu dGVybmFsIGFkbWluaXN0cmF0aW9uIGRhdGEKbmVlZGVkIGJ5IFhlbnN0b3Jl IG9ubHkgaXMgbm90IGJlaW5nIGFjY291bnRlZCBmb3IuCgpUaGVyZSBhcmUg dHdvIHF1b3RhcyBkZWZpbmVkOiBhIHNvZnQgcXVvdGEgd2hpY2ggd2lsbCBy ZXN1bHQgaW4gYQp3YXJuaW5nIGlzc3VlZCB2aWEgc3lzbG9nKCkgd2hlbiBp dCBpcyBleGNlZWRlZCwgYW5kIGEgaGFyZCBxdW90YQpyZXN1bHRpbmcgaW4g YSBzdG9wIG9mIGFjY2VwdGluZyBmdXJ0aGVyIHJlcXVlc3RzIG9yIHdhdGNo IGV2ZW50cyBhcwpsb25nIGFzIHRoZSBoYXJkIHF1b3RhIHdvdWxkIGJlIHZp b2xhdGVkIGJ5IGFjY2VwdGluZyB0aG9zZS4KClNldHRpbmcgYW55IG9mIHRo b3NlIHF1b3RhcyB0byAwIHdpbGwgZGlzYWJsZSBpdC4KCkFzIGRlZmF1bHQg dmFsdWVzIHVzZSAyTUIgcGVyIGRvbWFpbiBmb3IgdGhlIHNvZnQgbGltaXQg KHRoaXMgYmFzaWNhbGx5CmNvdmVycyB0aGUgYWxsb3dlZCBjYXNlIHRvIGNy ZWF0ZSAxMDAwIG5vZGVzIG5lZWRpbmcgMmtCIGVhY2gpLCBhbmQKMi41TUIg Zm9yIHRoZSBoYXJkIGxpbWl0LgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYu CgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNv bT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwppbmRl eCAxMzM1MDUxYTUzZjMuLjIxNzA5NmQ5MWE5ZCAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0xMDQsNiArMTA0LDggQEAgaW50 IHF1b3RhX21heF90cmFuc2FjdGlvbiA9IDEwOwogaW50IHF1b3RhX25iX3Bl cm1zX3Blcl9ub2RlID0gNTsKIGludCBxdW90YV90cmFuc19ub2RlcyA9IDEw MjQ7CiBpbnQgcXVvdGFfcmVxX291dHN0YW5kaW5nID0gMjA7CitpbnQgcXVv dGFfbWVtb3J5X3Blcl9kb21haW5fc29mdCA9IDIgKiAxMDI0ICogMTAyNDsg LyogMiBNQiAqLworaW50IHF1b3RhX21lbW9yeV9wZXJfZG9tYWluX2hhcmQg PSAyICogMTAyNCAqIDEwMjQgKyA1MTIgKiAxMDI0OyAvKiAyLjUgTUIgKi8K IAogdW5zaWduZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyA9IDIw MDAwOwogCkBAIC0yMjE0LDcgKzIyMTYsMTQgQEAgc3RhdGljIHZvaWQgdXNh Z2Uodm9pZCkKICIgICAgICAgICAgICAgICAgICAgICAgICAgIHF1b3RhcyBh cmU6XG4iCiAiICAgICAgICAgICAgICAgICAgICAgICAgICB0cmFuc2FjdGlv bi1ub2RlczogbnVtYmVyIG9mIGFjY2Vzc2VkIG5vZGUgcGVyXG4iCiAiICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHJh bnNhY3Rpb25cbiIKKyIgICAgICAgICAgICAgICAgICAgICAgICAgIG1lbW9y eTogdG90YWwgdXNlZCBtZW1vcnkgcGVyIGRvbWFpbiBmb3Igbm9kZXMsXG4i CisiICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRyYW5zYWN0 aW9ucywgd2F0Y2hlcyBhbmQgcmVxdWVzdHMsIGFib3ZlXG4iCisiICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHdoaWNoIFhlbnN0b3JlIHdp bGwgc3RvcCB0YWxraW5nIHRvIGRvbWFpblxuIgogIiAgICAgICAgICAgICAg ICAgICAgICAgICAgb3V0c3RhbmRpbmc6IG51bWJlciBvZiBvdXRzdGFuZGlu ZyByZXF1ZXN0c1xuIgorIiAgLXEsIC0tcXVvdGEtc29mdCA8d2hhdD49PG5i PiBzZXQgYSBzb2Z0IHF1b3RhIDx3aGF0PiB0byB0aGUgdmFsdWUgPG5iPixc biIKKyIgICAgICAgICAgICAgICAgICAgICAgICAgIGNhdXNpbmcgYSB3YXJu aW5nIHRvIGJlIGlzc3VlZCB2aWEgc3lzbG9nKCkgaWYgdGhlXG4iCisiICAg ICAgICAgICAgICAgICAgICAgICAgICBsaW1pdCBpcyB2aW9sYXRlZCwgYWxs b3dlZCBxdW90YXMgYXJlOlxuIgorIiAgICAgICAgICAgICAgICAgICAgICAg ICAgbWVtb3J5OiBzZWUgYWJvdmVcbiIKICIgIC13LCAtLXRpbWVvdXQgPHdo YXQ+PTxzZWNvbmRzPiAgIHNldCB0aGUgdGltZW91dCBpbiBzZWNvbmRzIGZv ciA8d2hhdD4sXG4iCiAiICAgICAgICAgICAgICAgICAgICAgICAgICBhbGxv d2VkIHRpbWVvdXQgY2FuZGlkYXRlcyBhcmU6XG4iCiAiICAgICAgICAgICAg ICAgICAgICAgICAgICB3YXRjaC1ldmVudDogdGltZSBhIHdhdGNoLWV2ZW50 IGlzIGtlcHQgcGVuZGluZ1xuIgpAQCAtMjI0MCw2ICsyMjQ5LDcgQEAgc3Rh dGljIHN0cnVjdCBvcHRpb24gb3B0aW9uc1tdID0gewogCXsgInRyYW5zYWN0 aW9uIiwgMSwgTlVMTCwgJ3QnIH0sCiAJeyAicGVybS1uYiIsIDEsIE5VTEws ICdBJyB9LAogCXsgInF1b3RhIiwgMSwgTlVMTCwgJ1EnIH0sCisJeyAicXVv dGEtc29mdCIsIDEsIE5VTEwsICdxJyB9LAogCXsgInRpbWVvdXQiLCAxLCBO VUxMLCAndycgfSwKIAl7ICJuby1yZWNvdmVyeSIsIDAsIE5VTEwsICdSJyB9 LAogCXsgImludGVybmFsLWRiIiwgMCwgTlVMTCwgJ0knIH0sCkBAIC0yMjg1 LDcgKzIyOTUsNyBAQCBzdGF0aWMgdm9pZCBzZXRfdGltZW91dChjb25zdCBj aGFyICphcmcpCiAJCWJhcmYoInVua25vd24gdGltZW91dCBcIiVzXCJcbiIs IGFyZyk7CiB9CiAKLXN0YXRpYyB2b2lkIHNldF9xdW90YShjb25zdCBjaGFy ICphcmcpCitzdGF0aWMgdm9pZCBzZXRfcXVvdGEoY29uc3QgY2hhciAqYXJn LCBib29sIHNvZnQpCiB7CiAJY29uc3QgY2hhciAqZXEgPSBzdHJjaHIoYXJn LCAnPScpOwogCWludCB2YWw7CkBAIC0yMjkzLDExICsyMzAzLDE2IEBAIHN0 YXRpYyB2b2lkIHNldF9xdW90YShjb25zdCBjaGFyICphcmcpCiAJaWYgKCFl cSkKIAkJYmFyZigicXVvdGFzIG11c3QgYmUgc3BlY2lmaWVkIHZpYSA8d2hh dD49PG5iPlxuIik7CiAJdmFsID0gZ2V0X29wdHZhbF9pbnQoZXEgKyAxKTsK LQlpZiAod2hhdF9tYXRjaGVzKGFyZywgIm91dHN0YW5kaW5nIikpCisJaWYg KHdoYXRfbWF0Y2hlcyhhcmcsICJvdXRzdGFuZGluZyIpICYmICFzb2Z0KQog CQlxdW90YV9yZXFfb3V0c3RhbmRpbmcgPSB2YWw7Ci0JZWxzZSBpZiAod2hh dF9tYXRjaGVzKGFyZywgInRyYW5zYWN0aW9uLW5vZGVzIikpCisJZWxzZSBp ZiAod2hhdF9tYXRjaGVzKGFyZywgInRyYW5zYWN0aW9uLW5vZGVzIikgJiYg IXNvZnQpCiAJCXF1b3RhX3RyYW5zX25vZGVzID0gdmFsOwotCWVsc2UKKwll bHNlIGlmICh3aGF0X21hdGNoZXMoYXJnLCAibWVtb3J5IikpIHsKKwkJaWYg KHNvZnQpCisJCQlxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9zb2Z0ID0gdmFs OworCQllbHNlCisJCQlxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJkID0g dmFsOworCX0gZWxzZQogCQliYXJmKCJ1bmtub3duIHF1b3RhIFwiJXNcIlxu IiwgYXJnKTsKIH0KIApAQCAtMjMxMiw3ICsyMzI3LDcgQEAgaW50IG1haW4o aW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAlpbnQgdGltZW91dDsKIAogCi0J d2hpbGUgKChvcHQgPSBnZXRvcHRfbG9uZyhhcmdjLCBhcmd2LCAiREU6RjpI TlBTOnQ6QTpROlQ6UlZXOnc6Iiwgb3B0aW9ucywKKwl3aGlsZSAoKG9wdCA9 IGdldG9wdF9sb25nKGFyZ2MsIGFyZ3YsICJERTpGOkhOUFM6dDpBOlE6cTpU OlJWVzp3OiIsIG9wdGlvbnMsCiAJCQkJICBOVUxMKSkgIT0gLTEpIHsKIAkJ c3dpdGNoIChvcHQpIHsKIAkJY2FzZSAnRCc6CkBAIC0yMzU4LDcgKzIzNzMs MTAgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAkJCXF1 b3RhX25iX3Blcm1zX3Blcl9ub2RlID0gc3RydG9sKG9wdGFyZywgTlVMTCwg MTApOwogCQkJYnJlYWs7CiAJCWNhc2UgJ1EnOgotCQkJc2V0X3F1b3RhKG9w dGFyZyk7CisJCQlzZXRfcXVvdGEob3B0YXJnLCBmYWxzZSk7CisJCQlicmVh azsKKwkJY2FzZSAncSc6CisJCQlzZXRfcXVvdGEob3B0YXJnLCB0cnVlKTsK IAkJCWJyZWFrOwogCQljYXNlICd3JzoKIAkJCXNldF90aW1lb3V0KG9wdGFy Zyk7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29y ZS5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCBk OTVlNDI2MmE5MWUuLjRlNTMwNzJlNjM3YyAxMDA2NDQKLS0tIGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAorKysgYi90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfY29yZS5oCkBAIC0yMjYsNiArMjI2LDggQEAgZXh0ZXJu IGludCBwcml2X2RvbWlkOwogZXh0ZXJuIGludCBxdW90YV9uYl9lbnRyeV9w ZXJfZG9tYWluOwogZXh0ZXJuIGludCBxdW90YV9yZXFfb3V0c3RhbmRpbmc7 CiBleHRlcm4gaW50IHF1b3RhX3RyYW5zX25vZGVzOworZXh0ZXJuIGludCBx dW90YV9tZW1vcnlfcGVyX2RvbWFpbl9zb2Z0OworZXh0ZXJuIGludCBxdW90 YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJkOwogCiBleHRlcm4gdW5zaWduZWQg aW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIApkaWZmIC0tZ2l0IGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IGU0MTFjNzlkNThhNy4u MTEyZmI0NTc1ODFlIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2RvbWFpbi5jCkBAIC04NCw2ICs4NCwxMyBAQCBzdHJ1Y3QgZG9tYWluCiAJ LyogbnVtYmVyIG9mIGVudHJ5IGZyb20gdGhpcyBkb21haW4gaW4gdGhlIHN0 b3JlICovCiAJaW50IG5iZW50cnk7CiAKKwkvKiBBbW91bnQgb2YgbWVtb3J5 IGFsbG9jYXRlZCBmb3IgdGhpcyBkb21haW4uICovCisJaW50IG1lbW9yeTsK Kwlib29sIHNvZnRfcXVvdGFfcmVwb3J0ZWQ7CisJYm9vbCBoYXJkX3F1b3Rh X3JlcG9ydGVkOworCXRpbWVfdCBtZW1fbGFzdF9tc2c7CisjZGVmaW5lIE1F TV9XQVJOX01JTlRJTUVfU0VDIDEwCisKIAkvKiBudW1iZXIgb2Ygd2F0Y2gg Zm9yIHRoaXMgZG9tYWluICovCiAJaW50IG5id2F0Y2g7CiAKQEAgLTI5Nyw2 ICszMDQsOSBAQCBib29sIGRvbWFpbl9jYW5fcmVhZChzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubikKIAkJCXJldHVybiBmYWxzZTsKIAkJaWYgKGNvbm4tPmRv bWFpbi0+bmJvdXRzdGFuZGluZyA+PSBxdW90YV9yZXFfb3V0c3RhbmRpbmcp CiAJCQlyZXR1cm4gZmFsc2U7CisJCWlmIChjb25uLT5kb21haW4tPm1lbW9y eSA+PSBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJkICYmCisJCSAgICBx dW90YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJkKQorCQkJcmV0dXJuIGZhbHNl OwogCX0KIAogCWlmIChjb25uLT5pc19pZ25vcmVkKQpAQCAtOTQ0LDYgKzk1 NCw4OSBAQCBpbnQgZG9tYWluX2VudHJ5KHN0cnVjdCBjb25uZWN0aW9uICpj b25uKQogCQk6IDA7CiB9CiAKK3N0YXRpYyBib29sIGRvbWFpbl9jaGtfcXVv dGEoc3RydWN0IGRvbWFpbiAqZG9tYWluLCBpbnQgbWVtKQoreworCXRpbWVf dCBub3c7CisKKwlpZiAoIWRvbWFpbiB8fCAhZG9taWRfaXNfdW5wcml2aWxl Z2VkKGRvbWFpbi0+ZG9taWQpIHx8CisJICAgIChkb21haW4tPmNvbm4gJiYg ZG9tYWluLT5jb25uLT5pc19pZ25vcmVkKSkKKwkJcmV0dXJuIGZhbHNlOwor CisJbm93ID0gdGltZShOVUxMKTsKKworCWlmIChtZW0gPj0gcXVvdGFfbWVt b3J5X3Blcl9kb21haW5faGFyZCAmJgorCSAgICBxdW90YV9tZW1vcnlfcGVy X2RvbWFpbl9oYXJkKSB7CisJCWlmIChkb21haW4tPmhhcmRfcXVvdGFfcmVw b3J0ZWQpCisJCQlyZXR1cm4gdHJ1ZTsKKwkJc3lzbG9nKExPR19FUlIsICJE b21haW4gJXUgZXhjZWVkcyBoYXJkIG1lbW9yeSBxdW90YSwgWGVuc3RvcmUg aW50ZXJmYWNlIHRvIGRvbWFpbiBzdGFsbGVkXG4iLAorCQkgICAgICAgZG9t YWluLT5kb21pZCk7CisJCWRvbWFpbi0+bWVtX2xhc3RfbXNnID0gbm93Owor CQlkb21haW4tPmhhcmRfcXVvdGFfcmVwb3J0ZWQgPSB0cnVlOworCQlyZXR1 cm4gdHJ1ZTsKKwl9CisKKwlpZiAobm93IC0gZG9tYWluLT5tZW1fbGFzdF9t c2cgPj0gTUVNX1dBUk5fTUlOVElNRV9TRUMpIHsKKwkJaWYgKGRvbWFpbi0+ aGFyZF9xdW90YV9yZXBvcnRlZCkgeworCQkJZG9tYWluLT5tZW1fbGFzdF9t c2cgPSBub3c7CisJCQlkb21haW4tPmhhcmRfcXVvdGFfcmVwb3J0ZWQgPSBm YWxzZTsKKwkJCXN5c2xvZyhMT0dfSU5GTywgIkRvbWFpbiAldSBiZWxvdyBo YXJkIG1lbW9yeSBxdW90YSBhZ2FpblxuIiwKKwkJCSAgICAgICBkb21haW4t PmRvbWlkKTsKKwkJfQorCQlpZiAobWVtID49IHF1b3RhX21lbW9yeV9wZXJf ZG9tYWluX3NvZnQgJiYKKwkJICAgIHF1b3RhX21lbW9yeV9wZXJfZG9tYWlu X3NvZnQgJiYKKwkJICAgICFkb21haW4tPnNvZnRfcXVvdGFfcmVwb3J0ZWQp IHsKKwkJCWRvbWFpbi0+bWVtX2xhc3RfbXNnID0gbm93OworCQkJZG9tYWlu LT5zb2Z0X3F1b3RhX3JlcG9ydGVkID0gdHJ1ZTsKKwkJCXN5c2xvZyhMT0df V0FSTklORywgIkRvbWFpbiAldSBleGNlZWRzIHNvZnQgbWVtb3J5IHF1b3Rh XG4iLAorCQkJICAgICAgIGRvbWFpbi0+ZG9taWQpOworCQl9CisJCWlmICht ZW0gPCBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9zb2Z0ICYmCisJCSAgICBk b21haW4tPnNvZnRfcXVvdGFfcmVwb3J0ZWQpIHsKKwkJCWRvbWFpbi0+bWVt X2xhc3RfbXNnID0gbm93OworCQkJZG9tYWluLT5zb2Z0X3F1b3RhX3JlcG9y dGVkID0gZmFsc2U7CisJCQlzeXNsb2coTE9HX0lORk8sICJEb21haW4gJXUg YmVsb3cgc29mdCBtZW1vcnkgcXVvdGEgYWdhaW5cbiIsCisJCQkgICAgICAg ZG9tYWluLT5kb21pZCk7CisJCX0KKworCX0KKworCXJldHVybiBmYWxzZTsK K30KKworaW50IGRvbWFpbl9tZW1vcnlfYWRkKHVuc2lnbmVkIGludCBkb21p ZCwgaW50IG1lbSwgYm9vbCBub19xdW90YV9jaGVjaykKK3sKKwlzdHJ1Y3Qg ZG9tYWluICpkb21haW47CisKKwlkb21haW4gPSBmaW5kX2RvbWFpbl9zdHJ1 Y3QoZG9taWQpOworCWlmIChkb21haW4pIHsKKwkJLyoKKwkJICogZG9tYWlu X2Noa19xdW90YSgpIHdpbGwgcHJpbnQgd2FybmluZyBhbmQgYWxzbyBzdG9y ZSB3aGV0aGVyCisJCSAqIHRoZSBzb2Z0L2hhcmQgcXVvdGEgaGFzIGJlZW4g aGl0LiBTbyBjaGVjayBub19xdW90YV9jaGVjaworCQkgKiAqYWZ0ZXIqLgor CQkgKi8KKwkJaWYgKGRvbWFpbl9jaGtfcXVvdGEoZG9tYWluLCBkb21haW4t Pm1lbW9yeSArIG1lbSkgJiYKKwkJICAgICFub19xdW90YV9jaGVjaykKKwkJ CXJldHVybiBFTk9NRU07CisJCWRvbWFpbi0+bWVtb3J5ICs9IG1lbTsKKwl9 IGVsc2UgeworCQkvKgorCQkgKiBUaGUgZG9tYWluIHRoZSBtZW1vcnkgaXMg dG8gYmUgYWNjb3VudGVkIGZvciBzaG91bGQgYWx3YXlzCisJCSAqIGV4aXN0 LCBhcyBhY2NvdW50aW5nIGlzIGRvbmUgZWl0aGVyIGZvciBhIGRvbWFpbiBy ZWxhdGVkIHRvCisJCSAqIHRoZSBjdXJyZW50IGNvbm5lY3Rpb24sIG9yIGZv ciB0aGUgZG9tYWluIG93bmluZyBhIG5vZGUKKwkJICogKHdoaWNoIGlzIGFs d2F5cyBleGlzdGluZywgYXMgdGhlIG93bmVyIG9mIHRoZSBub2RlIGlzCisJ CSAqIHRlc3RlZCB0byBleGlzdCBhbmQgcmVwbGFjZWQgYnkgZG9taWQgMCBp ZiBub3QpLgorCQkgKiBTbyBub3QgZmluZGluZyB0aGUgcmVsYXRlZCBkb21h aW4gTVVTVCBiZSBhbiBlcnJvciBpbiB0aGUKKwkJICogZGF0YSBiYXNlLgor CQkgKi8KKwkJZXJybm8gPSBFTk9FTlQ7CisJCWNvcnJ1cHQoTlVMTCwgIkFj Y291bnRpbmcgY2FsbGVkIGZvciBub24tZXhpc3RpbmcgZG9tYWluICV1XG4i LAorCQkJZG9taWQpOworCQlyZXR1cm4gRU5PRU5UOworCX0KKworCXJldHVy biAwOworfQorCiB2b2lkIGRvbWFpbl93YXRjaF9pbmMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pCiB7CiAJaWYgKCFjb25uIHx8ICFjb25uLT5kb21haW4p CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWlu LmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgKaW5kZXgg NGVkZjFkYmE5NDI1Li4zYThjNmJhYjQ4YmEgMTAwNjQ0Ci0tLSBhL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaAorKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfZG9tYWluLmgKQEAgLTY0LDYgKzY0LDI2IEBAIGlu dCBkb21haW5fZW50cnlfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBz dHJ1Y3Qgbm9kZSAqKTsKIHZvaWQgZG9tYWluX2VudHJ5X2RlYyhzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKik7CiBpbnQgZG9tYWlu X2VudHJ5X2ZpeCh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBudW0sIGJvb2wg dXBkYXRlKTsKIGludCBkb21haW5fZW50cnkoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pOworaW50IGRvbWFpbl9tZW1vcnlfYWRkKHVuc2lnbmVkIGludCBk b21pZCwgaW50IG1lbSwgYm9vbCBub19xdW90YV9jaGVjayk7CisKKy8qCisg KiBkb21haW5fbWVtb3J5X2FkZF9jaGsoKTogdG8gYmUgdXNlZCB3aGVuIG1l bW9yeSBxdW90YSBzaG91bGQgYmUgY2hlY2tlZC4KKyAqIE5vdCB0byBiZSB1 c2VkIHdoZW4gc3BlY2lmeWluZyBhIG5lZ2F0aXZlIG1lbSB2YWx1ZSwgYXMg bG93ZXJpbmcgdGhlIHVzZWQKKyAqIG1lbW9yeSBzaG91bGQgYWx3YXlzIGJl IGFsbG93ZWQuCisgKi8KK3N0YXRpYyBpbmxpbmUgaW50IGRvbWFpbl9tZW1v cnlfYWRkX2Noayh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBtZW0pCit7CisJ cmV0dXJuIGRvbWFpbl9tZW1vcnlfYWRkKGRvbWlkLCBtZW0sIGZhbHNlKTsK K30KKy8qCisgKiBkb21haW5fbWVtb3J5X2FkZF9ub2NoaygpOiB0byBiZSB1 c2VkIHdoZW4gbWVtb3J5IHF1b3RhIHNob3VsZCBub3QgYmUKKyAqIGNoZWNr ZWQsIGUuZy4gd2hlbiBsb3dlcmluZyBtZW1vcnkgdXNhZ2UsIG9yIGluIGFu IGVycm9yIGNhc2UgZm9yIHVuZG9pbmcKKyAqIGEgcHJldmlvdXMgbWVtb3J5 IGFkanVzdG1lbnQuCisgKi8KK3N0YXRpYyBpbmxpbmUgdm9pZCBkb21haW5f bWVtb3J5X2FkZF9ub2Noayh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBtZW0p Cit7CisJZG9tYWluX21lbW9yeV9hZGQoZG9taWQsIG1lbSwgdHJ1ZSk7Cit9 CiB2b2lkIGRvbWFpbl93YXRjaF9pbmMoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4pOwogdm9pZCBkb21haW5fd2F0Y2hfZGVjKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uKTsKIGludCBkb21haW5fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pOwo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-12.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-12.patch" Content-Transfer-Encoding: base64 RnJvbSBmYmQ5Y2FlMDMyYjQ1MmYwNGQ5MzgyM2Q0ODk3NGQ5NTdkODYzYmVi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3IgcmVzcG9uc2VzCgpBZGQgdGhlIG1lbW9yeSBh Y2NvdW50aW5nIGZvciBxdWV1ZWQgcmVzcG9uc2VzLgoKSW4gY2FzZSBhZGRp bmcgYSB3YXRjaCBldmVudCBmb3IgYSBndWVzdCBpcyBjYXVzaW5nIHRoZSBo YXJkIG1lbW9yeQpxdW90YSBvZiB0aGF0IGd1ZXN0IHRvIGJlIHZpb2xhdGVk LCB0aGUgZXZlbnQgaXMgZHJvcHBlZC4gVGhpcyB3aWxsCmVuc3VyZSB0aGF0 IGl0IGlzIGltcG9zc2libGUgdG8gZHJpdmUgYW5vdGhlciBndWVzdCBwYXN0 IGl0cyBtZW1vcnkKcXVvdGEgYnkgZ2VuZXJhdGluZyBpbnNhbmUgYW1vdW50 cyBvZiBldmVudHMgZm9yIHRoYXQgZ3Vlc3QuIFRoaXMgaXMKZXNwZWNpYWxs eSBpbXBvcnRhbnQgZm9yIHByb3RlY3RpbmcgZHJpdmVyIGRvbWFpbnMgZnJv bSB0aGF0IGF0dGFjawp2ZWN0b3IuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMy NiAvIENWRS0yMDIyLTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4g R3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKaW5kZXggMjE3MDk2ZDkxYTlkLi40ZjI5NDM5YWQ4 MjUgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAt MjU0LDYgKzI1NCw4IEBAIHN0YXRpYyB2b2lkIGZyZWVfYnVmZmVyZWRfZGF0 YShzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqb3V0LAogCQl9CiAJfQogCisJZG9t YWluX21lbW9yeV9hZGRfbm9jaGsoY29ubi0+aWQsIC1vdXQtPmhkci5tc2cu bGVuIC0gc2l6ZW9mKG91dC0+aGRyKSk7CisKIAlpZiAob3V0LT5oZHIubXNn LnR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQpIHsKIAkJcmVxID0gb3V0LT5wZW5k LnJlcTsKIAkJaWYgKHJlcSkgewpAQCAtODQzLDExICs4NDUsMTQgQEAgdm9p ZCBzZW5kX3JlcGx5KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBlbnVtIHhz ZF9zb2NrbXNnX3R5cGUgdHlwZSwKIAliZGF0YS0+dGltZW91dF9tc2VjID0g MDsKIAliZGF0YS0+d2F0Y2hfZXZlbnQgPSBmYWxzZTsKIAotCWlmIChsZW4g PD0gREVGQVVMVF9CVUZGRVJfU0laRSkKKwlpZiAobGVuIDw9IERFRkFVTFRf QlVGRkVSX1NJWkUpIHsKIAkJYmRhdGEtPmJ1ZmZlciA9IGJkYXRhLT5kZWZh dWx0X2J1ZmZlcjsKLQllbHNlIHsKKwkJLyogRG9uJ3QgY2hlY2sgcXVvdGEs IHBhdGggbWlnaHQgYmUgdXNlZCBmb3IgcmV0dXJuaW5nIGVycm9yLiAqLwor CQlkb21haW5fbWVtb3J5X2FkZF9ub2Noayhjb25uLT5pZCwgbGVuICsgc2l6 ZW9mKGJkYXRhLT5oZHIpKTsKKwl9IGVsc2UgewogCQliZGF0YS0+YnVmZmVy ID0gdGFsbG9jX2FycmF5KGJkYXRhLCBjaGFyLCBsZW4pOwotCQlpZiAoIWJk YXRhLT5idWZmZXIpIHsKKwkJaWYgKCFiZGF0YS0+YnVmZmVyIHx8CisJCSAg ICBkb21haW5fbWVtb3J5X2FkZF9jaGsoY29ubi0+aWQsIGxlbiArIHNpemVv ZihiZGF0YS0+aGRyKSkpIHsKIAkJCXNlbmRfZXJyb3IoY29ubiwgRU5PTUVN KTsKIAkJCXJldHVybjsKIAkJfQpAQCAtOTEyLDYgKzkxNywxMSBAQCB2b2lk IHNlbmRfZXZlbnQoc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKnJlcSwgc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sCiAJCX0KIAl9CiAKKwlpZiAoZG9tYWluX21l bW9yeV9hZGRfY2hrKGNvbm4tPmlkLCBsZW4gKyBzaXplb2YoYmRhdGEtPmhk cikpKSB7CisJCXRhbGxvY19mcmVlKGJkYXRhKTsKKwkJcmV0dXJuOworCX0K KwogCWlmICh0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWMgJiYgZG9tYWluX2lz X3VucHJpdmlsZWdlZChjb25uKSkgewogCQliZGF0YS0+dGltZW91dF9tc2Vj ID0gZ2V0X25vd19tc2VjKCkgKyB0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWM7 CiAJCWlmICghY29ubi0+dGltZW91dF9tc2VjKQo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-13.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-13.patch" Content-Transfer-Encoding: base64 RnJvbSBmYTIwMTlmZjJjMDcyNWMwZDkzZjRiZTc5YTcyOTUxNWY3MGExYTQw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3Igd2F0Y2hlcwoKQWRkIHRoZSBtZW1vcnkgYWNj b3VudGluZyBmb3IgcmVnaXN0ZXJlZCB3YXRjaGVzLgoKV2hlbiBhIHNvY2tl dCBjb25uZWN0aW9uIGlzIGRlc3Ryb3llZCwgdGhlIGFzc29jaWF0ZWQgd2F0 Y2hlcyBhcmUKcmVtb3ZlZCwgdG9vLiBJbiBvcmRlciB0byBrZWVwIG1lbW9y eSBhY2NvdW50aW5nIGNvcnJlY3QgdGhlIHdhdGNoZXMKbXVzdCBiZSByZW1v dmVkIGV4cGxpY2l0bHkgdmlhIGEgY2FsbCBvZiBjb25uX2RlbGV0ZV9hbGxf d2F0Y2hlcygpIGZyb20KZGVzdHJveV9jb25uKCkuCgpUaGlzIGlzIHBhcnQg b2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6 IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6 IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggNGYyOTQzOWFkODI1Li5l Y2EwNGU3MzRhODMgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuYwpAQCAtNDA0LDYgKzQwNCw3IEBAIHN0YXRpYyBpbnQgZGVzdHJveV9j b25uKHZvaWQgKl9jb25uKQogCX0KIAogCWNvbm5fZnJlZV9idWZmZXJlZF9k YXRhKGNvbm4pOworCWNvbm5fZGVsZXRlX2FsbF93YXRjaGVzKGNvbm4pOwog CWxpc3RfZm9yX2VhY2hfZW50cnkocmVxLCAmY29ubi0+cmVmX2xpc3QsIGxp c3QpCiAJCXJlcS0+b25fcmVmX2xpc3QgPSBmYWxzZTsKIApkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmMgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYwppbmRleCBjNTBjMDU3NWYwZjEu LjcxMThjMzBlOGMzMiAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX3dhdGNoLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X3dhdGNoLmMKQEAgLTIyNCw3ICsyMjQsOCBAQCBpbnQgZG9fd2F0Y2goc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICpp bikKIAkJcmV0dXJuIEVOT01FTTsKIAl3YXRjaC0+bm9kZSA9IHRhbGxvY19z dHJkdXAod2F0Y2gsIHZlY1swXSk7CiAJd2F0Y2gtPnRva2VuID0gdGFsbG9j X3N0cmR1cCh3YXRjaCwgdmVjWzFdKTsKLQlpZiAoIXdhdGNoLT5ub2RlIHx8 ICF3YXRjaC0+dG9rZW4pIHsKKwlpZiAoIXdhdGNoLT5ub2RlIHx8ICF3YXRj aC0+dG9rZW4gfHwKKwkgICAgZG9tYWluX21lbW9yeV9hZGRfY2hrKGNvbm4t PmlkLCBzdHJsZW4odmVjWzBdKSArIHN0cmxlbih2ZWNbMV0pKSkgewogCQl0 YWxsb2NfZnJlZSh3YXRjaCk7CiAJCXJldHVybiBFTk9NRU07CiAJfQpAQCAt MjY1LDYgKzI2Niw4IEBAIGludCBkb191bndhdGNoKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJbGlzdF9m b3JfZWFjaF9lbnRyeSh3YXRjaCwgJmNvbm4tPndhdGNoZXMsIGxpc3QpIHsK IAkJaWYgKHN0cmVxKHdhdGNoLT5ub2RlLCBub2RlKSAmJiBzdHJlcSh3YXRj aC0+dG9rZW4sIHZlY1sxXSkpIHsKIAkJCWxpc3RfZGVsKCZ3YXRjaC0+bGlz dCk7CisJCQlkb21haW5fbWVtb3J5X2FkZF9ub2Noayhjb25uLT5pZCwgLXN0 cmxlbih3YXRjaC0+bm9kZSkgLQorCQkJCQkJCSAgc3RybGVuKHdhdGNoLT50 b2tlbikpOwogCQkJdGFsbG9jX2ZyZWUod2F0Y2gpOwogCQkJZG9tYWluX3dh dGNoX2RlYyhjb25uKTsKIAkJCXNlbmRfYWNrKGNvbm4sIFhTX1VOV0FUQ0gp OwpAQCAtMjgwLDYgKzI4Myw4IEBAIHZvaWQgY29ubl9kZWxldGVfYWxsX3dh dGNoZXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCiAKIAl3aGlsZSAoKHdh dGNoID0gbGlzdF90b3AoJmNvbm4tPndhdGNoZXMsIHN0cnVjdCB3YXRjaCwg bGlzdCkpKSB7CiAJCWxpc3RfZGVsKCZ3YXRjaC0+bGlzdCk7CisJCWRvbWFp bl9tZW1vcnlfYWRkX25vY2hrKGNvbm4tPmlkLCAtc3RybGVuKHdhdGNoLT5u b2RlKSAtCisJCQkJCQkgIHN0cmxlbih3YXRjaC0+dG9rZW4pKTsKIAkJdGFs bG9jX2ZyZWUod2F0Y2gpOwogCQlkb21haW5fd2F0Y2hfZGVjKGNvbm4pOwog CX0K --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-14.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-14.patch" Content-Transfer-Encoding: base64 RnJvbSAxNDVjODM3NWYzODJmZTg1MzVkNjMzODkxY2ZkYjQ3ZWMyOWE0OTBh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3Igbm9kZXMKCkFkZCB0aGUgbWVtb3J5IGFjY291 bnRpbmcgZm9yIFhlbnN0b3JlIG5vZGVzLiBJbiBvcmRlciB0byBtYWtlIHRo aXMKbm90IHRvbyBjb21wbGljYXRlZCBhbGxvdyBmb3Igc29tZSBzbG9wcGlu ZXNzIHdoZW4gd3JpdGluZyBub2Rlcy4gQW55CmhhcmQgcXVvdGEgdmlvbGF0 aW9uIHdpbGwgcmVzdWx0IGluIG5vIGZ1cnRoZXIgcmVxdWVzdHMgdG8gYmUg YWNjZXB0ZWQuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNiAvIENWRS0yMDIy LTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxs QGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKaW5kZXggZWNhMDRlNzM0YTgzLi4yYzBmOGZkOTliYmQgMTAwNjQ0Ci0t LSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtNDk2LDYgKzQ5Niwx MTcgQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZV9mZHMoaW50IHNvY2ssIGlu dCAqcF9zb2NrX3BvbGxmZF9pZHgsCiAJfQogfQogCitzdGF0aWMgdm9pZCBn ZXRfYWNjX2RhdGEoVERCX0RBVEEgKmtleSwgc3RydWN0IG5vZGVfYWNjb3Vu dF9kYXRhICphY2MpCit7CisJVERCX0RBVEEgb2xkX2RhdGE7CisJc3RydWN0 IHhzX3RkYl9yZWNvcmRfaGRyICpoZHI7CisKKwlpZiAoYWNjLT5tZW1vcnkg PCAwKSB7CisJCW9sZF9kYXRhID0gdGRiX2ZldGNoKHRkYl9jdHgsICprZXkp OworCQkvKiBObyBjaGVjayBmb3IgZXJyb3IsIGFzIHRoZSBub2RlIG1pZ2h0 IG5vdCBleGlzdC4gKi8KKwkJaWYgKG9sZF9kYXRhLmRwdHIgPT0gTlVMTCkg eworCQkJYWNjLT5tZW1vcnkgPSAwOworCQl9IGVsc2UgeworCQkJaGRyID0g KHZvaWQgKilvbGRfZGF0YS5kcHRyOworCQkJYWNjLT5tZW1vcnkgPSBvbGRf ZGF0YS5kc2l6ZTsKKwkJCWFjYy0+ZG9taWQgPSBoZHItPnBlcm1zWzBdLmlk OworCQl9CisJCXRhbGxvY19mcmVlKG9sZF9kYXRhLmRwdHIpOworCX0KK30K KworLyoKKyAqIFBlci10cmFuc2FjdGlvbiBub2RlcyBuZWVkIHRvIGJlIGFj Y291bnRlZCBmb3IgdGhlIHRyYW5zYWN0aW9uIG93bmVyLgorICogVGhvc2Ug bm9kZXMgYXJlIHN0b3JlZCBpbiB0aGUgZGF0YSBiYXNlIHdpdGggdGhlIHRy YW5zYWN0aW9uIGdlbmVyYXRpb24KKyAqIGNvdW50IHByZXBlbmRlZCAoZS5n LiAxMjMvbG9jYWwvZG9tYWluLy4uLikuIFNvIHRlc3RpbmcgZm9yIHRoZSBu b2RlJ3MKKyAqIGtleSBub3QgdG8gc3RhcnQgd2l0aCAiLyIgaXMgc3VmZmlj aWVudC4KKyAqLworc3RhdGljIHVuc2lnbmVkIGludCBnZXRfYWNjX2RvbWlk KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5LAorCQkJ CSAgdW5zaWduZWQgaW50IGRvbWlkKQoreworCXJldHVybiAoIWNvbm4gfHwg a2V5LT5kcHRyWzBdID09ICcvJykgPyBkb21pZCA6IGNvbm4tPmlkOworfQor CitpbnQgZG9fdGRiX3dyaXRlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBU REJfREFUQSAqa2V5LCBUREJfREFUQSAqZGF0YSwKKwkJIHN0cnVjdCBub2Rl X2FjY291bnRfZGF0YSAqYWNjLCBib29sIG5vX3F1b3RhX2NoZWNrKQorewor CXN0cnVjdCB4c190ZGJfcmVjb3JkX2hkciAqaGRyID0gKHZvaWQgKilkYXRh LT5kcHRyOworCXN0cnVjdCBub2RlX2FjY291bnRfZGF0YSBvbGRfYWNjID0g e307CisJdW5zaWduZWQgaW50IG9sZF9kb21pZCwgbmV3X2RvbWlkOworCWlu dCByZXQ7CisKKwlpZiAoIWFjYykKKwkJb2xkX2FjYy5tZW1vcnkgPSAtMTsK KwllbHNlCisJCW9sZF9hY2MgPSAqYWNjOworCisJZ2V0X2FjY19kYXRhKGtl eSwgJm9sZF9hY2MpOworCW9sZF9kb21pZCA9IGdldF9hY2NfZG9taWQoY29u biwga2V5LCBvbGRfYWNjLmRvbWlkKTsKKwluZXdfZG9taWQgPSBnZXRfYWNj X2RvbWlkKGNvbm4sIGtleSwgaGRyLT5wZXJtc1swXS5pZCk7CisKKwkvKgor CSAqIERvbid0IGNoZWNrIGZvciBFTk9FTlQsIGFzIHdlIHdhbnQgdG8gYmUg YWJsZSB0byBzd2l0Y2ggb3JwaGFuZWQKKwkgKiBub2RlcyB0byBuZXcgb3du ZXJzLgorCSAqLworCWlmIChvbGRfYWNjLm1lbW9yeSkKKwkJZG9tYWluX21l bW9yeV9hZGRfbm9jaGsob2xkX2RvbWlkLAorCQkJCQktb2xkX2FjYy5tZW1v cnkgLSBrZXktPmRzaXplKTsKKwlyZXQgPSBkb21haW5fbWVtb3J5X2FkZChu ZXdfZG9taWQsIGRhdGEtPmRzaXplICsga2V5LT5kc2l6ZSwKKwkJCQlub19x dW90YV9jaGVjayk7CisJaWYgKHJldCkgeworCQkvKiBFcnJvciBwYXRoLCBz byBubyBxdW90YSBjaGVjay4gKi8KKwkJaWYgKG9sZF9hY2MubWVtb3J5KQor CQkJZG9tYWluX21lbW9yeV9hZGRfbm9jaGsob2xkX2RvbWlkLAorCQkJCQkJ b2xkX2FjYy5tZW1vcnkgKyBrZXktPmRzaXplKTsKKwkJcmV0dXJuIHJldDsK Kwl9CisKKwkvKiBUREIgc2hvdWxkIHNldCBlcnJubywgYnV0IGRvZXNuJ3Qg ZXZlbiBzZXQgZWNvZGUgQUZBSUNULiAqLworCWlmICh0ZGJfc3RvcmUodGRi X2N0eCwgKmtleSwgKmRhdGEsIFREQl9SRVBMQUNFKSAhPSAwKSB7CisJCWRv bWFpbl9tZW1vcnlfYWRkX25vY2hrKG5ld19kb21pZCwgLWRhdGEtPmRzaXpl IC0ga2V5LT5kc2l6ZSk7CisJCS8qIEVycm9yIHBhdGgsIHNvIG5vIHF1b3Rh IGNoZWNrLiAqLworCQlpZiAob2xkX2FjYy5tZW1vcnkpCisJCQlkb21haW5f bWVtb3J5X2FkZF9ub2NoayhvbGRfZG9taWQsCisJCQkJCQlvbGRfYWNjLm1l bW9yeSArIGtleS0+ZHNpemUpOworCQllcnJubyA9IEVJTzsKKwkJcmV0dXJu IGVycm5vOworCX0KKworCWlmIChhY2MpIHsKKwkJLyogRG9uJ3QgdXNlIG5l d19kb21pZCwgYXMgaXQgbWlnaHQgYmUgYSB0cmFuc2FjdGlvbiBub2RlLiAq LworCQlhY2MtPmRvbWlkID0gaGRyLT5wZXJtc1swXS5pZDsKKwkJYWNjLT5t ZW1vcnkgPSBkYXRhLT5kc2l6ZTsKKwl9CisKKwlyZXR1cm4gMDsKK30KKwor aW50IGRvX3RkYl9kZWxldGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFRE Ql9EQVRBICprZXksCisJCSAgc3RydWN0IG5vZGVfYWNjb3VudF9kYXRhICph Y2MpCit7CisJc3RydWN0IG5vZGVfYWNjb3VudF9kYXRhIHRtcF9hY2M7CisJ dW5zaWduZWQgaW50IGRvbWlkOworCisJaWYgKCFhY2MpIHsKKwkJYWNjID0g JnRtcF9hY2M7CisJCWFjYy0+bWVtb3J5ID0gLTE7CisJfQorCisJZ2V0X2Fj Y19kYXRhKGtleSwgYWNjKTsKKworCWlmICh0ZGJfZGVsZXRlKHRkYl9jdHgs ICprZXkpKSB7CisJCWVycm5vID0gRUlPOworCQlyZXR1cm4gZXJybm87CisJ fQorCisJaWYgKGFjYy0+bWVtb3J5KSB7CisJCWRvbWlkID0gZ2V0X2FjY19k b21pZChjb25uLCBrZXksIGFjYy0+ZG9taWQpOworCQlkb21haW5fbWVtb3J5 X2FkZF9ub2Noayhkb21pZCwgLWFjYy0+bWVtb3J5IC0ga2V5LT5kc2l6ZSk7 CisJfQorCisJcmV0dXJuIDA7Cit9CisKIC8qCiAgKiBJZiBpdCBmYWlscywg cmV0dXJucyBOVUxMIGFuZCBzZXRzIGVycm5vLgogICogVGVtcG9yYXJ5IG1l bW9yeSBhbGxvY2F0aW9ucyB3aWxsIGJlIGRvbmUgd2l0aCBjdHguCkBAIC01 NDksOSArNjYwLDE1IEBAIHN0cnVjdCBub2RlICpyZWFkX25vZGUoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAogCS8qIFBl cm1pc3Npb25zIGFyZSBzdHJ1Y3QgeHNfcGVybWlzc2lvbnMuICovCiAJbm9k ZS0+cGVybXMucCA9IGhkci0+cGVybXM7CisJbm9kZS0+YWNjLmRvbWlkID0g bm9kZS0+cGVybXMucFswXS5pZDsKKwlub2RlLT5hY2MubWVtb3J5ID0gZGF0 YS5kc2l6ZTsKIAlpZiAoZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKGNvbm4s IG5vZGUpKQogCQlnb3RvIGVycm9yOwogCisJLyogSWYgb3duZXIgaXMgZ29u ZSByZXNldCBjdXJyZW50bHkgYWNjb3VudGVkIG1lbW9yeSBzaXplLiAqLwor CWlmIChub2RlLT5hY2MuZG9taWQgIT0gbm9kZS0+cGVybXMucFswXS5pZCkK KwkJbm9kZS0+YWNjLm1lbW9yeSA9IDA7CisKIAkvKiBEYXRhIGlzIGJpbmFy eSBibG9iICh1c3VhbGx5IGFzY2lpLCBubyBudWwpLiAqLwogCW5vZGUtPmRh dGEgPSBub2RlLT5wZXJtcy5wICsgaGRyLT5udW1fcGVybXM7CiAJLyogQ2hp bGRyZW4gaXMgc3RyaW5ncywgbnVsIHNlcGFyYXRlZC4gKi8KQEAgLTYxNSwx MiArNzMyLDkgQEAgaW50IHdyaXRlX25vZGVfcmF3KHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBUREJfREFUQSAqa2V5LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwK IAlwICs9IG5vZGUtPmRhdGFsZW47CiAJbWVtY3B5KHAsIG5vZGUtPmNoaWxk cmVuLCBub2RlLT5jaGlsZGxlbik7CiAKLQkvKiBUREIgc2hvdWxkIHNldCBl cnJubywgYnV0IGRvZXNuJ3QgZXZlbiBzZXQgZWNvZGUgQUZBSUNULiAqLwot CWlmICh0ZGJfc3RvcmUodGRiX2N0eCwgKmtleSwgZGF0YSwgVERCX1JFUExB Q0UpICE9IDApIHsKLQkJY29ycnVwdChjb25uLCAiV3JpdGUgb2YgJXMgZmFp bGVkIiwga2V5LT5kcHRyKTsKLQkJZXJybm8gPSBFSU87Ci0JCXJldHVybiBl cnJubzsKLQl9CisJaWYgKGRvX3RkYl93cml0ZShjb25uLCBrZXksICZkYXRh LCAmbm9kZS0+YWNjLCBub19xdW90YV9jaGVjaykpCisJCXJldHVybiBFSU87 CisKIAlyZXR1cm4gMDsKIH0KIApAQCAtMTExOSw3ICsxMjMzLDcgQEAgc3Rh dGljIHZvaWQgZGVsZXRlX25vZGVfc2luZ2xlKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSkKIAlpZiAoYWNjZXNzX25vZGUo Y29ubiwgbm9kZSwgTk9ERV9BQ0NFU1NfREVMRVRFLCAma2V5KSkKIAkJcmV0 dXJuOwogCi0JaWYgKHRkYl9kZWxldGUodGRiX2N0eCwga2V5KSAhPSAwKSB7 CisJaWYgKGRvX3RkYl9kZWxldGUoY29ubiwgJmtleSwgJm5vZGUtPmFjYykg IT0gMCkgewogCQljb3JydXB0KGNvbm4sICJDb3VsZCBub3QgZGVsZXRlICcl cyciLCBub2RlLT5uYW1lKTsKIAkJcmV0dXJuOwogCX0KQEAgLTExODIsNiAr MTI5Niw3IEBAIHN0YXRpYyBzdHJ1Y3Qgbm9kZSAqY29uc3RydWN0X25vZGUo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAkv KiBObyBjaGlsZHJlbiwgbm8gZGF0YSAqLwogCW5vZGUtPmNoaWxkcmVuID0g bm9kZS0+ZGF0YSA9IE5VTEw7CiAJbm9kZS0+Y2hpbGRsZW4gPSBub2RlLT5k YXRhbGVuID0gMDsKKwlub2RlLT5hY2MubWVtb3J5ID0gMDsKIAlub2RlLT5w YXJlbnQgPSBwYXJlbnQ7CiAJcmV0dXJuIG5vZGU7CiAKQEAgLTExOTAsMTcg KzEzMDUsMTcgQEAgc3RhdGljIHN0cnVjdCBub2RlICpjb25zdHJ1Y3Rfbm9k ZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAog CXJldHVybiBOVUxMOwogfQogCi1zdGF0aWMgdm9pZCBkZXN0cm95X25vZGVf cm0oc3RydWN0IG5vZGUgKm5vZGUpCitzdGF0aWMgdm9pZCBkZXN0cm95X25v ZGVfcm0oc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpu b2RlKQogewogCWlmIChzdHJlcShub2RlLT5uYW1lLCAiLyIpKQogCQljb3Jy dXB0KE5VTEwsICJEZXN0cm95aW5nIHJvb3Qgbm9kZSEiKTsKIAotCXRkYl9k ZWxldGUodGRiX2N0eCwgbm9kZS0+a2V5KTsKKwlkb190ZGJfZGVsZXRlKGNv bm4sICZub2RlLT5rZXksICZub2RlLT5hY2MpOwogfQogCiBzdGF0aWMgaW50 IGRlc3Ryb3lfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0 IG5vZGUgKm5vZGUpCiB7Ci0JZGVzdHJveV9ub2RlX3JtKG5vZGUpOworCWRl c3Ryb3lfbm9kZV9ybShjb25uLCBub2RlKTsKIAlkb21haW5fZW50cnlfZGVj KGNvbm4sIG5vZGUpOwogCiAJLyoKQEAgLTEyNTIsNyArMTM2Nyw3IEBAIHN0 YXRpYyBzdHJ1Y3Qgbm9kZSAqY3JlYXRlX25vZGUoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAkJLyogQWNjb3VudCBmb3Ig bmV3IG5vZGUgKi8KIAkJaWYgKGktPnBhcmVudCkgewogCQkJaWYgKGRvbWFp bl9lbnRyeV9pbmMoY29ubiwgaSkpIHsKLQkJCQlkZXN0cm95X25vZGVfcm0o aSk7CisJCQkJZGVzdHJveV9ub2RlX3JtKGNvbm4sIGkpOwogCQkJCXJldHVy biBOVUxMOwogCQkJfQogCQl9CkBAIC0yMDc1LDcgKzIxOTAsNyBAQCBzdGF0 aWMgaW50IGNsZWFuX3N0b3JlXyhUREJfQ09OVEVYVCAqdGRiLCBUREJfREFU QSBrZXksIFREQl9EQVRBIHZhbCwKIAlpZiAoIWhhc2h0YWJsZV9zZWFyY2go cmVhY2hhYmxlLCBuYW1lKSkgewogCQlsb2coImNsZWFuX3N0b3JlOiAnJXMn IGlzIG9ycGhhbmVkISIsIG5hbWUpOwogCQlpZiAocmVjb3ZlcnkpIHsKLQkJ CXRkYl9kZWxldGUodGRiLCBrZXkpOworCQkJZG9fdGRiX2RlbGV0ZShOVUxM LCAma2V5LCBOVUxMKTsKIAkJfQogCX0KIApkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmgKaW5kZXggNGU1MzA3MmU2MzdjLi41MjFiYzgwMzg0 ZTUgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAt MTQxLDYgKzE0MSwxMSBAQCBzdHJ1Y3Qgbm9kZV9wZXJtcyB7CiAJc3RydWN0 IHhzX3Blcm1pc3Npb25zICpwOwogfTsKIAorc3RydWN0IG5vZGVfYWNjb3Vu dF9kYXRhIHsKKwl1bnNpZ25lZCBpbnQgZG9taWQ7CisJaW50IG1lbW9yeTsJ CS8qIC0xIGlmIHVua25vd24gKi8KK307CisKIHN0cnVjdCBub2RlIHsKIAlj b25zdCBjaGFyICpuYW1lOwogCS8qIEtleSB1c2VkIHRvIHVwZGF0ZSBUREIg Ki8KQEAgLTE2Myw2ICsxNjgsOSBAQCBzdHJ1Y3Qgbm9kZSB7CiAJLyogQ2hp bGRyZW4sIGVhY2ggbnVsLXRlcm1pbmF0ZWQuICovCiAJdW5zaWduZWQgaW50 IGNoaWxkbGVuOwogCWNoYXIgKmNoaWxkcmVuOworCisJLyogQWxsb2NhdGlv biBpbmZvcm1hdGlvbiBmb3Igbm9kZSBjdXJyZW50bHkgaW4gc3RvcmUuICov CisJc3RydWN0IG5vZGVfYWNjb3VudF9kYXRhIGFjYzsKIH07CiAKIC8qIFJl dHVybiB0aGUgb25seSBhcmd1bWVudCBpbiB0aGUgaW5wdXQuICovCkBAIC0y NTgsNiArMjY2LDExIEBAIGV4dGVybiB4ZW5nbnR0YWJfaGFuZGxlICoqeGd0 X2hhbmRsZTsKIAogaW50IHJlbWVtYmVyX3N0cmluZyhzdHJ1Y3QgaGFzaHRh YmxlICpoYXNoLCBjb25zdCBjaGFyICpzdHIpOwogCitpbnQgZG9fdGRiX3dy aXRlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5LCBU REJfREFUQSAqZGF0YSwKKwkJIHN0cnVjdCBub2RlX2FjY291bnRfZGF0YSAq YWNjLCBib29sIG5vX3F1b3RhX2NoZWNrKTsKK2ludCBkb190ZGJfZGVsZXRl KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5LAorCQkg IHN0cnVjdCBub2RlX2FjY291bnRfZGF0YSAqYWNjKTsKKwogdm9pZCBjb25u X2ZyZWVfYnVmZmVyZWRfZGF0YShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7 CiAKICNlbmRpZiAvKiBfWEVOU1RPUkVEX0NPUkVfSCAqLwpkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwppbmRleCA3 NzhiN2U0MzljYjMuLmMxYmViNDBhM2Q1MSAxMDA2NDQKLS0tIGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKKysrIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKQEAgLTE1Myw2ICsx NTMsOSBAQCBzdHJ1Y3QgdHJhbnNhY3Rpb24KIAkvKiBMaXN0IG9mIGFsbCB0 cmFuc2FjdGlvbnMgYWN0aXZlIG9uIHRoaXMgY29ubmVjdGlvbi4gKi8KIAlz dHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7CiAKKwkvKiBDb25uZWN0aW9uIHRoaXMg dHJhbnNhY3Rpb24gaXMgYXNzb2NpYXRlZCB3aXRoLiAqLworCXN0cnVjdCBj b25uZWN0aW9uICpjb25uOworCiAJLyogQ29ubmVjdGlvbi1sb2NhbCBpZGVu dGlmaWVyIGZvciB0aGlzIHRyYW5zYWN0aW9uLiAqLwogCXVpbnQzMl90IGlk OwogCkBAIC0yOTIsNiArMjk1LDggQEAgaW50IGFjY2Vzc19ub2RlKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIAogCQlp bnRyb2R1Y2UgPSB0cnVlOwogCQlpLT50YV9ub2RlID0gZmFsc2U7CisJCS8q IGFjYy5tZW1vcnkgPCAwIG1lYW5zICJ1bmtub3duLCBnZXQgc2l6ZSBmcm9t IFREQiIuICovCisJCW5vZGUtPmFjYy5tZW1vcnkgPSAtMTsKIAogCQkvKgog CQkgKiBBZGRpdGlvbmFsIHRyYW5zYWN0aW9uLXNwZWNpZmljIG5vZGUgZm9y IHJlYWQgdHlwZS4gV2Ugb25seQpAQCAtNDE2LDExICs0MjEsMTEgQEAgc3Rh dGljIGludCBmaW5hbGl6ZV90cmFuc2FjdGlvbihzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwKIAkJCQkJZ290byBlcnI7CiAJCQkJaGRyID0gKHZvaWQgKilk YXRhLmRwdHI7CiAJCQkJaGRyLT5nZW5lcmF0aW9uID0gKytnZW5lcmF0aW9u OwotCQkJCXJldCA9IHRkYl9zdG9yZSh0ZGJfY3R4LCBrZXksIGRhdGEsCi0J CQkJCQlUREJfUkVQTEFDRSk7CisJCQkJcmV0ID0gZG9fdGRiX3dyaXRlKGNv bm4sICZrZXksICZkYXRhLCBOVUxMLAorCQkJCQkJICAgdHJ1ZSk7CiAJCQkJ dGFsbG9jX2ZyZWUoZGF0YS5kcHRyKTsKIAkJCX0gZWxzZSB7Ci0JCQkJcmV0 ID0gdGRiX2RlbGV0ZSh0ZGJfY3R4LCBrZXkpOworCQkJCXJldCA9IGRvX3Rk Yl9kZWxldGUoY29ubiwgJmtleSwgTlVMTCk7CiAJCQl9CiAJCQlpZiAocmV0 KQogCQkJCWdvdG8gZXJyOwpAQCAtNDMxLDcgKzQzNiw3IEBAIHN0YXRpYyBp bnQgZmluYWxpemVfdHJhbnNhY3Rpb24oc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sCiAJCQl9CiAJCX0KIAotCQlpZiAoaS0+dGFfbm9kZSAmJiB0ZGJfZGVs ZXRlKHRkYl9jdHgsIHRhX2tleSkpCisJCWlmIChpLT50YV9ub2RlICYmIGRv X3RkYl9kZWxldGUoY29ubiwgJnRhX2tleSwgTlVMTCkpCiAJCQlnb3RvIGVy cjsKIAkJbGlzdF9kZWwoJmktPmxpc3QpOwogCQl0YWxsb2NfZnJlZShpKTsK QEAgLTQ1OSw3ICs0NjQsNyBAQCBzdGF0aWMgaW50IGRlc3Ryb3lfdHJhbnNh Y3Rpb24odm9pZCAqX3RyYW5zYWN0aW9uKQogCQkJCQkJCSAgICAgICBpLT5u b2RlKTsKIAkJCWlmICh0cmFuc19uYW1lKSB7CiAJCQkJc2V0X3RkYl9rZXko dHJhbnNfbmFtZSwgJmtleSk7Ci0JCQkJdGRiX2RlbGV0ZSh0ZGJfY3R4LCBr ZXkpOworCQkJCWRvX3RkYl9kZWxldGUodHJhbnMtPmNvbm4sICZrZXksIE5V TEwpOwogCQkJfQogCQl9CiAJCWxpc3RfZGVsKCZpLT5saXN0KTsKQEAgLTUw Myw2ICs1MDgsNyBAQCBpbnQgZG9fdHJhbnNhY3Rpb25fc3RhcnQoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikK IAogCUlOSVRfTElTVF9IRUFEKCZ0cmFucy0+YWNjZXNzZWQpOwogCUlOSVRf TElTVF9IRUFEKCZ0cmFucy0+Y2hhbmdlZF9kb21haW5zKTsKKwl0cmFucy0+ Y29ubiA9IGNvbm47CiAJdHJhbnMtPmZhaWwgPSBmYWxzZTsKIAl0cmFucy0+ Z2VuZXJhdGlvbiA9ICsrZ2VuZXJhdGlvbjsKIAo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-15.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-15.patch" Content-Transfer-Encoding: base64 RnJvbSA3Yzg2ODhmMTJiOGE2NGM3N2NiNTA4NDg4OTdmYzlhYzY2Y2Y0MjYw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBleHBv cnRzIGZvciBxdW90YSB2YXJpYWJsZXMKClNvbWUgcXVvdGEgdmFyaWFibGVz IGFyZSBub3QgZXhwb3J0ZWQgdmlhIGhlYWRlciBmaWxlcy4KClRoaXMgaXMg cGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jv c3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmgKaW5kZXggNTIxYmM4MDM4NGU1Li41YWJmMDZjMjFjOTggMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMjMxLDYg KzIzMSwxMSBAQCBleHRlcm4gVERCX0NPTlRFWFQgKnRkYl9jdHg7CiBleHRl cm4gaW50IGRvbTBfZG9taWQ7CiBleHRlcm4gaW50IGRvbTBfZXZlbnQ7CiBl eHRlcm4gaW50IHByaXZfZG9taWQ7CitleHRlcm4gaW50IHF1b3RhX25iX3dh dGNoX3Blcl9kb21haW47CitleHRlcm4gaW50IHF1b3RhX21heF90cmFuc2Fj dGlvbjsKK2V4dGVybiBpbnQgcXVvdGFfbWF4X2VudHJ5X3NpemU7CitleHRl cm4gaW50IHF1b3RhX25iX3Blcm1zX3Blcl9ub2RlOworZXh0ZXJuIGludCBx dW90YV9tYXhfcGF0aF9sZW47CiBleHRlcm4gaW50IHF1b3RhX25iX2VudHJ5 X3Blcl9kb21haW47CiBleHRlcm4gaW50IHF1b3RhX3JlcV9vdXRzdGFuZGlu ZzsKIGV4dGVybiBpbnQgcXVvdGFfdHJhbnNfbm9kZXM7CmRpZmYgLS1naXQg YS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4IGMx YmViNDBhM2Q1MS4uNmUyOTExOGM4MDBkIDEwMDY0NAotLS0gYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpAQCAtMTc1LDcgKzE3 NSw2IEBAIHN0cnVjdCB0cmFuc2FjdGlvbgogCWJvb2wgZmFpbDsKIH07CiAK LWV4dGVybiBpbnQgcXVvdGFfbWF4X3RyYW5zYWN0aW9uOwogdWludDY0X3Qg Z2VuZXJhdGlvbjsKIAogc3RhdGljIHZvaWQgc2V0X3RkYl9rZXkoY29uc3Qg Y2hhciAqbmFtZSwgVERCX0RBVEEgKmtleSkKZGlmZiAtLWdpdCBhL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3dhdGNoLmMKaW5kZXggNzExOGMzMGU4YzMyLi4xOWQwZmIw MWIxYzQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93 YXRjaC5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5j CkBAIC0zMSw4ICszMSw2IEBACiAjaW5jbHVkZSAieGVuc3RvcmVkX2RvbWFp bi5oIgogI2luY2x1ZGUgInhlbnN0b3JlZF90cmFuc2FjdGlvbi5oIgogCi1l eHRlcm4gaW50IHF1b3RhX25iX3dhdGNoX3Blcl9kb21haW47Ci0KIHN0cnVj dCB3YXRjaAogewogCS8qIFdhdGNoZXMgb24gdGhpcyBjb25uZWN0aW9uICov Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.13-xenstored-16.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.13-xenstored-16.patch" Content-Transfer-Encoding: base64 RnJvbSAzY2MyMzZkM2Y2MmMwMTVhOTVkM2Q2ZGM1NzhhZDdmY2ZhMTk2MDdh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBjb250 cm9sIGNvbW1hbmQgZm9yIHNldHRpbmcgYW5kIHNob3dpbmcgcXVvdGEKCkFk ZCBhIHhlbnN0b3JlLWNvbnRyb2wgY29tbWFuZCAicXVvdGEiIHRvOgotIHNo b3cgY3VycmVudCBxdW90YSBzZXR0aW5ncwotIGNoYW5nZSBxdW90YSBzZXR0 aW5ncwotIHNob3cgY3VycmVudCBxdW90YSByZWxhdGVkIHZhbHVlcyBvZiBh IGRvbWFpbgoKTm90ZSB0aGF0IGluIHRoZSBjYXNlIHRoZSBuZXcgcXVvdGEg aXMgbG93ZXIgdGhhbiBleGlzdGluZyBvbmUsClhlbnN0b3JlZCBtYXkgY29u dGludWUgdG8gaGFuZGxlIHJlcXVlc3RzIGZyb20gYSBkb21haW4gZXhjZWVk aW5nIHRoZQpuZXcgbGltaXQgKGRlcGVuZHMgb24gd2hpY2ggb25lIGhhcyBi ZWVuIGJyb2tlbikgYW5kIHRoZSBhbW91bnQgb2YKcmVzb3VyY2UgdXNlZCB3 aWxsIG5vdCBjaGFuZ2UuIEhvd2V2ZXIgdGhlIGRvbWFpbiB3aWxsIG5vdCBi ZSBhYmxlIHRvCmNyZWF0ZSBtb3JlIHJlc291cmNlIChhc3NvY2lhdGVkIHRv IHRoZSBxdW90YSkgdW50aWwgaXQgaXMgYmFjayB0byBiZWxvdwp0aGUgbGlt aXQuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNi4KClJlcG9ydGVkLWJ5OiBK dWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgpTaWduZWQtb2ZmLWJ5 OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJldmlld2VkLWJ5 OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdp dCBhL2RvY3MvbWlzYy94ZW5zdG9yZS50eHQgYi9kb2NzL21pc2MveGVuc3Rv cmUudHh0CmluZGV4IDMyOTY5ZWIzZmVjZC4uMGRiYWM0NDJkNzlkIDEwMDY0 NAotLS0gYS9kb2NzL21pc2MveGVuc3RvcmUudHh0CisrKyBiL2RvY3MvbWlz Yy94ZW5zdG9yZS50eHQKQEAgLTM0Niw2ICszNDYsMTcgQEAgQ09OVFJPTAkJ CTxjb21tYW5kPnxbPHBhcmFtZXRlcnM+fF0KIAlwcmludHw8c3RyaW5nPgog CQlwcmludCA8c3RyaW5nPiB0byBzeXNsb2cgKHhlbnN0b3JlIHJ1bnMgYXMg ZGFlbW9uKSBvcgogCQl0byBjb25zb2xlICh4ZW5zdG9yZSBydW5zIGFzIHN0 dWJkb20pCisJcXVvdGF8W3NldCA8bmFtZT4gPHZhbD58PGRvbWlkPl0KKwkJ d2l0aG91dCBwYXJhbWV0ZXJzOiBwcmludCB0aGUgY3VycmVudCBxdW90YSBz ZXR0aW5ncworCQl3aXRoICJzZXQgPG5hbWU+IDx2YWw+Ijogc2V0IHRoZSBx dW90YSA8bmFtZT4gdG8gbmV3IHZhbHVlCisJCTx2YWw+IChUaGUgYWRtaW4g c2hvdWxkIG1ha2Ugc3VyZSBhbGwgdGhlIGRvbWFpbiB1c2FnZSBpcworCQli ZWxvdyB0aGUgcXVvdGEuIElmIGl0IGlzIG5vdCwgdGhlbiBYZW5zdG9yZWQg bWF5IGNvbnRpbnVlIHRvCisJCWhhbmRsZSByZXF1ZXN0cyBmcm9tIHRoZSBk b21haW4gYXMgbG9uZyBhcyB0aGUgcmVzb3VyY2UKKwkJdmlvbGF0aW5nIHRo ZSBuZXcgcXVvdGEgc2V0dGluZyBpc24ndCBpbmNyZWFzZWQgZnVydGhlcikK KwkJd2l0aCAiPGRvbWlkPiI6IHByaW50IHF1b3RhIHJlbGF0ZWQgYWNjb3Vu dGluZyBkYXRhIGZvcgorCQl0aGUgZG9tYWluIDxkb21pZD4KKwlxdW90YS1z b2Z0fFtzZXQgPG5hbWU+IDx2YWw+XQorCQlsaWtlIHRoZSAicXVvdGEiIGNv bW1hbmQsIGJ1dCBmb3Igc29mdC1xdW90YS4KIAloZWxwCQkJPHN1cHBvcnRl ZC1jb21tYW5kcz4KIAkJcmV0dXJuIGxpc3Qgb2Ygc3VwcG9ydGVkIGNvbW1h bmRzIGZvciBDT05UUk9MCiAKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb250cm9sLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29udHJvbC5jCmluZGV4IDcxNWUwZDJhOWUwMy4uNDU0ZmU5ZDVhYjE4 IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJv bC5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmMK QEAgLTE5LDYgKzE5LDcgQEAKICNpbmNsdWRlIDxlcnJuby5oPgogI2luY2x1 ZGUgPHN0ZGFyZy5oPgogI2luY2x1ZGUgPHN0ZGlvLmg+CisjaW5jbHVkZSA8 c3RkbGliLmg+CiAjaW5jbHVkZSA8c3RyaW5nLmg+CiAKICNpbmNsdWRlICJ1 dGlscy5oIgpAQCAtNzcsNiArNzgsMTE0IEBAIHN0YXRpYyBpbnQgZG9fY29u dHJvbF9sb2dmaWxlKHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sCiAJcmV0dXJuIDA7CiB9CiAKK3N0cnVjdCBxdW90YSB7CisJY29uc3Qg Y2hhciAqbmFtZTsKKwlpbnQgKnF1b3RhOworCWNvbnN0IGNoYXIgKmRlc2Ny OworfTsKKworc3RhdGljIGNvbnN0IHN0cnVjdCBxdW90YSBoYXJkX3F1b3Rh c1tdID0geworCXsgIm5vZGVzIiwgJnF1b3RhX25iX2VudHJ5X3Blcl9kb21h aW4sICJOb2RlcyBwZXIgZG9tYWluIiB9LAorCXsgIndhdGNoZXMiLCAmcXVv dGFfbmJfd2F0Y2hfcGVyX2RvbWFpbiwgIldhdGNoZXMgcGVyIGRvbWFpbiIg fSwKKwl7ICJ0cmFuc2FjdGlvbnMiLCAmcXVvdGFfbWF4X3RyYW5zYWN0aW9u LCAiVHJhbnNhY3Rpb25zIHBlciBkb21haW4iIH0sCisJeyAib3V0c3RhbmRp bmciLCAmcXVvdGFfcmVxX291dHN0YW5kaW5nLAorCQkiT3V0c3RhbmRpbmcg cmVxdWVzdHMgcGVyIGRvbWFpbiIgfSwKKwl7ICJ0cmFuc2FjdGlvbi1ub2Rl cyIsICZxdW90YV90cmFuc19ub2RlcywKKwkJIk1heC4gbnVtYmVyIG9mIGFj Y2Vzc2VkIG5vZGVzIHBlciB0cmFuc2FjdGlvbiIgfSwKKwl7ICJtZW1vcnki LCAmcXVvdGFfbWVtb3J5X3Blcl9kb21haW5faGFyZCwKKwkJIlRvdGFsIFhl bnN0b3JlIG1lbW9yeSBwZXIgZG9tYWluIChlcnJvciBsZXZlbCkiIH0sCisJ eyAibm9kZS1zaXplIiwgJnF1b3RhX21heF9lbnRyeV9zaXplLCAiTWF4LiBz aXplIG9mIGEgbm9kZSIgfSwKKwl7ICJwZXJtaXNzaW9ucyIsICZxdW90YV9u Yl9wZXJtc19wZXJfbm9kZSwKKwkJIk1heC4gbnVtYmVyIG9mIHBlcm1pc3Np b25zIHBlciBub2RlIiB9LAorCXsgTlVMTCwgTlVMTCwgTlVMTCB9Cit9Owor CitzdGF0aWMgY29uc3Qgc3RydWN0IHF1b3RhIHNvZnRfcXVvdGFzW10gPSB7 CisJeyAibWVtb3J5IiwgJnF1b3RhX21lbW9yeV9wZXJfZG9tYWluX3NvZnQs CisJCSJUb3RhbCBYZW5zdG9yZSBtZW1vcnkgcGVyIGRvbWFpbiAod2Fybmlu ZyBsZXZlbCkiIH0sCisJeyBOVUxMLCBOVUxMLCBOVUxMIH0KK307CisKK3N0 YXRpYyBpbnQgcXVvdGFfc2hvd19jdXJyZW50KGNvbnN0IHZvaWQgKmN0eCwg c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCQkgICAgICBjb25zdCBzdHJ1 Y3QgcXVvdGEgKnF1b3RhcykKK3sKKwljaGFyICpyZXNwOworCXVuc2lnbmVk IGludCBpOworCisJcmVzcCA9IHRhbGxvY19zdHJkdXAoY3R4LCAiUXVvdGEg c2V0dGluZ3M6XG4iKTsKKwlpZiAoIXJlc3ApCisJCXJldHVybiBFTk9NRU07 CisKKwlmb3IgKGkgPSAwOyBxdW90YXNbaV0ucXVvdGE7IGkrKykgeworCQly ZXNwID0gdGFsbG9jX2FzcHJpbnRmX2FwcGVuZChyZXNwLCAiJS0xN3M6ICU4 ZCAlc1xuIiwKKwkJCQkJICAgICAgcXVvdGFzW2ldLm5hbWUsICpxdW90YXNb aV0ucXVvdGEsCisJCQkJCSAgICAgIHF1b3Rhc1tpXS5kZXNjcik7CisJCWlm ICghcmVzcCkKKwkJCXJldHVybiBFTk9NRU07CisJfQorCisJc2VuZF9yZXBs eShjb25uLCBYU19DT05UUk9MLCByZXNwLCBzdHJsZW4ocmVzcCkgKyAxKTsK KworCXJldHVybiAwOworfQorCitzdGF0aWMgaW50IHF1b3RhX3NldChjb25z dCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgICAg IGNoYXIgKip2ZWMsIGludCBudW0sIGNvbnN0IHN0cnVjdCBxdW90YSAqcXVv dGFzKQoreworCXVuc2lnbmVkIGludCBpOworCWludCB2YWw7CisKKwlpZiAo bnVtICE9IDIpCisJCXJldHVybiBFSU5WQUw7CisKKwl2YWwgPSBhdG9pKHZl Y1sxXSk7CisJaWYgKHZhbCA8IDEpCisJCXJldHVybiBFSU5WQUw7CisKKwlm b3IgKGkgPSAwOyBxdW90YXNbaV0ucXVvdGE7IGkrKykgeworCQlpZiAoIXN0 cmNtcCh2ZWNbMF0sIHF1b3Rhc1tpXS5uYW1lKSkgeworCQkJKnF1b3Rhc1tp XS5xdW90YSA9IHZhbDsKKwkJCXNlbmRfYWNrKGNvbm4sIFhTX0NPTlRST0wp OworCQkJcmV0dXJuIDA7CisJCX0KKwl9CisKKwlyZXR1cm4gRUlOVkFMOwor fQorCitzdGF0aWMgaW50IHF1b3RhX2dldChjb25zdCB2b2lkICpjdHgsIHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgICAgIGNoYXIgKip2ZWMsIGlu dCBudW0pCit7CisJaWYgKG51bSAhPSAxKQorCQlyZXR1cm4gRUlOVkFMOwor CisJcmV0dXJuIGRvbWFpbl9nZXRfcXVvdGEoY3R4LCBjb25uLCBhdG9pKHZl Y1swXSkpOworfQorCitzdGF0aWMgaW50IGRvX2NvbnRyb2xfcXVvdGEodm9p ZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJCSAgICBjaGFy ICoqdmVjLCBpbnQgbnVtKQoreworCWlmIChudW0gPT0gMCkKKwkJcmV0dXJu IHF1b3RhX3Nob3dfY3VycmVudChjdHgsIGNvbm4sIGhhcmRfcXVvdGFzKTsK KworCWlmICghc3RyY21wKHZlY1swXSwgInNldCIpKQorCQlyZXR1cm4gcXVv dGFfc2V0KGN0eCwgY29ubiwgdmVjICsgMSwgbnVtIC0gMSwgaGFyZF9xdW90 YXMpOworCisJcmV0dXJuIHF1b3RhX2dldChjdHgsIGNvbm4sIHZlYywgbnVt KTsKK30KKworc3RhdGljIGludCBkb19jb250cm9sX3F1b3RhX3Modm9pZCAq Y3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJCSAgICAgIGNoYXIg Kip2ZWMsIGludCBudW0pCit7CisJaWYgKG51bSA9PSAwKQorCQlyZXR1cm4g cXVvdGFfc2hvd19jdXJyZW50KGN0eCwgY29ubiwgc29mdF9xdW90YXMpOwor CisJaWYgKCFzdHJjbXAodmVjWzBdLCAic2V0IikpCisJCXJldHVybiBxdW90 YV9zZXQoY3R4LCBjb25uLCB2ZWMgKyAxLCBudW0gLSAxLCBzb2Z0X3F1b3Rh cyk7CisKKwlyZXR1cm4gRUlOVkFMOworfQorCiBzdGF0aWMgaW50IGRvX2Nv bnRyb2xfbWVtcmVwb3J0KHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sCiAJCQkJY2hhciAqKnZlYywgaW50IG51bSkKIHsKQEAgLTEzNiw2 ICsyNDUsOCBAQCBzdGF0aWMgc3RydWN0IGNtZF9zIGNtZHNbXSA9IHsKIAl7 ICJsb2dmaWxlIiwgZG9fY29udHJvbF9sb2dmaWxlLCAiPGZpbGU+IiB9LAog CXsgIm1lbXJlcG9ydCIsIGRvX2NvbnRyb2xfbWVtcmVwb3J0LCAiWzxmaWxl Pl0iIH0sCiAJeyAicHJpbnQiLCBkb19jb250cm9sX3ByaW50LCAiPHN0cmlu Zz4iIH0sCisJeyAicXVvdGEiLCBkb19jb250cm9sX3F1b3RhLCAiW3NldCA8 bmFtZT4gPHZhbD58PGRvbWlkPl0iIH0sCisJeyAicXVvdGEtc29mdCIsIGRv X2NvbnRyb2xfcXVvdGFfcywgIltzZXQgPG5hbWU+IDx2YWw+XSIgfSwKIAl7 ICJoZWxwIiwgZG9fY29udHJvbF9oZWxwLCAiIiB9LAogfTsKIApkaWZmIC0t Z2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IDExMmZiNDU3 NTgxZS4uZjQ1ODMxNGM4ZTAxIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2RvbWFpbi5jCkBAIC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSAi eGVuc3RvcmVkX2RvbWFpbi5oIgogI2luY2x1ZGUgInhlbnN0b3JlZF90cmFu c2FjdGlvbi5oIgogI2luY2x1ZGUgInhlbnN0b3JlZF93YXRjaC5oIgorI2lu Y2x1ZGUgInhlbnN0b3JlZF9jb250cm9sLmgiCiAKICNpbmNsdWRlIDx4ZW5l dnRjaG4uaD4KICNpbmNsdWRlIDx4ZW5jdHJsLmg+CkBAIC0zNTIsNiArMzUz LDM4IEBAIHN0YXRpYyBzdHJ1Y3QgZG9tYWluICpmaW5kX2RvbWFpbl9zdHJ1 Y3QodW5zaWduZWQgaW50IGRvbWlkKQogCXJldHVybiBOVUxMOwogfQogCitp bnQgZG9tYWluX2dldF9xdW90YShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBj b25uZWN0aW9uICpjb25uLAorCQkgICAgIHVuc2lnbmVkIGludCBkb21pZCkK K3sKKwlzdHJ1Y3QgZG9tYWluICpkID0gZmluZF9kb21haW5fc3RydWN0KGRv bWlkKTsKKwljaGFyICpyZXNwOworCWludCB0YTsKKworCWlmICghZCkKKwkJ cmV0dXJuIEVOT0VOVDsKKworCXRhID0gZC0+Y29ubiA/IGQtPmNvbm4tPnRy YW5zYWN0aW9uX3N0YXJ0ZWQgOiAwOworCXJlc3AgPSB0YWxsb2NfYXNwcmlu dGYoY3R4LCAiRG9tYWluICV1OlxuIiwgZG9taWQpOworCWlmICghcmVzcCkK KwkJcmV0dXJuIEVOT01FTTsKKworI2RlZmluZSBlbnQodCwgZSkgXAorCXJl c3AgPSB0YWxsb2NfYXNwcmludGZfYXBwZW5kKHJlc3AsICIlLTE2czogJThk XG4iLCAjdCwgZSk7IFwKKwlpZiAoIXJlc3ApIHJldHVybiBFTk9NRU0KKwor CWVudChub2RlcywgZC0+bmJlbnRyeSk7CisJZW50KHdhdGNoZXMsIGQtPm5i d2F0Y2gpOworCWVudCh0cmFuc2FjdGlvbnMsIHRhKTsKKwllbnQob3V0c3Rh bmRpbmcsIGQtPm5ib3V0c3RhbmRpbmcpOworCWVudChtZW1vcnksIGQtPm1l bW9yeSk7CisKKyN1bmRlZiBlbnQKKworCXNlbmRfcmVwbHkoY29ubiwgWFNf Q09OVFJPTCwgcmVzcCwgc3RybGVuKHJlc3ApICsgMSk7CisKKwlyZXR1cm4g MDsKK30KKwogc3RhdGljIHN0cnVjdCBkb21haW4gKmFsbG9jX2RvbWFpbih2 b2lkICpjb250ZXh0LCB1bnNpZ25lZCBpbnQgZG9taWQpCiB7CiAJc3RydWN0 IGRvbWFpbiAqZG9tYWluOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2RvbWFpbi5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2RvbWFpbi5oCmluZGV4IDNhOGM2YmFiNDhiYS4uZTAxM2E5OTkxY2E4IDEw MDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgK KysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oCkBAIC05 MCw2ICs5MCw4IEBAIGludCBkb21haW5fd2F0Y2goc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4pOwogdm9pZCBkb21haW5fb3V0c3RhbmRpbmdfaW5jKHN0cnVj dCBjb25uZWN0aW9uICpjb25uKTsKIHZvaWQgZG9tYWluX291dHN0YW5kaW5n X2RlYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7CiB2b2lkIGRvbWFpbl9v dXRzdGFuZGluZ19kb21pZF9kZWModW5zaWduZWQgaW50IGRvbWlkKTsKK2lu dCBkb21haW5fZ2V0X3F1b3RhKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCisJCSAgICAgdW5zaWduZWQgaW50IGRvbWlkKTsK IAogLyogU3BlY2lhbCBub2RlIHBlcm1pc3Npb24gaGFuZGxpbmcuICovCiBp bnQgc2V0X3Blcm1zX3NwZWNpYWwoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IGNvbnN0IGNoYXIgKm5hbWUsCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-oxenstored-01.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-oxenstored-01.patch" Content-Transfer-Encoding: base64 RnJvbSBhYTY1ZTU3MmI1NWVlNTE1ZjAxZDdlMDgwNDRjMmIwZjBhMTVhMjkz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IFN5bmNocm9uaXNlIGRlZmF1 bHRzIHdpdGggb3hlbnN0b3JlLmNvbmYuaW4KTUlNRS1WZXJzaW9uOiAxLjAK Q29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRl bnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCldlIGN1cnJlbnRseSBoYXZl IDIgZGlmZmVyZW50IHNldCBvZiBkZWZhdWx0cyBpbiB1cHN0cmVhbSBYZW4g Z2l0IHRyZWU6CiogZGVmaW5lZCBpbiB0aGUgc291cmNlIGNvZGUsIG9ubHkg dXNlZCBpZiB0aGVyZSBpcyBubyBjb25maWcgZmlsZQoqIGRlZmluZWQgaW4g dGhlIG94ZW5zdG9yZWQuY29uZi5pbiB1cHN0cmVhbSBYZW4KCkFuIG94ZW5z dG9yZWQuY29uZiBmaWxlIGlzIG5vdCBtYW5kYXRvcnksIGFuZCBpZiBtaXNz aW5nLCBtYXhyZXF1ZXN0cyBpbgpwYXJ0aWN1bGFyIGhhcyBhbiB1bnNhZmUg ZGVmYXVsdC4KClJlc3luYyB0aGUgZGVmYXVsdHMgZnJvbSBveGVuc3RvcmVk LmNvbmYuaW4gaW50byB0aGUgc291cmNlIGNvZGUuCgpUaGlzIGlzIHBhcnQg b2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzE2LgoKUmVwb3J0ZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6 IEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2Vk LWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJp eC5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Rl ZmluZS5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKaW5k ZXggZjU3NDM5N2E0YzBiLi45NmMxMjVhOTY5ZGEgMTAwNjQ0Ci0tLSBhL3Rv b2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKKysrIGIvdG9vbHMvb2Nh bWwveGVuc3RvcmVkL2RlZmluZS5tbApAQCAtMjIsOSArMjIsOSBAQCBsZXQg eHNfZGFlbW9uX3NvY2tldF9ybyA9IFBhdGhzLnhlbl9ydW5fc3RvcmVkIF4g Ii9zb2NrZXRfcm8iCiAKIGxldCBkZWZhdWx0X2NvbmZpZ19kaXIgPSBQYXRo cy54ZW5fY29uZmlnX2RpcgogCi1sZXQgbWF4d2F0Y2ggPSByZWYgKDUwKQot bGV0IG1heHRyYW5zYWN0aW9uID0gcmVmICgyMCkKLWxldCBtYXhyZXF1ZXN0 cyA9IHJlZiAoLTEpICAgKCogbWF4aW11bSByZXF1ZXN0cyBwZXIgdHJhbnNh Y3Rpb24gKikKK2xldCBtYXh3YXRjaCA9IHJlZiAoMTAwKQorbGV0IG1heHRy YW5zYWN0aW9uID0gcmVmICgxMCkKK2xldCBtYXhyZXF1ZXN0cyA9IHJlZiAo MTAyNCkgICAoKiBtYXhpbXVtIHJlcXVlc3RzIHBlciB0cmFuc2FjdGlvbiAq KQogCiBsZXQgY29uZmxpY3RfYnVyc3RfbGltaXQgPSByZWYgNS4wCiBsZXQg Y29uZmxpY3RfbWF4X2hpc3Rvcnlfc2Vjb25kcyA9IHJlZiAwLjA1CmRpZmYg LS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvcXVvdGEubWwgYi90b29s cy9vY2FtbC94ZW5zdG9yZWQvcXVvdGEubWwKaW5kZXggYWJjYWM5MTI4MDVh Li42ZTNkNjQwMWFlODkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0 b3JlZC9xdW90YS5tbAorKysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvcXVv dGEubWwKQEAgLTIwLDggKzIwLDggQEAgZXhjZXB0aW9uIFRyYW5zYWN0aW9u X29wZW5lZAogCiBsZXQgd2FybiBmbXQgPSBMb2dnaW5nLndhcm4gInF1b3Rh IiBmbXQKIGxldCBhY3RpdmF0ZSA9IHJlZiB0cnVlCi1sZXQgbWF4ZW50ID0g cmVmICgxMDAwMCkKLWxldCBtYXhzaXplID0gcmVmICg0MDk2KQorbGV0IG1h eGVudCA9IHJlZiAoMTAwMCkKK2xldCBtYXhzaXplID0gcmVmICgyMDQ4KQog CiB0eXBlIHQgPSB7CiAJbWF4ZW50OiBpbnQ7ICAgICAgICAgICAgICAgKCog bWF4IGVudGl0aWVzIHBlciBkb21VICopCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-oxenstored-02.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-oxenstored-02.patch" Content-Transfer-Encoding: base64 RnJvbSAwNTk0ZTEzMmYxNmY3ODBkN2E3YzJhMjA2OGU3YzI3OGYwNzliYjY5 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogVGh1LCAyOCBKdWwgMjAyMiAxNzowODoxNSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IENoZWNrIGZvciBtYXhyZXF1 ZXN0cyBiZWZvcmUgcGVyZm9ybWluZwogb3BlcmF0aW9ucwpNSU1FLVZlcnNp b246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRG LTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKUHJldmlvdXNs eSB3ZSdkIHBlcmZvcm0gdGhlIG9wZXJhdGlvbiwgcmVjb3JkIHRoZSB1cGRh dGVkIHRyZWUgaW4gdGhlCnRyYW5zYWN0aW9uIHJlY29yZCwgdGhlbiB0cnkg dG8gaW5zZXJ0IGEgd2F0Y2hvcCBwYXRoIGFuZCB0aGUgcmVwbHkgcGFja2V0 LgoKSWYgd2UgZXhjZWVkZWQgbWF4IHJlcXVlc3RzIHdlIHdvdWxkJ3ZlIHJl dHVybmVkIEVRVU9UQSwgYnV0IHN0aWxsOgoqIGhhdmUgcGVyZm9ybWVkIHRo ZSBvcGVyYXRpb24gb24gdGhlIHRyYW5zYWN0aW9uJ3MgdHJlZQoqIGhhdmUg cmVjb3JkZWQgdGhlIHdhdGNob3AsIG1ha2luZyB0aGlzIHF1ZXVlIGVmZmVj dGl2ZWx5IHVuYm91bmRlZAoKSXQgaXMgYmV0dGVyIGlmIHdlIGNoZWNrIHdo ZXRoZXIgd2UnZCBoYXZlIHJvb20gdG8gc3RvcmUgdGhlIG9wZXJhdGlvbiBi ZWZvcmUKcGVyZm9ybWluZyB0aGUgdHJhbnNhY3Rpb24sIGFuZCByYWlzZSBF UVVPVEEgdGhlcmUuICBUaGVuIHRoZSB0cmFuc2FjdGlvbgpyZWNvcmQgd29u J3QgZ3Jvdy4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2IC8gQ1ZFLTIwMjIt NDIzMTcuCgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1h em9uLmNvbT4KU2lnbmVkLW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4u dG9yb2tAY2l0cml4LmNvbT4KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcg PGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbCBiL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9wcm9jZXNzLm1sCmluZGV4IDNhYjA5YzZjZTkyNi4uMzI3 OWIxOWIxYmZmIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQv cHJvY2Vzcy5tbAorKysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vz cy5tbApAQCAtMjUzLDYgKzI1Myw3IEBAIGxldCBpbnB1dF9oYW5kbGVfZXJy b3IgfmNvbnMgfmRvbXMgfmZjdCB+Y29uIH50IH5yZXEgPQogCWxldCByZXBs eV9lcnJvciBlID0KIAkJUGFja2V0LkVycm9yIGUgaW4KIAl0cnkKKwkJVHJh bnNhY3Rpb24uY2hlY2tfcXVvdGFfZXhuIH5wZXJtOihDb25uZWN0aW9uLmdl dF9wZXJtIGNvbikgdDsKIAkJZmN0IGNvbiB0IGRvbXMgY29ucyByZXEuUGFj a2V0LmRhdGEKIAl3aXRoCiAJfCBEZWZpbmUuSW52YWxpZF9wYXRoICAgICAg ICAgIC0+IHJlcGx5X2Vycm9yICJFSU5WQUwiCkBAIC01NDUsOSArNTQ2LDEw IEBAIGxldCBwcm9jZXNzX3BhY2tldCB+c3RvcmUgfmNvbnMgfmRvbXMgfmNv biB+cmVxID0KIAkJaW4KIAogCQlsZXQgcmVzcG9uc2UgPSB0cnkKKwkJCVRy YW5zYWN0aW9uLmNoZWNrX3F1b3RhX2V4biB+cGVybTooQ29ubmVjdGlvbi5n ZXRfcGVybSBjb24pIHQ7CiAJCQlpZiB0aWQgPD4gVHJhbnNhY3Rpb24ubm9u ZSB0aGVuCiAJCQkJKCogUmVtZW1iZXIgdGhlIHJlcXVlc3QgYW5kIHJlc3Bv bnNlIGZvciB0aGlzIG9wZXJhdGlvbiBpbiBjYXNlIHdlIG5lZWQgdG8gcmVw bGF5IHRoZSB0cmFuc2FjdGlvbiAqKQotCQkJCVRyYW5zYWN0aW9uLmFkZF9v cGVyYXRpb24gfnBlcm06KENvbm5lY3Rpb24uZ2V0X3Blcm0gY29uKSB0IHJl cSByZXNwb25zZTsKKwkJCQlUcmFuc2FjdGlvbi5hZGRfb3BlcmF0aW9uIHQg cmVxIHJlc3BvbnNlOwogCQkJcmVzcG9uc2UKIAkJd2l0aCBRdW90YS5MaW1p dF9yZWFjaGVkIC0+CiAJCQlQYWNrZXQuRXJyb3IgIkVRVU9UQSIKZGlmZiAt LWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbCBi L3Rvb2xzL29jYW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbAppbmRleCAx N2IxYmRmMmVhZjkuLjI5NDE0M2UyMzM1YiAxMDA2NDQKLS0tIGEvdG9vbHMv b2NhbWwveGVuc3RvcmVkL3RyYW5zYWN0aW9uLm1sCisrKyBiL3Rvb2xzL29j YW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbApAQCAtODUsNiArODUsNyBA QCB0eXBlIHQgPSB7CiAJb2xkcm9vdDogU3RvcmUuTm9kZS50OwogCW11dGFi bGUgcGF0aHM6IChYZW5idXMuWGIuT3Aub3BlcmF0aW9uICogU3RvcmUuUGF0 aC50KSBsaXN0OwogCW11dGFibGUgb3BlcmF0aW9uczogKFBhY2tldC5yZXF1 ZXN0ICogUGFja2V0LnJlc3BvbnNlKSBsaXN0OworCW11dGFibGUgcXVvdGFf cmVhY2hlZDogYm9vbDsKIAltdXRhYmxlIHJlYWRfbG93cGF0aDogU3RvcmUu UGF0aC50IG9wdGlvbjsKIAltdXRhYmxlIHdyaXRlX2xvd3BhdGg6IFN0b3Jl LlBhdGgudCBvcHRpb247CiB9CkBAIC0xMjcsNiArMTI4LDcgQEAgbGV0IG1h a2UgPyhpbnRlcm5hbD1mYWxzZSkgaWQgc3RvcmUgPQogCQlvbGRyb290ID0g U3RvcmUuZ2V0X3Jvb3Qgc3RvcmU7CiAJCXBhdGhzID0gW107CiAJCW9wZXJh dGlvbnMgPSBbXTsKKwkJcXVvdGFfcmVhY2hlZCA9IGZhbHNlOwogCQlyZWFk X2xvd3BhdGggPSBOb25lOwogCQl3cml0ZV9sb3dwYXRoID0gTm9uZTsKIAl9 IGluCkBAIC0xNDMsMTMgKzE0NSwxOSBAQCBsZXQgZ2V0X3Jvb3QgdCA9IFN0 b3JlLmdldF9yb290IHQuc3RvcmUKIAogbGV0IGlzX3JlYWRfb25seSB0ID0g dC5wYXRocyA9IFtdCiBsZXQgYWRkX3dvcCB0IHR5IHBhdGggPSB0LnBhdGhz IDwtICh0eSwgcGF0aCkgOjogdC5wYXRocwotbGV0IGFkZF9vcGVyYXRpb24g fnBlcm0gdCByZXF1ZXN0IHJlc3BvbnNlID0KK2xldCBnZXRfb3BlcmF0aW9u cyB0ID0gTGlzdC5yZXYgdC5vcGVyYXRpb25zCisKK2xldCBjaGVja19xdW90 YV9leG4gfnBlcm0gdCA9CiAJaWYgIURlZmluZS5tYXhyZXF1ZXN0cyA+PSAw CiAJCSYmIG5vdCAoUGVybXMuQ29ubmVjdGlvbi5pc19kb20wIHBlcm0pCi0J CSYmIExpc3QubGVuZ3RoIHQub3BlcmF0aW9ucyA+PSAhRGVmaW5lLm1heHJl cXVlc3RzCi0JCXRoZW4gcmFpc2UgUXVvdGEuTGltaXRfcmVhY2hlZDsKKwkJ JiYgKHQucXVvdGFfcmVhY2hlZCB8fCBMaXN0Lmxlbmd0aCB0Lm9wZXJhdGlv bnMgPj0gIURlZmluZS5tYXhyZXF1ZXN0cykKKwkJdGhlbiBiZWdpbgorCQkJ dC5xdW90YV9yZWFjaGVkIDwtIHRydWU7CisJCQlyYWlzZSBRdW90YS5MaW1p dF9yZWFjaGVkOworCQllbmQKKworbGV0IGFkZF9vcGVyYXRpb24gdCByZXF1 ZXN0IHJlc3BvbnNlID0KIAl0Lm9wZXJhdGlvbnMgPC0gKHJlcXVlc3QsIHJl c3BvbnNlKSA6OiB0Lm9wZXJhdGlvbnMKLWxldCBnZXRfb3BlcmF0aW9ucyB0 ID0gTGlzdC5yZXYgdC5vcGVyYXRpb25zCiBsZXQgc2V0X3JlYWRfbG93cGF0 aCB0IHBhdGggPSB0LnJlYWRfbG93cGF0aCA8LSBnZXRfbG93ZXN0IHBhdGgg dC5yZWFkX2xvd3BhdGgKIGxldCBzZXRfd3JpdGVfbG93cGF0aCB0IHBhdGgg PSB0LndyaXRlX2xvd3BhdGggPC0gZ2V0X2xvd2VzdCBwYXRoIHQud3JpdGVf bG93cGF0aAogCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-oxenstored-03.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-oxenstored-03.patch" Content-Transfer-Encoding: base64 RnJvbSAwMDUxZDU5ZmYyZDc1ZjkyOTVhNzJjNzgzNzNhMWVkMTZhMjVlN2Ix IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNyArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogR0MgcGFyYW1ldGVyIHR1bmluZwpNSU1FLVZl cnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9 VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKQnkgZGVm YXVsdCB0aGUgT0NhbWwgZ2FyYmFnZSBjb2xsZWN0b3Igd291bGQgcmV0dXJu IG1lbW9yeSB0byB0aGUgT1Mgb25seQphZnRlciB1bnVzZWQgbWVtb3J5IGlz IDV4IGxpdmUgbWVtb3J5LiAgVHdlYWsgdGhpcyB0byAxMjAlIGluc3RlYWQs IHdoaWNoCndvdWxkIG1hdGNoIHRoZSBtYWpvciBHQyBzcGVlZC4KClRoaXMg aXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEVkd2luIFTD tnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJp c3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+Cgpk aWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RlZmluZS5tbCBi L3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKaW5kZXggOTZjMTI1 YTk2OWRhLi4xYTVkMmYzNGE2NzggMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9kZWZpbmUubWwKKysrIGIvdG9vbHMvb2NhbWwveGVuc3Rv cmVkL2RlZmluZS5tbApAQCAtMjYsNiArMjYsNyBAQCBsZXQgbWF4d2F0Y2gg PSByZWYgKDEwMCkKIGxldCBtYXh0cmFuc2FjdGlvbiA9IHJlZiAoMTApCiBs ZXQgbWF4cmVxdWVzdHMgPSByZWYgKDEwMjQpICAgKCogbWF4aW11bSByZXF1 ZXN0cyBwZXIgdHJhbnNhY3Rpb24gKikKIAorbGV0IGdjX21heF9vdmVyaGVh ZCA9IHJlZiAxMjAgKCogMTIwJSBzZWUgY29tbWVudCBpbiB4ZW5zdG9yZWQu bWwgKikKIGxldCBjb25mbGljdF9idXJzdF9saW1pdCA9IHJlZiA1LjAKIGxl dCBjb25mbGljdF9tYXhfaGlzdG9yeV9zZWNvbmRzID0gcmVmIDAuMDUKIGxl dCBjb25mbGljdF9yYXRlX2xpbWl0X2lzX2FnZ3JlZ2F0ZSA9IHJlZiB0cnVl CmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQveGVuc3RvcmVk Lm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbAppbmRl eCAzNjliNTAzNmY0M2QuLjBiNjM0M2RmYzc4OSAxMDA2NDQKLS0tIGEvdG9v bHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbAorKysgYi90b29scy9v Y2FtbC94ZW5zdG9yZWQveGVuc3RvcmVkLm1sCkBAIC0xMDMsNiArMTAzLDcg QEAgbGV0IHBhcnNlX2NvbmZpZyBmaWxlbmFtZSA9CiAJCSgicXVvdGEtbWF4 c2l6ZSIsIENvbmZpZy5TZXRfaW50IFF1b3RhLm1heHNpemUpOwogCQkoInF1 b3RhLW1heHJlcXVlc3RzIiwgQ29uZmlnLlNldF9pbnQgRGVmaW5lLm1heHJl cXVlc3RzKTsKIAkJKCJxdW90YS1wYXRoLW1heCIsIENvbmZpZy5TZXRfaW50 IERlZmluZS5wYXRoX21heCk7CisJCSgiZ2MtbWF4LW92ZXJoZWFkIiwgQ29u ZmlnLlNldF9pbnQgRGVmaW5lLmdjX21heF9vdmVyaGVhZCk7CiAJCSgidGVz dC1lYWdhaW4iLCBDb25maWcuU2V0X2Jvb2wgVHJhbnNhY3Rpb24udGVzdF9l YWdhaW4pOwogCQkoInBlcnNpc3RlbnQiLCBDb25maWcuU2V0X2Jvb2wgRGlz ay5lbmFibGUpOwogCQkoInhlbnN0b3JlZC1sb2ctZmlsZSIsIENvbmZpZy5T dHJpbmcgTG9nZ2luZy5zZXRfeGVuc3RvcmVkX2xvZ19kZXN0aW5hdGlvbik7 CkBAIC0yMjksNiArMjMwLDY3IEBAIGxldCB0b19maWxlIHN0b3JlIGNvbnMg ZmlsZSA9CiAJICAgICAgICAoZnVuICgpIC0+IGNsb3NlX291dCBjaGFubmVs KQogZW5kCiAKKygqCisJQnkgZGVmYXVsdCBPQ2FtbCdzIEdDIG9ubHkgcmV0 dXJucyBtZW1vcnkgdG8gdGhlIE9TIHdoZW4gaXQgZXhjZWVkcyBhCisJY29u ZmlndXJhYmxlICdtYXggb3ZlcmhlYWQnIHNldHRpbmcuCisJVGhlIGRlZmF1 bHQgaXMgNTAwJSwgdGhhdCBpcyA1LzZ0aCBvZiB0aGUgT0NhbWwgaGVhcCBu ZWVkcyB0byBiZSBmcmVlCisJYW5kIG9ubHkgMS82dGggbGl2ZSBmb3IgYSBj b21wYWN0aW9uIHRvIGJlIHRyaWdnZXJyZWQgdGhhdCB3b3VsZAorCXJlbGVh c2UgbWVtb3J5IGJhY2sgdG8gdGhlIE9TLgorCUlmIHRoZSBsaW1pdCBpcyBu b3QgaGl0IHRoZW4gdGhlIE9DYW1sIHByb2Nlc3MgY2FuIHJldXNlIHRoYXQg bWVtb3J5CisJZm9yIGl0cyBvd24gcHVycG9zZXMsIGJ1dCBvdGhlciBwcm9j ZXNzZXMgd29uJ3QgYmUgYWJsZSB0byB1c2UgaXQuCisKKwlUaGVyZSBpcyBh bHNvIGEgJ3NwYWNlIG92ZXJoZWFkJyBzZXR0aW5nIHRoYXQgY29udHJvbHMg aG93IG11Y2ggd29yaworCWVhY2ggbWFqb3IgR0Mgc2xpY2UgZG9lcywgYW5k IGJ5IGRlZmF1bHQgYWltcyBhdCBoYXZpbmcgbm8gbW9yZSB0aGFuCisJODAl IG9yIDEyMCUgKGRlcGVuZGluZyBvbiB2ZXJzaW9uKSBnYXJiYWdlIHZhbHVl cyBjb21wYXJlZCB0byBsaXZlCisJdmFsdWVzLgorCVRoaXMgZG9lc24ndCBo YXZlIGFzIG11Y2ggcmVsZXZhbmNlIHRvIG1lbW9yeSByZXR1cm5lZCB0byB0 aGUgT1MgYXMKKwlsb25nIGFzIHNwYWNlX292ZXJoZWFkIDw9IG1heF9vdmVy aGVhZCwgYmVjYXVzZSBjb21wYWN0aW9uIGlzIG9ubHkKKwl0cmlnZ2VycmVk IGF0IHRoZSBlbmQgb2YgbWFqb3IgR0MgY3ljbGVzLgorCisJVGhlIGRlZmF1 bHRzIGFyZSB0b28gbGFyZ2Ugb25jZSB0aGUgcHJvZ3JhbSBzdGFydHMgdXNp bmcgfjEwME1pQiBvZgorCW1lbW9yeSwgYXQgd2hpY2ggcG9pbnQgfjUwME1p QiB3b3VsZCBiZSB1bmF2YWlsYWJsZSB0byBvdGhlciBwcm9jZXNzZXMKKwko d2hpY2ggd291bGQgYmUgZmluZSBpZiB0aGlzIHdhcyB0aGUgbWFpbiBwcm9j ZXNzIGluIHRoaXMgVk0sIGJ1dCBpdCBpcworCW5vdCkuCisKKwlNYXggb3Zl cmhlYWQgY2FuIGFsc28gYmUgc2V0IHRvIDAsIGhvd2V2ZXIgdGhpcyBpcyBm b3IgdGVzdGluZyBwdXJwb3NlcworCW9ubHkgKHNldHRpbmcgaXQgbG93ZXIg dGhhbiAnc3BhY2Ugb3ZlcmhlYWQnIHdvdWxkbid0IGhlbHAgYmVjYXVzZSB0 aGUKKwltYWpvciBHQyB3b3VsZG4ndCBydW4gZmFzdCBlbm91Z2gsIGFuZCBj b21wYWN0aW9uIGRvZXMgaGF2ZSBhCisJcGVyZm9ybWFuY2UgY29zdDogd2Ug Y2FuIG9ubHkgY29tcGFjdCBjb250aWd1b3VzIHJlZ2lvbnMsIHNvIG1lbW9y eSBoYXMKKwl0byBiZSBtb3ZlZCBhcm91bmQpLgorCisJTWF4IG92ZXJoZWFk IGNvbnRyb2xzIGhvdyBvZnRlbiB0aGUgaGVhcCBpcyBjb21wYWN0ZWQsIHdo aWNoIGlzIHVzZWZ1bAorCWlmIHRoZXJlIGFyZSBidXJzdCBvZiBhY3Rpdml0 eSBmb2xsb3dlZCBieSBsb25nIHBlcmlvZHMgb2YgaWRsZSBzdGF0ZSwKKwlv ciBpZiBhIGRvbWFpbiBxdWl0cywgZXRjLiBDb21wYWN0aW9uIHJldHVybnMg bWVtb3J5IHRvIHRoZSBPUy4KKworCXdhc3RlZCA9IGxpdmUgKiBzcGFjZV9v dmVyaGVhZCAvIDEwMAorCisJRm9yIGdsb2JhbGx5IG92ZXJyaWRpbmcgdGhl IEdDIHNldHRpbmdzIG9uZSBjYW4gdXNlIE9DQU1MUlVOUEFSQU0sCisJaG93 ZXZlciB3ZSBwcm92aWRlIGEgY29uZmlnIGZpbGUgb3ZlcnJpZGUgdG8gYmUg Y29uc2lzdGVudCB3aXRoIG90aGVyCisJb3hlbnN0b3JlZCBzZXR0aW5ncy4K KworCU9uZSBtaWdodCB3YW50IHRvIGR5bmFtaWNhbGx5IGFkanVzdCB0aGUg b3ZlcmhlYWQgc2V0dGluZyBiYXNlZCBvbiB1c2VkCisJbWVtb3J5LCBpLmUu IHRvIHVzZSBhIGZpeGVkIHVwcGVyIGJvdW5kIGluIGJ5dGVzLCBub3QgcGVy Y2VudGFnZS4gSG93ZXZlcgorCW1lYXN1cmVtZW50cyBzaG93IHRoYXQgc3Vj aCBhZGp1c3RtZW50cyBpbmNyZWFzZSBHQyBvdmVyaGVhZCBtYXNzaXZlbHks CisJd2hpbGUgc3RpbGwgbm90IGd1YXJhbnRlZWluZyB0aGF0IG1lbW9yeSBp cyByZXR1cm5lZCBhbnkgbW9yZSBxdWlja2x5CisJdGhhbiB3aXRoIGEgcGVy Y2VudGFnZSBiYXNlZCBzZXR0aW5nLgorCisJVGhlIGFsbG9jYXRpb24gcG9s aWN5IGNvdWxkIGFsc28gYmUgdHdlYWtlZCwgZS5nLiBmaXJzdCBmaXQgd291 bGQgcmVkdWNlCisJZnJhZ21lbnRhdGlvbiBhbmQgdGh1cyBtZW1vcnkgdXNh Z2UsIGJ1dCB0aGUgZG9jdW1lbnRhdGlvbiB3YXJucyB0aGF0IGl0CisJY2Fu IGJlIHNlbnNpYmx5IHNsb3dlciwgYW5kIGluZGVlZCBvbmUgb2Ygb3VyIG93 biB0ZXN0Y2FzZXMgY2FuIHRyaWdnZXIKKwlzdWNoIGEgY29ybmVyIGNhc2Ug d2hlcmUgaXQgaXMgbXVsdGlwbGUgdGltZXMgc2xvd2VyLCBzbyBpdCBpcyBi ZXN0IHRvIGtlZXAKKwl0aGUgZGVmYXVsdCBhbGxvY2F0aW9uIHBvbGljeSAo bmV4dC1maXQvYmVzdC1maXQgZGVwZW5kaW5nIG9uIHZlcnNpb24pLgorCisJ VGhlcmUgYXJlIG90aGVyIHR3ZWFrcyB0aGF0IGNhbiBiZSBhdHRlbXB0ZWQg aW4gdGhlIGZ1dHVyZSwgZS5nLiBzZXR0aW5nCisJJ3VsaW1pdCAtdicgdG8g NzUlIG9mIFJBTSwgaG93ZXZlciBnZXR0aW5nIHRoZSBrZXJuZWwgdG8gYWN0 dWFsbHkgcmV0dXJuCisJTlVMTCBmcm9tIGFsbG9jYXRpb25zIGlzIGRpZmZp Y3VsdCBldmVuIHdpdGggdGhhdCBzZXR0aW5nLCBhbmQgd2l0aG91dCBhCisJ TlVMTCB0aGUgZW1lcmdlbmN5IEdDIHdvbid0IGJlIHRyaWdnZXJyZWQuCisJ UGVyaGFwcyBjZ3JvdXAgbGltaXRzIGNvdWxkIGhlbHAsIGJ1dCBmb3Igbm93 IHR3ZWFrIHRoZSBzYWZlc3Qgb25seS4KKyopCisKK2xldCB0d2Vha19nYyAo KSA9CisJR2Muc2V0IHsgKEdjLmdldCAoKSkgd2l0aCBHYy5tYXhfb3Zlcmhl YWQgPSAhRGVmaW5lLmdjX21heF9vdmVyaGVhZCB9CisKKwogbGV0IF8gPQog CWxldCBjZiA9IGRvX2FyZ3YgaW4KIAlsZXQgcGlkZmlsZSA9CkBAIC0yMzgs NiArMzAwLDggQEAgbGV0IF8gPQogCQkJZGVmYXVsdF9waWRmaWxlCiAJCWlu CiAKKwl0d2Vha19nYyAoKTsKKwogCSh0cnkKIAkJVW5peGV4dC5ta2Rpcl9y ZWMgKEZpbGVuYW1lLmRpcm5hbWUgcGlkZmlsZSkgMG83NTUKIAl3aXRoIF8g LT4K --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-oxenstored-04.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-oxenstored-04.patch" Content-Transfer-Encoding: base64 RnJvbSBlNDQ0ZmY1ZjE0NzIzYzc3NGU5OTkzZDRlYTRlZGM0NjcxY2RjYzM0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogRnJpLCAyOSBKdWwgMjAyMiAxODo1MzoyOSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC9saWJzL3hiOiBoaWRlIHR5cGUgb2YgWGIudApN SU1FLVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNo YXJzZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoK SGlkaW5nIHRoZSB0eXBlIHdpbGwgbWFrZSBpdCBlYXNpZXIgdG8gY2hhbmdl IHRoZSBpbXBsZW1lbnRhdGlvbgppbiB0aGUgZnV0dXJlIHdpdGhvdXQgYnJl YWtpbmcgY29kZSB0aGF0IHJlbGllcyBvbiBpdC4KCk5vIGZ1bmN0aW9uYWwg Y2hhbmdlLgoKU2lnbmVkLW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4u dG9yb2tAY2l0cml4LmNvbT4KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcg PGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4KKGNoZXJyeSBwaWNrZWQg ZnJvbSBjb21taXQgN2FkZTMwYTE0NTE3MzRkMDQxMzYzYzc1MGE2NWQzMjJl MjViNDdiYSkKClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBh bWF6b24uY29tPgpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yi94 Yi5tbCBiL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWwKaW5kZXggMTA0ZDMx OWQ3NzQ3Li44NDA0ZGRkOGE2ODIgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1s L2xpYnMveGIveGIubWwKKysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5t bApAQCAtMTk2LDYgKzE5Niw5IEBAIGxldCBwZWVrX291dHB1dCBjb24gPSBR dWV1ZS5wZWVrIGNvbi5wa3Rfb3V0CiBsZXQgaW5wdXRfbGVuIGNvbiA9IFF1 ZXVlLmxlbmd0aCBjb24ucGt0X2luCiBsZXQgaGFzX2luX3BhY2tldCBjb24g PSBRdWV1ZS5sZW5ndGggY29uLnBrdF9pbiA+IDAKIGxldCBnZXRfaW5fcGFj a2V0IGNvbiA9IFF1ZXVlLnBvcCBjb24ucGt0X2luCitsZXQgaGFzX3BhcnRp YWxfaW5wdXQgY29uID0gbWF0Y2ggY29uLnBhcnRpYWxfaW4gd2l0aAorCXwg SGF2ZUhkciBfIC0+IHRydWUKKwl8IE5vSGRyIChuLCBfKSAtPiBuIDwgUGFy dGlhbC5oZWFkZXJfc2l6ZSAoKQogbGV0IGhhc19tb3JlX2lucHV0IGNvbiA9 CiAJbWF0Y2ggY29uLmJhY2tlbmQgd2l0aAogCXwgRmQgXyAgICAgICAgIC0+ IGZhbHNlCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aSBiL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWxpCmluZGV4IDNhMDBkYTZj ZGRjMS4uNzk0ZTM1YmIzNDNlIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9s aWJzL3hiL3hiLm1saQorKysgYi90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aQpAQCAtNjYsMTMgKzY2LDcgQEAgdHlwZSBiYWNrZW5kX21tYXAgPSB7CiB0 eXBlIGJhY2tlbmRfZmQgPSB7IGZkIDogVW5peC5maWxlX2Rlc2NyOyB9CiB0 eXBlIGJhY2tlbmQgPSBGZCBvZiBiYWNrZW5kX2ZkIHwgWGVubW1hcCBvZiBi YWNrZW5kX21tYXAKIHR5cGUgcGFydGlhbF9idWYgPSBIYXZlSGRyIG9mIFBh cnRpYWwucGt0IHwgTm9IZHIgb2YgaW50ICogYnl0ZXMKLXR5cGUgdCA9IHsK LSAgYmFja2VuZCA6IGJhY2tlbmQ7Ci0gIHBrdF9pbiA6IFBhY2tldC50IFF1 ZXVlLnQ7Ci0gIHBrdF9vdXQgOiBQYWNrZXQudCBRdWV1ZS50OwotICBtdXRh YmxlIHBhcnRpYWxfaW4gOiBwYXJ0aWFsX2J1ZjsKLSAgbXV0YWJsZSBwYXJ0 aWFsX291dCA6IHN0cmluZzsKLX0KK3R5cGUgdAogdmFsIGluaXRfcGFydGlh bF9pbiA6IHVuaXQgLT4gcGFydGlhbF9idWYKIHZhbCByZWNvbm5lY3QgOiB0 IC0+IHVuaXQKIHZhbCBxdWV1ZSA6IHQgLT4gUGFja2V0LnQgLT4gdW5pdApA QCAtOTcsNiArOTEsNyBAQCB2YWwgaGFzX291dHB1dCA6IHQgLT4gYm9vbAog dmFsIHBlZWtfb3V0cHV0IDogdCAtPiBQYWNrZXQudAogdmFsIGlucHV0X2xl biA6IHQgLT4gaW50CiB2YWwgaGFzX2luX3BhY2tldCA6IHQgLT4gYm9vbAor dmFsIGhhc19wYXJ0aWFsX2lucHV0IDogdCAtPiBib29sCiB2YWwgZ2V0X2lu X3BhY2tldCA6IHQgLT4gUGFja2V0LnQKIHZhbCBoYXNfbW9yZV9pbnB1dCA6 IHQgLT4gYm9vbAogdmFsIGlzX3NlbGVjdGFibGUgOiB0IC0+IGJvb2wKZGlm ZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9uLm1s IGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Nvbm5lY3Rpb24ubWwKaW5kZXgg ZGFmOGQ4MDRmN2VmLi43MGM0MzQ4NTUyOGMgMTAwNjQ0Ci0tLSBhL3Rvb2xz L29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9uLm1sCisrKyBiL3Rvb2xzL29j YW1sL3hlbnN0b3JlZC9jb25uZWN0aW9uLm1sCkBAIC0xMjUsOSArMTI1LDcg QEAgbGV0IGdldF9wZXJtIGNvbiA9CiBsZXQgc2V0X3RhcmdldCBjb24gdGFy Z2V0X2RvbWlkID0KIAljb24ucGVybSA8LSBQZXJtcy5Db25uZWN0aW9uLnNl dF90YXJnZXQgKGdldF9wZXJtIGNvbikgfnBlcm1zOltQZXJtcy5SRUFEOyBQ ZXJtcy5XUklURV0gdGFyZ2V0X2RvbWlkCiAKLWxldCBpc19iYWNrZW5kX21t YXAgY29uID0gbWF0Y2ggY29uLnhiLlhlbmJ1cy5YYi5iYWNrZW5kIHdpdGgK LQl8IFhlbmJ1cy5YYi5YZW5tbWFwIF8gLT4gdHJ1ZQotCXwgXyAtPiBmYWxz ZQorbGV0IGlzX2JhY2tlbmRfbW1hcCBjb24gPSBYZW5idXMuWGIuaXNfbW1h cCBjb24ueGIKIAogbGV0IHNlbmRfcmVwbHkgY29uIHRpZCByaWQgdHkgZGF0 YSA9CiAJaWYgKFN0cmluZy5sZW5ndGggZGF0YSkgPiB4ZW5zdG9yZV9wYXls b2FkX21heCAmJiAoaXNfYmFja2VuZF9tbWFwIGNvbikgdGhlbgo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-oxenstored-05.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-oxenstored-05.patch" Content-Transfer-Encoding: base64 RnJvbSA0YTA2MjlmNzQ3MjM3Y2Q2ZmJiMjMwZjk0N2VmMjczZGI3N2NjODFl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMiArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogQ2hhbmdlIFhiLmlucHV0IHRvIHJldHVybiBQ YWNrZXQudCBvcHRpb24KTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBl OiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXIt RW5jb2Rpbmc6IDhiaXQKClRoZSBxdWV1ZSBoZXJlIHdvdWxkIG9ubHkgZXZl ciBob2xkIGF0IG1vc3Qgb25lIGVsZW1lbnQuICBUaGlzIHdpbGwgc2ltcGxp ZnkKZm9sbG93LXVwIHBhdGNoZXMuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMy Ni4KClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24u Y29tPgpTaWduZWQtb2ZmLWJ5OiBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jv a0BjaXRyaXguY29tPgpBY2tlZC1ieTogQ2hyaXN0aWFuIExpbmRpZyA8Y2hy aXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xz L29jYW1sL2xpYnMveGIveGIubWwgYi90b29scy9vY2FtbC9saWJzL3hiL3hi Lm1sCmluZGV4IDg0MDRkZGQ4YTY4Mi4uMTY1ZmQ0YTFlZGY0IDEwMDY0NAot LS0gYS90b29scy9vY2FtbC9saWJzL3hiL3hiLm1sCisrKyBiL3Rvb2xzL29j YW1sL2xpYnMveGIveGIubWwKQEAgLTQ1LDcgKzQ1LDYgQEAgdHlwZSBwYXJ0 aWFsX2J1ZiA9IEhhdmVIZHIgb2YgUGFydGlhbC5wa3QgfCBOb0hkciBvZiBp bnQgKiBieXRlcwogdHlwZSB0ID0KIHsKIAliYWNrZW5kOiBiYWNrZW5kOwot CXBrdF9pbjogUGFja2V0LnQgUXVldWUudDsKIAlwa3Rfb3V0OiBQYWNrZXQu dCBRdWV1ZS50OwogCW11dGFibGUgcGFydGlhbF9pbjogcGFydGlhbF9idWY7 CiAJbXV0YWJsZSBwYXJ0aWFsX291dDogc3RyaW5nOwpAQCAtNjIsNyArNjEs NiBAQCBsZXQgcmVjb25uZWN0IHQgPSBtYXRjaCB0LmJhY2tlbmQgd2l0aAog CQlYc19yaW5nLmNsb3NlIGJhY2tlbmQubW1hcDsKIAkJYmFja2VuZC5ldmVu dGNobl9ub3RpZnkgKCk7CiAJCSgqIENsZWFyIG91ciBvbGQgY29ubmVjdGlv biBzdGF0ZSAqKQotCQlRdWV1ZS5jbGVhciB0LnBrdF9pbjsKIAkJUXVldWUu Y2xlYXIgdC5wa3Rfb3V0OwogCQl0LnBhcnRpYWxfaW4gPC0gaW5pdF9wYXJ0 aWFsX2luICgpOwogCQl0LnBhcnRpYWxfb3V0IDwtICIiCkBAIC0xMjQsNyAr MTIyLDYgQEAgbGV0IG91dHB1dCBjb24gPQogCiAoKiBOQjogY2FuIHRocm93 IFJlY29ubmVjdCAqKQogbGV0IGlucHV0IGNvbiA9Ci0JbGV0IG5ld3BhY2tl dCA9IHJlZiBmYWxzZSBpbgogCWxldCB0b19yZWFkID0KIAkJbWF0Y2ggY29u LnBhcnRpYWxfaW4gd2l0aAogCQl8IEhhdmVIZHIgcGFydGlhbF9wa3QgLT4g UGFydGlhbC50b19jb21wbGV0ZSBwYXJ0aWFsX3BrdApAQCAtMTQzLDIxICsx NDAsMTkgQEAgbGV0IGlucHV0IGNvbiA9CiAJCWlmIFBhcnRpYWwudG9fY29t cGxldGUgcGFydGlhbF9wa3QgPSAwIHRoZW4gKAogCQkJbGV0IHBrdCA9IFBh Y2tldC5vZl9wYXJ0aWFscGt0IHBhcnRpYWxfcGt0IGluCiAJCQljb24ucGFy dGlhbF9pbiA8LSBpbml0X3BhcnRpYWxfaW4gKCk7Ci0JCQlRdWV1ZS5wdXNo IHBrdCBjb24ucGt0X2luOwotCQkJbmV3cGFja2V0IDo9IHRydWUKLQkJKQor CQkJU29tZSBwa3QKKwkJKSBlbHNlIE5vbmUKIAl8IE5vSGRyIChpLCBidWYp ICAgICAgLT4KIAkJKCogd2UgY29tcGxldGUgdGhlIHBhcnRpYWwgaGVhZGVy ICopCiAJCWlmIHN6ID4gMCB0aGVuCiAJCQlCeXRlcy5ibGl0IGIgMCBidWYg KFBhcnRpYWwuaGVhZGVyX3NpemUgKCkgLSBpKSBzejsKIAkJY29uLnBhcnRp YWxfaW4gPC0gaWYgc3ogPSBpIHRoZW4KLQkJCUhhdmVIZHIgKFBhcnRpYWwu b2Zfc3RyaW5nIChCeXRlcy50b19zdHJpbmcgYnVmKSkgZWxzZSBOb0hkciAo aSAtIHN6LCBidWYpCi0JKTsKLQkhbmV3cGFja2V0CisJCQlIYXZlSGRyIChQ YXJ0aWFsLm9mX3N0cmluZyAoQnl0ZXMudG9fc3RyaW5nIGJ1ZikpIGVsc2Ug Tm9IZHIgKGkgLSBzeiwgYnVmKTsKKwkJTm9uZQorCSkKIAogbGV0IG5ld2Nv biBiYWNrZW5kID0gewogCWJhY2tlbmQgPSBiYWNrZW5kOwotCXBrdF9pbiA9 IFF1ZXVlLmNyZWF0ZSAoKTsKIAlwa3Rfb3V0ID0gUXVldWUuY3JlYXRlICgp OwogCXBhcnRpYWxfaW4gPSBpbml0X3BhcnRpYWxfaW4gKCk7CiAJcGFydGlh bF9vdXQgPSAiIjsKQEAgLTE5Myw5ICsxODgsNiBAQCBsZXQgaGFzX291dHB1 dCBjb24gPSBoYXNfbmV3X291dHB1dCBjb24gfHwgaGFzX29sZF9vdXRwdXQg Y29uCiAKIGxldCBwZWVrX291dHB1dCBjb24gPSBRdWV1ZS5wZWVrIGNvbi5w a3Rfb3V0CiAKLWxldCBpbnB1dF9sZW4gY29uID0gUXVldWUubGVuZ3RoIGNv bi5wa3RfaW4KLWxldCBoYXNfaW5fcGFja2V0IGNvbiA9IFF1ZXVlLmxlbmd0 aCBjb24ucGt0X2luID4gMAotbGV0IGdldF9pbl9wYWNrZXQgY29uID0gUXVl dWUucG9wIGNvbi5wa3RfaW4KIGxldCBoYXNfcGFydGlhbF9pbnB1dCBjb24g PSBtYXRjaCBjb24ucGFydGlhbF9pbiB3aXRoCiAJfCBIYXZlSGRyIF8gLT4g dHJ1ZQogCXwgTm9IZHIgKG4sIF8pIC0+IG4gPCBQYXJ0aWFsLmhlYWRlcl9z aXplICgpCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aSBiL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWxpCmluZGV4IDc5NGUzNWJi MzQzZS4uOTFjNjgyMTYyY2VhIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9s aWJzL3hiL3hiLm1saQorKysgYi90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aQpAQCAtNzcsNyArNzcsNyBAQCB2YWwgd3JpdGVfZmQgOiBiYWNrZW5kX2Zk IC0+ICdhIC0+IHN0cmluZyAtPiBpbnQgLT4gaW50CiB2YWwgd3JpdGVfbW1h cCA6IGJhY2tlbmRfbW1hcCAtPiAnYSAtPiBzdHJpbmcgLT4gaW50IC0+IGlu dAogdmFsIHdyaXRlIDogdCAtPiBzdHJpbmcgLT4gaW50IC0+IGludAogdmFs IG91dHB1dCA6IHQgLT4gYm9vbAotdmFsIGlucHV0IDogdCAtPiBib29sCit2 YWwgaW5wdXQgOiB0IC0+IFBhY2tldC50IG9wdGlvbgogdmFsIG5ld2NvbiA6 IGJhY2tlbmQgLT4gdAogdmFsIG9wZW5fZmQgOiBVbml4LmZpbGVfZGVzY3Ig LT4gdAogdmFsIG9wZW5fbW1hcCA6IFhlbm1tYXAubW1hcF9pbnRlcmZhY2Ug LT4gKHVuaXQgLT4gdW5pdCkgLT4gdApAQCAtODksMTAgKzg5LDcgQEAgdmFs IGhhc19uZXdfb3V0cHV0IDogdCAtPiBib29sCiB2YWwgaGFzX29sZF9vdXRw dXQgOiB0IC0+IGJvb2wKIHZhbCBoYXNfb3V0cHV0IDogdCAtPiBib29sCiB2 YWwgcGVla19vdXRwdXQgOiB0IC0+IFBhY2tldC50Ci12YWwgaW5wdXRfbGVu IDogdCAtPiBpbnQKLXZhbCBoYXNfaW5fcGFja2V0IDogdCAtPiBib29sCiB2 YWwgaGFzX3BhcnRpYWxfaW5wdXQgOiB0IC0+IGJvb2wKLXZhbCBnZXRfaW5f cGFja2V0IDogdCAtPiBQYWNrZXQudAogdmFsIGhhc19tb3JlX2lucHV0IDog dCAtPiBib29sCiB2YWwgaXNfc2VsZWN0YWJsZSA6IHQgLT4gYm9vbAogdmFs IGdldF9mZCA6IHQgLT4gVW5peC5maWxlX2Rlc2NyCmRpZmYgLS1naXQgYS90 b29scy9vY2FtbC9saWJzL3hzL3hzcmF3Lm1sIGIvdG9vbHMvb2NhbWwvbGli cy94cy94c3Jhdy5tbAppbmRleCBkOTgyZmIyNGRiYjEuLjQ1MWY4YjM4ZGJj YyAxMDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94cy94c3Jhdy5tbAor KysgYi90b29scy9vY2FtbC9saWJzL3hzL3hzcmF3Lm1sCkBAIC05NCwyNiAr OTQsMTggQEAgbGV0IHBrdF9zZW5kIGNvbiA9CiAJZG9uZQogCiAoKiByZWNl aXZlIG9uZSBwYWNrZXQgLSBjYW4gc2xlZXAgKikKLWxldCBwa3RfcmVjdiBj b24gPQotCWxldCB3b3JrZG9uZSA9IHJlZiBmYWxzZSBpbgotCXdoaWxlIG5v dCAhd29ya2RvbmUKLQlkbwotCQl3b3JrZG9uZSA6PSBYYi5pbnB1dCBjb24u eGIKLQlkb25lOwotCVhiLmdldF9pbl9wYWNrZXQgY29uLnhiCitsZXQgcmVj IHBrdF9yZWN2IGNvbiA9CisJbWF0Y2ggWGIuaW5wdXQgY29uLnhiIHdpdGgK Kwl8IFNvbWUgcGFja2V0IC0+IHBhY2tldAorCXwgTm9uZSAtPiBwa3RfcmVj diBjb24KIAogbGV0IHBrdF9yZWN2X3RpbWVvdXQgY29uIHRpbWVvdXQgPQog CWxldCBmZCA9IFhiLmdldF9mZCBjb24ueGIgaW4KIAlsZXQgciwgXywgXyA9 IFVuaXguc2VsZWN0IFsgZmQgXSBbXSBbXSB0aW1lb3V0IGluCiAJaWYgciA9 IFtdIHRoZW4KIAkJdHJ1ZSwgTm9uZQotCWVsc2UgKAotCQlsZXQgd29ya2Rv bmUgPSBYYi5pbnB1dCBjb24ueGIgaW4KLQkJaWYgd29ya2RvbmUgdGhlbgot CQkJZmFsc2UsIChTb21lIChYYi5nZXRfaW5fcGFja2V0IGNvbi54YikpCi0J CWVsc2UKLQkJCWZhbHNlLCBOb25lCi0JKQorCWVsc2UKKwkJZmFsc2UsIFhi LmlucHV0IGNvbi54YgogCiBsZXQgcXVldWVfd2F0Y2hldmVudCBjb24gZGF0 YSA9CiAJbGV0IGxzID0gc3BsaXRfc3RyaW5nIH5saW1pdDoyICdcMDAwJyBk YXRhIGluCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvY29u bmVjdGlvbi5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9u Lm1sCmluZGV4IDcwYzQzNDg1NTI4Yy4uYWNlMmFhNWI0ZjUzIDEwMDY0NAot LS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQvY29ubmVjdGlvbi5tbAorKysg Yi90b29scy9vY2FtbC94ZW5zdG9yZWQvY29ubmVjdGlvbi5tbApAQCAtMjc3 LDggKzI3Nyw2IEBAIGxldCBnZXRfdHJhbnNhY3Rpb24gY29uIHRpZCA9CiAJ SGFzaHRibC5maW5kIGNvbi50cmFuc2FjdGlvbnMgdGlkCiAKIGxldCBkb19p bnB1dCBjb24gPSBYZW5idXMuWGIuaW5wdXQgY29uLnhiCi1sZXQgaGFzX2lu cHV0IGNvbiA9IFhlbmJ1cy5YYi5oYXNfaW5fcGFja2V0IGNvbi54YgotbGV0 IHBvcF9pbiBjb24gPSBYZW5idXMuWGIuZ2V0X2luX3BhY2tldCBjb24ueGIK IGxldCBoYXNfbW9yZV9pbnB1dCBjb24gPSBYZW5idXMuWGIuaGFzX21vcmVf aW5wdXQgY29uLnhiCiAKIGxldCBoYXNfb3V0cHV0IGNvbiA9IFhlbmJ1cy5Y Yi5oYXNfb3V0cHV0IGNvbi54YgpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwv eGVuc3RvcmVkL3Byb2Nlc3MubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQv cHJvY2Vzcy5tbAppbmRleCAwZGYzZGY0MDFkYjYuLmE3MjgxMGQwNmY0MyAx MDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3MubWwK KysrIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3MubWwKQEAgLTU2 OSwxNiArNTY5LDE3IEBAIGxldCBkb19pbnB1dCBzdG9yZSBjb25zIGRvbXMg Y29uID0KIAkJCWluZm8gIiVzIHJlcXVlc3RzIGEgcmVjb25uZWN0IiAoQ29u bmVjdGlvbi5nZXRfZG9tc3RyIGNvbik7CiAJCQlIaXN0b3J5LnJlY29ubmVj dCBjb247CiAJCQlpbmZvICIlcyByZWNvbm5lY3Rpb24gY29tcGxldGUiIChD b25uZWN0aW9uLmdldF9kb21zdHIgY29uKTsKLQkJCWZhbHNlCisJCQlOb25l CiAJCXwgRmFpbHVyZSBleHAgLT4KIAkJCWVycm9yICJjYXVnaHQgZXhjZXB0 aW9uICVzIiBleHA7CiAJCQllcnJvciAiZ290IGEgYmFkIGNsaWVudCAlcyIg KHNwcmludGYgIiUtOHMiIChDb25uZWN0aW9uLmdldF9kb21zdHIgY29uKSk7 CiAJCQlDb25uZWN0aW9uLm1hcmtfYXNfYmFkIGNvbjsKLQkJCWZhbHNlCisJ CQlOb25lCiAJaW4KIAotCWlmIG5ld3BhY2tldCB0aGVuICgKLQkJbGV0IHBh Y2tldCA9IENvbm5lY3Rpb24ucG9wX2luIGNvbiBpbgorCW1hdGNoIG5ld3Bh Y2tldCB3aXRoCisJfCBOb25lIC0+ICgpCisJfCBTb21lIHBhY2tldCAtPgog CQlsZXQgdGlkLCByaWQsIHR5LCBkYXRhID0gWGVuYnVzLlhiLlBhY2tldC51 bnBhY2sgcGFja2V0IGluCiAJCWxldCByZXEgPSB7UGFja2V0LnRpZD10aWQ7 IFBhY2tldC5yaWQ9cmlkOyBQYWNrZXQudHk9dHk7IFBhY2tldC5kYXRhPWRh dGF9IGluCiAKQEAgLTU4OCw4ICs1ODksNyBAQCBsZXQgZG9faW5wdXQgc3Rv cmUgY29ucyBkb21zIGNvbiA9CiAJCSAgICAgICAgIChYZW5idXMuWGIuT3Au dG9fc3RyaW5nIHR5KSAoc2FuaXRpemVfZGF0YSBkYXRhKTsgKikKIAkJcHJv Y2Vzc19wYWNrZXQgfnN0b3JlIH5jb25zIH5kb21zIH5jb24gfnJlcTsKIAkJ d3JpdGVfYWNjZXNzX2xvZyB+dHkgfnRpZCB+Y29uOihDb25uZWN0aW9uLmdl dF9kb21zdHIgY29uKSB+ZGF0YTsKLQkJQ29ubmVjdGlvbi5pbmNyX29wcyBj b247Ci0JKQorCQlDb25uZWN0aW9uLmluY3Jfb3BzIGNvbgogCiBsZXQgZG9f b3V0cHV0IF9zdG9yZSBfY29ucyBfZG9tcyBjb24gPQogCWlmIENvbm5lY3Rp b24uaGFzX291dHB1dCBjb24gdGhlbiAoCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-oxenstored-06.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-oxenstored-06.patch" Content-Transfer-Encoding: base64 RnJvbSBmYWVkMGVlM2NjYzI5NDBiMDFiMGM1MGQzYWRjODRlYWYyMDYxOGVk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMyArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94YjogQWRkIEJvdW5kZWRRdWV1ZQpNSU1FLVZl cnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9 VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKRW5zdXJl cyB3ZSBjYW5ub3Qgc3RvcmUgbW9yZSB0aGFuIFtjYXBhY2l0eV0gZWxlbWVu dHMgaW4gYSBbUXVldWVdLiAgUmVwbGFjaW5nCmFsbCBRdWV1ZSB3aXRoIHRo aXMgbW9kdWxlIHdpbGwgdGhlbiBlbnN1cmUgYXQgY29tcGlsZSB0aW1lIHRo YXQgYWxsIFF1ZXVlcwphcmUgY29ycmVjdGx5IGJvdW5kIGNoZWNrZWQuCgpF YWNoIGVsZW1lbnQgaW4gdGhlIHF1ZXVlIGhhcyBhIGNsYXNzIHdpdGggaXRz IG93biBsaW1pdHMuICBUaGlzLCBpbiBhCnN1YnNlcXVlbnQgY2hhbmdlLCB3 aWxsIGVuc3VyZSB0aGF0IGNvbW1hbmQgcmVzcG9uc2VzIGNhbiBwcm9jZWVk IGR1cmluZyBhCmZsb29kIG9mIHdhdGNoIGV2ZW50cy4KCk5vIGZ1bmN0aW9u YWwgY2hhbmdlLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRl ZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVk LW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5k aWdAY2l0cml4LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJz L3hiL3hiLm1sIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbAppbmRleCAx NjVmZDRhMWVkZjQuLjQxOTdhMzg4OGE2OCAxMDA2NDQKLS0tIGEvdG9vbHMv b2NhbWwvbGlicy94Yi94Yi5tbAorKysgYi90b29scy9vY2FtbC9saWJzL3hi L3hiLm1sCkBAIC0xNyw2ICsxNyw5OCBAQAogbW9kdWxlIE9wID0gc3RydWN0 IGluY2x1ZGUgT3AgZW5kCiBtb2R1bGUgUGFja2V0ID0gc3RydWN0IGluY2x1 ZGUgUGFja2V0IGVuZAogCittb2R1bGUgQm91bmRlZFF1ZXVlIDogc2lnCisJ dHlwZSAoJ2EsICdiKSB0CisKKwkoKiogW2NyZWF0ZSB+Y2FwYWNpdHkgfmNs YXNzaWZ5IH5saW1pdF0gY3JlYXRlcyBhIHF1ZXVlIHdpdGggbWF4aW11bSBb Y2FwYWNpdHldIGVsZW1lbnRzLgorCSAgICBUaGlzIGlzIGJ1cnN0IGNhcGFj aXR5LCBlYWNoIGVsZW1lbnQgaXMgZnVydGhlciBjbGFzc2lmaWVkIGFjY29y ZGluZyB0byBbY2xhc3NpZnldLAorCSAgICBhbmQgZWFjaCBjbGFzcyBjYW4g aGF2ZSBpdHMgb3duIFtsaW1pdF0uCisJICAgIFtjYXBhY2l0eV0gaXMgZW5m b3JjZWQgYXMgYW4gb3ZlcmFsbCBsaW1pdC4KKwkgICAgVGhlIFtsaW1pdF0g Y2FuIGJlIGR5bmFtaWMsIGFuZCBjYW4gYmUgc21hbGxlciB0aGFuIHRoZSBu dW1iZXIgb2YgZWxlbWVudHMgYWxyZWFkeSBxdWV1ZWQgb2YgdGhhdCBjbGFz cywKKwkgICAgaW4gd2hpY2ggY2FzZSB0aG9zZSBlbGVtZW50cyBhcmUgY29u c2lkZXJlZCB0byB1c2UgImJ1cnN0IGNhcGFjaXR5Ii4KKwkgICopCisJdmFs IGNyZWF0ZTogY2FwYWNpdHk6aW50IC0+IGNsYXNzaWZ5OignYSAtPiAnYikg LT4gbGltaXQ6KCdiIC0+IGludCkgLT4gKCdhLCAnYikgdAorCisJKCoqIFtj bGVhciBxXSBkaXNjYXJkcyBhbGwgZWxlbWVudHMgZnJvbSBbcV0gKikKKwl2 YWwgY2xlYXI6ICgnYSwgJ2IpIHQgLT4gdW5pdAorCisJKCoqIFtjYW5fcHVz aCBxXSB3aGVuIFtsZW5ndGggcSA8IGNhcGFjaXR5XS4JKikKKwl2YWwgY2Fu X3B1c2g6ICgnYSwgJ2IpIHQgLT4gJ2IgLT4gYm9vbAorCisJKCoqIFtwdXNo IGUgcV0gYWRkcyBbZV0gYXQgdGhlIGVuZCBvZiBxdWV1ZSBbcV0gaWYgW2Nh bl9wdXNoIHFdLCBvciByZXR1cm5zIFtOb25lXS4gKikKKwl2YWwgcHVzaDog J2EgLT4gKCdhLCAnYikgdCAtPiB1bml0IG9wdGlvbgorCisJKCoqIFtwb3Ag cV0gcmVtb3ZlcyBhbmQgcmV0dXJucyBmaXJzdCBlbGVtZW50IGluIFtxXSwg b3IgcmFpc2VzIFtRdWV1ZS5FbXB0eV0uICopCisJdmFsIHBvcDogKCdhLCAn YikgdCAtPiAnYQorCisJKCoqIFtwZWVrIHFdIHJldHVybnMgdGhlIGZpcnN0 IGVsZW1lbnQgaW4gW3FdLCBvciByYWlzZXMgW1F1ZXVlLkVtcHR5XS4gICop CisJdmFsIHBlZWsgOiAoJ2EsICdiKSB0IC0+ICdhCisKKwkoKiogW2xlbmd0 aCBxXSByZXR1cm5zIHRoZSBjdXJyZW50IG51bWJlciBvZiBlbGVtZW50cyBp biBbcV0gKikKKwl2YWwgbGVuZ3RoOiAoJ2EsICdiKSB0IC0+IGludAorCisJ KCoqIFtkZWJ1ZyBzdHJpbmdfb2ZfY2xhc3MgcV0gcHJpbnRzIHF1ZXVlIHVz YWdlIHN0YXRpc3RpY3MgaW4gYW4gdW5zcGVjaWZpZWQgaW50ZXJuYWwgZm9y bWF0LiAqKQorCXZhbCBkZWJ1ZzogKCdiIC0+IHN0cmluZykgLT4gKF8sICdi KSB0IC0+IHN0cmluZworZW5kID0gc3RydWN0CisJdHlwZSAoJ2EsICdiKSB0 ID0KKwkJeyBxOiAnYSBRdWV1ZS50CisJCTsgY2FwYWNpdHk6IGludAorCQk7 IGNsYXNzaWZ5OiAnYSAtPiAnYgorCQk7IGxpbWl0OiAnYiAtPiBpbnQKKwkJ OyBjbGFzc19jb3VudDogKCdiLCBpbnQpIEhhc2h0YmwudAorCQl9CisKKwls ZXQgY3JlYXRlIH5jYXBhY2l0eSB+Y2xhc3NpZnkgfmxpbWl0ID0KKwkJeyBj YXBhY2l0eTsgcSA9IFF1ZXVlLmNyZWF0ZSAoKTsgY2xhc3NpZnk7IGxpbWl0 OyBjbGFzc19jb3VudCA9IEhhc2h0YmwuY3JlYXRlIDMgfQorCisJbGV0IGdl dF9jb3VudCB0IGNsYXNzaWZpY2F0aW9uID0gdHJ5IEhhc2h0YmwuZmluZCB0 LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0aW9uIHdpdGggTm90X2ZvdW5kIC0+ IDAKKworCWxldCBjYW5fcHVzaF9pbnRlcm5hbCB0IGNsYXNzaWZpY2F0aW9u IGNsYXNzX2NvdW50ID0KKwkJUXVldWUubGVuZ3RoIHQucSA8IHQuY2FwYWNp dHkgJiYgY2xhc3NfY291bnQgPCB0LmxpbWl0IGNsYXNzaWZpY2F0aW9uCisK KwlsZXQgb2sgPSBTb21lICgpCisKKwlsZXQgcHVzaCBlIHQgPQorCQlsZXQg Y2xhc3NpZmljYXRpb24gPSB0LmNsYXNzaWZ5IGUgaW4KKwkJbGV0IGNsYXNz X2NvdW50ID0gZ2V0X2NvdW50IHQgY2xhc3NpZmljYXRpb24gaW4KKwkJaWYg Y2FuX3B1c2hfaW50ZXJuYWwgdCBjbGFzc2lmaWNhdGlvbiBjbGFzc19jb3Vu dCB0aGVuIGJlZ2luCisJCQlRdWV1ZS5wdXNoIGUgdC5xOworCQkJSGFzaHRi bC5yZXBsYWNlIHQuY2xhc3NfY291bnQgY2xhc3NpZmljYXRpb24gKGNsYXNz X2NvdW50ICsgMSk7CisJCQlvaworCQllbmQKKwkJZWxzZQorCQkJTm9uZQor CisJbGV0IGNhbl9wdXNoIHQgY2xhc3NpZmljYXRpb24gPQorCQljYW5fcHVz aF9pbnRlcm5hbCB0IGNsYXNzaWZpY2F0aW9uIEBAIGdldF9jb3VudCB0IGNs YXNzaWZpY2F0aW9uCisKKwlsZXQgY2xlYXIgdCA9CisJCVF1ZXVlLmNsZWFy IHQucTsKKwkJSGFzaHRibC5yZXNldCB0LmNsYXNzX2NvdW50CisKKwlsZXQg cG9wIHQgPQorCQlsZXQgZSA9IFF1ZXVlLnBvcCB0LnEgaW4KKwkJbGV0IGNs YXNzaWZpY2F0aW9uID0gdC5jbGFzc2lmeSBlIGluCisJCWxldCAoKSA9IG1h dGNoIGdldF9jb3VudCB0IGNsYXNzaWZpY2F0aW9uIC0gMSB3aXRoCisJCXwg MCAtPiBIYXNodGJsLnJlbW92ZSB0LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0 aW9uICgqIHJlZHVjZXMgbWVtdXNhZ2UgKikKKwkJfCBuIC0+IEhhc2h0Ymwu cmVwbGFjZSB0LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0aW9uIG4KKwkJaW4K KwkJZQorCisJbGV0IHBlZWsgdCA9IFF1ZXVlLnBlZWsgdC5xCisJbGV0IGxl bmd0aCB0ID0gUXVldWUubGVuZ3RoIHQucQorCisJbGV0IGRlYnVnIHN0cmlu Z19vZl9jbGFzcyB0ID0KKwkJbGV0IGIgPSBCdWZmZXIuY3JlYXRlIDEyOCBp bgorCQlQcmludGYuYnByaW50ZiBiICJCb3VuZGVkUXVldWUgY2FwYWNpdHk6 ICVkLCB1c2VkOiB7IiB0LmNhcGFjaXR5OworCQlIYXNodGJsLml0ZXIgKGZ1 biBwYWNrZXRfY2xhc3MgY291bnQgLT4KKwkJCVByaW50Zi5icHJpbnRmIGIg IgklczogJWQiIChzdHJpbmdfb2ZfY2xhc3MgcGFja2V0X2NsYXNzKSBjb3Vu dAorCQkpIHQuY2xhc3NfY291bnQ7CisJCVByaW50Zi5icHJpbnRmIGIgIn0i OworCQlCdWZmZXIuY29udGVudHMgYgorZW5kCisKKwogZXhjZXB0aW9uIEVu ZF9vZl9maWxlCiBleGNlcHRpb24gRWFnYWluCiBleGNlcHRpb24gTm9lbnQK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-oxenstored-07.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-oxenstored-07.patch" Content-Transfer-Encoding: base64 RnJvbSAzNzQ1NTRjOTJhODI5NDcyZWM0MjZmZDE1NjJkMDI4ZmQyZTMzMjY4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNCArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogTGltaXQgbWF4aW11bSBpbi1mbGlnaHQgcmVx dWVzdHMgLyBvdXRzdGFuZGluZyByZXBsaWVzCk1JTUUtVmVyc2lvbjogMS4w CkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250 ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgpJbnRyb2R1Y2UgYSBsaW1p dCBvbiB0aGUgbnVtYmVyIG9mIG91dHN0YW5kaW5nIHJlcGx5IHBhY2tldHMg aW4gdGhlIHhlbmJ1cwpxdWV1ZS4gIFRoaXMgbGltaXRzIHRoZSBudW1iZXIg b2YgaW4tZmxpZ2h0IHJlcXVlc3RzOiB3aGVuIHRoZSBvdXRwdXQgcXVldWUg aXMKZnVsbCB3ZSdsbCBzdG9wIHByb2Nlc3NpbmcgaW5wdXRzIHVudGlsIHRo ZSBvdXRwdXQgcXVldWUgaGFzIHJvb20gYWdhaW4uCgpUbyBhdm9pZCBhIGJ1 c3kgbG9vcCBvbiB0aGUgVW5peCBzb2NrZXQgd2Ugb25seSBhZGQgaXQgdG8g dGhlIHdhdGNoZWQgaW5wdXQKZmlsZSBkZXNjcmlwdG9yIHNldCBpZiB3ZSdk IGJlIGFibGUgdG8gY2FsbCBgaW5wdXRgIG9uIGl0LiAgRXZlbiB0aG91Z2gg RG9tMAppcyB0cnVzdGVkIGFuZCBleGVtcHQgZnJvbSBxdW90YXMgYSBmbG9v ZCBvZiBldmVudHMgbWlnaHQgY2F1c2UgYSBiYWNrbG9nCndoZXJlIGV2ZW50 cyBhcmUgcHJvZHVjZWQgZmFzdGVyIHRoYW4gZGFlbW9ucyBpbiBEb20wIGNh biBjb25zdW1lIHRoZW0sIHdoaWNoCmNvdWxkIGxlYWQgdG8gYW4gdW5ib3Vu ZGVkIHF1ZXVlIHNpemUgYW5kIE9PTS4KClRoZXJlZm9yZSB0aGUgeGVuYnVz IHF1ZXVlIGxpbWl0IG11c3QgYXBwbHkgdG8gYWxsIGNvbm5lY3Rpb25zLCBE b20wIGlzIG5vdApleGVtcHQgZnJvbSBpdCwgYWx0aG91Z2ggaWYgZXZlcnl0 aGluZyB3b3JrcyBjb3JyZWN0bHkgaXQgd2lsbCBldmVudHVhbGx5CmNhdGNo IHVwLgoKVGhpcyBwcmV2ZW50cyBhIG1hbGljaW91cyBndWVzdCBmcm9tIHNl bmRpbmcgbW9yZSBjb21tYW5kcyB3aGlsZSBpdCBoYXMKb3V0c3RhbmRpbmcg d2F0Y2ggZXZlbnRzIG9yIGNvbW1hbmQgcmVwbGllcyBpbiBpdHMgaW5wdXQg cmluZy4gIEhvd2V2ZXIgaWYgaXQKY2FuIGNhdXNlIHRoZSBnZW5lcmF0aW9u IG9mIHdhdGNoIGV2ZW50cyBieSBvdGhlciBtZWFucyAoZS5nLiBieSBEb20w LCBvcgphbm90aGVyIGNvb3BlcmF0aXZlIGd1ZXN0KSBhbmQgc3RvcCByZWFk aW5nIGl0cyBvd24gcmluZyB0aGVuIHdhdGNoIGV2ZW50cwp3b3VsZCd2ZSBx dWV1ZWQgdXAgd2l0aG91dCBsaW1pdC4KClRoZSB4ZW5zdG9yZSBwcm90b2Nv bCBkb2Vzbid0IGhhdmUgYSBiYWNrLXByZXNzdXJlIG1lY2hhbmlzbSwgYW5k IGRvZXNuJ3QKYWxsb3cgZHJvcHBpbmcgd2F0Y2ggZXZlbnRzLiAgSW4gZmFj dCwgZHJvcHBpbmcgd2F0Y2ggZXZlbnRzIGlzIGtub3duIHRvIGJyZWFrCnNv bWUgcGllY2VzIG9mIG5vcm1hbCBmdW5jdGlvbmFsaXR5LiAgVGhpcyBsZWF2 ZXMgbGl0dGxlIGNob2ljZSB0byBzYWZlbHkKaW1wbGVtZW50IHRoZSB4ZW5z dG9yZSBwcm90b2NvbCB3aXRob3V0IGV4cG9zaW5nIHRoZSB4ZW5zdG9yZSBk YWVtb24gdG8Kb3V0LW9mLW1lbW9yeSBhdHRhY2tzLgoKSW1wbGVtZW50IHRo ZSBmaXggYXMgcGlwZXMgd2l0aCBib3VuZGVkIGJ1ZmZlcnM6CiogVXNlIGEg Ym91bmRlZCBidWZmZXIgZm9yIHdhdGNoIGV2ZW50cwoqIFRoZSB3YXRjaCBz dHJ1Y3R1cmUgd2lsbCBoYXZlIGEgYm91bmRlZCByZWNlaXZpbmcgcGlwZSBv ZiB3YXRjaCBldmVudHMKKiBUaGUgc291cmNlIHdpbGwgaGF2ZSBhbiAib3Zl cmZsb3ciIHBpcGUgb2YgcGVuZGluZyB3YXRjaCBldmVudHMgaXQgY291bGRu J3QKICBkZWxpdmVyCgpJdGVtcyBhcmUgcXVldWVkIHVwIG9uIG9uZSBlbmQg YW5kIGFyZSBzZW50IGFzIGZhciBhbG9uZyB0aGUgcGlwZSBhcyBwb3NzaWJs ZToKCiAgc291cmNlIGRvbWFpbiAtPiB3YXRjaCAtPiB4ZW5idXMgb2YgdGFy Z2V0IC0+IHhlbnN0b3JlIHJpbmcvc29ja2V0IG9mIHRhcmdldAoKSWYgdGhl IHBpcGUgaXMgImZ1bGwiIGF0IGFueSBwb2ludCB0aGVuIGJhY2stcHJlc3N1 cmUgaXMgYXBwbGllZCBhbmQgd2UgcHJldmVudAptb3JlIGl0ZW1zIGZyb20g YmVpbmcgcXVldWVkIHVwLiAgRm9yIHRoZSBzb3VyY2UgZG9tYWluIHRoaXMg bWVhbnMgdGhhdCB3ZSdsbApzdG9wIGFjY2VwdGluZyBuZXcgY29tbWFuZHMg YXMgbG9uZyBhcyBpdHMgcGlwZSBidWZmZXIgaXMgbm90IGVtcHR5LgoKQmVm b3JlIHdlIHRyeSB0byBlbnF1ZXVlIGFuIGl0ZW0gd2UgZmlyc3QgY2hlY2sg d2hldGhlciBpdCBpcyBwb3NzaWJsZSB0byBzZW5kCml0IGZ1cnRoZXIgZG93 biB0aGUgcGlwZSwgYnkgYXR0ZW1wdGluZyB0byByZWN1cnNpdmVseSBmbHVz aCB0aGUgcGlwZXMuIFRoaXMKZW5zdXJlcyB0aGF0IHdlIHJldGFpbiB0aGUg b3JkZXIgb2YgZXZlbnRzIGFzIG11Y2ggYXMgcG9zc2libGUuCgpXZSBtaWdo dCBicmVhayBjYXVzYWxpdHkgb2Ygd2F0Y2ggZXZlbnRzIGlmIHRoZSB0YXJn ZXQgZG9tYWluJ3MgcXVldWUgaXMgZnVsbAphbmQgd2UgbmVlZCB0byBzdGFy dCB1c2luZyB0aGUgd2F0Y2gncyBxdWV1ZS4gIFRoaXMgaXMgYSBicmVha2lu ZyBjaGFuZ2UgaW4KdGhlIHhlbnN0b3JlIHByb3RvY29sLCBidXQgb25seSBm b3IgZG9tYWlucyB3aGljaCBhcmUgbm90IHByb2Nlc3NpbmcgdGhlaXIKaW5j b21pbmcgcmluZyBhcyBleHBlY3RlZC4KCldoZW4gYSB3YXRjaCBpcyBkZWxl dGVkIGl0cyBlbnRpcmUgcGVuZGluZyBxdWV1ZSBpcyBkcm9wcGVkIChubyBj b2RlIGlzIG5lZWRlZApmb3IgdGhhdCwgYmVjYXVzZSBpdCBpcyBwYXJ0IG9m IHRoZSAnd2F0Y2gnIHR5cGUpLgoKVGhlcmUgaXMgYSBjYWNoZSBvZiB3YXRj aGVzIHRoYXQgaGF2ZSBwZW5kaW5nIGV2ZW50cyB0aGF0IHdlIGF0dGVtcHQg dG8gZmx1c2gKYXQgZXZlcnkgY3ljbGUgaWYgcG9zc2libGUuCgpJbnRyb2R1 Y2UgMyBsaW1pdHMgaGVyZToKKiBxdW90YS1tYXh3YXRjaGV2ZW50cyBvbiB3 YXRjaCBldmVudCBkZXN0aW5hdGlvbjogd2hlbiB0aGlzIGlzIGhpdCB0aGUK ICBzb3VyY2Ugd2lsbCBub3QgYmUgYWxsb3dlZCB0byBxdWV1ZSB1cCBtb3Jl IHdhdGNoIGV2ZW50cy4KKiBxdW90YS1tYXhvdXN0YW5kaW5nIHdoaWNoIGlz IHRoZSBudW1iZXIgb2YgcmVzcG9uc2VzIG5vdCByZWFkIGZyb20gdGhlIHJp bmc6CiAgb25jZSBleGNlZWRlZCwgbm8gbW9yZSBpbnB1dHMgYXJlIHByb2Nl c3NlZCB1bnRpbCBhbGwgb3V0c3RhbmRpbmcgcmVwbGllcwogIGFyZSBjb25z dW1lZCBieSB0aGUgY2xpZW50LgoqIG92ZXJmbG93IHF1ZXVlIG9uIHRoZSB3 YXRjaCBldmVudCBzb3VyY2U6IGFsbCB3YXRjaGVzIHRoYXQgY2Fubm90IGJl IHN0b3JlZAogIG9uIGRlc3RpbmF0aW9uIGFyZSBxdWV1ZWQgdXAgaGVyZSwg YSBzaW5nbGUgY29tbWFuZCBjYW4gdHJpZ2dlciBtdWx0aXBsZQogIHdhdGNo ZXMgKGUuZy4gZHVlIHRvIHJlY3Vyc2lvbikuCgpUaGUgb3ZlcmZsb3cgcXVl dWUgY3VycmVudGx5IGRvZXNuJ3QgaGF2ZSBhbiB1cHBlciBib3VuZCwgaXQg aXMgZGlmZmljdWx0IHRvCmFjY3VyYXRlbHkgY2FsY3VsYXRlIG9uZSBhcyBp dCBkZXBlbmRzIG9uIHdoZXRoZXIgeW91IGFyZSBEb20wIGFuZCBob3cgbWFu eQp3YXRjaGVzIGVhY2ggcGF0aCBoYXMgcmVnaXN0ZXJlZCBhbmQgaG93IG1h bnkgd2F0Y2ggZXZlbnRzIHlvdSBjYW4gdHJpZ2dlcgp3aXRoIGEgc2luZ2xl IGNvbW1hbmQgKGUuZy4gYSBjb21taXQpLiAgSG93ZXZlciB0aGVzZSBldmVu dHMgd2VyZSBhbHJlYWR5CnVzaW5nIG1lbW9yeSwgdGhpcyBqdXN0IG1vdmVz IHRoZW0gZWxzZXdoZXJlLCBhbmQgYXMgbG9uZyBhcyB3ZSBjb3JyZWN0bHkK YmxvY2sgYSBkb21haW4gaXQgc2hvdWxkbid0IHJlc3VsdCBpbiB1bmJvdW5k ZWQgbWVtb3J5IHVzYWdlLgoKTm90ZSB0aGF0IERvbTAgaXMgbm90IGV4Y2x1 ZGVkIGZyb20gdGhlc2UgY2hlY2tzLCBpdCBpcyBpbXBvcnRhbnQgdGhhdCBE b20wIGlzCmVzcGVjaWFsbHkgbm90IGV4Y2x1ZGVkIHdoZW4gaXQgaXMgdGhl IHNvdXJjZSwgc2luY2UgdGhlcmUgYXJlIG1hbnkgd2F5cyBpbgp3aGljaCBh IGd1ZXN0IGNvdWxkIHRyaWdnZXIgRG9tMCB0byBzZW5kIGl0IHdhdGNoIGV2 ZW50cy4KClRoaXMgc2hvdWxkIHByb3RlY3QgYWdhaW5zdCBtYWxpY2lvdXMg ZnJvbnRlbmRzIGFzIGxvbmcgYXMgdGhlIGJhY2tlbmQgZm9sbG93cwp0aGUg UFYgeGVuc3RvcmUgcHJvdG9jb2wgYW5kIG9ubHkgZXhwb3NlcyBwYXRocyBu ZWVkZWQgYnkgdGhlIGZyb250ZW5kLCBhbmQKY2hhbmdlcyB0aG9zZSBwYXRo cyBhdCBtb3N0IG9uY2UgYXMgYSByZWFjdGlvbiB0byBndWVzdCBldmVudHMs IG9yIHByb3RvY29sCnN0YXRlLgoKVGhlIHF1ZXVlIGxpbWl0cyBhcmUgcGVy IHdhdGNoLCBhbmQgcGVyIGRvbWFpbi1wYWlyLCBzbyBldmVuIGlmIG9uZQpj b21tdW5pY2F0aW9uIGNoYW5uZWwgd291bGQgYmUgImJsb2NrZWQiLCBvdGhl cnMgd291bGQga2VlcCB3b3JraW5nLCBhbmQgdGhlCmRvbWFpbiBpdHNlbGYg d29uJ3QgZ2V0IGJsb2NrZWQgYXMgbG9uZyBhcyBpdCBkb2Vzbid0IG92ZXJm bG93IHRoZSBxdWV1ZSBvZgp3YXRjaCBldmVudHMuCgpTaW1pbGFybHkgYSBt YWxpY2lvdXMgYmFja2VuZCBjb3VsZCBjYXVzZSB0aGUgZnJvbnRlbmQgdG8g Z2V0IGJsb2NrZWQsIGJ1dAp0aGlzIHdhdGNoIHF1ZXVlIHByb3RlY3RzIHRo ZSBmcm9udGVuZCBhcyB3ZWxsIGFzIGxvbmcgYXMgaXQgZm9sbG93cyB0aGUg UFYKcHJvdG9jb2wuICAoQWx0aG91Z2ggbm90ZSB0aGF0IHByb3RlY3Rpb24g YWdhaW5zdCBtYWxpY2lvdXMgYmFja2VuZHMgaXMgb25seSBhCmJlc3QgZWZm b3J0IGF0IHRoZSBtb21lbnQpCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNiAv IENWRS0yMDIyLTQyMzE4LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLD tmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJpc3Rp YW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbCBiL3Rvb2xzL29j YW1sL2xpYnMveGIveGIubWwKaW5kZXggNDE5N2EzODg4YTY4Li5iMjkyZWQ3 YTg3NGQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWwK KysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbApAQCAtMTM0LDE0ICsx MzQsNDQgQEAgdHlwZSBiYWNrZW5kID0gRmQgb2YgYmFja2VuZF9mZCB8IFhl bm1tYXAgb2YgYmFja2VuZF9tbWFwCiAKIHR5cGUgcGFydGlhbF9idWYgPSBI YXZlSGRyIG9mIFBhcnRpYWwucGt0IHwgTm9IZHIgb2YgaW50ICogYnl0ZXMK IAorKCoKKwlzZXBhcmF0ZSBjYXBhY2l0eSByZXNlcnZhdGlvbiBmb3IgcmVw bGllcyBhbmQgd2F0Y2ggZXZlbnRzOgorCXRoaXMgYWxsb3dzIGEgZG9tYWlu IHRvIGtlZXAgd29ya2luZyBldmVuIHdoZW4gdW5kZXIgYSBjb25zdGFudCBm bG9vZCBvZgorCXdhdGNoIGV2ZW50cworKikKK3R5cGUgY2FwYWNpdHkgPSB7 IG1heG91dHN0YW5kaW5nOiBpbnQ7IG1heHdhdGNoZXZlbnRzOiBpbnQgfQor Cittb2R1bGUgUXVldWUgPSBCb3VuZGVkUXVldWUKKwordHlwZSBwYWNrZXRf Y2xhc3MgPQorCXwgQ29tbWFuZFJlcGx5CisJfCBXYXRjaGV2ZW50CisKK2xl dCBzdHJpbmdfb2ZfcGFja2V0X2NsYXNzID0gZnVuY3Rpb24KKwl8IENvbW1h bmRSZXBseSAtPiAiY29tbWFuZF9yZXBseSIKKwl8IFdhdGNoZXZlbnQgLT4g IndhdGNoX2V2ZW50IgorCiB0eXBlIHQgPQogewogCWJhY2tlbmQ6IGJhY2tl bmQ7Ci0JcGt0X291dDogUGFja2V0LnQgUXVldWUudDsKKwlwa3Rfb3V0OiAo UGFja2V0LnQsIHBhY2tldF9jbGFzcykgUXVldWUudDsKIAltdXRhYmxlIHBh cnRpYWxfaW46IHBhcnRpYWxfYnVmOwogCW11dGFibGUgcGFydGlhbF9vdXQ6 IHN0cmluZzsKKwljYXBhY2l0eTogY2FwYWNpdHkKIH0KIAorbGV0IHRvX3Jl YWQgY29uID0KKwltYXRjaCBjb24ucGFydGlhbF9pbiB3aXRoCisJCXwgSGF2 ZUhkciBwYXJ0aWFsX3BrdCAtPiBQYXJ0aWFsLnRvX2NvbXBsZXRlIHBhcnRp YWxfcGt0CisJCXwgTm9IZHIgICAoaSwgXykgICAgLT4gaQorCitsZXQgZGVi dWcgdCA9CisJUHJpbnRmLnNwcmludGYgIlhlbkJ1cyBzdGF0ZTogcGFydGlh bF9pbjogJWQgbmVlZGVkLCBwYXJ0aWFsX291dDogJWQgYnl0ZXMsIHBrdF9v dXQ6ICVkIHBhY2tldHMsICVzIgorCQkodG9fcmVhZCB0KQorCQkoU3RyaW5n Lmxlbmd0aCB0LnBhcnRpYWxfb3V0KQorCQkoUXVldWUubGVuZ3RoIHQucGt0 X291dCkKKwkJKEJvdW5kZWRRdWV1ZS5kZWJ1ZyBzdHJpbmdfb2ZfcGFja2V0 X2NsYXNzIHQucGt0X291dCkKKwogbGV0IGluaXRfcGFydGlhbF9pbiAoKSA9 IE5vSGRyCiAJKFBhcnRpYWwuaGVhZGVyX3NpemUgKCksIEJ5dGVzLm1ha2Ug KFBhcnRpYWwuaGVhZGVyX3NpemUoKSkgJ1wwMDAnKQogCkBAIC0xOTksNyAr MjI5LDggQEAgbGV0IG91dHB1dCBjb24gPQogCWxldCBzID0gaWYgU3RyaW5n Lmxlbmd0aCBjb24ucGFydGlhbF9vdXQgPiAwIHRoZW4KIAkJCWNvbi5wYXJ0 aWFsX291dAogCQllbHNlIGlmIFF1ZXVlLmxlbmd0aCBjb24ucGt0X291dCA+ IDAgdGhlbgotCQkJUGFja2V0LnRvX3N0cmluZyAoUXVldWUucG9wIGNvbi5w a3Rfb3V0KQorCQkJbGV0IHBrdCA9IFF1ZXVlLnBvcCBjb24ucGt0X291dCBp bgorCQkJUGFja2V0LnRvX3N0cmluZyBwa3QKIAkJZWxzZQogCQkJIiIgaW4K IAkoKiBzZW5kIGRhdGEgZnJvbSBzLCBhbmQgc2F2ZSB0aGUgdW5zZW50IGRh dGEgdG8gcGFydGlhbF9vdXQgKikKQEAgLTIxMiwxMiArMjQzLDE1IEBAIGxl dCBvdXRwdXQgY29uID0KIAkoKiBhZnRlciBzZW5kaW5nIG9uZSBwYWNrZXQs IHBhcnRpYWwgaXMgZW1wdHkgKikKIAljb24ucGFydGlhbF9vdXQgPSAiIgog CisoKiB3ZSBjYW4gb25seSBwcm9jZXNzIGFuIGlucHV0IHBhY2tldCBpZiB3 ZSdyZSBndWFyYW50ZWVkIHRvIGhhdmUgcm9vbQorICAgdG8gc3RvcmUgdGhl IHJlc3BvbnNlIHBhY2tldCAqKQorbGV0IGNhbl9pbnB1dCBjb24gPSBRdWV1 ZS5jYW5fcHVzaCBjb24ucGt0X291dCBDb21tYW5kUmVwbHkKKwogKCogTkI6 IGNhbiB0aHJvdyBSZWNvbm5lY3QgKikKIGxldCBpbnB1dCBjb24gPQotCWxl dCB0b19yZWFkID0KLQkJbWF0Y2ggY29uLnBhcnRpYWxfaW4gd2l0aAotCQl8 IEhhdmVIZHIgcGFydGlhbF9wa3QgLT4gUGFydGlhbC50b19jb21wbGV0ZSBw YXJ0aWFsX3BrdAotCQl8IE5vSGRyICAgKGksIF8pICAgIC0+IGkgaW4KKwlp ZiBub3QgKGNhbl9pbnB1dCBjb24pIHRoZW4gTm9uZQorCWVsc2UKKwlsZXQg dG9fcmVhZCA9IHRvX3JlYWQgY29uIGluCiAKIAkoKiB0cnkgdG8gZ2V0IG1v cmUgZGF0YSBmcm9tIGlucHV0IHN0cmVhbSAqKQogCWxldCBiID0gQnl0ZXMu bWFrZSB0b19yZWFkICdcMDAwJyBpbgpAQCAtMjQzLDExICsyNzcsMjIgQEAg bGV0IGlucHV0IGNvbiA9CiAJCU5vbmUKIAkpCiAKLWxldCBuZXdjb24gYmFj a2VuZCA9IHsKK2xldCBjbGFzc2lmeSB0ID0KKwltYXRjaCB0LlBhY2tldC50 eSB3aXRoCisJfCBPcC5XYXRjaGV2ZW50IC0+IFdhdGNoZXZlbnQKKwl8IF8g LT4gQ29tbWFuZFJlcGx5CisKK2xldCBuZXdjb24gfmNhcGFjaXR5IGJhY2tl bmQgPQorCWxldCBsaW1pdCA9IGZ1bmN0aW9uCisJCXwgQ29tbWFuZFJlcGx5 IC0+IGNhcGFjaXR5Lm1heG91dHN0YW5kaW5nCisJCXwgV2F0Y2hldmVudCAt PiBjYXBhY2l0eS5tYXh3YXRjaGV2ZW50cworCWluCisJewogCWJhY2tlbmQg PSBiYWNrZW5kOwotCXBrdF9vdXQgPSBRdWV1ZS5jcmVhdGUgKCk7CisJcGt0 X291dCA9IFF1ZXVlLmNyZWF0ZSB+Y2FwYWNpdHk6KGNhcGFjaXR5Lm1heG91 dHN0YW5kaW5nICsgY2FwYWNpdHkubWF4d2F0Y2hldmVudHMpIH5jbGFzc2lm eSB+bGltaXQ7CiAJcGFydGlhbF9pbiA9IGluaXRfcGFydGlhbF9pbiAoKTsK IAlwYXJ0aWFsX291dCA9ICIiOworCWNhcGFjaXR5ID0gY2FwYWNpdHk7CiAJ fQogCiBsZXQgb3Blbl9mZCBmZCA9IG5ld2NvbiAoRmQgeyBmZCA9IGZkOyB9 KQpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbGkgYi90 b29scy9vY2FtbC9saWJzL3hiL3hiLm1saQppbmRleCA5MWM2ODIxNjJjZWEu LjcxYjI3NTRjYTc4OCAxMDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94 Yi94Yi5tbGkKKysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbGkKQEAg LTY2LDEwICs2NiwxMSBAQCB0eXBlIGJhY2tlbmRfbW1hcCA9IHsKIHR5cGUg YmFja2VuZF9mZCA9IHsgZmQgOiBVbml4LmZpbGVfZGVzY3I7IH0KIHR5cGUg YmFja2VuZCA9IEZkIG9mIGJhY2tlbmRfZmQgfCBYZW5tbWFwIG9mIGJhY2tl bmRfbW1hcAogdHlwZSBwYXJ0aWFsX2J1ZiA9IEhhdmVIZHIgb2YgUGFydGlh bC5wa3QgfCBOb0hkciBvZiBpbnQgKiBieXRlcwordHlwZSBjYXBhY2l0eSA9 IHsgbWF4b3V0c3RhbmRpbmc6IGludDsgbWF4d2F0Y2hldmVudHM6IGludCB9 CiB0eXBlIHQKIHZhbCBpbml0X3BhcnRpYWxfaW4gOiB1bml0IC0+IHBhcnRp YWxfYnVmCiB2YWwgcmVjb25uZWN0IDogdCAtPiB1bml0Ci12YWwgcXVldWUg OiB0IC0+IFBhY2tldC50IC0+IHVuaXQKK3ZhbCBxdWV1ZSA6IHQgLT4gUGFj a2V0LnQgLT4gdW5pdCBvcHRpb24KIHZhbCByZWFkX2ZkIDogYmFja2VuZF9m ZCAtPiAnYSAtPiBieXRlcyAtPiBpbnQgLT4gaW50CiB2YWwgcmVhZF9tbWFw IDogYmFja2VuZF9tbWFwIC0+ICdhIC0+IGJ5dGVzIC0+IGludCAtPiBpbnQK IHZhbCByZWFkIDogdCAtPiBieXRlcyAtPiBpbnQgLT4gaW50CkBAIC03OCwx MyArNzksMTQgQEAgdmFsIHdyaXRlX21tYXAgOiBiYWNrZW5kX21tYXAgLT4g J2EgLT4gc3RyaW5nIC0+IGludCAtPiBpbnQKIHZhbCB3cml0ZSA6IHQgLT4g c3RyaW5nIC0+IGludCAtPiBpbnQKIHZhbCBvdXRwdXQgOiB0IC0+IGJvb2wK IHZhbCBpbnB1dCA6IHQgLT4gUGFja2V0LnQgb3B0aW9uCi12YWwgbmV3Y29u IDogYmFja2VuZCAtPiB0Ci12YWwgb3Blbl9mZCA6IFVuaXguZmlsZV9kZXNj ciAtPiB0Ci12YWwgb3Blbl9tbWFwIDogWGVubW1hcC5tbWFwX2ludGVyZmFj ZSAtPiAodW5pdCAtPiB1bml0KSAtPiB0Cit2YWwgbmV3Y29uIDogY2FwYWNp dHk6Y2FwYWNpdHkgLT4gYmFja2VuZCAtPiB0Cit2YWwgb3Blbl9mZCA6IFVu aXguZmlsZV9kZXNjciAtPiBjYXBhY2l0eTpjYXBhY2l0eSAtPiB0Cit2YWwg b3Blbl9tbWFwIDogWGVubW1hcC5tbWFwX2ludGVyZmFjZSAtPiAodW5pdCAt PiB1bml0KSAtPiBjYXBhY2l0eTpjYXBhY2l0eSAtPiB0CiB2YWwgY2xvc2Ug OiB0IC0+IHVuaXQKIHZhbCBpc19mZCA6IHQgLT4gYm9vbAogdmFsIGlzX21t YXAgOiB0IC0+IGJvb2wKIHZhbCBvdXRwdXRfbGVuIDogdCAtPiBpbnQKK3Zh bCBjYW5faW5wdXQ6IHQgLT4gYm9vbAogdmFsIGhhc19uZXdfb3V0cHV0IDog dCAtPiBib29sCiB2YWwgaGFzX29sZF9vdXRwdXQgOiB0IC0+IGJvb2wKIHZh bCBoYXNfb3V0cHV0IDogdCAtPiBib29sCkBAIC05MywzICs5NSw0IEBAIHZh bCBoYXNfcGFydGlhbF9pbnB1dCA6IHQgLT4gYm9vbAogdmFsIGhhc19tb3Jl X2lucHV0IDogdCAtPiBib29sCiB2YWwgaXNfc2VsZWN0YWJsZSA6IHQgLT4g Ym9vbAogdmFsIGdldF9mZCA6IHQgLT4gVW5peC5maWxlX2Rlc2NyCit2YWwg ZGVidWc6IHQgLT4gc3RyaW5nCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9s aWJzL3hzL3F1ZXVlb3AubWwgYi90b29scy9vY2FtbC9saWJzL3hzL3F1ZXVl b3AubWwKaW5kZXggOWZmNWJiZDUyOWNlLi40ZTUzMmNkYWVhY2IgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveHMvcXVldWVvcC5tbAorKysgYi90 b29scy9vY2FtbC9saWJzL3hzL3F1ZXVlb3AubWwKQEAgLTE2LDkgKzE2LDEw IEBACiBvcGVuIFhlbmJ1cwogCiBsZXQgZGF0YV9jb25jYXQgbHMgPSAoU3Ry aW5nLmNvbmNhdCAiXDAwMCIgbHMpIF4gIlwwMDAiCitsZXQgcXVldWUgY29u IHBrdCA9IGxldCByID0gWGIucXVldWUgY29uIHBrdCBpbiBhc3NlcnQgKHIg PD4gTm9uZSkKIGxldCBxdWV1ZV9wYXRoIHR5ICh0aWQ6IGludCkgKHBhdGg6 IHN0cmluZykgY29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgcGF0 aDsgXSBpbgotCVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSB0aWQg MCB0eSBkYXRhKQorCXF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSB0aWQg MCB0eSBkYXRhKQogCiAoKiBvcGVyYXRpb25zICopCiBsZXQgZGlyZWN0b3J5 IHRpZCBwYXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuRGlyZWN0b3J5IHRp ZCBwYXRoIGNvbgpAQCAtMjcsNDggKzI4LDQ4IEBAIGxldCByZWFkIHRpZCBw YXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuUmVhZCB0aWQgcGF0aCBjb24K IGxldCBnZXRwZXJtcyB0aWQgcGF0aCBjb24gPSBxdWV1ZV9wYXRoIFhiLk9w LkdldHBlcm1zIHRpZCBwYXRoIGNvbgogCiBsZXQgZGVidWcgY29tbWFuZHMg Y29uID0KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhi Lk9wLkRlYnVnIChkYXRhX2NvbmNhdCBjb21tYW5kcykpCisJcXVldWUgY29u IChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5EZWJ1ZyAoZGF0YV9jb25j YXQgY29tbWFuZHMpKQogCiBsZXQgd2F0Y2ggcGF0aCBkYXRhIGNvbiA9CiAJ bGV0IGRhdGEgPSBkYXRhX2NvbmNhdCBbIHBhdGg7IGRhdGE7IF0gaW4KLQlY Yi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhiLk9wLldhdGNo IGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5P cC5XYXRjaCBkYXRhKQogCiBsZXQgdW53YXRjaCBwYXRoIGRhdGEgY29uID0K IAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgcGF0aDsgZGF0YTsgXSBpbgot CVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuVW53 YXRjaCBkYXRhKQorCXF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAg WGIuT3AuVW53YXRjaCBkYXRhKQogCiBsZXQgdHJhbnNhY3Rpb25fc3RhcnQg Y29uID0KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhi Lk9wLlRyYW5zYWN0aW9uX3N0YXJ0IChkYXRhX2NvbmNhdCBbXSkpCisJcXVl dWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5UcmFuc2FjdGlv bl9zdGFydCAoZGF0YV9jb25jYXQgW10pKQogCiBsZXQgdHJhbnNhY3Rpb25f ZW5kIHRpZCBjb21taXQgY29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0 IFsgKGlmIGNvbW1pdCB0aGVuICJUIiBlbHNlICJGIik7IF0gaW4KLQlYYi5x dWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuVHJhbnNh Y3Rpb25fZW5kIGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRl IHRpZCAwIFhiLk9wLlRyYW5zYWN0aW9uX2VuZCBkYXRhKQogCiBsZXQgaW50 cm9kdWNlIGRvbWlkIG1mbiBwb3J0IGNvbiA9CiAJbGV0IGRhdGEgPSBkYXRh X2NvbmNhdCBbIFByaW50Zi5zcHJpbnRmICIldSIgZG9taWQ7CiAJICAgICAg ICAgICAgICAgICAgICAgICAgIFByaW50Zi5zcHJpbnRmICIlbnUiIG1mbjsK IAkgICAgICAgICAgICAgICAgICAgICAgICAgc3RyaW5nX29mX2ludCBwb3J0 OyBdIGluCi0JWGIucXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBY Yi5PcC5JbnRyb2R1Y2UgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBhY2tldC5j cmVhdGUgMCAwIFhiLk9wLkludHJvZHVjZSBkYXRhKQogCiBsZXQgcmVsZWFz ZSBkb21pZCBjb24gPQogCWxldCBkYXRhID0gZGF0YV9jb25jYXQgWyBQcmlu dGYuc3ByaW50ZiAiJXUiIGRvbWlkOyBdIGluCi0JWGIucXVldWUgY29uIChY Yi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5SZWxlYXNlIGRhdGEpCisJcXVl dWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5SZWxlYXNlIGRh dGEpCiAKIGxldCByZXN1bWUgZG9taWQgY29uID0KIAlsZXQgZGF0YSA9IGRh dGFfY29uY2F0IFsgUHJpbnRmLnNwcmludGYgIiV1IiBkb21pZDsgXSBpbgot CVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuUmVz dW1lIGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBY Yi5PcC5SZXN1bWUgZGF0YSkKIAogbGV0IGdldGRvbWFpbnBhdGggZG9taWQg Y29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgUHJpbnRmLnNwcmlu dGYgIiV1IiBkb21pZDsgXSBpbgotCVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0 LmNyZWF0ZSAwIDAgWGIuT3AuR2V0ZG9tYWlucGF0aCBkYXRhKQorCXF1ZXVl IGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuR2V0ZG9tYWlucGF0 aCBkYXRhKQogCiBsZXQgd3JpdGUgdGlkIHBhdGggdmFsdWUgY29uID0KIAls ZXQgZGF0YSA9IHBhdGggXiAiXDAwMCIgXiB2YWx1ZSAoKiBubyBOVUxMIGF0 IHRoZSBlbmQgKikgaW4KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVh dGUgdGlkIDAgWGIuT3AuV3JpdGUgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBh Y2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuV3JpdGUgZGF0YSkKIAogbGV0IG1r ZGlyIHRpZCBwYXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuTWtkaXIgdGlk IHBhdGggY29uCiBsZXQgcm0gdGlkIHBhdGggY29uID0gcXVldWVfcGF0aCBY Yi5PcC5SbSB0aWQgcGF0aCBjb24KIAogbGV0IHNldHBlcm1zIHRpZCBwYXRo IHBlcm1zIGNvbiA9CiAJbGV0IGRhdGEgPSBkYXRhX2NvbmNhdCBbIHBhdGg7 IHBlcm1zIF0gaW4KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUg dGlkIDAgWGIuT3AuU2V0cGVybXMgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBh Y2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuU2V0cGVybXMgZGF0YSkKZGlmZiAt LWdpdCBhL3Rvb2xzL29jYW1sL2xpYnMveHMveHNyYXcubWwgYi90b29scy9v Y2FtbC9saWJzL3hzL3hzcmF3Lm1sCmluZGV4IDQ1MWY4YjM4ZGJjYy4uY2Jk MTcyODA2MDBjIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9saWJzL3hzL3hz cmF3Lm1sCisrKyBiL3Rvb2xzL29jYW1sL2xpYnMveHMveHNyYXcubWwKQEAg LTM2LDggKzM2LDEwIEBAIHR5cGUgY29uID0gewogbGV0IGNsb3NlIGNvbiA9 CiAJWGIuY2xvc2UgY29uLnhiCiAKK2xldCBjYXBhY2l0eSA9IHsgWGIubWF4 b3V0c3RhbmRpbmcgPSAxOyBtYXh3YXRjaGV2ZW50cyA9IDA7IH0KKwogbGV0 IG9wZW5fZmQgZmQgPSB7Ci0JeGIgPSBYYi5vcGVuX2ZkIGZkOworCXhiID0g WGIub3Blbl9mZCB+Y2FwYWNpdHkgZmQ7CiAJd2F0Y2hldmVudHMgPSBRdWV1 ZS5jcmVhdGUgKCk7CiB9CiAKZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hl bnN0b3JlZC9jb25uZWN0aW9uLm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVk L2Nvbm5lY3Rpb24ubWwKaW5kZXggYWNlMmFhNWI0ZjUzLi45YWFkNDUxYTJk YmQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0 aW9uLm1sCisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9u Lm1sCkBAIC0yMCwxMiArMjAsODQgQEAgb3BlbiBTdGRleHQKIAogbGV0IHhl bnN0b3JlX3BheWxvYWRfbWF4ID0gNDA5NiAoKiB4ZW4vaW5jbHVkZS9wdWJs aWMvaW8veHNfd2lyZS5oICopCiAKK3R5cGUgJ2EgYm91bmRlZF9zZW5kZXIg PSAnYSAtPiB1bml0IG9wdGlvbgorKCoqIGEgYm91bmRlZCBzZW5kZXIgYWNj ZXB0cyBhbiBbJ2FdIGl0ZW0gYW5kIHJldHVybnM6CisgICAgTm9uZSAtIGlm IHRoZXJlIGlzIG5vIHJvb20gdG8gYWNjZXB0IHRoZSBpdGVtCisgICAgU29t ZSAoKSAtICBpZiBpdCBoYXMgc3VjY2Vzc2Z1bGx5IGFjY2VwdGVkL3NlbnQg dGhlIGl0ZW0KKyAqKQorCittb2R1bGUgQm91bmRlZFBpcGUgOiBzaWcKKwl0 eXBlICdhIHQKKworCSgqKiBbY3JlYXRlIH5jYXBhY2l0eSB+ZGVzdGluYXRp b25dIGNyZWF0ZXMgYSBib3VuZGVkIHBpcGUgd2l0aCBhCisJICAgIGxvY2Fs IGJ1ZmZlciBob2xkaW5nIGF0IG1vc3QgW2NhcGFjaXR5XSBpdGVtcy4gIE9u Y2UgdGhlIGJ1ZmZlciBpcworCSAgICBmdWxsIGl0IHdpbGwgbm90IGFjY2Vw dCBmdXJ0aGVyIGl0ZW1zLiAgaXRlbXMgZnJvbSB0aGUgcGlwZSBhcmUKKwkg ICAgZmx1c2hlZCBpbnRvIFtkZXN0aW5hdGlvbl0gYXMgbG9uZyBhcyBpdCBh Y2NlcHRzIGl0ZW1zLiAgVGhlCisJICAgIGRlc3RpbmF0aW9uIGNvdWxkIGJl IGFub3RoZXIgcGlwZS4KKwkgKikKKwl2YWwgY3JlYXRlOiBjYXBhY2l0eTpp bnQgLT4gZGVzdGluYXRpb246J2EgYm91bmRlZF9zZW5kZXIgLT4gJ2EgdAor CisJKCoqIFtpc19lbXB0eSB0XSByZXR1cm5zIHdoZXRoZXIgdGhlIGxvY2Fs IGJ1ZmZlciBvZiBbdF0gaXMgZW1wdHkuICopCisJdmFsIGlzX2VtcHR5IDog XyB0IC0+IGJvb2wKKworCSgqKiBbbGVuZ3RoIHRdIHRoZSBudW1iZXIgb2Yg aXRlbXMgaW4gdGhlIGludGVybmFsIGJ1ZmZlciAqKQorCXZhbCBsZW5ndGg6 IF8gdCAtPiBpbnQKKworCSgqKiBbZmx1c2hfcGlwZSB0XSBzZW5kcyBhcyBt YW55IGl0ZW1zIGZyb20gdGhlIGxvY2FsIGJ1ZmZlciBhcyBwb3NzaWJsZSwK KwkJCXdoaWNoIGNvdWxkIGJlIG5vbmUuICopCisJdmFsIGZsdXNoX3BpcGU6 IF8gdCAtPiB1bml0CisKKwkoKiogW3B1c2ggdCBpdGVtXSB0cmllcyB0byBb Zmx1c2hfcGlwZV0gYW5kIHRoZW4gcHVzaCBbaXRlbV0KKwkgICAgaW50byB0 aGUgcGlwZSBpZiBpdHMgW2NhcGFjaXR5XSBhbGxvd3MuCisJICAgIFJldHVy bnMgW05vbmVdIGlmIHRoZXJlIGlzIG5vIG1vcmUgcm9vbQorCSAqKQorCXZh bCBwdXNoIDogJ2EgdCAtPiAnYSBib3VuZGVkX3NlbmRlcgorZW5kID0gc3Ry dWN0CisJKCogaXRlbXMgYXJlIGVucXVldWVkIGluIFtxXSwgYW5kIHRoZW4g Zmx1c2hlZCB0byBbY29ubmVjdF90b10gKikKKwl0eXBlICdhIHQgPQorCQl7 IHE6ICdhIFF1ZXVlLnQKKwkJOyBkZXN0aW5hdGlvbjogJ2EgYm91bmRlZF9z ZW5kZXIKKwkJOyBjYXBhY2l0eTogaW50CisJCX0KKworCWxldCBjcmVhdGUg fmNhcGFjaXR5IH5kZXN0aW5hdGlvbiA9CisJCXsgcSA9IFF1ZXVlLmNyZWF0 ZSAoKTsgY2FwYWNpdHk7IGRlc3RpbmF0aW9uIH0KKworCWxldCByZWMgZmx1 c2hfcGlwZSB0ID0KKwkJaWYgbm90IFF1ZXVlLihpc19lbXB0eSB0LnEpIHRo ZW4KKwkJCWxldCBpdGVtID0gUXVldWUucGVlayB0LnEgaW4KKwkJCW1hdGNo IHQuZGVzdGluYXRpb24gaXRlbSB3aXRoCisJCQl8IE5vbmUgLT4gKCkgKCog bm8gcm9vbSAqKQorCQkJfCBTb21lICgpIC0+CisJCQkJKCogc3VjY2Vzc2Z1 bGx5IHNlbnQgaXRlbSB0byBuZXh0IHN0YWdlICopCisJCQkJbGV0IF8gPSBR dWV1ZS5wb3AgdC5xIGluCisJCQkJKCogY29udGludWUgdHJ5aW5nIHRvIHNl bmQgbW9yZSBpdGVtcyAqKQorCQkJCWZsdXNoX3BpcGUgdAorCisJbGV0IHB1 c2ggdCBpdGVtID0KKwkJKCogZmlyc3QgdHJ5IHRvIGZsdXNoIGFzIG1hbnkg aXRlbXMgZnJvbSB0aGlzIHBpcGUgYXMgcG9zc2libGUgdG8gbWFrZSByb29t LAorCQkgICBpdCBpcyBpbXBvcnRhbnQgdG8gZG8gdGhpcyBmaXJzdCB0byBw cmVzZXJ2ZSB0aGUgb3JkZXIgb2YgdGhlIGl0ZW1zCisJCSAqKQorCQlmbHVz aF9waXBlIHQ7CisJCWlmIFF1ZXVlLmxlbmd0aCB0LnEgPCB0LmNhcGFjaXR5 IHRoZW4gYmVnaW4KKwkJCSgqIGVucXVldWUsIGluc3RlYWQgb2Ygc2VuZGlu ZyBkaXJlY3RseS4KKwkJCSAgIHRoaXMgZW5zdXJlcyB0aGF0IFtvdXRdIHNl ZXMgdGhlIGl0ZW1zIGluIHRoZSBzYW1lIG9yZGVyIGFzIHdlIHJlY2VpdmUg dGhlbQorCQkJICopCisJCQlRdWV1ZS5wdXNoIGl0ZW0gdC5xOworCQkJU29t ZSAoZmx1c2hfcGlwZSB0KQorCQllbmQgZWxzZSBOb25lCisKKwlsZXQgaXNf ZW1wdHkgdCA9IFF1ZXVlLmlzX2VtcHR5IHQucQorCWxldCBsZW5ndGggdCA9 IFF1ZXVlLmxlbmd0aCB0LnEKK2VuZAorCiB0eXBlIHdhdGNoID0gewogCWNv bjogdDsKIAl0b2tlbjogc3RyaW5nOwogCXBhdGg6IHN0cmluZzsKIAliYXNl OiBzdHJpbmc7CiAJaXNfcmVsYXRpdmU6IGJvb2w7CisJcGVuZGluZ193YXRj aGV2ZW50czogWGVuYnVzLlhiLlBhY2tldC50IEJvdW5kZWRQaXBlLnQ7CiB9 CiAKIGFuZCB0ID0gewpAQCAtMzgsOCArMTEwLDM2IEBAIGFuZCB0ID0gewog CWFub25pZDogaW50OwogCW11dGFibGUgc3RhdF9uYl9vcHM6IGludDsKIAlt dXRhYmxlIHBlcm06IFBlcm1zLkNvbm5lY3Rpb24udDsKKwlwZW5kaW5nX3Nv dXJjZV93YXRjaGV2ZW50czogKHdhdGNoICogWGVuYnVzLlhiLlBhY2tldC50 KSBCb3VuZGVkUGlwZS50CiB9CiAKK21vZHVsZSBXYXRjaCA9IHN0cnVjdAor CW1vZHVsZSBUID0gc3RydWN0CisJCXR5cGUgdCA9IHdhdGNoCisKKwkJbGV0 IGNvbXBhcmUgdzEgdzIgPQorCQkJKCogY2Fubm90IGNvbXBhcmUgd2F0Y2hl cyBmcm9tIGRpZmZlcmVudCBjb25uZWN0aW9ucyAqKQorCQkJYXNzZXJ0ICh3 MS5jb24gPT0gdzIuY29uKTsKKwkJCW1hdGNoIFN0cmluZy5jb21wYXJlIHcx LnRva2VuIHcyLnRva2VuIHdpdGgKKwkJCXwgMCAtPiBTdHJpbmcuY29tcGFy ZSB3MS5wYXRoIHcyLnBhdGgKKwkJCXwgbiAtPiBuCisJZW5kCisJbW9kdWxl IFNldCA9IFNldC5NYWtlKFQpCisKKwlsZXQgZmx1c2hfZXZlbnRzIHQgPQor CQlCb3VuZGVkUGlwZS5mbHVzaF9waXBlIHQucGVuZGluZ193YXRjaGV2ZW50 czsKKwkJbm90IChCb3VuZGVkUGlwZS5pc19lbXB0eSB0LnBlbmRpbmdfd2F0 Y2hldmVudHMpCisKKwlsZXQgcGVuZGluZ193YXRjaGV2ZW50cyB0ID0KKwkJ Qm91bmRlZFBpcGUubGVuZ3RoIHQucGVuZGluZ193YXRjaGV2ZW50cworZW5k CisKK2xldCBzb3VyY2VfZmx1c2hfd2F0Y2hldmVudHMgdCA9CisJQm91bmRl ZFBpcGUuZmx1c2hfcGlwZSB0LnBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRz CisKK2xldCBzb3VyY2VfcGVuZGluZ193YXRjaGV2ZW50cyB0ID0KKwlCb3Vu ZGVkUGlwZS5sZW5ndGggdC5wZW5kaW5nX3NvdXJjZV93YXRjaGV2ZW50cwor CiBsZXQgbWFya19hc19iYWQgY29uID0KIAltYXRjaCBjb24uZG9tIHdpdGgK IAl8Tm9uZSAtPiAoKQpAQCAtNjcsNyArMTY3LDggQEAgbGV0IHdhdGNoX2Ny ZWF0ZSB+Y29uIH5wYXRoIH50b2tlbiA9IHsKIAl0b2tlbiA9IHRva2VuOwog CXBhdGggPSBwYXRoOwogCWJhc2UgPSBnZXRfcGF0aCBjb247Ci0JaXNfcmVs YXRpdmUgPSBwYXRoLlswXSA8PiAnLycgJiYgcGF0aC5bMF0gPD4gJ0AnCisJ aXNfcmVsYXRpdmUgPSBwYXRoLlswXSA8PiAnLycgJiYgcGF0aC5bMF0gPD4g J0AnOworCXBlbmRpbmdfd2F0Y2hldmVudHMgPSBCb3VuZGVkUGlwZS5jcmVh dGUgfmNhcGFjaXR5OiFEZWZpbmUubWF4d2F0Y2hldmVudHMgfmRlc3RpbmF0 aW9uOihYZW5idXMuWGIucXVldWUgY29uLnhiKQogfQogCiBsZXQgZ2V0X2Nv biB3ID0gdy5jb24KQEAgLTkzLDYgKzE5NCw5IEBAIGxldCBtYWtlX3Blcm0g ZG9tID0KIAlQZXJtcy5Db25uZWN0aW9uLmNyZWF0ZSB+cGVybXM6W1Blcm1z LlJFQUQ7IFBlcm1zLldSSVRFXSBkb21pZAogCiBsZXQgY3JlYXRlIHhiY29u IGRvbSA9CisJbGV0IGRlc3RpbmF0aW9uICh3YXRjaCwgcGt0KSA9CisJCUJv dW5kZWRQaXBlLnB1c2ggd2F0Y2gucGVuZGluZ193YXRjaGV2ZW50cyBwa3QK KwlpbgogCWxldCBpZCA9CiAJCW1hdGNoIGRvbSB3aXRoCiAJCXwgTm9uZSAt PiBsZXQgb2xkID0gIWFub25faWRfbmV4dCBpbiBpbmNyIGFub25faWRfbmV4 dDsgb2xkCkBAIC0xMDksNiArMjEzLDE2IEBAIGxldCBjcmVhdGUgeGJjb24g ZG9tID0KIAlhbm9uaWQgPSBpZDsKIAlzdGF0X25iX29wcyA9IDA7CiAJcGVy bSA9IG1ha2VfcGVybSBkb207CisKKwkoKiB0aGUgYWN0dWFsIGNhcGFjaXR5 IHdpbGwgYmUgbG93ZXIsIHRoaXMgaXMgdXNlZCBhcyBhbiBvdmVyZmxvdwor CSAgIGJ1ZmZlcjogYW55dGhpbmcgdGhhdCBkb2Vzbid0IGZpdCBlbHNld2hl cmUgZ2V0cyBwdXQgaGVyZSwgb25seQorCSAgIGxpbWl0ZWQgYnkgdGhlIGFt b3VudCBvZiB3YXRjaGVzIHRoYXQgeW91IGNhbiBnZW5lcmF0ZSB3aXRoIGEK KwkgICBzaW5nbGUgeGVuc3RvcmUgY29tbWFuZCAod2hpY2ggaXMgZmluaXRl LCBhbHRob3VnaCBwb3NzaWJseSB2ZXJ5CisJICAgbGFyZ2UgaW4gdGhlb3J5 IGZvciBEb20wKS4gIE9uY2UgdGhlIHBpcGUgaGVyZSBoYXMgYW55IGNvbnRl bnRzIHRoZQorCSAgIGRvbWFpbiBpcyBibG9ja2VkIGZyb20gc2VuZGluZyBt b3JlIGNvbW1hbmRzIHVudGlsIGl0IGlzIGVtcHR5CisJICAgYWdhaW4gdGhv dWdoLgorCSAqKQorCXBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRzID0gQm91 bmRlZFBpcGUuY3JlYXRlIH5jYXBhY2l0eTpTeXMubWF4X2FycmF5X2xlbmd0 aCB+ZGVzdGluYXRpb24KIAl9CiAJaW4KIAlMb2dnaW5nLm5ld19jb25uZWN0 aW9uIH50aWQ6VHJhbnNhY3Rpb24ubm9uZSB+Y29uOihnZXRfZG9tc3RyIGNv bik7CkBAIC0xMjcsMTEgKzI0MSwxNyBAQCBsZXQgc2V0X3RhcmdldCBjb24g dGFyZ2V0X2RvbWlkID0KIAogbGV0IGlzX2JhY2tlbmRfbW1hcCBjb24gPSBY ZW5idXMuWGIuaXNfbW1hcCBjb24ueGIKIAotbGV0IHNlbmRfcmVwbHkgY29u IHRpZCByaWQgdHkgZGF0YSA9CitsZXQgcGFja2V0X29mIGNvbiB0aWQgcmlk IHR5IGRhdGEgPQogCWlmIChTdHJpbmcubGVuZ3RoIGRhdGEpID4geGVuc3Rv cmVfcGF5bG9hZF9tYXggJiYgKGlzX2JhY2tlbmRfbW1hcCBjb24pIHRoZW4K LQkJWGVuYnVzLlhiLnF1ZXVlIGNvbi54YiAoWGVuYnVzLlhiLlBhY2tldC5j cmVhdGUgdGlkIHJpZCBYZW5idXMuWGIuT3AuRXJyb3IgIkUyQklHXDAwMCIp CisJCVhlbmJ1cy5YYi5QYWNrZXQuY3JlYXRlIHRpZCByaWQgWGVuYnVzLlhi Lk9wLkVycm9yICJFMkJJR1wwMDAiCiAJZWxzZQotCQlYZW5idXMuWGIucXVl dWUgY29uLnhiIChYZW5idXMuWGIuUGFja2V0LmNyZWF0ZSB0aWQgcmlkIHR5 IGRhdGEpCisJCVhlbmJ1cy5YYi5QYWNrZXQuY3JlYXRlIHRpZCByaWQgdHkg ZGF0YQorCitsZXQgc2VuZF9yZXBseSBjb24gdGlkIHJpZCB0eSBkYXRhID0K KwlsZXQgcmVzdWx0ID0gWGVuYnVzLlhiLnF1ZXVlIGNvbi54YiAocGFja2V0 X29mIGNvbiB0aWQgcmlkIHR5IGRhdGEpIGluCisJKCogc2hvdWxkIG5ldmVy IGhhcHBlbjogd2Ugb25seSBwcm9jZXNzIGFuIGlucHV0IHBhY2tldCB3aGVu IHRoZXJlIGlzIHJvb20gZm9yIGFuIG91dHB1dCBwYWNrZXQgKikKKwkoKiBh bmQgdGhlIGxpbWl0IGZvciByZXBsaWVzIGlzIGRpZmZlcmVudCBmcm9tIHRo ZSBsaW1pdCBmb3Igd2F0Y2ggZXZlbnRzICopCisJYXNzZXJ0IChyZXN1bHQg PD4gTm9uZSkKIAogbGV0IHNlbmRfZXJyb3IgY29uIHRpZCByaWQgZXJyID0g c2VuZF9yZXBseSBjb24gdGlkIHJpZCBYZW5idXMuWGIuT3AuRXJyb3IgKGVy ciBeICJcMDAwIikKIGxldCBzZW5kX2FjayBjb24gdGlkIHJpZCB0eSA9IHNl bmRfcmVwbHkgY29uIHRpZCByaWQgdHkgIk9LXDAwMCIKQEAgLTE4MSwxMSAr MzAxLDExIEBAIGxldCBkZWxfd2F0Y2ggY29uIHBhdGggdG9rZW4gPQogCWFw YXRoLCB3CiAKIGxldCBkZWxfd2F0Y2hlcyBjb24gPQotICBIYXNodGJsLmNs ZWFyIGNvbi53YXRjaGVzOworICBIYXNodGJsLnJlc2V0IGNvbi53YXRjaGVz OwogICBjb24ubmJfd2F0Y2hlcyA8LSAwCiAKIGxldCBkZWxfdHJhbnNhY3Rp b25zIGNvbiA9Ci0gIEhhc2h0YmwuY2xlYXIgY29uLnRyYW5zYWN0aW9ucwor ICBIYXNodGJsLnJlc2V0IGNvbi50cmFuc2FjdGlvbnMKIAogbGV0IGxpc3Rf d2F0Y2hlcyBjb24gPQogCWxldCBsbCA9IEhhc2h0YmwuZm9sZApAQCAtMjA4 LDIxICszMjgsMjkgQEAgbGV0IGxvb2t1cF93YXRjaF9wZXJtIHBhdGggPSBm dW5jdGlvbgogbGV0IGxvb2t1cF93YXRjaF9wZXJtcyBvbGRyb290IHJvb3Qg cGF0aCA9CiAJbG9va3VwX3dhdGNoX3Blcm0gcGF0aCBvbGRyb290IEAgbG9v a3VwX3dhdGNoX3Blcm0gcGF0aCAoU29tZSByb290KQogCi1sZXQgZmlyZV9z aW5nbGVfd2F0Y2hfdW5jaGVja2VkIHdhdGNoID0KK2xldCBmaXJlX3Npbmds ZV93YXRjaF91bmNoZWNrZWQgc291cmNlIHdhdGNoID0KIAlsZXQgZGF0YSA9 IFV0aWxzLmpvaW5fYnlfbnVsbCBbd2F0Y2gucGF0aDsgd2F0Y2gudG9rZW47 ICIiXSBpbgotCXNlbmRfcmVwbHkgd2F0Y2guY29uIFRyYW5zYWN0aW9uLm5v bmUgMCBYZW5idXMuWGIuT3AuV2F0Y2hldmVudCBkYXRhCisJbGV0IHBrdCA9 IHBhY2tldF9vZiB3YXRjaC5jb24gVHJhbnNhY3Rpb24ubm9uZSAwIFhlbmJ1 cy5YYi5PcC5XYXRjaGV2ZW50IGRhdGEgaW4KKworCW1hdGNoIEJvdW5kZWRQ aXBlLnB1c2ggc291cmNlLnBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRzICh3 YXRjaCwgcGt0KSB3aXRoCisJfCBTb21lICgpIC0+ICgpICgqIHBhY2tldCBx dWV1ZWQgKikKKwl8IE5vbmUgLT4KKwkJCSgqIGEgd2VsbCBiZWhhdmVkIERv bTAgc2hvdWxkbid0IGJlIGFibGUgdG8gdHJpZ2dlciB0aGlzLAorCQkJICAg aWYgaXQgaGFwcGVucyBpdCBpcyBsaWtlbHkgYSBEb20wIGJ1ZyBjYXVzaW5n IHJ1bmF3YXkgbWVtb3J5IHVzYWdlCisJCQkgKikKKwkJCWZhaWx3aXRoICJ3 YXRjaCBldmVudCBvdmVyZmxvdywgY2Fubm90IGhhcHBlbiIKIAotbGV0IGZp cmVfc2luZ2xlX3dhdGNoIChvbGRyb290LCByb290KSB3YXRjaCA9CitsZXQg ZmlyZV9zaW5nbGVfd2F0Y2ggc291cmNlIChvbGRyb290LCByb290KSB3YXRj aCA9CiAJbGV0IGFic3BhdGggPSBnZXRfd2F0Y2hfcGF0aCB3YXRjaC5jb24g d2F0Y2gucGF0aCB8PiBTdG9yZS5QYXRoLm9mX3N0cmluZyBpbgogCWxldCBw ZXJtcyA9IGxvb2t1cF93YXRjaF9wZXJtcyBvbGRyb290IHJvb3QgYWJzcGF0 aCBpbgogCWlmIFBlcm1zLmNhbl9maXJlX3dhdGNoIHdhdGNoLmNvbi5wZXJt IHBlcm1zIHRoZW4KLQkJZmlyZV9zaW5nbGVfd2F0Y2hfdW5jaGVja2VkIHdh dGNoCisJCWZpcmVfc2luZ2xlX3dhdGNoX3VuY2hlY2tlZCBzb3VyY2Ugd2F0 Y2gKIAllbHNlCiAJCWxldCBwZXJtcyA9IHBlcm1zIHw+IExpc3QubWFwIChQ ZXJtcy5Ob2RlLnRvX3N0cmluZyB+c2VwOiIgIikgfD4gU3RyaW5nLmNvbmNh dCAiLCAiIGluCiAJCWxldCBjb24gPSBnZXRfZG9tc3RyIHdhdGNoLmNvbiBp bgogCQlMb2dnaW5nLndhdGNoX25vdF9maXJlZCB+Y29uIHBlcm1zIChTdG9y ZS5QYXRoLnRvX3N0cmluZyBhYnNwYXRoKQogCi1sZXQgZmlyZV93YXRjaCBy b290cyB3YXRjaCBwYXRoID0KK2xldCBmaXJlX3dhdGNoIHNvdXJjZSByb290 cyB3YXRjaCBwYXRoID0KIAlsZXQgbmV3X3BhdGggPQogCQlpZiB3YXRjaC5p c19yZWxhdGl2ZSAmJiBwYXRoLlswXSA9ICcvJwogCQl0aGVuIGJlZ2luCkBA IC0yMzIsNyArMzYwLDcgQEAgbGV0IGZpcmVfd2F0Y2ggcm9vdHMgd2F0Y2gg cGF0aCA9CiAJCWVuZCBlbHNlCiAJCQlwYXRoCiAJaW4KLQlmaXJlX3Npbmds ZV93YXRjaCByb290cyB7IHdhdGNoIHdpdGggcGF0aCA9IG5ld19wYXRoIH0K KwlmaXJlX3NpbmdsZV93YXRjaCBzb3VyY2Ugcm9vdHMgeyB3YXRjaCB3aXRo IHBhdGggPSBuZXdfcGF0aCB9CiAKICgqIFNlYXJjaCBmb3IgYSB2YWxpZCB1 bnVzZWQgdHJhbnNhY3Rpb24gaWQuICopCiBsZXQgcmVjIHZhbGlkX3RyYW5z YWN0aW9uX2lkIGNvbiBwcm9wb3NlZF9pZCA9CkBAIC0yNzksNiArNDA3LDcg QEAgbGV0IGdldF90cmFuc2FjdGlvbiBjb24gdGlkID0KIGxldCBkb19pbnB1 dCBjb24gPSBYZW5idXMuWGIuaW5wdXQgY29uLnhiCiBsZXQgaGFzX21vcmVf aW5wdXQgY29uID0gWGVuYnVzLlhiLmhhc19tb3JlX2lucHV0IGNvbi54Ygog CitsZXQgY2FuX2lucHV0IGNvbiA9IFhlbmJ1cy5YYi5jYW5faW5wdXQgY29u LnhiICYmIEJvdW5kZWRQaXBlLmlzX2VtcHR5IGNvbi5wZW5kaW5nX3NvdXJj ZV93YXRjaGV2ZW50cwogbGV0IGhhc19vdXRwdXQgY29uID0gWGVuYnVzLlhi Lmhhc19vdXRwdXQgY29uLnhiCiBsZXQgaGFzX29sZF9vdXRwdXQgY29uID0g WGVuYnVzLlhiLmhhc19vbGRfb3V0cHV0IGNvbi54YgogbGV0IGhhc19uZXdf b3V0cHV0IGNvbiA9IFhlbmJ1cy5YYi5oYXNfbmV3X291dHB1dCBjb24ueGIK QEAgLTI4Niw3ICs0MTUsNyBAQCBsZXQgcGVla19vdXRwdXQgY29uID0gWGVu YnVzLlhiLnBlZWtfb3V0cHV0IGNvbi54YgogbGV0IGRvX291dHB1dCBjb24g PSBYZW5idXMuWGIub3V0cHV0IGNvbi54YgogCiBsZXQgaGFzX21vcmVfd29y ayBjb24gPQotCWhhc19tb3JlX2lucHV0IGNvbiB8fCBub3QgKGhhc19vbGRf b3V0cHV0IGNvbikgJiYgaGFzX25ld19vdXRwdXQgY29uCisJKGhhc19tb3Jl X2lucHV0IGNvbiAmJiBjYW5faW5wdXQgY29uKSB8fCBub3QgKGhhc19vbGRf b3V0cHV0IGNvbikgJiYgaGFzX25ld19vdXRwdXQgY29uCiAKIGxldCBpbmNy X29wcyBjb24gPSBjb24uc3RhdF9uYl9vcHMgPC0gY29uLnN0YXRfbmJfb3Bz ICsgMQogCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvY29u bmVjdGlvbnMubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvY29ubmVjdGlv bnMubWwKaW5kZXggN2VmZGYzZTVlMDVlLi4zOTE5MGMxOWVjNTggMTAwNjQ0 Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9ucy5tbAor KysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvY29ubmVjdGlvbnMubWwKQEAg LTIyLDIyICsyMiwzMCBAQCB0eXBlIHQgPSB7CiAJZG9tYWluczogKGludCwg Q29ubmVjdGlvbi50KSBIYXNodGJsLnQ7CiAJcG9ydHM6IChYZW5ldmVudGNo bi50LCBDb25uZWN0aW9uLnQpIEhhc2h0YmwudDsKIAltdXRhYmxlIHdhdGNo ZXM6IChzdHJpbmcsIENvbm5lY3Rpb24ud2F0Y2ggbGlzdCkgVHJpZS50Owor CW11dGFibGUgaGFzX3BlbmRpbmdfd2F0Y2hldmVudHM6IENvbm5lY3Rpb24u V2F0Y2guU2V0LnQKIH0KIAogbGV0IGNyZWF0ZSAoKSA9IHsKIAlhbm9ueW1v dXMgPSBIYXNodGJsLmNyZWF0ZSAzNzsKIAlkb21haW5zID0gSGFzaHRibC5j cmVhdGUgMzc7CiAJcG9ydHMgPSBIYXNodGJsLmNyZWF0ZSAzNzsKLQl3YXRj aGVzID0gVHJpZS5jcmVhdGUgKCkKKwl3YXRjaGVzID0gVHJpZS5jcmVhdGUg KCk7CisJaGFzX3BlbmRpbmdfd2F0Y2hldmVudHMgPSBDb25uZWN0aW9uLldh dGNoLlNldC5lbXB0eTsKIH0KIAorbGV0IGdldF9jYXBhY2l0eSAoKSA9CisJ KCogbm90IG11bHRpcGxpZWQgYnkgbWF4d2F0Y2ggb24gcHVycG9zZTogMm5k IHF1ZXVlIGluIHdhdGNoIGl0c2VsZiEgKikKKwl7IFhlbmJ1cy5YYi5tYXhv dXRzdGFuZGluZyA9ICFEZWZpbmUubWF4b3V0c3RhbmRpbmc7IG1heHdhdGNo ZXZlbnRzID0gIURlZmluZS5tYXh3YXRjaGV2ZW50cyB9CisKIGxldCBhZGRf YW5vbnltb3VzIGNvbnMgZmQgX2Nhbl93cml0ZSA9Ci0JbGV0IHhiY29uID0g WGVuYnVzLlhiLm9wZW5fZmQgZmQgaW4KKwlsZXQgY2FwYWNpdHkgPSBnZXRf Y2FwYWNpdHkgKCkgaW4KKwlsZXQgeGJjb24gPSBYZW5idXMuWGIub3Blbl9m ZCBmZCB+Y2FwYWNpdHkgaW4KIAlsZXQgY29uID0gQ29ubmVjdGlvbi5jcmVh dGUgeGJjb24gTm9uZSBpbgogCUhhc2h0YmwuYWRkIGNvbnMuYW5vbnltb3Vz IChYZW5idXMuWGIuZ2V0X2ZkIHhiY29uKSBjb24KIAogbGV0IGFkZF9kb21h aW4gY29ucyBkb20gPQotCWxldCB4YmNvbiA9IFhlbmJ1cy5YYi5vcGVuX21t YXAgKERvbWFpbi5nZXRfaW50ZXJmYWNlIGRvbSkgKGZ1biAoKSAtPiBEb21h aW4ubm90aWZ5IGRvbSkgaW4KKwlsZXQgY2FwYWNpdHkgPSBnZXRfY2FwYWNp dHkgKCkgaW4KKwlsZXQgeGJjb24gPSBYZW5idXMuWGIub3Blbl9tbWFwIH5j YXBhY2l0eSAoRG9tYWluLmdldF9pbnRlcmZhY2UgZG9tKSAoZnVuICgpIC0+ IERvbWFpbi5ub3RpZnkgZG9tKSBpbgogCWxldCBjb24gPSBDb25uZWN0aW9u LmNyZWF0ZSB4YmNvbiAoU29tZSBkb20pIGluCiAJSGFzaHRibC5hZGQgY29u cy5kb21haW5zIChEb21haW4uZ2V0X2lkIGRvbSkgY29uOwogCW1hdGNoIERv bWFpbi5nZXRfcG9ydCBkb20gd2l0aApAQCAtNDgsNyArNTYsOSBAQCBsZXQg c2VsZWN0ID8ob25seV9pZiA9IChmdW4gXyAtPiB0cnVlKSkgY29ucyA9CiAJ SGFzaHRibC5mb2xkIChmdW4gXyBjb24gKGlucywgb3V0cykgLT4KIAkJaWYg KG9ubHlfaWYgY29uKSB0aGVuICgKIAkJCWxldCBmZCA9IENvbm5lY3Rpb24u Z2V0X2ZkIGNvbiBpbgotCQkJKGZkIDo6IGlucywgIGlmIENvbm5lY3Rpb24u aGFzX291dHB1dCBjb24gdGhlbiBmZCA6OiBvdXRzIGVsc2Ugb3V0cykKKwkJ CWxldCBpbl9mZHMgPSBpZiBDb25uZWN0aW9uLmNhbl9pbnB1dCBjb24gdGhl biBmZCA6OiBpbnMgZWxzZSBpbnMgaW4KKwkJCWxldCBvdXRfZmRzID0gaWYg Q29ubmVjdGlvbi5oYXNfb3V0cHV0IGNvbiB0aGVuIGZkIDo6IG91dHMgZWxz ZSBvdXRzIGluCisJCQlpbl9mZHMsIG91dF9mZHMKIAkJKSBlbHNlIChpbnMs IG91dHMpCiAJKQogCWNvbnMuYW5vbnltb3VzIChbXSwgW10pCkBAIC02Nywx MCArNzcsMTcgQEAgbGV0IGRlbF93YXRjaGVzX29mX2NvbiBjb24gd2F0Y2hl cyA9CiAJfCBbXSAtPiBOb25lCiAJfCB3cyAtPiBTb21lIHdzCiAKK2xldCBk ZWxfd2F0Y2hlcyBjb25zIGNvbiA9CisJQ29ubmVjdGlvbi5kZWxfd2F0Y2hl cyBjb247CisJY29ucy53YXRjaGVzIDwtIFRyaWUubWFwIChkZWxfd2F0Y2hl c19vZl9jb24gY29uKSBjb25zLndhdGNoZXM7CisJY29ucy5oYXNfcGVuZGlu Z193YXRjaGV2ZW50cyA8LQorCQljb25zLmhhc19wZW5kaW5nX3dhdGNoZXZl bnRzIHw+IENvbm5lY3Rpb24uV2F0Y2guU2V0LmZpbHRlciBAQCBmdW4gdyAt PgorCQlDb25uZWN0aW9uLmdldF9jb24gdyAhPSBjb24KKwogbGV0IGRlbF9h bm9ueW1vdXMgY29ucyBjb24gPQogCXRyeQogCQlIYXNodGJsLnJlbW92ZSBj b25zLmFub255bW91cyAoQ29ubmVjdGlvbi5nZXRfZmQgY29uKTsKLQkJY29u cy53YXRjaGVzIDwtIFRyaWUubWFwIChkZWxfd2F0Y2hlc19vZl9jb24gY29u KSBjb25zLndhdGNoZXM7CisJCWRlbF93YXRjaGVzIGNvbnMgY29uOwogCQlD b25uZWN0aW9uLmNsb3NlIGNvbgogCXdpdGggZXhuIC0+CiAJCWRlYnVnICJk ZWwgYW5vbnltb3VzICVzIiAoUHJpbnRleGMudG9fc3RyaW5nIGV4bikKQEAg LTg1LDcgKzEwMiw3IEBAIGxldCBkZWxfZG9tYWluIGNvbnMgaWQgPQogCQkg ICAgfCBTb21lIHAgLT4gSGFzaHRibC5yZW1vdmUgY29ucy5wb3J0cyBwCiAJ CSAgICB8IE5vbmUgLT4gKCkpCiAJCSB8IE5vbmUgLT4gKCkpOwotCQljb25z LndhdGNoZXMgPC0gVHJpZS5tYXAgKGRlbF93YXRjaGVzX29mX2NvbiBjb24p IGNvbnMud2F0Y2hlczsKKwkJZGVsX3dhdGNoZXMgY29ucyBjb247CiAJCUNv bm5lY3Rpb24uY2xvc2UgY29uCiAJd2l0aCBleG4gLT4KIAkJZGVidWcgImRl bCBkb21haW4gJXU6ICVzIiBpZCAoUHJpbnRleGMudG9fc3RyaW5nIGV4bikK QEAgLTEzNiwzMSArMTUzLDMzIEBAIGxldCBkZWxfd2F0Y2ggY29ucyBjb24g cGF0aCB0b2tlbiA9CiAJCWNvbnMud2F0Y2hlcyA8LSBUcmllLnNldCBjb25z LndhdGNoZXMga2V5IHdhdGNoZXM7CiAgCXdhdGNoCiAKLWxldCBkZWxfd2F0 Y2hlcyBjb25zIGNvbiA9Ci0JQ29ubmVjdGlvbi5kZWxfd2F0Y2hlcyBjb247 Ci0JY29ucy53YXRjaGVzIDwtIFRyaWUubWFwIChkZWxfd2F0Y2hlc19vZl9j b24gY29uKSBjb25zLndhdGNoZXMKLQogKCogcGF0aCBpcyBhYnNvbHV0ZSAq KQotbGV0IGZpcmVfd2F0Y2hlcyA/b2xkcm9vdCByb290IGNvbnMgcGF0aCBy ZWN1cnNlID0KK2xldCBmaXJlX3dhdGNoZXMgP29sZHJvb3Qgc291cmNlIHJv b3QgY29ucyBwYXRoIHJlY3Vyc2UgPQogCWxldCBrZXkgPSBrZXlfb2ZfcGF0 aCBwYXRoIGluCiAJbGV0IHBhdGggPSBTdG9yZS5QYXRoLnRvX3N0cmluZyBw YXRoIGluCiAJbGV0IHJvb3RzID0gb2xkcm9vdCwgcm9vdCBpbgogCWxldCBm aXJlX3dhdGNoIF8gPSBmdW5jdGlvbgogCQl8IE5vbmUgICAgICAgICAtPiAo KQotCQl8IFNvbWUgd2F0Y2hlcyAtPiBMaXN0Lml0ZXIgKGZ1biB3IC0+IENv bm5lY3Rpb24uZmlyZV93YXRjaCByb290cyB3IHBhdGgpIHdhdGNoZXMKKwkJ fCBTb21lIHdhdGNoZXMgLT4gTGlzdC5pdGVyIChmdW4gdyAtPiBDb25uZWN0 aW9uLmZpcmVfd2F0Y2ggc291cmNlIHJvb3RzIHcgcGF0aCkgd2F0Y2hlcwog CWluCiAJbGV0IGZpcmVfcmVjIF94ID0gZnVuY3Rpb24KIAkJfCBOb25lICAg ICAgICAgLT4gKCkKIAkJfCBTb21lIHdhdGNoZXMgLT4KLQkJCUxpc3QuaXRl ciAoQ29ubmVjdGlvbi5maXJlX3NpbmdsZV93YXRjaCByb290cykgd2F0Y2hl cworCQkJTGlzdC5pdGVyIChDb25uZWN0aW9uLmZpcmVfc2luZ2xlX3dhdGNo IHNvdXJjZSByb290cykgd2F0Y2hlcwogCWluCiAJVHJpZS5pdGVyX3BhdGgg ZmlyZV93YXRjaCBjb25zLndhdGNoZXMga2V5OwogCWlmIHJlY3Vyc2UgdGhl bgogCQlUcmllLml0ZXIgZmlyZV9yZWMgKFRyaWUuc3ViIGNvbnMud2F0Y2hl cyBrZXkpCiAKK2xldCBzZW5kX3dhdGNoZXZlbnRzIGNvbnMgY29uID0KKwlj b25zLmhhc19wZW5kaW5nX3dhdGNoZXZlbnRzIDwtCisJCWNvbnMuaGFzX3Bl bmRpbmdfd2F0Y2hldmVudHMgfD4gQ29ubmVjdGlvbi5XYXRjaC5TZXQuZmls dGVyIENvbm5lY3Rpb24uV2F0Y2guZmx1c2hfZXZlbnRzOworCUNvbm5lY3Rp b24uc291cmNlX2ZsdXNoX3dhdGNoZXZlbnRzIGNvbgorCiBsZXQgZmlyZV9z cGVjX3dhdGNoZXMgcm9vdCBjb25zIHNwZWNwYXRoID0KKwlsZXQgc291cmNl ID0gZmluZF9kb21haW4gY29ucyAwIGluCiAJaXRlciBjb25zIChmdW4gY29u IC0+Ci0JCUxpc3QuaXRlciAoQ29ubmVjdGlvbi5maXJlX3NpbmdsZV93YXRj aCAoTm9uZSwgcm9vdCkpIChDb25uZWN0aW9uLmdldF93YXRjaGVzIGNvbiBz cGVjcGF0aCkpCisJCUxpc3QuaXRlciAoQ29ubmVjdGlvbi5maXJlX3Npbmds ZV93YXRjaCBzb3VyY2UgKE5vbmUsIHJvb3QpKSAoQ29ubmVjdGlvbi5nZXRf d2F0Y2hlcyBjb24gc3BlY3BhdGgpKQogCiBsZXQgc2V0X3RhcmdldCBjb25z IGRvbWFpbiB0YXJnZXRfZG9tYWluID0KIAlsZXQgY29uID0gZmluZF9kb21h aW4gY29ucyBkb21haW4gaW4KQEAgLTE5NiwzICsyMTUsMTMgQEAgbGV0IGRl YnVnIGNvbnMgPQogCWxldCBhbm9ueW1vdXMgPSBIYXNodGJsLmZvbGQgKGZ1 biBfIGNvbiBhY2N1IC0+IENvbm5lY3Rpb24uZGVidWcgY29uIDo6IGFjY3Up IGNvbnMuYW5vbnltb3VzIFtdIGluCiAJbGV0IGRvbWFpbnMgPSBIYXNodGJs LmZvbGQgKGZ1biBfIGNvbiBhY2N1IC0+IENvbm5lY3Rpb24uZGVidWcgY29u IDo6IGFjY3UpIGNvbnMuZG9tYWlucyBbXSBpbgogCVN0cmluZy5jb25jYXQg IiIgKGRvbWFpbnMgQCBhbm9ueW1vdXMpCisKK2xldCBkZWJ1Z193YXRjaGV2 ZW50cyBjb25zIGNvbiA9CisJKCogPT0gKHBoeXNpY2FsIGVxdWFsaXR5KQor CSAgIGhhcyB0byBiZSB1c2VkIGhlcmUgYmVjYXVzZSB3LmNvbi54Yi5iYWNr ZW5kIG1pZ2h0IGNvbnRhaW4gYSBbdW5pdC0+dW5pdF0gdmFsdWUgY2F1c2lu ZyByZWd1bGFyCisJICAgY29tcGFyaXNvbiB0byBmYWlsIGR1ZSB0byBoYXZp bmcgYSAnZnVuY3Rpb25hbCB2YWx1ZScgd2hpY2ggY2Fubm90IGJlIGNvbXBh cmVkLgorCSAqKQorCWxldCBzID0gY29ucy5oYXNfcGVuZGluZ193YXRjaGV2 ZW50cyB8PiBDb25uZWN0aW9uLldhdGNoLlNldC5maWx0ZXIgKGZ1biB3IC0+ IHcuY29uID09IGNvbikgaW4KKwlsZXQgcGVuZGluZyA9IHMgfD4gQ29ubmVj dGlvbi5XYXRjaC5TZXQuZWxlbWVudHMKKwkJfD4gTGlzdC5tYXAgKGZ1biB3 IC0+IENvbm5lY3Rpb24uV2F0Y2gucGVuZGluZ193YXRjaGV2ZW50cyB3KSB8 PiBMaXN0LmZvbGRfbGVmdCAoKykgMCBpbgorCVByaW50Zi5zcHJpbnRmICJX YXRjaGVzIHdpdGggcGVuZGluZyBldmVudHM6ICVkLCBwZW5kaW5nIGV2ZW50 cyB0b3RhbDogJWQiIChDb25uZWN0aW9uLldhdGNoLlNldC5jYXJkaW5hbCBz KSBwZW5kaW5nCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQv ZGVmaW5lLm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RlZmluZS5tbApp bmRleCAxYTVkMmYzNGE2NzguLjllNTIzNjcwOTQ3NCAxMDA2NDQKLS0tIGEv dG9vbHMvb2NhbWwveGVuc3RvcmVkL2RlZmluZS5tbAorKysgYi90b29scy9v Y2FtbC94ZW5zdG9yZWQvZGVmaW5lLm1sCkBAIC0yNSw2ICsyNSwxMyBAQCBs ZXQgZGVmYXVsdF9jb25maWdfZGlyID0gUGF0aHMueGVuX2NvbmZpZ19kaXIK IGxldCBtYXh3YXRjaCA9IHJlZiAoMTAwKQogbGV0IG1heHRyYW5zYWN0aW9u ID0gcmVmICgxMCkKIGxldCBtYXhyZXF1ZXN0cyA9IHJlZiAoMTAyNCkgICAo KiBtYXhpbXVtIHJlcXVlc3RzIHBlciB0cmFuc2FjdGlvbiAqKQorbGV0IG1h eG91dHN0YW5kaW5nID0gcmVmICgxMDI0KSAoKiBtYXhpbXVtIG91dHN0YW5k aW5nIHJlcXVlc3RzLCBpLmUuIGluLWZsaWdodCByZXF1ZXN0cyAvIGRvbWFp biAqKQorbGV0IG1heHdhdGNoZXZlbnRzID0gcmVmICgxMDI0KQorKCoKKwlt YXhpbXVtIG91dHN0YW5kaW5nIHdhdGNoIGV2ZW50cyBwZXIgd2F0Y2gsCisJ cmVjb21tZW5kZWQgPj0gbWF4b3V0c3RhbmRpbmcgdG8gYXZvaWQgYmxvY2tp bmcgYmFja2VuZCB0cmFuc2FjdGlvbnMgZHVlIHRvCisJbWFsaWNpb3VzIGZy b250ZW5kcworICopCiAKIGxldCBnY19tYXhfb3ZlcmhlYWQgPSByZWYgMTIw ICgqIDEyMCUgc2VlIGNvbW1lbnQgaW4geGVuc3RvcmVkLm1sICopCiBsZXQg Y29uZmxpY3RfYnVyc3RfbGltaXQgPSByZWYgNS4wCmRpZmYgLS1naXQgYS90 b29scy9vY2FtbC94ZW5zdG9yZWQvb3hlbnN0b3JlZC5jb25mLmluIGIvdG9v bHMvb2NhbWwveGVuc3RvcmVkL294ZW5zdG9yZWQuY29uZi5pbgppbmRleCA0 YWU0OGU0MmQ0N2QuLjlkMDM0ZTc0NGI0YiAxMDA2NDQKLS0tIGEvdG9vbHMv b2NhbWwveGVuc3RvcmVkL294ZW5zdG9yZWQuY29uZi5pbgorKysgYi90b29s cy9vY2FtbC94ZW5zdG9yZWQvb3hlbnN0b3JlZC5jb25mLmluCkBAIC02Miw2 ICs2Miw4IEBAIHF1b3RhLW1heHdhdGNoID0gMTAwCiBxdW90YS10cmFuc2Fj dGlvbiA9IDEwCiBxdW90YS1tYXhyZXF1ZXN0cyA9IDEwMjQKIHF1b3RhLXBh dGgtbWF4ID0gMTAyNAorcXVvdGEtbWF4b3V0c3RhbmRpbmcgPSAxMDI0Citx dW90YS1tYXh3YXRjaGV2ZW50cyA9IDEwMjQKIAogIyBBY3RpdmF0ZSBmaWxl ZCBiYXNlIGJhY2tlbmQKIHBlcnNpc3RlbnQgPSBmYWxzZQpkaWZmIC0tZ2l0 IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3MubWwgYi90b29scy9v Y2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbAppbmRleCBhNzI4MTBkMDZmNDMu LjA4MmM5M2ZhOWQzZiAxMDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwveGVuc3Rv cmVkL3Byb2Nlc3MubWwKKysrIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3By b2Nlc3MubWwKQEAgLTU2LDcgKzU2LDcgQEAgbGV0IHNwbGl0X29uZV9wYXRo IGRhdGEgY29uID0KIAl8IHBhdGggOjogIiIgOjogW10gLT4gU3RvcmUuUGF0 aC5jcmVhdGUgcGF0aCAoQ29ubmVjdGlvbi5nZXRfcGF0aCBjb24pCiAJfCBf ICAgICAgICAgICAgICAgIC0+IHJhaXNlIEludmFsaWRfQ21kX0FyZ3MKIAot bGV0IHByb2Nlc3Nfd2F0Y2ggdCBjb25zID0KK2xldCBwcm9jZXNzX3dhdGNo IHNvdXJjZSB0IGNvbnMgPQogCWxldCBvbGRyb290ID0gdC5UcmFuc2FjdGlv bi5vbGRyb290IGluCiAJbGV0IG5ld3Jvb3QgPSBTdG9yZS5nZXRfcm9vdCB0 LnN0b3JlIGluCiAJbGV0IG9wcyA9IFRyYW5zYWN0aW9uLmdldF9wYXRocyB0 IHw+IExpc3QucmV2IGluCkBAIC02Niw4ICs2Niw5IEBAIGxldCBwcm9jZXNz X3dhdGNoIHQgY29ucyA9CiAJCXwgWGVuYnVzLlhiLk9wLlJtICAgICAgIC0+ IHRydWUsIE5vbmUsIG9sZHJvb3QKIAkJfCBYZW5idXMuWGIuT3AuU2V0cGVy bXMgLT4gZmFsc2UsIFNvbWUgb2xkcm9vdCwgbmV3cm9vdAogCQl8IF8gICAg ICAgICAgICAgIC0+IHJhaXNlIChGYWlsdXJlICJodWggPyIpIGluCi0JCUNv bm5lY3Rpb25zLmZpcmVfd2F0Y2hlcyA/b2xkcm9vdCByb290IGNvbnMgKHNu ZCBvcCkgcmVjdXJzZSBpbgotCUxpc3QuaXRlciAoZnVuIG9wIC0+IGRvX29w X3dhdGNoIG9wIGNvbnMpIG9wcworCQlDb25uZWN0aW9ucy5maXJlX3dhdGNo ZXMgP29sZHJvb3Qgc291cmNlIHJvb3QgY29ucyAoc25kIG9wKSByZWN1cnNl IGluCisJTGlzdC5pdGVyIChmdW4gb3AgLT4gZG9fb3Bfd2F0Y2ggb3AgY29u cykgb3BzOworCUNvbm5lY3Rpb25zLnNlbmRfd2F0Y2hldmVudHMgY29ucyBz b3VyY2UKIAogbGV0IGNyZWF0ZV9pbXBsaWNpdF9wYXRoIHQgcGVybSBwYXRo ID0KIAlsZXQgZGlybmFtZSA9IFN0b3JlLlBhdGguZ2V0X3BhcmVudCBwYXRo IGluCkBAIC05OSw2ICsxMDAsMjAgQEAgbGV0IGRvX2RlYnVnIGNvbiB0IF9k b21haW5zIGNvbnMgZGF0YSA9CiAJfCAid2F0Y2hlcyIgOjogXyAtPgogCQls ZXQgd2F0Y2hlcyA9IENvbm5lY3Rpb25zLmRlYnVnIGNvbnMgaW4KIAkJU29t ZSAod2F0Y2hlcyBeICJcMDAwIikKKwl8ICJ4ZW5idXMiIDo6IGRvbWlkIDo6 IF8gLT4KKwkJbGV0IGRvbWlkID0gaW50X29mX3N0cmluZyBkb21pZCBpbgor CQlsZXQgY29uID0gQ29ubmVjdGlvbnMuZmluZF9kb21haW4gY29ucyBkb21p ZCBpbgorCQlsZXQgcyA9IFByaW50Zi5zcHJpbnRmICJ4ZW5idXM6ICVzOyBv dmVyZmxvdyBxdWV1ZSBsZW5ndGg6ICVkLCBjYW5faW5wdXQ6ICViLCBoYXNf bW9yZV9pbnB1dDogJWIsIGhhc19vbGRfb3V0cHV0OiAlYiwgaGFzX25ld19v dXRwdXQ6ICViLCBoYXNfbW9yZV93b3JrOiAlYi4gcGVuZGluZzogJXMiCisJ CQkoWGVuYnVzLlhiLmRlYnVnIGNvbi54YikKKwkJCShDb25uZWN0aW9uLnNv dXJjZV9wZW5kaW5nX3dhdGNoZXZlbnRzIGNvbikKKwkJCShDb25uZWN0aW9u LmNhbl9pbnB1dCBjb24pCisJCQkoQ29ubmVjdGlvbi5oYXNfbW9yZV9pbnB1 dCBjb24pCisJCQkoQ29ubmVjdGlvbi5oYXNfb2xkX291dHB1dCBjb24pCisJ CQkoQ29ubmVjdGlvbi5oYXNfbmV3X291dHB1dCBjb24pCisJCQkoQ29ubmVj dGlvbi5oYXNfbW9yZV93b3JrIGNvbikKKwkJCShDb25uZWN0aW9ucy5kZWJ1 Z193YXRjaGV2ZW50cyBjb25zIGNvbikKKwkJaW4KKwkJU29tZSBzCiAJfCAi bWZuIiA6OiBkb21pZCA6OiBfIC0+CiAJCWxldCBkb21pZCA9IGludF9vZl9z dHJpbmcgZG9taWQgaW4KIAkJbGV0IGNvbiA9IENvbm5lY3Rpb25zLmZpbmRf ZG9tYWluIGNvbnMgZG9taWQgaW4KQEAgLTIwNyw3ICsyMjIsNyBAQCBsZXQg cmVwbHlfYWNrIGZjdCBjb24gdCBkb21zIGNvbnMgZGF0YSA9CiAJZmN0IGNv biB0IGRvbXMgY29ucyBkYXRhOwogCVBhY2tldC5BY2sgKGZ1biAoKSAtPgog CQlpZiBUcmFuc2FjdGlvbi5nZXRfaWQgdCA9IFRyYW5zYWN0aW9uLm5vbmUg dGhlbgotCQkJcHJvY2Vzc193YXRjaCB0IGNvbnMKKwkJCXByb2Nlc3Nfd2F0 Y2ggY29uIHQgY29ucwogCSkKIAogbGV0IHJlcGx5X2RhdGEgZmN0IGNvbiB0 IGRvbXMgY29ucyBkYXRhID0KQEAgLTM2Niw3ICszODEsNyBAQCBsZXQgZG9f d2F0Y2ggY29uIHQgX2RvbWFpbnMgY29ucyBkYXRhID0KIAlQYWNrZXQuQWNr IChmdW4gKCkgLT4KIAkJKCogeGVuc3RvcmUudHh0IHNheXMgdGhpcyB3YXRj aCBpcyBmaXJlZCBpbW1lZGlhdGVseSwKIAkJICAgaW1wbHlpbmcgZXZlbiBp ZiBwYXRoIGRvZXNuJ3QgZXhpc3Qgb3IgaXMgdW5yZWFkYWJsZSAqKQotCQlD b25uZWN0aW9uLmZpcmVfc2luZ2xlX3dhdGNoX3VuY2hlY2tlZCB3YXRjaCkK KwkJQ29ubmVjdGlvbi5maXJlX3NpbmdsZV93YXRjaF91bmNoZWNrZWQgY29u IHdhdGNoKQogCiBsZXQgZG9fdW53YXRjaCBjb24gX3QgX2RvbWFpbnMgY29u cyBkYXRhID0KIAlsZXQgKG5vZGUsIHRva2VuKSA9CkBAIC0zOTcsNyArNDEy LDcgQEAgbGV0IGRvX3RyYW5zYWN0aW9uX2VuZCBjb24gdCBkb21haW5zIGNv bnMgZGF0YSA9CiAJaWYgbm90IHN1Y2Nlc3MgdGhlbgogCQlyYWlzZSBUcmFu c2FjdGlvbl9hZ2FpbjsKIAlpZiBjb21taXQgdGhlbiBiZWdpbgotCQlwcm9j ZXNzX3dhdGNoIHQgY29uczsKKwkJcHJvY2Vzc193YXRjaCBjb24gdCBjb25z OwogCQltYXRjaCB0LlRyYW5zYWN0aW9uLnR5IHdpdGgKIAkJfCBUcmFuc2Fj dGlvbi5ObyAtPgogCQkJKCkgKCogbm8gbmVlZCB0byByZWNvcmQgYW55dGhp bmcgKikKQEAgLTU2NCw3ICs1NzksOCBAQCBsZXQgcHJvY2Vzc19wYWNrZXQg fnN0b3JlIH5jb25zIH5kb21zIH5jb24gfnJlcSA9CiBsZXQgZG9faW5wdXQg c3RvcmUgY29ucyBkb21zIGNvbiA9CiAJbGV0IG5ld3BhY2tldCA9CiAJCXRy eQotCQkJQ29ubmVjdGlvbi5kb19pbnB1dCBjb24KKwkJCWlmIENvbm5lY3Rp b24uY2FuX2lucHV0IGNvbiB0aGVuIENvbm5lY3Rpb24uZG9faW5wdXQgY29u CisJCQllbHNlIE5vbmUKIAkJd2l0aCBYZW5idXMuWGIuUmVjb25uZWN0IC0+ CiAJCQlpbmZvICIlcyByZXF1ZXN0cyBhIHJlY29ubmVjdCIgKENvbm5lY3Rp b24uZ2V0X2RvbXN0ciBjb24pOwogCQkJSGlzdG9yeS5yZWNvbm5lY3QgY29u OwpAQCAtNTkyLDYgKzYwOCw3IEBAIGxldCBkb19pbnB1dCBzdG9yZSBjb25z IGRvbXMgY29uID0KIAkJQ29ubmVjdGlvbi5pbmNyX29wcyBjb24KIAogbGV0 IGRvX291dHB1dCBfc3RvcmUgX2NvbnMgX2RvbXMgY29uID0KKwlDb25uZWN0 aW9uLnNvdXJjZV9mbHVzaF93YXRjaGV2ZW50cyBjb247CiAJaWYgQ29ubmVj dGlvbi5oYXNfb3V0cHV0IGNvbiB0aGVuICgKIAkJaWYgQ29ubmVjdGlvbi5o YXNfbmV3X291dHB1dCBjb24gdGhlbiAoCiAJCQlsZXQgcGFja2V0ID0gQ29u bmVjdGlvbi5wZWVrX291dHB1dCBjb24gaW4KZGlmZiAtLWdpdCBhL3Rvb2xz L29jYW1sL3hlbnN0b3JlZC94ZW5zdG9yZWQubWwgYi90b29scy9vY2FtbC94 ZW5zdG9yZWQveGVuc3RvcmVkLm1sCmluZGV4IDBiNjM0M2RmYzc4OS4uNGY4 ZmFiMmRkMTNhIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQv eGVuc3RvcmVkLm1sCisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC94ZW5z dG9yZWQubWwKQEAgLTEwMiw2ICsxMDIsOCBAQCBsZXQgcGFyc2VfY29uZmln IGZpbGVuYW1lID0KIAkJKCJxdW90YS1tYXhlbnRpdHkiLCBDb25maWcuU2V0 X2ludCBRdW90YS5tYXhlbnQpOwogCQkoInF1b3RhLW1heHNpemUiLCBDb25m aWcuU2V0X2ludCBRdW90YS5tYXhzaXplKTsKIAkJKCJxdW90YS1tYXhyZXF1 ZXN0cyIsIENvbmZpZy5TZXRfaW50IERlZmluZS5tYXhyZXF1ZXN0cyk7CisJ CSgicXVvdGEtbWF4b3V0c3RhbmRpbmciLCBDb25maWcuU2V0X2ludCBEZWZp bmUubWF4b3V0c3RhbmRpbmcpOworCQkoInF1b3RhLW1heHdhdGNoZXZlbnRz IiwgQ29uZmlnLlNldF9pbnQgRGVmaW5lLm1heHdhdGNoZXZlbnRzKTsKIAkJ KCJxdW90YS1wYXRoLW1heCIsIENvbmZpZy5TZXRfaW50IERlZmluZS5wYXRo X21heCk7CiAJCSgiZ2MtbWF4LW92ZXJoZWFkIiwgQ29uZmlnLlNldF9pbnQg RGVmaW5lLmdjX21heF9vdmVyaGVhZCk7CiAJCSgidGVzdC1lYWdhaW4iLCBD b25maWcuU2V0X2Jvb2wgVHJhbnNhY3Rpb24udGVzdF9lYWdhaW4pOwo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-oxenstored-08.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-oxenstored-08.patch" Content-Transfer-Encoding: base64 RnJvbSA2NmVjMzAzZTY1YjE2ZTI4YTUzYWYwOTdmNWI3Mjk1NDU4ZWE4YjQ5 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFRodSwgMjkgU2VwIDIwMjIgMTM6 MDc6MzUgKzAyMDAKU3ViamVjdDogU1VQUE9SVC5tZDogY2xhcmlmeSBzdXBw b3J0IG9mIHVudHJ1c3RlZCBkcml2ZXIgZG9tYWlucyB3aXRoCiBveGVuc3Rv cmVkCgpBZGQgYSBzdXBwb3J0IHN0YXRlbWVudCBmb3IgdGhlIHNjb3BlIG9m IHN1cHBvcnQgcmVnYXJkaW5nIGRpZmZlcmVudApYZW5zdG9yZSB2YXJpYW50 cy4gRXNwZWNpYWxseSBveGVuc3RvcmVkIGRvZXMgbm90ICh5ZXQpIGhhdmUg c2VjdXJpdHkKc3VwcG9ydCBvZiB1bnRydXN0ZWQgZHJpdmVyIGRvbWFpbnMs IGFzIHRob3NlIG1pZ2h0IGRyaXZlIG94ZW5zdG9yZWQKb3V0IG9mIG1lbW9y eSBieSBjcmVhdGluZyBsb3RzIG9mIHdhdGNoIGV2ZW50cyBmb3IgdGhlIGd1 ZXN0cyB0aGV5IGFyZQpzZXJ2aWNpbmcuCgpBZGQgYSBzdGF0ZW1lbnQgcmVn YXJkaW5nIExpdmUgVXBkYXRlIHN1cHBvcnQgb2Ygb3hlbnN0b3JlZC4KClRo aXMgaXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEdlb3JnZSBE dW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClJldmlld2VkLWJ5OiBD aHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+ CgpkaWZmIC0tZ2l0IGEvU1VQUE9SVC5tZCBiL1NVUFBPUlQubWQKaW5kZXgg YzQ1MzkwYTI0NWMwLi5kZDk3MDJiZmU0MmYgMTAwNjQ0Ci0tLSBhL1NVUFBP UlQubWQKKysrIGIvU1VQUE9SVC5tZApAQCAtMTc1LDYgKzE3NSwxNyBAQCBT dXBwb3J0IGZvciBydW5uaW5nIHFlbXUteGVuIGRldmljZSBtb2RlbCBpbiBh IGxpbnV4IHN0dWJkb21haW4uCiAKICAgICBTdGF0dXM6IFRlY2ggUHJldmll dwogCisjIyBYZW5zdG9yZQorCisjIyMgQyB4ZW5zdG9yZWQgZGFlbW9uCisK KyAgICBTdGF0dXM6IFN1cHBvcnRlZAorCisjIyMgT0NhbWwgeGVuc3RvcmVk IGRhZW1vbgorCisgICAgU3RhdHVzOiBTdXBwb3J0ZWQKKyAgICBTdGF0dXMs IHVudHJ1c3RlZCBkcml2ZXIgZG9tYWluczogU3VwcG9ydGVkLCBub3Qgc2Vj dXJpdHkgc3VwcG9ydGVkCisKICMjIFRvb2xzdGFjay8zcmQgcGFydHkKIAog IyMjIGxpYnZpcnQgZHJpdmVyIGZvciB4bAo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-01.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-01.patch" Content-Transfer-Encoding: base64 RnJvbSBiZTI5YjM5MzRmZDVhNGQyYmNlNTU3MzFmMjRlNzQ0MTVlYmM0YjEz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHNwbGl0IHVw IHNlbmRfcmVwbHkoKQoKVG9kYXkgc2VuZF9yZXBseSgpIGlzIHVzZWQgZm9y IGJvdGgsIG5vcm1hbCByZXF1ZXN0IHJlcGxpZXMgYW5kIHdhdGNoCmV2ZW50 cy4KClNwbGl0IGl0IHVwIGludG8gc2VuZF9yZXBseSgpIGFuZCBzZW5kX2V2 ZW50KCkuIFRoaXMgd2lsbCBiZSB1c2VkIHRvCmFkZCBzb21lIGV2ZW50IHNw ZWNpZmljIGhhbmRsaW5nLgoKYWRkX2V2ZW50KCkgY2FuIGJlIG1lcmdlZCBp bnRvIHNlbmRfZXZlbnQoKSwgcmVtb3ZpbmcgdGhlIG5lZWQgZm9yIGFuCmlu dGVybWVkaWF0ZSBtZW1vcnkgYWxsb2NhdGlvbi4KClRoaXMgaXMgcGFydCBv ZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxs QGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpn cm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdy YWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMKaW5kZXggOGU5MWI1NTQ5ODRkLi5lNjc3NmJhZThmOTkgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtNjc0LDQ5ICs2 NzQsMzIgQEAgc3RhdGljIHZvaWQgc2VuZF9lcnJvcihzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgaW50IGVycm9yKQogdm9pZCBzZW5kX3JlcGx5KHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlw ZSwKIAkJY29uc3Qgdm9pZCAqZGF0YSwgdW5zaWduZWQgaW50IGxlbikKIHsK LQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRhdGE7CisJc3RydWN0IGJ1ZmZl cmVkX2RhdGEgKmJkYXRhID0gY29ubi0+aW47CisKKwlhc3NlcnQodHlwZSAh PSBYU19XQVRDSF9FVkVOVCk7CiAKIAlpZiAoIGxlbiA+IFhFTlNUT1JFX1BB WUxPQURfTUFYICkgewogCQlzZW5kX2Vycm9yKGNvbm4sIEUyQklHKTsKIAkJ cmV0dXJuOwogCX0KIAotCS8qIFJlcGxpZXMgcmV1c2UgdGhlIHJlcXVlc3Qg YnVmZmVyLCBldmVudHMgbmVlZCBhIG5ldyBvbmUuICovCi0JaWYgKHR5cGUg IT0gWFNfV0FUQ0hfRVZFTlQpIHsKLQkJYmRhdGEgPSBjb25uLT5pbjsKLQkJ LyogRHJvcCBhc3luY2hyb25vdXMgcmVzcG9uc2VzLCBlLmcuIGVycm9ycyBm b3Igd2F0Y2ggZXZlbnRzLiAqLwotCQlpZiAoIWJkYXRhKQotCQkJcmV0dXJu OwotCQliZGF0YS0+aW5oZHIgPSB0cnVlOwotCQliZGF0YS0+dXNlZCA9IDA7 Ci0JCWNvbm4tPmluID0gTlVMTDsKLQl9IGVsc2UgewotCQkvKiBNZXNzYWdl IGlzIGEgY2hpbGQgb2YgdGhlIGNvbm5lY3Rpb24gZm9yIGF1dG8tY2xlYW51 cC4gKi8KLQkJYmRhdGEgPSBuZXdfYnVmZmVyKGNvbm4pOworCWlmICghYmRh dGEpCisJCXJldHVybjsKKwliZGF0YS0+aW5oZHIgPSB0cnVlOworCWJkYXRh LT51c2VkID0gMDsKIAotCQkvKgotCQkgKiBBbGxvY2F0aW9uIGZhaWx1cmUg aGVyZSBpcyB1bmZvcnR1bmF0ZTogd2UgaGF2ZSBubyB3YXkgdG8KLQkJICog dGVsbCBhbnlib2R5IGFib3V0IGl0LgotCQkgKi8KLQkJaWYgKCFiZGF0YSkK LQkJCXJldHVybjsKLQl9CiAJaWYgKGxlbiA8PSBERUZBVUxUX0JVRkZFUl9T SVpFKQogCQliZGF0YS0+YnVmZmVyID0gYmRhdGEtPmRlZmF1bHRfYnVmZmVy OwotCWVsc2UKKwllbHNlIHsKIAkJYmRhdGEtPmJ1ZmZlciA9IHRhbGxvY19h cnJheShiZGF0YSwgY2hhciwgbGVuKTsKLQlpZiAoIWJkYXRhLT5idWZmZXIp IHsKLQkJaWYgKHR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQpIHsKLQkJCS8qIFNh bWUgYXMgYWJvdmU6IG5vIHdheSB0byB0ZWxsIHNvbWVvbmUuICovCi0JCQl0 YWxsb2NfZnJlZShiZGF0YSk7CisJCWlmICghYmRhdGEtPmJ1ZmZlcikgewor CQkJc2VuZF9lcnJvcihjb25uLCBFTk9NRU0pOwogCQkJcmV0dXJuOwogCQl9 Ci0JCS8qIHJlLWVzdGFibGlzaCByZXF1ZXN0IGJ1ZmZlciBmb3Igc2VuZGlu ZyBFTk9NRU0uICovCi0JCWNvbm4tPmluID0gYmRhdGE7Ci0JCXNlbmRfZXJy b3IoY29ubiwgRU5PTUVNKTsKLQkJcmV0dXJuOwogCX0KIAorCWNvbm4tPmlu ID0gTlVMTDsKKwogCS8qIFVwZGF0ZSByZWxldmFudCBoZWFkZXIgZmllbGRz IGFuZCBmaWxsIGluIHRoZSBtZXNzYWdlIGJvZHkuICovCiAJYmRhdGEtPmhk ci5tc2cudHlwZSA9IHR5cGU7CiAJYmRhdGEtPmhkci5tc2cubGVuID0gbGVu OwpAQCAtNzI0LDggKzcwNywzOSBAQCB2b2lkIHNlbmRfcmVwbHkoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBl LAogCiAJLyogUXVldWUgZm9yIGxhdGVyIHRyYW5zbWlzc2lvbi4gKi8KIAls aXN0X2FkZF90YWlsKCZiZGF0YS0+bGlzdCwgJmNvbm4tPm91dF9saXN0KTsK K30KIAotCXJldHVybjsKKy8qCisgKiBTZW5kIGEgd2F0Y2ggZXZlbnQuCisg KiBBcyB0aGlzIGlzIG5vdCBkaXJlY3RseSByZWxhdGVkIHRvIHRoZSBjdXJy ZW50IGNvbW1hbmQsIGVycm9ycyBjYW4ndCBiZQorICogcmVwb3J0ZWQuCisg Ki8KK3ZvaWQgc2VuZF9ldmVudChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3QgY2hhciAqcGF0aCwgY29uc3QgY2hhciAqdG9rZW4pCit7CisJc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmJkYXRhOworCXVuc2lnbmVkIGludCBsZW47 CisKKwlsZW4gPSBzdHJsZW4ocGF0aCkgKyAxICsgc3RybGVuKHRva2VuKSAr IDE7CisJLyogRG9uJ3QgdHJ5IHRvIHNlbmQgb3Zlci1sb25nIGV2ZW50cy4g Ki8KKwlpZiAobGVuID4gWEVOU1RPUkVfUEFZTE9BRF9NQVgpCisJCXJldHVy bjsKKworCWJkYXRhID0gbmV3X2J1ZmZlcihjb25uKTsKKwlpZiAoIWJkYXRh KQorCQlyZXR1cm47CisKKwliZGF0YS0+YnVmZmVyID0gdGFsbG9jX2FycmF5 KGJkYXRhLCBjaGFyLCBsZW4pOworCWlmICghYmRhdGEtPmJ1ZmZlcikgewor CQl0YWxsb2NfZnJlZShiZGF0YSk7CisJCXJldHVybjsKKwl9CisJc3RyY3B5 KGJkYXRhLT5idWZmZXIsIHBhdGgpOworCXN0cmNweShiZGF0YS0+YnVmZmVy ICsgc3RybGVuKHBhdGgpICsgMSwgdG9rZW4pOworCWJkYXRhLT5oZHIubXNn LnR5cGUgPSBYU19XQVRDSF9FVkVOVDsKKwliZGF0YS0+aGRyLm1zZy5sZW4g PSBsZW47CisKKwkvKiBRdWV1ZSBmb3IgbGF0ZXIgdHJhbnNtaXNzaW9uLiAq LworCWxpc3RfYWRkX3RhaWwoJmJkYXRhLT5saXN0LCAmY29ubi0+b3V0X2xp c3QpOwogfQogCiAvKiBTb21lIHJvdXRpbmVzICh3cml0ZSwgbWtkaXIsIGV0 YykganVzdCBuZWVkIGEgbm9uLWVycm9yIHJldHVybiAqLwpkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKaW5kZXggOTM2OWM0Y2JmZDI2Li4y YjBmNzk2ZDliYjEgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuaApAQCAtMTUwLDYgKzE1MCw3IEBAIHVuc2lnbmVkIGludCBnZXRfc3Ry aW5ncyhzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqZGF0YSwKIAogdm9pZCBzZW5k X3JlcGx5KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2Nr bXNnX3R5cGUgdHlwZSwKIAkJY29uc3Qgdm9pZCAqZGF0YSwgdW5zaWduZWQg aW50IGxlbik7Cit2b2lkIHNlbmRfZXZlbnQoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIGNvbnN0IGNoYXIgKnBhdGgsIGNvbnN0IGNoYXIgKnRva2VuKTsK IAogLyogU29tZSByb3V0aW5lcyAod3JpdGUsIG1rZGlyLCBldGMpIGp1c3Qg bmVlZCBhIG5vbi1lcnJvciByZXR1cm4gKi8KIHZvaWQgc2VuZF9hY2soc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0 eXBlKTsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93 YXRjaC5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmMKaW5k ZXggOWZmMjA2OTBjMDAwLi42ZDgwOTczNzZlNDcgMTAwNjQ0Ci0tLSBhL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCisrKyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCkBAIC03MiwzNyArNzIsMTcgQEAg c3RhdGljIGJvb2wgaXNfY2hpbGQoY29uc3QgY2hhciAqY2hpbGQsIGNvbnN0 IGNoYXIgKnBhcmVudCkKIAlyZXR1cm4gY2hpbGRbbGVuXSA9PSAnLycgfHwg Y2hpbGRbbGVuXSA9PSAnXDAnOwogfQogCi0vKgotICogU2VuZCBhIHdhdGNo IGV2ZW50LgotICogVGVtcG9yYXJ5IG1lbW9yeSBhbGxvY2F0aW9ucyBhcmUg ZG9uZSB3aXRoIGN0eC4KLSAqLwotc3RhdGljIHZvaWQgYWRkX2V2ZW50KHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLAotCQkgICAgICBjb25zdCB2b2lkICpj dHgsCi0JCSAgICAgIHN0cnVjdCB3YXRjaCAqd2F0Y2gsCi0JCSAgICAgIGNv bnN0IGNoYXIgKm5hbWUpCitzdGF0aWMgY29uc3QgY2hhciAqZ2V0X3dhdGNo X3BhdGgoY29uc3Qgc3RydWN0IHdhdGNoICp3YXRjaCwgY29uc3QgY2hhciAq bmFtZSkKIHsKLQkvKiBEYXRhIHRvIHNlbmQgKG5vZGVcMHRva2VuXDApLiAq LwotCXVuc2lnbmVkIGludCBsZW47Ci0JY2hhciAqZGF0YTsKKwljb25zdCBj aGFyICpwYXRoID0gbmFtZTsKIAogCWlmICh3YXRjaC0+cmVsYXRpdmVfcGF0 aCkgewotCQluYW1lICs9IHN0cmxlbih3YXRjaC0+cmVsYXRpdmVfcGF0aCk7 Ci0JCWlmICgqbmFtZSA9PSAnLycpIC8qIENvdWxkIGJlICIiICovCi0JCQlu YW1lKys7CisJCXBhdGggKz0gc3RybGVuKHdhdGNoLT5yZWxhdGl2ZV9wYXRo KTsKKwkJaWYgKCpwYXRoID09ICcvJykgLyogQ291bGQgYmUgIiIgKi8KKwkJ CXBhdGgrKzsKIAl9CiAKLQlsZW4gPSBzdHJsZW4obmFtZSkgKyAxICsgc3Ry bGVuKHdhdGNoLT50b2tlbikgKyAxOwotCS8qIERvbid0IHRyeSB0byBzZW5k IG92ZXItbG9uZyBldmVudHMuICovCi0JaWYgKGxlbiA+IFhFTlNUT1JFX1BB WUxPQURfTUFYKQotCQlyZXR1cm47Ci0KLQlkYXRhID0gdGFsbG9jX2FycmF5 KGN0eCwgY2hhciwgbGVuKTsKLQlpZiAoIWRhdGEpCi0JCXJldHVybjsKLQlz dHJjcHkoZGF0YSwgbmFtZSk7Ci0Jc3RyY3B5KGRhdGEgKyBzdHJsZW4obmFt ZSkgKyAxLCB3YXRjaC0+dG9rZW4pOwotCXNlbmRfcmVwbHkoY29ubiwgWFNf V0FUQ0hfRVZFTlQsIGRhdGEsIGxlbik7Ci0JdGFsbG9jX2ZyZWUoZGF0YSk7 CisJcmV0dXJuIHBhdGg7CiB9CiAKIC8qCkBAIC0xODEsMTAgKzE2MSwxNCBA QCB2b2lkIGZpcmVfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3Qgdm9pZCAqY3R4LCBjb25zdCBjaGFyICpuYW1lLAogCQlsaXN0X2Zv cl9lYWNoX2VudHJ5KHdhdGNoLCAmaS0+d2F0Y2hlcywgbGlzdCkgewogCQkJ aWYgKGV4YWN0KSB7CiAJCQkJaWYgKHN0cmVxKG5hbWUsIHdhdGNoLT5ub2Rl KSkKLQkJCQkJYWRkX2V2ZW50KGksIGN0eCwgd2F0Y2gsIG5hbWUpOworCQkJ CQlzZW5kX2V2ZW50KGksCisJCQkJCQkgICBnZXRfd2F0Y2hfcGF0aCh3YXRj aCwgbmFtZSksCisJCQkJCQkgICB3YXRjaC0+dG9rZW4pOwogCQkJfSBlbHNl IHsKIAkJCQlpZiAoaXNfY2hpbGQobmFtZSwgd2F0Y2gtPm5vZGUpKQotCQkJ CQlhZGRfZXZlbnQoaSwgY3R4LCB3YXRjaCwgbmFtZSk7CisJCQkJCXNlbmRf ZXZlbnQoaSwKKwkJCQkJCSAgIGdldF93YXRjaF9wYXRoKHdhdGNoLCBuYW1l KSwKKwkJCQkJCSAgIHdhdGNoLT50b2tlbik7CiAJCQl9CiAJCX0KIAl9CkBA IC0yNTIsNyArMjM2LDcgQEAgaW50IGRvX3dhdGNoKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJc2VuZF9h Y2soY29ubiwgWFNfV0FUQ0gpOwogCiAJLyogV2UgZmlyZSBvbmNlIHVwIGZy b250OiBzaW1wbGlmaWVzIGNsaWVudHMgYW5kIHJlc3RhcnQuICovCi0JYWRk X2V2ZW50KGNvbm4sIGluLCB3YXRjaCwgd2F0Y2gtPm5vZGUpOworCXNlbmRf ZXZlbnQoY29ubiwgZ2V0X3dhdGNoX3BhdGgod2F0Y2gsIHdhdGNoLT5ub2Rl KSwgd2F0Y2gtPnRva2VuKTsKIAogCXJldHVybiAwOwogfQo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-02.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-02.patch" Content-Transfer-Encoding: base64 RnJvbSBiM2RmODk3ZjZiYWIxNTc0ZDIyYWYxMGU3NmM1MzE4YzJlODM1ZGFl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBoZWxw ZXJzIHRvIGZyZWUgc3RydWN0IGJ1ZmZlcmVkX2RhdGEKCkFkZCB0d28gaGVs cGVycyBmb3IgZnJlZWluZyBzdHJ1Y3QgYnVmZmVyZWRfZGF0YTogZnJlZV9i dWZmZXJlZF9kYXRhKCkKZm9yIGZyZWVpbmcgb25lIGluc3RhbmNlIGFuZCBj b25uX2ZyZWVfYnVmZmVyZWRfZGF0YSgpIGZvciBmcmVlaW5nIGFsbAppbnN0 YW5jZXMgZm9yIGEgY29ubmVjdGlvbi4KClRoaXMgaXMgYXZvaWRpbmcgZHVw bGljYXRlZCBjb2RlIGFuZCB3aWxsIGhlbHAgbGF0ZXIgd2hlbiBtb3JlIGFj dGlvbnMKYXJlIG5lZWRlZCB3aGVuIGZyZWVpbmcgYSBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQt Ynk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1v ZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3 ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggZTY3NzZiYWU4 Zjk5Li41ZDU0Nzc5ZDQwOWIgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYwpAQCAtMjA4LDYgKzIwOCwyMSBAQCB2b2lkIHJlb3Blbl9s b2codm9pZCkKIAl9CiB9CiAKK3N0YXRpYyB2b2lkIGZyZWVfYnVmZmVyZWRf ZGF0YShzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqb3V0LAorCQkJICAgICAgIHN0 cnVjdCBjb25uZWN0aW9uICpjb25uKQoreworCWxpc3RfZGVsKCZvdXQtPmxp c3QpOworCXRhbGxvY19mcmVlKG91dCk7Cit9CisKK3ZvaWQgY29ubl9mcmVl X2J1ZmZlcmVkX2RhdGEoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCit7CisJ c3RydWN0IGJ1ZmZlcmVkX2RhdGEgKm91dDsKKworCXdoaWxlICgob3V0ID0g bGlzdF90b3AoJmNvbm4tPm91dF9saXN0LCBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSwgbGlzdCkpKQorCQlmcmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBjb25uKTsK K30KKwogc3RhdGljIGJvb2wgd3JpdGVfbWVzc2FnZXMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pCiB7CiAJaW50IHJldDsKQEAgLTI1MSw4ICsyNjYsNyBA QCBzdGF0aWMgYm9vbCB3cml0ZV9tZXNzYWdlcyhzdHJ1Y3QgY29ubmVjdGlv biAqY29ubikKIAogCXRyYWNlX2lvKGNvbm4sIG91dCwgMSk7CiAKLQlsaXN0 X2RlbCgmb3V0LT5saXN0KTsKLQl0YWxsb2NfZnJlZShvdXQpOworCWZyZWVf YnVmZmVyZWRfZGF0YShvdXQsIGNvbm4pOwogCiAJcmV0dXJuIHRydWU7CiB9 CkBAIC0xMzkxLDE4ICsxNDA1LDEyIEBAIHN0YXRpYyBzdHJ1Y3QgewogICov CiBzdGF0aWMgdm9pZCBpZ25vcmVfY29ubmVjdGlvbihzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubikKIHsKLQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqb3V0LCAq dG1wOwotCiAJdHJhY2UoIkNPTk4gJXAgaWdub3JlZFxuIiwgY29ubik7CiAK IAljb25uLT5pc19pZ25vcmVkID0gdHJ1ZTsKIAljb25uX2RlbGV0ZV9hbGxf d2F0Y2hlcyhjb25uKTsKIAljb25uX2RlbGV0ZV9hbGxfdHJhbnNhY3Rpb25z KGNvbm4pOwotCi0JbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKG91dCwgdG1w LCAmY29ubi0+b3V0X2xpc3QsIGxpc3QpIHsKLQkJbGlzdF9kZWwoJm91dC0+ bGlzdCk7Ci0JCXRhbGxvY19mcmVlKG91dCk7Ci0JfQorCWNvbm5fZnJlZV9i dWZmZXJlZF9kYXRhKGNvbm4pOwogCiAJdGFsbG9jX2ZyZWUoY29ubi0+aW4p OwogCWNvbm4tPmluID0gTlVMTDsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5oCmluZGV4IDJiMGY3OTZkOWJiMS4uODNkNDk2OTNmYzE5IDEw MDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCisr KyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKQEAgLTIyNiw2 ICsyMjYsOCBAQCBleHRlcm4geGVuZ250dGFiX2hhbmRsZSAqKnhndF9oYW5k bGU7CiAKIGludCByZW1lbWJlcl9zdHJpbmcoc3RydWN0IGhhc2h0YWJsZSAq aGFzaCwgY29uc3QgY2hhciAqc3RyKTsKIAordm9pZCBjb25uX2ZyZWVfYnVm ZmVyZWRfZGF0YShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7CisKICNlbmRp ZiAvKiBfWEVOU1RPUkVEX0NPUkVfSCAqLwogCiAvKgpkaWZmIC0tZ2l0IGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IGQ1ZTFlM2U5ZDQyZC4u M2JmZjMyMmQwMjRkIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2RvbWFpbi5jCkBAIC00MDIsMTUgKzQwMiwxMCBAQCBzdGF0aWMgc3RydWN0 IGRvbWFpbiAqZmluZF9kb21haW5fYnlfZG9taWQodW5zaWduZWQgaW50IGRv bWlkKQogc3RhdGljIHZvaWQgZG9tYWluX2Nvbm5fcmVzZXQoc3RydWN0IGRv bWFpbiAqZG9tYWluKQogewogCXN0cnVjdCBjb25uZWN0aW9uICpjb25uID0g ZG9tYWluLT5jb25uOwotCXN0cnVjdCBidWZmZXJlZF9kYXRhICpvdXQ7CiAK IAljb25uX2RlbGV0ZV9hbGxfd2F0Y2hlcyhjb25uKTsKIAljb25uX2RlbGV0 ZV9hbGxfdHJhbnNhY3Rpb25zKGNvbm4pOwotCi0Jd2hpbGUgKChvdXQgPSBs aXN0X3RvcCgmY29ubi0+b3V0X2xpc3QsIHN0cnVjdCBidWZmZXJlZF9kYXRh LCBsaXN0KSkpIHsKLQkJbGlzdF9kZWwoJm91dC0+bGlzdCk7Ci0JCXRhbGxv Y19mcmVlKG91dCk7Ci0JfQorCWNvbm5fZnJlZV9idWZmZXJlZF9kYXRhKGNv bm4pOwogCiAJdGFsbG9jX2ZyZWUoY29ubi0+aW4pOwogCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-03.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-03.patch" Content-Transfer-Encoding: base64 RnJvbSA4OWMwMjY2NDc0NWNkZDYyYWE1NTZhNzg3MGNkZjQ5NTc2YTkwMWEx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHJlZHVjZSBu dW1iZXIgb2Ygd2F0Y2ggZXZlbnRzCgpXaGVuIHJlbW92aW5nIGEgd2F0Y2hl ZCBub2RlIG91dHNpZGUgb2YgYSB0cmFuc2FjdGlvbiwgdHdvIHdhdGNoIGV2 ZW50cwphcmUgYmVpbmcgcHJvZHVjZWQgaW5zdGVhZCBvZiBqdXN0IGEgc2lu Z2xlIG9uZS4KCldoZW4gZmluYWxpemluZyBhIHRyYW5zYWN0aW9uIHdhdGNo IGV2ZW50cyBjYW4gYmUgZ2VuZXJhdGVkIGZvciBlYWNoCm5vZGUgd2hpY2gg aXMgYmVpbmcgbW9kaWZpZWQsIGV2ZW4gaWYgb3V0c2lkZSBhIHRyYW5zYWN0 aW9uIHN1Y2gKbW9kaWZpY2F0aW9ucyBtaWdodCBub3QgaGF2ZSByZXN1bHRl ZCBpbiBhIHdhdGNoIGV2ZW50LgoKVGhpcyBoYXBwZW5zIGUuZy46CgotIGZv ciBub2RlcyB3aGljaCBhcmUgb25seSBtb2RpZmllZCBkdWUgdG8gYWRkZWQv cmVtb3ZlZCBjaGlsZCBlbnRyaWVzCi0gZm9yIG5vZGVzIGJlaW5nIHJlbW92 ZWQgb3IgY3JlYXRlZCBpbXBsaWNpdGx5IChlLmcuIGNyZWF0aW9uIG9mIGEv Yi9jCiAgaXMgaW1wbGljaXRseSBjcmVhdGluZyBhL2IsIHJlc3VsdGluZyBp biB3YXRjaCBldmVudHMgZm9yIGEsIGEvYiBhbmQKICBhL2IvYyBpbnN0ZWFk IG9mIGEvYi9jIG9ubHkpCgpBdm9pZCB0aGVzZSBhZGRpdGlvbmFsIHdhdGNo IGV2ZW50cywgaW4gb3JkZXIgdG8gcmVkdWNlIHRoZSBuZWVkZWQKbWVtb3J5 IGluc2lkZSBYZW5zdG9yZSBmb3IgcXVldWVpbmcgdGhlbS4KClRoaXMgaXMg YmVpbmcgYWNoaWV2ZWQgYnkgYWRkaW5nIGV2ZW50IGZsYWdzIHRvIHN0cnVj dCBhY2Nlc3NlZF9ub2RlCnNwZWNpZnlpbmcgd2hldGhlciBhbiBldmVudCBz aG91bGQgYmUgdHJpZ2dlcmVkLCBhbmQgd2hldGhlciBpdCBzaG91bGQKYmUg YW4gZXhhY3QgbWF0Y2ggb2YgdGhlIG1vZGlmaWVkIHBhdGguIEJvdGggZmxh Z3MgY2FuIGJlIHNldCBmcm9tCmZpcmVfd2F0Y2hlcygpIGluc3RlYWQgb2Yg aW1wbHlpbmcgdGhlbSBvbmx5LgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYu CgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNv bT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwppbmRl eCA1ZDU0Nzc5ZDQwOWIuLjUzZDAwM2FlYmZmYiAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0xMTgyLDcgKzExODIsNyBAQCBz dGF0aWMgdm9pZCBkZWxldGVfY2hpbGQoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sCiB9CiAKIHN0YXRpYyBpbnQgZGVsZXRlX25vZGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKLQkJICAgICAgIHN0cnVj dCBub2RlICpwYXJlbnQsIHN0cnVjdCBub2RlICpub2RlKQorCQkgICAgICAg c3RydWN0IG5vZGUgKnBhcmVudCwgc3RydWN0IG5vZGUgKm5vZGUsIGJvb2wg d2F0Y2hfZXhhY3QpCiB7CiAJY2hhciAqbmFtZTsKIApAQCAtMTE5NCw3ICsx MTk0LDcgQEAgc3RhdGljIGludCBkZWxldGVfbm9kZShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCQkJCSAgICAgICBub2Rl LT5jaGlsZHJlbik7CiAJCWNoaWxkID0gbmFtZSA/IHJlYWRfbm9kZShjb25u LCBub2RlLCBuYW1lKSA6IE5VTEw7CiAJCWlmIChjaGlsZCkgewotCQkJaWYg KGRlbGV0ZV9ub2RlKGNvbm4sIGN0eCwgbm9kZSwgY2hpbGQpKQorCQkJaWYg KGRlbGV0ZV9ub2RlKGNvbm4sIGN0eCwgbm9kZSwgY2hpbGQsIHRydWUpKQog CQkJCXJldHVybiBlcnJubzsKIAkJfSBlbHNlIHsKIAkJCXRyYWNlKCJkZWxl dGVfbm9kZTogRXJyb3IgZGVsZXRpbmcgY2hpbGQgJyVzLyVzJyFcbiIsCkBA IC0xMjA2LDcgKzEyMDYsMTIgQEAgc3RhdGljIGludCBkZWxldGVfbm9kZShz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCQl0 YWxsb2NfZnJlZShuYW1lKTsKIAl9CiAKLQlmaXJlX3dhdGNoZXMoY29ubiwg Y3R4LCBub2RlLT5uYW1lLCBub2RlLCB0cnVlLCBOVUxMKTsKKwkvKgorCSAq IEZpcmUgdGhlIHdhdGNoZXMgbm93LCB3aGVuIHdlIGNhbiBzdGlsbCBzZWUg dGhlIG5vZGUgcGVybWlzc2lvbnMuCisJICogVGhpcyBmaW5lIGFzIHdlIGFy ZSBzaW5nbGUgdGhyZWFkZWQgYW5kIHRoZSBuZXh0IHBvc3NpYmxlIHJlYWQg d2lsbAorCSAqIGJlIGhhbmRsZWQgb25seSBhZnRlciB0aGUgbm9kZSBoYXMg YmVlbiByZWFsbHkgcmVtb3ZlZC4KKwkgKi8KKwlmaXJlX3dhdGNoZXMoY29u biwgY3R4LCBub2RlLT5uYW1lLCBub2RlLCB3YXRjaF9leGFjdCwgTlVMTCk7 CiAJZGVsZXRlX25vZGVfc2luZ2xlKGNvbm4sIG5vZGUpOwogCWRlbGV0ZV9j aGlsZChjb25uLCBwYXJlbnQsIGJhc2VuYW1lKG5vZGUtPm5hbWUpKTsKIAl0 YWxsb2NfZnJlZShub2RlKTsKQEAgLTEyMzIsMTMgKzEyMzcsNyBAQCBzdGF0 aWMgaW50IF9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9p ZCAqY3R4LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIAkJcmV0dXJuIChlcnJubyA9 PSBFTk9NRU0pID8gRU5PTUVNIDogRUlOVkFMOwogCW5vZGUtPnBhcmVudCA9 IHBhcmVudDsKIAotCS8qCi0JICogRmlyZSB0aGUgd2F0Y2hlcyBub3csIHdo ZW4gd2UgY2FuIHN0aWxsIHNlZSB0aGUgbm9kZSBwZXJtaXNzaW9ucy4KLQkg KiBUaGlzIGZpbmUgYXMgd2UgYXJlIHNpbmdsZSB0aHJlYWRlZCBhbmQgdGhl IG5leHQgcG9zc2libGUgcmVhZCB3aWxsCi0JICogYmUgaGFuZGxlZCBvbmx5 IGFmdGVyIHRoZSBub2RlIGhhcyBiZWVuIHJlYWxseSByZW1vdmVkLgotCSAq LwotCWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5hbWUsIG5vZGUsIGZhbHNl LCBOVUxMKTsKLQlyZXR1cm4gZGVsZXRlX25vZGUoY29ubiwgY3R4LCBwYXJl bnQsIG5vZGUpOworCXJldHVybiBkZWxldGVfbm9kZShjb25uLCBjdHgsIHBh cmVudCwgbm9kZSwgZmFsc2UpOwogfQogCiAKZGlmZiAtLWdpdCBhL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKaW5kZXggNGZmYTE4MzEx MTIwLi42ZmJkYjI5ZGNkZDcgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCisrKyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCkBAIC0xMzAsNiArMTMwLDEwIEBA IHN0cnVjdCBhY2Nlc3NlZF9ub2RlCiAKIAkvKiBUcmFuc2FjdGlvbiBub2Rl IGluIGRhdGEgYmFzZT8gKi8KIAlib29sIHRhX25vZGU7CisKKwkvKiBXYXRj aCBldmVudCBmbGFncy4gKi8KKwlib29sIGZpcmVfd2F0Y2g7CisJYm9vbCB3 YXRjaF9leGFjdDsKIH07CiAKIHN0cnVjdCBjaGFuZ2VkX2RvbWFpbgpAQCAt MzMwLDYgKzMzNCwyOSBAQCBpbnQgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAogfQogCiAvKgorICog QSB3YXRjaCBldmVudCBzaG91bGQgYmUgZmlyZWQgZm9yIGEgbm9kZSBtb2Rp ZmllZCBpbnNpZGUgYSB0cmFuc2FjdGlvbi4KKyAqIFNldCB0aGUgY29ycmVz cG9uZGluZyBpbmZvcm1hdGlvbi4gQSBub24tZXhhY3QgZXZlbnQgaXMgcmVw bGFjaW5nIGFuIGV4YWN0CisgKiBvbmUsIGJ1dCBub3QgdGhlIG90aGVyIHdh eSByb3VuZC4KKyAqLwordm9pZCBxdWV1ZV93YXRjaGVzKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpuYW1lLCBib29sIHdhdGNoX2V4 YWN0KQoreworCXN0cnVjdCBhY2Nlc3NlZF9ub2RlICppOworCisJaSA9IGZp bmRfYWNjZXNzZWRfbm9kZShjb25uLT50cmFuc2FjdGlvbiwgbmFtZSk7CisJ aWYgKCFpKSB7CisJCWNvbm4tPnRyYW5zYWN0aW9uLT5mYWlsID0gdHJ1ZTsK KwkJcmV0dXJuOworCX0KKworCWlmICghaS0+ZmlyZV93YXRjaCkgeworCQlp LT5maXJlX3dhdGNoID0gdHJ1ZTsKKwkJaS0+d2F0Y2hfZXhhY3QgPSB3YXRj aF9leGFjdDsKKwl9IGVsc2UgaWYgKCF3YXRjaF9leGFjdCkgeworCQlpLT53 YXRjaF9leGFjdCA9IGZhbHNlOworCX0KK30KKworLyoKICAqIEZpbmFsaXpl IHRyYW5zYWN0aW9uOgogICogV2FsayB0aHJvdWdoIGFjY2Vzc2VkIG5vZGVz IGFuZCBjaGVjayBnZW5lcmF0aW9uIGFnYWluc3QgZ2xvYmFsIGRhdGEuCiAg KiBJZiBhbGwgZW50cmllcyBtYXRjaCwgcmVhZCB0aGUgdHJhbnNhY3Rpb24g ZW50cmllcyBhbmQgd3JpdGUgdGhlbSB3aXRob3V0CkBAIC0zODMsMTUgKzQx MCwxNSBAQCBzdGF0aWMgaW50IGZpbmFsaXplX3RyYW5zYWN0aW9uKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAogCQkJCXJldCA9IHRkYl9zdG9yZSh0ZGJf Y3R4LCBrZXksIGRhdGEsCiAJCQkJCQlUREJfUkVQTEFDRSk7CiAJCQkJdGFs bG9jX2ZyZWUoZGF0YS5kcHRyKTsKLQkJCQlpZiAocmV0KQotCQkJCQlnb3Rv IGVycjsKLQkJCQlmaXJlX3dhdGNoZXMoY29ubiwgdHJhbnMsIGktPm5vZGUs IE5VTEwsIGZhbHNlLAotCQkJCQkgICAgIGktPnBlcm1zLnAgPyAmaS0+cGVy bXMgOiBOVUxMKTsKIAkJCX0gZWxzZSB7Ci0JCQkJZmlyZV93YXRjaGVzKGNv bm4sIHRyYW5zLCBpLT5ub2RlLCBOVUxMLCBmYWxzZSwKKwkJCQlyZXQgPSB0 ZGJfZGVsZXRlKHRkYl9jdHgsIGtleSk7CisJCQl9CisJCQlpZiAocmV0KQor CQkJCWdvdG8gZXJyOworCQkJaWYgKGktPmZpcmVfd2F0Y2gpIHsKKwkJCQlm aXJlX3dhdGNoZXMoY29ubiwgdHJhbnMsIGktPm5vZGUsIE5VTEwsCisJCQkJ CSAgICAgaS0+d2F0Y2hfZXhhY3QsCiAJCQkJCSAgICAgaS0+cGVybXMucCA/ ICZpLT5wZXJtcyA6IE5VTEwpOwotCQkJCWlmICh0ZGJfZGVsZXRlKHRkYl9j dHgsIGtleSkpCi0JCQkJCWdvdG8gZXJyOwogCQkJfQogCQl9CiAKZGlmZiAt LWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5o IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKaW5k ZXggMTQwNjI3MzBlM2M5Li4wMDkzY2FjODA3ZTMgMTAwNjQ0Ci0tLSBhL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCisrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCkBAIC00Miw2 ICs0Miw5IEBAIHZvaWQgdHJhbnNhY3Rpb25fZW50cnlfZGVjKHN0cnVjdCB0 cmFuc2FjdGlvbiAqdHJhbnMsIHVuc2lnbmVkIGludCBkb21pZCk7CiBpbnQg YWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlLAogICAgICAgICAgICAgICAgIGVudW0gbm9kZV9hY2Nlc3Nf dHlwZSB0eXBlLCBUREJfREFUQSAqa2V5KTsKIAorLyogUXVldWUgd2F0Y2hl cyBmb3IgYSBtb2RpZmllZCBub2RlLiAqLwordm9pZCBxdWV1ZV93YXRjaGVz KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpuYW1lLCBi b29sIHdhdGNoX2V4YWN0KTsKKwogLyogUHJlcGVuZCB0aGUgdHJhbnNhY3Rp b24gdG8gbmFtZSBpZiBhcHByb3ByaWF0ZS4gKi8KIGludCB0cmFuc2FjdGlv bl9wcmVwZW5kKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFy ICpuYW1lLAogICAgICAgICAgICAgICAgICAgICAgICAgVERCX0RBVEEgKmtl eSk7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0 Y2guYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCmluZGV4 IDZkODA5NzM3NmU0Ny4uMmY5MzY3NzY3ZTQ0IDEwMDY0NAotLS0gYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfd2F0Y2guYwpAQCAtMjksNiArMjksNyBAQAogI2lu Y2x1ZGUgInhlbnN0b3JlX2xpYi5oIgogI2luY2x1ZGUgInV0aWxzLmgiCiAj aW5jbHVkZSAieGVuc3RvcmVkX2RvbWFpbi5oIgorI2luY2x1ZGUgInhlbnN0 b3JlZF90cmFuc2FjdGlvbi5oIgogCiBleHRlcm4gaW50IHF1b3RhX25iX3dh dGNoX3Blcl9kb21haW47CiAKQEAgLTE0Myw5ICsxNDQsMTEgQEAgdm9pZCBm aXJlX3dhdGNoZXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZv aWQgKmN0eCwgY29uc3QgY2hhciAqbmFtZSwKIAlzdHJ1Y3QgY29ubmVjdGlv biAqaTsKIAlzdHJ1Y3Qgd2F0Y2ggKndhdGNoOwogCi0JLyogRHVyaW5nIHRy YW5zYWN0aW9ucywgZG9uJ3QgZmlyZSB3YXRjaGVzLiAqLwotCWlmIChjb25u ICYmIGNvbm4tPnRyYW5zYWN0aW9uKQorCS8qIER1cmluZyB0cmFuc2FjdGlv bnMsIGRvbid0IGZpcmUgd2F0Y2hlcywgYnV0IHF1ZXVlIHRoZW0uICovCisJ aWYgKGNvbm4gJiYgY29ubi0+dHJhbnNhY3Rpb24pIHsKKwkJcXVldWVfd2F0 Y2hlcyhjb25uLCBuYW1lLCBleGFjdCk7CiAJCXJldHVybjsKKwl9CiAKIAkv KiBDcmVhdGUgYW4gZXZlbnQgZm9yIGVhY2ggd2F0Y2guICovCiAJbGlzdF9m b3JfZWFjaF9lbnRyeShpLCAmY29ubmVjdGlvbnMsIGxpc3QpIHsK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-04.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-04.patch" Content-Transfer-Encoding: base64 RnJvbSA3OWE4OGIzOGNiOGI4Zjg3MDg5MzViYzQzYjFlOTM4MjY2MjZhYmFm IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxldCB1bnJl YWQgd2F0Y2ggZXZlbnRzIHRpbWUgb3V0CgpBIGZ1dHVyZSBtb2RpZmljYXRp b24gd2lsbCBsaW1pdCB0aGUgbnVtYmVyIG9mIG91dHN0YW5kaW5nIHJlcXVl c3RzCmZvciBhIGRvbWFpbiwgd2hlcmUgIm91dHN0YW5kaW5nIiBtZWFucyB0 aGF0IHRoZSByZXNwb25zZSBvZiB0aGUKcmVxdWVzdCBvciBhbnkgcmVzdWx0 aW5nIHdhdGNoIGV2ZW50IGhhc24ndCBiZWVuIGNvbnN1bWVkIHlldC4KCklu IG9yZGVyIHRvIGF2b2lkIGEgbWFsaWNpb3VzIGd1ZXN0IGJlaW5nIGNhcGFi bGUgdG8gYmxvY2sgb3RoZXIgZ3Vlc3RzCmJ5IG5vdCByZWFkaW5nIHdhdGNo IGV2ZW50cywgYWRkIGEgdGltZW91dCBmb3Igd2F0Y2ggZXZlbnRzLiBJbiBj YXNlIGEKd2F0Y2ggZXZlbnQgaGFzbid0IGJlZW4gY29uc3VtZWQgYWZ0ZXIg dGhpcyB0aW1lb3V0LCBpdCBpcyBiZWluZwpkZWxldGVkLiBTZXQgdGhlIGRl ZmF1bHQgdGltZW91dCB0byAyMCBzZWNvbmRzIChhIHJhbmRvbSB2YWx1ZSBi ZWluZwpub3QgdG9vIGhpZ2gpLgoKSW4gb3JkZXIgdG8gc3VwcG9ydCB0byBz cGVjaWZ5IG90aGVyIHRpbWVvdXQgdmFsdWVzIGluIGZ1dHVyZSwgdXNlIGEK Z2VuZXJpYyBjb21tYW5kIGxpbmUgb3B0aW9uIGZvciB0aGF0IHB1cnBvc2U6 CgotLXRpbWVvdXR8LXcgd2F0Y2gtZXZlbnQ9PHNlY29uZHM+CgpUaGlzIGlz IHBhcnQgb2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzExLgoKUmVwb3J0ZWQt Ynk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1v ZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3 ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggNTNkMDAzYWVi ZmZiLi45ODgzN2VmMmU5Y2YgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYwpAQCAtMTA2LDYgKzEwNiw4IEBAIGludCBxdW90YV9tYXhf ZW50cnlfc2l6ZSA9IDIwNDg7IC8qIDJLICovCiBpbnQgcXVvdGFfbWF4X3Ry YW5zYWN0aW9uID0gMTA7CiBpbnQgcXVvdGFfbmJfcGVybXNfcGVyX25vZGUg PSA1OwogCit1bnNpZ25lZCBpbnQgdGltZW91dF93YXRjaF9ldmVudF9tc2Vj ID0gMjAwMDA7CisKIHZvaWQgdHJhY2UoY29uc3QgY2hhciAqZm10LCAuLi4p CiB7CiAJdmFfbGlzdCBhcmdsaXN0OwpAQCAtMjA4LDE5ICsyMTAsOTIgQEAg dm9pZCByZW9wZW5fbG9nKHZvaWQpCiAJfQogfQogCitzdGF0aWMgdWludDY0 X3QgZ2V0X25vd19tc2VjKHZvaWQpCit7CisJc3RydWN0IHRpbWVzcGVjIG5v d190czsKKworCWlmIChjbG9ja19nZXR0aW1lKENMT0NLX01PTk9UT05JQywg Jm5vd190cykpCisJCWJhcmZfcGVycm9yKCJDb3VsZCBub3QgZmluZCB0aW1l IChjbG9ja19nZXR0aW1lIGZhaWxlZCkiKTsKKworCXJldHVybiBub3dfdHMu dHZfc2VjICogMTAwMCArIG5vd190cy50dl9uc2VjIC8gMTAwMDAwMDsKK30K Kwogc3RhdGljIHZvaWQgZnJlZV9idWZmZXJlZF9kYXRhKHN0cnVjdCBidWZm ZXJlZF9kYXRhICpvdXQsCiAJCQkgICAgICAgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pCiB7CisJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKnJlcTsKKwogCWxp c3RfZGVsKCZvdXQtPmxpc3QpOworCisJLyoKKwkgKiBVcGRhdGUgY29ubi0+ dGltZW91dF9tc2VjIHdpdGggdGhlIG5leHQgZm91bmQgdGltZW91dCB2YWx1 ZSBpbiB0aGUKKwkgKiBxdWV1ZWQgcGVuZGluZyByZXF1ZXN0cy4KKwkgKi8K KwlpZiAob3V0LT50aW1lb3V0X21zZWMpIHsKKwkJY29ubi0+dGltZW91dF9t c2VjID0gMDsKKwkJbGlzdF9mb3JfZWFjaF9lbnRyeShyZXEsICZjb25uLT5v dXRfbGlzdCwgbGlzdCkgeworCQkJaWYgKHJlcS0+dGltZW91dF9tc2VjKSB7 CisJCQkJY29ubi0+dGltZW91dF9tc2VjID0gcmVxLT50aW1lb3V0X21zZWM7 CisJCQkJYnJlYWs7CisJCQl9CisJCX0KKwl9CisKIAl0YWxsb2NfZnJlZShv dXQpOwogfQogCitzdGF0aWMgdm9pZCBjaGVja19ldmVudF90aW1lb3V0KHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCB1aW50NjRfdCBtc2VjcywKKwkJCQlp bnQgKnB0aW1lb3V0KQoreworCXVpbnQ2NF90IGRlbHRhOworCXN0cnVjdCBi dWZmZXJlZF9kYXRhICpvdXQsICp0bXA7CisKKwlpZiAoIWNvbm4tPnRpbWVv dXRfbXNlYykKKwkJcmV0dXJuOworCisJZGVsdGEgPSBjb25uLT50aW1lb3V0 X21zZWMgLSBtc2VjczsKKwlpZiAoY29ubi0+dGltZW91dF9tc2VjIDw9IG1z ZWNzKSB7CisJCWRlbHRhID0gMDsKKwkJbGlzdF9mb3JfZWFjaF9lbnRyeV9z YWZlKG91dCwgdG1wLCAmY29ubi0+b3V0X2xpc3QsIGxpc3QpIHsKKwkJCS8q CisJCQkgKiBPbmx5IGxvb2sgYXQgYnVmZmVycyB3aXRoIHRpbWVvdXQgYW5k IG5vIGRhdGEKKwkJCSAqIGFscmVhZHkgd3JpdHRlbiB0byB0aGUgcmluZy4K KwkJCSAqLworCQkJaWYgKG91dC0+dGltZW91dF9tc2VjICYmIG91dC0+aW5o ZHIgJiYgIW91dC0+dXNlZCkgeworCQkJCWlmIChvdXQtPnRpbWVvdXRfbXNl YyA+IG1zZWNzKSB7CisJCQkJCWNvbm4tPnRpbWVvdXRfbXNlYyA9IG91dC0+ dGltZW91dF9tc2VjOworCQkJCQlkZWx0YSA9IGNvbm4tPnRpbWVvdXRfbXNl YyAtIG1zZWNzOworCQkJCQlicmVhazsKKwkJCQl9CisKKwkJCQkvKgorCQkJ CSAqIEZyZWUgb3V0IHdpdGhvdXQgdXBkYXRpbmcgY29ubi0+dGltZW91dF9t c2VjLAorCQkJCSAqIGFzIHRoZSB1cGRhdGUgaXMgZG9uZSBpbiB0aGlzIGxv b3AgYWxyZWFkeS4KKwkJCQkgKi8KKwkJCQlvdXQtPnRpbWVvdXRfbXNlYyA9 IDA7CisJCQkJdHJhY2UoIndhdGNoIGV2ZW50IHBhdGggJXMgZm9yIGRvbWFp biAldSB0aW1lZCBvdXRcbiIsCisJCQkJICAgICAgb3V0LT5idWZmZXIsIGNv bm4tPmlkKTsKKwkJCQlmcmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBjb25uKTsK KwkJCX0KKwkJfQorCQlpZiAoIWRlbHRhKSB7CisJCQljb25uLT50aW1lb3V0 X21zZWMgPSAwOworCQkJcmV0dXJuOworCQl9CisJfQorCisJaWYgKCpwdGlt ZW91dCA9PSAtMSB8fCAqcHRpbWVvdXQgPiBkZWx0YSkKKwkJKnB0aW1lb3V0 ID0gZGVsdGE7Cit9CisKIHZvaWQgY29ubl9mcmVlX2J1ZmZlcmVkX2RhdGEo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCiB7CiAJc3RydWN0IGJ1ZmZlcmVk X2RhdGEgKm91dDsKIAogCXdoaWxlICgob3V0ID0gbGlzdF90b3AoJmNvbm4t Pm91dF9saXN0LCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSwgbGlzdCkpKQogCQlm cmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBjb25uKTsKKworCWNvbm4tPnRpbWVv dXRfbXNlYyA9IDA7CiB9CiAKIHN0YXRpYyBib29sIHdyaXRlX21lc3NhZ2Vz KHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQpAQCAtMzMzLDYgKzQwOCw3IEBA IHN0YXRpYyB2b2lkIGluaXRpYWxpemVfZmRzKGludCAqcF9zb2NrX3BvbGxm ZF9pZHgsIGludCAqcF9yb19zb2NrX3BvbGxmZF9pZHgsCiB7CiAJc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm47CiAJc3RydWN0IHdybF90aW1lc3RhbXB0IG5v dzsKKwl1aW50NjRfdCBtc2VjczsKIAogCWlmIChmZHMpCiAJCW1lbXNldChm ZHMsIDAsIHNpemVvZihzdHJ1Y3QgcG9sbGZkKSAqIGN1cnJlbnRfYXJyYXlf c2l6ZSk7CkBAIC0zNTQsMTAgKzQzMCwxMiBAQCBzdGF0aWMgdm9pZCBpbml0 aWFsaXplX2ZkcyhpbnQgKnBfc29ja19wb2xsZmRfaWR4LCBpbnQgKnBfcm9f c29ja19wb2xsZmRfaWR4LAogCiAJd3JsX2dldHRpbWVfbm93KCZub3cpOwog CXdybF9sb2dfcGVyaW9kaWMobm93KTsKKwltc2VjcyA9IGdldF9ub3dfbXNl YygpOwogCiAJbGlzdF9mb3JfZWFjaF9lbnRyeShjb25uLCAmY29ubmVjdGlv bnMsIGxpc3QpIHsKIAkJaWYgKGNvbm4tPmRvbWFpbikgewogCQkJd3JsX2No ZWNrX3RpbWVvdXQoY29ubi0+ZG9tYWluLCBub3csIHB0aW1lb3V0KTsKKwkJ CWNoZWNrX2V2ZW50X3RpbWVvdXQoY29ubiwgbXNlY3MsIHB0aW1lb3V0KTsK IAkJCWlmIChkb21haW5fY2FuX3JlYWQoY29ubikgfHwKIAkJCSAgICAoZG9t YWluX2Nhbl93cml0ZShjb25uKSAmJgogCQkJICAgICAhbGlzdF9lbXB0eSgm Y29ubi0+b3V0X2xpc3QpKSkKQEAgLTcwMSw2ICs3NzksNyBAQCB2b2lkIHNl bmRfcmVwbHkoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGVudW0geHNkX3Nv Y2ttc2dfdHlwZSB0eXBlLAogCQlyZXR1cm47CiAJYmRhdGEtPmluaGRyID0g dHJ1ZTsKIAliZGF0YS0+dXNlZCA9IDA7CisJYmRhdGEtPnRpbWVvdXRfbXNl YyA9IDA7CiAKIAlpZiAobGVuIDw9IERFRkFVTFRfQlVGRkVSX1NJWkUpCiAJ CWJkYXRhLT5idWZmZXIgPSBiZGF0YS0+ZGVmYXVsdF9idWZmZXI7CkBAIC03 NTIsNiArODMxLDEyIEBAIHZvaWQgc2VuZF9ldmVudChzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgY29uc3QgY2hhciAqcGF0aCwgY29uc3QgY2hhciAqdG9r ZW4pCiAJYmRhdGEtPmhkci5tc2cudHlwZSA9IFhTX1dBVENIX0VWRU5UOwog CWJkYXRhLT5oZHIubXNnLmxlbiA9IGxlbjsKIAorCWlmICh0aW1lb3V0X3dh dGNoX2V2ZW50X21zZWMgJiYgZG9tYWluX2lzX3VucHJpdmlsZWdlZChjb25u KSkgeworCQliZGF0YS0+dGltZW91dF9tc2VjID0gZ2V0X25vd19tc2VjKCkg KyB0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWM7CisJCWlmICghY29ubi0+dGlt ZW91dF9tc2VjKQorCQkJY29ubi0+dGltZW91dF9tc2VjID0gYmRhdGEtPnRp bWVvdXRfbXNlYzsKKwl9CisKIAkvKiBRdWV1ZSBmb3IgbGF0ZXIgdHJhbnNt aXNzaW9uLiAqLwogCWxpc3RfYWRkX3RhaWwoJmJkYXRhLT5saXN0LCAmY29u bi0+b3V0X2xpc3QpOwogfQpAQCAtMTk5NCw2ICsyMDc5LDkgQEAgc3RhdGlj IHZvaWQgdXNhZ2Uodm9pZCkKICIgIC1XLCAtLXdhdGNoLW5iIDxuYj4gICAg IGxpbWl0IHRoZSBudW1iZXIgb2Ygd2F0Y2hlcyBwZXIgZG9tYWluLFxuIgog IiAgLXQsIC0tdHJhbnNhY3Rpb24gPG5iPiAgbGltaXQgdGhlIG51bWJlciBv ZiB0cmFuc2FjdGlvbiBhbGxvd2VkIHBlciBkb21haW4sXG4iCiAiICAtQSwg LS1wZXJtLW5iIDxuYj4gICAgICBsaW1pdCB0aGUgbnVtYmVyIG9mIHBlcm1p c3Npb25zIHBlciBub2RlLFxuIgorIiAgLXcsIC0tdGltZW91dCA8d2hhdD49 PHNlY29uZHM+ICAgc2V0IHRoZSB0aW1lb3V0IGluIHNlY29uZHMgZm9yIDx3 aGF0PixcbiIKKyIgICAgICAgICAgICAgICAgICAgICAgICAgIGFsbG93ZWQg dGltZW91dCBjYW5kaWRhdGVzIGFyZTpcbiIKKyIgICAgICAgICAgICAgICAg ICAgICAgICAgIHdhdGNoLWV2ZW50OiB0aW1lIGEgd2F0Y2gtZXZlbnQgaXMg a2VwdCBwZW5kaW5nXG4iCiAiICAtUiwgLS1uby1yZWNvdmVyeSAgICAgICB0 byByZXF1ZXN0IHRoYXQgbm8gcmVjb3Zlcnkgc2hvdWxkIGJlIGF0dGVtcHRl ZCB3aGVuXG4iCiAiICAgICAgICAgICAgICAgICAgICAgICAgICB0aGUgc3Rv cmUgaXMgY29ycnVwdGVkIChkZWJ1ZyBvbmx5KSxcbiIKICIgIC1JLCAtLWlu dGVybmFsLWRiICAgICAgIHN0b3JlIGRhdGFiYXNlIGluIG1lbW9yeSwgbm90 IG9uIGRpc2tcbiIKQEAgLTIwMTUsNiArMjEwMyw3IEBAIHN0YXRpYyBzdHJ1 Y3Qgb3B0aW9uIG9wdGlvbnNbXSA9IHsKIAl7ICJ0cmFjZS1maWxlIiwgMSwg TlVMTCwgJ1QnIH0sCiAJeyAidHJhbnNhY3Rpb24iLCAxLCBOVUxMLCAndCcg fSwKIAl7ICJwZXJtLW5iIiwgMSwgTlVMTCwgJ0EnIH0sCisJeyAidGltZW91 dCIsIDEsIE5VTEwsICd3JyB9LAogCXsgIm5vLXJlY292ZXJ5IiwgMCwgTlVM TCwgJ1InIH0sCiAJeyAiaW50ZXJuYWwtZGIiLCAwLCBOVUxMLCAnSScgfSwK IAl7ICJ2ZXJib3NlIiwgMCwgTlVMTCwgJ1YnIH0sCkBAIC0yMDI2LDYgKzIx MTUsMzkgQEAgaW50IGRvbTBfZG9taWQgPSAwOwogaW50IGRvbTBfZXZlbnQg PSAwOwogaW50IHByaXZfZG9taWQgPSAwOwogCitzdGF0aWMgaW50IGdldF9v cHR2YWxfaW50KGNvbnN0IGNoYXIgKmFyZykKK3sKKwljaGFyICplbmQ7CisJ bG9uZyB2YWw7CisKKwl2YWwgPSBzdHJ0b2woYXJnLCAmZW5kLCAxMCk7CisJ aWYgKCEqYXJnIHx8ICplbmQgfHwgdmFsIDwgMCB8fCB2YWwgPiBJTlRfTUFY KQorCQliYXJmKCJpbnZhbGlkIHBhcmFtZXRlciB2YWx1ZSBcIiVzXCJcbiIs IGFyZyk7CisKKwlyZXR1cm4gdmFsOworfQorCitzdGF0aWMgYm9vbCB3aGF0 X21hdGNoZXMoY29uc3QgY2hhciAqYXJnLCBjb25zdCBjaGFyICp3aGF0KQor eworCXVuc2lnbmVkIGludCB3aGF0X2xlbiA9IHN0cmxlbih3aGF0KTsKKwor CXJldHVybiAhc3RybmNtcChhcmcsIHdoYXQsIHdoYXRfbGVuKSAmJiBhcmdb d2hhdF9sZW5dID09ICc9JzsKK30KKworc3RhdGljIHZvaWQgc2V0X3RpbWVv dXQoY29uc3QgY2hhciAqYXJnKQoreworCWNvbnN0IGNoYXIgKmVxID0gc3Ry Y2hyKGFyZywgJz0nKTsKKwlpbnQgdmFsOworCisJaWYgKCFlcSkKKwkJYmFy ZigicXVvdGFzIG11c3QgYmUgc3BlY2lmaWVkIHZpYSA8d2hhdD49PHNlY29u ZHM+XG4iKTsKKwl2YWwgPSBnZXRfb3B0dmFsX2ludChlcSArIDEpOworCWlm ICh3aGF0X21hdGNoZXMoYXJnLCAid2F0Y2gtZXZlbnQiKSkKKwkJdGltZW91 dF93YXRjaF9ldmVudF9tc2VjID0gdmFsICogMTAwMDsKKwllbHNlCisJCWJh cmYoInVua25vd24gdGltZW91dCBcIiVzXCJcbiIsIGFyZyk7Cit9CisKIGlu dCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiB7CiAJaW50IG9wdDsK QEAgLTIwMzcsNyArMjE1OSw3IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFy ICphcmd2W10pCiAJaW50IHRpbWVvdXQ7CiAKIAotCXdoaWxlICgob3B0ID0g Z2V0b3B0X2xvbmcoYXJnYywgYXJndiwgIkRFOkY6SE5QUzp0OkE6VDpSVlc6 Iiwgb3B0aW9ucywKKwl3aGlsZSAoKG9wdCA9IGdldG9wdF9sb25nKGFyZ2Ms IGFyZ3YsICJERTpGOkhOUFM6dDpBOlQ6UlZXOnc6Iiwgb3B0aW9ucywKIAkJ CQkgIE5VTEwpKSAhPSAtMSkgewogCQlzd2l0Y2ggKG9wdCkgewogCQljYXNl ICdEJzoKQEAgLTIwODIsNiArMjIwNCw5IEBAIGludCBtYWluKGludCBhcmdj LCBjaGFyICphcmd2W10pCiAJCWNhc2UgJ0EnOgogCQkJcXVvdGFfbmJfcGVy bXNfcGVyX25vZGUgPSBzdHJ0b2wob3B0YXJnLCBOVUxMLCAxMCk7CiAJCQli cmVhazsKKwkJY2FzZSAndyc6CisJCQlzZXRfdGltZW91dChvcHRhcmcpOwor CQkJYnJlYWs7CiAJCWNhc2UgJ2UnOgogCQkJZG9tMF9ldmVudCA9IHN0cnRv bChvcHRhcmcsIE5VTEwsIDEwKTsKIAkJCWJyZWFrOwpkaWZmIC0tZ2l0IGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmgKaW5kZXggODNkNDk2OTNmYzE5Li4zMTEy YzExODExZTUgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUu aApAQCAtMjcsNiArMjcsNyBAQAogI2luY2x1ZGUgPGRpcmVudC5oPgogI2lu Y2x1ZGUgPHN0ZGJvb2wuaD4KICNpbmNsdWRlIDxzdGRpbnQuaD4KKyNpbmNs dWRlIDx0aW1lLmg+CiAjaW5jbHVkZSA8ZXJybm8uaD4KIAogI2luY2x1ZGUg InhlbnN0b3JlX2xpYi5oIgpAQCAtNTYsNiArNTcsOCBAQCBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YQogCQljaGFyIHJhd1tzaXplb2Yoc3RydWN0IHhzZF9zb2Nr bXNnKV07CiAJfSBoZHI7CiAKKwl1aW50NjRfdCB0aW1lb3V0X21zZWM7CisK IAkvKiBUaGUgYWN0dWFsIGRhdGEuICovCiAJY2hhciAqYnVmZmVyOwogCWNo YXIgZGVmYXVsdF9idWZmZXJbREVGQVVMVF9CVUZGRVJfU0laRV07CkBAIC04 OCw2ICs5MSw3IEBAIHN0cnVjdCBjb25uZWN0aW9uCiAKIAkvKiBCdWZmZXJl ZCBvdXRwdXQgZGF0YSAqLwogCXN0cnVjdCBsaXN0X2hlYWQgb3V0X2xpc3Q7 CisJdWludDY0X3QgdGltZW91dF9tc2VjOwogCiAJLyogVHJhbnNhY3Rpb24g Y29udGV4dCBmb3IgY3VycmVudCByZXF1ZXN0IChOVUxMIGlmIG5vbmUpLiAq LwogCXN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnNhY3Rpb247CkBAIC0xOTks NiArMjAzLDggQEAgZXh0ZXJuIGludCBkb20wX2V2ZW50OwogZXh0ZXJuIGlu dCBwcml2X2RvbWlkOwogZXh0ZXJuIGludCBxdW90YV9uYl9lbnRyeV9wZXJf ZG9tYWluOwogCitleHRlcm4gdW5zaWduZWQgaW50IHRpbWVvdXRfd2F0Y2hf ZXZlbnRfbXNlYzsKKwogLyogTWFwIHRoZSBrZXJuZWwncyB4ZW5zdG9yZSBw YWdlLiAqLwogdm9pZCAqeGVuYnVzX21hcCh2b2lkKTsKIHZvaWQgdW5tYXBf eGVuYnVzKHZvaWQgKmludGVyZmFjZSk7Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-05.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-05.patch" Content-Transfer-Encoding: base64 RnJvbSA2MTAyZWM0ZDIxNTM1OWRiYzk0MzNiYzJiZmJiZjYzZTI0ZjkxNzYx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxpbWl0IG91 dHN0YW5kaW5nIHJlcXVlc3RzCgpBZGQgYW5vdGhlciBxdW90YSBmb3IgbGlt aXRpbmcgdGhlIG51bWJlciBvZiBvdXRzdGFuZGluZyByZXF1ZXN0cyBvZiBh Cmd1ZXN0LiBBcyB0aGUgd2F5IHRvIHNwZWNpZnkgcXVvdGFzIG9uIHRoZSBj b21tYW5kIGxpbmUgaXMgYmVjb21pbmcKcmF0aGVyIG5hc3R5LCBzd2l0Y2gg dG8gYSBuZXcgc2NoZW1lIHVzaW5nIFstLXF1b3RhfC1RXSA8d2hhdD49PHZh bD4KYWxsb3dpbmcgdG8gYWRkIG1vcmUgcXVvdGFzIGluIGZ1dHVyZSBlYXNp bHkuCgpTZXQgdGhlIGRlZmF1bHQgdmFsdWUgdG8gMjAgKGJhc2ljYWxseSBh IHJhbmRvbSB2YWx1ZSBub3Qgc2VlbWluZyB0bwpiZSB0b28gaGlnaCBvciB0 b28gbG93KS4KCkEgcmVxdWVzdCBpcyBzYWlkIHRvIGJlIG91dHN0YW5kaW5n IGlmIGFueSBtZXNzYWdlIGdlbmVyYXRlZCBieSB0aGlzCnJlcXVlc3QgKHRo ZSBkaXJlY3QgcmVzcG9uc2UgcGx1cyBwb3RlbnRpYWwgd2F0Y2ggZXZlbnRz KSBpcyBub3QgeWV0CmNvbXBsZXRlbHkgc3RvcmVkIGludG8gYSByaW5nIGJ1 ZmZlci4gVGhlIGluaXRpYWwgd2F0Y2ggZXZlbnQgc2VudCBhcwphIHJlc3Vs dCBvZiByZWdpc3RlcmluZyBhIHdhdGNoIGlzIGFuIGV4Y2VwdGlvbi4KCk5v dGUgdGhhdCBhY3Jvc3MgYSBsaXZlIHVwZGF0ZSB0aGUgcmVsYXRpb24gdG8g YnVmZmVyZWQgd2F0Y2ggZXZlbnRzCmZvciBvdGhlciBkb21haW5zIGlzIGxv c3QuCgpVc2UgdGFsbG9jX3plcm8oKSBmb3IgYWxsb2NhdGluZyB0aGUgZG9t YWluIHN0cnVjdHVyZSBpbiBvcmRlciB0byBoYXZlCmFsbCBwZXItZG9tYWlu IHF1b3RhIHplcm9lZCBpbml0aWFsbHkuCgpUaGlzIGlzIHBhcnQgb2YgWFNB LTMyNiAvIENWRS0yMDIyLTQyMzEyLgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKaW5kZXggOTg4MzdlZjJlOWNmLi4yZWQ5MWQxMzI5 N2IgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAt MTA1LDYgKzEwNSw3IEBAIGludCBxdW90YV9uYl93YXRjaF9wZXJfZG9tYWlu ID0gMTI4OwogaW50IHF1b3RhX21heF9lbnRyeV9zaXplID0gMjA0ODsgLyog MksgKi8KIGludCBxdW90YV9tYXhfdHJhbnNhY3Rpb24gPSAxMDsKIGludCBx dW90YV9uYl9wZXJtc19wZXJfbm9kZSA9IDU7CitpbnQgcXVvdGFfcmVxX291 dHN0YW5kaW5nID0gMjA7CiAKIHVuc2lnbmVkIGludCB0aW1lb3V0X3dhdGNo X2V2ZW50X21zZWMgPSAyMDAwMDsKIApAQCAtMjIwLDEyICsyMjEsMjQgQEAg c3RhdGljIHVpbnQ2NF90IGdldF9ub3dfbXNlYyh2b2lkKQogCXJldHVybiBu b3dfdHMudHZfc2VjICogMTAwMCArIG5vd190cy50dl9uc2VjIC8gMTAwMDAw MDsKIH0KIAorLyoKKyAqIFJlbW92ZSBhIHN0cnVjdCBidWZmZXJlZF9kYXRh IGZyb20gdGhlIGxpc3Qgb2Ygb3V0Z29pbmcgZGF0YS4KKyAqIEEgc3RydWN0 IGJ1ZmZlcmVkX2RhdGEgcmVsYXRlZCB0byBhIHJlcXVlc3QgaGF2aW5nIGNh dXNlZCB3YXRjaCBldmVudHMgdG8gYmUKKyAqIHNlbnQgaXMga2VwdCB1bnRp bCBhbGwgdGhvc2UgZXZlbnRzIGhhdmUgYmVlbiB3cml0dGVuIG91dC4KKyAq IEVhY2ggd2F0Y2ggZXZlbnQgaXMgcmVmZXJlbmNpbmcgdGhlIHJlbGF0ZWQg cmVxdWVzdCB2aWEgcGVuZC5yZXEsIHdoaWxlIHRoZQorICogbnVtYmVyIG9m IHdhdGNoIGV2ZW50cyBjYXVzZWQgYnkgYSByZXF1ZXN0IGlzIGtlcHQgaW4g cGVuZC5yZWYuZXZlbnRfY250CisgKiAodGhvc2UgdHdvIGNhc2VzIGFyZSBt dXR1YWxseSBleGNsdXNpdmUsIHNvIHRoZSB0d28gZmllbGRzIGNhbiBzaGFy ZSBtZW1vcnkKKyAqIHZpYSBhIHVuaW9uKS4KKyAqIFRoZSBzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSBpcyBmcmVlZCBvbmx5IGlmIG5vIHJlbGF0ZWQgd2F0Y2gg ZXZlbnQgaXMKKyAqIHJlZmVyZW5jaW5nIGl0LiBUaGUgcmVsYXRlZCByZXR1 cm4gZGF0YSBjYW4gYmUgZnJlZWQgcmlnaHQgYXdheS4KKyAqLwogc3RhdGlj IHZvaWQgZnJlZV9idWZmZXJlZF9kYXRhKHN0cnVjdCBidWZmZXJlZF9kYXRh ICpvdXQsCiAJCQkgICAgICAgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCiB7 CiAJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKnJlcTsKIAogCWxpc3RfZGVsKCZv dXQtPmxpc3QpOworCW91dC0+b25fb3V0X2xpc3QgPSBmYWxzZTsKIAogCS8q CiAJICogVXBkYXRlIGNvbm4tPnRpbWVvdXRfbXNlYyB3aXRoIHRoZSBuZXh0 IGZvdW5kIHRpbWVvdXQgdmFsdWUgaW4gdGhlCkBAIC0yNDEsNiArMjU0LDMw IEBAIHN0YXRpYyB2b2lkIGZyZWVfYnVmZmVyZWRfZGF0YShzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqb3V0LAogCQl9CiAJfQogCisJaWYgKG91dC0+aGRyLm1z Zy50eXBlID09IFhTX1dBVENIX0VWRU5UKSB7CisJCXJlcSA9IG91dC0+cGVu ZC5yZXE7CisJCWlmIChyZXEpIHsKKwkJCXJlcS0+cGVuZC5yZWYuZXZlbnRf Y250LS07CisJCQlpZiAoIXJlcS0+cGVuZC5yZWYuZXZlbnRfY250ICYmICFy ZXEtPm9uX291dF9saXN0KSB7CisJCQkJaWYgKHJlcS0+b25fcmVmX2xpc3Qp IHsKKwkJCQkJZG9tYWluX291dHN0YW5kaW5nX2RvbWlkX2RlYygKKwkJCQkJ CXJlcS0+cGVuZC5yZWYuZG9taWQpOworCQkJCQlsaXN0X2RlbCgmcmVxLT5s aXN0KTsKKwkJCQl9CisJCQkJdGFsbG9jX2ZyZWUocmVxKTsKKwkJCX0KKwkJ fQorCX0gZWxzZSBpZiAob3V0LT5wZW5kLnJlZi5ldmVudF9jbnQpIHsKKwkJ LyogSGFuZyBvdXQgb2ZmIGZyb20gY29ubi4gKi8KKwkJdGFsbG9jX3N0ZWFs KE5VTEwsIG91dCk7CisJCWlmIChvdXQtPmJ1ZmZlciAhPSBvdXQtPmRlZmF1 bHRfYnVmZmVyKQorCQkJdGFsbG9jX2ZyZWUob3V0LT5idWZmZXIpOworCQls aXN0X2FkZCgmb3V0LT5saXN0LCAmY29ubi0+cmVmX2xpc3QpOworCQlvdXQt Pm9uX3JlZl9saXN0ID0gdHJ1ZTsKKwkJcmV0dXJuOworCX0gZWxzZQorCQlk b21haW5fb3V0c3RhbmRpbmdfZGVjKGNvbm4pOworCiAJdGFsbG9jX2ZyZWUo b3V0KTsKIH0KIApAQCAtMzQ5LDYgKzM4Niw3IEBAIHN0YXRpYyBib29sIHdy aXRlX21lc3NhZ2VzKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQogc3RhdGlj IGludCBkZXN0cm95X2Nvbm4odm9pZCAqX2Nvbm4pCiB7CiAJc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4gPSBfY29ubjsKKwlzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSAqcmVxOwogCiAJLyogRmx1c2ggb3V0Z29pbmcgaWYgcG9zc2libGUsIGJ1 dCBkb24ndCBibG9jay4gKi8KIAlpZiAoIWNvbm4tPmRvbWFpbikgewpAQCAt MzYyLDYgKzQwMCwxMSBAQCBzdGF0aWMgaW50IGRlc3Ryb3lfY29ubih2b2lk ICpfY29ubikKIAkJCQlicmVhazsKIAkJY2xvc2UoY29ubi0+ZmQpOwogCX0K KworCWNvbm5fZnJlZV9idWZmZXJlZF9kYXRhKGNvbm4pOworCWxpc3RfZm9y X2VhY2hfZW50cnkocmVxLCAmY29ubi0+cmVmX2xpc3QsIGxpc3QpCisJCXJl cS0+b25fcmVmX2xpc3QgPSBmYWxzZTsKKwogICAgICAgICBpZiAoY29ubi0+ dGFyZ2V0KQogICAgICAgICAgICAgICAgIHRhbGxvY191bmxpbmsoY29ubiwg Y29ubi0+dGFyZ2V0KTsKIAlsaXN0X2RlbCgmY29ubi0+bGlzdCk7CkBAIC04 MDAsNiArODQzLDggQEAgdm9pZCBzZW5kX3JlcGx5KHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSwKIAogCS8q IFF1ZXVlIGZvciBsYXRlciB0cmFuc21pc3Npb24uICovCiAJbGlzdF9hZGRf dGFpbCgmYmRhdGEtPmxpc3QsICZjb25uLT5vdXRfbGlzdCk7CisJYmRhdGEt Pm9uX291dF9saXN0ID0gdHJ1ZTsKKwlkb21haW5fb3V0c3RhbmRpbmdfaW5j KGNvbm4pOwogfQogCiAvKgpAQCAtODA3LDcgKzg1Miw4IEBAIHZvaWQgc2Vu ZF9yZXBseShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgZW51bSB4c2Rfc29j a21zZ190eXBlIHR5cGUsCiAgKiBBcyB0aGlzIGlzIG5vdCBkaXJlY3RseSBy ZWxhdGVkIHRvIHRoZSBjdXJyZW50IGNvbW1hbmQsIGVycm9ycyBjYW4ndCBi ZQogICogcmVwb3J0ZWQuCiAgKi8KLXZvaWQgc2VuZF9ldmVudChzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgY29uc3QgY2hhciAqcGF0aCwgY29uc3QgY2hh ciAqdG9rZW4pCit2b2lkIHNlbmRfZXZlbnQoc3RydWN0IGJ1ZmZlcmVkX2Rh dGEgKnJlcSwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCWNvbnN0IGNo YXIgKnBhdGgsIGNvbnN0IGNoYXIgKnRva2VuKQogewogCXN0cnVjdCBidWZm ZXJlZF9kYXRhICpiZGF0YTsKIAl1bnNpZ25lZCBpbnQgbGVuOwpAQCAtODM3 LDggKzg4MywxMyBAQCB2b2lkIHNlbmRfZXZlbnQoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIGNvbnN0IGNoYXIgKnBhdGgsIGNvbnN0IGNoYXIgKnRva2Vu KQogCQkJY29ubi0+dGltZW91dF9tc2VjID0gYmRhdGEtPnRpbWVvdXRfbXNl YzsKIAl9CiAKKwliZGF0YS0+cGVuZC5yZXEgPSByZXE7CisJaWYgKHJlcSkK KwkJcmVxLT5wZW5kLnJlZi5ldmVudF9jbnQrKzsKKwogCS8qIFF1ZXVlIGZv ciBsYXRlciB0cmFuc21pc3Npb24uICovCiAJbGlzdF9hZGRfdGFpbCgmYmRh dGEtPmxpc3QsICZjb25uLT5vdXRfbGlzdCk7CisJYmRhdGEtPm9uX291dF9s aXN0ID0gdHJ1ZTsKIH0KIAogLyogU29tZSByb3V0aW5lcyAod3JpdGUsIG1r ZGlyLCBldGMpIGp1c3QgbmVlZCBhIG5vbi1lcnJvciByZXR1cm4gKi8KQEAg LTE1NzQsNiArMTYyNSw3IEBAIHN0YXRpYyB2b2lkIGhhbmRsZV9pbnB1dChz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubikKIAkJCXJldHVybjsKIAl9CiAJaW4g PSBjb25uLT5pbjsKKwlpbi0+cGVuZC5yZWYuZG9taWQgPSBjb25uLT5pZDsK IAogCS8qIE5vdCBmaW5pc2hlZCBoZWFkZXIgeWV0PyAqLwogCWlmIChpbi0+ aW5oZHIpIHsKQEAgLTE2NDQsNiArMTY5Niw3IEBAIHN0cnVjdCBjb25uZWN0 aW9uICpuZXdfY29ubmVjdGlvbihjb25ud3JpdGVmbl90ICp3cml0ZSwgY29u bnJlYWRmbl90ICpyZWFkKQogCW5ldy0+aXNfaWdub3JlZCA9IGZhbHNlOwog CW5ldy0+dHJhbnNhY3Rpb25fc3RhcnRlZCA9IDA7CiAJSU5JVF9MSVNUX0hF QUQoJm5ldy0+b3V0X2xpc3QpOworCUlOSVRfTElTVF9IRUFEKCZuZXctPnJl Zl9saXN0KTsKIAlJTklUX0xJU1RfSEVBRCgmbmV3LT53YXRjaGVzKTsKIAlJ TklUX0xJU1RfSEVBRCgmbmV3LT50cmFuc2FjdGlvbl9saXN0KTsKIApAQCAt MjA3OSw2ICsyMTMyLDkgQEAgc3RhdGljIHZvaWQgdXNhZ2Uodm9pZCkKICIg IC1XLCAtLXdhdGNoLW5iIDxuYj4gICAgIGxpbWl0IHRoZSBudW1iZXIgb2Yg d2F0Y2hlcyBwZXIgZG9tYWluLFxuIgogIiAgLXQsIC0tdHJhbnNhY3Rpb24g PG5iPiAgbGltaXQgdGhlIG51bWJlciBvZiB0cmFuc2FjdGlvbiBhbGxvd2Vk IHBlciBkb21haW4sXG4iCiAiICAtQSwgLS1wZXJtLW5iIDxuYj4gICAgICBs aW1pdCB0aGUgbnVtYmVyIG9mIHBlcm1pc3Npb25zIHBlciBub2RlLFxuIgor IiAgLVEsIC0tcXVvdGEgPHdoYXQ+PTxuYj4gc2V0IHRoZSBxdW90YSA8d2hh dD4gdG8gdGhlIHZhbHVlIDxuYj4sIGFsbG93ZWRcbiIKKyIgICAgICAgICAg ICAgICAgICAgICAgICAgIHF1b3RhcyBhcmU6XG4iCisiICAgICAgICAgICAg ICAgICAgICAgICAgICBvdXRzdGFuZGluZzogbnVtYmVyIG9mIG91dHN0YW5k aW5nIHJlcXVlc3RzXG4iCiAiICAtdywgLS10aW1lb3V0IDx3aGF0Pj08c2Vj b25kcz4gICBzZXQgdGhlIHRpbWVvdXQgaW4gc2Vjb25kcyBmb3IgPHdoYXQ+ LFxuIgogIiAgICAgICAgICAgICAgICAgICAgICAgICAgYWxsb3dlZCB0aW1l b3V0IGNhbmRpZGF0ZXMgYXJlOlxuIgogIiAgICAgICAgICAgICAgICAgICAg ICAgICAgd2F0Y2gtZXZlbnQ6IHRpbWUgYSB3YXRjaC1ldmVudCBpcyBrZXB0 IHBlbmRpbmdcbiIKQEAgLTIxMDMsNiArMjE1OSw3IEBAIHN0YXRpYyBzdHJ1 Y3Qgb3B0aW9uIG9wdGlvbnNbXSA9IHsKIAl7ICJ0cmFjZS1maWxlIiwgMSwg TlVMTCwgJ1QnIH0sCiAJeyAidHJhbnNhY3Rpb24iLCAxLCBOVUxMLCAndCcg fSwKIAl7ICJwZXJtLW5iIiwgMSwgTlVMTCwgJ0EnIH0sCisJeyAicXVvdGEi LCAxLCBOVUxMLCAnUScgfSwKIAl7ICJ0aW1lb3V0IiwgMSwgTlVMTCwgJ3cn IH0sCiAJeyAibm8tcmVjb3ZlcnkiLCAwLCBOVUxMLCAnUicgfSwKIAl7ICJp bnRlcm5hbC1kYiIsIDAsIE5VTEwsICdJJyB9LApAQCAtMjE0OCw2ICsyMjA1 LDIwIEBAIHN0YXRpYyB2b2lkIHNldF90aW1lb3V0KGNvbnN0IGNoYXIgKmFy ZykKIAkJYmFyZigidW5rbm93biB0aW1lb3V0IFwiJXNcIlxuIiwgYXJnKTsK IH0KIAorc3RhdGljIHZvaWQgc2V0X3F1b3RhKGNvbnN0IGNoYXIgKmFyZykK K3sKKwljb25zdCBjaGFyICplcSA9IHN0cmNocihhcmcsICc9Jyk7CisJaW50 IHZhbDsKKworCWlmICghZXEpCisJCWJhcmYoInF1b3RhcyBtdXN0IGJlIHNw ZWNpZmllZCB2aWEgPHdoYXQ+PTxuYj5cbiIpOworCXZhbCA9IGdldF9vcHR2 YWxfaW50KGVxICsgMSk7CisJaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJvdXRz dGFuZGluZyIpKQorCQlxdW90YV9yZXFfb3V0c3RhbmRpbmcgPSB2YWw7CisJ ZWxzZQorCQliYXJmKCJ1bmtub3duIHF1b3RhIFwiJXNcIlxuIiwgYXJnKTsK K30KKwogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIHsKIAlp bnQgb3B0OwpAQCAtMjE1OSw3ICsyMjMwLDcgQEAgaW50IG1haW4oaW50IGFy Z2MsIGNoYXIgKmFyZ3ZbXSkKIAlpbnQgdGltZW91dDsKIAogCi0Jd2hpbGUg KChvcHQgPSBnZXRvcHRfbG9uZyhhcmdjLCBhcmd2LCAiREU6RjpITlBTOnQ6 QTpUOlJWVzp3OiIsIG9wdGlvbnMsCisJd2hpbGUgKChvcHQgPSBnZXRvcHRf bG9uZyhhcmdjLCBhcmd2LCAiREU6RjpITlBTOnQ6QTpROlQ6UlZXOnc6Iiwg b3B0aW9ucywKIAkJCQkgIE5VTEwpKSAhPSAtMSkgewogCQlzd2l0Y2ggKG9w dCkgewogCQljYXNlICdEJzoKQEAgLTIyMDQsNiArMjI3NSw5IEBAIGludCBt YWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAJCWNhc2UgJ0EnOgogCQkJ cXVvdGFfbmJfcGVybXNfcGVyX25vZGUgPSBzdHJ0b2wob3B0YXJnLCBOVUxM LCAxMCk7CiAJCQlicmVhazsKKwkJY2FzZSAnUSc6CisJCQlzZXRfcXVvdGEo b3B0YXJnKTsKKwkJCWJyZWFrOwogCQljYXNlICd3JzoKIAkJCXNldF90aW1l b3V0KG9wdGFyZyk7CiAJCQlicmVhazsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmggYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfY29yZS5oCmluZGV4IDMxMTJjMTE4MTFlNS4uZWRlYWE5NmRkMTBi IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5o CisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKQEAgLTQ1 LDYgKzQ1LDggQEAgdHlwZWRlZiBpbnQzMl90IHdybF9jcmVkaXR0Owogc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEKIHsKIAlzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7 CisJYm9vbCBvbl9vdXRfbGlzdDsKKwlib29sIG9uX3JlZl9saXN0OwogCiAJ LyogQXJlIHdlIHN0aWxsIGRvaW5nIHRoZSBoZWFkZXI/ICovCiAJYm9vbCBp bmhkcjsKQEAgLTUyLDYgKzU0LDE3IEBAIHN0cnVjdCBidWZmZXJlZF9kYXRh CiAJLyogSG93IGZhciBhcmUgd2U/ICovCiAJdW5zaWduZWQgaW50IHVzZWQ7 CiAKKwkvKiBPdXRzdGFuZGluZyByZXF1ZXN0IGFjY291bnRpbmcuICovCisJ dW5pb24geworCQkvKiByZWYgaXMgYmVpbmcgdXNlZCBmb3IgcmVxdWVzdHMu ICovCisJCXN0cnVjdCB7CisJCQl1bnNpZ25lZCBpbnQgZXZlbnRfY250OyAv KiAjIG9mIG91dHN0YW5kaW5nIGV2ZW50cy4gKi8KKwkJCXVuc2lnbmVkIGlu dCBkb21pZDsgICAgIC8qIGRvbWlkIG9mIHJlcXVlc3QuICovCisJCX0gcmVm OworCQkvKiByZXEgaXMgYmVpbmcgdXNlZCBmb3Igd2F0Y2ggZXZlbnRzLiAq LworCQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqcmVxOyAgICAgIC8qIHJlcXVl c3QgY2F1c2luZyBldmVudC4gKi8KKwl9IHBlbmQ7CisKIAl1bmlvbiB7CiAJ CXN0cnVjdCB4c2Rfc29ja21zZyBtc2c7CiAJCWNoYXIgcmF3W3NpemVvZihz dHJ1Y3QgeHNkX3NvY2ttc2cpXTsKQEAgLTkzLDYgKzEwNiw5IEBAIHN0cnVj dCBjb25uZWN0aW9uCiAJc3RydWN0IGxpc3RfaGVhZCBvdXRfbGlzdDsKIAl1 aW50NjRfdCB0aW1lb3V0X21zZWM7CiAKKwkvKiBSZWZlcmVuY2VkIHJlcXVl c3RzIG5vIGxvbmdlciBwZW5kaW5nLiAqLworCXN0cnVjdCBsaXN0X2hlYWQg cmVmX2xpc3Q7CisKIAkvKiBUcmFuc2FjdGlvbiBjb250ZXh0IGZvciBjdXJy ZW50IHJlcXVlc3QgKE5VTEwgaWYgbm9uZSkuICovCiAJc3RydWN0IHRyYW5z YWN0aW9uICp0cmFuc2FjdGlvbjsKIApAQCAtMTU0LDcgKzE3MCw4IEBAIHVu c2lnbmVkIGludCBnZXRfc3RyaW5ncyhzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAq ZGF0YSwKIAogdm9pZCBzZW5kX3JlcGx5KHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSwKIAkJY29uc3Qgdm9p ZCAqZGF0YSwgdW5zaWduZWQgaW50IGxlbik7Ci12b2lkIHNlbmRfZXZlbnQo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IGNoYXIgKnBhdGgsIGNv bnN0IGNoYXIgKnRva2VuKTsKK3ZvaWQgc2VuZF9ldmVudChzdHJ1Y3QgYnVm ZmVyZWRfZGF0YSAqcmVxLCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJ Y29uc3QgY2hhciAqcGF0aCwgY29uc3QgY2hhciAqdG9rZW4pOwogCiAvKiBT b21lIHJvdXRpbmVzICh3cml0ZSwgbWtkaXIsIGV0YykganVzdCBuZWVkIGEg bm9uLWVycm9yIHJldHVybiAqLwogdm9pZCBzZW5kX2FjayhzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwgZW51bSB4c2Rfc29ja21zZ190eXBlIHR5cGUpOwpA QCAtMjAyLDYgKzIxOSw3IEBAIGV4dGVybiBpbnQgZG9tMF9kb21pZDsKIGV4 dGVybiBpbnQgZG9tMF9ldmVudDsKIGV4dGVybiBpbnQgcHJpdl9kb21pZDsK IGV4dGVybiBpbnQgcXVvdGFfbmJfZW50cnlfcGVyX2RvbWFpbjsKK2V4dGVy biBpbnQgcXVvdGFfcmVxX291dHN0YW5kaW5nOwogCiBleHRlcm4gdW5zaWdu ZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIApkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IDNiZmYzMjJkMDI0 ZC4uMmRkODBlYjFhN2JiIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2RvbWFpbi5jCkBAIC04Miw2ICs4Miw5IEBAIHN0cnVjdCBkb21haW4K IAkvKiBudW1iZXIgb2Ygd2F0Y2ggZm9yIHRoaXMgZG9tYWluICovCiAJaW50 IG5id2F0Y2g7CiAKKwkvKiBOdW1iZXIgb2Ygb3V0c3RhbmRpbmcgcmVxdWVz dHMuICovCisJaW50IG5ib3V0c3RhbmRpbmc7CisKIAkvKiB3cml0ZSByYXRl IGxpbWl0ICovCiAJd3JsX2NyZWRpdHQgd3JsX2NyZWRpdDsgLyogWyAtd3Js X2NvbmZpZ193cml0ZWNvc3QsICtfZGJ1cnN0IF0gKi8KIAlzdHJ1Y3Qgd3Js X3RpbWVzdGFtcHQgd3JsX3RpbWVzdGFtcDsKQEAgLTI4NCw4ICsyODcsMTIg QEAgYm9vbCBkb21haW5fY2FuX3JlYWQoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4pCiB7CiAJc3RydWN0IHhlbnN0b3JlX2RvbWFpbl9pbnRlcmZhY2UgKmlu dGYgPSBjb25uLT5kb21haW4tPmludGVyZmFjZTsKIAotCWlmIChkb21haW5f aXNfdW5wcml2aWxlZ2VkKGNvbm4pICYmIGNvbm4tPmRvbWFpbi0+d3JsX2Ny ZWRpdCA8IDApCi0JCXJldHVybiBmYWxzZTsKKwlpZiAoZG9tYWluX2lzX3Vu cHJpdmlsZWdlZChjb25uKSkgeworCQlpZiAoY29ubi0+ZG9tYWluLT53cmxf Y3JlZGl0IDwgMCkKKwkJCXJldHVybiBmYWxzZTsKKwkJaWYgKGNvbm4tPmRv bWFpbi0+bmJvdXRzdGFuZGluZyA+PSBxdW90YV9yZXFfb3V0c3RhbmRpbmcp CisJCQlyZXR1cm4gZmFsc2U7CisJfQogCiAJaWYgKGNvbm4tPmlzX2lnbm9y ZWQpCiAJCXJldHVybiBmYWxzZTsKQEAgLTMzNCw3ICszNDEsNyBAQCBzdGF0 aWMgc3RydWN0IGRvbWFpbiAqYWxsb2NfZG9tYWluKHZvaWQgKmNvbnRleHQs IHVuc2lnbmVkIGludCBkb21pZCkKIHsKIAlzdHJ1Y3QgZG9tYWluICpkb21h aW47CiAKLQlkb21haW4gPSB0YWxsb2MoY29udGV4dCwgc3RydWN0IGRvbWFp bik7CisJZG9tYWluID0gdGFsbG9jX3plcm8oY29udGV4dCwgc3RydWN0IGRv bWFpbik7CiAJaWYgKCFkb21haW4pIHsKIAkJZXJybm8gPSBFTk9NRU07CiAJ CXJldHVybiBOVUxMOwpAQCAtMzgzLDggKzM5MCw2IEBAIHN0YXRpYyBpbnQg bmV3X2RvbWFpbihzdHJ1Y3QgZG9tYWluICpkb21haW4sIGludCBwb3J0KQog CWRvbWFpbi0+Y29ubi0+aWQgPSBkb21haW4tPmRvbWlkOwogCiAJZG9tYWlu LT5yZW1vdGVfcG9ydCA9IHBvcnQ7Ci0JZG9tYWluLT5uYmVudHJ5ID0gMDsK LQlkb21haW4tPm5id2F0Y2ggPSAwOwogCiAJcmV0dXJuIDA7CiB9CkBAIC05 MjIsNiArOTI3LDI4IEBAIGludCBkb21haW5fd2F0Y2goc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pCiAJCTogMDsKIH0KIAordm9pZCBkb21haW5fb3V0c3Rh bmRpbmdfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQoreworCWlmICgh Y29ubiB8fCAhY29ubi0+ZG9tYWluKQorCQlyZXR1cm47CisJY29ubi0+ZG9t YWluLT5uYm91dHN0YW5kaW5nKys7Cit9CisKK3ZvaWQgZG9tYWluX291dHN0 YW5kaW5nX2RlYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubikKK3sKKwlpZiAo IWNvbm4gfHwgIWNvbm4tPmRvbWFpbikKKwkJcmV0dXJuOworCWNvbm4tPmRv bWFpbi0+bmJvdXRzdGFuZGluZy0tOworfQorCit2b2lkIGRvbWFpbl9vdXRz dGFuZGluZ19kb21pZF9kZWModW5zaWduZWQgaW50IGRvbWlkKQoreworCXN0 cnVjdCBkb21haW4gKmQgPSBmaW5kX2RvbWFpbl9ieV9kb21pZChkb21pZCk7 CisKKwlpZiAoZCkKKwkJZC0+bmJvdXRzdGFuZGluZy0tOworfQorCiBzdGF0 aWMgd3JsX2NyZWRpdHQgd3JsX2NvbmZpZ193cml0ZWNvc3QgICAgICA9IFdS TF9GQUNUT1I7CiBzdGF0aWMgd3JsX2NyZWRpdHQgd3JsX2NvbmZpZ19yYXRl ICAgICAgICAgICA9IFdSTF9SQVRFICAgKiBXUkxfRkFDVE9SOwogc3RhdGlj IHdybF9jcmVkaXR0IHdybF9jb25maWdfZGJ1cnN0ICAgICAgICAgPSBXUkxf REJVUlNUICogV1JMX0ZBQ1RPUjsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9kb21haW4uaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9kb21haW4uaAppbmRleCA1ZTAwMDg3MjA2YzcuLjRiZmYyZTY1NWI5 YiAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFp bi5oCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaApA QCAtNjcsNiArNjcsOSBAQCBpbnQgZG9tYWluX2VudHJ5KHN0cnVjdCBjb25u ZWN0aW9uICpjb25uKTsKIHZvaWQgZG9tYWluX3dhdGNoX2luYyhzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubik7CiB2b2lkIGRvbWFpbl93YXRjaF9kZWMoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4pOwogaW50IGRvbWFpbl93YXRjaChzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubik7Cit2b2lkIGRvbWFpbl9vdXRzdGFuZGlu Z19pbmMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pOwordm9pZCBkb21haW5f b3V0c3RhbmRpbmdfZGVjKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsKK3Zv aWQgZG9tYWluX291dHN0YW5kaW5nX2RvbWlkX2RlYyh1bnNpZ25lZCBpbnQg ZG9taWQpOwogCiAvKiBTcGVjaWFsIG5vZGUgcGVybWlzc2lvbiBoYW5kbGlu Zy4gKi8KIGludCBzZXRfcGVybXNfc3BlY2lhbChzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwgY29uc3QgY2hhciAqbmFtZSwKZGlmZiAtLWdpdCBhL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3dhdGNoLmMKaW5kZXggMmY5MzY3NzY3ZTQ0Li5jNTBjMDU3 NWYwZjEgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93 YXRjaC5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5j CkBAIC0xNDIsNiArMTQyLDcgQEAgdm9pZCBmaXJlX3dhdGNoZXMoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwgY29uc3QgY2hh ciAqbmFtZSwKIAkJICBzdHJ1Y3Qgbm9kZSAqbm9kZSwgYm9vbCBleGFjdCwg c3RydWN0IG5vZGVfcGVybXMgKnBlcm1zKQogewogCXN0cnVjdCBjb25uZWN0 aW9uICppOworCXN0cnVjdCBidWZmZXJlZF9kYXRhICpyZXE7CiAJc3RydWN0 IHdhdGNoICp3YXRjaDsKIAogCS8qIER1cmluZyB0cmFuc2FjdGlvbnMsIGRv bid0IGZpcmUgd2F0Y2hlcywgYnV0IHF1ZXVlIHRoZW0uICovCkBAIC0xNTAs NiArMTUxLDggQEAgdm9pZCBmaXJlX3dhdGNoZXMoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwgY29uc3QgY2hhciAqbmFtZSwK IAkJcmV0dXJuOwogCX0KIAorCXJlcSA9IGRvbWFpbl9pc191bnByaXZpbGVn ZWQoY29ubikgPyBjb25uLT5pbiA6IE5VTEw7CisKIAkvKiBDcmVhdGUgYW4g ZXZlbnQgZm9yIGVhY2ggd2F0Y2guICovCiAJbGlzdF9mb3JfZWFjaF9lbnRy eShpLCAmY29ubmVjdGlvbnMsIGxpc3QpIHsKIAkJLyogaW50cm9kdWNlL3Jl bGVhc2UgZG9tYWluIHdhdGNoZXMgKi8KQEAgLTE2NCwxMiArMTY3LDEyIEBA IHZvaWQgZmlyZV93YXRjaGVzKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBj b25zdCB2b2lkICpjdHgsIGNvbnN0IGNoYXIgKm5hbWUsCiAJCWxpc3RfZm9y X2VhY2hfZW50cnkod2F0Y2gsICZpLT53YXRjaGVzLCBsaXN0KSB7CiAJCQlp ZiAoZXhhY3QpIHsKIAkJCQlpZiAoc3RyZXEobmFtZSwgd2F0Y2gtPm5vZGUp KQotCQkJCQlzZW5kX2V2ZW50KGksCisJCQkJCXNlbmRfZXZlbnQocmVxLCBp LAogCQkJCQkJICAgZ2V0X3dhdGNoX3BhdGgod2F0Y2gsIG5hbWUpLAogCQkJ CQkJICAgd2F0Y2gtPnRva2VuKTsKIAkJCX0gZWxzZSB7CiAJCQkJaWYgKGlz X2NoaWxkKG5hbWUsIHdhdGNoLT5ub2RlKSkKLQkJCQkJc2VuZF9ldmVudChp LAorCQkJCQlzZW5kX2V2ZW50KHJlcSwgaSwKIAkJCQkJCSAgIGdldF93YXRj aF9wYXRoKHdhdGNoLCBuYW1lKSwKIAkJCQkJCSAgIHdhdGNoLT50b2tlbik7 CiAJCQl9CkBAIC0yMzgsOCArMjQxLDEyIEBAIGludCBkb193YXRjaChzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmlu KQogCXRhbGxvY19zZXRfZGVzdHJ1Y3Rvcih3YXRjaCwgZGVzdHJveV93YXRj aCk7CiAJc2VuZF9hY2soY29ubiwgWFNfV0FUQ0gpOwogCi0JLyogV2UgZmly ZSBvbmNlIHVwIGZyb250OiBzaW1wbGlmaWVzIGNsaWVudHMgYW5kIHJlc3Rh cnQuICovCi0Jc2VuZF9ldmVudChjb25uLCBnZXRfd2F0Y2hfcGF0aCh3YXRj aCwgd2F0Y2gtPm5vZGUpLCB3YXRjaC0+dG9rZW4pOworCS8qCisJICogV2Ug ZmlyZSBvbmNlIHVwIGZyb250OiBzaW1wbGlmaWVzIGNsaWVudHMgYW5kIHJl c3RhcnQuCisJICogVGhpcyBldmVudCB3aWxsIG5vdCBiZSBsaW5rZWQgdG8g dGhlIFhTX1dBVENIIHJlcXVlc3QuCisJICovCisJc2VuZF9ldmVudChOVUxM LCBjb25uLCBnZXRfd2F0Y2hfcGF0aCh3YXRjaCwgd2F0Y2gtPm5vZGUpLAor CQkgICB3YXRjaC0+dG9rZW4pOwogCiAJcmV0dXJuIDA7CiB9Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-06.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-06.patch" Content-Transfer-Encoding: base64 RnJvbSAzOTAwYmI0MzUwM2Y5OGM0YjUyY2IxOTRlMGY0YmEzYWVkZTg4OWU0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGRvbid0IGJ1 ZmZlciBtdWx0aXBsZSBpZGVudGljYWwgd2F0Y2ggZXZlbnRzCgpBIGd1ZXN0 IG5vdCByZWFkaW5nIGl0cyBYZW5zdG9yZSByZXNwb25zZSBidWZmZXIgZmFz dCBlbm91Z2ggbWlnaHQKcGlsZSB1cCBsb3RzIG9mIFhlbnN0b3JlIHdhdGNo IGV2ZW50cyBidWZmZXJlZC4gUmVkdWNlIHRoZSBnZW5lcmF0ZWQKbG9hZCBi eSBkcm9wcGluZyBuZXcgZXZlbnRzIHdoaWNoIGFscmVhZHkgaGF2ZSBhbiBp ZGVudGljYWwgY29weQpwZW5kaW5nLgoKVGhlIHNwZWNpYWwgZXZlbnRzICJA Li4uIiBhcmUgZXhjbHVkZWQgZnJvbSB0aGF0IGhhbmRsaW5nIGFzIHRoZXJl IGFyZQprbm93biB1c2UgY2FzZXMgd2hlcmUgdGhlIGhhbmRsZXIgaXMgcmVs eWluZyBvbiBlYWNoIGV2ZW50IHRvIGJlIHNlbnQKaW5kaXZpZHVhbGx5LgoK VGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRlZC1ieTogSnVsaWVu IEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVs aWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuYwppbmRleCAyZWQ5MWQxMzI5N2IuLmM2ZjFk NDE4OWNmZSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2NvcmUuYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5j CkBAIC04MjMsNiArODIzLDcgQEAgdm9pZCBzZW5kX3JlcGx5KHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSwK IAliZGF0YS0+aW5oZHIgPSB0cnVlOwogCWJkYXRhLT51c2VkID0gMDsKIAli ZGF0YS0+dGltZW91dF9tc2VjID0gMDsKKwliZGF0YS0+d2F0Y2hfZXZlbnQg PSBmYWxzZTsKIAogCWlmIChsZW4gPD0gREVGQVVMVF9CVUZGRVJfU0laRSkK IAkJYmRhdGEtPmJ1ZmZlciA9IGJkYXRhLT5kZWZhdWx0X2J1ZmZlcjsKQEAg LTg1NSw3ICs4NTYsNyBAQCB2b2lkIHNlbmRfcmVwbHkoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlLAogdm9p ZCBzZW5kX2V2ZW50KHN0cnVjdCBidWZmZXJlZF9kYXRhICpyZXEsIHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAogCQljb25zdCBjaGFyICpwYXRoLCBjb25z dCBjaGFyICp0b2tlbikKIHsKLQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRh dGE7CisJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmJkYXRhLCAqYmQ7CiAJdW5z aWduZWQgaW50IGxlbjsKIAogCWxlbiA9IHN0cmxlbihwYXRoKSArIDEgKyBz dHJsZW4odG9rZW4pICsgMTsKQEAgLTg3NywxMiArODc4LDI5IEBAIHZvaWQg c2VuZF9ldmVudChzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqcmVxLCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKIAliZGF0YS0+aGRyLm1zZy50eXBlID0gWFNf V0FUQ0hfRVZFTlQ7CiAJYmRhdGEtPmhkci5tc2cubGVuID0gbGVuOwogCisJ LyoKKwkgKiBDaGVjayB3aGV0aGVyIGFuIGlkZW50aWNhbCBldmVudCBpcyBw ZW5kaW5nIGFscmVhZHkuCisJICogU3BlY2lhbCBldmVudHMgYXJlIGV4Y2x1 ZGVkIGZyb20gdGhhdCBjaGVjay4KKwkgKi8KKwlpZiAocGF0aFswXSAhPSAn QCcpIHsKKwkJbGlzdF9mb3JfZWFjaF9lbnRyeShiZCwgJmNvbm4tPm91dF9s aXN0LCBsaXN0KSB7CisJCQlpZiAoYmQtPndhdGNoX2V2ZW50ICYmIGJkLT5o ZHIubXNnLmxlbiA9PSBsZW4gJiYKKwkJCSAgICAhbWVtY21wKGJkYXRhLT5i dWZmZXIsIGJkLT5idWZmZXIsIGxlbikpIHsKKwkJCQl0cmFjZSgiZHJvcHBp bmcgZHVwbGljYXRlIHdhdGNoICVzICVzIGZvciBkb21haW4gJXVcbiIsCisJ CQkJICAgICAgcGF0aCwgdG9rZW4sIGNvbm4tPmlkKTsKKwkJCQl0YWxsb2Nf ZnJlZShiZGF0YSk7CisJCQkJcmV0dXJuOworCQkJfQorCQl9CisJfQorCiAJ aWYgKHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyAmJiBkb21haW5faXNfdW5w cml2aWxlZ2VkKGNvbm4pKSB7CiAJCWJkYXRhLT50aW1lb3V0X21zZWMgPSBn ZXRfbm93X21zZWMoKSArIHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIAkJ aWYgKCFjb25uLT50aW1lb3V0X21zZWMpCiAJCQljb25uLT50aW1lb3V0X21z ZWMgPSBiZGF0YS0+dGltZW91dF9tc2VjOwogCX0KIAorCWJkYXRhLT53YXRj aF9ldmVudCA9IHRydWU7CiAJYmRhdGEtPnBlbmQucmVxID0gcmVxOwogCWlm IChyZXEpCiAJCXJlcS0+cGVuZC5yZWYuZXZlbnRfY250Kys7CmRpZmYgLS1n aXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCBlZGVhYTk2ZGQxMGIu LjFlYjYxMzFmYzg4ZCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5oCkBAIC01MSw2ICs1MSw5IEBAIHN0cnVjdCBidWZmZXJlZF9kYXRh CiAJLyogQXJlIHdlIHN0aWxsIGRvaW5nIHRoZSBoZWFkZXI/ICovCiAJYm9v bCBpbmhkcjsKIAorCS8qIElzIHRoaXMgYSB3YXRjaCBldmVudD8gKi8KKwli b29sIHdhdGNoX2V2ZW50OworCiAJLyogSG93IGZhciBhcmUgd2U/ICovCiAJ dW5zaWduZWQgaW50IHVzZWQ7CiAK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-07.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-07.patch" Content-Transfer-Encoding: base64 RnJvbSA5ZWRmZDdmYWIxMTE4MzNmYmExZDZlYTVkMjZmZDE0NzFjMDkwZTgz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGZpeCBjb25u ZWN0aW9uLT5pZCB1c2FnZQoKRG9uJ3QgdXNlIGNvbm4tPmlkIGZvciBwcml2 aWxlZ2UgY2hlY2tzLCBidXQgZG9tYWluX2lzX3VucHJpdmlsZWdlZCgpLgoK VGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRlZC1ieTogSnVsaWVu IEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVs aWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuYwppbmRleCA4ZDQ4YWI0ODIwMWIu LmJjZTY2NjJmNmU0NSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvbnRyb2wuYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29udHJvbC5jCkBAIC0xOTgsNyArMTk4LDcgQEAgaW50IGRvX2NvbnRy b2woc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbikKIAlpbnQgY21kOwogCWNoYXIgKip2ZWM7CiAKLQlpZiAoY29u bi0+aWQgIT0gMCkKKwlpZiAoZG9tYWluX2lzX3VucHJpdmlsZWdlZChjb25u KSkKIAkJcmV0dXJuIEVBQ0NFUzsKIAogCW51bSA9IHhzX2NvdW50X3N0cmlu Z3MoaW4tPmJ1ZmZlciwgaW4tPnVzZWQpOwpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmgKaW5kZXggMWViNjEzMWZjODhkLi45OGRiNGFmY2Fh YmYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAt OTMsNyArOTMsNyBAQCBzdHJ1Y3QgY29ubmVjdGlvbgogCS8qIFRoZSBpbmRl eCBvZiBwb2xsZmQgaW4gZ2xvYmFsIHBvbGxmZCBhcnJheSAqLwogCWludCBw b2xsZmRfaWR4OwogCi0JLyogV2hvIGFtIEk/IDAgZm9yIHNvY2tldCBjb25u ZWN0aW9ucy4gKi8KKwkvKiBXaG8gYW0gST8gRG9taWQgb2YgY29ubmVjdGlv bi4gKi8KIAl1bnNpZ25lZCBpbnQgaWQ7CiAKIAkvKiBJcyB0aGlzIGEgcmVh ZC1vbmx5IGNvbm5lY3Rpb24/ICovCmRpZmYgLS1naXQgYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4IDZmYmRiMjlkY2RkNy4u OWJlZjZlNzJhNTY2IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfdHJhbnNhY3Rpb24uYwpAQCAtNDgzLDcgKzQ4Myw4IEBAIGludCBk b190cmFuc2FjdGlvbl9zdGFydChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg c3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCWlmIChjb25uLT50cmFuc2Fj dGlvbikKIAkJcmV0dXJuIEVCVVNZOwogCi0JaWYgKGNvbm4tPmlkICYmIGNv bm4tPnRyYW5zYWN0aW9uX3N0YXJ0ZWQgPiBxdW90YV9tYXhfdHJhbnNhY3Rp b24pCisJaWYgKGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikgJiYKKwkg ICAgY29ubi0+dHJhbnNhY3Rpb25fc3RhcnRlZCA+IHF1b3RhX21heF90cmFu c2FjdGlvbikKIAkJcmV0dXJuIEVOT1NQQzsKIAogCS8qIEF0dGFjaCB0cmFu c2FjdGlvbiB0byBpbnB1dCBmb3IgYXV0b2ZyZWUgdW50aWwgaXQncyBjb21w bGV0ZSAqLwo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-08.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-08.patch" Content-Transfer-Encoding: base64 RnJvbSA1YWI4OTMwOGY0NjQ1MjU2NzQyNWNiMzJhODQzZjlmMzdlZDQ1ODhi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHNpbXBsaWZ5 IGFuZCBmaXggcGVyIGRvbWFpbiBub2RlIGFjY291bnRpbmcKClRoZSBhY2Nv dW50aW5nIG9mIG5vZGVzIGNhbiBiZSBzaW1wbGlmaWVkIG5vdyB0aGF0IGVh Y2ggY29ubmVjdGlvbgpob2xkcyB0aGUgYXNzb2NpYXRlZCBkb21pZC4KCkZp eCB0aGUgbm9kZSBhY2NvdW50aW5nIHRvIGNvdmVyIG5vZGVzIGNyZWF0ZWQg Zm9yIGEgZG9tYWluIGJlZm9yZSBpdApoYXMgYmVlbiBpbnRyb2R1Y2VkLiBU aGlzIHJlcXVpcmVzIHRvIHJlYWN0IHByb3Blcmx5IHRvIGFuIGFsbG9jYXRp b24KZmFpbHVyZSBpbnNpZGUgZG9tYWluX2VudHJ5X2luYygpIGJ5IHJldHVy bmluZyBhbiBlcnJvciBjb2RlLgoKRXNwZWNpYWxseSBpbiBlcnJvciBwYXRo cyB0aGUgbm9kZSBhY2NvdW50aW5nIGhhcyB0byBiZSBmaXhlZCBpbiBzb21l CmNhc2VzLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYgLyBDVkUtMjAyMi00 MjMxMy4KClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6 b24uY29tPgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NA c3VzZS5jb20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBh bWF6b24uY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb250cm9sLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29u dHJvbC5jCmluZGV4IGJjZTY2NjJmNmU0NS4uYWIwNzk0ZGVlZGM4IDEwMDY0 NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jCisr KyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmMKQEAgLTI1 LDYgKzI1LDcgQEAKICNpbmNsdWRlICJ0YWxsb2MuaCIKICNpbmNsdWRlICJ4 ZW5zdG9yZWRfY29yZS5oIgogI2luY2x1ZGUgInhlbnN0b3JlZF9jb250cm9s LmgiCisjaW5jbHVkZSAieGVuc3RvcmVkX2RvbWFpbi5oIgogCiBzdHJ1Y3Qg Y21kX3MgewogCWNoYXIgKmNtZDsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5jCmluZGV4IGM2ZjFkNDE4OWNmZS4uMTJkMDEzZDI0OTQ5IDEw MDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisr KyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTU0NSw3 ICs1NDUsNyBAQCBzdHJ1Y3Qgbm9kZSAqcmVhZF9ub2RlKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsCiAKIAkvKiBQZXJtaXNz aW9ucyBhcmUgc3RydWN0IHhzX3Blcm1pc3Npb25zLiAqLwogCW5vZGUtPnBl cm1zLnAgPSBoZHItPnBlcm1zOwotCWlmIChkb21haW5fYWRqdXN0X25vZGVf cGVybXMobm9kZSkpIHsKKwlpZiAoZG9tYWluX2FkanVzdF9ub2RlX3Blcm1z KGNvbm4sIG5vZGUpKSB7CiAJCXRhbGxvY19mcmVlKG5vZGUpOwogCQlyZXR1 cm4gTlVMTDsKIAl9CkBAIC01NjcsNyArNTY3LDcgQEAgaW50IHdyaXRlX25v ZGVfcmF3KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5 LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIAl2b2lkICpwOwogCXN0cnVjdCB4c190 ZGJfcmVjb3JkX2hkciAqaGRyOwogCi0JaWYgKGRvbWFpbl9hZGp1c3Rfbm9k ZV9wZXJtcyhub2RlKSkKKwlpZiAoZG9tYWluX2FkanVzdF9ub2RlX3Blcm1z KGNvbm4sIG5vZGUpKQogCQlyZXR1cm4gZXJybm87CiAKIAlkYXRhLmRzaXpl ID0gc2l6ZW9mKCpoZHIpCkBAIC0xMTYxLDEzICsxMTYxLDE3IEBAIHN0YXRp YyBzdHJ1Y3Qgbm9kZSAqY29uc3RydWN0X25vZGUoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAlyZXR1cm4gTlVMTDsKIH0K IAotc3RhdGljIGludCBkZXN0cm95X25vZGUoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQorc3RhdGljIHZvaWQgZGVzdHJv eV9ub2RlX3JtKHN0cnVjdCBub2RlICpub2RlKQogewogCWlmIChzdHJlcShu b2RlLT5uYW1lLCAiLyIpKQogCQljb3JydXB0KE5VTEwsICJEZXN0cm95aW5n IHJvb3Qgbm9kZSEiKTsKIAogCXRkYl9kZWxldGUodGRiX2N0eCwgbm9kZS0+ a2V5KTsKK30KIAorc3RhdGljIGludCBkZXN0cm95X25vZGUoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQoreworCWRlc3Ry b3lfbm9kZV9ybShub2RlKTsKIAlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5v ZGUpOwogCiAJLyoKQEAgLTEyMTcsOCArMTIyMSwxMiBAQCBzdGF0aWMgc3Ry dWN0IG5vZGUgKmNyZWF0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25u LCBjb25zdCB2b2lkICpjdHgsCiAJCQlnb3RvIGVycjsKIAogCQkvKiBBY2Nv dW50IGZvciBuZXcgbm9kZSAqLwotCQlpZiAoaS0+cGFyZW50KQotCQkJZG9t YWluX2VudHJ5X2luYyhjb25uLCBpKTsKKwkJaWYgKGktPnBhcmVudCkgewor CQkJaWYgKGRvbWFpbl9lbnRyeV9pbmMoY29ubiwgaSkpIHsKKwkJCQlkZXN0 cm95X25vZGVfcm0oaSk7CisJCQkJcmV0dXJuIE5VTEw7CisJCQl9CisJCX0K IAl9CiAKIAlyZXR1cm4gbm9kZTsKQEAgLTE0OTksMTAgKzE1MDcsMjcgQEAg c3RhdGljIGludCBkb19zZXRfcGVybXMoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlvbGRfcGVybXMgPSBu b2RlLT5wZXJtczsKIAlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5vZGUpOwog CW5vZGUtPnBlcm1zID0gcGVybXM7Ci0JZG9tYWluX2VudHJ5X2luYyhjb25u LCBub2RlKTsKKwlpZiAoZG9tYWluX2VudHJ5X2luYyhjb25uLCBub2RlKSkg eworCQlub2RlLT5wZXJtcyA9IG9sZF9wZXJtczsKKwkJLyoKKwkJICogVGhp cyBzaG91bGQgbmV2ZXIgZmFpbCBiZWNhdXNlIHdlIGhhZCBhIHJlZmVyZW5j ZSBvbiB0aGUKKwkJICogZG9tYWluIGJlZm9yZSBhbmQgWGVuc3RvcmVkIGlz IHNpbmdsZS10aHJlYWRlZC4KKwkJICovCisJCWRvbWFpbl9lbnRyeV9pbmMo Y29ubiwgbm9kZSk7CisJCXJldHVybiBFTk9NRU07CisJfQogCi0JaWYgKHdy aXRlX25vZGUoY29ubiwgbm9kZSwgZmFsc2UpKQorCWlmICh3cml0ZV9ub2Rl KGNvbm4sIG5vZGUsIGZhbHNlKSkgeworCQlpbnQgc2F2ZWRfZXJybm8gPSBl cnJubzsKKworCQlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5vZGUpOworCQlu b2RlLT5wZXJtcyA9IG9sZF9wZXJtczsKKwkJLyogTm8gZmFpbHVyZSBwb3Nz aWJsZSBhcyBhYm92ZS4gKi8KKwkJZG9tYWluX2VudHJ5X2luYyhjb25uLCBu b2RlKTsKKworCQllcnJubyA9IHNhdmVkX2Vycm5vOwogCQlyZXR1cm4gZXJy bm87CisJfQogCiAJZmlyZV93YXRjaGVzKGNvbm4sIGluLCBuYW1lLCBub2Rl LCBmYWxzZSwgJm9sZF9wZXJtcyk7CiAJc2VuZF9hY2soY29ubiwgWFNfU0VU X1BFUk1TKTsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9kb21haW4uYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4u YwppbmRleCAyZGQ4MGViMWE3YmIuLjMwNmUxMjM1OGJmOSAxMDA2NDQKLS0t IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCisrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYwpAQCAtMTYsNiArMTYs NyBAQAogICAgIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtOyBJZiBub3QsIHNl ZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCiAqLwogCisjaW5j bHVkZSA8YXNzZXJ0Lmg+CiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNsdWRl IDxzeXMvbW1hbi5oPgogI2luY2x1ZGUgPHVuaXN0ZC5oPgpAQCAtMzU4LDYg KzM1OSwxOCBAQCBzdGF0aWMgc3RydWN0IGRvbWFpbiAqYWxsb2NfZG9tYWlu KHZvaWQgKmNvbnRleHQsIHVuc2lnbmVkIGludCBkb21pZCkKIAlyZXR1cm4g ZG9tYWluOwogfQogCitzdGF0aWMgc3RydWN0IGRvbWFpbiAqZmluZF9vcl9h bGxvY19leGlzdGluZ19kb21haW4odW5zaWduZWQgaW50IGRvbWlkKQorewor CXN0cnVjdCBkb21haW4gKmRvbWFpbjsKKwl4Y19kb21pbmZvX3QgZG9taW5m bzsKKworCWRvbWFpbiA9IGZpbmRfZG9tYWluX3N0cnVjdChkb21pZCk7CisJ aWYgKCFkb21haW4gJiYgZ2V0X2RvbWFpbl9pbmZvKGRvbWlkLCAmZG9taW5m bykpCisJCWRvbWFpbiA9IGFsbG9jX2RvbWFpbihOVUxMLCBkb21pZCk7CisK KwlyZXR1cm4gZG9tYWluOworfQorCiBzdGF0aWMgaW50IG5ld19kb21haW4o c3RydWN0IGRvbWFpbiAqZG9tYWluLCBpbnQgcG9ydCkKIHsKIAlpbnQgcmM7 CkBAIC03NjcsMzAgKzc4MCwyOCBAQCB2b2lkIGRvbWFpbl9pbml0KHZvaWQp CiAJdmlycV9wb3J0ID0gcmM7CiB9CiAKLXZvaWQgZG9tYWluX2VudHJ5X2lu YyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKm5vZGUp CitpbnQgZG9tYWluX2VudHJ5X2luYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgc3RydWN0IG5vZGUgKm5vZGUpCiB7CiAJc3RydWN0IGRvbWFpbiAqZDsK Kwl1bnNpZ25lZCBpbnQgZG9taWQ7CiAKIAlpZiAoIWNvbm4pCi0JCXJldHVy bjsKKwkJcmV0dXJuIDA7CiAKLQlpZiAobm9kZS0+cGVybXMucCAmJiBub2Rl LT5wZXJtcy5wWzBdLmlkICE9IGNvbm4tPmlkKSB7Ci0JCWlmIChjb25uLT50 cmFuc2FjdGlvbikgewotCQkJdHJhbnNhY3Rpb25fZW50cnlfaW5jKGNvbm4t PnRyYW5zYWN0aW9uLAotCQkJCW5vZGUtPnBlcm1zLnBbMF0uaWQpOwotCQl9 IGVsc2UgewotCQkJZCA9IGZpbmRfZG9tYWluX2J5X2RvbWlkKG5vZGUtPnBl cm1zLnBbMF0uaWQpOwotCQkJaWYgKGQpCi0JCQkJZC0+bmJlbnRyeSsrOwot CQl9Ci0JfSBlbHNlIGlmIChjb25uLT5kb21haW4pIHsKLQkJaWYgKGNvbm4t PnRyYW5zYWN0aW9uKSB7Ci0JCQl0cmFuc2FjdGlvbl9lbnRyeV9pbmMoY29u bi0+dHJhbnNhY3Rpb24sCi0JCQkJY29ubi0+ZG9tYWluLT5kb21pZCk7Ci0g CQl9IGVsc2UgewotIAkJCWNvbm4tPmRvbWFpbi0+bmJlbnRyeSsrOwotCQl9 CisJZG9taWQgPSBub2RlLT5wZXJtcy5wID8gbm9kZS0+cGVybXMucFswXS5p ZCA6IGNvbm4tPmlkOworCisJaWYgKGNvbm4tPnRyYW5zYWN0aW9uKSB7CisJ CXRyYW5zYWN0aW9uX2VudHJ5X2luYyhjb25uLT50cmFuc2FjdGlvbiwgZG9t aWQpOworCX0gZWxzZSB7CisJCWQgPSAoZG9taWQgPT0gY29ubi0+aWQgJiYg Y29ubi0+ZG9tYWluKSA/IGNvbm4tPmRvbWFpbgorCQkgICAgOiBmaW5kX29y X2FsbG9jX2V4aXN0aW5nX2RvbWFpbihkb21pZCk7CisJCWlmIChkKQorCQkJ ZC0+bmJlbnRyeSsrOworCQllbHNlCisJCQlyZXR1cm4gRU5PTUVNOwogCX0K KworCXJldHVybiAwOwogfQogCiAvKgpAQCAtODI2LDcgKzgzNyw3IEBAIHN0 YXRpYyBpbnQgY2hrX2RvbWFpbl9nZW5lcmF0aW9uKHVuc2lnbmVkIGludCBk b21pZCwgdWludDY0X3QgZ2VuKQogICogUmVtb3ZlIHBlcm1pc3Npb25zIGZv ciBubyBsb25nZXIgZXhpc3RpbmcgZG9tYWlucyBpbiBvcmRlciB0byBhdm9p ZCBhIG5ldwogICogZG9tYWluIHdpdGggdGhlIHNhbWUgZG9taWQgaW5oZXJp dGluZyB0aGUgcGVybWlzc2lvbnMuCiAgKi8KLWludCBkb21haW5fYWRqdXN0 X25vZGVfcGVybXMoc3RydWN0IG5vZGUgKm5vZGUpCitpbnQgZG9tYWluX2Fk anVzdF9ub2RlX3Blcm1zKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1 Y3Qgbm9kZSAqbm9kZSkKIHsKIAl1bnNpZ25lZCBpbnQgaTsKIAlpbnQgcmV0 OwpAQCAtODM2LDggKzg0NywxNCBAQCBpbnQgZG9tYWluX2FkanVzdF9ub2Rl X3Blcm1zKHN0cnVjdCBub2RlICpub2RlKQogCQlyZXR1cm4gZXJybm87CiAK IAkvKiBJZiB0aGUgb3duZXIgZG9lc24ndCBleGlzdCBhbnkgbG9uZ2VyIGdp dmUgaXQgdG8gcHJpdiBkb21haW4uICovCi0JaWYgKCFyZXQpCisJaWYgKCFy ZXQpIHsKKwkJLyoKKwkJICogSW4gdGhlb3J5IHdlJ2QgbmVlZCB0byB1cGRh dGUgdGhlIG51bWJlciBvZiBkb20wIG5vZGVzIGhlcmUsCisJCSAqIGJ1dCB3 ZSBjb3VsZCBiZSBjYWxsZWQgZm9yIGEgcmVhZCBvZiB0aGUgbm9kZS4gU28g YmV0dGVyCisJCSAqIGF2b2lkIHRoZSByaXNrIHRvIG92ZXJmbG93IHRoZSBu b2RlIGNvdW50IG9mIGRvbTAuCisJCSAqLwogCQlub2RlLT5wZXJtcy5wWzBd LmlkID0gcHJpdl9kb21pZDsKKwl9CiAKIAlmb3IgKGkgPSAxOyBpIDwgbm9k ZS0+cGVybXMubnVtOyBpKyspIHsKIAkJaWYgKG5vZGUtPnBlcm1zLnBbaV0u cGVybXMgJiBYU19QRVJNX0lHTk9SRSkKQEAgLTg1NiwyNSArODczLDI1IEBA IGludCBkb21haW5fYWRqdXN0X25vZGVfcGVybXMoc3RydWN0IG5vZGUgKm5v ZGUpCiB2b2lkIGRvbWFpbl9lbnRyeV9kZWMoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQogewogCXN0cnVjdCBkb21haW4g KmQ7CisJdW5zaWduZWQgaW50IGRvbWlkOwogCiAJaWYgKCFjb25uKQogCQly ZXR1cm47CiAKLQlpZiAobm9kZS0+cGVybXMucCAmJiBub2RlLT5wZXJtcy5w WzBdLmlkICE9IGNvbm4tPmlkKSB7Ci0JCWlmIChjb25uLT50cmFuc2FjdGlv bikgewotCQkJdHJhbnNhY3Rpb25fZW50cnlfZGVjKGNvbm4tPnRyYW5zYWN0 aW9uLAotCQkJCW5vZGUtPnBlcm1zLnBbMF0uaWQpOwotCQl9IGVsc2Ugewot CQkJZCA9IGZpbmRfZG9tYWluX2J5X2RvbWlkKG5vZGUtPnBlcm1zLnBbMF0u aWQpOwotCQkJaWYgKGQgJiYgZC0+bmJlbnRyeSkKLQkJCQlkLT5uYmVudHJ5 LS07Ci0JCX0KLQl9IGVsc2UgaWYgKGNvbm4tPmRvbWFpbiAmJiBjb25uLT5k b21haW4tPm5iZW50cnkpIHsKLQkJaWYgKGNvbm4tPnRyYW5zYWN0aW9uKSB7 Ci0JCQl0cmFuc2FjdGlvbl9lbnRyeV9kZWMoY29ubi0+dHJhbnNhY3Rpb24s Ci0JCQkJY29ubi0+ZG9tYWluLT5kb21pZCk7CisJZG9taWQgPSBub2RlLT5w ZXJtcy5wID8gbm9kZS0+cGVybXMucFswXS5pZCA6IGNvbm4tPmlkOworCisJ aWYgKGNvbm4tPnRyYW5zYWN0aW9uKSB7CisJCXRyYW5zYWN0aW9uX2VudHJ5 X2RlYyhjb25uLT50cmFuc2FjdGlvbiwgZG9taWQpOworCX0gZWxzZSB7CisJ CWQgPSAoZG9taWQgPT0gY29ubi0+aWQgJiYgY29ubi0+ZG9tYWluKSA/IGNv bm4tPmRvbWFpbgorCQkgICAgOiBmaW5kX2RvbWFpbl9zdHJ1Y3QoZG9taWQp OworCQlpZiAoZCkgeworCQkJZC0+bmJlbnRyeS0tOwogCQl9IGVsc2Ugewot CQkJY29ubi0+ZG9tYWluLT5uYmVudHJ5LS07CisJCQllcnJubyA9IEVOT0VO VDsKKwkJCWNvcnJ1cHQoY29ubiwKKwkJCQkiTm9kZSBcIiVzXCIgb3duZWQg Ynkgbm9uLWV4aXN0aW5nIGRvbWFpbiAldVxuIiwKKwkJCQlub2RlLT5uYW1l LCBkb21pZCk7CiAJCX0KIAl9CiB9CkBAIC04ODQsMTMgKzkwMSwyMyBAQCBp bnQgZG9tYWluX2VudHJ5X2ZpeCh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBu dW0sIGJvb2wgdXBkYXRlKQogCXN0cnVjdCBkb21haW4gKmQ7CiAJaW50IGNu dDsKIAotCWQgPSBmaW5kX2RvbWFpbl9ieV9kb21pZChkb21pZCk7Ci0JaWYg KCFkKQotCQlyZXR1cm4gMDsKKwlpZiAodXBkYXRlKSB7CisJCWQgPSBmaW5k X2RvbWFpbl9zdHJ1Y3QoZG9taWQpOworCQlhc3NlcnQoZCk7CisJfSBlbHNl IHsKKwkJLyoKKwkJICogV2UgYXJlIGNhbGxlZCBmaXJzdCB3aXRoIHVwZGF0 ZSA9PSBmYWxzZSBpbiBvcmRlciB0byBjYXRjaAorCQkgKiBhbnkgZXJyb3Iu IFNvIGRvIGEgcG9zc2libGUgYWxsb2NhdGlvbiBhbmQgY2hlY2sgZm9yIGVy cm9yCisJCSAqIG9ubHkgaW4gdGhpcyBjYXNlLCBhcyBpbiB0aGUgY2FzZSBv ZiB1cGRhdGUgPT0gdHJ1ZSBub3RoaW5nCisJCSAqIGNhbiBnbyB3cm9uZyBh bnltb3JlIGFzIHRoZSBhbGxvY2F0aW9uIGFscmVhZHkgaGFwcGVuZWQuCisJ CSAqLworCQlkID0gZmluZF9vcl9hbGxvY19leGlzdGluZ19kb21haW4oZG9t aWQpOworCQlpZiAoIWQpCisJCQlyZXR1cm4gLTE7CisJfQogCiAJY250ID0g ZC0+bmJlbnRyeSArIG51bTsKLQlpZiAoY250IDwgMCkKLQkJY250ID0gMDsK Kwlhc3NlcnQoY250ID49IDApOwogCiAJaWYgKHVwZGF0ZSkKIAkJZC0+bmJl bnRyeSA9IGNudDsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9kb21haW4uaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21h aW4uaAppbmRleCA0YmZmMmU2NTViOWIuLjRlZGYxZGJhOTQyNSAxMDA2NDQK LS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oCisrKyBi L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaApAQCAtNTcsMTAg KzU3LDEwIEBAIGJvb2wgZG9tYWluX2Nhbl93cml0ZShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubik7CiBib29sIGRvbWFpbl9pc191bnByaXZpbGVnZWQoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4pOwogCiAvKiBSZW1vdmUgbm9kZSBwZXJt aXNzaW9ucyBmb3Igbm8gbG9uZ2VyIGV4aXN0aW5nIGRvbWFpbnMuICovCi1p bnQgZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKHN0cnVjdCBub2RlICpub2Rl KTsKK2ludCBkb21haW5fYWRqdXN0X25vZGVfcGVybXMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlKTsKIAogLyogUXVvdGEg bWFuaXB1bGF0aW9uICovCi12b2lkIGRvbWFpbl9lbnRyeV9pbmMoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICopOworaW50IGRvbWFp bl9lbnRyeV9pbmMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICopOwogdm9pZCBkb21haW5fZW50cnlfZGVjKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqKTsKIGludCBkb21haW5fZW50cnlf Zml4KHVuc2lnbmVkIGludCBkb21pZCwgaW50IG51bSwgYm9vbCB1cGRhdGUp OwogaW50IGRvbWFpbl9lbnRyeShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7 CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNh Y3Rpb24uYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlv bi5jCmluZGV4IDliZWY2ZTcyYTU2Ni4uYmYyZmRhODIzNGIzIDEwMDY0NAot LS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwor KysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpA QCAtNTIzLDggKzUyMywxMiBAQCBzdGF0aWMgaW50IHRyYW5zYWN0aW9uX2Zp eF9kb21haW5zKHN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnMsIGJvb2wgdXBk YXRlKQogCiAJbGlzdF9mb3JfZWFjaF9lbnRyeShkLCAmdHJhbnMtPmNoYW5n ZWRfZG9tYWlucywgbGlzdCkgewogCQljbnQgPSBkb21haW5fZW50cnlfZml4 KGQtPmRvbWlkLCBkLT5uYmVudHJ5LCB1cGRhdGUpOwotCQlpZiAoIXVwZGF0 ZSAmJiBjbnQgPj0gcXVvdGFfbmJfZW50cnlfcGVyX2RvbWFpbikKLQkJCXJl dHVybiBFTk9TUEM7CisJCWlmICghdXBkYXRlKSB7CisJCQlpZiAoY250ID49 IHF1b3RhX25iX2VudHJ5X3Blcl9kb21haW4pCisJCQkJcmV0dXJuIEVOT1NQ QzsKKwkJCWlmIChjbnQgPCAwKQorCQkJCXJldHVybiBFTk9NRU07CisJCX0K IAl9CiAKIAlyZXR1cm4gMDsK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-09.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-09.patch" Content-Transfer-Encoding: base64 RnJvbSBmMGI4NTZmNmQ2NDAzZDMyNTYzYWM3ZjZiODA3YTU4YWQ1NjgyZTkz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxpbWl0IG1h eCBudW1iZXIgb2Ygbm9kZXMgYWNjZXNzZWQgaW4gYSB0cmFuc2FjdGlvbgoK VG9kYXkgYSBndWVzdCBpcyBmcmVlIHRvIGFjY2VzcyBhcyBtYW55IG5vZGVz IGluIGEgc2luZ2xlIHRyYW5zYWN0aW9uCmFzIGl0IHdhbnRzLiBUaGlzIGNh biBsZWFkIHRvIHVuYm91bmRlZCBtZW1vcnkgY29uc3VtcHRpb24gaW4gWGVu c3RvcmUKYXMgdGhlcmUgaXMgdGhlIG5lZWQgdG8ga2VlcCB0cmFjayBvZiBh bGwgbm9kZXMgaGF2aW5nIGJlZW4gYWNjZXNzZWQKZHVyaW5nIGEgdHJhbnNh Y3Rpb24uCgpJbiBveGVuc3RvcmVkIHRoZSBudW1iZXIgb2YgcmVxdWVzdHMg aW4gYSB0cmFuc2FjdGlvbiBpcyBiZWluZyBsaW1pdGVkCnZpYSBhIHF1b3Rh IG1heHJlcXVlc3RzIChkZWZhdWx0IGlzIDEwMjQpLiBBcyBtdWx0aXBsZSBh Y2Nlc3NlcyBvZiBhCm5vZGUgYXJlIG5vdCBwcm9ibGVtYXRpYyBpbiBDIFhl bnN0b3JlLCBsaW1pdCB0aGUgbnVtYmVyIG9mIGFjY2Vzc2VkCm5vZGVzLgoK SW4gb3JkZXIgdG8gbGV0IHJlYWRfbm9kZSgpIGRldGVjdCBhIHF1b3RhIGVy cm9yIGluIGNhc2UgdG9vIG1hbnkgbm9kZXMKYXJlIGJlaW5nIGFjY2Vzc2Vk LCBjaGVjayB0aGUgcmV0dXJuIHZhbHVlIG9mIGFjY2Vzc19ub2RlKCkgYW5k IHJldHVybgpOVUxMIGluIGNhc2UgYW4gZXJyb3IgaGFzIGJlZW4gc2Vlbi4g SW50cm9kdWNlIF9fbXVzdF9jaGVjayBhbmQgYWRkIGl0CnRvIHRoZSBhY2Nl c3Nfbm9kZSgpIHByb3RvdHlwZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2 IC8gQ1ZFLTIwMjItNDIzMTQuCgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxs IDxqZ3JhbGxAYW1hem9uLmNvbT4KU3VnZ2VzdGVkLWJ5OiBKdWxpZW4gR3Jh bGwgPGp1bGllbkB4ZW4ub3JnPgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdy b3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3Jh bGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL2lu Y2x1ZGUveGVuLXRvb2xzL2xpYnMuaCBiL3Rvb2xzL2luY2x1ZGUveGVuLXRv b2xzL2xpYnMuaAppbmRleCBjYzdkZmM4YzY0NTMuLjM0ZGIzYjc4NDczMiAx MDA2NDQKLS0tIGEvdG9vbHMvaW5jbHVkZS94ZW4tdG9vbHMvbGlicy5oCisr KyBiL3Rvb2xzL2luY2x1ZGUveGVuLXRvb2xzL2xpYnMuaApAQCAtNTksNCAr NTksOCBAQAogICAgIH0pCiAjZW5kaWYKIAorI2lmbmRlZiBfX211c3RfY2hl Y2sKKyNkZWZpbmUgX19tdXN0X2NoZWNrIF9fYXR0cmlidXRlX18oKF9fd2Fy bl91bnVzZWRfcmVzdWx0X18pKQorI2VuZGlmCisKICNlbmRpZgkvKiBfX1hF Tl9UT09MU19MSUJTX18gKi8KZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5jCmluZGV4IDEyZDAxM2QyNDk0OS4uZmY2NDliNzU0NGRiIDEwMDY0 NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBi L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTEwNSw2ICsx MDUsNyBAQCBpbnQgcXVvdGFfbmJfd2F0Y2hfcGVyX2RvbWFpbiA9IDEyODsK IGludCBxdW90YV9tYXhfZW50cnlfc2l6ZSA9IDIwNDg7IC8qIDJLICovCiBp bnQgcXVvdGFfbWF4X3RyYW5zYWN0aW9uID0gMTA7CiBpbnQgcXVvdGFfbmJf cGVybXNfcGVyX25vZGUgPSA1OworaW50IHF1b3RhX3RyYW5zX25vZGVzID0g MTAyNDsKIGludCBxdW90YV9yZXFfb3V0c3RhbmRpbmcgPSAyMDsKIAogdW5z aWduZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyA9IDIwMDAwOwpA QCAtNTAyLDYgKzUwMyw3IEBAIHN0cnVjdCBub2RlICpyZWFkX25vZGUoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAlUREJf REFUQSBrZXksIGRhdGE7CiAJc3RydWN0IHhzX3RkYl9yZWNvcmRfaGRyICpo ZHI7CiAJc3RydWN0IG5vZGUgKm5vZGU7CisJaW50IGVycjsKIAogCW5vZGUg PSB0YWxsb2MoY3R4LCBzdHJ1Y3Qgbm9kZSk7CiAJaWYgKCFub2RlKSB7CkBA IC01MjMsMTQgKzUyNSwxMyBAQCBzdHJ1Y3Qgbm9kZSAqcmVhZF9ub2RlKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsCiAJaWYg KGRhdGEuZHB0ciA9PSBOVUxMKSB7CiAJCWlmICh0ZGJfZXJyb3IodGRiX2N0 eCkgPT0gVERCX0VSUl9OT0VYSVNUKSB7CiAJCQlub2RlLT5nZW5lcmF0aW9u ID0gTk9fR0VORVJBVElPTjsKLQkJCWFjY2Vzc19ub2RlKGNvbm4sIG5vZGUs IE5PREVfQUNDRVNTX1JFQUQsIE5VTEwpOwotCQkJZXJybm8gPSBFTk9FTlQ7 CisJCQllcnIgPSBhY2Nlc3Nfbm9kZShjb25uLCBub2RlLCBOT0RFX0FDQ0VT U19SRUFELCBOVUxMKTsKKwkJCWVycm5vID0gZXJyID8gOiBFTk9FTlQ7CiAJ CX0gZWxzZSB7CiAJCQlsb2coIlREQiBlcnJvciBvbiByZWFkOiAlcyIsIHRk Yl9lcnJvcnN0cih0ZGJfY3R4KSk7CiAJCQllcnJubyA9IEVJTzsKIAkJfQot CQl0YWxsb2NfZnJlZShub2RlKTsKLQkJcmV0dXJuIE5VTEw7CisJCWdvdG8g ZXJyb3I7CiAJfQogCiAJbm9kZS0+cGFyZW50ID0gTlVMTDsKQEAgLTU0NSwx OSArNTQ2LDM2IEBAIHN0cnVjdCBub2RlICpyZWFkX25vZGUoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAogCS8qIFBlcm1p c3Npb25zIGFyZSBzdHJ1Y3QgeHNfcGVybWlzc2lvbnMuICovCiAJbm9kZS0+ cGVybXMucCA9IGhkci0+cGVybXM7Ci0JaWYgKGRvbWFpbl9hZGp1c3Rfbm9k ZV9wZXJtcyhjb25uLCBub2RlKSkgewotCQl0YWxsb2NfZnJlZShub2RlKTsK LQkJcmV0dXJuIE5VTEw7Ci0JfQorCWlmIChkb21haW5fYWRqdXN0X25vZGVf cGVybXMoY29ubiwgbm9kZSkpCisJCWdvdG8gZXJyb3I7CiAKIAkvKiBEYXRh IGlzIGJpbmFyeSBibG9iICh1c3VhbGx5IGFzY2lpLCBubyBudWwpLiAqLwog CW5vZGUtPmRhdGEgPSBub2RlLT5wZXJtcy5wICsgaGRyLT5udW1fcGVybXM7 CiAJLyogQ2hpbGRyZW4gaXMgc3RyaW5ncywgbnVsIHNlcGFyYXRlZC4gKi8K IAlub2RlLT5jaGlsZHJlbiA9IG5vZGUtPmRhdGEgKyBub2RlLT5kYXRhbGVu OwogCi0JYWNjZXNzX25vZGUoY29ubiwgbm9kZSwgTk9ERV9BQ0NFU1NfUkVB RCwgTlVMTCk7CisJaWYgKGFjY2Vzc19ub2RlKGNvbm4sIG5vZGUsIE5PREVf QUNDRVNTX1JFQUQsIE5VTEwpKQorCQlnb3RvIGVycm9yOwogCiAJcmV0dXJu IG5vZGU7CisKKyBlcnJvcjoKKwllcnIgPSBlcnJubzsKKwl0YWxsb2NfZnJl ZShub2RlKTsKKwllcnJubyA9IGVycjsKKwlyZXR1cm4gTlVMTDsKK30KKwor c3RhdGljIGJvb2wgcmVhZF9ub2RlX2Nhbl9wcm9wYWdhdGVfZXJybm8odm9p ZCkKK3sKKwkvKgorCSAqIDIgZXJyb3IgY2FzZXMgZm9yIHJlYWRfbm9kZSgp IGNhbiBhbHdheXMgYmUgcHJvcGFnYXRlZCB1cDoKKwkgKiBFTk9NRU0sIGJl Y2F1c2UgdGhpcyBoYXMgbm90aGluZyB0byBkbyB3aXRoIHRoZSBub2RlIGJl aW5nIGluIHRoZQorCSAqIGRhdGEgYmFzZSBvciBub3QsIGJ1dCBpcyBjYXVz ZWQgYnkgYSBnZW5lcmFsIGxhY2sgb2YgbWVtb3J5LgorCSAqIEVOT1NQQywg YmVjYXVzZSB0aGlzIGlzIHJlbGF0ZWQgdG8gaGl0dGluZyBxdW90YSBsaW1p dHMgd2hpY2ggbmVlZAorCSAqIHRvIGJlIHJlc3BlY3RlZC4KKwkgKi8KKwly ZXR1cm4gZXJybm8gPT0gRU5PTUVNIHx8IGVycm5vID09IEVOT1NQQzsKIH0K IAogaW50IHdyaXRlX25vZGVfcmF3KHN0cnVjdCBjb25uZWN0aW9uICpjb25u LCBUREJfREFUQSAqa2V5LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKQEAgLTY3Miw3 ICs2OTAsNyBAQCBzdGF0aWMgaW50IGFza19wYXJlbnRzKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsCiAJCW5vZGUgPSByZWFk X25vZGUoY29ubiwgY3R4LCBuYW1lKTsKIAkJaWYgKG5vZGUpCiAJCQlicmVh azsKLQkJaWYgKGVycm5vID09IEVOT01FTSkKKwkJaWYgKHJlYWRfbm9kZV9j YW5fcHJvcGFnYXRlX2Vycm5vKCkpCiAJCQlyZXR1cm4gZXJybm87CiAJfSB3 aGlsZSAoIXN0cmVxKG5hbWUsICIvIikpOwogCkBAIC03MzUsNyArNzUzLDcg QEAgc3RhdGljIHN0cnVjdCBub2RlICpnZXRfbm9kZShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwKIAkJfQogCX0KIAkvKiBDbGVhbiB1cCBlcnJubyBpZiB0 aGV5IHdlcmVuJ3Qgc3VwcG9zZWQgdG8ga25vdy4gKi8KLQlpZiAoIW5vZGUg JiYgZXJybm8gIT0gRU5PTUVNKQorCWlmICghbm9kZSAmJiAhcmVhZF9ub2Rl X2Nhbl9wcm9wYWdhdGVfZXJybm8oKSkKIAkJZXJybm8gPSBlcnJub19mcm9t X3BhcmVudHMoY29ubiwgY3R4LCBuYW1lLCBlcnJubywgcGVybSk7CiAJcmV0 dXJuIG5vZGU7CiB9CkBAIC0xMTE3LDcgKzExMzUsNyBAQCBzdGF0aWMgc3Ry dWN0IG5vZGUgKmNvbnN0cnVjdF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCBjb25zdCB2b2lkICpjdHgsCiAKIAkvKiBJZiBwYXJlbnQgZG9lc24n dCBleGlzdCwgY3JlYXRlIGl0LiAqLwogCXBhcmVudCA9IHJlYWRfbm9kZShj b25uLCBwYXJlbnRuYW1lLCBwYXJlbnRuYW1lKTsKLQlpZiAoIXBhcmVudCkK KwlpZiAoIXBhcmVudCAmJiBlcnJubyA9PSBFTk9FTlQpCiAJCXBhcmVudCA9 IGNvbnN0cnVjdF9ub2RlKGNvbm4sIGN0eCwgcGFyZW50bmFtZSk7CiAJaWYg KCFwYXJlbnQpCiAJCXJldHVybiBOVUxMOwpAQCAtMTM5Niw3ICsxNDE0LDcg QEAgc3RhdGljIGludCBfcm0oc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNv bnN0IHZvaWQgKmN0eCwgc3RydWN0IG5vZGUgKm5vZGUsCiAKIAlwYXJlbnQg PSByZWFkX25vZGUoY29ubiwgY3R4LCBwYXJlbnRuYW1lKTsKIAlpZiAoIXBh cmVudCkKLQkJcmV0dXJuIChlcnJubyA9PSBFTk9NRU0pID8gRU5PTUVNIDog RUlOVkFMOworCQlyZXR1cm4gcmVhZF9ub2RlX2Nhbl9wcm9wYWdhdGVfZXJy bm8oKSA/IGVycm5vIDogRUlOVkFMOwogCW5vZGUtPnBhcmVudCA9IHBhcmVu dDsKIAogCXJldHVybiBkZWxldGVfbm9kZShjb25uLCBjdHgsIHBhcmVudCwg bm9kZSwgZmFsc2UpOwpAQCAtMTQyNCw3ICsxNDQyLDcgQEAgc3RhdGljIGlu dCBkb19ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1ZmZl cmVkX2RhdGEgKmluKQogCQkJCXJldHVybiAwOwogCQkJfQogCQkJLyogUmVz dG9yZSBlcnJubywganVzdCBpbiBjYXNlLiAqLwotCQkJaWYgKGVycm5vICE9 IEVOT01FTSkKKwkJCWlmICghcmVhZF9ub2RlX2Nhbl9wcm9wYWdhdGVfZXJy bm8oKSkKIAkJCQllcnJubyA9IEVOT0VOVDsKIAkJfQogCQlyZXR1cm4gZXJy bm87CkBAIC0yMTc3LDYgKzIxOTUsOCBAQCBzdGF0aWMgdm9pZCB1c2FnZSh2 b2lkKQogIiAgLUEsIC0tcGVybS1uYiA8bmI+ICAgICAgbGltaXQgdGhlIG51 bWJlciBvZiBwZXJtaXNzaW9ucyBwZXIgbm9kZSxcbiIKICIgIC1RLCAtLXF1 b3RhIDx3aGF0Pj08bmI+IHNldCB0aGUgcXVvdGEgPHdoYXQ+IHRvIHRoZSB2 YWx1ZSA8bmI+LCBhbGxvd2VkXG4iCiAiICAgICAgICAgICAgICAgICAgICAg ICAgICBxdW90YXMgYXJlOlxuIgorIiAgICAgICAgICAgICAgICAgICAgICAg ICAgdHJhbnNhY3Rpb24tbm9kZXM6IG51bWJlciBvZiBhY2Nlc3NlZCBub2Rl IHBlclxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHRyYW5zYWN0aW9uXG4iCiAiICAgICAgICAgICAgICAgICAg ICAgICAgICBvdXRzdGFuZGluZzogbnVtYmVyIG9mIG91dHN0YW5kaW5nIHJl cXVlc3RzXG4iCiAiICAtdywgLS10aW1lb3V0IDx3aGF0Pj08c2Vjb25kcz4g ICBzZXQgdGhlIHRpbWVvdXQgaW4gc2Vjb25kcyBmb3IgPHdoYXQ+LFxuIgog IiAgICAgICAgICAgICAgICAgICAgICAgICAgYWxsb3dlZCB0aW1lb3V0IGNh bmRpZGF0ZXMgYXJlOlxuIgpAQCAtMjI1OCw2ICsyMjc4LDggQEAgc3RhdGlj IHZvaWQgc2V0X3F1b3RhKGNvbnN0IGNoYXIgKmFyZykKIAl2YWwgPSBnZXRf b3B0dmFsX2ludChlcSArIDEpOwogCWlmICh3aGF0X21hdGNoZXMoYXJnLCAi b3V0c3RhbmRpbmciKSkKIAkJcXVvdGFfcmVxX291dHN0YW5kaW5nID0gdmFs OworCWVsc2UgaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJ0cmFuc2FjdGlvbi1u b2RlcyIpKQorCQlxdW90YV90cmFuc19ub2RlcyA9IHZhbDsKIAllbHNlCiAJ CWJhcmYoInVua25vd24gcXVvdGEgXCIlc1wiXG4iLCBhcmcpOwogfQpkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKaW5kZXggOThkYjRhZmNh YWJmLi43ZTM3MTI1M2QyZDEgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuaApAQCAtMzQsNiArMzQsNyBAQAogI2luY2x1ZGUgImxpc3Qu aCIKICNpbmNsdWRlICJ0ZGIuaCIKICNpbmNsdWRlICJoYXNodGFibGUuaCIK KyNpbmNsdWRlICJ1dGlscy5oIgogCiAvKiBERUZBVUxUX0JVRkZFUl9TSVpF IHNob3VsZCBiZSBsYXJnZSBlbm91Z2ggZm9yIGVhY2ggZXJybm8gc3RyaW5n LiAqLwogI2RlZmluZSBERUZBVUxUX0JVRkZFUl9TSVpFIDE2CkBAIC0yMjMs NiArMjI0LDcgQEAgZXh0ZXJuIGludCBkb20wX2V2ZW50OwogZXh0ZXJuIGlu dCBwcml2X2RvbWlkOwogZXh0ZXJuIGludCBxdW90YV9uYl9lbnRyeV9wZXJf ZG9tYWluOwogZXh0ZXJuIGludCBxdW90YV9yZXFfb3V0c3RhbmRpbmc7Citl eHRlcm4gaW50IHF1b3RhX3RyYW5zX25vZGVzOwogCiBleHRlcm4gdW5zaWdu ZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIApkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwppbmRleCBi ZjJmZGE4MjM0YjMuLjc3OGI3ZTQzOWNiMyAxMDA2NDQKLS0tIGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKKysrIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKQEAgLTE1Niw2ICsx NTYsOSBAQCBzdHJ1Y3QgdHJhbnNhY3Rpb24KIAkvKiBDb25uZWN0aW9uLWxv Y2FsIGlkZW50aWZpZXIgZm9yIHRoaXMgdHJhbnNhY3Rpb24uICovCiAJdWlu dDMyX3QgaWQ7CiAKKwkvKiBOb2RlIGNvdW50ZXIuICovCisJdW5zaWduZWQg aW50IG5vZGVzOworCiAJLyogR2VuZXJhdGlvbiB3aGVuIHRyYW5zYWN0aW9u IHN0YXJ0ZWQuICovCiAJdWludDY0X3QgZ2VuZXJhdGlvbjsKIApAQCAtMjY2 LDYgKzI2OSwxMSBAQCBpbnQgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAogCiAJaSA9IGZpbmRfYWNj ZXNzZWRfbm9kZSh0cmFucywgbm9kZS0+bmFtZSk7CiAJaWYgKCFpKSB7CisJ CWlmICh0cmFucy0+bm9kZXMgPj0gcXVvdGFfdHJhbnNfbm9kZXMgJiYKKwkJ ICAgIGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikpIHsKKwkJCXJldCA9 IEVOT1NQQzsKKwkJCWdvdG8gZXJyOworCQl9CiAJCWkgPSB0YWxsb2NfemVy byh0cmFucywgc3RydWN0IGFjY2Vzc2VkX25vZGUpOwogCQlpZiAoIWkpCiAJ CQlnb3RvIG5vbWVtOwpAQCAtMzAzLDYgKzMxMSw3IEBAIGludCBhY2Nlc3Nf bm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKm5v ZGUsCiAJCQkJaS0+dGFfbm9kZSA9IHRydWU7CiAJCQl9CiAJCX0KKwkJdHJh bnMtPm5vZGVzKys7CiAJCWxpc3RfYWRkX3RhaWwoJmktPmxpc3QsICZ0cmFu cy0+YWNjZXNzZWQpOwogCX0KIApkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmggYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfdHJhbnNhY3Rpb24uaAppbmRleCAwMDkzY2FjODA3ZTMuLmUz Y2JkNmIyMzA5NSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX3RyYW5zYWN0aW9uLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX3RyYW5zYWN0aW9uLmgKQEAgLTM5LDggKzM5LDggQEAgdm9pZCB0cmFu c2FjdGlvbl9lbnRyeV9pbmMoc3RydWN0IHRyYW5zYWN0aW9uICp0cmFucywg dW5zaWduZWQgaW50IGRvbWlkKTsKIHZvaWQgdHJhbnNhY3Rpb25fZW50cnlf ZGVjKHN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnMsIHVuc2lnbmVkIGludCBk b21pZCk7CiAKIC8qIFRoaXMgbm9kZSB3YXMgYWNjZXNzZWQuICovCi1pbnQg YWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlLAotICAgICAgICAgICAgICAgIGVudW0gbm9kZV9hY2Nlc3Nf dHlwZSB0eXBlLCBUREJfREFUQSAqa2V5KTsKK2ludCBfX211c3RfY2hlY2sg YWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbnVt IG5vZGVfYWNjZXNzX3R5cGUgdHlwZSwgVERCX0RBVEEgKmtleSk7CiAKIC8q IFF1ZXVlIHdhdGNoZXMgZm9yIGEgbW9kaWZpZWQgbm9kZS4gKi8KIHZvaWQg cXVldWVfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qg Y2hhciAqbmFtZSwgYm9vbCB3YXRjaF9leGFjdCk7Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-10.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-10.patch" Content-Transfer-Encoding: base64 RnJvbSA4M2RhOTM4ZTdkNjZhODZmZDJlMDZhMThhYmE1YTkwYzUyYWM0YmNi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IG1vdmUgdGhl IGNhbGwgb2Ygc2V0dXBfc3RydWN0dXJlKCkgdG8gZG9tMAogaW50cm9kdWN0 aW9uCgpTZXR0aW5nIHVwIHRoZSBiYXNpYyBzdHJ1Y3R1cmUgd2hlbiBpbnRy b2R1Y2luZyBkb20wIGhhcyB0aGUgYWR2YW50YWdlCnRvIGJlIGFibGUgdG8g YWRkIHByb3BlciBub2RlIG1lbW9yeSBhY2NvdW50aW5nIGZvciB0aGUgYWRk ZWQgbm9kZXMKbGF0ZXIuCgpUaGlzIG1ha2VzIGl0IHBvc3NpYmxlIHRvIGRv IHByb3BlciBub2RlIGFjY291bnRpbmcsIHRvby4KCkFuIGFkZGl0aW9uYWwg cmVxdWlyZW1lbnQgdG8gbWFrZSB0aGF0IHdvcmsgZmluZSBpcyB0byBjb3Jy ZWN0IHRoZQpvd25lciBvZiB0aGUgY3JlYXRlZCBub2RlcyB0byBiZSBkb20w X2RvbWlkIGluc3RlYWQgb2YgZG9taWQgMC4KClRoaXMgaXMgcGFydCBvZiBY U0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMK aW5kZXggZmY2NDliNzU0NC4uODEyM2E2NWE1OCAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0xODM0LDcgKzE4MzQsOCBAQCBz dGF0aWMgaW50IHRkYl9mbGFnczsKIHN0YXRpYyB2b2lkIG1hbnVhbF9ub2Rl KGNvbnN0IGNoYXIgKm5hbWUsIGNvbnN0IGNoYXIgKmNoaWxkKQogewogCXN0 cnVjdCBub2RlICpub2RlOwotCXN0cnVjdCB4c19wZXJtaXNzaW9ucyBwZXJt cyA9IHsgLmlkID0gMCwgLnBlcm1zID0gWFNfUEVSTV9OT05FIH07CisJc3Ry dWN0IHhzX3Blcm1pc3Npb25zIHBlcm1zID0geyAuaWQgPSBkb20wX2RvbWlk LAorCQkJCQkucGVybXMgPSBYU19QRVJNX05PTkUgfTsKIAogCW5vZGUgPSB0 YWxsb2NfemVybyhOVUxMLCBzdHJ1Y3Qgbm9kZSk7CiAJaWYgKCFub2RlKQpA QCAtMTg3Myw3ICsxODc0LDcgQEAgc3RhdGljIHZvaWQgdGRiX2xvZ2dlcihU REJfQ09OVEVYVCAqdGRiLCBpbnQgbGV2ZWwsIGNvbnN0IGNoYXIgKiBmbXQs IC4uLikKIAl9CiB9CiAKLXN0YXRpYyB2b2lkIHNldHVwX3N0cnVjdHVyZSh2 b2lkKQordm9pZCBzZXR1cF9zdHJ1Y3R1cmUodm9pZCkKIHsKIAljaGFyICp0 ZGJuYW1lOwogCXRkYm5hbWUgPSB0YWxsb2Nfc3RyZHVwKHRhbGxvY19hdXRv ZnJlZV9jb250ZXh0KCksIHhzX2RhZW1vbl90ZGIoKSk7CkBAIC0xODkxLDYg KzE4OTIsNyBAQCBzdGF0aWMgdm9pZCBzZXR1cF9zdHJ1Y3R1cmUodm9pZCkK IAltYW51YWxfbm9kZSgiLyIsICJ0b29sIik7CiAJbWFudWFsX25vZGUoIi90 b29sIiwgInhlbnN0b3JlZCIpOwogCW1hbnVhbF9ub2RlKCIvdG9vbC94ZW5z dG9yZWQiLCBOVUxMKTsKKwlkb21haW5fZW50cnlfZml4KGRvbTBfZG9taWQs IDMsIHRydWUpOwogCiAJY2hlY2tfc3RvcmUoKTsKIH0KQEAgLTIzODksOSAr MjM5MSw2IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAK IAlpbml0X3BpcGUocmVvcGVuX2xvZ19waXBlKTsKIAotCS8qIFNldHVwIHRo ZSBkYXRhYmFzZSAqLwotCXNldHVwX3N0cnVjdHVyZSgpOwotCiAJLyogTGlz dGVuIHRvIGh5cGVydmlzb3IuICovCiAJaWYgKCFub19kb21haW5faW5pdCkK IAkJZG9tYWluX2luaXQoKTsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5oCmluZGV4IDdlMzcxMjUzZDIuLmQ5NWU0MjYyYTkgMTAwNjQ0Ci0t LSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKKysrIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMTk1LDYgKzE5NSw3 IEBAIGludCB3cml0ZV9ub2RlX3JhdyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgVERCX0RBVEEgKmtleSwgc3RydWN0IG5vZGUgKm5vZGUsCiBzdHJ1Y3Qg bm9kZSAqcmVhZF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25z dCB2b2lkICpjdHgsCiAJCSAgICAgICBjb25zdCBjaGFyICpuYW1lKTsKIAor dm9pZCBzZXR1cF9zdHJ1Y3R1cmUodm9pZCk7CiBzdHJ1Y3QgY29ubmVjdGlv biAqbmV3X2Nvbm5lY3Rpb24oY29ubndyaXRlZm5fdCAqd3JpdGUsIGNvbm5y ZWFkZm5fdCAqcmVhZCk7CiB2b2lkIGNoZWNrX3N0b3JlKHZvaWQpOwogdm9p ZCBjb3JydXB0KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFy ICpmbXQsIC4uLik7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9t YWluLmMKaW5kZXggMzA2ZTEyMzU4Yi4uYmVkNmM0ZTA1YSAxMDA2NDQKLS0t IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCisrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYwpAQCAtNzMyLDYgKzcz Miw4IEBAIHN0YXRpYyBpbnQgZG9tMF9pbml0KHZvaWQpCiAJaWYgKGRvbTAt PmludGVyZmFjZSA9PSBOVUxMKQogCQlyZXR1cm4gLTE7CiAKKwlzZXR1cF9z dHJ1Y3R1cmUoKTsKKwogCXRhbGxvY19zdGVhbChkb20wLT5jb25uLCBkb20w KTsgCiAKIAl4ZW5ldnRjaG5fbm90aWZ5KHhjZV9oYW5kbGUsIGRvbTAtPnBv cnQpOwotLSAKMi4zNS4zCgo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-11.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-11.patch" Content-Transfer-Encoding: base64 RnJvbSA1NmJiMDMwNjc4NDNiODBmZmQ4NWQ4OTYxMGU3MjgzZDgwZDQyMzM1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBpbmZy YXN0cnVjdHVyZSB0byBrZWVwIHRyYWNrIG9mIHBlciBkb21haW4gbWVtb3J5 CiB1c2FnZQoKVGhlIGFtb3VudCBvZiBtZW1vcnkgYSBkb21haW4gY2FuIGNv bnN1bWUgaW4gWGVuc3RvcmUgaXMgbGltaXRlZCBieQp2YXJpb3VzIHF1b3Rh IHRvZGF5LCBidXQgZXZlbiB3aXRoIHNhbmUgcXVvdGEgYSBkb21haW4gY2Fu IHN0aWxsCmNvbnN1bWUgcmF0aGVyIGxhcmdlIG1lbW9yeSBxdWFudGl0aWVz LgoKQWRkIHRoZSBpbmZyYXN0cnVjdHVyZSBmb3Iga2VlcGluZyB0cmFjayBv ZiB0aGUgYW1vdW50IG9mIG1lbW9yeSBhCmRvbWFpbiBpcyBjb25zdW1pbmcg aW4gWGVuc3RvcmUuIE5vdGUgdGhhdCB0aGlzIGlzIG9ubHkgdGhlIG1lbW9y eSBhCmRvbWFpbiBoYXMgZGlyZWN0IGNvbnRyb2wgb3Zlciwgc28gYW55IGlu dGVybmFsIGFkbWluaXN0cmF0aW9uIGRhdGEKbmVlZGVkIGJ5IFhlbnN0b3Jl IG9ubHkgaXMgbm90IGJlaW5nIGFjY291bnRlZCBmb3IuCgpUaGVyZSBhcmUg dHdvIHF1b3RhcyBkZWZpbmVkOiBhIHNvZnQgcXVvdGEgd2hpY2ggd2lsbCBy ZXN1bHQgaW4gYQp3YXJuaW5nIGlzc3VlZCB2aWEgc3lzbG9nKCkgd2hlbiBp dCBpcyBleGNlZWRlZCwgYW5kIGEgaGFyZCBxdW90YQpyZXN1bHRpbmcgaW4g YSBzdG9wIG9mIGFjY2VwdGluZyBmdXJ0aGVyIHJlcXVlc3RzIG9yIHdhdGNo IGV2ZW50cyBhcwpsb25nIGFzIHRoZSBoYXJkIHF1b3RhIHdvdWxkIGJlIHZp b2xhdGVkIGJ5IGFjY2VwdGluZyB0aG9zZS4KClNldHRpbmcgYW55IG9mIHRo b3NlIHF1b3RhcyB0byAwIHdpbGwgZGlzYWJsZSBpdC4KCkFzIGRlZmF1bHQg dmFsdWVzIHVzZSAyTUIgcGVyIGRvbWFpbiBmb3IgdGhlIHNvZnQgbGltaXQg KHRoaXMgYmFzaWNhbGx5CmNvdmVycyB0aGUgYWxsb3dlZCBjYXNlIHRvIGNy ZWF0ZSAxMDAwIG5vZGVzIG5lZWRpbmcgMmtCIGVhY2gpLCBhbmQKMi41TUIg Zm9yIHRoZSBoYXJkIGxpbWl0LgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYu CgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNv bT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwppbmRl eCA4MTIzYTY1YTU4YmYuLjlmZDgzZWEwMjU5YSAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0xMDcsNiArMTA3LDggQEAgaW50 IHF1b3RhX21heF90cmFuc2FjdGlvbiA9IDEwOwogaW50IHF1b3RhX25iX3Bl cm1zX3Blcl9ub2RlID0gNTsKIGludCBxdW90YV90cmFuc19ub2RlcyA9IDEw MjQ7CiBpbnQgcXVvdGFfcmVxX291dHN0YW5kaW5nID0gMjA7CitpbnQgcXVv dGFfbWVtb3J5X3Blcl9kb21haW5fc29mdCA9IDIgKiAxMDI0ICogMTAyNDsg LyogMiBNQiAqLworaW50IHF1b3RhX21lbW9yeV9wZXJfZG9tYWluX2hhcmQg PSAyICogMTAyNCAqIDEwMjQgKyA1MTIgKiAxMDI0OyAvKiAyLjUgTUIgKi8K IAogdW5zaWduZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyA9IDIw MDAwOwogCkBAIC0yMTk5LDcgKzIyMDEsMTQgQEAgc3RhdGljIHZvaWQgdXNh Z2Uodm9pZCkKICIgICAgICAgICAgICAgICAgICAgICAgICAgIHF1b3RhcyBh cmU6XG4iCiAiICAgICAgICAgICAgICAgICAgICAgICAgICB0cmFuc2FjdGlv bi1ub2RlczogbnVtYmVyIG9mIGFjY2Vzc2VkIG5vZGUgcGVyXG4iCiAiICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHJh bnNhY3Rpb25cbiIKKyIgICAgICAgICAgICAgICAgICAgICAgICAgIG1lbW9y eTogdG90YWwgdXNlZCBtZW1vcnkgcGVyIGRvbWFpbiBmb3Igbm9kZXMsXG4i CisiICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRyYW5zYWN0 aW9ucywgd2F0Y2hlcyBhbmQgcmVxdWVzdHMsIGFib3ZlXG4iCisiICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHdoaWNoIFhlbnN0b3JlIHdp bGwgc3RvcCB0YWxraW5nIHRvIGRvbWFpblxuIgogIiAgICAgICAgICAgICAg ICAgICAgICAgICAgb3V0c3RhbmRpbmc6IG51bWJlciBvZiBvdXRzdGFuZGlu ZyByZXF1ZXN0c1xuIgorIiAgLXEsIC0tcXVvdGEtc29mdCA8d2hhdD49PG5i PiBzZXQgYSBzb2Z0IHF1b3RhIDx3aGF0PiB0byB0aGUgdmFsdWUgPG5iPixc biIKKyIgICAgICAgICAgICAgICAgICAgICAgICAgIGNhdXNpbmcgYSB3YXJu aW5nIHRvIGJlIGlzc3VlZCB2aWEgc3lzbG9nKCkgaWYgdGhlXG4iCisiICAg ICAgICAgICAgICAgICAgICAgICAgICBsaW1pdCBpcyB2aW9sYXRlZCwgYWxs b3dlZCBxdW90YXMgYXJlOlxuIgorIiAgICAgICAgICAgICAgICAgICAgICAg ICAgbWVtb3J5OiBzZWUgYWJvdmVcbiIKICIgIC13LCAtLXRpbWVvdXQgPHdo YXQ+PTxzZWNvbmRzPiAgIHNldCB0aGUgdGltZW91dCBpbiBzZWNvbmRzIGZv ciA8d2hhdD4sXG4iCiAiICAgICAgICAgICAgICAgICAgICAgICAgICBhbGxv d2VkIHRpbWVvdXQgY2FuZGlkYXRlcyBhcmU6XG4iCiAiICAgICAgICAgICAg ICAgICAgICAgICAgICB3YXRjaC1ldmVudDogdGltZSBhIHdhdGNoLWV2ZW50 IGlzIGtlcHQgcGVuZGluZ1xuIgpAQCAtMjIyNSw2ICsyMjM0LDcgQEAgc3Rh dGljIHN0cnVjdCBvcHRpb24gb3B0aW9uc1tdID0gewogCXsgInRyYW5zYWN0 aW9uIiwgMSwgTlVMTCwgJ3QnIH0sCiAJeyAicGVybS1uYiIsIDEsIE5VTEws ICdBJyB9LAogCXsgInF1b3RhIiwgMSwgTlVMTCwgJ1EnIH0sCisJeyAicXVv dGEtc29mdCIsIDEsIE5VTEwsICdxJyB9LAogCXsgInRpbWVvdXQiLCAxLCBO VUxMLCAndycgfSwKIAl7ICJuby1yZWNvdmVyeSIsIDAsIE5VTEwsICdSJyB9 LAogCXsgImludGVybmFsLWRiIiwgMCwgTlVMTCwgJ0knIH0sCkBAIC0yMjcw LDcgKzIyODAsNyBAQCBzdGF0aWMgdm9pZCBzZXRfdGltZW91dChjb25zdCBj aGFyICphcmcpCiAJCWJhcmYoInVua25vd24gdGltZW91dCBcIiVzXCJcbiIs IGFyZyk7CiB9CiAKLXN0YXRpYyB2b2lkIHNldF9xdW90YShjb25zdCBjaGFy ICphcmcpCitzdGF0aWMgdm9pZCBzZXRfcXVvdGEoY29uc3QgY2hhciAqYXJn LCBib29sIHNvZnQpCiB7CiAJY29uc3QgY2hhciAqZXEgPSBzdHJjaHIoYXJn LCAnPScpOwogCWludCB2YWw7CkBAIC0yMjc4LDExICsyMjg4LDE2IEBAIHN0 YXRpYyB2b2lkIHNldF9xdW90YShjb25zdCBjaGFyICphcmcpCiAJaWYgKCFl cSkKIAkJYmFyZigicXVvdGFzIG11c3QgYmUgc3BlY2lmaWVkIHZpYSA8d2hh dD49PG5iPlxuIik7CiAJdmFsID0gZ2V0X29wdHZhbF9pbnQoZXEgKyAxKTsK LQlpZiAod2hhdF9tYXRjaGVzKGFyZywgIm91dHN0YW5kaW5nIikpCisJaWYg KHdoYXRfbWF0Y2hlcyhhcmcsICJvdXRzdGFuZGluZyIpICYmICFzb2Z0KQog CQlxdW90YV9yZXFfb3V0c3RhbmRpbmcgPSB2YWw7Ci0JZWxzZSBpZiAod2hh dF9tYXRjaGVzKGFyZywgInRyYW5zYWN0aW9uLW5vZGVzIikpCisJZWxzZSBp ZiAod2hhdF9tYXRjaGVzKGFyZywgInRyYW5zYWN0aW9uLW5vZGVzIikgJiYg IXNvZnQpCiAJCXF1b3RhX3RyYW5zX25vZGVzID0gdmFsOwotCWVsc2UKKwll bHNlIGlmICh3aGF0X21hdGNoZXMoYXJnLCAibWVtb3J5IikpIHsKKwkJaWYg KHNvZnQpCisJCQlxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9zb2Z0ID0gdmFs OworCQllbHNlCisJCQlxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJkID0g dmFsOworCX0gZWxzZQogCQliYXJmKCJ1bmtub3duIHF1b3RhIFwiJXNcIlxu IiwgYXJnKTsKIH0KIApAQCAtMjI5Nyw3ICsyMzEyLDcgQEAgaW50IG1haW4o aW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAlpbnQgdGltZW91dDsKIAogCi0J d2hpbGUgKChvcHQgPSBnZXRvcHRfbG9uZyhhcmdjLCBhcmd2LCAiREU6RjpI TlBTOnQ6QTpROlQ6UlZXOnc6Iiwgb3B0aW9ucywKKwl3aGlsZSAoKG9wdCA9 IGdldG9wdF9sb25nKGFyZ2MsIGFyZ3YsICJERTpGOkhOUFM6dDpBOlE6cTpU OlJWVzp3OiIsIG9wdGlvbnMsCiAJCQkJICBOVUxMKSkgIT0gLTEpIHsKIAkJ c3dpdGNoIChvcHQpIHsKIAkJY2FzZSAnRCc6CkBAIC0yMzQzLDcgKzIzNTgs MTAgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAkJCXF1 b3RhX25iX3Blcm1zX3Blcl9ub2RlID0gc3RydG9sKG9wdGFyZywgTlVMTCwg MTApOwogCQkJYnJlYWs7CiAJCWNhc2UgJ1EnOgotCQkJc2V0X3F1b3RhKG9w dGFyZyk7CisJCQlzZXRfcXVvdGEob3B0YXJnLCBmYWxzZSk7CisJCQlicmVh azsKKwkJY2FzZSAncSc6CisJCQlzZXRfcXVvdGEob3B0YXJnLCB0cnVlKTsK IAkJCWJyZWFrOwogCQljYXNlICd3JzoKIAkJCXNldF90aW1lb3V0KG9wdGFy Zyk7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29y ZS5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCBk OTVlNDI2MmE5MWUuLjRlNTMwNzJlNjM3YyAxMDA2NDQKLS0tIGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAorKysgYi90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfY29yZS5oCkBAIC0yMjYsNiArMjI2LDggQEAgZXh0ZXJu IGludCBwcml2X2RvbWlkOwogZXh0ZXJuIGludCBxdW90YV9uYl9lbnRyeV9w ZXJfZG9tYWluOwogZXh0ZXJuIGludCBxdW90YV9yZXFfb3V0c3RhbmRpbmc7 CiBleHRlcm4gaW50IHF1b3RhX3RyYW5zX25vZGVzOworZXh0ZXJuIGludCBx dW90YV9tZW1vcnlfcGVyX2RvbWFpbl9zb2Z0OworZXh0ZXJuIGludCBxdW90 YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJkOwogCiBleHRlcm4gdW5zaWduZWQg aW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIApkaWZmIC0tZ2l0IGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IDBlMTE2ZTVjM2Q2My4u Nzg2M2ZhNTU0ODdkIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2RvbWFpbi5jCkBAIC04MCw2ICs4MCwxMyBAQCBzdHJ1Y3QgZG9tYWluCiAJ LyogbnVtYmVyIG9mIGVudHJ5IGZyb20gdGhpcyBkb21haW4gaW4gdGhlIHN0 b3JlICovCiAJaW50IG5iZW50cnk7CiAKKwkvKiBBbW91bnQgb2YgbWVtb3J5 IGFsbG9jYXRlZCBmb3IgdGhpcyBkb21haW4uICovCisJaW50IG1lbW9yeTsK Kwlib29sIHNvZnRfcXVvdGFfcmVwb3J0ZWQ7CisJYm9vbCBoYXJkX3F1b3Rh X3JlcG9ydGVkOworCXRpbWVfdCBtZW1fbGFzdF9tc2c7CisjZGVmaW5lIE1F TV9XQVJOX01JTlRJTUVfU0VDIDEwCisKIAkvKiBudW1iZXIgb2Ygd2F0Y2gg Zm9yIHRoaXMgZG9tYWluICovCiAJaW50IG5id2F0Y2g7CiAKQEAgLTI5Myw2 ICszMDAsOSBAQCBib29sIGRvbWFpbl9jYW5fcmVhZChzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubikKIAkJCXJldHVybiBmYWxzZTsKIAkJaWYgKGNvbm4tPmRv bWFpbi0+bmJvdXRzdGFuZGluZyA+PSBxdW90YV9yZXFfb3V0c3RhbmRpbmcp CiAJCQlyZXR1cm4gZmFsc2U7CisJCWlmIChjb25uLT5kb21haW4tPm1lbW9y eSA+PSBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJkICYmCisJCSAgICBx dW90YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJkKQorCQkJcmV0dXJuIGZhbHNl OwogCX0KIAogCWlmIChjb25uLT5pc19pZ25vcmVkKQpAQCAtOTM3LDYgKzk0 Nyw4OSBAQCBpbnQgZG9tYWluX2VudHJ5KHN0cnVjdCBjb25uZWN0aW9uICpj b25uKQogCQk6IDA7CiB9CiAKK3N0YXRpYyBib29sIGRvbWFpbl9jaGtfcXVv dGEoc3RydWN0IGRvbWFpbiAqZG9tYWluLCBpbnQgbWVtKQoreworCXRpbWVf dCBub3c7CisKKwlpZiAoIWRvbWFpbiB8fCAhZG9taWRfaXNfdW5wcml2aWxl Z2VkKGRvbWFpbi0+ZG9taWQpIHx8CisJICAgIChkb21haW4tPmNvbm4gJiYg ZG9tYWluLT5jb25uLT5pc19pZ25vcmVkKSkKKwkJcmV0dXJuIGZhbHNlOwor CisJbm93ID0gdGltZShOVUxMKTsKKworCWlmIChtZW0gPj0gcXVvdGFfbWVt b3J5X3Blcl9kb21haW5faGFyZCAmJgorCSAgICBxdW90YV9tZW1vcnlfcGVy X2RvbWFpbl9oYXJkKSB7CisJCWlmIChkb21haW4tPmhhcmRfcXVvdGFfcmVw b3J0ZWQpCisJCQlyZXR1cm4gdHJ1ZTsKKwkJc3lzbG9nKExPR19FUlIsICJE b21haW4gJXUgZXhjZWVkcyBoYXJkIG1lbW9yeSBxdW90YSwgWGVuc3RvcmUg aW50ZXJmYWNlIHRvIGRvbWFpbiBzdGFsbGVkXG4iLAorCQkgICAgICAgZG9t YWluLT5kb21pZCk7CisJCWRvbWFpbi0+bWVtX2xhc3RfbXNnID0gbm93Owor CQlkb21haW4tPmhhcmRfcXVvdGFfcmVwb3J0ZWQgPSB0cnVlOworCQlyZXR1 cm4gdHJ1ZTsKKwl9CisKKwlpZiAobm93IC0gZG9tYWluLT5tZW1fbGFzdF9t c2cgPj0gTUVNX1dBUk5fTUlOVElNRV9TRUMpIHsKKwkJaWYgKGRvbWFpbi0+ aGFyZF9xdW90YV9yZXBvcnRlZCkgeworCQkJZG9tYWluLT5tZW1fbGFzdF9t c2cgPSBub3c7CisJCQlkb21haW4tPmhhcmRfcXVvdGFfcmVwb3J0ZWQgPSBm YWxzZTsKKwkJCXN5c2xvZyhMT0dfSU5GTywgIkRvbWFpbiAldSBiZWxvdyBo YXJkIG1lbW9yeSBxdW90YSBhZ2FpblxuIiwKKwkJCSAgICAgICBkb21haW4t PmRvbWlkKTsKKwkJfQorCQlpZiAobWVtID49IHF1b3RhX21lbW9yeV9wZXJf ZG9tYWluX3NvZnQgJiYKKwkJICAgIHF1b3RhX21lbW9yeV9wZXJfZG9tYWlu X3NvZnQgJiYKKwkJICAgICFkb21haW4tPnNvZnRfcXVvdGFfcmVwb3J0ZWQp IHsKKwkJCWRvbWFpbi0+bWVtX2xhc3RfbXNnID0gbm93OworCQkJZG9tYWlu LT5zb2Z0X3F1b3RhX3JlcG9ydGVkID0gdHJ1ZTsKKwkJCXN5c2xvZyhMT0df V0FSTklORywgIkRvbWFpbiAldSBleGNlZWRzIHNvZnQgbWVtb3J5IHF1b3Rh XG4iLAorCQkJICAgICAgIGRvbWFpbi0+ZG9taWQpOworCQl9CisJCWlmICht ZW0gPCBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9zb2Z0ICYmCisJCSAgICBk b21haW4tPnNvZnRfcXVvdGFfcmVwb3J0ZWQpIHsKKwkJCWRvbWFpbi0+bWVt X2xhc3RfbXNnID0gbm93OworCQkJZG9tYWluLT5zb2Z0X3F1b3RhX3JlcG9y dGVkID0gZmFsc2U7CisJCQlzeXNsb2coTE9HX0lORk8sICJEb21haW4gJXUg YmVsb3cgc29mdCBtZW1vcnkgcXVvdGEgYWdhaW5cbiIsCisJCQkgICAgICAg ZG9tYWluLT5kb21pZCk7CisJCX0KKworCX0KKworCXJldHVybiBmYWxzZTsK K30KKworaW50IGRvbWFpbl9tZW1vcnlfYWRkKHVuc2lnbmVkIGludCBkb21p ZCwgaW50IG1lbSwgYm9vbCBub19xdW90YV9jaGVjaykKK3sKKwlzdHJ1Y3Qg ZG9tYWluICpkb21haW47CisKKwlkb21haW4gPSBmaW5kX2RvbWFpbl9zdHJ1 Y3QoZG9taWQpOworCWlmIChkb21haW4pIHsKKwkJLyoKKwkJICogZG9tYWlu X2Noa19xdW90YSgpIHdpbGwgcHJpbnQgd2FybmluZyBhbmQgYWxzbyBzdG9y ZSB3aGV0aGVyCisJCSAqIHRoZSBzb2Z0L2hhcmQgcXVvdGEgaGFzIGJlZW4g aGl0LiBTbyBjaGVjayBub19xdW90YV9jaGVjaworCQkgKiAqYWZ0ZXIqLgor CQkgKi8KKwkJaWYgKGRvbWFpbl9jaGtfcXVvdGEoZG9tYWluLCBkb21haW4t Pm1lbW9yeSArIG1lbSkgJiYKKwkJICAgICFub19xdW90YV9jaGVjaykKKwkJ CXJldHVybiBFTk9NRU07CisJCWRvbWFpbi0+bWVtb3J5ICs9IG1lbTsKKwl9 IGVsc2UgeworCQkvKgorCQkgKiBUaGUgZG9tYWluIHRoZSBtZW1vcnkgaXMg dG8gYmUgYWNjb3VudGVkIGZvciBzaG91bGQgYWx3YXlzCisJCSAqIGV4aXN0 LCBhcyBhY2NvdW50aW5nIGlzIGRvbmUgZWl0aGVyIGZvciBhIGRvbWFpbiBy ZWxhdGVkIHRvCisJCSAqIHRoZSBjdXJyZW50IGNvbm5lY3Rpb24sIG9yIGZv ciB0aGUgZG9tYWluIG93bmluZyBhIG5vZGUKKwkJICogKHdoaWNoIGlzIGFs d2F5cyBleGlzdGluZywgYXMgdGhlIG93bmVyIG9mIHRoZSBub2RlIGlzCisJ CSAqIHRlc3RlZCB0byBleGlzdCBhbmQgcmVwbGFjZWQgYnkgZG9taWQgMCBp ZiBub3QpLgorCQkgKiBTbyBub3QgZmluZGluZyB0aGUgcmVsYXRlZCBkb21h aW4gTVVTVCBiZSBhbiBlcnJvciBpbiB0aGUKKwkJICogZGF0YSBiYXNlLgor CQkgKi8KKwkJZXJybm8gPSBFTk9FTlQ7CisJCWNvcnJ1cHQoTlVMTCwgIkFj Y291bnRpbmcgY2FsbGVkIGZvciBub24tZXhpc3RpbmcgZG9tYWluICV1XG4i LAorCQkJZG9taWQpOworCQlyZXR1cm4gRU5PRU5UOworCX0KKworCXJldHVy biAwOworfQorCiB2b2lkIGRvbWFpbl93YXRjaF9pbmMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pCiB7CiAJaWYgKCFjb25uIHx8ICFjb25uLT5kb21haW4p CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWlu LmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgKaW5kZXgg NGVkZjFkYmE5NDI1Li4zYThjNmJhYjQ4YmEgMTAwNjQ0Ci0tLSBhL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaAorKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfZG9tYWluLmgKQEAgLTY0LDYgKzY0LDI2IEBAIGlu dCBkb21haW5fZW50cnlfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBz dHJ1Y3Qgbm9kZSAqKTsKIHZvaWQgZG9tYWluX2VudHJ5X2RlYyhzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKik7CiBpbnQgZG9tYWlu X2VudHJ5X2ZpeCh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBudW0sIGJvb2wg dXBkYXRlKTsKIGludCBkb21haW5fZW50cnkoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pOworaW50IGRvbWFpbl9tZW1vcnlfYWRkKHVuc2lnbmVkIGludCBk b21pZCwgaW50IG1lbSwgYm9vbCBub19xdW90YV9jaGVjayk7CisKKy8qCisg KiBkb21haW5fbWVtb3J5X2FkZF9jaGsoKTogdG8gYmUgdXNlZCB3aGVuIG1l bW9yeSBxdW90YSBzaG91bGQgYmUgY2hlY2tlZC4KKyAqIE5vdCB0byBiZSB1 c2VkIHdoZW4gc3BlY2lmeWluZyBhIG5lZ2F0aXZlIG1lbSB2YWx1ZSwgYXMg bG93ZXJpbmcgdGhlIHVzZWQKKyAqIG1lbW9yeSBzaG91bGQgYWx3YXlzIGJl IGFsbG93ZWQuCisgKi8KK3N0YXRpYyBpbmxpbmUgaW50IGRvbWFpbl9tZW1v cnlfYWRkX2Noayh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBtZW0pCit7CisJ cmV0dXJuIGRvbWFpbl9tZW1vcnlfYWRkKGRvbWlkLCBtZW0sIGZhbHNlKTsK K30KKy8qCisgKiBkb21haW5fbWVtb3J5X2FkZF9ub2NoaygpOiB0byBiZSB1 c2VkIHdoZW4gbWVtb3J5IHF1b3RhIHNob3VsZCBub3QgYmUKKyAqIGNoZWNr ZWQsIGUuZy4gd2hlbiBsb3dlcmluZyBtZW1vcnkgdXNhZ2UsIG9yIGluIGFu IGVycm9yIGNhc2UgZm9yIHVuZG9pbmcKKyAqIGEgcHJldmlvdXMgbWVtb3J5 IGFkanVzdG1lbnQuCisgKi8KK3N0YXRpYyBpbmxpbmUgdm9pZCBkb21haW5f bWVtb3J5X2FkZF9ub2Noayh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBtZW0p Cit7CisJZG9tYWluX21lbW9yeV9hZGQoZG9taWQsIG1lbSwgdHJ1ZSk7Cit9 CiB2b2lkIGRvbWFpbl93YXRjaF9pbmMoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4pOwogdm9pZCBkb21haW5fd2F0Y2hfZGVjKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uKTsKIGludCBkb21haW5fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pOwo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-12.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-12.patch" Content-Transfer-Encoding: base64 RnJvbSAzZWNmMTU3MjhkNzUxNmU3NTY0ZjI5ZDJkZDc2NzI0YTNlZDk2Y2M0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3IgcmVzcG9uc2VzCgpBZGQgdGhlIG1lbW9yeSBh Y2NvdW50aW5nIGZvciBxdWV1ZWQgcmVzcG9uc2VzLgoKSW4gY2FzZSBhZGRp bmcgYSB3YXRjaCBldmVudCBmb3IgYSBndWVzdCBpcyBjYXVzaW5nIHRoZSBo YXJkIG1lbW9yeQpxdW90YSBvZiB0aGF0IGd1ZXN0IHRvIGJlIHZpb2xhdGVk LCB0aGUgZXZlbnQgaXMgZHJvcHBlZC4gVGhpcyB3aWxsCmVuc3VyZSB0aGF0 IGl0IGlzIGltcG9zc2libGUgdG8gZHJpdmUgYW5vdGhlciBndWVzdCBwYXN0 IGl0cyBtZW1vcnkKcXVvdGEgYnkgZ2VuZXJhdGluZyBpbnNhbmUgYW1vdW50 cyBvZiBldmVudHMgZm9yIHRoYXQgZ3Vlc3QuIFRoaXMgaXMKZXNwZWNpYWxs eSBpbXBvcnRhbnQgZm9yIHByb3RlY3RpbmcgZHJpdmVyIGRvbWFpbnMgZnJv bSB0aGF0IGF0dGFjawp2ZWN0b3IuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMy NiAvIENWRS0yMDIyLTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4g R3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKaW5kZXggOWZkODNlYTAyNTlhLi40MzIyZDNjZjYz YTEgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAt MjU3LDYgKzI1Nyw4IEBAIHN0YXRpYyB2b2lkIGZyZWVfYnVmZmVyZWRfZGF0 YShzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqb3V0LAogCQl9CiAJfQogCisJZG9t YWluX21lbW9yeV9hZGRfbm9jaGsoY29ubi0+aWQsIC1vdXQtPmhkci5tc2cu bGVuIC0gc2l6ZW9mKG91dC0+aGRyKSk7CisKIAlpZiAob3V0LT5oZHIubXNn LnR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQpIHsKIAkJcmVxID0gb3V0LT5wZW5k LnJlcTsKIAkJaWYgKHJlcSkgewpAQCAtODQ1LDExICs4NDcsMTQgQEAgdm9p ZCBzZW5kX3JlcGx5KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBlbnVtIHhz ZF9zb2NrbXNnX3R5cGUgdHlwZSwKIAliZGF0YS0+dGltZW91dF9tc2VjID0g MDsKIAliZGF0YS0+d2F0Y2hfZXZlbnQgPSBmYWxzZTsKIAotCWlmIChsZW4g PD0gREVGQVVMVF9CVUZGRVJfU0laRSkKKwlpZiAobGVuIDw9IERFRkFVTFRf QlVGRkVSX1NJWkUpIHsKIAkJYmRhdGEtPmJ1ZmZlciA9IGJkYXRhLT5kZWZh dWx0X2J1ZmZlcjsKLQllbHNlIHsKKwkJLyogRG9uJ3QgY2hlY2sgcXVvdGEs IHBhdGggbWlnaHQgYmUgdXNlZCBmb3IgcmV0dXJuaW5nIGVycm9yLiAqLwor CQlkb21haW5fbWVtb3J5X2FkZF9ub2Noayhjb25uLT5pZCwgbGVuICsgc2l6 ZW9mKGJkYXRhLT5oZHIpKTsKKwl9IGVsc2UgewogCQliZGF0YS0+YnVmZmVy ID0gdGFsbG9jX2FycmF5KGJkYXRhLCBjaGFyLCBsZW4pOwotCQlpZiAoIWJk YXRhLT5idWZmZXIpIHsKKwkJaWYgKCFiZGF0YS0+YnVmZmVyIHx8CisJCSAg ICBkb21haW5fbWVtb3J5X2FkZF9jaGsoY29ubi0+aWQsIGxlbiArIHNpemVv ZihiZGF0YS0+aGRyKSkpIHsKIAkJCXNlbmRfZXJyb3IoY29ubiwgRU5PTUVN KTsKIAkJCXJldHVybjsKIAkJfQpAQCAtOTE0LDYgKzkxOSwxMSBAQCB2b2lk IHNlbmRfZXZlbnQoc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKnJlcSwgc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sCiAJCX0KIAl9CiAKKwlpZiAoZG9tYWluX21l bW9yeV9hZGRfY2hrKGNvbm4tPmlkLCBsZW4gKyBzaXplb2YoYmRhdGEtPmhk cikpKSB7CisJCXRhbGxvY19mcmVlKGJkYXRhKTsKKwkJcmV0dXJuOworCX0K KwogCWlmICh0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWMgJiYgZG9tYWluX2lz X3VucHJpdmlsZWdlZChjb25uKSkgewogCQliZGF0YS0+dGltZW91dF9tc2Vj ID0gZ2V0X25vd19tc2VjKCkgKyB0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWM7 CiAJCWlmICghY29ubi0+dGltZW91dF9tc2VjKQo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-13.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-13.patch" Content-Transfer-Encoding: base64 RnJvbSA2YWI5YzFkZThiZTE4MTA1ODk1YjU0NWU2MWQ2ZTE1NTAxODc1OTUx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3Igd2F0Y2hlcwoKQWRkIHRoZSBtZW1vcnkgYWNj b3VudGluZyBmb3IgcmVnaXN0ZXJlZCB3YXRjaGVzLgoKV2hlbiBhIHNvY2tl dCBjb25uZWN0aW9uIGlzIGRlc3Ryb3llZCwgdGhlIGFzc29jaWF0ZWQgd2F0 Y2hlcyBhcmUKcmVtb3ZlZCwgdG9vLiBJbiBvcmRlciB0byBrZWVwIG1lbW9y eSBhY2NvdW50aW5nIGNvcnJlY3QgdGhlIHdhdGNoZXMKbXVzdCBiZSByZW1v dmVkIGV4cGxpY2l0bHkgdmlhIGEgY2FsbCBvZiBjb25uX2RlbGV0ZV9hbGxf d2F0Y2hlcygpIGZyb20KZGVzdHJveV9jb25uKCkuCgpUaGlzIGlzIHBhcnQg b2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6 IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6 IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggNDMyMmQzY2Y2M2ExLi4w ZjU4OWExZjYzYTAgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuYwpAQCAtNDA3LDYgKzQwNyw3IEBAIHN0YXRpYyBpbnQgZGVzdHJveV9j b25uKHZvaWQgKl9jb25uKQogCX0KIAogCWNvbm5fZnJlZV9idWZmZXJlZF9k YXRhKGNvbm4pOworCWNvbm5fZGVsZXRlX2FsbF93YXRjaGVzKGNvbm4pOwog CWxpc3RfZm9yX2VhY2hfZW50cnkocmVxLCAmY29ubi0+cmVmX2xpc3QsIGxp c3QpCiAJCXJlcS0+b25fcmVmX2xpc3QgPSBmYWxzZTsKIApkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmMgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYwppbmRleCBjNTBjMDU3NWYwZjEu LjcxMThjMzBlOGMzMiAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX3dhdGNoLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X3dhdGNoLmMKQEAgLTIyNCw3ICsyMjQsOCBAQCBpbnQgZG9fd2F0Y2goc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICpp bikKIAkJcmV0dXJuIEVOT01FTTsKIAl3YXRjaC0+bm9kZSA9IHRhbGxvY19z dHJkdXAod2F0Y2gsIHZlY1swXSk7CiAJd2F0Y2gtPnRva2VuID0gdGFsbG9j X3N0cmR1cCh3YXRjaCwgdmVjWzFdKTsKLQlpZiAoIXdhdGNoLT5ub2RlIHx8 ICF3YXRjaC0+dG9rZW4pIHsKKwlpZiAoIXdhdGNoLT5ub2RlIHx8ICF3YXRj aC0+dG9rZW4gfHwKKwkgICAgZG9tYWluX21lbW9yeV9hZGRfY2hrKGNvbm4t PmlkLCBzdHJsZW4odmVjWzBdKSArIHN0cmxlbih2ZWNbMV0pKSkgewogCQl0 YWxsb2NfZnJlZSh3YXRjaCk7CiAJCXJldHVybiBFTk9NRU07CiAJfQpAQCAt MjY1LDYgKzI2Niw4IEBAIGludCBkb191bndhdGNoKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJbGlzdF9m b3JfZWFjaF9lbnRyeSh3YXRjaCwgJmNvbm4tPndhdGNoZXMsIGxpc3QpIHsK IAkJaWYgKHN0cmVxKHdhdGNoLT5ub2RlLCBub2RlKSAmJiBzdHJlcSh3YXRj aC0+dG9rZW4sIHZlY1sxXSkpIHsKIAkJCWxpc3RfZGVsKCZ3YXRjaC0+bGlz dCk7CisJCQlkb21haW5fbWVtb3J5X2FkZF9ub2Noayhjb25uLT5pZCwgLXN0 cmxlbih3YXRjaC0+bm9kZSkgLQorCQkJCQkJCSAgc3RybGVuKHdhdGNoLT50 b2tlbikpOwogCQkJdGFsbG9jX2ZyZWUod2F0Y2gpOwogCQkJZG9tYWluX3dh dGNoX2RlYyhjb25uKTsKIAkJCXNlbmRfYWNrKGNvbm4sIFhTX1VOV0FUQ0gp OwpAQCAtMjgwLDYgKzI4Myw4IEBAIHZvaWQgY29ubl9kZWxldGVfYWxsX3dh dGNoZXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCiAKIAl3aGlsZSAoKHdh dGNoID0gbGlzdF90b3AoJmNvbm4tPndhdGNoZXMsIHN0cnVjdCB3YXRjaCwg bGlzdCkpKSB7CiAJCWxpc3RfZGVsKCZ3YXRjaC0+bGlzdCk7CisJCWRvbWFp bl9tZW1vcnlfYWRkX25vY2hrKGNvbm4tPmlkLCAtc3RybGVuKHdhdGNoLT5u b2RlKSAtCisJCQkJCQkgIHN0cmxlbih3YXRjaC0+dG9rZW4pKTsKIAkJdGFs bG9jX2ZyZWUod2F0Y2gpOwogCQlkb21haW5fd2F0Y2hfZGVjKGNvbm4pOwog CX0K --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-14.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-14.patch" Content-Transfer-Encoding: base64 RnJvbSAyM2E2OGIzMzhkMzZjMjFmYWU1MDk3NjFmZjllZDExN2FkOTZlNDZi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3Igbm9kZXMKCkFkZCB0aGUgbWVtb3J5IGFjY291 bnRpbmcgZm9yIFhlbnN0b3JlIG5vZGVzLiBJbiBvcmRlciB0byBtYWtlIHRo aXMKbm90IHRvbyBjb21wbGljYXRlZCBhbGxvdyBmb3Igc29tZSBzbG9wcGlu ZXNzIHdoZW4gd3JpdGluZyBub2Rlcy4gQW55CmhhcmQgcXVvdGEgdmlvbGF0 aW9uIHdpbGwgcmVzdWx0IGluIG5vIGZ1cnRoZXIgcmVxdWVzdHMgdG8gYmUg YWNjZXB0ZWQuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNiAvIENWRS0yMDIy LTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxs QGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKaW5kZXggMGY1ODlhMWY2M2EwLi42ZWQxYWUyNjE0NzAgMTAwNjQ0Ci0t LSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtNDk4LDYgKzQ5OCwx MTcgQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZV9mZHMoaW50ICpwX3NvY2tf cG9sbGZkX2lkeCwgaW50ICpwX3JvX3NvY2tfcG9sbGZkX2lkeCwKIAl9CiB9 CiAKK3N0YXRpYyB2b2lkIGdldF9hY2NfZGF0YShUREJfREFUQSAqa2V5LCBz dHJ1Y3Qgbm9kZV9hY2NvdW50X2RhdGEgKmFjYykKK3sKKwlUREJfREFUQSBv bGRfZGF0YTsKKwlzdHJ1Y3QgeHNfdGRiX3JlY29yZF9oZHIgKmhkcjsKKwor CWlmIChhY2MtPm1lbW9yeSA8IDApIHsKKwkJb2xkX2RhdGEgPSB0ZGJfZmV0 Y2godGRiX2N0eCwgKmtleSk7CisJCS8qIE5vIGNoZWNrIGZvciBlcnJvciwg YXMgdGhlIG5vZGUgbWlnaHQgbm90IGV4aXN0LiAqLworCQlpZiAob2xkX2Rh dGEuZHB0ciA9PSBOVUxMKSB7CisJCQlhY2MtPm1lbW9yeSA9IDA7CisJCX0g ZWxzZSB7CisJCQloZHIgPSAodm9pZCAqKW9sZF9kYXRhLmRwdHI7CisJCQlh Y2MtPm1lbW9yeSA9IG9sZF9kYXRhLmRzaXplOworCQkJYWNjLT5kb21pZCA9 IGhkci0+cGVybXNbMF0uaWQ7CisJCX0KKwkJdGFsbG9jX2ZyZWUob2xkX2Rh dGEuZHB0cik7CisJfQorfQorCisvKgorICogUGVyLXRyYW5zYWN0aW9uIG5v ZGVzIG5lZWQgdG8gYmUgYWNjb3VudGVkIGZvciB0aGUgdHJhbnNhY3Rpb24g b3duZXIuCisgKiBUaG9zZSBub2RlcyBhcmUgc3RvcmVkIGluIHRoZSBkYXRh IGJhc2Ugd2l0aCB0aGUgdHJhbnNhY3Rpb24gZ2VuZXJhdGlvbgorICogY291 bnQgcHJlcGVuZGVkIChlLmcuIDEyMy9sb2NhbC9kb21haW4vLi4uKS4gU28g dGVzdGluZyBmb3IgdGhlIG5vZGUncworICoga2V5IG5vdCB0byBzdGFydCB3 aXRoICIvIiBpcyBzdWZmaWNpZW50LgorICovCitzdGF0aWMgdW5zaWduZWQg aW50IGdldF9hY2NfZG9taWQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFRE Ql9EQVRBICprZXksCisJCQkJICB1bnNpZ25lZCBpbnQgZG9taWQpCit7CisJ cmV0dXJuICghY29ubiB8fCBrZXktPmRwdHJbMF0gPT0gJy8nKSA/IGRvbWlk IDogY29ubi0+aWQ7Cit9CisKK2ludCBkb190ZGJfd3JpdGUoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXksIFREQl9EQVRBICpkYXRh LAorCQkgc3RydWN0IG5vZGVfYWNjb3VudF9kYXRhICphY2MsIGJvb2wgbm9f cXVvdGFfY2hlY2spCit7CisJc3RydWN0IHhzX3RkYl9yZWNvcmRfaGRyICpo ZHIgPSAodm9pZCAqKWRhdGEtPmRwdHI7CisJc3RydWN0IG5vZGVfYWNjb3Vu dF9kYXRhIG9sZF9hY2MgPSB7fTsKKwl1bnNpZ25lZCBpbnQgb2xkX2RvbWlk LCBuZXdfZG9taWQ7CisJaW50IHJldDsKKworCWlmICghYWNjKQorCQlvbGRf YWNjLm1lbW9yeSA9IC0xOworCWVsc2UKKwkJb2xkX2FjYyA9ICphY2M7CisK KwlnZXRfYWNjX2RhdGEoa2V5LCAmb2xkX2FjYyk7CisJb2xkX2RvbWlkID0g Z2V0X2FjY19kb21pZChjb25uLCBrZXksIG9sZF9hY2MuZG9taWQpOworCW5l d19kb21pZCA9IGdldF9hY2NfZG9taWQoY29ubiwga2V5LCBoZHItPnBlcm1z WzBdLmlkKTsKKworCS8qCisJICogRG9uJ3QgY2hlY2sgZm9yIEVOT0VOVCwg YXMgd2Ugd2FudCB0byBiZSBhYmxlIHRvIHN3aXRjaCBvcnBoYW5lZAorCSAq IG5vZGVzIHRvIG5ldyBvd25lcnMuCisJICovCisJaWYgKG9sZF9hY2MubWVt b3J5KQorCQlkb21haW5fbWVtb3J5X2FkZF9ub2NoayhvbGRfZG9taWQsCisJ CQkJCS1vbGRfYWNjLm1lbW9yeSAtIGtleS0+ZHNpemUpOworCXJldCA9IGRv bWFpbl9tZW1vcnlfYWRkKG5ld19kb21pZCwgZGF0YS0+ZHNpemUgKyBrZXkt PmRzaXplLAorCQkJCW5vX3F1b3RhX2NoZWNrKTsKKwlpZiAocmV0KSB7CisJ CS8qIEVycm9yIHBhdGgsIHNvIG5vIHF1b3RhIGNoZWNrLiAqLworCQlpZiAo b2xkX2FjYy5tZW1vcnkpCisJCQlkb21haW5fbWVtb3J5X2FkZF9ub2Noayhv bGRfZG9taWQsCisJCQkJCQlvbGRfYWNjLm1lbW9yeSArIGtleS0+ZHNpemUp OworCQlyZXR1cm4gcmV0OworCX0KKworCS8qIFREQiBzaG91bGQgc2V0IGVy cm5vLCBidXQgZG9lc24ndCBldmVuIHNldCBlY29kZSBBRkFJQ1QuICovCisJ aWYgKHRkYl9zdG9yZSh0ZGJfY3R4LCAqa2V5LCAqZGF0YSwgVERCX1JFUExB Q0UpICE9IDApIHsKKwkJZG9tYWluX21lbW9yeV9hZGRfbm9jaGsobmV3X2Rv bWlkLCAtZGF0YS0+ZHNpemUgLSBrZXktPmRzaXplKTsKKwkJLyogRXJyb3Ig cGF0aCwgc28gbm8gcXVvdGEgY2hlY2suICovCisJCWlmIChvbGRfYWNjLm1l bW9yeSkKKwkJCWRvbWFpbl9tZW1vcnlfYWRkX25vY2hrKG9sZF9kb21pZCwK KwkJCQkJCW9sZF9hY2MubWVtb3J5ICsga2V5LT5kc2l6ZSk7CisJCWVycm5v ID0gRUlPOworCQlyZXR1cm4gZXJybm87CisJfQorCisJaWYgKGFjYykgewor CQkvKiBEb24ndCB1c2UgbmV3X2RvbWlkLCBhcyBpdCBtaWdodCBiZSBhIHRy YW5zYWN0aW9uIG5vZGUuICovCisJCWFjYy0+ZG9taWQgPSBoZHItPnBlcm1z WzBdLmlkOworCQlhY2MtPm1lbW9yeSA9IGRhdGEtPmRzaXplOworCX0KKwor CXJldHVybiAwOworfQorCitpbnQgZG9fdGRiX2RlbGV0ZShzdHJ1Y3QgY29u bmVjdGlvbiAqY29ubiwgVERCX0RBVEEgKmtleSwKKwkJICBzdHJ1Y3Qgbm9k ZV9hY2NvdW50X2RhdGEgKmFjYykKK3sKKwlzdHJ1Y3Qgbm9kZV9hY2NvdW50 X2RhdGEgdG1wX2FjYzsKKwl1bnNpZ25lZCBpbnQgZG9taWQ7CisKKwlpZiAo IWFjYykgeworCQlhY2MgPSAmdG1wX2FjYzsKKwkJYWNjLT5tZW1vcnkgPSAt MTsKKwl9CisKKwlnZXRfYWNjX2RhdGEoa2V5LCBhY2MpOworCisJaWYgKHRk Yl9kZWxldGUodGRiX2N0eCwgKmtleSkpIHsKKwkJZXJybm8gPSBFSU87CisJ CXJldHVybiBlcnJubzsKKwl9CisKKwlpZiAoYWNjLT5tZW1vcnkpIHsKKwkJ ZG9taWQgPSBnZXRfYWNjX2RvbWlkKGNvbm4sIGtleSwgYWNjLT5kb21pZCk7 CisJCWRvbWFpbl9tZW1vcnlfYWRkX25vY2hrKGRvbWlkLCAtYWNjLT5tZW1v cnkgLSBrZXktPmRzaXplKTsKKwl9CisKKwlyZXR1cm4gMDsKK30KKwogLyoK ICAqIElmIGl0IGZhaWxzLCByZXR1cm5zIE5VTEwgYW5kIHNldHMgZXJybm8u CiAgKiBUZW1wb3JhcnkgbWVtb3J5IGFsbG9jYXRpb25zIHdpbGwgYmUgZG9u ZSB3aXRoIGN0eC4KQEAgLTU1MSw5ICs2NjIsMTUgQEAgc3RydWN0IG5vZGUg KnJlYWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9p ZCAqY3R4LAogCiAJLyogUGVybWlzc2lvbnMgYXJlIHN0cnVjdCB4c19wZXJt aXNzaW9ucy4gKi8KIAlub2RlLT5wZXJtcy5wID0gaGRyLT5wZXJtczsKKwlu b2RlLT5hY2MuZG9taWQgPSBub2RlLT5wZXJtcy5wWzBdLmlkOworCW5vZGUt PmFjYy5tZW1vcnkgPSBkYXRhLmRzaXplOwogCWlmIChkb21haW5fYWRqdXN0 X25vZGVfcGVybXMoY29ubiwgbm9kZSkpCiAJCWdvdG8gZXJyb3I7CiAKKwkv KiBJZiBvd25lciBpcyBnb25lIHJlc2V0IGN1cnJlbnRseSBhY2NvdW50ZWQg bWVtb3J5IHNpemUuICovCisJaWYgKG5vZGUtPmFjYy5kb21pZCAhPSBub2Rl LT5wZXJtcy5wWzBdLmlkKQorCQlub2RlLT5hY2MubWVtb3J5ID0gMDsKKwog CS8qIERhdGEgaXMgYmluYXJ5IGJsb2IgKHVzdWFsbHkgYXNjaWksIG5vIG51 bCkuICovCiAJbm9kZS0+ZGF0YSA9IG5vZGUtPnBlcm1zLnAgKyBoZHItPm51 bV9wZXJtczsKIAkvKiBDaGlsZHJlbiBpcyBzdHJpbmdzLCBudWwgc2VwYXJh dGVkLiAqLwpAQCAtNjE3LDEyICs3MzQsOSBAQCBpbnQgd3JpdGVfbm9kZV9y YXcoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXksIHN0 cnVjdCBub2RlICpub2RlLAogCXAgKz0gbm9kZS0+ZGF0YWxlbjsKIAltZW1j cHkocCwgbm9kZS0+Y2hpbGRyZW4sIG5vZGUtPmNoaWxkbGVuKTsKIAotCS8q IFREQiBzaG91bGQgc2V0IGVycm5vLCBidXQgZG9lc24ndCBldmVuIHNldCBl Y29kZSBBRkFJQ1QuICovCi0JaWYgKHRkYl9zdG9yZSh0ZGJfY3R4LCAqa2V5 LCBkYXRhLCBUREJfUkVQTEFDRSkgIT0gMCkgewotCQljb3JydXB0KGNvbm4s ICJXcml0ZSBvZiAlcyBmYWlsZWQiLCBrZXktPmRwdHIpOwotCQllcnJubyA9 IEVJTzsKLQkJcmV0dXJuIGVycm5vOwotCX0KKwlpZiAoZG9fdGRiX3dyaXRl KGNvbm4sIGtleSwgJmRhdGEsICZub2RlLT5hY2MsIG5vX3F1b3RhX2NoZWNr KSkKKwkJcmV0dXJuIEVJTzsKKwogCXJldHVybiAwOwogfQogCkBAIC0xMTIx LDcgKzEyMzUsNyBAQCBzdGF0aWMgdm9pZCBkZWxldGVfbm9kZV9zaW5nbGUo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQog CWlmIChhY2Nlc3Nfbm9kZShjb25uLCBub2RlLCBOT0RFX0FDQ0VTU19ERUxF VEUsICZrZXkpKQogCQlyZXR1cm47CiAKLQlpZiAodGRiX2RlbGV0ZSh0ZGJf Y3R4LCBrZXkpICE9IDApIHsKKwlpZiAoZG9fdGRiX2RlbGV0ZShjb25uLCAm a2V5LCAmbm9kZS0+YWNjKSAhPSAwKSB7CiAJCWNvcnJ1cHQoY29ubiwgIkNv dWxkIG5vdCBkZWxldGUgJyVzJyIsIG5vZGUtPm5hbWUpOwogCQlyZXR1cm47 CiAJfQpAQCAtMTE4NCw2ICsxMjk4LDcgQEAgc3RhdGljIHN0cnVjdCBub2Rl ICpjb25zdHJ1Y3Rfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29u c3Qgdm9pZCAqY3R4LAogCS8qIE5vIGNoaWxkcmVuLCBubyBkYXRhICovCiAJ bm9kZS0+Y2hpbGRyZW4gPSBub2RlLT5kYXRhID0gTlVMTDsKIAlub2RlLT5j aGlsZGxlbiA9IG5vZGUtPmRhdGFsZW4gPSAwOworCW5vZGUtPmFjYy5tZW1v cnkgPSAwOwogCW5vZGUtPnBhcmVudCA9IHBhcmVudDsKIAlyZXR1cm4gbm9k ZTsKIApAQCAtMTE5MiwxNyArMTMwNywxNyBAQCBzdGF0aWMgc3RydWN0IG5v ZGUgKmNvbnN0cnVjdF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBj b25zdCB2b2lkICpjdHgsCiAJcmV0dXJuIE5VTEw7CiB9CiAKLXN0YXRpYyB2 b2lkIGRlc3Ryb3lfbm9kZV9ybShzdHJ1Y3Qgbm9kZSAqbm9kZSkKK3N0YXRp YyB2b2lkIGRlc3Ryb3lfbm9kZV9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgc3RydWN0IG5vZGUgKm5vZGUpCiB7CiAJaWYgKHN0cmVxKG5vZGUtPm5h bWUsICIvIikpCiAJCWNvcnJ1cHQoTlVMTCwgIkRlc3Ryb3lpbmcgcm9vdCBu b2RlISIpOwogCi0JdGRiX2RlbGV0ZSh0ZGJfY3R4LCBub2RlLT5rZXkpOwor CWRvX3RkYl9kZWxldGUoY29ubiwgJm5vZGUtPmtleSwgJm5vZGUtPmFjYyk7 CiB9CiAKIHN0YXRpYyBpbnQgZGVzdHJveV9ub2RlKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSkKIHsKLQlkZXN0cm95X25v ZGVfcm0obm9kZSk7CisJZGVzdHJveV9ub2RlX3JtKGNvbm4sIG5vZGUpOwog CWRvbWFpbl9lbnRyeV9kZWMoY29ubiwgbm9kZSk7CiAKIAkvKgpAQCAtMTI1 NCw3ICsxMzY5LDcgQEAgc3RhdGljIHN0cnVjdCBub2RlICpjcmVhdGVfbm9k ZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAog CQkvKiBBY2NvdW50IGZvciBuZXcgbm9kZSAqLwogCQlpZiAoaS0+cGFyZW50 KSB7CiAJCQlpZiAoZG9tYWluX2VudHJ5X2luYyhjb25uLCBpKSkgewotCQkJ CWRlc3Ryb3lfbm9kZV9ybShpKTsKKwkJCQlkZXN0cm95X25vZGVfcm0oY29u biwgaSk7CiAJCQkJcmV0dXJuIE5VTEw7CiAJCQl9CiAJCX0KQEAgLTIwNzcs NyArMjE5Miw3IEBAIHN0YXRpYyBpbnQgY2xlYW5fc3RvcmVfKFREQl9DT05U RVhUICp0ZGIsIFREQl9EQVRBIGtleSwgVERCX0RBVEEgdmFsLAogCWlmICgh aGFzaHRhYmxlX3NlYXJjaChyZWFjaGFibGUsIG5hbWUpKSB7CiAJCWxvZygi Y2xlYW5fc3RvcmU6ICclcycgaXMgb3JwaGFuZWQhIiwgbmFtZSk7CiAJCWlm IChyZWNvdmVyeSkgewotCQkJdGRiX2RlbGV0ZSh0ZGIsIGtleSk7CisJCQlk b190ZGJfZGVsZXRlKE5VTEwsICZrZXksIE5VTEwpOwogCQl9CiAJfQogCmRp ZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCA0ZTUzMDcy ZTYzN2MuLjUyMWJjODAzODRlNSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfY29yZS5oCkBAIC0xNDEsNiArMTQxLDExIEBAIHN0cnVjdCBub2Rl X3Blcm1zIHsKIAlzdHJ1Y3QgeHNfcGVybWlzc2lvbnMgKnA7CiB9OwogCitz dHJ1Y3Qgbm9kZV9hY2NvdW50X2RhdGEgeworCXVuc2lnbmVkIGludCBkb21p ZDsKKwlpbnQgbWVtb3J5OwkJLyogLTEgaWYgdW5rbm93biAqLworfTsKKwog c3RydWN0IG5vZGUgewogCWNvbnN0IGNoYXIgKm5hbWU7CiAJLyogS2V5IHVz ZWQgdG8gdXBkYXRlIFREQiAqLwpAQCAtMTYzLDYgKzE2OCw5IEBAIHN0cnVj dCBub2RlIHsKIAkvKiBDaGlsZHJlbiwgZWFjaCBudWwtdGVybWluYXRlZC4g Ki8KIAl1bnNpZ25lZCBpbnQgY2hpbGRsZW47CiAJY2hhciAqY2hpbGRyZW47 CisKKwkvKiBBbGxvY2F0aW9uIGluZm9ybWF0aW9uIGZvciBub2RlIGN1cnJl bnRseSBpbiBzdG9yZS4gKi8KKwlzdHJ1Y3Qgbm9kZV9hY2NvdW50X2RhdGEg YWNjOwogfTsKIAogLyogUmV0dXJuIHRoZSBvbmx5IGFyZ3VtZW50IGluIHRo ZSBpbnB1dC4gKi8KQEAgLTI1OCw2ICsyNjYsMTEgQEAgZXh0ZXJuIHhlbmdu dHRhYl9oYW5kbGUgKip4Z3RfaGFuZGxlOwogCiBpbnQgcmVtZW1iZXJfc3Ry aW5nKHN0cnVjdCBoYXNodGFibGUgKmhhc2gsIGNvbnN0IGNoYXIgKnN0cik7 CiAKK2ludCBkb190ZGJfd3JpdGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IFREQl9EQVRBICprZXksIFREQl9EQVRBICpkYXRhLAorCQkgc3RydWN0IG5v ZGVfYWNjb3VudF9kYXRhICphY2MsIGJvb2wgbm9fcXVvdGFfY2hlY2spOwor aW50IGRvX3RkYl9kZWxldGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFRE Ql9EQVRBICprZXksCisJCSAgc3RydWN0IG5vZGVfYWNjb3VudF9kYXRhICph Y2MpOworCiB2b2lkIGNvbm5fZnJlZV9idWZmZXJlZF9kYXRhKHN0cnVjdCBj b25uZWN0aW9uICpjb25uKTsKIAogI2VuZGlmIC8qIF9YRU5TVE9SRURfQ09S RV9IICovCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf dHJhbnNhY3Rpb24uYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFu c2FjdGlvbi5jCmluZGV4IDc3OGI3ZTQzOWNiMy4uYzFiZWI0MGEzZDUxIDEw MDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rp b24uYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rp b24uYwpAQCAtMTUzLDYgKzE1Myw5IEBAIHN0cnVjdCB0cmFuc2FjdGlvbgog CS8qIExpc3Qgb2YgYWxsIHRyYW5zYWN0aW9ucyBhY3RpdmUgb24gdGhpcyBj b25uZWN0aW9uLiAqLwogCXN0cnVjdCBsaXN0X2hlYWQgbGlzdDsKIAorCS8q IENvbm5lY3Rpb24gdGhpcyB0cmFuc2FjdGlvbiBpcyBhc3NvY2lhdGVkIHdp dGguICovCisJc3RydWN0IGNvbm5lY3Rpb24gKmNvbm47CisKIAkvKiBDb25u ZWN0aW9uLWxvY2FsIGlkZW50aWZpZXIgZm9yIHRoaXMgdHJhbnNhY3Rpb24u ICovCiAJdWludDMyX3QgaWQ7CiAKQEAgLTI5Miw2ICsyOTUsOCBAQCBpbnQg YWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlLAogCiAJCWludHJvZHVjZSA9IHRydWU7CiAJCWktPnRhX25v ZGUgPSBmYWxzZTsKKwkJLyogYWNjLm1lbW9yeSA8IDAgbWVhbnMgInVua25v d24sIGdldCBzaXplIGZyb20gVERCIi4gKi8KKwkJbm9kZS0+YWNjLm1lbW9y eSA9IC0xOwogCiAJCS8qCiAJCSAqIEFkZGl0aW9uYWwgdHJhbnNhY3Rpb24t c3BlY2lmaWMgbm9kZSBmb3IgcmVhZCB0eXBlLiBXZSBvbmx5CkBAIC00MTYs MTEgKzQyMSwxMSBAQCBzdGF0aWMgaW50IGZpbmFsaXplX3RyYW5zYWN0aW9u KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCQkJCQlnb3RvIGVycjsKIAkJ CQloZHIgPSAodm9pZCAqKWRhdGEuZHB0cjsKIAkJCQloZHItPmdlbmVyYXRp b24gPSArK2dlbmVyYXRpb247Ci0JCQkJcmV0ID0gdGRiX3N0b3JlKHRkYl9j dHgsIGtleSwgZGF0YSwKLQkJCQkJCVREQl9SRVBMQUNFKTsKKwkJCQlyZXQg PSBkb190ZGJfd3JpdGUoY29ubiwgJmtleSwgJmRhdGEsIE5VTEwsCisJCQkJ CQkgICB0cnVlKTsKIAkJCQl0YWxsb2NfZnJlZShkYXRhLmRwdHIpOwogCQkJ fSBlbHNlIHsKLQkJCQlyZXQgPSB0ZGJfZGVsZXRlKHRkYl9jdHgsIGtleSk7 CisJCQkJcmV0ID0gZG9fdGRiX2RlbGV0ZShjb25uLCAma2V5LCBOVUxMKTsK IAkJCX0KIAkJCWlmIChyZXQpCiAJCQkJZ290byBlcnI7CkBAIC00MzEsNyAr NDM2LDcgQEAgc3RhdGljIGludCBmaW5hbGl6ZV90cmFuc2FjdGlvbihzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJCX0KIAkJfQogCi0JCWlmIChpLT50 YV9ub2RlICYmIHRkYl9kZWxldGUodGRiX2N0eCwgdGFfa2V5KSkKKwkJaWYg KGktPnRhX25vZGUgJiYgZG9fdGRiX2RlbGV0ZShjb25uLCAmdGFfa2V5LCBO VUxMKSkKIAkJCWdvdG8gZXJyOwogCQlsaXN0X2RlbCgmaS0+bGlzdCk7CiAJ CXRhbGxvY19mcmVlKGkpOwpAQCAtNDU5LDcgKzQ2NCw3IEBAIHN0YXRpYyBp bnQgZGVzdHJveV90cmFuc2FjdGlvbih2b2lkICpfdHJhbnNhY3Rpb24pCiAJ CQkJCQkJICAgICAgIGktPm5vZGUpOwogCQkJaWYgKHRyYW5zX25hbWUpIHsK IAkJCQlzZXRfdGRiX2tleSh0cmFuc19uYW1lLCAma2V5KTsKLQkJCQl0ZGJf ZGVsZXRlKHRkYl9jdHgsIGtleSk7CisJCQkJZG9fdGRiX2RlbGV0ZSh0cmFu cy0+Y29ubiwgJmtleSwgTlVMTCk7CiAJCQl9CiAJCX0KIAkJbGlzdF9kZWwo JmktPmxpc3QpOwpAQCAtNTAzLDYgKzUwOCw3IEBAIGludCBkb190cmFuc2Fj dGlvbl9zdGFydChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKmluKQogCiAJSU5JVF9MSVNUX0hFQUQoJnRyYW5zLT5h Y2Nlc3NlZCk7CiAJSU5JVF9MSVNUX0hFQUQoJnRyYW5zLT5jaGFuZ2VkX2Rv bWFpbnMpOworCXRyYW5zLT5jb25uID0gY29ubjsKIAl0cmFucy0+ZmFpbCA9 IGZhbHNlOwogCXRyYW5zLT5nZW5lcmF0aW9uID0gKytnZW5lcmF0aW9uOwog Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-15.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-15.patch" Content-Transfer-Encoding: base64 RnJvbSBlYWNjMDMyZTllNjY4ZGNkY2JhY2I4N2JiYjYxYTdiYTJlMzk4Y2Rk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBleHBv cnRzIGZvciBxdW90YSB2YXJpYWJsZXMKClNvbWUgcXVvdGEgdmFyaWFibGVz IGFyZSBub3QgZXhwb3J0ZWQgdmlhIGhlYWRlciBmaWxlcy4KClRoaXMgaXMg cGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jv c3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmgKaW5kZXggNTIxYmM4MDM4NGU1Li41YWJmMDZjMjFjOTggMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMjMxLDYg KzIzMSwxMSBAQCBleHRlcm4gVERCX0NPTlRFWFQgKnRkYl9jdHg7CiBleHRl cm4gaW50IGRvbTBfZG9taWQ7CiBleHRlcm4gaW50IGRvbTBfZXZlbnQ7CiBl eHRlcm4gaW50IHByaXZfZG9taWQ7CitleHRlcm4gaW50IHF1b3RhX25iX3dh dGNoX3Blcl9kb21haW47CitleHRlcm4gaW50IHF1b3RhX21heF90cmFuc2Fj dGlvbjsKK2V4dGVybiBpbnQgcXVvdGFfbWF4X2VudHJ5X3NpemU7CitleHRl cm4gaW50IHF1b3RhX25iX3Blcm1zX3Blcl9ub2RlOworZXh0ZXJuIGludCBx dW90YV9tYXhfcGF0aF9sZW47CiBleHRlcm4gaW50IHF1b3RhX25iX2VudHJ5 X3Blcl9kb21haW47CiBleHRlcm4gaW50IHF1b3RhX3JlcV9vdXRzdGFuZGlu ZzsKIGV4dGVybiBpbnQgcXVvdGFfdHJhbnNfbm9kZXM7CmRpZmYgLS1naXQg YS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4IGMx YmViNDBhM2Q1MS4uNmUyOTExOGM4MDBkIDEwMDY0NAotLS0gYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpAQCAtMTc1LDcgKzE3 NSw2IEBAIHN0cnVjdCB0cmFuc2FjdGlvbgogCWJvb2wgZmFpbDsKIH07CiAK LWV4dGVybiBpbnQgcXVvdGFfbWF4X3RyYW5zYWN0aW9uOwogdWludDY0X3Qg Z2VuZXJhdGlvbjsKIAogc3RhdGljIHZvaWQgc2V0X3RkYl9rZXkoY29uc3Qg Y2hhciAqbmFtZSwgVERCX0RBVEEgKmtleSkKZGlmZiAtLWdpdCBhL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3dhdGNoLmMKaW5kZXggNzExOGMzMGU4YzMyLi4xOWQwZmIw MWIxYzQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93 YXRjaC5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5j CkBAIC0zMSw4ICszMSw2IEBACiAjaW5jbHVkZSAieGVuc3RvcmVkX2RvbWFp bi5oIgogI2luY2x1ZGUgInhlbnN0b3JlZF90cmFuc2FjdGlvbi5oIgogCi1l eHRlcm4gaW50IHF1b3RhX25iX3dhdGNoX3Blcl9kb21haW47Ci0KIHN0cnVj dCB3YXRjaAogewogCS8qIFdhdGNoZXMgb24gdGhpcyBjb25uZWN0aW9uICov Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.14-xenstored-16.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.14-xenstored-16.patch" Content-Transfer-Encoding: base64 RnJvbSA1NzM0ZmI2NTVlODdlYzM4YzRlMGFmOTAyM2I1NGUxM2Q4MjdjN2U2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBjb250 cm9sIGNvbW1hbmQgZm9yIHNldHRpbmcgYW5kIHNob3dpbmcgcXVvdGEKCkFk ZCBhIHhlbnN0b3JlLWNvbnRyb2wgY29tbWFuZCAicXVvdGEiIHRvOgotIHNo b3cgY3VycmVudCBxdW90YSBzZXR0aW5ncwotIGNoYW5nZSBxdW90YSBzZXR0 aW5ncwotIHNob3cgY3VycmVudCBxdW90YSByZWxhdGVkIHZhbHVlcyBvZiBh IGRvbWFpbgoKTm90ZSB0aGF0IGluIHRoZSBjYXNlIHRoZSBuZXcgcXVvdGEg aXMgbG93ZXIgdGhhbiBleGlzdGluZyBvbmUsClhlbnN0b3JlZCBtYXkgY29u dGludWUgdG8gaGFuZGxlIHJlcXVlc3RzIGZyb20gYSBkb21haW4gZXhjZWVk aW5nIHRoZQpuZXcgbGltaXQgKGRlcGVuZHMgb24gd2hpY2ggb25lIGhhcyBi ZWVuIGJyb2tlbikgYW5kIHRoZSBhbW91bnQgb2YKcmVzb3VyY2UgdXNlZCB3 aWxsIG5vdCBjaGFuZ2UuIEhvd2V2ZXIgdGhlIGRvbWFpbiB3aWxsIG5vdCBi ZSBhYmxlIHRvCmNyZWF0ZSBtb3JlIHJlc291cmNlIChhc3NvY2lhdGVkIHRv IHRoZSBxdW90YSkgdW50aWwgaXQgaXMgYmFjayB0byBiZWxvdwp0aGUgbGlt aXQuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNi4KClJlcG9ydGVkLWJ5OiBK dWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgpTaWduZWQtb2ZmLWJ5 OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJldmlld2VkLWJ5 OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdp dCBhL2RvY3MvbWlzYy94ZW5zdG9yZS50eHQgYi9kb2NzL21pc2MveGVuc3Rv cmUudHh0CmluZGV4IDIwODFmMjBmNTVlNC4uMWY0MmEzNzdjMTBmIDEwMDY0 NAotLS0gYS9kb2NzL21pc2MveGVuc3RvcmUudHh0CisrKyBiL2RvY3MvbWlz Yy94ZW5zdG9yZS50eHQKQEAgLTMyOSw2ICszMjksMTcgQEAgQ09OVFJPTAkJ CTxjb21tYW5kPnxbPHBhcmFtZXRlcnM+fF0KIAlwcmludHw8c3RyaW5nPgog CQlwcmludCA8c3RyaW5nPiB0byBzeXNsb2cgKHhlbnN0b3JlIHJ1bnMgYXMg ZGFlbW9uKSBvcgogCQl0byBjb25zb2xlICh4ZW5zdG9yZSBydW5zIGFzIHN0 dWJkb20pCisJcXVvdGF8W3NldCA8bmFtZT4gPHZhbD58PGRvbWlkPl0KKwkJ d2l0aG91dCBwYXJhbWV0ZXJzOiBwcmludCB0aGUgY3VycmVudCBxdW90YSBz ZXR0aW5ncworCQl3aXRoICJzZXQgPG5hbWU+IDx2YWw+Ijogc2V0IHRoZSBx dW90YSA8bmFtZT4gdG8gbmV3IHZhbHVlCisJCTx2YWw+IChUaGUgYWRtaW4g c2hvdWxkIG1ha2Ugc3VyZSBhbGwgdGhlIGRvbWFpbiB1c2FnZSBpcworCQli ZWxvdyB0aGUgcXVvdGEuIElmIGl0IGlzIG5vdCwgdGhlbiBYZW5zdG9yZWQg bWF5IGNvbnRpbnVlIHRvCisJCWhhbmRsZSByZXF1ZXN0cyBmcm9tIHRoZSBk b21haW4gYXMgbG9uZyBhcyB0aGUgcmVzb3VyY2UKKwkJdmlvbGF0aW5nIHRo ZSBuZXcgcXVvdGEgc2V0dGluZyBpc24ndCBpbmNyZWFzZWQgZnVydGhlcikK KwkJd2l0aCAiPGRvbWlkPiI6IHByaW50IHF1b3RhIHJlbGF0ZWQgYWNjb3Vu dGluZyBkYXRhIGZvcgorCQl0aGUgZG9tYWluIDxkb21pZD4KKwlxdW90YS1z b2Z0fFtzZXQgPG5hbWU+IDx2YWw+XQorCQlsaWtlIHRoZSAicXVvdGEiIGNv bW1hbmQsIGJ1dCBmb3Igc29mdC1xdW90YS4KIAloZWxwCQkJPHN1cHBvcnRl ZC1jb21tYW5kcz4KIAkJcmV0dXJuIGxpc3Qgb2Ygc3VwcG9ydGVkIGNvbW1h bmRzIGZvciBDT05UUk9MCiAKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb250cm9sLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29udHJvbC5jCmluZGV4IGFiMDc5NGRlZWRjOC4uMDIyN2E1NTY1NjU3 IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJv bC5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmMK QEAgLTE5LDYgKzE5LDcgQEAKICNpbmNsdWRlIDxlcnJuby5oPgogI2luY2x1 ZGUgPHN0ZGFyZy5oPgogI2luY2x1ZGUgPHN0ZGlvLmg+CisjaW5jbHVkZSA8 c3RkbGliLmg+CiAjaW5jbHVkZSA8c3RyaW5nLmg+CiAKICNpbmNsdWRlICJ1 dGlscy5oIgpAQCAtNjIsNiArNjMsMTE0IEBAIHN0YXRpYyBpbnQgZG9fY29u dHJvbF9sb2codm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwK IAlyZXR1cm4gMDsKIH0KIAorc3RydWN0IHF1b3RhIHsKKwljb25zdCBjaGFy ICpuYW1lOworCWludCAqcXVvdGE7CisJY29uc3QgY2hhciAqZGVzY3I7Cit9 OworCitzdGF0aWMgY29uc3Qgc3RydWN0IHF1b3RhIGhhcmRfcXVvdGFzW10g PSB7CisJeyAibm9kZXMiLCAmcXVvdGFfbmJfZW50cnlfcGVyX2RvbWFpbiwg Ik5vZGVzIHBlciBkb21haW4iIH0sCisJeyAid2F0Y2hlcyIsICZxdW90YV9u Yl93YXRjaF9wZXJfZG9tYWluLCAiV2F0Y2hlcyBwZXIgZG9tYWluIiB9LAor CXsgInRyYW5zYWN0aW9ucyIsICZxdW90YV9tYXhfdHJhbnNhY3Rpb24sICJU cmFuc2FjdGlvbnMgcGVyIGRvbWFpbiIgfSwKKwl7ICJvdXRzdGFuZGluZyIs ICZxdW90YV9yZXFfb3V0c3RhbmRpbmcsCisJCSJPdXRzdGFuZGluZyByZXF1 ZXN0cyBwZXIgZG9tYWluIiB9LAorCXsgInRyYW5zYWN0aW9uLW5vZGVzIiwg JnF1b3RhX3RyYW5zX25vZGVzLAorCQkiTWF4LiBudW1iZXIgb2YgYWNjZXNz ZWQgbm9kZXMgcGVyIHRyYW5zYWN0aW9uIiB9LAorCXsgIm1lbW9yeSIsICZx dW90YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJkLAorCQkiVG90YWwgWGVuc3Rv cmUgbWVtb3J5IHBlciBkb21haW4gKGVycm9yIGxldmVsKSIgfSwKKwl7ICJu b2RlLXNpemUiLCAmcXVvdGFfbWF4X2VudHJ5X3NpemUsICJNYXguIHNpemUg b2YgYSBub2RlIiB9LAorCXsgInBlcm1pc3Npb25zIiwgJnF1b3RhX25iX3Bl cm1zX3Blcl9ub2RlLAorCQkiTWF4LiBudW1iZXIgb2YgcGVybWlzc2lvbnMg cGVyIG5vZGUiIH0sCisJeyBOVUxMLCBOVUxMLCBOVUxMIH0KK307CisKK3N0 YXRpYyBjb25zdCBzdHJ1Y3QgcXVvdGEgc29mdF9xdW90YXNbXSA9IHsKKwl7 ICJtZW1vcnkiLCAmcXVvdGFfbWVtb3J5X3Blcl9kb21haW5fc29mdCwKKwkJ IlRvdGFsIFhlbnN0b3JlIG1lbW9yeSBwZXIgZG9tYWluICh3YXJuaW5nIGxl dmVsKSIgfSwKKwl7IE5VTEwsIE5VTEwsIE5VTEwgfQorfTsKKworc3RhdGlj IGludCBxdW90YV9zaG93X2N1cnJlbnQoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJCSAgICAgIGNvbnN0IHN0cnVjdCBx dW90YSAqcXVvdGFzKQoreworCWNoYXIgKnJlc3A7CisJdW5zaWduZWQgaW50 IGk7CisKKwlyZXNwID0gdGFsbG9jX3N0cmR1cChjdHgsICJRdW90YSBzZXR0 aW5nczpcbiIpOworCWlmICghcmVzcCkKKwkJcmV0dXJuIEVOT01FTTsKKwor CWZvciAoaSA9IDA7IHF1b3Rhc1tpXS5xdW90YTsgaSsrKSB7CisJCXJlc3Ag PSB0YWxsb2NfYXNwcmludGZfYXBwZW5kKHJlc3AsICIlLTE3czogJThkICVz XG4iLAorCQkJCQkgICAgICBxdW90YXNbaV0ubmFtZSwgKnF1b3Rhc1tpXS5x dW90YSwKKwkJCQkJICAgICAgcXVvdGFzW2ldLmRlc2NyKTsKKwkJaWYgKCFy ZXNwKQorCQkJcmV0dXJuIEVOT01FTTsKKwl9CisKKwlzZW5kX3JlcGx5KGNv bm4sIFhTX0NPTlRST0wsIHJlc3AsIHN0cmxlbihyZXNwKSArIDEpOworCisJ cmV0dXJuIDA7Cit9CisKK3N0YXRpYyBpbnQgcXVvdGFfc2V0KGNvbnN0IHZv aWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICAgY2hh ciAqKnZlYywgaW50IG51bSwgY29uc3Qgc3RydWN0IHF1b3RhICpxdW90YXMp Cit7CisJdW5zaWduZWQgaW50IGk7CisJaW50IHZhbDsKKworCWlmIChudW0g IT0gMikKKwkJcmV0dXJuIEVJTlZBTDsKKworCXZhbCA9IGF0b2kodmVjWzFd KTsKKwlpZiAodmFsIDwgMSkKKwkJcmV0dXJuIEVJTlZBTDsKKworCWZvciAo aSA9IDA7IHF1b3Rhc1tpXS5xdW90YTsgaSsrKSB7CisJCWlmICghc3RyY21w KHZlY1swXSwgcXVvdGFzW2ldLm5hbWUpKSB7CisJCQkqcXVvdGFzW2ldLnF1 b3RhID0gdmFsOworCQkJc2VuZF9hY2soY29ubiwgWFNfQ09OVFJPTCk7CisJ CQlyZXR1cm4gMDsKKwkJfQorCX0KKworCXJldHVybiBFSU5WQUw7Cit9CisK K3N0YXRpYyBpbnQgcXVvdGFfZ2V0KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICAgY2hhciAqKnZlYywgaW50IG51 bSkKK3sKKwlpZiAobnVtICE9IDEpCisJCXJldHVybiBFSU5WQUw7CisKKwly ZXR1cm4gZG9tYWluX2dldF9xdW90YShjdHgsIGNvbm4sIGF0b2kodmVjWzBd KSk7Cit9CisKK3N0YXRpYyBpbnQgZG9fY29udHJvbF9xdW90YSh2b2lkICpj dHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkJICAgIGNoYXIgKip2 ZWMsIGludCBudW0pCit7CisJaWYgKG51bSA9PSAwKQorCQlyZXR1cm4gcXVv dGFfc2hvd19jdXJyZW50KGN0eCwgY29ubiwgaGFyZF9xdW90YXMpOworCisJ aWYgKCFzdHJjbXAodmVjWzBdLCAic2V0IikpCisJCXJldHVybiBxdW90YV9z ZXQoY3R4LCBjb25uLCB2ZWMgKyAxLCBudW0gLSAxLCBoYXJkX3F1b3Rhcyk7 CisKKwlyZXR1cm4gcXVvdGFfZ2V0KGN0eCwgY29ubiwgdmVjLCBudW0pOwor fQorCitzdGF0aWMgaW50IGRvX2NvbnRyb2xfcXVvdGFfcyh2b2lkICpjdHgs IHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkJICAgICAgY2hhciAqKnZl YywgaW50IG51bSkKK3sKKwlpZiAobnVtID09IDApCisJCXJldHVybiBxdW90 YV9zaG93X2N1cnJlbnQoY3R4LCBjb25uLCBzb2Z0X3F1b3Rhcyk7CisKKwlp ZiAoIXN0cmNtcCh2ZWNbMF0sICJzZXQiKSkKKwkJcmV0dXJuIHF1b3RhX3Nl dChjdHgsIGNvbm4sIHZlYyArIDEsIG51bSAtIDEsIHNvZnRfcXVvdGFzKTsK KworCXJldHVybiBFSU5WQUw7Cit9CisKICNpZmRlZiBfX01JTklPU19fCiBz dGF0aWMgaW50IGRvX2NvbnRyb2xfbWVtcmVwb3J0KHZvaWQgKmN0eCwgc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQkJY2hhciAqKnZlYywgaW50IG51 bSkKQEAgLTE1NCw2ICsyNjMsOCBAQCBzdGF0aWMgc3RydWN0IGNtZF9zIGNt ZHNbXSA9IHsKIAl7ICJtZW1yZXBvcnQiLCBkb19jb250cm9sX21lbXJlcG9y dCwgIls8ZmlsZT5dIiB9LAogI2VuZGlmCiAJeyAicHJpbnQiLCBkb19jb250 cm9sX3ByaW50LCAiPHN0cmluZz4iIH0sCisJeyAicXVvdGEiLCBkb19jb250 cm9sX3F1b3RhLCAiW3NldCA8bmFtZT4gPHZhbD58PGRvbWlkPl0iIH0sCisJ eyAicXVvdGEtc29mdCIsIGRvX2NvbnRyb2xfcXVvdGFfcywgIltzZXQgPG5h bWU+IDx2YWw+XSIgfSwKIAl7ICJoZWxwIiwgZG9fY29udHJvbF9oZWxwLCAi IiB9LAogfTsKIApkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2RvbWFpbi5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFp bi5jCmluZGV4IDc4NjNmYTU1NDg3ZC4uZGQzYWUxNWVhNGZkIDEwMDY0NAot LS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMKKysrIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCkBAIC0zMSw2ICsz MSw3IEBACiAjaW5jbHVkZSAieGVuc3RvcmVkX2RvbWFpbi5oIgogI2luY2x1 ZGUgInhlbnN0b3JlZF90cmFuc2FjdGlvbi5oIgogI2luY2x1ZGUgInhlbnN0 b3JlZF93YXRjaC5oIgorI2luY2x1ZGUgInhlbnN0b3JlZF9jb250cm9sLmgi CiAKICNpbmNsdWRlIDx4ZW5ldnRjaG4uaD4KICNpbmNsdWRlIDx4ZW5jdHJs Lmg+CkBAIC0zNDgsNiArMzQ5LDM4IEBAIHN0YXRpYyBzdHJ1Y3QgZG9tYWlu ICpmaW5kX2RvbWFpbl9zdHJ1Y3QodW5zaWduZWQgaW50IGRvbWlkKQogCXJl dHVybiBOVUxMOwogfQogCitpbnQgZG9tYWluX2dldF9xdW90YShjb25zdCB2 b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAorCQkgICAgIHVu c2lnbmVkIGludCBkb21pZCkKK3sKKwlzdHJ1Y3QgZG9tYWluICpkID0gZmlu ZF9kb21haW5fc3RydWN0KGRvbWlkKTsKKwljaGFyICpyZXNwOworCWludCB0 YTsKKworCWlmICghZCkKKwkJcmV0dXJuIEVOT0VOVDsKKworCXRhID0gZC0+ Y29ubiA/IGQtPmNvbm4tPnRyYW5zYWN0aW9uX3N0YXJ0ZWQgOiAwOworCXJl c3AgPSB0YWxsb2NfYXNwcmludGYoY3R4LCAiRG9tYWluICV1OlxuIiwgZG9t aWQpOworCWlmICghcmVzcCkKKwkJcmV0dXJuIEVOT01FTTsKKworI2RlZmlu ZSBlbnQodCwgZSkgXAorCXJlc3AgPSB0YWxsb2NfYXNwcmludGZfYXBwZW5k KHJlc3AsICIlLTE2czogJThkXG4iLCAjdCwgZSk7IFwKKwlpZiAoIXJlc3Ap IHJldHVybiBFTk9NRU0KKworCWVudChub2RlcywgZC0+bmJlbnRyeSk7CisJ ZW50KHdhdGNoZXMsIGQtPm5id2F0Y2gpOworCWVudCh0cmFuc2FjdGlvbnMs IHRhKTsKKwllbnQob3V0c3RhbmRpbmcsIGQtPm5ib3V0c3RhbmRpbmcpOwor CWVudChtZW1vcnksIGQtPm1lbW9yeSk7CisKKyN1bmRlZiBlbnQKKworCXNl bmRfcmVwbHkoY29ubiwgWFNfQ09OVFJPTCwgcmVzcCwgc3RybGVuKHJlc3Ap ICsgMSk7CisKKwlyZXR1cm4gMDsKK30KKwogc3RhdGljIHN0cnVjdCBkb21h aW4gKmFsbG9jX2RvbWFpbih2b2lkICpjb250ZXh0LCB1bnNpZ25lZCBpbnQg ZG9taWQpCiB7CiAJc3RydWN0IGRvbWFpbiAqZG9tYWluOwpkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oCmluZGV4IDNhOGM2YmFiNDhi YS4uZTAxM2E5OTkxY2E4IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfZG9tYWluLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2RvbWFpbi5oCkBAIC05MCw2ICs5MCw4IEBAIGludCBkb21haW5fd2F0 Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pOwogdm9pZCBkb21haW5fb3V0 c3RhbmRpbmdfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsKIHZvaWQg ZG9tYWluX291dHN0YW5kaW5nX2RlYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29u bik7CiB2b2lkIGRvbWFpbl9vdXRzdGFuZGluZ19kb21pZF9kZWModW5zaWdu ZWQgaW50IGRvbWlkKTsKK2ludCBkb21haW5fZ2V0X3F1b3RhKGNvbnN0IHZv aWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICAgdW5z aWduZWQgaW50IGRvbWlkKTsKIAogLyogU3BlY2lhbCBub2RlIHBlcm1pc3Np b24gaGFuZGxpbmcuICovCiBpbnQgc2V0X3Blcm1zX3NwZWNpYWwoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IGNoYXIgKm5hbWUsCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-oxenstored-01.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-oxenstored-01.patch" Content-Transfer-Encoding: base64 RnJvbSBlM2QwYWFjYWY1MzIxYjkyMDRkMmVjNjI4Zjk4YmE2OTQ5NjIzYjIy IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IFN5bmNocm9uaXNlIGRlZmF1 bHRzIHdpdGggb3hlbnN0b3JlLmNvbmYuaW4KTUlNRS1WZXJzaW9uOiAxLjAK Q29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRl bnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCldlIGN1cnJlbnRseSBoYXZl IDIgZGlmZmVyZW50IHNldCBvZiBkZWZhdWx0cyBpbiB1cHN0cmVhbSBYZW4g Z2l0IHRyZWU6CiogZGVmaW5lZCBpbiB0aGUgc291cmNlIGNvZGUsIG9ubHkg dXNlZCBpZiB0aGVyZSBpcyBubyBjb25maWcgZmlsZQoqIGRlZmluZWQgaW4g dGhlIG94ZW5zdG9yZWQuY29uZi5pbiB1cHN0cmVhbSBYZW4KCkFuIG94ZW5z dG9yZWQuY29uZiBmaWxlIGlzIG5vdCBtYW5kYXRvcnksIGFuZCBpZiBtaXNz aW5nLCBtYXhyZXF1ZXN0cyBpbgpwYXJ0aWN1bGFyIGhhcyBhbiB1bnNhZmUg ZGVmYXVsdC4KClJlc3luYyB0aGUgZGVmYXVsdHMgZnJvbSBveGVuc3RvcmVk LmNvbmYuaW4gaW50byB0aGUgc291cmNlIGNvZGUuCgpUaGlzIGlzIHBhcnQg b2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzE2LgoKUmVwb3J0ZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6 IEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2Vk LWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJp eC5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Rl ZmluZS5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKaW5k ZXggZWJlMThiOGUzMTJjLi42YjA2ZjgwODU5NWIgMTAwNjQ0Ci0tLSBhL3Rv b2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKKysrIGIvdG9vbHMvb2Nh bWwveGVuc3RvcmVkL2RlZmluZS5tbApAQCAtMjEsOSArMjEsOSBAQCBsZXQg eHNfZGFlbW9uX3NvY2tldCA9IFBhdGhzLnhlbl9ydW5fc3RvcmVkIF4gIi9z b2NrZXQiCiAKIGxldCBkZWZhdWx0X2NvbmZpZ19kaXIgPSBQYXRocy54ZW5f Y29uZmlnX2RpcgogCi1sZXQgbWF4d2F0Y2ggPSByZWYgKDUwKQotbGV0IG1h eHRyYW5zYWN0aW9uID0gcmVmICgyMCkKLWxldCBtYXhyZXF1ZXN0cyA9IHJl ZiAoLTEpICAgKCogbWF4aW11bSByZXF1ZXN0cyBwZXIgdHJhbnNhY3Rpb24g KikKK2xldCBtYXh3YXRjaCA9IHJlZiAoMTAwKQorbGV0IG1heHRyYW5zYWN0 aW9uID0gcmVmICgxMCkKK2xldCBtYXhyZXF1ZXN0cyA9IHJlZiAoMTAyNCkg ICAoKiBtYXhpbXVtIHJlcXVlc3RzIHBlciB0cmFuc2FjdGlvbiAqKQogCiBs ZXQgY29uZmxpY3RfYnVyc3RfbGltaXQgPSByZWYgNS4wCiBsZXQgY29uZmxp Y3RfbWF4X2hpc3Rvcnlfc2Vjb25kcyA9IHJlZiAwLjA1CmRpZmYgLS1naXQg YS90b29scy9vY2FtbC94ZW5zdG9yZWQvcXVvdGEubWwgYi90b29scy9vY2Ft bC94ZW5zdG9yZWQvcXVvdGEubWwKaW5kZXggYWJjYWM5MTI4MDVhLi42ZTNk NjQwMWFlODkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9x dW90YS5tbAorKysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvcXVvdGEubWwK QEAgLTIwLDggKzIwLDggQEAgZXhjZXB0aW9uIFRyYW5zYWN0aW9uX29wZW5l ZAogCiBsZXQgd2FybiBmbXQgPSBMb2dnaW5nLndhcm4gInF1b3RhIiBmbXQK IGxldCBhY3RpdmF0ZSA9IHJlZiB0cnVlCi1sZXQgbWF4ZW50ID0gcmVmICgx MDAwMCkKLWxldCBtYXhzaXplID0gcmVmICg0MDk2KQorbGV0IG1heGVudCA9 IHJlZiAoMTAwMCkKK2xldCBtYXhzaXplID0gcmVmICgyMDQ4KQogCiB0eXBl IHQgPSB7CiAJbWF4ZW50OiBpbnQ7ICAgICAgICAgICAgICAgKCogbWF4IGVu dGl0aWVzIHBlciBkb21VICopCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-oxenstored-02.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-oxenstored-02.patch" Content-Transfer-Encoding: base64 RnJvbSBiM2IyN2UwY2I2NmI2OWUwYTdkMzU2MmQ3ODQ2YTNlYWZkZDAyYTgw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogVGh1LCAyOCBKdWwgMjAyMiAxNzowODoxNSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IENoZWNrIGZvciBtYXhyZXF1 ZXN0cyBiZWZvcmUgcGVyZm9ybWluZwogb3BlcmF0aW9ucwpNSU1FLVZlcnNp b246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRG LTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKUHJldmlvdXNs eSB3ZSdkIHBlcmZvcm0gdGhlIG9wZXJhdGlvbiwgcmVjb3JkIHRoZSB1cGRh dGVkIHRyZWUgaW4gdGhlCnRyYW5zYWN0aW9uIHJlY29yZCwgdGhlbiB0cnkg dG8gaW5zZXJ0IGEgd2F0Y2hvcCBwYXRoIGFuZCB0aGUgcmVwbHkgcGFja2V0 LgoKSWYgd2UgZXhjZWVkZWQgbWF4IHJlcXVlc3RzIHdlIHdvdWxkJ3ZlIHJl dHVybmVkIEVRVU9UQSwgYnV0IHN0aWxsOgoqIGhhdmUgcGVyZm9ybWVkIHRo ZSBvcGVyYXRpb24gb24gdGhlIHRyYW5zYWN0aW9uJ3MgdHJlZQoqIGhhdmUg cmVjb3JkZWQgdGhlIHdhdGNob3AsIG1ha2luZyB0aGlzIHF1ZXVlIGVmZmVj dGl2ZWx5IHVuYm91bmRlZAoKSXQgaXMgYmV0dGVyIGlmIHdlIGNoZWNrIHdo ZXRoZXIgd2UnZCBoYXZlIHJvb20gdG8gc3RvcmUgdGhlIG9wZXJhdGlvbiBi ZWZvcmUKcGVyZm9ybWluZyB0aGUgdHJhbnNhY3Rpb24sIGFuZCByYWlzZSBF UVVPVEEgdGhlcmUuICBUaGVuIHRoZSB0cmFuc2FjdGlvbgpyZWNvcmQgd29u J3QgZ3Jvdy4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2IC8gQ1ZFLTIwMjIt NDIzMTcuCgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1h em9uLmNvbT4KU2lnbmVkLW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4u dG9yb2tAY2l0cml4LmNvbT4KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcg PGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbCBiL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9wcm9jZXNzLm1sCmluZGV4IDI3NzkwZDRhNWM0MS4uZGQ1 OGU2OTc5Y2Y5IDEwMDY0NAotLS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQv cHJvY2Vzcy5tbAorKysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vz cy5tbApAQCAtMzg5LDYgKzM4OSw3IEBAIGxldCBpbnB1dF9oYW5kbGVfZXJy b3IgfmNvbnMgfmRvbXMgfmZjdCB+Y29uIH50IH5yZXEgPQogCWxldCByZXBs eV9lcnJvciBlID0KIAkJUGFja2V0LkVycm9yIGUgaW4KIAl0cnkKKwkJVHJh bnNhY3Rpb24uY2hlY2tfcXVvdGFfZXhuIH5wZXJtOihDb25uZWN0aW9uLmdl dF9wZXJtIGNvbikgdDsKIAkJZmN0IGNvbiB0IGRvbXMgY29ucyByZXEuUGFj a2V0LmRhdGEKIAl3aXRoCiAJfCBEZWZpbmUuSW52YWxpZF9wYXRoICAgICAg ICAgIC0+IHJlcGx5X2Vycm9yICJFSU5WQUwiCkBAIC02ODEsOSArNjgyLDEw IEBAIGxldCBwcm9jZXNzX3BhY2tldCB+c3RvcmUgfmNvbnMgfmRvbXMgfmNv biB+cmVxID0KIAkJaW4KIAogCQlsZXQgcmVzcG9uc2UgPSB0cnkKKwkJCVRy YW5zYWN0aW9uLmNoZWNrX3F1b3RhX2V4biB+cGVybTooQ29ubmVjdGlvbi5n ZXRfcGVybSBjb24pIHQ7CiAJCQlpZiB0aWQgPD4gVHJhbnNhY3Rpb24ubm9u ZSB0aGVuCiAJCQkJKCogUmVtZW1iZXIgdGhlIHJlcXVlc3QgYW5kIHJlc3Bv bnNlIGZvciB0aGlzIG9wZXJhdGlvbiBpbiBjYXNlIHdlIG5lZWQgdG8gcmVw bGF5IHRoZSB0cmFuc2FjdGlvbiAqKQotCQkJCVRyYW5zYWN0aW9uLmFkZF9v cGVyYXRpb24gfnBlcm06KENvbm5lY3Rpb24uZ2V0X3Blcm0gY29uKSB0IHJl cSByZXNwb25zZTsKKwkJCQlUcmFuc2FjdGlvbi5hZGRfb3BlcmF0aW9uIHQg cmVxIHJlc3BvbnNlOwogCQkJcmVzcG9uc2UKIAkJd2l0aCBRdW90YS5MaW1p dF9yZWFjaGVkIC0+CiAJCQlQYWNrZXQuRXJyb3IgIkVRVU9UQSIKZGlmZiAt LWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbCBi L3Rvb2xzL29jYW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbAppbmRleCAx N2IxYmRmMmVhZjkuLjI5NDE0M2UyMzM1YiAxMDA2NDQKLS0tIGEvdG9vbHMv b2NhbWwveGVuc3RvcmVkL3RyYW5zYWN0aW9uLm1sCisrKyBiL3Rvb2xzL29j YW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbApAQCAtODUsNiArODUsNyBA QCB0eXBlIHQgPSB7CiAJb2xkcm9vdDogU3RvcmUuTm9kZS50OwogCW11dGFi bGUgcGF0aHM6IChYZW5idXMuWGIuT3Aub3BlcmF0aW9uICogU3RvcmUuUGF0 aC50KSBsaXN0OwogCW11dGFibGUgb3BlcmF0aW9uczogKFBhY2tldC5yZXF1 ZXN0ICogUGFja2V0LnJlc3BvbnNlKSBsaXN0OworCW11dGFibGUgcXVvdGFf cmVhY2hlZDogYm9vbDsKIAltdXRhYmxlIHJlYWRfbG93cGF0aDogU3RvcmUu UGF0aC50IG9wdGlvbjsKIAltdXRhYmxlIHdyaXRlX2xvd3BhdGg6IFN0b3Jl LlBhdGgudCBvcHRpb247CiB9CkBAIC0xMjcsNiArMTI4LDcgQEAgbGV0IG1h a2UgPyhpbnRlcm5hbD1mYWxzZSkgaWQgc3RvcmUgPQogCQlvbGRyb290ID0g U3RvcmUuZ2V0X3Jvb3Qgc3RvcmU7CiAJCXBhdGhzID0gW107CiAJCW9wZXJh dGlvbnMgPSBbXTsKKwkJcXVvdGFfcmVhY2hlZCA9IGZhbHNlOwogCQlyZWFk X2xvd3BhdGggPSBOb25lOwogCQl3cml0ZV9sb3dwYXRoID0gTm9uZTsKIAl9 IGluCkBAIC0xNDMsMTMgKzE0NSwxOSBAQCBsZXQgZ2V0X3Jvb3QgdCA9IFN0 b3JlLmdldF9yb290IHQuc3RvcmUKIAogbGV0IGlzX3JlYWRfb25seSB0ID0g dC5wYXRocyA9IFtdCiBsZXQgYWRkX3dvcCB0IHR5IHBhdGggPSB0LnBhdGhz IDwtICh0eSwgcGF0aCkgOjogdC5wYXRocwotbGV0IGFkZF9vcGVyYXRpb24g fnBlcm0gdCByZXF1ZXN0IHJlc3BvbnNlID0KK2xldCBnZXRfb3BlcmF0aW9u cyB0ID0gTGlzdC5yZXYgdC5vcGVyYXRpb25zCisKK2xldCBjaGVja19xdW90 YV9leG4gfnBlcm0gdCA9CiAJaWYgIURlZmluZS5tYXhyZXF1ZXN0cyA+PSAw CiAJCSYmIG5vdCAoUGVybXMuQ29ubmVjdGlvbi5pc19kb20wIHBlcm0pCi0J CSYmIExpc3QubGVuZ3RoIHQub3BlcmF0aW9ucyA+PSAhRGVmaW5lLm1heHJl cXVlc3RzCi0JCXRoZW4gcmFpc2UgUXVvdGEuTGltaXRfcmVhY2hlZDsKKwkJ JiYgKHQucXVvdGFfcmVhY2hlZCB8fCBMaXN0Lmxlbmd0aCB0Lm9wZXJhdGlv bnMgPj0gIURlZmluZS5tYXhyZXF1ZXN0cykKKwkJdGhlbiBiZWdpbgorCQkJ dC5xdW90YV9yZWFjaGVkIDwtIHRydWU7CisJCQlyYWlzZSBRdW90YS5MaW1p dF9yZWFjaGVkOworCQllbmQKKworbGV0IGFkZF9vcGVyYXRpb24gdCByZXF1 ZXN0IHJlc3BvbnNlID0KIAl0Lm9wZXJhdGlvbnMgPC0gKHJlcXVlc3QsIHJl c3BvbnNlKSA6OiB0Lm9wZXJhdGlvbnMKLWxldCBnZXRfb3BlcmF0aW9ucyB0 ID0gTGlzdC5yZXYgdC5vcGVyYXRpb25zCiBsZXQgc2V0X3JlYWRfbG93cGF0 aCB0IHBhdGggPSB0LnJlYWRfbG93cGF0aCA8LSBnZXRfbG93ZXN0IHBhdGgg dC5yZWFkX2xvd3BhdGgKIGxldCBzZXRfd3JpdGVfbG93cGF0aCB0IHBhdGgg PSB0LndyaXRlX2xvd3BhdGggPC0gZ2V0X2xvd2VzdCBwYXRoIHQud3JpdGVf bG93cGF0aAogCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-oxenstored-03.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-oxenstored-03.patch" Content-Transfer-Encoding: base64 RnJvbSA0OWNlNjY1OGFlZTc5ODFhNGUxOTI1ZTQ0OWJiZjk5ZjRlOGFmMzli IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNyArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogR0MgcGFyYW1ldGVyIHR1bmluZwpNSU1FLVZl cnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9 VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKQnkgZGVm YXVsdCB0aGUgT0NhbWwgZ2FyYmFnZSBjb2xsZWN0b3Igd291bGQgcmV0dXJu IG1lbW9yeSB0byB0aGUgT1Mgb25seQphZnRlciB1bnVzZWQgbWVtb3J5IGlz IDV4IGxpdmUgbWVtb3J5LiAgVHdlYWsgdGhpcyB0byAxMjAlIGluc3RlYWQs IHdoaWNoCndvdWxkIG1hdGNoIHRoZSBtYWpvciBHQyBzcGVlZC4KClRoaXMg aXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEVkd2luIFTD tnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJp c3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+Cgpk aWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RlZmluZS5tbCBi L3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKaW5kZXggNmIwNmY4 MDg1OTViLi5iYTYzYTgxNDdlMDkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9kZWZpbmUubWwKKysrIGIvdG9vbHMvb2NhbWwveGVuc3Rv cmVkL2RlZmluZS5tbApAQCAtMjUsNiArMjUsNyBAQCBsZXQgbWF4d2F0Y2gg PSByZWYgKDEwMCkKIGxldCBtYXh0cmFuc2FjdGlvbiA9IHJlZiAoMTApCiBs ZXQgbWF4cmVxdWVzdHMgPSByZWYgKDEwMjQpICAgKCogbWF4aW11bSByZXF1 ZXN0cyBwZXIgdHJhbnNhY3Rpb24gKikKIAorbGV0IGdjX21heF9vdmVyaGVh ZCA9IHJlZiAxMjAgKCogMTIwJSBzZWUgY29tbWVudCBpbiB4ZW5zdG9yZWQu bWwgKikKIGxldCBjb25mbGljdF9idXJzdF9saW1pdCA9IHJlZiA1LjAKIGxl dCBjb25mbGljdF9tYXhfaGlzdG9yeV9zZWNvbmRzID0gcmVmIDAuMDUKIGxl dCBjb25mbGljdF9yYXRlX2xpbWl0X2lzX2FnZ3JlZ2F0ZSA9IHJlZiB0cnVl CmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQveGVuc3RvcmVk Lm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbAppbmRl eCBkNDRhZTY3M2M0MmEuLjNiNTdhZDAxNmRmYiAxMDA2NDQKLS0tIGEvdG9v bHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbAorKysgYi90b29scy9v Y2FtbC94ZW5zdG9yZWQveGVuc3RvcmVkLm1sCkBAIC0xMDQsNiArMTA0LDcg QEAgbGV0IHBhcnNlX2NvbmZpZyBmaWxlbmFtZSA9CiAJCSgicXVvdGEtbWF4 c2l6ZSIsIENvbmZpZy5TZXRfaW50IFF1b3RhLm1heHNpemUpOwogCQkoInF1 b3RhLW1heHJlcXVlc3RzIiwgQ29uZmlnLlNldF9pbnQgRGVmaW5lLm1heHJl cXVlc3RzKTsKIAkJKCJxdW90YS1wYXRoLW1heCIsIENvbmZpZy5TZXRfaW50 IERlZmluZS5wYXRoX21heCk7CisJCSgiZ2MtbWF4LW92ZXJoZWFkIiwgQ29u ZmlnLlNldF9pbnQgRGVmaW5lLmdjX21heF9vdmVyaGVhZCk7CiAJCSgidGVz dC1lYWdhaW4iLCBDb25maWcuU2V0X2Jvb2wgVHJhbnNhY3Rpb24udGVzdF9l YWdhaW4pOwogCQkoInBlcnNpc3RlbnQiLCBDb25maWcuU2V0X2Jvb2wgRGlz ay5lbmFibGUpOwogCQkoInhlbnN0b3JlZC1sb2ctZmlsZSIsIENvbmZpZy5T dHJpbmcgTG9nZ2luZy5zZXRfeGVuc3RvcmVkX2xvZ19kZXN0aW5hdGlvbik7 CkBAIC0yNjUsNiArMjY2LDY3IEBAIGxldCB0b19maWxlIHN0b3JlIGNvbnMg ZmRzIGZpbGUgPQogCSAgICAgICAgKGZ1biAoKSAtPiBjbG9zZV9vdXQgY2hh bm5lbCkKIGVuZAogCisoKgorCUJ5IGRlZmF1bHQgT0NhbWwncyBHQyBvbmx5 IHJldHVybnMgbWVtb3J5IHRvIHRoZSBPUyB3aGVuIGl0IGV4Y2VlZHMgYQor CWNvbmZpZ3VyYWJsZSAnbWF4IG92ZXJoZWFkJyBzZXR0aW5nLgorCVRoZSBk ZWZhdWx0IGlzIDUwMCUsIHRoYXQgaXMgNS82dGggb2YgdGhlIE9DYW1sIGhl YXAgbmVlZHMgdG8gYmUgZnJlZQorCWFuZCBvbmx5IDEvNnRoIGxpdmUgZm9y IGEgY29tcGFjdGlvbiB0byBiZSB0cmlnZ2VycmVkIHRoYXQgd291bGQKKwly ZWxlYXNlIG1lbW9yeSBiYWNrIHRvIHRoZSBPUy4KKwlJZiB0aGUgbGltaXQg aXMgbm90IGhpdCB0aGVuIHRoZSBPQ2FtbCBwcm9jZXNzIGNhbiByZXVzZSB0 aGF0IG1lbW9yeQorCWZvciBpdHMgb3duIHB1cnBvc2VzLCBidXQgb3RoZXIg cHJvY2Vzc2VzIHdvbid0IGJlIGFibGUgdG8gdXNlIGl0LgorCisJVGhlcmUg aXMgYWxzbyBhICdzcGFjZSBvdmVyaGVhZCcgc2V0dGluZyB0aGF0IGNvbnRy b2xzIGhvdyBtdWNoIHdvcmsKKwllYWNoIG1ham9yIEdDIHNsaWNlIGRvZXMs IGFuZCBieSBkZWZhdWx0IGFpbXMgYXQgaGF2aW5nIG5vIG1vcmUgdGhhbgor CTgwJSBvciAxMjAlIChkZXBlbmRpbmcgb24gdmVyc2lvbikgZ2FyYmFnZSB2 YWx1ZXMgY29tcGFyZWQgdG8gbGl2ZQorCXZhbHVlcy4KKwlUaGlzIGRvZXNu J3QgaGF2ZSBhcyBtdWNoIHJlbGV2YW5jZSB0byBtZW1vcnkgcmV0dXJuZWQg dG8gdGhlIE9TIGFzCisJbG9uZyBhcyBzcGFjZV9vdmVyaGVhZCA8PSBtYXhf b3ZlcmhlYWQsIGJlY2F1c2UgY29tcGFjdGlvbiBpcyBvbmx5CisJdHJpZ2dl cnJlZCBhdCB0aGUgZW5kIG9mIG1ham9yIEdDIGN5Y2xlcy4KKworCVRoZSBk ZWZhdWx0cyBhcmUgdG9vIGxhcmdlIG9uY2UgdGhlIHByb2dyYW0gc3RhcnRz IHVzaW5nIH4xMDBNaUIgb2YKKwltZW1vcnksIGF0IHdoaWNoIHBvaW50IH41 MDBNaUIgd291bGQgYmUgdW5hdmFpbGFibGUgdG8gb3RoZXIgcHJvY2Vzc2Vz CisJKHdoaWNoIHdvdWxkIGJlIGZpbmUgaWYgdGhpcyB3YXMgdGhlIG1haW4g cHJvY2VzcyBpbiB0aGlzIFZNLCBidXQgaXQgaXMKKwlub3QpLgorCisJTWF4 IG92ZXJoZWFkIGNhbiBhbHNvIGJlIHNldCB0byAwLCBob3dldmVyIHRoaXMg aXMgZm9yIHRlc3RpbmcgcHVycG9zZXMKKwlvbmx5IChzZXR0aW5nIGl0IGxv d2VyIHRoYW4gJ3NwYWNlIG92ZXJoZWFkJyB3b3VsZG4ndCBoZWxwIGJlY2F1 c2UgdGhlCisJbWFqb3IgR0Mgd291bGRuJ3QgcnVuIGZhc3QgZW5vdWdoLCBh bmQgY29tcGFjdGlvbiBkb2VzIGhhdmUgYQorCXBlcmZvcm1hbmNlIGNvc3Q6 IHdlIGNhbiBvbmx5IGNvbXBhY3QgY29udGlndW91cyByZWdpb25zLCBzbyBt ZW1vcnkgaGFzCisJdG8gYmUgbW92ZWQgYXJvdW5kKS4KKworCU1heCBvdmVy aGVhZCBjb250cm9scyBob3cgb2Z0ZW4gdGhlIGhlYXAgaXMgY29tcGFjdGVk LCB3aGljaCBpcyB1c2VmdWwKKwlpZiB0aGVyZSBhcmUgYnVyc3Qgb2YgYWN0 aXZpdHkgZm9sbG93ZWQgYnkgbG9uZyBwZXJpb2RzIG9mIGlkbGUgc3RhdGUs CisJb3IgaWYgYSBkb21haW4gcXVpdHMsIGV0Yy4gQ29tcGFjdGlvbiByZXR1 cm5zIG1lbW9yeSB0byB0aGUgT1MuCisKKwl3YXN0ZWQgPSBsaXZlICogc3Bh Y2Vfb3ZlcmhlYWQgLyAxMDAKKworCUZvciBnbG9iYWxseSBvdmVycmlkaW5n IHRoZSBHQyBzZXR0aW5ncyBvbmUgY2FuIHVzZSBPQ0FNTFJVTlBBUkFNLAor CWhvd2V2ZXIgd2UgcHJvdmlkZSBhIGNvbmZpZyBmaWxlIG92ZXJyaWRlIHRv IGJlIGNvbnNpc3RlbnQgd2l0aCBvdGhlcgorCW94ZW5zdG9yZWQgc2V0dGlu Z3MuCisKKwlPbmUgbWlnaHQgd2FudCB0byBkeW5hbWljYWxseSBhZGp1c3Qg dGhlIG92ZXJoZWFkIHNldHRpbmcgYmFzZWQgb24gdXNlZAorCW1lbW9yeSwg aS5lLiB0byB1c2UgYSBmaXhlZCB1cHBlciBib3VuZCBpbiBieXRlcywgbm90 IHBlcmNlbnRhZ2UuIEhvd2V2ZXIKKwltZWFzdXJlbWVudHMgc2hvdyB0aGF0 IHN1Y2ggYWRqdXN0bWVudHMgaW5jcmVhc2UgR0Mgb3ZlcmhlYWQgbWFzc2l2 ZWx5LAorCXdoaWxlIHN0aWxsIG5vdCBndWFyYW50ZWVpbmcgdGhhdCBtZW1v cnkgaXMgcmV0dXJuZWQgYW55IG1vcmUgcXVpY2tseQorCXRoYW4gd2l0aCBh IHBlcmNlbnRhZ2UgYmFzZWQgc2V0dGluZy4KKworCVRoZSBhbGxvY2F0aW9u IHBvbGljeSBjb3VsZCBhbHNvIGJlIHR3ZWFrZWQsIGUuZy4gZmlyc3QgZml0 IHdvdWxkIHJlZHVjZQorCWZyYWdtZW50YXRpb24gYW5kIHRodXMgbWVtb3J5 IHVzYWdlLCBidXQgdGhlIGRvY3VtZW50YXRpb24gd2FybnMgdGhhdCBpdAor CWNhbiBiZSBzZW5zaWJseSBzbG93ZXIsIGFuZCBpbmRlZWQgb25lIG9mIG91 ciBvd24gdGVzdGNhc2VzIGNhbiB0cmlnZ2VyCisJc3VjaCBhIGNvcm5lciBj YXNlIHdoZXJlIGl0IGlzIG11bHRpcGxlIHRpbWVzIHNsb3dlciwgc28gaXQg aXMgYmVzdCB0byBrZWVwCisJdGhlIGRlZmF1bHQgYWxsb2NhdGlvbiBwb2xp Y3kgKG5leHQtZml0L2Jlc3QtZml0IGRlcGVuZGluZyBvbiB2ZXJzaW9uKS4K KworCVRoZXJlIGFyZSBvdGhlciB0d2Vha3MgdGhhdCBjYW4gYmUgYXR0ZW1w dGVkIGluIHRoZSBmdXR1cmUsIGUuZy4gc2V0dGluZworCSd1bGltaXQgLXYn IHRvIDc1JSBvZiBSQU0sIGhvd2V2ZXIgZ2V0dGluZyB0aGUga2VybmVsIHRv IGFjdHVhbGx5IHJldHVybgorCU5VTEwgZnJvbSBhbGxvY2F0aW9ucyBpcyBk aWZmaWN1bHQgZXZlbiB3aXRoIHRoYXQgc2V0dGluZywgYW5kIHdpdGhvdXQg YQorCU5VTEwgdGhlIGVtZXJnZW5jeSBHQyB3b24ndCBiZSB0cmlnZ2VycmVk LgorCVBlcmhhcHMgY2dyb3VwIGxpbWl0cyBjb3VsZCBoZWxwLCBidXQgZm9y IG5vdyB0d2VhayB0aGUgc2FmZXN0IG9ubHkuCisqKQorCitsZXQgdHdlYWtf Z2MgKCkgPQorCUdjLnNldCB7IChHYy5nZXQgKCkpIHdpdGggR2MubWF4X292 ZXJoZWFkID0gIURlZmluZS5nY19tYXhfb3ZlcmhlYWQgfQorCisKIGxldCBf ID0KIAlsZXQgY2YgPSBkb19hcmd2IGluCiAJbGV0IHBpZGZpbGUgPQpAQCAt Mjc0LDYgKzMzNiw4IEBAIGxldCBfID0KIAkJCWRlZmF1bHRfcGlkZmlsZQog CQlpbgogCisJdHdlYWtfZ2MgKCk7CisKIAkodHJ5CiAJCVVuaXhleHQubWtk aXJfcmVjIChGaWxlbmFtZS5kaXJuYW1lIHBpZGZpbGUpIDBvNzU1CiAJd2l0 aCBfIC0+Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-oxenstored-04.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-oxenstored-04.patch" Content-Transfer-Encoding: base64 RnJvbSA2MmQwNWI5ZWQ1MzhjM2MxMDY0MjE1ZmIxNDMwYmI5YjFjNDlkZjRk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogRnJpLCAyOSBKdWwgMjAyMiAxODo1MzoyOSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC9saWJzL3hiOiBoaWRlIHR5cGUgb2YgWGIudApN SU1FLVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNo YXJzZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoK SGlkaW5nIHRoZSB0eXBlIHdpbGwgbWFrZSBpdCBlYXNpZXIgdG8gY2hhbmdl IHRoZSBpbXBsZW1lbnRhdGlvbgppbiB0aGUgZnV0dXJlIHdpdGhvdXQgYnJl YWtpbmcgY29kZSB0aGF0IHJlbGllcyBvbiBpdC4KCk5vIGZ1bmN0aW9uYWwg Y2hhbmdlLgoKU2lnbmVkLW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4u dG9yb2tAY2l0cml4LmNvbT4KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcg PGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4KKGNoZXJyeSBwaWNrZWQg ZnJvbSBjb21taXQgN2FkZTMwYTE0NTE3MzRkMDQxMzYzYzc1MGE2NWQzMjJl MjViNDdiYSkKClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBh bWF6b24uY29tPgpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yi94 Yi5tbCBiL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWwKaW5kZXggMTA0ZDMx OWQ3NzQ3Li44NDA0ZGRkOGE2ODIgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1s L2xpYnMveGIveGIubWwKKysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5t bApAQCAtMTk2LDYgKzE5Niw5IEBAIGxldCBwZWVrX291dHB1dCBjb24gPSBR dWV1ZS5wZWVrIGNvbi5wa3Rfb3V0CiBsZXQgaW5wdXRfbGVuIGNvbiA9IFF1 ZXVlLmxlbmd0aCBjb24ucGt0X2luCiBsZXQgaGFzX2luX3BhY2tldCBjb24g PSBRdWV1ZS5sZW5ndGggY29uLnBrdF9pbiA+IDAKIGxldCBnZXRfaW5fcGFj a2V0IGNvbiA9IFF1ZXVlLnBvcCBjb24ucGt0X2luCitsZXQgaGFzX3BhcnRp YWxfaW5wdXQgY29uID0gbWF0Y2ggY29uLnBhcnRpYWxfaW4gd2l0aAorCXwg SGF2ZUhkciBfIC0+IHRydWUKKwl8IE5vSGRyIChuLCBfKSAtPiBuIDwgUGFy dGlhbC5oZWFkZXJfc2l6ZSAoKQogbGV0IGhhc19tb3JlX2lucHV0IGNvbiA9 CiAJbWF0Y2ggY29uLmJhY2tlbmQgd2l0aAogCXwgRmQgXyAgICAgICAgIC0+ IGZhbHNlCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aSBiL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWxpCmluZGV4IDNhMDBkYTZj ZGRjMS4uNzk0ZTM1YmIzNDNlIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9s aWJzL3hiL3hiLm1saQorKysgYi90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aQpAQCAtNjYsMTMgKzY2LDcgQEAgdHlwZSBiYWNrZW5kX21tYXAgPSB7CiB0 eXBlIGJhY2tlbmRfZmQgPSB7IGZkIDogVW5peC5maWxlX2Rlc2NyOyB9CiB0 eXBlIGJhY2tlbmQgPSBGZCBvZiBiYWNrZW5kX2ZkIHwgWGVubW1hcCBvZiBi YWNrZW5kX21tYXAKIHR5cGUgcGFydGlhbF9idWYgPSBIYXZlSGRyIG9mIFBh cnRpYWwucGt0IHwgTm9IZHIgb2YgaW50ICogYnl0ZXMKLXR5cGUgdCA9IHsK LSAgYmFja2VuZCA6IGJhY2tlbmQ7Ci0gIHBrdF9pbiA6IFBhY2tldC50IFF1 ZXVlLnQ7Ci0gIHBrdF9vdXQgOiBQYWNrZXQudCBRdWV1ZS50OwotICBtdXRh YmxlIHBhcnRpYWxfaW4gOiBwYXJ0aWFsX2J1ZjsKLSAgbXV0YWJsZSBwYXJ0 aWFsX291dCA6IHN0cmluZzsKLX0KK3R5cGUgdAogdmFsIGluaXRfcGFydGlh bF9pbiA6IHVuaXQgLT4gcGFydGlhbF9idWYKIHZhbCByZWNvbm5lY3QgOiB0 IC0+IHVuaXQKIHZhbCBxdWV1ZSA6IHQgLT4gUGFja2V0LnQgLT4gdW5pdApA QCAtOTcsNiArOTEsNyBAQCB2YWwgaGFzX291dHB1dCA6IHQgLT4gYm9vbAog dmFsIHBlZWtfb3V0cHV0IDogdCAtPiBQYWNrZXQudAogdmFsIGlucHV0X2xl biA6IHQgLT4gaW50CiB2YWwgaGFzX2luX3BhY2tldCA6IHQgLT4gYm9vbAor dmFsIGhhc19wYXJ0aWFsX2lucHV0IDogdCAtPiBib29sCiB2YWwgZ2V0X2lu X3BhY2tldCA6IHQgLT4gUGFja2V0LnQKIHZhbCBoYXNfbW9yZV9pbnB1dCA6 IHQgLT4gYm9vbAogdmFsIGlzX3NlbGVjdGFibGUgOiB0IC0+IGJvb2wKZGlm ZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9uLm1s IGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Nvbm5lY3Rpb24ubWwKaW5kZXgg NjVmOTllYTZmMjhhLi4zOGI0NzM2M2ExNzMgMTAwNjQ0Ci0tLSBhL3Rvb2xz L29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9uLm1sCisrKyBiL3Rvb2xzL29j YW1sL3hlbnN0b3JlZC9jb25uZWN0aW9uLm1sCkBAIC0xMjUsOSArMTI1LDcg QEAgbGV0IGdldF9wZXJtIGNvbiA9CiBsZXQgc2V0X3RhcmdldCBjb24gdGFy Z2V0X2RvbWlkID0KIAljb24ucGVybSA8LSBQZXJtcy5Db25uZWN0aW9uLnNl dF90YXJnZXQgKGdldF9wZXJtIGNvbikgfnBlcm1zOltQZXJtcy5SRUFEOyBQ ZXJtcy5XUklURV0gdGFyZ2V0X2RvbWlkCiAKLWxldCBpc19iYWNrZW5kX21t YXAgY29uID0gbWF0Y2ggY29uLnhiLlhlbmJ1cy5YYi5iYWNrZW5kIHdpdGgK LQl8IFhlbmJ1cy5YYi5YZW5tbWFwIF8gLT4gdHJ1ZQotCXwgXyAtPiBmYWxz ZQorbGV0IGlzX2JhY2tlbmRfbW1hcCBjb24gPSBYZW5idXMuWGIuaXNfbW1h cCBjb24ueGIKIAogbGV0IHNlbmRfcmVwbHkgY29uIHRpZCByaWQgdHkgZGF0 YSA9CiAJaWYgKFN0cmluZy5sZW5ndGggZGF0YSkgPiB4ZW5zdG9yZV9wYXls b2FkX21heCAmJiAoaXNfYmFja2VuZF9tbWFwIGNvbikgdGhlbgpAQCAtMjgw LDkgKzI3OCw3IEBAIGxldCBnZXRfdHJhbnNhY3Rpb24gY29uIHRpZCA9CiAK IGxldCBkb19pbnB1dCBjb24gPSBYZW5idXMuWGIuaW5wdXQgY29uLnhiCiBs ZXQgaGFzX2lucHV0IGNvbiA9IFhlbmJ1cy5YYi5oYXNfaW5fcGFja2V0IGNv bi54YgotbGV0IGhhc19wYXJ0aWFsX2lucHV0IGNvbiA9IG1hdGNoIGNvbi54 Yi5YZW5idXMuWGIucGFydGlhbF9pbiB3aXRoCi0JfCBIYXZlSGRyIF8gLT4g dHJ1ZQotCXwgTm9IZHIgKG4sIF8pIC0+IG4gPCBYZW5idXMuUGFydGlhbC5o ZWFkZXJfc2l6ZSAoKQorbGV0IGhhc19wYXJ0aWFsX2lucHV0IGNvbiA9IFhl bmJ1cy5YYi5oYXNfcGFydGlhbF9pbnB1dCBjb24ueGIKIGxldCBwb3BfaW4g Y29uID0gWGVuYnVzLlhiLmdldF9pbl9wYWNrZXQgY29uLnhiCiBsZXQgaGFz X21vcmVfaW5wdXQgY29uID0gWGVuYnVzLlhiLmhhc19tb3JlX2lucHV0IGNv bi54YgogCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-oxenstored-05.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-oxenstored-05.patch" Content-Transfer-Encoding: base64 RnJvbSAxMWNlNTE5NjkzMjQ0NWNjZjY2NzlkMDRlZjJlMTk2Mzk1MTk2N2Mx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMiArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogQ2hhbmdlIFhiLmlucHV0IHRvIHJldHVybiBQ YWNrZXQudCBvcHRpb24KTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBl OiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXIt RW5jb2Rpbmc6IDhiaXQKClRoZSBxdWV1ZSBoZXJlIHdvdWxkIG9ubHkgZXZl ciBob2xkIGF0IG1vc3Qgb25lIGVsZW1lbnQuICBUaGlzIHdpbGwgc2ltcGxp ZnkKZm9sbG93LXVwIHBhdGNoZXMuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMy Ni4KClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24u Y29tPgpTaWduZWQtb2ZmLWJ5OiBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jv a0BjaXRyaXguY29tPgpBY2tlZC1ieTogQ2hyaXN0aWFuIExpbmRpZyA8Y2hy aXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xz L29jYW1sL2xpYnMveGIveGIubWwgYi90b29scy9vY2FtbC9saWJzL3hiL3hi Lm1sCmluZGV4IDg0MDRkZGQ4YTY4Mi4uMTY1ZmQ0YTFlZGY0IDEwMDY0NAot LS0gYS90b29scy9vY2FtbC9saWJzL3hiL3hiLm1sCisrKyBiL3Rvb2xzL29j YW1sL2xpYnMveGIveGIubWwKQEAgLTQ1LDcgKzQ1LDYgQEAgdHlwZSBwYXJ0 aWFsX2J1ZiA9IEhhdmVIZHIgb2YgUGFydGlhbC5wa3QgfCBOb0hkciBvZiBp bnQgKiBieXRlcwogdHlwZSB0ID0KIHsKIAliYWNrZW5kOiBiYWNrZW5kOwot CXBrdF9pbjogUGFja2V0LnQgUXVldWUudDsKIAlwa3Rfb3V0OiBQYWNrZXQu dCBRdWV1ZS50OwogCW11dGFibGUgcGFydGlhbF9pbjogcGFydGlhbF9idWY7 CiAJbXV0YWJsZSBwYXJ0aWFsX291dDogc3RyaW5nOwpAQCAtNjIsNyArNjEs NiBAQCBsZXQgcmVjb25uZWN0IHQgPSBtYXRjaCB0LmJhY2tlbmQgd2l0aAog CQlYc19yaW5nLmNsb3NlIGJhY2tlbmQubW1hcDsKIAkJYmFja2VuZC5ldmVu dGNobl9ub3RpZnkgKCk7CiAJCSgqIENsZWFyIG91ciBvbGQgY29ubmVjdGlv biBzdGF0ZSAqKQotCQlRdWV1ZS5jbGVhciB0LnBrdF9pbjsKIAkJUXVldWUu Y2xlYXIgdC5wa3Rfb3V0OwogCQl0LnBhcnRpYWxfaW4gPC0gaW5pdF9wYXJ0 aWFsX2luICgpOwogCQl0LnBhcnRpYWxfb3V0IDwtICIiCkBAIC0xMjQsNyAr MTIyLDYgQEAgbGV0IG91dHB1dCBjb24gPQogCiAoKiBOQjogY2FuIHRocm93 IFJlY29ubmVjdCAqKQogbGV0IGlucHV0IGNvbiA9Ci0JbGV0IG5ld3BhY2tl dCA9IHJlZiBmYWxzZSBpbgogCWxldCB0b19yZWFkID0KIAkJbWF0Y2ggY29u LnBhcnRpYWxfaW4gd2l0aAogCQl8IEhhdmVIZHIgcGFydGlhbF9wa3QgLT4g UGFydGlhbC50b19jb21wbGV0ZSBwYXJ0aWFsX3BrdApAQCAtMTQzLDIxICsx NDAsMTkgQEAgbGV0IGlucHV0IGNvbiA9CiAJCWlmIFBhcnRpYWwudG9fY29t cGxldGUgcGFydGlhbF9wa3QgPSAwIHRoZW4gKAogCQkJbGV0IHBrdCA9IFBh Y2tldC5vZl9wYXJ0aWFscGt0IHBhcnRpYWxfcGt0IGluCiAJCQljb24ucGFy dGlhbF9pbiA8LSBpbml0X3BhcnRpYWxfaW4gKCk7Ci0JCQlRdWV1ZS5wdXNo IHBrdCBjb24ucGt0X2luOwotCQkJbmV3cGFja2V0IDo9IHRydWUKLQkJKQor CQkJU29tZSBwa3QKKwkJKSBlbHNlIE5vbmUKIAl8IE5vSGRyIChpLCBidWYp ICAgICAgLT4KIAkJKCogd2UgY29tcGxldGUgdGhlIHBhcnRpYWwgaGVhZGVy ICopCiAJCWlmIHN6ID4gMCB0aGVuCiAJCQlCeXRlcy5ibGl0IGIgMCBidWYg KFBhcnRpYWwuaGVhZGVyX3NpemUgKCkgLSBpKSBzejsKIAkJY29uLnBhcnRp YWxfaW4gPC0gaWYgc3ogPSBpIHRoZW4KLQkJCUhhdmVIZHIgKFBhcnRpYWwu b2Zfc3RyaW5nIChCeXRlcy50b19zdHJpbmcgYnVmKSkgZWxzZSBOb0hkciAo aSAtIHN6LCBidWYpCi0JKTsKLQkhbmV3cGFja2V0CisJCQlIYXZlSGRyIChQ YXJ0aWFsLm9mX3N0cmluZyAoQnl0ZXMudG9fc3RyaW5nIGJ1ZikpIGVsc2Ug Tm9IZHIgKGkgLSBzeiwgYnVmKTsKKwkJTm9uZQorCSkKIAogbGV0IG5ld2Nv biBiYWNrZW5kID0gewogCWJhY2tlbmQgPSBiYWNrZW5kOwotCXBrdF9pbiA9 IFF1ZXVlLmNyZWF0ZSAoKTsKIAlwa3Rfb3V0ID0gUXVldWUuY3JlYXRlICgp OwogCXBhcnRpYWxfaW4gPSBpbml0X3BhcnRpYWxfaW4gKCk7CiAJcGFydGlh bF9vdXQgPSAiIjsKQEAgLTE5Myw5ICsxODgsNiBAQCBsZXQgaGFzX291dHB1 dCBjb24gPSBoYXNfbmV3X291dHB1dCBjb24gfHwgaGFzX29sZF9vdXRwdXQg Y29uCiAKIGxldCBwZWVrX291dHB1dCBjb24gPSBRdWV1ZS5wZWVrIGNvbi5w a3Rfb3V0CiAKLWxldCBpbnB1dF9sZW4gY29uID0gUXVldWUubGVuZ3RoIGNv bi5wa3RfaW4KLWxldCBoYXNfaW5fcGFja2V0IGNvbiA9IFF1ZXVlLmxlbmd0 aCBjb24ucGt0X2luID4gMAotbGV0IGdldF9pbl9wYWNrZXQgY29uID0gUXVl dWUucG9wIGNvbi5wa3RfaW4KIGxldCBoYXNfcGFydGlhbF9pbnB1dCBjb24g PSBtYXRjaCBjb24ucGFydGlhbF9pbiB3aXRoCiAJfCBIYXZlSGRyIF8gLT4g dHJ1ZQogCXwgTm9IZHIgKG4sIF8pIC0+IG4gPCBQYXJ0aWFsLmhlYWRlcl9z aXplICgpCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aSBiL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWxpCmluZGV4IDc5NGUzNWJi MzQzZS4uOTFjNjgyMTYyY2VhIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9s aWJzL3hiL3hiLm1saQorKysgYi90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aQpAQCAtNzcsNyArNzcsNyBAQCB2YWwgd3JpdGVfZmQgOiBiYWNrZW5kX2Zk IC0+ICdhIC0+IHN0cmluZyAtPiBpbnQgLT4gaW50CiB2YWwgd3JpdGVfbW1h cCA6IGJhY2tlbmRfbW1hcCAtPiAnYSAtPiBzdHJpbmcgLT4gaW50IC0+IGlu dAogdmFsIHdyaXRlIDogdCAtPiBzdHJpbmcgLT4gaW50IC0+IGludAogdmFs IG91dHB1dCA6IHQgLT4gYm9vbAotdmFsIGlucHV0IDogdCAtPiBib29sCit2 YWwgaW5wdXQgOiB0IC0+IFBhY2tldC50IG9wdGlvbgogdmFsIG5ld2NvbiA6 IGJhY2tlbmQgLT4gdAogdmFsIG9wZW5fZmQgOiBVbml4LmZpbGVfZGVzY3Ig LT4gdAogdmFsIG9wZW5fbW1hcCA6IFhlbm1tYXAubW1hcF9pbnRlcmZhY2Ug LT4gKHVuaXQgLT4gdW5pdCkgLT4gdApAQCAtODksMTAgKzg5LDcgQEAgdmFs IGhhc19uZXdfb3V0cHV0IDogdCAtPiBib29sCiB2YWwgaGFzX29sZF9vdXRw dXQgOiB0IC0+IGJvb2wKIHZhbCBoYXNfb3V0cHV0IDogdCAtPiBib29sCiB2 YWwgcGVla19vdXRwdXQgOiB0IC0+IFBhY2tldC50Ci12YWwgaW5wdXRfbGVu IDogdCAtPiBpbnQKLXZhbCBoYXNfaW5fcGFja2V0IDogdCAtPiBib29sCiB2 YWwgaGFzX3BhcnRpYWxfaW5wdXQgOiB0IC0+IGJvb2wKLXZhbCBnZXRfaW5f cGFja2V0IDogdCAtPiBQYWNrZXQudAogdmFsIGhhc19tb3JlX2lucHV0IDog dCAtPiBib29sCiB2YWwgaXNfc2VsZWN0YWJsZSA6IHQgLT4gYm9vbAogdmFs IGdldF9mZCA6IHQgLT4gVW5peC5maWxlX2Rlc2NyCmRpZmYgLS1naXQgYS90 b29scy9vY2FtbC9saWJzL3hzL3hzcmF3Lm1sIGIvdG9vbHMvb2NhbWwvbGli cy94cy94c3Jhdy5tbAppbmRleCBkOTgyZmIyNGRiYjEuLjQ1MWY4YjM4ZGJj YyAxMDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94cy94c3Jhdy5tbAor KysgYi90b29scy9vY2FtbC9saWJzL3hzL3hzcmF3Lm1sCkBAIC05NCwyNiAr OTQsMTggQEAgbGV0IHBrdF9zZW5kIGNvbiA9CiAJZG9uZQogCiAoKiByZWNl aXZlIG9uZSBwYWNrZXQgLSBjYW4gc2xlZXAgKikKLWxldCBwa3RfcmVjdiBj b24gPQotCWxldCB3b3JrZG9uZSA9IHJlZiBmYWxzZSBpbgotCXdoaWxlIG5v dCAhd29ya2RvbmUKLQlkbwotCQl3b3JrZG9uZSA6PSBYYi5pbnB1dCBjb24u eGIKLQlkb25lOwotCVhiLmdldF9pbl9wYWNrZXQgY29uLnhiCitsZXQgcmVj IHBrdF9yZWN2IGNvbiA9CisJbWF0Y2ggWGIuaW5wdXQgY29uLnhiIHdpdGgK Kwl8IFNvbWUgcGFja2V0IC0+IHBhY2tldAorCXwgTm9uZSAtPiBwa3RfcmVj diBjb24KIAogbGV0IHBrdF9yZWN2X3RpbWVvdXQgY29uIHRpbWVvdXQgPQog CWxldCBmZCA9IFhiLmdldF9mZCBjb24ueGIgaW4KIAlsZXQgciwgXywgXyA9 IFVuaXguc2VsZWN0IFsgZmQgXSBbXSBbXSB0aW1lb3V0IGluCiAJaWYgciA9 IFtdIHRoZW4KIAkJdHJ1ZSwgTm9uZQotCWVsc2UgKAotCQlsZXQgd29ya2Rv bmUgPSBYYi5pbnB1dCBjb24ueGIgaW4KLQkJaWYgd29ya2RvbmUgdGhlbgot CQkJZmFsc2UsIChTb21lIChYYi5nZXRfaW5fcGFja2V0IGNvbi54YikpCi0J CWVsc2UKLQkJCWZhbHNlLCBOb25lCi0JKQorCWVsc2UKKwkJZmFsc2UsIFhi LmlucHV0IGNvbi54YgogCiBsZXQgcXVldWVfd2F0Y2hldmVudCBjb24gZGF0 YSA9CiAJbGV0IGxzID0gc3BsaXRfc3RyaW5nIH5saW1pdDoyICdcMDAwJyBk YXRhIGluCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvY29u bmVjdGlvbi5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9u Lm1sCmluZGV4IDM4YjQ3MzYzYTE3My4uY2MyMGUwNDdkMmI5IDEwMDY0NAot LS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQvY29ubmVjdGlvbi5tbAorKysg Yi90b29scy9vY2FtbC94ZW5zdG9yZWQvY29ubmVjdGlvbi5tbApAQCAtMjc3 LDkgKzI3Nyw3IEBAIGxldCBnZXRfdHJhbnNhY3Rpb24gY29uIHRpZCA9CiAJ SGFzaHRibC5maW5kIGNvbi50cmFuc2FjdGlvbnMgdGlkCiAKIGxldCBkb19p bnB1dCBjb24gPSBYZW5idXMuWGIuaW5wdXQgY29uLnhiCi1sZXQgaGFzX2lu cHV0IGNvbiA9IFhlbmJ1cy5YYi5oYXNfaW5fcGFja2V0IGNvbi54YgogbGV0 IGhhc19wYXJ0aWFsX2lucHV0IGNvbiA9IFhlbmJ1cy5YYi5oYXNfcGFydGlh bF9pbnB1dCBjb24ueGIKLWxldCBwb3BfaW4gY29uID0gWGVuYnVzLlhiLmdl dF9pbl9wYWNrZXQgY29uLnhiCiBsZXQgaGFzX21vcmVfaW5wdXQgY29uID0g WGVuYnVzLlhiLmhhc19tb3JlX2lucHV0IGNvbi54YgogCiBsZXQgaGFzX291 dHB1dCBjb24gPSBYZW5idXMuWGIuaGFzX291dHB1dCBjb24ueGIKQEAgLTMw Nyw3ICszMDUsNyBAQCBsZXQgaXNfYmFkIGNvbiA9IG1hdGNoIGNvbi5kb20g d2l0aCBOb25lIC0+IGZhbHNlIHwgU29tZSBkb20gLT4gRG9tYWluLmlzX2Jh ZF9kbwogICAgUmVzdHJpY3Rpb25zIGJlbG93IGNhbiBiZSByZWxheGVkIG9u Y2UgeGVuc3RvcmVkIGxlYXJucyB0byBkdW1wIG1vcmUKICAgIG9mIGl0cyBs aXZlIHN0YXRlIGluIGEgc2FmZSB3YXkgKikKIGxldCBoYXNfZXh0cmFfY29u bmVjdGlvbl9kYXRhIGNvbiA9Ci0JbGV0IGhhc19pbiA9IGhhc19pbnB1dCBj b24gfHwgaGFzX3BhcnRpYWxfaW5wdXQgY29uIGluCisJbGV0IGhhc19pbiA9 IGhhc19wYXJ0aWFsX2lucHV0IGNvbiBpbgogCWxldCBoYXNfb3V0ID0gaGFz X291dHB1dCBjb24gaW4KIAlsZXQgaGFzX3NvY2tldCA9IGNvbi5kb20gPSBO b25lIGluCiAJbGV0IGhhc19ub25kZWZhdWx0X3Blcm1zID0gbWFrZV9wZXJt IGNvbi5kb20gPD4gY29uLnBlcm0gaW4KZGlmZiAtLWdpdCBhL3Rvb2xzL29j YW1sL3hlbnN0b3JlZC9wcm9jZXNzLm1sIGIvdG9vbHMvb2NhbWwveGVuc3Rv cmVkL3Byb2Nlc3MubWwKaW5kZXggNmEzNDM1YzI2NWQzLi4yZDY3NDU2YTJh YTAgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9wcm9jZXNz Lm1sCisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9wcm9jZXNzLm1sCkBA IC0xOTUsMTAgKzE5NSw5IEBAIGxldCBwYXJzZV9saXZlX3VwZGF0ZSBhcmdz ID0KIAkJCXwgXyB3aGVuIFVuaXguZ2V0dGltZW9mZGF5ICgpIDwgdC5kZWFk bGluZSAtPiBmYWxzZQogCQkJfCBsIC0+CiAJCQkJd2FybiAidGltZW91dCBy ZWFjaGVkOiBoYXZlIHRvIHdhaXQsIG1pZ3JhdGUgb3Igc2h1dGRvd24gJWQg ZG9tYWluczoiIChMaXN0Lmxlbmd0aCBsKTsKLQkJCQlsZXQgbXNncyA9IExp c3QucmV2X21hcCAoZnVuIGNvbiAtPiBQcmludGYuc3ByaW50ZiAiJXM6ICVk IHR4LCBpbjogJWIsIG91dDogJWIsIHBlcm06ICVzIgorCQkJCWxldCBtc2dz ID0gTGlzdC5yZXZfbWFwIChmdW4gY29uIC0+IFByaW50Zi5zcHJpbnRmICIl czogJWQgdHgsIG91dDogJWIsIHBlcm06ICVzIgogCQkJCQkoQ29ubmVjdGlv bi5nZXRfZG9tc3RyIGNvbikKIAkJCQkJKENvbm5lY3Rpb24ubnVtYmVyX29m X3RyYW5zYWN0aW9ucyBjb24pCi0JCQkJCShDb25uZWN0aW9uLmhhc19pbnB1 dCBjb24pCiAJCQkJCShDb25uZWN0aW9uLmhhc19vdXRwdXQgY29uKQogCQkJ CQkoQ29ubmVjdGlvbi5nZXRfcGVybSBjb24gfD4gUGVybXMuQ29ubmVjdGlv bi50b19zdHJpbmcpCiAJCQkJCSkgbCBpbgpAQCAtNzA1LDE2ICs3MDQsMTcg QEAgbGV0IGRvX2lucHV0IHN0b3JlIGNvbnMgZG9tcyBjb24gPQogCQkJaW5m byAiJXMgcmVxdWVzdHMgYSByZWNvbm5lY3QiIChDb25uZWN0aW9uLmdldF9k b21zdHIgY29uKTsKIAkJCUhpc3RvcnkucmVjb25uZWN0IGNvbjsKIAkJCWlu Zm8gIiVzIHJlY29ubmVjdGlvbiBjb21wbGV0ZSIgKENvbm5lY3Rpb24uZ2V0 X2RvbXN0ciBjb24pOwotCQkJZmFsc2UKKwkJCU5vbmUKIAkJfCBGYWlsdXJl IGV4cCAtPgogCQkJZXJyb3IgImNhdWdodCBleGNlcHRpb24gJXMiIGV4cDsK IAkJCWVycm9yICJnb3QgYSBiYWQgY2xpZW50ICVzIiAoc3ByaW50ZiAiJS04 cyIgKENvbm5lY3Rpb24uZ2V0X2RvbXN0ciBjb24pKTsKIAkJCUNvbm5lY3Rp b24ubWFya19hc19iYWQgY29uOwotCQkJZmFsc2UKKwkJCU5vbmUKIAlpbgog Ci0JaWYgbmV3cGFja2V0IHRoZW4gKAotCQlsZXQgcGFja2V0ID0gQ29ubmVj dGlvbi5wb3BfaW4gY29uIGluCisJbWF0Y2ggbmV3cGFja2V0IHdpdGgKKwl8 IE5vbmUgLT4gKCkKKwl8IFNvbWUgcGFja2V0IC0+CiAJCWxldCB0aWQsIHJp ZCwgdHksIGRhdGEgPSBYZW5idXMuWGIuUGFja2V0LnVucGFjayBwYWNrZXQg aW4KIAkJbGV0IHJlcSA9IHtQYWNrZXQudGlkPXRpZDsgUGFja2V0LnJpZD1y aWQ7IFBhY2tldC50eT10eTsgUGFja2V0LmRhdGE9ZGF0YX0gaW4KIApAQCAt NzI0LDggKzcyNCw3IEBAIGxldCBkb19pbnB1dCBzdG9yZSBjb25zIGRvbXMg Y29uID0KIAkJICAgICAgICAgKFhlbmJ1cy5YYi5PcC50b19zdHJpbmcgdHkp IChzYW5pdGl6ZV9kYXRhIGRhdGEpOyAqKQogCQlwcm9jZXNzX3BhY2tldCB+ c3RvcmUgfmNvbnMgfmRvbXMgfmNvbiB+cmVxOwogCQl3cml0ZV9hY2Nlc3Nf bG9nIH50eSB+dGlkIH5jb246KENvbm5lY3Rpb24uZ2V0X2RvbXN0ciBjb24p IH5kYXRhOwotCQlDb25uZWN0aW9uLmluY3Jfb3BzIGNvbjsKLQkpCisJCUNv bm5lY3Rpb24uaW5jcl9vcHMgY29uCiAKIGxldCBkb19vdXRwdXQgX3N0b3Jl IF9jb25zIF9kb21zIGNvbiA9CiAJaWYgQ29ubmVjdGlvbi5oYXNfb3V0cHV0 IGNvbiB0aGVuICgK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-oxenstored-06.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-oxenstored-06.patch" Content-Transfer-Encoding: base64 RnJvbSA2ODI0YmQyOGI1OWVlZjg1ODI1N2RkZTgwNzZkNGY0NzAyNGJkM2Vi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMyArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94YjogQWRkIEJvdW5kZWRRdWV1ZQpNSU1FLVZl cnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9 VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKRW5zdXJl cyB3ZSBjYW5ub3Qgc3RvcmUgbW9yZSB0aGFuIFtjYXBhY2l0eV0gZWxlbWVu dHMgaW4gYSBbUXVldWVdLiAgUmVwbGFjaW5nCmFsbCBRdWV1ZSB3aXRoIHRo aXMgbW9kdWxlIHdpbGwgdGhlbiBlbnN1cmUgYXQgY29tcGlsZSB0aW1lIHRo YXQgYWxsIFF1ZXVlcwphcmUgY29ycmVjdGx5IGJvdW5kIGNoZWNrZWQuCgpF YWNoIGVsZW1lbnQgaW4gdGhlIHF1ZXVlIGhhcyBhIGNsYXNzIHdpdGggaXRz IG93biBsaW1pdHMuICBUaGlzLCBpbiBhCnN1YnNlcXVlbnQgY2hhbmdlLCB3 aWxsIGVuc3VyZSB0aGF0IGNvbW1hbmQgcmVzcG9uc2VzIGNhbiBwcm9jZWVk IGR1cmluZyBhCmZsb29kIG9mIHdhdGNoIGV2ZW50cy4KCk5vIGZ1bmN0aW9u YWwgY2hhbmdlLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRl ZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVk LW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5k aWdAY2l0cml4LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJz L3hiL3hiLm1sIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbAppbmRleCAx NjVmZDRhMWVkZjQuLjQxOTdhMzg4OGE2OCAxMDA2NDQKLS0tIGEvdG9vbHMv b2NhbWwvbGlicy94Yi94Yi5tbAorKysgYi90b29scy9vY2FtbC9saWJzL3hi L3hiLm1sCkBAIC0xNyw2ICsxNyw5OCBAQAogbW9kdWxlIE9wID0gc3RydWN0 IGluY2x1ZGUgT3AgZW5kCiBtb2R1bGUgUGFja2V0ID0gc3RydWN0IGluY2x1 ZGUgUGFja2V0IGVuZAogCittb2R1bGUgQm91bmRlZFF1ZXVlIDogc2lnCisJ dHlwZSAoJ2EsICdiKSB0CisKKwkoKiogW2NyZWF0ZSB+Y2FwYWNpdHkgfmNs YXNzaWZ5IH5saW1pdF0gY3JlYXRlcyBhIHF1ZXVlIHdpdGggbWF4aW11bSBb Y2FwYWNpdHldIGVsZW1lbnRzLgorCSAgICBUaGlzIGlzIGJ1cnN0IGNhcGFj aXR5LCBlYWNoIGVsZW1lbnQgaXMgZnVydGhlciBjbGFzc2lmaWVkIGFjY29y ZGluZyB0byBbY2xhc3NpZnldLAorCSAgICBhbmQgZWFjaCBjbGFzcyBjYW4g aGF2ZSBpdHMgb3duIFtsaW1pdF0uCisJICAgIFtjYXBhY2l0eV0gaXMgZW5m b3JjZWQgYXMgYW4gb3ZlcmFsbCBsaW1pdC4KKwkgICAgVGhlIFtsaW1pdF0g Y2FuIGJlIGR5bmFtaWMsIGFuZCBjYW4gYmUgc21hbGxlciB0aGFuIHRoZSBu dW1iZXIgb2YgZWxlbWVudHMgYWxyZWFkeSBxdWV1ZWQgb2YgdGhhdCBjbGFz cywKKwkgICAgaW4gd2hpY2ggY2FzZSB0aG9zZSBlbGVtZW50cyBhcmUgY29u c2lkZXJlZCB0byB1c2UgImJ1cnN0IGNhcGFjaXR5Ii4KKwkgICopCisJdmFs IGNyZWF0ZTogY2FwYWNpdHk6aW50IC0+IGNsYXNzaWZ5OignYSAtPiAnYikg LT4gbGltaXQ6KCdiIC0+IGludCkgLT4gKCdhLCAnYikgdAorCisJKCoqIFtj bGVhciBxXSBkaXNjYXJkcyBhbGwgZWxlbWVudHMgZnJvbSBbcV0gKikKKwl2 YWwgY2xlYXI6ICgnYSwgJ2IpIHQgLT4gdW5pdAorCisJKCoqIFtjYW5fcHVz aCBxXSB3aGVuIFtsZW5ndGggcSA8IGNhcGFjaXR5XS4JKikKKwl2YWwgY2Fu X3B1c2g6ICgnYSwgJ2IpIHQgLT4gJ2IgLT4gYm9vbAorCisJKCoqIFtwdXNo IGUgcV0gYWRkcyBbZV0gYXQgdGhlIGVuZCBvZiBxdWV1ZSBbcV0gaWYgW2Nh bl9wdXNoIHFdLCBvciByZXR1cm5zIFtOb25lXS4gKikKKwl2YWwgcHVzaDog J2EgLT4gKCdhLCAnYikgdCAtPiB1bml0IG9wdGlvbgorCisJKCoqIFtwb3Ag cV0gcmVtb3ZlcyBhbmQgcmV0dXJucyBmaXJzdCBlbGVtZW50IGluIFtxXSwg b3IgcmFpc2VzIFtRdWV1ZS5FbXB0eV0uICopCisJdmFsIHBvcDogKCdhLCAn YikgdCAtPiAnYQorCisJKCoqIFtwZWVrIHFdIHJldHVybnMgdGhlIGZpcnN0 IGVsZW1lbnQgaW4gW3FdLCBvciByYWlzZXMgW1F1ZXVlLkVtcHR5XS4gICop CisJdmFsIHBlZWsgOiAoJ2EsICdiKSB0IC0+ICdhCisKKwkoKiogW2xlbmd0 aCBxXSByZXR1cm5zIHRoZSBjdXJyZW50IG51bWJlciBvZiBlbGVtZW50cyBp biBbcV0gKikKKwl2YWwgbGVuZ3RoOiAoJ2EsICdiKSB0IC0+IGludAorCisJ KCoqIFtkZWJ1ZyBzdHJpbmdfb2ZfY2xhc3MgcV0gcHJpbnRzIHF1ZXVlIHVz YWdlIHN0YXRpc3RpY3MgaW4gYW4gdW5zcGVjaWZpZWQgaW50ZXJuYWwgZm9y bWF0LiAqKQorCXZhbCBkZWJ1ZzogKCdiIC0+IHN0cmluZykgLT4gKF8sICdi KSB0IC0+IHN0cmluZworZW5kID0gc3RydWN0CisJdHlwZSAoJ2EsICdiKSB0 ID0KKwkJeyBxOiAnYSBRdWV1ZS50CisJCTsgY2FwYWNpdHk6IGludAorCQk7 IGNsYXNzaWZ5OiAnYSAtPiAnYgorCQk7IGxpbWl0OiAnYiAtPiBpbnQKKwkJ OyBjbGFzc19jb3VudDogKCdiLCBpbnQpIEhhc2h0YmwudAorCQl9CisKKwls ZXQgY3JlYXRlIH5jYXBhY2l0eSB+Y2xhc3NpZnkgfmxpbWl0ID0KKwkJeyBj YXBhY2l0eTsgcSA9IFF1ZXVlLmNyZWF0ZSAoKTsgY2xhc3NpZnk7IGxpbWl0 OyBjbGFzc19jb3VudCA9IEhhc2h0YmwuY3JlYXRlIDMgfQorCisJbGV0IGdl dF9jb3VudCB0IGNsYXNzaWZpY2F0aW9uID0gdHJ5IEhhc2h0YmwuZmluZCB0 LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0aW9uIHdpdGggTm90X2ZvdW5kIC0+ IDAKKworCWxldCBjYW5fcHVzaF9pbnRlcm5hbCB0IGNsYXNzaWZpY2F0aW9u IGNsYXNzX2NvdW50ID0KKwkJUXVldWUubGVuZ3RoIHQucSA8IHQuY2FwYWNp dHkgJiYgY2xhc3NfY291bnQgPCB0LmxpbWl0IGNsYXNzaWZpY2F0aW9uCisK KwlsZXQgb2sgPSBTb21lICgpCisKKwlsZXQgcHVzaCBlIHQgPQorCQlsZXQg Y2xhc3NpZmljYXRpb24gPSB0LmNsYXNzaWZ5IGUgaW4KKwkJbGV0IGNsYXNz X2NvdW50ID0gZ2V0X2NvdW50IHQgY2xhc3NpZmljYXRpb24gaW4KKwkJaWYg Y2FuX3B1c2hfaW50ZXJuYWwgdCBjbGFzc2lmaWNhdGlvbiBjbGFzc19jb3Vu dCB0aGVuIGJlZ2luCisJCQlRdWV1ZS5wdXNoIGUgdC5xOworCQkJSGFzaHRi bC5yZXBsYWNlIHQuY2xhc3NfY291bnQgY2xhc3NpZmljYXRpb24gKGNsYXNz X2NvdW50ICsgMSk7CisJCQlvaworCQllbmQKKwkJZWxzZQorCQkJTm9uZQor CisJbGV0IGNhbl9wdXNoIHQgY2xhc3NpZmljYXRpb24gPQorCQljYW5fcHVz aF9pbnRlcm5hbCB0IGNsYXNzaWZpY2F0aW9uIEBAIGdldF9jb3VudCB0IGNs YXNzaWZpY2F0aW9uCisKKwlsZXQgY2xlYXIgdCA9CisJCVF1ZXVlLmNsZWFy IHQucTsKKwkJSGFzaHRibC5yZXNldCB0LmNsYXNzX2NvdW50CisKKwlsZXQg cG9wIHQgPQorCQlsZXQgZSA9IFF1ZXVlLnBvcCB0LnEgaW4KKwkJbGV0IGNs YXNzaWZpY2F0aW9uID0gdC5jbGFzc2lmeSBlIGluCisJCWxldCAoKSA9IG1h dGNoIGdldF9jb3VudCB0IGNsYXNzaWZpY2F0aW9uIC0gMSB3aXRoCisJCXwg MCAtPiBIYXNodGJsLnJlbW92ZSB0LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0 aW9uICgqIHJlZHVjZXMgbWVtdXNhZ2UgKikKKwkJfCBuIC0+IEhhc2h0Ymwu cmVwbGFjZSB0LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0aW9uIG4KKwkJaW4K KwkJZQorCisJbGV0IHBlZWsgdCA9IFF1ZXVlLnBlZWsgdC5xCisJbGV0IGxl bmd0aCB0ID0gUXVldWUubGVuZ3RoIHQucQorCisJbGV0IGRlYnVnIHN0cmlu Z19vZl9jbGFzcyB0ID0KKwkJbGV0IGIgPSBCdWZmZXIuY3JlYXRlIDEyOCBp bgorCQlQcmludGYuYnByaW50ZiBiICJCb3VuZGVkUXVldWUgY2FwYWNpdHk6 ICVkLCB1c2VkOiB7IiB0LmNhcGFjaXR5OworCQlIYXNodGJsLml0ZXIgKGZ1 biBwYWNrZXRfY2xhc3MgY291bnQgLT4KKwkJCVByaW50Zi5icHJpbnRmIGIg IgklczogJWQiIChzdHJpbmdfb2ZfY2xhc3MgcGFja2V0X2NsYXNzKSBjb3Vu dAorCQkpIHQuY2xhc3NfY291bnQ7CisJCVByaW50Zi5icHJpbnRmIGIgIn0i OworCQlCdWZmZXIuY29udGVudHMgYgorZW5kCisKKwogZXhjZXB0aW9uIEVu ZF9vZl9maWxlCiBleGNlcHRpb24gRWFnYWluCiBleGNlcHRpb24gTm9lbnQK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-oxenstored-07.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-oxenstored-07.patch" Content-Transfer-Encoding: base64 RnJvbSAwZTBkODUzODVmNzczOTQ5MDA1ZWEyZWZhMTg5NTZkZTIzMDgxMzY0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNCArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogTGltaXQgbWF4aW11bSBpbi1mbGlnaHQgcmVx dWVzdHMgLyBvdXRzdGFuZGluZyByZXBsaWVzCk1JTUUtVmVyc2lvbjogMS4w CkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250 ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgpJbnRyb2R1Y2UgYSBsaW1p dCBvbiB0aGUgbnVtYmVyIG9mIG91dHN0YW5kaW5nIHJlcGx5IHBhY2tldHMg aW4gdGhlIHhlbmJ1cwpxdWV1ZS4gIFRoaXMgbGltaXRzIHRoZSBudW1iZXIg b2YgaW4tZmxpZ2h0IHJlcXVlc3RzOiB3aGVuIHRoZSBvdXRwdXQgcXVldWUg aXMKZnVsbCB3ZSdsbCBzdG9wIHByb2Nlc3NpbmcgaW5wdXRzIHVudGlsIHRo ZSBvdXRwdXQgcXVldWUgaGFzIHJvb20gYWdhaW4uCgpUbyBhdm9pZCBhIGJ1 c3kgbG9vcCBvbiB0aGUgVW5peCBzb2NrZXQgd2Ugb25seSBhZGQgaXQgdG8g dGhlIHdhdGNoZWQgaW5wdXQKZmlsZSBkZXNjcmlwdG9yIHNldCBpZiB3ZSdk IGJlIGFibGUgdG8gY2FsbCBgaW5wdXRgIG9uIGl0LiAgRXZlbiB0aG91Z2gg RG9tMAppcyB0cnVzdGVkIGFuZCBleGVtcHQgZnJvbSBxdW90YXMgYSBmbG9v ZCBvZiBldmVudHMgbWlnaHQgY2F1c2UgYSBiYWNrbG9nCndoZXJlIGV2ZW50 cyBhcmUgcHJvZHVjZWQgZmFzdGVyIHRoYW4gZGFlbW9ucyBpbiBEb20wIGNh biBjb25zdW1lIHRoZW0sIHdoaWNoCmNvdWxkIGxlYWQgdG8gYW4gdW5ib3Vu ZGVkIHF1ZXVlIHNpemUgYW5kIE9PTS4KClRoZXJlZm9yZSB0aGUgeGVuYnVz IHF1ZXVlIGxpbWl0IG11c3QgYXBwbHkgdG8gYWxsIGNvbm5lY3Rpb25zLCBE b20wIGlzIG5vdApleGVtcHQgZnJvbSBpdCwgYWx0aG91Z2ggaWYgZXZlcnl0 aGluZyB3b3JrcyBjb3JyZWN0bHkgaXQgd2lsbCBldmVudHVhbGx5CmNhdGNo IHVwLgoKVGhpcyBwcmV2ZW50cyBhIG1hbGljaW91cyBndWVzdCBmcm9tIHNl bmRpbmcgbW9yZSBjb21tYW5kcyB3aGlsZSBpdCBoYXMKb3V0c3RhbmRpbmcg d2F0Y2ggZXZlbnRzIG9yIGNvbW1hbmQgcmVwbGllcyBpbiBpdHMgaW5wdXQg cmluZy4gIEhvd2V2ZXIgaWYgaXQKY2FuIGNhdXNlIHRoZSBnZW5lcmF0aW9u IG9mIHdhdGNoIGV2ZW50cyBieSBvdGhlciBtZWFucyAoZS5nLiBieSBEb20w LCBvcgphbm90aGVyIGNvb3BlcmF0aXZlIGd1ZXN0KSBhbmQgc3RvcCByZWFk aW5nIGl0cyBvd24gcmluZyB0aGVuIHdhdGNoIGV2ZW50cwp3b3VsZCd2ZSBx dWV1ZWQgdXAgd2l0aG91dCBsaW1pdC4KClRoZSB4ZW5zdG9yZSBwcm90b2Nv bCBkb2Vzbid0IGhhdmUgYSBiYWNrLXByZXNzdXJlIG1lY2hhbmlzbSwgYW5k IGRvZXNuJ3QKYWxsb3cgZHJvcHBpbmcgd2F0Y2ggZXZlbnRzLiAgSW4gZmFj dCwgZHJvcHBpbmcgd2F0Y2ggZXZlbnRzIGlzIGtub3duIHRvIGJyZWFrCnNv bWUgcGllY2VzIG9mIG5vcm1hbCBmdW5jdGlvbmFsaXR5LiAgVGhpcyBsZWF2 ZXMgbGl0dGxlIGNob2ljZSB0byBzYWZlbHkKaW1wbGVtZW50IHRoZSB4ZW5z dG9yZSBwcm90b2NvbCB3aXRob3V0IGV4cG9zaW5nIHRoZSB4ZW5zdG9yZSBk YWVtb24gdG8Kb3V0LW9mLW1lbW9yeSBhdHRhY2tzLgoKSW1wbGVtZW50IHRo ZSBmaXggYXMgcGlwZXMgd2l0aCBib3VuZGVkIGJ1ZmZlcnM6CiogVXNlIGEg Ym91bmRlZCBidWZmZXIgZm9yIHdhdGNoIGV2ZW50cwoqIFRoZSB3YXRjaCBz dHJ1Y3R1cmUgd2lsbCBoYXZlIGEgYm91bmRlZCByZWNlaXZpbmcgcGlwZSBv ZiB3YXRjaCBldmVudHMKKiBUaGUgc291cmNlIHdpbGwgaGF2ZSBhbiAib3Zl cmZsb3ciIHBpcGUgb2YgcGVuZGluZyB3YXRjaCBldmVudHMgaXQgY291bGRu J3QKICBkZWxpdmVyCgpJdGVtcyBhcmUgcXVldWVkIHVwIG9uIG9uZSBlbmQg YW5kIGFyZSBzZW50IGFzIGZhciBhbG9uZyB0aGUgcGlwZSBhcyBwb3NzaWJs ZToKCiAgc291cmNlIGRvbWFpbiAtPiB3YXRjaCAtPiB4ZW5idXMgb2YgdGFy Z2V0IC0+IHhlbnN0b3JlIHJpbmcvc29ja2V0IG9mIHRhcmdldAoKSWYgdGhl IHBpcGUgaXMgImZ1bGwiIGF0IGFueSBwb2ludCB0aGVuIGJhY2stcHJlc3N1 cmUgaXMgYXBwbGllZCBhbmQgd2UgcHJldmVudAptb3JlIGl0ZW1zIGZyb20g YmVpbmcgcXVldWVkIHVwLiAgRm9yIHRoZSBzb3VyY2UgZG9tYWluIHRoaXMg bWVhbnMgdGhhdCB3ZSdsbApzdG9wIGFjY2VwdGluZyBuZXcgY29tbWFuZHMg YXMgbG9uZyBhcyBpdHMgcGlwZSBidWZmZXIgaXMgbm90IGVtcHR5LgoKQmVm b3JlIHdlIHRyeSB0byBlbnF1ZXVlIGFuIGl0ZW0gd2UgZmlyc3QgY2hlY2sg d2hldGhlciBpdCBpcyBwb3NzaWJsZSB0byBzZW5kCml0IGZ1cnRoZXIgZG93 biB0aGUgcGlwZSwgYnkgYXR0ZW1wdGluZyB0byByZWN1cnNpdmVseSBmbHVz aCB0aGUgcGlwZXMuIFRoaXMKZW5zdXJlcyB0aGF0IHdlIHJldGFpbiB0aGUg b3JkZXIgb2YgZXZlbnRzIGFzIG11Y2ggYXMgcG9zc2libGUuCgpXZSBtaWdo dCBicmVhayBjYXVzYWxpdHkgb2Ygd2F0Y2ggZXZlbnRzIGlmIHRoZSB0YXJn ZXQgZG9tYWluJ3MgcXVldWUgaXMgZnVsbAphbmQgd2UgbmVlZCB0byBzdGFy dCB1c2luZyB0aGUgd2F0Y2gncyBxdWV1ZS4gIFRoaXMgaXMgYSBicmVha2lu ZyBjaGFuZ2UgaW4KdGhlIHhlbnN0b3JlIHByb3RvY29sLCBidXQgb25seSBm b3IgZG9tYWlucyB3aGljaCBhcmUgbm90IHByb2Nlc3NpbmcgdGhlaXIKaW5j b21pbmcgcmluZyBhcyBleHBlY3RlZC4KCldoZW4gYSB3YXRjaCBpcyBkZWxl dGVkIGl0cyBlbnRpcmUgcGVuZGluZyBxdWV1ZSBpcyBkcm9wcGVkIChubyBj b2RlIGlzIG5lZWRlZApmb3IgdGhhdCwgYmVjYXVzZSBpdCBpcyBwYXJ0IG9m IHRoZSAnd2F0Y2gnIHR5cGUpLgoKVGhlcmUgaXMgYSBjYWNoZSBvZiB3YXRj aGVzIHRoYXQgaGF2ZSBwZW5kaW5nIGV2ZW50cyB0aGF0IHdlIGF0dGVtcHQg dG8gZmx1c2gKYXQgZXZlcnkgY3ljbGUgaWYgcG9zc2libGUuCgpJbnRyb2R1 Y2UgMyBsaW1pdHMgaGVyZToKKiBxdW90YS1tYXh3YXRjaGV2ZW50cyBvbiB3 YXRjaCBldmVudCBkZXN0aW5hdGlvbjogd2hlbiB0aGlzIGlzIGhpdCB0aGUK ICBzb3VyY2Ugd2lsbCBub3QgYmUgYWxsb3dlZCB0byBxdWV1ZSB1cCBtb3Jl IHdhdGNoIGV2ZW50cy4KKiBxdW90YS1tYXhvdXN0YW5kaW5nIHdoaWNoIGlz IHRoZSBudW1iZXIgb2YgcmVzcG9uc2VzIG5vdCByZWFkIGZyb20gdGhlIHJp bmc6CiAgb25jZSBleGNlZWRlZCwgbm8gbW9yZSBpbnB1dHMgYXJlIHByb2Nl c3NlZCB1bnRpbCBhbGwgb3V0c3RhbmRpbmcgcmVwbGllcwogIGFyZSBjb25z dW1lZCBieSB0aGUgY2xpZW50LgoqIG92ZXJmbG93IHF1ZXVlIG9uIHRoZSB3 YXRjaCBldmVudCBzb3VyY2U6IGFsbCB3YXRjaGVzIHRoYXQgY2Fubm90IGJl IHN0b3JlZAogIG9uIGRlc3RpbmF0aW9uIGFyZSBxdWV1ZWQgdXAgaGVyZSwg YSBzaW5nbGUgY29tbWFuZCBjYW4gdHJpZ2dlciBtdWx0aXBsZQogIHdhdGNo ZXMgKGUuZy4gZHVlIHRvIHJlY3Vyc2lvbikuCgpUaGUgb3ZlcmZsb3cgcXVl dWUgY3VycmVudGx5IGRvZXNuJ3QgaGF2ZSBhbiB1cHBlciBib3VuZCwgaXQg aXMgZGlmZmljdWx0IHRvCmFjY3VyYXRlbHkgY2FsY3VsYXRlIG9uZSBhcyBp dCBkZXBlbmRzIG9uIHdoZXRoZXIgeW91IGFyZSBEb20wIGFuZCBob3cgbWFu eQp3YXRjaGVzIGVhY2ggcGF0aCBoYXMgcmVnaXN0ZXJlZCBhbmQgaG93IG1h bnkgd2F0Y2ggZXZlbnRzIHlvdSBjYW4gdHJpZ2dlcgp3aXRoIGEgc2luZ2xl IGNvbW1hbmQgKGUuZy4gYSBjb21taXQpLiAgSG93ZXZlciB0aGVzZSBldmVu dHMgd2VyZSBhbHJlYWR5CnVzaW5nIG1lbW9yeSwgdGhpcyBqdXN0IG1vdmVz IHRoZW0gZWxzZXdoZXJlLCBhbmQgYXMgbG9uZyBhcyB3ZSBjb3JyZWN0bHkK YmxvY2sgYSBkb21haW4gaXQgc2hvdWxkbid0IHJlc3VsdCBpbiB1bmJvdW5k ZWQgbWVtb3J5IHVzYWdlLgoKTm90ZSB0aGF0IERvbTAgaXMgbm90IGV4Y2x1 ZGVkIGZyb20gdGhlc2UgY2hlY2tzLCBpdCBpcyBpbXBvcnRhbnQgdGhhdCBE b20wIGlzCmVzcGVjaWFsbHkgbm90IGV4Y2x1ZGVkIHdoZW4gaXQgaXMgdGhl IHNvdXJjZSwgc2luY2UgdGhlcmUgYXJlIG1hbnkgd2F5cyBpbgp3aGljaCBh IGd1ZXN0IGNvdWxkIHRyaWdnZXIgRG9tMCB0byBzZW5kIGl0IHdhdGNoIGV2 ZW50cy4KClRoaXMgc2hvdWxkIHByb3RlY3QgYWdhaW5zdCBtYWxpY2lvdXMg ZnJvbnRlbmRzIGFzIGxvbmcgYXMgdGhlIGJhY2tlbmQgZm9sbG93cwp0aGUg UFYgeGVuc3RvcmUgcHJvdG9jb2wgYW5kIG9ubHkgZXhwb3NlcyBwYXRocyBu ZWVkZWQgYnkgdGhlIGZyb250ZW5kLCBhbmQKY2hhbmdlcyB0aG9zZSBwYXRo cyBhdCBtb3N0IG9uY2UgYXMgYSByZWFjdGlvbiB0byBndWVzdCBldmVudHMs IG9yIHByb3RvY29sCnN0YXRlLgoKVGhlIHF1ZXVlIGxpbWl0cyBhcmUgcGVy IHdhdGNoLCBhbmQgcGVyIGRvbWFpbi1wYWlyLCBzbyBldmVuIGlmIG9uZQpj b21tdW5pY2F0aW9uIGNoYW5uZWwgd291bGQgYmUgImJsb2NrZWQiLCBvdGhl cnMgd291bGQga2VlcCB3b3JraW5nLCBhbmQgdGhlCmRvbWFpbiBpdHNlbGYg d29uJ3QgZ2V0IGJsb2NrZWQgYXMgbG9uZyBhcyBpdCBkb2Vzbid0IG92ZXJm bG93IHRoZSBxdWV1ZSBvZgp3YXRjaCBldmVudHMuCgpTaW1pbGFybHkgYSBt YWxpY2lvdXMgYmFja2VuZCBjb3VsZCBjYXVzZSB0aGUgZnJvbnRlbmQgdG8g Z2V0IGJsb2NrZWQsIGJ1dAp0aGlzIHdhdGNoIHF1ZXVlIHByb3RlY3RzIHRo ZSBmcm9udGVuZCBhcyB3ZWxsIGFzIGxvbmcgYXMgaXQgZm9sbG93cyB0aGUg UFYKcHJvdG9jb2wuICAoQWx0aG91Z2ggbm90ZSB0aGF0IHByb3RlY3Rpb24g YWdhaW5zdCBtYWxpY2lvdXMgYmFja2VuZHMgaXMgb25seSBhCmJlc3QgZWZm b3J0IGF0IHRoZSBtb21lbnQpCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNiAv IENWRS0yMDIyLTQyMzE4LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLD tmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJpc3Rp YW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbCBiL3Rvb2xzL29j YW1sL2xpYnMveGIveGIubWwKaW5kZXggNDE5N2EzODg4YTY4Li5iMjkyZWQ3 YTg3NGQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWwK KysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbApAQCAtMTM0LDE0ICsx MzQsNDQgQEAgdHlwZSBiYWNrZW5kID0gRmQgb2YgYmFja2VuZF9mZCB8IFhl bm1tYXAgb2YgYmFja2VuZF9tbWFwCiAKIHR5cGUgcGFydGlhbF9idWYgPSBI YXZlSGRyIG9mIFBhcnRpYWwucGt0IHwgTm9IZHIgb2YgaW50ICogYnl0ZXMK IAorKCoKKwlzZXBhcmF0ZSBjYXBhY2l0eSByZXNlcnZhdGlvbiBmb3IgcmVw bGllcyBhbmQgd2F0Y2ggZXZlbnRzOgorCXRoaXMgYWxsb3dzIGEgZG9tYWlu IHRvIGtlZXAgd29ya2luZyBldmVuIHdoZW4gdW5kZXIgYSBjb25zdGFudCBm bG9vZCBvZgorCXdhdGNoIGV2ZW50cworKikKK3R5cGUgY2FwYWNpdHkgPSB7 IG1heG91dHN0YW5kaW5nOiBpbnQ7IG1heHdhdGNoZXZlbnRzOiBpbnQgfQor Cittb2R1bGUgUXVldWUgPSBCb3VuZGVkUXVldWUKKwordHlwZSBwYWNrZXRf Y2xhc3MgPQorCXwgQ29tbWFuZFJlcGx5CisJfCBXYXRjaGV2ZW50CisKK2xl dCBzdHJpbmdfb2ZfcGFja2V0X2NsYXNzID0gZnVuY3Rpb24KKwl8IENvbW1h bmRSZXBseSAtPiAiY29tbWFuZF9yZXBseSIKKwl8IFdhdGNoZXZlbnQgLT4g IndhdGNoX2V2ZW50IgorCiB0eXBlIHQgPQogewogCWJhY2tlbmQ6IGJhY2tl bmQ7Ci0JcGt0X291dDogUGFja2V0LnQgUXVldWUudDsKKwlwa3Rfb3V0OiAo UGFja2V0LnQsIHBhY2tldF9jbGFzcykgUXVldWUudDsKIAltdXRhYmxlIHBh cnRpYWxfaW46IHBhcnRpYWxfYnVmOwogCW11dGFibGUgcGFydGlhbF9vdXQ6 IHN0cmluZzsKKwljYXBhY2l0eTogY2FwYWNpdHkKIH0KIAorbGV0IHRvX3Jl YWQgY29uID0KKwltYXRjaCBjb24ucGFydGlhbF9pbiB3aXRoCisJCXwgSGF2 ZUhkciBwYXJ0aWFsX3BrdCAtPiBQYXJ0aWFsLnRvX2NvbXBsZXRlIHBhcnRp YWxfcGt0CisJCXwgTm9IZHIgICAoaSwgXykgICAgLT4gaQorCitsZXQgZGVi dWcgdCA9CisJUHJpbnRmLnNwcmludGYgIlhlbkJ1cyBzdGF0ZTogcGFydGlh bF9pbjogJWQgbmVlZGVkLCBwYXJ0aWFsX291dDogJWQgYnl0ZXMsIHBrdF9v dXQ6ICVkIHBhY2tldHMsICVzIgorCQkodG9fcmVhZCB0KQorCQkoU3RyaW5n Lmxlbmd0aCB0LnBhcnRpYWxfb3V0KQorCQkoUXVldWUubGVuZ3RoIHQucGt0 X291dCkKKwkJKEJvdW5kZWRRdWV1ZS5kZWJ1ZyBzdHJpbmdfb2ZfcGFja2V0 X2NsYXNzIHQucGt0X291dCkKKwogbGV0IGluaXRfcGFydGlhbF9pbiAoKSA9 IE5vSGRyCiAJKFBhcnRpYWwuaGVhZGVyX3NpemUgKCksIEJ5dGVzLm1ha2Ug KFBhcnRpYWwuaGVhZGVyX3NpemUoKSkgJ1wwMDAnKQogCkBAIC0xOTksNyAr MjI5LDggQEAgbGV0IG91dHB1dCBjb24gPQogCWxldCBzID0gaWYgU3RyaW5n Lmxlbmd0aCBjb24ucGFydGlhbF9vdXQgPiAwIHRoZW4KIAkJCWNvbi5wYXJ0 aWFsX291dAogCQllbHNlIGlmIFF1ZXVlLmxlbmd0aCBjb24ucGt0X291dCA+ IDAgdGhlbgotCQkJUGFja2V0LnRvX3N0cmluZyAoUXVldWUucG9wIGNvbi5w a3Rfb3V0KQorCQkJbGV0IHBrdCA9IFF1ZXVlLnBvcCBjb24ucGt0X291dCBp bgorCQkJUGFja2V0LnRvX3N0cmluZyBwa3QKIAkJZWxzZQogCQkJIiIgaW4K IAkoKiBzZW5kIGRhdGEgZnJvbSBzLCBhbmQgc2F2ZSB0aGUgdW5zZW50IGRh dGEgdG8gcGFydGlhbF9vdXQgKikKQEAgLTIxMiwxMiArMjQzLDE1IEBAIGxl dCBvdXRwdXQgY29uID0KIAkoKiBhZnRlciBzZW5kaW5nIG9uZSBwYWNrZXQs IHBhcnRpYWwgaXMgZW1wdHkgKikKIAljb24ucGFydGlhbF9vdXQgPSAiIgog CisoKiB3ZSBjYW4gb25seSBwcm9jZXNzIGFuIGlucHV0IHBhY2tldCBpZiB3 ZSdyZSBndWFyYW50ZWVkIHRvIGhhdmUgcm9vbQorICAgdG8gc3RvcmUgdGhl IHJlc3BvbnNlIHBhY2tldCAqKQorbGV0IGNhbl9pbnB1dCBjb24gPSBRdWV1 ZS5jYW5fcHVzaCBjb24ucGt0X291dCBDb21tYW5kUmVwbHkKKwogKCogTkI6 IGNhbiB0aHJvdyBSZWNvbm5lY3QgKikKIGxldCBpbnB1dCBjb24gPQotCWxl dCB0b19yZWFkID0KLQkJbWF0Y2ggY29uLnBhcnRpYWxfaW4gd2l0aAotCQl8 IEhhdmVIZHIgcGFydGlhbF9wa3QgLT4gUGFydGlhbC50b19jb21wbGV0ZSBw YXJ0aWFsX3BrdAotCQl8IE5vSGRyICAgKGksIF8pICAgIC0+IGkgaW4KKwlp ZiBub3QgKGNhbl9pbnB1dCBjb24pIHRoZW4gTm9uZQorCWVsc2UKKwlsZXQg dG9fcmVhZCA9IHRvX3JlYWQgY29uIGluCiAKIAkoKiB0cnkgdG8gZ2V0IG1v cmUgZGF0YSBmcm9tIGlucHV0IHN0cmVhbSAqKQogCWxldCBiID0gQnl0ZXMu bWFrZSB0b19yZWFkICdcMDAwJyBpbgpAQCAtMjQzLDExICsyNzcsMjIgQEAg bGV0IGlucHV0IGNvbiA9CiAJCU5vbmUKIAkpCiAKLWxldCBuZXdjb24gYmFj a2VuZCA9IHsKK2xldCBjbGFzc2lmeSB0ID0KKwltYXRjaCB0LlBhY2tldC50 eSB3aXRoCisJfCBPcC5XYXRjaGV2ZW50IC0+IFdhdGNoZXZlbnQKKwl8IF8g LT4gQ29tbWFuZFJlcGx5CisKK2xldCBuZXdjb24gfmNhcGFjaXR5IGJhY2tl bmQgPQorCWxldCBsaW1pdCA9IGZ1bmN0aW9uCisJCXwgQ29tbWFuZFJlcGx5 IC0+IGNhcGFjaXR5Lm1heG91dHN0YW5kaW5nCisJCXwgV2F0Y2hldmVudCAt PiBjYXBhY2l0eS5tYXh3YXRjaGV2ZW50cworCWluCisJewogCWJhY2tlbmQg PSBiYWNrZW5kOwotCXBrdF9vdXQgPSBRdWV1ZS5jcmVhdGUgKCk7CisJcGt0 X291dCA9IFF1ZXVlLmNyZWF0ZSB+Y2FwYWNpdHk6KGNhcGFjaXR5Lm1heG91 dHN0YW5kaW5nICsgY2FwYWNpdHkubWF4d2F0Y2hldmVudHMpIH5jbGFzc2lm eSB+bGltaXQ7CiAJcGFydGlhbF9pbiA9IGluaXRfcGFydGlhbF9pbiAoKTsK IAlwYXJ0aWFsX291dCA9ICIiOworCWNhcGFjaXR5ID0gY2FwYWNpdHk7CiAJ fQogCiBsZXQgb3Blbl9mZCBmZCA9IG5ld2NvbiAoRmQgeyBmZCA9IGZkOyB9 KQpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbGkgYi90 b29scy9vY2FtbC9saWJzL3hiL3hiLm1saQppbmRleCA5MWM2ODIxNjJjZWEu LjcxYjI3NTRjYTc4OCAxMDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94 Yi94Yi5tbGkKKysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbGkKQEAg LTY2LDEwICs2NiwxMSBAQCB0eXBlIGJhY2tlbmRfbW1hcCA9IHsKIHR5cGUg YmFja2VuZF9mZCA9IHsgZmQgOiBVbml4LmZpbGVfZGVzY3I7IH0KIHR5cGUg YmFja2VuZCA9IEZkIG9mIGJhY2tlbmRfZmQgfCBYZW5tbWFwIG9mIGJhY2tl bmRfbW1hcAogdHlwZSBwYXJ0aWFsX2J1ZiA9IEhhdmVIZHIgb2YgUGFydGlh bC5wa3QgfCBOb0hkciBvZiBpbnQgKiBieXRlcwordHlwZSBjYXBhY2l0eSA9 IHsgbWF4b3V0c3RhbmRpbmc6IGludDsgbWF4d2F0Y2hldmVudHM6IGludCB9 CiB0eXBlIHQKIHZhbCBpbml0X3BhcnRpYWxfaW4gOiB1bml0IC0+IHBhcnRp YWxfYnVmCiB2YWwgcmVjb25uZWN0IDogdCAtPiB1bml0Ci12YWwgcXVldWUg OiB0IC0+IFBhY2tldC50IC0+IHVuaXQKK3ZhbCBxdWV1ZSA6IHQgLT4gUGFj a2V0LnQgLT4gdW5pdCBvcHRpb24KIHZhbCByZWFkX2ZkIDogYmFja2VuZF9m ZCAtPiAnYSAtPiBieXRlcyAtPiBpbnQgLT4gaW50CiB2YWwgcmVhZF9tbWFw IDogYmFja2VuZF9tbWFwIC0+ICdhIC0+IGJ5dGVzIC0+IGludCAtPiBpbnQK IHZhbCByZWFkIDogdCAtPiBieXRlcyAtPiBpbnQgLT4gaW50CkBAIC03OCwx MyArNzksMTQgQEAgdmFsIHdyaXRlX21tYXAgOiBiYWNrZW5kX21tYXAgLT4g J2EgLT4gc3RyaW5nIC0+IGludCAtPiBpbnQKIHZhbCB3cml0ZSA6IHQgLT4g c3RyaW5nIC0+IGludCAtPiBpbnQKIHZhbCBvdXRwdXQgOiB0IC0+IGJvb2wK IHZhbCBpbnB1dCA6IHQgLT4gUGFja2V0LnQgb3B0aW9uCi12YWwgbmV3Y29u IDogYmFja2VuZCAtPiB0Ci12YWwgb3Blbl9mZCA6IFVuaXguZmlsZV9kZXNj ciAtPiB0Ci12YWwgb3Blbl9tbWFwIDogWGVubW1hcC5tbWFwX2ludGVyZmFj ZSAtPiAodW5pdCAtPiB1bml0KSAtPiB0Cit2YWwgbmV3Y29uIDogY2FwYWNp dHk6Y2FwYWNpdHkgLT4gYmFja2VuZCAtPiB0Cit2YWwgb3Blbl9mZCA6IFVu aXguZmlsZV9kZXNjciAtPiBjYXBhY2l0eTpjYXBhY2l0eSAtPiB0Cit2YWwg b3Blbl9tbWFwIDogWGVubW1hcC5tbWFwX2ludGVyZmFjZSAtPiAodW5pdCAt PiB1bml0KSAtPiBjYXBhY2l0eTpjYXBhY2l0eSAtPiB0CiB2YWwgY2xvc2Ug OiB0IC0+IHVuaXQKIHZhbCBpc19mZCA6IHQgLT4gYm9vbAogdmFsIGlzX21t YXAgOiB0IC0+IGJvb2wKIHZhbCBvdXRwdXRfbGVuIDogdCAtPiBpbnQKK3Zh bCBjYW5faW5wdXQ6IHQgLT4gYm9vbAogdmFsIGhhc19uZXdfb3V0cHV0IDog dCAtPiBib29sCiB2YWwgaGFzX29sZF9vdXRwdXQgOiB0IC0+IGJvb2wKIHZh bCBoYXNfb3V0cHV0IDogdCAtPiBib29sCkBAIC05MywzICs5NSw0IEBAIHZh bCBoYXNfcGFydGlhbF9pbnB1dCA6IHQgLT4gYm9vbAogdmFsIGhhc19tb3Jl X2lucHV0IDogdCAtPiBib29sCiB2YWwgaXNfc2VsZWN0YWJsZSA6IHQgLT4g Ym9vbAogdmFsIGdldF9mZCA6IHQgLT4gVW5peC5maWxlX2Rlc2NyCit2YWwg ZGVidWc6IHQgLT4gc3RyaW5nCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9s aWJzL3hzL3F1ZXVlb3AubWwgYi90b29scy9vY2FtbC9saWJzL3hzL3F1ZXVl b3AubWwKaW5kZXggOWZmNWJiZDUyOWNlLi40ZTUzMmNkYWVhY2IgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveHMvcXVldWVvcC5tbAorKysgYi90 b29scy9vY2FtbC9saWJzL3hzL3F1ZXVlb3AubWwKQEAgLTE2LDkgKzE2LDEw IEBACiBvcGVuIFhlbmJ1cwogCiBsZXQgZGF0YV9jb25jYXQgbHMgPSAoU3Ry aW5nLmNvbmNhdCAiXDAwMCIgbHMpIF4gIlwwMDAiCitsZXQgcXVldWUgY29u IHBrdCA9IGxldCByID0gWGIucXVldWUgY29uIHBrdCBpbiBhc3NlcnQgKHIg PD4gTm9uZSkKIGxldCBxdWV1ZV9wYXRoIHR5ICh0aWQ6IGludCkgKHBhdGg6 IHN0cmluZykgY29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgcGF0 aDsgXSBpbgotCVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSB0aWQg MCB0eSBkYXRhKQorCXF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSB0aWQg MCB0eSBkYXRhKQogCiAoKiBvcGVyYXRpb25zICopCiBsZXQgZGlyZWN0b3J5 IHRpZCBwYXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuRGlyZWN0b3J5IHRp ZCBwYXRoIGNvbgpAQCAtMjcsNDggKzI4LDQ4IEBAIGxldCByZWFkIHRpZCBw YXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuUmVhZCB0aWQgcGF0aCBjb24K IGxldCBnZXRwZXJtcyB0aWQgcGF0aCBjb24gPSBxdWV1ZV9wYXRoIFhiLk9w LkdldHBlcm1zIHRpZCBwYXRoIGNvbgogCiBsZXQgZGVidWcgY29tbWFuZHMg Y29uID0KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhi Lk9wLkRlYnVnIChkYXRhX2NvbmNhdCBjb21tYW5kcykpCisJcXVldWUgY29u IChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5EZWJ1ZyAoZGF0YV9jb25j YXQgY29tbWFuZHMpKQogCiBsZXQgd2F0Y2ggcGF0aCBkYXRhIGNvbiA9CiAJ bGV0IGRhdGEgPSBkYXRhX2NvbmNhdCBbIHBhdGg7IGRhdGE7IF0gaW4KLQlY Yi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhiLk9wLldhdGNo IGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5P cC5XYXRjaCBkYXRhKQogCiBsZXQgdW53YXRjaCBwYXRoIGRhdGEgY29uID0K IAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgcGF0aDsgZGF0YTsgXSBpbgot CVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuVW53 YXRjaCBkYXRhKQorCXF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAg WGIuT3AuVW53YXRjaCBkYXRhKQogCiBsZXQgdHJhbnNhY3Rpb25fc3RhcnQg Y29uID0KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhi Lk9wLlRyYW5zYWN0aW9uX3N0YXJ0IChkYXRhX2NvbmNhdCBbXSkpCisJcXVl dWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5UcmFuc2FjdGlv bl9zdGFydCAoZGF0YV9jb25jYXQgW10pKQogCiBsZXQgdHJhbnNhY3Rpb25f ZW5kIHRpZCBjb21taXQgY29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0 IFsgKGlmIGNvbW1pdCB0aGVuICJUIiBlbHNlICJGIik7IF0gaW4KLQlYYi5x dWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuVHJhbnNh Y3Rpb25fZW5kIGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRl IHRpZCAwIFhiLk9wLlRyYW5zYWN0aW9uX2VuZCBkYXRhKQogCiBsZXQgaW50 cm9kdWNlIGRvbWlkIG1mbiBwb3J0IGNvbiA9CiAJbGV0IGRhdGEgPSBkYXRh X2NvbmNhdCBbIFByaW50Zi5zcHJpbnRmICIldSIgZG9taWQ7CiAJICAgICAg ICAgICAgICAgICAgICAgICAgIFByaW50Zi5zcHJpbnRmICIlbnUiIG1mbjsK IAkgICAgICAgICAgICAgICAgICAgICAgICAgc3RyaW5nX29mX2ludCBwb3J0 OyBdIGluCi0JWGIucXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBY Yi5PcC5JbnRyb2R1Y2UgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBhY2tldC5j cmVhdGUgMCAwIFhiLk9wLkludHJvZHVjZSBkYXRhKQogCiBsZXQgcmVsZWFz ZSBkb21pZCBjb24gPQogCWxldCBkYXRhID0gZGF0YV9jb25jYXQgWyBQcmlu dGYuc3ByaW50ZiAiJXUiIGRvbWlkOyBdIGluCi0JWGIucXVldWUgY29uIChY Yi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5SZWxlYXNlIGRhdGEpCisJcXVl dWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5SZWxlYXNlIGRh dGEpCiAKIGxldCByZXN1bWUgZG9taWQgY29uID0KIAlsZXQgZGF0YSA9IGRh dGFfY29uY2F0IFsgUHJpbnRmLnNwcmludGYgIiV1IiBkb21pZDsgXSBpbgot CVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuUmVz dW1lIGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBY Yi5PcC5SZXN1bWUgZGF0YSkKIAogbGV0IGdldGRvbWFpbnBhdGggZG9taWQg Y29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgUHJpbnRmLnNwcmlu dGYgIiV1IiBkb21pZDsgXSBpbgotCVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0 LmNyZWF0ZSAwIDAgWGIuT3AuR2V0ZG9tYWlucGF0aCBkYXRhKQorCXF1ZXVl IGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuR2V0ZG9tYWlucGF0 aCBkYXRhKQogCiBsZXQgd3JpdGUgdGlkIHBhdGggdmFsdWUgY29uID0KIAls ZXQgZGF0YSA9IHBhdGggXiAiXDAwMCIgXiB2YWx1ZSAoKiBubyBOVUxMIGF0 IHRoZSBlbmQgKikgaW4KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVh dGUgdGlkIDAgWGIuT3AuV3JpdGUgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBh Y2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuV3JpdGUgZGF0YSkKIAogbGV0IG1r ZGlyIHRpZCBwYXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuTWtkaXIgdGlk IHBhdGggY29uCiBsZXQgcm0gdGlkIHBhdGggY29uID0gcXVldWVfcGF0aCBY Yi5PcC5SbSB0aWQgcGF0aCBjb24KIAogbGV0IHNldHBlcm1zIHRpZCBwYXRo IHBlcm1zIGNvbiA9CiAJbGV0IGRhdGEgPSBkYXRhX2NvbmNhdCBbIHBhdGg7 IHBlcm1zIF0gaW4KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUg dGlkIDAgWGIuT3AuU2V0cGVybXMgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBh Y2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuU2V0cGVybXMgZGF0YSkKZGlmZiAt LWdpdCBhL3Rvb2xzL29jYW1sL2xpYnMveHMveHNyYXcubWwgYi90b29scy9v Y2FtbC9saWJzL3hzL3hzcmF3Lm1sCmluZGV4IDQ1MWY4YjM4ZGJjYy4uY2Jk MTcyODA2MDBjIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9saWJzL3hzL3hz cmF3Lm1sCisrKyBiL3Rvb2xzL29jYW1sL2xpYnMveHMveHNyYXcubWwKQEAg LTM2LDggKzM2LDEwIEBAIHR5cGUgY29uID0gewogbGV0IGNsb3NlIGNvbiA9 CiAJWGIuY2xvc2UgY29uLnhiCiAKK2xldCBjYXBhY2l0eSA9IHsgWGIubWF4 b3V0c3RhbmRpbmcgPSAxOyBtYXh3YXRjaGV2ZW50cyA9IDA7IH0KKwogbGV0 IG9wZW5fZmQgZmQgPSB7Ci0JeGIgPSBYYi5vcGVuX2ZkIGZkOworCXhiID0g WGIub3Blbl9mZCB+Y2FwYWNpdHkgZmQ7CiAJd2F0Y2hldmVudHMgPSBRdWV1 ZS5jcmVhdGUgKCk7CiB9CiAKZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hl bnN0b3JlZC9jb25uZWN0aW9uLm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVk L2Nvbm5lY3Rpb24ubWwKaW5kZXggY2MyMGUwNDdkMmI5Li45NjI0YTVmOWRh MmMgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0 aW9uLm1sCisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9u Lm1sCkBAIC0yMCwxMiArMjAsODQgQEAgb3BlbiBTdGRleHQKIAogbGV0IHhl bnN0b3JlX3BheWxvYWRfbWF4ID0gNDA5NiAoKiB4ZW4vaW5jbHVkZS9wdWJs aWMvaW8veHNfd2lyZS5oICopCiAKK3R5cGUgJ2EgYm91bmRlZF9zZW5kZXIg PSAnYSAtPiB1bml0IG9wdGlvbgorKCoqIGEgYm91bmRlZCBzZW5kZXIgYWNj ZXB0cyBhbiBbJ2FdIGl0ZW0gYW5kIHJldHVybnM6CisgICAgTm9uZSAtIGlm IHRoZXJlIGlzIG5vIHJvb20gdG8gYWNjZXB0IHRoZSBpdGVtCisgICAgU29t ZSAoKSAtICBpZiBpdCBoYXMgc3VjY2Vzc2Z1bGx5IGFjY2VwdGVkL3NlbnQg dGhlIGl0ZW0KKyAqKQorCittb2R1bGUgQm91bmRlZFBpcGUgOiBzaWcKKwl0 eXBlICdhIHQKKworCSgqKiBbY3JlYXRlIH5jYXBhY2l0eSB+ZGVzdGluYXRp b25dIGNyZWF0ZXMgYSBib3VuZGVkIHBpcGUgd2l0aCBhCisJICAgIGxvY2Fs IGJ1ZmZlciBob2xkaW5nIGF0IG1vc3QgW2NhcGFjaXR5XSBpdGVtcy4gIE9u Y2UgdGhlIGJ1ZmZlciBpcworCSAgICBmdWxsIGl0IHdpbGwgbm90IGFjY2Vw dCBmdXJ0aGVyIGl0ZW1zLiAgaXRlbXMgZnJvbSB0aGUgcGlwZSBhcmUKKwkg ICAgZmx1c2hlZCBpbnRvIFtkZXN0aW5hdGlvbl0gYXMgbG9uZyBhcyBpdCBh Y2NlcHRzIGl0ZW1zLiAgVGhlCisJICAgIGRlc3RpbmF0aW9uIGNvdWxkIGJl IGFub3RoZXIgcGlwZS4KKwkgKikKKwl2YWwgY3JlYXRlOiBjYXBhY2l0eTpp bnQgLT4gZGVzdGluYXRpb246J2EgYm91bmRlZF9zZW5kZXIgLT4gJ2EgdAor CisJKCoqIFtpc19lbXB0eSB0XSByZXR1cm5zIHdoZXRoZXIgdGhlIGxvY2Fs IGJ1ZmZlciBvZiBbdF0gaXMgZW1wdHkuICopCisJdmFsIGlzX2VtcHR5IDog XyB0IC0+IGJvb2wKKworCSgqKiBbbGVuZ3RoIHRdIHRoZSBudW1iZXIgb2Yg aXRlbXMgaW4gdGhlIGludGVybmFsIGJ1ZmZlciAqKQorCXZhbCBsZW5ndGg6 IF8gdCAtPiBpbnQKKworCSgqKiBbZmx1c2hfcGlwZSB0XSBzZW5kcyBhcyBt YW55IGl0ZW1zIGZyb20gdGhlIGxvY2FsIGJ1ZmZlciBhcyBwb3NzaWJsZSwK KwkJCXdoaWNoIGNvdWxkIGJlIG5vbmUuICopCisJdmFsIGZsdXNoX3BpcGU6 IF8gdCAtPiB1bml0CisKKwkoKiogW3B1c2ggdCBpdGVtXSB0cmllcyB0byBb Zmx1c2hfcGlwZV0gYW5kIHRoZW4gcHVzaCBbaXRlbV0KKwkgICAgaW50byB0 aGUgcGlwZSBpZiBpdHMgW2NhcGFjaXR5XSBhbGxvd3MuCisJICAgIFJldHVy bnMgW05vbmVdIGlmIHRoZXJlIGlzIG5vIG1vcmUgcm9vbQorCSAqKQorCXZh bCBwdXNoIDogJ2EgdCAtPiAnYSBib3VuZGVkX3NlbmRlcgorZW5kID0gc3Ry dWN0CisJKCogaXRlbXMgYXJlIGVucXVldWVkIGluIFtxXSwgYW5kIHRoZW4g Zmx1c2hlZCB0byBbY29ubmVjdF90b10gKikKKwl0eXBlICdhIHQgPQorCQl7 IHE6ICdhIFF1ZXVlLnQKKwkJOyBkZXN0aW5hdGlvbjogJ2EgYm91bmRlZF9z ZW5kZXIKKwkJOyBjYXBhY2l0eTogaW50CisJCX0KKworCWxldCBjcmVhdGUg fmNhcGFjaXR5IH5kZXN0aW5hdGlvbiA9CisJCXsgcSA9IFF1ZXVlLmNyZWF0 ZSAoKTsgY2FwYWNpdHk7IGRlc3RpbmF0aW9uIH0KKworCWxldCByZWMgZmx1 c2hfcGlwZSB0ID0KKwkJaWYgbm90IFF1ZXVlLihpc19lbXB0eSB0LnEpIHRo ZW4KKwkJCWxldCBpdGVtID0gUXVldWUucGVlayB0LnEgaW4KKwkJCW1hdGNo IHQuZGVzdGluYXRpb24gaXRlbSB3aXRoCisJCQl8IE5vbmUgLT4gKCkgKCog bm8gcm9vbSAqKQorCQkJfCBTb21lICgpIC0+CisJCQkJKCogc3VjY2Vzc2Z1 bGx5IHNlbnQgaXRlbSB0byBuZXh0IHN0YWdlICopCisJCQkJbGV0IF8gPSBR dWV1ZS5wb3AgdC5xIGluCisJCQkJKCogY29udGludWUgdHJ5aW5nIHRvIHNl bmQgbW9yZSBpdGVtcyAqKQorCQkJCWZsdXNoX3BpcGUgdAorCisJbGV0IHB1 c2ggdCBpdGVtID0KKwkJKCogZmlyc3QgdHJ5IHRvIGZsdXNoIGFzIG1hbnkg aXRlbXMgZnJvbSB0aGlzIHBpcGUgYXMgcG9zc2libGUgdG8gbWFrZSByb29t LAorCQkgICBpdCBpcyBpbXBvcnRhbnQgdG8gZG8gdGhpcyBmaXJzdCB0byBw cmVzZXJ2ZSB0aGUgb3JkZXIgb2YgdGhlIGl0ZW1zCisJCSAqKQorCQlmbHVz aF9waXBlIHQ7CisJCWlmIFF1ZXVlLmxlbmd0aCB0LnEgPCB0LmNhcGFjaXR5 IHRoZW4gYmVnaW4KKwkJCSgqIGVucXVldWUsIGluc3RlYWQgb2Ygc2VuZGlu ZyBkaXJlY3RseS4KKwkJCSAgIHRoaXMgZW5zdXJlcyB0aGF0IFtvdXRdIHNl ZXMgdGhlIGl0ZW1zIGluIHRoZSBzYW1lIG9yZGVyIGFzIHdlIHJlY2VpdmUg dGhlbQorCQkJICopCisJCQlRdWV1ZS5wdXNoIGl0ZW0gdC5xOworCQkJU29t ZSAoZmx1c2hfcGlwZSB0KQorCQllbmQgZWxzZSBOb25lCisKKwlsZXQgaXNf ZW1wdHkgdCA9IFF1ZXVlLmlzX2VtcHR5IHQucQorCWxldCBsZW5ndGggdCA9 IFF1ZXVlLmxlbmd0aCB0LnEKK2VuZAorCiB0eXBlIHdhdGNoID0gewogCWNv bjogdDsKIAl0b2tlbjogc3RyaW5nOwogCXBhdGg6IHN0cmluZzsKIAliYXNl OiBzdHJpbmc7CiAJaXNfcmVsYXRpdmU6IGJvb2w7CisJcGVuZGluZ193YXRj aGV2ZW50czogWGVuYnVzLlhiLlBhY2tldC50IEJvdW5kZWRQaXBlLnQ7CiB9 CiAKIGFuZCB0ID0gewpAQCAtMzgsOCArMTEwLDM2IEBAIGFuZCB0ID0gewog CWFub25pZDogaW50OwogCW11dGFibGUgc3RhdF9uYl9vcHM6IGludDsKIAlt dXRhYmxlIHBlcm06IFBlcm1zLkNvbm5lY3Rpb24udDsKKwlwZW5kaW5nX3Nv dXJjZV93YXRjaGV2ZW50czogKHdhdGNoICogWGVuYnVzLlhiLlBhY2tldC50 KSBCb3VuZGVkUGlwZS50CiB9CiAKK21vZHVsZSBXYXRjaCA9IHN0cnVjdAor CW1vZHVsZSBUID0gc3RydWN0CisJCXR5cGUgdCA9IHdhdGNoCisKKwkJbGV0 IGNvbXBhcmUgdzEgdzIgPQorCQkJKCogY2Fubm90IGNvbXBhcmUgd2F0Y2hl cyBmcm9tIGRpZmZlcmVudCBjb25uZWN0aW9ucyAqKQorCQkJYXNzZXJ0ICh3 MS5jb24gPT0gdzIuY29uKTsKKwkJCW1hdGNoIFN0cmluZy5jb21wYXJlIHcx LnRva2VuIHcyLnRva2VuIHdpdGgKKwkJCXwgMCAtPiBTdHJpbmcuY29tcGFy ZSB3MS5wYXRoIHcyLnBhdGgKKwkJCXwgbiAtPiBuCisJZW5kCisJbW9kdWxl IFNldCA9IFNldC5NYWtlKFQpCisKKwlsZXQgZmx1c2hfZXZlbnRzIHQgPQor CQlCb3VuZGVkUGlwZS5mbHVzaF9waXBlIHQucGVuZGluZ193YXRjaGV2ZW50 czsKKwkJbm90IChCb3VuZGVkUGlwZS5pc19lbXB0eSB0LnBlbmRpbmdfd2F0 Y2hldmVudHMpCisKKwlsZXQgcGVuZGluZ193YXRjaGV2ZW50cyB0ID0KKwkJ Qm91bmRlZFBpcGUubGVuZ3RoIHQucGVuZGluZ193YXRjaGV2ZW50cworZW5k CisKK2xldCBzb3VyY2VfZmx1c2hfd2F0Y2hldmVudHMgdCA9CisJQm91bmRl ZFBpcGUuZmx1c2hfcGlwZSB0LnBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRz CisKK2xldCBzb3VyY2VfcGVuZGluZ193YXRjaGV2ZW50cyB0ID0KKwlCb3Vu ZGVkUGlwZS5sZW5ndGggdC5wZW5kaW5nX3NvdXJjZV93YXRjaGV2ZW50cwor CiBsZXQgbWFya19hc19iYWQgY29uID0KIAltYXRjaCBjb24uZG9tIHdpdGgK IAl8Tm9uZSAtPiAoKQpAQCAtNjcsNyArMTY3LDggQEAgbGV0IHdhdGNoX2Ny ZWF0ZSB+Y29uIH5wYXRoIH50b2tlbiA9IHsKIAl0b2tlbiA9IHRva2VuOwog CXBhdGggPSBwYXRoOwogCWJhc2UgPSBnZXRfcGF0aCBjb247Ci0JaXNfcmVs YXRpdmUgPSBwYXRoLlswXSA8PiAnLycgJiYgcGF0aC5bMF0gPD4gJ0AnCisJ aXNfcmVsYXRpdmUgPSBwYXRoLlswXSA8PiAnLycgJiYgcGF0aC5bMF0gPD4g J0AnOworCXBlbmRpbmdfd2F0Y2hldmVudHMgPSBCb3VuZGVkUGlwZS5jcmVh dGUgfmNhcGFjaXR5OiFEZWZpbmUubWF4d2F0Y2hldmVudHMgfmRlc3RpbmF0 aW9uOihYZW5idXMuWGIucXVldWUgY29uLnhiKQogfQogCiBsZXQgZ2V0X2Nv biB3ID0gdy5jb24KQEAgLTkzLDYgKzE5NCw5IEBAIGxldCBtYWtlX3Blcm0g ZG9tID0KIAlQZXJtcy5Db25uZWN0aW9uLmNyZWF0ZSB+cGVybXM6W1Blcm1z LlJFQUQ7IFBlcm1zLldSSVRFXSBkb21pZAogCiBsZXQgY3JlYXRlIHhiY29u IGRvbSA9CisJbGV0IGRlc3RpbmF0aW9uICh3YXRjaCwgcGt0KSA9CisJCUJv dW5kZWRQaXBlLnB1c2ggd2F0Y2gucGVuZGluZ193YXRjaGV2ZW50cyBwa3QK KwlpbgogCWxldCBpZCA9CiAJCW1hdGNoIGRvbSB3aXRoCiAJCXwgTm9uZSAt PiBsZXQgb2xkID0gIWFub25faWRfbmV4dCBpbiBpbmNyIGFub25faWRfbmV4 dDsgb2xkCkBAIC0xMDksNiArMjEzLDE2IEBAIGxldCBjcmVhdGUgeGJjb24g ZG9tID0KIAlhbm9uaWQgPSBpZDsKIAlzdGF0X25iX29wcyA9IDA7CiAJcGVy bSA9IG1ha2VfcGVybSBkb207CisKKwkoKiB0aGUgYWN0dWFsIGNhcGFjaXR5 IHdpbGwgYmUgbG93ZXIsIHRoaXMgaXMgdXNlZCBhcyBhbiBvdmVyZmxvdwor CSAgIGJ1ZmZlcjogYW55dGhpbmcgdGhhdCBkb2Vzbid0IGZpdCBlbHNld2hl cmUgZ2V0cyBwdXQgaGVyZSwgb25seQorCSAgIGxpbWl0ZWQgYnkgdGhlIGFt b3VudCBvZiB3YXRjaGVzIHRoYXQgeW91IGNhbiBnZW5lcmF0ZSB3aXRoIGEK KwkgICBzaW5nbGUgeGVuc3RvcmUgY29tbWFuZCAod2hpY2ggaXMgZmluaXRl LCBhbHRob3VnaCBwb3NzaWJseSB2ZXJ5CisJICAgbGFyZ2UgaW4gdGhlb3J5 IGZvciBEb20wKS4gIE9uY2UgdGhlIHBpcGUgaGVyZSBoYXMgYW55IGNvbnRl bnRzIHRoZQorCSAgIGRvbWFpbiBpcyBibG9ja2VkIGZyb20gc2VuZGluZyBt b3JlIGNvbW1hbmRzIHVudGlsIGl0IGlzIGVtcHR5CisJICAgYWdhaW4gdGhv dWdoLgorCSAqKQorCXBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRzID0gQm91 bmRlZFBpcGUuY3JlYXRlIH5jYXBhY2l0eTpTeXMubWF4X2FycmF5X2xlbmd0 aCB+ZGVzdGluYXRpb24KIAl9CiAJaW4KIAlMb2dnaW5nLm5ld19jb25uZWN0 aW9uIH50aWQ6VHJhbnNhY3Rpb24ubm9uZSB+Y29uOihnZXRfZG9tc3RyIGNv bik7CkBAIC0xMjcsMTEgKzI0MSwxNyBAQCBsZXQgc2V0X3RhcmdldCBjb24g dGFyZ2V0X2RvbWlkID0KIAogbGV0IGlzX2JhY2tlbmRfbW1hcCBjb24gPSBY ZW5idXMuWGIuaXNfbW1hcCBjb24ueGIKIAotbGV0IHNlbmRfcmVwbHkgY29u IHRpZCByaWQgdHkgZGF0YSA9CitsZXQgcGFja2V0X29mIGNvbiB0aWQgcmlk IHR5IGRhdGEgPQogCWlmIChTdHJpbmcubGVuZ3RoIGRhdGEpID4geGVuc3Rv cmVfcGF5bG9hZF9tYXggJiYgKGlzX2JhY2tlbmRfbW1hcCBjb24pIHRoZW4K LQkJWGVuYnVzLlhiLnF1ZXVlIGNvbi54YiAoWGVuYnVzLlhiLlBhY2tldC5j cmVhdGUgdGlkIHJpZCBYZW5idXMuWGIuT3AuRXJyb3IgIkUyQklHXDAwMCIp CisJCVhlbmJ1cy5YYi5QYWNrZXQuY3JlYXRlIHRpZCByaWQgWGVuYnVzLlhi Lk9wLkVycm9yICJFMkJJR1wwMDAiCiAJZWxzZQotCQlYZW5idXMuWGIucXVl dWUgY29uLnhiIChYZW5idXMuWGIuUGFja2V0LmNyZWF0ZSB0aWQgcmlkIHR5 IGRhdGEpCisJCVhlbmJ1cy5YYi5QYWNrZXQuY3JlYXRlIHRpZCByaWQgdHkg ZGF0YQorCitsZXQgc2VuZF9yZXBseSBjb24gdGlkIHJpZCB0eSBkYXRhID0K KwlsZXQgcmVzdWx0ID0gWGVuYnVzLlhiLnF1ZXVlIGNvbi54YiAocGFja2V0 X29mIGNvbiB0aWQgcmlkIHR5IGRhdGEpIGluCisJKCogc2hvdWxkIG5ldmVy IGhhcHBlbjogd2Ugb25seSBwcm9jZXNzIGFuIGlucHV0IHBhY2tldCB3aGVu IHRoZXJlIGlzIHJvb20gZm9yIGFuIG91dHB1dCBwYWNrZXQgKikKKwkoKiBh bmQgdGhlIGxpbWl0IGZvciByZXBsaWVzIGlzIGRpZmZlcmVudCBmcm9tIHRo ZSBsaW1pdCBmb3Igd2F0Y2ggZXZlbnRzICopCisJYXNzZXJ0IChyZXN1bHQg PD4gTm9uZSkKIAogbGV0IHNlbmRfZXJyb3IgY29uIHRpZCByaWQgZXJyID0g c2VuZF9yZXBseSBjb24gdGlkIHJpZCBYZW5idXMuWGIuT3AuRXJyb3IgKGVy ciBeICJcMDAwIikKIGxldCBzZW5kX2FjayBjb24gdGlkIHJpZCB0eSA9IHNl bmRfcmVwbHkgY29uIHRpZCByaWQgdHkgIk9LXDAwMCIKQEAgLTE4MSwxMSAr MzAxLDExIEBAIGxldCBkZWxfd2F0Y2ggY29uIHBhdGggdG9rZW4gPQogCWFw YXRoLCB3CiAKIGxldCBkZWxfd2F0Y2hlcyBjb24gPQotICBIYXNodGJsLmNs ZWFyIGNvbi53YXRjaGVzOworICBIYXNodGJsLnJlc2V0IGNvbi53YXRjaGVz OwogICBjb24ubmJfd2F0Y2hlcyA8LSAwCiAKIGxldCBkZWxfdHJhbnNhY3Rp b25zIGNvbiA9Ci0gIEhhc2h0YmwuY2xlYXIgY29uLnRyYW5zYWN0aW9ucwor ICBIYXNodGJsLnJlc2V0IGNvbi50cmFuc2FjdGlvbnMKIAogbGV0IGxpc3Rf d2F0Y2hlcyBjb24gPQogCWxldCBsbCA9IEhhc2h0YmwuZm9sZApAQCAtMjA4 LDIxICszMjgsMjkgQEAgbGV0IGxvb2t1cF93YXRjaF9wZXJtIHBhdGggPSBm dW5jdGlvbgogbGV0IGxvb2t1cF93YXRjaF9wZXJtcyBvbGRyb290IHJvb3Qg cGF0aCA9CiAJbG9va3VwX3dhdGNoX3Blcm0gcGF0aCBvbGRyb290IEAgbG9v a3VwX3dhdGNoX3Blcm0gcGF0aCAoU29tZSByb290KQogCi1sZXQgZmlyZV9z aW5nbGVfd2F0Y2hfdW5jaGVja2VkIHdhdGNoID0KK2xldCBmaXJlX3Npbmds ZV93YXRjaF91bmNoZWNrZWQgc291cmNlIHdhdGNoID0KIAlsZXQgZGF0YSA9 IFV0aWxzLmpvaW5fYnlfbnVsbCBbd2F0Y2gucGF0aDsgd2F0Y2gudG9rZW47 ICIiXSBpbgotCXNlbmRfcmVwbHkgd2F0Y2guY29uIFRyYW5zYWN0aW9uLm5v bmUgMCBYZW5idXMuWGIuT3AuV2F0Y2hldmVudCBkYXRhCisJbGV0IHBrdCA9 IHBhY2tldF9vZiB3YXRjaC5jb24gVHJhbnNhY3Rpb24ubm9uZSAwIFhlbmJ1 cy5YYi5PcC5XYXRjaGV2ZW50IGRhdGEgaW4KKworCW1hdGNoIEJvdW5kZWRQ aXBlLnB1c2ggc291cmNlLnBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRzICh3 YXRjaCwgcGt0KSB3aXRoCisJfCBTb21lICgpIC0+ICgpICgqIHBhY2tldCBx dWV1ZWQgKikKKwl8IE5vbmUgLT4KKwkJCSgqIGEgd2VsbCBiZWhhdmVkIERv bTAgc2hvdWxkbid0IGJlIGFibGUgdG8gdHJpZ2dlciB0aGlzLAorCQkJICAg aWYgaXQgaGFwcGVucyBpdCBpcyBsaWtlbHkgYSBEb20wIGJ1ZyBjYXVzaW5n IHJ1bmF3YXkgbWVtb3J5IHVzYWdlCisJCQkgKikKKwkJCWZhaWx3aXRoICJ3 YXRjaCBldmVudCBvdmVyZmxvdywgY2Fubm90IGhhcHBlbiIKIAotbGV0IGZp cmVfc2luZ2xlX3dhdGNoIChvbGRyb290LCByb290KSB3YXRjaCA9CitsZXQg ZmlyZV9zaW5nbGVfd2F0Y2ggc291cmNlIChvbGRyb290LCByb290KSB3YXRj aCA9CiAJbGV0IGFic3BhdGggPSBnZXRfd2F0Y2hfcGF0aCB3YXRjaC5jb24g d2F0Y2gucGF0aCB8PiBTdG9yZS5QYXRoLm9mX3N0cmluZyBpbgogCWxldCBw ZXJtcyA9IGxvb2t1cF93YXRjaF9wZXJtcyBvbGRyb290IHJvb3QgYWJzcGF0 aCBpbgogCWlmIFBlcm1zLmNhbl9maXJlX3dhdGNoIHdhdGNoLmNvbi5wZXJt IHBlcm1zIHRoZW4KLQkJZmlyZV9zaW5nbGVfd2F0Y2hfdW5jaGVja2VkIHdh dGNoCisJCWZpcmVfc2luZ2xlX3dhdGNoX3VuY2hlY2tlZCBzb3VyY2Ugd2F0 Y2gKIAllbHNlCiAJCWxldCBwZXJtcyA9IHBlcm1zIHw+IExpc3QubWFwIChQ ZXJtcy5Ob2RlLnRvX3N0cmluZyB+c2VwOiIgIikgfD4gU3RyaW5nLmNvbmNh dCAiLCAiIGluCiAJCWxldCBjb24gPSBnZXRfZG9tc3RyIHdhdGNoLmNvbiBp bgogCQlMb2dnaW5nLndhdGNoX25vdF9maXJlZCB+Y29uIHBlcm1zIChTdG9y ZS5QYXRoLnRvX3N0cmluZyBhYnNwYXRoKQogCi1sZXQgZmlyZV93YXRjaCBy b290cyB3YXRjaCBwYXRoID0KK2xldCBmaXJlX3dhdGNoIHNvdXJjZSByb290 cyB3YXRjaCBwYXRoID0KIAlsZXQgbmV3X3BhdGggPQogCQlpZiB3YXRjaC5p c19yZWxhdGl2ZSAmJiBwYXRoLlswXSA9ICcvJwogCQl0aGVuIGJlZ2luCkBA IC0yMzIsNyArMzYwLDcgQEAgbGV0IGZpcmVfd2F0Y2ggcm9vdHMgd2F0Y2gg cGF0aCA9CiAJCWVuZCBlbHNlCiAJCQlwYXRoCiAJaW4KLQlmaXJlX3Npbmds ZV93YXRjaCByb290cyB7IHdhdGNoIHdpdGggcGF0aCA9IG5ld19wYXRoIH0K KwlmaXJlX3NpbmdsZV93YXRjaCBzb3VyY2Ugcm9vdHMgeyB3YXRjaCB3aXRo IHBhdGggPSBuZXdfcGF0aCB9CiAKICgqIFNlYXJjaCBmb3IgYSB2YWxpZCB1 bnVzZWQgdHJhbnNhY3Rpb24gaWQuICopCiBsZXQgcmVjIHZhbGlkX3RyYW5z YWN0aW9uX2lkIGNvbiBwcm9wb3NlZF9pZCA9CkBAIC0yODAsNiArNDA4LDcg QEAgbGV0IGRvX2lucHV0IGNvbiA9IFhlbmJ1cy5YYi5pbnB1dCBjb24ueGIK IGxldCBoYXNfcGFydGlhbF9pbnB1dCBjb24gPSBYZW5idXMuWGIuaGFzX3Bh cnRpYWxfaW5wdXQgY29uLnhiCiBsZXQgaGFzX21vcmVfaW5wdXQgY29uID0g WGVuYnVzLlhiLmhhc19tb3JlX2lucHV0IGNvbi54YgogCitsZXQgY2FuX2lu cHV0IGNvbiA9IFhlbmJ1cy5YYi5jYW5faW5wdXQgY29uLnhiICYmIEJvdW5k ZWRQaXBlLmlzX2VtcHR5IGNvbi5wZW5kaW5nX3NvdXJjZV93YXRjaGV2ZW50 cwogbGV0IGhhc19vdXRwdXQgY29uID0gWGVuYnVzLlhiLmhhc19vdXRwdXQg Y29uLnhiCiBsZXQgaGFzX29sZF9vdXRwdXQgY29uID0gWGVuYnVzLlhiLmhh c19vbGRfb3V0cHV0IGNvbi54YgogbGV0IGhhc19uZXdfb3V0cHV0IGNvbiA9 IFhlbmJ1cy5YYi5oYXNfbmV3X291dHB1dCBjb24ueGIKQEAgLTMyMyw3ICs0 NTIsNyBAQCBsZXQgcHJldmVudHNfbGl2ZV91cGRhdGUgY29uID0gbm90IChp c19iYWQgY29uKQogCSYmIChoYXNfZXh0cmFfY29ubmVjdGlvbl9kYXRhIGNv biB8fCBoYXNfdHJhbnNhY3Rpb25fZGF0YSBjb24pCiAKIGxldCBoYXNfbW9y ZV93b3JrIGNvbiA9Ci0JaGFzX21vcmVfaW5wdXQgY29uIHx8IG5vdCAoaGFz X29sZF9vdXRwdXQgY29uKSAmJiBoYXNfbmV3X291dHB1dCBjb24KKwkoaGFz X21vcmVfaW5wdXQgY29uICYmIGNhbl9pbnB1dCBjb24pIHx8IG5vdCAoaGFz X29sZF9vdXRwdXQgY29uKSAmJiBoYXNfbmV3X291dHB1dCBjb24KIAogbGV0 IGluY3Jfb3BzIGNvbiA9IGNvbi5zdGF0X25iX29wcyA8LSBjb24uc3RhdF9u Yl9vcHMgKyAxCiAKZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3Jl ZC9jb25uZWN0aW9ucy5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25u ZWN0aW9ucy5tbAppbmRleCAzYzc0MjlmZTdmNjEuLjdkNjhjNTgzYjQzYSAx MDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Nvbm5lY3Rpb25z Lm1sCisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9ucy5t bApAQCAtMjIsMjIgKzIyLDMwIEBAIHR5cGUgdCA9IHsKIAlkb21haW5zOiAo aW50LCBDb25uZWN0aW9uLnQpIEhhc2h0YmwudDsKIAlwb3J0czogKFhlbmV2 ZW50Y2huLnQsIENvbm5lY3Rpb24udCkgSGFzaHRibC50OwogCW11dGFibGUg d2F0Y2hlczogQ29ubmVjdGlvbi53YXRjaCBsaXN0IFRyaWUudDsKKwltdXRh YmxlIGhhc19wZW5kaW5nX3dhdGNoZXZlbnRzOiBDb25uZWN0aW9uLldhdGNo LlNldC50CiB9CiAKIGxldCBjcmVhdGUgKCkgPSB7CiAJYW5vbnltb3VzID0g SGFzaHRibC5jcmVhdGUgMzc7CiAJZG9tYWlucyA9IEhhc2h0YmwuY3JlYXRl IDM3OwogCXBvcnRzID0gSGFzaHRibC5jcmVhdGUgMzc7Ci0Jd2F0Y2hlcyA9 IFRyaWUuY3JlYXRlICgpCisJd2F0Y2hlcyA9IFRyaWUuY3JlYXRlICgpOwor CWhhc19wZW5kaW5nX3dhdGNoZXZlbnRzID0gQ29ubmVjdGlvbi5XYXRjaC5T ZXQuZW1wdHk7CiB9CiAKK2xldCBnZXRfY2FwYWNpdHkgKCkgPQorCSgqIG5v dCBtdWx0aXBsaWVkIGJ5IG1heHdhdGNoIG9uIHB1cnBvc2U6IDJuZCBxdWV1 ZSBpbiB3YXRjaCBpdHNlbGYhICopCisJeyBYZW5idXMuWGIubWF4b3V0c3Rh bmRpbmcgPSAhRGVmaW5lLm1heG91dHN0YW5kaW5nOyBtYXh3YXRjaGV2ZW50 cyA9ICFEZWZpbmUubWF4d2F0Y2hldmVudHMgfQorCiBsZXQgYWRkX2Fub255 bW91cyBjb25zIGZkID0KLQlsZXQgeGJjb24gPSBYZW5idXMuWGIub3Blbl9m ZCBmZCBpbgorCWxldCBjYXBhY2l0eSA9IGdldF9jYXBhY2l0eSAoKSBpbgor CWxldCB4YmNvbiA9IFhlbmJ1cy5YYi5vcGVuX2ZkIGZkIH5jYXBhY2l0eSBp bgogCWxldCBjb24gPSBDb25uZWN0aW9uLmNyZWF0ZSB4YmNvbiBOb25lIGlu CiAJSGFzaHRibC5hZGQgY29ucy5hbm9ueW1vdXMgKFhlbmJ1cy5YYi5nZXRf ZmQgeGJjb24pIGNvbgogCiBsZXQgYWRkX2RvbWFpbiBjb25zIGRvbSA9Ci0J bGV0IHhiY29uID0gWGVuYnVzLlhiLm9wZW5fbW1hcCAoRG9tYWluLmdldF9p bnRlcmZhY2UgZG9tKSAoZnVuICgpIC0+IERvbWFpbi5ub3RpZnkgZG9tKSBp bgorCWxldCBjYXBhY2l0eSA9IGdldF9jYXBhY2l0eSAoKSBpbgorCWxldCB4 YmNvbiA9IFhlbmJ1cy5YYi5vcGVuX21tYXAgfmNhcGFjaXR5IChEb21haW4u Z2V0X2ludGVyZmFjZSBkb20pIChmdW4gKCkgLT4gRG9tYWluLm5vdGlmeSBk b20pIGluCiAJbGV0IGNvbiA9IENvbm5lY3Rpb24uY3JlYXRlIHhiY29uIChT b21lIGRvbSkgaW4KIAlIYXNodGJsLmFkZCBjb25zLmRvbWFpbnMgKERvbWFp bi5nZXRfaWQgZG9tKSBjb247CiAJbWF0Y2ggRG9tYWluLmdldF9wb3J0IGRv bSB3aXRoCkBAIC00OCw3ICs1Niw5IEBAIGxldCBzZWxlY3QgPyhvbmx5X2lm ID0gKGZ1biBfIC0+IHRydWUpKSBjb25zID0KIAlIYXNodGJsLmZvbGQgKGZ1 biBfIGNvbiAoaW5zLCBvdXRzKSAtPgogCQlpZiAob25seV9pZiBjb24pIHRo ZW4gKAogCQkJbGV0IGZkID0gQ29ubmVjdGlvbi5nZXRfZmQgY29uIGluCi0J CQkoZmQgOjogaW5zLCAgaWYgQ29ubmVjdGlvbi5oYXNfb3V0cHV0IGNvbiB0 aGVuIGZkIDo6IG91dHMgZWxzZSBvdXRzKQorCQkJbGV0IGluX2ZkcyA9IGlm IENvbm5lY3Rpb24uY2FuX2lucHV0IGNvbiB0aGVuIGZkIDo6IGlucyBlbHNl IGlucyBpbgorCQkJbGV0IG91dF9mZHMgPSBpZiBDb25uZWN0aW9uLmhhc19v dXRwdXQgY29uIHRoZW4gZmQgOjogb3V0cyBlbHNlIG91dHMgaW4KKwkJCWlu X2Zkcywgb3V0X2ZkcwogCQkpIGVsc2UgKGlucywgb3V0cykKIAkpCiAJY29u cy5hbm9ueW1vdXMgKFtdLCBbXSkKQEAgLTY3LDEwICs3NywxNyBAQCBsZXQg ZGVsX3dhdGNoZXNfb2ZfY29uIGNvbiB3YXRjaGVzID0KIAl8IFtdIC0+IE5v bmUKIAl8IHdzIC0+IFNvbWUgd3MKIAorbGV0IGRlbF93YXRjaGVzIGNvbnMg Y29uID0KKwlDb25uZWN0aW9uLmRlbF93YXRjaGVzIGNvbjsKKwljb25zLndh dGNoZXMgPC0gVHJpZS5tYXAgKGRlbF93YXRjaGVzX29mX2NvbiBjb24pIGNv bnMud2F0Y2hlczsKKwljb25zLmhhc19wZW5kaW5nX3dhdGNoZXZlbnRzIDwt CisJCWNvbnMuaGFzX3BlbmRpbmdfd2F0Y2hldmVudHMgfD4gQ29ubmVjdGlv bi5XYXRjaC5TZXQuZmlsdGVyIEBAIGZ1biB3IC0+CisJCUNvbm5lY3Rpb24u Z2V0X2NvbiB3ICE9IGNvbgorCiBsZXQgZGVsX2Fub255bW91cyBjb25zIGNv biA9CiAJdHJ5CiAJCUhhc2h0YmwucmVtb3ZlIGNvbnMuYW5vbnltb3VzIChD b25uZWN0aW9uLmdldF9mZCBjb24pOwotCQljb25zLndhdGNoZXMgPC0gVHJp ZS5tYXAgKGRlbF93YXRjaGVzX29mX2NvbiBjb24pIGNvbnMud2F0Y2hlczsK KwkJZGVsX3dhdGNoZXMgY29ucyBjb247CiAJCUNvbm5lY3Rpb24uY2xvc2Ug Y29uCiAJd2l0aCBleG4gLT4KIAkJZGVidWcgImRlbCBhbm9ueW1vdXMgJXMi IChQcmludGV4Yy50b19zdHJpbmcgZXhuKQpAQCAtODUsNyArMTAyLDcgQEAg bGV0IGRlbF9kb21haW4gY29ucyBpZCA9CiAJCSAgICB8IFNvbWUgcCAtPiBI YXNodGJsLnJlbW92ZSBjb25zLnBvcnRzIHAKIAkJICAgIHwgTm9uZSAtPiAo KSkKIAkJIHwgTm9uZSAtPiAoKSk7Ci0JCWNvbnMud2F0Y2hlcyA8LSBUcmll Lm1hcCAoZGVsX3dhdGNoZXNfb2ZfY29uIGNvbikgY29ucy53YXRjaGVzOwor CQlkZWxfd2F0Y2hlcyBjb25zIGNvbjsKIAkJQ29ubmVjdGlvbi5jbG9zZSBj b24KIAl3aXRoIGV4biAtPgogCQlkZWJ1ZyAiZGVsIGRvbWFpbiAldTogJXMi IGlkIChQcmludGV4Yy50b19zdHJpbmcgZXhuKQpAQCAtMTM2LDMxICsxNTMs MzMgQEAgbGV0IGRlbF93YXRjaCBjb25zIGNvbiBwYXRoIHRva2VuID0KIAkJ Y29ucy53YXRjaGVzIDwtIFRyaWUuc2V0IGNvbnMud2F0Y2hlcyBrZXkgd2F0 Y2hlczsKICAJd2F0Y2gKIAotbGV0IGRlbF93YXRjaGVzIGNvbnMgY29uID0K LQlDb25uZWN0aW9uLmRlbF93YXRjaGVzIGNvbjsKLQljb25zLndhdGNoZXMg PC0gVHJpZS5tYXAgKGRlbF93YXRjaGVzX29mX2NvbiBjb24pIGNvbnMud2F0 Y2hlcwotCiAoKiBwYXRoIGlzIGFic29sdXRlICopCi1sZXQgZmlyZV93YXRj aGVzID9vbGRyb290IHJvb3QgY29ucyBwYXRoIHJlY3Vyc2UgPQorbGV0IGZp cmVfd2F0Y2hlcyA/b2xkcm9vdCBzb3VyY2Ugcm9vdCBjb25zIHBhdGggcmVj dXJzZSA9CiAJbGV0IGtleSA9IGtleV9vZl9wYXRoIHBhdGggaW4KIAlsZXQg cGF0aCA9IFN0b3JlLlBhdGgudG9fc3RyaW5nIHBhdGggaW4KIAlsZXQgcm9v dHMgPSBvbGRyb290LCByb290IGluCiAJbGV0IGZpcmVfd2F0Y2ggXyA9IGZ1 bmN0aW9uCiAJCXwgTm9uZSAgICAgICAgIC0+ICgpCi0JCXwgU29tZSB3YXRj aGVzIC0+IExpc3QuaXRlciAoZnVuIHcgLT4gQ29ubmVjdGlvbi5maXJlX3dh dGNoIHJvb3RzIHcgcGF0aCkgd2F0Y2hlcworCQl8IFNvbWUgd2F0Y2hlcyAt PiBMaXN0Lml0ZXIgKGZ1biB3IC0+IENvbm5lY3Rpb24uZmlyZV93YXRjaCBz b3VyY2Ugcm9vdHMgdyBwYXRoKSB3YXRjaGVzCiAJaW4KIAlsZXQgZmlyZV9y ZWMgX3ggPSBmdW5jdGlvbgogCQl8IE5vbmUgICAgICAgICAtPiAoKQogCQl8 IFNvbWUgd2F0Y2hlcyAtPgotCQkJTGlzdC5pdGVyIChDb25uZWN0aW9uLmZp cmVfc2luZ2xlX3dhdGNoIHJvb3RzKSB3YXRjaGVzCisJCQlMaXN0Lml0ZXIg KENvbm5lY3Rpb24uZmlyZV9zaW5nbGVfd2F0Y2ggc291cmNlIHJvb3RzKSB3 YXRjaGVzCiAJaW4KIAlUcmllLml0ZXJfcGF0aCBmaXJlX3dhdGNoIGNvbnMu d2F0Y2hlcyBrZXk7CiAJaWYgcmVjdXJzZSB0aGVuCiAJCVRyaWUuaXRlciBm aXJlX3JlYyAoVHJpZS5zdWIgY29ucy53YXRjaGVzIGtleSkKIAorbGV0IHNl bmRfd2F0Y2hldmVudHMgY29ucyBjb24gPQorCWNvbnMuaGFzX3BlbmRpbmdf d2F0Y2hldmVudHMgPC0KKwkJY29ucy5oYXNfcGVuZGluZ193YXRjaGV2ZW50 cyB8PiBDb25uZWN0aW9uLldhdGNoLlNldC5maWx0ZXIgQ29ubmVjdGlvbi5X YXRjaC5mbHVzaF9ldmVudHM7CisJQ29ubmVjdGlvbi5zb3VyY2VfZmx1c2hf d2F0Y2hldmVudHMgY29uCisKIGxldCBmaXJlX3NwZWNfd2F0Y2hlcyByb290 IGNvbnMgc3BlY3BhdGggPQorCWxldCBzb3VyY2UgPSBmaW5kX2RvbWFpbiBj b25zIDAgaW4KIAlpdGVyIGNvbnMgKGZ1biBjb24gLT4KLQkJTGlzdC5pdGVy IChDb25uZWN0aW9uLmZpcmVfc2luZ2xlX3dhdGNoIChOb25lLCByb290KSkg KENvbm5lY3Rpb24uZ2V0X3dhdGNoZXMgY29uIHNwZWNwYXRoKSkKKwkJTGlz dC5pdGVyIChDb25uZWN0aW9uLmZpcmVfc2luZ2xlX3dhdGNoIHNvdXJjZSAo Tm9uZSwgcm9vdCkpIChDb25uZWN0aW9uLmdldF93YXRjaGVzIGNvbiBzcGVj cGF0aCkpCiAKIGxldCBzZXRfdGFyZ2V0IGNvbnMgZG9tYWluIHRhcmdldF9k b21haW4gPQogCWxldCBjb24gPSBmaW5kX2RvbWFpbiBjb25zIGRvbWFpbiBp bgpAQCAtMTk3LDYgKzIxNiwxNiBAQCBsZXQgZGVidWcgY29ucyA9CiAJbGV0 IGRvbWFpbnMgPSBIYXNodGJsLmZvbGQgKGZ1biBfIGNvbiBhY2N1IC0+IENv bm5lY3Rpb24uZGVidWcgY29uIDo6IGFjY3UpIGNvbnMuZG9tYWlucyBbXSBp bgogCVN0cmluZy5jb25jYXQgIiIgKGRvbWFpbnMgQCBhbm9ueW1vdXMpCiAK K2xldCBkZWJ1Z193YXRjaGV2ZW50cyBjb25zIGNvbiA9CisJKCogPT0gKHBo eXNpY2FsIGVxdWFsaXR5KQorCSAgIGhhcyB0byBiZSB1c2VkIGhlcmUgYmVj YXVzZSB3LmNvbi54Yi5iYWNrZW5kIG1pZ2h0IGNvbnRhaW4gYSBbdW5pdC0+ dW5pdF0gdmFsdWUgY2F1c2luZyByZWd1bGFyCisJICAgY29tcGFyaXNvbiB0 byBmYWlsIGR1ZSB0byBoYXZpbmcgYSAnZnVuY3Rpb25hbCB2YWx1ZScgd2hp Y2ggY2Fubm90IGJlIGNvbXBhcmVkLgorCSAqKQorCWxldCBzID0gY29ucy5o YXNfcGVuZGluZ193YXRjaGV2ZW50cyB8PiBDb25uZWN0aW9uLldhdGNoLlNl dC5maWx0ZXIgKGZ1biB3IC0+IHcuY29uID09IGNvbikgaW4KKwlsZXQgcGVu ZGluZyA9IHMgfD4gQ29ubmVjdGlvbi5XYXRjaC5TZXQuZWxlbWVudHMKKwkJ fD4gTGlzdC5tYXAgKGZ1biB3IC0+IENvbm5lY3Rpb24uV2F0Y2gucGVuZGlu Z193YXRjaGV2ZW50cyB3KSB8PiBMaXN0LmZvbGRfbGVmdCAoKykgMCBpbgor CVByaW50Zi5zcHJpbnRmICJXYXRjaGVzIHdpdGggcGVuZGluZyBldmVudHM6 ICVkLCBwZW5kaW5nIGV2ZW50cyB0b3RhbDogJWQiIChDb25uZWN0aW9uLldh dGNoLlNldC5jYXJkaW5hbCBzKSBwZW5kaW5nCisKIGxldCBmaWx0ZXIgfmYg Y29ucyA9CiAJbGV0IGZvbGQgXyB2IGFjYyA9IGlmIGYgdiB0aGVuIHYgOjog YWNjIGVsc2UgYWNjIGluCiAJW10KZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9kZWZpbmUubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQv ZGVmaW5lLm1sCmluZGV4IGJhNjNhODE0N2UwOS4uMzI3YjZkNzk1ZWM3IDEw MDY0NAotLS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQvZGVmaW5lLm1sCisr KyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKQEAgLTI0LDYg KzI0LDEzIEBAIGxldCBkZWZhdWx0X2NvbmZpZ19kaXIgPSBQYXRocy54ZW5f Y29uZmlnX2RpcgogbGV0IG1heHdhdGNoID0gcmVmICgxMDApCiBsZXQgbWF4 dHJhbnNhY3Rpb24gPSByZWYgKDEwKQogbGV0IG1heHJlcXVlc3RzID0gcmVm ICgxMDI0KSAgICgqIG1heGltdW0gcmVxdWVzdHMgcGVyIHRyYW5zYWN0aW9u ICopCitsZXQgbWF4b3V0c3RhbmRpbmcgPSByZWYgKDEwMjQpICgqIG1heGlt dW0gb3V0c3RhbmRpbmcgcmVxdWVzdHMsIGkuZS4gaW4tZmxpZ2h0IHJlcXVl c3RzIC8gZG9tYWluICopCitsZXQgbWF4d2F0Y2hldmVudHMgPSByZWYgKDEw MjQpCisoKgorCW1heGltdW0gb3V0c3RhbmRpbmcgd2F0Y2ggZXZlbnRzIHBl ciB3YXRjaCwKKwlyZWNvbW1lbmRlZCA+PSBtYXhvdXRzdGFuZGluZyB0byBh dm9pZCBibG9ja2luZyBiYWNrZW5kIHRyYW5zYWN0aW9ucyBkdWUgdG8KKwlt YWxpY2lvdXMgZnJvbnRlbmRzCisgKikKIAogbGV0IGdjX21heF9vdmVyaGVh ZCA9IHJlZiAxMjAgKCogMTIwJSBzZWUgY29tbWVudCBpbiB4ZW5zdG9yZWQu bWwgKikKIGxldCBjb25mbGljdF9idXJzdF9saW1pdCA9IHJlZiA1LjAKZGlm ZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9veGVuc3RvcmVkLmNv bmYuaW4gYi90b29scy9vY2FtbC94ZW5zdG9yZWQvb3hlbnN0b3JlZC5jb25m LmluCmluZGV4IDRhZTQ4ZTQyZDQ3ZC4uOWQwMzRlNzQ0YjRiIDEwMDY0NAot LS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQvb3hlbnN0b3JlZC5jb25mLmlu CisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9veGVuc3RvcmVkLmNvbmYu aW4KQEAgLTYyLDYgKzYyLDggQEAgcXVvdGEtbWF4d2F0Y2ggPSAxMDAKIHF1 b3RhLXRyYW5zYWN0aW9uID0gMTAKIHF1b3RhLW1heHJlcXVlc3RzID0gMTAy NAogcXVvdGEtcGF0aC1tYXggPSAxMDI0CitxdW90YS1tYXhvdXRzdGFuZGlu ZyA9IDEwMjQKK3F1b3RhLW1heHdhdGNoZXZlbnRzID0gMTAyNAogCiAjIEFj dGl2YXRlIGZpbGVkIGJhc2UgYmFja2VuZAogcGVyc2lzdGVudCA9IGZhbHNl CmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5t bCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9wcm9jZXNzLm1sCmluZGV4IDJk Njc0NTZhMmFhMC4uNmRjZWRmZGE4NmU0IDEwMDY0NAotLS0gYS90b29scy9v Y2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbAorKysgYi90b29scy9vY2FtbC94 ZW5zdG9yZWQvcHJvY2Vzcy5tbApAQCAtNTcsNyArNTcsNyBAQCBsZXQgc3Bs aXRfb25lX3BhdGggZGF0YSBjb24gPQogCXwgcGF0aCA6OiAiIiA6OiBbXSAt PiBTdG9yZS5QYXRoLmNyZWF0ZSBwYXRoIChDb25uZWN0aW9uLmdldF9wYXRo IGNvbikKIAl8IF8gICAgICAgICAgICAgICAgLT4gcmFpc2UgSW52YWxpZF9D bWRfQXJncwogCi1sZXQgcHJvY2Vzc193YXRjaCB0IGNvbnMgPQorbGV0IHBy b2Nlc3Nfd2F0Y2ggc291cmNlIHQgY29ucyA9CiAJbGV0IG9sZHJvb3QgPSB0 LlRyYW5zYWN0aW9uLm9sZHJvb3QgaW4KIAlsZXQgbmV3cm9vdCA9IFN0b3Jl LmdldF9yb290IHQuc3RvcmUgaW4KIAlsZXQgb3BzID0gVHJhbnNhY3Rpb24u Z2V0X3BhdGhzIHQgfD4gTGlzdC5yZXYgaW4KQEAgLTY3LDggKzY3LDkgQEAg bGV0IHByb2Nlc3Nfd2F0Y2ggdCBjb25zID0KIAkJfCBYZW5idXMuWGIuT3Au Um0gICAgICAgLT4gdHJ1ZSwgTm9uZSwgb2xkcm9vdAogCQl8IFhlbmJ1cy5Y Yi5PcC5TZXRwZXJtcyAtPiBmYWxzZSwgU29tZSBvbGRyb290LCBuZXdyb290 CiAJCXwgXyAgICAgICAgICAgICAgLT4gcmFpc2UgKEZhaWx1cmUgImh1aCA/ IikgaW4KLQkJQ29ubmVjdGlvbnMuZmlyZV93YXRjaGVzID9vbGRyb290IHJv b3QgY29ucyAoc25kIG9wKSByZWN1cnNlIGluCi0JTGlzdC5pdGVyIChmdW4g b3AgLT4gZG9fb3Bfd2F0Y2ggb3AgY29ucykgb3BzCisJCUNvbm5lY3Rpb25z LmZpcmVfd2F0Y2hlcyA/b2xkcm9vdCBzb3VyY2Ugcm9vdCBjb25zIChzbmQg b3ApIHJlY3Vyc2UgaW4KKwlMaXN0Lml0ZXIgKGZ1biBvcCAtPiBkb19vcF93 YXRjaCBvcCBjb25zKSBvcHM7CisJQ29ubmVjdGlvbnMuc2VuZF93YXRjaGV2 ZW50cyBjb25zIHNvdXJjZQogCiBsZXQgY3JlYXRlX2ltcGxpY2l0X3BhdGgg dCBwZXJtIHBhdGggPQogCWxldCBkaXJuYW1lID0gU3RvcmUuUGF0aC5nZXRf cGFyZW50IHBhdGggaW4KQEAgLTIzNCw2ICsyMzUsMjAgQEAgbGV0IGRvX2Rl YnVnIGNvbiB0IF9kb21haW5zIGNvbnMgZGF0YSA9CiAJfCAid2F0Y2hlcyIg OjogXyAtPgogCQlsZXQgd2F0Y2hlcyA9IENvbm5lY3Rpb25zLmRlYnVnIGNv bnMgaW4KIAkJU29tZSAod2F0Y2hlcyBeICJcMDAwIikKKwl8ICJ4ZW5idXMi IDo6IGRvbWlkIDo6IF8gLT4KKwkJbGV0IGRvbWlkID0gaW50X29mX3N0cmlu ZyBkb21pZCBpbgorCQlsZXQgY29uID0gQ29ubmVjdGlvbnMuZmluZF9kb21h aW4gY29ucyBkb21pZCBpbgorCQlsZXQgcyA9IFByaW50Zi5zcHJpbnRmICJ4 ZW5idXM6ICVzOyBvdmVyZmxvdyBxdWV1ZSBsZW5ndGg6ICVkLCBjYW5faW5w dXQ6ICViLCBoYXNfbW9yZV9pbnB1dDogJWIsIGhhc19vbGRfb3V0cHV0OiAl YiwgaGFzX25ld19vdXRwdXQ6ICViLCBoYXNfbW9yZV93b3JrOiAlYi4gcGVu ZGluZzogJXMiCisJCQkoWGVuYnVzLlhiLmRlYnVnIGNvbi54YikKKwkJCShD b25uZWN0aW9uLnNvdXJjZV9wZW5kaW5nX3dhdGNoZXZlbnRzIGNvbikKKwkJ CShDb25uZWN0aW9uLmNhbl9pbnB1dCBjb24pCisJCQkoQ29ubmVjdGlvbi5o YXNfbW9yZV9pbnB1dCBjb24pCisJCQkoQ29ubmVjdGlvbi5oYXNfb2xkX291 dHB1dCBjb24pCisJCQkoQ29ubmVjdGlvbi5oYXNfbmV3X291dHB1dCBjb24p CisJCQkoQ29ubmVjdGlvbi5oYXNfbW9yZV93b3JrIGNvbikKKwkJCShDb25u ZWN0aW9ucy5kZWJ1Z193YXRjaGV2ZW50cyBjb25zIGNvbikKKwkJaW4KKwkJ U29tZSBzCiAJfCAibWZuIiA6OiBkb21pZCA6OiBfIC0+CiAJCWxldCBkb21p ZCA9IGludF9vZl9zdHJpbmcgZG9taWQgaW4KIAkJbGV0IGNvbiA9IENvbm5l Y3Rpb25zLmZpbmRfZG9tYWluIGNvbnMgZG9taWQgaW4KQEAgLTM0Miw3ICsz NTcsNyBAQCBsZXQgcmVwbHlfYWNrIGZjdCBjb24gdCBkb21zIGNvbnMgZGF0 YSA9CiAJZmN0IGNvbiB0IGRvbXMgY29ucyBkYXRhOwogCVBhY2tldC5BY2sg KGZ1biAoKSAtPgogCQlpZiBUcmFuc2FjdGlvbi5nZXRfaWQgdCA9IFRyYW5z YWN0aW9uLm5vbmUgdGhlbgotCQkJcHJvY2Vzc193YXRjaCB0IGNvbnMKKwkJ CXByb2Nlc3Nfd2F0Y2ggY29uIHQgY29ucwogCSkKIAogbGV0IHJlcGx5X2Rh dGEgZmN0IGNvbiB0IGRvbXMgY29ucyBkYXRhID0KQEAgLTUwMSw3ICs1MTYs NyBAQCBsZXQgZG9fd2F0Y2ggY29uIHQgX2RvbWFpbnMgY29ucyBkYXRhID0K IAlQYWNrZXQuQWNrIChmdW4gKCkgLT4KIAkJKCogeGVuc3RvcmUudHh0IHNh eXMgdGhpcyB3YXRjaCBpcyBmaXJlZCBpbW1lZGlhdGVseSwKIAkJICAgaW1w bHlpbmcgZXZlbiBpZiBwYXRoIGRvZXNuJ3QgZXhpc3Qgb3IgaXMgdW5yZWFk YWJsZSAqKQotCQlDb25uZWN0aW9uLmZpcmVfc2luZ2xlX3dhdGNoX3VuY2hl Y2tlZCB3YXRjaCkKKwkJQ29ubmVjdGlvbi5maXJlX3NpbmdsZV93YXRjaF91 bmNoZWNrZWQgY29uIHdhdGNoKQogCiBsZXQgZG9fdW53YXRjaCBjb24gX3Qg X2RvbWFpbnMgY29ucyBkYXRhID0KIAlsZXQgKG5vZGUsIHRva2VuKSA9CkBA IC01MzIsNyArNTQ3LDcgQEAgbGV0IGRvX3RyYW5zYWN0aW9uX2VuZCBjb24g dCBkb21haW5zIGNvbnMgZGF0YSA9CiAJaWYgbm90IHN1Y2Nlc3MgdGhlbgog CQlyYWlzZSBUcmFuc2FjdGlvbl9hZ2FpbjsKIAlpZiBjb21taXQgdGhlbiBi ZWdpbgotCQlwcm9jZXNzX3dhdGNoIHQgY29uczsKKwkJcHJvY2Vzc193YXRj aCBjb24gdCBjb25zOwogCQltYXRjaCB0LlRyYW5zYWN0aW9uLnR5IHdpdGgK IAkJfCBUcmFuc2FjdGlvbi5ObyAtPgogCQkJKCkgKCogbm8gbmVlZCB0byBy ZWNvcmQgYW55dGhpbmcgKikKQEAgLTY5OSw3ICs3MTQsOCBAQCBsZXQgcHJv Y2Vzc19wYWNrZXQgfnN0b3JlIH5jb25zIH5kb21zIH5jb24gfnJlcSA9CiBs ZXQgZG9faW5wdXQgc3RvcmUgY29ucyBkb21zIGNvbiA9CiAJbGV0IG5ld3Bh Y2tldCA9CiAJCXRyeQotCQkJQ29ubmVjdGlvbi5kb19pbnB1dCBjb24KKwkJ CWlmIENvbm5lY3Rpb24uY2FuX2lucHV0IGNvbiB0aGVuIENvbm5lY3Rpb24u ZG9faW5wdXQgY29uCisJCQllbHNlIE5vbmUKIAkJd2l0aCBYZW5idXMuWGIu UmVjb25uZWN0IC0+CiAJCQlpbmZvICIlcyByZXF1ZXN0cyBhIHJlY29ubmVj dCIgKENvbm5lY3Rpb24uZ2V0X2RvbXN0ciBjb24pOwogCQkJSGlzdG9yeS5y ZWNvbm5lY3QgY29uOwpAQCAtNzI3LDYgKzc0Myw3IEBAIGxldCBkb19pbnB1 dCBzdG9yZSBjb25zIGRvbXMgY29uID0KIAkJQ29ubmVjdGlvbi5pbmNyX29w cyBjb24KIAogbGV0IGRvX291dHB1dCBfc3RvcmUgX2NvbnMgX2RvbXMgY29u ID0KKwlDb25uZWN0aW9uLnNvdXJjZV9mbHVzaF93YXRjaGV2ZW50cyBjb247 CiAJaWYgQ29ubmVjdGlvbi5oYXNfb3V0cHV0IGNvbiB0aGVuICgKIAkJaWYg Q29ubmVjdGlvbi5oYXNfbmV3X291dHB1dCBjb24gdGhlbiAoCiAJCQlsZXQg cGFja2V0ID0gQ29ubmVjdGlvbi5wZWVrX291dHB1dCBjb24gaW4KZGlmZiAt LWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC94ZW5zdG9yZWQubWwgYi90 b29scy9vY2FtbC94ZW5zdG9yZWQveGVuc3RvcmVkLm1sCmluZGV4IDNiNTdh ZDAxNmRmYi4uYzc5OWUyMGYxMTQ1IDEwMDY0NAotLS0gYS90b29scy9vY2Ft bC94ZW5zdG9yZWQveGVuc3RvcmVkLm1sCisrKyBiL3Rvb2xzL29jYW1sL3hl bnN0b3JlZC94ZW5zdG9yZWQubWwKQEAgLTEwMyw2ICsxMDMsOCBAQCBsZXQg cGFyc2VfY29uZmlnIGZpbGVuYW1lID0KIAkJKCJxdW90YS1tYXhlbnRpdHki LCBDb25maWcuU2V0X2ludCBRdW90YS5tYXhlbnQpOwogCQkoInF1b3RhLW1h eHNpemUiLCBDb25maWcuU2V0X2ludCBRdW90YS5tYXhzaXplKTsKIAkJKCJx dW90YS1tYXhyZXF1ZXN0cyIsIENvbmZpZy5TZXRfaW50IERlZmluZS5tYXhy ZXF1ZXN0cyk7CisJCSgicXVvdGEtbWF4b3V0c3RhbmRpbmciLCBDb25maWcu U2V0X2ludCBEZWZpbmUubWF4b3V0c3RhbmRpbmcpOworCQkoInF1b3RhLW1h eHdhdGNoZXZlbnRzIiwgQ29uZmlnLlNldF9pbnQgRGVmaW5lLm1heHdhdGNo ZXZlbnRzKTsKIAkJKCJxdW90YS1wYXRoLW1heCIsIENvbmZpZy5TZXRfaW50 IERlZmluZS5wYXRoX21heCk7CiAJCSgiZ2MtbWF4LW92ZXJoZWFkIiwgQ29u ZmlnLlNldF9pbnQgRGVmaW5lLmdjX21heF9vdmVyaGVhZCk7CiAJCSgidGVz dC1lYWdhaW4iLCBDb25maWcuU2V0X2Jvb2wgVHJhbnNhY3Rpb24udGVzdF9l YWdhaW4pOwo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-oxenstored-08.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-oxenstored-08.patch" Content-Transfer-Encoding: base64 RnJvbSA4ZWJhMGJhYjljMzZjMDRkOTI0ZjlmZTk3YjFmYTI2NGZlMjNmMTll IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFRodSwgMjkgU2VwIDIwMjIgMTM6 MDc6MzUgKzAyMDAKU3ViamVjdDogU1VQUE9SVC5tZDogY2xhcmlmeSBzdXBw b3J0IG9mIHVudHJ1c3RlZCBkcml2ZXIgZG9tYWlucyB3aXRoCiBveGVuc3Rv cmVkCgpBZGQgYSBzdXBwb3J0IHN0YXRlbWVudCBmb3IgdGhlIHNjb3BlIG9m IHN1cHBvcnQgcmVnYXJkaW5nIGRpZmZlcmVudApYZW5zdG9yZSB2YXJpYW50 cy4gRXNwZWNpYWxseSBveGVuc3RvcmVkIGRvZXMgbm90ICh5ZXQpIGhhdmUg c2VjdXJpdHkKc3VwcG9ydCBvZiB1bnRydXN0ZWQgZHJpdmVyIGRvbWFpbnMs IGFzIHRob3NlIG1pZ2h0IGRyaXZlIG94ZW5zdG9yZWQKb3V0IG9mIG1lbW9y eSBieSBjcmVhdGluZyBsb3RzIG9mIHdhdGNoIGV2ZW50cyBmb3IgdGhlIGd1 ZXN0cyB0aGV5IGFyZQpzZXJ2aWNpbmcuCgpBZGQgYSBzdGF0ZW1lbnQgcmVn YXJkaW5nIExpdmUgVXBkYXRlIHN1cHBvcnQgb2Ygb3hlbnN0b3JlZC4KClRo aXMgaXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEdlb3JnZSBE dW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClJldmlld2VkLWJ5OiBD aHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+ CgpkaWZmIC0tZ2l0IGEvU1VQUE9SVC5tZCBiL1NVUFBPUlQubWQKaW5kZXgg MGZiMjYyZjgxZjQwLi40OGZiNDYyMjIxY2YgMTAwNjQ0Ci0tLSBhL1NVUFBP UlQubWQKKysrIGIvU1VQUE9SVC5tZApAQCAtMTc5LDEzICsxNzksMTggQEAg U3VwcG9ydCBmb3IgcnVubmluZyBxZW11LXhlbiBkZXZpY2UgbW9kZWwgaW4g YSBsaW51eCBzdHViZG9tYWluLgogCiAgICAgU3RhdHVzOiBUZWNoIFByZXZp ZXcKIAotIyMgTGl2ZXVwZGF0ZSBvZiBDIHhlbnN0b3JlZCBkYWVtb24KKyMj IFhlbnN0b3JlCiAKLSAgICBTdGF0dXM6IFRlY2ggUHJldmlldworIyMjIEMg eGVuc3RvcmVkIGRhZW1vbgogCi0jIyBMaXZldXBkYXRlIG9mIE9DYW1sIHhl bnN0b3JlZCBkYWVtb24KKyAgICBTdGF0dXM6IFN1cHBvcnRlZAorICAgIFN0 YXR1cywgTGl2ZXVwZGF0ZTogVGVjaCBQcmV2aWV3CiAKLSAgICBTdGF0dXM6 IFRlY2ggUHJldmlldworIyMjIE9DYW1sIHhlbnN0b3JlZCBkYWVtb24KKwor ICAgIFN0YXR1czogU3VwcG9ydGVkCisgICAgU3RhdHVzLCB1bnRydXN0ZWQg ZHJpdmVyIGRvbWFpbnM6IFN1cHBvcnRlZCwgbm90IHNlY3VyaXR5IHN1cHBv cnRlZAorICAgIFN0YXR1cywgTGl2ZXVwZGF0ZTogTm90IGZ1bmN0aW9uYWwK IAogIyMgVG9vbHN0YWNrLzNyZCBwYXJ0eQogCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-01.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-01.patch" Content-Transfer-Encoding: base64 RnJvbSBiYjIyNzA5ZDk0ZmE5OGY1YTJhYmJhNGVlZWJhNDFlZjA5NzUzZjhl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHNwbGl0IHVw IHNlbmRfcmVwbHkoKQoKVG9kYXkgc2VuZF9yZXBseSgpIGlzIHVzZWQgZm9y IGJvdGgsIG5vcm1hbCByZXF1ZXN0IHJlcGxpZXMgYW5kIHdhdGNoCmV2ZW50 cy4KClNwbGl0IGl0IHVwIGludG8gc2VuZF9yZXBseSgpIGFuZCBzZW5kX2V2 ZW50KCkuIFRoaXMgd2lsbCBiZSB1c2VkIHRvCmFkZCBzb21lIGV2ZW50IHNw ZWNpZmljIGhhbmRsaW5nLgoKYWRkX2V2ZW50KCkgY2FuIGJlIG1lcmdlZCBp bnRvIHNlbmRfZXZlbnQoKSwgcmVtb3ZpbmcgdGhlIG5lZWQgZm9yIGFuCmlu dGVybWVkaWF0ZSBtZW1vcnkgYWxsb2NhdGlvbi4KClRoaXMgaXMgcGFydCBv ZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxs QGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpn cm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdy YWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMKaW5kZXggYjI4YzJjNjZiNTNiLi4wMWQ0YTJlNDQwZWMgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtNzMzLDQ5ICs3 MzMsMzIgQEAgc3RhdGljIHZvaWQgc2VuZF9lcnJvcihzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgaW50IGVycm9yKQogdm9pZCBzZW5kX3JlcGx5KHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlw ZSwKIAkJY29uc3Qgdm9pZCAqZGF0YSwgdW5zaWduZWQgaW50IGxlbikKIHsK LQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRhdGE7CisJc3RydWN0IGJ1ZmZl cmVkX2RhdGEgKmJkYXRhID0gY29ubi0+aW47CisKKwlhc3NlcnQodHlwZSAh PSBYU19XQVRDSF9FVkVOVCk7CiAKIAlpZiAoIGxlbiA+IFhFTlNUT1JFX1BB WUxPQURfTUFYICkgewogCQlzZW5kX2Vycm9yKGNvbm4sIEUyQklHKTsKIAkJ cmV0dXJuOwogCX0KIAotCS8qIFJlcGxpZXMgcmV1c2UgdGhlIHJlcXVlc3Qg YnVmZmVyLCBldmVudHMgbmVlZCBhIG5ldyBvbmUuICovCi0JaWYgKHR5cGUg IT0gWFNfV0FUQ0hfRVZFTlQpIHsKLQkJYmRhdGEgPSBjb25uLT5pbjsKLQkJ LyogRHJvcCBhc3luY2hyb25vdXMgcmVzcG9uc2VzLCBlLmcuIGVycm9ycyBm b3Igd2F0Y2ggZXZlbnRzLiAqLwotCQlpZiAoIWJkYXRhKQotCQkJcmV0dXJu OwotCQliZGF0YS0+aW5oZHIgPSB0cnVlOwotCQliZGF0YS0+dXNlZCA9IDA7 Ci0JCWNvbm4tPmluID0gTlVMTDsKLQl9IGVsc2UgewotCQkvKiBNZXNzYWdl IGlzIGEgY2hpbGQgb2YgdGhlIGNvbm5lY3Rpb24gZm9yIGF1dG8tY2xlYW51 cC4gKi8KLQkJYmRhdGEgPSBuZXdfYnVmZmVyKGNvbm4pOworCWlmICghYmRh dGEpCisJCXJldHVybjsKKwliZGF0YS0+aW5oZHIgPSB0cnVlOworCWJkYXRh LT51c2VkID0gMDsKIAotCQkvKgotCQkgKiBBbGxvY2F0aW9uIGZhaWx1cmUg aGVyZSBpcyB1bmZvcnR1bmF0ZTogd2UgaGF2ZSBubyB3YXkgdG8KLQkJICog dGVsbCBhbnlib2R5IGFib3V0IGl0LgotCQkgKi8KLQkJaWYgKCFiZGF0YSkK LQkJCXJldHVybjsKLQl9CiAJaWYgKGxlbiA8PSBERUZBVUxUX0JVRkZFUl9T SVpFKQogCQliZGF0YS0+YnVmZmVyID0gYmRhdGEtPmRlZmF1bHRfYnVmZmVy OwotCWVsc2UKKwllbHNlIHsKIAkJYmRhdGEtPmJ1ZmZlciA9IHRhbGxvY19h cnJheShiZGF0YSwgY2hhciwgbGVuKTsKLQlpZiAoIWJkYXRhLT5idWZmZXIp IHsKLQkJaWYgKHR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQpIHsKLQkJCS8qIFNh bWUgYXMgYWJvdmU6IG5vIHdheSB0byB0ZWxsIHNvbWVvbmUuICovCi0JCQl0 YWxsb2NfZnJlZShiZGF0YSk7CisJCWlmICghYmRhdGEtPmJ1ZmZlcikgewor CQkJc2VuZF9lcnJvcihjb25uLCBFTk9NRU0pOwogCQkJcmV0dXJuOwogCQl9 Ci0JCS8qIHJlLWVzdGFibGlzaCByZXF1ZXN0IGJ1ZmZlciBmb3Igc2VuZGlu ZyBFTk9NRU0uICovCi0JCWNvbm4tPmluID0gYmRhdGE7Ci0JCXNlbmRfZXJy b3IoY29ubiwgRU5PTUVNKTsKLQkJcmV0dXJuOwogCX0KIAorCWNvbm4tPmlu ID0gTlVMTDsKKwogCS8qIFVwZGF0ZSByZWxldmFudCBoZWFkZXIgZmllbGRz IGFuZCBmaWxsIGluIHRoZSBtZXNzYWdlIGJvZHkuICovCiAJYmRhdGEtPmhk ci5tc2cudHlwZSA9IHR5cGU7CiAJYmRhdGEtPmhkci5tc2cubGVuID0gbGVu OwpAQCAtNzgzLDggKzc2NiwzOSBAQCB2b2lkIHNlbmRfcmVwbHkoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBl LAogCiAJLyogUXVldWUgZm9yIGxhdGVyIHRyYW5zbWlzc2lvbi4gKi8KIAls aXN0X2FkZF90YWlsKCZiZGF0YS0+bGlzdCwgJmNvbm4tPm91dF9saXN0KTsK K30KIAotCXJldHVybjsKKy8qCisgKiBTZW5kIGEgd2F0Y2ggZXZlbnQuCisg KiBBcyB0aGlzIGlzIG5vdCBkaXJlY3RseSByZWxhdGVkIHRvIHRoZSBjdXJy ZW50IGNvbW1hbmQsIGVycm9ycyBjYW4ndCBiZQorICogcmVwb3J0ZWQuCisg Ki8KK3ZvaWQgc2VuZF9ldmVudChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3QgY2hhciAqcGF0aCwgY29uc3QgY2hhciAqdG9rZW4pCit7CisJc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmJkYXRhOworCXVuc2lnbmVkIGludCBsZW47 CisKKwlsZW4gPSBzdHJsZW4ocGF0aCkgKyAxICsgc3RybGVuKHRva2VuKSAr IDE7CisJLyogRG9uJ3QgdHJ5IHRvIHNlbmQgb3Zlci1sb25nIGV2ZW50cy4g Ki8KKwlpZiAobGVuID4gWEVOU1RPUkVfUEFZTE9BRF9NQVgpCisJCXJldHVy bjsKKworCWJkYXRhID0gbmV3X2J1ZmZlcihjb25uKTsKKwlpZiAoIWJkYXRh KQorCQlyZXR1cm47CisKKwliZGF0YS0+YnVmZmVyID0gdGFsbG9jX2FycmF5 KGJkYXRhLCBjaGFyLCBsZW4pOworCWlmICghYmRhdGEtPmJ1ZmZlcikgewor CQl0YWxsb2NfZnJlZShiZGF0YSk7CisJCXJldHVybjsKKwl9CisJc3RyY3B5 KGJkYXRhLT5idWZmZXIsIHBhdGgpOworCXN0cmNweShiZGF0YS0+YnVmZmVy ICsgc3RybGVuKHBhdGgpICsgMSwgdG9rZW4pOworCWJkYXRhLT5oZHIubXNn LnR5cGUgPSBYU19XQVRDSF9FVkVOVDsKKwliZGF0YS0+aGRyLm1zZy5sZW4g PSBsZW47CisKKwkvKiBRdWV1ZSBmb3IgbGF0ZXIgdHJhbnNtaXNzaW9uLiAq LworCWxpc3RfYWRkX3RhaWwoJmJkYXRhLT5saXN0LCAmY29ubi0+b3V0X2xp c3QpOwogfQogCiAvKiBTb21lIHJvdXRpbmVzICh3cml0ZSwgbWtkaXIsIGV0 YykganVzdCBuZWVkIGEgbm9uLWVycm9yIHJldHVybiAqLwpkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKaW5kZXggOTAwMzM2YWZhNDI2Li4z OGQ5N2ZhMDgxYTYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuaApAQCAtMTgwLDYgKzE4MCw3IEBAIHVuc2lnbmVkIGludCBnZXRfc3Ry aW5nKGNvbnN0IHN0cnVjdCBidWZmZXJlZF9kYXRhICpkYXRhLCB1bnNpZ25l ZCBpbnQgb2Zmc2V0KTsKIAogdm9pZCBzZW5kX3JlcGx5KHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSwKIAkJ Y29uc3Qgdm9pZCAqZGF0YSwgdW5zaWduZWQgaW50IGxlbik7Cit2b2lkIHNl bmRfZXZlbnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IGNoYXIg KnBhdGgsIGNvbnN0IGNoYXIgKnRva2VuKTsKIAogLyogU29tZSByb3V0aW5l cyAod3JpdGUsIG1rZGlyLCBldGMpIGp1c3QgbmVlZCBhIG5vbi1lcnJvciBy ZXR1cm4gKi8KIHZvaWQgc2VuZF9hY2soc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlKTsKZGlmZiAtLWdpdCBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX3dhdGNoLmMKaW5kZXggZGI4OWUwMTQxZmNlLi5h MTE2Zjk2N2RjNjYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF93YXRjaC5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93 YXRjaC5jCkBAIC04NiwzNSArODYsNiBAQCBzdGF0aWMgY29uc3QgY2hhciAq Z2V0X3dhdGNoX3BhdGgoY29uc3Qgc3RydWN0IHdhdGNoICp3YXRjaCwgY29u c3QgY2hhciAqbmFtZSkKIH0KIAogLyoKLSAqIFNlbmQgYSB3YXRjaCBldmVu dC4KLSAqIFRlbXBvcmFyeSBtZW1vcnkgYWxsb2NhdGlvbnMgYXJlIGRvbmUg d2l0aCBjdHguCi0gKi8KLXN0YXRpYyB2b2lkIGFkZF9ldmVudChzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKLQkJICAgICAgY29uc3Qgdm9pZCAqY3R4LAot CQkgICAgICBzdHJ1Y3Qgd2F0Y2ggKndhdGNoLAotCQkgICAgICBjb25zdCBj aGFyICpuYW1lKQotewotCS8qIERhdGEgdG8gc2VuZCAobm9kZVwwdG9rZW5c MCkuICovCi0JdW5zaWduZWQgaW50IGxlbjsKLQljaGFyICpkYXRhOwotCi0J bmFtZSA9IGdldF93YXRjaF9wYXRoKHdhdGNoLCBuYW1lKTsKLQotCWxlbiA9 IHN0cmxlbihuYW1lKSArIDEgKyBzdHJsZW4od2F0Y2gtPnRva2VuKSArIDE7 Ci0JLyogRG9uJ3QgdHJ5IHRvIHNlbmQgb3Zlci1sb25nIGV2ZW50cy4gKi8K LQlpZiAobGVuID4gWEVOU1RPUkVfUEFZTE9BRF9NQVgpCi0JCXJldHVybjsK LQotCWRhdGEgPSB0YWxsb2NfYXJyYXkoY3R4LCBjaGFyLCBsZW4pOwotCWlm ICghZGF0YSkKLQkJcmV0dXJuOwotCXN0cmNweShkYXRhLCBuYW1lKTsKLQlz dHJjcHkoZGF0YSArIHN0cmxlbihuYW1lKSArIDEsIHdhdGNoLT50b2tlbik7 Ci0Jc2VuZF9yZXBseShjb25uLCBYU19XQVRDSF9FVkVOVCwgZGF0YSwgbGVu KTsKLQl0YWxsb2NfZnJlZShkYXRhKTsKLX0KLQotLyoKICAqIENoZWNrIHBl cm1pc3Npb25zIG9mIGEgc3BlY2lmaWMgd2F0Y2ggdG8gZmlyZToKICAqIEVp dGhlciB0aGUgbm9kZSBpdHNlbGYgb3IgaXRzIHBhcmVudCBoYXZlIHRvIGJl IHJlYWRhYmxlIGJ5IHRoZSBjb25uZWN0aW9uCiAgKiB0aGUgd2F0Y2ggaGFz IGJlZW4gc2V0dXAgZm9yLiBJbiBjYXNlIGEgd2F0Y2ggZXZlbnQgaXMgY3Jl YXRlZCBkdWUgdG8KQEAgLTE5MCwxMCArMTYxLDE0IEBAIHZvaWQgZmlyZV93 YXRjaGVzKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpj dHgsIGNvbnN0IGNoYXIgKm5hbWUsCiAJCWxpc3RfZm9yX2VhY2hfZW50cnko d2F0Y2gsICZpLT53YXRjaGVzLCBsaXN0KSB7CiAJCQlpZiAoZXhhY3QpIHsK IAkJCQlpZiAoc3RyZXEobmFtZSwgd2F0Y2gtPm5vZGUpKQotCQkJCQlhZGRf ZXZlbnQoaSwgY3R4LCB3YXRjaCwgbmFtZSk7CisJCQkJCXNlbmRfZXZlbnQo aSwKKwkJCQkJCSAgIGdldF93YXRjaF9wYXRoKHdhdGNoLCBuYW1lKSwKKwkJ CQkJCSAgIHdhdGNoLT50b2tlbik7CiAJCQl9IGVsc2UgewogCQkJCWlmIChp c19jaGlsZChuYW1lLCB3YXRjaC0+bm9kZSkpCi0JCQkJCWFkZF9ldmVudChp LCBjdHgsIHdhdGNoLCBuYW1lKTsKKwkJCQkJc2VuZF9ldmVudChpLAorCQkJ CQkJICAgZ2V0X3dhdGNoX3BhdGgod2F0Y2gsIG5hbWUpLAorCQkJCQkJICAg d2F0Y2gtPnRva2VuKTsKIAkJCX0KIAkJfQogCX0KQEAgLTI5Miw3ICsyNjcs NyBAQCBpbnQgZG9fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlzZW5kX2Fjayhjb25uLCBYU19X QVRDSCk7CiAKIAkvKiBXZSBmaXJlIG9uY2UgdXAgZnJvbnQ6IHNpbXBsaWZp ZXMgY2xpZW50cyBhbmQgcmVzdGFydC4gKi8KLQlhZGRfZXZlbnQoY29ubiwg aW4sIHdhdGNoLCB3YXRjaC0+bm9kZSk7CisJc2VuZF9ldmVudChjb25uLCBn ZXRfd2F0Y2hfcGF0aCh3YXRjaCwgd2F0Y2gtPm5vZGUpLCB3YXRjaC0+dG9r ZW4pOwogCiAJcmV0dXJuIDA7CiB9Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-02.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-02.patch" Content-Transfer-Encoding: base64 RnJvbSA2YWYxNTUyNTI2MGRkZDhmNzhmNzUzMzhiMmNhOTdiNGY2ODE1ZGZi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBoZWxw ZXJzIHRvIGZyZWUgc3RydWN0IGJ1ZmZlcmVkX2RhdGEKCkFkZCB0d28gaGVs cGVycyBmb3IgZnJlZWluZyBzdHJ1Y3QgYnVmZmVyZWRfZGF0YTogZnJlZV9i dWZmZXJlZF9kYXRhKCkKZm9yIGZyZWVpbmcgb25lIGluc3RhbmNlIGFuZCBj b25uX2ZyZWVfYnVmZmVyZWRfZGF0YSgpIGZvciBmcmVlaW5nIGFsbAppbnN0 YW5jZXMgZm9yIGEgY29ubmVjdGlvbi4KClRoaXMgaXMgYXZvaWRpbmcgZHVw bGljYXRlZCBjb2RlIGFuZCB3aWxsIGhlbHAgbGF0ZXIgd2hlbiBtb3JlIGFj dGlvbnMKYXJlIG5lZWRlZCB3aGVuIGZyZWVpbmcgYSBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQt Ynk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1v ZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3 ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggMDFkNGEyZTQ0 MGVjLi42NDk4YmY2MDM2NjYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYwpAQCAtMjExLDYgKzIxMSwyMSBAQCB2b2lkIHJlb3Blbl9s b2codm9pZCkKIAl9CiB9CiAKK3N0YXRpYyB2b2lkIGZyZWVfYnVmZmVyZWRf ZGF0YShzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqb3V0LAorCQkJICAgICAgIHN0 cnVjdCBjb25uZWN0aW9uICpjb25uKQoreworCWxpc3RfZGVsKCZvdXQtPmxp c3QpOworCXRhbGxvY19mcmVlKG91dCk7Cit9CisKK3ZvaWQgY29ubl9mcmVl X2J1ZmZlcmVkX2RhdGEoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCit7CisJ c3RydWN0IGJ1ZmZlcmVkX2RhdGEgKm91dDsKKworCXdoaWxlICgob3V0ID0g bGlzdF90b3AoJmNvbm4tPm91dF9saXN0LCBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSwgbGlzdCkpKQorCQlmcmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBjb25uKTsK K30KKwogc3RhdGljIGJvb2wgd3JpdGVfbWVzc2FnZXMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pCiB7CiAJaW50IHJldDsKQEAgLTI1NCw4ICsyNjksNyBA QCBzdGF0aWMgYm9vbCB3cml0ZV9tZXNzYWdlcyhzdHJ1Y3QgY29ubmVjdGlv biAqY29ubikKIAogCXRyYWNlX2lvKGNvbm4sIG91dCwgMSk7CiAKLQlsaXN0 X2RlbCgmb3V0LT5saXN0KTsKLQl0YWxsb2NfZnJlZShvdXQpOworCWZyZWVf YnVmZmVyZWRfZGF0YShvdXQsIGNvbm4pOwogCiAJcmV0dXJuIHRydWU7CiB9 CkBAIC0xNDcyLDE4ICsxNDg2LDEyIEBAIHN0YXRpYyBzdHJ1Y3QgewogICov CiBzdGF0aWMgdm9pZCBpZ25vcmVfY29ubmVjdGlvbihzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubikKIHsKLQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqb3V0LCAq dG1wOwotCiAJdHJhY2UoIkNPTk4gJXAgaWdub3JlZFxuIiwgY29ubik7CiAK IAljb25uLT5pc19pZ25vcmVkID0gdHJ1ZTsKIAljb25uX2RlbGV0ZV9hbGxf d2F0Y2hlcyhjb25uKTsKIAljb25uX2RlbGV0ZV9hbGxfdHJhbnNhY3Rpb25z KGNvbm4pOwotCi0JbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKG91dCwgdG1w LCAmY29ubi0+b3V0X2xpc3QsIGxpc3QpIHsKLQkJbGlzdF9kZWwoJm91dC0+ bGlzdCk7Ci0JCXRhbGxvY19mcmVlKG91dCk7Ci0JfQorCWNvbm5fZnJlZV9i dWZmZXJlZF9kYXRhKGNvbm4pOwogCiAJdGFsbG9jX2ZyZWUoY29ubi0+aW4p OwogCWNvbm4tPmluID0gTlVMTDsKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5oCmluZGV4IDM4ZDk3ZmEwODFhNi4uMGJhNWI3ODNkNGQxIDEw MDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCisr KyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKQEAgLTI3MCw2 ICsyNzAsOCBAQCBpbnQgcmVtZW1iZXJfc3RyaW5nKHN0cnVjdCBoYXNodGFi bGUgKmhhc2gsIGNvbnN0IGNoYXIgKnN0cik7CiAKIHZvaWQgc2V0X3RkYl9r ZXkoY29uc3QgY2hhciAqbmFtZSwgVERCX0RBVEEgKmtleSk7CiAKK3ZvaWQg Y29ubl9mcmVlX2J1ZmZlcmVkX2RhdGEoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4pOworCiBjb25zdCBjaGFyICpkdW1wX3N0YXRlX2dsb2JhbChGSUxFICpm cCk7CiBjb25zdCBjaGFyICpkdW1wX3N0YXRlX2J1ZmZlcmVkX2RhdGEoRklM RSAqZnAsIGNvbnN0IHN0cnVjdCBjb25uZWN0aW9uICpjLAogCQkJCSAgICAg Y29uc3Qgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCmRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfZG9tYWluLmMKaW5kZXggM2Q0ZDA2NDlhMjQzLi43 MmE1Y2QzYjlhYWYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9kb21haW4uYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmMKQEAgLTQxNywxNSArNDE3LDEwIEBAIHN0YXRpYyBzdHJ1Y3Qg ZG9tYWluICpmaW5kX2RvbWFpbl9ieV9kb21pZCh1bnNpZ25lZCBpbnQgZG9t aWQpCiBzdGF0aWMgdm9pZCBkb21haW5fY29ubl9yZXNldChzdHJ1Y3QgZG9t YWluICpkb21haW4pCiB7CiAJc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4gPSBk b21haW4tPmNvbm47Ci0Jc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKm91dDsKIAog CWNvbm5fZGVsZXRlX2FsbF93YXRjaGVzKGNvbm4pOwogCWNvbm5fZGVsZXRl X2FsbF90cmFuc2FjdGlvbnMoY29ubik7Ci0KLQl3aGlsZSAoKG91dCA9IGxp c3RfdG9wKCZjb25uLT5vdXRfbGlzdCwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEs IGxpc3QpKSkgewotCQlsaXN0X2RlbCgmb3V0LT5saXN0KTsKLQkJdGFsbG9j X2ZyZWUob3V0KTsKLQl9CisJY29ubl9mcmVlX2J1ZmZlcmVkX2RhdGEoY29u bik7CiAKIAl0YWxsb2NfZnJlZShjb25uLT5pbik7CiAK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-03.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-03.patch" Content-Transfer-Encoding: base64 RnJvbSBjZGMzNzQ3Njc2YjFlNWVhNzI2NzI5Zjg4NjUwMzFiZjBmNzY0Nzc4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHJlZHVjZSBu dW1iZXIgb2Ygd2F0Y2ggZXZlbnRzCgpXaGVuIHJlbW92aW5nIGEgd2F0Y2hl ZCBub2RlIG91dHNpZGUgb2YgYSB0cmFuc2FjdGlvbiwgdHdvIHdhdGNoIGV2 ZW50cwphcmUgYmVpbmcgcHJvZHVjZWQgaW5zdGVhZCBvZiBqdXN0IGEgc2lu Z2xlIG9uZS4KCldoZW4gZmluYWxpemluZyBhIHRyYW5zYWN0aW9uIHdhdGNo IGV2ZW50cyBjYW4gYmUgZ2VuZXJhdGVkIGZvciBlYWNoCm5vZGUgd2hpY2gg aXMgYmVpbmcgbW9kaWZpZWQsIGV2ZW4gaWYgb3V0c2lkZSBhIHRyYW5zYWN0 aW9uIHN1Y2gKbW9kaWZpY2F0aW9ucyBtaWdodCBub3QgaGF2ZSByZXN1bHRl ZCBpbiBhIHdhdGNoIGV2ZW50LgoKVGhpcyBoYXBwZW5zIGUuZy46CgotIGZv ciBub2RlcyB3aGljaCBhcmUgb25seSBtb2RpZmllZCBkdWUgdG8gYWRkZWQv cmVtb3ZlZCBjaGlsZCBlbnRyaWVzCi0gZm9yIG5vZGVzIGJlaW5nIHJlbW92 ZWQgb3IgY3JlYXRlZCBpbXBsaWNpdGx5IChlLmcuIGNyZWF0aW9uIG9mIGEv Yi9jCiAgaXMgaW1wbGljaXRseSBjcmVhdGluZyBhL2IsIHJlc3VsdGluZyBp biB3YXRjaCBldmVudHMgZm9yIGEsIGEvYiBhbmQKICBhL2IvYyBpbnN0ZWFk IG9mIGEvYi9jIG9ubHkpCgpBdm9pZCB0aGVzZSBhZGRpdGlvbmFsIHdhdGNo IGV2ZW50cywgaW4gb3JkZXIgdG8gcmVkdWNlIHRoZSBuZWVkZWQKbWVtb3J5 IGluc2lkZSBYZW5zdG9yZSBmb3IgcXVldWVpbmcgdGhlbS4KClRoaXMgaXMg YmVpbmcgYWNoaWV2ZWQgYnkgYWRkaW5nIGV2ZW50IGZsYWdzIHRvIHN0cnVj dCBhY2Nlc3NlZF9ub2RlCnNwZWNpZnlpbmcgd2hldGhlciBhbiBldmVudCBz aG91bGQgYmUgdHJpZ2dlcmVkLCBhbmQgd2hldGhlciBpdCBzaG91bGQKYmUg YW4gZXhhY3QgbWF0Y2ggb2YgdGhlIG1vZGlmaWVkIHBhdGguIEJvdGggZmxh Z3MgY2FuIGJlIHNldCBmcm9tCmZpcmVfd2F0Y2hlcygpIGluc3RlYWQgb2Yg aW1wbHlpbmcgdGhlbSBvbmx5LgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYu CgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNv bT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwppbmRl eCA2NDk4YmY2MDM2NjYuLjUxNTdhNzUyN2Y1OCAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0xMjYxLDcgKzEyNjEsNyBAQCBz dGF0aWMgdm9pZCBkZWxldGVfY2hpbGQoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sCiB9CiAKIHN0YXRpYyBpbnQgZGVsZXRlX25vZGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKLQkJICAgICAgIHN0cnVj dCBub2RlICpwYXJlbnQsIHN0cnVjdCBub2RlICpub2RlKQorCQkgICAgICAg c3RydWN0IG5vZGUgKnBhcmVudCwgc3RydWN0IG5vZGUgKm5vZGUsIGJvb2wg d2F0Y2hfZXhhY3QpCiB7CiAJY2hhciAqbmFtZTsKIApAQCAtMTI3Myw3ICsx MjczLDcgQEAgc3RhdGljIGludCBkZWxldGVfbm9kZShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCQkJCSAgICAgICBub2Rl LT5jaGlsZHJlbik7CiAJCWNoaWxkID0gbmFtZSA/IHJlYWRfbm9kZShjb25u LCBub2RlLCBuYW1lKSA6IE5VTEw7CiAJCWlmIChjaGlsZCkgewotCQkJaWYg KGRlbGV0ZV9ub2RlKGNvbm4sIGN0eCwgbm9kZSwgY2hpbGQpKQorCQkJaWYg KGRlbGV0ZV9ub2RlKGNvbm4sIGN0eCwgbm9kZSwgY2hpbGQsIHRydWUpKQog CQkJCXJldHVybiBlcnJubzsKIAkJfSBlbHNlIHsKIAkJCXRyYWNlKCJkZWxl dGVfbm9kZTogRXJyb3IgZGVsZXRpbmcgY2hpbGQgJyVzLyVzJyFcbiIsCkBA IC0xMjg1LDcgKzEyODUsMTIgQEAgc3RhdGljIGludCBkZWxldGVfbm9kZShz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCQl0 YWxsb2NfZnJlZShuYW1lKTsKIAl9CiAKLQlmaXJlX3dhdGNoZXMoY29ubiwg Y3R4LCBub2RlLT5uYW1lLCBub2RlLCB0cnVlLCBOVUxMKTsKKwkvKgorCSAq IEZpcmUgdGhlIHdhdGNoZXMgbm93LCB3aGVuIHdlIGNhbiBzdGlsbCBzZWUg dGhlIG5vZGUgcGVybWlzc2lvbnMuCisJICogVGhpcyBmaW5lIGFzIHdlIGFy ZSBzaW5nbGUgdGhyZWFkZWQgYW5kIHRoZSBuZXh0IHBvc3NpYmxlIHJlYWQg d2lsbAorCSAqIGJlIGhhbmRsZWQgb25seSBhZnRlciB0aGUgbm9kZSBoYXMg YmVlbiByZWFsbHkgcmVtb3ZlZC4KKwkgKi8KKwlmaXJlX3dhdGNoZXMoY29u biwgY3R4LCBub2RlLT5uYW1lLCBub2RlLCB3YXRjaF9leGFjdCwgTlVMTCk7 CiAJZGVsZXRlX25vZGVfc2luZ2xlKGNvbm4sIG5vZGUpOwogCWRlbGV0ZV9j aGlsZChjb25uLCBwYXJlbnQsIGJhc2VuYW1lKG5vZGUtPm5hbWUpKTsKIAl0 YWxsb2NfZnJlZShub2RlKTsKQEAgLTEzMTEsMTMgKzEzMTYsNyBAQCBzdGF0 aWMgaW50IF9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9p ZCAqY3R4LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIAkJcmV0dXJuIChlcnJubyA9 PSBFTk9NRU0pID8gRU5PTUVNIDogRUlOVkFMOwogCW5vZGUtPnBhcmVudCA9 IHBhcmVudDsKIAotCS8qCi0JICogRmlyZSB0aGUgd2F0Y2hlcyBub3csIHdo ZW4gd2UgY2FuIHN0aWxsIHNlZSB0aGUgbm9kZSBwZXJtaXNzaW9ucy4KLQkg KiBUaGlzIGZpbmUgYXMgd2UgYXJlIHNpbmdsZSB0aHJlYWRlZCBhbmQgdGhl IG5leHQgcG9zc2libGUgcmVhZCB3aWxsCi0JICogYmUgaGFuZGxlZCBvbmx5 IGFmdGVyIHRoZSBub2RlIGhhcyBiZWVuIHJlYWxseSByZW1vdmVkLgotCSAq LwotCWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5hbWUsIG5vZGUsIGZhbHNl LCBOVUxMKTsKLQlyZXR1cm4gZGVsZXRlX25vZGUoY29ubiwgY3R4LCBwYXJl bnQsIG5vZGUpOworCXJldHVybiBkZWxldGVfbm9kZShjb25uLCBjdHgsIHBh cmVudCwgbm9kZSwgZmFsc2UpOwogfQogCiAKZGlmZiAtLWdpdCBhL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKaW5kZXggZmFmNmM5MzBl NDJhLi41NDQzMjkwN2ZjNzYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCisrKyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCkBAIC0xMzAsNiArMTMwLDEwIEBA IHN0cnVjdCBhY2Nlc3NlZF9ub2RlCiAKIAkvKiBUcmFuc2FjdGlvbiBub2Rl IGluIGRhdGEgYmFzZT8gKi8KIAlib29sIHRhX25vZGU7CisKKwkvKiBXYXRj aCBldmVudCBmbGFncy4gKi8KKwlib29sIGZpcmVfd2F0Y2g7CisJYm9vbCB3 YXRjaF9leGFjdDsKIH07CiAKIHN0cnVjdCBjaGFuZ2VkX2RvbWFpbgpAQCAt MzI0LDYgKzMyOCwyOSBAQCBpbnQgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAogfQogCiAvKgorICog QSB3YXRjaCBldmVudCBzaG91bGQgYmUgZmlyZWQgZm9yIGEgbm9kZSBtb2Rp ZmllZCBpbnNpZGUgYSB0cmFuc2FjdGlvbi4KKyAqIFNldCB0aGUgY29ycmVz cG9uZGluZyBpbmZvcm1hdGlvbi4gQSBub24tZXhhY3QgZXZlbnQgaXMgcmVw bGFjaW5nIGFuIGV4YWN0CisgKiBvbmUsIGJ1dCBub3QgdGhlIG90aGVyIHdh eSByb3VuZC4KKyAqLwordm9pZCBxdWV1ZV93YXRjaGVzKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpuYW1lLCBib29sIHdhdGNoX2V4 YWN0KQoreworCXN0cnVjdCBhY2Nlc3NlZF9ub2RlICppOworCisJaSA9IGZp bmRfYWNjZXNzZWRfbm9kZShjb25uLT50cmFuc2FjdGlvbiwgbmFtZSk7CisJ aWYgKCFpKSB7CisJCWNvbm4tPnRyYW5zYWN0aW9uLT5mYWlsID0gdHJ1ZTsK KwkJcmV0dXJuOworCX0KKworCWlmICghaS0+ZmlyZV93YXRjaCkgeworCQlp LT5maXJlX3dhdGNoID0gdHJ1ZTsKKwkJaS0+d2F0Y2hfZXhhY3QgPSB3YXRj aF9leGFjdDsKKwl9IGVsc2UgaWYgKCF3YXRjaF9leGFjdCkgeworCQlpLT53 YXRjaF9leGFjdCA9IGZhbHNlOworCX0KK30KKworLyoKICAqIEZpbmFsaXpl IHRyYW5zYWN0aW9uOgogICogV2FsayB0aHJvdWdoIGFjY2Vzc2VkIG5vZGVz IGFuZCBjaGVjayBnZW5lcmF0aW9uIGFnYWluc3QgZ2xvYmFsIGRhdGEuCiAg KiBJZiBhbGwgZW50cmllcyBtYXRjaCwgcmVhZCB0aGUgdHJhbnNhY3Rpb24g ZW50cmllcyBhbmQgd3JpdGUgdGhlbSB3aXRob3V0CkBAIC0zNzcsMTUgKzQw NCwxNSBAQCBzdGF0aWMgaW50IGZpbmFsaXplX3RyYW5zYWN0aW9uKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAogCQkJCXJldCA9IHRkYl9zdG9yZSh0ZGJf Y3R4LCBrZXksIGRhdGEsCiAJCQkJCQlUREJfUkVQTEFDRSk7CiAJCQkJdGFs bG9jX2ZyZWUoZGF0YS5kcHRyKTsKLQkJCQlpZiAocmV0KQotCQkJCQlnb3Rv IGVycjsKLQkJCQlmaXJlX3dhdGNoZXMoY29ubiwgdHJhbnMsIGktPm5vZGUs IE5VTEwsIGZhbHNlLAotCQkJCQkgICAgIGktPnBlcm1zLnAgPyAmaS0+cGVy bXMgOiBOVUxMKTsKIAkJCX0gZWxzZSB7Ci0JCQkJZmlyZV93YXRjaGVzKGNv bm4sIHRyYW5zLCBpLT5ub2RlLCBOVUxMLCBmYWxzZSwKKwkJCQlyZXQgPSB0 ZGJfZGVsZXRlKHRkYl9jdHgsIGtleSk7CisJCQl9CisJCQlpZiAocmV0KQor CQkJCWdvdG8gZXJyOworCQkJaWYgKGktPmZpcmVfd2F0Y2gpIHsKKwkJCQlm aXJlX3dhdGNoZXMoY29ubiwgdHJhbnMsIGktPm5vZGUsIE5VTEwsCisJCQkJ CSAgICAgaS0+d2F0Y2hfZXhhY3QsCiAJCQkJCSAgICAgaS0+cGVybXMucCA/ ICZpLT5wZXJtcyA6IE5VTEwpOwotCQkJCWlmICh0ZGJfZGVsZXRlKHRkYl9j dHgsIGtleSkpCi0JCQkJCWdvdG8gZXJyOwogCQkJfQogCQl9CiAKZGlmZiAt LWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5o IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKaW5k ZXggMTQwNjI3MzBlM2M5Li4wMDkzY2FjODA3ZTMgMTAwNjQ0Ci0tLSBhL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCisrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCkBAIC00Miw2 ICs0Miw5IEBAIHZvaWQgdHJhbnNhY3Rpb25fZW50cnlfZGVjKHN0cnVjdCB0 cmFuc2FjdGlvbiAqdHJhbnMsIHVuc2lnbmVkIGludCBkb21pZCk7CiBpbnQg YWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlLAogICAgICAgICAgICAgICAgIGVudW0gbm9kZV9hY2Nlc3Nf dHlwZSB0eXBlLCBUREJfREFUQSAqa2V5KTsKIAorLyogUXVldWUgd2F0Y2hl cyBmb3IgYSBtb2RpZmllZCBub2RlLiAqLwordm9pZCBxdWV1ZV93YXRjaGVz KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpuYW1lLCBi b29sIHdhdGNoX2V4YWN0KTsKKwogLyogUHJlcGVuZCB0aGUgdHJhbnNhY3Rp b24gdG8gbmFtZSBpZiBhcHByb3ByaWF0ZS4gKi8KIGludCB0cmFuc2FjdGlv bl9wcmVwZW5kKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFy ICpuYW1lLAogICAgICAgICAgICAgICAgICAgICAgICAgVERCX0RBVEEgKmtl eSk7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0 Y2guYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCmluZGV4 IGExMTZmOTY3ZGM2Ni4uYmM2ZDgzMzAyOGEzIDEwMDY0NAotLS0gYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfd2F0Y2guYwpAQCAtMjksNiArMjksNyBAQAogI2lu Y2x1ZGUgInhlbnN0b3JlX2xpYi5oIgogI2luY2x1ZGUgInV0aWxzLmgiCiAj aW5jbHVkZSAieGVuc3RvcmVkX2RvbWFpbi5oIgorI2luY2x1ZGUgInhlbnN0 b3JlZF90cmFuc2FjdGlvbi5oIgogCiBleHRlcm4gaW50IHF1b3RhX25iX3dh dGNoX3Blcl9kb21haW47CiAKQEAgLTE0Myw5ICsxNDQsMTEgQEAgdm9pZCBm aXJlX3dhdGNoZXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZv aWQgKmN0eCwgY29uc3QgY2hhciAqbmFtZSwKIAlzdHJ1Y3QgY29ubmVjdGlv biAqaTsKIAlzdHJ1Y3Qgd2F0Y2ggKndhdGNoOwogCi0JLyogRHVyaW5nIHRy YW5zYWN0aW9ucywgZG9uJ3QgZmlyZSB3YXRjaGVzLiAqLwotCWlmIChjb25u ICYmIGNvbm4tPnRyYW5zYWN0aW9uKQorCS8qIER1cmluZyB0cmFuc2FjdGlv bnMsIGRvbid0IGZpcmUgd2F0Y2hlcywgYnV0IHF1ZXVlIHRoZW0uICovCisJ aWYgKGNvbm4gJiYgY29ubi0+dHJhbnNhY3Rpb24pIHsKKwkJcXVldWVfd2F0 Y2hlcyhjb25uLCBuYW1lLCBleGFjdCk7CiAJCXJldHVybjsKKwl9CiAKIAkv KiBDcmVhdGUgYW4gZXZlbnQgZm9yIGVhY2ggd2F0Y2guICovCiAJbGlzdF9m b3JfZWFjaF9lbnRyeShpLCAmY29ubmVjdGlvbnMsIGxpc3QpIHsK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-04.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-04.patch" Content-Transfer-Encoding: base64 RnJvbSA0M2RkN2U0ZDM5NTJlNGYyMTAwZTZmMDRkZTJiOWZlYmIyYzVjNTBh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxldCB1bnJl YWQgd2F0Y2ggZXZlbnRzIHRpbWUgb3V0CgpBIGZ1dHVyZSBtb2RpZmljYXRp b24gd2lsbCBsaW1pdCB0aGUgbnVtYmVyIG9mIG91dHN0YW5kaW5nIHJlcXVl c3RzCmZvciBhIGRvbWFpbiwgd2hlcmUgIm91dHN0YW5kaW5nIiBtZWFucyB0 aGF0IHRoZSByZXNwb25zZSBvZiB0aGUKcmVxdWVzdCBvciBhbnkgcmVzdWx0 aW5nIHdhdGNoIGV2ZW50IGhhc24ndCBiZWVuIGNvbnN1bWVkIHlldC4KCklu IG9yZGVyIHRvIGF2b2lkIGEgbWFsaWNpb3VzIGd1ZXN0IGJlaW5nIGNhcGFi bGUgdG8gYmxvY2sgb3RoZXIgZ3Vlc3RzCmJ5IG5vdCByZWFkaW5nIHdhdGNo IGV2ZW50cywgYWRkIGEgdGltZW91dCBmb3Igd2F0Y2ggZXZlbnRzLiBJbiBj YXNlIGEKd2F0Y2ggZXZlbnQgaGFzbid0IGJlZW4gY29uc3VtZWQgYWZ0ZXIg dGhpcyB0aW1lb3V0LCBpdCBpcyBiZWluZwpkZWxldGVkLiBTZXQgdGhlIGRl ZmF1bHQgdGltZW91dCB0byAyMCBzZWNvbmRzIChhIHJhbmRvbSB2YWx1ZSBi ZWluZwpub3QgdG9vIGhpZ2gpLgoKSW4gb3JkZXIgdG8gc3VwcG9ydCB0byBz cGVjaWZ5IG90aGVyIHRpbWVvdXQgdmFsdWVzIGluIGZ1dHVyZSwgdXNlIGEK Z2VuZXJpYyBjb21tYW5kIGxpbmUgb3B0aW9uIGZvciB0aGF0IHB1cnBvc2U6 CgotLXRpbWVvdXR8LXcgd2F0Y2gtZXZlbnQ9PHNlY29uZHM+CgpUaGlzIGlz IHBhcnQgb2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzExLgoKUmVwb3J0ZWQt Ynk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1v ZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3 ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggNTE1N2E3NTI3 ZjU4Li5lZTMzOTZmZWZhOTQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYwpAQCAtMTA4LDYgKzEwOCw4IEBAIGludCBxdW90YV9tYXhf dHJhbnNhY3Rpb24gPSAxMDsKIGludCBxdW90YV9uYl9wZXJtc19wZXJfbm9k ZSA9IDU7CiBpbnQgcXVvdGFfbWF4X3BhdGhfbGVuID0gWEVOU1RPUkVfUkVM X1BBVEhfTUFYOwogCit1bnNpZ25lZCBpbnQgdGltZW91dF93YXRjaF9ldmVu dF9tc2VjID0gMjAwMDA7CisKIHZvaWQgdHJhY2UoY29uc3QgY2hhciAqZm10 LCAuLi4pCiB7CiAJdmFfbGlzdCBhcmdsaXN0OwpAQCAtMjExLDE5ICsyMTMs OTIgQEAgdm9pZCByZW9wZW5fbG9nKHZvaWQpCiAJfQogfQogCitzdGF0aWMg dWludDY0X3QgZ2V0X25vd19tc2VjKHZvaWQpCit7CisJc3RydWN0IHRpbWVz cGVjIG5vd190czsKKworCWlmIChjbG9ja19nZXR0aW1lKENMT0NLX01PTk9U T05JQywgJm5vd190cykpCisJCWJhcmZfcGVycm9yKCJDb3VsZCBub3QgZmlu ZCB0aW1lIChjbG9ja19nZXR0aW1lIGZhaWxlZCkiKTsKKworCXJldHVybiBu b3dfdHMudHZfc2VjICogMTAwMCArIG5vd190cy50dl9uc2VjIC8gMTAwMDAw MDsKK30KKwogc3RhdGljIHZvaWQgZnJlZV9idWZmZXJlZF9kYXRhKHN0cnVj dCBidWZmZXJlZF9kYXRhICpvdXQsCiAJCQkgICAgICAgc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pCiB7CisJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKnJlcTsK KwogCWxpc3RfZGVsKCZvdXQtPmxpc3QpOworCisJLyoKKwkgKiBVcGRhdGUg Y29ubi0+dGltZW91dF9tc2VjIHdpdGggdGhlIG5leHQgZm91bmQgdGltZW91 dCB2YWx1ZSBpbiB0aGUKKwkgKiBxdWV1ZWQgcGVuZGluZyByZXF1ZXN0cy4K KwkgKi8KKwlpZiAob3V0LT50aW1lb3V0X21zZWMpIHsKKwkJY29ubi0+dGlt ZW91dF9tc2VjID0gMDsKKwkJbGlzdF9mb3JfZWFjaF9lbnRyeShyZXEsICZj b25uLT5vdXRfbGlzdCwgbGlzdCkgeworCQkJaWYgKHJlcS0+dGltZW91dF9t c2VjKSB7CisJCQkJY29ubi0+dGltZW91dF9tc2VjID0gcmVxLT50aW1lb3V0 X21zZWM7CisJCQkJYnJlYWs7CisJCQl9CisJCX0KKwl9CisKIAl0YWxsb2Nf ZnJlZShvdXQpOwogfQogCitzdGF0aWMgdm9pZCBjaGVja19ldmVudF90aW1l b3V0KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCB1aW50NjRfdCBtc2VjcywK KwkJCQlpbnQgKnB0aW1lb3V0KQoreworCXVpbnQ2NF90IGRlbHRhOworCXN0 cnVjdCBidWZmZXJlZF9kYXRhICpvdXQsICp0bXA7CisKKwlpZiAoIWNvbm4t PnRpbWVvdXRfbXNlYykKKwkJcmV0dXJuOworCisJZGVsdGEgPSBjb25uLT50 aW1lb3V0X21zZWMgLSBtc2VjczsKKwlpZiAoY29ubi0+dGltZW91dF9tc2Vj IDw9IG1zZWNzKSB7CisJCWRlbHRhID0gMDsKKwkJbGlzdF9mb3JfZWFjaF9l bnRyeV9zYWZlKG91dCwgdG1wLCAmY29ubi0+b3V0X2xpc3QsIGxpc3QpIHsK KwkJCS8qCisJCQkgKiBPbmx5IGxvb2sgYXQgYnVmZmVycyB3aXRoIHRpbWVv dXQgYW5kIG5vIGRhdGEKKwkJCSAqIGFscmVhZHkgd3JpdHRlbiB0byB0aGUg cmluZy4KKwkJCSAqLworCQkJaWYgKG91dC0+dGltZW91dF9tc2VjICYmIG91 dC0+aW5oZHIgJiYgIW91dC0+dXNlZCkgeworCQkJCWlmIChvdXQtPnRpbWVv dXRfbXNlYyA+IG1zZWNzKSB7CisJCQkJCWNvbm4tPnRpbWVvdXRfbXNlYyA9 IG91dC0+dGltZW91dF9tc2VjOworCQkJCQlkZWx0YSA9IGNvbm4tPnRpbWVv dXRfbXNlYyAtIG1zZWNzOworCQkJCQlicmVhazsKKwkJCQl9CisKKwkJCQkv KgorCQkJCSAqIEZyZWUgb3V0IHdpdGhvdXQgdXBkYXRpbmcgY29ubi0+dGlt ZW91dF9tc2VjLAorCQkJCSAqIGFzIHRoZSB1cGRhdGUgaXMgZG9uZSBpbiB0 aGlzIGxvb3AgYWxyZWFkeS4KKwkJCQkgKi8KKwkJCQlvdXQtPnRpbWVvdXRf bXNlYyA9IDA7CisJCQkJdHJhY2UoIndhdGNoIGV2ZW50IHBhdGggJXMgZm9y IGRvbWFpbiAldSB0aW1lZCBvdXRcbiIsCisJCQkJICAgICAgb3V0LT5idWZm ZXIsIGNvbm4tPmlkKTsKKwkJCQlmcmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBj b25uKTsKKwkJCX0KKwkJfQorCQlpZiAoIWRlbHRhKSB7CisJCQljb25uLT50 aW1lb3V0X21zZWMgPSAwOworCQkJcmV0dXJuOworCQl9CisJfQorCisJaWYg KCpwdGltZW91dCA9PSAtMSB8fCAqcHRpbWVvdXQgPiBkZWx0YSkKKwkJKnB0 aW1lb3V0ID0gZGVsdGE7Cit9CisKIHZvaWQgY29ubl9mcmVlX2J1ZmZlcmVk X2RhdGEoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCiB7CiAJc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKm91dDsKIAogCXdoaWxlICgob3V0ID0gbGlzdF90b3Ao JmNvbm4tPm91dF9saXN0LCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSwgbGlzdCkp KQogCQlmcmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBjb25uKTsKKworCWNvbm4t PnRpbWVvdXRfbXNlYyA9IDA7CiB9CiAKIHN0YXRpYyBib29sIHdyaXRlX21l c3NhZ2VzKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQpAQCAtMzgyLDYgKzQ1 Nyw3IEBAIHN0YXRpYyB2b2lkIGluaXRpYWxpemVfZmRzKGludCAqcF9zb2Nr X3BvbGxmZF9pZHgsIGludCAqcHRpbWVvdXQpCiB7CiAJc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm47CiAJc3RydWN0IHdybF90aW1lc3RhbXB0IG5vdzsKKwl1 aW50NjRfdCBtc2VjczsKIAogCWlmIChmZHMpCiAJCW1lbXNldChmZHMsIDAs IHNpemVvZihzdHJ1Y3QgcG9sbGZkKSAqIGN1cnJlbnRfYXJyYXlfc2l6ZSk7 CkBAIC00MDIsMTAgKzQ3OCwxMiBAQCBzdGF0aWMgdm9pZCBpbml0aWFsaXpl X2ZkcyhpbnQgKnBfc29ja19wb2xsZmRfaWR4LCBpbnQgKnB0aW1lb3V0KQog CiAJd3JsX2dldHRpbWVfbm93KCZub3cpOwogCXdybF9sb2dfcGVyaW9kaWMo bm93KTsKKwltc2VjcyA9IGdldF9ub3dfbXNlYygpOwogCiAJbGlzdF9mb3Jf ZWFjaF9lbnRyeShjb25uLCAmY29ubmVjdGlvbnMsIGxpc3QpIHsKIAkJaWYg KGNvbm4tPmRvbWFpbikgewogCQkJd3JsX2NoZWNrX3RpbWVvdXQoY29ubi0+ ZG9tYWluLCBub3csIHB0aW1lb3V0KTsKKwkJCWNoZWNrX2V2ZW50X3RpbWVv dXQoY29ubiwgbXNlY3MsIHB0aW1lb3V0KTsKIAkJCWlmIChkb21haW5fY2Fu X3JlYWQoY29ubikgfHwKIAkJCSAgICAoZG9tYWluX2Nhbl93cml0ZShjb25u KSAmJgogCQkJICAgICAhbGlzdF9lbXB0eSgmY29ubi0+b3V0X2xpc3QpKSkK QEAgLTc2MCw2ICs4MzgsNyBAQCB2b2lkIHNlbmRfcmVwbHkoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlLAog CQlyZXR1cm47CiAJYmRhdGEtPmluaGRyID0gdHJ1ZTsKIAliZGF0YS0+dXNl ZCA9IDA7CisJYmRhdGEtPnRpbWVvdXRfbXNlYyA9IDA7CiAKIAlpZiAobGVu IDw9IERFRkFVTFRfQlVGRkVSX1NJWkUpCiAJCWJkYXRhLT5idWZmZXIgPSBi ZGF0YS0+ZGVmYXVsdF9idWZmZXI7CkBAIC04MTEsNiArODkwLDEyIEBAIHZv aWQgc2VuZF9ldmVudChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qg Y2hhciAqcGF0aCwgY29uc3QgY2hhciAqdG9rZW4pCiAJYmRhdGEtPmhkci5t c2cudHlwZSA9IFhTX1dBVENIX0VWRU5UOwogCWJkYXRhLT5oZHIubXNnLmxl biA9IGxlbjsKIAorCWlmICh0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWMgJiYg ZG9tYWluX2lzX3VucHJpdmlsZWdlZChjb25uKSkgeworCQliZGF0YS0+dGlt ZW91dF9tc2VjID0gZ2V0X25vd19tc2VjKCkgKyB0aW1lb3V0X3dhdGNoX2V2 ZW50X21zZWM7CisJCWlmICghY29ubi0+dGltZW91dF9tc2VjKQorCQkJY29u bi0+dGltZW91dF9tc2VjID0gYmRhdGEtPnRpbWVvdXRfbXNlYzsKKwl9CisK IAkvKiBRdWV1ZSBmb3IgbGF0ZXIgdHJhbnNtaXNzaW9uLiAqLwogCWxpc3Rf YWRkX3RhaWwoJmJkYXRhLT5saXN0LCAmY29ubi0+b3V0X2xpc3QpOwogfQpA QCAtMjA5OSw2ICsyMTg0LDkgQEAgc3RhdGljIHZvaWQgdXNhZ2Uodm9pZCkK ICIgIC10LCAtLXRyYW5zYWN0aW9uIDxuYj4gIGxpbWl0IHRoZSBudW1iZXIg b2YgdHJhbnNhY3Rpb24gYWxsb3dlZCBwZXIgZG9tYWluLFxuIgogIiAgLUEs IC0tcGVybS1uYiA8bmI+ICAgICAgbGltaXQgdGhlIG51bWJlciBvZiBwZXJt aXNzaW9ucyBwZXIgbm9kZSxcbiIKICIgIC1NLCAtLXBhdGgtbWF4IDxjaGFy cz4gIGxpbWl0IHRoZSBhbGxvd2VkIFhlbnN0b3JlIG5vZGUgcGF0aCBsZW5n dGgsXG4iCisiICAtdywgLS10aW1lb3V0IDx3aGF0Pj08c2Vjb25kcz4gICBz ZXQgdGhlIHRpbWVvdXQgaW4gc2Vjb25kcyBmb3IgPHdoYXQ+LFxuIgorIiAg ICAgICAgICAgICAgICAgICAgICAgICAgYWxsb3dlZCB0aW1lb3V0IGNhbmRp ZGF0ZXMgYXJlOlxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgd2F0 Y2gtZXZlbnQ6IHRpbWUgYSB3YXRjaC1ldmVudCBpcyBrZXB0IHBlbmRpbmdc biIKICIgIC1SLCAtLW5vLXJlY292ZXJ5ICAgICAgIHRvIHJlcXVlc3QgdGhh dCBubyByZWNvdmVyeSBzaG91bGQgYmUgYXR0ZW1wdGVkIHdoZW5cbiIKICIg ICAgICAgICAgICAgICAgICAgICAgICAgIHRoZSBzdG9yZSBpcyBjb3JydXB0 ZWQgKGRlYnVnIG9ubHkpLFxuIgogIiAgLUksIC0taW50ZXJuYWwtZGIgICAg ICAgc3RvcmUgZGF0YWJhc2UgaW4gbWVtb3J5LCBub3Qgb24gZGlza1xuIgpA QCAtMjEyMSw2ICsyMjA5LDcgQEAgc3RhdGljIHN0cnVjdCBvcHRpb24gb3B0 aW9uc1tdID0gewogCXsgInRyYW5zYWN0aW9uIiwgMSwgTlVMTCwgJ3QnIH0s CiAJeyAicGVybS1uYiIsIDEsIE5VTEwsICdBJyB9LAogCXsgInBhdGgtbWF4 IiwgMSwgTlVMTCwgJ00nIH0sCisJeyAidGltZW91dCIsIDEsIE5VTEwsICd3 JyB9LAogCXsgIm5vLXJlY292ZXJ5IiwgMCwgTlVMTCwgJ1InIH0sCiAJeyAi aW50ZXJuYWwtZGIiLCAwLCBOVUxMLCAnSScgfSwKIAl7ICJ2ZXJib3NlIiwg MCwgTlVMTCwgJ1YnIH0sCkBAIC0yMTM1LDYgKzIyMjQsMzkgQEAgaW50IGRv bTBfZG9taWQgPSAwOwogaW50IGRvbTBfZXZlbnQgPSAwOwogaW50IHByaXZf ZG9taWQgPSAwOwogCitzdGF0aWMgaW50IGdldF9vcHR2YWxfaW50KGNvbnN0 IGNoYXIgKmFyZykKK3sKKwljaGFyICplbmQ7CisJbG9uZyB2YWw7CisKKwl2 YWwgPSBzdHJ0b2woYXJnLCAmZW5kLCAxMCk7CisJaWYgKCEqYXJnIHx8ICpl bmQgfHwgdmFsIDwgMCB8fCB2YWwgPiBJTlRfTUFYKQorCQliYXJmKCJpbnZh bGlkIHBhcmFtZXRlciB2YWx1ZSBcIiVzXCJcbiIsIGFyZyk7CisKKwlyZXR1 cm4gdmFsOworfQorCitzdGF0aWMgYm9vbCB3aGF0X21hdGNoZXMoY29uc3Qg Y2hhciAqYXJnLCBjb25zdCBjaGFyICp3aGF0KQoreworCXVuc2lnbmVkIGlu dCB3aGF0X2xlbiA9IHN0cmxlbih3aGF0KTsKKworCXJldHVybiAhc3RybmNt cChhcmcsIHdoYXQsIHdoYXRfbGVuKSAmJiBhcmdbd2hhdF9sZW5dID09ICc9 JzsKK30KKworc3RhdGljIHZvaWQgc2V0X3RpbWVvdXQoY29uc3QgY2hhciAq YXJnKQoreworCWNvbnN0IGNoYXIgKmVxID0gc3RyY2hyKGFyZywgJz0nKTsK KwlpbnQgdmFsOworCisJaWYgKCFlcSkKKwkJYmFyZigicXVvdGFzIG11c3Qg YmUgc3BlY2lmaWVkIHZpYSA8d2hhdD49PHNlY29uZHM+XG4iKTsKKwl2YWwg PSBnZXRfb3B0dmFsX2ludChlcSArIDEpOworCWlmICh3aGF0X21hdGNoZXMo YXJnLCAid2F0Y2gtZXZlbnQiKSkKKwkJdGltZW91dF93YXRjaF9ldmVudF9t c2VjID0gdmFsICogMTAwMDsKKwllbHNlCisJCWJhcmYoInVua25vd24gdGlt ZW91dCBcIiVzXCJcbiIsIGFyZyk7Cit9CisKIGludCBtYWluKGludCBhcmdj LCBjaGFyICphcmd2W10pCiB7CiAJaW50IG9wdDsKQEAgLTIxNDksNyArMjI3 MSw3IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAJb3Jp Z19hcmdjID0gYXJnYzsKIAlvcmlnX2FyZ3YgPSBhcmd2OwogCi0Jd2hpbGUg KChvcHQgPSBnZXRvcHRfbG9uZyhhcmdjLCBhcmd2LCAiREU6RjpITlBTOnQ6 QTpNOlQ6UlZXOlUiLCBvcHRpb25zLAorCXdoaWxlICgob3B0ID0gZ2V0b3B0 X2xvbmcoYXJnYywgYXJndiwgIkRFOkY6SE5QUzp0OkE6TTpUOlJWVzp3OlUi LCBvcHRpb25zLAogCQkJCSAgTlVMTCkpICE9IC0xKSB7CiAJCXN3aXRjaCAo b3B0KSB7CiAJCWNhc2UgJ0QnOgpAQCAtMjE5OCw2ICsyMzIwLDkgQEAgaW50 IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAkJCXF1b3RhX21heF9w YXRoX2xlbiA9IG1pbihYRU5TVE9SRV9SRUxfUEFUSF9NQVgsCiAJCQkJCQkg cXVvdGFfbWF4X3BhdGhfbGVuKTsKIAkJCWJyZWFrOworCQljYXNlICd3JzoK KwkJCXNldF90aW1lb3V0KG9wdGFyZyk7CisJCQlicmVhazsKIAkJY2FzZSAn ZSc6CiAJCQlkb20wX2V2ZW50ID0gc3RydG9sKG9wdGFyZywgTlVMTCwgMTAp OwogCQkJYnJlYWs7CkBAIC0yNjQyLDYgKzI3NjcsMTIgQEAgc3RhdGljIHZv aWQgYWRkX2J1ZmZlcmVkX2RhdGEoc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmJk YXRhLAogCQliYXJmKCJlcnJvciByZXN0b3JpbmcgYnVmZmVyZWQgZGF0YSIp OwogCiAJbWVtY3B5KGJkYXRhLT5idWZmZXIsIGRhdGEsIGxlbik7CisJaWYg KGJkYXRhLT5oZHIubXNnLnR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQgJiYgdGlt ZW91dF93YXRjaF9ldmVudF9tc2VjICYmCisJICAgIGRvbWFpbl9pc191bnBy aXZpbGVnZWQoY29ubikpIHsKKwkJYmRhdGEtPnRpbWVvdXRfbXNlYyA9IGdl dF9ub3dfbXNlYygpICsgdGltZW91dF93YXRjaF9ldmVudF9tc2VjOworCQlp ZiAoIWNvbm4tPnRpbWVvdXRfbXNlYykKKwkJCWNvbm4tPnRpbWVvdXRfbXNl YyA9IGJkYXRhLT50aW1lb3V0X21zZWM7CisJfQogCiAJLyogUXVldWUgZm9y IGxhdGVyIHRyYW5zbWlzc2lvbi4gKi8KIAlsaXN0X2FkZF90YWlsKCZiZGF0 YS0+bGlzdCwgJmNvbm4tPm91dF9saXN0KTsKZGlmZiAtLWdpdCBhL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmggYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfY29yZS5oCmluZGV4IDBiYTViNzgzZDRkMS4uMmRiNTc3OTI4 ZmM2IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29y ZS5oCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKQEAg LTI3LDYgKzI3LDcgQEAKICNpbmNsdWRlIDxkaXJlbnQuaD4KICNpbmNsdWRl IDxzdGRib29sLmg+CiAjaW5jbHVkZSA8c3RkaW50Lmg+CisjaW5jbHVkZSA8 dGltZS5oPgogI2luY2x1ZGUgPGVycm5vLmg+CiAKICNpbmNsdWRlICJ4ZW5z dG9yZV9saWIuaCIKQEAgLTY3LDYgKzY4LDggQEAgc3RydWN0IGJ1ZmZlcmVk X2RhdGEKIAkJY2hhciByYXdbc2l6ZW9mKHN0cnVjdCB4c2Rfc29ja21zZyld OwogCX0gaGRyOwogCisJdWludDY0X3QgdGltZW91dF9tc2VjOworCiAJLyog VGhlIGFjdHVhbCBkYXRhLiAqLwogCWNoYXIgKmJ1ZmZlcjsKIAljaGFyIGRl ZmF1bHRfYnVmZmVyW0RFRkFVTFRfQlVGRkVSX1NJWkVdOwpAQCAtMTEwLDYg KzExMyw3IEBAIHN0cnVjdCBjb25uZWN0aW9uCiAKIAkvKiBCdWZmZXJlZCBv dXRwdXQgZGF0YSAqLwogCXN0cnVjdCBsaXN0X2hlYWQgb3V0X2xpc3Q7CisJ dWludDY0X3QgdGltZW91dF9tc2VjOwogCiAJLyogVHJhbnNhY3Rpb24gY29u dGV4dCBmb3IgY3VycmVudCByZXF1ZXN0IChOVUxMIGlmIG5vbmUpLiAqLwog CXN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnNhY3Rpb247CkBAIC0yMzcsNiAr MjQxLDggQEAgZXh0ZXJuIGludCBkb20wX2V2ZW50OwogZXh0ZXJuIGludCBw cml2X2RvbWlkOwogZXh0ZXJuIGludCBxdW90YV9uYl9lbnRyeV9wZXJfZG9t YWluOwogCitleHRlcm4gdW5zaWduZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZl bnRfbXNlYzsKKwogLyogTWFwIHRoZSBrZXJuZWwncyB4ZW5zdG9yZSBwYWdl LiAqLwogdm9pZCAqeGVuYnVzX21hcCh2b2lkKTsKIHZvaWQgdW5tYXBfeGVu YnVzKHZvaWQgKmludGVyZmFjZSk7Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-05.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-05.patch" Content-Transfer-Encoding: base64 RnJvbSA0YmZjOGIyY2YyNWYyYzQxOGRjMmM4YTExY2FiNmNkMTJkNDI4YjYx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxpbWl0IG91 dHN0YW5kaW5nIHJlcXVlc3RzCgpBZGQgYW5vdGhlciBxdW90YSBmb3IgbGlt aXRpbmcgdGhlIG51bWJlciBvZiBvdXRzdGFuZGluZyByZXF1ZXN0cyBvZiBh Cmd1ZXN0LiBBcyB0aGUgd2F5IHRvIHNwZWNpZnkgcXVvdGFzIG9uIHRoZSBj b21tYW5kIGxpbmUgaXMgYmVjb21pbmcKcmF0aGVyIG5hc3R5LCBzd2l0Y2gg dG8gYSBuZXcgc2NoZW1lIHVzaW5nIFstLXF1b3RhfC1RXSA8d2hhdD49PHZh bD4KYWxsb3dpbmcgdG8gYWRkIG1vcmUgcXVvdGFzIGluIGZ1dHVyZSBlYXNp bHkuCgpTZXQgdGhlIGRlZmF1bHQgdmFsdWUgdG8gMjAgKGJhc2ljYWxseSBh IHJhbmRvbSB2YWx1ZSBub3Qgc2VlbWluZyB0bwpiZSB0b28gaGlnaCBvciB0 b28gbG93KS4KCkEgcmVxdWVzdCBpcyBzYWlkIHRvIGJlIG91dHN0YW5kaW5n IGlmIGFueSBtZXNzYWdlIGdlbmVyYXRlZCBieSB0aGlzCnJlcXVlc3QgKHRo ZSBkaXJlY3QgcmVzcG9uc2UgcGx1cyBwb3RlbnRpYWwgd2F0Y2ggZXZlbnRz KSBpcyBub3QgeWV0CmNvbXBsZXRlbHkgc3RvcmVkIGludG8gYSByaW5nIGJ1 ZmZlci4gVGhlIGluaXRpYWwgd2F0Y2ggZXZlbnQgc2VudCBhcwphIHJlc3Vs dCBvZiByZWdpc3RlcmluZyBhIHdhdGNoIGlzIGFuIGV4Y2VwdGlvbi4KCk5v dGUgdGhhdCBhY3Jvc3MgYSBsaXZlIHVwZGF0ZSB0aGUgcmVsYXRpb24gdG8g YnVmZmVyZWQgd2F0Y2ggZXZlbnRzCmZvciBvdGhlciBkb21haW5zIGlzIGxv c3QuCgpVc2UgdGFsbG9jX3plcm8oKSBmb3IgYWxsb2NhdGluZyB0aGUgZG9t YWluIHN0cnVjdHVyZSBpbiBvcmRlciB0byBoYXZlCmFsbCBwZXItZG9tYWlu IHF1b3RhIHplcm9lZCBpbml0aWFsbHkuCgpUaGlzIGlzIHBhcnQgb2YgWFNB LTMyNiAvIENWRS0yMDIyLTQyMzEyLgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKaW5kZXggZWUzMzk2ZmVmYTk0Li5kODcxZjIxN2Fm OWMgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAt MTA3LDYgKzEwNyw3IEBAIGludCBxdW90YV9tYXhfZW50cnlfc2l6ZSA9IDIw NDg7IC8qIDJLICovCiBpbnQgcXVvdGFfbWF4X3RyYW5zYWN0aW9uID0gMTA7 CiBpbnQgcXVvdGFfbmJfcGVybXNfcGVyX25vZGUgPSA1OwogaW50IHF1b3Rh X21heF9wYXRoX2xlbiA9IFhFTlNUT1JFX1JFTF9QQVRIX01BWDsKK2ludCBx dW90YV9yZXFfb3V0c3RhbmRpbmcgPSAyMDsKIAogdW5zaWduZWQgaW50IHRp bWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyA9IDIwMDAwOwogCkBAIC0yMjMsMTIg KzIyNCwyNCBAQCBzdGF0aWMgdWludDY0X3QgZ2V0X25vd19tc2VjKHZvaWQp CiAJcmV0dXJuIG5vd190cy50dl9zZWMgKiAxMDAwICsgbm93X3RzLnR2X25z ZWMgLyAxMDAwMDAwOwogfQogCisvKgorICogUmVtb3ZlIGEgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgZnJvbSB0aGUgbGlzdCBvZiBvdXRnb2luZyBkYXRhLgor ICogQSBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSByZWxhdGVkIHRvIGEgcmVxdWVz dCBoYXZpbmcgY2F1c2VkIHdhdGNoIGV2ZW50cyB0byBiZQorICogc2VudCBp cyBrZXB0IHVudGlsIGFsbCB0aG9zZSBldmVudHMgaGF2ZSBiZWVuIHdyaXR0 ZW4gb3V0LgorICogRWFjaCB3YXRjaCBldmVudCBpcyByZWZlcmVuY2luZyB0 aGUgcmVsYXRlZCByZXF1ZXN0IHZpYSBwZW5kLnJlcSwgd2hpbGUgdGhlCisg KiBudW1iZXIgb2Ygd2F0Y2ggZXZlbnRzIGNhdXNlZCBieSBhIHJlcXVlc3Qg aXMga2VwdCBpbiBwZW5kLnJlZi5ldmVudF9jbnQKKyAqICh0aG9zZSB0d28g Y2FzZXMgYXJlIG11dHVhbGx5IGV4Y2x1c2l2ZSwgc28gdGhlIHR3byBmaWVs ZHMgY2FuIHNoYXJlIG1lbW9yeQorICogdmlhIGEgdW5pb24pLgorICogVGhl IHN0cnVjdCBidWZmZXJlZF9kYXRhIGlzIGZyZWVkIG9ubHkgaWYgbm8gcmVs YXRlZCB3YXRjaCBldmVudCBpcworICogcmVmZXJlbmNpbmcgaXQuIFRoZSBy ZWxhdGVkIHJldHVybiBkYXRhIGNhbiBiZSBmcmVlZCByaWdodCBhd2F5Lgor ICovCiBzdGF0aWMgdm9pZCBmcmVlX2J1ZmZlcmVkX2RhdGEoc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKm91dCwKIAkJCSAgICAgICBzdHJ1Y3QgY29ubmVjdGlv biAqY29ubikKIHsKIAlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqcmVxOwogCiAJ bGlzdF9kZWwoJm91dC0+bGlzdCk7CisJb3V0LT5vbl9vdXRfbGlzdCA9IGZh bHNlOwogCiAJLyoKIAkgKiBVcGRhdGUgY29ubi0+dGltZW91dF9tc2VjIHdp dGggdGhlIG5leHQgZm91bmQgdGltZW91dCB2YWx1ZSBpbiB0aGUKQEAgLTI0 NCw2ICsyNTcsMzAgQEAgc3RhdGljIHZvaWQgZnJlZV9idWZmZXJlZF9kYXRh KHN0cnVjdCBidWZmZXJlZF9kYXRhICpvdXQsCiAJCX0KIAl9CiAKKwlpZiAo b3V0LT5oZHIubXNnLnR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQpIHsKKwkJcmVx ID0gb3V0LT5wZW5kLnJlcTsKKwkJaWYgKHJlcSkgeworCQkJcmVxLT5wZW5k LnJlZi5ldmVudF9jbnQtLTsKKwkJCWlmICghcmVxLT5wZW5kLnJlZi5ldmVu dF9jbnQgJiYgIXJlcS0+b25fb3V0X2xpc3QpIHsKKwkJCQlpZiAocmVxLT5v bl9yZWZfbGlzdCkgeworCQkJCQlkb21haW5fb3V0c3RhbmRpbmdfZG9taWRf ZGVjKAorCQkJCQkJcmVxLT5wZW5kLnJlZi5kb21pZCk7CisJCQkJCWxpc3Rf ZGVsKCZyZXEtPmxpc3QpOworCQkJCX0KKwkJCQl0YWxsb2NfZnJlZShyZXEp OworCQkJfQorCQl9CisJfSBlbHNlIGlmIChvdXQtPnBlbmQucmVmLmV2ZW50 X2NudCkgeworCQkvKiBIYW5nIG91dCBvZmYgZnJvbSBjb25uLiAqLworCQl0 YWxsb2Nfc3RlYWwoTlVMTCwgb3V0KTsKKwkJaWYgKG91dC0+YnVmZmVyICE9 IG91dC0+ZGVmYXVsdF9idWZmZXIpCisJCQl0YWxsb2NfZnJlZShvdXQtPmJ1 ZmZlcik7CisJCWxpc3RfYWRkKCZvdXQtPmxpc3QsICZjb25uLT5yZWZfbGlz dCk7CisJCW91dC0+b25fcmVmX2xpc3QgPSB0cnVlOworCQlyZXR1cm47CisJ fSBlbHNlCisJCWRvbWFpbl9vdXRzdGFuZGluZ19kZWMoY29ubik7CisKIAl0 YWxsb2NfZnJlZShvdXQpOwogfQogCkBAIC0zOTksNiArNDM2LDcgQEAgaW50 IGRlbGF5X3JlcXVlc3Qoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbiwKIHN0YXRpYyBpbnQgZGVzdHJveV9jb25u KHZvaWQgKl9jb25uKQogewogCXN0cnVjdCBjb25uZWN0aW9uICpjb25uID0g X2Nvbm47CisJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKnJlcTsKIAogCS8qIEZs dXNoIG91dGdvaW5nIGlmIHBvc3NpYmxlLCBidXQgZG9uJ3QgYmxvY2suICov CiAJaWYgKCFjb25uLT5kb21haW4pIHsKQEAgLTQxMiw2ICs0NTAsMTEgQEAg c3RhdGljIGludCBkZXN0cm95X2Nvbm4odm9pZCAqX2Nvbm4pCiAJCQkJYnJl YWs7CiAJCWNsb3NlKGNvbm4tPmZkKTsKIAl9CisKKwljb25uX2ZyZWVfYnVm ZmVyZWRfZGF0YShjb25uKTsKKwlsaXN0X2Zvcl9lYWNoX2VudHJ5KHJlcSwg JmNvbm4tPnJlZl9saXN0LCBsaXN0KQorCQlyZXEtPm9uX3JlZl9saXN0ID0g ZmFsc2U7CisKICAgICAgICAgaWYgKGNvbm4tPnRhcmdldCkKICAgICAgICAg ICAgICAgICB0YWxsb2NfdW5saW5rKGNvbm4sIGNvbm4tPnRhcmdldCk7CiAJ bGlzdF9kZWwoJmNvbm4tPmxpc3QpOwpAQCAtODU5LDYgKzkwMiw4IEBAIHZv aWQgc2VuZF9yZXBseShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgZW51bSB4 c2Rfc29ja21zZ190eXBlIHR5cGUsCiAKIAkvKiBRdWV1ZSBmb3IgbGF0ZXIg dHJhbnNtaXNzaW9uLiAqLwogCWxpc3RfYWRkX3RhaWwoJmJkYXRhLT5saXN0 LCAmY29ubi0+b3V0X2xpc3QpOworCWJkYXRhLT5vbl9vdXRfbGlzdCA9IHRy dWU7CisJZG9tYWluX291dHN0YW5kaW5nX2luYyhjb25uKTsKIH0KIAogLyoK QEAgLTg2Niw3ICs5MTEsOCBAQCB2b2lkIHNlbmRfcmVwbHkoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlLAog ICogQXMgdGhpcyBpcyBub3QgZGlyZWN0bHkgcmVsYXRlZCB0byB0aGUgY3Vy cmVudCBjb21tYW5kLCBlcnJvcnMgY2FuJ3QgYmUKICAqIHJlcG9ydGVkLgog ICovCi12b2lkIHNlbmRfZXZlbnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IGNvbnN0IGNoYXIgKnBhdGgsIGNvbnN0IGNoYXIgKnRva2VuKQordm9pZCBz ZW5kX2V2ZW50KHN0cnVjdCBidWZmZXJlZF9kYXRhICpyZXEsIHN0cnVjdCBj b25uZWN0aW9uICpjb25uLAorCQljb25zdCBjaGFyICpwYXRoLCBjb25zdCBj aGFyICp0b2tlbikKIHsKIAlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRhdGE7 CiAJdW5zaWduZWQgaW50IGxlbjsKQEAgLTg5Niw4ICs5NDIsMTMgQEAgdm9p ZCBzZW5kX2V2ZW50KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBj aGFyICpwYXRoLCBjb25zdCBjaGFyICp0b2tlbikKIAkJCWNvbm4tPnRpbWVv dXRfbXNlYyA9IGJkYXRhLT50aW1lb3V0X21zZWM7CiAJfQogCisJYmRhdGEt PnBlbmQucmVxID0gcmVxOworCWlmIChyZXEpCisJCXJlcS0+cGVuZC5yZWYu ZXZlbnRfY250Kys7CisKIAkvKiBRdWV1ZSBmb3IgbGF0ZXIgdHJhbnNtaXNz aW9uLiAqLwogCWxpc3RfYWRkX3RhaWwoJmJkYXRhLT5saXN0LCAmY29ubi0+ b3V0X2xpc3QpOworCWJkYXRhLT5vbl9vdXRfbGlzdCA9IHRydWU7CiB9CiAK IC8qIFNvbWUgcm91dGluZXMgKHdyaXRlLCBta2RpciwgZXRjKSBqdXN0IG5l ZWQgYSBub24tZXJyb3IgcmV0dXJuICovCkBAIC0xNjU4LDYgKzE3MDksNyBA QCBzdGF0aWMgdm9pZCBoYW5kbGVfaW5wdXQoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pCiAJCQlyZXR1cm47CiAJfQogCWluID0gY29ubi0+aW47CisJaW4t PnBlbmQucmVmLmRvbWlkID0gY29ubi0+aWQ7CiAKIAkvKiBOb3QgZmluaXNo ZWQgaGVhZGVyIHlldD8gKi8KIAlpZiAoaW4tPmluaGRyKSB7CkBAIC0xNzI3 LDYgKzE3NzksNyBAQCBzdHJ1Y3QgY29ubmVjdGlvbiAqbmV3X2Nvbm5lY3Rp b24oY29ubndyaXRlZm5fdCAqd3JpdGUsIGNvbm5yZWFkZm5fdCAqcmVhZCkK IAluZXctPmlzX2lnbm9yZWQgPSBmYWxzZTsKIAluZXctPnRyYW5zYWN0aW9u X3N0YXJ0ZWQgPSAwOwogCUlOSVRfTElTVF9IRUFEKCZuZXctPm91dF9saXN0 KTsKKwlJTklUX0xJU1RfSEVBRCgmbmV3LT5yZWZfbGlzdCk7CiAJSU5JVF9M SVNUX0hFQUQoJm5ldy0+d2F0Y2hlcyk7CiAJSU5JVF9MSVNUX0hFQUQoJm5l dy0+dHJhbnNhY3Rpb25fbGlzdCk7CiAJSU5JVF9MSVNUX0hFQUQoJm5ldy0+ ZGVsYXllZCk7CkBAIC0yMTg0LDYgKzIyMzcsOSBAQCBzdGF0aWMgdm9pZCB1 c2FnZSh2b2lkKQogIiAgLXQsIC0tdHJhbnNhY3Rpb24gPG5iPiAgbGltaXQg dGhlIG51bWJlciBvZiB0cmFuc2FjdGlvbiBhbGxvd2VkIHBlciBkb21haW4s XG4iCiAiICAtQSwgLS1wZXJtLW5iIDxuYj4gICAgICBsaW1pdCB0aGUgbnVt YmVyIG9mIHBlcm1pc3Npb25zIHBlciBub2RlLFxuIgogIiAgLU0sIC0tcGF0 aC1tYXggPGNoYXJzPiAgbGltaXQgdGhlIGFsbG93ZWQgWGVuc3RvcmUgbm9k ZSBwYXRoIGxlbmd0aCxcbiIKKyIgIC1RLCAtLXF1b3RhIDx3aGF0Pj08bmI+ IHNldCB0aGUgcXVvdGEgPHdoYXQ+IHRvIHRoZSB2YWx1ZSA8bmI+LCBhbGxv d2VkXG4iCisiICAgICAgICAgICAgICAgICAgICAgICAgICBxdW90YXMgYXJl OlxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgb3V0c3RhbmRpbmc6 IG51bWJlciBvZiBvdXRzdGFuZGluZyByZXF1ZXN0c1xuIgogIiAgLXcsIC0t dGltZW91dCA8d2hhdD49PHNlY29uZHM+ICAgc2V0IHRoZSB0aW1lb3V0IGlu IHNlY29uZHMgZm9yIDx3aGF0PixcbiIKICIgICAgICAgICAgICAgICAgICAg ICAgICAgIGFsbG93ZWQgdGltZW91dCBjYW5kaWRhdGVzIGFyZTpcbiIKICIg ICAgICAgICAgICAgICAgICAgICAgICAgIHdhdGNoLWV2ZW50OiB0aW1lIGEg d2F0Y2gtZXZlbnQgaXMga2VwdCBwZW5kaW5nXG4iCkBAIC0yMjA5LDYgKzIy NjUsNyBAQCBzdGF0aWMgc3RydWN0IG9wdGlvbiBvcHRpb25zW10gPSB7CiAJ eyAidHJhbnNhY3Rpb24iLCAxLCBOVUxMLCAndCcgfSwKIAl7ICJwZXJtLW5i IiwgMSwgTlVMTCwgJ0EnIH0sCiAJeyAicGF0aC1tYXgiLCAxLCBOVUxMLCAn TScgfSwKKwl7ICJxdW90YSIsIDEsIE5VTEwsICdRJyB9LAogCXsgInRpbWVv dXQiLCAxLCBOVUxMLCAndycgfSwKIAl7ICJuby1yZWNvdmVyeSIsIDAsIE5V TEwsICdSJyB9LAogCXsgImludGVybmFsLWRiIiwgMCwgTlVMTCwgJ0knIH0s CkBAIC0yMjU3LDYgKzIzMTQsMjAgQEAgc3RhdGljIHZvaWQgc2V0X3RpbWVv dXQoY29uc3QgY2hhciAqYXJnKQogCQliYXJmKCJ1bmtub3duIHRpbWVvdXQg XCIlc1wiXG4iLCBhcmcpOwogfQogCitzdGF0aWMgdm9pZCBzZXRfcXVvdGEo Y29uc3QgY2hhciAqYXJnKQoreworCWNvbnN0IGNoYXIgKmVxID0gc3RyY2hy KGFyZywgJz0nKTsKKwlpbnQgdmFsOworCisJaWYgKCFlcSkKKwkJYmFyZigi cXVvdGFzIG11c3QgYmUgc3BlY2lmaWVkIHZpYSA8d2hhdD49PG5iPlxuIik7 CisJdmFsID0gZ2V0X29wdHZhbF9pbnQoZXEgKyAxKTsKKwlpZiAod2hhdF9t YXRjaGVzKGFyZywgIm91dHN0YW5kaW5nIikpCisJCXF1b3RhX3JlcV9vdXRz dGFuZGluZyA9IHZhbDsKKwllbHNlCisJCWJhcmYoInVua25vd24gcXVvdGEg XCIlc1wiXG4iLCBhcmcpOworfQorCiBpbnQgbWFpbihpbnQgYXJnYywgY2hh ciAqYXJndltdKQogewogCWludCBvcHQ7CkBAIC0yMjcxLDggKzIzNDIsOCBA QCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQogCW9yaWdfYXJn YyA9IGFyZ2M7CiAJb3JpZ19hcmd2ID0gYXJndjsKIAotCXdoaWxlICgob3B0 ID0gZ2V0b3B0X2xvbmcoYXJnYywgYXJndiwgIkRFOkY6SE5QUzp0OkE6TTpU OlJWVzp3OlUiLCBvcHRpb25zLAotCQkJCSAgTlVMTCkpICE9IC0xKSB7CisJ d2hpbGUgKChvcHQgPSBnZXRvcHRfbG9uZyhhcmdjLCBhcmd2LCAiREU6RjpI TlBTOnQ6QTpNOlE6VDpSVlc6dzpVIiwKKwkJCQkgIG9wdGlvbnMsIE5VTEwp KSAhPSAtMSkgewogCQlzd2l0Y2ggKG9wdCkgewogCQljYXNlICdEJzoKIAkJ CW5vX2RvbWFpbl9pbml0ID0gdHJ1ZTsKQEAgLTIzMjAsNiArMjM5MSw5IEBA IGludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAJCQlxdW90YV9t YXhfcGF0aF9sZW4gPSBtaW4oWEVOU1RPUkVfUkVMX1BBVEhfTUFYLAogCQkJ CQkJIHF1b3RhX21heF9wYXRoX2xlbik7CiAJCQlicmVhazsKKwkJY2FzZSAn USc6CisJCQlzZXRfcXVvdGEob3B0YXJnKTsKKwkJCWJyZWFrOwogCQljYXNl ICd3JzoKIAkJCXNldF90aW1lb3V0KG9wdGFyZyk7CiAJCQlicmVhazsKQEAg LTI3NzYsNiArMjg1MCwxNCBAQCBzdGF0aWMgdm9pZCBhZGRfYnVmZmVyZWRf ZGF0YShzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRhdGEsCiAKIAkvKiBRdWV1 ZSBmb3IgbGF0ZXIgdHJhbnNtaXNzaW9uLiAqLwogCWxpc3RfYWRkX3RhaWwo JmJkYXRhLT5saXN0LCAmY29ubi0+b3V0X2xpc3QpOworCWJkYXRhLT5vbl9v dXRfbGlzdCA9IHRydWU7CisJLyoKKwkgKiBXYXRjaCBldmVudHMgYXJlIG5l dmVyICJvdXRzdGFuZGluZyIsIGJ1dCB0aGUgcmVxdWVzdCBjYXVzaW5nIHRo ZW0KKwkgKiBhcmUgaW5zdGVhZCBrZXB0ICJvdXRzdGFuZGluZyIgdW50aWwg YWxsIHdhdGNoIGV2ZW50cyBjYXVzZWQgYnkgdGhhdAorCSAqIHJlcXVlc3Qg aGF2ZSBiZWVuIGRlbGl2ZXJlZC4KKwkgKi8KKwlpZiAoYmRhdGEtPmhkci5t c2cudHlwZSAhPSBYU19XQVRDSF9FVkVOVCkKKwkJZG9tYWluX291dHN0YW5k aW5nX2luYyhjb25uKTsKIH0KIAogdm9pZCByZWFkX3N0YXRlX2J1ZmZlcmVk X2RhdGEoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCmluZGV4IDJk YjU3NzkyOGZjNi4uZmNiMjczOTlmMTE2IDEwMDY0NAotLS0gYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCisrKyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmgKQEAgLTU2LDYgKzU2LDggQEAgc3RydWN0IHhz X3N0YXRlX2Nvbm5lY3Rpb247CiBzdHJ1Y3QgYnVmZmVyZWRfZGF0YQogewog CXN0cnVjdCBsaXN0X2hlYWQgbGlzdDsKKwlib29sIG9uX291dF9saXN0Owor CWJvb2wgb25fcmVmX2xpc3Q7CiAKIAkvKiBBcmUgd2Ugc3RpbGwgZG9pbmcg dGhlIGhlYWRlcj8gKi8KIAlib29sIGluaGRyOwpAQCAtNjMsNiArNjUsMTcg QEAgc3RydWN0IGJ1ZmZlcmVkX2RhdGEKIAkvKiBIb3cgZmFyIGFyZSB3ZT8g Ki8KIAl1bnNpZ25lZCBpbnQgdXNlZDsKIAorCS8qIE91dHN0YW5kaW5nIHJl cXVlc3QgYWNjb3VudGluZy4gKi8KKwl1bmlvbiB7CisJCS8qIHJlZiBpcyBi ZWluZyB1c2VkIGZvciByZXF1ZXN0cy4gKi8KKwkJc3RydWN0IHsKKwkJCXVu c2lnbmVkIGludCBldmVudF9jbnQ7IC8qICMgb2Ygb3V0c3RhbmRpbmcgZXZl bnRzLiAqLworCQkJdW5zaWduZWQgaW50IGRvbWlkOyAgICAgLyogZG9taWQg b2YgcmVxdWVzdC4gKi8KKwkJfSByZWY7CisJCS8qIHJlcSBpcyBiZWluZyB1 c2VkIGZvciB3YXRjaCBldmVudHMuICovCisJCXN0cnVjdCBidWZmZXJlZF9k YXRhICpyZXE7ICAgICAgLyogcmVxdWVzdCBjYXVzaW5nIGV2ZW50LiAqLwor CX0gcGVuZDsKKwogCXVuaW9uIHsKIAkJc3RydWN0IHhzZF9zb2NrbXNnIG1z ZzsKIAkJY2hhciByYXdbc2l6ZW9mKHN0cnVjdCB4c2Rfc29ja21zZyldOwpA QCAtMTE1LDYgKzEyOCw5IEBAIHN0cnVjdCBjb25uZWN0aW9uCiAJc3RydWN0 IGxpc3RfaGVhZCBvdXRfbGlzdDsKIAl1aW50NjRfdCB0aW1lb3V0X21zZWM7 CiAKKwkvKiBSZWZlcmVuY2VkIHJlcXVlc3RzIG5vIGxvbmdlciBwZW5kaW5n LiAqLworCXN0cnVjdCBsaXN0X2hlYWQgcmVmX2xpc3Q7CisKIAkvKiBUcmFu c2FjdGlvbiBjb250ZXh0IGZvciBjdXJyZW50IHJlcXVlc3QgKE5VTEwgaWYg bm9uZSkuICovCiAJc3RydWN0IHRyYW5zYWN0aW9uICp0cmFuc2FjdGlvbjsK IApAQCAtMTg0LDcgKzIwMCw4IEBAIHVuc2lnbmVkIGludCBnZXRfc3RyaW5n KGNvbnN0IHN0cnVjdCBidWZmZXJlZF9kYXRhICpkYXRhLCB1bnNpZ25lZCBp bnQgb2Zmc2V0KTsKIAogdm9pZCBzZW5kX3JlcGx5KHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSwKIAkJY29u c3Qgdm9pZCAqZGF0YSwgdW5zaWduZWQgaW50IGxlbik7Ci12b2lkIHNlbmRf ZXZlbnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IGNoYXIgKnBh dGgsIGNvbnN0IGNoYXIgKnRva2VuKTsKK3ZvaWQgc2VuZF9ldmVudChzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqcmVxLCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwKKwkJY29uc3QgY2hhciAqcGF0aCwgY29uc3QgY2hhciAqdG9rZW4pOwog CiAvKiBTb21lIHJvdXRpbmVzICh3cml0ZSwgbWtkaXIsIGV0YykganVzdCBu ZWVkIGEgbm9uLWVycm9yIHJldHVybiAqLwogdm9pZCBzZW5kX2FjayhzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgZW51bSB4c2Rfc29ja21zZ190eXBlIHR5 cGUpOwpAQCAtMjQwLDYgKzI1Nyw3IEBAIGV4dGVybiBpbnQgZG9tMF9kb21p ZDsKIGV4dGVybiBpbnQgZG9tMF9ldmVudDsKIGV4dGVybiBpbnQgcHJpdl9k b21pZDsKIGV4dGVybiBpbnQgcXVvdGFfbmJfZW50cnlfcGVyX2RvbWFpbjsK K2V4dGVybiBpbnQgcXVvdGFfcmVxX291dHN0YW5kaW5nOwogCiBleHRlcm4g dW5zaWduZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIApkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IDcyYTVj ZDNiOWFhZi4uOTc5ZjhjNjI5ODM1IDEwMDY0NAotLS0gYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2RvbWFpbi5jCkBAIC03OCw2ICs3OCw5IEBAIHN0cnVjdCBk b21haW4KIAkvKiBudW1iZXIgb2Ygd2F0Y2ggZm9yIHRoaXMgZG9tYWluICov CiAJaW50IG5id2F0Y2g7CiAKKwkvKiBOdW1iZXIgb2Ygb3V0c3RhbmRpbmcg cmVxdWVzdHMuICovCisJaW50IG5ib3V0c3RhbmRpbmc7CisKIAkvKiB3cml0 ZSByYXRlIGxpbWl0ICovCiAJd3JsX2NyZWRpdHQgd3JsX2NyZWRpdDsgLyog WyAtd3JsX2NvbmZpZ193cml0ZWNvc3QsICtfZGJ1cnN0IF0gKi8KIAlzdHJ1 Y3Qgd3JsX3RpbWVzdGFtcHQgd3JsX3RpbWVzdGFtcDsKQEAgLTI4Nyw4ICsy OTAsMTIgQEAgYm9vbCBkb21haW5fY2FuX3JlYWQoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4pCiB7CiAJc3RydWN0IHhlbnN0b3JlX2RvbWFpbl9pbnRlcmZh Y2UgKmludGYgPSBjb25uLT5kb21haW4tPmludGVyZmFjZTsKIAotCWlmIChk b21haW5faXNfdW5wcml2aWxlZ2VkKGNvbm4pICYmIGNvbm4tPmRvbWFpbi0+ d3JsX2NyZWRpdCA8IDApCi0JCXJldHVybiBmYWxzZTsKKwlpZiAoZG9tYWlu X2lzX3VucHJpdmlsZWdlZChjb25uKSkgeworCQlpZiAoY29ubi0+ZG9tYWlu LT53cmxfY3JlZGl0IDwgMCkKKwkJCXJldHVybiBmYWxzZTsKKwkJaWYgKGNv bm4tPmRvbWFpbi0+bmJvdXRzdGFuZGluZyA+PSBxdW90YV9yZXFfb3V0c3Rh bmRpbmcpCisJCQlyZXR1cm4gZmFsc2U7CisJfQogCiAJaWYgKGNvbm4tPmlz X2lnbm9yZWQpCiAJCXJldHVybiBmYWxzZTsKQEAgLTMzNyw3ICszNDQsNyBA QCBzdGF0aWMgc3RydWN0IGRvbWFpbiAqYWxsb2NfZG9tYWluKGNvbnN0IHZv aWQgKmNvbnRleHQsIHVuc2lnbmVkIGludCBkb21pZCkKIHsKIAlzdHJ1Y3Qg ZG9tYWluICpkb21haW47CiAKLQlkb21haW4gPSB0YWxsb2MoY29udGV4dCwg c3RydWN0IGRvbWFpbik7CisJZG9tYWluID0gdGFsbG9jX3plcm8oY29udGV4 dCwgc3RydWN0IGRvbWFpbik7CiAJaWYgKCFkb21haW4pIHsKIAkJZXJybm8g PSBFTk9NRU07CiAJCXJldHVybiBOVUxMOwpAQCAtMzk4LDkgKzQwNSw2IEBA IHN0YXRpYyBpbnQgbmV3X2RvbWFpbihzdHJ1Y3QgZG9tYWluICpkb21haW4s IGludCBwb3J0LCBib29sIHJlc3RvcmUpCiAJZG9tYWluLT5jb25uLT5kb21h aW4gPSBkb21haW47CiAJZG9tYWluLT5jb25uLT5pZCA9IGRvbWFpbi0+ZG9t aWQ7CiAKLQlkb21haW4tPm5iZW50cnkgPSAwOwotCWRvbWFpbi0+bmJ3YXRj aCA9IDA7Ci0KIAlyZXR1cm4gMDsKIH0KIApAQCAtOTQ0LDYgKzk0OCwyOCBA QCBpbnQgZG9tYWluX3dhdGNoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQog CQk6IDA7CiB9CiAKK3ZvaWQgZG9tYWluX291dHN0YW5kaW5nX2luYyhzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubikKK3sKKwlpZiAoIWNvbm4gfHwgIWNvbm4t PmRvbWFpbikKKwkJcmV0dXJuOworCWNvbm4tPmRvbWFpbi0+bmJvdXRzdGFu ZGluZysrOworfQorCit2b2lkIGRvbWFpbl9vdXRzdGFuZGluZ19kZWMoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4pCit7CisJaWYgKCFjb25uIHx8ICFjb25u LT5kb21haW4pCisJCXJldHVybjsKKwljb25uLT5kb21haW4tPm5ib3V0c3Rh bmRpbmctLTsKK30KKwordm9pZCBkb21haW5fb3V0c3RhbmRpbmdfZG9taWRf ZGVjKHVuc2lnbmVkIGludCBkb21pZCkKK3sKKwlzdHJ1Y3QgZG9tYWluICpk ID0gZmluZF9kb21haW5fYnlfZG9taWQoZG9taWQpOworCisJaWYgKGQpCisJ CWQtPm5ib3V0c3RhbmRpbmctLTsKK30KKwogc3RhdGljIHdybF9jcmVkaXR0 IHdybF9jb25maWdfd3JpdGVjb3N0ICAgICAgPSBXUkxfRkFDVE9SOwogc3Rh dGljIHdybF9jcmVkaXR0IHdybF9jb25maWdfcmF0ZSAgICAgICAgICAgPSBX UkxfUkFURSAgICogV1JMX0ZBQ1RPUjsKIHN0YXRpYyB3cmxfY3JlZGl0dCB3 cmxfY29uZmlnX2RidXJzdCAgICAgICAgID0gV1JMX0RCVVJTVCAqIFdSTF9G QUNUT1I7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgK aW5kZXggZGM5NzU5MTcxMzE3Li41NzU3YTY1NTcxNDYgMTAwNjQ0Ci0tLSBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaAorKysgYi90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgKQEAgLTY4LDYgKzY4LDkg QEAgaW50IGRvbWFpbl9lbnRyeShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7 CiB2b2lkIGRvbWFpbl93YXRjaF9pbmMoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4pOwogdm9pZCBkb21haW5fd2F0Y2hfZGVjKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uKTsKIGludCBkb21haW5fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pOwordm9pZCBkb21haW5fb3V0c3RhbmRpbmdfaW5jKHN0cnVjdCBj b25uZWN0aW9uICpjb25uKTsKK3ZvaWQgZG9tYWluX291dHN0YW5kaW5nX2Rl YyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7Cit2b2lkIGRvbWFpbl9vdXRz dGFuZGluZ19kb21pZF9kZWModW5zaWduZWQgaW50IGRvbWlkKTsKIAogLyog U3BlY2lhbCBub2RlIHBlcm1pc3Npb24gaGFuZGxpbmcuICovCiBpbnQgc2V0 X3Blcm1zX3NwZWNpYWwoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0 IGNoYXIgKm5hbWUsCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfd2F0Y2guYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRj aC5jCmluZGV4IGJjNmQ4MzMwMjhhMy4uMWQ2NjRlM2Q2YjcyIDEwMDY0NAot LS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYworKysgYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYwpAQCAtMTQyLDYgKzE0 Miw3IEBAIHZvaWQgZmlyZV93YXRjaGVzKHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCBjb25zdCB2b2lkICpjdHgsIGNvbnN0IGNoYXIgKm5hbWUsCiAJCSAg c3RydWN0IG5vZGUgKm5vZGUsIGJvb2wgZXhhY3QsIHN0cnVjdCBub2RlX3Bl cm1zICpwZXJtcykKIHsKIAlzdHJ1Y3QgY29ubmVjdGlvbiAqaTsKKwlzdHJ1 Y3QgYnVmZmVyZWRfZGF0YSAqcmVxOwogCXN0cnVjdCB3YXRjaCAqd2F0Y2g7 CiAKIAkvKiBEdXJpbmcgdHJhbnNhY3Rpb25zLCBkb24ndCBmaXJlIHdhdGNo ZXMsIGJ1dCBxdWV1ZSB0aGVtLiAqLwpAQCAtMTUwLDYgKzE1MSw4IEBAIHZv aWQgZmlyZV93YXRjaGVzKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25z dCB2b2lkICpjdHgsIGNvbnN0IGNoYXIgKm5hbWUsCiAJCXJldHVybjsKIAl9 CiAKKwlyZXEgPSBkb21haW5faXNfdW5wcml2aWxlZ2VkKGNvbm4pID8gY29u bi0+aW4gOiBOVUxMOworCiAJLyogQ3JlYXRlIGFuIGV2ZW50IGZvciBlYWNo IHdhdGNoLiAqLwogCWxpc3RfZm9yX2VhY2hfZW50cnkoaSwgJmNvbm5lY3Rp b25zLCBsaXN0KSB7CiAJCS8qIGludHJvZHVjZS9yZWxlYXNlIGRvbWFpbiB3 YXRjaGVzICovCkBAIC0xNjQsMTIgKzE2NywxMiBAQCB2b2lkIGZpcmVfd2F0 Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4 LCBjb25zdCBjaGFyICpuYW1lLAogCQlsaXN0X2Zvcl9lYWNoX2VudHJ5KHdh dGNoLCAmaS0+d2F0Y2hlcywgbGlzdCkgewogCQkJaWYgKGV4YWN0KSB7CiAJ CQkJaWYgKHN0cmVxKG5hbWUsIHdhdGNoLT5ub2RlKSkKLQkJCQkJc2VuZF9l dmVudChpLAorCQkJCQlzZW5kX2V2ZW50KHJlcSwgaSwKIAkJCQkJCSAgIGdl dF93YXRjaF9wYXRoKHdhdGNoLCBuYW1lKSwKIAkJCQkJCSAgIHdhdGNoLT50 b2tlbik7CiAJCQl9IGVsc2UgewogCQkJCWlmIChpc19jaGlsZChuYW1lLCB3 YXRjaC0+bm9kZSkpCi0JCQkJCXNlbmRfZXZlbnQoaSwKKwkJCQkJc2VuZF9l dmVudChyZXEsIGksCiAJCQkJCQkgICBnZXRfd2F0Y2hfcGF0aCh3YXRjaCwg bmFtZSksCiAJCQkJCQkgICB3YXRjaC0+dG9rZW4pOwogCQkJfQpAQCAtMjY5 LDggKzI3MiwxMiBAQCBpbnQgZG9fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAl0cmFjZV9jcmVh dGUod2F0Y2gsICJ3YXRjaCIpOwogCXNlbmRfYWNrKGNvbm4sIFhTX1dBVENI KTsKIAotCS8qIFdlIGZpcmUgb25jZSB1cCBmcm9udDogc2ltcGxpZmllcyBj bGllbnRzIGFuZCByZXN0YXJ0LiAqLwotCXNlbmRfZXZlbnQoY29ubiwgZ2V0 X3dhdGNoX3BhdGgod2F0Y2gsIHdhdGNoLT5ub2RlKSwgd2F0Y2gtPnRva2Vu KTsKKwkvKgorCSAqIFdlIGZpcmUgb25jZSB1cCBmcm9udDogc2ltcGxpZmll cyBjbGllbnRzIGFuZCByZXN0YXJ0LgorCSAqIFRoaXMgZXZlbnQgd2lsbCBu b3QgYmUgbGlua2VkIHRvIHRoZSBYU19XQVRDSCByZXF1ZXN0LgorCSAqLwor CXNlbmRfZXZlbnQoTlVMTCwgY29ubiwgZ2V0X3dhdGNoX3BhdGgod2F0Y2gs IHdhdGNoLT5ub2RlKSwKKwkJICAgd2F0Y2gtPnRva2VuKTsKIAogCXJldHVy biAwOwogfQo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-06.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-06.patch" Content-Transfer-Encoding: base64 RnJvbSA0NTIyYjllNWMwNWYxMmJjYTBjN2QxYzJjOWZlYTE1YzdiYzQxMzU4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGRvbid0IGJ1 ZmZlciBtdWx0aXBsZSBpZGVudGljYWwgd2F0Y2ggZXZlbnRzCgpBIGd1ZXN0 IG5vdCByZWFkaW5nIGl0cyBYZW5zdG9yZSByZXNwb25zZSBidWZmZXIgZmFz dCBlbm91Z2ggbWlnaHQKcGlsZSB1cCBsb3RzIG9mIFhlbnN0b3JlIHdhdGNo IGV2ZW50cyBidWZmZXJlZC4gUmVkdWNlIHRoZSBnZW5lcmF0ZWQKbG9hZCBi eSBkcm9wcGluZyBuZXcgZXZlbnRzIHdoaWNoIGFscmVhZHkgaGF2ZSBhbiBp ZGVudGljYWwgY29weQpwZW5kaW5nLgoKVGhlIHNwZWNpYWwgZXZlbnRzICJA Li4uIiBhcmUgZXhjbHVkZWQgZnJvbSB0aGF0IGhhbmRsaW5nIGFzIHRoZXJl IGFyZQprbm93biB1c2UgY2FzZXMgd2hlcmUgdGhlIGhhbmRsZXIgaXMgcmVs eWluZyBvbiBlYWNoIGV2ZW50IHRvIGJlIHNlbnQKaW5kaXZpZHVhbGx5LgoK VGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRlZC1ieTogSnVsaWVu IEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVs aWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuYwppbmRleCBkODcxZjIxN2FmOWMuLjZlYTA2 ZTIwZGY5MSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2NvcmUuYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5j CkBAIC04ODIsNiArODgyLDcgQEAgdm9pZCBzZW5kX3JlcGx5KHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSwK IAliZGF0YS0+aW5oZHIgPSB0cnVlOwogCWJkYXRhLT51c2VkID0gMDsKIAli ZGF0YS0+dGltZW91dF9tc2VjID0gMDsKKwliZGF0YS0+d2F0Y2hfZXZlbnQg PSBmYWxzZTsKIAogCWlmIChsZW4gPD0gREVGQVVMVF9CVUZGRVJfU0laRSkK IAkJYmRhdGEtPmJ1ZmZlciA9IGJkYXRhLT5kZWZhdWx0X2J1ZmZlcjsKQEAg LTkxNCw3ICs5MTUsNyBAQCB2b2lkIHNlbmRfcmVwbHkoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlLAogdm9p ZCBzZW5kX2V2ZW50KHN0cnVjdCBidWZmZXJlZF9kYXRhICpyZXEsIHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAogCQljb25zdCBjaGFyICpwYXRoLCBjb25z dCBjaGFyICp0b2tlbikKIHsKLQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRh dGE7CisJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmJkYXRhLCAqYmQ7CiAJdW5z aWduZWQgaW50IGxlbjsKIAogCWxlbiA9IHN0cmxlbihwYXRoKSArIDEgKyBz dHJsZW4odG9rZW4pICsgMTsKQEAgLTkzNiwxMiArOTM3LDI5IEBAIHZvaWQg c2VuZF9ldmVudChzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqcmVxLCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKIAliZGF0YS0+aGRyLm1zZy50eXBlID0gWFNf V0FUQ0hfRVZFTlQ7CiAJYmRhdGEtPmhkci5tc2cubGVuID0gbGVuOwogCisJ LyoKKwkgKiBDaGVjayB3aGV0aGVyIGFuIGlkZW50aWNhbCBldmVudCBpcyBw ZW5kaW5nIGFscmVhZHkuCisJICogU3BlY2lhbCBldmVudHMgYXJlIGV4Y2x1 ZGVkIGZyb20gdGhhdCBjaGVjay4KKwkgKi8KKwlpZiAocGF0aFswXSAhPSAn QCcpIHsKKwkJbGlzdF9mb3JfZWFjaF9lbnRyeShiZCwgJmNvbm4tPm91dF9s aXN0LCBsaXN0KSB7CisJCQlpZiAoYmQtPndhdGNoX2V2ZW50ICYmIGJkLT5o ZHIubXNnLmxlbiA9PSBsZW4gJiYKKwkJCSAgICAhbWVtY21wKGJkYXRhLT5i dWZmZXIsIGJkLT5idWZmZXIsIGxlbikpIHsKKwkJCQl0cmFjZSgiZHJvcHBp bmcgZHVwbGljYXRlIHdhdGNoICVzICVzIGZvciBkb21haW4gJXVcbiIsCisJ CQkJICAgICAgcGF0aCwgdG9rZW4sIGNvbm4tPmlkKTsKKwkJCQl0YWxsb2Nf ZnJlZShiZGF0YSk7CisJCQkJcmV0dXJuOworCQkJfQorCQl9CisJfQorCiAJ aWYgKHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyAmJiBkb21haW5faXNfdW5w cml2aWxlZ2VkKGNvbm4pKSB7CiAJCWJkYXRhLT50aW1lb3V0X21zZWMgPSBn ZXRfbm93X21zZWMoKSArIHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIAkJ aWYgKCFjb25uLT50aW1lb3V0X21zZWMpCiAJCQljb25uLT50aW1lb3V0X21z ZWMgPSBiZGF0YS0+dGltZW91dF9tc2VjOwogCX0KIAorCWJkYXRhLT53YXRj aF9ldmVudCA9IHRydWU7CiAJYmRhdGEtPnBlbmQucmVxID0gcmVxOwogCWlm IChyZXEpCiAJCXJlcS0+cGVuZC5yZWYuZXZlbnRfY250Kys7CmRpZmYgLS1n aXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCBmY2IyNzM5OWYxMTYu LmFmYmQ5ODJjMjY1NCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5oCkBAIC02Miw2ICs2Miw5IEBAIHN0cnVjdCBidWZmZXJlZF9kYXRh CiAJLyogQXJlIHdlIHN0aWxsIGRvaW5nIHRoZSBoZWFkZXI/ICovCiAJYm9v bCBpbmhkcjsKIAorCS8qIElzIHRoaXMgYSB3YXRjaCBldmVudD8gKi8KKwli b29sIHdhdGNoX2V2ZW50OworCiAJLyogSG93IGZhciBhcmUgd2U/ICovCiAJ dW5zaWduZWQgaW50IHVzZWQ7CiAK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-07.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-07.patch" Content-Transfer-Encoding: base64 RnJvbSBiMjhhZDllYjc2MTVkMDU3MTZiZDcyOGU2YjJkZjBmODRkMDcxMWEw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGZpeCBjb25u ZWN0aW9uLT5pZCB1c2FnZQoKRG9uJ3QgdXNlIGNvbm4tPmlkIGZvciBwcml2 aWxlZ2UgY2hlY2tzLCBidXQgZG9tYWluX2lzX3VucHJpdmlsZWdlZCgpLgoK VGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRlZC1ieTogSnVsaWVu IEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVs aWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuYwppbmRleCA4ZTQ3MGYyYjIwNTYu LjIxMWZlMWZkOWIzNyAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvbnRyb2wuYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29udHJvbC5jCkBAIC04MjEsNyArODIxLDcgQEAgaW50IGRvX2NvbnRy b2woc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbikKIAl1bnNpZ25lZCBpbnQgY21kLCBudW0sIG9mZjsKIAljaGFy ICoqdmVjID0gTlVMTDsKIAotCWlmIChjb25uLT5pZCAhPSAwKQorCWlmIChk b21haW5faXNfdW5wcml2aWxlZ2VkKGNvbm4pKQogCQlyZXR1cm4gRUFDQ0VT OwogCiAJb2ZmID0gZ2V0X3N0cmluZyhpbiwgMCk7CmRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCBhZmJkOTgyYzI2NTQuLmMwYTA1 NmNlMTNmZSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2NvcmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5o CkBAIC0xMTgsNyArMTE4LDcgQEAgc3RydWN0IGNvbm5lY3Rpb24KIAkvKiBU aGUgaW5kZXggb2YgcG9sbGZkIGluIGdsb2JhbCBwb2xsZmQgYXJyYXkgKi8K IAlpbnQgcG9sbGZkX2lkeDsKIAotCS8qIFdobyBhbSBJPyAwIGZvciBzb2Nr ZXQgY29ubmVjdGlvbnMuICovCisJLyogV2hvIGFtIEk/IERvbWlkIG9mIGNv bm5lY3Rpb24uICovCiAJdW5zaWduZWQgaW50IGlkOwogCiAJLyogSXMgdGhp cyBjb25uZWN0aW9uIGlnbm9yZWQ/ICovCmRpZmYgLS1naXQgYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4IDU0NDMyOTA3ZmM3 Ni4uZWUxYjA5MDMxYTNiIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpAQCAtNDc3LDcgKzQ3Nyw4IEBAIGlu dCBkb190cmFuc2FjdGlvbl9zdGFydChzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCWlmIChjb25uLT50cmFu c2FjdGlvbikKIAkJcmV0dXJuIEVCVVNZOwogCi0JaWYgKGNvbm4tPmlkICYm IGNvbm4tPnRyYW5zYWN0aW9uX3N0YXJ0ZWQgPiBxdW90YV9tYXhfdHJhbnNh Y3Rpb24pCisJaWYgKGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikgJiYK KwkgICAgY29ubi0+dHJhbnNhY3Rpb25fc3RhcnRlZCA+IHF1b3RhX21heF90 cmFuc2FjdGlvbikKIAkJcmV0dXJuIEVOT1NQQzsKIAogCS8qIEF0dGFjaCB0 cmFuc2FjdGlvbiB0byBpbnB1dCBmb3IgYXV0b2ZyZWUgdW50aWwgaXQncyBj b21wbGV0ZSAqLwo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-08.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-08.patch" Content-Transfer-Encoding: base64 RnJvbSAwZTcyNGE3OTY0NWQwNWYxMTdmMGFmODMyYjI0YmMzMzRmNzYyZGJj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHNpbXBsaWZ5 IGFuZCBmaXggcGVyIGRvbWFpbiBub2RlIGFjY291bnRpbmcKClRoZSBhY2Nv dW50aW5nIG9mIG5vZGVzIGNhbiBiZSBzaW1wbGlmaWVkIG5vdyB0aGF0IGVh Y2ggY29ubmVjdGlvbgpob2xkcyB0aGUgYXNzb2NpYXRlZCBkb21pZC4KCkZp eCB0aGUgbm9kZSBhY2NvdW50aW5nIHRvIGNvdmVyIG5vZGVzIGNyZWF0ZWQg Zm9yIGEgZG9tYWluIGJlZm9yZSBpdApoYXMgYmVlbiBpbnRyb2R1Y2VkLiBU aGlzIHJlcXVpcmVzIHRvIHJlYWN0IHByb3Blcmx5IHRvIGFuIGFsbG9jYXRp b24KZmFpbHVyZSBpbnNpZGUgZG9tYWluX2VudHJ5X2luYygpIGJ5IHJldHVy bmluZyBhbiBlcnJvciBjb2RlLgoKRXNwZWNpYWxseSBpbiBlcnJvciBwYXRo cyB0aGUgbm9kZSBhY2NvdW50aW5nIGhhcyB0byBiZSBmaXhlZCBpbiBzb21l CmNhc2VzLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYgLyBDVkUtMjAyMi00 MjMxMy4KClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6 b24uY29tPgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NA c3VzZS5jb20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBh bWF6b24uY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5j CmluZGV4IDZlYTA2ZTIwZGY5MS4uODVjMGQyZjM4ZmFjIDEwMDY0NAotLS0g YS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTYwMyw3ICs2MDMsNyBA QCBzdHJ1Y3Qgbm9kZSAqcmVhZF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCBjb25zdCB2b2lkICpjdHgsCiAKIAkvKiBQZXJtaXNzaW9ucyBhcmUg c3RydWN0IHhzX3Blcm1pc3Npb25zLiAqLwogCW5vZGUtPnBlcm1zLnAgPSBo ZHItPnBlcm1zOwotCWlmIChkb21haW5fYWRqdXN0X25vZGVfcGVybXMobm9k ZSkpIHsKKwlpZiAoZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKGNvbm4sIG5v ZGUpKSB7CiAJCXRhbGxvY19mcmVlKG5vZGUpOwogCQlyZXR1cm4gTlVMTDsK IAl9CkBAIC02MjUsNyArNjI1LDcgQEAgaW50IHdyaXRlX25vZGVfcmF3KHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5LCBzdHJ1Y3Qg bm9kZSAqbm9kZSwKIAl2b2lkICpwOwogCXN0cnVjdCB4c190ZGJfcmVjb3Jk X2hkciAqaGRyOwogCi0JaWYgKGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhu b2RlKSkKKwlpZiAoZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKGNvbm4sIG5v ZGUpKQogCQlyZXR1cm4gZXJybm87CiAKIAlkYXRhLmRzaXplID0gc2l6ZW9m KCpoZHIpCkBAIC0xMjM4LDEzICsxMjM4LDE3IEBAIHN0YXRpYyBzdHJ1Y3Qg bm9kZSAqY29uc3RydWN0X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IGNvbnN0IHZvaWQgKmN0eCwKIAlyZXR1cm4gTlVMTDsKIH0KIAotc3RhdGlj IGludCBkZXN0cm95X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBub2RlICpub2RlKQorc3RhdGljIHZvaWQgZGVzdHJveV9ub2RlX3Jt KHN0cnVjdCBub2RlICpub2RlKQogewogCWlmIChzdHJlcShub2RlLT5uYW1l LCAiLyIpKQogCQljb3JydXB0KE5VTEwsICJEZXN0cm95aW5nIHJvb3Qgbm9k ZSEiKTsKIAogCXRkYl9kZWxldGUodGRiX2N0eCwgbm9kZS0+a2V5KTsKK30K IAorc3RhdGljIGludCBkZXN0cm95X25vZGUoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQoreworCWRlc3Ryb3lfbm9kZV9y bShub2RlKTsKIAlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5vZGUpOwogCiAJ LyoKQEAgLTEyOTQsOCArMTI5OCwxMiBAQCBzdGF0aWMgc3RydWN0IG5vZGUg KmNyZWF0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2 b2lkICpjdHgsCiAJCQlnb3RvIGVycjsKIAogCQkvKiBBY2NvdW50IGZvciBu ZXcgbm9kZSAqLwotCQlpZiAoaS0+cGFyZW50KQotCQkJZG9tYWluX2VudHJ5 X2luYyhjb25uLCBpKTsKKwkJaWYgKGktPnBhcmVudCkgeworCQkJaWYgKGRv bWFpbl9lbnRyeV9pbmMoY29ubiwgaSkpIHsKKwkJCQlkZXN0cm95X25vZGVf cm0oaSk7CisJCQkJcmV0dXJuIE5VTEw7CisJCQl9CisJCX0KIAl9CiAKIAly ZXR1cm4gbm9kZTsKQEAgLTE1ODAsMTAgKzE1ODgsMjcgQEAgc3RhdGljIGlu dCBkb19zZXRfcGVybXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbikKIAlvbGRfcGVybXMgPSBub2RlLT5wZXJt czsKIAlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5vZGUpOwogCW5vZGUtPnBl cm1zID0gcGVybXM7Ci0JZG9tYWluX2VudHJ5X2luYyhjb25uLCBub2RlKTsK KwlpZiAoZG9tYWluX2VudHJ5X2luYyhjb25uLCBub2RlKSkgeworCQlub2Rl LT5wZXJtcyA9IG9sZF9wZXJtczsKKwkJLyoKKwkJICogVGhpcyBzaG91bGQg bmV2ZXIgZmFpbCBiZWNhdXNlIHdlIGhhZCBhIHJlZmVyZW5jZSBvbiB0aGUK KwkJICogZG9tYWluIGJlZm9yZSBhbmQgWGVuc3RvcmVkIGlzIHNpbmdsZS10 aHJlYWRlZC4KKwkJICovCisJCWRvbWFpbl9lbnRyeV9pbmMoY29ubiwgbm9k ZSk7CisJCXJldHVybiBFTk9NRU07CisJfQorCisJaWYgKHdyaXRlX25vZGUo Y29ubiwgbm9kZSwgZmFsc2UpKSB7CisJCWludCBzYXZlZF9lcnJubyA9IGVy cm5vOwogCi0JaWYgKHdyaXRlX25vZGUoY29ubiwgbm9kZSwgZmFsc2UpKQor CQlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5vZGUpOworCQlub2RlLT5wZXJt cyA9IG9sZF9wZXJtczsKKwkJLyogTm8gZmFpbHVyZSBwb3NzaWJsZSBhcyBh Ym92ZS4gKi8KKwkJZG9tYWluX2VudHJ5X2luYyhjb25uLCBub2RlKTsKKwor CQllcnJubyA9IHNhdmVkX2Vycm5vOwogCQlyZXR1cm4gZXJybm87CisJfQog CiAJZmlyZV93YXRjaGVzKGNvbm4sIGluLCBuYW1lLCBub2RlLCBmYWxzZSwg Jm9sZF9wZXJtcyk7CiAJc2VuZF9hY2soY29ubiwgWFNfU0VUX1BFUk1TKTsK QEAgLTMwMDMsNyArMzAyOCw5IEBAIHZvaWQgcmVhZF9zdGF0ZV9ub2RlKGNv bnN0IHZvaWQgKmN0eCwgY29uc3Qgdm9pZCAqc3RhdGUpCiAJc2V0X3RkYl9r ZXkobmFtZSwgJmtleSk7CiAJaWYgKHdyaXRlX25vZGVfcmF3KE5VTEwsICZr ZXksIG5vZGUsIHRydWUpKQogCQliYXJmKCJ3cml0ZSBub2RlIGVycm9yIHJl c3RvcmluZyBub2RlIik7Ci0JZG9tYWluX2VudHJ5X2luYygmY29ubiwgbm9k ZSk7CisKKwlpZiAoZG9tYWluX2VudHJ5X2luYygmY29ubiwgbm9kZSkpCisJ CWJhcmYoIm5vZGUgYWNjb3VudGluZyBlcnJvciByZXN0b3Jpbmcgbm9kZSIp OwogCiAJdGFsbG9jX2ZyZWUobm9kZSk7CiB9CmRpZmYgLS1naXQgYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMgYi90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfZG9tYWluLmMKaW5kZXggOTc5ZjhjNjI5ODM1Li4zYzI3 OTczZmI4MzYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9kb21haW4uYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9t YWluLmMKQEAgLTE2LDYgKzE2LDcgQEAKICAgICBhbG9uZyB3aXRoIHRoaXMg cHJvZ3JhbTsgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNl bnNlcy8+LgogKi8KIAorI2luY2x1ZGUgPGFzc2VydC5oPgogI2luY2x1ZGUg PHN0ZGlvLmg+CiAjaW5jbHVkZSA8c3lzL21tYW4uaD4KICNpbmNsdWRlIDx1 bmlzdGQuaD4KQEAgLTM2OSw2ICszNzAsMTggQEAgc3RhdGljIHN0cnVjdCBk b21haW4gKmZpbmRfb3JfYWxsb2NfZG9tYWluKGNvbnN0IHZvaWQgKmN0eCwg dW5zaWduZWQgaW50IGRvbWlkKQogCXJldHVybiBkb21haW4gPyA6IGFsbG9j X2RvbWFpbihjdHgsIGRvbWlkKTsKIH0KIAorc3RhdGljIHN0cnVjdCBkb21h aW4gKmZpbmRfb3JfYWxsb2NfZXhpc3RpbmdfZG9tYWluKHVuc2lnbmVkIGlu dCBkb21pZCkKK3sKKwlzdHJ1Y3QgZG9tYWluICpkb21haW47CisJeGNfZG9t aW5mb190IGRvbWluZm87CisKKwlkb21haW4gPSBmaW5kX2RvbWFpbl9zdHJ1 Y3QoZG9taWQpOworCWlmICghZG9tYWluICYmIGdldF9kb21haW5faW5mbyhk b21pZCwgJmRvbWluZm8pKQorCQlkb21haW4gPSBhbGxvY19kb21haW4oTlVM TCwgZG9taWQpOworCisJcmV0dXJuIGRvbWFpbjsKK30KKwogc3RhdGljIGlu dCBuZXdfZG9tYWluKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgaW50IHBvcnQs IGJvb2wgcmVzdG9yZSkKIHsKIAlpbnQgcmM7CkBAIC03ODgsMzAgKzgwMSwy OCBAQCB2b2lkIGRvbWFpbl9kZWluaXQodm9pZCkKIAkJeGVuZXZ0Y2huX3Vu YmluZCh4Y2VfaGFuZGxlLCB2aXJxX3BvcnQpOwogfQogCi12b2lkIGRvbWFp bl9lbnRyeV9pbmMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlKQoraW50IGRvbWFpbl9lbnRyeV9pbmMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQogewogCXN0cnVjdCBk b21haW4gKmQ7CisJdW5zaWduZWQgaW50IGRvbWlkOwogCiAJaWYgKCFjb25u KQotCQlyZXR1cm47CisJCXJldHVybiAwOwogCi0JaWYgKG5vZGUtPnBlcm1z LnAgJiYgbm9kZS0+cGVybXMucFswXS5pZCAhPSBjb25uLT5pZCkgewotCQlp ZiAoY29ubi0+dHJhbnNhY3Rpb24pIHsKLQkJCXRyYW5zYWN0aW9uX2VudHJ5 X2luYyhjb25uLT50cmFuc2FjdGlvbiwKLQkJCQlub2RlLT5wZXJtcy5wWzBd LmlkKTsKLQkJfSBlbHNlIHsKLQkJCWQgPSBmaW5kX2RvbWFpbl9ieV9kb21p ZChub2RlLT5wZXJtcy5wWzBdLmlkKTsKLQkJCWlmIChkKQotCQkJCWQtPm5i ZW50cnkrKzsKLQkJfQotCX0gZWxzZSBpZiAoY29ubi0+ZG9tYWluKSB7Ci0J CWlmIChjb25uLT50cmFuc2FjdGlvbikgewotCQkJdHJhbnNhY3Rpb25fZW50 cnlfaW5jKGNvbm4tPnRyYW5zYWN0aW9uLAotCQkJCWNvbm4tPmRvbWFpbi0+ ZG9taWQpOwotIAkJfSBlbHNlIHsKLSAJCQljb25uLT5kb21haW4tPm5iZW50 cnkrKzsKLQkJfQorCWRvbWlkID0gbm9kZS0+cGVybXMucCA/IG5vZGUtPnBl cm1zLnBbMF0uaWQgOiBjb25uLT5pZDsKKworCWlmIChjb25uLT50cmFuc2Fj dGlvbikgeworCQl0cmFuc2FjdGlvbl9lbnRyeV9pbmMoY29ubi0+dHJhbnNh Y3Rpb24sIGRvbWlkKTsKKwl9IGVsc2UgeworCQlkID0gKGRvbWlkID09IGNv bm4tPmlkICYmIGNvbm4tPmRvbWFpbikgPyBjb25uLT5kb21haW4KKwkJICAg IDogZmluZF9vcl9hbGxvY19leGlzdGluZ19kb21haW4oZG9taWQpOworCQlp ZiAoZCkKKwkJCWQtPm5iZW50cnkrKzsKKwkJZWxzZQorCQkJcmV0dXJuIEVO T01FTTsKIAl9CisKKwlyZXR1cm4gMDsKIH0KIAogLyoKQEAgLTg0Nyw3ICs4 NTgsNyBAQCBzdGF0aWMgaW50IGNoa19kb21haW5fZ2VuZXJhdGlvbih1bnNp Z25lZCBpbnQgZG9taWQsIHVpbnQ2NF90IGdlbikKICAqIFJlbW92ZSBwZXJt aXNzaW9ucyBmb3Igbm8gbG9uZ2VyIGV4aXN0aW5nIGRvbWFpbnMgaW4gb3Jk ZXIgdG8gYXZvaWQgYSBuZXcKICAqIGRvbWFpbiB3aXRoIHRoZSBzYW1lIGRv bWlkIGluaGVyaXRpbmcgdGhlIHBlcm1pc3Npb25zLgogICovCi1pbnQgZG9t YWluX2FkanVzdF9ub2RlX3Blcm1zKHN0cnVjdCBub2RlICpub2RlKQoraW50 IGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgc3RydWN0IG5vZGUgKm5vZGUpCiB7CiAJdW5zaWduZWQgaW50IGk7 CiAJaW50IHJldDsKQEAgLTg1Nyw4ICs4NjgsMTQgQEAgaW50IGRvbWFpbl9h ZGp1c3Rfbm9kZV9wZXJtcyhzdHJ1Y3Qgbm9kZSAqbm9kZSkKIAkJcmV0dXJu IGVycm5vOwogCiAJLyogSWYgdGhlIG93bmVyIGRvZXNuJ3QgZXhpc3QgYW55 IGxvbmdlciBnaXZlIGl0IHRvIHByaXYgZG9tYWluLiAqLwotCWlmICghcmV0 KQorCWlmICghcmV0KSB7CisJCS8qCisJCSAqIEluIHRoZW9yeSB3ZSdkIG5l ZWQgdG8gdXBkYXRlIHRoZSBudW1iZXIgb2YgZG9tMCBub2RlcyBoZXJlLAor CQkgKiBidXQgd2UgY291bGQgYmUgY2FsbGVkIGZvciBhIHJlYWQgb2YgdGhl IG5vZGUuIFNvIGJldHRlcgorCQkgKiBhdm9pZCB0aGUgcmlzayB0byBvdmVy ZmxvdyB0aGUgbm9kZSBjb3VudCBvZiBkb20wLgorCQkgKi8KIAkJbm9kZS0+ cGVybXMucFswXS5pZCA9IHByaXZfZG9taWQ7CisJfQogCiAJZm9yIChpID0g MTsgaSA8IG5vZGUtPnBlcm1zLm51bTsgaSsrKSB7CiAJCWlmIChub2RlLT5w ZXJtcy5wW2ldLnBlcm1zICYgWFNfUEVSTV9JR05PUkUpCkBAIC04NzcsMjUg Kzg5NCwyNSBAQCBpbnQgZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKHN0cnVj dCBub2RlICpub2RlKQogdm9pZCBkb21haW5fZW50cnlfZGVjKHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSkKIHsKIAlzdHJ1 Y3QgZG9tYWluICpkOworCXVuc2lnbmVkIGludCBkb21pZDsKIAogCWlmICgh Y29ubikKIAkJcmV0dXJuOwogCi0JaWYgKG5vZGUtPnBlcm1zLnAgJiYgbm9k ZS0+cGVybXMucFswXS5pZCAhPSBjb25uLT5pZCkgewotCQlpZiAoY29ubi0+ dHJhbnNhY3Rpb24pIHsKLQkJCXRyYW5zYWN0aW9uX2VudHJ5X2RlYyhjb25u LT50cmFuc2FjdGlvbiwKLQkJCQlub2RlLT5wZXJtcy5wWzBdLmlkKTsKLQkJ fSBlbHNlIHsKLQkJCWQgPSBmaW5kX2RvbWFpbl9ieV9kb21pZChub2RlLT5w ZXJtcy5wWzBdLmlkKTsKLQkJCWlmIChkICYmIGQtPm5iZW50cnkpCi0JCQkJ ZC0+bmJlbnRyeS0tOwotCQl9Ci0JfSBlbHNlIGlmIChjb25uLT5kb21haW4g JiYgY29ubi0+ZG9tYWluLT5uYmVudHJ5KSB7Ci0JCWlmIChjb25uLT50cmFu c2FjdGlvbikgewotCQkJdHJhbnNhY3Rpb25fZW50cnlfZGVjKGNvbm4tPnRy YW5zYWN0aW9uLAotCQkJCWNvbm4tPmRvbWFpbi0+ZG9taWQpOworCWRvbWlk ID0gbm9kZS0+cGVybXMucCA/IG5vZGUtPnBlcm1zLnBbMF0uaWQgOiBjb25u LT5pZDsKKworCWlmIChjb25uLT50cmFuc2FjdGlvbikgeworCQl0cmFuc2Fj dGlvbl9lbnRyeV9kZWMoY29ubi0+dHJhbnNhY3Rpb24sIGRvbWlkKTsKKwl9 IGVsc2UgeworCQlkID0gKGRvbWlkID09IGNvbm4tPmlkICYmIGNvbm4tPmRv bWFpbikgPyBjb25uLT5kb21haW4KKwkJICAgIDogZmluZF9kb21haW5fc3Ry dWN0KGRvbWlkKTsKKwkJaWYgKGQpIHsKKwkJCWQtPm5iZW50cnktLTsKIAkJ fSBlbHNlIHsKLQkJCWNvbm4tPmRvbWFpbi0+bmJlbnRyeS0tOworCQkJZXJy bm8gPSBFTk9FTlQ7CisJCQljb3JydXB0KGNvbm4sCisJCQkJIk5vZGUgXCIl c1wiIG93bmVkIGJ5IG5vbi1leGlzdGluZyBkb21haW4gJXVcbiIsCisJCQkJ bm9kZS0+bmFtZSwgZG9taWQpOwogCQl9CiAJfQogfQpAQCAtOTA1LDEzICs5 MjIsMjMgQEAgaW50IGRvbWFpbl9lbnRyeV9maXgodW5zaWduZWQgaW50IGRv bWlkLCBpbnQgbnVtLCBib29sIHVwZGF0ZSkKIAlzdHJ1Y3QgZG9tYWluICpk OwogCWludCBjbnQ7CiAKLQlkID0gZmluZF9kb21haW5fYnlfZG9taWQoZG9t aWQpOwotCWlmICghZCkKLQkJcmV0dXJuIDA7CisJaWYgKHVwZGF0ZSkgewor CQlkID0gZmluZF9kb21haW5fc3RydWN0KGRvbWlkKTsKKwkJYXNzZXJ0KGQp OworCX0gZWxzZSB7CisJCS8qCisJCSAqIFdlIGFyZSBjYWxsZWQgZmlyc3Qg d2l0aCB1cGRhdGUgPT0gZmFsc2UgaW4gb3JkZXIgdG8gY2F0Y2gKKwkJICog YW55IGVycm9yLiBTbyBkbyBhIHBvc3NpYmxlIGFsbG9jYXRpb24gYW5kIGNo ZWNrIGZvciBlcnJvcgorCQkgKiBvbmx5IGluIHRoaXMgY2FzZSwgYXMgaW4g dGhlIGNhc2Ugb2YgdXBkYXRlID09IHRydWUgbm90aGluZworCQkgKiBjYW4g Z28gd3JvbmcgYW55bW9yZSBhcyB0aGUgYWxsb2NhdGlvbiBhbHJlYWR5IGhh cHBlbmVkLgorCQkgKi8KKwkJZCA9IGZpbmRfb3JfYWxsb2NfZXhpc3Rpbmdf ZG9tYWluKGRvbWlkKTsKKwkJaWYgKCFkKQorCQkJcmV0dXJuIC0xOworCX0K IAogCWNudCA9IGQtPm5iZW50cnkgKyBudW07Ci0JaWYgKGNudCA8IDApCi0J CWNudCA9IDA7CisJYXNzZXJ0KGNudCA+PSAwKTsKIAogCWlmICh1cGRhdGUp CiAJCWQtPm5iZW50cnkgPSBjbnQ7CmRpZmYgLS1naXQgYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfZG9tYWluLmggYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmgKaW5kZXggNTc1N2E2NTU3MTQ2Li5jY2UxM2QxNGYw MTYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21h aW4uaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgK QEAgLTU4LDEwICs1OCwxMCBAQCBib29sIGRvbWFpbl9jYW5fd3JpdGUoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4pOwogYm9vbCBkb21haW5faXNfdW5wcml2 aWxlZ2VkKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsKIAogLyogUmVtb3Zl IG5vZGUgcGVybWlzc2lvbnMgZm9yIG5vIGxvbmdlciBleGlzdGluZyBkb21h aW5zLiAqLwotaW50IGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhzdHJ1Y3Qg bm9kZSAqbm9kZSk7CitpbnQgZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSk7CiAK IC8qIFF1b3RhIG1hbmlwdWxhdGlvbiAqLwotdm9pZCBkb21haW5fZW50cnlf aW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqKTsK K2ludCBkb21haW5fZW50cnlfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25u LCBzdHJ1Y3Qgbm9kZSAqKTsKIHZvaWQgZG9tYWluX2VudHJ5X2RlYyhzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKik7CiBpbnQgZG9t YWluX2VudHJ5X2ZpeCh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBudW0sIGJv b2wgdXBkYXRlKTsKIGludCBkb21haW5fZW50cnkoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4pOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX3RyYW5zYWN0aW9uLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf dHJhbnNhY3Rpb24uYwppbmRleCBlZTFiMDkwMzFhM2IuLjg2Y2FmNmMzOThi ZSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5z YWN0aW9uLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5z YWN0aW9uLmMKQEAgLTUxOSw4ICs1MTksMTIgQEAgc3RhdGljIGludCB0cmFu c2FjdGlvbl9maXhfZG9tYWlucyhzdHJ1Y3QgdHJhbnNhY3Rpb24gKnRyYW5z LCBib29sIHVwZGF0ZSkKIAogCWxpc3RfZm9yX2VhY2hfZW50cnkoZCwgJnRy YW5zLT5jaGFuZ2VkX2RvbWFpbnMsIGxpc3QpIHsKIAkJY250ID0gZG9tYWlu X2VudHJ5X2ZpeChkLT5kb21pZCwgZC0+bmJlbnRyeSwgdXBkYXRlKTsKLQkJ aWYgKCF1cGRhdGUgJiYgY250ID49IHF1b3RhX25iX2VudHJ5X3Blcl9kb21h aW4pCi0JCQlyZXR1cm4gRU5PU1BDOworCQlpZiAoIXVwZGF0ZSkgeworCQkJ aWYgKGNudCA+PSBxdW90YV9uYl9lbnRyeV9wZXJfZG9tYWluKQorCQkJCXJl dHVybiBFTk9TUEM7CisJCQlpZiAoY250IDwgMCkKKwkJCQlyZXR1cm4gRU5P TUVNOworCQl9CiAJfQogCiAJcmV0dXJuIDA7Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-09.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-09.patch" Content-Transfer-Encoding: base64 RnJvbSBmNTZiMGFhMDQzMGQwZWU3OGU2NTgyYjMyM2E1NTIwODQzNjE5MDFh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxpbWl0IG1h eCBudW1iZXIgb2Ygbm9kZXMgYWNjZXNzZWQgaW4gYSB0cmFuc2FjdGlvbgoK VG9kYXkgYSBndWVzdCBpcyBmcmVlIHRvIGFjY2VzcyBhcyBtYW55IG5vZGVz IGluIGEgc2luZ2xlIHRyYW5zYWN0aW9uCmFzIGl0IHdhbnRzLiBUaGlzIGNh biBsZWFkIHRvIHVuYm91bmRlZCBtZW1vcnkgY29uc3VtcHRpb24gaW4gWGVu c3RvcmUKYXMgdGhlcmUgaXMgdGhlIG5lZWQgdG8ga2VlcCB0cmFjayBvZiBh bGwgbm9kZXMgaGF2aW5nIGJlZW4gYWNjZXNzZWQKZHVyaW5nIGEgdHJhbnNh Y3Rpb24uCgpJbiBveGVuc3RvcmVkIHRoZSBudW1iZXIgb2YgcmVxdWVzdHMg aW4gYSB0cmFuc2FjdGlvbiBpcyBiZWluZyBsaW1pdGVkCnZpYSBhIHF1b3Rh IG1heHJlcXVlc3RzIChkZWZhdWx0IGlzIDEwMjQpLiBBcyBtdWx0aXBsZSBh Y2Nlc3NlcyBvZiBhCm5vZGUgYXJlIG5vdCBwcm9ibGVtYXRpYyBpbiBDIFhl bnN0b3JlLCBsaW1pdCB0aGUgbnVtYmVyIG9mIGFjY2Vzc2VkCm5vZGVzLgoK SW4gb3JkZXIgdG8gbGV0IHJlYWRfbm9kZSgpIGRldGVjdCBhIHF1b3RhIGVy cm9yIGluIGNhc2UgdG9vIG1hbnkgbm9kZXMKYXJlIGJlaW5nIGFjY2Vzc2Vk LCBjaGVjayB0aGUgcmV0dXJuIHZhbHVlIG9mIGFjY2Vzc19ub2RlKCkgYW5k IHJldHVybgpOVUxMIGluIGNhc2UgYW4gZXJyb3IgaGFzIGJlZW4gc2Vlbi4g SW50cm9kdWNlIF9fbXVzdF9jaGVjayBhbmQgYWRkIGl0CnRvIHRoZSBhY2Nl c3Nfbm9kZSgpIHByb3RvdHlwZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2 IC8gQ1ZFLTIwMjItNDIzMTQuCgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxs IDxqZ3JhbGxAYW1hem9uLmNvbT4KU3VnZ2VzdGVkLWJ5OiBKdWxpZW4gR3Jh bGwgPGp1bGllbkB4ZW4ub3JnPgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdy b3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3Jh bGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL2lu Y2x1ZGUveGVuLXRvb2xzL2xpYnMuaCBiL3Rvb2xzL2luY2x1ZGUveGVuLXRv b2xzL2xpYnMuaAppbmRleCBhMTZlMGMzODA3MDkuLmJhZmM5MGUyZjYwMyAx MDA2NDQKLS0tIGEvdG9vbHMvaW5jbHVkZS94ZW4tdG9vbHMvbGlicy5oCisr KyBiL3Rvb2xzL2luY2x1ZGUveGVuLXRvb2xzL2xpYnMuaApAQCAtNjMsNCAr NjMsOCBAQAogI2RlZmluZSBST1VORFVQKF94LF93KSAoKCh1bnNpZ25lZCBs b25nKShfeCkrKDFVTDw8KF93KSktMSkgJiB+KCgxVUw8PChfdykpLTEpKQog I2VuZGlmCiAKKyNpZm5kZWYgX19tdXN0X2NoZWNrCisjZGVmaW5lIF9fbXVz dF9jaGVjayBfX2F0dHJpYnV0ZV9fKChfX3dhcm5fdW51c2VkX3Jlc3VsdF9f KSkKKyNlbmRpZgorCiAjZW5kaWYJLyogX19YRU5fVE9PTFNfTElCU19fICov CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5j IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwppbmRleCA4NWMw ZDJmMzhmYWMuLjA1MGQ2ZjY1MWFlOSAxMDA2NDQKLS0tIGEvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfY29yZS5jCkBAIC0xMDYsNiArMTA2LDcgQEAgaW50IHF1b3Rh X25iX3dhdGNoX3Blcl9kb21haW4gPSAxMjg7CiBpbnQgcXVvdGFfbWF4X2Vu dHJ5X3NpemUgPSAyMDQ4OyAvKiAySyAqLwogaW50IHF1b3RhX21heF90cmFu c2FjdGlvbiA9IDEwOwogaW50IHF1b3RhX25iX3Blcm1zX3Blcl9ub2RlID0g NTsKK2ludCBxdW90YV90cmFuc19ub2RlcyA9IDEwMjQ7CiBpbnQgcXVvdGFf bWF4X3BhdGhfbGVuID0gWEVOU1RPUkVfUkVMX1BBVEhfTUFYOwogaW50IHF1 b3RhX3JlcV9vdXRzdGFuZGluZyA9IDIwOwogCkBAIC01NjAsNiArNTYxLDcg QEAgc3RydWN0IG5vZGUgKnJlYWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCVREQl9EQVRBIGtleSwgZGF0YTsK IAlzdHJ1Y3QgeHNfdGRiX3JlY29yZF9oZHIgKmhkcjsKIAlzdHJ1Y3Qgbm9k ZSAqbm9kZTsKKwlpbnQgZXJyOwogCiAJbm9kZSA9IHRhbGxvYyhjdHgsIHN0 cnVjdCBub2RlKTsKIAlpZiAoIW5vZGUpIHsKQEAgLTU4MSwxNCArNTgzLDEz IEBAIHN0cnVjdCBub2RlICpyZWFkX25vZGUoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAlpZiAoZGF0YS5kcHRyID09IE5V TEwpIHsKIAkJaWYgKHRkYl9lcnJvcih0ZGJfY3R4KSA9PSBUREJfRVJSX05P RVhJU1QpIHsKIAkJCW5vZGUtPmdlbmVyYXRpb24gPSBOT19HRU5FUkFUSU9O OwotCQkJYWNjZXNzX25vZGUoY29ubiwgbm9kZSwgTk9ERV9BQ0NFU1NfUkVB RCwgTlVMTCk7Ci0JCQllcnJubyA9IEVOT0VOVDsKKwkJCWVyciA9IGFjY2Vz c19ub2RlKGNvbm4sIG5vZGUsIE5PREVfQUNDRVNTX1JFQUQsIE5VTEwpOwor CQkJZXJybm8gPSBlcnIgPyA6IEVOT0VOVDsKIAkJfSBlbHNlIHsKIAkJCWxv ZygiVERCIGVycm9yIG9uIHJlYWQ6ICVzIiwgdGRiX2Vycm9yc3RyKHRkYl9j dHgpKTsKIAkJCWVycm5vID0gRUlPOwogCQl9Ci0JCXRhbGxvY19mcmVlKG5v ZGUpOwotCQlyZXR1cm4gTlVMTDsKKwkJZ290byBlcnJvcjsKIAl9CiAKIAlu b2RlLT5wYXJlbnQgPSBOVUxMOwpAQCAtNjAzLDE5ICs2MDQsMzYgQEAgc3Ry dWN0IG5vZGUgKnJlYWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3Qgdm9pZCAqY3R4LAogCiAJLyogUGVybWlzc2lvbnMgYXJlIHN0cnVj dCB4c19wZXJtaXNzaW9ucy4gKi8KIAlub2RlLT5wZXJtcy5wID0gaGRyLT5w ZXJtczsKLQlpZiAoZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKGNvbm4sIG5v ZGUpKSB7Ci0JCXRhbGxvY19mcmVlKG5vZGUpOwotCQlyZXR1cm4gTlVMTDsK LQl9CisJaWYgKGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhjb25uLCBub2Rl KSkKKwkJZ290byBlcnJvcjsKIAogCS8qIERhdGEgaXMgYmluYXJ5IGJsb2Ig KHVzdWFsbHkgYXNjaWksIG5vIG51bCkuICovCiAJbm9kZS0+ZGF0YSA9IG5v ZGUtPnBlcm1zLnAgKyBoZHItPm51bV9wZXJtczsKIAkvKiBDaGlsZHJlbiBp cyBzdHJpbmdzLCBudWwgc2VwYXJhdGVkLiAqLwogCW5vZGUtPmNoaWxkcmVu ID0gbm9kZS0+ZGF0YSArIG5vZGUtPmRhdGFsZW47CiAKLQlhY2Nlc3Nfbm9k ZShjb25uLCBub2RlLCBOT0RFX0FDQ0VTU19SRUFELCBOVUxMKTsKKwlpZiAo YWNjZXNzX25vZGUoY29ubiwgbm9kZSwgTk9ERV9BQ0NFU1NfUkVBRCwgTlVM TCkpCisJCWdvdG8gZXJyb3I7CiAKIAlyZXR1cm4gbm9kZTsKKworIGVycm9y OgorCWVyciA9IGVycm5vOworCXRhbGxvY19mcmVlKG5vZGUpOworCWVycm5v ID0gZXJyOworCXJldHVybiBOVUxMOworfQorCitzdGF0aWMgYm9vbCByZWFk X25vZGVfY2FuX3Byb3BhZ2F0ZV9lcnJubyh2b2lkKQoreworCS8qCisJICog MiBlcnJvciBjYXNlcyBmb3IgcmVhZF9ub2RlKCkgY2FuIGFsd2F5cyBiZSBw cm9wYWdhdGVkIHVwOgorCSAqIEVOT01FTSwgYmVjYXVzZSB0aGlzIGhhcyBu b3RoaW5nIHRvIGRvIHdpdGggdGhlIG5vZGUgYmVpbmcgaW4gdGhlCisJICog ZGF0YSBiYXNlIG9yIG5vdCwgYnV0IGlzIGNhdXNlZCBieSBhIGdlbmVyYWwg bGFjayBvZiBtZW1vcnkuCisJICogRU5PU1BDLCBiZWNhdXNlIHRoaXMgaXMg cmVsYXRlZCB0byBoaXR0aW5nIHF1b3RhIGxpbWl0cyB3aGljaCBuZWVkCisJ ICogdG8gYmUgcmVzcGVjdGVkLgorCSAqLworCXJldHVybiBlcnJubyA9PSBF Tk9NRU0gfHwgZXJybm8gPT0gRU5PU1BDOwogfQogCiBpbnQgd3JpdGVfbm9k ZV9yYXcoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXks IHN0cnVjdCBub2RlICpub2RlLApAQCAtNzMyLDcgKzc1MCw3IEBAIHN0YXRp YyBpbnQgYXNrX3BhcmVudHMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNv bnN0IHZvaWQgKmN0eCwKIAkJbm9kZSA9IHJlYWRfbm9kZShjb25uLCBjdHgs IG5hbWUpOwogCQlpZiAobm9kZSkKIAkJCWJyZWFrOwotCQlpZiAoZXJybm8g PT0gRU5PTUVNKQorCQlpZiAocmVhZF9ub2RlX2Nhbl9wcm9wYWdhdGVfZXJy bm8oKSkKIAkJCXJldHVybiBlcnJubzsKIAl9IHdoaWxlICghc3RyZXEobmFt ZSwgIi8iKSk7CiAKQEAgLTc5NSw3ICs4MTMsNyBAQCBzdGF0aWMgc3RydWN0 IG5vZGUgKmdldF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCQl9 CiAJfQogCS8qIENsZWFuIHVwIGVycm5vIGlmIHRoZXkgd2VyZW4ndCBzdXBw b3NlZCB0byBrbm93LiAqLwotCWlmICghbm9kZSAmJiBlcnJubyAhPSBFTk9N RU0pCisJaWYgKCFub2RlICYmICFyZWFkX25vZGVfY2FuX3Byb3BhZ2F0ZV9l cnJubygpKQogCQllcnJubyA9IGVycm5vX2Zyb21fcGFyZW50cyhjb25uLCBj dHgsIG5hbWUsIGVycm5vLCBwZXJtKTsKIAlyZXR1cm4gbm9kZTsKIH0KQEAg LTEyMDEsNyArMTIxOSw3IEBAIHN0YXRpYyBzdHJ1Y3Qgbm9kZSAqY29uc3Ry dWN0X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQg KmN0eCwKIAogCS8qIElmIHBhcmVudCBkb2Vzbid0IGV4aXN0LCBjcmVhdGUg aXQuICovCiAJcGFyZW50ID0gcmVhZF9ub2RlKGNvbm4sIHBhcmVudG5hbWUs IHBhcmVudG5hbWUpOwotCWlmICghcGFyZW50KQorCWlmICghcGFyZW50ICYm IGVycm5vID09IEVOT0VOVCkKIAkJcGFyZW50ID0gY29uc3RydWN0X25vZGUo Y29ubiwgY3R4LCBwYXJlbnRuYW1lKTsKIAlpZiAoIXBhcmVudCkKIAkJcmV0 dXJuIE5VTEw7CkBAIC0xNDc1LDcgKzE0OTMsNyBAQCBzdGF0aWMgaW50IF9y bShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LCBz dHJ1Y3Qgbm9kZSAqbm9kZSwKIAogCXBhcmVudCA9IHJlYWRfbm9kZShjb25u LCBjdHgsIHBhcmVudG5hbWUpOwogCWlmICghcGFyZW50KQotCQlyZXR1cm4g KGVycm5vID09IEVOT01FTSkgPyBFTk9NRU0gOiBFSU5WQUw7CisJCXJldHVy biByZWFkX25vZGVfY2FuX3Byb3BhZ2F0ZV9lcnJubygpID8gZXJybm8gOiBF SU5WQUw7CiAJbm9kZS0+cGFyZW50ID0gcGFyZW50OwogCiAJcmV0dXJuIGRl bGV0ZV9ub2RlKGNvbm4sIGN0eCwgcGFyZW50LCBub2RlLCBmYWxzZSk7CkBA IC0xNTA1LDcgKzE1MjMsNyBAQCBzdGF0aWMgaW50IGRvX3JtKHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJ CQkJcmV0dXJuIDA7CiAJCQl9CiAJCQkvKiBSZXN0b3JlIGVycm5vLCBqdXN0 IGluIGNhc2UuICovCi0JCQlpZiAoZXJybm8gIT0gRU5PTUVNKQorCQkJaWYg KCFyZWFkX25vZGVfY2FuX3Byb3BhZ2F0ZV9lcnJubygpKQogCQkJCWVycm5v ID0gRU5PRU5UOwogCQl9CiAJCXJldHVybiBlcnJubzsKQEAgLTIyODIsNiAr MjMwMCw4IEBAIHN0YXRpYyB2b2lkIHVzYWdlKHZvaWQpCiAiICAtTSwgLS1w YXRoLW1heCA8Y2hhcnM+ICBsaW1pdCB0aGUgYWxsb3dlZCBYZW5zdG9yZSBu b2RlIHBhdGggbGVuZ3RoLFxuIgogIiAgLVEsIC0tcXVvdGEgPHdoYXQ+PTxu Yj4gc2V0IHRoZSBxdW90YSA8d2hhdD4gdG8gdGhlIHZhbHVlIDxuYj4sIGFs bG93ZWRcbiIKICIgICAgICAgICAgICAgICAgICAgICAgICAgIHF1b3RhcyBh cmU6XG4iCisiICAgICAgICAgICAgICAgICAgICAgICAgICB0cmFuc2FjdGlv bi1ub2RlczogbnVtYmVyIG9mIGFjY2Vzc2VkIG5vZGUgcGVyXG4iCisiICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHJh bnNhY3Rpb25cbiIKICIgICAgICAgICAgICAgICAgICAgICAgICAgIG91dHN0 YW5kaW5nOiBudW1iZXIgb2Ygb3V0c3RhbmRpbmcgcmVxdWVzdHNcbiIKICIg IC13LCAtLXRpbWVvdXQgPHdoYXQ+PTxzZWNvbmRzPiAgIHNldCB0aGUgdGlt ZW91dCBpbiBzZWNvbmRzIGZvciA8d2hhdD4sXG4iCiAiICAgICAgICAgICAg ICAgICAgICAgICAgICBhbGxvd2VkIHRpbWVvdXQgY2FuZGlkYXRlcyBhcmU6 XG4iCkBAIC0yMzY3LDYgKzIzODcsOCBAQCBzdGF0aWMgdm9pZCBzZXRfcXVv dGEoY29uc3QgY2hhciAqYXJnKQogCXZhbCA9IGdldF9vcHR2YWxfaW50KGVx ICsgMSk7CiAJaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJvdXRzdGFuZGluZyIp KQogCQlxdW90YV9yZXFfb3V0c3RhbmRpbmcgPSB2YWw7CisJZWxzZSBpZiAo d2hhdF9tYXRjaGVzKGFyZywgInRyYW5zYWN0aW9uLW5vZGVzIikpCisJCXF1 b3RhX3RyYW5zX25vZGVzID0gdmFsOwogCWVsc2UKIAkJYmFyZigidW5rbm93 biBxdW90YSBcIiVzXCJcbiIsIGFyZyk7CiB9CmRpZmYgLS1naXQgYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2NvcmUuaAppbmRleCBjMGEwNTZjZTEzZmUuLjFiM2JkNWNh NTYzYSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCkBA IC0yNjEsNiArMjYxLDcgQEAgZXh0ZXJuIGludCBkb20wX2V2ZW50OwogZXh0 ZXJuIGludCBwcml2X2RvbWlkOwogZXh0ZXJuIGludCBxdW90YV9uYl9lbnRy eV9wZXJfZG9tYWluOwogZXh0ZXJuIGludCBxdW90YV9yZXFfb3V0c3RhbmRp bmc7CitleHRlcm4gaW50IHF1b3RhX3RyYW5zX25vZGVzOwogCiBleHRlcm4g dW5zaWduZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIApkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9u LmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpp bmRleCA4NmNhZjZjMzk4YmUuLjdiZDQxZWI0NzVlMyAxMDA2NDQKLS0tIGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKKysrIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKQEAgLTE1 Niw2ICsxNTYsOSBAQCBzdHJ1Y3QgdHJhbnNhY3Rpb24KIAkvKiBDb25uZWN0 aW9uLWxvY2FsIGlkZW50aWZpZXIgZm9yIHRoaXMgdHJhbnNhY3Rpb24uICov CiAJdWludDMyX3QgaWQ7CiAKKwkvKiBOb2RlIGNvdW50ZXIuICovCisJdW5z aWduZWQgaW50IG5vZGVzOworCiAJLyogR2VuZXJhdGlvbiB3aGVuIHRyYW5z YWN0aW9uIHN0YXJ0ZWQuICovCiAJdWludDY0X3QgZ2VuZXJhdGlvbjsKIApA QCAtMjYwLDYgKzI2MywxMSBAQCBpbnQgYWNjZXNzX25vZGUoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAogCiAJaSA9IGZp bmRfYWNjZXNzZWRfbm9kZSh0cmFucywgbm9kZS0+bmFtZSk7CiAJaWYgKCFp KSB7CisJCWlmICh0cmFucy0+bm9kZXMgPj0gcXVvdGFfdHJhbnNfbm9kZXMg JiYKKwkJICAgIGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikpIHsKKwkJ CXJldCA9IEVOT1NQQzsKKwkJCWdvdG8gZXJyOworCQl9CiAJCWkgPSB0YWxs b2NfemVybyh0cmFucywgc3RydWN0IGFjY2Vzc2VkX25vZGUpOwogCQlpZiAo IWkpCiAJCQlnb3RvIG5vbWVtOwpAQCAtMjk3LDYgKzMwNSw3IEBAIGludCBh Y2Nlc3Nfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5v ZGUgKm5vZGUsCiAJCQkJaS0+dGFfbm9kZSA9IHRydWU7CiAJCQl9CiAJCX0K KwkJdHJhbnMtPm5vZGVzKys7CiAJCWxpc3RfYWRkX3RhaWwoJmktPmxpc3Qs ICZ0cmFucy0+YWNjZXNzZWQpOwogCX0KIApkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmggYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uaAppbmRleCAwMDkzY2FjODA3 ZTMuLmUzY2JkNmIyMzA5NSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKKysrIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKQEAgLTM5LDggKzM5LDggQEAgdm9p ZCB0cmFuc2FjdGlvbl9lbnRyeV9pbmMoc3RydWN0IHRyYW5zYWN0aW9uICp0 cmFucywgdW5zaWduZWQgaW50IGRvbWlkKTsKIHZvaWQgdHJhbnNhY3Rpb25f ZW50cnlfZGVjKHN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnMsIHVuc2lnbmVk IGludCBkb21pZCk7CiAKIC8qIFRoaXMgbm9kZSB3YXMgYWNjZXNzZWQuICov Ci1pbnQgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBub2RlICpub2RlLAotICAgICAgICAgICAgICAgIGVudW0gbm9kZV9h Y2Nlc3NfdHlwZSB0eXBlLCBUREJfREFUQSAqa2V5KTsKK2ludCBfX211c3Rf Y2hlY2sgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBub2RlICpub2RlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBlbnVtIG5vZGVfYWNjZXNzX3R5cGUgdHlwZSwgVERCX0RBVEEgKmtleSk7 CiAKIC8qIFF1ZXVlIHdhdGNoZXMgZm9yIGEgbW9kaWZpZWQgbm9kZS4gKi8K IHZvaWQgcXVldWVfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3QgY2hhciAqbmFtZSwgYm9vbCB3YXRjaF9leGFjdCk7Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-10.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-10.patch" Content-Transfer-Encoding: base64 RnJvbSA3MzI3ODA2YTgzMDcxYWY0MTA1ZThjMzIzY2NlYTViNGQ0MzlkZGM4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IG1vdmUgdGhl IGNhbGwgb2Ygc2V0dXBfc3RydWN0dXJlKCkgdG8gZG9tMAogaW50cm9kdWN0 aW9uCgpTZXR0aW5nIHVwIHRoZSBiYXNpYyBzdHJ1Y3R1cmUgd2hlbiBpbnRy b2R1Y2luZyBkb20wIGhhcyB0aGUgYWR2YW50YWdlCnRvIGJlIGFibGUgdG8g YWRkIHByb3BlciBub2RlIG1lbW9yeSBhY2NvdW50aW5nIGZvciB0aGUgYWRk ZWQgbm9kZXMKbGF0ZXIuCgpUaGlzIG1ha2VzIGl0IHBvc3NpYmxlIHRvIGRv IHByb3BlciBub2RlIGFjY291bnRpbmcsIHRvby4KCkFuIGFkZGl0aW9uYWwg cmVxdWlyZW1lbnQgdG8gbWFrZSB0aGF0IHdvcmsgZmluZSBpcyB0byBjb3Jy ZWN0IHRoZQpvd25lciBvZiB0aGUgY3JlYXRlZCBub2RlcyB0byBiZSBkb20w X2RvbWlkIGluc3RlYWQgb2YgZG9taWQgMC4KClRoaXMgaXMgcGFydCBvZiBY U0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMK aW5kZXggMDUwZDZmNjUxYWU5Li41MWFmNzQzOTBjYmUgMTAwNjQ0Ci0tLSBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtMTk0MCw3ICsxOTQwLDgg QEAgc3RhdGljIGludCB0ZGJfZmxhZ3M7CiBzdGF0aWMgdm9pZCBtYW51YWxf bm9kZShjb25zdCBjaGFyICpuYW1lLCBjb25zdCBjaGFyICpjaGlsZCkKIHsK IAlzdHJ1Y3Qgbm9kZSAqbm9kZTsKLQlzdHJ1Y3QgeHNfcGVybWlzc2lvbnMg cGVybXMgPSB7IC5pZCA9IDAsIC5wZXJtcyA9IFhTX1BFUk1fTk9ORSB9Owor CXN0cnVjdCB4c19wZXJtaXNzaW9ucyBwZXJtcyA9IHsgLmlkID0gZG9tMF9k b21pZCwKKwkJCQkJLnBlcm1zID0gWFNfUEVSTV9OT05FIH07CiAKIAlub2Rl ID0gdGFsbG9jX3plcm8oTlVMTCwgc3RydWN0IG5vZGUpOwogCWlmICghbm9k ZSkKQEAgLTE5NzksNyArMTk4MCw3IEBAIHN0YXRpYyB2b2lkIHRkYl9sb2dn ZXIoVERCX0NPTlRFWFQgKnRkYiwgaW50IGxldmVsLCBjb25zdCBjaGFyICog Zm10LCAuLi4pCiAJfQogfQogCi1zdGF0aWMgdm9pZCBzZXR1cF9zdHJ1Y3R1 cmUoYm9vbCBsaXZlX3VwZGF0ZSkKK3ZvaWQgc2V0dXBfc3RydWN0dXJlKGJv b2wgbGl2ZV91cGRhdGUpCiB7CiAJY2hhciAqdGRibmFtZTsKIApAQCAtMjAw Miw2ICsyMDAzLDcgQEAgc3RhdGljIHZvaWQgc2V0dXBfc3RydWN0dXJlKGJv b2wgbGl2ZV91cGRhdGUpCiAJCW1hbnVhbF9ub2RlKCIvIiwgInRvb2wiKTsK IAkJbWFudWFsX25vZGUoIi90b29sIiwgInhlbnN0b3JlZCIpOwogCQltYW51 YWxfbm9kZSgiL3Rvb2wveGVuc3RvcmVkIiwgTlVMTCk7CisJCWRvbWFpbl9l bnRyeV9maXgoZG9tMF9kb21pZCwgMywgdHJ1ZSk7CiAJfQogCiAJY2hlY2tf c3RvcmUoKTsKQEAgLTI1MTIsOSArMjUxNCw2IEBAIGludCBtYWluKGludCBh cmdjLCBjaGFyICphcmd2W10pCiAKIAlpbml0X3BpcGUocmVvcGVuX2xvZ19w aXBlKTsKIAotCS8qIFNldHVwIHRoZSBkYXRhYmFzZSAqLwotCXNldHVwX3N0 cnVjdHVyZShsaXZlX3VwZGF0ZSk7Ci0KIAkvKiBMaXN0ZW4gdG8gaHlwZXJ2 aXNvci4gKi8KIAlpZiAoIW5vX2RvbWFpbl9pbml0ICYmICFsaXZlX3VwZGF0 ZSkgewogCQlkb21haW5faW5pdCgtMSk7CmRpZmYgLS1naXQgYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuaAppbmRleCAxYjNiZDVjYTU2M2EuLjQ1OTY5OGQ4NDA3 YSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUu aAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCkBAIC0y MjQsNiArMjI0LDcgQEAgaW50IHdyaXRlX25vZGVfcmF3KHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5LCBzdHJ1Y3Qgbm9kZSAqbm9k ZSwKIHN0cnVjdCBub2RlICpyZWFkX25vZGUoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAkJICAgICAgIGNvbnN0IGNoYXIg Km5hbWUpOwogCit2b2lkIHNldHVwX3N0cnVjdHVyZShib29sIGxpdmVfdXBk YXRlKTsKIHN0cnVjdCBjb25uZWN0aW9uICpuZXdfY29ubmVjdGlvbihjb25u d3JpdGVmbl90ICp3cml0ZSwgY29ubnJlYWRmbl90ICpyZWFkKTsKIHN0cnVj dCBjb25uZWN0aW9uICpnZXRfY29ubmVjdGlvbl9ieV9pZCh1bnNpZ25lZCBp bnQgY29ubl9pZCk7CiB2b2lkIGNoZWNrX3N0b3JlKHZvaWQpOwpkaWZmIC0t Z2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IDNjMjc5NzNm YjgzNi4uMGRkNzVhNmEyMTk0IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2RvbWFpbi5jCkBAIC00NzYsNiArNDc2LDkgQEAgc3RhdGljIHN0 cnVjdCBkb21haW4gKmludHJvZHVjZV9kb21haW4oY29uc3Qgdm9pZCAqY3R4 LAogCQl9CiAJCWRvbWFpbi0+aW50ZXJmYWNlID0gaW50ZXJmYWNlOwogCisJ CWlmIChpc19tYXN0ZXJfZG9tYWluKQorCQkJc2V0dXBfc3RydWN0dXJlKHJl c3RvcmUpOworCiAJCS8qIE5vdyBkb21haW4gYmVsb25ncyB0byBpdHMgY29u bmVjdGlvbi4gKi8KIAkJdGFsbG9jX3N0ZWFsKGRvbWFpbi0+Y29ubiwgZG9t YWluKTsKIAo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-11.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-11.patch" Content-Transfer-Encoding: base64 RnJvbSBlOWRkNjA1MzhhYmU3MTkzZWFmMmM1ZWI3MmNjMWYxODc0OWU3YzFh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBpbmZy YXN0cnVjdHVyZSB0byBrZWVwIHRyYWNrIG9mIHBlciBkb21haW4gbWVtb3J5 CiB1c2FnZQoKVGhlIGFtb3VudCBvZiBtZW1vcnkgYSBkb21haW4gY2FuIGNv bnN1bWUgaW4gWGVuc3RvcmUgaXMgbGltaXRlZCBieQp2YXJpb3VzIHF1b3Rh IHRvZGF5LCBidXQgZXZlbiB3aXRoIHNhbmUgcXVvdGEgYSBkb21haW4gY2Fu IHN0aWxsCmNvbnN1bWUgcmF0aGVyIGxhcmdlIG1lbW9yeSBxdWFudGl0aWVz LgoKQWRkIHRoZSBpbmZyYXN0cnVjdHVyZSBmb3Iga2VlcGluZyB0cmFjayBv ZiB0aGUgYW1vdW50IG9mIG1lbW9yeSBhCmRvbWFpbiBpcyBjb25zdW1pbmcg aW4gWGVuc3RvcmUuIE5vdGUgdGhhdCB0aGlzIGlzIG9ubHkgdGhlIG1lbW9y eSBhCmRvbWFpbiBoYXMgZGlyZWN0IGNvbnRyb2wgb3Zlciwgc28gYW55IGlu dGVybmFsIGFkbWluaXN0cmF0aW9uIGRhdGEKbmVlZGVkIGJ5IFhlbnN0b3Jl IG9ubHkgaXMgbm90IGJlaW5nIGFjY291bnRlZCBmb3IuCgpUaGVyZSBhcmUg dHdvIHF1b3RhcyBkZWZpbmVkOiBhIHNvZnQgcXVvdGEgd2hpY2ggd2lsbCBy ZXN1bHQgaW4gYQp3YXJuaW5nIGlzc3VlZCB2aWEgc3lzbG9nKCkgd2hlbiBp dCBpcyBleGNlZWRlZCwgYW5kIGEgaGFyZCBxdW90YQpyZXN1bHRpbmcgaW4g YSBzdG9wIG9mIGFjY2VwdGluZyBmdXJ0aGVyIHJlcXVlc3RzIG9yIHdhdGNo IGV2ZW50cyBhcwpsb25nIGFzIHRoZSBoYXJkIHF1b3RhIHdvdWxkIGJlIHZp b2xhdGVkIGJ5IGFjY2VwdGluZyB0aG9zZS4KClNldHRpbmcgYW55IG9mIHRo b3NlIHF1b3RhcyB0byAwIHdpbGwgZGlzYWJsZSBpdC4KCkFzIGRlZmF1bHQg dmFsdWVzIHVzZSAyTUIgcGVyIGRvbWFpbiBmb3IgdGhlIHNvZnQgbGltaXQg KHRoaXMgYmFzaWNhbGx5CmNvdmVycyB0aGUgYWxsb3dlZCBjYXNlIHRvIGNy ZWF0ZSAxMDAwIG5vZGVzIG5lZWRpbmcgMmtCIGVhY2gpLCBhbmQKMi41TUIg Zm9yIHRoZSBoYXJkIGxpbWl0LgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYu CgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNv bT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwppbmRl eCA1MWFmNzQzOTBjYmUuLmVlYjBkODkzZThjMyAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0xMDksNiArMTA5LDggQEAgaW50 IHF1b3RhX25iX3Blcm1zX3Blcl9ub2RlID0gNTsKIGludCBxdW90YV90cmFu c19ub2RlcyA9IDEwMjQ7CiBpbnQgcXVvdGFfbWF4X3BhdGhfbGVuID0gWEVO U1RPUkVfUkVMX1BBVEhfTUFYOwogaW50IHF1b3RhX3JlcV9vdXRzdGFuZGlu ZyA9IDIwOworaW50IHF1b3RhX21lbW9yeV9wZXJfZG9tYWluX3NvZnQgPSAy ICogMTAyNCAqIDEwMjQ7IC8qIDIgTUIgKi8KK2ludCBxdW90YV9tZW1vcnlf cGVyX2RvbWFpbl9oYXJkID0gMiAqIDEwMjQgKiAxMDI0ICsgNTEyICogMTAy NDsgLyogMi41IE1CICovCiAKIHVuc2lnbmVkIGludCB0aW1lb3V0X3dhdGNo X2V2ZW50X21zZWMgPSAyMDAwMDsKIApAQCAtMjMwNCw3ICsyMzA2LDE0IEBA IHN0YXRpYyB2b2lkIHVzYWdlKHZvaWQpCiAiICAgICAgICAgICAgICAgICAg ICAgICAgICBxdW90YXMgYXJlOlxuIgogIiAgICAgICAgICAgICAgICAgICAg ICAgICAgdHJhbnNhY3Rpb24tbm9kZXM6IG51bWJlciBvZiBhY2Nlc3NlZCBu b2RlIHBlclxuIgogIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHRyYW5zYWN0aW9uXG4iCisiICAgICAgICAgICAgICAg ICAgICAgICAgICBtZW1vcnk6IHRvdGFsIHVzZWQgbWVtb3J5IHBlciBkb21h aW4gZm9yIG5vZGVzLFxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB0cmFuc2FjdGlvbnMsIHdhdGNoZXMgYW5kIHJlcXVlc3RzLCBh Ym92ZVxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3 aGljaCBYZW5zdG9yZSB3aWxsIHN0b3AgdGFsa2luZyB0byBkb21haW5cbiIK ICIgICAgICAgICAgICAgICAgICAgICAgICAgIG91dHN0YW5kaW5nOiBudW1i ZXIgb2Ygb3V0c3RhbmRpbmcgcmVxdWVzdHNcbiIKKyIgIC1xLCAtLXF1b3Rh LXNvZnQgPHdoYXQ+PTxuYj4gc2V0IGEgc29mdCBxdW90YSA8d2hhdD4gdG8g dGhlIHZhbHVlIDxuYj4sXG4iCisiICAgICAgICAgICAgICAgICAgICAgICAg ICBjYXVzaW5nIGEgd2FybmluZyB0byBiZSBpc3N1ZWQgdmlhIHN5c2xvZygp IGlmIHRoZVxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgbGltaXQg aXMgdmlvbGF0ZWQsIGFsbG93ZWQgcXVvdGFzIGFyZTpcbiIKKyIgICAgICAg ICAgICAgICAgICAgICAgICAgIG1lbW9yeTogc2VlIGFib3ZlXG4iCiAiICAt dywgLS10aW1lb3V0IDx3aGF0Pj08c2Vjb25kcz4gICBzZXQgdGhlIHRpbWVv dXQgaW4gc2Vjb25kcyBmb3IgPHdoYXQ+LFxuIgogIiAgICAgICAgICAgICAg ICAgICAgICAgICAgYWxsb3dlZCB0aW1lb3V0IGNhbmRpZGF0ZXMgYXJlOlxu IgogIiAgICAgICAgICAgICAgICAgICAgICAgICAgd2F0Y2gtZXZlbnQ6IHRp bWUgYSB3YXRjaC1ldmVudCBpcyBrZXB0IHBlbmRpbmdcbiIKQEAgLTIzMzEs NiArMjM0MCw3IEBAIHN0YXRpYyBzdHJ1Y3Qgb3B0aW9uIG9wdGlvbnNbXSA9 IHsKIAl7ICJwZXJtLW5iIiwgMSwgTlVMTCwgJ0EnIH0sCiAJeyAicGF0aC1t YXgiLCAxLCBOVUxMLCAnTScgfSwKIAl7ICJxdW90YSIsIDEsIE5VTEwsICdR JyB9LAorCXsgInF1b3RhLXNvZnQiLCAxLCBOVUxMLCAncScgfSwKIAl7ICJ0 aW1lb3V0IiwgMSwgTlVMTCwgJ3cnIH0sCiAJeyAibm8tcmVjb3ZlcnkiLCAw LCBOVUxMLCAnUicgfSwKIAl7ICJpbnRlcm5hbC1kYiIsIDAsIE5VTEwsICdJ JyB9LApAQCAtMjM3OSw3ICsyMzg5LDcgQEAgc3RhdGljIHZvaWQgc2V0X3Rp bWVvdXQoY29uc3QgY2hhciAqYXJnKQogCQliYXJmKCJ1bmtub3duIHRpbWVv dXQgXCIlc1wiXG4iLCBhcmcpOwogfQogCi1zdGF0aWMgdm9pZCBzZXRfcXVv dGEoY29uc3QgY2hhciAqYXJnKQorc3RhdGljIHZvaWQgc2V0X3F1b3RhKGNv bnN0IGNoYXIgKmFyZywgYm9vbCBzb2Z0KQogewogCWNvbnN0IGNoYXIgKmVx ID0gc3RyY2hyKGFyZywgJz0nKTsKIAlpbnQgdmFsOwpAQCAtMjM4NywxMSAr MjM5NywxNiBAQCBzdGF0aWMgdm9pZCBzZXRfcXVvdGEoY29uc3QgY2hhciAq YXJnKQogCWlmICghZXEpCiAJCWJhcmYoInF1b3RhcyBtdXN0IGJlIHNwZWNp ZmllZCB2aWEgPHdoYXQ+PTxuYj5cbiIpOwogCXZhbCA9IGdldF9vcHR2YWxf aW50KGVxICsgMSk7Ci0JaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJvdXRzdGFu ZGluZyIpKQorCWlmICh3aGF0X21hdGNoZXMoYXJnLCAib3V0c3RhbmRpbmci KSAmJiAhc29mdCkKIAkJcXVvdGFfcmVxX291dHN0YW5kaW5nID0gdmFsOwot CWVsc2UgaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJ0cmFuc2FjdGlvbi1ub2Rl cyIpKQorCWVsc2UgaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJ0cmFuc2FjdGlv bi1ub2RlcyIpICYmICFzb2Z0KQogCQlxdW90YV90cmFuc19ub2RlcyA9IHZh bDsKLQllbHNlCisJZWxzZSBpZiAod2hhdF9tYXRjaGVzKGFyZywgIm1lbW9y eSIpKSB7CisJCWlmIChzb2Z0KQorCQkJcXVvdGFfbWVtb3J5X3Blcl9kb21h aW5fc29mdCA9IHZhbDsKKwkJZWxzZQorCQkJcXVvdGFfbWVtb3J5X3Blcl9k b21haW5faGFyZCA9IHZhbDsKKwl9IGVsc2UKIAkJYmFyZigidW5rbm93biBx dW90YSBcIiVzXCJcbiIsIGFyZyk7CiB9CiAKQEAgLTI0MDksNyArMjQyNCw3 IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAJb3JpZ19h cmdjID0gYXJnYzsKIAlvcmlnX2FyZ3YgPSBhcmd2OwogCi0Jd2hpbGUgKChv cHQgPSBnZXRvcHRfbG9uZyhhcmdjLCBhcmd2LCAiREU6RjpITlBTOnQ6QTpN OlE6VDpSVlc6dzpVIiwKKwl3aGlsZSAoKG9wdCA9IGdldG9wdF9sb25nKGFy Z2MsIGFyZ3YsICJERTpGOkhOUFM6dDpBOk06UTpxOlQ6UlZXOnc6VSIsCiAJ CQkJICBvcHRpb25zLCBOVUxMKSkgIT0gLTEpIHsKIAkJc3dpdGNoIChvcHQp IHsKIAkJY2FzZSAnRCc6CkBAIC0yNDU5LDcgKzI0NzQsMTAgQEAgaW50IG1h aW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAkJCQkJCSBxdW90YV9tYXhf cGF0aF9sZW4pOwogCQkJYnJlYWs7CiAJCWNhc2UgJ1EnOgotCQkJc2V0X3F1 b3RhKG9wdGFyZyk7CisJCQlzZXRfcXVvdGEob3B0YXJnLCBmYWxzZSk7CisJ CQlicmVhazsKKwkJY2FzZSAncSc6CisJCQlzZXRfcXVvdGEob3B0YXJnLCB0 cnVlKTsKIAkJCWJyZWFrOwogCQljYXNlICd3JzoKIAkJCXNldF90aW1lb3V0 KG9wdGFyZyk7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApp bmRleCA0NTk2OThkODQwN2EuLjJmYjM3ZGJmZTg0NyAxMDA2NDQKLS0tIGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAorKysgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCkBAIC0yNjMsNiArMjYzLDggQEAg ZXh0ZXJuIGludCBwcml2X2RvbWlkOwogZXh0ZXJuIGludCBxdW90YV9uYl9l bnRyeV9wZXJfZG9tYWluOwogZXh0ZXJuIGludCBxdW90YV9yZXFfb3V0c3Rh bmRpbmc7CiBleHRlcm4gaW50IHF1b3RhX3RyYW5zX25vZGVzOworZXh0ZXJu IGludCBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9zb2Z0OworZXh0ZXJuIGlu dCBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJkOwogCiBleHRlcm4gdW5z aWduZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIApkaWZmIC0t Z2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IDBkZDc1YTZh MjE5NC4uZWM1NDJkZjZhNjdlIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2RvbWFpbi5jCkBAIC03Niw2ICs3NiwxMyBAQCBzdHJ1Y3QgZG9t YWluCiAJLyogbnVtYmVyIG9mIGVudHJ5IGZyb20gdGhpcyBkb21haW4gaW4g dGhlIHN0b3JlICovCiAJaW50IG5iZW50cnk7CiAKKwkvKiBBbW91bnQgb2Yg bWVtb3J5IGFsbG9jYXRlZCBmb3IgdGhpcyBkb21haW4uICovCisJaW50IG1l bW9yeTsKKwlib29sIHNvZnRfcXVvdGFfcmVwb3J0ZWQ7CisJYm9vbCBoYXJk X3F1b3RhX3JlcG9ydGVkOworCXRpbWVfdCBtZW1fbGFzdF9tc2c7CisjZGVm aW5lIE1FTV9XQVJOX01JTlRJTUVfU0VDIDEwCisKIAkvKiBudW1iZXIgb2Yg d2F0Y2ggZm9yIHRoaXMgZG9tYWluICovCiAJaW50IG5id2F0Y2g7CiAKQEAg LTI5Niw2ICszMDMsOSBAQCBib29sIGRvbWFpbl9jYW5fcmVhZChzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubikKIAkJCXJldHVybiBmYWxzZTsKIAkJaWYgKGNv bm4tPmRvbWFpbi0+bmJvdXRzdGFuZGluZyA+PSBxdW90YV9yZXFfb3V0c3Rh bmRpbmcpCiAJCQlyZXR1cm4gZmFsc2U7CisJCWlmIChjb25uLT5kb21haW4t Pm1lbW9yeSA+PSBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJkICYmCisJ CSAgICBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJkKQorCQkJcmV0dXJu IGZhbHNlOwogCX0KIAogCWlmIChjb25uLT5pc19pZ25vcmVkKQpAQCAtOTU2 LDYgKzk2Niw4OSBAQCBpbnQgZG9tYWluX2VudHJ5KHN0cnVjdCBjb25uZWN0 aW9uICpjb25uKQogCQk6IDA7CiB9CiAKK3N0YXRpYyBib29sIGRvbWFpbl9j aGtfcXVvdGEoc3RydWN0IGRvbWFpbiAqZG9tYWluLCBpbnQgbWVtKQorewor CXRpbWVfdCBub3c7CisKKwlpZiAoIWRvbWFpbiB8fCAhZG9taWRfaXNfdW5w cml2aWxlZ2VkKGRvbWFpbi0+ZG9taWQpIHx8CisJICAgIChkb21haW4tPmNv bm4gJiYgZG9tYWluLT5jb25uLT5pc19pZ25vcmVkKSkKKwkJcmV0dXJuIGZh bHNlOworCisJbm93ID0gdGltZShOVUxMKTsKKworCWlmIChtZW0gPj0gcXVv dGFfbWVtb3J5X3Blcl9kb21haW5faGFyZCAmJgorCSAgICBxdW90YV9tZW1v cnlfcGVyX2RvbWFpbl9oYXJkKSB7CisJCWlmIChkb21haW4tPmhhcmRfcXVv dGFfcmVwb3J0ZWQpCisJCQlyZXR1cm4gdHJ1ZTsKKwkJc3lzbG9nKExPR19F UlIsICJEb21haW4gJXUgZXhjZWVkcyBoYXJkIG1lbW9yeSBxdW90YSwgWGVu c3RvcmUgaW50ZXJmYWNlIHRvIGRvbWFpbiBzdGFsbGVkXG4iLAorCQkgICAg ICAgZG9tYWluLT5kb21pZCk7CisJCWRvbWFpbi0+bWVtX2xhc3RfbXNnID0g bm93OworCQlkb21haW4tPmhhcmRfcXVvdGFfcmVwb3J0ZWQgPSB0cnVlOwor CQlyZXR1cm4gdHJ1ZTsKKwl9CisKKwlpZiAobm93IC0gZG9tYWluLT5tZW1f bGFzdF9tc2cgPj0gTUVNX1dBUk5fTUlOVElNRV9TRUMpIHsKKwkJaWYgKGRv bWFpbi0+aGFyZF9xdW90YV9yZXBvcnRlZCkgeworCQkJZG9tYWluLT5tZW1f bGFzdF9tc2cgPSBub3c7CisJCQlkb21haW4tPmhhcmRfcXVvdGFfcmVwb3J0 ZWQgPSBmYWxzZTsKKwkJCXN5c2xvZyhMT0dfSU5GTywgIkRvbWFpbiAldSBi ZWxvdyBoYXJkIG1lbW9yeSBxdW90YSBhZ2FpblxuIiwKKwkJCSAgICAgICBk b21haW4tPmRvbWlkKTsKKwkJfQorCQlpZiAobWVtID49IHF1b3RhX21lbW9y eV9wZXJfZG9tYWluX3NvZnQgJiYKKwkJICAgIHF1b3RhX21lbW9yeV9wZXJf ZG9tYWluX3NvZnQgJiYKKwkJICAgICFkb21haW4tPnNvZnRfcXVvdGFfcmVw b3J0ZWQpIHsKKwkJCWRvbWFpbi0+bWVtX2xhc3RfbXNnID0gbm93OworCQkJ ZG9tYWluLT5zb2Z0X3F1b3RhX3JlcG9ydGVkID0gdHJ1ZTsKKwkJCXN5c2xv ZyhMT0dfV0FSTklORywgIkRvbWFpbiAldSBleGNlZWRzIHNvZnQgbWVtb3J5 IHF1b3RhXG4iLAorCQkJICAgICAgIGRvbWFpbi0+ZG9taWQpOworCQl9CisJ CWlmIChtZW0gPCBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9zb2Z0ICYmCisJ CSAgICBkb21haW4tPnNvZnRfcXVvdGFfcmVwb3J0ZWQpIHsKKwkJCWRvbWFp bi0+bWVtX2xhc3RfbXNnID0gbm93OworCQkJZG9tYWluLT5zb2Z0X3F1b3Rh X3JlcG9ydGVkID0gZmFsc2U7CisJCQlzeXNsb2coTE9HX0lORk8sICJEb21h aW4gJXUgYmVsb3cgc29mdCBtZW1vcnkgcXVvdGEgYWdhaW5cbiIsCisJCQkg ICAgICAgZG9tYWluLT5kb21pZCk7CisJCX0KKworCX0KKworCXJldHVybiBm YWxzZTsKK30KKworaW50IGRvbWFpbl9tZW1vcnlfYWRkKHVuc2lnbmVkIGlu dCBkb21pZCwgaW50IG1lbSwgYm9vbCBub19xdW90YV9jaGVjaykKK3sKKwlz dHJ1Y3QgZG9tYWluICpkb21haW47CisKKwlkb21haW4gPSBmaW5kX2RvbWFp bl9zdHJ1Y3QoZG9taWQpOworCWlmIChkb21haW4pIHsKKwkJLyoKKwkJICog ZG9tYWluX2Noa19xdW90YSgpIHdpbGwgcHJpbnQgd2FybmluZyBhbmQgYWxz byBzdG9yZSB3aGV0aGVyCisJCSAqIHRoZSBzb2Z0L2hhcmQgcXVvdGEgaGFz IGJlZW4gaGl0LiBTbyBjaGVjayBub19xdW90YV9jaGVjaworCQkgKiAqYWZ0 ZXIqLgorCQkgKi8KKwkJaWYgKGRvbWFpbl9jaGtfcXVvdGEoZG9tYWluLCBk b21haW4tPm1lbW9yeSArIG1lbSkgJiYKKwkJICAgICFub19xdW90YV9jaGVj aykKKwkJCXJldHVybiBFTk9NRU07CisJCWRvbWFpbi0+bWVtb3J5ICs9IG1l bTsKKwl9IGVsc2UgeworCQkvKgorCQkgKiBUaGUgZG9tYWluIHRoZSBtZW1v cnkgaXMgdG8gYmUgYWNjb3VudGVkIGZvciBzaG91bGQgYWx3YXlzCisJCSAq IGV4aXN0LCBhcyBhY2NvdW50aW5nIGlzIGRvbmUgZWl0aGVyIGZvciBhIGRv bWFpbiByZWxhdGVkIHRvCisJCSAqIHRoZSBjdXJyZW50IGNvbm5lY3Rpb24s IG9yIGZvciB0aGUgZG9tYWluIG93bmluZyBhIG5vZGUKKwkJICogKHdoaWNo IGlzIGFsd2F5cyBleGlzdGluZywgYXMgdGhlIG93bmVyIG9mIHRoZSBub2Rl IGlzCisJCSAqIHRlc3RlZCB0byBleGlzdCBhbmQgcmVwbGFjZWQgYnkgZG9t aWQgMCBpZiBub3QpLgorCQkgKiBTbyBub3QgZmluZGluZyB0aGUgcmVsYXRl ZCBkb21haW4gTVVTVCBiZSBhbiBlcnJvciBpbiB0aGUKKwkJICogZGF0YSBi YXNlLgorCQkgKi8KKwkJZXJybm8gPSBFTk9FTlQ7CisJCWNvcnJ1cHQoTlVM TCwgIkFjY291bnRpbmcgY2FsbGVkIGZvciBub24tZXhpc3RpbmcgZG9tYWlu ICV1XG4iLAorCQkJZG9taWQpOworCQlyZXR1cm4gRU5PRU5UOworCX0KKwor CXJldHVybiAwOworfQorCiB2b2lkIGRvbWFpbl93YXRjaF9pbmMoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4pCiB7CiAJaWYgKCFjb25uIHx8ICFjb25uLT5k b21haW4pCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgK aW5kZXggY2NlMTNkMTRmMDE2Li41NzFhYTQ2ZDE1OGUgMTAwNjQ0Ci0tLSBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaAorKysgYi90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgKQEAgLTY1LDYgKzY1LDI2 IEBAIGludCBkb21haW5fZW50cnlfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCBzdHJ1Y3Qgbm9kZSAqKTsKIHZvaWQgZG9tYWluX2VudHJ5X2RlYyhz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKik7CiBpbnQg ZG9tYWluX2VudHJ5X2ZpeCh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBudW0s IGJvb2wgdXBkYXRlKTsKIGludCBkb21haW5fZW50cnkoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pOworaW50IGRvbWFpbl9tZW1vcnlfYWRkKHVuc2lnbmVk IGludCBkb21pZCwgaW50IG1lbSwgYm9vbCBub19xdW90YV9jaGVjayk7CisK Ky8qCisgKiBkb21haW5fbWVtb3J5X2FkZF9jaGsoKTogdG8gYmUgdXNlZCB3 aGVuIG1lbW9yeSBxdW90YSBzaG91bGQgYmUgY2hlY2tlZC4KKyAqIE5vdCB0 byBiZSB1c2VkIHdoZW4gc3BlY2lmeWluZyBhIG5lZ2F0aXZlIG1lbSB2YWx1 ZSwgYXMgbG93ZXJpbmcgdGhlIHVzZWQKKyAqIG1lbW9yeSBzaG91bGQgYWx3 YXlzIGJlIGFsbG93ZWQuCisgKi8KK3N0YXRpYyBpbmxpbmUgaW50IGRvbWFp bl9tZW1vcnlfYWRkX2Noayh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBtZW0p Cit7CisJcmV0dXJuIGRvbWFpbl9tZW1vcnlfYWRkKGRvbWlkLCBtZW0sIGZh bHNlKTsKK30KKy8qCisgKiBkb21haW5fbWVtb3J5X2FkZF9ub2NoaygpOiB0 byBiZSB1c2VkIHdoZW4gbWVtb3J5IHF1b3RhIHNob3VsZCBub3QgYmUKKyAq IGNoZWNrZWQsIGUuZy4gd2hlbiBsb3dlcmluZyBtZW1vcnkgdXNhZ2UsIG9y IGluIGFuIGVycm9yIGNhc2UgZm9yIHVuZG9pbmcKKyAqIGEgcHJldmlvdXMg bWVtb3J5IGFkanVzdG1lbnQuCisgKi8KK3N0YXRpYyBpbmxpbmUgdm9pZCBk b21haW5fbWVtb3J5X2FkZF9ub2Noayh1bnNpZ25lZCBpbnQgZG9taWQsIGlu dCBtZW0pCit7CisJZG9tYWluX21lbW9yeV9hZGQoZG9taWQsIG1lbSwgdHJ1 ZSk7Cit9CiB2b2lkIGRvbWFpbl93YXRjaF9pbmMoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4pOwogdm9pZCBkb21haW5fd2F0Y2hfZGVjKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uKTsKIGludCBkb21haW5fd2F0Y2goc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pOwo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-12.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-12.patch" Content-Transfer-Encoding: base64 RnJvbSA0YjQwMzI2OGQ5ZDA3OGE4YmZkMjk1YjZhNDM3MzVhOGNiZWQ5MzQx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3IgcmVzcG9uc2VzCgpBZGQgdGhlIG1lbW9yeSBh Y2NvdW50aW5nIGZvciBxdWV1ZWQgcmVzcG9uc2VzLgoKSW4gY2FzZSBhZGRp bmcgYSB3YXRjaCBldmVudCBmb3IgYSBndWVzdCBpcyBjYXVzaW5nIHRoZSBo YXJkIG1lbW9yeQpxdW90YSBvZiB0aGF0IGd1ZXN0IHRvIGJlIHZpb2xhdGVk LCB0aGUgZXZlbnQgaXMgZHJvcHBlZC4gVGhpcyB3aWxsCmVuc3VyZSB0aGF0 IGl0IGlzIGltcG9zc2libGUgdG8gZHJpdmUgYW5vdGhlciBndWVzdCBwYXN0 IGl0cyBtZW1vcnkKcXVvdGEgYnkgZ2VuZXJhdGluZyBpbnNhbmUgYW1vdW50 cyBvZiBldmVudHMgZm9yIHRoYXQgZ3Vlc3QuIFRoaXMgaXMKZXNwZWNpYWxs eSBpbXBvcnRhbnQgZm9yIHByb3RlY3RpbmcgZHJpdmVyIGRvbWFpbnMgZnJv bSB0aGF0IGF0dGFjawp2ZWN0b3IuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMy NiAvIENWRS0yMDIyLTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4g R3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKaW5kZXggZWViMGQ4OTNlOGMzLi4yZTAyYjU3N2M5 MTIgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAt MjYwLDYgKzI2MCw4IEBAIHN0YXRpYyB2b2lkIGZyZWVfYnVmZmVyZWRfZGF0 YShzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqb3V0LAogCQl9CiAJfQogCisJZG9t YWluX21lbW9yeV9hZGRfbm9jaGsoY29ubi0+aWQsIC1vdXQtPmhkci5tc2cu bGVuIC0gc2l6ZW9mKG91dC0+aGRyKSk7CisKIAlpZiAob3V0LT5oZHIubXNn LnR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQpIHsKIAkJcmVxID0gb3V0LT5wZW5k LnJlcTsKIAkJaWYgKHJlcSkgewpAQCAtOTA0LDExICs5MDYsMTQgQEAgdm9p ZCBzZW5kX3JlcGx5KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBlbnVtIHhz ZF9zb2NrbXNnX3R5cGUgdHlwZSwKIAliZGF0YS0+dGltZW91dF9tc2VjID0g MDsKIAliZGF0YS0+d2F0Y2hfZXZlbnQgPSBmYWxzZTsKIAotCWlmIChsZW4g PD0gREVGQVVMVF9CVUZGRVJfU0laRSkKKwlpZiAobGVuIDw9IERFRkFVTFRf QlVGRkVSX1NJWkUpIHsKIAkJYmRhdGEtPmJ1ZmZlciA9IGJkYXRhLT5kZWZh dWx0X2J1ZmZlcjsKLQllbHNlIHsKKwkJLyogRG9uJ3QgY2hlY2sgcXVvdGEs IHBhdGggbWlnaHQgYmUgdXNlZCBmb3IgcmV0dXJuaW5nIGVycm9yLiAqLwor CQlkb21haW5fbWVtb3J5X2FkZF9ub2Noayhjb25uLT5pZCwgbGVuICsgc2l6 ZW9mKGJkYXRhLT5oZHIpKTsKKwl9IGVsc2UgewogCQliZGF0YS0+YnVmZmVy ID0gdGFsbG9jX2FycmF5KGJkYXRhLCBjaGFyLCBsZW4pOwotCQlpZiAoIWJk YXRhLT5idWZmZXIpIHsKKwkJaWYgKCFiZGF0YS0+YnVmZmVyIHx8CisJCSAg ICBkb21haW5fbWVtb3J5X2FkZF9jaGsoY29ubi0+aWQsIGxlbiArIHNpemVv ZihiZGF0YS0+aGRyKSkpIHsKIAkJCXNlbmRfZXJyb3IoY29ubiwgRU5PTUVN KTsKIAkJCXJldHVybjsKIAkJfQpAQCAtOTczLDYgKzk3OCwxMSBAQCB2b2lk IHNlbmRfZXZlbnQoc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKnJlcSwgc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sCiAJCX0KIAl9CiAKKwlpZiAoZG9tYWluX21l bW9yeV9hZGRfY2hrKGNvbm4tPmlkLCBsZW4gKyBzaXplb2YoYmRhdGEtPmhk cikpKSB7CisJCXRhbGxvY19mcmVlKGJkYXRhKTsKKwkJcmV0dXJuOworCX0K KwogCWlmICh0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWMgJiYgZG9tYWluX2lz X3VucHJpdmlsZWdlZChjb25uKSkgewogCQliZGF0YS0+dGltZW91dF9tc2Vj ID0gZ2V0X25vd19tc2VjKCkgKyB0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWM7 CiAJCWlmICghY29ubi0+dGltZW91dF9tc2VjKQpAQCAtMjk0MCw2ICsyOTUw LDEyIEBAIHN0YXRpYyB2b2lkIGFkZF9idWZmZXJlZF9kYXRhKHN0cnVjdCBi dWZmZXJlZF9kYXRhICpiZGF0YSwKIAkgKi8KIAlpZiAoYmRhdGEtPmhkci5t c2cudHlwZSAhPSBYU19XQVRDSF9FVkVOVCkKIAkJZG9tYWluX291dHN0YW5k aW5nX2luYyhjb25uKTsKKwkvKgorCSAqIFdlIGFyZSByZXN0b3JpbmcgdGhl IHN0YXRlIGFmdGVyIExpdmUtVXBkYXRlIGFuZCB0aGUgbmV3IHF1b3RhIG1h eQorCSAqIGJlIHNtYWxsZXIuIFNvIGlnbm9yZSBpdC4gVGhlIGxpbWl0IHdp bGwgYmUgYXBwbGllZCBmb3IgYW55IHJlc291cmNlCisJICogYWZ0ZXIgdGhl IHN0YXRlIGhhcyBiZWVuIGZ1bGx5IHJlc3RvcmVkLgorCSAqLworCWRvbWFp bl9tZW1vcnlfYWRkX25vY2hrKGNvbm4tPmlkLCBsZW4gKyBzaXplb2YoYmRh dGEtPmhkcikpOwogfQogCiB2b2lkIHJlYWRfc3RhdGVfYnVmZmVyZWRfZGF0 YShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-13.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-13.patch" Content-Transfer-Encoding: base64 RnJvbSA2MWI2NGM0NTc0MzFiZTBhNDQ0YjJhNzcxYjc2NmJhZDNlNWFiZjgy IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3Igd2F0Y2hlcwoKQWRkIHRoZSBtZW1vcnkgYWNj b3VudGluZyBmb3IgcmVnaXN0ZXJlZCB3YXRjaGVzLgoKV2hlbiBhIHNvY2tl dCBjb25uZWN0aW9uIGlzIGRlc3Ryb3llZCwgdGhlIGFzc29jaWF0ZWQgd2F0 Y2hlcyBhcmUKcmVtb3ZlZCwgdG9vLiBJbiBvcmRlciB0byBrZWVwIG1lbW9y eSBhY2NvdW50aW5nIGNvcnJlY3QgdGhlIHdhdGNoZXMKbXVzdCBiZSByZW1v dmVkIGV4cGxpY2l0bHkgdmlhIGEgY2FsbCBvZiBjb25uX2RlbGV0ZV9hbGxf d2F0Y2hlcygpIGZyb20KZGVzdHJveV9jb25uKCkuCgpUaGlzIGlzIHBhcnQg b2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6 IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6 IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggMmUwMmI1NzdjOTEyLi5i MWE0NTc1OTI5YmQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuYwpAQCAtNDU3LDYgKzQ1Nyw3IEBAIHN0YXRpYyBpbnQgZGVzdHJveV9j b25uKHZvaWQgKl9jb25uKQogCX0KIAogCWNvbm5fZnJlZV9idWZmZXJlZF9k YXRhKGNvbm4pOworCWNvbm5fZGVsZXRlX2FsbF93YXRjaGVzKGNvbm4pOwog CWxpc3RfZm9yX2VhY2hfZW50cnkocmVxLCAmY29ubi0+cmVmX2xpc3QsIGxp c3QpCiAJCXJlcS0+b25fcmVmX2xpc3QgPSBmYWxzZTsKIApkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmMgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYwppbmRleCAxZDY2NGUzZDZiNzIu LjBkNTg1OGRmNWJkZCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX3dhdGNoLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X3dhdGNoLmMKQEAgLTIxMSw3ICsyMTEsNyBAQCBzdGF0aWMgaW50IGNoZWNr X3dhdGNoX3BhdGgoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZv aWQgKmN0eCwKIH0KIAogc3RhdGljIHN0cnVjdCB3YXRjaCAqYWRkX3dhdGNo KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjaGFyICpwYXRoLCBjaGFyICp0 b2tlbiwKLQkJCSAgICAgICBib29sIHJlbGF0aXZlKQorCQkJICAgICAgIGJv b2wgcmVsYXRpdmUsIGJvb2wgbm9fcXVvdGFfY2hlY2spCiB7CiAJc3RydWN0 IHdhdGNoICp3YXRjaDsKIApAQCAtMjIyLDYgKzIyMiw5IEBAIHN0YXRpYyBz dHJ1Y3Qgd2F0Y2ggKmFkZF93YXRjaChzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgY2hhciAqcGF0aCwgY2hhciAqdG9rZW4sCiAJd2F0Y2gtPnRva2VuID0g dGFsbG9jX3N0cmR1cCh3YXRjaCwgdG9rZW4pOwogCWlmICghd2F0Y2gtPm5v ZGUgfHwgIXdhdGNoLT50b2tlbikKIAkJZ290byBub21lbTsKKwlpZiAoZG9t YWluX21lbW9yeV9hZGQoY29ubi0+aWQsIHN0cmxlbihwYXRoKSArIHN0cmxl bih0b2tlbiksCisJCQkgICAgICBub19xdW90YV9jaGVjaykpCisJCWdvdG8g bm9tZW07CiAKIAlpZiAocmVsYXRpdmUpCiAJCXdhdGNoLT5yZWxhdGl2ZV9w YXRoID0gZ2V0X2ltcGxpY2l0X3BhdGgoY29ubik7CkBAIC0yNjUsNyArMjY4 LDcgQEAgaW50IGRvX3dhdGNoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJaWYgKGRvbWFpbl93YXRjaChj b25uKSA+IHF1b3RhX25iX3dhdGNoX3Blcl9kb21haW4pCiAJCXJldHVybiBF MkJJRzsKIAotCXdhdGNoID0gYWRkX3dhdGNoKGNvbm4sIHZlY1swXSwgdmVj WzFdLCByZWxhdGl2ZSk7CisJd2F0Y2ggPSBhZGRfd2F0Y2goY29ubiwgdmVj WzBdLCB2ZWNbMV0sIHJlbGF0aXZlLCBmYWxzZSk7CiAJaWYgKCF3YXRjaCkK IAkJcmV0dXJuIGVycm5vOwogCkBAIC0yOTYsNiArMjk5LDggQEAgaW50IGRv X3Vud2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZm ZXJlZF9kYXRhICppbikKIAlsaXN0X2Zvcl9lYWNoX2VudHJ5KHdhdGNoLCAm Y29ubi0+d2F0Y2hlcywgbGlzdCkgewogCQlpZiAoc3RyZXEod2F0Y2gtPm5v ZGUsIG5vZGUpICYmIHN0cmVxKHdhdGNoLT50b2tlbiwgdmVjWzFdKSkgewog CQkJbGlzdF9kZWwoJndhdGNoLT5saXN0KTsKKwkJCWRvbWFpbl9tZW1vcnlf YWRkX25vY2hrKGNvbm4tPmlkLCAtc3RybGVuKHdhdGNoLT5ub2RlKSAtCisJ CQkJCQkJICBzdHJsZW4od2F0Y2gtPnRva2VuKSk7CiAJCQl0YWxsb2NfZnJl ZSh3YXRjaCk7CiAJCQlkb21haW5fd2F0Y2hfZGVjKGNvbm4pOwogCQkJc2Vu ZF9hY2soY29ubiwgWFNfVU5XQVRDSCk7CkBAIC0zMTEsNiArMzE2LDggQEAg dm9pZCBjb25uX2RlbGV0ZV9hbGxfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlv biAqY29ubikKIAogCXdoaWxlICgod2F0Y2ggPSBsaXN0X3RvcCgmY29ubi0+ d2F0Y2hlcywgc3RydWN0IHdhdGNoLCBsaXN0KSkpIHsKIAkJbGlzdF9kZWwo JndhdGNoLT5saXN0KTsKKwkJZG9tYWluX21lbW9yeV9hZGRfbm9jaGsoY29u bi0+aWQsIC1zdHJsZW4od2F0Y2gtPm5vZGUpIC0KKwkJCQkJCSAgc3RybGVu KHdhdGNoLT50b2tlbikpOwogCQl0YWxsb2NfZnJlZSh3YXRjaCk7CiAJCWRv bWFpbl93YXRjaF9kZWMoY29ubik7CiAJfQpAQCAtMzczLDcgKzM4MCw3IEBA IHZvaWQgcmVhZF9zdGF0ZV93YXRjaChjb25zdCB2b2lkICpjdHgsIGNvbnN0 IHZvaWQgKnN0YXRlKQogCWlmICghcGF0aCkKIAkJYmFyZigiYWxsb2NhdGlv biBlcnJvciBmb3IgcmVhZCB3YXRjaCIpOwogCi0JaWYgKCFhZGRfd2F0Y2go Y29ubiwgcGF0aCwgdG9rZW4sIHJlbGF0aXZlKSkKKwlpZiAoIWFkZF93YXRj aChjb25uLCBwYXRoLCB0b2tlbiwgcmVsYXRpdmUsIHRydWUpKQogCQliYXJm KCJlcnJvciBhZGRpbmcgd2F0Y2giKTsKIH0KIAo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-14.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-14.patch" Content-Transfer-Encoding: base64 RnJvbSA4N2JmY2NhYzU3ZjlhZGRjMWE0NWViNzIyMmM1NDAyZTQ1ZDJhODhh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3Igbm9kZXMKCkFkZCB0aGUgbWVtb3J5IGFjY291 bnRpbmcgZm9yIFhlbnN0b3JlIG5vZGVzLiBJbiBvcmRlciB0byBtYWtlIHRo aXMKbm90IHRvbyBjb21wbGljYXRlZCBhbGxvdyBmb3Igc29tZSBzbG9wcGlu ZXNzIHdoZW4gd3JpdGluZyBub2Rlcy4gQW55CmhhcmQgcXVvdGEgdmlvbGF0 aW9uIHdpbGwgcmVzdWx0IGluIG5vIGZ1cnRoZXIgcmVxdWVzdHMgdG8gYmUg YWNjZXB0ZWQuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNiAvIENWRS0yMDIy LTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxs QGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKaW5kZXggYjFhNDU3NTkyOWJkLi5mMjdkNWMwMTAxYmMgMTAwNjQ0Ci0t LSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtNTU2LDYgKzU1Niwx MTcgQEAgdm9pZCBzZXRfdGRiX2tleShjb25zdCBjaGFyICpuYW1lLCBUREJf REFUQSAqa2V5KQogCWtleS0+ZHNpemUgPSBzdHJsZW4obmFtZSk7CiB9CiAK K3N0YXRpYyB2b2lkIGdldF9hY2NfZGF0YShUREJfREFUQSAqa2V5LCBzdHJ1 Y3Qgbm9kZV9hY2NvdW50X2RhdGEgKmFjYykKK3sKKwlUREJfREFUQSBvbGRf ZGF0YTsKKwlzdHJ1Y3QgeHNfdGRiX3JlY29yZF9oZHIgKmhkcjsKKworCWlm IChhY2MtPm1lbW9yeSA8IDApIHsKKwkJb2xkX2RhdGEgPSB0ZGJfZmV0Y2go dGRiX2N0eCwgKmtleSk7CisJCS8qIE5vIGNoZWNrIGZvciBlcnJvciwgYXMg dGhlIG5vZGUgbWlnaHQgbm90IGV4aXN0LiAqLworCQlpZiAob2xkX2RhdGEu ZHB0ciA9PSBOVUxMKSB7CisJCQlhY2MtPm1lbW9yeSA9IDA7CisJCX0gZWxz ZSB7CisJCQloZHIgPSAodm9pZCAqKW9sZF9kYXRhLmRwdHI7CisJCQlhY2Mt Pm1lbW9yeSA9IG9sZF9kYXRhLmRzaXplOworCQkJYWNjLT5kb21pZCA9IGhk ci0+cGVybXNbMF0uaWQ7CisJCX0KKwkJdGFsbG9jX2ZyZWUob2xkX2RhdGEu ZHB0cik7CisJfQorfQorCisvKgorICogUGVyLXRyYW5zYWN0aW9uIG5vZGVz IG5lZWQgdG8gYmUgYWNjb3VudGVkIGZvciB0aGUgdHJhbnNhY3Rpb24gb3du ZXIuCisgKiBUaG9zZSBub2RlcyBhcmUgc3RvcmVkIGluIHRoZSBkYXRhIGJh c2Ugd2l0aCB0aGUgdHJhbnNhY3Rpb24gZ2VuZXJhdGlvbgorICogY291bnQg cHJlcGVuZGVkIChlLmcuIDEyMy9sb2NhbC9kb21haW4vLi4uKS4gU28gdGVz dGluZyBmb3IgdGhlIG5vZGUncworICoga2V5IG5vdCB0byBzdGFydCB3aXRo ICIvIiBpcyBzdWZmaWNpZW50LgorICovCitzdGF0aWMgdW5zaWduZWQgaW50 IGdldF9hY2NfZG9taWQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9E QVRBICprZXksCisJCQkJICB1bnNpZ25lZCBpbnQgZG9taWQpCit7CisJcmV0 dXJuICghY29ubiB8fCBrZXktPmRwdHJbMF0gPT0gJy8nKSA/IGRvbWlkIDog Y29ubi0+aWQ7Cit9CisKK2ludCBkb190ZGJfd3JpdGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXksIFREQl9EQVRBICpkYXRhLAor CQkgc3RydWN0IG5vZGVfYWNjb3VudF9kYXRhICphY2MsIGJvb2wgbm9fcXVv dGFfY2hlY2spCit7CisJc3RydWN0IHhzX3RkYl9yZWNvcmRfaGRyICpoZHIg PSAodm9pZCAqKWRhdGEtPmRwdHI7CisJc3RydWN0IG5vZGVfYWNjb3VudF9k YXRhIG9sZF9hY2MgPSB7fTsKKwl1bnNpZ25lZCBpbnQgb2xkX2RvbWlkLCBu ZXdfZG9taWQ7CisJaW50IHJldDsKKworCWlmICghYWNjKQorCQlvbGRfYWNj Lm1lbW9yeSA9IC0xOworCWVsc2UKKwkJb2xkX2FjYyA9ICphY2M7CisKKwln ZXRfYWNjX2RhdGEoa2V5LCAmb2xkX2FjYyk7CisJb2xkX2RvbWlkID0gZ2V0 X2FjY19kb21pZChjb25uLCBrZXksIG9sZF9hY2MuZG9taWQpOworCW5ld19k b21pZCA9IGdldF9hY2NfZG9taWQoY29ubiwga2V5LCBoZHItPnBlcm1zWzBd LmlkKTsKKworCS8qCisJICogRG9uJ3QgY2hlY2sgZm9yIEVOT0VOVCwgYXMg d2Ugd2FudCB0byBiZSBhYmxlIHRvIHN3aXRjaCBvcnBoYW5lZAorCSAqIG5v ZGVzIHRvIG5ldyBvd25lcnMuCisJICovCisJaWYgKG9sZF9hY2MubWVtb3J5 KQorCQlkb21haW5fbWVtb3J5X2FkZF9ub2NoayhvbGRfZG9taWQsCisJCQkJ CS1vbGRfYWNjLm1lbW9yeSAtIGtleS0+ZHNpemUpOworCXJldCA9IGRvbWFp bl9tZW1vcnlfYWRkKG5ld19kb21pZCwgZGF0YS0+ZHNpemUgKyBrZXktPmRz aXplLAorCQkJCW5vX3F1b3RhX2NoZWNrKTsKKwlpZiAocmV0KSB7CisJCS8q IEVycm9yIHBhdGgsIHNvIG5vIHF1b3RhIGNoZWNrLiAqLworCQlpZiAob2xk X2FjYy5tZW1vcnkpCisJCQlkb21haW5fbWVtb3J5X2FkZF9ub2NoayhvbGRf ZG9taWQsCisJCQkJCQlvbGRfYWNjLm1lbW9yeSArIGtleS0+ZHNpemUpOwor CQlyZXR1cm4gcmV0OworCX0KKworCS8qIFREQiBzaG91bGQgc2V0IGVycm5v LCBidXQgZG9lc24ndCBldmVuIHNldCBlY29kZSBBRkFJQ1QuICovCisJaWYg KHRkYl9zdG9yZSh0ZGJfY3R4LCAqa2V5LCAqZGF0YSwgVERCX1JFUExBQ0Up ICE9IDApIHsKKwkJZG9tYWluX21lbW9yeV9hZGRfbm9jaGsobmV3X2RvbWlk LCAtZGF0YS0+ZHNpemUgLSBrZXktPmRzaXplKTsKKwkJLyogRXJyb3IgcGF0 aCwgc28gbm8gcXVvdGEgY2hlY2suICovCisJCWlmIChvbGRfYWNjLm1lbW9y eSkKKwkJCWRvbWFpbl9tZW1vcnlfYWRkX25vY2hrKG9sZF9kb21pZCwKKwkJ CQkJCW9sZF9hY2MubWVtb3J5ICsga2V5LT5kc2l6ZSk7CisJCWVycm5vID0g RUlPOworCQlyZXR1cm4gZXJybm87CisJfQorCisJaWYgKGFjYykgeworCQkv KiBEb24ndCB1c2UgbmV3X2RvbWlkLCBhcyBpdCBtaWdodCBiZSBhIHRyYW5z YWN0aW9uIG5vZGUuICovCisJCWFjYy0+ZG9taWQgPSBoZHItPnBlcm1zWzBd LmlkOworCQlhY2MtPm1lbW9yeSA9IGRhdGEtPmRzaXplOworCX0KKworCXJl dHVybiAwOworfQorCitpbnQgZG9fdGRiX2RlbGV0ZShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgVERCX0RBVEEgKmtleSwKKwkJICBzdHJ1Y3Qgbm9kZV9h Y2NvdW50X2RhdGEgKmFjYykKK3sKKwlzdHJ1Y3Qgbm9kZV9hY2NvdW50X2Rh dGEgdG1wX2FjYzsKKwl1bnNpZ25lZCBpbnQgZG9taWQ7CisKKwlpZiAoIWFj YykgeworCQlhY2MgPSAmdG1wX2FjYzsKKwkJYWNjLT5tZW1vcnkgPSAtMTsK Kwl9CisKKwlnZXRfYWNjX2RhdGEoa2V5LCBhY2MpOworCisJaWYgKHRkYl9k ZWxldGUodGRiX2N0eCwgKmtleSkpIHsKKwkJZXJybm8gPSBFSU87CisJCXJl dHVybiBlcnJubzsKKwl9CisKKwlpZiAoYWNjLT5tZW1vcnkpIHsKKwkJZG9t aWQgPSBnZXRfYWNjX2RvbWlkKGNvbm4sIGtleSwgYWNjLT5kb21pZCk7CisJ CWRvbWFpbl9tZW1vcnlfYWRkX25vY2hrKGRvbWlkLCAtYWNjLT5tZW1vcnkg LSBrZXktPmRzaXplKTsKKwl9CisKKwlyZXR1cm4gMDsKK30KKwogLyoKICAq IElmIGl0IGZhaWxzLCByZXR1cm5zIE5VTEwgYW5kIHNldHMgZXJybm8uCiAg KiBUZW1wb3JhcnkgbWVtb3J5IGFsbG9jYXRpb25zIHdpbGwgYmUgZG9uZSB3 aXRoIGN0eC4KQEAgLTYwOSw5ICs3MjAsMTUgQEAgc3RydWN0IG5vZGUgKnJl YWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAq Y3R4LAogCiAJLyogUGVybWlzc2lvbnMgYXJlIHN0cnVjdCB4c19wZXJtaXNz aW9ucy4gKi8KIAlub2RlLT5wZXJtcy5wID0gaGRyLT5wZXJtczsKKwlub2Rl LT5hY2MuZG9taWQgPSBub2RlLT5wZXJtcy5wWzBdLmlkOworCW5vZGUtPmFj Yy5tZW1vcnkgPSBkYXRhLmRzaXplOwogCWlmIChkb21haW5fYWRqdXN0X25v ZGVfcGVybXMoY29ubiwgbm9kZSkpCiAJCWdvdG8gZXJyb3I7CiAKKwkvKiBJ ZiBvd25lciBpcyBnb25lIHJlc2V0IGN1cnJlbnRseSBhY2NvdW50ZWQgbWVt b3J5IHNpemUuICovCisJaWYgKG5vZGUtPmFjYy5kb21pZCAhPSBub2RlLT5w ZXJtcy5wWzBdLmlkKQorCQlub2RlLT5hY2MubWVtb3J5ID0gMDsKKwogCS8q IERhdGEgaXMgYmluYXJ5IGJsb2IgKHVzdWFsbHkgYXNjaWksIG5vIG51bCku ICovCiAJbm9kZS0+ZGF0YSA9IG5vZGUtPnBlcm1zLnAgKyBoZHItPm51bV9w ZXJtczsKIAkvKiBDaGlsZHJlbiBpcyBzdHJpbmdzLCBudWwgc2VwYXJhdGVk LiAqLwpAQCAtNjgwLDEyICs3OTcsOSBAQCBpbnQgd3JpdGVfbm9kZV9yYXco c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXksIHN0cnVj dCBub2RlICpub2RlLAogCXAgKz0gbm9kZS0+ZGF0YWxlbjsKIAltZW1jcHko cCwgbm9kZS0+Y2hpbGRyZW4sIG5vZGUtPmNoaWxkbGVuKTsKIAotCS8qIFRE QiBzaG91bGQgc2V0IGVycm5vLCBidXQgZG9lc24ndCBldmVuIHNldCBlY29k ZSBBRkFJQ1QuICovCi0JaWYgKHRkYl9zdG9yZSh0ZGJfY3R4LCAqa2V5LCBk YXRhLCBUREJfUkVQTEFDRSkgIT0gMCkgewotCQljb3JydXB0KGNvbm4sICJX cml0ZSBvZiAlcyBmYWlsZWQiLCBrZXktPmRwdHIpOwotCQllcnJubyA9IEVJ TzsKLQkJcmV0dXJuIGVycm5vOwotCX0KKwlpZiAoZG9fdGRiX3dyaXRlKGNv bm4sIGtleSwgJmRhdGEsICZub2RlLT5hY2MsIG5vX3F1b3RhX2NoZWNrKSkK KwkJcmV0dXJuIEVJTzsKKwogCXJldHVybiAwOwogfQogCkBAIC0xMTg4LDcg KzEzMDIsNyBAQCBzdGF0aWMgdm9pZCBkZWxldGVfbm9kZV9zaW5nbGUoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQogCWlm IChhY2Nlc3Nfbm9kZShjb25uLCBub2RlLCBOT0RFX0FDQ0VTU19ERUxFVEUs ICZrZXkpKQogCQlyZXR1cm47CiAKLQlpZiAodGRiX2RlbGV0ZSh0ZGJfY3R4 LCBrZXkpICE9IDApIHsKKwlpZiAoZG9fdGRiX2RlbGV0ZShjb25uLCAma2V5 LCAmbm9kZS0+YWNjKSAhPSAwKSB7CiAJCWNvcnJ1cHQoY29ubiwgIkNvdWxk IG5vdCBkZWxldGUgJyVzJyIsIG5vZGUtPm5hbWUpOwogCQlyZXR1cm47CiAJ fQpAQCAtMTI2MSw2ICsxMzc1LDcgQEAgc3RhdGljIHN0cnVjdCBub2RlICpj b25zdHJ1Y3Rfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qg dm9pZCAqY3R4LAogCS8qIE5vIGNoaWxkcmVuLCBubyBkYXRhICovCiAJbm9k ZS0+Y2hpbGRyZW4gPSBub2RlLT5kYXRhID0gTlVMTDsKIAlub2RlLT5jaGls ZGxlbiA9IG5vZGUtPmRhdGFsZW4gPSAwOworCW5vZGUtPmFjYy5tZW1vcnkg PSAwOwogCW5vZGUtPnBhcmVudCA9IHBhcmVudDsKIAlyZXR1cm4gbm9kZTsK IApAQCAtMTI2OSwxNyArMTM4NCwxNyBAQCBzdGF0aWMgc3RydWN0IG5vZGUg KmNvbnN0cnVjdF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25z dCB2b2lkICpjdHgsCiAJcmV0dXJuIE5VTEw7CiB9CiAKLXN0YXRpYyB2b2lk IGRlc3Ryb3lfbm9kZV9ybShzdHJ1Y3Qgbm9kZSAqbm9kZSkKK3N0YXRpYyB2 b2lkIGRlc3Ryb3lfbm9kZV9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg c3RydWN0IG5vZGUgKm5vZGUpCiB7CiAJaWYgKHN0cmVxKG5vZGUtPm5hbWUs ICIvIikpCiAJCWNvcnJ1cHQoTlVMTCwgIkRlc3Ryb3lpbmcgcm9vdCBub2Rl ISIpOwogCi0JdGRiX2RlbGV0ZSh0ZGJfY3R4LCBub2RlLT5rZXkpOworCWRv X3RkYl9kZWxldGUoY29ubiwgJm5vZGUtPmtleSwgJm5vZGUtPmFjYyk7CiB9 CiAKIHN0YXRpYyBpbnQgZGVzdHJveV9ub2RlKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSkKIHsKLQlkZXN0cm95X25vZGVf cm0obm9kZSk7CisJZGVzdHJveV9ub2RlX3JtKGNvbm4sIG5vZGUpOwogCWRv bWFpbl9lbnRyeV9kZWMoY29ubiwgbm9kZSk7CiAKIAkvKgpAQCAtMTMzMSw3 ICsxNDQ2LDcgQEAgc3RhdGljIHN0cnVjdCBub2RlICpjcmVhdGVfbm9kZShz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCQkv KiBBY2NvdW50IGZvciBuZXcgbm9kZSAqLwogCQlpZiAoaS0+cGFyZW50KSB7 CiAJCQlpZiAoZG9tYWluX2VudHJ5X2luYyhjb25uLCBpKSkgewotCQkJCWRl c3Ryb3lfbm9kZV9ybShpKTsKKwkJCQlkZXN0cm95X25vZGVfcm0oY29ubiwg aSk7CiAJCQkJcmV0dXJuIE5VTEw7CiAJCQl9CiAJCX0KQEAgLTIxOTIsNyAr MjMwNyw3IEBAIHN0YXRpYyBpbnQgY2xlYW5fc3RvcmVfKFREQl9DT05URVhU ICp0ZGIsIFREQl9EQVRBIGtleSwgVERCX0RBVEEgdmFsLAogCWlmICghaGFz aHRhYmxlX3NlYXJjaChyZWFjaGFibGUsIG5hbWUpKSB7CiAJCWxvZygiY2xl YW5fc3RvcmU6ICclcycgaXMgb3JwaGFuZWQhIiwgbmFtZSk7CiAJCWlmIChy ZWNvdmVyeSkgewotCQkJdGRiX2RlbGV0ZSh0ZGIsIGtleSk7CisJCQlkb190 ZGJfZGVsZXRlKE5VTEwsICZrZXksIE5VTEwpOwogCQl9CiAJfQogCkBAIC0z MDMwLDYgKzMxNDUsNyBAQCB2b2lkIHJlYWRfc3RhdGVfbm9kZShjb25zdCB2 b2lkICpjdHgsIGNvbnN0IHZvaWQgKnN0YXRlKQogCWlmICghbm9kZSkKIAkJ YmFyZigiYWxsb2NhdGlvbiBlcnJvciByZXN0b3Jpbmcgbm9kZSIpOwogCisJ bm9kZS0+YWNjLm1lbW9yeSA9IDA7CiAJbm9kZS0+bmFtZSA9IG5hbWU7CiAJ bm9kZS0+Z2VuZXJhdGlvbiA9ICsrZ2VuZXJhdGlvbjsKIAlub2RlLT5kYXRh bGVuID0gc24tPmRhdGFfbGVuOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmgKaW5kZXggMmZiMzdkYmZlODQ3Li41YzFiNTc0YmZmZTYgMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMTY5LDYg KzE2OSwxMSBAQCBzdHJ1Y3Qgbm9kZV9wZXJtcyB7CiAJc3RydWN0IHhzX3Bl cm1pc3Npb25zICpwOwogfTsKIAorc3RydWN0IG5vZGVfYWNjb3VudF9kYXRh IHsKKwl1bnNpZ25lZCBpbnQgZG9taWQ7CisJaW50IG1lbW9yeTsJCS8qIC0x IGlmIHVua25vd24gKi8KK307CisKIHN0cnVjdCBub2RlIHsKIAljb25zdCBj aGFyICpuYW1lOwogCS8qIEtleSB1c2VkIHRvIHVwZGF0ZSBUREIgKi8KQEAg LTE5MSw2ICsxOTYsOSBAQCBzdHJ1Y3Qgbm9kZSB7CiAJLyogQ2hpbGRyZW4s IGVhY2ggbnVsLXRlcm1pbmF0ZWQuICovCiAJdW5zaWduZWQgaW50IGNoaWxk bGVuOwogCWNoYXIgKmNoaWxkcmVuOworCisJLyogQWxsb2NhdGlvbiBpbmZv cm1hdGlvbiBmb3Igbm9kZSBjdXJyZW50bHkgaW4gc3RvcmUuICovCisJc3Ry dWN0IG5vZGVfYWNjb3VudF9kYXRhIGFjYzsKIH07CiAKIC8qIFJldHVybiB0 aGUgb25seSBhcmd1bWVudCBpbiB0aGUgaW5wdXQuICovCkBAIC0zMDAsNiAr MzA4LDEwIEBAIGV4dGVybiB4ZW5nbnR0YWJfaGFuZGxlICoqeGd0X2hhbmRs ZTsKIGludCByZW1lbWJlcl9zdHJpbmcoc3RydWN0IGhhc2h0YWJsZSAqaGFz aCwgY29uc3QgY2hhciAqc3RyKTsKIAogdm9pZCBzZXRfdGRiX2tleShjb25z dCBjaGFyICpuYW1lLCBUREJfREFUQSAqa2V5KTsKK2ludCBkb190ZGJfd3Jp dGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXksIFRE Ql9EQVRBICpkYXRhLAorCQkgc3RydWN0IG5vZGVfYWNjb3VudF9kYXRhICph Y2MsIGJvb2wgbm9fcXVvdGFfY2hlY2spOworaW50IGRvX3RkYl9kZWxldGUo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXksCisJCSAg c3RydWN0IG5vZGVfYWNjb3VudF9kYXRhICphY2MpOwogCiB2b2lkIGNvbm5f ZnJlZV9idWZmZXJlZF9kYXRhKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsK IApkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5z YWN0aW9uLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rp b24uYwppbmRleCA3YmQ0MWViNDc1ZTMuLmFjZTlhMTFkNzdiYiAxMDA2NDQK LS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMK KysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMK QEAgLTE1Myw2ICsxNTMsOSBAQCBzdHJ1Y3QgdHJhbnNhY3Rpb24KIAkvKiBM aXN0IG9mIGFsbCB0cmFuc2FjdGlvbnMgYWN0aXZlIG9uIHRoaXMgY29ubmVj dGlvbi4gKi8KIAlzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7CiAKKwkvKiBDb25u ZWN0aW9uIHRoaXMgdHJhbnNhY3Rpb24gaXMgYXNzb2NpYXRlZCB3aXRoLiAq LworCXN0cnVjdCBjb25uZWN0aW9uICpjb25uOworCiAJLyogQ29ubmVjdGlv bi1sb2NhbCBpZGVudGlmaWVyIGZvciB0aGlzIHRyYW5zYWN0aW9uLiAqLwog CXVpbnQzMl90IGlkOwogCkBAIC0yODYsNiArMjg5LDggQEAgaW50IGFjY2Vz c19ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAq bm9kZSwKIAogCQlpbnRyb2R1Y2UgPSB0cnVlOwogCQlpLT50YV9ub2RlID0g ZmFsc2U7CisJCS8qIGFjYy5tZW1vcnkgPCAwIG1lYW5zICJ1bmtub3duLCBn ZXQgc2l6ZSBmcm9tIFREQiIuICovCisJCW5vZGUtPmFjYy5tZW1vcnkgPSAt MTsKIAogCQkvKgogCQkgKiBBZGRpdGlvbmFsIHRyYW5zYWN0aW9uLXNwZWNp ZmljIG5vZGUgZm9yIHJlYWQgdHlwZS4gV2Ugb25seQpAQCAtNDEwLDExICs0 MTUsMTEgQEAgc3RhdGljIGludCBmaW5hbGl6ZV90cmFuc2FjdGlvbihzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJCQkJZ290byBlcnI7CiAJCQkJaGRy ID0gKHZvaWQgKilkYXRhLmRwdHI7CiAJCQkJaGRyLT5nZW5lcmF0aW9uID0g KytnZW5lcmF0aW9uOwotCQkJCXJldCA9IHRkYl9zdG9yZSh0ZGJfY3R4LCBr ZXksIGRhdGEsCi0JCQkJCQlUREJfUkVQTEFDRSk7CisJCQkJcmV0ID0gZG9f dGRiX3dyaXRlKGNvbm4sICZrZXksICZkYXRhLCBOVUxMLAorCQkJCQkJICAg dHJ1ZSk7CiAJCQkJdGFsbG9jX2ZyZWUoZGF0YS5kcHRyKTsKIAkJCX0gZWxz ZSB7Ci0JCQkJcmV0ID0gdGRiX2RlbGV0ZSh0ZGJfY3R4LCBrZXkpOworCQkJ CXJldCA9IGRvX3RkYl9kZWxldGUoY29ubiwgJmtleSwgTlVMTCk7CiAJCQl9 CiAJCQlpZiAocmV0KQogCQkJCWdvdG8gZXJyOwpAQCAtNDI1LDcgKzQzMCw3 IEBAIHN0YXRpYyBpbnQgZmluYWxpemVfdHJhbnNhY3Rpb24oc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCiAJCQl9CiAJCX0KIAotCQlpZiAoaS0+dGFfbm9k ZSAmJiB0ZGJfZGVsZXRlKHRkYl9jdHgsIHRhX2tleSkpCisJCWlmIChpLT50 YV9ub2RlICYmIGRvX3RkYl9kZWxldGUoY29ubiwgJnRhX2tleSwgTlVMTCkp CiAJCQlnb3RvIGVycjsKIAkJbGlzdF9kZWwoJmktPmxpc3QpOwogCQl0YWxs b2NfZnJlZShpKTsKQEAgLTQ1Myw3ICs0NTgsNyBAQCBzdGF0aWMgaW50IGRl c3Ryb3lfdHJhbnNhY3Rpb24odm9pZCAqX3RyYW5zYWN0aW9uKQogCQkJCQkJ CSAgICAgICBpLT5ub2RlKTsKIAkJCWlmICh0cmFuc19uYW1lKSB7CiAJCQkJ c2V0X3RkYl9rZXkodHJhbnNfbmFtZSwgJmtleSk7Ci0JCQkJdGRiX2RlbGV0 ZSh0ZGJfY3R4LCBrZXkpOworCQkJCWRvX3RkYl9kZWxldGUodHJhbnMtPmNv bm4sICZrZXksIE5VTEwpOwogCQkJfQogCQl9CiAJCWxpc3RfZGVsKCZpLT5s aXN0KTsKQEAgLTQ5Nyw2ICs1MDIsNyBAQCBpbnQgZG9fdHJhbnNhY3Rpb25f c3RhcnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbikKIAogCUlOSVRfTElTVF9IRUFEKCZ0cmFucy0+YWNjZXNz ZWQpOwogCUlOSVRfTElTVF9IRUFEKCZ0cmFucy0+Y2hhbmdlZF9kb21haW5z KTsKKwl0cmFucy0+Y29ubiA9IGNvbm47CiAJdHJhbnMtPmZhaWwgPSBmYWxz ZTsKIAl0cmFucy0+Z2VuZXJhdGlvbiA9ICsrZ2VuZXJhdGlvbjsKIAo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-15.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-15.patch" Content-Transfer-Encoding: base64 RnJvbSBmZWQ2MjkyNTljNjRkOTFkZmIyNmJkNDc4YzI2MGI2NmRmYWQ0ZGFl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBleHBv cnRzIGZvciBxdW90YSB2YXJpYWJsZXMKClNvbWUgcXVvdGEgdmFyaWFibGVz IGFyZSBub3QgZXhwb3J0ZWQgdmlhIGhlYWRlciBmaWxlcy4KClRoaXMgaXMg cGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jv c3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmgKaW5kZXggNWMxYjU3NGJmZmU2Li4xZWIzNzA4ZjgyZGQgMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMjY4LDYg KzI2OCwxMSBAQCBleHRlcm4gVERCX0NPTlRFWFQgKnRkYl9jdHg7CiBleHRl cm4gaW50IGRvbTBfZG9taWQ7CiBleHRlcm4gaW50IGRvbTBfZXZlbnQ7CiBl eHRlcm4gaW50IHByaXZfZG9taWQ7CitleHRlcm4gaW50IHF1b3RhX25iX3dh dGNoX3Blcl9kb21haW47CitleHRlcm4gaW50IHF1b3RhX21heF90cmFuc2Fj dGlvbjsKK2V4dGVybiBpbnQgcXVvdGFfbWF4X2VudHJ5X3NpemU7CitleHRl cm4gaW50IHF1b3RhX25iX3Blcm1zX3Blcl9ub2RlOworZXh0ZXJuIGludCBx dW90YV9tYXhfcGF0aF9sZW47CiBleHRlcm4gaW50IHF1b3RhX25iX2VudHJ5 X3Blcl9kb21haW47CiBleHRlcm4gaW50IHF1b3RhX3JlcV9vdXRzdGFuZGlu ZzsKIGV4dGVybiBpbnQgcXVvdGFfdHJhbnNfbm9kZXM7CmRpZmYgLS1naXQg YS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4IGFj ZTlhMTFkNzdiYi4uMjg3NzQ4MTNkZTgzIDEwMDY0NAotLS0gYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpAQCAtMTc1LDcgKzE3 NSw2IEBAIHN0cnVjdCB0cmFuc2FjdGlvbgogCWJvb2wgZmFpbDsKIH07CiAK LWV4dGVybiBpbnQgcXVvdGFfbWF4X3RyYW5zYWN0aW9uOwogdWludDY0X3Qg Z2VuZXJhdGlvbjsKIAogc3RhdGljIHN0cnVjdCBhY2Nlc3NlZF9ub2RlICpm aW5kX2FjY2Vzc2VkX25vZGUoc3RydWN0IHRyYW5zYWN0aW9uICp0cmFucywK ZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5j IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmMKaW5kZXggMGQ1 ODU4ZGY1YmRkLi40OTcwZTlmMWExYjkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCisrKyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF93YXRjaC5jCkBAIC0zMSw4ICszMSw2IEBACiAjaW5jbHVk ZSAieGVuc3RvcmVkX2RvbWFpbi5oIgogI2luY2x1ZGUgInhlbnN0b3JlZF90 cmFuc2FjdGlvbi5oIgogCi1leHRlcm4gaW50IHF1b3RhX25iX3dhdGNoX3Bl cl9kb21haW47Ci0KIHN0cnVjdCB3YXRjaAogewogCS8qIFdhdGNoZXMgb24g dGhpcyBjb25uZWN0aW9uICovCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.15-xenstored-16.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.15-xenstored-16.patch" Content-Transfer-Encoding: base64 RnJvbSBlN2Q4NDY3M2Y3NTdjZDM4YWQwMjM5MWZlMDc5ZjI5MWI4MTk3ZDU0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBjb250 cm9sIGNvbW1hbmQgZm9yIHNldHRpbmcgYW5kIHNob3dpbmcgcXVvdGEKCkFk ZCBhIHhlbnN0b3JlLWNvbnRyb2wgY29tbWFuZCAicXVvdGEiIHRvOgotIHNo b3cgY3VycmVudCBxdW90YSBzZXR0aW5ncwotIGNoYW5nZSBxdW90YSBzZXR0 aW5ncwotIHNob3cgY3VycmVudCBxdW90YSByZWxhdGVkIHZhbHVlcyBvZiBh IGRvbWFpbgoKTm90ZSB0aGF0IGluIHRoZSBjYXNlIHRoZSBuZXcgcXVvdGEg aXMgbG93ZXIgdGhhbiBleGlzdGluZyBvbmUsClhlbnN0b3JlZCBtYXkgY29u dGludWUgdG8gaGFuZGxlIHJlcXVlc3RzIGZyb20gYSBkb21haW4gZXhjZWVk aW5nIHRoZQpuZXcgbGltaXQgKGRlcGVuZHMgb24gd2hpY2ggb25lIGhhcyBi ZWVuIGJyb2tlbikgYW5kIHRoZSBhbW91bnQgb2YKcmVzb3VyY2UgdXNlZCB3 aWxsIG5vdCBjaGFuZ2UuIEhvd2V2ZXIgdGhlIGRvbWFpbiB3aWxsIG5vdCBi ZSBhYmxlIHRvCmNyZWF0ZSBtb3JlIHJlc291cmNlIChhc3NvY2lhdGVkIHRv IHRoZSBxdW90YSkgdW50aWwgaXQgaXMgYmFjayB0byBiZWxvdwp0aGUgbGlt aXQuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNi4KClJlcG9ydGVkLWJ5OiBK dWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgpTaWduZWQtb2ZmLWJ5 OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJldmlld2VkLWJ5 OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdp dCBhL2RvY3MvbWlzYy94ZW5zdG9yZS50eHQgYi9kb2NzL21pc2MveGVuc3Rv cmUudHh0CmluZGV4IDMzNGRjOGI2ZmRmNS4uYTdkMDA2NTE5YWU4IDEwMDY0 NAotLS0gYS9kb2NzL21pc2MveGVuc3RvcmUudHh0CisrKyBiL2RvY3MvbWlz Yy94ZW5zdG9yZS50eHQKQEAgLTM2Niw2ICszNjYsMTcgQEAgQ09OVFJPTAkJ CTxjb21tYW5kPnxbPHBhcmFtZXRlcnM+fF0KIAlwcmludHw8c3RyaW5nPgog CQlwcmludCA8c3RyaW5nPiB0byBzeXNsb2cgKHhlbnN0b3JlIHJ1bnMgYXMg ZGFlbW9uKSBvcgogCQl0byBjb25zb2xlICh4ZW5zdG9yZSBydW5zIGFzIHN0 dWJkb20pCisJcXVvdGF8W3NldCA8bmFtZT4gPHZhbD58PGRvbWlkPl0KKwkJ d2l0aG91dCBwYXJhbWV0ZXJzOiBwcmludCB0aGUgY3VycmVudCBxdW90YSBz ZXR0aW5ncworCQl3aXRoICJzZXQgPG5hbWU+IDx2YWw+Ijogc2V0IHRoZSBx dW90YSA8bmFtZT4gdG8gbmV3IHZhbHVlCisJCTx2YWw+IChUaGUgYWRtaW4g c2hvdWxkIG1ha2Ugc3VyZSBhbGwgdGhlIGRvbWFpbiB1c2FnZSBpcworCQli ZWxvdyB0aGUgcXVvdGEuIElmIGl0IGlzIG5vdCwgdGhlbiBYZW5zdG9yZWQg bWF5IGNvbnRpbnVlIHRvCisJCWhhbmRsZSByZXF1ZXN0cyBmcm9tIHRoZSBk b21haW4gYXMgbG9uZyBhcyB0aGUgcmVzb3VyY2UKKwkJdmlvbGF0aW5nIHRo ZSBuZXcgcXVvdGEgc2V0dGluZyBpc24ndCBpbmNyZWFzZWQgZnVydGhlcikK KwkJd2l0aCAiPGRvbWlkPiI6IHByaW50IHF1b3RhIHJlbGF0ZWQgYWNjb3Vu dGluZyBkYXRhIGZvcgorCQl0aGUgZG9tYWluIDxkb21pZD4KKwlxdW90YS1z b2Z0fFtzZXQgPG5hbWU+IDx2YWw+XQorCQlsaWtlIHRoZSAicXVvdGEiIGNv bW1hbmQsIGJ1dCBmb3Igc29mdC1xdW90YS4KIAloZWxwCQkJPHN1cHBvcnRl ZC1jb21tYW5kcz4KIAkJcmV0dXJuIGxpc3Qgb2Ygc3VwcG9ydGVkIGNvbW1h bmRzIGZvciBDT05UUk9MCiAKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb250cm9sLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29udHJvbC5jCmluZGV4IDIxMWZlMWZkOWIzNy4uOTgwMjc5ZmE1M2Zm IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJv bC5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmMK QEAgLTE0OCw2ICsxNDgsMTE1IEBAIHN0YXRpYyBpbnQgZG9fY29udHJvbF9s b2codm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAlyZXR1 cm4gMDsKIH0KIAorc3RydWN0IHF1b3RhIHsKKwljb25zdCBjaGFyICpuYW1l OworCWludCAqcXVvdGE7CisJY29uc3QgY2hhciAqZGVzY3I7Cit9OworCitz dGF0aWMgY29uc3Qgc3RydWN0IHF1b3RhIGhhcmRfcXVvdGFzW10gPSB7CisJ eyAibm9kZXMiLCAmcXVvdGFfbmJfZW50cnlfcGVyX2RvbWFpbiwgIk5vZGVz IHBlciBkb21haW4iIH0sCisJeyAid2F0Y2hlcyIsICZxdW90YV9uYl93YXRj aF9wZXJfZG9tYWluLCAiV2F0Y2hlcyBwZXIgZG9tYWluIiB9LAorCXsgInRy YW5zYWN0aW9ucyIsICZxdW90YV9tYXhfdHJhbnNhY3Rpb24sICJUcmFuc2Fj dGlvbnMgcGVyIGRvbWFpbiIgfSwKKwl7ICJvdXRzdGFuZGluZyIsICZxdW90 YV9yZXFfb3V0c3RhbmRpbmcsCisJCSJPdXRzdGFuZGluZyByZXF1ZXN0cyBw ZXIgZG9tYWluIiB9LAorCXsgInRyYW5zYWN0aW9uLW5vZGVzIiwgJnF1b3Rh X3RyYW5zX25vZGVzLAorCQkiTWF4LiBudW1iZXIgb2YgYWNjZXNzZWQgbm9k ZXMgcGVyIHRyYW5zYWN0aW9uIiB9LAorCXsgIm1lbW9yeSIsICZxdW90YV9t ZW1vcnlfcGVyX2RvbWFpbl9oYXJkLAorCQkiVG90YWwgWGVuc3RvcmUgbWVt b3J5IHBlciBkb21haW4gKGVycm9yIGxldmVsKSIgfSwKKwl7ICJub2RlLXNp emUiLCAmcXVvdGFfbWF4X2VudHJ5X3NpemUsICJNYXguIHNpemUgb2YgYSBu b2RlIiB9LAorCXsgInBhdGgtbWF4IiwgJnF1b3RhX21heF9wYXRoX2xlbiwg Ik1heC4gbGVuZ3RoIG9mIGEgbm9kZSBwYXRoIiB9LAorCXsgInBlcm1pc3Np b25zIiwgJnF1b3RhX25iX3Blcm1zX3Blcl9ub2RlLAorCQkiTWF4LiBudW1i ZXIgb2YgcGVybWlzc2lvbnMgcGVyIG5vZGUiIH0sCisJeyBOVUxMLCBOVUxM LCBOVUxMIH0KK307CisKK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcXVvdGEgc29m dF9xdW90YXNbXSA9IHsKKwl7ICJtZW1vcnkiLCAmcXVvdGFfbWVtb3J5X3Bl cl9kb21haW5fc29mdCwKKwkJIlRvdGFsIFhlbnN0b3JlIG1lbW9yeSBwZXIg ZG9tYWluICh3YXJuaW5nIGxldmVsKSIgfSwKKwl7IE5VTEwsIE5VTEwsIE5V TEwgfQorfTsKKworc3RhdGljIGludCBxdW90YV9zaG93X2N1cnJlbnQoY29u c3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJCSAg ICAgIGNvbnN0IHN0cnVjdCBxdW90YSAqcXVvdGFzKQoreworCWNoYXIgKnJl c3A7CisJdW5zaWduZWQgaW50IGk7CisKKwlyZXNwID0gdGFsbG9jX3N0cmR1 cChjdHgsICJRdW90YSBzZXR0aW5nczpcbiIpOworCWlmICghcmVzcCkKKwkJ cmV0dXJuIEVOT01FTTsKKworCWZvciAoaSA9IDA7IHF1b3Rhc1tpXS5xdW90 YTsgaSsrKSB7CisJCXJlc3AgPSB0YWxsb2NfYXNwcmludGZfYXBwZW5kKHJl c3AsICIlLTE3czogJThkICVzXG4iLAorCQkJCQkgICAgICBxdW90YXNbaV0u bmFtZSwgKnF1b3Rhc1tpXS5xdW90YSwKKwkJCQkJICAgICAgcXVvdGFzW2ld LmRlc2NyKTsKKwkJaWYgKCFyZXNwKQorCQkJcmV0dXJuIEVOT01FTTsKKwl9 CisKKwlzZW5kX3JlcGx5KGNvbm4sIFhTX0NPTlRST0wsIHJlc3AsIHN0cmxl bihyZXNwKSArIDEpOworCisJcmV0dXJuIDA7Cit9CisKK3N0YXRpYyBpbnQg cXVvdGFfc2V0KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sCisJCSAgICAgY2hhciAqKnZlYywgaW50IG51bSwgY29uc3Qgc3Ry dWN0IHF1b3RhICpxdW90YXMpCit7CisJdW5zaWduZWQgaW50IGk7CisJaW50 IHZhbDsKKworCWlmIChudW0gIT0gMikKKwkJcmV0dXJuIEVJTlZBTDsKKwor CXZhbCA9IGF0b2kodmVjWzFdKTsKKwlpZiAodmFsIDwgMSkKKwkJcmV0dXJu IEVJTlZBTDsKKworCWZvciAoaSA9IDA7IHF1b3Rhc1tpXS5xdW90YTsgaSsr KSB7CisJCWlmICghc3RyY21wKHZlY1swXSwgcXVvdGFzW2ldLm5hbWUpKSB7 CisJCQkqcXVvdGFzW2ldLnF1b3RhID0gdmFsOworCQkJc2VuZF9hY2soY29u biwgWFNfQ09OVFJPTCk7CisJCQlyZXR1cm4gMDsKKwkJfQorCX0KKworCXJl dHVybiBFSU5WQUw7Cit9CisKK3N0YXRpYyBpbnQgcXVvdGFfZ2V0KGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICAg Y2hhciAqKnZlYywgaW50IG51bSkKK3sKKwlpZiAobnVtICE9IDEpCisJCXJl dHVybiBFSU5WQUw7CisKKwlyZXR1cm4gZG9tYWluX2dldF9xdW90YShjdHgs IGNvbm4sIGF0b2kodmVjWzBdKSk7Cit9CisKK3N0YXRpYyBpbnQgZG9fY29u dHJvbF9xdW90YSh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25u LAorCQkJICAgIGNoYXIgKip2ZWMsIGludCBudW0pCit7CisJaWYgKG51bSA9 PSAwKQorCQlyZXR1cm4gcXVvdGFfc2hvd19jdXJyZW50KGN0eCwgY29ubiwg aGFyZF9xdW90YXMpOworCisJaWYgKCFzdHJjbXAodmVjWzBdLCAic2V0Iikp CisJCXJldHVybiBxdW90YV9zZXQoY3R4LCBjb25uLCB2ZWMgKyAxLCBudW0g LSAxLCBoYXJkX3F1b3Rhcyk7CisKKwlyZXR1cm4gcXVvdGFfZ2V0KGN0eCwg Y29ubiwgdmVjLCBudW0pOworfQorCitzdGF0aWMgaW50IGRvX2NvbnRyb2xf cXVvdGFfcyh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAor CQkJICAgICAgY2hhciAqKnZlYywgaW50IG51bSkKK3sKKwlpZiAobnVtID09 IDApCisJCXJldHVybiBxdW90YV9zaG93X2N1cnJlbnQoY3R4LCBjb25uLCBz b2Z0X3F1b3Rhcyk7CisKKwlpZiAoIXN0cmNtcCh2ZWNbMF0sICJzZXQiKSkK KwkJcmV0dXJuIHF1b3RhX3NldChjdHgsIGNvbm4sIHZlYyArIDEsIG51bSAt IDEsIHNvZnRfcXVvdGFzKTsKKworCXJldHVybiBFSU5WQUw7Cit9CisKICNp ZmRlZiBfX01JTklPU19fCiBzdGF0aWMgaW50IGRvX2NvbnRyb2xfbWVtcmVw b3J0KHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQkJ Y2hhciAqKnZlYywgaW50IG51bSkKQEAgLTc3Nyw2ICs4ODYsOCBAQCBzdGF0 aWMgc3RydWN0IGNtZF9zIGNtZHNbXSA9IHsKIAl7ICJtZW1yZXBvcnQiLCBk b19jb250cm9sX21lbXJlcG9ydCwgIls8ZmlsZT5dIiB9LAogI2VuZGlmCiAJ eyAicHJpbnQiLCBkb19jb250cm9sX3ByaW50LCAiPHN0cmluZz4iIH0sCisJ eyAicXVvdGEiLCBkb19jb250cm9sX3F1b3RhLCAiW3NldCA8bmFtZT4gPHZh bD58PGRvbWlkPl0iIH0sCisJeyAicXVvdGEtc29mdCIsIGRvX2NvbnRyb2xf cXVvdGFfcywgIltzZXQgPG5hbWU+IDx2YWw+XSIgfSwKIAl7ICJoZWxwIiwg ZG9fY29udHJvbF9oZWxwLCAiIiB9LAogfTsKIApkaWZmIC0tZ2l0IGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IGVjNTQyZGY2YTY3ZS4uM2Q1 MTQyNTgxMzMyIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Rv bWFpbi5jCkBAIC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSAieGVuc3RvcmVk X2RvbWFpbi5oIgogI2luY2x1ZGUgInhlbnN0b3JlZF90cmFuc2FjdGlvbi5o IgogI2luY2x1ZGUgInhlbnN0b3JlZF93YXRjaC5oIgorI2luY2x1ZGUgInhl bnN0b3JlZF9jb250cm9sLmgiCiAKICNpbmNsdWRlIDx4ZW5ldnRjaG4uaD4K ICNpbmNsdWRlIDx4ZW5jdHJsLmg+CkBAIC0zNTEsNiArMzUyLDM4IEBAIHN0 YXRpYyBzdHJ1Y3QgZG9tYWluICpmaW5kX2RvbWFpbl9zdHJ1Y3QodW5zaWdu ZWQgaW50IGRvbWlkKQogCXJldHVybiBOVUxMOwogfQogCitpbnQgZG9tYWlu X2dldF9xdW90YShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAorCQkgICAgIHVuc2lnbmVkIGludCBkb21pZCkKK3sKKwlzdHJ1 Y3QgZG9tYWluICpkID0gZmluZF9kb21haW5fc3RydWN0KGRvbWlkKTsKKwlj aGFyICpyZXNwOworCWludCB0YTsKKworCWlmICghZCkKKwkJcmV0dXJuIEVO T0VOVDsKKworCXRhID0gZC0+Y29ubiA/IGQtPmNvbm4tPnRyYW5zYWN0aW9u X3N0YXJ0ZWQgOiAwOworCXJlc3AgPSB0YWxsb2NfYXNwcmludGYoY3R4LCAi RG9tYWluICV1OlxuIiwgZG9taWQpOworCWlmICghcmVzcCkKKwkJcmV0dXJu IEVOT01FTTsKKworI2RlZmluZSBlbnQodCwgZSkgXAorCXJlc3AgPSB0YWxs b2NfYXNwcmludGZfYXBwZW5kKHJlc3AsICIlLTE2czogJThkXG4iLCAjdCwg ZSk7IFwKKwlpZiAoIXJlc3ApIHJldHVybiBFTk9NRU0KKworCWVudChub2Rl cywgZC0+bmJlbnRyeSk7CisJZW50KHdhdGNoZXMsIGQtPm5id2F0Y2gpOwor CWVudCh0cmFuc2FjdGlvbnMsIHRhKTsKKwllbnQob3V0c3RhbmRpbmcsIGQt Pm5ib3V0c3RhbmRpbmcpOworCWVudChtZW1vcnksIGQtPm1lbW9yeSk7CisK KyN1bmRlZiBlbnQKKworCXNlbmRfcmVwbHkoY29ubiwgWFNfQ09OVFJPTCwg cmVzcCwgc3RybGVuKHJlc3ApICsgMSk7CisKKwlyZXR1cm4gMDsKK30KKwog c3RhdGljIHN0cnVjdCBkb21haW4gKmFsbG9jX2RvbWFpbihjb25zdCB2b2lk ICpjb250ZXh0LCB1bnNpZ25lZCBpbnQgZG9taWQpCiB7CiAJc3RydWN0IGRv bWFpbiAqZG9tYWluOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2RvbWFpbi5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Rv bWFpbi5oCmluZGV4IDU3MWFhNDZkMTU4ZS4uMGY4ODM5MzZmNDEzIDEwMDY0 NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oCkBAIC05MSw2 ICs5MSw4IEBAIGludCBkb21haW5fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pOwogdm9pZCBkb21haW5fb3V0c3RhbmRpbmdfaW5jKHN0cnVjdCBj b25uZWN0aW9uICpjb25uKTsKIHZvaWQgZG9tYWluX291dHN0YW5kaW5nX2Rl YyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7CiB2b2lkIGRvbWFpbl9vdXRz dGFuZGluZ19kb21pZF9kZWModW5zaWduZWQgaW50IGRvbWlkKTsKK2ludCBk b21haW5fZ2V0X3F1b3RhKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sCisJCSAgICAgdW5zaWduZWQgaW50IGRvbWlkKTsKIAog LyogU3BlY2lhbCBub2RlIHBlcm1pc3Npb24gaGFuZGxpbmcuICovCiBpbnQg c2V0X3Blcm1zX3NwZWNpYWwoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNv bnN0IGNoYXIgKm5hbWUsCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-oxenstored-01.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-oxenstored-01.patch" Content-Transfer-Encoding: base64 RnJvbSA4ZDZiYjRhYzQwNjE5ODc3MTMwNTMzYjExNjU1ODI5MTAxYjMxZDA0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IFN5bmNocm9uaXNlIGRlZmF1 bHRzIHdpdGggb3hlbnN0b3JlLmNvbmYuaW4KTUlNRS1WZXJzaW9uOiAxLjAK Q29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRl bnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCldlIGN1cnJlbnRseSBoYXZl IDIgZGlmZmVyZW50IHNldCBvZiBkZWZhdWx0cyBpbiB1cHN0cmVhbSBYZW4g Z2l0IHRyZWU6CiogZGVmaW5lZCBpbiB0aGUgc291cmNlIGNvZGUsIG9ubHkg dXNlZCBpZiB0aGVyZSBpcyBubyBjb25maWcgZmlsZQoqIGRlZmluZWQgaW4g dGhlIG94ZW5zdG9yZWQuY29uZi5pbiB1cHN0cmVhbSBYZW4KCkFuIG94ZW5z dG9yZWQuY29uZiBmaWxlIGlzIG5vdCBtYW5kYXRvcnksIGFuZCBpZiBtaXNz aW5nLCBtYXhyZXF1ZXN0cyBpbgpwYXJ0aWN1bGFyIGhhcyBhbiB1bnNhZmUg ZGVmYXVsdC4KClJlc3luYyB0aGUgZGVmYXVsdHMgZnJvbSBveGVuc3RvcmVk LmNvbmYuaW4gaW50byB0aGUgc291cmNlIGNvZGUuCgpUaGlzIGlzIHBhcnQg b2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzE2LgoKUmVwb3J0ZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6 IEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2Vk LWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJp eC5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Rl ZmluZS5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKaW5k ZXggZWJlMThiOGUzMTJjLi42YjA2ZjgwODU5NWIgMTAwNjQ0Ci0tLSBhL3Rv b2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKKysrIGIvdG9vbHMvb2Nh bWwveGVuc3RvcmVkL2RlZmluZS5tbApAQCAtMjEsOSArMjEsOSBAQCBsZXQg eHNfZGFlbW9uX3NvY2tldCA9IFBhdGhzLnhlbl9ydW5fc3RvcmVkIF4gIi9z b2NrZXQiCiAKIGxldCBkZWZhdWx0X2NvbmZpZ19kaXIgPSBQYXRocy54ZW5f Y29uZmlnX2RpcgogCi1sZXQgbWF4d2F0Y2ggPSByZWYgKDUwKQotbGV0IG1h eHRyYW5zYWN0aW9uID0gcmVmICgyMCkKLWxldCBtYXhyZXF1ZXN0cyA9IHJl ZiAoLTEpICAgKCogbWF4aW11bSByZXF1ZXN0cyBwZXIgdHJhbnNhY3Rpb24g KikKK2xldCBtYXh3YXRjaCA9IHJlZiAoMTAwKQorbGV0IG1heHRyYW5zYWN0 aW9uID0gcmVmICgxMCkKK2xldCBtYXhyZXF1ZXN0cyA9IHJlZiAoMTAyNCkg ICAoKiBtYXhpbXVtIHJlcXVlc3RzIHBlciB0cmFuc2FjdGlvbiAqKQogCiBs ZXQgY29uZmxpY3RfYnVyc3RfbGltaXQgPSByZWYgNS4wCiBsZXQgY29uZmxp Y3RfbWF4X2hpc3Rvcnlfc2Vjb25kcyA9IHJlZiAwLjA1CmRpZmYgLS1naXQg YS90b29scy9vY2FtbC94ZW5zdG9yZWQvcXVvdGEubWwgYi90b29scy9vY2Ft bC94ZW5zdG9yZWQvcXVvdGEubWwKaW5kZXggYWJjYWM5MTI4MDVhLi42ZTNk NjQwMWFlODkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9x dW90YS5tbAorKysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvcXVvdGEubWwK QEAgLTIwLDggKzIwLDggQEAgZXhjZXB0aW9uIFRyYW5zYWN0aW9uX29wZW5l ZAogCiBsZXQgd2FybiBmbXQgPSBMb2dnaW5nLndhcm4gInF1b3RhIiBmbXQK IGxldCBhY3RpdmF0ZSA9IHJlZiB0cnVlCi1sZXQgbWF4ZW50ID0gcmVmICgx MDAwMCkKLWxldCBtYXhzaXplID0gcmVmICg0MDk2KQorbGV0IG1heGVudCA9 IHJlZiAoMTAwMCkKK2xldCBtYXhzaXplID0gcmVmICgyMDQ4KQogCiB0eXBl IHQgPSB7CiAJbWF4ZW50OiBpbnQ7ICAgICAgICAgICAgICAgKCogbWF4IGVu dGl0aWVzIHBlciBkb21VICopCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-oxenstored-02.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-oxenstored-02.patch" Content-Transfer-Encoding: base64 RnJvbSA3OGQ1YWY0NGFiMTNiYjE4Yzg3YjZhZDc1ZTUwNWJkMzc0Mzc5Y2Iz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogVGh1LCAyOCBKdWwgMjAyMiAxNzowODoxNSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IENoZWNrIGZvciBtYXhyZXF1 ZXN0cyBiZWZvcmUgcGVyZm9ybWluZwogb3BlcmF0aW9ucwpNSU1FLVZlcnNp b246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRG LTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKUHJldmlvdXNs eSB3ZSdkIHBlcmZvcm0gdGhlIG9wZXJhdGlvbiwgcmVjb3JkIHRoZSB1cGRh dGVkIHRyZWUgaW4gdGhlCnRyYW5zYWN0aW9uIHJlY29yZCwgdGhlbiB0cnkg dG8gaW5zZXJ0IGEgd2F0Y2hvcCBwYXRoIGFuZCB0aGUgcmVwbHkgcGFja2V0 LgoKSWYgd2UgZXhjZWVkZWQgbWF4IHJlcXVlc3RzIHdlIHdvdWxkJ3ZlIHJl dHVybmVkIEVRVU9UQSwgYnV0IHN0aWxsOgoqIGhhdmUgcGVyZm9ybWVkIHRo ZSBvcGVyYXRpb24gb24gdGhlIHRyYW5zYWN0aW9uJ3MgdHJlZQoqIGhhdmUg cmVjb3JkZWQgdGhlIHdhdGNob3AsIG1ha2luZyB0aGlzIHF1ZXVlIGVmZmVj dGl2ZWx5IHVuYm91bmRlZAoKSXQgaXMgYmV0dGVyIGlmIHdlIGNoZWNrIHdo ZXRoZXIgd2UnZCBoYXZlIHJvb20gdG8gc3RvcmUgdGhlIG9wZXJhdGlvbiBi ZWZvcmUKcGVyZm9ybWluZyB0aGUgdHJhbnNhY3Rpb24sIGFuZCByYWlzZSBF UVVPVEEgdGhlcmUuICBUaGVuIHRoZSB0cmFuc2FjdGlvbgpyZWNvcmQgd29u J3QgZ3Jvdy4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2IC8gQ1ZFLTIwMjIt NDIzMTcuCgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1h em9uLmNvbT4KU2lnbmVkLW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4u dG9yb2tAY2l0cml4LmNvbT4KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcg PGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbCBiL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9wcm9jZXNzLm1sCmluZGV4IDI3NzkwZDRhNWM0MS4uZGQ1 OGU2OTc5Y2Y5IDEwMDY0NAotLS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQv cHJvY2Vzcy5tbAorKysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vz cy5tbApAQCAtMzg5LDYgKzM4OSw3IEBAIGxldCBpbnB1dF9oYW5kbGVfZXJy b3IgfmNvbnMgfmRvbXMgfmZjdCB+Y29uIH50IH5yZXEgPQogCWxldCByZXBs eV9lcnJvciBlID0KIAkJUGFja2V0LkVycm9yIGUgaW4KIAl0cnkKKwkJVHJh bnNhY3Rpb24uY2hlY2tfcXVvdGFfZXhuIH5wZXJtOihDb25uZWN0aW9uLmdl dF9wZXJtIGNvbikgdDsKIAkJZmN0IGNvbiB0IGRvbXMgY29ucyByZXEuUGFj a2V0LmRhdGEKIAl3aXRoCiAJfCBEZWZpbmUuSW52YWxpZF9wYXRoICAgICAg ICAgIC0+IHJlcGx5X2Vycm9yICJFSU5WQUwiCkBAIC02ODEsOSArNjgyLDEw IEBAIGxldCBwcm9jZXNzX3BhY2tldCB+c3RvcmUgfmNvbnMgfmRvbXMgfmNv biB+cmVxID0KIAkJaW4KIAogCQlsZXQgcmVzcG9uc2UgPSB0cnkKKwkJCVRy YW5zYWN0aW9uLmNoZWNrX3F1b3RhX2V4biB+cGVybTooQ29ubmVjdGlvbi5n ZXRfcGVybSBjb24pIHQ7CiAJCQlpZiB0aWQgPD4gVHJhbnNhY3Rpb24ubm9u ZSB0aGVuCiAJCQkJKCogUmVtZW1iZXIgdGhlIHJlcXVlc3QgYW5kIHJlc3Bv bnNlIGZvciB0aGlzIG9wZXJhdGlvbiBpbiBjYXNlIHdlIG5lZWQgdG8gcmVw bGF5IHRoZSB0cmFuc2FjdGlvbiAqKQotCQkJCVRyYW5zYWN0aW9uLmFkZF9v cGVyYXRpb24gfnBlcm06KENvbm5lY3Rpb24uZ2V0X3Blcm0gY29uKSB0IHJl cSByZXNwb25zZTsKKwkJCQlUcmFuc2FjdGlvbi5hZGRfb3BlcmF0aW9uIHQg cmVxIHJlc3BvbnNlOwogCQkJcmVzcG9uc2UKIAkJd2l0aCBRdW90YS5MaW1p dF9yZWFjaGVkIC0+CiAJCQlQYWNrZXQuRXJyb3IgIkVRVU9UQSIKZGlmZiAt LWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbCBi L3Rvb2xzL29jYW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbAppbmRleCAx N2IxYmRmMmVhZjkuLjI5NDE0M2UyMzM1YiAxMDA2NDQKLS0tIGEvdG9vbHMv b2NhbWwveGVuc3RvcmVkL3RyYW5zYWN0aW9uLm1sCisrKyBiL3Rvb2xzL29j YW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbApAQCAtODUsNiArODUsNyBA QCB0eXBlIHQgPSB7CiAJb2xkcm9vdDogU3RvcmUuTm9kZS50OwogCW11dGFi bGUgcGF0aHM6IChYZW5idXMuWGIuT3Aub3BlcmF0aW9uICogU3RvcmUuUGF0 aC50KSBsaXN0OwogCW11dGFibGUgb3BlcmF0aW9uczogKFBhY2tldC5yZXF1 ZXN0ICogUGFja2V0LnJlc3BvbnNlKSBsaXN0OworCW11dGFibGUgcXVvdGFf cmVhY2hlZDogYm9vbDsKIAltdXRhYmxlIHJlYWRfbG93cGF0aDogU3RvcmUu UGF0aC50IG9wdGlvbjsKIAltdXRhYmxlIHdyaXRlX2xvd3BhdGg6IFN0b3Jl LlBhdGgudCBvcHRpb247CiB9CkBAIC0xMjcsNiArMTI4LDcgQEAgbGV0IG1h a2UgPyhpbnRlcm5hbD1mYWxzZSkgaWQgc3RvcmUgPQogCQlvbGRyb290ID0g U3RvcmUuZ2V0X3Jvb3Qgc3RvcmU7CiAJCXBhdGhzID0gW107CiAJCW9wZXJh dGlvbnMgPSBbXTsKKwkJcXVvdGFfcmVhY2hlZCA9IGZhbHNlOwogCQlyZWFk X2xvd3BhdGggPSBOb25lOwogCQl3cml0ZV9sb3dwYXRoID0gTm9uZTsKIAl9 IGluCkBAIC0xNDMsMTMgKzE0NSwxOSBAQCBsZXQgZ2V0X3Jvb3QgdCA9IFN0 b3JlLmdldF9yb290IHQuc3RvcmUKIAogbGV0IGlzX3JlYWRfb25seSB0ID0g dC5wYXRocyA9IFtdCiBsZXQgYWRkX3dvcCB0IHR5IHBhdGggPSB0LnBhdGhz IDwtICh0eSwgcGF0aCkgOjogdC5wYXRocwotbGV0IGFkZF9vcGVyYXRpb24g fnBlcm0gdCByZXF1ZXN0IHJlc3BvbnNlID0KK2xldCBnZXRfb3BlcmF0aW9u cyB0ID0gTGlzdC5yZXYgdC5vcGVyYXRpb25zCisKK2xldCBjaGVja19xdW90 YV9leG4gfnBlcm0gdCA9CiAJaWYgIURlZmluZS5tYXhyZXF1ZXN0cyA+PSAw CiAJCSYmIG5vdCAoUGVybXMuQ29ubmVjdGlvbi5pc19kb20wIHBlcm0pCi0J CSYmIExpc3QubGVuZ3RoIHQub3BlcmF0aW9ucyA+PSAhRGVmaW5lLm1heHJl cXVlc3RzCi0JCXRoZW4gcmFpc2UgUXVvdGEuTGltaXRfcmVhY2hlZDsKKwkJ JiYgKHQucXVvdGFfcmVhY2hlZCB8fCBMaXN0Lmxlbmd0aCB0Lm9wZXJhdGlv bnMgPj0gIURlZmluZS5tYXhyZXF1ZXN0cykKKwkJdGhlbiBiZWdpbgorCQkJ dC5xdW90YV9yZWFjaGVkIDwtIHRydWU7CisJCQlyYWlzZSBRdW90YS5MaW1p dF9yZWFjaGVkOworCQllbmQKKworbGV0IGFkZF9vcGVyYXRpb24gdCByZXF1 ZXN0IHJlc3BvbnNlID0KIAl0Lm9wZXJhdGlvbnMgPC0gKHJlcXVlc3QsIHJl c3BvbnNlKSA6OiB0Lm9wZXJhdGlvbnMKLWxldCBnZXRfb3BlcmF0aW9ucyB0 ID0gTGlzdC5yZXYgdC5vcGVyYXRpb25zCiBsZXQgc2V0X3JlYWRfbG93cGF0 aCB0IHBhdGggPSB0LnJlYWRfbG93cGF0aCA8LSBnZXRfbG93ZXN0IHBhdGgg dC5yZWFkX2xvd3BhdGgKIGxldCBzZXRfd3JpdGVfbG93cGF0aCB0IHBhdGgg PSB0LndyaXRlX2xvd3BhdGggPC0gZ2V0X2xvd2VzdCBwYXRoIHQud3JpdGVf bG93cGF0aAogCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-oxenstored-03.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-oxenstored-03.patch" Content-Transfer-Encoding: base64 RnJvbSA2MDBjNDVlNDljMjA2MGUwNzdjMDZhYjE5MDc4ZGE4OWFhOGUyZTA4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNyArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogR0MgcGFyYW1ldGVyIHR1bmluZwpNSU1FLVZl cnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9 VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKQnkgZGVm YXVsdCB0aGUgT0NhbWwgZ2FyYmFnZSBjb2xsZWN0b3Igd291bGQgcmV0dXJu IG1lbW9yeSB0byB0aGUgT1Mgb25seQphZnRlciB1bnVzZWQgbWVtb3J5IGlz IDV4IGxpdmUgbWVtb3J5LiAgVHdlYWsgdGhpcyB0byAxMjAlIGluc3RlYWQs IHdoaWNoCndvdWxkIG1hdGNoIHRoZSBtYWpvciBHQyBzcGVlZC4KClRoaXMg aXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEVkd2luIFTD tnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJp c3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+Cgpk aWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RlZmluZS5tbCBi L3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKaW5kZXggNmIwNmY4 MDg1OTViLi5iYTYzYTgxNDdlMDkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9kZWZpbmUubWwKKysrIGIvdG9vbHMvb2NhbWwveGVuc3Rv cmVkL2RlZmluZS5tbApAQCAtMjUsNiArMjUsNyBAQCBsZXQgbWF4d2F0Y2gg PSByZWYgKDEwMCkKIGxldCBtYXh0cmFuc2FjdGlvbiA9IHJlZiAoMTApCiBs ZXQgbWF4cmVxdWVzdHMgPSByZWYgKDEwMjQpICAgKCogbWF4aW11bSByZXF1 ZXN0cyBwZXIgdHJhbnNhY3Rpb24gKikKIAorbGV0IGdjX21heF9vdmVyaGVh ZCA9IHJlZiAxMjAgKCogMTIwJSBzZWUgY29tbWVudCBpbiB4ZW5zdG9yZWQu bWwgKikKIGxldCBjb25mbGljdF9idXJzdF9saW1pdCA9IHJlZiA1LjAKIGxl dCBjb25mbGljdF9tYXhfaGlzdG9yeV9zZWNvbmRzID0gcmVmIDAuMDUKIGxl dCBjb25mbGljdF9yYXRlX2xpbWl0X2lzX2FnZ3JlZ2F0ZSA9IHJlZiB0cnVl CmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQveGVuc3RvcmVk Lm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbAppbmRl eCBkNDRhZTY3M2M0MmEuLjNiNTdhZDAxNmRmYiAxMDA2NDQKLS0tIGEvdG9v bHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbAorKysgYi90b29scy9v Y2FtbC94ZW5zdG9yZWQveGVuc3RvcmVkLm1sCkBAIC0xMDQsNiArMTA0LDcg QEAgbGV0IHBhcnNlX2NvbmZpZyBmaWxlbmFtZSA9CiAJCSgicXVvdGEtbWF4 c2l6ZSIsIENvbmZpZy5TZXRfaW50IFF1b3RhLm1heHNpemUpOwogCQkoInF1 b3RhLW1heHJlcXVlc3RzIiwgQ29uZmlnLlNldF9pbnQgRGVmaW5lLm1heHJl cXVlc3RzKTsKIAkJKCJxdW90YS1wYXRoLW1heCIsIENvbmZpZy5TZXRfaW50 IERlZmluZS5wYXRoX21heCk7CisJCSgiZ2MtbWF4LW92ZXJoZWFkIiwgQ29u ZmlnLlNldF9pbnQgRGVmaW5lLmdjX21heF9vdmVyaGVhZCk7CiAJCSgidGVz dC1lYWdhaW4iLCBDb25maWcuU2V0X2Jvb2wgVHJhbnNhY3Rpb24udGVzdF9l YWdhaW4pOwogCQkoInBlcnNpc3RlbnQiLCBDb25maWcuU2V0X2Jvb2wgRGlz ay5lbmFibGUpOwogCQkoInhlbnN0b3JlZC1sb2ctZmlsZSIsIENvbmZpZy5T dHJpbmcgTG9nZ2luZy5zZXRfeGVuc3RvcmVkX2xvZ19kZXN0aW5hdGlvbik7 CkBAIC0yNjUsNiArMjY2LDY3IEBAIGxldCB0b19maWxlIHN0b3JlIGNvbnMg ZmRzIGZpbGUgPQogCSAgICAgICAgKGZ1biAoKSAtPiBjbG9zZV9vdXQgY2hh bm5lbCkKIGVuZAogCisoKgorCUJ5IGRlZmF1bHQgT0NhbWwncyBHQyBvbmx5 IHJldHVybnMgbWVtb3J5IHRvIHRoZSBPUyB3aGVuIGl0IGV4Y2VlZHMgYQor CWNvbmZpZ3VyYWJsZSAnbWF4IG92ZXJoZWFkJyBzZXR0aW5nLgorCVRoZSBk ZWZhdWx0IGlzIDUwMCUsIHRoYXQgaXMgNS82dGggb2YgdGhlIE9DYW1sIGhl YXAgbmVlZHMgdG8gYmUgZnJlZQorCWFuZCBvbmx5IDEvNnRoIGxpdmUgZm9y IGEgY29tcGFjdGlvbiB0byBiZSB0cmlnZ2VycmVkIHRoYXQgd291bGQKKwly ZWxlYXNlIG1lbW9yeSBiYWNrIHRvIHRoZSBPUy4KKwlJZiB0aGUgbGltaXQg aXMgbm90IGhpdCB0aGVuIHRoZSBPQ2FtbCBwcm9jZXNzIGNhbiByZXVzZSB0 aGF0IG1lbW9yeQorCWZvciBpdHMgb3duIHB1cnBvc2VzLCBidXQgb3RoZXIg cHJvY2Vzc2VzIHdvbid0IGJlIGFibGUgdG8gdXNlIGl0LgorCisJVGhlcmUg aXMgYWxzbyBhICdzcGFjZSBvdmVyaGVhZCcgc2V0dGluZyB0aGF0IGNvbnRy b2xzIGhvdyBtdWNoIHdvcmsKKwllYWNoIG1ham9yIEdDIHNsaWNlIGRvZXMs IGFuZCBieSBkZWZhdWx0IGFpbXMgYXQgaGF2aW5nIG5vIG1vcmUgdGhhbgor CTgwJSBvciAxMjAlIChkZXBlbmRpbmcgb24gdmVyc2lvbikgZ2FyYmFnZSB2 YWx1ZXMgY29tcGFyZWQgdG8gbGl2ZQorCXZhbHVlcy4KKwlUaGlzIGRvZXNu J3QgaGF2ZSBhcyBtdWNoIHJlbGV2YW5jZSB0byBtZW1vcnkgcmV0dXJuZWQg dG8gdGhlIE9TIGFzCisJbG9uZyBhcyBzcGFjZV9vdmVyaGVhZCA8PSBtYXhf b3ZlcmhlYWQsIGJlY2F1c2UgY29tcGFjdGlvbiBpcyBvbmx5CisJdHJpZ2dl cnJlZCBhdCB0aGUgZW5kIG9mIG1ham9yIEdDIGN5Y2xlcy4KKworCVRoZSBk ZWZhdWx0cyBhcmUgdG9vIGxhcmdlIG9uY2UgdGhlIHByb2dyYW0gc3RhcnRz IHVzaW5nIH4xMDBNaUIgb2YKKwltZW1vcnksIGF0IHdoaWNoIHBvaW50IH41 MDBNaUIgd291bGQgYmUgdW5hdmFpbGFibGUgdG8gb3RoZXIgcHJvY2Vzc2Vz CisJKHdoaWNoIHdvdWxkIGJlIGZpbmUgaWYgdGhpcyB3YXMgdGhlIG1haW4g cHJvY2VzcyBpbiB0aGlzIFZNLCBidXQgaXQgaXMKKwlub3QpLgorCisJTWF4 IG92ZXJoZWFkIGNhbiBhbHNvIGJlIHNldCB0byAwLCBob3dldmVyIHRoaXMg aXMgZm9yIHRlc3RpbmcgcHVycG9zZXMKKwlvbmx5IChzZXR0aW5nIGl0IGxv d2VyIHRoYW4gJ3NwYWNlIG92ZXJoZWFkJyB3b3VsZG4ndCBoZWxwIGJlY2F1 c2UgdGhlCisJbWFqb3IgR0Mgd291bGRuJ3QgcnVuIGZhc3QgZW5vdWdoLCBh bmQgY29tcGFjdGlvbiBkb2VzIGhhdmUgYQorCXBlcmZvcm1hbmNlIGNvc3Q6 IHdlIGNhbiBvbmx5IGNvbXBhY3QgY29udGlndW91cyByZWdpb25zLCBzbyBt ZW1vcnkgaGFzCisJdG8gYmUgbW92ZWQgYXJvdW5kKS4KKworCU1heCBvdmVy aGVhZCBjb250cm9scyBob3cgb2Z0ZW4gdGhlIGhlYXAgaXMgY29tcGFjdGVk LCB3aGljaCBpcyB1c2VmdWwKKwlpZiB0aGVyZSBhcmUgYnVyc3Qgb2YgYWN0 aXZpdHkgZm9sbG93ZWQgYnkgbG9uZyBwZXJpb2RzIG9mIGlkbGUgc3RhdGUs CisJb3IgaWYgYSBkb21haW4gcXVpdHMsIGV0Yy4gQ29tcGFjdGlvbiByZXR1 cm5zIG1lbW9yeSB0byB0aGUgT1MuCisKKwl3YXN0ZWQgPSBsaXZlICogc3Bh Y2Vfb3ZlcmhlYWQgLyAxMDAKKworCUZvciBnbG9iYWxseSBvdmVycmlkaW5n IHRoZSBHQyBzZXR0aW5ncyBvbmUgY2FuIHVzZSBPQ0FNTFJVTlBBUkFNLAor CWhvd2V2ZXIgd2UgcHJvdmlkZSBhIGNvbmZpZyBmaWxlIG92ZXJyaWRlIHRv IGJlIGNvbnNpc3RlbnQgd2l0aCBvdGhlcgorCW94ZW5zdG9yZWQgc2V0dGlu Z3MuCisKKwlPbmUgbWlnaHQgd2FudCB0byBkeW5hbWljYWxseSBhZGp1c3Qg dGhlIG92ZXJoZWFkIHNldHRpbmcgYmFzZWQgb24gdXNlZAorCW1lbW9yeSwg aS5lLiB0byB1c2UgYSBmaXhlZCB1cHBlciBib3VuZCBpbiBieXRlcywgbm90 IHBlcmNlbnRhZ2UuIEhvd2V2ZXIKKwltZWFzdXJlbWVudHMgc2hvdyB0aGF0 IHN1Y2ggYWRqdXN0bWVudHMgaW5jcmVhc2UgR0Mgb3ZlcmhlYWQgbWFzc2l2 ZWx5LAorCXdoaWxlIHN0aWxsIG5vdCBndWFyYW50ZWVpbmcgdGhhdCBtZW1v cnkgaXMgcmV0dXJuZWQgYW55IG1vcmUgcXVpY2tseQorCXRoYW4gd2l0aCBh IHBlcmNlbnRhZ2UgYmFzZWQgc2V0dGluZy4KKworCVRoZSBhbGxvY2F0aW9u IHBvbGljeSBjb3VsZCBhbHNvIGJlIHR3ZWFrZWQsIGUuZy4gZmlyc3QgZml0 IHdvdWxkIHJlZHVjZQorCWZyYWdtZW50YXRpb24gYW5kIHRodXMgbWVtb3J5 IHVzYWdlLCBidXQgdGhlIGRvY3VtZW50YXRpb24gd2FybnMgdGhhdCBpdAor CWNhbiBiZSBzZW5zaWJseSBzbG93ZXIsIGFuZCBpbmRlZWQgb25lIG9mIG91 ciBvd24gdGVzdGNhc2VzIGNhbiB0cmlnZ2VyCisJc3VjaCBhIGNvcm5lciBj YXNlIHdoZXJlIGl0IGlzIG11bHRpcGxlIHRpbWVzIHNsb3dlciwgc28gaXQg aXMgYmVzdCB0byBrZWVwCisJdGhlIGRlZmF1bHQgYWxsb2NhdGlvbiBwb2xp Y3kgKG5leHQtZml0L2Jlc3QtZml0IGRlcGVuZGluZyBvbiB2ZXJzaW9uKS4K KworCVRoZXJlIGFyZSBvdGhlciB0d2Vha3MgdGhhdCBjYW4gYmUgYXR0ZW1w dGVkIGluIHRoZSBmdXR1cmUsIGUuZy4gc2V0dGluZworCSd1bGltaXQgLXYn IHRvIDc1JSBvZiBSQU0sIGhvd2V2ZXIgZ2V0dGluZyB0aGUga2VybmVsIHRv IGFjdHVhbGx5IHJldHVybgorCU5VTEwgZnJvbSBhbGxvY2F0aW9ucyBpcyBk aWZmaWN1bHQgZXZlbiB3aXRoIHRoYXQgc2V0dGluZywgYW5kIHdpdGhvdXQg YQorCU5VTEwgdGhlIGVtZXJnZW5jeSBHQyB3b24ndCBiZSB0cmlnZ2VycmVk LgorCVBlcmhhcHMgY2dyb3VwIGxpbWl0cyBjb3VsZCBoZWxwLCBidXQgZm9y IG5vdyB0d2VhayB0aGUgc2FmZXN0IG9ubHkuCisqKQorCitsZXQgdHdlYWtf Z2MgKCkgPQorCUdjLnNldCB7IChHYy5nZXQgKCkpIHdpdGggR2MubWF4X292 ZXJoZWFkID0gIURlZmluZS5nY19tYXhfb3ZlcmhlYWQgfQorCisKIGxldCBf ID0KIAlsZXQgY2YgPSBkb19hcmd2IGluCiAJbGV0IHBpZGZpbGUgPQpAQCAt Mjc0LDYgKzMzNiw4IEBAIGxldCBfID0KIAkJCWRlZmF1bHRfcGlkZmlsZQog CQlpbgogCisJdHdlYWtfZ2MgKCk7CisKIAkodHJ5CiAJCVVuaXhleHQubWtk aXJfcmVjIChGaWxlbmFtZS5kaXJuYW1lIHBpZGZpbGUpIDBvNzU1CiAJd2l0 aCBfIC0+Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-oxenstored-04.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-oxenstored-04.patch" Content-Transfer-Encoding: base64 RnJvbSBmZDZkOWNkM2QyMGU0OTZiZGJmM2UwYTA3MzU0ZjY1ZGUwYmNmNGFl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogRnJpLCAyOSBKdWwgMjAyMiAxODo1MzoyOSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC9saWJzL3hiOiBoaWRlIHR5cGUgb2YgWGIudApN SU1FLVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNo YXJzZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoK SGlkaW5nIHRoZSB0eXBlIHdpbGwgbWFrZSBpdCBlYXNpZXIgdG8gY2hhbmdl IHRoZSBpbXBsZW1lbnRhdGlvbgppbiB0aGUgZnV0dXJlIHdpdGhvdXQgYnJl YWtpbmcgY29kZSB0aGF0IHJlbGllcyBvbiBpdC4KCk5vIGZ1bmN0aW9uYWwg Y2hhbmdlLgoKU2lnbmVkLW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4u dG9yb2tAY2l0cml4LmNvbT4KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcg PGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4KKGNoZXJyeSBwaWNrZWQg ZnJvbSBjb21taXQgN2FkZTMwYTE0NTE3MzRkMDQxMzYzYzc1MGE2NWQzMjJl MjViNDdiYSkKClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBh bWF6b24uY29tPgpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yi94 Yi5tbCBiL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWwKaW5kZXggMTA0ZDMx OWQ3NzQ3Li44NDA0ZGRkOGE2ODIgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1s L2xpYnMveGIveGIubWwKKysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5t bApAQCAtMTk2LDYgKzE5Niw5IEBAIGxldCBwZWVrX291dHB1dCBjb24gPSBR dWV1ZS5wZWVrIGNvbi5wa3Rfb3V0CiBsZXQgaW5wdXRfbGVuIGNvbiA9IFF1 ZXVlLmxlbmd0aCBjb24ucGt0X2luCiBsZXQgaGFzX2luX3BhY2tldCBjb24g PSBRdWV1ZS5sZW5ndGggY29uLnBrdF9pbiA+IDAKIGxldCBnZXRfaW5fcGFj a2V0IGNvbiA9IFF1ZXVlLnBvcCBjb24ucGt0X2luCitsZXQgaGFzX3BhcnRp YWxfaW5wdXQgY29uID0gbWF0Y2ggY29uLnBhcnRpYWxfaW4gd2l0aAorCXwg SGF2ZUhkciBfIC0+IHRydWUKKwl8IE5vSGRyIChuLCBfKSAtPiBuIDwgUGFy dGlhbC5oZWFkZXJfc2l6ZSAoKQogbGV0IGhhc19tb3JlX2lucHV0IGNvbiA9 CiAJbWF0Y2ggY29uLmJhY2tlbmQgd2l0aAogCXwgRmQgXyAgICAgICAgIC0+ IGZhbHNlCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aSBiL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWxpCmluZGV4IDNhMDBkYTZj ZGRjMS4uNzk0ZTM1YmIzNDNlIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9s aWJzL3hiL3hiLm1saQorKysgYi90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aQpAQCAtNjYsMTMgKzY2LDcgQEAgdHlwZSBiYWNrZW5kX21tYXAgPSB7CiB0 eXBlIGJhY2tlbmRfZmQgPSB7IGZkIDogVW5peC5maWxlX2Rlc2NyOyB9CiB0 eXBlIGJhY2tlbmQgPSBGZCBvZiBiYWNrZW5kX2ZkIHwgWGVubW1hcCBvZiBi YWNrZW5kX21tYXAKIHR5cGUgcGFydGlhbF9idWYgPSBIYXZlSGRyIG9mIFBh cnRpYWwucGt0IHwgTm9IZHIgb2YgaW50ICogYnl0ZXMKLXR5cGUgdCA9IHsK LSAgYmFja2VuZCA6IGJhY2tlbmQ7Ci0gIHBrdF9pbiA6IFBhY2tldC50IFF1 ZXVlLnQ7Ci0gIHBrdF9vdXQgOiBQYWNrZXQudCBRdWV1ZS50OwotICBtdXRh YmxlIHBhcnRpYWxfaW4gOiBwYXJ0aWFsX2J1ZjsKLSAgbXV0YWJsZSBwYXJ0 aWFsX291dCA6IHN0cmluZzsKLX0KK3R5cGUgdAogdmFsIGluaXRfcGFydGlh bF9pbiA6IHVuaXQgLT4gcGFydGlhbF9idWYKIHZhbCByZWNvbm5lY3QgOiB0 IC0+IHVuaXQKIHZhbCBxdWV1ZSA6IHQgLT4gUGFja2V0LnQgLT4gdW5pdApA QCAtOTcsNiArOTEsNyBAQCB2YWwgaGFzX291dHB1dCA6IHQgLT4gYm9vbAog dmFsIHBlZWtfb3V0cHV0IDogdCAtPiBQYWNrZXQudAogdmFsIGlucHV0X2xl biA6IHQgLT4gaW50CiB2YWwgaGFzX2luX3BhY2tldCA6IHQgLT4gYm9vbAor dmFsIGhhc19wYXJ0aWFsX2lucHV0IDogdCAtPiBib29sCiB2YWwgZ2V0X2lu X3BhY2tldCA6IHQgLT4gUGFja2V0LnQKIHZhbCBoYXNfbW9yZV9pbnB1dCA6 IHQgLT4gYm9vbAogdmFsIGlzX3NlbGVjdGFibGUgOiB0IC0+IGJvb2wKZGlm ZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9uLm1s IGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Nvbm5lY3Rpb24ubWwKaW5kZXgg NjVmOTllYTZmMjhhLi4zOGI0NzM2M2ExNzMgMTAwNjQ0Ci0tLSBhL3Rvb2xz L29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9uLm1sCisrKyBiL3Rvb2xzL29j YW1sL3hlbnN0b3JlZC9jb25uZWN0aW9uLm1sCkBAIC0xMjUsOSArMTI1LDcg QEAgbGV0IGdldF9wZXJtIGNvbiA9CiBsZXQgc2V0X3RhcmdldCBjb24gdGFy Z2V0X2RvbWlkID0KIAljb24ucGVybSA8LSBQZXJtcy5Db25uZWN0aW9uLnNl dF90YXJnZXQgKGdldF9wZXJtIGNvbikgfnBlcm1zOltQZXJtcy5SRUFEOyBQ ZXJtcy5XUklURV0gdGFyZ2V0X2RvbWlkCiAKLWxldCBpc19iYWNrZW5kX21t YXAgY29uID0gbWF0Y2ggY29uLnhiLlhlbmJ1cy5YYi5iYWNrZW5kIHdpdGgK LQl8IFhlbmJ1cy5YYi5YZW5tbWFwIF8gLT4gdHJ1ZQotCXwgXyAtPiBmYWxz ZQorbGV0IGlzX2JhY2tlbmRfbW1hcCBjb24gPSBYZW5idXMuWGIuaXNfbW1h cCBjb24ueGIKIAogbGV0IHNlbmRfcmVwbHkgY29uIHRpZCByaWQgdHkgZGF0 YSA9CiAJaWYgKFN0cmluZy5sZW5ndGggZGF0YSkgPiB4ZW5zdG9yZV9wYXls b2FkX21heCAmJiAoaXNfYmFja2VuZF9tbWFwIGNvbikgdGhlbgpAQCAtMjgw LDkgKzI3OCw3IEBAIGxldCBnZXRfdHJhbnNhY3Rpb24gY29uIHRpZCA9CiAK IGxldCBkb19pbnB1dCBjb24gPSBYZW5idXMuWGIuaW5wdXQgY29uLnhiCiBs ZXQgaGFzX2lucHV0IGNvbiA9IFhlbmJ1cy5YYi5oYXNfaW5fcGFja2V0IGNv bi54YgotbGV0IGhhc19wYXJ0aWFsX2lucHV0IGNvbiA9IG1hdGNoIGNvbi54 Yi5YZW5idXMuWGIucGFydGlhbF9pbiB3aXRoCi0JfCBIYXZlSGRyIF8gLT4g dHJ1ZQotCXwgTm9IZHIgKG4sIF8pIC0+IG4gPCBYZW5idXMuUGFydGlhbC5o ZWFkZXJfc2l6ZSAoKQorbGV0IGhhc19wYXJ0aWFsX2lucHV0IGNvbiA9IFhl bmJ1cy5YYi5oYXNfcGFydGlhbF9pbnB1dCBjb24ueGIKIGxldCBwb3BfaW4g Y29uID0gWGVuYnVzLlhiLmdldF9pbl9wYWNrZXQgY29uLnhiCiBsZXQgaGFz X21vcmVfaW5wdXQgY29uID0gWGVuYnVzLlhiLmhhc19tb3JlX2lucHV0IGNv bi54YgogCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-oxenstored-05.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-oxenstored-05.patch" Content-Transfer-Encoding: base64 RnJvbSBmMTNmZTU5MDMzNjE5NTNlNGNjZjg2MDJiOWM4ZGY3ZTY0NTY4ZDU1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMiArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogQ2hhbmdlIFhiLmlucHV0IHRvIHJldHVybiBQ YWNrZXQudCBvcHRpb24KTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBl OiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXIt RW5jb2Rpbmc6IDhiaXQKClRoZSBxdWV1ZSBoZXJlIHdvdWxkIG9ubHkgZXZl ciBob2xkIGF0IG1vc3Qgb25lIGVsZW1lbnQuICBUaGlzIHdpbGwgc2ltcGxp ZnkKZm9sbG93LXVwIHBhdGNoZXMuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMy Ni4KClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24u Y29tPgpTaWduZWQtb2ZmLWJ5OiBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jv a0BjaXRyaXguY29tPgpBY2tlZC1ieTogQ2hyaXN0aWFuIExpbmRpZyA8Y2hy aXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xz L29jYW1sL2xpYnMveGIveGIubWwgYi90b29scy9vY2FtbC9saWJzL3hiL3hi Lm1sCmluZGV4IDg0MDRkZGQ4YTY4Mi4uMTY1ZmQ0YTFlZGY0IDEwMDY0NAot LS0gYS90b29scy9vY2FtbC9saWJzL3hiL3hiLm1sCisrKyBiL3Rvb2xzL29j YW1sL2xpYnMveGIveGIubWwKQEAgLTQ1LDcgKzQ1LDYgQEAgdHlwZSBwYXJ0 aWFsX2J1ZiA9IEhhdmVIZHIgb2YgUGFydGlhbC5wa3QgfCBOb0hkciBvZiBp bnQgKiBieXRlcwogdHlwZSB0ID0KIHsKIAliYWNrZW5kOiBiYWNrZW5kOwot CXBrdF9pbjogUGFja2V0LnQgUXVldWUudDsKIAlwa3Rfb3V0OiBQYWNrZXQu dCBRdWV1ZS50OwogCW11dGFibGUgcGFydGlhbF9pbjogcGFydGlhbF9idWY7 CiAJbXV0YWJsZSBwYXJ0aWFsX291dDogc3RyaW5nOwpAQCAtNjIsNyArNjEs NiBAQCBsZXQgcmVjb25uZWN0IHQgPSBtYXRjaCB0LmJhY2tlbmQgd2l0aAog CQlYc19yaW5nLmNsb3NlIGJhY2tlbmQubW1hcDsKIAkJYmFja2VuZC5ldmVu dGNobl9ub3RpZnkgKCk7CiAJCSgqIENsZWFyIG91ciBvbGQgY29ubmVjdGlv biBzdGF0ZSAqKQotCQlRdWV1ZS5jbGVhciB0LnBrdF9pbjsKIAkJUXVldWUu Y2xlYXIgdC5wa3Rfb3V0OwogCQl0LnBhcnRpYWxfaW4gPC0gaW5pdF9wYXJ0 aWFsX2luICgpOwogCQl0LnBhcnRpYWxfb3V0IDwtICIiCkBAIC0xMjQsNyAr MTIyLDYgQEAgbGV0IG91dHB1dCBjb24gPQogCiAoKiBOQjogY2FuIHRocm93 IFJlY29ubmVjdCAqKQogbGV0IGlucHV0IGNvbiA9Ci0JbGV0IG5ld3BhY2tl dCA9IHJlZiBmYWxzZSBpbgogCWxldCB0b19yZWFkID0KIAkJbWF0Y2ggY29u LnBhcnRpYWxfaW4gd2l0aAogCQl8IEhhdmVIZHIgcGFydGlhbF9wa3QgLT4g UGFydGlhbC50b19jb21wbGV0ZSBwYXJ0aWFsX3BrdApAQCAtMTQzLDIxICsx NDAsMTkgQEAgbGV0IGlucHV0IGNvbiA9CiAJCWlmIFBhcnRpYWwudG9fY29t cGxldGUgcGFydGlhbF9wa3QgPSAwIHRoZW4gKAogCQkJbGV0IHBrdCA9IFBh Y2tldC5vZl9wYXJ0aWFscGt0IHBhcnRpYWxfcGt0IGluCiAJCQljb24ucGFy dGlhbF9pbiA8LSBpbml0X3BhcnRpYWxfaW4gKCk7Ci0JCQlRdWV1ZS5wdXNo IHBrdCBjb24ucGt0X2luOwotCQkJbmV3cGFja2V0IDo9IHRydWUKLQkJKQor CQkJU29tZSBwa3QKKwkJKSBlbHNlIE5vbmUKIAl8IE5vSGRyIChpLCBidWYp ICAgICAgLT4KIAkJKCogd2UgY29tcGxldGUgdGhlIHBhcnRpYWwgaGVhZGVy ICopCiAJCWlmIHN6ID4gMCB0aGVuCiAJCQlCeXRlcy5ibGl0IGIgMCBidWYg KFBhcnRpYWwuaGVhZGVyX3NpemUgKCkgLSBpKSBzejsKIAkJY29uLnBhcnRp YWxfaW4gPC0gaWYgc3ogPSBpIHRoZW4KLQkJCUhhdmVIZHIgKFBhcnRpYWwu b2Zfc3RyaW5nIChCeXRlcy50b19zdHJpbmcgYnVmKSkgZWxzZSBOb0hkciAo aSAtIHN6LCBidWYpCi0JKTsKLQkhbmV3cGFja2V0CisJCQlIYXZlSGRyIChQ YXJ0aWFsLm9mX3N0cmluZyAoQnl0ZXMudG9fc3RyaW5nIGJ1ZikpIGVsc2Ug Tm9IZHIgKGkgLSBzeiwgYnVmKTsKKwkJTm9uZQorCSkKIAogbGV0IG5ld2Nv biBiYWNrZW5kID0gewogCWJhY2tlbmQgPSBiYWNrZW5kOwotCXBrdF9pbiA9 IFF1ZXVlLmNyZWF0ZSAoKTsKIAlwa3Rfb3V0ID0gUXVldWUuY3JlYXRlICgp OwogCXBhcnRpYWxfaW4gPSBpbml0X3BhcnRpYWxfaW4gKCk7CiAJcGFydGlh bF9vdXQgPSAiIjsKQEAgLTE5Myw5ICsxODgsNiBAQCBsZXQgaGFzX291dHB1 dCBjb24gPSBoYXNfbmV3X291dHB1dCBjb24gfHwgaGFzX29sZF9vdXRwdXQg Y29uCiAKIGxldCBwZWVrX291dHB1dCBjb24gPSBRdWV1ZS5wZWVrIGNvbi5w a3Rfb3V0CiAKLWxldCBpbnB1dF9sZW4gY29uID0gUXVldWUubGVuZ3RoIGNv bi5wa3RfaW4KLWxldCBoYXNfaW5fcGFja2V0IGNvbiA9IFF1ZXVlLmxlbmd0 aCBjb24ucGt0X2luID4gMAotbGV0IGdldF9pbl9wYWNrZXQgY29uID0gUXVl dWUucG9wIGNvbi5wa3RfaW4KIGxldCBoYXNfcGFydGlhbF9pbnB1dCBjb24g PSBtYXRjaCBjb24ucGFydGlhbF9pbiB3aXRoCiAJfCBIYXZlSGRyIF8gLT4g dHJ1ZQogCXwgTm9IZHIgKG4sIF8pIC0+IG4gPCBQYXJ0aWFsLmhlYWRlcl9z aXplICgpCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aSBiL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWxpCmluZGV4IDc5NGUzNWJi MzQzZS4uOTFjNjgyMTYyY2VhIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9s aWJzL3hiL3hiLm1saQorKysgYi90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aQpAQCAtNzcsNyArNzcsNyBAQCB2YWwgd3JpdGVfZmQgOiBiYWNrZW5kX2Zk IC0+ICdhIC0+IHN0cmluZyAtPiBpbnQgLT4gaW50CiB2YWwgd3JpdGVfbW1h cCA6IGJhY2tlbmRfbW1hcCAtPiAnYSAtPiBzdHJpbmcgLT4gaW50IC0+IGlu dAogdmFsIHdyaXRlIDogdCAtPiBzdHJpbmcgLT4gaW50IC0+IGludAogdmFs IG91dHB1dCA6IHQgLT4gYm9vbAotdmFsIGlucHV0IDogdCAtPiBib29sCit2 YWwgaW5wdXQgOiB0IC0+IFBhY2tldC50IG9wdGlvbgogdmFsIG5ld2NvbiA6 IGJhY2tlbmQgLT4gdAogdmFsIG9wZW5fZmQgOiBVbml4LmZpbGVfZGVzY3Ig LT4gdAogdmFsIG9wZW5fbW1hcCA6IFhlbm1tYXAubW1hcF9pbnRlcmZhY2Ug LT4gKHVuaXQgLT4gdW5pdCkgLT4gdApAQCAtODksMTAgKzg5LDcgQEAgdmFs IGhhc19uZXdfb3V0cHV0IDogdCAtPiBib29sCiB2YWwgaGFzX29sZF9vdXRw dXQgOiB0IC0+IGJvb2wKIHZhbCBoYXNfb3V0cHV0IDogdCAtPiBib29sCiB2 YWwgcGVla19vdXRwdXQgOiB0IC0+IFBhY2tldC50Ci12YWwgaW5wdXRfbGVu IDogdCAtPiBpbnQKLXZhbCBoYXNfaW5fcGFja2V0IDogdCAtPiBib29sCiB2 YWwgaGFzX3BhcnRpYWxfaW5wdXQgOiB0IC0+IGJvb2wKLXZhbCBnZXRfaW5f cGFja2V0IDogdCAtPiBQYWNrZXQudAogdmFsIGhhc19tb3JlX2lucHV0IDog dCAtPiBib29sCiB2YWwgaXNfc2VsZWN0YWJsZSA6IHQgLT4gYm9vbAogdmFs IGdldF9mZCA6IHQgLT4gVW5peC5maWxlX2Rlc2NyCmRpZmYgLS1naXQgYS90 b29scy9vY2FtbC9saWJzL3hzL3hzcmF3Lm1sIGIvdG9vbHMvb2NhbWwvbGli cy94cy94c3Jhdy5tbAppbmRleCBkOTgyZmIyNGRiYjEuLjQ1MWY4YjM4ZGJj YyAxMDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94cy94c3Jhdy5tbAor KysgYi90b29scy9vY2FtbC9saWJzL3hzL3hzcmF3Lm1sCkBAIC05NCwyNiAr OTQsMTggQEAgbGV0IHBrdF9zZW5kIGNvbiA9CiAJZG9uZQogCiAoKiByZWNl aXZlIG9uZSBwYWNrZXQgLSBjYW4gc2xlZXAgKikKLWxldCBwa3RfcmVjdiBj b24gPQotCWxldCB3b3JrZG9uZSA9IHJlZiBmYWxzZSBpbgotCXdoaWxlIG5v dCAhd29ya2RvbmUKLQlkbwotCQl3b3JrZG9uZSA6PSBYYi5pbnB1dCBjb24u eGIKLQlkb25lOwotCVhiLmdldF9pbl9wYWNrZXQgY29uLnhiCitsZXQgcmVj IHBrdF9yZWN2IGNvbiA9CisJbWF0Y2ggWGIuaW5wdXQgY29uLnhiIHdpdGgK Kwl8IFNvbWUgcGFja2V0IC0+IHBhY2tldAorCXwgTm9uZSAtPiBwa3RfcmVj diBjb24KIAogbGV0IHBrdF9yZWN2X3RpbWVvdXQgY29uIHRpbWVvdXQgPQog CWxldCBmZCA9IFhiLmdldF9mZCBjb24ueGIgaW4KIAlsZXQgciwgXywgXyA9 IFVuaXguc2VsZWN0IFsgZmQgXSBbXSBbXSB0aW1lb3V0IGluCiAJaWYgciA9 IFtdIHRoZW4KIAkJdHJ1ZSwgTm9uZQotCWVsc2UgKAotCQlsZXQgd29ya2Rv bmUgPSBYYi5pbnB1dCBjb24ueGIgaW4KLQkJaWYgd29ya2RvbmUgdGhlbgot CQkJZmFsc2UsIChTb21lIChYYi5nZXRfaW5fcGFja2V0IGNvbi54YikpCi0J CWVsc2UKLQkJCWZhbHNlLCBOb25lCi0JKQorCWVsc2UKKwkJZmFsc2UsIFhi LmlucHV0IGNvbi54YgogCiBsZXQgcXVldWVfd2F0Y2hldmVudCBjb24gZGF0 YSA9CiAJbGV0IGxzID0gc3BsaXRfc3RyaW5nIH5saW1pdDoyICdcMDAwJyBk YXRhIGluCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvY29u bmVjdGlvbi5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9u Lm1sCmluZGV4IDM4YjQ3MzYzYTE3My4uY2MyMGUwNDdkMmI5IDEwMDY0NAot LS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQvY29ubmVjdGlvbi5tbAorKysg Yi90b29scy9vY2FtbC94ZW5zdG9yZWQvY29ubmVjdGlvbi5tbApAQCAtMjc3 LDkgKzI3Nyw3IEBAIGxldCBnZXRfdHJhbnNhY3Rpb24gY29uIHRpZCA9CiAJ SGFzaHRibC5maW5kIGNvbi50cmFuc2FjdGlvbnMgdGlkCiAKIGxldCBkb19p bnB1dCBjb24gPSBYZW5idXMuWGIuaW5wdXQgY29uLnhiCi1sZXQgaGFzX2lu cHV0IGNvbiA9IFhlbmJ1cy5YYi5oYXNfaW5fcGFja2V0IGNvbi54YgogbGV0 IGhhc19wYXJ0aWFsX2lucHV0IGNvbiA9IFhlbmJ1cy5YYi5oYXNfcGFydGlh bF9pbnB1dCBjb24ueGIKLWxldCBwb3BfaW4gY29uID0gWGVuYnVzLlhiLmdl dF9pbl9wYWNrZXQgY29uLnhiCiBsZXQgaGFzX21vcmVfaW5wdXQgY29uID0g WGVuYnVzLlhiLmhhc19tb3JlX2lucHV0IGNvbi54YgogCiBsZXQgaGFzX291 dHB1dCBjb24gPSBYZW5idXMuWGIuaGFzX291dHB1dCBjb24ueGIKQEAgLTMw Nyw3ICszMDUsNyBAQCBsZXQgaXNfYmFkIGNvbiA9IG1hdGNoIGNvbi5kb20g d2l0aCBOb25lIC0+IGZhbHNlIHwgU29tZSBkb20gLT4gRG9tYWluLmlzX2Jh ZF9kbwogICAgUmVzdHJpY3Rpb25zIGJlbG93IGNhbiBiZSByZWxheGVkIG9u Y2UgeGVuc3RvcmVkIGxlYXJucyB0byBkdW1wIG1vcmUKICAgIG9mIGl0cyBs aXZlIHN0YXRlIGluIGEgc2FmZSB3YXkgKikKIGxldCBoYXNfZXh0cmFfY29u bmVjdGlvbl9kYXRhIGNvbiA9Ci0JbGV0IGhhc19pbiA9IGhhc19pbnB1dCBj b24gfHwgaGFzX3BhcnRpYWxfaW5wdXQgY29uIGluCisJbGV0IGhhc19pbiA9 IGhhc19wYXJ0aWFsX2lucHV0IGNvbiBpbgogCWxldCBoYXNfb3V0ID0gaGFz X291dHB1dCBjb24gaW4KIAlsZXQgaGFzX3NvY2tldCA9IGNvbi5kb20gPSBO b25lIGluCiAJbGV0IGhhc19ub25kZWZhdWx0X3Blcm1zID0gbWFrZV9wZXJt IGNvbi5kb20gPD4gY29uLnBlcm0gaW4KZGlmZiAtLWdpdCBhL3Rvb2xzL29j YW1sL3hlbnN0b3JlZC9wcm9jZXNzLm1sIGIvdG9vbHMvb2NhbWwveGVuc3Rv cmVkL3Byb2Nlc3MubWwKaW5kZXggNmEzNDM1YzI2NWQzLi4yZDY3NDU2YTJh YTAgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9wcm9jZXNz Lm1sCisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9wcm9jZXNzLm1sCkBA IC0xOTUsMTAgKzE5NSw5IEBAIGxldCBwYXJzZV9saXZlX3VwZGF0ZSBhcmdz ID0KIAkJCXwgXyB3aGVuIFVuaXguZ2V0dGltZW9mZGF5ICgpIDwgdC5kZWFk bGluZSAtPiBmYWxzZQogCQkJfCBsIC0+CiAJCQkJd2FybiAidGltZW91dCBy ZWFjaGVkOiBoYXZlIHRvIHdhaXQsIG1pZ3JhdGUgb3Igc2h1dGRvd24gJWQg ZG9tYWluczoiIChMaXN0Lmxlbmd0aCBsKTsKLQkJCQlsZXQgbXNncyA9IExp c3QucmV2X21hcCAoZnVuIGNvbiAtPiBQcmludGYuc3ByaW50ZiAiJXM6ICVk IHR4LCBpbjogJWIsIG91dDogJWIsIHBlcm06ICVzIgorCQkJCWxldCBtc2dz ID0gTGlzdC5yZXZfbWFwIChmdW4gY29uIC0+IFByaW50Zi5zcHJpbnRmICIl czogJWQgdHgsIG91dDogJWIsIHBlcm06ICVzIgogCQkJCQkoQ29ubmVjdGlv bi5nZXRfZG9tc3RyIGNvbikKIAkJCQkJKENvbm5lY3Rpb24ubnVtYmVyX29m X3RyYW5zYWN0aW9ucyBjb24pCi0JCQkJCShDb25uZWN0aW9uLmhhc19pbnB1 dCBjb24pCiAJCQkJCShDb25uZWN0aW9uLmhhc19vdXRwdXQgY29uKQogCQkJ CQkoQ29ubmVjdGlvbi5nZXRfcGVybSBjb24gfD4gUGVybXMuQ29ubmVjdGlv bi50b19zdHJpbmcpCiAJCQkJCSkgbCBpbgpAQCAtNzA1LDE2ICs3MDQsMTcg QEAgbGV0IGRvX2lucHV0IHN0b3JlIGNvbnMgZG9tcyBjb24gPQogCQkJaW5m byAiJXMgcmVxdWVzdHMgYSByZWNvbm5lY3QiIChDb25uZWN0aW9uLmdldF9k b21zdHIgY29uKTsKIAkJCUhpc3RvcnkucmVjb25uZWN0IGNvbjsKIAkJCWlu Zm8gIiVzIHJlY29ubmVjdGlvbiBjb21wbGV0ZSIgKENvbm5lY3Rpb24uZ2V0 X2RvbXN0ciBjb24pOwotCQkJZmFsc2UKKwkJCU5vbmUKIAkJfCBGYWlsdXJl IGV4cCAtPgogCQkJZXJyb3IgImNhdWdodCBleGNlcHRpb24gJXMiIGV4cDsK IAkJCWVycm9yICJnb3QgYSBiYWQgY2xpZW50ICVzIiAoc3ByaW50ZiAiJS04 cyIgKENvbm5lY3Rpb24uZ2V0X2RvbXN0ciBjb24pKTsKIAkJCUNvbm5lY3Rp b24ubWFya19hc19iYWQgY29uOwotCQkJZmFsc2UKKwkJCU5vbmUKIAlpbgog Ci0JaWYgbmV3cGFja2V0IHRoZW4gKAotCQlsZXQgcGFja2V0ID0gQ29ubmVj dGlvbi5wb3BfaW4gY29uIGluCisJbWF0Y2ggbmV3cGFja2V0IHdpdGgKKwl8 IE5vbmUgLT4gKCkKKwl8IFNvbWUgcGFja2V0IC0+CiAJCWxldCB0aWQsIHJp ZCwgdHksIGRhdGEgPSBYZW5idXMuWGIuUGFja2V0LnVucGFjayBwYWNrZXQg aW4KIAkJbGV0IHJlcSA9IHtQYWNrZXQudGlkPXRpZDsgUGFja2V0LnJpZD1y aWQ7IFBhY2tldC50eT10eTsgUGFja2V0LmRhdGE9ZGF0YX0gaW4KIApAQCAt NzI0LDggKzcyNCw3IEBAIGxldCBkb19pbnB1dCBzdG9yZSBjb25zIGRvbXMg Y29uID0KIAkJICAgICAgICAgKFhlbmJ1cy5YYi5PcC50b19zdHJpbmcgdHkp IChzYW5pdGl6ZV9kYXRhIGRhdGEpOyAqKQogCQlwcm9jZXNzX3BhY2tldCB+ c3RvcmUgfmNvbnMgfmRvbXMgfmNvbiB+cmVxOwogCQl3cml0ZV9hY2Nlc3Nf bG9nIH50eSB+dGlkIH5jb246KENvbm5lY3Rpb24uZ2V0X2RvbXN0ciBjb24p IH5kYXRhOwotCQlDb25uZWN0aW9uLmluY3Jfb3BzIGNvbjsKLQkpCisJCUNv bm5lY3Rpb24uaW5jcl9vcHMgY29uCiAKIGxldCBkb19vdXRwdXQgX3N0b3Jl IF9jb25zIF9kb21zIGNvbiA9CiAJaWYgQ29ubmVjdGlvbi5oYXNfb3V0cHV0 IGNvbiB0aGVuICgK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-oxenstored-06.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-oxenstored-06.patch" Content-Transfer-Encoding: base64 RnJvbSAyNDQwYThiNjlhMTE4ZmUxNGU3M2ViNmNhYjRhMDUwOTIyODY2ZjFh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMyArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94YjogQWRkIEJvdW5kZWRRdWV1ZQpNSU1FLVZl cnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9 VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKRW5zdXJl cyB3ZSBjYW5ub3Qgc3RvcmUgbW9yZSB0aGFuIFtjYXBhY2l0eV0gZWxlbWVu dHMgaW4gYSBbUXVldWVdLiAgUmVwbGFjaW5nCmFsbCBRdWV1ZSB3aXRoIHRo aXMgbW9kdWxlIHdpbGwgdGhlbiBlbnN1cmUgYXQgY29tcGlsZSB0aW1lIHRo YXQgYWxsIFF1ZXVlcwphcmUgY29ycmVjdGx5IGJvdW5kIGNoZWNrZWQuCgpF YWNoIGVsZW1lbnQgaW4gdGhlIHF1ZXVlIGhhcyBhIGNsYXNzIHdpdGggaXRz IG93biBsaW1pdHMuICBUaGlzLCBpbiBhCnN1YnNlcXVlbnQgY2hhbmdlLCB3 aWxsIGVuc3VyZSB0aGF0IGNvbW1hbmQgcmVzcG9uc2VzIGNhbiBwcm9jZWVk IGR1cmluZyBhCmZsb29kIG9mIHdhdGNoIGV2ZW50cy4KCk5vIGZ1bmN0aW9u YWwgY2hhbmdlLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRl ZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVk LW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5k aWdAY2l0cml4LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJz L3hiL3hiLm1sIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbAppbmRleCAx NjVmZDRhMWVkZjQuLjQxOTdhMzg4OGE2OCAxMDA2NDQKLS0tIGEvdG9vbHMv b2NhbWwvbGlicy94Yi94Yi5tbAorKysgYi90b29scy9vY2FtbC9saWJzL3hi L3hiLm1sCkBAIC0xNyw2ICsxNyw5OCBAQAogbW9kdWxlIE9wID0gc3RydWN0 IGluY2x1ZGUgT3AgZW5kCiBtb2R1bGUgUGFja2V0ID0gc3RydWN0IGluY2x1 ZGUgUGFja2V0IGVuZAogCittb2R1bGUgQm91bmRlZFF1ZXVlIDogc2lnCisJ dHlwZSAoJ2EsICdiKSB0CisKKwkoKiogW2NyZWF0ZSB+Y2FwYWNpdHkgfmNs YXNzaWZ5IH5saW1pdF0gY3JlYXRlcyBhIHF1ZXVlIHdpdGggbWF4aW11bSBb Y2FwYWNpdHldIGVsZW1lbnRzLgorCSAgICBUaGlzIGlzIGJ1cnN0IGNhcGFj aXR5LCBlYWNoIGVsZW1lbnQgaXMgZnVydGhlciBjbGFzc2lmaWVkIGFjY29y ZGluZyB0byBbY2xhc3NpZnldLAorCSAgICBhbmQgZWFjaCBjbGFzcyBjYW4g aGF2ZSBpdHMgb3duIFtsaW1pdF0uCisJICAgIFtjYXBhY2l0eV0gaXMgZW5m b3JjZWQgYXMgYW4gb3ZlcmFsbCBsaW1pdC4KKwkgICAgVGhlIFtsaW1pdF0g Y2FuIGJlIGR5bmFtaWMsIGFuZCBjYW4gYmUgc21hbGxlciB0aGFuIHRoZSBu dW1iZXIgb2YgZWxlbWVudHMgYWxyZWFkeSBxdWV1ZWQgb2YgdGhhdCBjbGFz cywKKwkgICAgaW4gd2hpY2ggY2FzZSB0aG9zZSBlbGVtZW50cyBhcmUgY29u c2lkZXJlZCB0byB1c2UgImJ1cnN0IGNhcGFjaXR5Ii4KKwkgICopCisJdmFs IGNyZWF0ZTogY2FwYWNpdHk6aW50IC0+IGNsYXNzaWZ5OignYSAtPiAnYikg LT4gbGltaXQ6KCdiIC0+IGludCkgLT4gKCdhLCAnYikgdAorCisJKCoqIFtj bGVhciBxXSBkaXNjYXJkcyBhbGwgZWxlbWVudHMgZnJvbSBbcV0gKikKKwl2 YWwgY2xlYXI6ICgnYSwgJ2IpIHQgLT4gdW5pdAorCisJKCoqIFtjYW5fcHVz aCBxXSB3aGVuIFtsZW5ndGggcSA8IGNhcGFjaXR5XS4JKikKKwl2YWwgY2Fu X3B1c2g6ICgnYSwgJ2IpIHQgLT4gJ2IgLT4gYm9vbAorCisJKCoqIFtwdXNo IGUgcV0gYWRkcyBbZV0gYXQgdGhlIGVuZCBvZiBxdWV1ZSBbcV0gaWYgW2Nh bl9wdXNoIHFdLCBvciByZXR1cm5zIFtOb25lXS4gKikKKwl2YWwgcHVzaDog J2EgLT4gKCdhLCAnYikgdCAtPiB1bml0IG9wdGlvbgorCisJKCoqIFtwb3Ag cV0gcmVtb3ZlcyBhbmQgcmV0dXJucyBmaXJzdCBlbGVtZW50IGluIFtxXSwg b3IgcmFpc2VzIFtRdWV1ZS5FbXB0eV0uICopCisJdmFsIHBvcDogKCdhLCAn YikgdCAtPiAnYQorCisJKCoqIFtwZWVrIHFdIHJldHVybnMgdGhlIGZpcnN0 IGVsZW1lbnQgaW4gW3FdLCBvciByYWlzZXMgW1F1ZXVlLkVtcHR5XS4gICop CisJdmFsIHBlZWsgOiAoJ2EsICdiKSB0IC0+ICdhCisKKwkoKiogW2xlbmd0 aCBxXSByZXR1cm5zIHRoZSBjdXJyZW50IG51bWJlciBvZiBlbGVtZW50cyBp biBbcV0gKikKKwl2YWwgbGVuZ3RoOiAoJ2EsICdiKSB0IC0+IGludAorCisJ KCoqIFtkZWJ1ZyBzdHJpbmdfb2ZfY2xhc3MgcV0gcHJpbnRzIHF1ZXVlIHVz YWdlIHN0YXRpc3RpY3MgaW4gYW4gdW5zcGVjaWZpZWQgaW50ZXJuYWwgZm9y bWF0LiAqKQorCXZhbCBkZWJ1ZzogKCdiIC0+IHN0cmluZykgLT4gKF8sICdi KSB0IC0+IHN0cmluZworZW5kID0gc3RydWN0CisJdHlwZSAoJ2EsICdiKSB0 ID0KKwkJeyBxOiAnYSBRdWV1ZS50CisJCTsgY2FwYWNpdHk6IGludAorCQk7 IGNsYXNzaWZ5OiAnYSAtPiAnYgorCQk7IGxpbWl0OiAnYiAtPiBpbnQKKwkJ OyBjbGFzc19jb3VudDogKCdiLCBpbnQpIEhhc2h0YmwudAorCQl9CisKKwls ZXQgY3JlYXRlIH5jYXBhY2l0eSB+Y2xhc3NpZnkgfmxpbWl0ID0KKwkJeyBj YXBhY2l0eTsgcSA9IFF1ZXVlLmNyZWF0ZSAoKTsgY2xhc3NpZnk7IGxpbWl0 OyBjbGFzc19jb3VudCA9IEhhc2h0YmwuY3JlYXRlIDMgfQorCisJbGV0IGdl dF9jb3VudCB0IGNsYXNzaWZpY2F0aW9uID0gdHJ5IEhhc2h0YmwuZmluZCB0 LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0aW9uIHdpdGggTm90X2ZvdW5kIC0+ IDAKKworCWxldCBjYW5fcHVzaF9pbnRlcm5hbCB0IGNsYXNzaWZpY2F0aW9u IGNsYXNzX2NvdW50ID0KKwkJUXVldWUubGVuZ3RoIHQucSA8IHQuY2FwYWNp dHkgJiYgY2xhc3NfY291bnQgPCB0LmxpbWl0IGNsYXNzaWZpY2F0aW9uCisK KwlsZXQgb2sgPSBTb21lICgpCisKKwlsZXQgcHVzaCBlIHQgPQorCQlsZXQg Y2xhc3NpZmljYXRpb24gPSB0LmNsYXNzaWZ5IGUgaW4KKwkJbGV0IGNsYXNz X2NvdW50ID0gZ2V0X2NvdW50IHQgY2xhc3NpZmljYXRpb24gaW4KKwkJaWYg Y2FuX3B1c2hfaW50ZXJuYWwgdCBjbGFzc2lmaWNhdGlvbiBjbGFzc19jb3Vu dCB0aGVuIGJlZ2luCisJCQlRdWV1ZS5wdXNoIGUgdC5xOworCQkJSGFzaHRi bC5yZXBsYWNlIHQuY2xhc3NfY291bnQgY2xhc3NpZmljYXRpb24gKGNsYXNz X2NvdW50ICsgMSk7CisJCQlvaworCQllbmQKKwkJZWxzZQorCQkJTm9uZQor CisJbGV0IGNhbl9wdXNoIHQgY2xhc3NpZmljYXRpb24gPQorCQljYW5fcHVz aF9pbnRlcm5hbCB0IGNsYXNzaWZpY2F0aW9uIEBAIGdldF9jb3VudCB0IGNs YXNzaWZpY2F0aW9uCisKKwlsZXQgY2xlYXIgdCA9CisJCVF1ZXVlLmNsZWFy IHQucTsKKwkJSGFzaHRibC5yZXNldCB0LmNsYXNzX2NvdW50CisKKwlsZXQg cG9wIHQgPQorCQlsZXQgZSA9IFF1ZXVlLnBvcCB0LnEgaW4KKwkJbGV0IGNs YXNzaWZpY2F0aW9uID0gdC5jbGFzc2lmeSBlIGluCisJCWxldCAoKSA9IG1h dGNoIGdldF9jb3VudCB0IGNsYXNzaWZpY2F0aW9uIC0gMSB3aXRoCisJCXwg MCAtPiBIYXNodGJsLnJlbW92ZSB0LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0 aW9uICgqIHJlZHVjZXMgbWVtdXNhZ2UgKikKKwkJfCBuIC0+IEhhc2h0Ymwu cmVwbGFjZSB0LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0aW9uIG4KKwkJaW4K KwkJZQorCisJbGV0IHBlZWsgdCA9IFF1ZXVlLnBlZWsgdC5xCisJbGV0IGxl bmd0aCB0ID0gUXVldWUubGVuZ3RoIHQucQorCisJbGV0IGRlYnVnIHN0cmlu Z19vZl9jbGFzcyB0ID0KKwkJbGV0IGIgPSBCdWZmZXIuY3JlYXRlIDEyOCBp bgorCQlQcmludGYuYnByaW50ZiBiICJCb3VuZGVkUXVldWUgY2FwYWNpdHk6 ICVkLCB1c2VkOiB7IiB0LmNhcGFjaXR5OworCQlIYXNodGJsLml0ZXIgKGZ1 biBwYWNrZXRfY2xhc3MgY291bnQgLT4KKwkJCVByaW50Zi5icHJpbnRmIGIg IgklczogJWQiIChzdHJpbmdfb2ZfY2xhc3MgcGFja2V0X2NsYXNzKSBjb3Vu dAorCQkpIHQuY2xhc3NfY291bnQ7CisJCVByaW50Zi5icHJpbnRmIGIgIn0i OworCQlCdWZmZXIuY29udGVudHMgYgorZW5kCisKKwogZXhjZXB0aW9uIEVu ZF9vZl9maWxlCiBleGNlcHRpb24gRWFnYWluCiBleGNlcHRpb24gTm9lbnQK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-oxenstored-07.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-oxenstored-07.patch" Content-Transfer-Encoding: base64 RnJvbSBiYzBmMDVlNmYzYTNjOTNjODUzY2VmZmQxZjZkMjAyMmRjMzBmYjc3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNCArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogTGltaXQgbWF4aW11bSBpbi1mbGlnaHQgcmVx dWVzdHMgLyBvdXRzdGFuZGluZyByZXBsaWVzCk1JTUUtVmVyc2lvbjogMS4w CkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250 ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgpJbnRyb2R1Y2UgYSBsaW1p dCBvbiB0aGUgbnVtYmVyIG9mIG91dHN0YW5kaW5nIHJlcGx5IHBhY2tldHMg aW4gdGhlIHhlbmJ1cwpxdWV1ZS4gIFRoaXMgbGltaXRzIHRoZSBudW1iZXIg b2YgaW4tZmxpZ2h0IHJlcXVlc3RzOiB3aGVuIHRoZSBvdXRwdXQgcXVldWUg aXMKZnVsbCB3ZSdsbCBzdG9wIHByb2Nlc3NpbmcgaW5wdXRzIHVudGlsIHRo ZSBvdXRwdXQgcXVldWUgaGFzIHJvb20gYWdhaW4uCgpUbyBhdm9pZCBhIGJ1 c3kgbG9vcCBvbiB0aGUgVW5peCBzb2NrZXQgd2Ugb25seSBhZGQgaXQgdG8g dGhlIHdhdGNoZWQgaW5wdXQKZmlsZSBkZXNjcmlwdG9yIHNldCBpZiB3ZSdk IGJlIGFibGUgdG8gY2FsbCBgaW5wdXRgIG9uIGl0LiAgRXZlbiB0aG91Z2gg RG9tMAppcyB0cnVzdGVkIGFuZCBleGVtcHQgZnJvbSBxdW90YXMgYSBmbG9v ZCBvZiBldmVudHMgbWlnaHQgY2F1c2UgYSBiYWNrbG9nCndoZXJlIGV2ZW50 cyBhcmUgcHJvZHVjZWQgZmFzdGVyIHRoYW4gZGFlbW9ucyBpbiBEb20wIGNh biBjb25zdW1lIHRoZW0sIHdoaWNoCmNvdWxkIGxlYWQgdG8gYW4gdW5ib3Vu ZGVkIHF1ZXVlIHNpemUgYW5kIE9PTS4KClRoZXJlZm9yZSB0aGUgeGVuYnVz IHF1ZXVlIGxpbWl0IG11c3QgYXBwbHkgdG8gYWxsIGNvbm5lY3Rpb25zLCBE b20wIGlzIG5vdApleGVtcHQgZnJvbSBpdCwgYWx0aG91Z2ggaWYgZXZlcnl0 aGluZyB3b3JrcyBjb3JyZWN0bHkgaXQgd2lsbCBldmVudHVhbGx5CmNhdGNo IHVwLgoKVGhpcyBwcmV2ZW50cyBhIG1hbGljaW91cyBndWVzdCBmcm9tIHNl bmRpbmcgbW9yZSBjb21tYW5kcyB3aGlsZSBpdCBoYXMKb3V0c3RhbmRpbmcg d2F0Y2ggZXZlbnRzIG9yIGNvbW1hbmQgcmVwbGllcyBpbiBpdHMgaW5wdXQg cmluZy4gIEhvd2V2ZXIgaWYgaXQKY2FuIGNhdXNlIHRoZSBnZW5lcmF0aW9u IG9mIHdhdGNoIGV2ZW50cyBieSBvdGhlciBtZWFucyAoZS5nLiBieSBEb20w LCBvcgphbm90aGVyIGNvb3BlcmF0aXZlIGd1ZXN0KSBhbmQgc3RvcCByZWFk aW5nIGl0cyBvd24gcmluZyB0aGVuIHdhdGNoIGV2ZW50cwp3b3VsZCd2ZSBx dWV1ZWQgdXAgd2l0aG91dCBsaW1pdC4KClRoZSB4ZW5zdG9yZSBwcm90b2Nv bCBkb2Vzbid0IGhhdmUgYSBiYWNrLXByZXNzdXJlIG1lY2hhbmlzbSwgYW5k IGRvZXNuJ3QKYWxsb3cgZHJvcHBpbmcgd2F0Y2ggZXZlbnRzLiAgSW4gZmFj dCwgZHJvcHBpbmcgd2F0Y2ggZXZlbnRzIGlzIGtub3duIHRvIGJyZWFrCnNv bWUgcGllY2VzIG9mIG5vcm1hbCBmdW5jdGlvbmFsaXR5LiAgVGhpcyBsZWF2 ZXMgbGl0dGxlIGNob2ljZSB0byBzYWZlbHkKaW1wbGVtZW50IHRoZSB4ZW5z dG9yZSBwcm90b2NvbCB3aXRob3V0IGV4cG9zaW5nIHRoZSB4ZW5zdG9yZSBk YWVtb24gdG8Kb3V0LW9mLW1lbW9yeSBhdHRhY2tzLgoKSW1wbGVtZW50IHRo ZSBmaXggYXMgcGlwZXMgd2l0aCBib3VuZGVkIGJ1ZmZlcnM6CiogVXNlIGEg Ym91bmRlZCBidWZmZXIgZm9yIHdhdGNoIGV2ZW50cwoqIFRoZSB3YXRjaCBz dHJ1Y3R1cmUgd2lsbCBoYXZlIGEgYm91bmRlZCByZWNlaXZpbmcgcGlwZSBv ZiB3YXRjaCBldmVudHMKKiBUaGUgc291cmNlIHdpbGwgaGF2ZSBhbiAib3Zl cmZsb3ciIHBpcGUgb2YgcGVuZGluZyB3YXRjaCBldmVudHMgaXQgY291bGRu J3QKICBkZWxpdmVyCgpJdGVtcyBhcmUgcXVldWVkIHVwIG9uIG9uZSBlbmQg YW5kIGFyZSBzZW50IGFzIGZhciBhbG9uZyB0aGUgcGlwZSBhcyBwb3NzaWJs ZToKCiAgc291cmNlIGRvbWFpbiAtPiB3YXRjaCAtPiB4ZW5idXMgb2YgdGFy Z2V0IC0+IHhlbnN0b3JlIHJpbmcvc29ja2V0IG9mIHRhcmdldAoKSWYgdGhl IHBpcGUgaXMgImZ1bGwiIGF0IGFueSBwb2ludCB0aGVuIGJhY2stcHJlc3N1 cmUgaXMgYXBwbGllZCBhbmQgd2UgcHJldmVudAptb3JlIGl0ZW1zIGZyb20g YmVpbmcgcXVldWVkIHVwLiAgRm9yIHRoZSBzb3VyY2UgZG9tYWluIHRoaXMg bWVhbnMgdGhhdCB3ZSdsbApzdG9wIGFjY2VwdGluZyBuZXcgY29tbWFuZHMg YXMgbG9uZyBhcyBpdHMgcGlwZSBidWZmZXIgaXMgbm90IGVtcHR5LgoKQmVm b3JlIHdlIHRyeSB0byBlbnF1ZXVlIGFuIGl0ZW0gd2UgZmlyc3QgY2hlY2sg d2hldGhlciBpdCBpcyBwb3NzaWJsZSB0byBzZW5kCml0IGZ1cnRoZXIgZG93 biB0aGUgcGlwZSwgYnkgYXR0ZW1wdGluZyB0byByZWN1cnNpdmVseSBmbHVz aCB0aGUgcGlwZXMuIFRoaXMKZW5zdXJlcyB0aGF0IHdlIHJldGFpbiB0aGUg b3JkZXIgb2YgZXZlbnRzIGFzIG11Y2ggYXMgcG9zc2libGUuCgpXZSBtaWdo dCBicmVhayBjYXVzYWxpdHkgb2Ygd2F0Y2ggZXZlbnRzIGlmIHRoZSB0YXJn ZXQgZG9tYWluJ3MgcXVldWUgaXMgZnVsbAphbmQgd2UgbmVlZCB0byBzdGFy dCB1c2luZyB0aGUgd2F0Y2gncyBxdWV1ZS4gIFRoaXMgaXMgYSBicmVha2lu ZyBjaGFuZ2UgaW4KdGhlIHhlbnN0b3JlIHByb3RvY29sLCBidXQgb25seSBm b3IgZG9tYWlucyB3aGljaCBhcmUgbm90IHByb2Nlc3NpbmcgdGhlaXIKaW5j b21pbmcgcmluZyBhcyBleHBlY3RlZC4KCldoZW4gYSB3YXRjaCBpcyBkZWxl dGVkIGl0cyBlbnRpcmUgcGVuZGluZyBxdWV1ZSBpcyBkcm9wcGVkIChubyBj b2RlIGlzIG5lZWRlZApmb3IgdGhhdCwgYmVjYXVzZSBpdCBpcyBwYXJ0IG9m IHRoZSAnd2F0Y2gnIHR5cGUpLgoKVGhlcmUgaXMgYSBjYWNoZSBvZiB3YXRj aGVzIHRoYXQgaGF2ZSBwZW5kaW5nIGV2ZW50cyB0aGF0IHdlIGF0dGVtcHQg dG8gZmx1c2gKYXQgZXZlcnkgY3ljbGUgaWYgcG9zc2libGUuCgpJbnRyb2R1 Y2UgMyBsaW1pdHMgaGVyZToKKiBxdW90YS1tYXh3YXRjaGV2ZW50cyBvbiB3 YXRjaCBldmVudCBkZXN0aW5hdGlvbjogd2hlbiB0aGlzIGlzIGhpdCB0aGUK ICBzb3VyY2Ugd2lsbCBub3QgYmUgYWxsb3dlZCB0byBxdWV1ZSB1cCBtb3Jl IHdhdGNoIGV2ZW50cy4KKiBxdW90YS1tYXhvdXN0YW5kaW5nIHdoaWNoIGlz IHRoZSBudW1iZXIgb2YgcmVzcG9uc2VzIG5vdCByZWFkIGZyb20gdGhlIHJp bmc6CiAgb25jZSBleGNlZWRlZCwgbm8gbW9yZSBpbnB1dHMgYXJlIHByb2Nl c3NlZCB1bnRpbCBhbGwgb3V0c3RhbmRpbmcgcmVwbGllcwogIGFyZSBjb25z dW1lZCBieSB0aGUgY2xpZW50LgoqIG92ZXJmbG93IHF1ZXVlIG9uIHRoZSB3 YXRjaCBldmVudCBzb3VyY2U6IGFsbCB3YXRjaGVzIHRoYXQgY2Fubm90IGJl IHN0b3JlZAogIG9uIGRlc3RpbmF0aW9uIGFyZSBxdWV1ZWQgdXAgaGVyZSwg YSBzaW5nbGUgY29tbWFuZCBjYW4gdHJpZ2dlciBtdWx0aXBsZQogIHdhdGNo ZXMgKGUuZy4gZHVlIHRvIHJlY3Vyc2lvbikuCgpUaGUgb3ZlcmZsb3cgcXVl dWUgY3VycmVudGx5IGRvZXNuJ3QgaGF2ZSBhbiB1cHBlciBib3VuZCwgaXQg aXMgZGlmZmljdWx0IHRvCmFjY3VyYXRlbHkgY2FsY3VsYXRlIG9uZSBhcyBp dCBkZXBlbmRzIG9uIHdoZXRoZXIgeW91IGFyZSBEb20wIGFuZCBob3cgbWFu eQp3YXRjaGVzIGVhY2ggcGF0aCBoYXMgcmVnaXN0ZXJlZCBhbmQgaG93IG1h bnkgd2F0Y2ggZXZlbnRzIHlvdSBjYW4gdHJpZ2dlcgp3aXRoIGEgc2luZ2xl IGNvbW1hbmQgKGUuZy4gYSBjb21taXQpLiAgSG93ZXZlciB0aGVzZSBldmVu dHMgd2VyZSBhbHJlYWR5CnVzaW5nIG1lbW9yeSwgdGhpcyBqdXN0IG1vdmVz IHRoZW0gZWxzZXdoZXJlLCBhbmQgYXMgbG9uZyBhcyB3ZSBjb3JyZWN0bHkK YmxvY2sgYSBkb21haW4gaXQgc2hvdWxkbid0IHJlc3VsdCBpbiB1bmJvdW5k ZWQgbWVtb3J5IHVzYWdlLgoKTm90ZSB0aGF0IERvbTAgaXMgbm90IGV4Y2x1 ZGVkIGZyb20gdGhlc2UgY2hlY2tzLCBpdCBpcyBpbXBvcnRhbnQgdGhhdCBE b20wIGlzCmVzcGVjaWFsbHkgbm90IGV4Y2x1ZGVkIHdoZW4gaXQgaXMgdGhl IHNvdXJjZSwgc2luY2UgdGhlcmUgYXJlIG1hbnkgd2F5cyBpbgp3aGljaCBh IGd1ZXN0IGNvdWxkIHRyaWdnZXIgRG9tMCB0byBzZW5kIGl0IHdhdGNoIGV2 ZW50cy4KClRoaXMgc2hvdWxkIHByb3RlY3QgYWdhaW5zdCBtYWxpY2lvdXMg ZnJvbnRlbmRzIGFzIGxvbmcgYXMgdGhlIGJhY2tlbmQgZm9sbG93cwp0aGUg UFYgeGVuc3RvcmUgcHJvdG9jb2wgYW5kIG9ubHkgZXhwb3NlcyBwYXRocyBu ZWVkZWQgYnkgdGhlIGZyb250ZW5kLCBhbmQKY2hhbmdlcyB0aG9zZSBwYXRo cyBhdCBtb3N0IG9uY2UgYXMgYSByZWFjdGlvbiB0byBndWVzdCBldmVudHMs IG9yIHByb3RvY29sCnN0YXRlLgoKVGhlIHF1ZXVlIGxpbWl0cyBhcmUgcGVy IHdhdGNoLCBhbmQgcGVyIGRvbWFpbi1wYWlyLCBzbyBldmVuIGlmIG9uZQpj b21tdW5pY2F0aW9uIGNoYW5uZWwgd291bGQgYmUgImJsb2NrZWQiLCBvdGhl cnMgd291bGQga2VlcCB3b3JraW5nLCBhbmQgdGhlCmRvbWFpbiBpdHNlbGYg d29uJ3QgZ2V0IGJsb2NrZWQgYXMgbG9uZyBhcyBpdCBkb2Vzbid0IG92ZXJm bG93IHRoZSBxdWV1ZSBvZgp3YXRjaCBldmVudHMuCgpTaW1pbGFybHkgYSBt YWxpY2lvdXMgYmFja2VuZCBjb3VsZCBjYXVzZSB0aGUgZnJvbnRlbmQgdG8g Z2V0IGJsb2NrZWQsIGJ1dAp0aGlzIHdhdGNoIHF1ZXVlIHByb3RlY3RzIHRo ZSBmcm9udGVuZCBhcyB3ZWxsIGFzIGxvbmcgYXMgaXQgZm9sbG93cyB0aGUg UFYKcHJvdG9jb2wuICAoQWx0aG91Z2ggbm90ZSB0aGF0IHByb3RlY3Rpb24g YWdhaW5zdCBtYWxpY2lvdXMgYmFja2VuZHMgaXMgb25seSBhCmJlc3QgZWZm b3J0IGF0IHRoZSBtb21lbnQpCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNiAv IENWRS0yMDIyLTQyMzE4LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLD tmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJpc3Rp YW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbCBiL3Rvb2xzL29j YW1sL2xpYnMveGIveGIubWwKaW5kZXggNDE5N2EzODg4YTY4Li5iMjkyZWQ3 YTg3NGQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWwK KysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbApAQCAtMTM0LDE0ICsx MzQsNDQgQEAgdHlwZSBiYWNrZW5kID0gRmQgb2YgYmFja2VuZF9mZCB8IFhl bm1tYXAgb2YgYmFja2VuZF9tbWFwCiAKIHR5cGUgcGFydGlhbF9idWYgPSBI YXZlSGRyIG9mIFBhcnRpYWwucGt0IHwgTm9IZHIgb2YgaW50ICogYnl0ZXMK IAorKCoKKwlzZXBhcmF0ZSBjYXBhY2l0eSByZXNlcnZhdGlvbiBmb3IgcmVw bGllcyBhbmQgd2F0Y2ggZXZlbnRzOgorCXRoaXMgYWxsb3dzIGEgZG9tYWlu IHRvIGtlZXAgd29ya2luZyBldmVuIHdoZW4gdW5kZXIgYSBjb25zdGFudCBm bG9vZCBvZgorCXdhdGNoIGV2ZW50cworKikKK3R5cGUgY2FwYWNpdHkgPSB7 IG1heG91dHN0YW5kaW5nOiBpbnQ7IG1heHdhdGNoZXZlbnRzOiBpbnQgfQor Cittb2R1bGUgUXVldWUgPSBCb3VuZGVkUXVldWUKKwordHlwZSBwYWNrZXRf Y2xhc3MgPQorCXwgQ29tbWFuZFJlcGx5CisJfCBXYXRjaGV2ZW50CisKK2xl dCBzdHJpbmdfb2ZfcGFja2V0X2NsYXNzID0gZnVuY3Rpb24KKwl8IENvbW1h bmRSZXBseSAtPiAiY29tbWFuZF9yZXBseSIKKwl8IFdhdGNoZXZlbnQgLT4g IndhdGNoX2V2ZW50IgorCiB0eXBlIHQgPQogewogCWJhY2tlbmQ6IGJhY2tl bmQ7Ci0JcGt0X291dDogUGFja2V0LnQgUXVldWUudDsKKwlwa3Rfb3V0OiAo UGFja2V0LnQsIHBhY2tldF9jbGFzcykgUXVldWUudDsKIAltdXRhYmxlIHBh cnRpYWxfaW46IHBhcnRpYWxfYnVmOwogCW11dGFibGUgcGFydGlhbF9vdXQ6 IHN0cmluZzsKKwljYXBhY2l0eTogY2FwYWNpdHkKIH0KIAorbGV0IHRvX3Jl YWQgY29uID0KKwltYXRjaCBjb24ucGFydGlhbF9pbiB3aXRoCisJCXwgSGF2 ZUhkciBwYXJ0aWFsX3BrdCAtPiBQYXJ0aWFsLnRvX2NvbXBsZXRlIHBhcnRp YWxfcGt0CisJCXwgTm9IZHIgICAoaSwgXykgICAgLT4gaQorCitsZXQgZGVi dWcgdCA9CisJUHJpbnRmLnNwcmludGYgIlhlbkJ1cyBzdGF0ZTogcGFydGlh bF9pbjogJWQgbmVlZGVkLCBwYXJ0aWFsX291dDogJWQgYnl0ZXMsIHBrdF9v dXQ6ICVkIHBhY2tldHMsICVzIgorCQkodG9fcmVhZCB0KQorCQkoU3RyaW5n Lmxlbmd0aCB0LnBhcnRpYWxfb3V0KQorCQkoUXVldWUubGVuZ3RoIHQucGt0 X291dCkKKwkJKEJvdW5kZWRRdWV1ZS5kZWJ1ZyBzdHJpbmdfb2ZfcGFja2V0 X2NsYXNzIHQucGt0X291dCkKKwogbGV0IGluaXRfcGFydGlhbF9pbiAoKSA9 IE5vSGRyCiAJKFBhcnRpYWwuaGVhZGVyX3NpemUgKCksIEJ5dGVzLm1ha2Ug KFBhcnRpYWwuaGVhZGVyX3NpemUoKSkgJ1wwMDAnKQogCkBAIC0xOTksNyAr MjI5LDggQEAgbGV0IG91dHB1dCBjb24gPQogCWxldCBzID0gaWYgU3RyaW5n Lmxlbmd0aCBjb24ucGFydGlhbF9vdXQgPiAwIHRoZW4KIAkJCWNvbi5wYXJ0 aWFsX291dAogCQllbHNlIGlmIFF1ZXVlLmxlbmd0aCBjb24ucGt0X291dCA+ IDAgdGhlbgotCQkJUGFja2V0LnRvX3N0cmluZyAoUXVldWUucG9wIGNvbi5w a3Rfb3V0KQorCQkJbGV0IHBrdCA9IFF1ZXVlLnBvcCBjb24ucGt0X291dCBp bgorCQkJUGFja2V0LnRvX3N0cmluZyBwa3QKIAkJZWxzZQogCQkJIiIgaW4K IAkoKiBzZW5kIGRhdGEgZnJvbSBzLCBhbmQgc2F2ZSB0aGUgdW5zZW50IGRh dGEgdG8gcGFydGlhbF9vdXQgKikKQEAgLTIxMiwxMiArMjQzLDE1IEBAIGxl dCBvdXRwdXQgY29uID0KIAkoKiBhZnRlciBzZW5kaW5nIG9uZSBwYWNrZXQs IHBhcnRpYWwgaXMgZW1wdHkgKikKIAljb24ucGFydGlhbF9vdXQgPSAiIgog CisoKiB3ZSBjYW4gb25seSBwcm9jZXNzIGFuIGlucHV0IHBhY2tldCBpZiB3 ZSdyZSBndWFyYW50ZWVkIHRvIGhhdmUgcm9vbQorICAgdG8gc3RvcmUgdGhl IHJlc3BvbnNlIHBhY2tldCAqKQorbGV0IGNhbl9pbnB1dCBjb24gPSBRdWV1 ZS5jYW5fcHVzaCBjb24ucGt0X291dCBDb21tYW5kUmVwbHkKKwogKCogTkI6 IGNhbiB0aHJvdyBSZWNvbm5lY3QgKikKIGxldCBpbnB1dCBjb24gPQotCWxl dCB0b19yZWFkID0KLQkJbWF0Y2ggY29uLnBhcnRpYWxfaW4gd2l0aAotCQl8 IEhhdmVIZHIgcGFydGlhbF9wa3QgLT4gUGFydGlhbC50b19jb21wbGV0ZSBw YXJ0aWFsX3BrdAotCQl8IE5vSGRyICAgKGksIF8pICAgIC0+IGkgaW4KKwlp ZiBub3QgKGNhbl9pbnB1dCBjb24pIHRoZW4gTm9uZQorCWVsc2UKKwlsZXQg dG9fcmVhZCA9IHRvX3JlYWQgY29uIGluCiAKIAkoKiB0cnkgdG8gZ2V0IG1v cmUgZGF0YSBmcm9tIGlucHV0IHN0cmVhbSAqKQogCWxldCBiID0gQnl0ZXMu bWFrZSB0b19yZWFkICdcMDAwJyBpbgpAQCAtMjQzLDExICsyNzcsMjIgQEAg bGV0IGlucHV0IGNvbiA9CiAJCU5vbmUKIAkpCiAKLWxldCBuZXdjb24gYmFj a2VuZCA9IHsKK2xldCBjbGFzc2lmeSB0ID0KKwltYXRjaCB0LlBhY2tldC50 eSB3aXRoCisJfCBPcC5XYXRjaGV2ZW50IC0+IFdhdGNoZXZlbnQKKwl8IF8g LT4gQ29tbWFuZFJlcGx5CisKK2xldCBuZXdjb24gfmNhcGFjaXR5IGJhY2tl bmQgPQorCWxldCBsaW1pdCA9IGZ1bmN0aW9uCisJCXwgQ29tbWFuZFJlcGx5 IC0+IGNhcGFjaXR5Lm1heG91dHN0YW5kaW5nCisJCXwgV2F0Y2hldmVudCAt PiBjYXBhY2l0eS5tYXh3YXRjaGV2ZW50cworCWluCisJewogCWJhY2tlbmQg PSBiYWNrZW5kOwotCXBrdF9vdXQgPSBRdWV1ZS5jcmVhdGUgKCk7CisJcGt0 X291dCA9IFF1ZXVlLmNyZWF0ZSB+Y2FwYWNpdHk6KGNhcGFjaXR5Lm1heG91 dHN0YW5kaW5nICsgY2FwYWNpdHkubWF4d2F0Y2hldmVudHMpIH5jbGFzc2lm eSB+bGltaXQ7CiAJcGFydGlhbF9pbiA9IGluaXRfcGFydGlhbF9pbiAoKTsK IAlwYXJ0aWFsX291dCA9ICIiOworCWNhcGFjaXR5ID0gY2FwYWNpdHk7CiAJ fQogCiBsZXQgb3Blbl9mZCBmZCA9IG5ld2NvbiAoRmQgeyBmZCA9IGZkOyB9 KQpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbGkgYi90 b29scy9vY2FtbC9saWJzL3hiL3hiLm1saQppbmRleCA5MWM2ODIxNjJjZWEu LjcxYjI3NTRjYTc4OCAxMDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94 Yi94Yi5tbGkKKysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbGkKQEAg LTY2LDEwICs2NiwxMSBAQCB0eXBlIGJhY2tlbmRfbW1hcCA9IHsKIHR5cGUg YmFja2VuZF9mZCA9IHsgZmQgOiBVbml4LmZpbGVfZGVzY3I7IH0KIHR5cGUg YmFja2VuZCA9IEZkIG9mIGJhY2tlbmRfZmQgfCBYZW5tbWFwIG9mIGJhY2tl bmRfbW1hcAogdHlwZSBwYXJ0aWFsX2J1ZiA9IEhhdmVIZHIgb2YgUGFydGlh bC5wa3QgfCBOb0hkciBvZiBpbnQgKiBieXRlcwordHlwZSBjYXBhY2l0eSA9 IHsgbWF4b3V0c3RhbmRpbmc6IGludDsgbWF4d2F0Y2hldmVudHM6IGludCB9 CiB0eXBlIHQKIHZhbCBpbml0X3BhcnRpYWxfaW4gOiB1bml0IC0+IHBhcnRp YWxfYnVmCiB2YWwgcmVjb25uZWN0IDogdCAtPiB1bml0Ci12YWwgcXVldWUg OiB0IC0+IFBhY2tldC50IC0+IHVuaXQKK3ZhbCBxdWV1ZSA6IHQgLT4gUGFj a2V0LnQgLT4gdW5pdCBvcHRpb24KIHZhbCByZWFkX2ZkIDogYmFja2VuZF9m ZCAtPiAnYSAtPiBieXRlcyAtPiBpbnQgLT4gaW50CiB2YWwgcmVhZF9tbWFw IDogYmFja2VuZF9tbWFwIC0+ICdhIC0+IGJ5dGVzIC0+IGludCAtPiBpbnQK IHZhbCByZWFkIDogdCAtPiBieXRlcyAtPiBpbnQgLT4gaW50CkBAIC03OCwx MyArNzksMTQgQEAgdmFsIHdyaXRlX21tYXAgOiBiYWNrZW5kX21tYXAgLT4g J2EgLT4gc3RyaW5nIC0+IGludCAtPiBpbnQKIHZhbCB3cml0ZSA6IHQgLT4g c3RyaW5nIC0+IGludCAtPiBpbnQKIHZhbCBvdXRwdXQgOiB0IC0+IGJvb2wK IHZhbCBpbnB1dCA6IHQgLT4gUGFja2V0LnQgb3B0aW9uCi12YWwgbmV3Y29u IDogYmFja2VuZCAtPiB0Ci12YWwgb3Blbl9mZCA6IFVuaXguZmlsZV9kZXNj ciAtPiB0Ci12YWwgb3Blbl9tbWFwIDogWGVubW1hcC5tbWFwX2ludGVyZmFj ZSAtPiAodW5pdCAtPiB1bml0KSAtPiB0Cit2YWwgbmV3Y29uIDogY2FwYWNp dHk6Y2FwYWNpdHkgLT4gYmFja2VuZCAtPiB0Cit2YWwgb3Blbl9mZCA6IFVu aXguZmlsZV9kZXNjciAtPiBjYXBhY2l0eTpjYXBhY2l0eSAtPiB0Cit2YWwg b3Blbl9tbWFwIDogWGVubW1hcC5tbWFwX2ludGVyZmFjZSAtPiAodW5pdCAt PiB1bml0KSAtPiBjYXBhY2l0eTpjYXBhY2l0eSAtPiB0CiB2YWwgY2xvc2Ug OiB0IC0+IHVuaXQKIHZhbCBpc19mZCA6IHQgLT4gYm9vbAogdmFsIGlzX21t YXAgOiB0IC0+IGJvb2wKIHZhbCBvdXRwdXRfbGVuIDogdCAtPiBpbnQKK3Zh bCBjYW5faW5wdXQ6IHQgLT4gYm9vbAogdmFsIGhhc19uZXdfb3V0cHV0IDog dCAtPiBib29sCiB2YWwgaGFzX29sZF9vdXRwdXQgOiB0IC0+IGJvb2wKIHZh bCBoYXNfb3V0cHV0IDogdCAtPiBib29sCkBAIC05MywzICs5NSw0IEBAIHZh bCBoYXNfcGFydGlhbF9pbnB1dCA6IHQgLT4gYm9vbAogdmFsIGhhc19tb3Jl X2lucHV0IDogdCAtPiBib29sCiB2YWwgaXNfc2VsZWN0YWJsZSA6IHQgLT4g Ym9vbAogdmFsIGdldF9mZCA6IHQgLT4gVW5peC5maWxlX2Rlc2NyCit2YWwg ZGVidWc6IHQgLT4gc3RyaW5nCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9s aWJzL3hzL3F1ZXVlb3AubWwgYi90b29scy9vY2FtbC9saWJzL3hzL3F1ZXVl b3AubWwKaW5kZXggOWZmNWJiZDUyOWNlLi40ZTUzMmNkYWVhY2IgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveHMvcXVldWVvcC5tbAorKysgYi90 b29scy9vY2FtbC9saWJzL3hzL3F1ZXVlb3AubWwKQEAgLTE2LDkgKzE2LDEw IEBACiBvcGVuIFhlbmJ1cwogCiBsZXQgZGF0YV9jb25jYXQgbHMgPSAoU3Ry aW5nLmNvbmNhdCAiXDAwMCIgbHMpIF4gIlwwMDAiCitsZXQgcXVldWUgY29u IHBrdCA9IGxldCByID0gWGIucXVldWUgY29uIHBrdCBpbiBhc3NlcnQgKHIg PD4gTm9uZSkKIGxldCBxdWV1ZV9wYXRoIHR5ICh0aWQ6IGludCkgKHBhdGg6 IHN0cmluZykgY29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgcGF0 aDsgXSBpbgotCVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSB0aWQg MCB0eSBkYXRhKQorCXF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSB0aWQg MCB0eSBkYXRhKQogCiAoKiBvcGVyYXRpb25zICopCiBsZXQgZGlyZWN0b3J5 IHRpZCBwYXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuRGlyZWN0b3J5IHRp ZCBwYXRoIGNvbgpAQCAtMjcsNDggKzI4LDQ4IEBAIGxldCByZWFkIHRpZCBw YXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuUmVhZCB0aWQgcGF0aCBjb24K IGxldCBnZXRwZXJtcyB0aWQgcGF0aCBjb24gPSBxdWV1ZV9wYXRoIFhiLk9w LkdldHBlcm1zIHRpZCBwYXRoIGNvbgogCiBsZXQgZGVidWcgY29tbWFuZHMg Y29uID0KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhi Lk9wLkRlYnVnIChkYXRhX2NvbmNhdCBjb21tYW5kcykpCisJcXVldWUgY29u IChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5EZWJ1ZyAoZGF0YV9jb25j YXQgY29tbWFuZHMpKQogCiBsZXQgd2F0Y2ggcGF0aCBkYXRhIGNvbiA9CiAJ bGV0IGRhdGEgPSBkYXRhX2NvbmNhdCBbIHBhdGg7IGRhdGE7IF0gaW4KLQlY Yi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhiLk9wLldhdGNo IGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5P cC5XYXRjaCBkYXRhKQogCiBsZXQgdW53YXRjaCBwYXRoIGRhdGEgY29uID0K IAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgcGF0aDsgZGF0YTsgXSBpbgot CVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuVW53 YXRjaCBkYXRhKQorCXF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAg WGIuT3AuVW53YXRjaCBkYXRhKQogCiBsZXQgdHJhbnNhY3Rpb25fc3RhcnQg Y29uID0KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhi Lk9wLlRyYW5zYWN0aW9uX3N0YXJ0IChkYXRhX2NvbmNhdCBbXSkpCisJcXVl dWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5UcmFuc2FjdGlv bl9zdGFydCAoZGF0YV9jb25jYXQgW10pKQogCiBsZXQgdHJhbnNhY3Rpb25f ZW5kIHRpZCBjb21taXQgY29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0 IFsgKGlmIGNvbW1pdCB0aGVuICJUIiBlbHNlICJGIik7IF0gaW4KLQlYYi5x dWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuVHJhbnNh Y3Rpb25fZW5kIGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRl IHRpZCAwIFhiLk9wLlRyYW5zYWN0aW9uX2VuZCBkYXRhKQogCiBsZXQgaW50 cm9kdWNlIGRvbWlkIG1mbiBwb3J0IGNvbiA9CiAJbGV0IGRhdGEgPSBkYXRh X2NvbmNhdCBbIFByaW50Zi5zcHJpbnRmICIldSIgZG9taWQ7CiAJICAgICAg ICAgICAgICAgICAgICAgICAgIFByaW50Zi5zcHJpbnRmICIlbnUiIG1mbjsK IAkgICAgICAgICAgICAgICAgICAgICAgICAgc3RyaW5nX29mX2ludCBwb3J0 OyBdIGluCi0JWGIucXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBY Yi5PcC5JbnRyb2R1Y2UgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBhY2tldC5j cmVhdGUgMCAwIFhiLk9wLkludHJvZHVjZSBkYXRhKQogCiBsZXQgcmVsZWFz ZSBkb21pZCBjb24gPQogCWxldCBkYXRhID0gZGF0YV9jb25jYXQgWyBQcmlu dGYuc3ByaW50ZiAiJXUiIGRvbWlkOyBdIGluCi0JWGIucXVldWUgY29uIChY Yi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5SZWxlYXNlIGRhdGEpCisJcXVl dWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5SZWxlYXNlIGRh dGEpCiAKIGxldCByZXN1bWUgZG9taWQgY29uID0KIAlsZXQgZGF0YSA9IGRh dGFfY29uY2F0IFsgUHJpbnRmLnNwcmludGYgIiV1IiBkb21pZDsgXSBpbgot CVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuUmVz dW1lIGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBY Yi5PcC5SZXN1bWUgZGF0YSkKIAogbGV0IGdldGRvbWFpbnBhdGggZG9taWQg Y29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgUHJpbnRmLnNwcmlu dGYgIiV1IiBkb21pZDsgXSBpbgotCVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0 LmNyZWF0ZSAwIDAgWGIuT3AuR2V0ZG9tYWlucGF0aCBkYXRhKQorCXF1ZXVl IGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuR2V0ZG9tYWlucGF0 aCBkYXRhKQogCiBsZXQgd3JpdGUgdGlkIHBhdGggdmFsdWUgY29uID0KIAls ZXQgZGF0YSA9IHBhdGggXiAiXDAwMCIgXiB2YWx1ZSAoKiBubyBOVUxMIGF0 IHRoZSBlbmQgKikgaW4KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVh dGUgdGlkIDAgWGIuT3AuV3JpdGUgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBh Y2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuV3JpdGUgZGF0YSkKIAogbGV0IG1r ZGlyIHRpZCBwYXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuTWtkaXIgdGlk IHBhdGggY29uCiBsZXQgcm0gdGlkIHBhdGggY29uID0gcXVldWVfcGF0aCBY Yi5PcC5SbSB0aWQgcGF0aCBjb24KIAogbGV0IHNldHBlcm1zIHRpZCBwYXRo IHBlcm1zIGNvbiA9CiAJbGV0IGRhdGEgPSBkYXRhX2NvbmNhdCBbIHBhdGg7 IHBlcm1zIF0gaW4KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUg dGlkIDAgWGIuT3AuU2V0cGVybXMgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBh Y2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuU2V0cGVybXMgZGF0YSkKZGlmZiAt LWdpdCBhL3Rvb2xzL29jYW1sL2xpYnMveHMveHNyYXcubWwgYi90b29scy9v Y2FtbC9saWJzL3hzL3hzcmF3Lm1sCmluZGV4IDQ1MWY4YjM4ZGJjYy4uY2Jk MTcyODA2MDBjIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9saWJzL3hzL3hz cmF3Lm1sCisrKyBiL3Rvb2xzL29jYW1sL2xpYnMveHMveHNyYXcubWwKQEAg LTM2LDggKzM2LDEwIEBAIHR5cGUgY29uID0gewogbGV0IGNsb3NlIGNvbiA9 CiAJWGIuY2xvc2UgY29uLnhiCiAKK2xldCBjYXBhY2l0eSA9IHsgWGIubWF4 b3V0c3RhbmRpbmcgPSAxOyBtYXh3YXRjaGV2ZW50cyA9IDA7IH0KKwogbGV0 IG9wZW5fZmQgZmQgPSB7Ci0JeGIgPSBYYi5vcGVuX2ZkIGZkOworCXhiID0g WGIub3Blbl9mZCB+Y2FwYWNpdHkgZmQ7CiAJd2F0Y2hldmVudHMgPSBRdWV1 ZS5jcmVhdGUgKCk7CiB9CiAKZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hl bnN0b3JlZC9jb25uZWN0aW9uLm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVk L2Nvbm5lY3Rpb24ubWwKaW5kZXggY2MyMGUwNDdkMmI5Li45NjI0YTVmOWRh MmMgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0 aW9uLm1sCisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9u Lm1sCkBAIC0yMCwxMiArMjAsODQgQEAgb3BlbiBTdGRleHQKIAogbGV0IHhl bnN0b3JlX3BheWxvYWRfbWF4ID0gNDA5NiAoKiB4ZW4vaW5jbHVkZS9wdWJs aWMvaW8veHNfd2lyZS5oICopCiAKK3R5cGUgJ2EgYm91bmRlZF9zZW5kZXIg PSAnYSAtPiB1bml0IG9wdGlvbgorKCoqIGEgYm91bmRlZCBzZW5kZXIgYWNj ZXB0cyBhbiBbJ2FdIGl0ZW0gYW5kIHJldHVybnM6CisgICAgTm9uZSAtIGlm IHRoZXJlIGlzIG5vIHJvb20gdG8gYWNjZXB0IHRoZSBpdGVtCisgICAgU29t ZSAoKSAtICBpZiBpdCBoYXMgc3VjY2Vzc2Z1bGx5IGFjY2VwdGVkL3NlbnQg dGhlIGl0ZW0KKyAqKQorCittb2R1bGUgQm91bmRlZFBpcGUgOiBzaWcKKwl0 eXBlICdhIHQKKworCSgqKiBbY3JlYXRlIH5jYXBhY2l0eSB+ZGVzdGluYXRp b25dIGNyZWF0ZXMgYSBib3VuZGVkIHBpcGUgd2l0aCBhCisJICAgIGxvY2Fs IGJ1ZmZlciBob2xkaW5nIGF0IG1vc3QgW2NhcGFjaXR5XSBpdGVtcy4gIE9u Y2UgdGhlIGJ1ZmZlciBpcworCSAgICBmdWxsIGl0IHdpbGwgbm90IGFjY2Vw dCBmdXJ0aGVyIGl0ZW1zLiAgaXRlbXMgZnJvbSB0aGUgcGlwZSBhcmUKKwkg ICAgZmx1c2hlZCBpbnRvIFtkZXN0aW5hdGlvbl0gYXMgbG9uZyBhcyBpdCBh Y2NlcHRzIGl0ZW1zLiAgVGhlCisJICAgIGRlc3RpbmF0aW9uIGNvdWxkIGJl IGFub3RoZXIgcGlwZS4KKwkgKikKKwl2YWwgY3JlYXRlOiBjYXBhY2l0eTpp bnQgLT4gZGVzdGluYXRpb246J2EgYm91bmRlZF9zZW5kZXIgLT4gJ2EgdAor CisJKCoqIFtpc19lbXB0eSB0XSByZXR1cm5zIHdoZXRoZXIgdGhlIGxvY2Fs IGJ1ZmZlciBvZiBbdF0gaXMgZW1wdHkuICopCisJdmFsIGlzX2VtcHR5IDog XyB0IC0+IGJvb2wKKworCSgqKiBbbGVuZ3RoIHRdIHRoZSBudW1iZXIgb2Yg aXRlbXMgaW4gdGhlIGludGVybmFsIGJ1ZmZlciAqKQorCXZhbCBsZW5ndGg6 IF8gdCAtPiBpbnQKKworCSgqKiBbZmx1c2hfcGlwZSB0XSBzZW5kcyBhcyBt YW55IGl0ZW1zIGZyb20gdGhlIGxvY2FsIGJ1ZmZlciBhcyBwb3NzaWJsZSwK KwkJCXdoaWNoIGNvdWxkIGJlIG5vbmUuICopCisJdmFsIGZsdXNoX3BpcGU6 IF8gdCAtPiB1bml0CisKKwkoKiogW3B1c2ggdCBpdGVtXSB0cmllcyB0byBb Zmx1c2hfcGlwZV0gYW5kIHRoZW4gcHVzaCBbaXRlbV0KKwkgICAgaW50byB0 aGUgcGlwZSBpZiBpdHMgW2NhcGFjaXR5XSBhbGxvd3MuCisJICAgIFJldHVy bnMgW05vbmVdIGlmIHRoZXJlIGlzIG5vIG1vcmUgcm9vbQorCSAqKQorCXZh bCBwdXNoIDogJ2EgdCAtPiAnYSBib3VuZGVkX3NlbmRlcgorZW5kID0gc3Ry dWN0CisJKCogaXRlbXMgYXJlIGVucXVldWVkIGluIFtxXSwgYW5kIHRoZW4g Zmx1c2hlZCB0byBbY29ubmVjdF90b10gKikKKwl0eXBlICdhIHQgPQorCQl7 IHE6ICdhIFF1ZXVlLnQKKwkJOyBkZXN0aW5hdGlvbjogJ2EgYm91bmRlZF9z ZW5kZXIKKwkJOyBjYXBhY2l0eTogaW50CisJCX0KKworCWxldCBjcmVhdGUg fmNhcGFjaXR5IH5kZXN0aW5hdGlvbiA9CisJCXsgcSA9IFF1ZXVlLmNyZWF0 ZSAoKTsgY2FwYWNpdHk7IGRlc3RpbmF0aW9uIH0KKworCWxldCByZWMgZmx1 c2hfcGlwZSB0ID0KKwkJaWYgbm90IFF1ZXVlLihpc19lbXB0eSB0LnEpIHRo ZW4KKwkJCWxldCBpdGVtID0gUXVldWUucGVlayB0LnEgaW4KKwkJCW1hdGNo IHQuZGVzdGluYXRpb24gaXRlbSB3aXRoCisJCQl8IE5vbmUgLT4gKCkgKCog bm8gcm9vbSAqKQorCQkJfCBTb21lICgpIC0+CisJCQkJKCogc3VjY2Vzc2Z1 bGx5IHNlbnQgaXRlbSB0byBuZXh0IHN0YWdlICopCisJCQkJbGV0IF8gPSBR dWV1ZS5wb3AgdC5xIGluCisJCQkJKCogY29udGludWUgdHJ5aW5nIHRvIHNl bmQgbW9yZSBpdGVtcyAqKQorCQkJCWZsdXNoX3BpcGUgdAorCisJbGV0IHB1 c2ggdCBpdGVtID0KKwkJKCogZmlyc3QgdHJ5IHRvIGZsdXNoIGFzIG1hbnkg aXRlbXMgZnJvbSB0aGlzIHBpcGUgYXMgcG9zc2libGUgdG8gbWFrZSByb29t LAorCQkgICBpdCBpcyBpbXBvcnRhbnQgdG8gZG8gdGhpcyBmaXJzdCB0byBw cmVzZXJ2ZSB0aGUgb3JkZXIgb2YgdGhlIGl0ZW1zCisJCSAqKQorCQlmbHVz aF9waXBlIHQ7CisJCWlmIFF1ZXVlLmxlbmd0aCB0LnEgPCB0LmNhcGFjaXR5 IHRoZW4gYmVnaW4KKwkJCSgqIGVucXVldWUsIGluc3RlYWQgb2Ygc2VuZGlu ZyBkaXJlY3RseS4KKwkJCSAgIHRoaXMgZW5zdXJlcyB0aGF0IFtvdXRdIHNl ZXMgdGhlIGl0ZW1zIGluIHRoZSBzYW1lIG9yZGVyIGFzIHdlIHJlY2VpdmUg dGhlbQorCQkJICopCisJCQlRdWV1ZS5wdXNoIGl0ZW0gdC5xOworCQkJU29t ZSAoZmx1c2hfcGlwZSB0KQorCQllbmQgZWxzZSBOb25lCisKKwlsZXQgaXNf ZW1wdHkgdCA9IFF1ZXVlLmlzX2VtcHR5IHQucQorCWxldCBsZW5ndGggdCA9 IFF1ZXVlLmxlbmd0aCB0LnEKK2VuZAorCiB0eXBlIHdhdGNoID0gewogCWNv bjogdDsKIAl0b2tlbjogc3RyaW5nOwogCXBhdGg6IHN0cmluZzsKIAliYXNl OiBzdHJpbmc7CiAJaXNfcmVsYXRpdmU6IGJvb2w7CisJcGVuZGluZ193YXRj aGV2ZW50czogWGVuYnVzLlhiLlBhY2tldC50IEJvdW5kZWRQaXBlLnQ7CiB9 CiAKIGFuZCB0ID0gewpAQCAtMzgsOCArMTEwLDM2IEBAIGFuZCB0ID0gewog CWFub25pZDogaW50OwogCW11dGFibGUgc3RhdF9uYl9vcHM6IGludDsKIAlt dXRhYmxlIHBlcm06IFBlcm1zLkNvbm5lY3Rpb24udDsKKwlwZW5kaW5nX3Nv dXJjZV93YXRjaGV2ZW50czogKHdhdGNoICogWGVuYnVzLlhiLlBhY2tldC50 KSBCb3VuZGVkUGlwZS50CiB9CiAKK21vZHVsZSBXYXRjaCA9IHN0cnVjdAor CW1vZHVsZSBUID0gc3RydWN0CisJCXR5cGUgdCA9IHdhdGNoCisKKwkJbGV0 IGNvbXBhcmUgdzEgdzIgPQorCQkJKCogY2Fubm90IGNvbXBhcmUgd2F0Y2hl cyBmcm9tIGRpZmZlcmVudCBjb25uZWN0aW9ucyAqKQorCQkJYXNzZXJ0ICh3 MS5jb24gPT0gdzIuY29uKTsKKwkJCW1hdGNoIFN0cmluZy5jb21wYXJlIHcx LnRva2VuIHcyLnRva2VuIHdpdGgKKwkJCXwgMCAtPiBTdHJpbmcuY29tcGFy ZSB3MS5wYXRoIHcyLnBhdGgKKwkJCXwgbiAtPiBuCisJZW5kCisJbW9kdWxl IFNldCA9IFNldC5NYWtlKFQpCisKKwlsZXQgZmx1c2hfZXZlbnRzIHQgPQor CQlCb3VuZGVkUGlwZS5mbHVzaF9waXBlIHQucGVuZGluZ193YXRjaGV2ZW50 czsKKwkJbm90IChCb3VuZGVkUGlwZS5pc19lbXB0eSB0LnBlbmRpbmdfd2F0 Y2hldmVudHMpCisKKwlsZXQgcGVuZGluZ193YXRjaGV2ZW50cyB0ID0KKwkJ Qm91bmRlZFBpcGUubGVuZ3RoIHQucGVuZGluZ193YXRjaGV2ZW50cworZW5k CisKK2xldCBzb3VyY2VfZmx1c2hfd2F0Y2hldmVudHMgdCA9CisJQm91bmRl ZFBpcGUuZmx1c2hfcGlwZSB0LnBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRz CisKK2xldCBzb3VyY2VfcGVuZGluZ193YXRjaGV2ZW50cyB0ID0KKwlCb3Vu ZGVkUGlwZS5sZW5ndGggdC5wZW5kaW5nX3NvdXJjZV93YXRjaGV2ZW50cwor CiBsZXQgbWFya19hc19iYWQgY29uID0KIAltYXRjaCBjb24uZG9tIHdpdGgK IAl8Tm9uZSAtPiAoKQpAQCAtNjcsNyArMTY3LDggQEAgbGV0IHdhdGNoX2Ny ZWF0ZSB+Y29uIH5wYXRoIH50b2tlbiA9IHsKIAl0b2tlbiA9IHRva2VuOwog CXBhdGggPSBwYXRoOwogCWJhc2UgPSBnZXRfcGF0aCBjb247Ci0JaXNfcmVs YXRpdmUgPSBwYXRoLlswXSA8PiAnLycgJiYgcGF0aC5bMF0gPD4gJ0AnCisJ aXNfcmVsYXRpdmUgPSBwYXRoLlswXSA8PiAnLycgJiYgcGF0aC5bMF0gPD4g J0AnOworCXBlbmRpbmdfd2F0Y2hldmVudHMgPSBCb3VuZGVkUGlwZS5jcmVh dGUgfmNhcGFjaXR5OiFEZWZpbmUubWF4d2F0Y2hldmVudHMgfmRlc3RpbmF0 aW9uOihYZW5idXMuWGIucXVldWUgY29uLnhiKQogfQogCiBsZXQgZ2V0X2Nv biB3ID0gdy5jb24KQEAgLTkzLDYgKzE5NCw5IEBAIGxldCBtYWtlX3Blcm0g ZG9tID0KIAlQZXJtcy5Db25uZWN0aW9uLmNyZWF0ZSB+cGVybXM6W1Blcm1z LlJFQUQ7IFBlcm1zLldSSVRFXSBkb21pZAogCiBsZXQgY3JlYXRlIHhiY29u IGRvbSA9CisJbGV0IGRlc3RpbmF0aW9uICh3YXRjaCwgcGt0KSA9CisJCUJv dW5kZWRQaXBlLnB1c2ggd2F0Y2gucGVuZGluZ193YXRjaGV2ZW50cyBwa3QK KwlpbgogCWxldCBpZCA9CiAJCW1hdGNoIGRvbSB3aXRoCiAJCXwgTm9uZSAt PiBsZXQgb2xkID0gIWFub25faWRfbmV4dCBpbiBpbmNyIGFub25faWRfbmV4 dDsgb2xkCkBAIC0xMDksNiArMjEzLDE2IEBAIGxldCBjcmVhdGUgeGJjb24g ZG9tID0KIAlhbm9uaWQgPSBpZDsKIAlzdGF0X25iX29wcyA9IDA7CiAJcGVy bSA9IG1ha2VfcGVybSBkb207CisKKwkoKiB0aGUgYWN0dWFsIGNhcGFjaXR5 IHdpbGwgYmUgbG93ZXIsIHRoaXMgaXMgdXNlZCBhcyBhbiBvdmVyZmxvdwor CSAgIGJ1ZmZlcjogYW55dGhpbmcgdGhhdCBkb2Vzbid0IGZpdCBlbHNld2hl cmUgZ2V0cyBwdXQgaGVyZSwgb25seQorCSAgIGxpbWl0ZWQgYnkgdGhlIGFt b3VudCBvZiB3YXRjaGVzIHRoYXQgeW91IGNhbiBnZW5lcmF0ZSB3aXRoIGEK KwkgICBzaW5nbGUgeGVuc3RvcmUgY29tbWFuZCAod2hpY2ggaXMgZmluaXRl LCBhbHRob3VnaCBwb3NzaWJseSB2ZXJ5CisJICAgbGFyZ2UgaW4gdGhlb3J5 IGZvciBEb20wKS4gIE9uY2UgdGhlIHBpcGUgaGVyZSBoYXMgYW55IGNvbnRl bnRzIHRoZQorCSAgIGRvbWFpbiBpcyBibG9ja2VkIGZyb20gc2VuZGluZyBt b3JlIGNvbW1hbmRzIHVudGlsIGl0IGlzIGVtcHR5CisJICAgYWdhaW4gdGhv dWdoLgorCSAqKQorCXBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRzID0gQm91 bmRlZFBpcGUuY3JlYXRlIH5jYXBhY2l0eTpTeXMubWF4X2FycmF5X2xlbmd0 aCB+ZGVzdGluYXRpb24KIAl9CiAJaW4KIAlMb2dnaW5nLm5ld19jb25uZWN0 aW9uIH50aWQ6VHJhbnNhY3Rpb24ubm9uZSB+Y29uOihnZXRfZG9tc3RyIGNv bik7CkBAIC0xMjcsMTEgKzI0MSwxNyBAQCBsZXQgc2V0X3RhcmdldCBjb24g dGFyZ2V0X2RvbWlkID0KIAogbGV0IGlzX2JhY2tlbmRfbW1hcCBjb24gPSBY ZW5idXMuWGIuaXNfbW1hcCBjb24ueGIKIAotbGV0IHNlbmRfcmVwbHkgY29u IHRpZCByaWQgdHkgZGF0YSA9CitsZXQgcGFja2V0X29mIGNvbiB0aWQgcmlk IHR5IGRhdGEgPQogCWlmIChTdHJpbmcubGVuZ3RoIGRhdGEpID4geGVuc3Rv cmVfcGF5bG9hZF9tYXggJiYgKGlzX2JhY2tlbmRfbW1hcCBjb24pIHRoZW4K LQkJWGVuYnVzLlhiLnF1ZXVlIGNvbi54YiAoWGVuYnVzLlhiLlBhY2tldC5j cmVhdGUgdGlkIHJpZCBYZW5idXMuWGIuT3AuRXJyb3IgIkUyQklHXDAwMCIp CisJCVhlbmJ1cy5YYi5QYWNrZXQuY3JlYXRlIHRpZCByaWQgWGVuYnVzLlhi Lk9wLkVycm9yICJFMkJJR1wwMDAiCiAJZWxzZQotCQlYZW5idXMuWGIucXVl dWUgY29uLnhiIChYZW5idXMuWGIuUGFja2V0LmNyZWF0ZSB0aWQgcmlkIHR5 IGRhdGEpCisJCVhlbmJ1cy5YYi5QYWNrZXQuY3JlYXRlIHRpZCByaWQgdHkg ZGF0YQorCitsZXQgc2VuZF9yZXBseSBjb24gdGlkIHJpZCB0eSBkYXRhID0K KwlsZXQgcmVzdWx0ID0gWGVuYnVzLlhiLnF1ZXVlIGNvbi54YiAocGFja2V0 X29mIGNvbiB0aWQgcmlkIHR5IGRhdGEpIGluCisJKCogc2hvdWxkIG5ldmVy IGhhcHBlbjogd2Ugb25seSBwcm9jZXNzIGFuIGlucHV0IHBhY2tldCB3aGVu IHRoZXJlIGlzIHJvb20gZm9yIGFuIG91dHB1dCBwYWNrZXQgKikKKwkoKiBh bmQgdGhlIGxpbWl0IGZvciByZXBsaWVzIGlzIGRpZmZlcmVudCBmcm9tIHRo ZSBsaW1pdCBmb3Igd2F0Y2ggZXZlbnRzICopCisJYXNzZXJ0IChyZXN1bHQg PD4gTm9uZSkKIAogbGV0IHNlbmRfZXJyb3IgY29uIHRpZCByaWQgZXJyID0g c2VuZF9yZXBseSBjb24gdGlkIHJpZCBYZW5idXMuWGIuT3AuRXJyb3IgKGVy ciBeICJcMDAwIikKIGxldCBzZW5kX2FjayBjb24gdGlkIHJpZCB0eSA9IHNl bmRfcmVwbHkgY29uIHRpZCByaWQgdHkgIk9LXDAwMCIKQEAgLTE4MSwxMSAr MzAxLDExIEBAIGxldCBkZWxfd2F0Y2ggY29uIHBhdGggdG9rZW4gPQogCWFw YXRoLCB3CiAKIGxldCBkZWxfd2F0Y2hlcyBjb24gPQotICBIYXNodGJsLmNs ZWFyIGNvbi53YXRjaGVzOworICBIYXNodGJsLnJlc2V0IGNvbi53YXRjaGVz OwogICBjb24ubmJfd2F0Y2hlcyA8LSAwCiAKIGxldCBkZWxfdHJhbnNhY3Rp b25zIGNvbiA9Ci0gIEhhc2h0YmwuY2xlYXIgY29uLnRyYW5zYWN0aW9ucwor ICBIYXNodGJsLnJlc2V0IGNvbi50cmFuc2FjdGlvbnMKIAogbGV0IGxpc3Rf d2F0Y2hlcyBjb24gPQogCWxldCBsbCA9IEhhc2h0YmwuZm9sZApAQCAtMjA4 LDIxICszMjgsMjkgQEAgbGV0IGxvb2t1cF93YXRjaF9wZXJtIHBhdGggPSBm dW5jdGlvbgogbGV0IGxvb2t1cF93YXRjaF9wZXJtcyBvbGRyb290IHJvb3Qg cGF0aCA9CiAJbG9va3VwX3dhdGNoX3Blcm0gcGF0aCBvbGRyb290IEAgbG9v a3VwX3dhdGNoX3Blcm0gcGF0aCAoU29tZSByb290KQogCi1sZXQgZmlyZV9z aW5nbGVfd2F0Y2hfdW5jaGVja2VkIHdhdGNoID0KK2xldCBmaXJlX3Npbmds ZV93YXRjaF91bmNoZWNrZWQgc291cmNlIHdhdGNoID0KIAlsZXQgZGF0YSA9 IFV0aWxzLmpvaW5fYnlfbnVsbCBbd2F0Y2gucGF0aDsgd2F0Y2gudG9rZW47 ICIiXSBpbgotCXNlbmRfcmVwbHkgd2F0Y2guY29uIFRyYW5zYWN0aW9uLm5v bmUgMCBYZW5idXMuWGIuT3AuV2F0Y2hldmVudCBkYXRhCisJbGV0IHBrdCA9 IHBhY2tldF9vZiB3YXRjaC5jb24gVHJhbnNhY3Rpb24ubm9uZSAwIFhlbmJ1 cy5YYi5PcC5XYXRjaGV2ZW50IGRhdGEgaW4KKworCW1hdGNoIEJvdW5kZWRQ aXBlLnB1c2ggc291cmNlLnBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRzICh3 YXRjaCwgcGt0KSB3aXRoCisJfCBTb21lICgpIC0+ICgpICgqIHBhY2tldCBx dWV1ZWQgKikKKwl8IE5vbmUgLT4KKwkJCSgqIGEgd2VsbCBiZWhhdmVkIERv bTAgc2hvdWxkbid0IGJlIGFibGUgdG8gdHJpZ2dlciB0aGlzLAorCQkJICAg aWYgaXQgaGFwcGVucyBpdCBpcyBsaWtlbHkgYSBEb20wIGJ1ZyBjYXVzaW5n IHJ1bmF3YXkgbWVtb3J5IHVzYWdlCisJCQkgKikKKwkJCWZhaWx3aXRoICJ3 YXRjaCBldmVudCBvdmVyZmxvdywgY2Fubm90IGhhcHBlbiIKIAotbGV0IGZp cmVfc2luZ2xlX3dhdGNoIChvbGRyb290LCByb290KSB3YXRjaCA9CitsZXQg ZmlyZV9zaW5nbGVfd2F0Y2ggc291cmNlIChvbGRyb290LCByb290KSB3YXRj aCA9CiAJbGV0IGFic3BhdGggPSBnZXRfd2F0Y2hfcGF0aCB3YXRjaC5jb24g d2F0Y2gucGF0aCB8PiBTdG9yZS5QYXRoLm9mX3N0cmluZyBpbgogCWxldCBw ZXJtcyA9IGxvb2t1cF93YXRjaF9wZXJtcyBvbGRyb290IHJvb3QgYWJzcGF0 aCBpbgogCWlmIFBlcm1zLmNhbl9maXJlX3dhdGNoIHdhdGNoLmNvbi5wZXJt IHBlcm1zIHRoZW4KLQkJZmlyZV9zaW5nbGVfd2F0Y2hfdW5jaGVja2VkIHdh dGNoCisJCWZpcmVfc2luZ2xlX3dhdGNoX3VuY2hlY2tlZCBzb3VyY2Ugd2F0 Y2gKIAllbHNlCiAJCWxldCBwZXJtcyA9IHBlcm1zIHw+IExpc3QubWFwIChQ ZXJtcy5Ob2RlLnRvX3N0cmluZyB+c2VwOiIgIikgfD4gU3RyaW5nLmNvbmNh dCAiLCAiIGluCiAJCWxldCBjb24gPSBnZXRfZG9tc3RyIHdhdGNoLmNvbiBp bgogCQlMb2dnaW5nLndhdGNoX25vdF9maXJlZCB+Y29uIHBlcm1zIChTdG9y ZS5QYXRoLnRvX3N0cmluZyBhYnNwYXRoKQogCi1sZXQgZmlyZV93YXRjaCBy b290cyB3YXRjaCBwYXRoID0KK2xldCBmaXJlX3dhdGNoIHNvdXJjZSByb290 cyB3YXRjaCBwYXRoID0KIAlsZXQgbmV3X3BhdGggPQogCQlpZiB3YXRjaC5p c19yZWxhdGl2ZSAmJiBwYXRoLlswXSA9ICcvJwogCQl0aGVuIGJlZ2luCkBA IC0yMzIsNyArMzYwLDcgQEAgbGV0IGZpcmVfd2F0Y2ggcm9vdHMgd2F0Y2gg cGF0aCA9CiAJCWVuZCBlbHNlCiAJCQlwYXRoCiAJaW4KLQlmaXJlX3Npbmds ZV93YXRjaCByb290cyB7IHdhdGNoIHdpdGggcGF0aCA9IG5ld19wYXRoIH0K KwlmaXJlX3NpbmdsZV93YXRjaCBzb3VyY2Ugcm9vdHMgeyB3YXRjaCB3aXRo IHBhdGggPSBuZXdfcGF0aCB9CiAKICgqIFNlYXJjaCBmb3IgYSB2YWxpZCB1 bnVzZWQgdHJhbnNhY3Rpb24gaWQuICopCiBsZXQgcmVjIHZhbGlkX3RyYW5z YWN0aW9uX2lkIGNvbiBwcm9wb3NlZF9pZCA9CkBAIC0yODAsNiArNDA4LDcg QEAgbGV0IGRvX2lucHV0IGNvbiA9IFhlbmJ1cy5YYi5pbnB1dCBjb24ueGIK IGxldCBoYXNfcGFydGlhbF9pbnB1dCBjb24gPSBYZW5idXMuWGIuaGFzX3Bh cnRpYWxfaW5wdXQgY29uLnhiCiBsZXQgaGFzX21vcmVfaW5wdXQgY29uID0g WGVuYnVzLlhiLmhhc19tb3JlX2lucHV0IGNvbi54YgogCitsZXQgY2FuX2lu cHV0IGNvbiA9IFhlbmJ1cy5YYi5jYW5faW5wdXQgY29uLnhiICYmIEJvdW5k ZWRQaXBlLmlzX2VtcHR5IGNvbi5wZW5kaW5nX3NvdXJjZV93YXRjaGV2ZW50 cwogbGV0IGhhc19vdXRwdXQgY29uID0gWGVuYnVzLlhiLmhhc19vdXRwdXQg Y29uLnhiCiBsZXQgaGFzX29sZF9vdXRwdXQgY29uID0gWGVuYnVzLlhiLmhh c19vbGRfb3V0cHV0IGNvbi54YgogbGV0IGhhc19uZXdfb3V0cHV0IGNvbiA9 IFhlbmJ1cy5YYi5oYXNfbmV3X291dHB1dCBjb24ueGIKQEAgLTMyMyw3ICs0 NTIsNyBAQCBsZXQgcHJldmVudHNfbGl2ZV91cGRhdGUgY29uID0gbm90IChp c19iYWQgY29uKQogCSYmIChoYXNfZXh0cmFfY29ubmVjdGlvbl9kYXRhIGNv biB8fCBoYXNfdHJhbnNhY3Rpb25fZGF0YSBjb24pCiAKIGxldCBoYXNfbW9y ZV93b3JrIGNvbiA9Ci0JaGFzX21vcmVfaW5wdXQgY29uIHx8IG5vdCAoaGFz X29sZF9vdXRwdXQgY29uKSAmJiBoYXNfbmV3X291dHB1dCBjb24KKwkoaGFz X21vcmVfaW5wdXQgY29uICYmIGNhbl9pbnB1dCBjb24pIHx8IG5vdCAoaGFz X29sZF9vdXRwdXQgY29uKSAmJiBoYXNfbmV3X291dHB1dCBjb24KIAogbGV0 IGluY3Jfb3BzIGNvbiA9IGNvbi5zdGF0X25iX29wcyA8LSBjb24uc3RhdF9u Yl9vcHMgKyAxCiAKZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3Jl ZC9jb25uZWN0aW9ucy5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25u ZWN0aW9ucy5tbAppbmRleCAzYzc0MjlmZTdmNjEuLjdkNjhjNTgzYjQzYSAx MDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Nvbm5lY3Rpb25z Lm1sCisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9ucy5t bApAQCAtMjIsMjIgKzIyLDMwIEBAIHR5cGUgdCA9IHsKIAlkb21haW5zOiAo aW50LCBDb25uZWN0aW9uLnQpIEhhc2h0YmwudDsKIAlwb3J0czogKFhlbmV2 ZW50Y2huLnQsIENvbm5lY3Rpb24udCkgSGFzaHRibC50OwogCW11dGFibGUg d2F0Y2hlczogQ29ubmVjdGlvbi53YXRjaCBsaXN0IFRyaWUudDsKKwltdXRh YmxlIGhhc19wZW5kaW5nX3dhdGNoZXZlbnRzOiBDb25uZWN0aW9uLldhdGNo LlNldC50CiB9CiAKIGxldCBjcmVhdGUgKCkgPSB7CiAJYW5vbnltb3VzID0g SGFzaHRibC5jcmVhdGUgMzc7CiAJZG9tYWlucyA9IEhhc2h0YmwuY3JlYXRl IDM3OwogCXBvcnRzID0gSGFzaHRibC5jcmVhdGUgMzc7Ci0Jd2F0Y2hlcyA9 IFRyaWUuY3JlYXRlICgpCisJd2F0Y2hlcyA9IFRyaWUuY3JlYXRlICgpOwor CWhhc19wZW5kaW5nX3dhdGNoZXZlbnRzID0gQ29ubmVjdGlvbi5XYXRjaC5T ZXQuZW1wdHk7CiB9CiAKK2xldCBnZXRfY2FwYWNpdHkgKCkgPQorCSgqIG5v dCBtdWx0aXBsaWVkIGJ5IG1heHdhdGNoIG9uIHB1cnBvc2U6IDJuZCBxdWV1 ZSBpbiB3YXRjaCBpdHNlbGYhICopCisJeyBYZW5idXMuWGIubWF4b3V0c3Rh bmRpbmcgPSAhRGVmaW5lLm1heG91dHN0YW5kaW5nOyBtYXh3YXRjaGV2ZW50 cyA9ICFEZWZpbmUubWF4d2F0Y2hldmVudHMgfQorCiBsZXQgYWRkX2Fub255 bW91cyBjb25zIGZkID0KLQlsZXQgeGJjb24gPSBYZW5idXMuWGIub3Blbl9m ZCBmZCBpbgorCWxldCBjYXBhY2l0eSA9IGdldF9jYXBhY2l0eSAoKSBpbgor CWxldCB4YmNvbiA9IFhlbmJ1cy5YYi5vcGVuX2ZkIGZkIH5jYXBhY2l0eSBp bgogCWxldCBjb24gPSBDb25uZWN0aW9uLmNyZWF0ZSB4YmNvbiBOb25lIGlu CiAJSGFzaHRibC5hZGQgY29ucy5hbm9ueW1vdXMgKFhlbmJ1cy5YYi5nZXRf ZmQgeGJjb24pIGNvbgogCiBsZXQgYWRkX2RvbWFpbiBjb25zIGRvbSA9Ci0J bGV0IHhiY29uID0gWGVuYnVzLlhiLm9wZW5fbW1hcCAoRG9tYWluLmdldF9p bnRlcmZhY2UgZG9tKSAoZnVuICgpIC0+IERvbWFpbi5ub3RpZnkgZG9tKSBp bgorCWxldCBjYXBhY2l0eSA9IGdldF9jYXBhY2l0eSAoKSBpbgorCWxldCB4 YmNvbiA9IFhlbmJ1cy5YYi5vcGVuX21tYXAgfmNhcGFjaXR5IChEb21haW4u Z2V0X2ludGVyZmFjZSBkb20pIChmdW4gKCkgLT4gRG9tYWluLm5vdGlmeSBk b20pIGluCiAJbGV0IGNvbiA9IENvbm5lY3Rpb24uY3JlYXRlIHhiY29uIChT b21lIGRvbSkgaW4KIAlIYXNodGJsLmFkZCBjb25zLmRvbWFpbnMgKERvbWFp bi5nZXRfaWQgZG9tKSBjb247CiAJbWF0Y2ggRG9tYWluLmdldF9wb3J0IGRv bSB3aXRoCkBAIC00OCw3ICs1Niw5IEBAIGxldCBzZWxlY3QgPyhvbmx5X2lm ID0gKGZ1biBfIC0+IHRydWUpKSBjb25zID0KIAlIYXNodGJsLmZvbGQgKGZ1 biBfIGNvbiAoaW5zLCBvdXRzKSAtPgogCQlpZiAob25seV9pZiBjb24pIHRo ZW4gKAogCQkJbGV0IGZkID0gQ29ubmVjdGlvbi5nZXRfZmQgY29uIGluCi0J CQkoZmQgOjogaW5zLCAgaWYgQ29ubmVjdGlvbi5oYXNfb3V0cHV0IGNvbiB0 aGVuIGZkIDo6IG91dHMgZWxzZSBvdXRzKQorCQkJbGV0IGluX2ZkcyA9IGlm IENvbm5lY3Rpb24uY2FuX2lucHV0IGNvbiB0aGVuIGZkIDo6IGlucyBlbHNl IGlucyBpbgorCQkJbGV0IG91dF9mZHMgPSBpZiBDb25uZWN0aW9uLmhhc19v dXRwdXQgY29uIHRoZW4gZmQgOjogb3V0cyBlbHNlIG91dHMgaW4KKwkJCWlu X2Zkcywgb3V0X2ZkcwogCQkpIGVsc2UgKGlucywgb3V0cykKIAkpCiAJY29u cy5hbm9ueW1vdXMgKFtdLCBbXSkKQEAgLTY3LDEwICs3NywxNyBAQCBsZXQg ZGVsX3dhdGNoZXNfb2ZfY29uIGNvbiB3YXRjaGVzID0KIAl8IFtdIC0+IE5v bmUKIAl8IHdzIC0+IFNvbWUgd3MKIAorbGV0IGRlbF93YXRjaGVzIGNvbnMg Y29uID0KKwlDb25uZWN0aW9uLmRlbF93YXRjaGVzIGNvbjsKKwljb25zLndh dGNoZXMgPC0gVHJpZS5tYXAgKGRlbF93YXRjaGVzX29mX2NvbiBjb24pIGNv bnMud2F0Y2hlczsKKwljb25zLmhhc19wZW5kaW5nX3dhdGNoZXZlbnRzIDwt CisJCWNvbnMuaGFzX3BlbmRpbmdfd2F0Y2hldmVudHMgfD4gQ29ubmVjdGlv bi5XYXRjaC5TZXQuZmlsdGVyIEBAIGZ1biB3IC0+CisJCUNvbm5lY3Rpb24u Z2V0X2NvbiB3ICE9IGNvbgorCiBsZXQgZGVsX2Fub255bW91cyBjb25zIGNv biA9CiAJdHJ5CiAJCUhhc2h0YmwucmVtb3ZlIGNvbnMuYW5vbnltb3VzIChD b25uZWN0aW9uLmdldF9mZCBjb24pOwotCQljb25zLndhdGNoZXMgPC0gVHJp ZS5tYXAgKGRlbF93YXRjaGVzX29mX2NvbiBjb24pIGNvbnMud2F0Y2hlczsK KwkJZGVsX3dhdGNoZXMgY29ucyBjb247CiAJCUNvbm5lY3Rpb24uY2xvc2Ug Y29uCiAJd2l0aCBleG4gLT4KIAkJZGVidWcgImRlbCBhbm9ueW1vdXMgJXMi IChQcmludGV4Yy50b19zdHJpbmcgZXhuKQpAQCAtODUsNyArMTAyLDcgQEAg bGV0IGRlbF9kb21haW4gY29ucyBpZCA9CiAJCSAgICB8IFNvbWUgcCAtPiBI YXNodGJsLnJlbW92ZSBjb25zLnBvcnRzIHAKIAkJICAgIHwgTm9uZSAtPiAo KSkKIAkJIHwgTm9uZSAtPiAoKSk7Ci0JCWNvbnMud2F0Y2hlcyA8LSBUcmll Lm1hcCAoZGVsX3dhdGNoZXNfb2ZfY29uIGNvbikgY29ucy53YXRjaGVzOwor CQlkZWxfd2F0Y2hlcyBjb25zIGNvbjsKIAkJQ29ubmVjdGlvbi5jbG9zZSBj b24KIAl3aXRoIGV4biAtPgogCQlkZWJ1ZyAiZGVsIGRvbWFpbiAldTogJXMi IGlkIChQcmludGV4Yy50b19zdHJpbmcgZXhuKQpAQCAtMTM2LDMxICsxNTMs MzMgQEAgbGV0IGRlbF93YXRjaCBjb25zIGNvbiBwYXRoIHRva2VuID0KIAkJ Y29ucy53YXRjaGVzIDwtIFRyaWUuc2V0IGNvbnMud2F0Y2hlcyBrZXkgd2F0 Y2hlczsKICAJd2F0Y2gKIAotbGV0IGRlbF93YXRjaGVzIGNvbnMgY29uID0K LQlDb25uZWN0aW9uLmRlbF93YXRjaGVzIGNvbjsKLQljb25zLndhdGNoZXMg PC0gVHJpZS5tYXAgKGRlbF93YXRjaGVzX29mX2NvbiBjb24pIGNvbnMud2F0 Y2hlcwotCiAoKiBwYXRoIGlzIGFic29sdXRlICopCi1sZXQgZmlyZV93YXRj aGVzID9vbGRyb290IHJvb3QgY29ucyBwYXRoIHJlY3Vyc2UgPQorbGV0IGZp cmVfd2F0Y2hlcyA/b2xkcm9vdCBzb3VyY2Ugcm9vdCBjb25zIHBhdGggcmVj dXJzZSA9CiAJbGV0IGtleSA9IGtleV9vZl9wYXRoIHBhdGggaW4KIAlsZXQg cGF0aCA9IFN0b3JlLlBhdGgudG9fc3RyaW5nIHBhdGggaW4KIAlsZXQgcm9v dHMgPSBvbGRyb290LCByb290IGluCiAJbGV0IGZpcmVfd2F0Y2ggXyA9IGZ1 bmN0aW9uCiAJCXwgTm9uZSAgICAgICAgIC0+ICgpCi0JCXwgU29tZSB3YXRj aGVzIC0+IExpc3QuaXRlciAoZnVuIHcgLT4gQ29ubmVjdGlvbi5maXJlX3dh dGNoIHJvb3RzIHcgcGF0aCkgd2F0Y2hlcworCQl8IFNvbWUgd2F0Y2hlcyAt PiBMaXN0Lml0ZXIgKGZ1biB3IC0+IENvbm5lY3Rpb24uZmlyZV93YXRjaCBz b3VyY2Ugcm9vdHMgdyBwYXRoKSB3YXRjaGVzCiAJaW4KIAlsZXQgZmlyZV9y ZWMgX3ggPSBmdW5jdGlvbgogCQl8IE5vbmUgICAgICAgICAtPiAoKQogCQl8 IFNvbWUgd2F0Y2hlcyAtPgotCQkJTGlzdC5pdGVyIChDb25uZWN0aW9uLmZp cmVfc2luZ2xlX3dhdGNoIHJvb3RzKSB3YXRjaGVzCisJCQlMaXN0Lml0ZXIg KENvbm5lY3Rpb24uZmlyZV9zaW5nbGVfd2F0Y2ggc291cmNlIHJvb3RzKSB3 YXRjaGVzCiAJaW4KIAlUcmllLml0ZXJfcGF0aCBmaXJlX3dhdGNoIGNvbnMu d2F0Y2hlcyBrZXk7CiAJaWYgcmVjdXJzZSB0aGVuCiAJCVRyaWUuaXRlciBm aXJlX3JlYyAoVHJpZS5zdWIgY29ucy53YXRjaGVzIGtleSkKIAorbGV0IHNl bmRfd2F0Y2hldmVudHMgY29ucyBjb24gPQorCWNvbnMuaGFzX3BlbmRpbmdf d2F0Y2hldmVudHMgPC0KKwkJY29ucy5oYXNfcGVuZGluZ193YXRjaGV2ZW50 cyB8PiBDb25uZWN0aW9uLldhdGNoLlNldC5maWx0ZXIgQ29ubmVjdGlvbi5X YXRjaC5mbHVzaF9ldmVudHM7CisJQ29ubmVjdGlvbi5zb3VyY2VfZmx1c2hf d2F0Y2hldmVudHMgY29uCisKIGxldCBmaXJlX3NwZWNfd2F0Y2hlcyByb290 IGNvbnMgc3BlY3BhdGggPQorCWxldCBzb3VyY2UgPSBmaW5kX2RvbWFpbiBj b25zIDAgaW4KIAlpdGVyIGNvbnMgKGZ1biBjb24gLT4KLQkJTGlzdC5pdGVy IChDb25uZWN0aW9uLmZpcmVfc2luZ2xlX3dhdGNoIChOb25lLCByb290KSkg KENvbm5lY3Rpb24uZ2V0X3dhdGNoZXMgY29uIHNwZWNwYXRoKSkKKwkJTGlz dC5pdGVyIChDb25uZWN0aW9uLmZpcmVfc2luZ2xlX3dhdGNoIHNvdXJjZSAo Tm9uZSwgcm9vdCkpIChDb25uZWN0aW9uLmdldF93YXRjaGVzIGNvbiBzcGVj cGF0aCkpCiAKIGxldCBzZXRfdGFyZ2V0IGNvbnMgZG9tYWluIHRhcmdldF9k b21haW4gPQogCWxldCBjb24gPSBmaW5kX2RvbWFpbiBjb25zIGRvbWFpbiBp bgpAQCAtMTk3LDYgKzIxNiwxNiBAQCBsZXQgZGVidWcgY29ucyA9CiAJbGV0 IGRvbWFpbnMgPSBIYXNodGJsLmZvbGQgKGZ1biBfIGNvbiBhY2N1IC0+IENv bm5lY3Rpb24uZGVidWcgY29uIDo6IGFjY3UpIGNvbnMuZG9tYWlucyBbXSBp bgogCVN0cmluZy5jb25jYXQgIiIgKGRvbWFpbnMgQCBhbm9ueW1vdXMpCiAK K2xldCBkZWJ1Z193YXRjaGV2ZW50cyBjb25zIGNvbiA9CisJKCogPT0gKHBo eXNpY2FsIGVxdWFsaXR5KQorCSAgIGhhcyB0byBiZSB1c2VkIGhlcmUgYmVj YXVzZSB3LmNvbi54Yi5iYWNrZW5kIG1pZ2h0IGNvbnRhaW4gYSBbdW5pdC0+ dW5pdF0gdmFsdWUgY2F1c2luZyByZWd1bGFyCisJICAgY29tcGFyaXNvbiB0 byBmYWlsIGR1ZSB0byBoYXZpbmcgYSAnZnVuY3Rpb25hbCB2YWx1ZScgd2hp Y2ggY2Fubm90IGJlIGNvbXBhcmVkLgorCSAqKQorCWxldCBzID0gY29ucy5o YXNfcGVuZGluZ193YXRjaGV2ZW50cyB8PiBDb25uZWN0aW9uLldhdGNoLlNl dC5maWx0ZXIgKGZ1biB3IC0+IHcuY29uID09IGNvbikgaW4KKwlsZXQgcGVu ZGluZyA9IHMgfD4gQ29ubmVjdGlvbi5XYXRjaC5TZXQuZWxlbWVudHMKKwkJ fD4gTGlzdC5tYXAgKGZ1biB3IC0+IENvbm5lY3Rpb24uV2F0Y2gucGVuZGlu Z193YXRjaGV2ZW50cyB3KSB8PiBMaXN0LmZvbGRfbGVmdCAoKykgMCBpbgor CVByaW50Zi5zcHJpbnRmICJXYXRjaGVzIHdpdGggcGVuZGluZyBldmVudHM6 ICVkLCBwZW5kaW5nIGV2ZW50cyB0b3RhbDogJWQiIChDb25uZWN0aW9uLldh dGNoLlNldC5jYXJkaW5hbCBzKSBwZW5kaW5nCisKIGxldCBmaWx0ZXIgfmYg Y29ucyA9CiAJbGV0IGZvbGQgXyB2IGFjYyA9IGlmIGYgdiB0aGVuIHYgOjog YWNjIGVsc2UgYWNjIGluCiAJW10KZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9kZWZpbmUubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQv ZGVmaW5lLm1sCmluZGV4IGJhNjNhODE0N2UwOS4uMzI3YjZkNzk1ZWM3IDEw MDY0NAotLS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQvZGVmaW5lLm1sCisr KyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKQEAgLTI0LDYg KzI0LDEzIEBAIGxldCBkZWZhdWx0X2NvbmZpZ19kaXIgPSBQYXRocy54ZW5f Y29uZmlnX2RpcgogbGV0IG1heHdhdGNoID0gcmVmICgxMDApCiBsZXQgbWF4 dHJhbnNhY3Rpb24gPSByZWYgKDEwKQogbGV0IG1heHJlcXVlc3RzID0gcmVm ICgxMDI0KSAgICgqIG1heGltdW0gcmVxdWVzdHMgcGVyIHRyYW5zYWN0aW9u ICopCitsZXQgbWF4b3V0c3RhbmRpbmcgPSByZWYgKDEwMjQpICgqIG1heGlt dW0gb3V0c3RhbmRpbmcgcmVxdWVzdHMsIGkuZS4gaW4tZmxpZ2h0IHJlcXVl c3RzIC8gZG9tYWluICopCitsZXQgbWF4d2F0Y2hldmVudHMgPSByZWYgKDEw MjQpCisoKgorCW1heGltdW0gb3V0c3RhbmRpbmcgd2F0Y2ggZXZlbnRzIHBl ciB3YXRjaCwKKwlyZWNvbW1lbmRlZCA+PSBtYXhvdXRzdGFuZGluZyB0byBh dm9pZCBibG9ja2luZyBiYWNrZW5kIHRyYW5zYWN0aW9ucyBkdWUgdG8KKwlt YWxpY2lvdXMgZnJvbnRlbmRzCisgKikKIAogbGV0IGdjX21heF9vdmVyaGVh ZCA9IHJlZiAxMjAgKCogMTIwJSBzZWUgY29tbWVudCBpbiB4ZW5zdG9yZWQu bWwgKikKIGxldCBjb25mbGljdF9idXJzdF9saW1pdCA9IHJlZiA1LjAKZGlm ZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9veGVuc3RvcmVkLmNv bmYuaW4gYi90b29scy9vY2FtbC94ZW5zdG9yZWQvb3hlbnN0b3JlZC5jb25m LmluCmluZGV4IDRhZTQ4ZTQyZDQ3ZC4uOWQwMzRlNzQ0YjRiIDEwMDY0NAot LS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQvb3hlbnN0b3JlZC5jb25mLmlu CisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9veGVuc3RvcmVkLmNvbmYu aW4KQEAgLTYyLDYgKzYyLDggQEAgcXVvdGEtbWF4d2F0Y2ggPSAxMDAKIHF1 b3RhLXRyYW5zYWN0aW9uID0gMTAKIHF1b3RhLW1heHJlcXVlc3RzID0gMTAy NAogcXVvdGEtcGF0aC1tYXggPSAxMDI0CitxdW90YS1tYXhvdXRzdGFuZGlu ZyA9IDEwMjQKK3F1b3RhLW1heHdhdGNoZXZlbnRzID0gMTAyNAogCiAjIEFj dGl2YXRlIGZpbGVkIGJhc2UgYmFja2VuZAogcGVyc2lzdGVudCA9IGZhbHNl CmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5t bCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9wcm9jZXNzLm1sCmluZGV4IDJk Njc0NTZhMmFhMC4uNmRjZWRmZGE4NmU0IDEwMDY0NAotLS0gYS90b29scy9v Y2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbAorKysgYi90b29scy9vY2FtbC94 ZW5zdG9yZWQvcHJvY2Vzcy5tbApAQCAtNTcsNyArNTcsNyBAQCBsZXQgc3Bs aXRfb25lX3BhdGggZGF0YSBjb24gPQogCXwgcGF0aCA6OiAiIiA6OiBbXSAt PiBTdG9yZS5QYXRoLmNyZWF0ZSBwYXRoIChDb25uZWN0aW9uLmdldF9wYXRo IGNvbikKIAl8IF8gICAgICAgICAgICAgICAgLT4gcmFpc2UgSW52YWxpZF9D bWRfQXJncwogCi1sZXQgcHJvY2Vzc193YXRjaCB0IGNvbnMgPQorbGV0IHBy b2Nlc3Nfd2F0Y2ggc291cmNlIHQgY29ucyA9CiAJbGV0IG9sZHJvb3QgPSB0 LlRyYW5zYWN0aW9uLm9sZHJvb3QgaW4KIAlsZXQgbmV3cm9vdCA9IFN0b3Jl LmdldF9yb290IHQuc3RvcmUgaW4KIAlsZXQgb3BzID0gVHJhbnNhY3Rpb24u Z2V0X3BhdGhzIHQgfD4gTGlzdC5yZXYgaW4KQEAgLTY3LDggKzY3LDkgQEAg bGV0IHByb2Nlc3Nfd2F0Y2ggdCBjb25zID0KIAkJfCBYZW5idXMuWGIuT3Au Um0gICAgICAgLT4gdHJ1ZSwgTm9uZSwgb2xkcm9vdAogCQl8IFhlbmJ1cy5Y Yi5PcC5TZXRwZXJtcyAtPiBmYWxzZSwgU29tZSBvbGRyb290LCBuZXdyb290 CiAJCXwgXyAgICAgICAgICAgICAgLT4gcmFpc2UgKEZhaWx1cmUgImh1aCA/ IikgaW4KLQkJQ29ubmVjdGlvbnMuZmlyZV93YXRjaGVzID9vbGRyb290IHJv b3QgY29ucyAoc25kIG9wKSByZWN1cnNlIGluCi0JTGlzdC5pdGVyIChmdW4g b3AgLT4gZG9fb3Bfd2F0Y2ggb3AgY29ucykgb3BzCisJCUNvbm5lY3Rpb25z LmZpcmVfd2F0Y2hlcyA/b2xkcm9vdCBzb3VyY2Ugcm9vdCBjb25zIChzbmQg b3ApIHJlY3Vyc2UgaW4KKwlMaXN0Lml0ZXIgKGZ1biBvcCAtPiBkb19vcF93 YXRjaCBvcCBjb25zKSBvcHM7CisJQ29ubmVjdGlvbnMuc2VuZF93YXRjaGV2 ZW50cyBjb25zIHNvdXJjZQogCiBsZXQgY3JlYXRlX2ltcGxpY2l0X3BhdGgg dCBwZXJtIHBhdGggPQogCWxldCBkaXJuYW1lID0gU3RvcmUuUGF0aC5nZXRf cGFyZW50IHBhdGggaW4KQEAgLTIzNCw2ICsyMzUsMjAgQEAgbGV0IGRvX2Rl YnVnIGNvbiB0IF9kb21haW5zIGNvbnMgZGF0YSA9CiAJfCAid2F0Y2hlcyIg OjogXyAtPgogCQlsZXQgd2F0Y2hlcyA9IENvbm5lY3Rpb25zLmRlYnVnIGNv bnMgaW4KIAkJU29tZSAod2F0Y2hlcyBeICJcMDAwIikKKwl8ICJ4ZW5idXMi IDo6IGRvbWlkIDo6IF8gLT4KKwkJbGV0IGRvbWlkID0gaW50X29mX3N0cmlu ZyBkb21pZCBpbgorCQlsZXQgY29uID0gQ29ubmVjdGlvbnMuZmluZF9kb21h aW4gY29ucyBkb21pZCBpbgorCQlsZXQgcyA9IFByaW50Zi5zcHJpbnRmICJ4 ZW5idXM6ICVzOyBvdmVyZmxvdyBxdWV1ZSBsZW5ndGg6ICVkLCBjYW5faW5w dXQ6ICViLCBoYXNfbW9yZV9pbnB1dDogJWIsIGhhc19vbGRfb3V0cHV0OiAl YiwgaGFzX25ld19vdXRwdXQ6ICViLCBoYXNfbW9yZV93b3JrOiAlYi4gcGVu ZGluZzogJXMiCisJCQkoWGVuYnVzLlhiLmRlYnVnIGNvbi54YikKKwkJCShD b25uZWN0aW9uLnNvdXJjZV9wZW5kaW5nX3dhdGNoZXZlbnRzIGNvbikKKwkJ CShDb25uZWN0aW9uLmNhbl9pbnB1dCBjb24pCisJCQkoQ29ubmVjdGlvbi5o YXNfbW9yZV9pbnB1dCBjb24pCisJCQkoQ29ubmVjdGlvbi5oYXNfb2xkX291 dHB1dCBjb24pCisJCQkoQ29ubmVjdGlvbi5oYXNfbmV3X291dHB1dCBjb24p CisJCQkoQ29ubmVjdGlvbi5oYXNfbW9yZV93b3JrIGNvbikKKwkJCShDb25u ZWN0aW9ucy5kZWJ1Z193YXRjaGV2ZW50cyBjb25zIGNvbikKKwkJaW4KKwkJ U29tZSBzCiAJfCAibWZuIiA6OiBkb21pZCA6OiBfIC0+CiAJCWxldCBkb21p ZCA9IGludF9vZl9zdHJpbmcgZG9taWQgaW4KIAkJbGV0IGNvbiA9IENvbm5l Y3Rpb25zLmZpbmRfZG9tYWluIGNvbnMgZG9taWQgaW4KQEAgLTM0Miw3ICsz NTcsNyBAQCBsZXQgcmVwbHlfYWNrIGZjdCBjb24gdCBkb21zIGNvbnMgZGF0 YSA9CiAJZmN0IGNvbiB0IGRvbXMgY29ucyBkYXRhOwogCVBhY2tldC5BY2sg KGZ1biAoKSAtPgogCQlpZiBUcmFuc2FjdGlvbi5nZXRfaWQgdCA9IFRyYW5z YWN0aW9uLm5vbmUgdGhlbgotCQkJcHJvY2Vzc193YXRjaCB0IGNvbnMKKwkJ CXByb2Nlc3Nfd2F0Y2ggY29uIHQgY29ucwogCSkKIAogbGV0IHJlcGx5X2Rh dGEgZmN0IGNvbiB0IGRvbXMgY29ucyBkYXRhID0KQEAgLTUwMSw3ICs1MTYs NyBAQCBsZXQgZG9fd2F0Y2ggY29uIHQgX2RvbWFpbnMgY29ucyBkYXRhID0K IAlQYWNrZXQuQWNrIChmdW4gKCkgLT4KIAkJKCogeGVuc3RvcmUudHh0IHNh eXMgdGhpcyB3YXRjaCBpcyBmaXJlZCBpbW1lZGlhdGVseSwKIAkJICAgaW1w bHlpbmcgZXZlbiBpZiBwYXRoIGRvZXNuJ3QgZXhpc3Qgb3IgaXMgdW5yZWFk YWJsZSAqKQotCQlDb25uZWN0aW9uLmZpcmVfc2luZ2xlX3dhdGNoX3VuY2hl Y2tlZCB3YXRjaCkKKwkJQ29ubmVjdGlvbi5maXJlX3NpbmdsZV93YXRjaF91 bmNoZWNrZWQgY29uIHdhdGNoKQogCiBsZXQgZG9fdW53YXRjaCBjb24gX3Qg X2RvbWFpbnMgY29ucyBkYXRhID0KIAlsZXQgKG5vZGUsIHRva2VuKSA9CkBA IC01MzIsNyArNTQ3LDcgQEAgbGV0IGRvX3RyYW5zYWN0aW9uX2VuZCBjb24g dCBkb21haW5zIGNvbnMgZGF0YSA9CiAJaWYgbm90IHN1Y2Nlc3MgdGhlbgog CQlyYWlzZSBUcmFuc2FjdGlvbl9hZ2FpbjsKIAlpZiBjb21taXQgdGhlbiBi ZWdpbgotCQlwcm9jZXNzX3dhdGNoIHQgY29uczsKKwkJcHJvY2Vzc193YXRj aCBjb24gdCBjb25zOwogCQltYXRjaCB0LlRyYW5zYWN0aW9uLnR5IHdpdGgK IAkJfCBUcmFuc2FjdGlvbi5ObyAtPgogCQkJKCkgKCogbm8gbmVlZCB0byBy ZWNvcmQgYW55dGhpbmcgKikKQEAgLTY5OSw3ICs3MTQsOCBAQCBsZXQgcHJv Y2Vzc19wYWNrZXQgfnN0b3JlIH5jb25zIH5kb21zIH5jb24gfnJlcSA9CiBs ZXQgZG9faW5wdXQgc3RvcmUgY29ucyBkb21zIGNvbiA9CiAJbGV0IG5ld3Bh Y2tldCA9CiAJCXRyeQotCQkJQ29ubmVjdGlvbi5kb19pbnB1dCBjb24KKwkJ CWlmIENvbm5lY3Rpb24uY2FuX2lucHV0IGNvbiB0aGVuIENvbm5lY3Rpb24u ZG9faW5wdXQgY29uCisJCQllbHNlIE5vbmUKIAkJd2l0aCBYZW5idXMuWGIu UmVjb25uZWN0IC0+CiAJCQlpbmZvICIlcyByZXF1ZXN0cyBhIHJlY29ubmVj dCIgKENvbm5lY3Rpb24uZ2V0X2RvbXN0ciBjb24pOwogCQkJSGlzdG9yeS5y ZWNvbm5lY3QgY29uOwpAQCAtNzI3LDYgKzc0Myw3IEBAIGxldCBkb19pbnB1 dCBzdG9yZSBjb25zIGRvbXMgY29uID0KIAkJQ29ubmVjdGlvbi5pbmNyX29w cyBjb24KIAogbGV0IGRvX291dHB1dCBfc3RvcmUgX2NvbnMgX2RvbXMgY29u ID0KKwlDb25uZWN0aW9uLnNvdXJjZV9mbHVzaF93YXRjaGV2ZW50cyBjb247 CiAJaWYgQ29ubmVjdGlvbi5oYXNfb3V0cHV0IGNvbiB0aGVuICgKIAkJaWYg Q29ubmVjdGlvbi5oYXNfbmV3X291dHB1dCBjb24gdGhlbiAoCiAJCQlsZXQg cGFja2V0ID0gQ29ubmVjdGlvbi5wZWVrX291dHB1dCBjb24gaW4KZGlmZiAt LWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC94ZW5zdG9yZWQubWwgYi90 b29scy9vY2FtbC94ZW5zdG9yZWQveGVuc3RvcmVkLm1sCmluZGV4IDNiNTdh ZDAxNmRmYi4uYzc5OWUyMGYxMTQ1IDEwMDY0NAotLS0gYS90b29scy9vY2Ft bC94ZW5zdG9yZWQveGVuc3RvcmVkLm1sCisrKyBiL3Rvb2xzL29jYW1sL3hl bnN0b3JlZC94ZW5zdG9yZWQubWwKQEAgLTEwMyw2ICsxMDMsOCBAQCBsZXQg cGFyc2VfY29uZmlnIGZpbGVuYW1lID0KIAkJKCJxdW90YS1tYXhlbnRpdHki LCBDb25maWcuU2V0X2ludCBRdW90YS5tYXhlbnQpOwogCQkoInF1b3RhLW1h eHNpemUiLCBDb25maWcuU2V0X2ludCBRdW90YS5tYXhzaXplKTsKIAkJKCJx dW90YS1tYXhyZXF1ZXN0cyIsIENvbmZpZy5TZXRfaW50IERlZmluZS5tYXhy ZXF1ZXN0cyk7CisJCSgicXVvdGEtbWF4b3V0c3RhbmRpbmciLCBDb25maWcu U2V0X2ludCBEZWZpbmUubWF4b3V0c3RhbmRpbmcpOworCQkoInF1b3RhLW1h eHdhdGNoZXZlbnRzIiwgQ29uZmlnLlNldF9pbnQgRGVmaW5lLm1heHdhdGNo ZXZlbnRzKTsKIAkJKCJxdW90YS1wYXRoLW1heCIsIENvbmZpZy5TZXRfaW50 IERlZmluZS5wYXRoX21heCk7CiAJCSgiZ2MtbWF4LW92ZXJoZWFkIiwgQ29u ZmlnLlNldF9pbnQgRGVmaW5lLmdjX21heF9vdmVyaGVhZCk7CiAJCSgidGVz dC1lYWdhaW4iLCBDb25maWcuU2V0X2Jvb2wgVHJhbnNhY3Rpb24udGVzdF9l YWdhaW4pOwo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-oxenstored-08.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-oxenstored-08.patch" Content-Transfer-Encoding: base64 RnJvbSAwOWFhMTA2NDlmNzVhMjYyMDI4ZTlhOWI3ZDg1OWVmN2VmYjIzZDU0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFRodSwgMjkgU2VwIDIwMjIgMTM6 MDc6MzUgKzAyMDAKU3ViamVjdDogU1VQUE9SVC5tZDogY2xhcmlmeSBzdXBw b3J0IG9mIHVudHJ1c3RlZCBkcml2ZXIgZG9tYWlucyB3aXRoCiBveGVuc3Rv cmVkCgpBZGQgYSBzdXBwb3J0IHN0YXRlbWVudCBmb3IgdGhlIHNjb3BlIG9m IHN1cHBvcnQgcmVnYXJkaW5nIGRpZmZlcmVudApYZW5zdG9yZSB2YXJpYW50 cy4gRXNwZWNpYWxseSBveGVuc3RvcmVkIGRvZXMgbm90ICh5ZXQpIGhhdmUg c2VjdXJpdHkKc3VwcG9ydCBvZiB1bnRydXN0ZWQgZHJpdmVyIGRvbWFpbnMs IGFzIHRob3NlIG1pZ2h0IGRyaXZlIG94ZW5zdG9yZWQKb3V0IG9mIG1lbW9y eSBieSBjcmVhdGluZyBsb3RzIG9mIHdhdGNoIGV2ZW50cyBmb3IgdGhlIGd1 ZXN0cyB0aGV5IGFyZQpzZXJ2aWNpbmcuCgpBZGQgYSBzdGF0ZW1lbnQgcmVn YXJkaW5nIExpdmUgVXBkYXRlIHN1cHBvcnQgb2Ygb3hlbnN0b3JlZC4KClRo aXMgaXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEdlb3JnZSBE dW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClJldmlld2VkLWJ5OiBD aHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+ CgpkaWZmIC0tZ2l0IGEvU1VQUE9SVC5tZCBiL1NVUFBPUlQubWQKaW5kZXgg ODU3MjYxMDJlYWI4Li43ZDBjYjM0YzhmNmYgMTAwNjQ0Ci0tLSBhL1NVUFBP UlQubWQKKysrIGIvU1VQUE9SVC5tZApAQCAtMTc5LDEzICsxNzksMTggQEAg U3VwcG9ydCBmb3IgcnVubmluZyBxZW11LXhlbiBkZXZpY2UgbW9kZWwgaW4g YSBsaW51eCBzdHViZG9tYWluLgogCiAgICAgU3RhdHVzOiBUZWNoIFByZXZp ZXcKIAotIyMgTGl2ZXVwZGF0ZSBvZiBDIHhlbnN0b3JlZCBkYWVtb24KKyMj IFhlbnN0b3JlCiAKLSAgICBTdGF0dXM6IFRlY2ggUHJldmlldworIyMjIEMg eGVuc3RvcmVkIGRhZW1vbgogCi0jIyBMaXZldXBkYXRlIG9mIE9DYW1sIHhl bnN0b3JlZCBkYWVtb24KKyAgICBTdGF0dXM6IFN1cHBvcnRlZAorICAgIFN0 YXR1cywgTGl2ZXVwZGF0ZTogVGVjaCBQcmV2aWV3CiAKLSAgICBTdGF0dXM6 IFRlY2ggUHJldmlldworIyMjIE9DYW1sIHhlbnN0b3JlZCBkYWVtb24KKwor ICAgIFN0YXR1czogU3VwcG9ydGVkCisgICAgU3RhdHVzLCB1bnRydXN0ZWQg ZHJpdmVyIGRvbWFpbnM6IFN1cHBvcnRlZCwgbm90IHNlY3VyaXR5IHN1cHBv cnRlZAorICAgIFN0YXR1cywgTGl2ZXVwZGF0ZTogTm90IGZ1bmN0aW9uYWwK IAogIyMgVG9vbHN0YWNrLzNyZCBwYXJ0eQogCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-01.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-01.patch" Content-Transfer-Encoding: base64 RnJvbSA1MTkyZjEzYTQxNjYxYjFjMWI5ZTA4ODlkNTdjMGY1YjQxOTI1YzM5 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHNwbGl0IHVw IHNlbmRfcmVwbHkoKQoKVG9kYXkgc2VuZF9yZXBseSgpIGlzIHVzZWQgZm9y IGJvdGgsIG5vcm1hbCByZXF1ZXN0IHJlcGxpZXMgYW5kIHdhdGNoCmV2ZW50 cy4KClNwbGl0IGl0IHVwIGludG8gc2VuZF9yZXBseSgpIGFuZCBzZW5kX2V2 ZW50KCkuIFRoaXMgd2lsbCBiZSB1c2VkIHRvCmFkZCBzb21lIGV2ZW50IHNw ZWNpZmljIGhhbmRsaW5nLgoKYWRkX2V2ZW50KCkgY2FuIGJlIG1lcmdlZCBp bnRvIHNlbmRfZXZlbnQoKSwgcmVtb3ZpbmcgdGhlIG5lZWQgZm9yIGFuCmlu dGVybWVkaWF0ZSBtZW1vcnkgYWxsb2NhdGlvbi4KClRoaXMgaXMgcGFydCBv ZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxs QGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpn cm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdy YWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMKaW5kZXggZTljOTY5NWZkMTZlLi4yNDlhZDVlYzZmYjEgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtNzY3LDQ5ICs3 NjcsMzIgQEAgc3RhdGljIHZvaWQgc2VuZF9lcnJvcihzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgaW50IGVycm9yKQogdm9pZCBzZW5kX3JlcGx5KHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlw ZSwKIAkJY29uc3Qgdm9pZCAqZGF0YSwgdW5zaWduZWQgaW50IGxlbikKIHsK LQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRhdGE7CisJc3RydWN0IGJ1ZmZl cmVkX2RhdGEgKmJkYXRhID0gY29ubi0+aW47CisKKwlhc3NlcnQodHlwZSAh PSBYU19XQVRDSF9FVkVOVCk7CiAKIAlpZiAoIGxlbiA+IFhFTlNUT1JFX1BB WUxPQURfTUFYICkgewogCQlzZW5kX2Vycm9yKGNvbm4sIEUyQklHKTsKIAkJ cmV0dXJuOwogCX0KIAotCS8qIFJlcGxpZXMgcmV1c2UgdGhlIHJlcXVlc3Qg YnVmZmVyLCBldmVudHMgbmVlZCBhIG5ldyBvbmUuICovCi0JaWYgKHR5cGUg IT0gWFNfV0FUQ0hfRVZFTlQpIHsKLQkJYmRhdGEgPSBjb25uLT5pbjsKLQkJ LyogRHJvcCBhc3luY2hyb25vdXMgcmVzcG9uc2VzLCBlLmcuIGVycm9ycyBm b3Igd2F0Y2ggZXZlbnRzLiAqLwotCQlpZiAoIWJkYXRhKQotCQkJcmV0dXJu OwotCQliZGF0YS0+aW5oZHIgPSB0cnVlOwotCQliZGF0YS0+dXNlZCA9IDA7 Ci0JCWNvbm4tPmluID0gTlVMTDsKLQl9IGVsc2UgewotCQkvKiBNZXNzYWdl IGlzIGEgY2hpbGQgb2YgdGhlIGNvbm5lY3Rpb24gZm9yIGF1dG8tY2xlYW51 cC4gKi8KLQkJYmRhdGEgPSBuZXdfYnVmZmVyKGNvbm4pOworCWlmICghYmRh dGEpCisJCXJldHVybjsKKwliZGF0YS0+aW5oZHIgPSB0cnVlOworCWJkYXRh LT51c2VkID0gMDsKIAotCQkvKgotCQkgKiBBbGxvY2F0aW9uIGZhaWx1cmUg aGVyZSBpcyB1bmZvcnR1bmF0ZTogd2UgaGF2ZSBubyB3YXkgdG8KLQkJICog dGVsbCBhbnlib2R5IGFib3V0IGl0LgotCQkgKi8KLQkJaWYgKCFiZGF0YSkK LQkJCXJldHVybjsKLQl9CiAJaWYgKGxlbiA8PSBERUZBVUxUX0JVRkZFUl9T SVpFKQogCQliZGF0YS0+YnVmZmVyID0gYmRhdGEtPmRlZmF1bHRfYnVmZmVy OwotCWVsc2UKKwllbHNlIHsKIAkJYmRhdGEtPmJ1ZmZlciA9IHRhbGxvY19h cnJheShiZGF0YSwgY2hhciwgbGVuKTsKLQlpZiAoIWJkYXRhLT5idWZmZXIp IHsKLQkJaWYgKHR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQpIHsKLQkJCS8qIFNh bWUgYXMgYWJvdmU6IG5vIHdheSB0byB0ZWxsIHNvbWVvbmUuICovCi0JCQl0 YWxsb2NfZnJlZShiZGF0YSk7CisJCWlmICghYmRhdGEtPmJ1ZmZlcikgewor CQkJc2VuZF9lcnJvcihjb25uLCBFTk9NRU0pOwogCQkJcmV0dXJuOwogCQl9 Ci0JCS8qIHJlLWVzdGFibGlzaCByZXF1ZXN0IGJ1ZmZlciBmb3Igc2VuZGlu ZyBFTk9NRU0uICovCi0JCWNvbm4tPmluID0gYmRhdGE7Ci0JCXNlbmRfZXJy b3IoY29ubiwgRU5PTUVNKTsKLQkJcmV0dXJuOwogCX0KIAorCWNvbm4tPmlu ID0gTlVMTDsKKwogCS8qIFVwZGF0ZSByZWxldmFudCBoZWFkZXIgZmllbGRz IGFuZCBmaWxsIGluIHRoZSBtZXNzYWdlIGJvZHkuICovCiAJYmRhdGEtPmhk ci5tc2cudHlwZSA9IHR5cGU7CiAJYmRhdGEtPmhkci5tc2cubGVuID0gbGVu OwpAQCAtODE3LDggKzgwMCwzOSBAQCB2b2lkIHNlbmRfcmVwbHkoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBl LAogCiAJLyogUXVldWUgZm9yIGxhdGVyIHRyYW5zbWlzc2lvbi4gKi8KIAls aXN0X2FkZF90YWlsKCZiZGF0YS0+bGlzdCwgJmNvbm4tPm91dF9saXN0KTsK K30KIAotCXJldHVybjsKKy8qCisgKiBTZW5kIGEgd2F0Y2ggZXZlbnQuCisg KiBBcyB0aGlzIGlzIG5vdCBkaXJlY3RseSByZWxhdGVkIHRvIHRoZSBjdXJy ZW50IGNvbW1hbmQsIGVycm9ycyBjYW4ndCBiZQorICogcmVwb3J0ZWQuCisg Ki8KK3ZvaWQgc2VuZF9ldmVudChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3QgY2hhciAqcGF0aCwgY29uc3QgY2hhciAqdG9rZW4pCit7CisJc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmJkYXRhOworCXVuc2lnbmVkIGludCBsZW47 CisKKwlsZW4gPSBzdHJsZW4ocGF0aCkgKyAxICsgc3RybGVuKHRva2VuKSAr IDE7CisJLyogRG9uJ3QgdHJ5IHRvIHNlbmQgb3Zlci1sb25nIGV2ZW50cy4g Ki8KKwlpZiAobGVuID4gWEVOU1RPUkVfUEFZTE9BRF9NQVgpCisJCXJldHVy bjsKKworCWJkYXRhID0gbmV3X2J1ZmZlcihjb25uKTsKKwlpZiAoIWJkYXRh KQorCQlyZXR1cm47CisKKwliZGF0YS0+YnVmZmVyID0gdGFsbG9jX2FycmF5 KGJkYXRhLCBjaGFyLCBsZW4pOworCWlmICghYmRhdGEtPmJ1ZmZlcikgewor CQl0YWxsb2NfZnJlZShiZGF0YSk7CisJCXJldHVybjsKKwl9CisJc3RyY3B5 KGJkYXRhLT5idWZmZXIsIHBhdGgpOworCXN0cmNweShiZGF0YS0+YnVmZmVy ICsgc3RybGVuKHBhdGgpICsgMSwgdG9rZW4pOworCWJkYXRhLT5oZHIubXNn LnR5cGUgPSBYU19XQVRDSF9FVkVOVDsKKwliZGF0YS0+aGRyLm1zZy5sZW4g PSBsZW47CisKKwkvKiBRdWV1ZSBmb3IgbGF0ZXIgdHJhbnNtaXNzaW9uLiAq LworCWxpc3RfYWRkX3RhaWwoJmJkYXRhLT5saXN0LCAmY29ubi0+b3V0X2xp c3QpOwogfQogCiAvKiBTb21lIHJvdXRpbmVzICh3cml0ZSwgbWtkaXIsIGV0 YykganVzdCBuZWVkIGEgbm9uLWVycm9yIHJldHVybiAqLwpkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKaW5kZXggMDAwNGZhODQ4YzgzLi45 YWY5YWY0MzkwYmQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuaApAQCAtMTg3LDYgKzE4Nyw3IEBAIHVuc2lnbmVkIGludCBnZXRfc3Ry aW5nKGNvbnN0IHN0cnVjdCBidWZmZXJlZF9kYXRhICpkYXRhLCB1bnNpZ25l ZCBpbnQgb2Zmc2V0KTsKIAogdm9pZCBzZW5kX3JlcGx5KHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSwKIAkJ Y29uc3Qgdm9pZCAqZGF0YSwgdW5zaWduZWQgaW50IGxlbik7Cit2b2lkIHNl bmRfZXZlbnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IGNoYXIg KnBhdGgsIGNvbnN0IGNoYXIgKnRva2VuKTsKIAogLyogU29tZSByb3V0aW5l cyAod3JpdGUsIG1rZGlyLCBldGMpIGp1c3QgbmVlZCBhIG5vbi1lcnJvciBy ZXR1cm4gKi8KIHZvaWQgc2VuZF9hY2soc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlKTsKZGlmZiAtLWdpdCBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX3dhdGNoLmMKaW5kZXggYWNhMGE3MWJhZGExLi45 OWEyYzI2NmIyOGEgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF93YXRjaC5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93 YXRjaC5jCkBAIC04NiwzNSArODYsNiBAQCBzdGF0aWMgY29uc3QgY2hhciAq Z2V0X3dhdGNoX3BhdGgoY29uc3Qgc3RydWN0IHdhdGNoICp3YXRjaCwgY29u c3QgY2hhciAqbmFtZSkKIH0KIAogLyoKLSAqIFNlbmQgYSB3YXRjaCBldmVu dC4KLSAqIFRlbXBvcmFyeSBtZW1vcnkgYWxsb2NhdGlvbnMgYXJlIGRvbmUg d2l0aCBjdHguCi0gKi8KLXN0YXRpYyB2b2lkIGFkZF9ldmVudChzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKLQkJICAgICAgY29uc3Qgdm9pZCAqY3R4LAot CQkgICAgICBzdHJ1Y3Qgd2F0Y2ggKndhdGNoLAotCQkgICAgICBjb25zdCBj aGFyICpuYW1lKQotewotCS8qIERhdGEgdG8gc2VuZCAobm9kZVwwdG9rZW5c MCkuICovCi0JdW5zaWduZWQgaW50IGxlbjsKLQljaGFyICpkYXRhOwotCi0J bmFtZSA9IGdldF93YXRjaF9wYXRoKHdhdGNoLCBuYW1lKTsKLQotCWxlbiA9 IHN0cmxlbihuYW1lKSArIDEgKyBzdHJsZW4od2F0Y2gtPnRva2VuKSArIDE7 Ci0JLyogRG9uJ3QgdHJ5IHRvIHNlbmQgb3Zlci1sb25nIGV2ZW50cy4gKi8K LQlpZiAobGVuID4gWEVOU1RPUkVfUEFZTE9BRF9NQVgpCi0JCXJldHVybjsK LQotCWRhdGEgPSB0YWxsb2NfYXJyYXkoY3R4LCBjaGFyLCBsZW4pOwotCWlm ICghZGF0YSkKLQkJcmV0dXJuOwotCXN0cmNweShkYXRhLCBuYW1lKTsKLQlz dHJjcHkoZGF0YSArIHN0cmxlbihuYW1lKSArIDEsIHdhdGNoLT50b2tlbik7 Ci0Jc2VuZF9yZXBseShjb25uLCBYU19XQVRDSF9FVkVOVCwgZGF0YSwgbGVu KTsKLQl0YWxsb2NfZnJlZShkYXRhKTsKLX0KLQotLyoKICAqIENoZWNrIHBl cm1pc3Npb25zIG9mIGEgc3BlY2lmaWMgd2F0Y2ggdG8gZmlyZToKICAqIEVp dGhlciB0aGUgbm9kZSBpdHNlbGYgb3IgaXRzIHBhcmVudCBoYXZlIHRvIGJl IHJlYWRhYmxlIGJ5IHRoZSBjb25uZWN0aW9uCiAgKiB0aGUgd2F0Y2ggaGFz IGJlZW4gc2V0dXAgZm9yLiBJbiBjYXNlIGEgd2F0Y2ggZXZlbnQgaXMgY3Jl YXRlZCBkdWUgdG8KQEAgLTE5MCwxMCArMTYxLDE0IEBAIHZvaWQgZmlyZV93 YXRjaGVzKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpj dHgsIGNvbnN0IGNoYXIgKm5hbWUsCiAJCWxpc3RfZm9yX2VhY2hfZW50cnko d2F0Y2gsICZpLT53YXRjaGVzLCBsaXN0KSB7CiAJCQlpZiAoZXhhY3QpIHsK IAkJCQlpZiAoc3RyZXEobmFtZSwgd2F0Y2gtPm5vZGUpKQotCQkJCQlhZGRf ZXZlbnQoaSwgY3R4LCB3YXRjaCwgbmFtZSk7CisJCQkJCXNlbmRfZXZlbnQo aSwKKwkJCQkJCSAgIGdldF93YXRjaF9wYXRoKHdhdGNoLCBuYW1lKSwKKwkJ CQkJCSAgIHdhdGNoLT50b2tlbik7CiAJCQl9IGVsc2UgewogCQkJCWlmIChp c19jaGlsZChuYW1lLCB3YXRjaC0+bm9kZSkpCi0JCQkJCWFkZF9ldmVudChp LCBjdHgsIHdhdGNoLCBuYW1lKTsKKwkJCQkJc2VuZF9ldmVudChpLAorCQkJ CQkJICAgZ2V0X3dhdGNoX3BhdGgod2F0Y2gsIG5hbWUpLAorCQkJCQkJICAg d2F0Y2gtPnRva2VuKTsKIAkJCX0KIAkJfQogCX0KQEAgLTI5Miw3ICsyNjcs NyBAQCBpbnQgZG9fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlzZW5kX2Fjayhjb25uLCBYU19X QVRDSCk7CiAKIAkvKiBXZSBmaXJlIG9uY2UgdXAgZnJvbnQ6IHNpbXBsaWZp ZXMgY2xpZW50cyBhbmQgcmVzdGFydC4gKi8KLQlhZGRfZXZlbnQoY29ubiwg aW4sIHdhdGNoLCB3YXRjaC0+bm9kZSk7CisJc2VuZF9ldmVudChjb25uLCBn ZXRfd2F0Y2hfcGF0aCh3YXRjaCwgd2F0Y2gtPm5vZGUpLCB3YXRjaC0+dG9r ZW4pOwogCiAJcmV0dXJuIDA7CiB9Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-02.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-02.patch" Content-Transfer-Encoding: base64 RnJvbSAwYTRjODZmOGE4ZmViZDg1NjEwNDk2NDcwMTIzYWRmYzRmYmMxYzVk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBoZWxw ZXJzIHRvIGZyZWUgc3RydWN0IGJ1ZmZlcmVkX2RhdGEKCkFkZCB0d28gaGVs cGVycyBmb3IgZnJlZWluZyBzdHJ1Y3QgYnVmZmVyZWRfZGF0YTogZnJlZV9i dWZmZXJlZF9kYXRhKCkKZm9yIGZyZWVpbmcgb25lIGluc3RhbmNlIGFuZCBj b25uX2ZyZWVfYnVmZmVyZWRfZGF0YSgpIGZvciBmcmVlaW5nIGFsbAppbnN0 YW5jZXMgZm9yIGEgY29ubmVjdGlvbi4KClRoaXMgaXMgYXZvaWRpbmcgZHVw bGljYXRlZCBjb2RlIGFuZCB3aWxsIGhlbHAgbGF0ZXIgd2hlbiBtb3JlIGFj dGlvbnMKYXJlIG5lZWRlZCB3aGVuIGZyZWVpbmcgYSBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQt Ynk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1v ZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3 ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggMjQ5YWQ1ZWM2 ZmIxLi41MjdhMWViZGVkZWQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYwpAQCAtMjExLDYgKzIxMSwyMSBAQCB2b2lkIHJlb3Blbl9s b2codm9pZCkKIAl9CiB9CiAKK3N0YXRpYyB2b2lkIGZyZWVfYnVmZmVyZWRf ZGF0YShzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqb3V0LAorCQkJICAgICAgIHN0 cnVjdCBjb25uZWN0aW9uICpjb25uKQoreworCWxpc3RfZGVsKCZvdXQtPmxp c3QpOworCXRhbGxvY19mcmVlKG91dCk7Cit9CisKK3ZvaWQgY29ubl9mcmVl X2J1ZmZlcmVkX2RhdGEoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCit7CisJ c3RydWN0IGJ1ZmZlcmVkX2RhdGEgKm91dDsKKworCXdoaWxlICgob3V0ID0g bGlzdF90b3AoJmNvbm4tPm91dF9saXN0LCBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSwgbGlzdCkpKQorCQlmcmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBjb25uKTsK K30KKwogc3RhdGljIGJvb2wgd3JpdGVfbWVzc2FnZXMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pCiB7CiAJaW50IHJldDsKQEAgLTI1NCw4ICsyNjksNyBA QCBzdGF0aWMgYm9vbCB3cml0ZV9tZXNzYWdlcyhzdHJ1Y3QgY29ubmVjdGlv biAqY29ubikKIAogCXRyYWNlX2lvKGNvbm4sIG91dCwgMSk7CiAKLQlsaXN0 X2RlbCgmb3V0LT5saXN0KTsKLQl0YWxsb2NfZnJlZShvdXQpOworCWZyZWVf YnVmZmVyZWRfZGF0YShvdXQsIGNvbm4pOwogCiAJcmV0dXJuIHRydWU7CiB9 CkBAIC0xNTA2LDE4ICsxNTIwLDEyIEBAIHN0YXRpYyBzdHJ1Y3QgewogICov CiB2b2lkIGlnbm9yZV9jb25uZWN0aW9uKHN0cnVjdCBjb25uZWN0aW9uICpj b25uKQogewotCXN0cnVjdCBidWZmZXJlZF9kYXRhICpvdXQsICp0bXA7Ci0K IAl0cmFjZSgiQ09OTiAlcCBpZ25vcmVkXG4iLCBjb25uKTsKIAogCWNvbm4t PmlzX2lnbm9yZWQgPSB0cnVlOwogCWNvbm5fZGVsZXRlX2FsbF93YXRjaGVz KGNvbm4pOwogCWNvbm5fZGVsZXRlX2FsbF90cmFuc2FjdGlvbnMoY29ubik7 Ci0KLQlsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUob3V0LCB0bXAsICZjb25u LT5vdXRfbGlzdCwgbGlzdCkgewotCQlsaXN0X2RlbCgmb3V0LT5saXN0KTsK LQkJdGFsbG9jX2ZyZWUob3V0KTsKLQl9CisJY29ubl9mcmVlX2J1ZmZlcmVk X2RhdGEoY29ubik7CiAKIAl0YWxsb2NfZnJlZShjb25uLT5pbik7CiAJY29u bi0+aW4gPSBOVUxMOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmgKaW5kZXggOWFmOWFmNDM5MGJkLi5lN2VlODc4MjVjM2IgMTAwNjQ0Ci0t LSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKKysrIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMjc2LDYgKzI3Niw4 IEBAIGludCByZW1lbWJlcl9zdHJpbmcoc3RydWN0IGhhc2h0YWJsZSAqaGFz aCwgY29uc3QgY2hhciAqc3RyKTsKIAogdm9pZCBzZXRfdGRiX2tleShjb25z dCBjaGFyICpuYW1lLCBUREJfREFUQSAqa2V5KTsKIAordm9pZCBjb25uX2Zy ZWVfYnVmZmVyZWRfZGF0YShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7CisK IGNvbnN0IGNoYXIgKmR1bXBfc3RhdGVfZ2xvYmFsKEZJTEUgKmZwKTsKIGNv bnN0IGNoYXIgKmR1bXBfc3RhdGVfYnVmZmVyZWRfZGF0YShGSUxFICpmcCwg Y29uc3Qgc3RydWN0IGNvbm5lY3Rpb24gKmMsCiAJCQkJICAgICBzdHJ1Y3Qg eHNfc3RhdGVfY29ubmVjdGlvbiAqc2MpOwpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IGQwM2M3ZDkzYTllNy4uOTNjNGMx ZWRjZGQxIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFp bi5jCkBAIC00MTEsMTUgKzQxMSwxMCBAQCBzdGF0aWMgc3RydWN0IGRvbWFp biAqZmluZF9kb21haW5fYnlfZG9taWQodW5zaWduZWQgaW50IGRvbWlkKQog c3RhdGljIHZvaWQgZG9tYWluX2Nvbm5fcmVzZXQoc3RydWN0IGRvbWFpbiAq ZG9tYWluKQogewogCXN0cnVjdCBjb25uZWN0aW9uICpjb25uID0gZG9tYWlu LT5jb25uOwotCXN0cnVjdCBidWZmZXJlZF9kYXRhICpvdXQ7CiAKIAljb25u X2RlbGV0ZV9hbGxfd2F0Y2hlcyhjb25uKTsKIAljb25uX2RlbGV0ZV9hbGxf dHJhbnNhY3Rpb25zKGNvbm4pOwotCi0Jd2hpbGUgKChvdXQgPSBsaXN0X3Rv cCgmY29ubi0+b3V0X2xpc3QsIHN0cnVjdCBidWZmZXJlZF9kYXRhLCBsaXN0 KSkpIHsKLQkJbGlzdF9kZWwoJm91dC0+bGlzdCk7Ci0JCXRhbGxvY19mcmVl KG91dCk7Ci0JfQorCWNvbm5fZnJlZV9idWZmZXJlZF9kYXRhKGNvbm4pOwog CiAJdGFsbG9jX2ZyZWUoY29ubi0+aW4pOwogCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-03.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-03.patch" Content-Transfer-Encoding: base64 RnJvbSBhNmM0MTk4MjQyYmY2OWJlYTE4MjU0OTJiNzY2NWI1NTkwMjMzOTBj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHJlZHVjZSBu dW1iZXIgb2Ygd2F0Y2ggZXZlbnRzCgpXaGVuIHJlbW92aW5nIGEgd2F0Y2hl ZCBub2RlIG91dHNpZGUgb2YgYSB0cmFuc2FjdGlvbiwgdHdvIHdhdGNoIGV2 ZW50cwphcmUgYmVpbmcgcHJvZHVjZWQgaW5zdGVhZCBvZiBqdXN0IGEgc2lu Z2xlIG9uZS4KCldoZW4gZmluYWxpemluZyBhIHRyYW5zYWN0aW9uIHdhdGNo IGV2ZW50cyBjYW4gYmUgZ2VuZXJhdGVkIGZvciBlYWNoCm5vZGUgd2hpY2gg aXMgYmVpbmcgbW9kaWZpZWQsIGV2ZW4gaWYgb3V0c2lkZSBhIHRyYW5zYWN0 aW9uIHN1Y2gKbW9kaWZpY2F0aW9ucyBtaWdodCBub3QgaGF2ZSByZXN1bHRl ZCBpbiBhIHdhdGNoIGV2ZW50LgoKVGhpcyBoYXBwZW5zIGUuZy46CgotIGZv ciBub2RlcyB3aGljaCBhcmUgb25seSBtb2RpZmllZCBkdWUgdG8gYWRkZWQv cmVtb3ZlZCBjaGlsZCBlbnRyaWVzCi0gZm9yIG5vZGVzIGJlaW5nIHJlbW92 ZWQgb3IgY3JlYXRlZCBpbXBsaWNpdGx5IChlLmcuIGNyZWF0aW9uIG9mIGEv Yi9jCiAgaXMgaW1wbGljaXRseSBjcmVhdGluZyBhL2IsIHJlc3VsdGluZyBp biB3YXRjaCBldmVudHMgZm9yIGEsIGEvYiBhbmQKICBhL2IvYyBpbnN0ZWFk IG9mIGEvYi9jIG9ubHkpCgpBdm9pZCB0aGVzZSBhZGRpdGlvbmFsIHdhdGNo IGV2ZW50cywgaW4gb3JkZXIgdG8gcmVkdWNlIHRoZSBuZWVkZWQKbWVtb3J5 IGluc2lkZSBYZW5zdG9yZSBmb3IgcXVldWVpbmcgdGhlbS4KClRoaXMgaXMg YmVpbmcgYWNoaWV2ZWQgYnkgYWRkaW5nIGV2ZW50IGZsYWdzIHRvIHN0cnVj dCBhY2Nlc3NlZF9ub2RlCnNwZWNpZnlpbmcgd2hldGhlciBhbiBldmVudCBz aG91bGQgYmUgdHJpZ2dlcmVkLCBhbmQgd2hldGhlciBpdCBzaG91bGQKYmUg YW4gZXhhY3QgbWF0Y2ggb2YgdGhlIG1vZGlmaWVkIHBhdGguIEJvdGggZmxh Z3MgY2FuIGJlIHNldCBmcm9tCmZpcmVfd2F0Y2hlcygpIGluc3RlYWQgb2Yg aW1wbHlpbmcgdGhlbSBvbmx5LgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYu CgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNv bT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwppbmRl eCA1MjdhMWViZGVkZWQuLmJmMjI0Mzg3MzkwMSAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0xMjk1LDcgKzEyOTUsNyBAQCBz dGF0aWMgdm9pZCBkZWxldGVfY2hpbGQoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sCiB9CiAKIHN0YXRpYyBpbnQgZGVsZXRlX25vZGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKLQkJICAgICAgIHN0cnVj dCBub2RlICpwYXJlbnQsIHN0cnVjdCBub2RlICpub2RlKQorCQkgICAgICAg c3RydWN0IG5vZGUgKnBhcmVudCwgc3RydWN0IG5vZGUgKm5vZGUsIGJvb2wg d2F0Y2hfZXhhY3QpCiB7CiAJY2hhciAqbmFtZTsKIApAQCAtMTMwNyw3ICsx MzA3LDcgQEAgc3RhdGljIGludCBkZWxldGVfbm9kZShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCQkJCSAgICAgICBub2Rl LT5jaGlsZHJlbik7CiAJCWNoaWxkID0gbmFtZSA/IHJlYWRfbm9kZShjb25u LCBub2RlLCBuYW1lKSA6IE5VTEw7CiAJCWlmIChjaGlsZCkgewotCQkJaWYg KGRlbGV0ZV9ub2RlKGNvbm4sIGN0eCwgbm9kZSwgY2hpbGQpKQorCQkJaWYg KGRlbGV0ZV9ub2RlKGNvbm4sIGN0eCwgbm9kZSwgY2hpbGQsIHRydWUpKQog CQkJCXJldHVybiBlcnJubzsKIAkJfSBlbHNlIHsKIAkJCXRyYWNlKCJkZWxl dGVfbm9kZTogRXJyb3IgZGVsZXRpbmcgY2hpbGQgJyVzLyVzJyFcbiIsCkBA IC0xMzE5LDcgKzEzMTksMTIgQEAgc3RhdGljIGludCBkZWxldGVfbm9kZShz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCQl0 YWxsb2NfZnJlZShuYW1lKTsKIAl9CiAKLQlmaXJlX3dhdGNoZXMoY29ubiwg Y3R4LCBub2RlLT5uYW1lLCBub2RlLCB0cnVlLCBOVUxMKTsKKwkvKgorCSAq IEZpcmUgdGhlIHdhdGNoZXMgbm93LCB3aGVuIHdlIGNhbiBzdGlsbCBzZWUg dGhlIG5vZGUgcGVybWlzc2lvbnMuCisJICogVGhpcyBmaW5lIGFzIHdlIGFy ZSBzaW5nbGUgdGhyZWFkZWQgYW5kIHRoZSBuZXh0IHBvc3NpYmxlIHJlYWQg d2lsbAorCSAqIGJlIGhhbmRsZWQgb25seSBhZnRlciB0aGUgbm9kZSBoYXMg YmVlbiByZWFsbHkgcmVtb3ZlZC4KKwkgKi8KKwlmaXJlX3dhdGNoZXMoY29u biwgY3R4LCBub2RlLT5uYW1lLCBub2RlLCB3YXRjaF9leGFjdCwgTlVMTCk7 CiAJZGVsZXRlX25vZGVfc2luZ2xlKGNvbm4sIG5vZGUpOwogCWRlbGV0ZV9j aGlsZChjb25uLCBwYXJlbnQsIGJhc2VuYW1lKG5vZGUtPm5hbWUpKTsKIAl0 YWxsb2NfZnJlZShub2RlKTsKQEAgLTEzNDUsMTMgKzEzNTAsNyBAQCBzdGF0 aWMgaW50IF9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9p ZCAqY3R4LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIAkJcmV0dXJuIChlcnJubyA9 PSBFTk9NRU0pID8gRU5PTUVNIDogRUlOVkFMOwogCW5vZGUtPnBhcmVudCA9 IHBhcmVudDsKIAotCS8qCi0JICogRmlyZSB0aGUgd2F0Y2hlcyBub3csIHdo ZW4gd2UgY2FuIHN0aWxsIHNlZSB0aGUgbm9kZSBwZXJtaXNzaW9ucy4KLQkg KiBUaGlzIGZpbmUgYXMgd2UgYXJlIHNpbmdsZSB0aHJlYWRlZCBhbmQgdGhl IG5leHQgcG9zc2libGUgcmVhZCB3aWxsCi0JICogYmUgaGFuZGxlZCBvbmx5 IGFmdGVyIHRoZSBub2RlIGhhcyBiZWVuIHJlYWxseSByZW1vdmVkLgotCSAq LwotCWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5hbWUsIG5vZGUsIGZhbHNl LCBOVUxMKTsKLQlyZXR1cm4gZGVsZXRlX25vZGUoY29ubiwgY3R4LCBwYXJl bnQsIG5vZGUpOworCXJldHVybiBkZWxldGVfbm9kZShjb25uLCBjdHgsIHBh cmVudCwgbm9kZSwgZmFsc2UpOwogfQogCiAKZGlmZiAtLWdpdCBhL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKaW5kZXggZmFmNmM5MzBl NDJhLi41NDQzMjkwN2ZjNzYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCisrKyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCkBAIC0xMzAsNiArMTMwLDEwIEBA IHN0cnVjdCBhY2Nlc3NlZF9ub2RlCiAKIAkvKiBUcmFuc2FjdGlvbiBub2Rl IGluIGRhdGEgYmFzZT8gKi8KIAlib29sIHRhX25vZGU7CisKKwkvKiBXYXRj aCBldmVudCBmbGFncy4gKi8KKwlib29sIGZpcmVfd2F0Y2g7CisJYm9vbCB3 YXRjaF9leGFjdDsKIH07CiAKIHN0cnVjdCBjaGFuZ2VkX2RvbWFpbgpAQCAt MzI0LDYgKzMyOCwyOSBAQCBpbnQgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAogfQogCiAvKgorICog QSB3YXRjaCBldmVudCBzaG91bGQgYmUgZmlyZWQgZm9yIGEgbm9kZSBtb2Rp ZmllZCBpbnNpZGUgYSB0cmFuc2FjdGlvbi4KKyAqIFNldCB0aGUgY29ycmVz cG9uZGluZyBpbmZvcm1hdGlvbi4gQSBub24tZXhhY3QgZXZlbnQgaXMgcmVw bGFjaW5nIGFuIGV4YWN0CisgKiBvbmUsIGJ1dCBub3QgdGhlIG90aGVyIHdh eSByb3VuZC4KKyAqLwordm9pZCBxdWV1ZV93YXRjaGVzKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpuYW1lLCBib29sIHdhdGNoX2V4 YWN0KQoreworCXN0cnVjdCBhY2Nlc3NlZF9ub2RlICppOworCisJaSA9IGZp bmRfYWNjZXNzZWRfbm9kZShjb25uLT50cmFuc2FjdGlvbiwgbmFtZSk7CisJ aWYgKCFpKSB7CisJCWNvbm4tPnRyYW5zYWN0aW9uLT5mYWlsID0gdHJ1ZTsK KwkJcmV0dXJuOworCX0KKworCWlmICghaS0+ZmlyZV93YXRjaCkgeworCQlp LT5maXJlX3dhdGNoID0gdHJ1ZTsKKwkJaS0+d2F0Y2hfZXhhY3QgPSB3YXRj aF9leGFjdDsKKwl9IGVsc2UgaWYgKCF3YXRjaF9leGFjdCkgeworCQlpLT53 YXRjaF9leGFjdCA9IGZhbHNlOworCX0KK30KKworLyoKICAqIEZpbmFsaXpl IHRyYW5zYWN0aW9uOgogICogV2FsayB0aHJvdWdoIGFjY2Vzc2VkIG5vZGVz IGFuZCBjaGVjayBnZW5lcmF0aW9uIGFnYWluc3QgZ2xvYmFsIGRhdGEuCiAg KiBJZiBhbGwgZW50cmllcyBtYXRjaCwgcmVhZCB0aGUgdHJhbnNhY3Rpb24g ZW50cmllcyBhbmQgd3JpdGUgdGhlbSB3aXRob3V0CkBAIC0zNzcsMTUgKzQw NCwxNSBAQCBzdGF0aWMgaW50IGZpbmFsaXplX3RyYW5zYWN0aW9uKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAogCQkJCXJldCA9IHRkYl9zdG9yZSh0ZGJf Y3R4LCBrZXksIGRhdGEsCiAJCQkJCQlUREJfUkVQTEFDRSk7CiAJCQkJdGFs bG9jX2ZyZWUoZGF0YS5kcHRyKTsKLQkJCQlpZiAocmV0KQotCQkJCQlnb3Rv IGVycjsKLQkJCQlmaXJlX3dhdGNoZXMoY29ubiwgdHJhbnMsIGktPm5vZGUs IE5VTEwsIGZhbHNlLAotCQkJCQkgICAgIGktPnBlcm1zLnAgPyAmaS0+cGVy bXMgOiBOVUxMKTsKIAkJCX0gZWxzZSB7Ci0JCQkJZmlyZV93YXRjaGVzKGNv bm4sIHRyYW5zLCBpLT5ub2RlLCBOVUxMLCBmYWxzZSwKKwkJCQlyZXQgPSB0 ZGJfZGVsZXRlKHRkYl9jdHgsIGtleSk7CisJCQl9CisJCQlpZiAocmV0KQor CQkJCWdvdG8gZXJyOworCQkJaWYgKGktPmZpcmVfd2F0Y2gpIHsKKwkJCQlm aXJlX3dhdGNoZXMoY29ubiwgdHJhbnMsIGktPm5vZGUsIE5VTEwsCisJCQkJ CSAgICAgaS0+d2F0Y2hfZXhhY3QsCiAJCQkJCSAgICAgaS0+cGVybXMucCA/ ICZpLT5wZXJtcyA6IE5VTEwpOwotCQkJCWlmICh0ZGJfZGVsZXRlKHRkYl9j dHgsIGtleSkpCi0JCQkJCWdvdG8gZXJyOwogCQkJfQogCQl9CiAKZGlmZiAt LWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5o IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKaW5k ZXggMTQwNjI3MzBlM2M5Li4wMDkzY2FjODA3ZTMgMTAwNjQ0Ci0tLSBhL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCisrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCkBAIC00Miw2 ICs0Miw5IEBAIHZvaWQgdHJhbnNhY3Rpb25fZW50cnlfZGVjKHN0cnVjdCB0 cmFuc2FjdGlvbiAqdHJhbnMsIHVuc2lnbmVkIGludCBkb21pZCk7CiBpbnQg YWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlLAogICAgICAgICAgICAgICAgIGVudW0gbm9kZV9hY2Nlc3Nf dHlwZSB0eXBlLCBUREJfREFUQSAqa2V5KTsKIAorLyogUXVldWUgd2F0Y2hl cyBmb3IgYSBtb2RpZmllZCBub2RlLiAqLwordm9pZCBxdWV1ZV93YXRjaGVz KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpuYW1lLCBi b29sIHdhdGNoX2V4YWN0KTsKKwogLyogUHJlcGVuZCB0aGUgdHJhbnNhY3Rp b24gdG8gbmFtZSBpZiBhcHByb3ByaWF0ZS4gKi8KIGludCB0cmFuc2FjdGlv bl9wcmVwZW5kKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFy ICpuYW1lLAogICAgICAgICAgICAgICAgICAgICAgICAgVERCX0RBVEEgKmtl eSk7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0 Y2guYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCmluZGV4 IDk5YTJjMjY2YjI4YS4uMjA1ZDlkOGVhMTE2IDEwMDY0NAotLS0gYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfd2F0Y2guYwpAQCAtMjksNiArMjksNyBAQAogI2lu Y2x1ZGUgInhlbnN0b3JlX2xpYi5oIgogI2luY2x1ZGUgInV0aWxzLmgiCiAj aW5jbHVkZSAieGVuc3RvcmVkX2RvbWFpbi5oIgorI2luY2x1ZGUgInhlbnN0 b3JlZF90cmFuc2FjdGlvbi5oIgogCiBleHRlcm4gaW50IHF1b3RhX25iX3dh dGNoX3Blcl9kb21haW47CiAKQEAgLTE0Myw5ICsxNDQsMTEgQEAgdm9pZCBm aXJlX3dhdGNoZXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZv aWQgKmN0eCwgY29uc3QgY2hhciAqbmFtZSwKIAlzdHJ1Y3QgY29ubmVjdGlv biAqaTsKIAlzdHJ1Y3Qgd2F0Y2ggKndhdGNoOwogCi0JLyogRHVyaW5nIHRy YW5zYWN0aW9ucywgZG9uJ3QgZmlyZSB3YXRjaGVzLiAqLwotCWlmIChjb25u ICYmIGNvbm4tPnRyYW5zYWN0aW9uKQorCS8qIER1cmluZyB0cmFuc2FjdGlv bnMsIGRvbid0IGZpcmUgd2F0Y2hlcywgYnV0IHF1ZXVlIHRoZW0uICovCisJ aWYgKGNvbm4gJiYgY29ubi0+dHJhbnNhY3Rpb24pIHsKKwkJcXVldWVfd2F0 Y2hlcyhjb25uLCBuYW1lLCBleGFjdCk7CiAJCXJldHVybjsKKwl9CiAKIAkv KiBDcmVhdGUgYW4gZXZlbnQgZm9yIGVhY2ggd2F0Y2guICovCiAJbGlzdF9m b3JfZWFjaF9lbnRyeShpLCAmY29ubmVjdGlvbnMsIGxpc3QpIHsK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-04.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-04.patch" Content-Transfer-Encoding: base64 RnJvbSAyZmVlZDczNzUzMDU5MjY4ODM4MmM2NTU2ODA5ODJlMTA5NTFjMWVj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxldCB1bnJl YWQgd2F0Y2ggZXZlbnRzIHRpbWUgb3V0CgpBIGZ1dHVyZSBtb2RpZmljYXRp b24gd2lsbCBsaW1pdCB0aGUgbnVtYmVyIG9mIG91dHN0YW5kaW5nIHJlcXVl c3RzCmZvciBhIGRvbWFpbiwgd2hlcmUgIm91dHN0YW5kaW5nIiBtZWFucyB0 aGF0IHRoZSByZXNwb25zZSBvZiB0aGUKcmVxdWVzdCBvciBhbnkgcmVzdWx0 aW5nIHdhdGNoIGV2ZW50IGhhc24ndCBiZWVuIGNvbnN1bWVkIHlldC4KCklu IG9yZGVyIHRvIGF2b2lkIGEgbWFsaWNpb3VzIGd1ZXN0IGJlaW5nIGNhcGFi bGUgdG8gYmxvY2sgb3RoZXIgZ3Vlc3RzCmJ5IG5vdCByZWFkaW5nIHdhdGNo IGV2ZW50cywgYWRkIGEgdGltZW91dCBmb3Igd2F0Y2ggZXZlbnRzLiBJbiBj YXNlIGEKd2F0Y2ggZXZlbnQgaGFzbid0IGJlZW4gY29uc3VtZWQgYWZ0ZXIg dGhpcyB0aW1lb3V0LCBpdCBpcyBiZWluZwpkZWxldGVkLiBTZXQgdGhlIGRl ZmF1bHQgdGltZW91dCB0byAyMCBzZWNvbmRzIChhIHJhbmRvbSB2YWx1ZSBi ZWluZwpub3QgdG9vIGhpZ2gpLgoKSW4gb3JkZXIgdG8gc3VwcG9ydCB0byBz cGVjaWZ5IG90aGVyIHRpbWVvdXQgdmFsdWVzIGluIGZ1dHVyZSwgdXNlIGEK Z2VuZXJpYyBjb21tYW5kIGxpbmUgb3B0aW9uIGZvciB0aGF0IHB1cnBvc2U6 CgotLXRpbWVvdXR8LXcgd2F0Y2gtZXZlbnQ9PHNlY29uZHM+CgpUaGlzIGlz IHBhcnQgb2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzExLgoKUmVwb3J0ZWQt Ynk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1v ZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3 ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggYmYyMjQzODcz OTAxLi40NTI0NGMwMjFjZDMgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYwpAQCAtMTA4LDYgKzEwOCw4IEBAIGludCBxdW90YV9tYXhf dHJhbnNhY3Rpb24gPSAxMDsKIGludCBxdW90YV9uYl9wZXJtc19wZXJfbm9k ZSA9IDU7CiBpbnQgcXVvdGFfbWF4X3BhdGhfbGVuID0gWEVOU1RPUkVfUkVM X1BBVEhfTUFYOwogCit1bnNpZ25lZCBpbnQgdGltZW91dF93YXRjaF9ldmVu dF9tc2VjID0gMjAwMDA7CisKIHZvaWQgdHJhY2UoY29uc3QgY2hhciAqZm10 LCAuLi4pCiB7CiAJdmFfbGlzdCBhcmdsaXN0OwpAQCAtMjExLDE5ICsyMTMs OTIgQEAgdm9pZCByZW9wZW5fbG9nKHZvaWQpCiAJfQogfQogCitzdGF0aWMg dWludDY0X3QgZ2V0X25vd19tc2VjKHZvaWQpCit7CisJc3RydWN0IHRpbWVz cGVjIG5vd190czsKKworCWlmIChjbG9ja19nZXR0aW1lKENMT0NLX01PTk9U T05JQywgJm5vd190cykpCisJCWJhcmZfcGVycm9yKCJDb3VsZCBub3QgZmlu ZCB0aW1lIChjbG9ja19nZXR0aW1lIGZhaWxlZCkiKTsKKworCXJldHVybiBu b3dfdHMudHZfc2VjICogMTAwMCArIG5vd190cy50dl9uc2VjIC8gMTAwMDAw MDsKK30KKwogc3RhdGljIHZvaWQgZnJlZV9idWZmZXJlZF9kYXRhKHN0cnVj dCBidWZmZXJlZF9kYXRhICpvdXQsCiAJCQkgICAgICAgc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pCiB7CisJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKnJlcTsK KwogCWxpc3RfZGVsKCZvdXQtPmxpc3QpOworCisJLyoKKwkgKiBVcGRhdGUg Y29ubi0+dGltZW91dF9tc2VjIHdpdGggdGhlIG5leHQgZm91bmQgdGltZW91 dCB2YWx1ZSBpbiB0aGUKKwkgKiBxdWV1ZWQgcGVuZGluZyByZXF1ZXN0cy4K KwkgKi8KKwlpZiAob3V0LT50aW1lb3V0X21zZWMpIHsKKwkJY29ubi0+dGlt ZW91dF9tc2VjID0gMDsKKwkJbGlzdF9mb3JfZWFjaF9lbnRyeShyZXEsICZj b25uLT5vdXRfbGlzdCwgbGlzdCkgeworCQkJaWYgKHJlcS0+dGltZW91dF9t c2VjKSB7CisJCQkJY29ubi0+dGltZW91dF9tc2VjID0gcmVxLT50aW1lb3V0 X21zZWM7CisJCQkJYnJlYWs7CisJCQl9CisJCX0KKwl9CisKIAl0YWxsb2Nf ZnJlZShvdXQpOwogfQogCitzdGF0aWMgdm9pZCBjaGVja19ldmVudF90aW1l b3V0KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCB1aW50NjRfdCBtc2VjcywK KwkJCQlpbnQgKnB0aW1lb3V0KQoreworCXVpbnQ2NF90IGRlbHRhOworCXN0 cnVjdCBidWZmZXJlZF9kYXRhICpvdXQsICp0bXA7CisKKwlpZiAoIWNvbm4t PnRpbWVvdXRfbXNlYykKKwkJcmV0dXJuOworCisJZGVsdGEgPSBjb25uLT50 aW1lb3V0X21zZWMgLSBtc2VjczsKKwlpZiAoY29ubi0+dGltZW91dF9tc2Vj IDw9IG1zZWNzKSB7CisJCWRlbHRhID0gMDsKKwkJbGlzdF9mb3JfZWFjaF9l bnRyeV9zYWZlKG91dCwgdG1wLCAmY29ubi0+b3V0X2xpc3QsIGxpc3QpIHsK KwkJCS8qCisJCQkgKiBPbmx5IGxvb2sgYXQgYnVmZmVycyB3aXRoIHRpbWVv dXQgYW5kIG5vIGRhdGEKKwkJCSAqIGFscmVhZHkgd3JpdHRlbiB0byB0aGUg cmluZy4KKwkJCSAqLworCQkJaWYgKG91dC0+dGltZW91dF9tc2VjICYmIG91 dC0+aW5oZHIgJiYgIW91dC0+dXNlZCkgeworCQkJCWlmIChvdXQtPnRpbWVv dXRfbXNlYyA+IG1zZWNzKSB7CisJCQkJCWNvbm4tPnRpbWVvdXRfbXNlYyA9 IG91dC0+dGltZW91dF9tc2VjOworCQkJCQlkZWx0YSA9IGNvbm4tPnRpbWVv dXRfbXNlYyAtIG1zZWNzOworCQkJCQlicmVhazsKKwkJCQl9CisKKwkJCQkv KgorCQkJCSAqIEZyZWUgb3V0IHdpdGhvdXQgdXBkYXRpbmcgY29ubi0+dGlt ZW91dF9tc2VjLAorCQkJCSAqIGFzIHRoZSB1cGRhdGUgaXMgZG9uZSBpbiB0 aGlzIGxvb3AgYWxyZWFkeS4KKwkJCQkgKi8KKwkJCQlvdXQtPnRpbWVvdXRf bXNlYyA9IDA7CisJCQkJdHJhY2UoIndhdGNoIGV2ZW50IHBhdGggJXMgZm9y IGRvbWFpbiAldSB0aW1lZCBvdXRcbiIsCisJCQkJICAgICAgb3V0LT5idWZm ZXIsIGNvbm4tPmlkKTsKKwkJCQlmcmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBj b25uKTsKKwkJCX0KKwkJfQorCQlpZiAoIWRlbHRhKSB7CisJCQljb25uLT50 aW1lb3V0X21zZWMgPSAwOworCQkJcmV0dXJuOworCQl9CisJfQorCisJaWYg KCpwdGltZW91dCA9PSAtMSB8fCAqcHRpbWVvdXQgPiBkZWx0YSkKKwkJKnB0 aW1lb3V0ID0gZGVsdGE7Cit9CisKIHZvaWQgY29ubl9mcmVlX2J1ZmZlcmVk X2RhdGEoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCiB7CiAJc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKm91dDsKIAogCXdoaWxlICgob3V0ID0gbGlzdF90b3Ao JmNvbm4tPm91dF9saXN0LCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSwgbGlzdCkp KQogCQlmcmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBjb25uKTsKKworCWNvbm4t PnRpbWVvdXRfbXNlYyA9IDA7CiB9CiAKIHN0YXRpYyBib29sIHdyaXRlX21l c3NhZ2VzKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQpAQCAtNDExLDYgKzQ4 Niw3IEBAIHN0YXRpYyB2b2lkIGluaXRpYWxpemVfZmRzKGludCAqcF9zb2Nr X3BvbGxmZF9pZHgsIGludCAqcHRpbWVvdXQpCiB7CiAJc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm47CiAJc3RydWN0IHdybF90aW1lc3RhbXB0IG5vdzsKKwl1 aW50NjRfdCBtc2VjczsKIAogCWlmIChmZHMpCiAJCW1lbXNldChmZHMsIDAs IHNpemVvZihzdHJ1Y3QgcG9sbGZkKSAqIGN1cnJlbnRfYXJyYXlfc2l6ZSk7 CkBAIC00MzEsMTAgKzUwNywxMiBAQCBzdGF0aWMgdm9pZCBpbml0aWFsaXpl X2ZkcyhpbnQgKnBfc29ja19wb2xsZmRfaWR4LCBpbnQgKnB0aW1lb3V0KQog CiAJd3JsX2dldHRpbWVfbm93KCZub3cpOwogCXdybF9sb2dfcGVyaW9kaWMo bm93KTsKKwltc2VjcyA9IGdldF9ub3dfbXNlYygpOwogCiAJbGlzdF9mb3Jf ZWFjaF9lbnRyeShjb25uLCAmY29ubmVjdGlvbnMsIGxpc3QpIHsKIAkJaWYg KGNvbm4tPmRvbWFpbikgewogCQkJd3JsX2NoZWNrX3RpbWVvdXQoY29ubi0+ ZG9tYWluLCBub3csIHB0aW1lb3V0KTsKKwkJCWNoZWNrX2V2ZW50X3RpbWVv dXQoY29ubiwgbXNlY3MsIHB0aW1lb3V0KTsKIAkJCWlmIChjb25uX2Nhbl9y ZWFkKGNvbm4pIHx8CiAJCQkgICAgKGNvbm5fY2FuX3dyaXRlKGNvbm4pICYm CiAJCQkgICAgICFsaXN0X2VtcHR5KCZjb25uLT5vdXRfbGlzdCkpKQpAQCAt Nzk0LDYgKzg3Miw3IEBAIHZvaWQgc2VuZF9yZXBseShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgZW51bSB4c2Rfc29ja21zZ190eXBlIHR5cGUsCiAJCXJl dHVybjsKIAliZGF0YS0+aW5oZHIgPSB0cnVlOwogCWJkYXRhLT51c2VkID0g MDsKKwliZGF0YS0+dGltZW91dF9tc2VjID0gMDsKIAogCWlmIChsZW4gPD0g REVGQVVMVF9CVUZGRVJfU0laRSkKIAkJYmRhdGEtPmJ1ZmZlciA9IGJkYXRh LT5kZWZhdWx0X2J1ZmZlcjsKQEAgLTg0NSw2ICs5MjQsMTIgQEAgdm9pZCBz ZW5kX2V2ZW50KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFy ICpwYXRoLCBjb25zdCBjaGFyICp0b2tlbikKIAliZGF0YS0+aGRyLm1zZy50 eXBlID0gWFNfV0FUQ0hfRVZFTlQ7CiAJYmRhdGEtPmhkci5tc2cubGVuID0g bGVuOwogCisJaWYgKHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyAmJiBkb21h aW5faXNfdW5wcml2aWxlZ2VkKGNvbm4pKSB7CisJCWJkYXRhLT50aW1lb3V0 X21zZWMgPSBnZXRfbm93X21zZWMoKSArIHRpbWVvdXRfd2F0Y2hfZXZlbnRf bXNlYzsKKwkJaWYgKCFjb25uLT50aW1lb3V0X21zZWMpCisJCQljb25uLT50 aW1lb3V0X21zZWMgPSBiZGF0YS0+dGltZW91dF9tc2VjOworCX0KKwogCS8q IFF1ZXVlIGZvciBsYXRlciB0cmFuc21pc3Npb24uICovCiAJbGlzdF9hZGRf dGFpbCgmYmRhdGEtPmxpc3QsICZjb25uLT5vdXRfbGlzdCk7CiB9CkBAIC0y MjAxLDYgKzIyODYsOSBAQCBzdGF0aWMgdm9pZCB1c2FnZSh2b2lkKQogIiAg LXQsIC0tdHJhbnNhY3Rpb24gPG5iPiAgbGltaXQgdGhlIG51bWJlciBvZiB0 cmFuc2FjdGlvbiBhbGxvd2VkIHBlciBkb21haW4sXG4iCiAiICAtQSwgLS1w ZXJtLW5iIDxuYj4gICAgICBsaW1pdCB0aGUgbnVtYmVyIG9mIHBlcm1pc3Np b25zIHBlciBub2RlLFxuIgogIiAgLU0sIC0tcGF0aC1tYXggPGNoYXJzPiAg bGltaXQgdGhlIGFsbG93ZWQgWGVuc3RvcmUgbm9kZSBwYXRoIGxlbmd0aCxc biIKKyIgIC13LCAtLXRpbWVvdXQgPHdoYXQ+PTxzZWNvbmRzPiAgIHNldCB0 aGUgdGltZW91dCBpbiBzZWNvbmRzIGZvciA8d2hhdD4sXG4iCisiICAgICAg ICAgICAgICAgICAgICAgICAgICBhbGxvd2VkIHRpbWVvdXQgY2FuZGlkYXRl cyBhcmU6XG4iCisiICAgICAgICAgICAgICAgICAgICAgICAgICB3YXRjaC1l dmVudDogdGltZSBhIHdhdGNoLWV2ZW50IGlzIGtlcHQgcGVuZGluZ1xuIgog IiAgLVIsIC0tbm8tcmVjb3ZlcnkgICAgICAgdG8gcmVxdWVzdCB0aGF0IG5v IHJlY292ZXJ5IHNob3VsZCBiZSBhdHRlbXB0ZWQgd2hlblxuIgogIiAgICAg ICAgICAgICAgICAgICAgICAgICAgdGhlIHN0b3JlIGlzIGNvcnJ1cHRlZCAo ZGVidWcgb25seSksXG4iCiAiICAtSSwgLS1pbnRlcm5hbC1kYiAgICAgICBz dG9yZSBkYXRhYmFzZSBpbiBtZW1vcnksIG5vdCBvbiBkaXNrXG4iCkBAIC0y MjIzLDYgKzIzMTEsNyBAQCBzdGF0aWMgc3RydWN0IG9wdGlvbiBvcHRpb25z W10gPSB7CiAJeyAidHJhbnNhY3Rpb24iLCAxLCBOVUxMLCAndCcgfSwKIAl7 ICJwZXJtLW5iIiwgMSwgTlVMTCwgJ0EnIH0sCiAJeyAicGF0aC1tYXgiLCAx LCBOVUxMLCAnTScgfSwKKwl7ICJ0aW1lb3V0IiwgMSwgTlVMTCwgJ3cnIH0s CiAJeyAibm8tcmVjb3ZlcnkiLCAwLCBOVUxMLCAnUicgfSwKIAl7ICJpbnRl cm5hbC1kYiIsIDAsIE5VTEwsICdJJyB9LAogCXsgInZlcmJvc2UiLCAwLCBO VUxMLCAnVicgfSwKQEAgLTIyMzYsNiArMjMyNSwzOSBAQCBpbnQgZG9tMF9k b21pZCA9IDA7CiBpbnQgZG9tMF9ldmVudCA9IDA7CiBpbnQgcHJpdl9kb21p ZCA9IDA7CiAKK3N0YXRpYyBpbnQgZ2V0X29wdHZhbF9pbnQoY29uc3QgY2hh ciAqYXJnKQoreworCWNoYXIgKmVuZDsKKwlsb25nIHZhbDsKKworCXZhbCA9 IHN0cnRvbChhcmcsICZlbmQsIDEwKTsKKwlpZiAoISphcmcgfHwgKmVuZCB8 fCB2YWwgPCAwIHx8IHZhbCA+IElOVF9NQVgpCisJCWJhcmYoImludmFsaWQg cGFyYW1ldGVyIHZhbHVlIFwiJXNcIlxuIiwgYXJnKTsKKworCXJldHVybiB2 YWw7Cit9CisKK3N0YXRpYyBib29sIHdoYXRfbWF0Y2hlcyhjb25zdCBjaGFy ICphcmcsIGNvbnN0IGNoYXIgKndoYXQpCit7CisJdW5zaWduZWQgaW50IHdo YXRfbGVuID0gc3RybGVuKHdoYXQpOworCisJcmV0dXJuICFzdHJuY21wKGFy Zywgd2hhdCwgd2hhdF9sZW4pICYmIGFyZ1t3aGF0X2xlbl0gPT0gJz0nOwor fQorCitzdGF0aWMgdm9pZCBzZXRfdGltZW91dChjb25zdCBjaGFyICphcmcp Cit7CisJY29uc3QgY2hhciAqZXEgPSBzdHJjaHIoYXJnLCAnPScpOworCWlu dCB2YWw7CisKKwlpZiAoIWVxKQorCQliYXJmKCJxdW90YXMgbXVzdCBiZSBz cGVjaWZpZWQgdmlhIDx3aGF0Pj08c2Vjb25kcz5cbiIpOworCXZhbCA9IGdl dF9vcHR2YWxfaW50KGVxICsgMSk7CisJaWYgKHdoYXRfbWF0Y2hlcyhhcmcs ICJ3YXRjaC1ldmVudCIpKQorCQl0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWMg PSB2YWwgKiAxMDAwOworCWVsc2UKKwkJYmFyZigidW5rbm93biB0aW1lb3V0 IFwiJXNcIlxuIiwgYXJnKTsKK30KKwogaW50IG1haW4oaW50IGFyZ2MsIGNo YXIgKmFyZ3ZbXSkKIHsKIAlpbnQgb3B0OwpAQCAtMjI1MCw3ICsyMzcyLDcg QEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAlvcmlnX2Fy Z2MgPSBhcmdjOwogCW9yaWdfYXJndiA9IGFyZ3Y7CiAKLQl3aGlsZSAoKG9w dCA9IGdldG9wdF9sb25nKGFyZ2MsIGFyZ3YsICJERTpGOkhOUFM6dDpBOk06 VDpSVlc6VSIsIG9wdGlvbnMsCisJd2hpbGUgKChvcHQgPSBnZXRvcHRfbG9u ZyhhcmdjLCBhcmd2LCAiREU6RjpITlBTOnQ6QTpNOlQ6UlZXOnc6VSIsIG9w dGlvbnMsCiAJCQkJICBOVUxMKSkgIT0gLTEpIHsKIAkJc3dpdGNoIChvcHQp IHsKIAkJY2FzZSAnRCc6CkBAIC0yMzAwLDYgKzI0MjIsOSBAQCBpbnQgbWFp bihpbnQgYXJnYywgY2hhciAqYXJndltdKQogCQkJcXVvdGFfbWF4X3BhdGhf bGVuID0gbWluKFhFTlNUT1JFX1JFTF9QQVRIX01BWCwKIAkJCQkJCSBxdW90 YV9tYXhfcGF0aF9sZW4pOwogCQkJYnJlYWs7CisJCWNhc2UgJ3cnOgorCQkJ c2V0X3RpbWVvdXQob3B0YXJnKTsKKwkJCWJyZWFrOwogCQljYXNlICdlJzoK IAkJCWRvbTBfZXZlbnQgPSBzdHJ0b2wob3B0YXJnLCBOVUxMLCAxMCk7CiAJ CQlicmVhazsKQEAgLTI3NDEsNiArMjg2NiwxMiBAQCBzdGF0aWMgdm9pZCBh ZGRfYnVmZmVyZWRfZGF0YShzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRhdGEs CiAJCWJhcmYoImVycm9yIHJlc3RvcmluZyBidWZmZXJlZCBkYXRhIik7CiAK IAltZW1jcHkoYmRhdGEtPmJ1ZmZlciwgZGF0YSwgbGVuKTsKKwlpZiAoYmRh dGEtPmhkci5tc2cudHlwZSA9PSBYU19XQVRDSF9FVkVOVCAmJiB0aW1lb3V0 X3dhdGNoX2V2ZW50X21zZWMgJiYKKwkgICAgZG9tYWluX2lzX3VucHJpdmls ZWdlZChjb25uKSkgeworCQliZGF0YS0+dGltZW91dF9tc2VjID0gZ2V0X25v d19tc2VjKCkgKyB0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWM7CisJCWlmICgh Y29ubi0+dGltZW91dF9tc2VjKQorCQkJY29ubi0+dGltZW91dF9tc2VjID0g YmRhdGEtPnRpbWVvdXRfbXNlYzsKKwl9CiAKIAkvKiBRdWV1ZSBmb3IgbGF0 ZXIgdHJhbnNtaXNzaW9uLiAqLwogCWxpc3RfYWRkX3RhaWwoJmJkYXRhLT5s aXN0LCAmY29ubi0+b3V0X2xpc3QpOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmgKaW5kZXggZTdlZTg3ODI1YzNiLi44YTgxZmM2OTNmMDEg MTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgK KysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMjcs NiArMjcsNyBAQAogI2luY2x1ZGUgPGZjbnRsLmg+CiAjaW5jbHVkZSA8c3Rk Ym9vbC5oPgogI2luY2x1ZGUgPHN0ZGludC5oPgorI2luY2x1ZGUgPHRpbWUu aD4KICNpbmNsdWRlIDxlcnJuby5oPgogCiAjaW5jbHVkZSAieGVuc3RvcmVf bGliLmgiCkBAIC02Nyw2ICs2OCw4IEBAIHN0cnVjdCBidWZmZXJlZF9kYXRh CiAJCWNoYXIgcmF3W3NpemVvZihzdHJ1Y3QgeHNkX3NvY2ttc2cpXTsKIAl9 IGhkcjsKIAorCXVpbnQ2NF90IHRpbWVvdXRfbXNlYzsKKwogCS8qIFRoZSBh Y3R1YWwgZGF0YS4gKi8KIAljaGFyICpidWZmZXI7CiAJY2hhciBkZWZhdWx0 X2J1ZmZlcltERUZBVUxUX0JVRkZFUl9TSVpFXTsKQEAgLTExOCw2ICsxMjEs NyBAQCBzdHJ1Y3QgY29ubmVjdGlvbgogCiAJLyogQnVmZmVyZWQgb3V0cHV0 IGRhdGEgKi8KIAlzdHJ1Y3QgbGlzdF9oZWFkIG91dF9saXN0OworCXVpbnQ2 NF90IHRpbWVvdXRfbXNlYzsKIAogCS8qIFRyYW5zYWN0aW9uIGNvbnRleHQg Zm9yIGN1cnJlbnQgcmVxdWVzdCAoTlVMTCBpZiBub25lKS4gKi8KIAlzdHJ1 Y3QgdHJhbnNhY3Rpb24gKnRyYW5zYWN0aW9uOwpAQCAtMjQ0LDYgKzI0OCw4 IEBAIGV4dGVybiBpbnQgZG9tMF9ldmVudDsKIGV4dGVybiBpbnQgcHJpdl9k b21pZDsKIGV4dGVybiBpbnQgcXVvdGFfbmJfZW50cnlfcGVyX2RvbWFpbjsK IAorZXh0ZXJuIHVuc2lnbmVkIGludCB0aW1lb3V0X3dhdGNoX2V2ZW50X21z ZWM7CisKIC8qIE1hcCB0aGUga2VybmVsJ3MgeGVuc3RvcmUgcGFnZS4gKi8K IHZvaWQgKnhlbmJ1c19tYXAodm9pZCk7CiB2b2lkIHVubWFwX3hlbmJ1cyh2 b2lkICppbnRlcmZhY2UpOwo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-05.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-05.patch" Content-Transfer-Encoding: base64 RnJvbSAyZWVlMTIyYTQ1ZWI0YTIxODU5NmIxMDNjZTdmMDc1OWE4MjRjZjJl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxpbWl0IG91 dHN0YW5kaW5nIHJlcXVlc3RzCgpBZGQgYW5vdGhlciBxdW90YSBmb3IgbGlt aXRpbmcgdGhlIG51bWJlciBvZiBvdXRzdGFuZGluZyByZXF1ZXN0cyBvZiBh Cmd1ZXN0LiBBcyB0aGUgd2F5IHRvIHNwZWNpZnkgcXVvdGFzIG9uIHRoZSBj b21tYW5kIGxpbmUgaXMgYmVjb21pbmcKcmF0aGVyIG5hc3R5LCBzd2l0Y2gg dG8gYSBuZXcgc2NoZW1lIHVzaW5nIFstLXF1b3RhfC1RXSA8d2hhdD49PHZh bD4KYWxsb3dpbmcgdG8gYWRkIG1vcmUgcXVvdGFzIGluIGZ1dHVyZSBlYXNp bHkuCgpTZXQgdGhlIGRlZmF1bHQgdmFsdWUgdG8gMjAgKGJhc2ljYWxseSBh IHJhbmRvbSB2YWx1ZSBub3Qgc2VlbWluZyB0bwpiZSB0b28gaGlnaCBvciB0 b28gbG93KS4KCkEgcmVxdWVzdCBpcyBzYWlkIHRvIGJlIG91dHN0YW5kaW5n IGlmIGFueSBtZXNzYWdlIGdlbmVyYXRlZCBieSB0aGlzCnJlcXVlc3QgKHRo ZSBkaXJlY3QgcmVzcG9uc2UgcGx1cyBwb3RlbnRpYWwgd2F0Y2ggZXZlbnRz KSBpcyBub3QgeWV0CmNvbXBsZXRlbHkgc3RvcmVkIGludG8gYSByaW5nIGJ1 ZmZlci4gVGhlIGluaXRpYWwgd2F0Y2ggZXZlbnQgc2VudCBhcwphIHJlc3Vs dCBvZiByZWdpc3RlcmluZyBhIHdhdGNoIGlzIGFuIGV4Y2VwdGlvbi4KCk5v dGUgdGhhdCBhY3Jvc3MgYSBsaXZlIHVwZGF0ZSB0aGUgcmVsYXRpb24gdG8g YnVmZmVyZWQgd2F0Y2ggZXZlbnRzCmZvciBvdGhlciBkb21haW5zIGlzIGxv c3QuCgpVc2UgdGFsbG9jX3plcm8oKSBmb3IgYWxsb2NhdGluZyB0aGUgZG9t YWluIHN0cnVjdHVyZSBpbiBvcmRlciB0byBoYXZlCmFsbCBwZXItZG9tYWlu IHF1b3RhIHplcm9lZCBpbml0aWFsbHkuCgpUaGlzIGlzIHBhcnQgb2YgWFNB LTMyNiAvIENWRS0yMDIyLTQyMzEyLgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKaW5kZXggNDUyNDRjMDIxY2QzLi40ODhkNTQwZjNh MzIgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAt MTA3LDYgKzEwNyw3IEBAIGludCBxdW90YV9tYXhfZW50cnlfc2l6ZSA9IDIw NDg7IC8qIDJLICovCiBpbnQgcXVvdGFfbWF4X3RyYW5zYWN0aW9uID0gMTA7 CiBpbnQgcXVvdGFfbmJfcGVybXNfcGVyX25vZGUgPSA1OwogaW50IHF1b3Rh X21heF9wYXRoX2xlbiA9IFhFTlNUT1JFX1JFTF9QQVRIX01BWDsKK2ludCBx dW90YV9yZXFfb3V0c3RhbmRpbmcgPSAyMDsKIAogdW5zaWduZWQgaW50IHRp bWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyA9IDIwMDAwOwogCkBAIC0yMjMsMTIg KzIyNCwyNCBAQCBzdGF0aWMgdWludDY0X3QgZ2V0X25vd19tc2VjKHZvaWQp CiAJcmV0dXJuIG5vd190cy50dl9zZWMgKiAxMDAwICsgbm93X3RzLnR2X25z ZWMgLyAxMDAwMDAwOwogfQogCisvKgorICogUmVtb3ZlIGEgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgZnJvbSB0aGUgbGlzdCBvZiBvdXRnb2luZyBkYXRhLgor ICogQSBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSByZWxhdGVkIHRvIGEgcmVxdWVz dCBoYXZpbmcgY2F1c2VkIHdhdGNoIGV2ZW50cyB0byBiZQorICogc2VudCBp cyBrZXB0IHVudGlsIGFsbCB0aG9zZSBldmVudHMgaGF2ZSBiZWVuIHdyaXR0 ZW4gb3V0LgorICogRWFjaCB3YXRjaCBldmVudCBpcyByZWZlcmVuY2luZyB0 aGUgcmVsYXRlZCByZXF1ZXN0IHZpYSBwZW5kLnJlcSwgd2hpbGUgdGhlCisg KiBudW1iZXIgb2Ygd2F0Y2ggZXZlbnRzIGNhdXNlZCBieSBhIHJlcXVlc3Qg aXMga2VwdCBpbiBwZW5kLnJlZi5ldmVudF9jbnQKKyAqICh0aG9zZSB0d28g Y2FzZXMgYXJlIG11dHVhbGx5IGV4Y2x1c2l2ZSwgc28gdGhlIHR3byBmaWVs ZHMgY2FuIHNoYXJlIG1lbW9yeQorICogdmlhIGEgdW5pb24pLgorICogVGhl IHN0cnVjdCBidWZmZXJlZF9kYXRhIGlzIGZyZWVkIG9ubHkgaWYgbm8gcmVs YXRlZCB3YXRjaCBldmVudCBpcworICogcmVmZXJlbmNpbmcgaXQuIFRoZSBy ZWxhdGVkIHJldHVybiBkYXRhIGNhbiBiZSBmcmVlZCByaWdodCBhd2F5Lgor ICovCiBzdGF0aWMgdm9pZCBmcmVlX2J1ZmZlcmVkX2RhdGEoc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKm91dCwKIAkJCSAgICAgICBzdHJ1Y3QgY29ubmVjdGlv biAqY29ubikKIHsKIAlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqcmVxOwogCiAJ bGlzdF9kZWwoJm91dC0+bGlzdCk7CisJb3V0LT5vbl9vdXRfbGlzdCA9IGZh bHNlOwogCiAJLyoKIAkgKiBVcGRhdGUgY29ubi0+dGltZW91dF9tc2VjIHdp dGggdGhlIG5leHQgZm91bmQgdGltZW91dCB2YWx1ZSBpbiB0aGUKQEAgLTI0 NCw2ICsyNTcsMzAgQEAgc3RhdGljIHZvaWQgZnJlZV9idWZmZXJlZF9kYXRh KHN0cnVjdCBidWZmZXJlZF9kYXRhICpvdXQsCiAJCX0KIAl9CiAKKwlpZiAo b3V0LT5oZHIubXNnLnR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQpIHsKKwkJcmVx ID0gb3V0LT5wZW5kLnJlcTsKKwkJaWYgKHJlcSkgeworCQkJcmVxLT5wZW5k LnJlZi5ldmVudF9jbnQtLTsKKwkJCWlmICghcmVxLT5wZW5kLnJlZi5ldmVu dF9jbnQgJiYgIXJlcS0+b25fb3V0X2xpc3QpIHsKKwkJCQlpZiAocmVxLT5v bl9yZWZfbGlzdCkgeworCQkJCQlkb21haW5fb3V0c3RhbmRpbmdfZG9taWRf ZGVjKAorCQkJCQkJcmVxLT5wZW5kLnJlZi5kb21pZCk7CisJCQkJCWxpc3Rf ZGVsKCZyZXEtPmxpc3QpOworCQkJCX0KKwkJCQl0YWxsb2NfZnJlZShyZXEp OworCQkJfQorCQl9CisJfSBlbHNlIGlmIChvdXQtPnBlbmQucmVmLmV2ZW50 X2NudCkgeworCQkvKiBIYW5nIG91dCBvZmYgZnJvbSBjb25uLiAqLworCQl0 YWxsb2Nfc3RlYWwoTlVMTCwgb3V0KTsKKwkJaWYgKG91dC0+YnVmZmVyICE9 IG91dC0+ZGVmYXVsdF9idWZmZXIpCisJCQl0YWxsb2NfZnJlZShvdXQtPmJ1 ZmZlcik7CisJCWxpc3RfYWRkKCZvdXQtPmxpc3QsICZjb25uLT5yZWZfbGlz dCk7CisJCW91dC0+b25fcmVmX2xpc3QgPSB0cnVlOworCQlyZXR1cm47CisJ fSBlbHNlCisJCWRvbWFpbl9vdXRzdGFuZGluZ19kZWMoY29ubik7CisKIAl0 YWxsb2NfZnJlZShvdXQpOwogfQogCkBAIC00MDUsNiArNDQyLDcgQEAgaW50 IGRlbGF5X3JlcXVlc3Qoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbiwKIHN0YXRpYyBpbnQgZGVzdHJveV9jb25u KHZvaWQgKl9jb25uKQogewogCXN0cnVjdCBjb25uZWN0aW9uICpjb25uID0g X2Nvbm47CisJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKnJlcTsKIAogCS8qIEZs dXNoIG91dGdvaW5nIGlmIHBvc3NpYmxlLCBidXQgZG9uJ3QgYmxvY2suICov CiAJaWYgKCFjb25uLT5kb21haW4pIHsKQEAgLTQxOCw2ICs0NTYsMTEgQEAg c3RhdGljIGludCBkZXN0cm95X2Nvbm4odm9pZCAqX2Nvbm4pCiAJCQkJYnJl YWs7CiAJCWNsb3NlKGNvbm4tPmZkKTsKIAl9CisKKwljb25uX2ZyZWVfYnVm ZmVyZWRfZGF0YShjb25uKTsKKwlsaXN0X2Zvcl9lYWNoX2VudHJ5KHJlcSwg JmNvbm4tPnJlZl9saXN0LCBsaXN0KQorCQlyZXEtPm9uX3JlZl9saXN0ID0g ZmFsc2U7CisKICAgICAgICAgaWYgKGNvbm4tPnRhcmdldCkKICAgICAgICAg ICAgICAgICB0YWxsb2NfdW5saW5rKGNvbm4sIGNvbm4tPnRhcmdldCk7CiAJ bGlzdF9kZWwoJmNvbm4tPmxpc3QpOwpAQCAtODkzLDYgKzkzNiw4IEBAIHZv aWQgc2VuZF9yZXBseShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgZW51bSB4 c2Rfc29ja21zZ190eXBlIHR5cGUsCiAKIAkvKiBRdWV1ZSBmb3IgbGF0ZXIg dHJhbnNtaXNzaW9uLiAqLwogCWxpc3RfYWRkX3RhaWwoJmJkYXRhLT5saXN0 LCAmY29ubi0+b3V0X2xpc3QpOworCWJkYXRhLT5vbl9vdXRfbGlzdCA9IHRy dWU7CisJZG9tYWluX291dHN0YW5kaW5nX2luYyhjb25uKTsKIH0KIAogLyoK QEAgLTkwMCw3ICs5NDUsOCBAQCB2b2lkIHNlbmRfcmVwbHkoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlLAog ICogQXMgdGhpcyBpcyBub3QgZGlyZWN0bHkgcmVsYXRlZCB0byB0aGUgY3Vy cmVudCBjb21tYW5kLCBlcnJvcnMgY2FuJ3QgYmUKICAqIHJlcG9ydGVkLgog ICovCi12b2lkIHNlbmRfZXZlbnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IGNvbnN0IGNoYXIgKnBhdGgsIGNvbnN0IGNoYXIgKnRva2VuKQordm9pZCBz ZW5kX2V2ZW50KHN0cnVjdCBidWZmZXJlZF9kYXRhICpyZXEsIHN0cnVjdCBj b25uZWN0aW9uICpjb25uLAorCQljb25zdCBjaGFyICpwYXRoLCBjb25zdCBj aGFyICp0b2tlbikKIHsKIAlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRhdGE7 CiAJdW5zaWduZWQgaW50IGxlbjsKQEAgLTkzMCw4ICs5NzYsMTMgQEAgdm9p ZCBzZW5kX2V2ZW50KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBj aGFyICpwYXRoLCBjb25zdCBjaGFyICp0b2tlbikKIAkJCWNvbm4tPnRpbWVv dXRfbXNlYyA9IGJkYXRhLT50aW1lb3V0X21zZWM7CiAJfQogCisJYmRhdGEt PnBlbmQucmVxID0gcmVxOworCWlmIChyZXEpCisJCXJlcS0+cGVuZC5yZWYu ZXZlbnRfY250Kys7CisKIAkvKiBRdWV1ZSBmb3IgbGF0ZXIgdHJhbnNtaXNz aW9uLiAqLwogCWxpc3RfYWRkX3RhaWwoJmJkYXRhLT5saXN0LCAmY29ubi0+ b3V0X2xpc3QpOworCWJkYXRhLT5vbl9vdXRfbGlzdCA9IHRydWU7CiB9CiAK IC8qIFNvbWUgcm91dGluZXMgKHdyaXRlLCBta2RpciwgZXRjKSBqdXN0IG5l ZWQgYSBub24tZXJyb3IgcmV0dXJuICovCkBAIC0xNzQwLDYgKzE3OTEsNyBA QCBzdGF0aWMgdm9pZCBoYW5kbGVfaW5wdXQoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pCiAJCQlyZXR1cm47CiAJfQogCWluID0gY29ubi0+aW47CisJaW4t PnBlbmQucmVmLmRvbWlkID0gY29ubi0+aWQ7CiAKIAkvKiBOb3QgZmluaXNo ZWQgaGVhZGVyIHlldD8gKi8KIAlpZiAoaW4tPmluaGRyKSB7CkBAIC0xODA4 LDYgKzE4NjAsNyBAQCBzdHJ1Y3QgY29ubmVjdGlvbiAqbmV3X2Nvbm5lY3Rp b24oY29uc3Qgc3RydWN0IGludGVyZmFjZV9mdW5jcyAqZnVuY3MpCiAJbmV3 LT5pc19zdGFsbGVkID0gZmFsc2U7CiAJbmV3LT50cmFuc2FjdGlvbl9zdGFy dGVkID0gMDsKIAlJTklUX0xJU1RfSEVBRCgmbmV3LT5vdXRfbGlzdCk7CisJ SU5JVF9MSVNUX0hFQUQoJm5ldy0+cmVmX2xpc3QpOwogCUlOSVRfTElTVF9I RUFEKCZuZXctPndhdGNoZXMpOwogCUlOSVRfTElTVF9IRUFEKCZuZXctPnRy YW5zYWN0aW9uX2xpc3QpOwogCUlOSVRfTElTVF9IRUFEKCZuZXctPmRlbGF5 ZWQpOwpAQCAtMjI4Niw2ICsyMzM5LDkgQEAgc3RhdGljIHZvaWQgdXNhZ2Uo dm9pZCkKICIgIC10LCAtLXRyYW5zYWN0aW9uIDxuYj4gIGxpbWl0IHRoZSBu dW1iZXIgb2YgdHJhbnNhY3Rpb24gYWxsb3dlZCBwZXIgZG9tYWluLFxuIgog IiAgLUEsIC0tcGVybS1uYiA8bmI+ICAgICAgbGltaXQgdGhlIG51bWJlciBv ZiBwZXJtaXNzaW9ucyBwZXIgbm9kZSxcbiIKICIgIC1NLCAtLXBhdGgtbWF4 IDxjaGFycz4gIGxpbWl0IHRoZSBhbGxvd2VkIFhlbnN0b3JlIG5vZGUgcGF0 aCBsZW5ndGgsXG4iCisiICAtUSwgLS1xdW90YSA8d2hhdD49PG5iPiBzZXQg dGhlIHF1b3RhIDx3aGF0PiB0byB0aGUgdmFsdWUgPG5iPiwgYWxsb3dlZFxu IgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgcXVvdGFzIGFyZTpcbiIK KyIgICAgICAgICAgICAgICAgICAgICAgICAgIG91dHN0YW5kaW5nOiBudW1i ZXIgb2Ygb3V0c3RhbmRpbmcgcmVxdWVzdHNcbiIKICIgIC13LCAtLXRpbWVv dXQgPHdoYXQ+PTxzZWNvbmRzPiAgIHNldCB0aGUgdGltZW91dCBpbiBzZWNv bmRzIGZvciA8d2hhdD4sXG4iCiAiICAgICAgICAgICAgICAgICAgICAgICAg ICBhbGxvd2VkIHRpbWVvdXQgY2FuZGlkYXRlcyBhcmU6XG4iCiAiICAgICAg ICAgICAgICAgICAgICAgICAgICB3YXRjaC1ldmVudDogdGltZSBhIHdhdGNo LWV2ZW50IGlzIGtlcHQgcGVuZGluZ1xuIgpAQCAtMjMxMSw2ICsyMzY3LDcg QEAgc3RhdGljIHN0cnVjdCBvcHRpb24gb3B0aW9uc1tdID0gewogCXsgInRy YW5zYWN0aW9uIiwgMSwgTlVMTCwgJ3QnIH0sCiAJeyAicGVybS1uYiIsIDEs IE5VTEwsICdBJyB9LAogCXsgInBhdGgtbWF4IiwgMSwgTlVMTCwgJ00nIH0s CisJeyAicXVvdGEiLCAxLCBOVUxMLCAnUScgfSwKIAl7ICJ0aW1lb3V0Iiwg MSwgTlVMTCwgJ3cnIH0sCiAJeyAibm8tcmVjb3ZlcnkiLCAwLCBOVUxMLCAn UicgfSwKIAl7ICJpbnRlcm5hbC1kYiIsIDAsIE5VTEwsICdJJyB9LApAQCAt MjM1OCw2ICsyNDE1LDIwIEBAIHN0YXRpYyB2b2lkIHNldF90aW1lb3V0KGNv bnN0IGNoYXIgKmFyZykKIAkJYmFyZigidW5rbm93biB0aW1lb3V0IFwiJXNc IlxuIiwgYXJnKTsKIH0KIAorc3RhdGljIHZvaWQgc2V0X3F1b3RhKGNvbnN0 IGNoYXIgKmFyZykKK3sKKwljb25zdCBjaGFyICplcSA9IHN0cmNocihhcmcs ICc9Jyk7CisJaW50IHZhbDsKKworCWlmICghZXEpCisJCWJhcmYoInF1b3Rh cyBtdXN0IGJlIHNwZWNpZmllZCB2aWEgPHdoYXQ+PTxuYj5cbiIpOworCXZh bCA9IGdldF9vcHR2YWxfaW50KGVxICsgMSk7CisJaWYgKHdoYXRfbWF0Y2hl cyhhcmcsICJvdXRzdGFuZGluZyIpKQorCQlxdW90YV9yZXFfb3V0c3RhbmRp bmcgPSB2YWw7CisJZWxzZQorCQliYXJmKCJ1bmtub3duIHF1b3RhIFwiJXNc IlxuIiwgYXJnKTsKK30KKwogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFy Z3ZbXSkKIHsKIAlpbnQgb3B0OwpAQCAtMjM3Miw4ICsyNDQzLDggQEAgaW50 IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAlvcmlnX2FyZ2MgPSBh cmdjOwogCW9yaWdfYXJndiA9IGFyZ3Y7CiAKLQl3aGlsZSAoKG9wdCA9IGdl dG9wdF9sb25nKGFyZ2MsIGFyZ3YsICJERTpGOkhOUFM6dDpBOk06VDpSVlc6 dzpVIiwgb3B0aW9ucywKLQkJCQkgIE5VTEwpKSAhPSAtMSkgeworCXdoaWxl ICgob3B0ID0gZ2V0b3B0X2xvbmcoYXJnYywgYXJndiwgIkRFOkY6SE5QUzp0 OkE6TTpROlQ6UlZXOnc6VSIsCisJCQkJICBvcHRpb25zLCBOVUxMKSkgIT0g LTEpIHsKIAkJc3dpdGNoIChvcHQpIHsKIAkJY2FzZSAnRCc6CiAJCQlub19k b21haW5faW5pdCA9IHRydWU7CkBAIC0yNDIyLDYgKzI0OTMsOSBAQCBpbnQg bWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQogCQkJcXVvdGFfbWF4X3Bh dGhfbGVuID0gbWluKFhFTlNUT1JFX1JFTF9QQVRIX01BWCwKIAkJCQkJCSBx dW90YV9tYXhfcGF0aF9sZW4pOwogCQkJYnJlYWs7CisJCWNhc2UgJ1EnOgor CQkJc2V0X3F1b3RhKG9wdGFyZyk7CisJCQlicmVhazsKIAkJY2FzZSAndyc6 CiAJCQlzZXRfdGltZW91dChvcHRhcmcpOwogCQkJYnJlYWs7CkBAIC0yODc1 LDYgKzI5NDksMTQgQEAgc3RhdGljIHZvaWQgYWRkX2J1ZmZlcmVkX2RhdGEo c3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmJkYXRhLAogCiAJLyogUXVldWUgZm9y IGxhdGVyIHRyYW5zbWlzc2lvbi4gKi8KIAlsaXN0X2FkZF90YWlsKCZiZGF0 YS0+bGlzdCwgJmNvbm4tPm91dF9saXN0KTsKKwliZGF0YS0+b25fb3V0X2xp c3QgPSB0cnVlOworCS8qCisJICogV2F0Y2ggZXZlbnRzIGFyZSBuZXZlciAi b3V0c3RhbmRpbmciLCBidXQgdGhlIHJlcXVlc3QgY2F1c2luZyB0aGVtCisJ ICogYXJlIGluc3RlYWQga2VwdCAib3V0c3RhbmRpbmciIHVudGlsIGFsbCB3 YXRjaCBldmVudHMgY2F1c2VkIGJ5IHRoYXQKKwkgKiByZXF1ZXN0IGhhdmUg YmVlbiBkZWxpdmVyZWQuCisJICovCisJaWYgKGJkYXRhLT5oZHIubXNnLnR5 cGUgIT0gWFNfV0FUQ0hfRVZFTlQpCisJCWRvbWFpbl9vdXRzdGFuZGluZ19p bmMoY29ubik7CiB9CiAKIHZvaWQgcmVhZF9zdGF0ZV9idWZmZXJlZF9kYXRh KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCmRp ZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCA4YTgxZmM2 OTNmMDEuLmRiMDlmNDYzYTY1NyAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfY29yZS5oCkBAIC01Niw2ICs1Niw4IEBAIHN0cnVjdCB4c19zdGF0 ZV9jb25uZWN0aW9uOwogc3RydWN0IGJ1ZmZlcmVkX2RhdGEKIHsKIAlzdHJ1 Y3QgbGlzdF9oZWFkIGxpc3Q7CisJYm9vbCBvbl9vdXRfbGlzdDsKKwlib29s IG9uX3JlZl9saXN0OwogCiAJLyogQXJlIHdlIHN0aWxsIGRvaW5nIHRoZSBo ZWFkZXI/ICovCiAJYm9vbCBpbmhkcjsKQEAgLTYzLDYgKzY1LDE3IEBAIHN0 cnVjdCBidWZmZXJlZF9kYXRhCiAJLyogSG93IGZhciBhcmUgd2U/ICovCiAJ dW5zaWduZWQgaW50IHVzZWQ7CiAKKwkvKiBPdXRzdGFuZGluZyByZXF1ZXN0 IGFjY291bnRpbmcuICovCisJdW5pb24geworCQkvKiByZWYgaXMgYmVpbmcg dXNlZCBmb3IgcmVxdWVzdHMuICovCisJCXN0cnVjdCB7CisJCQl1bnNpZ25l ZCBpbnQgZXZlbnRfY250OyAvKiAjIG9mIG91dHN0YW5kaW5nIGV2ZW50cy4g Ki8KKwkJCXVuc2lnbmVkIGludCBkb21pZDsgICAgIC8qIGRvbWlkIG9mIHJl cXVlc3QuICovCisJCX0gcmVmOworCQkvKiByZXEgaXMgYmVpbmcgdXNlZCBm b3Igd2F0Y2ggZXZlbnRzLiAqLworCQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAq cmVxOyAgICAgIC8qIHJlcXVlc3QgY2F1c2luZyBldmVudC4gKi8KKwl9IHBl bmQ7CisKIAl1bmlvbiB7CiAJCXN0cnVjdCB4c2Rfc29ja21zZyBtc2c7CiAJ CWNoYXIgcmF3W3NpemVvZihzdHJ1Y3QgeHNkX3NvY2ttc2cpXTsKQEAgLTEy Myw2ICsxMzYsOSBAQCBzdHJ1Y3QgY29ubmVjdGlvbgogCXN0cnVjdCBsaXN0 X2hlYWQgb3V0X2xpc3Q7CiAJdWludDY0X3QgdGltZW91dF9tc2VjOwogCisJ LyogUmVmZXJlbmNlZCByZXF1ZXN0cyBubyBsb25nZXIgcGVuZGluZy4gKi8K KwlzdHJ1Y3QgbGlzdF9oZWFkIHJlZl9saXN0OworCiAJLyogVHJhbnNhY3Rp b24gY29udGV4dCBmb3IgY3VycmVudCByZXF1ZXN0IChOVUxMIGlmIG5vbmUp LiAqLwogCXN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnNhY3Rpb247CiAKQEAg LTE5MSw3ICsyMDcsOCBAQCB1bnNpZ25lZCBpbnQgZ2V0X3N0cmluZyhjb25z dCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqZGF0YSwgdW5zaWduZWQgaW50IG9m ZnNldCk7CiAKIHZvaWQgc2VuZF9yZXBseShzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgZW51bSB4c2Rfc29ja21zZ190eXBlIHR5cGUsCiAJCWNvbnN0IHZv aWQgKmRhdGEsIHVuc2lnbmVkIGludCBsZW4pOwotdm9pZCBzZW5kX2V2ZW50 KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpwYXRoLCBj b25zdCBjaGFyICp0b2tlbik7Cit2b2lkIHNlbmRfZXZlbnQoc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKnJlcSwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJ CWNvbnN0IGNoYXIgKnBhdGgsIGNvbnN0IGNoYXIgKnRva2VuKTsKIAogLyog U29tZSByb3V0aW5lcyAod3JpdGUsIG1rZGlyLCBldGMpIGp1c3QgbmVlZCBh IG5vbi1lcnJvciByZXR1cm4gKi8KIHZvaWQgc2VuZF9hY2soc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlKTsK QEAgLTI0Nyw2ICsyNjQsNyBAQCBleHRlcm4gaW50IGRvbTBfZG9taWQ7CiBl eHRlcm4gaW50IGRvbTBfZXZlbnQ7CiBleHRlcm4gaW50IHByaXZfZG9taWQ7 CiBleHRlcm4gaW50IHF1b3RhX25iX2VudHJ5X3Blcl9kb21haW47CitleHRl cm4gaW50IHF1b3RhX3JlcV9vdXRzdGFuZGluZzsKIAogZXh0ZXJuIHVuc2ln bmVkIGludCB0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWM7CiAKZGlmZiAtLWdp dCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYyBiL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYwppbmRleCA5M2M0YzFlZGNk ZDEuLjg1MDA4NWE5MmM3NiAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2RvbWFpbi5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9kb21haW4uYwpAQCAtNzgsNiArNzgsOSBAQCBzdHJ1Y3QgZG9tYWlu CiAJLyogbnVtYmVyIG9mIHdhdGNoIGZvciB0aGlzIGRvbWFpbiAqLwogCWlu dCBuYndhdGNoOwogCisJLyogTnVtYmVyIG9mIG91dHN0YW5kaW5nIHJlcXVl c3RzLiAqLworCWludCBuYm91dHN0YW5kaW5nOworCiAJLyogd3JpdGUgcmF0 ZSBsaW1pdCAqLwogCXdybF9jcmVkaXR0IHdybF9jcmVkaXQ7IC8qIFsgLXdy bF9jb25maWdfd3JpdGVjb3N0LCArX2RidXJzdCBdICovCiAJc3RydWN0IHdy bF90aW1lc3RhbXB0IHdybF90aW1lc3RhbXA7CkBAIC0xODMsOCArMTg2LDEy IEBAIHN0YXRpYyBib29sIGRvbWFpbl9jYW5fcmVhZChzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubikKIHsKIAlzdHJ1Y3QgeGVuc3RvcmVfZG9tYWluX2ludGVy ZmFjZSAqaW50ZiA9IGNvbm4tPmRvbWFpbi0+aW50ZXJmYWNlOwogCi0JaWYg KGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikgJiYgY29ubi0+ZG9tYWlu LT53cmxfY3JlZGl0IDwgMCkKLQkJcmV0dXJuIGZhbHNlOworCWlmIChkb21h aW5faXNfdW5wcml2aWxlZ2VkKGNvbm4pKSB7CisJCWlmIChjb25uLT5kb21h aW4tPndybF9jcmVkaXQgPCAwKQorCQkJcmV0dXJuIGZhbHNlOworCQlpZiAo Y29ubi0+ZG9tYWluLT5uYm91dHN0YW5kaW5nID49IHF1b3RhX3JlcV9vdXRz dGFuZGluZykKKwkJCXJldHVybiBmYWxzZTsKKwl9CiAKIAlyZXR1cm4gKGlu dGYtPnJlcV9jb25zICE9IGludGYtPnJlcV9wcm9kKTsKIH0KQEAgLTMzMSw3 ICszMzgsNyBAQCBzdGF0aWMgc3RydWN0IGRvbWFpbiAqYWxsb2NfZG9tYWlu KGNvbnN0IHZvaWQgKmNvbnRleHQsIHVuc2lnbmVkIGludCBkb21pZCkKIHsK IAlzdHJ1Y3QgZG9tYWluICpkb21haW47CiAKLQlkb21haW4gPSB0YWxsb2Mo Y29udGV4dCwgc3RydWN0IGRvbWFpbik7CisJZG9tYWluID0gdGFsbG9jX3pl cm8oY29udGV4dCwgc3RydWN0IGRvbWFpbik7CiAJaWYgKCFkb21haW4pIHsK IAkJZXJybm8gPSBFTk9NRU07CiAJCXJldHVybiBOVUxMOwpAQCAtMzkyLDkg KzM5OSw2IEBAIHN0YXRpYyBpbnQgbmV3X2RvbWFpbihzdHJ1Y3QgZG9tYWlu ICpkb21haW4sIGludCBwb3J0LCBib29sIHJlc3RvcmUpCiAJZG9tYWluLT5j b25uLT5kb21haW4gPSBkb21haW47CiAJZG9tYWluLT5jb25uLT5pZCA9IGRv bWFpbi0+ZG9taWQ7CiAKLQlkb21haW4tPm5iZW50cnkgPSAwOwotCWRvbWFp bi0+bmJ3YXRjaCA9IDA7Ci0KIAlyZXR1cm4gMDsKIH0KIApAQCAtOTM4LDYg Kzk0MiwyOCBAQCBpbnQgZG9tYWluX3dhdGNoKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uKQogCQk6IDA7CiB9CiAKK3ZvaWQgZG9tYWluX291dHN0YW5kaW5n X2luYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubikKK3sKKwlpZiAoIWNvbm4g fHwgIWNvbm4tPmRvbWFpbikKKwkJcmV0dXJuOworCWNvbm4tPmRvbWFpbi0+ bmJvdXRzdGFuZGluZysrOworfQorCit2b2lkIGRvbWFpbl9vdXRzdGFuZGlu Z19kZWMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCit7CisJaWYgKCFjb25u IHx8ICFjb25uLT5kb21haW4pCisJCXJldHVybjsKKwljb25uLT5kb21haW4t Pm5ib3V0c3RhbmRpbmctLTsKK30KKwordm9pZCBkb21haW5fb3V0c3RhbmRp bmdfZG9taWRfZGVjKHVuc2lnbmVkIGludCBkb21pZCkKK3sKKwlzdHJ1Y3Qg ZG9tYWluICpkID0gZmluZF9kb21haW5fYnlfZG9taWQoZG9taWQpOworCisJ aWYgKGQpCisJCWQtPm5ib3V0c3RhbmRpbmctLTsKK30KKwogc3RhdGljIHdy bF9jcmVkaXR0IHdybF9jb25maWdfd3JpdGVjb3N0ICAgICAgPSBXUkxfRkFD VE9SOwogc3RhdGljIHdybF9jcmVkaXR0IHdybF9jb25maWdfcmF0ZSAgICAg ICAgICAgPSBXUkxfUkFURSAgICogV1JMX0ZBQ1RPUjsKIHN0YXRpYyB3cmxf Y3JlZGl0dCB3cmxfY29uZmlnX2RidXJzdCAgICAgICAgID0gV1JMX0RCVVJT VCAqIFdSTF9GQUNUT1I7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfZG9tYWluLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmgKaW5kZXggMWU5MjliOGY4YzZmLi40ZjUxYjAwNTI5MWEgMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaAor KysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgKQEAgLTY0 LDYgKzY0LDkgQEAgaW50IGRvbWFpbl9lbnRyeShzdHJ1Y3QgY29ubmVjdGlv biAqY29ubik7CiB2b2lkIGRvbWFpbl93YXRjaF9pbmMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pOwogdm9pZCBkb21haW5fd2F0Y2hfZGVjKHN0cnVjdCBj b25uZWN0aW9uICpjb25uKTsKIGludCBkb21haW5fd2F0Y2goc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4pOwordm9pZCBkb21haW5fb3V0c3RhbmRpbmdfaW5j KHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsKK3ZvaWQgZG9tYWluX291dHN0 YW5kaW5nX2RlYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7Cit2b2lkIGRv bWFpbl9vdXRzdGFuZGluZ19kb21pZF9kZWModW5zaWduZWQgaW50IGRvbWlk KTsKIAogLyogU3BlY2lhbCBub2RlIHBlcm1pc3Npb24gaGFuZGxpbmcuICov CiBpbnQgc2V0X3Blcm1zX3NwZWNpYWwoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sIGNvbnN0IGNoYXIgKm5hbWUsCmRpZmYgLS1naXQgYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfd2F0Y2guYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF93YXRjaC5jCmluZGV4IDIwNWQ5ZDhlYTExNi4uMDc1NWZmYTM3NWJh IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2gu YworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYwpAQCAt MTQyLDYgKzE0Miw3IEBAIHZvaWQgZmlyZV93YXRjaGVzKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsIGNvbnN0IGNoYXIgKm5h bWUsCiAJCSAgc3RydWN0IG5vZGUgKm5vZGUsIGJvb2wgZXhhY3QsIHN0cnVj dCBub2RlX3Blcm1zICpwZXJtcykKIHsKIAlzdHJ1Y3QgY29ubmVjdGlvbiAq aTsKKwlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqcmVxOwogCXN0cnVjdCB3YXRj aCAqd2F0Y2g7CiAKIAkvKiBEdXJpbmcgdHJhbnNhY3Rpb25zLCBkb24ndCBm aXJlIHdhdGNoZXMsIGJ1dCBxdWV1ZSB0aGVtLiAqLwpAQCAtMTUwLDYgKzE1 MSw4IEBAIHZvaWQgZmlyZV93YXRjaGVzKHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCBjb25zdCB2b2lkICpjdHgsIGNvbnN0IGNoYXIgKm5hbWUsCiAJCXJl dHVybjsKIAl9CiAKKwlyZXEgPSBkb21haW5faXNfdW5wcml2aWxlZ2VkKGNv bm4pID8gY29ubi0+aW4gOiBOVUxMOworCiAJLyogQ3JlYXRlIGFuIGV2ZW50 IGZvciBlYWNoIHdhdGNoLiAqLwogCWxpc3RfZm9yX2VhY2hfZW50cnkoaSwg JmNvbm5lY3Rpb25zLCBsaXN0KSB7CiAJCS8qIGludHJvZHVjZS9yZWxlYXNl IGRvbWFpbiB3YXRjaGVzICovCkBAIC0xNjQsMTIgKzE2NywxMiBAQCB2b2lk IGZpcmVfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qg dm9pZCAqY3R4LCBjb25zdCBjaGFyICpuYW1lLAogCQlsaXN0X2Zvcl9lYWNo X2VudHJ5KHdhdGNoLCAmaS0+d2F0Y2hlcywgbGlzdCkgewogCQkJaWYgKGV4 YWN0KSB7CiAJCQkJaWYgKHN0cmVxKG5hbWUsIHdhdGNoLT5ub2RlKSkKLQkJ CQkJc2VuZF9ldmVudChpLAorCQkJCQlzZW5kX2V2ZW50KHJlcSwgaSwKIAkJ CQkJCSAgIGdldF93YXRjaF9wYXRoKHdhdGNoLCBuYW1lKSwKIAkJCQkJCSAg IHdhdGNoLT50b2tlbik7CiAJCQl9IGVsc2UgewogCQkJCWlmIChpc19jaGls ZChuYW1lLCB3YXRjaC0+bm9kZSkpCi0JCQkJCXNlbmRfZXZlbnQoaSwKKwkJ CQkJc2VuZF9ldmVudChyZXEsIGksCiAJCQkJCQkgICBnZXRfd2F0Y2hfcGF0 aCh3YXRjaCwgbmFtZSksCiAJCQkJCQkgICB3YXRjaC0+dG9rZW4pOwogCQkJ fQpAQCAtMjY5LDggKzI3MiwxMiBAQCBpbnQgZG9fd2F0Y2goc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAl0 cmFjZV9jcmVhdGUod2F0Y2gsICJ3YXRjaCIpOwogCXNlbmRfYWNrKGNvbm4s IFhTX1dBVENIKTsKIAotCS8qIFdlIGZpcmUgb25jZSB1cCBmcm9udDogc2lt cGxpZmllcyBjbGllbnRzIGFuZCByZXN0YXJ0LiAqLwotCXNlbmRfZXZlbnQo Y29ubiwgZ2V0X3dhdGNoX3BhdGgod2F0Y2gsIHdhdGNoLT5ub2RlKSwgd2F0 Y2gtPnRva2VuKTsKKwkvKgorCSAqIFdlIGZpcmUgb25jZSB1cCBmcm9udDog c2ltcGxpZmllcyBjbGllbnRzIGFuZCByZXN0YXJ0LgorCSAqIFRoaXMgZXZl bnQgd2lsbCBub3QgYmUgbGlua2VkIHRvIHRoZSBYU19XQVRDSCByZXF1ZXN0 LgorCSAqLworCXNlbmRfZXZlbnQoTlVMTCwgY29ubiwgZ2V0X3dhdGNoX3Bh dGgod2F0Y2gsIHdhdGNoLT5ub2RlKSwKKwkJICAgd2F0Y2gtPnRva2VuKTsK IAogCXJldHVybiAwOwogfQo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-06.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-06.patch" Content-Transfer-Encoding: base64 RnJvbSBjODA1N2NiNDgzYWJmMmNkNDA2MGIzOTYxNjQyM2UxOTI4M2ZiZDBh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGRvbid0IGJ1 ZmZlciBtdWx0aXBsZSBpZGVudGljYWwgd2F0Y2ggZXZlbnRzCgpBIGd1ZXN0 IG5vdCByZWFkaW5nIGl0cyBYZW5zdG9yZSByZXNwb25zZSBidWZmZXIgZmFz dCBlbm91Z2ggbWlnaHQKcGlsZSB1cCBsb3RzIG9mIFhlbnN0b3JlIHdhdGNo IGV2ZW50cyBidWZmZXJlZC4gUmVkdWNlIHRoZSBnZW5lcmF0ZWQKbG9hZCBi eSBkcm9wcGluZyBuZXcgZXZlbnRzIHdoaWNoIGFscmVhZHkgaGF2ZSBhbiBp ZGVudGljYWwgY29weQpwZW5kaW5nLgoKVGhlIHNwZWNpYWwgZXZlbnRzICJA Li4uIiBhcmUgZXhjbHVkZWQgZnJvbSB0aGF0IGhhbmRsaW5nIGFzIHRoZXJl IGFyZQprbm93biB1c2UgY2FzZXMgd2hlcmUgdGhlIGhhbmRsZXIgaXMgcmVs eWluZyBvbiBlYWNoIGV2ZW50IHRvIGJlIHNlbnQKaW5kaXZpZHVhbGx5LgoK VGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRlZC1ieTogSnVsaWVu IEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVs aWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuYwppbmRleCA0ODhkNTQwZjNhMzIuLmYxZmE5 N2I4Y2Y1MCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2NvcmUuYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5j CkBAIC05MTYsNiArOTE2LDcgQEAgdm9pZCBzZW5kX3JlcGx5KHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSwK IAliZGF0YS0+aW5oZHIgPSB0cnVlOwogCWJkYXRhLT51c2VkID0gMDsKIAli ZGF0YS0+dGltZW91dF9tc2VjID0gMDsKKwliZGF0YS0+d2F0Y2hfZXZlbnQg PSBmYWxzZTsKIAogCWlmIChsZW4gPD0gREVGQVVMVF9CVUZGRVJfU0laRSkK IAkJYmRhdGEtPmJ1ZmZlciA9IGJkYXRhLT5kZWZhdWx0X2J1ZmZlcjsKQEAg LTk0OCw3ICs5NDksNyBAQCB2b2lkIHNlbmRfcmVwbHkoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlLAogdm9p ZCBzZW5kX2V2ZW50KHN0cnVjdCBidWZmZXJlZF9kYXRhICpyZXEsIHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAogCQljb25zdCBjaGFyICpwYXRoLCBjb25z dCBjaGFyICp0b2tlbikKIHsKLQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRh dGE7CisJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmJkYXRhLCAqYmQ7CiAJdW5z aWduZWQgaW50IGxlbjsKIAogCWxlbiA9IHN0cmxlbihwYXRoKSArIDEgKyBz dHJsZW4odG9rZW4pICsgMTsKQEAgLTk3MCwxMiArOTcxLDI5IEBAIHZvaWQg c2VuZF9ldmVudChzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqcmVxLCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKIAliZGF0YS0+aGRyLm1zZy50eXBlID0gWFNf V0FUQ0hfRVZFTlQ7CiAJYmRhdGEtPmhkci5tc2cubGVuID0gbGVuOwogCisJ LyoKKwkgKiBDaGVjayB3aGV0aGVyIGFuIGlkZW50aWNhbCBldmVudCBpcyBw ZW5kaW5nIGFscmVhZHkuCisJICogU3BlY2lhbCBldmVudHMgYXJlIGV4Y2x1 ZGVkIGZyb20gdGhhdCBjaGVjay4KKwkgKi8KKwlpZiAocGF0aFswXSAhPSAn QCcpIHsKKwkJbGlzdF9mb3JfZWFjaF9lbnRyeShiZCwgJmNvbm4tPm91dF9s aXN0LCBsaXN0KSB7CisJCQlpZiAoYmQtPndhdGNoX2V2ZW50ICYmIGJkLT5o ZHIubXNnLmxlbiA9PSBsZW4gJiYKKwkJCSAgICAhbWVtY21wKGJkYXRhLT5i dWZmZXIsIGJkLT5idWZmZXIsIGxlbikpIHsKKwkJCQl0cmFjZSgiZHJvcHBp bmcgZHVwbGljYXRlIHdhdGNoICVzICVzIGZvciBkb21haW4gJXVcbiIsCisJ CQkJICAgICAgcGF0aCwgdG9rZW4sIGNvbm4tPmlkKTsKKwkJCQl0YWxsb2Nf ZnJlZShiZGF0YSk7CisJCQkJcmV0dXJuOworCQkJfQorCQl9CisJfQorCiAJ aWYgKHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyAmJiBkb21haW5faXNfdW5w cml2aWxlZ2VkKGNvbm4pKSB7CiAJCWJkYXRhLT50aW1lb3V0X21zZWMgPSBn ZXRfbm93X21zZWMoKSArIHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIAkJ aWYgKCFjb25uLT50aW1lb3V0X21zZWMpCiAJCQljb25uLT50aW1lb3V0X21z ZWMgPSBiZGF0YS0+dGltZW91dF9tc2VjOwogCX0KIAorCWJkYXRhLT53YXRj aF9ldmVudCA9IHRydWU7CiAJYmRhdGEtPnBlbmQucmVxID0gcmVxOwogCWlm IChyZXEpCiAJCXJlcS0+cGVuZC5yZWYuZXZlbnRfY250Kys7CmRpZmYgLS1n aXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCBkYjA5ZjQ2M2E2NTcu LmI5YjUwZTgxYzdiNCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5oCkBAIC02Miw2ICs2Miw5IEBAIHN0cnVjdCBidWZmZXJlZF9kYXRh CiAJLyogQXJlIHdlIHN0aWxsIGRvaW5nIHRoZSBoZWFkZXI/ICovCiAJYm9v bCBpbmhkcjsKIAorCS8qIElzIHRoaXMgYSB3YXRjaCBldmVudD8gKi8KKwli b29sIHdhdGNoX2V2ZW50OworCiAJLyogSG93IGZhciBhcmUgd2U/ICovCiAJ dW5zaWduZWQgaW50IHVzZWQ7CiAK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-07.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-07.patch" Content-Transfer-Encoding: base64 RnJvbSA1ZWFjNjkyYjg0MTYzM2JlM2U4NWYwMTI1YzU5ZmEwMmFmMTAzOTg5 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGZpeCBjb25u ZWN0aW9uLT5pZCB1c2FnZQoKRG9uJ3QgdXNlIGNvbm4tPmlkIGZvciBwcml2 aWxlZ2UgY2hlY2tzLCBidXQgZG9tYWluX2lzX3VucHJpdmlsZWdlZCgpLgoK VGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRlZC1ieTogSnVsaWVu IEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVs aWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuYwppbmRleCA3YjQzMDBlZjc3Nzcu LmFkYjhkNTFiMDQzYiAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvbnRyb2wuYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29udHJvbC5jCkBAIC04OTEsNyArODkxLDcgQEAgaW50IGRvX2NvbnRy b2woc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbikKIAl1bnNpZ25lZCBpbnQgY21kLCBudW0sIG9mZjsKIAljaGFy ICoqdmVjID0gTlVMTDsKIAotCWlmIChjb25uLT5pZCAhPSAwKQorCWlmIChk b21haW5faXNfdW5wcml2aWxlZ2VkKGNvbm4pKQogCQlyZXR1cm4gRUFDQ0VT OwogCiAJb2ZmID0gZ2V0X3N0cmluZyhpbiwgMCk7CmRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCBiOWI1MGU4MWM3YjQuLmIxYTcw NDg4Yjk4OSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2NvcmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5o CkBAIC0xMjMsNyArMTIzLDcgQEAgc3RydWN0IGNvbm5lY3Rpb24KIAkvKiBU aGUgaW5kZXggb2YgcG9sbGZkIGluIGdsb2JhbCBwb2xsZmQgYXJyYXkgKi8K IAlpbnQgcG9sbGZkX2lkeDsKIAotCS8qIFdobyBhbSBJPyAwIGZvciBzb2Nr ZXQgY29ubmVjdGlvbnMuICovCisJLyogV2hvIGFtIEk/IERvbWlkIG9mIGNv bm5lY3Rpb24uICovCiAJdW5zaWduZWQgaW50IGlkOwogCiAJLyogSXMgdGhp cyBjb25uZWN0aW9uIGlnbm9yZWQ/ICovCmRpZmYgLS1naXQgYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4IDU0NDMyOTA3ZmM3 Ni4uZWUxYjA5MDMxYTNiIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpAQCAtNDc3LDcgKzQ3Nyw4IEBAIGlu dCBkb190cmFuc2FjdGlvbl9zdGFydChzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCWlmIChjb25uLT50cmFu c2FjdGlvbikKIAkJcmV0dXJuIEVCVVNZOwogCi0JaWYgKGNvbm4tPmlkICYm IGNvbm4tPnRyYW5zYWN0aW9uX3N0YXJ0ZWQgPiBxdW90YV9tYXhfdHJhbnNh Y3Rpb24pCisJaWYgKGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikgJiYK KwkgICAgY29ubi0+dHJhbnNhY3Rpb25fc3RhcnRlZCA+IHF1b3RhX21heF90 cmFuc2FjdGlvbikKIAkJcmV0dXJuIEVOT1NQQzsKIAogCS8qIEF0dGFjaCB0 cmFuc2FjdGlvbiB0byBpbnB1dCBmb3IgYXV0b2ZyZWUgdW50aWwgaXQncyBj b21wbGV0ZSAqLwo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-08.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-08.patch" Content-Transfer-Encoding: base64 RnJvbSBmOWYzMTcxNDQxYjVmY2IzMzM5Y2Y2MTI0MDA3OTRmYzI2Y2QyZWMy IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHNpbXBsaWZ5 IGFuZCBmaXggcGVyIGRvbWFpbiBub2RlIGFjY291bnRpbmcKClRoZSBhY2Nv dW50aW5nIG9mIG5vZGVzIGNhbiBiZSBzaW1wbGlmaWVkIG5vdyB0aGF0IGVh Y2ggY29ubmVjdGlvbgpob2xkcyB0aGUgYXNzb2NpYXRlZCBkb21pZC4KCkZp eCB0aGUgbm9kZSBhY2NvdW50aW5nIHRvIGNvdmVyIG5vZGVzIGNyZWF0ZWQg Zm9yIGEgZG9tYWluIGJlZm9yZSBpdApoYXMgYmVlbiBpbnRyb2R1Y2VkLiBU aGlzIHJlcXVpcmVzIHRvIHJlYWN0IHByb3Blcmx5IHRvIGFuIGFsbG9jYXRp b24KZmFpbHVyZSBpbnNpZGUgZG9tYWluX2VudHJ5X2luYygpIGJ5IHJldHVy bmluZyBhbiBlcnJvciBjb2RlLgoKRXNwZWNpYWxseSBpbiBlcnJvciBwYXRo cyB0aGUgbm9kZSBhY2NvdW50aW5nIGhhcyB0byBiZSBmaXhlZCBpbiBzb21l CmNhc2VzLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYgLyBDVkUtMjAyMi00 MjMxMy4KClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6 b24uY29tPgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NA c3VzZS5jb20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBh bWF6b24uY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5j CmluZGV4IGYxZmE5N2I4Y2Y1MC4uNjkyZDg2M2ZjZTM1IDEwMDY0NAotLS0g YS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTYzOCw3ICs2MzgsNyBA QCBzdHJ1Y3Qgbm9kZSAqcmVhZF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCBjb25zdCB2b2lkICpjdHgsCiAKIAkvKiBQZXJtaXNzaW9ucyBhcmUg c3RydWN0IHhzX3Blcm1pc3Npb25zLiAqLwogCW5vZGUtPnBlcm1zLnAgPSBo ZHItPnBlcm1zOwotCWlmIChkb21haW5fYWRqdXN0X25vZGVfcGVybXMobm9k ZSkpIHsKKwlpZiAoZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKGNvbm4sIG5v ZGUpKSB7CiAJCXRhbGxvY19mcmVlKG5vZGUpOwogCQlyZXR1cm4gTlVMTDsK IAl9CkBAIC02NjAsNyArNjYwLDcgQEAgaW50IHdyaXRlX25vZGVfcmF3KHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5LCBzdHJ1Y3Qg bm9kZSAqbm9kZSwKIAl2b2lkICpwOwogCXN0cnVjdCB4c190ZGJfcmVjb3Jk X2hkciAqaGRyOwogCi0JaWYgKGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhu b2RlKSkKKwlpZiAoZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKGNvbm4sIG5v ZGUpKQogCQlyZXR1cm4gZXJybm87CiAKIAlkYXRhLmRzaXplID0gc2l6ZW9m KCpoZHIpCkBAIC0xMjcyLDEzICsxMjcyLDE3IEBAIHN0YXRpYyBzdHJ1Y3Qg bm9kZSAqY29uc3RydWN0X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IGNvbnN0IHZvaWQgKmN0eCwKIAlyZXR1cm4gTlVMTDsKIH0KIAotc3RhdGlj IGludCBkZXN0cm95X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBub2RlICpub2RlKQorc3RhdGljIHZvaWQgZGVzdHJveV9ub2RlX3Jt KHN0cnVjdCBub2RlICpub2RlKQogewogCWlmIChzdHJlcShub2RlLT5uYW1l LCAiLyIpKQogCQljb3JydXB0KE5VTEwsICJEZXN0cm95aW5nIHJvb3Qgbm9k ZSEiKTsKIAogCXRkYl9kZWxldGUodGRiX2N0eCwgbm9kZS0+a2V5KTsKK30K IAorc3RhdGljIGludCBkZXN0cm95X25vZGUoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQoreworCWRlc3Ryb3lfbm9kZV9y bShub2RlKTsKIAlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5vZGUpOwogCiAJ LyoKQEAgLTEzMjgsOCArMTMzMiwxMiBAQCBzdGF0aWMgc3RydWN0IG5vZGUg KmNyZWF0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2 b2lkICpjdHgsCiAJCQlnb3RvIGVycjsKIAogCQkvKiBBY2NvdW50IGZvciBu ZXcgbm9kZSAqLwotCQlpZiAoaS0+cGFyZW50KQotCQkJZG9tYWluX2VudHJ5 X2luYyhjb25uLCBpKTsKKwkJaWYgKGktPnBhcmVudCkgeworCQkJaWYgKGRv bWFpbl9lbnRyeV9pbmMoY29ubiwgaSkpIHsKKwkJCQlkZXN0cm95X25vZGVf cm0oaSk7CisJCQkJcmV0dXJuIE5VTEw7CisJCQl9CisJCX0KIAl9CiAKIAly ZXR1cm4gbm9kZTsKQEAgLTE2MTQsMTAgKzE2MjIsMjcgQEAgc3RhdGljIGlu dCBkb19zZXRfcGVybXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbikKIAlvbGRfcGVybXMgPSBub2RlLT5wZXJt czsKIAlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5vZGUpOwogCW5vZGUtPnBl cm1zID0gcGVybXM7Ci0JZG9tYWluX2VudHJ5X2luYyhjb25uLCBub2RlKTsK KwlpZiAoZG9tYWluX2VudHJ5X2luYyhjb25uLCBub2RlKSkgeworCQlub2Rl LT5wZXJtcyA9IG9sZF9wZXJtczsKKwkJLyoKKwkJICogVGhpcyBzaG91bGQg bmV2ZXIgZmFpbCBiZWNhdXNlIHdlIGhhZCBhIHJlZmVyZW5jZSBvbiB0aGUK KwkJICogZG9tYWluIGJlZm9yZSBhbmQgWGVuc3RvcmVkIGlzIHNpbmdsZS10 aHJlYWRlZC4KKwkJICovCisJCWRvbWFpbl9lbnRyeV9pbmMoY29ubiwgbm9k ZSk7CisJCXJldHVybiBFTk9NRU07CisJfQorCisJaWYgKHdyaXRlX25vZGUo Y29ubiwgbm9kZSwgZmFsc2UpKSB7CisJCWludCBzYXZlZF9lcnJubyA9IGVy cm5vOwogCi0JaWYgKHdyaXRlX25vZGUoY29ubiwgbm9kZSwgZmFsc2UpKQor CQlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5vZGUpOworCQlub2RlLT5wZXJt cyA9IG9sZF9wZXJtczsKKwkJLyogTm8gZmFpbHVyZSBwb3NzaWJsZSBhcyBh Ym92ZS4gKi8KKwkJZG9tYWluX2VudHJ5X2luYyhjb25uLCBub2RlKTsKKwor CQllcnJubyA9IHNhdmVkX2Vycm5vOwogCQlyZXR1cm4gZXJybm87CisJfQog CiAJZmlyZV93YXRjaGVzKGNvbm4sIGluLCBuYW1lLCBub2RlLCBmYWxzZSwg Jm9sZF9wZXJtcyk7CiAJc2VuZF9hY2soY29ubiwgWFNfU0VUX1BFUk1TKTsK QEAgLTMxMjIsNyArMzE0Nyw5IEBAIHZvaWQgcmVhZF9zdGF0ZV9ub2RlKGNv bnN0IHZvaWQgKmN0eCwgY29uc3Qgdm9pZCAqc3RhdGUpCiAJc2V0X3RkYl9r ZXkobmFtZSwgJmtleSk7CiAJaWYgKHdyaXRlX25vZGVfcmF3KE5VTEwsICZr ZXksIG5vZGUsIHRydWUpKQogCQliYXJmKCJ3cml0ZSBub2RlIGVycm9yIHJl c3RvcmluZyBub2RlIik7Ci0JZG9tYWluX2VudHJ5X2luYygmY29ubiwgbm9k ZSk7CisKKwlpZiAoZG9tYWluX2VudHJ5X2luYygmY29ubiwgbm9kZSkpCisJ CWJhcmYoIm5vZGUgYWNjb3VudGluZyBlcnJvciByZXN0b3Jpbmcgbm9kZSIp OwogCiAJdGFsbG9jX2ZyZWUobm9kZSk7CiB9CmRpZmYgLS1naXQgYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMgYi90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfZG9tYWluLmMKaW5kZXggODUwMDg1YTkyYzc2Li4yNjA5 NTJlMDkwOTYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9kb21haW4uYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9t YWluLmMKQEAgLTE2LDYgKzE2LDcgQEAKICAgICBhbG9uZyB3aXRoIHRoaXMg cHJvZ3JhbTsgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNl bnNlcy8+LgogKi8KIAorI2luY2x1ZGUgPGFzc2VydC5oPgogI2luY2x1ZGUg PHN0ZGlvLmg+CiAjaW5jbHVkZSA8c3lzL21tYW4uaD4KICNpbmNsdWRlIDx1 bmlzdGQuaD4KQEAgLTM2Myw2ICszNjQsMTggQEAgc3RhdGljIHN0cnVjdCBk b21haW4gKmZpbmRfb3JfYWxsb2NfZG9tYWluKGNvbnN0IHZvaWQgKmN0eCwg dW5zaWduZWQgaW50IGRvbWlkKQogCXJldHVybiBkb21haW4gPyA6IGFsbG9j X2RvbWFpbihjdHgsIGRvbWlkKTsKIH0KIAorc3RhdGljIHN0cnVjdCBkb21h aW4gKmZpbmRfb3JfYWxsb2NfZXhpc3RpbmdfZG9tYWluKHVuc2lnbmVkIGlu dCBkb21pZCkKK3sKKwlzdHJ1Y3QgZG9tYWluICpkb21haW47CisJeGNfZG9t aW5mb190IGRvbWluZm87CisKKwlkb21haW4gPSBmaW5kX2RvbWFpbl9zdHJ1 Y3QoZG9taWQpOworCWlmICghZG9tYWluICYmIGdldF9kb21haW5faW5mbyhk b21pZCwgJmRvbWluZm8pKQorCQlkb21haW4gPSBhbGxvY19kb21haW4oTlVM TCwgZG9taWQpOworCisJcmV0dXJuIGRvbWFpbjsKK30KKwogc3RhdGljIGlu dCBuZXdfZG9tYWluKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgaW50IHBvcnQs IGJvb2wgcmVzdG9yZSkKIHsKIAlpbnQgcmM7CkBAIC03ODIsMzAgKzc5NSwy OCBAQCB2b2lkIGRvbWFpbl9kZWluaXQodm9pZCkKIAkJeGVuZXZ0Y2huX3Vu YmluZCh4Y2VfaGFuZGxlLCB2aXJxX3BvcnQpOwogfQogCi12b2lkIGRvbWFp bl9lbnRyeV9pbmMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlKQoraW50IGRvbWFpbl9lbnRyeV9pbmMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQogewogCXN0cnVjdCBk b21haW4gKmQ7CisJdW5zaWduZWQgaW50IGRvbWlkOwogCiAJaWYgKCFjb25u KQotCQlyZXR1cm47CisJCXJldHVybiAwOwogCi0JaWYgKG5vZGUtPnBlcm1z LnAgJiYgbm9kZS0+cGVybXMucFswXS5pZCAhPSBjb25uLT5pZCkgewotCQlp ZiAoY29ubi0+dHJhbnNhY3Rpb24pIHsKLQkJCXRyYW5zYWN0aW9uX2VudHJ5 X2luYyhjb25uLT50cmFuc2FjdGlvbiwKLQkJCQlub2RlLT5wZXJtcy5wWzBd LmlkKTsKLQkJfSBlbHNlIHsKLQkJCWQgPSBmaW5kX2RvbWFpbl9ieV9kb21p ZChub2RlLT5wZXJtcy5wWzBdLmlkKTsKLQkJCWlmIChkKQotCQkJCWQtPm5i ZW50cnkrKzsKLQkJfQotCX0gZWxzZSBpZiAoY29ubi0+ZG9tYWluKSB7Ci0J CWlmIChjb25uLT50cmFuc2FjdGlvbikgewotCQkJdHJhbnNhY3Rpb25fZW50 cnlfaW5jKGNvbm4tPnRyYW5zYWN0aW9uLAotCQkJCWNvbm4tPmRvbWFpbi0+ ZG9taWQpOwotIAkJfSBlbHNlIHsKLSAJCQljb25uLT5kb21haW4tPm5iZW50 cnkrKzsKLQkJfQorCWRvbWlkID0gbm9kZS0+cGVybXMucCA/IG5vZGUtPnBl cm1zLnBbMF0uaWQgOiBjb25uLT5pZDsKKworCWlmIChjb25uLT50cmFuc2Fj dGlvbikgeworCQl0cmFuc2FjdGlvbl9lbnRyeV9pbmMoY29ubi0+dHJhbnNh Y3Rpb24sIGRvbWlkKTsKKwl9IGVsc2UgeworCQlkID0gKGRvbWlkID09IGNv bm4tPmlkICYmIGNvbm4tPmRvbWFpbikgPyBjb25uLT5kb21haW4KKwkJICAg IDogZmluZF9vcl9hbGxvY19leGlzdGluZ19kb21haW4oZG9taWQpOworCQlp ZiAoZCkKKwkJCWQtPm5iZW50cnkrKzsKKwkJZWxzZQorCQkJcmV0dXJuIEVO T01FTTsKIAl9CisKKwlyZXR1cm4gMDsKIH0KIAogLyoKQEAgLTg0MSw3ICs4 NTIsNyBAQCBzdGF0aWMgaW50IGNoa19kb21haW5fZ2VuZXJhdGlvbih1bnNp Z25lZCBpbnQgZG9taWQsIHVpbnQ2NF90IGdlbikKICAqIFJlbW92ZSBwZXJt aXNzaW9ucyBmb3Igbm8gbG9uZ2VyIGV4aXN0aW5nIGRvbWFpbnMgaW4gb3Jk ZXIgdG8gYXZvaWQgYSBuZXcKICAqIGRvbWFpbiB3aXRoIHRoZSBzYW1lIGRv bWlkIGluaGVyaXRpbmcgdGhlIHBlcm1pc3Npb25zLgogICovCi1pbnQgZG9t YWluX2FkanVzdF9ub2RlX3Blcm1zKHN0cnVjdCBub2RlICpub2RlKQoraW50 IGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgc3RydWN0IG5vZGUgKm5vZGUpCiB7CiAJdW5zaWduZWQgaW50IGk7 CiAJaW50IHJldDsKQEAgLTg1MSw4ICs4NjIsMTQgQEAgaW50IGRvbWFpbl9h ZGp1c3Rfbm9kZV9wZXJtcyhzdHJ1Y3Qgbm9kZSAqbm9kZSkKIAkJcmV0dXJu IGVycm5vOwogCiAJLyogSWYgdGhlIG93bmVyIGRvZXNuJ3QgZXhpc3QgYW55 IGxvbmdlciBnaXZlIGl0IHRvIHByaXYgZG9tYWluLiAqLwotCWlmICghcmV0 KQorCWlmICghcmV0KSB7CisJCS8qCisJCSAqIEluIHRoZW9yeSB3ZSdkIG5l ZWQgdG8gdXBkYXRlIHRoZSBudW1iZXIgb2YgZG9tMCBub2RlcyBoZXJlLAor CQkgKiBidXQgd2UgY291bGQgYmUgY2FsbGVkIGZvciBhIHJlYWQgb2YgdGhl IG5vZGUuIFNvIGJldHRlcgorCQkgKiBhdm9pZCB0aGUgcmlzayB0byBvdmVy ZmxvdyB0aGUgbm9kZSBjb3VudCBvZiBkb20wLgorCQkgKi8KIAkJbm9kZS0+ cGVybXMucFswXS5pZCA9IHByaXZfZG9taWQ7CisJfQogCiAJZm9yIChpID0g MTsgaSA8IG5vZGUtPnBlcm1zLm51bTsgaSsrKSB7CiAJCWlmIChub2RlLT5w ZXJtcy5wW2ldLnBlcm1zICYgWFNfUEVSTV9JR05PUkUpCkBAIC04NzEsMjUg Kzg4OCwyNSBAQCBpbnQgZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKHN0cnVj dCBub2RlICpub2RlKQogdm9pZCBkb21haW5fZW50cnlfZGVjKHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSkKIHsKIAlzdHJ1 Y3QgZG9tYWluICpkOworCXVuc2lnbmVkIGludCBkb21pZDsKIAogCWlmICgh Y29ubikKIAkJcmV0dXJuOwogCi0JaWYgKG5vZGUtPnBlcm1zLnAgJiYgbm9k ZS0+cGVybXMucFswXS5pZCAhPSBjb25uLT5pZCkgewotCQlpZiAoY29ubi0+ dHJhbnNhY3Rpb24pIHsKLQkJCXRyYW5zYWN0aW9uX2VudHJ5X2RlYyhjb25u LT50cmFuc2FjdGlvbiwKLQkJCQlub2RlLT5wZXJtcy5wWzBdLmlkKTsKLQkJ fSBlbHNlIHsKLQkJCWQgPSBmaW5kX2RvbWFpbl9ieV9kb21pZChub2RlLT5w ZXJtcy5wWzBdLmlkKTsKLQkJCWlmIChkICYmIGQtPm5iZW50cnkpCi0JCQkJ ZC0+bmJlbnRyeS0tOwotCQl9Ci0JfSBlbHNlIGlmIChjb25uLT5kb21haW4g JiYgY29ubi0+ZG9tYWluLT5uYmVudHJ5KSB7Ci0JCWlmIChjb25uLT50cmFu c2FjdGlvbikgewotCQkJdHJhbnNhY3Rpb25fZW50cnlfZGVjKGNvbm4tPnRy YW5zYWN0aW9uLAotCQkJCWNvbm4tPmRvbWFpbi0+ZG9taWQpOworCWRvbWlk ID0gbm9kZS0+cGVybXMucCA/IG5vZGUtPnBlcm1zLnBbMF0uaWQgOiBjb25u LT5pZDsKKworCWlmIChjb25uLT50cmFuc2FjdGlvbikgeworCQl0cmFuc2Fj dGlvbl9lbnRyeV9kZWMoY29ubi0+dHJhbnNhY3Rpb24sIGRvbWlkKTsKKwl9 IGVsc2UgeworCQlkID0gKGRvbWlkID09IGNvbm4tPmlkICYmIGNvbm4tPmRv bWFpbikgPyBjb25uLT5kb21haW4KKwkJICAgIDogZmluZF9kb21haW5fc3Ry dWN0KGRvbWlkKTsKKwkJaWYgKGQpIHsKKwkJCWQtPm5iZW50cnktLTsKIAkJ fSBlbHNlIHsKLQkJCWNvbm4tPmRvbWFpbi0+bmJlbnRyeS0tOworCQkJZXJy bm8gPSBFTk9FTlQ7CisJCQljb3JydXB0KGNvbm4sCisJCQkJIk5vZGUgXCIl c1wiIG93bmVkIGJ5IG5vbi1leGlzdGluZyBkb21haW4gJXVcbiIsCisJCQkJ bm9kZS0+bmFtZSwgZG9taWQpOwogCQl9CiAJfQogfQpAQCAtODk5LDEzICs5 MTYsMjMgQEAgaW50IGRvbWFpbl9lbnRyeV9maXgodW5zaWduZWQgaW50IGRv bWlkLCBpbnQgbnVtLCBib29sIHVwZGF0ZSkKIAlzdHJ1Y3QgZG9tYWluICpk OwogCWludCBjbnQ7CiAKLQlkID0gZmluZF9kb21haW5fYnlfZG9taWQoZG9t aWQpOwotCWlmICghZCkKLQkJcmV0dXJuIDA7CisJaWYgKHVwZGF0ZSkgewor CQlkID0gZmluZF9kb21haW5fc3RydWN0KGRvbWlkKTsKKwkJYXNzZXJ0KGQp OworCX0gZWxzZSB7CisJCS8qCisJCSAqIFdlIGFyZSBjYWxsZWQgZmlyc3Qg d2l0aCB1cGRhdGUgPT0gZmFsc2UgaW4gb3JkZXIgdG8gY2F0Y2gKKwkJICog YW55IGVycm9yLiBTbyBkbyBhIHBvc3NpYmxlIGFsbG9jYXRpb24gYW5kIGNo ZWNrIGZvciBlcnJvcgorCQkgKiBvbmx5IGluIHRoaXMgY2FzZSwgYXMgaW4g dGhlIGNhc2Ugb2YgdXBkYXRlID09IHRydWUgbm90aGluZworCQkgKiBjYW4g Z28gd3JvbmcgYW55bW9yZSBhcyB0aGUgYWxsb2NhdGlvbiBhbHJlYWR5IGhh cHBlbmVkLgorCQkgKi8KKwkJZCA9IGZpbmRfb3JfYWxsb2NfZXhpc3Rpbmdf ZG9tYWluKGRvbWlkKTsKKwkJaWYgKCFkKQorCQkJcmV0dXJuIC0xOworCX0K IAogCWNudCA9IGQtPm5iZW50cnkgKyBudW07Ci0JaWYgKGNudCA8IDApCi0J CWNudCA9IDA7CisJYXNzZXJ0KGNudCA+PSAwKTsKIAogCWlmICh1cGRhdGUp CiAJCWQtPm5iZW50cnkgPSBjbnQ7CmRpZmYgLS1naXQgYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfZG9tYWluLmggYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmgKaW5kZXggNGY1MWIwMDUyOTFhLi5kNjUxOTkwNGQ4 MzEgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21h aW4uaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgK QEAgLTU0LDEwICs1NCwxMCBAQCBjb25zdCBjaGFyICpnZXRfaW1wbGljaXRf cGF0aChjb25zdCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7CiBib29sIGRv bWFpbl9pc191bnByaXZpbGVnZWQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4p OwogCiAvKiBSZW1vdmUgbm9kZSBwZXJtaXNzaW9ucyBmb3Igbm8gbG9uZ2Vy IGV4aXN0aW5nIGRvbWFpbnMuICovCi1pbnQgZG9tYWluX2FkanVzdF9ub2Rl X3Blcm1zKHN0cnVjdCBub2RlICpub2RlKTsKK2ludCBkb21haW5fYWRqdXN0 X25vZGVfcGVybXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlKTsKIAogLyogUXVvdGEgbWFuaXB1bGF0aW9uICovCi12b2lk IGRvbWFpbl9lbnRyeV9pbmMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBub2RlICopOworaW50IGRvbWFpbl9lbnRyeV9pbmMoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICopOwogdm9pZCBkb21haW5f ZW50cnlfZGVjKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9k ZSAqKTsKIGludCBkb21haW5fZW50cnlfZml4KHVuc2lnbmVkIGludCBkb21p ZCwgaW50IG51bSwgYm9vbCB1cGRhdGUpOwogaW50IGRvbWFpbl9lbnRyeShz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7CmRpZmYgLS1naXQgYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4IGVlMWIwOTAzMWEz Yi4uODZjYWY2YzM5OGJlIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpAQCAtNTE5LDggKzUxOSwxMiBAQCBz dGF0aWMgaW50IHRyYW5zYWN0aW9uX2ZpeF9kb21haW5zKHN0cnVjdCB0cmFu c2FjdGlvbiAqdHJhbnMsIGJvb2wgdXBkYXRlKQogCiAJbGlzdF9mb3JfZWFj aF9lbnRyeShkLCAmdHJhbnMtPmNoYW5nZWRfZG9tYWlucywgbGlzdCkgewog CQljbnQgPSBkb21haW5fZW50cnlfZml4KGQtPmRvbWlkLCBkLT5uYmVudHJ5 LCB1cGRhdGUpOwotCQlpZiAoIXVwZGF0ZSAmJiBjbnQgPj0gcXVvdGFfbmJf ZW50cnlfcGVyX2RvbWFpbikKLQkJCXJldHVybiBFTk9TUEM7CisJCWlmICgh dXBkYXRlKSB7CisJCQlpZiAoY250ID49IHF1b3RhX25iX2VudHJ5X3Blcl9k b21haW4pCisJCQkJcmV0dXJuIEVOT1NQQzsKKwkJCWlmIChjbnQgPCAwKQor CQkJCXJldHVybiBFTk9NRU07CisJCX0KIAl9CiAKIAlyZXR1cm4gMDsK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-09.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-09.patch" Content-Transfer-Encoding: base64 RnJvbSA3MWFhYzZmN2U4OWQ1YzEwMWFkYjllODJlZWE3MDMxZTE2ZDM0ZTQ2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxpbWl0IG1h eCBudW1iZXIgb2Ygbm9kZXMgYWNjZXNzZWQgaW4gYSB0cmFuc2FjdGlvbgoK VG9kYXkgYSBndWVzdCBpcyBmcmVlIHRvIGFjY2VzcyBhcyBtYW55IG5vZGVz IGluIGEgc2luZ2xlIHRyYW5zYWN0aW9uCmFzIGl0IHdhbnRzLiBUaGlzIGNh biBsZWFkIHRvIHVuYm91bmRlZCBtZW1vcnkgY29uc3VtcHRpb24gaW4gWGVu c3RvcmUKYXMgdGhlcmUgaXMgdGhlIG5lZWQgdG8ga2VlcCB0cmFjayBvZiBh bGwgbm9kZXMgaGF2aW5nIGJlZW4gYWNjZXNzZWQKZHVyaW5nIGEgdHJhbnNh Y3Rpb24uCgpJbiBveGVuc3RvcmVkIHRoZSBudW1iZXIgb2YgcmVxdWVzdHMg aW4gYSB0cmFuc2FjdGlvbiBpcyBiZWluZyBsaW1pdGVkCnZpYSBhIHF1b3Rh IG1heHJlcXVlc3RzIChkZWZhdWx0IGlzIDEwMjQpLiBBcyBtdWx0aXBsZSBh Y2Nlc3NlcyBvZiBhCm5vZGUgYXJlIG5vdCBwcm9ibGVtYXRpYyBpbiBDIFhl bnN0b3JlLCBsaW1pdCB0aGUgbnVtYmVyIG9mIGFjY2Vzc2VkCm5vZGVzLgoK SW4gb3JkZXIgdG8gbGV0IHJlYWRfbm9kZSgpIGRldGVjdCBhIHF1b3RhIGVy cm9yIGluIGNhc2UgdG9vIG1hbnkgbm9kZXMKYXJlIGJlaW5nIGFjY2Vzc2Vk LCBjaGVjayB0aGUgcmV0dXJuIHZhbHVlIG9mIGFjY2Vzc19ub2RlKCkgYW5k IHJldHVybgpOVUxMIGluIGNhc2UgYW4gZXJyb3IgaGFzIGJlZW4gc2Vlbi4g SW50cm9kdWNlIF9fbXVzdF9jaGVjayBhbmQgYWRkIGl0CnRvIHRoZSBhY2Nl c3Nfbm9kZSgpIHByb3RvdHlwZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2 IC8gQ1ZFLTIwMjItNDIzMTQuCgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxs IDxqZ3JhbGxAYW1hem9uLmNvbT4KU3VnZ2VzdGVkLWJ5OiBKdWxpZW4gR3Jh bGwgPGp1bGllbkB4ZW4ub3JnPgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdy b3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3Jh bGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL2lu Y2x1ZGUveGVuLXRvb2xzL2xpYnMuaCBiL3Rvb2xzL2luY2x1ZGUveGVuLXRv b2xzL2xpYnMuaAppbmRleCBhMTZlMGMzODA3MDkuLmJhZmM5MGUyZjYwMyAx MDA2NDQKLS0tIGEvdG9vbHMvaW5jbHVkZS94ZW4tdG9vbHMvbGlicy5oCisr KyBiL3Rvb2xzL2luY2x1ZGUveGVuLXRvb2xzL2xpYnMuaApAQCAtNjMsNCAr NjMsOCBAQAogI2RlZmluZSBST1VORFVQKF94LF93KSAoKCh1bnNpZ25lZCBs b25nKShfeCkrKDFVTDw8KF93KSktMSkgJiB+KCgxVUw8PChfdykpLTEpKQog I2VuZGlmCiAKKyNpZm5kZWYgX19tdXN0X2NoZWNrCisjZGVmaW5lIF9fbXVz dF9jaGVjayBfX2F0dHJpYnV0ZV9fKChfX3dhcm5fdW51c2VkX3Jlc3VsdF9f KSkKKyNlbmRpZgorCiAjZW5kaWYJLyogX19YRU5fVE9PTFNfTElCU19fICov CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5j IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwppbmRleCA2OTJk ODYzZmNlMzUuLmY4MzVhYTFiMmYxZiAxMDA2NDQKLS0tIGEvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfY29yZS5jCkBAIC0xMDYsNiArMTA2LDcgQEAgaW50IHF1b3Rh X25iX3dhdGNoX3Blcl9kb21haW4gPSAxMjg7CiBpbnQgcXVvdGFfbWF4X2Vu dHJ5X3NpemUgPSAyMDQ4OyAvKiAySyAqLwogaW50IHF1b3RhX21heF90cmFu c2FjdGlvbiA9IDEwOwogaW50IHF1b3RhX25iX3Blcm1zX3Blcl9ub2RlID0g NTsKK2ludCBxdW90YV90cmFuc19ub2RlcyA9IDEwMjQ7CiBpbnQgcXVvdGFf bWF4X3BhdGhfbGVuID0gWEVOU1RPUkVfUkVMX1BBVEhfTUFYOwogaW50IHF1 b3RhX3JlcV9vdXRzdGFuZGluZyA9IDIwOwogCkBAIC01OTUsNiArNTk2LDcg QEAgc3RydWN0IG5vZGUgKnJlYWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCVREQl9EQVRBIGtleSwgZGF0YTsK IAlzdHJ1Y3QgeHNfdGRiX3JlY29yZF9oZHIgKmhkcjsKIAlzdHJ1Y3Qgbm9k ZSAqbm9kZTsKKwlpbnQgZXJyOwogCiAJbm9kZSA9IHRhbGxvYyhjdHgsIHN0 cnVjdCBub2RlKTsKIAlpZiAoIW5vZGUpIHsKQEAgLTYxNiwxNCArNjE4LDEz IEBAIHN0cnVjdCBub2RlICpyZWFkX25vZGUoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAlpZiAoZGF0YS5kcHRyID09IE5V TEwpIHsKIAkJaWYgKHRkYl9lcnJvcih0ZGJfY3R4KSA9PSBUREJfRVJSX05P RVhJU1QpIHsKIAkJCW5vZGUtPmdlbmVyYXRpb24gPSBOT19HRU5FUkFUSU9O OwotCQkJYWNjZXNzX25vZGUoY29ubiwgbm9kZSwgTk9ERV9BQ0NFU1NfUkVB RCwgTlVMTCk7Ci0JCQllcnJubyA9IEVOT0VOVDsKKwkJCWVyciA9IGFjY2Vz c19ub2RlKGNvbm4sIG5vZGUsIE5PREVfQUNDRVNTX1JFQUQsIE5VTEwpOwor CQkJZXJybm8gPSBlcnIgPyA6IEVOT0VOVDsKIAkJfSBlbHNlIHsKIAkJCWxv ZygiVERCIGVycm9yIG9uIHJlYWQ6ICVzIiwgdGRiX2Vycm9yc3RyKHRkYl9j dHgpKTsKIAkJCWVycm5vID0gRUlPOwogCQl9Ci0JCXRhbGxvY19mcmVlKG5v ZGUpOwotCQlyZXR1cm4gTlVMTDsKKwkJZ290byBlcnJvcjsKIAl9CiAKIAlu b2RlLT5wYXJlbnQgPSBOVUxMOwpAQCAtNjM4LDE5ICs2MzksMzYgQEAgc3Ry dWN0IG5vZGUgKnJlYWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3Qgdm9pZCAqY3R4LAogCiAJLyogUGVybWlzc2lvbnMgYXJlIHN0cnVj dCB4c19wZXJtaXNzaW9ucy4gKi8KIAlub2RlLT5wZXJtcy5wID0gaGRyLT5w ZXJtczsKLQlpZiAoZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKGNvbm4sIG5v ZGUpKSB7Ci0JCXRhbGxvY19mcmVlKG5vZGUpOwotCQlyZXR1cm4gTlVMTDsK LQl9CisJaWYgKGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhjb25uLCBub2Rl KSkKKwkJZ290byBlcnJvcjsKIAogCS8qIERhdGEgaXMgYmluYXJ5IGJsb2Ig KHVzdWFsbHkgYXNjaWksIG5vIG51bCkuICovCiAJbm9kZS0+ZGF0YSA9IG5v ZGUtPnBlcm1zLnAgKyBoZHItPm51bV9wZXJtczsKIAkvKiBDaGlsZHJlbiBp cyBzdHJpbmdzLCBudWwgc2VwYXJhdGVkLiAqLwogCW5vZGUtPmNoaWxkcmVu ID0gbm9kZS0+ZGF0YSArIG5vZGUtPmRhdGFsZW47CiAKLQlhY2Nlc3Nfbm9k ZShjb25uLCBub2RlLCBOT0RFX0FDQ0VTU19SRUFELCBOVUxMKTsKKwlpZiAo YWNjZXNzX25vZGUoY29ubiwgbm9kZSwgTk9ERV9BQ0NFU1NfUkVBRCwgTlVM TCkpCisJCWdvdG8gZXJyb3I7CiAKIAlyZXR1cm4gbm9kZTsKKworIGVycm9y OgorCWVyciA9IGVycm5vOworCXRhbGxvY19mcmVlKG5vZGUpOworCWVycm5v ID0gZXJyOworCXJldHVybiBOVUxMOworfQorCitzdGF0aWMgYm9vbCByZWFk X25vZGVfY2FuX3Byb3BhZ2F0ZV9lcnJubyh2b2lkKQoreworCS8qCisJICog MiBlcnJvciBjYXNlcyBmb3IgcmVhZF9ub2RlKCkgY2FuIGFsd2F5cyBiZSBw cm9wYWdhdGVkIHVwOgorCSAqIEVOT01FTSwgYmVjYXVzZSB0aGlzIGhhcyBu b3RoaW5nIHRvIGRvIHdpdGggdGhlIG5vZGUgYmVpbmcgaW4gdGhlCisJICog ZGF0YSBiYXNlIG9yIG5vdCwgYnV0IGlzIGNhdXNlZCBieSBhIGdlbmVyYWwg bGFjayBvZiBtZW1vcnkuCisJICogRU5PU1BDLCBiZWNhdXNlIHRoaXMgaXMg cmVsYXRlZCB0byBoaXR0aW5nIHF1b3RhIGxpbWl0cyB3aGljaCBuZWVkCisJ ICogdG8gYmUgcmVzcGVjdGVkLgorCSAqLworCXJldHVybiBlcnJubyA9PSBF Tk9NRU0gfHwgZXJybm8gPT0gRU5PU1BDOwogfQogCiBpbnQgd3JpdGVfbm9k ZV9yYXcoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXks IHN0cnVjdCBub2RlICpub2RlLApAQCAtNzY3LDcgKzc4NSw3IEBAIHN0YXRp YyBpbnQgYXNrX3BhcmVudHMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNv bnN0IHZvaWQgKmN0eCwKIAkJbm9kZSA9IHJlYWRfbm9kZShjb25uLCBjdHgs IG5hbWUpOwogCQlpZiAobm9kZSkKIAkJCWJyZWFrOwotCQlpZiAoZXJybm8g PT0gRU5PTUVNKQorCQlpZiAocmVhZF9ub2RlX2Nhbl9wcm9wYWdhdGVfZXJy bm8oKSkKIAkJCXJldHVybiBlcnJubzsKIAl9IHdoaWxlICghc3RyZXEobmFt ZSwgIi8iKSk7CiAKQEAgLTgyOSw3ICs4NDcsNyBAQCBzdGF0aWMgc3RydWN0 IG5vZGUgKmdldF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCQl9 CiAJfQogCS8qIENsZWFuIHVwIGVycm5vIGlmIHRoZXkgd2VyZW4ndCBzdXBw b3NlZCB0byBrbm93LiAqLwotCWlmICghbm9kZSAmJiBlcnJubyAhPSBFTk9N RU0pCisJaWYgKCFub2RlICYmICFyZWFkX25vZGVfY2FuX3Byb3BhZ2F0ZV9l cnJubygpKQogCQllcnJubyA9IGVycm5vX2Zyb21fcGFyZW50cyhjb25uLCBj dHgsIG5hbWUsIGVycm5vLCBwZXJtKTsKIAlyZXR1cm4gbm9kZTsKIH0KQEAg LTEyMzUsNyArMTI1Myw3IEBAIHN0YXRpYyBzdHJ1Y3Qgbm9kZSAqY29uc3Ry dWN0X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQg KmN0eCwKIAogCS8qIElmIHBhcmVudCBkb2Vzbid0IGV4aXN0LCBjcmVhdGUg aXQuICovCiAJcGFyZW50ID0gcmVhZF9ub2RlKGNvbm4sIHBhcmVudG5hbWUs IHBhcmVudG5hbWUpOwotCWlmICghcGFyZW50KQorCWlmICghcGFyZW50ICYm IGVycm5vID09IEVOT0VOVCkKIAkJcGFyZW50ID0gY29uc3RydWN0X25vZGUo Y29ubiwgY3R4LCBwYXJlbnRuYW1lKTsKIAlpZiAoIXBhcmVudCkKIAkJcmV0 dXJuIE5VTEw7CkBAIC0xNTA5LDcgKzE1MjcsNyBAQCBzdGF0aWMgaW50IF9y bShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LCBz dHJ1Y3Qgbm9kZSAqbm9kZSwKIAogCXBhcmVudCA9IHJlYWRfbm9kZShjb25u LCBjdHgsIHBhcmVudG5hbWUpOwogCWlmICghcGFyZW50KQotCQlyZXR1cm4g KGVycm5vID09IEVOT01FTSkgPyBFTk9NRU0gOiBFSU5WQUw7CisJCXJldHVy biByZWFkX25vZGVfY2FuX3Byb3BhZ2F0ZV9lcnJubygpID8gZXJybm8gOiBF SU5WQUw7CiAJbm9kZS0+cGFyZW50ID0gcGFyZW50OwogCiAJcmV0dXJuIGRl bGV0ZV9ub2RlKGNvbm4sIGN0eCwgcGFyZW50LCBub2RlLCBmYWxzZSk7CkBA IC0xNTM5LDcgKzE1NTcsNyBAQCBzdGF0aWMgaW50IGRvX3JtKHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJ CQkJcmV0dXJuIDA7CiAJCQl9CiAJCQkvKiBSZXN0b3JlIGVycm5vLCBqdXN0 IGluIGNhc2UuICovCi0JCQlpZiAoZXJybm8gIT0gRU5PTUVNKQorCQkJaWYg KCFyZWFkX25vZGVfY2FuX3Byb3BhZ2F0ZV9lcnJubygpKQogCQkJCWVycm5v ID0gRU5PRU5UOwogCQl9CiAJCXJldHVybiBlcnJubzsKQEAgLTIzODQsNiAr MjQwMiw4IEBAIHN0YXRpYyB2b2lkIHVzYWdlKHZvaWQpCiAiICAtTSwgLS1w YXRoLW1heCA8Y2hhcnM+ICBsaW1pdCB0aGUgYWxsb3dlZCBYZW5zdG9yZSBu b2RlIHBhdGggbGVuZ3RoLFxuIgogIiAgLVEsIC0tcXVvdGEgPHdoYXQ+PTxu Yj4gc2V0IHRoZSBxdW90YSA8d2hhdD4gdG8gdGhlIHZhbHVlIDxuYj4sIGFs bG93ZWRcbiIKICIgICAgICAgICAgICAgICAgICAgICAgICAgIHF1b3RhcyBh cmU6XG4iCisiICAgICAgICAgICAgICAgICAgICAgICAgICB0cmFuc2FjdGlv bi1ub2RlczogbnVtYmVyIG9mIGFjY2Vzc2VkIG5vZGUgcGVyXG4iCisiICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHJh bnNhY3Rpb25cbiIKICIgICAgICAgICAgICAgICAgICAgICAgICAgIG91dHN0 YW5kaW5nOiBudW1iZXIgb2Ygb3V0c3RhbmRpbmcgcmVxdWVzdHNcbiIKICIg IC13LCAtLXRpbWVvdXQgPHdoYXQ+PTxzZWNvbmRzPiAgIHNldCB0aGUgdGlt ZW91dCBpbiBzZWNvbmRzIGZvciA8d2hhdD4sXG4iCiAiICAgICAgICAgICAg ICAgICAgICAgICAgICBhbGxvd2VkIHRpbWVvdXQgY2FuZGlkYXRlcyBhcmU6 XG4iCkBAIC0yNDY4LDYgKzI0ODgsOCBAQCBzdGF0aWMgdm9pZCBzZXRfcXVv dGEoY29uc3QgY2hhciAqYXJnKQogCXZhbCA9IGdldF9vcHR2YWxfaW50KGVx ICsgMSk7CiAJaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJvdXRzdGFuZGluZyIp KQogCQlxdW90YV9yZXFfb3V0c3RhbmRpbmcgPSB2YWw7CisJZWxzZSBpZiAo d2hhdF9tYXRjaGVzKGFyZywgInRyYW5zYWN0aW9uLW5vZGVzIikpCisJCXF1 b3RhX3RyYW5zX25vZGVzID0gdmFsOwogCWVsc2UKIAkJYmFyZigidW5rbm93 biBxdW90YSBcIiVzXCJcbiIsIGFyZyk7CiB9CmRpZmYgLS1naXQgYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2NvcmUuaAppbmRleCBiMWE3MDQ4OGI5ODkuLjI0NWY5MjU4 MjM1ZiAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCkBA IC0yNjgsNiArMjY4LDcgQEAgZXh0ZXJuIGludCBkb20wX2V2ZW50OwogZXh0 ZXJuIGludCBwcml2X2RvbWlkOwogZXh0ZXJuIGludCBxdW90YV9uYl9lbnRy eV9wZXJfZG9tYWluOwogZXh0ZXJuIGludCBxdW90YV9yZXFfb3V0c3RhbmRp bmc7CitleHRlcm4gaW50IHF1b3RhX3RyYW5zX25vZGVzOwogCiBleHRlcm4g dW5zaWduZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIApkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9u LmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpp bmRleCA4NmNhZjZjMzk4YmUuLjdiZDQxZWI0NzVlMyAxMDA2NDQKLS0tIGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKKysrIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKQEAgLTE1 Niw2ICsxNTYsOSBAQCBzdHJ1Y3QgdHJhbnNhY3Rpb24KIAkvKiBDb25uZWN0 aW9uLWxvY2FsIGlkZW50aWZpZXIgZm9yIHRoaXMgdHJhbnNhY3Rpb24uICov CiAJdWludDMyX3QgaWQ7CiAKKwkvKiBOb2RlIGNvdW50ZXIuICovCisJdW5z aWduZWQgaW50IG5vZGVzOworCiAJLyogR2VuZXJhdGlvbiB3aGVuIHRyYW5z YWN0aW9uIHN0YXJ0ZWQuICovCiAJdWludDY0X3QgZ2VuZXJhdGlvbjsKIApA QCAtMjYwLDYgKzI2MywxMSBAQCBpbnQgYWNjZXNzX25vZGUoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAogCiAJaSA9IGZp bmRfYWNjZXNzZWRfbm9kZSh0cmFucywgbm9kZS0+bmFtZSk7CiAJaWYgKCFp KSB7CisJCWlmICh0cmFucy0+bm9kZXMgPj0gcXVvdGFfdHJhbnNfbm9kZXMg JiYKKwkJICAgIGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikpIHsKKwkJ CXJldCA9IEVOT1NQQzsKKwkJCWdvdG8gZXJyOworCQl9CiAJCWkgPSB0YWxs b2NfemVybyh0cmFucywgc3RydWN0IGFjY2Vzc2VkX25vZGUpOwogCQlpZiAo IWkpCiAJCQlnb3RvIG5vbWVtOwpAQCAtMjk3LDYgKzMwNSw3IEBAIGludCBh Y2Nlc3Nfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5v ZGUgKm5vZGUsCiAJCQkJaS0+dGFfbm9kZSA9IHRydWU7CiAJCQl9CiAJCX0K KwkJdHJhbnMtPm5vZGVzKys7CiAJCWxpc3RfYWRkX3RhaWwoJmktPmxpc3Qs ICZ0cmFucy0+YWNjZXNzZWQpOwogCX0KIApkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmggYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uaAppbmRleCAwMDkzY2FjODA3 ZTMuLmUzY2JkNmIyMzA5NSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKKysrIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKQEAgLTM5LDggKzM5LDggQEAgdm9p ZCB0cmFuc2FjdGlvbl9lbnRyeV9pbmMoc3RydWN0IHRyYW5zYWN0aW9uICp0 cmFucywgdW5zaWduZWQgaW50IGRvbWlkKTsKIHZvaWQgdHJhbnNhY3Rpb25f ZW50cnlfZGVjKHN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnMsIHVuc2lnbmVk IGludCBkb21pZCk7CiAKIC8qIFRoaXMgbm9kZSB3YXMgYWNjZXNzZWQuICov Ci1pbnQgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBub2RlICpub2RlLAotICAgICAgICAgICAgICAgIGVudW0gbm9kZV9h Y2Nlc3NfdHlwZSB0eXBlLCBUREJfREFUQSAqa2V5KTsKK2ludCBfX211c3Rf Y2hlY2sgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBub2RlICpub2RlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBlbnVtIG5vZGVfYWNjZXNzX3R5cGUgdHlwZSwgVERCX0RBVEEgKmtleSk7 CiAKIC8qIFF1ZXVlIHdhdGNoZXMgZm9yIGEgbW9kaWZpZWQgbm9kZS4gKi8K IHZvaWQgcXVldWVfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3QgY2hhciAqbmFtZSwgYm9vbCB3YXRjaF9leGFjdCk7Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-10.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-10.patch" Content-Transfer-Encoding: base64 RnJvbSA5MDAxM2Q2YTczNTQ5MWE3YjkzYTY4MzJlYjJhNTFlNTYzMzI1NGY1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IG1vdmUgdGhl IGNhbGwgb2Ygc2V0dXBfc3RydWN0dXJlKCkgdG8gZG9tMAogaW50cm9kdWN0 aW9uCgpTZXR0aW5nIHVwIHRoZSBiYXNpYyBzdHJ1Y3R1cmUgd2hlbiBpbnRy b2R1Y2luZyBkb20wIGhhcyB0aGUgYWR2YW50YWdlCnRvIGJlIGFibGUgdG8g YWRkIHByb3BlciBub2RlIG1lbW9yeSBhY2NvdW50aW5nIGZvciB0aGUgYWRk ZWQgbm9kZXMKbGF0ZXIuCgpUaGlzIG1ha2VzIGl0IHBvc3NpYmxlIHRvIGRv IHByb3BlciBub2RlIGFjY291bnRpbmcsIHRvby4KCkFuIGFkZGl0aW9uYWwg cmVxdWlyZW1lbnQgdG8gbWFrZSB0aGF0IHdvcmsgZmluZSBpcyB0byBjb3Jy ZWN0IHRoZQpvd25lciBvZiB0aGUgY3JlYXRlZCBub2RlcyB0byBiZSBkb20w X2RvbWlkIGluc3RlYWQgb2YgZG9taWQgMC4KClRoaXMgaXMgcGFydCBvZiBY U0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMK aW5kZXggZjgzNWFhMWIyZjFmLi41MTcxZDM0Yzk0N2UgMTAwNjQ0Ci0tLSBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtMjAzOSw3ICsyMDM5LDgg QEAgc3RhdGljIGludCB0ZGJfZmxhZ3M7CiBzdGF0aWMgdm9pZCBtYW51YWxf bm9kZShjb25zdCBjaGFyICpuYW1lLCBjb25zdCBjaGFyICpjaGlsZCkKIHsK IAlzdHJ1Y3Qgbm9kZSAqbm9kZTsKLQlzdHJ1Y3QgeHNfcGVybWlzc2lvbnMg cGVybXMgPSB7IC5pZCA9IDAsIC5wZXJtcyA9IFhTX1BFUk1fTk9ORSB9Owor CXN0cnVjdCB4c19wZXJtaXNzaW9ucyBwZXJtcyA9IHsgLmlkID0gZG9tMF9k b21pZCwKKwkJCQkJLnBlcm1zID0gWFNfUEVSTV9OT05FIH07CiAKIAlub2Rl ID0gdGFsbG9jX3plcm8oTlVMTCwgc3RydWN0IG5vZGUpOwogCWlmICghbm9k ZSkKQEAgLTIwNzgsNyArMjA3OSw3IEBAIHN0YXRpYyB2b2lkIHRkYl9sb2dn ZXIoVERCX0NPTlRFWFQgKnRkYiwgaW50IGxldmVsLCBjb25zdCBjaGFyICog Zm10LCAuLi4pCiAJfQogfQogCi1zdGF0aWMgdm9pZCBzZXR1cF9zdHJ1Y3R1 cmUoYm9vbCBsaXZlX3VwZGF0ZSkKK3ZvaWQgc2V0dXBfc3RydWN0dXJlKGJv b2wgbGl2ZV91cGRhdGUpCiB7CiAJY2hhciAqdGRibmFtZTsKIApAQCAtMjEw MSw2ICsyMTAyLDcgQEAgc3RhdGljIHZvaWQgc2V0dXBfc3RydWN0dXJlKGJv b2wgbGl2ZV91cGRhdGUpCiAJCW1hbnVhbF9ub2RlKCIvIiwgInRvb2wiKTsK IAkJbWFudWFsX25vZGUoIi90b29sIiwgInhlbnN0b3JlZCIpOwogCQltYW51 YWxfbm9kZSgiL3Rvb2wveGVuc3RvcmVkIiwgTlVMTCk7CisJCWRvbWFpbl9l bnRyeV9maXgoZG9tMF9kb21pZCwgMywgdHJ1ZSk7CiAJfQogCiAJY2hlY2tf c3RvcmUoKTsKQEAgLTI2MTQsOSArMjYxNiw2IEBAIGludCBtYWluKGludCBh cmdjLCBjaGFyICphcmd2W10pCiAKIAlpbml0X3BpcGUocmVvcGVuX2xvZ19w aXBlKTsKIAotCS8qIFNldHVwIHRoZSBkYXRhYmFzZSAqLwotCXNldHVwX3N0 cnVjdHVyZShsaXZlX3VwZGF0ZSk7Ci0KIAkvKiBMaXN0ZW4gdG8gaHlwZXJ2 aXNvci4gKi8KIAlpZiAoIW5vX2RvbWFpbl9pbml0ICYmICFsaXZlX3VwZGF0 ZSkgewogCQlkb21haW5faW5pdCgtMSk7CmRpZmYgLS1naXQgYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuaAppbmRleCAyNDVmOTI1ODIzNWYuLjJjNzdlYzdlZTBm NCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUu aAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCkBAIC0y MzEsNiArMjMxLDcgQEAgaW50IHdyaXRlX25vZGVfcmF3KHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5LCBzdHJ1Y3Qgbm9kZSAqbm9k ZSwKIHN0cnVjdCBub2RlICpyZWFkX25vZGUoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAkJICAgICAgIGNvbnN0IGNoYXIg Km5hbWUpOwogCit2b2lkIHNldHVwX3N0cnVjdHVyZShib29sIGxpdmVfdXBk YXRlKTsKIHN0cnVjdCBjb25uZWN0aW9uICpuZXdfY29ubmVjdGlvbihjb25z dCBzdHJ1Y3QgaW50ZXJmYWNlX2Z1bmNzICpmdW5jcyk7CiBzdHJ1Y3QgY29u bmVjdGlvbiAqZ2V0X2Nvbm5lY3Rpb25fYnlfaWQodW5zaWduZWQgaW50IGNv bm5faWQpOwogdm9pZCBpZ25vcmVfY29ubmVjdGlvbihzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubik7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9t YWluLmMKaW5kZXggMjYwOTUyZTA5MDk2Li5mMDRiN2FhZThhMzIgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYworKysg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMKQEAgLTQ3MCw2 ICs0NzAsOSBAQCBzdGF0aWMgc3RydWN0IGRvbWFpbiAqaW50cm9kdWNlX2Rv bWFpbihjb25zdCB2b2lkICpjdHgsCiAJCX0KIAkJZG9tYWluLT5pbnRlcmZh Y2UgPSBpbnRlcmZhY2U7CiAKKwkJaWYgKGlzX21hc3Rlcl9kb21haW4pCisJ CQlzZXR1cF9zdHJ1Y3R1cmUocmVzdG9yZSk7CisKIAkJLyogTm93IGRvbWFp biBiZWxvbmdzIHRvIGl0cyBjb25uZWN0aW9uLiAqLwogCQl0YWxsb2Nfc3Rl YWwoZG9tYWluLT5jb25uLCBkb21haW4pOwogCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-11.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-11.patch" Content-Transfer-Encoding: base64 RnJvbSA2YWYxN2I4YmY1MmI5ZGZkYzZhNWVjZDNlZmJjZWE5ZmRkZDU3ZDkx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBpbmZy YXN0cnVjdHVyZSB0byBrZWVwIHRyYWNrIG9mIHBlciBkb21haW4gbWVtb3J5 CiB1c2FnZQoKVGhlIGFtb3VudCBvZiBtZW1vcnkgYSBkb21haW4gY2FuIGNv bnN1bWUgaW4gWGVuc3RvcmUgaXMgbGltaXRlZCBieQp2YXJpb3VzIHF1b3Rh IHRvZGF5LCBidXQgZXZlbiB3aXRoIHNhbmUgcXVvdGEgYSBkb21haW4gY2Fu IHN0aWxsCmNvbnN1bWUgcmF0aGVyIGxhcmdlIG1lbW9yeSBxdWFudGl0aWVz LgoKQWRkIHRoZSBpbmZyYXN0cnVjdHVyZSBmb3Iga2VlcGluZyB0cmFjayBv ZiB0aGUgYW1vdW50IG9mIG1lbW9yeSBhCmRvbWFpbiBpcyBjb25zdW1pbmcg aW4gWGVuc3RvcmUuIE5vdGUgdGhhdCB0aGlzIGlzIG9ubHkgdGhlIG1lbW9y eSBhCmRvbWFpbiBoYXMgZGlyZWN0IGNvbnRyb2wgb3Zlciwgc28gYW55IGlu dGVybmFsIGFkbWluaXN0cmF0aW9uIGRhdGEKbmVlZGVkIGJ5IFhlbnN0b3Jl IG9ubHkgaXMgbm90IGJlaW5nIGFjY291bnRlZCBmb3IuCgpUaGVyZSBhcmUg dHdvIHF1b3RhcyBkZWZpbmVkOiBhIHNvZnQgcXVvdGEgd2hpY2ggd2lsbCBy ZXN1bHQgaW4gYQp3YXJuaW5nIGlzc3VlZCB2aWEgc3lzbG9nKCkgd2hlbiBp dCBpcyBleGNlZWRlZCwgYW5kIGEgaGFyZCBxdW90YQpyZXN1bHRpbmcgaW4g YSBzdG9wIG9mIGFjY2VwdGluZyBmdXJ0aGVyIHJlcXVlc3RzIG9yIHdhdGNo IGV2ZW50cyBhcwpsb25nIGFzIHRoZSBoYXJkIHF1b3RhIHdvdWxkIGJlIHZp b2xhdGVkIGJ5IGFjY2VwdGluZyB0aG9zZS4KClNldHRpbmcgYW55IG9mIHRo b3NlIHF1b3RhcyB0byAwIHdpbGwgZGlzYWJsZSBpdC4KCkFzIGRlZmF1bHQg dmFsdWVzIHVzZSAyTUIgcGVyIGRvbWFpbiBmb3IgdGhlIHNvZnQgbGltaXQg KHRoaXMgYmFzaWNhbGx5CmNvdmVycyB0aGUgYWxsb3dlZCBjYXNlIHRvIGNy ZWF0ZSAxMDAwIG5vZGVzIG5lZWRpbmcgMmtCIGVhY2gpLCBhbmQKMi41TUIg Zm9yIHRoZSBoYXJkIGxpbWl0LgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYu CgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNv bT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwppbmRl eCA1MTcxZDM0Yzk0N2UuLmIyYmY2NzQwZDQzMCAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0xMDksNiArMTA5LDggQEAgaW50 IHF1b3RhX25iX3Blcm1zX3Blcl9ub2RlID0gNTsKIGludCBxdW90YV90cmFu c19ub2RlcyA9IDEwMjQ7CiBpbnQgcXVvdGFfbWF4X3BhdGhfbGVuID0gWEVO U1RPUkVfUkVMX1BBVEhfTUFYOwogaW50IHF1b3RhX3JlcV9vdXRzdGFuZGlu ZyA9IDIwOworaW50IHF1b3RhX21lbW9yeV9wZXJfZG9tYWluX3NvZnQgPSAy ICogMTAyNCAqIDEwMjQ7IC8qIDIgTUIgKi8KK2ludCBxdW90YV9tZW1vcnlf cGVyX2RvbWFpbl9oYXJkID0gMiAqIDEwMjQgKiAxMDI0ICsgNTEyICogMTAy NDsgLyogMi41IE1CICovCiAKIHVuc2lnbmVkIGludCB0aW1lb3V0X3dhdGNo X2V2ZW50X21zZWMgPSAyMDAwMDsKIApAQCAtMjQwNiw3ICsyNDA4LDE0IEBA IHN0YXRpYyB2b2lkIHVzYWdlKHZvaWQpCiAiICAgICAgICAgICAgICAgICAg ICAgICAgICBxdW90YXMgYXJlOlxuIgogIiAgICAgICAgICAgICAgICAgICAg ICAgICAgdHJhbnNhY3Rpb24tbm9kZXM6IG51bWJlciBvZiBhY2Nlc3NlZCBu b2RlIHBlclxuIgogIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHRyYW5zYWN0aW9uXG4iCisiICAgICAgICAgICAgICAg ICAgICAgICAgICBtZW1vcnk6IHRvdGFsIHVzZWQgbWVtb3J5IHBlciBkb21h aW4gZm9yIG5vZGVzLFxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB0cmFuc2FjdGlvbnMsIHdhdGNoZXMgYW5kIHJlcXVlc3RzLCBh Ym92ZVxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3 aGljaCBYZW5zdG9yZSB3aWxsIHN0b3AgdGFsa2luZyB0byBkb21haW5cbiIK ICIgICAgICAgICAgICAgICAgICAgICAgICAgIG91dHN0YW5kaW5nOiBudW1i ZXIgb2Ygb3V0c3RhbmRpbmcgcmVxdWVzdHNcbiIKKyIgIC1xLCAtLXF1b3Rh LXNvZnQgPHdoYXQ+PTxuYj4gc2V0IGEgc29mdCBxdW90YSA8d2hhdD4gdG8g dGhlIHZhbHVlIDxuYj4sXG4iCisiICAgICAgICAgICAgICAgICAgICAgICAg ICBjYXVzaW5nIGEgd2FybmluZyB0byBiZSBpc3N1ZWQgdmlhIHN5c2xvZygp IGlmIHRoZVxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgbGltaXQg aXMgdmlvbGF0ZWQsIGFsbG93ZWQgcXVvdGFzIGFyZTpcbiIKKyIgICAgICAg ICAgICAgICAgICAgICAgICAgIG1lbW9yeTogc2VlIGFib3ZlXG4iCiAiICAt dywgLS10aW1lb3V0IDx3aGF0Pj08c2Vjb25kcz4gICBzZXQgdGhlIHRpbWVv dXQgaW4gc2Vjb25kcyBmb3IgPHdoYXQ+LFxuIgogIiAgICAgICAgICAgICAg ICAgICAgICAgICAgYWxsb3dlZCB0aW1lb3V0IGNhbmRpZGF0ZXMgYXJlOlxu IgogIiAgICAgICAgICAgICAgICAgICAgICAgICAgd2F0Y2gtZXZlbnQ6IHRp bWUgYSB3YXRjaC1ldmVudCBpcyBrZXB0IHBlbmRpbmdcbiIKQEAgLTI0MzMs NiArMjQ0Miw3IEBAIHN0YXRpYyBzdHJ1Y3Qgb3B0aW9uIG9wdGlvbnNbXSA9 IHsKIAl7ICJwZXJtLW5iIiwgMSwgTlVMTCwgJ0EnIH0sCiAJeyAicGF0aC1t YXgiLCAxLCBOVUxMLCAnTScgfSwKIAl7ICJxdW90YSIsIDEsIE5VTEwsICdR JyB9LAorCXsgInF1b3RhLXNvZnQiLCAxLCBOVUxMLCAncScgfSwKIAl7ICJ0 aW1lb3V0IiwgMSwgTlVMTCwgJ3cnIH0sCiAJeyAibm8tcmVjb3ZlcnkiLCAw LCBOVUxMLCAnUicgfSwKIAl7ICJpbnRlcm5hbC1kYiIsIDAsIE5VTEwsICdJ JyB9LApAQCAtMjQ4MCw3ICsyNDkwLDcgQEAgc3RhdGljIHZvaWQgc2V0X3Rp bWVvdXQoY29uc3QgY2hhciAqYXJnKQogCQliYXJmKCJ1bmtub3duIHRpbWVv dXQgXCIlc1wiXG4iLCBhcmcpOwogfQogCi1zdGF0aWMgdm9pZCBzZXRfcXVv dGEoY29uc3QgY2hhciAqYXJnKQorc3RhdGljIHZvaWQgc2V0X3F1b3RhKGNv bnN0IGNoYXIgKmFyZywgYm9vbCBzb2Z0KQogewogCWNvbnN0IGNoYXIgKmVx ID0gc3RyY2hyKGFyZywgJz0nKTsKIAlpbnQgdmFsOwpAQCAtMjQ4OCwxMSAr MjQ5OCwxNiBAQCBzdGF0aWMgdm9pZCBzZXRfcXVvdGEoY29uc3QgY2hhciAq YXJnKQogCWlmICghZXEpCiAJCWJhcmYoInF1b3RhcyBtdXN0IGJlIHNwZWNp ZmllZCB2aWEgPHdoYXQ+PTxuYj5cbiIpOwogCXZhbCA9IGdldF9vcHR2YWxf aW50KGVxICsgMSk7Ci0JaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJvdXRzdGFu ZGluZyIpKQorCWlmICh3aGF0X21hdGNoZXMoYXJnLCAib3V0c3RhbmRpbmci KSAmJiAhc29mdCkKIAkJcXVvdGFfcmVxX291dHN0YW5kaW5nID0gdmFsOwot CWVsc2UgaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJ0cmFuc2FjdGlvbi1ub2Rl cyIpKQorCWVsc2UgaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJ0cmFuc2FjdGlv bi1ub2RlcyIpICYmICFzb2Z0KQogCQlxdW90YV90cmFuc19ub2RlcyA9IHZh bDsKLQllbHNlCisJZWxzZSBpZiAod2hhdF9tYXRjaGVzKGFyZywgIm1lbW9y eSIpKSB7CisJCWlmIChzb2Z0KQorCQkJcXVvdGFfbWVtb3J5X3Blcl9kb21h aW5fc29mdCA9IHZhbDsKKwkJZWxzZQorCQkJcXVvdGFfbWVtb3J5X3Blcl9k b21haW5faGFyZCA9IHZhbDsKKwl9IGVsc2UKIAkJYmFyZigidW5rbm93biBx dW90YSBcIiVzXCJcbiIsIGFyZyk7CiB9CiAKQEAgLTI1MTAsNyArMjUyNSw3 IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAJb3JpZ19h cmdjID0gYXJnYzsKIAlvcmlnX2FyZ3YgPSBhcmd2OwogCi0Jd2hpbGUgKChv cHQgPSBnZXRvcHRfbG9uZyhhcmdjLCBhcmd2LCAiREU6RjpITlBTOnQ6QTpN OlE6VDpSVlc6dzpVIiwKKwl3aGlsZSAoKG9wdCA9IGdldG9wdF9sb25nKGFy Z2MsIGFyZ3YsICJERTpGOkhOUFM6dDpBOk06UTpxOlQ6UlZXOnc6VSIsCiAJ CQkJICBvcHRpb25zLCBOVUxMKSkgIT0gLTEpIHsKIAkJc3dpdGNoIChvcHQp IHsKIAkJY2FzZSAnRCc6CkBAIC0yNTYxLDcgKzI1NzYsMTAgQEAgaW50IG1h aW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAkJCQkJCSBxdW90YV9tYXhf cGF0aF9sZW4pOwogCQkJYnJlYWs7CiAJCWNhc2UgJ1EnOgotCQkJc2V0X3F1 b3RhKG9wdGFyZyk7CisJCQlzZXRfcXVvdGEob3B0YXJnLCBmYWxzZSk7CisJ CQlicmVhazsKKwkJY2FzZSAncSc6CisJCQlzZXRfcXVvdGEob3B0YXJnLCB0 cnVlKTsKIAkJCWJyZWFrOwogCQljYXNlICd3JzoKIAkJCXNldF90aW1lb3V0 KG9wdGFyZyk7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApp bmRleCAyYzc3ZWM3ZWUwZjQuLjM3M2FmMTgyOTdiZiAxMDA2NDQKLS0tIGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAorKysgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCkBAIC0yNzAsNiArMjcwLDggQEAg ZXh0ZXJuIGludCBwcml2X2RvbWlkOwogZXh0ZXJuIGludCBxdW90YV9uYl9l bnRyeV9wZXJfZG9tYWluOwogZXh0ZXJuIGludCBxdW90YV9yZXFfb3V0c3Rh bmRpbmc7CiBleHRlcm4gaW50IHF1b3RhX3RyYW5zX25vZGVzOworZXh0ZXJu IGludCBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9zb2Z0OworZXh0ZXJuIGlu dCBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJkOwogCiBleHRlcm4gdW5z aWduZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIApkaWZmIC0t Z2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IGYwNGI3YWFl OGEzMi4uOTRmZDU2MWU5ZGU0IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2RvbWFpbi5jCkBAIC03Niw2ICs3NiwxMyBAQCBzdHJ1Y3QgZG9t YWluCiAJLyogbnVtYmVyIG9mIGVudHJ5IGZyb20gdGhpcyBkb21haW4gaW4g dGhlIHN0b3JlICovCiAJaW50IG5iZW50cnk7CiAKKwkvKiBBbW91bnQgb2Yg bWVtb3J5IGFsbG9jYXRlZCBmb3IgdGhpcyBkb21haW4uICovCisJaW50IG1l bW9yeTsKKwlib29sIHNvZnRfcXVvdGFfcmVwb3J0ZWQ7CisJYm9vbCBoYXJk X3F1b3RhX3JlcG9ydGVkOworCXRpbWVfdCBtZW1fbGFzdF9tc2c7CisjZGVm aW5lIE1FTV9XQVJOX01JTlRJTUVfU0VDIDEwCisKIAkvKiBudW1iZXIgb2Yg d2F0Y2ggZm9yIHRoaXMgZG9tYWluICovCiAJaW50IG5id2F0Y2g7CiAKQEAg LTE5Miw2ICsxOTksOSBAQCBzdGF0aWMgYm9vbCBkb21haW5fY2FuX3JlYWQo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCiAJCQlyZXR1cm4gZmFsc2U7CiAJ CWlmIChjb25uLT5kb21haW4tPm5ib3V0c3RhbmRpbmcgPj0gcXVvdGFfcmVx X291dHN0YW5kaW5nKQogCQkJcmV0dXJuIGZhbHNlOworCQlpZiAoY29ubi0+ ZG9tYWluLT5tZW1vcnkgPj0gcXVvdGFfbWVtb3J5X3Blcl9kb21haW5faGFy ZCAmJgorCQkgICAgcXVvdGFfbWVtb3J5X3Blcl9kb21haW5faGFyZCkKKwkJ CXJldHVybiBmYWxzZTsKIAl9CiAKIAlyZXR1cm4gKGludGYtPnJlcV9jb25z ICE9IGludGYtPnJlcV9wcm9kKTsKQEAgLTk1MCw2ICs5NjAsODkgQEAgaW50 IGRvbWFpbl9lbnRyeShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubikKIAkJOiAw OwogfQogCitzdGF0aWMgYm9vbCBkb21haW5fY2hrX3F1b3RhKHN0cnVjdCBk b21haW4gKmRvbWFpbiwgaW50IG1lbSkKK3sKKwl0aW1lX3Qgbm93OworCisJ aWYgKCFkb21haW4gfHwgIWRvbWlkX2lzX3VucHJpdmlsZWdlZChkb21haW4t PmRvbWlkKSB8fAorCSAgICAoZG9tYWluLT5jb25uICYmIGRvbWFpbi0+Y29u bi0+aXNfaWdub3JlZCkpCisJCXJldHVybiBmYWxzZTsKKworCW5vdyA9IHRp bWUoTlVMTCk7CisKKwlpZiAobWVtID49IHF1b3RhX21lbW9yeV9wZXJfZG9t YWluX2hhcmQgJiYKKwkgICAgcXVvdGFfbWVtb3J5X3Blcl9kb21haW5faGFy ZCkgeworCQlpZiAoZG9tYWluLT5oYXJkX3F1b3RhX3JlcG9ydGVkKQorCQkJ cmV0dXJuIHRydWU7CisJCXN5c2xvZyhMT0dfRVJSLCAiRG9tYWluICV1IGV4 Y2VlZHMgaGFyZCBtZW1vcnkgcXVvdGEsIFhlbnN0b3JlIGludGVyZmFjZSB0 byBkb21haW4gc3RhbGxlZFxuIiwKKwkJICAgICAgIGRvbWFpbi0+ZG9taWQp OworCQlkb21haW4tPm1lbV9sYXN0X21zZyA9IG5vdzsKKwkJZG9tYWluLT5o YXJkX3F1b3RhX3JlcG9ydGVkID0gdHJ1ZTsKKwkJcmV0dXJuIHRydWU7CisJ fQorCisJaWYgKG5vdyAtIGRvbWFpbi0+bWVtX2xhc3RfbXNnID49IE1FTV9X QVJOX01JTlRJTUVfU0VDKSB7CisJCWlmIChkb21haW4tPmhhcmRfcXVvdGFf cmVwb3J0ZWQpIHsKKwkJCWRvbWFpbi0+bWVtX2xhc3RfbXNnID0gbm93Owor CQkJZG9tYWluLT5oYXJkX3F1b3RhX3JlcG9ydGVkID0gZmFsc2U7CisJCQlz eXNsb2coTE9HX0lORk8sICJEb21haW4gJXUgYmVsb3cgaGFyZCBtZW1vcnkg cXVvdGEgYWdhaW5cbiIsCisJCQkgICAgICAgZG9tYWluLT5kb21pZCk7CisJ CX0KKwkJaWYgKG1lbSA+PSBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9zb2Z0 ICYmCisJCSAgICBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9zb2Z0ICYmCisJ CSAgICAhZG9tYWluLT5zb2Z0X3F1b3RhX3JlcG9ydGVkKSB7CisJCQlkb21h aW4tPm1lbV9sYXN0X21zZyA9IG5vdzsKKwkJCWRvbWFpbi0+c29mdF9xdW90 YV9yZXBvcnRlZCA9IHRydWU7CisJCQlzeXNsb2coTE9HX1dBUk5JTkcsICJE b21haW4gJXUgZXhjZWVkcyBzb2Z0IG1lbW9yeSBxdW90YVxuIiwKKwkJCSAg ICAgICBkb21haW4tPmRvbWlkKTsKKwkJfQorCQlpZiAobWVtIDwgcXVvdGFf bWVtb3J5X3Blcl9kb21haW5fc29mdCAmJgorCQkgICAgZG9tYWluLT5zb2Z0 X3F1b3RhX3JlcG9ydGVkKSB7CisJCQlkb21haW4tPm1lbV9sYXN0X21zZyA9 IG5vdzsKKwkJCWRvbWFpbi0+c29mdF9xdW90YV9yZXBvcnRlZCA9IGZhbHNl OworCQkJc3lzbG9nKExPR19JTkZPLCAiRG9tYWluICV1IGJlbG93IHNvZnQg bWVtb3J5IHF1b3RhIGFnYWluXG4iLAorCQkJICAgICAgIGRvbWFpbi0+ZG9t aWQpOworCQl9CisKKwl9CisKKwlyZXR1cm4gZmFsc2U7Cit9CisKK2ludCBk b21haW5fbWVtb3J5X2FkZCh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBtZW0s IGJvb2wgbm9fcXVvdGFfY2hlY2spCit7CisJc3RydWN0IGRvbWFpbiAqZG9t YWluOworCisJZG9tYWluID0gZmluZF9kb21haW5fc3RydWN0KGRvbWlkKTsK KwlpZiAoZG9tYWluKSB7CisJCS8qCisJCSAqIGRvbWFpbl9jaGtfcXVvdGEo KSB3aWxsIHByaW50IHdhcm5pbmcgYW5kIGFsc28gc3RvcmUgd2hldGhlcgor CQkgKiB0aGUgc29mdC9oYXJkIHF1b3RhIGhhcyBiZWVuIGhpdC4gU28gY2hl Y2sgbm9fcXVvdGFfY2hlY2sKKwkJICogKmFmdGVyKi4KKwkJICovCisJCWlm IChkb21haW5fY2hrX3F1b3RhKGRvbWFpbiwgZG9tYWluLT5tZW1vcnkgKyBt ZW0pICYmCisJCSAgICAhbm9fcXVvdGFfY2hlY2spCisJCQlyZXR1cm4gRU5P TUVNOworCQlkb21haW4tPm1lbW9yeSArPSBtZW07CisJfSBlbHNlIHsKKwkJ LyoKKwkJICogVGhlIGRvbWFpbiB0aGUgbWVtb3J5IGlzIHRvIGJlIGFjY291 bnRlZCBmb3Igc2hvdWxkIGFsd2F5cworCQkgKiBleGlzdCwgYXMgYWNjb3Vu dGluZyBpcyBkb25lIGVpdGhlciBmb3IgYSBkb21haW4gcmVsYXRlZCB0bwor CQkgKiB0aGUgY3VycmVudCBjb25uZWN0aW9uLCBvciBmb3IgdGhlIGRvbWFp biBvd25pbmcgYSBub2RlCisJCSAqICh3aGljaCBpcyBhbHdheXMgZXhpc3Rp bmcsIGFzIHRoZSBvd25lciBvZiB0aGUgbm9kZSBpcworCQkgKiB0ZXN0ZWQg dG8gZXhpc3QgYW5kIHJlcGxhY2VkIGJ5IGRvbWlkIDAgaWYgbm90KS4KKwkJ ICogU28gbm90IGZpbmRpbmcgdGhlIHJlbGF0ZWQgZG9tYWluIE1VU1QgYmUg YW4gZXJyb3IgaW4gdGhlCisJCSAqIGRhdGEgYmFzZS4KKwkJICovCisJCWVy cm5vID0gRU5PRU5UOworCQljb3JydXB0KE5VTEwsICJBY2NvdW50aW5nIGNh bGxlZCBmb3Igbm9uLWV4aXN0aW5nIGRvbWFpbiAldVxuIiwKKwkJCWRvbWlk KTsKKwkJcmV0dXJuIEVOT0VOVDsKKwl9CisKKwlyZXR1cm4gMDsKK30KKwog dm9pZCBkb21haW5fd2F0Y2hfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25u KQogewogCWlmICghY29ubiB8fCAhY29ubi0+ZG9tYWluKQpkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oCmluZGV4IGQ2NTE5OTA0ZDgz MS4uNjMzYzlhMGEwYTFmIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfZG9tYWluLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2RvbWFpbi5oCkBAIC02MSw2ICs2MSwyNiBAQCBpbnQgZG9tYWluX2Vu dHJ5X2luYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUg Kik7CiB2b2lkIGRvbWFpbl9lbnRyeV9kZWMoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBub2RlICopOwogaW50IGRvbWFpbl9lbnRyeV9maXgo dW5zaWduZWQgaW50IGRvbWlkLCBpbnQgbnVtLCBib29sIHVwZGF0ZSk7CiBp bnQgZG9tYWluX2VudHJ5KHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsKK2lu dCBkb21haW5fbWVtb3J5X2FkZCh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBt ZW0sIGJvb2wgbm9fcXVvdGFfY2hlY2spOworCisvKgorICogZG9tYWluX21l bW9yeV9hZGRfY2hrKCk6IHRvIGJlIHVzZWQgd2hlbiBtZW1vcnkgcXVvdGEg c2hvdWxkIGJlIGNoZWNrZWQuCisgKiBOb3QgdG8gYmUgdXNlZCB3aGVuIHNw ZWNpZnlpbmcgYSBuZWdhdGl2ZSBtZW0gdmFsdWUsIGFzIGxvd2VyaW5nIHRo ZSB1c2VkCisgKiBtZW1vcnkgc2hvdWxkIGFsd2F5cyBiZSBhbGxvd2VkLgor ICovCitzdGF0aWMgaW5saW5lIGludCBkb21haW5fbWVtb3J5X2FkZF9jaGso dW5zaWduZWQgaW50IGRvbWlkLCBpbnQgbWVtKQoreworCXJldHVybiBkb21h aW5fbWVtb3J5X2FkZChkb21pZCwgbWVtLCBmYWxzZSk7Cit9CisvKgorICog ZG9tYWluX21lbW9yeV9hZGRfbm9jaGsoKTogdG8gYmUgdXNlZCB3aGVuIG1l bW9yeSBxdW90YSBzaG91bGQgbm90IGJlCisgKiBjaGVja2VkLCBlLmcuIHdo ZW4gbG93ZXJpbmcgbWVtb3J5IHVzYWdlLCBvciBpbiBhbiBlcnJvciBjYXNl IGZvciB1bmRvaW5nCisgKiBhIHByZXZpb3VzIG1lbW9yeSBhZGp1c3RtZW50 LgorICovCitzdGF0aWMgaW5saW5lIHZvaWQgZG9tYWluX21lbW9yeV9hZGRf bm9jaGsodW5zaWduZWQgaW50IGRvbWlkLCBpbnQgbWVtKQoreworCWRvbWFp bl9tZW1vcnlfYWRkKGRvbWlkLCBtZW0sIHRydWUpOworfQogdm9pZCBkb21h aW5fd2F0Y2hfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsKIHZvaWQg ZG9tYWluX3dhdGNoX2RlYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7CiBp bnQgZG9tYWluX3dhdGNoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-12.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-12.patch" Content-Transfer-Encoding: base64 RnJvbSBhZTcwNDJmMDI0YWY3NTg0MjUxZjc3NmExMmQ5YmIyNGQxM2ZlY2Fm IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3IgcmVzcG9uc2VzCgpBZGQgdGhlIG1lbW9yeSBh Y2NvdW50aW5nIGZvciBxdWV1ZWQgcmVzcG9uc2VzLgoKSW4gY2FzZSBhZGRp bmcgYSB3YXRjaCBldmVudCBmb3IgYSBndWVzdCBpcyBjYXVzaW5nIHRoZSBo YXJkIG1lbW9yeQpxdW90YSBvZiB0aGF0IGd1ZXN0IHRvIGJlIHZpb2xhdGVk LCB0aGUgZXZlbnQgaXMgZHJvcHBlZC4gVGhpcyB3aWxsCmVuc3VyZSB0aGF0 IGl0IGlzIGltcG9zc2libGUgdG8gZHJpdmUgYW5vdGhlciBndWVzdCBwYXN0 IGl0cyBtZW1vcnkKcXVvdGEgYnkgZ2VuZXJhdGluZyBpbnNhbmUgYW1vdW50 cyBvZiBldmVudHMgZm9yIHRoYXQgZ3Vlc3QuIFRoaXMgaXMKZXNwZWNpYWxs eSBpbXBvcnRhbnQgZm9yIHByb3RlY3RpbmcgZHJpdmVyIGRvbWFpbnMgZnJv bSB0aGF0IGF0dGFjawp2ZWN0b3IuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMy NiAvIENWRS0yMDIyLTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4g R3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKaW5kZXggYjJiZjY3NDBkNDMwLi5lY2FiNmNmYmJl MTUgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAt MjYwLDYgKzI2MCw4IEBAIHN0YXRpYyB2b2lkIGZyZWVfYnVmZmVyZWRfZGF0 YShzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqb3V0LAogCQl9CiAJfQogCisJZG9t YWluX21lbW9yeV9hZGRfbm9jaGsoY29ubi0+aWQsIC1vdXQtPmhkci5tc2cu bGVuIC0gc2l6ZW9mKG91dC0+aGRyKSk7CisKIAlpZiAob3V0LT5oZHIubXNn LnR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQpIHsKIAkJcmVxID0gb3V0LT5wZW5k LnJlcTsKIAkJaWYgKHJlcSkgewpAQCAtOTM4LDExICs5NDAsMTQgQEAgdm9p ZCBzZW5kX3JlcGx5KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBlbnVtIHhz ZF9zb2NrbXNnX3R5cGUgdHlwZSwKIAliZGF0YS0+dGltZW91dF9tc2VjID0g MDsKIAliZGF0YS0+d2F0Y2hfZXZlbnQgPSBmYWxzZTsKIAotCWlmIChsZW4g PD0gREVGQVVMVF9CVUZGRVJfU0laRSkKKwlpZiAobGVuIDw9IERFRkFVTFRf QlVGRkVSX1NJWkUpIHsKIAkJYmRhdGEtPmJ1ZmZlciA9IGJkYXRhLT5kZWZh dWx0X2J1ZmZlcjsKLQllbHNlIHsKKwkJLyogRG9uJ3QgY2hlY2sgcXVvdGEs IHBhdGggbWlnaHQgYmUgdXNlZCBmb3IgcmV0dXJuaW5nIGVycm9yLiAqLwor CQlkb21haW5fbWVtb3J5X2FkZF9ub2Noayhjb25uLT5pZCwgbGVuICsgc2l6 ZW9mKGJkYXRhLT5oZHIpKTsKKwl9IGVsc2UgewogCQliZGF0YS0+YnVmZmVy ID0gdGFsbG9jX2FycmF5KGJkYXRhLCBjaGFyLCBsZW4pOwotCQlpZiAoIWJk YXRhLT5idWZmZXIpIHsKKwkJaWYgKCFiZGF0YS0+YnVmZmVyIHx8CisJCSAg ICBkb21haW5fbWVtb3J5X2FkZF9jaGsoY29ubi0+aWQsIGxlbiArIHNpemVv ZihiZGF0YS0+aGRyKSkpIHsKIAkJCXNlbmRfZXJyb3IoY29ubiwgRU5PTUVN KTsKIAkJCXJldHVybjsKIAkJfQpAQCAtMTAwNyw2ICsxMDEyLDExIEBAIHZv aWQgc2VuZF9ldmVudChzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqcmVxLCBzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJfQogCX0KIAorCWlmIChkb21haW5f bWVtb3J5X2FkZF9jaGsoY29ubi0+aWQsIGxlbiArIHNpemVvZihiZGF0YS0+ aGRyKSkpIHsKKwkJdGFsbG9jX2ZyZWUoYmRhdGEpOworCQlyZXR1cm47CisJ fQorCiAJaWYgKHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyAmJiBkb21haW5f aXNfdW5wcml2aWxlZ2VkKGNvbm4pKSB7CiAJCWJkYXRhLT50aW1lb3V0X21z ZWMgPSBnZXRfbm93X21zZWMoKSArIHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNl YzsKIAkJaWYgKCFjb25uLT50aW1lb3V0X21zZWMpCkBAIC0zMDM5LDYgKzMw NDksMTIgQEAgc3RhdGljIHZvaWQgYWRkX2J1ZmZlcmVkX2RhdGEoc3RydWN0 IGJ1ZmZlcmVkX2RhdGEgKmJkYXRhLAogCSAqLwogCWlmIChiZGF0YS0+aGRy Lm1zZy50eXBlICE9IFhTX1dBVENIX0VWRU5UKQogCQlkb21haW5fb3V0c3Rh bmRpbmdfaW5jKGNvbm4pOworCS8qCisJICogV2UgYXJlIHJlc3RvcmluZyB0 aGUgc3RhdGUgYWZ0ZXIgTGl2ZS1VcGRhdGUgYW5kIHRoZSBuZXcgcXVvdGEg bWF5CisJICogYmUgc21hbGxlci4gU28gaWdub3JlIGl0LiBUaGUgbGltaXQg d2lsbCBiZSBhcHBsaWVkIGZvciBhbnkgcmVzb3VyY2UKKwkgKiBhZnRlciB0 aGUgc3RhdGUgaGFzIGJlZW4gZnVsbHkgcmVzdG9yZWQuCisJICovCisJZG9t YWluX21lbW9yeV9hZGRfbm9jaGsoY29ubi0+aWQsIGxlbiArIHNpemVvZihi ZGF0YS0+aGRyKSk7CiB9CiAKIHZvaWQgcmVhZF9zdGF0ZV9idWZmZXJlZF9k YXRhKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-13.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-13.patch" Content-Transfer-Encoding: base64 RnJvbSA0NjI4YWUwYTU2YjAzN2RjZGM4YTNlNDJjNTQzYzViOWZkOTk5MGNm IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3Igd2F0Y2hlcwoKQWRkIHRoZSBtZW1vcnkgYWNj b3VudGluZyBmb3IgcmVnaXN0ZXJlZCB3YXRjaGVzLgoKV2hlbiBhIHNvY2tl dCBjb25uZWN0aW9uIGlzIGRlc3Ryb3llZCwgdGhlIGFzc29jaWF0ZWQgd2F0 Y2hlcyBhcmUKcmVtb3ZlZCwgdG9vLiBJbiBvcmRlciB0byBrZWVwIG1lbW9y eSBhY2NvdW50aW5nIGNvcnJlY3QgdGhlIHdhdGNoZXMKbXVzdCBiZSByZW1v dmVkIGV4cGxpY2l0bHkgdmlhIGEgY2FsbCBvZiBjb25uX2RlbGV0ZV9hbGxf d2F0Y2hlcygpIGZyb20KZGVzdHJveV9jb25uKCkuCgpUaGlzIGlzIHBhcnQg b2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6 IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6 IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggZWNhYjZjZmJiZTE1Li5k ODY5NDJmNWFhNzcgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuYwpAQCAtNDYzLDYgKzQ2Myw3IEBAIHN0YXRpYyBpbnQgZGVzdHJveV9j b25uKHZvaWQgKl9jb25uKQogCX0KIAogCWNvbm5fZnJlZV9idWZmZXJlZF9k YXRhKGNvbm4pOworCWNvbm5fZGVsZXRlX2FsbF93YXRjaGVzKGNvbm4pOwog CWxpc3RfZm9yX2VhY2hfZW50cnkocmVxLCAmY29ubi0+cmVmX2xpc3QsIGxp c3QpCiAJCXJlcS0+b25fcmVmX2xpc3QgPSBmYWxzZTsKIApkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmMgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYwppbmRleCAwNzU1ZmZhMzc1YmEu LmZkZjliMmQ2NTNhMCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX3dhdGNoLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X3dhdGNoLmMKQEAgLTIxMSw3ICsyMTEsNyBAQCBzdGF0aWMgaW50IGNoZWNr X3dhdGNoX3BhdGgoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZv aWQgKmN0eCwKIH0KIAogc3RhdGljIHN0cnVjdCB3YXRjaCAqYWRkX3dhdGNo KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjaGFyICpwYXRoLCBjaGFyICp0 b2tlbiwKLQkJCSAgICAgICBib29sIHJlbGF0aXZlKQorCQkJICAgICAgIGJv b2wgcmVsYXRpdmUsIGJvb2wgbm9fcXVvdGFfY2hlY2spCiB7CiAJc3RydWN0 IHdhdGNoICp3YXRjaDsKIApAQCAtMjIyLDYgKzIyMiw5IEBAIHN0YXRpYyBz dHJ1Y3Qgd2F0Y2ggKmFkZF93YXRjaChzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgY2hhciAqcGF0aCwgY2hhciAqdG9rZW4sCiAJd2F0Y2gtPnRva2VuID0g dGFsbG9jX3N0cmR1cCh3YXRjaCwgdG9rZW4pOwogCWlmICghd2F0Y2gtPm5v ZGUgfHwgIXdhdGNoLT50b2tlbikKIAkJZ290byBub21lbTsKKwlpZiAoZG9t YWluX21lbW9yeV9hZGQoY29ubi0+aWQsIHN0cmxlbihwYXRoKSArIHN0cmxl bih0b2tlbiksCisJCQkgICAgICBub19xdW90YV9jaGVjaykpCisJCWdvdG8g bm9tZW07CiAKIAlpZiAocmVsYXRpdmUpCiAJCXdhdGNoLT5yZWxhdGl2ZV9w YXRoID0gZ2V0X2ltcGxpY2l0X3BhdGgoY29ubik7CkBAIC0yNjUsNyArMjY4 LDcgQEAgaW50IGRvX3dhdGNoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJaWYgKGRvbWFpbl93YXRjaChj b25uKSA+IHF1b3RhX25iX3dhdGNoX3Blcl9kb21haW4pCiAJCXJldHVybiBF MkJJRzsKIAotCXdhdGNoID0gYWRkX3dhdGNoKGNvbm4sIHZlY1swXSwgdmVj WzFdLCByZWxhdGl2ZSk7CisJd2F0Y2ggPSBhZGRfd2F0Y2goY29ubiwgdmVj WzBdLCB2ZWNbMV0sIHJlbGF0aXZlLCBmYWxzZSk7CiAJaWYgKCF3YXRjaCkK IAkJcmV0dXJuIGVycm5vOwogCkBAIC0yOTYsNiArMjk5LDggQEAgaW50IGRv X3Vud2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZm ZXJlZF9kYXRhICppbikKIAlsaXN0X2Zvcl9lYWNoX2VudHJ5KHdhdGNoLCAm Y29ubi0+d2F0Y2hlcywgbGlzdCkgewogCQlpZiAoc3RyZXEod2F0Y2gtPm5v ZGUsIG5vZGUpICYmIHN0cmVxKHdhdGNoLT50b2tlbiwgdmVjWzFdKSkgewog CQkJbGlzdF9kZWwoJndhdGNoLT5saXN0KTsKKwkJCWRvbWFpbl9tZW1vcnlf YWRkX25vY2hrKGNvbm4tPmlkLCAtc3RybGVuKHdhdGNoLT5ub2RlKSAtCisJ CQkJCQkJICBzdHJsZW4od2F0Y2gtPnRva2VuKSk7CiAJCQl0YWxsb2NfZnJl ZSh3YXRjaCk7CiAJCQlkb21haW5fd2F0Y2hfZGVjKGNvbm4pOwogCQkJc2Vu ZF9hY2soY29ubiwgWFNfVU5XQVRDSCk7CkBAIC0zMTEsNiArMzE2LDggQEAg dm9pZCBjb25uX2RlbGV0ZV9hbGxfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlv biAqY29ubikKIAogCXdoaWxlICgod2F0Y2ggPSBsaXN0X3RvcCgmY29ubi0+ d2F0Y2hlcywgc3RydWN0IHdhdGNoLCBsaXN0KSkpIHsKIAkJbGlzdF9kZWwo JndhdGNoLT5saXN0KTsKKwkJZG9tYWluX21lbW9yeV9hZGRfbm9jaGsoY29u bi0+aWQsIC1zdHJsZW4od2F0Y2gtPm5vZGUpIC0KKwkJCQkJCSAgc3RybGVu KHdhdGNoLT50b2tlbikpOwogCQl0YWxsb2NfZnJlZSh3YXRjaCk7CiAJCWRv bWFpbl93YXRjaF9kZWMoY29ubik7CiAJfQpAQCAtMzczLDcgKzM4MCw3IEBA IHZvaWQgcmVhZF9zdGF0ZV93YXRjaChjb25zdCB2b2lkICpjdHgsIGNvbnN0 IHZvaWQgKnN0YXRlKQogCWlmICghcGF0aCkKIAkJYmFyZigiYWxsb2NhdGlv biBlcnJvciBmb3IgcmVhZCB3YXRjaCIpOwogCi0JaWYgKCFhZGRfd2F0Y2go Y29ubiwgcGF0aCwgdG9rZW4sIHJlbGF0aXZlKSkKKwlpZiAoIWFkZF93YXRj aChjb25uLCBwYXRoLCB0b2tlbiwgcmVsYXRpdmUsIHRydWUpKQogCQliYXJm KCJlcnJvciBhZGRpbmcgd2F0Y2giKTsKIH0KIAo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-14.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-14.patch" Content-Transfer-Encoding: base64 RnJvbSBiOGJkNzRlNWU5NjI5NTUyMTFhYjBjNWMxOTI0ZWJmMmJiNTI2Nzk5 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3Igbm9kZXMKCkFkZCB0aGUgbWVtb3J5IGFjY291 bnRpbmcgZm9yIFhlbnN0b3JlIG5vZGVzLiBJbiBvcmRlciB0byBtYWtlIHRo aXMKbm90IHRvbyBjb21wbGljYXRlZCBhbGxvdyBmb3Igc29tZSBzbG9wcGlu ZXNzIHdoZW4gd3JpdGluZyBub2Rlcy4gQW55CmhhcmQgcXVvdGEgdmlvbGF0 aW9uIHdpbGwgcmVzdWx0IGluIG5vIGZ1cnRoZXIgcmVxdWVzdHMgdG8gYmUg YWNjZXB0ZWQuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNiAvIENWRS0yMDIy LTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxs QGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKaW5kZXggZDg2OTQyZjVhYTc3Li4xNjUwNGRlNDIwMTcgMTAwNjQ0Ci0t LSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtNTkxLDYgKzU5MSwx MTcgQEAgdm9pZCBzZXRfdGRiX2tleShjb25zdCBjaGFyICpuYW1lLCBUREJf REFUQSAqa2V5KQogCWtleS0+ZHNpemUgPSBzdHJsZW4obmFtZSk7CiB9CiAK K3N0YXRpYyB2b2lkIGdldF9hY2NfZGF0YShUREJfREFUQSAqa2V5LCBzdHJ1 Y3Qgbm9kZV9hY2NvdW50X2RhdGEgKmFjYykKK3sKKwlUREJfREFUQSBvbGRf ZGF0YTsKKwlzdHJ1Y3QgeHNfdGRiX3JlY29yZF9oZHIgKmhkcjsKKworCWlm IChhY2MtPm1lbW9yeSA8IDApIHsKKwkJb2xkX2RhdGEgPSB0ZGJfZmV0Y2go dGRiX2N0eCwgKmtleSk7CisJCS8qIE5vIGNoZWNrIGZvciBlcnJvciwgYXMg dGhlIG5vZGUgbWlnaHQgbm90IGV4aXN0LiAqLworCQlpZiAob2xkX2RhdGEu ZHB0ciA9PSBOVUxMKSB7CisJCQlhY2MtPm1lbW9yeSA9IDA7CisJCX0gZWxz ZSB7CisJCQloZHIgPSAodm9pZCAqKW9sZF9kYXRhLmRwdHI7CisJCQlhY2Mt Pm1lbW9yeSA9IG9sZF9kYXRhLmRzaXplOworCQkJYWNjLT5kb21pZCA9IGhk ci0+cGVybXNbMF0uaWQ7CisJCX0KKwkJdGFsbG9jX2ZyZWUob2xkX2RhdGEu ZHB0cik7CisJfQorfQorCisvKgorICogUGVyLXRyYW5zYWN0aW9uIG5vZGVz IG5lZWQgdG8gYmUgYWNjb3VudGVkIGZvciB0aGUgdHJhbnNhY3Rpb24gb3du ZXIuCisgKiBUaG9zZSBub2RlcyBhcmUgc3RvcmVkIGluIHRoZSBkYXRhIGJh c2Ugd2l0aCB0aGUgdHJhbnNhY3Rpb24gZ2VuZXJhdGlvbgorICogY291bnQg cHJlcGVuZGVkIChlLmcuIDEyMy9sb2NhbC9kb21haW4vLi4uKS4gU28gdGVz dGluZyBmb3IgdGhlIG5vZGUncworICoga2V5IG5vdCB0byBzdGFydCB3aXRo ICIvIiBpcyBzdWZmaWNpZW50LgorICovCitzdGF0aWMgdW5zaWduZWQgaW50 IGdldF9hY2NfZG9taWQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9E QVRBICprZXksCisJCQkJICB1bnNpZ25lZCBpbnQgZG9taWQpCit7CisJcmV0 dXJuICghY29ubiB8fCBrZXktPmRwdHJbMF0gPT0gJy8nKSA/IGRvbWlkIDog Y29ubi0+aWQ7Cit9CisKK2ludCBkb190ZGJfd3JpdGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXksIFREQl9EQVRBICpkYXRhLAor CQkgc3RydWN0IG5vZGVfYWNjb3VudF9kYXRhICphY2MsIGJvb2wgbm9fcXVv dGFfY2hlY2spCit7CisJc3RydWN0IHhzX3RkYl9yZWNvcmRfaGRyICpoZHIg PSAodm9pZCAqKWRhdGEtPmRwdHI7CisJc3RydWN0IG5vZGVfYWNjb3VudF9k YXRhIG9sZF9hY2MgPSB7fTsKKwl1bnNpZ25lZCBpbnQgb2xkX2RvbWlkLCBu ZXdfZG9taWQ7CisJaW50IHJldDsKKworCWlmICghYWNjKQorCQlvbGRfYWNj Lm1lbW9yeSA9IC0xOworCWVsc2UKKwkJb2xkX2FjYyA9ICphY2M7CisKKwln ZXRfYWNjX2RhdGEoa2V5LCAmb2xkX2FjYyk7CisJb2xkX2RvbWlkID0gZ2V0 X2FjY19kb21pZChjb25uLCBrZXksIG9sZF9hY2MuZG9taWQpOworCW5ld19k b21pZCA9IGdldF9hY2NfZG9taWQoY29ubiwga2V5LCBoZHItPnBlcm1zWzBd LmlkKTsKKworCS8qCisJICogRG9uJ3QgY2hlY2sgZm9yIEVOT0VOVCwgYXMg d2Ugd2FudCB0byBiZSBhYmxlIHRvIHN3aXRjaCBvcnBoYW5lZAorCSAqIG5v ZGVzIHRvIG5ldyBvd25lcnMuCisJICovCisJaWYgKG9sZF9hY2MubWVtb3J5 KQorCQlkb21haW5fbWVtb3J5X2FkZF9ub2NoayhvbGRfZG9taWQsCisJCQkJ CS1vbGRfYWNjLm1lbW9yeSAtIGtleS0+ZHNpemUpOworCXJldCA9IGRvbWFp bl9tZW1vcnlfYWRkKG5ld19kb21pZCwgZGF0YS0+ZHNpemUgKyBrZXktPmRz aXplLAorCQkJCW5vX3F1b3RhX2NoZWNrKTsKKwlpZiAocmV0KSB7CisJCS8q IEVycm9yIHBhdGgsIHNvIG5vIHF1b3RhIGNoZWNrLiAqLworCQlpZiAob2xk X2FjYy5tZW1vcnkpCisJCQlkb21haW5fbWVtb3J5X2FkZF9ub2NoayhvbGRf ZG9taWQsCisJCQkJCQlvbGRfYWNjLm1lbW9yeSArIGtleS0+ZHNpemUpOwor CQlyZXR1cm4gcmV0OworCX0KKworCS8qIFREQiBzaG91bGQgc2V0IGVycm5v LCBidXQgZG9lc24ndCBldmVuIHNldCBlY29kZSBBRkFJQ1QuICovCisJaWYg KHRkYl9zdG9yZSh0ZGJfY3R4LCAqa2V5LCAqZGF0YSwgVERCX1JFUExBQ0Up ICE9IDApIHsKKwkJZG9tYWluX21lbW9yeV9hZGRfbm9jaGsobmV3X2RvbWlk LCAtZGF0YS0+ZHNpemUgLSBrZXktPmRzaXplKTsKKwkJLyogRXJyb3IgcGF0 aCwgc28gbm8gcXVvdGEgY2hlY2suICovCisJCWlmIChvbGRfYWNjLm1lbW9y eSkKKwkJCWRvbWFpbl9tZW1vcnlfYWRkX25vY2hrKG9sZF9kb21pZCwKKwkJ CQkJCW9sZF9hY2MubWVtb3J5ICsga2V5LT5kc2l6ZSk7CisJCWVycm5vID0g RUlPOworCQlyZXR1cm4gZXJybm87CisJfQorCisJaWYgKGFjYykgeworCQkv KiBEb24ndCB1c2UgbmV3X2RvbWlkLCBhcyBpdCBtaWdodCBiZSBhIHRyYW5z YWN0aW9uIG5vZGUuICovCisJCWFjYy0+ZG9taWQgPSBoZHItPnBlcm1zWzBd LmlkOworCQlhY2MtPm1lbW9yeSA9IGRhdGEtPmRzaXplOworCX0KKworCXJl dHVybiAwOworfQorCitpbnQgZG9fdGRiX2RlbGV0ZShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgVERCX0RBVEEgKmtleSwKKwkJICBzdHJ1Y3Qgbm9kZV9h Y2NvdW50X2RhdGEgKmFjYykKK3sKKwlzdHJ1Y3Qgbm9kZV9hY2NvdW50X2Rh dGEgdG1wX2FjYzsKKwl1bnNpZ25lZCBpbnQgZG9taWQ7CisKKwlpZiAoIWFj YykgeworCQlhY2MgPSAmdG1wX2FjYzsKKwkJYWNjLT5tZW1vcnkgPSAtMTsK Kwl9CisKKwlnZXRfYWNjX2RhdGEoa2V5LCBhY2MpOworCisJaWYgKHRkYl9k ZWxldGUodGRiX2N0eCwgKmtleSkpIHsKKwkJZXJybm8gPSBFSU87CisJCXJl dHVybiBlcnJubzsKKwl9CisKKwlpZiAoYWNjLT5tZW1vcnkpIHsKKwkJZG9t aWQgPSBnZXRfYWNjX2RvbWlkKGNvbm4sIGtleSwgYWNjLT5kb21pZCk7CisJ CWRvbWFpbl9tZW1vcnlfYWRkX25vY2hrKGRvbWlkLCAtYWNjLT5tZW1vcnkg LSBrZXktPmRzaXplKTsKKwl9CisKKwlyZXR1cm4gMDsKK30KKwogLyoKICAq IElmIGl0IGZhaWxzLCByZXR1cm5zIE5VTEwgYW5kIHNldHMgZXJybm8uCiAg KiBUZW1wb3JhcnkgbWVtb3J5IGFsbG9jYXRpb25zIHdpbGwgYmUgZG9uZSB3 aXRoIGN0eC4KQEAgLTY0NCw5ICs3NTUsMTUgQEAgc3RydWN0IG5vZGUgKnJl YWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAq Y3R4LAogCiAJLyogUGVybWlzc2lvbnMgYXJlIHN0cnVjdCB4c19wZXJtaXNz aW9ucy4gKi8KIAlub2RlLT5wZXJtcy5wID0gaGRyLT5wZXJtczsKKwlub2Rl LT5hY2MuZG9taWQgPSBub2RlLT5wZXJtcy5wWzBdLmlkOworCW5vZGUtPmFj Yy5tZW1vcnkgPSBkYXRhLmRzaXplOwogCWlmIChkb21haW5fYWRqdXN0X25v ZGVfcGVybXMoY29ubiwgbm9kZSkpCiAJCWdvdG8gZXJyb3I7CiAKKwkvKiBJ ZiBvd25lciBpcyBnb25lIHJlc2V0IGN1cnJlbnRseSBhY2NvdW50ZWQgbWVt b3J5IHNpemUuICovCisJaWYgKG5vZGUtPmFjYy5kb21pZCAhPSBub2RlLT5w ZXJtcy5wWzBdLmlkKQorCQlub2RlLT5hY2MubWVtb3J5ID0gMDsKKwogCS8q IERhdGEgaXMgYmluYXJ5IGJsb2IgKHVzdWFsbHkgYXNjaWksIG5vIG51bCku ICovCiAJbm9kZS0+ZGF0YSA9IG5vZGUtPnBlcm1zLnAgKyBoZHItPm51bV9w ZXJtczsKIAkvKiBDaGlsZHJlbiBpcyBzdHJpbmdzLCBudWwgc2VwYXJhdGVk LiAqLwpAQCAtNzE1LDEyICs4MzIsOSBAQCBpbnQgd3JpdGVfbm9kZV9yYXco c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXksIHN0cnVj dCBub2RlICpub2RlLAogCXAgKz0gbm9kZS0+ZGF0YWxlbjsKIAltZW1jcHko cCwgbm9kZS0+Y2hpbGRyZW4sIG5vZGUtPmNoaWxkbGVuKTsKIAotCS8qIFRE QiBzaG91bGQgc2V0IGVycm5vLCBidXQgZG9lc24ndCBldmVuIHNldCBlY29k ZSBBRkFJQ1QuICovCi0JaWYgKHRkYl9zdG9yZSh0ZGJfY3R4LCAqa2V5LCBk YXRhLCBUREJfUkVQTEFDRSkgIT0gMCkgewotCQljb3JydXB0KGNvbm4sICJX cml0ZSBvZiAlcyBmYWlsZWQiLCBrZXktPmRwdHIpOwotCQllcnJubyA9IEVJ TzsKLQkJcmV0dXJuIGVycm5vOwotCX0KKwlpZiAoZG9fdGRiX3dyaXRlKGNv bm4sIGtleSwgJmRhdGEsICZub2RlLT5hY2MsIG5vX3F1b3RhX2NoZWNrKSkK KwkJcmV0dXJuIEVJTzsKKwogCXJldHVybiAwOwogfQogCkBAIC0xMjIyLDcg KzEzMzYsNyBAQCBzdGF0aWMgdm9pZCBkZWxldGVfbm9kZV9zaW5nbGUoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQogCWlm IChhY2Nlc3Nfbm9kZShjb25uLCBub2RlLCBOT0RFX0FDQ0VTU19ERUxFVEUs ICZrZXkpKQogCQlyZXR1cm47CiAKLQlpZiAodGRiX2RlbGV0ZSh0ZGJfY3R4 LCBrZXkpICE9IDApIHsKKwlpZiAoZG9fdGRiX2RlbGV0ZShjb25uLCAma2V5 LCAmbm9kZS0+YWNjKSAhPSAwKSB7CiAJCWNvcnJ1cHQoY29ubiwgIkNvdWxk IG5vdCBkZWxldGUgJyVzJyIsIG5vZGUtPm5hbWUpOwogCQlyZXR1cm47CiAJ fQpAQCAtMTI5NSw2ICsxNDA5LDcgQEAgc3RhdGljIHN0cnVjdCBub2RlICpj b25zdHJ1Y3Rfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qg dm9pZCAqY3R4LAogCS8qIE5vIGNoaWxkcmVuLCBubyBkYXRhICovCiAJbm9k ZS0+Y2hpbGRyZW4gPSBub2RlLT5kYXRhID0gTlVMTDsKIAlub2RlLT5jaGls ZGxlbiA9IG5vZGUtPmRhdGFsZW4gPSAwOworCW5vZGUtPmFjYy5tZW1vcnkg PSAwOwogCW5vZGUtPnBhcmVudCA9IHBhcmVudDsKIAlyZXR1cm4gbm9kZTsK IApAQCAtMTMwMywxNyArMTQxOCwxNyBAQCBzdGF0aWMgc3RydWN0IG5vZGUg KmNvbnN0cnVjdF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25z dCB2b2lkICpjdHgsCiAJcmV0dXJuIE5VTEw7CiB9CiAKLXN0YXRpYyB2b2lk IGRlc3Ryb3lfbm9kZV9ybShzdHJ1Y3Qgbm9kZSAqbm9kZSkKK3N0YXRpYyB2 b2lkIGRlc3Ryb3lfbm9kZV9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg c3RydWN0IG5vZGUgKm5vZGUpCiB7CiAJaWYgKHN0cmVxKG5vZGUtPm5hbWUs ICIvIikpCiAJCWNvcnJ1cHQoTlVMTCwgIkRlc3Ryb3lpbmcgcm9vdCBub2Rl ISIpOwogCi0JdGRiX2RlbGV0ZSh0ZGJfY3R4LCBub2RlLT5rZXkpOworCWRv X3RkYl9kZWxldGUoY29ubiwgJm5vZGUtPmtleSwgJm5vZGUtPmFjYyk7CiB9 CiAKIHN0YXRpYyBpbnQgZGVzdHJveV9ub2RlKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSkKIHsKLQlkZXN0cm95X25vZGVf cm0obm9kZSk7CisJZGVzdHJveV9ub2RlX3JtKGNvbm4sIG5vZGUpOwogCWRv bWFpbl9lbnRyeV9kZWMoY29ubiwgbm9kZSk7CiAKIAkvKgpAQCAtMTM2NSw3 ICsxNDgwLDcgQEAgc3RhdGljIHN0cnVjdCBub2RlICpjcmVhdGVfbm9kZShz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCQkv KiBBY2NvdW50IGZvciBuZXcgbm9kZSAqLwogCQlpZiAoaS0+cGFyZW50KSB7 CiAJCQlpZiAoZG9tYWluX2VudHJ5X2luYyhjb25uLCBpKSkgewotCQkJCWRl c3Ryb3lfbm9kZV9ybShpKTsKKwkJCQlkZXN0cm95X25vZGVfcm0oY29ubiwg aSk7CiAJCQkJcmV0dXJuIE5VTEw7CiAJCQl9CiAJCX0KQEAgLTIyOTEsNyAr MjQwNiw3IEBAIHN0YXRpYyBpbnQgY2xlYW5fc3RvcmVfKFREQl9DT05URVhU ICp0ZGIsIFREQl9EQVRBIGtleSwgVERCX0RBVEEgdmFsLAogCWlmICghaGFz aHRhYmxlX3NlYXJjaChyZWFjaGFibGUsIG5hbWUpKSB7CiAJCWxvZygiY2xl YW5fc3RvcmU6ICclcycgaXMgb3JwaGFuZWQhIiwgbmFtZSk7CiAJCWlmIChy ZWNvdmVyeSkgewotCQkJdGRiX2RlbGV0ZSh0ZGIsIGtleSk7CisJCQlkb190 ZGJfZGVsZXRlKE5VTEwsICZrZXksIE5VTEwpOwogCQl9CiAJfQogCkBAIC0z MTQ5LDYgKzMyNjQsNyBAQCB2b2lkIHJlYWRfc3RhdGVfbm9kZShjb25zdCB2 b2lkICpjdHgsIGNvbnN0IHZvaWQgKnN0YXRlKQogCWlmICghbm9kZSkKIAkJ YmFyZigiYWxsb2NhdGlvbiBlcnJvciByZXN0b3Jpbmcgbm9kZSIpOwogCisJ bm9kZS0+YWNjLm1lbW9yeSA9IDA7CiAJbm9kZS0+bmFtZSA9IG5hbWU7CiAJ bm9kZS0+Z2VuZXJhdGlvbiA9ICsrZ2VuZXJhdGlvbjsKIAlub2RlLT5kYXRh bGVuID0gc24tPmRhdGFfbGVuOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmgKaW5kZXggMzczYWYxODI5N2JmLi5kYTllY2NlNjdmMzEgMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMTc2LDYg KzE3NiwxMSBAQCBzdHJ1Y3Qgbm9kZV9wZXJtcyB7CiAJc3RydWN0IHhzX3Bl cm1pc3Npb25zICpwOwogfTsKIAorc3RydWN0IG5vZGVfYWNjb3VudF9kYXRh IHsKKwl1bnNpZ25lZCBpbnQgZG9taWQ7CisJaW50IG1lbW9yeTsJCS8qIC0x IGlmIHVua25vd24gKi8KK307CisKIHN0cnVjdCBub2RlIHsKIAljb25zdCBj aGFyICpuYW1lOwogCS8qIEtleSB1c2VkIHRvIHVwZGF0ZSBUREIgKi8KQEAg LTE5OCw2ICsyMDMsOSBAQCBzdHJ1Y3Qgbm9kZSB7CiAJLyogQ2hpbGRyZW4s IGVhY2ggbnVsLXRlcm1pbmF0ZWQuICovCiAJdW5zaWduZWQgaW50IGNoaWxk bGVuOwogCWNoYXIgKmNoaWxkcmVuOworCisJLyogQWxsb2NhdGlvbiBpbmZv cm1hdGlvbiBmb3Igbm9kZSBjdXJyZW50bHkgaW4gc3RvcmUuICovCisJc3Ry dWN0IG5vZGVfYWNjb3VudF9kYXRhIGFjYzsKIH07CiAKIC8qIFJldHVybiB0 aGUgb25seSBhcmd1bWVudCBpbiB0aGUgaW5wdXQuICovCkBAIC0zMDYsNiAr MzE0LDEwIEBAIGV4dGVybiB4ZW5nbnR0YWJfaGFuZGxlICoqeGd0X2hhbmRs ZTsKIGludCByZW1lbWJlcl9zdHJpbmcoc3RydWN0IGhhc2h0YWJsZSAqaGFz aCwgY29uc3QgY2hhciAqc3RyKTsKIAogdm9pZCBzZXRfdGRiX2tleShjb25z dCBjaGFyICpuYW1lLCBUREJfREFUQSAqa2V5KTsKK2ludCBkb190ZGJfd3Jp dGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXksIFRE Ql9EQVRBICpkYXRhLAorCQkgc3RydWN0IG5vZGVfYWNjb3VudF9kYXRhICph Y2MsIGJvb2wgbm9fcXVvdGFfY2hlY2spOworaW50IGRvX3RkYl9kZWxldGUo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXksCisJCSAg c3RydWN0IG5vZGVfYWNjb3VudF9kYXRhICphY2MpOwogCiB2b2lkIGNvbm5f ZnJlZV9idWZmZXJlZF9kYXRhKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsK IApkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5z YWN0aW9uLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rp b24uYwppbmRleCA3YmQ0MWViNDc1ZTMuLmFjZTlhMTFkNzdiYiAxMDA2NDQK LS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMK KysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMK QEAgLTE1Myw2ICsxNTMsOSBAQCBzdHJ1Y3QgdHJhbnNhY3Rpb24KIAkvKiBM aXN0IG9mIGFsbCB0cmFuc2FjdGlvbnMgYWN0aXZlIG9uIHRoaXMgY29ubmVj dGlvbi4gKi8KIAlzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7CiAKKwkvKiBDb25u ZWN0aW9uIHRoaXMgdHJhbnNhY3Rpb24gaXMgYXNzb2NpYXRlZCB3aXRoLiAq LworCXN0cnVjdCBjb25uZWN0aW9uICpjb25uOworCiAJLyogQ29ubmVjdGlv bi1sb2NhbCBpZGVudGlmaWVyIGZvciB0aGlzIHRyYW5zYWN0aW9uLiAqLwog CXVpbnQzMl90IGlkOwogCkBAIC0yODYsNiArMjg5LDggQEAgaW50IGFjY2Vz c19ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAq bm9kZSwKIAogCQlpbnRyb2R1Y2UgPSB0cnVlOwogCQlpLT50YV9ub2RlID0g ZmFsc2U7CisJCS8qIGFjYy5tZW1vcnkgPCAwIG1lYW5zICJ1bmtub3duLCBn ZXQgc2l6ZSBmcm9tIFREQiIuICovCisJCW5vZGUtPmFjYy5tZW1vcnkgPSAt MTsKIAogCQkvKgogCQkgKiBBZGRpdGlvbmFsIHRyYW5zYWN0aW9uLXNwZWNp ZmljIG5vZGUgZm9yIHJlYWQgdHlwZS4gV2Ugb25seQpAQCAtNDEwLDExICs0 MTUsMTEgQEAgc3RhdGljIGludCBmaW5hbGl6ZV90cmFuc2FjdGlvbihzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJCQkJZ290byBlcnI7CiAJCQkJaGRy ID0gKHZvaWQgKilkYXRhLmRwdHI7CiAJCQkJaGRyLT5nZW5lcmF0aW9uID0g KytnZW5lcmF0aW9uOwotCQkJCXJldCA9IHRkYl9zdG9yZSh0ZGJfY3R4LCBr ZXksIGRhdGEsCi0JCQkJCQlUREJfUkVQTEFDRSk7CisJCQkJcmV0ID0gZG9f dGRiX3dyaXRlKGNvbm4sICZrZXksICZkYXRhLCBOVUxMLAorCQkJCQkJICAg dHJ1ZSk7CiAJCQkJdGFsbG9jX2ZyZWUoZGF0YS5kcHRyKTsKIAkJCX0gZWxz ZSB7Ci0JCQkJcmV0ID0gdGRiX2RlbGV0ZSh0ZGJfY3R4LCBrZXkpOworCQkJ CXJldCA9IGRvX3RkYl9kZWxldGUoY29ubiwgJmtleSwgTlVMTCk7CiAJCQl9 CiAJCQlpZiAocmV0KQogCQkJCWdvdG8gZXJyOwpAQCAtNDI1LDcgKzQzMCw3 IEBAIHN0YXRpYyBpbnQgZmluYWxpemVfdHJhbnNhY3Rpb24oc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCiAJCQl9CiAJCX0KIAotCQlpZiAoaS0+dGFfbm9k ZSAmJiB0ZGJfZGVsZXRlKHRkYl9jdHgsIHRhX2tleSkpCisJCWlmIChpLT50 YV9ub2RlICYmIGRvX3RkYl9kZWxldGUoY29ubiwgJnRhX2tleSwgTlVMTCkp CiAJCQlnb3RvIGVycjsKIAkJbGlzdF9kZWwoJmktPmxpc3QpOwogCQl0YWxs b2NfZnJlZShpKTsKQEAgLTQ1Myw3ICs0NTgsNyBAQCBzdGF0aWMgaW50IGRl c3Ryb3lfdHJhbnNhY3Rpb24odm9pZCAqX3RyYW5zYWN0aW9uKQogCQkJCQkJ CSAgICAgICBpLT5ub2RlKTsKIAkJCWlmICh0cmFuc19uYW1lKSB7CiAJCQkJ c2V0X3RkYl9rZXkodHJhbnNfbmFtZSwgJmtleSk7Ci0JCQkJdGRiX2RlbGV0 ZSh0ZGJfY3R4LCBrZXkpOworCQkJCWRvX3RkYl9kZWxldGUodHJhbnMtPmNv bm4sICZrZXksIE5VTEwpOwogCQkJfQogCQl9CiAJCWxpc3RfZGVsKCZpLT5s aXN0KTsKQEAgLTQ5Nyw2ICs1MDIsNyBAQCBpbnQgZG9fdHJhbnNhY3Rpb25f c3RhcnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbikKIAogCUlOSVRfTElTVF9IRUFEKCZ0cmFucy0+YWNjZXNz ZWQpOwogCUlOSVRfTElTVF9IRUFEKCZ0cmFucy0+Y2hhbmdlZF9kb21haW5z KTsKKwl0cmFucy0+Y29ubiA9IGNvbm47CiAJdHJhbnMtPmZhaWwgPSBmYWxz ZTsKIAl0cmFucy0+Z2VuZXJhdGlvbiA9ICsrZ2VuZXJhdGlvbjsKIAo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-15.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-15.patch" Content-Transfer-Encoding: base64 RnJvbSBjNTVhMWVhMGE1ZWE3ZjZhM2RjODUwY2IwMTVhNDliYTllYzU3MWFi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBleHBv cnRzIGZvciBxdW90YSB2YXJpYWJsZXMKClNvbWUgcXVvdGEgdmFyaWFibGVz IGFyZSBub3QgZXhwb3J0ZWQgdmlhIGhlYWRlciBmaWxlcy4KClRoaXMgaXMg cGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jv c3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmgKaW5kZXggZGE5ZWNjZTY3ZjMxLi5iZmQzZmMxZTlkZjMgMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMjc1LDYg KzI3NSwxMSBAQCBleHRlcm4gVERCX0NPTlRFWFQgKnRkYl9jdHg7CiBleHRl cm4gaW50IGRvbTBfZG9taWQ7CiBleHRlcm4gaW50IGRvbTBfZXZlbnQ7CiBl eHRlcm4gaW50IHByaXZfZG9taWQ7CitleHRlcm4gaW50IHF1b3RhX25iX3dh dGNoX3Blcl9kb21haW47CitleHRlcm4gaW50IHF1b3RhX21heF90cmFuc2Fj dGlvbjsKK2V4dGVybiBpbnQgcXVvdGFfbWF4X2VudHJ5X3NpemU7CitleHRl cm4gaW50IHF1b3RhX25iX3Blcm1zX3Blcl9ub2RlOworZXh0ZXJuIGludCBx dW90YV9tYXhfcGF0aF9sZW47CiBleHRlcm4gaW50IHF1b3RhX25iX2VudHJ5 X3Blcl9kb21haW47CiBleHRlcm4gaW50IHF1b3RhX3JlcV9vdXRzdGFuZGlu ZzsKIGV4dGVybiBpbnQgcXVvdGFfdHJhbnNfbm9kZXM7CmRpZmYgLS1naXQg YS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4IGFj ZTlhMTFkNzdiYi4uMjg3NzQ4MTNkZTgzIDEwMDY0NAotLS0gYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpAQCAtMTc1LDcgKzE3 NSw2IEBAIHN0cnVjdCB0cmFuc2FjdGlvbgogCWJvb2wgZmFpbDsKIH07CiAK LWV4dGVybiBpbnQgcXVvdGFfbWF4X3RyYW5zYWN0aW9uOwogdWludDY0X3Qg Z2VuZXJhdGlvbjsKIAogc3RhdGljIHN0cnVjdCBhY2Nlc3NlZF9ub2RlICpm aW5kX2FjY2Vzc2VkX25vZGUoc3RydWN0IHRyYW5zYWN0aW9uICp0cmFucywK ZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5j IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmMKaW5kZXggZmRm OWIyZDY1M2EwLi44NTM2MmJjY2UzMTQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCisrKyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF93YXRjaC5jCkBAIC0zMSw4ICszMSw2IEBACiAjaW5jbHVk ZSAieGVuc3RvcmVkX2RvbWFpbi5oIgogI2luY2x1ZGUgInhlbnN0b3JlZF90 cmFuc2FjdGlvbi5oIgogCi1leHRlcm4gaW50IHF1b3RhX25iX3dhdGNoX3Bl cl9kb21haW47Ci0KIHN0cnVjdCB3YXRjaAogewogCS8qIFdhdGNoZXMgb24g dGhpcyBjb25uZWN0aW9uICovCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-4.16-xenstored-16.patch" Content-Disposition: attachment; filename="xsa326/xsa326-4.16-xenstored-16.patch" Content-Transfer-Encoding: base64 RnJvbSAwNWNjMmFmNTBiYTQzNDMxZDZkNTBhZmY3NThlOTY4ODMzYWFiOWM2 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBjb250 cm9sIGNvbW1hbmQgZm9yIHNldHRpbmcgYW5kIHNob3dpbmcgcXVvdGEKCkFk ZCBhIHhlbnN0b3JlLWNvbnRyb2wgY29tbWFuZCAicXVvdGEiIHRvOgotIHNo b3cgY3VycmVudCBxdW90YSBzZXR0aW5ncwotIGNoYW5nZSBxdW90YSBzZXR0 aW5ncwotIHNob3cgY3VycmVudCBxdW90YSByZWxhdGVkIHZhbHVlcyBvZiBh IGRvbWFpbgoKTm90ZSB0aGF0IGluIHRoZSBjYXNlIHRoZSBuZXcgcXVvdGEg aXMgbG93ZXIgdGhhbiBleGlzdGluZyBvbmUsClhlbnN0b3JlZCBtYXkgY29u dGludWUgdG8gaGFuZGxlIHJlcXVlc3RzIGZyb20gYSBkb21haW4gZXhjZWVk aW5nIHRoZQpuZXcgbGltaXQgKGRlcGVuZHMgb24gd2hpY2ggb25lIGhhcyBi ZWVuIGJyb2tlbikgYW5kIHRoZSBhbW91bnQgb2YKcmVzb3VyY2UgdXNlZCB3 aWxsIG5vdCBjaGFuZ2UuIEhvd2V2ZXIgdGhlIGRvbWFpbiB3aWxsIG5vdCBi ZSBhYmxlIHRvCmNyZWF0ZSBtb3JlIHJlc291cmNlIChhc3NvY2lhdGVkIHRv IHRoZSBxdW90YSkgdW50aWwgaXQgaXMgYmFjayB0byBiZWxvdwp0aGUgbGlt aXQuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNi4KClJlcG9ydGVkLWJ5OiBK dWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgpTaWduZWQtb2ZmLWJ5 OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJldmlld2VkLWJ5 OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdp dCBhL2RvY3MvbWlzYy94ZW5zdG9yZS50eHQgYi9kb2NzL21pc2MveGVuc3Rv cmUudHh0CmluZGV4IDMzNGRjOGI2ZmRmNS4uYTdkMDA2NTE5YWU4IDEwMDY0 NAotLS0gYS9kb2NzL21pc2MveGVuc3RvcmUudHh0CisrKyBiL2RvY3MvbWlz Yy94ZW5zdG9yZS50eHQKQEAgLTM2Niw2ICszNjYsMTcgQEAgQ09OVFJPTAkJ CTxjb21tYW5kPnxbPHBhcmFtZXRlcnM+fF0KIAlwcmludHw8c3RyaW5nPgog CQlwcmludCA8c3RyaW5nPiB0byBzeXNsb2cgKHhlbnN0b3JlIHJ1bnMgYXMg ZGFlbW9uKSBvcgogCQl0byBjb25zb2xlICh4ZW5zdG9yZSBydW5zIGFzIHN0 dWJkb20pCisJcXVvdGF8W3NldCA8bmFtZT4gPHZhbD58PGRvbWlkPl0KKwkJ d2l0aG91dCBwYXJhbWV0ZXJzOiBwcmludCB0aGUgY3VycmVudCBxdW90YSBz ZXR0aW5ncworCQl3aXRoICJzZXQgPG5hbWU+IDx2YWw+Ijogc2V0IHRoZSBx dW90YSA8bmFtZT4gdG8gbmV3IHZhbHVlCisJCTx2YWw+IChUaGUgYWRtaW4g c2hvdWxkIG1ha2Ugc3VyZSBhbGwgdGhlIGRvbWFpbiB1c2FnZSBpcworCQli ZWxvdyB0aGUgcXVvdGEuIElmIGl0IGlzIG5vdCwgdGhlbiBYZW5zdG9yZWQg bWF5IGNvbnRpbnVlIHRvCisJCWhhbmRsZSByZXF1ZXN0cyBmcm9tIHRoZSBk b21haW4gYXMgbG9uZyBhcyB0aGUgcmVzb3VyY2UKKwkJdmlvbGF0aW5nIHRo ZSBuZXcgcXVvdGEgc2V0dGluZyBpc24ndCBpbmNyZWFzZWQgZnVydGhlcikK KwkJd2l0aCAiPGRvbWlkPiI6IHByaW50IHF1b3RhIHJlbGF0ZWQgYWNjb3Vu dGluZyBkYXRhIGZvcgorCQl0aGUgZG9tYWluIDxkb21pZD4KKwlxdW90YS1z b2Z0fFtzZXQgPG5hbWU+IDx2YWw+XQorCQlsaWtlIHRoZSAicXVvdGEiIGNv bW1hbmQsIGJ1dCBmb3Igc29mdC1xdW90YS4KIAloZWxwCQkJPHN1cHBvcnRl ZC1jb21tYW5kcz4KIAkJcmV0dXJuIGxpc3Qgb2Ygc3VwcG9ydGVkIGNvbW1h bmRzIGZvciBDT05UUk9MCiAKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb250cm9sLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29udHJvbC5jCmluZGV4IGFkYjhkNTFiMDQzYi4uMTAzMWE4MWMzODc0 IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJv bC5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmMK QEAgLTE5Niw2ICsxOTYsMTE1IEBAIHN0YXRpYyBpbnQgZG9fY29udHJvbF9s b2codm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAlyZXR1 cm4gMDsKIH0KIAorc3RydWN0IHF1b3RhIHsKKwljb25zdCBjaGFyICpuYW1l OworCWludCAqcXVvdGE7CisJY29uc3QgY2hhciAqZGVzY3I7Cit9OworCitz dGF0aWMgY29uc3Qgc3RydWN0IHF1b3RhIGhhcmRfcXVvdGFzW10gPSB7CisJ eyAibm9kZXMiLCAmcXVvdGFfbmJfZW50cnlfcGVyX2RvbWFpbiwgIk5vZGVz IHBlciBkb21haW4iIH0sCisJeyAid2F0Y2hlcyIsICZxdW90YV9uYl93YXRj aF9wZXJfZG9tYWluLCAiV2F0Y2hlcyBwZXIgZG9tYWluIiB9LAorCXsgInRy YW5zYWN0aW9ucyIsICZxdW90YV9tYXhfdHJhbnNhY3Rpb24sICJUcmFuc2Fj dGlvbnMgcGVyIGRvbWFpbiIgfSwKKwl7ICJvdXRzdGFuZGluZyIsICZxdW90 YV9yZXFfb3V0c3RhbmRpbmcsCisJCSJPdXRzdGFuZGluZyByZXF1ZXN0cyBw ZXIgZG9tYWluIiB9LAorCXsgInRyYW5zYWN0aW9uLW5vZGVzIiwgJnF1b3Rh X3RyYW5zX25vZGVzLAorCQkiTWF4LiBudW1iZXIgb2YgYWNjZXNzZWQgbm9k ZXMgcGVyIHRyYW5zYWN0aW9uIiB9LAorCXsgIm1lbW9yeSIsICZxdW90YV9t ZW1vcnlfcGVyX2RvbWFpbl9oYXJkLAorCQkiVG90YWwgWGVuc3RvcmUgbWVt b3J5IHBlciBkb21haW4gKGVycm9yIGxldmVsKSIgfSwKKwl7ICJub2RlLXNp emUiLCAmcXVvdGFfbWF4X2VudHJ5X3NpemUsICJNYXguIHNpemUgb2YgYSBu b2RlIiB9LAorCXsgInBhdGgtbWF4IiwgJnF1b3RhX21heF9wYXRoX2xlbiwg Ik1heC4gbGVuZ3RoIG9mIGEgbm9kZSBwYXRoIiB9LAorCXsgInBlcm1pc3Np b25zIiwgJnF1b3RhX25iX3Blcm1zX3Blcl9ub2RlLAorCQkiTWF4LiBudW1i ZXIgb2YgcGVybWlzc2lvbnMgcGVyIG5vZGUiIH0sCisJeyBOVUxMLCBOVUxM LCBOVUxMIH0KK307CisKK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcXVvdGEgc29m dF9xdW90YXNbXSA9IHsKKwl7ICJtZW1vcnkiLCAmcXVvdGFfbWVtb3J5X3Bl cl9kb21haW5fc29mdCwKKwkJIlRvdGFsIFhlbnN0b3JlIG1lbW9yeSBwZXIg ZG9tYWluICh3YXJuaW5nIGxldmVsKSIgfSwKKwl7IE5VTEwsIE5VTEwsIE5V TEwgfQorfTsKKworc3RhdGljIGludCBxdW90YV9zaG93X2N1cnJlbnQoY29u c3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJCSAg ICAgIGNvbnN0IHN0cnVjdCBxdW90YSAqcXVvdGFzKQoreworCWNoYXIgKnJl c3A7CisJdW5zaWduZWQgaW50IGk7CisKKwlyZXNwID0gdGFsbG9jX3N0cmR1 cChjdHgsICJRdW90YSBzZXR0aW5nczpcbiIpOworCWlmICghcmVzcCkKKwkJ cmV0dXJuIEVOT01FTTsKKworCWZvciAoaSA9IDA7IHF1b3Rhc1tpXS5xdW90 YTsgaSsrKSB7CisJCXJlc3AgPSB0YWxsb2NfYXNwcmludGZfYXBwZW5kKHJl c3AsICIlLTE3czogJThkICVzXG4iLAorCQkJCQkgICAgICBxdW90YXNbaV0u bmFtZSwgKnF1b3Rhc1tpXS5xdW90YSwKKwkJCQkJICAgICAgcXVvdGFzW2ld LmRlc2NyKTsKKwkJaWYgKCFyZXNwKQorCQkJcmV0dXJuIEVOT01FTTsKKwl9 CisKKwlzZW5kX3JlcGx5KGNvbm4sIFhTX0NPTlRST0wsIHJlc3AsIHN0cmxl bihyZXNwKSArIDEpOworCisJcmV0dXJuIDA7Cit9CisKK3N0YXRpYyBpbnQg cXVvdGFfc2V0KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sCisJCSAgICAgY2hhciAqKnZlYywgaW50IG51bSwgY29uc3Qgc3Ry dWN0IHF1b3RhICpxdW90YXMpCit7CisJdW5zaWduZWQgaW50IGk7CisJaW50 IHZhbDsKKworCWlmIChudW0gIT0gMikKKwkJcmV0dXJuIEVJTlZBTDsKKwor CXZhbCA9IGF0b2kodmVjWzFdKTsKKwlpZiAodmFsIDwgMSkKKwkJcmV0dXJu IEVJTlZBTDsKKworCWZvciAoaSA9IDA7IHF1b3Rhc1tpXS5xdW90YTsgaSsr KSB7CisJCWlmICghc3RyY21wKHZlY1swXSwgcXVvdGFzW2ldLm5hbWUpKSB7 CisJCQkqcXVvdGFzW2ldLnF1b3RhID0gdmFsOworCQkJc2VuZF9hY2soY29u biwgWFNfQ09OVFJPTCk7CisJCQlyZXR1cm4gMDsKKwkJfQorCX0KKworCXJl dHVybiBFSU5WQUw7Cit9CisKK3N0YXRpYyBpbnQgcXVvdGFfZ2V0KGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICAg Y2hhciAqKnZlYywgaW50IG51bSkKK3sKKwlpZiAobnVtICE9IDEpCisJCXJl dHVybiBFSU5WQUw7CisKKwlyZXR1cm4gZG9tYWluX2dldF9xdW90YShjdHgs IGNvbm4sIGF0b2kodmVjWzBdKSk7Cit9CisKK3N0YXRpYyBpbnQgZG9fY29u dHJvbF9xdW90YSh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25u LAorCQkJICAgIGNoYXIgKip2ZWMsIGludCBudW0pCit7CisJaWYgKG51bSA9 PSAwKQorCQlyZXR1cm4gcXVvdGFfc2hvd19jdXJyZW50KGN0eCwgY29ubiwg aGFyZF9xdW90YXMpOworCisJaWYgKCFzdHJjbXAodmVjWzBdLCAic2V0Iikp CisJCXJldHVybiBxdW90YV9zZXQoY3R4LCBjb25uLCB2ZWMgKyAxLCBudW0g LSAxLCBoYXJkX3F1b3Rhcyk7CisKKwlyZXR1cm4gcXVvdGFfZ2V0KGN0eCwg Y29ubiwgdmVjLCBudW0pOworfQorCitzdGF0aWMgaW50IGRvX2NvbnRyb2xf cXVvdGFfcyh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAor CQkJICAgICAgY2hhciAqKnZlYywgaW50IG51bSkKK3sKKwlpZiAobnVtID09 IDApCisJCXJldHVybiBxdW90YV9zaG93X2N1cnJlbnQoY3R4LCBjb25uLCBz b2Z0X3F1b3Rhcyk7CisKKwlpZiAoIXN0cmNtcCh2ZWNbMF0sICJzZXQiKSkK KwkJcmV0dXJuIHF1b3RhX3NldChjdHgsIGNvbm4sIHZlYyArIDEsIG51bSAt IDEsIHNvZnRfcXVvdGFzKTsKKworCXJldHVybiBFSU5WQUw7Cit9CisKICNp ZmRlZiBfX01JTklPU19fCiBzdGF0aWMgaW50IGRvX2NvbnRyb2xfbWVtcmVw b3J0KHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQkJ Y2hhciAqKnZlYywgaW50IG51bSkKQEAgLTg0Nyw2ICs5NTYsOCBAQCBzdGF0 aWMgc3RydWN0IGNtZF9zIGNtZHNbXSA9IHsKIAl7ICJtZW1yZXBvcnQiLCBk b19jb250cm9sX21lbXJlcG9ydCwgIls8ZmlsZT5dIiB9LAogI2VuZGlmCiAJ eyAicHJpbnQiLCBkb19jb250cm9sX3ByaW50LCAiPHN0cmluZz4iIH0sCisJ eyAicXVvdGEiLCBkb19jb250cm9sX3F1b3RhLCAiW3NldCA8bmFtZT4gPHZh bD58PGRvbWlkPl0iIH0sCisJeyAicXVvdGEtc29mdCIsIGRvX2NvbnRyb2xf cXVvdGFfcywgIltzZXQgPG5hbWU+IDx2YWw+XSIgfSwKIAl7ICJoZWxwIiwg ZG9fY29udHJvbF9oZWxwLCAiIiB9LAogfTsKIApkaWZmIC0tZ2l0IGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IDk0ZmQ1NjFlOWRlNC4uZTdj Njg4NmNjZjQ3IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Rv bWFpbi5jCkBAIC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSAieGVuc3RvcmVk X2RvbWFpbi5oIgogI2luY2x1ZGUgInhlbnN0b3JlZF90cmFuc2FjdGlvbi5o IgogI2luY2x1ZGUgInhlbnN0b3JlZF93YXRjaC5oIgorI2luY2x1ZGUgInhl bnN0b3JlZF9jb250cm9sLmgiCiAKICNpbmNsdWRlIDx4ZW5ldnRjaG4uaD4K ICNpbmNsdWRlIDx4ZW5jdHJsLmg+CkBAIC0zNDUsNiArMzQ2LDM4IEBAIHN0 YXRpYyBzdHJ1Y3QgZG9tYWluICpmaW5kX2RvbWFpbl9zdHJ1Y3QodW5zaWdu ZWQgaW50IGRvbWlkKQogCXJldHVybiBOVUxMOwogfQogCitpbnQgZG9tYWlu X2dldF9xdW90YShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAorCQkgICAgIHVuc2lnbmVkIGludCBkb21pZCkKK3sKKwlzdHJ1 Y3QgZG9tYWluICpkID0gZmluZF9kb21haW5fc3RydWN0KGRvbWlkKTsKKwlj aGFyICpyZXNwOworCWludCB0YTsKKworCWlmICghZCkKKwkJcmV0dXJuIEVO T0VOVDsKKworCXRhID0gZC0+Y29ubiA/IGQtPmNvbm4tPnRyYW5zYWN0aW9u X3N0YXJ0ZWQgOiAwOworCXJlc3AgPSB0YWxsb2NfYXNwcmludGYoY3R4LCAi RG9tYWluICV1OlxuIiwgZG9taWQpOworCWlmICghcmVzcCkKKwkJcmV0dXJu IEVOT01FTTsKKworI2RlZmluZSBlbnQodCwgZSkgXAorCXJlc3AgPSB0YWxs b2NfYXNwcmludGZfYXBwZW5kKHJlc3AsICIlLTE2czogJThkXG4iLCAjdCwg ZSk7IFwKKwlpZiAoIXJlc3ApIHJldHVybiBFTk9NRU0KKworCWVudChub2Rl cywgZC0+bmJlbnRyeSk7CisJZW50KHdhdGNoZXMsIGQtPm5id2F0Y2gpOwor CWVudCh0cmFuc2FjdGlvbnMsIHRhKTsKKwllbnQob3V0c3RhbmRpbmcsIGQt Pm5ib3V0c3RhbmRpbmcpOworCWVudChtZW1vcnksIGQtPm1lbW9yeSk7CisK KyN1bmRlZiBlbnQKKworCXNlbmRfcmVwbHkoY29ubiwgWFNfQ09OVFJPTCwg cmVzcCwgc3RybGVuKHJlc3ApICsgMSk7CisKKwlyZXR1cm4gMDsKK30KKwog c3RhdGljIHN0cnVjdCBkb21haW4gKmFsbG9jX2RvbWFpbihjb25zdCB2b2lk ICpjb250ZXh0LCB1bnNpZ25lZCBpbnQgZG9taWQpCiB7CiAJc3RydWN0IGRv bWFpbiAqZG9tYWluOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2RvbWFpbi5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Rv bWFpbi5oCmluZGV4IDYzM2M5YTBhMGExZi4uOTA0ZmFhOTIzYWZiIDEwMDY0 NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oCkBAIC04Nyw2 ICs4Nyw4IEBAIGludCBkb21haW5fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pOwogdm9pZCBkb21haW5fb3V0c3RhbmRpbmdfaW5jKHN0cnVjdCBj b25uZWN0aW9uICpjb25uKTsKIHZvaWQgZG9tYWluX291dHN0YW5kaW5nX2Rl YyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7CiB2b2lkIGRvbWFpbl9vdXRz dGFuZGluZ19kb21pZF9kZWModW5zaWduZWQgaW50IGRvbWlkKTsKK2ludCBk b21haW5fZ2V0X3F1b3RhKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sCisJCSAgICAgdW5zaWduZWQgaW50IGRvbWlkKTsKIAog LyogU3BlY2lhbCBub2RlIHBlcm1pc3Npb24gaGFuZGxpbmcuICovCiBpbnQg c2V0X3Blcm1zX3NwZWNpYWwoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNv bnN0IGNoYXIgKm5hbWUsCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-oxenstored-01.patch" Content-Disposition: attachment; filename="xsa326/xsa326-oxenstored-01.patch" Content-Transfer-Encoding: base64 RnJvbSA1YWVjMWEzN2E4Y2NjNTFlNjEzNjQxZGVjZjk5YTEwZDc3MDUyZjNm IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IFN5bmNocm9uaXNlIGRlZmF1 bHRzIHdpdGggb3hlbnN0b3JlLmNvbmYuaW4KTUlNRS1WZXJzaW9uOiAxLjAK Q29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRl bnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCldlIGN1cnJlbnRseSBoYXZl IDIgZGlmZmVyZW50IHNldCBvZiBkZWZhdWx0cyBpbiB1cHN0cmVhbSBYZW4g Z2l0IHRyZWU6CiogZGVmaW5lZCBpbiB0aGUgc291cmNlIGNvZGUsIG9ubHkg dXNlZCBpZiB0aGVyZSBpcyBubyBjb25maWcgZmlsZQoqIGRlZmluZWQgaW4g dGhlIG94ZW5zdG9yZWQuY29uZi5pbiB1cHN0cmVhbSBYZW4KCkFuIG94ZW5z dG9yZWQuY29uZiBmaWxlIGlzIG5vdCBtYW5kYXRvcnksIGFuZCBpZiBtaXNz aW5nLCBtYXhyZXF1ZXN0cyBpbgpwYXJ0aWN1bGFyIGhhcyBhbiB1bnNhZmUg ZGVmYXVsdC4KClJlc3luYyB0aGUgZGVmYXVsdHMgZnJvbSBveGVuc3RvcmVk LmNvbmYuaW4gaW50byB0aGUgc291cmNlIGNvZGUuCgpUaGlzIGlzIHBhcnQg b2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzE2LgoKUmVwb3J0ZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6 IEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2Vk LWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJp eC5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Rl ZmluZS5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKaW5k ZXggZWJlMThiOGUzMTJjLi42YjA2ZjgwODU5NWIgMTAwNjQ0Ci0tLSBhL3Rv b2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKKysrIGIvdG9vbHMvb2Nh bWwveGVuc3RvcmVkL2RlZmluZS5tbApAQCAtMjEsOSArMjEsOSBAQCBsZXQg eHNfZGFlbW9uX3NvY2tldCA9IFBhdGhzLnhlbl9ydW5fc3RvcmVkIF4gIi9z b2NrZXQiCiAKIGxldCBkZWZhdWx0X2NvbmZpZ19kaXIgPSBQYXRocy54ZW5f Y29uZmlnX2RpcgogCi1sZXQgbWF4d2F0Y2ggPSByZWYgKDUwKQotbGV0IG1h eHRyYW5zYWN0aW9uID0gcmVmICgyMCkKLWxldCBtYXhyZXF1ZXN0cyA9IHJl ZiAoLTEpICAgKCogbWF4aW11bSByZXF1ZXN0cyBwZXIgdHJhbnNhY3Rpb24g KikKK2xldCBtYXh3YXRjaCA9IHJlZiAoMTAwKQorbGV0IG1heHRyYW5zYWN0 aW9uID0gcmVmICgxMCkKK2xldCBtYXhyZXF1ZXN0cyA9IHJlZiAoMTAyNCkg ICAoKiBtYXhpbXVtIHJlcXVlc3RzIHBlciB0cmFuc2FjdGlvbiAqKQogCiBs ZXQgY29uZmxpY3RfYnVyc3RfbGltaXQgPSByZWYgNS4wCiBsZXQgY29uZmxp Y3RfbWF4X2hpc3Rvcnlfc2Vjb25kcyA9IHJlZiAwLjA1CmRpZmYgLS1naXQg YS90b29scy9vY2FtbC94ZW5zdG9yZWQvcXVvdGEubWwgYi90b29scy9vY2Ft bC94ZW5zdG9yZWQvcXVvdGEubWwKaW5kZXggYWJjYWM5MTI4MDVhLi42ZTNk NjQwMWFlODkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9x dW90YS5tbAorKysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvcXVvdGEubWwK QEAgLTIwLDggKzIwLDggQEAgZXhjZXB0aW9uIFRyYW5zYWN0aW9uX29wZW5l ZAogCiBsZXQgd2FybiBmbXQgPSBMb2dnaW5nLndhcm4gInF1b3RhIiBmbXQK IGxldCBhY3RpdmF0ZSA9IHJlZiB0cnVlCi1sZXQgbWF4ZW50ID0gcmVmICgx MDAwMCkKLWxldCBtYXhzaXplID0gcmVmICg0MDk2KQorbGV0IG1heGVudCA9 IHJlZiAoMTAwMCkKK2xldCBtYXhzaXplID0gcmVmICgyMDQ4KQogCiB0eXBl IHQgPSB7CiAJbWF4ZW50OiBpbnQ7ICAgICAgICAgICAgICAgKCogbWF4IGVu dGl0aWVzIHBlciBkb21VICopCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-oxenstored-02.patch" Content-Disposition: attachment; filename="xsa326/xsa326-oxenstored-02.patch" Content-Transfer-Encoding: base64 RnJvbSBmOTE1NmQzYTlkZTE5OGU5ZGJiNjI3NGVlYjIzM2ExZTEyZDk2MjI5 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogVGh1LCAyOCBKdWwgMjAyMiAxNzowODoxNSArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IENoZWNrIGZvciBtYXhyZXF1 ZXN0cyBiZWZvcmUgcGVyZm9ybWluZwogb3BlcmF0aW9ucwpNSU1FLVZlcnNp b246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRG LTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKUHJldmlvdXNs eSB3ZSdkIHBlcmZvcm0gdGhlIG9wZXJhdGlvbiwgcmVjb3JkIHRoZSB1cGRh dGVkIHRyZWUgaW4gdGhlCnRyYW5zYWN0aW9uIHJlY29yZCwgdGhlbiB0cnkg dG8gaW5zZXJ0IGEgd2F0Y2hvcCBwYXRoIGFuZCB0aGUgcmVwbHkgcGFja2V0 LgoKSWYgd2UgZXhjZWVkZWQgbWF4IHJlcXVlc3RzIHdlIHdvdWxkJ3ZlIHJl dHVybmVkIEVRVU9UQSwgYnV0IHN0aWxsOgoqIGhhdmUgcGVyZm9ybWVkIHRo ZSBvcGVyYXRpb24gb24gdGhlIHRyYW5zYWN0aW9uJ3MgdHJlZQoqIGhhdmUg cmVjb3JkZWQgdGhlIHdhdGNob3AsIG1ha2luZyB0aGlzIHF1ZXVlIGVmZmVj dGl2ZWx5IHVuYm91bmRlZAoKSXQgaXMgYmV0dGVyIGlmIHdlIGNoZWNrIHdo ZXRoZXIgd2UnZCBoYXZlIHJvb20gdG8gc3RvcmUgdGhlIG9wZXJhdGlvbiBi ZWZvcmUKcGVyZm9ybWluZyB0aGUgdHJhbnNhY3Rpb24sIGFuZCByYWlzZSBF UVVPVEEgdGhlcmUuICBUaGVuIHRoZSB0cmFuc2FjdGlvbgpyZWNvcmQgd29u J3QgZ3Jvdy4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2IC8gQ1ZFLTIwMjIt NDIzMTcuCgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1h em9uLmNvbT4KU2lnbmVkLW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4u dG9yb2tAY2l0cml4LmNvbT4KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcg PGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbCBiL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9wcm9jZXNzLm1sCmluZGV4IDg2ZWVkMDI0MTM3Yi4uZDA0 MDA0MTlhYjRmIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQv cHJvY2Vzcy5tbAorKysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vz cy5tbApAQCAtMzg5LDYgKzM4OSw3IEBAIGxldCBpbnB1dF9oYW5kbGVfZXJy b3IgfmNvbnMgfmRvbXMgfmZjdCB+Y29uIH50IH5yZXEgPQogCWxldCByZXBs eV9lcnJvciBlID0KIAkJUGFja2V0LkVycm9yIGUgaW4KIAl0cnkKKwkJVHJh bnNhY3Rpb24uY2hlY2tfcXVvdGFfZXhuIH5wZXJtOihDb25uZWN0aW9uLmdl dF9wZXJtIGNvbikgdDsKIAkJZmN0IGNvbiB0IGRvbXMgY29ucyByZXEuUGFj a2V0LmRhdGEKIAl3aXRoCiAJfCBEZWZpbmUuSW52YWxpZF9wYXRoICAgICAg ICAgIC0+IHJlcGx5X2Vycm9yICJFSU5WQUwiCkBAIC02ODIsOSArNjgzLDEw IEBAIGxldCBwcm9jZXNzX3BhY2tldCB+c3RvcmUgfmNvbnMgfmRvbXMgfmNv biB+cmVxID0KIAkJaW4KIAogCQlsZXQgcmVzcG9uc2UgPSB0cnkKKwkJCVRy YW5zYWN0aW9uLmNoZWNrX3F1b3RhX2V4biB+cGVybTooQ29ubmVjdGlvbi5n ZXRfcGVybSBjb24pIHQ7CiAJCQlpZiB0aWQgPD4gVHJhbnNhY3Rpb24ubm9u ZSB0aGVuCiAJCQkJKCogUmVtZW1iZXIgdGhlIHJlcXVlc3QgYW5kIHJlc3Bv bnNlIGZvciB0aGlzIG9wZXJhdGlvbiBpbiBjYXNlIHdlIG5lZWQgdG8gcmVw bGF5IHRoZSB0cmFuc2FjdGlvbiAqKQotCQkJCVRyYW5zYWN0aW9uLmFkZF9v cGVyYXRpb24gfnBlcm06KENvbm5lY3Rpb24uZ2V0X3Blcm0gY29uKSB0IHJl cSByZXNwb25zZTsKKwkJCQlUcmFuc2FjdGlvbi5hZGRfb3BlcmF0aW9uIHQg cmVxIHJlc3BvbnNlOwogCQkJcmVzcG9uc2UKIAkJd2l0aCBRdW90YS5MaW1p dF9yZWFjaGVkIC0+CiAJCQlQYWNrZXQuRXJyb3IgIkVRVU9UQSIKZGlmZiAt LWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbCBi L3Rvb2xzL29jYW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbAppbmRleCAx N2IxYmRmMmVhZjkuLjI5NDE0M2UyMzM1YiAxMDA2NDQKLS0tIGEvdG9vbHMv b2NhbWwveGVuc3RvcmVkL3RyYW5zYWN0aW9uLm1sCisrKyBiL3Rvb2xzL29j YW1sL3hlbnN0b3JlZC90cmFuc2FjdGlvbi5tbApAQCAtODUsNiArODUsNyBA QCB0eXBlIHQgPSB7CiAJb2xkcm9vdDogU3RvcmUuTm9kZS50OwogCW11dGFi bGUgcGF0aHM6IChYZW5idXMuWGIuT3Aub3BlcmF0aW9uICogU3RvcmUuUGF0 aC50KSBsaXN0OwogCW11dGFibGUgb3BlcmF0aW9uczogKFBhY2tldC5yZXF1 ZXN0ICogUGFja2V0LnJlc3BvbnNlKSBsaXN0OworCW11dGFibGUgcXVvdGFf cmVhY2hlZDogYm9vbDsKIAltdXRhYmxlIHJlYWRfbG93cGF0aDogU3RvcmUu UGF0aC50IG9wdGlvbjsKIAltdXRhYmxlIHdyaXRlX2xvd3BhdGg6IFN0b3Jl LlBhdGgudCBvcHRpb247CiB9CkBAIC0xMjcsNiArMTI4LDcgQEAgbGV0IG1h a2UgPyhpbnRlcm5hbD1mYWxzZSkgaWQgc3RvcmUgPQogCQlvbGRyb290ID0g U3RvcmUuZ2V0X3Jvb3Qgc3RvcmU7CiAJCXBhdGhzID0gW107CiAJCW9wZXJh dGlvbnMgPSBbXTsKKwkJcXVvdGFfcmVhY2hlZCA9IGZhbHNlOwogCQlyZWFk X2xvd3BhdGggPSBOb25lOwogCQl3cml0ZV9sb3dwYXRoID0gTm9uZTsKIAl9 IGluCkBAIC0xNDMsMTMgKzE0NSwxOSBAQCBsZXQgZ2V0X3Jvb3QgdCA9IFN0 b3JlLmdldF9yb290IHQuc3RvcmUKIAogbGV0IGlzX3JlYWRfb25seSB0ID0g dC5wYXRocyA9IFtdCiBsZXQgYWRkX3dvcCB0IHR5IHBhdGggPSB0LnBhdGhz IDwtICh0eSwgcGF0aCkgOjogdC5wYXRocwotbGV0IGFkZF9vcGVyYXRpb24g fnBlcm0gdCByZXF1ZXN0IHJlc3BvbnNlID0KK2xldCBnZXRfb3BlcmF0aW9u cyB0ID0gTGlzdC5yZXYgdC5vcGVyYXRpb25zCisKK2xldCBjaGVja19xdW90 YV9leG4gfnBlcm0gdCA9CiAJaWYgIURlZmluZS5tYXhyZXF1ZXN0cyA+PSAw CiAJCSYmIG5vdCAoUGVybXMuQ29ubmVjdGlvbi5pc19kb20wIHBlcm0pCi0J CSYmIExpc3QubGVuZ3RoIHQub3BlcmF0aW9ucyA+PSAhRGVmaW5lLm1heHJl cXVlc3RzCi0JCXRoZW4gcmFpc2UgUXVvdGEuTGltaXRfcmVhY2hlZDsKKwkJ JiYgKHQucXVvdGFfcmVhY2hlZCB8fCBMaXN0Lmxlbmd0aCB0Lm9wZXJhdGlv bnMgPj0gIURlZmluZS5tYXhyZXF1ZXN0cykKKwkJdGhlbiBiZWdpbgorCQkJ dC5xdW90YV9yZWFjaGVkIDwtIHRydWU7CisJCQlyYWlzZSBRdW90YS5MaW1p dF9yZWFjaGVkOworCQllbmQKKworbGV0IGFkZF9vcGVyYXRpb24gdCByZXF1 ZXN0IHJlc3BvbnNlID0KIAl0Lm9wZXJhdGlvbnMgPC0gKHJlcXVlc3QsIHJl c3BvbnNlKSA6OiB0Lm9wZXJhdGlvbnMKLWxldCBnZXRfb3BlcmF0aW9ucyB0 ID0gTGlzdC5yZXYgdC5vcGVyYXRpb25zCiBsZXQgc2V0X3JlYWRfbG93cGF0 aCB0IHBhdGggPSB0LnJlYWRfbG93cGF0aCA8LSBnZXRfbG93ZXN0IHBhdGgg dC5yZWFkX2xvd3BhdGgKIGxldCBzZXRfd3JpdGVfbG93cGF0aCB0IHBhdGgg PSB0LndyaXRlX2xvd3BhdGggPC0gZ2V0X2xvd2VzdCBwYXRoIHQud3JpdGVf bG93cGF0aAogCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-oxenstored-03.patch" Content-Disposition: attachment; filename="xsa326/xsa326-oxenstored-03.patch" Content-Transfer-Encoding: base64 RnJvbSBmZTc4M2QxZTVhNjkzNTJkYTMwNWZhZGQzNDViMjZlNDhhYWIyMzgw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNyArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogR0MgcGFyYW1ldGVyIHR1bmluZwpNSU1FLVZl cnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9 VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKQnkgZGVm YXVsdCB0aGUgT0NhbWwgZ2FyYmFnZSBjb2xsZWN0b3Igd291bGQgcmV0dXJu IG1lbW9yeSB0byB0aGUgT1Mgb25seQphZnRlciB1bnVzZWQgbWVtb3J5IGlz IDV4IGxpdmUgbWVtb3J5LiAgVHdlYWsgdGhpcyB0byAxMjAlIGluc3RlYWQs IHdoaWNoCndvdWxkIG1hdGNoIHRoZSBtYWpvciBHQyBzcGVlZC4KClRoaXMg aXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEVkd2luIFTD tnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJp c3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+Cgpk aWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RlZmluZS5tbCBi L3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKaW5kZXggNmIwNmY4 MDg1OTViLi5iYTYzYTgxNDdlMDkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9kZWZpbmUubWwKKysrIGIvdG9vbHMvb2NhbWwveGVuc3Rv cmVkL2RlZmluZS5tbApAQCAtMjUsNiArMjUsNyBAQCBsZXQgbWF4d2F0Y2gg PSByZWYgKDEwMCkKIGxldCBtYXh0cmFuc2FjdGlvbiA9IHJlZiAoMTApCiBs ZXQgbWF4cmVxdWVzdHMgPSByZWYgKDEwMjQpICAgKCogbWF4aW11bSByZXF1 ZXN0cyBwZXIgdHJhbnNhY3Rpb24gKikKIAorbGV0IGdjX21heF9vdmVyaGVh ZCA9IHJlZiAxMjAgKCogMTIwJSBzZWUgY29tbWVudCBpbiB4ZW5zdG9yZWQu bWwgKikKIGxldCBjb25mbGljdF9idXJzdF9saW1pdCA9IHJlZiA1LjAKIGxl dCBjb25mbGljdF9tYXhfaGlzdG9yeV9zZWNvbmRzID0gcmVmIDAuMDUKIGxl dCBjb25mbGljdF9yYXRlX2xpbWl0X2lzX2FnZ3JlZ2F0ZSA9IHJlZiB0cnVl CmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQveGVuc3RvcmVk Lm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbAppbmRl eCBkNDRhZTY3M2M0MmEuLjNiNTdhZDAxNmRmYiAxMDA2NDQKLS0tIGEvdG9v bHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbAorKysgYi90b29scy9v Y2FtbC94ZW5zdG9yZWQveGVuc3RvcmVkLm1sCkBAIC0xMDQsNiArMTA0LDcg QEAgbGV0IHBhcnNlX2NvbmZpZyBmaWxlbmFtZSA9CiAJCSgicXVvdGEtbWF4 c2l6ZSIsIENvbmZpZy5TZXRfaW50IFF1b3RhLm1heHNpemUpOwogCQkoInF1 b3RhLW1heHJlcXVlc3RzIiwgQ29uZmlnLlNldF9pbnQgRGVmaW5lLm1heHJl cXVlc3RzKTsKIAkJKCJxdW90YS1wYXRoLW1heCIsIENvbmZpZy5TZXRfaW50 IERlZmluZS5wYXRoX21heCk7CisJCSgiZ2MtbWF4LW92ZXJoZWFkIiwgQ29u ZmlnLlNldF9pbnQgRGVmaW5lLmdjX21heF9vdmVyaGVhZCk7CiAJCSgidGVz dC1lYWdhaW4iLCBDb25maWcuU2V0X2Jvb2wgVHJhbnNhY3Rpb24udGVzdF9l YWdhaW4pOwogCQkoInBlcnNpc3RlbnQiLCBDb25maWcuU2V0X2Jvb2wgRGlz ay5lbmFibGUpOwogCQkoInhlbnN0b3JlZC1sb2ctZmlsZSIsIENvbmZpZy5T dHJpbmcgTG9nZ2luZy5zZXRfeGVuc3RvcmVkX2xvZ19kZXN0aW5hdGlvbik7 CkBAIC0yNjUsNiArMjY2LDY3IEBAIGxldCB0b19maWxlIHN0b3JlIGNvbnMg ZmRzIGZpbGUgPQogCSAgICAgICAgKGZ1biAoKSAtPiBjbG9zZV9vdXQgY2hh bm5lbCkKIGVuZAogCisoKgorCUJ5IGRlZmF1bHQgT0NhbWwncyBHQyBvbmx5 IHJldHVybnMgbWVtb3J5IHRvIHRoZSBPUyB3aGVuIGl0IGV4Y2VlZHMgYQor CWNvbmZpZ3VyYWJsZSAnbWF4IG92ZXJoZWFkJyBzZXR0aW5nLgorCVRoZSBk ZWZhdWx0IGlzIDUwMCUsIHRoYXQgaXMgNS82dGggb2YgdGhlIE9DYW1sIGhl YXAgbmVlZHMgdG8gYmUgZnJlZQorCWFuZCBvbmx5IDEvNnRoIGxpdmUgZm9y IGEgY29tcGFjdGlvbiB0byBiZSB0cmlnZ2VycmVkIHRoYXQgd291bGQKKwly ZWxlYXNlIG1lbW9yeSBiYWNrIHRvIHRoZSBPUy4KKwlJZiB0aGUgbGltaXQg aXMgbm90IGhpdCB0aGVuIHRoZSBPQ2FtbCBwcm9jZXNzIGNhbiByZXVzZSB0 aGF0IG1lbW9yeQorCWZvciBpdHMgb3duIHB1cnBvc2VzLCBidXQgb3RoZXIg cHJvY2Vzc2VzIHdvbid0IGJlIGFibGUgdG8gdXNlIGl0LgorCisJVGhlcmUg aXMgYWxzbyBhICdzcGFjZSBvdmVyaGVhZCcgc2V0dGluZyB0aGF0IGNvbnRy b2xzIGhvdyBtdWNoIHdvcmsKKwllYWNoIG1ham9yIEdDIHNsaWNlIGRvZXMs IGFuZCBieSBkZWZhdWx0IGFpbXMgYXQgaGF2aW5nIG5vIG1vcmUgdGhhbgor CTgwJSBvciAxMjAlIChkZXBlbmRpbmcgb24gdmVyc2lvbikgZ2FyYmFnZSB2 YWx1ZXMgY29tcGFyZWQgdG8gbGl2ZQorCXZhbHVlcy4KKwlUaGlzIGRvZXNu J3QgaGF2ZSBhcyBtdWNoIHJlbGV2YW5jZSB0byBtZW1vcnkgcmV0dXJuZWQg dG8gdGhlIE9TIGFzCisJbG9uZyBhcyBzcGFjZV9vdmVyaGVhZCA8PSBtYXhf b3ZlcmhlYWQsIGJlY2F1c2UgY29tcGFjdGlvbiBpcyBvbmx5CisJdHJpZ2dl cnJlZCBhdCB0aGUgZW5kIG9mIG1ham9yIEdDIGN5Y2xlcy4KKworCVRoZSBk ZWZhdWx0cyBhcmUgdG9vIGxhcmdlIG9uY2UgdGhlIHByb2dyYW0gc3RhcnRz IHVzaW5nIH4xMDBNaUIgb2YKKwltZW1vcnksIGF0IHdoaWNoIHBvaW50IH41 MDBNaUIgd291bGQgYmUgdW5hdmFpbGFibGUgdG8gb3RoZXIgcHJvY2Vzc2Vz CisJKHdoaWNoIHdvdWxkIGJlIGZpbmUgaWYgdGhpcyB3YXMgdGhlIG1haW4g cHJvY2VzcyBpbiB0aGlzIFZNLCBidXQgaXQgaXMKKwlub3QpLgorCisJTWF4 IG92ZXJoZWFkIGNhbiBhbHNvIGJlIHNldCB0byAwLCBob3dldmVyIHRoaXMg aXMgZm9yIHRlc3RpbmcgcHVycG9zZXMKKwlvbmx5IChzZXR0aW5nIGl0IGxv d2VyIHRoYW4gJ3NwYWNlIG92ZXJoZWFkJyB3b3VsZG4ndCBoZWxwIGJlY2F1 c2UgdGhlCisJbWFqb3IgR0Mgd291bGRuJ3QgcnVuIGZhc3QgZW5vdWdoLCBh bmQgY29tcGFjdGlvbiBkb2VzIGhhdmUgYQorCXBlcmZvcm1hbmNlIGNvc3Q6 IHdlIGNhbiBvbmx5IGNvbXBhY3QgY29udGlndW91cyByZWdpb25zLCBzbyBt ZW1vcnkgaGFzCisJdG8gYmUgbW92ZWQgYXJvdW5kKS4KKworCU1heCBvdmVy aGVhZCBjb250cm9scyBob3cgb2Z0ZW4gdGhlIGhlYXAgaXMgY29tcGFjdGVk LCB3aGljaCBpcyB1c2VmdWwKKwlpZiB0aGVyZSBhcmUgYnVyc3Qgb2YgYWN0 aXZpdHkgZm9sbG93ZWQgYnkgbG9uZyBwZXJpb2RzIG9mIGlkbGUgc3RhdGUs CisJb3IgaWYgYSBkb21haW4gcXVpdHMsIGV0Yy4gQ29tcGFjdGlvbiByZXR1 cm5zIG1lbW9yeSB0byB0aGUgT1MuCisKKwl3YXN0ZWQgPSBsaXZlICogc3Bh Y2Vfb3ZlcmhlYWQgLyAxMDAKKworCUZvciBnbG9iYWxseSBvdmVycmlkaW5n IHRoZSBHQyBzZXR0aW5ncyBvbmUgY2FuIHVzZSBPQ0FNTFJVTlBBUkFNLAor CWhvd2V2ZXIgd2UgcHJvdmlkZSBhIGNvbmZpZyBmaWxlIG92ZXJyaWRlIHRv IGJlIGNvbnNpc3RlbnQgd2l0aCBvdGhlcgorCW94ZW5zdG9yZWQgc2V0dGlu Z3MuCisKKwlPbmUgbWlnaHQgd2FudCB0byBkeW5hbWljYWxseSBhZGp1c3Qg dGhlIG92ZXJoZWFkIHNldHRpbmcgYmFzZWQgb24gdXNlZAorCW1lbW9yeSwg aS5lLiB0byB1c2UgYSBmaXhlZCB1cHBlciBib3VuZCBpbiBieXRlcywgbm90 IHBlcmNlbnRhZ2UuIEhvd2V2ZXIKKwltZWFzdXJlbWVudHMgc2hvdyB0aGF0 IHN1Y2ggYWRqdXN0bWVudHMgaW5jcmVhc2UgR0Mgb3ZlcmhlYWQgbWFzc2l2 ZWx5LAorCXdoaWxlIHN0aWxsIG5vdCBndWFyYW50ZWVpbmcgdGhhdCBtZW1v cnkgaXMgcmV0dXJuZWQgYW55IG1vcmUgcXVpY2tseQorCXRoYW4gd2l0aCBh IHBlcmNlbnRhZ2UgYmFzZWQgc2V0dGluZy4KKworCVRoZSBhbGxvY2F0aW9u IHBvbGljeSBjb3VsZCBhbHNvIGJlIHR3ZWFrZWQsIGUuZy4gZmlyc3QgZml0 IHdvdWxkIHJlZHVjZQorCWZyYWdtZW50YXRpb24gYW5kIHRodXMgbWVtb3J5 IHVzYWdlLCBidXQgdGhlIGRvY3VtZW50YXRpb24gd2FybnMgdGhhdCBpdAor CWNhbiBiZSBzZW5zaWJseSBzbG93ZXIsIGFuZCBpbmRlZWQgb25lIG9mIG91 ciBvd24gdGVzdGNhc2VzIGNhbiB0cmlnZ2VyCisJc3VjaCBhIGNvcm5lciBj YXNlIHdoZXJlIGl0IGlzIG11bHRpcGxlIHRpbWVzIHNsb3dlciwgc28gaXQg aXMgYmVzdCB0byBrZWVwCisJdGhlIGRlZmF1bHQgYWxsb2NhdGlvbiBwb2xp Y3kgKG5leHQtZml0L2Jlc3QtZml0IGRlcGVuZGluZyBvbiB2ZXJzaW9uKS4K KworCVRoZXJlIGFyZSBvdGhlciB0d2Vha3MgdGhhdCBjYW4gYmUgYXR0ZW1w dGVkIGluIHRoZSBmdXR1cmUsIGUuZy4gc2V0dGluZworCSd1bGltaXQgLXYn IHRvIDc1JSBvZiBSQU0sIGhvd2V2ZXIgZ2V0dGluZyB0aGUga2VybmVsIHRv IGFjdHVhbGx5IHJldHVybgorCU5VTEwgZnJvbSBhbGxvY2F0aW9ucyBpcyBk aWZmaWN1bHQgZXZlbiB3aXRoIHRoYXQgc2V0dGluZywgYW5kIHdpdGhvdXQg YQorCU5VTEwgdGhlIGVtZXJnZW5jeSBHQyB3b24ndCBiZSB0cmlnZ2VycmVk LgorCVBlcmhhcHMgY2dyb3VwIGxpbWl0cyBjb3VsZCBoZWxwLCBidXQgZm9y IG5vdyB0d2VhayB0aGUgc2FmZXN0IG9ubHkuCisqKQorCitsZXQgdHdlYWtf Z2MgKCkgPQorCUdjLnNldCB7IChHYy5nZXQgKCkpIHdpdGggR2MubWF4X292 ZXJoZWFkID0gIURlZmluZS5nY19tYXhfb3ZlcmhlYWQgfQorCisKIGxldCBf ID0KIAlsZXQgY2YgPSBkb19hcmd2IGluCiAJbGV0IHBpZGZpbGUgPQpAQCAt Mjc0LDYgKzMzNiw4IEBAIGxldCBfID0KIAkJCWRlZmF1bHRfcGlkZmlsZQog CQlpbgogCisJdHdlYWtfZ2MgKCk7CisKIAkodHJ5CiAJCVVuaXhleHQubWtk aXJfcmVjIChGaWxlbmFtZS5kaXJuYW1lIHBpZGZpbGUpIDBvNzU1CiAJd2l0 aCBfIC0+Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-oxenstored-04.patch" Content-Disposition: attachment; filename="xsa326/xsa326-oxenstored-04.patch" Content-Transfer-Encoding: base64 RnJvbSBlOWFmMzlmMGI0ZDQ3MDIyYmFiZTNkYmEzOGQ4M2Q3ZWI4MmQ4YTNl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMiArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogQ2hhbmdlIFhiLmlucHV0IHRvIHJldHVybiBQ YWNrZXQudCBvcHRpb24KTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBl OiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXIt RW5jb2Rpbmc6IDhiaXQKClRoZSBxdWV1ZSBoZXJlIHdvdWxkIG9ubHkgZXZl ciBob2xkIGF0IG1vc3Qgb25lIGVsZW1lbnQuICBUaGlzIHdpbGwgc2ltcGxp ZnkKZm9sbG93LXVwIHBhdGNoZXMuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMy Ni4KClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24u Y29tPgpTaWduZWQtb2ZmLWJ5OiBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jv a0BjaXRyaXguY29tPgpBY2tlZC1ieTogQ2hyaXN0aWFuIExpbmRpZyA8Y2hy aXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xz L29jYW1sL2xpYnMveGIveGIubWwgYi90b29scy9vY2FtbC9saWJzL3hiL3hi Lm1sCmluZGV4IDg0MDRkZGQ4YTY4Mi4uMTY1ZmQ0YTFlZGY0IDEwMDY0NAot LS0gYS90b29scy9vY2FtbC9saWJzL3hiL3hiLm1sCisrKyBiL3Rvb2xzL29j YW1sL2xpYnMveGIveGIubWwKQEAgLTQ1LDcgKzQ1LDYgQEAgdHlwZSBwYXJ0 aWFsX2J1ZiA9IEhhdmVIZHIgb2YgUGFydGlhbC5wa3QgfCBOb0hkciBvZiBp bnQgKiBieXRlcwogdHlwZSB0ID0KIHsKIAliYWNrZW5kOiBiYWNrZW5kOwot CXBrdF9pbjogUGFja2V0LnQgUXVldWUudDsKIAlwa3Rfb3V0OiBQYWNrZXQu dCBRdWV1ZS50OwogCW11dGFibGUgcGFydGlhbF9pbjogcGFydGlhbF9idWY7 CiAJbXV0YWJsZSBwYXJ0aWFsX291dDogc3RyaW5nOwpAQCAtNjIsNyArNjEs NiBAQCBsZXQgcmVjb25uZWN0IHQgPSBtYXRjaCB0LmJhY2tlbmQgd2l0aAog CQlYc19yaW5nLmNsb3NlIGJhY2tlbmQubW1hcDsKIAkJYmFja2VuZC5ldmVu dGNobl9ub3RpZnkgKCk7CiAJCSgqIENsZWFyIG91ciBvbGQgY29ubmVjdGlv biBzdGF0ZSAqKQotCQlRdWV1ZS5jbGVhciB0LnBrdF9pbjsKIAkJUXVldWUu Y2xlYXIgdC5wa3Rfb3V0OwogCQl0LnBhcnRpYWxfaW4gPC0gaW5pdF9wYXJ0 aWFsX2luICgpOwogCQl0LnBhcnRpYWxfb3V0IDwtICIiCkBAIC0xMjQsNyAr MTIyLDYgQEAgbGV0IG91dHB1dCBjb24gPQogCiAoKiBOQjogY2FuIHRocm93 IFJlY29ubmVjdCAqKQogbGV0IGlucHV0IGNvbiA9Ci0JbGV0IG5ld3BhY2tl dCA9IHJlZiBmYWxzZSBpbgogCWxldCB0b19yZWFkID0KIAkJbWF0Y2ggY29u LnBhcnRpYWxfaW4gd2l0aAogCQl8IEhhdmVIZHIgcGFydGlhbF9wa3QgLT4g UGFydGlhbC50b19jb21wbGV0ZSBwYXJ0aWFsX3BrdApAQCAtMTQzLDIxICsx NDAsMTkgQEAgbGV0IGlucHV0IGNvbiA9CiAJCWlmIFBhcnRpYWwudG9fY29t cGxldGUgcGFydGlhbF9wa3QgPSAwIHRoZW4gKAogCQkJbGV0IHBrdCA9IFBh Y2tldC5vZl9wYXJ0aWFscGt0IHBhcnRpYWxfcGt0IGluCiAJCQljb24ucGFy dGlhbF9pbiA8LSBpbml0X3BhcnRpYWxfaW4gKCk7Ci0JCQlRdWV1ZS5wdXNo IHBrdCBjb24ucGt0X2luOwotCQkJbmV3cGFja2V0IDo9IHRydWUKLQkJKQor CQkJU29tZSBwa3QKKwkJKSBlbHNlIE5vbmUKIAl8IE5vSGRyIChpLCBidWYp ICAgICAgLT4KIAkJKCogd2UgY29tcGxldGUgdGhlIHBhcnRpYWwgaGVhZGVy ICopCiAJCWlmIHN6ID4gMCB0aGVuCiAJCQlCeXRlcy5ibGl0IGIgMCBidWYg KFBhcnRpYWwuaGVhZGVyX3NpemUgKCkgLSBpKSBzejsKIAkJY29uLnBhcnRp YWxfaW4gPC0gaWYgc3ogPSBpIHRoZW4KLQkJCUhhdmVIZHIgKFBhcnRpYWwu b2Zfc3RyaW5nIChCeXRlcy50b19zdHJpbmcgYnVmKSkgZWxzZSBOb0hkciAo aSAtIHN6LCBidWYpCi0JKTsKLQkhbmV3cGFja2V0CisJCQlIYXZlSGRyIChQ YXJ0aWFsLm9mX3N0cmluZyAoQnl0ZXMudG9fc3RyaW5nIGJ1ZikpIGVsc2Ug Tm9IZHIgKGkgLSBzeiwgYnVmKTsKKwkJTm9uZQorCSkKIAogbGV0IG5ld2Nv biBiYWNrZW5kID0gewogCWJhY2tlbmQgPSBiYWNrZW5kOwotCXBrdF9pbiA9 IFF1ZXVlLmNyZWF0ZSAoKTsKIAlwa3Rfb3V0ID0gUXVldWUuY3JlYXRlICgp OwogCXBhcnRpYWxfaW4gPSBpbml0X3BhcnRpYWxfaW4gKCk7CiAJcGFydGlh bF9vdXQgPSAiIjsKQEAgLTE5Myw5ICsxODgsNiBAQCBsZXQgaGFzX291dHB1 dCBjb24gPSBoYXNfbmV3X291dHB1dCBjb24gfHwgaGFzX29sZF9vdXRwdXQg Y29uCiAKIGxldCBwZWVrX291dHB1dCBjb24gPSBRdWV1ZS5wZWVrIGNvbi5w a3Rfb3V0CiAKLWxldCBpbnB1dF9sZW4gY29uID0gUXVldWUubGVuZ3RoIGNv bi5wa3RfaW4KLWxldCBoYXNfaW5fcGFja2V0IGNvbiA9IFF1ZXVlLmxlbmd0 aCBjb24ucGt0X2luID4gMAotbGV0IGdldF9pbl9wYWNrZXQgY29uID0gUXVl dWUucG9wIGNvbi5wa3RfaW4KIGxldCBoYXNfcGFydGlhbF9pbnB1dCBjb24g PSBtYXRjaCBjb24ucGFydGlhbF9pbiB3aXRoCiAJfCBIYXZlSGRyIF8gLT4g dHJ1ZQogCXwgTm9IZHIgKG4sIF8pIC0+IG4gPCBQYXJ0aWFsLmhlYWRlcl9z aXplICgpCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aSBiL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWxpCmluZGV4IDc5NGUzNWJi MzQzZS4uOTFjNjgyMTYyY2VhIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9s aWJzL3hiL3hiLm1saQorKysgYi90b29scy9vY2FtbC9saWJzL3hiL3hiLm1s aQpAQCAtNzcsNyArNzcsNyBAQCB2YWwgd3JpdGVfZmQgOiBiYWNrZW5kX2Zk IC0+ICdhIC0+IHN0cmluZyAtPiBpbnQgLT4gaW50CiB2YWwgd3JpdGVfbW1h cCA6IGJhY2tlbmRfbW1hcCAtPiAnYSAtPiBzdHJpbmcgLT4gaW50IC0+IGlu dAogdmFsIHdyaXRlIDogdCAtPiBzdHJpbmcgLT4gaW50IC0+IGludAogdmFs IG91dHB1dCA6IHQgLT4gYm9vbAotdmFsIGlucHV0IDogdCAtPiBib29sCit2 YWwgaW5wdXQgOiB0IC0+IFBhY2tldC50IG9wdGlvbgogdmFsIG5ld2NvbiA6 IGJhY2tlbmQgLT4gdAogdmFsIG9wZW5fZmQgOiBVbml4LmZpbGVfZGVzY3Ig LT4gdAogdmFsIG9wZW5fbW1hcCA6IFhlbm1tYXAubW1hcF9pbnRlcmZhY2Ug LT4gKHVuaXQgLT4gdW5pdCkgLT4gdApAQCAtODksMTAgKzg5LDcgQEAgdmFs IGhhc19uZXdfb3V0cHV0IDogdCAtPiBib29sCiB2YWwgaGFzX29sZF9vdXRw dXQgOiB0IC0+IGJvb2wKIHZhbCBoYXNfb3V0cHV0IDogdCAtPiBib29sCiB2 YWwgcGVla19vdXRwdXQgOiB0IC0+IFBhY2tldC50Ci12YWwgaW5wdXRfbGVu IDogdCAtPiBpbnQKLXZhbCBoYXNfaW5fcGFja2V0IDogdCAtPiBib29sCiB2 YWwgaGFzX3BhcnRpYWxfaW5wdXQgOiB0IC0+IGJvb2wKLXZhbCBnZXRfaW5f cGFja2V0IDogdCAtPiBQYWNrZXQudAogdmFsIGhhc19tb3JlX2lucHV0IDog dCAtPiBib29sCiB2YWwgaXNfc2VsZWN0YWJsZSA6IHQgLT4gYm9vbAogdmFs IGdldF9mZCA6IHQgLT4gVW5peC5maWxlX2Rlc2NyCmRpZmYgLS1naXQgYS90 b29scy9vY2FtbC9saWJzL3hzL3hzcmF3Lm1sIGIvdG9vbHMvb2NhbWwvbGli cy94cy94c3Jhdy5tbAppbmRleCBkOTgyZmIyNGRiYjEuLjQ1MWY4YjM4ZGJj YyAxMDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94cy94c3Jhdy5tbAor KysgYi90b29scy9vY2FtbC9saWJzL3hzL3hzcmF3Lm1sCkBAIC05NCwyNiAr OTQsMTggQEAgbGV0IHBrdF9zZW5kIGNvbiA9CiAJZG9uZQogCiAoKiByZWNl aXZlIG9uZSBwYWNrZXQgLSBjYW4gc2xlZXAgKikKLWxldCBwa3RfcmVjdiBj b24gPQotCWxldCB3b3JrZG9uZSA9IHJlZiBmYWxzZSBpbgotCXdoaWxlIG5v dCAhd29ya2RvbmUKLQlkbwotCQl3b3JrZG9uZSA6PSBYYi5pbnB1dCBjb24u eGIKLQlkb25lOwotCVhiLmdldF9pbl9wYWNrZXQgY29uLnhiCitsZXQgcmVj IHBrdF9yZWN2IGNvbiA9CisJbWF0Y2ggWGIuaW5wdXQgY29uLnhiIHdpdGgK Kwl8IFNvbWUgcGFja2V0IC0+IHBhY2tldAorCXwgTm9uZSAtPiBwa3RfcmVj diBjb24KIAogbGV0IHBrdF9yZWN2X3RpbWVvdXQgY29uIHRpbWVvdXQgPQog CWxldCBmZCA9IFhiLmdldF9mZCBjb24ueGIgaW4KIAlsZXQgciwgXywgXyA9 IFVuaXguc2VsZWN0IFsgZmQgXSBbXSBbXSB0aW1lb3V0IGluCiAJaWYgciA9 IFtdIHRoZW4KIAkJdHJ1ZSwgTm9uZQotCWVsc2UgKAotCQlsZXQgd29ya2Rv bmUgPSBYYi5pbnB1dCBjb24ueGIgaW4KLQkJaWYgd29ya2RvbmUgdGhlbgot CQkJZmFsc2UsIChTb21lIChYYi5nZXRfaW5fcGFja2V0IGNvbi54YikpCi0J CWVsc2UKLQkJCWZhbHNlLCBOb25lCi0JKQorCWVsc2UKKwkJZmFsc2UsIFhi LmlucHV0IGNvbi54YgogCiBsZXQgcXVldWVfd2F0Y2hldmVudCBjb24gZGF0 YSA9CiAJbGV0IGxzID0gc3BsaXRfc3RyaW5nIH5saW1pdDoyICdcMDAwJyBk YXRhIGluCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvY29u bmVjdGlvbi5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9u Lm1sCmluZGV4IDY0MTgwYmIyZDVmNi4uM2Y2YThmMWFkMGY3IDEwMDY0NAot LS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQvY29ubmVjdGlvbi5tbAorKysg Yi90b29scy9vY2FtbC94ZW5zdG9yZWQvY29ubmVjdGlvbi5tbApAQCAtMjc3 LDkgKzI3Nyw3IEBAIGxldCBnZXRfdHJhbnNhY3Rpb24gY29uIHRpZCA9CiAJ SGFzaHRibC5maW5kIGNvbi50cmFuc2FjdGlvbnMgdGlkCiAKIGxldCBkb19p bnB1dCBjb24gPSBYZW5idXMuWGIuaW5wdXQgY29uLnhiCi1sZXQgaGFzX2lu cHV0IGNvbiA9IFhlbmJ1cy5YYi5oYXNfaW5fcGFja2V0IGNvbi54YgogbGV0 IGhhc19wYXJ0aWFsX2lucHV0IGNvbiA9IFhlbmJ1cy5YYi5oYXNfcGFydGlh bF9pbnB1dCBjb24ueGIKLWxldCBwb3BfaW4gY29uID0gWGVuYnVzLlhiLmdl dF9pbl9wYWNrZXQgY29uLnhiCiBsZXQgaGFzX21vcmVfaW5wdXQgY29uID0g WGVuYnVzLlhiLmhhc19tb3JlX2lucHV0IGNvbi54YgogCiBsZXQgaGFzX291 dHB1dCBjb24gPSBYZW5idXMuWGIuaGFzX291dHB1dCBjb24ueGIKQEAgLTMw Nyw3ICszMDUsNyBAQCBsZXQgaXNfYmFkIGNvbiA9IG1hdGNoIGNvbi5kb20g d2l0aCBOb25lIC0+IGZhbHNlIHwgU29tZSBkb20gLT4gRG9tYWluLmlzX2Jh ZF9kbwogICAgUmVzdHJpY3Rpb25zIGJlbG93IGNhbiBiZSByZWxheGVkIG9u Y2UgeGVuc3RvcmVkIGxlYXJucyB0byBkdW1wIG1vcmUKICAgIG9mIGl0cyBs aXZlIHN0YXRlIGluIGEgc2FmZSB3YXkgKikKIGxldCBoYXNfZXh0cmFfY29u bmVjdGlvbl9kYXRhIGNvbiA9Ci0JbGV0IGhhc19pbiA9IGhhc19pbnB1dCBj b24gfHwgaGFzX3BhcnRpYWxfaW5wdXQgY29uIGluCisJbGV0IGhhc19pbiA9 IGhhc19wYXJ0aWFsX2lucHV0IGNvbiBpbgogCWxldCBoYXNfb3V0ID0gaGFz X291dHB1dCBjb24gaW4KIAlsZXQgaGFzX25vbmRlZmF1bHRfcGVybXMgPSBt YWtlX3Blcm0gY29uLmRvbSA8PiBjb24ucGVybSBpbgogCWhhc19pbiB8fCBo YXNfb3V0CmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvcHJv Y2Vzcy5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9wcm9jZXNzLm1sCmlu ZGV4IDNhZWY0ZTQ2NzNmOS4uNjlhOTZmMmRhOGU5IDEwMDY0NAotLS0gYS90 b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbAorKysgYi90b29scy9v Y2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbApAQCAtMTk1LDEwICsxOTUsOSBA QCBsZXQgcGFyc2VfbGl2ZV91cGRhdGUgYXJncyA9CiAJCQl8IF8gd2hlbiBV bml4LmdldHRpbWVvZmRheSAoKSA8IHQuZGVhZGxpbmUgLT4gZmFsc2UKIAkJ CXwgbCAtPgogCQkJCXdhcm4gInRpbWVvdXQgcmVhY2hlZDogaGF2ZSB0byB3 YWl0LCBtaWdyYXRlIG9yIHNodXRkb3duICVkIGRvbWFpbnM6IiAoTGlzdC5s ZW5ndGggbCk7Ci0JCQkJbGV0IG1zZ3MgPSBMaXN0LnJldl9tYXAgKGZ1biBj b24gLT4gUHJpbnRmLnNwcmludGYgIiVzOiAlZCB0eCwgaW46ICViLCBvdXQ6 ICViLCBwZXJtOiAlcyIKKwkJCQlsZXQgbXNncyA9IExpc3QucmV2X21hcCAo ZnVuIGNvbiAtPiBQcmludGYuc3ByaW50ZiAiJXM6ICVkIHR4LCBvdXQ6ICVi LCBwZXJtOiAlcyIKIAkJCQkJKENvbm5lY3Rpb24uZ2V0X2RvbXN0ciBjb24p CiAJCQkJCShDb25uZWN0aW9uLm51bWJlcl9vZl90cmFuc2FjdGlvbnMgY29u KQotCQkJCQkoQ29ubmVjdGlvbi5oYXNfaW5wdXQgY29uKQogCQkJCQkoQ29u bmVjdGlvbi5oYXNfb3V0cHV0IGNvbikKIAkJCQkJKENvbm5lY3Rpb24uZ2V0 X3Blcm0gY29uIHw+IFBlcm1zLkNvbm5lY3Rpb24udG9fc3RyaW5nKQogCQkJ CQkpIGwgaW4KQEAgLTcwNiwxNiArNzA1LDE3IEBAIGxldCBkb19pbnB1dCBz dG9yZSBjb25zIGRvbXMgY29uID0KIAkJCWluZm8gIiVzIHJlcXVlc3RzIGEg cmVjb25uZWN0IiAoQ29ubmVjdGlvbi5nZXRfZG9tc3RyIGNvbik7CiAJCQlI aXN0b3J5LnJlY29ubmVjdCBjb247CiAJCQlpbmZvICIlcyByZWNvbm5lY3Rp b24gY29tcGxldGUiIChDb25uZWN0aW9uLmdldF9kb21zdHIgY29uKTsKLQkJ CWZhbHNlCisJCQlOb25lCiAJCXwgRmFpbHVyZSBleHAgLT4KIAkJCWVycm9y ICJjYXVnaHQgZXhjZXB0aW9uICVzIiBleHA7CiAJCQllcnJvciAiZ290IGEg YmFkIGNsaWVudCAlcyIgKHNwcmludGYgIiUtOHMiIChDb25uZWN0aW9uLmdl dF9kb21zdHIgY29uKSk7CiAJCQlDb25uZWN0aW9uLm1hcmtfYXNfYmFkIGNv bjsKLQkJCWZhbHNlCisJCQlOb25lCiAJaW4KIAotCWlmIG5ld3BhY2tldCB0 aGVuICgKLQkJbGV0IHBhY2tldCA9IENvbm5lY3Rpb24ucG9wX2luIGNvbiBp bgorCW1hdGNoIG5ld3BhY2tldCB3aXRoCisJfCBOb25lIC0+ICgpCisJfCBT b21lIHBhY2tldCAtPgogCQlsZXQgdGlkLCByaWQsIHR5LCBkYXRhID0gWGVu YnVzLlhiLlBhY2tldC51bnBhY2sgcGFja2V0IGluCiAJCWxldCByZXEgPSB7 UGFja2V0LnRpZD10aWQ7IFBhY2tldC5yaWQ9cmlkOyBQYWNrZXQudHk9dHk7 IFBhY2tldC5kYXRhPWRhdGF9IGluCiAKQEAgLTcyNSw4ICs3MjUsNyBAQCBs ZXQgZG9faW5wdXQgc3RvcmUgY29ucyBkb21zIGNvbiA9CiAJCSAgICAgICAg IChYZW5idXMuWGIuT3AudG9fc3RyaW5nIHR5KSAoc2FuaXRpemVfZGF0YSBk YXRhKTsgKikKIAkJcHJvY2Vzc19wYWNrZXQgfnN0b3JlIH5jb25zIH5kb21z IH5jb24gfnJlcTsKIAkJd3JpdGVfYWNjZXNzX2xvZyB+dHkgfnRpZCB+Y29u OihDb25uZWN0aW9uLmdldF9kb21zdHIgY29uKSB+ZGF0YTsKLQkJQ29ubmVj dGlvbi5pbmNyX29wcyBjb247Ci0JKQorCQlDb25uZWN0aW9uLmluY3Jfb3Bz IGNvbgogCiBsZXQgZG9fb3V0cHV0IF9zdG9yZSBfY29ucyBfZG9tcyBjb24g PQogCWlmIENvbm5lY3Rpb24uaGFzX291dHB1dCBjb24gdGhlbiAoCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-oxenstored-05.patch" Content-Disposition: attachment; filename="xsa326/xsa326-oxenstored-05.patch" Content-Transfer-Encoding: base64 RnJvbSA0MDk5ODUzNWI2ZDFiOGU3NjcwZGExYzRlYTgxYjZkOGQ4OTk0YzE4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowMyArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbC94YjogQWRkIEJvdW5kZWRRdWV1ZQpNSU1FLVZl cnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9 VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKRW5zdXJl cyB3ZSBjYW5ub3Qgc3RvcmUgbW9yZSB0aGFuIFtjYXBhY2l0eV0gZWxlbWVu dHMgaW4gYSBbUXVldWVdLiAgUmVwbGFjaW5nCmFsbCBRdWV1ZSB3aXRoIHRo aXMgbW9kdWxlIHdpbGwgdGhlbiBlbnN1cmUgYXQgY29tcGlsZSB0aW1lIHRo YXQgYWxsIFF1ZXVlcwphcmUgY29ycmVjdGx5IGJvdW5kIGNoZWNrZWQuCgpF YWNoIGVsZW1lbnQgaW4gdGhlIHF1ZXVlIGhhcyBhIGNsYXNzIHdpdGggaXRz IG93biBsaW1pdHMuICBUaGlzLCBpbiBhCnN1YnNlcXVlbnQgY2hhbmdlLCB3 aWxsIGVuc3VyZSB0aGF0IGNvbW1hbmQgcmVzcG9uc2VzIGNhbiBwcm9jZWVk IGR1cmluZyBhCmZsb29kIG9mIHdhdGNoIGV2ZW50cy4KCk5vIGZ1bmN0aW9u YWwgY2hhbmdlLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRl ZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVk LW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5k aWdAY2l0cml4LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJz L3hiL3hiLm1sIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbAppbmRleCAx NjVmZDRhMWVkZjQuLjQxOTdhMzg4OGE2OCAxMDA2NDQKLS0tIGEvdG9vbHMv b2NhbWwvbGlicy94Yi94Yi5tbAorKysgYi90b29scy9vY2FtbC9saWJzL3hi L3hiLm1sCkBAIC0xNyw2ICsxNyw5OCBAQAogbW9kdWxlIE9wID0gc3RydWN0 IGluY2x1ZGUgT3AgZW5kCiBtb2R1bGUgUGFja2V0ID0gc3RydWN0IGluY2x1 ZGUgUGFja2V0IGVuZAogCittb2R1bGUgQm91bmRlZFF1ZXVlIDogc2lnCisJ dHlwZSAoJ2EsICdiKSB0CisKKwkoKiogW2NyZWF0ZSB+Y2FwYWNpdHkgfmNs YXNzaWZ5IH5saW1pdF0gY3JlYXRlcyBhIHF1ZXVlIHdpdGggbWF4aW11bSBb Y2FwYWNpdHldIGVsZW1lbnRzLgorCSAgICBUaGlzIGlzIGJ1cnN0IGNhcGFj aXR5LCBlYWNoIGVsZW1lbnQgaXMgZnVydGhlciBjbGFzc2lmaWVkIGFjY29y ZGluZyB0byBbY2xhc3NpZnldLAorCSAgICBhbmQgZWFjaCBjbGFzcyBjYW4g aGF2ZSBpdHMgb3duIFtsaW1pdF0uCisJICAgIFtjYXBhY2l0eV0gaXMgZW5m b3JjZWQgYXMgYW4gb3ZlcmFsbCBsaW1pdC4KKwkgICAgVGhlIFtsaW1pdF0g Y2FuIGJlIGR5bmFtaWMsIGFuZCBjYW4gYmUgc21hbGxlciB0aGFuIHRoZSBu dW1iZXIgb2YgZWxlbWVudHMgYWxyZWFkeSBxdWV1ZWQgb2YgdGhhdCBjbGFz cywKKwkgICAgaW4gd2hpY2ggY2FzZSB0aG9zZSBlbGVtZW50cyBhcmUgY29u c2lkZXJlZCB0byB1c2UgImJ1cnN0IGNhcGFjaXR5Ii4KKwkgICopCisJdmFs IGNyZWF0ZTogY2FwYWNpdHk6aW50IC0+IGNsYXNzaWZ5OignYSAtPiAnYikg LT4gbGltaXQ6KCdiIC0+IGludCkgLT4gKCdhLCAnYikgdAorCisJKCoqIFtj bGVhciBxXSBkaXNjYXJkcyBhbGwgZWxlbWVudHMgZnJvbSBbcV0gKikKKwl2 YWwgY2xlYXI6ICgnYSwgJ2IpIHQgLT4gdW5pdAorCisJKCoqIFtjYW5fcHVz aCBxXSB3aGVuIFtsZW5ndGggcSA8IGNhcGFjaXR5XS4JKikKKwl2YWwgY2Fu X3B1c2g6ICgnYSwgJ2IpIHQgLT4gJ2IgLT4gYm9vbAorCisJKCoqIFtwdXNo IGUgcV0gYWRkcyBbZV0gYXQgdGhlIGVuZCBvZiBxdWV1ZSBbcV0gaWYgW2Nh bl9wdXNoIHFdLCBvciByZXR1cm5zIFtOb25lXS4gKikKKwl2YWwgcHVzaDog J2EgLT4gKCdhLCAnYikgdCAtPiB1bml0IG9wdGlvbgorCisJKCoqIFtwb3Ag cV0gcmVtb3ZlcyBhbmQgcmV0dXJucyBmaXJzdCBlbGVtZW50IGluIFtxXSwg b3IgcmFpc2VzIFtRdWV1ZS5FbXB0eV0uICopCisJdmFsIHBvcDogKCdhLCAn YikgdCAtPiAnYQorCisJKCoqIFtwZWVrIHFdIHJldHVybnMgdGhlIGZpcnN0 IGVsZW1lbnQgaW4gW3FdLCBvciByYWlzZXMgW1F1ZXVlLkVtcHR5XS4gICop CisJdmFsIHBlZWsgOiAoJ2EsICdiKSB0IC0+ICdhCisKKwkoKiogW2xlbmd0 aCBxXSByZXR1cm5zIHRoZSBjdXJyZW50IG51bWJlciBvZiBlbGVtZW50cyBp biBbcV0gKikKKwl2YWwgbGVuZ3RoOiAoJ2EsICdiKSB0IC0+IGludAorCisJ KCoqIFtkZWJ1ZyBzdHJpbmdfb2ZfY2xhc3MgcV0gcHJpbnRzIHF1ZXVlIHVz YWdlIHN0YXRpc3RpY3MgaW4gYW4gdW5zcGVjaWZpZWQgaW50ZXJuYWwgZm9y bWF0LiAqKQorCXZhbCBkZWJ1ZzogKCdiIC0+IHN0cmluZykgLT4gKF8sICdi KSB0IC0+IHN0cmluZworZW5kID0gc3RydWN0CisJdHlwZSAoJ2EsICdiKSB0 ID0KKwkJeyBxOiAnYSBRdWV1ZS50CisJCTsgY2FwYWNpdHk6IGludAorCQk7 IGNsYXNzaWZ5OiAnYSAtPiAnYgorCQk7IGxpbWl0OiAnYiAtPiBpbnQKKwkJ OyBjbGFzc19jb3VudDogKCdiLCBpbnQpIEhhc2h0YmwudAorCQl9CisKKwls ZXQgY3JlYXRlIH5jYXBhY2l0eSB+Y2xhc3NpZnkgfmxpbWl0ID0KKwkJeyBj YXBhY2l0eTsgcSA9IFF1ZXVlLmNyZWF0ZSAoKTsgY2xhc3NpZnk7IGxpbWl0 OyBjbGFzc19jb3VudCA9IEhhc2h0YmwuY3JlYXRlIDMgfQorCisJbGV0IGdl dF9jb3VudCB0IGNsYXNzaWZpY2F0aW9uID0gdHJ5IEhhc2h0YmwuZmluZCB0 LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0aW9uIHdpdGggTm90X2ZvdW5kIC0+ IDAKKworCWxldCBjYW5fcHVzaF9pbnRlcm5hbCB0IGNsYXNzaWZpY2F0aW9u IGNsYXNzX2NvdW50ID0KKwkJUXVldWUubGVuZ3RoIHQucSA8IHQuY2FwYWNp dHkgJiYgY2xhc3NfY291bnQgPCB0LmxpbWl0IGNsYXNzaWZpY2F0aW9uCisK KwlsZXQgb2sgPSBTb21lICgpCisKKwlsZXQgcHVzaCBlIHQgPQorCQlsZXQg Y2xhc3NpZmljYXRpb24gPSB0LmNsYXNzaWZ5IGUgaW4KKwkJbGV0IGNsYXNz X2NvdW50ID0gZ2V0X2NvdW50IHQgY2xhc3NpZmljYXRpb24gaW4KKwkJaWYg Y2FuX3B1c2hfaW50ZXJuYWwgdCBjbGFzc2lmaWNhdGlvbiBjbGFzc19jb3Vu dCB0aGVuIGJlZ2luCisJCQlRdWV1ZS5wdXNoIGUgdC5xOworCQkJSGFzaHRi bC5yZXBsYWNlIHQuY2xhc3NfY291bnQgY2xhc3NpZmljYXRpb24gKGNsYXNz X2NvdW50ICsgMSk7CisJCQlvaworCQllbmQKKwkJZWxzZQorCQkJTm9uZQor CisJbGV0IGNhbl9wdXNoIHQgY2xhc3NpZmljYXRpb24gPQorCQljYW5fcHVz aF9pbnRlcm5hbCB0IGNsYXNzaWZpY2F0aW9uIEBAIGdldF9jb3VudCB0IGNs YXNzaWZpY2F0aW9uCisKKwlsZXQgY2xlYXIgdCA9CisJCVF1ZXVlLmNsZWFy IHQucTsKKwkJSGFzaHRibC5yZXNldCB0LmNsYXNzX2NvdW50CisKKwlsZXQg cG9wIHQgPQorCQlsZXQgZSA9IFF1ZXVlLnBvcCB0LnEgaW4KKwkJbGV0IGNs YXNzaWZpY2F0aW9uID0gdC5jbGFzc2lmeSBlIGluCisJCWxldCAoKSA9IG1h dGNoIGdldF9jb3VudCB0IGNsYXNzaWZpY2F0aW9uIC0gMSB3aXRoCisJCXwg MCAtPiBIYXNodGJsLnJlbW92ZSB0LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0 aW9uICgqIHJlZHVjZXMgbWVtdXNhZ2UgKikKKwkJfCBuIC0+IEhhc2h0Ymwu cmVwbGFjZSB0LmNsYXNzX2NvdW50IGNsYXNzaWZpY2F0aW9uIG4KKwkJaW4K KwkJZQorCisJbGV0IHBlZWsgdCA9IFF1ZXVlLnBlZWsgdC5xCisJbGV0IGxl bmd0aCB0ID0gUXVldWUubGVuZ3RoIHQucQorCisJbGV0IGRlYnVnIHN0cmlu Z19vZl9jbGFzcyB0ID0KKwkJbGV0IGIgPSBCdWZmZXIuY3JlYXRlIDEyOCBp bgorCQlQcmludGYuYnByaW50ZiBiICJCb3VuZGVkUXVldWUgY2FwYWNpdHk6 ICVkLCB1c2VkOiB7IiB0LmNhcGFjaXR5OworCQlIYXNodGJsLml0ZXIgKGZ1 biBwYWNrZXRfY2xhc3MgY291bnQgLT4KKwkJCVByaW50Zi5icHJpbnRmIGIg IgklczogJWQiIChzdHJpbmdfb2ZfY2xhc3MgcGFja2V0X2NsYXNzKSBjb3Vu dAorCQkpIHQuY2xhc3NfY291bnQ7CisJCVByaW50Zi5icHJpbnRmIGIgIn0i OworCQlCdWZmZXIuY29udGVudHMgYgorZW5kCisKKwogZXhjZXB0aW9uIEVu ZF9vZl9maWxlCiBleGNlcHRpb24gRWFnYWluCiBleGNlcHRpb24gTm9lbnQK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-oxenstored-06.patch" Content-Disposition: attachment; filename="xsa326/xsa326-oxenstored-06.patch" Content-Transfer-Encoding: base64 RnJvbSAzNTgwOGY4NzZkNTI1NTE0Y2JjMTNkMmI4ZGFkZDM2NGZiMjA0MGMx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RWR3 aW49MjBUPUMzPUI2cj1DMz1CNms/PSA8ZWR2aW4udG9yb2tAY2l0cml4LmNv bT4KRGF0ZTogV2VkLCAxMiBPY3QgMjAyMiAxOToxMzowNCArMDEwMApTdWJq ZWN0OiB0b29scy9vY2FtbDogTGltaXQgbWF4aW11bSBpbi1mbGlnaHQgcmVx dWVzdHMgLyBvdXRzdGFuZGluZyByZXBsaWVzCk1JTUUtVmVyc2lvbjogMS4w CkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250 ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgpJbnRyb2R1Y2UgYSBsaW1p dCBvbiB0aGUgbnVtYmVyIG9mIG91dHN0YW5kaW5nIHJlcGx5IHBhY2tldHMg aW4gdGhlIHhlbmJ1cwpxdWV1ZS4gIFRoaXMgbGltaXRzIHRoZSBudW1iZXIg b2YgaW4tZmxpZ2h0IHJlcXVlc3RzOiB3aGVuIHRoZSBvdXRwdXQgcXVldWUg aXMKZnVsbCB3ZSdsbCBzdG9wIHByb2Nlc3NpbmcgaW5wdXRzIHVudGlsIHRo ZSBvdXRwdXQgcXVldWUgaGFzIHJvb20gYWdhaW4uCgpUbyBhdm9pZCBhIGJ1 c3kgbG9vcCBvbiB0aGUgVW5peCBzb2NrZXQgd2Ugb25seSBhZGQgaXQgdG8g dGhlIHdhdGNoZWQgaW5wdXQKZmlsZSBkZXNjcmlwdG9yIHNldCBpZiB3ZSdk IGJlIGFibGUgdG8gY2FsbCBgaW5wdXRgIG9uIGl0LiAgRXZlbiB0aG91Z2gg RG9tMAppcyB0cnVzdGVkIGFuZCBleGVtcHQgZnJvbSBxdW90YXMgYSBmbG9v ZCBvZiBldmVudHMgbWlnaHQgY2F1c2UgYSBiYWNrbG9nCndoZXJlIGV2ZW50 cyBhcmUgcHJvZHVjZWQgZmFzdGVyIHRoYW4gZGFlbW9ucyBpbiBEb20wIGNh biBjb25zdW1lIHRoZW0sIHdoaWNoCmNvdWxkIGxlYWQgdG8gYW4gdW5ib3Vu ZGVkIHF1ZXVlIHNpemUgYW5kIE9PTS4KClRoZXJlZm9yZSB0aGUgeGVuYnVz IHF1ZXVlIGxpbWl0IG11c3QgYXBwbHkgdG8gYWxsIGNvbm5lY3Rpb25zLCBE b20wIGlzIG5vdApleGVtcHQgZnJvbSBpdCwgYWx0aG91Z2ggaWYgZXZlcnl0 aGluZyB3b3JrcyBjb3JyZWN0bHkgaXQgd2lsbCBldmVudHVhbGx5CmNhdGNo IHVwLgoKVGhpcyBwcmV2ZW50cyBhIG1hbGljaW91cyBndWVzdCBmcm9tIHNl bmRpbmcgbW9yZSBjb21tYW5kcyB3aGlsZSBpdCBoYXMKb3V0c3RhbmRpbmcg d2F0Y2ggZXZlbnRzIG9yIGNvbW1hbmQgcmVwbGllcyBpbiBpdHMgaW5wdXQg cmluZy4gIEhvd2V2ZXIgaWYgaXQKY2FuIGNhdXNlIHRoZSBnZW5lcmF0aW9u IG9mIHdhdGNoIGV2ZW50cyBieSBvdGhlciBtZWFucyAoZS5nLiBieSBEb20w LCBvcgphbm90aGVyIGNvb3BlcmF0aXZlIGd1ZXN0KSBhbmQgc3RvcCByZWFk aW5nIGl0cyBvd24gcmluZyB0aGVuIHdhdGNoIGV2ZW50cwp3b3VsZCd2ZSBx dWV1ZWQgdXAgd2l0aG91dCBsaW1pdC4KClRoZSB4ZW5zdG9yZSBwcm90b2Nv bCBkb2Vzbid0IGhhdmUgYSBiYWNrLXByZXNzdXJlIG1lY2hhbmlzbSwgYW5k IGRvZXNuJ3QKYWxsb3cgZHJvcHBpbmcgd2F0Y2ggZXZlbnRzLiAgSW4gZmFj dCwgZHJvcHBpbmcgd2F0Y2ggZXZlbnRzIGlzIGtub3duIHRvIGJyZWFrCnNv bWUgcGllY2VzIG9mIG5vcm1hbCBmdW5jdGlvbmFsaXR5LiAgVGhpcyBsZWF2 ZXMgbGl0dGxlIGNob2ljZSB0byBzYWZlbHkKaW1wbGVtZW50IHRoZSB4ZW5z dG9yZSBwcm90b2NvbCB3aXRob3V0IGV4cG9zaW5nIHRoZSB4ZW5zdG9yZSBk YWVtb24gdG8Kb3V0LW9mLW1lbW9yeSBhdHRhY2tzLgoKSW1wbGVtZW50IHRo ZSBmaXggYXMgcGlwZXMgd2l0aCBib3VuZGVkIGJ1ZmZlcnM6CiogVXNlIGEg Ym91bmRlZCBidWZmZXIgZm9yIHdhdGNoIGV2ZW50cwoqIFRoZSB3YXRjaCBz dHJ1Y3R1cmUgd2lsbCBoYXZlIGEgYm91bmRlZCByZWNlaXZpbmcgcGlwZSBv ZiB3YXRjaCBldmVudHMKKiBUaGUgc291cmNlIHdpbGwgaGF2ZSBhbiAib3Zl cmZsb3ciIHBpcGUgb2YgcGVuZGluZyB3YXRjaCBldmVudHMgaXQgY291bGRu J3QKICBkZWxpdmVyCgpJdGVtcyBhcmUgcXVldWVkIHVwIG9uIG9uZSBlbmQg YW5kIGFyZSBzZW50IGFzIGZhciBhbG9uZyB0aGUgcGlwZSBhcyBwb3NzaWJs ZToKCiAgc291cmNlIGRvbWFpbiAtPiB3YXRjaCAtPiB4ZW5idXMgb2YgdGFy Z2V0IC0+IHhlbnN0b3JlIHJpbmcvc29ja2V0IG9mIHRhcmdldAoKSWYgdGhl IHBpcGUgaXMgImZ1bGwiIGF0IGFueSBwb2ludCB0aGVuIGJhY2stcHJlc3N1 cmUgaXMgYXBwbGllZCBhbmQgd2UgcHJldmVudAptb3JlIGl0ZW1zIGZyb20g YmVpbmcgcXVldWVkIHVwLiAgRm9yIHRoZSBzb3VyY2UgZG9tYWluIHRoaXMg bWVhbnMgdGhhdCB3ZSdsbApzdG9wIGFjY2VwdGluZyBuZXcgY29tbWFuZHMg YXMgbG9uZyBhcyBpdHMgcGlwZSBidWZmZXIgaXMgbm90IGVtcHR5LgoKQmVm b3JlIHdlIHRyeSB0byBlbnF1ZXVlIGFuIGl0ZW0gd2UgZmlyc3QgY2hlY2sg d2hldGhlciBpdCBpcyBwb3NzaWJsZSB0byBzZW5kCml0IGZ1cnRoZXIgZG93 biB0aGUgcGlwZSwgYnkgYXR0ZW1wdGluZyB0byByZWN1cnNpdmVseSBmbHVz aCB0aGUgcGlwZXMuIFRoaXMKZW5zdXJlcyB0aGF0IHdlIHJldGFpbiB0aGUg b3JkZXIgb2YgZXZlbnRzIGFzIG11Y2ggYXMgcG9zc2libGUuCgpXZSBtaWdo dCBicmVhayBjYXVzYWxpdHkgb2Ygd2F0Y2ggZXZlbnRzIGlmIHRoZSB0YXJn ZXQgZG9tYWluJ3MgcXVldWUgaXMgZnVsbAphbmQgd2UgbmVlZCB0byBzdGFy dCB1c2luZyB0aGUgd2F0Y2gncyBxdWV1ZS4gIFRoaXMgaXMgYSBicmVha2lu ZyBjaGFuZ2UgaW4KdGhlIHhlbnN0b3JlIHByb3RvY29sLCBidXQgb25seSBm b3IgZG9tYWlucyB3aGljaCBhcmUgbm90IHByb2Nlc3NpbmcgdGhlaXIKaW5j b21pbmcgcmluZyBhcyBleHBlY3RlZC4KCldoZW4gYSB3YXRjaCBpcyBkZWxl dGVkIGl0cyBlbnRpcmUgcGVuZGluZyBxdWV1ZSBpcyBkcm9wcGVkIChubyBj b2RlIGlzIG5lZWRlZApmb3IgdGhhdCwgYmVjYXVzZSBpdCBpcyBwYXJ0IG9m IHRoZSAnd2F0Y2gnIHR5cGUpLgoKVGhlcmUgaXMgYSBjYWNoZSBvZiB3YXRj aGVzIHRoYXQgaGF2ZSBwZW5kaW5nIGV2ZW50cyB0aGF0IHdlIGF0dGVtcHQg dG8gZmx1c2gKYXQgZXZlcnkgY3ljbGUgaWYgcG9zc2libGUuCgpJbnRyb2R1 Y2UgMyBsaW1pdHMgaGVyZToKKiBxdW90YS1tYXh3YXRjaGV2ZW50cyBvbiB3 YXRjaCBldmVudCBkZXN0aW5hdGlvbjogd2hlbiB0aGlzIGlzIGhpdCB0aGUK ICBzb3VyY2Ugd2lsbCBub3QgYmUgYWxsb3dlZCB0byBxdWV1ZSB1cCBtb3Jl IHdhdGNoIGV2ZW50cy4KKiBxdW90YS1tYXhvdXN0YW5kaW5nIHdoaWNoIGlz IHRoZSBudW1iZXIgb2YgcmVzcG9uc2VzIG5vdCByZWFkIGZyb20gdGhlIHJp bmc6CiAgb25jZSBleGNlZWRlZCwgbm8gbW9yZSBpbnB1dHMgYXJlIHByb2Nl c3NlZCB1bnRpbCBhbGwgb3V0c3RhbmRpbmcgcmVwbGllcwogIGFyZSBjb25z dW1lZCBieSB0aGUgY2xpZW50LgoqIG92ZXJmbG93IHF1ZXVlIG9uIHRoZSB3 YXRjaCBldmVudCBzb3VyY2U6IGFsbCB3YXRjaGVzIHRoYXQgY2Fubm90IGJl IHN0b3JlZAogIG9uIGRlc3RpbmF0aW9uIGFyZSBxdWV1ZWQgdXAgaGVyZSwg YSBzaW5nbGUgY29tbWFuZCBjYW4gdHJpZ2dlciBtdWx0aXBsZQogIHdhdGNo ZXMgKGUuZy4gZHVlIHRvIHJlY3Vyc2lvbikuCgpUaGUgb3ZlcmZsb3cgcXVl dWUgY3VycmVudGx5IGRvZXNuJ3QgaGF2ZSBhbiB1cHBlciBib3VuZCwgaXQg aXMgZGlmZmljdWx0IHRvCmFjY3VyYXRlbHkgY2FsY3VsYXRlIG9uZSBhcyBp dCBkZXBlbmRzIG9uIHdoZXRoZXIgeW91IGFyZSBEb20wIGFuZCBob3cgbWFu eQp3YXRjaGVzIGVhY2ggcGF0aCBoYXMgcmVnaXN0ZXJlZCBhbmQgaG93IG1h bnkgd2F0Y2ggZXZlbnRzIHlvdSBjYW4gdHJpZ2dlcgp3aXRoIGEgc2luZ2xl IGNvbW1hbmQgKGUuZy4gYSBjb21taXQpLiAgSG93ZXZlciB0aGVzZSBldmVu dHMgd2VyZSBhbHJlYWR5CnVzaW5nIG1lbW9yeSwgdGhpcyBqdXN0IG1vdmVz IHRoZW0gZWxzZXdoZXJlLCBhbmQgYXMgbG9uZyBhcyB3ZSBjb3JyZWN0bHkK YmxvY2sgYSBkb21haW4gaXQgc2hvdWxkbid0IHJlc3VsdCBpbiB1bmJvdW5k ZWQgbWVtb3J5IHVzYWdlLgoKTm90ZSB0aGF0IERvbTAgaXMgbm90IGV4Y2x1 ZGVkIGZyb20gdGhlc2UgY2hlY2tzLCBpdCBpcyBpbXBvcnRhbnQgdGhhdCBE b20wIGlzCmVzcGVjaWFsbHkgbm90IGV4Y2x1ZGVkIHdoZW4gaXQgaXMgdGhl IHNvdXJjZSwgc2luY2UgdGhlcmUgYXJlIG1hbnkgd2F5cyBpbgp3aGljaCBh IGd1ZXN0IGNvdWxkIHRyaWdnZXIgRG9tMCB0byBzZW5kIGl0IHdhdGNoIGV2 ZW50cy4KClRoaXMgc2hvdWxkIHByb3RlY3QgYWdhaW5zdCBtYWxpY2lvdXMg ZnJvbnRlbmRzIGFzIGxvbmcgYXMgdGhlIGJhY2tlbmQgZm9sbG93cwp0aGUg UFYgeGVuc3RvcmUgcHJvdG9jb2wgYW5kIG9ubHkgZXhwb3NlcyBwYXRocyBu ZWVkZWQgYnkgdGhlIGZyb250ZW5kLCBhbmQKY2hhbmdlcyB0aG9zZSBwYXRo cyBhdCBtb3N0IG9uY2UgYXMgYSByZWFjdGlvbiB0byBndWVzdCBldmVudHMs IG9yIHByb3RvY29sCnN0YXRlLgoKVGhlIHF1ZXVlIGxpbWl0cyBhcmUgcGVy IHdhdGNoLCBhbmQgcGVyIGRvbWFpbi1wYWlyLCBzbyBldmVuIGlmIG9uZQpj b21tdW5pY2F0aW9uIGNoYW5uZWwgd291bGQgYmUgImJsb2NrZWQiLCBvdGhl cnMgd291bGQga2VlcCB3b3JraW5nLCBhbmQgdGhlCmRvbWFpbiBpdHNlbGYg d29uJ3QgZ2V0IGJsb2NrZWQgYXMgbG9uZyBhcyBpdCBkb2Vzbid0IG92ZXJm bG93IHRoZSBxdWV1ZSBvZgp3YXRjaCBldmVudHMuCgpTaW1pbGFybHkgYSBt YWxpY2lvdXMgYmFja2VuZCBjb3VsZCBjYXVzZSB0aGUgZnJvbnRlbmQgdG8g Z2V0IGJsb2NrZWQsIGJ1dAp0aGlzIHdhdGNoIHF1ZXVlIHByb3RlY3RzIHRo ZSBmcm9udGVuZCBhcyB3ZWxsIGFzIGxvbmcgYXMgaXQgZm9sbG93cyB0aGUg UFYKcHJvdG9jb2wuICAoQWx0aG91Z2ggbm90ZSB0aGF0IHByb3RlY3Rpb24g YWdhaW5zdCBtYWxpY2lvdXMgYmFja2VuZHMgaXMgb25seSBhCmJlc3QgZWZm b3J0IGF0IHRoZSBtb21lbnQpCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNiAv IENWRS0yMDIyLTQyMzE4LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLD tmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+CkFja2VkLWJ5OiBDaHJpc3Rp YW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbCBiL3Rvb2xzL29j YW1sL2xpYnMveGIveGIubWwKaW5kZXggNDE5N2EzODg4YTY4Li5iMjkyZWQ3 YTg3NGQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveGIveGIubWwK KysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbApAQCAtMTM0LDE0ICsx MzQsNDQgQEAgdHlwZSBiYWNrZW5kID0gRmQgb2YgYmFja2VuZF9mZCB8IFhl bm1tYXAgb2YgYmFja2VuZF9tbWFwCiAKIHR5cGUgcGFydGlhbF9idWYgPSBI YXZlSGRyIG9mIFBhcnRpYWwucGt0IHwgTm9IZHIgb2YgaW50ICogYnl0ZXMK IAorKCoKKwlzZXBhcmF0ZSBjYXBhY2l0eSByZXNlcnZhdGlvbiBmb3IgcmVw bGllcyBhbmQgd2F0Y2ggZXZlbnRzOgorCXRoaXMgYWxsb3dzIGEgZG9tYWlu IHRvIGtlZXAgd29ya2luZyBldmVuIHdoZW4gdW5kZXIgYSBjb25zdGFudCBm bG9vZCBvZgorCXdhdGNoIGV2ZW50cworKikKK3R5cGUgY2FwYWNpdHkgPSB7 IG1heG91dHN0YW5kaW5nOiBpbnQ7IG1heHdhdGNoZXZlbnRzOiBpbnQgfQor Cittb2R1bGUgUXVldWUgPSBCb3VuZGVkUXVldWUKKwordHlwZSBwYWNrZXRf Y2xhc3MgPQorCXwgQ29tbWFuZFJlcGx5CisJfCBXYXRjaGV2ZW50CisKK2xl dCBzdHJpbmdfb2ZfcGFja2V0X2NsYXNzID0gZnVuY3Rpb24KKwl8IENvbW1h bmRSZXBseSAtPiAiY29tbWFuZF9yZXBseSIKKwl8IFdhdGNoZXZlbnQgLT4g IndhdGNoX2V2ZW50IgorCiB0eXBlIHQgPQogewogCWJhY2tlbmQ6IGJhY2tl bmQ7Ci0JcGt0X291dDogUGFja2V0LnQgUXVldWUudDsKKwlwa3Rfb3V0OiAo UGFja2V0LnQsIHBhY2tldF9jbGFzcykgUXVldWUudDsKIAltdXRhYmxlIHBh cnRpYWxfaW46IHBhcnRpYWxfYnVmOwogCW11dGFibGUgcGFydGlhbF9vdXQ6 IHN0cmluZzsKKwljYXBhY2l0eTogY2FwYWNpdHkKIH0KIAorbGV0IHRvX3Jl YWQgY29uID0KKwltYXRjaCBjb24ucGFydGlhbF9pbiB3aXRoCisJCXwgSGF2 ZUhkciBwYXJ0aWFsX3BrdCAtPiBQYXJ0aWFsLnRvX2NvbXBsZXRlIHBhcnRp YWxfcGt0CisJCXwgTm9IZHIgICAoaSwgXykgICAgLT4gaQorCitsZXQgZGVi dWcgdCA9CisJUHJpbnRmLnNwcmludGYgIlhlbkJ1cyBzdGF0ZTogcGFydGlh bF9pbjogJWQgbmVlZGVkLCBwYXJ0aWFsX291dDogJWQgYnl0ZXMsIHBrdF9v dXQ6ICVkIHBhY2tldHMsICVzIgorCQkodG9fcmVhZCB0KQorCQkoU3RyaW5n Lmxlbmd0aCB0LnBhcnRpYWxfb3V0KQorCQkoUXVldWUubGVuZ3RoIHQucGt0 X291dCkKKwkJKEJvdW5kZWRRdWV1ZS5kZWJ1ZyBzdHJpbmdfb2ZfcGFja2V0 X2NsYXNzIHQucGt0X291dCkKKwogbGV0IGluaXRfcGFydGlhbF9pbiAoKSA9 IE5vSGRyCiAJKFBhcnRpYWwuaGVhZGVyX3NpemUgKCksIEJ5dGVzLm1ha2Ug KFBhcnRpYWwuaGVhZGVyX3NpemUoKSkgJ1wwMDAnKQogCkBAIC0xOTksNyAr MjI5LDggQEAgbGV0IG91dHB1dCBjb24gPQogCWxldCBzID0gaWYgU3RyaW5n Lmxlbmd0aCBjb24ucGFydGlhbF9vdXQgPiAwIHRoZW4KIAkJCWNvbi5wYXJ0 aWFsX291dAogCQllbHNlIGlmIFF1ZXVlLmxlbmd0aCBjb24ucGt0X291dCA+ IDAgdGhlbgotCQkJUGFja2V0LnRvX3N0cmluZyAoUXVldWUucG9wIGNvbi5w a3Rfb3V0KQorCQkJbGV0IHBrdCA9IFF1ZXVlLnBvcCBjb24ucGt0X291dCBp bgorCQkJUGFja2V0LnRvX3N0cmluZyBwa3QKIAkJZWxzZQogCQkJIiIgaW4K IAkoKiBzZW5kIGRhdGEgZnJvbSBzLCBhbmQgc2F2ZSB0aGUgdW5zZW50IGRh dGEgdG8gcGFydGlhbF9vdXQgKikKQEAgLTIxMiwxMiArMjQzLDE1IEBAIGxl dCBvdXRwdXQgY29uID0KIAkoKiBhZnRlciBzZW5kaW5nIG9uZSBwYWNrZXQs IHBhcnRpYWwgaXMgZW1wdHkgKikKIAljb24ucGFydGlhbF9vdXQgPSAiIgog CisoKiB3ZSBjYW4gb25seSBwcm9jZXNzIGFuIGlucHV0IHBhY2tldCBpZiB3 ZSdyZSBndWFyYW50ZWVkIHRvIGhhdmUgcm9vbQorICAgdG8gc3RvcmUgdGhl IHJlc3BvbnNlIHBhY2tldCAqKQorbGV0IGNhbl9pbnB1dCBjb24gPSBRdWV1 ZS5jYW5fcHVzaCBjb24ucGt0X291dCBDb21tYW5kUmVwbHkKKwogKCogTkI6 IGNhbiB0aHJvdyBSZWNvbm5lY3QgKikKIGxldCBpbnB1dCBjb24gPQotCWxl dCB0b19yZWFkID0KLQkJbWF0Y2ggY29uLnBhcnRpYWxfaW4gd2l0aAotCQl8 IEhhdmVIZHIgcGFydGlhbF9wa3QgLT4gUGFydGlhbC50b19jb21wbGV0ZSBw YXJ0aWFsX3BrdAotCQl8IE5vSGRyICAgKGksIF8pICAgIC0+IGkgaW4KKwlp ZiBub3QgKGNhbl9pbnB1dCBjb24pIHRoZW4gTm9uZQorCWVsc2UKKwlsZXQg dG9fcmVhZCA9IHRvX3JlYWQgY29uIGluCiAKIAkoKiB0cnkgdG8gZ2V0IG1v cmUgZGF0YSBmcm9tIGlucHV0IHN0cmVhbSAqKQogCWxldCBiID0gQnl0ZXMu bWFrZSB0b19yZWFkICdcMDAwJyBpbgpAQCAtMjQzLDExICsyNzcsMjIgQEAg bGV0IGlucHV0IGNvbiA9CiAJCU5vbmUKIAkpCiAKLWxldCBuZXdjb24gYmFj a2VuZCA9IHsKK2xldCBjbGFzc2lmeSB0ID0KKwltYXRjaCB0LlBhY2tldC50 eSB3aXRoCisJfCBPcC5XYXRjaGV2ZW50IC0+IFdhdGNoZXZlbnQKKwl8IF8g LT4gQ29tbWFuZFJlcGx5CisKK2xldCBuZXdjb24gfmNhcGFjaXR5IGJhY2tl bmQgPQorCWxldCBsaW1pdCA9IGZ1bmN0aW9uCisJCXwgQ29tbWFuZFJlcGx5 IC0+IGNhcGFjaXR5Lm1heG91dHN0YW5kaW5nCisJCXwgV2F0Y2hldmVudCAt PiBjYXBhY2l0eS5tYXh3YXRjaGV2ZW50cworCWluCisJewogCWJhY2tlbmQg PSBiYWNrZW5kOwotCXBrdF9vdXQgPSBRdWV1ZS5jcmVhdGUgKCk7CisJcGt0 X291dCA9IFF1ZXVlLmNyZWF0ZSB+Y2FwYWNpdHk6KGNhcGFjaXR5Lm1heG91 dHN0YW5kaW5nICsgY2FwYWNpdHkubWF4d2F0Y2hldmVudHMpIH5jbGFzc2lm eSB+bGltaXQ7CiAJcGFydGlhbF9pbiA9IGluaXRfcGFydGlhbF9pbiAoKTsK IAlwYXJ0aWFsX291dCA9ICIiOworCWNhcGFjaXR5ID0gY2FwYWNpdHk7CiAJ fQogCiBsZXQgb3Blbl9mZCBmZCA9IG5ld2NvbiAoRmQgeyBmZCA9IGZkOyB9 KQpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbGkgYi90 b29scy9vY2FtbC9saWJzL3hiL3hiLm1saQppbmRleCA5MWM2ODIxNjJjZWEu LjcxYjI3NTRjYTc4OCAxMDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94 Yi94Yi5tbGkKKysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yi94Yi5tbGkKQEAg LTY2LDEwICs2NiwxMSBAQCB0eXBlIGJhY2tlbmRfbW1hcCA9IHsKIHR5cGUg YmFja2VuZF9mZCA9IHsgZmQgOiBVbml4LmZpbGVfZGVzY3I7IH0KIHR5cGUg YmFja2VuZCA9IEZkIG9mIGJhY2tlbmRfZmQgfCBYZW5tbWFwIG9mIGJhY2tl bmRfbW1hcAogdHlwZSBwYXJ0aWFsX2J1ZiA9IEhhdmVIZHIgb2YgUGFydGlh bC5wa3QgfCBOb0hkciBvZiBpbnQgKiBieXRlcwordHlwZSBjYXBhY2l0eSA9 IHsgbWF4b3V0c3RhbmRpbmc6IGludDsgbWF4d2F0Y2hldmVudHM6IGludCB9 CiB0eXBlIHQKIHZhbCBpbml0X3BhcnRpYWxfaW4gOiB1bml0IC0+IHBhcnRp YWxfYnVmCiB2YWwgcmVjb25uZWN0IDogdCAtPiB1bml0Ci12YWwgcXVldWUg OiB0IC0+IFBhY2tldC50IC0+IHVuaXQKK3ZhbCBxdWV1ZSA6IHQgLT4gUGFj a2V0LnQgLT4gdW5pdCBvcHRpb24KIHZhbCByZWFkX2ZkIDogYmFja2VuZF9m ZCAtPiAnYSAtPiBieXRlcyAtPiBpbnQgLT4gaW50CiB2YWwgcmVhZF9tbWFw IDogYmFja2VuZF9tbWFwIC0+ICdhIC0+IGJ5dGVzIC0+IGludCAtPiBpbnQK IHZhbCByZWFkIDogdCAtPiBieXRlcyAtPiBpbnQgLT4gaW50CkBAIC03OCwx MyArNzksMTQgQEAgdmFsIHdyaXRlX21tYXAgOiBiYWNrZW5kX21tYXAgLT4g J2EgLT4gc3RyaW5nIC0+IGludCAtPiBpbnQKIHZhbCB3cml0ZSA6IHQgLT4g c3RyaW5nIC0+IGludCAtPiBpbnQKIHZhbCBvdXRwdXQgOiB0IC0+IGJvb2wK IHZhbCBpbnB1dCA6IHQgLT4gUGFja2V0LnQgb3B0aW9uCi12YWwgbmV3Y29u IDogYmFja2VuZCAtPiB0Ci12YWwgb3Blbl9mZCA6IFVuaXguZmlsZV9kZXNj ciAtPiB0Ci12YWwgb3Blbl9tbWFwIDogWGVubW1hcC5tbWFwX2ludGVyZmFj ZSAtPiAodW5pdCAtPiB1bml0KSAtPiB0Cit2YWwgbmV3Y29uIDogY2FwYWNp dHk6Y2FwYWNpdHkgLT4gYmFja2VuZCAtPiB0Cit2YWwgb3Blbl9mZCA6IFVu aXguZmlsZV9kZXNjciAtPiBjYXBhY2l0eTpjYXBhY2l0eSAtPiB0Cit2YWwg b3Blbl9tbWFwIDogWGVubW1hcC5tbWFwX2ludGVyZmFjZSAtPiAodW5pdCAt PiB1bml0KSAtPiBjYXBhY2l0eTpjYXBhY2l0eSAtPiB0CiB2YWwgY2xvc2Ug OiB0IC0+IHVuaXQKIHZhbCBpc19mZCA6IHQgLT4gYm9vbAogdmFsIGlzX21t YXAgOiB0IC0+IGJvb2wKIHZhbCBvdXRwdXRfbGVuIDogdCAtPiBpbnQKK3Zh bCBjYW5faW5wdXQ6IHQgLT4gYm9vbAogdmFsIGhhc19uZXdfb3V0cHV0IDog dCAtPiBib29sCiB2YWwgaGFzX29sZF9vdXRwdXQgOiB0IC0+IGJvb2wKIHZh bCBoYXNfb3V0cHV0IDogdCAtPiBib29sCkBAIC05MywzICs5NSw0IEBAIHZh bCBoYXNfcGFydGlhbF9pbnB1dCA6IHQgLT4gYm9vbAogdmFsIGhhc19tb3Jl X2lucHV0IDogdCAtPiBib29sCiB2YWwgaXNfc2VsZWN0YWJsZSA6IHQgLT4g Ym9vbAogdmFsIGdldF9mZCA6IHQgLT4gVW5peC5maWxlX2Rlc2NyCit2YWwg ZGVidWc6IHQgLT4gc3RyaW5nCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9s aWJzL3hzL3F1ZXVlb3AubWwgYi90b29scy9vY2FtbC9saWJzL3hzL3F1ZXVl b3AubWwKaW5kZXggOWZmNWJiZDUyOWNlLi40ZTUzMmNkYWVhY2IgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveHMvcXVldWVvcC5tbAorKysgYi90 b29scy9vY2FtbC9saWJzL3hzL3F1ZXVlb3AubWwKQEAgLTE2LDkgKzE2LDEw IEBACiBvcGVuIFhlbmJ1cwogCiBsZXQgZGF0YV9jb25jYXQgbHMgPSAoU3Ry aW5nLmNvbmNhdCAiXDAwMCIgbHMpIF4gIlwwMDAiCitsZXQgcXVldWUgY29u IHBrdCA9IGxldCByID0gWGIucXVldWUgY29uIHBrdCBpbiBhc3NlcnQgKHIg PD4gTm9uZSkKIGxldCBxdWV1ZV9wYXRoIHR5ICh0aWQ6IGludCkgKHBhdGg6 IHN0cmluZykgY29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgcGF0 aDsgXSBpbgotCVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSB0aWQg MCB0eSBkYXRhKQorCXF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSB0aWQg MCB0eSBkYXRhKQogCiAoKiBvcGVyYXRpb25zICopCiBsZXQgZGlyZWN0b3J5 IHRpZCBwYXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuRGlyZWN0b3J5IHRp ZCBwYXRoIGNvbgpAQCAtMjcsNDggKzI4LDQ4IEBAIGxldCByZWFkIHRpZCBw YXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuUmVhZCB0aWQgcGF0aCBjb24K IGxldCBnZXRwZXJtcyB0aWQgcGF0aCBjb24gPSBxdWV1ZV9wYXRoIFhiLk9w LkdldHBlcm1zIHRpZCBwYXRoIGNvbgogCiBsZXQgZGVidWcgY29tbWFuZHMg Y29uID0KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhi Lk9wLkRlYnVnIChkYXRhX2NvbmNhdCBjb21tYW5kcykpCisJcXVldWUgY29u IChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5EZWJ1ZyAoZGF0YV9jb25j YXQgY29tbWFuZHMpKQogCiBsZXQgd2F0Y2ggcGF0aCBkYXRhIGNvbiA9CiAJ bGV0IGRhdGEgPSBkYXRhX2NvbmNhdCBbIHBhdGg7IGRhdGE7IF0gaW4KLQlY Yi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhiLk9wLldhdGNo IGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5P cC5XYXRjaCBkYXRhKQogCiBsZXQgdW53YXRjaCBwYXRoIGRhdGEgY29uID0K IAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgcGF0aDsgZGF0YTsgXSBpbgot CVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuVW53 YXRjaCBkYXRhKQorCXF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAg WGIuT3AuVW53YXRjaCBkYXRhKQogCiBsZXQgdHJhbnNhY3Rpb25fc3RhcnQg Y29uID0KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgMCAwIFhi Lk9wLlRyYW5zYWN0aW9uX3N0YXJ0IChkYXRhX2NvbmNhdCBbXSkpCisJcXVl dWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5UcmFuc2FjdGlv bl9zdGFydCAoZGF0YV9jb25jYXQgW10pKQogCiBsZXQgdHJhbnNhY3Rpb25f ZW5kIHRpZCBjb21taXQgY29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0 IFsgKGlmIGNvbW1pdCB0aGVuICJUIiBlbHNlICJGIik7IF0gaW4KLQlYYi5x dWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuVHJhbnNh Y3Rpb25fZW5kIGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRl IHRpZCAwIFhiLk9wLlRyYW5zYWN0aW9uX2VuZCBkYXRhKQogCiBsZXQgaW50 cm9kdWNlIGRvbWlkIG1mbiBwb3J0IGNvbiA9CiAJbGV0IGRhdGEgPSBkYXRh X2NvbmNhdCBbIFByaW50Zi5zcHJpbnRmICIldSIgZG9taWQ7CiAJICAgICAg ICAgICAgICAgICAgICAgICAgIFByaW50Zi5zcHJpbnRmICIlbnUiIG1mbjsK IAkgICAgICAgICAgICAgICAgICAgICAgICAgc3RyaW5nX29mX2ludCBwb3J0 OyBdIGluCi0JWGIucXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBY Yi5PcC5JbnRyb2R1Y2UgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBhY2tldC5j cmVhdGUgMCAwIFhiLk9wLkludHJvZHVjZSBkYXRhKQogCiBsZXQgcmVsZWFz ZSBkb21pZCBjb24gPQogCWxldCBkYXRhID0gZGF0YV9jb25jYXQgWyBQcmlu dGYuc3ByaW50ZiAiJXUiIGRvbWlkOyBdIGluCi0JWGIucXVldWUgY29uIChY Yi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5SZWxlYXNlIGRhdGEpCisJcXVl dWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBYYi5PcC5SZWxlYXNlIGRh dGEpCiAKIGxldCByZXN1bWUgZG9taWQgY29uID0KIAlsZXQgZGF0YSA9IGRh dGFfY29uY2F0IFsgUHJpbnRmLnNwcmludGYgIiV1IiBkb21pZDsgXSBpbgot CVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuUmVz dW1lIGRhdGEpCisJcXVldWUgY29uIChYYi5QYWNrZXQuY3JlYXRlIDAgMCBY Yi5PcC5SZXN1bWUgZGF0YSkKIAogbGV0IGdldGRvbWFpbnBhdGggZG9taWQg Y29uID0KIAlsZXQgZGF0YSA9IGRhdGFfY29uY2F0IFsgUHJpbnRmLnNwcmlu dGYgIiV1IiBkb21pZDsgXSBpbgotCVhiLnF1ZXVlIGNvbiAoWGIuUGFja2V0 LmNyZWF0ZSAwIDAgWGIuT3AuR2V0ZG9tYWlucGF0aCBkYXRhKQorCXF1ZXVl IGNvbiAoWGIuUGFja2V0LmNyZWF0ZSAwIDAgWGIuT3AuR2V0ZG9tYWlucGF0 aCBkYXRhKQogCiBsZXQgd3JpdGUgdGlkIHBhdGggdmFsdWUgY29uID0KIAls ZXQgZGF0YSA9IHBhdGggXiAiXDAwMCIgXiB2YWx1ZSAoKiBubyBOVUxMIGF0 IHRoZSBlbmQgKikgaW4KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVh dGUgdGlkIDAgWGIuT3AuV3JpdGUgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBh Y2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuV3JpdGUgZGF0YSkKIAogbGV0IG1r ZGlyIHRpZCBwYXRoIGNvbiA9IHF1ZXVlX3BhdGggWGIuT3AuTWtkaXIgdGlk IHBhdGggY29uCiBsZXQgcm0gdGlkIHBhdGggY29uID0gcXVldWVfcGF0aCBY Yi5PcC5SbSB0aWQgcGF0aCBjb24KIAogbGV0IHNldHBlcm1zIHRpZCBwYXRo IHBlcm1zIGNvbiA9CiAJbGV0IGRhdGEgPSBkYXRhX2NvbmNhdCBbIHBhdGg7 IHBlcm1zIF0gaW4KLQlYYi5xdWV1ZSBjb24gKFhiLlBhY2tldC5jcmVhdGUg dGlkIDAgWGIuT3AuU2V0cGVybXMgZGF0YSkKKwlxdWV1ZSBjb24gKFhiLlBh Y2tldC5jcmVhdGUgdGlkIDAgWGIuT3AuU2V0cGVybXMgZGF0YSkKZGlmZiAt LWdpdCBhL3Rvb2xzL29jYW1sL2xpYnMveHMveHNyYXcubWwgYi90b29scy9v Y2FtbC9saWJzL3hzL3hzcmF3Lm1sCmluZGV4IDQ1MWY4YjM4ZGJjYy4uY2Jk MTcyODA2MDBjIDEwMDY0NAotLS0gYS90b29scy9vY2FtbC9saWJzL3hzL3hz cmF3Lm1sCisrKyBiL3Rvb2xzL29jYW1sL2xpYnMveHMveHNyYXcubWwKQEAg LTM2LDggKzM2LDEwIEBAIHR5cGUgY29uID0gewogbGV0IGNsb3NlIGNvbiA9 CiAJWGIuY2xvc2UgY29uLnhiCiAKK2xldCBjYXBhY2l0eSA9IHsgWGIubWF4 b3V0c3RhbmRpbmcgPSAxOyBtYXh3YXRjaGV2ZW50cyA9IDA7IH0KKwogbGV0 IG9wZW5fZmQgZmQgPSB7Ci0JeGIgPSBYYi5vcGVuX2ZkIGZkOworCXhiID0g WGIub3Blbl9mZCB+Y2FwYWNpdHkgZmQ7CiAJd2F0Y2hldmVudHMgPSBRdWV1 ZS5jcmVhdGUgKCk7CiB9CiAKZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hl bnN0b3JlZC9jb25uZWN0aW9uLm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVk L2Nvbm5lY3Rpb24ubWwKaW5kZXggM2Y2YThmMWFkMGY3Li41NGY3Zjc2NTE2 N2IgMTAwNjQ0Ci0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0 aW9uLm1sCisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9u Lm1sCkBAIC0yMCwxMiArMjAsODQgQEAgb3BlbiBTdGRleHQKIAogbGV0IHhl bnN0b3JlX3BheWxvYWRfbWF4ID0gNDA5NiAoKiB4ZW4vaW5jbHVkZS9wdWJs aWMvaW8veHNfd2lyZS5oICopCiAKK3R5cGUgJ2EgYm91bmRlZF9zZW5kZXIg PSAnYSAtPiB1bml0IG9wdGlvbgorKCoqIGEgYm91bmRlZCBzZW5kZXIgYWNj ZXB0cyBhbiBbJ2FdIGl0ZW0gYW5kIHJldHVybnM6CisgICAgTm9uZSAtIGlm IHRoZXJlIGlzIG5vIHJvb20gdG8gYWNjZXB0IHRoZSBpdGVtCisgICAgU29t ZSAoKSAtICBpZiBpdCBoYXMgc3VjY2Vzc2Z1bGx5IGFjY2VwdGVkL3NlbnQg dGhlIGl0ZW0KKyAqKQorCittb2R1bGUgQm91bmRlZFBpcGUgOiBzaWcKKwl0 eXBlICdhIHQKKworCSgqKiBbY3JlYXRlIH5jYXBhY2l0eSB+ZGVzdGluYXRp b25dIGNyZWF0ZXMgYSBib3VuZGVkIHBpcGUgd2l0aCBhCisJICAgIGxvY2Fs IGJ1ZmZlciBob2xkaW5nIGF0IG1vc3QgW2NhcGFjaXR5XSBpdGVtcy4gIE9u Y2UgdGhlIGJ1ZmZlciBpcworCSAgICBmdWxsIGl0IHdpbGwgbm90IGFjY2Vw dCBmdXJ0aGVyIGl0ZW1zLiAgaXRlbXMgZnJvbSB0aGUgcGlwZSBhcmUKKwkg ICAgZmx1c2hlZCBpbnRvIFtkZXN0aW5hdGlvbl0gYXMgbG9uZyBhcyBpdCBh Y2NlcHRzIGl0ZW1zLiAgVGhlCisJICAgIGRlc3RpbmF0aW9uIGNvdWxkIGJl IGFub3RoZXIgcGlwZS4KKwkgKikKKwl2YWwgY3JlYXRlOiBjYXBhY2l0eTpp bnQgLT4gZGVzdGluYXRpb246J2EgYm91bmRlZF9zZW5kZXIgLT4gJ2EgdAor CisJKCoqIFtpc19lbXB0eSB0XSByZXR1cm5zIHdoZXRoZXIgdGhlIGxvY2Fs IGJ1ZmZlciBvZiBbdF0gaXMgZW1wdHkuICopCisJdmFsIGlzX2VtcHR5IDog XyB0IC0+IGJvb2wKKworCSgqKiBbbGVuZ3RoIHRdIHRoZSBudW1iZXIgb2Yg aXRlbXMgaW4gdGhlIGludGVybmFsIGJ1ZmZlciAqKQorCXZhbCBsZW5ndGg6 IF8gdCAtPiBpbnQKKworCSgqKiBbZmx1c2hfcGlwZSB0XSBzZW5kcyBhcyBt YW55IGl0ZW1zIGZyb20gdGhlIGxvY2FsIGJ1ZmZlciBhcyBwb3NzaWJsZSwK KwkJCXdoaWNoIGNvdWxkIGJlIG5vbmUuICopCisJdmFsIGZsdXNoX3BpcGU6 IF8gdCAtPiB1bml0CisKKwkoKiogW3B1c2ggdCBpdGVtXSB0cmllcyB0byBb Zmx1c2hfcGlwZV0gYW5kIHRoZW4gcHVzaCBbaXRlbV0KKwkgICAgaW50byB0 aGUgcGlwZSBpZiBpdHMgW2NhcGFjaXR5XSBhbGxvd3MuCisJICAgIFJldHVy bnMgW05vbmVdIGlmIHRoZXJlIGlzIG5vIG1vcmUgcm9vbQorCSAqKQorCXZh bCBwdXNoIDogJ2EgdCAtPiAnYSBib3VuZGVkX3NlbmRlcgorZW5kID0gc3Ry dWN0CisJKCogaXRlbXMgYXJlIGVucXVldWVkIGluIFtxXSwgYW5kIHRoZW4g Zmx1c2hlZCB0byBbY29ubmVjdF90b10gKikKKwl0eXBlICdhIHQgPQorCQl7 IHE6ICdhIFF1ZXVlLnQKKwkJOyBkZXN0aW5hdGlvbjogJ2EgYm91bmRlZF9z ZW5kZXIKKwkJOyBjYXBhY2l0eTogaW50CisJCX0KKworCWxldCBjcmVhdGUg fmNhcGFjaXR5IH5kZXN0aW5hdGlvbiA9CisJCXsgcSA9IFF1ZXVlLmNyZWF0 ZSAoKTsgY2FwYWNpdHk7IGRlc3RpbmF0aW9uIH0KKworCWxldCByZWMgZmx1 c2hfcGlwZSB0ID0KKwkJaWYgbm90IFF1ZXVlLihpc19lbXB0eSB0LnEpIHRo ZW4KKwkJCWxldCBpdGVtID0gUXVldWUucGVlayB0LnEgaW4KKwkJCW1hdGNo IHQuZGVzdGluYXRpb24gaXRlbSB3aXRoCisJCQl8IE5vbmUgLT4gKCkgKCog bm8gcm9vbSAqKQorCQkJfCBTb21lICgpIC0+CisJCQkJKCogc3VjY2Vzc2Z1 bGx5IHNlbnQgaXRlbSB0byBuZXh0IHN0YWdlICopCisJCQkJbGV0IF8gPSBR dWV1ZS5wb3AgdC5xIGluCisJCQkJKCogY29udGludWUgdHJ5aW5nIHRvIHNl bmQgbW9yZSBpdGVtcyAqKQorCQkJCWZsdXNoX3BpcGUgdAorCisJbGV0IHB1 c2ggdCBpdGVtID0KKwkJKCogZmlyc3QgdHJ5IHRvIGZsdXNoIGFzIG1hbnkg aXRlbXMgZnJvbSB0aGlzIHBpcGUgYXMgcG9zc2libGUgdG8gbWFrZSByb29t LAorCQkgICBpdCBpcyBpbXBvcnRhbnQgdG8gZG8gdGhpcyBmaXJzdCB0byBw cmVzZXJ2ZSB0aGUgb3JkZXIgb2YgdGhlIGl0ZW1zCisJCSAqKQorCQlmbHVz aF9waXBlIHQ7CisJCWlmIFF1ZXVlLmxlbmd0aCB0LnEgPCB0LmNhcGFjaXR5 IHRoZW4gYmVnaW4KKwkJCSgqIGVucXVldWUsIGluc3RlYWQgb2Ygc2VuZGlu ZyBkaXJlY3RseS4KKwkJCSAgIHRoaXMgZW5zdXJlcyB0aGF0IFtvdXRdIHNl ZXMgdGhlIGl0ZW1zIGluIHRoZSBzYW1lIG9yZGVyIGFzIHdlIHJlY2VpdmUg dGhlbQorCQkJICopCisJCQlRdWV1ZS5wdXNoIGl0ZW0gdC5xOworCQkJU29t ZSAoZmx1c2hfcGlwZSB0KQorCQllbmQgZWxzZSBOb25lCisKKwlsZXQgaXNf ZW1wdHkgdCA9IFF1ZXVlLmlzX2VtcHR5IHQucQorCWxldCBsZW5ndGggdCA9 IFF1ZXVlLmxlbmd0aCB0LnEKK2VuZAorCiB0eXBlIHdhdGNoID0gewogCWNv bjogdDsKIAl0b2tlbjogc3RyaW5nOwogCXBhdGg6IHN0cmluZzsKIAliYXNl OiBzdHJpbmc7CiAJaXNfcmVsYXRpdmU6IGJvb2w7CisJcGVuZGluZ193YXRj aGV2ZW50czogWGVuYnVzLlhiLlBhY2tldC50IEJvdW5kZWRQaXBlLnQ7CiB9 CiAKIGFuZCB0ID0gewpAQCAtMzgsOCArMTEwLDM2IEBAIGFuZCB0ID0gewog CWFub25pZDogaW50OwogCW11dGFibGUgc3RhdF9uYl9vcHM6IGludDsKIAlt dXRhYmxlIHBlcm06IFBlcm1zLkNvbm5lY3Rpb24udDsKKwlwZW5kaW5nX3Nv dXJjZV93YXRjaGV2ZW50czogKHdhdGNoICogWGVuYnVzLlhiLlBhY2tldC50 KSBCb3VuZGVkUGlwZS50CiB9CiAKK21vZHVsZSBXYXRjaCA9IHN0cnVjdAor CW1vZHVsZSBUID0gc3RydWN0CisJCXR5cGUgdCA9IHdhdGNoCisKKwkJbGV0 IGNvbXBhcmUgdzEgdzIgPQorCQkJKCogY2Fubm90IGNvbXBhcmUgd2F0Y2hl cyBmcm9tIGRpZmZlcmVudCBjb25uZWN0aW9ucyAqKQorCQkJYXNzZXJ0ICh3 MS5jb24gPT0gdzIuY29uKTsKKwkJCW1hdGNoIFN0cmluZy5jb21wYXJlIHcx LnRva2VuIHcyLnRva2VuIHdpdGgKKwkJCXwgMCAtPiBTdHJpbmcuY29tcGFy ZSB3MS5wYXRoIHcyLnBhdGgKKwkJCXwgbiAtPiBuCisJZW5kCisJbW9kdWxl IFNldCA9IFNldC5NYWtlKFQpCisKKwlsZXQgZmx1c2hfZXZlbnRzIHQgPQor CQlCb3VuZGVkUGlwZS5mbHVzaF9waXBlIHQucGVuZGluZ193YXRjaGV2ZW50 czsKKwkJbm90IChCb3VuZGVkUGlwZS5pc19lbXB0eSB0LnBlbmRpbmdfd2F0 Y2hldmVudHMpCisKKwlsZXQgcGVuZGluZ193YXRjaGV2ZW50cyB0ID0KKwkJ Qm91bmRlZFBpcGUubGVuZ3RoIHQucGVuZGluZ193YXRjaGV2ZW50cworZW5k CisKK2xldCBzb3VyY2VfZmx1c2hfd2F0Y2hldmVudHMgdCA9CisJQm91bmRl ZFBpcGUuZmx1c2hfcGlwZSB0LnBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRz CisKK2xldCBzb3VyY2VfcGVuZGluZ193YXRjaGV2ZW50cyB0ID0KKwlCb3Vu ZGVkUGlwZS5sZW5ndGggdC5wZW5kaW5nX3NvdXJjZV93YXRjaGV2ZW50cwor CiBsZXQgbWFya19hc19iYWQgY29uID0KIAltYXRjaCBjb24uZG9tIHdpdGgK IAl8Tm9uZSAtPiAoKQpAQCAtNjcsNyArMTY3LDggQEAgbGV0IHdhdGNoX2Ny ZWF0ZSB+Y29uIH5wYXRoIH50b2tlbiA9IHsKIAl0b2tlbiA9IHRva2VuOwog CXBhdGggPSBwYXRoOwogCWJhc2UgPSBnZXRfcGF0aCBjb247Ci0JaXNfcmVs YXRpdmUgPSBwYXRoLlswXSA8PiAnLycgJiYgcGF0aC5bMF0gPD4gJ0AnCisJ aXNfcmVsYXRpdmUgPSBwYXRoLlswXSA8PiAnLycgJiYgcGF0aC5bMF0gPD4g J0AnOworCXBlbmRpbmdfd2F0Y2hldmVudHMgPSBCb3VuZGVkUGlwZS5jcmVh dGUgfmNhcGFjaXR5OiFEZWZpbmUubWF4d2F0Y2hldmVudHMgfmRlc3RpbmF0 aW9uOihYZW5idXMuWGIucXVldWUgY29uLnhiKQogfQogCiBsZXQgZ2V0X2Nv biB3ID0gdy5jb24KQEAgLTkzLDYgKzE5NCw5IEBAIGxldCBtYWtlX3Blcm0g ZG9tID0KIAlQZXJtcy5Db25uZWN0aW9uLmNyZWF0ZSB+cGVybXM6W1Blcm1z LlJFQUQ7IFBlcm1zLldSSVRFXSBkb21pZAogCiBsZXQgY3JlYXRlIHhiY29u IGRvbSA9CisJbGV0IGRlc3RpbmF0aW9uICh3YXRjaCwgcGt0KSA9CisJCUJv dW5kZWRQaXBlLnB1c2ggd2F0Y2gucGVuZGluZ193YXRjaGV2ZW50cyBwa3QK KwlpbgogCWxldCBpZCA9CiAJCW1hdGNoIGRvbSB3aXRoCiAJCXwgTm9uZSAt PiBsZXQgb2xkID0gIWFub25faWRfbmV4dCBpbiBpbmNyIGFub25faWRfbmV4 dDsgb2xkCkBAIC0xMDksNiArMjEzLDE2IEBAIGxldCBjcmVhdGUgeGJjb24g ZG9tID0KIAlhbm9uaWQgPSBpZDsKIAlzdGF0X25iX29wcyA9IDA7CiAJcGVy bSA9IG1ha2VfcGVybSBkb207CisKKwkoKiB0aGUgYWN0dWFsIGNhcGFjaXR5 IHdpbGwgYmUgbG93ZXIsIHRoaXMgaXMgdXNlZCBhcyBhbiBvdmVyZmxvdwor CSAgIGJ1ZmZlcjogYW55dGhpbmcgdGhhdCBkb2Vzbid0IGZpdCBlbHNld2hl cmUgZ2V0cyBwdXQgaGVyZSwgb25seQorCSAgIGxpbWl0ZWQgYnkgdGhlIGFt b3VudCBvZiB3YXRjaGVzIHRoYXQgeW91IGNhbiBnZW5lcmF0ZSB3aXRoIGEK KwkgICBzaW5nbGUgeGVuc3RvcmUgY29tbWFuZCAod2hpY2ggaXMgZmluaXRl LCBhbHRob3VnaCBwb3NzaWJseSB2ZXJ5CisJICAgbGFyZ2UgaW4gdGhlb3J5 IGZvciBEb20wKS4gIE9uY2UgdGhlIHBpcGUgaGVyZSBoYXMgYW55IGNvbnRl bnRzIHRoZQorCSAgIGRvbWFpbiBpcyBibG9ja2VkIGZyb20gc2VuZGluZyBt b3JlIGNvbW1hbmRzIHVudGlsIGl0IGlzIGVtcHR5CisJICAgYWdhaW4gdGhv dWdoLgorCSAqKQorCXBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRzID0gQm91 bmRlZFBpcGUuY3JlYXRlIH5jYXBhY2l0eTpTeXMubWF4X2FycmF5X2xlbmd0 aCB+ZGVzdGluYXRpb24KIAl9CiAJaW4KIAlMb2dnaW5nLm5ld19jb25uZWN0 aW9uIH50aWQ6VHJhbnNhY3Rpb24ubm9uZSB+Y29uOihnZXRfZG9tc3RyIGNv bik7CkBAIC0xMjcsMTEgKzI0MSwxNyBAQCBsZXQgc2V0X3RhcmdldCBjb24g dGFyZ2V0X2RvbWlkID0KIAogbGV0IGlzX2JhY2tlbmRfbW1hcCBjb24gPSBY ZW5idXMuWGIuaXNfbW1hcCBjb24ueGIKIAotbGV0IHNlbmRfcmVwbHkgY29u IHRpZCByaWQgdHkgZGF0YSA9CitsZXQgcGFja2V0X29mIGNvbiB0aWQgcmlk IHR5IGRhdGEgPQogCWlmIChTdHJpbmcubGVuZ3RoIGRhdGEpID4geGVuc3Rv cmVfcGF5bG9hZF9tYXggJiYgKGlzX2JhY2tlbmRfbW1hcCBjb24pIHRoZW4K LQkJWGVuYnVzLlhiLnF1ZXVlIGNvbi54YiAoWGVuYnVzLlhiLlBhY2tldC5j cmVhdGUgdGlkIHJpZCBYZW5idXMuWGIuT3AuRXJyb3IgIkUyQklHXDAwMCIp CisJCVhlbmJ1cy5YYi5QYWNrZXQuY3JlYXRlIHRpZCByaWQgWGVuYnVzLlhi Lk9wLkVycm9yICJFMkJJR1wwMDAiCiAJZWxzZQotCQlYZW5idXMuWGIucXVl dWUgY29uLnhiIChYZW5idXMuWGIuUGFja2V0LmNyZWF0ZSB0aWQgcmlkIHR5 IGRhdGEpCisJCVhlbmJ1cy5YYi5QYWNrZXQuY3JlYXRlIHRpZCByaWQgdHkg ZGF0YQorCitsZXQgc2VuZF9yZXBseSBjb24gdGlkIHJpZCB0eSBkYXRhID0K KwlsZXQgcmVzdWx0ID0gWGVuYnVzLlhiLnF1ZXVlIGNvbi54YiAocGFja2V0 X29mIGNvbiB0aWQgcmlkIHR5IGRhdGEpIGluCisJKCogc2hvdWxkIG5ldmVy IGhhcHBlbjogd2Ugb25seSBwcm9jZXNzIGFuIGlucHV0IHBhY2tldCB3aGVu IHRoZXJlIGlzIHJvb20gZm9yIGFuIG91dHB1dCBwYWNrZXQgKikKKwkoKiBh bmQgdGhlIGxpbWl0IGZvciByZXBsaWVzIGlzIGRpZmZlcmVudCBmcm9tIHRo ZSBsaW1pdCBmb3Igd2F0Y2ggZXZlbnRzICopCisJYXNzZXJ0IChyZXN1bHQg PD4gTm9uZSkKIAogbGV0IHNlbmRfZXJyb3IgY29uIHRpZCByaWQgZXJyID0g c2VuZF9yZXBseSBjb24gdGlkIHJpZCBYZW5idXMuWGIuT3AuRXJyb3IgKGVy ciBeICJcMDAwIikKIGxldCBzZW5kX2FjayBjb24gdGlkIHJpZCB0eSA9IHNl bmRfcmVwbHkgY29uIHRpZCByaWQgdHkgIk9LXDAwMCIKQEAgLTE4MSwxMSAr MzAxLDExIEBAIGxldCBkZWxfd2F0Y2ggY29uIHBhdGggdG9rZW4gPQogCWFw YXRoLCB3CiAKIGxldCBkZWxfd2F0Y2hlcyBjb24gPQotICBIYXNodGJsLmNs ZWFyIGNvbi53YXRjaGVzOworICBIYXNodGJsLnJlc2V0IGNvbi53YXRjaGVz OwogICBjb24ubmJfd2F0Y2hlcyA8LSAwCiAKIGxldCBkZWxfdHJhbnNhY3Rp b25zIGNvbiA9Ci0gIEhhc2h0YmwuY2xlYXIgY29uLnRyYW5zYWN0aW9ucwor ICBIYXNodGJsLnJlc2V0IGNvbi50cmFuc2FjdGlvbnMKIAogbGV0IGxpc3Rf d2F0Y2hlcyBjb24gPQogCWxldCBsbCA9IEhhc2h0YmwuZm9sZApAQCAtMjA4 LDIxICszMjgsMjkgQEAgbGV0IGxvb2t1cF93YXRjaF9wZXJtIHBhdGggPSBm dW5jdGlvbgogbGV0IGxvb2t1cF93YXRjaF9wZXJtcyBvbGRyb290IHJvb3Qg cGF0aCA9CiAJbG9va3VwX3dhdGNoX3Blcm0gcGF0aCBvbGRyb290IEAgbG9v a3VwX3dhdGNoX3Blcm0gcGF0aCAoU29tZSByb290KQogCi1sZXQgZmlyZV9z aW5nbGVfd2F0Y2hfdW5jaGVja2VkIHdhdGNoID0KK2xldCBmaXJlX3Npbmds ZV93YXRjaF91bmNoZWNrZWQgc291cmNlIHdhdGNoID0KIAlsZXQgZGF0YSA9 IFV0aWxzLmpvaW5fYnlfbnVsbCBbd2F0Y2gucGF0aDsgd2F0Y2gudG9rZW47 ICIiXSBpbgotCXNlbmRfcmVwbHkgd2F0Y2guY29uIFRyYW5zYWN0aW9uLm5v bmUgMCBYZW5idXMuWGIuT3AuV2F0Y2hldmVudCBkYXRhCisJbGV0IHBrdCA9 IHBhY2tldF9vZiB3YXRjaC5jb24gVHJhbnNhY3Rpb24ubm9uZSAwIFhlbmJ1 cy5YYi5PcC5XYXRjaGV2ZW50IGRhdGEgaW4KKworCW1hdGNoIEJvdW5kZWRQ aXBlLnB1c2ggc291cmNlLnBlbmRpbmdfc291cmNlX3dhdGNoZXZlbnRzICh3 YXRjaCwgcGt0KSB3aXRoCisJfCBTb21lICgpIC0+ICgpICgqIHBhY2tldCBx dWV1ZWQgKikKKwl8IE5vbmUgLT4KKwkJCSgqIGEgd2VsbCBiZWhhdmVkIERv bTAgc2hvdWxkbid0IGJlIGFibGUgdG8gdHJpZ2dlciB0aGlzLAorCQkJICAg aWYgaXQgaGFwcGVucyBpdCBpcyBsaWtlbHkgYSBEb20wIGJ1ZyBjYXVzaW5n IHJ1bmF3YXkgbWVtb3J5IHVzYWdlCisJCQkgKikKKwkJCWZhaWx3aXRoICJ3 YXRjaCBldmVudCBvdmVyZmxvdywgY2Fubm90IGhhcHBlbiIKIAotbGV0IGZp cmVfc2luZ2xlX3dhdGNoIChvbGRyb290LCByb290KSB3YXRjaCA9CitsZXQg ZmlyZV9zaW5nbGVfd2F0Y2ggc291cmNlIChvbGRyb290LCByb290KSB3YXRj aCA9CiAJbGV0IGFic3BhdGggPSBnZXRfd2F0Y2hfcGF0aCB3YXRjaC5jb24g d2F0Y2gucGF0aCB8PiBTdG9yZS5QYXRoLm9mX3N0cmluZyBpbgogCWxldCBw ZXJtcyA9IGxvb2t1cF93YXRjaF9wZXJtcyBvbGRyb290IHJvb3QgYWJzcGF0 aCBpbgogCWlmIFBlcm1zLmNhbl9maXJlX3dhdGNoIHdhdGNoLmNvbi5wZXJt IHBlcm1zIHRoZW4KLQkJZmlyZV9zaW5nbGVfd2F0Y2hfdW5jaGVja2VkIHdh dGNoCisJCWZpcmVfc2luZ2xlX3dhdGNoX3VuY2hlY2tlZCBzb3VyY2Ugd2F0 Y2gKIAllbHNlCiAJCWxldCBwZXJtcyA9IHBlcm1zIHw+IExpc3QubWFwIChQ ZXJtcy5Ob2RlLnRvX3N0cmluZyB+c2VwOiIgIikgfD4gU3RyaW5nLmNvbmNh dCAiLCAiIGluCiAJCWxldCBjb24gPSBnZXRfZG9tc3RyIHdhdGNoLmNvbiBp bgogCQlMb2dnaW5nLndhdGNoX25vdF9maXJlZCB+Y29uIHBlcm1zIChTdG9y ZS5QYXRoLnRvX3N0cmluZyBhYnNwYXRoKQogCi1sZXQgZmlyZV93YXRjaCBy b290cyB3YXRjaCBwYXRoID0KK2xldCBmaXJlX3dhdGNoIHNvdXJjZSByb290 cyB3YXRjaCBwYXRoID0KIAlsZXQgbmV3X3BhdGggPQogCQlpZiB3YXRjaC5p c19yZWxhdGl2ZSAmJiBwYXRoLlswXSA9ICcvJwogCQl0aGVuIGJlZ2luCkBA IC0yMzIsNyArMzYwLDcgQEAgbGV0IGZpcmVfd2F0Y2ggcm9vdHMgd2F0Y2gg cGF0aCA9CiAJCWVuZCBlbHNlCiAJCQlwYXRoCiAJaW4KLQlmaXJlX3Npbmds ZV93YXRjaCByb290cyB7IHdhdGNoIHdpdGggcGF0aCA9IG5ld19wYXRoIH0K KwlmaXJlX3NpbmdsZV93YXRjaCBzb3VyY2Ugcm9vdHMgeyB3YXRjaCB3aXRo IHBhdGggPSBuZXdfcGF0aCB9CiAKICgqIFNlYXJjaCBmb3IgYSB2YWxpZCB1 bnVzZWQgdHJhbnNhY3Rpb24gaWQuICopCiBsZXQgcmVjIHZhbGlkX3RyYW5z YWN0aW9uX2lkIGNvbiBwcm9wb3NlZF9pZCA9CkBAIC0yODAsNiArNDA4LDcg QEAgbGV0IGRvX2lucHV0IGNvbiA9IFhlbmJ1cy5YYi5pbnB1dCBjb24ueGIK IGxldCBoYXNfcGFydGlhbF9pbnB1dCBjb24gPSBYZW5idXMuWGIuaGFzX3Bh cnRpYWxfaW5wdXQgY29uLnhiCiBsZXQgaGFzX21vcmVfaW5wdXQgY29uID0g WGVuYnVzLlhiLmhhc19tb3JlX2lucHV0IGNvbi54YgogCitsZXQgY2FuX2lu cHV0IGNvbiA9IFhlbmJ1cy5YYi5jYW5faW5wdXQgY29uLnhiICYmIEJvdW5k ZWRQaXBlLmlzX2VtcHR5IGNvbi5wZW5kaW5nX3NvdXJjZV93YXRjaGV2ZW50 cwogbGV0IGhhc19vdXRwdXQgY29uID0gWGVuYnVzLlhiLmhhc19vdXRwdXQg Y29uLnhiCiBsZXQgaGFzX29sZF9vdXRwdXQgY29uID0gWGVuYnVzLlhiLmhh c19vbGRfb3V0cHV0IGNvbi54YgogbGV0IGhhc19uZXdfb3V0cHV0IGNvbiA9 IFhlbmJ1cy5YYi5oYXNfbmV3X291dHB1dCBjb24ueGIKQEAgLTMyMiw3ICs0 NTEsNyBAQCBsZXQgcHJldmVudHNfbGl2ZV91cGRhdGUgY29uID0gbm90IChp c19iYWQgY29uKQogCSYmIChoYXNfZXh0cmFfY29ubmVjdGlvbl9kYXRhIGNv biB8fCBoYXNfdHJhbnNhY3Rpb25fZGF0YSBjb24pCiAKIGxldCBoYXNfbW9y ZV93b3JrIGNvbiA9Ci0JaGFzX21vcmVfaW5wdXQgY29uIHx8IG5vdCAoaGFz X29sZF9vdXRwdXQgY29uKSAmJiBoYXNfbmV3X291dHB1dCBjb24KKwkoaGFz X21vcmVfaW5wdXQgY29uICYmIGNhbl9pbnB1dCBjb24pIHx8IG5vdCAoaGFz X29sZF9vdXRwdXQgY29uKSAmJiBoYXNfbmV3X291dHB1dCBjb24KIAogbGV0 IGluY3Jfb3BzIGNvbiA9IGNvbi5zdGF0X25iX29wcyA8LSBjb24uc3RhdF9u Yl9vcHMgKyAxCiAKZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3Jl ZC9jb25uZWN0aW9ucy5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25u ZWN0aW9ucy5tbAppbmRleCAzYzc0MjlmZTdmNjEuLjdkNjhjNTgzYjQzYSAx MDA2NDQKLS0tIGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Nvbm5lY3Rpb25z Lm1sCisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9ucy5t bApAQCAtMjIsMjIgKzIyLDMwIEBAIHR5cGUgdCA9IHsKIAlkb21haW5zOiAo aW50LCBDb25uZWN0aW9uLnQpIEhhc2h0YmwudDsKIAlwb3J0czogKFhlbmV2 ZW50Y2huLnQsIENvbm5lY3Rpb24udCkgSGFzaHRibC50OwogCW11dGFibGUg d2F0Y2hlczogQ29ubmVjdGlvbi53YXRjaCBsaXN0IFRyaWUudDsKKwltdXRh YmxlIGhhc19wZW5kaW5nX3dhdGNoZXZlbnRzOiBDb25uZWN0aW9uLldhdGNo LlNldC50CiB9CiAKIGxldCBjcmVhdGUgKCkgPSB7CiAJYW5vbnltb3VzID0g SGFzaHRibC5jcmVhdGUgMzc7CiAJZG9tYWlucyA9IEhhc2h0YmwuY3JlYXRl IDM3OwogCXBvcnRzID0gSGFzaHRibC5jcmVhdGUgMzc7Ci0Jd2F0Y2hlcyA9 IFRyaWUuY3JlYXRlICgpCisJd2F0Y2hlcyA9IFRyaWUuY3JlYXRlICgpOwor CWhhc19wZW5kaW5nX3dhdGNoZXZlbnRzID0gQ29ubmVjdGlvbi5XYXRjaC5T ZXQuZW1wdHk7CiB9CiAKK2xldCBnZXRfY2FwYWNpdHkgKCkgPQorCSgqIG5v dCBtdWx0aXBsaWVkIGJ5IG1heHdhdGNoIG9uIHB1cnBvc2U6IDJuZCBxdWV1 ZSBpbiB3YXRjaCBpdHNlbGYhICopCisJeyBYZW5idXMuWGIubWF4b3V0c3Rh bmRpbmcgPSAhRGVmaW5lLm1heG91dHN0YW5kaW5nOyBtYXh3YXRjaGV2ZW50 cyA9ICFEZWZpbmUubWF4d2F0Y2hldmVudHMgfQorCiBsZXQgYWRkX2Fub255 bW91cyBjb25zIGZkID0KLQlsZXQgeGJjb24gPSBYZW5idXMuWGIub3Blbl9m ZCBmZCBpbgorCWxldCBjYXBhY2l0eSA9IGdldF9jYXBhY2l0eSAoKSBpbgor CWxldCB4YmNvbiA9IFhlbmJ1cy5YYi5vcGVuX2ZkIGZkIH5jYXBhY2l0eSBp bgogCWxldCBjb24gPSBDb25uZWN0aW9uLmNyZWF0ZSB4YmNvbiBOb25lIGlu CiAJSGFzaHRibC5hZGQgY29ucy5hbm9ueW1vdXMgKFhlbmJ1cy5YYi5nZXRf ZmQgeGJjb24pIGNvbgogCiBsZXQgYWRkX2RvbWFpbiBjb25zIGRvbSA9Ci0J bGV0IHhiY29uID0gWGVuYnVzLlhiLm9wZW5fbW1hcCAoRG9tYWluLmdldF9p bnRlcmZhY2UgZG9tKSAoZnVuICgpIC0+IERvbWFpbi5ub3RpZnkgZG9tKSBp bgorCWxldCBjYXBhY2l0eSA9IGdldF9jYXBhY2l0eSAoKSBpbgorCWxldCB4 YmNvbiA9IFhlbmJ1cy5YYi5vcGVuX21tYXAgfmNhcGFjaXR5IChEb21haW4u Z2V0X2ludGVyZmFjZSBkb20pIChmdW4gKCkgLT4gRG9tYWluLm5vdGlmeSBk b20pIGluCiAJbGV0IGNvbiA9IENvbm5lY3Rpb24uY3JlYXRlIHhiY29uIChT b21lIGRvbSkgaW4KIAlIYXNodGJsLmFkZCBjb25zLmRvbWFpbnMgKERvbWFp bi5nZXRfaWQgZG9tKSBjb247CiAJbWF0Y2ggRG9tYWluLmdldF9wb3J0IGRv bSB3aXRoCkBAIC00OCw3ICs1Niw5IEBAIGxldCBzZWxlY3QgPyhvbmx5X2lm ID0gKGZ1biBfIC0+IHRydWUpKSBjb25zID0KIAlIYXNodGJsLmZvbGQgKGZ1 biBfIGNvbiAoaW5zLCBvdXRzKSAtPgogCQlpZiAob25seV9pZiBjb24pIHRo ZW4gKAogCQkJbGV0IGZkID0gQ29ubmVjdGlvbi5nZXRfZmQgY29uIGluCi0J CQkoZmQgOjogaW5zLCAgaWYgQ29ubmVjdGlvbi5oYXNfb3V0cHV0IGNvbiB0 aGVuIGZkIDo6IG91dHMgZWxzZSBvdXRzKQorCQkJbGV0IGluX2ZkcyA9IGlm IENvbm5lY3Rpb24uY2FuX2lucHV0IGNvbiB0aGVuIGZkIDo6IGlucyBlbHNl IGlucyBpbgorCQkJbGV0IG91dF9mZHMgPSBpZiBDb25uZWN0aW9uLmhhc19v dXRwdXQgY29uIHRoZW4gZmQgOjogb3V0cyBlbHNlIG91dHMgaW4KKwkJCWlu X2Zkcywgb3V0X2ZkcwogCQkpIGVsc2UgKGlucywgb3V0cykKIAkpCiAJY29u cy5hbm9ueW1vdXMgKFtdLCBbXSkKQEAgLTY3LDEwICs3NywxNyBAQCBsZXQg ZGVsX3dhdGNoZXNfb2ZfY29uIGNvbiB3YXRjaGVzID0KIAl8IFtdIC0+IE5v bmUKIAl8IHdzIC0+IFNvbWUgd3MKIAorbGV0IGRlbF93YXRjaGVzIGNvbnMg Y29uID0KKwlDb25uZWN0aW9uLmRlbF93YXRjaGVzIGNvbjsKKwljb25zLndh dGNoZXMgPC0gVHJpZS5tYXAgKGRlbF93YXRjaGVzX29mX2NvbiBjb24pIGNv bnMud2F0Y2hlczsKKwljb25zLmhhc19wZW5kaW5nX3dhdGNoZXZlbnRzIDwt CisJCWNvbnMuaGFzX3BlbmRpbmdfd2F0Y2hldmVudHMgfD4gQ29ubmVjdGlv bi5XYXRjaC5TZXQuZmlsdGVyIEBAIGZ1biB3IC0+CisJCUNvbm5lY3Rpb24u Z2V0X2NvbiB3ICE9IGNvbgorCiBsZXQgZGVsX2Fub255bW91cyBjb25zIGNv biA9CiAJdHJ5CiAJCUhhc2h0YmwucmVtb3ZlIGNvbnMuYW5vbnltb3VzIChD b25uZWN0aW9uLmdldF9mZCBjb24pOwotCQljb25zLndhdGNoZXMgPC0gVHJp ZS5tYXAgKGRlbF93YXRjaGVzX29mX2NvbiBjb24pIGNvbnMud2F0Y2hlczsK KwkJZGVsX3dhdGNoZXMgY29ucyBjb247CiAJCUNvbm5lY3Rpb24uY2xvc2Ug Y29uCiAJd2l0aCBleG4gLT4KIAkJZGVidWcgImRlbCBhbm9ueW1vdXMgJXMi IChQcmludGV4Yy50b19zdHJpbmcgZXhuKQpAQCAtODUsNyArMTAyLDcgQEAg bGV0IGRlbF9kb21haW4gY29ucyBpZCA9CiAJCSAgICB8IFNvbWUgcCAtPiBI YXNodGJsLnJlbW92ZSBjb25zLnBvcnRzIHAKIAkJICAgIHwgTm9uZSAtPiAo KSkKIAkJIHwgTm9uZSAtPiAoKSk7Ci0JCWNvbnMud2F0Y2hlcyA8LSBUcmll Lm1hcCAoZGVsX3dhdGNoZXNfb2ZfY29uIGNvbikgY29ucy53YXRjaGVzOwor CQlkZWxfd2F0Y2hlcyBjb25zIGNvbjsKIAkJQ29ubmVjdGlvbi5jbG9zZSBj b24KIAl3aXRoIGV4biAtPgogCQlkZWJ1ZyAiZGVsIGRvbWFpbiAldTogJXMi IGlkIChQcmludGV4Yy50b19zdHJpbmcgZXhuKQpAQCAtMTM2LDMxICsxNTMs MzMgQEAgbGV0IGRlbF93YXRjaCBjb25zIGNvbiBwYXRoIHRva2VuID0KIAkJ Y29ucy53YXRjaGVzIDwtIFRyaWUuc2V0IGNvbnMud2F0Y2hlcyBrZXkgd2F0 Y2hlczsKICAJd2F0Y2gKIAotbGV0IGRlbF93YXRjaGVzIGNvbnMgY29uID0K LQlDb25uZWN0aW9uLmRlbF93YXRjaGVzIGNvbjsKLQljb25zLndhdGNoZXMg PC0gVHJpZS5tYXAgKGRlbF93YXRjaGVzX29mX2NvbiBjb24pIGNvbnMud2F0 Y2hlcwotCiAoKiBwYXRoIGlzIGFic29sdXRlICopCi1sZXQgZmlyZV93YXRj aGVzID9vbGRyb290IHJvb3QgY29ucyBwYXRoIHJlY3Vyc2UgPQorbGV0IGZp cmVfd2F0Y2hlcyA/b2xkcm9vdCBzb3VyY2Ugcm9vdCBjb25zIHBhdGggcmVj dXJzZSA9CiAJbGV0IGtleSA9IGtleV9vZl9wYXRoIHBhdGggaW4KIAlsZXQg cGF0aCA9IFN0b3JlLlBhdGgudG9fc3RyaW5nIHBhdGggaW4KIAlsZXQgcm9v dHMgPSBvbGRyb290LCByb290IGluCiAJbGV0IGZpcmVfd2F0Y2ggXyA9IGZ1 bmN0aW9uCiAJCXwgTm9uZSAgICAgICAgIC0+ICgpCi0JCXwgU29tZSB3YXRj aGVzIC0+IExpc3QuaXRlciAoZnVuIHcgLT4gQ29ubmVjdGlvbi5maXJlX3dh dGNoIHJvb3RzIHcgcGF0aCkgd2F0Y2hlcworCQl8IFNvbWUgd2F0Y2hlcyAt PiBMaXN0Lml0ZXIgKGZ1biB3IC0+IENvbm5lY3Rpb24uZmlyZV93YXRjaCBz b3VyY2Ugcm9vdHMgdyBwYXRoKSB3YXRjaGVzCiAJaW4KIAlsZXQgZmlyZV9y ZWMgX3ggPSBmdW5jdGlvbgogCQl8IE5vbmUgICAgICAgICAtPiAoKQogCQl8 IFNvbWUgd2F0Y2hlcyAtPgotCQkJTGlzdC5pdGVyIChDb25uZWN0aW9uLmZp cmVfc2luZ2xlX3dhdGNoIHJvb3RzKSB3YXRjaGVzCisJCQlMaXN0Lml0ZXIg KENvbm5lY3Rpb24uZmlyZV9zaW5nbGVfd2F0Y2ggc291cmNlIHJvb3RzKSB3 YXRjaGVzCiAJaW4KIAlUcmllLml0ZXJfcGF0aCBmaXJlX3dhdGNoIGNvbnMu d2F0Y2hlcyBrZXk7CiAJaWYgcmVjdXJzZSB0aGVuCiAJCVRyaWUuaXRlciBm aXJlX3JlYyAoVHJpZS5zdWIgY29ucy53YXRjaGVzIGtleSkKIAorbGV0IHNl bmRfd2F0Y2hldmVudHMgY29ucyBjb24gPQorCWNvbnMuaGFzX3BlbmRpbmdf d2F0Y2hldmVudHMgPC0KKwkJY29ucy5oYXNfcGVuZGluZ193YXRjaGV2ZW50 cyB8PiBDb25uZWN0aW9uLldhdGNoLlNldC5maWx0ZXIgQ29ubmVjdGlvbi5X YXRjaC5mbHVzaF9ldmVudHM7CisJQ29ubmVjdGlvbi5zb3VyY2VfZmx1c2hf d2F0Y2hldmVudHMgY29uCisKIGxldCBmaXJlX3NwZWNfd2F0Y2hlcyByb290 IGNvbnMgc3BlY3BhdGggPQorCWxldCBzb3VyY2UgPSBmaW5kX2RvbWFpbiBj b25zIDAgaW4KIAlpdGVyIGNvbnMgKGZ1biBjb24gLT4KLQkJTGlzdC5pdGVy IChDb25uZWN0aW9uLmZpcmVfc2luZ2xlX3dhdGNoIChOb25lLCByb290KSkg KENvbm5lY3Rpb24uZ2V0X3dhdGNoZXMgY29uIHNwZWNwYXRoKSkKKwkJTGlz dC5pdGVyIChDb25uZWN0aW9uLmZpcmVfc2luZ2xlX3dhdGNoIHNvdXJjZSAo Tm9uZSwgcm9vdCkpIChDb25uZWN0aW9uLmdldF93YXRjaGVzIGNvbiBzcGVj cGF0aCkpCiAKIGxldCBzZXRfdGFyZ2V0IGNvbnMgZG9tYWluIHRhcmdldF9k b21haW4gPQogCWxldCBjb24gPSBmaW5kX2RvbWFpbiBjb25zIGRvbWFpbiBp bgpAQCAtMTk3LDYgKzIxNiwxNiBAQCBsZXQgZGVidWcgY29ucyA9CiAJbGV0 IGRvbWFpbnMgPSBIYXNodGJsLmZvbGQgKGZ1biBfIGNvbiBhY2N1IC0+IENv bm5lY3Rpb24uZGVidWcgY29uIDo6IGFjY3UpIGNvbnMuZG9tYWlucyBbXSBp bgogCVN0cmluZy5jb25jYXQgIiIgKGRvbWFpbnMgQCBhbm9ueW1vdXMpCiAK K2xldCBkZWJ1Z193YXRjaGV2ZW50cyBjb25zIGNvbiA9CisJKCogPT0gKHBo eXNpY2FsIGVxdWFsaXR5KQorCSAgIGhhcyB0byBiZSB1c2VkIGhlcmUgYmVj YXVzZSB3LmNvbi54Yi5iYWNrZW5kIG1pZ2h0IGNvbnRhaW4gYSBbdW5pdC0+ dW5pdF0gdmFsdWUgY2F1c2luZyByZWd1bGFyCisJICAgY29tcGFyaXNvbiB0 byBmYWlsIGR1ZSB0byBoYXZpbmcgYSAnZnVuY3Rpb25hbCB2YWx1ZScgd2hp Y2ggY2Fubm90IGJlIGNvbXBhcmVkLgorCSAqKQorCWxldCBzID0gY29ucy5o YXNfcGVuZGluZ193YXRjaGV2ZW50cyB8PiBDb25uZWN0aW9uLldhdGNoLlNl dC5maWx0ZXIgKGZ1biB3IC0+IHcuY29uID09IGNvbikgaW4KKwlsZXQgcGVu ZGluZyA9IHMgfD4gQ29ubmVjdGlvbi5XYXRjaC5TZXQuZWxlbWVudHMKKwkJ fD4gTGlzdC5tYXAgKGZ1biB3IC0+IENvbm5lY3Rpb24uV2F0Y2gucGVuZGlu Z193YXRjaGV2ZW50cyB3KSB8PiBMaXN0LmZvbGRfbGVmdCAoKykgMCBpbgor CVByaW50Zi5zcHJpbnRmICJXYXRjaGVzIHdpdGggcGVuZGluZyBldmVudHM6 ICVkLCBwZW5kaW5nIGV2ZW50cyB0b3RhbDogJWQiIChDb25uZWN0aW9uLldh dGNoLlNldC5jYXJkaW5hbCBzKSBwZW5kaW5nCisKIGxldCBmaWx0ZXIgfmYg Y29ucyA9CiAJbGV0IGZvbGQgXyB2IGFjYyA9IGlmIGYgdiB0aGVuIHYgOjog YWNjIGVsc2UgYWNjIGluCiAJW10KZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9kZWZpbmUubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQv ZGVmaW5lLm1sCmluZGV4IGJhNjNhODE0N2UwOS4uMzI3YjZkNzk1ZWM3IDEw MDY0NAotLS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQvZGVmaW5lLm1sCisr KyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kZWZpbmUubWwKQEAgLTI0LDYg KzI0LDEzIEBAIGxldCBkZWZhdWx0X2NvbmZpZ19kaXIgPSBQYXRocy54ZW5f Y29uZmlnX2RpcgogbGV0IG1heHdhdGNoID0gcmVmICgxMDApCiBsZXQgbWF4 dHJhbnNhY3Rpb24gPSByZWYgKDEwKQogbGV0IG1heHJlcXVlc3RzID0gcmVm ICgxMDI0KSAgICgqIG1heGltdW0gcmVxdWVzdHMgcGVyIHRyYW5zYWN0aW9u ICopCitsZXQgbWF4b3V0c3RhbmRpbmcgPSByZWYgKDEwMjQpICgqIG1heGlt dW0gb3V0c3RhbmRpbmcgcmVxdWVzdHMsIGkuZS4gaW4tZmxpZ2h0IHJlcXVl c3RzIC8gZG9tYWluICopCitsZXQgbWF4d2F0Y2hldmVudHMgPSByZWYgKDEw MjQpCisoKgorCW1heGltdW0gb3V0c3RhbmRpbmcgd2F0Y2ggZXZlbnRzIHBl ciB3YXRjaCwKKwlyZWNvbW1lbmRlZCA+PSBtYXhvdXRzdGFuZGluZyB0byBh dm9pZCBibG9ja2luZyBiYWNrZW5kIHRyYW5zYWN0aW9ucyBkdWUgdG8KKwlt YWxpY2lvdXMgZnJvbnRlbmRzCisgKikKIAogbGV0IGdjX21heF9vdmVyaGVh ZCA9IHJlZiAxMjAgKCogMTIwJSBzZWUgY29tbWVudCBpbiB4ZW5zdG9yZWQu bWwgKikKIGxldCBjb25mbGljdF9idXJzdF9saW1pdCA9IHJlZiA1LjAKZGlm ZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9veGVuc3RvcmVkLmNv bmYuaW4gYi90b29scy9vY2FtbC94ZW5zdG9yZWQvb3hlbnN0b3JlZC5jb25m LmluCmluZGV4IDRhZTQ4ZTQyZDQ3ZC4uOWQwMzRlNzQ0YjRiIDEwMDY0NAot LS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQvb3hlbnN0b3JlZC5jb25mLmlu CisrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9veGVuc3RvcmVkLmNvbmYu aW4KQEAgLTYyLDYgKzYyLDggQEAgcXVvdGEtbWF4d2F0Y2ggPSAxMDAKIHF1 b3RhLXRyYW5zYWN0aW9uID0gMTAKIHF1b3RhLW1heHJlcXVlc3RzID0gMTAy NAogcXVvdGEtcGF0aC1tYXggPSAxMDI0CitxdW90YS1tYXhvdXRzdGFuZGlu ZyA9IDEwMjQKK3F1b3RhLW1heHdhdGNoZXZlbnRzID0gMTAyNAogCiAjIEFj dGl2YXRlIGZpbGVkIGJhc2UgYmFja2VuZAogcGVyc2lzdGVudCA9IGZhbHNl CmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5t bCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9wcm9jZXNzLm1sCmluZGV4IDY5 YTk2ZjJkYThlOS4uNWY0MzlmZTU5ZjQ3IDEwMDY0NAotLS0gYS90b29scy9v Y2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbAorKysgYi90b29scy9vY2FtbC94 ZW5zdG9yZWQvcHJvY2Vzcy5tbApAQCAtNTcsNyArNTcsNyBAQCBsZXQgc3Bs aXRfb25lX3BhdGggZGF0YSBjb24gPQogCXwgcGF0aCA6OiAiIiA6OiBbXSAt PiBTdG9yZS5QYXRoLmNyZWF0ZSBwYXRoIChDb25uZWN0aW9uLmdldF9wYXRo IGNvbikKIAl8IF8gICAgICAgICAgICAgICAgLT4gcmFpc2UgSW52YWxpZF9D bWRfQXJncwogCi1sZXQgcHJvY2Vzc193YXRjaCB0IGNvbnMgPQorbGV0IHBy b2Nlc3Nfd2F0Y2ggc291cmNlIHQgY29ucyA9CiAJbGV0IG9sZHJvb3QgPSB0 LlRyYW5zYWN0aW9uLm9sZHJvb3QgaW4KIAlsZXQgbmV3cm9vdCA9IFN0b3Jl LmdldF9yb290IHQuVHJhbnNhY3Rpb24uc3RvcmUgaW4KIAlsZXQgb3BzID0g VHJhbnNhY3Rpb24uZ2V0X3BhdGhzIHQgfD4gTGlzdC5yZXYgaW4KQEAgLTY3 LDggKzY3LDkgQEAgbGV0IHByb2Nlc3Nfd2F0Y2ggdCBjb25zID0KIAkJfCBY ZW5idXMuWGIuT3AuUm0gICAgICAgLT4gdHJ1ZSwgTm9uZSwgb2xkcm9vdAog CQl8IFhlbmJ1cy5YYi5PcC5TZXRwZXJtcyAtPiBmYWxzZSwgU29tZSBvbGRy b290LCBuZXdyb290CiAJCXwgXyAgICAgICAgICAgICAgLT4gcmFpc2UgKEZh aWx1cmUgImh1aCA/IikgaW4KLQkJQ29ubmVjdGlvbnMuZmlyZV93YXRjaGVz ID9vbGRyb290IHJvb3QgY29ucyAoc25kIG9wKSByZWN1cnNlIGluCi0JTGlz dC5pdGVyIChmdW4gb3AgLT4gZG9fb3Bfd2F0Y2ggb3AgY29ucykgb3BzCisJ CUNvbm5lY3Rpb25zLmZpcmVfd2F0Y2hlcyA/b2xkcm9vdCBzb3VyY2Ugcm9v dCBjb25zIChzbmQgb3ApIHJlY3Vyc2UgaW4KKwlMaXN0Lml0ZXIgKGZ1biBv cCAtPiBkb19vcF93YXRjaCBvcCBjb25zKSBvcHM7CisJQ29ubmVjdGlvbnMu c2VuZF93YXRjaGV2ZW50cyBjb25zIHNvdXJjZQogCiBsZXQgY3JlYXRlX2lt cGxpY2l0X3BhdGggdCBwZXJtIHBhdGggPQogCWxldCBkaXJuYW1lID0gU3Rv cmUuUGF0aC5nZXRfcGFyZW50IHBhdGggaW4KQEAgLTIzNCw2ICsyMzUsMjAg QEAgbGV0IGRvX2RlYnVnIGNvbiB0IF9kb21haW5zIGNvbnMgZGF0YSA9CiAJ fCAid2F0Y2hlcyIgOjogXyAtPgogCQlsZXQgd2F0Y2hlcyA9IENvbm5lY3Rp b25zLmRlYnVnIGNvbnMgaW4KIAkJU29tZSAod2F0Y2hlcyBeICJcMDAwIikK Kwl8ICJ4ZW5idXMiIDo6IGRvbWlkIDo6IF8gLT4KKwkJbGV0IGRvbWlkID0g aW50X29mX3N0cmluZyBkb21pZCBpbgorCQlsZXQgY29uID0gQ29ubmVjdGlv bnMuZmluZF9kb21haW4gY29ucyBkb21pZCBpbgorCQlsZXQgcyA9IFByaW50 Zi5zcHJpbnRmICJ4ZW5idXM6ICVzOyBvdmVyZmxvdyBxdWV1ZSBsZW5ndGg6 ICVkLCBjYW5faW5wdXQ6ICViLCBoYXNfbW9yZV9pbnB1dDogJWIsIGhhc19v bGRfb3V0cHV0OiAlYiwgaGFzX25ld19vdXRwdXQ6ICViLCBoYXNfbW9yZV93 b3JrOiAlYi4gcGVuZGluZzogJXMiCisJCQkoWGVuYnVzLlhiLmRlYnVnIGNv bi54YikKKwkJCShDb25uZWN0aW9uLnNvdXJjZV9wZW5kaW5nX3dhdGNoZXZl bnRzIGNvbikKKwkJCShDb25uZWN0aW9uLmNhbl9pbnB1dCBjb24pCisJCQko Q29ubmVjdGlvbi5oYXNfbW9yZV9pbnB1dCBjb24pCisJCQkoQ29ubmVjdGlv bi5oYXNfb2xkX291dHB1dCBjb24pCisJCQkoQ29ubmVjdGlvbi5oYXNfbmV3 X291dHB1dCBjb24pCisJCQkoQ29ubmVjdGlvbi5oYXNfbW9yZV93b3JrIGNv bikKKwkJCShDb25uZWN0aW9ucy5kZWJ1Z193YXRjaGV2ZW50cyBjb25zIGNv bikKKwkJaW4KKwkJU29tZSBzCiAJfCAibWZuIiA6OiBkb21pZCA6OiBfIC0+ CiAJCWxldCBkb21pZCA9IGludF9vZl9zdHJpbmcgZG9taWQgaW4KIAkJbGV0 IGNvbiA9IENvbm5lY3Rpb25zLmZpbmRfZG9tYWluIGNvbnMgZG9taWQgaW4K QEAgLTM0Miw3ICszNTcsNyBAQCBsZXQgcmVwbHlfYWNrIGZjdCBjb24gdCBk b21zIGNvbnMgZGF0YSA9CiAJZmN0IGNvbiB0IGRvbXMgY29ucyBkYXRhOwog CVBhY2tldC5BY2sgKGZ1biAoKSAtPgogCQlpZiBUcmFuc2FjdGlvbi5nZXRf aWQgdCA9IFRyYW5zYWN0aW9uLm5vbmUgdGhlbgotCQkJcHJvY2Vzc193YXRj aCB0IGNvbnMKKwkJCXByb2Nlc3Nfd2F0Y2ggY29uIHQgY29ucwogCSkKIAog bGV0IHJlcGx5X2RhdGEgZmN0IGNvbiB0IGRvbXMgY29ucyBkYXRhID0KQEAg LTUwMSw3ICs1MTYsNyBAQCBsZXQgZG9fd2F0Y2ggY29uIF90IF9kb21haW5z IGNvbnMgZGF0YSA9CiAJUGFja2V0LkFjayAoZnVuICgpIC0+CiAJCSgqIHhl bnN0b3JlLnR4dCBzYXlzIHRoaXMgd2F0Y2ggaXMgZmlyZWQgaW1tZWRpYXRl bHksCiAJCSAgIGltcGx5aW5nIGV2ZW4gaWYgcGF0aCBkb2Vzbid0IGV4aXN0 IG9yIGlzIHVucmVhZGFibGUgKikKLQkJQ29ubmVjdGlvbi5maXJlX3Npbmds ZV93YXRjaF91bmNoZWNrZWQgd2F0Y2gpCisJCUNvbm5lY3Rpb24uZmlyZV9z aW5nbGVfd2F0Y2hfdW5jaGVja2VkIGNvbiB3YXRjaCkKIAogbGV0IGRvX3Vu d2F0Y2ggY29uIF90IF9kb21haW5zIGNvbnMgZGF0YSA9CiAJbGV0IChub2Rl LCB0b2tlbikgPQpAQCAtNTMyLDcgKzU0Nyw3IEBAIGxldCBkb190cmFuc2Fj dGlvbl9lbmQgY29uIHQgZG9tYWlucyBjb25zIGRhdGEgPQogCWlmIG5vdCBz dWNjZXNzIHRoZW4KIAkJcmFpc2UgVHJhbnNhY3Rpb25fYWdhaW47CiAJaWYg Y29tbWl0IHRoZW4gYmVnaW4KLQkJcHJvY2Vzc193YXRjaCB0IGNvbnM7CisJ CXByb2Nlc3Nfd2F0Y2ggY29uIHQgY29uczsKIAkJbWF0Y2ggdC5UcmFuc2Fj dGlvbi50eSB3aXRoCiAJCXwgVHJhbnNhY3Rpb24uTm8gLT4KIAkJCSgpICgq IG5vIG5lZWQgdG8gcmVjb3JkIGFueXRoaW5nICopCkBAIC03MDAsNyArNzE1 LDggQEAgbGV0IHByb2Nlc3NfcGFja2V0IH5zdG9yZSB+Y29ucyB+ZG9tcyB+ Y29uIH5yZXEgPQogbGV0IGRvX2lucHV0IHN0b3JlIGNvbnMgZG9tcyBjb24g PQogCWxldCBuZXdwYWNrZXQgPQogCQl0cnkKLQkJCUNvbm5lY3Rpb24uZG9f aW5wdXQgY29uCisJCQlpZiBDb25uZWN0aW9uLmNhbl9pbnB1dCBjb24gdGhl biBDb25uZWN0aW9uLmRvX2lucHV0IGNvbgorCQkJZWxzZSBOb25lCiAJCXdp dGggWGVuYnVzLlhiLlJlY29ubmVjdCAtPgogCQkJaW5mbyAiJXMgcmVxdWVz dHMgYSByZWNvbm5lY3QiIChDb25uZWN0aW9uLmdldF9kb21zdHIgY29uKTsK IAkJCUhpc3RvcnkucmVjb25uZWN0IGNvbjsKQEAgLTcyOCw2ICs3NDQsNyBA QCBsZXQgZG9faW5wdXQgc3RvcmUgY29ucyBkb21zIGNvbiA9CiAJCUNvbm5l Y3Rpb24uaW5jcl9vcHMgY29uCiAKIGxldCBkb19vdXRwdXQgX3N0b3JlIF9j b25zIF9kb21zIGNvbiA9CisJQ29ubmVjdGlvbi5zb3VyY2VfZmx1c2hfd2F0 Y2hldmVudHMgY29uOwogCWlmIENvbm5lY3Rpb24uaGFzX291dHB1dCBjb24g dGhlbiAoCiAJCWlmIENvbm5lY3Rpb24uaGFzX25ld19vdXRwdXQgY29uIHRo ZW4gKAogCQkJbGV0IHBhY2tldCA9IENvbm5lY3Rpb24ucGVla19vdXRwdXQg Y29uIGluCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQveGVu c3RvcmVkLm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5t bAppbmRleCAzYjU3YWQwMTZkZmIuLmM3OTllMjBmMTE0NSAxMDA2NDQKLS0t IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbAorKysgYi90 b29scy9vY2FtbC94ZW5zdG9yZWQveGVuc3RvcmVkLm1sCkBAIC0xMDMsNiAr MTAzLDggQEAgbGV0IHBhcnNlX2NvbmZpZyBmaWxlbmFtZSA9CiAJCSgicXVv dGEtbWF4ZW50aXR5IiwgQ29uZmlnLlNldF9pbnQgUXVvdGEubWF4ZW50KTsK IAkJKCJxdW90YS1tYXhzaXplIiwgQ29uZmlnLlNldF9pbnQgUXVvdGEubWF4 c2l6ZSk7CiAJCSgicXVvdGEtbWF4cmVxdWVzdHMiLCBDb25maWcuU2V0X2lu dCBEZWZpbmUubWF4cmVxdWVzdHMpOworCQkoInF1b3RhLW1heG91dHN0YW5k aW5nIiwgQ29uZmlnLlNldF9pbnQgRGVmaW5lLm1heG91dHN0YW5kaW5nKTsK KwkJKCJxdW90YS1tYXh3YXRjaGV2ZW50cyIsIENvbmZpZy5TZXRfaW50IERl ZmluZS5tYXh3YXRjaGV2ZW50cyk7CiAJCSgicXVvdGEtcGF0aC1tYXgiLCBD b25maWcuU2V0X2ludCBEZWZpbmUucGF0aF9tYXgpOwogCQkoImdjLW1heC1v dmVyaGVhZCIsIENvbmZpZy5TZXRfaW50IERlZmluZS5nY19tYXhfb3Zlcmhl YWQpOwogCQkoInRlc3QtZWFnYWluIiwgQ29uZmlnLlNldF9ib29sIFRyYW5z YWN0aW9uLnRlc3RfZWFnYWluKTsK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-oxenstored-07.patch" Content-Disposition: attachment; filename="xsa326/xsa326-oxenstored-07.patch" Content-Transfer-Encoding: base64 RnJvbSBhNzczY2NiNjYzZjI2ZGI4MjljODEyNmQ5MmNkN2UwMzhkY2Q4OTVj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFRodSwgMjkgU2VwIDIwMjIgMTM6 MDc6MzUgKzAyMDAKU3ViamVjdDogU1VQUE9SVC5tZDogY2xhcmlmeSBzdXBw b3J0IG9mIHVudHJ1c3RlZCBkcml2ZXIgZG9tYWlucyB3aXRoCiBveGVuc3Rv cmVkCgpBZGQgYSBzdXBwb3J0IHN0YXRlbWVudCBmb3IgdGhlIHNjb3BlIG9m IHN1cHBvcnQgcmVnYXJkaW5nIGRpZmZlcmVudApYZW5zdG9yZSB2YXJpYW50 cy4gRXNwZWNpYWxseSBveGVuc3RvcmVkIGRvZXMgbm90ICh5ZXQpIGhhdmUg c2VjdXJpdHkKc3VwcG9ydCBvZiB1bnRydXN0ZWQgZHJpdmVyIGRvbWFpbnMs IGFzIHRob3NlIG1pZ2h0IGRyaXZlIG94ZW5zdG9yZWQKb3V0IG9mIG1lbW9y eSBieSBjcmVhdGluZyBsb3RzIG9mIHdhdGNoIGV2ZW50cyBmb3IgdGhlIGd1 ZXN0cyB0aGV5IGFyZQpzZXJ2aWNpbmcuCgpBZGQgYSBzdGF0ZW1lbnQgcmVn YXJkaW5nIExpdmUgVXBkYXRlIHN1cHBvcnQgb2Ygb3hlbnN0b3JlZC4KClRo aXMgaXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEdlb3JnZSBE dW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClJldmlld2VkLWJ5OiBD aHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+ CgpkaWZmIC0tZ2l0IGEvU1VQUE9SVC5tZCBiL1NVUFBPUlQubWQKaW5kZXgg Y2YyZGRmYWNhZjA5Li5hYjcxNDY0Y2Y2NzIgMTAwNjQ0Ci0tLSBhL1NVUFBP UlQubWQKKysrIGIvU1VQUE9SVC5tZApAQCAtMTkzLDEzICsxOTMsMTggQEAg U3VwcG9ydCBmb3IgcnVubmluZyBxZW11LXhlbiBkZXZpY2UgbW9kZWwgaW4g YSBsaW51eCBzdHViZG9tYWluLgogCiAgICAgU3RhdHVzOiBUZWNoIFByZXZp ZXcKIAotIyMgTGl2ZXVwZGF0ZSBvZiBDIHhlbnN0b3JlZCBkYWVtb24KKyMj IFhlbnN0b3JlCiAKLSAgICBTdGF0dXM6IFRlY2ggUHJldmlldworIyMjIEMg eGVuc3RvcmVkIGRhZW1vbgogCi0jIyBMaXZldXBkYXRlIG9mIE9DYW1sIHhl bnN0b3JlZCBkYWVtb24KKyAgICBTdGF0dXM6IFN1cHBvcnRlZAorICAgIFN0 YXR1cywgTGl2ZXVwZGF0ZTogVGVjaCBQcmV2aWV3CiAKLSAgICBTdGF0dXM6 IFRlY2ggUHJldmlldworIyMjIE9DYW1sIHhlbnN0b3JlZCBkYWVtb24KKwor ICAgIFN0YXR1czogU3VwcG9ydGVkCisgICAgU3RhdHVzLCB1bnRydXN0ZWQg ZHJpdmVyIGRvbWFpbnM6IFN1cHBvcnRlZCwgbm90IHNlY3VyaXR5IHN1cHBv cnRlZAorICAgIFN0YXR1cywgTGl2ZXVwZGF0ZTogTm90IGZ1bmN0aW9uYWwK IAogIyMgVG9vbHN0YWNrLzNyZCBwYXJ0eQogCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-01.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-01.patch" Content-Transfer-Encoding: base64 RnJvbSAyYzJhNzAzZjZiNDBhN2Q4ZmZkZTNlNDc5OWU2ZDE4YzQzOGQzMDA3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHNwbGl0IHVw IHNlbmRfcmVwbHkoKQoKVG9kYXkgc2VuZF9yZXBseSgpIGlzIHVzZWQgZm9y IGJvdGgsIG5vcm1hbCByZXF1ZXN0IHJlcGxpZXMgYW5kIHdhdGNoCmV2ZW50 cy4KClNwbGl0IGl0IHVwIGludG8gc2VuZF9yZXBseSgpIGFuZCBzZW5kX2V2 ZW50KCkuIFRoaXMgd2lsbCBiZSB1c2VkIHRvCmFkZCBzb21lIGV2ZW50IHNw ZWNpZmljIGhhbmRsaW5nLgoKYWRkX2V2ZW50KCkgY2FuIGJlIG1lcmdlZCBp bnRvIHNlbmRfZXZlbnQoKSwgcmVtb3ZpbmcgdGhlIG5lZWQgZm9yIGFuCmlu dGVybWVkaWF0ZSBtZW1vcnkgYWxsb2NhdGlvbi4KClRoaXMgaXMgcGFydCBv ZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxs QGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpn cm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdy YWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMKaW5kZXggNTViNzllNGMwMzJlLi5lZDc0MmQ5ZGZjMmUgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtNzYzLDQ5ICs3 NjMsMzIgQEAgc3RhdGljIHZvaWQgc2VuZF9lcnJvcihzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgaW50IGVycm9yKQogdm9pZCBzZW5kX3JlcGx5KHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlw ZSwKIAkJY29uc3Qgdm9pZCAqZGF0YSwgdW5zaWduZWQgaW50IGxlbikKIHsK LQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRhdGE7CisJc3RydWN0IGJ1ZmZl cmVkX2RhdGEgKmJkYXRhID0gY29ubi0+aW47CisKKwlhc3NlcnQodHlwZSAh PSBYU19XQVRDSF9FVkVOVCk7CiAKIAlpZiAoIGxlbiA+IFhFTlNUT1JFX1BB WUxPQURfTUFYICkgewogCQlzZW5kX2Vycm9yKGNvbm4sIEUyQklHKTsKIAkJ cmV0dXJuOwogCX0KIAotCS8qIFJlcGxpZXMgcmV1c2UgdGhlIHJlcXVlc3Qg YnVmZmVyLCBldmVudHMgbmVlZCBhIG5ldyBvbmUuICovCi0JaWYgKHR5cGUg IT0gWFNfV0FUQ0hfRVZFTlQpIHsKLQkJYmRhdGEgPSBjb25uLT5pbjsKLQkJ LyogRHJvcCBhc3luY2hyb25vdXMgcmVzcG9uc2VzLCBlLmcuIGVycm9ycyBm b3Igd2F0Y2ggZXZlbnRzLiAqLwotCQlpZiAoIWJkYXRhKQotCQkJcmV0dXJu OwotCQliZGF0YS0+aW5oZHIgPSB0cnVlOwotCQliZGF0YS0+dXNlZCA9IDA7 Ci0JCWNvbm4tPmluID0gTlVMTDsKLQl9IGVsc2UgewotCQkvKiBNZXNzYWdl IGlzIGEgY2hpbGQgb2YgdGhlIGNvbm5lY3Rpb24gZm9yIGF1dG8tY2xlYW51 cC4gKi8KLQkJYmRhdGEgPSBuZXdfYnVmZmVyKGNvbm4pOworCWlmICghYmRh dGEpCisJCXJldHVybjsKKwliZGF0YS0+aW5oZHIgPSB0cnVlOworCWJkYXRh LT51c2VkID0gMDsKIAotCQkvKgotCQkgKiBBbGxvY2F0aW9uIGZhaWx1cmUg aGVyZSBpcyB1bmZvcnR1bmF0ZTogd2UgaGF2ZSBubyB3YXkgdG8KLQkJICog dGVsbCBhbnlib2R5IGFib3V0IGl0LgotCQkgKi8KLQkJaWYgKCFiZGF0YSkK LQkJCXJldHVybjsKLQl9CiAJaWYgKGxlbiA8PSBERUZBVUxUX0JVRkZFUl9T SVpFKQogCQliZGF0YS0+YnVmZmVyID0gYmRhdGEtPmRlZmF1bHRfYnVmZmVy OwotCWVsc2UKKwllbHNlIHsKIAkJYmRhdGEtPmJ1ZmZlciA9IHRhbGxvY19h cnJheShiZGF0YSwgY2hhciwgbGVuKTsKLQlpZiAoIWJkYXRhLT5idWZmZXIp IHsKLQkJaWYgKHR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQpIHsKLQkJCS8qIFNh bWUgYXMgYWJvdmU6IG5vIHdheSB0byB0ZWxsIHNvbWVvbmUuICovCi0JCQl0 YWxsb2NfZnJlZShiZGF0YSk7CisJCWlmICghYmRhdGEtPmJ1ZmZlcikgewor CQkJc2VuZF9lcnJvcihjb25uLCBFTk9NRU0pOwogCQkJcmV0dXJuOwogCQl9 Ci0JCS8qIHJlLWVzdGFibGlzaCByZXF1ZXN0IGJ1ZmZlciBmb3Igc2VuZGlu ZyBFTk9NRU0uICovCi0JCWNvbm4tPmluID0gYmRhdGE7Ci0JCXNlbmRfZXJy b3IoY29ubiwgRU5PTUVNKTsKLQkJcmV0dXJuOwogCX0KIAorCWNvbm4tPmlu ID0gTlVMTDsKKwogCS8qIFVwZGF0ZSByZWxldmFudCBoZWFkZXIgZmllbGRz IGFuZCBmaWxsIGluIHRoZSBtZXNzYWdlIGJvZHkuICovCiAJYmRhdGEtPmhk ci5tc2cudHlwZSA9IHR5cGU7CiAJYmRhdGEtPmhkci5tc2cubGVuID0gbGVu OwpAQCAtODEzLDggKzc5NiwzOSBAQCB2b2lkIHNlbmRfcmVwbHkoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBl LAogCiAJLyogUXVldWUgZm9yIGxhdGVyIHRyYW5zbWlzc2lvbi4gKi8KIAls aXN0X2FkZF90YWlsKCZiZGF0YS0+bGlzdCwgJmNvbm4tPm91dF9saXN0KTsK K30KIAotCXJldHVybjsKKy8qCisgKiBTZW5kIGEgd2F0Y2ggZXZlbnQuCisg KiBBcyB0aGlzIGlzIG5vdCBkaXJlY3RseSByZWxhdGVkIHRvIHRoZSBjdXJy ZW50IGNvbW1hbmQsIGVycm9ycyBjYW4ndCBiZQorICogcmVwb3J0ZWQuCisg Ki8KK3ZvaWQgc2VuZF9ldmVudChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3QgY2hhciAqcGF0aCwgY29uc3QgY2hhciAqdG9rZW4pCit7CisJc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKmJkYXRhOworCXVuc2lnbmVkIGludCBsZW47 CisKKwlsZW4gPSBzdHJsZW4ocGF0aCkgKyAxICsgc3RybGVuKHRva2VuKSAr IDE7CisJLyogRG9uJ3QgdHJ5IHRvIHNlbmQgb3Zlci1sb25nIGV2ZW50cy4g Ki8KKwlpZiAobGVuID4gWEVOU1RPUkVfUEFZTE9BRF9NQVgpCisJCXJldHVy bjsKKworCWJkYXRhID0gbmV3X2J1ZmZlcihjb25uKTsKKwlpZiAoIWJkYXRh KQorCQlyZXR1cm47CisKKwliZGF0YS0+YnVmZmVyID0gdGFsbG9jX2FycmF5 KGJkYXRhLCBjaGFyLCBsZW4pOworCWlmICghYmRhdGEtPmJ1ZmZlcikgewor CQl0YWxsb2NfZnJlZShiZGF0YSk7CisJCXJldHVybjsKKwl9CisJc3RyY3B5 KGJkYXRhLT5idWZmZXIsIHBhdGgpOworCXN0cmNweShiZGF0YS0+YnVmZmVy ICsgc3RybGVuKHBhdGgpICsgMSwgdG9rZW4pOworCWJkYXRhLT5oZHIubXNn LnR5cGUgPSBYU19XQVRDSF9FVkVOVDsKKwliZGF0YS0+aGRyLm1zZy5sZW4g PSBsZW47CisKKwkvKiBRdWV1ZSBmb3IgbGF0ZXIgdHJhbnNtaXNzaW9uLiAq LworCWxpc3RfYWRkX3RhaWwoJmJkYXRhLT5saXN0LCAmY29ubi0+b3V0X2xp c3QpOwogfQogCiAvKiBTb21lIHJvdXRpbmVzICh3cml0ZSwgbWtkaXIsIGV0 YykganVzdCBuZWVkIGEgbm9uLWVycm9yIHJldHVybiAqLwpkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKaW5kZXggN2QwZmU3N2U3OTg5Li45 OWEwMzczOTQ0YjIgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuaApAQCAtMTg3LDYgKzE4Nyw3IEBAIHVuc2lnbmVkIGludCBnZXRfc3Ry aW5nKGNvbnN0IHN0cnVjdCBidWZmZXJlZF9kYXRhICpkYXRhLCB1bnNpZ25l ZCBpbnQgb2Zmc2V0KTsKIAogdm9pZCBzZW5kX3JlcGx5KHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSwKIAkJ Y29uc3Qgdm9pZCAqZGF0YSwgdW5zaWduZWQgaW50IGxlbik7Cit2b2lkIHNl bmRfZXZlbnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IGNoYXIg KnBhdGgsIGNvbnN0IGNoYXIgKnRva2VuKTsKIAogLyogU29tZSByb3V0aW5l cyAod3JpdGUsIG1rZGlyLCBldGMpIGp1c3QgbmVlZCBhIG5vbi1lcnJvciBy ZXR1cm4gKi8KIHZvaWQgc2VuZF9hY2soc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlKTsKZGlmZiAtLWdpdCBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX3dhdGNoLmMKaW5kZXggYWNhMGE3MWJhZGExLi45 OWEyYzI2NmIyOGEgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF93YXRjaC5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93 YXRjaC5jCkBAIC04NiwzNSArODYsNiBAQCBzdGF0aWMgY29uc3QgY2hhciAq Z2V0X3dhdGNoX3BhdGgoY29uc3Qgc3RydWN0IHdhdGNoICp3YXRjaCwgY29u c3QgY2hhciAqbmFtZSkKIH0KIAogLyoKLSAqIFNlbmQgYSB3YXRjaCBldmVu dC4KLSAqIFRlbXBvcmFyeSBtZW1vcnkgYWxsb2NhdGlvbnMgYXJlIGRvbmUg d2l0aCBjdHguCi0gKi8KLXN0YXRpYyB2b2lkIGFkZF9ldmVudChzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKLQkJICAgICAgY29uc3Qgdm9pZCAqY3R4LAot CQkgICAgICBzdHJ1Y3Qgd2F0Y2ggKndhdGNoLAotCQkgICAgICBjb25zdCBj aGFyICpuYW1lKQotewotCS8qIERhdGEgdG8gc2VuZCAobm9kZVwwdG9rZW5c MCkuICovCi0JdW5zaWduZWQgaW50IGxlbjsKLQljaGFyICpkYXRhOwotCi0J bmFtZSA9IGdldF93YXRjaF9wYXRoKHdhdGNoLCBuYW1lKTsKLQotCWxlbiA9 IHN0cmxlbihuYW1lKSArIDEgKyBzdHJsZW4od2F0Y2gtPnRva2VuKSArIDE7 Ci0JLyogRG9uJ3QgdHJ5IHRvIHNlbmQgb3Zlci1sb25nIGV2ZW50cy4gKi8K LQlpZiAobGVuID4gWEVOU1RPUkVfUEFZTE9BRF9NQVgpCi0JCXJldHVybjsK LQotCWRhdGEgPSB0YWxsb2NfYXJyYXkoY3R4LCBjaGFyLCBsZW4pOwotCWlm ICghZGF0YSkKLQkJcmV0dXJuOwotCXN0cmNweShkYXRhLCBuYW1lKTsKLQlz dHJjcHkoZGF0YSArIHN0cmxlbihuYW1lKSArIDEsIHdhdGNoLT50b2tlbik7 Ci0Jc2VuZF9yZXBseShjb25uLCBYU19XQVRDSF9FVkVOVCwgZGF0YSwgbGVu KTsKLQl0YWxsb2NfZnJlZShkYXRhKTsKLX0KLQotLyoKICAqIENoZWNrIHBl cm1pc3Npb25zIG9mIGEgc3BlY2lmaWMgd2F0Y2ggdG8gZmlyZToKICAqIEVp dGhlciB0aGUgbm9kZSBpdHNlbGYgb3IgaXRzIHBhcmVudCBoYXZlIHRvIGJl IHJlYWRhYmxlIGJ5IHRoZSBjb25uZWN0aW9uCiAgKiB0aGUgd2F0Y2ggaGFz IGJlZW4gc2V0dXAgZm9yLiBJbiBjYXNlIGEgd2F0Y2ggZXZlbnQgaXMgY3Jl YXRlZCBkdWUgdG8KQEAgLTE5MCwxMCArMTYxLDE0IEBAIHZvaWQgZmlyZV93 YXRjaGVzKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpj dHgsIGNvbnN0IGNoYXIgKm5hbWUsCiAJCWxpc3RfZm9yX2VhY2hfZW50cnko d2F0Y2gsICZpLT53YXRjaGVzLCBsaXN0KSB7CiAJCQlpZiAoZXhhY3QpIHsK IAkJCQlpZiAoc3RyZXEobmFtZSwgd2F0Y2gtPm5vZGUpKQotCQkJCQlhZGRf ZXZlbnQoaSwgY3R4LCB3YXRjaCwgbmFtZSk7CisJCQkJCXNlbmRfZXZlbnQo aSwKKwkJCQkJCSAgIGdldF93YXRjaF9wYXRoKHdhdGNoLCBuYW1lKSwKKwkJ CQkJCSAgIHdhdGNoLT50b2tlbik7CiAJCQl9IGVsc2UgewogCQkJCWlmIChp c19jaGlsZChuYW1lLCB3YXRjaC0+bm9kZSkpCi0JCQkJCWFkZF9ldmVudChp LCBjdHgsIHdhdGNoLCBuYW1lKTsKKwkJCQkJc2VuZF9ldmVudChpLAorCQkJ CQkJICAgZ2V0X3dhdGNoX3BhdGgod2F0Y2gsIG5hbWUpLAorCQkJCQkJICAg d2F0Y2gtPnRva2VuKTsKIAkJCX0KIAkJfQogCX0KQEAgLTI5Miw3ICsyNjcs NyBAQCBpbnQgZG9fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAlzZW5kX2Fjayhjb25uLCBYU19X QVRDSCk7CiAKIAkvKiBXZSBmaXJlIG9uY2UgdXAgZnJvbnQ6IHNpbXBsaWZp ZXMgY2xpZW50cyBhbmQgcmVzdGFydC4gKi8KLQlhZGRfZXZlbnQoY29ubiwg aW4sIHdhdGNoLCB3YXRjaC0+bm9kZSk7CisJc2VuZF9ldmVudChjb25uLCBn ZXRfd2F0Y2hfcGF0aCh3YXRjaCwgd2F0Y2gtPm5vZGUpLCB3YXRjaC0+dG9r ZW4pOwogCiAJcmV0dXJuIDA7CiB9Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-02.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-02.patch" Content-Transfer-Encoding: base64 RnJvbSBkZjBjMTA3ZmJmNjVmNjFiYjFkMzFjOWEzNGVjZWUwNWYzODUyNmE3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBoZWxw ZXJzIHRvIGZyZWUgc3RydWN0IGJ1ZmZlcmVkX2RhdGEKCkFkZCB0d28gaGVs cGVycyBmb3IgZnJlZWluZyBzdHJ1Y3QgYnVmZmVyZWRfZGF0YTogZnJlZV9i dWZmZXJlZF9kYXRhKCkKZm9yIGZyZWVpbmcgb25lIGluc3RhbmNlIGFuZCBj b25uX2ZyZWVfYnVmZmVyZWRfZGF0YSgpIGZvciBmcmVlaW5nIGFsbAppbnN0 YW5jZXMgZm9yIGEgY29ubmVjdGlvbi4KClRoaXMgaXMgYXZvaWRpbmcgZHVw bGljYXRlZCBjb2RlIGFuZCB3aWxsIGhlbHAgbGF0ZXIgd2hlbiBtb3JlIGFj dGlvbnMKYXJlIG5lZWRlZCB3aGVuIGZyZWVpbmcgYSBzdHJ1Y3QgYnVmZmVy ZWRfZGF0YS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQt Ynk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1v ZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3 ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggZWQ3NDJkOWRm YzJlLi42MWZjMzY4ZThjMjggMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYwpAQCAtMjA3LDYgKzIwNywyMSBAQCB2b2lkIHJlb3Blbl9s b2codm9pZCkKIAl9CiB9CiAKK3N0YXRpYyB2b2lkIGZyZWVfYnVmZmVyZWRf ZGF0YShzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqb3V0LAorCQkJICAgICAgIHN0 cnVjdCBjb25uZWN0aW9uICpjb25uKQoreworCWxpc3RfZGVsKCZvdXQtPmxp c3QpOworCXRhbGxvY19mcmVlKG91dCk7Cit9CisKK3ZvaWQgY29ubl9mcmVl X2J1ZmZlcmVkX2RhdGEoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCit7CisJ c3RydWN0IGJ1ZmZlcmVkX2RhdGEgKm91dDsKKworCXdoaWxlICgob3V0ID0g bGlzdF90b3AoJmNvbm4tPm91dF9saXN0LCBzdHJ1Y3QgYnVmZmVyZWRfZGF0 YSwgbGlzdCkpKQorCQlmcmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBjb25uKTsK K30KKwogc3RhdGljIGJvb2wgd3JpdGVfbWVzc2FnZXMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pCiB7CiAJaW50IHJldDsKQEAgLTI1MCw4ICsyNjUsNyBA QCBzdGF0aWMgYm9vbCB3cml0ZV9tZXNzYWdlcyhzdHJ1Y3QgY29ubmVjdGlv biAqY29ubikKIAogCXRyYWNlX2lvKGNvbm4sIG91dCwgMSk7CiAKLQlsaXN0 X2RlbCgmb3V0LT5saXN0KTsKLQl0YWxsb2NfZnJlZShvdXQpOworCWZyZWVf YnVmZmVyZWRfZGF0YShvdXQsIGNvbm4pOwogCiAJcmV0dXJuIHRydWU7CiB9 CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5o IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCA5OWEw MzczOTQ0YjIuLmM5ZWE3OTYxODVlOCAxMDA2NDQKLS0tIGEvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvcmUuaAorKysgYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfY29yZS5oCkBAIC0yNzEsNiArMjcxLDggQEAgaW50IHJlbWVt YmVyX3N0cmluZyhzdHJ1Y3QgaGFzaHRhYmxlICpoYXNoLCBjb25zdCBjaGFy ICpzdHIpOwogCiB2b2lkIHNldF90ZGJfa2V5KGNvbnN0IGNoYXIgKm5hbWUs IFREQl9EQVRBICprZXkpOwogCit2b2lkIGNvbm5fZnJlZV9idWZmZXJlZF9k YXRhKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsKKwogY29uc3QgY2hhciAq ZHVtcF9zdGF0ZV9nbG9iYWwoRklMRSAqZnApOwogY29uc3QgY2hhciAqZHVt cF9zdGF0ZV9idWZmZXJlZF9kYXRhKEZJTEUgKmZwLCBjb25zdCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqYywKIAkJCQkgICAgIHN0cnVjdCB4c19zdGF0ZV9jb25u ZWN0aW9uICpzYyk7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9t YWluLmMKaW5kZXggZWFkNGMyMzdkMjMzLi5kZTM0OWUyYTc3YTUgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYworKysg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMKQEAgLTQxMSwx NSArNDExLDEwIEBAIHN0YXRpYyBzdHJ1Y3QgZG9tYWluICpmaW5kX2RvbWFp bl9ieV9kb21pZCh1bnNpZ25lZCBpbnQgZG9taWQpCiBzdGF0aWMgdm9pZCBk b21haW5fY29ubl9yZXNldChzdHJ1Y3QgZG9tYWluICpkb21haW4pCiB7CiAJ c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4gPSBkb21haW4tPmNvbm47Ci0Jc3Ry dWN0IGJ1ZmZlcmVkX2RhdGEgKm91dDsKIAogCWNvbm5fZGVsZXRlX2FsbF93 YXRjaGVzKGNvbm4pOwogCWNvbm5fZGVsZXRlX2FsbF90cmFuc2FjdGlvbnMo Y29ubik7Ci0KLQl3aGlsZSAoKG91dCA9IGxpc3RfdG9wKCZjb25uLT5vdXRf bGlzdCwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEsIGxpc3QpKSkgewotCQlsaXN0 X2RlbCgmb3V0LT5saXN0KTsKLQkJdGFsbG9jX2ZyZWUob3V0KTsKLQl9CisJ Y29ubl9mcmVlX2J1ZmZlcmVkX2RhdGEoY29ubik7CiAKIAl0YWxsb2NfZnJl ZShjb25uLT5pbik7CiAKQEAgLTQzNiw4ICs0MzEsNiBAQCBzdGF0aWMgdm9p ZCBkb21haW5fY29ubl9yZXNldChzdHJ1Y3QgZG9tYWluICpkb21haW4pCiAg Ki8KIHZvaWQgaWdub3JlX2Nvbm5lY3Rpb24oc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHVuc2lnbmVkIGludCBlcnIpCiB7Ci0Jc3RydWN0IGJ1ZmZlcmVk X2RhdGEgKm91dCwgKnRtcDsKLQogCXRyYWNlKCJDT05OICVwIGlnbm9yZWQs IHJlYXNvbiAldVxuIiwgY29ubiwgZXJyKTsKIAogCWlmIChjb25uLT5kb21h aW4gJiYgY29ubi0+ZG9tYWluLT5pbnRlcmZhY2UpCkBAIC00NDYsMTEgKzQz OSw3IEBAIHZvaWQgaWdub3JlX2Nvbm5lY3Rpb24oc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIHVuc2lnbmVkIGludCBlcnIpCiAJY29ubi0+aXNfaWdub3Jl ZCA9IHRydWU7CiAJY29ubl9kZWxldGVfYWxsX3dhdGNoZXMoY29ubik7CiAJ Y29ubl9kZWxldGVfYWxsX3RyYW5zYWN0aW9ucyhjb25uKTsKLQotCWxpc3Rf Zm9yX2VhY2hfZW50cnlfc2FmZShvdXQsIHRtcCwgJmNvbm4tPm91dF9saXN0 LCBsaXN0KSB7Ci0JCWxpc3RfZGVsKCZvdXQtPmxpc3QpOwotCQl0YWxsb2Nf ZnJlZShvdXQpOwotCX0KKwljb25uX2ZyZWVfYnVmZmVyZWRfZGF0YShjb25u KTsKIAogCXRhbGxvY19mcmVlKGNvbm4tPmluKTsKIAljb25uLT5pbiA9IE5V TEw7Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-03.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-03.patch" Content-Transfer-Encoding: base64 RnJvbSAxNmE4YTE4NTRiYzhiMzM1ZmZiODI3ODZhOWRkOTBhZDI2OGFhNTU4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHJlZHVjZSBu dW1iZXIgb2Ygd2F0Y2ggZXZlbnRzCgpXaGVuIHJlbW92aW5nIGEgd2F0Y2hl ZCBub2RlIG91dHNpZGUgb2YgYSB0cmFuc2FjdGlvbiwgdHdvIHdhdGNoIGV2 ZW50cwphcmUgYmVpbmcgcHJvZHVjZWQgaW5zdGVhZCBvZiBqdXN0IGEgc2lu Z2xlIG9uZS4KCldoZW4gZmluYWxpemluZyBhIHRyYW5zYWN0aW9uIHdhdGNo IGV2ZW50cyBjYW4gYmUgZ2VuZXJhdGVkIGZvciBlYWNoCm5vZGUgd2hpY2gg aXMgYmVpbmcgbW9kaWZpZWQsIGV2ZW4gaWYgb3V0c2lkZSBhIHRyYW5zYWN0 aW9uIHN1Y2gKbW9kaWZpY2F0aW9ucyBtaWdodCBub3QgaGF2ZSByZXN1bHRl ZCBpbiBhIHdhdGNoIGV2ZW50LgoKVGhpcyBoYXBwZW5zIGUuZy46CgotIGZv ciBub2RlcyB3aGljaCBhcmUgb25seSBtb2RpZmllZCBkdWUgdG8gYWRkZWQv cmVtb3ZlZCBjaGlsZCBlbnRyaWVzCi0gZm9yIG5vZGVzIGJlaW5nIHJlbW92 ZWQgb3IgY3JlYXRlZCBpbXBsaWNpdGx5IChlLmcuIGNyZWF0aW9uIG9mIGEv Yi9jCiAgaXMgaW1wbGljaXRseSBjcmVhdGluZyBhL2IsIHJlc3VsdGluZyBp biB3YXRjaCBldmVudHMgZm9yIGEsIGEvYiBhbmQKICBhL2IvYyBpbnN0ZWFk IG9mIGEvYi9jIG9ubHkpCgpBdm9pZCB0aGVzZSBhZGRpdGlvbmFsIHdhdGNo IGV2ZW50cywgaW4gb3JkZXIgdG8gcmVkdWNlIHRoZSBuZWVkZWQKbWVtb3J5 IGluc2lkZSBYZW5zdG9yZSBmb3IgcXVldWVpbmcgdGhlbS4KClRoaXMgaXMg YmVpbmcgYWNoaWV2ZWQgYnkgYWRkaW5nIGV2ZW50IGZsYWdzIHRvIHN0cnVj dCBhY2Nlc3NlZF9ub2RlCnNwZWNpZnlpbmcgd2hldGhlciBhbiBldmVudCBz aG91bGQgYmUgdHJpZ2dlcmVkLCBhbmQgd2hldGhlciBpdCBzaG91bGQKYmUg YW4gZXhhY3QgbWF0Y2ggb2YgdGhlIG1vZGlmaWVkIHBhdGguIEJvdGggZmxh Z3MgY2FuIGJlIHNldCBmcm9tCmZpcmVfd2F0Y2hlcygpIGluc3RlYWQgb2Yg aW1wbHlpbmcgdGhlbSBvbmx5LgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYu CgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNv bT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwppbmRl eCA2MWZjMzY4ZThjMjguLmI5YTBmZjVlMDVjZiAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0xMjkxLDcgKzEyOTEsNyBAQCBz dGF0aWMgdm9pZCBkZWxldGVfY2hpbGQoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sCiB9CiAKIHN0YXRpYyBpbnQgZGVsZXRlX25vZGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKLQkJICAgICAgIHN0cnVj dCBub2RlICpwYXJlbnQsIHN0cnVjdCBub2RlICpub2RlKQorCQkgICAgICAg c3RydWN0IG5vZGUgKnBhcmVudCwgc3RydWN0IG5vZGUgKm5vZGUsIGJvb2wg d2F0Y2hfZXhhY3QpCiB7CiAJY2hhciAqbmFtZTsKIApAQCAtMTMwMyw3ICsx MzAzLDcgQEAgc3RhdGljIGludCBkZWxldGVfbm9kZShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCQkJCSAgICAgICBub2Rl LT5jaGlsZHJlbik7CiAJCWNoaWxkID0gbmFtZSA/IHJlYWRfbm9kZShjb25u LCBub2RlLCBuYW1lKSA6IE5VTEw7CiAJCWlmIChjaGlsZCkgewotCQkJaWYg KGRlbGV0ZV9ub2RlKGNvbm4sIGN0eCwgbm9kZSwgY2hpbGQpKQorCQkJaWYg KGRlbGV0ZV9ub2RlKGNvbm4sIGN0eCwgbm9kZSwgY2hpbGQsIHRydWUpKQog CQkJCXJldHVybiBlcnJubzsKIAkJfSBlbHNlIHsKIAkJCXRyYWNlKCJkZWxl dGVfbm9kZTogRXJyb3IgZGVsZXRpbmcgY2hpbGQgJyVzLyVzJyFcbiIsCkBA IC0xMzE1LDcgKzEzMTUsMTIgQEAgc3RhdGljIGludCBkZWxldGVfbm9kZShz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCQl0 YWxsb2NfZnJlZShuYW1lKTsKIAl9CiAKLQlmaXJlX3dhdGNoZXMoY29ubiwg Y3R4LCBub2RlLT5uYW1lLCBub2RlLCB0cnVlLCBOVUxMKTsKKwkvKgorCSAq IEZpcmUgdGhlIHdhdGNoZXMgbm93LCB3aGVuIHdlIGNhbiBzdGlsbCBzZWUg dGhlIG5vZGUgcGVybWlzc2lvbnMuCisJICogVGhpcyBmaW5lIGFzIHdlIGFy ZSBzaW5nbGUgdGhyZWFkZWQgYW5kIHRoZSBuZXh0IHBvc3NpYmxlIHJlYWQg d2lsbAorCSAqIGJlIGhhbmRsZWQgb25seSBhZnRlciB0aGUgbm9kZSBoYXMg YmVlbiByZWFsbHkgcmVtb3ZlZC4KKwkgKi8KKwlmaXJlX3dhdGNoZXMoY29u biwgY3R4LCBub2RlLT5uYW1lLCBub2RlLCB3YXRjaF9leGFjdCwgTlVMTCk7 CiAJZGVsZXRlX25vZGVfc2luZ2xlKGNvbm4sIG5vZGUpOwogCWRlbGV0ZV9j aGlsZChjb25uLCBwYXJlbnQsIGJhc2VuYW1lKG5vZGUtPm5hbWUpKTsKIAl0 YWxsb2NfZnJlZShub2RlKTsKQEAgLTEzNDEsMTMgKzEzNDYsNyBAQCBzdGF0 aWMgaW50IF9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9p ZCAqY3R4LCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIAkJcmV0dXJuIChlcnJubyA9 PSBFTk9NRU0pID8gRU5PTUVNIDogRUlOVkFMOwogCW5vZGUtPnBhcmVudCA9 IHBhcmVudDsKIAotCS8qCi0JICogRmlyZSB0aGUgd2F0Y2hlcyBub3csIHdo ZW4gd2UgY2FuIHN0aWxsIHNlZSB0aGUgbm9kZSBwZXJtaXNzaW9ucy4KLQkg KiBUaGlzIGZpbmUgYXMgd2UgYXJlIHNpbmdsZSB0aHJlYWRlZCBhbmQgdGhl IG5leHQgcG9zc2libGUgcmVhZCB3aWxsCi0JICogYmUgaGFuZGxlZCBvbmx5 IGFmdGVyIHRoZSBub2RlIGhhcyBiZWVuIHJlYWxseSByZW1vdmVkLgotCSAq LwotCWZpcmVfd2F0Y2hlcyhjb25uLCBjdHgsIG5hbWUsIG5vZGUsIGZhbHNl LCBOVUxMKTsKLQlyZXR1cm4gZGVsZXRlX25vZGUoY29ubiwgY3R4LCBwYXJl bnQsIG5vZGUpOworCXJldHVybiBkZWxldGVfbm9kZShjb25uLCBjdHgsIHBh cmVudCwgbm9kZSwgZmFsc2UpOwogfQogCiAKZGlmZiAtLWdpdCBhL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKaW5kZXggZmFmNmM5MzBl NDJhLi41NDQzMjkwN2ZjNzYgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCisrKyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCkBAIC0xMzAsNiArMTMwLDEwIEBA IHN0cnVjdCBhY2Nlc3NlZF9ub2RlCiAKIAkvKiBUcmFuc2FjdGlvbiBub2Rl IGluIGRhdGEgYmFzZT8gKi8KIAlib29sIHRhX25vZGU7CisKKwkvKiBXYXRj aCBldmVudCBmbGFncy4gKi8KKwlib29sIGZpcmVfd2F0Y2g7CisJYm9vbCB3 YXRjaF9leGFjdDsKIH07CiAKIHN0cnVjdCBjaGFuZ2VkX2RvbWFpbgpAQCAt MzI0LDYgKzMyOCwyOSBAQCBpbnQgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAogfQogCiAvKgorICog QSB3YXRjaCBldmVudCBzaG91bGQgYmUgZmlyZWQgZm9yIGEgbm9kZSBtb2Rp ZmllZCBpbnNpZGUgYSB0cmFuc2FjdGlvbi4KKyAqIFNldCB0aGUgY29ycmVz cG9uZGluZyBpbmZvcm1hdGlvbi4gQSBub24tZXhhY3QgZXZlbnQgaXMgcmVw bGFjaW5nIGFuIGV4YWN0CisgKiBvbmUsIGJ1dCBub3QgdGhlIG90aGVyIHdh eSByb3VuZC4KKyAqLwordm9pZCBxdWV1ZV93YXRjaGVzKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpuYW1lLCBib29sIHdhdGNoX2V4 YWN0KQoreworCXN0cnVjdCBhY2Nlc3NlZF9ub2RlICppOworCisJaSA9IGZp bmRfYWNjZXNzZWRfbm9kZShjb25uLT50cmFuc2FjdGlvbiwgbmFtZSk7CisJ aWYgKCFpKSB7CisJCWNvbm4tPnRyYW5zYWN0aW9uLT5mYWlsID0gdHJ1ZTsK KwkJcmV0dXJuOworCX0KKworCWlmICghaS0+ZmlyZV93YXRjaCkgeworCQlp LT5maXJlX3dhdGNoID0gdHJ1ZTsKKwkJaS0+d2F0Y2hfZXhhY3QgPSB3YXRj aF9leGFjdDsKKwl9IGVsc2UgaWYgKCF3YXRjaF9leGFjdCkgeworCQlpLT53 YXRjaF9leGFjdCA9IGZhbHNlOworCX0KK30KKworLyoKICAqIEZpbmFsaXpl IHRyYW5zYWN0aW9uOgogICogV2FsayB0aHJvdWdoIGFjY2Vzc2VkIG5vZGVz IGFuZCBjaGVjayBnZW5lcmF0aW9uIGFnYWluc3QgZ2xvYmFsIGRhdGEuCiAg KiBJZiBhbGwgZW50cmllcyBtYXRjaCwgcmVhZCB0aGUgdHJhbnNhY3Rpb24g ZW50cmllcyBhbmQgd3JpdGUgdGhlbSB3aXRob3V0CkBAIC0zNzcsMTUgKzQw NCwxNSBAQCBzdGF0aWMgaW50IGZpbmFsaXplX3RyYW5zYWN0aW9uKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAogCQkJCXJldCA9IHRkYl9zdG9yZSh0ZGJf Y3R4LCBrZXksIGRhdGEsCiAJCQkJCQlUREJfUkVQTEFDRSk7CiAJCQkJdGFs bG9jX2ZyZWUoZGF0YS5kcHRyKTsKLQkJCQlpZiAocmV0KQotCQkJCQlnb3Rv IGVycjsKLQkJCQlmaXJlX3dhdGNoZXMoY29ubiwgdHJhbnMsIGktPm5vZGUs IE5VTEwsIGZhbHNlLAotCQkJCQkgICAgIGktPnBlcm1zLnAgPyAmaS0+cGVy bXMgOiBOVUxMKTsKIAkJCX0gZWxzZSB7Ci0JCQkJZmlyZV93YXRjaGVzKGNv bm4sIHRyYW5zLCBpLT5ub2RlLCBOVUxMLCBmYWxzZSwKKwkJCQlyZXQgPSB0 ZGJfZGVsZXRlKHRkYl9jdHgsIGtleSk7CisJCQl9CisJCQlpZiAocmV0KQor CQkJCWdvdG8gZXJyOworCQkJaWYgKGktPmZpcmVfd2F0Y2gpIHsKKwkJCQlm aXJlX3dhdGNoZXMoY29ubiwgdHJhbnMsIGktPm5vZGUsIE5VTEwsCisJCQkJ CSAgICAgaS0+d2F0Y2hfZXhhY3QsCiAJCQkJCSAgICAgaS0+cGVybXMucCA/ ICZpLT5wZXJtcyA6IE5VTEwpOwotCQkJCWlmICh0ZGJfZGVsZXRlKHRkYl9j dHgsIGtleSkpCi0JCQkJCWdvdG8gZXJyOwogCQkJfQogCQl9CiAKZGlmZiAt LWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5o IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKaW5k ZXggMTQwNjI3MzBlM2M5Li4wMDkzY2FjODA3ZTMgMTAwNjQ0Ci0tLSBhL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCisrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCkBAIC00Miw2 ICs0Miw5IEBAIHZvaWQgdHJhbnNhY3Rpb25fZW50cnlfZGVjKHN0cnVjdCB0 cmFuc2FjdGlvbiAqdHJhbnMsIHVuc2lnbmVkIGludCBkb21pZCk7CiBpbnQg YWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlLAogICAgICAgICAgICAgICAgIGVudW0gbm9kZV9hY2Nlc3Nf dHlwZSB0eXBlLCBUREJfREFUQSAqa2V5KTsKIAorLyogUXVldWUgd2F0Y2hl cyBmb3IgYSBtb2RpZmllZCBub2RlLiAqLwordm9pZCBxdWV1ZV93YXRjaGVz KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpuYW1lLCBi b29sIHdhdGNoX2V4YWN0KTsKKwogLyogUHJlcGVuZCB0aGUgdHJhbnNhY3Rp b24gdG8gbmFtZSBpZiBhcHByb3ByaWF0ZS4gKi8KIGludCB0cmFuc2FjdGlv bl9wcmVwZW5kKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFy ICpuYW1lLAogICAgICAgICAgICAgICAgICAgICAgICAgVERCX0RBVEEgKmtl eSk7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0 Y2guYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCmluZGV4 IDk5YTJjMjY2YjI4YS4uMjA1ZDlkOGVhMTE2IDEwMDY0NAotLS0gYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfd2F0Y2guYwpAQCAtMjksNiArMjksNyBAQAogI2lu Y2x1ZGUgInhlbnN0b3JlX2xpYi5oIgogI2luY2x1ZGUgInV0aWxzLmgiCiAj aW5jbHVkZSAieGVuc3RvcmVkX2RvbWFpbi5oIgorI2luY2x1ZGUgInhlbnN0 b3JlZF90cmFuc2FjdGlvbi5oIgogCiBleHRlcm4gaW50IHF1b3RhX25iX3dh dGNoX3Blcl9kb21haW47CiAKQEAgLTE0Myw5ICsxNDQsMTEgQEAgdm9pZCBm aXJlX3dhdGNoZXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZv aWQgKmN0eCwgY29uc3QgY2hhciAqbmFtZSwKIAlzdHJ1Y3QgY29ubmVjdGlv biAqaTsKIAlzdHJ1Y3Qgd2F0Y2ggKndhdGNoOwogCi0JLyogRHVyaW5nIHRy YW5zYWN0aW9ucywgZG9uJ3QgZmlyZSB3YXRjaGVzLiAqLwotCWlmIChjb25u ICYmIGNvbm4tPnRyYW5zYWN0aW9uKQorCS8qIER1cmluZyB0cmFuc2FjdGlv bnMsIGRvbid0IGZpcmUgd2F0Y2hlcywgYnV0IHF1ZXVlIHRoZW0uICovCisJ aWYgKGNvbm4gJiYgY29ubi0+dHJhbnNhY3Rpb24pIHsKKwkJcXVldWVfd2F0 Y2hlcyhjb25uLCBuYW1lLCBleGFjdCk7CiAJCXJldHVybjsKKwl9CiAKIAkv KiBDcmVhdGUgYW4gZXZlbnQgZm9yIGVhY2ggd2F0Y2guICovCiAJbGlzdF9m b3JfZWFjaF9lbnRyeShpLCAmY29ubmVjdGlvbnMsIGxpc3QpIHsK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-04.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-04.patch" Content-Transfer-Encoding: base64 RnJvbSA1MDhmNThhOTI1OTdlMmNhNzI3NzUyZWJkZjlhZGJhNTljZjNmYjIz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDcgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxldCB1bnJl YWQgd2F0Y2ggZXZlbnRzIHRpbWUgb3V0CgpBIGZ1dHVyZSBtb2RpZmljYXRp b24gd2lsbCBsaW1pdCB0aGUgbnVtYmVyIG9mIG91dHN0YW5kaW5nIHJlcXVl c3RzCmZvciBhIGRvbWFpbiwgd2hlcmUgIm91dHN0YW5kaW5nIiBtZWFucyB0 aGF0IHRoZSByZXNwb25zZSBvZiB0aGUKcmVxdWVzdCBvciBhbnkgcmVzdWx0 aW5nIHdhdGNoIGV2ZW50IGhhc24ndCBiZWVuIGNvbnN1bWVkIHlldC4KCklu IG9yZGVyIHRvIGF2b2lkIGEgbWFsaWNpb3VzIGd1ZXN0IGJlaW5nIGNhcGFi bGUgdG8gYmxvY2sgb3RoZXIgZ3Vlc3RzCmJ5IG5vdCByZWFkaW5nIHdhdGNo IGV2ZW50cywgYWRkIGEgdGltZW91dCBmb3Igd2F0Y2ggZXZlbnRzLiBJbiBj YXNlIGEKd2F0Y2ggZXZlbnQgaGFzbid0IGJlZW4gY29uc3VtZWQgYWZ0ZXIg dGhpcyB0aW1lb3V0LCBpdCBpcyBiZWluZwpkZWxldGVkLiBTZXQgdGhlIGRl ZmF1bHQgdGltZW91dCB0byAyMCBzZWNvbmRzIChhIHJhbmRvbSB2YWx1ZSBi ZWluZwpub3QgdG9vIGhpZ2gpLgoKSW4gb3JkZXIgdG8gc3VwcG9ydCB0byBz cGVjaWZ5IG90aGVyIHRpbWVvdXQgdmFsdWVzIGluIGZ1dHVyZSwgdXNlIGEK Z2VuZXJpYyBjb21tYW5kIGxpbmUgb3B0aW9uIGZvciB0aGF0IHB1cnBvc2U6 CgotLXRpbWVvdXR8LXcgd2F0Y2gtZXZlbnQ9PHNlY29uZHM+CgpUaGlzIGlz IHBhcnQgb2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzExLgoKUmVwb3J0ZWQt Ynk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1v ZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3 ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggYjlhMGZmNWUw NWNmLi5jY2UwMmYyNGI1MWMgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYwpAQCAtMTA4LDYgKzEwOCw4IEBAIGludCBxdW90YV9tYXhf dHJhbnNhY3Rpb24gPSAxMDsKIGludCBxdW90YV9uYl9wZXJtc19wZXJfbm9k ZSA9IDU7CiBpbnQgcXVvdGFfbWF4X3BhdGhfbGVuID0gWEVOU1RPUkVfUkVM X1BBVEhfTUFYOwogCit1bnNpZ25lZCBpbnQgdGltZW91dF93YXRjaF9ldmVu dF9tc2VjID0gMjAwMDA7CisKIHZvaWQgdHJhY2UoY29uc3QgY2hhciAqZm10 LCAuLi4pCiB7CiAJdmFfbGlzdCBhcmdsaXN0OwpAQCAtMjA3LDE5ICsyMDks OTIgQEAgdm9pZCByZW9wZW5fbG9nKHZvaWQpCiAJfQogfQogCitzdGF0aWMg dWludDY0X3QgZ2V0X25vd19tc2VjKHZvaWQpCit7CisJc3RydWN0IHRpbWVz cGVjIG5vd190czsKKworCWlmIChjbG9ja19nZXR0aW1lKENMT0NLX01PTk9U T05JQywgJm5vd190cykpCisJCWJhcmZfcGVycm9yKCJDb3VsZCBub3QgZmlu ZCB0aW1lIChjbG9ja19nZXR0aW1lIGZhaWxlZCkiKTsKKworCXJldHVybiBu b3dfdHMudHZfc2VjICogMTAwMCArIG5vd190cy50dl9uc2VjIC8gMTAwMDAw MDsKK30KKwogc3RhdGljIHZvaWQgZnJlZV9idWZmZXJlZF9kYXRhKHN0cnVj dCBidWZmZXJlZF9kYXRhICpvdXQsCiAJCQkgICAgICAgc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pCiB7CisJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKnJlcTsK KwogCWxpc3RfZGVsKCZvdXQtPmxpc3QpOworCisJLyoKKwkgKiBVcGRhdGUg Y29ubi0+dGltZW91dF9tc2VjIHdpdGggdGhlIG5leHQgZm91bmQgdGltZW91 dCB2YWx1ZSBpbiB0aGUKKwkgKiBxdWV1ZWQgcGVuZGluZyByZXF1ZXN0cy4K KwkgKi8KKwlpZiAob3V0LT50aW1lb3V0X21zZWMpIHsKKwkJY29ubi0+dGlt ZW91dF9tc2VjID0gMDsKKwkJbGlzdF9mb3JfZWFjaF9lbnRyeShyZXEsICZj b25uLT5vdXRfbGlzdCwgbGlzdCkgeworCQkJaWYgKHJlcS0+dGltZW91dF9t c2VjKSB7CisJCQkJY29ubi0+dGltZW91dF9tc2VjID0gcmVxLT50aW1lb3V0 X21zZWM7CisJCQkJYnJlYWs7CisJCQl9CisJCX0KKwl9CisKIAl0YWxsb2Nf ZnJlZShvdXQpOwogfQogCitzdGF0aWMgdm9pZCBjaGVja19ldmVudF90aW1l b3V0KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCB1aW50NjRfdCBtc2VjcywK KwkJCQlpbnQgKnB0aW1lb3V0KQoreworCXVpbnQ2NF90IGRlbHRhOworCXN0 cnVjdCBidWZmZXJlZF9kYXRhICpvdXQsICp0bXA7CisKKwlpZiAoIWNvbm4t PnRpbWVvdXRfbXNlYykKKwkJcmV0dXJuOworCisJZGVsdGEgPSBjb25uLT50 aW1lb3V0X21zZWMgLSBtc2VjczsKKwlpZiAoY29ubi0+dGltZW91dF9tc2Vj IDw9IG1zZWNzKSB7CisJCWRlbHRhID0gMDsKKwkJbGlzdF9mb3JfZWFjaF9l bnRyeV9zYWZlKG91dCwgdG1wLCAmY29ubi0+b3V0X2xpc3QsIGxpc3QpIHsK KwkJCS8qCisJCQkgKiBPbmx5IGxvb2sgYXQgYnVmZmVycyB3aXRoIHRpbWVv dXQgYW5kIG5vIGRhdGEKKwkJCSAqIGFscmVhZHkgd3JpdHRlbiB0byB0aGUg cmluZy4KKwkJCSAqLworCQkJaWYgKG91dC0+dGltZW91dF9tc2VjICYmIG91 dC0+aW5oZHIgJiYgIW91dC0+dXNlZCkgeworCQkJCWlmIChvdXQtPnRpbWVv dXRfbXNlYyA+IG1zZWNzKSB7CisJCQkJCWNvbm4tPnRpbWVvdXRfbXNlYyA9 IG91dC0+dGltZW91dF9tc2VjOworCQkJCQlkZWx0YSA9IGNvbm4tPnRpbWVv dXRfbXNlYyAtIG1zZWNzOworCQkJCQlicmVhazsKKwkJCQl9CisKKwkJCQkv KgorCQkJCSAqIEZyZWUgb3V0IHdpdGhvdXQgdXBkYXRpbmcgY29ubi0+dGlt ZW91dF9tc2VjLAorCQkJCSAqIGFzIHRoZSB1cGRhdGUgaXMgZG9uZSBpbiB0 aGlzIGxvb3AgYWxyZWFkeS4KKwkJCQkgKi8KKwkJCQlvdXQtPnRpbWVvdXRf bXNlYyA9IDA7CisJCQkJdHJhY2UoIndhdGNoIGV2ZW50IHBhdGggJXMgZm9y IGRvbWFpbiAldSB0aW1lZCBvdXRcbiIsCisJCQkJICAgICAgb3V0LT5idWZm ZXIsIGNvbm4tPmlkKTsKKwkJCQlmcmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBj b25uKTsKKwkJCX0KKwkJfQorCQlpZiAoIWRlbHRhKSB7CisJCQljb25uLT50 aW1lb3V0X21zZWMgPSAwOworCQkJcmV0dXJuOworCQl9CisJfQorCisJaWYg KCpwdGltZW91dCA9PSAtMSB8fCAqcHRpbWVvdXQgPiBkZWx0YSkKKwkJKnB0 aW1lb3V0ID0gZGVsdGE7Cit9CisKIHZvaWQgY29ubl9mcmVlX2J1ZmZlcmVk X2RhdGEoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCiB7CiAJc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKm91dDsKIAogCXdoaWxlICgob3V0ID0gbGlzdF90b3Ao JmNvbm4tPm91dF9saXN0LCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSwgbGlzdCkp KQogCQlmcmVlX2J1ZmZlcmVkX2RhdGEob3V0LCBjb25uKTsKKworCWNvbm4t PnRpbWVvdXRfbXNlYyA9IDA7CiB9CiAKIHN0YXRpYyBib29sIHdyaXRlX21l c3NhZ2VzKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQpAQCAtNDA3LDYgKzQ4 Miw3IEBAIHN0YXRpYyB2b2lkIGluaXRpYWxpemVfZmRzKGludCAqcF9zb2Nr X3BvbGxmZF9pZHgsIGludCAqcHRpbWVvdXQpCiB7CiAJc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm47CiAJc3RydWN0IHdybF90aW1lc3RhbXB0IG5vdzsKKwl1 aW50NjRfdCBtc2VjczsKIAogCWlmIChmZHMpCiAJCW1lbXNldChmZHMsIDAs IHNpemVvZihzdHJ1Y3QgcG9sbGZkKSAqIGN1cnJlbnRfYXJyYXlfc2l6ZSk7 CkBAIC00MjcsMTAgKzUwMywxMiBAQCBzdGF0aWMgdm9pZCBpbml0aWFsaXpl X2ZkcyhpbnQgKnBfc29ja19wb2xsZmRfaWR4LCBpbnQgKnB0aW1lb3V0KQog CiAJd3JsX2dldHRpbWVfbm93KCZub3cpOwogCXdybF9sb2dfcGVyaW9kaWMo bm93KTsKKwltc2VjcyA9IGdldF9ub3dfbXNlYygpOwogCiAJbGlzdF9mb3Jf ZWFjaF9lbnRyeShjb25uLCAmY29ubmVjdGlvbnMsIGxpc3QpIHsKIAkJaWYg KGNvbm4tPmRvbWFpbikgewogCQkJd3JsX2NoZWNrX3RpbWVvdXQoY29ubi0+ ZG9tYWluLCBub3csIHB0aW1lb3V0KTsKKwkJCWNoZWNrX2V2ZW50X3RpbWVv dXQoY29ubiwgbXNlY3MsIHB0aW1lb3V0KTsKIAkJCWlmIChjb25uX2Nhbl9y ZWFkKGNvbm4pIHx8CiAJCQkgICAgKGNvbm5fY2FuX3dyaXRlKGNvbm4pICYm CiAJCQkgICAgICFsaXN0X2VtcHR5KCZjb25uLT5vdXRfbGlzdCkpKQpAQCAt NzkwLDYgKzg2OCw3IEBAIHZvaWQgc2VuZF9yZXBseShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgZW51bSB4c2Rfc29ja21zZ190eXBlIHR5cGUsCiAJCXJl dHVybjsKIAliZGF0YS0+aW5oZHIgPSB0cnVlOwogCWJkYXRhLT51c2VkID0g MDsKKwliZGF0YS0+dGltZW91dF9tc2VjID0gMDsKIAogCWlmIChsZW4gPD0g REVGQVVMVF9CVUZGRVJfU0laRSkKIAkJYmRhdGEtPmJ1ZmZlciA9IGJkYXRh LT5kZWZhdWx0X2J1ZmZlcjsKQEAgLTg0MSw2ICs5MjAsMTIgQEAgdm9pZCBz ZW5kX2V2ZW50KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFy ICpwYXRoLCBjb25zdCBjaGFyICp0b2tlbikKIAliZGF0YS0+aGRyLm1zZy50 eXBlID0gWFNfV0FUQ0hfRVZFTlQ7CiAJYmRhdGEtPmhkci5tc2cubGVuID0g bGVuOwogCisJaWYgKHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyAmJiBkb21h aW5faXNfdW5wcml2aWxlZ2VkKGNvbm4pKSB7CisJCWJkYXRhLT50aW1lb3V0 X21zZWMgPSBnZXRfbm93X21zZWMoKSArIHRpbWVvdXRfd2F0Y2hfZXZlbnRf bXNlYzsKKwkJaWYgKCFjb25uLT50aW1lb3V0X21zZWMpCisJCQljb25uLT50 aW1lb3V0X21zZWMgPSBiZGF0YS0+dGltZW91dF9tc2VjOworCX0KKwogCS8q IFF1ZXVlIGZvciBsYXRlciB0cmFuc21pc3Npb24uICovCiAJbGlzdF9hZGRf dGFpbCgmYmRhdGEtPmxpc3QsICZjb25uLT5vdXRfbGlzdCk7CiB9CkBAIC0y MTg1LDYgKzIyNzAsOSBAQCBzdGF0aWMgdm9pZCB1c2FnZSh2b2lkKQogIiAg LXQsIC0tdHJhbnNhY3Rpb24gPG5iPiAgbGltaXQgdGhlIG51bWJlciBvZiB0 cmFuc2FjdGlvbiBhbGxvd2VkIHBlciBkb21haW4sXG4iCiAiICAtQSwgLS1w ZXJtLW5iIDxuYj4gICAgICBsaW1pdCB0aGUgbnVtYmVyIG9mIHBlcm1pc3Np b25zIHBlciBub2RlLFxuIgogIiAgLU0sIC0tcGF0aC1tYXggPGNoYXJzPiAg bGltaXQgdGhlIGFsbG93ZWQgWGVuc3RvcmUgbm9kZSBwYXRoIGxlbmd0aCxc biIKKyIgIC13LCAtLXRpbWVvdXQgPHdoYXQ+PTxzZWNvbmRzPiAgIHNldCB0 aGUgdGltZW91dCBpbiBzZWNvbmRzIGZvciA8d2hhdD4sXG4iCisiICAgICAg ICAgICAgICAgICAgICAgICAgICBhbGxvd2VkIHRpbWVvdXQgY2FuZGlkYXRl cyBhcmU6XG4iCisiICAgICAgICAgICAgICAgICAgICAgICAgICB3YXRjaC1l dmVudDogdGltZSBhIHdhdGNoLWV2ZW50IGlzIGtlcHQgcGVuZGluZ1xuIgog IiAgLVIsIC0tbm8tcmVjb3ZlcnkgICAgICAgdG8gcmVxdWVzdCB0aGF0IG5v IHJlY292ZXJ5IHNob3VsZCBiZSBhdHRlbXB0ZWQgd2hlblxuIgogIiAgICAg ICAgICAgICAgICAgICAgICAgICAgdGhlIHN0b3JlIGlzIGNvcnJ1cHRlZCAo ZGVidWcgb25seSksXG4iCiAiICAtSSwgLS1pbnRlcm5hbC1kYiAgICAgICBz dG9yZSBkYXRhYmFzZSBpbiBtZW1vcnksIG5vdCBvbiBkaXNrXG4iCkBAIC0y MjA3LDYgKzIyOTUsNyBAQCBzdGF0aWMgc3RydWN0IG9wdGlvbiBvcHRpb25z W10gPSB7CiAJeyAidHJhbnNhY3Rpb24iLCAxLCBOVUxMLCAndCcgfSwKIAl7 ICJwZXJtLW5iIiwgMSwgTlVMTCwgJ0EnIH0sCiAJeyAicGF0aC1tYXgiLCAx LCBOVUxMLCAnTScgfSwKKwl7ICJ0aW1lb3V0IiwgMSwgTlVMTCwgJ3cnIH0s CiAJeyAibm8tcmVjb3ZlcnkiLCAwLCBOVUxMLCAnUicgfSwKIAl7ICJpbnRl cm5hbC1kYiIsIDAsIE5VTEwsICdJJyB9LAogCXsgInZlcmJvc2UiLCAwLCBO VUxMLCAnVicgfSwKQEAgLTIyMjAsNiArMjMwOSwzOSBAQCBpbnQgZG9tMF9k b21pZCA9IDA7CiBpbnQgZG9tMF9ldmVudCA9IDA7CiBpbnQgcHJpdl9kb21p ZCA9IDA7CiAKK3N0YXRpYyBpbnQgZ2V0X29wdHZhbF9pbnQoY29uc3QgY2hh ciAqYXJnKQoreworCWNoYXIgKmVuZDsKKwlsb25nIHZhbDsKKworCXZhbCA9 IHN0cnRvbChhcmcsICZlbmQsIDEwKTsKKwlpZiAoISphcmcgfHwgKmVuZCB8 fCB2YWwgPCAwIHx8IHZhbCA+IElOVF9NQVgpCisJCWJhcmYoImludmFsaWQg cGFyYW1ldGVyIHZhbHVlIFwiJXNcIlxuIiwgYXJnKTsKKworCXJldHVybiB2 YWw7Cit9CisKK3N0YXRpYyBib29sIHdoYXRfbWF0Y2hlcyhjb25zdCBjaGFy ICphcmcsIGNvbnN0IGNoYXIgKndoYXQpCit7CisJdW5zaWduZWQgaW50IHdo YXRfbGVuID0gc3RybGVuKHdoYXQpOworCisJcmV0dXJuICFzdHJuY21wKGFy Zywgd2hhdCwgd2hhdF9sZW4pICYmIGFyZ1t3aGF0X2xlbl0gPT0gJz0nOwor fQorCitzdGF0aWMgdm9pZCBzZXRfdGltZW91dChjb25zdCBjaGFyICphcmcp Cit7CisJY29uc3QgY2hhciAqZXEgPSBzdHJjaHIoYXJnLCAnPScpOworCWlu dCB2YWw7CisKKwlpZiAoIWVxKQorCQliYXJmKCJxdW90YXMgbXVzdCBiZSBz cGVjaWZpZWQgdmlhIDx3aGF0Pj08c2Vjb25kcz5cbiIpOworCXZhbCA9IGdl dF9vcHR2YWxfaW50KGVxICsgMSk7CisJaWYgKHdoYXRfbWF0Y2hlcyhhcmcs ICJ3YXRjaC1ldmVudCIpKQorCQl0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWMg PSB2YWwgKiAxMDAwOworCWVsc2UKKwkJYmFyZigidW5rbm93biB0aW1lb3V0 IFwiJXNcIlxuIiwgYXJnKTsKK30KKwogaW50IG1haW4oaW50IGFyZ2MsIGNo YXIgKmFyZ3ZbXSkKIHsKIAlpbnQgb3B0OwpAQCAtMjIzNCw3ICsyMzU2LDcg QEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAlvcmlnX2Fy Z2MgPSBhcmdjOwogCW9yaWdfYXJndiA9IGFyZ3Y7CiAKLQl3aGlsZSAoKG9w dCA9IGdldG9wdF9sb25nKGFyZ2MsIGFyZ3YsICJERTpGOkhOUFM6dDpBOk06 VDpSVlc6VSIsIG9wdGlvbnMsCisJd2hpbGUgKChvcHQgPSBnZXRvcHRfbG9u ZyhhcmdjLCBhcmd2LCAiREU6RjpITlBTOnQ6QTpNOlQ6UlZXOnc6VSIsIG9w dGlvbnMsCiAJCQkJICBOVUxMKSkgIT0gLTEpIHsKIAkJc3dpdGNoIChvcHQp IHsKIAkJY2FzZSAnRCc6CkBAIC0yMjg0LDYgKzI0MDYsOSBAQCBpbnQgbWFp bihpbnQgYXJnYywgY2hhciAqYXJndltdKQogCQkJcXVvdGFfbWF4X3BhdGhf bGVuID0gbWluKFhFTlNUT1JFX1JFTF9QQVRIX01BWCwKIAkJCQkJCSBxdW90 YV9tYXhfcGF0aF9sZW4pOwogCQkJYnJlYWs7CisJCWNhc2UgJ3cnOgorCQkJ c2V0X3RpbWVvdXQob3B0YXJnKTsKKwkJCWJyZWFrOwogCQljYXNlICdlJzoK IAkJCWRvbTBfZXZlbnQgPSBzdHJ0b2wob3B0YXJnLCBOVUxMLCAxMCk7CiAJ CQlicmVhazsKQEAgLTI3MTQsNiArMjgzOSwxMiBAQCBzdGF0aWMgdm9pZCBh ZGRfYnVmZmVyZWRfZGF0YShzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRhdGEs CiAJCWJhcmYoImVycm9yIHJlc3RvcmluZyBidWZmZXJlZCBkYXRhIik7CiAK IAltZW1jcHkoYmRhdGEtPmJ1ZmZlciwgZGF0YSwgbGVuKTsKKwlpZiAoYmRh dGEtPmhkci5tc2cudHlwZSA9PSBYU19XQVRDSF9FVkVOVCAmJiB0aW1lb3V0 X3dhdGNoX2V2ZW50X21zZWMgJiYKKwkgICAgZG9tYWluX2lzX3VucHJpdmls ZWdlZChjb25uKSkgeworCQliZGF0YS0+dGltZW91dF9tc2VjID0gZ2V0X25v d19tc2VjKCkgKyB0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWM7CisJCWlmICgh Y29ubi0+dGltZW91dF9tc2VjKQorCQkJY29ubi0+dGltZW91dF9tc2VjID0g YmRhdGEtPnRpbWVvdXRfbXNlYzsKKwl9CiAKIAkvKiBRdWV1ZSBmb3IgbGF0 ZXIgdHJhbnNtaXNzaW9uLiAqLwogCWxpc3RfYWRkX3RhaWwoJmJkYXRhLT5s aXN0LCAmY29ubi0+b3V0X2xpc3QpOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmgKaW5kZXggYzllYTc5NjE4NWU4Li43NDUyNjJhZjk2ZmQg MTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgK KysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMjcs NiArMjcsNyBAQAogI2luY2x1ZGUgPGZjbnRsLmg+CiAjaW5jbHVkZSA8c3Rk Ym9vbC5oPgogI2luY2x1ZGUgPHN0ZGludC5oPgorI2luY2x1ZGUgPHRpbWUu aD4KICNpbmNsdWRlIDxlcnJuby5oPgogCiAjaW5jbHVkZSAieGVuc3RvcmVf bGliLmgiCkBAIC02Nyw2ICs2OCw4IEBAIHN0cnVjdCBidWZmZXJlZF9kYXRh CiAJCWNoYXIgcmF3W3NpemVvZihzdHJ1Y3QgeHNkX3NvY2ttc2cpXTsKIAl9 IGhkcjsKIAorCXVpbnQ2NF90IHRpbWVvdXRfbXNlYzsKKwogCS8qIFRoZSBh Y3R1YWwgZGF0YS4gKi8KIAljaGFyICpidWZmZXI7CiAJY2hhciBkZWZhdWx0 X2J1ZmZlcltERUZBVUxUX0JVRkZFUl9TSVpFXTsKQEAgLTExOCw2ICsxMjEs NyBAQCBzdHJ1Y3QgY29ubmVjdGlvbgogCiAJLyogQnVmZmVyZWQgb3V0cHV0 IGRhdGEgKi8KIAlzdHJ1Y3QgbGlzdF9oZWFkIG91dF9saXN0OworCXVpbnQ2 NF90IHRpbWVvdXRfbXNlYzsKIAogCS8qIFRyYW5zYWN0aW9uIGNvbnRleHQg Zm9yIGN1cnJlbnQgcmVxdWVzdCAoTlVMTCBpZiBub25lKS4gKi8KIAlzdHJ1 Y3QgdHJhbnNhY3Rpb24gKnRyYW5zYWN0aW9uOwpAQCAtMjQyLDYgKzI0Niw4 IEBAIGV4dGVybiBpbnQgZG9tMF9ldmVudDsKIGV4dGVybiBpbnQgcHJpdl9k b21pZDsKIGV4dGVybiBpbnQgcXVvdGFfbmJfZW50cnlfcGVyX2RvbWFpbjsK IAorZXh0ZXJuIHVuc2lnbmVkIGludCB0aW1lb3V0X3dhdGNoX2V2ZW50X21z ZWM7CisKIC8qIE1hcCB0aGUga2VybmVsJ3MgeGVuc3RvcmUgcGFnZS4gKi8K IHZvaWQgKnhlbmJ1c19tYXAodm9pZCk7CiB2b2lkIHVubWFwX3hlbmJ1cyh2 b2lkICppbnRlcmZhY2UpOwo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-05.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-05.patch" Content-Transfer-Encoding: base64 RnJvbSA4MjczZDUwMTkyMzRjYmEzMDhkN2ZjOTY0NzAwNjk1NDQ5NDlmNjBk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxpbWl0IG91 dHN0YW5kaW5nIHJlcXVlc3RzCgpBZGQgYW5vdGhlciBxdW90YSBmb3IgbGlt aXRpbmcgdGhlIG51bWJlciBvZiBvdXRzdGFuZGluZyByZXF1ZXN0cyBvZiBh Cmd1ZXN0LiBBcyB0aGUgd2F5IHRvIHNwZWNpZnkgcXVvdGFzIG9uIHRoZSBj b21tYW5kIGxpbmUgaXMgYmVjb21pbmcKcmF0aGVyIG5hc3R5LCBzd2l0Y2gg dG8gYSBuZXcgc2NoZW1lIHVzaW5nIFstLXF1b3RhfC1RXSA8d2hhdD49PHZh bD4KYWxsb3dpbmcgdG8gYWRkIG1vcmUgcXVvdGFzIGluIGZ1dHVyZSBlYXNp bHkuCgpTZXQgdGhlIGRlZmF1bHQgdmFsdWUgdG8gMjAgKGJhc2ljYWxseSBh IHJhbmRvbSB2YWx1ZSBub3Qgc2VlbWluZyB0bwpiZSB0b28gaGlnaCBvciB0 b28gbG93KS4KCkEgcmVxdWVzdCBpcyBzYWlkIHRvIGJlIG91dHN0YW5kaW5n IGlmIGFueSBtZXNzYWdlIGdlbmVyYXRlZCBieSB0aGlzCnJlcXVlc3QgKHRo ZSBkaXJlY3QgcmVzcG9uc2UgcGx1cyBwb3RlbnRpYWwgd2F0Y2ggZXZlbnRz KSBpcyBub3QgeWV0CmNvbXBsZXRlbHkgc3RvcmVkIGludG8gYSByaW5nIGJ1 ZmZlci4gVGhlIGluaXRpYWwgd2F0Y2ggZXZlbnQgc2VudCBhcwphIHJlc3Vs dCBvZiByZWdpc3RlcmluZyBhIHdhdGNoIGlzIGFuIGV4Y2VwdGlvbi4KCk5v dGUgdGhhdCBhY3Jvc3MgYSBsaXZlIHVwZGF0ZSB0aGUgcmVsYXRpb24gdG8g YnVmZmVyZWQgd2F0Y2ggZXZlbnRzCmZvciBvdGhlciBkb21haW5zIGlzIGxv c3QuCgpVc2UgdGFsbG9jX3plcm8oKSBmb3IgYWxsb2NhdGluZyB0aGUgZG9t YWluIHN0cnVjdHVyZSBpbiBvcmRlciB0byBoYXZlCmFsbCBwZXItZG9tYWlu IHF1b3RhIHplcm9lZCBpbml0aWFsbHkuCgpUaGlzIGlzIHBhcnQgb2YgWFNB LTMyNiAvIENWRS0yMDIyLTQyMzEyLgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKaW5kZXggY2NlMDJmMjRiNTFjLi41NGU2YWRkMWEx NTcgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAt MTA3LDYgKzEwNyw3IEBAIGludCBxdW90YV9tYXhfZW50cnlfc2l6ZSA9IDIw NDg7IC8qIDJLICovCiBpbnQgcXVvdGFfbWF4X3RyYW5zYWN0aW9uID0gMTA7 CiBpbnQgcXVvdGFfbmJfcGVybXNfcGVyX25vZGUgPSA1OwogaW50IHF1b3Rh X21heF9wYXRoX2xlbiA9IFhFTlNUT1JFX1JFTF9QQVRIX01BWDsKK2ludCBx dW90YV9yZXFfb3V0c3RhbmRpbmcgPSAyMDsKIAogdW5zaWduZWQgaW50IHRp bWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyA9IDIwMDAwOwogCkBAIC0yMTksMTIg KzIyMCwyNCBAQCBzdGF0aWMgdWludDY0X3QgZ2V0X25vd19tc2VjKHZvaWQp CiAJcmV0dXJuIG5vd190cy50dl9zZWMgKiAxMDAwICsgbm93X3RzLnR2X25z ZWMgLyAxMDAwMDAwOwogfQogCisvKgorICogUmVtb3ZlIGEgc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgZnJvbSB0aGUgbGlzdCBvZiBvdXRnb2luZyBkYXRhLgor ICogQSBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSByZWxhdGVkIHRvIGEgcmVxdWVz dCBoYXZpbmcgY2F1c2VkIHdhdGNoIGV2ZW50cyB0byBiZQorICogc2VudCBp cyBrZXB0IHVudGlsIGFsbCB0aG9zZSBldmVudHMgaGF2ZSBiZWVuIHdyaXR0 ZW4gb3V0LgorICogRWFjaCB3YXRjaCBldmVudCBpcyByZWZlcmVuY2luZyB0 aGUgcmVsYXRlZCByZXF1ZXN0IHZpYSBwZW5kLnJlcSwgd2hpbGUgdGhlCisg KiBudW1iZXIgb2Ygd2F0Y2ggZXZlbnRzIGNhdXNlZCBieSBhIHJlcXVlc3Qg aXMga2VwdCBpbiBwZW5kLnJlZi5ldmVudF9jbnQKKyAqICh0aG9zZSB0d28g Y2FzZXMgYXJlIG11dHVhbGx5IGV4Y2x1c2l2ZSwgc28gdGhlIHR3byBmaWVs ZHMgY2FuIHNoYXJlIG1lbW9yeQorICogdmlhIGEgdW5pb24pLgorICogVGhl IHN0cnVjdCBidWZmZXJlZF9kYXRhIGlzIGZyZWVkIG9ubHkgaWYgbm8gcmVs YXRlZCB3YXRjaCBldmVudCBpcworICogcmVmZXJlbmNpbmcgaXQuIFRoZSBy ZWxhdGVkIHJldHVybiBkYXRhIGNhbiBiZSBmcmVlZCByaWdodCBhd2F5Lgor ICovCiBzdGF0aWMgdm9pZCBmcmVlX2J1ZmZlcmVkX2RhdGEoc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKm91dCwKIAkJCSAgICAgICBzdHJ1Y3QgY29ubmVjdGlv biAqY29ubikKIHsKIAlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqcmVxOwogCiAJ bGlzdF9kZWwoJm91dC0+bGlzdCk7CisJb3V0LT5vbl9vdXRfbGlzdCA9IGZh bHNlOwogCiAJLyoKIAkgKiBVcGRhdGUgY29ubi0+dGltZW91dF9tc2VjIHdp dGggdGhlIG5leHQgZm91bmQgdGltZW91dCB2YWx1ZSBpbiB0aGUKQEAgLTI0 MCw2ICsyNTMsMzAgQEAgc3RhdGljIHZvaWQgZnJlZV9idWZmZXJlZF9kYXRh KHN0cnVjdCBidWZmZXJlZF9kYXRhICpvdXQsCiAJCX0KIAl9CiAKKwlpZiAo b3V0LT5oZHIubXNnLnR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQpIHsKKwkJcmVx ID0gb3V0LT5wZW5kLnJlcTsKKwkJaWYgKHJlcSkgeworCQkJcmVxLT5wZW5k LnJlZi5ldmVudF9jbnQtLTsKKwkJCWlmICghcmVxLT5wZW5kLnJlZi5ldmVu dF9jbnQgJiYgIXJlcS0+b25fb3V0X2xpc3QpIHsKKwkJCQlpZiAocmVxLT5v bl9yZWZfbGlzdCkgeworCQkJCQlkb21haW5fb3V0c3RhbmRpbmdfZG9taWRf ZGVjKAorCQkJCQkJcmVxLT5wZW5kLnJlZi5kb21pZCk7CisJCQkJCWxpc3Rf ZGVsKCZyZXEtPmxpc3QpOworCQkJCX0KKwkJCQl0YWxsb2NfZnJlZShyZXEp OworCQkJfQorCQl9CisJfSBlbHNlIGlmIChvdXQtPnBlbmQucmVmLmV2ZW50 X2NudCkgeworCQkvKiBIYW5nIG91dCBvZmYgZnJvbSBjb25uLiAqLworCQl0 YWxsb2Nfc3RlYWwoTlVMTCwgb3V0KTsKKwkJaWYgKG91dC0+YnVmZmVyICE9 IG91dC0+ZGVmYXVsdF9idWZmZXIpCisJCQl0YWxsb2NfZnJlZShvdXQtPmJ1 ZmZlcik7CisJCWxpc3RfYWRkKCZvdXQtPmxpc3QsICZjb25uLT5yZWZfbGlz dCk7CisJCW91dC0+b25fcmVmX2xpc3QgPSB0cnVlOworCQlyZXR1cm47CisJ fSBlbHNlCisJCWRvbWFpbl9vdXRzdGFuZGluZ19kZWMoY29ubik7CisKIAl0 YWxsb2NfZnJlZShvdXQpOwogfQogCkBAIC00MDEsNiArNDM4LDcgQEAgaW50 IGRlbGF5X3JlcXVlc3Qoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbiwKIHN0YXRpYyBpbnQgZGVzdHJveV9jb25u KHZvaWQgKl9jb25uKQogewogCXN0cnVjdCBjb25uZWN0aW9uICpjb25uID0g X2Nvbm47CisJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKnJlcTsKIAogCS8qIEZs dXNoIG91dGdvaW5nIGlmIHBvc3NpYmxlLCBidXQgZG9uJ3QgYmxvY2suICov CiAJaWYgKCFjb25uLT5kb21haW4pIHsKQEAgLTQxNCw2ICs0NTIsMTEgQEAg c3RhdGljIGludCBkZXN0cm95X2Nvbm4odm9pZCAqX2Nvbm4pCiAJCQkJYnJl YWs7CiAJCWNsb3NlKGNvbm4tPmZkKTsKIAl9CisKKwljb25uX2ZyZWVfYnVm ZmVyZWRfZGF0YShjb25uKTsKKwlsaXN0X2Zvcl9lYWNoX2VudHJ5KHJlcSwg JmNvbm4tPnJlZl9saXN0LCBsaXN0KQorCQlyZXEtPm9uX3JlZl9saXN0ID0g ZmFsc2U7CisKICAgICAgICAgaWYgKGNvbm4tPnRhcmdldCkKICAgICAgICAg ICAgICAgICB0YWxsb2NfdW5saW5rKGNvbm4sIGNvbm4tPnRhcmdldCk7CiAJ bGlzdF9kZWwoJmNvbm4tPmxpc3QpOwpAQCAtODg5LDYgKzkzMiw4IEBAIHZv aWQgc2VuZF9yZXBseShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgZW51bSB4 c2Rfc29ja21zZ190eXBlIHR5cGUsCiAKIAkvKiBRdWV1ZSBmb3IgbGF0ZXIg dHJhbnNtaXNzaW9uLiAqLwogCWxpc3RfYWRkX3RhaWwoJmJkYXRhLT5saXN0 LCAmY29ubi0+b3V0X2xpc3QpOworCWJkYXRhLT5vbl9vdXRfbGlzdCA9IHRy dWU7CisJZG9tYWluX291dHN0YW5kaW5nX2luYyhjb25uKTsKIH0KIAogLyoK QEAgLTg5Niw3ICs5NDEsOCBAQCB2b2lkIHNlbmRfcmVwbHkoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlLAog ICogQXMgdGhpcyBpcyBub3QgZGlyZWN0bHkgcmVsYXRlZCB0byB0aGUgY3Vy cmVudCBjb21tYW5kLCBlcnJvcnMgY2FuJ3QgYmUKICAqIHJlcG9ydGVkLgog ICovCi12b2lkIHNlbmRfZXZlbnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IGNvbnN0IGNoYXIgKnBhdGgsIGNvbnN0IGNoYXIgKnRva2VuKQordm9pZCBz ZW5kX2V2ZW50KHN0cnVjdCBidWZmZXJlZF9kYXRhICpyZXEsIHN0cnVjdCBj b25uZWN0aW9uICpjb25uLAorCQljb25zdCBjaGFyICpwYXRoLCBjb25zdCBj aGFyICp0b2tlbikKIHsKIAlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRhdGE7 CiAJdW5zaWduZWQgaW50IGxlbjsKQEAgLTkyNiw4ICs5NzIsMTMgQEAgdm9p ZCBzZW5kX2V2ZW50KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBj aGFyICpwYXRoLCBjb25zdCBjaGFyICp0b2tlbikKIAkJCWNvbm4tPnRpbWVv dXRfbXNlYyA9IGJkYXRhLT50aW1lb3V0X21zZWM7CiAJfQogCisJYmRhdGEt PnBlbmQucmVxID0gcmVxOworCWlmIChyZXEpCisJCXJlcS0+cGVuZC5yZWYu ZXZlbnRfY250Kys7CisKIAkvKiBRdWV1ZSBmb3IgbGF0ZXIgdHJhbnNtaXNz aW9uLiAqLwogCWxpc3RfYWRkX3RhaWwoJmJkYXRhLT5saXN0LCAmY29ubi0+ b3V0X2xpc3QpOworCWJkYXRhLT5vbl9vdXRfbGlzdCA9IHRydWU7CiB9CiAK IC8qIFNvbWUgcm91dGluZXMgKHdyaXRlLCBta2RpciwgZXRjKSBqdXN0IG5l ZWQgYSBub24tZXJyb3IgcmV0dXJuICovCkBAIC0xNzE0LDYgKzE3NjUsNyBA QCBzdGF0aWMgdm9pZCBoYW5kbGVfaW5wdXQoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pCiAJCQlyZXR1cm47CiAJfQogCWluID0gY29ubi0+aW47CisJaW4t PnBlbmQucmVmLmRvbWlkID0gY29ubi0+aWQ7CiAKIAkvKiBOb3QgZmluaXNo ZWQgaGVhZGVyIHlldD8gKi8KIAlpZiAoaW4tPmluaGRyKSB7CkBAIC0xNzg3 LDYgKzE4MzksNyBAQCBzdHJ1Y3QgY29ubmVjdGlvbiAqbmV3X2Nvbm5lY3Rp b24oY29uc3Qgc3RydWN0IGludGVyZmFjZV9mdW5jcyAqZnVuY3MpCiAJbmV3 LT5pc19zdGFsbGVkID0gZmFsc2U7CiAJbmV3LT50cmFuc2FjdGlvbl9zdGFy dGVkID0gMDsKIAlJTklUX0xJU1RfSEVBRCgmbmV3LT5vdXRfbGlzdCk7CisJ SU5JVF9MSVNUX0hFQUQoJm5ldy0+cmVmX2xpc3QpOwogCUlOSVRfTElTVF9I RUFEKCZuZXctPndhdGNoZXMpOwogCUlOSVRfTElTVF9IRUFEKCZuZXctPnRy YW5zYWN0aW9uX2xpc3QpOwogCUlOSVRfTElTVF9IRUFEKCZuZXctPmRlbGF5 ZWQpOwpAQCAtMjI3MCw2ICsyMzIzLDkgQEAgc3RhdGljIHZvaWQgdXNhZ2Uo dm9pZCkKICIgIC10LCAtLXRyYW5zYWN0aW9uIDxuYj4gIGxpbWl0IHRoZSBu dW1iZXIgb2YgdHJhbnNhY3Rpb24gYWxsb3dlZCBwZXIgZG9tYWluLFxuIgog IiAgLUEsIC0tcGVybS1uYiA8bmI+ICAgICAgbGltaXQgdGhlIG51bWJlciBv ZiBwZXJtaXNzaW9ucyBwZXIgbm9kZSxcbiIKICIgIC1NLCAtLXBhdGgtbWF4 IDxjaGFycz4gIGxpbWl0IHRoZSBhbGxvd2VkIFhlbnN0b3JlIG5vZGUgcGF0 aCBsZW5ndGgsXG4iCisiICAtUSwgLS1xdW90YSA8d2hhdD49PG5iPiBzZXQg dGhlIHF1b3RhIDx3aGF0PiB0byB0aGUgdmFsdWUgPG5iPiwgYWxsb3dlZFxu IgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgcXVvdGFzIGFyZTpcbiIK KyIgICAgICAgICAgICAgICAgICAgICAgICAgIG91dHN0YW5kaW5nOiBudW1i ZXIgb2Ygb3V0c3RhbmRpbmcgcmVxdWVzdHNcbiIKICIgIC13LCAtLXRpbWVv dXQgPHdoYXQ+PTxzZWNvbmRzPiAgIHNldCB0aGUgdGltZW91dCBpbiBzZWNv bmRzIGZvciA8d2hhdD4sXG4iCiAiICAgICAgICAgICAgICAgICAgICAgICAg ICBhbGxvd2VkIHRpbWVvdXQgY2FuZGlkYXRlcyBhcmU6XG4iCiAiICAgICAg ICAgICAgICAgICAgICAgICAgICB3YXRjaC1ldmVudDogdGltZSBhIHdhdGNo LWV2ZW50IGlzIGtlcHQgcGVuZGluZ1xuIgpAQCAtMjI5NSw2ICsyMzUxLDcg QEAgc3RhdGljIHN0cnVjdCBvcHRpb24gb3B0aW9uc1tdID0gewogCXsgInRy YW5zYWN0aW9uIiwgMSwgTlVMTCwgJ3QnIH0sCiAJeyAicGVybS1uYiIsIDEs IE5VTEwsICdBJyB9LAogCXsgInBhdGgtbWF4IiwgMSwgTlVMTCwgJ00nIH0s CisJeyAicXVvdGEiLCAxLCBOVUxMLCAnUScgfSwKIAl7ICJ0aW1lb3V0Iiwg MSwgTlVMTCwgJ3cnIH0sCiAJeyAibm8tcmVjb3ZlcnkiLCAwLCBOVUxMLCAn UicgfSwKIAl7ICJpbnRlcm5hbC1kYiIsIDAsIE5VTEwsICdJJyB9LApAQCAt MjM0Miw2ICsyMzk5LDIwIEBAIHN0YXRpYyB2b2lkIHNldF90aW1lb3V0KGNv bnN0IGNoYXIgKmFyZykKIAkJYmFyZigidW5rbm93biB0aW1lb3V0IFwiJXNc IlxuIiwgYXJnKTsKIH0KIAorc3RhdGljIHZvaWQgc2V0X3F1b3RhKGNvbnN0 IGNoYXIgKmFyZykKK3sKKwljb25zdCBjaGFyICplcSA9IHN0cmNocihhcmcs ICc9Jyk7CisJaW50IHZhbDsKKworCWlmICghZXEpCisJCWJhcmYoInF1b3Rh cyBtdXN0IGJlIHNwZWNpZmllZCB2aWEgPHdoYXQ+PTxuYj5cbiIpOworCXZh bCA9IGdldF9vcHR2YWxfaW50KGVxICsgMSk7CisJaWYgKHdoYXRfbWF0Y2hl cyhhcmcsICJvdXRzdGFuZGluZyIpKQorCQlxdW90YV9yZXFfb3V0c3RhbmRp bmcgPSB2YWw7CisJZWxzZQorCQliYXJmKCJ1bmtub3duIHF1b3RhIFwiJXNc IlxuIiwgYXJnKTsKK30KKwogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFy Z3ZbXSkKIHsKIAlpbnQgb3B0OwpAQCAtMjM1Niw4ICsyNDI3LDggQEAgaW50 IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAlvcmlnX2FyZ2MgPSBh cmdjOwogCW9yaWdfYXJndiA9IGFyZ3Y7CiAKLQl3aGlsZSAoKG9wdCA9IGdl dG9wdF9sb25nKGFyZ2MsIGFyZ3YsICJERTpGOkhOUFM6dDpBOk06VDpSVlc6 dzpVIiwgb3B0aW9ucywKLQkJCQkgIE5VTEwpKSAhPSAtMSkgeworCXdoaWxl ICgob3B0ID0gZ2V0b3B0X2xvbmcoYXJnYywgYXJndiwgIkRFOkY6SE5QUzp0 OkE6TTpROlQ6UlZXOnc6VSIsCisJCQkJICBvcHRpb25zLCBOVUxMKSkgIT0g LTEpIHsKIAkJc3dpdGNoIChvcHQpIHsKIAkJY2FzZSAnRCc6CiAJCQlub19k b21haW5faW5pdCA9IHRydWU7CkBAIC0yNDA2LDYgKzI0NzcsOSBAQCBpbnQg bWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQogCQkJcXVvdGFfbWF4X3Bh dGhfbGVuID0gbWluKFhFTlNUT1JFX1JFTF9QQVRIX01BWCwKIAkJCQkJCSBx dW90YV9tYXhfcGF0aF9sZW4pOwogCQkJYnJlYWs7CisJCWNhc2UgJ1EnOgor CQkJc2V0X3F1b3RhKG9wdGFyZyk7CisJCQlicmVhazsKIAkJY2FzZSAndyc6 CiAJCQlzZXRfdGltZW91dChvcHRhcmcpOwogCQkJYnJlYWs7CkBAIC0yODQ4 LDYgKzI5MjIsMTQgQEAgc3RhdGljIHZvaWQgYWRkX2J1ZmZlcmVkX2RhdGEo c3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmJkYXRhLAogCiAJLyogUXVldWUgZm9y IGxhdGVyIHRyYW5zbWlzc2lvbi4gKi8KIAlsaXN0X2FkZF90YWlsKCZiZGF0 YS0+bGlzdCwgJmNvbm4tPm91dF9saXN0KTsKKwliZGF0YS0+b25fb3V0X2xp c3QgPSB0cnVlOworCS8qCisJICogV2F0Y2ggZXZlbnRzIGFyZSBuZXZlciAi b3V0c3RhbmRpbmciLCBidXQgdGhlIHJlcXVlc3QgY2F1c2luZyB0aGVtCisJ ICogYXJlIGluc3RlYWQga2VwdCAib3V0c3RhbmRpbmciIHVudGlsIGFsbCB3 YXRjaCBldmVudHMgY2F1c2VkIGJ5IHRoYXQKKwkgKiByZXF1ZXN0IGhhdmUg YmVlbiBkZWxpdmVyZWQuCisJICovCisJaWYgKGJkYXRhLT5oZHIubXNnLnR5 cGUgIT0gWFNfV0FUQ0hfRVZFTlQpCisJCWRvbWFpbl9vdXRzdGFuZGluZ19p bmMoY29ubik7CiB9CiAKIHZvaWQgcmVhZF9zdGF0ZV9idWZmZXJlZF9kYXRh KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCmRp ZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCA3NDUyNjJh Zjk2ZmQuLmFjYjZiOWZlMmFjMyAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfY29yZS5oCkBAIC01Niw2ICs1Niw4IEBAIHN0cnVjdCB4c19zdGF0 ZV9jb25uZWN0aW9uOwogc3RydWN0IGJ1ZmZlcmVkX2RhdGEKIHsKIAlzdHJ1 Y3QgbGlzdF9oZWFkIGxpc3Q7CisJYm9vbCBvbl9vdXRfbGlzdDsKKwlib29s IG9uX3JlZl9saXN0OwogCiAJLyogQXJlIHdlIHN0aWxsIGRvaW5nIHRoZSBo ZWFkZXI/ICovCiAJYm9vbCBpbmhkcjsKQEAgLTYzLDYgKzY1LDE3IEBAIHN0 cnVjdCBidWZmZXJlZF9kYXRhCiAJLyogSG93IGZhciBhcmUgd2U/ICovCiAJ dW5zaWduZWQgaW50IHVzZWQ7CiAKKwkvKiBPdXRzdGFuZGluZyByZXF1ZXN0 IGFjY291bnRpbmcuICovCisJdW5pb24geworCQkvKiByZWYgaXMgYmVpbmcg dXNlZCBmb3IgcmVxdWVzdHMuICovCisJCXN0cnVjdCB7CisJCQl1bnNpZ25l ZCBpbnQgZXZlbnRfY250OyAvKiAjIG9mIG91dHN0YW5kaW5nIGV2ZW50cy4g Ki8KKwkJCXVuc2lnbmVkIGludCBkb21pZDsgICAgIC8qIGRvbWlkIG9mIHJl cXVlc3QuICovCisJCX0gcmVmOworCQkvKiByZXEgaXMgYmVpbmcgdXNlZCBm b3Igd2F0Y2ggZXZlbnRzLiAqLworCQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAq cmVxOyAgICAgIC8qIHJlcXVlc3QgY2F1c2luZyBldmVudC4gKi8KKwl9IHBl bmQ7CisKIAl1bmlvbiB7CiAJCXN0cnVjdCB4c2Rfc29ja21zZyBtc2c7CiAJ CWNoYXIgcmF3W3NpemVvZihzdHJ1Y3QgeHNkX3NvY2ttc2cpXTsKQEAgLTEy Myw2ICsxMzYsOSBAQCBzdHJ1Y3QgY29ubmVjdGlvbgogCXN0cnVjdCBsaXN0 X2hlYWQgb3V0X2xpc3Q7CiAJdWludDY0X3QgdGltZW91dF9tc2VjOwogCisJ LyogUmVmZXJlbmNlZCByZXF1ZXN0cyBubyBsb25nZXIgcGVuZGluZy4gKi8K KwlzdHJ1Y3QgbGlzdF9oZWFkIHJlZl9saXN0OworCiAJLyogVHJhbnNhY3Rp b24gY29udGV4dCBmb3IgY3VycmVudCByZXF1ZXN0IChOVUxMIGlmIG5vbmUp LiAqLwogCXN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnNhY3Rpb247CiAKQEAg LTE5MSw3ICsyMDcsOCBAQCB1bnNpZ25lZCBpbnQgZ2V0X3N0cmluZyhjb25z dCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqZGF0YSwgdW5zaWduZWQgaW50IG9m ZnNldCk7CiAKIHZvaWQgc2VuZF9yZXBseShzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgZW51bSB4c2Rfc29ja21zZ190eXBlIHR5cGUsCiAJCWNvbnN0IHZv aWQgKmRhdGEsIHVuc2lnbmVkIGludCBsZW4pOwotdm9pZCBzZW5kX2V2ZW50 KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpwYXRoLCBj b25zdCBjaGFyICp0b2tlbik7Cit2b2lkIHNlbmRfZXZlbnQoc3RydWN0IGJ1 ZmZlcmVkX2RhdGEgKnJlcSwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJ CWNvbnN0IGNoYXIgKnBhdGgsIGNvbnN0IGNoYXIgKnRva2VuKTsKIAogLyog U29tZSByb3V0aW5lcyAod3JpdGUsIG1rZGlyLCBldGMpIGp1c3QgbmVlZCBh IG5vbi1lcnJvciByZXR1cm4gKi8KIHZvaWQgc2VuZF9hY2soc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlKTsK QEAgLTI0NSw2ICsyNjIsNyBAQCBleHRlcm4gaW50IGRvbTBfZG9taWQ7CiBl eHRlcm4gaW50IGRvbTBfZXZlbnQ7CiBleHRlcm4gaW50IHByaXZfZG9taWQ7 CiBleHRlcm4gaW50IHF1b3RhX25iX2VudHJ5X3Blcl9kb21haW47CitleHRl cm4gaW50IHF1b3RhX3JlcV9vdXRzdGFuZGluZzsKIAogZXh0ZXJuIHVuc2ln bmVkIGludCB0aW1lb3V0X3dhdGNoX2V2ZW50X21zZWM7CiAKZGlmZiAtLWdp dCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYyBiL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYwppbmRleCBkZTM0OWUyYTc3 YTUuLmMwYTM3NzEyZjg5YiAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2RvbWFpbi5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9kb21haW4uYwpAQCAtNzgsNiArNzgsOSBAQCBzdHJ1Y3QgZG9tYWlu CiAJLyogbnVtYmVyIG9mIHdhdGNoIGZvciB0aGlzIGRvbWFpbiAqLwogCWlu dCBuYndhdGNoOwogCisJLyogTnVtYmVyIG9mIG91dHN0YW5kaW5nIHJlcXVl c3RzLiAqLworCWludCBuYm91dHN0YW5kaW5nOworCiAJLyogd3JpdGUgcmF0 ZSBsaW1pdCAqLwogCXdybF9jcmVkaXR0IHdybF9jcmVkaXQ7IC8qIFsgLXdy bF9jb25maWdfd3JpdGVjb3N0LCArX2RidXJzdCBdICovCiAJc3RydWN0IHdy bF90aW1lc3RhbXB0IHdybF90aW1lc3RhbXA7CkBAIC0xODMsOCArMTg2LDEy IEBAIHN0YXRpYyBib29sIGRvbWFpbl9jYW5fcmVhZChzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubikKIHsKIAlzdHJ1Y3QgeGVuc3RvcmVfZG9tYWluX2ludGVy ZmFjZSAqaW50ZiA9IGNvbm4tPmRvbWFpbi0+aW50ZXJmYWNlOwogCi0JaWYg KGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikgJiYgY29ubi0+ZG9tYWlu LT53cmxfY3JlZGl0IDwgMCkKLQkJcmV0dXJuIGZhbHNlOworCWlmIChkb21h aW5faXNfdW5wcml2aWxlZ2VkKGNvbm4pKSB7CisJCWlmIChjb25uLT5kb21h aW4tPndybF9jcmVkaXQgPCAwKQorCQkJcmV0dXJuIGZhbHNlOworCQlpZiAo Y29ubi0+ZG9tYWluLT5uYm91dHN0YW5kaW5nID49IHF1b3RhX3JlcV9vdXRz dGFuZGluZykKKwkJCXJldHVybiBmYWxzZTsKKwl9CiAKIAlyZXR1cm4gKGlu dGYtPnJlcV9jb25zICE9IGludGYtPnJlcV9wcm9kKTsKIH0KQEAgLTMzMSw3 ICszMzgsNyBAQCBzdGF0aWMgc3RydWN0IGRvbWFpbiAqYWxsb2NfZG9tYWlu KGNvbnN0IHZvaWQgKmNvbnRleHQsIHVuc2lnbmVkIGludCBkb21pZCkKIHsK IAlzdHJ1Y3QgZG9tYWluICpkb21haW47CiAKLQlkb21haW4gPSB0YWxsb2Mo Y29udGV4dCwgc3RydWN0IGRvbWFpbik7CisJZG9tYWluID0gdGFsbG9jX3pl cm8oY29udGV4dCwgc3RydWN0IGRvbWFpbik7CiAJaWYgKCFkb21haW4pIHsK IAkJZXJybm8gPSBFTk9NRU07CiAJCXJldHVybiBOVUxMOwpAQCAtMzkyLDkg KzM5OSw2IEBAIHN0YXRpYyBpbnQgbmV3X2RvbWFpbihzdHJ1Y3QgZG9tYWlu ICpkb21haW4sIGludCBwb3J0LCBib29sIHJlc3RvcmUpCiAJZG9tYWluLT5j b25uLT5kb21haW4gPSBkb21haW47CiAJZG9tYWluLT5jb25uLT5pZCA9IGRv bWFpbi0+ZG9taWQ7CiAKLQlkb21haW4tPm5iZW50cnkgPSAwOwotCWRvbWFp bi0+bmJ3YXRjaCA9IDA7Ci0KIAlyZXR1cm4gMDsKIH0KIApAQCAtOTcwLDYg Kzk3NCwyOCBAQCBpbnQgZG9tYWluX3dhdGNoKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uKQogCQk6IDA7CiB9CiAKK3ZvaWQgZG9tYWluX291dHN0YW5kaW5n X2luYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubikKK3sKKwlpZiAoIWNvbm4g fHwgIWNvbm4tPmRvbWFpbikKKwkJcmV0dXJuOworCWNvbm4tPmRvbWFpbi0+ bmJvdXRzdGFuZGluZysrOworfQorCit2b2lkIGRvbWFpbl9vdXRzdGFuZGlu Z19kZWMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCit7CisJaWYgKCFjb25u IHx8ICFjb25uLT5kb21haW4pCisJCXJldHVybjsKKwljb25uLT5kb21haW4t Pm5ib3V0c3RhbmRpbmctLTsKK30KKwordm9pZCBkb21haW5fb3V0c3RhbmRp bmdfZG9taWRfZGVjKHVuc2lnbmVkIGludCBkb21pZCkKK3sKKwlzdHJ1Y3Qg ZG9tYWluICpkID0gZmluZF9kb21haW5fYnlfZG9taWQoZG9taWQpOworCisJ aWYgKGQpCisJCWQtPm5ib3V0c3RhbmRpbmctLTsKK30KKwogc3RhdGljIHdy bF9jcmVkaXR0IHdybF9jb25maWdfd3JpdGVjb3N0ICAgICAgPSBXUkxfRkFD VE9SOwogc3RhdGljIHdybF9jcmVkaXR0IHdybF9jb25maWdfcmF0ZSAgICAg ICAgICAgPSBXUkxfUkFURSAgICogV1JMX0ZBQ1RPUjsKIHN0YXRpYyB3cmxf Y3JlZGl0dCB3cmxfY29uZmlnX2RidXJzdCAgICAgICAgID0gV1JMX0RCVVJT VCAqIFdSTF9GQUNUT1I7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfZG9tYWluLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmgKaW5kZXggNGEzN2RlNjdhMDllLi42MTdkMGFjZmQ3NWIgMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaAor KysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgKQEAgLTY1 LDYgKzY1LDkgQEAgaW50IGRvbWFpbl9lbnRyeShzdHJ1Y3QgY29ubmVjdGlv biAqY29ubik7CiB2b2lkIGRvbWFpbl93YXRjaF9pbmMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4pOwogdm9pZCBkb21haW5fd2F0Y2hfZGVjKHN0cnVjdCBj b25uZWN0aW9uICpjb25uKTsKIGludCBkb21haW5fd2F0Y2goc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4pOwordm9pZCBkb21haW5fb3V0c3RhbmRpbmdfaW5j KHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsKK3ZvaWQgZG9tYWluX291dHN0 YW5kaW5nX2RlYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7Cit2b2lkIGRv bWFpbl9vdXRzdGFuZGluZ19kb21pZF9kZWModW5zaWduZWQgaW50IGRvbWlk KTsKIAogLyogU3BlY2lhbCBub2RlIHBlcm1pc3Npb24gaGFuZGxpbmcuICov CiBpbnQgc2V0X3Blcm1zX3NwZWNpYWwoc3RydWN0IGNvbm5lY3Rpb24gKmNv bm4sIGNvbnN0IGNoYXIgKm5hbWUsCmRpZmYgLS1naXQgYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfd2F0Y2guYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF93YXRjaC5jCmluZGV4IDIwNWQ5ZDhlYTExNi4uMDc1NWZmYTM3NWJh IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2gu YworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYwpAQCAt MTQyLDYgKzE0Miw3IEBAIHZvaWQgZmlyZV93YXRjaGVzKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsIGNvbnN0IGNoYXIgKm5h bWUsCiAJCSAgc3RydWN0IG5vZGUgKm5vZGUsIGJvb2wgZXhhY3QsIHN0cnVj dCBub2RlX3Blcm1zICpwZXJtcykKIHsKIAlzdHJ1Y3QgY29ubmVjdGlvbiAq aTsKKwlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqcmVxOwogCXN0cnVjdCB3YXRj aCAqd2F0Y2g7CiAKIAkvKiBEdXJpbmcgdHJhbnNhY3Rpb25zLCBkb24ndCBm aXJlIHdhdGNoZXMsIGJ1dCBxdWV1ZSB0aGVtLiAqLwpAQCAtMTUwLDYgKzE1 MSw4IEBAIHZvaWQgZmlyZV93YXRjaGVzKHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCBjb25zdCB2b2lkICpjdHgsIGNvbnN0IGNoYXIgKm5hbWUsCiAJCXJl dHVybjsKIAl9CiAKKwlyZXEgPSBkb21haW5faXNfdW5wcml2aWxlZ2VkKGNv bm4pID8gY29ubi0+aW4gOiBOVUxMOworCiAJLyogQ3JlYXRlIGFuIGV2ZW50 IGZvciBlYWNoIHdhdGNoLiAqLwogCWxpc3RfZm9yX2VhY2hfZW50cnkoaSwg JmNvbm5lY3Rpb25zLCBsaXN0KSB7CiAJCS8qIGludHJvZHVjZS9yZWxlYXNl IGRvbWFpbiB3YXRjaGVzICovCkBAIC0xNjQsMTIgKzE2NywxMiBAQCB2b2lk IGZpcmVfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qg dm9pZCAqY3R4LCBjb25zdCBjaGFyICpuYW1lLAogCQlsaXN0X2Zvcl9lYWNo X2VudHJ5KHdhdGNoLCAmaS0+d2F0Y2hlcywgbGlzdCkgewogCQkJaWYgKGV4 YWN0KSB7CiAJCQkJaWYgKHN0cmVxKG5hbWUsIHdhdGNoLT5ub2RlKSkKLQkJ CQkJc2VuZF9ldmVudChpLAorCQkJCQlzZW5kX2V2ZW50KHJlcSwgaSwKIAkJ CQkJCSAgIGdldF93YXRjaF9wYXRoKHdhdGNoLCBuYW1lKSwKIAkJCQkJCSAg IHdhdGNoLT50b2tlbik7CiAJCQl9IGVsc2UgewogCQkJCWlmIChpc19jaGls ZChuYW1lLCB3YXRjaC0+bm9kZSkpCi0JCQkJCXNlbmRfZXZlbnQoaSwKKwkJ CQkJc2VuZF9ldmVudChyZXEsIGksCiAJCQkJCQkgICBnZXRfd2F0Y2hfcGF0 aCh3YXRjaCwgbmFtZSksCiAJCQkJCQkgICB3YXRjaC0+dG9rZW4pOwogCQkJ fQpAQCAtMjY5LDggKzI3MiwxMiBAQCBpbnQgZG9fd2F0Y2goc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9kYXRhICppbikKIAl0 cmFjZV9jcmVhdGUod2F0Y2gsICJ3YXRjaCIpOwogCXNlbmRfYWNrKGNvbm4s IFhTX1dBVENIKTsKIAotCS8qIFdlIGZpcmUgb25jZSB1cCBmcm9udDogc2lt cGxpZmllcyBjbGllbnRzIGFuZCByZXN0YXJ0LiAqLwotCXNlbmRfZXZlbnQo Y29ubiwgZ2V0X3dhdGNoX3BhdGgod2F0Y2gsIHdhdGNoLT5ub2RlKSwgd2F0 Y2gtPnRva2VuKTsKKwkvKgorCSAqIFdlIGZpcmUgb25jZSB1cCBmcm9udDog c2ltcGxpZmllcyBjbGllbnRzIGFuZCByZXN0YXJ0LgorCSAqIFRoaXMgZXZl bnQgd2lsbCBub3QgYmUgbGlua2VkIHRvIHRoZSBYU19XQVRDSCByZXF1ZXN0 LgorCSAqLworCXNlbmRfZXZlbnQoTlVMTCwgY29ubiwgZ2V0X3dhdGNoX3Bh dGgod2F0Y2gsIHdhdGNoLT5ub2RlKSwKKwkJICAgd2F0Y2gtPnRva2VuKTsK IAogCXJldHVybiAwOwogfQo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-06.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-06.patch" Content-Transfer-Encoding: base64 RnJvbSA3YzgyYzE5NWUwYjk3YmU0YzA3NzI4YmE3NDFiZWI1NGFmYmVlMWI3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGRvbid0IGJ1 ZmZlciBtdWx0aXBsZSBpZGVudGljYWwgd2F0Y2ggZXZlbnRzCgpBIGd1ZXN0 IG5vdCByZWFkaW5nIGl0cyBYZW5zdG9yZSByZXNwb25zZSBidWZmZXIgZmFz dCBlbm91Z2ggbWlnaHQKcGlsZSB1cCBsb3RzIG9mIFhlbnN0b3JlIHdhdGNo IGV2ZW50cyBidWZmZXJlZC4gUmVkdWNlIHRoZSBnZW5lcmF0ZWQKbG9hZCBi eSBkcm9wcGluZyBuZXcgZXZlbnRzIHdoaWNoIGFscmVhZHkgaGF2ZSBhbiBp ZGVudGljYWwgY29weQpwZW5kaW5nLgoKVGhlIHNwZWNpYWwgZXZlbnRzICJA Li4uIiBhcmUgZXhjbHVkZWQgZnJvbSB0aGF0IGhhbmRsaW5nIGFzIHRoZXJl IGFyZQprbm93biB1c2UgY2FzZXMgd2hlcmUgdGhlIGhhbmRsZXIgaXMgcmVs eWluZyBvbiBlYWNoIGV2ZW50IHRvIGJlIHNlbnQKaW5kaXZpZHVhbGx5LgoK VGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRlZC1ieTogSnVsaWVu IEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVs aWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuYwppbmRleCA1NGU2YWRkMWExNTcuLjQ1ZmVh ZTMxM2FlNiAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2NvcmUuYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5j CkBAIC05MTIsNiArOTEyLDcgQEAgdm9pZCBzZW5kX3JlcGx5KHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBlbnVtIHhzZF9zb2NrbXNnX3R5cGUgdHlwZSwK IAliZGF0YS0+aW5oZHIgPSB0cnVlOwogCWJkYXRhLT51c2VkID0gMDsKIAli ZGF0YS0+dGltZW91dF9tc2VjID0gMDsKKwliZGF0YS0+d2F0Y2hfZXZlbnQg PSBmYWxzZTsKIAogCWlmIChsZW4gPD0gREVGQVVMVF9CVUZGRVJfU0laRSkK IAkJYmRhdGEtPmJ1ZmZlciA9IGJkYXRhLT5kZWZhdWx0X2J1ZmZlcjsKQEAg LTk0NCw3ICs5NDUsNyBAQCB2b2lkIHNlbmRfcmVwbHkoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIGVudW0geHNkX3NvY2ttc2dfdHlwZSB0eXBlLAogdm9p ZCBzZW5kX2V2ZW50KHN0cnVjdCBidWZmZXJlZF9kYXRhICpyZXEsIHN0cnVj dCBjb25uZWN0aW9uICpjb25uLAogCQljb25zdCBjaGFyICpwYXRoLCBjb25z dCBjaGFyICp0b2tlbikKIHsKLQlzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqYmRh dGE7CisJc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmJkYXRhLCAqYmQ7CiAJdW5z aWduZWQgaW50IGxlbjsKIAogCWxlbiA9IHN0cmxlbihwYXRoKSArIDEgKyBz dHJsZW4odG9rZW4pICsgMTsKQEAgLTk2NiwxMiArOTY3LDI5IEBAIHZvaWQg c2VuZF9ldmVudChzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqcmVxLCBzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwKIAliZGF0YS0+aGRyLm1zZy50eXBlID0gWFNf V0FUQ0hfRVZFTlQ7CiAJYmRhdGEtPmhkci5tc2cubGVuID0gbGVuOwogCisJ LyoKKwkgKiBDaGVjayB3aGV0aGVyIGFuIGlkZW50aWNhbCBldmVudCBpcyBw ZW5kaW5nIGFscmVhZHkuCisJICogU3BlY2lhbCBldmVudHMgYXJlIGV4Y2x1 ZGVkIGZyb20gdGhhdCBjaGVjay4KKwkgKi8KKwlpZiAocGF0aFswXSAhPSAn QCcpIHsKKwkJbGlzdF9mb3JfZWFjaF9lbnRyeShiZCwgJmNvbm4tPm91dF9s aXN0LCBsaXN0KSB7CisJCQlpZiAoYmQtPndhdGNoX2V2ZW50ICYmIGJkLT5o ZHIubXNnLmxlbiA9PSBsZW4gJiYKKwkJCSAgICAhbWVtY21wKGJkYXRhLT5i dWZmZXIsIGJkLT5idWZmZXIsIGxlbikpIHsKKwkJCQl0cmFjZSgiZHJvcHBp bmcgZHVwbGljYXRlIHdhdGNoICVzICVzIGZvciBkb21haW4gJXVcbiIsCisJ CQkJICAgICAgcGF0aCwgdG9rZW4sIGNvbm4tPmlkKTsKKwkJCQl0YWxsb2Nf ZnJlZShiZGF0YSk7CisJCQkJcmV0dXJuOworCQkJfQorCQl9CisJfQorCiAJ aWYgKHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyAmJiBkb21haW5faXNfdW5w cml2aWxlZ2VkKGNvbm4pKSB7CiAJCWJkYXRhLT50aW1lb3V0X21zZWMgPSBn ZXRfbm93X21zZWMoKSArIHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIAkJ aWYgKCFjb25uLT50aW1lb3V0X21zZWMpCiAJCQljb25uLT50aW1lb3V0X21z ZWMgPSBiZGF0YS0+dGltZW91dF9tc2VjOwogCX0KIAorCWJkYXRhLT53YXRj aF9ldmVudCA9IHRydWU7CiAJYmRhdGEtPnBlbmQucmVxID0gcmVxOwogCWlm IChyZXEpCiAJCXJlcS0+cGVuZC5yZWYuZXZlbnRfY250Kys7CmRpZmYgLS1n aXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCBhY2I2YjlmZTJhYzMu LmUxZDQ3Zjg4NDQ1ZiAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5oCkBAIC02Miw2ICs2Miw5IEBAIHN0cnVjdCBidWZmZXJlZF9kYXRh CiAJLyogQXJlIHdlIHN0aWxsIGRvaW5nIHRoZSBoZWFkZXI/ICovCiAJYm9v bCBpbmhkcjsKIAorCS8qIElzIHRoaXMgYSB3YXRjaCBldmVudD8gKi8KKwli b29sIHdhdGNoX2V2ZW50OworCiAJLyogSG93IGZhciBhcmUgd2U/ICovCiAJ dW5zaWduZWQgaW50IHVzZWQ7CiAK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-07.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-07.patch" Content-Transfer-Encoding: base64 RnJvbSA1MjU1M2I2NWY0ODM4ZTJkN2RkY2Y2OWRlN2I0ZjkwZjI4YzRjNGNh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGZpeCBjb25u ZWN0aW9uLT5pZCB1c2FnZQoKRG9uJ3QgdXNlIGNvbm4tPmlkIGZvciBwcml2 aWxlZ2UgY2hlY2tzLCBidXQgZG9tYWluX2lzX3VucHJpdmlsZWdlZCgpLgoK VGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYuCgpSZXBvcnRlZC1ieTogSnVsaWVu IEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVs aWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCmRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvbnRyb2wuYwppbmRleCBmMGUwMGRiNjMzZWMu LjYxYmNiYzA2OWQ3NSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvbnRyb2wuYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29udHJvbC5jCkBAIC04NzgsNyArODc4LDcgQEAgaW50IGRvX2NvbnRy b2woc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJlZF9k YXRhICppbikKIAl1bnNpZ25lZCBpbnQgY21kLCBudW0sIG9mZjsKIAljaGFy ICoqdmVjID0gTlVMTDsKIAotCWlmIChjb25uLT5pZCAhPSAwKQorCWlmIChk b21haW5faXNfdW5wcml2aWxlZ2VkKGNvbm4pKQogCQlyZXR1cm4gRUFDQ0VT OwogCiAJb2ZmID0gZ2V0X3N0cmluZyhpbiwgMCk7CmRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaAppbmRleCBlMWQ0N2Y4ODQ0NWYuLmFhMGRl ZGRlNjQ0YiAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2NvcmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5o CkBAIC0xMjMsNyArMTIzLDcgQEAgc3RydWN0IGNvbm5lY3Rpb24KIAkvKiBU aGUgaW5kZXggb2YgcG9sbGZkIGluIGdsb2JhbCBwb2xsZmQgYXJyYXkgKi8K IAlpbnQgcG9sbGZkX2lkeDsKIAotCS8qIFdobyBhbSBJPyAwIGZvciBzb2Nr ZXQgY29ubmVjdGlvbnMuICovCisJLyogV2hvIGFtIEk/IERvbWlkIG9mIGNv bm5lY3Rpb24uICovCiAJdW5zaWduZWQgaW50IGlkOwogCiAJLyogSXMgdGhp cyBjb25uZWN0aW9uIGlnbm9yZWQ/ICovCmRpZmYgLS1naXQgYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4IDU0NDMyOTA3ZmM3 Ni4uZWUxYjA5MDMxYTNiIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpAQCAtNDc3LDcgKzQ3Nyw4IEBAIGlu dCBkb190cmFuc2FjdGlvbl9zdGFydChzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgc3RydWN0IGJ1ZmZlcmVkX2RhdGEgKmluKQogCWlmIChjb25uLT50cmFu c2FjdGlvbikKIAkJcmV0dXJuIEVCVVNZOwogCi0JaWYgKGNvbm4tPmlkICYm IGNvbm4tPnRyYW5zYWN0aW9uX3N0YXJ0ZWQgPiBxdW90YV9tYXhfdHJhbnNh Y3Rpb24pCisJaWYgKGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikgJiYK KwkgICAgY29ubi0+dHJhbnNhY3Rpb25fc3RhcnRlZCA+IHF1b3RhX21heF90 cmFuc2FjdGlvbikKIAkJcmV0dXJuIEVOT1NQQzsKIAogCS8qIEF0dGFjaCB0 cmFuc2FjdGlvbiB0byBpbnB1dCBmb3IgYXV0b2ZyZWUgdW50aWwgaXQncyBj b21wbGV0ZSAqLwo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-08.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-08.patch" Content-Transfer-Encoding: base64 RnJvbSA1YWQzNjViOWMyYThmMWExYzM1NjAwMGVlMTlkZjVkY2IyY2U1Yzg3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDggKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IHNpbXBsaWZ5 IGFuZCBmaXggcGVyIGRvbWFpbiBub2RlIGFjY291bnRpbmcKClRoZSBhY2Nv dW50aW5nIG9mIG5vZGVzIGNhbiBiZSBzaW1wbGlmaWVkIG5vdyB0aGF0IGVh Y2ggY29ubmVjdGlvbgpob2xkcyB0aGUgYXNzb2NpYXRlZCBkb21pZC4KCkZp eCB0aGUgbm9kZSBhY2NvdW50aW5nIHRvIGNvdmVyIG5vZGVzIGNyZWF0ZWQg Zm9yIGEgZG9tYWluIGJlZm9yZSBpdApoYXMgYmVlbiBpbnRyb2R1Y2VkLiBU aGlzIHJlcXVpcmVzIHRvIHJlYWN0IHByb3Blcmx5IHRvIGFuIGFsbG9jYXRp b24KZmFpbHVyZSBpbnNpZGUgZG9tYWluX2VudHJ5X2luYygpIGJ5IHJldHVy bmluZyBhbiBlcnJvciBjb2RlLgoKRXNwZWNpYWxseSBpbiBlcnJvciBwYXRo cyB0aGUgbm9kZSBhY2NvdW50aW5nIGhhcyB0byBiZSBmaXhlZCBpbiBzb21l CmNhc2VzLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYgLyBDVkUtMjAyMi00 MjMxMy4KClJlcG9ydGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6 b24uY29tPgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NA c3VzZS5jb20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBh bWF6b24uY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5j CmluZGV4IDQ1ZmVhZTMxM2FlNi4uMGE2ODQ0NTBiY2E2IDEwMDY0NAotLS0g YS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jCisrKyBiL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKQEAgLTYzNCw3ICs2MzQsNyBA QCBzdHJ1Y3Qgbm9kZSAqcmVhZF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpj b25uLCBjb25zdCB2b2lkICpjdHgsCiAKIAkvKiBQZXJtaXNzaW9ucyBhcmUg c3RydWN0IHhzX3Blcm1pc3Npb25zLiAqLwogCW5vZGUtPnBlcm1zLnAgPSBo ZHItPnBlcm1zOwotCWlmIChkb21haW5fYWRqdXN0X25vZGVfcGVybXMobm9k ZSkpIHsKKwlpZiAoZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKGNvbm4sIG5v ZGUpKSB7CiAJCXRhbGxvY19mcmVlKG5vZGUpOwogCQlyZXR1cm4gTlVMTDsK IAl9CkBAIC02NTYsNyArNjU2LDcgQEAgaW50IHdyaXRlX25vZGVfcmF3KHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5LCBzdHJ1Y3Qg bm9kZSAqbm9kZSwKIAl2b2lkICpwOwogCXN0cnVjdCB4c190ZGJfcmVjb3Jk X2hkciAqaGRyOwogCi0JaWYgKGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhu b2RlKSkKKwlpZiAoZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKGNvbm4sIG5v ZGUpKQogCQlyZXR1cm4gZXJybm87CiAKIAlkYXRhLmRzaXplID0gc2l6ZW9m KCpoZHIpCkBAIC0xMjY4LDEzICsxMjY4LDE3IEBAIHN0YXRpYyBzdHJ1Y3Qg bm9kZSAqY29uc3RydWN0X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IGNvbnN0IHZvaWQgKmN0eCwKIAlyZXR1cm4gTlVMTDsKIH0KIAotc3RhdGlj IGludCBkZXN0cm95X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBub2RlICpub2RlKQorc3RhdGljIHZvaWQgZGVzdHJveV9ub2RlX3Jt KHN0cnVjdCBub2RlICpub2RlKQogewogCWlmIChzdHJlcShub2RlLT5uYW1l LCAiLyIpKQogCQljb3JydXB0KE5VTEwsICJEZXN0cm95aW5nIHJvb3Qgbm9k ZSEiKTsKIAogCXRkYl9kZWxldGUodGRiX2N0eCwgbm9kZS0+a2V5KTsKK30K IAorc3RhdGljIGludCBkZXN0cm95X25vZGUoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQoreworCWRlc3Ryb3lfbm9kZV9y bShub2RlKTsKIAlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5vZGUpOwogCiAJ LyoKQEAgLTEzMjQsOCArMTMyOCwxMiBAQCBzdGF0aWMgc3RydWN0IG5vZGUg KmNyZWF0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2 b2lkICpjdHgsCiAJCQlnb3RvIGVycjsKIAogCQkvKiBBY2NvdW50IGZvciBu ZXcgbm9kZSAqLwotCQlpZiAoaS0+cGFyZW50KQotCQkJZG9tYWluX2VudHJ5 X2luYyhjb25uLCBpKTsKKwkJaWYgKGktPnBhcmVudCkgeworCQkJaWYgKGRv bWFpbl9lbnRyeV9pbmMoY29ubiwgaSkpIHsKKwkJCQlkZXN0cm95X25vZGVf cm0oaSk7CisJCQkJcmV0dXJuIE5VTEw7CisJCQl9CisJCX0KIAl9CiAKIAly ZXR1cm4gbm9kZTsKQEAgLTE2MTAsMTAgKzE2MTgsMjcgQEAgc3RhdGljIGlu dCBkb19zZXRfcGVybXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbikKIAlvbGRfcGVybXMgPSBub2RlLT5wZXJt czsKIAlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5vZGUpOwogCW5vZGUtPnBl cm1zID0gcGVybXM7Ci0JZG9tYWluX2VudHJ5X2luYyhjb25uLCBub2RlKTsK KwlpZiAoZG9tYWluX2VudHJ5X2luYyhjb25uLCBub2RlKSkgeworCQlub2Rl LT5wZXJtcyA9IG9sZF9wZXJtczsKKwkJLyoKKwkJICogVGhpcyBzaG91bGQg bmV2ZXIgZmFpbCBiZWNhdXNlIHdlIGhhZCBhIHJlZmVyZW5jZSBvbiB0aGUK KwkJICogZG9tYWluIGJlZm9yZSBhbmQgWGVuc3RvcmVkIGlzIHNpbmdsZS10 aHJlYWRlZC4KKwkJICovCisJCWRvbWFpbl9lbnRyeV9pbmMoY29ubiwgbm9k ZSk7CisJCXJldHVybiBFTk9NRU07CisJfQorCisJaWYgKHdyaXRlX25vZGUo Y29ubiwgbm9kZSwgZmFsc2UpKSB7CisJCWludCBzYXZlZF9lcnJubyA9IGVy cm5vOwogCi0JaWYgKHdyaXRlX25vZGUoY29ubiwgbm9kZSwgZmFsc2UpKQor CQlkb21haW5fZW50cnlfZGVjKGNvbm4sIG5vZGUpOworCQlub2RlLT5wZXJt cyA9IG9sZF9wZXJtczsKKwkJLyogTm8gZmFpbHVyZSBwb3NzaWJsZSBhcyBh Ym92ZS4gKi8KKwkJZG9tYWluX2VudHJ5X2luYyhjb25uLCBub2RlKTsKKwor CQllcnJubyA9IHNhdmVkX2Vycm5vOwogCQlyZXR1cm4gZXJybm87CisJfQog CiAJZmlyZV93YXRjaGVzKGNvbm4sIGluLCBuYW1lLCBub2RlLCBmYWxzZSwg Jm9sZF9wZXJtcyk7CiAJc2VuZF9hY2soY29ubiwgWFNfU0VUX1BFUk1TKTsK QEAgLTMwOTUsNyArMzEyMCw5IEBAIHZvaWQgcmVhZF9zdGF0ZV9ub2RlKGNv bnN0IHZvaWQgKmN0eCwgY29uc3Qgdm9pZCAqc3RhdGUpCiAJc2V0X3RkYl9r ZXkobmFtZSwgJmtleSk7CiAJaWYgKHdyaXRlX25vZGVfcmF3KE5VTEwsICZr ZXksIG5vZGUsIHRydWUpKQogCQliYXJmKCJ3cml0ZSBub2RlIGVycm9yIHJl c3RvcmluZyBub2RlIik7Ci0JZG9tYWluX2VudHJ5X2luYygmY29ubiwgbm9k ZSk7CisKKwlpZiAoZG9tYWluX2VudHJ5X2luYygmY29ubiwgbm9kZSkpCisJ CWJhcmYoIm5vZGUgYWNjb3VudGluZyBlcnJvciByZXN0b3Jpbmcgbm9kZSIp OwogCiAJdGFsbG9jX2ZyZWUobm9kZSk7CiB9CmRpZmYgLS1naXQgYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMgYi90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfZG9tYWluLmMKaW5kZXggYzBhMzc3MTJmODliLi40NGNl MjY3ZWM1NTcgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9kb21haW4uYworKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9t YWluLmMKQEAgLTE2LDYgKzE2LDcgQEAKICAgICBhbG9uZyB3aXRoIHRoaXMg cHJvZ3JhbTsgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNl bnNlcy8+LgogKi8KIAorI2luY2x1ZGUgPGFzc2VydC5oPgogI2luY2x1ZGUg PHN0ZGlvLmg+CiAjaW5jbHVkZSA8c3lzL21tYW4uaD4KICNpbmNsdWRlIDx1 bmlzdGQuaD4KQEAgLTM2Myw2ICszNjQsMTggQEAgc3RhdGljIHN0cnVjdCBk b21haW4gKmZpbmRfb3JfYWxsb2NfZG9tYWluKGNvbnN0IHZvaWQgKmN0eCwg dW5zaWduZWQgaW50IGRvbWlkKQogCXJldHVybiBkb21haW4gPyA6IGFsbG9j X2RvbWFpbihjdHgsIGRvbWlkKTsKIH0KIAorc3RhdGljIHN0cnVjdCBkb21h aW4gKmZpbmRfb3JfYWxsb2NfZXhpc3RpbmdfZG9tYWluKHVuc2lnbmVkIGlu dCBkb21pZCkKK3sKKwlzdHJ1Y3QgZG9tYWluICpkb21haW47CisJeGNfZG9t aW5mb190IGRvbWluZm87CisKKwlkb21haW4gPSBmaW5kX2RvbWFpbl9zdHJ1 Y3QoZG9taWQpOworCWlmICghZG9tYWluICYmIGdldF9kb21haW5faW5mbyhk b21pZCwgJmRvbWluZm8pKQorCQlkb21haW4gPSBhbGxvY19kb21haW4oTlVM TCwgZG9taWQpOworCisJcmV0dXJuIGRvbWFpbjsKK30KKwogc3RhdGljIGlu dCBuZXdfZG9tYWluKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgaW50IHBvcnQs IGJvb2wgcmVzdG9yZSkKIHsKIAlpbnQgcmM7CkBAIC04MTQsMzAgKzgyNywy OCBAQCB2b2lkIGRvbWFpbl9kZWluaXQodm9pZCkKIAkJeGVuZXZ0Y2huX3Vu YmluZCh4Y2VfaGFuZGxlLCB2aXJxX3BvcnQpOwogfQogCi12b2lkIGRvbWFp bl9lbnRyeV9pbmMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlKQoraW50IGRvbWFpbl9lbnRyeV9pbmMoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQogewogCXN0cnVjdCBk b21haW4gKmQ7CisJdW5zaWduZWQgaW50IGRvbWlkOwogCiAJaWYgKCFjb25u KQotCQlyZXR1cm47CisJCXJldHVybiAwOwogCi0JaWYgKG5vZGUtPnBlcm1z LnAgJiYgbm9kZS0+cGVybXMucFswXS5pZCAhPSBjb25uLT5pZCkgewotCQlp ZiAoY29ubi0+dHJhbnNhY3Rpb24pIHsKLQkJCXRyYW5zYWN0aW9uX2VudHJ5 X2luYyhjb25uLT50cmFuc2FjdGlvbiwKLQkJCQlub2RlLT5wZXJtcy5wWzBd LmlkKTsKLQkJfSBlbHNlIHsKLQkJCWQgPSBmaW5kX2RvbWFpbl9ieV9kb21p ZChub2RlLT5wZXJtcy5wWzBdLmlkKTsKLQkJCWlmIChkKQotCQkJCWQtPm5i ZW50cnkrKzsKLQkJfQotCX0gZWxzZSBpZiAoY29ubi0+ZG9tYWluKSB7Ci0J CWlmIChjb25uLT50cmFuc2FjdGlvbikgewotCQkJdHJhbnNhY3Rpb25fZW50 cnlfaW5jKGNvbm4tPnRyYW5zYWN0aW9uLAotCQkJCWNvbm4tPmRvbWFpbi0+ ZG9taWQpOwotIAkJfSBlbHNlIHsKLSAJCQljb25uLT5kb21haW4tPm5iZW50 cnkrKzsKLQkJfQorCWRvbWlkID0gbm9kZS0+cGVybXMucCA/IG5vZGUtPnBl cm1zLnBbMF0uaWQgOiBjb25uLT5pZDsKKworCWlmIChjb25uLT50cmFuc2Fj dGlvbikgeworCQl0cmFuc2FjdGlvbl9lbnRyeV9pbmMoY29ubi0+dHJhbnNh Y3Rpb24sIGRvbWlkKTsKKwl9IGVsc2UgeworCQlkID0gKGRvbWlkID09IGNv bm4tPmlkICYmIGNvbm4tPmRvbWFpbikgPyBjb25uLT5kb21haW4KKwkJICAg IDogZmluZF9vcl9hbGxvY19leGlzdGluZ19kb21haW4oZG9taWQpOworCQlp ZiAoZCkKKwkJCWQtPm5iZW50cnkrKzsKKwkJZWxzZQorCQkJcmV0dXJuIEVO T01FTTsKIAl9CisKKwlyZXR1cm4gMDsKIH0KIAogLyoKQEAgLTg3Myw3ICs4 ODQsNyBAQCBzdGF0aWMgaW50IGNoa19kb21haW5fZ2VuZXJhdGlvbih1bnNp Z25lZCBpbnQgZG9taWQsIHVpbnQ2NF90IGdlbikKICAqIFJlbW92ZSBwZXJt aXNzaW9ucyBmb3Igbm8gbG9uZ2VyIGV4aXN0aW5nIGRvbWFpbnMgaW4gb3Jk ZXIgdG8gYXZvaWQgYSBuZXcKICAqIGRvbWFpbiB3aXRoIHRoZSBzYW1lIGRv bWlkIGluaGVyaXRpbmcgdGhlIHBlcm1pc3Npb25zLgogICovCi1pbnQgZG9t YWluX2FkanVzdF9ub2RlX3Blcm1zKHN0cnVjdCBub2RlICpub2RlKQoraW50 IGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgc3RydWN0IG5vZGUgKm5vZGUpCiB7CiAJdW5zaWduZWQgaW50IGk7 CiAJaW50IHJldDsKQEAgLTg4Myw4ICs4OTQsMTQgQEAgaW50IGRvbWFpbl9h ZGp1c3Rfbm9kZV9wZXJtcyhzdHJ1Y3Qgbm9kZSAqbm9kZSkKIAkJcmV0dXJu IGVycm5vOwogCiAJLyogSWYgdGhlIG93bmVyIGRvZXNuJ3QgZXhpc3QgYW55 IGxvbmdlciBnaXZlIGl0IHRvIHByaXYgZG9tYWluLiAqLwotCWlmICghcmV0 KQorCWlmICghcmV0KSB7CisJCS8qCisJCSAqIEluIHRoZW9yeSB3ZSdkIG5l ZWQgdG8gdXBkYXRlIHRoZSBudW1iZXIgb2YgZG9tMCBub2RlcyBoZXJlLAor CQkgKiBidXQgd2UgY291bGQgYmUgY2FsbGVkIGZvciBhIHJlYWQgb2YgdGhl IG5vZGUuIFNvIGJldHRlcgorCQkgKiBhdm9pZCB0aGUgcmlzayB0byBvdmVy ZmxvdyB0aGUgbm9kZSBjb3VudCBvZiBkb20wLgorCQkgKi8KIAkJbm9kZS0+ cGVybXMucFswXS5pZCA9IHByaXZfZG9taWQ7CisJfQogCiAJZm9yIChpID0g MTsgaSA8IG5vZGUtPnBlcm1zLm51bTsgaSsrKSB7CiAJCWlmIChub2RlLT5w ZXJtcy5wW2ldLnBlcm1zICYgWFNfUEVSTV9JR05PUkUpCkBAIC05MDMsMjUg KzkyMCwyNSBAQCBpbnQgZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKHN0cnVj dCBub2RlICpub2RlKQogdm9pZCBkb21haW5fZW50cnlfZGVjKHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSkKIHsKIAlzdHJ1 Y3QgZG9tYWluICpkOworCXVuc2lnbmVkIGludCBkb21pZDsKIAogCWlmICgh Y29ubikKIAkJcmV0dXJuOwogCi0JaWYgKG5vZGUtPnBlcm1zLnAgJiYgbm9k ZS0+cGVybXMucFswXS5pZCAhPSBjb25uLT5pZCkgewotCQlpZiAoY29ubi0+ dHJhbnNhY3Rpb24pIHsKLQkJCXRyYW5zYWN0aW9uX2VudHJ5X2RlYyhjb25u LT50cmFuc2FjdGlvbiwKLQkJCQlub2RlLT5wZXJtcy5wWzBdLmlkKTsKLQkJ fSBlbHNlIHsKLQkJCWQgPSBmaW5kX2RvbWFpbl9ieV9kb21pZChub2RlLT5w ZXJtcy5wWzBdLmlkKTsKLQkJCWlmIChkICYmIGQtPm5iZW50cnkpCi0JCQkJ ZC0+bmJlbnRyeS0tOwotCQl9Ci0JfSBlbHNlIGlmIChjb25uLT5kb21haW4g JiYgY29ubi0+ZG9tYWluLT5uYmVudHJ5KSB7Ci0JCWlmIChjb25uLT50cmFu c2FjdGlvbikgewotCQkJdHJhbnNhY3Rpb25fZW50cnlfZGVjKGNvbm4tPnRy YW5zYWN0aW9uLAotCQkJCWNvbm4tPmRvbWFpbi0+ZG9taWQpOworCWRvbWlk ID0gbm9kZS0+cGVybXMucCA/IG5vZGUtPnBlcm1zLnBbMF0uaWQgOiBjb25u LT5pZDsKKworCWlmIChjb25uLT50cmFuc2FjdGlvbikgeworCQl0cmFuc2Fj dGlvbl9lbnRyeV9kZWMoY29ubi0+dHJhbnNhY3Rpb24sIGRvbWlkKTsKKwl9 IGVsc2UgeworCQlkID0gKGRvbWlkID09IGNvbm4tPmlkICYmIGNvbm4tPmRv bWFpbikgPyBjb25uLT5kb21haW4KKwkJICAgIDogZmluZF9kb21haW5fc3Ry dWN0KGRvbWlkKTsKKwkJaWYgKGQpIHsKKwkJCWQtPm5iZW50cnktLTsKIAkJ fSBlbHNlIHsKLQkJCWNvbm4tPmRvbWFpbi0+bmJlbnRyeS0tOworCQkJZXJy bm8gPSBFTk9FTlQ7CisJCQljb3JydXB0KGNvbm4sCisJCQkJIk5vZGUgXCIl c1wiIG93bmVkIGJ5IG5vbi1leGlzdGluZyBkb21haW4gJXVcbiIsCisJCQkJ bm9kZS0+bmFtZSwgZG9taWQpOwogCQl9CiAJfQogfQpAQCAtOTMxLDEzICs5 NDgsMjMgQEAgaW50IGRvbWFpbl9lbnRyeV9maXgodW5zaWduZWQgaW50IGRv bWlkLCBpbnQgbnVtLCBib29sIHVwZGF0ZSkKIAlzdHJ1Y3QgZG9tYWluICpk OwogCWludCBjbnQ7CiAKLQlkID0gZmluZF9kb21haW5fYnlfZG9taWQoZG9t aWQpOwotCWlmICghZCkKLQkJcmV0dXJuIDA7CisJaWYgKHVwZGF0ZSkgewor CQlkID0gZmluZF9kb21haW5fc3RydWN0KGRvbWlkKTsKKwkJYXNzZXJ0KGQp OworCX0gZWxzZSB7CisJCS8qCisJCSAqIFdlIGFyZSBjYWxsZWQgZmlyc3Qg d2l0aCB1cGRhdGUgPT0gZmFsc2UgaW4gb3JkZXIgdG8gY2F0Y2gKKwkJICog YW55IGVycm9yLiBTbyBkbyBhIHBvc3NpYmxlIGFsbG9jYXRpb24gYW5kIGNo ZWNrIGZvciBlcnJvcgorCQkgKiBvbmx5IGluIHRoaXMgY2FzZSwgYXMgaW4g dGhlIGNhc2Ugb2YgdXBkYXRlID09IHRydWUgbm90aGluZworCQkgKiBjYW4g Z28gd3JvbmcgYW55bW9yZSBhcyB0aGUgYWxsb2NhdGlvbiBhbHJlYWR5IGhh cHBlbmVkLgorCQkgKi8KKwkJZCA9IGZpbmRfb3JfYWxsb2NfZXhpc3Rpbmdf ZG9tYWluKGRvbWlkKTsKKwkJaWYgKCFkKQorCQkJcmV0dXJuIC0xOworCX0K IAogCWNudCA9IGQtPm5iZW50cnkgKyBudW07Ci0JaWYgKGNudCA8IDApCi0J CWNudCA9IDA7CisJYXNzZXJ0KGNudCA+PSAwKTsKIAogCWlmICh1cGRhdGUp CiAJCWQtPm5iZW50cnkgPSBjbnQ7CmRpZmYgLS1naXQgYS90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfZG9tYWluLmggYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmgKaW5kZXggNjE3ZDBhY2ZkNzViLi41OTM3OTMxMzE0 OTQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21h aW4uaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgK QEAgLTU1LDEwICs1NSwxMCBAQCBjb25zdCBjaGFyICpnZXRfaW1wbGljaXRf cGF0aChjb25zdCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7CiBib29sIGRv bWFpbl9pc191bnByaXZpbGVnZWQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4p OwogCiAvKiBSZW1vdmUgbm9kZSBwZXJtaXNzaW9ucyBmb3Igbm8gbG9uZ2Vy IGV4aXN0aW5nIGRvbWFpbnMuICovCi1pbnQgZG9tYWluX2FkanVzdF9ub2Rl X3Blcm1zKHN0cnVjdCBub2RlICpub2RlKTsKK2ludCBkb21haW5fYWRqdXN0 X25vZGVfcGVybXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBu b2RlICpub2RlKTsKIAogLyogUXVvdGEgbWFuaXB1bGF0aW9uICovCi12b2lk IGRvbWFpbl9lbnRyeV9pbmMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBub2RlICopOworaW50IGRvbWFpbl9lbnRyeV9pbmMoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICopOwogdm9pZCBkb21haW5f ZW50cnlfZGVjKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9k ZSAqKTsKIGludCBkb21haW5fZW50cnlfZml4KHVuc2lnbmVkIGludCBkb21p ZCwgaW50IG51bSwgYm9vbCB1cGRhdGUpOwogaW50IGRvbWFpbl9lbnRyeShz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7CmRpZmYgLS1naXQgYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4IGVlMWIwOTAzMWEz Yi4uODZjYWY2YzM5OGJlIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpAQCAtNTE5LDggKzUxOSwxMiBAQCBz dGF0aWMgaW50IHRyYW5zYWN0aW9uX2ZpeF9kb21haW5zKHN0cnVjdCB0cmFu c2FjdGlvbiAqdHJhbnMsIGJvb2wgdXBkYXRlKQogCiAJbGlzdF9mb3JfZWFj aF9lbnRyeShkLCAmdHJhbnMtPmNoYW5nZWRfZG9tYWlucywgbGlzdCkgewog CQljbnQgPSBkb21haW5fZW50cnlfZml4KGQtPmRvbWlkLCBkLT5uYmVudHJ5 LCB1cGRhdGUpOwotCQlpZiAoIXVwZGF0ZSAmJiBjbnQgPj0gcXVvdGFfbmJf ZW50cnlfcGVyX2RvbWFpbikKLQkJCXJldHVybiBFTk9TUEM7CisJCWlmICgh dXBkYXRlKSB7CisJCQlpZiAoY250ID49IHF1b3RhX25iX2VudHJ5X3Blcl9k b21haW4pCisJCQkJcmV0dXJuIEVOT1NQQzsKKwkJCWlmIChjbnQgPCAwKQor CQkJCXJldHVybiBFTk9NRU07CisJCX0KIAl9CiAKIAlyZXR1cm4gMDsK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-09.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-09.patch" Content-Transfer-Encoding: base64 RnJvbSA1YTlkMGFlNDg3OWZiMmI1YTBkYThhNTkyYTM1NzNmZjk2ZjU3YzA1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGxpbWl0IG1h eCBudW1iZXIgb2Ygbm9kZXMgYWNjZXNzZWQgaW4gYSB0cmFuc2FjdGlvbgoK VG9kYXkgYSBndWVzdCBpcyBmcmVlIHRvIGFjY2VzcyBhcyBtYW55IG5vZGVz IGluIGEgc2luZ2xlIHRyYW5zYWN0aW9uCmFzIGl0IHdhbnRzLiBUaGlzIGNh biBsZWFkIHRvIHVuYm91bmRlZCBtZW1vcnkgY29uc3VtcHRpb24gaW4gWGVu c3RvcmUKYXMgdGhlcmUgaXMgdGhlIG5lZWQgdG8ga2VlcCB0cmFjayBvZiBh bGwgbm9kZXMgaGF2aW5nIGJlZW4gYWNjZXNzZWQKZHVyaW5nIGEgdHJhbnNh Y3Rpb24uCgpJbiBveGVuc3RvcmVkIHRoZSBudW1iZXIgb2YgcmVxdWVzdHMg aW4gYSB0cmFuc2FjdGlvbiBpcyBiZWluZyBsaW1pdGVkCnZpYSBhIHF1b3Rh IG1heHJlcXVlc3RzIChkZWZhdWx0IGlzIDEwMjQpLiBBcyBtdWx0aXBsZSBh Y2Nlc3NlcyBvZiBhCm5vZGUgYXJlIG5vdCBwcm9ibGVtYXRpYyBpbiBDIFhl bnN0b3JlLCBsaW1pdCB0aGUgbnVtYmVyIG9mIGFjY2Vzc2VkCm5vZGVzLgoK SW4gb3JkZXIgdG8gbGV0IHJlYWRfbm9kZSgpIGRldGVjdCBhIHF1b3RhIGVy cm9yIGluIGNhc2UgdG9vIG1hbnkgbm9kZXMKYXJlIGJlaW5nIGFjY2Vzc2Vk LCBjaGVjayB0aGUgcmV0dXJuIHZhbHVlIG9mIGFjY2Vzc19ub2RlKCkgYW5k IHJldHVybgpOVUxMIGluIGNhc2UgYW4gZXJyb3IgaGFzIGJlZW4gc2Vlbi4g SW50cm9kdWNlIF9fbXVzdF9jaGVjayBhbmQgYWRkIGl0CnRvIHRoZSBhY2Nl c3Nfbm9kZSgpIHByb3RvdHlwZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzI2 IC8gQ1ZFLTIwMjItNDIzMTQuCgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxs IDxqZ3JhbGxAYW1hem9uLmNvbT4KU3VnZ2VzdGVkLWJ5OiBKdWxpZW4gR3Jh bGwgPGp1bGllbkB4ZW4ub3JnPgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdy b3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBKdWxpZW4gR3Jh bGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL2lu Y2x1ZGUveGVuLXRvb2xzL2xpYnMuaCBiL3Rvb2xzL2luY2x1ZGUveGVuLXRv b2xzL2xpYnMuaAppbmRleCBhMTZlMGMzODA3MDkuLmJhZmM5MGUyZjYwMyAx MDA2NDQKLS0tIGEvdG9vbHMvaW5jbHVkZS94ZW4tdG9vbHMvbGlicy5oCisr KyBiL3Rvb2xzL2luY2x1ZGUveGVuLXRvb2xzL2xpYnMuaApAQCAtNjMsNCAr NjMsOCBAQAogI2RlZmluZSBST1VORFVQKF94LF93KSAoKCh1bnNpZ25lZCBs b25nKShfeCkrKDFVTDw8KF93KSktMSkgJiB+KCgxVUw8PChfdykpLTEpKQog I2VuZGlmCiAKKyNpZm5kZWYgX19tdXN0X2NoZWNrCisjZGVmaW5lIF9fbXVz dF9jaGVjayBfX2F0dHJpYnV0ZV9fKChfX3dhcm5fdW51c2VkX3Jlc3VsdF9f KSkKKyNlbmRpZgorCiAjZW5kaWYJLyogX19YRU5fVE9PTFNfTElCU19fICov CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5j IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwppbmRleCAwYTY4 NDQ1MGJjYTYuLmQ0ZmQwMDVmNTk5ZCAxMDA2NDQKLS0tIGEvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfY29yZS5jCkBAIC0xMDYsNiArMTA2LDcgQEAgaW50IHF1b3Rh X25iX3dhdGNoX3Blcl9kb21haW4gPSAxMjg7CiBpbnQgcXVvdGFfbWF4X2Vu dHJ5X3NpemUgPSAyMDQ4OyAvKiAySyAqLwogaW50IHF1b3RhX21heF90cmFu c2FjdGlvbiA9IDEwOwogaW50IHF1b3RhX25iX3Blcm1zX3Blcl9ub2RlID0g NTsKK2ludCBxdW90YV90cmFuc19ub2RlcyA9IDEwMjQ7CiBpbnQgcXVvdGFf bWF4X3BhdGhfbGVuID0gWEVOU1RPUkVfUkVMX1BBVEhfTUFYOwogaW50IHF1 b3RhX3JlcV9vdXRzdGFuZGluZyA9IDIwOwogCkBAIC01OTEsNiArNTkyLDcg QEAgc3RydWN0IG5vZGUgKnJlYWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAq Y29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCVREQl9EQVRBIGtleSwgZGF0YTsK IAlzdHJ1Y3QgeHNfdGRiX3JlY29yZF9oZHIgKmhkcjsKIAlzdHJ1Y3Qgbm9k ZSAqbm9kZTsKKwlpbnQgZXJyOwogCiAJbm9kZSA9IHRhbGxvYyhjdHgsIHN0 cnVjdCBub2RlKTsKIAlpZiAoIW5vZGUpIHsKQEAgLTYxMiwxNCArNjE0LDEz IEBAIHN0cnVjdCBub2RlICpyZWFkX25vZGUoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAlpZiAoZGF0YS5kcHRyID09IE5V TEwpIHsKIAkJaWYgKHRkYl9lcnJvcih0ZGJfY3R4KSA9PSBUREJfRVJSX05P RVhJU1QpIHsKIAkJCW5vZGUtPmdlbmVyYXRpb24gPSBOT19HRU5FUkFUSU9O OwotCQkJYWNjZXNzX25vZGUoY29ubiwgbm9kZSwgTk9ERV9BQ0NFU1NfUkVB RCwgTlVMTCk7Ci0JCQllcnJubyA9IEVOT0VOVDsKKwkJCWVyciA9IGFjY2Vz c19ub2RlKGNvbm4sIG5vZGUsIE5PREVfQUNDRVNTX1JFQUQsIE5VTEwpOwor CQkJZXJybm8gPSBlcnIgPyA6IEVOT0VOVDsKIAkJfSBlbHNlIHsKIAkJCWxv ZygiVERCIGVycm9yIG9uIHJlYWQ6ICVzIiwgdGRiX2Vycm9yc3RyKHRkYl9j dHgpKTsKIAkJCWVycm5vID0gRUlPOwogCQl9Ci0JCXRhbGxvY19mcmVlKG5v ZGUpOwotCQlyZXR1cm4gTlVMTDsKKwkJZ290byBlcnJvcjsKIAl9CiAKIAlu b2RlLT5wYXJlbnQgPSBOVUxMOwpAQCAtNjM0LDE5ICs2MzUsMzYgQEAgc3Ry dWN0IG5vZGUgKnJlYWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3Qgdm9pZCAqY3R4LAogCiAJLyogUGVybWlzc2lvbnMgYXJlIHN0cnVj dCB4c19wZXJtaXNzaW9ucy4gKi8KIAlub2RlLT5wZXJtcy5wID0gaGRyLT5w ZXJtczsKLQlpZiAoZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKGNvbm4sIG5v ZGUpKSB7Ci0JCXRhbGxvY19mcmVlKG5vZGUpOwotCQlyZXR1cm4gTlVMTDsK LQl9CisJaWYgKGRvbWFpbl9hZGp1c3Rfbm9kZV9wZXJtcyhjb25uLCBub2Rl KSkKKwkJZ290byBlcnJvcjsKIAogCS8qIERhdGEgaXMgYmluYXJ5IGJsb2Ig KHVzdWFsbHkgYXNjaWksIG5vIG51bCkuICovCiAJbm9kZS0+ZGF0YSA9IG5v ZGUtPnBlcm1zLnAgKyBoZHItPm51bV9wZXJtczsKIAkvKiBDaGlsZHJlbiBp cyBzdHJpbmdzLCBudWwgc2VwYXJhdGVkLiAqLwogCW5vZGUtPmNoaWxkcmVu ID0gbm9kZS0+ZGF0YSArIG5vZGUtPmRhdGFsZW47CiAKLQlhY2Nlc3Nfbm9k ZShjb25uLCBub2RlLCBOT0RFX0FDQ0VTU19SRUFELCBOVUxMKTsKKwlpZiAo YWNjZXNzX25vZGUoY29ubiwgbm9kZSwgTk9ERV9BQ0NFU1NfUkVBRCwgTlVM TCkpCisJCWdvdG8gZXJyb3I7CiAKIAlyZXR1cm4gbm9kZTsKKworIGVycm9y OgorCWVyciA9IGVycm5vOworCXRhbGxvY19mcmVlKG5vZGUpOworCWVycm5v ID0gZXJyOworCXJldHVybiBOVUxMOworfQorCitzdGF0aWMgYm9vbCByZWFk X25vZGVfY2FuX3Byb3BhZ2F0ZV9lcnJubyh2b2lkKQoreworCS8qCisJICog MiBlcnJvciBjYXNlcyBmb3IgcmVhZF9ub2RlKCkgY2FuIGFsd2F5cyBiZSBw cm9wYWdhdGVkIHVwOgorCSAqIEVOT01FTSwgYmVjYXVzZSB0aGlzIGhhcyBu b3RoaW5nIHRvIGRvIHdpdGggdGhlIG5vZGUgYmVpbmcgaW4gdGhlCisJICog ZGF0YSBiYXNlIG9yIG5vdCwgYnV0IGlzIGNhdXNlZCBieSBhIGdlbmVyYWwg bGFjayBvZiBtZW1vcnkuCisJICogRU5PU1BDLCBiZWNhdXNlIHRoaXMgaXMg cmVsYXRlZCB0byBoaXR0aW5nIHF1b3RhIGxpbWl0cyB3aGljaCBuZWVkCisJ ICogdG8gYmUgcmVzcGVjdGVkLgorCSAqLworCXJldHVybiBlcnJubyA9PSBF Tk9NRU0gfHwgZXJybm8gPT0gRU5PU1BDOwogfQogCiBpbnQgd3JpdGVfbm9k ZV9yYXcoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXks IHN0cnVjdCBub2RlICpub2RlLApAQCAtNzYzLDcgKzc4MSw3IEBAIHN0YXRp YyBpbnQgYXNrX3BhcmVudHMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNv bnN0IHZvaWQgKmN0eCwKIAkJbm9kZSA9IHJlYWRfbm9kZShjb25uLCBjdHgs IG5hbWUpOwogCQlpZiAobm9kZSkKIAkJCWJyZWFrOwotCQlpZiAoZXJybm8g PT0gRU5PTUVNKQorCQlpZiAocmVhZF9ub2RlX2Nhbl9wcm9wYWdhdGVfZXJy bm8oKSkKIAkJCXJldHVybiBlcnJubzsKIAl9IHdoaWxlICghc3RyZXEobmFt ZSwgIi8iKSk7CiAKQEAgLTgyNSw3ICs4NDMsNyBAQCBzdGF0aWMgc3RydWN0 IG5vZGUgKmdldF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAogCQl9 CiAJfQogCS8qIENsZWFuIHVwIGVycm5vIGlmIHRoZXkgd2VyZW4ndCBzdXBw b3NlZCB0byBrbm93LiAqLwotCWlmICghbm9kZSAmJiBlcnJubyAhPSBFTk9N RU0pCisJaWYgKCFub2RlICYmICFyZWFkX25vZGVfY2FuX3Byb3BhZ2F0ZV9l cnJubygpKQogCQllcnJubyA9IGVycm5vX2Zyb21fcGFyZW50cyhjb25uLCBj dHgsIG5hbWUsIGVycm5vLCBwZXJtKTsKIAlyZXR1cm4gbm9kZTsKIH0KQEAg LTEyMzEsNyArMTI0OSw3IEBAIHN0YXRpYyBzdHJ1Y3Qgbm9kZSAqY29uc3Ry dWN0X25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQg KmN0eCwKIAogCS8qIElmIHBhcmVudCBkb2Vzbid0IGV4aXN0LCBjcmVhdGUg aXQuICovCiAJcGFyZW50ID0gcmVhZF9ub2RlKGNvbm4sIHBhcmVudG5hbWUs IHBhcmVudG5hbWUpOwotCWlmICghcGFyZW50KQorCWlmICghcGFyZW50ICYm IGVycm5vID09IEVOT0VOVCkKIAkJcGFyZW50ID0gY29uc3RydWN0X25vZGUo Y29ubiwgY3R4LCBwYXJlbnRuYW1lKTsKIAlpZiAoIXBhcmVudCkKIAkJcmV0 dXJuIE5VTEw7CkBAIC0xNTA1LDcgKzE1MjMsNyBAQCBzdGF0aWMgaW50IF9y bShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LCBz dHJ1Y3Qgbm9kZSAqbm9kZSwKIAogCXBhcmVudCA9IHJlYWRfbm9kZShjb25u LCBjdHgsIHBhcmVudG5hbWUpOwogCWlmICghcGFyZW50KQotCQlyZXR1cm4g KGVycm5vID09IEVOT01FTSkgPyBFTk9NRU0gOiBFSU5WQUw7CisJCXJldHVy biByZWFkX25vZGVfY2FuX3Byb3BhZ2F0ZV9lcnJubygpID8gZXJybm8gOiBF SU5WQUw7CiAJbm9kZS0+cGFyZW50ID0gcGFyZW50OwogCiAJcmV0dXJuIGRl bGV0ZV9ub2RlKGNvbm4sIGN0eCwgcGFyZW50LCBub2RlLCBmYWxzZSk7CkBA IC0xNTM1LDcgKzE1NTMsNyBAQCBzdGF0aWMgaW50IGRvX3JtKHN0cnVjdCBj b25uZWN0aW9uICpjb25uLCBzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJ CQkJcmV0dXJuIDA7CiAJCQl9CiAJCQkvKiBSZXN0b3JlIGVycm5vLCBqdXN0 IGluIGNhc2UuICovCi0JCQlpZiAoZXJybm8gIT0gRU5PTUVNKQorCQkJaWYg KCFyZWFkX25vZGVfY2FuX3Byb3BhZ2F0ZV9lcnJubygpKQogCQkJCWVycm5v ID0gRU5PRU5UOwogCQl9CiAJCXJldHVybiBlcnJubzsKQEAgLTIzNjgsNiAr MjM4Niw4IEBAIHN0YXRpYyB2b2lkIHVzYWdlKHZvaWQpCiAiICAtTSwgLS1w YXRoLW1heCA8Y2hhcnM+ICBsaW1pdCB0aGUgYWxsb3dlZCBYZW5zdG9yZSBu b2RlIHBhdGggbGVuZ3RoLFxuIgogIiAgLVEsIC0tcXVvdGEgPHdoYXQ+PTxu Yj4gc2V0IHRoZSBxdW90YSA8d2hhdD4gdG8gdGhlIHZhbHVlIDxuYj4sIGFs bG93ZWRcbiIKICIgICAgICAgICAgICAgICAgICAgICAgICAgIHF1b3RhcyBh cmU6XG4iCisiICAgICAgICAgICAgICAgICAgICAgICAgICB0cmFuc2FjdGlv bi1ub2RlczogbnVtYmVyIG9mIGFjY2Vzc2VkIG5vZGUgcGVyXG4iCisiICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHJh bnNhY3Rpb25cbiIKICIgICAgICAgICAgICAgICAgICAgICAgICAgIG91dHN0 YW5kaW5nOiBudW1iZXIgb2Ygb3V0c3RhbmRpbmcgcmVxdWVzdHNcbiIKICIg IC13LCAtLXRpbWVvdXQgPHdoYXQ+PTxzZWNvbmRzPiAgIHNldCB0aGUgdGlt ZW91dCBpbiBzZWNvbmRzIGZvciA8d2hhdD4sXG4iCiAiICAgICAgICAgICAg ICAgICAgICAgICAgICBhbGxvd2VkIHRpbWVvdXQgY2FuZGlkYXRlcyBhcmU6 XG4iCkBAIC0yNDUyLDYgKzI0NzIsOCBAQCBzdGF0aWMgdm9pZCBzZXRfcXVv dGEoY29uc3QgY2hhciAqYXJnKQogCXZhbCA9IGdldF9vcHR2YWxfaW50KGVx ICsgMSk7CiAJaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJvdXRzdGFuZGluZyIp KQogCQlxdW90YV9yZXFfb3V0c3RhbmRpbmcgPSB2YWw7CisJZWxzZSBpZiAo d2hhdF9tYXRjaGVzKGFyZywgInRyYW5zYWN0aW9uLW5vZGVzIikpCisJCXF1 b3RhX3RyYW5zX25vZGVzID0gdmFsOwogCWVsc2UKIAkJYmFyZigidW5rbm93 biBxdW90YSBcIiVzXCJcbiIsIGFyZyk7CiB9CmRpZmYgLS1naXQgYS90b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX2NvcmUuaAppbmRleCBhYTBkZWRkZTY0NGIuLjljNTcyYTNj NmUyYSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuaAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCkBA IC0yNjYsNiArMjY2LDcgQEAgZXh0ZXJuIGludCBkb20wX2V2ZW50OwogZXh0 ZXJuIGludCBwcml2X2RvbWlkOwogZXh0ZXJuIGludCBxdW90YV9uYl9lbnRy eV9wZXJfZG9tYWluOwogZXh0ZXJuIGludCBxdW90YV9yZXFfb3V0c3RhbmRp bmc7CitleHRlcm4gaW50IHF1b3RhX3RyYW5zX25vZGVzOwogCiBleHRlcm4g dW5zaWduZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIApkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9u LmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpp bmRleCA4NmNhZjZjMzk4YmUuLjdiZDQxZWI0NzVlMyAxMDA2NDQKLS0tIGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKKysrIGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKQEAgLTE1 Niw2ICsxNTYsOSBAQCBzdHJ1Y3QgdHJhbnNhY3Rpb24KIAkvKiBDb25uZWN0 aW9uLWxvY2FsIGlkZW50aWZpZXIgZm9yIHRoaXMgdHJhbnNhY3Rpb24uICov CiAJdWludDMyX3QgaWQ7CiAKKwkvKiBOb2RlIGNvdW50ZXIuICovCisJdW5z aWduZWQgaW50IG5vZGVzOworCiAJLyogR2VuZXJhdGlvbiB3aGVuIHRyYW5z YWN0aW9uIHN0YXJ0ZWQuICovCiAJdWludDY0X3QgZ2VuZXJhdGlvbjsKIApA QCAtMjYwLDYgKzI2MywxMSBAQCBpbnQgYWNjZXNzX25vZGUoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAogCiAJaSA9IGZp bmRfYWNjZXNzZWRfbm9kZSh0cmFucywgbm9kZS0+bmFtZSk7CiAJaWYgKCFp KSB7CisJCWlmICh0cmFucy0+bm9kZXMgPj0gcXVvdGFfdHJhbnNfbm9kZXMg JiYKKwkJICAgIGRvbWFpbl9pc191bnByaXZpbGVnZWQoY29ubikpIHsKKwkJ CXJldCA9IEVOT1NQQzsKKwkJCWdvdG8gZXJyOworCQl9CiAJCWkgPSB0YWxs b2NfemVybyh0cmFucywgc3RydWN0IGFjY2Vzc2VkX25vZGUpOwogCQlpZiAo IWkpCiAJCQlnb3RvIG5vbWVtOwpAQCAtMjk3LDYgKzMwNSw3IEBAIGludCBh Y2Nlc3Nfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5v ZGUgKm5vZGUsCiAJCQkJaS0+dGFfbm9kZSA9IHRydWU7CiAJCQl9CiAJCX0K KwkJdHJhbnMtPm5vZGVzKys7CiAJCWxpc3RfYWRkX3RhaWwoJmktPmxpc3Qs ICZ0cmFucy0+YWNjZXNzZWQpOwogCX0KIApkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmggYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uaAppbmRleCAwMDkzY2FjODA3 ZTMuLmUzY2JkNmIyMzA5NSAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKKysrIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKQEAgLTM5LDggKzM5LDggQEAgdm9p ZCB0cmFuc2FjdGlvbl9lbnRyeV9pbmMoc3RydWN0IHRyYW5zYWN0aW9uICp0 cmFucywgdW5zaWduZWQgaW50IGRvbWlkKTsKIHZvaWQgdHJhbnNhY3Rpb25f ZW50cnlfZGVjKHN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnMsIHVuc2lnbmVk IGludCBkb21pZCk7CiAKIC8qIFRoaXMgbm9kZSB3YXMgYWNjZXNzZWQuICov Ci1pbnQgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBub2RlICpub2RlLAotICAgICAgICAgICAgICAgIGVudW0gbm9kZV9h Y2Nlc3NfdHlwZSB0eXBlLCBUREJfREFUQSAqa2V5KTsKK2ludCBfX211c3Rf Y2hlY2sgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBub2RlICpub2RlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBlbnVtIG5vZGVfYWNjZXNzX3R5cGUgdHlwZSwgVERCX0RBVEEgKmtleSk7 CiAKIC8qIFF1ZXVlIHdhdGNoZXMgZm9yIGEgbW9kaWZpZWQgbm9kZS4gKi8K IHZvaWQgcXVldWVfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg Y29uc3QgY2hhciAqbmFtZSwgYm9vbCB3YXRjaF9leGFjdCk7Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-10.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-10.patch" Content-Transfer-Encoding: base64 RnJvbSA0ZTFmYzFmZWYxMWI5ZWU5ZWNjMTAwZjFhYzFhN2FiYzNjZmY4YzBh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IG1vdmUgdGhl IGNhbGwgb2Ygc2V0dXBfc3RydWN0dXJlKCkgdG8gZG9tMAogaW50cm9kdWN0 aW9uCgpTZXR0aW5nIHVwIHRoZSBiYXNpYyBzdHJ1Y3R1cmUgd2hlbiBpbnRy b2R1Y2luZyBkb20wIGhhcyB0aGUgYWR2YW50YWdlCnRvIGJlIGFibGUgdG8g YWRkIHByb3BlciBub2RlIG1lbW9yeSBhY2NvdW50aW5nIGZvciB0aGUgYWRk ZWQgbm9kZXMKbGF0ZXIuCgpUaGlzIG1ha2VzIGl0IHBvc3NpYmxlIHRvIGRv IHByb3BlciBub2RlIGFjY291bnRpbmcsIHRvby4KCkFuIGFkZGl0aW9uYWwg cmVxdWlyZW1lbnQgdG8gbWFrZSB0aGF0IHdvcmsgZmluZSBpcyB0byBjb3Jy ZWN0IHRoZQpvd25lciBvZiB0aGUgY3JlYXRlZCBub2RlcyB0byBiZSBkb20w X2RvbWlkIGluc3RlYWQgb2YgZG9taWQgMC4KClRoaXMgaXMgcGFydCBvZiBY U0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMK aW5kZXggZDRmZDAwNWY1OTlkLi44NDRhZTM5NmEwZDUgMTAwNjQ0Ci0tLSBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtMjAxOCw3ICsyMDE4LDgg QEAgc3RhdGljIGludCB0ZGJfZmxhZ3M7CiBzdGF0aWMgdm9pZCBtYW51YWxf bm9kZShjb25zdCBjaGFyICpuYW1lLCBjb25zdCBjaGFyICpjaGlsZCkKIHsK IAlzdHJ1Y3Qgbm9kZSAqbm9kZTsKLQlzdHJ1Y3QgeHNfcGVybWlzc2lvbnMg cGVybXMgPSB7IC5pZCA9IDAsIC5wZXJtcyA9IFhTX1BFUk1fTk9ORSB9Owor CXN0cnVjdCB4c19wZXJtaXNzaW9ucyBwZXJtcyA9IHsgLmlkID0gZG9tMF9k b21pZCwKKwkJCQkJLnBlcm1zID0gWFNfUEVSTV9OT05FIH07CiAKIAlub2Rl ID0gdGFsbG9jX3plcm8oTlVMTCwgc3RydWN0IG5vZGUpOwogCWlmICghbm9k ZSkKQEAgLTIwNTcsNyArMjA1OCw3IEBAIHN0YXRpYyB2b2lkIHRkYl9sb2dn ZXIoVERCX0NPTlRFWFQgKnRkYiwgaW50IGxldmVsLCBjb25zdCBjaGFyICog Zm10LCAuLi4pCiAJfQogfQogCi1zdGF0aWMgdm9pZCBzZXR1cF9zdHJ1Y3R1 cmUoYm9vbCBsaXZlX3VwZGF0ZSkKK3ZvaWQgc2V0dXBfc3RydWN0dXJlKGJv b2wgbGl2ZV91cGRhdGUpCiB7CiAJY2hhciAqdGRibmFtZTsKIApAQCAtMjA4 MCw2ICsyMDgxLDcgQEAgc3RhdGljIHZvaWQgc2V0dXBfc3RydWN0dXJlKGJv b2wgbGl2ZV91cGRhdGUpCiAJCW1hbnVhbF9ub2RlKCIvIiwgInRvb2wiKTsK IAkJbWFudWFsX25vZGUoIi90b29sIiwgInhlbnN0b3JlZCIpOwogCQltYW51 YWxfbm9kZSgiL3Rvb2wveGVuc3RvcmVkIiwgTlVMTCk7CisJCWRvbWFpbl9l bnRyeV9maXgoZG9tMF9kb21pZCwgMywgdHJ1ZSk7CiAJfQogCiAJY2hlY2tf c3RvcmUoKTsKQEAgLTI1OTgsOSArMjYwMCw2IEBAIGludCBtYWluKGludCBh cmdjLCBjaGFyICphcmd2W10pCiAKIAlpbml0X3BpcGUocmVvcGVuX2xvZ19w aXBlKTsKIAotCS8qIFNldHVwIHRoZSBkYXRhYmFzZSAqLwotCXNldHVwX3N0 cnVjdHVyZShsaXZlX3VwZGF0ZSk7Ci0KIAkvKiBMaXN0ZW4gdG8gaHlwZXJ2 aXNvci4gKi8KIAlpZiAoIW5vX2RvbWFpbl9pbml0ICYmICFsaXZlX3VwZGF0 ZSkgewogCQlkb21haW5faW5pdCgtMSk7CmRpZmYgLS1naXQgYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuaAppbmRleCA5YzU3MmEzYzZlMmEuLmE3NzJmM2I4ZWFk MiAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUu aAorKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCkBAIC0y MzEsNiArMjMxLDcgQEAgaW50IHdyaXRlX25vZGVfcmF3KHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5LCBzdHJ1Y3Qgbm9kZSAqbm9k ZSwKIHN0cnVjdCBub2RlICpyZWFkX25vZGUoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwKIAkJICAgICAgIGNvbnN0IGNoYXIg Km5hbWUpOwogCit2b2lkIHNldHVwX3N0cnVjdHVyZShib29sIGxpdmVfdXBk YXRlKTsKIHN0cnVjdCBjb25uZWN0aW9uICpuZXdfY29ubmVjdGlvbihjb25z dCBzdHJ1Y3QgaW50ZXJmYWNlX2Z1bmNzICpmdW5jcyk7CiBzdHJ1Y3QgY29u bmVjdGlvbiAqZ2V0X2Nvbm5lY3Rpb25fYnlfaWQodW5zaWduZWQgaW50IGNv bm5faWQpOwogdm9pZCBjaGVja19zdG9yZSh2b2lkKTsKZGlmZiAtLWdpdCBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYwppbmRleCA0NGNlMjY3ZWM1NTcu LjVjNzllZWQzZGMzNCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2RvbWFpbi5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9kb21haW4uYwpAQCAtNDk2LDYgKzQ5Niw5IEBAIHN0YXRpYyBzdHJ1Y3Qg ZG9tYWluICppbnRyb2R1Y2VfZG9tYWluKGNvbnN0IHZvaWQgKmN0eCwKIAkJ fQogCQlkb21haW4tPmludGVyZmFjZSA9IGludGVyZmFjZTsKIAorCQlpZiAo aXNfbWFzdGVyX2RvbWFpbikKKwkJCXNldHVwX3N0cnVjdHVyZShyZXN0b3Jl KTsKKwogCQkvKiBOb3cgZG9tYWluIGJlbG9uZ3MgdG8gaXRzIGNvbm5lY3Rp b24uICovCiAJCXRhbGxvY19zdGVhbChkb21haW4tPmNvbm4sIGRvbWFpbik7 CiAK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-11.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-11.patch" Content-Transfer-Encoding: base64 RnJvbSBmMzBlZGQ1NDUyYTMyMjZkMThmZjk4NDQxMDEzYzllODZlNGUzNGYy IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBpbmZy YXN0cnVjdHVyZSB0byBrZWVwIHRyYWNrIG9mIHBlciBkb21haW4gbWVtb3J5 CiB1c2FnZQoKVGhlIGFtb3VudCBvZiBtZW1vcnkgYSBkb21haW4gY2FuIGNv bnN1bWUgaW4gWGVuc3RvcmUgaXMgbGltaXRlZCBieQp2YXJpb3VzIHF1b3Rh IHRvZGF5LCBidXQgZXZlbiB3aXRoIHNhbmUgcXVvdGEgYSBkb21haW4gY2Fu IHN0aWxsCmNvbnN1bWUgcmF0aGVyIGxhcmdlIG1lbW9yeSBxdWFudGl0aWVz LgoKQWRkIHRoZSBpbmZyYXN0cnVjdHVyZSBmb3Iga2VlcGluZyB0cmFjayBv ZiB0aGUgYW1vdW50IG9mIG1lbW9yeSBhCmRvbWFpbiBpcyBjb25zdW1pbmcg aW4gWGVuc3RvcmUuIE5vdGUgdGhhdCB0aGlzIGlzIG9ubHkgdGhlIG1lbW9y eSBhCmRvbWFpbiBoYXMgZGlyZWN0IGNvbnRyb2wgb3Zlciwgc28gYW55IGlu dGVybmFsIGFkbWluaXN0cmF0aW9uIGRhdGEKbmVlZGVkIGJ5IFhlbnN0b3Jl IG9ubHkgaXMgbm90IGJlaW5nIGFjY291bnRlZCBmb3IuCgpUaGVyZSBhcmUg dHdvIHF1b3RhcyBkZWZpbmVkOiBhIHNvZnQgcXVvdGEgd2hpY2ggd2lsbCBy ZXN1bHQgaW4gYQp3YXJuaW5nIGlzc3VlZCB2aWEgc3lzbG9nKCkgd2hlbiBp dCBpcyBleGNlZWRlZCwgYW5kIGEgaGFyZCBxdW90YQpyZXN1bHRpbmcgaW4g YSBzdG9wIG9mIGFjY2VwdGluZyBmdXJ0aGVyIHJlcXVlc3RzIG9yIHdhdGNo IGV2ZW50cyBhcwpsb25nIGFzIHRoZSBoYXJkIHF1b3RhIHdvdWxkIGJlIHZp b2xhdGVkIGJ5IGFjY2VwdGluZyB0aG9zZS4KClNldHRpbmcgYW55IG9mIHRo b3NlIHF1b3RhcyB0byAwIHdpbGwgZGlzYWJsZSBpdC4KCkFzIGRlZmF1bHQg dmFsdWVzIHVzZSAyTUIgcGVyIGRvbWFpbiBmb3IgdGhlIHNvZnQgbGltaXQg KHRoaXMgYmFzaWNhbGx5CmNvdmVycyB0aGUgYWxsb3dlZCBjYXNlIHRvIGNy ZWF0ZSAxMDAwIG5vZGVzIG5lZWRpbmcgMmtCIGVhY2gpLCBhbmQKMi41TUIg Zm9yIHRoZSBoYXJkIGxpbWl0LgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zMjYu CgpSZXBvcnRlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNv bT4KU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u LmNvbT4KCmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwppbmRl eCA4NDRhZTM5NmEwZDUuLmYwM2FkOTNiNDM4NSAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYworKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCkBAIC0xMDksNiArMTA5LDggQEAgaW50 IHF1b3RhX25iX3Blcm1zX3Blcl9ub2RlID0gNTsKIGludCBxdW90YV90cmFu c19ub2RlcyA9IDEwMjQ7CiBpbnQgcXVvdGFfbWF4X3BhdGhfbGVuID0gWEVO U1RPUkVfUkVMX1BBVEhfTUFYOwogaW50IHF1b3RhX3JlcV9vdXRzdGFuZGlu ZyA9IDIwOworaW50IHF1b3RhX21lbW9yeV9wZXJfZG9tYWluX3NvZnQgPSAy ICogMTAyNCAqIDEwMjQ7IC8qIDIgTUIgKi8KK2ludCBxdW90YV9tZW1vcnlf cGVyX2RvbWFpbl9oYXJkID0gMiAqIDEwMjQgKiAxMDI0ICsgNTEyICogMTAy NDsgLyogMi41IE1CICovCiAKIHVuc2lnbmVkIGludCB0aW1lb3V0X3dhdGNo X2V2ZW50X21zZWMgPSAyMDAwMDsKIApAQCAtMjM5MCw3ICsyMzkyLDE0IEBA IHN0YXRpYyB2b2lkIHVzYWdlKHZvaWQpCiAiICAgICAgICAgICAgICAgICAg ICAgICAgICBxdW90YXMgYXJlOlxuIgogIiAgICAgICAgICAgICAgICAgICAg ICAgICAgdHJhbnNhY3Rpb24tbm9kZXM6IG51bWJlciBvZiBhY2Nlc3NlZCBu b2RlIHBlclxuIgogIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHRyYW5zYWN0aW9uXG4iCisiICAgICAgICAgICAgICAg ICAgICAgICAgICBtZW1vcnk6IHRvdGFsIHVzZWQgbWVtb3J5IHBlciBkb21h aW4gZm9yIG5vZGVzLFxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB0cmFuc2FjdGlvbnMsIHdhdGNoZXMgYW5kIHJlcXVlc3RzLCBh Ym92ZVxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3 aGljaCBYZW5zdG9yZSB3aWxsIHN0b3AgdGFsa2luZyB0byBkb21haW5cbiIK ICIgICAgICAgICAgICAgICAgICAgICAgICAgIG91dHN0YW5kaW5nOiBudW1i ZXIgb2Ygb3V0c3RhbmRpbmcgcmVxdWVzdHNcbiIKKyIgIC1xLCAtLXF1b3Rh LXNvZnQgPHdoYXQ+PTxuYj4gc2V0IGEgc29mdCBxdW90YSA8d2hhdD4gdG8g dGhlIHZhbHVlIDxuYj4sXG4iCisiICAgICAgICAgICAgICAgICAgICAgICAg ICBjYXVzaW5nIGEgd2FybmluZyB0byBiZSBpc3N1ZWQgdmlhIHN5c2xvZygp IGlmIHRoZVxuIgorIiAgICAgICAgICAgICAgICAgICAgICAgICAgbGltaXQg aXMgdmlvbGF0ZWQsIGFsbG93ZWQgcXVvdGFzIGFyZTpcbiIKKyIgICAgICAg ICAgICAgICAgICAgICAgICAgIG1lbW9yeTogc2VlIGFib3ZlXG4iCiAiICAt dywgLS10aW1lb3V0IDx3aGF0Pj08c2Vjb25kcz4gICBzZXQgdGhlIHRpbWVv dXQgaW4gc2Vjb25kcyBmb3IgPHdoYXQ+LFxuIgogIiAgICAgICAgICAgICAg ICAgICAgICAgICAgYWxsb3dlZCB0aW1lb3V0IGNhbmRpZGF0ZXMgYXJlOlxu IgogIiAgICAgICAgICAgICAgICAgICAgICAgICAgd2F0Y2gtZXZlbnQ6IHRp bWUgYSB3YXRjaC1ldmVudCBpcyBrZXB0IHBlbmRpbmdcbiIKQEAgLTI0MTcs NiArMjQyNiw3IEBAIHN0YXRpYyBzdHJ1Y3Qgb3B0aW9uIG9wdGlvbnNbXSA9 IHsKIAl7ICJwZXJtLW5iIiwgMSwgTlVMTCwgJ0EnIH0sCiAJeyAicGF0aC1t YXgiLCAxLCBOVUxMLCAnTScgfSwKIAl7ICJxdW90YSIsIDEsIE5VTEwsICdR JyB9LAorCXsgInF1b3RhLXNvZnQiLCAxLCBOVUxMLCAncScgfSwKIAl7ICJ0 aW1lb3V0IiwgMSwgTlVMTCwgJ3cnIH0sCiAJeyAibm8tcmVjb3ZlcnkiLCAw LCBOVUxMLCAnUicgfSwKIAl7ICJpbnRlcm5hbC1kYiIsIDAsIE5VTEwsICdJ JyB9LApAQCAtMjQ2NCw3ICsyNDc0LDcgQEAgc3RhdGljIHZvaWQgc2V0X3Rp bWVvdXQoY29uc3QgY2hhciAqYXJnKQogCQliYXJmKCJ1bmtub3duIHRpbWVv dXQgXCIlc1wiXG4iLCBhcmcpOwogfQogCi1zdGF0aWMgdm9pZCBzZXRfcXVv dGEoY29uc3QgY2hhciAqYXJnKQorc3RhdGljIHZvaWQgc2V0X3F1b3RhKGNv bnN0IGNoYXIgKmFyZywgYm9vbCBzb2Z0KQogewogCWNvbnN0IGNoYXIgKmVx ID0gc3RyY2hyKGFyZywgJz0nKTsKIAlpbnQgdmFsOwpAQCAtMjQ3MiwxMSAr MjQ4MiwxNiBAQCBzdGF0aWMgdm9pZCBzZXRfcXVvdGEoY29uc3QgY2hhciAq YXJnKQogCWlmICghZXEpCiAJCWJhcmYoInF1b3RhcyBtdXN0IGJlIHNwZWNp ZmllZCB2aWEgPHdoYXQ+PTxuYj5cbiIpOwogCXZhbCA9IGdldF9vcHR2YWxf aW50KGVxICsgMSk7Ci0JaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJvdXRzdGFu ZGluZyIpKQorCWlmICh3aGF0X21hdGNoZXMoYXJnLCAib3V0c3RhbmRpbmci KSAmJiAhc29mdCkKIAkJcXVvdGFfcmVxX291dHN0YW5kaW5nID0gdmFsOwot CWVsc2UgaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJ0cmFuc2FjdGlvbi1ub2Rl cyIpKQorCWVsc2UgaWYgKHdoYXRfbWF0Y2hlcyhhcmcsICJ0cmFuc2FjdGlv bi1ub2RlcyIpICYmICFzb2Z0KQogCQlxdW90YV90cmFuc19ub2RlcyA9IHZh bDsKLQllbHNlCisJZWxzZSBpZiAod2hhdF9tYXRjaGVzKGFyZywgIm1lbW9y eSIpKSB7CisJCWlmIChzb2Z0KQorCQkJcXVvdGFfbWVtb3J5X3Blcl9kb21h aW5fc29mdCA9IHZhbDsKKwkJZWxzZQorCQkJcXVvdGFfbWVtb3J5X3Blcl9k b21haW5faGFyZCA9IHZhbDsKKwl9IGVsc2UKIAkJYmFyZigidW5rbm93biBx dW90YSBcIiVzXCJcbiIsIGFyZyk7CiB9CiAKQEAgLTI0OTQsNyArMjUwOSw3 IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAJb3JpZ19h cmdjID0gYXJnYzsKIAlvcmlnX2FyZ3YgPSBhcmd2OwogCi0Jd2hpbGUgKChv cHQgPSBnZXRvcHRfbG9uZyhhcmdjLCBhcmd2LCAiREU6RjpITlBTOnQ6QTpN OlE6VDpSVlc6dzpVIiwKKwl3aGlsZSAoKG9wdCA9IGdldG9wdF9sb25nKGFy Z2MsIGFyZ3YsICJERTpGOkhOUFM6dDpBOk06UTpxOlQ6UlZXOnc6VSIsCiAJ CQkJICBvcHRpb25zLCBOVUxMKSkgIT0gLTEpIHsKIAkJc3dpdGNoIChvcHQp IHsKIAkJY2FzZSAnRCc6CkBAIC0yNTQ1LDcgKzI1NjAsMTAgQEAgaW50IG1h aW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAkJCQkJCSBxdW90YV9tYXhf cGF0aF9sZW4pOwogCQkJYnJlYWs7CiAJCWNhc2UgJ1EnOgotCQkJc2V0X3F1 b3RhKG9wdGFyZyk7CisJCQlzZXRfcXVvdGEob3B0YXJnLCBmYWxzZSk7CisJ CQlicmVhazsKKwkJY2FzZSAncSc6CisJCQlzZXRfcXVvdGEob3B0YXJnLCB0 cnVlKTsKIAkJCWJyZWFrOwogCQljYXNlICd3JzoKIAkJCXNldF90aW1lb3V0 KG9wdGFyZyk7CmRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApp bmRleCBhNzcyZjNiOGVhZDIuLmVjNTJkOGQzZmYwMyAxMDA2NDQKLS0tIGEv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaAorKysgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oCkBAIC0yNjgsNiArMjY4LDggQEAg ZXh0ZXJuIGludCBwcml2X2RvbWlkOwogZXh0ZXJuIGludCBxdW90YV9uYl9l bnRyeV9wZXJfZG9tYWluOwogZXh0ZXJuIGludCBxdW90YV9yZXFfb3V0c3Rh bmRpbmc7CiBleHRlcm4gaW50IHF1b3RhX3RyYW5zX25vZGVzOworZXh0ZXJu IGludCBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9zb2Z0OworZXh0ZXJuIGlu dCBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9oYXJkOwogCiBleHRlcm4gdW5z aWduZWQgaW50IHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYzsKIApkaWZmIC0t Z2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IDVjNzllZWQz ZGMzNC4uNDI0MjM4MDg4NjNmIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2RvbWFpbi5jCkBAIC03Niw2ICs3NiwxMyBAQCBzdHJ1Y3QgZG9t YWluCiAJLyogbnVtYmVyIG9mIGVudHJ5IGZyb20gdGhpcyBkb21haW4gaW4g dGhlIHN0b3JlICovCiAJaW50IG5iZW50cnk7CiAKKwkvKiBBbW91bnQgb2Yg bWVtb3J5IGFsbG9jYXRlZCBmb3IgdGhpcyBkb21haW4uICovCisJaW50IG1l bW9yeTsKKwlib29sIHNvZnRfcXVvdGFfcmVwb3J0ZWQ7CisJYm9vbCBoYXJk X3F1b3RhX3JlcG9ydGVkOworCXRpbWVfdCBtZW1fbGFzdF9tc2c7CisjZGVm aW5lIE1FTV9XQVJOX01JTlRJTUVfU0VDIDEwCisKIAkvKiBudW1iZXIgb2Yg d2F0Y2ggZm9yIHRoaXMgZG9tYWluICovCiAJaW50IG5id2F0Y2g7CiAKQEAg LTE5Miw2ICsxOTksOSBAQCBzdGF0aWMgYm9vbCBkb21haW5fY2FuX3JlYWQo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pCiAJCQlyZXR1cm4gZmFsc2U7CiAJ CWlmIChjb25uLT5kb21haW4tPm5ib3V0c3RhbmRpbmcgPj0gcXVvdGFfcmVx X291dHN0YW5kaW5nKQogCQkJcmV0dXJuIGZhbHNlOworCQlpZiAoY29ubi0+ ZG9tYWluLT5tZW1vcnkgPj0gcXVvdGFfbWVtb3J5X3Blcl9kb21haW5faGFy ZCAmJgorCQkgICAgcXVvdGFfbWVtb3J5X3Blcl9kb21haW5faGFyZCkKKwkJ CXJldHVybiBmYWxzZTsKIAl9CiAKIAlyZXR1cm4gKGludGYtPnJlcV9jb25z ICE9IGludGYtPnJlcV9wcm9kKTsKQEAgLTk4Miw2ICs5OTIsODkgQEAgaW50 IGRvbWFpbl9lbnRyeShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubikKIAkJOiAw OwogfQogCitzdGF0aWMgYm9vbCBkb21haW5fY2hrX3F1b3RhKHN0cnVjdCBk b21haW4gKmRvbWFpbiwgaW50IG1lbSkKK3sKKwl0aW1lX3Qgbm93OworCisJ aWYgKCFkb21haW4gfHwgIWRvbWlkX2lzX3VucHJpdmlsZWdlZChkb21haW4t PmRvbWlkKSB8fAorCSAgICAoZG9tYWluLT5jb25uICYmIGRvbWFpbi0+Y29u bi0+aXNfaWdub3JlZCkpCisJCXJldHVybiBmYWxzZTsKKworCW5vdyA9IHRp bWUoTlVMTCk7CisKKwlpZiAobWVtID49IHF1b3RhX21lbW9yeV9wZXJfZG9t YWluX2hhcmQgJiYKKwkgICAgcXVvdGFfbWVtb3J5X3Blcl9kb21haW5faGFy ZCkgeworCQlpZiAoZG9tYWluLT5oYXJkX3F1b3RhX3JlcG9ydGVkKQorCQkJ cmV0dXJuIHRydWU7CisJCXN5c2xvZyhMT0dfRVJSLCAiRG9tYWluICV1IGV4 Y2VlZHMgaGFyZCBtZW1vcnkgcXVvdGEsIFhlbnN0b3JlIGludGVyZmFjZSB0 byBkb21haW4gc3RhbGxlZFxuIiwKKwkJICAgICAgIGRvbWFpbi0+ZG9taWQp OworCQlkb21haW4tPm1lbV9sYXN0X21zZyA9IG5vdzsKKwkJZG9tYWluLT5o YXJkX3F1b3RhX3JlcG9ydGVkID0gdHJ1ZTsKKwkJcmV0dXJuIHRydWU7CisJ fQorCisJaWYgKG5vdyAtIGRvbWFpbi0+bWVtX2xhc3RfbXNnID49IE1FTV9X QVJOX01JTlRJTUVfU0VDKSB7CisJCWlmIChkb21haW4tPmhhcmRfcXVvdGFf cmVwb3J0ZWQpIHsKKwkJCWRvbWFpbi0+bWVtX2xhc3RfbXNnID0gbm93Owor CQkJZG9tYWluLT5oYXJkX3F1b3RhX3JlcG9ydGVkID0gZmFsc2U7CisJCQlz eXNsb2coTE9HX0lORk8sICJEb21haW4gJXUgYmVsb3cgaGFyZCBtZW1vcnkg cXVvdGEgYWdhaW5cbiIsCisJCQkgICAgICAgZG9tYWluLT5kb21pZCk7CisJ CX0KKwkJaWYgKG1lbSA+PSBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9zb2Z0 ICYmCisJCSAgICBxdW90YV9tZW1vcnlfcGVyX2RvbWFpbl9zb2Z0ICYmCisJ CSAgICAhZG9tYWluLT5zb2Z0X3F1b3RhX3JlcG9ydGVkKSB7CisJCQlkb21h aW4tPm1lbV9sYXN0X21zZyA9IG5vdzsKKwkJCWRvbWFpbi0+c29mdF9xdW90 YV9yZXBvcnRlZCA9IHRydWU7CisJCQlzeXNsb2coTE9HX1dBUk5JTkcsICJE b21haW4gJXUgZXhjZWVkcyBzb2Z0IG1lbW9yeSBxdW90YVxuIiwKKwkJCSAg ICAgICBkb21haW4tPmRvbWlkKTsKKwkJfQorCQlpZiAobWVtIDwgcXVvdGFf bWVtb3J5X3Blcl9kb21haW5fc29mdCAmJgorCQkgICAgZG9tYWluLT5zb2Z0 X3F1b3RhX3JlcG9ydGVkKSB7CisJCQlkb21haW4tPm1lbV9sYXN0X21zZyA9 IG5vdzsKKwkJCWRvbWFpbi0+c29mdF9xdW90YV9yZXBvcnRlZCA9IGZhbHNl OworCQkJc3lzbG9nKExPR19JTkZPLCAiRG9tYWluICV1IGJlbG93IHNvZnQg bWVtb3J5IHF1b3RhIGFnYWluXG4iLAorCQkJICAgICAgIGRvbWFpbi0+ZG9t aWQpOworCQl9CisKKwl9CisKKwlyZXR1cm4gZmFsc2U7Cit9CisKK2ludCBk b21haW5fbWVtb3J5X2FkZCh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBtZW0s IGJvb2wgbm9fcXVvdGFfY2hlY2spCit7CisJc3RydWN0IGRvbWFpbiAqZG9t YWluOworCisJZG9tYWluID0gZmluZF9kb21haW5fc3RydWN0KGRvbWlkKTsK KwlpZiAoZG9tYWluKSB7CisJCS8qCisJCSAqIGRvbWFpbl9jaGtfcXVvdGEo KSB3aWxsIHByaW50IHdhcm5pbmcgYW5kIGFsc28gc3RvcmUgd2hldGhlcgor CQkgKiB0aGUgc29mdC9oYXJkIHF1b3RhIGhhcyBiZWVuIGhpdC4gU28gY2hl Y2sgbm9fcXVvdGFfY2hlY2sKKwkJICogKmFmdGVyKi4KKwkJICovCisJCWlm IChkb21haW5fY2hrX3F1b3RhKGRvbWFpbiwgZG9tYWluLT5tZW1vcnkgKyBt ZW0pICYmCisJCSAgICAhbm9fcXVvdGFfY2hlY2spCisJCQlyZXR1cm4gRU5P TUVNOworCQlkb21haW4tPm1lbW9yeSArPSBtZW07CisJfSBlbHNlIHsKKwkJ LyoKKwkJICogVGhlIGRvbWFpbiB0aGUgbWVtb3J5IGlzIHRvIGJlIGFjY291 bnRlZCBmb3Igc2hvdWxkIGFsd2F5cworCQkgKiBleGlzdCwgYXMgYWNjb3Vu dGluZyBpcyBkb25lIGVpdGhlciBmb3IgYSBkb21haW4gcmVsYXRlZCB0bwor CQkgKiB0aGUgY3VycmVudCBjb25uZWN0aW9uLCBvciBmb3IgdGhlIGRvbWFp biBvd25pbmcgYSBub2RlCisJCSAqICh3aGljaCBpcyBhbHdheXMgZXhpc3Rp bmcsIGFzIHRoZSBvd25lciBvZiB0aGUgbm9kZSBpcworCQkgKiB0ZXN0ZWQg dG8gZXhpc3QgYW5kIHJlcGxhY2VkIGJ5IGRvbWlkIDAgaWYgbm90KS4KKwkJ ICogU28gbm90IGZpbmRpbmcgdGhlIHJlbGF0ZWQgZG9tYWluIE1VU1QgYmUg YW4gZXJyb3IgaW4gdGhlCisJCSAqIGRhdGEgYmFzZS4KKwkJICovCisJCWVy cm5vID0gRU5PRU5UOworCQljb3JydXB0KE5VTEwsICJBY2NvdW50aW5nIGNh bGxlZCBmb3Igbm9uLWV4aXN0aW5nIGRvbWFpbiAldVxuIiwKKwkJCWRvbWlk KTsKKwkJcmV0dXJuIEVOT0VOVDsKKwl9CisKKwlyZXR1cm4gMDsKK30KKwog dm9pZCBkb21haW5fd2F0Y2hfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25u KQogewogCWlmICghY29ubiB8fCAhY29ubi0+ZG9tYWluKQpkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oIGIvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oCmluZGV4IDU5Mzc5MzEzMTQ5 NC4uZDM0MmU1ZTg2N2VkIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfZG9tYWluLmgKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2RvbWFpbi5oCkBAIC02Miw2ICs2MiwyNiBAQCBpbnQgZG9tYWluX2Vu dHJ5X2luYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUg Kik7CiB2b2lkIGRvbWFpbl9lbnRyeV9kZWMoc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sIHN0cnVjdCBub2RlICopOwogaW50IGRvbWFpbl9lbnRyeV9maXgo dW5zaWduZWQgaW50IGRvbWlkLCBpbnQgbnVtLCBib29sIHVwZGF0ZSk7CiBp bnQgZG9tYWluX2VudHJ5KHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsKK2lu dCBkb21haW5fbWVtb3J5X2FkZCh1bnNpZ25lZCBpbnQgZG9taWQsIGludCBt ZW0sIGJvb2wgbm9fcXVvdGFfY2hlY2spOworCisvKgorICogZG9tYWluX21l bW9yeV9hZGRfY2hrKCk6IHRvIGJlIHVzZWQgd2hlbiBtZW1vcnkgcXVvdGEg c2hvdWxkIGJlIGNoZWNrZWQuCisgKiBOb3QgdG8gYmUgdXNlZCB3aGVuIHNw ZWNpZnlpbmcgYSBuZWdhdGl2ZSBtZW0gdmFsdWUsIGFzIGxvd2VyaW5nIHRo ZSB1c2VkCisgKiBtZW1vcnkgc2hvdWxkIGFsd2F5cyBiZSBhbGxvd2VkLgor ICovCitzdGF0aWMgaW5saW5lIGludCBkb21haW5fbWVtb3J5X2FkZF9jaGso dW5zaWduZWQgaW50IGRvbWlkLCBpbnQgbWVtKQoreworCXJldHVybiBkb21h aW5fbWVtb3J5X2FkZChkb21pZCwgbWVtLCBmYWxzZSk7Cit9CisvKgorICog ZG9tYWluX21lbW9yeV9hZGRfbm9jaGsoKTogdG8gYmUgdXNlZCB3aGVuIG1l bW9yeSBxdW90YSBzaG91bGQgbm90IGJlCisgKiBjaGVja2VkLCBlLmcuIHdo ZW4gbG93ZXJpbmcgbWVtb3J5IHVzYWdlLCBvciBpbiBhbiBlcnJvciBjYXNl IGZvciB1bmRvaW5nCisgKiBhIHByZXZpb3VzIG1lbW9yeSBhZGp1c3RtZW50 LgorICovCitzdGF0aWMgaW5saW5lIHZvaWQgZG9tYWluX21lbW9yeV9hZGRf bm9jaGsodW5zaWduZWQgaW50IGRvbWlkLCBpbnQgbWVtKQoreworCWRvbWFp bl9tZW1vcnlfYWRkKGRvbWlkLCBtZW0sIHRydWUpOworfQogdm9pZCBkb21h aW5fd2F0Y2hfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsKIHZvaWQg ZG9tYWluX3dhdGNoX2RlYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7CiBp bnQgZG9tYWluX3dhdGNoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsK --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-12.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-12.patch" Content-Transfer-Encoding: base64 RnJvbSA4MzU2ZmI1MWM5OTkzYTYyNzZhZjI1ZGUzZDE4M2E5NzJjYjljNDlh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MDkgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3IgcmVzcG9uc2VzCgpBZGQgdGhlIG1lbW9yeSBh Y2NvdW50aW5nIGZvciBxdWV1ZWQgcmVzcG9uc2VzLgoKSW4gY2FzZSBhZGRp bmcgYSB3YXRjaCBldmVudCBmb3IgYSBndWVzdCBpcyBjYXVzaW5nIHRoZSBo YXJkIG1lbW9yeQpxdW90YSBvZiB0aGF0IGd1ZXN0IHRvIGJlIHZpb2xhdGVk LCB0aGUgZXZlbnQgaXMgZHJvcHBlZC4gVGhpcyB3aWxsCmVuc3VyZSB0aGF0 IGl0IGlzIGltcG9zc2libGUgdG8gZHJpdmUgYW5vdGhlciBndWVzdCBwYXN0 IGl0cyBtZW1vcnkKcXVvdGEgYnkgZ2VuZXJhdGluZyBpbnNhbmUgYW1vdW50 cyBvZiBldmVudHMgZm9yIHRoYXQgZ3Vlc3QuIFRoaXMgaXMKZXNwZWNpYWxs eSBpbXBvcnRhbnQgZm9yIHByb3RlY3RpbmcgZHJpdmVyIGRvbWFpbnMgZnJv bSB0aGF0IGF0dGFjawp2ZWN0b3IuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMy NiAvIENWRS0yMDIyLTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4g R3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hl bnN0b3JlZF9jb3JlLmMKaW5kZXggZjAzYWQ5M2I0Mzg1Li4wMDllYWE4ZTVm NTMgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAt MjU2LDYgKzI1Niw4IEBAIHN0YXRpYyB2b2lkIGZyZWVfYnVmZmVyZWRfZGF0 YShzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqb3V0LAogCQl9CiAJfQogCisJZG9t YWluX21lbW9yeV9hZGRfbm9jaGsoY29ubi0+aWQsIC1vdXQtPmhkci5tc2cu bGVuIC0gc2l6ZW9mKG91dC0+aGRyKSk7CisKIAlpZiAob3V0LT5oZHIubXNn LnR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQpIHsKIAkJcmVxID0gb3V0LT5wZW5k LnJlcTsKIAkJaWYgKHJlcSkgewpAQCAtOTM0LDExICs5MzYsMTQgQEAgdm9p ZCBzZW5kX3JlcGx5KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBlbnVtIHhz ZF9zb2NrbXNnX3R5cGUgdHlwZSwKIAliZGF0YS0+dGltZW91dF9tc2VjID0g MDsKIAliZGF0YS0+d2F0Y2hfZXZlbnQgPSBmYWxzZTsKIAotCWlmIChsZW4g PD0gREVGQVVMVF9CVUZGRVJfU0laRSkKKwlpZiAobGVuIDw9IERFRkFVTFRf QlVGRkVSX1NJWkUpIHsKIAkJYmRhdGEtPmJ1ZmZlciA9IGJkYXRhLT5kZWZh dWx0X2J1ZmZlcjsKLQllbHNlIHsKKwkJLyogRG9uJ3QgY2hlY2sgcXVvdGEs IHBhdGggbWlnaHQgYmUgdXNlZCBmb3IgcmV0dXJuaW5nIGVycm9yLiAqLwor CQlkb21haW5fbWVtb3J5X2FkZF9ub2Noayhjb25uLT5pZCwgbGVuICsgc2l6 ZW9mKGJkYXRhLT5oZHIpKTsKKwl9IGVsc2UgewogCQliZGF0YS0+YnVmZmVy ID0gdGFsbG9jX2FycmF5KGJkYXRhLCBjaGFyLCBsZW4pOwotCQlpZiAoIWJk YXRhLT5idWZmZXIpIHsKKwkJaWYgKCFiZGF0YS0+YnVmZmVyIHx8CisJCSAg ICBkb21haW5fbWVtb3J5X2FkZF9jaGsoY29ubi0+aWQsIGxlbiArIHNpemVv ZihiZGF0YS0+aGRyKSkpIHsKIAkJCXNlbmRfZXJyb3IoY29ubiwgRU5PTUVN KTsKIAkJCXJldHVybjsKIAkJfQpAQCAtMTAwMyw2ICsxMDA4LDExIEBAIHZv aWQgc2VuZF9ldmVudChzdHJ1Y3QgYnVmZmVyZWRfZGF0YSAqcmVxLCBzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJfQogCX0KIAorCWlmIChkb21haW5f bWVtb3J5X2FkZF9jaGsoY29ubi0+aWQsIGxlbiArIHNpemVvZihiZGF0YS0+ aGRyKSkpIHsKKwkJdGFsbG9jX2ZyZWUoYmRhdGEpOworCQlyZXR1cm47CisJ fQorCiAJaWYgKHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNlYyAmJiBkb21haW5f aXNfdW5wcml2aWxlZ2VkKGNvbm4pKSB7CiAJCWJkYXRhLT50aW1lb3V0X21z ZWMgPSBnZXRfbm93X21zZWMoKSArIHRpbWVvdXRfd2F0Y2hfZXZlbnRfbXNl YzsKIAkJaWYgKCFjb25uLT50aW1lb3V0X21zZWMpCkBAIC0zMDEyLDYgKzMw MjIsMTIgQEAgc3RhdGljIHZvaWQgYWRkX2J1ZmZlcmVkX2RhdGEoc3RydWN0 IGJ1ZmZlcmVkX2RhdGEgKmJkYXRhLAogCSAqLwogCWlmIChiZGF0YS0+aGRy Lm1zZy50eXBlICE9IFhTX1dBVENIX0VWRU5UKQogCQlkb21haW5fb3V0c3Rh bmRpbmdfaW5jKGNvbm4pOworCS8qCisJICogV2UgYXJlIHJlc3RvcmluZyB0 aGUgc3RhdGUgYWZ0ZXIgTGl2ZS1VcGRhdGUgYW5kIHRoZSBuZXcgcXVvdGEg bWF5CisJICogYmUgc21hbGxlci4gU28gaWdub3JlIGl0LiBUaGUgbGltaXQg d2lsbCBiZSBhcHBsaWVkIGZvciBhbnkgcmVzb3VyY2UKKwkgKiBhZnRlciB0 aGUgc3RhdGUgaGFzIGJlZW4gZnVsbHkgcmVzdG9yZWQuCisJICovCisJZG9t YWluX21lbW9yeV9hZGRfbm9jaGsoY29ubi0+aWQsIGxlbiArIHNpemVvZihi ZGF0YS0+aGRyKSk7CiB9CiAKIHZvaWQgcmVhZF9zdGF0ZV9idWZmZXJlZF9k YXRhKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s Cg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-13.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-13.patch" Content-Transfer-Encoding: base64 RnJvbSAwZjU3NmYzMzc2YjM4Mjk4MjM0Y2M3NGEzNzJmMGJiMmVhMTg2YTMw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3Igd2F0Y2hlcwoKQWRkIHRoZSBtZW1vcnkgYWNj b3VudGluZyBmb3IgcmVnaXN0ZXJlZCB3YXRjaGVzLgoKV2hlbiBhIHNvY2tl dCBjb25uZWN0aW9uIGlzIGRlc3Ryb3llZCwgdGhlIGFzc29jaWF0ZWQgd2F0 Y2hlcyBhcmUKcmVtb3ZlZCwgdG9vLiBJbiBvcmRlciB0byBrZWVwIG1lbW9y eSBhY2NvdW50aW5nIGNvcnJlY3QgdGhlIHdhdGNoZXMKbXVzdCBiZSByZW1v dmVkIGV4cGxpY2l0bHkgdmlhIGEgY2FsbCBvZiBjb25uX2RlbGV0ZV9hbGxf d2F0Y2hlcygpIGZyb20KZGVzdHJveV9jb25uKCkuCgpUaGlzIGlzIHBhcnQg b2YgWFNBLTMyNiAvIENWRS0yMDIyLTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1 bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6 IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6 IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKaW5kZXggMDA5ZWFhOGU1ZjUzLi4x YTViYTRhYmE4MzkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF9jb3JlLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuYwpAQCAtNDU5LDYgKzQ1OSw3IEBAIHN0YXRpYyBpbnQgZGVzdHJveV9j b25uKHZvaWQgKl9jb25uKQogCX0KIAogCWNvbm5fZnJlZV9idWZmZXJlZF9k YXRhKGNvbm4pOworCWNvbm5fZGVsZXRlX2FsbF93YXRjaGVzKGNvbm4pOwog CWxpc3RfZm9yX2VhY2hfZW50cnkocmVxLCAmY29ubi0+cmVmX2xpc3QsIGxp c3QpCiAJCXJlcS0+b25fcmVmX2xpc3QgPSBmYWxzZTsKIApkaWZmIC0tZ2l0 IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmMgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYwppbmRleCAwNzU1ZmZhMzc1YmEu LmZkZjliMmQ2NTNhMCAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX3dhdGNoLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X3dhdGNoLmMKQEAgLTIxMSw3ICsyMTEsNyBAQCBzdGF0aWMgaW50IGNoZWNr X3dhdGNoX3BhdGgoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZv aWQgKmN0eCwKIH0KIAogc3RhdGljIHN0cnVjdCB3YXRjaCAqYWRkX3dhdGNo KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjaGFyICpwYXRoLCBjaGFyICp0 b2tlbiwKLQkJCSAgICAgICBib29sIHJlbGF0aXZlKQorCQkJICAgICAgIGJv b2wgcmVsYXRpdmUsIGJvb2wgbm9fcXVvdGFfY2hlY2spCiB7CiAJc3RydWN0 IHdhdGNoICp3YXRjaDsKIApAQCAtMjIyLDYgKzIyMiw5IEBAIHN0YXRpYyBz dHJ1Y3Qgd2F0Y2ggKmFkZF93YXRjaChzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgY2hhciAqcGF0aCwgY2hhciAqdG9rZW4sCiAJd2F0Y2gtPnRva2VuID0g dGFsbG9jX3N0cmR1cCh3YXRjaCwgdG9rZW4pOwogCWlmICghd2F0Y2gtPm5v ZGUgfHwgIXdhdGNoLT50b2tlbikKIAkJZ290byBub21lbTsKKwlpZiAoZG9t YWluX21lbW9yeV9hZGQoY29ubi0+aWQsIHN0cmxlbihwYXRoKSArIHN0cmxl bih0b2tlbiksCisJCQkgICAgICBub19xdW90YV9jaGVjaykpCisJCWdvdG8g bm9tZW07CiAKIAlpZiAocmVsYXRpdmUpCiAJCXdhdGNoLT5yZWxhdGl2ZV9w YXRoID0gZ2V0X2ltcGxpY2l0X3BhdGgoY29ubik7CkBAIC0yNjUsNyArMjY4 LDcgQEAgaW50IGRvX3dhdGNoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBz dHJ1Y3QgYnVmZmVyZWRfZGF0YSAqaW4pCiAJaWYgKGRvbWFpbl93YXRjaChj b25uKSA+IHF1b3RhX25iX3dhdGNoX3Blcl9kb21haW4pCiAJCXJldHVybiBF MkJJRzsKIAotCXdhdGNoID0gYWRkX3dhdGNoKGNvbm4sIHZlY1swXSwgdmVj WzFdLCByZWxhdGl2ZSk7CisJd2F0Y2ggPSBhZGRfd2F0Y2goY29ubiwgdmVj WzBdLCB2ZWNbMV0sIHJlbGF0aXZlLCBmYWxzZSk7CiAJaWYgKCF3YXRjaCkK IAkJcmV0dXJuIGVycm5vOwogCkBAIC0yOTYsNiArMjk5LDggQEAgaW50IGRv X3Vud2F0Y2goc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZm ZXJlZF9kYXRhICppbikKIAlsaXN0X2Zvcl9lYWNoX2VudHJ5KHdhdGNoLCAm Y29ubi0+d2F0Y2hlcywgbGlzdCkgewogCQlpZiAoc3RyZXEod2F0Y2gtPm5v ZGUsIG5vZGUpICYmIHN0cmVxKHdhdGNoLT50b2tlbiwgdmVjWzFdKSkgewog CQkJbGlzdF9kZWwoJndhdGNoLT5saXN0KTsKKwkJCWRvbWFpbl9tZW1vcnlf YWRkX25vY2hrKGNvbm4tPmlkLCAtc3RybGVuKHdhdGNoLT5ub2RlKSAtCisJ CQkJCQkJICBzdHJsZW4od2F0Y2gtPnRva2VuKSk7CiAJCQl0YWxsb2NfZnJl ZSh3YXRjaCk7CiAJCQlkb21haW5fd2F0Y2hfZGVjKGNvbm4pOwogCQkJc2Vu ZF9hY2soY29ubiwgWFNfVU5XQVRDSCk7CkBAIC0zMTEsNiArMzE2LDggQEAg dm9pZCBjb25uX2RlbGV0ZV9hbGxfd2F0Y2hlcyhzdHJ1Y3QgY29ubmVjdGlv biAqY29ubikKIAogCXdoaWxlICgod2F0Y2ggPSBsaXN0X3RvcCgmY29ubi0+ d2F0Y2hlcywgc3RydWN0IHdhdGNoLCBsaXN0KSkpIHsKIAkJbGlzdF9kZWwo JndhdGNoLT5saXN0KTsKKwkJZG9tYWluX21lbW9yeV9hZGRfbm9jaGsoY29u bi0+aWQsIC1zdHJsZW4od2F0Y2gtPm5vZGUpIC0KKwkJCQkJCSAgc3RybGVu KHdhdGNoLT50b2tlbikpOwogCQl0YWxsb2NfZnJlZSh3YXRjaCk7CiAJCWRv bWFpbl93YXRjaF9kZWMoY29ubik7CiAJfQpAQCAtMzczLDcgKzM4MCw3IEBA IHZvaWQgcmVhZF9zdGF0ZV93YXRjaChjb25zdCB2b2lkICpjdHgsIGNvbnN0 IHZvaWQgKnN0YXRlKQogCWlmICghcGF0aCkKIAkJYmFyZigiYWxsb2NhdGlv biBlcnJvciBmb3IgcmVhZCB3YXRjaCIpOwogCi0JaWYgKCFhZGRfd2F0Y2go Y29ubiwgcGF0aCwgdG9rZW4sIHJlbGF0aXZlKSkKKwlpZiAoIWFkZF93YXRj aChjb25uLCBwYXRoLCB0b2tlbiwgcmVsYXRpdmUsIHRydWUpKQogCQliYXJm KCJlcnJvciBhZGRpbmcgd2F0Y2giKTsKIH0KIAo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-14.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-14.patch" Content-Transfer-Encoding: base64 RnJvbSAzYzlkZTAxODA3ZTIzZmU3ZDExZmJmMGNhYjY0ZjQyNzRkMjYwZTkx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBtZW1v cnkgYWNjb3VudGluZyBmb3Igbm9kZXMKCkFkZCB0aGUgbWVtb3J5IGFjY291 bnRpbmcgZm9yIFhlbnN0b3JlIG5vZGVzLiBJbiBvcmRlciB0byBtYWtlIHRo aXMKbm90IHRvbyBjb21wbGljYXRlZCBhbGxvdyBmb3Igc29tZSBzbG9wcGlu ZXNzIHdoZW4gd3JpdGluZyBub2Rlcy4gQW55CmhhcmQgcXVvdGEgdmlvbGF0 aW9uIHdpbGwgcmVzdWx0IGluIG5vIGZ1cnRoZXIgcmVxdWVzdHMgdG8gYmUg YWNjZXB0ZWQuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNiAvIENWRS0yMDIy LTQyMzE1LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFt YXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z c0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxs QGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKaW5kZXggMWE1YmE0YWJhODM5Li5mN2YxZTAwYzcxNWIgMTAwNjQ0Ci0t LSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMKKysrIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYwpAQCAtNTg3LDYgKzU4Nywx MTcgQEAgdm9pZCBzZXRfdGRiX2tleShjb25zdCBjaGFyICpuYW1lLCBUREJf REFUQSAqa2V5KQogCWtleS0+ZHNpemUgPSBzdHJsZW4obmFtZSk7CiB9CiAK K3N0YXRpYyB2b2lkIGdldF9hY2NfZGF0YShUREJfREFUQSAqa2V5LCBzdHJ1 Y3Qgbm9kZV9hY2NvdW50X2RhdGEgKmFjYykKK3sKKwlUREJfREFUQSBvbGRf ZGF0YTsKKwlzdHJ1Y3QgeHNfdGRiX3JlY29yZF9oZHIgKmhkcjsKKworCWlm IChhY2MtPm1lbW9yeSA8IDApIHsKKwkJb2xkX2RhdGEgPSB0ZGJfZmV0Y2go dGRiX2N0eCwgKmtleSk7CisJCS8qIE5vIGNoZWNrIGZvciBlcnJvciwgYXMg dGhlIG5vZGUgbWlnaHQgbm90IGV4aXN0LiAqLworCQlpZiAob2xkX2RhdGEu ZHB0ciA9PSBOVUxMKSB7CisJCQlhY2MtPm1lbW9yeSA9IDA7CisJCX0gZWxz ZSB7CisJCQloZHIgPSAodm9pZCAqKW9sZF9kYXRhLmRwdHI7CisJCQlhY2Mt Pm1lbW9yeSA9IG9sZF9kYXRhLmRzaXplOworCQkJYWNjLT5kb21pZCA9IGhk ci0+cGVybXNbMF0uaWQ7CisJCX0KKwkJdGFsbG9jX2ZyZWUob2xkX2RhdGEu ZHB0cik7CisJfQorfQorCisvKgorICogUGVyLXRyYW5zYWN0aW9uIG5vZGVz IG5lZWQgdG8gYmUgYWNjb3VudGVkIGZvciB0aGUgdHJhbnNhY3Rpb24gb3du ZXIuCisgKiBUaG9zZSBub2RlcyBhcmUgc3RvcmVkIGluIHRoZSBkYXRhIGJh c2Ugd2l0aCB0aGUgdHJhbnNhY3Rpb24gZ2VuZXJhdGlvbgorICogY291bnQg cHJlcGVuZGVkIChlLmcuIDEyMy9sb2NhbC9kb21haW4vLi4uKS4gU28gdGVz dGluZyBmb3IgdGhlIG5vZGUncworICoga2V5IG5vdCB0byBzdGFydCB3aXRo ICIvIiBpcyBzdWZmaWNpZW50LgorICovCitzdGF0aWMgdW5zaWduZWQgaW50 IGdldF9hY2NfZG9taWQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9E QVRBICprZXksCisJCQkJICB1bnNpZ25lZCBpbnQgZG9taWQpCit7CisJcmV0 dXJuICghY29ubiB8fCBrZXktPmRwdHJbMF0gPT0gJy8nKSA/IGRvbWlkIDog Y29ubi0+aWQ7Cit9CisKK2ludCBkb190ZGJfd3JpdGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXksIFREQl9EQVRBICpkYXRhLAor CQkgc3RydWN0IG5vZGVfYWNjb3VudF9kYXRhICphY2MsIGJvb2wgbm9fcXVv dGFfY2hlY2spCit7CisJc3RydWN0IHhzX3RkYl9yZWNvcmRfaGRyICpoZHIg PSAodm9pZCAqKWRhdGEtPmRwdHI7CisJc3RydWN0IG5vZGVfYWNjb3VudF9k YXRhIG9sZF9hY2MgPSB7fTsKKwl1bnNpZ25lZCBpbnQgb2xkX2RvbWlkLCBu ZXdfZG9taWQ7CisJaW50IHJldDsKKworCWlmICghYWNjKQorCQlvbGRfYWNj Lm1lbW9yeSA9IC0xOworCWVsc2UKKwkJb2xkX2FjYyA9ICphY2M7CisKKwln ZXRfYWNjX2RhdGEoa2V5LCAmb2xkX2FjYyk7CisJb2xkX2RvbWlkID0gZ2V0 X2FjY19kb21pZChjb25uLCBrZXksIG9sZF9hY2MuZG9taWQpOworCW5ld19k b21pZCA9IGdldF9hY2NfZG9taWQoY29ubiwga2V5LCBoZHItPnBlcm1zWzBd LmlkKTsKKworCS8qCisJICogRG9uJ3QgY2hlY2sgZm9yIEVOT0VOVCwgYXMg d2Ugd2FudCB0byBiZSBhYmxlIHRvIHN3aXRjaCBvcnBoYW5lZAorCSAqIG5v ZGVzIHRvIG5ldyBvd25lcnMuCisJICovCisJaWYgKG9sZF9hY2MubWVtb3J5 KQorCQlkb21haW5fbWVtb3J5X2FkZF9ub2NoayhvbGRfZG9taWQsCisJCQkJ CS1vbGRfYWNjLm1lbW9yeSAtIGtleS0+ZHNpemUpOworCXJldCA9IGRvbWFp bl9tZW1vcnlfYWRkKG5ld19kb21pZCwgZGF0YS0+ZHNpemUgKyBrZXktPmRz aXplLAorCQkJCW5vX3F1b3RhX2NoZWNrKTsKKwlpZiAocmV0KSB7CisJCS8q IEVycm9yIHBhdGgsIHNvIG5vIHF1b3RhIGNoZWNrLiAqLworCQlpZiAob2xk X2FjYy5tZW1vcnkpCisJCQlkb21haW5fbWVtb3J5X2FkZF9ub2NoayhvbGRf ZG9taWQsCisJCQkJCQlvbGRfYWNjLm1lbW9yeSArIGtleS0+ZHNpemUpOwor CQlyZXR1cm4gcmV0OworCX0KKworCS8qIFREQiBzaG91bGQgc2V0IGVycm5v LCBidXQgZG9lc24ndCBldmVuIHNldCBlY29kZSBBRkFJQ1QuICovCisJaWYg KHRkYl9zdG9yZSh0ZGJfY3R4LCAqa2V5LCAqZGF0YSwgVERCX1JFUExBQ0Up ICE9IDApIHsKKwkJZG9tYWluX21lbW9yeV9hZGRfbm9jaGsobmV3X2RvbWlk LCAtZGF0YS0+ZHNpemUgLSBrZXktPmRzaXplKTsKKwkJLyogRXJyb3IgcGF0 aCwgc28gbm8gcXVvdGEgY2hlY2suICovCisJCWlmIChvbGRfYWNjLm1lbW9y eSkKKwkJCWRvbWFpbl9tZW1vcnlfYWRkX25vY2hrKG9sZF9kb21pZCwKKwkJ CQkJCW9sZF9hY2MubWVtb3J5ICsga2V5LT5kc2l6ZSk7CisJCWVycm5vID0g RUlPOworCQlyZXR1cm4gZXJybm87CisJfQorCisJaWYgKGFjYykgeworCQkv KiBEb24ndCB1c2UgbmV3X2RvbWlkLCBhcyBpdCBtaWdodCBiZSBhIHRyYW5z YWN0aW9uIG5vZGUuICovCisJCWFjYy0+ZG9taWQgPSBoZHItPnBlcm1zWzBd LmlkOworCQlhY2MtPm1lbW9yeSA9IGRhdGEtPmRzaXplOworCX0KKworCXJl dHVybiAwOworfQorCitpbnQgZG9fdGRiX2RlbGV0ZShzdHJ1Y3QgY29ubmVj dGlvbiAqY29ubiwgVERCX0RBVEEgKmtleSwKKwkJICBzdHJ1Y3Qgbm9kZV9h Y2NvdW50X2RhdGEgKmFjYykKK3sKKwlzdHJ1Y3Qgbm9kZV9hY2NvdW50X2Rh dGEgdG1wX2FjYzsKKwl1bnNpZ25lZCBpbnQgZG9taWQ7CisKKwlpZiAoIWFj YykgeworCQlhY2MgPSAmdG1wX2FjYzsKKwkJYWNjLT5tZW1vcnkgPSAtMTsK Kwl9CisKKwlnZXRfYWNjX2RhdGEoa2V5LCBhY2MpOworCisJaWYgKHRkYl9k ZWxldGUodGRiX2N0eCwgKmtleSkpIHsKKwkJZXJybm8gPSBFSU87CisJCXJl dHVybiBlcnJubzsKKwl9CisKKwlpZiAoYWNjLT5tZW1vcnkpIHsKKwkJZG9t aWQgPSBnZXRfYWNjX2RvbWlkKGNvbm4sIGtleSwgYWNjLT5kb21pZCk7CisJ CWRvbWFpbl9tZW1vcnlfYWRkX25vY2hrKGRvbWlkLCAtYWNjLT5tZW1vcnkg LSBrZXktPmRzaXplKTsKKwl9CisKKwlyZXR1cm4gMDsKK30KKwogLyoKICAq IElmIGl0IGZhaWxzLCByZXR1cm5zIE5VTEwgYW5kIHNldHMgZXJybm8uCiAg KiBUZW1wb3JhcnkgbWVtb3J5IGFsbG9jYXRpb25zIHdpbGwgYmUgZG9uZSB3 aXRoIGN0eC4KQEAgLTY0MCw5ICs3NTEsMTUgQEAgc3RydWN0IG5vZGUgKnJl YWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAq Y3R4LAogCiAJLyogUGVybWlzc2lvbnMgYXJlIHN0cnVjdCB4c19wZXJtaXNz aW9ucy4gKi8KIAlub2RlLT5wZXJtcy5wID0gaGRyLT5wZXJtczsKKwlub2Rl LT5hY2MuZG9taWQgPSBub2RlLT5wZXJtcy5wWzBdLmlkOworCW5vZGUtPmFj Yy5tZW1vcnkgPSBkYXRhLmRzaXplOwogCWlmIChkb21haW5fYWRqdXN0X25v ZGVfcGVybXMoY29ubiwgbm9kZSkpCiAJCWdvdG8gZXJyb3I7CiAKKwkvKiBJ ZiBvd25lciBpcyBnb25lIHJlc2V0IGN1cnJlbnRseSBhY2NvdW50ZWQgbWVt b3J5IHNpemUuICovCisJaWYgKG5vZGUtPmFjYy5kb21pZCAhPSBub2RlLT5w ZXJtcy5wWzBdLmlkKQorCQlub2RlLT5hY2MubWVtb3J5ID0gMDsKKwogCS8q IERhdGEgaXMgYmluYXJ5IGJsb2IgKHVzdWFsbHkgYXNjaWksIG5vIG51bCku ICovCiAJbm9kZS0+ZGF0YSA9IG5vZGUtPnBlcm1zLnAgKyBoZHItPm51bV9w ZXJtczsKIAkvKiBDaGlsZHJlbiBpcyBzdHJpbmdzLCBudWwgc2VwYXJhdGVk LiAqLwpAQCAtNzExLDEyICs4MjgsOSBAQCBpbnQgd3JpdGVfbm9kZV9yYXco c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXksIHN0cnVj dCBub2RlICpub2RlLAogCXAgKz0gbm9kZS0+ZGF0YWxlbjsKIAltZW1jcHko cCwgbm9kZS0+Y2hpbGRyZW4sIG5vZGUtPmNoaWxkbGVuKTsKIAotCS8qIFRE QiBzaG91bGQgc2V0IGVycm5vLCBidXQgZG9lc24ndCBldmVuIHNldCBlY29k ZSBBRkFJQ1QuICovCi0JaWYgKHRkYl9zdG9yZSh0ZGJfY3R4LCAqa2V5LCBk YXRhLCBUREJfUkVQTEFDRSkgIT0gMCkgewotCQljb3JydXB0KGNvbm4sICJX cml0ZSBvZiAlcyBmYWlsZWQiLCBrZXktPmRwdHIpOwotCQllcnJubyA9IEVJ TzsKLQkJcmV0dXJuIGVycm5vOwotCX0KKwlpZiAoZG9fdGRiX3dyaXRlKGNv bm4sIGtleSwgJmRhdGEsICZub2RlLT5hY2MsIG5vX3F1b3RhX2NoZWNrKSkK KwkJcmV0dXJuIEVJTzsKKwogCXJldHVybiAwOwogfQogCkBAIC0xMjE4LDcg KzEzMzIsNyBAQCBzdGF0aWMgdm9pZCBkZWxldGVfbm9kZV9zaW5nbGUoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQogCWlm IChhY2Nlc3Nfbm9kZShjb25uLCBub2RlLCBOT0RFX0FDQ0VTU19ERUxFVEUs ICZrZXkpKQogCQlyZXR1cm47CiAKLQlpZiAodGRiX2RlbGV0ZSh0ZGJfY3R4 LCBrZXkpICE9IDApIHsKKwlpZiAoZG9fdGRiX2RlbGV0ZShjb25uLCAma2V5 LCAmbm9kZS0+YWNjKSAhPSAwKSB7CiAJCWNvcnJ1cHQoY29ubiwgIkNvdWxk IG5vdCBkZWxldGUgJyVzJyIsIG5vZGUtPm5hbWUpOwogCQlyZXR1cm47CiAJ fQpAQCAtMTI5MSw2ICsxNDA1LDcgQEAgc3RhdGljIHN0cnVjdCBub2RlICpj b25zdHJ1Y3Rfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qg dm9pZCAqY3R4LAogCS8qIE5vIGNoaWxkcmVuLCBubyBkYXRhICovCiAJbm9k ZS0+Y2hpbGRyZW4gPSBub2RlLT5kYXRhID0gTlVMTDsKIAlub2RlLT5jaGls ZGxlbiA9IG5vZGUtPmRhdGFsZW4gPSAwOworCW5vZGUtPmFjYy5tZW1vcnkg PSAwOwogCW5vZGUtPnBhcmVudCA9IHBhcmVudDsKIAlyZXR1cm4gbm9kZTsK IApAQCAtMTI5OSwxNyArMTQxNCwxNyBAQCBzdGF0aWMgc3RydWN0IG5vZGUg KmNvbnN0cnVjdF9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25z dCB2b2lkICpjdHgsCiAJcmV0dXJuIE5VTEw7CiB9CiAKLXN0YXRpYyB2b2lk IGRlc3Ryb3lfbm9kZV9ybShzdHJ1Y3Qgbm9kZSAqbm9kZSkKK3N0YXRpYyB2 b2lkIGRlc3Ryb3lfbm9kZV9ybShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwg c3RydWN0IG5vZGUgKm5vZGUpCiB7CiAJaWYgKHN0cmVxKG5vZGUtPm5hbWUs ICIvIikpCiAJCWNvcnJ1cHQoTlVMTCwgIkRlc3Ryb3lpbmcgcm9vdCBub2Rl ISIpOwogCi0JdGRiX2RlbGV0ZSh0ZGJfY3R4LCBub2RlLT5rZXkpOworCWRv X3RkYl9kZWxldGUoY29ubiwgJm5vZGUtPmtleSwgJm5vZGUtPmFjYyk7CiB9 CiAKIHN0YXRpYyBpbnQgZGVzdHJveV9ub2RlKHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSkKIHsKLQlkZXN0cm95X25vZGVf cm0obm9kZSk7CisJZGVzdHJveV9ub2RlX3JtKGNvbm4sIG5vZGUpOwogCWRv bWFpbl9lbnRyeV9kZWMoY29ubiwgbm9kZSk7CiAKIAkvKgpAQCAtMTM2MSw3 ICsxNDc2LDcgQEAgc3RhdGljIHN0cnVjdCBub2RlICpjcmVhdGVfbm9kZShz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCAqY3R4LAogCQkv KiBBY2NvdW50IGZvciBuZXcgbm9kZSAqLwogCQlpZiAoaS0+cGFyZW50KSB7 CiAJCQlpZiAoZG9tYWluX2VudHJ5X2luYyhjb25uLCBpKSkgewotCQkJCWRl c3Ryb3lfbm9kZV9ybShpKTsKKwkJCQlkZXN0cm95X25vZGVfcm0oY29ubiwg aSk7CiAJCQkJcmV0dXJuIE5VTEw7CiAJCQl9CiAJCX0KQEAgLTIyNzAsNyAr MjM4NSw3IEBAIHN0YXRpYyBpbnQgY2xlYW5fc3RvcmVfKFREQl9DT05URVhU ICp0ZGIsIFREQl9EQVRBIGtleSwgVERCX0RBVEEgdmFsLAogCWlmICghaGFz aHRhYmxlX3NlYXJjaChyZWFjaGFibGUsIG5hbWUpKSB7CiAJCWxvZygiY2xl YW5fc3RvcmU6ICclcycgaXMgb3JwaGFuZWQhIiwgbmFtZSk7CiAJCWlmIChy ZWNvdmVyeSkgewotCQkJdGRiX2RlbGV0ZSh0ZGIsIGtleSk7CisJCQlkb190 ZGJfZGVsZXRlKE5VTEwsICZrZXksIE5VTEwpOwogCQl9CiAJfQogCkBAIC0z MTIyLDYgKzMyMzcsNyBAQCB2b2lkIHJlYWRfc3RhdGVfbm9kZShjb25zdCB2 b2lkICpjdHgsIGNvbnN0IHZvaWQgKnN0YXRlKQogCWlmICghbm9kZSkKIAkJ YmFyZigiYWxsb2NhdGlvbiBlcnJvciByZXN0b3Jpbmcgbm9kZSIpOwogCisJ bm9kZS0+YWNjLm1lbW9yeSA9IDA7CiAJbm9kZS0+bmFtZSA9IG5hbWU7CiAJ bm9kZS0+Z2VuZXJhdGlvbiA9ICsrZ2VuZXJhdGlvbjsKIAlub2RlLT5kYXRh bGVuID0gc24tPmRhdGFfbGVuOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmgKaW5kZXggZWM1MmQ4ZDNmZjAzLi4wMzFhODIxMzU4NmMgMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMTc2LDYg KzE3NiwxMSBAQCBzdHJ1Y3Qgbm9kZV9wZXJtcyB7CiAJc3RydWN0IHhzX3Bl cm1pc3Npb25zICpwOwogfTsKIAorc3RydWN0IG5vZGVfYWNjb3VudF9kYXRh IHsKKwl1bnNpZ25lZCBpbnQgZG9taWQ7CisJaW50IG1lbW9yeTsJCS8qIC0x IGlmIHVua25vd24gKi8KK307CisKIHN0cnVjdCBub2RlIHsKIAljb25zdCBj aGFyICpuYW1lOwogCS8qIEtleSB1c2VkIHRvIHVwZGF0ZSBUREIgKi8KQEAg LTE5OCw2ICsyMDMsOSBAQCBzdHJ1Y3Qgbm9kZSB7CiAJLyogQ2hpbGRyZW4s IGVhY2ggbnVsLXRlcm1pbmF0ZWQuICovCiAJdW5zaWduZWQgaW50IGNoaWxk bGVuOwogCWNoYXIgKmNoaWxkcmVuOworCisJLyogQWxsb2NhdGlvbiBpbmZv cm1hdGlvbiBmb3Igbm9kZSBjdXJyZW50bHkgaW4gc3RvcmUuICovCisJc3Ry dWN0IG5vZGVfYWNjb3VudF9kYXRhIGFjYzsKIH07CiAKIC8qIFJldHVybiB0 aGUgb25seSBhcmd1bWVudCBpbiB0aGUgaW5wdXQuICovCkBAIC0zMDEsNiAr MzA5LDEwIEBAIGV4dGVybiB4ZW5nbnR0YWJfaGFuZGxlICoqeGd0X2hhbmRs ZTsKIGludCByZW1lbWJlcl9zdHJpbmcoc3RydWN0IGhhc2h0YWJsZSAqaGFz aCwgY29uc3QgY2hhciAqc3RyKTsKIAogdm9pZCBzZXRfdGRiX2tleShjb25z dCBjaGFyICpuYW1lLCBUREJfREFUQSAqa2V5KTsKK2ludCBkb190ZGJfd3Jp dGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXksIFRE Ql9EQVRBICpkYXRhLAorCQkgc3RydWN0IG5vZGVfYWNjb3VudF9kYXRhICph Y2MsIGJvb2wgbm9fcXVvdGFfY2hlY2spOworaW50IGRvX3RkYl9kZWxldGUo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIFREQl9EQVRBICprZXksCisJCSAg c3RydWN0IG5vZGVfYWNjb3VudF9kYXRhICphY2MpOwogCiB2b2lkIGNvbm5f ZnJlZV9idWZmZXJlZF9kYXRhKHN0cnVjdCBjb25uZWN0aW9uICpjb25uKTsK IApkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5z YWN0aW9uLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rp b24uYwppbmRleCA3YmQ0MWViNDc1ZTMuLmFjZTlhMTFkNzdiYiAxMDA2NDQK LS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMK KysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMK QEAgLTE1Myw2ICsxNTMsOSBAQCBzdHJ1Y3QgdHJhbnNhY3Rpb24KIAkvKiBM aXN0IG9mIGFsbCB0cmFuc2FjdGlvbnMgYWN0aXZlIG9uIHRoaXMgY29ubmVj dGlvbi4gKi8KIAlzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7CiAKKwkvKiBDb25u ZWN0aW9uIHRoaXMgdHJhbnNhY3Rpb24gaXMgYXNzb2NpYXRlZCB3aXRoLiAq LworCXN0cnVjdCBjb25uZWN0aW9uICpjb25uOworCiAJLyogQ29ubmVjdGlv bi1sb2NhbCBpZGVudGlmaWVyIGZvciB0aGlzIHRyYW5zYWN0aW9uLiAqLwog CXVpbnQzMl90IGlkOwogCkBAIC0yODYsNiArMjg5LDggQEAgaW50IGFjY2Vz c19ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAq bm9kZSwKIAogCQlpbnRyb2R1Y2UgPSB0cnVlOwogCQlpLT50YV9ub2RlID0g ZmFsc2U7CisJCS8qIGFjYy5tZW1vcnkgPCAwIG1lYW5zICJ1bmtub3duLCBn ZXQgc2l6ZSBmcm9tIFREQiIuICovCisJCW5vZGUtPmFjYy5tZW1vcnkgPSAt MTsKIAogCQkvKgogCQkgKiBBZGRpdGlvbmFsIHRyYW5zYWN0aW9uLXNwZWNp ZmljIG5vZGUgZm9yIHJlYWQgdHlwZS4gV2Ugb25seQpAQCAtNDEwLDExICs0 MTUsMTEgQEAgc3RhdGljIGludCBmaW5hbGl6ZV90cmFuc2FjdGlvbihzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJCQkJZ290byBlcnI7CiAJCQkJaGRy ID0gKHZvaWQgKilkYXRhLmRwdHI7CiAJCQkJaGRyLT5nZW5lcmF0aW9uID0g KytnZW5lcmF0aW9uOwotCQkJCXJldCA9IHRkYl9zdG9yZSh0ZGJfY3R4LCBr ZXksIGRhdGEsCi0JCQkJCQlUREJfUkVQTEFDRSk7CisJCQkJcmV0ID0gZG9f dGRiX3dyaXRlKGNvbm4sICZrZXksICZkYXRhLCBOVUxMLAorCQkJCQkJICAg dHJ1ZSk7CiAJCQkJdGFsbG9jX2ZyZWUoZGF0YS5kcHRyKTsKIAkJCX0gZWxz ZSB7Ci0JCQkJcmV0ID0gdGRiX2RlbGV0ZSh0ZGJfY3R4LCBrZXkpOworCQkJ CXJldCA9IGRvX3RkYl9kZWxldGUoY29ubiwgJmtleSwgTlVMTCk7CiAJCQl9 CiAJCQlpZiAocmV0KQogCQkJCWdvdG8gZXJyOwpAQCAtNDI1LDcgKzQzMCw3 IEBAIHN0YXRpYyBpbnQgZmluYWxpemVfdHJhbnNhY3Rpb24oc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sCiAJCQl9CiAJCX0KIAotCQlpZiAoaS0+dGFfbm9k ZSAmJiB0ZGJfZGVsZXRlKHRkYl9jdHgsIHRhX2tleSkpCisJCWlmIChpLT50 YV9ub2RlICYmIGRvX3RkYl9kZWxldGUoY29ubiwgJnRhX2tleSwgTlVMTCkp CiAJCQlnb3RvIGVycjsKIAkJbGlzdF9kZWwoJmktPmxpc3QpOwogCQl0YWxs b2NfZnJlZShpKTsKQEAgLTQ1Myw3ICs0NTgsNyBAQCBzdGF0aWMgaW50IGRl c3Ryb3lfdHJhbnNhY3Rpb24odm9pZCAqX3RyYW5zYWN0aW9uKQogCQkJCQkJ CSAgICAgICBpLT5ub2RlKTsKIAkJCWlmICh0cmFuc19uYW1lKSB7CiAJCQkJ c2V0X3RkYl9rZXkodHJhbnNfbmFtZSwgJmtleSk7Ci0JCQkJdGRiX2RlbGV0 ZSh0ZGJfY3R4LCBrZXkpOworCQkJCWRvX3RkYl9kZWxldGUodHJhbnMtPmNv bm4sICZrZXksIE5VTEwpOwogCQkJfQogCQl9CiAJCWxpc3RfZGVsKCZpLT5s aXN0KTsKQEAgLTQ5Nyw2ICs1MDIsNyBAQCBpbnQgZG9fdHJhbnNhY3Rpb25f c3RhcnQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBidWZmZXJl ZF9kYXRhICppbikKIAogCUlOSVRfTElTVF9IRUFEKCZ0cmFucy0+YWNjZXNz ZWQpOwogCUlOSVRfTElTVF9IRUFEKCZ0cmFucy0+Y2hhbmdlZF9kb21haW5z KTsKKwl0cmFucy0+Y29ubiA9IGNvbm47CiAJdHJhbnMtPmZhaWwgPSBmYWxz ZTsKIAl0cmFucy0+Z2VuZXJhdGlvbiA9ICsrZ2VuZXJhdGlvbjsKIAo= --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-15.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-15.patch" Content-Transfer-Encoding: base64 RnJvbSAxMjY4YjgxMzA5OTI4ZThmNTlhNTM1OGM4ZDBiMGI1MDA3NGI1ZWVm IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBleHBv cnRzIGZvciBxdW90YSB2YXJpYWJsZXMKClNvbWUgcXVvdGEgdmFyaWFibGVz IGFyZSBub3QgZXhwb3J0ZWQgdmlhIGhlYWRlciBmaWxlcy4KClRoaXMgaXMg cGFydCBvZiBYU0EtMzI2LgoKUmVwb3J0ZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jv c3MgPGpncm9zc0BzdXNlLmNvbT4KQWNrZWQtYnk6IEp1bGllbiBHcmFsbCA8 amdyYWxsQGFtYXpvbi5jb20+CgpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuaCBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmgKaW5kZXggMDMxYTgyMTM1ODZjLi5mN2MzN2ZlM2I1NjUgMTAw NjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaApAQCAtMjczLDYg KzI3MywxMSBAQCBleHRlcm4gVERCX0NPTlRFWFQgKnRkYl9jdHg7CiBleHRl cm4gaW50IGRvbTBfZG9taWQ7CiBleHRlcm4gaW50IGRvbTBfZXZlbnQ7CiBl eHRlcm4gaW50IHByaXZfZG9taWQ7CitleHRlcm4gaW50IHF1b3RhX25iX3dh dGNoX3Blcl9kb21haW47CitleHRlcm4gaW50IHF1b3RhX21heF90cmFuc2Fj dGlvbjsKK2V4dGVybiBpbnQgcXVvdGFfbWF4X2VudHJ5X3NpemU7CitleHRl cm4gaW50IHF1b3RhX25iX3Blcm1zX3Blcl9ub2RlOworZXh0ZXJuIGludCBx dW90YV9tYXhfcGF0aF9sZW47CiBleHRlcm4gaW50IHF1b3RhX25iX2VudHJ5 X3Blcl9kb21haW47CiBleHRlcm4gaW50IHF1b3RhX3JlcV9vdXRzdGFuZGlu ZzsKIGV4dGVybiBpbnQgcXVvdGFfdHJhbnNfbm9kZXM7CmRpZmYgLS1naXQg YS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCmluZGV4IGFj ZTlhMTFkNzdiYi4uMjg3NzQ4MTNkZTgzIDEwMDY0NAotLS0gYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYworKysgYi90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwpAQCAtMTc1LDcgKzE3 NSw2IEBAIHN0cnVjdCB0cmFuc2FjdGlvbgogCWJvb2wgZmFpbDsKIH07CiAK LWV4dGVybiBpbnQgcXVvdGFfbWF4X3RyYW5zYWN0aW9uOwogdWludDY0X3Qg Z2VuZXJhdGlvbjsKIAogc3RhdGljIHN0cnVjdCBhY2Nlc3NlZF9ub2RlICpm aW5kX2FjY2Vzc2VkX25vZGUoc3RydWN0IHRyYW5zYWN0aW9uICp0cmFucywK ZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5j IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmMKaW5kZXggZmRm OWIyZDY1M2EwLi44NTM2MmJjY2UzMTQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jCisrKyBiL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF93YXRjaC5jCkBAIC0zMSw4ICszMSw2IEBACiAjaW5jbHVk ZSAieGVuc3RvcmVkX2RvbWFpbi5oIgogI2luY2x1ZGUgInhlbnN0b3JlZF90 cmFuc2FjdGlvbi5oIgogCi1leHRlcm4gaW50IHF1b3RhX25iX3dhdGNoX3Bl cl9kb21haW47Ci0KIHN0cnVjdCB3YXRjaAogewogCS8qIFdhdGNoZXMgb24g dGhpcyBjb25uZWN0aW9uICovCg== --=separator Content-Type: application/octet-stream; name="xsa326/xsa326-xenstored-16.patch" Content-Disposition: attachment; filename="xsa326/xsa326-xenstored-16.patch" Content-Transfer-Encoding: base64 RnJvbSBlOTAyOTQ2ZmIwZTQzMmI0Y2JiNThmMmU5OWFiNTYyZmUxMDBiZDc1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTAgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGFkZCBjb250 cm9sIGNvbW1hbmQgZm9yIHNldHRpbmcgYW5kIHNob3dpbmcgcXVvdGEKCkFk ZCBhIHhlbnN0b3JlLWNvbnRyb2wgY29tbWFuZCAicXVvdGEiIHRvOgotIHNo b3cgY3VycmVudCBxdW90YSBzZXR0aW5ncwotIGNoYW5nZSBxdW90YSBzZXR0 aW5ncwotIHNob3cgY3VycmVudCBxdW90YSByZWxhdGVkIHZhbHVlcyBvZiBh IGRvbWFpbgoKTm90ZSB0aGF0IGluIHRoZSBjYXNlIHRoZSBuZXcgcXVvdGEg aXMgbG93ZXIgdGhhbiBleGlzdGluZyBvbmUsClhlbnN0b3JlZCBtYXkgY29u dGludWUgdG8gaGFuZGxlIHJlcXVlc3RzIGZyb20gYSBkb21haW4gZXhjZWVk aW5nIHRoZQpuZXcgbGltaXQgKGRlcGVuZHMgb24gd2hpY2ggb25lIGhhcyBi ZWVuIGJyb2tlbikgYW5kIHRoZSBhbW91bnQgb2YKcmVzb3VyY2UgdXNlZCB3 aWxsIG5vdCBjaGFuZ2UuIEhvd2V2ZXIgdGhlIGRvbWFpbiB3aWxsIG5vdCBi ZSBhYmxlIHRvCmNyZWF0ZSBtb3JlIHJlc291cmNlIChhc3NvY2lhdGVkIHRv IHRoZSBxdW90YSkgdW50aWwgaXQgaXMgYmFjayB0byBiZWxvdwp0aGUgbGlt aXQuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTMyNi4KClJlcG9ydGVkLWJ5OiBK dWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgpTaWduZWQtb2ZmLWJ5 OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ClJldmlld2VkLWJ5 OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdp dCBhL2RvY3MvbWlzYy94ZW5zdG9yZS50eHQgYi9kb2NzL21pc2MveGVuc3Rv cmUudHh0CmluZGV4IDRiYzI2MmZkNWRiMS4uOTg4ZWY4OWNiYTJkIDEwMDY0 NAotLS0gYS9kb2NzL21pc2MveGVuc3RvcmUudHh0CisrKyBiL2RvY3MvbWlz Yy94ZW5zdG9yZS50eHQKQEAgLTQxMCw2ICs0MTAsMTcgQEAgQ09OVFJPTAkJ CTxjb21tYW5kPnxbPHBhcmFtZXRlcnM+fF0KIAlwcmludHw8c3RyaW5nPgog CQlwcmludCA8c3RyaW5nPiB0byBzeXNsb2cgKHhlbnN0b3JlIHJ1bnMgYXMg ZGFlbW9uKSBvcgogCQl0byBjb25zb2xlICh4ZW5zdG9yZSBydW5zIGFzIHN0 dWJkb20pCisJcXVvdGF8W3NldCA8bmFtZT4gPHZhbD58PGRvbWlkPl0KKwkJ d2l0aG91dCBwYXJhbWV0ZXJzOiBwcmludCB0aGUgY3VycmVudCBxdW90YSBz ZXR0aW5ncworCQl3aXRoICJzZXQgPG5hbWU+IDx2YWw+Ijogc2V0IHRoZSBx dW90YSA8bmFtZT4gdG8gbmV3IHZhbHVlCisJCTx2YWw+IChUaGUgYWRtaW4g c2hvdWxkIG1ha2Ugc3VyZSBhbGwgdGhlIGRvbWFpbiB1c2FnZSBpcworCQli ZWxvdyB0aGUgcXVvdGEuIElmIGl0IGlzIG5vdCwgdGhlbiBYZW5zdG9yZWQg bWF5IGNvbnRpbnVlIHRvCisJCWhhbmRsZSByZXF1ZXN0cyBmcm9tIHRoZSBk b21haW4gYXMgbG9uZyBhcyB0aGUgcmVzb3VyY2UKKwkJdmlvbGF0aW5nIHRo ZSBuZXcgcXVvdGEgc2V0dGluZyBpc24ndCBpbmNyZWFzZWQgZnVydGhlcikK KwkJd2l0aCAiPGRvbWlkPiI6IHByaW50IHF1b3RhIHJlbGF0ZWQgYWNjb3Vu dGluZyBkYXRhIGZvcgorCQl0aGUgZG9tYWluIDxkb21pZD4KKwlxdW90YS1z b2Z0fFtzZXQgPG5hbWU+IDx2YWw+XQorCQlsaWtlIHRoZSAicXVvdGEiIGNv bW1hbmQsIGJ1dCBmb3Igc29mdC1xdW90YS4KIAloZWxwCQkJPHN1cHBvcnRl ZC1jb21tYW5kcz4KIAkJcmV0dXJuIGxpc3Qgb2Ygc3VwcG9ydGVkIGNvbW1h bmRzIGZvciBDT05UUk9MCiAKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3Jl L3hlbnN0b3JlZF9jb250cm9sLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29udHJvbC5jCmluZGV4IDYxYmNiYzA2OWQ3NS4uMjY0YmIzOWQ3YjBl IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJv bC5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmMK QEAgLTE5Niw2ICsxOTYsMTE1IEBAIHN0YXRpYyBpbnQgZG9fY29udHJvbF9s b2codm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAlyZXR1 cm4gMDsKIH0KIAorc3RydWN0IHF1b3RhIHsKKwljb25zdCBjaGFyICpuYW1l OworCWludCAqcXVvdGE7CisJY29uc3QgY2hhciAqZGVzY3I7Cit9OworCitz dGF0aWMgY29uc3Qgc3RydWN0IHF1b3RhIGhhcmRfcXVvdGFzW10gPSB7CisJ eyAibm9kZXMiLCAmcXVvdGFfbmJfZW50cnlfcGVyX2RvbWFpbiwgIk5vZGVz IHBlciBkb21haW4iIH0sCisJeyAid2F0Y2hlcyIsICZxdW90YV9uYl93YXRj aF9wZXJfZG9tYWluLCAiV2F0Y2hlcyBwZXIgZG9tYWluIiB9LAorCXsgInRy YW5zYWN0aW9ucyIsICZxdW90YV9tYXhfdHJhbnNhY3Rpb24sICJUcmFuc2Fj dGlvbnMgcGVyIGRvbWFpbiIgfSwKKwl7ICJvdXRzdGFuZGluZyIsICZxdW90 YV9yZXFfb3V0c3RhbmRpbmcsCisJCSJPdXRzdGFuZGluZyByZXF1ZXN0cyBw ZXIgZG9tYWluIiB9LAorCXsgInRyYW5zYWN0aW9uLW5vZGVzIiwgJnF1b3Rh X3RyYW5zX25vZGVzLAorCQkiTWF4LiBudW1iZXIgb2YgYWNjZXNzZWQgbm9k ZXMgcGVyIHRyYW5zYWN0aW9uIiB9LAorCXsgIm1lbW9yeSIsICZxdW90YV9t ZW1vcnlfcGVyX2RvbWFpbl9oYXJkLAorCQkiVG90YWwgWGVuc3RvcmUgbWVt b3J5IHBlciBkb21haW4gKGVycm9yIGxldmVsKSIgfSwKKwl7ICJub2RlLXNp emUiLCAmcXVvdGFfbWF4X2VudHJ5X3NpemUsICJNYXguIHNpemUgb2YgYSBu b2RlIiB9LAorCXsgInBhdGgtbWF4IiwgJnF1b3RhX21heF9wYXRoX2xlbiwg Ik1heC4gbGVuZ3RoIG9mIGEgbm9kZSBwYXRoIiB9LAorCXsgInBlcm1pc3Np b25zIiwgJnF1b3RhX25iX3Blcm1zX3Blcl9ub2RlLAorCQkiTWF4LiBudW1i ZXIgb2YgcGVybWlzc2lvbnMgcGVyIG5vZGUiIH0sCisJeyBOVUxMLCBOVUxM LCBOVUxMIH0KK307CisKK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcXVvdGEgc29m dF9xdW90YXNbXSA9IHsKKwl7ICJtZW1vcnkiLCAmcXVvdGFfbWVtb3J5X3Bl cl9kb21haW5fc29mdCwKKwkJIlRvdGFsIFhlbnN0b3JlIG1lbW9yeSBwZXIg ZG9tYWluICh3YXJuaW5nIGxldmVsKSIgfSwKKwl7IE5VTEwsIE5VTEwsIE5V TEwgfQorfTsKKworc3RhdGljIGludCBxdW90YV9zaG93X2N1cnJlbnQoY29u c3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKKwkJCSAg ICAgIGNvbnN0IHN0cnVjdCBxdW90YSAqcXVvdGFzKQoreworCWNoYXIgKnJl c3A7CisJdW5zaWduZWQgaW50IGk7CisKKwlyZXNwID0gdGFsbG9jX3N0cmR1 cChjdHgsICJRdW90YSBzZXR0aW5nczpcbiIpOworCWlmICghcmVzcCkKKwkJ cmV0dXJuIEVOT01FTTsKKworCWZvciAoaSA9IDA7IHF1b3Rhc1tpXS5xdW90 YTsgaSsrKSB7CisJCXJlc3AgPSB0YWxsb2NfYXNwcmludGZfYXBwZW5kKHJl c3AsICIlLTE3czogJThkICVzXG4iLAorCQkJCQkgICAgICBxdW90YXNbaV0u bmFtZSwgKnF1b3Rhc1tpXS5xdW90YSwKKwkJCQkJICAgICAgcXVvdGFzW2ld LmRlc2NyKTsKKwkJaWYgKCFyZXNwKQorCQkJcmV0dXJuIEVOT01FTTsKKwl9 CisKKwlzZW5kX3JlcGx5KGNvbm4sIFhTX0NPTlRST0wsIHJlc3AsIHN0cmxl bihyZXNwKSArIDEpOworCisJcmV0dXJuIDA7Cit9CisKK3N0YXRpYyBpbnQg cXVvdGFfc2V0KGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4sCisJCSAgICAgY2hhciAqKnZlYywgaW50IG51bSwgY29uc3Qgc3Ry dWN0IHF1b3RhICpxdW90YXMpCit7CisJdW5zaWduZWQgaW50IGk7CisJaW50 IHZhbDsKKworCWlmIChudW0gIT0gMikKKwkJcmV0dXJuIEVJTlZBTDsKKwor CXZhbCA9IGF0b2kodmVjWzFdKTsKKwlpZiAodmFsIDwgMSkKKwkJcmV0dXJu IEVJTlZBTDsKKworCWZvciAoaSA9IDA7IHF1b3Rhc1tpXS5xdW90YTsgaSsr KSB7CisJCWlmICghc3RyY21wKHZlY1swXSwgcXVvdGFzW2ldLm5hbWUpKSB7 CisJCQkqcXVvdGFzW2ldLnF1b3RhID0gdmFsOworCQkJc2VuZF9hY2soY29u biwgWFNfQ09OVFJPTCk7CisJCQlyZXR1cm4gMDsKKwkJfQorCX0KKworCXJl dHVybiBFSU5WQUw7Cit9CisKK3N0YXRpYyBpbnQgcXVvdGFfZ2V0KGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCisJCSAgICAg Y2hhciAqKnZlYywgaW50IG51bSkKK3sKKwlpZiAobnVtICE9IDEpCisJCXJl dHVybiBFSU5WQUw7CisKKwlyZXR1cm4gZG9tYWluX2dldF9xdW90YShjdHgs IGNvbm4sIGF0b2kodmVjWzBdKSk7Cit9CisKK3N0YXRpYyBpbnQgZG9fY29u dHJvbF9xdW90YSh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25u LAorCQkJICAgIGNoYXIgKip2ZWMsIGludCBudW0pCit7CisJaWYgKG51bSA9 PSAwKQorCQlyZXR1cm4gcXVvdGFfc2hvd19jdXJyZW50KGN0eCwgY29ubiwg aGFyZF9xdW90YXMpOworCisJaWYgKCFzdHJjbXAodmVjWzBdLCAic2V0Iikp CisJCXJldHVybiBxdW90YV9zZXQoY3R4LCBjb25uLCB2ZWMgKyAxLCBudW0g LSAxLCBoYXJkX3F1b3Rhcyk7CisKKwlyZXR1cm4gcXVvdGFfZ2V0KGN0eCwg Y29ubiwgdmVjLCBudW0pOworfQorCitzdGF0aWMgaW50IGRvX2NvbnRyb2xf cXVvdGFfcyh2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAor CQkJICAgICAgY2hhciAqKnZlYywgaW50IG51bSkKK3sKKwlpZiAobnVtID09 IDApCisJCXJldHVybiBxdW90YV9zaG93X2N1cnJlbnQoY3R4LCBjb25uLCBz b2Z0X3F1b3Rhcyk7CisKKwlpZiAoIXN0cmNtcCh2ZWNbMF0sICJzZXQiKSkK KwkJcmV0dXJuIHF1b3RhX3NldChjdHgsIGNvbm4sIHZlYyArIDEsIG51bSAt IDEsIHNvZnRfcXVvdGFzKTsKKworCXJldHVybiBFSU5WQUw7Cit9CisKICNp ZmRlZiBfX01JTklPU19fCiBzdGF0aWMgaW50IGRvX2NvbnRyb2xfbWVtcmVw b3J0KHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQkJ Y2hhciAqKnZlYywgaW50IG51bSkKQEAgLTg0Nyw2ICs5NTYsOCBAQCBzdGF0 aWMgc3RydWN0IGNtZF9zIGNtZHNbXSA9IHsKIAl7ICJtZW1yZXBvcnQiLCBk b19jb250cm9sX21lbXJlcG9ydCwgIls8ZmlsZT5dIiB9LAogI2VuZGlmCiAJ eyAicHJpbnQiLCBkb19jb250cm9sX3ByaW50LCAiPHN0cmluZz4iIH0sCisJ eyAicXVvdGEiLCBkb19jb250cm9sX3F1b3RhLCAiW3NldCA8bmFtZT4gPHZh bD58PGRvbWlkPl0iIH0sCisJeyAicXVvdGEtc29mdCIsIGRvX2NvbnRyb2xf cXVvdGFfcywgIltzZXQgPG5hbWU+IDx2YWw+XSIgfSwKIAl7ICJoZWxwIiwg ZG9fY29udHJvbF9oZWxwLCAiIiB9LAogfTsKIApkaWZmIC0tZ2l0IGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2RvbWFpbi5jCmluZGV4IDQyNDIzODA4ODYzZi4uOTgz YjM0OGVlNTljIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfZG9tYWluLmMKKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Rv bWFpbi5jCkBAIC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSAieGVuc3RvcmVk X2RvbWFpbi5oIgogI2luY2x1ZGUgInhlbnN0b3JlZF90cmFuc2FjdGlvbi5o IgogI2luY2x1ZGUgInhlbnN0b3JlZF93YXRjaC5oIgorI2luY2x1ZGUgInhl bnN0b3JlZF9jb250cm9sLmgiCiAKICNpbmNsdWRlIDx4ZW5ldnRjaG4uaD4K ICNpbmNsdWRlIDx4ZW5jdHJsLmg+CkBAIC0zNDUsNiArMzQ2LDM4IEBAIHN0 YXRpYyBzdHJ1Y3QgZG9tYWluICpmaW5kX2RvbWFpbl9zdHJ1Y3QodW5zaWdu ZWQgaW50IGRvbWlkKQogCXJldHVybiBOVUxMOwogfQogCitpbnQgZG9tYWlu X2dldF9xdW90YShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9u ICpjb25uLAorCQkgICAgIHVuc2lnbmVkIGludCBkb21pZCkKK3sKKwlzdHJ1 Y3QgZG9tYWluICpkID0gZmluZF9kb21haW5fc3RydWN0KGRvbWlkKTsKKwlj aGFyICpyZXNwOworCWludCB0YTsKKworCWlmICghZCkKKwkJcmV0dXJuIEVO T0VOVDsKKworCXRhID0gZC0+Y29ubiA/IGQtPmNvbm4tPnRyYW5zYWN0aW9u X3N0YXJ0ZWQgOiAwOworCXJlc3AgPSB0YWxsb2NfYXNwcmludGYoY3R4LCAi RG9tYWluICV1OlxuIiwgZG9taWQpOworCWlmICghcmVzcCkKKwkJcmV0dXJu IEVOT01FTTsKKworI2RlZmluZSBlbnQodCwgZSkgXAorCXJlc3AgPSB0YWxs b2NfYXNwcmludGZfYXBwZW5kKHJlc3AsICIlLTE2czogJThkXG4iLCAjdCwg ZSk7IFwKKwlpZiAoIXJlc3ApIHJldHVybiBFTk9NRU0KKworCWVudChub2Rl cywgZC0+bmJlbnRyeSk7CisJZW50KHdhdGNoZXMsIGQtPm5id2F0Y2gpOwor CWVudCh0cmFuc2FjdGlvbnMsIHRhKTsKKwllbnQob3V0c3RhbmRpbmcsIGQt Pm5ib3V0c3RhbmRpbmcpOworCWVudChtZW1vcnksIGQtPm1lbW9yeSk7CisK KyN1bmRlZiBlbnQKKworCXNlbmRfcmVwbHkoY29ubiwgWFNfQ09OVFJPTCwg cmVzcCwgc3RybGVuKHJlc3ApICsgMSk7CisKKwlyZXR1cm4gMDsKK30KKwog c3RhdGljIHN0cnVjdCBkb21haW4gKmFsbG9jX2RvbWFpbihjb25zdCB2b2lk ICpjb250ZXh0LCB1bnNpZ25lZCBpbnQgZG9taWQpCiB7CiAJc3RydWN0IGRv bWFpbiAqZG9tYWluOwpkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2RvbWFpbi5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Rv bWFpbi5oCmluZGV4IGQzNDJlNWU4NjdlZC4uNWI4NmE5MmUxYjViIDEwMDY0 NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgKKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oCkBAIC04OCw2 ICs4OCw4IEBAIGludCBkb21haW5fd2F0Y2goc3RydWN0IGNvbm5lY3Rpb24g KmNvbm4pOwogdm9pZCBkb21haW5fb3V0c3RhbmRpbmdfaW5jKHN0cnVjdCBj b25uZWN0aW9uICpjb25uKTsKIHZvaWQgZG9tYWluX291dHN0YW5kaW5nX2Rl YyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubik7CiB2b2lkIGRvbWFpbl9vdXRz dGFuZGluZ19kb21pZF9kZWModW5zaWduZWQgaW50IGRvbWlkKTsKK2ludCBk b21haW5fZ2V0X3F1b3RhKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sCisJCSAgICAgdW5zaWduZWQgaW50IGRvbWlkKTsKIAog LyogU3BlY2lhbCBub2RlIHBlcm1pc3Npb24gaGFuZGxpbmcuICovCiBpbnQg c2V0X3Blcm1zX3NwZWNpYWwoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNv bnN0IGNoYXIgKm5hbWUsCg== --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Nov 01 12:15:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 12:15:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434125.686840 (Exim 4.92) (envelope-from ) id 1opqB7-0005DA-4N; Tue, 01 Nov 2022 12:15:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434125.686840; Tue, 01 Nov 2022 12:15:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opqB7-0005D3-0u; Tue, 01 Nov 2022 12:15:37 +0000 Received: by outflank-mailman (input) for mailman id 434125; Tue, 01 Nov 2022 12:15:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppxA-0004vc-Uq for xen-devel@lists.xen.org; Tue, 01 Nov 2022 12:01:13 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d8322f92-59dc-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 13:00:57 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oppwm-0005a0-Lz; Tue, 01 Nov 2022 12:00:48 +0000 Received: from jgross by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oppwm-0005ZF-LH; Tue, 01 Nov 2022 12:00:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8322f92-59dc-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=MwmXhCW17fuWS6K5pLZJBXuGP1D9uNG4Nmw73+6WPGw=; b=CHZZt2FYZFGjpoUie2GqyCNrRh 7UclCyPwTLHuzFKgLDSxafb8ejyFbcDQvA1LvM7fpkAy+vqQ/FDdniVgvNl7Y8bnWLvUmkTDsQA2e eCO4+kJPcO9rkZkWvBstEiVMmraInLUEsLL2xtQwThoCoYIWoM1aGgTdyY9lVgq1ShtQ=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 421 v2 (CVE-2022-42325,CVE-2022-42326) - Xenstore: Guests can create arbitrary number of nodes via transactions Message-Id: Date: Tue, 01 Nov 2022 12:00:48 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-42325,CVE-2022-42326 / XSA-421 version 2 Xenstore: Guests can create arbitrary number of nodes via transactions UPDATES IN VERSION 2 ==================== Fix typo in title. Public release. ISSUE DESCRIPTION ================= In case a node has been created in a transaction and it is later deleted in the same transaction, the transaction will be terminated with an error. As this error is encountered only when handling the deleted node at transaction finalization, the transaction will have been performed partially and without updating the accounting information. This will enable a malicious guest to create arbitrary number of nodes. IMPACT ====== A malicious guest can cause memory shortage in xenstored, resulting in a Denial of Service (DoS) of xenstored. This will inhibit creating new guests and changing the configuration of already running guests. VULNERABLE SYSTEMS ================== All systems running Xen version 4.9 and newer are affected. Only systems running the C variant of Xenstore (xenstored or xenstore- stubdom) are vulnerable. Systems using the Ocaml variant of Xenstore (oxenstored) are not vulnerable. MITIGATION ========== Running oxenstored instead of xenstored will avoid the vulnerability. CREDITS ======= This issue was discovered by Julien Grall of Amazon. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa421/xsa421-??.patch xen-unstable, Xen 4.16.x xsa421/xsa421-4.15-??.patch Xen 4.15.x - 4.13.x $ sha256sum xsa421* xsa421*/* c2184bfb9f84220c648531e1ba13a1db0533019c999622e605a6000393e97e65 xsa421.meta eb2c5ef828e75c79a5f2eb3274a191d3b5d13107db792b8ba2b664ef335a738e xsa421/xsa421-01.patch 50532ad32975fdaa2674e454da125d5d44d5b471f3cf7c91f24d4128e2e4d090 xsa421/xsa421-02.patch 7ea5a47c293fd2379ec99ef88e29d4a19f03221aa731a600da510f61ff702be9 xsa421/xsa421-4.15-01.patch 8198a41789ed2c63f79f64ea491d9ebbf6d31b78a47e0ff0bbf3db8257fc5f39 xsa421/xsa421-4.15-02.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNg+7IMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZgUUH/19VNMAsM8ROQ/MWuba28+8Y7iwwi/+fg5byAefj vsQp+VfTODpvfQDngfqt43LhzHZ2YnUJqvsvteDiQKRrLtqakR5xrfAN5pNnzv8Q PJQfIlsaxyVbeUWdsc2BPuQIdPi9hGGxVjpxTfLNSpbIk0E7pXzeztQKW7buxERv vFLh358t2FBXXwpMD9qFHcTZX+tz9nVg9/0/POoiBb/7LKrmNQRJ3FmvqmgKwsyu qzZli4eDkHouq/ay5RZKnhurbRxVe80yJ8yTE26AHgZayZUMkLRbTezKaUfkCDD1 Fb2wFmhOj0nfEl4taql2P4du5emFYezMVWy1JKP4y+4i0DQ= =nNY0 -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa421.meta" Content-Disposition: attachment; filename="xsa421.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MjEsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIw YmU2M2MyNjE1YjI2ODAwMWY3Y2M5YjcyY2UyNWVlZDk1MjczN2RjIiwKICAg ICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICA0MTQsCiAgICAgICAg ICAgIDQxNSwKICAgICAgICAgICAgMzI2LAogICAgICAgICAgICA0MTYsCiAg ICAgICAgICAgIDQxNywKICAgICAgICAgICAgNDE4LAogICAgICAgICAgICA0 MTksCiAgICAgICAgICAgIDQyMAogICAgICAgICAgXSwKICAgICAgICAgICJQ YXRjaGVzIjogWwogICAgICAgICAgICAieHNhNDIxL3hzYTQyMS00LjE1LT8/ LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwK ICAgICI0LjE0IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVu IjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIwMTZkZTYyNzQ3YjI2ZWFk NWE1Yzc2M2I2NDBmZThlMjA1Y2QxODJiIiwKICAgICAgICAgICJQcmVyZXFz IjogWwogICAgICAgICAgICA0MTQsCiAgICAgICAgICAgIDQxNSwKICAgICAg ICAgICAgMzI2LAogICAgICAgICAgICA0MTYsCiAgICAgICAgICAgIDQxNywK ICAgICAgICAgICAgNDE4LAogICAgICAgICAgICA0MTksCiAgICAgICAgICAg IDQyMAogICAgICAgICAgXSwKICAgICAgICAgICJQYXRjaGVzIjogWwogICAg ICAgICAgICAieHNhNDIxL3hzYTQyMS00LjE1LT8/LnBhdGNoIgogICAgICAg ICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE1Ijogewog ICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAg IlN0YWJsZVJlZiI6ICI4MTY1ODBhZmRkMTczMGQ0Zjg1ZjY0NDc3YTI0MmE0 MzlhZjFjZGY4IiwKICAgICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAg ICA0MTQsCiAgICAgICAgICAgIDQxNSwKICAgICAgICAgICAgMzI2LAogICAg ICAgICAgICA0MTYsCiAgICAgICAgICAgIDQxNywKICAgICAgICAgICAgNDE4 LAogICAgICAgICAgICA0MTksCiAgICAgICAgICAgIDQyMAogICAgICAgICAg XSwKICAgICAgICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhNDIx L3hzYTQyMS00LjE1LT8/LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0K ICAgICAgfQogICAgfSwKICAgICI0LjE2IjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIx YmNlN2ZiMWY3MDJkYTRmN2E3NDljNmYxNDU3ZWNiMjBiZjc0ZmNhIiwKICAg ICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICA0MTIsCiAgICAgICAg ICAgIDQxNCwKICAgICAgICAgICAgNDE1LAogICAgICAgICAgICAzMjYsCiAg ICAgICAgICAgIDQxNiwKICAgICAgICAgICAgNDE3LAogICAgICAgICAgICA0 MTgsCiAgICAgICAgICAgIDQxOSwKICAgICAgICAgICAgNDIwCiAgICAgICAg ICBdLAogICAgICAgICAgIlBhdGNoZXMiOiBbCiAgICAgICAgICAgICJ4c2E0 MjEveHNhNDIxLT8/LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAg ICAgfQogICAgfSwKICAgICJtYXN0ZXIiOiB7CiAgICAgICJSZWNpcGVzIjog ewogICAgICAgICJ4ZW4iOiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogImNj NDc0N2JlOGJhMTU3YTNiMzEwOTIxZTllZTA3ZmI4NTQ1YWEyMDYiLAogICAg ICAgICAgIlByZXJlcXMiOiBbCiAgICAgICAgICAgIDQxMiwKICAgICAgICAg ICAgNDE0LAogICAgICAgICAgICA0MTUsCiAgICAgICAgICAgIDMyNiwKICAg ICAgICAgICAgNDE2LAogICAgICAgICAgICA0MTcsCiAgICAgICAgICAgIDQx OCwKICAgICAgICAgICAgNDE5LAogICAgICAgICAgICA0MjAKICAgICAgICAg IF0sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQy MS94c2E0MjEtPz8ucGF0Y2giCiAgICAgICAgICBdCiAgICAgICAgfQogICAg ICB9CiAgICB9CiAgfQp9 --=separator Content-Type: application/octet-stream; name="xsa421/xsa421-01.patch" Content-Disposition: attachment; filename="xsa421/xsa421-01.patch" Content-Transfer-Encoding: base64 RnJvbSA5MTY2ODY5ZTdlNjUzMGJlZmRkZmQ4YmI0NmZmMzc0MzZhMzhlZmMx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTMgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGZpeCBkZWxl dGluZyBub2RlIGluIHRyYW5zYWN0aW9uCgpJbiBjYXNlIGEgbm9kZSBoYXMg YmVlbiBjcmVhdGVkIGluIGEgdHJhbnNhY3Rpb24gYW5kIGl0IGlzIGxhdGVy CmRlbGV0ZWQgaW4gdGhlIHNhbWUgdHJhbnNhY3Rpb24sIHRoZSB0cmFuc2Fj dGlvbiB3aWxsIGJlIHRlcm1pbmF0ZWQKd2l0aCBhbiBlcnJvci4KCkFzIHRo aXMgZXJyb3IgaXMgZW5jb3VudGVyZWQgb25seSB3aGVuIGhhbmRsaW5nIHRo ZSBkZWxldGVkIG5vZGUgYXQKdHJhbnNhY3Rpb24gZmluYWxpemF0aW9uLCB0 aGUgdHJhbnNhY3Rpb24gd2lsbCBoYXZlIGJlZW4gcGVyZm9ybWVkCnBhcnRp YWxseSBhbmQgd2l0aG91dCB1cGRhdGluZyB0aGUgYWNjb3VudGluZyBpbmZv cm1hdGlvbi4gVGhpcyB3aWxsCmVuYWJsZSBhIG1hbGljaW91cyBndWVzdCB0 byBjcmVhdGUgYXJiaXRyYXJ5IG51bWJlciBvZiBub2Rlcy4KClRoaXMgaXMg cGFydCBvZiBYU0EtNDIxIC8gQ1ZFLTIwMjItNDIzMjUuCgpSZXBvcnRlZC1i eTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9m Zi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpUZXN0ZWQt Ynk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClJldmlld2Vk LWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAt LWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5j IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKaW5k ZXggM2UzZWI0NzMyNmNjLi43ZmZlMjFiYjUyODUgMTAwNjQ0Ci0tLSBhL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCisrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCkBAIC00MTgs NyArNDE4LDEzIEBAIHN0YXRpYyBpbnQgZmluYWxpemVfdHJhbnNhY3Rpb24o c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQkJCQkgICB0cnVlKTsKIAkJ CQl0YWxsb2NfZnJlZShkYXRhLmRwdHIpOwogCQkJfSBlbHNlIHsKLQkJCQly ZXQgPSBkb190ZGJfZGVsZXRlKGNvbm4sICZrZXksIE5VTEwpOworCQkJCS8q CisJCQkJICogQSBub2RlIGhhdmluZyBiZWVuIGNyZWF0ZWQgYW5kIGxhdGVy IGRlbGV0ZWQKKwkJCQkgKiBpbiB0aGlzIHRyYW5zYWN0aW9uIHdpbGwgaGF2 ZSBubyBnZW5lcmF0aW9uCisJCQkJICogaW5mb3JtYXRpb24gc3RvcmVkLgor CQkJCSAqLworCQkJCXJldCA9IChpLT5nZW5lcmF0aW9uID09IE5PX0dFTkVS QVRJT04pCisJCQkJICAgICAgPyAwIDogZG9fdGRiX2RlbGV0ZShjb25uLCAm a2V5LCBOVUxMKTsKIAkJCX0KIAkJCWlmIChyZXQpCiAJCQkJZ290byBlcnI7 Cg== --=separator Content-Type: application/octet-stream; name="xsa421/xsa421-02.patch" Content-Disposition: attachment; filename="xsa421/xsa421-02.patch" Content-Transfer-Encoding: base64 RnJvbSAwOWZjMjJmZWE4YTQ2ODljNWU1NjNiYTRhMmZhOTU5MjgyMDcxNzky IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTQgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGhhcmRlbiB0 cmFuc2FjdGlvbiBmaW5hbGl6YXRpb24gYWdhaW5zdCBlcnJvcnMKCldoZW4g ZmluYWxpemluZyBhIHRyYW5zYWN0aW9uLCBhbnkgZXJyb3Igb2NjdXJyaW5n IGFmdGVyIGNoZWNraW5nIGZvcgpjb25mbGljdHMgd2lsbCByZXN1bHQgaW4g dGhlIHRyYW5zYWN0aW9uIGJlaW5nIHBlcmZvcm1lZCBvbmx5CnBhcnRpYWxs eSB0b2RheS4gQWRkaXRpb25hbGx5IGFjY291bnRpbmcgZGF0YSB3aWxsIG5v dCBiZSB1cGRhdGVkIGF0CnRoZSBlbmQgb2YgdGhlIHRyYW5zYWN0aW9uLCB3 aGljaCBtaWdodCByZXN1bHQgaW4gZnVydGhlciBwcm9ibGVtcwpsYXRlci4K CkF2b2lkIHRob3NlIHByb2JsZW1zIGJ5IG11bHRpcGxlIG1vZGlmaWNhdGlv bnM6CgotIGZyZWUgYW55IHRyYW5zYWN0aW9uIHNwZWNpZmljIG5vZGVzIHdo aWNoIGRvbid0IG5lZWQgdG8gYmUgY29tbWl0dGVkCiAgYXMgdGhleSBoYXZl bid0IGJlZW4gd3JpdHRlbiBkdXJpbmcgdGhlIHRyYW5zYWN0aW9uIGFzIHNv b24gYXMgdGhlaXIKICBnZW5lcmF0aW9uIGNvdW50IGhhcyBiZWVuIHZlcmlm aWVkLCB0aGlzIHdpbGwgcmVkdWNlIHRoZSByaXNrIG9mCiAgb3V0LW9mLW1l bW9yeSBzaXR1YXRpb25zCgotIHN0b3JlIHRoZSB0cmFuc2FjdGlvbiBzcGVj aWZpYyBub2RlIG5hbWUgaW4gc3RydWN0IGFjY2Vzc2VkX25vZGUgaW4KICBv cmRlciB0byBhdm9pZCB0aGUgbmVlZCB0byBhbGxvY2F0ZSBhZGRpdGlvbmFs IG1lbW9yeSBmb3IgaXQgd2hlbgogIGZpbmFsaXppbmcgdGhlIHRyYW5zYWN0 aW9uCgotIGRvbid0IHN0b3AgdGhlIHRyYW5zYWN0aW9uIGZpbmFsaXphdGlv biB3aGVuIGhpdHRpbmcgYW4gZXJyb3IKICBjb25kaXRpb24sIGJ1dCB0cnkg dG8gY29udGludWUgdG8gaGFuZGxlIGFsbCBtb2RpZmllZCBub2RlcwoKLSBp biBjYXNlIG9mIGEgZGV0ZWN0ZWQgZXJyb3IgZG8gdGhlIGFjY291bnRpbmcg dXBkYXRlIGFzIG5lZWRlZCBhbmQKICBjYWxsIHRoZSBkYXRhIGJhc2UgY2hl Y2tpbmcgb25seSBhZnRlciB0aGF0CgotIGlmIHdyaXRpbmcgYSBub2RlIGlu IGEgdHJhbnNhY3Rpb24gaXMgZmFpbGluZyAoZS5nLiBkdWUgdG8gYSBmYWls ZWQKICBxdW90YSBjaGVjayksIGZhaWwgdGhlIHRyYW5zYWN0aW9uLCBhcyBw cmlvciBjaGFuZ2VzIHRvIHN0cnVjdAogIGFjY2Vzc2VkX25vZGUgY2FuJ3Qg ZWFzaWx5IGJlIHVuZG9uZSBpbiB0aGF0IGNhc2UKClRoaXMgaXMgcGFydCBv ZiBYU0EtNDIxIC8gQ1ZFLTIwMjItNDIzMjYuCgpSZXBvcnRlZC1ieTogSnVs aWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9mZi1ieTog SnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog SnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KVGVzdGVkLWJ5OiBK dWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdpdCBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IDM2ZmI0YTgzMjgzNC4uNDc2 ZDVjNmQ1MWJkIDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKQEAgLTcyMyw4ICs3MjMsNyBAQCBzdHJ1Y3Qgbm9kZSAqcmVhZF9ub2Rl KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsCiAJ CXJldHVybiBOVUxMOwogCX0KIAotCWlmICh0cmFuc2FjdGlvbl9wcmVwZW5k KGNvbm4sIG5hbWUsICZrZXkpKQotCQlyZXR1cm4gTlVMTDsKKwl0cmFuc2Fj dGlvbl9wcmVwZW5kKGNvbm4sIG5hbWUsICZrZXkpOwogCiAJZGF0YSA9IHRk Yl9mZXRjaCh0ZGJfY3R4LCBrZXkpOwogCkBAIC04NDIsMTAgKzg0MSwyMSBA QCBpbnQgd3JpdGVfbm9kZV9yYXcoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IFREQl9EQVRBICprZXksIHN0cnVjdCBub2RlICpub2RlLAogc3RhdGljIGlu dCB3cml0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qg bm9kZSAqbm9kZSwKIAkJICAgICAgYm9vbCBub19xdW90YV9jaGVjaykKIHsK KwlpbnQgcmV0OworCiAJaWYgKGFjY2Vzc19ub2RlKGNvbm4sIG5vZGUsIE5P REVfQUNDRVNTX1dSSVRFLCAmbm9kZS0+a2V5KSkKIAkJcmV0dXJuIGVycm5v OwogCi0JcmV0dXJuIHdyaXRlX25vZGVfcmF3KGNvbm4sICZub2RlLT5rZXks IG5vZGUsIG5vX3F1b3RhX2NoZWNrKTsKKwlyZXQgPSB3cml0ZV9ub2RlX3Jh dyhjb25uLCAmbm9kZS0+a2V5LCBub2RlLCBub19xdW90YV9jaGVjayk7CisJ aWYgKHJldCAmJiBjb25uICYmIGNvbm4tPnRyYW5zYWN0aW9uKSB7CisJCS8q CisJCSAqIFJldmVydGluZyBhY2Nlc3Nfbm9kZSgpIGlzIGhhcmQsIHNvIGp1 c3QgZmFpbCB0aGUKKwkJICogdHJhbnNhY3Rpb24uCisJCSAqLworCQlmYWls X3RyYW5zYWN0aW9uKGNvbm4tPnRyYW5zYWN0aW9uKTsKKwl9CisKKwlyZXR1 cm4gcmV0OwogfQogCiB1bnNpZ25lZCBpbnQgcGVybV9mb3JfY29ubihzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwKZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKaW5kZXggN2ZmZTIxYmI1Mjg1Li5h Yzg1NDE5N2NhZGIgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF90cmFuc2FjdGlvbi5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0 b3JlZF90cmFuc2FjdGlvbi5jCkBAIC0xMTQsNyArMTE0LDggQEAgc3RydWN0 IGFjY2Vzc2VkX25vZGUKIAlzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7CiAKIAkv KiBUaGUgbmFtZSBvZiB0aGUgbm9kZS4gKi8KLQljaGFyICpub2RlOworCWNo YXIgKnRyYW5zX25hbWU7CS8qIFRyYW5zYWN0aW9uIHNwZWNpZmljIG5hbWUu ICovCisJY2hhciAqbm9kZTsJCS8qIE1haW4gZGF0YSBiYXNlIG5hbWUuICov CiAKIAkvKiBHZW5lcmF0aW9uIGNvdW50IChvciBOT19HRU5FUkFUSU9OKSBm b3IgY29uZmxpY3QgY2hlY2tpbmcuICovCiAJdWludDY0X3QgZ2VuZXJhdGlv bjsKQEAgLTE5OSwyNSArMjAwLDIwIEBAIHN0YXRpYyBjaGFyICp0cmFuc2Fj dGlvbl9nZXRfbm9kZV9uYW1lKHZvaWQgKmN0eCwgc3RydWN0IHRyYW5zYWN0 aW9uICp0cmFucywKICAqIFByZXBlbmQgdGhlIHRyYW5zYWN0aW9uIHRvIG5h bWUgaWYgbm9kZSBoYXMgYmVlbiBtb2RpZmllZCBpbiB0aGUgY3VycmVudAog ICogdHJhbnNhY3Rpb24uCiAgKi8KLWludCB0cmFuc2FjdGlvbl9wcmVwZW5k KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpuYW1lLAot CQkJVERCX0RBVEEgKmtleSkKK3ZvaWQgdHJhbnNhY3Rpb25fcHJlcGVuZChz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3QgY2hhciAqbmFtZSwKKwkJ CSBUREJfREFUQSAqa2V5KQogewotCWNoYXIgKnRkYl9uYW1lOworCXN0cnVj dCBhY2Nlc3NlZF9ub2RlICppOwogCi0JaWYgKCFjb25uIHx8ICFjb25uLT50 cmFuc2FjdGlvbiB8fAotCSAgICAhZmluZF9hY2Nlc3NlZF9ub2RlKGNvbm4t PnRyYW5zYWN0aW9uLCBuYW1lKSkgewotCQlzZXRfdGRiX2tleShuYW1lLCBr ZXkpOwotCQlyZXR1cm4gMDsKKwlpZiAoY29ubiAmJiBjb25uLT50cmFuc2Fj dGlvbikgeworCQlpID0gZmluZF9hY2Nlc3NlZF9ub2RlKGNvbm4tPnRyYW5z YWN0aW9uLCBuYW1lKTsKKwkJaWYgKGkpIHsKKwkJCXNldF90ZGJfa2V5KGkt PnRyYW5zX25hbWUsIGtleSk7CisJCQlyZXR1cm47CisJCX0KIAl9CiAKLQl0 ZGJfbmFtZSA9IHRyYW5zYWN0aW9uX2dldF9ub2RlX25hbWUoY29ubi0+dHJh bnNhY3Rpb24sCi0JCQkJCSAgICAgY29ubi0+dHJhbnNhY3Rpb24sIG5hbWUp OwotCWlmICghdGRiX25hbWUpCi0JCXJldHVybiBlcnJubzsKLQotCXNldF90 ZGJfa2V5KHRkYl9uYW1lLCBrZXkpOwotCi0JcmV0dXJuIDA7CisJc2V0X3Rk Yl9rZXkobmFtZSwga2V5KTsKIH0KIAogLyoKQEAgLTI0MCw3ICsyMzYsNiBA QCBpbnQgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0 cnVjdCBub2RlICpub2RlLAogCXN0cnVjdCBhY2Nlc3NlZF9ub2RlICppID0g TlVMTDsKIAlzdHJ1Y3QgdHJhbnNhY3Rpb24gKnRyYW5zOwogCVREQl9EQVRB IGxvY2FsX2tleTsKLQljb25zdCBjaGFyICp0cmFuc19uYW1lID0gTlVMTDsK IAlpbnQgcmV0OwogCWJvb2wgaW50cm9kdWNlID0gZmFsc2U7CiAKQEAgLTI1 OSwxMCArMjU0LDYgQEAgaW50IGFjY2Vzc19ub2RlKHN0cnVjdCBjb25uZWN0 aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIAogCXRyYW5zID0gY29u bi0+dHJhbnNhY3Rpb247CiAKLQl0cmFuc19uYW1lID0gdHJhbnNhY3Rpb25f Z2V0X25vZGVfbmFtZShub2RlLCB0cmFucywgbm9kZS0+bmFtZSk7Ci0JaWYg KCF0cmFuc19uYW1lKQotCQlnb3RvIG5vbWVtOwotCiAJaSA9IGZpbmRfYWNj ZXNzZWRfbm9kZSh0cmFucywgbm9kZS0+bmFtZSk7CiAJaWYgKCFpKSB7CiAJ CWlmICh0cmFucy0+bm9kZXMgPj0gcXVvdGFfdHJhbnNfbm9kZXMgJiYKQEAg LTI3Myw5ICsyNjQsMTAgQEAgaW50IGFjY2Vzc19ub2RlKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSwKIAkJaSA9IHRhbGxv Y196ZXJvKHRyYW5zLCBzdHJ1Y3QgYWNjZXNzZWRfbm9kZSk7CiAJCWlmICgh aSkKIAkJCWdvdG8gbm9tZW07Ci0JCWktPm5vZGUgPSB0YWxsb2Nfc3RyZHVw KGksIG5vZGUtPm5hbWUpOwotCQlpZiAoIWktPm5vZGUpCisJCWktPnRyYW5z X25hbWUgPSB0cmFuc2FjdGlvbl9nZXRfbm9kZV9uYW1lKGksIHRyYW5zLCBu b2RlLT5uYW1lKTsKKwkJaWYgKCFpLT50cmFuc19uYW1lKQogCQkJZ290byBu b21lbTsKKwkJaS0+bm9kZSA9IHN0cmNocihpLT50cmFuc19uYW1lLCAnLycp ICsgMTsKIAkJaWYgKG5vZGUtPmdlbmVyYXRpb24gIT0gTk9fR0VORVJBVElP TiAmJiBub2RlLT5wZXJtcy5udW0pIHsKIAkJCWktPnBlcm1zLnAgPSB0YWxs b2NfYXJyYXkoaSwgc3RydWN0IHhzX3Blcm1pc3Npb25zLAogCQkJCQkJICBu b2RlLT5wZXJtcy5udW0pOwpAQCAtMzAyLDcgKzI5NCw3IEBAIGludCBhY2Nl c3Nfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUg Km5vZGUsCiAJCQlpLT5nZW5lcmF0aW9uID0gbm9kZS0+Z2VuZXJhdGlvbjsK IAkJCWktPmNoZWNrX2dlbiA9IHRydWU7CiAJCQlpZiAobm9kZS0+Z2VuZXJh dGlvbiAhPSBOT19HRU5FUkFUSU9OKSB7Ci0JCQkJc2V0X3RkYl9rZXkodHJh bnNfbmFtZSwgJmxvY2FsX2tleSk7CisJCQkJc2V0X3RkYl9rZXkoaS0+dHJh bnNfbmFtZSwgJmxvY2FsX2tleSk7CiAJCQkJcmV0ID0gd3JpdGVfbm9kZV9y YXcoY29ubiwgJmxvY2FsX2tleSwgbm9kZSwgdHJ1ZSk7CiAJCQkJaWYgKHJl dCkKIAkJCQkJZ290byBlcnI7CkBAIC0zMjEsNyArMzEzLDcgQEAgaW50IGFj Y2Vzc19ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9k ZSAqbm9kZSwKIAkJcmV0dXJuIC0xOwogCiAJaWYgKGtleSkgewotCQlzZXRf dGRiX2tleSh0cmFuc19uYW1lLCBrZXkpOworCQlzZXRfdGRiX2tleShpLT50 cmFuc19uYW1lLCBrZXkpOwogCQlpZiAodHlwZSA9PSBOT0RFX0FDQ0VTU19X UklURSkKIAkJCWktPnRhX25vZGUgPSB0cnVlOwogCQlpZiAodHlwZSA9PSBO T0RFX0FDQ0VTU19ERUxFVEUpCkBAIC0zMzMsNyArMzI1LDYgQEAgaW50IGFj Y2Vzc19ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9k ZSAqbm9kZSwKIG5vbWVtOgogCXJldCA9IEVOT01FTTsKIGVycjoKLQl0YWxs b2NfZnJlZSgodm9pZCAqKXRyYW5zX25hbWUpOwogCXRhbGxvY19mcmVlKGkp OwogCXRyYW5zLT5mYWlsID0gdHJ1ZTsKIAllcnJubyA9IHJldDsKQEAgLTM3 MSwxMDAgKzM2Miw5MCBAQCB2b2lkIHF1ZXVlX3dhdGNoZXMoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIGNvbnN0IGNoYXIgKm5hbWUsIGJvb2wgd2F0Y2hf ZXhhY3QpCiAgKiBiYXNlLgogICovCiBzdGF0aWMgaW50IGZpbmFsaXplX3Ry YW5zYWN0aW9uKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLAotCQkJCXN0cnVj dCB0cmFuc2FjdGlvbiAqdHJhbnMpCisJCQkJc3RydWN0IHRyYW5zYWN0aW9u ICp0cmFucywgYm9vbCAqaXNfY29ycnVwdCkKIHsKLQlzdHJ1Y3QgYWNjZXNz ZWRfbm9kZSAqaTsKKwlzdHJ1Y3QgYWNjZXNzZWRfbm9kZSAqaSwgKm47CiAJ VERCX0RBVEEga2V5LCB0YV9rZXksIGRhdGE7CiAJc3RydWN0IHhzX3RkYl9y ZWNvcmRfaGRyICpoZHI7CiAJdWludDY0X3QgZ2VuOwotCWNoYXIgKnRyYW5z X25hbWU7Ci0JaW50IHJldDsKIAotCWxpc3RfZm9yX2VhY2hfZW50cnkoaSwg JnRyYW5zLT5hY2Nlc3NlZCwgbGlzdCkgewotCQlpZiAoIWktPmNoZWNrX2dl bikKLQkJCWNvbnRpbnVlOworCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZShp LCBuLCAmdHJhbnMtPmFjY2Vzc2VkLCBsaXN0KSB7CisJCWlmIChpLT5jaGVj a19nZW4pIHsKKwkJCXNldF90ZGJfa2V5KGktPm5vZGUsICZrZXkpOworCQkJ ZGF0YSA9IHRkYl9mZXRjaCh0ZGJfY3R4LCBrZXkpOworCQkJaGRyID0gKHZv aWQgKilkYXRhLmRwdHI7CisJCQlpZiAoIWRhdGEuZHB0cikgeworCQkJCWlm ICh0ZGJfZXJyb3IodGRiX2N0eCkgIT0gVERCX0VSUl9OT0VYSVNUKQorCQkJ CQlyZXR1cm4gRUlPOworCQkJCWdlbiA9IE5PX0dFTkVSQVRJT047CisJCQl9 IGVsc2UKKwkJCQlnZW4gPSBoZHItPmdlbmVyYXRpb247CisJCQl0YWxsb2Nf ZnJlZShkYXRhLmRwdHIpOworCQkJaWYgKGktPmdlbmVyYXRpb24gIT0gZ2Vu KQorCQkJCXJldHVybiBFQUdBSU47CisJCX0KIAotCQlzZXRfdGRiX2tleShp LT5ub2RlLCAma2V5KTsKLQkJZGF0YSA9IHRkYl9mZXRjaCh0ZGJfY3R4LCBr ZXkpOwotCQloZHIgPSAodm9pZCAqKWRhdGEuZHB0cjsKLQkJaWYgKCFkYXRh LmRwdHIpIHsKLQkJCWlmICh0ZGJfZXJyb3IodGRiX2N0eCkgIT0gVERCX0VS Ul9OT0VYSVNUKQotCQkJCXJldHVybiBFSU87Ci0JCQlnZW4gPSBOT19HRU5F UkFUSU9OOwotCQl9IGVsc2UKLQkJCWdlbiA9IGhkci0+Z2VuZXJhdGlvbjsK LQkJdGFsbG9jX2ZyZWUoZGF0YS5kcHRyKTsKLQkJaWYgKGktPmdlbmVyYXRp b24gIT0gZ2VuKQotCQkJcmV0dXJuIEVBR0FJTjsKKwkJLyogRW50cmllcyBm b3IgdW5tb2RpZmllZCBub2RlcyBjYW4gYmUgcmVtb3ZlZCBlYXJseS4gKi8K KwkJaWYgKCFpLT5tb2RpZmllZCkgeworCQkJaWYgKGktPnRhX25vZGUpIHsK KwkJCQlzZXRfdGRiX2tleShpLT50cmFuc19uYW1lLCAmdGFfa2V5KTsKKwkJ CQlpZiAoZG9fdGRiX2RlbGV0ZShjb25uLCAmdGFfa2V5LCBOVUxMKSkKKwkJ CQkJcmV0dXJuIEVJTzsKKwkJCX0KKwkJCWxpc3RfZGVsKCZpLT5saXN0KTsK KwkJCXRhbGxvY19mcmVlKGkpOworCQl9CiAJfQogCiAJd2hpbGUgKChpID0g bGlzdF90b3AoJnRyYW5zLT5hY2Nlc3NlZCwgc3RydWN0IGFjY2Vzc2VkX25v ZGUsIGxpc3QpKSkgewotCQl0cmFuc19uYW1lID0gdHJhbnNhY3Rpb25fZ2V0 X25vZGVfbmFtZShpLCB0cmFucywgaS0+bm9kZSk7Ci0JCWlmICghdHJhbnNf bmFtZSkKLQkJCS8qIFdlIGFyZSBkb29tZWQ6IHRoZSB0cmFuc2FjdGlvbiBp cyBvbmx5IHBhcnRpYWwuICovCi0JCQlnb3RvIGVycjsKLQotCQlzZXRfdGRi X2tleSh0cmFuc19uYW1lLCAmdGFfa2V5KTsKLQotCQlpZiAoaS0+bW9kaWZp ZWQpIHsKLQkJCXNldF90ZGJfa2V5KGktPm5vZGUsICZrZXkpOwotCQkJaWYg KGktPnRhX25vZGUpIHsKLQkJCQlkYXRhID0gdGRiX2ZldGNoKHRkYl9jdHgs IHRhX2tleSk7Ci0JCQkJaWYgKCFkYXRhLmRwdHIpCi0JCQkJCWdvdG8gZXJy OworCQlzZXRfdGRiX2tleShpLT5ub2RlLCAma2V5KTsKKwkJaWYgKGktPnRh X25vZGUpIHsKKwkJCXNldF90ZGJfa2V5KGktPnRyYW5zX25hbWUsICZ0YV9r ZXkpOworCQkJZGF0YSA9IHRkYl9mZXRjaCh0ZGJfY3R4LCB0YV9rZXkpOwor CQkJaWYgKGRhdGEuZHB0cikgewogCQkJCWhkciA9ICh2b2lkICopZGF0YS5k cHRyOwogCQkJCWhkci0+Z2VuZXJhdGlvbiA9ICsrZ2VuZXJhdGlvbjsKLQkJ CQlyZXQgPSBkb190ZGJfd3JpdGUoY29ubiwgJmtleSwgJmRhdGEsIE5VTEws Ci0JCQkJCQkgICB0cnVlKTsKKwkJCQkqaXNfY29ycnVwdCB8PSBkb190ZGJf d3JpdGUoY29ubiwgJmtleSwgJmRhdGEsCisJCQkJCQkJICAgIE5VTEwsIHRy dWUpOwogCQkJCXRhbGxvY19mcmVlKGRhdGEuZHB0cik7CisJCQkJaWYgKGRv X3RkYl9kZWxldGUoY29ubiwgJnRhX2tleSwgTlVMTCkpCisJCQkJCSppc19j b3JydXB0ID0gdHJ1ZTsKIAkJCX0gZWxzZSB7Ci0JCQkJLyoKLQkJCQkgKiBB IG5vZGUgaGF2aW5nIGJlZW4gY3JlYXRlZCBhbmQgbGF0ZXIgZGVsZXRlZAot CQkJCSAqIGluIHRoaXMgdHJhbnNhY3Rpb24gd2lsbCBoYXZlIG5vIGdlbmVy YXRpb24KLQkJCQkgKiBpbmZvcm1hdGlvbiBzdG9yZWQuCi0JCQkJICovCi0J CQkJcmV0ID0gKGktPmdlbmVyYXRpb24gPT0gTk9fR0VORVJBVElPTikKLQkJ CQkgICAgICA/IDAgOiBkb190ZGJfZGVsZXRlKGNvbm4sICZrZXksIE5VTEwp OwotCQkJfQotCQkJaWYgKHJldCkKLQkJCQlnb3RvIGVycjsKLQkJCWlmIChp LT5maXJlX3dhdGNoKSB7Ci0JCQkJZmlyZV93YXRjaGVzKGNvbm4sIHRyYW5z LCBpLT5ub2RlLCBOVUxMLAotCQkJCQkgICAgIGktPndhdGNoX2V4YWN0LAot CQkJCQkgICAgIGktPnBlcm1zLnAgPyAmaS0+cGVybXMgOiBOVUxMKTsKKwkJ CQkqaXNfY29ycnVwdCA9IHRydWU7CiAJCQl9CisJCX0gZWxzZSB7CisJCQkv KgorCQkJICogQSBub2RlIGhhdmluZyBiZWVuIGNyZWF0ZWQgYW5kIGxhdGVy IGRlbGV0ZWQKKwkJCSAqIGluIHRoaXMgdHJhbnNhY3Rpb24gd2lsbCBoYXZl IG5vIGdlbmVyYXRpb24KKwkJCSAqIGluZm9ybWF0aW9uIHN0b3JlZC4KKwkJ CSAqLworCQkJKmlzX2NvcnJ1cHQgfD0gKGktPmdlbmVyYXRpb24gPT0gTk9f R0VORVJBVElPTikKKwkJCQkgICAgICAgPyBmYWxzZQorCQkJCSAgICAgICA6 IGRvX3RkYl9kZWxldGUoY29ubiwgJmtleSwgTlVMTCk7CiAJCX0KKwkJaWYg KGktPmZpcmVfd2F0Y2gpCisJCQlmaXJlX3dhdGNoZXMoY29ubiwgdHJhbnMs IGktPm5vZGUsIE5VTEwsIGktPndhdGNoX2V4YWN0LAorCQkJCSAgICAgaS0+ cGVybXMucCA/ICZpLT5wZXJtcyA6IE5VTEwpOwogCi0JCWlmIChpLT50YV9u b2RlICYmIGRvX3RkYl9kZWxldGUoY29ubiwgJnRhX2tleSwgTlVMTCkpCi0J CQlnb3RvIGVycjsKIAkJbGlzdF9kZWwoJmktPmxpc3QpOwogCQl0YWxsb2Nf ZnJlZShpKTsKIAl9CiAKIAlyZXR1cm4gMDsKLQotZXJyOgotCWNvcnJ1cHQo Y29ubiwgIlBhcnRpYWwgdHJhbnNhY3Rpb24iKTsKLQlyZXR1cm4gRUlPOwog fQogCiBzdGF0aWMgaW50IGRlc3Ryb3lfdHJhbnNhY3Rpb24odm9pZCAqX3Ry YW5zYWN0aW9uKQogewogCXN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnMgPSBf dHJhbnNhY3Rpb247CiAJc3RydWN0IGFjY2Vzc2VkX25vZGUgKmk7Ci0JY2hh ciAqdHJhbnNfbmFtZTsKIAlUREJfREFUQSBrZXk7CiAKIAl3cmxfbnRyYW5z YWN0aW9ucy0tOwogCXRyYWNlX2Rlc3Ryb3kodHJhbnMsICJ0cmFuc2FjdGlv biIpOwogCXdoaWxlICgoaSA9IGxpc3RfdG9wKCZ0cmFucy0+YWNjZXNzZWQs IHN0cnVjdCBhY2Nlc3NlZF9ub2RlLCBsaXN0KSkpIHsKIAkJaWYgKGktPnRh X25vZGUpIHsKLQkJCXRyYW5zX25hbWUgPSB0cmFuc2FjdGlvbl9nZXRfbm9k ZV9uYW1lKGksIHRyYW5zLAotCQkJCQkJCSAgICAgICBpLT5ub2RlKTsKLQkJ CWlmICh0cmFuc19uYW1lKSB7Ci0JCQkJc2V0X3RkYl9rZXkodHJhbnNfbmFt ZSwgJmtleSk7Ci0JCQkJZG9fdGRiX2RlbGV0ZSh0cmFucy0+Y29ubiwgJmtl eSwgTlVMTCk7Ci0JCQl9CisJCQlzZXRfdGRiX2tleShpLT50cmFuc19uYW1l LCAma2V5KTsKKwkJCWRvX3RkYl9kZWxldGUodHJhbnMtPmNvbm4sICZrZXks IE5VTEwpOwogCQl9CiAJCWxpc3RfZGVsKCZpLT5saXN0KTsKIAkJdGFsbG9j X2ZyZWUoaSk7CkBAIC01NTYsNiArNTM3LDcgQEAgaW50IGRvX3RyYW5zYWN0 aW9uX2VuZChjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpj b25uLAogewogCWNvbnN0IGNoYXIgKmFyZyA9IG9uZWFyZyhpbik7CiAJc3Ry dWN0IHRyYW5zYWN0aW9uICp0cmFuczsKKwlib29sIGlzX2NvcnJ1cHQgPSBm YWxzZTsKIAlpbnQgcmV0OwogCiAJaWYgKCFhcmcgfHwgKCFzdHJlcShhcmcs ICJUIikgJiYgIXN0cmVxKGFyZywgIkYiKSkpCkBAIC01NzksMTMgKzU2MSwx NyBAQCBpbnQgZG9fdHJhbnNhY3Rpb25fZW5kKGNvbnN0IHZvaWQgKmN0eCwg c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCXJldCA9IHRyYW5zYWN0aW9u X2ZpeF9kb21haW5zKHRyYW5zLCBmYWxzZSk7CiAJCWlmIChyZXQpCiAJCQly ZXR1cm4gcmV0OwotCQlpZiAoZmluYWxpemVfdHJhbnNhY3Rpb24oY29ubiwg dHJhbnMpKQotCQkJcmV0dXJuIEVBR0FJTjsKKwkJcmV0ID0gZmluYWxpemVf dHJhbnNhY3Rpb24oY29ubiwgdHJhbnMsICZpc19jb3JydXB0KTsKKwkJaWYg KHJldCkKKwkJCXJldHVybiByZXQ7CiAKIAkJd3JsX2FwcGx5X2RlYml0X3Ry YW5zX2NvbW1pdChjb25uKTsKIAogCQkvKiBmaXggZG9tYWluIGVudHJ5IGZv ciBlYWNoIGNoYW5nZWQgZG9tYWluICovCiAJCXRyYW5zYWN0aW9uX2ZpeF9k b21haW5zKHRyYW5zLCB0cnVlKTsKKworCQlpZiAoaXNfY29ycnVwdCkKKwkJ CWNvcnJ1cHQoY29ubiwgInRyYW5zYWN0aW9uIGluY29uc2lzdGVuY3kiKTsK IAl9CiAJc2VuZF9hY2soY29ubiwgWFNfVFJBTlNBQ1RJT05fRU5EKTsKIApA QCAtNjYwLDcgKzY0Niw3IEBAIGludCBjaGVja190cmFuc2FjdGlvbnMoc3Ry dWN0IGhhc2h0YWJsZSAqaGFzaCkKIAlzdHJ1Y3QgY29ubmVjdGlvbiAqY29u bjsKIAlzdHJ1Y3QgdHJhbnNhY3Rpb24gKnRyYW5zOwogCXN0cnVjdCBhY2Nl c3NlZF9ub2RlICppOwotCWNoYXIgKnRuYW1lLCAqdG5vZGU7CisJY2hhciAq dG5hbWU7CiAKIAlsaXN0X2Zvcl9lYWNoX2VudHJ5KGNvbm4sICZjb25uZWN0 aW9ucywgbGlzdCkgewogCQlsaXN0X2Zvcl9lYWNoX2VudHJ5KHRyYW5zLCAm Y29ubi0+dHJhbnNhY3Rpb25fbGlzdCwgbGlzdCkgewpAQCAtNjcyLDExICs2 NTgsOCBAQCBpbnQgY2hlY2tfdHJhbnNhY3Rpb25zKHN0cnVjdCBoYXNodGFi bGUgKmhhc2gpCiAJCQlsaXN0X2Zvcl9lYWNoX2VudHJ5KGksICZ0cmFucy0+ YWNjZXNzZWQsIGxpc3QpIHsKIAkJCQlpZiAoIWktPnRhX25vZGUpCiAJCQkJ CWNvbnRpbnVlOwotCQkJCXRub2RlID0gdHJhbnNhY3Rpb25fZ2V0X25vZGVf bmFtZSh0bmFtZSwgdHJhbnMsCi0JCQkJCQkJCSAgaS0+bm9kZSk7Ci0JCQkJ aWYgKCF0bm9kZSB8fCAhcmVtZW1iZXJfc3RyaW5nKGhhc2gsIHRub2RlKSkK KwkJCQlpZiAoIXJlbWVtYmVyX3N0cmluZyhoYXNoLCBpLT50cmFuc19uYW1l KSkKIAkJCQkJZ290byBub21lbTsKLQkJCQl0YWxsb2NfZnJlZSh0bm9kZSk7 CiAJCQl9CiAKIAkJCXRhbGxvY19mcmVlKHRuYW1lKTsKZGlmZiAtLWdpdCBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKaW5kZXggMzlk N2Y4MWM1MTI3Li4zNDE3MzAzZjk0MjcgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCisrKyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5oCkBAIC00OCw4ICs0OCw4 IEBAIGludCBfX211c3RfY2hlY2sgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5l Y3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAogdm9pZCBxdWV1ZV93 YXRjaGVzKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpu YW1lLCBib29sIHdhdGNoX2V4YWN0KTsKIAogLyogUHJlcGVuZCB0aGUgdHJh bnNhY3Rpb24gdG8gbmFtZSBpZiBhcHByb3ByaWF0ZS4gKi8KLWludCB0cmFu c2FjdGlvbl9wcmVwZW5kKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25z dCBjaGFyICpuYW1lLAotICAgICAgICAgICAgICAgICAgICAgICAgVERCX0RB VEEgKmtleSk7Cit2b2lkIHRyYW5zYWN0aW9uX3ByZXBlbmQoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIGNvbnN0IGNoYXIgKm5hbWUsCisgICAgICAgICAg ICAgICAgICAgICAgICAgVERCX0RBVEEgKmtleSk7CiAKIC8qIE1hcmsgdGhl IHRyYW5zYWN0aW9uIGFzIGZhaWxlZC4gVGhpcyB3aWxsIHByZXZlbnQgaXQg dG8gYmUgY29tbWl0dGVkLiAqLwogdm9pZCBmYWlsX3RyYW5zYWN0aW9uKHN0 cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnMpOwo= --=separator Content-Type: application/octet-stream; name="xsa421/xsa421-4.15-01.patch" Content-Disposition: attachment; filename="xsa421/xsa421-4.15-01.patch" Content-Transfer-Encoding: base64 RnJvbSAyNDZkOGRiNTQwZjA4NDcwYzJmODc4OWE4NDQwMTczMDI4Yzg1YjM4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTMgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGZpeCBkZWxl dGluZyBub2RlIGluIHRyYW5zYWN0aW9uCgpJbiBjYXNlIGEgbm9kZSBoYXMg YmVlbiBjcmVhdGVkIGluIGEgdHJhbnNhY3Rpb24gYW5kIGl0IGlzIGxhdGVy CmRlbGV0ZWQgaW4gdGhlIHNhbWUgdHJhbnNhY3Rpb24sIHRoZSB0cmFuc2Fj dGlvbiB3aWxsIGJlIHRlcm1pbmF0ZWQKd2l0aCBhbiBlcnJvci4KCkFzIHRo aXMgZXJyb3IgaXMgZW5jb3VudGVyZWQgb25seSB3aGVuIGhhbmRsaW5nIHRo ZSBkZWxldGVkIG5vZGUgYXQKdHJhbnNhY3Rpb24gZmluYWxpemF0aW9uLCB0 aGUgdHJhbnNhY3Rpb24gd2lsbCBoYXZlIGJlZW4gcGVyZm9ybWVkCnBhcnRp YWxseSBhbmQgd2l0aG91dCB1cGRhdGluZyB0aGUgYWNjb3VudGluZyBpbmZv cm1hdGlvbi4gVGhpcyB3aWxsCmVuYWJsZSBhIG1hbGljaW91cyBndWVzdCB0 byBjcmVhdGUgYXJiaXRyYXJ5IG51bWJlciBvZiBub2Rlcy4KClRoaXMgaXMg cGFydCBvZiBYU0EtNDIxIC8gQ1ZFLTIwMjItNDIzMjUuCgpSZXBvcnRlZC1i eTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9m Zi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpUZXN0ZWQt Ynk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClJldmlld2Vk LWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAt LWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5j IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKaW5k ZXggM2UzZWI0NzMyNmNjLi43ZmZlMjFiYjUyODUgMTAwNjQ0Ci0tLSBhL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCisrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90cmFuc2FjdGlvbi5jCkBAIC00MTgs NyArNDE4LDEzIEBAIHN0YXRpYyBpbnQgZmluYWxpemVfdHJhbnNhY3Rpb24o c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCiAJCQkJCQkgICB0cnVlKTsKIAkJ CQl0YWxsb2NfZnJlZShkYXRhLmRwdHIpOwogCQkJfSBlbHNlIHsKLQkJCQly ZXQgPSBkb190ZGJfZGVsZXRlKGNvbm4sICZrZXksIE5VTEwpOworCQkJCS8q CisJCQkJICogQSBub2RlIGhhdmluZyBiZWVuIGNyZWF0ZWQgYW5kIGxhdGVy IGRlbGV0ZWQKKwkJCQkgKiBpbiB0aGlzIHRyYW5zYWN0aW9uIHdpbGwgaGF2 ZSBubyBnZW5lcmF0aW9uCisJCQkJICogaW5mb3JtYXRpb24gc3RvcmVkLgor CQkJCSAqLworCQkJCXJldCA9IChpLT5nZW5lcmF0aW9uID09IE5PX0dFTkVS QVRJT04pCisJCQkJICAgICAgPyAwIDogZG9fdGRiX2RlbGV0ZShjb25uLCAm a2V5LCBOVUxMKTsKIAkJCX0KIAkJCWlmIChyZXQpCiAJCQkJZ290byBlcnI7 Cg== --=separator Content-Type: application/octet-stream; name="xsa421/xsa421-4.15-02.patch" Content-Disposition: attachment; filename="xsa421/xsa421-4.15-02.patch" Content-Transfer-Encoding: base64 RnJvbSBiYjQ1MTY3MTMyYjk5ODhlZjcyODJlZWY5NmJlYWE1Yzk4NDVmOWFk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMDc6 MzU6MTQgKzAyMDAKU3ViamVjdDogdG9vbHMveGVuc3RvcmU6IGhhcmRlbiB0 cmFuc2FjdGlvbiBmaW5hbGl6YXRpb24gYWdhaW5zdCBlcnJvcnMKCldoZW4g ZmluYWxpemluZyBhIHRyYW5zYWN0aW9uLCBhbnkgZXJyb3Igb2NjdXJyaW5n IGFmdGVyIGNoZWNraW5nIGZvcgpjb25mbGljdHMgd2lsbCByZXN1bHQgaW4g dGhlIHRyYW5zYWN0aW9uIGJlaW5nIHBlcmZvcm1lZCBvbmx5CnBhcnRpYWxs eSB0b2RheS4gQWRkaXRpb25hbGx5IGFjY291bnRpbmcgZGF0YSB3aWxsIG5v dCBiZSB1cGRhdGVkIGF0CnRoZSBlbmQgb2YgdGhlIHRyYW5zYWN0aW9uLCB3 aGljaCBtaWdodCByZXN1bHQgaW4gZnVydGhlciBwcm9ibGVtcwpsYXRlci4K CkF2b2lkIHRob3NlIHByb2JsZW1zIGJ5IG11bHRpcGxlIG1vZGlmaWNhdGlv bnM6CgotIGZyZWUgYW55IHRyYW5zYWN0aW9uIHNwZWNpZmljIG5vZGVzIHdo aWNoIGRvbid0IG5lZWQgdG8gYmUgY29tbWl0dGVkCiAgYXMgdGhleSBoYXZl bid0IGJlZW4gd3JpdHRlbiBkdXJpbmcgdGhlIHRyYW5zYWN0aW9uIGFzIHNv b24gYXMgdGhlaXIKICBnZW5lcmF0aW9uIGNvdW50IGhhcyBiZWVuIHZlcmlm aWVkLCB0aGlzIHdpbGwgcmVkdWNlIHRoZSByaXNrIG9mCiAgb3V0LW9mLW1l bW9yeSBzaXR1YXRpb25zCgotIHN0b3JlIHRoZSB0cmFuc2FjdGlvbiBzcGVj aWZpYyBub2RlIG5hbWUgaW4gc3RydWN0IGFjY2Vzc2VkX25vZGUgaW4KICBv cmRlciB0byBhdm9pZCB0aGUgbmVlZCB0byBhbGxvY2F0ZSBhZGRpdGlvbmFs IG1lbW9yeSBmb3IgaXQgd2hlbgogIGZpbmFsaXppbmcgdGhlIHRyYW5zYWN0 aW9uCgotIGRvbid0IHN0b3AgdGhlIHRyYW5zYWN0aW9uIGZpbmFsaXphdGlv biB3aGVuIGhpdHRpbmcgYW4gZXJyb3IKICBjb25kaXRpb24sIGJ1dCB0cnkg dG8gY29udGludWUgdG8gaGFuZGxlIGFsbCBtb2RpZmllZCBub2RlcwoKLSBp biBjYXNlIG9mIGEgZGV0ZWN0ZWQgZXJyb3IgZG8gdGhlIGFjY291bnRpbmcg dXBkYXRlIGFzIG5lZWRlZCBhbmQKICBjYWxsIHRoZSBkYXRhIGJhc2UgY2hl Y2tpbmcgb25seSBhZnRlciB0aGF0CgotIGlmIHdyaXRpbmcgYSBub2RlIGlu IGEgdHJhbnNhY3Rpb24gaXMgZmFpbGluZyAoZS5nLiBkdWUgdG8gYSBmYWls ZWQKICBxdW90YSBjaGVjayksIGZhaWwgdGhlIHRyYW5zYWN0aW9uLCBhcyBw cmlvciBjaGFuZ2VzIHRvIHN0cnVjdAogIGFjY2Vzc2VkX25vZGUgY2FuJ3Qg ZWFzaWx5IGJlIHVuZG9uZSBpbiB0aGF0IGNhc2UKClRoaXMgaXMgcGFydCBv ZiBYU0EtNDIxIC8gQ1ZFLTIwMjItNDIzMjYuCgpSZXBvcnRlZC1ieTogSnVs aWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9mZi1ieTog SnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog SnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KVGVzdGVkLWJ5OiBK dWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgoKZGlmZiAtLWdpdCBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jCmluZGV4IDlkZGJkOTM0Zjc5NC4uM2Mw MDhjOGNkNDU1IDEwMDY0NAotLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfY29yZS5jCisrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMKQEAgLTY5Miw4ICs2OTIsNyBAQCBzdHJ1Y3Qgbm9kZSAqcmVhZF9ub2Rl KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsCiAJ CXJldHVybiBOVUxMOwogCX0KIAotCWlmICh0cmFuc2FjdGlvbl9wcmVwZW5k KGNvbm4sIG5hbWUsICZrZXkpKQotCQlyZXR1cm4gTlVMTDsKKwl0cmFuc2Fj dGlvbl9wcmVwZW5kKGNvbm4sIG5hbWUsICZrZXkpOwogCiAJZGF0YSA9IHRk Yl9mZXRjaCh0ZGJfY3R4LCBrZXkpOwogCkBAIC04MTEsMTAgKzgxMCwyMSBA QCBpbnQgd3JpdGVfbm9kZV9yYXcoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IFREQl9EQVRBICprZXksIHN0cnVjdCBub2RlICpub2RlLAogc3RhdGljIGlu dCB3cml0ZV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qg bm9kZSAqbm9kZSwKIAkJICAgICAgYm9vbCBub19xdW90YV9jaGVjaykKIHsK KwlpbnQgcmV0OworCiAJaWYgKGFjY2Vzc19ub2RlKGNvbm4sIG5vZGUsIE5P REVfQUNDRVNTX1dSSVRFLCAmbm9kZS0+a2V5KSkKIAkJcmV0dXJuIGVycm5v OwogCi0JcmV0dXJuIHdyaXRlX25vZGVfcmF3KGNvbm4sICZub2RlLT5rZXks IG5vZGUsIG5vX3F1b3RhX2NoZWNrKTsKKwlyZXQgPSB3cml0ZV9ub2RlX3Jh dyhjb25uLCAmbm9kZS0+a2V5LCBub2RlLCBub19xdW90YV9jaGVjayk7CisJ aWYgKHJldCAmJiBjb25uICYmIGNvbm4tPnRyYW5zYWN0aW9uKSB7CisJCS8q CisJCSAqIFJldmVydGluZyBhY2Nlc3Nfbm9kZSgpIGlzIGhhcmQsIHNvIGp1 c3QgZmFpbCB0aGUKKwkJICogdHJhbnNhY3Rpb24uCisJCSAqLworCQlmYWls X3RyYW5zYWN0aW9uKGNvbm4tPnRyYW5zYWN0aW9uKTsKKwl9CisKKwlyZXR1 cm4gcmV0OwogfQogCiBlbnVtIHhzX3Blcm1fdHlwZSBwZXJtX2Zvcl9jb25u KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLApkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uYwppbmRleCA3ZmZlMjFiYjUy ODUuLmFjODU0MTk3Y2FkYiAxMDA2NDQKLS0tIGEvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKKysrIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMKQEAgLTExNCw3ICsxMTQsOCBAQCBz dHJ1Y3QgYWNjZXNzZWRfbm9kZQogCXN0cnVjdCBsaXN0X2hlYWQgbGlzdDsK IAogCS8qIFRoZSBuYW1lIG9mIHRoZSBub2RlLiAqLwotCWNoYXIgKm5vZGU7 CisJY2hhciAqdHJhbnNfbmFtZTsJLyogVHJhbnNhY3Rpb24gc3BlY2lmaWMg bmFtZS4gKi8KKwljaGFyICpub2RlOwkJLyogTWFpbiBkYXRhIGJhc2UgbmFt ZS4gKi8KIAogCS8qIEdlbmVyYXRpb24gY291bnQgKG9yIE5PX0dFTkVSQVRJ T04pIGZvciBjb25mbGljdCBjaGVja2luZy4gKi8KIAl1aW50NjRfdCBnZW5l cmF0aW9uOwpAQCAtMTk5LDI1ICsyMDAsMjAgQEAgc3RhdGljIGNoYXIgKnRy YW5zYWN0aW9uX2dldF9ub2RlX25hbWUodm9pZCAqY3R4LCBzdHJ1Y3QgdHJh bnNhY3Rpb24gKnRyYW5zLAogICogUHJlcGVuZCB0aGUgdHJhbnNhY3Rpb24g dG8gbmFtZSBpZiBub2RlIGhhcyBiZWVuIG1vZGlmaWVkIGluIHRoZSBjdXJy ZW50CiAgKiB0cmFuc2FjdGlvbi4KICAqLwotaW50IHRyYW5zYWN0aW9uX3By ZXBlbmQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IGNoYXIgKm5h bWUsCi0JCQlUREJfREFUQSAqa2V5KQordm9pZCB0cmFuc2FjdGlvbl9wcmVw ZW5kKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyICpuYW1l LAorCQkJIFREQl9EQVRBICprZXkpCiB7Ci0JY2hhciAqdGRiX25hbWU7CisJ c3RydWN0IGFjY2Vzc2VkX25vZGUgKmk7CiAKLQlpZiAoIWNvbm4gfHwgIWNv bm4tPnRyYW5zYWN0aW9uIHx8Ci0JICAgICFmaW5kX2FjY2Vzc2VkX25vZGUo Y29ubi0+dHJhbnNhY3Rpb24sIG5hbWUpKSB7Ci0JCXNldF90ZGJfa2V5KG5h bWUsIGtleSk7Ci0JCXJldHVybiAwOworCWlmIChjb25uICYmIGNvbm4tPnRy YW5zYWN0aW9uKSB7CisJCWkgPSBmaW5kX2FjY2Vzc2VkX25vZGUoY29ubi0+ dHJhbnNhY3Rpb24sIG5hbWUpOworCQlpZiAoaSkgeworCQkJc2V0X3RkYl9r ZXkoaS0+dHJhbnNfbmFtZSwga2V5KTsKKwkJCXJldHVybjsKKwkJfQogCX0K IAotCXRkYl9uYW1lID0gdHJhbnNhY3Rpb25fZ2V0X25vZGVfbmFtZShjb25u LT50cmFuc2FjdGlvbiwKLQkJCQkJICAgICBjb25uLT50cmFuc2FjdGlvbiwg bmFtZSk7Ci0JaWYgKCF0ZGJfbmFtZSkKLQkJcmV0dXJuIGVycm5vOwotCi0J c2V0X3RkYl9rZXkodGRiX25hbWUsIGtleSk7Ci0KLQlyZXR1cm4gMDsKKwlz ZXRfdGRiX2tleShuYW1lLCBrZXkpOwogfQogCiAvKgpAQCAtMjQwLDcgKzIz Niw2IEBAIGludCBhY2Nlc3Nfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29u biwgc3RydWN0IG5vZGUgKm5vZGUsCiAJc3RydWN0IGFjY2Vzc2VkX25vZGUg KmkgPSBOVUxMOwogCXN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnM7CiAJVERC X0RBVEEgbG9jYWxfa2V5OwotCWNvbnN0IGNoYXIgKnRyYW5zX25hbWUgPSBO VUxMOwogCWludCByZXQ7CiAJYm9vbCBpbnRyb2R1Y2UgPSBmYWxzZTsKIApA QCAtMjU5LDEwICsyNTQsNiBAQCBpbnQgYWNjZXNzX25vZGUoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAogCiAJdHJhbnMg PSBjb25uLT50cmFuc2FjdGlvbjsKIAotCXRyYW5zX25hbWUgPSB0cmFuc2Fj dGlvbl9nZXRfbm9kZV9uYW1lKG5vZGUsIHRyYW5zLCBub2RlLT5uYW1lKTsK LQlpZiAoIXRyYW5zX25hbWUpCi0JCWdvdG8gbm9tZW07Ci0KIAlpID0gZmlu ZF9hY2Nlc3NlZF9ub2RlKHRyYW5zLCBub2RlLT5uYW1lKTsKIAlpZiAoIWkp IHsKIAkJaWYgKHRyYW5zLT5ub2RlcyA+PSBxdW90YV90cmFuc19ub2RlcyAm JgpAQCAtMjczLDkgKzI2NCwxMCBAQCBpbnQgYWNjZXNzX25vZGUoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlLAogCQlpID0g dGFsbG9jX3plcm8odHJhbnMsIHN0cnVjdCBhY2Nlc3NlZF9ub2RlKTsKIAkJ aWYgKCFpKQogCQkJZ290byBub21lbTsKLQkJaS0+bm9kZSA9IHRhbGxvY19z dHJkdXAoaSwgbm9kZS0+bmFtZSk7Ci0JCWlmICghaS0+bm9kZSkKKwkJaS0+ dHJhbnNfbmFtZSA9IHRyYW5zYWN0aW9uX2dldF9ub2RlX25hbWUoaSwgdHJh bnMsIG5vZGUtPm5hbWUpOworCQlpZiAoIWktPnRyYW5zX25hbWUpCiAJCQln b3RvIG5vbWVtOworCQlpLT5ub2RlID0gc3RyY2hyKGktPnRyYW5zX25hbWUs ICcvJykgKyAxOwogCQlpZiAobm9kZS0+Z2VuZXJhdGlvbiAhPSBOT19HRU5F UkFUSU9OICYmIG5vZGUtPnBlcm1zLm51bSkgewogCQkJaS0+cGVybXMucCA9 IHRhbGxvY19hcnJheShpLCBzdHJ1Y3QgeHNfcGVybWlzc2lvbnMsCiAJCQkJ CQkgIG5vZGUtPnBlcm1zLm51bSk7CkBAIC0zMDIsNyArMjk0LDcgQEAgaW50 IGFjY2Vzc19ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qg bm9kZSAqbm9kZSwKIAkJCWktPmdlbmVyYXRpb24gPSBub2RlLT5nZW5lcmF0 aW9uOwogCQkJaS0+Y2hlY2tfZ2VuID0gdHJ1ZTsKIAkJCWlmIChub2RlLT5n ZW5lcmF0aW9uICE9IE5PX0dFTkVSQVRJT04pIHsKLQkJCQlzZXRfdGRiX2tl eSh0cmFuc19uYW1lLCAmbG9jYWxfa2V5KTsKKwkJCQlzZXRfdGRiX2tleShp LT50cmFuc19uYW1lLCAmbG9jYWxfa2V5KTsKIAkJCQlyZXQgPSB3cml0ZV9u b2RlX3Jhdyhjb25uLCAmbG9jYWxfa2V5LCBub2RlLCB0cnVlKTsKIAkJCQlp ZiAocmV0KQogCQkJCQlnb3RvIGVycjsKQEAgLTMyMSw3ICszMTMsNyBAQCBp bnQgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBub2RlICpub2RlLAogCQlyZXR1cm4gLTE7CiAKIAlpZiAoa2V5KSB7Ci0J CXNldF90ZGJfa2V5KHRyYW5zX25hbWUsIGtleSk7CisJCXNldF90ZGJfa2V5 KGktPnRyYW5zX25hbWUsIGtleSk7CiAJCWlmICh0eXBlID09IE5PREVfQUND RVNTX1dSSVRFKQogCQkJaS0+dGFfbm9kZSA9IHRydWU7CiAJCWlmICh0eXBl ID09IE5PREVfQUNDRVNTX0RFTEVURSkKQEAgLTMzMyw3ICszMjUsNiBAQCBp bnQgYWNjZXNzX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVj dCBub2RlICpub2RlLAogbm9tZW06CiAJcmV0ID0gRU5PTUVNOwogZXJyOgot CXRhbGxvY19mcmVlKCh2b2lkICopdHJhbnNfbmFtZSk7CiAJdGFsbG9jX2Zy ZWUoaSk7CiAJdHJhbnMtPmZhaWwgPSB0cnVlOwogCWVycm5vID0gcmV0OwpA QCAtMzcxLDEwMCArMzYyLDkwIEBAIHZvaWQgcXVldWVfd2F0Y2hlcyhzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3QgY2hhciAqbmFtZSwgYm9vbCB3 YXRjaF9leGFjdCkKICAqIGJhc2UuCiAgKi8KIHN0YXRpYyBpbnQgZmluYWxp emVfdHJhbnNhY3Rpb24oc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sCi0JCQkJ c3RydWN0IHRyYW5zYWN0aW9uICp0cmFucykKKwkJCQlzdHJ1Y3QgdHJhbnNh Y3Rpb24gKnRyYW5zLCBib29sICppc19jb3JydXB0KQogewotCXN0cnVjdCBh Y2Nlc3NlZF9ub2RlICppOworCXN0cnVjdCBhY2Nlc3NlZF9ub2RlICppLCAq bjsKIAlUREJfREFUQSBrZXksIHRhX2tleSwgZGF0YTsKIAlzdHJ1Y3QgeHNf dGRiX3JlY29yZF9oZHIgKmhkcjsKIAl1aW50NjRfdCBnZW47Ci0JY2hhciAq dHJhbnNfbmFtZTsKLQlpbnQgcmV0OwogCi0JbGlzdF9mb3JfZWFjaF9lbnRy eShpLCAmdHJhbnMtPmFjY2Vzc2VkLCBsaXN0KSB7Ci0JCWlmICghaS0+Y2hl Y2tfZ2VuKQotCQkJY29udGludWU7CisJbGlzdF9mb3JfZWFjaF9lbnRyeV9z YWZlKGksIG4sICZ0cmFucy0+YWNjZXNzZWQsIGxpc3QpIHsKKwkJaWYgKGkt PmNoZWNrX2dlbikgeworCQkJc2V0X3RkYl9rZXkoaS0+bm9kZSwgJmtleSk7 CisJCQlkYXRhID0gdGRiX2ZldGNoKHRkYl9jdHgsIGtleSk7CisJCQloZHIg PSAodm9pZCAqKWRhdGEuZHB0cjsKKwkJCWlmICghZGF0YS5kcHRyKSB7CisJ CQkJaWYgKHRkYl9lcnJvcih0ZGJfY3R4KSAhPSBUREJfRVJSX05PRVhJU1Qp CisJCQkJCXJldHVybiBFSU87CisJCQkJZ2VuID0gTk9fR0VORVJBVElPTjsK KwkJCX0gZWxzZQorCQkJCWdlbiA9IGhkci0+Z2VuZXJhdGlvbjsKKwkJCXRh bGxvY19mcmVlKGRhdGEuZHB0cik7CisJCQlpZiAoaS0+Z2VuZXJhdGlvbiAh PSBnZW4pCisJCQkJcmV0dXJuIEVBR0FJTjsKKwkJfQogCi0JCXNldF90ZGJf a2V5KGktPm5vZGUsICZrZXkpOwotCQlkYXRhID0gdGRiX2ZldGNoKHRkYl9j dHgsIGtleSk7Ci0JCWhkciA9ICh2b2lkICopZGF0YS5kcHRyOwotCQlpZiAo IWRhdGEuZHB0cikgewotCQkJaWYgKHRkYl9lcnJvcih0ZGJfY3R4KSAhPSBU REJfRVJSX05PRVhJU1QpCi0JCQkJcmV0dXJuIEVJTzsKLQkJCWdlbiA9IE5P X0dFTkVSQVRJT047Ci0JCX0gZWxzZQotCQkJZ2VuID0gaGRyLT5nZW5lcmF0 aW9uOwotCQl0YWxsb2NfZnJlZShkYXRhLmRwdHIpOwotCQlpZiAoaS0+Z2Vu ZXJhdGlvbiAhPSBnZW4pCi0JCQlyZXR1cm4gRUFHQUlOOworCQkvKiBFbnRy aWVzIGZvciB1bm1vZGlmaWVkIG5vZGVzIGNhbiBiZSByZW1vdmVkIGVhcmx5 LiAqLworCQlpZiAoIWktPm1vZGlmaWVkKSB7CisJCQlpZiAoaS0+dGFfbm9k ZSkgeworCQkJCXNldF90ZGJfa2V5KGktPnRyYW5zX25hbWUsICZ0YV9rZXkp OworCQkJCWlmIChkb190ZGJfZGVsZXRlKGNvbm4sICZ0YV9rZXksIE5VTEwp KQorCQkJCQlyZXR1cm4gRUlPOworCQkJfQorCQkJbGlzdF9kZWwoJmktPmxp c3QpOworCQkJdGFsbG9jX2ZyZWUoaSk7CisJCX0KIAl9CiAKIAl3aGlsZSAo KGkgPSBsaXN0X3RvcCgmdHJhbnMtPmFjY2Vzc2VkLCBzdHJ1Y3QgYWNjZXNz ZWRfbm9kZSwgbGlzdCkpKSB7Ci0JCXRyYW5zX25hbWUgPSB0cmFuc2FjdGlv bl9nZXRfbm9kZV9uYW1lKGksIHRyYW5zLCBpLT5ub2RlKTsKLQkJaWYgKCF0 cmFuc19uYW1lKQotCQkJLyogV2UgYXJlIGRvb21lZDogdGhlIHRyYW5zYWN0 aW9uIGlzIG9ubHkgcGFydGlhbC4gKi8KLQkJCWdvdG8gZXJyOwotCi0JCXNl dF90ZGJfa2V5KHRyYW5zX25hbWUsICZ0YV9rZXkpOwotCi0JCWlmIChpLT5t b2RpZmllZCkgewotCQkJc2V0X3RkYl9rZXkoaS0+bm9kZSwgJmtleSk7Ci0J CQlpZiAoaS0+dGFfbm9kZSkgewotCQkJCWRhdGEgPSB0ZGJfZmV0Y2godGRi X2N0eCwgdGFfa2V5KTsKLQkJCQlpZiAoIWRhdGEuZHB0cikKLQkJCQkJZ290 byBlcnI7CisJCXNldF90ZGJfa2V5KGktPm5vZGUsICZrZXkpOworCQlpZiAo aS0+dGFfbm9kZSkgeworCQkJc2V0X3RkYl9rZXkoaS0+dHJhbnNfbmFtZSwg JnRhX2tleSk7CisJCQlkYXRhID0gdGRiX2ZldGNoKHRkYl9jdHgsIHRhX2tl eSk7CisJCQlpZiAoZGF0YS5kcHRyKSB7CiAJCQkJaGRyID0gKHZvaWQgKilk YXRhLmRwdHI7CiAJCQkJaGRyLT5nZW5lcmF0aW9uID0gKytnZW5lcmF0aW9u OwotCQkJCXJldCA9IGRvX3RkYl93cml0ZShjb25uLCAma2V5LCAmZGF0YSwg TlVMTCwKLQkJCQkJCSAgIHRydWUpOworCQkJCSppc19jb3JydXB0IHw9IGRv X3RkYl93cml0ZShjb25uLCAma2V5LCAmZGF0YSwKKwkJCQkJCQkgICAgTlVM TCwgdHJ1ZSk7CiAJCQkJdGFsbG9jX2ZyZWUoZGF0YS5kcHRyKTsKKwkJCQlp ZiAoZG9fdGRiX2RlbGV0ZShjb25uLCAmdGFfa2V5LCBOVUxMKSkKKwkJCQkJ KmlzX2NvcnJ1cHQgPSB0cnVlOwogCQkJfSBlbHNlIHsKLQkJCQkvKgotCQkJ CSAqIEEgbm9kZSBoYXZpbmcgYmVlbiBjcmVhdGVkIGFuZCBsYXRlciBkZWxl dGVkCi0JCQkJICogaW4gdGhpcyB0cmFuc2FjdGlvbiB3aWxsIGhhdmUgbm8g Z2VuZXJhdGlvbgotCQkJCSAqIGluZm9ybWF0aW9uIHN0b3JlZC4KLQkJCQkg Ki8KLQkJCQlyZXQgPSAoaS0+Z2VuZXJhdGlvbiA9PSBOT19HRU5FUkFUSU9O KQotCQkJCSAgICAgID8gMCA6IGRvX3RkYl9kZWxldGUoY29ubiwgJmtleSwg TlVMTCk7Ci0JCQl9Ci0JCQlpZiAocmV0KQotCQkJCWdvdG8gZXJyOwotCQkJ aWYgKGktPmZpcmVfd2F0Y2gpIHsKLQkJCQlmaXJlX3dhdGNoZXMoY29ubiwg dHJhbnMsIGktPm5vZGUsIE5VTEwsCi0JCQkJCSAgICAgaS0+d2F0Y2hfZXhh Y3QsCi0JCQkJCSAgICAgaS0+cGVybXMucCA/ICZpLT5wZXJtcyA6IE5VTEwp OworCQkJCSppc19jb3JydXB0ID0gdHJ1ZTsKIAkJCX0KKwkJfSBlbHNlIHsK KwkJCS8qCisJCQkgKiBBIG5vZGUgaGF2aW5nIGJlZW4gY3JlYXRlZCBhbmQg bGF0ZXIgZGVsZXRlZAorCQkJICogaW4gdGhpcyB0cmFuc2FjdGlvbiB3aWxs IGhhdmUgbm8gZ2VuZXJhdGlvbgorCQkJICogaW5mb3JtYXRpb24gc3RvcmVk LgorCQkJICovCisJCQkqaXNfY29ycnVwdCB8PSAoaS0+Z2VuZXJhdGlvbiA9 PSBOT19HRU5FUkFUSU9OKQorCQkJCSAgICAgICA/IGZhbHNlCisJCQkJICAg ICAgIDogZG9fdGRiX2RlbGV0ZShjb25uLCAma2V5LCBOVUxMKTsKIAkJfQor CQlpZiAoaS0+ZmlyZV93YXRjaCkKKwkJCWZpcmVfd2F0Y2hlcyhjb25uLCB0 cmFucywgaS0+bm9kZSwgTlVMTCwgaS0+d2F0Y2hfZXhhY3QsCisJCQkJICAg ICBpLT5wZXJtcy5wID8gJmktPnBlcm1zIDogTlVMTCk7CiAKLQkJaWYgKGkt PnRhX25vZGUgJiYgZG9fdGRiX2RlbGV0ZShjb25uLCAmdGFfa2V5LCBOVUxM KSkKLQkJCWdvdG8gZXJyOwogCQlsaXN0X2RlbCgmaS0+bGlzdCk7CiAJCXRh bGxvY19mcmVlKGkpOwogCX0KIAogCXJldHVybiAwOwotCi1lcnI6Ci0JY29y cnVwdChjb25uLCAiUGFydGlhbCB0cmFuc2FjdGlvbiIpOwotCXJldHVybiBF SU87CiB9CiAKIHN0YXRpYyBpbnQgZGVzdHJveV90cmFuc2FjdGlvbih2b2lk ICpfdHJhbnNhY3Rpb24pCiB7CiAJc3RydWN0IHRyYW5zYWN0aW9uICp0cmFu cyA9IF90cmFuc2FjdGlvbjsKIAlzdHJ1Y3QgYWNjZXNzZWRfbm9kZSAqaTsK LQljaGFyICp0cmFuc19uYW1lOwogCVREQl9EQVRBIGtleTsKIAogCXdybF9u dHJhbnNhY3Rpb25zLS07CiAJdHJhY2VfZGVzdHJveSh0cmFucywgInRyYW5z YWN0aW9uIik7CiAJd2hpbGUgKChpID0gbGlzdF90b3AoJnRyYW5zLT5hY2Nl c3NlZCwgc3RydWN0IGFjY2Vzc2VkX25vZGUsIGxpc3QpKSkgewogCQlpZiAo aS0+dGFfbm9kZSkgewotCQkJdHJhbnNfbmFtZSA9IHRyYW5zYWN0aW9uX2dl dF9ub2RlX25hbWUoaSwgdHJhbnMsCi0JCQkJCQkJICAgICAgIGktPm5vZGUp OwotCQkJaWYgKHRyYW5zX25hbWUpIHsKLQkJCQlzZXRfdGRiX2tleSh0cmFu c19uYW1lLCAma2V5KTsKLQkJCQlkb190ZGJfZGVsZXRlKHRyYW5zLT5jb25u LCAma2V5LCBOVUxMKTsKLQkJCX0KKwkJCXNldF90ZGJfa2V5KGktPnRyYW5z X25hbWUsICZrZXkpOworCQkJZG9fdGRiX2RlbGV0ZSh0cmFucy0+Y29ubiwg JmtleSwgTlVMTCk7CiAJCX0KIAkJbGlzdF9kZWwoJmktPmxpc3QpOwogCQl0 YWxsb2NfZnJlZShpKTsKQEAgLTU1Niw2ICs1MzcsNyBAQCBpbnQgZG9fdHJh bnNhY3Rpb25fZW5kKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sCiB7CiAJY29uc3QgY2hhciAqYXJnID0gb25lYXJnKGluKTsK IAlzdHJ1Y3QgdHJhbnNhY3Rpb24gKnRyYW5zOworCWJvb2wgaXNfY29ycnVw dCA9IGZhbHNlOwogCWludCByZXQ7CiAKIAlpZiAoIWFyZyB8fCAoIXN0cmVx KGFyZywgIlQiKSAmJiAhc3RyZXEoYXJnLCAiRiIpKSkKQEAgLTU3OSwxMyAr NTYxLDE3IEBAIGludCBkb190cmFuc2FjdGlvbl9lbmQoY29uc3Qgdm9pZCAq Y3R4LCBzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwKIAkJcmV0ID0gdHJhbnNh Y3Rpb25fZml4X2RvbWFpbnModHJhbnMsIGZhbHNlKTsKIAkJaWYgKHJldCkK IAkJCXJldHVybiByZXQ7Ci0JCWlmIChmaW5hbGl6ZV90cmFuc2FjdGlvbihj b25uLCB0cmFucykpCi0JCQlyZXR1cm4gRUFHQUlOOworCQlyZXQgPSBmaW5h bGl6ZV90cmFuc2FjdGlvbihjb25uLCB0cmFucywgJmlzX2NvcnJ1cHQpOwor CQlpZiAocmV0KQorCQkJcmV0dXJuIHJldDsKIAogCQl3cmxfYXBwbHlfZGVi aXRfdHJhbnNfY29tbWl0KGNvbm4pOwogCiAJCS8qIGZpeCBkb21haW4gZW50 cnkgZm9yIGVhY2ggY2hhbmdlZCBkb21haW4gKi8KIAkJdHJhbnNhY3Rpb25f Zml4X2RvbWFpbnModHJhbnMsIHRydWUpOworCisJCWlmIChpc19jb3JydXB0 KQorCQkJY29ycnVwdChjb25uLCAidHJhbnNhY3Rpb24gaW5jb25zaXN0ZW5j eSIpOwogCX0KIAlzZW5kX2Fjayhjb25uLCBYU19UUkFOU0FDVElPTl9FTkQp OwogCkBAIC02NjAsNyArNjQ2LDcgQEAgaW50IGNoZWNrX3RyYW5zYWN0aW9u cyhzdHJ1Y3QgaGFzaHRhYmxlICpoYXNoKQogCXN0cnVjdCBjb25uZWN0aW9u ICpjb25uOwogCXN0cnVjdCB0cmFuc2FjdGlvbiAqdHJhbnM7CiAJc3RydWN0 IGFjY2Vzc2VkX25vZGUgKmk7Ci0JY2hhciAqdG5hbWUsICp0bm9kZTsKKwlj aGFyICp0bmFtZTsKIAogCWxpc3RfZm9yX2VhY2hfZW50cnkoY29ubiwgJmNv bm5lY3Rpb25zLCBsaXN0KSB7CiAJCWxpc3RfZm9yX2VhY2hfZW50cnkodHJh bnMsICZjb25uLT50cmFuc2FjdGlvbl9saXN0LCBsaXN0KSB7CkBAIC02NzIs MTEgKzY1OCw4IEBAIGludCBjaGVja190cmFuc2FjdGlvbnMoc3RydWN0IGhh c2h0YWJsZSAqaGFzaCkKIAkJCWxpc3RfZm9yX2VhY2hfZW50cnkoaSwgJnRy YW5zLT5hY2Nlc3NlZCwgbGlzdCkgewogCQkJCWlmICghaS0+dGFfbm9kZSkK IAkJCQkJY29udGludWU7Ci0JCQkJdG5vZGUgPSB0cmFuc2FjdGlvbl9nZXRf bm9kZV9uYW1lKHRuYW1lLCB0cmFucywKLQkJCQkJCQkJICBpLT5ub2RlKTsK LQkJCQlpZiAoIXRub2RlIHx8ICFyZW1lbWJlcl9zdHJpbmcoaGFzaCwgdG5v ZGUpKQorCQkJCWlmICghcmVtZW1iZXJfc3RyaW5nKGhhc2gsIGktPnRyYW5z X25hbWUpKQogCQkJCQlnb3RvIG5vbWVtOwotCQkJCXRhbGxvY19mcmVlKHRu b2RlKTsKIAkJCX0KIAogCQkJdGFsbG9jX2ZyZWUodG5hbWUpOwpkaWZmIC0t Z2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfdHJhbnNhY3Rpb24uaAppbmRl eCAzOWQ3ZjgxYzUxMjcuLjM0MTczMDNmOTQyNyAxMDA2NDQKLS0tIGEvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKKysrIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmgKQEAgLTQ4LDgg KzQ4LDggQEAgaW50IF9fbXVzdF9jaGVjayBhY2Nlc3Nfbm9kZShzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKm5vZGUsCiB2b2lkIHF1 ZXVlX3dhdGNoZXMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IGNo YXIgKm5hbWUsIGJvb2wgd2F0Y2hfZXhhY3QpOwogCiAvKiBQcmVwZW5kIHRo ZSB0cmFuc2FjdGlvbiB0byBuYW1lIGlmIGFwcHJvcHJpYXRlLiAqLwotaW50 IHRyYW5zYWN0aW9uX3ByZXBlbmQoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4s IGNvbnN0IGNoYXIgKm5hbWUsCi0gICAgICAgICAgICAgICAgICAgICAgICBU REJfREFUQSAqa2V5KTsKK3ZvaWQgdHJhbnNhY3Rpb25fcHJlcGVuZChzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3QgY2hhciAqbmFtZSwKKyAgICAg ICAgICAgICAgICAgICAgICAgICBUREJfREFUQSAqa2V5KTsKIAogLyogTWFy ayB0aGUgdHJhbnNhY3Rpb24gYXMgZmFpbGVkLiBUaGlzIHdpbGwgcHJldmVu dCBpdCB0byBiZSBjb21taXR0ZWQuICovCiB2b2lkIGZhaWxfdHJhbnNhY3Rp b24oc3RydWN0IHRyYW5zYWN0aW9uICp0cmFucyk7Cg== --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Nov 01 12:30:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 12:30:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434367.686887 (Exim 4.92) (envelope-from ) id 1opqPg-0001zM-My; Tue, 01 Nov 2022 12:30:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434367.686887; Tue, 01 Nov 2022 12:30:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opqPg-0001zF-J2; Tue, 01 Nov 2022 12:30:40 +0000 Received: by outflank-mailman (input) for mailman id 434367; Tue, 01 Nov 2022 12:30:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opqPf-0001z3-Lb; Tue, 01 Nov 2022 12:30:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opqPf-0006Gp-Jt; Tue, 01 Nov 2022 12:30:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opqPf-0005Tt-2r; Tue, 01 Nov 2022 12:30:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1opqPf-0003dT-2R; Tue, 01 Nov 2022 12:30:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YLicT4P2c8UEiyoaF63laJMQkm18JAV9OZEEypNJfPk=; b=oajYzGfS2FB+MU0jZOSRmHaXwl M2YRAmYzXOHZ3OnCrWXqrwKeX/hBJ/Y1TcIz2qdBBrFsRbGcIP7HycD7GvB/QOQIwP/x+ZbQJr/sU T8gmCIU+M2BGI+LHrI0yxOUqvJ3La7EsKwXYvzGi8JAozM1sORjdsfuV6wjHm7qHCH+Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174565: all pass - PUSHED X-Osstest-Versions-This: ovmf=720c25ab41400f9a3dfd0742da5a6d237991df5b X-Osstest-Versions-That: ovmf=df7ce74e6c75e19a528d5b4921e5b3d0260e45fe From: osstest service owner Date: Tue, 01 Nov 2022 12:30:39 +0000 flight 174565 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174565/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 720c25ab41400f9a3dfd0742da5a6d237991df5b baseline version: ovmf df7ce74e6c75e19a528d5b4921e5b3d0260e45fe Last test of basis 174562 2022-11-01 01:43:29 Z 0 days Testing same since 174565 2022-11-01 10:13:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Jiaqi Gao Min M Xu Min Xu Zhichao Gao jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git df7ce74e6c..720c25ab41 720c25ab41400f9a3dfd0742da5a6d237991df5b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Nov 01 13:25:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 13:25:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434664.687067 (Exim 4.92) (envelope-from ) id 1oprGd-0003Bh-25; Tue, 01 Nov 2022 13:25:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434664.687067; Tue, 01 Nov 2022 13:25:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oprGc-0003Ba-TY; Tue, 01 Nov 2022 13:25:22 +0000 Received: by outflank-mailman (input) for mailman id 434664; Tue, 01 Nov 2022 13:25:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oprGb-0003BQ-PL; Tue, 01 Nov 2022 13:25:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oprGb-0007Ii-ME; Tue, 01 Nov 2022 13:25:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oprGb-0006fL-89; Tue, 01 Nov 2022 13:25:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oprGb-0006mX-7h; Tue, 01 Nov 2022 13:25:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6hFArmq48tkuFaQ8ZzkeUpGfK64MHMb2ITDPRY9qSyM=; b=vIUQ+zG+Txp57y9qyl1OO0BzoZ qmF1CCYocaOv+aCovaR/8yZj1z3b2887QV6rXhN4JC+def8qimp7vIyeYnhlOgZIaABfL1KFWxLuB S10oLx0gIgUF5i1fMUEAO+Y3XoLHomyNp2AXZmexvcY6m22Zkzuhagh8+gh2kw7LmtUg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174564: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=5aaef24b5c6d4246b2cac1be949869fa36577737 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 01 Nov 2022 13:25:21 +0000 flight 174564 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174564/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 5aaef24b5c6d4246b2cac1be949869fa36577737 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 24 days Failing since 173470 2022-10-08 06:21:34 Z 24 days 38 attempts Testing same since 174564 2022-11-01 04:17:49 Z 0 days 1 attempts ------------------------------------------------------------ 1531 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 143523 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Nov 01 14:23:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 14:23:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434698.687077 (Exim 4.92) (envelope-from ) id 1opsAo-0002Xv-Aa; Tue, 01 Nov 2022 14:23:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434698.687077; Tue, 01 Nov 2022 14:23:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opsAo-0002Xo-7l; Tue, 01 Nov 2022 14:23:26 +0000 Received: by outflank-mailman (input) for mailman id 434698; Tue, 01 Nov 2022 14:23:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opsAn-0002Xi-4c for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 14:23:25 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bdfc24a7-59f0-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 15:23:23 +0100 (CET) Received: by mail-ej1-x633.google.com with SMTP id kt23so37368593ejc.7 for ; Tue, 01 Nov 2022 07:23:23 -0700 (PDT) Received: from [192.168.1.93] (adsl-235.109.242.227.tellas.gr. [109.242.227.235]) by smtp.gmail.com with ESMTPSA id ju26-20020a17090798ba00b0078d424e8c09sm4271797ejc.77.2022.11.01.07.23.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 07:23:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bdfc24a7-59f0-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pNdMCET0AX6v76zQYGTGiQhfcBjxiSV/5Jz19I5He6s=; b=plLjzmtQcklzkxyQoWhQgZcI37UqM/N4ofaSwwKt6MSzz8CigrNb6lqiLPCs9TesKm i/Yc84vRKT82xKUWPSMGW63pBg1bsl+gaeIODDI3YPAejPq+s1QQ/uzj6GBCQIcN6sVs Dey44iz7WajkNBJP4anKxp7822GLwCgdL3Fda3wnCueZJnCFnlSst6spQq0+BU9kLThi SrTPDcS0CwemwA8rOps4quMq+6jVyv7+dXRGIbNIqOi2opGtQgOXFl5I3svbrDIgenZN uRAqeDAbdQKehFHUu0a2WBFGnapmPujwilRpuihfX79YkhNDfftnwq3tdG/meNQ8DaQr fpVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pNdMCET0AX6v76zQYGTGiQhfcBjxiSV/5Jz19I5He6s=; b=mVmHFcI01aah0ktFgusBUsPoLRfNxH8psI7RN3kWJGteHFUbyjrlxg5GTK1+3Qia4c T74pbJLoxFZxtVgRr05QLfMZ/4vf3IQnIytEHnZaoMmL1H3OtJEIbfOUYQ8GwzuhB0H4 ZJAgFiOtfiP+THCB2/L8hBA+RnEDvEfR6Q4kQk8CgkfSAV+/FOsOkwGizibzghKm17gy SgkD7mxdNSNPUsU41F3QsLaCLR8WPeSP3kfiRp9knzJgav1HUzeqUKHVIDa/gsgSNRov VPfz4f6TaS4naakcZxpldXvzz02aHGD2rb69vSAsyerHBx3fdPwt3Gu7aHAQK55BVavD GFmg== X-Gm-Message-State: ACrzQf388bQsfV56yodK8AnsaVRbe6KtnzCZgcHTZH9AH4693QmeNjOb i5DP1abY4cCFnCne+mmMbIQ= X-Google-Smtp-Source: AMsMyM5CGywIEUWnqnt/+csJfJN4rkb66ER8comeLewKnNKDjNPkiRCoyie9fJC7IdkmSjA4dcW+9A== X-Received: by 2002:a17:907:270b:b0:7ad:ae01:e0d9 with SMTP id w11-20020a170907270b00b007adae01e0d9mr17137485ejk.196.1667312602855; Tue, 01 Nov 2022 07:23:22 -0700 (PDT) Message-ID: Date: Tue, 1 Nov 2022 16:23:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [XEN v2 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit Content-Language: en-US To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-12-ayankuma@amd.com> <956195e5-0409-1da0-f0db-a0192061d29d@gmail.com> <5b5df2ee-b1b4-bfd8-b6bf-6bf5cb92f557@amd.com> <01a22605-4ae4-d5ba-205c-ab2c1f7d24c2@xen.org> From: Xenia Ragiadakou In-Reply-To: <01a22605-4ae4-d5ba-205c-ab2c1f7d24c2@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/1/22 13:57, Julien Grall wrote: > Hi Ayan, > > On 01/11/2022 10:59, Ayan Kumar Halder wrote: >> >> On 01/11/2022 09:50, Julien Grall wrote: >>> Hi, >> >> Hi Xenia, Julien, >> >> I have few clarifications. >> >>> >>> On 01/11/2022 07:08, Xenia Ragiadakou wrote: >>>> On 10/31/22 17:13, Ayan Kumar Halder wrote: >>>>> Defined readq_relaxed()/writeq_relaxed() to read and write 64 bit >>>>> regs. >>>>> This uses ldrd/strd instructions. >>>>> >>>>> Signed-off-by: Ayan Kumar Halder >>>>> --- >>>>> >>>>> Changes from :- >>>>> v1 - 1. Use ldrd/strd for readq_relaxed()/writeq_relaxed(). >>>>> 2. No need to use le64_to_cpu() as the returned byte order is >>>>> already in cpu >>>>> endianess. >>>>> >>>>>   xen/arch/arm/include/asm/arm32/io.h | 21 +++++++++++++++++++++ >>>>>   1 file changed, 21 insertions(+) >>>>> >>>>> diff --git a/xen/arch/arm/include/asm/arm32/io.h >>>>> b/xen/arch/arm/include/asm/arm32/io.h >>>>> index 73a879e9fb..d9d19ad764 100644 >>>>> --- a/xen/arch/arm/include/asm/arm32/io.h >>>>> +++ b/xen/arch/arm/include/asm/arm32/io.h >>>>> @@ -72,6 +72,22 @@ static inline u32 __raw_readl(const volatile >>>>> void __iomem *addr) >>>>>           return val; >>>>>   } >>>>> +static inline u64 __raw_readq(const volatile void __iomem *addr) >> Rename this to __raw_readq_nonatomic() >>>>> +{ >>>>> +        u64 val; >>>>> +        asm volatile("ldrd %Q1, %R1, %0" >>>>> +                     : "+Qo" (*(volatile u64 __force *)addr), >>>>> +                       "=r" (val)); >>>>> +        return val; >>>>> +} >>>>> + >>>>> +static inline void __raw_writeq(u64 val, const volatile void >>>>> __iomem *addr) >> Rename to __raw_writeq_nonatomic() >>>>> +{ >>>>> +    asm volatile("strd %Q1, %R1, %0" >>>>> +                 : "+Q" (*(volatile u64 __force *)addr) >>>>> +                 : "r" (val)); >>>>> +} >>>>> + >>>>>   #define __iormb()               rmb() >>>>>   #define __iowmb()               wmb() >>>>> @@ -80,17 +96,22 @@ static inline u32 __raw_readl(const volatile >>>>> void __iomem *addr) >>>>>                                           __raw_readw(c)); __r; }) >>>>>   #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \ >>>>>                                           __raw_readl(c)); __r; }) >>>>> +#define readq_relaxed(c) ({ u64 __r = le64_to_cpu((__force __le64) \ >>>>> +                                        __raw_readq(c)); __r; }) >>>>>   #define writeb_relaxed(v,c)     __raw_writeb(v,c) >>>>>   #define writew_relaxed(v,c)     __raw_writew((__force u16) >>>>> cpu_to_le16(v),c) >>>>>   #define writel_relaxed(v,c)     __raw_writel((__force u32) >>>>> cpu_to_le32(v),c) >>>>> +#define writeq_relaxed(v,c)     __raw_writeq((__force u64) >>>>> cpu_to_le64(v),c) >>>>>   #define readb(c)                ({ u8  __v = readb_relaxed(c); >>>>> __iormb(); __v; }) >>>>>   #define readw(c)                ({ u16 __v = readw_relaxed(c); >>>>> __iormb(); __v; }) >>>>>   #define readl(c)                ({ u32 __v = readl_relaxed(c); >>>>> __iormb(); __v; }) >>>>> +#define readq(c)                ({ u64 __v = readq_relaxed(c); >>>>> __iormb(); __v; }) >>>>>   #define writeb(v,c)             ({ __iowmb(); >>>>> writeb_relaxed(v,c); }) >>>>>   #define writew(v,c)             ({ __iowmb(); >>>>> writew_relaxed(v,c); }) >>>>>   #define writel(v,c)             ({ __iowmb(); >>>>> writel_relaxed(v,c); }) >>>>> +#define writeq(v,c)             ({ __iowmb(); writeq_relaxed(v,c); }) >>>>>   #endif /* _ARM_ARM32_IO_H */ >>>> >>>> AFAIU, ldrd/strd accesses to MMIO are not guaranteed to be 64-bit >>>> single-copy atomic. So, as Julien suggested, you still need to use a >>>> different name to reflect this. >> >> Yes you are correct, ldrd/strd for system ram are guaranteed to be >> atomic. Here we are accessing MMIO, so atomicity is not guaranteed. >> >> I wasn't very sure if {read/write}*_relaxed are always atomic. > > All the current use are atomic. >> #define writeq_relaxed(v,c) __raw_writeq_nonatomic((__force u64) >> cpu_to_le64(v),c) >> >> #define readq_relaxed(c) ({ u64 __r = le64_to_cpu((__force __le64) \ >>                                          __raw_readq_nonatomic(c)); >> __r; }) >> >> We can remove "#define readq()/writeq() ..." as they are not used. >> >>>> Also, having nested virtualization in mind, since these instructions >>>> can't be virtualized, maybe it would be better to avoid using them >>>> for MMIO accesses. >> >> Does nested virtualization apply to Arm ? > > This is supported by the Architecture although not implemented in Xen. > >> >> Reading https://wiki.xenproject.org/wiki/Nested_Virtualization_in_Xen >> , I find two points of interest >> >> "Only 64-bit hypervisors are supported at this time." >> >> "See below for more details on tested hypervisior / guest >> combinations, and known issues on Intel CPUs" >> >> Thus, I understand that nested virtualization is supported only on x86 >> machines and that too 64bit only. Thus, it does not apply to AArch32. > > The wiki page is describing the case where another hypervisor is running > on top of Xen. But there is no support necessary in Xen to run it on top > of another hypervisor. > > I haven't looked whether the architecture allows to use nested on 32-bit > though... > To clarify... what I had in mind was an aarch32 XEN (guest) hosted by an aarch64 hypervisor. >> >> Let me know if I misunderstood something. >> >>> >>> +1. The previous version was actually using 32-bit access and it is >>> not clear to me why the new version is using 64-bit access. >> >> IMO, I made a mistake in my previous patch of using 2 32bit access for >> a 64 bit register. >> >> ldrd/strd is not supported for AArch32 guests in EL1 mode when they >> access emulated MMIO region (which traps to EL2). >> >> However, ldrd/strd is supported for AArch32 hypervisors running in EL2 >> mode. > > That's not what I understood from previous discussion [1]. ldrd/strd > would be atomic on system RAM but there is no guarantee they would be > for MMIO access. > > I know this was Andre's interpretation. However, the HW architects may > have interpreted the same way... > > So I think we should be convervative in Xen. AFAICT, in the case of > GICv3, we don't need the atomicity for the 64-bit registers. Therefore, > I would rather prefer if we introduce an helper that do two 32-bit read. > > Cheers, > > [1] > https://lore.kernel.org/xen-devel/20221027153632.0cf7d004@donnerap.cambridge.arm.com/ > > -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Nov 01 14:43:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 14:43:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434722.687088 (Exim 4.92) (envelope-from ) id 1opsUS-0005pd-0l; Tue, 01 Nov 2022 14:43:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434722.687088; Tue, 01 Nov 2022 14:43:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opsUR-0005pW-U0; Tue, 01 Nov 2022 14:43:43 +0000 Received: by outflank-mailman (input) for mailman id 434722; Tue, 01 Nov 2022 14:43:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opsUQ-0005pQ-2r for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 14:43:42 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 921f458e-59f3-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 15:43:39 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by SA1PR12MB6919.namprd12.prod.outlook.com (2603:10b6:806:24e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Tue, 1 Nov 2022 14:43:35 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 14:43:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 921f458e-59f3-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LhLaPXakoACxCC6SSgh8lvDEye4tQakzmrzDs7IuHtEaAwdjUp2ek1mLZ65W0poHJ7Zdx1DEjDQLN6c7ITJvqNCQOeibMxIkoHLfYOQoiFLZZxqfJeKDrN2Yb3aHC290yWG64MtP107gu8MA0yKwdZQXrTo/cE6Nagc99ITGBN/s7rwlxE70P1uBINmvMGyfzF9TFAym1+LBbESK7SGdTffbWNwzJ4/5JnkvKkby3SD/gEIzZe4ElcY+IbDmgeqZXBnFYs5yMvF1IUSz6cz9l5WpmECcFVgjZPi7ERtF4tfkL+76b5N04nIMzhlNz5/G3NUtYsfs3BCbXsllvharqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XGNckTtpVsAtin8tuowT5MZxIdcWk/p2dn94h3ibjPA=; b=Nn2oklDhnM/7PnGxhrbyF2GSUcXAcbub9IiKmOb6w83xQZfNUkXi5sa8syAS9l0+ssQDJEabrjgQ4ocsijfh4Yd4jDvl7my7qB14RAONaEmYzIdV5ommS7VGf9YsD+zEyCQkAR5t+uxovQthFI7RyywRC9j79jJplVAjWbBhLKpzP5P3nm8u28vjmFpAXduuEx5dWVYuyG+fIETgP2c6fLhPgVf142iJ8mh8nKaX7kk3NKAPgaj3YoBPwQ0mL4eTCQydiNJAjcsoZYB+hKBhMFkwwQzqD4mIrlfv0rX0shSgYcHkebq7DakazZ0S8+gKS06klq0HhJ+fB2v9Vx8y0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XGNckTtpVsAtin8tuowT5MZxIdcWk/p2dn94h3ibjPA=; b=DqbeFfnNPtxvPUiQ/yvRdECZeI4zLn2s9vWl1kEBO/Nl/xoHiul0qM6qwJByKZ4gaH/3o+V1W628uB+2NeZCm1lblyj2uHf7ZDYBp24JmHxU61KEkKAyiRR87eaSIqJ/YIi3ftgWbEpVbiRRnEPEwqT0X6jQiPnPmW/HK+t9cGo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <0a8b2d0e-1352-cb69-f567-e63b5bbbabef@amd.com> Date: Tue, 1 Nov 2022 14:43:29 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 10/12] xen/Arm: GICv3: Use ULL instead of UL for 64bits To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-11-ayankuma@amd.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0118.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::8) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|SA1PR12MB6919:EE_ X-MS-Office365-Filtering-Correlation-Id: 315cc084-2564-4ded-1166-08dabc1773c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yT+1gkb44U6cajs2It+ONGCAuV9FUzRXnAL7Fte00p40lTKMc9m0Vm7hW1kV3/GdplRtF8IVH1Icj8drAc4MyozxUITGdzVk+g+D3SGVPjqQKAvp4rvYF0EU08zzccWKsfs0rHUzG9bNivor45Y8jT5TIcduqRRnmnMlKmf+X+252DhA8CpEI9UKfK/jKmE2nl+FLrXiS+quVqSVGyehj6GmzLU5bfT8GhEcArXnFv4ylPpV/7gGmZK8iapD8U8jD49t46QiOwKseSFoProb/ihGw+4CR26jQaj32xMsDoTW0SDW6D20WXy/JcSTyR02LIz5bzE9VzVsvNwD302AgWZYaKTYGGqki8lwl/WsK+6zbJFCJMua7RZ9q6qVMZWSfZfRmE1L6Ghl9OX8pWqx3mwm29uRMlKNdbM12qo/KJuvYutyCkOsYbVGa7RU6xKtIUt0wa3h/9y4EpFOyZAy8yzbweC9tzPF7DxmlYefL6OSnCOdc8n2AzGyJ+I2bLGw4e3JVWAu6tZqtXaE9byCDcvKsr00TJn6dxIJMks7WixDyZR+smUjN+wVDDG2OisQp4D4/z+HFT/XDQ7lisJb430EZE4i0LxI8bxg5pfoWHwxvq4E1oqtNaIt4oK9jBhSlITc4boW+ooH2RdYzzsGioC7R+h0cGe4DSoRrXShA90xB5LykGKWs5gd1DQToCzmuY8r+fOwqHTEMKUJd8vzHu2KlqSIyMmMZc86OQPsDb9F2/eRhSCY+56VGr90bRhhjQH8k2HVXOql+kuds/W4BYBkab4HruiI6pNUuxmGfOE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(376002)(396003)(136003)(39860400002)(451199015)(186003)(38100700002)(2906002)(31696002)(316002)(53546011)(4326008)(8676002)(6506007)(6666004)(66556008)(66476007)(66946007)(36756003)(2616005)(41300700001)(26005)(6512007)(5660300002)(8936002)(478600001)(31686004)(83380400001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnB6V2xaSHJLOWpsdk11eFlYQkp6TGUzKzFMTTlSZGxkQUhoeUpCeldjbjNi?= =?utf-8?B?OXNDQnV1MHhtUndrNFYydjEvRHUwdDFNLzg5ajF2N0FGMDFxaHJQbVBoRU53?= =?utf-8?B?TUoxbG1jVzdzQjlsVVF6ZmN2MHZVTEh3OU5tWTVHWHgyNEIzM0xCTEZEckZ6?= =?utf-8?B?TG45NXdKRUVzdGQyMlNHbElaTERETFNQV3BGZWNlOHRwWXFSMGQzVG9YYUFC?= =?utf-8?B?eEtlNERxSWM4K2dhbnZSejJWYkVycFc1aTRGZnZUN3pVOW9hcDl2eE9RRUNP?= =?utf-8?B?dks0b0dJb2hMYklvK2ZqS1NIR09GVXlVRFd5MVdLT0FuMVdVTEpWUDFUYVFM?= =?utf-8?B?THUxR1NSUTVKaTBycEFmNEVrQUZMT2kyN1FHdE5haHpNSHJpZlc0eFZSMVZa?= =?utf-8?B?OUp0aXQwaDZPamxkNkI0VW10YjIxSnpRVmZIaUQyV2ZQNjhwZ3RMbTBoc1FN?= =?utf-8?B?NjZzYVFNWW00YjFXS3hYUUErTm5HWFZNblNiYTZYVmI0SWVBUHFIUm5iRDIw?= =?utf-8?B?Rm84YXVHWXRpbERYOU53SFZxd2hpQzlISWwwMVhlYU1uWFA1clpKM2dqMVkr?= =?utf-8?B?OW5DQnBISVNQMU1PcmlVc2d3bSsrY3NhM2tidWRMa1k4SHdKclRjcGk4bEI3?= =?utf-8?B?eDl0S3BRVGZjUmFGcFU1SGJsS1Zwck53NjhESUlpdzVTSUpzM2tzL1VoaXFx?= =?utf-8?B?ZTJOOFFva1JEcW5uTkt2c0lwUGVGeng4dGhteXRoRGtPeUdKZndXdlAyMVly?= =?utf-8?B?QW4yL0cyTU4yVmhBZHFpdUYrZjMvcFFZMDU0NktJUlZsOUphNTAzekpuSjBF?= =?utf-8?B?dUthVWNnSjZpTzlRZUR2dTQ4ZmVwVUpHRHUxdnd0aWlqTWlOZlZGaS9BVlRK?= =?utf-8?B?MWZaK2dKSU1oNHEvbXZCRHdpa1ZHWFlCUEVnd2xaZ0V2amI2MEtkVmdnQ2E3?= =?utf-8?B?OUp4cFhPRFNaMVc2dHdLdjlaR2ROcE5Jbnp5c25VVlA4dXE0SXBUNlk4VkNC?= =?utf-8?B?U2s1OU5oVWRscU8zS0NWZVZodGRjUlBnL0NuVk8zcGdUS09DVmEwdFBHZjZV?= =?utf-8?B?YlY0WmtRQVZmL0ZmR05WcHhwcUdlK3Z0SEZzSnkycXRUcTRqcTMrRUs3azRi?= =?utf-8?B?UWp3Qno5a2RDMzJMcDJEQ3JYdVhjUHdwRTRXVDBOTUE5QkpIU2lXWWJ0YkNP?= =?utf-8?B?SGNMSXNKNmIzK1RmRWZMbGNKK3NueEZJcTMzTEtWVFNxdUN3RkVNL2Y4Y0g4?= =?utf-8?B?T2l6R21wMXBpL1dLUGlCQlU1MnVxRnhvMlVjN1VXRzZidDlvbVEvdGZxRnJ0?= =?utf-8?B?MUpDQkY4M012aENNREhObWZGVzN5TFhZT214Mmc3NGNvQ2dEcnRCZUpLMDdQ?= =?utf-8?B?dWFtbTEwYXpsa3FmaTl0MnJqa05XUStjOW51K05mNzRzM1NRbzdPRHBYTFU0?= =?utf-8?B?WmJ1c1hKME9tMERYQkU2Tys5R1l1aG5ZcG14UEgrTFhPQURubnNLREU0RjB0?= =?utf-8?B?eHZqOWJLSkltS1o1UVdpdGd4TjIxa3UvMVhmK3JFcWZtcHlpRFRKd0IyclJ6?= =?utf-8?B?WHlpbVJvVmxVRWhrQ3dra05iUm1QTjZHMU5ITjhBTnN2QjJsVnc1QkcxMmtF?= =?utf-8?B?azFDTjlDbWFCK2lxLzhkendlUitIR1dSRmd0cU1iYWx5dkEzVmFWSHN3QUJV?= =?utf-8?B?elE0RnZDMGNJWU9DMW90MFc1VlFSQ0pLay9MQUlITWVmNENnODFnRW1NcVlP?= =?utf-8?B?YVByRERBbU14ZklxSVFlVFo2dmxvcVJYd25sdlJkVHljWjc1R21teEhOaFQ1?= =?utf-8?B?NFZ0d1lkZ2xQTWd1clJSRFozRnNlTjkwdU8xUHZnSmtPbm90dEp3V3U4OXFX?= =?utf-8?B?UGpuNWwybU5jUDlnMzE0eHBPY0tST0ZWMWU3WnRHN1gwdi9raCt1b0pGb2tj?= =?utf-8?B?NzVJdjZaSTJFZFZqZWVLcWFDVlI2d2VEMERLVDZTOEFDcXZmS3lUTXJFMkFE?= =?utf-8?B?Qmx5VkptWDh0R1pxQUlHZUEwdXRnTXd5WWVoMjl2K1Q4NHhPcGFSK045bUFr?= =?utf-8?B?MWw0STh3Um83Y1NzV1NzM0VCSWYwNElvMnV1UFdQbUF0c0p1c1ZNTWlDZEow?= =?utf-8?Q?roh/Y+jkC4VzRkoCMxUb7YjQh?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 315cc084-2564-4ded-1166-08dabc1773c2 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 14:43:34.2776 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mc+rgG6IbFP75ywWCKQmnQCz4HVo6u+NE89RhsnkPVBYLdMsBdct3fjmW8zU1Y4UU0OxOFGducX2XaON9oXDWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6919 On 01/11/2022 10:03, Xenia Ragiadakou wrote: > Hi Ayan, Hi Xenia, > > On 10/31/22 17:13, Ayan Kumar Halder wrote: >> "unsigned long long" is defined as 64 bits on AArch64 and AArch32 >> Thus, one should this instead of "unsigned long" which is 32 bits >> on AArch32. >> >> Also use 'PRIx64' instead of 'lx' or 'llx' to print uint64_t. >> >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changed from :- >> v1 - 1. Replace PRIu64 with PRIx64 so that the values are printed in >> hex as >> desired. >> 2. Use ULL in GITS_BASER_RO_MASK as MMIO registers are always unsigned. >> >>   xen/arch/arm/gic-v3-lpi.c              |  8 ++++---- >>   xen/arch/arm/gic-v3.c                  |  4 ++-- >>   xen/arch/arm/include/asm/gic_v3_defs.h |  2 +- >>   xen/arch/arm/include/asm/gic_v3_its.h  |  2 +- >>   xen/arch/arm/vgic-v3-its.c             | 17 +++++++++-------- >>   5 files changed, 17 insertions(+), 16 deletions(-) >> >> diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c >> index 61d90eb386..9ca74bc321 100644 >> --- a/xen/arch/arm/gic-v3-lpi.c >> +++ b/xen/arch/arm/gic-v3-lpi.c >> @@ -134,7 +134,7 @@ void gicv3_set_redist_address(paddr_t address, >> unsigned int redist_id) >>   uint64_t gicv3_get_redist_address(unsigned int cpu, bool use_pta) >>   { >>       if ( use_pta ) >> -        return per_cpu(lpi_redist, cpu).redist_addr & GENMASK(51, 16); >> +        return per_cpu(lpi_redist, cpu).redist_addr & >> GENMASK_ULL(51, 16); >>       else >>           return per_cpu(lpi_redist, cpu).redist_id << 16; >>   } >> @@ -253,7 +253,7 @@ static int gicv3_lpi_allocate_pendtable(unsigned >> int cpu) >>           return -ENOMEM; >>         /* Make sure the physical address can be encoded in the >> register. */ >> -    if ( virt_to_maddr(pendtable) & ~GENMASK(51, 16) ) >> +    if ( virt_to_maddr(pendtable) & ~GENMASK_ULL(51, 16) ) >>       { >>           xfree(pendtable); >>           return -ERANGE; >> @@ -281,7 +281,7 @@ static int gicv3_lpi_set_pendtable(void __iomem >> *rdist_base) >>           return -ENOMEM; >>       } >>   -    ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK(51, 16))); >> +    ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK_ULL(51, 16))); >>         val  = GIC_BASER_CACHE_RaWaWb << >> GICR_PENDBASER_INNER_CACHEABILITY_SHIFT; >>       val |= GIC_BASER_CACHE_SameAsInner << >> GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT; >> @@ -329,7 +329,7 @@ static int gicv3_lpi_set_proptable(void __iomem * >> rdist_base) >>               return -ENOMEM; >>             /* Make sure the physical address can be encoded in the >> register. */ >> -        if ( (virt_to_maddr(table) & ~GENMASK(51, 12)) ) >> +        if ( (virt_to_maddr(table) & ~GENMASK_ULL(51, 12)) ) >>           { >>               xfree(table); >>               return -ERANGE; >> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c >> index 8b4b168e78..d8ce0f46c6 100644 >> --- a/xen/arch/arm/gic-v3.c >> +++ b/xen/arch/arm/gic-v3.c >> @@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v) >>       if ( v == current ) >>       { >>           for ( i = 0; i < gicv3_info.nr_lrs; i++ ) >> -            printk("   HW_LR[%d]=%llx\n", i, gicv3_ich_read_lr(i)); >> +            printk("   HW_LR[%d]=%" PRIx64 "\n", i, >> gicv3_ich_read_lr(i)); >>       } >>       else >>       { >>           for ( i = 0; i < gicv3_info.nr_lrs; i++ ) >> -            printk("   VCPU_LR[%d]=%llx\n", i, v->arch.gic.v3.lr[i]); >> +            printk("   VCPU_LR[%d]=%" PRIx64 "\n", i, >> v->arch.gic.v3.lr[i]); >>       } >>   } >>   diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h >> b/xen/arch/arm/include/asm/gic_v3_defs.h >> index 87115f8b25..3a24bd4825 100644 >> --- a/xen/arch/arm/include/asm/gic_v3_defs.h >> +++ b/xen/arch/arm/include/asm/gic_v3_defs.h >> @@ -195,7 +195,7 @@ >>     #define ICH_SGI_IRQMODE_SHIFT        40 >>   #define ICH_SGI_IRQMODE_MASK         0x1 >> -#define ICH_SGI_TARGET_OTHERS        1UL >> +#define ICH_SGI_TARGET_OTHERS        1ULL >>   #define ICH_SGI_TARGET_LIST          0 >>   #define ICH_SGI_IRQ_SHIFT            24 >>   #define ICH_SGI_IRQ_MASK             0xf >> diff --git a/xen/arch/arm/include/asm/gic_v3_its.h >> b/xen/arch/arm/include/asm/gic_v3_its.h >> index fae3f6ecef..5ae50b18ea 100644 >> --- a/xen/arch/arm/include/asm/gic_v3_its.h >> +++ b/xen/arch/arm/include/asm/gic_v3_its.h Changes not required as ITS is not supported on AArch32 v8R GIC. >> @@ -38,7 +38,7 @@ >>   #define GITS_PIDR2                      GICR_PIDR2 >>     /* Register bits */ >> -#define GITS_VALID_BIT                  BIT(63, UL) >> +#define GITS_VALID_BIT                  BIT(63, ULL) >>     #define GITS_CTLR_QUIESCENT             BIT(31, UL) >>   #define GITS_CTLR_ENABLE                BIT(0, UL) > > It seems that you forgot GITS_BASER_INDIRECT, that is BIT(62, UL). > >> diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c >> index 58d939b85f..c5e02b2c41 100644 >> --- a/xen/arch/arm/vgic-v3-its.c >> +++ b/xen/arch/arm/vgic-v3-its.c Changes not required as ITS is not supported on AArch32 v8R GIC. >> @@ -96,13 +96,13 @@ typedef uint16_t coll_table_entry_t; >>    * in the lowest 5 bits of the word. >>    */ >>   typedef uint64_t dev_table_entry_t; >> -#define DEV_TABLE_ITT_ADDR(x) ((x) & GENMASK(51, 8)) >> +#define DEV_TABLE_ITT_ADDR(x) ((x) & GENMASK_ULL(51, 8)) >>   #define DEV_TABLE_ITT_SIZE(x) (BIT(((x) & GENMASK(4, 0)) + 1, UL)) >>   #define DEV_TABLE_ENTRY(addr, bits)                     \ >>           (((addr) & GENMASK(51, 8)) | (((bits) - 1) & GENMASK(4, 0))) >>     #define GITS_BASER_RO_MASK       (GITS_BASER_TYPE_MASK | \ >> -                                  (0x1fL << >> GITS_BASER_ENTRY_SIZE_SHIFT)) >> +                                  (0x1ULL << >> GITS_BASER_ENTRY_SIZE_SHIFT)) > > You have accidently dropped 'f' from the mask. Yes, actually I intentionally dropped it. AFAIU, 'fL' represent a floating point literal. This does not make sense are the MMIO registers are always unsigned long (32 bit) or unsigned long long (64 bit). So, I corrected it. > > I noticed that you change to ULL only a part of GENMASK and BIT > occurences, I cannot see why. Maybe I m missing sth. Actually, I am trying to change only where the shift exceeds 32 bits. > > Also, with patch [XEN v2 12/12] xen/Arm: GICv3: Enable GICv3 for > AArch32, you disable ITS support for arm32, so it seems that those > changes in ITS related files are not required (not that do any harm to > have). Sorry, this is my mistake. I should not have changed gic_v3_its.h or vgic-v3-its.c as they are not used for AArch32 v8R GIC. I will fix this in v3. - Ayan > >>     /* >>    * The physical address is encoded slightly differently depending on >> @@ -112,10 +112,10 @@ typedef uint64_t dev_table_entry_t; >>   static paddr_t get_baser_phys_addr(uint64_t reg) >>   { >>       if ( reg & BIT(9, UL) ) >> -        return (reg & GENMASK(47, 16)) | >> +        return (reg & GENMASK_ULL(47, 16)) | >>                   ((reg & GENMASK(15, 12)) << 36); >>       else >> -        return reg & GENMASK(47, 12); >> +        return reg & GENMASK_ULL(47, 12); >>   } >>     /* Must be called with the ITS lock held. */ >> @@ -414,7 +414,7 @@ static int update_lpi_property(struct domain *d, >> struct pending_irq *p) >>       if ( !d->arch.vgic.rdists_enabled ) >>           return 0; >>   -    addr = d->arch.vgic.rdist_propbase & GENMASK(51, 12); >> +    addr = d->arch.vgic.rdist_propbase & GENMASK_ULL(51, 12); >>         ret = access_guest_memory_by_ipa(d, addr + p->irq - LPI_OFFSET, >>                                        &property, sizeof(property), >> false); >> @@ -897,7 +897,8 @@ out_unlock: >>     static void dump_its_command(uint64_t *command) >>   { >> -    gdprintk(XENLOG_WARNING, "  cmd 0x%02lx: %016lx %016lx %016lx >> %016lx\n", >> +    gdprintk(XENLOG_WARNING, "  cmd 0x%" PRIx64 ": %" PRIx64 >> +             "%" PRIx64 "%" PRIx64 "%" PRIx64 "\n", >>                its_cmd_get_command(command), >>                command[0], command[1], command[2], command[3]); >>   } >> @@ -909,7 +910,7 @@ static void dump_its_command(uint64_t *command) >>    */ >>   static int vgic_its_handle_cmds(struct domain *d, struct virt_its >> *its) >>   { >> -    paddr_t addr = its->cbaser & GENMASK(51, 12); >> +    paddr_t addr = its->cbaser & GENMASK_ULL(51, 12); >>       uint64_t command[4]; >>         ASSERT(spin_is_locked(&its->vcmd_lock)); >> @@ -1122,7 +1123,7 @@ read_as_zero_64: >>     read_impl_defined: >>       printk(XENLOG_G_DEBUG >> -           "%pv: vGITS: RAZ on implementation defined register >> offset %#04lx\n", >> +           "%pv: vGITS: RAZ on implementation defined register >> offset %" PRIx64 "#04llx\n", >>              v, info->gpa & 0xffff); >>       *r = 0; >>       return 1; > From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:02:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:02:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434776.687270 (Exim 4.92) (envelope-from ) id 1opsmr-0002MF-Mg; Tue, 01 Nov 2022 15:02:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434776.687270; Tue, 01 Nov 2022 15:02:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opsmr-0002M8-Jn; Tue, 01 Nov 2022 15:02:45 +0000 Received: by outflank-mailman (input) for mailman id 434776; Tue, 01 Nov 2022 15:02:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opsmq-0002Lv-D7 for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:02:44 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3b47f9e7-59f6-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 16:02:42 +0100 (CET) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 2A1F1vhX015299 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 1 Nov 2022 11:02:03 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 2A1F1v3f015298; Tue, 1 Nov 2022 08:01:57 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b47f9e7-59f6-11ed-91b5-6bf2151ebd3b Date: Tue, 1 Nov 2022 08:01:57 -0700 From: Elliott Mitchell To: Bertrand Marquis Cc: Stefano Stabellini , Julien Grall , Rahul Singh , Xen developer discussion , Michal Orzel , Oleksandr Tyshchenko , Oleksandr Andrushchenko , Volodymyr Babchuk , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Andrew Cooper , Juergen Gross Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices Message-ID: References: <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com> <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com> <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org> <82c45bc1-6052-502b-3007-8a16fbd1d433@xen.org> <9F323893-B1C9-4D31-9A40-213345421860@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9F323893-B1C9-4D31-9A40-213345421860@arm.com> X-Spam-Status: No, score=-0.0 required=10.0 tests=KHOP_HELO_FCRDNS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com On Mon, Oct 31, 2022 at 01:26:44PM +0000, Bertrand Marquis wrote: > > > On 30 Oct 2022, at 21:14, Stefano Stabellini wrote: > > > > Ideally this would be something quick that can be easily invoked as the > > first step of an external third-party build process. > > I think that we are making this problem a lot to complex and I am not sure > that all this complexity is required. Speaking of complexity. Is it just me or does a vIOMMU had an odd sort of similarity with a Grant Table? Both are about allowing foreign entities access to portions of the current domain's memory. Just in the case of a Grant Table the entity happens to be another domain, whereas for a vIOMMU it is a hardware device. Perhaps some functionality could be shared between the two? Perhaps this is something for the designer of the next version of IOMMU to think about? (or perhaps I'm off the deep end and bringing in a silly idea) -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:28:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:28:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434829.687457 (Exim 4.92) (envelope-from ) id 1optCB-0007Uk-82; Tue, 01 Nov 2022 15:28:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434829.687457; Tue, 01 Nov 2022 15:28:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCB-0007Ud-33; Tue, 01 Nov 2022 15:28:55 +0000 Received: by outflank-mailman (input) for mailman id 434829; Tue, 01 Nov 2022 15:28:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optC9-0007Tl-Pn for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:28:53 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e3924cde-59f9-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 16:28:52 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B778C1F8E3; Tue, 1 Nov 2022 15:28:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 882431346F; Tue, 1 Nov 2022 15:28:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HBTaHzM7YWOBYAAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:28:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3924cde-59f9-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316531; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2kCPlZkMn4lMbWZL1TxCM0JXd1CkVTaMTWMc1Tu0JRs=; b=UhkOmD9eqKepd1DwAGoQnmkF54esO2ORp7c5GTlAIM5iUH+zcY9MWpgGafI54QEl8nmjv5 NMjJqRr3JPo8y4AhoZjG1pmBTBmf+OXP0tKOQrfriHwS19OdzjvE4WUYBYH8RTG0htlbkY L8o20/0kxNP8peDj3efPqVmq6PpqTLo= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD , Julien Grall Subject: [PATCH 01/20] tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR Date: Tue, 1 Nov 2022 16:28:23 +0100 Message-Id: <20221101152842.4257-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit XEN_LIB_STORED is serving no real purpose, as it is a mount point for a tmpfs, so it can be replaced easily by XEN_RUN_STORED. XENSTORED_ROOTDIR is basically unused already, there is just a single reference in xs_daemon_rootdir() with a fallback to XEN_LIB_STORED, and a .gdbinit file setting it. Remove the .gdbinit file, as it is not known having been used since ages, and make xs_daemon_rootdir() an alias of xs_daemon_rundir(). Signed-off-by: Juergen Gross --- config/Paths.mk.in | 1 - configure | 4 ---- docs/configure | 4 ---- m4/paths.m4 | 3 --- tools/configure | 7 +------ tools/configure.ac | 1 - tools/hotplug/FreeBSD/rc.d/xencommons.in | 6 ------ tools/hotplug/Linux/systemd/Makefile | 1 - .../hotplug/Linux/systemd/var-lib-xenstored.mount.in | 12 ------------ tools/libs/store/Makefile | 1 - tools/xenstore/.gdbinit | 4 ---- tools/xenstore/Makefile | 4 ---- tools/xenstore/Makefile.common | 1 - tools/xenstore/xs_lib.c | 11 +++++------ 14 files changed, 6 insertions(+), 54 deletions(-) delete mode 100644 tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in delete mode 100644 tools/xenstore/.gdbinit diff --git a/config/Paths.mk.in b/config/Paths.mk.in index 416fc7aab9..44bab1d748 100644 --- a/config/Paths.mk.in +++ b/config/Paths.mk.in @@ -41,7 +41,6 @@ MAN8DIR := $(mandir)/man8 XEN_RUN_DIR := @XEN_RUN_DIR@ XEN_LOG_DIR := @XEN_LOG_DIR@ XEN_LIB_DIR := @XEN_LIB_DIR@ -XEN_LIB_STORED := @XEN_LIB_STORED@ XEN_RUN_STORED := @XEN_RUN_STORED@ CONFIG_DIR := @CONFIG_DIR@ diff --git a/configure b/configure index bb7f27ddad..b51174f2ef 100755 --- a/configure +++ b/configure @@ -603,7 +603,6 @@ INITD_DIR SHAREDIR XEN_LIB_DIR XEN_RUN_STORED -XEN_LIB_STORED XEN_LOG_DIR XEN_RUN_DIR XENFIRMWAREDIR @@ -2081,9 +2080,6 @@ cat >>confdefs.h <<_ACEOF _ACEOF -XEN_LIB_STORED=$localstatedir/lib/xenstored - - XEN_RUN_STORED=$rundir_path/xenstored diff --git a/docs/configure b/docs/configure index d4fced9858..f008ca0565 100755 --- a/docs/configure +++ b/docs/configure @@ -601,7 +601,6 @@ INITD_DIR SHAREDIR XEN_LIB_DIR XEN_RUN_STORED -XEN_LIB_STORED XEN_LOG_DIR XEN_RUN_DIR XENFIRMWAREDIR @@ -1984,9 +1983,6 @@ cat >>confdefs.h <<_ACEOF _ACEOF -XEN_LIB_STORED=$localstatedir/lib/xenstored - - XEN_RUN_STORED=$rundir_path/xenstored diff --git a/m4/paths.m4 b/m4/paths.m4 index 826faada45..e4104bcce0 100644 --- a/m4/paths.m4 +++ b/m4/paths.m4 @@ -136,9 +136,6 @@ XEN_LOG_DIR=$localstatedir/log/xen AC_SUBST(XEN_LOG_DIR) AC_DEFINE_UNQUOTED([XEN_LOG_DIR], ["$XEN_LOG_DIR"], [Xen's log dir]) -XEN_LIB_STORED=$localstatedir/lib/xenstored -AC_SUBST(XEN_LIB_STORED) - XEN_RUN_STORED=$rundir_path/xenstored AC_SUBST(XEN_RUN_STORED) diff --git a/tools/configure b/tools/configure index 6199823f5a..ffe3f48901 100755 --- a/tools/configure +++ b/tools/configure @@ -725,7 +725,6 @@ INITD_DIR SHAREDIR XEN_LIB_DIR XEN_RUN_STORED -XEN_LIB_STORED XEN_LOG_DIR XEN_RUN_DIR XENFIRMWAREDIR @@ -4065,9 +4064,6 @@ cat >>confdefs.h <<_ACEOF _ACEOF -XEN_LIB_STORED=$localstatedir/lib/xenstored - - XEN_RUN_STORED=$rundir_path/xenstored @@ -10085,7 +10081,7 @@ fi if test "x$systemd" = "xy"; then : - ac_config_files="$ac_config_files hotplug/Linux/systemd/proc-xen.mount hotplug/Linux/systemd/var-lib-xenstored.mount hotplug/Linux/systemd/xen-init-dom0.service hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service hotplug/Linux/systemd/xen-watchdog.service hotplug/Linux/systemd/xenconsoled.service hotplug/Linux/systemd/xendomains.service hotplug/Linux/systemd/xendriverdomain.service hotplug/Linux/systemd/xenstored.service" + ac_config_files="$ac_config_files hotplug/Linux/systemd/proc-xen.mount hotplug/Linux/systemd/xen-init-dom0.service hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service hotplug/Linux/systemd/xen-watchdog.service hotplug/Linux/systemd/xenconsoled.service hotplug/Linux/systemd/xendomains.service hotplug/Linux/systemd/xendriverdomain.service hotplug/Linux/systemd/xenstored.service" fi @@ -10967,7 +10963,6 @@ do "ocaml/xenstored/oxenstored.conf") CONFIG_FILES="$CONFIG_FILES ocaml/xenstored/oxenstored.conf" ;; "config.h") CONFIG_HEADERS="$CONFIG_HEADERS config.h" ;; "hotplug/Linux/systemd/proc-xen.mount") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/proc-xen.mount" ;; - "hotplug/Linux/systemd/var-lib-xenstored.mount") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/var-lib-xenstored.mount" ;; "hotplug/Linux/systemd/xen-init-dom0.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xen-init-dom0.service" ;; "hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service" ;; "hotplug/Linux/systemd/xen-watchdog.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xen-watchdog.service" ;; diff --git a/tools/configure.ac b/tools/configure.ac index 18e481d77e..3a2f6a2da9 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -482,7 +482,6 @@ AX_AVAILABLE_SYSTEMD() AS_IF([test "x$systemd" = "xy"], [ AC_CONFIG_FILES([ hotplug/Linux/systemd/proc-xen.mount - hotplug/Linux/systemd/var-lib-xenstored.mount hotplug/Linux/systemd/xen-init-dom0.service hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service hotplug/Linux/systemd/xen-watchdog.service diff --git a/tools/hotplug/FreeBSD/rc.d/xencommons.in b/tools/hotplug/FreeBSD/rc.d/xencommons.in index fddcce314c..7f7cda289f 100644 --- a/tools/hotplug/FreeBSD/rc.d/xencommons.in +++ b/tools/hotplug/FreeBSD/rc.d/xencommons.in @@ -14,7 +14,6 @@ export LD_LIBRARY_PATH name="xencommons" rcvar="xencommons_enable" -start_precmd="xen_precmd" start_cmd="xen_startcmd" stop_cmd="xen_stop" status_cmd="xen_status" @@ -30,11 +29,6 @@ XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid" load_rc_config $name : ${xencommons_enable:=no} -xen_precmd() -{ - mkdir -p @XEN_LIB_STORED@ || exit 1 -} - xen_startcmd() { local time=0 diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile index 26df2a43b1..e29889156d 100644 --- a/tools/hotplug/Linux/systemd/Makefile +++ b/tools/hotplug/Linux/systemd/Makefile @@ -4,7 +4,6 @@ include $(XEN_ROOT)/tools/Rules.mk XEN_SYSTEMD_MODULES := xen.conf XEN_SYSTEMD_MOUNT := proc-xen.mount -XEN_SYSTEMD_MOUNT += var-lib-xenstored.mount XEN_SYSTEMD_SERVICE := xenstored.service XEN_SYSTEMD_SERVICE += xenconsoled.service diff --git a/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in b/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in deleted file mode 100644 index 11a7d50edc..0000000000 --- a/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in +++ /dev/null @@ -1,12 +0,0 @@ -[Unit] -Description=mount xenstore file system -Requires=proc-xen.mount -After=proc-xen.mount -ConditionPathExists=/proc/xen/capabilities -RefuseManualStop=true - -[Mount] -What=xenstore -Where=@XEN_LIB_STORED@ -Type=tmpfs -Options=mode=755 diff --git a/tools/libs/store/Makefile b/tools/libs/store/Makefile index 2334c953bb..3557a8c76d 100644 --- a/tools/libs/store/Makefile +++ b/tools/libs/store/Makefile @@ -18,7 +18,6 @@ include ../libs.mk # Include configure output (config.h) CFLAGS += -include $(XEN_ROOT)/tools/config.h CFLAGS += $(CFLAGS_libxentoolcore) -CFLAGS += -DXEN_LIB_STORED="\"$(XEN_LIB_STORED)\"" CFLAGS += -DXEN_RUN_STORED="\"$(XEN_RUN_STORED)\"" vpath xs_lib.c $(XEN_ROOT)/tools/xenstore diff --git a/tools/xenstore/.gdbinit b/tools/xenstore/.gdbinit deleted file mode 100644 index 9a71b20ac4..0000000000 --- a/tools/xenstore/.gdbinit +++ /dev/null @@ -1,4 +0,0 @@ -set environment XENSTORED_RUNDIR=testsuite/tmp -set environment XENSTORED_ROOTDIR=testsuite/tmp -handle SIGUSR1 noprint nostop -handle SIGPIPE noprint nostop diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile index 1b66190cc5..ce7a68178f 100644 --- a/tools/xenstore/Makefile +++ b/tools/xenstore/Makefile @@ -69,7 +69,6 @@ install: all $(INSTALL_DIR) $(DESTDIR)$(bindir) ifeq ($(XENSTORE_XENSTORED),y) $(INSTALL_DIR) $(DESTDIR)$(sbindir) - $(INSTALL_DIR) $(DESTDIR)$(XEN_LIB_STORED) $(INSTALL_PROG) xenstored $(DESTDIR)$(sbindir) endif $(INSTALL_PROG) xenstore-control $(DESTDIR)$(bindir) @@ -85,9 +84,6 @@ uninstall: rm -f $(DESTDIR)$(bindir)/xenstore-control ifeq ($(XENSTORE_XENSTORED),y) rm -f $(DESTDIR)$(sbindir)/xenstored - if [ -d $(DESTDIR)$(XEN_LIB_STORED) ]; then \ - rmdir --ignore-fail-on-non-empty $(DESTDIR)$(XEN_LIB_STORED); \ - fi endif if [ -d $(DESTDIR)$(includedir)/xenstore-compat ]; then \ rmdir --ignore-fail-on-non-empty $(DESTDIR)$(includedir)/xenstore-compat; \ diff --git a/tools/xenstore/Makefile.common b/tools/xenstore/Makefile.common index ddbac052ac..b18f95c103 100644 --- a/tools/xenstore/Makefile.common +++ b/tools/xenstore/Makefile.common @@ -16,7 +16,6 @@ CFLAGS += $(CFLAGS_libxenevtchn) CFLAGS += $(CFLAGS_libxenctrl) CFLAGS += $(CFLAGS_libxenguest) CFLAGS += $(CFLAGS_libxentoolcore) -CFLAGS += -DXEN_LIB_STORED="\"$(XEN_LIB_STORED)\"" CFLAGS += -DXEN_RUN_STORED="\"$(XEN_RUN_STORED)\"" ifdef CONFIG_STUBDOM diff --git a/tools/xenstore/xs_lib.c b/tools/xenstore/xs_lib.c index 10fa4c3ad0..b9941c567c 100644 --- a/tools/xenstore/xs_lib.c +++ b/tools/xenstore/xs_lib.c @@ -26,18 +26,17 @@ /* Common routines for the Xen store daemon and client library. */ -const char *xs_daemon_rootdir(void) -{ - char *s = getenv("XENSTORED_ROOTDIR"); - return (s ? s : XEN_LIB_STORED); -} - const char *xs_daemon_rundir(void) { char *s = getenv("XENSTORED_RUNDIR"); return (s ? s : XEN_RUN_STORED); } +const char *xs_daemon_rootdir(void) +{ + return xs_daemon_rundir(); +} + static const char *xs_daemon_path(void) { static char buf[PATH_MAX]; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:28:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:28:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434828.687446 (Exim 4.92) (envelope-from ) id 1optC6-0007Cg-UC; Tue, 01 Nov 2022 15:28:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434828.687446; Tue, 01 Nov 2022 15:28:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optC6-0007CS-OP; Tue, 01 Nov 2022 15:28:50 +0000 Received: by outflank-mailman (input) for mailman id 434828; Tue, 01 Nov 2022 15:28:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optC5-0007Bd-I5 for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:28:49 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e05594c4-59f9-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 16:28:46 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 314A31F8CA; Tue, 1 Nov 2022 15:28:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D2E571346F; Tue, 1 Nov 2022 15:28:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ThsDMi07YWN1YAAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:28:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e05594c4-59f9-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=c13kZx4t7oIwcvFXUwofop8wzkLiv8F8bFXwr4LDykE=; b=ZwU7LG4N0W8RZv4f67SQM9jYKLhE6wUiUdYJNo1l6uJz8lCATPDnBn5YASf2sVPZqd4ows 9+AFckU0uZiQUXRSYHJ9lOd7Gt9RYY7sTa/y/ewUfPtEkFpK8FnZkHTm1gVGqGONe1vRsV /KSRxSneA+NV9vhd73BdUjFrzRdTVGQ= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD , Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini Subject: [PATCH 00/20] tools/xenstore: do some cleanup and fixes Date: Tue, 1 Nov 2022 16:28:22 +0100 Message-Id: <20221101152842.4257-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is a first run of post-XSA patches which piled up during the development phase of all the recent Xenstore related XSA patches. At least the first 7 patches are completely independent from each other. After those the dependencies are starting to be more complex. This is a mixture of small fixes, enhancements and cleanups. Patch 2 was initially part of the XSA patches, which is the reason for having a "Reviewed-by:" tag already. Even with fixing a previous commit it is not urgent to put this patch in, so I don't think this is 4.17 material. Juergen Gross (20): tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR tools/xenstore: call remove_domid_from_perm() for special nodes tools/xenstore: let talloc_free() preserve errno tools/xenstore: let tdb_logger() preserve errno tools/xenstore: preserve errno across corrupt() tools/xenstore: remove all watches when a domain has stopped tools/xenstore: enhance hashtable implementation tools/xenstore: add hashlist for finding struct domain by domid tools/xenstore: introduce dummy nodes for special watch paths tools/xenstore: replace watch->relative_path with a prefix length tools/xenstore: move changed domain handling tools/xenstore: change per-domain node accounting interface tools/xenstore: don't allow creating too many nodes in a transaction tools/xenstore: replace literal domid 0 with dom0_domid tools/xenstore: make domain_is_unprivileged() an inline function tools/xenstore: let chk_domain_generation() return a bool tools/xenstore: switch hashtable to use the talloc framework tools/xenstore: make log macro globally available tools/xenstore: introduce trace classes tools/xenstore: let check_store() check the accounting data config/Paths.mk.in | 1 - configure | 4 - docs/configure | 4 - docs/misc/xenstore.txt | 18 +- m4/paths.m4 | 3 - tools/configure | 7 +- tools/configure.ac | 1 - tools/hotplug/FreeBSD/rc.d/xencommons.in | 6 - tools/hotplug/Linux/systemd/Makefile | 1 - .../Linux/systemd/var-lib-xenstored.mount.in | 12 - tools/libs/store/Makefile | 1 - tools/xenstore/.gdbinit | 4 - tools/xenstore/Makefile | 4 - tools/xenstore/Makefile.common | 1 - tools/xenstore/hashtable.c | 134 ++-- tools/xenstore/hashtable.h | 38 +- tools/xenstore/talloc.c | 25 +- tools/xenstore/xenstored_control.c | 44 +- tools/xenstore/xenstored_core.c | 223 ++++--- tools/xenstore/xenstored_core.h | 31 + tools/xenstore/xenstored_domain.c | 596 ++++++++++-------- tools/xenstore/xenstored_domain.h | 21 +- tools/xenstore/xenstored_transaction.c | 76 +-- tools/xenstore/xenstored_transaction.h | 7 +- tools/xenstore/xenstored_watch.c | 43 +- tools/xenstore/xs_lib.c | 11 +- 26 files changed, 707 insertions(+), 609 deletions(-) delete mode 100644 tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in delete mode 100644 tools/xenstore/.gdbinit -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:29:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:29:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434830.687468 (Exim 4.92) (envelope-from ) id 1optCG-0007ou-G3; Tue, 01 Nov 2022 15:29:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434830.687468; Tue, 01 Nov 2022 15:29:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCG-0007oc-Cs; Tue, 01 Nov 2022 15:29:00 +0000 Received: by outflank-mailman (input) for mailman id 434830; Tue, 01 Nov 2022 15:28:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCE-0007Tl-Fg for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:28:58 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e6ee5cff-59f9-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 16:28:57 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6151F2256A; Tue, 1 Nov 2022 15:28:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 312DD1346F; Tue, 1 Nov 2022 15:28:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ycfICTk7YWOJYAAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:28:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6ee5cff-59f9-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316537; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wnyre0lY6vh0o8N40Ag5noXJoA9j7rscMFp/jnaPIq8=; b=Zn1xF+Ym/ToL4Sea/vmyDRyR+YP9a0QGM/fOrIlRVDmhnWgjY67i9mtfxFj+fd6smJpMfC dB3+Hf2D27zHF24nuIjT/U7cH1kDHYB1SykNnHSFKuvibo1HnoNn504Bdgdo+L9ekqltmu 8A0EqqpmOYtjJ6oRGv3Q+TCaPMIcrUU= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Julien Grall Subject: [PATCH 02/20] tools/xenstore: call remove_domid_from_perm() for special nodes Date: Tue, 1 Nov 2022 16:28:24 +0100 Message-Id: <20221101152842.4257-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When destroying a domain, any stale permissions of the domain must be removed from the special nodes "@...", too. This was not done in the fix for XSA-322. Fixes: 496306324d8d ("tools/xenstore: revoke access rights for removed domains") Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- tools/xenstore/xenstored_domain.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 84b7817cd5..aa86892fed 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -227,6 +227,27 @@ static void unmap_interface(void *interface) xengnttab_unmap(*xgt_handle, interface, 1); } +static void remove_domid_from_perm(struct node_perms *perms, + struct domain *domain) +{ + unsigned int cur, new; + + if (perms->p[0].id == domain->domid) + perms->p[0].id = priv_domid; + + for (cur = new = 1; cur < perms->num; cur++) { + if (perms->p[cur].id == domain->domid) + continue; + + if (new != cur) + perms->p[new] = perms->p[cur]; + + new++; + } + + perms->num = new; +} + static int domain_tree_remove_sub(const void *ctx, struct connection *conn, struct node *node, void *arg) { @@ -277,6 +298,9 @@ static void domain_tree_remove(struct domain *domain) syslog(LOG_ERR, "error when looking for orphaned nodes\n"); } + + remove_domid_from_perm(&dom_release_perms, domain); + remove_domid_from_perm(&dom_introduce_perms, domain); } static int destroy_domain(void *_domain) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:29:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:29:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434832.687483 (Exim 4.92) (envelope-from ) id 1optCK-00089v-SV; Tue, 01 Nov 2022 15:29:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434832.687483; Tue, 01 Nov 2022 15:29:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCK-00089k-Op; Tue, 01 Nov 2022 15:29:04 +0000 Received: by outflank-mailman (input) for mailman id 434832; Tue, 01 Nov 2022 15:29:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCK-0007Bd-0Q for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:29:04 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ea41e590-59f9-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 16:29:03 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EF674336C7; Tue, 1 Nov 2022 15:29:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C1D391346F; Tue, 1 Nov 2022 15:29:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NKPuLT47YWOWYAAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:29:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea41e590-59f9-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316542; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2WmsoGzujtIkC6YuYigP+4ElT2gZKOfCQSt1d9XlPlQ=; b=cfwPiTtHeymrVNMf5+4iT9g56NXixGH35F1GILJ1i/A5austDtqWq5FupnFdRKURsnfF3t BfengqzNG3xV8ujPQgjGRVHJOYHjpzHn/NzFk5RAIX36oOde+glQbL8vMPZ0sG3lsVktGE Ck+ub/XCeVK18+c+sK1oIWKS7fo8qtE= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 03/20] tools/xenstore: let talloc_free() preserve errno Date: Tue, 1 Nov 2022 16:28:25 +0100 Message-Id: <20221101152842.4257-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today talloc_free() is not guaranteed to preserve errno, especially in case a custom destructor is being used. Change that by renaming talloc_free() to _talloc_free() in talloc.c and adding a wrapper to talloc.c. This allows to remove some errno saving outside of talloc.c. Signed-off-by: Juergen Gross --- tools/xenstore/talloc.c | 25 ++++++++++++++++++------- tools/xenstore/xenstored_core.c | 2 -- 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/tools/xenstore/talloc.c b/tools/xenstore/talloc.c index d7edcf3a93..5fbefdf091 100644 --- a/tools/xenstore/talloc.c +++ b/tools/xenstore/talloc.c @@ -103,6 +103,8 @@ struct talloc_chunk { unsigned flags; }; +static int _talloc_free(void *ptr); + /* 16 byte alignment seems to keep everyone happy */ #define TC_HDR_SIZE ((sizeof(struct talloc_chunk)+15)&~15) #define TC_PTR_FROM_CHUNK(tc) ((void *)(TC_HDR_SIZE + (char*)tc)) @@ -245,7 +247,7 @@ static int talloc_reference_destructor(void *ptr) tc1->destructor = NULL; } _TLIST_REMOVE(tc2->refs, handle); - talloc_free(handle); + _talloc_free(handle); return 0; } @@ -311,7 +313,7 @@ static int talloc_unreference(const void *context, const void *ptr) talloc_set_destructor(h, NULL); _TLIST_REMOVE(tc->refs, h); - talloc_free(h); + _talloc_free(h); return 0; } @@ -349,7 +351,7 @@ int talloc_unlink(const void *context, void *ptr) tc_p = talloc_chunk_from_ptr(ptr); if (tc_p->refs == NULL) { - return talloc_free(ptr); + return _talloc_free(ptr); } new_p = talloc_parent_chunk(tc_p->refs); @@ -521,7 +523,7 @@ static void talloc_free_children(void *ptr) struct talloc_chunk *p = talloc_parent_chunk(tc->child->refs); if (p) new_parent = TC_PTR_FROM_CHUNK(p); } - if (talloc_free(child) == -1) { + if (_talloc_free(child) == -1) { if (new_parent == null_context) { struct talloc_chunk *p = talloc_parent_chunk(ptr); if (p) new_parent = TC_PTR_FROM_CHUNK(p); @@ -539,7 +541,7 @@ static void talloc_free_children(void *ptr) will not be freed if the ref_count is > 1 or the destructor (if any) returns non-zero */ -int talloc_free(void *ptr) +static int _talloc_free(void *ptr) { struct talloc_chunk *tc; @@ -597,7 +599,16 @@ int talloc_free(void *ptr) return 0; } +int talloc_free(void *ptr) +{ + int ret; + int saved_errno = errno; + ret = _talloc_free(ptr); + errno = saved_errno; + + return ret; +} /* A talloc version of realloc. The context argument is only used if @@ -610,7 +621,7 @@ void *_talloc_realloc(const void *context, void *ptr, size_t size, const char *n /* size zero is equivalent to free() */ if (size == 0) { - talloc_free(ptr); + _talloc_free(ptr); return NULL; } @@ -1243,7 +1254,7 @@ void *talloc_realloc_fn(const void *context, void *ptr, size_t size) static void talloc_autofree(void) { - talloc_free(cleanup_context); + _talloc_free(cleanup_context); cleanup_context = NULL; } diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 476d5c6d51..5a174b9881 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -771,9 +771,7 @@ struct node *read_node(struct connection *conn, const void *ctx, return node; error: - err = errno; talloc_free(node); - errno = err; return NULL; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:29:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:29:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434833.687494 (Exim 4.92) (envelope-from ) id 1optCR-00009J-4F; Tue, 01 Nov 2022 15:29:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434833.687494; Tue, 01 Nov 2022 15:29:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCR-000094-0j; Tue, 01 Nov 2022 15:29:11 +0000 Received: by outflank-mailman (input) for mailman id 434833; Tue, 01 Nov 2022 15:29:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCP-0007Tl-DS for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:29:09 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed91d5d7-59f9-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 16:29:08 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 818151F8E3; Tue, 1 Nov 2022 15:29:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 58D0B1346F; Tue, 1 Nov 2022 15:29:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IcyBFEQ7YWOlYAAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:29:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed91d5d7-59f9-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316548; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kI1Emp5xZULnpO1cGT8dYHVyoLvYXhzW8MdJFPz/OVo=; b=f+5YMk/mhCQx9Q20fUu9M/tLuSwPFGVsS8ZSkbQN1Wh2FhBWbY6fnFKbCVLOJfd6Ux6rCG 0URdb6sg6n09kSXpJK2vBV3QLHAjaUquslVDFAaSI2pKnyJ4TnxV9/QOuoG0OhS5dgzw8d NNt0R2+HG5nVWdCQ6NSIF/DT3Daft60= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 04/20] tools/xenstore: let tdb_logger() preserve errno Date: Tue, 1 Nov 2022 16:28:26 +0100 Message-Id: <20221101152842.4257-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit tdb_logger() is called by TDB for logging errors. As errno is checked often after doing the logging, tdb_logger() should preserve errno. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 5a174b9881..d48208ecfe 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2345,6 +2345,7 @@ static void tdb_logger(TDB_CONTEXT *tdb, int level, const char * fmt, ...) { va_list ap; char *s; + int saved_errno = errno; va_start(ap, fmt); s = talloc_vasprintf(NULL, fmt, ap); @@ -2360,6 +2361,8 @@ static void tdb_logger(TDB_CONTEXT *tdb, int level, const char * fmt, ...) trace("talloc failure during logging\n"); syslog(LOG_ERR, "talloc failure during logging\n"); } + + errno = saved_errno; } void setup_structure(bool live_update) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:29:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:29:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434835.687509 (Exim 4.92) (envelope-from ) id 1optCW-0000gp-F3; Tue, 01 Nov 2022 15:29:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434835.687509; Tue, 01 Nov 2022 15:29:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCW-0000ge-AL; Tue, 01 Nov 2022 15:29:16 +0000 Received: by outflank-mailman (input) for mailman id 434835; Tue, 01 Nov 2022 15:29:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCU-0007Tl-Ul for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:29:14 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f0e9d469-59f9-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 16:29:14 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 238181F8E3; Tue, 1 Nov 2022 15:29:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E1FD41346F; Tue, 1 Nov 2022 15:29:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6NvLNUk7YWOuYAAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:29:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0e9d469-59f9-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316554; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SuvESnVvB2BaByGaIJAGNczPYSTrohyV2ePtAUTn3Zo=; b=r5QuV7JC7wkD4s9mWUzioVvFGyOcQt6tK54cHnqZqJUEHkisMCSL2jMJCVwEf78RCBDYGI 57TyhVRZRE66CLy+U/cvO3/oR1WCLifZj34+TYcXP2GX2Lha7Y+wyW8SeDivHuo4jVimj9 mKKVe5DrQ9JKXAgd6WGdcGBdQxLYrn4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 05/20] tools/xenstore: preserve errno across corrupt() Date: Tue, 1 Nov 2022 16:28:27 +0100 Message-Id: <20221101152842.4257-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Let corrupt() preserve errno in order to be able to simplify error handling in future. This is rather easy as the errno value when entering corrupt() is saved already. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index d48208ecfe..8c2cca62b7 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2549,6 +2549,8 @@ void corrupt(struct connection *conn, const char *fmt, ...) talloc_free(str); check_store(); + + errno = saved_errno; } #ifndef NO_SOCKETS -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:29:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:29:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434842.687524 (Exim 4.92) (envelope-from ) id 1optCc-0001RH-47; Tue, 01 Nov 2022 15:29:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434842.687524; Tue, 01 Nov 2022 15:29:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCb-0001Qc-TB; Tue, 01 Nov 2022 15:29:21 +0000 Received: by outflank-mailman (input) for mailman id 434842; Tue, 01 Nov 2022 15:29:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCb-0007Tl-AO for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:29:21 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f43d8c1a-59f9-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 16:29:19 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B133F1F8E3; Tue, 1 Nov 2022 15:29:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 849211346F; Tue, 1 Nov 2022 15:29:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4R78Hk87YWO+YAAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:29:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f43d8c1a-59f9-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316559; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EBpnpvtRtx53neoNfKJ9kBe5E0CVVtJQnxw6pFlViTQ=; b=Ryg26mb5pXdhw1khCYn7z4/27NjZGgmswuPON1qOxmwXcRX/BRryG4vFYnp8VE2FNaCGn3 SBN2aXbQQJFrICf0GUkGjL6TijOAETGDR8pxGd0auGbXfC/AQyX1s1I+PZsF2105saUIlK D0sEVKe4jiVvjo2y2GpJ9Xl2CicbWXQ= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 06/20] tools/xenstore: remove all watches when a domain has stopped Date: Tue, 1 Nov 2022 16:28:28 +0100 Message-Id: <20221101152842.4257-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When a domain has been recognized to have stopped, remove all its registered watches. This avoids sending watch events to the dead domain when all the nodes related to it are being removed by the Xen tools. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_domain.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index aa86892fed..1516df71d8 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -364,6 +364,12 @@ void check_domains(void) && !domain->shutdown) { domain->shutdown = true; notify = 1; + /* + * Avoid triggering watch events when the + * domain's nodes are being deleted. + */ + if (domain->conn) + conn_delete_all_watches(domain->conn); } if (!dominfo.dying) continue; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:29:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:29:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434849.687539 (Exim 4.92) (envelope-from ) id 1optCo-0002Jd-EK; Tue, 01 Nov 2022 15:29:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434849.687539; Tue, 01 Nov 2022 15:29:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCo-0002JW-92; Tue, 01 Nov 2022 15:29:34 +0000 Received: by outflank-mailman (input) for mailman id 434849; Tue, 01 Nov 2022 15:29:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCn-0007Bd-BZ for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:29:33 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fae2c300-59f9-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 16:29:31 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D4FF8336C7; Tue, 1 Nov 2022 15:29:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AD8681346F; Tue, 1 Nov 2022 15:29:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nbMkKVo7YWPbYAAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:29:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fae2c300-59f9-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=anDpkDCTkclPSUMBJP+Mdb2oOV35Mkg0KiisY71X+Fk=; b=MFWcpC6+nbBGxiQJabTdKQpyqv5tBenYSnNEdeSD2WFCL4wO3ERGddNQ7FSV6FA+HxACkq YPzH+jn7bvlLLTm7LPlFjJ2Is6WlMjh3TKFH4kE71KCXFW2kZlIlgaBhz2CQe6LLw/lU5o YFtHuf4AdYzy7I/+T9xSq45ZLZixcvw= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 08/20] tools/xenstore: add hashlist for finding struct domain by domid Date: Tue, 1 Nov 2022 16:28:30 +0100 Message-Id: <20221101152842.4257-9-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today finding a struct domain by its domain id requires to scan the list of domains until finding the correct domid. Add a hashlist for being able to speed this up. This allows to remove the linking of struct domain in a list. Note that the list of changed domains per transaction is kept as a list, as there are no known use cases with more than 4 domains being touched in a single transaction (this would be a device handled by a driver domain and being assigned to a HVM domain with device model in a stubdom, plus the control domain). Some simple performance tests comparing the scanning and hashlist have shown that the hashlist will win as soon as more than 6 entries need to be scanned. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_domain.c | 112 +++++++++++++++++------------- 1 file changed, 65 insertions(+), 47 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 1516df71d8..f6797e53c5 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -48,8 +48,6 @@ static struct node_perms dom_introduce_perms; struct domain { - struct list_head list; - /* The id of this domain */ unsigned int domid; @@ -96,7 +94,7 @@ struct domain bool wrl_delay_logged; }; -static LIST_HEAD(domains); +static struct hashtable *domhash; static bool check_indexes(XENSTORE_RING_IDX cons, XENSTORE_RING_IDX prod) { @@ -309,7 +307,7 @@ static int destroy_domain(void *_domain) domain_tree_remove(domain); - list_del(&domain->list); + hashtable_remove(domhash, &domain->domid); if (!domain->introduced) return 0; @@ -341,49 +339,56 @@ static bool get_domain_info(unsigned int domid, xc_dominfo_t *dominfo) dominfo->domid == domid; } -void check_domains(void) +static int check_domain(void *k, void *v, void *arg) { xc_dominfo_t dominfo; - struct domain *domain; struct connection *conn; - int notify = 0; bool dom_valid; + struct domain *domain = v; + bool *notify = arg; - again: - list_for_each_entry(domain, &domains, list) { - dom_valid = get_domain_info(domain->domid, &dominfo); - if (!domain->introduced) { - if (!dom_valid) { - talloc_free(domain); - goto again; - } - continue; - } - if (dom_valid) { - if ((dominfo.crashed || dominfo.shutdown) - && !domain->shutdown) { - domain->shutdown = true; - notify = 1; - /* - * Avoid triggering watch events when the - * domain's nodes are being deleted. - */ - if (domain->conn) - conn_delete_all_watches(domain->conn); - } - if (!dominfo.dying) - continue; + dom_valid = get_domain_info(domain->domid, &dominfo); + if (!domain->introduced) { + if (!dom_valid) { + talloc_free(domain); + return 1; } - if (domain->conn) { - /* domain is a talloc child of domain->conn. */ - conn = domain->conn; - domain->conn = NULL; - talloc_unlink(talloc_autofree_context(), conn); - notify = 0; /* destroy_domain() fires the watch */ - goto again; + return 0; + } + if (dom_valid) { + if ((dominfo.crashed || dominfo.shutdown) + && !domain->shutdown) { + domain->shutdown = true; + *notify = true; + /* + * Avoid triggering watch events when the domain's + * nodes are being deleted. + */ + if (domain->conn) + conn_delete_all_watches(domain->conn); } + if (!dominfo.dying) + return 0; + } + if (domain->conn) { + /* domain is a talloc child of domain->conn. */ + conn = domain->conn; + domain->conn = NULL; + talloc_unlink(talloc_autofree_context(), conn); + *notify = false; /* destroy_domain() fires the watch */ + return 1; } + return 0; +} + +void check_domains(void) +{ + bool notify = false; + + while (hashtable_iterate(domhash, check_domain, ¬ify)) + ; + if (notify) fire_watches(NULL, NULL, "@releaseDomain", NULL, true, NULL); } @@ -421,13 +426,7 @@ static char *talloc_domain_path(const void *context, unsigned int domid) static struct domain *find_domain_struct(unsigned int domid) { - struct domain *i; - - list_for_each_entry(i, &domains, list) { - if (i->domid == domid) - return i; - } - return NULL; + return hashtable_search(domhash, &domid); } int domain_get_quota(const void *ctx, struct connection *conn, @@ -476,9 +475,13 @@ static struct domain *alloc_domain(const void *context, unsigned int domid) domain->generation = generation; domain->introduced = false; - talloc_set_destructor(domain, destroy_domain); + if (!hashtable_insert(domhash, &domain->domid, domain)) { + talloc_free(domain); + errno = ENOMEM; + return NULL; + } - list_add(&domain->list, &domains); + talloc_set_destructor(domain, destroy_domain); return domain; } @@ -909,10 +912,25 @@ void dom0_init(void) xenevtchn_notify(xce_handle, dom0->port); } +static unsigned int domhash_fn(void *k) +{ + return *(unsigned int *)k; +} + +static int domeq_fn(void *key1, void *key2) +{ + return *(unsigned int *)key1 == *(unsigned int *)key2; +} + void domain_init(int evtfd) { int rc; + /* Start with a random rather low domain count for the hashtable. */ + domhash = create_hashtable(8, domhash_fn, domeq_fn, 0); + if (!domhash) + barf_perror("Failed to allocate domain hashtable"); + xc_handle = talloc(talloc_autofree_context(), xc_interface*); if (!xc_handle) barf_perror("Failed to allocate domain handle"); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:35:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:35:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434893.687682 (Exim 4.92) (envelope-from ) id 1optIB-00061c-SF; Tue, 01 Nov 2022 15:35:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434893.687682; Tue, 01 Nov 2022 15:35:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optIB-00061S-PN; Tue, 01 Nov 2022 15:35:07 +0000 Received: by outflank-mailman (input) for mailman id 434893; Tue, 01 Nov 2022 15:35:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optDJ-0007Bd-Od for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:30:05 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0ece2237-59fa-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 16:30:04 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 48C743385D; Tue, 1 Nov 2022 15:30:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1A3B71346F; Tue, 1 Nov 2022 15:30:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id xksRBXw7YWNGYQAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:30:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ece2237-59fa-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OXW2q3TSE2sqfE+CLKAdRKeOGAyBZRR57o9SMNJeWXg=; b=pc2W4hcBKUl9aOOF72kOOB4n9AKlmfC1e8IkhndZQOTiqKbPKFuijJs0z9Y6+sW1T08mzB OKo2cL5KltYgbWsalH1cehr4oR+QcU0I/IYnvH/9LdCL4MNVlfMNOXndZ/HgL9uIsu9yWv SMShbQdmKerTHLJN4putmEXddYa3JQI= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 14/20] tools/xenstore: replace literal domid 0 with dom0_domid Date: Tue, 1 Nov 2022 16:28:36 +0100 Message-Id: <20221101152842.4257-15-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are some places left where dom0 is associated with domid 0. Use dom0_domid instead. Signed-off-by: Juergen Gross --- V2: - new patch --- tools/xenstore/xenstored_core.c | 5 +++-- tools/xenstore/xenstored_domain.c | 8 ++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 5fd4f8e606..5013f8b909 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2302,9 +2302,10 @@ static void accept_connection(int sock) return; conn = new_connection(&socket_funcs); - if (conn) + if (conn) { conn->fd = fd; - else + conn->id = dom0_domid; + } else close(fd); } #endif diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 529ffb522a..0f1c903ee6 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -324,7 +324,7 @@ static int destroy_domain(void *_domain) if (domain->interface) { /* Domain 0 was mapped by dom0_init, so it must be unmapped using munmap() and not the grant unmap call. */ - if (domain->domid == 0) + if (domain->domid == dom0_domid) unmap_xenbus(domain->interface); else unmap_interface(domain->interface); @@ -414,7 +414,7 @@ void handle_event(void) static bool domid_is_unprivileged(unsigned int domid) { - return domid != 0 && domid != priv_domid; + return domid != dom0_domid && domid != priv_domid; } bool domain_is_unprivileged(struct connection *conn) @@ -806,7 +806,7 @@ static struct domain *onearg_domain(struct connection *conn, return ERR_PTR(-EINVAL); domid = atoi(domid_str); - if (!domid) + if (domid == dom0_domid) return ERR_PTR(-EINVAL); return find_connected_domain(domid); @@ -1009,7 +1009,7 @@ static int chk_domain_generation(unsigned int domid, uint64_t gen) { struct domain *d; - if (!xc_handle && domid == 0) + if (!xc_handle && domid == dom0_domid) return 1; d = find_domain_struct(domid); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:37:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:37:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434916.687750 (Exim 4.92) (envelope-from ) id 1optKN-0007Ll-9T; Tue, 01 Nov 2022 15:37:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434916.687750; Tue, 01 Nov 2022 15:37:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optKN-0007Kc-4w; Tue, 01 Nov 2022 15:37:23 +0000 Received: by outflank-mailman (input) for mailman id 434916; Tue, 01 Nov 2022 15:37:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optD8-0007Tl-Gs for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:29:54 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0829b728-59fa-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 16:29:53 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 233BA3385D; Tue, 1 Nov 2022 15:29:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EA98E1346F; Tue, 1 Nov 2022 15:29:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id McwcOHA7YWMIYQAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:29:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0829b728-59fa-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316593; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6cO3bOwodibHGnM88vggzXd4Fv7IsN58rIy1QvyWOFY=; b=rBc42uxY2f851cPpNm3gakPKlOQ4MiD3BFBidWinnPFaun+bkqxw8u+DqJ9hwPXuaVh3nA dM7ijcgocM0A3yC5ll/Mi2Bn7kKfd/tMHyBRRLLMqKX4Rr+q/OayYhkQsz4cLt3NNm1MC/ xB4+CFgxem0/t552v7QmYeoPzzzfO4g= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 12/20] tools/xenstore: change per-domain node accounting interface Date: Tue, 1 Nov 2022 16:28:34 +0100 Message-Id: <20221101152842.4257-13-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rework the interface and the internals of the per-domain node accounting: - rename the functions to domain_nbentry_*() in order to better match the related counter name - switch from node pointer to domid as interface, as all nodes have the owner filled in - use a common internal function for adding a value to the counter For the transaction case add a helper function to get the list head of the per-transaction changed domains, enabling to eliminate the transaction_entry_*() functions. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 22 ++--- tools/xenstore/xenstored_domain.c | 122 +++++++++++-------------- tools/xenstore/xenstored_domain.h | 10 +- tools/xenstore/xenstored_transaction.c | 15 +-- tools/xenstore/xenstored_transaction.h | 7 +- 5 files changed, 72 insertions(+), 104 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index cadb339486..5fd4f8e606 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -1449,7 +1449,7 @@ static void destroy_node_rm(struct connection *conn, struct node *node) static int destroy_node(struct connection *conn, struct node *node) { destroy_node_rm(conn, node); - domain_entry_dec(conn, node); + domain_nbentry_dec(conn, node->perms.p[0].id); /* * It is not possible to easily revert the changes in a transaction. @@ -1488,7 +1488,7 @@ static struct node *create_node(struct connection *conn, const void *ctx, for (i = node; i; i = i->parent) { /* i->parent is set for each new node, so check quota. */ if (i->parent && - domain_entry(conn) >= quota_nb_entry_per_domain) { + domain_nbentry(conn) >= quota_nb_entry_per_domain) { ret = ENOSPC; goto err; } @@ -1499,7 +1499,7 @@ static struct node *create_node(struct connection *conn, const void *ctx, /* Account for new node */ if (i->parent) { - if (domain_entry_inc(conn, i)) { + if (domain_nbentry_inc(conn, i->perms.p[0].id)) { destroy_node_rm(conn, i); return NULL; } @@ -1652,7 +1652,7 @@ static int delnode_sub(const void *ctx, struct connection *conn, watch_exact = strcmp(root, node->name); fire_watches(conn, ctx, node->name, node, watch_exact, NULL); - domain_entry_dec(conn, node); + domain_nbentry_dec(conn, node->perms.p[0].id); return WALK_TREE_RM_CHILDENTRY; } @@ -1793,25 +1793,25 @@ static int do_set_perms(const void *ctx, struct connection *conn, return EPERM; old_perms = node->perms; - domain_entry_dec(conn, node); + domain_nbentry_dec(conn, node->perms.p[0].id); node->perms = perms; - if (domain_entry_inc(conn, node)) { + if (domain_nbentry_inc(conn, node->perms.p[0].id)) { node->perms = old_perms; /* * This should never fail because we had a reference on the * domain before and Xenstored is single-threaded. */ - domain_entry_inc(conn, node); + domain_nbentry_inc(conn, node->perms.p[0].id); return ENOMEM; } if (write_node(conn, node, false)) { int saved_errno = errno; - domain_entry_dec(conn, node); + domain_nbentry_dec(conn, node->perms.p[0].id); node->perms = old_perms; /* No failure possible as above. */ - domain_entry_inc(conn, node); + domain_nbentry_inc(conn, node->perms.p[0].id); errno = saved_errno; return errno; @@ -2383,7 +2383,7 @@ void setup_structure(bool live_update) manual_node("/tool/xenstored", NULL); manual_node("@releaseDomain", NULL); manual_node("@introduceDomain", NULL); - domain_entry_fix(dom0_domid, 5, true); + domain_nbentry_fix(dom0_domid, 5, true); } check_store(); @@ -3391,7 +3391,7 @@ void read_state_node(const void *ctx, const void *state) if (write_node_raw(NULL, &key, node, true)) barf("write node error restoring node"); - if (domain_entry_inc(&conn, node)) + if (domain_nbentry_inc(&conn, node->perms.p[0].id)) barf("node accounting error restoring node"); talloc_free(node); diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 14fd84c288..b737a77683 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -249,7 +249,7 @@ static int domain_tree_remove_sub(const void *ctx, struct connection *conn, domain->nbentry--; node->perms.p[0].id = priv_domid; node->acc.memory = 0; - domain_entry_inc(NULL, node); + domain_nbentry_inc(NULL, priv_domid); if (write_node_raw(NULL, &key, node, true)) { /* That's unfortunate. We only can try to continue. */ syslog(LOG_ERR, @@ -569,7 +569,7 @@ int acc_fix_domains(struct list_head *head, bool update) int cnt; list_for_each_entry(cd, head, list) { - cnt = domain_entry_fix(cd->domid, cd->nbentry, update); + cnt = domain_nbentry_fix(cd->domid, cd->nbentry, update); if (!update) { if (cnt >= quota_nb_entry_per_domain) return ENOSPC; @@ -614,18 +614,19 @@ static struct changed_domain *acc_get_changed_domain(const void *ctx, return cd; } -int acc_add_dom_nbentry(const void *ctx, struct list_head *head, int val, - unsigned int domid) +static int acc_add_dom_nbentry(const void *ctx, struct list_head *head, int val, + unsigned int domid) { struct changed_domain *cd; cd = acc_get_changed_domain(ctx, head, domid); if (!cd) - return errno; + return 0; + errno = 0; cd->nbentry += val; - return 0; + return cd->nbentry; } static void domain_conn_reset(struct domain *domain) @@ -995,30 +996,6 @@ void domain_deinit(void) xenevtchn_unbind(xce_handle, virq_port); } -int domain_entry_inc(struct connection *conn, struct node *node) -{ - struct domain *d; - unsigned int domid; - - if (!node->perms.p) - return 0; - - domid = node->perms.p[0].id; - - if (conn && conn->transaction) { - transaction_entry_inc(conn->transaction, domid); - } else { - d = (conn && domid == conn->id && conn->domain) ? conn->domain - : find_or_alloc_existing_domain(domid); - if (d) - d->nbentry++; - else - return ENOMEM; - } - - return 0; -} - /* * Check whether a domain was created before or after a specific generation * count (used for testing whether a node permission is older than a domain). @@ -1086,62 +1063,67 @@ int domain_adjust_node_perms(struct node *node) return 0; } -void domain_entry_dec(struct connection *conn, struct node *node) +static int domain_nbentry_add(struct connection *conn, unsigned int domid, + int add, bool dom_exists) { struct domain *d; - unsigned int domid; - - if (!node->perms.p) - return; + struct list_head *head; + int ret; - domid = node->perms.p ? node->perms.p[0].id : conn->id; + if (conn && domid == conn->id && conn->domain) + d = conn->domain; + else if (dom_exists) { + d = find_domain_struct(domid); + if (!d) { + errno = ENOENT; + corrupt(conn, "Missing domain %u\n", domid); + return -1; + } + } else { + d = find_or_alloc_existing_domain(domid); + if (!d) { + errno = ENOMEM; + return -1; + } + } if (conn && conn->transaction) { - transaction_entry_dec(conn->transaction, domid); - } else { - d = (conn && domid == conn->id && conn->domain) ? conn->domain - : find_domain_struct(domid); - if (d) { - d->nbentry--; - } else { - errno = ENOENT; - corrupt(conn, - "Node \"%s\" owned by non-existing domain %u\n", - node->name, domid); + head = transaction_get_changed_domains(conn->transaction); + ret = acc_add_dom_nbentry(conn->transaction, head, add, domid); + if (errno) { + fail_transaction(conn->transaction); + return -1; } + return d->nbentry + ret; } + + d->nbentry += add; + + return d->nbentry; } -int domain_entry_fix(unsigned int domid, int num, bool update) +int domain_nbentry_inc(struct connection *conn, unsigned int domid) { - struct domain *d; - int cnt; + return (domain_nbentry_add(conn, domid, 1, false) < 0) ? errno : 0; +} - if (update) { - d = find_domain_struct(domid); - assert(d); - } else { - /* - * We are called first with update == false in order to catch - * any error. So do a possible allocation and check for error - * only in this case, as in the case of update == true nothing - * can go wrong anymore as the allocation already happened. - */ - d = find_or_alloc_existing_domain(domid); - if (!d) - return -1; - } +int domain_nbentry_dec(struct connection *conn, unsigned int domid) +{ + return (domain_nbentry_add(conn, domid, -1, true) < 0) ? errno : 0; +} - cnt = d->nbentry + num; - assert(cnt >= 0); +int domain_nbentry_fix(unsigned int domid, int num, bool update) +{ + int ret; - if (update) - d->nbentry = cnt; + ret = domain_nbentry_add(NULL, domid, update ? num : 0, update); + if (ret < 0 || update) + return ret; - return domid_is_unprivileged(domid) ? cnt : 0; + return domid_is_unprivileged(domid) ? ret + num : 0; } -int domain_entry(struct connection *conn) +int domain_nbentry(struct connection *conn) { return (domain_is_unprivileged(conn)) ? conn->domain->nbentry diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 9e20d2b17d..1e402f2609 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -66,10 +66,10 @@ int domain_adjust_node_perms(struct node *node); int domain_alloc_permrefs(struct node_perms *perms); /* Quota manipulation */ -int domain_entry_inc(struct connection *conn, struct node *); -void domain_entry_dec(struct connection *conn, struct node *); -int domain_entry_fix(unsigned int domid, int num, bool update); -int domain_entry(struct connection *conn); +int domain_nbentry_inc(struct connection *conn, unsigned int domid); +int domain_nbentry_dec(struct connection *conn, unsigned int domid); +int domain_nbentry_fix(unsigned int domid, int num, bool update); +int domain_nbentry(struct connection *conn); int domain_memory_add(unsigned int domid, int mem, bool no_quota_check); /* @@ -99,8 +99,6 @@ void domain_outstanding_domid_dec(unsigned int domid); int domain_get_quota(const void *ctx, struct connection *conn, unsigned int domid); int acc_fix_domains(struct list_head *head, bool update); -int acc_add_dom_nbentry(const void *ctx, struct list_head *head, int val, - unsigned int domid); /* Write rate limiting */ diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 89b92f0baf..82e5e66c18 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -548,20 +548,9 @@ int do_transaction_end(const void *ctx, struct connection *conn, return 0; } -void transaction_entry_inc(struct transaction *trans, unsigned int domid) +struct list_head *transaction_get_changed_domains(struct transaction *trans) { - if (acc_add_dom_nbentry(trans, &trans->changed_domains, 1, domid)) { - /* Let the transaction fail. */ - trans->fail = true; - } -} - -void transaction_entry_dec(struct transaction *trans, unsigned int domid) -{ - if (acc_add_dom_nbentry(trans, &trans->changed_domains, -1, domid)) { - /* Let the transaction fail. */ - trans->fail = true; - } + return &trans->changed_domains; } void fail_transaction(struct transaction *trans) diff --git a/tools/xenstore/xenstored_transaction.h b/tools/xenstore/xenstored_transaction.h index 3417303f94..b6f8cb7d0a 100644 --- a/tools/xenstore/xenstored_transaction.h +++ b/tools/xenstore/xenstored_transaction.h @@ -36,10 +36,6 @@ int do_transaction_end(const void *ctx, struct connection *conn, struct transaction *transaction_lookup(struct connection *conn, uint32_t id); -/* inc/dec entry number local to trans while changing a node */ -void transaction_entry_inc(struct transaction *trans, unsigned int domid); -void transaction_entry_dec(struct transaction *trans, unsigned int domid); - /* This node was accessed. */ int __must_check access_node(struct connection *conn, struct node *node, enum node_access_type type, TDB_DATA *key); @@ -54,6 +50,9 @@ void transaction_prepend(struct connection *conn, const char *name, /* Mark the transaction as failed. This will prevent it to be committed. */ void fail_transaction(struct transaction *trans); +/* Get the list head of the changed domains. */ +struct list_head *transaction_get_changed_domains(struct transaction *trans); + void conn_delete_all_transactions(struct connection *conn); int check_transactions(struct hashtable *hash); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:37:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:37:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434913.687745 (Exim 4.92) (envelope-from ) id 1optKN-0007Ii-22; Tue, 01 Nov 2022 15:37:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434913.687745; Tue, 01 Nov 2022 15:37:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optKM-0007Ib-Uv; Tue, 01 Nov 2022 15:37:22 +0000 Received: by outflank-mailman (input) for mailman id 434913; Tue, 01 Nov 2022 15:37:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCy-0007Tl-Nq for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:29:44 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0183a777-59fa-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 16:29:42 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F3FA51F8E3; Tue, 1 Nov 2022 15:29:41 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C7DC61346F; Tue, 1 Nov 2022 15:29:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id W4FOL2U7YWPvYAAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:29:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0183a777-59fa-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316582; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SBeCcFuOhLUEwWwrku8ezHj3ySsRMOxBoKQyjJXO/Rw=; b=GKHnzEtw0Utvfi1KYA0w3j9knflkiyuEPxBNpn2l9n0YccG2EaIzQKsOPnEcyzTgHKs2xI /VfnGYAfcuqBZH3aP7VUxPEthZNYbq4ikvy+v9S829wbxc9iXLJ/sfJ5N3LuPj2952BFvC +LNPV+7SFeCLpynsKx1ITNzbn9F/KMI= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 10/20] tools/xenstore: replace watch->relative_path with a prefix length Date: Tue, 1 Nov 2022 16:28:32 +0100 Message-Id: <20221101152842.4257-11-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of storing a pointer to the path which is prepended to relative paths in struct watch, just use the length of the prepended path. It should be noted that the now removed special case of the relative path being "" in get_watch_path() can't happen at all. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_watch.c | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index 75748ac109..8bed967c56 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -39,8 +39,8 @@ struct watch /* Current outstanding events applying to this watch. */ struct list_head events; - /* Is this relative to connnection's implicit path? */ - const char *relative_path; + /* Offset into path for skipping prefix (used for relative paths). */ + unsigned int prefix_len; char *token; char *node; @@ -66,15 +66,7 @@ static bool is_child(const char *child, const char *parent) static const char *get_watch_path(const struct watch *watch, const char *name) { - const char *path = name; - - if (watch->relative_path) { - path += strlen(watch->relative_path); - if (*path == '/') /* Could be "" */ - path++; - } - - return path; + return name + watch->prefix_len; } /* @@ -211,10 +203,7 @@ static struct watch *add_watch(struct connection *conn, char *path, char *token, no_quota_check)) goto nomem; - if (relative) - watch->relative_path = get_implicit_path(conn); - else - watch->relative_path = NULL; + watch->prefix_len = relative ? strlen(get_implicit_path(conn)) + 1 : 0; INIT_LIST_HEAD(&watch->events); @@ -316,7 +305,6 @@ const char *dump_state_watches(FILE *fp, struct connection *conn, struct watch *watch; struct xs_state_watch sw; struct xs_state_record_header head; - const char *path; head.type = XS_STATE_TYPE_WATCH; @@ -324,8 +312,7 @@ const char *dump_state_watches(FILE *fp, struct connection *conn, head.length = sizeof(sw); sw.conn_id = conn_id; - path = get_watch_path(watch, watch->node); - sw.path_length = strlen(path) + 1; + sw.path_length = strlen(watch->node + watch->prefix_len) + 1; sw.token_length = strlen(watch->token) + 1; head.length += sw.path_length + sw.token_length; head.length = ROUNDUP(head.length, 3); @@ -334,7 +321,8 @@ const char *dump_state_watches(FILE *fp, struct connection *conn, if (fwrite(&sw, sizeof(sw), 1, fp) != 1) return "Dump watch state error"; - if (fwrite(path, sw.path_length, 1, fp) != 1) + if (fwrite(watch->node + watch->prefix_len, sw.path_length, + 1, fp) != 1) return "Dump watch path error"; if (fwrite(watch->token, sw.token_length, 1, fp) != 1) return "Dump watch token error"; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:43:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:43:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434975.687930 (Exim 4.92) (envelope-from ) id 1optQP-0003Xc-Rz; Tue, 01 Nov 2022 15:43:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434975.687930; Tue, 01 Nov 2022 15:43:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optQP-0003Ts-NB; Tue, 01 Nov 2022 15:43:37 +0000 Received: by outflank-mailman (input) for mailman id 434975; Tue, 01 Nov 2022 15:43:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optDf-0007Tl-FT for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:30:27 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1c1ccdb4-59fa-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 16:30:26 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 955E51F8CA; Tue, 1 Nov 2022 15:30:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5D57F1346F; Tue, 1 Nov 2022 15:30:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id h95oFZI7YWNzYQAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:30:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c1ccdb4-59fa-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316626; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zmqv1jjZI833QBU+Sj0Qlh8Q6xTSbx5Wk7y/ffO7mPc=; b=DQqxx27m1f+pKfkMF7ChunHMN3E8sERsgD7maErBhwwQX+N23pWIH5UC+abafJh0xEMkE1 rVQ9phzVjpds2mp7buNQ0yxBAFSVS6CgWwp9DAUDUfErcov+WzUplR4ZcYKxQ3lq79PGrO 7otG+23o+9ArqnZxWKOEJQeuP1yiabs= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 18/20] tools/xenstore: make log macro globally available Date: Tue, 1 Nov 2022 16:28:40 +0100 Message-Id: <20221101152842.4257-19-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move the definition of the log() macro to xenstored_core.h in order to make it usable from other source files, too. While at it preserve errno from being modified. Signed-off-by: Juergen Gross --- V2: - preserve errno (Julien Grall) --- tools/xenstore/xenstored_core.c | 14 -------------- tools/xenstore/xenstored_core.h | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 9361ee7696..e79d82cbff 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -88,20 +88,6 @@ TDB_CONTEXT *tdb_ctx = NULL; static const char *sockmsg_string(enum xsd_sockmsg_type type); -#define log(...) \ - do { \ - char *s = talloc_asprintf(NULL, __VA_ARGS__); \ - if (s) { \ - trace("%s\n", s); \ - syslog(LOG_ERR, "%s\n", s); \ - talloc_free(s); \ - } else { \ - trace("talloc failure during logging\n"); \ - syslog(LOG_ERR, "talloc failure during logging\n"); \ - } \ - } while (0) - - int quota_nb_entry_per_domain = 1000; int quota_nb_watch_per_domain = 128; int quota_max_entry_size = 2048; /* 2K */ diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 3c4e27d0dd..3b96ecd018 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -267,6 +267,21 @@ void trace(const char *fmt, ...) __attribute__ ((format (printf, 1, 2))); void reopen_log(void); void close_log(void); +#define log(...) \ + do { \ + int _saved_errno = errno; \ + char *s = talloc_asprintf(NULL, __VA_ARGS__); \ + if (s) { \ + trace("%s\n", s); \ + syslog(LOG_ERR, "%s\n", s); \ + talloc_free(s); \ + } else { \ + trace("talloc failure during logging\n"); \ + syslog(LOG_ERR, "talloc failure during logging\n"); \ + } \ + errno = _saved_errno; \ + } while (0) + extern int orig_argc; extern char **orig_argv; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:43:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:43:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434970.687904 (Exim 4.92) (envelope-from ) id 1optQO-0002pO-6b; Tue, 01 Nov 2022 15:43:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434970.687904; Tue, 01 Nov 2022 15:43:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optQO-0002p3-21; Tue, 01 Nov 2022 15:43:36 +0000 Received: by outflank-mailman (input) for mailman id 434970; Tue, 01 Nov 2022 15:43:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optDq-0007Bd-SB for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:30:38 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 22c7567f-59fa-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 16:30:38 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C4FED1F8CA; Tue, 1 Nov 2022 15:30:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9490E1346F; Tue, 1 Nov 2022 15:30:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mFb7Ip07YWONYQAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:30:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22c7567f-59fa-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/+Sd+O8DwggSngPmK/S4X0Rtl1nPCQzxh+jG+tl/sB8=; b=OZi+DTTliQy3mYT5OtMAMeO6qOucSYwr5MUNVeNgg2oypDwI8JKcFeZv2xvHG00kTNxpaI 98EQ5FftHfze3iM/f9hoP/P1J5BgG7+HjCF9IC7c9GsowoAGf+STae0SE9AnLfaV6elaQK N9lYVW8IlIaWMDKzuJQsWeoxfERjHeo= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 20/20] tools/xenstore: let check_store() check the accounting data Date: Tue, 1 Nov 2022 16:28:42 +0100 Message-Id: <20221101152842.4257-21-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today check_store() is only testing the correctness of the node tree. Add verification of the accounting data (number of nodes) and correct the data if it is wrong. Do the initial check_store() call only after Xenstore entries of a live update have been read. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 62 ++++++++++++++++------ tools/xenstore/xenstored_domain.c | 86 +++++++++++++++++++++++++++++++ tools/xenstore/xenstored_domain.h | 4 ++ 3 files changed, 137 insertions(+), 15 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 86ef511ac0..ea0e6292d3 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2375,8 +2375,6 @@ void setup_structure(bool live_update) manual_node("@introduceDomain", NULL); domain_nbentry_fix(dom0_domid, 5, true); } - - check_store(); } static unsigned int hash_from_key_fn(void *k) @@ -2419,20 +2417,28 @@ int remember_string(struct hashtable *hash, const char *str) * As we go, we record each node in the given reachable hashtable. These * entries will be used later in clean_store. */ + +struct check_store_data { + struct hashtable *reachable; + struct hashtable *domains; +}; + static int check_store_step(const void *ctx, struct connection *conn, struct node *node, void *arg) { - struct hashtable *reachable = arg; + struct check_store_data *data = arg; - if (hashtable_search(reachable, (void *)node->name)) { + if (hashtable_search(data->reachable, (void *)node->name)) { log("check_store: '%s' is duplicated!", node->name); return recovery ? WALK_TREE_RM_CHILDENTRY : WALK_TREE_SKIP_CHILDREN; } - if (!remember_string(reachable, node->name)) + if (!remember_string(data->reachable, node->name)) return WALK_TREE_ERROR_STOP; + domain_check_acc_add(node, data->domains); + return WALK_TREE_OK; } @@ -2482,37 +2488,61 @@ static int clean_store_(TDB_CONTEXT *tdb, TDB_DATA key, TDB_DATA val, * Given the list of reachable nodes, iterate over the whole store, and * remove any that were not reached. */ -static void clean_store(struct hashtable *reachable) +static void clean_store(struct check_store_data *data) { - tdb_traverse(tdb_ctx, &clean_store_, reachable); + tdb_traverse(tdb_ctx, &clean_store_, data->reachable); + domain_check_acc(data->domains); } +int check_store_path(const char *name, struct check_store_data *data) +{ + struct node *node; + + node = read_node(NULL, NULL, name); + if (!node) { + log("check_store: error %d reading special node '%s'", errno, + name); + return errno; + } + + return check_store_step(NULL, NULL, node, data); +} void check_store(void) { - struct hashtable *reachable; struct walk_funcs walkfuncs = { .enter = check_store_step, .enoent = check_store_enoent, }; + struct check_store_data data; /* Don't free values (they are all void *1) */ - reachable = create_hashtable(NULL, 16, hash_from_key_fn, keys_equal_fn, - HASHTABLE_FREE_KEY); - if (!reachable) { + data.reachable = create_hashtable(NULL, 16, hash_from_key_fn, + keys_equal_fn, HASHTABLE_FREE_KEY); + if (!data.reachable) { log("check_store: ENOMEM"); return; } + data.domains = domain_check_acc_init(); + if (!data.domains) { + log("check_store: ENOMEM"); + goto out_hash; + } + log("Checking store ..."); - if (walk_node_tree(NULL, NULL, "/", &walkfuncs, reachable)) { + if (walk_node_tree(NULL, NULL, "/", &walkfuncs, &data)) { if (errno == ENOMEM) log("check_store: ENOMEM"); - } else if (!check_transactions(reachable)) - clean_store(reachable); + } else if (!check_store_path("@introduceDomain", &data) && + !check_store_path("@releaseDomain", &data) && + !check_transactions(data.reachable)) + clean_store(&data); log("Checking store complete."); - hashtable_destroy(reachable); + hashtable_destroy(data.domains); + out_hash: + hashtable_destroy(data.reachable); } @@ -2900,6 +2930,8 @@ int main(int argc, char *argv[]) lu_read_state(); #endif + check_store(); + /* Get ready to listen to the tools. */ initialize_fds(&sock_pollfd_idx, &timeout); diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 70d9e9572d..582b78b0ee 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -1569,6 +1569,92 @@ void read_state_connection(const void *ctx, const void *state) read_state_buffered_data(ctx, conn, sc); } +struct domain_acc { + unsigned int domid; + int nodes; +}; + +static int domain_check_acc_init_sub(void *k, void *v, void *arg) +{ + struct hashtable *domains = arg; + struct domain *d = v; + struct domain_acc *dom; + + dom = talloc_zero(NULL, struct domain_acc); + if (!dom) + return -1; + + dom->domid = d->domid; + /* + * Set the initial value to the negative one of the current domain. + * If everything is correct incrementing the value for each node will + * result in dom->nodes being 0 at the end. + */ + dom->nodes = -d->nbentry; + + if (!hashtable_insert(domains, &dom->domid, dom)) { + talloc_free(dom); + return -1; + } + + return 0; +} + +struct hashtable *domain_check_acc_init(void) +{ + struct hashtable *domains; + + domains = create_hashtable(NULL, 8, domhash_fn, domeq_fn, + HASHTABLE_FREE_VALUE); + if (!domains) + return NULL; + + if (hashtable_iterate(domhash, domain_check_acc_init_sub, domains)) { + hashtable_destroy(domains); + return NULL; + } + + return domains; +} + +void domain_check_acc_add(const struct node *node, struct hashtable *domains) +{ + struct domain_acc *dom; + unsigned int domid; + + domid = node->perms.p[0].id; + dom = hashtable_search(domains, &domid); + if (!dom) + log("Node %s owned by unknown domain %u", node->name, domid); + else + dom->nodes++; +} + +static int domain_check_acc_sub(void *k, void *v, void *arg) +{ + struct domain_acc *dom = v; + struct domain *d; + + if (!dom->nodes) + return 0; + + log("Correct accounting data for domain %u: nodes are %d off", + dom->domid, dom->nodes); + + d = find_domain_struct(dom->domid); + if (!d) + return 0; + + d->nbentry += dom->nodes; + + return 0; +} + +void domain_check_acc(struct hashtable *domains) +{ + hashtable_iterate(domains, domain_check_acc_sub, NULL); +} + /* * Local variables: * mode: C diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 22996e2576..dc4660861e 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -129,4 +129,8 @@ const char *dump_state_connections(FILE *fp); void read_state_connection(const void *ctx, const void *state); +struct hashtable *domain_check_acc_init(void); +void domain_check_acc_add(const struct node *node, struct hashtable *domains); +void domain_check_acc(struct hashtable *domains); + #endif /* _XENSTORED_DOMAIN_H */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:43:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:43:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434967.687899 (Exim 4.92) (envelope-from ) id 1optQN-0002mm-UM; Tue, 01 Nov 2022 15:43:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434967.687899; Tue, 01 Nov 2022 15:43:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optQN-0002mf-QQ; Tue, 01 Nov 2022 15:43:35 +0000 Received: by outflank-mailman (input) for mailman id 434967; Tue, 01 Nov 2022 15:43:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optDO-0007Bd-QY for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:30:10 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1221cb66-59fa-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 16:30:10 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D61673385D; Tue, 1 Nov 2022 15:30:09 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A94561346F; Tue, 1 Nov 2022 15:30:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ryH+J4E7YWNRYQAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:30:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1221cb66-59fa-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vs7tzrOYBYmkzYl4ReCdb5HC0Yd5c99GD/sLiCRSObs=; b=JyayYnxYUI0yFc9zniEKm81TdEP1b/ntvCh06rddcmY1ci4r4xDwFisg+YxZctujASetHc KGj17238bpgMoSPs87kJ6y1pbGQ7iSmIuNYw2uXTRJ+hK5CQA9nRZw626TbTd3J88cGR/g HLlAZbTFJSeiacENHkHtB2xy+bRZFJ4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 15/20] tools/xenstore: make domain_is_unprivileged() an inline function Date: Tue, 1 Nov 2022 16:28:37 +0100 Message-Id: <20221101152842.4257-16-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit clang is complaining about a NULL dereference for constructs like: domain_is_unprivileged(conn) ? conn->in : NULL as it can't know that domain_is_unprivileged(conn) will return false if conn is NULL. Fix that by making domain_is_unprivileged() an inline function (and related to that domid_is_unprivileged(), too). In order not having to make struct domain public, use conn->id instead of conn->domain->domid for the test. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.h | 10 ++++++++++ tools/xenstore/xenstored_domain.c | 11 ----------- tools/xenstore/xenstored_domain.h | 2 -- 3 files changed, 10 insertions(+), 13 deletions(-) diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 37006d508d..3c4e27d0dd 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -297,6 +297,16 @@ void unmap_xenbus(void *interface); static inline int xenbus_master_domid(void) { return dom0_domid; } +static inline bool domid_is_unprivileged(unsigned int domid) +{ + return domid != dom0_domid && domid != priv_domid; +} + +static inline bool domain_is_unprivileged(const struct connection *conn) +{ + return conn && domid_is_unprivileged(conn->id); +} + /* Return the event channel used by xenbus. */ evtchn_port_t xenbus_evtchn(void); diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 0f1c903ee6..368b9bc2b7 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -412,17 +412,6 @@ void handle_event(void) barf_perror("Failed to write to event fd"); } -static bool domid_is_unprivileged(unsigned int domid) -{ - return domid != dom0_domid && domid != priv_domid; -} - -bool domain_is_unprivileged(struct connection *conn) -{ - return conn && conn->domain && - domid_is_unprivileged(conn->domain->domid); -} - static char *talloc_domain_path(const void *context, unsigned int domid) { return talloc_asprintf(context, "/local/domain/%u", domid); diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 1e402f2609..22996e2576 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -59,8 +59,6 @@ void ignore_connection(struct connection *conn, unsigned int err); /* Returns the implicit path of a connection (only domains have this) */ const char *get_implicit_path(const struct connection *conn); -bool domain_is_unprivileged(struct connection *conn); - /* Remove node permissions for no longer existing domains. */ int domain_adjust_node_perms(struct node *node); int domain_alloc_permrefs(struct node_perms *perms); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:43:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:43:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434977.687942 (Exim 4.92) (envelope-from ) id 1optQR-0003qz-6P; Tue, 01 Nov 2022 15:43:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434977.687942; Tue, 01 Nov 2022 15:43:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optQR-0003q9-26; Tue, 01 Nov 2022 15:43:39 +0000 Received: by outflank-mailman (input) for mailman id 434977; Tue, 01 Nov 2022 15:43:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optDl-0007Tl-Fd for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:30:33 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1f7647a8-59fa-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 16:30:32 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3749F1F8CA; Tue, 1 Nov 2022 15:30:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E95471346F; Tue, 1 Nov 2022 15:30:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ACOxN5c7YWN8YQAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:30:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f7647a8-59fa-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316632; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jp/wq4hw5G22takTn0GXQsF4DTUlBtleEPwgDpe2N2w=; b=VOH4FDu+f21xeut1KkronhOOj6gpTJwpJrvxdsvQ7VelIq34XFnchQYDzHiiR9tfGBrCKA f7l592e6rFlBB6FdvA+G8+BWV2JeL9CBXeYz7StmdM/p0ZnsXlJ3FT/czpyBL2JOGZ7KXY Du1EhRWa1wCxXgWt5lRNAcMKBDf2bZ4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: [PATCH 19/20] tools/xenstore: introduce trace classes Date: Tue, 1 Nov 2022 16:28:41 +0100 Message-Id: <20221101152842.4257-20-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make the xenstored internal trace configurable by adding classes which can be switched on and off independently from each other. Define the following classes: - obj: Creation and deletion of interesting "objects" (watch, transaction, connection) - io: incoming requests and outgoing responses - wrl: write limiting Per default "obj" and "io" are switched on. Entries written via trace() will always be printed (if tracing is on at all). Rename the misnamed xenstore-control commands "logfile" to "tracefile" and "log" to "trace". Add the capability to control the trace settings via the "trace" command and via a new "--trace-control" command line option. Add a missing trace_create() call for creating a transaction. Signed-off-by: Juergen Gross --- docs/misc/xenstore.txt | 18 +++++++---- tools/xenstore/xenstored_control.c | 41 +++++++++++++++++++----- tools/xenstore/xenstored_core.c | 44 +++++++++++++++++++++++--- tools/xenstore/xenstored_core.h | 6 ++++ tools/xenstore/xenstored_domain.c | 27 ++++++++-------- tools/xenstore/xenstored_transaction.c | 1 + 6 files changed, 105 insertions(+), 32 deletions(-) diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt index 44428ae3a7..9db0385120 100644 --- a/docs/misc/xenstore.txt +++ b/docs/misc/xenstore.txt @@ -409,14 +409,8 @@ CONTROL |[|] error string in case of failure. -s can return "BUSY" in case of an active transaction, a retry of -s can be done in that case. - log|on - turn xenstore logging on - log|off - turn xenstore logging off - logfile| - log to specified file memreport|[] - print memory statistics to logfile (no + print memory statistics to tracefile (no specified) or to specific file print| print to syslog (xenstore runs as daemon) or @@ -432,6 +426,16 @@ CONTROL |[|] the domain quota-soft|[set ] like the "quota" command, but for soft-quota. + trace|[+|-] + without parameters: show possible trace switches + + activates trace entries for , + - deactivates trace entries for + trace|on + turn xenstore tracing on + trace|off + turn xenstore tracing off + tracefile| + trace to specified file help return list of supported commands for CONTROL diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index 41e6992591..0a985a1faa 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -179,9 +179,31 @@ static int do_control_check(const void *ctx, struct connection *conn, return 0; } -static int do_control_log(const void *ctx, struct connection *conn, - char **vec, int num) +static int do_control_trace(const void *ctx, struct connection *conn, + char **vec, int num) { + int ret; + + if (num == 0) { + char *resp = talloc_asprintf(ctx, "Trace switch settings:\n"); + unsigned int idx; + bool on; + + if (!resp) + return ENOMEM; + for (idx = 0; trace_switches[idx]; idx++) { + on = trace_flags & (1u << idx); + resp = talloc_asprintf_append(resp, "%-8s: %s\n", + trace_switches[idx], + on ? "on" : "off"); + if (!resp) + return ENOMEM; + } + + send_reply(conn, XS_CONTROL, resp, strlen(resp) + 1); + return 0; + } + if (num != 1) return EINVAL; @@ -189,8 +211,11 @@ static int do_control_log(const void *ctx, struct connection *conn, reopen_log(); else if (!strcmp(vec[0], "off")) close_log(); - else - return EINVAL; + else { + ret = set_trace_switch(vec[0]); + if (ret) + return ret; + } send_ack(conn, XS_CONTROL); return 0; @@ -318,8 +343,8 @@ static int do_control_memreport(const void *ctx, struct connection *conn, return 0; } #else -static int do_control_logfile(const void *ctx, struct connection *conn, - char **vec, int num) +static int do_control_tracefile(const void *ctx, struct connection *conn, + char **vec, int num) { if (num != 1) return EINVAL; @@ -923,7 +948,7 @@ static int do_control_help(const void *, struct connection *, char **, int); static struct cmd_s cmds[] = { { "check", do_control_check, "" }, - { "log", do_control_log, "on|off" }, + { "trace", do_control_trace, "[on|off|[!]]" }, #ifndef NO_LIVE_UPDATE /* @@ -949,7 +974,7 @@ static struct cmd_s cmds[] = { #ifdef __MINIOS__ { "memreport", do_control_memreport, "" }, #else - { "logfile", do_control_logfile, "" }, + { "tracefile", do_control_tracefile, "" }, { "memreport", do_control_memreport, "[]" }, #endif { "print", do_control_print, "" }, diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index e79d82cbff..86ef511ac0 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -85,6 +85,7 @@ static int reopen_log_pipe[2]; static int reopen_log_pipe0_pollfd_idx = -1; char *tracefile = NULL; TDB_CONTEXT *tdb_ctx = NULL; +unsigned int trace_flags = TRACE_OBJ | TRACE_IO; static const char *sockmsg_string(enum xsd_sockmsg_type type); @@ -139,13 +140,13 @@ static void trace_io(const struct connection *conn, time_t now; struct tm *tm; - if (tracefd < 0) + if (tracefd < 0 || !(trace_flags & TRACE_IO)) return; now = time(NULL); tm = localtime(&now); - trace("%s %p %04d%02d%02d %02d:%02d:%02d %s (", + trace("io: %s %p %04d%02d%02d %02d:%02d:%02d %s (", out ? "OUT" : "IN", conn, tm->tm_year + 1900, tm->tm_mon + 1, tm->tm_mday, tm->tm_hour, tm->tm_min, tm->tm_sec, @@ -158,12 +159,14 @@ static void trace_io(const struct connection *conn, void trace_create(const void *data, const char *type) { - trace("CREATE %s %p\n", type, data); + if (trace_flags & TRACE_OBJ) + trace("obj: CREATE %s %p\n", type, data); } void trace_destroy(const void *data, const char *type) { - trace("DESTROY %s %p\n", type, data); + if (trace_flags & TRACE_OBJ) + trace("obj: DESTROY %s %p\n", type, data); } /** @@ -2590,6 +2593,8 @@ static void usage(void) " -N, --no-fork to request that the daemon does not fork,\n" " -P, --output-pid to request that the pid of the daemon is output,\n" " -T, --trace-file giving the file for logging, and\n" +" --trace-control [!] activate (no \"!\" prepended) or deactivate\n" +" a specific \n" " -E, --entry-nb limit the number of entries per domain,\n" " -S, --entry-size limit the size of entry per domain, and\n" " -W, --watch-nb limit the number of watches per domain,\n" @@ -2633,6 +2638,7 @@ static struct option options[] = { { "output-pid", 0, NULL, 'P' }, { "entry-size", 1, NULL, 'S' }, { "trace-file", 1, NULL, 'T' }, + { "trace-control", 1, NULL, 1 }, { "transaction", 1, NULL, 't' }, { "perm-nb", 1, NULL, 'A' }, { "path-max", 1, NULL, 'M' }, @@ -2707,6 +2713,33 @@ static void set_quota(const char *arg, bool soft) barf("unknown quota \"%s\"\n", arg); } +/* Sorted by bit values of TRACE_* flags. Flag is (1u << index). */ +const char *trace_switches[] = { + "obj", "io", "wrl", + NULL +}; + +int set_trace_switch(const char *arg) +{ + bool remove = (arg[0] == '!'); + unsigned int idx; + + if (remove) + arg++; + + for (idx = 0; trace_switches[idx]; idx++) { + if (!strcmp(arg, trace_switches[idx])) { + if (remove) + trace_flags &= ~(1u << idx); + else + trace_flags |= 1u << idx; + return 0; + } + } + + return EINVAL; +} + int main(int argc, char *argv[]) { int opt; @@ -2755,6 +2788,9 @@ int main(int argc, char *argv[]) case 'T': tracefile = optarg; break; + case 1: + set_trace_switch(optarg); + break; case 'I': if (optarg && !strcmp(optarg, "off")) tdb_flags = 0; diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 3b96ecd018..c85b15515c 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -287,6 +287,12 @@ extern char **orig_argv; extern char *tracefile; extern int tracefd; +extern unsigned int trace_flags; +#define TRACE_OBJ 0x00000001 +#define TRACE_IO 0x00000002 +#define TRACE_WRL 0x00000004 +extern const char *trace_switches[]; +int set_trace_switch(const char *arg); extern TDB_CONTEXT *tdb_ctx; extern int dom0_domid; diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 0bf35cd353..70d9e9572d 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -1256,6 +1256,12 @@ static long wrl_ndomains; static wrl_creditt wrl_reserve; /* [-wrl_config_newdoms_dburst, +_gburst ] */ static time_t wrl_log_last_warning; /* 0: no previous warning */ +#define trace_wrl(...) \ +do { \ + if (trace_flags & TRACE_WRL) \ + trace("wrl: " __VA_ARGS__); \ +} while (0) + void wrl_gettime_now(struct wrl_timestampt *now_wt) { struct timespec now_ts; @@ -1361,12 +1367,9 @@ void wrl_credit_update(struct domain *domain, struct wrl_timestampt now) domain->wrl_timestamp = now; - trace("wrl: dom %4d %6ld msec %9ld credit %9ld reserve" - " %9ld discard\n", - domain->domid, - msec, - (long)domain->wrl_credit, (long)wrl_reserve, - (long)surplus); + trace_wrl("dom %4d %6ld msec %9ld credit %9ld reserve %9ld discard\n", + domain->domid, msec, (long)domain->wrl_credit, + (long)wrl_reserve, (long)surplus); } void wrl_check_timeout(struct domain *domain, @@ -1398,10 +1401,9 @@ void wrl_check_timeout(struct domain *domain, if (*ptimeout==-1 || wakeup < *ptimeout) *ptimeout = wakeup; - trace("wrl: domain %u credit=%ld (reserve=%ld) SLEEPING for %d\n", - domain->domid, - (long)domain->wrl_credit, (long)wrl_reserve, - wakeup); + trace_wrl("domain %u credit=%ld (reserve=%ld) SLEEPING for %d\n", + domain->domid, (long)domain->wrl_credit, (long)wrl_reserve, + wakeup); } #define WRL_LOG(now, ...) \ @@ -1419,9 +1421,8 @@ void wrl_apply_debit_actual(struct domain *domain) wrl_credit_update(domain, now); domain->wrl_credit -= wrl_config_writecost; - trace("wrl: domain %u credit=%ld (reserve=%ld)\n", - domain->domid, - (long)domain->wrl_credit, (long)wrl_reserve); + trace_wrl("domain %u credit=%ld (reserve=%ld)\n", domain->domid, + (long)domain->wrl_credit, (long)wrl_reserve); if (domain->wrl_credit < 0) { if (!domain->wrl_delay_logged) { diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 82e5e66c18..1aa9d3cb3d 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -475,6 +475,7 @@ int do_transaction_start(const void *ctx, struct connection *conn, if (!trans) return ENOMEM; + trace_create(trans, "transaction"); INIT_LIST_HEAD(&trans->accessed); INIT_LIST_HEAD(&trans->changed_domains); trans->conn = conn; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:43:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:43:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434972.687908 (Exim 4.92) (envelope-from ) id 1optQO-0002vH-En; Tue, 01 Nov 2022 15:43:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434972.687908; Tue, 01 Nov 2022 15:43:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optQO-0002tJ-9d; Tue, 01 Nov 2022 15:43:36 +0000 Received: by outflank-mailman (input) for mailman id 434972; Tue, 01 Nov 2022 15:43:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optDD-0007Bd-Ln for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:29:59 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0b7c0860-59fa-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 16:29:59 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B0D111F8E3; Tue, 1 Nov 2022 15:29:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 828381346F; Tue, 1 Nov 2022 15:29:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7z17HnY7YWMYYQAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:29:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b7c0860-59fa-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316598; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E0EnVO0aZYolAaiP6qGG7pTwSLxkIEF5XkBdvMekgyk=; b=hHzm9gqbBIbfmvXUshM5RoHjqnOu/zNp8CQR1IJ87mbtBAEmKfoIblzWK+VjbElb5T/OEu XdPBz/nP50myYPQJ2i/WT/tJCJX9CJhnZQJfrAFgJiHv3hVd1+VDlls8DXO+7G1RuWFXYK 8y2zmaa//bnv7roGpGGHu5LFXRL/FXo= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 13/20] tools/xenstore: don't allow creating too many nodes in a transaction Date: Tue, 1 Nov 2022 16:28:35 +0100 Message-Id: <20221101152842.4257-14-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The accounting for the number of nodes of a domain in an active transaction is not working correctly, as it allows to create arbitrary number of nodes. The transaction will finally fail due to exceeding the number of nodes quota, but before closing the transaction an unprivileged guest could cause Xenstore to use a lot of memory. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_domain.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index b737a77683..529ffb522a 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -1125,9 +1125,8 @@ int domain_nbentry_fix(unsigned int domid, int num, bool update) int domain_nbentry(struct connection *conn) { - return (domain_is_unprivileged(conn)) - ? conn->domain->nbentry - : 0; + return domain_is_unprivileged(conn) + ? domain_nbentry_add(conn, conn->id, 0, true) : 0; } static bool domain_chk_quota(struct domain *domain, int mem) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:43:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:43:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434979.687949 (Exim 4.92) (envelope-from ) id 1optQR-0003z5-R1; Tue, 01 Nov 2022 15:43:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434979.687949; Tue, 01 Nov 2022 15:43:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optQR-0003wZ-Jk; Tue, 01 Nov 2022 15:43:39 +0000 Received: by outflank-mailman (input) for mailman id 434979; Tue, 01 Nov 2022 15:43:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optDU-0007Bd-Ai for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:30:16 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 15709a41-59fa-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 16:30:15 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 67CB53385D; Tue, 1 Nov 2022 15:30:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3B03A1346F; Tue, 1 Nov 2022 15:30:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PZsPDYc7YWNeYQAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:30:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15709a41-59fa-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316615; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EV5pCY35LkOt79N6jfSZOmuhj6wp/oTOWnMIlMFabww=; b=GRx9hABOt4TyefgU+wj81x3BQMxKCDd14fhzqJ5Tfds0etLA/HyNb4T+OTHrqNx7PsS3LN q/aQqm5siFsg0Aorcp3txVxTKg261+rDl3ERYDowpX6kfe5a9Izak8jQBVSo2fXgb2TM/y n++oVlUZeHXDYSkSTKW4xx5z1HdTaIA= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 16/20] tools/xenstore: let chk_domain_generation() return a bool Date: Tue, 1 Nov 2022 16:28:38 +0100 Message-Id: <20221101152842.4257-17-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of returning 0 or 1 let chk_domain_generation() return a boolean value. Simplify the only caller by removing the ret variable. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_domain.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 368b9bc2b7..3d460a6fa8 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -990,20 +990,20 @@ void domain_deinit(void) * count (used for testing whether a node permission is older than a domain). * * Return values: - * 0: domain has higher generation count (it is younger than a node with the - * given count), or domain isn't existing any longer - * 1: domain is older than the node + * false: domain has higher generation count (it is younger than a node with + * the given count), or domain isn't existing any longer + * true: domain is older than the node */ -static int chk_domain_generation(unsigned int domid, uint64_t gen) +static bool chk_domain_generation(unsigned int domid, uint64_t gen) { struct domain *d; if (!xc_handle && domid == dom0_domid) - return 1; + return true; d = find_domain_struct(domid); - return (d && d->generation <= gen) ? 1 : 0; + return d && d->generation <= gen; } /* @@ -1038,14 +1038,12 @@ int domain_alloc_permrefs(struct node_perms *perms) int domain_adjust_node_perms(struct node *node) { unsigned int i; - int ret; for (i = 1; i < node->perms.num; i++) { if (node->perms.p[i].perms & XS_PERM_IGNORE) continue; - ret = chk_domain_generation(node->perms.p[i].id, - node->generation); - if (!ret) + if (!chk_domain_generation(node->perms.p[i].id, + node->generation)) node->perms.p[i].perms |= XS_PERM_IGNORE; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:43:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:43:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434980.687965 (Exim 4.92) (envelope-from ) id 1optQW-0004eR-6k; Tue, 01 Nov 2022 15:43:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434980.687965; Tue, 01 Nov 2022 15:43:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optQW-0004e2-0k; Tue, 01 Nov 2022 15:43:44 +0000 Received: by outflank-mailman (input) for mailman id 434980; Tue, 01 Nov 2022 15:43:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCs-0007Bd-8J for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:29:38 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fe3239c3-59f9-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 16:29:36 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 67F39336C7; Tue, 1 Nov 2022 15:29:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3C29A1346F; Tue, 1 Nov 2022 15:29:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6EFVDWA7YWPjYAAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:29:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe3239c3-59f9-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tg8TSEeYBIF2KJ0g+f5733uhCW0POMvEIJ3tLX8Z4xA=; b=YudtRelzqL4HQQP/fQ7qugSrRsQJ8Dr+UwF3rEg/kAa1MwwJlMQuqjJMZ3ZlMV40lw537a fuWCg8yOwgyLFylEJtGSkzoYIN5ZZqf2NUU2TKBMEPIwvqRbtOGOm4qAN8xns9Tzcj/ObO OgoK8ng0tkNzMrufvn4MhN1DZrY41yU= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 09/20] tools/xenstore: introduce dummy nodes for special watch paths Date: Tue, 1 Nov 2022 16:28:31 +0100 Message-Id: <20221101152842.4257-10-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of special casing the permission handling and watch event firing for the special watch paths "@introduceDomain" and "@releaseDomain", use static dummy nodes added to the data base when starting Xenstore. This allows to simplify quite some code. Note that this requires to rework the calls of fire_watches() for the special events in order to avoid leaking memory. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_control.c | 3 - tools/xenstore/xenstored_core.c | 67 +++++++----- tools/xenstore/xenstored_domain.c | 162 ++++------------------------- tools/xenstore/xenstored_domain.h | 6 -- tools/xenstore/xenstored_watch.c | 17 +-- 5 files changed, 63 insertions(+), 192 deletions(-) diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index d1aaa00bf4..41e6992591 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -676,9 +676,6 @@ static const char *lu_dump_state(const void *ctx, struct connection *conn) if (ret) goto out; ret = dump_state_connections(fp); - if (ret) - goto out; - ret = dump_state_special_nodes(fp); if (ret) goto out; ret = dump_state_nodes(fp, ctx); diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 1650821922..cadb339486 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -616,7 +616,8 @@ static void get_acc_data(TDB_DATA *key, struct node_account_data *acc) static unsigned int get_acc_domid(struct connection *conn, TDB_DATA *key, unsigned int domid) { - return (!conn || key->dptr[0] == '/') ? domid : conn->id; + return (!conn || key->dptr[0] == '/' || key->dptr[0] == '@') + ? domid : conn->id; } int do_tdb_write(struct connection *conn, TDB_DATA *key, TDB_DATA *data, @@ -1780,14 +1781,6 @@ static int do_set_perms(const void *ctx, struct connection *conn, if (perms.p[0].perms & XS_PERM_IGNORE) return ENOENT; - /* First arg is node name. */ - if (strstarts(in->buffer, "@")) { - if (set_perms_special(conn, in->buffer, &perms)) - return errno; - send_ack(conn, XS_SET_PERMS); - return 0; - } - /* We must own node to do this (tools can do this too). */ node = get_node_canonicalized(conn, ctx, in->buffer, &name, XS_PERM_WRITE | XS_PERM_OWNER); @@ -2388,7 +2381,9 @@ void setup_structure(bool live_update) manual_node("/", "tool"); manual_node("/tool", "xenstored"); manual_node("/tool/xenstored", NULL); - domain_entry_fix(dom0_domid, 3, true); + manual_node("@releaseDomain", NULL); + manual_node("@introduceDomain", NULL); + domain_entry_fix(dom0_domid, 5, true); } check_store(); @@ -3170,6 +3165,23 @@ static int dump_state_node(const void *ctx, struct connection *conn, return WALK_TREE_OK; } +static int dump_state_special_node(FILE *fp, const void *ctx, + struct dump_node_data *data, + const char *name) +{ + struct node *node; + int ret; + + node = read_node(NULL, ctx, name); + if (!node) + return dump_state_node_err(data, "Dump node read node error"); + + ret = dump_state_node(ctx, NULL, node, data); + talloc_free(node); + + return ret; +} + const char *dump_state_nodes(FILE *fp, const void *ctx) { struct dump_node_data data = { @@ -3181,6 +3193,11 @@ const char *dump_state_nodes(FILE *fp, const void *ctx) if (walk_node_tree(ctx, NULL, "/", &walkfuncs, &data)) return data.err; + if (dump_state_special_node(fp, ctx, &data, "@releaseDomain")) + return data.err; + if (dump_state_special_node(fp, ctx, &data, "@introduceDomain")) + return data.err; + return NULL; } @@ -3354,25 +3371,21 @@ void read_state_node(const void *ctx, const void *state) node->perms.p[i].id = sn->perms[i].domid; } - if (strstarts(name, "@")) { - set_perms_special(&conn, name, &node->perms); - talloc_free(node); - return; - } - - parentname = get_parent(node, name); - if (!parentname) - barf("allocation error restoring node"); - parent = read_node(NULL, node, parentname); - if (!parent) - barf("read parent error restoring node"); + if (!strstarts(name, "@")) { + parentname = get_parent(node, name); + if (!parentname) + barf("allocation error restoring node"); + parent = read_node(NULL, node, parentname); + if (!parent) + barf("read parent error restoring node"); - if (add_child(node, parent, name)) - barf("allocation error restoring node"); + if (add_child(node, parent, name)) + barf("allocation error restoring node"); - set_tdb_key(parentname, &key); - if (write_node_raw(NULL, &key, parent, true)) - barf("write parent error restoring node"); + set_tdb_key(parentname, &key); + if (write_node_raw(NULL, &key, parent, true)) + barf("write parent error restoring node"); + } set_tdb_key(name, &key); if (write_node_raw(NULL, &key, node, true)) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index f6797e53c5..5756010944 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -43,9 +43,6 @@ static evtchn_port_t virq_port; xenevtchn_handle *xce_handle = NULL; -static struct node_perms dom_release_perms; -static struct node_perms dom_introduce_perms; - struct domain { /* The id of this domain */ @@ -225,27 +222,6 @@ static void unmap_interface(void *interface) xengnttab_unmap(*xgt_handle, interface, 1); } -static void remove_domid_from_perm(struct node_perms *perms, - struct domain *domain) -{ - unsigned int cur, new; - - if (perms->p[0].id == domain->domid) - perms->p[0].id = priv_domid; - - for (cur = new = 1; cur < perms->num; cur++) { - if (perms->p[cur].id == domain->domid) - continue; - - if (new != cur) - perms->p[new] = perms->p[cur]; - - new++; - } - - perms->num = new; -} - static int domain_tree_remove_sub(const void *ctx, struct connection *conn, struct node *node, void *arg) { @@ -297,8 +273,24 @@ static void domain_tree_remove(struct domain *domain) "error when looking for orphaned nodes\n"); } - remove_domid_from_perm(&dom_release_perms, domain); - remove_domid_from_perm(&dom_introduce_perms, domain); + walk_node_tree(domain, NULL, "@releaseDomain", &walkfuncs, domain); + walk_node_tree(domain, NULL, "@introduceDomain", &walkfuncs, domain); +} + +static void fire_special_watches(const char *name) +{ + void *ctx = talloc_new(NULL); + struct node *node; + + if (!ctx) + return; + + node = read_node(NULL, ctx, name); + + if (node) + fire_watches(NULL, ctx, name, node, true, NULL); + + talloc_free(ctx); } static int destroy_domain(void *_domain) @@ -326,7 +318,7 @@ static int destroy_domain(void *_domain) unmap_interface(domain->interface); } - fire_watches(NULL, domain, "@releaseDomain", NULL, true, NULL); + fire_special_watches("@releaseDomain"); wrl_domain_destroy(domain); @@ -390,7 +382,7 @@ void check_domains(void) ; if (notify) - fire_watches(NULL, NULL, "@releaseDomain", NULL, true, NULL); + fire_special_watches("@releaseDomain"); } /* We scan all domains rather than use the information given here. */ @@ -639,8 +631,7 @@ static struct domain *introduce_domain(const void *ctx, } if (!is_master_domain && !restore) - fire_watches(NULL, ctx, "@introduceDomain", NULL, - true, NULL); + fire_special_watches("@introduceDomain"); } else { /* Use XS_INTRODUCE for recreating the xenbus event-channel. */ if (domain->port) @@ -843,59 +834,6 @@ const char *get_implicit_path(const struct connection *conn) return conn->domain->path; } -static int set_dom_perms_default(struct node_perms *perms) -{ - perms->num = 1; - perms->p = talloc_array(NULL, struct xs_permissions, perms->num); - if (!perms->p) - return -1; - perms->p->id = 0; - perms->p->perms = XS_PERM_NONE; - - return 0; -} - -static struct node_perms *get_perms_special(const char *name) -{ - if (!strcmp(name, "@releaseDomain")) - return &dom_release_perms; - if (!strcmp(name, "@introduceDomain")) - return &dom_introduce_perms; - return NULL; -} - -int set_perms_special(struct connection *conn, const char *name, - struct node_perms *perms) -{ - struct node_perms *p; - - p = get_perms_special(name); - if (!p) - return EINVAL; - - if ((perm_for_conn(conn, p) & (XS_PERM_WRITE | XS_PERM_OWNER)) != - (XS_PERM_WRITE | XS_PERM_OWNER)) - return EACCES; - - p->num = perms->num; - talloc_free(p->p); - p->p = perms->p; - talloc_steal(NULL, perms->p); - - return 0; -} - -bool check_perms_special(const char *name, struct connection *conn) -{ - struct node_perms *p; - - p = get_perms_special(name); - if (!p) - return false; - - return perm_for_conn(conn, p) & XS_PERM_READ; -} - void dom0_init(void) { evtchn_port_t port; @@ -965,10 +903,6 @@ void domain_init(int evtfd) if (xce_handle == NULL) barf_perror("Failed to open evtchn device"); - if (set_dom_perms_default(&dom_release_perms) || - set_dom_perms_default(&dom_introduce_perms)) - barf_perror("Failed to set special permissions"); - if ((rc = xenevtchn_bind_virq(xce_handle, VIRQ_DOM_EXC)) == -1) barf_perror("Failed to bind to domain exception virq port"); virq_port = rc; @@ -1538,60 +1472,6 @@ const char *dump_state_connections(FILE *fp) return ret; } -static const char *dump_state_special_node(FILE *fp, const char *name, - const struct node_perms *perms) -{ - struct xs_state_record_header head; - struct xs_state_node sn; - unsigned int pathlen; - const char *ret; - - pathlen = strlen(name) + 1; - - head.type = XS_STATE_TYPE_NODE; - head.length = sizeof(sn); - - sn.conn_id = 0; - sn.ta_id = 0; - sn.ta_access = 0; - sn.perm_n = perms->num; - sn.path_len = pathlen; - sn.data_len = 0; - head.length += perms->num * sizeof(*sn.perms); - head.length += pathlen; - head.length = ROUNDUP(head.length, 3); - if (fwrite(&head, sizeof(head), 1, fp) != 1) - return "Dump special node error"; - if (fwrite(&sn, sizeof(sn), 1, fp) != 1) - return "Dump special node error"; - - ret = dump_state_node_perms(fp, perms->p, perms->num); - if (ret) - return ret; - - if (fwrite(name, pathlen, 1, fp) != 1) - return "Dump special node path error"; - - ret = dump_state_align(fp); - - return ret; -} - -const char *dump_state_special_nodes(FILE *fp) -{ - const char *ret; - - ret = dump_state_special_node(fp, "@releaseDomain", - &dom_release_perms); - if (ret) - return ret; - - ret = dump_state_special_node(fp, "@introduceDomain", - &dom_introduce_perms); - - return ret; -} - void read_state_connection(const void *ctx, const void *state) { const struct xs_state_connection *sc = state; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index b38c82991d..630641d620 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -99,11 +99,6 @@ void domain_outstanding_domid_dec(unsigned int domid); int domain_get_quota(const void *ctx, struct connection *conn, unsigned int domid); -/* Special node permission handling. */ -int set_perms_special(struct connection *conn, const char *name, - struct node_perms *perms); -bool check_perms_special(const char *name, struct connection *conn); - /* Write rate limiting */ #define WRL_FACTOR 1000 /* for fixed-point arithmetic */ @@ -132,7 +127,6 @@ void wrl_apply_debit_direct(struct connection *conn); void wrl_apply_debit_trans_commit(struct connection *conn); const char *dump_state_connections(FILE *fp); -const char *dump_state_special_nodes(FILE *fp); void read_state_connection(const void *ctx, const void *state); diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index 316c08b7f7..75748ac109 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -46,13 +46,6 @@ struct watch char *node; }; -static bool check_special_event(const char *name) -{ - assert(name); - - return strstarts(name, "@"); -} - /* Is child a subnode of parent, or equal? */ static bool is_child(const char *child, const char *parent) { @@ -153,14 +146,8 @@ void fire_watches(struct connection *conn, const void *ctx, const char *name, /* Create an event for each watch. */ list_for_each_entry(i, &connections, list) { - /* introduce/release domain watches */ - if (check_special_event(name)) { - if (!check_perms_special(name, i)) - continue; - } else { - if (!watch_permitted(i, ctx, name, node, perms)) - continue; - } + if (!watch_permitted(i, ctx, name, node, perms)) + continue; list_for_each_entry(watch, &i->watches, list) { if (exact) { -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:43:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:43:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434982.687971 (Exim 4.92) (envelope-from ) id 1optQW-0004ik-Kl; Tue, 01 Nov 2022 15:43:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434982.687971; Tue, 01 Nov 2022 15:43:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optQW-0004iD-Cc; Tue, 01 Nov 2022 15:43:44 +0000 Received: by outflank-mailman (input) for mailman id 434982; Tue, 01 Nov 2022 15:43:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optDa-0007Bd-59 for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:30:22 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 18bfe960-59fa-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 16:30:21 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F00081F90F; Tue, 1 Nov 2022 15:30:20 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C4CA81346F; Tue, 1 Nov 2022 15:30:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sFyNLow7YWNqYQAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:30:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18bfe960-59fa-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316620; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ic6QdQsT3IiF6Ltj3wF/G4ESqbAyko/szkpr1ypz+8c=; b=tRkxrFYV3oaB/2utzN949AwMp4KgL1SdgHyhRiBQW6W5TqBAHM4BNUS6x4vFwpgMq6oGYU BOwywZvi2T2Cyd3Id+NmSYyZI1eHlWz99UzigKQJ5T7bTGiilX1EVe1yVf7eCZRO4eV2Cu 5eRpY9D3VSDjUASKrKfbzg5rCjAcUxg= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 17/20] tools/xenstore: switch hashtable to use the talloc framework Date: Tue, 1 Nov 2022 16:28:39 +0100 Message-Id: <20221101152842.4257-18-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using malloc() and friends, let the hashtable implementation use the talloc framework. Signed-off-by: Juergen Gross --- tools/xenstore/hashtable.c | 86 ++++++++++++------------------- tools/xenstore/hashtable.h | 3 +- tools/xenstore/xenstored_core.c | 5 +- tools/xenstore/xenstored_domain.c | 2 +- 4 files changed, 39 insertions(+), 57 deletions(-) diff --git a/tools/xenstore/hashtable.c b/tools/xenstore/hashtable.c index 7a1548c490..1c8656e016 100644 --- a/tools/xenstore/hashtable.c +++ b/tools/xenstore/hashtable.c @@ -6,6 +6,8 @@ #include #include #include +#include +#include "talloc.h" struct entry { @@ -50,7 +52,7 @@ indexFor(unsigned int tablelength, unsigned int hashvalue) { /*****************************************************************************/ struct hashtable * -create_hashtable(unsigned int minsize, +create_hashtable(const void *ctx, unsigned int minsize, unsigned int (*hashf) (void*), int (*eqf) (void*,void*), unsigned int flags) @@ -66,10 +68,10 @@ create_hashtable(unsigned int minsize, if (primes[pindex] > minsize) { size = primes[pindex]; break; } } - h = (struct hashtable *)calloc(1, sizeof(struct hashtable)); + h = talloc_zero(ctx, struct hashtable); if (NULL == h) goto err0; - h->table = (struct entry **)calloc(size, sizeof(struct entry *)); + h->table = talloc_zero_array(h, struct entry *, size); if (NULL == h->table) goto err1; @@ -83,7 +85,7 @@ create_hashtable(unsigned int minsize, return h; err1: - free(h); + talloc_free(h); err0: return NULL; } @@ -115,47 +117,32 @@ hashtable_expand(struct hashtable *h) if (h->primeindex == (prime_table_length - 1)) return 0; newsize = primes[++(h->primeindex)]; - newtable = (struct entry **)calloc(newsize, sizeof(struct entry*)); - if (NULL != newtable) + newtable = talloc_realloc(h, h->table, struct entry *, newsize); + if (!newtable) { - /* This algorithm is not 'stable'. ie. it reverses the list - * when it transfers entries between the tables */ - for (i = 0; i < h->tablelength; i++) { - while (NULL != (e = h->table[i])) { - h->table[i] = e->next; - index = indexFor(newsize,e->h); + h->primeindex--; + return 0; + } + + h->table = newtable; + memset(newtable + h->tablelength, 0, + (newsize - h->tablelength) * sizeof(*newtable)); + for (i = 0; i < h->tablelength; i++) { + for (pE = &(newtable[i]), e = *pE; e != NULL; e = *pE) { + index = indexFor(newsize,e->h); + if (index == i) + { + pE = &(e->next); + } + else + { + *pE = e->next; e->next = newtable[index]; newtable[index] = e; } } - free(h->table); - h->table = newtable; - } - /* Plan B: realloc instead */ - else - { - newtable = (struct entry **) - realloc(h->table, newsize * sizeof(struct entry *)); - if (NULL == newtable) { (h->primeindex)--; return 0; } - h->table = newtable; - memset(newtable + h->tablelength, 0, - (newsize - h->tablelength) * sizeof(*newtable)); - for (i = 0; i < h->tablelength; i++) { - for (pE = &(newtable[i]), e = *pE; e != NULL; e = *pE) { - index = indexFor(newsize,e->h); - if (index == i) - { - pE = &(e->next); - } - else - { - *pE = e->next; - e->next = newtable[index]; - newtable[index] = e; - } - } - } } + h->tablelength = newsize; h->loadlimit = (unsigned int) (((uint64_t)newsize * max_load_factor) / 100); @@ -184,7 +171,7 @@ hashtable_insert(struct hashtable *h, void *k, void *v) * element may be ok. Next time we insert, we'll try expanding again.*/ hashtable_expand(h); } - e = (struct entry *)calloc(1, sizeof(struct entry)); + e = talloc_zero(h, struct entry); if (NULL == e) { --(h->entrycount); return 0; } /*oom*/ e->h = hash(h,k); index = indexFor(h->tablelength,e->h); @@ -238,8 +225,8 @@ hashtable_remove(struct hashtable *h, void *k) h->entrycount--; v = e->v; if (h->flags & HASHTABLE_FREE_KEY) - free(e->k); - free(e); + talloc_free(e->k); + talloc_free(e); return v; } pE = &(e->next); @@ -280,25 +267,20 @@ void hashtable_destroy(struct hashtable *h) { unsigned int i; - struct entry *e, *f; + struct entry *e; struct entry **table = h->table; for (i = 0; i < h->tablelength; i++) { - e = table[i]; - while (NULL != e) + for (e = table[i]; e; e = e->next) { - f = e; - e = e->next; if (h->flags & HASHTABLE_FREE_KEY) - free(f->k); + talloc_free(e->k); if (h->flags & HASHTABLE_FREE_VALUE) - free(f->v); - free(f); + talloc_free(e->v); } } - free(h->table); - free(h); + talloc_free(h); } /* diff --git a/tools/xenstore/hashtable.h b/tools/xenstore/hashtable.h index b31eeaea26..07fdc1a82b 100644 --- a/tools/xenstore/hashtable.h +++ b/tools/xenstore/hashtable.h @@ -9,6 +9,7 @@ struct hashtable; * create_hashtable * @name create_hashtable + * @param ctx talloc context to use for allocations * @param minsize minimum initial size of hashtable * @param hashfunction function for hashing keys * @param key_eq_fn function for determining key equality @@ -22,7 +23,7 @@ struct hashtable; #define HASHTABLE_FREE_KEY (1U << 1) struct hashtable * -create_hashtable(unsigned int minsize, +create_hashtable(const void *ctx, unsigned int minsize, unsigned int (*hashfunction) (void*), int (*key_eq_fn) (void*,void*), unsigned int flags diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 5013f8b909..9361ee7696 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2410,11 +2410,10 @@ static int keys_equal_fn(void *key1, void *key2) int remember_string(struct hashtable *hash, const char *str) { - char *k = malloc(strlen(str) + 1); + char *k = talloc_strdup(NULL, str); if (!k) return 0; - strcpy(k, str); return hashtable_insert(hash, k, (void *)1); } @@ -2509,7 +2508,7 @@ void check_store(void) }; /* Don't free values (they are all void *1) */ - reachable = create_hashtable(16, hash_from_key_fn, keys_equal_fn, + reachable = create_hashtable(NULL, 16, hash_from_key_fn, keys_equal_fn, HASHTABLE_FREE_KEY); if (!reachable) { log("check_store: ENOMEM"); diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 3d460a6fa8..0bf35cd353 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -936,7 +936,7 @@ void domain_init(int evtfd) int rc; /* Start with a random rather low domain count for the hashtable. */ - domhash = create_hashtable(8, domhash_fn, domeq_fn, 0); + domhash = create_hashtable(NULL, 8, domhash_fn, domeq_fn, 0); if (!domhash) barf_perror("Failed to allocate domain hashtable"); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:43:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:43:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434984.687976 (Exim 4.92) (envelope-from ) id 1optQX-0004qd-3Z; Tue, 01 Nov 2022 15:43:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434984.687976; Tue, 01 Nov 2022 15:43:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optQW-0004o0-Sv; Tue, 01 Nov 2022 15:43:44 +0000 Received: by outflank-mailman (input) for mailman id 434984; Tue, 01 Nov 2022 15:43:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optCh-0007Tl-J1 for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:29:27 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f792a4f8-59f9-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 16:29:25 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4C0581F8E3; Tue, 1 Nov 2022 15:29:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 201DC1346F; Tue, 1 Nov 2022 15:29:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5smIBlU7YWPPYAAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:29:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f792a4f8-59f9-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316565; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jhFlAl8E/ZVxI2AuUFyhPfvdnWASnzhuJ0AtRWUI/hQ=; b=bGuDis76nzl50gDl8gQleQdWKLKz16tCHn071OCHWJCPe60hDOgaxI0a4BBznOO058Xf7p Nxk4FmR38xb+m7BclrF1Oek4rMkrawdd5C98mCqE31GIIkycd7Wa6P24fc2zpdKzOtyyxM +sSqPJyb71vIzsGSrrBOVUysY64bZpE= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 07/20] tools/xenstore: enhance hashtable implementation Date: Tue, 1 Nov 2022 16:28:29 +0100 Message-Id: <20221101152842.4257-8-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today it is possible to set a flag when calling hashtable_destroy() in order to specify whether the data associated with the hashtable entries should be freed or not. The keys of the entries will always be freed. Change that by replacing the flag of hashtable_destroy() by two flags for create_hashtable() which will specify whether the data and/or the key of each entry should be freed or not. This will enable users to have the key e.g. as part of the data. Add a new function hashtable_iterate() to call a user specified function for each entry in the hashtable. Add new primes to the primetable in order to support smaller sizes of the hashtable. The primes are selected according to: https://planetmath.org/goodhashtableprimes Signed-off-by: Juergen Gross --- tools/xenstore/hashtable.c | 66 +++++++++++++++++++++++---------- tools/xenstore/hashtable.h | 35 +++++++++++++++-- tools/xenstore/xenstored_core.c | 7 ++-- 3 files changed, 82 insertions(+), 26 deletions(-) diff --git a/tools/xenstore/hashtable.c b/tools/xenstore/hashtable.c index 6ac336eff1..7a1548c490 100644 --- a/tools/xenstore/hashtable.c +++ b/tools/xenstore/hashtable.c @@ -16,6 +16,7 @@ struct entry struct hashtable { unsigned int tablelength; + unsigned int flags; struct entry **table; unsigned int entrycount; unsigned int loadlimit; @@ -25,12 +26,11 @@ struct hashtable { }; /* -Credit for primes table: Aaron Krowne - http://br.endernet.org/~akrowne/ - http://planetmath.org/encyclopedia/GoodHashTablePrimes.html -*/ + * Credit for primes table: Aaron Krowne + * https://planetmath.org/goodhashtableprimes + */ static const unsigned int primes[] = { -53, 97, 193, 389, +11, 23, 53, 97, 193, 389, 769, 1543, 3079, 6151, 12289, 24593, 49157, 98317, 196613, 393241, 786433, 1572869, @@ -52,7 +52,8 @@ indexFor(unsigned int tablelength, unsigned int hashvalue) { struct hashtable * create_hashtable(unsigned int minsize, unsigned int (*hashf) (void*), - int (*eqf) (void*,void*)) + int (*eqf) (void*,void*), + unsigned int flags) { struct hashtable *h; unsigned int pindex, size = primes[0]; @@ -73,6 +74,7 @@ create_hashtable(unsigned int minsize, goto err1; h->tablelength = size; + h->flags = flags; h->primeindex = pindex; h->entrycount = 0; h->hashfn = hashf; @@ -235,7 +237,8 @@ hashtable_remove(struct hashtable *h, void *k) *pE = e->next; h->entrycount--; v = e->v; - free(e->k); + if (h->flags & HASHTABLE_FREE_KEY) + free(e->k); free(e); return v; } @@ -246,29 +249,52 @@ hashtable_remove(struct hashtable *h, void *k) } /*****************************************************************************/ -/* destroy */ -void -hashtable_destroy(struct hashtable *h, int free_values) +int +hashtable_iterate(struct hashtable *h, + int (*func)(void *k, void *v, void *arg), void *arg) { + int ret; unsigned int i; struct entry *e, *f; struct entry **table = h->table; - if (free_values) + + for (i = 0; i < h->tablelength; i++) { - for (i = 0; i < h->tablelength; i++) + e = table[i]; + while (e) { - e = table[i]; - while (NULL != e) - { f = e; e = e->next; free(f->k); free(f->v); free(f); } + f = e; + e = e->next; + ret = func(f->k, f->v, arg); + if (ret) + return ret; } } - else + + return 0; +} + +/*****************************************************************************/ +/* destroy */ +void +hashtable_destroy(struct hashtable *h) +{ + unsigned int i; + struct entry *e, *f; + struct entry **table = h->table; + + for (i = 0; i < h->tablelength; i++) { - for (i = 0; i < h->tablelength; i++) + e = table[i]; + while (NULL != e) { - e = table[i]; - while (NULL != e) - { f = e; e = e->next; free(f->k); free(f); } + f = e; + e = e->next; + if (h->flags & HASHTABLE_FREE_KEY) + free(f->k); + if (h->flags & HASHTABLE_FREE_VALUE) + free(f->v); + free(f); } } free(h->table); diff --git a/tools/xenstore/hashtable.h b/tools/xenstore/hashtable.h index 62fef6081a..b31eeaea26 100644 --- a/tools/xenstore/hashtable.h +++ b/tools/xenstore/hashtable.h @@ -12,13 +12,21 @@ struct hashtable; * @param minsize minimum initial size of hashtable * @param hashfunction function for hashing keys * @param key_eq_fn function for determining key equality + * @param flags flags HASHTABLE_* * @return newly created hashtable or NULL on failure */ +/* Let hashtable_destroy() free the entries' values. */ +#define HASHTABLE_FREE_VALUE (1U << 0) +/* Let hashtable_remove() and hashtable_destroy() free the entries' keys. */ +#define HASHTABLE_FREE_KEY (1U << 1) + struct hashtable * create_hashtable(unsigned int minsize, unsigned int (*hashfunction) (void*), - int (*key_eq_fn) (void*,void*)); + int (*key_eq_fn) (void*,void*), + unsigned int flags +); /***************************************************************************** * hashtable_insert @@ -76,16 +84,37 @@ hashtable_remove(struct hashtable *h, void *k); unsigned int hashtable_count(struct hashtable *h); +/***************************************************************************** + * hashtable_iterate + + * @name hashtable_iterate + * @param h the hashtable + * @param func function to call for each entry + * @param arg user supplied parameter for func + * @return 0 if okay, non-zero return value of func (and iteration + * was aborted) + * + * Iterates over all entries in the hashtable and calls func with the + * key, value, and the user supplied parameter. + * func returning a non-zero value will abort the iteration. In case func is + * removing an entry other than itself from the hashtable, it must return a + * non-zero value in order to abort the iteration. Inserting entries is + * allowed, but it is undefined whether func will be called for those new + * entries during this iteration. + */ +int +hashtable_iterate(struct hashtable *h, + int (*func)(void *k, void *v, void *arg), void *arg); + /***************************************************************************** * hashtable_destroy * @name hashtable_destroy * @param h the hashtable - * @param free_values whether to call 'free' on the remaining values */ void -hashtable_destroy(struct hashtable *h, int free_values); +hashtable_destroy(struct hashtable *h); #endif /* __HASHTABLE_CWC22_H__ */ diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 8c2cca62b7..1650821922 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2512,7 +2512,9 @@ void check_store(void) .enoent = check_store_enoent, }; - reachable = create_hashtable(16, hash_from_key_fn, keys_equal_fn); + /* Don't free values (they are all void *1) */ + reachable = create_hashtable(16, hash_from_key_fn, keys_equal_fn, + HASHTABLE_FREE_KEY); if (!reachable) { log("check_store: ENOMEM"); return; @@ -2526,8 +2528,7 @@ void check_store(void) clean_store(reachable); log("Checking store complete."); - hashtable_destroy(reachable, 0 /* Don't free values (they are all - (void *)1) */); + hashtable_destroy(reachable); } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 15:43:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 15:43:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.434985.687983 (Exim 4.92) (envelope-from ) id 1optQX-00053L-Ty; Tue, 01 Nov 2022 15:43:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 434985.687983; Tue, 01 Nov 2022 15:43:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optQX-0004xE-If; Tue, 01 Nov 2022 15:43:45 +0000 Received: by outflank-mailman (input) for mailman id 434985; Tue, 01 Nov 2022 15:43:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optD2-0007Tl-Jm for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 15:29:48 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 04d736a9-59fa-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 16:29:47 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8B9013385D; Tue, 1 Nov 2022 15:29:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5DC971346F; Tue, 1 Nov 2022 15:29:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tUCKFWs7YWP5YAAAMHmgww (envelope-from ); Tue, 01 Nov 2022 15:29:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04d736a9-59fa-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667316587; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YEuNMFZScrBO9VppDIj+NvcWUmoCWDv+0NHEQClkkiM=; b=KtJt4+Wu1b0GgfxVWcgP6BYrWFjgfvpI6FE79lMDZjQWT4zRpDGJvbk0Igj6yCZZekx51h U/+p2cUN+TIp+V+4e3yCfIgIppE4PNpXfHvuFR1EQvGSVisJJ5nrNM/SbFc07gVhE+0BSn uwh8V3w+HA7OgA34dk+5L3f6LXykKnk= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 11/20] tools/xenstore: move changed domain handling Date: Tue, 1 Nov 2022 16:28:33 +0100 Message-Id: <20221101152842.4257-12-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101152842.4257-1-jgross@suse.com> References: <20221101152842.4257-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move all code related to struct changed_domain from xenstored_transaction.c to xenstored_domain.c. This will be needed later in order to simplify the accounting data updates in cases of errors during a request. Split the code to have a more generic base framework. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_domain.c | 85 +++++++++++++++++++++++++- tools/xenstore/xenstored_domain.h | 3 + tools/xenstore/xenstored_transaction.c | 64 ++----------------- 3 files changed, 90 insertions(+), 62 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 5756010944..14fd84c288 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -91,6 +91,18 @@ struct domain bool wrl_delay_logged; }; +struct changed_domain +{ + /* List of all changed domains. */ + struct list_head list; + + /* Identifier of the changed domain. */ + unsigned int domid; + + /* Amount by which this domain's nbentry field has changed. */ + int nbentry; +}; + static struct hashtable *domhash; static bool check_indexes(XENSTORE_RING_IDX cons, XENSTORE_RING_IDX prod) @@ -492,8 +504,12 @@ static struct domain *find_or_alloc_existing_domain(unsigned int domid) xc_dominfo_t dominfo; domain = find_domain_struct(domid); - if (!domain && get_domain_info(domid, &dominfo)) - domain = alloc_domain(NULL, domid); + if (!domain) { + if (!get_domain_info(domid, &dominfo)) + errno = ENOENT; + else + domain = alloc_domain(NULL, domid); + } return domain; } @@ -547,6 +563,71 @@ static struct domain *find_domain_by_domid(unsigned int domid) return (d && d->introduced) ? d : NULL; } +int acc_fix_domains(struct list_head *head, bool update) +{ + struct changed_domain *cd; + int cnt; + + list_for_each_entry(cd, head, list) { + cnt = domain_entry_fix(cd->domid, cd->nbentry, update); + if (!update) { + if (cnt >= quota_nb_entry_per_domain) + return ENOSPC; + if (cnt < 0) + return ENOMEM; + } + } + + return 0; +} + +static struct changed_domain *acc_find_changed_domain(struct list_head *head, + unsigned int domid) +{ + struct changed_domain *cd; + + list_for_each_entry(cd, head, list) { + if (cd->domid == domid) + return cd; + } + + return NULL; +} + +static struct changed_domain *acc_get_changed_domain(const void *ctx, + struct list_head *head, + unsigned int domid) +{ + struct changed_domain *cd; + + cd = acc_find_changed_domain(head, domid); + if (cd) + return cd; + + cd = talloc_zero(ctx, struct changed_domain); + if (!cd) + return NULL; + + cd->domid = domid; + list_add_tail(&cd->list, head); + + return cd; +} + +int acc_add_dom_nbentry(const void *ctx, struct list_head *head, int val, + unsigned int domid) +{ + struct changed_domain *cd; + + cd = acc_get_changed_domain(ctx, head, domid); + if (!cd) + return errno; + + cd->nbentry += val; + + return 0; +} + static void domain_conn_reset(struct domain *domain) { struct connection *conn = domain->conn; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 630641d620..9e20d2b17d 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -98,6 +98,9 @@ void domain_outstanding_dec(struct connection *conn); void domain_outstanding_domid_dec(unsigned int domid); int domain_get_quota(const void *ctx, struct connection *conn, unsigned int domid); +int acc_fix_domains(struct list_head *head, bool update); +int acc_add_dom_nbentry(const void *ctx, struct list_head *head, int val, + unsigned int domid); /* Write rate limiting */ diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index ac854197ca..89b92f0baf 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -137,18 +137,6 @@ struct accessed_node bool watch_exact; }; -struct changed_domain -{ - /* List of all changed domains in the context of this transaction. */ - struct list_head list; - - /* Identifier of the changed domain. */ - unsigned int domid; - - /* Amount by which this domain's nbentry field has changed. */ - int nbentry; -}; - struct transaction { /* List of all transactions active on this connection. */ @@ -514,24 +502,6 @@ int do_transaction_start(const void *ctx, struct connection *conn, return 0; } -static int transaction_fix_domains(struct transaction *trans, bool update) -{ - struct changed_domain *d; - int cnt; - - list_for_each_entry(d, &trans->changed_domains, list) { - cnt = domain_entry_fix(d->domid, d->nbentry, update); - if (!update) { - if (cnt >= quota_nb_entry_per_domain) - return ENOSPC; - if (cnt < 0) - return ENOMEM; - } - } - - return 0; -} - int do_transaction_end(const void *ctx, struct connection *conn, struct buffered_data *in) { @@ -558,7 +528,7 @@ int do_transaction_end(const void *ctx, struct connection *conn, if (streq(arg, "T")) { if (trans->fail) return ENOMEM; - ret = transaction_fix_domains(trans, false); + ret = acc_fix_domains(&trans->changed_domains, false); if (ret) return ret; ret = finalize_transaction(conn, trans, &is_corrupt); @@ -568,7 +538,7 @@ int do_transaction_end(const void *ctx, struct connection *conn, wrl_apply_debit_trans_commit(conn); /* fix domain entry for each changed domain */ - transaction_fix_domains(trans, true); + acc_fix_domains(&trans->changed_domains, true); if (is_corrupt) corrupt(conn, "transaction inconsistency"); @@ -580,44 +550,18 @@ int do_transaction_end(const void *ctx, struct connection *conn, void transaction_entry_inc(struct transaction *trans, unsigned int domid) { - struct changed_domain *d; - - list_for_each_entry(d, &trans->changed_domains, list) - if (d->domid == domid) { - d->nbentry++; - return; - } - - d = talloc(trans, struct changed_domain); - if (!d) { + if (acc_add_dom_nbentry(trans, &trans->changed_domains, 1, domid)) { /* Let the transaction fail. */ trans->fail = true; - return; } - d->domid = domid; - d->nbentry = 1; - list_add_tail(&d->list, &trans->changed_domains); } void transaction_entry_dec(struct transaction *trans, unsigned int domid) { - struct changed_domain *d; - - list_for_each_entry(d, &trans->changed_domains, list) - if (d->domid == domid) { - d->nbentry--; - return; - } - - d = talloc(trans, struct changed_domain); - if (!d) { + if (acc_add_dom_nbentry(trans, &trans->changed_domains, -1, domid)) { /* Let the transaction fail. */ trans->fail = true; - return; } - d->domid = domid; - d->nbentry = -1; - list_add_tail(&d->list, &trans->changed_domains); } void fail_transaction(struct transaction *trans) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:04:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:04:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435036.688009 (Exim 4.92) (envelope-from ) id 1optka-0003J8-M3; Tue, 01 Nov 2022 16:04:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435036.688009; Tue, 01 Nov 2022 16:04:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optka-0003J1-JF; Tue, 01 Nov 2022 16:04:28 +0000 Received: by outflank-mailman (input) for mailman id 435036; Tue, 01 Nov 2022 16:04:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optkY-0003Iv-R8 for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:04:26 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db4ea332-59fe-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 17:04:25 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3AB2F22537; Tue, 1 Nov 2022 16:04:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E85CA1346F; Tue, 1 Nov 2022 16:04:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ZcNDN4hDYWMccgAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:04:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db4ea332-59fe-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667318665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NnWE8Bi9rxvc//cfqCoXtYhB8VvdWu9RGDKrjPB8kEI=; b=MlmaLhzDfOlO4tr9jFCJQ/fa0Fn9p7ee6XQu0BZtdkAnUNdpi+LkggIwz9XKx6KGq63V9I lpDwP46lWAX0bQLshkyR+OPlGs1sC3nRlsW3o7pnnFHe/BwKBt9PDF5i6hHjxsQ6E/GNpt lsXMJ3+2Mk4GiKiYm/sZUKssOMgzS8E= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini Subject: [PATCH 00/12] tools/xenstore Date: Tue, 1 Nov 2022 17:04:10 +0100 Message-Id: <20221101160422.7212-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series reworks the Xenstore internal accounting to use a uniform generic framework. It is adding some additional useful diagnostic information, like accounting trace and max. per-domain and global quota values seen. This series is based on top of the series "tools/xenstore: do some cleanup and fixes". Juergen Gross (12): tools/xenstore: manage per-transaction domain accounting data in an array tools/xenstore: introduce accounting data array for per-domain values tools/xenstore: add framework to commit accounting data on success only tools/xenstore: use accounting buffering for node accounting tools/xenstore: add current connection to domain_memory_add() parameters tools/xenstore: use accounting data array for per-domain values tools/xenstore: add accounting trace support tools/xenstore: add TDB access trace support tools/xenstore: switch transaction accounting to generic accounting tools/xenstore: remember global and per domain max accounting values tools/xenstore: use generic accounting for remaining quotas tools/xenstore: switch quota management to be table based docs/misc/xenstore.txt | 5 +- tools/xenstore/xenstored_control.c | 65 ++-- tools/xenstore/xenstored_core.c | 164 +++++----- tools/xenstore/xenstored_core.h | 23 +- tools/xenstore/xenstored_domain.c | 414 ++++++++++++++++++------- tools/xenstore/xenstored_domain.h | 55 +++- tools/xenstore/xenstored_transaction.c | 22 +- tools/xenstore/xenstored_watch.c | 15 +- 8 files changed, 496 insertions(+), 267 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:04:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:04:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435037.688019 (Exim 4.92) (envelope-from ) id 1optkf-0003Ys-Sj; Tue, 01 Nov 2022 16:04:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435037.688019; Tue, 01 Nov 2022 16:04:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optkf-0003Yl-QB; Tue, 01 Nov 2022 16:04:33 +0000 Received: by outflank-mailman (input) for mailman id 435037; Tue, 01 Nov 2022 16:04:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optkd-0003Iv-R5 for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:04:31 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id de8dce0d-59fe-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 17:04:31 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C8C1822566; Tue, 1 Nov 2022 16:04:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 99B781346F; Tue, 1 Nov 2022 16:04:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yt4pJI5DYWMlcgAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:04:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de8dce0d-59fe-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667318670; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ClK+S4fe5XoEXGnmTytfGm/UdGaWd4a4uXnR/ciAATo=; b=WMGNJh12bIYiZ3wI7cv2gXwEYFjkKcD1gXNtYdWxfxaXL/kQI0nRODknx7zA9E/mJNMdWw AbYTfI8vpU9MlilXn7mveQ2OoEBHanYIDRq60xbbXbcQVTsV+HNrzd/AVWCfnPwYBicJr7 oLOfTYleBpgd/t4E6+CAHPOFD71dXfk= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 01/12] tools/xenstore: manage per-transaction domain accounting data in an array Date: Tue, 1 Nov 2022 17:04:11 +0100 Message-Id: <20221101160422.7212-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101160422.7212-1-jgross@suse.com> References: <20221101160422.7212-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to prepare keeping accounting data in an array instead of using independent fields, switch the struct changed_domain accounting data to that scheme, for now only using an array with one element. In order to be able to extend this scheme add the needed indexing enum to xenstored_domain.h. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_domain.c | 17 +++++++++-------- tools/xenstore/xenstored_domain.h | 5 +++++ 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 582b78b0ee..399fc920bb 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -99,8 +99,8 @@ struct changed_domain /* Identifier of the changed domain. */ unsigned int domid; - /* Amount by which this domain's nbentry field has changed. */ - int nbentry; + /* Accounting data. */ + int acc[ACC_TR_N]; }; static struct hashtable *domhash; @@ -558,7 +558,7 @@ int acc_fix_domains(struct list_head *head, bool update) int cnt; list_for_each_entry(cd, head, list) { - cnt = domain_nbentry_fix(cd->domid, cd->nbentry, update); + cnt = domain_nbentry_fix(cd->domid, cd->acc[ACC_NODES], update); if (!update) { if (cnt >= quota_nb_entry_per_domain) return ENOSPC; @@ -603,8 +603,8 @@ static struct changed_domain *acc_get_changed_domain(const void *ctx, return cd; } -static int acc_add_dom_nbentry(const void *ctx, struct list_head *head, int val, - unsigned int domid) +static int acc_add_changed_dom(const void *ctx, struct list_head *head, + unsigned int what, int val, unsigned int domid) { struct changed_domain *cd; @@ -613,9 +613,9 @@ static int acc_add_dom_nbentry(const void *ctx, struct list_head *head, int val, return 0; errno = 0; - cd->nbentry += val; + cd->acc[what] += val; - return cd->nbentry; + return cd->acc[what]; } static void domain_conn_reset(struct domain *domain) @@ -1076,7 +1076,8 @@ static int domain_nbentry_add(struct connection *conn, unsigned int domid, if (conn && conn->transaction) { head = transaction_get_changed_domains(conn->transaction); - ret = acc_add_dom_nbentry(conn->transaction, head, add, domid); + ret = acc_add_changed_dom(conn->transaction, head, ACC_NODES, + add, domid); if (errno) { fail_transaction(conn->transaction); return -1; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index dc4660861e..124b9e1b1e 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -19,6 +19,11 @@ #ifndef _XENSTORED_DOMAIN_H #define _XENSTORED_DOMAIN_H +enum { + ACC_NODES, + ACC_TR_N /* Number of elements per transaction and domain. */ +}; + void handle_event(void); void check_domains(void); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:04:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:04:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435038.688031 (Exim 4.92) (envelope-from ) id 1optkk-0003rH-8z; Tue, 01 Nov 2022 16:04:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435038.688031; Tue, 01 Nov 2022 16:04:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optkk-0003rA-5R; Tue, 01 Nov 2022 16:04:38 +0000 Received: by outflank-mailman (input) for mailman id 435038; Tue, 01 Nov 2022 16:04:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optkj-0003qE-Np for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:04:37 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e1e10eb0-59fe-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 17:04:36 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 608D722537; Tue, 1 Nov 2022 16:04:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3284A1346F; Tue, 1 Nov 2022 16:04:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id FaD6CpRDYWMycgAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:04:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1e10eb0-59fe-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667318676; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uACmj/0xjTQgTK11Nj7tD8GLil4Q1EMyFQ4FTisl410=; b=uj9PoVHih8X6+Qj6VH/DwWL2AaF+jbV6F7rDsIC7Wrng93xyqd1PKALhdxtngFvQjBs2f/ CO5e2/D1/HR+nmExURebiOErvwazI8xu0mVvczMlySOixcYn4zeIZRy2fR3xqH9j0lVUtY SlfuZUueJSi9PG3PgmQ/HdohGNjAxOA= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 02/12] tools/xenstore: introduce accounting data array for per-domain values Date: Tue, 1 Nov 2022 17:04:12 +0100 Message-Id: <20221101160422.7212-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101160422.7212-1-jgross@suse.com> References: <20221101160422.7212-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce the scheme of an accounting data array for per-domain accounting data and use it initially for the number of nodes owned by a domain. Make the accounting data type to be unsigned int, as no data is allowed to be negative at any time. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_domain.c | 55 ++++++++++++++++++++----------- tools/xenstore/xenstored_domain.h | 5 +-- 2 files changed, 38 insertions(+), 22 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 399fc920bb..9591a19189 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -69,8 +69,8 @@ struct domain /* Has domain been officially introduced? */ bool introduced; - /* number of entry from this domain in the store */ - int nbentry; + /* Accounting data for this domain. */ + unsigned int acc[ACC_N]; /* Amount of memory allocated for this domain. */ int memory; @@ -246,7 +246,7 @@ static int domain_tree_remove_sub(const void *ctx, struct connection *conn, if (keep_orphans) { set_tdb_key(node->name, &key); - domain->nbentry--; + domain_nbentry_dec(NULL, domain->domid); node->perms.p[0].id = priv_domid; node->acc.memory = 0; domain_nbentry_inc(NULL, priv_domid); @@ -270,7 +270,7 @@ static int domain_tree_remove_sub(const void *ctx, struct connection *conn, ret = WALK_TREE_SKIP_CHILDREN; } - return domain->nbentry > 0 ? ret : WALK_TREE_SUCCESS_STOP; + return domain->acc[ACC_NODES] ? ret : WALK_TREE_SUCCESS_STOP; } static void domain_tree_remove(struct domain *domain) @@ -278,7 +278,7 @@ static void domain_tree_remove(struct domain *domain) int ret; struct walk_funcs walkfuncs = { .enter = domain_tree_remove_sub }; - if (domain->nbentry > 0) { + if (domain->acc[ACC_NODES]) { ret = walk_node_tree(domain, NULL, "/", &walkfuncs, domain); if (ret == WALK_TREE_ERROR_STOP) syslog(LOG_ERR, @@ -441,7 +441,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, resp = talloc_asprintf_append(resp, "%-16s: %8d\n", #t, e); \ if (!resp) return ENOMEM - ent(nodes, d->nbentry); + ent(nodes, d->acc[ACC_NODES]); ent(watches, d->nbwatch); ent(transactions, ta); ent(outstanding, d->nboutstanding); @@ -1050,8 +1050,21 @@ int domain_adjust_node_perms(struct node *node) return 0; } -static int domain_nbentry_add(struct connection *conn, unsigned int domid, - int add, bool dom_exists) +static int domain_acc_add_chk(struct domain *d, unsigned int what, int add, + unsigned int domid) +{ + if ((add < 0 && -add > d->acc[what]) || + (d->acc[what] + add) > INT_MAX) { + syslog(LOG_ERR, "Accounting error: domain %u type %u val %u\n", + domid, what, d->acc[what] + add); + return (add < 0) ? 0 : INT_MAX; + } + + return d->acc[what] + add; +} + +static int domain_acc_add(struct connection *conn, unsigned int domid, + unsigned int what, int add, bool dom_exists) { struct domain *d; struct list_head *head; @@ -1074,47 +1087,49 @@ static int domain_nbentry_add(struct connection *conn, unsigned int domid, } } - if (conn && conn->transaction) { + if (conn && conn->transaction && what < ACC_TR_N) { head = transaction_get_changed_domains(conn->transaction); - ret = acc_add_changed_dom(conn->transaction, head, ACC_NODES, + ret = acc_add_changed_dom(conn->transaction, head, what, add, domid); if (errno) { fail_transaction(conn->transaction); return -1; } - return d->nbentry + ret; + return domain_acc_add_chk(d, what, ret, domid); } - d->nbentry += add; + d->acc[what] = domain_acc_add_chk(d, what, add, domid); - return d->nbentry; + return d->acc[what]; } int domain_nbentry_inc(struct connection *conn, unsigned int domid) { - return (domain_nbentry_add(conn, domid, 1, false) < 0) ? errno : 0; + return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) + ? errno : 0; } int domain_nbentry_dec(struct connection *conn, unsigned int domid) { - return (domain_nbentry_add(conn, domid, -1, true) < 0) ? errno : 0; + return (domain_acc_add(conn, domid, ACC_NODES, -1, true) < 0) + ? errno : 0; } int domain_nbentry_fix(unsigned int domid, int num, bool update) { int ret; - ret = domain_nbentry_add(NULL, domid, update ? num : 0, update); + ret = domain_acc_add(NULL, domid, ACC_NODES, update ? num : 0, update); if (ret < 0 || update) return ret; return domid_is_unprivileged(domid) ? ret + num : 0; } -int domain_nbentry(struct connection *conn) +unsigned int domain_nbentry(struct connection *conn) { return domain_is_unprivileged(conn) - ? domain_nbentry_add(conn, conn->id, 0, true) : 0; + ? domain_acc_add(conn, conn->id, ACC_NODES, 0, true) : 0; } static bool domain_chk_quota(struct domain *domain, int mem) @@ -1591,7 +1606,7 @@ static int domain_check_acc_init_sub(void *k, void *v, void *arg) * If everything is correct incrementing the value for each node will * result in dom->nodes being 0 at the end. */ - dom->nodes = -d->nbentry; + dom->nodes = -d->acc[ACC_NODES]; if (!hashtable_insert(domains, &dom->domid, dom)) { talloc_free(dom); @@ -1646,7 +1661,7 @@ static int domain_check_acc_sub(void *k, void *v, void *arg) if (!d) return 0; - d->nbentry += dom->nodes; + d->acc[ACC_NODES] += dom->nodes; return 0; } diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 124b9e1b1e..d2563d33e7 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -21,7 +21,8 @@ enum { ACC_NODES, - ACC_TR_N /* Number of elements per transaction and domain. */ + ACC_TR_N, /* Number of elements per transaction and domain. */ + ACC_N = ACC_TR_N /* Number of elements per domain. */ }; void handle_event(void); @@ -72,7 +73,7 @@ int domain_alloc_permrefs(struct node_perms *perms); int domain_nbentry_inc(struct connection *conn, unsigned int domid); int domain_nbentry_dec(struct connection *conn, unsigned int domid); int domain_nbentry_fix(unsigned int domid, int num, bool update); -int domain_nbentry(struct connection *conn); +unsigned int domain_nbentry(struct connection *conn); int domain_memory_add(unsigned int domid, int mem, bool no_quota_check); /* -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:04:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:04:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435039.688042 (Exim 4.92) (envelope-from ) id 1optkq-0004Ck-JH; Tue, 01 Nov 2022 16:04:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435039.688042; Tue, 01 Nov 2022 16:04:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optkq-0004Cb-Ei; Tue, 01 Nov 2022 16:04:44 +0000 Received: by outflank-mailman (input) for mailman id 435039; Tue, 01 Nov 2022 16:04:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optkp-0003Iv-1P for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:04:43 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e530adac-59fe-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 17:04:42 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E95211F8CA; Tue, 1 Nov 2022 16:04:41 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BEE201346F; Tue, 1 Nov 2022 16:04:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ZO9nLZlDYWNBcgAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:04:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e530adac-59fe-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667318681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k+yCodySqCz3qBnau8fT3yGc+modYKUB87SWoIcrsUE=; b=qLOvDUMdu/eNdUOlaVuZeksxGBpQy7T0s2ZoHdhSU+mP1cuepJC/vojdBUpunc/xzli7Qn kvrCi27DyXKX2ZwH3YWn41Mk4sOjGEQY9wlhdLXXs9yAKZ3IIRKsRO7n741jPdYi053M98 O26ySAu668YmT+PUDi0bk/1KpFO87v4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 03/12] tools/xenstore: add framework to commit accounting data on success only Date: Tue, 1 Nov 2022 17:04:13 +0100 Message-Id: <20221101160422.7212-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101160422.7212-1-jgross@suse.com> References: <20221101160422.7212-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of modifying accounting data and undo those modifications in case of an error during further processing, add a framework for collecting the needed changes and commit them only when the whole operation has succeeded. This scheme can reuse large parts of the per transaction accounting. The changed_domain handling can be reused, but the array size of the accounting data should be possible to be different for both use cases. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 5 +++ tools/xenstore/xenstored_core.h | 3 ++ tools/xenstore/xenstored_domain.c | 61 ++++++++++++++++++++++++++++--- tools/xenstore/xenstored_domain.h | 5 ++- 4 files changed, 67 insertions(+), 7 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index ea0e6292d3..d437149622 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -1027,6 +1027,9 @@ static void send_error(struct connection *conn, int error) break; } } + + acc_drop(conn); + send_reply(conn, XS_ERROR, xsd_errors[i].errstring, strlen(xsd_errors[i].errstring) + 1); } @@ -1064,6 +1067,7 @@ void send_reply(struct connection *conn, enum xsd_sockmsg_type type, } conn->in = NULL; + acc_commit(conn); /* Update relevant header fields and fill in the message body. */ bdata->hdr.msg.type = type; @@ -2186,6 +2190,7 @@ struct connection *new_connection(const struct interface_funcs *funcs) new->is_stalled = false; new->transaction_started = 0; INIT_LIST_HEAD(&new->out_list); + INIT_LIST_HEAD(&new->acc_list); INIT_LIST_HEAD(&new->ref_list); INIT_LIST_HEAD(&new->watches); INIT_LIST_HEAD(&new->transaction_list); diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index c85b15515c..8223a49354 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -139,6 +139,9 @@ struct connection struct list_head out_list; uint64_t timeout_msec; + /* Not yet committed accounting data (valid if in != NULL). */ + struct list_head acc_list; + /* Referenced requests no longer pending. */ struct list_head ref_list; diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 9591a19189..7988125f71 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -100,7 +100,7 @@ struct changed_domain unsigned int domid; /* Accounting data. */ - int acc[ACC_TR_N]; + int acc[]; }; static struct hashtable *domhash; @@ -585,6 +585,7 @@ static struct changed_domain *acc_find_changed_domain(struct list_head *head, static struct changed_domain *acc_get_changed_domain(const void *ctx, struct list_head *head, + unsigned int acc_sz, unsigned int domid) { struct changed_domain *cd; @@ -593,7 +594,7 @@ static struct changed_domain *acc_get_changed_domain(const void *ctx, if (cd) return cd; - cd = talloc_zero(ctx, struct changed_domain); + cd = talloc_zero_size(ctx, sizeof(*cd) + acc_sz * sizeof(cd->acc[0])); if (!cd) return NULL; @@ -604,11 +605,12 @@ static struct changed_domain *acc_get_changed_domain(const void *ctx, } static int acc_add_changed_dom(const void *ctx, struct list_head *head, - unsigned int what, int val, unsigned int domid) + unsigned int acc_sz, unsigned int what, + int val, unsigned int domid) { struct changed_domain *cd; - cd = acc_get_changed_domain(ctx, head, domid); + cd = acc_get_changed_domain(ctx, head, acc_sz, domid); if (!cd) return 0; @@ -1067,6 +1069,7 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, unsigned int what, int add, bool dom_exists) { struct domain *d; + struct changed_domain *cd; struct list_head *head; int ret; @@ -1087,10 +1090,26 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, } } + /* Temporary accounting data until final commit? */ + if (conn && conn->in && what < ACC_REQ_N) { + /* Consider transaction local data. */ + ret = 0; + if (conn->transaction && what < ACC_TR_N) { + head = transaction_get_changed_domains( + conn->transaction); + cd = acc_find_changed_domain(head, domid); + if (cd) + ret = cd->acc[what]; + } + ret += acc_add_changed_dom(conn->in, &conn->acc_list, ACC_REQ_N, + what, add, domid); + return errno ? -1 : domain_acc_add_chk(d, what, ret, domid); + } + if (conn && conn->transaction && what < ACC_TR_N) { head = transaction_get_changed_domains(conn->transaction); - ret = acc_add_changed_dom(conn->transaction, head, what, - add, domid); + ret = acc_add_changed_dom(conn->transaction, head, ACC_TR_N, + what, add, domid); if (errno) { fail_transaction(conn->transaction); return -1; @@ -1103,6 +1122,36 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, return d->acc[what]; } +void acc_drop(struct connection *conn) +{ + struct changed_domain *cd; + + while ((cd = list_top(&conn->acc_list, struct changed_domain, list))) { + list_del(&cd->list); + talloc_free(cd); + } +} + +void acc_commit(struct connection *conn) +{ + struct changed_domain *cd; + struct buffered_data *in = conn->in; + unsigned int what; + + conn->in = NULL; /* Avoid recursion. */ + while ((cd = list_top(&conn->acc_list, struct changed_domain, list))) { + list_del(&cd->list); + for (what = 0; what < ACC_REQ_N; what++) + if (cd->acc[what]) + domain_acc_add(conn, cd->domid, what, + cd->acc[what], true); + + talloc_free(cd); + } + + conn->in = in; +} + int domain_nbentry_inc(struct connection *conn, unsigned int domid) { return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index d2563d33e7..9959b2f2e4 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -20,7 +20,8 @@ #define _XENSTORED_DOMAIN_H enum { - ACC_NODES, + ACC_REQ_N, /* Number of elements per request and domain. */ + ACC_NODES = ACC_REQ_N, ACC_TR_N, /* Number of elements per transaction and domain. */ ACC_N = ACC_TR_N /* Number of elements per domain. */ }; @@ -103,6 +104,8 @@ void domain_outstanding_domid_dec(unsigned int domid); int domain_get_quota(const void *ctx, struct connection *conn, unsigned int domid); int acc_fix_domains(struct list_head *head, bool update); +void acc_drop(struct connection *conn); +void acc_commit(struct connection *conn); /* Write rate limiting */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:04:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:04:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435040.688052 (Exim 4.92) (envelope-from ) id 1optkv-0004bL-QR; Tue, 01 Nov 2022 16:04:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435040.688052; Tue, 01 Nov 2022 16:04:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optkv-0004bC-N6; Tue, 01 Nov 2022 16:04:49 +0000 Received: by outflank-mailman (input) for mailman id 435040; Tue, 01 Nov 2022 16:04:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optku-0003Iv-Co for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:04:48 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e8823555-59fe-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 17:04:47 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7F0B61F8CA; Tue, 1 Nov 2022 16:04:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 522971346F; Tue, 1 Nov 2022 16:04:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ivTHEp9DYWNLcgAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:04:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8823555-59fe-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667318687; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6FDt15mfZEArmZvoJOo527N0gTwrSVu9AiSo1IvcHbc=; b=OBcPfXbw3m0lmkiUREpm5sJR19ZG/eacbsBhCZcnY8iexXdGYYqawa9dUTtz+/8rbhWov1 jF5bHeVmyybe+d6pQEHVYFf4zJlygeMK/dl22cEIpWFBOcRQqEsyd7BPs5zrKIYvlzwEI9 UX7+V6eyWAg6OajcKpEZkAuh/SwNk8k= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 04/12] tools/xenstore: use accounting buffering for node accounting Date: Tue, 1 Nov 2022 17:04:14 +0100 Message-Id: <20221101160422.7212-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101160422.7212-1-jgross@suse.com> References: <20221101160422.7212-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the node accounting to the accounting information buffering in order to avoid having to undo it in case of failure. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 21 ++------------------- tools/xenstore/xenstored_domain.h | 4 ++-- 2 files changed, 4 insertions(+), 21 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index d437149622..7bf56b4d38 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -1442,7 +1442,6 @@ static void destroy_node_rm(struct connection *conn, struct node *node) static int destroy_node(struct connection *conn, struct node *node) { destroy_node_rm(conn, node); - domain_nbentry_dec(conn, node->perms.p[0].id); /* * It is not possible to easily revert the changes in a transaction. @@ -1788,27 +1787,11 @@ static int do_set_perms(const void *ctx, struct connection *conn, old_perms = node->perms; domain_nbentry_dec(conn, node->perms.p[0].id); node->perms = perms; - if (domain_nbentry_inc(conn, node->perms.p[0].id)) { - node->perms = old_perms; - /* - * This should never fail because we had a reference on the - * domain before and Xenstored is single-threaded. - */ - domain_nbentry_inc(conn, node->perms.p[0].id); + if (domain_nbentry_inc(conn, node->perms.p[0].id)) return ENOMEM; - } - if (write_node(conn, node, false)) { - int saved_errno = errno; - - domain_nbentry_dec(conn, node->perms.p[0].id); - node->perms = old_perms; - /* No failure possible as above. */ - domain_nbentry_inc(conn, node->perms.p[0].id); - - errno = saved_errno; + if (write_node(conn, node, false)) return errno; - } fire_watches(conn, ctx, name, node, false, &old_perms); send_ack(conn, XS_SET_PERMS); diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 9959b2f2e4..ead3893fc1 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -20,9 +20,9 @@ #define _XENSTORED_DOMAIN_H enum { + ACC_NODES, ACC_REQ_N, /* Number of elements per request and domain. */ - ACC_NODES = ACC_REQ_N, - ACC_TR_N, /* Number of elements per transaction and domain. */ + ACC_TR_N = ACC_REQ_N, /* Number of elements per transaction and domain. */ ACC_N = ACC_TR_N /* Number of elements per domain. */ }; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:04:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:04:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435043.688064 (Exim 4.92) (envelope-from ) id 1optl2-00057x-4a; Tue, 01 Nov 2022 16:04:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435043.688064; Tue, 01 Nov 2022 16:04:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optl2-00057l-0B; Tue, 01 Nov 2022 16:04:56 +0000 Received: by outflank-mailman (input) for mailman id 435043; Tue, 01 Nov 2022 16:04:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optl0-0003Iv-5z for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:04:54 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ebd36167-59fe-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 17:04:53 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 14A7522596; Tue, 1 Nov 2022 16:04:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DBD221346F; Tue, 1 Nov 2022 16:04:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GnhUNKRDYWNTcgAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:04:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebd36167-59fe-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667318693; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qf00sJCUn8cU2FKlLsp6pVr2UdbMy6ENU4LwBge1Np0=; b=hdulCi7uTtTnAszmoYhK0f/1OtmncZ4daLLxDHNKt/jg9OBRsVIPXqUdpeB4uvXcDXGIQ3 7a4k+eKsRPEtt6U/H695wIHSIPY5zP8rY1htNucTJr4Ng4Isq/nauUubWzZCTY5SRxLn0A mMcUsVU99orEBOipxZvbaKjPcgZjWY4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 05/12] tools/xenstore: add current connection to domain_memory_add() parameters Date: Tue, 1 Nov 2022 17:04:15 +0100 Message-Id: <20221101160422.7212-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101160422.7212-1-jgross@suse.com> References: <20221101160422.7212-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to enable switching memory accounting to the generic array based accounting, add the current connection to the parameters of domain_memory_add(). This requires to add the connection to some other functions, too. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 28 ++++++++++++++++------------ tools/xenstore/xenstored_domain.c | 3 ++- tools/xenstore/xenstored_domain.h | 14 +++++++++----- tools/xenstore/xenstored_watch.c | 11 ++++++----- 4 files changed, 33 insertions(+), 23 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 7bf56b4d38..8b8900b77c 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -246,7 +246,8 @@ static void free_buffered_data(struct buffered_data *out, } } - domain_memory_add_nochk(conn->id, -out->hdr.msg.len - sizeof(out->hdr)); + domain_memory_add_nochk(conn, conn->id, + -out->hdr.msg.len - sizeof(out->hdr)); if (out->hdr.msg.type == XS_WATCH_EVENT) { req = out->pend.req; @@ -631,24 +632,25 @@ int do_tdb_write(struct connection *conn, TDB_DATA *key, TDB_DATA *data, * nodes to new owners. */ if (old_acc.memory) - domain_memory_add_nochk(old_domid, + domain_memory_add_nochk(conn, old_domid, -old_acc.memory - key->dsize); - ret = domain_memory_add(new_domid, data->dsize + key->dsize, - no_quota_check); + ret = domain_memory_add(conn, new_domid, + data->dsize + key->dsize, no_quota_check); if (ret) { /* Error path, so no quota check. */ if (old_acc.memory) - domain_memory_add_nochk(old_domid, + domain_memory_add_nochk(conn, old_domid, old_acc.memory + key->dsize); return ret; } /* TDB should set errno, but doesn't even set ecode AFAICT. */ if (tdb_store(tdb_ctx, *key, *data, TDB_REPLACE) != 0) { - domain_memory_add_nochk(new_domid, -data->dsize - key->dsize); + domain_memory_add_nochk(conn, new_domid, + -data->dsize - key->dsize); /* Error path, so no quota check. */ if (old_acc.memory) - domain_memory_add_nochk(old_domid, + domain_memory_add_nochk(conn, old_domid, old_acc.memory + key->dsize); errno = EIO; return errno; @@ -683,7 +685,7 @@ int do_tdb_delete(struct connection *conn, TDB_DATA *key, if (acc->memory) { domid = get_acc_domid(conn, key, acc->domid); - domain_memory_add_nochk(domid, -acc->memory - key->dsize); + domain_memory_add_nochk(conn, domid, -acc->memory - key->dsize); } return 0; @@ -1056,11 +1058,13 @@ void send_reply(struct connection *conn, enum xsd_sockmsg_type type, if (len <= DEFAULT_BUFFER_SIZE) { bdata->buffer = bdata->default_buffer; /* Don't check quota, path might be used for returning error. */ - domain_memory_add_nochk(conn->id, len + sizeof(bdata->hdr)); + domain_memory_add_nochk(conn, conn->id, + len + sizeof(bdata->hdr)); } else { bdata->buffer = talloc_array(bdata, char, len); if (!bdata->buffer || - domain_memory_add_chk(conn->id, len + sizeof(bdata->hdr))) { + domain_memory_add_chk(conn, conn->id, + len + sizeof(bdata->hdr))) { send_error(conn, ENOMEM); return; } @@ -1126,7 +1130,7 @@ void send_event(struct buffered_data *req, struct connection *conn, } } - if (domain_memory_add_chk(conn->id, len + sizeof(bdata->hdr))) { + if (domain_memory_add_chk(conn, conn->id, len + sizeof(bdata->hdr))) { talloc_free(bdata); return; } @@ -3287,7 +3291,7 @@ static void add_buffered_data(struct buffered_data *bdata, * be smaller. So ignore it. The limit will be applied for any resource * after the state has been fully restored. */ - domain_memory_add_nochk(conn->id, len + sizeof(bdata->hdr)); + domain_memory_add_nochk(conn, conn->id, len + sizeof(bdata->hdr)); } void read_state_buffered_data(const void *ctx, struct connection *conn, diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 7988125f71..1407ff9e36 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -1230,7 +1230,8 @@ static bool domain_chk_quota(struct domain *domain, int mem) return false; } -int domain_memory_add(unsigned int domid, int mem, bool no_quota_check) +int domain_memory_add(struct connection *conn, unsigned int domid, int mem, + bool no_quota_check) { struct domain *domain; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index ead3893fc1..565b47b17b 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -75,25 +75,29 @@ int domain_nbentry_inc(struct connection *conn, unsigned int domid); int domain_nbentry_dec(struct connection *conn, unsigned int domid); int domain_nbentry_fix(unsigned int domid, int num, bool update); unsigned int domain_nbentry(struct connection *conn); -int domain_memory_add(unsigned int domid, int mem, bool no_quota_check); +int domain_memory_add(struct connection *conn, unsigned int domid, int mem, + bool no_quota_check); /* * domain_memory_add_chk(): to be used when memory quota should be checked. * Not to be used when specifying a negative mem value, as lowering the used * memory should always be allowed. */ -static inline int domain_memory_add_chk(unsigned int domid, int mem) +static inline int domain_memory_add_chk(struct connection *conn, + unsigned int domid, int mem) { - return domain_memory_add(domid, mem, false); + return domain_memory_add(conn, domid, mem, false); } + /* * domain_memory_add_nochk(): to be used when memory quota should not be * checked, e.g. when lowering memory usage, or in an error case for undoing * a previous memory adjustment. */ -static inline void domain_memory_add_nochk(unsigned int domid, int mem) +static inline void domain_memory_add_nochk(struct connection *conn, + unsigned int domid, int mem) { - domain_memory_add(domid, mem, true); + domain_memory_add(conn, domid, mem, true); } void domain_watch_inc(struct connection *conn); void domain_watch_dec(struct connection *conn); diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index 8bed967c56..ed742de936 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -199,7 +199,7 @@ static struct watch *add_watch(struct connection *conn, char *path, char *token, watch->token = talloc_strdup(watch, token); if (!watch->node || !watch->token) goto nomem; - if (domain_memory_add(conn->id, strlen(path) + strlen(token), + if (domain_memory_add(conn, conn->id, strlen(path) + strlen(token), no_quota_check)) goto nomem; @@ -274,8 +274,9 @@ int do_unwatch(const void *ctx, struct connection *conn, list_for_each_entry(watch, &conn->watches, list) { if (streq(watch->node, node) && streq(watch->token, vec[1])) { list_del(&watch->list); - domain_memory_add_nochk(conn->id, -strlen(watch->node) - - strlen(watch->token)); + domain_memory_add_nochk(conn, conn->id, + -strlen(watch->node) - + strlen(watch->token)); talloc_free(watch); domain_watch_dec(conn); send_ack(conn, XS_UNWATCH); @@ -291,8 +292,8 @@ void conn_delete_all_watches(struct connection *conn) while ((watch = list_top(&conn->watches, struct watch, list))) { list_del(&watch->list); - domain_memory_add_nochk(conn->id, -strlen(watch->node) - - strlen(watch->token)); + domain_memory_add_nochk(conn, conn->id, -strlen(watch->node) - + strlen(watch->token)); talloc_free(watch); domain_watch_dec(conn); } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:05:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:05:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435050.688075 (Exim 4.92) (envelope-from ) id 1optl7-0005dG-IK; Tue, 01 Nov 2022 16:05:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435050.688075; Tue, 01 Nov 2022 16:05:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optl7-0005d1-EP; Tue, 01 Nov 2022 16:05:01 +0000 Received: by outflank-mailman (input) for mailman id 435050; Tue, 01 Nov 2022 16:05:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optl6-0003qE-Hh for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:05:00 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef24b16f-59fe-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 17:04:58 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9FC0C225B2; Tue, 1 Nov 2022 16:04:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 744B31346F; Tue, 1 Nov 2022 16:04:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KboXG6pDYWNXcgAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:04:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef24b16f-59fe-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667318698; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7vX06iot/jRh0KmEBI3quz+d8jYTOyvXE2YRmnqLSRs=; b=PC0WXAhF8kSh9wd8H8fXBg8r06PyMz/pWBW4ErY1m+NNfOyJUsnTgFf7ToZFvipTBY6/3W BAeF3S2d7gNdx1TlbvJjSEutukEsk6sI4e6GMPb/6/zJ+pn5nh8na+ceGZ294D4LVY6Brq KosNKnN6Ijjt1zzrH9P3xBqRmz8W0cg= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 06/12] tools/xenstore: use accounting data array for per-domain values Date: Tue, 1 Nov 2022 17:04:16 +0100 Message-Id: <20221101160422.7212-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101160422.7212-1-jgross@suse.com> References: <20221101160422.7212-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the accounting of per-domain usage of Xenstore memory, watches, and outstanding requests to the array based mechanism. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 8 +-- tools/xenstore/xenstored_domain.c | 111 +++++++++++------------------- tools/xenstore/xenstored_domain.h | 10 +-- 3 files changed, 52 insertions(+), 77 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 8b8900b77c..7bd83a0eaf 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -255,7 +255,7 @@ static void free_buffered_data(struct buffered_data *out, req->pend.ref.event_cnt--; if (!req->pend.ref.event_cnt && !req->on_out_list) { if (req->on_ref_list) { - domain_outstanding_domid_dec( + domain_outstanding_dec(conn, req->pend.ref.domid); list_del(&req->list); } @@ -271,7 +271,7 @@ static void free_buffered_data(struct buffered_data *out, out->on_ref_list = true; return; } else - domain_outstanding_dec(conn); + domain_outstanding_dec(conn, conn->id); talloc_free(out); } @@ -1081,7 +1081,7 @@ void send_reply(struct connection *conn, enum xsd_sockmsg_type type, /* Queue for later transmission. */ list_add_tail(&bdata->list, &conn->out_list); bdata->on_out_list = true; - domain_outstanding_inc(conn); + domain_outstanding_inc(conn, conn->id); } /* @@ -3285,7 +3285,7 @@ static void add_buffered_data(struct buffered_data *bdata, * request have been delivered. */ if (bdata->hdr.msg.type != XS_WATCH_EVENT) - domain_outstanding_inc(conn); + domain_outstanding_inc(conn, conn->id); /* * We are restoring the state after Live-Update and the new quota may * be smaller. So ignore it. The limit will be applied for any resource diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 1407ff9e36..cb2a78b597 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -72,19 +72,12 @@ struct domain /* Accounting data for this domain. */ unsigned int acc[ACC_N]; - /* Amount of memory allocated for this domain. */ - int memory; + /* Memory quota data for this domain. */ bool soft_quota_reported; bool hard_quota_reported; time_t mem_last_msg; #define MEM_WARN_MINTIME_SEC 10 - /* number of watch for this domain */ - int nbwatch; - - /* Number of outstanding requests. */ - int nboutstanding; - /* write rate limit */ wrl_creditt wrl_credit; /* [ -wrl_config_writecost, +_dburst ] */ struct wrl_timestampt wrl_timestamp; @@ -200,14 +193,15 @@ static bool domain_can_write(struct connection *conn) static bool domain_can_read(struct connection *conn) { - struct xenstore_domain_interface *intf = conn->domain->interface; + struct domain *domain = conn->domain; + struct xenstore_domain_interface *intf = domain->interface; if (domain_is_unprivileged(conn)) { - if (conn->domain->wrl_credit < 0) + if (domain->wrl_credit < 0) return false; - if (conn->domain->nboutstanding >= quota_req_outstanding) + if (domain->acc[ACC_OUTST] >= quota_req_outstanding) return false; - if (conn->domain->memory >= quota_memory_per_domain_hard && + if (domain->acc[ACC_MEM] >= quota_memory_per_domain_hard && quota_memory_per_domain_hard) return false; } @@ -442,10 +436,10 @@ int domain_get_quota(const void *ctx, struct connection *conn, if (!resp) return ENOMEM ent(nodes, d->acc[ACC_NODES]); - ent(watches, d->nbwatch); + ent(watches, d->acc[ACC_WATCH]); ent(transactions, ta); - ent(outstanding, d->nboutstanding); - ent(memory, d->memory); + ent(outstanding, d->acc[ACC_OUTST]); + ent(memory, d->acc[ACC_MEM]); #undef ent @@ -1181,14 +1175,16 @@ unsigned int domain_nbentry(struct connection *conn) ? domain_acc_add(conn, conn->id, ACC_NODES, 0, true) : 0; } -static bool domain_chk_quota(struct domain *domain, int mem) +static bool domain_chk_quota(struct connection *conn, unsigned int mem) { time_t now; + struct domain *domain; - if (!domain || !domid_is_unprivileged(domain->domid) || - (domain->conn && domain->conn->is_ignored)) + if (!conn || !domid_is_unprivileged(conn->id) || + conn->is_ignored) return false; + domain = conn->domain; now = time(NULL); if (mem >= quota_memory_per_domain_hard && @@ -1233,80 +1229,57 @@ static bool domain_chk_quota(struct domain *domain, int mem) int domain_memory_add(struct connection *conn, unsigned int domid, int mem, bool no_quota_check) { - struct domain *domain; + int ret; - domain = find_domain_struct(domid); - if (domain) { - /* - * domain_chk_quota() will print warning and also store whether - * the soft/hard quota has been hit. So check no_quota_check - * *after*. - */ - if (domain_chk_quota(domain, domain->memory + mem) && - !no_quota_check) - return ENOMEM; - domain->memory += mem; - } else { - /* - * The domain the memory is to be accounted for should always - * exist, as accounting is done either for a domain related to - * the current connection, or for the domain owning a node - * (which is always existing, as the owner of the node is - * tested to exist and deleted or replaced by domid 0 if not). - * So not finding the related domain MUST be an error in the - * data base. - */ - errno = ENOENT; - corrupt(NULL, "Accounting called for non-existing domain %u\n", - domid); - return ENOENT; - } + ret = domain_acc_add(conn, domid, ACC_MEM, 0, true); + if (ret < 0) + return -ret; + + /* + * domain_chk_quota() will print warning and also store whether the + * soft/hard quota has been hit. So check no_quota_check *after*. + */ + if (domain_chk_quota(conn, ret + mem) && !no_quota_check) + return ENOMEM; + + /* + * The domain the memory is to be accounted for should always exist, + * as accounting is done either for a domain related to the current + * connection, or for the domain owning a node (which is always + * existing, as the owner of the node is tested to exist and deleted + * or replaced by domid 0 if not). + * So not finding the related domain MUST be an error in the data base. + */ + domain_acc_add(conn, domid, ACC_MEM, mem, true); return 0; } void domain_watch_inc(struct connection *conn) { - if (!conn || !conn->domain) - return; - conn->domain->nbwatch++; + domain_acc_add(conn, conn->id, ACC_WATCH, 1, true); } void domain_watch_dec(struct connection *conn) { - if (!conn || !conn->domain) - return; - if (conn->domain->nbwatch) - conn->domain->nbwatch--; + domain_acc_add(conn, conn->id, ACC_WATCH, -1, true); } int domain_watch(struct connection *conn) { return (domain_is_unprivileged(conn)) - ? conn->domain->nbwatch + ? domain_acc_add(conn, conn->id, ACC_WATCH, 0, true) : 0; } -void domain_outstanding_inc(struct connection *conn) +void domain_outstanding_inc(struct connection *conn, unsigned int domid) { - if (!conn || !conn->domain) - return; - conn->domain->nboutstanding++; + domain_acc_add(conn, domid, ACC_OUTST, 1, true); } -void domain_outstanding_dec(struct connection *conn) +void domain_outstanding_dec(struct connection *conn, unsigned int domid) { - if (!conn || !conn->domain) - return; - conn->domain->nboutstanding--; -} - -void domain_outstanding_domid_dec(unsigned int domid) -{ - struct domain *d = find_domain_by_domid(domid); - - if (d) - d->nboutstanding--; + domain_acc_add(conn, domid, ACC_OUTST, -1, true); } static wrl_creditt wrl_config_writecost = WRL_FACTOR; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 565b47b17b..91db3342c4 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -23,7 +23,10 @@ enum { ACC_NODES, ACC_REQ_N, /* Number of elements per request and domain. */ ACC_TR_N = ACC_REQ_N, /* Number of elements per transaction and domain. */ - ACC_N = ACC_TR_N /* Number of elements per domain. */ + ACC_WATCH = ACC_TR_N, + ACC_OUTST, + ACC_MEM, + ACC_N /* Number of elements per domain. */ }; void handle_event(void); @@ -102,9 +105,8 @@ static inline void domain_memory_add_nochk(struct connection *conn, void domain_watch_inc(struct connection *conn); void domain_watch_dec(struct connection *conn); int domain_watch(struct connection *conn); -void domain_outstanding_inc(struct connection *conn); -void domain_outstanding_dec(struct connection *conn); -void domain_outstanding_domid_dec(unsigned int domid); +void domain_outstanding_inc(struct connection *conn, unsigned int domid); +void domain_outstanding_dec(struct connection *conn, unsigned int domid); int domain_get_quota(const void *ctx, struct connection *conn, unsigned int domid); int acc_fix_domains(struct list_head *head, bool update); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:05:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:05:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435051.688086 (Exim 4.92) (envelope-from ) id 1optlC-0006AS-Sf; Tue, 01 Nov 2022 16:05:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435051.688086; Tue, 01 Nov 2022 16:05:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optlC-0006AH-OV; Tue, 01 Nov 2022 16:05:06 +0000 Received: by outflank-mailman (input) for mailman id 435051; Tue, 01 Nov 2022 16:05:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optlB-0003Iv-3U for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:05:05 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f272fb8f-59fe-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 17:05:04 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 32067225A4; Tue, 1 Nov 2022 16:05:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 09D721346F; Tue, 1 Nov 2022 16:05:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wBs4AbBDYWNscgAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:05:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f272fb8f-59fe-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667318704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pLiRR0HBtiamzqwHIKj4WOLeWu1RXT2UzX7ss3KrLTA=; b=nuqhTHY6cfBGrDX1oNGxGEioxVSe59cEhTzjpZyRyj647EtN9moepmFnXlUcFvwV3zbSPr 8pLi6DXUvjiycifxvRsy39jxSf0Xs7dOjvL3wAbaHVGUgX9IEdr5jeTpuYXgyWyXvrrmZF 61S8l7QC8vFF5r34cLi0tTppF8/n3oU= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 07/12] tools/xenstore: add accounting trace support Date: Tue, 1 Nov 2022 17:04:17 +0100 Message-Id: <20221101160422.7212-8-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101160422.7212-1-jgross@suse.com> References: <20221101160422.7212-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a new trace switch "acc" and the related trace calls. The "acc" switch is off per default. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 2 +- tools/xenstore/xenstored_core.h | 1 + tools/xenstore/xenstored_domain.c | 10 ++++++++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 7bd83a0eaf..be3c2aba77 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2737,7 +2737,7 @@ static void set_quota(const char *arg, bool soft) /* Sorted by bit values of TRACE_* flags. Flag is (1u << index). */ const char *trace_switches[] = { - "obj", "io", "wrl", + "obj", "io", "wrl", "acc", NULL }; diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 8223a49354..e17bd4c268 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -294,6 +294,7 @@ extern unsigned int trace_flags; #define TRACE_OBJ 0x00000001 #define TRACE_IO 0x00000002 #define TRACE_WRL 0x00000004 +#define TRACE_ACC 0x00000008 extern const char *trace_switches[]; int set_trace_switch(const char *arg); diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index cb2a78b597..2420fbff31 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -546,6 +546,12 @@ static struct domain *find_domain_by_domid(unsigned int domid) return (d && d->introduced) ? d : NULL; } +#define trace_acc(...) \ +do { \ + if (trace_flags & TRACE_ACC) \ + trace("acc: " __VA_ARGS__); \ +} while (0) + int acc_fix_domains(struct list_head *head, bool update) { struct changed_domain *cd; @@ -609,6 +615,8 @@ static int acc_add_changed_dom(const void *ctx, struct list_head *head, return 0; errno = 0; + trace_acc("local change domid %u: what=%u %d add %d\n", domid, what, + cd->acc[what], val); cd->acc[what] += val; return cd->acc[what]; @@ -1111,6 +1119,8 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, return domain_acc_add_chk(d, what, ret, domid); } + trace_acc("global change domid %u: what=%u %u add %d\n", domid, what, + d->acc[what], add); d->acc[what] = domain_acc_add_chk(d, what, add, domid); return d->acc[what]; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:15:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:15:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435064.688097 (Exim 4.92) (envelope-from ) id 1optuo-0000iI-PB; Tue, 01 Nov 2022 16:15:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435064.688097; Tue, 01 Nov 2022 16:15:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optuo-0000iB-Ls; Tue, 01 Nov 2022 16:15:02 +0000 Received: by outflank-mailman (input) for mailman id 435064; Tue, 01 Nov 2022 16:15:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optun-0000i5-EW for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:15:01 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55b01a07-5a00-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 17:15:00 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0596D1F8CA; Tue, 1 Nov 2022 16:15:00 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CA3621346F; Tue, 1 Nov 2022 16:14:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id c2X4LwNGYWPndgAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:14:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55b01a07-5a00-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667319300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3vvEwjmy3y2freXdh/Vxr98T44RB5swrhH94wA9YUTQ=; b=WEt0KZ68IRo5Lo00mV0sHSFbbeOhYgJsrJvmrKer9qNjr12hHIYf5mrhVtgCP1NvJIqWP+ VF4sEQFkK5C7+/9eDjd66o6dgXk/Zsr9gtsmlgSz6nrt5pSTjewC30JMQPetzYIm9AV3LT srxsWGCWMvoPoiILYurVA4RezMahSQ8= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 00/10] tools/xenstore: more cleanups Date: Tue, 1 Nov 2022 17:14:47 +0100 Message-Id: <20221101161457.8470-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Some more cleanups of Xenstore. Based on top of the previous 2 Xenstore series "tools/xenstore: do some cleanup and fixes" and the accounting rework series (sorry for the cut off series header). Juergen Gross (10): tools/xenstore: verify command line parameters better tools/xenstore: do some cleanup of hashtable.c tools/xenstore: modify interface of create_hashtable() tools/xenstore: let hashtable_insert() return 0 on success tools/xenstore: make some write limit functions static tools/xenstore: switch write limiting to use millisecond time base tools/xenstore: remove stale TODO file tools/xenstore: remove unused events list tools/xenstore: remove support of file backed data base tools/xenstore: remove no longer needed functions from xs_lib.c tools/libs/store/xs.c | 20 ++ tools/xenstore/Makefile | 5 +- tools/xenstore/TODO | 10 - tools/xenstore/hashtable.c | 101 +++--- tools/xenstore/hashtable.h | 16 +- tools/xenstore/xenstore_client.c | 129 +++++++ tools/xenstore/xenstored_core.c | 51 +-- tools/xenstore/xenstored_core.h | 7 +- tools/xenstore/xenstored_domain.c | 458 ++++++++++++------------- tools/xenstore/xenstored_domain.h | 24 +- tools/xenstore/xenstored_transaction.c | 4 +- tools/xenstore/xenstored_watch.c | 5 - tools/xenstore/xs_lib.c | 138 -------- tools/xenstore/xs_lib.h | 17 - tools/xenstore/xs_tdb_dump.c | 86 ----- 15 files changed, 442 insertions(+), 629 deletions(-) delete mode 100644 tools/xenstore/TODO delete mode 100644 tools/xenstore/xs_tdb_dump.c -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:15:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:15:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435065.688108 (Exim 4.92) (envelope-from ) id 1optuv-0000zR-1F; Tue, 01 Nov 2022 16:15:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435065.688108; Tue, 01 Nov 2022 16:15:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optuu-0000zG-UD; Tue, 01 Nov 2022 16:15:08 +0000 Received: by outflank-mailman (input) for mailman id 435065; Tue, 01 Nov 2022 16:15:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optus-0000yH-Ny for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:15:06 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 58e3f89c-5a00-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 17:15:05 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 871D51F90F; Tue, 1 Nov 2022 16:15:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 600101346F; Tue, 1 Nov 2022 16:15:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mTP/FQlGYWMPdwAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:15:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58e3f89c-5a00-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667319305; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SRXNQDO4MhG9H32yh0qBaLPCvnVGtf7v3eYM21ANcnk=; b=uE2UvseLH5K44Hrqi7TWdLTAcE5uiNIIixn9OviwEQVluWQGHv5wkD7r7O20R4TuQjPElQ cCsFuXRC8LPqau/1IXWJsksgLf6VhHAFrywyThJsId+1dp5vL6DGo5vCz8R8pw2QitTiQB Zi1wM+hn6U2EbKVhn4G6iMPIIUSR19g= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 01/10] tools/xenstore: verify command line parameters better Date: Tue, 1 Nov 2022 17:14:48 +0100 Message-Id: <20221101161457.8470-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101161457.8470-1-jgross@suse.com> References: <20221101161457.8470-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add some more verification of command line parameters. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index ae1ea29b80..714841d9ca 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2790,7 +2790,7 @@ int main(int argc, char *argv[]) no_domain_init = true; break; case 'E': - hard_quotas[ACC_NODES].val = strtoul(optarg, NULL, 10); + hard_quotas[ACC_NODES].val = get_optval_int(optarg); break; case 'F': pidfile = optarg; @@ -2808,10 +2808,10 @@ int main(int argc, char *argv[]) recovery = false; break; case 'S': - hard_quotas[ACC_NODESZ].val = strtoul(optarg, NULL, 10); + hard_quotas[ACC_NODESZ].val = get_optval_int(optarg); break; case 't': - hard_quotas[ACC_TRANS].val = strtoul(optarg, NULL, 10); + hard_quotas[ACC_TRANS].val = get_optval_int(optarg); break; case 'T': tracefile = optarg; @@ -2830,14 +2830,13 @@ int main(int argc, char *argv[]) verbose = true; break; case 'W': - hard_quotas[ACC_WATCH].val = strtoul(optarg, NULL, 10); + hard_quotas[ACC_WATCH].val = get_optval_int(optarg); break; case 'A': - hard_quotas[ACC_NPERM].val = strtoul(optarg, NULL, 10); + hard_quotas[ACC_NPERM].val = get_optval_int(optarg); break; case 'M': - hard_quotas[ACC_PATHLEN].val = - strtoul(optarg, NULL, 10); + hard_quotas[ACC_PATHLEN].val = get_optval_int(optarg); hard_quotas[ACC_PATHLEN].val = min((unsigned int)XENSTORE_REL_PATH_MAX, hard_quotas[ACC_PATHLEN].val); @@ -2852,13 +2851,13 @@ int main(int argc, char *argv[]) set_timeout(optarg); break; case 'e': - dom0_event = strtol(optarg, NULL, 10); + dom0_event = get_optval_int(optarg); break; case 'm': - dom0_domid = strtol(optarg, NULL, 10); + dom0_domid = get_optval_int(optarg); break; case 'p': - priv_domid = strtol(optarg, NULL, 10); + priv_domid = get_optval_int(optarg); break; #ifndef NO_LIVE_UPDATE case 'U': -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:15:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:15:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435071.688118 (Exim 4.92) (envelope-from ) id 1optuy-0001Rh-9n; Tue, 01 Nov 2022 16:15:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435071.688118; Tue, 01 Nov 2022 16:15:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optuy-0001RW-5v; Tue, 01 Nov 2022 16:15:12 +0000 Received: by outflank-mailman (input) for mailman id 435071; Tue, 01 Nov 2022 16:15:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optlS-0003qE-Ba for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:05:22 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fc7b1ad5-59fe-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 17:05:21 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 05F921F8CA; Tue, 1 Nov 2022 16:05:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B58871346F; Tue, 1 Nov 2022 16:05:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 73wIK8BDYWOYcgAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:05:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc7b1ad5-59fe-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667318721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2q+bzKJwqxVNaXxCMgH7XK7Vg2XGJN/yW7eJYqIUWtA=; b=kY9fUxff56SHHUTCsUXg+fjZsQukQrKVZpMqHwqzdq8HqER9E7HL3At5QCPyST88IXUfjo O33Af+MmYBz/w+Tkmqq25S/0X7Fb7NtA7tMs9TFuQ0dRBY9RsOjDd6sS8VsCrHaiP+FWsH /PMee7RLt/5ql+Kfq1I7Ydh19dVxTl4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: [PATCH 10/12] tools/xenstore: remember global and per domain max accounting values Date: Tue, 1 Nov 2022 17:04:20 +0100 Message-Id: <20221101160422.7212-11-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101160422.7212-1-jgross@suse.com> References: <20221101160422.7212-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add saving the maximum values of the different accounting data seen per domain and (for unprivileged domains) globally, and print those values via the xenstore-control quota command. Add a sub-command for resetting the global maximum values seen. This should help for a decision how to set the related quotas. Signed-off-by: Juergen Gross --- docs/misc/xenstore.txt | 5 +- tools/xenstore/xenstored_control.c | 22 ++++++- tools/xenstore/xenstored_domain.c | 102 +++++++++++++++++++++++------ tools/xenstore/xenstored_domain.h | 2 + 4 files changed, 109 insertions(+), 22 deletions(-) diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt index 9db0385120..da47d7bb16 100644 --- a/docs/misc/xenstore.txt +++ b/docs/misc/xenstore.txt @@ -415,7 +415,7 @@ CONTROL |[|] print| print to syslog (xenstore runs as daemon) or to console (xenstore runs as stubdom) - quota|[set |] + quota|[set ||max [-r]] without parameters: print the current quota settings with "set ": set the quota to new value (The admin should make sure all the domain usage is @@ -424,6 +424,9 @@ CONTROL |[|] violating the new quota setting isn't increased further) with "": print quota related accounting data for the domain + with "max [-r]": show global per-domain maximum values of all + unprivileged domains, optionally reset the values by adding + "-r" quota-soft|[set ] like the "quota" command, but for soft-quota. trace|[+|-] diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index 0a985a1faa..23098917ec 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -306,6 +306,22 @@ static int quota_get(const void *ctx, struct connection *conn, return domain_get_quota(ctx, conn, atoi(vec[0])); } +static int quota_max(const void *ctx, struct connection *conn, + char **vec, int num) +{ + if (num > 1) + return EINVAL; + + if (num == 1) { + if (!strcmp(vec[0], "-r")) + domain_reset_global_acc(); + else + return EINVAL; + } + + return domain_max_global_acc(ctx, conn); +} + static int do_control_quota(const void *ctx, struct connection *conn, char **vec, int num) { @@ -315,6 +331,9 @@ static int do_control_quota(const void *ctx, struct connection *conn, if (!strcmp(vec[0], "set")) return quota_set(ctx, conn, vec + 1, num - 1, hard_quotas); + if (!strcmp(vec[0], "max")) + return quota_max(ctx, conn, vec + 1, num - 1); + return quota_get(ctx, conn, vec, num); } @@ -978,7 +997,8 @@ static struct cmd_s cmds[] = { { "memreport", do_control_memreport, "[]" }, #endif { "print", do_control_print, "" }, - { "quota", do_control_quota, "[set |]" }, + { "quota", do_control_quota, + "[set ||max [-r]]" }, { "quota-soft", do_control_quota_s, "[set ]" }, { "help", do_control_help, "" }, }; diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 274ea72741..6464362299 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -43,6 +43,8 @@ static evtchn_port_t virq_port; xenevtchn_handle *xce_handle = NULL; +static unsigned int acc_global_max[ACC_N]; + struct domain { /* The id of this domain */ @@ -70,7 +72,10 @@ struct domain bool introduced; /* Accounting data for this domain. */ - unsigned int acc[ACC_N]; + struct acc { + unsigned int val; + unsigned int max; + } acc[ACC_N]; /* Memory quota data for this domain. */ bool soft_quota_reported; @@ -199,9 +204,9 @@ static bool domain_can_read(struct connection *conn) if (domain_is_unprivileged(conn)) { if (domain->wrl_credit < 0) return false; - if (domain->acc[ACC_OUTST] >= quota_req_outstanding) + if (domain->acc[ACC_OUTST].val >= quota_req_outstanding) return false; - if (domain->acc[ACC_MEM] >= quota_memory_per_domain_hard && + if (domain->acc[ACC_MEM].val >= quota_memory_per_domain_hard && quota_memory_per_domain_hard) return false; } @@ -264,7 +269,7 @@ static int domain_tree_remove_sub(const void *ctx, struct connection *conn, ret = WALK_TREE_SKIP_CHILDREN; } - return domain->acc[ACC_NODES] ? ret : WALK_TREE_SUCCESS_STOP; + return domain->acc[ACC_NODES].val ? ret : WALK_TREE_SUCCESS_STOP; } static void domain_tree_remove(struct domain *domain) @@ -272,7 +277,7 @@ static void domain_tree_remove(struct domain *domain) int ret; struct walk_funcs walkfuncs = { .enter = domain_tree_remove_sub }; - if (domain->acc[ACC_NODES]) { + if (domain->acc[ACC_NODES].val) { ret = walk_node_tree(domain, NULL, "/", &walkfuncs, domain); if (ret == WALK_TREE_ERROR_STOP) syslog(LOG_ERR, @@ -430,14 +435,41 @@ int domain_get_quota(const void *ctx, struct connection *conn, return ENOMEM; #define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-16s: %8d\n", #t, e); \ + resp = talloc_asprintf_append(resp, "%-16s: %8u (max: %8u\n", #t, \ + d->acc[e].val, d->acc[e].max); \ + if (!resp) return ENOMEM + + ent(nodes, ACC_NODES); + ent(watches, ACC_WATCH); + ent(transactions, ACC_TRANS); + ent(outstanding, ACC_OUTST); + ent(memory, ACC_MEM); + +#undef ent + + send_reply(conn, XS_CONTROL, resp, strlen(resp) + 1); + + return 0; +} + +int domain_max_global_acc(const void *ctx, struct connection *conn) +{ + char *resp; + + resp = talloc_asprintf(ctx, "Max. seen accounting values:\n"); + if (!resp) + return ENOMEM; + +#define ent(t, e) \ + resp = talloc_asprintf_append(resp, "%-16s: %8u\n", #t, \ + acc_global_max[e]); \ if (!resp) return ENOMEM - ent(nodes, d->acc[ACC_NODES]); - ent(watches, d->acc[ACC_WATCH]); - ent(transactions, d->acc[ACC_TRANS]); - ent(outstanding, d->acc[ACC_OUTST]); - ent(memory, d->acc[ACC_MEM]); + ent(nodes, ACC_NODES); + ent(watches, ACC_WATCH); + ent(transactions, ACC_TRANS); + ent(outstanding, ACC_OUTST); + ent(memory, ACC_MEM); #undef ent @@ -1055,14 +1087,22 @@ int domain_adjust_node_perms(struct node *node) static int domain_acc_add_chk(struct domain *d, unsigned int what, int add, unsigned int domid) { - if ((add < 0 && -add > d->acc[what]) || - (d->acc[what] + add) > INT_MAX) { + unsigned int val; + + if ((add < 0 && -add > d->acc[what].val) || + (d->acc[what].val + add) > INT_MAX) { syslog(LOG_ERR, "Accounting error: domain %u type %u val %u\n", - domid, what, d->acc[what] + add); + domid, what, d->acc[what].val + add); return (add < 0) ? 0 : INT_MAX; } - return d->acc[what] + add; + val = d->acc[what].val + add; + if (val > d->acc[what].max) + d->acc[what].max = val; + if (val > acc_global_max[what] && domid_is_unprivileged(domid)) + acc_global_max[what] = val; + + return val; } static int domain_acc_add(struct connection *conn, unsigned int domid, @@ -1118,10 +1158,10 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, } trace_acc("global change domid %u: what=%u %u add %d\n", domid, what, - d->acc[what], add); - d->acc[what] = domain_acc_add_chk(d, what, add, domid); + d->acc[what].val, add); + d->acc[what].val = domain_acc_add_chk(d, what, add, domid); - return d->acc[what]; + return d->acc[what].val; } void acc_drop(struct connection *conn) @@ -1154,6 +1194,28 @@ void acc_commit(struct connection *conn) conn->in = in; } +static int domain_reset_global_acc_sub(void *k, void *v, void *arg) +{ + struct domain *d = v; + unsigned int i; + + for (i = 0; i < ACC_N; i++) + d->acc[i].max = d->acc[i].val; + + return 0; +} + +void domain_reset_global_acc(void) +{ + unsigned int i; + + for (i = 0; i < ACC_N; i++) + acc_global_max[i] = 0; + + /* Set current max values seen. */ + hashtable_iterate(domhash, domain_reset_global_acc_sub, NULL); +} + int domain_nbentry_inc(struct connection *conn, unsigned int domid) { return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) @@ -1654,7 +1716,7 @@ static int domain_check_acc_init_sub(void *k, void *v, void *arg) * If everything is correct incrementing the value for each node will * result in dom->nodes being 0 at the end. */ - dom->nodes = -d->acc[ACC_NODES]; + dom->nodes = -d->acc[ACC_NODES].val; if (!hashtable_insert(domains, &dom->domid, dom)) { talloc_free(dom); @@ -1709,7 +1771,7 @@ static int domain_check_acc_sub(void *k, void *v, void *arg) if (!d) return 0; - d->acc[ACC_NODES] += dom->nodes; + d->acc[ACC_NODES].val += dom->nodes; return 0; } diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 5005850dd3..b5f0b9a591 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -116,6 +116,8 @@ int domain_get_quota(const void *ctx, struct connection *conn, int acc_fix_domains(struct list_head *head, bool update); void acc_drop(struct connection *conn); void acc_commit(struct connection *conn); +int domain_max_global_acc(const void *ctx, struct connection *conn); +void domain_reset_global_acc(void); /* Write rate limiting */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:15:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:15:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435075.688130 (Exim 4.92) (envelope-from ) id 1optuz-0001mY-Oi; Tue, 01 Nov 2022 16:15:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435075.688130; Tue, 01 Nov 2022 16:15:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optuz-0001mR-LO; Tue, 01 Nov 2022 16:15:13 +0000 Received: by outflank-mailman (input) for mailman id 435075; Tue, 01 Nov 2022 16:15:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optlG-0003qE-OW for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:05:10 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f5c39eb7-59fe-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 17:05:10 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BA5F31F8CA; Tue, 1 Nov 2022 16:05:09 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8DBAA1346F; Tue, 1 Nov 2022 16:05:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2go9IbVDYWN/cgAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:05:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f5c39eb7-59fe-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667318709; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ex16tXxYUWTa8wrIuGo+oPYlqG5C+9YpA2AwG1Rpfyo=; b=nAw8jCn3lUB78s8xN/MoFeZL168qrdvi58IqMzzBHtTRXHhYLxtvbatvLdAKqR9tR0BHtE lK1tK/LEfJoB893kvzMcdn1/5jqwfiVaOBv8nbik6SdPv74yvepZQ/FUAZyK6F08DV8e9T ASWkrIEbIbZl2/ULG09qwkASkcwtqRM= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 08/12] tools/xenstore: add TDB access trace support Date: Tue, 1 Nov 2022 17:04:18 +0100 Message-Id: <20221101160422.7212-9-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101160422.7212-1-jgross@suse.com> References: <20221101160422.7212-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a new trace switch "tdb" and the related trace calls. The "tdb" switch is off per default. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 8 +++++++- tools/xenstore/xenstored_core.h | 6 ++++++ tools/xenstore/xenstored_transaction.c | 7 ++++++- 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index be3c2aba77..f07398e2cf 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -589,6 +589,8 @@ static void get_acc_data(TDB_DATA *key, struct node_account_data *acc) if (old_data.dptr == NULL) { acc->memory = 0; } else { + trace_tdb("read %s size %zu\n", key->dptr, + old_data.dsize + key->dsize); hdr = (void *)old_data.dptr; acc->memory = old_data.dsize; acc->domid = hdr->perms[0].id; @@ -655,6 +657,7 @@ int do_tdb_write(struct connection *conn, TDB_DATA *key, TDB_DATA *data, errno = EIO; return errno; } + trace_tdb("store %s size %zu\n", key->dptr, data->dsize + key->dsize); if (acc) { /* Don't use new_domid, as it might be a transaction node. */ @@ -682,6 +685,7 @@ int do_tdb_delete(struct connection *conn, TDB_DATA *key, errno = EIO; return errno; } + trace_tdb("delete %s\n", key->dptr); if (acc->memory) { domid = get_acc_domid(conn, key, acc->domid); @@ -731,6 +735,8 @@ struct node *read_node(struct connection *conn, const void *ctx, goto error; } + trace_tdb("read %s size %zu\n", key.dptr, data.dsize + key.dsize); + node->parent = NULL; talloc_steal(node, data.dptr); @@ -2737,7 +2743,7 @@ static void set_quota(const char *arg, bool soft) /* Sorted by bit values of TRACE_* flags. Flag is (1u << index). */ const char *trace_switches[] = { - "obj", "io", "wrl", "acc", + "obj", "io", "wrl", "acc", "tdb", NULL }; diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index e17bd4c268..d3a17a6ce1 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -295,8 +295,14 @@ extern unsigned int trace_flags; #define TRACE_IO 0x00000002 #define TRACE_WRL 0x00000004 #define TRACE_ACC 0x00000008 +#define TRACE_TDB 0x00000010 extern const char *trace_switches[]; int set_trace_switch(const char *arg); +#define trace_tdb(...) \ +do { \ + if (trace_flags & TRACE_TDB) \ + trace("tdb: " __VA_ARGS__); \ +} while (0) extern TDB_CONTEXT *tdb_ctx; extern int dom0_domid; diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 1aa9d3cb3d..19a1175d1b 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -366,8 +366,11 @@ static int finalize_transaction(struct connection *conn, if (tdb_error(tdb_ctx) != TDB_ERR_NOEXIST) return EIO; gen = NO_GENERATION; - } else + } else { + trace_tdb("read %s size %zu\n", key.dptr, + key.dsize + data.dsize); gen = hdr->generation; + } talloc_free(data.dptr); if (i->generation != gen) return EAGAIN; @@ -391,6 +394,8 @@ static int finalize_transaction(struct connection *conn, set_tdb_key(i->trans_name, &ta_key); data = tdb_fetch(tdb_ctx, ta_key); if (data.dptr) { + trace_tdb("read %s size %zu\n", ta_key.dptr, + ta_key.dsize + data.dsize); hdr = (void *)data.dptr; hdr->generation = ++generation; *is_corrupt |= do_tdb_write(conn, &key, &data, -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:15:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:15:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435076.688135 (Exim 4.92) (envelope-from ) id 1optv0-0001qA-6y; Tue, 01 Nov 2022 16:15:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435076.688135; Tue, 01 Nov 2022 16:15:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optuz-0001pC-VV; Tue, 01 Nov 2022 16:15:13 +0000 Received: by outflank-mailman (input) for mailman id 435076; Tue, 01 Nov 2022 16:15:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optuy-0000i5-AU for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:15:12 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c3528f9-5a00-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 17:15:11 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 202503382E; Tue, 1 Nov 2022 16:15:11 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E69B71346F; Tue, 1 Nov 2022 16:15:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QVjxNg5GYWMedwAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:15:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c3528f9-5a00-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667319311; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pIb0/mYGQ+HwHEptI7zIsqWzXRU1CQBKgofF97fLAvs=; b=Mux+Oyeny1sk2ahF5isrQx7yM9meirOsLaQ2iXfYQm8Hn1AuqztnbpMJ8yiumFWQ9a70lW N1tKEZ/nKhEY9+oNc+JLe+Wm7x2xRa9yH4Zw8AGCvj7jQFA2ZRkGCY79FYlxIMS2upluMZ DsqP0sR1byMe9zu2wfI69MyLzeDBJwI= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 02/10] tools/xenstore: do some cleanup of hashtable.c Date: Tue, 1 Nov 2022 17:14:49 +0100 Message-Id: <20221101161457.8470-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101161457.8470-1-jgross@suse.com> References: <20221101161457.8470-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Do the following cleanups: - hashtable_count() isn't used at all, so remove it - replace prime_table_length and max_load_factor with macros - make hash() static - add a loadlimit() helper function - remove the /***/ lines between functions - do some style corrections Signed-off-by: Juergen Gross --- tools/xenstore/hashtable.c | 74 ++++++++++++++------------------------ tools/xenstore/hashtable.h | 10 ------ 2 files changed, 27 insertions(+), 57 deletions(-) diff --git a/tools/xenstore/hashtable.c b/tools/xenstore/hashtable.c index 1c8656e016..d312004d70 100644 --- a/tools/xenstore/hashtable.c +++ b/tools/xenstore/hashtable.c @@ -40,22 +40,25 @@ static const unsigned int primes[] = { 50331653, 100663319, 201326611, 402653189, 805306457, 1610612741 }; -const unsigned int prime_table_length = sizeof(primes)/sizeof(primes[0]); -const unsigned int max_load_factor = 65; /* percentage */ -/*****************************************************************************/ -/* indexFor */ -static inline unsigned int -indexFor(unsigned int tablelength, unsigned int hashvalue) { +#define PRIME_TABLE_LEN ARRAY_SIZE(primes) +#define MAX_LOAD_PERCENT 65 + +static inline unsigned int indexFor(unsigned int tablelength, + unsigned int hashvalue) +{ return (hashvalue % tablelength); } -/*****************************************************************************/ -struct hashtable * -create_hashtable(const void *ctx, unsigned int minsize, - unsigned int (*hashf) (void*), - int (*eqf) (void*,void*), - unsigned int flags) +static unsigned int loadlimit(unsigned int pindex) +{ + return ((uint64_t)primes[pindex] * MAX_LOAD_PERCENT) / 100; +} + +struct hashtable *create_hashtable(const void *ctx, unsigned int minsize, + unsigned int (*hashf) (void *), + int (*eqf) (void *,void *), + unsigned int flags) { struct hashtable *h; unsigned int pindex, size = primes[0]; @@ -64,7 +67,7 @@ create_hashtable(const void *ctx, unsigned int minsize, if (minsize > (1u << 30)) return NULL; /* Enforce size as prime */ - for (pindex=0; pindex < prime_table_length; pindex++) { + for (pindex=0; pindex < PRIME_TABLE_LEN; pindex++) { if (primes[pindex] > minsize) { size = primes[pindex]; break; } } @@ -81,7 +84,7 @@ create_hashtable(const void *ctx, unsigned int minsize, h->entrycount = 0; h->hashfn = hashf; h->eqfn = eqf; - h->loadlimit = (unsigned int)(((uint64_t)size * max_load_factor) / 100); + h->loadlimit = loadlimit(pindex); return h; err1: @@ -90,9 +93,7 @@ err0: return NULL; } -/*****************************************************************************/ -unsigned int -hash(struct hashtable *h, void *k) +static unsigned int hash(struct hashtable *h, void *k) { /* Aim to protect against poor hash functions by adding logic here * - logic taken from java 1.4 hashtable source */ @@ -104,9 +105,7 @@ hash(struct hashtable *h, void *k) return i; } -/*****************************************************************************/ -static int -hashtable_expand(struct hashtable *h) +static int hashtable_expand(struct hashtable *h) { /* Double the size of the table to accomodate more entries */ struct entry **newtable; @@ -114,7 +113,7 @@ hashtable_expand(struct hashtable *h) struct entry **pE; unsigned int newsize, i, index; /* Check we're not hitting max capacity */ - if (h->primeindex == (prime_table_length - 1)) return 0; + if (h->primeindex == (PRIME_TABLE_LEN - 1)) return 0; newsize = primes[++(h->primeindex)]; newtable = talloc_realloc(h, h->table, struct entry *, newsize); @@ -144,21 +143,11 @@ hashtable_expand(struct hashtable *h) } h->tablelength = newsize; - h->loadlimit = (unsigned int) - (((uint64_t)newsize * max_load_factor) / 100); + h->loadlimit = loadlimit(h->primeindex); return -1; } -/*****************************************************************************/ -unsigned int -hashtable_count(struct hashtable *h) -{ - return h->entrycount; -} - -/*****************************************************************************/ -int -hashtable_insert(struct hashtable *h, void *k, void *v) +int hashtable_insert(struct hashtable *h, void *k, void *v) { /* This method allows duplicate keys - but they shouldn't be used */ unsigned int index; @@ -182,9 +171,7 @@ hashtable_insert(struct hashtable *h, void *k, void *v) return -1; } -/*****************************************************************************/ -void * /* returns value associated with key */ -hashtable_search(struct hashtable *h, void *k) +void *hashtable_search(struct hashtable *h, void *k) { struct entry *e; unsigned int hashvalue, index; @@ -200,9 +187,7 @@ hashtable_search(struct hashtable *h, void *k) return NULL; } -/*****************************************************************************/ -void * /* returns value associated with key */ -hashtable_remove(struct hashtable *h, void *k) +void *hashtable_remove(struct hashtable *h, void *k) { /* TODO: consider compacting the table when the load factor drops enough, * or provide a 'compact' method. */ @@ -235,10 +220,8 @@ hashtable_remove(struct hashtable *h, void *k) return NULL; } -/*****************************************************************************/ -int -hashtable_iterate(struct hashtable *h, - int (*func)(void *k, void *v, void *arg), void *arg) +int hashtable_iterate(struct hashtable *h, + int (*func)(void *k, void *v, void *arg), void *arg) { int ret; unsigned int i; @@ -261,10 +244,7 @@ hashtable_iterate(struct hashtable *h, return 0; } -/*****************************************************************************/ -/* destroy */ -void -hashtable_destroy(struct hashtable *h) +void hashtable_destroy(struct hashtable *h) { unsigned int i; struct entry *e; diff --git a/tools/xenstore/hashtable.h b/tools/xenstore/hashtable.h index 07fdc1a82b..f1caef0d4f 100644 --- a/tools/xenstore/hashtable.h +++ b/tools/xenstore/hashtable.h @@ -75,16 +75,6 @@ hashtable_search(struct hashtable *h, void *k); void * /* returns value */ hashtable_remove(struct hashtable *h, void *k); -/***************************************************************************** - * hashtable_count - - * @name hashtable_count - * @param h the hashtable - * @return the number of items stored in the hashtable - */ -unsigned int -hashtable_count(struct hashtable *h); - /***************************************************************************** * hashtable_iterate -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:15:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:15:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435080.688143 (Exim 4.92) (envelope-from ) id 1optv0-0001wV-Ls; Tue, 01 Nov 2022 16:15:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435080.688143; Tue, 01 Nov 2022 16:15:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optv0-0001ue-D9; Tue, 01 Nov 2022 16:15:14 +0000 Received: by outflank-mailman (input) for mailman id 435080; Tue, 01 Nov 2022 16:15:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optlM-0003Iv-CR for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:05:16 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f918903b-59fe-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 17:05:15 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5201822350; Tue, 1 Nov 2022 16:05:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 242691346F; Tue, 1 Nov 2022 16:05:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cuN+B7tDYWOJcgAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:05:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f918903b-59fe-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667318715; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zlr1bEVW5zM00uivxYgahU2VVqHYofX1SXVVdA6eJyo=; b=PonLWqrEzh/61QWbp7+LdC4rt+JYU/gOL/wCJ+WSpOQQ7MS0UwzaLyZWEl8QS2Cec1Lnli s8ZJSKP1Mwp2isKS03VYfcaOXqqLXskRXqLe8hqecz0MQyKElcCmssD6pcvtkmBkPRUww2 J8vTE8YLaOEmvmuTqB/AEpSTxNpPRuk= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 09/12] tools/xenstore: switch transaction accounting to generic accounting Date: Tue, 1 Nov 2022 17:04:19 +0100 Message-Id: <20221101160422.7212-10-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101160422.7212-1-jgross@suse.com> References: <20221101160422.7212-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As transaction accounting is active for unprivileged domains only, it can easily be added to the generic per-domain accounting. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 3 +-- tools/xenstore/xenstored_core.h | 1 - tools/xenstore/xenstored_domain.c | 21 ++++++++++++++++++--- tools/xenstore/xenstored_domain.h | 4 ++++ tools/xenstore/xenstored_transaction.c | 12 +++++------- 5 files changed, 28 insertions(+), 13 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index f07398e2cf..f5933a900a 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2074,7 +2074,7 @@ static void consider_message(struct connection *conn) * stalled. This will ignore new requests until Live-Update happened * or it was aborted. */ - if (lu_is_pending() && conn->transaction_started == 0 && + if (lu_is_pending() && conn->ta_start_time == 0 && conn->in->hdr.msg.type == XS_TRANSACTION_START) { trace("Delaying transaction start for connection %p req_id %u\n", conn, conn->in->hdr.msg.req_id); @@ -2181,7 +2181,6 @@ struct connection *new_connection(const struct interface_funcs *funcs) new->funcs = funcs; new->is_ignored = false; new->is_stalled = false; - new->transaction_started = 0; INIT_LIST_HEAD(&new->out_list); INIT_LIST_HEAD(&new->acc_list); INIT_LIST_HEAD(&new->ref_list); diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index d3a17a6ce1..f51b8d1839 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -151,7 +151,6 @@ struct connection /* List of in-progress transactions. */ struct list_head transaction_list; uint32_t next_transaction_id; - unsigned int transaction_started; time_t ta_start_time; /* List of delayed requests. */ diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 2420fbff31..274ea72741 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -421,12 +421,10 @@ int domain_get_quota(const void *ctx, struct connection *conn, { struct domain *d = find_domain_struct(domid); char *resp; - int ta; if (!d) return ENOENT; - ta = d->conn ? d->conn->transaction_started : 0; resp = talloc_asprintf(ctx, "Domain %u:\n", domid); if (!resp) return ENOMEM; @@ -437,7 +435,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, ent(nodes, d->acc[ACC_NODES]); ent(watches, d->acc[ACC_WATCH]); - ent(transactions, ta); + ent(transactions, d->acc[ACC_TRANS]); ent(outstanding, d->acc[ACC_OUTST]); ent(memory, d->acc[ACC_MEM]); @@ -1292,6 +1290,23 @@ void domain_outstanding_dec(struct connection *conn, unsigned int domid) domain_acc_add(conn, domid, ACC_OUTST, -1, true); } +void domain_transaction_inc(struct connection *conn) +{ + domain_acc_add(conn, conn->id, ACC_TRANS, 1, true); +} + +void domain_transaction_dec(struct connection *conn) +{ + domain_acc_add(conn, conn->id, ACC_TRANS, -1, true); +} + +unsigned int domain_transaction_get(struct connection *conn) +{ + return (domain_is_unprivileged(conn)) + ? domain_acc_add(conn, conn->id, ACC_TRANS, 0, true) + : 0; +} + static wrl_creditt wrl_config_writecost = WRL_FACTOR; static wrl_creditt wrl_config_rate = WRL_RATE * WRL_FACTOR; static wrl_creditt wrl_config_dburst = WRL_DBURST * WRL_FACTOR; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 91db3342c4..5005850dd3 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -26,6 +26,7 @@ enum { ACC_WATCH = ACC_TR_N, ACC_OUTST, ACC_MEM, + ACC_TRANS, ACC_N /* Number of elements per domain. */ }; @@ -107,6 +108,9 @@ void domain_watch_dec(struct connection *conn); int domain_watch(struct connection *conn); void domain_outstanding_inc(struct connection *conn, unsigned int domid); void domain_outstanding_dec(struct connection *conn, unsigned int domid); +void domain_transaction_inc(struct connection *conn); +void domain_transaction_dec(struct connection *conn); +unsigned int domain_transaction_get(struct connection *conn); int domain_get_quota(const void *ctx, struct connection *conn, unsigned int domid); int acc_fix_domains(struct list_head *head, bool update); diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 19a1175d1b..ce6a12b576 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -471,8 +471,7 @@ int do_transaction_start(const void *ctx, struct connection *conn, if (conn->transaction) return EBUSY; - if (domain_is_unprivileged(conn) && - conn->transaction_started > quota_max_transaction) + if (domain_transaction_get(conn) > quota_max_transaction) return ENOSPC; /* Attach transaction to ctx for autofree until it's complete */ @@ -497,9 +496,9 @@ int do_transaction_start(const void *ctx, struct connection *conn, list_add_tail(&trans->list, &conn->transaction_list); talloc_steal(conn, trans); talloc_set_destructor(trans, destroy_transaction); - if (!conn->transaction_started) + if (!conn->ta_start_time) conn->ta_start_time = time(NULL); - conn->transaction_started++; + domain_transaction_inc(conn); wrl_ntransactions++; snprintf(id_str, sizeof(id_str), "%u", trans->id); @@ -524,8 +523,8 @@ int do_transaction_end(const void *ctx, struct connection *conn, conn->transaction = NULL; list_del(&trans->list); - conn->transaction_started--; - if (!conn->transaction_started) + domain_transaction_dec(conn); + if (list_empty(&conn->transaction_list)) conn->ta_start_time = 0; /* Attach transaction to ctx for auto-cleanup */ @@ -576,7 +575,6 @@ void conn_delete_all_transactions(struct connection *conn) assert(conn->transaction == NULL); - conn->transaction_started = 0; conn->ta_start_time = 0; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:15:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:15:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435084.688163 (Exim 4.92) (envelope-from ) id 1optv5-0002vo-Uw; Tue, 01 Nov 2022 16:15:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435084.688163; Tue, 01 Nov 2022 16:15:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optv5-0002vU-S0; Tue, 01 Nov 2022 16:15:19 +0000 Received: by outflank-mailman (input) for mailman id 435084; Tue, 01 Nov 2022 16:15:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optv4-0000i5-0L for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:15:18 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f893797-5a00-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 17:15:17 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AE73D1F90F; Tue, 1 Nov 2022 16:15:16 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7EDF41346F; Tue, 1 Nov 2022 16:15:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PHilHRRGYWMtdwAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:15:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f893797-5a00-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667319316; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ePljyH5jlUhgLAg8XDkia2Vo0lFqj2Qpdrf2FB4EPzU=; b=KGxM5llsacI35uOqsmNhcEZhS/uWRSdQhPmi6hi/EOUtXVNP6dTXi/+gv9A516MZo3uqat HDKcN7WyMEqmUvXEGFJyQPbC9oBIEvoRjKo+Cxix4Bd/ItrzMO7SsJqcqycf7FJx6TwsIS V4d+xVt278CTw05khGNw+C4W/BywrZg= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 03/10] tools/xenstore: modify interface of create_hashtable() Date: Tue, 1 Nov 2022 17:14:50 +0100 Message-Id: <20221101161457.8470-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101161457.8470-1-jgross@suse.com> References: <20221101161457.8470-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The minsize parameter of create_hashtable() doesn't have any real use case for Xenstore, so drop it. For better talloc_report_full() diagnostic output add a name parameter to create_hashtable(). Signed-off-by: Juergen Gross --- tools/xenstore/hashtable.c | 24 ++++++++---------------- tools/xenstore/hashtable.h | 4 ++-- tools/xenstore/xenstored_core.c | 2 +- tools/xenstore/xenstored_domain.c | 4 ++-- 4 files changed, 13 insertions(+), 21 deletions(-) diff --git a/tools/xenstore/hashtable.c b/tools/xenstore/hashtable.c index d312004d70..43a8caab82 100644 --- a/tools/xenstore/hashtable.c +++ b/tools/xenstore/hashtable.c @@ -55,36 +55,28 @@ static unsigned int loadlimit(unsigned int pindex) return ((uint64_t)primes[pindex] * MAX_LOAD_PERCENT) / 100; } -struct hashtable *create_hashtable(const void *ctx, unsigned int minsize, - unsigned int (*hashf) (void *), - int (*eqf) (void *,void *), +struct hashtable *create_hashtable(const void *ctx, const char *name, + unsigned int (*hashf) (void*), + int (*eqf) (void*,void*), unsigned int flags) { struct hashtable *h; - unsigned int pindex, size = primes[0]; - - /* Check requested hashtable isn't too large */ - if (minsize > (1u << 30)) return NULL; - - /* Enforce size as prime */ - for (pindex=0; pindex < PRIME_TABLE_LEN; pindex++) { - if (primes[pindex] > minsize) { size = primes[pindex]; break; } - } h = talloc_zero(ctx, struct hashtable); if (NULL == h) goto err0; - h->table = talloc_zero_array(h, struct entry *, size); + talloc_set_name_const(h, name); + h->table = talloc_zero_array(h, struct entry *, primes[0]); if (NULL == h->table) goto err1; - h->tablelength = size; + h->tablelength = primes[0]; h->flags = flags; - h->primeindex = pindex; + h->primeindex = 0; h->entrycount = 0; h->hashfn = hashf; h->eqfn = eqf; - h->loadlimit = loadlimit(pindex); + h->loadlimit = loadlimit(0); return h; err1: diff --git a/tools/xenstore/hashtable.h b/tools/xenstore/hashtable.h index f1caef0d4f..5575f6c1dd 100644 --- a/tools/xenstore/hashtable.h +++ b/tools/xenstore/hashtable.h @@ -10,7 +10,7 @@ struct hashtable; * @name create_hashtable * @param ctx talloc context to use for allocations - * @param minsize minimum initial size of hashtable + * @param name talloc name of the hashtable * @param hashfunction function for hashing keys * @param key_eq_fn function for determining key equality * @param flags flags HASHTABLE_* @@ -23,7 +23,7 @@ struct hashtable; #define HASHTABLE_FREE_KEY (1U << 1) struct hashtable * -create_hashtable(const void *ctx, unsigned int minsize, +create_hashtable(const void *ctx, const char *name, unsigned int (*hashfunction) (void*), int (*key_eq_fn) (void*,void*), unsigned int flags diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 714841d9ca..c4d9d275be 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2502,7 +2502,7 @@ void check_store(void) struct check_store_data data; /* Don't free values (they are all void *1) */ - data.reachable = create_hashtable(NULL, 16, hash_from_key_fn, + data.reachable = create_hashtable(NULL, "checkstore", hash_from_key_fn, keys_equal_fn, HASHTABLE_FREE_KEY); if (!data.reachable) { log("check_store: ENOMEM"); diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 1f746afd70..b3c288bf40 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -1020,7 +1020,7 @@ void domain_init(int evtfd) int rc; /* Start with a random rather low domain count for the hashtable. */ - domhash = create_hashtable(NULL, 8, domhash_fn, domeq_fn, 0); + domhash = create_hashtable(NULL, "domains", domhash_fn, domeq_fn, 0); if (!domhash) barf_perror("Failed to allocate domain hashtable"); @@ -1798,7 +1798,7 @@ struct hashtable *domain_check_acc_init(void) { struct hashtable *domains; - domains = create_hashtable(NULL, 8, domhash_fn, domeq_fn, + domains = create_hashtable(NULL, "domain_check", domhash_fn, domeq_fn, HASHTABLE_FREE_VALUE); if (!domains) return NULL; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:15:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:15:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435086.688169 (Exim 4.92) (envelope-from ) id 1optv6-00030w-FG; Tue, 01 Nov 2022 16:15:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435086.688169; Tue, 01 Nov 2022 16:15:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optv6-000309-8K; Tue, 01 Nov 2022 16:15:20 +0000 Received: by outflank-mailman (input) for mailman id 435086; Tue, 01 Nov 2022 16:15:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optlX-0003qE-QV for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:05:27 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ffceadcf-59fe-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 17:05:26 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 94E931F8CA; Tue, 1 Nov 2022 16:05:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6AB141346F; Tue, 1 Nov 2022 16:05:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GmSiGMZDYWOlcgAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:05:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ffceadcf-59fe-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667318726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cBkIMfoGbobN/afNSIa7avOizbXZzmTA3t+O9pWgXaQ=; b=kVOwyFJo3DnA+kTKMB5lSEkk6JlHtyREiXQqjwTuXmAoM+NmioSa5IpPJWNdzigKshqSNa 83hAf7HwzIrLjJjIdEUM9Iwp/QdIgj5LccahQ/cioWnP0VJVa4w6vBaVcPr+zjTZhSInnz qfiwgba3DMNIokcjJM/jNt6N2AcqQL0= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 11/12] tools/xenstore: use generic accounting for remaining quotas Date: Tue, 1 Nov 2022 17:04:21 +0100 Message-Id: <20221101160422.7212-12-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101160422.7212-1-jgross@suse.com> References: <20221101160422.7212-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The maxrequests, node size, number of node permissions, and path length quota are a little bit special, as they are either active in transactions only (maxrequests), or they are just per item instead of count values. Nevertheless being able to know the maximum number of those quota related values per domain would be beneficial, so add them to the generic accounting. The per domain value will never show current numbers other than zero, but the maximum number seen can be gathered the same way as the number of nodes during a transaction. To be able to use the const qualifier for a new function switch domain_is_unprivileged() to take a const pointer, too. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 14 +++++------ tools/xenstore/xenstored_core.h | 2 +- tools/xenstore/xenstored_domain.c | 34 +++++++++++++++++++++----- tools/xenstore/xenstored_domain.h | 6 +++++ tools/xenstore/xenstored_transaction.c | 4 +-- tools/xenstore/xenstored_watch.c | 2 +- 6 files changed, 45 insertions(+), 17 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index f5933a900a..af16b18692 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -799,8 +799,8 @@ int write_node_raw(struct connection *conn, TDB_DATA *key, struct node *node, + node->perms.num * sizeof(node->perms.p[0]) + node->datalen + node->childlen; - if (!no_quota_check && domain_is_unprivileged(conn) && - data.dsize >= quota_max_entry_size) { + if (domain_max_chk(conn, ACC_NODESZ, data.dsize, quota_max_entry_size) + && !no_quota_check) { errno = ENOSPC; return errno; } @@ -956,7 +956,7 @@ static struct node *get_node(struct connection *conn, { struct node *node; - if (!name || !is_valid_nodename(name)) { + if (!name || !is_valid_nodename(conn, name)) { errno = EINVAL; return NULL; } @@ -1172,7 +1172,7 @@ static bool valid_chars(const char *node) "0123456789-/_@") == strlen(node)); } -bool is_valid_nodename(const char *node) +bool is_valid_nodename(const struct connection *conn, const char *node) { int local_off = 0; unsigned int domid; @@ -1192,7 +1192,8 @@ bool is_valid_nodename(const char *node) if (sscanf(node, "/local/domain/%5u/%n", &domid, &local_off) != 1) local_off = 0; - if (strlen(node) > local_off + quota_max_path_len) + if (domain_max_chk(conn, ACC_PATHLEN, strlen(node) - local_off, + quota_max_path_len)) return false; return valid_chars(node); @@ -1766,8 +1767,7 @@ static int do_set_perms(const void *ctx, struct connection *conn, return EINVAL; perms.num--; - if (domain_is_unprivileged(conn) && - perms.num > quota_nb_perms_per_node) + if (domain_max_chk(conn, ACC_NPERM, perms.num, quota_nb_perms_per_node)) return ENOSPC; permstr = in->buffer + strlen(in->buffer) + 1; diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index f51b8d1839..752c69d80f 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -252,7 +252,7 @@ void check_store(void); void corrupt(struct connection *conn, const char *fmt, ...); /* Is this a valid node name? */ -bool is_valid_nodename(const char *node); +bool is_valid_nodename(const struct connection *conn, const char *node); /* Get name of parent node. */ char *get_parent(const void *ctx, const char *node); diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 6464362299..2b4a551df5 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -435,7 +435,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, return ENOMEM; #define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-16s: %8u (max: %8u\n", #t, \ + resp = talloc_asprintf_append(resp, "%-17s: %8u (max: %8u\n", #t, \ d->acc[e].val, d->acc[e].max); \ if (!resp) return ENOMEM @@ -444,6 +444,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, ent(transactions, ACC_TRANS); ent(outstanding, ACC_OUTST); ent(memory, ACC_MEM); + ent(transaction-nodes, ACC_TRANSNODES); #undef ent @@ -461,7 +462,7 @@ int domain_max_global_acc(const void *ctx, struct connection *conn) return ENOMEM; #define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-16s: %8u\n", #t, \ + resp = talloc_asprintf_append(resp, "%-17s: %8u\n", #t, \ acc_global_max[e]); \ if (!resp) return ENOMEM @@ -470,6 +471,7 @@ int domain_max_global_acc(const void *ctx, struct connection *conn) ent(transactions, ACC_TRANS); ent(outstanding, ACC_OUTST); ent(memory, ACC_MEM); + ent(transaction-nodes, ACC_TRANSNODES); #undef ent @@ -1084,6 +1086,15 @@ int domain_adjust_node_perms(struct node *node) return 0; } +static void domain_acc_chk_max(struct domain *d, unsigned int what, + unsigned int val, unsigned int domid) +{ + if (val > d->acc[what].max) + d->acc[what].max = val; + if (val > acc_global_max[what] && domid_is_unprivileged(domid)) + acc_global_max[what] = val; +} + static int domain_acc_add_chk(struct domain *d, unsigned int what, int add, unsigned int domid) { @@ -1097,10 +1108,7 @@ static int domain_acc_add_chk(struct domain *d, unsigned int what, int add, } val = d->acc[what].val + add; - if (val > d->acc[what].max) - d->acc[what].max = val; - if (val > acc_global_max[what] && domid_is_unprivileged(domid)) - acc_global_max[what] = val; + domain_acc_chk_max(d, what, val, domid); return val; } @@ -1216,6 +1224,20 @@ void domain_reset_global_acc(void) hashtable_iterate(domhash, domain_reset_global_acc_sub, NULL); } +bool domain_max_chk(const struct connection *conn, unsigned int what, + unsigned int val, unsigned int quota) +{ + if (!conn || !conn->domain) + return false; + + if (domain_is_unprivileged(conn) && val > quota) + return true; + + domain_acc_chk_max(conn->domain, what, val, conn->id); + + return false; +} + int domain_nbentry_inc(struct connection *conn, unsigned int domid) { return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index b5f0b9a591..2bf9b0d87b 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -27,6 +27,10 @@ enum { ACC_OUTST, ACC_MEM, ACC_TRANS, + ACC_TRANSNODES, + ACC_NPERM, + ACC_PATHLEN, + ACC_NODESZ, ACC_N /* Number of elements per domain. */ }; @@ -118,6 +122,8 @@ void acc_drop(struct connection *conn); void acc_commit(struct connection *conn); int domain_max_global_acc(const void *ctx, struct connection *conn); void domain_reset_global_acc(void); +bool domain_max_chk(const struct connection *conn, unsigned int what, + unsigned int val, unsigned int quota); /* Write rate limiting */ diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index ce6a12b576..7967770ca2 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -244,8 +244,8 @@ int access_node(struct connection *conn, struct node *node, i = find_accessed_node(trans, node->name); if (!i) { - if (trans->nodes >= quota_trans_nodes && - domain_is_unprivileged(conn)) { + if (domain_max_chk(conn, ACC_TRANSNODES, trans->nodes + 1, + quota_trans_nodes)) { ret = ENOSPC; goto err; } diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index ed742de936..4deef21c4c 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -176,7 +176,7 @@ static int check_watch_path(struct connection *conn, const void *ctx, *path = canonicalize(conn, ctx, *path); if (!*path) return errno; - if (!is_valid_nodename(*path)) + if (!is_valid_nodename(conn, *path)) goto inval; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:15:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:15:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435087.688174 (Exim 4.92) (envelope-from ) id 1optv6-00038n-V9; Tue, 01 Nov 2022 16:15:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435087.688174; Tue, 01 Nov 2022 16:15:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optv6-00037A-NQ; Tue, 01 Nov 2022 16:15:20 +0000 Received: by outflank-mailman (input) for mailman id 435087; Tue, 01 Nov 2022 16:15:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optld-0003qE-V6 for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:05:34 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0326622c-59ff-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 17:05:32 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 344CD22855; Tue, 1 Nov 2022 16:05:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 025091346F; Tue, 1 Nov 2022 16:05:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kIjAOstDYWOtcgAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:05:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0326622c-59ff-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667318732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0ANLKSke6vhgVX7TFChLAMcfhP/HS68oLDqQfBRqxvs=; b=rfXvg3NnnZu9ba/ny/OPhhE/cKOHWynnq6Z0JAJNPgUm9MPiitfffik1p/prIvGWpnoc01 HMsr3+BuHawMxILbTEuO/FFs7f3gLh/3pLy9nSqsRE5Rg0g+oZ0jBE0smCW1YKxWTeTMfk R35x2KZ/vfiWPAx0pvmTniJHHEX6hUA= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 12/12] tools/xenstore: switch quota management to be table based Date: Tue, 1 Nov 2022 17:04:22 +0100 Message-Id: <20221101160422.7212-13-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101160422.7212-1-jgross@suse.com> References: <20221101160422.7212-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of having individual quota variables switch to a table based approach like the generic accounting. Include all the related data in the same table and add accessor functions. This enables to use the command line --quota parameter for setting all possible quota values, keeping the previous parameters for compatibility. Signed-off-by: Juergen Gross --- V2: - new patch One further remark: it would be rather easy to add soft-quota for all the other quotas (similar to the memory one). This could be used as an early warning for the need to raise global quota. --- tools/xenstore/xenstored_control.c | 43 ++------ tools/xenstore/xenstored_core.c | 85 ++++++++-------- tools/xenstore/xenstored_core.h | 10 -- tools/xenstore/xenstored_domain.c | 130 +++++++++++++++++-------- tools/xenstore/xenstored_domain.h | 12 ++- tools/xenstore/xenstored_transaction.c | 5 +- tools/xenstore/xenstored_watch.c | 2 +- 7 files changed, 154 insertions(+), 133 deletions(-) diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index 23098917ec..bfaba0a854 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -221,35 +221,6 @@ static int do_control_trace(const void *ctx, struct connection *conn, return 0; } -struct quota { - const char *name; - int *quota; - const char *descr; -}; - -static const struct quota hard_quotas[] = { - { "nodes", "a_nb_entry_per_domain, "Nodes per domain" }, - { "watches", "a_nb_watch_per_domain, "Watches per domain" }, - { "transactions", "a_max_transaction, "Transactions per domain" }, - { "outstanding", "a_req_outstanding, - "Outstanding requests per domain" }, - { "transaction-nodes", "a_trans_nodes, - "Max. number of accessed nodes per transaction" }, - { "memory", "a_memory_per_domain_hard, - "Total Xenstore memory per domain (error level)" }, - { "node-size", "a_max_entry_size, "Max. size of a node" }, - { "path-max", "a_max_path_len, "Max. length of a node path" }, - { "permissions", "a_nb_perms_per_node, - "Max. number of permissions per node" }, - { NULL, NULL, NULL } -}; - -static const struct quota soft_quotas[] = { - { "memory", "a_memory_per_domain_soft, - "Total Xenstore memory per domain (warning level)" }, - { NULL, NULL, NULL } -}; - static int quota_show_current(const void *ctx, struct connection *conn, const struct quota *quotas) { @@ -260,9 +231,11 @@ static int quota_show_current(const void *ctx, struct connection *conn, if (!resp) return ENOMEM; - for (i = 0; quotas[i].quota; i++) { + for (i = 0; i < ACC_N; i++) { + if (!quotas[i].name) + continue; resp = talloc_asprintf_append(resp, "%-17s: %8d %s\n", - quotas[i].name, *quotas[i].quota, + quotas[i].name, quotas[i].val, quotas[i].descr); if (!resp) return ENOMEM; @@ -274,7 +247,7 @@ static int quota_show_current(const void *ctx, struct connection *conn, } static int quota_set(const void *ctx, struct connection *conn, - char **vec, int num, const struct quota *quotas) + char **vec, int num, struct quota *quotas) { unsigned int i; int val; @@ -286,9 +259,9 @@ static int quota_set(const void *ctx, struct connection *conn, if (val < 1) return EINVAL; - for (i = 0; quotas[i].quota; i++) { - if (!strcmp(vec[0], quotas[i].name)) { - *quotas[i].quota = val; + for (i = 0; i < ACC_N; i++) { + if (quotas[i].name && !strcmp(vec[0], quotas[i].name)) { + quotas[i].val = val; send_ack(conn, XS_CONTROL); return 0; } diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index af16b18692..ae1ea29b80 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -89,17 +89,6 @@ unsigned int trace_flags = TRACE_OBJ | TRACE_IO; static const char *sockmsg_string(enum xsd_sockmsg_type type); -int quota_nb_entry_per_domain = 1000; -int quota_nb_watch_per_domain = 128; -int quota_max_entry_size = 2048; /* 2K */ -int quota_max_transaction = 10; -int quota_nb_perms_per_node = 5; -int quota_trans_nodes = 1024; -int quota_max_path_len = XENSTORE_REL_PATH_MAX; -int quota_req_outstanding = 20; -int quota_memory_per_domain_soft = 2 * 1024 * 1024; /* 2 MB */ -int quota_memory_per_domain_hard = 2 * 1024 * 1024 + 512 * 1024; /* 2.5 MB */ - unsigned int timeout_watch_event_msec = 20000; void trace(const char *fmt, ...) @@ -799,7 +788,7 @@ int write_node_raw(struct connection *conn, TDB_DATA *key, struct node *node, + node->perms.num * sizeof(node->perms.p[0]) + node->datalen + node->childlen; - if (domain_max_chk(conn, ACC_NODESZ, data.dsize, quota_max_entry_size) + if (domain_max_chk(conn, ACC_NODESZ, data.dsize) && !no_quota_check) { errno = ENOSPC; return errno; @@ -1192,8 +1181,7 @@ bool is_valid_nodename(const struct connection *conn, const char *node) if (sscanf(node, "/local/domain/%5u/%n", &domid, &local_off) != 1) local_off = 0; - if (domain_max_chk(conn, ACC_PATHLEN, strlen(node) - local_off, - quota_max_path_len)) + if (domain_max_chk(conn, ACC_PATHLEN, strlen(node) - local_off)) return false; return valid_chars(node); @@ -1491,7 +1479,7 @@ static struct node *create_node(struct connection *conn, const void *ctx, for (i = node; i; i = i->parent) { /* i->parent is set for each new node, so check quota. */ if (i->parent && - domain_nbentry(conn) >= quota_nb_entry_per_domain) { + domain_nbentry(conn) >= hard_quotas[ACC_NODES].val) { ret = ENOSPC; goto err; } @@ -1767,7 +1755,7 @@ static int do_set_perms(const void *ctx, struct connection *conn, return EINVAL; perms.num--; - if (domain_max_chk(conn, ACC_NPERM, perms.num, quota_nb_perms_per_node)) + if (domain_max_chk(conn, ACC_NPERM, perms.num)) return ENOSPC; permstr = in->buffer + strlen(in->buffer) + 1; @@ -2635,7 +2623,16 @@ static void usage(void) " memory: total used memory per domain for nodes,\n" " transactions, watches and requests, above\n" " which Xenstore will stop talking to domain\n" +" nodes: number nodes owned by a domain\n" +" node-permissions: number of access permissions per\n" +" node\n" +" node-size: total size of a node (permissions +\n" +" children names + content)\n" " outstanding: number of outstanding requests\n" +" path-length: length of a node path\n" +" transactions: number of concurrent transactions\n" +" per domain\n" +" watches: number of watches per domain" " -q, --quota-soft = set a soft quota to the value ,\n" " causing a warning to be issued via syslog() if the\n" " limit is violated, allowed quotas are:\n" @@ -2686,12 +2683,12 @@ int dom0_domid = 0; int dom0_event = 0; int priv_domid = 0; -static int get_optval_int(const char *arg) +static unsigned int get_optval_int(const char *arg) { char *end; - long val; + unsigned long val; - val = strtol(arg, &end, 10); + val = strtoul(arg, &end, 10); if (!*arg || *end || val < 0 || val > INT_MAX) barf("invalid parameter value \"%s\"\n", arg); @@ -2700,15 +2697,19 @@ static int get_optval_int(const char *arg) static bool what_matches(const char *arg, const char *what) { - unsigned int what_len = strlen(what); + unsigned int what_len; + + if (!what) + false; + what_len = strlen(what); return !strncmp(arg, what, what_len) && arg[what_len] == '='; } static void set_timeout(const char *arg) { const char *eq = strchr(arg, '='); - int val; + unsigned int val; if (!eq) barf("quotas must be specified via =\n"); @@ -2722,22 +2723,22 @@ static void set_timeout(const char *arg) static void set_quota(const char *arg, bool soft) { const char *eq = strchr(arg, '='); - int val; + struct quota *q = soft ? soft_quotas : hard_quotas; + unsigned int val; + unsigned int i; if (!eq) barf("quotas must be specified via =\n"); val = get_optval_int(eq + 1); - if (what_matches(arg, "outstanding") && !soft) - quota_req_outstanding = val; - else if (what_matches(arg, "transaction-nodes") && !soft) - quota_trans_nodes = val; - else if (what_matches(arg, "memory")) { - if (soft) - quota_memory_per_domain_soft = val; - else - quota_memory_per_domain_hard = val; - } else - barf("unknown quota \"%s\"\n", arg); + + for (i = 0; i < ACC_N; i++) { + if (what_matches(arg, q[i].name)) { + q[i].val = val; + return; + } + } + + barf("unknown quota \"%s\"\n", arg); } /* Sorted by bit values of TRACE_* flags. Flag is (1u << index). */ @@ -2789,7 +2790,7 @@ int main(int argc, char *argv[]) no_domain_init = true; break; case 'E': - quota_nb_entry_per_domain = strtol(optarg, NULL, 10); + hard_quotas[ACC_NODES].val = strtoul(optarg, NULL, 10); break; case 'F': pidfile = optarg; @@ -2807,10 +2808,10 @@ int main(int argc, char *argv[]) recovery = false; break; case 'S': - quota_max_entry_size = strtol(optarg, NULL, 10); + hard_quotas[ACC_NODESZ].val = strtoul(optarg, NULL, 10); break; case 't': - quota_max_transaction = strtol(optarg, NULL, 10); + hard_quotas[ACC_TRANS].val = strtoul(optarg, NULL, 10); break; case 'T': tracefile = optarg; @@ -2829,15 +2830,17 @@ int main(int argc, char *argv[]) verbose = true; break; case 'W': - quota_nb_watch_per_domain = strtol(optarg, NULL, 10); + hard_quotas[ACC_WATCH].val = strtoul(optarg, NULL, 10); break; case 'A': - quota_nb_perms_per_node = strtol(optarg, NULL, 10); + hard_quotas[ACC_NPERM].val = strtoul(optarg, NULL, 10); break; case 'M': - quota_max_path_len = strtol(optarg, NULL, 10); - quota_max_path_len = min(XENSTORE_REL_PATH_MAX, - quota_max_path_len); + hard_quotas[ACC_PATHLEN].val = + strtoul(optarg, NULL, 10); + hard_quotas[ACC_PATHLEN].val = + min((unsigned int)XENSTORE_REL_PATH_MAX, + hard_quotas[ACC_PATHLEN].val); break; case 'Q': set_quota(optarg, false); diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 752c69d80f..e3a987028a 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -307,16 +307,6 @@ extern TDB_CONTEXT *tdb_ctx; extern int dom0_domid; extern int dom0_event; extern int priv_domid; -extern int quota_nb_watch_per_domain; -extern int quota_max_transaction; -extern int quota_max_entry_size; -extern int quota_nb_perms_per_node; -extern int quota_max_path_len; -extern int quota_nb_entry_per_domain; -extern int quota_req_outstanding; -extern int quota_trans_nodes; -extern int quota_memory_per_domain_soft; -extern int quota_memory_per_domain_hard; extern bool keep_orphans; extern unsigned int timeout_watch_event_msec; diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 2b4a551df5..1f746afd70 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -43,7 +43,61 @@ static evtchn_port_t virq_port; xenevtchn_handle *xce_handle = NULL; -static unsigned int acc_global_max[ACC_N]; +struct quota hard_quotas[ACC_N] = { + [ACC_NODES] = { + .name = "nodes", + .descr = "Nodes per domain", + .val = 1000, + }, + [ACC_WATCH] = { + .name = "watches", + .descr = "Watches per domain", + .val = 128, + }, + [ACC_OUTST] = { + .name = "outstanding", + .descr = "Outstanding requests per domain", + .val = 20, + }, + [ACC_MEM] = { + .name = "memory", + .descr = "Total Xenstore memory per domain (error level)", + .val = 2 * 1024 * 1024 + 512 * 1024, /* 2.5 MB */ + }, + [ACC_TRANS] = { + .name = "transactions", + .descr = "Active transactions per domain", + .val = 10, + }, + [ACC_TRANSNODES] = { + .name = "transaction-nodes", + .descr = "Max. number of accessed nodes per transaction", + .val = 1024, + }, + [ACC_NPERM] = { + .name = "node-permissions", + .descr = "Max. number of permissions per node", + .val = 5, + }, + [ACC_PATHLEN] = { + .name = "path-max", + .descr = "Max. length of a node path", + .val = XENSTORE_REL_PATH_MAX, + }, + [ACC_NODESZ] = { + .name = "node-size", + .descr = "Max. size of a node", + .val = 2048, + }, +}; + +struct quota soft_quotas[ACC_N] = { + [ACC_MEM] = { + .name = "memory", + .descr = "Total Xenstore memory per domain (warning level)", + .val = 2 * 1024 * 1024, /* 2.0 MB */ + }, +}; struct domain { @@ -204,10 +258,10 @@ static bool domain_can_read(struct connection *conn) if (domain_is_unprivileged(conn)) { if (domain->wrl_credit < 0) return false; - if (domain->acc[ACC_OUTST].val >= quota_req_outstanding) + if (domain->acc[ACC_OUTST].val >= hard_quotas[ACC_OUTST].val) return false; - if (domain->acc[ACC_MEM].val >= quota_memory_per_domain_hard && - quota_memory_per_domain_hard) + if (domain->acc[ACC_MEM].val >= hard_quotas[ACC_MEM].val && + hard_quotas[ACC_MEM].val) return false; } @@ -426,6 +480,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, { struct domain *d = find_domain_struct(domid); char *resp; + unsigned int i; if (!d) return ENOENT; @@ -434,19 +489,15 @@ int domain_get_quota(const void *ctx, struct connection *conn, if (!resp) return ENOMEM; -#define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-17s: %8u (max: %8u\n", #t, \ - d->acc[e].val, d->acc[e].max); \ - if (!resp) return ENOMEM - - ent(nodes, ACC_NODES); - ent(watches, ACC_WATCH); - ent(transactions, ACC_TRANS); - ent(outstanding, ACC_OUTST); - ent(memory, ACC_MEM); - ent(transaction-nodes, ACC_TRANSNODES); - -#undef ent + for (i = 0; i < ACC_N; i++) { + if (!hard_quotas[i].name) + continue; + resp = talloc_asprintf_append(resp, "%-17s: %8u (max %8u)\n", + hard_quotas[i].name, + d->acc[i].val, d->acc[i].max); + if (!resp) + return ENOMEM; + } send_reply(conn, XS_CONTROL, resp, strlen(resp) + 1); @@ -456,24 +507,21 @@ int domain_get_quota(const void *ctx, struct connection *conn, int domain_max_global_acc(const void *ctx, struct connection *conn) { char *resp; + unsigned int i; resp = talloc_asprintf(ctx, "Max. seen accounting values:\n"); if (!resp) return ENOMEM; -#define ent(t, e) \ - resp = talloc_asprintf_append(resp, "%-17s: %8u\n", #t, \ - acc_global_max[e]); \ - if (!resp) return ENOMEM - - ent(nodes, ACC_NODES); - ent(watches, ACC_WATCH); - ent(transactions, ACC_TRANS); - ent(outstanding, ACC_OUTST); - ent(memory, ACC_MEM); - ent(transaction-nodes, ACC_TRANSNODES); - -#undef ent + for (i = 0; i < ACC_N; i++) { + if (!hard_quotas[i].name) + continue; + resp = talloc_asprintf_append(resp, "%-17s: %8u\n", + hard_quotas[i].name, + hard_quotas[i].max); + if (!resp) + return ENOMEM; + } send_reply(conn, XS_CONTROL, resp, strlen(resp) + 1); @@ -592,7 +640,7 @@ int acc_fix_domains(struct list_head *head, bool update) list_for_each_entry(cd, head, list) { cnt = domain_nbentry_fix(cd->domid, cd->acc[ACC_NODES], update); if (!update) { - if (cnt >= quota_nb_entry_per_domain) + if (cnt >= hard_quotas[ACC_NODES].val) return ENOSPC; if (cnt < 0) return ENOMEM; @@ -1091,8 +1139,8 @@ static void domain_acc_chk_max(struct domain *d, unsigned int what, { if (val > d->acc[what].max) d->acc[what].max = val; - if (val > acc_global_max[what] && domid_is_unprivileged(domid)) - acc_global_max[what] = val; + if (val > hard_quotas[what].max && domid_is_unprivileged(domid)) + hard_quotas[what].max = val; } static int domain_acc_add_chk(struct domain *d, unsigned int what, int add, @@ -1218,19 +1266,19 @@ void domain_reset_global_acc(void) unsigned int i; for (i = 0; i < ACC_N; i++) - acc_global_max[i] = 0; + hard_quotas[i].max = 0; /* Set current max values seen. */ hashtable_iterate(domhash, domain_reset_global_acc_sub, NULL); } bool domain_max_chk(const struct connection *conn, unsigned int what, - unsigned int val, unsigned int quota) + unsigned int val) { if (!conn || !conn->domain) return false; - if (domain_is_unprivileged(conn) && val > quota) + if (domain_is_unprivileged(conn) && val > hard_quotas[what].val) return true; domain_acc_chk_max(conn->domain, what, val, conn->id); @@ -1279,8 +1327,7 @@ static bool domain_chk_quota(struct connection *conn, unsigned int mem) domain = conn->domain; now = time(NULL); - if (mem >= quota_memory_per_domain_hard && - quota_memory_per_domain_hard) { + if (mem >= hard_quotas[ACC_MEM].val && hard_quotas[ACC_MEM].val) { if (domain->hard_quota_reported) return true; syslog(LOG_ERR, "Domain %u exceeds hard memory quota, Xenstore interface to domain stalled\n", @@ -1297,15 +1344,14 @@ static bool domain_chk_quota(struct connection *conn, unsigned int mem) syslog(LOG_INFO, "Domain %u below hard memory quota again\n", domain->domid); } - if (mem >= quota_memory_per_domain_soft && - quota_memory_per_domain_soft && - !domain->soft_quota_reported) { + if (mem >= soft_quotas[ACC_MEM].val && + soft_quotas[ACC_MEM].val && !domain->soft_quota_reported) { domain->mem_last_msg = now; domain->soft_quota_reported = true; syslog(LOG_WARNING, "Domain %u exceeds soft memory quota\n", domain->domid); } - if (mem < quota_memory_per_domain_soft && + if (mem < soft_quotas[ACC_MEM].val && domain->soft_quota_reported) { domain->mem_last_msg = now; domain->soft_quota_reported = false; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 2bf9b0d87b..1d11085ebc 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -34,6 +34,16 @@ enum { ACC_N /* Number of elements per domain. */ }; +struct quota { + const char *name; + const char *descr; + unsigned int val; + unsigned int max; +}; + +extern struct quota hard_quotas[ACC_N]; +extern struct quota soft_quotas[ACC_N]; + void handle_event(void); void check_domains(void); @@ -123,7 +133,7 @@ void acc_commit(struct connection *conn); int domain_max_global_acc(const void *ctx, struct connection *conn); void domain_reset_global_acc(void); bool domain_max_chk(const struct connection *conn, unsigned int what, - unsigned int val, unsigned int quota); + unsigned int val); /* Write rate limiting */ diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 7967770ca2..13fabe030d 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -244,8 +244,7 @@ int access_node(struct connection *conn, struct node *node, i = find_accessed_node(trans, node->name); if (!i) { - if (domain_max_chk(conn, ACC_TRANSNODES, trans->nodes + 1, - quota_trans_nodes)) { + if (domain_max_chk(conn, ACC_TRANSNODES, trans->nodes + 1)) { ret = ENOSPC; goto err; } @@ -471,7 +470,7 @@ int do_transaction_start(const void *ctx, struct connection *conn, if (conn->transaction) return EBUSY; - if (domain_transaction_get(conn) > quota_max_transaction) + if (domain_transaction_get(conn) > hard_quotas[ACC_TRANS].val) return ENOSPC; /* Attach transaction to ctx for autofree until it's complete */ diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index 4deef21c4c..ca0194966e 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -239,7 +239,7 @@ int do_watch(const void *ctx, struct connection *conn, struct buffered_data *in) return EEXIST; } - if (domain_watch(conn) > quota_nb_watch_per_domain) + if (domain_watch(conn) > hard_quotas[ACC_WATCH].val) return E2BIG; watch = add_watch(conn, vec[0], vec[1], relative, false); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:15:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:15:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435090.688196 (Exim 4.92) (envelope-from ) id 1optvB-000467-5k; Tue, 01 Nov 2022 16:15:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435090.688196; Tue, 01 Nov 2022 16:15:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optvA-00044X-UX; Tue, 01 Nov 2022 16:15:24 +0000 Received: by outflank-mailman (input) for mailman id 435090; Tue, 01 Nov 2022 16:15:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optv9-0000i5-AG for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:15:23 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 62dddeb9-5a00-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 17:15:22 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4904E3382E; Tue, 1 Nov 2022 16:15:22 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1CF4A1346F; Tue, 1 Nov 2022 16:15:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 30vABRpGYWNCdwAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:15:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62dddeb9-5a00-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667319322; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wkI1F2q0wuo3k02I3w30xmcUIYPftf6mWJLCe27OacU=; b=UTcOeQTSFT9SOojEBqDhJP0nJ6RXmzODIkVf9DxuMqnQYqzAy2gWNtsAMPc0ocFA7GFAv2 1pxrKEuzJ6pKP6gjBHrYbetw/ISTcpdzr54LfJKeWsaz+ue4JAZRZcA52TgDMFsTpJHezh BgXJmzbhGPeEW8V4brzn7b4GSeC523I= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 04/10] tools/xenstore: let hashtable_insert() return 0 on success Date: Tue, 1 Nov 2022 17:14:51 +0100 Message-Id: <20221101161457.8470-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101161457.8470-1-jgross@suse.com> References: <20221101161457.8470-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today hashtable_insert() returns 0 in case of an error. Change that to let it return an errno value in the error case and 0 in case of success. Even if not used today, do the same switch for the return value of hashtable_expand(). Signed-off-by: Juergen Gross --- tools/xenstore/hashtable.c | 15 ++++++++++----- tools/xenstore/hashtable.h | 2 +- tools/xenstore/xenstored_core.c | 4 ++-- tools/xenstore/xenstored_domain.c | 4 ++-- tools/xenstore/xenstored_transaction.c | 4 ++-- 5 files changed, 17 insertions(+), 12 deletions(-) diff --git a/tools/xenstore/hashtable.c b/tools/xenstore/hashtable.c index 43a8caab82..1bed5ad384 100644 --- a/tools/xenstore/hashtable.c +++ b/tools/xenstore/hashtable.c @@ -105,14 +105,15 @@ static int hashtable_expand(struct hashtable *h) struct entry **pE; unsigned int newsize, i, index; /* Check we're not hitting max capacity */ - if (h->primeindex == (PRIME_TABLE_LEN - 1)) return 0; + if (h->primeindex == (PRIME_TABLE_LEN - 1)) + return ENOSPC; newsize = primes[++(h->primeindex)]; newtable = talloc_realloc(h, h->table, struct entry *, newsize); if (!newtable) { h->primeindex--; - return 0; + return ENOMEM; } h->table = newtable; @@ -136,7 +137,7 @@ static int hashtable_expand(struct hashtable *h) h->tablelength = newsize; h->loadlimit = loadlimit(h->primeindex); - return -1; + return 0; } int hashtable_insert(struct hashtable *h, void *k, void *v) @@ -153,14 +154,18 @@ int hashtable_insert(struct hashtable *h, void *k, void *v) hashtable_expand(h); } e = talloc_zero(h, struct entry); - if (NULL == e) { --(h->entrycount); return 0; } /*oom*/ + if (NULL == e) + { + --h->entrycount; + return ENOMEM; + } e->h = hash(h,k); index = indexFor(h->tablelength,e->h); e->k = k; e->v = v; e->next = h->table[index]; h->table[index] = e; - return -1; + return 0; } void *hashtable_search(struct hashtable *h, void *k) diff --git a/tools/xenstore/hashtable.h b/tools/xenstore/hashtable.h index 5575f6c1dd..99a8331bec 100644 --- a/tools/xenstore/hashtable.h +++ b/tools/xenstore/hashtable.h @@ -36,7 +36,7 @@ create_hashtable(const void *ctx, const char *name, * @param h the hashtable to insert into * @param k the key - hashtable claims ownership and will free on removal * @param v the value - does not claim ownership - * @return non-zero for successful insertion + * @return zero for successful insertion * * This function will cause the table to expand if the insertion would take * the ratio of entries to table size over the maximum load factor. diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index c4d9d275be..5d35925ed8 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2385,7 +2385,7 @@ int remember_string(struct hashtable *hash, const char *str) char *k = talloc_strdup(NULL, str); if (!k) - return 0; + return ENOMEM; return hashtable_insert(hash, k, (void *)1); } @@ -2419,7 +2419,7 @@ static int check_store_step(const void *ctx, struct connection *conn, : WALK_TREE_SKIP_CHILDREN; } - if (!remember_string(data->reachable, node->name)) + if (remember_string(data->reachable, node->name)) return WALK_TREE_ERROR_STOP; domain_check_acc_add(node, data->domains); diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index b3c288bf40..f871bdf04a 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -542,7 +542,7 @@ static struct domain *alloc_domain(const void *context, unsigned int domid) domain->generation = generation; domain->introduced = false; - if (!hashtable_insert(domhash, &domain->domid, domain)) { + if (hashtable_insert(domhash, &domain->domid, domain)) { talloc_free(domain); errno = ENOMEM; return NULL; @@ -1786,7 +1786,7 @@ static int domain_check_acc_init_sub(void *k, void *v, void *arg) */ dom->nodes = -d->acc[ACC_NODES].val; - if (!hashtable_insert(domains, &dom->domid, dom)) { + if (hashtable_insert(domains, &dom->domid, dom)) { talloc_free(dom); return -1; } diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 13fabe030d..7b2e78f104 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -588,13 +588,13 @@ int check_transactions(struct hashtable *hash) list_for_each_entry(trans, &conn->transaction_list, list) { tname = talloc_asprintf(trans, "%"PRIu64, trans->generation); - if (!tname || !remember_string(hash, tname)) + if (!tname || remember_string(hash, tname)) goto nomem; list_for_each_entry(i, &trans->accessed, list) { if (!i->ta_node) continue; - if (!remember_string(hash, i->trans_name)) + if (remember_string(hash, i->trans_name)) goto nomem; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:15:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:15:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435095.688207 (Exim 4.92) (envelope-from ) id 1optvH-0004z5-Fx; Tue, 01 Nov 2022 16:15:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435095.688207; Tue, 01 Nov 2022 16:15:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optvH-0004yq-CG; Tue, 01 Nov 2022 16:15:31 +0000 Received: by outflank-mailman (input) for mailman id 435095; Tue, 01 Nov 2022 16:15:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optvF-0000yH-8v for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:15:29 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 662faff1-5a00-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 17:15:28 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D3BAF3382E; Tue, 1 Nov 2022 16:15:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A031E1346F; Tue, 1 Nov 2022 16:15:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mjLRJR9GYWNKdwAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:15:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 662faff1-5a00-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667319327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R7SNA0TjbXqw84TAvx2L4UOdxld+IGgbLt1a5t0hQVU=; b=bZAuQg/e1wdVIjlcMwpvW7DNycqex9ZABU2aAOblEY9Ok1NLH22xsBs/viLsa/AJJs0XPg pSIAMNsSq/9B4+TJt2Agi4z80qkDLrh4zxXfKJlwPcdyk75MgZcUB581v7+i3Y3gxdfxAw Kymk2gDfWtQPKs8NjUNvy1hcrHvuhBg= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 05/10] tools/xenstore: make some write limit functions static Date: Tue, 1 Nov 2022 17:14:52 +0100 Message-Id: <20221101161457.8470-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101161457.8470-1-jgross@suse.com> References: <20221101161457.8470-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Some wrl_*() functions are only used in xenstored_domain.c, so make them static. In order to avoid the need of forward declarations, move the whole function block to the start of the file. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_domain.c | 456 +++++++++++++++--------------- tools/xenstore/xenstored_domain.h | 3 - 2 files changed, 228 insertions(+), 231 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index f871bdf04a..559687a9d9 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -157,6 +157,234 @@ struct changed_domain static struct hashtable *domhash; +static wrl_creditt wrl_config_writecost = WRL_FACTOR; +static wrl_creditt wrl_config_rate = WRL_RATE * WRL_FACTOR; +static wrl_creditt wrl_config_dburst = WRL_DBURST * WRL_FACTOR; +static wrl_creditt wrl_config_gburst = WRL_GBURST * WRL_FACTOR; +static wrl_creditt wrl_config_newdoms_dburst = + WRL_DBURST * WRL_NEWDOMS * WRL_FACTOR; + +long wrl_ntransactions; + +static long wrl_ndomains; +static wrl_creditt wrl_reserve; /* [-wrl_config_newdoms_dburst, +_gburst ] */ +static time_t wrl_log_last_warning; /* 0: no previous warning */ + +#define trace_wrl(...) \ +do { \ + if (trace_flags & TRACE_WRL) \ + trace("wrl: " __VA_ARGS__); \ +} while (0) + +void wrl_gettime_now(struct wrl_timestampt *now_wt) +{ + struct timespec now_ts; + int r; + + r = clock_gettime(CLOCK_MONOTONIC, &now_ts); + if (r) + barf_perror("Could not find time (clock_gettime failed)"); + + now_wt->sec = now_ts.tv_sec; + now_wt->msec = now_ts.tv_nsec / 1000000; +} + +static void wrl_xfer_credit(wrl_creditt *debit, wrl_creditt debit_floor, + wrl_creditt *credit, wrl_creditt credit_ceil) + /* + * Transfers zero or more credit from "debit" to "credit". + * Transfers as much as possible while maintaining + * debit >= debit_floor and credit <= credit_ceil. + * (If that's violated already, does nothing.) + * + * Sufficient conditions to avoid overflow, either of: + * |every argument| <= 0x3fffffff + * |every argument| <= 1E9 + * |every argument| <= WRL_CREDIT_MAX + * (And this condition is preserved.) + */ +{ + wrl_creditt xfer = MIN( *debit - debit_floor, + credit_ceil - *credit ); + if (xfer > 0) { + *debit -= xfer; + *credit += xfer; + } +} + +static void wrl_domain_new(struct domain *domain) +{ + domain->wrl_credit = 0; + wrl_gettime_now(&domain->wrl_timestamp); + wrl_ndomains++; + /* Steal up to DBURST from the reserve */ + wrl_xfer_credit(&wrl_reserve, -wrl_config_newdoms_dburst, + &domain->wrl_credit, wrl_config_dburst); +} + +static void wrl_domain_destroy(struct domain *domain) +{ + wrl_ndomains--; + /* + * Don't bother recalculating domain's credit - this just + * means we don't give the reserve the ending domain's credit + * for time elapsed since last update. + */ + wrl_xfer_credit(&domain->wrl_credit, 0, + &wrl_reserve, wrl_config_dburst); +} + +static void wrl_credit_update(struct domain *domain, struct wrl_timestampt now) +{ + /* + * We want to calculate + * credit += (now - timestamp) * RATE / ndoms; + * But we want it to saturate, and to avoid floating point. + * To avoid rounding errors from constantly adding small + * amounts of credit, we only add credit for whole milliseconds. + */ + long seconds = now.sec - domain->wrl_timestamp.sec; + long milliseconds = now.msec - domain->wrl_timestamp.msec; + long msec; + int64_t denom, num; + wrl_creditt surplus; + + seconds = MIN(seconds, 1000*1000); /* arbitrary, prevents overflow */ + msec = seconds * 1000 + milliseconds; + + if (msec < 0) + /* shouldn't happen with CLOCK_MONOTONIC */ + msec = 0; + + /* 32x32 -> 64 cannot overflow */ + denom = (int64_t)msec * wrl_config_rate; + num = (int64_t)wrl_ndomains * 1000; + /* denom / num <= 1E6 * wrl_config_rate, so with + reasonable wrl_config_rate, denom / num << 2^64 */ + + /* at last! */ + domain->wrl_credit = MIN( (int64_t)domain->wrl_credit + denom / num, + WRL_CREDIT_MAX ); + /* (maybe briefly violating the DBURST cap on wrl_credit) */ + + /* maybe take from the reserve to make us nonnegative */ + wrl_xfer_credit(&wrl_reserve, 0, + &domain->wrl_credit, 0); + + /* return any surplus (over DBURST) to the reserve */ + surplus = 0; + wrl_xfer_credit(&domain->wrl_credit, wrl_config_dburst, + &surplus, WRL_CREDIT_MAX); + wrl_xfer_credit(&surplus, 0, + &wrl_reserve, wrl_config_gburst); + /* surplus is now implicitly discarded */ + + domain->wrl_timestamp = now; + + trace_wrl("dom %4d %6ld msec %9ld credit %9ld reserve %9ld discard\n", + domain->domid, msec, (long)domain->wrl_credit, + (long)wrl_reserve, (long)surplus); +} + +void wrl_check_timeout(struct domain *domain, + struct wrl_timestampt now, + int *ptimeout) +{ + uint64_t num, denom; + int wakeup; + + wrl_credit_update(domain, now); + + if (domain->wrl_credit >= 0) + /* not blocked */ + return; + + if (!*ptimeout) + /* already decided on immediate wakeup, + so no need to calculate our timeout */ + return; + + /* calculate wakeup = now + -credit / (RATE / ndoms); */ + + /* credit cannot go more -ve than one transaction, + * so the first multiplication cannot overflow even 32-bit */ + num = (uint64_t)(-domain->wrl_credit * 1000) * wrl_ndomains; + denom = wrl_config_rate; + + wakeup = MIN( num / denom /* uint64_t */, INT_MAX ); + if (*ptimeout==-1 || wakeup < *ptimeout) + *ptimeout = wakeup; + + trace_wrl("domain %u credit=%ld (reserve=%ld) SLEEPING for %d\n", + domain->domid, (long)domain->wrl_credit, (long)wrl_reserve, + wakeup); +} + +#define WRL_LOG(now, ...) \ + (syslog(LOG_WARNING, "write rate limit: " __VA_ARGS__)) + +void wrl_apply_debit_actual(struct domain *domain) +{ + struct wrl_timestampt now; + + if (!domain || !domain_is_unprivileged(domain->conn)) + /* sockets and privileged domain escape the write rate limit */ + return; + + wrl_gettime_now(&now); + wrl_credit_update(domain, now); + + domain->wrl_credit -= wrl_config_writecost; + trace_wrl("domain %u credit=%ld (reserve=%ld)\n", domain->domid, + (long)domain->wrl_credit, (long)wrl_reserve); + + if (domain->wrl_credit < 0) { + if (!domain->wrl_delay_logged) { + domain->wrl_delay_logged = true; + WRL_LOG(now, "domain %ld is affected\n", + (long)domain->domid); + } else if (!wrl_log_last_warning) { + WRL_LOG(now, "rate limiting restarts\n"); + } + wrl_log_last_warning = now.sec; + } +} + +void wrl_log_periodic(struct wrl_timestampt now) +{ + if (wrl_log_last_warning && + (now.sec - wrl_log_last_warning) > WRL_LOGEVERY) { + WRL_LOG(now, "not in force recently\n"); + wrl_log_last_warning = 0; + } +} + +void wrl_apply_debit_direct(struct connection *conn) +{ + if (!conn) + /* some writes are generated internally */ + return; + + if (conn->transaction) + /* these are accounted for when the transaction ends */ + return; + + if (!wrl_ntransactions) + /* we don't conflict with anyone */ + return; + + wrl_apply_debit_actual(conn->domain); +} + +void wrl_apply_debit_trans_commit(struct connection *conn) +{ + if (wrl_ntransactions <= 1) + /* our own transaction appears in the counter */ + return; + + wrl_apply_debit_actual(conn->domain); +} + static bool check_indexes(XENSTORE_RING_IDX cons, XENSTORE_RING_IDX prod) { return ((prod - cons) <= XENSTORE_RING_SIZE); @@ -1437,234 +1665,6 @@ unsigned int domain_transaction_get(struct connection *conn) : 0; } -static wrl_creditt wrl_config_writecost = WRL_FACTOR; -static wrl_creditt wrl_config_rate = WRL_RATE * WRL_FACTOR; -static wrl_creditt wrl_config_dburst = WRL_DBURST * WRL_FACTOR; -static wrl_creditt wrl_config_gburst = WRL_GBURST * WRL_FACTOR; -static wrl_creditt wrl_config_newdoms_dburst = - WRL_DBURST * WRL_NEWDOMS * WRL_FACTOR; - -long wrl_ntransactions; - -static long wrl_ndomains; -static wrl_creditt wrl_reserve; /* [-wrl_config_newdoms_dburst, +_gburst ] */ -static time_t wrl_log_last_warning; /* 0: no previous warning */ - -#define trace_wrl(...) \ -do { \ - if (trace_flags & TRACE_WRL) \ - trace("wrl: " __VA_ARGS__); \ -} while (0) - -void wrl_gettime_now(struct wrl_timestampt *now_wt) -{ - struct timespec now_ts; - int r; - - r = clock_gettime(CLOCK_MONOTONIC, &now_ts); - if (r) - barf_perror("Could not find time (clock_gettime failed)"); - - now_wt->sec = now_ts.tv_sec; - now_wt->msec = now_ts.tv_nsec / 1000000; -} - -static void wrl_xfer_credit(wrl_creditt *debit, wrl_creditt debit_floor, - wrl_creditt *credit, wrl_creditt credit_ceil) - /* - * Transfers zero or more credit from "debit" to "credit". - * Transfers as much as possible while maintaining - * debit >= debit_floor and credit <= credit_ceil. - * (If that's violated already, does nothing.) - * - * Sufficient conditions to avoid overflow, either of: - * |every argument| <= 0x3fffffff - * |every argument| <= 1E9 - * |every argument| <= WRL_CREDIT_MAX - * (And this condition is preserved.) - */ -{ - wrl_creditt xfer = MIN( *debit - debit_floor, - credit_ceil - *credit ); - if (xfer > 0) { - *debit -= xfer; - *credit += xfer; - } -} - -void wrl_domain_new(struct domain *domain) -{ - domain->wrl_credit = 0; - wrl_gettime_now(&domain->wrl_timestamp); - wrl_ndomains++; - /* Steal up to DBURST from the reserve */ - wrl_xfer_credit(&wrl_reserve, -wrl_config_newdoms_dburst, - &domain->wrl_credit, wrl_config_dburst); -} - -void wrl_domain_destroy(struct domain *domain) -{ - wrl_ndomains--; - /* - * Don't bother recalculating domain's credit - this just - * means we don't give the reserve the ending domain's credit - * for time elapsed since last update. - */ - wrl_xfer_credit(&domain->wrl_credit, 0, - &wrl_reserve, wrl_config_dburst); -} - -void wrl_credit_update(struct domain *domain, struct wrl_timestampt now) -{ - /* - * We want to calculate - * credit += (now - timestamp) * RATE / ndoms; - * But we want it to saturate, and to avoid floating point. - * To avoid rounding errors from constantly adding small - * amounts of credit, we only add credit for whole milliseconds. - */ - long seconds = now.sec - domain->wrl_timestamp.sec; - long milliseconds = now.msec - domain->wrl_timestamp.msec; - long msec; - int64_t denom, num; - wrl_creditt surplus; - - seconds = MIN(seconds, 1000*1000); /* arbitrary, prevents overflow */ - msec = seconds * 1000 + milliseconds; - - if (msec < 0) - /* shouldn't happen with CLOCK_MONOTONIC */ - msec = 0; - - /* 32x32 -> 64 cannot overflow */ - denom = (int64_t)msec * wrl_config_rate; - num = (int64_t)wrl_ndomains * 1000; - /* denom / num <= 1E6 * wrl_config_rate, so with - reasonable wrl_config_rate, denom / num << 2^64 */ - - /* at last! */ - domain->wrl_credit = MIN( (int64_t)domain->wrl_credit + denom / num, - WRL_CREDIT_MAX ); - /* (maybe briefly violating the DBURST cap on wrl_credit) */ - - /* maybe take from the reserve to make us nonnegative */ - wrl_xfer_credit(&wrl_reserve, 0, - &domain->wrl_credit, 0); - - /* return any surplus (over DBURST) to the reserve */ - surplus = 0; - wrl_xfer_credit(&domain->wrl_credit, wrl_config_dburst, - &surplus, WRL_CREDIT_MAX); - wrl_xfer_credit(&surplus, 0, - &wrl_reserve, wrl_config_gburst); - /* surplus is now implicitly discarded */ - - domain->wrl_timestamp = now; - - trace_wrl("dom %4d %6ld msec %9ld credit %9ld reserve %9ld discard\n", - domain->domid, msec, (long)domain->wrl_credit, - (long)wrl_reserve, (long)surplus); -} - -void wrl_check_timeout(struct domain *domain, - struct wrl_timestampt now, - int *ptimeout) -{ - uint64_t num, denom; - int wakeup; - - wrl_credit_update(domain, now); - - if (domain->wrl_credit >= 0) - /* not blocked */ - return; - - if (!*ptimeout) - /* already decided on immediate wakeup, - so no need to calculate our timeout */ - return; - - /* calculate wakeup = now + -credit / (RATE / ndoms); */ - - /* credit cannot go more -ve than one transaction, - * so the first multiplication cannot overflow even 32-bit */ - num = (uint64_t)(-domain->wrl_credit * 1000) * wrl_ndomains; - denom = wrl_config_rate; - - wakeup = MIN( num / denom /* uint64_t */, INT_MAX ); - if (*ptimeout==-1 || wakeup < *ptimeout) - *ptimeout = wakeup; - - trace_wrl("domain %u credit=%ld (reserve=%ld) SLEEPING for %d\n", - domain->domid, (long)domain->wrl_credit, (long)wrl_reserve, - wakeup); -} - -#define WRL_LOG(now, ...) \ - (syslog(LOG_WARNING, "write rate limit: " __VA_ARGS__)) - -void wrl_apply_debit_actual(struct domain *domain) -{ - struct wrl_timestampt now; - - if (!domain || !domid_is_unprivileged(domain->domid)) - /* sockets and privileged domain escape the write rate limit */ - return; - - wrl_gettime_now(&now); - wrl_credit_update(domain, now); - - domain->wrl_credit -= wrl_config_writecost; - trace_wrl("domain %u credit=%ld (reserve=%ld)\n", domain->domid, - (long)domain->wrl_credit, (long)wrl_reserve); - - if (domain->wrl_credit < 0) { - if (!domain->wrl_delay_logged) { - domain->wrl_delay_logged = true; - WRL_LOG(now, "domain %ld is affected\n", - (long)domain->domid); - } else if (!wrl_log_last_warning) { - WRL_LOG(now, "rate limiting restarts\n"); - } - wrl_log_last_warning = now.sec; - } -} - -void wrl_log_periodic(struct wrl_timestampt now) -{ - if (wrl_log_last_warning && - (now.sec - wrl_log_last_warning) > WRL_LOGEVERY) { - WRL_LOG(now, "not in force recently\n"); - wrl_log_last_warning = 0; - } -} - -void wrl_apply_debit_direct(struct connection *conn) -{ - if (!conn) - /* some writes are generated internally */ - return; - - if (conn->transaction) - /* these are accounted for when the transaction ends */ - return; - - if (!wrl_ntransactions) - /* we don't conflict with anyone */ - return; - - wrl_apply_debit_actual(conn->domain); -} - -void wrl_apply_debit_trans_commit(struct connection *conn) -{ - if (wrl_ntransactions <= 1) - /* our own transaction appears in the counter */ - return; - - wrl_apply_debit_actual(conn->domain); -} - const char *dump_state_connections(FILE *fp) { const char *ret = NULL; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index 1d11085ebc..b691a28778 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -152,9 +152,6 @@ struct wrl_timestampt { extern long wrl_ntransactions; void wrl_gettime_now(struct wrl_timestampt *now_ts); -void wrl_domain_new(struct domain *domain); -void wrl_domain_destroy(struct domain *domain); -void wrl_credit_update(struct domain *domain, struct wrl_timestampt now); void wrl_check_timeout(struct domain *domain, struct wrl_timestampt now, int *ptimeout); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:25:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:25:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435122.688223 (Exim 4.92) (envelope-from ) id 1opu4d-0008QM-Rw; Tue, 01 Nov 2022 16:25:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435122.688223; Tue, 01 Nov 2022 16:25:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opu4d-0008Po-Mg; Tue, 01 Nov 2022 16:25:11 +0000 Received: by outflank-mailman (input) for mailman id 435122; Tue, 01 Nov 2022 16:25:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optvM-0000i5-0k for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:15:36 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 698050f7-5a00-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 17:15:33 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 68E353382E; Tue, 1 Nov 2022 16:15:33 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3D9D71346F; Tue, 1 Nov 2022 16:15:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id VJ3IDSVGYWNadwAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:15:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 698050f7-5a00-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667319333; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rMRJEUOJ3aRwlNByoJe0UnjE1hGXLfxM7z6HnPQjpTg=; b=LkklC2O/2gLEIwig1MTllAL6tTicHJ7NtHo8PBAN8jEL49AihkQQd7J+DP6H+blTCOKviS Hx3nLBbsoeYOS+g2NbyzWk9zUCt2mob6kgsEvL+/KGeotvPci/B2BUlkKIbuAtBDbsN9gm Dq3dhFT4k7NHl/pYyvaQDRpi4xZ7xdA= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 06/10] tools/xenstore: switch write limiting to use millisecond time base Date: Tue, 1 Nov 2022 17:14:53 +0100 Message-Id: <20221101161457.8470-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101161457.8470-1-jgross@suse.com> References: <20221101161457.8470-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There is no need to keep struct wrl_timestampt, as it serves the same purpose as the more simple time base provided by get_now(). Move some more stuff from xenstored_domain.h into xenstored_domain.c as it is being used nowhere else. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 8 ++--- tools/xenstore/xenstored_core.h | 7 ++-- tools/xenstore/xenstored_domain.c | 56 +++++++++++++------------------ tools/xenstore/xenstored_domain.h | 21 ++---------- 4 files changed, 32 insertions(+), 60 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 5d35925ed8..5fcf96c77a 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -192,7 +192,7 @@ void reopen_log(void) } } -static uint64_t get_now_msec(void) +uint64_t get_now_msec(void) { struct timespec now_ts; @@ -510,7 +510,6 @@ fail: static void initialize_fds(int *p_sock_pollfd_idx, int *ptimeout) { struct connection *conn; - struct wrl_timestampt now; uint64_t msecs; if (fds) @@ -530,13 +529,12 @@ static void initialize_fds(int *p_sock_pollfd_idx, int *ptimeout) xce_pollfd_idx = set_fd(xenevtchn_fd(xce_handle), POLLIN|POLLPRI); - wrl_gettime_now(&now); - wrl_log_periodic(now); msecs = get_now_msec(); + wrl_log_periodic(msecs); list_for_each_entry(conn, &connections, list) { if (conn->domain) { - wrl_check_timeout(conn->domain, now, ptimeout); + wrl_check_timeout(conn->domain, msecs, ptimeout); check_event_timeout(conn, msecs, ptimeout); if (conn_can_read(conn) || (conn_can_write(conn) && diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index e3a987028a..ecfa987272 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -47,10 +47,6 @@ /* DEFAULT_BUFFER_SIZE should be large enough for each errno string. */ #define DEFAULT_BUFFER_SIZE 16 -typedef int32_t wrl_creditt; -#define WRL_CREDIT_MAX (1000*1000*1000) -/* ^ satisfies non-overflow condition for wrl_xfer_credit */ - struct xs_state_connection; struct buffered_data @@ -311,6 +307,9 @@ extern bool keep_orphans; extern unsigned int timeout_watch_event_msec; +/* Get internal time in milliseconds. */ +uint64_t get_now_msec(void); + /* Map the kernel's xenstore page. */ void *xenbus_map(void); void unmap_xenbus(void *interface); diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 559687a9d9..329815ffc3 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -99,6 +99,8 @@ struct quota soft_quotas[ACC_N] = { }, }; +typedef int32_t wrl_creditt; + struct domain { /* The id of this domain */ @@ -139,7 +141,7 @@ struct domain /* write rate limit */ wrl_creditt wrl_credit; /* [ -wrl_config_writecost, +_dburst ] */ - struct wrl_timestampt wrl_timestamp; + uint64_t wrl_timestamp; bool wrl_delay_logged; }; @@ -157,6 +159,17 @@ struct changed_domain static struct hashtable *domhash; +/* Write rate limiting */ + +/* Satisfies non-overflow condition for wrl_xfer_credit. */ +#define WRL_CREDIT_MAX (1000*1000*1000) +#define WRL_FACTOR 1000 /* for fixed-point arithmetic */ +#define WRL_RATE 200 +#define WRL_DBURST 10 +#define WRL_GBURST 1000 +#define WRL_NEWDOMS 5 +#define WRL_LOGEVERY 120 /* seconds */ + static wrl_creditt wrl_config_writecost = WRL_FACTOR; static wrl_creditt wrl_config_rate = WRL_RATE * WRL_FACTOR; static wrl_creditt wrl_config_dburst = WRL_DBURST * WRL_FACTOR; @@ -176,19 +189,6 @@ do { \ trace("wrl: " __VA_ARGS__); \ } while (0) -void wrl_gettime_now(struct wrl_timestampt *now_wt) -{ - struct timespec now_ts; - int r; - - r = clock_gettime(CLOCK_MONOTONIC, &now_ts); - if (r) - barf_perror("Could not find time (clock_gettime failed)"); - - now_wt->sec = now_ts.tv_sec; - now_wt->msec = now_ts.tv_nsec / 1000000; -} - static void wrl_xfer_credit(wrl_creditt *debit, wrl_creditt debit_floor, wrl_creditt *credit, wrl_creditt credit_ceil) /* @@ -215,7 +215,7 @@ static void wrl_xfer_credit(wrl_creditt *debit, wrl_creditt debit_floor, static void wrl_domain_new(struct domain *domain) { domain->wrl_credit = 0; - wrl_gettime_now(&domain->wrl_timestamp); + domain->wrl_timestamp = get_now_msec(); wrl_ndomains++; /* Steal up to DBURST from the reserve */ wrl_xfer_credit(&wrl_reserve, -wrl_config_newdoms_dburst, @@ -234,7 +234,7 @@ static void wrl_domain_destroy(struct domain *domain) &wrl_reserve, wrl_config_dburst); } -static void wrl_credit_update(struct domain *domain, struct wrl_timestampt now) +static void wrl_credit_update(struct domain *domain, uint64_t now) { /* * We want to calculate @@ -243,18 +243,12 @@ static void wrl_credit_update(struct domain *domain, struct wrl_timestampt now) * To avoid rounding errors from constantly adding small * amounts of credit, we only add credit for whole milliseconds. */ - long seconds = now.sec - domain->wrl_timestamp.sec; - long milliseconds = now.msec - domain->wrl_timestamp.msec; long msec; int64_t denom, num; wrl_creditt surplus; - seconds = MIN(seconds, 1000*1000); /* arbitrary, prevents overflow */ - msec = seconds * 1000 + milliseconds; - - if (msec < 0) - /* shouldn't happen with CLOCK_MONOTONIC */ - msec = 0; + /* Prevent overflow by limiting to 32 bits. */ + msec = MIN(now - domain->wrl_timestamp, 1000 * 1000 * 1000); /* 32x32 -> 64 cannot overflow */ denom = (int64_t)msec * wrl_config_rate; @@ -286,9 +280,7 @@ static void wrl_credit_update(struct domain *domain, struct wrl_timestampt now) (long)wrl_reserve, (long)surplus); } -void wrl_check_timeout(struct domain *domain, - struct wrl_timestampt now, - int *ptimeout) +void wrl_check_timeout(struct domain *domain, uint64_t now, int *ptimeout) { uint64_t num, denom; int wakeup; @@ -325,13 +317,13 @@ void wrl_check_timeout(struct domain *domain, void wrl_apply_debit_actual(struct domain *domain) { - struct wrl_timestampt now; + uint64_t now; if (!domain || !domain_is_unprivileged(domain->conn)) /* sockets and privileged domain escape the write rate limit */ return; - wrl_gettime_now(&now); + now = get_now_msec(); wrl_credit_update(domain, now); domain->wrl_credit -= wrl_config_writecost; @@ -346,14 +338,14 @@ void wrl_apply_debit_actual(struct domain *domain) } else if (!wrl_log_last_warning) { WRL_LOG(now, "rate limiting restarts\n"); } - wrl_log_last_warning = now.sec; + wrl_log_last_warning = now / 1000; } } -void wrl_log_periodic(struct wrl_timestampt now) +void wrl_log_periodic(uint64_t now) { if (wrl_log_last_warning && - (now.sec - wrl_log_last_warning) > WRL_LOGEVERY) { + (now / 1000 - wrl_log_last_warning) > WRL_LOGEVERY) { WRL_LOG(now, "not in force recently\n"); wrl_log_last_warning = 0; } diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index b691a28778..1ab0a220f2 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -135,27 +135,10 @@ void domain_reset_global_acc(void); bool domain_max_chk(const struct connection *conn, unsigned int what, unsigned int val); -/* Write rate limiting */ - -#define WRL_FACTOR 1000 /* for fixed-point arithmetic */ -#define WRL_RATE 200 -#define WRL_DBURST 10 -#define WRL_GBURST 1000 -#define WRL_NEWDOMS 5 -#define WRL_LOGEVERY 120 /* seconds */ - -struct wrl_timestampt { - time_t sec; - int msec; -}; - extern long wrl_ntransactions; -void wrl_gettime_now(struct wrl_timestampt *now_ts); -void wrl_check_timeout(struct domain *domain, - struct wrl_timestampt now, - int *ptimeout); -void wrl_log_periodic(struct wrl_timestampt now); +void wrl_check_timeout(struct domain *domain, uint64_t now, int *ptimeout); +void wrl_log_periodic(uint64_t now); void wrl_apply_debit_direct(struct connection *conn); void wrl_apply_debit_trans_commit(struct connection *conn); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:25:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:25:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435119.688218 (Exim 4.92) (envelope-from ) id 1opu4d-0008Oo-Jv; Tue, 01 Nov 2022 16:25:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435119.688218; Tue, 01 Nov 2022 16:25:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opu4d-0008Og-FF; Tue, 01 Nov 2022 16:25:11 +0000 Received: by outflank-mailman (input) for mailman id 435119; Tue, 01 Nov 2022 16:25:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optvV-0000i5-CS for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:15:45 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 701c7b69-5a00-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 17:15:44 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 80B543382E; Tue, 1 Nov 2022 16:15:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 53A851346F; Tue, 1 Nov 2022 16:15:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id djYBEzBGYWOHdwAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:15:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 701c7b69-5a00-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667319344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IGeFv24ZPr/KZ3pFnNba31NdyHUcNMT973heFZoLWFU=; b=T7J3HDkC1l+3rUaVhUunMHYySpYRhVEQhxj6aYRXboYzG0eM5jAtqwPy+Y5ztLlixdE9Cp jFxZViANVTYtICCiE/OUOfbzUhZcQmhexZ7BjVWfAL+PNEY7kDBkLzOjAkIP3pP/IAlCJp MA5cjgldwEMICM5h6IrDvNF88tMcxWM= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 08/10] tools/xenstore: remove unused events list Date: Tue, 1 Nov 2022 17:14:55 +0100 Message-Id: <20221101161457.8470-9-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101161457.8470-1-jgross@suse.com> References: <20221101161457.8470-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit struct watch contains an used struct list_head events. Remove it. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_watch.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index ca0194966e..0078c60f32 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -36,9 +36,6 @@ struct watch /* Watches on this connection */ struct list_head list; - /* Current outstanding events applying to this watch. */ - struct list_head events; - /* Offset into path for skipping prefix (used for relative paths). */ unsigned int prefix_len; @@ -205,8 +202,6 @@ static struct watch *add_watch(struct connection *conn, char *path, char *token, watch->prefix_len = relative ? strlen(get_implicit_path(conn)) + 1 : 0; - INIT_LIST_HEAD(&watch->events); - domain_watch_inc(conn); list_add_tail(&watch->list, &conn->watches); talloc_set_destructor(watch, destroy_watch); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:25:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:25:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435128.688240 (Exim 4.92) (envelope-from ) id 1opu4m-0000bV-7w; Tue, 01 Nov 2022 16:25:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435128.688240; Tue, 01 Nov 2022 16:25:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opu4m-0000bM-4q; Tue, 01 Nov 2022 16:25:20 +0000 Received: by outflank-mailman (input) for mailman id 435128; Tue, 01 Nov 2022 16:25:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optvg-0000i5-TD for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:15:57 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 76c72637-5a00-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 17:15:55 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AC6F21F90F; Tue, 1 Nov 2022 16:15:55 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 79BBE1346F; Tue, 1 Nov 2022 16:15:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id E81QHDtGYWOadwAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:15:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76c72637-5a00-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667319355; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NwUivDjaxbqaMaYd71PIDNVF/acd+ugyV6m7DW6bCCE=; b=LAfcGAD/f0G8jxFhOEnhq4NYiVUAVpLGaAo4xbrzDiB6caXDy1oqhMF8Dd6AU9uQG/oyzg bd/eGb3CVLzK7U/EmluFNP2j+3Vb1QHsTdZjLbMVGDWhfgwMLxbRKbSr7Sc+Vv+qM6SlCe zRgCuu6ioPH3VVqioqaAQm2PByqHRSs= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD , Julien Grall Subject: [PATCH 10/10] tools/xenstore: remove no longer needed functions from xs_lib.c Date: Tue, 1 Nov 2022 17:14:57 +0100 Message-Id: <20221101161457.8470-11-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101161457.8470-1-jgross@suse.com> References: <20221101161457.8470-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xs_daemon_tdb() in xs_lib.c is no longer used at all, so it can be removed. xs_domain_dev() is not used by xenstored, so it can be moved to tools/libs/store/xs.c. Move functions used by xenstore-client only to xenstore_client.c. Signed-off-by: Juergen Gross --- tools/libs/store/xs.c | 20 +++++ tools/xenstore/xenstore_client.c | 129 +++++++++++++++++++++++++++++ tools/xenstore/xs_lib.c | 138 ------------------------------- tools/xenstore/xs_lib.h | 17 ---- 4 files changed, 149 insertions(+), 155 deletions(-) diff --git a/tools/libs/store/xs.c b/tools/libs/store/xs.c index 7a9a8b1656..70e64fccb8 100644 --- a/tools/libs/store/xs.c +++ b/tools/libs/store/xs.c @@ -311,6 +311,26 @@ struct xs_handle *xs_domain_open(void) return xs_open(0); } +static const char *xs_domain_dev(void) +{ + char *s = getenv("XENSTORED_PATH"); + if (s) + return s; +#if defined(__RUMPUSER_XEN__) || defined(__RUMPRUN__) + return "/dev/xen/xenbus"; +#elif defined(__linux__) + if (access("/dev/xen/xenbus", F_OK) == 0) + return "/dev/xen/xenbus"; + return "/proc/xen/xenbus"; +#elif defined(__NetBSD__) + return "/kern/xen/xenbus"; +#elif defined(__FreeBSD__) + return "/dev/xen/xenstore"; +#else + return "/dev/xen/xenbus"; +#endif +} + struct xs_handle *xs_open(unsigned long flags) { struct xs_handle *xsh = NULL; diff --git a/tools/xenstore/xenstore_client.c b/tools/xenstore/xenstore_client.c index 0628ba275e..8ff8abf12a 100644 --- a/tools/xenstore/xenstore_client.c +++ b/tools/xenstore/xenstore_client.c @@ -8,6 +8,7 @@ * */ +#include #include #include #include @@ -40,12 +41,140 @@ enum mode { MODE_watch, }; +/* Sanitising (quoting) possibly-binary strings. */ +struct expanding_buffer { + char *buf; + int avail; +}; + static char *output_buf = NULL; static int output_pos = 0; static struct expanding_buffer ebuf; static int output_size = 0; +/* Ensure that given expanding buffer has at least min_avail characters. */ +static char *expanding_buffer_ensure(struct expanding_buffer *ebuf, + int min_avail) +{ + int want; + char *got; + + if ( ebuf->avail >= min_avail ) + return ebuf->buf; + + if ( min_avail >= INT_MAX/3 ) + return 0; + + want = ebuf->avail + min_avail + 10; + got = realloc(ebuf->buf, want); + if ( !got ) + return 0; + + ebuf->buf = got; + ebuf->avail = want; + return ebuf->buf; +} + +/* sanitise_value() may return NULL if malloc fails. */ +static char *sanitise_value(struct expanding_buffer *ebuf, + const char *val, unsigned len) +{ + int used, remain, c; + unsigned char *ip; + +#define ADD(c) (ebuf->buf[used++] = (c)) +#define ADDF(f,c) (used += sprintf(ebuf->buf+used, (f), (c))) + + assert(len < INT_MAX/5); + + ip = (unsigned char *)val; + used = 0; + remain = len; + + if ( !expanding_buffer_ensure(ebuf, remain + 1) ) + return NULL; + + while ( remain-- > 0 ) + { + c= *ip++; + + if ( c >= ' ' && c <= '~' && c != '\\' ) + { + ADD(c); + continue; + } + + if ( !expanding_buffer_ensure(ebuf, used + remain + 5) ) + /* for "\\nnn\0" */ + return 0; + + ADD('\\'); + switch (c) + { + case '\t': ADD('t'); break; + case '\n': ADD('n'); break; + case '\r': ADD('r'); break; + case '\\': ADD('\\'); break; + default: + if ( c < 010 ) ADDF("%03o", c); + else ADDF("x%02x", c); + } + } + + ADD(0); + assert(used <= ebuf->avail); + return ebuf->buf; + +#undef ADD +#undef ADDF +} + +/* *out_len_r on entry is ignored; out must be at least strlen(in)+1 bytes. */ +static void unsanitise_value(char *out, unsigned *out_len_r, const char *in) +{ + const char *ip; + char *op; + unsigned c; + int n; + + for ( ip = in, op = out; (c = *ip++); *op++ = c ) + { + if ( c == '\\' ) + { + c = *ip++; + +#define GETF(f) do \ +{ \ + n = 0; \ + sscanf(ip, f "%n", &c, &n); \ + ip += n; \ +} while ( 0 ) + + switch ( c ) + { + case 't': c= '\t'; break; + case 'n': c= '\n'; break; + case 'r': c= '\r'; break; + case '\\': c= '\\'; break; + case 'x': GETF("%2x"); break; + case '0': case '4': + case '1': case '5': + case '2': case '6': + case '3': case '7': --ip; GETF("%3o"); break; + case 0: --ip; break; + default:; + } +#undef GETF + } + } + + *op = 0; + + if ( out_len_r ) + *out_len_r = op - out; +} + /* make sure there is at least 'len' more space in output_buf */ static void expand_buffer(size_t len) { diff --git a/tools/xenstore/xs_lib.c b/tools/xenstore/xs_lib.c index b9941c567c..1cfa9236bd 100644 --- a/tools/xenstore/xs_lib.c +++ b/tools/xenstore/xs_lib.c @@ -49,13 +49,6 @@ static const char *xs_daemon_path(void) return buf; } -const char *xs_daemon_tdb(void) -{ - static char buf[PATH_MAX]; - snprintf(buf, sizeof(buf), "%s/tdb", xs_daemon_rootdir()); - return buf; -} - const char *xs_daemon_socket(void) { return xs_daemon_path(); @@ -66,26 +59,6 @@ const char *xs_daemon_socket_ro(void) return xs_daemon_path(); } -const char *xs_domain_dev(void) -{ - char *s = getenv("XENSTORED_PATH"); - if (s) - return s; -#if defined(__RUMPUSER_XEN__) || defined(__RUMPRUN__) - return "/dev/xen/xenbus"; -#elif defined(__linux__) - if (access("/dev/xen/xenbus", F_OK) == 0) - return "/dev/xen/xenbus"; - return "/proc/xen/xenbus"; -#elif defined(__NetBSD__) - return "/kern/xen/xenbus"; -#elif defined(__FreeBSD__) - return "/dev/xen/xenstore"; -#else - return "/dev/xen/xenbus"; -#endif -} - /* Simple routines for writing to sockets, etc. */ bool xs_write_all(int fd, const void *data, unsigned int len) { @@ -179,114 +152,3 @@ unsigned int xs_count_strings(const char *strings, unsigned int len) return num; } - -char *expanding_buffer_ensure(struct expanding_buffer *ebuf, int min_avail) -{ - int want; - char *got; - - if (ebuf->avail >= min_avail) - return ebuf->buf; - - if (min_avail >= INT_MAX/3) - return 0; - - want = ebuf->avail + min_avail + 10; - got = realloc(ebuf->buf, want); - if (!got) - return 0; - - ebuf->buf = got; - ebuf->avail = want; - return ebuf->buf; -} - -char *sanitise_value(struct expanding_buffer *ebuf, - const char *val, unsigned len) -{ - int used, remain, c; - unsigned char *ip; - -#define ADD(c) (ebuf->buf[used++] = (c)) -#define ADDF(f,c) (used += sprintf(ebuf->buf+used, (f), (c))) - - assert(len < INT_MAX/5); - - ip = (unsigned char *)val; - used = 0; - remain = len; - - if (!expanding_buffer_ensure(ebuf, remain + 1)) - return NULL; - - while (remain-- > 0) { - c= *ip++; - - if (c >= ' ' && c <= '~' && c != '\\') { - ADD(c); - continue; - } - - if (!expanding_buffer_ensure(ebuf, used + remain + 5)) - /* for "\\nnn\0" */ - return 0; - - ADD('\\'); - switch (c) { - case '\t': ADD('t'); break; - case '\n': ADD('n'); break; - case '\r': ADD('r'); break; - case '\\': ADD('\\'); break; - default: - if (c < 010) ADDF("%03o", c); - else ADDF("x%02x", c); - } - } - - ADD(0); - assert(used <= ebuf->avail); - return ebuf->buf; - -#undef ADD -#undef ADDF -} - -void unsanitise_value(char *out, unsigned *out_len_r, const char *in) -{ - const char *ip; - char *op; - unsigned c; - int n; - - for (ip = in, op = out; (c = *ip++); *op++ = c) { - if (c == '\\') { - c = *ip++; - -#define GETF(f) do { \ - n = 0; \ - sscanf(ip, f "%n", &c, &n); \ - ip += n; \ - } while (0) - - switch (c) { - case 't': c= '\t'; break; - case 'n': c= '\n'; break; - case 'r': c= '\r'; break; - case '\\': c= '\\'; break; - case 'x': GETF("%2x"); break; - case '0': case '4': - case '1': case '5': - case '2': case '6': - case '3': case '7': --ip; GETF("%3o"); break; - case 0: --ip; break; - default:; - } -#undef GETF - } - } - - *op = 0; - - if (out_len_r) - *out_len_r = op - out; -} diff --git a/tools/xenstore/xs_lib.h b/tools/xenstore/xs_lib.h index efa05997d6..61229aa435 100644 --- a/tools/xenstore/xs_lib.h +++ b/tools/xenstore/xs_lib.h @@ -22,8 +22,6 @@ #include "xenstore_lib.h" const char *xs_daemon_rootdir(void); -const char *xs_domain_dev(void); -const char *xs_daemon_tdb(void); /* Convert permissions to a string (up to len MAX_STRLEN(unsigned int)+1). */ bool xs_perm_to_string(const struct xs_permissions *perm, @@ -32,19 +30,4 @@ bool xs_perm_to_string(const struct xs_permissions *perm, /* Given a string and a length, count how many strings (nul terms). */ unsigned int xs_count_strings(const char *strings, unsigned int len); -/* Sanitising (quoting) possibly-binary strings. */ -struct expanding_buffer { - char *buf; - int avail; -}; - -/* Ensure that given expanding buffer has at least min_avail characters. */ -char *expanding_buffer_ensure(struct expanding_buffer *, int min_avail); - -/* sanitise_value() may return NULL if malloc fails. */ -char *sanitise_value(struct expanding_buffer *, const char *val, unsigned len); - -/* *out_len_r on entry is ignored; out must be at least strlen(in)+1 bytes. */ -void unsanitise_value(char *out, unsigned *out_len_r, const char *in); - #endif /* XS_LIB_H */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:25:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:25:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435130.688251 (Exim 4.92) (envelope-from ) id 1opu4n-0000t1-Hs; Tue, 01 Nov 2022 16:25:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435130.688251; Tue, 01 Nov 2022 16:25:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opu4n-0000sq-Dq; Tue, 01 Nov 2022 16:25:21 +0000 Received: by outflank-mailman (input) for mailman id 435130; Tue, 01 Nov 2022 16:25:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optvc-0000yH-Ra for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:15:52 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 736f26f5-5a00-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 17:15:50 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 182473382E; Tue, 1 Nov 2022 16:15:50 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DE1D51346F; Tue, 1 Nov 2022 16:15:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YhHLNDVGYWOSdwAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:15:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 736f26f5-5a00-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667319350; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WhOM3PNzD9bJCGoKKo33Zgli+2MPQr6UTZsqeC1HgWI=; b=eG9FjtjWP236isyPLSn4cWvJOdhSGJQKWtpUvyKcxBklDbp3krOAkwfa5IbKUi+K897HEq NNepjiSyG9K1qoT+RgBUA2kISTUQkelJ3RRROHcdfPxELrkLccd5pUgRlB+XO5+s+EQvf7 EICx5g3e1kMZM5aGTebMgKsDZ4ZM/do= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 09/10] tools/xenstore: remove support of file backed data base Date: Tue, 1 Nov 2022 17:14:56 +0100 Message-Id: <20221101161457.8470-10-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101161457.8470-1-jgross@suse.com> References: <20221101161457.8470-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to prepare the replacement of TDB with direct accessible nodes in memory, remove the support for a file backed data base. This allows to remove xs_tdb_dump, too. Signed-off-by: Juergen Gross --- tools/xenstore/Makefile | 5 +- tools/xenstore/xenstored_core.c | 18 ++----- tools/xenstore/xs_tdb_dump.c | 86 --------------------------------- 3 files changed, 4 insertions(+), 105 deletions(-) delete mode 100644 tools/xenstore/xs_tdb_dump.c diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile index ce7a68178f..56723139a1 100644 --- a/tools/xenstore/Makefile +++ b/tools/xenstore/Makefile @@ -29,7 +29,7 @@ CLIENTS += xenstore-write xenstore-ls xenstore-watch TARGETS := xenstore $(CLIENTS) xenstore-control ifeq ($(XENSTORE_XENSTORED),y) -TARGETS += xs_tdb_dump xenstored +TARGETS += xenstored endif .PHONY: all @@ -50,9 +50,6 @@ xenstore: xenstore_client.o xs_lib.o xenstore-control: xenstore_control.o $(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS) -xs_tdb_dump: xs_tdb_dump.o utils.o tdb.o talloc.o - $(CC) $(LDFLAGS) $^ -o $@ $(APPEND_LDFLAGS) - .PHONY: clean clean:: $(RM) $(TARGETS) $(DEPS_RM) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 5fcf96c77a..e11f796aaa 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2282,8 +2282,6 @@ static void accept_connection(int sock) } #endif -static int tdb_flags = TDB_INTERNAL | TDB_NOLOCK; - /* We create initial nodes manually. */ static void manual_node(const char *name, const char *child) { @@ -2335,14 +2333,11 @@ void setup_structure(bool live_update) { char *tdbname; - tdbname = talloc_strdup(talloc_autofree_context(), xs_daemon_tdb()); + tdbname = talloc_strdup(talloc_autofree_context(), "/dev/mem"); if (!tdbname) barf_perror("Could not create tdbname"); - if (!(tdb_flags & TDB_INTERNAL)) - unlink(tdbname); - - tdb_ctx = tdb_open_ex(tdbname, 7919, tdb_flags, + tdb_ctx = tdb_open_ex(tdbname, 7919, TDB_INTERNAL | TDB_NOLOCK, O_RDWR | O_CREAT | O_EXCL | O_CLOEXEC, 0640, &tdb_logger, NULL); if (!tdb_ctx) @@ -2640,8 +2635,6 @@ static void usage(void) " watch-event: time a watch-event is kept pending\n" " -R, --no-recovery to request that no recovery should be attempted when\n" " the store is corrupted (debug only),\n" -" -I, --internal-db [on|off] store database in memory, not on disk, default is\n" -" memory, with \"--internal-db off\" it is on disk\n" " -K, --keep-orphans don't delete nodes owned by a domain when the\n" " domain is deleted (this is a security risk!)\n" " -V, --verbose to request verbose execution.\n"); @@ -2668,7 +2661,6 @@ static struct option options[] = { { "quota-soft", 1, NULL, 'q' }, { "timeout", 1, NULL, 'w' }, { "no-recovery", 0, NULL, 'R' }, - { "internal-db", 2, NULL, 'I' }, { "keep-orphans", 0, NULL, 'K' }, { "verbose", 0, NULL, 'V' }, { "watch-nb", 1, NULL, 'W' }, @@ -2781,7 +2773,7 @@ int main(int argc, char *argv[]) orig_argv = argv; while ((opt = getopt_long(argc, argv, - "DE:F:HI::KNPS:t:A:M:Q:q:T:RVW:w:U", + "DE:F:H::KNPS:t:A:M:Q:q:T:RVW:w:U", options, NULL)) != -1) { switch (opt) { case 'D': @@ -2817,10 +2809,6 @@ int main(int argc, char *argv[]) case 1: set_trace_switch(optarg); break; - case 'I': - if (optarg && !strcmp(optarg, "off")) - tdb_flags = 0; - break; case 'K': keep_orphans = true; break; diff --git a/tools/xenstore/xs_tdb_dump.c b/tools/xenstore/xs_tdb_dump.c deleted file mode 100644 index 5d2db392b4..0000000000 --- a/tools/xenstore/xs_tdb_dump.c +++ /dev/null @@ -1,86 +0,0 @@ -/* Simple program to dump out all records of TDB */ -#include -#include -#include -#include -#include -#include -#include -#include "xenstore_lib.h" -#include "tdb.h" -#include "talloc.h" -#include "utils.h" - -static uint32_t total_size(struct xs_tdb_record_hdr *hdr) -{ - return sizeof(*hdr) + hdr->num_perms * sizeof(struct xs_permissions) - + hdr->datalen + hdr->childlen; -} - -static char perm_to_char(unsigned int perm) -{ - return perm == XS_PERM_READ ? 'r' : - perm == XS_PERM_WRITE ? 'w' : - perm == XS_PERM_NONE ? '-' : - perm == (XS_PERM_READ|XS_PERM_WRITE) ? 'b' : - '?'; -} - -static void tdb_logger(TDB_CONTEXT *tdb, int level, const char * fmt, ...) -{ - va_list ap; - - va_start(ap, fmt); - vfprintf(stderr, fmt, ap); - va_end(ap); -} - -int main(int argc, char *argv[]) -{ - TDB_DATA key; - TDB_CONTEXT *tdb; - - if (argc != 2) - barf("Usage: xs_tdb_dump "); - - tdb = tdb_open_ex(talloc_strdup(NULL, argv[1]), 0, 0, O_RDONLY, 0, - &tdb_logger, NULL); - if (!tdb) - barf_perror("Could not open %s", argv[1]); - - key = tdb_firstkey(tdb); - while (key.dptr) { - TDB_DATA data; - struct xs_tdb_record_hdr *hdr; - - data = tdb_fetch(tdb, key); - hdr = (void *)data.dptr; - if (data.dsize < sizeof(*hdr)) - fprintf(stderr, "%.*s: BAD truncated\n", - (int)key.dsize, key.dptr); - else if (data.dsize != total_size(hdr)) - fprintf(stderr, "%.*s: BAD length %zu for %u/%u/%u (%u)\n", - (int)key.dsize, key.dptr, data.dsize, - hdr->num_perms, hdr->datalen, - hdr->childlen, total_size(hdr)); - else { - unsigned int i; - char *p; - - printf("%.*s: ", (int)key.dsize, key.dptr); - for (i = 0; i < hdr->num_perms; i++) - printf("%s%c%u", - i == 0 ? "" : ",", - perm_to_char(hdr->perms[i].perms), - hdr->perms[i].id); - p = (void *)&hdr->perms[hdr->num_perms]; - printf(" %.*s\n", hdr->datalen, p); - p += hdr->datalen; - for (i = 0; i < hdr->childlen; i += strlen(p+i)+1) - printf("\t-> %s\n", p+i); - } - key = tdb_nextkey(tdb, key); - } - return 0; -} - -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:25:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:25:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435139.688262 (Exim 4.92) (envelope-from ) id 1opu4x-0001jM-0G; Tue, 01 Nov 2022 16:25:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435139.688262; Tue, 01 Nov 2022 16:25:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opu4w-0001j3-SR; Tue, 01 Nov 2022 16:25:30 +0000 Received: by outflank-mailman (input) for mailman id 435139; Tue, 01 Nov 2022 16:25:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1optvR-0000i5-19 for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:15:41 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6ccac263-5a00-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 17:15:39 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E9ECD1F90F; Tue, 1 Nov 2022 16:15:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BD6A51346F; Tue, 1 Nov 2022 16:15:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aJTaLCpGYWN0dwAAMHmgww (envelope-from ); Tue, 01 Nov 2022 16:15:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ccac263-5a00-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667319338; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eAHb8+QFjd5pkkPNHRs46idZapdPvMHUccr3ff2r5Dk=; b=FXS0hBgkIjRdmY+XZX/5I1lbxMmzyG9Z7+97+Rs1Qr1mN9bRIPa5kiPpwRZ61AT9PwWsh5 j4xCekkHPpCKyzn9DUUZGnp3gTlu1yjjIqZIIpLxcAG/vmCtZucKMk6umnOTHbDeGQk+b0 P71e/QkSBWeOsJnrDfdF+rB2HF4IYeM= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 07/10] tools/xenstore: remove stale TODO file Date: Tue, 1 Nov 2022 17:14:54 +0100 Message-Id: <20221101161457.8470-8-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221101161457.8470-1-jgross@suse.com> References: <20221101161457.8470-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The TODO file is not really helpful any longer. It contains only entries which no longer apply or it is unknown what they are meant for ("Dynamic/supply nodes", "Remove assumption that rename doesn't fail"). Signed-off-by: Juergen Gross --- tools/xenstore/TODO | 10 ---------- 1 file changed, 10 deletions(-) delete mode 100644 tools/xenstore/TODO diff --git a/tools/xenstore/TODO b/tools/xenstore/TODO deleted file mode 100644 index 71d5bbbf50..0000000000 --- a/tools/xenstore/TODO +++ /dev/null @@ -1,10 +0,0 @@ -TODO in no particular order. Some of these will never be done. There -are omissions of important but necessary things. It is up to the -reader to fill in the blanks. - -- Timeout failed watch responses -- Dynamic/supply nodes -- Persistant storage of introductions, watches and transactions, so daemon can restart -- Remove assumption that rename doesn't fail -- Multi-root transactions, for setting up front and back ends at same time. - -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:30:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:30:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435163.688273 (Exim 4.92) (envelope-from ) id 1opuA8-000423-La; Tue, 01 Nov 2022 16:30:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435163.688273; Tue, 01 Nov 2022 16:30:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opuA8-00041w-HD; Tue, 01 Nov 2022 16:30:52 +0000 Received: by outflank-mailman (input) for mailman id 435163; Tue, 01 Nov 2022 16:30:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opuA7-00041X-8m for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:30:51 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2066.outbound.protection.outlook.com [40.107.20.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b378651-5a02-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 17:30:49 +0100 (CET) Received: from AS8PR07CA0050.eurprd07.prod.outlook.com (2603:10a6:20b:459::7) by DBBPR08MB6089.eurprd08.prod.outlook.com (2603:10a6:10:206::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Tue, 1 Nov 2022 16:30:46 +0000 Received: from AM7EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:459:cafe::70) by AS8PR07CA0050.outlook.office365.com (2603:10a6:20b:459::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.19 via Frontend Transport; Tue, 1 Nov 2022 16:30:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT049.mail.protection.outlook.com (100.127.140.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14 via Frontend Transport; Tue, 1 Nov 2022 16:30:45 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Tue, 01 Nov 2022 16:30:45 +0000 Received: from 99e5fd8acc25.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 246E1C68-3AD3-4331-BC59-3F9CD64747D1.1; Tue, 01 Nov 2022 16:30:35 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 99e5fd8acc25.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Nov 2022 16:30:35 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAWPR08MB9757.eurprd08.prod.outlook.com (2603:10a6:102:2e6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Tue, 1 Nov 2022 16:30:31 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 16:30:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b378651-5a02-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=loEmFMar9PZ5WEh9r39OSc4aRXwn4KzNnycCp9Efm/cMLdq0D9YlR7AVaeWbXnQFCYQkeR8TERbiloXNY1bAdnazqYd3Tn6wy3e0YYBfVaePKGdScfUpUHixDLNMZ+gEUEq38FyNmioJaF8amKxfz0X6pUM+pvS809nB3GjjOlG8Hxa38ERzOaAATdrSl0Lf7qyIhSOYrui6MHT4stLIRPNbndYOUBTyo2EFAKFpIT/sFayUahdJKhJAxguwldNIRRp0rD17VdBaKpIWrOiCBNNS+WiTi4MrIJlt+TtQqc7dWH4uw5Ooq9tyVB1YmhtVissi7sXLyX6WdWt4rfXeVQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i38CRmTm6wERfkVwb4A/x0v28RK8dyYprb9eOiTEGfw=; b=OFjqGrh+9IewE71+O6mGw2gJCC5yxu2q8HANhbQXjlXgzHXW5nqsdeoU0CRhzA9GKSCv5Ja7HENS1JM/zef9xE/MW8TwL5z00IQy9wbMliOtF+1vg4wYEfS6XEeu2E+CuhhhVqDr7kLd0wjGzEZjqoV4zDVDkOHJgFObZMcwfmVcUxVP+5Kq9XOiWGTC/tqbQV2gVLCPNJel4Yrzy25j+c5pavFPXwrC02d3WWGWh0gDj9MWMcjfclImqLNAY3UeYcwZXN2BRiJ08rp1MkYvu37vF5B7KkMoL1XLm8fdTQAf+DTkTXrQ2B8Hvyvb/45Rip20J9sS2R21AoI4UFXr+w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i38CRmTm6wERfkVwb4A/x0v28RK8dyYprb9eOiTEGfw=; b=9t8FKWqzCkxamLpY2Odo8A/6kmu6veZ/DOkEr3npkV0TVgkDbgKH288w3OOvq7JyKJ8wqICHhgOXDFl3beGqyJu9bD97AoA5o200msOMEJukUN1Xf6UECcPPR87Z/cpbYxx5gKk0ynpWpuKqaEfA3o/24FhyzIfXCwOUvlsKTGI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 07a42a0215627caa X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QHWUujGd+OnYg36jifm8InmqAHg7+HSMTP2AGBC7i9qX7diUqHoi+mggl7QQ80PFzOM+O+dUyeXF0KlYybtMQo888D90p8joL4UZV/shR0YBvtBl5OSAwHKQ3rjlHfVYkimid/S4LN3aFx++lxxOv/Wqg88uw9TIUGyOlwIFLj2sACLxr+nP/7ACpO2uQt8NgS9pg+yRcbLHa/FQI9QtRlDZfyBSE8shO3gQekzl9YJdf3z1Hq0FQGkfY3UWQq5f9aq9CZEY7IQtWhBDlgjL+aOTKuhqi8s/kjq0ome5hVwxiQVOPfeuL6wPuaFwxGmLLBPiWz+QRXmmOHZ9B8aRPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i38CRmTm6wERfkVwb4A/x0v28RK8dyYprb9eOiTEGfw=; b=H5uBoq3wf/mZuQAuWU6d4DN+PMNGrpjx7kHOyGh6m5jYD7s7X5lJ/bLjWunlpt8EZa2M4tWVLkfRwmTcR4guEU4Bl6cKz4ouT855bLnd1NAcVPxoDopqpl/IDxkKQfEDjPxctzs6t7TtN1rdqmvNc41691Rr/+74b6oNyq/V4/7TNv9bCGTEhvIUD+fXLmPXKIrh0h9UAoFF8B+eoMyNgwQ/+G77Dtpr97kv14WwEtjD8ZEWRKd+CHT8sh4eiC8bEgcaCJbqu6PNEuT3Z7hP/TQCNFLtcSb92Dgd2dI9aW1zG1dQij058+bF/LL3RN1CYMWLrgkka13pW46S7tEMwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i38CRmTm6wERfkVwb4A/x0v28RK8dyYprb9eOiTEGfw=; b=9t8FKWqzCkxamLpY2Odo8A/6kmu6veZ/DOkEr3npkV0TVgkDbgKH288w3OOvq7JyKJ8wqICHhgOXDFl3beGqyJu9bD97AoA5o200msOMEJukUN1Xf6UECcPPR87Z/cpbYxx5gKk0ynpWpuKqaEfA3o/24FhyzIfXCwOUvlsKTGI= From: Bertrand Marquis To: Elliott Mitchell CC: Stefano Stabellini , Julien Grall , Rahul Singh , Xen developer discussion , Michal Orzel , Oleksandr Tyshchenko , Oleksandr Andrushchenko , Volodymyr Babchuk , Jan Beulich , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Andrew Cooper , Juergen Gross Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices Thread-Topic: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices Thread-Index: AQHY6T1V+gcJbmRqpEyt0b8GeG9bFq4grXIAgAAQCACAAFf9AIABVMyAgAAG64CAAVVJgIAAAzuAgAACBwCAAAPNgIADNHqAgABdGACAABWOgIABD7SAgAGs8ICAABi+AA== Date: Tue, 1 Nov 2022 16:30:31 +0000 Message-ID: <947E315E-6537-48DC-8AC6-5218C12B604C@arm.com> References: <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com> <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com> <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org> <82c45bc1-6052-502b-3007-8a16fbd1d433@xen.org> <9F323893-B1C9-4D31-9A40-213345421860@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|PAWPR08MB9757:EE_|AM7EUR03FT049:EE_|DBBPR08MB6089:EE_ X-MS-Office365-Filtering-Correlation-Id: c1429a92-371c-4248-3c1a-08dabc266d65 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: aOgAEzu4P6Wl+ILQHiFirlm9zYVIAROuO1lziC3Pfw5SX7r/p+IIFv/l1z8xfT7ySoHUX51CQq8BQM6LGm/11uynfbKE2hpsrleLzViRFmYaVykOpUfivdAwTIPfOjzbyULJa6TEQLKm7Pa+R6cezV4kmUeN5iEFqPpMDJInoVIJ+z9fLeUfGOZa/3/2r47slnqupicNboP3PxuZcqT55kMG4F2Zzgsiw4ZS4prOH6taLJHUbom7wjLzEadzAR9Psih7d/yanMxNFCucn63V99RSkC1Un7QfZlMjhRAfey9rxbOwnvsWBCCQrZpo1Q5+OF3Yu9K28jmnMn9JyNl4RI2JuS3gOIPWo7noeA+aaeWDrKodwfQX7gd37TnihJji/YdzxCHY94MmJdust4leNwLY8atzhzKFg93dXjA/6yFumqaEOmcB7WbU2U6z73CNiRkW9yesDDACnMHc+N+S4pAi87xafiQOUNI5bDwHpAurC/pN6BcSbaEJxOgWYZcAlcP/z+ieSSWYiZEUDCOKrk51A/5ZsrSjLzP2PUsS37PGEl+E44rweYMbhO2JXV/CjbWIVWg81XP88l7yWAZfF0JQe0+Jyi0MRUeCpAQYgjRx2Y9mRVjXg6F00tmMyyEDSm6ijodL5saYNFzm6a8Ld2kn9rb9vr1azrYYxaLdWQtW2as5irVNxpEEDtpkv/x5xqkfbt+k4MRCbQFHutK8ZdUBdddFfJHNiiYti2en5oMbX048kkWROhpJV2mVND21VMIsmFxKhhHW0pw7FKwqntxNtJHUn9ho6ZZ2lN00Qao= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(366004)(39860400002)(136003)(376002)(451199015)(316002)(66899015)(71200400001)(478600001)(8676002)(54906003)(4326008)(66476007)(66556008)(66446008)(66946007)(64756008)(6486002)(91956017)(76116006)(186003)(7416002)(2616005)(6512007)(2906002)(5660300002)(41300700001)(26005)(86362001)(8936002)(36756003)(122000001)(53546011)(83380400001)(33656002)(38070700005)(6506007)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9757 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6e8672d6-1fd5-4e61-2d41-08dabc266513 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5aQODSEKuBTP+Qtep77o6J54s42qOUF4swpxu1/iM7uaETfcXGdWScnfjiwUD+wFR6KvVgrA86A1PHGk3VFxvguutU7pZcaj4Ojzb9ZCxXZFDcRzQfpDUF/JgZJhzy2K1aT6I+m31Kaka+Ak8gHK7snfeC9S8MsSvN00pmPDR3AHfdYHvrpK1mAXBywCEqYyxQ46fW9Nhl3Oa6WSXvPDr4VOUz6fl9y/QEa57XfIZOFEKli9OSGz+g455NeOC9pLuDMMcYcpOGg9Y7jOR9pKvC8T2S9s0qQWspbFOXczTn7c8xWOgCFpkWZQU+x7KBweuXJTFNSgcRcdxnofpc7Xo4mzM9fmsSQd8NQ1W1sbUrpjMhz+GknAXl2R19AtRYoUHDfbY1KObGVpRKlPxnXqRWFieJsOH5ksyBSiRFqikw3i8UoRRoiauR0Hxhzche+d3KxCCbXZhddBSAgmY225WzE9LK9wA844GhiAv23kr/g7qjBK2hyN3xQYvlo4bhXTqJnjSWxWhN/HoYJcGS9GvyKjh7f7ci5oF19U44SN1aRom5wBBsOMag51Gsj9/WhmvPxvDY8SJV5EYmF5RNULaxb0pzY4qi2zRM50ZjD80I1mLO+6fjHQOKZr8jPrBQ/VNN4ml3wPziB59qLhwEM8yaPEiGDE72cV0UDsKDA+UvSff1HUyfWoO6bpBO7pxi31gjMwGfxSQ3u17DgqJB/Ve7ebJ24YooHF4Cfevj29fxKztXcsu4kc6mw6Q3Q0W45KdnvzvrJZH8AYEAzm1bkveA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199015)(40470700004)(46966006)(36840700001)(83380400001)(47076005)(336012)(66899015)(82740400003)(33656002)(36756003)(70206006)(2906002)(107886003)(6486002)(81166007)(356005)(86362001)(40480700001)(82310400005)(26005)(6512007)(316002)(53546011)(8676002)(2616005)(186003)(36860700001)(70586007)(4326008)(54906003)(41300700001)(40460700003)(6506007)(5660300002)(6862004)(478600001)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 16:30:45.5851 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c1429a92-371c-4248-3c1a-08dabc266d65 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6089 Hi Elliot, > On 1 Nov 2022, at 15:01, Elliott Mitchell wrote: >=20 > On Mon, Oct 31, 2022 at 01:26:44PM +0000, Bertrand Marquis wrote: >>=20 >>> On 30 Oct 2022, at 21:14, Stefano Stabellini w= rote: >>>=20 >>> Ideally this would be something quick that can be easily invoked as the >>> first step of an external third-party build process. >>=20 >> I think that we are making this problem a lot to complex and I am not su= re >> that all this complexity is required. >=20 > Speaking of complexity. Is it just me or does a vIOMMU had an odd sort > of similarity with a Grant Table? >=20 > Both are about allowing foreign entities access to portions of the > current domain's memory. Just in the case of a Grant Table the entity > happens to be another domain, whereas for a vIOMMU it is a hardware > device. >=20 > Perhaps some functionality could be shared between the two? Perhaps > this is something for the designer of the next version of IOMMU to think > about? (or perhaps I'm off the deep end and bringing in a silly idea) I am not quite sure what you mean here. The IOMMU is something not Xen specific. Linux is using it to restrict the = area of memory accessible to a device using its DMA engine. Here we just try to = give the same possibility when running on top Xen in a transparent way so that t= he Linux (or an other guest) can continue to do the same even if it is running= on top of Xen. In practice, the guest is not telling us what it does, we just get the poin= ter to the first level of page table and we write it in the hardware which is doing th= e rest. We need to have a vIOMMU because we need to make sure the guest is only doing this for devices assigned to him and that it is not modifying the sec= ond level of page tables which is used by Xen to make sure that only the memory from the guest is accessible using the DMA engine.=20 So I am not exactly seeing the common part with grant tables here. Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Tue Nov 01 16:43:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 16:43:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435168.688283 (Exim 4.92) (envelope-from ) id 1opuMj-0005sT-PF; Tue, 01 Nov 2022 16:43:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435168.688283; Tue, 01 Nov 2022 16:43:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opuMj-0005sM-Ly; Tue, 01 Nov 2022 16:43:53 +0000 Received: by outflank-mailman (input) for mailman id 435168; Tue, 01 Nov 2022 16:43:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opuMi-0005s0-0W for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 16:43:52 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5adee95c-5a04-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 17:43:48 +0100 (CET) Received: from mail-dm6nam04lp2044.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Nov 2022 12:43:41 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5546.namprd03.prod.outlook.com (2603:10b6:806:bb::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Tue, 1 Nov 2022 16:43:39 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 16:43:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5adee95c-5a04-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667321028; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=PBESsZyigvbb47SSPjBG7n61DaIXRMZrbk3poGWYFqQ=; b=ZzKoa5Wc6HdxcQTPWkgEKTuOlBgk3inpANIaUSI3p7zScj5zLR4Lc5ou IMwZK7VrqB5r82l9C1qN3uoMVdimP/qpEXm9v1HM7CDPVXA0Hnj7FC5U/ cVppkZgaeNsqRxqwKDYevFjmrqSD2OtTo4w7ndpwTolTvdMIqMekNSwpD Y=; X-IronPort-RemoteIP: 104.47.73.44 X-IronPort-MID: 83031418 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:/NSutKx1LrBV55IUNJZ6t+f6xyrEfRIJ4+MujC+fZmUNrF6WrkVTy DQdWzqGOveOa2TzL94jaoS2p0oEsJ7TzYc3S1c++CAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U4HUMja4mtC5AVnPakT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWB/z eM2ODUfUhGgjOiG5OuhactApv12eaEHPKtH0p1h5RfwKK56BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDOVkFAZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXOgANlLSOTonhJsqGG+/lQSBAYGb32cqubnl06QSeACe kNBr0LCqoB3riRHVOLVXRKip2WflgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaESoIKW4PYwcUQA1D5MPsyKkTgxTVX5BcGai6ptTvHHf7x DXikcQlr7AajMpO26Dl+1nC226ovsKRElJz4RjLVGW46A8/fJSie4Gj9Vnc67BHMZqdSV6C+ nMDnqBy8dwzMH1ErwTVKM1lIV1jz6zt3OH06bK3I6Qcyg== IronPort-HdrOrdr: A9a23:Trw4xKgcCxbFGUI4gMkaoL14jHBQX3l13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gIsKwC zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJLiJGofy/wzdktvfrWrCo+ O85yvI+P4DrE85S1vF4ycFHTOQlgrGpUWSkGNwykGT3PARDAhKd/apw7gpPCcxonBQwu2Vms hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfZsRKEkjTRo+a07bVTHwZFiFP MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TtE5lpdwNZakmYL9Zo7RZUB7+ PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZek6EmOIr4Sy7KQ+5emsdpBNxJwumI 7ZWFcdrmI2c1KGM7z74HSKyGG5fIyQZ0Wf9igF3ekJhlTVfsuaDQSTDFYzjsCnv/ITRsXGRv fbAuMlP8Pe X-IronPort-AV: E=Sophos;i="5.95,231,1661832000"; d="scan'208";a="83031418" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WuYhtD3+2gY9yeiFAkLhHzYZ7J+mRfGQC4f5tUfAfkqKlzlo+vIrKOpqHbVIK+YYDB1egA8RZkdcsSypBFPjIKTaDUyh/r1rkXswPMtTROvak6vsFn7OQgLAs3diXfZJQE/Dpy0ajwA239mG3LQoUoHm6FFt7lJMgjkyyZpfZPuVw3XyO/C0RAV8pyBV1hUGyOqtQ41Z0KycF1FlzlJRlty+q7k9aaFP7IBl/gvVJiF/2ur7Ij+f/QI9nldGVhGzAh7obUH7SqK0dzRQe4lQoD8KywVHw23seGWcUpzgrSXil48VlN+9f5eaHKtWkUNFxUgDiev1+2d/zgdUdwfFww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PBESsZyigvbb47SSPjBG7n61DaIXRMZrbk3poGWYFqQ=; b=XX59zcdG16Cug5Fl1nPwHGQ+OpARy7kWX/LLdOmaSvzu/p5XDRDJu5nn/Su2/aZ+ZcLexdtB8KfWEJ3Tk1dSOVTKSSO0p/foOZXaNYZZ4jDNJhiYTtGrsPp770LJV/1EwZO+djCIxd3uNGxuDEs748SRnjEiFB9JmnPeW7VGRpeGgT21fKmU7WOd11ohlNbIbD2IsIhLrfUmvmfFXtBR8cT0uGKLy+FmybUYfLbvV4cmru61NyTUjjnQihgNNOL02ST2fmtJx5l8lbUjti98ledKlYAd74mmMNv5B7n/L7IeG/XDHZ00xFNv8ym8hQWrAa/szCYHHcK2fUZKA4wbMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PBESsZyigvbb47SSPjBG7n61DaIXRMZrbk3poGWYFqQ=; b=jlvYXHCocLa/MH3tpJokUOljRLMf3qhWpqAxO48ykdH4G8qawMlOZmiqXOCWZOctNlBjW8AYKZdeWdVj90ZsalOGIOALVl+hpxszNQWA93qmDtBR8bmRCg/0PG6kqPjnBYdQX/h8m3hNgomfohWa7viux654XJPr8YzmQJiL8mY= From: Andrew Cooper To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: Wei Liu , Anthony Perard , Julien Grall , Henry Wang Subject: Re: [PATCH 01/20] tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR Thread-Topic: [PATCH 01/20] tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR Thread-Index: AQHY7ga/b4iszKEqLE269ZEbCknJE64qRiKA Date: Tue, 1 Nov 2022 16:43:39 +0000 Message-ID: <766454c4-1065-a991-b64e-c9f950ad8cdb@citrix.com> References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-2-jgross@suse.com> In-Reply-To: <20221101152842.4257-2-jgross@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA0PR03MB5546:EE_ x-ms-office365-filtering-correlation-id: 32bd6656-e77e-432f-249f-08dabc283ad2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i+W7v918X7Dbk6ZB3gSRUORhG8sveYqqdZEGlSAgyKAbtTmlzE1jU7tOyaqHg6296FJSz5QXpFKq8SKgvy42Dl9UxOdolcgbO9yLgFqCL/70oOpTo0uJi1C/ihTizDkO8e9ng3Utx3+kYIIH9/KeUA0S3hzgTyQ2/sRRuEMvhSlQa9v8iOo1fy/1B+M0eNEHTAxA08XU9cS6rI/LViu4irlDBS2AnaqFNssRyc66ofZIL08lGRbFHJzM+BN0bcWwE73VnuEsXFweFgy+8fcfwEhsUc5uxYdD98JJwn556pMHmf6V8KlznA3hKDzAT5M6J9RCDDTML9/4SajfB7E230fJmC8qISkKng0vjOAcnoXeLqWc5wc1ebD3/gxjB0XdJu6jHLvpIO51o/zLRhaPnL7ikAbdEBMbGRuZ42o27nkeK6lXR6YWNrNsQl7fi+DT452WIAq/gA6XqYM8FMfnwk59QXm8PzIUoSyWYe/8K484006YHpG1j98mmLl48dYLDEp8KLfpcnVzEaV1/+x1vivmFw1GlzZiFQfAya2V/Ae/FZ7fGQPuvXhHvTCSPyW1Nc8ci4CCfF7iT7pOfuelafLAjMaZXVV6oyPXYU2nntJiq8ZoKAKaQVi9u6HeRIkgW4etPhCx29QvT4ZEGjlRMILJB+YXcmPvf+9CGuEUgBR8pYC0AOWKNF77kx7EtQmQgEmvvjO4CnsBLeGPSKzaTvV9Rj7uNXav+sD5WWeU8xZ8RthTW3bO0IJBLOAiU7EnXrwHTEgiCFNgoouj39E8PGUTp7ltgWBDrIVc3FjzgKk2RRyFXkavwNspwXeqlbsGGlHHJZS+w0IFT2btoog1cw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(366004)(346002)(396003)(376002)(451199015)(31686004)(478600001)(71200400001)(6486002)(83380400001)(2906002)(53546011)(4326008)(316002)(8676002)(86362001)(31696002)(38100700002)(122000001)(186003)(6506007)(82960400001)(2616005)(8936002)(5660300002)(26005)(110136005)(41300700001)(54906003)(6512007)(66446008)(64756008)(36756003)(4744005)(38070700005)(91956017)(66556008)(66476007)(76116006)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cm8rTTJENGNRelpaZUdrUklDdVptS1lPNElkMUd3MjFQQmxBUG1nOUJYeFJ3?= =?utf-8?B?b2NMQnRTRmkxUmRNMU03dTFDUThlenBRdWFzUEtwUnJGYkVvTXNyWXEyQWFX?= =?utf-8?B?eENlcnpIb3NWdm9mZDcvSzJUbjRCZG85cXlnaGYwakR0bWg0LzZqSWhaNWxp?= =?utf-8?B?am5qL3Zhbk5wZDR1dXZsdk56NTFlNnlOdjVkR0hmSFJFWkhMZzRWaTJrSXVW?= =?utf-8?B?c0g4ZjVDNzNBK2ZvK0VNRk1jSHpvazRnOGhmMUFOQlhVQzl2WmFqTzZ6ejgx?= =?utf-8?B?d28wbHNjK3ZSTTZLUCtZOERMWGdzbnM4TEJMcUwxN0JESnpqTVBIbzdnT1Rz?= =?utf-8?B?ckdxYmRGTGFCMko1Zi9NcHJuMUhXK1lXZndSOTV5ZzdWN0Z0QnZWVXJDc2N1?= =?utf-8?B?R2VwTGtYbDVhY2x1OTU4MDg1OGlFb29PNFVBOVNUUTBxMDhOWGhsTkRKU2gv?= =?utf-8?B?WDZpbDM1blpPMytoQ245WmYyMitHU3g5bDNLSDczVm9UWGtTK0dRRlFTcTFY?= =?utf-8?B?akM4S29ySVFZbVN5Z1RiempoMk02UEYxb3dWSlJUVGE1a3YzL0RBQXo1czI5?= =?utf-8?B?TDg0aHFrUDlEUXFyc0IzUnJhSHlSYTNjU3EvUlU1YmFIZmF1LytubE1KVVE5?= =?utf-8?B?VXRHOWpjYnVWZENuVGhFV2kraDdjcHl6cEpJTkFSSWFad0E1QklROXdOYkhE?= =?utf-8?B?VGkvOEhGV1hTZ2dpYmoxVHJEMUxOWDBCd1ZUcE1pU0NrWTUzVXZHYStRTHNZ?= =?utf-8?B?SW1RWnZ0VUFHL2RIY0tQUzljOGtCUGlHTEZ5NndtakN0LyszVVkrWVZjR1F5?= =?utf-8?B?Wm52aXlwUWwrSUZnWVVKdk9pOEpSYlFDeHE3bk15Nm1RdDBVUStkcmZpK2pi?= =?utf-8?B?SVdSYnZkWW1TeWpZTVV4TTlqd0wwZEliS2lHZFNCT2tycDR3ZlRFbWRYNU5a?= =?utf-8?B?cjNIWDRZUi9VVmFiYzlTcEZzbkowc3QzZzhqVzB6ZkNCL3ExeU9OUmdmR1Zw?= =?utf-8?B?Rlg0VUNQamdwN0p5Z2VtTE5Zc3QxcTl6WmUrRkNRY1M3ZjdKbmEyUk5nN2RD?= =?utf-8?B?bXBWSS9kOHl6SDFmUm9zbno3ZVlTcHZPb0srQ3ppUnU0WCsvTzFvZ1Z5TkFC?= =?utf-8?B?b0RKUzcyd0tUaHppMUZQVzVGU0c0QW15MENaay83UHdqelZsbDdzanJVZDJs?= =?utf-8?B?MTdEWE1VQ0VuMjZrY0dleTRNTmRSRnAxSE1DTVJWcmxyRExRUENuemx2WGZB?= =?utf-8?B?NzkvTVpZSjFuVzgxT0RnV1p2UE0vdHhUUVQ1SWlMb0JtRVNiWVZ2VTZqMnVi?= =?utf-8?B?LzRGMzVYbVRoWTlQWFU4NDBobXN6Z0lGNnlXTytuNkdsMUpUSDk2SlJ5bkpp?= =?utf-8?B?OEphQWc0MUxiZE9lODdPUzkySjlSQnRBUGlmN3NNa2lRYTN3WElKVVFtc0Fu?= =?utf-8?B?QVVJTXFSNzdheEt4NyszUzBrenBYQnRsbUpyWVdOQnFuV2VvOGo3aysrVEJk?= =?utf-8?B?Yy9sZ2ExeHJjc0xSOVRWTE9nNDNZRWo1c1ovdzFYc2dlaHhmTUpYVWpYQXFj?= =?utf-8?B?SkptazhtYzhGcG1BQzI1ZlFWQWI2dmFhWDVEZjZ1Ull1WVBQTDNDVFZFYXBz?= =?utf-8?B?d0FnRmdWMWYydkt1OGZCcnlUQVFQWHlvNkxYeEl2cFhVem0yWGNzZ25jaENC?= =?utf-8?B?MGxBTDNHbDlER0luN1dwMEhERmdLYkJTUGtGdjJ0ajl2Smd3NFZxSjNVdVlK?= =?utf-8?B?YURJR0JYdERjSkNyVnoxeUI0VzlmUkNUQzZ0TFlnTzVmdlRPSUlQRmMzaEMz?= =?utf-8?B?ckNpUDhGTGpsck1LVEJ4WGFscHdnUC9kNG10YTFoamJ0enZDQzZPY1Vud3Q0?= =?utf-8?B?SXZhWkpiNE15aDhaRlhPSkprV3BYcWhmV0UxSFZWem1VL09tbm1pa0NNdEJa?= =?utf-8?B?QUpudkEvQm92YjkvdnNyMEZVai85QkxqTnJzd3pUaWlxK2hTQ2gyeW93WDYz?= =?utf-8?B?cEhKTkRndm5SWlVvMkxSZ21ta044bEtMb2NLeWE5YlF0R2RROG5MeHpiL3JS?= =?utf-8?B?anN1WXkyOTJmTDA3SkRWcTRTS1JyWFY5dk9KTnRMaUdqZlFrWElsemFvK0pZ?= =?utf-8?Q?+9JZ2O9Zd85zj9VUgjK7FvQ/1?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32bd6656-e77e-432f-249f-08dabc283ad2 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2022 16:43:39.7285 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qSXeYQtxD7oy9EgEbSdH/fRkbuBd46gETCZcFDuw09OC5b2t1aMW5xRr0U/RQVqNzAlr/by362y172lYLb/Jd+az24QSswVpcAp646Adz7A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5546 T24gMDEvMTEvMjAyMiAxNToyOCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gWEVOX0xJQl9TVE9S RUQgaXMgc2VydmluZyBubyByZWFsIHB1cnBvc2UsIGFzIGl0IGlzIGEgbW91bnQgcG9pbnQgZm9y DQo+IGEgdG1wZnMsIHNvIGl0IGNhbiBiZSByZXBsYWNlZCBlYXNpbHkgYnkgWEVOX1JVTl9TVE9S RUQuDQo+DQo+IFhFTlNUT1JFRF9ST09URElSIGlzIGJhc2ljYWxseSB1bnVzZWQgYWxyZWFkeSwg dGhlcmUgaXMganVzdCBhIHNpbmdsZQ0KPiByZWZlcmVuY2UgaW4geHNfZGFlbW9uX3Jvb3RkaXIo KSB3aXRoIGEgZmFsbGJhY2sgdG8gWEVOX0xJQl9TVE9SRUQsDQo+IGFuZCBhIC5nZGJpbml0IGZp bGUgc2V0dGluZyBpdC4NCj4NCj4gUmVtb3ZlIHRoZSAuZ2RiaW5pdCBmaWxlLCBhcyBpdCBpcyBu b3Qga25vd24gaGF2aW5nIGJlZW4gdXNlZCBzaW5jZQ0KPiBhZ2VzLCBhbmQgbWFrZSB4c19kYWVt b25fcm9vdGRpcigpIGFuIGFsaWFzIG9mIHhzX2RhZW1vbl9ydW5kaXIoKS4NCj4NCj4gU2lnbmVk LW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQpEbyBJIGdldCBhIFJl cXVlc3RlZC9SZXBvcnRlZC1ieT8NCg0KQWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5j b29wZXIzQGNpdHJpeC5jb20+DQoNCkNDIEhlbnJ5LsKgIFRoaXMgcmVtb3ZlcyBhbiB1bm5lZWRl ZCBtb3VudCBmcm9tIGRvbTAgKGFuZCBhc3NvY2lhdGVkIGluaXQNCmluZnJhc3RydWN0dXJlKSwg YW5kIGFzIHN1Y2ggd2lsbCBiZSBhIGJsYW5rZXQgaW1wcm92ZW1lbnQgKGlmIG1hcmdpbmFsKQ0K Zm9yIDQuMTcuwqAgSSdkIGxpa2UgdG8gdG8gYmUgZW50ZXJlZCBmb3IgY29uc2lkZXJhdGlvbiBh dCB0aGlzIHBvaW50Lg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 01 18:00:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 18:00:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435180.688317 (Exim 4.92) (envelope-from ) id 1opvYK-0007Lx-VM; Tue, 01 Nov 2022 17:59:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435180.688317; Tue, 01 Nov 2022 17:59:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opvYK-0007Lq-SI; Tue, 01 Nov 2022 17:59:56 +0000 Received: by outflank-mailman (input) for mailman id 435180; Tue, 01 Nov 2022 17:59:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opvYJ-0007Ki-Nm for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 17:59:55 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fbff9131-5a0e-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 18:59:54 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fbff9131-5a0e-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667325593; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1BFJHHFskkYwrDc+C5nugZc7KAKVNuo0AeEB6cAz2Ac=; b=AKxvz6YnDCOszHd+cJLKs3kTgFtCgnathi9qor3hj+O0VGmjqyrpJq/o 0Onwfr92DqqYBOmIEl08UAbNT56pe4dE2gjeXqILJjfhtw1/M0zQYH033 tUdSNauPsNiCrzJQG+dq1ibShfQKlagj6rSF74jQq+7PMy8Gz/9rUuFyq s=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 83555985 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:W9spzqqhDI3c791hhctDyL4LHM1eBmIaZRIvgKrLsJaIsI4StFCzt garIBnVPqmCZmT8fd4jOYjj9ksHvZXTmoNrSwA5/i82QXkR8JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W5wUmAWP6gR5gaHzyBNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAC5VagyTnOOI/KOQa7ZQjM5yL5DPGqpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFHU/rSn8/x7pX7WzBUtlOT47Yw+W/Q5AdwzKLsIJzefdniqcB9zh3F+ z+XrzmR7hcyM/qdy2CcyG6Wv8jipn76VIwONYaq+as/6LGU7jNKU0BHPbehmtGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c9ZZDeAS8gyGzavQpQGDCQAsUTppeNEg8sgsSlQXO kShxo2zQ2Y16fvMFCzbpuz8QS6O1TY9MzcGeT8fTDU58vLC/705hEPMF/JFOfvg5jHqIg3Yz zePpSk4orwci88Xyqm2lWz6byKQSovhFVBsuFiONo6xxkYgPdP+OdT0gbTOxawYRLt1WGVtq 5TtdyK2yOkVRa+AmyWWKAnmNOH4vq3VWNEwbLMGInXAy9hP0yT9FWyzyGskTKuMDirjUWawC HI/QSsLuPdu0IKCNMebmb6ZBcUw1rTHHt/4TP3SZdcmSsEvKlDdoHg1PxXBgj2FfK0QfUYXY MnzTCpRJSxCVfQPIMSeGo/xLoPHNghhnDiOFPgXPjys0KaEZW79dFv2GALmUwzN14vd+V29z jqqH5HVo/mpeLGhP3K/HE96BQxiEEXX8rit8JcKKrHYclM4cIzjYteIqY4cl0Vet/w9vo/1E ruVAye0FHKXaaX7FDi3 IronPort-HdrOrdr: A9a23:hiF3n62h8t59zmxs1GuCIAqjBIokLtp133Aq2lEZdPRUGvb3qy nIpoVj6faUskd2ZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ uIG5IOcOEYZmIasS+V2maF+q4bsbu6zJw= X-IronPort-AV: E=Sophos;i="5.95,231,1661832000"; d="scan'208";a="83555985" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v1 2/2] xenctrl: use larger chunksize in domain_getinfolist Date: Tue, 1 Nov 2022 17:59:17 +0000 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The support limit of XAPI is 1000, so using 1024 will very likely get everything in one go. Other code in Xen also uses chunk sizes of 256 or 1024, and would be much better than 2, especially now that list construction is more efficient. Xenopsd should also use `domain_getinfo` instead of `domain_getinfolist` in a lot of places where info list is used, but that is another optimization. Signed-off-by: Edwin Török Tested-by: Pau Ruiz Safont --- tools/ocaml/libs/xc/xenctrl.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 3ebedffdc7..a56539ff2c 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -237,7 +237,7 @@ let rev_append_fold acc e = List.rev_append e acc let rev_concat lst = List.fold_left rev_append_fold [] lst let domain_getinfolist handle first_domain = - let nb = 2 in + let nb = 1024 in let rec __getlist lst from = (* _domain_getinfolist returns domains in reverse order, largest first *) match _domain_getinfolist handle from nb with -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 18:00:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 18:00:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435179.688306 (Exim 4.92) (envelope-from ) id 1opvYG-00074g-Mi; Tue, 01 Nov 2022 17:59:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435179.688306; Tue, 01 Nov 2022 17:59:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opvYG-00074Z-Jl; Tue, 01 Nov 2022 17:59:52 +0000 Received: by outflank-mailman (input) for mailman id 435179; Tue, 01 Nov 2022 17:59:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opvYF-0006ou-3H for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 17:59:51 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f987485f-5a0e-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 18:59:49 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f987485f-5a0e-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667325589; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GczOI6dOgGkSiOucAzErsvhWg4FDt4sWmOiy0PcUCiw=; b=eHIMTdmh2hTYoHE/V+EdBpAfArYXaERD995BdvnQJsVlpWP81GrpbUpf IXDZjrgp9yQBOKTv6mRJuBllf3qCdR8vl1gzugCnJmQ5YlfLTZW9I8Ftf zTCh9rgZ8UsUGaCna9w5Ue8+YFdsKKnizsw9mceYDU/l1qQ5xalq2HXWx s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 86481058 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:CqrAvK6HpKl6A7m5+udmkQxRtDrHchMFZxGqfqrLsTDasY5as4F+v jcZWmmCaKqCMTH1LYpyOoi0pxkFuMSEmtVmQQRlqHtmHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKkT5QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m9 c0hcRs3QFO4xKGU253kSLNFpsgcBZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJU0UUrsUIMtWcOOAi3XhcjsetFWPoqkf6GnP1g1hlrPqNbI5f/TaG5kFxx7F9 goq+UynX0kXMdyV2wCDrGuHl8PvnCXdSZ4dQejQGvlC3wTImz175ActfUS/iem0jAi5Qd03A 0Ad5CcGt6U5802vCN7nUHWQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3PLaXhRzi AXPxYmwQ2Uy7vvFEhpx64t4sxuyCBFMBlUsJhRHDikezIbh+qgTgi3mG4ML/LGOsvX5HjT5w javpSc4hqkOgcNj65hX7WwrkBr3+MGXE1ddChH/Gzv8s1gnPNLNi5mAswCz0BpWEGqOorBtV lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83sJrWrFF52LJ9o4DNRCyKBBa59sRNMRS BWP0T69HbcKVJdQUYd5YpiqF+MhxrX6GNLuW5j8N4QQPcItLVTdp3AzOCZ8OlwBd2B1z8kC1 WqzK57wXR7294w6pNZJewvt+eBynX1vrY8ibZv60w6mwdKjiI29EN843K+1RrlgtMu5TPD9q Yk32z2il0oCC4UTo0D/reYuELz9BSNgXs2q9JcHL7Drz8gPMDhJNsI9CIgJI+RN95m5XM+Sl p1hcie0EGbCuEA= IronPort-HdrOrdr: A9a23:TUFdLqG+5LsUrrVgpLqEGMeALOsnbusQ8zAXPiBKJCC9E/bo8P xG+c5w6faaslkssR0b9+xofZPwIk80lqQFhbX5X43DYOCOggLBQL2Kr7GSoQEIcxeUygc379 YET0ERMrzN5VgRt7eH3OG7eexQv+VuJsqT9JnjJ3QGd3AaV0l5hT0JbDpyiidNNXN77ZxSLu vk2uN34wCOVF4wdcqBCnwMT4H41qD2fMKPW29/O/Y/gjP+9g+V1A== X-IronPort-AV: E=Sophos;i="5.95,231,1661832000"; d="scan'208";a="86481058" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v1 1/2] xenctrl.ml: make domain_getinfolist tail recursive Date: Tue, 1 Nov 2022 17:59:16 +0000 Message-ID: <6e9ee150c5f393f2d403a71ac540ff0d621100ab.1667324874.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On a host with ~1000 VMs (the support limit for XAPI) domain_getinfolist took O(n^2) time (n=number of domains). This couples with xenopsd making inefficient calls to domain_getinfolist(1 call/VM) resulted in visibly bad performance of XAPI. It was calling the Xen domainfolist hypercall N/2 times. Optimize this such that it is called at most 2 times during normal use. Implement a tail recursive `rev_concat` equivalent to `concat |> rev`, and use it instead of calling `@` multiple times. The added benefit is that the list of domains should now actually be in increasing order instead of having pairs of 2 changing direction every time. Signed-off-by: Edwin Török Tested-by: Pau Ruiz Safont --- tools/ocaml/libs/xc/xenctrl.ml | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 28ed642231..3ebedffdc7 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -226,14 +226,25 @@ external domain_shutdown: handle -> domid -> shutdown_reason -> unit external _domain_getinfolist: handle -> domid -> int -> domaininfo list = "stub_xc_domain_getinfolist" +let rev_append_fold acc e = List.rev_append e acc + +(** + [rev_concat lst] is equivalent to [lst |> List.concat |> List.rev] + except it is tail recursive, whereas [List.concat] isn't. + Example: + rev_concat [[10;9;8];[7;6];[5]]] = [5; 6; 7; 8; 9; 10] +*) +let rev_concat lst = List.fold_left rev_append_fold [] lst + let domain_getinfolist handle first_domain = let nb = 2 in - let last_domid l = (List.hd l).domid + 1 in - let rec __getlist from = - let l = _domain_getinfolist handle from nb in - (if List.length l = nb then __getlist (last_domid l) else []) @ l - in - List.rev (__getlist first_domain) + let rec __getlist lst from = + (* _domain_getinfolist returns domains in reverse order, largest first *) + match _domain_getinfolist handle from nb with + | [] -> rev_concat lst + | (hd :: _) as l -> __getlist (l :: lst) (hd.domid + 1) + in + __getlist [] first_domain external domain_getinfo: handle -> domid -> domaininfo= "stub_xc_domain_getinfo" -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 18:00:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 18:00:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435178.688295 (Exim 4.92) (envelope-from ) id 1opvYC-0006pA-Fo; Tue, 01 Nov 2022 17:59:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435178.688295; Tue, 01 Nov 2022 17:59:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opvYC-0006p3-Cg; Tue, 01 Nov 2022 17:59:48 +0000 Received: by outflank-mailman (input) for mailman id 435178; Tue, 01 Nov 2022 17:59:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opvYB-0006ou-4H for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 17:59:47 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f5ed9d00-5a0e-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 18:59:44 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f5ed9d00-5a0e-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667325583; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=nQ6PQbafsIuC2eqqQnyl8eWJ0xfyUt9qBIdXr8HJ8Z0=; b=UJasGdYc067tnqrJ02z/P3XX++QoGvq4Fm/NESwZyWC2bN6mBssoF4Ql LsTq32d1AD7qeX+tkNZQ7bBzP5Qdblj5m64RasRf2KOAqS0JsfYLG87CC j72fyPFrD6nYqoncuIAQmh4R7VH4oBY87NdCjTS+A8eZGIq0fAOFrwVoe Q=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 83943129 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:N6RAPaBvIxI/PxVW/yvjw5YqxClBgxIJ4kV8jS/XYbTApDN0hjIFn 2EeXmCCPqncZ2v2eN5xPY3gphgH68fUzNUxQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WpA5wRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw0OlRHmdf8 KwjEG4EUkyJtsyxn7f8Rbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/BZ4gneHumn7ldD5wo1OJv6snpWPUyWSd1ZC9a4uJIYXQFK25mG6+n WSW4VTdGSolLePDigeA6lWpq9LQyHaTtIU6S+Tjq68CbEeo7nweDlgaWEW2pdG9i1WiQJRPJ koM4C0soKMuskuxQbHVUxSmrVaesxUbWt4WFPc1gCmSzoLE7gDfAXILJgOtc/R/6pVwH2Zzk AbUwZW5XlSDrYF5V1q3+ZGLqyK3aRMtc2Y+OSU1Ywxa5p7s9dRbYg30cv5vF6u8j9vQED72w iyXoCVWu4j/nfLnxI3gowmZ3mvESozhC1dsu16JBj7NAhZRPtbNWmC+1bTMAR+sxq69R0LJg nULktP2AAsmXcDUz3zlrAng8diUCxe53N/02wAH83oJrW7FF5ufkWd4uWgWGauRGpxYEQIFm WeK0e+r2LddPWGxcYh8aJ+rBsIhwMDITIq7CaqIN4EUOcksKWdrGR2CgmbJgQjQfLUEy/lja f93j+7xZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjGI+ePiNKjiIquYe5caDOzghURtvzsTPP9r 4kCbKNnCnx3DIXDX8Ug2dVIdg1WciNrXM6eRg4+XrfrHzeK0VoJU5f5qY7NsaQ890iJvo8kJ k2AZ3I= IronPort-HdrOrdr: A9a23:ThjKAKl0eFrXu0jG9iG89bSea3rpDfIg3DAbv31ZSRFFG/Fxl6 iV8sjzsiWE7wr5OUtQ/exoV5PhfZqxz/JICOoqTNKftWvdyQiVxehZhOOIqVDd8kXFh4hgPM xbEpSWZueeMbEDt7eZ3DWF X-IronPort-AV: E=Sophos;i="5.95,231,1661832000"; d="scan'208";a="83943129" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist Date: Tue, 1 Nov 2022 17:59:15 +0000 Message-ID: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Pau has performed some performance tests by booting 1000 mirage unikernels test VMs and shutting them down. We've noticed on the flamegraphs that a lot of time is spent in Xenctrl `domain_getinfolist`, 17.7% of overall time (This needs to be multiplied by 16 because Dom0 100% usage = 16 vCPUs) In particular time is spent in camlXenctrl___getlist_339 as can be seen from this flamegraph, and it also creates a very deep call stack: https://cdn.jsdelivr.net/gh/edwintorok/xen@xenctrl-coverletter/docs/tmp/perf-merge-boot.svg?x=948.9&y=2213 After some algorithmic improvements to the code now the function barely shows up at all on a flamegraph, taking only 0.02%. The function is called camlXenctrl___getlist_343, but that is just due to the changed arguments, still the same function: https://cdn.jsdelivr.net/gh/edwintorok/xen@xenctrl-coverletter/docs/tmp/perf-xen-boot-1150.svg?x=1188.0&y=1941&s=infolist It was calling the Xen hypercall ~500*1000 times for 1000 VMs, and instead it is now calling it "only" 1000 times. I would suggest to try to take this in 4.17 given the massive improvement in scalability (number of VMs on a Xen host). There are further improvements possible here, but they'll be in xenopsd (part of XAPI) to avoid calling domain_getinfolist and just use domain_getinfo: the only reason it needs use infolist is that it does the lookup by VM UUID and not by domid, but it could have a small cache of UUID->domid mappings and then call just domain_getinfo (or get the mapping from xenstore if not in the cache), but it looks like that improvement is not even needed if this function barely registers on a flamegraph now. P.S.: the mirage test VM is a very old PV version, at some point we'll repeat the test with a Solo5 based PVH one. Edwin Török (2): xenctrl.ml: make domain_getinfolist tail recursive xenctrl: use larger chunksize in domain_getinfolist tools/ocaml/libs/xc/xenctrl.ml | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 18:30:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 18:30:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435195.688328 (Exim 4.92) (envelope-from ) id 1opw1t-0004YR-BQ; Tue, 01 Nov 2022 18:30:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435195.688328; Tue, 01 Nov 2022 18:30:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opw1t-0004YK-8X; Tue, 01 Nov 2022 18:30:29 +0000 Received: by outflank-mailman (input) for mailman id 435195; Tue, 01 Nov 2022 18:30:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opw1r-0004YA-Pg; Tue, 01 Nov 2022 18:30:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opw1r-0005H4-N0; Tue, 01 Nov 2022 18:30:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opw1r-0005S0-9w; Tue, 01 Nov 2022 18:30:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1opw1r-0003bs-8C; Tue, 01 Nov 2022 18:30:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fzl88BAJz1ng2xyQLrxom8l3zzjo1vkw5F5zKv7o8b8=; b=O6IYvYNpGnp/8sC8SLNQKr7gFf i/bnX6x+got/5a7Tn5WR5ThjEefz4EKkViBNa28CnC5DSFmlT5ik/FLE9d4xvT6DIHBQwMGmoRxpZ 4JiK8671ScC7HQuhz5M2coW/yA/k+FGt+GTbnvP2ghk0Bm9viQ9pWYwZP9eh4g5vjYTo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174567: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2dd823ca7237e7fb90c890642d6a3b357a26fcff X-Osstest-Versions-That: xen=1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1 From: osstest service owner Date: Tue, 01 Nov 2022 18:30:27 +0000 flight 174567 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174567/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass version targeted for testing: xen 2dd823ca7237e7fb90c890642d6a3b357a26fcff baseline version: xen 1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1 Last test of basis 174532 2022-10-28 15:03:22 Z 4 days Testing same since 174567 2022-11-01 14:00:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Christian Lindig Edwin Török George Dunlap Juergen Gross Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 1d7fbc535d..2dd823ca72 2dd823ca7237e7fb90c890642d6a3b357a26fcff -> smoke From xen-devel-bounces@lists.xenproject.org Tue Nov 01 20:05:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 20:05:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435218.688343 (Exim 4.92) (envelope-from ) id 1opxVX-0007wR-5c; Tue, 01 Nov 2022 20:05:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435218.688343; Tue, 01 Nov 2022 20:05:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opxVX-0007wK-2Q; Tue, 01 Nov 2022 20:05:11 +0000 Received: by outflank-mailman (input) for mailman id 435218; Tue, 01 Nov 2022 20:05:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opxVW-0007vZ-5Y; Tue, 01 Nov 2022 20:05:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opxVW-0006tJ-3L; Tue, 01 Nov 2022 20:05:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opxVV-0001iM-M5; Tue, 01 Nov 2022 20:05:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1opxVV-000509-Jl; Tue, 01 Nov 2022 20:05:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Q0dBUAMYfeqxzMQBveA3x7COYMe2WhNZxdL+snFUZck=; b=a3vp1i32/5D2P7pOYCykSrZGmQ BzsSL95L4nXEichPad2AMmNLfSNUnXEGOLt1WeFVY1/7vuJc12xQsrB6y2vhW1T+aypMKa/NIPuea KT6s9sa7abWOWoLPpqEYS/pKsAnBWkWl6xhYeMxQ5rAhsEbWnaDB6c9gngrVm+rvXGPg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174569: all pass - PUSHED X-Osstest-Versions-This: ovmf=85dba961c761021755cd2aa6bc98b8e789f751ef X-Osstest-Versions-That: ovmf=720c25ab41400f9a3dfd0742da5a6d237991df5b From: osstest service owner Date: Tue, 01 Nov 2022 20:05:09 +0000 flight 174569 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174569/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 85dba961c761021755cd2aa6bc98b8e789f751ef baseline version: ovmf 720c25ab41400f9a3dfd0742da5a6d237991df5b Last test of basis 174565 2022-11-01 10:13:19 Z 0 days Testing same since 174569 2022-11-01 15:10:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael D Kinney jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 720c25ab41..85dba961c7 85dba961c761021755cd2aa6bc98b8e789f751ef -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Nov 01 20:26:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 20:26:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435227.688354 (Exim 4.92) (envelope-from ) id 1opxq8-0002jh-Uu; Tue, 01 Nov 2022 20:26:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435227.688354; Tue, 01 Nov 2022 20:26:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opxq8-0002ja-RZ; Tue, 01 Nov 2022 20:26:28 +0000 Received: by outflank-mailman (input) for mailman id 435227; Tue, 01 Nov 2022 20:26:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opxq7-0002jQ-Iw for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 20:26:27 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7440c6ad-5a23-11ed-91b5-6bf2151ebd3b; Tue, 01 Nov 2022 21:26:25 +0100 (CET) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 2A1KPbpm019236 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 1 Nov 2022 16:25:43 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 2A1KPaSh019235; Tue, 1 Nov 2022 13:25:36 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7440c6ad-5a23-11ed-91b5-6bf2151ebd3b Date: Tue, 1 Nov 2022 13:25:36 -0700 From: Elliott Mitchell To: Bertrand Marquis Cc: Stefano Stabellini , Julien Grall , Rahul Singh , Xen developer discussion , Michal Orzel , Oleksandr Tyshchenko , Oleksandr Andrushchenko , Volodymyr Babchuk , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Andrew Cooper , Juergen Gross Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices Message-ID: References: <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com> <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com> <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org> <82c45bc1-6052-502b-3007-8a16fbd1d433@xen.org> <9F323893-B1C9-4D31-9A40-213345421860@arm.com> <947E315E-6537-48DC-8AC6-5218C12B604C@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <947E315E-6537-48DC-8AC6-5218C12B604C@arm.com> X-Spam-Status: No, score=-0.0 required=10.0 tests=KHOP_HELO_FCRDNS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com On Tue, Nov 01, 2022 at 04:30:31PM +0000, Bertrand Marquis wrote: > > > On 1 Nov 2022, at 15:01, Elliott Mitchell wrote: > > > > On Mon, Oct 31, 2022 at 01:26:44PM +0000, Bertrand Marquis wrote: > >> > >>> On 30 Oct 2022, at 21:14, Stefano Stabellini wrote: > >>> > >>> Ideally this would be something quick that can be easily invoked as the > >>> first step of an external third-party build process. > >> > >> I think that we are making this problem a lot to complex and I am not sure > >> that all this complexity is required. > > > > Speaking of complexity. Is it just me or does a vIOMMU had an odd sort > > of similarity with a Grant Table? > > > > Both are about allowing foreign entities access to portions of the > > current domain's memory. Just in the case of a Grant Table the entity > > happens to be another domain, whereas for a vIOMMU it is a hardware > > device. > > > > Perhaps some functionality could be shared between the two? Perhaps > > this is something for the designer of the next version of IOMMU to think > > about? (or perhaps I'm off the deep end and bringing in a silly idea) > > I am not quite sure what you mean here. > > The IOMMU is something not Xen specific. Linux is using it to restrict the area > of memory accessible to a device using its DMA engine. Here we just try to give > the same possibility when running on top Xen in a transparent way so that the > Linux (or an other guest) can continue to do the same even if it is running on > top of Xen. > In practice, the guest is not telling us what it does, we just get the pointer to the > first level of page table and we write it in the hardware which is doing the rest. > We need to have a vIOMMU because we need to make sure the guest is only > doing this for devices assigned to him and that it is not modifying the second > level of page tables which is used by Xen to make sure that only the memory > from the guest is accessible using the DMA engine. > > So I am not exactly seeing the common part with grant tables here. With Grant Tables, one domain is allocating pages and then allowing another domain to read and potentially write to them. What is being given to Xen is the tuple of page address and other domain. With the model presently being discussed you would have a vIOMMU for each other domain. The the pages access is being granted to are the pages being entered into the vIOMMU page table. Allocate a domain Id to each IOMMU domain and this very much seems quite similar to Xen's grant tables. I'm unsure the two can be unified, but they appear to have many common aspects. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 21:15:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 21:15:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435239.688365 (Exim 4.92) (envelope-from ) id 1opybg-0000tr-L3; Tue, 01 Nov 2022 21:15:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435239.688365; Tue, 01 Nov 2022 21:15:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opybg-0000tk-IM; Tue, 01 Nov 2022 21:15:36 +0000 Received: by outflank-mailman (input) for mailman id 435239; Tue, 01 Nov 2022 21:15:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1opybf-0000tZ-Fp for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 21:15:35 +0000 Received: from smtp.smtpout.orange.fr (smtp-16.smtpout.orange.fr [80.12.242.16]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 525cfc74-5a2a-11ed-8fd0-01056ac49cbb; Tue, 01 Nov 2022 22:15:34 +0100 (CET) Received: from pop-os.home ([86.243.100.34]) by smtp.orange.fr with ESMTPA id pyanoKD2rsfCIpybcoWfMO; Tue, 01 Nov 2022 22:15:33 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 525cfc74-5a2a-11ed-8fd0-01056ac49cbb X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Tue, 01 Nov 2022 22:15:33 +0100 X-ME-IP: 86.243.100.34 From: Christophe JAILLET To: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , xen-devel@lists.xenproject.org Subject: [PATCH 28/30] x86/xen: Use kstrtobool() instead of strtobool() Date: Tue, 1 Nov 2022 22:14:16 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit strtobool() is the same as kstrtobool(). However, the latter is more used within the kernel. In order to remove strtobool() and slightly simplify kstrtox.h, switch to the other function name. While at it, include the corresponding header file () Signed-off-by: Christophe JAILLET --- This patch is part of a serie that axes all usages of strtobool(). Each patch can be applied independently from the other ones. The last patch of the serie removes the definition of strtobool(). You may not be in copy of the cover letter. So, if needed, it is available at [1]. [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/ --- arch/x86/xen/enlighten_pv.c | 3 ++- arch/x86/xen/setup.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 05170fc19083..9e1ac6a281e4 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include @@ -113,7 +114,7 @@ static __read_mostly bool xen_msr_safe = IS_ENABLED(CONFIG_XEN_PV_MSR_SAFE); static int __init parse_xen_msr_safe(char *str) { if (str) - return strtobool(str, &xen_msr_safe); + return kstrtobool(str, &xen_msr_safe); return -EINVAL; } early_param("xen_msr_safe", parse_xen_msr_safe); diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index cfa99e8f054b..0abccdab5bc6 100644 --- a/arch/x86/xen/setup.c +++ b/arch/x86/xen/setup.c @@ -7,6 +7,7 @@ #include #include +#include #include #include #include @@ -85,7 +86,7 @@ static void __init xen_parse_512gb(void) arg = strstr(xen_start_info->cmd_line, "xen_512gb_limit="); if (!arg) val = true; - else if (strtobool(arg + strlen("xen_512gb_limit="), &val)) + else if (kstrtobool(arg + strlen("xen_512gb_limit="), &val)) return; xen_512gb_limit = val; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 01 23:12:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 23:12:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435253.688380 (Exim 4.92) (envelope-from ) id 1oq0Qd-0007H7-4O; Tue, 01 Nov 2022 23:12:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435253.688380; Tue, 01 Nov 2022 23:12:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq0Qd-0007H0-1F; Tue, 01 Nov 2022 23:12:19 +0000 Received: by outflank-mailman (input) for mailman id 435253; Tue, 01 Nov 2022 23:12:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq0Qb-0007Gu-V4 for xen-devel@lists.xenproject.org; Tue, 01 Nov 2022 23:12:18 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9eaf0697-5a3a-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 00:12:14 +0100 (CET) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2A1M3w4k008148; Tue, 1 Nov 2022 23:11:48 GMT Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3kgtkd7uba-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Nov 2022 23:11:48 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2A1JeE6m002908; Tue, 1 Nov 2022 23:11:47 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2049.outbound.protection.outlook.com [104.47.56.49]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3kgtmb01vh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Nov 2022 23:11:47 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by SA1PR10MB6614.namprd10.prod.outlook.com (2603:10b6:806:2b9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Tue, 1 Nov 2022 23:11:45 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::dcd4:3c82:8227:3fd]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::dcd4:3c82:8227:3fd%6]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 23:11:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9eaf0697-5a3a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : to : cc : references : from : subject : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=VkIbyvWwmbnj/B3DsoogfaBnMNzGAXR5v/0NjEM6KvQ=; b=TMXK+zl8n+PtfF3RAo9Zz3DzSRov/ynd6Jy6irgsGWVxQsMrYYgJP4WSEdCo1Idve5E2 s3fxQhRpNj5MC3cO3zdP6QrfGYdtPHEdyiGK7TNLQ8j42mrrMujcm5d6gCMdbyghYhTo 3ZW62jbLIQq4zkP+4MofH9qzaVSTVth25kNNU7V2GYlQcBQpGt61TSn5esLd6GffpW5q Xz0Dt6OhXUmFi0VyD1w3T/AX+NvB5j+enj0U78otuJszGatu/fwG3KjLUopWC/nq+8xe Q0a/zoDSpl/7r8x/bUSVqDUynfrhQ4xiy3J95o9ls36W7C117TTqkO9FNjk3iHvSLbtN nQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=noYuJCqM2JfTZry7RbyNXUg8vOSp4Df+h5iQ548iJB/kJ4ElJ8TqFtvDGrPCbds6qwQS+xfu3/Wwxc1n8XpDEEeoxz4lsf5VYlXNmwokTA2ZiPZ1YSyk8XZ5YX/bGb5rG+BTKsOsimUlTbOZiZrKfuszRIUGSAlZB5EeU4rbZVa+5xw92KpL4Er4doIj27almxAt7ZBlpTMNIS9byYkg2fyT5GuZfCIicHlNJqoTR5FtaUgv3cgzCFJoCxPbSLbGitWQII7dUm2L3hJwGCsTJqTaCim80zYT+rks3eAN1KL8kX6aJTyAdpOPU4mHaoK3v7o/PeJ2nuHs/MJsqLdd0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VkIbyvWwmbnj/B3DsoogfaBnMNzGAXR5v/0NjEM6KvQ=; b=eQhoHuBfjWZ2rOIr4nd/H0U5j/E5RxkMbxfWt43n15WZewocZ3vJ+z371PN4b3nNGyHQdtMjp5ELagcg4AxQTeW+ydPNrGfP0/KusYhMXjPw1CinYwEF7mijWS3D6Fwd3WQ/SgbKI8NKGlH9mOvsEitk3JrQrCHZ3yUQ4FLQl0bJHrtSHD0OloQMYNSM7wFvwK3yLGrbtLnYebxYboLiDS54xWrmxsHEWshfr4H0fTfN0M+RvXllBUvC5WqSfX7byqBMbvC1RgXc3nCqIuGdyjuuTzA3USRpb8h6SB2m/i6/h7kcyc52U8++SMqI0+Sn8QLl3CnFziqQBNCX/oInjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VkIbyvWwmbnj/B3DsoogfaBnMNzGAXR5v/0NjEM6KvQ=; b=mWEweNL1kst+Rp6M3wwnamk4MWQwk3TctXydjypyePhLPGXSdPw9rOTNAo7cYKxSk+dYX80VtLGGoS3JcPdTLGkzNQ5ijICdjjQOma7yem/i3E3BHFdof+9wjA3Z+G63rApqCbfPL6oCDIJW/n+SQd8ZRfU55U/W8O23iP157/g= Message-ID: <94c03150-11c3-2a58-b01e-2467f6aa62dc@oracle.com> Date: Tue, 1 Nov 2022 19:11:41 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Content-Language: en-US To: Christophe JAILLET , Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, xen-devel@lists.xenproject.org References: From: Boris Ostrovsky Subject: Re: [PATCH 28/30] x86/xen: Use kstrtobool() instead of strtobool() In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA0PR11CA0069.namprd11.prod.outlook.com (2603:10b6:806:d2::14) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|SA1PR10MB6614:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ae1dbde-4baa-4b4a-3102-08dabc5e71d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UfwMYWPK6fPk2absjhGdxEeL+aySGus9J9zr1Jrg0WgfXa5syPSCMMCEHfHiLUhT3WHyJadrxms3QrA8jpcPGYdRgLcOSyghdreWvobysyge07Po01f2jAmitiOxPMpm+uQ0u+V8dFjNuTtdDLm/lWzNvU1ow+n5PBFB4sPzajp5MImPmgwvVGXX+EpInRM4eCNdpBlkiF0KT02R43aVeK+Lg5qhdsQIosbRZujHgqs05Q6K0Y1Q97PSOF5+J6bhEftO4cjT8GC1K7WRQ/Z0gofDtV55+1bNC8+J0l8U6Ziai7Lf4tE1nZH4XTltEWKDlErCvJh1gh4V/aySj28XoiVsTycx6siMP4knzl2K90r1/95cF6d4V1FjAQV0qo68oQV4g2nkZys19PsGkB/O5ON3bfW/zs0xrrYI0snMrfFuyUxkOM+gUSmWRQEbfnTgkY9854tfcHwSG7qdWwPB0Zra4Ep5MsmHJB+74V3NdVGNS5JWW9BFa5zQnko6ECpktbNvkZqEh3JIlYO9KAOHG4uuIs5jttdeTDKuz/KN9hmJLZjRzOhyVwNxCpDGOCzSnDUPyn99uimCDG+VfIZzMPlXYZmia7cH+WybWUqTd1da4S+K/OdqAAqVxtP+BxgSaMMcMr3fO9f3Cqwcb3ENWy9GEk716/i9rYb4iYOBQanK5c7thPQZQf1DCVMdSiOn/VxlnwliInB/U2mAmGbCcGuxItjPuYm0z8g0xe3rfAXWOz2QYkAjnwoc2SscXLzwQUWh1Ej7Po9xET+k8gVWLuw9ryzc/W2ZhtzBnWNG1ghKggN0zB1UVgkpKZqkG0R5sX7TTJnLac01XcXLC9ojCA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(366004)(136003)(396003)(346002)(451199015)(83380400001)(31696002)(86362001)(38100700002)(5660300002)(7416002)(2906002)(4744005)(966005)(66476007)(66556008)(26005)(8936002)(6512007)(4326008)(44832011)(6506007)(2616005)(186003)(110136005)(316002)(66946007)(6486002)(53546011)(6666004)(41300700001)(8676002)(478600001)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVR1Z3VaMlRnSXd3bEhSQVVYUVZmRHVnRkN3YWRNdlkyRGd1UHYrZW9vNWR3?= =?utf-8?B?OENXeGhVRVd3dkRuMW9Xb0VCUk5adDVOMzZ2UEVHZVNwYjhsTm9XNTc2OUZl?= =?utf-8?B?VFA5c0MwT1NxdU13V250cEg5Qk9OTUFCcHYvMEZPNFFKSnVhcUtLRVMxQkdB?= =?utf-8?B?dGx2aHcxR1BiOFJFU2swV25jZFFWY0w2L0ZhV3p2UmtkZS9sdGdkR2JIcWVh?= =?utf-8?B?UVl5S2NRTTNaQkU4UzZkVW93REpvMUt4ZkVwQzhEdCtoTW0rZkh6MUFOQWtj?= =?utf-8?B?WlFvcXU5eGZGMDlFZThCd3FZNjQvMkJtTDFwcGhPOXhhK2xISkpoSXhGYmxT?= =?utf-8?B?MEFSRVBRZkZvYmpDR1ZMbFo3REVTNjFzaGttU1lMYndHbTlOakNPS3Y4TkNH?= =?utf-8?B?aGJLVFVIQk1xR3lFZ3Q1aXZlZkRpVkFzL1NqZUFkRVUzcTE0QmZJdmVOckJI?= =?utf-8?B?WHJVWnRpS0xISFJYcVdXQ0t0MkJWSHhVbGF2QzZlakNCOUM3UjU3dWNHYU9H?= =?utf-8?B?YkIxSWk1RjVtSnBIUTkzdVg5V3dBaytaWmZiSjFMOWdJVUdUdllwK0Fub1B4?= =?utf-8?B?elFMbXpDdHhBOU9oOUpjU1VqTmltRDNOVFlVRmpSd0NaVlV2cldQUnFEakhM?= =?utf-8?B?VUlVc0lOS2Q0aUd1UzlBOExXUkQ0clpxaDlhdjVpek9zZjBINDA5ZzV6M09x?= =?utf-8?B?R200ZnhCMzRTK0ZPemRkdzhaN053QXJWR2p3a3RSQ2hDRFI3cVVuOWdDYStu?= =?utf-8?B?bjFPNzZzT0t5TlNQSEJjWW05TURONHBrMisyU0NLeGh5a2xnQUNqd3NZU0Rt?= =?utf-8?B?cnpsQXBpRDNxSFQ5M25penZza08zK0hnZS9XTThuT09aSEdWRVoya0NDclRP?= =?utf-8?B?eVVTSWJvU2NCRkc4cU9WRkRWcEsxb1pKdWtHdkdrWng4cTJDYlYwODNZRHBV?= =?utf-8?B?WDNMRnJ0SFNianJhbGFKSURVZlVsb1g5WVVTM2M5UlNtRjBpY0Y1ZTJNUkRh?= =?utf-8?B?K2d3aDBhYkZUYy9CNWN2SVArd050Z0hGcFZMR29FdmU5QWtXSmdlTVg4bHZJ?= =?utf-8?B?Z1laUTgxdzJvS1c2ZzRLQlpsbm9hSXc0V0dGYVNTa1p4aGlaenErTHZNMlRn?= =?utf-8?B?V0ZLYzZ5cGh5aEU5WEhSV2xBUlNqMGxDWUwwdmxvNXRIcnlDeG9hSmFyWHFw?= =?utf-8?B?QVFnRmpUdDVxQi9sUDJ6N1hzZmhqZHI3aGVJODZ4SGx5THdsVkpvY01hTU5m?= =?utf-8?B?SjNjNjQ2L1Z6MUxkbXRKTGRNZ1N6ZXhIK050VVZmdDJPL093UnNjNXN0aW0x?= =?utf-8?B?djVkay9iUVdDWGd0Y29mMmRIeXRhRHhOMFVRbWhvdVV1VUFvMTl4N2g2NVRk?= =?utf-8?B?ckM3bTNPaW9hM2V6NG04dzlxRWwvekNqMXdNcEVabzJJQTVrTUpSWGUxc0sx?= =?utf-8?B?b3pCRi9sTVV6eG42UDhxUm9IMjdKcm1mK3BlTW43UVJKQ3d0MnNRRXZiMjAv?= =?utf-8?B?aTFqejQyamFxNkM5Zm16TCtTMUo0OC9LamdLNmtLWVAwVkxkSTU1enRQSVJE?= =?utf-8?B?bVNHQkJUUDI5WEFBejJyWThrVXpEZHhrOWlWZmIxam8wMFhNV3hPK2hXU3ZB?= =?utf-8?B?RC9uQVhUaytjMzFQcVhwL1pWS2pZenJ0eWR4RFpzNkJSVElYM1pNUHBOclpN?= =?utf-8?B?Sm9ZM1ZiUW5aZS85OGY0c1pLUkRBU3pQbXR1OWg1RGZFeitNSkhFdHQ2ZWlD?= =?utf-8?B?RGFLbDFPb25UUlZTR1l5dVI4QUhDbisvdUFPU29wSmtzdU8yK1prMkQrU3Y3?= =?utf-8?B?NFkxSjlYYnF5TmhXSDVUdkxMRW52OVJzQjZLSG5hWjhRV00rdk5wajBuNWZ3?= =?utf-8?B?SVdkRzdVTFRiUzNaajdiUDdyZm0rWnFsVGtpSVBERWhrK0h3aks0MUlCMWRt?= =?utf-8?B?ZEozclRPdXVmZlczZTNyRW9XalNCOWxXcUlWVFVGalFnbTl4NnZaVzFmY1Rs?= =?utf-8?B?VXlObTZCQTZuMmNzZUNWOWlBZlJjTVk1bFdsL2pieVh4elplRE13eGZpYTFr?= =?utf-8?B?cGJPckNzNVJsQ3E4QUcrZ2xZazBFZGtYUi9HdDJSeVVTTDNTSXN5NUo2eEph?= =?utf-8?B?MVVWa0ZubFNFMHU4Um15aERLclNQQUo2UHdMa3R3RUQvR2xybHpnUFcreUpY?= =?utf-8?B?TEE9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ae1dbde-4baa-4b4a-3102-08dabc5e71d5 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 23:11:45.1903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FhGV7axF58ViYD5521buUkRCvwY0FTiOaazSYZGqzMDjtNa0vuS8BN4CdFjpjhiNAvSugfsNOEyFr66gtzpQPlNjDVICAuXPcoDmYYYenh8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6614 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-01_10,2022-11-01_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 mlxscore=0 suspectscore=0 malwarescore=0 bulkscore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211010157 X-Proofpoint-ORIG-GUID: W8ClTMnEASx3Bm2NObXqcC4GNYjEHk-E X-Proofpoint-GUID: W8ClTMnEASx3Bm2NObXqcC4GNYjEHk-E On 11/1/22 5:14 PM, Christophe JAILLET wrote: > strtobool() is the same as kstrtobool(). > However, the latter is more used within the kernel. > > In order to remove strtobool() and slightly simplify kstrtox.h, switch to > the other function name. > > While at it, include the corresponding header file () > > Signed-off-by: Christophe JAILLET > --- > This patch is part of a serie that axes all usages of strtobool(). > Each patch can be applied independently from the other ones. > > The last patch of the serie removes the definition of strtobool(). > > You may not be in copy of the cover letter. So, if needed, it is available > at [1]. > > [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/ Reviewed-by: Boris Ostrovsky From xen-devel-bounces@lists.xenproject.org Tue Nov 01 23:26:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Nov 2022 23:26:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435258.688390 (Exim 4.92) (envelope-from ) id 1oq0eG-0000uy-Ap; Tue, 01 Nov 2022 23:26:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435258.688390; Tue, 01 Nov 2022 23:26:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq0eG-0000ur-84; Tue, 01 Nov 2022 23:26:24 +0000 Received: by outflank-mailman (input) for mailman id 435258; Tue, 01 Nov 2022 23:26:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq0eF-0000uh-Gv; Tue, 01 Nov 2022 23:26:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq0eF-0001kh-Du; Tue, 01 Nov 2022 23:26:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq0eE-0006yW-SO; Tue, 01 Nov 2022 23:26:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oq0eE-0001Il-RB; Tue, 01 Nov 2022 23:26:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zXd8kUP9ZX65BD+J3M2Okz3LldluFbTE+Ig80ofeS64=; b=cIJlQoJJ4J4FrCPUw3GgB5TEgW e+D8mmI3RD77myYeUlDCv+lQv7ep6KPYChZxlwCaseGy39dcNRKiqkCQxWVGzmHmntP9eraFor+6n G8oDlqJh2QWcU8Itcj5/n2WgP8y7U+D6nnVsx27NuY4QXRlD74VqDFRar/RhPiDagLK0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174566: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=5aaef24b5c6d4246b2cac1be949869fa36577737 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 01 Nov 2022 23:26:22 +0000 flight 174566 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174566/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 5aaef24b5c6d4246b2cac1be949869fa36577737 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 25 days Failing since 173470 2022-10-08 06:21:34 Z 24 days 39 attempts Testing same since 174564 2022-11-01 04:17:49 Z 0 days 2 attempts ------------------------------------------------------------ 1531 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 143523 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Nov 02 00:08:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 00:08:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435318.688424 (Exim 4.92) (envelope-from ) id 1oq1J4-00089P-1L; Wed, 02 Nov 2022 00:08:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435318.688424; Wed, 02 Nov 2022 00:08:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq1J3-00089I-Uj; Wed, 02 Nov 2022 00:08:33 +0000 Received: by outflank-mailman (input) for mailman id 435318; Wed, 02 Nov 2022 00:08:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq1J2-000898-3p; Wed, 02 Nov 2022 00:08:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq1J1-00034z-W9; Wed, 02 Nov 2022 00:08:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq1J1-0001PW-FU; Wed, 02 Nov 2022 00:08:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oq1J1-0007Ad-Ex; Wed, 02 Nov 2022 00:08:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=daKC17gJoqor/00JohMDNvyACxVqFzTTp2eWi1sngR4=; b=m3gbhqfai4tOTkW4WAGXYdWdbE qfQSjeoFmMY5uHYWMmj7gGZUye2Oll89iAnkTC4jRsdzN4QRSY4/6PglZ+RabiJPd6vEWanuWNLAf /KJzZa+qHeul6fZT9xWO2QlfoU5NRxbIxG8CDU7FUFIkuADpAKjfnJMMq3s5t+Iuq62w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 174568: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=1bdd7c438b399e2ecce9e3c72bd7c1ae56df60f8 X-Osstest-Versions-That: xen=c229b16ba3eb5579a9a5d470ab16dd9ad55e57d6 From: osstest service owner Date: Wed, 02 Nov 2022 00:08:31 +0000 flight 174568 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174568/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 174553 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174553 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174553 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174553 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174553 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174553 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174553 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174553 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174553 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174553 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174553 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174553 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 1bdd7c438b399e2ecce9e3c72bd7c1ae56df60f8 baseline version: xen c229b16ba3eb5579a9a5d470ab16dd9ad55e57d6 Last test of basis 174553 2022-10-31 12:38:31 Z 1 days Testing same since 174568 2022-11-01 15:08:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Christian Lindig Edwin Török George Dunlap Juergen Gross Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c229b16ba3..1bdd7c438b 1bdd7c438b399e2ecce9e3c72bd7c1ae56df60f8 -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Wed Nov 02 00:55:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 00:55:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435373.688615 (Exim 4.92) (envelope-from ) id 1oq22K-00081a-UK; Wed, 02 Nov 2022 00:55:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435373.688615; Wed, 02 Nov 2022 00:55:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq22K-00081T-R9; Wed, 02 Nov 2022 00:55:20 +0000 Received: by outflank-mailman (input) for mailman id 435373; Wed, 02 Nov 2022 00:55:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq22J-000813-Ky; Wed, 02 Nov 2022 00:55:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq22J-0003vB-IN; Wed, 02 Nov 2022 00:55:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq22J-0006kL-4l; Wed, 02 Nov 2022 00:55:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oq22J-0004Wo-4G; Wed, 02 Nov 2022 00:55:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vNBo7dn3iy2fLBohM71IjK5xRJizuUAjYFJn1k7hKcc=; b=qzNstXKz2K+Sl/jlqO/PJ4lVgL 1pFeFgPAkCfYAJHiCzmVefeAhsmIQ4mnQrl0xHRJp+cN4aXF+t2UAFLcu1sciaRKDIQAk0XsJ1HkF Zguu/q0rzTcUKcBuB968bBNNyqAXwSkRZxiwiZn/izUfzbPUgdnY3kosmsTMGk+bRQMM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 174572: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e818f4f0dabf83a6138cd77d7464495fab7bfc16 X-Osstest-Versions-That: xen=ddab5b1e001366258c0bfc7d5995b9d548e6042b From: osstest service owner Date: Wed, 02 Nov 2022 00:55:19 +0000 flight 174572 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174572/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174555 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174555 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174555 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174555 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174555 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174555 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174555 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174555 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174555 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174555 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174555 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174555 test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen e818f4f0dabf83a6138cd77d7464495fab7bfc16 baseline version: xen ddab5b1e001366258c0bfc7d5995b9d548e6042b Last test of basis 174555 2022-10-31 13:08:30 Z 1 days Testing same since 174572 2022-11-01 15:38:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Lindig Edwin Török George Dunlap Juergen Gross Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ddab5b1e00..e818f4f0da e818f4f0dabf83a6138cd77d7464495fab7bfc16 -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Wed Nov 02 02:27:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 02:27:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435431.688790 (Exim 4.92) (envelope-from ) id 1oq3Ss-0005vM-Dh; Wed, 02 Nov 2022 02:26:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435431.688790; Wed, 02 Nov 2022 02:26:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq3Ss-0005vF-9r; Wed, 02 Nov 2022 02:26:50 +0000 Received: by outflank-mailman (input) for mailman id 435431; Wed, 02 Nov 2022 02:26:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq3Sr-0005v9-6B for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 02:26:49 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2083.outbound.protection.outlook.com [40.107.105.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cbffd02f-5a55-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 03:26:46 +0100 (CET) Received: from DU2PR04CA0235.eurprd04.prod.outlook.com (2603:10a6:10:2b1::30) by DB3PR08MB8891.eurprd08.prod.outlook.com (2603:10a6:10:42a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Wed, 2 Nov 2022 02:26:44 +0000 Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b1:cafe::64) by DU2PR04CA0235.outlook.office365.com (2603:10a6:10:2b1::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Wed, 2 Nov 2022 02:26:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Wed, 2 Nov 2022 02:26:43 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Wed, 02 Nov 2022 02:26:43 +0000 Received: from 9628f1fba73c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id ABA47A6A-FEB0-4F62-8F01-1DF0E4344C8E.1; Wed, 02 Nov 2022 02:26:38 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9628f1fba73c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Nov 2022 02:26:38 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB6230.eurprd08.prod.outlook.com (2603:10a6:20b:29d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 02:26:34 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Wed, 2 Nov 2022 02:26:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbffd02f-5a55-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AuOrO4iVmAXWfwrJpIM/XtGMKY4TrVNYYglNSDkvQMRBBbE3rpcJ4YswjkF+MZI5ew2EMS0ifox8AM7pd+pctMRUClII8FQLbie6jxhEiDPChzwLJSPn9WWqFHkzczNXNPYVVMHkQ9wYQBFL223OjyewFxMVv0c5ibbyXr3PeJA7fFby4fdlJewJT0inYzTcUXNXzD04Zr0D1JchXzxbFaaxswaggWxxOP0Mfgj09VtTxLXo6086bk7mLVuGcnqcu2bF48JI4wIZvmbE/BSa32RcQZLbf4Pr/ANfnWOHOkX7eQd1z80O4MD/ZeR5S162megkPHGxht0li7jOkIvPdg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3UHtU8XtcpS0EXFssE+14LXtjeyAVPSX3Y+vDU7HxVU=; b=bZhtb7+7up4nt1CRI0TOZlvk9lKg8EwzWshSZK47siM46s+JCoXHGf+kxi4BXq52UAzJkLFxYMNnov8g9mY+npRpZW7mYHE5lE9Ddpn3MJeU/pbPWlH71TGp2uK3oOeFSWPIKPPuHrydz4dCk2f+7Px9Q6scyp85RDMTyoqvEs0UZXBpHTq9R+hd7cVw1B1bxda0Je9WTfuqf7Xo9H6XlIVKGr+1+uGyy5jIxGZ4HRKATZVgbOX7CpBs8K2/zG7Wea6uHbh89jV8/wgS4VikJsOWhVgjQ85tsrY/yZzexhECR0SypL3KfKOn4cgn13dd6UPMBoafAFoEhdvJ5Dyyfg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3UHtU8XtcpS0EXFssE+14LXtjeyAVPSX3Y+vDU7HxVU=; b=MhJyTEjpOoVxaTGsZmPoNtzFrEgccf8srfnibHwITMd1TtfkOwD0lD0yVDTTtaGqao8xh7XZ5Orln0x/C8CUToE1NfQdfzHzuFhDozfg7+dOqWzjWTvDe8y95yelzsC72DD+2eh5Bv6OM1pdYtqjn0mbQuUH0/yiPuu4DjWe9AA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BHRFigJrKbQoa7S8JGakyzgEwI4AznOW5ZpBh4ntoSgdNuQSNtyAlFKW2Apua9dwpi1khbunbo9I11V9pdPF/uAXHG2CXHDOcFq4UO/kUXuKo5qJltMCHmwpGq0m4lPeecosY26zTLcQMI2HyB9aYWxZLs+nyA3sXTQZWLMuW7Pz3NqHmE4mbD7onsfj08pooq2AJrSkV5fC1+AqpYchMp5pPAIsTpOu4FzkxjJLxFUC9BugXSoXFfhh6EuRpEW3CZdgIB+dotpwjcUOGkPO/e4+KLmV4P7n/tKSS+qhR9kM6xVWeogSQwE173nFQxeYzfKCymHHaUYk2OOL7Sec4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3UHtU8XtcpS0EXFssE+14LXtjeyAVPSX3Y+vDU7HxVU=; b=Jbp2IsOiOPu9L4ZlhFoW41GQ3er55hPPr+AH2vrENjFUQfSRqEBPzxTJAUhXusfC3w2TSeTZyil+zbySKwCb057raEKHMP1QhXYe2mfUE9Xtfq1LbBynbsQq4rAvNT27nX1dttpQ98Slm97f8xXM1M8Y6CoYMcZCF7y9C4E2NJGWAPxKeYE7UyAc2oVhNGm3uOjNQ0U0xmfW72DdAvS6IbIp0/kp9zwiDKnqShNdG6xH5vXS3jlRPwPbTByaGmi/fp5eCtQMrhGO7Oexv0Gi151j8TNtXU2FzN01qogEjjlx/PHu81zUV86as0vNnulOq4+nmHa/BmfsqbKtosrwXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3UHtU8XtcpS0EXFssE+14LXtjeyAVPSX3Y+vDU7HxVU=; b=MhJyTEjpOoVxaTGsZmPoNtzFrEgccf8srfnibHwITMd1TtfkOwD0lD0yVDTTtaGqao8xh7XZ5Orln0x/C8CUToE1NfQdfzHzuFhDozfg7+dOqWzjWTvDe8y95yelzsC72DD+2eh5Bv6OM1pdYtqjn0mbQuUH0/yiPuu4DjWe9AA= From: Henry Wang To: Andrew Cooper , Juergen Gross , "xen-devel@lists.xenproject.org" CC: Wei Liu , Anthony Perard , Julien Grall Subject: RE: [PATCH 01/20] tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR Thread-Topic: [PATCH 01/20] tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR Thread-Index: AQHY7ga4dTGSL0cDn0qJYyAUTS/3pK4qRiKAgACiqGA= Date: Wed, 2 Nov 2022 02:26:34 +0000 Message-ID: References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-2-jgross@suse.com> <766454c4-1065-a991-b64e-c9f950ad8cdb@citrix.com> In-Reply-To: <766454c4-1065-a991-b64e-c9f950ad8cdb@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 417C75A47983F049A6B8C07ED181108D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB6230:EE_|DBAEUR03FT062:EE_|DB3PR08MB8891:EE_ X-MS-Office365-Filtering-Correlation-Id: 838c5a49-623d-4e67-7adb-08dabc79af04 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WkKIZ8Zh/JV1U5qmPF/J/J9YKpYvztwA/SZJ1iAqsO2xg1dNKw5lh03DLFLLPGLxm8l8z2Akp2U14PzECw0P/yrQnGLOd1nsPaN4Ta073DQF6B9uEqoSFqPQVc7djT93mr3F+62gWkKqlbIn7LRahFHPITWEqSIkf7hDtab+PWpD5SbcWj3OnctDiIcxmK65axKHIykKLAivKspTNfEt5udaatkFzXfXQL0Wq+mjcRT314na1pLHHRGOaEbLb+kKJbffr4nlZc7HKjUoqqKz7V2Bqar6E9r5isDrrpzUPyLcyT4nZnY+FhJCJg4Lj28T590WPTMe9lXYkwMEu/LSZu9mmpQ2D2TQKcQ18X/vY4nZPQV3/OErK/L1QuntXc1FXf2xoz0FXoMnyg0uiP8Y705KTusJqYxgrqLmz54Wp1Kf7RkJgdZbASHE/LewtHfKNaQlM7S2MbxHoboIg6zAn/YiaHo1Og1qykgxoVC0sk8XosobKrM8r0j7a2NMYXvKzm/CX59ldAHji/wqcDO2G/nfBdCUlXbvXeBUf01+1CKEpVIVaAb6cbY7UUt1Kx5IzrvSl+OmugK+PO6fW2tId/8NlabSHQ8B5aY6hiRJXhNJ5DYP5W9XKtpzeqf2+iTn44WpUxHd97aVeG7rx1WeBZex8bz8KxKAQKuP7GCPxp1U7E5sKJbalpIGmNKSBXUG3kTCqtfRl4QBkJkINfIVnT2LlBPusqzJjhwkBcMwWeA9u7rgnYQEHgug98h1FXHkb+eBxkuJOqCQWyf5Z15XjQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(39860400002)(396003)(136003)(376002)(451199015)(83380400001)(33656002)(38070700005)(86362001)(38100700002)(5660300002)(8676002)(122000001)(2906002)(66446008)(66476007)(4326008)(64756008)(41300700001)(8936002)(52536014)(66556008)(6506007)(66946007)(7696005)(53546011)(186003)(26005)(9686003)(478600001)(316002)(76116006)(110136005)(54906003)(55016003)(71200400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6230 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cea8360f-064b-4fe6-c0b8-08dabc79a94e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KIqpP43WYBeyvLTfQhcdcJdjjIl1UDBFGbHvgYpCPoc1L1QwAd6v3/830cFyCIfipEM1mCWMpF0lPVLoAJYLF/YCQWCsbRmmo8Lsx1qYODXDd2qy1nH8cISZ4cAq5z6I2N/xMl6P1M3DUUko165zIAvbgWEpuJmZI19TqDEm3+b6JepjAn8TiArkwUtv62MjwJZNR7tzqq2y2gEue45xRDmZDzlFfDkQNWSbIkibxleQJR689hiJNoo+cHNuGJJghoFs2EvPxkktHpAan+p71r22awvdxbLq3IlhMwiRmcC40DT6XIO9xIjpr4uPVe5e52oixH6IQHZ6JcBxa14Go+LU0DreqG+txxQTAG8c2U9p4T9rvcSeFRYaivX9ngTo4l5nb0gBsrhafoJXt775oO4/4UUlqZTrh/Zq3+x29uFlLpaKEsniyIhUibFJEADoeBSsJKQu+aL7YrHphX5FM8IcJW2BBGHOXsJaBIUYC3rBATaulgxZDgHN0w6ZQqAT5dZ8U81hysmHmH6oM0GD/tTfp0CEyi7GZsLJFjHO7B45hNt8oPkMJb0TnlRClawrE+zc2NJNrt3XMFlgnuy7x4lObXbGdTz2RiBOth01IsUSyXFQfQelA/R/UUZty/9dPqbFK0Ylj20g5JDcfGWW+q79tAG1v+qLqU4lYrDbFCJ80IviUZAZq8zNe4REuQFBLKK1tMWO5Qeh8lDmjXwR+jp0wf99TQVY942ZwUoRqaXeZ1RODfT8NuXtVqxJ0bdvl2dy+S3mDoxcH5w3t1EvwQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(136003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(26005)(9686003)(478600001)(7696005)(83380400001)(36860700001)(54906003)(6506007)(53546011)(336012)(186003)(40480700001)(47076005)(2906002)(40460700003)(55016003)(110136005)(82310400005)(70586007)(52536014)(8676002)(70206006)(4326008)(316002)(8936002)(5660300002)(41300700001)(86362001)(33656002)(82740400003)(81166007)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 02:26:43.9561 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 838c5a49-623d-4e67-7adb-08dabc79af04 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8891 SGkgQW5kcmV3LA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEFuZHJl dyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggMDEvMjBdIHRvb2xzL3hlbnN0b3JlOiByZW1vdmUgWEVOX0xJQl9TVE9SRUQgYW5kDQo+IFhF TlNUT1JFRF9ST09URElSDQo+IA0KPiBPbiAwMS8xMS8yMDIyIDE1OjI4LCBKdWVyZ2VuIEdyb3Nz IHdyb3RlOg0KPiA+IFhFTl9MSUJfU1RPUkVEIGlzIHNlcnZpbmcgbm8gcmVhbCBwdXJwb3NlLCBh cyBpdCBpcyBhIG1vdW50IHBvaW50IGZvcg0KPiA+IGEgdG1wZnMsIHNvIGl0IGNhbiBiZSByZXBs YWNlZCBlYXNpbHkgYnkgWEVOX1JVTl9TVE9SRUQuDQo+ID4NCj4gPiBYRU5TVE9SRURfUk9PVERJ UiBpcyBiYXNpY2FsbHkgdW51c2VkIGFscmVhZHksIHRoZXJlIGlzIGp1c3QgYSBzaW5nbGUNCj4g PiByZWZlcmVuY2UgaW4geHNfZGFlbW9uX3Jvb3RkaXIoKSB3aXRoIGEgZmFsbGJhY2sgdG8gWEVO X0xJQl9TVE9SRUQsDQo+ID4gYW5kIGEgLmdkYmluaXQgZmlsZSBzZXR0aW5nIGl0Lg0KPiA+DQo+ ID4gUmVtb3ZlIHRoZSAuZ2RiaW5pdCBmaWxlLCBhcyBpdCBpcyBub3Qga25vd24gaGF2aW5nIGJl ZW4gdXNlZCBzaW5jZQ0KPiA+IGFnZXMsIGFuZCBtYWtlIHhzX2RhZW1vbl9yb290ZGlyKCkgYW4g YWxpYXMgb2YgeHNfZGFlbW9uX3J1bmRpcigpLg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiANCj4gRG8gSSBnZXQgYSBSZXF1ZXN0ZWQv UmVwb3J0ZWQtYnk/DQo+IA0KPiBBY2tlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3Bl cjNAY2l0cml4LmNvbT4NCj4gDQo+IENDIEhlbnJ5LsKgIFRoaXMgcmVtb3ZlcyBhbiB1bm5lZWRl ZCBtb3VudCBmcm9tIGRvbTAgKGFuZCBhc3NvY2lhdGVkIGluaXQNCj4gaW5mcmFzdHJ1Y3R1cmUp LCBhbmQgYXMgc3VjaCB3aWxsIGJlIGEgYmxhbmtldCBpbXByb3ZlbWVudCAoaWYgbWFyZ2luYWwp DQo+IGZvciA0LjE3LsKgIEknZCBsaWtlIHRvIHRvIGJlIGVudGVyZWQgZm9yIGNvbnNpZGVyYXRp b24gYXQgdGhpcyBwb2ludC4NCg0KVGhhbmtzIGZvciBub3RpY2luZyEgU291bmRzIGdvb2QgdG8g bWUuDQoNClJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4N Cg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KDQo+IA0KPiB+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 02 03:00:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 03:00:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435436.688801 (Exim 4.92) (envelope-from ) id 1oq3za-0002WW-0U; Wed, 02 Nov 2022 03:00:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435436.688801; Wed, 02 Nov 2022 03:00:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq3zZ-0002WP-Tv; Wed, 02 Nov 2022 03:00:37 +0000 Received: by outflank-mailman (input) for mailman id 435436; Wed, 02 Nov 2022 03:00:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq3zY-0002WD-6w for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 03:00:36 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60086.outbound.protection.outlook.com [40.107.6.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 849dac6b-5a5a-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 04:00:34 +0100 (CET) Received: from DU2PR04CA0216.eurprd04.prod.outlook.com (2603:10a6:10:2b1::11) by DB9PR08MB8226.eurprd08.prod.outlook.com (2603:10a6:10:39e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Wed, 2 Nov 2022 03:00:30 +0000 Received: from DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b1:cafe::81) by DU2PR04CA0216.outlook.office365.com (2603:10a6:10:2b1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend Transport; Wed, 2 Nov 2022 03:00:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT047.mail.protection.outlook.com (100.127.143.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Wed, 2 Nov 2022 03:00:29 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Wed, 02 Nov 2022 03:00:29 +0000 Received: from 7cab5397478d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 52011106-587B-4BA4-A671-543468190550.1; Wed, 02 Nov 2022 03:00:23 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7cab5397478d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Nov 2022 03:00:23 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS2PR08MB9666.eurprd08.prod.outlook.com (2603:10a6:20b:606::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Wed, 2 Nov 2022 03:00:21 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Wed, 2 Nov 2022 03:00:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 849dac6b-5a5a-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NQbLLcQ/KcgmL8JdIZqyBuMwAhBz0O76wykwKnoTuTYL7zBClUhvzvShokS36yD7CeYOxPASHGgAstA3sjqizXFAMovS/TUZQAOZg8LuKVsImZXaUdi3vBgLAl1gs2uW6vpHB8f9IueRWIe1mTL57LpEjJk1wBJzk3en/JuaXnnocOzW1EO7z/CLxdyHPVOOkBHULDP4SKcrbak+jwrqM3wCxxXdLnMdoGg4RQV7M9cYW/n2k/iodVq80gkWQ98RqqYN4HRGLs8Pk14JrS7obyN0/Rn3HNS7bdAwp11Xv5NMH3gYU5Xt1kw+PdrcUzC8WOXirWjs8kHOAOfq1jOShA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Afh2g8IHnLtSRQc/BsQlf/r/DdqKy5FuoqMnnXz9Q6c=; b=FiRpZf+BQD9oXaVt1w323NPkDi2hmdFRiaYppZWJoLgHgLX9Gcn9aLL6L0yxx2LETwrM4C0xWWG959I+JRpB7bv4STDaslsqkRfOIdQDKAtX+glH/h+aWAjUjRJa+x4IBSBuG7QSfyvQYK7fWBT8QbhK6/2TOx+pPhlevrt1uh8ZkSh1Hb0Fi/8tOgtwthHqa/+FitKoPg2MjQP42CwulA9QllmWh2WrgNxgopZiMdErFj+DEHXUCJXqlx4KOio2farR4yBREMXn8PYyjXpiMTU+bb6Fxs7grZ+A1Qh59LJBsvjsimHZzbLTKnO3k8qIJyDa/tIQRb+ELC39xInfGA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Afh2g8IHnLtSRQc/BsQlf/r/DdqKy5FuoqMnnXz9Q6c=; b=0jIMjoc5+v+mYLfr9xhCniaZQ7HwIIf3whC2n1OlYeQNjTM0pPADOkd0Z5xFo17T81xH8xkR5ZNrBY6AW2PfDKm6hy131F16MzzgClvAzGOjA0GxnEyGjiqBvBhyqorv/Gc/JmT7sfeT41j63CUev48Rm/GjHD0wMJNSzTEc2lE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ljkW8dPSq+HDUEV46uv37Q4BrKWRLazvBZMdE+FJu8bQlTDf+MQzo7krQHEyHzehuFzA4lDYbtjrStfPZFDnWdC/CkwKaADIQT/Z+z6ZzhczWEQSRUj8STToGwlRozJSbzKrMacdZQNDq0Hje1cJM4qaj/CQfWwf7S+hvG6WY8lFYHo8pWOoVI8Hot8c6PAsgRhabqd8ahcLmQhGKKGG1oXiFLtN02d5usxmMgo0/mxkAVPCEpLbCIlqm9iYtuMyZphZtV3QLFVjc4A2YQyuRuyICvYXeg5WOSzPapFCICGRdZTrb0V7mN+kwuWFWVAqbljTIUui2IExUdns732jQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Afh2g8IHnLtSRQc/BsQlf/r/DdqKy5FuoqMnnXz9Q6c=; b=Wr7Wsau6TGfA83TCxNujMBvWZmCDHoivFQ3ynQ+mj1+9a1dQlVsBA8W2qi3Ia7u+SLWlaIYeOAdoNcRt8fuAij/aOMQi/oOaoxFpjLBnG2ODle/ONqWMCVLkXEdQWUBu0Gn0dtX3er9XF4DnBxlxECOXdyho4dxMsh3uV2y8OBUTGtKZ7r7+fNO83Cxqbgrpw5s1YQuzB6pU3RtgV1q7BorhAMTOdoN4h/MgInTWy41o8kwCPTUO9P8kLFWP71amqTfaCzEdbc83at+d64K4vPIi0zeantdc0fd6NoUZZRj5cTgEpGlzXxG1LhWBD8MId5Qvgrg+FeJZJgeMQedkZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Afh2g8IHnLtSRQc/BsQlf/r/DdqKy5FuoqMnnXz9Q6c=; b=0jIMjoc5+v+mYLfr9xhCniaZQ7HwIIf3whC2n1OlYeQNjTM0pPADOkd0Z5xFo17T81xH8xkR5ZNrBY6AW2PfDKm6hy131F16MzzgClvAzGOjA0GxnEyGjiqBvBhyqorv/Gc/JmT7sfeT41j63CUev48Rm/GjHD0wMJNSzTEc2lE= From: Henry Wang To: Jan Beulich , Julien Grall CC: "Daniel P. Smith" , George Dunlap , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" , "xen-devel@lists.xenproject.org" Subject: RE: Feedback for postponing the 4.17 release to a week later Thread-Topic: Feedback for postponing the 4.17 release to a week later Thread-Index: Adjqh6nb7bpyTo+8QPKuDS/Y5NDKqwAI6YmAAAA21oAAAA9FIADukS/A Date: Wed, 2 Nov 2022 03:00:20 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E3BC93EE67FFFC41AB18970D425F9721.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS2PR08MB9666:EE_|DBAEUR03FT047:EE_|DB9PR08MB8226:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c98881b-7f96-4967-c59d-08dabc7e6687 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IvzYegatshIhprjNdmafkGK2Ktz85zbeX091HKQjaud5wK3GixzCjsse8eJVK3Neac9tEFLbvXZs0Yrnlp9SeJ+Kt6p8wLqhGkUnrNeAVz5jb5WzKJ0FqkzIZfROxCrcB5IhYoS3EeL1kX2MZjRsj1aUldtUcEoyAOYXJ5cKaDFu3Cm45U5tBqbUqiN7MSR7wTHtehkSwEkYwlTMAlvpb/v4RPWnZE59qaXpPw3k7LPwqE54Mrlmrm+nNjDd6LVl7umkPv5sDCfiDHJpcx87sKZW2+iFyuuBBzyNm9/8kj/6E4CKFu1fdt9kTe0OmtgqPJI3gYT7JIEQnCsTxvhcOPi3+bl2kZsMB/U14WR5TgeIxE186sebxrqn28rhb0iq3plyu5EcWMG2V2/QcHOpTo9ABPq+2DHfpQ4SnzS7SFGF0z7WUPVkCSmvSZ4GyLxtU2SxvfpFDL1nPSFeniNZoI5a0VDf0OeKa5fcVVKRZVMKyVlkGWvwmpA1PAzyZ5ckXL3QWh4ivjzTxd4TwNReFUZ9zNDjFv3c2ksfHOZBm+9lEMh7wD1dZ1arVXvqzkNUQ5OCl1Fkrm+aal+fw3zUESDSaG0xtBsGO2wjPMiLqExrv9Vcekw4QaZKYEHh6h85RMhEvVqk8Ac9yPZqJSUyHQfkhCC6CPbEbN9e9bwjtD+rI5Xl5GizaTlGISMsXBvyp1Lm6DGq+GNVWL+Ct/xbzd6QfpZcNXA8ZWnwL5ZF1m3Dg+URO2EFeIjMqqFuwTcONTJqQzjseBYMdYnT4w//Rg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(39860400002)(396003)(366004)(451199015)(38070700005)(110136005)(316002)(54906003)(83380400001)(64756008)(66946007)(66556008)(66476007)(86362001)(66446008)(4326008)(122000001)(76116006)(38100700002)(8676002)(66899015)(6506007)(2906002)(5660300002)(52536014)(7416002)(186003)(8936002)(55016003)(71200400001)(9686003)(7696005)(26005)(33656002)(41300700001)(478600001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9666 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 29485887-e1ec-4fd1-5e23-08dabc7e6130 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /DeG6HuVbkbnM1V6lwKSUNBEXGSp7FNk8XFTVvKfxTdq8gvluRBD3giaDlgUu7yZVogkyDsfh46lxoY7FbhI+cVqvhzNlOKO2cY4h3yd2jzX7EEzHOq5pomwbm09gt9hp3teFbFnxDdYW4FsMOt29Mtpb2lx/0f/UexA9igPlO76KoVxWI1YpUjWsAnyJl12rpWYqKYUcsHcqx28qiUY1CTmxrYA+fFy88fLemhxuDvxiualNzLD3yaomxfY4yELBagrJv/+7XHabV/wAH3mND8z05OQvh0tduQfthcb63w2EvzuiIBkXxN2CDBZTUuoW2pssygORFMFXLxtnBcJWALrETmJGjbWq8t/EDLY6iBsrCMCyx5fIC3rHW5dHV/o/9kWk8+MyEVH8fHZg7kBqtlggcYdRVw/F+ImWc7fn1hAxYjTltN2Y+KSwO1lqJoh7Ag0zA1zHthkbWiyKKguVGNCSHSIIseWZkI6ojpCUSkx6tniSyILGgr12v1PUgBCVxtlcB6MkitezDWCfVp4K9aeaFj2TUe13xoQIMYUSssL8VY4CAf+gc5cTOILtPHzsRI5SK2X8dKdpuQYubOKrySMIXk3dxhnlakUziDSbYaaWP/3SEzoWrYyIXqr4HSV1CQkbc6AkaY7A+ydYdDzwyR98UYbQeKH4J5NFQHKRMAYYD/RecdcyJN0jwoH59pLTCwDgwgX4+G7jwuZN2ITGVhJBFfUrRO3ZTH+968eAOYUTKG2ATvdtEVYaj69sZBdOUBFsBHUIFoYJ26JBW5lOA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(376002)(396003)(451199015)(36840700001)(46966006)(40470700004)(81166007)(36860700001)(336012)(7696005)(2906002)(186003)(316002)(83380400001)(86362001)(8936002)(40460700003)(41300700001)(52536014)(9686003)(33656002)(55016003)(47076005)(5660300002)(70206006)(6506007)(8676002)(70586007)(4326008)(40480700001)(26005)(478600001)(66899015)(82310400005)(54906003)(110136005)(356005)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 03:00:29.8421 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8c98881b-7f96-4967-c59d-08dabc7e6687 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8226 SGkgSnVsaWVuIGFuZCBKYW4sDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+ IFNvbWV3aGF0IHJlbGF0ZWQuIFdoZW4gc2hvdWxkIHdlIGJyYW5jaCBmb3IgdGhlIHJlbGVhc2Ug YW5kIHNldA0KPiA+ID4gQ09ORklHX0RFQlVHPW4/DQo+ID4gPg0KPiA+ID4gSSB0aGluayB3ZSB3 b3VsZCBhdCBsZWFzdCBuZWVkIGEgUkMgd2l0aCBDT05GSUdfREVCVUc9biBidXQgSUlVQyB3ZQ0K PiA+ID4gdXN1YWxseSBkbyBpdCBhdCBhIHBvaW50IHdoZXJlIHRoZSB0cmVlIGlzIG5lYXJseSBm cm96ZW4uDQo+ID4gPg0KPiA+ID4gQUZBSUNULCB0aGVyZSBhcmUgc3RpbGwgYSBmZXcgdGhpbmdz IGluIGZsaWdodCAoaW5jbHVkaW5nIGZpeCBmb3INCj4gPiA+IFhTQS00MDkpLiBTbyBJIGFtIG5v dCBzdXJlIHdlIGFyZSBpbiBwb3NpdGlvbiB5ZXQgdG8gYnJhbmNoLiBBbnkgb3BpbmlvbnM/DQo+ ID4NCj4gPiArMSB0byBpdCBiZWluZyB0b28gZWFybHkgdG8gYnJhbmNoLiBJIHdvdWxkIHN1Z2dl c3QgdGhhdCB0aGUgWFNBIGJhdGNoDQo+ID4gc2hvdWxkIGhhdmUgZ29uZSBpbiBmaXJzdCBhbmQg cmVsZWFzZSBibG9ja2VycyBzaG91bGQgaGF2ZSBiZWVuIGRlYWx0DQo+ID4gd2l0aCAodW5sZXNz IGZvciBzb21lIGl0IGlzIGNsZWFyIHRoYXQgdGhleSdyZSBnb2luZyB0byBiZSB1bmludHJ1c2l2 ZSksDQo+ID4gdG8gbGltaXQgd2hhdCBuZWVkcyBhcHBseWluZyB0byBzdGFnaW5nIGFuZCB0aGUg bmV3IGJyYW5jaC4NCj4gDQo+IEkgYWdyZWUsIHRoZXJlZm9yZSBJIHRoaW5rIHdlIGNhbiBzd2l0 Y2ggdG8gQ09ORklHX0RFQlVHPW4gaW4gdGhlIFJDDQo+IG5leHQgd2VlayBhZnRlciB0aGUgTm92 LiAxIFhTQXMuIFNvIHdlIGhhdmUgYXQgbGVhc3QgYSB3ZWVrIGFmdGVyIHRoZSBSQzMuDQo+IA0K PiBEb2VzIHRoaXMgc291bmQgb2s/DQoNClRoYW5rIHlvdSBib3RoIGZvciB0aGUgc3VnZ2VzdGlv bnMhDQoNCkp1c3QgaW4gY2FzZSBJIGZvcmdldCB0aGlzLi4uSSBzYXcgdGhlIHhlbnN0b3JlIFhT QXMgYmVlbiBtZXJnZWQgeWVzdGVyZGF5LA0KYW5kIGhlbmNlIG1heSBJIHBsZWFzZSBhc2sgZm9y IGEgY2xhcmlmaWNhdGlvbiBpZiB5b3UgYXJlIG9rIHdpdGggdGhlIGFib3ZlDQpwbGFuIHNvIHdl IGNhbiB0YWcgUkMzIHRoaXMgd2VlayBsYXRlciBhZnRlciBtYXN0ZXIgYnJhbmNoIGlzIHN5bmNl ZCB3aXRoDQpzbW9rZS9zdGFnaW5nPw0KDQpBbHNvIEkgdGhpbmsgd2UgbmVlZCB0byBzdWJtaXQg YSBwYXRjaCB0byBtYWtlIHRoZSBkZWZhdWx0IENPTkZJR19ERUJVRw0KdG8gbiBpbiBLY29uZmln PyBUaGFua3MhDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCg0K From xen-devel-bounces@lists.xenproject.org Wed Nov 02 05:08:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 05:08:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435475.688828 (Exim 4.92) (envelope-from ) id 1oq5z5-0001vv-5W; Wed, 02 Nov 2022 05:08:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435475.688828; Wed, 02 Nov 2022 05:08:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq5z5-0001vo-29; Wed, 02 Nov 2022 05:08:15 +0000 Received: by outflank-mailman (input) for mailman id 435475; Wed, 02 Nov 2022 05:08:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq5z4-0001vi-4X for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 05:08:14 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 59b83dbb-5a6c-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 06:08:13 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5ECFF1F381; Wed, 2 Nov 2022 05:08:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3015A13A92; Wed, 2 Nov 2022 05:08:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ukZ5Cjz7YWNvMAAAMHmgww (envelope-from ); Wed, 02 Nov 2022 05:08:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59b83dbb-5a6c-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667365692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SHD1rp9a64PHC8EVZ4s5dCxgknbCBnCOQOnHcjubODQ=; b=lNjBmPycmiHJoMs+Vx+VnpoTw3hplJW+MjffbXr9kYSgdOkgdi4ipIWE6czmDr4quAIfdS sSgXeKhXHb+hmH20En1RnhlhGHzAElrcoHJE4m2htJ/wv8QHJBEoUr5Ql7jcQ292NlcG/R /iYrU1uxxjlkPXRAOzt2zsjhrKdHoTk= Message-ID: <3dd589c2-800c-50e7-c4ef-30e7e0aaeb79@suse.com> Date: Wed, 2 Nov 2022 06:08:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 01/20] tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR Content-Language: en-US To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: Wei Liu , Anthony Perard , Julien Grall , Henry Wang References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-2-jgross@suse.com> <766454c4-1065-a991-b64e-c9f950ad8cdb@citrix.com> From: Juergen Gross In-Reply-To: <766454c4-1065-a991-b64e-c9f950ad8cdb@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------8BllobqHo6sJt8MnsRTbsXkW" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------8BllobqHo6sJt8MnsRTbsXkW Content-Type: multipart/mixed; boundary="------------b0ooxhQCl8NkI0Q11wz3f7aP"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: Wei Liu , Anthony Perard , Julien Grall , Henry Wang Message-ID: <3dd589c2-800c-50e7-c4ef-30e7e0aaeb79@suse.com> Subject: Re: [PATCH 01/20] tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-2-jgross@suse.com> <766454c4-1065-a991-b64e-c9f950ad8cdb@citrix.com> In-Reply-To: <766454c4-1065-a991-b64e-c9f950ad8cdb@citrix.com> --------------b0ooxhQCl8NkI0Q11wz3f7aP Content-Type: multipart/mixed; boundary="------------ZalPBB93YlaXmVEQL1JWffzr" --------------ZalPBB93YlaXmVEQL1JWffzr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMTEuMjIgMTc6NDMsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDAxLzExLzIw MjIgMTU6MjgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBYRU5fTElCX1NUT1JFRCBpcyBz ZXJ2aW5nIG5vIHJlYWwgcHVycG9zZSwgYXMgaXQgaXMgYSBtb3VudCBwb2ludCBmb3INCj4+ IGEgdG1wZnMsIHNvIGl0IGNhbiBiZSByZXBsYWNlZCBlYXNpbHkgYnkgWEVOX1JVTl9TVE9S RUQuDQo+Pg0KPj4gWEVOU1RPUkVEX1JPT1RESVIgaXMgYmFzaWNhbGx5IHVudXNlZCBhbHJl YWR5LCB0aGVyZSBpcyBqdXN0IGEgc2luZ2xlDQo+PiByZWZlcmVuY2UgaW4geHNfZGFlbW9u X3Jvb3RkaXIoKSB3aXRoIGEgZmFsbGJhY2sgdG8gWEVOX0xJQl9TVE9SRUQsDQo+PiBhbmQg YSAuZ2RiaW5pdCBmaWxlIHNldHRpbmcgaXQuDQo+Pg0KPj4gUmVtb3ZlIHRoZSAuZ2RiaW5p dCBmaWxlLCBhcyBpdCBpcyBub3Qga25vd24gaGF2aW5nIGJlZW4gdXNlZCBzaW5jZQ0KPj4g YWdlcywgYW5kIG1ha2UgeHNfZGFlbW9uX3Jvb3RkaXIoKSBhbiBhbGlhcyBvZiB4c19kYWVt b25fcnVuZGlyKCkuDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdy b3NzQHN1c2UuY29tPg0KPiANCj4gRG8gSSBnZXQgYSBSZXF1ZXN0ZWQvUmVwb3J0ZWQtYnk/ DQoNCk9oIHllcywgb2YgY291cnNlLiBEbyB5b3Ugd2FudCBtZSB0byByZXNlbmQgd2l0aCBp dD8gSSdkIGJlIGZpbmUgd2l0aA0KDQpSZXBvcnRlZC1ieTogQW5kcmV3IENvb3BlciA8YW5k cmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCg0KYWRkZWQgd2hlbiBjb21taXR0aW5nLg0KDQo+ IA0KPiBBY2tlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4NCg0KVGhhbmtzLA0KDQpKdWVyZ2VuDQoNCg== --------------ZalPBB93YlaXmVEQL1JWffzr Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ZalPBB93YlaXmVEQL1JWffzr-- --------------b0ooxhQCl8NkI0Q11wz3f7aP-- --------------8BllobqHo6sJt8MnsRTbsXkW Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNh+zsFAwAAAAAACgkQsN6d1ii/Ey/3 MQgAk+hQ46syfotEamxQ0ghxJrHiyPA7aqC5NDF5n2uAQF+2vresgSC3AmDmVjG1Fy7unS6pTTSc P6yxhdyrcGlP1/GFO2swro6X/ptgcE1BVKL4X/KrX8z0T1C27KfqKO9CKQi1pgAHx03k3+2EIZSI CKx/Tj/MnCM+9FyZYPgxe+yBqhdAujF1b32X60aX3O+2heh+gqQ0EPfqg0oyjoQydDrPccWRtxkt cNoPFs0V5sBWo+MoqOoRWpLInw8cIJW/S8uaodT04ddF5SzEZRJ5bNdlIwWxzDhIve7uU24y/pnz MteNqrc8ScC2hdE0qbvg3CRYbb1b78sr/dJnxkNOVA== =kvyV -----END PGP SIGNATURE----- --------------8BllobqHo6sJt8MnsRTbsXkW-- From xen-devel-bounces@lists.xenproject.org Wed Nov 02 06:44:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 06:44:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435501.688854 (Exim 4.92) (envelope-from ) id 1oq7UF-000669-De; Wed, 02 Nov 2022 06:44:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435501.688854; Wed, 02 Nov 2022 06:44:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq7UF-000662-B6; Wed, 02 Nov 2022 06:44:31 +0000 Received: by outflank-mailman (input) for mailman id 435501; Wed, 02 Nov 2022 06:44:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq7UD-00065Y-Cq; Wed, 02 Nov 2022 06:44:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq7UD-0002sD-A4; Wed, 02 Nov 2022 06:44:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq7UC-0005BC-Ts; Wed, 02 Nov 2022 06:44:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oq7UC-0008Ud-TS; Wed, 02 Nov 2022 06:44:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1fnGfok7o2sDIw8gj0ZDgcsLpumWr7OiUKCSKveDgwk=; b=ZnMeBHDSMMdshaKcJ2yrA2SHgw H9w4yDU709+bF2dTxQTv4rU1p2j5guStVQOG6/kDnkHCEjvXrunwBE/17iWhE/5v8v3mXBmw4MJY+ EMb9jzb1auzxRvGGudmrc+K7FS/wTSadd4NZ1GImn9IfSIQzvHch3YMURYZzoJBb7qZo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.13-testing test] 174570: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.13-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=377dbf9cea55a1976d0957c1f209b083c734c250 X-Osstest-Versions-That: xen=5b668634a9feb68e7a27339f25591b019d0923c3 From: osstest service owner Date: Wed, 02 Nov 2022 06:44:28 +0000 flight 174570 xen-4.13-testing real [real] flight 174579 xen-4.13-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174570/ http://logs.test-lab.xenproject.org/osstest/logs/174579/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174579-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174476 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174476 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174476 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174476 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174476 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174476 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174476 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174476 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174476 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174476 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174476 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174476 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 377dbf9cea55a1976d0957c1f209b083c734c250 baseline version: xen 5b668634a9feb68e7a27339f25591b019d0923c3 Last test of basis 174476 2022-10-26 20:31:02 Z 6 days Testing same since 174570 2022-11-01 15:38:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Lindig Edwin Török George Dunlap Juergen Gross Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 5b668634a9..377dbf9cea 377dbf9cea55a1976d0957c1f209b083c734c250 -> stable-4.13 From xen-devel-bounces@lists.xenproject.org Wed Nov 02 07:27:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 07:27:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435548.689017 (Exim 4.92) (envelope-from ) id 1oq89g-0005OO-Iu; Wed, 02 Nov 2022 07:27:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435548.689017; Wed, 02 Nov 2022 07:27:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq89g-0005OH-GK; Wed, 02 Nov 2022 07:27:20 +0000 Received: by outflank-mailman (input) for mailman id 435548; Wed, 02 Nov 2022 07:27:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq89f-0005OB-2x for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 07:27:19 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70080.outbound.protection.outlook.com [40.107.7.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c76687cf-5a7f-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 08:27:17 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7652.eurprd04.prod.outlook.com (2603:10a6:20b:285::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Wed, 2 Nov 2022 07:27:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 07:27:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c76687cf-5a7f-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ThQwZ5lkpPBwFgZ7mJN9EQMCu8CmWMv4f3SqWDOGo3j3xsfi6mqWZsORpW9Xy+tG+KTkSxVwTvvhAg5IGgm7uHnESloNGvxFwTVoDOPxdghoCYtK69iHM/LRkzg8rBI/hyhzKKwjwsTrpWkw7FlITiG04mAgzCmP0DeuybRunj5P2TVowggRizR9Fhxk4dBKcp1MRiH87Z0gcs61bcsw//GMvFc+adurta6Uy9a5F9T1ZwrHPq5RRjhK4RvFZ1j7g0NZE2CkILHDQEolaXlj7W8zscqTaceh2iQK6EpjxB+2nWauELRjIb9P5omq/kPaVx7lknH8+ufhJ268aYtBYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qA7w3Q/Ft1Hm0JdhOtciqeJDaqXY6ivjvOLkDpiaTMo=; b=aDy8vo/BOnBMr8O/hF0J9/uFvbkEsDML+tCfZdpWueIkQuZ/6+RzX0eLCITTL0iv59Ytjm8UaBw/CAxGZlLnnSRtNeDn2EdbN5s+L4NpwEgcCg11JehIcVOwGj4mwSDvLFZhUBOSEbSBEdS7C6LDcGPL95neQ999lYEvYHVyiFc81+JIk2eB1Lv3qLUdt8qzJ8CODnq+LkvuxWHQ3EIwBzxptNATF4RsfVSEOMRUricPJDOJRKggeD14wwakiVL44LvYXMB72KoDiAaPLcSWKEKWuGT1Ux+emPz3+Q3aww4JaEMHkbuwzH4RANYGa8yZbHVvyO1aZcgO2bqXImn86w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qA7w3Q/Ft1Hm0JdhOtciqeJDaqXY6ivjvOLkDpiaTMo=; b=f3NcLVBr0mZ4HTKiw5wBDA50Q8xYo3aawgkAFsBTePYTn5CejN3mYBzzQNR9cqAZB2xyTIpUtbILDRJOhiE/HXls2Ld2Azq7nk4B9ufrmm7iUHUUpsyuiqNQg8CV3k9R5zofDvTcBMkNHZa7WJOv5plBIoy4bzX38qJNalFtKpwcDJztMMi+9iAgzdBzIqvAIVIYQKFppIs8ORS4+3olXaYsL9eonF3dActeFS8fdK4zrotbns+3mtfbav6+WW40t2z4+0KhxXbiS2meoIoPwE/tF5DJeeyjINvRaOD1ojYKsHylPaOGcJCbx+GIpwrKTD52AA0IjTHAWwfcMBqxMg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 2 Nov 2022 08:27:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: Feedback for postponing the 4.17 release to a week later To: Henry Wang Cc: "Daniel P. Smith" , George Dunlap , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" , "xen-devel@lists.xenproject.org" , Julien Grall References: Content-Language: en-US From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0058.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7652:EE_ X-MS-Office365-Filtering-Correlation-Id: afae173d-1d82-4f3e-06b5-08dabca3a99e X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B5H6ZM921EW2VkAEoxVLPAU0ywjHdEAIZbRZfPo9s8pWHwn18PBchdvxorfe+WUgEVN6WWujf95PLsN5niRogee40u4WVFxXYnfjL9821y2FUvz3GMY4R3eOwQPedBvdwMl4EPjgBFbMHSB9wEqyop1dKHbLyRuaidu02A9bWBQAbJAlreJDwwsygOjODwoffJnm9K51NCCxxto/MgEWaMXOjFe63Ug1XolB87gVaIZZyHZGxqIUrpN41bfF17pz/h6vgoZ0G4wYKNnt6IuwRGM6ah6SS5x8lqpmvmQboeXk//AtiIp6lytgqZlCZpTUVEgYii8XcvyuX/o1OMbuod2ZH9pgC07yLjEmQRnzHnANvADcGHPtM7LakpZsk6CSTt5D8hzWIR0hrkVoPlnSGZ58hiuVu9zRCXYSoCMk8oWkmvL+HUiRii0YLYPACYCZKt8DBwL5tBZVPvubqRgLNyu2vD3TQuzcc5Hw+89XQD9CLMumk+m/aUzCjU9r8kHfJ+4sT9wuolPX4Fey+qO2DWqKgN+2Q1XElrGNsyB/ubQgTPTFXXu/L/PP+Nppp/tLCSBuKq08zH+jY0Ewz4O1DB+JTyLbtfHELNNIykhMsZBQUvTZuttSZlN9bEGkEjRht6x9Y6oMKVvOT9udnH0h0zI6EtSQFUReDLwwYyukWAetcYEs8g6312xhPPzZhy14umiNdjChKAqsaZYfRaUN1H1pYZnInvpcIRMWsAdFKUfQD2dpfpzNXBWZlq4nHaO/NWmntR48IwobmEvpiZoVTUbEc+Wd2Tak03tAZ2BAvIs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(396003)(346002)(376002)(366004)(451199015)(31686004)(36756003)(66899015)(7416002)(2906002)(86362001)(31696002)(83380400001)(6486002)(41300700001)(5660300002)(4326008)(186003)(8936002)(54906003)(8676002)(66476007)(66946007)(6916009)(66556008)(316002)(53546011)(26005)(2616005)(6512007)(478600001)(6506007)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXlaZk1JM2ViZVBmSmNod2lobld1QUJZRnBMTUoxTkVHQytMUGFjcXRLcHpZ?= =?utf-8?B?S2FadDdUY0haQWQxakVnRUUvbTEyUk04ZDhoTm16eEY1NFlIOWgyZXRsaE9k?= =?utf-8?B?azZqV09sWGUxSHhvaUxEVlZGbktaQ00xaGdpUThSK3NtdmlLaENWQ3F5Nndp?= =?utf-8?B?ckRHRjZUNnJwRmxkcXF1K0pxR3N4U09RMm96Vld4U2ViSkt3NC9FWUxESjVK?= =?utf-8?B?dW80WGRzZVZGUGdnOFY0RUFKb2c4cnQrMjVBUjZQU3RmU3plbHhDdC9sVTBk?= =?utf-8?B?KzFEUm1BZElwMWFacjdPS1EvZjYzQnRGaHUzWHRGRCs4K2xtNlEzeDJld1JE?= =?utf-8?B?NXRuSk1ScnQrZnF4aVVjR3ErY3o3cjZDZTF3VzRFamZiVGx6QzNQMmJPUnF5?= =?utf-8?B?d2FXUk1WVkVlVmNIaGNUU0JhOFpIZWRkS1dwRU5ZNDlqYTlzaVFVZlM2bnA0?= =?utf-8?B?R09KTHhNMVlyNW5Rbkl5Mm9wd1c5VzVla2lqVU5YVnd5S2EvOWhrelIrVmQr?= =?utf-8?B?ajE5V1ZSUEZxQXF2NzFHdTBrOWR4OTVjT0NXMTVIR2RLWWw0ZUNSRVJ0djV5?= =?utf-8?B?bk1rK3JRM0N0NWhWajNiOVJsSFdhdWtGTWtWLy9ZR0orRGJJV1V5VHFBY1RM?= =?utf-8?B?aThFSzk5bGFra2F1Wi8zZThocnBZVWdDZUFkRGFSNnc0T1REU1VxSGpkZXQ2?= =?utf-8?B?L0x1MGFnQ0RwK21ncHovaG5NV2dTVGtlME9UUHdBWFhNSDdxVWdxamQzOHJC?= =?utf-8?B?ZW1xNm5sdU5VSDhLaEpJRXV1Z2FlTlVJZ0JmY0tlQlZOSnNZYWlDTFI0U1du?= =?utf-8?B?M0tEbzdjR3pkR1EySmpsUlJCZjRsYk1PWWFjbkd0bUVaL3FVTXRlRFVLR2x0?= =?utf-8?B?dng1ejIwaE1hanFrZVltTFlwM3RKVFZ3SzhmakFNQ2hDbDRKaUZaZkN1dEww?= =?utf-8?B?L2MxWWxtZ1pXWjlEWEdxWFNIWUpRcmhGTHlKRE1iemh1NkExMDR5M3doU2Jp?= =?utf-8?B?Uk1VRzluSXhlRzlyZGJ3djM5QmltM0JTc3RIUVdsSWdrV2t1STJtUjh1OGt0?= =?utf-8?B?V2JGS0E2NWZtWjRta2Fxam15NlJTRXJ1RGpsR1NnVVpuM00zZEkrQ2huOGZO?= =?utf-8?B?Z2diS2hUaG1BcjUzVlN0WkVFYkdFMHhRVUNIYU05OEQrZXhRV05iK0hWd1Bx?= =?utf-8?B?QjhialllbG9sVURBRjdoMjZmZ0J2UEpoT1FYOUd4ZlNzNS9CNGJUMU5rQUt1?= =?utf-8?B?RDBwT2s4NEJ6MWd3Z1NOZU55MGZ4L1hvWTZPeHE3TDBNYU0xWm4xQXROQnVE?= =?utf-8?B?WmFvQzdKMU1PY1ZVSElSZEVMVEpJdCtldHRBM05CZVV3VzU3amV3Q2h2SG80?= =?utf-8?B?aG43ZEZPS1k0ajVrUStFSW1JeE1vemJGcHUvN3pkU0psWjhrOWJ1THgvT25o?= =?utf-8?B?dDJCZ2kzQ2dDSUg5ZkpNM2plQ09qZjNZaXBiZXJaaS8reDJSYXdmL2RFa3h5?= =?utf-8?B?Qk5hNFU0UFVsQStESDRGYnF6VG9jRUhrSHNKWUgyWExqRFVSdGRCTjhXemVI?= =?utf-8?B?NVVzZUtKMlpJNzZNRE5JWGNhZldaNVorUURtQ0RKeVhucTJxM0s2dVp1cklD?= =?utf-8?B?TEVvS0IvMDR2MHA4RHNhK3pmaG41ZlVBZjgvcHNKYkFxSnZWeXlCVTg4S2ZN?= =?utf-8?B?cHVRUmNoS3dUcVRNdHJ0V3gyWktIcUlVNHRBbGhJNDVnRnVFZ3lUMVNCQmI4?= =?utf-8?B?NUt4STV3SHVRbGFuQ2QvMDVsUk5UY2h5SFN0RkNrTC9NOW9lTDRidHZrN1lQ?= =?utf-8?B?SFFCZU5jSXpxSHBTZyt5OFQ2NzFxWDJCRGwrN2UwSlpRUGJMdkhjbkxISkJF?= =?utf-8?B?UWhOcHVxTUFibUx4cnZDSlY1S0JQY3BPM3FEN0FFOWFWTWZRYlQySTZIOEJG?= =?utf-8?B?Ti8zYkZoYmdzS0tHbytJbWZUVUFwc25jQm1kRUtoRXRsZjhlbDBjZWZxeG9E?= =?utf-8?B?OFVCZTNhb2lpWFNQa1hCWlJDZkJNb1ZSc3RiRmhWeGNwY2lQbDhaSFVhUXpE?= =?utf-8?B?aTZhYjVGTjBNVUlsN1RSV2tyMjhIWkxOZ0haVGZ6MkQ2UWo2Y0xReWlPemZ6?= =?utf-8?Q?L38k1lgEVYadv0dKo5VjQy5Yy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: afae173d-1d82-4f3e-06b5-08dabca3a99e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 07:27:14.0243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qreoW3+WtNUoTjbOhVrLC7/fkiPnif020EfQ+0YRw164tohvPyZFJvA4mYqt36ct3UyYtgI15IDLyzDSwVE6Tg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7652 On 02.11.2022 04:00, Henry Wang wrote: > Hi Julien and Jan, > >> -----Original Message----- >>>> Somewhat related. When should we branch for the release and set >>>> CONFIG_DEBUG=n? >>>> >>>> I think we would at least need a RC with CONFIG_DEBUG=n but IIUC we >>>> usually do it at a point where the tree is nearly frozen. >>>> >>>> AFAICT, there are still a few things in flight (including fix for >>>> XSA-409). So I am not sure we are in position yet to branch. Any opinions? >>> >>> +1 to it being too early to branch. I would suggest that the XSA batch >>> should have gone in first and release blockers should have been dealt >>> with (unless for some it is clear that they're going to be unintrusive), >>> to limit what needs applying to staging and the new branch. >> >> I agree, therefore I think we can switch to CONFIG_DEBUG=n in the RC >> next week after the Nov. 1 XSAs. So we have at least a week after the RC3. >> >> Does this sound ok? > > Thank you both for the suggestions! > > Just in case I forget this...I saw the xenstore XSAs been merged yesterday, > and hence may I please ask for a clarification if you are ok with the above > plan so we can tag RC3 this week later after master branch is synced with > smoke/staging? > > Also I think we need to submit a patch to make the default CONFIG_DEBUG > to n in Kconfig? Thanks! Iirc what was done in 4.16 was to switch to non-debug immediately after branching, on the new branch only. That was specifically to keep debug enabled at all times (and no undue code churn) in staging. Debug intermediately off was (earlier on) observed to result in huge Coverity reports, because of the perceived differences in the pre-processed / produced code. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 02 08:11:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 08:11:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435559.689029 (Exim 4.92) (envelope-from ) id 1oq8pn-0003yX-D0; Wed, 02 Nov 2022 08:10:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435559.689029; Wed, 02 Nov 2022 08:10:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq8pn-0003yQ-9x; Wed, 02 Nov 2022 08:10:51 +0000 Received: by outflank-mailman (input) for mailman id 435559; Wed, 02 Nov 2022 08:10:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq8pl-0003yK-Lz for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 08:10:49 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d9643b7f-5a85-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 09:10:48 +0100 (CET) Received: by mail-wr1-x433.google.com with SMTP id v1so23293374wrt.11 for ; Wed, 02 Nov 2022 01:10:44 -0700 (PDT) Received: from [192.168.1.93] (adsl-187.109.242.224.tellas.gr. [109.242.224.187]) by smtp.gmail.com with ESMTPSA id ay41-20020a05600c1e2900b003cf7055c014sm1287541wmb.1.2022.11.02.01.10.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 01:10:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9643b7f-5a85-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eMBuq5CoXkQ4fqzvV9vBUnZhop/W2kXkogfgclXugYY=; b=C53ZC/Qhj8Mg6fNVzm0xEU1Z2i4VbfntxJzbQH5+nEsAGiIWqGdU8wXLxhNuqdbCJg 09z0Zg9iW7OUV9OWbgyqZXbyuQ3eEGy2iC9sjkl4/x+Lmi5Oj7cHiguHBlCrosycBqqc ePhmWGx+5nxp5UMZgWoaEq5ggyPhyUPmATrOWrJxMHLYtGk5pM4+P580XijCtfvJD+M4 ZqMfSKUp+TDoRU6cSW8v15v3DucctzIs2zfkP456VIBBTUTFgXLBf/ZJ99/X6VUrTN/4 j6PPnwc64YBoMirWdx2h+/smDK2HJHVyhOtC6aZ+ttjc87fU0wob/l4o9RE+gb18fgTd sZGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eMBuq5CoXkQ4fqzvV9vBUnZhop/W2kXkogfgclXugYY=; b=iv0t0mmHmiVm+Bo143djJhyeZ5sweCn2JtjTjbCk4JHje5rhgPHPdhVUu6ySxN3/mA /lvSZZdaCGbCiiy/FCxChT9FpVoQahaQAyUYGeK1lCc1PilC17L9dU2R8eiB2Z2uuasj F094zFMp4AdSlKZSyZ5VPRuVO/b1qpsVttEYXhD1syLX04/uWZGyda+8o9C+a1bkmrU6 6xbRX8/gkiwkO4YFdXVZC6Xc8FyvMj53Jzb/jMomyYz+Vcdjj2f6+DqjdOsSoj3x9syW u5R0zF0CQg5zKK5lcVWK07CVhzl4+P5sSuQ0JtAO3/+jgwfa++JTHGQy+wsA/eqbFCS6 ZhNg== X-Gm-Message-State: ACrzQf0099zEpj757TowTtBXAkGFJZ1qEGdih2haPT6oZm06rxNPnwlb /layhL6DU4r6rXa8zqhfVrI= X-Google-Smtp-Source: AMsMyM4POZR72D2GYnJY8hrzJPy9HcYjNd16EB2DudhUO/otLjkbUYS3VQnwE03cSt+b0V96Dxpd5A== X-Received: by 2002:adf:ef82:0:b0:234:ef87:dc8d with SMTP id d2-20020adfef82000000b00234ef87dc8dmr14514531wro.297.1667376643687; Wed, 02 Nov 2022 01:10:43 -0700 (PDT) Message-ID: <333c0344-af4a-ca15-c568-b1782e4ba1dd@gmail.com> Date: Wed, 2 Nov 2022 10:10:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [XEN v2 10/12] xen/Arm: GICv3: Use ULL instead of UL for 64bits Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-11-ayankuma@amd.com> <0a8b2d0e-1352-cb69-f567-e63b5bbbabef@amd.com> From: Xenia Ragiadakou In-Reply-To: <0a8b2d0e-1352-cb69-f567-e63b5bbbabef@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/1/22 16:43, Ayan Kumar Halder wrote: > > On 01/11/2022 10:03, Xenia Ragiadakou wrote: >> Hi Ayan, > Hi Xenia, >> >> On 10/31/22 17:13, Ayan Kumar Halder wrote: >>> "unsigned long long" is defined as 64 bits on AArch64 and AArch32 >>> Thus, one should this instead of "unsigned long" which is 32 bits >>> on AArch32. >>> >>> Also use 'PRIx64' instead of 'lx' or 'llx' to print uint64_t. >>> >>> Signed-off-by: Ayan Kumar Halder >>> --- >>> >>> Changed from :- >>> v1 - 1. Replace PRIu64 with PRIx64 so that the values are printed in >>> hex as >>> desired. >>> 2. Use ULL in GITS_BASER_RO_MASK as MMIO registers are always unsigned. >>> >>>   xen/arch/arm/gic-v3-lpi.c              |  8 ++++---- >>>   xen/arch/arm/gic-v3.c                  |  4 ++-- >>>   xen/arch/arm/include/asm/gic_v3_defs.h |  2 +- >>>   xen/arch/arm/include/asm/gic_v3_its.h  |  2 +- >>>   xen/arch/arm/vgic-v3-its.c             | 17 +++++++++-------- >>>   5 files changed, 17 insertions(+), 16 deletions(-) >>> >>> diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c >>> index 61d90eb386..9ca74bc321 100644 >>> --- a/xen/arch/arm/gic-v3-lpi.c >>> +++ b/xen/arch/arm/gic-v3-lpi.c >>> @@ -134,7 +134,7 @@ void gicv3_set_redist_address(paddr_t address, >>> unsigned int redist_id) >>>   uint64_t gicv3_get_redist_address(unsigned int cpu, bool use_pta) >>>   { >>>       if ( use_pta ) >>> -        return per_cpu(lpi_redist, cpu).redist_addr & GENMASK(51, 16); >>> +        return per_cpu(lpi_redist, cpu).redist_addr & >>> GENMASK_ULL(51, 16); >>>       else >>>           return per_cpu(lpi_redist, cpu).redist_id << 16; >>>   } >>> @@ -253,7 +253,7 @@ static int gicv3_lpi_allocate_pendtable(unsigned >>> int cpu) >>>           return -ENOMEM; >>>         /* Make sure the physical address can be encoded in the >>> register. */ >>> -    if ( virt_to_maddr(pendtable) & ~GENMASK(51, 16) ) >>> +    if ( virt_to_maddr(pendtable) & ~GENMASK_ULL(51, 16) ) >>>       { >>>           xfree(pendtable); >>>           return -ERANGE; >>> @@ -281,7 +281,7 @@ static int gicv3_lpi_set_pendtable(void __iomem >>> *rdist_base) >>>           return -ENOMEM; >>>       } >>>   -    ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK(51, 16))); >>> +    ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK_ULL(51, 16))); >>>         val  = GIC_BASER_CACHE_RaWaWb << >>> GICR_PENDBASER_INNER_CACHEABILITY_SHIFT; >>>       val |= GIC_BASER_CACHE_SameAsInner << >>> GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT; >>> @@ -329,7 +329,7 @@ static int gicv3_lpi_set_proptable(void __iomem * >>> rdist_base) >>>               return -ENOMEM; >>>             /* Make sure the physical address can be encoded in the >>> register. */ >>> -        if ( (virt_to_maddr(table) & ~GENMASK(51, 12)) ) >>> +        if ( (virt_to_maddr(table) & ~GENMASK_ULL(51, 12)) ) >>>           { >>>               xfree(table); >>>               return -ERANGE; >>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c >>> index 8b4b168e78..d8ce0f46c6 100644 >>> --- a/xen/arch/arm/gic-v3.c >>> +++ b/xen/arch/arm/gic-v3.c >>> @@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v) >>>       if ( v == current ) >>>       { >>>           for ( i = 0; i < gicv3_info.nr_lrs; i++ ) >>> -            printk("   HW_LR[%d]=%llx\n", i, gicv3_ich_read_lr(i)); >>> +            printk("   HW_LR[%d]=%" PRIx64 "\n", i, >>> gicv3_ich_read_lr(i)); >>>       } >>>       else >>>       { >>>           for ( i = 0; i < gicv3_info.nr_lrs; i++ ) >>> -            printk("   VCPU_LR[%d]=%llx\n", i, v->arch.gic.v3.lr[i]); >>> +            printk("   VCPU_LR[%d]=%" PRIx64 "\n", i, >>> v->arch.gic.v3.lr[i]); >>>       } >>>   } >>>   diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h >>> b/xen/arch/arm/include/asm/gic_v3_defs.h >>> index 87115f8b25..3a24bd4825 100644 >>> --- a/xen/arch/arm/include/asm/gic_v3_defs.h >>> +++ b/xen/arch/arm/include/asm/gic_v3_defs.h >>> @@ -195,7 +195,7 @@ >>>     #define ICH_SGI_IRQMODE_SHIFT        40 >>>   #define ICH_SGI_IRQMODE_MASK         0x1 >>> -#define ICH_SGI_TARGET_OTHERS        1UL >>> +#define ICH_SGI_TARGET_OTHERS        1ULL >>>   #define ICH_SGI_TARGET_LIST          0 >>>   #define ICH_SGI_IRQ_SHIFT            24 >>>   #define ICH_SGI_IRQ_MASK             0xf >>> diff --git a/xen/arch/arm/include/asm/gic_v3_its.h >>> b/xen/arch/arm/include/asm/gic_v3_its.h >>> index fae3f6ecef..5ae50b18ea 100644 >>> --- a/xen/arch/arm/include/asm/gic_v3_its.h >>> +++ b/xen/arch/arm/include/asm/gic_v3_its.h > Changes not required as ITS is not supported on AArch32 v8R GIC. >>> @@ -38,7 +38,7 @@ >>>   #define GITS_PIDR2                      GICR_PIDR2 >>>     /* Register bits */ >>> -#define GITS_VALID_BIT                  BIT(63, UL) >>> +#define GITS_VALID_BIT                  BIT(63, ULL) >>>     #define GITS_CTLR_QUIESCENT             BIT(31, UL) >>>   #define GITS_CTLR_ENABLE                BIT(0, UL) >> >> It seems that you forgot GITS_BASER_INDIRECT, that is BIT(62, UL). >> >>> diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c >>> index 58d939b85f..c5e02b2c41 100644 >>> --- a/xen/arch/arm/vgic-v3-its.c >>> +++ b/xen/arch/arm/vgic-v3-its.c > Changes not required as ITS is not supported on AArch32 v8R GIC. >>> @@ -96,13 +96,13 @@ typedef uint16_t coll_table_entry_t; >>>    * in the lowest 5 bits of the word. >>>    */ >>>   typedef uint64_t dev_table_entry_t; >>> -#define DEV_TABLE_ITT_ADDR(x) ((x) & GENMASK(51, 8)) >>> +#define DEV_TABLE_ITT_ADDR(x) ((x) & GENMASK_ULL(51, 8)) >>>   #define DEV_TABLE_ITT_SIZE(x) (BIT(((x) & GENMASK(4, 0)) + 1, UL)) >>>   #define DEV_TABLE_ENTRY(addr, bits)                     \ >>>           (((addr) & GENMASK(51, 8)) | (((bits) - 1) & GENMASK(4, 0))) >>>     #define GITS_BASER_RO_MASK       (GITS_BASER_TYPE_MASK | \ >>> -                                  (0x1fL << >>> GITS_BASER_ENTRY_SIZE_SHIFT)) >>> +                                  (0x1ULL << >>> GITS_BASER_ENTRY_SIZE_SHIFT)) >> >> You have accidently dropped 'f' from the mask. > > Yes, actually I intentionally dropped it. > > AFAIU, 'fL' represent a floating point literal. This does not make sense > are the MMIO registers are always unsigned long (32 bit) or unsigned > long long (64 bit). Probably you got a bit confused. Here f is just a hex digit. The expression cannot be a hex floating point literal because there is no exponent part. > > So, I corrected it. > >> >> I noticed that you change to ULL only a part of GENMASK and BIT >> occurences, I cannot see why. Maybe I m missing sth. > Actually, I am trying to change only where the shift exceeds 32 bits. >> >> Also, with patch [XEN v2 12/12] xen/Arm: GICv3: Enable GICv3 for >> AArch32, you disable ITS support for arm32, so it seems that those >> changes in ITS related files are not required (not that do any harm to >> have). > > Sorry, this is my mistake. I should not have changed gic_v3_its.h or > vgic-v3-its.c as they are not used for AArch32 v8R GIC. > > I will fix this in v3. > > - Ayan > >> >>>     /* >>>    * The physical address is encoded slightly differently depending on >>> @@ -112,10 +112,10 @@ typedef uint64_t dev_table_entry_t; >>>   static paddr_t get_baser_phys_addr(uint64_t reg) >>>   { >>>       if ( reg & BIT(9, UL) ) >>> -        return (reg & GENMASK(47, 16)) | >>> +        return (reg & GENMASK_ULL(47, 16)) | >>>                   ((reg & GENMASK(15, 12)) << 36); >>>       else >>> -        return reg & GENMASK(47, 12); >>> +        return reg & GENMASK_ULL(47, 12); >>>   } >>>     /* Must be called with the ITS lock held. */ >>> @@ -414,7 +414,7 @@ static int update_lpi_property(struct domain *d, >>> struct pending_irq *p) >>>       if ( !d->arch.vgic.rdists_enabled ) >>>           return 0; >>>   -    addr = d->arch.vgic.rdist_propbase & GENMASK(51, 12); >>> +    addr = d->arch.vgic.rdist_propbase & GENMASK_ULL(51, 12); >>>         ret = access_guest_memory_by_ipa(d, addr + p->irq - LPI_OFFSET, >>>                                        &property, sizeof(property), >>> false); >>> @@ -897,7 +897,8 @@ out_unlock: >>>     static void dump_its_command(uint64_t *command) >>>   { >>> -    gdprintk(XENLOG_WARNING, "  cmd 0x%02lx: %016lx %016lx %016lx >>> %016lx\n", >>> +    gdprintk(XENLOG_WARNING, "  cmd 0x%" PRIx64 ": %" PRIx64 >>> +             "%" PRIx64 "%" PRIx64 "%" PRIx64 "\n", >>>                its_cmd_get_command(command), >>>                command[0], command[1], command[2], command[3]); >>>   } >>> @@ -909,7 +910,7 @@ static void dump_its_command(uint64_t *command) >>>    */ >>>   static int vgic_its_handle_cmds(struct domain *d, struct virt_its >>> *its) >>>   { >>> -    paddr_t addr = its->cbaser & GENMASK(51, 12); >>> +    paddr_t addr = its->cbaser & GENMASK_ULL(51, 12); >>>       uint64_t command[4]; >>>         ASSERT(spin_is_locked(&its->vcmd_lock)); >>> @@ -1122,7 +1123,7 @@ read_as_zero_64: >>>     read_impl_defined: >>>       printk(XENLOG_G_DEBUG >>> -           "%pv: vGITS: RAZ on implementation defined register >>> offset %#04lx\n", >>> +           "%pv: vGITS: RAZ on implementation defined register >>> offset %" PRIx64 "#04llx\n", >>>              v, info->gpa & 0xffff); >>>       *r = 0; >>>       return 1; >> -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Nov 02 08:19:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 08:19:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435564.689040 (Exim 4.92) (envelope-from ) id 1oq8xm-0004z3-6N; Wed, 02 Nov 2022 08:19:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435564.689040; Wed, 02 Nov 2022 08:19:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq8xm-0004yw-3X; Wed, 02 Nov 2022 08:19:06 +0000 Received: by outflank-mailman (input) for mailman id 435564; Wed, 02 Nov 2022 08:19:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq8xl-0004ym-7l; Wed, 02 Nov 2022 08:19:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq8xl-000548-4p; Wed, 02 Nov 2022 08:19:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq8xk-00021G-Kg; Wed, 02 Nov 2022 08:19:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oq8xk-0004lH-K9; Wed, 02 Nov 2022 08:19:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UOps8sT7+oMrV+/J6erhnREoJ/ztAFJFxAyq7df84DA=; b=yKQOVrU041d4i8fhga59Uglz6i T5+6JIDex0C2iKdqng+W2+Pixo8hsdQCHtD9TKCn28ziy/gcNIM1QPTL5N9iUT5A21vsqK4DDMzsW jgmlNSeudPYi2i7NFcWT4go2IJlVwJ7AG2XqbgGKuDz0WLBboqOkQXmA7CItYxX3WO4c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 174571: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.14-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=1c354767d58cd80224f0dfb107584bc8bd629b00 X-Osstest-Versions-That: xen=96220aec3e72b9d71600d78958b60e77db753b94 From: osstest service owner Date: Wed, 02 Nov 2022 08:19:04 +0000 flight 174571 xen-4.14-testing real [real] flight 174580 xen-4.14-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174571/ http://logs.test-lab.xenproject.org/osstest/logs/174580/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 174580-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174470 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174470 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174470 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174470 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174470 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174470 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174470 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174470 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174470 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail starved in 174470 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail starved in 174470 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 174470 version targeted for testing: xen 1c354767d58cd80224f0dfb107584bc8bd629b00 baseline version: xen 96220aec3e72b9d71600d78958b60e77db753b94 Last test of basis 174470 2022-10-26 19:06:00 Z 6 days Testing same since 174571 2022-11-01 15:38:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Lindig Edwin Török George Dunlap Juergen Gross Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 96220aec3e..1c354767d5 1c354767d58cd80224f0dfb107584bc8bd629b00 -> stable-4.14 From xen-devel-bounces@lists.xenproject.org Wed Nov 02 08:30:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 08:30:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435617.689214 (Exim 4.92) (envelope-from ) id 1oq998-0001Ac-FE; Wed, 02 Nov 2022 08:30:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435617.689214; Wed, 02 Nov 2022 08:30:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq998-0001AV-CW; Wed, 02 Nov 2022 08:30:50 +0000 Received: by outflank-mailman (input) for mailman id 435617; Wed, 02 Nov 2022 08:30:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq996-0001AP-PD for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 08:30:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq98w-0005KG-5V; Wed, 02 Nov 2022 08:30:38 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oq98v-000727-U8; Wed, 02 Nov 2022 08:30:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=X7YYZ4rzCBfvxVCsi13grVypqhTEE+93bLHLzJMi/YQ=; b=3Mo15bwNeJenAVJDtqmFqs7UJY QX7G1zWlYT81ilr+s7qlJuabdiwOuQETYDpi1Dz2VVT3e01vrhel7nQr5sEjBbDuVAnO8HFSjccwU 6eyaj0+dGLZ8vVeYNgthogvRMYV7cldRzIlA7g3xPxNmVHnoynrm2PNfExhFHnG3ArDI=; Message-ID: Date: Wed, 2 Nov 2022 08:30:34 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: Feedback for postponing the 4.17 release to a week later Content-Language: en-US To: Jan Beulich , Henry Wang Cc: "Daniel P. Smith" , George Dunlap , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" , "xen-devel@lists.xenproject.org" References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/11/2022 07:27, Jan Beulich wrote: > On 02.11.2022 04:00, Henry Wang wrote: >> >> Also I think we need to submit a patch to make the default CONFIG_DEBUG >> to n in Kconfig? Thanks! > > Iirc what was done in 4.16 was to switch to non-debug immediately after > branching, on the new branch only. That was specifically to keep debug > enabled at all times (and no undue code churn) in staging. Debug > intermediately off was (earlier on) observed to result in huge Coverity > reports, because of the perceived differences in the pre-processed / > produced code. That's correct. I will send the patch once we agreed when to branch. @Henry, From the previous discussion, it seems like we still have some blocker. Do we have any update on them? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 02 08:41:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 08:41:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435622.689226 (Exim 4.92) (envelope-from ) id 1oq9Jg-00035N-Fb; Wed, 02 Nov 2022 08:41:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435622.689226; Wed, 02 Nov 2022 08:41:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9Jg-00035G-BR; Wed, 02 Nov 2022 08:41:44 +0000 Received: by outflank-mailman (input) for mailman id 435622; Wed, 02 Nov 2022 08:41:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9Jf-00035A-Cx for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 08:41:43 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2ae788e1-5a8a-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 09:41:41 +0100 (CET) Received: from mail-sn1anam02lp2046.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Nov 2022 04:41:37 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5410.namprd03.prod.outlook.com (2603:10b6:208:29c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 08:41:32 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 08:41:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ae788e1-5a8a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667378501; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=+xxM5wFKUi3p/4vPj61Bn/Dr2aDLwstqkvQRZEDlcxU=; b=JfwKzQiqw5ZYotOmUf5s6XrUfd9VcG/Y4zxewZ2Ht4INwq7ClLaILZDB qoyKe4E0JQACERw0pQaIKSuyenBqNJafshgOib+B1VgjdQaXank6e4O/V mJ0mWC7+TG+F7sikle+c995yP/YFWMjbISo98R49Z5q3xrnc2GRS5VZEv 8=; X-IronPort-RemoteIP: 104.47.57.46 X-IronPort-MID: 84413670 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ZDW7jKMAhUgfJ9rvrR18lsFynXyQoLVcMsEvi/4bfWQNrUon3j1Sz TdJXD/Xa6reZ2bzeN9+bYzg9k4E7MCAn9JgTwto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpB5gZmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0slTGV5Er fIKEixOah2ln7qw4qmJb+Y506zPLOGzVG8ekldJ6GmDSM0AGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PVxvza7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr+TwXqgBt1KfFG+3qJlx3eJ+2U5Mhw5VWWFqvWdpmG8QOsKf iT4/QJr98De7neDTNbnWAajiGWZpRNaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBLSNrmK2YTzSa7Lj8hTGvPSkYK0cSaClCShEKi/Hhr5s6ihbnR9NqAqmzyNbyHFnY4 z2Mtjl4uLwVguYCzaD99lfC6w9AvbDMRw8xox7RB2uj5wYhPoq9PdT0tx7c8OpKK5ufQh+Zp n8YlsOC7ecIS5aQiCiKR+ZLF7asjxqYDADhbZdUN8FJ31yQF7SLJOi8PBkWyJ9VD/s5 IronPort-HdrOrdr: A9a23:T1vjraxB4QQs05XqMvsaKrPxj+skLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqm16Jr1usMr5 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGLf2RYUh2rD3xnklZqsoDWb/8sQqAe NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN DbXFZRpQcJCjbT4A21reh2Gzz2MRaAtG7Wu7BjDrBCy83BbauuNzGfQ1YzlMblq+kDA6TgKo SOBK4= X-IronPort-AV: E=Sophos;i="5.95,232,1661832000"; d="scan'208";a="84413670" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YTUCdhy4jNpOzaClFJZc3g/brb22/SqOL4bDz7j+sEHrFSf6Ce89hlDZfDcngVPgtkVWhuO+pHBcwGGfexrIp6skQmDiRC5pBkALo0+WqpwicSq4QLZOIMwsFEY/o05jpVgk1fnL7xmLH+gClugLiC0tKygV7JJM1PgMFaTX2Ci7dk0WBOCri4dtv7W5syPu5+4LolJw9XEzhX+BJCzhOVvE0VCpoGkGdt7mLahZ/NLAW3OTRbzISnYLZ10WbGhxvQYm9ijYvFkbL0u3ZiRO6XZV29KsJs1REgn9Kusm5N79gFnbZJ/plm3JhrzCPCE72gM03bLDOl4yR8yICXRNKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+xxM5wFKUi3p/4vPj61Bn/Dr2aDLwstqkvQRZEDlcxU=; b=FrVlfcg60dPK0qgf2aOIUFgAFcv1F1BlPGcazwFDlraPg8YAJ9c2obbG9MuU6hH5Z3peQWHuNmXM+AUL4WvKr86jTGJiprvpCLKAxCK4Wjvqt5BgnFaQ4XXCCn1FhkDYSaTh7p5p8sK9aeAZDmIVx5AcRVn14AfQQnvpqstQLoQEIGLclagf24Ai24vBtneCktnSkB+5UyzM2EZanxC13pUmHEAZisJe6n431KVf46CJRvsi4Wnn50hYFEjS7WdyRIJq0WHitXlW393RhJGWtwzCfh69/noLtmWdUFbXMqmyBx36CuiLp9nrDw7NVrFtRnl8WRSTSzxEurggulcS1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+xxM5wFKUi3p/4vPj61Bn/Dr2aDLwstqkvQRZEDlcxU=; b=tm+9agJEj4or9/OK23a5mgvOEdzBA4koO9/VDndRbR9G7/wsOLM4e389SwCo4LMQ6qgY6W59hPTABmGCngZa2KWuvTELSARh3h+bRXVIWvCMLdi3QJ1KfXe7f/DBHL9wG7uOrbp8I6ErLvhzYLnytX+Iw0alRlshntRM6imMdaE= From: Andrew Cooper To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: Wei Liu , Julien Grall , Anthony Perard , Julien Grall , Henry Wang Subject: Re: [PATCH 02/20] tools/xenstore: call remove_domid_from_perm() for special nodes Thread-Topic: [PATCH 02/20] tools/xenstore: call remove_domid_from_perm() for special nodes Thread-Index: AQHY7ga/5MFeaUWvXkWrm6X3MoCOY64rUcKA Date: Wed, 2 Nov 2022 08:41:31 +0000 Message-ID: <0a0d2d20-bba7-e802-a1aa-476390cf38a8@citrix.com> References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-3-jgross@suse.com> In-Reply-To: <20221101152842.4257-3-jgross@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5410:EE_ x-ms-office365-filtering-correlation-id: 2db92370-b746-4786-14bf-08dabcae0ace x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kgCd9haCsX6O/6AL8w5BeNyQjqzptJf5SEusdQEYv1e3aPtHfGPTxF6NSX17QLRoow7I+LSzSc2xSGNC2OR7gwtTbZGII2pJoZhGXUFzcz+hHSnIfG6k1d/a2QahXTmbEX1BhnTzjG0bCmqrlJHpeZ0BYgBLoB8ZrrTSDOJQ3QJLwITouDpgXjRNHDoPaJCZZw8SO0PIckZauV/Q3NRnhRlC3PtuPxRZh3nDjM+tchELIxQ37pS+FFF0uSTkA0VCUnRYrdnspcQBuOOBTfVzCfqNvpt1jO1f9g1d4ACDukemRhYQFNnguiCTAyD77o/B6+vUyuWoocQ5ipr5uy+0BGiLAJAa9SAzJbBNFxdEHWmtIcTyUkd6u1ONFBB6G1WznEIqZZgLdFIUD7AcE5sprVS6tAiNahUXvj/OLEW4g7pDCQGMLiFpZEOpkWwxjWpdaliG0jo2lOB9dCtiU8Y8cPHYJjm5GlbuoNGQ2yJi6LeDektNWoDbNRe4C7mHQchJ5G/TCbSAqGLJw7ljudjCtA86BhIMFLdERWO8K1uaYADnpZaDNgLCiv8SnSno3fJIXwHXgB2poIwUd+PF35OFVg1BozW10lc9FY+ZgQLEYoplAzUvxAZUfM6+k2nNSgiNYztsQgm3KRKDYsdy75jxEFxCyNQM+kZpWoEt2cURWrOV3ZBdY2b2fwU4QgNZztQikumlB9ujJiMPZj/211AjC4Hf99ZodulWUZJlWr393EXmlB/Y+klOtZZFeq8saqwooG64kMZum0w5VeEU2PlYsE0vgoZBGFX2338Ld+d8gtRVI2RJzHDTEJNwO6rzj4IqWGcsSVospegleJoeAgCHwA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(366004)(39860400002)(376002)(136003)(451199015)(6512007)(26005)(186003)(2616005)(53546011)(8936002)(4326008)(6506007)(8676002)(91956017)(66946007)(76116006)(66556008)(66476007)(66446008)(64756008)(86362001)(316002)(2906002)(38100700002)(31696002)(71200400001)(4744005)(83380400001)(5660300002)(82960400001)(478600001)(6486002)(31686004)(122000001)(38070700005)(110136005)(54906003)(36756003)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?US80R3AzQ0VvV1ZQNE5sajA1Z2cyT2RKbmxGenpZZHlsWEVLZFhrZmJZUWlQ?= =?utf-8?B?dFo2bCtMbzNiQTQ0YXZqU09VSWhiWmVFaTJ4eFd0UXU0bm9sVndhVHkvaUFt?= =?utf-8?B?Sy9MRVdrMkZ0bHU4MzlRajFWUEdSVVZPMFRpNXYrYk5icHZrS3RRTnhneHBa?= =?utf-8?B?NER4c1JmT2dMS0FlbUc0TmpIdlpvdE00KzljZURmMG43NWdOU0FmMVB0NXJS?= =?utf-8?B?dXg1ZjQrMmV0ZkFhLzFCU05KZkUrNVNoY3ZEbjRwb0NkNmtyTTdmRHFQNzZV?= =?utf-8?B?dmlrajhiSUxTWS93dk44b0xBSmV4MFQrSW9zSklleUUwblczWVdyZUNpVytR?= =?utf-8?B?bDhzWm05RVFPdkhCTWdFOEJrcW1YMDlwR01ZSjQxQjV4Mm05UWRvUlVFcXpp?= =?utf-8?B?TXZYbmVMajBXWHNJWkVzU2FIcjJ6VHV3YitHa1B2aWhmT0Y5b1VIelZFRlc0?= =?utf-8?B?ek9mU08yY2o4U1krL1lmU0ZTREUzWkgrTTVLeGVLMGE4SlZZb01XMzFaZVhW?= =?utf-8?B?U2pmUlhLWXQ4V2ViZnp3cUl5QXhxU1B0QTRwbnZTWTYzaVZwU2ZOYU43R0pk?= =?utf-8?B?ZCtOZTRXWDBjc0tJUmtwSEx5bTVEUlZnZWtuYjZ5NTYwOHZSZlQ2SHl4QkZ5?= =?utf-8?B?RGMxdUZ2UjBlQ1dkck1WNWtiOEpTZTkxU3hNZ25FRUJOTE1ORHRmODdWNnZQ?= =?utf-8?B?Y2ZIcGdGbWY2Y0JKZ2hwaFNxemZzTkE4cU9XY09OazBwbjUvV1VXSWpwM0VV?= =?utf-8?B?Y3pSeCtJV015dWNVR0szZGRSaDdDQldlaGc2RFE3ZjdCYUtoemEyY2pnTm92?= =?utf-8?B?YndTaVVnOVFmK1g1Q3lUSkNyeU9VeXRRQXVHeDFJQ0xQdVZYdmgxcTIxSVZI?= =?utf-8?B?azF1QTNGWmUxNWNSOHdmdzd0SklJSkg5R2thS21lWGthalRaUVIvaHJvUkYx?= =?utf-8?B?LzMzS3VOQjU3cDR3WWJSR3YzTUZmblQ1QWpCZjJNOFVCTDRGU2VjZFo5Mmh6?= =?utf-8?B?clJ2VkhqVVJRbyswVENYQUtwZ1Y0djNoSUFjMGlRTUE2dUM0N1VCdlFMc28r?= =?utf-8?B?eG9VVjd5Q1ZwbUdraStkOHE0dkJ0MktJaHZtblJkTEhNV05RT01DZDF6akRv?= =?utf-8?B?MEliUTJoeVdSa2NNRHk1MHZ2S0NKQ0V0NmlDTkNOdHg3bVdGYTNZd1laLzAv?= =?utf-8?B?ZmRNaEZrNVdCbW5vZE9VdjBDT0Q1QWpvWC9wK2tpbmFMVm5Mc3dLK1QwN25V?= =?utf-8?B?azFhS1VOVjBqTk1raldKWU52T1VYU0tReEZxUDNndTkvMUduUDMxdWRHOTRP?= =?utf-8?B?R211T2lHcitLTEtKdFJVa3BiOTRRblRqYW1pVE8wSUI5a1hnd0hsRWRtazZr?= =?utf-8?B?aEFlN3pkTi95aVVQeXBvK2dsQ2IvOUxGQ0h3VGZTdUo3dnFGL3V1T25iVlJt?= =?utf-8?B?TXFzUFZ1VThaY1Ayeno4T25XYTVXTEJLck5MODN5d3dJOTR6Wk9sY2NGQTdk?= =?utf-8?B?enR0dEpURHVSdUxBdUNMY1JBRmNYa1hDLzRzUHNjRS9IS1FkR1crVURybW5v?= =?utf-8?B?bVJxMXM3M1c4NENvRE4wajB3TmFieFRPcmpGTWpmd1dkcXdpenVUaTJ3aTZ2?= =?utf-8?B?Mm5ZMC9QMFZWaGk1RVZKNmllejNkTW5sL21tRGdKRzVhS0ROVi84Y2lsOUVt?= =?utf-8?B?N3BuUUtScEdNNW1vWE4zaXNXdko4a3pRY2lzZFpneVZINERDYlZFSDZOU1VL?= =?utf-8?B?TmZxVW5nblBUZURzbVAvazNRQlN3YVJMN2d1cG5ZcnlEaWtDb096UFF4YjVv?= =?utf-8?B?Zy8xNW02eXI4bkw3YXF3bHR4V3BuQU9RWW9CU2puQ09YVlllbW9sVzRLZ0JJ?= =?utf-8?B?WHlxTWI4QldYaXdEZWFoWDhVRkVIWnk2VjE3MU5Tbm5NL3ByZjBmVTdKYXlk?= =?utf-8?B?ZG8xQmQ0cmdnVHhWb1RxSWErQVVIeWRPcEV5bkRFVWlGMU0xN1pkYTAzU3BF?= =?utf-8?B?ekFqVGk0SGYwN0RpT3BpZm16UDRRT29MVFliOXFwWGRSL2N3MmlJUlNmaCtT?= =?utf-8?B?aThleCtmVUkvSFMzd1E4dG9ueldsZlZTQ2JmaERSc1QzS1NsUUNRaWNXZDlY?= =?utf-8?Q?MhJDzN7COpvoSGGawhSJO4tZt?= Content-Type: text/plain; charset="utf-8" Content-ID: <36C99CB5A6A57A4FAC29E500A362E6C6@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2db92370-b746-4786-14bf-08dabcae0ace X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 08:41:31.7643 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AayWB9fU3bX8WZ0bj6v2tzwxE7YjvRodqQBKwyfcytanQPGXgvlL22luJjOh7P7Y5omMIhlUsl7+Gsc47yO9Sv5H7x0sAGcxuUPC43mRlhI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5410 T24gMDEvMTEvMjAyMiAxNToyOCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gV2hlbiBkZXN0cm95 aW5nIGEgZG9tYWluLCBhbnkgc3RhbGUgcGVybWlzc2lvbnMgb2YgdGhlIGRvbWFpbiBtdXN0IGJl DQo+IHJlbW92ZWQgZnJvbSB0aGUgc3BlY2lhbCBub2RlcyAiQC4uLiIsIHRvby4gVGhpcyB3YXMg bm90IGRvbmUgaW4gdGhlDQo+IGZpeCBmb3IgWFNBLTMyMi4NCj4NCj4gRml4ZXM6IDQ5NjMwNjMy NGQ4ZCAoInRvb2xzL3hlbnN0b3JlOiByZXZva2UgYWNjZXNzIHJpZ2h0cyBmb3IgcmVtb3ZlZCBk b21haW5zIikNCj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29t Pg0KPiBSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCg0KSGVu cnksIHRoaXMgb25lIGFsc28gb3VnaHQgdG8gYmUgY29uc2lkZXJlZCBmb3IgNC4xNyBhdCB0aGlz IHBvaW50LCBhcw0KaXQncyBhIGJ1Z2ZpeCB0byBzZWN1cml0eSBmaXguDQoNCkFzIG5vdGVkIGlu IHRoZSBjb3ZlciBsZXR0ZXIsIGl0IGlzIFItYnkgYWxyZWFkeSBhcyBpdCBjYW1lIHVwIGluDQpw cml2YXRlLCBidXQgd2FzIHVsdGltYXRlbHkgbm90IGluY2x1ZGVkIGluIHRoZSBzZWN1cml0eSBj b250ZW50Lg0KDQpUaGFua3MsDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 02 08:43:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 08:43:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435626.689237 (Exim 4.92) (envelope-from ) id 1oq9Lh-0003f0-RA; Wed, 02 Nov 2022 08:43:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435626.689237; Wed, 02 Nov 2022 08:43:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9Lh-0003et-OO; Wed, 02 Nov 2022 08:43:49 +0000 Received: by outflank-mailman (input) for mailman id 435626; Wed, 02 Nov 2022 08:43:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9Lg-0003el-Dq for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 08:43:48 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2086.outbound.protection.outlook.com [40.107.20.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7662aaf9-5a8a-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 09:43:46 +0100 (CET) Received: from AS8P189CA0056.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:458::33) by AM0PR08MB5458.eurprd08.prod.outlook.com (2603:10a6:208:185::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Wed, 2 Nov 2022 08:43:42 +0000 Received: from VI1EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:458:cafe::2c) by AS8P189CA0056.outlook.office365.com (2603:10a6:20b:458::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Wed, 2 Nov 2022 08:43:41 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT027.mail.protection.outlook.com (100.127.144.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Wed, 2 Nov 2022 08:43:41 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Wed, 02 Nov 2022 08:43:40 +0000 Received: from b615575a6ebb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6C32B0DF-2BF7-4FA7-ACFE-3EEBAD9F6788.1; Wed, 02 Nov 2022 08:43:33 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b615575a6ebb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Nov 2022 08:43:33 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB4PR08MB9336.eurprd08.prod.outlook.com (2603:10a6:10:3f3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Wed, 2 Nov 2022 08:43:27 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Wed, 2 Nov 2022 08:43:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7662aaf9-5a8a-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Sg201/zs4/l+dzKRxyU0BiVvIkoaI/u3ykNnotinSu9t6shl9nGwFhMCkWxPMSTm45LHqNproWTsZ5u4tysUCJGDxjk72MsBlkEF8BZjPey26s/K58Fuy9mWhgeouuwNh7MuV+QqHL0z50ya2J0YIcw/WV9zC8cqGplNB2razWuKcGRJ8SMW0dMfCfK/BE/IcSdCouXIv9wxIp+eubjvTjIwAGGCwBCZ9gYQ3Wsf2TTmuaVSJp6SPLwcBURsXxEfPfmkyyQoUkD6DxXbERhmSQuM614brVLcSEVhFVFjlXyPWaJ3s8LTo3kWQoP0axdQ5f7U7+klFLNPSySHIcbeZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bhuBIBtjzum9X2+gEP41HhUCDeiUfqibsaK2tCuVjGQ=; b=B144Oh1nCsBVnnED1oj+ejjTuHtfphDEHzT/zz2buivJ4HAbCknZE9PW3SfqIHY6enZd9TnFxqt3MlnjxtOpoJGrhRl+QaK5tk7hipmiyHHF0ICgE2b2VAOecDkIZp2nAJUlbhb52cj8+88LRF3q1PyPzSIRZZbFMfh/ac1LlFMNeLfc3SHATSHnHhzq9kaTBK1JV7LEWy4KlrU3YtdpKJQG99v4mA8upnWsm7GQa8XpGw0wr6P/NtEE+dI526hgsaw1gSqevN+hgETTVpQlRyVeUmTmDTL0JhjYple372VZo7nuH8ENzo7D8iwJPe2M2PzjZZjnirsUwpHh0ljAhw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bhuBIBtjzum9X2+gEP41HhUCDeiUfqibsaK2tCuVjGQ=; b=1AZ6R2vHzBr9zIf7aY0Iz6mR5Ip7Jm1/RkaeYTaeVZnkV8P98wtcKd3VWO1/uWqsTXaPmSSTfUL87C42ingkME8x4Btl0u+fm6W1IN1yRv/avkLuDhnLYO4wHdKAJMrWd8QsQRKlYq3TbSpvKBsJGrJEb7xMdl5oF31ghuo4FXg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h4YlOkNPI0glkm/QgoL+uY5nV0Q3WTNJnxmGk1NlNIL5YHmtcw14+Iilk3W53/SZMutp5Wgeou7Aq66OVMtIt9aJmXI66Kb35UBCj44yvGT1nv0+oA7qTJLqYSwj5hPHgIOMF6yoG2dvr5D0JUYH6291iddIrhA3N1WBFlzc0RMEdqaWbWmUpsiM4FDBq136l5K4i8gIM9wwJNJ/i3biiwKRTg1OYFzOkfkS0VR5q85XQP9hvSGAFWEnSPLcoLGjhfUT0aN34QOSHzwGJ8m8PkzXuwliHV9XS4jpqCPGpYdEhhMqNqEASImZDVog9Eoaj5kuBdWgAacJVQM49s3tQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bhuBIBtjzum9X2+gEP41HhUCDeiUfqibsaK2tCuVjGQ=; b=QIv/a4QER2DDkWdbBAZfsNjpLmc9Q03Fy6CbXmuDOezZ/KH0FqEOa2oKU6wMXl0TxDbNwJ+FzGU3MnOD81eM3sihJqdtcgMjkrlAk4cOXodTzW8Rzj3QiIRYD3JkDCSP39JTtg04ILuGORw0yEpY3UIZ29rVmODGZzuKIjOWT+3aQ86lhRYU/YA8wHoy/Q4g0M/1FwmzLorTh7MgmwyT2G5zQnIeeQYgT9PknZ4ZS/UBFAv/o6aIezvqJmDQm5b987oTB0O5mWE37ixrL7TW0FzJVQgtve9frik1OLN+Xj1eElpHMSWgG7/KHtwd2tHGkxfmjSOYmMssJ7+UI/1LuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bhuBIBtjzum9X2+gEP41HhUCDeiUfqibsaK2tCuVjGQ=; b=1AZ6R2vHzBr9zIf7aY0Iz6mR5Ip7Jm1/RkaeYTaeVZnkV8P98wtcKd3VWO1/uWqsTXaPmSSTfUL87C42ingkME8x4Btl0u+fm6W1IN1yRv/avkLuDhnLYO4wHdKAJMrWd8QsQRKlYq3TbSpvKBsJGrJEb7xMdl5oF31ghuo4FXg= From: Henry Wang To: Julien Grall CC: "Daniel P. Smith" , George Dunlap , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Jan Beulich , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" , "xen-devel@lists.xenproject.org" Subject: RE: Feedback for postponing the 4.17 release to a week later Thread-Topic: Feedback for postponing the 4.17 release to a week later Thread-Index: Adjqh6nb7bpyTo+8QPKuDS/Y5NDKqwAI6YmAAAA21oAAAA9FIADukS/AAAl2iAAAAjY/AAAAV4vw Date: Wed, 2 Nov 2022 08:43:27 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7C5E489CF1127A41BD3260B975BBCD20.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB4PR08MB9336:EE_|VI1EUR03FT027:EE_|AM0PR08MB5458:EE_ X-MS-Office365-Filtering-Correlation-Id: de1e21ea-d697-410f-d0cb-08dabcae584e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hsVXYb0T99yocW0Q1Dy/JU8tpj/fIxjAebZ1/e/NE+v5kESLqDcC2Qcq+vSG2q8X7uK75yiqeYLDqhZzncoYv6pLp4W85JVLxYjxikEbdOUB9VYIpKaGqUqw7l5F+TO+EHJKwIE/5lxpM1lf6m1QM4UoOuPp0cyOs5xz0I8I6uFi62YDwfFJ9PkiVJXQWzQrQiGyst9d0MgXNMKk+xmGaSBG12YchaBVxp7AgxOW5kppwWaZlFXnlHxzNtcibRRgC0I8oipkg2ALZ5FlA9n7IfZNtbk0IDQsoFPLC+/0g63EJw1zu80EaC/sbGd2Y4CFoEz9uCHRqPf4ERr4QEQNONPeYVvKmOrT7aqmFPFK9wtA0zpI8EBMZ8ufFCSR6GtglstKSoIKrVur77ib9Zd5D5y3exI27/YdYs2ITjNyKlSqgT1dnG5oo48J17r81f6cgK4iYVkF+lggwwpQqhLVNgITv6ayLsZ5dZaI4gMWdP4861f6++9bg3I2/2tIqpuqELGNRukNLTPI0sJ2v3jzUcvL6Y143o+1hrgaQUgazVs+6T0Q1jPKoquySLMbQt9XPtaFZ1Pu8W/t6nt1ABW2C+2sOZdWFIj3ipUpXUIRKdPZ/ZO5vrfmSA/m7OkYtS0soSV859ex4wi25tBQOFkG5hM/zEKX3+9BRfNC05S+MP2L31++ynPBZ32klZHLiXMhXLWfvZlmKnHaXFYTAbrh2xyAoi1bLEOUNp6OATdMFn0p/RxWBu2GGHFMj4hifVDtsAl9EmlnW6taxS0BR82mcTQ/JmfJTZwewInt97Sef40= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(39860400002)(346002)(366004)(451199015)(53546011)(5660300002)(7416002)(38100700002)(26005)(2906002)(52536014)(33656002)(7696005)(86362001)(9686003)(6506007)(966005)(38070700005)(478600001)(54906003)(122000001)(6916009)(71200400001)(55016003)(41300700001)(64756008)(186003)(76116006)(8676002)(66446008)(66556008)(4326008)(66946007)(66476007)(8936002)(83380400001)(316002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9336 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6c3947ba-c866-4013-3985-08dabcae4f9d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tIExFpZueilIW87i0y3VbCdzSNRO+yBurexKrpeaMhs5RrTUO81EYXKbMTSDzWZgU6lNb6aJvXGgxoAMJ5JMaTSixY2rRYQ9ftv3T9K2F6azKFoDGRQFVQzjDrUUv8GIigR3MNh2KT5RWHFMJPTaKchGJkKZ97YLnofdfOzC9U2xsg18U9RN1YVu9Yv76Dqdz6Eqg4M1hRXrEIMQSk0jTWJIA1La1w++Y+AkDTji8oIfiTXGJ6OWSmtVBoj/m43L/ORZEf4k3B2molDwX68+hiy4ANdKn7gL6o5jO8ikDQKazbnnJA0wyAUKczWDqNLCW/b2DRU1Gm52fegRMxofpOo26JQO4K+YjhUfGKFdNZKUS0QZQgXDK0ybF54jLi88ZWlU7WidYzryA7PWVtH+wHGDEHbKqKnPEBMDn5lVqLIDHgGTFxMFBuS2udHlLtuYbRsOreZyHR+Aq9ia0OZdCFycDwh0CzAViCvUiaKbUmJPicWAz1CYHGuE1PT8eAXJiFFI9/YxoHE0Yi7LKll/XpbhhuJrsmIODZOaf2IUdjXL5bV43KVIth+FB9/vMTPUQK1QJjoHR63Y4bMhY+9RjCtsmUB7mgYAZuOBQ1jdPqjCVw3VheR8cflQSaap1sD+oL6SC4quR1znHOX6E5/Gdz5Cla1uoNfTf3T8bIHOKf0ooNEeGDdS2txjmZBj2NIO6pwgTLQbzYLploZ+KUiO/WFF7RzNle1s73wvYhMzn6BeD0gFdsqHAB6MWjeju0syexqwsWsOSCOdtYeY5U4h8AAdYEqxUo6uCgmqp0yeIpCWd+FX5YLXDVyeDFCmAj3J X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(346002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(40480700001)(40460700003)(70206006)(55016003)(53546011)(316002)(54906003)(8676002)(7696005)(70586007)(33656002)(4326008)(6506007)(82740400003)(83380400001)(52536014)(81166007)(356005)(36860700001)(41300700001)(6862004)(82310400005)(9686003)(5660300002)(47076005)(8936002)(26005)(86362001)(336012)(186003)(2906002)(966005)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 08:43:41.6988 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de1e21ea-d697-410f-d0cb-08dabcae584e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5458 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFJl OiBGZWVkYmFjayBmb3IgcG9zdHBvbmluZyB0aGUgNC4xNyByZWxlYXNlIHRvIGEgd2VlayBsYXRl cg0KPiBPbiAwMi8xMS8yMDIyIDA3OjI3LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gPiBPbiAwMi4x MS4yMDIyIDA0OjAwLCBIZW5yeSBXYW5nIHdyb3RlOiA+Pg0KPiA+PiBBbHNvIEkgdGhpbmsgd2Ug bmVlZCB0byBzdWJtaXQgYSBwYXRjaCB0byBtYWtlIHRoZSBkZWZhdWx0DQo+IENPTkZJR19ERUJV Rw0KPiA+PiB0byBuIGluIEtjb25maWc/IFRoYW5rcyENCj4gPg0KPiA+IElpcmMgd2hhdCB3YXMg ZG9uZSBpbiA0LjE2IHdhcyB0byBzd2l0Y2ggdG8gbm9uLWRlYnVnIGltbWVkaWF0ZWx5IGFmdGVy DQo+ID4gYnJhbmNoaW5nLCBvbiB0aGUgbmV3IGJyYW5jaCBvbmx5LiBUaGF0IHdhcyBzcGVjaWZp Y2FsbHkgdG8ga2VlcCBkZWJ1Zw0KPiA+IGVuYWJsZWQgYXQgYWxsIHRpbWVzIChhbmQgbm8gdW5k dWUgY29kZSBjaHVybikgaW4gc3RhZ2luZy4gRGVidWcNCj4gPiBpbnRlcm1lZGlhdGVseSBvZmYg d2FzIChlYXJsaWVyIG9uKSBvYnNlcnZlZCB0byByZXN1bHQgaW4gaHVnZSBDb3Zlcml0eQ0KPiA+ IHJlcG9ydHMsIGJlY2F1c2Ugb2YgdGhlIHBlcmNlaXZlZCBkaWZmZXJlbmNlcyBpbiB0aGUgcHJl LXByb2Nlc3NlZCAvDQo+ID4gcHJvZHVjZWQgY29kZS4NCj4gDQo+IFRoYXQncyBjb3JyZWN0LiBJ IHdpbGwgc2VuZCB0aGUgcGF0Y2ggb25jZSB3ZSBhZ3JlZWQgd2hlbiB0byBicmFuY2guDQoNClRo YW5rcy4NCg0KPiANCj4gQEhlbnJ5LCBGcm9tIHRoZSBwcmV2aW91cyBkaXNjdXNzaW9uLCBpdCBz ZWVtcyBsaWtlIHdlIHN0aWxsIGhhdmUgc29tZQ0KPiBibG9ja2VyLiBEbyB3ZSBoYXZlIGFueSB1 cGRhdGUgb24gdGhlbT8NCg0KSSB0aGluayBjdXJyZW50IHJlbGVhc2UgYmxvY2tlciBib2FyZCBb MV0gaXMgYWNjdXJhdGUuDQoNCkZvciB0aGUgdXBkYXRlLCBJSVVDLCB0aGUgTVNSX1ZJUlRfU1BF Q19DVFJMIGZpeC11cCBpcyBhbG1vc3QgdGhlcmUsIHdlDQpoYXZlIDIgb3V0IG9mIDMgcGF0Y2hl cyBhbHJlYWR5IGJlIHJldmlld2VkIChJIHdpbGwgcHJvdmlkZSBteSByZWxlYXNlIGFjayBub3cp Lg0KT25seSB0aGUgcGF0Y2ggIzIgbmVlZHMgc29tZSByZXZpZXcgZnJvbSB4ODYgbWFpbnRhaW5l cnMuDQoNCkZvciB0aGUgb3RoZXIgdGlja2V0cywgSSBhbSBub3QgcmVhbGx5IHN1cmUgaWYgdGhl cmUgaXMgYW55IHVwZGF0ZXMuIEkgd2lsbCByYWlzZQ0KYSB0b3BpYyB0byBkaXNjdXNzIGluIHRo ZSBjb21tdW5pdHkgY2FsbC4NCg0KWzFdIGh0dHBzOi8vZ2l0bGFiLmNvbS9ncm91cHMveGVuLXBy b2plY3QvLS9ib2FyZHMvNDcyMzYwNT9taWxlc3RvbmVfdGl0bGU9UmVsZWFzZSUyMDQuMTcmbGFi ZWxfbmFtZVtdPVByaW9yaXR5JTNBJTNBUkVMRUFTRSUyMEJMT0NLRVINCg0KS2luZCByZWdhcmRz LA0KSGVucnkNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 02 08:45:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 08:45:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435631.689248 (Exim 4.92) (envelope-from ) id 1oq9Mx-0004YK-8X; Wed, 02 Nov 2022 08:45:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435631.689248; Wed, 02 Nov 2022 08:45:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9Mx-0004YA-5l; Wed, 02 Nov 2022 08:45:07 +0000 Received: by outflank-mailman (input) for mailman id 435631; Wed, 02 Nov 2022 08:45:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9Mv-0004Gr-KD for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 08:45:05 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2042.outbound.protection.outlook.com [40.107.20.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a535d61f-5a8a-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 09:45:04 +0100 (CET) Received: from AS8PR04CA0203.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::28) by PA4PR08MB6191.eurprd08.prod.outlook.com (2603:10a6:102:f3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 08:45:02 +0000 Received: from AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f3:cafe::2e) by AS8PR04CA0203.outlook.office365.com (2603:10a6:20b:2f3::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend Transport; Wed, 2 Nov 2022 08:45:02 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT006.mail.protection.outlook.com (100.127.141.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Wed, 2 Nov 2022 08:45:02 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Wed, 02 Nov 2022 08:45:01 +0000 Received: from 948600757415.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BD4DF0AC-0A94-4486-8B2D-9F048D943312.1; Wed, 02 Nov 2022 08:44:56 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 948600757415.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Nov 2022 08:44:56 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB7884.eurprd08.prod.outlook.com (2603:10a6:10:3b0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 08:44:52 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Wed, 2 Nov 2022 08:44:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a535d61f-5a8a-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ch47SOG89eC4UWI44ZqDtpRTTtHVWJ74elZBBfI+m0vTWBI9IwIxEdCHDrlDhZqX5aL6oW/1e9QsDE0kUe7cBaoUrcMpOhcdzVe28hliK02Nbeht84HCfLMEKFePiqShn+odv2Ff1Y736BohVDGCimJ/4RIFKD2VdjLnrjV0IaRr/CDKTRlBhfMMTRZvwYYYovKlH8ceYuLuhaWwe8SrqIR5Y+dXLIMZnSxa0yFjGvRnXufXeYlsBtrN05Qvi1A9V0/l8/fmOV669B1yzVpgB2LeVx7+nvMCFiVjfGRU71m8fKlo/lfbq+0Ypg7RYJJxBreqoy3UB6k3i5RjYD5+xA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oK4jbHfGL94GP7JAH7C2CgduJanU8YTRpFQRxy7Cm04=; b=OSFJ9i+uEQtAkHO09G9SxJLsOD3pgMOdodVorllPbDVVkeaClT3AOy0sBvdYfPaxfn9faky2chIw8yG/oXrmLq2XBHIvUViJQYV+6zq7U8ZfnqZxOKsncntczJhpnXL6lq9jNnRRAV8l3gF1YAyuAI/l4p/m+UPvVvg366ctF2QWQMEvB5vq2uuOIvrFBLskuluHQn2n6KRkoAvBcqVX5mY07inP7QBu2RjD8HMAXLYhOnosazr+wBIa4fEPtsAcpYht6MiCoQ2xFVbBB2OurNobLbE1TWXxS4/6H78ZWpR+pra0/So7oObMtVbKuyItquc69Dk2grHEBFIqaRmlDg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oK4jbHfGL94GP7JAH7C2CgduJanU8YTRpFQRxy7Cm04=; b=NPbYcHCSykTwTBgU/Pv5qcv/sE1ipf+gke6IPkC68C1RdT14JYgPdBDnO7CTwKgDAWh9DIgybo2MTyRZ0/67FOvwgwAyMhbZgZ322n8t5hyQWp2xPaYNVTLOfvS2mL+fMiuOofGCFM2g52tvqUuO+M9Xdg71gevzZxDQRsOqJ30= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cKPt+DA0pJS5DGVHa/6/kslw4mAR9ZPYPp4YIkf0TCsjOV56ufZMROH1An3ng8wIMABFTHGZZvBXhdc+mgYI/cyvpOlChmLkJIgF2kKruwtGZ3uYh6PBVqLkxR550IO4oTkS8LwkMe6ZwLWukT5DbxzOLka9wV7M4Y0lfwJRGgeTTZVfB5IghLqKdQG/YBZ/7UTfCeN9FDVGLR9pVhLnp253ZKxTzaY3Eu7plThdYJtoZJEZ2143SCDjaT5HxUKKhU4Qo7aVRTyclYX9W5Lj6vMsRBx+pXEuxckLG/qVIkJCmgIs38rfUNeYqIOHynyYldJz45f0FYuC0yMP2HwUTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oK4jbHfGL94GP7JAH7C2CgduJanU8YTRpFQRxy7Cm04=; b=lZS08AD312nF8wUuqAk83ATYTgOgPUXtU8Yh+Ty6VZgWjPFExg3D8e0BNQCXpeOOW+fa5e4Vrked11WtsK8qDtVfWAegHCtKC1pE6HZi/5Cb5npvPAYIJLvRx2txifYOnwK/oXMe9gjIGgJECGmNyUP+LmqwsvD1Aylh63oBf+5mo7BAAktKr86PSWtDV/B30nywGrC6/W+z6ye1Y/mWn7dURcLXOnstv6v1hkB+bt7RyJ6Toxe71ZR+lo+Sv8TYUJ8BGPxmY8I/42EAuw81KFcPBVIsDNuGNKYDY7kRj0hG2psa2/HGpN1bGhc3LvXWm6A1MaQHY8jJOa/JgePqYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oK4jbHfGL94GP7JAH7C2CgduJanU8YTRpFQRxy7Cm04=; b=NPbYcHCSykTwTBgU/Pv5qcv/sE1ipf+gke6IPkC68C1RdT14JYgPdBDnO7CTwKgDAWh9DIgybo2MTyRZ0/67FOvwgwAyMhbZgZ322n8t5hyQWp2xPaYNVTLOfvS2mL+fMiuOofGCFM2g52tvqUuO+M9Xdg71gevzZxDQRsOqJ30= From: Henry Wang To: Andrew Cooper , Juergen Gross , "xen-devel@lists.xenproject.org" CC: Wei Liu , Julien Grall , Anthony Perard , Julien Grall Subject: RE: [PATCH 02/20] tools/xenstore: call remove_domid_from_perm() for special nodes Thread-Topic: [PATCH 02/20] tools/xenstore: call remove_domid_from_perm() for special nodes Thread-Index: AQHY7ga8TbV3UfvVg06BXOIqShILHK4rUcKAgAAAoDA= Date: Wed, 2 Nov 2022 08:44:52 +0000 Message-ID: References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-3-jgross@suse.com> <0a0d2d20-bba7-e802-a1aa-476390cf38a8@citrix.com> In-Reply-To: <0a0d2d20-bba7-e802-a1aa-476390cf38a8@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 9EB0839AE561CD41B93F1E656E51B0BE.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DU0PR08MB7884:EE_|AM7EUR03FT006:EE_|PA4PR08MB6191:EE_ X-MS-Office365-Filtering-Correlation-Id: 481b7c6f-dd8b-451e-8606-08dabcae8837 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6KxubFG7NjbmsvjZgag8oiJRkRtSsXKYS4hVFBu5/QsDoIOAySR0Ql9GV9ohl/XTuriJ49AHdisrKPpI0O3lMhVaOquHU7YK5pIdZ+fYs5k1VuInRbXgaIE0n+2ozEUgv+gX8W5i4DtipPMoXjo78cBtttn1O/JJ602H5UslU80oUn/D5/YD5KY1HVK1YcYig6aVp3WiUBvB/wFtAqRcqmi8POX2jcsTrV43n9AxPoWSNL+yFmjzHddMNKB6izBy4WeOc+lsiHo1DiprBoh9AESnjVl/zkQVnsg0YX0v17HqaYh5b/oBK2GCILqkidqJ+n6FsFWC7uQ2pixep66nseTeWoFSR5pch9nEhwqI9hgSSM1RmT4VTmGj+/lmJDyqgJLlj84E48bcqa9dtK6+NHVpSt4kpmW/RZz8d2YPYuayOnEXi2T/Y8N21YVU4c9kGBOxmVi8pNASrMfeB1udZZUnPczUDXP9dHi++WIh4eH7D1Xv9hjNYZrI6tFHL74KiTpbL7tVYf0n53e3BpFCRMON/pcVox824kpj0maPuSXvRCNv313vJIlz0EWJj19vKRpOJyZ0afQRn0Ixr5WOfR1AFvlzUBDQcZoNpeCwonOtPZHEWlulh6r9wdSiobapPFNR/CJlGtug8/mzrTXwC2Nx/s/lCIgLkxBbDg1RHnou044BAVuEDl/jQAQguXYgJezU6j+XtuMhwNn6CJz5wnFiFgFij0uTfOEPhlIvI2FZ1K7371HCfhu/Vd/TpoPY6A9u8/HZRAMB//YOkh+fxQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(366004)(346002)(396003)(451199015)(55016003)(186003)(478600001)(4744005)(9686003)(26005)(86362001)(38070700005)(33656002)(52536014)(122000001)(8936002)(2906002)(38100700002)(7696005)(53546011)(5660300002)(6506007)(71200400001)(41300700001)(83380400001)(316002)(66476007)(64756008)(66556008)(66946007)(54906003)(66446008)(4326008)(8676002)(110136005)(76116006);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7884 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 414c2e9b-fe73-40a1-d8b8-08dabcae827e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aWJp3wa+ExTJC7STc02sHY6wJ0noQI94nLbhhv2rGLGR9MM7XHnSg/Y7ElsEPrV/k2Oq2mrMcJaum1yHCTfqa7cPnZy+rEsq2NbNssSNC7nopfTlXEdvGBfFSTzXfIwc+YaaGss63iIj+xX+5B0OJtxqCJYH0EgUPCtiNa2UxA3p8toPkK2o2ILjbz8QfwjzGAWfzgFp49BGsYiWYsyGSQMI0kFGYfHA9oks2ob/KgnRQHZ5uj6SeJ8qfwgYKAgR5CtviXsT04RaWAy0o+9Kdiwk8W5EpSkMJQpe2AOq4lJCg4ofAX299Oc/D8L4s6IUOarkx4YUvOCDL0Ywi6ko85+RZsAaZAqkjcgADjJXGxKAXy2f+4uGKNgFudswabfl62DeWRR7BIQV+qaMHD6ELbh10/H1ijqiimND6JSZppcdpq+NGAZRfeBM1EY2Z+nnrbkqmvT63Z2bH4RD78HjMi3R+dtbVeyIIPXyLkczfrprzmlcKa8BSTnhVg7rFMPmzZHf23OuLv6DEXXqkRh00ffxgsDm7aRb7GzcEU4Rj+EjTDRqM4PmRXwWDbbjIugwJ+EBgW30OuAHRZlw6BH1iE+0dybCvpDktiD67ZW4MOsP4Y9+CMWey48Tx9kfrT1Gc+d+l4FMLSyru66jiRKLOmT66v8eEMAFUv6Y2CnRdcYGdirDx+ak/34/nDQZJfmYY4I9uOTv7Ieyi8HrIZYUfMH7SzNAoLT4Y1qK2IqHzPoYhCAohXwsStbkcjbvaXOfQPvGWz3vM8AFzpSvZkVF/w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(396003)(39860400002)(346002)(451199015)(36840700001)(46966006)(40470700004)(5660300002)(8936002)(2906002)(4326008)(110136005)(54906003)(33656002)(41300700001)(70586007)(8676002)(70206006)(83380400001)(52536014)(478600001)(316002)(55016003)(40480700001)(356005)(81166007)(36860700001)(82740400003)(107886003)(6506007)(7696005)(86362001)(53546011)(336012)(186003)(47076005)(40460700003)(26005)(9686003)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 08:45:02.1549 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 481b7c6f-dd8b-451e-8606-08dabcae8837 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6191 SGkgQW5kcmV3LA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEFuZHJl dyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggMDIvMjBdIHRvb2xzL3hlbnN0b3JlOiBjYWxsIHJlbW92ZV9kb21pZF9mcm9tX3Blcm0oKQ0K PiBmb3Igc3BlY2lhbCBub2Rlcw0KPiANCj4gT24gMDEvMTEvMjAyMiAxNToyOCwgSnVlcmdlbiBH cm9zcyB3cm90ZToNCj4gPiBXaGVuIGRlc3Ryb3lpbmcgYSBkb21haW4sIGFueSBzdGFsZSBwZXJt aXNzaW9ucyBvZiB0aGUgZG9tYWluIG11c3QgYmUNCj4gPiByZW1vdmVkIGZyb20gdGhlIHNwZWNp YWwgbm9kZXMgIkAuLi4iLCB0b28uIFRoaXMgd2FzIG5vdCBkb25lIGluIHRoZQ0KPiA+IGZpeCBm b3IgWFNBLTMyMi4NCj4gPg0KPiA+IEZpeGVzOiA0OTYzMDYzMjRkOGQgKCJ0b29scy94ZW5zdG9y ZTogcmV2b2tlIGFjY2VzcyByaWdodHMgZm9yIHJlbW92ZWQNCj4gZG9tYWlucyIpDQo+ID4gU2ln bmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiA+IFJldmlld2Vk LWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KPiANCj4gSGVucnksIHRoaXMg b25lIGFsc28gb3VnaHQgdG8gYmUgY29uc2lkZXJlZCBmb3IgNC4xNyBhdCB0aGlzIHBvaW50LCBh cw0KPiBpdCdzIGEgYnVnZml4IHRvIHNlY3VyaXR5IGZpeC4NCg0KWWVzLCBJIHdhcyB3b25kZXJp bmcgd2h5IEkgZGlkbid0IGhhdmUgYW4gZW1haWwgaW4gbXkgaW5ib3ggYWJvdXQgdGhpcw0KcGF0 Y2ggOikNCg0KUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29t Pg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBBcyBub3RlZCBpbiB0aGUgY292ZXIg bGV0dGVyLCBpdCBpcyBSLWJ5IGFscmVhZHkgYXMgaXQgY2FtZSB1cCBpbg0KPiBwcml2YXRlLCBi dXQgd2FzIHVsdGltYXRlbHkgbm90IGluY2x1ZGVkIGluIHRoZSBzZWN1cml0eSBjb250ZW50Lg0K PiANCj4gVGhhbmtzLA0KPiANCj4gfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Nov 02 08:45:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 08:45:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435634.689259 (Exim 4.92) (envelope-from ) id 1oq9NW-0005D1-H7; Wed, 02 Nov 2022 08:45:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435634.689259; Wed, 02 Nov 2022 08:45:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9NW-0005Cu-E0; Wed, 02 Nov 2022 08:45:42 +0000 Received: by outflank-mailman (input) for mailman id 435634; Wed, 02 Nov 2022 08:45:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9NU-0005Cd-I9 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 08:45:40 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2049.outbound.protection.outlook.com [40.107.249.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9fcae5d-5a8a-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 09:45:39 +0100 (CET) Received: from DB6PR0501CA0038.eurprd05.prod.outlook.com (2603:10a6:4:67::24) by GV2PR08MB9375.eurprd08.prod.outlook.com (2603:10a6:150:d0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Wed, 2 Nov 2022 08:45:37 +0000 Received: from DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:67:cafe::dd) by DB6PR0501CA0038.outlook.office365.com (2603:10a6:4:67::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.21 via Frontend Transport; Wed, 2 Nov 2022 08:45:37 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT040.mail.protection.outlook.com (100.127.142.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Wed, 2 Nov 2022 08:45:37 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Wed, 02 Nov 2022 08:45:37 +0000 Received: from 9912b7738943.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 987DE7FF-C636-4888-8504-5BB8724CC47A.1; Wed, 02 Nov 2022 08:45:30 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9912b7738943.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Nov 2022 08:45:30 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS1PR08MB7401.eurprd08.prod.outlook.com (2603:10a6:20b:4c7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Wed, 2 Nov 2022 08:45:28 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Wed, 2 Nov 2022 08:45:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9fcae5d-5a8a-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EmNpycgUSMz7k4dlAgPbjXqF9uwzDWdEUCEsZ0h5uLrPV7qJZe2juVvCMAqsfFIJ0kwG/ONeplzlJ1QfYwQRwk93cFkgxmyBlSKCY8E4yWcp5JNfZFez3T3uCkjIMrsduv9kmjdF6Z0J6YpQTr+w/DyXBnFxca258l4zqozInemeT3RrakFmScm+vcWEcD6NEPPbC4rTLGgzUBt0rbt0BSDo1Fm5a8ll8ITSGfHJbWfxOOma2OgHzvztS3S3XzJ+6oeMasHOcWDTQzsjASTwX7oM/nRDkngCrHgyokVtWbjYWlTcQhm2j5YwL3WjRnyTcX73hly8yDskQAvA7aQp2w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ty0weOIn68UPa9nzah4zlBMEZLNmB9bJfky6eEw+pIk=; b=Piht07stvcqdrD9RQ6vB3VQlmhNE2fB7gII9CowQ3L8lH9WbxKge6B73ue0C4ceoPJ2pMsZ6pY319Ac4FX8aQffqN1ugvhhHHwpbUW6hNA40+U6nfeyz+OiWVq/T/PCLgTQt0kB+zPJp7xZ4iprdMHuJk3H/mr5cVodaCrO8mfTxNS7/YDvxeFp1uLFaoq9lESXk63h+tfFkz/A2vaInPnkeJ1S2HxMYeofhrfZUs8Y6dMSW4VceqMLVypwDweOskmrKThMzU9lrNweFU5oZHkJfOlW0kJO4B3Z2FwwNhUyQzk8nx5lykdL7ztm0oMM4MUDJkNpBSmrLuRM3/wx3qg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ty0weOIn68UPa9nzah4zlBMEZLNmB9bJfky6eEw+pIk=; b=td8KJfZi2DfJMwnKPwvQfJrlXgdEjynBjCeC9aMqPg7vJqoQErOmdoz1FP8difycjOcHTpmHL5rpHxw7jMsJ/TkHcevDPdj4r32STj9nPKZrnF7qFadZ0FhXhn8ePJ2nelx1v+gfHYncIITRt6UmhWhk1XH0I4MaA/6TUjW5yng= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HM37Krn63HluQtVQcFf7O3bxx7nk5uK0k1Aa0VkJmLZH++X0JL0pEbu4YQRl+un2bj/8WorFQG4xQnfGBmaLHyOF5nmeaLlAqZMSU5pPAWaHLfbKQQHf6m1J2lTvdBav8IWFpEwAfobe1CmdocqJV2K7BgIGlG9JuXMj0JdOsDuuFMHXVT3m25hvq15ao+3bbZmjFnRzrVN8nchDj1Ctc9tNWKFf7JJ2RO4m6gCTbFXM2zRM9Uh/mur0AB9bQNVWcLdjc7eT9kVM1AZhJp9BVPDBVhbJknh2QpYkRRU5v6/vNPeV9vMdSEhUwTmJmTvqpYaXnGnoMiHew2bx1TKyRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ty0weOIn68UPa9nzah4zlBMEZLNmB9bJfky6eEw+pIk=; b=PdIee4Y+m5IAiRCzd/pE+NsyFSax7cJ3Wq75q9Jk15Y23jM5un5FXkiGtdxxVSdY8JFjr0+Dr1JfJuJKKnz3nMxsrfXwftcR5kAq+m9O4urmRCpxQuRWi0l4XMtp+DgDWyHRCl9Xf4bZxtmnZ/PEwjEbALZhe3OybQT/TdnoorY6Yv+oJup2RfJqtj5H77PPLbQ+7DZsKGJ/zs1AIVaSQUVPA1WvfS5i1swoOXG0hhlmLy3y0LTJ314MIQyhj7PXYxvDCSaWj4kmzma2MzMaWjD5EHq9Vb7ePOHMsSSWaIDnnxGnwBiWEylmXrKtKH0RtUuNrUzmsNp0HvUbmELwjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ty0weOIn68UPa9nzah4zlBMEZLNmB9bJfky6eEw+pIk=; b=td8KJfZi2DfJMwnKPwvQfJrlXgdEjynBjCeC9aMqPg7vJqoQErOmdoz1FP8difycjOcHTpmHL5rpHxw7jMsJ/TkHcevDPdj4r32STj9nPKZrnF7qFadZ0FhXhn8ePJ2nelx1v+gfHYncIITRt6UmhWhk1XH0I4MaA/6TUjW5yng= From: Henry Wang To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Andrew Cooper , Wei Liu Subject: RE: [PATCH for-4.17 v2 3/3] amd: remove VIRT_SC_MSR_HVM synthetic feature Thread-Topic: [PATCH for-4.17 v2 3/3] amd: remove VIRT_SC_MSR_HVM synthetic feature Thread-Index: AQHY6sNrNuecjAW2cEGLnlzFn4hq464rWUqg Date: Wed, 2 Nov 2022 08:45:28 +0000 Message-ID: References: <20221028114913.88921-1-roger.pau@citrix.com> <20221028114913.88921-4-roger.pau@citrix.com> In-Reply-To: <20221028114913.88921-4-roger.pau@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 79F55EAA85F08349B4952824A3A0FB55.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS1PR08MB7401:EE_|DBAEUR03FT040:EE_|GV2PR08MB9375:EE_ X-MS-Office365-Filtering-Correlation-Id: 631fc632-2e49-445e-2a60-08dabcae9d31 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9vta9AaamftE9Yfu+zZ306K4eqI0szjlS1qut6VI4rciYdXrnt8BOAdf4sWuF9+7U1rstZnhGrJBqDgH1Xxw5YMFV5KQSJvY1IHWdPuJFL5GnRITT8IAVAt6ZwBqqfoxg3MXaVevdKuXRa7rC+G/zLWiXrUcMIXyi6am0qyKAisr43RolDTTw6FxKKymZXMn+m6JllkvQohp8Olo71oXYP8T0jovGp09W8PehiyVOi0Gt7kuSoqlkkHmXcMbjJW62LT8JJ2EJoKgG852mB1gzBjPoAkR8iYd3gvqJDAlwSTiBu2j1MgxYVemQiHAj3cwkyo81RfwEAVjBZeTIBC4Y28VU5WsLhVKLKJrwgrRbec3ByPUSOLMAzCXQfoXJyXQs8YdL1+TmLXsCm9s4GGkAofIiLLy+Um5BdbGQfWEAtnUGkxTVL37JDSpVztlEhvH/GfgpT2LzIeTmauZHNbsQ9E6rZV3MIPJpCFYqMnZl8DZCf4N76iFvqjQNb2ATQUXckhzf15eaNKSDqDx8Hd6TApfhf9qJ50HXM4dvvi9caASnjLNduR5EOgBBBQMmEthcFA6kbWRwmGk1ZMhrSmgdVt6TMDjza/H3Wa22A0eJP8zkOG2j9WERm1FHACpxKYeXDwaO3tRXItPvbSghHBgHTAl2m4eaqvGmW1vZmz5RvQ2mX//UoFmkafONwVpc8+EgIgRW9PxX3wOpHF/nAeONv1QE23c00bTDrv6nBGzXt3gX2carSm0jM50OXEdEoAfeCkvKF/VH+b2I6FdSvzy9g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(366004)(396003)(136003)(451199015)(7696005)(33656002)(38070700005)(26005)(86362001)(9686003)(55016003)(8676002)(41300700001)(6506007)(4326008)(186003)(316002)(66476007)(4744005)(76116006)(52536014)(71200400001)(66446008)(478600001)(66946007)(110136005)(122000001)(54906003)(38100700002)(5660300002)(64756008)(83380400001)(8936002)(66556008)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7401 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9cdbf92a-93e4-41ca-5a39-08dabcae9810 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z82DDYe9elngju/WeM0kGn3sAYvzQX38w/QzCJwPldPKCZNuuo4KpwXv6J1on03hbwjX5ueMvNp0mGI51J45OdrV3AZWKoEaSQHSKvc9dO72LyoqucKdMoNy+iS5tc2TFOfB80pbeVCYoXGK0kN6D0FGKSUCSojprzHBHpFrZ8/vR3/88s14GcMCbJrQ4WN/ivAgci4uqA8zkJZzCvsVJ29rPrikFphGXFfiuzHHKCm1Gs2NLC9hiqIWdg3384l0ypej5LZ5HfatYOj6DSPaRgv6XfL82pqlfoWvNsiXYLDcoNOp7FrgH4d3EjVjxhzXQk+Kra/ps0VsGVBIgtVEE3bKooyTLhCR8s1umjMoMb4MRgUTlz+tIX7YMntSbwWFXFAgYS8logqL19Z2YasAKGkQy4yozW420vCiFj6oSInhUzCKaEeg12roEgv5LXOypVEGB07J20bzgDh5P+MAd4z0xcuJih+YNhyqmm1PSc3ClTDcK0KI8VdQ1Ej41T8e3n1WlFlIw1LqE0hm+lzpaoE9fm/CxbFmAqV+LA65RVuZtAvWoPUYXxojUdsInnAJ1tjM2EuRXrQoQ9UhiWVxFEhqtpdYSCJ5lUJ2aYB5CIobsuCKasKrfC6uUhRa5YKG77d7f4yTAXCbm+79kX7XeQgJm8WUT/Z9zq0IUu0F8dlLibk6MVS1Neuq5JyiI5pTFHLvyK1dcyJET+6Cw6/KvUST4V4c+2rPZSnMvjHBgJq9bBPOwZ+VhA1MmIq1Z60kERv2dP6K82zdVbaVFd0Zpg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(396003)(39860400002)(346002)(451199015)(46966006)(36840700001)(40470700004)(86362001)(33656002)(356005)(81166007)(82740400003)(186003)(47076005)(6506007)(40480700001)(55016003)(26005)(7696005)(9686003)(36860700001)(478600001)(40460700003)(54906003)(8936002)(83380400001)(336012)(82310400005)(2906002)(316002)(110136005)(52536014)(4744005)(70586007)(41300700001)(5660300002)(4326008)(70206006)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 08:45:37.3922 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 631fc632-2e49-445e-2a60-08dabcae9d31 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9375 SGkgUm9nZXIsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUm9nZXIg UGF1IE1vbm5lIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogW1BBVENIIGZvci00 LjE3IHYyIDMvM10gYW1kOiByZW1vdmUgVklSVF9TQ19NU1JfSFZNIHN5bnRoZXRpYw0KPiBmZWF0 dXJlDQo+IA0KPiBTaW5jZSB0aGUgVklSVF9TUEVDX0NUUkwuU1NCRCBzZWxlY3Rpb24gaXMgbm8g bG9uZ2VyIGNvbnRleHQgc3dpdGNoZWQNCj4gb24gdm17ZW50cnksZXhpdH0gdGhlcmUncyBubyBu ZWVkIHRvIHVzZSBhIHN5bnRoZXRpYyBmZWF0dXJlIGJpdCBmb3INCj4gaXQgYW55bW9yZS4NCj4g DQo+IFJlbW92ZSB0aGUgYml0IGFuZCBpbnN0ZWFkIHVzZSBhIGdsb2JhbCB2YXJpYWJsZS4NCj4g DQo+IE5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVkLg0KPiANCj4gU2lnbmVkLW9mZi1ieTog Um9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+IFJldmlld2VkLWJ5OiBK YW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNClNvcnJ5IGZvciB0aGUgbGF0ZSByZXNw b25zZS4NCg0KUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29t Pg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0K From xen-devel-bounces@lists.xenproject.org Wed Nov 02 08:46:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 08:46:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435640.689270 (Exim 4.92) (envelope-from ) id 1oq9O8-0005mp-Pd; Wed, 02 Nov 2022 08:46:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435640.689270; Wed, 02 Nov 2022 08:46:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9O8-0005mi-Ml; Wed, 02 Nov 2022 08:46:20 +0000 Received: by outflank-mailman (input) for mailman id 435640; Wed, 02 Nov 2022 08:46:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9O7-0005m3-Dy for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 08:46:19 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80040.outbound.protection.outlook.com [40.107.8.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d1203af1-5a8a-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 09:46:18 +0100 (CET) Received: from DB6P195CA0005.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::15) by PAXPR08MB7550.eurprd08.prod.outlook.com (2603:10a6:102:24d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Wed, 2 Nov 2022 08:46:15 +0000 Received: from DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::dc) by DB6P195CA0005.outlook.office365.com (2603:10a6:4:cb::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend Transport; Wed, 2 Nov 2022 08:46:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT063.mail.protection.outlook.com (100.127.142.255) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Wed, 2 Nov 2022 08:46:14 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Wed, 02 Nov 2022 08:46:14 +0000 Received: from f543fb238fa0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7BC1D5D9-64A2-4A3E-8312-97F211CB72BD.1; Wed, 02 Nov 2022 08:46:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f543fb238fa0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Nov 2022 08:46:08 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS1PR08MB7401.eurprd08.prod.outlook.com (2603:10a6:20b:4c7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Wed, 2 Nov 2022 08:46:06 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Wed, 2 Nov 2022 08:46:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1203af1-5a8a-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HSNZPpN1VdnEYAm+BhRBGF7q3mu3y8VEfpNvWG1gMBFfWDf258niWdY06qH8OIeqVyC4aC2k9nGhf1Lg2iUo0N0CkpGAPMeME0C5xobCvF+jgCy4lcJywQlNrRqBzuijg2ojhaKwW0N9X2G+jRr+9oaeYG0YShaGtTPoKodnk/sQdMA5Vjmp/6ukl+suFjuArJrDU416QibetB2iTrDZmOsgkSvbkvigkRM14nhU1slMm8My0DUPG/Dec5amPOt1EOdO8CWldS1zKW78LsUIguie2HCnFaXi5yLlOrMRICHJaLly/P/xpPmNwVtM39wvb/6X5kkztJu0VSa/ZDaSAw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VZAJMsg5VB2gzKE8hg7O1E/6R/0GVI0d5VUs9fDRXnI=; b=X4X4nqwBBMoQLIDjCrHhLGqbI1NK+VGJCp0riPU+Gxr1PcruVkJ8MHQ8qeZ0YM2t7e+soQvBj00jLjng6ATaY+xlXmtyZcNURKY9e+YYylUvKJNEtQJtA76GOxy4avlwOnn2F+9sx8rOSZ60ICFYYSPqx6vBhD+vM6Zk9Vb1m573S47chcS6V6gOQR86IcQhxp+zdtX6axgkLXI5OTV8VF2gW4dnJasc3yfHZjAhbSxPxsgokMY0t8JZaovAqfJJQXfcpItBxjhLtB+7qBDoXGWxiMX9RfonJuYNl8WxHRL9TqggutDGankxecpuvB2whpZs90BOuTA3kOu6keBDjQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VZAJMsg5VB2gzKE8hg7O1E/6R/0GVI0d5VUs9fDRXnI=; b=pgvzwZIInZ6w5putUy/6NKM56VgoR+K/RtcU3Dauxc3Kt4XcZ9LziowwxksBwBda/g0MQy4hBg9eYVDasMSLQ6gik8YMAcAONl+ULc/+7M8kqFXqAa1Jqz97OGuqpkS1KkrDJQ85ARKbv8KVzBJtMoT0pWVOSPzpKRZuZevxsnc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MTuycf9zzlbxqYTxQdkjOkm5i4oMStiO98sPjycXlUXD5PnjTlYaBWFhq+LgXkJuHB9KMm1kvOrxBVO3OO9vhex0ekul6+XXJjRRWkpVmlmjnF9/VfwkWvJ3XNipZWAr1WzHPfQZouu7QM2qOGKT4tRJ9SMymPu5wLJn2eBNzVFzwcCiPGQQYVqQmABgdWssADTfrktWA8fRa5yP3uUGOgXibZUWEBPI7S5Nv+b7wEeZ9zUf8B5A9ISRwPgLqQl+jic+5q7NJuf1SQixhR74kFx4wRLYeQzziLDfhrhnw31XYRHzfGvlK9eWp5Kv1bUG/8JqnWkkXTZmccx9VrNpzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VZAJMsg5VB2gzKE8hg7O1E/6R/0GVI0d5VUs9fDRXnI=; b=aAIsiGWKGPPPmPf858ZzOuVatVo6Iu4WLwY0d+i9pttOwsgrlsxELK1Tdc123hgg3+WJUqI+bNjvS6ytqqJWjA5RDpA51sDPpbIT0OLtiDL1ofrA546dlXggQT5nv97MrXu0OHiqxFY7rEc0DIjK/5t/D77UfV/VcSj8MGGbyVigrIqIjdnqomfVh67pdoMJTv3sr63KckBULvV8iQ7zFp2Mo8nJd4KUL6yYIfhARO4a4kwf79onRf6gCn75LsuDwlVFS1MZXjPaNnp3PcjVJjJNMCeKkVj7O+UEjsWCZgQ4eMWnKlKsBVa7fnI0SjMHoXi9zpNel3C9lCoPpJnqqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VZAJMsg5VB2gzKE8hg7O1E/6R/0GVI0d5VUs9fDRXnI=; b=pgvzwZIInZ6w5putUy/6NKM56VgoR+K/RtcU3Dauxc3Kt4XcZ9LziowwxksBwBda/g0MQy4hBg9eYVDasMSLQ6gik8YMAcAONl+ULc/+7M8kqFXqAa1Jqz97OGuqpkS1KkrDJQ85ARKbv8KVzBJtMoT0pWVOSPzpKRZuZevxsnc= From: Henry Wang To: Jan Beulich , Roger Pau Monne CC: Andrew Cooper , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH for-4.17 v2 1/3] hvm/msr: load VIRT_SPEC_CTRL Thread-Topic: [PATCH for-4.17 v2 1/3] hvm/msr: load VIRT_SPEC_CTRL Thread-Index: AQHY6sNlCXMYVGLn/0u9RJaApMVaua4otHcAgAKk/kA= Date: Wed, 2 Nov 2022 08:46:06 +0000 Message-ID: References: <20221028114913.88921-1-roger.pau@citrix.com> <20221028114913.88921-2-roger.pau@citrix.com> <2d1f7271-1399-f5ea-9519-9db4e4ca3de0@suse.com> In-Reply-To: <2d1f7271-1399-f5ea-9519-9db4e4ca3de0@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8ABE42886634D04EAFB65A7C1EE184ED.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS1PR08MB7401:EE_|DBAEUR03FT063:EE_|PAXPR08MB7550:EE_ X-MS-Office365-Filtering-Correlation-Id: f3557d03-2036-45c7-083a-08dabcaeb37a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9vYMuM0lCAXB0IQTv1lLN6NsF+R4o4zKT77cYdxn3AZRVXVsN88S3Z9MvUaSRdaYfXQ+u3kwEssDW9Mo8HCiouRyPcJCRq15bbOkQ+pasCVzV9Aq+m6SHQ0WjH/UV2Ehf4PllVyugs7yGrLYQbXoJw38Xl3TOrDlpYEEnth29aR/OZuvjs2MPXUtjKrDzc3qGLm75Nww37aqkT7141H5A2vrRZ58NvNtsoMQaPn2v8dRsb53ZDL4CcT9ktB9TCvk5XP2+dcyHBFjmaQIW9SztZHiUMNDhVLZ/hFvt64jamCSzzvNWdnjSMvCtj2bzKs+Ds2dv7THeyd5/Et5kPD40/hh2fCv+d2g+12NF9R6/VA1IneVKoxx8ijGGSIPJUXm42S1Bw+0QdUBfS8h4W1v28eNm7kK1CyYJyafbTnNHDwJMEi+BfJnhYqtz9LCKfQfbpwvazBs3EObgYe3saUhwDc2085Il7RLZwkkFGdAWrRMcCPh/4Cq6OzpgVwodplzIBIPJp8bX1Z4rzyc3eBT8u6eXGFIzvQ9nut15NHka1YhufGwWQynd75zDWERgewAhZJzQk9IwPMWQWDxZD133VItdOBCrYhErra8csd/LQhei+ZWlp0Q1O+9sqbIWwO9SqgHnxGjEPo+1VBQF9AaBv4zAW1sgxYamwvAtTmIKZrfVuG+UaZncjsCU0QDRWRRGjhz4/Gn0RdhT7LyzHrwhUERcp/HPoTOgNLUA6/bkyTd1VQr98ExBQIjIoe+YysAyf8hRvw0KBpvu1/ULZNuZQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(366004)(396003)(136003)(451199015)(7696005)(33656002)(38070700005)(26005)(86362001)(9686003)(53546011)(55016003)(8676002)(41300700001)(6506007)(4326008)(186003)(316002)(66476007)(4744005)(76116006)(52536014)(71200400001)(66446008)(478600001)(66946007)(110136005)(122000001)(54906003)(38100700002)(5660300002)(64756008)(83380400001)(8936002)(66556008)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7401 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 678e44e4-7829-4418-05cf-08dabcaeaec9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mvHkzj2J3yUJmIiSDVJ09e10Gkq3yKa+ueo/LLsAI1bM7N+nY71jSLBbPzD3rgVgfj8B9XdwbQyj32BTldigc0EL7gLD7fRcxIGOfiX1FeE77e27SFBrkR6mbejaqXwrB6yHHVr2i9+OZosrU/c59GqrYxnK1uzHZKaImJdxO2agEXS8uvJBL2GqNALswlN300nOqV9tJPUJdbHMLlUcu75B0/tbUpbUBfKgYNIt26Jh6EY58qBX16xF2c42kPNh1PCN4Xdu2vVQwJWxiKJL365y7X726DQvdhpITC0yYQp+iVVh+RA5g0Kds9Y5WB6/tGFJvLAU3m5zMFgqLP6+lCwwycbqWZe2L2emJudAvVNYc41ssIc8V/svi+1XGQ5oCcPl+cBwCFpEbrtkNzp9Jt5+kNRNwXR+uqwG1+Yh4NICSxvw+WcJBzcXTv7U8NW7EbWC2tgaTYTR53uTY11U7P8DDpm8HZuF+l+5jc1i/384EMCUYpdTds4WGCW8gCX5Bwt18v46Jf7tVfMu6XsKJImSR6vTNJtYLh3Bd8lb17/cIQ2lTTfxfHXilcjJoWvEj80LTGkqsUaa3PoffWjYc9SJE6AYgy5Jlevs+pIJz3PPGl42fGK+IHPak4cvg+MmHAX+cKCg3OwKFQPEVxHWcuoNUx7Q5lGS/FPVf9aj/1DiSZ3X/bVtLrJxrSIdZpcXlgrHU9cKY2YctICw4gFmTbq3R1/UH7CHhHgQ+x0mvxr16wEp8L4HykxxhxWt6y3sPA1KFW7mEI7vIDmmS05tmw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(346002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(47076005)(86362001)(83380400001)(33656002)(356005)(82740400003)(4744005)(5660300002)(2906002)(70206006)(70586007)(8936002)(52536014)(41300700001)(36860700001)(7696005)(81166007)(4326008)(6506007)(53546011)(82310400005)(40460700003)(336012)(186003)(9686003)(26005)(316002)(54906003)(8676002)(478600001)(55016003)(40480700001)(110136005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 08:46:14.7640 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3557d03-2036-45c7-083a-08dabcaeb37a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7550 SGkgYm90aCwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKYW4gQmV1 bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggZm9yLTQuMTcg djIgMS8zXSBodm0vbXNyOiBsb2FkIFZJUlRfU1BFQ19DVFJMDQo+IA0KPiBPbiAyOC4xMC4yMDIy IDEzOjQ5LCBSb2dlciBQYXUgTW9ubmUgd3JvdGU6DQo+ID4gQWRkIE1TUl9WSVJUX1NQRUNfQ1RS TCB0byB0aGUgbGlzdCBvZiBNU1JzIGhhbmRsZWQgYnkNCj4gPiBodm1fbG9hZF9jcHVfbXNycygp LCBvciBlbHNlIGl0IHdvdWxkIGJlIGxvc3QuDQo+ID4NCj4gPiBGaXhlczogOGZmZDU0OTZmNCAo J2FtZC9tc3I6IGltcGxlbWVudCBWSVJUX1NQRUNfQ1RSTCBmb3IgSFZNIGd1ZXN0cw0KPiBvbiB0 b3Agb2YgU1BFQ19DVFJMJykNCj4gPiBTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxy b2dlci5wYXVAY2l0cml4LmNvbT4NCj4gDQo+IFJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJl dWxpY2hAc3VzZS5jb20+DQoNClNvcnJ5IGZvciB0aGUgbGF0ZSByZXBseS4NCg0KUmVsZWFzZS1h Y2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KDQpLaW5kIHJlZ2FyZHMs DQpIZW5yeQ0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 02 08:46:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 08:46:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435641.689281 (Exim 4.92) (envelope-from ) id 1oq9OF-00065V-7q; Wed, 02 Nov 2022 08:46:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435641.689281; Wed, 02 Nov 2022 08:46:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9OF-00065O-3T; Wed, 02 Nov 2022 08:46:27 +0000 Received: by outflank-mailman (input) for mailman id 435641; Wed, 02 Nov 2022 08:46:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9OE-00064w-6n for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 08:46:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9OD-0005cu-O6; Wed, 02 Nov 2022 08:46:25 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.26.173]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oq9OD-0007u5-HJ; Wed, 02 Nov 2022 08:46:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Z2WmQRsotChnU/nRWRYRy7OWhReR/3JRoqgEymUUs6M=; b=I+WKVu6Bag8iSZewQN4afW/DJZ XOdGlSRIFAkzG+6IF7DAtuHAnTJo6DcUGRrni6bZIo68ggM8MusYQUqfmk3xqlkDjJZAwuCRJXwVj Uc6ti9wY3P4Qvtg+PBsai2zB3VCWRVhJcHHpgnsG0k9bsKVBrlAuXeu6fXGbgkjPeglE=; Message-ID: Date: Wed, 2 Nov 2022 08:46:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 02/12] xen/Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32 Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-3-ayankuma@amd.com> From: Julien Grall In-Reply-To: <20221031151326.22634-3-ayankuma@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Title: The macros you are moving are not GICv3 specific. On 31/10/2022 15:13, Ayan Kumar Halder wrote: > Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm64/ \ > include/asm/cputype.h#L14 , for the macros specific for arm64. > > Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm/include/ \ > asm/cputype.h#L54 , for the macros specific for arm32. > > MPIDR_LEVEL_SHIFT() differs between 64 and 32 bit. > For 64 bit :- > > aff_lev3 aff_lev2 aff_lev1 aff_lev0 > |________|________|________|________|________| > 40 32 24 16 8 0 > > For 32 bit :- > > aff_lev3 aff_lev2 aff_lev1 aff_lev0 > |________|________|________|________| > 32 24 16 8 0 As discussed with Michal, AFF3 doesn't exist for 32-bit. So it is not clear to me what we are gaining by moving the macros. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 02 08:51:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 08:51:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435655.689303 (Exim 4.92) (envelope-from ) id 1oq9Sx-0008B5-1S; Wed, 02 Nov 2022 08:51:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435655.689303; Wed, 02 Nov 2022 08:51:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9Sw-0008Ay-Ti; Wed, 02 Nov 2022 08:51:18 +0000 Received: by outflank-mailman (input) for mailman id 435655; Wed, 02 Nov 2022 08:51:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9Sv-0007x0-Bi for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 08:51:17 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2065.outbound.protection.outlook.com [40.107.103.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 83009dea-5a8b-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 09:51:16 +0100 (CET) Received: from AM6P191CA0037.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::14) by VI1PR08MB10274.eurprd08.prod.outlook.com (2603:10a6:800:1be::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Wed, 2 Nov 2022 08:51:12 +0000 Received: from VI1EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::ab) by AM6P191CA0037.outlook.office365.com (2603:10a6:209:7f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21 via Frontend Transport; Wed, 2 Nov 2022 08:51:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT025.mail.protection.outlook.com (100.127.144.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Wed, 2 Nov 2022 08:51:11 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Wed, 02 Nov 2022 08:51:11 +0000 Received: from a267608a2105.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3392C4CA-8120-4494-9F21-BC11913C240D.1; Wed, 02 Nov 2022 08:51:01 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a267608a2105.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Nov 2022 08:51:01 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV1PR08MB7707.eurprd08.prod.outlook.com (2603:10a6:150:52::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Wed, 2 Nov 2022 08:50:58 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 08:50:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83009dea-5a8b-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Zip11gxD7FZb1ITly/xi/OtyTlNr7/alm08iTAM30sTSadV85RSU0BDEjrwcpZEyQN1K+LKT7M94sKg/ZscY84d7BzLqCr/1UumVpfRl/HebBWbwhPqP7i/a7OsTy9bn0PdJpyrxC0gxEor5eAEtPR5eOXhMxXDLizb6TWoyZ1Na3zdPbNAak/u0gdtt6HSCGmvIqcMgzXFo84Z3A8vIFHUkSEuV8RxgoJJrvXW0GfUIKnqy45oafHeEx93n8r4Xhwm/WmsxW829AZpsOSq2eFVYOHcLm0AWcjP2lLkVV641muC7QhGgAIKgx87QNg1RawQlUd3Zx1/sysLJT6X3LA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v35/mGrKtMar9Hx6IpTQx3/+KlpCVHSkPX70F4d5i8g=; b=nQufWMDvh37iXEXSs9WgGBfRHGVJ8s3UGGHsBQXw/ixLrr0n1IiyWwLn8NfZSWKUWimHx4G8MjsIsSCPriz1gbfNhKhBE1KgzYsI6sfPQAXn9u9FAppyBorMzQQmEI4mKQsBkfvp2p0Yjkxi18VmVxE5dYngBoT2ETzlJBYeEcaO8IfGwATeE5Yp5Rs8IUKY2Q0TgSn8uv5Y/wMDWyI4qyTDzaacZrofr1t8MLephycnfxloTirBP+qtHRH/MECn7WYBMhmWmWeaJnY5GCpkarkDZs91dgq15mQk5txfmkGdacMV9QpPewMUhMPY3X6kVZ+pyj5bcq7bWbAZ8wUAqA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v35/mGrKtMar9Hx6IpTQx3/+KlpCVHSkPX70F4d5i8g=; b=3JI7TgDWuLLxqCX5OetXO+XY36RAAQb6kJHzw5ITUPV6w3NoP9RWXtw4zkUcM566YFeOZBZ16t6UOk2Z+XcNezbszLuMCnjT5pCzYhu01FXW0ua5zWwdbcQGDtUadXW1+SOBI1s0CCFdvcut+i6Dh6Uty02k5pGxXREgPXhgfIk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 352bfb693f8e33c3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=krW6P3SVVFv/inosnx2QeIXLEpNYbl1+AaGPBYqos1Q/dZqld33HKEGyW/POKpBfU9weu5ob8skEQxivzbTvPLakLSqCWPR8EuWVzNqkblhjSeElm4p/AJ+gHHqd9DC3EeBNIwTCIhH/i/MIKLXDPLYyI6SPQ6XBRHK1De8eQh1FbEEZ+FAIgwWRz23Gfkuec5yVv/lbx4eElquBFIu/56ZcBlynTDESJUtmMw4RrfZrQYYMERY4t1+ailnzv3ux5tVP95LNAAlSI0i1qSrtbrRTyEzwcKjVVWYYmuEVmJI/2Qk7IIr/GWmqH4Dp/JxyZQTRePVnl62EecbPyOQhug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v35/mGrKtMar9Hx6IpTQx3/+KlpCVHSkPX70F4d5i8g=; b=JcflzCNPeR9uBWxDtgaaQ+9IGVpU9uM6I3FWE+NoYuYEZIzQLmw9jiHGyFoqmvB4TMPt5zKc4KgLG2rVMFEjnvzZRyFhhfcSH6/I+pwlQQa1e0y5OVKt6ST2eRrhgpEHQtD2m7BwxznQrSXDfiGb8zDNeRlZHP+oy/BLWnvXKLqHzys2KS4yWc2l5RktVxpvDsqQU8yhBfnA56OKCkBOJpjDVxOhO0IKOsyr8l0lezaIs6brns+iCg2wY9Rc6ersFK7KakQ/Skf13MapGe2tDmMzZQ2lU1wjiMAJ15wr2IziSzo6bqQO585V5X7SiAhi8+1EbbRA2rPmMAdymmEsOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v35/mGrKtMar9Hx6IpTQx3/+KlpCVHSkPX70F4d5i8g=; b=3JI7TgDWuLLxqCX5OetXO+XY36RAAQb6kJHzw5ITUPV6w3NoP9RWXtw4zkUcM566YFeOZBZ16t6UOk2Z+XcNezbszLuMCnjT5pCzYhu01FXW0ua5zWwdbcQGDtUadXW1+SOBI1s0CCFdvcut+i6Dh6Uty02k5pGxXREgPXhgfIk= From: Bertrand Marquis To: Elliott Mitchell CC: Stefano Stabellini , Julien Grall , Rahul Singh , Xen developer discussion , Michal Orzel , Oleksandr Tyshchenko , Oleksandr Andrushchenko , Volodymyr Babchuk , Jan Beulich , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Andrew Cooper , Juergen Gross Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices Thread-Topic: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices Thread-Index: AQHY6T1V+gcJbmRqpEyt0b8GeG9bFq4grXIAgAAQCACAAFf9AIABVMyAgAAG64CAAVVJgIAAAzuAgAACBwCAAAPNgIADNHqAgABdGACAABWOgIABD7SAgAGs8ICAABi+AIAAQbAAgADQQAA= Date: Wed, 2 Nov 2022 08:50:58 +0000 Message-ID: References: <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com> <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com> <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org> <82c45bc1-6052-502b-3007-8a16fbd1d433@xen.org> <9F323893-B1C9-4D31-9A40-213345421860@arm.com> <947E315E-6537-48DC-8AC6-5218C12B604C@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|GV1PR08MB7707:EE_|VI1EUR03FT025:EE_|VI1PR08MB10274:EE_ X-MS-Office365-Filtering-Correlation-Id: 64fc4393-b619-4dfa-ceee-08dabcaf6494 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IJjLTn6Q6QffLaRj8YL7C2nnN2somiz4Pw0snp535zObT6TDet6W3mJ8aHsRQpFCWSpq3/XimZC/jLRmPsRq9M1cvDfx4jNDUSv/06ujHSAZMtiOQ6KTbUqdxSjNKWO/hWs/RcBCi1VPRemErplMxDbzRIpHZW/0WJm6MVzhwP+kvu7NcjQNd7zXh8uaK+PoBa90KYvRYHGOfvrUF/QnMB1xjkh4ZN8zU94Sm291tSKjD+RJ6HQO8EWYIKpZBGbmZwH1ekdzpgZtgB3ZgUHNqIh+L/AcfPdWrLQJfNTPLmRl/MsiZ1I02oDd/cQ0pwIv4e3dnsbzRssRw1UvzhZpGB7taKiglGpvUC5AhNzarUQtyIIt/tSbj7Ft0Oud1sI1FKe/PCflDdQFoXYrArZxxymh2Jh2p7lhKRjB07pZy8dLPw3QbjaIPhP2JL33iZYSGv4qHNxnxLPIHCJyw6q6D0muil7jqKweioAlvUfLXRQD7wVIvRphMI/w4DcfdPuRixL4vaCv7a+WpKmY9/czE2IjoGJcEHMeyxqgl/DlN3y80tIGxd98PVE0cGRjMWM5A24mTWGO9ZYttuO4zV9ZR/t3XECb1eaK5FvASSXY0LmN0pTMJsuZnYeZM+ZcLfz+vtV6JRYnStAnK+p+v/AXsUIW6hlMtkJsM9CuJl0ttlRGD4l/L11E+srmPmxlZuQyyBp24QSXu6Smi8mIk4cbxkNpKGOR63P+JaMs0mKo2K/zl8Z/m3vW63/6G10Xn+decVhaauhClS8epgpnjXlmJWs+R56BOwl4Nyk/AIR9Gf4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(346002)(39860400002)(366004)(451199015)(2906002)(66899015)(36756003)(5660300002)(7416002)(83380400001)(186003)(66446008)(64756008)(41300700001)(66556008)(8936002)(66476007)(33656002)(8676002)(91956017)(38070700005)(76116006)(54906003)(478600001)(4326008)(316002)(2616005)(86362001)(66946007)(6486002)(6506007)(71200400001)(122000001)(6512007)(38100700002)(26005)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7707 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1f6e2309-46e9-4977-a520-08dabcaf5c83 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YTgZmq6fCkjONZJZ+md1yR2tSx7R4lhFxhmE7kL1KLryADYfzMj0pC1cjGE2iD2ZfiE1VxO2NF4uCCzWltztmug1cXHrmPvMRTDqmGACgzh8K/WRzpLmIpQcSuQLyu5P9z1XR31zQiiYhN5GfQ5HzgjPS6eEHPFcEYrg2I3CYBqWeRy9Oax+sbh/WyRwEfqFWgzg+sk43o/zf9NGf0BRtun2OrScISWAHUwrxSrY+qqU7/uYxGL/2hXMwkUZYkyQobi9vUqoL3hovLahphWnYFfDlODXQaCGeBkdgBOJ+IZFJSJyAVQ2ctM4mSYWxzojMFGi9SPBlZtkR3hEWg0IXi8CZ2vlr/826/KiaYjOFueAHPBYQAzcPwoQNNwk0WVv2mfaDMvI3no5T2ZRkBdo36bocirDK0jyuHEym3pZnECMibo9h5X0dnGnymNvpVBhts4FCVPR3KGeFUGDTkMnkNgjzuRE2luLZS2h64n5nvgFPcAFWrVV/uEe8SmYRyCVmgBwbsdr64bRu4Oaj3lBKxXpFJGki2GSCIlq8Et8sHRfT7lApG+AVj3ZpQKxbCEZP5G14KnHHEd++qdILK7CFramrmGbpxlOoqDIyPvJ6D++TLQLf4/rfnh1eOScC6CM643iu/YqVWRQ18e9kVmkSNFmyL4mwe4mBYwdw1Keua9kpb/WaR59aJ4LkpNzulE9TaQ2ntqSVsgxyD1wfTqvwLKaOxhkLBQ+YYE91c3aIAohq8wD2trqI8mBKF1n9ZdO0zW8RqWQUFqNZ00tDJASzg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(376002)(346002)(451199015)(40470700004)(36840700001)(46966006)(83380400001)(336012)(47076005)(66899015)(86362001)(40480700001)(6486002)(33656002)(2906002)(107886003)(82740400003)(356005)(81166007)(40460700003)(8676002)(36860700001)(6512007)(53546011)(26005)(6506007)(186003)(2616005)(36756003)(82310400005)(6862004)(70586007)(8936002)(4326008)(54906003)(316002)(41300700001)(70206006)(5660300002)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 08:51:11.8025 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 64fc4393-b619-4dfa-ceee-08dabcaf6494 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB10274 Hi Elliott, > On 1 Nov 2022, at 20:25, Elliott Mitchell wrote: >=20 > On Tue, Nov 01, 2022 at 04:30:31PM +0000, Bertrand Marquis wrote: >>=20 >>> On 1 Nov 2022, at 15:01, Elliott Mitchell wrote: >>>=20 >>> On Mon, Oct 31, 2022 at 01:26:44PM +0000, Bertrand Marquis wrote: >>>>=20 >>>>> On 30 Oct 2022, at 21:14, Stefano Stabellini = wrote: >>>>>=20 >>>>> Ideally this would be something quick that can be easily invoked as t= he >>>>> first step of an external third-party build process. >>>>=20 >>>> I think that we are making this problem a lot to complex and I am not = sure >>>> that all this complexity is required. >>>=20 >>> Speaking of complexity. Is it just me or does a vIOMMU had an odd sort >>> of similarity with a Grant Table? >>>=20 >>> Both are about allowing foreign entities access to portions of the >>> current domain's memory. Just in the case of a Grant Table the entity >>> happens to be another domain, whereas for a vIOMMU it is a hardware >>> device. >>>=20 >>> Perhaps some functionality could be shared between the two? Perhaps >>> this is something for the designer of the next version of IOMMU to thin= k >>> about? (or perhaps I'm off the deep end and bringing in a silly idea) >>=20 >> I am not quite sure what you mean here. >>=20 >> The IOMMU is something not Xen specific. Linux is using it to restrict t= he area >> of memory accessible to a device using its DMA engine. Here we just try = to give >> the same possibility when running on top Xen in a transparent way so tha= t the >> Linux (or an other guest) can continue to do the same even if it is runn= ing on >> top of Xen. >> In practice, the guest is not telling us what it does, we just get the p= ointer to the >> first level of page table and we write it in the hardware which is doing= the rest. >> We need to have a vIOMMU because we need to make sure the guest is only >> doing this for devices assigned to him and that it is not modifying the = second >> level of page tables which is used by Xen to make sure that only the mem= ory >> from the guest is accessible using the DMA engine.=20 >>=20 >> So I am not exactly seeing the common part with grant tables here. >=20 > With Grant Tables, one domain is allocating pages and then allowing > another domain to read and potentially write to them. What is being > given to Xen is the tuple of page address and other domain. With the IOMMU we do not get to that information, we only get the first lev= el of page table pointer and the hardware is doing the rest, protecting the acces= s using the second level of page tables handled by Xen. >=20 > With the model presently being discussed you would have a vIOMMU for each > other domain. The the pages access is being granted to are the pages > being entered into the vIOMMU page table. Which Xen does not check. >=20 > Allocate a domain Id to each IOMMU domain and this very much seems quite > similar to Xen's grant tables. I'm unsure the two can be unified, but > they appear to have many common aspects. >From an high level point of view it might but from the guest point of view = the IOMMU is something used with or without Xen where grant tables are very specific to Xen. I do not see anything that could be unified there. Maybe I am missing something here that other could see though :-) Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Wed Nov 02 08:51:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 08:51:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435654.689292 (Exim 4.92) (envelope-from ) id 1oq9Su-0007vQ-P5; Wed, 02 Nov 2022 08:51:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435654.689292; Wed, 02 Nov 2022 08:51:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9Su-0007vJ-MP; Wed, 02 Nov 2022 08:51:16 +0000 Received: by outflank-mailman (input) for mailman id 435654; Wed, 02 Nov 2022 08:51:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9St-0007vD-2O for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 08:51:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9Ss-0005ia-JZ; Wed, 02 Nov 2022 08:51:14 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.26.173]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oq9Ss-0007ye-DA; Wed, 02 Nov 2022 08:51:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=JckvhBMCGPKMErj4nJrjlog/hoTr01oVAsdjkU8D5Dc=; b=4X0ij574xV2FpI/+vScY+OqTKr 3SxpOFnTlM+fuIkxSVBcAau2tCM1Gz30mE8EfbV2nyPJpa+LXbUMqpQ7Wdb8vfdLqWpbMQcRkL/96 dgl9Abg6FijVF7o+r1dS7KvbdsK+XjokCmED2ZrKXhKrZ3X2nz4IvM+U3t2uxB//J3UI=; Message-ID: Date: Wed, 2 Nov 2022 08:51:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 01/12] xen/Arm: vGICv3: Sysreg emulation is applicable for Aarch64 only Content-Language: en-US To: Michal Orzel , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-2-ayankuma@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31/10/2022 17:43, Michal Orzel wrote: > Hi Ayan, > > On 31/10/2022 16:13, Ayan Kumar Halder wrote: >> >> >> Refer ARM DDI 0487G.b ID072021, EC==0b011000 is supported for Aarch64 state > > I think when adding new code we should be taking the latest spec (which is I.a) as a base + > you are lacking the information \wrt page number, table, whatever contains this information > within ARM ARM. +1. > > Apart from that, wouldn't it be easier for those reading the commit to just write e.g.: > "Sysreg emulation is 64-bit specific, so guard the calls to vgic_v3_emulate_sysreg > as well as the function itself with #ifdef CONFIG_ARM_64." This read better. What matter is the emulation is 64-bit specific, not that the EC doesn't exist on 32-bit (BTW, in theory 32-bit could have re-used it for a different purpose...). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 02 08:52:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 08:52:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435662.689314 (Exim 4.92) (envelope-from ) id 1oq9U7-0000bI-DH; Wed, 02 Nov 2022 08:52:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435662.689314; Wed, 02 Nov 2022 08:52:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9U7-0000bB-9C; Wed, 02 Nov 2022 08:52:31 +0000 Received: by outflank-mailman (input) for mailman id 435662; Wed, 02 Nov 2022 08:52:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9U5-0000b1-K5 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 08:52:29 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2087.outbound.protection.outlook.com [40.107.101.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id abb4a283-5a8b-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 09:52:27 +0100 (CET) Received: from DM6PR02CA0097.namprd02.prod.outlook.com (2603:10b6:5:1f4::38) by SJ0PR12MB5609.namprd12.prod.outlook.com (2603:10b6:a03:42c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Wed, 2 Nov 2022 08:52:22 +0000 Received: from DM6NAM11FT082.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1f4:cafe::40) by DM6PR02CA0097.outlook.office365.com (2603:10b6:5:1f4::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21 via Frontend Transport; Wed, 2 Nov 2022 08:52:21 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT082.mail.protection.outlook.com (10.13.173.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Wed, 2 Nov 2022 08:52:21 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 2 Nov 2022 03:52:19 -0500 Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Wed, 2 Nov 2022 03:52:18 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abb4a283-5a8b-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=esEuTEJp4PkZS3hUvY/RaaVcaUGd3OZJHgebkNeJVqj715FUQHDvyhsB9l8NMj4BXi1ikWlJTsYfCZVHjuUBnfhTb2ealo3GkP6mZvsKjwhI5rDfIlThi7UnPWPh2WoRScHGScePfOIrdi+0UvZ+0/2L/u1gRRSyVdW5C/U163df7rZRX23oExVg9DcA8K6LldEDuVJOvxc8QdTrAYzvvm49Q6akdopuo2JTznV8mE8NELGevQRBSqxVrsxl5Gmb0897lVIO5gG0pc+SvZ/IEsJ737VkpL1sfG2H/vhDhoaddtXcVTgNCTqzS/ORD9nFjO+N5kfHZiP0MkLbY6C2kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X/jLUbXTFMMm9MS2oC3GDrF/cplqLRXe+DAHKVZ9w/U=; b=jyeMIiFCWBSEcwFJLgvn6gx+AXI41IiweB2TDDMaznPDs00JsgM3lTIR2JJn54Y5nSZECOGMu0EnrNNLF4awEd2jbyrknW/i2heAoCdJUXWF48F3Sb8dkYRS1C1tbDAVRN+xt9luXtClEGwVJDgbnM4GC7b6yEfcH3bhiq+jeYprit8pZQ7rUK5PaCO5wle7t/rDs2kaVqho8eeeQZlJfGsP8mhaaGr59224JiiA3evvSqKcuETp90eVQQWEZ2VbeGNi7+0dZD54ejKVuwejseuEqBUAK3pTTObtP/KaIKcX5VJEpwIBoxDe3znLh2H9mZ7ZVHKvwkzpukdrhmdbSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X/jLUbXTFMMm9MS2oC3GDrF/cplqLRXe+DAHKVZ9w/U=; b=3dbBNZwVMcdBx3NqC+LsinW1pyAwAsxQ8yTyVzziTa2HjRmDb/XBvwDKpk7HMmJOgsIzdM4nlLXuCKOrQqn7OZ1OPr9E5RKiaewHiKug73Hf8S8V92VX1DypqpsLYtuiBNaCUcvFjl5l336sSGoIMSqRM7WiJKB7JHu/vPw1jqs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Wed, 2 Nov 2022 09:52:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 03/12] xen/Arm: vreg: Support vreg_reg64_* helpers on Aarch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-4-ayankuma@amd.com> From: Michal Orzel In-Reply-To: <20221031151326.22634-4-ayankuma@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT082:EE_|SJ0PR12MB5609:EE_ X-MS-Office365-Filtering-Correlation-Id: 36c40938-b95f-4e6a-4da9-08dabcaf8df0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mhumzKm6F3uAw4iq2z7T8kTzwwGRuUOREaCtbUVRxT6keERIVSsIy2X/d3fjsHco+SWx/FiJV2PdwKw+ZOqa3zRQlptQ6JTNJA/X2B74aQdFdKz6iSqlKOkbqKcwLpZfx9QYrtZ38l7ew3jT3ITzxp1HfOZBlmTI2aWBp5Bs1BT89SW8dLO3KQyy73JK0DvhuHT6HE4htM+ynA4QltAkIud/sM453EI6Rlexj2nsYDt1ulI9ib9UO41TFxoxP7sl2ptbga1ri8PhbiYOMVo5ZzHliML2Cjuwm+T59ZY0f4BDpwFCXQ7tW3AcYNYfAOZFtkQwBlD6rtTIk5+ZbaW3/FMdqPbxZmsVAw/cyzrFJI5dlFjFqaFvYx+p8yN5te2iHjE9jIxz1fPXpMGpJ2HVb4vO2s8vO7EdH9X7wqj0CqC1BKu/AQ7eXN07tzOEmsSO0MQErbpLADD/TuJtJHRfJR32yd2P0t2M0IIDJch40VtB/wq8tb4qUvzQUQHAKBpa2FQuPpY4CQA/H+I2/ihv+qPCLnGbwcky03Pvb7fGy4uF+UtgJ/JDCI3lC9pjiqKc5poWzV6kfw/SGHi1njMYPll9DK9WU09oYhiyubcRKQgOr6EibUPLk49wLxSVfjckJepCuyjJcLUAMSA6Tgo5jOqVl69gnCBQuZY191q/T48U6XAptFO9/W/98eBwGKUrKFuBfQV7/eXjREaSFyXkx6+7Sj4gMqzPOGp7n7jt4IczSsAxGUaoe12y5cC0uRhAf/VJ/Lo8YBWqsLORz5B947tgr+Mih55pnKbClZSDf8DH6tEk/CovZbL9b1SmBRoDidn61QJYI1EcDA3jDN5IFg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(376002)(39860400002)(136003)(451199015)(46966006)(40470700004)(36840700001)(83380400001)(426003)(336012)(47076005)(31686004)(86362001)(316002)(44832011)(31696002)(40480700001)(2906002)(356005)(82740400003)(36756003)(81166007)(478600001)(40460700003)(53546011)(82310400005)(186003)(26005)(2616005)(36860700001)(8936002)(41300700001)(8676002)(16576012)(54906003)(70206006)(4326008)(70586007)(110136005)(5660300002)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 08:52:21.2356 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 36c40938-b95f-4e6a-4da9-08dabcaf8df0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT082.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5609 Hi Ayan, On 31/10/2022 16:13, Ayan Kumar Halder wrote: > > > In some situations (eg GICR_TYPER), the hypervior may need to emulate > 64bit registers in aarch32 mode. In such situations, the hypervisor may > need to read/modify the lower or upper 32 bits of the 64 bit register. > > In aarch32, 'unsigned long' is 32 bits. Thus, we cannot use it for 64 bit > registers. > > The correct approach is to typecast 'mask' based on the size of register access > (ie uint32_t or uint64_t) instead of using 'unsigned long' as it will not > generate the correct mask for the upper 32 bits of a 64 bit register. > Also, 'val' needs to be typecasted so that it can correctly update the upper/ > lower 32 bits of a 64 bit register. > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from :- > v1 - 1. Remove vreg_reg_extract(), vreg_reg_update(), vreg_reg_setbits() and > vreg_reg_clearbits(). Moved the implementation to vreg_reg##sz##_*. > 'mask' and 'val' is now using uint##sz##_t. > > xen/arch/arm/include/asm/vreg.h | 88 ++++++++------------------------- > 1 file changed, 20 insertions(+), 68 deletions(-) > > diff --git a/xen/arch/arm/include/asm/vreg.h b/xen/arch/arm/include/asm/vreg.h > index f26a70d024..122ea79b65 100644 > --- a/xen/arch/arm/include/asm/vreg.h > +++ b/xen/arch/arm/include/asm/vreg.h > @@ -89,107 +89,59 @@ static inline bool vreg_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr > * The check on the size supported by the register has to be done by > * the caller of vreg_regN_*. > * > - * vreg_reg_* should never be called directly. Instead use the vreg_regN_* > - * according to size of the emulated register > - * > * Note that the alignment fault will always be taken in the guest > * (see B3.12.7 DDI0406.b). > */ > -static inline register_t vreg_reg_extract(unsigned long reg, > - unsigned int offset, > - enum dabt_size size) > -{ > - reg >>= 8 * offset; > - reg &= VREG_REG_MASK(size); > - > - return reg; > -} > - > -static inline void vreg_reg_update(unsigned long *reg, register_t val, > - unsigned int offset, > - enum dabt_size size) > -{ > - unsigned long mask = VREG_REG_MASK(size); > - int shift = offset * 8; > - > - *reg &= ~(mask << shift); > - *reg |= ((unsigned long)val & mask) << shift; > -} > - > -static inline void vreg_reg_setbits(unsigned long *reg, register_t bits, > - unsigned int offset, > - enum dabt_size size) > -{ > - unsigned long mask = VREG_REG_MASK(size); > - int shift = offset * 8; > - > - *reg |= ((unsigned long)bits & mask) << shift; > -} > - > -static inline void vreg_reg_clearbits(unsigned long *reg, register_t bits, > - unsigned int offset, > - enum dabt_size size) > -{ > - unsigned long mask = VREG_REG_MASK(size); > - int shift = offset * 8; > - > - *reg &= ~(((unsigned long)bits & mask) << shift); > -} > > /* N-bit register helpers */ > #define VREG_REG_HELPERS(sz, offmask) \ > static inline register_t vreg_reg##sz##_extract(uint##sz##_t reg, \ > const mmio_info_t *info)\ > { \ > - return vreg_reg_extract(reg, info->gpa & (offmask), \ > - info->dabt.size); \ > + unsigned int offset = info->gpa & (offmask); \ In all the other helpers you are also defining the variables to store shift and mask, no matter the number of uses. I know that this is a left over from the removed helpers, but since you are modifying the file you could improve consistency and define them here as well. > + \ > + reg >>= 8 * offset; \ > + reg &= VREG_REG_MASK(info->dabt.size); \ > + \ > + return reg; \ > } \ > \ > static inline void vreg_reg##sz##_update(uint##sz##_t *reg, \ > register_t val, \ > const mmio_info_t *info) \ > { \ > - unsigned long tmp = *reg; \ > - \ > - vreg_reg_update(&tmp, val, info->gpa & (offmask), \ > - info->dabt.size); \ > + unsigned int offset = info->gpa & (offmask); \ > + uint##sz##_t mask = VREG_REG_MASK(info->dabt.size); \ > + int shift = offset * 8; \ > \ > - *reg = tmp; \ > + *reg &= ~(mask << shift); \ > + *reg |= ((uint##sz##_t)val & mask) << shift; \ > } \ > \ > static inline void vreg_reg##sz##_setbits(uint##sz##_t *reg, \ > register_t bits, \ > const mmio_info_t *info) \ > { \ > - unsigned long tmp = *reg; \ > - \ > - vreg_reg_setbits(&tmp, bits, info->gpa & (offmask), \ > - info->dabt.size); \ > + unsigned int offset = info->gpa & (offmask); \ > + uint##sz##_t mask = VREG_REG_MASK(info->dabt.size); \ > + int shift = offset * 8; \ > \ > - *reg = tmp; \ > + *reg |= ((uint##sz##_t)bits & mask) << shift; \ > } \ > \ > static inline void vreg_reg##sz##_clearbits(uint##sz##_t *reg, \ > register_t bits, \ > const mmio_info_t *info) \ > { \ > - unsigned long tmp = *reg; \ > + unsigned int offset = info->gpa & (offmask); \ > + uint##sz##_t mask = VREG_REG_MASK(info->dabt.size); \ > + int shift = offset * 8; \ > \ > - vreg_reg_clearbits(&tmp, bits, info->gpa & (offmask), \ > - info->dabt.size); \ > - \ > - *reg = tmp; \ > + *reg &= ~(((uint##sz##_t)bits & mask) << shift); \ > } > > -/* > - * 64 bits registers are only supported on platform with 64-bit long. > - * This is also allow us to optimize the 32 bit case by using > - * unsigned long rather than uint64_t > - */ > -#if BITS_PER_LONG == 64 > -VREG_REG_HELPERS(64, 0x7); > -#endif > VREG_REG_HELPERS(32, 0x3); > +VREG_REG_HELPERS(64, 0x7); No need for the movement. 64 should stay as it was before 32 and you should only remove the guards. > > #undef VREG_REG_HELPERS > > -- > 2.17.1 > > Apart from that, the change looks good. ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 02 08:59:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 08:59:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435670.689325 (Exim 4.92) (envelope-from ) id 1oq9aL-0001nM-5N; Wed, 02 Nov 2022 08:58:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435670.689325; Wed, 02 Nov 2022 08:58:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9aL-0001nF-2V; Wed, 02 Nov 2022 08:58:57 +0000 Received: by outflank-mailman (input) for mailman id 435670; Wed, 02 Nov 2022 08:58:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9aJ-0001n8-Qm for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 08:58:55 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 93cf6ccc-5a8c-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 09:58:54 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BE9CA225DC; Wed, 2 Nov 2022 08:58:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 539C8139D3; Wed, 2 Nov 2022 08:58:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mxTmEk0xYmPmHAAAMHmgww (envelope-from ); Wed, 02 Nov 2022 08:58:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93cf6ccc-5a8c-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667379533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x32TTSXhwza5c7baqBgiOCbV2AXnegIHoi3AjHskP0Y=; b=Y65T1xmuEky7XtQo065WDHNFG2bBmcNcA8SMKwV1flVuA8gBCT+23xawrwdHDo2Cusu2o5 lLsU541qCRsQhS2QljZneSMuXIwQTWpyJv01vGycSSHSPT22WU19Kcdeh0P3JcdTQXeIrs KhD4j7db0e+tgEimRCX+CNN+nsEQzZ8= Message-ID: Date: Wed, 2 Nov 2022 09:58:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices Content-Language: en-US To: Bertrand Marquis , Elliott Mitchell Cc: Stefano Stabellini , Julien Grall , Rahul Singh , Xen developer discussion , Michal Orzel , Oleksandr Tyshchenko , Oleksandr Andrushchenko , Volodymyr Babchuk , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper References: <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com> <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com> <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org> <82c45bc1-6052-502b-3007-8a16fbd1d433@xen.org> <9F323893-B1C9-4D31-9A40-213345421860@arm.com> <947E315E-6537-48DC-8AC6-5218C12B604C@arm.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------IfVgbINxJkhComWf6T80Q9Je" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------IfVgbINxJkhComWf6T80Q9Je Content-Type: multipart/mixed; boundary="------------bKqdsL0ifYJIOn5PfF7fOG5X"; protected-headers="v1" From: Juergen Gross To: Bertrand Marquis , Elliott Mitchell Cc: Stefano Stabellini , Julien Grall , Rahul Singh , Xen developer discussion , Michal Orzel , Oleksandr Tyshchenko , Oleksandr Andrushchenko , Volodymyr Babchuk , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper Message-ID: Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices References: <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com> <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com> <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org> <82c45bc1-6052-502b-3007-8a16fbd1d433@xen.org> <9F323893-B1C9-4D31-9A40-213345421860@arm.com> <947E315E-6537-48DC-8AC6-5218C12B604C@arm.com> In-Reply-To: --------------bKqdsL0ifYJIOn5PfF7fOG5X Content-Type: multipart/mixed; boundary="------------z6Uogb5YoIpOS7nT1iS9sxHW" --------------z6Uogb5YoIpOS7nT1iS9sxHW Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDIuMTEuMjIgMDk6NTAsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+IEhpIEVsbGlv dHQsDQo+IA0KPj4gT24gMSBOb3YgMjAyMiwgYXQgMjA6MjUsIEVsbGlvdHQgTWl0Y2hlbGwg PGVoZW0reGVuQG01cC5jb20+IHdyb3RlOg0KPj4NCj4+IE9uIFR1ZSwgTm92IDAxLCAyMDIy IGF0IDA0OjMwOjMxUE0gKzAwMDAsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4NCj4+ Pj4gT24gMSBOb3YgMjAyMiwgYXQgMTU6MDEsIEVsbGlvdHQgTWl0Y2hlbGwgPGVoZW0reGVu QG01cC5jb20+IHdyb3RlOg0KPj4+Pg0KPj4+PiBPbiBNb24sIE9jdCAzMSwgMjAyMiBhdCAw MToyNjo0NFBNICswMDAwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+Pj4NCj4+Pj4+ PiBPbiAzMCBPY3QgMjAyMiwgYXQgMjE6MTQsIFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQo+Pj4+Pj4NCj4+Pj4+PiBJZGVhbGx5IHRoaXMg d291bGQgYmUgc29tZXRoaW5nIHF1aWNrIHRoYXQgY2FuIGJlIGVhc2lseSBpbnZva2VkIGFz IHRoZQ0KPj4+Pj4+IGZpcnN0IHN0ZXAgb2YgYW4gZXh0ZXJuYWwgdGhpcmQtcGFydHkgYnVp bGQgcHJvY2Vzcy4NCj4+Pj4+DQo+Pj4+PiBJIHRoaW5rIHRoYXQgd2UgYXJlIG1ha2luZyB0 aGlzIHByb2JsZW0gYSBsb3QgdG8gY29tcGxleCBhbmQgSSBhbSBub3Qgc3VyZQ0KPj4+Pj4g dGhhdCBhbGwgdGhpcyBjb21wbGV4aXR5IGlzIHJlcXVpcmVkLg0KPj4+Pg0KPj4+PiBTcGVh a2luZyBvZiBjb21wbGV4aXR5LiAgSXMgaXQganVzdCBtZSBvciBkb2VzIGEgdklPTU1VIGhh ZCBhbiBvZGQgc29ydA0KPj4+PiBvZiBzaW1pbGFyaXR5IHdpdGggYSBHcmFudCBUYWJsZT8N Cj4+Pj4NCj4+Pj4gQm90aCBhcmUgYWJvdXQgYWxsb3dpbmcgZm9yZWlnbiBlbnRpdGllcyBh Y2Nlc3MgdG8gcG9ydGlvbnMgb2YgdGhlDQo+Pj4+IGN1cnJlbnQgZG9tYWluJ3MgbWVtb3J5 LiAgSnVzdCBpbiB0aGUgY2FzZSBvZiBhIEdyYW50IFRhYmxlIHRoZSBlbnRpdHkNCj4+Pj4g aGFwcGVucyB0byBiZSBhbm90aGVyIGRvbWFpbiwgd2hlcmVhcyBmb3IgYSB2SU9NTVUgaXQg aXMgYSBoYXJkd2FyZQ0KPj4+PiBkZXZpY2UuDQo+Pj4+DQo+Pj4+IFBlcmhhcHMgc29tZSBm dW5jdGlvbmFsaXR5IGNvdWxkIGJlIHNoYXJlZCBiZXR3ZWVuIHRoZSB0d28/ICBQZXJoYXBz DQo+Pj4+IHRoaXMgaXMgc29tZXRoaW5nIGZvciB0aGUgZGVzaWduZXIgb2YgdGhlIG5leHQg dmVyc2lvbiBvZiBJT01NVSB0byB0aGluaw0KPj4+PiBhYm91dD8gIChvciBwZXJoYXBzIEkn bSBvZmYgdGhlIGRlZXAgZW5kIGFuZCBicmluZ2luZyBpbiBhIHNpbGx5IGlkZWEpDQo+Pj4N Cj4+PiBJIGFtIG5vdCBxdWl0ZSBzdXJlIHdoYXQgeW91IG1lYW4gaGVyZS4NCj4+Pg0KPj4+ IFRoZSBJT01NVSBpcyBzb21ldGhpbmcgbm90IFhlbiBzcGVjaWZpYy4gTGludXggaXMgdXNp bmcgaXQgdG8gcmVzdHJpY3QgdGhlIGFyZWENCj4+PiBvZiBtZW1vcnkgYWNjZXNzaWJsZSB0 byBhIGRldmljZSB1c2luZyBpdHMgRE1BIGVuZ2luZS4gSGVyZSB3ZSBqdXN0IHRyeSB0byBn aXZlDQo+Pj4gdGhlIHNhbWUgcG9zc2liaWxpdHkgd2hlbiBydW5uaW5nIG9uIHRvcCBYZW4g aW4gYSB0cmFuc3BhcmVudCB3YXkgc28gdGhhdCB0aGUNCj4+PiBMaW51eCAob3IgYW4gb3Ro ZXIgZ3Vlc3QpIGNhbiBjb250aW51ZSB0byBkbyB0aGUgc2FtZSBldmVuIGlmIGl0IGlzIHJ1 bm5pbmcgb24NCj4+PiB0b3Agb2YgWGVuLg0KPj4+IEluIHByYWN0aWNlLCB0aGUgZ3Vlc3Qg aXMgbm90IHRlbGxpbmcgdXMgd2hhdCBpdCBkb2VzLCB3ZSBqdXN0IGdldCB0aGUgcG9pbnRl ciB0byB0aGUNCj4+PiBmaXJzdCBsZXZlbCBvZiBwYWdlIHRhYmxlIGFuZCB3ZSB3cml0ZSBp dCBpbiB0aGUgaGFyZHdhcmUgd2hpY2ggaXMgZG9pbmcgdGhlIHJlc3QuDQo+Pj4gV2UgbmVl ZCB0byBoYXZlIGEgdklPTU1VIGJlY2F1c2Ugd2UgbmVlZCB0byBtYWtlIHN1cmUgdGhlIGd1 ZXN0IGlzIG9ubHkNCj4+PiBkb2luZyB0aGlzIGZvciBkZXZpY2VzIGFzc2lnbmVkIHRvIGhp bSBhbmQgdGhhdCBpdCBpcyBub3QgbW9kaWZ5aW5nIHRoZSBzZWNvbmQNCj4+PiBsZXZlbCBv ZiBwYWdlIHRhYmxlcyB3aGljaCBpcyB1c2VkIGJ5IFhlbiB0byBtYWtlIHN1cmUgdGhhdCBv bmx5IHRoZSBtZW1vcnkNCj4+PiBmcm9tIHRoZSBndWVzdCBpcyBhY2Nlc3NpYmxlIHVzaW5n IHRoZSBETUEgZW5naW5lLg0KPj4+DQo+Pj4gU28gSSBhbSBub3QgZXhhY3RseSBzZWVpbmcg dGhlIGNvbW1vbiBwYXJ0IHdpdGggZ3JhbnQgdGFibGVzIGhlcmUuDQo+Pg0KPj4gV2l0aCBH cmFudCBUYWJsZXMsIG9uZSBkb21haW4gaXMgYWxsb2NhdGluZyBwYWdlcyBhbmQgdGhlbiBh bGxvd2luZw0KPj4gYW5vdGhlciBkb21haW4gdG8gcmVhZCBhbmQgcG90ZW50aWFsbHkgd3Jp dGUgdG8gdGhlbS4gIFdoYXQgaXMgYmVpbmcNCj4+IGdpdmVuIHRvIFhlbiBpcyB0aGUgdHVw bGUgb2YgcGFnZSBhZGRyZXNzIGFuZCBvdGhlciBkb21haW4uDQo+IA0KPiBXaXRoIHRoZSBJ T01NVSB3ZSBkbyBub3QgZ2V0IHRvIHRoYXQgaW5mb3JtYXRpb24sIHdlIG9ubHkgZ2V0IHRo ZSBmaXJzdCBsZXZlbCBvZg0KPiBwYWdlIHRhYmxlIHBvaW50ZXIgYW5kIHRoZSBoYXJkd2Fy ZSBpcyBkb2luZyB0aGUgcmVzdCwgcHJvdGVjdGluZyB0aGUgYWNjZXNzDQo+IHVzaW5nIHRo ZSBzZWNvbmQgbGV2ZWwgb2YgcGFnZSB0YWJsZXMgaGFuZGxlZCBieSBYZW4uDQo+IA0KPj4N Cj4+IFdpdGggdGhlIG1vZGVsIHByZXNlbnRseSBiZWluZyBkaXNjdXNzZWQgeW91IHdvdWxk IGhhdmUgYSB2SU9NTVUgZm9yIGVhY2gNCj4+IG90aGVyIGRvbWFpbi4gIFRoZSB0aGUgcGFn ZXMgYWNjZXNzIGlzIGJlaW5nIGdyYW50ZWQgdG8gYXJlIHRoZSBwYWdlcw0KPj4gYmVpbmcg ZW50ZXJlZCBpbnRvIHRoZSB2SU9NTVUgcGFnZSB0YWJsZS4NCj4gDQo+IFdoaWNoIFhlbiBk b2VzIG5vdCBjaGVjay4NCj4gDQo+Pg0KPj4gQWxsb2NhdGUgYSBkb21haW4gSWQgdG8gZWFj aCBJT01NVSBkb21haW4gYW5kIHRoaXMgdmVyeSBtdWNoIHNlZW1zIHF1aXRlDQo+PiBzaW1p bGFyIHRvIFhlbidzIGdyYW50IHRhYmxlcy4gIEknbSB1bnN1cmUgdGhlIHR3byBjYW4gYmUg dW5pZmllZCwgYnV0DQo+PiB0aGV5IGFwcGVhciB0byBoYXZlIG1hbnkgY29tbW9uIGFzcGVj dHMuDQo+IA0KPj5Gcm9tIGFuIGhpZ2ggbGV2ZWwgcG9pbnQgb2YgdmlldyBpdCBtaWdodCBi dXQgZnJvbSB0aGUgZ3Vlc3QgcG9pbnQgb2YgdmlldyB0aGUNCj4gSU9NTVUgaXMgc29tZXRo aW5nIHVzZWQgd2l0aCBvciB3aXRob3V0IFhlbiB3aGVyZSBncmFudCB0YWJsZXMgYXJlIHZl cnkNCj4gc3BlY2lmaWMgdG8gWGVuLiBJIGRvIG5vdCBzZWUgYW55dGhpbmcgdGhhdCBjb3Vs ZCBiZSB1bmlmaWVkIHRoZXJlLg0KPiANCj4gTWF5YmUgSSBhbSBtaXNzaW5nIHNvbWV0aGlu ZyBoZXJlIHRoYXQgb3RoZXIgY291bGQgc2VlIHRob3VnaCA6LSkNCg0KWW91IG1pZ2h0IHdh bnQgdG8gaGF2ZSBhIGxvb2sgYXQgbXkgIkdyYW50IHRhYmxlIFYzIiBkZXNpZ24gc2Vzc2lv biBhdCB0aGUNClhlbiBTdW1taXQgdGhpcyB5ZWFyOg0KDQpodHRwczovL2xpc3RzLnhlbi5v cmcvYXJjaGl2ZXMvaHRtbC94ZW4tZGV2ZWwvMjAyMi0wOS9tc2cwMTQyOS5odG1sDQoNCg0K SnVlcmdlbg0KDQo= --------------z6Uogb5YoIpOS7nT1iS9sxHW Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------z6Uogb5YoIpOS7nT1iS9sxHW-- --------------bKqdsL0ifYJIOn5PfF7fOG5X-- --------------IfVgbINxJkhComWf6T80Q9Je Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNiMUwFAwAAAAAACgkQsN6d1ii/Ey+n Zgf/dF9X26FL59JQ7t+VJVI6bjtLKaMEYiLK7zhHXtRU+i4IbmQkMZvdb8muv6M6YnZXEWtIfjOO NVQErbNM/WSHA9ZEe2JxSegIGsN9g5VC+yEE9yKo2wsyTYdGJJU4+eB1dKRzbTYOX4siGaO2/a/1 Z+QO/daVOdGQa4YF610V5LiLkzPS+8ceDnTkrhD52bq349Dl6VdkbYxJ1W7hBj29n4RLxQIFOMxR Zhe94/seuKNAvs6YL4zZVEXIRxDAMJoHci+TFzcW0jp1vJNekNfg11oLA943av6yV/GjuLA77zFY 2ST0qH0Y3Ur69D2bOKBMVH8ycWn+lOPvMPyvK249cA== =4N0q -----END PGP SIGNATURE----- --------------IfVgbINxJkhComWf6T80Q9Je-- From xen-devel-bounces@lists.xenproject.org Wed Nov 02 09:02:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 09:02:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435674.689335 (Exim 4.92) (envelope-from ) id 1oq9dj-0003Dw-Kq; Wed, 02 Nov 2022 09:02:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435674.689335; Wed, 02 Nov 2022 09:02:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9dj-0003Dp-IB; Wed, 02 Nov 2022 09:02:27 +0000 Received: by outflank-mailman (input) for mailman id 435674; Wed, 02 Nov 2022 09:02:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9di-0003Dh-69 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 09:02:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9dh-0005xm-Mr; Wed, 02 Nov 2022 09:02:25 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.26.173]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oq9dh-0000Ch-F1; Wed, 02 Nov 2022 09:02:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=q3YcW/TzJD7jwwibAtb6hLrcF4w4sXqck59Zucbwvms=; b=w4x6A8/WMuAlSutSiirHPwoRjt wt1/fF79f4VBxWaMl/0F4BE+8wDVSco4N5x5T+QTRK0vvaeXAalHHs93UwLRM8a+F1PhSZsvagzfE hvkgSbwTCyxPPfQaVwGq3Z6O1WcCCOfv1RE0LscQVFOSj8HVfhbdYy8ANIqMTvm/nfI8=; Message-ID: Date: Wed, 2 Nov 2022 09:02:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 03/12] xen/Arm: vreg: Support vreg_reg64_* helpers on Aarch32 Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-4-ayankuma@amd.com> From: Julien Grall In-Reply-To: <20221031151326.22634-4-ayankuma@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 31/10/2022 15:13, Ayan Kumar Halder wrote: > In some situations (eg GICR_TYPER), the hypervior may need to emulate Typo: s/eg/e.g./ > 64bit registers in aarch32 mode. In such situations, the hypervisor may > need to read/modify the lower or upper 32 bits of the 64 bit register. > > In aarch32, 'unsigned long' is 32 bits. Thus, we cannot use it for 64 bit > registers. > > The correct approach is to typecast 'mask' based on the size of register access > (ie uint32_t or uint64_t) instead of using 'unsigned long' as it will not > generate the correct mask for the upper 32 bits of a 64 bit register. > Also, 'val' needs to be typecasted so that it can correctly update the upper/ 'val' doesn't exist everywhere. But rather than explaining variable by variable what needs to be done, I would suggest something like the following: "While we could replace 'unsigned long' by 'uint64_t', it is not entirely clear whether a 32-bit compiler would not allocate register for the upper 32-bit. Therefore fold vreg_reg_* helper in the size specific one and use the appropriate type based on the size requested." This would also explain why we didn't do a straight replacement of "unsigned long" to "uint64_t". [...] > /* N-bit register helpers */ > #define VREG_REG_HELPERS(sz, offmask) \ > static inline register_t vreg_reg##sz##_extract(uint##sz##_t reg, \ > const mmio_info_t *info)\ > { \ > - return vreg_reg_extract(reg, info->gpa & (offmask), \ > - info->dabt.size); \ > + unsigned int offset = info->gpa & (offmask); \ > + \ > + reg >>= 8 * offset; \ > + reg &= VREG_REG_MASK(info->dabt.size); \ > + \ > + return reg; \ > } \ > \ > static inline void vreg_reg##sz##_update(uint##sz##_t *reg, \ > register_t val, \ > const mmio_info_t *info) \ > { \ > - unsigned long tmp = *reg; \ > - \ > - vreg_reg_update(&tmp, val, info->gpa & (offmask), \ > - info->dabt.size); \ > + unsigned int offset = info->gpa & (offmask); \ > + uint##sz##_t mask = VREG_REG_MASK(info->dabt.size); \ > + int shift = offset * 8; \ As you fold it, please switch to "unsigned int". > \ > - *reg = tmp; \ > + *reg &= ~(mask << shift); \ > + *reg |= ((uint##sz##_t)val & mask) << shift; \ > } \ > \ > static inline void vreg_reg##sz##_setbits(uint##sz##_t *reg, \ > register_t bits, \ > const mmio_info_t *info) \ > { \ > - unsigned long tmp = *reg; \ > - \ > - vreg_reg_setbits(&tmp, bits, info->gpa & (offmask), \ > - info->dabt.size); \ > + unsigned int offset = info->gpa & (offmask); \ > + uint##sz##_t mask = VREG_REG_MASK(info->dabt.size); \ > + int shift = offset * 8; \ Same here. > \ > - *reg = tmp; \ > + *reg |= ((uint##sz##_t)bits & mask) << shift; \ > } \ > \ > static inline void vreg_reg##sz##_clearbits(uint##sz##_t *reg, \ > register_t bits, \ > const mmio_info_t *info) \ > { \ > - unsigned long tmp = *reg; \ > + unsigned int offset = info->gpa & (offmask); \ > + uint##sz##_t mask = VREG_REG_MASK(info->dabt.size); \ > + int shift = offset * 8; \ Same here. > \ > - vreg_reg_clearbits(&tmp, bits, info->gpa & (offmask), \ > - info->dabt.size); \ > - \ > - *reg = tmp; \ > + *reg &= ~(((uint##sz##_t)bits & mask) << shift); \ > } > > -/* > - * 64 bits registers are only supported on platform with 64-bit long. > - * This is also allow us to optimize the 32 bit case by using > - * unsigned long rather than uint64_t > - */ > -#if BITS_PER_LONG == 64 > -VREG_REG_HELPERS(64, 0x7); > -#endif > VREG_REG_HELPERS(32, 0x3); > +VREG_REG_HELPERS(64, 0x7); > > #undef VREG_REG_HELPERS > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 02 09:03:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 09:03:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435678.689347 (Exim 4.92) (envelope-from ) id 1oq9eH-0003j3-Vf; Wed, 02 Nov 2022 09:03:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435678.689347; Wed, 02 Nov 2022 09:03:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9eH-0003iw-R3; Wed, 02 Nov 2022 09:03:01 +0000 Received: by outflank-mailman (input) for mailman id 435678; Wed, 02 Nov 2022 09:03:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9eG-0003e7-Bp for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 09:03:00 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 24dd199d-5a8d-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 10:02:59 +0100 (CET) Received: from mail-bn7nam10lp2102.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Nov 2022 05:02:52 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by BL1PR03MB6166.namprd03.prod.outlook.com (2603:10b6:208:31e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Wed, 2 Nov 2022 09:02:50 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::5d4b:6b1d:efc2:20e5]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::5d4b:6b1d:efc2:20e5%9]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 09:02:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24dd199d-5a8d-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667379779; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=4aYDivTRPAbk6PDnD/fkTW2cfLOl47POntFVChhrmQs=; b=FVt+ZXazpXRzU8e6HLAid8HwO8+g/4zGfhSMIApw4vV7pfIy8DODW2EL WAfWvzY7fhldGdt1nmv0V8zUqiAexxbAFNpEjgkpDCrGdrCeO1o/Yolim smbU1fL0XYvVZCdsTgHi38J+V2zqK0usd2TNsm/0EaxdrMr4iGw1QHTXS g=; X-IronPort-RemoteIP: 104.47.70.102 X-IronPort-MID: 84414840 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:oPQ4oK3a0uem9S/kOvbD5VJ0kn2cJEfYwER7XKvMYbSIYQITYwd3j TtIBzjCf73ffDO2KOnCW/3j/E5QuZPdytQ1SgJp+39mEXxD9JPLVNqQfx+sM3ybc5GeEBo65 chOO9XJIJptFyOB/k6gY+G9oyEs3P+EF+ajYAKo1lidYCc9IMt2oU4zy4bV+7JVvOVVIz9hm Pv+qZaAaAOr12V/OTga5v3e9Rll5KistG8U5A1kPPlA5Q6CmyEZAqxEKPDqJRMUYGX28s2SH L+fke7jrgs12z93V7tJR56iKhVirob6ZFTI0TwOHvD42XCunwRquo4jLv0QdExLvDuAmtF12 b1luIe5DAwkJcUgosxEO/VjO3w4bPAuFIPveyDl65XKlxeeKhMA/t01ZK0IFdxAkgpIKTkmG cwwcFglch2FjuSq97O3IsEEahMLdZSD0Cs34xmM/BmBZRoUacmrr5bivLe06AwYlMFWdcsyU uJCAdZZgLYsVDUUUrsfIMpWcO5FHRATeRUAwL6ejfJfD2Q+UGWdeVUiWTbYUoXieClboqqXj jn00WXmJzQbDeHczGam81G33cLohiyuDer+FJXgnhJrqHu64zVLTTcwCh68q/T/jVOiUdVCL UBS4jApsaU56E2sSJ/6QgG8p3mH+BUbXrK8EcVjsF3LlvWSvF7fXzBeJtJCQIVOWMseajEtz FCE2f/0AzhmqJWeSG6H96fSpjS3UcQQBT9eOXZYHVddizXliJwwsDn/UOdFLK2ooYD7JTz1/ 2uljAFr0t3/iuZOjc1X52vvkz+q45TEUAMxzgHWRX6+qBN0Ypa/YI6l4kSd6uxPRK6FR1yIp z4H3cyT6u8fAJWlmymEQeFLF7asj96ENiHRhRt/Ep8J9jKx9nrldodViBlyLUFoP8JCej7xb VX7vhlY75teenCtaMdfaIKrCt82yrDgGM6jSbbfatNUYbB+cQaG+GdlYkv493jgilMljLsXN pKScMLqBnEfYYxkwSS3QaEF3LYx3Sc47WTJWZXyyR+g16GDYGKUT7hDO1yLBsg747mDux796 MtEOo2BzBA3ePXyfzPN+IgPBVkPJGo8A9b9rMk/XuyEIgwgGmAJCvnNzLdncItg94xYmujB5 De8VUtV01v2nlXXKAGLbGAlY7TqNb5lqng6O2o2NFCk23E8aK6m9qJZfJwyFZEO7vBuyMlRX vYMesieKvlXQzGB8DMYBbHYpZB+Mi+ziASFMjCNaSI6OZVnQmThwcPpYQL16G8uDy67uMEkq rus/greTdwIQAEKJNjRbPWj3lagp08Xkeh5X1bLCtRLcUCq+49vQwTTg/E5ZeIRIxzYzTqZ/ wqRGxEVv/bKuYwuttLOgMistJy1GuFzGk5bGWjz7rusMyTeuG25zudoUvuMfD3bfHP5/uOlf +o95+v9OfsegVdMtaJzFr9qyeQ14N6Hj7NC1QFlAHXjZkymEK99OWKB2dRTt6pL3flSvg7ec kmG4NVdNJ2CMdnpF1NXLw0gBsyPyvQLsjDX5OYyJgPx42lq/9KvWEBTIzGNjiJHJbd4OY9jx v0u0OYI4ha2hhUjL8qPiwhb8m2NKjoLVKBPnpsAAYbtzBUszV1ZSYzdDi7w8NeEbNAkGlMtK HmIg7XEg7lN7kXHens3U3PK2IJ1j5MEsgEMwUQCI1mMk9ztifo+3RkX+jMyJixeyxRBwutpN kBuKUxuOazI9DBt7OBEW2GyGgxbQhmQ/0b80UchimTFQlLuWHalBGQmOaCPul8Y925deDdz8 7SRyWKjWjHvFOnL1ysvXQheqvrsTfR47AiEk8eid+ydHp4me3zmmKiqTTENpxbtR8g2gSXvr /Nn+up5b66gbHY4rKgyCo3c3rMVIDiFIndfW/5m1LkIBmzBYHe01CTmA0e1d8BWLvrG63ixD cB0O9lPXBSz0iWJhj0DDKtKKLhx9NYu4NcBYbrtKXQxr6qErjFpvZTT8QDznGYuBd5plK4VJ o7cby6CEyqVrX9Ih3SLp85BUkKjat4YeBLw9O+w+eQNUZkEtYlEe0w0+rakuGmcNgp6+lSVu 2vrYq7dz+Vmj4N2jYboOqxGC0O/LtabfOGB6gv1rtJBYMjEMcbNqxg9tFD7Mh8QM6F5c8Zsl bmLmNPn21/MurcrVibYnPGpHbRT98y2W+ZQLcvfI3xTnC/EU8jpizMj9maiONp2mdVSzsC9Q k2zb87YSDIOc9JUxXkQYS4BFR8YUvzzdv25/Xn7qOmQAB8A1wCBNMmg6XLicWBccGkPJoH6D Qj3/f2p47i0sbhxOfPNPNk+a7cQHbMpcfJOmwHZ3dVAMlSVvw== IronPort-HdrOrdr: A9a23:1KY6m6ovOtzjRHK3xtcNKKUaV5uUL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ki90dq7MAjhHP9OkMIs1NKZMDUO11HYSL2KgbGC/9SkIVyGygc/79 YrT0EdMqyWMbESt6+Tj2eF+pQbsb+6GcuT9ITjJgJWPGRXgtZbnmVE42igcnFedU1jP94UBZ Cc7s1Iq36LYnIMdPm2AXEDQqzqu8DLvIiOW29LOzcXrC21yR+44r/zFBaVmj0EVSlU/Lsk+W /Z1yTk+6SYte2hwBO07R6d030Woqqu9jJwPr3NtiEnEESutu9uXvUiZ1S2hkF1nAho0idurD CDmWZlAy050QKqQoj8m2qR5+Cn6kdi15aq8y7mvVLz5cP+Xz40EMxHmMZQdQbY8VMpuJVm3L tMxH/xjesgMftR9B6Nm+Qgeisa4nZcm0BS5tI7njhaS88TebVRpYsQ8AdcF4oBBjvz7MQiHP N1BM/R6f5KeRfCBkqp9lVH0ZipRDA+Dx2GSk8Ntoic1CVXhmlwyw8dyNYElnkN+ZohQ91P5v jCMK5viLZSJ/VmJJ5VFaMEW4+6G2bNSRXDPCabJknmDrgOPzbXp5v+8NwOlZSXkVwzvekPcb j6ISNlXDQJCjzT4OW1rex22wGIRnmhVjLwzcwb74Rlu9THNcnWDRE= X-IronPort-AV: E=Sophos;i="5.95,232,1661832000"; d="asc'?scan'208";a="84414840" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KDMGAvojmdgX72qR29asaUdRNmJRrxeINN6641oUO3e+erDJAzk9k/qWu+AlXaZ9Zr/1WMln9FuLOc8sZdvR+hmlSS0ZMM4xe7hZIhuHMw6O9PogKnfMYFHUnBsv1/v9cHwH/lrC0O7D2+UUmeQi3KlXFCUFNzwYAk5EI137I/90ZEjtIO2owMQQvhadyBuQzQh7UXna3KE7zZ1ZnWeKCaoZpkqkMXGUlFO7X5e+liTM158A45Pen2E5p2XYdMIzokXjAnI9sCmVE4Yka6+B3H5uo/3+PKaauWGvEbHX8kGLXw9hr9CWHkP4n68xt0YmCVsfSZ1nuRFPaqe8BqthRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rUoo3aV58qz30ZStXzkApNbS2D+lvMOpJ+QPFHfoTlw=; b=dtmp9N5RlcCrBskI6Uy6w+hFDQRcxR2jooSY/gTEwMqfkMXXJid0HPqictjRpJbwxakwWZ/JyW8eOF02COEs9OAiLsELgnllHv5zNC7ILse0cTwVeWehKiQM6mCAk1JF66ic+7icG+KTlfgAm1dwHlq7P5bFmS7qW4jbB0U4pdl3QOnQbGizKVSL5b5PZjsrvor57bkT6EKDDzO2aLg5GjjiKQp1pQIrhiUa1t33DCkKOuUzIw9BA1cBbuM8dX7zKFq2tQyLu6AFMSDWHEtsxXl26wAu2N1Q/UWz4M/0p0A1+4oho7v7l+JVz/eYAOFi/UKcW4EotI9M6vlFXKLg8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rUoo3aV58qz30ZStXzkApNbS2D+lvMOpJ+QPFHfoTlw=; b=AdGWxRSDoCxWfO8EOuD6swXkOEWc/AFPy6oK7OMk3nNmzdiVcuEDmj5EujYW++i2lOO6h5ESNioCgYOMis3k3NbtPeuTH/FrkbrzfqAzIfLrhHGrDYIvbE/80BH6uvzM3gZtg8OHMkoo2WFhzTkxeCaTA94l0DLf0cud4x7/1yM= From: George Dunlap To: Xen-devel , Tamas K Lengyel , "intel-xen@intel.com" , "daniel.kiper@oracle.com" , Roger Pau Monne , Sergey Dyasli , Christopher Clark , Rich Persaud , Kevin Pearson , Juergen Gross , =?utf-8?B?UGF1bCBEdXJyYW50wqA=?= , "Ji, John" , "edgar.iglesias@xilinx.com" , "robin.randhawa@arm.com" , Artem Mygaiev , Matt Spencer , Stewart Hildebrand , Volodymyr Babchuk , Jeff Kubascik , Stefano Stabellini , Julien Grall , Rian Quinn , "Daniel P. Smith" , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLRG91ZyBHb2xkc3RlaW4=?= , George Dunlap , David Woodhouse , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQW1pdCBTaGFo?= , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLVmFyYWQgR2F1dGFt?= , Brian Woods , Robert Townley , Bobby Eshleman , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQ29yZXkgTWlueWFyZA==?= , Olivier Lambert , Andrew Cooper , Ash Wilding , Rahul Singh , =?utf-8?B?UGlvdHIgS3LDs2w=?= , Brendan Kerrigan , "Thierry Laurion (Insurgo)" , Oleksandr Andrushchenko , Oleksandr Tyshchenko , Deepthi , Scott Davis , Ben Boyd , Anthony Perard , Michal Orzel , Marc Ungeschikts , Zhiming Shen , Xenia Ragiadakou , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLSGVucnkgV2FuZw==?= Subject: Re: [ANNOUNCE] Call for agenda items for 3 November Community Call @ 1600 UTC Thread-Topic: [ANNOUNCE] Call for agenda items for 3 November Community Call @ 1600 UTC Thread-Index: AQHY7pniZwSJPFR0zUarBtD9c84HRA== Date: Wed, 2 Nov 2022 09:02:49 +0000 Message-ID: <4C373461-D464-4414-9DE0-97D95554D76C@citrix.com> References: <75B69D18-27F3-4DC6-9308-CD2548967154@citrix.com> In-Reply-To: <75B69D18-27F3-4DC6-9308-CD2548967154@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR03MB5669:EE_|BL1PR03MB6166:EE_ x-ms-office365-filtering-correlation-id: 22dfbc61-4200-4d87-8bd3-08dabcb10490 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MMi9GhSbKOQXHBzpp69pEV1QfgqMca/Aws1JlI6dk2n0vyBlqP6ZSKHR1OvBVNKQUpwERtoM9GPKFI85LfAl4Az5o78Kp0XVfu8Pvqz1G2xDCRulhSfdKz2TgnPIIqoJMLLG4hqEFHFPgXcvux+vHcaZgRpH4Q4cDv9h5K/e5nceNKIkBO1mEqf6uwoK+1+aQZPikHC9ujh7C+HQ2RetjllIQGHlUDAngx+jJrtlyVPpoCGtN3auf8+VUqJJYg1+Ad9z+MpnoStM4xHBrVghy8GO4AQCv0G6IrdyxJUhsb1fioKXKJHtN78oif5uJpx6UB+N5Qyb8ip/r79nD6JnuSiaX5whc0TpliGKpAVpa0dnYVJRrWNBdHOLOo+0q+cO5Ptcf2zOlDwAqkuMldbg93ndNbo3tP//DyPCJQGJXN0zYt8wBn0fBtMpc+Om6SaSskda3H2Da6Ae7Mt9eBszb4Ormn9trW8lvO126qWPOtC+bmcOE07Q9IE02JyTwE8xDdb5wKS1EsDx6I1ymMomtToWfQcV21NGxiRU1NZP1ocxHKdPIgryo4KaT2WhOH7md4DRoIBuOdwlbE7eoM41kSmdassCA/Rs8Ji03sC4HObMOn4Fms5JlgnzBjZK+qa0QNaFLp0Hfwo6l7Twef4WiZDdwPUL8X56FqZkSXJnimEECDg7d819xhvsCntalu7XwclbCPXA3s9tIF9g9G0F/XvbqNF5f6FzeqJz+kVDokDTGejFVzNmeQnlIng4mi11MTk4IHbEZgXsbx5TATsHn7k0HXy+pvvAokRtDY2oaqKkYpc2ugN+tAY1zQjqsTrn6NtANhH+CD45kkK12sLfghdhdFvXDzbGZoWLw92Aip8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(366004)(376002)(136003)(451199015)(33656002)(36756003)(1191002)(316002)(7406005)(7416002)(478600001)(5660300002)(8936002)(38070700005)(83380400001)(921005)(66446008)(71200400001)(66946007)(41300700001)(91956017)(66476007)(64756008)(76116006)(966005)(8676002)(2906002)(6486002)(66556008)(110136005)(122000001)(6512007)(26005)(2616005)(186003)(86362001)(82960400001)(99936003)(6506007)(38100700002)(53546011)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SXh4M3dscGwzbSt2UkVjdkl1eWFoZXBTc0JEZU94WWZjc1hyR001ZXh3SVM3?= =?utf-8?B?enBWSm1kcjJhM1RIWUpEblFCOTdXZDFIcjlETFB5VURDaWFSQzkxRVlCcEJF?= =?utf-8?B?ekJubVBaNVRNczZZNHFqVEVQMEptREtFUFBlS3psUHVyTkNiWmtzVlhpajdE?= =?utf-8?B?dlExVWc5OUZrY0tjMXFkRTVEdUt6UE80Qlk2ZGREc01UeFcwblhYdUtqaTE2?= =?utf-8?B?Ulo4V29QZ0J3ekdTSDVmc2Eza1kvSWRTZTNMUm0zNFlmbC81VDhxMzQ3MEt5?= =?utf-8?B?bTFrWG4wZGJCa3FucERuUGRWZ2c1OEpRbzdMVmxhSnM2Y3NlQUx6bmwrZitz?= =?utf-8?B?Vmg2azdNRzdGbE1GdVVyKzdma2tCZkdIQk1oY3lpcUJjdDlwUVI3YVhodmgv?= =?utf-8?B?RlZFUTV2K1J4bzJVdVJycnR2azNUdDVIaDRXV1diRmlMTmUxaXNORENJMkFx?= =?utf-8?B?VWVEQXRlYkVQUThLcW1Vb05oL0JuZ2cvMTBoRW1hT1czUTF4SzVZaTJob2Rm?= =?utf-8?B?bWh3czRNU1lXcnhySVVKVzIzdFlSSU5GZXVDeWlZeFFRTmRyam5UMHAzQzMv?= =?utf-8?B?MW1iQUhlWTByaXlpMkpUWmE4aGw5Q2VqZ3EzS3BQV2VDY2h3YXE3eEZaNU5G?= =?utf-8?B?VzVaZmlpZGRmWDZjS0l0YXdoQkJBUjNxbnMzOTMxcXl6TXVhZSsxZ1ZiOFhJ?= =?utf-8?B?YnlnSlZxb1VSUGRhWXphVDVacEl1TFNrb3M5QUwvb2QrUWFuVFFKNXFkZ2Fr?= =?utf-8?B?QVBiQTFRUGJ0VEttNGwzL3Y3OVgxNitPL2M4V2Foa3llbnQ2R0xLcHRycGh6?= =?utf-8?B?T3pDbHh3TVpLeGlzYlZTUklFdEZzZXZkZVJiTlRNVE1LUHNtWmdMcFpZT3NK?= =?utf-8?B?d3ZHcGdlSVRnQ0pndzEwNEdDM1IzQ2o2VUJZd09iWUM3MGVkOWJsVXFEMDBo?= =?utf-8?B?Q1orRUdzRHF4U2t6a2dpTGwvT1pMWFFrVEpxYkhCS3Z6MFlIakdHZlNFRnF4?= =?utf-8?B?ZVU3WjB4Rk5qSm5Bc3pJVU1wTk1qNkxzU2dsRWFOc0x3Zm1PWGttYkR4aGFx?= =?utf-8?B?QXRPRmU4SXZCU3QzVGlDWHMxSEtDOTUvTFJ0NlRBTVp1ZXNWOGJFNm5kTlJz?= =?utf-8?B?OUNENzZXcVZuRm5rb0hLNjA5N1lRc29XMmtjZXR5MFpRNHZNSkl2anQ2WFhj?= =?utf-8?B?U1FrbTNFSmRpbTA2QWJSdE51d1VBUm91OXJJY0dlRjdLQ3NNYWZXbVdqYlor?= =?utf-8?B?dzlZNUhka0I3UG5mc1FLRlZZcHdPOVA1SVNvblBGMjQ3WGl2bHhqMVVybXpN?= =?utf-8?B?WXdpV1pabHVwaHQwOWtBNFMxRm1ZM2FManV6QldyU3ZQK2w4QWNWbEFwYThK?= =?utf-8?B?NFMrL3l4dGN4cVhKOG5pQXZnQUVCekVMaEFiWHYwRFJrazBnd1VCUWlWOExv?= =?utf-8?B?d2JsN3dzcHlvNzVlS09TdjduSHlCR2Fxd3RCN05TT3EwTjArclBoMTBHRE8x?= =?utf-8?B?c1BuMkxKV0RYOHF5UlVOOGtSTzFWTVpCWGszZkEyNXZtNkdkeEoyNkF1ZkVh?= =?utf-8?B?UTkxZUhKMGVjR0dxWnhMb3REWVhhYXFlYzZ5aXJDWGRIWExsQWcwM1JEZHN2?= =?utf-8?B?eVUvZUpMSk9LUjAwSDdSdk1OcEdWRkoyMjFIREcra1REQmNJSEdCZ3BMT2lZ?= =?utf-8?B?VWl2bTlIN2FSeUV6QjVEYlNVeGdLS29XS2l3RVhlcmx5eVRkNFVzSWVKQUFE?= =?utf-8?B?NCs2cmo3NUtsS2xuREVSR0xwZWkzL0NGUmV5bTVzRGhFdEdOTVZmb3BXQmU3?= =?utf-8?B?NTBSRnQ0dFRWUGFBbHl4TGpVSTVsU29KM3RIZGFIMjdzWFBCWTRjMjFHS1FY?= =?utf-8?B?LzRETDRLZXR1aStjbHR4dmZ3aGhEQmFlQXhVeGVCaGtWaWdETlA0ekpscVAw?= =?utf-8?B?MXBBd2pqSHNlcGlSVzlYNVdxbGhlRDl1b0pwenNpaXJlSzBjUDJsRmFqNENK?= =?utf-8?B?ZERIOGpCS3ZaWXlpZW5LRXN0ZDNMdDJPQ1pFcDR3SmtCZEpJbHptaU9sQ0hQ?= =?utf-8?B?R05YYkxxZTYyZ3ExMmNDMnQ3WFlEUVhtWCsvR0Vhb2xDVTM1TWI2V1NuanVR?= =?utf-8?B?dHpnMjV0QlpGcyszcEl4QnF4YWZ4VS9wem1vcEZOTWFpYS9GOXg2YTFyZFJN?= =?utf-8?B?dmc9PQ==?= Content-Type: multipart/signed; boundary="Apple-Mail=_620AD4AA-2FA6-4D92-A02E-4FB46E4748E9"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22dfbc61-4200-4d87-8bd3-08dabcb10490 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 09:02:49.8005 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yx3kI3+beqEAPLTAu2v0MzaLDcHfLRNiKZtaaaY9vFlXrpH/JLYtk59y1GBTnNt7fIGiLW8ngvxc2lassWY8AhYPTxgwDX28IhxPbubUdwE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6166 --Apple-Mail=_620AD4AA-2FA6-4D92-A02E-4FB46E4748E9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Sorry all, It=E2=80=99s been pointed out that this should be the *third* of = November (tomorrow), not the 5th of November. -George > On 28 Oct 2022, at 15:08, George Dunlap = wrote: >=20 >=20 > Hi all, >=20 > The proposed agenda is in = https://cryptpad.fr/pad/#/2/pad/edit/5YUquBkUpmg-XuzK8cyvUQ8+/ and you = can edit to add items. Alternatively, you can reply to this mail = directly. >=20 > Agenda items appreciated a few days before the call: please put your = name besides items if you edit the document. >=20 > Note the following administrative conventions for the call: > * Unless, agreed in the pervious meeting otherwise, the call is on the = 1st Thursday of each month at 1600 British Time (either GMT or BST) > * I usually send out a meeting reminder a few days before with a = provisional agenda >=20 > * To allow time to switch between meetings, we'll plan on starting the = agenda at 16:05 sharp. Aim to join by 16:03 if possible to allocate = time to sort out technical difficulties &c >=20 > * If you want to be CC'ed please add or remove yourself from the = sign-up-sheet at = https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/ >=20 > Best Regards > George >=20 >=20 >=20 > =3D=3D Dial-in Information =3D=3D > ## Meeting time > 16:00 - 17:00 UTC > Further International meeting times: = https://www.timeanddate.com/worldclock/meetingdetails.html?year=3D2022&mon= th=3D11&day=3D3&hour=3D16&min=3D0&sec=3D0&p1=3D1234&p2=3D37&p3=3D224&p4=3D= 179 >=20 >=20 > ## Dial in details > Web: https://meet.jit.si/XenProjectCommunityCall >=20 > Dial-in info and pin can be found here: >=20 > = https://meet.jit.si/static/dialInInfo.html?room=3DXenProjectCommunityCall --Apple-Mail=_620AD4AA-2FA6-4D92-A02E-4FB46E4748E9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmNiMjIACgkQshXHp8eE G+0pLwf/ZK0Qlqq05x0b/FMCKB6adNEdnKpyK34tO9Hc5EanHBdHHtkCtoGDqbN5 dFzcRftZqU6eJ2GoXOVSb9345cnkEtr5E5TFl9egLHDVeBACmNCv+984nI93FG1D uRFSKwefeyUQouhABfJAY9xdCBmv3LBjHf5dcf+vACxYXFPhMCKHVsTvnBUOHpnK 6J7d7DSQB4/Ev6uD9bgGMVSyryxwDohMvzRbTNTGr8OtKahQl6WFi+pYVrK+RvZK FGZ0UZ8om4SFb1b1G3PxlBN/r12qriSdGwJomZFs3+RlEIR7R5/XhVv3iIoxsh9X w/fxPLjR4Q7Sw3Qzp0eTuZ0M1cmA1w== =zHbW -----END PGP SIGNATURE----- --Apple-Mail=_620AD4AA-2FA6-4D92-A02E-4FB46E4748E9-- From xen-devel-bounces@lists.xenproject.org Wed Nov 02 09:04:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 09:04:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435684.689358 (Exim 4.92) (envelope-from ) id 1oq9fM-0004Lx-D1; Wed, 02 Nov 2022 09:04:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435684.689358; Wed, 02 Nov 2022 09:04:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9fM-0004Lq-9b; Wed, 02 Nov 2022 09:04:08 +0000 Received: by outflank-mailman (input) for mailman id 435684; Wed, 02 Nov 2022 09:04:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9fK-0004LR-S9 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 09:04:07 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4cccdf14-5a8d-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 10:04:05 +0100 (CET) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-364-w8LYwmAUM4eCLwp-YsEBLA-1; Wed, 02 Nov 2022 05:04:01 -0400 Received: by mail-wm1-f69.google.com with SMTP id h8-20020a1c2108000000b003cf550bfc8dso805817wmh.2 for ; Wed, 02 Nov 2022 02:04:01 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id b13-20020a5d550d000000b002366b17ca8bsm14083933wrv.108.2022.11.02.02.03.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:03:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4cccdf14-5a8d-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667379844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XBlp2DOijU5hXQ9AriUwp9vEVLgfxcCQxHX+sSZSvOs=; b=foE1tqMnN1euVXsjwdlyPW1Y4BTMlfQxIBqnZz2eDUgMOJ3r8Zu+tBZQX0GkNtDL2D+9Aj flWcioqcZUsIaIG4L65T3zBd/pzbd1EQRgPn+MZdj0iMkyKMJis4wJ5Qwuj07kEsp7CYEk jHcVQV9OGuPi3hRfiynfov54IpOv5aE= X-MC-Unique: w8LYwmAUM4eCLwp-YsEBLA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XBlp2DOijU5hXQ9AriUwp9vEVLgfxcCQxHX+sSZSvOs=; b=myRmTKNfsYyKoRr4pNN7PPN3YpVJnIXTrJTHgxJefbe46F5xtj7jCIOIfpo6E4oiNX m9rXO1/woota/8sMqyPs1nxpNDWdLfHtdFHFh2YBU+woVkJqFRDZO8SudMZNfLVnOu++ OEeKp2s1/o44Wp/ilqrN4f759GPGqIaVhuSnFb/L1ShR2xW3Ktn3+lPisBAWeVV8bjCy NdGnSGU6qis1OcCSD+312Zl36JDM2paRZRz3OOdSeMVov3iZ8ARQHb7kipukXmzVL+70 hw7Z5+SS9H85Rzzrd71/Fhe48BRqQh8F/rjGSkgdPTnt+HyICFgiMYsV+diVgWo9dFDS XYgg== X-Gm-Message-State: ACrzQf26Q0A1Sbg78MJXRSpufY8mvL98jjl55SoZRDlFmOq6sPoHN7y1 p2HAZFO4HWgPh/QtemVOE2CPoXdcHqtx1nwgi+vBIlltrKWHNtOXsPwz3NYK6RwNXABHzB4wm9P MXEu/ETwMmPP+8OcOfA830Z32HHE= X-Received: by 2002:a7b:c409:0:b0:3cf:4c81:8936 with SMTP id k9-20020a7bc409000000b003cf4c818936mr24380814wmi.38.1667379840253; Wed, 02 Nov 2022 02:04:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM72ckpdUoZR+NwXtu1sv2+7NmgS+YMIWWHB7QdeKnWTKduGDRl7tg4bkpenTZv0mX1kFf34kw== X-Received: by 2002:a7b:c409:0:b0:3cf:4c81:8936 with SMTP id k9-20020a7bc409000000b003cf4c818936mr24380784wmi.38.1667379840046; Wed, 02 Nov 2022 02:04:00 -0700 (PDT) Message-ID: <87284e5e-859e-3b1c-7142-28d4fa7a7939@redhat.com> Date: Wed, 2 Nov 2022 10:03:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 15/21] drm/fb-helper: Disconnect damage worker from update logic To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-16-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-16-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/24/22 13:19, Thomas Zimmermann wrote: > The fbdev helpers implement a damage worker that forwards fbdev > updates to the DRM driver. The worker's update logic depends on > the generic fbdev emulation. Separate the two via function pointer. > > The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty, > a new callback that hides the update logic from the damage worker. > It's not possible to use the generic logic with other fbdev emulation, > because it contains additional code for the shadow buffering that > the generic emulation employs. > > DRM drivers with internal fbdev emulation can set fb_dirty to their > own implementation if they require damage handling; although no such > drivers currently exist. > > Signed-off-by: Thomas Zimmermann > --- [...] > static void drm_fb_helper_damage_work(struct work_struct *work) > { > - struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, > - damage_work); > - struct drm_device *dev = helper->dev; > + struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work); This line is an unrelated code style change. But I guess it's OK. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From xen-devel-bounces@lists.xenproject.org Wed Nov 02 09:05:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 09:05:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435688.689369 (Exim 4.92) (envelope-from ) id 1oq9gO-0004ti-MB; Wed, 02 Nov 2022 09:05:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435688.689369; Wed, 02 Nov 2022 09:05:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9gO-0004tb-JN; Wed, 02 Nov 2022 09:05:12 +0000 Received: by outflank-mailman (input) for mailman id 435688; Wed, 02 Nov 2022 09:05:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9gN-0004rG-Fj for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 09:05:11 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 738569fe-5a8d-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 10:05:10 +0100 (CET) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-359-dzD8mTWzPTil1YyUkyZUcA-1; Wed, 02 Nov 2022 05:05:05 -0400 Received: by mail-wm1-f72.google.com with SMTP id f1-20020a1cc901000000b003cf703a4f08so245518wmb.2 for ; Wed, 02 Nov 2022 02:05:05 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id p2-20020a5d4582000000b00228d52b935asm12402687wrq.71.2022.11.02.02.05.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:05:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 738569fe-5a8d-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667379909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LpYqcUNkPgIA1fAPwB+EiO+Z9dq0ENSiM+RajxMrldI=; b=QABVmfZToklNdvumxrtSd259Jj+oeLI5xV1YLK//PW4EDNnyJVGOuH8Kcta6DRkCdxiWYG c7MV5QnmzSanxQBGKfqjkQS0ihPymcrU7b61Fv+rZPi7usBLTFoqRnfUgIkFOVYwZkN6jY ly5+ihqZcTGjHX2Isj3K7FAWWznwcfU= X-MC-Unique: dzD8mTWzPTil1YyUkyZUcA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LpYqcUNkPgIA1fAPwB+EiO+Z9dq0ENSiM+RajxMrldI=; b=Y8EdZwwVsNLo07wow+R5reoEDeF2wgS1+Sa6p61b/77YWmeQs5BGeDWU9kuR89Z4si mdPJ7elYC3O4jSj/sF08BZ1IXlFn8+8XB3blxVGSdNvWwhwgQW0pjt2Eu15tja4y/1HZ 0oaECoBhUxMiObVmYkneVi4mYb4mc8cdY19I9dd7hwfrU858D2fRjx+xRI/w3cBiERpf 13WYop2QGAKHk4/InCufOY+jE/dkqlT6tGqs4aMkvbOpoN/vd5vaqlysbMG1ORpK5lBj LWta26pQ+BnRAt5YGtonIgN66AkkDJWbWRl06tX2S5ae5aN95dZUdrxKw2VYicAdRPHJ 0PAA== X-Gm-Message-State: ACrzQf2zczZ560bD6mZhgBt7Ou/0QlH982ocEMNyz3gLXgRxoEyxA/RS icQwY5x4hQHgev4wIExtRmJsDkxzdvKkto81gYyFng5BdPo8EQDitkDe2Pi9CSjqT/lIbH5zdNM rWYdaCJFXZE8Qo8Uq1Z/2WNshWIY= X-Received: by 2002:a5d:6488:0:b0:22b:3b0b:5e72 with SMTP id o8-20020a5d6488000000b0022b3b0b5e72mr14464172wri.138.1667379904745; Wed, 02 Nov 2022 02:05:04 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Ug/7BR+PMLuqwC0wiYVRKEgerXkzKho5yFNKIDT0bC26SnYKpkqpAn1quqQ9FNF9E1JGkLg== X-Received: by 2002:a5d:6488:0:b0:22b:3b0b:5e72 with SMTP id o8-20020a5d6488000000b0022b3b0b5e72mr14464139wri.138.1667379904487; Wed, 02 Nov 2022 02:05:04 -0700 (PDT) Message-ID: Date: Wed, 2 Nov 2022 10:05:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 16/21] drm/fb-helper: Call fb_sync in I/O functions To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-17-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-17-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/24/22 13:19, Thomas Zimmermann wrote: > Call struct fb_ops.fb_sync in drm_fbdev_{read,write}() to mimic the > behavior of fbdev. Fbdev implementations of fb_read and fb_write in > struct fb_ops invoke fb_sync to synchronize with outstanding operations > before I/O. Doing the same in DRM implementations will allow us to use > them throughout DRM drivers. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From xen-devel-bounces@lists.xenproject.org Wed Nov 02 09:08:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 09:08:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435694.689380 (Exim 4.92) (envelope-from ) id 1oq9jg-00063E-41; Wed, 02 Nov 2022 09:08:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435694.689380; Wed, 02 Nov 2022 09:08:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9jg-000637-0w; Wed, 02 Nov 2022 09:08:36 +0000 Received: by outflank-mailman (input) for mailman id 435694; Wed, 02 Nov 2022 09:08:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9je-000631-Sn for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 09:08:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9je-00064U-ID; Wed, 02 Nov 2022 09:08:34 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.26.173]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oq9je-0000Ru-90; Wed, 02 Nov 2022 09:08:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=RLFowBG2jiqBOiJts4yeqkMa0/QhmAvTm3aZ9Rg2EbU=; b=4LHxOFQXvbzpNw5zc5SRNVwwCd /PNZqFKm9dNPEA12bmE8WGq5iVED38pL5ylOdcC+kAdYKWpzksFkduRt9+UvnKoXGkAJa0BQhwute 1Ja22an5uDD2u9rDak/3G3TnC51aHgLtSR/0mH/H3ynMjS3P8k87iO0YR2EeQRC41w7k=; Message-ID: Date: Wed, 2 Nov 2022 09:08:32 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 03/12] xen/Arm: vreg: Support vreg_reg64_* helpers on Aarch32 Content-Language: en-US To: Michal Orzel , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-4-ayankuma@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/11/2022 08:52, Michal Orzel wrote: >> /* N-bit register helpers */ >> #define VREG_REG_HELPERS(sz, offmask) \ >> static inline register_t vreg_reg##sz##_extract(uint##sz##_t reg, \ >> const mmio_info_t *info)\ >> { \ >> - return vreg_reg_extract(reg, info->gpa & (offmask), \ >> - info->dabt.size); \ >> + unsigned int offset = info->gpa & (offmask); \ > In all the other helpers you are also defining the variables to store shift and mask, > no matter the number of uses. I know that this is a left over from the removed helpers, > but since you are modifying the file you could improve consistency and define them > here as well. Nack. We don't define extra local variable just for consistency. They are added in some places below to reduce the number of operation in one line. This is not necessary here. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 02 09:11:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 09:11:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435700.689391 (Exim 4.92) (envelope-from ) id 1oq9mT-0007Qj-Ir; Wed, 02 Nov 2022 09:11:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435700.689391; Wed, 02 Nov 2022 09:11:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9mT-0007Qc-F8; Wed, 02 Nov 2022 09:11:29 +0000 Received: by outflank-mailman (input) for mailman id 435700; Wed, 02 Nov 2022 09:11:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oq9mS-0007QQ-40 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 09:11:28 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5278ab42-5a8e-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 10:11:25 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Nov 2022 05:11:18 -0400 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by SJ0PR03MB5774.namprd03.prod.outlook.com (2603:10b6:a03:2da::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 09:11:17 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::5de3:b6a7:8935:2731]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::5de3:b6a7:8935:2731%3]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 09:11:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5278ab42-5a8e-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667380284; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=L/h6dsfgncYhEPqHTBICIMVOyM5d4zj+ofmNBj6XvEY=; b=clEpTpUR0IyHCs/rWBTZ35ifopMPsQHwSxxKiQTyFHDj4fXZys0FfL9N DHL67jfWMgL+m+CI/HqWeV9DNWvVK1N5evAdROZ2yx11zzXb6saqmHO+q 0g4GlsjAQi+J4tNesoXzyvSxsZ/HaaaDPpCXCnPK8AZnCNVnsBOWOLP3C o=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 86522324 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:JpXY0avRyJRX0UgEtn5JFfJngufnVHRfMUV32f8akzHdYApBsoF/q tZmKTqCOq3cNDGne953aITi9xlU65LXn9I3TABpq3pgH3wV+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5Vv0gnRkPaoR5QaGzSFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwcSoGNzqqnMiM3LODbbF+tpx7ItWxBdZK0p1g5Wmx4fcOZ7nmGvyPz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgP60boq9lt+iHK25mm6Tp njH5Hj4CxdcMN2ZxTuK2nmtmvXOjWXwX4d6+LiQpqA32gfInDB75Bs+X1GphPCymkiHW4x+A RM40TI2jKEU+xn+JjX6d1jiyJKehTYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/ lOAgd7BHzFkt7yRD3WH+d+8sjeaKSUTa2gYakc5oRAt5tDipMQ5iELJR9M6Saqt1ISrSXf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxode51knHpU KA4pvWj IronPort-HdrOrdr: A9a23:4ieTfaNj/MLa0MBcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+75xY1/X7VEts8p717 8O12WFt4BPBReFhyjl4cPUPisa33ZdMRIZ4JEuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiItiYfzQTOaNSSj5uw5zvmWehTNYd3E8LAv27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm X-IronPort-AV: E=Sophos;i="5.95,232,1661832000"; d="scan'208";a="86522324" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=be9V4yJeuumd5sM0UBVHvlNdCM35FVq+Zwyd298d/NUhjRTa1QxMNs5pmg6iJN7KA7qLDPHOv97FWfLHIds7aNG6+kt4BfcbaLMJfTSfD/xrrw0fc6CmIp0HkxVWOHOy6zB0wEtJv2YvwRc7n0wQaFoq+mB3fmmoZl5YL0HTU1VZSTOKZF1YBi7UnKL+1h3kIkLRc0kUWMpa1MJm8aYq7tVYHMFKnJO7OeGoMRWcEYlnqtGJ7fhuVgsf4ob2vpb6lASUfYNd/+TeC6igP4KLrbBNhc0AcXoXdxTSoVHhH5xCy+pkq/zXr9tZAGyYjzpolZrSCVtVl0gbGljhq5UQPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L/h6dsfgncYhEPqHTBICIMVOyM5d4zj+ofmNBj6XvEY=; b=iw/CfGDxJSm6XoOIzcgqTda5cRKId1aEeU56dR2n1EqnIOukM4A1oYdoiisvTwncN9oaAiOfLUm1mM2Vw0sgSxpTih8SeVHbDfY/DzNHCd1JCvlDFLUkbpAnl1x0Y7XGDHpM+GY8YTFKujJXxsFTjMvOwV91rk6QrQ3K5R/4Ax7viPgqT6MVhMdP+WfZlROXHKyT3JRRfqr/j+hff+U3HSeXq9LpQTOOMXEg8bmW8ayxPe36MBrpK0TVRlZeGBPVtODk5D0CXERWjGhJNYXR7ERCO+ME1JV26oWjH8M8t95KB6T5Mw/3Uaenvvz9FQFz/Aa3GtjJStslyoZswNonUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L/h6dsfgncYhEPqHTBICIMVOyM5d4zj+ofmNBj6XvEY=; b=cS55c0dr3PJ5yFZHyGL30jRUt4gN9qceit+xqhhCM0Fsayn8cBDwMwePQ13k4d6kHea6IKqE2MS89mv1qiOvUjN9ZbAOP9HLpnb1cB8Gdcxr7JPMnGOCc4HEryOddxbK1ZAf2yCAmBuib/Md3JPZQ2FldbFFfWVz8aap1LwHnmc= From: Christian Lindig To: Edwin Torok CC: Xen-devel , Pau Ruiz Safont , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist Thread-Topic: [PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist Thread-Index: AQHY7hu7nGK02b4G20+MH2/c4dYgF64rWegA Date: Wed, 2 Nov 2022 09:11:16 +0000 Message-ID: <1FD039A8-AE3A-4D6E-A2E9-F446FD6653DD@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|SJ0PR03MB5774:EE_ x-ms-office365-filtering-correlation-id: f4a3a856-a739-4791-3cf9-08dabcb232c1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K1qYkwn/HeULkS/vDm+2be33TxcMbVli1wZLbGwO43daMLExiLdI8zsgDjnXkayKqPXxLDazk64W8KZ2AVyra78T+jQYqzuj0Y5Q6M3YmwoAxo65Jdg2RdEuLQE2No02esOUN9bXCFEVObVlPgci732ufce7l97lpaCXU1X5S8lyZTexnx0M2i2hWsFpm+baj0OX/qcQDI1s8FuK/Db+9HPnuK0gvnVS1Zez1Bz9OcgMdBtIkmRaBBA6IoPX+RYdpkngy2O8gsA+FYbmUk/N/VGYUyhnXgRmZBROVWjhfc6HBy8i7OhBBi522Ls9pVpsFxTY6dpZ3bDV49/q+u5XDfa8FnM7tGkCbrxEIGXEeX91xnG7AiXAqg3G1g3/Gna4Xlzr+IGLMryBwFIVSYvQY9hUiE8mx56ScVu9Akn1ctYrnY228tW6+BxfT/xKUQsmdZ2C2JcaTPXMdr0QbjFQgYM4ENN8CoaSo8cQNbZvoeMszbmvxhnk5lQ2Sh5zSWolPw+RIDSWuHyymTGrOlaaTkFp80KSvn3CKfMLDbYbU8PlTf+xXfNMgsBIvbTtms+haf3bjqqsqsXE7POA13AbFo31ZKkjeN1wX0C58bHa1mimQmwsYxN91ZWrSiRKGaGzlCDrBNDjGaSU//mvMHgqXABpED6Eotu1Y+eCSxloLk5xYjP7WrmusASlePhatJN5EiN8BoeufNzEcF8YxvUQrOMvSfjQXYAGOg8GtGzMdEi+/nBc5qEqFDPUvnbEVuujNM6+HYf3yNcxurkQodXBe9+ORpTyJK4o72FT6v+QJaY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(451199015)(6636002)(37006003)(54906003)(478600001)(107886003)(186003)(44832011)(6506007)(66476007)(66556008)(66946007)(6486002)(76116006)(8676002)(53546011)(71200400001)(91956017)(41300700001)(6512007)(26005)(2906002)(6862004)(5660300002)(8936002)(66574015)(66446008)(83380400001)(4326008)(38070700005)(33656002)(38100700002)(122000001)(316002)(64756008)(2616005)(36756003)(86362001)(4744005)(82960400001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eDhQb2x6U0FCcU5aSVJVVE5MZkRVcUFWTGxNcmxSRUFSSS8yL3JFRHk4MkZ6?= =?utf-8?B?WVFTOW5nWkZLOUFaYUNwbk9iUW00RmFDYkM4U3JjazJxcm9mdVNZRTN5UFBx?= =?utf-8?B?QjNZRzdHaXQ3ejNKZ2NjK3BXdkpBZittVjZ5WjlwY0FBRWNtNFpqTU0zN0x6?= =?utf-8?B?ektMaHQ5UGs5Z2Z3Y1h4ckRZelhaK3pRamVNbEQxdVVOcWVhWFkxbSs0bXBw?= =?utf-8?B?MUUxazFyMGxJWk9oR3h1dk9PalhDNUlKMDJaWXE5QzZrbHZNQk5McEFNS3JM?= =?utf-8?B?bC9UaExhOW1UZHloUGt0aWJIRjl2TVBiVXRqd0hWMEw3bENzZ2VTVUQ3RnV6?= =?utf-8?B?Mit4WkNmYnNGTWd3N3MxVHk3eC9Ob1RqUHF6VTBHY0IxV3NMRDVVWVIrMllZ?= =?utf-8?B?UnNGbEFWbUxDRnA4YmdSVzlmMGlPL201VFVUbG9tL01kTEFNMUpDdTE1bGFO?= =?utf-8?B?elQ4b0pZcG03bmJJM2VaeGRYbFRGMlZIRnlIYWhZNi9xcWNkZ2JOSGNPQWlO?= =?utf-8?B?TDNMSjhESnRxQy9Qbi9lRkpJVnhWSW1veHJsaC83LzhXdjBkWm1Td2pabjhB?= =?utf-8?B?dE5ZNEhqZ1l6L3luMkIxUUxUMU5HcWN4bjhVK2ltNjljMTBldUdyUWtwRy9S?= =?utf-8?B?dlFWSTArMnJSQll1VGFNZXhvQjF3eC8yYTZZZC9QY2NrZEM1TjFtMzdsLy9X?= =?utf-8?B?dzBUR0N2M2lXeDNaQnB2N0w3Y1RsbElvNTUvaFJQU2g4RFdmN0d6ek1SNzBK?= =?utf-8?B?TlRsTlNzeURqa3ZxVXVGOEZhMHFMUVdYajFNNXVmcE9QWDVIUHlkY05kMkFQ?= =?utf-8?B?dU5obXF6eDQxSHB0eWxjRFF2Tk9XTGF1VElKRUlFK044aHZ6RzVBd3lFZHFG?= =?utf-8?B?WnVkNE5lVjFzcG1mZjd6L2hPR2VJZ0ZTMDRLR3Zldm81MDVrVDJyRjZZWUxK?= =?utf-8?B?YmVQMFN1UzNCeDlFbW8xZ2xSL3JCaUZwMU5JdEJVelZNRXZDL2NpM1hsdS9U?= =?utf-8?B?WmhQR1ZJdkk2RnVVSmJ3NERTa2oxQTFqRUhQWGhBOU80TU9IQnk5ZExVRkc4?= =?utf-8?B?Q1VGTE5WYWUvcXpCZW84THhTVGZPRzVpOXYzdjNMcWxTRXFYTnk5aHRBOHll?= =?utf-8?B?eEpQNU9UWi9HZ3RpNHBVYUpGamNUbGVVQlh3dm5YWlRMWnFHc3cxTER3am9F?= =?utf-8?B?cTMrb1NVNHpHWU44OCtMTHhwVGZnQ0svczJBL3BCWXJNZ3djN0Eybk4wd2Jk?= =?utf-8?B?QnRhK2JPTG9lTzR4VS91NGRzVVdYZGZFUU1QaGlIeS95V3RUSHF2VnhGUm9P?= =?utf-8?B?Uk53UTJkblVQQVMyTjFOd3pEdmNtektPcC96b2ovckhZUmFUaGhVZWJLTks2?= =?utf-8?B?emluNzFOT2hham1CQ0MrMXN5ZVpmN0NpRG1zbzVxM2J2Qk1TUWRPOGVEL2lo?= =?utf-8?B?UElheTQwSkR3dmcrMDVSUjdqNTk3YzlQTzlQcFVQOVgyYVZDNkVFZWpGOTd4?= =?utf-8?B?R3Z4MHNuVDVpTTlNcUxLRGVpYk1XUkxpdE5XNGlML0VCbVJXNU94dmZxMmI1?= =?utf-8?B?YnJUU05PdFVPb0FjZWdjUHlBbi9EblVMcklGYTJ3V21pVDhkSC9zcUtCdkdz?= =?utf-8?B?NkM2MzJyaDRLVnBMTkZHeVVNWTEvOGxJZWticzFzWWdOVHo1MDFLcjNvaWtr?= =?utf-8?B?TVpUeEhsUS91bGZoc0MzejZsaWVsakJqdk16blVQSEJYZTRHUEl3b3c4VVl0?= =?utf-8?B?R3FIaDBIVjBxK0R2elNzVjJLbG1DTUtJbWhpaCtQS0dUcWZNcmpTTWlqQVNM?= =?utf-8?B?dW5yQ09xaVk4SE5KQW1BTjNDM2swSkFjM3J1WlBOTzlQcG51MkdRMjNNSnFT?= =?utf-8?B?L0hiQ3QxZ3pvR00yVUUwdjJ0cjhoQzRhZm1lY042R0p4SmxhK21EdE42U2JG?= =?utf-8?B?N2JoamFZRjdHcjY0NWRIaXB4Yy9YR0NWeW5PVHNPaXpSZTNFNDBhei91dW5q?= =?utf-8?B?cERhMFNodVE0TXIzbFpHWW44RzZZamx4REdzZlJZUjRLUWlIWVVnRW5qZWJy?= =?utf-8?B?SkYxTnpMaDB2aGxUZ2VDNlh4b2pBZVZyckJUT0tkdmRUdzVndHdYWVoyL1Jh?= =?utf-8?B?ZFhKUjhEdFVoazBCclltdnVScmliN2QwRzIvTjhwNkNuYzI2TmdJNVkvTndz?= =?utf-8?Q?5A5/aZwkxuIrvAbuNyD2QaQ=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <19CDF95DD54768499DE4E51DBE5FD219@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4a3a856-a739-4791-3cf9-08dabcb232c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 09:11:16.7759 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4UwoQKYD5erEDEeZWwJo1Q785TqYMB4m2g6p5Q7H0QhU73A3OYKCYqbF7ewCWowQo6HSYcGkFv40cBMJJbTznRPBpQOhyUkWNyD/XRLVo6k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5774 DQoNCj4gT24gMSBOb3YgMjAyMiwgYXQgMTc6NTksIEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9r QGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gDQo+IEVkd2luIFTDtnLDtmsgKDIpOg0KPiAgeGVu Y3RybC5tbDogbWFrZSBkb21haW5fZ2V0aW5mb2xpc3QgdGFpbCByZWN1cnNpdmUNCj4gIHhlbmN0 cmw6IHVzZSBsYXJnZXIgY2h1bmtzaXplIGluIGRvbWFpbl9nZXRpbmZvbGlzdA0KPiANCj4gdG9v bHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sIHwgMjUgKysrKysrKysrKysrKysrKysrLS0tLS0t LQ0KPiAxIGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkNCg0K QWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4N Cg0KDQo+IEl0IHdhcyBjYWxsaW5nIHRoZSBYZW4gZG9tYWluZm9saXN0IGh5cGVyY2FsbCBOLzIg dGltZXMuDQo+IE9wdGltaXplIHRoaXMgc3VjaCB0aGF0IGl0IGlzIGNhbGxlZCBhdCBtb3N0IDIg dGltZXMgZHVyaW5nIG5vcm1hbCB1c2UuDQo+IA0KPiBJbXBsZW1lbnQgYSB0YWlsIHJlY3Vyc2l2 ZSBgcmV2X2NvbmNhdGAgZXF1aXZhbGVudCB0byBgY29uY2F0IHw+IHJldmAsDQo+IGFuZCB1c2Ug aXQgaW5zdGVhZCBvZiBjYWxsaW5nIGBAYCBtdWx0aXBsZSB0aW1lcy4NCg0KQXJlIHRoZXJlIGFu eSBhc3N1cmFuY2VzIGFib3V0IHRoZSBvcmRlciBpbiBlbGVtZW50cyByZXR1cm5lZCBieSBkb21h aW5fZ2V0aW5mb2xpc3Q/IEkgdW5kZXJzdGFuZCB0aGF0IHRoZSBjaGFuZ2UgbWFpbnRhaW5zIHRo ZSBjdXJyZW50IGJlaGF2aW91ciBidXQgYXJlIHdlIGV2ZW4gcmVxdWlyZWQgdG8gbWFpbnRhaW4g dGhhdCBvcmRlcj8gQmVjYXVzZSBvdGhlcndpc2Ugd2UgY291bGQgcmV0dXJuIHRoZSByZXZlcnNl IGxpc3QgYW5kIHNhdmUgbW9yZSB3b3JrLg0KDQrigJQgQw0KDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 02 09:29:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 09:29:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435707.689402 (Exim 4.92) (envelope-from ) id 1oqA4D-0001V0-8J; Wed, 02 Nov 2022 09:29:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435707.689402; Wed, 02 Nov 2022 09:29:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqA4D-0001Ut-5I; Wed, 02 Nov 2022 09:29:49 +0000 Received: by outflank-mailman (input) for mailman id 435707; Wed, 02 Nov 2022 09:29:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqA4B-0001Uj-HY; Wed, 02 Nov 2022 09:29:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqA4B-0006Pe-Er; Wed, 02 Nov 2022 09:29:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqA4A-0007uv-LZ; Wed, 02 Nov 2022 09:29:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqA41-0002JA-0n; Wed, 02 Nov 2022 09:29:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9HVWxBEMQXVW2cH0qTKQj5qt7vVsDoonXYoLwPm1IW8=; b=o8Vo59VjQcRyv62jN9+uHETiAo vZCREvl2TBcquzeBzjbGvuvifgcbdZxpmJuHkCP1BZTUbYHPKJxPpLe4v69ZZjuIGrwWmn29+vq5s Cz8WWmbC3sSyDR1X/vlxM9lhr9Udzeq19UjqthUGgy2wEcUlIYanNTgREu2FMF88J+Q0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174573: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-shadow:guest-saverestore.2:fail:heisenbug qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=18cd31ff30883707408c7d6d952310189903939e X-Osstest-Versions-That: qemuu=5107fd3effb1cfec3b96d9e819f1605048640e31 From: osstest service owner Date: Wed, 02 Nov 2022 09:29:37 +0000 flight 174573 qemu-mainline real [real] flight 174581 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174573/ http://logs.test-lab.xenproject.org/osstest/logs/174581/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-shadow 19 guest-saverestore.2 fail pass in 174581-retest test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail pass in 174581-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174560 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174560 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174560 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174560 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174560 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174560 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174560 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174560 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 18cd31ff30883707408c7d6d952310189903939e baseline version: qemuu 5107fd3effb1cfec3b96d9e819f1605048640e31 Last test of basis 174560 2022-10-31 20:38:40 Z 1 days Testing same since 174573 2022-11-01 15:38:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: BALATON Zoltan Icenowy Zheng Ilya Leoshkevich Mark Cave-Ayland Richard Henderson Stefan Hajnoczi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow fail test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 5107fd3eff..18cd31ff30 18cd31ff30883707408c7d6d952310189903939e -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Nov 02 09:32:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 09:32:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435713.689412 (Exim 4.92) (envelope-from ) id 1oqA6d-0002rp-Lz; Wed, 02 Nov 2022 09:32:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435713.689412; Wed, 02 Nov 2022 09:32:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqA6d-0002ri-JK; Wed, 02 Nov 2022 09:32:19 +0000 Received: by outflank-mailman (input) for mailman id 435713; Wed, 02 Nov 2022 09:32:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqA6b-0002rb-M5 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 09:32:17 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3c4cb807-5a91-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 10:32:16 +0100 (CET) Received: from mail-dm6nam04lp2047.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Nov 2022 05:32:13 -0400 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by DM6PR03MB4972.namprd03.prod.outlook.com (2603:10b6:5:1e4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Wed, 2 Nov 2022 09:31:11 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::a093:1d6d:9e9:cbfa]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::a093:1d6d:9e9:cbfa%5]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 09:31:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c4cb807-5a91-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667381536; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=2DhY5H+/0wbCMl95XLJ2Ekls9iBh3MHnpW/yKvtLgaM=; b=NAcDWTcLOgDqiGreyFZ2g9K2twCxpRW8WY3jNdcLpqLv11dC/xUc+WhG QDCOm7VC1f7M/Pv8Csuz+mbvIfsKAi8tuKSTgt3jzlEETLOk9a7bsnTb+ Oxm9OP5eHGyC3HFpGVQ/b8Obw/f1osYtXxKkoL5A1cDDwEgSyz/2W0Nug 0=; X-IronPort-RemoteIP: 104.47.73.47 X-IronPort-MID: 84416478 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:V82CsqprHmY+0XFbSp6y3nBwt25eBmI8ZBIvgKrLsJaIsI4StFCzt garIBmDOa3cY2f0LtAkPdnlox5T7MeGy95lS1A6+X88ES5G8puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W5wUmAWP6gR5gaHzyNNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABRSb0yi3f3t+/GQGvtNgeQvccLMZZxK7xmMzRmBZRonabbqZv2WoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+OrbIW9lt+iHK25mm6Vq nzH+SLlBQsdN/SUyCaf82LqjejK9c/+cNJOSOTmqqE66LGV7kJUUCQqbUOWm8KCpGOkWs1aC RYpoiV7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3Oc6TCIn/ kWElNToAXpoqrL9YW2Z3qeZq3W1Iyd9EIMZTSoNTA9A79y9pog21k7LVow7TPHzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQGzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:kAA6FK4np4yXttbTIgPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+ O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCfx+g4uuspx37 lM2H/cv51LDQnYlCC4/NTQUQp2/3DE6EbLAYYo/gNiuKYlGchsRLYkjTVoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+ CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5 jFWEMwjx9HR6svM7z64HRmyGG/fIzmZ0Wd9ih33ekIhpTsALz2LCaEVFci18O9vvR3OLyoZ8 qO X-IronPort-AV: E=Sophos;i="5.95,232,1661832000"; d="scan'208";a="84416478" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HXKatotv+pKx1Y/04ERK2tzaxPOg/hIgMHNVAIOL/xFMaYZYLPpZePZgMBqms+xmU71LUQywCapNPu070KgN9PMDcKx8gQsVeWJcRwmcTfU8VSFFsy4fjuTopJk1dvO+TT6tX8no7gRN9HV8o4j2KgB10VRjbwlyE/vv4M1nrpIu53jQNdEZECSrAlaN2Gpg9FT7ULRSaevjBG7f+bLvIt0zAjPM7GmYpqA2dCG8fyN1xw6jgho0cKTNQbu7dp2iqYnb0IqeR4gz1mdSr4LQcbnXXgdYUSPwRGdlzto3UvHaKKurgBwhnvJekV9BhmN9v15pSFESOGH8wIQuhzyy2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2DhY5H+/0wbCMl95XLJ2Ekls9iBh3MHnpW/yKvtLgaM=; b=QGrSISuxwoLjZlxdGZu2Zggem5/jNPtje5RpXgKXJXdeFNdIWKbWnEP4JnqCRNmjj97H/Y14pK//WAUFAUYTVQltwZXpOzsTiF7zX9pjG9CWuXTKYxXwgiPMRKIPSWA6qGy0sgteo2rYrvybcH04S5ubsXqSeyej4WxUMxCvZexGLSUa7NeY/tC5Z4tjOvaNd5QlyouijV44xSeTOBaeFjuCZGdpxHBEi6XLVzPMm2Y1WpCoXLVQIRgMWvS8ux+pyZdUw3ybLidsx0O8hEpzanPKL2oTQ05027LMrzM5AvyYF+DY7fQoJ6d4lcPrUxDtd/Z5fdYpSLez97gc9q0rew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2DhY5H+/0wbCMl95XLJ2Ekls9iBh3MHnpW/yKvtLgaM=; b=m61A+Lk3i2U8IGsjSSTxtLpFZp2cMK9qBhBwOECX/uxzVapkjqe+Hit+vCh0/j3+fewAldKQDB+9sQIG/2k8YR77f+O2YXViLJQlUtnJqv4h1cokxhKYH/CBZrhZrWlFnIh/d3aaeArafvH4cE9QXGMzo8Wu16ZDcs9dlO/ASFg= From: Edwin Torok To: Christian Lindig CC: Xen-devel , Pau Ruiz Safont , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist Thread-Topic: [PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist Thread-Index: AQHY7hu6Hfeu3cnxk0m/6L4xh+MTgK4rWegAgAAFhIA= Date: Wed, 2 Nov 2022 09:31:11 +0000 Message-ID: <068F2C45-AC7C-407E-B6D7-90D4E98FBB76@citrix.com> References: <1FD039A8-AE3A-4D6E-A2E9-F446FD6653DD@citrix.com> In-Reply-To: <1FD039A8-AE3A-4D6E-A2E9-F446FD6653DD@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|DM6PR03MB4972:EE_ x-ms-office365-filtering-correlation-id: e8298f17-7105-4185-410e-08dabcb4faf1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AM4bbTnQlajEHd2Lfi3FnMVqsAvtxWhE9UZ3HD5XZHmHzIrQPvo46Kc7UeXx7pFEQKcUDfg86GJm5VSnUwV4sbibtjNSFwQIGgjPO6qBVn0UtPrWpZFzZ6PkVh1P15sRcpMebjR/zwTvVGDrq5ANfGcmW8PKxhwqx7GoZB905joK5//aN2aDuuKtpiD4Xow6TsKpAwusVAUjhSijGIZhBEp/YXEZerL1GVcCrYglQK9ZWPULHpSIuBXwUpXst+VGmUFj2h8N/dAU2l9R1JxY8KUefCixGNhLWtPeVowVjNteYv0G0keRxHem6xAOt361mzl3rnDUF6jYQ0K7QpdT3uD0qYeKf76WjE7dQsS1OUmWfkmJBxnW3nfkN27U5+K/0dsrN4+2w1OiHnWzyZEJtNe3J6IaApu8HmDM59j5AmJ3eVxB3zRdL8mFxeUyxQnwIkMX2uiThXxDA2DkEiF1M5FeLl25mOWVfGwdSrkRkw1pv6TcW50nWlj1dwO1LxL2+AJhTIAGMvk4YYiq1PDl3G2QTGVeGfowqbwGplcEqiN1xfYlx1qivqKnAKoUnZd0FXL89aX+iZ6lQRSAEHZbjk4i7A5XvBi097ioNYHfXDmq/ux+9gZzTeI27yxxsBRGlGtkYMJXVRhCaCEAd9E9v4lgiHVoTUdjsE/kcj8rKWIurjxONxmCPD7zej3xY0AH/XYvyDodpx8apstKQM4x30fZsFyl1BM0kW8Xrcfxw8/Zn1O4pgGrxDthycrIjLRGu/xVecoPkoEymB5GSu6KD93yuGgUvhfAck6346n8QjQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(39860400002)(136003)(376002)(396003)(451199015)(38070700005)(122000001)(83380400001)(33656002)(38100700002)(86362001)(66946007)(82960400001)(8676002)(76116006)(91956017)(66556008)(37006003)(66446008)(64756008)(4326008)(71200400001)(41300700001)(6862004)(2616005)(478600001)(66476007)(54906003)(6636002)(316002)(6486002)(186003)(66574015)(6512007)(2906002)(8936002)(5660300002)(53546011)(26005)(107886003)(6506007)(36756003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?a0wxRkQ5V1Jmd0FVNGpWMkp3YVQ3RFhJWUFyOHZ2QXR2RzdQV0RKckZUbjVn?= =?utf-8?B?YjA1RHQ4S0V3TXB5V3RmZmVJVXFZa25DMFgyb0VzTnZIVjEwUVJlSm4wTlUy?= =?utf-8?B?djIybU14Nityd05ZTFdmRVdZT2pKakZza1VwNUNFSEZCb3RwazRvbW9yYVRU?= =?utf-8?B?ZC9jU0tQNUlSOTB0M25NMlVuN1FFaFVRZDBnR1k3NDlXTWVoZDVkS3JsUE1T?= =?utf-8?B?cDZyUzAwbXlsOXJrdEpRYmsra2NTZGcrRnFyYktrVHlLSFB1UXIrcnJrSUlN?= =?utf-8?B?NncveEFCVTRUQjhXUnR1YWFDbk10dXFDZGN2Sk4xaFVEWDB4Q1lCeEF4dy81?= =?utf-8?B?M3djbE0wa1FTWXpROUpJU3BFNThvdEtDN0NPVzhkMkRvK0xUOG04aG5pbk9X?= =?utf-8?B?VjM2Qkp3d0tsTTRmNnZQV2I0TFZlK3hDc2cyMWxyU1ZxZFJnbXNWRDZKaS9Z?= =?utf-8?B?aVM4WGlUbnpVR2VBZEJhOGdweGdnekxqNWY3Qmd1S1k5ZUNqVFMyL2FiWFZF?= =?utf-8?B?Y0ZtSDVOL0F6OFZNckpRb0lzWXpoVDhjZ0ZiSTJUODJlZUNrMHF0R0NNOUJG?= =?utf-8?B?V0RnVXd1YVY1a2l2WnhiTHoydmIrR21kMTNqcEV6OWtQYUNFL0E5V2k4T3V1?= =?utf-8?B?RU9iUVhrTmhZeXQrbDNKNDhYYVp6azljcE1Wc0xBNnExWE9SeU9hRWlUQUcv?= =?utf-8?B?M1hKME93UDRJSXAxd0labHlyL1JXQks2S0wybWVtZXVvV2x4TzFHaDdQS2dR?= =?utf-8?B?ZllFQ2VCZHNFYUk2WHZKeWdLMW40RzN2SUJvRjEydkZVb2VKaDNPYm44L0xE?= =?utf-8?B?VE50SXBKOXNlMHRqcHc3SEJLRjdhQ3FUNlB5SFdDRVd2Z0ZDTVJ4V1VwbW1G?= =?utf-8?B?R3lBcTVOTVhMSmdMRzkxQmtQYittbWwyV2RaL0sxTlpUTmRKY09TSFUyRkQ5?= =?utf-8?B?enBiaGpSUExrd0NSalhyeEhNUjFURXBHTG41eDh3UVg0dHRLMHBpalpsbmc5?= =?utf-8?B?c20rdWdvR1U3c09BV2ExSDVUdkdMQzF6V0FWWmxOQ0FoR3J4VzhUaFhYckFi?= =?utf-8?B?OHh3Y3hZbXBQS3dQUzE4WlRXUU1hWllRVlFRdDFKOTdkRk9nVkdoOW00cWQ0?= =?utf-8?B?SVZEczM4WTd4ZlVqR3FLVmNvMUYzZkdoYUNJSlF4dEFTNEUvL2wvTHg1UEt4?= =?utf-8?B?ZGNkVDU2RXZxUStKeWw5eEhJNE8xVnVObXZLeDNEVlJLSmV1VUloSmlOYVY1?= =?utf-8?B?QnpHWUNMbFlkeEl3MHdVRDIxL0ZXREROb2VBRE4xdlRlZEV6SG9oK1FWb01r?= =?utf-8?B?MUc3cCtOQTBWeTg2K2ZLQ1pOMjZkTUcxeU03dFFTcUdldzJjRms1Rm5QejVm?= =?utf-8?B?SGF1UkxuZlJseEZRM0E4OWlnVFVwTEpWd29ZM3ovWGdzZksxbEFaYlRkTWpL?= =?utf-8?B?aUcrYU80S2ZocXVjQTBhakppRUtUb2JpQThpOFIvNHdhRWV6VVBoY2pTZlpy?= =?utf-8?B?dktvbmplMHJsMm13S2tEVTdzR0lrWHhtRUhvQTViYlN3YjI2RUtESWhjTThk?= =?utf-8?B?MzVrZldTcm5qbkFxd2tVLzJXSnRlQlBtcExUNitpdW9mVEx6cE5tdXNuL1Fl?= =?utf-8?B?ZG82YWdWYmhQd1JKSmZkRnV0aGc1aWE0alhWQ2V3eFlHK3djTDFvUDc0R0dn?= =?utf-8?B?K2V5NWRnTXgrbXpMeGZKN09uczNyK2ZIdWpNc0FNZDFBMmZGOTJTemk1Tk5X?= =?utf-8?B?L0FYYnpJWWJ6dWozcENDNkowUlJ6QTAwbGVDUW9pQ1p0ZGxkTE5Wb1o3SVN3?= =?utf-8?B?RHY0MTUyUlNXaGlINDdvK29DQTRoaTZxWXBXZHoyczhFdjZ2amhBQlVnZWZm?= =?utf-8?B?amh2T2QzT0Ryak5JZW9YNFpoNlVxOUI1alpsL3pPWnBBaU9IVFVlckR5SEJx?= =?utf-8?B?T1RYdXRwMHV5Tm5oZlRVcUhSeTRncWIvZmwxbmltSXUrRlVzaVY0NWVmbllj?= =?utf-8?B?ekovemczeTJpbHJtVGt3U1VaS2YwN0FjTURqUTVMYWtGU1B3RmV0QWpMSG9K?= =?utf-8?B?TGhEdFl4UWxjcmx2WEg5S0dFTWdrU0g3NHhnUE9qNlRDYnRYSmRaeFR1MmVG?= =?utf-8?B?aVdwUU9Cb28vRldUbFd1bWxnaWlKamdLcTFDTHRLWlljRktaQkNSVEZjSHZN?= =?utf-8?B?d0E9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <04650B8CDCD38641B909FAC469ABF46B@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8298f17-7105-4185-410e-08dabcb4faf1 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 09:31:11.6127 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4ZIlphXd7uBT+YfqO2fbB/WJgTAerpeXNLQ36NezV5hV4kX9h9X8kshUfrnd3cMjnsNmZiELCywlSPmdrbq+IA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4972 DQoNCj4gT24gMiBOb3YgMjAyMiwgYXQgMDk6MTEsIENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlh bi5saW5kaWdAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiANCj4gDQo+PiBPbiAxIE5vdiAyMDIy LCBhdCAxNzo1OSwgRWR3aW4gVMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4gd3JvdGU6 DQo+PiANCj4+IA0KPj4gRWR3aW4gVMO2csO2ayAoMik6DQo+PiB4ZW5jdHJsLm1sOiBtYWtlIGRv bWFpbl9nZXRpbmZvbGlzdCB0YWlsIHJlY3Vyc2l2ZQ0KPj4geGVuY3RybDogdXNlIGxhcmdlciBj aHVua3NpemUgaW4gZG9tYWluX2dldGluZm9saXN0DQo+PiANCj4+IHRvb2xzL29jYW1sL2xpYnMv eGMveGVuY3RybC5tbCB8IDI1ICsrKysrKysrKysrKysrKysrKy0tLS0tLS0NCj4+IDEgZmlsZSBj aGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQ0KPiANCj4gQWNrZWQtYnk6 IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4NCj4gDQo+IA0K Pj4gSXQgd2FzIGNhbGxpbmcgdGhlIFhlbiBkb21haW5mb2xpc3QgaHlwZXJjYWxsIE4vMiB0aW1l cy4NCj4+IE9wdGltaXplIHRoaXMgc3VjaCB0aGF0IGl0IGlzIGNhbGxlZCBhdCBtb3N0IDIgdGlt ZXMgZHVyaW5nIG5vcm1hbCB1c2UuDQo+PiANCj4+IEltcGxlbWVudCBhIHRhaWwgcmVjdXJzaXZl IGByZXZfY29uY2F0YCBlcXVpdmFsZW50IHRvIGBjb25jYXQgfD4gcmV2YCwNCj4+IGFuZCB1c2Ug aXQgaW5zdGVhZCBvZiBjYWxsaW5nIGBAYCBtdWx0aXBsZSB0aW1lcy4NCj4gDQo+IEFyZSB0aGVy ZSBhbnkgYXNzdXJhbmNlcyBhYm91dCB0aGUgb3JkZXIgaW4gZWxlbWVudHMgcmV0dXJuZWQgYnkg ZG9tYWluX2dldGluZm9saXN0PyBJIHVuZGVyc3RhbmQgdGhhdCB0aGUgY2hhbmdlIG1haW50YWlu cyB0aGUgY3VycmVudCBiZWhhdmlvdXIgYnV0IGFyZSB3ZSBldmVuIHJlcXVpcmVkIHRvIG1haW50 YWluIHRoYXQgb3JkZXI/IEJlY2F1c2Ugb3RoZXJ3aXNlIHdlIGNvdWxkIHJldHVybiB0aGUgcmV2 ZXJzZSBsaXN0IGFuZCBzYXZlIG1vcmUgd29yay4NCg0KDQpNYWludGFpbmluZyB0aGUgY3VycmVu dCAocmV2ZXJzZWQpIG9yZGVyIGluIHRoZSBDIHN0dWJzIGlzIHVzZWZ1bCB0byBiZSBhYmxlIHRv IGV4dHJhY3QgdGhlIGxhcmdlc3QgZG9taWQgc28gd2Uga25vdyB3aGVyZSB0byBjb250aW51ZS4N Ckhvd2V2ZXIgd2UgZG9uJ3QgbmVjZXNzYXJpbHkgaGF2ZSB0byBtYWludGFpbiB0aGUgb3JkZXIg b24gdGhlIGhpZ2hlciBsZXZlbCBmdW5jdGlvbiBhdmFpbGFibGUgaW4gdGhlIC5tbGksIGl0IGp1 c3QgaGFwcGVucyB0aGF0IGByZXZfY29uY2F0YCBnaXZlcyB1cyB0aGUgcmVzdWx0cyBpbiB0aGUg b3JkZXIgdGhhdCB3ZSB3YW50Lg0KDQpBbHRob3VnaCBwZXJoYXBzIHVzaW5nIGFuIGFycmF5IHJh dGhlciBhIGxpc3QgaGVyZSBtaWdodCBiZSBiZXR0ZXIsIGFuZCB3ZSBjb3VsZCBtb3ZlIHJlc2l6 aW5nL3JlYWxsb2NpbmcgdGhhdCBhcnJheSBpbnRvIHRoZSBDIHN0dWIsIGFuZCBoYXZlIGp1c3Qg YSBuaWNlciAoYW5kIHBlcmhhcHMgZmFzdGVyKSBpbnRlcmZhY2UgaW4gdGhlIEMvT0NhbWwgQVBJ LA0KYnkgcHJvZHVjaW5nIGxlc3MgZ2FyYmFnZSB0aGFuIGxpc3RzIChhIHNpbmdsZSBBcnJheS50 IGFsbG9jYXRpb24gcmF0aGVyIHRoYW4gTiBsaXN0IGVsZW1lbnRzKS4NCihBbHRob3VnaCBJIGRv bid0IHVzdWFsbHkgbGlrZSBwdXNoaW5nIGNvbXBsZXhpdHkgbGlrZSB0aGF0IGludG8gQyBzdHVi cywgZm9yIG5vdyBJJ20gaGFwcHkgd2l0aCB0aGUgcGVyZm9ybWFuY2Ugb2YgdGhlIGNvZGUgYXMg aXMpLg0KDQpUaGVyZSBhcmUgbW9yZSBpc3N1ZXMgaW4gdGhlc2UgQyBzdHVicyBpbiB4ZW5jdHJs LCBJJ2xsIGJlIHBvdXJpbmcgb3ZlciB0aGUgY29kZSBhbmQgdHJ5IHRvIHNlbmQgYSBmZXcgbW9y ZSBwYXRjaGVzLg0KDQpCZXN0IHJlZ2FyZHMsDQotLUVkd2lu From xen-devel-bounces@lists.xenproject.org Wed Nov 02 09:32:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 09:32:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435714.689424 (Exim 4.92) (envelope-from ) id 1oqA6h-00038t-1o; Wed, 02 Nov 2022 09:32:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435714.689424; Wed, 02 Nov 2022 09:32:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqA6g-00038j-VA; Wed, 02 Nov 2022 09:32:22 +0000 Received: by outflank-mailman (input) for mailman id 435714; Wed, 02 Nov 2022 09:32:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqA6f-0002rb-C6 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 09:32:21 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3ed6d257-5a91-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 10:32:20 +0100 (CET) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-653-Afke9pNBP16lQmfvJhX3Cg-1; Wed, 02 Nov 2022 05:32:15 -0400 Received: by mail-wm1-f69.google.com with SMTP id h8-20020a1c2108000000b003cf550bfc8dso838507wmh.2 for ; Wed, 02 Nov 2022 02:32:15 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id x21-20020a1c7c15000000b003b492753826sm1361990wmc.43.2022.11.02.02.32.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:32:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ed6d257-5a91-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667381538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qCDrX0xKXyu8erIDNjxDiJKuT0hxZZKKE3HXuUGBVDQ=; b=gOVvVa96O5EjRk1UGNXS6akGr9XDQjQiqdmQBHCQa+tMXWjo4EGQzsrYKTW8LkCTjt8VaT mOIldExhNaLbRlo5rI+VMLayI2ICD5dw1M0bM9yV2WHUb7xS2SyWZO6UVluK7IToeQE+dh Q7CC5UGJ7LzJwPOaa/lrTnivgU+iW1I= X-MC-Unique: Afke9pNBP16lQmfvJhX3Cg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qCDrX0xKXyu8erIDNjxDiJKuT0hxZZKKE3HXuUGBVDQ=; b=N7VdQy8PwyFGfqMDXnjGXTpYa+s33m7kTeLszSZxcy3m1JrYzeMG/TKjrDCdJMFA4Z mnodZeHnIVH9d8d0lsjtuRZ/rmD+8WN4D8Yee9DpN4bYqbQdQIa+AdF57ItqVgZiGtpI r8enc4Qvx2sS+KdOsLFVsxp6Gv/F5PWXb+0WkbJe1Z5hPVEH1eU45+ID21+leegvQSNp a7LSFZzFKOSPlZ/fjgGPSOOkqK7SH7BFndfLsBWvoVO9E1Gw0ouIV4mMeq8v67seSTyJ btkpRpYKRdZn1zy6A/XGo11xB+r3+lRxGdVJEz8bumWApllLbT6idGzogTqMtlDFq2S4 VezQ== X-Gm-Message-State: ACrzQf387en3d7ulZCwrJ6d3a3hPlje7jkfiZ/e9VAfNvz2NhXYZha5w ACGlUxyvTX/B9I8dOeYiBccamjHdLLy0Y5GQ8U5uGsw+UTr3PDB/9QcvC6nTA2FsltBj7Z37Pvt OTEmASQM2VBVEvJHnEG0UsJY4F1Q= X-Received: by 2002:a05:600c:6023:b0:3cf:7dc1:e08e with SMTP id az35-20020a05600c602300b003cf7dc1e08emr5443619wmb.154.1667381534285; Wed, 02 Nov 2022 02:32:14 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7iks5yFnak5X2iZPcs6wSoPN4c8RmVdgyjVaQzUQOEwDY0j8GZM7MD/vLKrS0XyFefd22bEw== X-Received: by 2002:a05:600c:6023:b0:3cf:7dc1:e08e with SMTP id az35-20020a05600c602300b003cf7dc1e08emr5443583wmb.154.1667381533975; Wed, 02 Nov 2022 02:32:13 -0700 (PDT) Message-ID: <3ab32fc3-f2aa-1b42-fd87-557482ab56d5@redhat.com> Date: Wed, 2 Nov 2022 10:32:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 17/21] drm/fb-helper: Perform all fbdev I/O with the same implementation To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-18-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-18-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/24/22 13:19, Thomas Zimmermann wrote: > Implement the fbdev's read/write helpers with the same functions. Use > the generic fbdev's code as template. Convert all drivers. > > DRM's fb helpers must implement regular I/O functionality in struct > fb_ops and possibly perform a damage update. Handle all this in the > same functions and convert drivers. The functionality has been used > as part of the generic fbdev code for some time. The drivers don't > set struct drm_fb_helper.fb_dirty, so they will not be affected by > damage handling. > > For I/O memory, fb helpers now provide drm_fb_helper_cfb_read() and > drm_fb_helper_cfb_write(). Several drivers require these. Until now > tegra used I/O read and write, although the memory buffer appears to > be in system memory. So use _sys_ helpers now. > > Signed-off-by: Thomas Zimmermann > --- [...] > +static ssize_t __drm_fb_helper_write(struct fb_info *info, const char __user *buf, size_t count, > + loff_t *ppos, drm_fb_helper_write_screen write_screen) > +{ [...] > + /* > + * Copy to framebuffer even if we already logged an error. Emulates > + * the behavior of the original fbdev implementation. > + */ > + ret = write_screen(info, buf, count, pos); > + if (ret < 0) > + return ret; /* return last error, if any */ > + else if (!ret) > + return err; /* return previous error, if any */ > + > + *ppos += ret; > + Should *ppos be incremented even if the previous error is returned? The write_screen() succeeded anyways, even when the count written was smaller than what the caller asked for. > /** > - * drm_fb_helper_sys_read - wrapper around fb_sys_read > + * drm_fb_helper_sys_read - Implements struct &fb_ops.fb_read for system memory > * @info: fb_info struct pointer > * @buf: userspace buffer to read from framebuffer memory > * @count: number of bytes to read from framebuffer memory > * @ppos: read offset within framebuffer memory > * > - * A wrapper around fb_sys_read implemented by fbdev core > + * Returns: > + * The number of read bytes on success, or an error code otherwise. > */ This sentence sounds a little bit off to me. Shouldn't be "number of bytes read" instead? I'm not a native English speaker though, so feel free to just ignore me. [...] > > +static ssize_t fb_read_screen_base(struct fb_info *info, char __user *buf, size_t count, > + loff_t pos) > +{ > + const char __iomem *src = info->screen_base + pos; > + size_t alloc_size = min_t(size_t, count, PAGE_SIZE); > + ssize_t ret = 0; > + int err = 0; Do you really need these two? AFAIK ssize_t is a signed type so you can just use the ret variable to store and return the errno value. [...] > +static ssize_t fb_write_screen_base(struct fb_info *info, const char __user *buf, size_t count, > + loff_t pos) > +{ > + char __iomem *dst = info->screen_base + pos; > + size_t alloc_size = min_t(size_t, count, PAGE_SIZE); > + ssize_t ret = 0; > + int err = 0; Same here. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From xen-devel-bounces@lists.xenproject.org Wed Nov 02 09:37:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 09:37:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435725.689434 (Exim 4.92) (envelope-from ) id 1oqABd-0004Xn-Lj; Wed, 02 Nov 2022 09:37:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435725.689434; Wed, 02 Nov 2022 09:37:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqABd-0004Xg-IR; Wed, 02 Nov 2022 09:37:29 +0000 Received: by outflank-mailman (input) for mailman id 435725; Wed, 02 Nov 2022 09:37:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqABc-0004Xa-4M for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 09:37:28 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f4f4ee89-5a91-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 10:37:26 +0100 (CET) Received: from mail-bn7nam10lp2108.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Nov 2022 05:37:10 -0400 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by BN8PR03MB5059.namprd03.prod.outlook.com (2603:10b6:408:d9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 09:37:08 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::a093:1d6d:9e9:cbfa]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::a093:1d6d:9e9:cbfa%5]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 09:37:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4f4ee89-5a91-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667381846; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=YxfV0c7AEX9Hh2v2XHDix8xVkGkplYsJTKmoiFyajgw=; b=JdCpJZw/nXH11Qwcl0IArE6aYDJlvsSsrBiueA4dKLyVM2ZrHcZuCIVI VGgoeuwVPdGCSmiZ9x4b02niHTx9NF43mX9X8BJc4cavfiKH0Wc4mq4re ml9ILNb4AQcYXYXaW3tCb39R9OEXXS/JunOOoW6wh5s2a2XwvGy78QrQW I=; X-IronPort-RemoteIP: 104.47.70.108 X-IronPort-MID: 86523628 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ZG0jSqJXdoSYtLKyFE+R95QlxSXFcZb7ZxGr2PjKsXjdYENSgzRWy GNLUW2BMvuMYmvwf9gga4SwpksHucXcmIJhTABlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5wRkPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c56GUQUz 8YjcgkGVU6DgP+3+pyre+xV05FLwMnDZOvzu1lG5BSAVbMMZ8+GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VvpTGLnGSd05C0WDbRUtGGW8RT2Fqfv GXF12/4HgsbJJqUzj/tHneE1rGSx3ilAtJ6+LuQyqdmr3TKxUUvVUM0UnaCm/SI0na1RIcKQ 6AT0m90xUQoz2S7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZjJIdtEOrsI9Qj0uk FiTkLvBGjhHoLCTD3WH+d+pQSiaPCEUKSoIY3ACRA5cu937+thr3lTIU8ppF7OzgpvtAzbsz juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslRPdDNi1CAgbQD0ct9EQ== IronPort-HdrOrdr: A9a23:5/r3gau5uev87LVbnWIsURKB7skC1YMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIP/Z4StU z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfpWG0hYczAgNkGmpDr1L8Yqq iJn/7mBbU115rlRBD2nfIq4Xin7N9h0Q669bbSuwqfnSWwfkNHNyMGv/MWTvKR0TtfgPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5TOObFuF4O5gLZvi3+9Kq1wah7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm10xR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XXJ0vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLmzNV1wg2XwqUmGLEfQI5tllulEU5XHNcrWGDzGTkwymM29pPhaCtHHWp +ISeBrP8M= X-IronPort-AV: E=Sophos;i="5.95,232,1661832000"; d="scan'208";a="86523628" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XPcp0xFqBMQP/5IXjjU3em6lNIrCieC8NCWqXMUSbkzeDbeXsXb5FPXll8k5dJdz2dwsRrzILpnYcO98TJuRpOguVAYlodIyL8vmH2Z5OhZNLTWqg5USpRdIsEHbN0ZtZnSnjO402+xKAOGRp3UPjRXK5GduKym5oOs1OdWugaJch79KE+NXQMM6tcQOnZYaKvMwFkOA8R2sK8FweoG6wGRzLqyZEMwvMrwGPILijWNXR+etl/EnUfLxpMZ1LDz9NDjYWQlB8tbvCEpEtWgCrZ1IpZ9VgIXb/cK3VU2xXZuSKGOW+Pv+mmiNcI91fv8IsP0DN7RpqFgaapZ0Haq4Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YxfV0c7AEX9Hh2v2XHDix8xVkGkplYsJTKmoiFyajgw=; b=Kserjiw07Tmot/JVLSCDS2SeRL8BgZZN0V2+UsqRPMXRxZ2BH7Q3OYvKDHHi/myqSNJsebQNekSu0YyI0w3OZWqPNpMjLSYt7pCV7caJRdnJJIeO170xK5kqdFy9ni78auO35avEkzQGhIIG8qtxNJ58I7S1JcAdHlQWYnPvdIoa/Yc03Lg466TVMfwv+TMSlL7mnQUbQrn8yR/7mQ3Qkdfy3ren8y1KnctuXaKALHn12xcgQWVZ4Z97UCRsCzFHHlp2JLsB0m0HUKrK3RQeibNWILGJTELArmjofOteY9DC42ISCZiPHqsFxPVz6CgLmZo6ntaKiEy5xYBlcXfqDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YxfV0c7AEX9Hh2v2XHDix8xVkGkplYsJTKmoiFyajgw=; b=OJ0hzSbife2MA13ympKW13mfrF9Vk21WVq37M8j8eYpe05tQnb7+MHpKV1U/qUW0k5RaS3KfT5jFXOXnfgW6W7VdFI0D7Ar5iVzIb1E1xJeFXk9c1jxShz7kbzqk56iaO1/qZly8bKBd/LX2IkEuKig+Io0bCpTM5f9oAIzWRaI= From: Edwin Torok To: Christian Lindig CC: Xen-devel , Pau Ruiz Safont , David Scott , Wei Liu , Anthony Perard , Andrew Cooper Subject: Re: [PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist Thread-Topic: [PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist Thread-Index: AQHY7hu6Hfeu3cnxk0m/6L4xh+MTgK4rWegAgAAHLYA= Date: Wed, 2 Nov 2022 09:37:08 +0000 Message-ID: <38BF59DF-B5DE-4D12-895F-874C41D6B34C@citrix.com> References: <1FD039A8-AE3A-4D6E-A2E9-F446FD6653DD@citrix.com> In-Reply-To: <1FD039A8-AE3A-4D6E-A2E9-F446FD6653DD@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|BN8PR03MB5059:EE_ x-ms-office365-filtering-correlation-id: 68684270-49b2-47f0-ed4d-08dabcb5cf82 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Wnq6wQjg4I2UsszzQpnLezHA7Pw7uMN3EgPX+sSv13Kg0OYLmZ3coLu1Kz2qkkLLarKwwCbjZYlrt4UDH0XFNa6KGj8tQZqL3wM6MXeq0zi1oT3NnfIv43ywBo9We3mBGaPqRzgJMpqXVTsc701oXTNkTJmVizCtJrgsE6hM/7b5y9BuuLnnc6qb8yAUx1Z8t7UftyKmXksZB5PdviPeH1IBouXkMDlFc5B9jRukfW+Evj4Evy35L8Pn5qxaSpmgGHcdXGfStnfSh3OEuuGKkypcdz9wHc2LlUWmseaCoPTc/jEG9JPXO5afeCXGksP3WyPCRfjPdVLS+hkPa1qWCijvesPWRqugoQBywULNo6NewwArWL3elftttyqPHq5lhdqLMtlREdnG3K8CyAqSkxYOfyTOi+Aus70cm6+Jcsc5qI7914RmfpzdZDyifzy3EJbBVNM6jr6AoivSyA7+pFSAdfEfSwBbuQMOKKBvMu2nWktgMGUZobMm4Bc9TiwASVfyY2KTMs+1hSmnwg0Zj6gIcopf6+9WXSfsZVRgMxOgFT7glePOZCR/mDaT74C9r0q9j4pYiCYE4lbwEBpbcY4OzCdf1PH1ru2IYn13VOUljCPer+7pagM+bSaJJC8b+NwXkuBu325Ln/jP9hCkV/4cKW1LUUc8FaYa/lzrgX5rxCBA9f7LRrT8g4S2tJE0k6wcdNwkum8eN9G54+IL5EQHJEtHnIVjeuBU646l2VTGdgDkkdR6i+rpUKYYDnorABcBZ87tOxTxmFTtlSfrjaFYMxUNXOEY0N9nAoMEULI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(376002)(366004)(396003)(451199015)(36756003)(54906003)(6636002)(6862004)(5660300002)(6486002)(478600001)(38070700005)(71200400001)(83380400001)(2906002)(41300700001)(66946007)(76116006)(4326008)(64756008)(66446008)(66556008)(66476007)(8676002)(91956017)(37006003)(33656002)(8936002)(316002)(186003)(6512007)(26005)(66574015)(2616005)(82960400001)(38100700002)(122000001)(107886003)(86362001)(53546011)(6506007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?V1lMUWRhMWJjUzRKRUZlRzl5M2dDdFZUY2lrckhPVHArYlUvT0Z2TmMxN1hx?= =?utf-8?B?ZjBwUlBkY0dsRjlNdENqYXpvSTRwdDZQQzh2YnBPcENkS1RRU25MWDd2TXUv?= =?utf-8?B?QkUrYzhDZHo4T282dFRvTjBQSTgvcDFLdTNob3U4UDVzWDJRNlBNdW0xU0RC?= =?utf-8?B?S1FrYnNjQTlBT25nbmQyVStDT213Z3dVTGpzNC8yZE5rZ1FMZUVwSXNqeHdR?= =?utf-8?B?b1h5ZDJ2STVWWUNuQnNISmpKRlJ0eW8wNVdBaHZBMXVWMkdrRHBvZ3lyaE4y?= =?utf-8?B?NmRjMTEvYXZ5Y3JUYmJPWkRhRXBGNjJIK3RpeTVxNEVjVmFoOHlRVXhnWEFG?= =?utf-8?B?aVZYdkQvZDhTMTF6aURIK2Y0TnZ1enlIUGNaWDdNNHRROGxicTVDa1V2ZnVo?= =?utf-8?B?RG1WVnROUnJNeGFObEdINHZuMG4xSnlkOUdIY2FDYzRWeW9BZUFwR2RKQkV0?= =?utf-8?B?MHEySHoyZDdwQVJROEFTRk02NWhoamxPWDhqTUF2SFBkQWZYbXk4SUFkcDJE?= =?utf-8?B?UXdKN1IxYmFhKzlYZEJNL1hsNlVJWHY1RFdhMTVDTTk1TDB0ajZPQ3JSckl4?= =?utf-8?B?M1dmTzloYXhad2pZdTZ0MnhmRlhkN1dqK0RkNE1TVEl0blFtNGxYWTBPOHIv?= =?utf-8?B?RFNpNGZISEZWenExVTJaR0ZlQ0F0QWpjTUc3Ujc1QlRLSmZ0NHNjV29nTURv?= =?utf-8?B?Wm9leUNlb25lRmFCOEFYWHlIeFhHd0ZReElybkFWQVhLVG1nTS91L0NGSUlJ?= =?utf-8?B?TTZ3VjlCek5wT3VuZXM3cnAzTjkxL1loNkxUMHYwTkVBMytjNUN0dkhpL0Ev?= =?utf-8?B?MkNoL0dmbWZ0OEprQ3Bibkkyckg0cUZuaFFWTG1lMGVxUmVGRnhQY2ZkSG1p?= =?utf-8?B?bDVuZ2NheHlPNWZQMEY1djMvWElGVWh3NUJ4MWF3Tm5Qakt3KzZqMkl3SWsw?= =?utf-8?B?NUQyd2huc1gzSTFTRXpsSHp2VmFiUkRSVXlzTVFqTVlIOStPSEJkdjlpak00?= =?utf-8?B?bGxna3JOa0JpNEpQN2gycngwODhId0wzUG5ld2ZzZG93NWRhZ2txWFNnRjcr?= =?utf-8?B?TTJVMmZRVHM3Y2llNGtOQ3RyVjMvQm94dnpDL21zdGNGcEI5WEtzdjgrS09W?= =?utf-8?B?S2paMHBpT0QvTGRNV0R3ZU03ZFRDK3VLdEQ3amFWSDZGVXhOdnczS09UaDNR?= =?utf-8?B?NDZZQnZyLzhBdCszNU9OTXRJVnVuczk5SU4vQ3I5QVc0N2R3RTdoblFzeG1n?= =?utf-8?B?NGdCY1dYcFNBeDFMNFA1bVNXdWt6b056dG9MWkRjMVBlS1E2ZThuQ3AwRHE0?= =?utf-8?B?U1ArWXVBRGdEUGRNei94eHZ2YU1jOU55djNrdEltZTJmeGhIWSt2MU9RemVO?= =?utf-8?B?cVN0U3BrOUxhckQrL0dtVE9ZUmZGVHRjWjN6V2FXaHV5anczc0gvWE5oMFVG?= =?utf-8?B?VjQxMkt6UGpWMmJpK01nN0dSL24zM3JyUm9mR004cDNQNVVSNXZINkxKdXNj?= =?utf-8?B?U09qVkVHL2ZDcjNuMVJyUFZLdzlWd0NtQ1I0ejBScSthd1JqVXRGM3E1a2RT?= =?utf-8?B?M2gyZFhOanBOMEdoR0hUbnZBUCt2aGluR1JZNUVrNnJwM1ExcSsxYmdzMHA1?= =?utf-8?B?VFZoZHpGeGdZalYyVG9VMjNSZEN1MXo4U0ZHT3BsLzRGbkJpLytsTlRHVC9J?= =?utf-8?B?ZFdKTCtWREhiRlNLQmRvT2FtRVVjQkZvZVpOTVFNaWRUVkFmbllqSWdraUw0?= =?utf-8?B?UWFxTXJJSms4OTc2QVo3M2xzT2lOWmhmd0tyb3A0YzRaUG9lU3UyejZLaG00?= =?utf-8?B?L0w3MWtjbCtXemlWZFB3VlU2NmtheGU3Tmh4bDJuRFNVYjg0QjJYVE9WVitE?= =?utf-8?B?WVcyMHJRY3dQemJnRVpPR3VLUGVQTTdGUnhrUHdtNktmUDFHa0RES3VGRzI2?= =?utf-8?B?VXduZVNzMTBOeUJvOExWdzJMNTRGTmh0SUg4WWxsZUNjSkhEZ3Qvd2tFVS8x?= =?utf-8?B?OWhGY3RVN09rSzA4RHg3VzRBN1FEeXBTYWYwN0tTdTY2RndaMkRkdUc3Zisx?= =?utf-8?B?VmlURm40Zkw4QTlIUjNGbjFyQVV4UmxDQ2JHa29sU2NuSHRMWmJueG5ZdjNp?= =?utf-8?B?Y1ZmMXhoWGQ2dmpCanNEQ3QyK28zMElwcVNmenRRUFNOREpucHdrNS9HbXd0?= =?utf-8?B?Q3c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <38A13B672E225C41A1C22044F8C21B38@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68684270-49b2-47f0-ed4d-08dabcb5cf82 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 09:37:08.2444 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AIfaj1zS/8rewYwTTZ+6KzMYUWOHli5HMTMA/0hcRnd7/kRG6BTtuIPRx6XoCG3oTb8HmSpPrNFS3K/1nxyknQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5059 DQoNCj4gT24gMiBOb3YgMjAyMiwgYXQgMDk6MTEsIENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlh bi5saW5kaWdAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiANCj4gDQo+PiBPbiAxIE5vdiAyMDIy LCBhdCAxNzo1OSwgRWR3aW4gVMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4gd3JvdGU6 DQo+PiANCj4+IA0KPj4gRWR3aW4gVMO2csO2ayAoMik6DQo+PiB4ZW5jdHJsLm1sOiBtYWtlIGRv bWFpbl9nZXRpbmZvbGlzdCB0YWlsIHJlY3Vyc2l2ZQ0KPj4geGVuY3RybDogdXNlIGxhcmdlciBj aHVua3NpemUgaW4gZG9tYWluX2dldGluZm9saXN0DQo+PiANCj4+IHRvb2xzL29jYW1sL2xpYnMv eGMveGVuY3RybC5tbCB8IDI1ICsrKysrKysrKysrKysrKysrKy0tLS0tLS0NCj4+IDEgZmlsZSBj aGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQ0KPiANCj4gQWNrZWQtYnk6 IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4NCj4gDQo+IA0K Pj4gSXQgd2FzIGNhbGxpbmcgdGhlIFhlbiBkb21haW5mb2xpc3QgaHlwZXJjYWxsIE4vMiB0aW1l cy4NCj4+IE9wdGltaXplIHRoaXMgc3VjaCB0aGF0IGl0IGlzIGNhbGxlZCBhdCBtb3N0IDIgdGlt ZXMgZHVyaW5nIG5vcm1hbCB1c2UuDQo+PiANCj4+IEltcGxlbWVudCBhIHRhaWwgcmVjdXJzaXZl IGByZXZfY29uY2F0YCBlcXVpdmFsZW50IHRvIGBjb25jYXQgfD4gcmV2YCwNCj4+IGFuZCB1c2Ug aXQgaW5zdGVhZCBvZiBjYWxsaW5nIGBAYCBtdWx0aXBsZSB0aW1lcy4NCj4gDQo+IEFyZSB0aGVy ZSBhbnkgYXNzdXJhbmNlcyBhYm91dCB0aGUgb3JkZXIgaW4gZWxlbWVudHMgcmV0dXJuZWQgYnkg ZG9tYWluX2dldGluZm9saXN0PyBJIHVuZGVyc3RhbmQgdGhhdCB0aGUgY2hhbmdlIG1haW50YWlu cyB0aGUgY3VycmVudCBiZWhhdmlvdXIgYnV0IGFyZSB3ZSBldmVuIHJlcXVpcmVkIHRvIG1haW50 YWluIHRoYXQgb3JkZXI/IEJlY2F1c2Ugb3RoZXJ3aXNlIHdlIGNvdWxkIHJldHVybiB0aGUgcmV2 ZXJzZSBsaXN0IGFuZCBzYXZlIG1vcmUgd29yay4NCg0KDQpBZnRlciBzb21lIGRpc2N1c3Npb24g d2l0aCBBbmRyZXcgQ29vcGVyIGFwcGFyZW50bHkgdGhlIHhlbmN0cmwgQVBJIGlzIGJyb2tlbiBh bmQgY2Fubm90IGJlIHVzZWQgc2FmZWx5IGFzIGlzLCBzbyBJJ2xsIGJlIHJld3JpdGluZyB0aGlz IHBhdGNoLg0KRG9taWRzIGNhbiBiZSBhc3NpZ25lZCByYW5kb21seSwgb3IgdG9vbHN0YWNrcyBj YW4gc2V0IGEgY3VzdG9tIGRvbWlkLCBzbyBpdCBpcyBub3QgZ3VhcmFudGVlZCB0aGF0IG5ldyBk b21pZHMgYWx3YXlzIHNob3cgdXAgYXMgaGlnaGVyIG51bWJlcnMsDQphbmQgdGhlIG9ubHkgc2Fm ZSB3YXkgdG8gdXNlIGluZm9saXN0IGlzIHRvIGVpdGhlciByZXF1ZXN0IDEgZG9taWQsIG9yIHJl cXVlc3QgdGhlbSBhbGwgKGRvbWlkcyBhcmUgMTUtYml0LCBzbyAzMjc2OCkuDQpBbnl0aGluZyBl bHNlIGlzIHByb25lIHRvIHJhY2UgY29uZGl0aW9ucyBhbmQgbWlnaHQgZ2l2ZSB5b3UgYW4gaW5j b25zaXN0ZW50IHNuYXBzaG90Lg0KDQpUaGlzIGlzIHByb2JhYmx5IGJldHRlciBmaXhlZCBieSBj aGFuZ2luZyB0aGUgcHJvdG90eXBlIG9mIHRoZSBDIGZ1bmN0aW9uIGluIHhlbmN0cmwgdG8gbm90 IHRha2UgYSBjb3VudCB0byBmb3JjZSB1cGRhdGluZyBhbGwgY2FsbGVycw0KKHRoZSBjYWxsZXJz IGluIHRoZSAneGwnIHRvb2xzdGFjayBhcmUganVzdCBhcyBidWdneSBhcyB0aGUgb25lIGluIHRo aXMgT0NhbWwgYmluZGluZywgYW5kIHByb2JhYmx5IGJldHRlciB0byBmaXggdGhlIEFQSSBpbiB4 ZW5jdHJsIHRoYW4gd29ya2luZyBhcm91bmQgdGhlIHJhY2UgY29uZGl0aW9uIGluIGVhY2ggY2Fs bGVyKS4NCg0KU3RheSB0dW5lZCBmb3IgbW9yZSBwYXRjaGVzLi4uDQoNCkJlc3QgcmVnYXJkcywN Ci0tRWR3aW4= From xen-devel-bounces@lists.xenproject.org Wed Nov 02 09:39:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 09:39:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435729.689446 (Exim 4.92) (envelope-from ) id 1oqADb-00055t-1m; Wed, 02 Nov 2022 09:39:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435729.689446; Wed, 02 Nov 2022 09:39:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqADa-00055m-Ul; Wed, 02 Nov 2022 09:39:30 +0000 Received: by outflank-mailman (input) for mailman id 435729; Wed, 02 Nov 2022 09:39:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqADZ-00055g-FO for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 09:39:29 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e0ace9a-5a92-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 10:39:28 +0100 (CET) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-90-A4soFWBqPf6HzKFVGpY5Iw-1; Wed, 02 Nov 2022 05:39:25 -0400 Received: by mail-wr1-f69.google.com with SMTP id n16-20020adfc610000000b0023650935090so4598539wrg.5 for ; Wed, 02 Nov 2022 02:39:25 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id dn12-20020a05600c654c00b003cf537ec2efsm1653185wmb.36.2022.11.02.02.39.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:39:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e0ace9a-5a92-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667381966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=Jio9JFQacF7FMi0mPUb743H5F84vjCUoxUEdOs4aCfEtqSNexXzNQhBZqnP+aEdEkKHJXh URmHGjTMdLlBZMQtpImG0Y4/SH1ck9czoq54M3olm1njxLJsVz+LHQL3sTJgt66SNaM5Ds +mvqMM0BCfe4PNY5ygcY3NKi7w2CfF8= X-MC-Unique: A4soFWBqPf6HzKFVGpY5Iw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=F4njMvx1S11Efh140bdG9A3MsHbz9m9lnT9+lybRQp6GUTGVvMjAM1MymxOp/RWbjs 9V6L+dAnrg/GnqEra6qisKDVTPEwAqV3pub9Vhy+vRB6tEX6kszvaQwxm6hrjRytKO1L gJN3wOF+ERRkdmC0J1ARAXE0QZvbxHMPWCyQVJ/9ivblYhHWthdVlgX9MZgcToFfW+Am 7BU7ubo9S/XH0WbnPDKB9DMk/sd185Z7xZDOFXwBvqyNVKBt5vnmaM8bEU42oMFbV2vS AeNRrylgM9xjQS7RkCbV2faut+2Ms/nRhjD6Ci4mG51c+dw3nhslAL6t1hPM86WGwn09 gvkQ== X-Gm-Message-State: ACrzQf0kM+Z5Wb3eq0IJIk1/Jwu5dphkD/oblUBOrQQ+OV8h2NKCCUnr Aie//339bfVvizzfNZKT6Xw6/D9+EsJKjXBxdzEU8OcS8b9grQ+ZS99eNUvsQseSTDWFQBvNp9s lBjPXRctdV3vJ0jnmyKj+p1d3+fs= X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871562wrq.355.1667381964726; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4/k2KHrjikPXyIbTE3cWGjPi0EsRobUeOg55XAJjnO250x+w4Sp4JFFeS1nRK3GUJGY3QPnQ== X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871522wrq.355.1667381964509; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Message-ID: <23b6c3ca-828a-5376-ae80-0b04202e190b@redhat.com> Date: Wed, 2 Nov 2022 10:39:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 18/21] drm/fb_helper: Minimize damage-helper overhead To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-19-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-19-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/24/22 13:19, Thomas Zimmermann wrote: > Pull the test for fb_dirty into the caller to avoid extra work > if no callback has been set. In this case no damage handling is > required and no damage area needs to be computed. Print a warning > if the damage worker runs without getting an fb_dirty callback. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas But I've a trivial comment below: > drivers/gpu/drm/drm_fb_helper.c | 90 ++++++++++++++++++++++----------- > 1 file changed, 60 insertions(+), 30 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 836523aef6a27..fbc5c5445fdb0 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -449,12 +449,13 @@ static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper, > static void drm_fb_helper_damage_work(struct work_struct *work) > { > struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work); > + struct drm_device *dev = helper->dev; You removed this in patch #15, maybe just leaving it in that patch if you plan to use it again here? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From xen-devel-bounces@lists.xenproject.org Wed Nov 02 09:40:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 09:40:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435734.689457 (Exim 4.92) (envelope-from ) id 1oqAER-0006Tl-Du; Wed, 02 Nov 2022 09:40:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435734.689457; Wed, 02 Nov 2022 09:40:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAER-0006Te-As; Wed, 02 Nov 2022 09:40:23 +0000 Received: by outflank-mailman (input) for mailman id 435734; Wed, 02 Nov 2022 09:40:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAEQ-00055g-Aw for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 09:40:22 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5dd88631-5a92-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 10:40:21 +0100 (CET) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-102-moHqYDSeOTy1boBCy1aCGg-1; Wed, 02 Nov 2022 05:40:18 -0400 Received: by mail-wm1-f71.google.com with SMTP id v191-20020a1cacc8000000b003bdf7b78dccso7731254wme.3 for ; Wed, 02 Nov 2022 02:40:18 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id j20-20020a05600c191400b003b47e8a5d22sm1924445wmq.23.2022.11.02.02.40.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:40:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5dd88631-5a92-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667382020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BsLrquRWckXT1s1aby8jZXWvTG60TzDOu2w8x1+2PdY=; b=fUSRy8Zp8hL5ntlfmePj6zXKYgK0hNbpwaAPl4Rtr/L+NQKHNiQcaZetp03fJmOW/QFs+Q d44KFkqdGPiQPlcRHV2mBX8w0Ah9neKG1tBZadLpV9HHXYjDO0/SpMitiQ+nHz3fT7j2hH NBR7lAJaxX6PHFu1TleW+zbwALFhats= X-MC-Unique: moHqYDSeOTy1boBCy1aCGg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BsLrquRWckXT1s1aby8jZXWvTG60TzDOu2w8x1+2PdY=; b=MUZyT1nimx4VJ8OS/163WnjUnqAkEDmd13XpgSWeLiOLBBy0XDe8x+0AV0z7XVHhdP 8E/zfmUGDr41gG8wbTW7bYwBBM8REXs9p9reb20z9q9ltOZ2hU11K2ijTTa3jLqz/WvP NpZsXCoP+XGOWNrHkAyPxzvv+r7F47G1CSngUEXV30OGS2mIf47ZWAh86x9aotFcj8mN ReuvVObybmFZQeaq9a1S6xrqCfdXeLH+5SnYV7MDoxMplPtujKeDh7tYCzF2YUI2zg8k bJI8+VlOK7sdFNTihWUMC8ejwg9LcPuAH/4cPErfudlvVEPbjSPLxf/jb5SZZ+d9/6b+ QWlg== X-Gm-Message-State: ACrzQf2T28I6XCQXh6oXKCIBVvb3njaMZ05ILPWiIuxUoSyk+8LY5/Dv gUagdBFIro/LWL20GZQrt6DCErxgChxAFV8AnfqoC5Sc/kY/gn580pXSyOBsjg/vwySWaHwnP9T Pyc181KwMUXiX4jTh/YJUpwny3qA= X-Received: by 2002:adf:ba8f:0:b0:22c:def3:1179 with SMTP id p15-20020adfba8f000000b0022cdef31179mr14547813wrg.571.1667382017693; Wed, 02 Nov 2022 02:40:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5M29YlmTkXAEgNYduNYpaEq18eaSYaR/je5Gn7y2xNrovwH6Pttvb6rYpMLmmOPDm/qr+vag== X-Received: by 2002:adf:ba8f:0:b0:22c:def3:1179 with SMTP id p15-20020adfba8f000000b0022cdef31179mr14547781wrg.571.1667382017447; Wed, 02 Nov 2022 02:40:17 -0700 (PDT) Message-ID: <7ac0da2c-0a43-4c02-4199-f48a50347171@redhat.com> Date: Wed, 2 Nov 2022 10:40:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 19/21] drm/fb-helper: Always initialize generic fbdev emulation To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-20-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-20-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/24/22 13:19, Thomas Zimmermann wrote: > Initialize the generic fbdev emulation even if it has been disabled > on the kernel command line. The hotplug and mode initialization will > fail accordingly. > > The kernel parameter can still be changed at runtime and the emulation > will initialize after hotplugging the connector. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From xen-devel-bounces@lists.xenproject.org Wed Nov 02 09:57:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 09:57:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435745.689468 (Exim 4.92) (envelope-from ) id 1oqAUj-0000Vb-RZ; Wed, 02 Nov 2022 09:57:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435745.689468; Wed, 02 Nov 2022 09:57:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAUj-0000VU-Nt; Wed, 02 Nov 2022 09:57:13 +0000 Received: by outflank-mailman (input) for mailman id 435745; Wed, 02 Nov 2022 09:57:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAUi-0000VO-JT for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 09:57:12 +0000 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [2a00:1450:4864:20::436]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b874ba0a-5a94-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 10:57:11 +0100 (CET) Received: by mail-wr1-x436.google.com with SMTP id w14so23683518wru.8 for ; Wed, 02 Nov 2022 02:57:11 -0700 (PDT) Received: from [192.168.1.93] (adsl-187.176.58.195.tellas.gr. [176.58.195.187]) by smtp.gmail.com with ESMTPSA id bo29-20020a056000069d00b0022eafed36ebsm12674656wrb.73.2022.11.02.02.57.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:57:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b874ba0a-5a94-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l1Zr+ROJX+1LLm7/1PyIDgn0rklVbwIyI46qsgY4fKU=; b=EKL85XA8/iTlANoM+1T3xhat12Y3iXtWkifbCLcorCri0Def8cBnnmuCsK+huKu+e0 /+nvOlSw9DreC5ZbdDmyO1HU15xCwHgow1hVxGvcj2s4O83QAk6vNYqg7+WkrYteLmmk AHnwLAF3Go7LDqQE3T8DyNHVUW/qIkqVYBmLKGK3Pvi1jAt89HPpBkUH6iVFKjF4TMvB 95IPF9Hw3+okMlB8vJUFmwcqdxUMJSDp5BGbNVtBoZYGBDYtTD6vppZuYyLZwmbk69TU oELSHZ6QJxr2qiaXQJzhO0bXUlwd3oui4HF0PZPmU/UcHbJYpkCmjhCghDzRAlzR3FLK f+JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l1Zr+ROJX+1LLm7/1PyIDgn0rklVbwIyI46qsgY4fKU=; b=cW+BHLaLoc9qDoOybmJSh6Pyqng2hOY77Z6UerMn4V/Lc2437lMpkQwi0eLklT6tO8 1L5dY7iXVyaJaSHZKlCDwqoz+wxDwtXr0mQuDRxQNOgMBlW97uXeqy8rPV7d4gZ9O1WK 1OMtSJMTc0tS82ycAyli9KLEqQOx5skfv6dIRXYDAQ62elgnfPUHDPuHL2GVePgMAthL 5PKAMEqlJ6s1SdQTTm17Kg4373VZOQXV9BzljR9OcWgL4j3zRdi8FZ8Fb134XPDuC/Dy DCmtJJVuC8nbBIzZakaZXssqJoUyL4yIwJqLaKe3wTkFBiQKl9Mf0O+hUjLhjIXauXZg PjsQ== X-Gm-Message-State: ACrzQf3cWIwN4O7FJOHDsGitr427/WEt4nAxmu74W6qcoB80qfoxCn+o Gt38FWzeIHJ/7pXjjKLbd2o= X-Google-Smtp-Source: AMsMyM427MALCkkF89RY3Paa7OoszKLR0VttOK9XneONavmf/Q/FNhOHs2ZtBaDiw4O1jp18wOV4ng== X-Received: by 2002:adf:e992:0:b0:236:70ad:3bd9 with SMTP id h18-20020adfe992000000b0023670ad3bd9mr14479169wrm.136.1667383031042; Wed, 02 Nov 2022 02:57:11 -0700 (PDT) Message-ID: <8e36fec2-6df5-835c-f75a-f530c1a678e3@gmail.com> Date: Wed, 2 Nov 2022 11:57:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [XEN v2 02/12] xen/Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32 Content-Language: en-US To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-3-ayankuma@amd.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/2/22 10:46, Julien Grall wrote: > Hi, > > Title: The macros you are moving are not GICv3 specific. > > On 31/10/2022 15:13, Ayan Kumar Halder wrote: >> Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm64/ \ >> include/asm/cputype.h#L14 , for the macros specific for arm64. >> >> Refer >> https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm/include/ \ >> asm/cputype.h#L54  , for the macros specific for arm32. >> >> MPIDR_LEVEL_SHIFT() differs between 64 and 32 bit. > For 64 bit :- >> >>   aff_lev3          aff_lev2 aff_lev1 aff_lev0 >> |________|________|________|________|________| >> 40       32       24       16       8        0 >> >> For 32 bit :- >> >>   aff_lev3 aff_lev2 aff_lev1 aff_lev0 >> |________|________|________|________| >> 32       24       16       8        0 > > As discussed with Michal, AFF3 doesn't exist for 32-bit. So it is not > clear to me what we are gaining by moving the macros. > I cannot understand what do you mean by "what we are gaining by moving the macros". IIUC, when identifying the cpu topology, a mask is applied to the value of MPIDR_EL1 #ifdef CONFIG_ARM_64 #define MPIDR_HWID_MASK _AC(0xff00ffffff,UL) #else #define MPIDR_HWID_MASK _AC(0xffffff,U) #endif So, for arm32, the affinity at level 3 is considered to be 0. Do you mean, what we are gaining by defining the MPIDR_LEVEL_SHIFT in a different way for arm32 and for arm64? IMO, we need to do so, because the shift, used to retrieve the affinity at each level, cannot be calculated using the same logic i.e (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT) For arm32 the affinity at each level is calculated as follows ((level) << MPIDR_LEVEL_BITS_SHIFT) Also, IMO, since MPIDR_HWID_MASK is defined in the common header, maybe the same needs to be done for MPIDR_LEVEL_SHIFT, to make easier for someone reading the code to understand the difference. I hope I'm not out of context. > Cheers, > -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Nov 02 09:59:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 09:59:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435749.689478 (Exim 4.92) (envelope-from ) id 1oqAWS-00013d-5L; Wed, 02 Nov 2022 09:59:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435749.689478; Wed, 02 Nov 2022 09:59:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAWS-00013W-2g; Wed, 02 Nov 2022 09:59:00 +0000 Received: by outflank-mailman (input) for mailman id 435749; Wed, 02 Nov 2022 09:58:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAWQ-00013O-P4 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 09:58:58 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70084.outbound.protection.outlook.com [40.107.7.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f7a373e5-5a94-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 10:58:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6860.eurprd04.prod.outlook.com (2603:10a6:10:112::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 09:58:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 09:58:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7a373e5-5a94-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BanlWiegPDymqOU6g3mNsZvtpU966Q7EQPV2nGyKoa8Eujn/YjMH5mMfjH/ul8/wf4RKfaDX5U+yjGcS2E4IHCE44UaSzfBAGQuR1lI39q2KzZvuNvkKspiKQOTMpdlaVf7ASOYjBbkJI2MmS/n1YF3aWFEGOB2va+79+cDy9k0W9GO8YmLQyO+vv5clXbxfnXdoXr1rsu3w18YnfIlWchSVJHviTrmudlvtZFfoOByBT630f3tHAtsPRSXntfOP47bvYQnIfMAQE3zCNpJz/vbZJlUf8LJKdJxb7+W8tJeSP953tx8hwgkyUpag28deuy7jn45PJHLPJwvI1BdF+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qFxOckmnoL1HTJeBqKIjLyAK7x5/XyGqlHSsZrCCOm4=; b=jK2o8nfmtTbYO8K9CM6CAK2RxTm5Hp78Bg4jp/N7UguKqQ33xdVQk4AaQ6XtEzdrKXcsGV+p0sf6D+RMSO9dgag5yQLpIqqbypYVvb4+p6HZVKOGUOMeLxth31O26j2kOoxSxrlRehz/Eo9DRaqOvfFVsDe840WzSFXS6dG3lTAWe6zM0/BtUmoYJgeFoSqmeF8vwov2FOXc3Z1DDxnRGMFOVlWgwmDQC4ptue/CeeaGZh5eZyZeX91bbbKdHlOMFCOpnqg9cJOXiOAkIveavLEA3Eu1/yxxoUeTE6SbBJ8DQQI1gyD40Nmx7QZ3Cskmk/dzMluQ1HGXpyrgk3NKLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qFxOckmnoL1HTJeBqKIjLyAK7x5/XyGqlHSsZrCCOm4=; b=LCxmOpwOAaTcJtxalyUvOOOQJ7Kf7IU7Qv9XK6yO0dLEdYmmrC5wFNIDIUh6n3oJacynqvW9+P2DmZt8c/sJim69GCzJJ6y23R0VKbueXYzFPyHsSH25IBs4PGxw90RZuf23ApeSDgm+ufSzcjszJKvurRzUz/s8Rhggj3CAnasK2fnaCrQNDCx0eMSwh6XcDc4gMOzGW8FvPhamvF9xQyVil0xId5FgmNU65uce5rxwXC0lYlIIx/wLdn5lsBukikW9xeHOGPZKorl6qlrVh8j8CVI8HGZqhGsXItkbfII/7KCIysGZ/y33wT7ON2acdPBzcf4AI/waQgw3rkmuMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 2 Nov 2022 10:58:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [linux-linus test] 174539: regressions - FAIL Content-Language: en-US To: Juergen Gross References: <3c8a3be2-db65-253d-94ae-1bfcad1b94e2@suse.com> Cc: osstest service owner , xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: <3c8a3be2-db65-253d-94ae-1bfcad1b94e2@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6860:EE_ X-MS-Office365-Filtering-Correlation-Id: 55e75601-2de6-42ef-34d7-08dabcb8da11 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CtXzoCyb9HsveUq+LkbcXwWZNUH+Zqk/84LbJSePvb0DVtNAYg6iOdxlqZwOZe80NxCdx/3yi+aPq2puBwqPgb5qVoTBiO8LptaGUwXL7ZnipcrFxhL4mjUs5ThNTP+uBd1qyQFjF9v14Ffk9VL0oPx8esT7lSTdXDezQLKZ5g/MguTG48zn4cHLC0bGtX6lg1ntnxYUUg6gkj9F/gw90jJ5ADjBihaMbPGXxKU+Dpd56x4+moSDShlq/2kIhf8+XvEiEOrBpoYzvjaPDpq6yjGyzGsdc9NFrkEform67Hg4lsW0/1dg2VErPEPovOektsbRVOdaCiGK5TRTwVrC9k3lxKsDHr4nHvL4qZYh1RE7BpgKY7BlWkQG4A2vTph4vzfG3RAfmtkW43GQxG1YJe5viUn6IA+KtGUzF445oI5+fP0Vnbxu00pYMMRupYTQbRy3S+d2K+oaCvCQGDRRO0rlL93nNjdpMBBvTmRw/Cg+wbzZ2EuecbakFfvVbHgZDhMcvjOP3cS6suMk10r/MrfpkljnoCrJIDYAVoZ3WiqEqn62EzglH/xNaIAC0V9fSkI1iufY2uswTk9mw9BOpcGhVo6yRfXBHXyajoqdXxdw7u4h4RjPXSafK8ASXZ/e1lKLH3sLC1mnUGOABc0RN0dphvTr8IXMqXt+6nF3tt/oqNEh7uD4BFHBFys7woBk5//Hko6PssCLU3u3tVCZAkv/80/GwuO6sCUlqdibrnjuUK8yIMlVdBJggNm0SVpGoE8Nkswi6gK4A2j8ASaC8u2GkGWaQHI7IObdZowUbTwc1tY61LsfJ1+vu8WWpyxyULfoRXP+6P57/YJgjQNI/Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(396003)(136003)(39860400002)(346002)(451199015)(8936002)(5660300002)(4744005)(41300700001)(316002)(2906002)(6862004)(37006003)(6636002)(66946007)(66556008)(4326008)(8676002)(66476007)(966005)(38100700002)(86362001)(6486002)(31696002)(478600001)(186003)(83380400001)(26005)(6506007)(53546011)(6512007)(2616005)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1JzQy9IOGFwZGlGREJ3MGdRMGFtRGV4UldQQW4vS2crd0wwSUppUWtCdVVk?= =?utf-8?B?Q2p3cXpIUDUwTU5hRy8vY0Y2QlNyWFdsZytzUi9RUGh2azI3OGEzSFhIWHdk?= =?utf-8?B?eldsMDdzKzViMEczeHJRam1tMDhmVEYrL2pBOGdLNjJnRzJpUERuQXAxd1RO?= =?utf-8?B?b0tNRjJiRC9rZGp4RUF4a0Z5c1JLOHJ5aWwrMncyUGtoUU5RNHFPeER3L2dI?= =?utf-8?B?L0FyNjNjd2pIZ2YvL3h3b0xwZVBrVFZDSVRDb09NSVByTk4vMnljUkFHZ1RY?= =?utf-8?B?azRNWE9kTzFyRDZZR2c3bVFUOGJSL1EwdC9OUm1XbE1tR2pXejR5T1FlSnFW?= =?utf-8?B?L3loOExCSU1MOVNDbHpGbXhZbG9kYXBrd2Q5UCtnK25oYjNDTHdKVytHVDNz?= =?utf-8?B?dk85eHVBdFNhaExNTHRwcG96cGY0QzUyQVh3QS9JcURrdFlyR2JiTUYzMVZS?= =?utf-8?B?dXJaYTBFRHhyT2RUNXRtQkRIclNCRjN6ekVaVW0wTFdjbEhqWEVKVmNFWFNw?= =?utf-8?B?RDhzczZWc09UWmJ3K1JyUzFmbUNQQkNqU2MvSzM1Sml2U2VxWFhNTDFhelVF?= =?utf-8?B?NndNc3FRRVZmekxNd2VNSWZMa1EydHBockFtRUQvcFlJYjRZeHJjL0dqSlMr?= =?utf-8?B?L0U0T0pWZ0V2WEVLaGplUDhSdUNmME1vdUJLMG9nRmJXbS9KK0JQdlhvZWxh?= =?utf-8?B?RHVBU3NCK0JqeEFqRmttL2hxTTdNVDFyRlNtSTRVNkphWG0yQXZvSk8rdGFo?= =?utf-8?B?QmtwbzlIUmN0OGNiRDE4M0REREgxT09SeW95MlVqOGl2QlJWVVNzVGVLRDRC?= =?utf-8?B?Vk5iTG05NGVWTWlORzNvZm1NckxaR3BaZXY5cFR2NlBDWlltNGlXMGJSWjhh?= =?utf-8?B?dnYrUktaelRjb2E0MHR1cSs2T25yby9pTXJUYzNCcUJaMEpBb0U2T3QrNFNQ?= =?utf-8?B?QURFS01maVIxZ1NNZTk2Q1NJbkp1SFhlUXZsVHpSeUo2NExUdVM4SGVmRDVz?= =?utf-8?B?ZnlZR0tjeWNnTEhKSmdETkVZakRQVFQvR0xzZXdyY1BMYW9TeUFPTVlvamdM?= =?utf-8?B?Q3FwaXRzWGttQVpodmRjZWVWMVhKUnBWaXF3eDAvVHVnMWtYYzluU0FYdTk3?= =?utf-8?B?TkZaRDNSalppU0FNV2pnTXRmNHc1U3IxVUNOM0F3Ykd0NlVCRXlSOEZrUE1P?= =?utf-8?B?UWxSRlZoMHdlNEpZa1dwcER5NHByK2Q5OXdKcnNzNU9MclgwUXZjT0NNWWVE?= =?utf-8?B?OE42VmxFcG5TK21qUXpmTTdER0Q0a3FLenhhcUtvZEFEY1JDa0VWYTF3T0J3?= =?utf-8?B?cTBOM1llbjVEbEhYdG9IRDBHQmJkamRuTUQzelV1T2NqWkk3OHdSNXBhejcw?= =?utf-8?B?bnl2N2VDakdqWlQxT3lGck9SRmREc2V5NnorTm9xWGZHQzlDN24yQmFPSys5?= =?utf-8?B?Wjc2SHIxYWJUYW1zbWtibWN6T3JaTmpaY3J4TnpMV0hDU3FHZXlLQjVCV01F?= =?utf-8?B?ZnJVQmg4NHYySndjODhFU3FYdmFGVnBUZ2xKbmJVMk9RYTc2OUYyR0prR3hI?= =?utf-8?B?RHAvU2RRaEFDR3BKYjlWb3V3R2Z6RkVlS2RHRkxDN0U2N1NxeGE1dUJQbnZp?= =?utf-8?B?NUl6V01qclBVaHdXL0p4ckptcnFMRS9QQmdRTWZqZXNzQlF0WGJLbWlvOUIw?= =?utf-8?B?bklBTEtPc3Y5c2Z4Z2FVWWFCb2hSZUdsWERUdjBISGk2UnczcjRpV1VTR3ZR?= =?utf-8?B?Q0krdGlLdGxFV2FxdUR4MXhJNGZVbmpaajBvVU5qTS95aG4vZUQ3QytuNHRm?= =?utf-8?B?MHRLbGtDNEswSmlDbytFVFlJeDQ3bUpTckhmMzJINUF4Y0MwUVptQ1paaUpC?= =?utf-8?B?TkkzZVZ5V2lUQlJndFlEdHpTWlkvZGZwNEJsOW1hUmduSnZpQ0dPN0ZHUVhv?= =?utf-8?B?aTlDUzRmakJoL2MyMkUxRWVJcnhBUWdWVm9sZ0VicExqenhjRG1yWHJhZXN5?= =?utf-8?B?VXk1ZGRTazhJUlRlWVRqMjgrTUhYbnMwZ0ZtcDMwM3B4SER1WG82RmowRnUr?= =?utf-8?B?TjhPeHdPQ1RJclphMGRROW9rV2RXb0VCRmJhUGtiS1ZiY0hzc0VZNFIxVTJj?= =?utf-8?Q?dXtWXYMi9q0z33VHbOxaZ35sw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55e75601-2de6-42ef-34d7-08dabcb8da11 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 09:58:54.6161 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6KUWBbB6O2yjLzaODW2I1Yf0uYfyUYHP9Xky5Hbne1/VYdhKyV9txGVE2psyWFfpXMLDNV4aMMbcC8C9ZV3Cng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6860 On 01.11.2022 08:56, Juergen Gross wrote: > On 29.10.22 23:50, osstest service owner wrote: >> flight 174539 linux-linus real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/174539/ >> >> Regressions :-( > > I'm rather sure this is not kernel related, as the issue is occurring only on > Arm and it doesn't seem to be an architecture related issue (the volume group > containing the root file system couldn't be found). > > Could it be an infrastructure problem? Why would such manifest on only linux-linus? Along the lines of what I did say in reply to flight 173480's report I continue to think that there's an issue with the loading of a driver, perhaps because of a bad / missing dependency just on Arm. Sadly the log doesn't have any data in that regard (perhaps because of too low verbosity), so I suspect finding out can only be done by someone with actual access to one of the affected systems. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 02 10:01:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 10:01:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435754.689490 (Exim 4.92) (envelope-from ) id 1oqAYs-0002Vg-IK; Wed, 02 Nov 2022 10:01:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435754.689490; Wed, 02 Nov 2022 10:01:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAYs-0002VZ-FS; Wed, 02 Nov 2022 10:01:30 +0000 Received: by outflank-mailman (input) for mailman id 435754; Wed, 02 Nov 2022 10:01:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAYr-0002VT-25 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 10:01:29 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 509e2c6b-5a95-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 11:01:27 +0100 (CET) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-351-_in6jKhSNiS1DF-QxevBGQ-1; Wed, 02 Nov 2022 06:01:25 -0400 Received: by mail-wm1-f72.google.com with SMTP id f62-20020a1c3841000000b003cf6d9aacbbso3544417wma.8 for ; Wed, 02 Nov 2022 03:01:25 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id b13-20020a5d550d000000b002366b17ca8bsm14230263wrv.108.2022.11.02.03.01.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 03:01:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 509e2c6b-5a95-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667383286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QoVTRIE06q1gLaA+FiGPh2NoY5TNtlfidxMdk3t+aTM=; b=fuSs/eA4/7vZhV+X35FsnJlEhJ/20+W2k2LZenlQ7FIAvrb5mWjQpHZEEE3G7/vkuBezcY ci/Smj7q/Z7hIgWVlQx1F2hNiJZQuFSvdEElWEudDf6CzncUGzYGNXoMcPmOQDpm4N2pDn leC3TPAoQgZGNS5Qf5k3LtPYa4n+dVI= X-MC-Unique: _in6jKhSNiS1DF-QxevBGQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QoVTRIE06q1gLaA+FiGPh2NoY5TNtlfidxMdk3t+aTM=; b=D2gfTjVyRjC4thgiFQq1bDQhCawSV54ctNXQQy27F5D+QooPvR0IAeZo72NwHKxhXx 34KVdvP/CDT6Do1IPiasKv8+MPr43x14hX+wOYU4cVPdIeTaPsa+uOXKDFw84z74ut4T XbA3OBuvznA31UVePpA7JlkEeurwiuuVT0QDQLgCYqgscc4YCEU2Noq01UnuyN+6pIJY yzYMhEDLGyEibYv+rGecCgAvZuwkK45oDo3e//yiYlPy4kzTCLrpoZxxUra4AuYXUxfs Av0d+FXfAL4y7exuRgMYRxYsrKPPKu3cGZe4oHg7kRd5XP216+J5SH5chAXKag9Fpjkc /FDg== X-Gm-Message-State: ACrzQf1RLG/FTNwpYzY5bJzgZx5M+q0qkh6jaXGX76qM/wbD6//IA6A8 8g3UDJkFRVu14/g5+qCWOWpgdTbBMyVEaD2FXk/31H7+O7J6rH89RcEqxXZ7HLBTD+VVjwESBbu bY7hIwIaI/+sTx5O4LxVz3G5NYHg= X-Received: by 2002:a5d:5505:0:b0:236:582b:7eb0 with SMTP id b5-20020a5d5505000000b00236582b7eb0mr14405755wrv.68.1667383284403; Wed, 02 Nov 2022 03:01:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5ieiweFPtXW5w3c0VZoUXMoQohTPuy1WtQBfT29g+UzlDhvHMzFOjUUUPFpm0LZwMa5DV8ag== X-Received: by 2002:a5d:5505:0:b0:236:582b:7eb0 with SMTP id b5-20020a5d5505000000b00236582b7eb0mr14405736wrv.68.1667383284200; Wed, 02 Nov 2022 03:01:24 -0700 (PDT) Message-ID: <1d2b9809-857f-48cc-1177-72e6fc67b8e5@redhat.com> Date: Wed, 2 Nov 2022 11:01:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 20/21] drm/fb-helper: Move generic fbdev emulation into separate source file To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-21-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-21-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/24/22 13:19, Thomas Zimmermann wrote: > Move the generic fbdev implementation into its own source and header > file. Adapt drivers. No functonal changes, but some of the internal > helpers have been renamed to fit into the drm_fbdev_ naming scheme. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From xen-devel-bounces@lists.xenproject.org Wed Nov 02 10:02:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 10:02:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435758.689501 (Exim 4.92) (envelope-from ) id 1oqAZy-000350-SW; Wed, 02 Nov 2022 10:02:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435758.689501; Wed, 02 Nov 2022 10:02:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAZy-00034t-Oy; Wed, 02 Nov 2022 10:02:38 +0000 Received: by outflank-mailman (input) for mailman id 435758; Wed, 02 Nov 2022 10:02:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAZx-00034X-4T for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 10:02:37 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 795c7c37-5a95-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 11:02:36 +0100 (CET) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-467-XDoRL1XLMTyIXSWM5Jbipg-1; Wed, 02 Nov 2022 06:02:31 -0400 Received: by mail-wm1-f72.google.com with SMTP id r6-20020a1c4406000000b003cf4d3b6644so3572024wma.6 for ; Wed, 02 Nov 2022 03:02:31 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id fn13-20020a05600c688d00b003a3170a7af9sm1564836wmb.4.2022.11.02.03.02.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 03:02:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 795c7c37-5a95-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667383354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lYDm2f88uo7N+T5CuGh2kGVIDaWbYMjQLaRZ3nU/m+Y=; b=Mwcfz5L0ulLeIm+Y2T2sVMkrbMzYnXrEZSPdikrHgMjcrwcQG3fACvszbCufoJjXQoYs7u dZbA2GEOnEn8MNhLyf6j3YAcxL1DV6xPfJ7EefGLtV001lrH/mEnJToVjvJcoQkvJl7sVU aucY35Pybi1KoSpJbjjiiolK8+Z7EVw= X-MC-Unique: XDoRL1XLMTyIXSWM5Jbipg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lYDm2f88uo7N+T5CuGh2kGVIDaWbYMjQLaRZ3nU/m+Y=; b=aAWgcmUqzRzGLVoLwaoXoajOSSlIJsEt0IOYO/AZLEXtTucLS3HhCkj+/kbg4+i19g tPEWBAwew2wrfh9nRsmqOh8RlHCnWl5HAX3Vi/ixaP1XrjOr8G+QDoxo7wH/vP3Aa5BN fJqLpfli4RsztPpcyMdUXd5S78xUS7rgkUm2SRH6Gk5xFtF6JZaPoU8N+VC0P+KQtlNc KaLvsTYpCsUfpTEKWGI+ohnbZpUsIXTE2D1/qF+tI3EBuAaqaKTjnPl+v7Wc0KSzfDxx PoNxTTGi4t9KCHaLWFfT6hMEqAJAgn8qisBVuifjMtEEzS17khBBB4y4Z4GtlJE1FL3m hbbw== X-Gm-Message-State: ACrzQf1yFgFMXBpthyF7pCVi+8+jioW2sUUm6wcpzhg4dO7LpXJaiVXa cKWbv9DoC3EqosDgWv9SEajLPsnsxZ8+x3ljMyN4WHqnz7jFpgM+phCCsdGAT0C4nSCdeSwEFQM YB41besOSoPV/7NvukUUVBaeVl4E= X-Received: by 2002:adf:f9cf:0:b0:236:6a26:c055 with SMTP id w15-20020adff9cf000000b002366a26c055mr14584883wrr.195.1667383350616; Wed, 02 Nov 2022 03:02:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6OHHkFmpcUlQhLx4VZSF/FNGP0hsrmpEExWtKIxFg2Jf6dmbAckk/gQVQTytU8dXpfU2B04w== X-Received: by 2002:adf:f9cf:0:b0:236:6a26:c055 with SMTP id w15-20020adff9cf000000b002366a26c055mr14584846wrr.195.1667383350420; Wed, 02 Nov 2022 03:02:30 -0700 (PDT) Message-ID: <68309442-ad39-36da-b1ec-680dd4129a7f@redhat.com> Date: Wed, 2 Nov 2022 11:02:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 21/21] drm/fb-helper: Remove unnecessary include statements To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-22-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-22-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/24/22 13:19, Thomas Zimmermann wrote: > Remove include statements for where it is not > required (i.e., most of them). In a few places include other header > files that are required by the source code. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From xen-devel-bounces@lists.xenproject.org Wed Nov 02 10:10:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 10:10:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435766.689512 (Exim 4.92) (envelope-from ) id 1oqAha-000519-Nx; Wed, 02 Nov 2022 10:10:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435766.689512; Wed, 02 Nov 2022 10:10:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAha-000512-Ky; Wed, 02 Nov 2022 10:10:30 +0000 Received: by outflank-mailman (input) for mailman id 435766; Wed, 02 Nov 2022 10:10:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAha-00050w-21 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 10:10:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAhY-0007CW-W7; Wed, 02 Nov 2022 10:10:28 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oqAhY-0003KY-PC; Wed, 02 Nov 2022 10:10:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=mptFKpEndcS7416tpebhikfpMHYhH2a8NS3Ohm9rpJs=; b=rLq2i1prMGSW+wsZFZIJhh5qW0 gb6jLtwJTPLQ/oyoomAhiTsVER3HmrC+j8iN+a/AxwMWyjCKnXUZYIqbK3GWkw2HRZW+B/RKiChxb mrZfv+1lfruuQpfD9ddSZbveIq2MbWDSIZakH1lRlxkkeLtFHIjwcYRrXwy1o3r++KGE=; Message-ID: <9c4ca761-6ef4-d0e9-f496-27e0acaba95c@xen.org> Date: Wed, 2 Nov 2022 10:10:26 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 02/12] xen/Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32 To: Xenia Ragiadakou , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-3-ayankuma@amd.com> <8e36fec2-6df5-835c-f75a-f530c1a678e3@gmail.com> Content-Language: en-US From: Julien Grall In-Reply-To: <8e36fec2-6df5-835c-f75a-f530c1a678e3@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Xenia, On 02/11/2022 09:57, Xenia Ragiadakou wrote: > > On 11/2/22 10:46, Julien Grall wrote: >> Hi, >> >> Title: The macros you are moving are not GICv3 specific. >> >> On 31/10/2022 15:13, Ayan Kumar Halder wrote: >>> Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm64/ \ >>> include/asm/cputype.h#L14 , for the macros specific for arm64. >>> >>> Refer >>> https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm/include/ \ >>> asm/cputype.h#L54  , for the macros specific for arm32. >>> >>> MPIDR_LEVEL_SHIFT() differs between 64 and 32 bit. > For 64 bit :- >>> >>>   aff_lev3          aff_lev2 aff_lev1 aff_lev0 >>> |________|________|________|________|________| >>> 40       32       24       16       8        0 >>> >>> For 32 bit :- >>> >>>   aff_lev3 aff_lev2 aff_lev1 aff_lev0 >>> |________|________|________|________| >>> 32       24       16       8        0 >> >> As discussed with Michal, AFF3 doesn't exist for 32-bit. So it is not >> clear to me what we are gaining by moving the macros. >> > > I cannot understand what do you mean by "what we are gaining by moving > the macros". > > IIUC, when identifying the cpu topology, a mask is applied to the value > of MPIDR_EL1 > #ifdef CONFIG_ARM_64 > #define MPIDR_HWID_MASK     _AC(0xff00ffffff,UL) > #else > #define MPIDR_HWID_MASK     _AC(0xffffff,U) > #endif > So, for arm32, the affinity at level 3 is considered to be 0. > > Do you mean, what we are gaining by defining the MPIDR_LEVEL_SHIFT in a > different way for arm32 and for arm64? Yes. There are nothing justifying the move so far. > > IMO, we need to do so, because the shift, used to retrieve the affinity > at each level, cannot be calculated using the same logic i.e > (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT) > > For arm32 the affinity at each level is calculated as follows > ((level) << MPIDR_LEVEL_BITS_SHIFT) I understand they are written differently. But if you look at the layout, AFF0, AFF1, AFF2 are in the same position. AFF3 doesn't exist for arm32 and, AFAICT, the shift will not matter because the bits 40:32 will be zeroed in any case. So I don't see the problem of using the arm64 version. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 02 10:26:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 10:26:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435771.689523 (Exim 4.92) (envelope-from ) id 1oqAwt-0007Pl-2l; Wed, 02 Nov 2022 10:26:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435771.689523; Wed, 02 Nov 2022 10:26:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAws-0007Pe-VW; Wed, 02 Nov 2022 10:26:18 +0000 Received: by outflank-mailman (input) for mailman id 435771; Wed, 02 Nov 2022 10:26:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqAwr-0007PY-Sl for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 10:26:18 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2080.outbound.protection.outlook.com [40.107.102.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c76639c2-5a98-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 11:26:15 +0100 (CET) Received: from DM6PR08CA0044.namprd08.prod.outlook.com (2603:10b6:5:1e0::18) by MN0PR12MB6295.namprd12.prod.outlook.com (2603:10b6:208:3c0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 2 Nov 2022 10:26:12 +0000 Received: from DM6NAM11FT111.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1e0:cafe::57) by DM6PR08CA0044.outlook.office365.com (2603:10b6:5:1e0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Wed, 2 Nov 2022 10:26:12 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT111.mail.protection.outlook.com (10.13.173.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Wed, 2 Nov 2022 10:26:12 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 2 Nov 2022 05:26:11 -0500 Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Wed, 2 Nov 2022 05:26:09 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c76639c2-5a98-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VWrdhQKafJIJiQbM1+/U5K65cR6uwSWMP4EVe8+N3cXZbmZ2LDbdMEteWgFbqaupYz0+JZlpNiq2IC0GtNVkm3k39LbIjHbvXjuVzvqIAYBJUYFJL0jkp60bMHxu0kNyW8zLdU/BM75zeYB65eVvM8m04dli7IaTL2kTJQATbgIzqdaMXEpvzftDfYjG+Zywal0O4HFtiQYyJ3n8nz9OWXN5/CPPeKQt5bbuQgxiLEnsiJdVtOZ6BdwTuKIejO28gyxrCqB/mJkw1ERs4tnZJLRtL2nbBZorAp+ka0xgDaO6aNA86l5KvGxT05Yi78frmoOyjPb0QWKV8MnPNKg+lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jBbRSb269aG1kYLOZeTi/FdLlssi7ojyFLAGVh5a67A=; b=i8C+4RFM/GKMjT4vS2lh+kYy3DGi5k08jKl0BQmIEq0SNDoP63UEN0AsJ0u6wystQ6vmLvmYnkf41yPh94ejFHVgnt9enlE2ru8YGz4UfSLYRSRUpfoliB90i862oOr/apZv/wg/0j50UpcKyuwWU8/w0KY2PhNQPBWqEc3I6ATH4TloS2l3dqtyh2cMMnZi9zXMyWwbhzPpv6LzrJLu5aw7o7J47uDNKYSd+xfT9cAEdb4wffCtae3AxPk8e/UnpxQxSnGcsjYXo3+D9Ni81xXzokeoExq9BQtcoPzjLu6g9VZ2wUlHZZTY4tbsiZ1Fa9G0F/Usy7Bfhb4i+4HUVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jBbRSb269aG1kYLOZeTi/FdLlssi7ojyFLAGVh5a67A=; b=n9DLPJxaEVR/bn76ztHoR5fBu2V8DfUti6lUYcyy6Zi9+pPGRMdWd3CYGFBaJ9LGg6okDfGVFDJ6NujIIfEcyV7s1iiAc7Z6gE2h/yAkG3EM+uGgUB9gEDyAYZOAMrspWAVTbOQJ8bjAlNSdrAblnCKARjUpE7X1YR9oDI8Ic5A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Wed, 2 Nov 2022 11:26:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 05/12] xen/Arm: GICv3: Fix GICR_{PENDBASER, PROPBASER} emulation on 32-bit host Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-6-ayankuma@amd.com> From: Michal Orzel In-Reply-To: <20221031151326.22634-6-ayankuma@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT111:EE_|MN0PR12MB6295:EE_ X-MS-Office365-Filtering-Correlation-Id: af8bfe0f-7527-4567-64ce-08dabcbcaa44 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5ZdhBlTsRi/CkmM6rjPFAT/cUeNKQII6OQDtI35SEnjFt/zDlWERlHcgNA5VPgRyZuFkJxFUU2XWaTwh/P+YOC7EBYk+R3o+K6JytT7umjAooL0/6096FVeo8/MjOIsQnnqMFrWrvRYFUgYL7PXrT/Vamx+QPyOHHw6bTbWYaj7GwrtrnfRkM3QRyH78raTu408wFCR8C9pZ1LuqIrWaio06SMXLk0lRCmY5qxdA2sttZ96JgTEL0277bt1WqB+/eiyaTeeo0asjRTBlkiV7I5yCQGr4CwYuZEDrka+7YaXo3PSIJtCWIxJ1wba/uhiHlNpcGQU7BE8ORNsaNthnXc8Al2dMz3lX32/28iYD5mwWJe4tlG5U23/nNfpLjIsylUrehxKQ+5gIoyjurcWKPsg5JSl/H/rF/cPovOXiCU4bQbafHaBy99OC9EJcr6i+w6I5TagobjjFmy2eAZ6XEpvX+1ynmSfzvV0ldBeK40/WatLouggB2JT+S27JWwN9jNNTkEbsZZjzoefo6uO+DUrLcxwQL31z7QxTRh+oQioGLqX+YJ70J9q27923pD/ucC2mOGztAKh+2voOrSMYDW2aFRto++TF7+e3cxccXa7jaUdwavJ3beNHF4Zy8PTnsG1zr4l6ANkGtzxGjLoZAS9ty7QWLCKN7AqDIBPFjR9U4dwaXQERdPtuiDWdkgLKqKxTggdfC0UCflL2wesdtJet+F4v3QieJSFearm8omaFxFnQbmq6FCcbPlhYGDkIARFiCE+VYQuywpNH/5AkDvO3c6PC2JVsGrbBeaTaeY3QldbTYYk5BjJruLDLxWoTS+hj4I+GbeWbqvSvcniDw/+sUYULQo8h8Iovzdvop20RhhC5ovkkAuPBF2qK/icf X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199015)(36840700001)(40470700004)(46966006)(82310400005)(26005)(8676002)(70206006)(36756003)(53546011)(54906003)(110136005)(70586007)(36860700001)(2906002)(40480700001)(336012)(316002)(47076005)(426003)(5660300002)(31696002)(86362001)(41300700001)(40460700003)(83380400001)(2616005)(44832011)(8936002)(4326008)(966005)(31686004)(478600001)(186003)(356005)(82740400003)(16576012)(81166007)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 10:26:12.2204 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af8bfe0f-7527-4567-64ce-08dabcbcaa44 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT111.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6295 Hi Ayan, On 31/10/2022 16:13, Ayan Kumar Halder wrote: > > > 'unsigned long long' is defined as 64 bit across both aarch32 and aarch64. > So, use 'ULL' for 64 bit word instead of UL which is 32 bits for aarch32. > GICR_PENDBASER and GICR_PROPBASER both are 64 bit registers. > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from - > v1 - 1. Extract the bug fix for incorrect bit clearing (GICR_PENDBASER_PTZ) > into a separate patch fix. > https://patchwork.kernel.org/project/xen-devel/patch/20221027185555.46125-1-ayankuma@amd.com/ > > xen/arch/arm/include/asm/gic_v3_defs.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h > index 728e28d5e5..48a1bc401e 100644 > --- a/xen/arch/arm/include/asm/gic_v3_defs.h > +++ b/xen/arch/arm/include/asm/gic_v3_defs.h > @@ -134,15 +134,15 @@ > > #define GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT 56 > #define GICR_PROPBASER_OUTER_CACHEABILITY_MASK \ > - (7UL << GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT) > + (7ULL << GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT) > #define GICR_PROPBASER_SHAREABILITY_SHIFT 10 > #define GICR_PROPBASER_SHAREABILITY_MASK \ > - (3UL << GICR_PROPBASER_SHAREABILITY_SHIFT) > + (3ULL << GICR_PROPBASER_SHAREABILITY_SHIFT) > #define GICR_PROPBASER_INNER_CACHEABILITY_SHIFT 7 > #define GICR_PROPBASER_INNER_CACHEABILITY_MASK \ > - (7UL << GICR_PROPBASER_INNER_CACHEABILITY_SHIFT) > + (7ULL << GICR_PROPBASER_INNER_CACHEABILITY_SHIFT) > #define GICR_PROPBASER_RES0_MASK \ > - (GENMASK(63, 59) | GENMASK(55, 52) | GENMASK(6, 5)) > + (GENMASK_ULL(63, 59) | GENMASK_ULL(55, 52) | GENMASK_ULL(6, 5)) > > #define GICR_PENDBASER_SHAREABILITY_SHIFT 10 > #define GICR_PENDBASER_INNER_CACHEABILITY_SHIFT 7 > @@ -152,11 +152,11 @@ > #define GICR_PENDBASER_INNER_CACHEABILITY_MASK \ > (7UL << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT) > #define GICR_PENDBASER_OUTER_CACHEABILITY_MASK \ > - (7UL << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT) > -#define GICR_PENDBASER_PTZ BIT(62, UL) > + (7ULL << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT) > +#define GICR_PENDBASER_PTZ BIT(62, ULL) > #define GICR_PENDBASER_RES0_MASK \ > - (BIT(63, UL) | GENMASK(61, 59) | GENMASK(55, 52) | \ > - GENMASK(15, 12) | GENMASK(6, 0)) > + (BIT(63, ULL) | GENMASK_ULL(61, 59) | GENMASK_ULL(55, 52) | \ It would be good to align \ but at the same time I can understand that it was not aligned before your change and you may not want to do this, so: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 02 10:33:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 10:33:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435777.689534 (Exim 4.92) (envelope-from ) id 1oqB3c-0000Qc-Q2; Wed, 02 Nov 2022 10:33:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435777.689534; Wed, 02 Nov 2022 10:33:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqB3c-0000QV-N4; Wed, 02 Nov 2022 10:33:16 +0000 Received: by outflank-mailman (input) for mailman id 435777; Wed, 02 Nov 2022 10:33:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqB3b-0000QP-2C for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 10:33:15 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c09535b8-5a99-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 11:33:12 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F080D336B1; Wed, 2 Nov 2022 10:33:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 733C813AE0; Wed, 2 Nov 2022 10:33:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pwAgG2hHYmPXUwAAMHmgww (envelope-from ); Wed, 02 Nov 2022 10:33:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c09535b8-5a99-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667385193; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=39AVSkEHI1J+0NxFici1XfnR3bd2AlgAeg7g921bvYs=; b=Cx2xiWMC5E11WkmY909rsos2svtnzjxSZkKuTFtXUFgr5/q5Xz2IM5g1+XgGiDXWLl3iN6 j9vK8FYTQJj8c/fwCAVjGLZsRRl8/etR11oAGlj7oqfq0SZsvlm7Gqn7NqATYTdOX31lSm kEohXWWBhiXVhscLaSrUkGEyO7CmrEQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667385193; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=39AVSkEHI1J+0NxFici1XfnR3bd2AlgAeg7g921bvYs=; b=VmKtdHzSvWZGkFNSUcLJzJsMZ9sTv9odj9s9+U4GRjt8StJaU5YRqyzyk25taSOPmszLei O0R9jIyTleysD+AQ== Message-ID: <0ca70b76-c24a-4fdb-cf0d-2647d37379df@suse.de> Date: Wed, 2 Nov 2022 11:33:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2 17/21] drm/fb-helper: Perform all fbdev I/O with the same implementation Content-Language: en-US To: Javier Martinez Canillas , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-18-tzimmermann@suse.de> <3ab32fc3-f2aa-1b42-fd87-557482ab56d5@redhat.com> From: Thomas Zimmermann In-Reply-To: <3ab32fc3-f2aa-1b42-fd87-557482ab56d5@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------580Yj573GGcKpjSl0DPBr0oc" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------580Yj573GGcKpjSl0DPBr0oc Content-Type: multipart/mixed; boundary="------------0mHlbG09Ag4oDeheVwguJWiS"; protected-headers="v1" From: Thomas Zimmermann To: Javier Martinez Canillas , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org Message-ID: <0ca70b76-c24a-4fdb-cf0d-2647d37379df@suse.de> Subject: Re: [PATCH v2 17/21] drm/fb-helper: Perform all fbdev I/O with the same implementation References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-18-tzimmermann@suse.de> <3ab32fc3-f2aa-1b42-fd87-557482ab56d5@redhat.com> In-Reply-To: <3ab32fc3-f2aa-1b42-fd87-557482ab56d5@redhat.com> --------------0mHlbG09Ag4oDeheVwguJWiS Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 SGkNCg0KQW0gMDIuMTEuMjIgdW0gMTA6MzIgc2NocmllYiBKYXZpZXIgTWFydGluZXogQ2Fu aWxsYXM6DQo+IE9uIDEwLzI0LzIyIDEzOjE5LCBUaG9tYXMgWmltbWVybWFubiB3cm90ZToN Cj4+IEltcGxlbWVudCB0aGUgZmJkZXYncyByZWFkL3dyaXRlIGhlbHBlcnMgd2l0aCB0aGUg c2FtZSBmdW5jdGlvbnMuIFVzZQ0KPj4gdGhlIGdlbmVyaWMgZmJkZXYncyBjb2RlIGFzIHRl bXBsYXRlLiBDb252ZXJ0IGFsbCBkcml2ZXJzLg0KPj4NCj4+IERSTSdzIGZiIGhlbHBlcnMg bXVzdCBpbXBsZW1lbnQgcmVndWxhciBJL08gZnVuY3Rpb25hbGl0eSBpbiBzdHJ1Y3QNCj4+ IGZiX29wcyBhbmQgcG9zc2libHkgcGVyZm9ybSBhIGRhbWFnZSB1cGRhdGUuIEhhbmRsZSBh bGwgdGhpcyBpbiB0aGUNCj4+IHNhbWUgZnVuY3Rpb25zIGFuZCBjb252ZXJ0IGRyaXZlcnMu IFRoZSBmdW5jdGlvbmFsaXR5IGhhcyBiZWVuIHVzZWQNCj4+IGFzIHBhcnQgb2YgdGhlIGdl bmVyaWMgZmJkZXYgY29kZSBmb3Igc29tZSB0aW1lLiBUaGUgZHJpdmVycyBkb24ndA0KPj4g c2V0IHN0cnVjdCBkcm1fZmJfaGVscGVyLmZiX2RpcnR5LCBzbyB0aGV5IHdpbGwgbm90IGJl IGFmZmVjdGVkIGJ5DQo+PiBkYW1hZ2UgaGFuZGxpbmcuDQo+Pg0KPj4gRm9yIEkvTyBtZW1v cnksIGZiIGhlbHBlcnMgbm93IHByb3ZpZGUgZHJtX2ZiX2hlbHBlcl9jZmJfcmVhZCgpIGFu ZA0KPj4gZHJtX2ZiX2hlbHBlcl9jZmJfd3JpdGUoKS4gU2V2ZXJhbCBkcml2ZXJzIHJlcXVp cmUgdGhlc2UuIFVudGlsIG5vdw0KPj4gdGVncmEgdXNlZCBJL08gcmVhZCBhbmQgd3JpdGUs IGFsdGhvdWdoIHRoZSBtZW1vcnkgYnVmZmVyIGFwcGVhcnMgdG8NCj4+IGJlIGluIHN5c3Rl bSBtZW1vcnkuIFNvIHVzZSBfc3lzXyBoZWxwZXJzIG5vdy4NCj4+DQo+PiBTaWduZWQtb2Zm LWJ5OiBUaG9tYXMgWmltbWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4NCj4+IC0tLQ0K PiANCj4gWy4uLl0NCj4gDQo+PiArc3RhdGljIHNzaXplX3QgX19kcm1fZmJfaGVscGVyX3dy aXRlKHN0cnVjdCBmYl9pbmZvICppbmZvLCBjb25zdCBjaGFyIF9fdXNlciAqYnVmLCBzaXpl X3QgY291bnQsDQo+PiArCQkJCSAgICAgbG9mZl90ICpwcG9zLCBkcm1fZmJfaGVscGVyX3dy aXRlX3NjcmVlbiB3cml0ZV9zY3JlZW4pDQo+PiArew0KPiANCj4gWy4uLl0NCj4gDQo+PiAr CS8qDQo+PiArCSAqIENvcHkgdG8gZnJhbWVidWZmZXIgZXZlbiBpZiB3ZSBhbHJlYWR5IGxv Z2dlZCBhbiBlcnJvci4gRW11bGF0ZXMNCj4+ICsJICogdGhlIGJlaGF2aW9yIG9mIHRoZSBv cmlnaW5hbCBmYmRldiBpbXBsZW1lbnRhdGlvbi4NCj4+ICsJICovDQo+PiArCXJldCA9IHdy aXRlX3NjcmVlbihpbmZvLCBidWYsIGNvdW50LCBwb3MpOw0KPj4gKwlpZiAocmV0IDwgMCkN Cj4+ICsJCXJldHVybiByZXQ7IC8qIHJldHVybiBsYXN0IGVycm9yLCBpZiBhbnkgKi8NCj4+ ICsJZWxzZSBpZiAoIXJldCkNCj4+ICsJCXJldHVybiBlcnI7IC8qIHJldHVybiBwcmV2aW91 cyBlcnJvciwgaWYgYW55ICovDQo+PiArDQo+PiArCSpwcG9zICs9IHJldDsNCj4+ICsNCj4g DQo+IFNob3VsZCAqcHBvcyBiZSBpbmNyZW1lbnRlZCBldmVuIGlmIHRoZSBwcmV2aW91cyBl cnJvciBpcyByZXR1cm5lZD8NCg0KWWVzLiBJdCBlbXVsYXRlcyB0aGUgb3JpZ2luYWwgZmJk ZXYgY29kZSBhdCBbMV0uIEZ1cnRoZXIgZG93biBpbiB0aGF0IA0KZnVuY3Rpb24sIHRoZSBw b3NpdGlvbiBpcyBiZWluZyB1cGRhdGVkIGV2ZW4gaWYgYW4gZXJyb3Igb2NjdXJlZC4gV2Ug DQpvbmx5IHJldHVybiB0aGUgaW5pdGlhbCBlcnJvciBpZiBubyBieXRlcyBnb3Qgd3JpdHRl bi4NCg0KSXQgY291bGQgaGFwcGVuIHRoYXQgc29tZSB1c2Vyc3BhY2UgcHJvZ3JhbSBoaXRz IHRvIGVycm9yLCBidXQgc3RpbGwgDQpyZWxpZXMgb24gdGhlIG91dHB1dCBhbmQgcG9zaXRp b24gYmVpbmcgdXBkYXRlZC4gSUlSQyBJIGV2ZW4gYWRkZWQgDQp2YWxpZGF0aW9uIG9mIHRo aXMgYmVoYXZpb3IgdG8gdGhlIElHVCBmYmRldiB0ZXN0cy4gIEkgYWdyZWUgdGhhdCB0aGlz IA0KaXMgc29tZXdoYXQgYm9ndXMgYmVoYXZpb3IsIGJ1dCBjaGFuZ2luZyBpdCB3b3VsZCBj aGFuZ2UgbG9uZy1zdGFuZGluZyANCnVzZXJzcGFjZSBzZW1hbnRpY3MuDQoNClsxXSANCmh0 dHBzOi8vZWxpeGlyLmJvb3RsaW4uY29tL2xpbnV4L3Y2LjAuNi9zb3VyY2UvZHJpdmVycy92 aWRlby9mYmRldi9jb3JlL2ZibWVtLmMjTDgyNQ0KDQo+IA0KPiBUaGUgd3JpdGVfc2NyZWVu KCkgc3VjY2VlZGVkIGFueXdheXMsIGV2ZW4gd2hlbiB0aGUgY291bnQgd3JpdHRlbiB3YXMN Cj4gc21hbGxlciB0aGFuIHdoYXQgdGhlIGNhbGxlciBhc2tlZCBmb3IuDQo+IA0KPj4gICAv KioNCj4+IC0gKiBkcm1fZmJfaGVscGVyX3N5c19yZWFkIC0gd3JhcHBlciBhcm91bmQgZmJf c3lzX3JlYWQNCj4+ICsgKiBkcm1fZmJfaGVscGVyX3N5c19yZWFkIC0gSW1wbGVtZW50cyBz dHJ1Y3QgJmZiX29wcy5mYl9yZWFkIGZvciBzeXN0ZW0gbWVtb3J5DQo+PiAgICAqIEBpbmZv OiBmYl9pbmZvIHN0cnVjdCBwb2ludGVyDQo+PiAgICAqIEBidWY6IHVzZXJzcGFjZSBidWZm ZXIgdG8gcmVhZCBmcm9tIGZyYW1lYnVmZmVyIG1lbW9yeQ0KPj4gICAgKiBAY291bnQ6IG51 bWJlciBvZiBieXRlcyB0byByZWFkIGZyb20gZnJhbWVidWZmZXIgbWVtb3J5DQo+PiAgICAq IEBwcG9zOiByZWFkIG9mZnNldCB3aXRoaW4gZnJhbWVidWZmZXIgbWVtb3J5DQo+PiAgICAq DQo+PiAtICogQSB3cmFwcGVyIGFyb3VuZCBmYl9zeXNfcmVhZCBpbXBsZW1lbnRlZCBieSBm YmRldiBjb3JlDQo+PiArICogUmV0dXJuczoNCj4+ICsgKiBUaGUgbnVtYmVyIG9mIHJlYWQg Ynl0ZXMgb24gc3VjY2Vzcywgb3IgYW4gZXJyb3IgY29kZSBvdGhlcndpc2UuDQo+PiAgICAq Lw0KPiANCj4gVGhpcyBzZW50ZW5jZSBzb3VuZHMgYSBsaXR0bGUgYml0IG9mZiB0byBtZS4g U2hvdWxkbid0IGJlICJudW1iZXIgb2YgYnl0ZXMgcmVhZCINCj4gaW5zdGVhZD8gSSdtIG5v dCBhIG5hdGl2ZSBFbmdsaXNoIHNwZWFrZXIgdGhvdWdoLCBzbyBmZWVsIGZyZWUgdG8ganVz dCBpZ25vcmUgbWUuDQoNCllvdSdyZSByaWdodC4NCg0KPiANCj4gWy4uLl0NCj4gDQo+PiAg IA0KPj4gK3N0YXRpYyBzc2l6ZV90IGZiX3JlYWRfc2NyZWVuX2Jhc2Uoc3RydWN0IGZiX2lu Zm8gKmluZm8sIGNoYXIgX191c2VyICpidWYsIHNpemVfdCBjb3VudCwNCj4+ICsJCQkJICAg bG9mZl90IHBvcykNCj4+ICt7DQo+PiArCWNvbnN0IGNoYXIgX19pb21lbSAqc3JjID0gaW5m by0+c2NyZWVuX2Jhc2UgKyBwb3M7DQo+PiArCXNpemVfdCBhbGxvY19zaXplID0gbWluX3Qo c2l6ZV90LCBjb3VudCwgUEFHRV9TSVpFKTsNCj4+ICsJc3NpemVfdCByZXQgPSAwOw0KPj4g KwlpbnQgZXJyID0gMDsNCj4gDQo+IERvIHlvdSByZWFsbHkgbmVlZCB0aGVzZSB0d28/IEFG QUlLIHNzaXplX3QgaXMgYSBzaWduZWQgdHlwZQ0KDQpJIHRoaW5rIHNvLiBXZSdsbCBnbyB0 aHJvdWdoIHRoZSB3aGlsZSBsb29wIG11bHRpcGxlIHRpbWVzLiBJZiB3ZSBmYWlsIA0Kb24g dGhlIGluaXRpYWwgaXRlcmF0aW9uLCB3ZSByZXR1cm4gdGhlIGVycm9yIGluIGVyci4gSWYg d2UgZmFpbCBvbiBhbnkgDQpsYXRlciBpdGVyYXRpb24sIHdlIHJldHVybiB0aGUgbnVtYmVy IG9mIHByb2Nlc3NlZCBieXRlcy4gIEhhdmluZyB0aGlzIA0KaW4gdHdvIHZhcmlhYmxlcyBz aW1wbGlmaWVzIHRoZSBsb2dpYyBBRkFJQ1QuDQoNCkJlc3QgcmVnYXJkcw0KVGhvbWFzDQoN Cj4gc28geW91IGNhbiBqdXN0IHVzZSB0aGUgcmV0IHZhcmlhYmxlIHRvIHN0b3JlIGFuZCBy ZXR1cm4gdGhlDQo+IGVycm5vIHZhbHVlLg0KPiANCj4gWy4uLl0NCj4gDQo+PiArc3RhdGlj IHNzaXplX3QgZmJfd3JpdGVfc2NyZWVuX2Jhc2Uoc3RydWN0IGZiX2luZm8gKmluZm8sIGNv bnN0IGNoYXIgX191c2VyICpidWYsIHNpemVfdCBjb3VudCwNCj4+ICsJCQkJICAgIGxvZmZf dCBwb3MpDQo+PiArew0KPj4gKwljaGFyIF9faW9tZW0gKmRzdCA9IGluZm8tPnNjcmVlbl9i YXNlICsgcG9zOw0KPj4gKwlzaXplX3QgYWxsb2Nfc2l6ZSA9IG1pbl90KHNpemVfdCwgY291 bnQsIFBBR0VfU0laRSk7DQo+PiArCXNzaXplX3QgcmV0ID0gMDsNCj4+ICsJaW50IGVyciA9 IDA7DQo+IA0KPiBTYW1lIGhlcmUuDQo+IA0KDQotLSANClRob21hcyBaaW1tZXJtYW5uDQpH cmFwaGljcyBEcml2ZXIgRGV2ZWxvcGVyDQpTVVNFIFNvZnR3YXJlIFNvbHV0aW9ucyBHZXJt YW55IEdtYkgNCk1heGZlbGRzdHIuIDUsIDkwNDA5IE7DvHJuYmVyZywgR2VybWFueQ0KKEhS QiAzNjgwOSwgQUcgTsO8cm5iZXJnKQ0KR2VzY2jDpGZ0c2bDvGhyZXI6IEl2byBUb3Rldg0K --------------0mHlbG09Ag4oDeheVwguJWiS-- --------------580Yj573GGcKpjSl0DPBr0oc Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmNiR2gFAwAAAAAACgkQlh/E3EQov+Bj MxAAp4wfwx+b/f1M/vv0NPDNSC9u3BJZBg47JuiNuprKGsOIBEeua7fb65cfh+LHqgna0CjJ9xSh bxNVEMHqrEWsi84G6EpqeIoHlfMhRK83P5zAE/GXqpxpQVPmOGmRq8RHk3fRXB+NUjW/hp6m2vm1 4UKKcQr8pm1POl+FqlvBPgIwFcrilo9Xx8FytS+0e1cZhqf1Z3y2sXVzNUQYrdq9Dvz884Jz3wmL 17m5oRbTVBQke7h08jMRyneJkZgnhF8jBT33C5X+HVNvjgLKSOGQiQbdiMEHhTT/lLa248ypTC2x ZtXQfyeTtEb/eGIInJXlE6gizVrOGJpGQb1jg3t1CoxJA0rXFHmHwVFLV+CA9pOtrMOYeE6ud9w+ iVYQbN/HLph6mIbYkZViGfFABNIr5u32ZJkR90aQWfSeLHgFJtON8p25LxLcUNQEkRe1X/pXaElE TLKY2S7E/OKeTTWxhQCk+gF+ZqBcH7uX4oBm6aSfzF/a6wy9XvGRAPPs7vVvD+r7cb0Yj+GLB8Yx aWhWFOYh+GZt5xkJ1H3UBQDOhJ237+4NpIzskMoLJPzl5EcSWVE4Nr39CfZTTFFISJsnHmAHt+Za bpUEIgHrkfrtP8KsXztM5SXXwSHzICLZHsps/fyvC8MSODtD2hRENA1BtVPpYcGl0MHBtuKjLZWp y4I= =DprF -----END PGP SIGNATURE----- --------------580Yj573GGcKpjSl0DPBr0oc-- From xen-devel-bounces@lists.xenproject.org Wed Nov 02 10:36:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 10:36:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435781.689545 (Exim 4.92) (envelope-from ) id 1oqB7A-00010z-Bn; Wed, 02 Nov 2022 10:36:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435781.689545; Wed, 02 Nov 2022 10:36:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqB7A-00010s-7k; Wed, 02 Nov 2022 10:36:56 +0000 Received: by outflank-mailman (input) for mailman id 435781; Wed, 02 Nov 2022 10:36:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqB79-00010m-6b for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 10:36:55 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 441d1f76-5a9a-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 11:36:53 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id t1so6691370wmi.4 for ; Wed, 02 Nov 2022 03:36:54 -0700 (PDT) Received: from [192.168.1.93] (adsl-187.176.58.195.tellas.gr. [176.58.195.187]) by smtp.gmail.com with ESMTPSA id j27-20020a05600c1c1b00b003c6bd91caa5sm1790106wms.17.2022.11.02.03.36.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 03:36:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 441d1f76-5a9a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q6Dde4fbYO/gMhCkyc5MUWLqgS/KiOiRy+op50FhtwQ=; b=hfNkE7PaCMbxMsRlmJv4j59ZUW75/mgcKevqds+FfUH3c1bEmrhkT2Ia+kKjPv5wFw T0DBgyO+xxL0JTC6Bc+tJvPMuhK5Ug0oDoP4ZyYKAOge+6og7jN6/SdorkLvmBiDaB4g l5inwrI8vqozVKu5P1nEgQmsHD6WkW3brYb6Ee6whDLEe3dKP5EK/xlrte4pDFlyYTX1 3YNlN0XLKF9/GlzAXf3OWof96hAV4V41Werb9oEapwGDnG2m0EnFFjeKDUHueP3ebSHp NNcDY8mvXhLjzM6s4d/xvyKtOoQSqP1DZXbr39Ub9dDvIvwhmDjoTeXpV34HdmqngCSV UqTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q6Dde4fbYO/gMhCkyc5MUWLqgS/KiOiRy+op50FhtwQ=; b=M5ZeE1czdEtb+qvk3QTZdKXwwRmlj3VQECNi4jNPuUi9h5QyE2LNAYuBykzneQsAcn NxKZ8pIC2M8pcp2wzKiCeDg36O3JjpEOTd00bNejN9b2IA73Cvy8RR756uuybxzqhI81 InKotGJj6DonwgYxiOMsTjCv/jfUh60JMx/p83KHyGxya5Do8oou8/uxihAyUnd1KiXV URLhGXWhR3FfmleX5EkKFcmnVGldmUqflMZ5/C3oHe/rMJNCGOMhr5wYIbx/DbkhztoU KqxO5HIOLzMhdKfp1EFQbAkHjRmNhxGesuom3f9rR2BIXVJXYKUz19lrb+pISQIaxmxn xK0Q== X-Gm-Message-State: ACrzQf1pdrDLmuXWxOch02QOVnN7J2IIXg588xx5+9lNk/tIZxIgZBOG DBTcwYWKoElur5Y5TcAmDEg= X-Google-Smtp-Source: AMsMyM7KhZdipAGlJiA7bNdRe5fEGuVULMeld9yi40BvJmUqr53T1/bfNQ7NYN83iXUYv/89HT7ijg== X-Received: by 2002:a1c:4641:0:b0:3cf:4ff3:8d2f with SMTP id t62-20020a1c4641000000b003cf4ff38d2fmr15351651wma.107.1667385413671; Wed, 02 Nov 2022 03:36:53 -0700 (PDT) Message-ID: <2cf591c5-df8c-d231-8862-e5c00b9a3698@gmail.com> Date: Wed, 2 Nov 2022 12:36:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [XEN v2 02/12] xen/Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32 Content-Language: en-US To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-3-ayankuma@amd.com> <8e36fec2-6df5-835c-f75a-f530c1a678e3@gmail.com> <9c4ca761-6ef4-d0e9-f496-27e0acaba95c@xen.org> From: Xenia Ragiadakou In-Reply-To: <9c4ca761-6ef4-d0e9-f496-27e0acaba95c@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Julien, On 11/2/22 12:10, Julien Grall wrote: > Hi Xenia, > > On 02/11/2022 09:57, Xenia Ragiadakou wrote: >> >> On 11/2/22 10:46, Julien Grall wrote: >>> Hi, >>> >>> Title: The macros you are moving are not GICv3 specific. >>> >>> On 31/10/2022 15:13, Ayan Kumar Halder wrote: >>>> Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm64/ \ >>>> include/asm/cputype.h#L14 , for the macros specific for arm64. >>>> >>>> Refer >>>> https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm/include/ \ >>>> asm/cputype.h#L54  , for the macros specific for arm32. >>>> >>>> MPIDR_LEVEL_SHIFT() differs between 64 and 32 bit. > For 64 bit :- >>>> >>>>   aff_lev3          aff_lev2 aff_lev1 aff_lev0 >>>> |________|________|________|________|________| >>>> 40       32       24       16       8        0 >>>> >>>> For 32 bit :- >>>> >>>>   aff_lev3 aff_lev2 aff_lev1 aff_lev0 >>>> |________|________|________|________| >>>> 32       24       16       8        0 >>> >>> As discussed with Michal, AFF3 doesn't exist for 32-bit. So it is not >>> clear to me what we are gaining by moving the macros. >>> >> >> I cannot understand what do you mean by "what we are gaining by moving >> the macros". > > >> IIUC, when identifying the cpu topology, a mask is applied to the >> value of MPIDR_EL1 >> #ifdef CONFIG_ARM_64 >> #define MPIDR_HWID_MASK     _AC(0xff00ffffff,UL) >> #else >> #define MPIDR_HWID_MASK     _AC(0xffffff,U) >> #endif >> So, for arm32, the affinity at level 3 is considered to be 0. >> >> Do you mean, what we are gaining by defining the MPIDR_LEVEL_SHIFT in >> a different way for arm32 and for arm64? > > Yes. There are nothing justifying the move so far. > >> >> IMO, we need to do so, because the shift, used to retrieve the >> affinity at each level, cannot be calculated using the same logic i.e >> (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT) >> >> For arm32 the affinity at each level is calculated as follows >> ((level) << MPIDR_LEVEL_BITS_SHIFT) > > I understand they are written differently. But if you look at the > layout, AFF0, AFF1, AFF2 are in the same position. AFF3 doesn't exist > for arm32 and, AFAICT, the shift will not matter because the bits 40:32 > will be zeroed in any case. > > So I don't see the problem of using the arm64 version. Now I see :) ... IIUC you are proposing to just cast the mpidr in MPIDR_AFFINITY_LEVEL(mpidr, level) to uint64_t? In this case, I think, UL, below, needs to also to become ULL #define AFFINITY_MASK(level) ~((_AC(0x1,UL) << MPIDR_LEVEL_SHIFT(level)) - 1) > > Cheers, > -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Nov 02 10:41:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 10:41:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435788.689556 (Exim 4.92) (envelope-from ) id 1oqBBh-0002Tt-0O; Wed, 02 Nov 2022 10:41:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435788.689556; Wed, 02 Nov 2022 10:41:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqBBg-0002Tm-SX; Wed, 02 Nov 2022 10:41:36 +0000 Received: by outflank-mailman (input) for mailman id 435788; Wed, 02 Nov 2022 10:41:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqBBg-0002Tg-IC for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 10:41:36 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2061.outbound.protection.outlook.com [40.107.223.61]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eb733bc1-5a9a-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 11:41:35 +0100 (CET) Received: from BN1PR12CA0022.namprd12.prod.outlook.com (2603:10b6:408:e1::27) by DM4PR12MB7622.namprd12.prod.outlook.com (2603:10b6:8:109::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Wed, 2 Nov 2022 10:41:32 +0000 Received: from BN8NAM11FT040.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e1:cafe::f9) by BN1PR12CA0022.outlook.office365.com (2603:10b6:408:e1::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.21 via Frontend Transport; Wed, 2 Nov 2022 10:41:32 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT040.mail.protection.outlook.com (10.13.177.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Wed, 2 Nov 2022 10:41:30 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 2 Nov 2022 05:41:30 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 2 Nov 2022 03:41:30 -0700 Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Wed, 2 Nov 2022 05:41:28 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb733bc1-5a9a-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mwx51ZVKWVxYJBIwZWEyf7IeDtlAJ7VqKDaLtzsCGpPEICkQzTh6vZrCx0hkivguwJnf4mQgBB4J60YCip8pgwR40WeWl2wpksFQIWGJ290Lax8OUrpqXmABPoK+upOWkIGlUFm1j/SJ+h7GjJLlJPBRuzHI3st9XOXwmYi3Ik1T6G0hVJAmqWaX+/QKz1ZpgKdR3MjzrBWJCMRxLldgZamAdK9jGAnfAQ7rYiHYYouwN6in9iEpvG8ecHN34A5esW53NJLyLaf3GRtXIMrLDJyH5g1clvlL5gekuM6igve62pPFRUeUThN2SpUlvoXsOPIgheVE/UTE29qJAudX1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J/61dQBjz0dzgrdbi5L+d0tNRXILRBKjyyY1wjD5yCQ=; b=Uk13Vs06jW6W2FboPzyO6y+LX6Z3Dbj8zbFX8fceisPOJIN5yvh2SXxEGdsTF92UOIOGDBjZ9hhVkol4PmwVcCZlpjLyQ/Lu0c+yKvUGsdSc7D89XAftVE8yufsWGzzr3U27TI85smUO5+WeTVJRDGFFm2K3tl8r+2doUbFEyDEkF/izO6P33PKz6IwAFBPwwLh0iKcE1Cve6+Pk/PjT6D5/IB1l8FqvTtK5ArsHaVzR0oI8gTml0jq/1aZx9bYx+Qqz+DuvC5DfnSXDQkSOSMuGwBF57Hk6MuJZGN91TTtpSYjkk2yjmpjNpsRThWVz0xjT0nhwgEUGjep84CaMmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J/61dQBjz0dzgrdbi5L+d0tNRXILRBKjyyY1wjD5yCQ=; b=WMmzT7YcDEFX9u/5cISX/2tevNFFxdXKiTkSrBQnmvSLxlXSSL6RXlLydKJlyeJjGHDsvkDRtJPe+2j08s1fDq6+Q48l16DBSIJlJe3Kwr4Z1l3YLyz5GNHw9bxDJRyzjHQRsbMJwSiFSI0GQDkuGmp6BX1BQBOaZ4Jp857cVjI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <2cd6324e-71eb-f489-15ac-8c7438e03b0a@amd.com> Date: Wed, 2 Nov 2022 11:41:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 06/12] xen/Arm: vGICv3: Fix emulation of ICC_SGI1R on AArch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-7-ayankuma@amd.com> From: Michal Orzel In-Reply-To: <20221031151326.22634-7-ayankuma@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT040:EE_|DM4PR12MB7622:EE_ X-MS-Office365-Filtering-Correlation-Id: 720b5abf-78c2-4923-4c45-08dabcbecdc4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0Ilgm6bETglNRcSOJTkn3yonCwfjzh71aDcbyFGVXaBkWxaINlyZxvlZ6M9RJwM1oDedJJjBd9EYoqyyqDvylHGOWR2ouZWQiULIcFuvZjTQXfvdRUYZOYfl1fOh5eTTbLPlPysSjzVC/HFxj5F2AQFjWMLZvx2RVEmtYAZDtnc7aSicoAttI+RKWCVRcPj3iCvor1vcFM4ttksXvpahKAMkJTHbnJnOoFVngbIqw/saSM8I7cIyVIT/XnmQHklBMqacbe9cEfXkOpRik1JaceAHxGGtpR6SfMP4Qu9Bj/vDQpJYiA0h8mPjANrdwOWXzlnzimYgXa7ix6ONUhXgE+neQNqZUOqxdghroyWEQSK9qtdBppmtYr6yYbBOUBnZsMyJ3zg+o6ODw59TUZtZnGT83DDq2R68eu6mJbs8rnMIeNAOnM5Ugu2Y0obC0+uNzU2bPZIv0Bt8CIpnmwCXNLi/mkD1F55m07mGrlbTvBPIbg3b9Aq6zlK8ot5wsoQqKnm7rpzzDVsN2JHBIOqwYeQlSf0fmuttCmdMPVGQLAlxSX5OeEdF2SE7vzD1fBVO+7kiC2qEaXW2W1uSBtz/f3BZfx8EUlRQ6+jWV5deidMQVIx7rVDzI8xY/AsStYyUxV1JU7EXfJMAU51HJy/YD31hklBFEk34gg/8YPgALjoFMTytYumSTo2i5OhHFjSpd1Lfw0oVCInHf3vc+tVJhzeVuQ9R4dnBykL8+jCvMtkZgB31qqBSyVNV+0WumIuDbZLbo3zMmq64elYIAv4E8QKmNFKVkonQRbyAb96gmLghsCxl4f+mi1wYrFYDZoxZ/z0snNo3ghWFHJymQukn0w== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(44832011)(26005)(53546011)(4326008)(478600001)(186003)(426003)(40480700001)(36860700001)(336012)(47076005)(2616005)(40460700003)(16576012)(5660300002)(82310400005)(54906003)(110136005)(8936002)(8676002)(70206006)(41300700001)(70586007)(4744005)(316002)(86362001)(31696002)(82740400003)(36756003)(356005)(2906002)(81166007)(31686004)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 10:41:30.8036 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 720b5abf-78c2-4923-4c45-08dabcbecdc4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT040.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7622 Hi Ayan, On 31/10/2022 16:13, Ayan Kumar Halder wrote: > > > Refer Arm IHI 0069H ID020922, 12.5.23, ICC_SGI1R is a 64 bit register on > Aarch32 systems. Thus, the prototype needs to change to reflect this. NIT: prototype means function declaration. vgic_v3_to_sgi is a function that has no prototype. Apart from that: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 02 10:46:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 10:46:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435793.689567 (Exim 4.92) (envelope-from ) id 1oqBGk-0003x9-JP; Wed, 02 Nov 2022 10:46:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435793.689567; Wed, 02 Nov 2022 10:46:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqBGk-0003x2-G2; Wed, 02 Nov 2022 10:46:50 +0000 Received: by outflank-mailman (input) for mailman id 435793; Wed, 02 Nov 2022 10:46:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqBGj-0003ww-LF for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 10:46:49 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6260536-5a9b-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 11:46:48 +0100 (CET) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-125-1q4mtTQAPNuEtsnvf-t5lw-1; Wed, 02 Nov 2022 06:46:46 -0400 Received: by mail-wm1-f70.google.com with SMTP id i7-20020a1c3b07000000b003c5e6b44ebaso913272wma.9 for ; Wed, 02 Nov 2022 03:46:45 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id c18-20020a05600c0a5200b003b3365b38f9sm1701531wmq.10.2022.11.02.03.46.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 03:46:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6260536-5a9b-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667386007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iUJvEUx8gtjx3iaw6xY22YZZMkx+Fxj3A7QQSAUB80Y=; b=IdsGxcpc/b9eri3/F2vdOUh/cr0GJaUlcfrvfXm5M1ivFv5rIhWx6/D/pKE538YSPP5rTI dnD7I+fjmyuhuvWBoCiKKCvwlRz6YgWk+A/vS3qXmahAei/2tst2AFgeuCYRtXXo0TJL7L IuJ/qqE+hcToYJ3azmb4wt9N7PXsAw8= X-MC-Unique: 1q4mtTQAPNuEtsnvf-t5lw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iUJvEUx8gtjx3iaw6xY22YZZMkx+Fxj3A7QQSAUB80Y=; b=tWLKbiuNlG8zIIFMrYwo625rnQ8F5z4fbWecZjuYzkar8hzNncuDVozt0se4+/FD7e KorWeheV6MhHfPD1D2sNI5o8E/JaHnzev9kdR8YJVg8f393PUDGT5CoFc8XnacCYxnDU JQCcWs9koj2kQtrEi/wUdTwbH6rNKbZ3usUc0vjqIiqCca3VoUZtIVjhrj82a/VjuFDG BBJIVSCQ+6oqS3wlYkIs1dXLlZZOEuyGogqJv3T63RtdP/QabE6HkFZ0yYJI0tT1/UET lIj4qIqazApU2EJKKxglzaQE1qzGiu3ioY14MDzZ4s4GvjGzHfbW3+3iYLAQ+b0wHucb RBbA== X-Gm-Message-State: ACrzQf1HwW8h+f7fD36CRkbDPFVhUTl/2czIsTAhbUY9KYNKU9IG+qSs aD3/BSkH4QOrLFTnTds0sZ+EBby7ngH0NTu2CVcMx7/1UZr6KIh4IoOWsR7bGk+aQRaJFwdXn8e 8DVIuz325o6u7Mo4iA7IIAJBg0N4= X-Received: by 2002:a05:600c:3556:b0:3ca:771d:701a with SMTP id i22-20020a05600c355600b003ca771d701amr14652012wmq.61.1667386004902; Wed, 02 Nov 2022 03:46:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5jzv0egtLEIAVaxEN/tayyZgqvKvq+1qzahuWoTfzpPIfJE04AyAO6MvJnCllXJsp0I0J18w== X-Received: by 2002:a05:600c:3556:b0:3ca:771d:701a with SMTP id i22-20020a05600c355600b003ca771d701amr14651998wmq.61.1667386004691; Wed, 02 Nov 2022 03:46:44 -0700 (PDT) Message-ID: <5abf94d6-9a48-525e-c562-605529c5793a@redhat.com> Date: Wed, 2 Nov 2022 11:46:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 17/21] drm/fb-helper: Perform all fbdev I/O with the same implementation To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-18-tzimmermann@suse.de> <3ab32fc3-f2aa-1b42-fd87-557482ab56d5@redhat.com> <0ca70b76-c24a-4fdb-cf0d-2647d37379df@suse.de> From: Javier Martinez Canillas In-Reply-To: <0ca70b76-c24a-4fdb-cf0d-2647d37379df@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/2/22 11:33, Thomas Zimmermann wrote: [...] >> >>> +static ssize_t __drm_fb_helper_write(struct fb_info *info, const char __user *buf, size_t count, >>> + loff_t *ppos, drm_fb_helper_write_screen write_screen) >>> +{ >> >> [...] >> >>> + /* >>> + * Copy to framebuffer even if we already logged an error. Emulates >>> + * the behavior of the original fbdev implementation. >>> + */ >>> + ret = write_screen(info, buf, count, pos); >>> + if (ret < 0) >>> + return ret; /* return last error, if any */ >>> + else if (!ret) >>> + return err; /* return previous error, if any */ >>> + >>> + *ppos += ret; >>> + >> >> Should *ppos be incremented even if the previous error is returned? > > Yes. It emulates the original fbdev code at [1]. Further down in that > function, the position is being updated even if an error occured. We > only return the initial error if no bytes got written. > > It could happen that some userspace program hits to error, but still > relies on the output and position being updated. IIRC I even added > validation of this behavior to the IGT fbdev tests. I agree that this > is somewhat bogus behavior, but changing it would change long-standing > userspace semantics. > Thanks for the explanation, feel free then to also add to this patch: Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From xen-devel-bounces@lists.xenproject.org Wed Nov 02 11:29:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 11:29:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435804.689598 (Exim 4.92) (envelope-from ) id 1oqBvc-0001lo-2U; Wed, 02 Nov 2022 11:29:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435804.689598; Wed, 02 Nov 2022 11:29:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqBvb-0001lg-Qn; Wed, 02 Nov 2022 11:29:03 +0000 Received: by outflank-mailman (input) for mailman id 435804; Wed, 02 Nov 2022 11:29:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqBva-0001la-Ks for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 11:29:02 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8adafbb8-5aa1-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 12:29:00 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8adafbb8-5aa1-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667388539; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Q3hcdcZDvwBPZ68PKud/zS5YU2lxoxIAcF5oBaqlgss=; b=QPu4AzWy4kEJ23UeXVL8wCm60H6ufkzQvR1xAeLZd6TxuADB+PTA1Wo3 ECN/dOql63fSviwh/+1jbt7KY7+hjAiqafHe3O0Z+UMsEs3Hqn+aztWaZ QG4jYOnuLcbbXtfnZb6Wd6QmYAMt4swvVTesjReBtdtsJrG2BdVRBNS98 M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 84426188 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:GUflZqg/eEi4awlmjgryQet/X161rRAKZh0ujC45NGQN5FlHY01je htvD2vXafyKM2H2f9ojboW+/U5VvZ7cnNUxSAJqrys3QyMb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWv0N8klgZmP6oS5QeEzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQnBBsyYRq8m96L3b3lT8ByqpsnJ+T0adZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglH2dSFYr1SE47I6+WHJwCR60aT3McqTcduPLSlQthbE+ jiYpjSpav0cHIa11COBo0yPvN3exQb/YZwPHeCTxMc/1TV/wURMUUZLBDNXu8KRiESzRtZeI Ew84Tc1oO4580nDZsb5dw21pjiDpBF0c9hNF+w37imdx6yS5ByWbkAkQzhbeZoZvck5bTUw0 xmCmNaBLSxitviZRGyQ8p+QrCiuIm4FIGkafygGQAAZpd75r+kblQnTR9xuFKq0iNzdGjzqx T2O6i8kiN0uYdUjjvvhuwqd2nT1+8aPHlVdChjrsnyN0S9SW4GvWJCU1EXUs/NpMqrGSlKso y1R8ySB19wmAZaInS2LZewCGrC1+vqIWAHhbU5T84oJrGr0pSP6FWxEyHQnfRoybJ5YEdP8S BWL0T698qO/K5dDgUVfR4uqQ/onwqH7fTgOfqCFN4EeCnSdmeLuwc2PWaJy9zqz+KTPuftlU Xt+TSpLJS9DYZmLNBLsG48gPUYDn0jSP1/7S5Hh1AiA2rGDfnOTQrptGALQML9itvzb+FSEq oo32y62J/J3CbOWX8Uq2dRLcQBiwYYTWPgaVPC7hsbce1E7SQnN+tfawK87epwNokimvr6gw 51JYWcBkQKXuJEyAV/VApyVQO+wAM0XQLNSFXBEAGtELFB6P9j/t/9PJsVpFVTlncQ6pcNJo zA+U53oKpxypv7volzxsbGVQFReSSmW IronPort-HdrOrdr: A9a23:2H7z9q4RJyP/TY5rugPXwMLXdLJyesId70hD6qhwISY7TiX+rb HKoB17726StN9/YhAdcLy7VZVoIkmsl6Kdg7NwAV7KZmCP0wGVxelZnO/fKlbbdREWmNQw6U 4ZSdkcNOHN X-IronPort-AV: E=Sophos;i="5.95,232,1661832000"; d="scan'208";a="84426188" From: Anthony PERARD To: CC: Henry Wang , Anthony PERARD , Stefano Stabellini , George Dunlap , Wei Liu , Jan Beulich , Andrew Cooper , Julien Grall Subject: [XEN PATCH for-4.17 0/4] Fixing some licences issue in public headers Date: Wed, 2 Nov 2022 11:28:50 +0000 Message-ID: <20221102112854.49020-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.licences-fix-public-headers-v1 Hi, Andrew pointed out some licences issue: https://lore.kernel.org/xen-devel/b58f5340-d4fa-df9d-89de-6137005add77@citrix.com/T/#u tracked here: https://gitlab.com/xen-project/xen/-/issues/35 So I attempt to fix them with this series. For 4.17: This mostly change "documentation" so little risk for those patch, except "xen-foreign: Capture licences from the input headers" which changes "mkheader.py" which could generate broken headers. Anthony PERARD (4): xen: Add licence information to public/errno.h tools/include/xen-foreign: Capture licences from the input headers xen: Add licence header to device_tree_defs.h Rework COPYING installed in /usr/include/xen/, due to several licences tools/include/Makefile | 1 - xen/include/public/device_tree_defs.h | 6 ++++++ xen/include/public/errno.h | 2 ++ tools/include/xen-foreign/mkheader.py | 15 +++++++++++++-- tools/include/xen/COPYING | 26 ++++++++++++++++++++++++++ 5 files changed, 47 insertions(+), 3 deletions(-) create mode 100644 tools/include/xen/COPYING -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Nov 02 11:29:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 11:29:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435805.689609 (Exim 4.92) (envelope-from ) id 1oqBvk-00022r-6b; Wed, 02 Nov 2022 11:29:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435805.689609; Wed, 02 Nov 2022 11:29:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqBvk-00022k-2b; Wed, 02 Nov 2022 11:29:12 +0000 Received: by outflank-mailman (input) for mailman id 435805; Wed, 02 Nov 2022 11:29:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqBvi-00021c-Ng for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 11:29:10 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8f745791-5aa1-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 12:29:07 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f745791-5aa1-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667388547; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=sdBaG8nza+w2eZvi73Kk9Zj+hZVkMYunpXxpVdr9hzQ=; b=g8rtRZ2qw0KHt3/bu6i6daM8MWTNKGiFKOV/mDoCJogV9FCAgEHQJ9dZ h4SpmUx3A9J7aHEPhvangoYNkDFxTw7Pc+m7lHTyOpK56Fzysc61/uNFX DLPHShzpyfxv7onrRlRy0+D4+/9wN++YPOzGEJGFELW86KCWbWy0Ydsfh 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 84016366 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:wwnYDKoVDoZP1FIIzQGUGXinGBheBmLVZRIvgKrLsJaIsI4StFCzt garIBnUM/iPMzahLdEla9uzoRsAvJCGxoBgTwc+rilgRCxB95uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W5wUmAWP6gR5gaHzyNNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADBVcSC52fz1/KmybehypMMHC9bkGqpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFHU/rSn8/x7pX7WzRetFKSo7tx+2XJxRZ9+LPsLMDUapqBQsA9ckOw9 j6epjqiXE9y2Nq3xSC182yehPL1uzLSSK43L7K2x85WjwjGroAUIEJPDgbqyRWjsWa8RtZeJ ko86ico668o+ySDTNPwQhm5q36spQMHVpxbFOhSwB6J4rrZ5UCeHGdsZiVadNUsucsyRDor/ lyEhdXkAXpoqrL9YVKQ8K2F6wy7Pyc9JHUHIyQDSGMt89Tl5Y0+kB/LZtJiC7KuyM34Hynqx DKHpzR4gK8c5fPnzI3iowqB2Wj14MGUEEhlvW07Q15J8Ct5PJGVXdK2qmTA5NFBMqSean6es 14tzp32AP81MbmBkymEQeMoFb6v5uqYPDC0vWODD6XN5Bz2pSf9INk4DCVWYR4wb51aIWOBj Fr741s52XNFAJe9gUabiaqVAt9i86XvHM+Nuhv8PosXOcgZmONqEUhTia+sM4LFyhZEfUIXY 83znSOQ4ZEyUP0P8dZOb71BuYLHPwhnrY8pebj1zg68zZ2Vb2OPRLEOPTOmN75ns/je/1qNo ocGa6NmLimzt8WnPEHqHXM7dwhWfRDX+7irwyCoSgJzClU/QzxwYxMg6bggZ5Zkj8xoehTgp xmAtrtj4AOm3RX6xfCiMC8LhEXHAcki9hrW/EUEYT6V5pTUSd/xsvdEL8tmI+dPGS4K5accc sTpsv6oWpxnIgkrMRxEBXUhhOSOrCiWuD8= IronPort-HdrOrdr: A9a23:orygW6E5DywoYn+EpLqE7seALOsnbusQ8zAXP0AYc3Nom6uj5q eTdZUgpGbJYVkqOU3I9ersBEDEewK/yXcX2/h0AV7BZmnbUQKTRekIh7cKgQeQfhEWntQts5 uIGJIRNDSfNzRHZL7BkWqFL+o= X-IronPort-AV: E=Sophos;i="5.95,232,1661832000"; d="scan'208";a="84016366" From: Anthony PERARD To: CC: Henry Wang , Anthony PERARD , Andrew Cooper , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH for-4.17 1/4] xen: Add licence information to public/errno.h Date: Wed, 2 Nov 2022 11:28:51 +0000 Message-ID: <20221102112854.49020-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221102112854.49020-1-anthony.perard@citrix.com> References: <20221102112854.49020-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Fixes: 81f559e97974 ("make error codes a formal part of the ABI") Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD --- xen/include/public/errno.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/include/public/errno.h b/xen/include/public/errno.h index 5c53af6af9..6bdc8c5079 100644 --- a/xen/include/public/errno.h +++ b/xen/include/public/errno.h @@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: MIT */ + /* * There are two expected ways of including this header. * -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Nov 02 11:29:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 11:29:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435806.689620 (Exim 4.92) (envelope-from ) id 1oqBvq-0002M0-ER; Wed, 02 Nov 2022 11:29:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435806.689620; Wed, 02 Nov 2022 11:29:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqBvq-0002Lo-9W; Wed, 02 Nov 2022 11:29:18 +0000 Received: by outflank-mailman (input) for mailman id 435806; Wed, 02 Nov 2022 11:29:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqBvo-00021c-N6 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 11:29:16 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 944c0787-5aa1-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 12:29:15 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 944c0787-5aa1-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667388555; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pr0JfmwP5/FWVhK0t5YQqcQll6KmEYKssZtRV/z9j94=; b=UMMiSzEnIy3yybdqtVAE/goJXOZnIS4g04N/vpLt77TZjbNKqpwlKJBf 8W82RDZira55YRqW1wvl35l+m5V4pt0/d8k+IYJeGlfT5dko6oqgwz2ed 0ErxmmXiJ9VvmOmbLrBB1CeeZqSpZgVT1iIgPAw4rBa59MDS7CdaTu3Pv g=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 84016409 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:aRFRLKC8Hj8+IhVW/+Tjw5YqxClBgxIJ4kV8jS/XYbTApD9xhDIHz GMXWGjQOK3eZTP8fd93Yd7n8x5XucKHmIVlQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WpA5ARnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwxeV7OERI2 sUjDTkOLUzSgumcwZicVbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/AZQinOCulz/nfidRsl69rqsr+WnDigd21dABNfKFJoTTG5kNzy50o Ere43TYBSwYGuW11GGOyTGMmevJtzH0Ddd6+LqQqacx3Qz7KnYoIB8LUVq2p9Gph0j4XMhQQ 2QP4TYnp6U28E2tT/H+Uge+rXrCuQQTM/JPF8Uq5QfLzbDbiy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313peZqymjfxccK2AqbDUBCwAC5rHLoos+kxbORdZLC7Oug5v+HjSY/ tyRhHFg3fNJ15dNjvjluwCc696xmnTXZjE26jzyWE2c1SZwZ835Nomjw1nxyukVee51UWK9l HQDnsGf6sUHApeMiDGBTY0xIV252xqWGGaC2AAyRvHN4xzooif+Jt4IvFmSMW8zaq45lSnVj Fg/UO+7zLtaJzOUYKB+eOpd4Ox6nPG7RbwJuh05B+eig6SdlifdokmChmbKhQgBdXTAdolmY P+mnT6EVypyNEie5GPeqx0h+bEq3Dsi4mjYWIr2yR+quZLHOiDKEu1abwPfP7llhE9hnOky2 48BX/ZmNj0FCLGuCsUp2dN7wa82wYgTWsmt9p0/mh+rKQt6AmAxY8I9Mpt4E7GJa599z76Ql kxRr2cClzITc1WbdljRAp2iAZuzNatCQYUTZHJybQ3wiyl9P+5CLs43LvMKQFXuz8Q7pdYcc hXPU5zo7ihnItgfxwkgUA== IronPort-HdrOrdr: A9a23:Nf8BuKhH4RKMi8ondNUPty3BtXBQXuIji2hC6mlwRA09TySZ// rBoB19726TtN9xYgBZpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5 0QF5SWYOeAdGSS5vya3ODXKbkdKaG8gcKVuds= X-IronPort-AV: E=Sophos;i="5.95,232,1661832000"; d="scan'208";a="84016409" From: Anthony PERARD To: CC: Henry Wang , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Andrew Cooper Subject: [XEN PATCH for-4.17 2/4] tools/include/xen-foreign: Capture licences from the input headers Date: Wed, 2 Nov 2022 11:28:52 +0000 Message-ID: <20221102112854.49020-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221102112854.49020-1-anthony.perard@citrix.com> References: <20221102112854.49020-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The headers install in "/usr/include/xen/foreign/" are missing a licence. While we could probably just add the MIT licence to the generated file, this patch instead try to grab the licence from the original input file. Since licences are in the first multiline C comments, we just look for that. Also with this patch, the possible licences will not be in the "input" variable anymore, but it should be unnecessary to generate the foreign header. With this change, the licence will be copied 2 or 3 time in the install headers depending on the number of input headers. Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD --- Notes: Maybe instead of this, we should just stamp this on the generated header /* SPDX-License-Identifier: MIT */ but we would be missing the "Copyright" informations. I guess we could look for those line with Copyright and copy them. Or, we could replace the licence in the input header by a SPDX and have the script parse that. (Probably still need to grab the Copyright lines) CC: Andrew Cooper CC: George Dunlap CC: Jan Beulich CC: Julien Grall CC: Stefano Stabellini CC: Wei Liu tools/include/xen-foreign/mkheader.py | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/tools/include/xen-foreign/mkheader.py b/tools/include/xen-foreign/mkheader.py index fb268f0dce..07a9bcbd01 100644 --- a/tools/include/xen-foreign/mkheader.py +++ b/tools/include/xen-foreign/mkheader.py @@ -114,9 +114,19 @@ input = ""; output = ""; fileid = re.sub("[-.]", "_", "__FOREIGN_%s__" % outfile.upper()); -# read input header files +# Try to captures licences headers from original files. +# heuristic: just look for the end of the first multiline comment. +licence_headers = ""; + for name in infiles: f = open(name, "r"); + while True: + line = f.readline() + if not line: + break + licence_headers += line + if line == " */\n": + break input += f.read(); f.close(); @@ -126,11 +136,12 @@ output += """ * public xen defines and struct for %s * generated by %s -- DO NOT EDIT */ +%s #ifndef %s #define %s 1 -""" % (arch, sys.argv[0], fileid, fileid) +""" % (arch, sys.argv[0], licence_headers, fileid, fileid) if arch in header: output += header[arch]; -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Nov 02 11:29:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 11:29:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435810.689631 (Exim 4.92) (envelope-from ) id 1oqBw4-00031w-RT; Wed, 02 Nov 2022 11:29:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435810.689631; Wed, 02 Nov 2022 11:29:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqBw4-00031H-N5; Wed, 02 Nov 2022 11:29:32 +0000 Received: by outflank-mailman (input) for mailman id 435810; Wed, 02 Nov 2022 11:29:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqBw3-0001la-Mm for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 11:29:31 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d1f519b-5aa1-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 12:29:30 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d1f519b-5aa1-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667388570; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AB+G/K/xEbC4EusmJ8MPpns5BVj+9RqzmSAPIYA2wGU=; b=NXTdvWjGyf3h6zo9Yw5Q1yfAEKpPFcR/xrkDQ2SSmzq1mYhmCplpe/bG ZEtOdOck3tMYhK7r7vfcIBaf3E8B5VD/qwVf10yspyVIsJiRNVuGqS4a+ 19frH49J7IeX/F+1hL7muSE1LlT1HDlJrPUkSbOPZAgD/hgUe8AV0mhZ/ 4=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 83088809 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:CYfMjKnEl0wY812IrSadzNjo5gxMJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIXCmCFbPjYamOke98gYNnk9B9Sv8KHx9VnGwQ4ryE2RiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7amaVA8w5ARkP6kS5AWGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 cBfAT1OMh3eu8js77iDVsl02OgRa+C+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsfYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9zh3A9 jKWpzWR7hcyFf2iwzrVqW2WvbH13jHFR98SMZfl+as/6LGU7jNKU0BHPbehmtG7l0q/VtR3O 0ESvC00osAa9kamU938VB2Qu2Ofs1gXXN84O/I+wBGAzOzT+QnxLnMfUjdLZdgitck3bT8nz FmEm5XuHzMHmJ2YT2iMsIidqzyaMDIQa2QFYEcsXQYDptXuvow3phbOVcp4Vr64iMXvHjP9y CzMqzIx74j/luZSif/9pwqexWvx+N6ZFWbZ+zk7QEqZqSp0J9KoOrCCs3fR1epgNNi1fB6o6 S1sd9el0MgCCpSElSqoSeoLHa206/vtDAAwkWKDDLF6qW3zpifLkZR4pWgneRw3appslSrBO he7hO9H2HNE0JJGh4dTapn5NcklxLOI+T/NBqGNNYomjnScmWa6EMBSiay4hT6FfKsEy/tX1 XKnnSGEVC9yNEif5GDqL9rxKJdyrszE+UvdRIrg0zOs2qeEaXieRN8taQXQMbtjs/zc8VSMr 76z0vdmLD0GDoXDjtT/q9ZPfTjm01BmbXwJlyCnXrHaeVc3cI3QI/TQ3akga+RYc1d9z4/1E oWGchYBkDLCaYjvc1rihoZLNOyyBv6SbBsTYUQRALpf8yF9P9b0tPdOKcVfkHtO3LUL8MOYh sItI62oasmjgByek9jBRfERdLBfSSk= IronPort-HdrOrdr: A9a23:y8jkm60oc9XWbeQ+BIbaKgqjBLgkLtp133Aq2lEZdPRUGvb2qy nIpoV/6faUskd3ZJhOo7G90cW7LE80lqQFg7X5X43DYOCOggLBR+tfBOPZslnd8kbFmNK1u5 0NT0EHMqySMWRH X-IronPort-AV: E=Sophos;i="5.95,232,1661832000"; d="scan'208";a="83088809" From: Anthony PERARD To: CC: Henry Wang , Anthony PERARD , Andrew Cooper , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH for-4.17 3/4] xen: Add licence header to device_tree_defs.h Date: Wed, 2 Nov 2022 11:28:53 +0000 Message-ID: <20221102112854.49020-4-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221102112854.49020-1-anthony.perard@citrix.com> References: <20221102112854.49020-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This header have been created by moving code from other part of the project and miss a licence header. The original source code was some version of GPL or LGPL but we intend to have the public header to be MIT so they can be included easily in other projects. Part of device_tree_defs.h were moved from libxl_arm.c which is LGPL-2.1-only. And part were moved from device_tree.h that is GPL-2.0-only. Part of the original code were added by Julien Grall @ Citrix with a Linaro "hat" in commits c3ba52a84dd8 and 405c167f0ec9 and 886f34045bf0. The other part were added by Ian Campbell @ Citrix, with commit 0c64527e7fc9. Resolves: xen-project/xen#35 Fixes: 1c898a9fec7e ("xen/arm: move a few DT related defines to public/device_tree_defs.h") Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD --- Notes: Julian was working @citrix until 2015. xen/include/public/device_tree_defs.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/device_tree_defs.h index 228daafe81..9e80d0499d 100644 --- a/xen/include/public/device_tree_defs.h +++ b/xen/include/public/device_tree_defs.h @@ -1,3 +1,9 @@ +/* SPDX-License-Identifier: MIT */ +/* + * Copyright (c) 2013 Linaro Limited + * Copyright (c) 2015 Citrix Systems, Inc + */ + #ifndef __XEN_DEVICE_TREE_DEFS_H__ #define __XEN_DEVICE_TREE_DEFS_H__ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Nov 02 11:29:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 11:29:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435811.689642 (Exim 4.92) (envelope-from ) id 1oqBw6-0003J5-3b; Wed, 02 Nov 2022 11:29:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435811.689642; Wed, 02 Nov 2022 11:29:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqBw6-0003Iw-0G; Wed, 02 Nov 2022 11:29:34 +0000 Received: by outflank-mailman (input) for mailman id 435811; Wed, 02 Nov 2022 11:29:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqBw4-00021c-LX for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 11:29:32 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9d915115-5aa1-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 12:29:31 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d915115-5aa1-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667388571; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2iKsKAFpwVBDCeJ/fX/gBxBJJ7BZRdN62cOsn36HHnw=; b=V4KFPLgdYG0ybIjKl0MD3IQK82Jjk9STaCRte8OG1XWMrBwRgAo02oCO tXh4POskyAhMlbjLy0g+83JUlfQP03fbekzr+HfC8ZF1ZcAVsESH4b3Vf o0J/vrhwRWel8/fcV/rQqHT2UAn/7gFSHWiNEutb+nrCkmi+vC4oGB1TV c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 83996305 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:s4qQOK2AQLakYsWWePbD5R5xkn2cJEfYwER7XKvMYLTBsI5bpzZTy mRODW3QbvqPY2f1LY13bYm+pkNS7cLVndFiGVRqpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wVmP6gS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfL21o3 vkbGio0ay+dle7o4LeGEfdXmZF2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKkSbC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TaHpQEwB3A+ woq+UzaAghDBMKW4wDf822lierGmz39AKsrQejQGvlC3wTImz175ActfVmmpfi0jGauVtQZL FYbkgI1trQ7/kGvStj7XjW7rWSCsxpaXMBfe8Ul7Cmdx6yS5ByWbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hRO/PzIEa1ALYyAsRBEApdLkpekbjBjCU9JiG66dlcDuFHf7x DXikcQlr+xN14hRjfz9pA2ZxWL3znTUcuIrzivbeEmg7TFjXYuaeZ6kt3je0K1eF5nMGzFto 0M4s8SZ6ekPC7SEmyqMXPgBEdmV2hqVDNHPqQUxRsd8rlxB71bmJNkNu28meC+FJ+5eIVfUj FnvVRS9DXO5FF+jdudJbo24EKzGJoCwRI2+Bpg4gjejC6WdlTNrHgk0OyZ8PEi3yiDAdJ3T3 r/CKK6R4Y4yU/gP8dZPb751PUUX7i4/33jPYpvw0g6q17GTDFbMF+laawHRMbhovfrYyOkwz zq4H5LUoyizrcWkOnWHmWLtBQ1iwYcH6WDe9JUMK7/rzvtOE2A9Ef7BqY7NiKQ895m5Ytzgp yjlMnK0PXKl2hUr3y3WNS04AF4uNL4jxU8G0dsEZAj2iyN7Mdfxss/ytfIfJNEayQCq9tYsJ 9FtRilKKq0npujvk9jFUaTAkQ== IronPort-HdrOrdr: A9a23:9RKjeaiEwa2Sfx9CX3dWuqmBXHBQXtwji2hC6mlwRA09TySZ// rAoB19726StN9xYgBYpTnuAsi9qB/nmKKdpLNhX4tKPzOW3FdATrsD0WKK+VSJcEfDH6xmpM JdmsBFebvN5DNB4/oSjjPVLz9Z+qjlzJyV X-IronPort-AV: E=Sophos;i="5.95,232,1661832000"; d="scan'208";a="83996305" From: Anthony PERARD To: CC: Henry Wang , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Andrew Cooper Subject: [XEN PATCH for-4.17 4/4] Rework COPYING installed in /usr/include/xen/, due to several licences Date: Wed, 2 Nov 2022 11:28:54 +0000 Message-ID: <20221102112854.49020-5-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221102112854.49020-1-anthony.perard@citrix.com> References: <20221102112854.49020-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The notice in the COPYING file in "xen/include/public/COPYING" doesn't really apply to the files that ultimately are been install at "/usr/include/xen". The issue are headers in the "sys/" subdirectory that comes from other projects such as Linux or FreeBSD. The main issue is that there are two headers that have a different licence than the MIT licence: - xen-sys/Linux/gntalloc.h (installed as "sys/gntalloc.h") is public domain. - xen-sys/FreeBSD/gntdev.h (installed as "sys/gntdev.h") is BSD-2. To clarify this, we'll install a COPYING file with a different notice. Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD --- Notes: CC: Andrew Cooper CC: George Dunlap CC: Jan Beulich CC: Julien Grall CC: Stefano Stabellini CC: Wei Liu tools/include/Makefile | 1 - tools/include/xen/COPYING | 26 ++++++++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 tools/include/xen/COPYING diff --git a/tools/include/Makefile b/tools/include/Makefile index 81c3d09039..f838171e8c 100644 --- a/tools/include/Makefile +++ b/tools/include/Makefile @@ -24,7 +24,6 @@ xen-foreign: xen-dir: mkdir -p xen/libelf acpi find xen/ acpi/ -type l -exec rm '{}' + - ln -s $(XEN_ROOT)/xen/include/public/COPYING xen/ ln -s $(XEN_ROOT)/xen/include/public/*.h xen/ ln -s $(XEN_ROOT)/xen/include/public/*/ xen/ ln -s ../xen-sys/$(XEN_OS) xen/sys diff --git a/tools/include/xen/COPYING b/tools/include/xen/COPYING new file mode 100644 index 0000000000..e54eb79832 --- /dev/null +++ b/tools/include/xen/COPYING @@ -0,0 +1,26 @@ +XEN NOTICE +========== + +This licence applies to all files within this subdirectory ("/usr/include/xen") +with the exception of "sys/" which may include an header under public domain or +BSD-2 licence. + +===================================================================== + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to +deal in the Software without restriction, including without limitation the +rights to use, copy, modify, merge, publish, distribute, sublicense, and/or +sell copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in +all copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER +DEALINGS IN THE SOFTWARE. -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Nov 02 11:49:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 11:49:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435832.689653 (Exim 4.92) (envelope-from ) id 1oqCFG-0007SI-Oc; Wed, 02 Nov 2022 11:49:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435832.689653; Wed, 02 Nov 2022 11:49:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqCFG-0007Rs-I2; Wed, 02 Nov 2022 11:49:22 +0000 Received: by outflank-mailman (input) for mailman id 435832; Wed, 02 Nov 2022 11:49:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqCFF-0007Rm-0u for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 11:49:21 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2086.outbound.protection.outlook.com [40.107.21.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 62020c41-5aa4-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 12:49:18 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8180.eurprd04.prod.outlook.com (2603:10a6:20b:3e2::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 11:49:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 11:49:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62020c41-5aa4-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SaJFsM4e3L/K4+b/Fh8kPXvxCmm0ZuIZzIhbhHR3uKpeLqkQF5ByQ2tjjJYav8/18/YuIqPuQ7lM1pkv+Xg20j2Vt6yJtXbbTpbpSzLnkeaYVOTfhHP1f2YiGQHqzEKWY1H+b6ahWE8IOvto8zNVZkO8vbPM4iWaDzRUHVRq73Jb60SZkcjRr8rc+1YQKDGa10EtjwlKm+EQbPDQ8iHik3Rq5OFy/Z/Fg7nbpELSGaxG9YaF96RuD23JkvVvufKAnd76Y+qf450+ABdnalfRA/Kbcib6N6WCUfcUNj5w9xgl4tVbaKDPQB8YYGeYu5N/q+OFbn/7d2cAAbvaEYi9jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xOU5Dky2cwCRpHacYiYggxCYvslZlCxBQUq8SWKcpbA=; b=QUqvS1cHGcODVFVFoMEE3OdIvQRgiyY3KPcqrQR3NJaAJJBgZBxf7B6O9MfL7TB13Enji57Xu1qYDge9H64WI7sX4MldV9Z+8ntTsnpCGfLpOSNUttG72fHq6t2PF72L6867EYpN5lF4OYLEQUtMSqG4Hq0ka3s9KIJSiuKRwrBP7og/YI7ZJvpdeS2L1Y/ss3KKud5gD+9yjlJ53Lv9zgkacNAOa9NtPSPjGzxlarB+djiz3ntKmRvHURYP5WgeV8zRqh1evKix+/Mtjfo/YohtZdQ/5+KGI43v9vkQxYTZ2u2uDNY04yQJRAEYl3SCq9bCl9qQq+0rVZcHRoXlfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xOU5Dky2cwCRpHacYiYggxCYvslZlCxBQUq8SWKcpbA=; b=ZBv7tvkkPTvgIYQhCRgAoHp8TLLxCckIDlzuq5HItpZAREGtGumY9H+uy7Hj8lFgN0vHZwdlh4QLaYAy+d3T/akDLgcuYQA+PCHwuPgtjMq2t4Yp4ZpMtpQwzaL3GmdaREtIXxqum684vpuGPmGVkFqK/tD44ETJ0UE+AgPIL/W0AIxr34YB/Zl1F5VHGqMWriQFZQQuMq9ZSIXo8/qoTpLF7IedfNb4gWXuTkrNXv0ouBQJGwBqvceN6kUVuhFAb0XW3gqkk/NyXiun3+alOlmJhJBG1x67UP20z00dN4aASxiZ5r3Djbnm4vNzMeBlZpRuz/sJkbJsIJsWKNRYwQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <198d04be-e7f2-dc11-18b7-ef3352d07b80@suse.com> Date: Wed, 2 Nov 2022 12:49:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 v2.1 2/3] amd/virt_ssbd: set SSBD at vCPU context switch Content-Language: en-US To: Roger Pau Monne Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20221028114913.88921-3-roger.pau@citrix.com> <20221029131258.95811-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20221029131258.95811-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P193CA0065.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::42) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8180:EE_ X-MS-Office365-Filtering-Correlation-Id: 39c24fbe-617b-4ef3-5b78-08dabcc84584 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kFkDrMx0yfAwuU3a1zk/IOHptL+PTNEnK14rAugfOEpYdWT5sanEGyZ7GGigLDFmaEJOkOMH1QwIwnn8Y/NqkxSAGOVv5jHseWHzZZnvAPeCivCmjR2w9ulZviONLGGw+gJ7lteoMTwE52Fh0yPTOPe+smcD+sWJpkiBtZAOQS2etXNsrdDvGvy3R8qCyD90dJ4VwVNHKE1QaEcaBHpG4X1vz9NImgjNf4XGQSmCAzdj5CUcMYmLMKRF/J4lsZn0pnraCOxRGB++DYaMSgjEVwhDM+ps7zBQ/smYP5NmOnBTUZlg0usisQi41rsqpk/QNaFo297YpyY4nDOkhB9HM2bK6skMlSjCJFAH4kqGPESSiE6f521AkMmPTzRXBltRCn4TWf0KmPCPcyYGtK9VW7x3iWIe130bvHfOQ5jHc15OqwaTs9QX6fU8VsyfoC5P3wSp+6yVaNMaQii+vL+KDPUYwwm3gEdZCZ6FT+n4eZxLDSL1IgP5butDWooJDo8/O36A02LyCQMV7yzs1onjCsZx4QswK8mcVAeF6Mmt3xjnw0ZqLG5Em+vHh3jGQuzIrMop3lUZV3g6Jok0nrAfd80CeFdLK38YR01HBWR/apb5+nEhidr4R6OejT5aU9kYMqhLFJTLjMDbW8G3Ba6I/d+H0sWvm2Pofskcyx7VWKPlSEceT3otPOA3yyDlcg26UWuBeTHfdoV7JHDzpoYWiHh+42ZS84mWP/w8MYklwe/ALsfeRIWODlxNPYNV2XUPF3Q61hdsXdTnU+ScNJMsn7CxcZfxWS0a21EMIHmyiv0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(346002)(39860400002)(396003)(366004)(451199015)(31686004)(36756003)(8936002)(5660300002)(38100700002)(2906002)(86362001)(31696002)(316002)(26005)(6512007)(6916009)(54906003)(186003)(2616005)(478600001)(6486002)(41300700001)(66946007)(4326008)(66556008)(66476007)(6506007)(8676002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTNwSm4zMnF4MEJpRUhNMzhCU1hwRHl2eXdnTnNiY3dycENzbTRKRGU0aEp3?= =?utf-8?B?Qk0weHE0Z2VNVUZxaDFzRWk1cXl2OVRVRktCb0RNZVFXUHJOSzdjejA2U0dL?= =?utf-8?B?UllxSG9KUjhaV1h3MG5xN1dFcGtsemFFVVcxS1F0VnBFc05SZUxtaWJxNGt5?= =?utf-8?B?YXo3QVpudkVzMmV0alFudDZCUU02TWs2RnZrREJDYVJpQTZMVjFRQUZyZnRH?= =?utf-8?B?TkE0RVhNUHNzZUVFYktQaWtXS2ZCVGErbm5UU3k3ODFSdHUyR1B4ck0wNncr?= =?utf-8?B?UC9nU204QlJlL3RuM3lZQ0dKTVRyN3dFL2dBUk1tMXRWK0h6dDVLd3pGZkZU?= =?utf-8?B?dExQcTV5SW9iVnFGNEgyVlpUVkNYd1ZySldyNkpGdncrR3dGQVExZytwWjRj?= =?utf-8?B?UUdJSjE4N2krK05BSnJWNzRCWjJoUm8ya24yUFUzM2FyZjh4WmVHZjhITndL?= =?utf-8?B?eXNtOHM2dHJyQWVWYTdUdjZpdHh5djZRQThkVnFzNXc1RDliWlBlTXRTK0xP?= =?utf-8?B?bnJyTUhKQlFjWXJKMURPMVV3cGd4V0RuTldVSlNzSGs2cDZkRmxpaVVnNmpY?= =?utf-8?B?cnhLaW9CUEEyY3JlaGV3TkNMY2Z4aEp0U1lnajNuNTBUaHRYRzJZU0ZyOTZ2?= =?utf-8?B?QVpjcjFaM3hEMjR2K2s2TTBpNkdXRGhoK2N2VVhaMGV1K0E4OWYvWnpFS0c1?= =?utf-8?B?SS84ckxZQ0VLYjZYUE93L1VXVmJQZXJROXJab3J0akZGaXIzbURmeVg3eEZB?= =?utf-8?B?dGxaczFnVC9vaWdPaTUrdCtCVUw3dm1rVVNsb0o3dnFGd2dQMVRsN2FVNW9k?= =?utf-8?B?VjJoL0pvL05PL3VVMlQ4ZnEvQmxoMzdEeWJyWERPSURlUXE1ZFppNEwrL0FP?= =?utf-8?B?VndtUWlPZW1LTW1DbUVzODY2cnhNVXJkTDQ1K0NZQjVZdmJHU2pSdm81azF3?= =?utf-8?B?ZDNHdUkxSFdOTFZkb0pCMDJDOFRuWkVxMmY5MG5uL1IvcnJnUGQ3RnJBVlpl?= =?utf-8?B?eFh6aWxLS25qdWUzbEF4NWdWRVVXY2U2RWZpQ29hV1VmMXNBejN5WVF1SGNz?= =?utf-8?B?bS9tUnZ6YTIwNzVVS1V5UExPL2pvYXJRNmVlR3VjNGZEa0VIVjkybzZtWWti?= =?utf-8?B?SmNvaTlJZk1OcUVlUmNBRlpkZ0lYT29hS3RZOHFLaVdhSW4vcS9kMitGZE93?= =?utf-8?B?WTJISUJMUDA1a2dSOGNhei9WeUFVUk4wcEdpMGxwazZtVnJpdExVVjBvVGFz?= =?utf-8?B?YjFOK2hrb1dvcW91YmVOdG9PdEdaVWsxYTRqZlh0UWU3alhBNHd1Vlo5ajZX?= =?utf-8?B?SHVnZG1mYnp4YUhzZHFQWGtUais4djFwV0dpaXlBVDhmZkNMRThpWkI0eFFB?= =?utf-8?B?VFdBOVViMlFxQzR4UEtQTGFhWHhDdWJGWk8xQlhGZ2dCYmFodTZDd0NhUy9i?= =?utf-8?B?SGs4TGI1Qi8rVHg0djZqWnVCd3NnOVFjNjhFVkZibFp0d3BURys2SkJBM0px?= =?utf-8?B?Qm44OFUwSXZlaVFNRk1yM2MwcjJGZVNjbnRrNlFNb2o0LzNlU2xCeWVXcTM5?= =?utf-8?B?WU9jRnNFczNicmhHZndVWkd6R01zNGladTI4ZnRvcFIySG1kRTVIOVRZU2Z2?= =?utf-8?B?cWFSakVWaXJYM0xQRjVCSng2M0tYdzBLS0ExU211b3BTVU41ZEJzWHdubFNm?= =?utf-8?B?OFpVa3NpMVNTbmkzczhvSUFTTG1ZUzZrMFJVRXJPRThwdFJtNjd5aVpRY01E?= =?utf-8?B?WXp0NXRGWWttVFF3aFI4V2ZGWkUzbnNJWTVJcVJlMHFNL3cyR0RuOUNuRlNm?= =?utf-8?B?elpjTDY2eHhFZnY0SVgyak02ckhZUTFhWHhSa0x5eXpuMndzVnE2WGk1SEl6?= =?utf-8?B?T0pyM00xeWF2bWdiek43emx3TnliTHZudFRJSWJCVzd4ZzU3dzNuZ3FmbVRn?= =?utf-8?B?VUxBeFZxMy9mN09POVdXSCtKN0VYcVd0dXd1SmR4RklGdERxY0w1OS9uVFRk?= =?utf-8?B?RVd5R1pLKy9ORGRLeUU1Ym9XcE1ENXVleXdrQnhRNUJFZEdCc05keWp3U0Nu?= =?utf-8?B?c3lvTEF4b1BVdkV2WHdFQlozZ2Z4R2lZWHpqYlFTWVROREptd1FHZGtPSkJS?= =?utf-8?Q?sj6kExx3RTnbN09nKsmXqckTb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39c24fbe-617b-4ef3-5b78-08dabcc84584 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 11:49:17.3067 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BFJw4CZRccX4L2q208WZRtF+5OiNUIXZMVXR8k40gxhwybnYMurWQuSYkHwtSaDmTltly2Y+VyANSER8Q2M//w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8180 On 29.10.2022 15:12, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -973,6 +973,16 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v) > > /* Resume use of ISTs now that the host TR is reinstated. */ > enable_each_ist(idt_tables[cpu]); > + > + /* > + * Clear previous guest selection of SSBD if set. Note that SPEC_CTRL.SSBD > + * is already cleared by svm_vmexit_spec_ctrl. > + */ > + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) > + { > + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); > + amd_set_ssbd(false); > + } > } Aren't you potentially turning off SSBD here just to ... > @@ -1000,6 +1010,13 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v) > > if ( cpu_has_msr_tsc_aux ) > wrmsr_tsc_aux(v->arch.msrs->tsc_aux); > + > + /* Load SSBD if set by the guest. */ > + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) > + { > + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); > + amd_set_ssbd(true); > + } > } ... turn it on here again? IOW wouldn't switching better be isolated to just svm_ctxt_switch_to(), doing nothing if already in the intended mode? > --- a/xen/arch/x86/msr.c > +++ b/xen/arch/x86/msr.c > @@ -697,7 +697,15 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) > msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD; > } > else > + { > msrs->virt_spec_ctrl.raw = val & SPEC_CTRL_SSBD; > + if ( v == curr ) > + /* > + * Propagate the value to hardware, as it won't be context > + * switched on vmentry. > + */ I have to admit that I find "on vmentry" in the comment misleading: Reading it I first thought you're still alluding to the old model. Plus I also find the combination of "context switched" and "on vmentry" problematic, as we generally mean something else when we say "context switch". > + goto set_reg; It's not clear why you want to use hvm_set_reg() in the first place - the comment says "propagate to hardware", which would mean wrmsrl() in the usual case. Here it would mean a direct call to amd_set_ssbd() imo. That would then also be in line with all other "v == curr" conditionals, none of which apply to any "goto set_reg". ..._set_reg(), aiui, is meant only for use in cases where vCPU state needs updating such that proper state would be loaded later (e.g. during VM entry). Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 02 11:57:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 11:57:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435837.689664 (Exim 4.92) (envelope-from ) id 1oqCN9-0000uy-EC; Wed, 02 Nov 2022 11:57:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435837.689664; Wed, 02 Nov 2022 11:57:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqCN9-0000ur-BV; Wed, 02 Nov 2022 11:57:31 +0000 Received: by outflank-mailman (input) for mailman id 435837; Wed, 02 Nov 2022 11:57:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqCN7-0000uh-Oh; Wed, 02 Nov 2022 11:57:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqCN7-0000aD-Ms; Wed, 02 Nov 2022 11:57:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqCN7-00006E-7h; Wed, 02 Nov 2022 11:57:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqCN7-0005ze-79; Wed, 02 Nov 2022 11:57:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lexQ80W3E+PQ7d7GDkpqcX+Wlmy1xXyr99s99d5IAw0=; b=PmYvQSqqFQAhLUzy5ji4/b8C6u cPIWmbs7yh9fB1FQ8LoogtmjQEIxW67O0YMyR0gCu+EASeXtu+0vYNoiPZfKsinP8ghPcmI9Da3Jq S+6SzTT3iiqN6sk1F6LOi6c2Sgy8uadByx7/qIxa8Kp39S+BI8RRK3daVP/EZIjNXtrA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174577: all pass - PUSHED X-Osstest-Versions-This: ovmf=b5dbf8267b2596f4a28cdb30d1f533b958ddd4ed X-Osstest-Versions-That: ovmf=85dba961c761021755cd2aa6bc98b8e789f751ef From: osstest service owner Date: Wed, 02 Nov 2022 11:57:29 +0000 flight 174577 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174577/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b5dbf8267b2596f4a28cdb30d1f533b958ddd4ed baseline version: ovmf 85dba961c761021755cd2aa6bc98b8e789f751ef Last test of basis 174569 2022-11-01 15:10:52 Z 0 days Testing same since 174577 2022-11-02 02:43:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 85dba961c7..b5dbf8267b b5dbf8267b2596f4a28cdb30d1f533b958ddd4ed -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Nov 02 12:09:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 12:09:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435866.689675 (Exim 4.92) (envelope-from ) id 1oqCYk-0003ES-2J; Wed, 02 Nov 2022 12:09:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435866.689675; Wed, 02 Nov 2022 12:09:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqCYj-0003EL-V4; Wed, 02 Nov 2022 12:09:29 +0000 Received: by outflank-mailman (input) for mailman id 435866; Wed, 02 Nov 2022 12:09:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqCYi-0003EB-Dx; Wed, 02 Nov 2022 12:09:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqCYi-0000nH-9h; Wed, 02 Nov 2022 12:09:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqCYh-0000aI-Q4; Wed, 02 Nov 2022 12:09:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqCYh-0002BD-Pc; Wed, 02 Nov 2022 12:09:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=O5eG2uRtFDtMsbwGJht9Te2SZbZAXVHafqGOLfFU87c=; b=3btrEu0zbhJOPV1+7hoRgzpqxJ 8FK/swcRqGtPV+Tht70tZa5feAOb581S1JauqRo+pp3ThyCNsAaK+UbBihcsNjypGz5ytdcFIvPwY zGY8eoUqkF/rYRmRk5SfvddaO5X0d0yaOrJ5gXWzN4P9edB0pNmVCDF1ulpRb7HwN+4k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174574: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2dd823ca7237e7fb90c890642d6a3b357a26fcff X-Osstest-Versions-That: xen=1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1 From: osstest service owner Date: Wed, 02 Nov 2022 12:09:27 +0000 flight 174574 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174574/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174563 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174563 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174563 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174563 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174563 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174563 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174563 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174563 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174563 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174563 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174563 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174563 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 2dd823ca7237e7fb90c890642d6a3b357a26fcff baseline version: xen 1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1 Last test of basis 174563 2022-11-01 01:51:51 Z 1 days Testing same since 174574 2022-11-01 18:38:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Christian Lindig Edwin Török George Dunlap Juergen Gross Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 1d7fbc535d..2dd823ca72 2dd823ca7237e7fb90c890642d6a3b357a26fcff -> master From xen-devel-bounces@lists.xenproject.org Wed Nov 02 12:24:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 12:24:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435915.689854 (Exim 4.92) (envelope-from ) id 1oqCnG-0007zF-J1; Wed, 02 Nov 2022 12:24:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435915.689854; Wed, 02 Nov 2022 12:24:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqCnG-0007z8-FC; Wed, 02 Nov 2022 12:24:30 +0000 Received: by outflank-mailman (input) for mailman id 435915; Wed, 02 Nov 2022 12:24:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqCnF-0007z2-4C for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 12:24:29 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a084c43-5aa9-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 13:24:27 +0100 (CET) Received: from mail-co1nam11lp2173.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Nov 2022 08:24:24 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SN4PR03MB6768.namprd03.prod.outlook.com (2603:10b6:806:214::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Wed, 2 Nov 2022 12:24:22 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 12:24:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a084c43-5aa9-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667391866; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=aDID4nVq4FEnFfYcVy85RxjiZcZdcE9HZxjFlaLQEDQ=; b=ZPrhDc1Coh4H3oRsWwI6u02Xg5FibNyif4Z0VIyuyvXkFYdaQoWeT/8t LbYS3ebvcgSjyeMBQ7Fbg3aI4kpic+uteWRCskzAlEOUrqOpHCVdz1SK8 38Yz5FFGFXVR0B65n8rg/3jCgn+SvF/LoTi9RCwm9wGd84UB77FVberFw E=; X-IronPort-RemoteIP: 104.47.56.173 X-IronPort-MID: 84431285 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:coZEGKK9a3vQTWtZFE+RN5QlxSXFcZb7ZxGr2PjKsXjdYENS0DJVz GAeDWiFO67ZZGujc9gla9m/oUhXuZbWztZjGQRlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5wRkPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5QIDlH6 KYEDwwjLR2breCX+o6Vd9dF05FLwMnDZOvzu1lG5BSAVLMNZsmGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dppTGMl2Sd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzX+nA9tIRODQGvhCrwaLx2tIAwwvcgW3uN6lp0/iWOxzE hlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQPwrstUnAwMj0 FChlsnsQzdotdW9S3iQ67OVpjOaIjUOICkJYipsZQkY59jupqkjgxSJScxseIaulcH8Ezz0x zGMrQA9iq8VgMpN0L+0lXjYhxq8q56PSRQ6jjg7RUqg5wJ9IYWiPoqh7AGC6e4addnCCF6co HIDhs6SqvgUCo2AnzCMR+NLG6y14/GCM3vXhlsH84QdyglBMkWLJeh4iAyS7m8wWirYUVcFu HPuhD4= IronPort-HdrOrdr: A9a23:T1bQDKo0Rx0pM+L+KbC94e4aV5sqL9V00zEX/kB9WHVpm5Sj5q STdYcgpHjJYVcqKQsdcLW7Sdy9qBznlaKdjbN9AV7mZniChILKFvAe0WKB+UyCJ8SWzIc0v5 uIMZIOauEYZWIQsS+Q2maF+qMboeVvh5rHuQ6x9RtQpEpRGsddBk9Ce3+mO3wzTgxBGZd8Dp aX+tFGuirIQwVkUu2LQnMBWfTP48fGno78YQMXQyEm8xWVlzmh79fBYmml9yZbWTZI3bpn62 TOjxf4+7Xmufe9zRPXygbonudrseqkwN5EGMHJkMQeNi7tlxbtbp9wQqDqhkFKnMifrFwuls XA5w0tNdhp627AOmy0uxHp0wnl3C1G0Q6T9XaoxXHnp9D1ACg3AdZbhZ9INgDU4Uo4vN16zc twrh2knqsSBxbHgCm4/dTDSwpri1rxu3YknOIJ5kYvLbc2eftYsJEW9kJQHJAcdRiKk7zPPt MedP3h2A== X-IronPort-AV: E=Sophos;i="5.95,232,1661832000"; d="scan'208";a="84431285" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R1U6dmqEgLabxqu9LLzYQIVB+22hiG1Y20JD4VNOuagNw/rNG8A+NtnqTTSPbslWydwFj86OZZBPz/qcuqYgDgF6OnT9k0/j4i+GWxmwOgvaYA0hW2eoKuhseulWCpKMe4tE0Wqbkkgr9D5bvegp6TjoEgq4unh1o68O0vZdM4DP1k4wtmVa7tIkuZOCzjBae1luwGM7eShW5AS2jGkFeN1eYFrL/t5V0Sjk8HlqEGaIe0mtAjRJ70E3VIHuwaqU/IrA+7s3eMAuln05ijvGCjj/j1znY5/trHj+r2ibpKLXQV9K9VZmWFtqHBjg1Pz3CrK+u9kBp3ohsFwzmvYDvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aDID4nVq4FEnFfYcVy85RxjiZcZdcE9HZxjFlaLQEDQ=; b=l0shiTyl0VlyT7I7by2RPOIDWzEwT30Q4DwXn3yBAOh1jkOJL74XbwF/aTbvS18CMbjVd0UTKTwL93pUUiIkeOg9RpgZAcFeaz4i0SwF8MXI7r+ljn57KwrwRFNamSZEqzyHpW46nBA1XS/fvr25mLe2Cwpfu5gbb1UcwXxiq0hdbYNjvdhxoj02pSWJMIWD2eGInJFXjW+O/Aw7MMnPnmmtkw0ZkWBfs4/CHS0pKarkeyfoo19iFxzAJNx3OopSmCfsqfxyuznhdtVSrj7kU3J+BvsXGeaqDZe10c3UeXJeo5mT/KGZIZWN8PkwbmwYU9bjUol7YY+Vk4mMd4sXzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aDID4nVq4FEnFfYcVy85RxjiZcZdcE9HZxjFlaLQEDQ=; b=qaZvgzGG6vZ8gyUrsPocSQXxULcCCE3QydaL/eUhvAXM8m/8URvk9I6rVWLhC6bF8YqvouWjR9lvp5DWYv1rVPoNo+rSCVP8XtF9aKpq8FsLU0N46UNCRgB4rjR31uDT5id4afHrYxGHM1P1E6OHJ09YEDimZnz+y5GczRnlO0s= From: Andrew Cooper To: Anthony Perard , "xen-devel@lists.xenproject.org" CC: Henry Wang , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH for-4.17 2/4] tools/include/xen-foreign: Capture licences from the input headers Thread-Topic: [XEN PATCH for-4.17 2/4] tools/include/xen-foreign: Capture licences from the input headers Thread-Index: AQHY7q5XVsL2+RG/AUCiEkMy4e8OGa4rjrQA Date: Wed, 2 Nov 2022 12:24:21 +0000 Message-ID: <822f8cb3-6f13-d729-9779-0aeceda46272@citrix.com> References: <20221102112854.49020-1-anthony.perard@citrix.com> <20221102112854.49020-3-anthony.perard@citrix.com> In-Reply-To: <20221102112854.49020-3-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SN4PR03MB6768:EE_ x-ms-office365-filtering-correlation-id: cafe5ac1-320d-4936-6618-08dabccd2bc2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: obVPY/Qp+J1e3mCbvEc+KqQG4SE6Zo3Hfl2m2soM/iNu/7B4s7Z3fXLNVl7LYsM5gQpqyLmTDlPYdgFx/tNCIpQL/yYO0P6BzDmm0yqfbTB5iC5wBxvl8dfYfCnJ+8LXptDP+jS0um2Ifm0QNFVCwyc2K39xvAAieJoqP4gspbgTG7j5uaDufIUM13/DSJ827TFKKQ80lHC2ucqr0pj5yJWHggUbGlyBQTnCKBHvCYuYwc7XE0tu4CvDTW32aNOZXcL0JIPzzgl7DknfztGlGoCDugIWaYe99qGA1/hX2S77XSQZjN9/GQ5kqElZeKIUY1VmWd0HKqp0q9Xla9NXWLR57jXgaYmlKfO9NUAvbTQjeS2XcdegFPhPPH3heySAh9hKjSx0zZ67DXBraPgsRjFDVtt9Xrm2dUuiZxAEIL2fP7yk5NUbTf9YhPn2nb267RFVJExam3741hM4L0kqHlQ9XrxP/zXsw/lImZAL0vl330hwnGPSWMA21L2SOsUwTzzd5JXoBr9jBCsD4xyKPbBY/EgrPfj+8gZJe8V+adcfAJylgxyQc3aFIlqUu89e3mBetG6utbZEi0p3G3EVS6K/ZYAEUcHqhyUM+O0O7fkHXtTvE4wecCN2LwoftUKm0fi0NEqsSpX/NRDsZgz+r5oSAqhloQd7VaJ4/reibbcq7YICDFcbqpo9qdfj/h6clnVXY/SPI4nRUpX4q079Umh5QxYlZNWJJJ16HD1QzMAcaTZ2vE8VUEWqxv5QGRoR55cpzinyURkh7JXs7msIx5rMjBn6kJFzETV/0kLC9dYuea74KRGpC4oue664rRoSS+7XahrPncJxtmOrc8tlaA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199015)(31686004)(2906002)(86362001)(6506007)(4326008)(53546011)(31696002)(6512007)(8676002)(41300700001)(26005)(38070700005)(36756003)(54906003)(71200400001)(316002)(64756008)(122000001)(82960400001)(66446008)(38100700002)(8936002)(5660300002)(76116006)(66556008)(186003)(66476007)(66946007)(2616005)(478600001)(91956017)(6486002)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SE5GMGtvZy85UUJ1Rk1kWVVZdWRycG1SYXhMdS9CcURXVUNPVkRuY3lwclB3?= =?utf-8?B?WXFBKzIrK1JjMkJCUjU3czlYZ3ovUlFDa1pINlNiMk04d1hZUXl0cUFtVFJM?= =?utf-8?B?a2ZJZ1JKY0ZqMDBBeHFQTitIT2Y4VzBOY1pXRWUyODY1QmxJQWs5QlREd0t3?= =?utf-8?B?MjRia3dha3piWVMxR2xEYTk1OWpFTzhRRGpyTmU2dHBLQXRma3Zsb1A2c1dj?= =?utf-8?B?ekN0T2dERGx1enlqeFhzSVdSTWtIKzB2Z25kTG9WQXNDR1NDRVlXcUhVa3gy?= =?utf-8?B?clJ1a3BOdmh4NzN1a2tKTGk3QXA5eXBQVCtGZWttZjFycHdjK0ErM1pBTG1K?= =?utf-8?B?WTc2K1F2NnZidG1yOStzZ3M0Kys4WXorVERvZDFLVllXcFNsVmNPZklxcDRD?= =?utf-8?B?WldibFFkUTY0aGRGbXN0eWcyMkl6cnhqRnVENTdyMnp1MlRSa3ZzNDlxSkQv?= =?utf-8?B?eU9PNnJseHJFdllwSFcxUFFPYVgvV1dWVnAzSUlzK1RPSlZRSTFKb0FUVm9V?= =?utf-8?B?RG0za2szTUJtMzR3QmV6Zk84TlFwRmFpeGJ2TXJMRC8wYUoyUDRucm9wNXBt?= =?utf-8?B?bXNpTWdhS1VXVisvSU9PbmphcHFoMmZpejNlQjNvWTZpa21IODAwTEU1b2tX?= =?utf-8?B?UnUvWmlPV24yQk1sK1lTTWFxM3VodXBWUEVoYXkrcGhoYVppUzdyeHBRUXFq?= =?utf-8?B?YmZqaERHQnZPTzl2dlozUHYzaFZVTVJ1NWFieTF1bmhybm1BMkV0WFBqNC9E?= =?utf-8?B?cWNqSGdLUWM1dHlGY0xzbWEybmFCOEpobXcwcThkMThuTlRDYkFwbzJhTE81?= =?utf-8?B?Ti9GdFJ5MnAwUWozVHF5L1pKMkpkYWFNNlFxZXNxb1VGV2trN1IxUGJkZk83?= =?utf-8?B?SmdScWppUGpEUytvektPNExQL2xzYm9BU3UzOXRnM0IrR1dvMHdaTjlLNnFw?= =?utf-8?B?RmpMUUVYamF0dkNEWXNiQTdHVmZGQ1d2QmcxZFY5dEVtWUhaTDFaald2Z1FF?= =?utf-8?B?UnhlTHFRclRXZ2M5cjNKVHZ3eEs1eGlQajdFK1h0QmNTWTRyaTQ1QkYzN09G?= =?utf-8?B?UDhqTXlHeGJ5aWxhcUdRQXRZSTY4Ykg3YUNaRWxld3gxR3dpRDF0SDkzRnI5?= =?utf-8?B?ellQL21FdkU1U2lhQjdIYmhDT3Z4bFhoRithZnZvOXVLV2UrbG5Bd1Y3WFZj?= =?utf-8?B?RE5OSXFrOS9VWTFFeTh6QmRiWFkyd2tybHRZN011aEFUaHdPY0djcEN1aTlX?= =?utf-8?B?R3V3TGFBMGlDVWhDcXRNb1FwclFGU3B1UklGS3ovTFg0QnM0WS9GY0xwam9n?= =?utf-8?B?bFFERERLaUtNMFBNbHZQQUYyb29EaGZnRExuRndBejRNUHZ5MmZyZzNzZlA4?= =?utf-8?B?SEg5QjZkcE1HbDFvVlVhbUJLMElYQ2NTT1hJTG1RQU9jaWFEeGQ1eVg2VTRZ?= =?utf-8?B?S2dRS3RicnJ6QThrN1NuSWw1QVdZSnBKdU1IV3MwaXVoV004UDJ4UDU2SE0v?= =?utf-8?B?K2lyc2lCMHhuc0pSeks5MjB6TUlTSVhLNm1YZnZ0aFU5UFpNTVFQaWVpSTdH?= =?utf-8?B?aGd5d0hta0xLS2t0aTNhODNUN1N6dzRrTVhDMTFXSWxiT25RL0x2MUQxaXYw?= =?utf-8?B?TDRxU0hEaHJNUy9meHhGWkJGci8yYlZ3VDVvSWJVSlZUVHV0dDBoSU5KUHBx?= =?utf-8?B?dGlBYWlIWERWRVpHMEdXQkF0M215Q21pZFNXNlh6d1FlVHkxOHpIeVJoeUxX?= =?utf-8?B?bmZBazUrRjhIczJaSzJOd0o2Umh2ZkhnNXNGcG9SZGh6RGJKVDAybi80RVJD?= =?utf-8?B?V3RzM2xtc2NjdEN1dDF3K3hhSkpRcXoySzlpUVVDdzlkNXNmL3V0NUlDZDBV?= =?utf-8?B?c2YvRGlFQVlTUHNZVVp1S0E4aDdmY1d5bnoyQ0syOUxld21jbjl0VEVHUTZn?= =?utf-8?B?VGM0RUxNeUhUYzZEOWlRVDZsajZ0ZldzYU9Eclc3UklweGRKQ1g1MGRkWmgr?= =?utf-8?B?cGxmcUcyVmVTZDM3NG54RWg3MzBBd2Ftd0NLUnlSKzNmS0hXQkVLaW5Yc0l0?= =?utf-8?B?L3NZMHdhRFBDSEtSeVNKYlpJemVybWViL2NXWEc0M3FxUFBQbTdoQXB4SHhj?= =?utf-8?Q?DBbheo5Zu6TGN89RMJ6FMO8TL?= Content-Type: text/plain; charset="utf-8" Content-ID: <0DAD927489638242B6465EAD2BB6F3EB@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cafe5ac1-320d-4936-6618-08dabccd2bc2 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 12:24:21.4512 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w5gUaA8+HxCJM+J6g5tE/aVxneleYIGXDbtVe2Uu+q/GsxzGfc0xZ9Xo6hykYjvz31eHSpgm+WkJyjzWFRdNm+WU6NphzL/1T5bVvI4DkEA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6768 T24gMDIvMTEvMjAyMiAxMToyOCwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IFRoZSBoZWFkZXJz IGluc3RhbGwgaW4gIi91c3IvaW5jbHVkZS94ZW4vZm9yZWlnbi8iIGFyZSBtaXNzaW5nIGENCj4g bGljZW5jZS4NCj4NCj4gV2hpbGUgd2UgY291bGQgcHJvYmFibHkganVzdCBhZGQgdGhlIE1JVCBs aWNlbmNlIHRvIHRoZSBnZW5lcmF0ZWQNCj4gZmlsZSwgdGhpcyBwYXRjaCBpbnN0ZWFkIHRyeSB0 byBncmFiIHRoZSBsaWNlbmNlIGZyb20gdGhlIG9yaWdpbmFsDQo+IGlucHV0IGZpbGUuDQo+DQo+ IFNpbmNlIGxpY2VuY2VzIGFyZSBpbiB0aGUgZmlyc3QgbXVsdGlsaW5lIEMgY29tbWVudHMsIHdl IGp1c3QgbG9vayBmb3INCj4gdGhhdC4gQWxzbyB3aXRoIHRoaXMgcGF0Y2gsIHRoZSBwb3NzaWJs ZSBsaWNlbmNlcyB3aWxsIG5vdCBiZSBpbiB0aGUNCj4gImlucHV0IiB2YXJpYWJsZSBhbnltb3Jl LCBidXQgaXQgc2hvdWxkIGJlIHVubmVjZXNzYXJ5IHRvIGdlbmVyYXRlIHRoZQ0KPiBmb3JlaWdu IGhlYWRlci4NCj4NCj4gV2l0aCB0aGlzIGNoYW5nZSwgdGhlIGxpY2VuY2Ugd2lsbCBiZSBjb3Bp ZWQgMiBvciAzIHRpbWUgaW4gdGhlDQo+IGluc3RhbGwgaGVhZGVycyBkZXBlbmRpbmcgb24gdGhl IG51bWJlciBvZiBpbnB1dCBoZWFkZXJzLg0KPg0KPiBSZXBvcnRlZC1ieTogQW5kcmV3IENvb3Bl ciA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogQW50aG9ueSBQ RVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+DQo+IC0tLQ0KPg0KPiBOb3RlczoNCj4g ICAgIE1heWJlIGluc3RlYWQgb2YgdGhpcywgd2Ugc2hvdWxkIGp1c3Qgc3RhbXAgdGhpcyBvbiB0 aGUgZ2VuZXJhdGVkIGhlYWRlcg0KPiAgICAgICAgIC8qIFNQRFgtTGljZW5zZS1JZGVudGlmaWVy OiBNSVQgKi8NCj4gICAgIA0KPiAgICAgYnV0IHdlIHdvdWxkIGJlIG1pc3NpbmcgdGhlICJDb3B5 cmlnaHQiIGluZm9ybWF0aW9ucy4gSSBndWVzcyB3ZSBjb3VsZA0KPiAgICAgbG9vayBmb3IgdGhv c2UgbGluZSB3aXRoIENvcHlyaWdodCBhbmQgY29weSB0aGVtLg0KPiAgICAgDQo+ICAgICBPciwg d2UgY291bGQgcmVwbGFjZSB0aGUgbGljZW5jZSBpbiB0aGUgaW5wdXQgaGVhZGVyIGJ5IGEgU1BE WCBhbmQgaGF2ZQ0KPiAgICAgdGhlIHNjcmlwdCBwYXJzZSB0aGF0LiAoUHJvYmFibHkgc3RpbGwg bmVlZCB0byBncmFiIHRoZSBDb3B5cmlnaHQgbGluZXMpDQoNCkFsbCBwdWJsaWMgaGVhZGVycyAo ZXhjZXB0IG9uZSA6LSggKSBhcmUgTUlULg0KDQpXZSBzaG91bGQgU1BEWCB0aGUgbG90LCBub3Qg bGVhc3QgYmVjYXVzZSB0aGF0IHJlbW92ZXMgYWxsIHRoZQ0KZ3Vlc3RpbWF0aW9uIGZyb20gdGhp cyBzY3JpcHQ7IHdlIGNhbiByZXF1aXJlIHRoYXQgdGhlIFNQRFggbGluZSBpcyB0aGUNCmZpcnN0 IGxpbmUsIGFuZCBzYW5pdHkgY2hlY2sgaXQgYXMgd2UgcHJvY2VzcyBpdC4NCg0KVGhlIGhlYWRl cnMgYWxzbyBvdWdodCB0byBzYXkgImF1dG9tYXRpY2FsbHkgZ2VuZXJhdGVkIGZyb20gJE9USEVS IiwgYW5kDQppbmNsdWRlIG5vIG90aGVyIGluZm9ybWF0aW9uLsKgIFRoYXQncyBub3cgbW9zdCBh dXRvZ2VuIGhlYWRlcnMgd29yay4NCg0KU28gdGhlIGdlbmVyYXRlZCBmaWxlcyBvdWdodCB0byBl bmQgdXAgbG9va2luZyBsaWtlOg0KDQovKiBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogTUlUICov DQovKiBBdXRvbWF0aWNhbGx5IGdlbmVyYXRlZCBmcm9tICRGSUxFICovDQoNCiNpZm5kZWYgJEJM QUgNCi4uLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 02 12:58:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 12:58:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435924.689865 (Exim 4.92) (envelope-from ) id 1oqDJx-0004t4-CY; Wed, 02 Nov 2022 12:58:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435924.689865; Wed, 02 Nov 2022 12:58:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqDJx-0004sx-9V; Wed, 02 Nov 2022 12:58:17 +0000 Received: by outflank-mailman (input) for mailman id 435924; Wed, 02 Nov 2022 12:58:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqDJv-0004so-V3 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 12:58:16 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2068.outbound.protection.outlook.com [40.107.20.68]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 02c89598-5aae-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 13:58:14 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7283.eurprd04.prod.outlook.com (2603:10a6:20b:1c7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Wed, 2 Nov 2022 12:58:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 12:58:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02c89598-5aae-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L2uYIAxekl8ukviJc1BoAjMUHvfOp6FaJrqwE4sOOHsAiMtFnILMiTQbYhEN1EWWaPEYRn/zESMTYm9DVmiTw+6x/WzvmlOlJ9dWeQ5uj+t12RGETdK5spCDF6v5sDMBt7uj50iFkSGa+r7nV+EIAfIWeelBpWRPm4oJg8gCE2scGDD5s7ooCgf6TavHS8E/t/k8anciCdoJ5/HCWWgd+bJebvonN62cV3Hn8rsd4Hw7BLOnc59ZYZeLCMP7GzoRF95zuBKW0uK1zOOSxP4oZnSrwTVPhA77CYjEnVjpb/GD4RbfEkVZH+xCm+ZjucspmC6QaKoY4bJIn4w/QUuU6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kn+7xbZ3czE43TfL10MYZaR5153UaGRfLuJSYE/oprw=; b=XxH3nl5Gf1+CgII5+qmF6vV2oOCe9uL+8tePbzUdYoHIi/9L1YoqTQAJTTqk2s5zRabQ+TbLZJGO0qxoTB0wA8mZySdXantOoBqAxz2dTFjAo9WUrSj0NbGJ7wXA/HJ0jmwFqlB0kXHO1ibbI2fz8I4XHJt+MKTYqPT/q1ugBZms5TptSRfuDRMATT0zdqWBqFSCXHRbVl3BqgED4KXl+y+6XgCBZ2Fm0fO25kRmdONS6MqqheQowz1M2ds7hHeC5ASRKmEZihy/4NpxLg6N/eYbnJO0ojNf1YL4w4zSsAKYzlJOTqnsvKKMqiymuv61kNXFr/G4chRhbuTd0ODcxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kn+7xbZ3czE43TfL10MYZaR5153UaGRfLuJSYE/oprw=; b=CUt2QKmreYLDBgQBJQvnNOyHqgpfVR6HNC5BJZlnuLrMcpB3OVglYtlDDaWWNnh5v6EfhGZtxlOgQyKxlWOclrQB0oKhQjFN4Xvb1TxOShBHfmmLgqfISZ2H0fRgmur/5kWDHmkiggwiDSICffO7tkuPUsnoyQ+iT61qmy6KH/raWtCSWDKrmoPYdhEILwVy3yyFm0KWhlwZY61WZMk0Ng9Mdu9QXCXcGrsnAgrsHuLnyJj1lnvSKQ2O5dEFRLsYZJMJxdDS2YdVWGtPsT1NpPBQGJu55kMn8c3kteLLOC3bPF02vQC9c680Hxd2iqT9E4AMuIk0Au81ZbmfUkSZMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 2 Nov 2022 13:58:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN PATCH for-4.17 1/4] xen: Add licence information to public/errno.h Content-Language: en-US To: Anthony PERARD Cc: Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20221102112854.49020-1-anthony.perard@citrix.com> <20221102112854.49020-2-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: <20221102112854.49020-2-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0032.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7283:EE_ X-MS-Office365-Filtering-Correlation-Id: 66621a27-ab00-4799-a162-08dabcd1e576 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wis6rgl3WnHX6Z1q3CYaGOVqGGpVN+/C1SKUEUyf/xlycWGcnEY6PmL9BgqkLZwttc/088KECR7dCgQIfzn055v4F03Fnvh6t+sSkVWEegawXqS+v5M7e4hY+cH2n0L7pNesoqSK+GQerQCE2n+UQVGm6owY9R1Kqd2LDA1KbSYUQWH5alFu3VNwION7U7z/GajMnsGbx645MDknztc1oJr8lkOaSoomrJj07RHMQkK5/zV/fQEYlShfkvgmP0JrPtoAycrHrSSmNPrdjjuWbnmMkSwXKNYWZwlrBHjwmJDRCFV7lZs5rH74PEGVg4dmM9yWPfpWHORGLmygDvrhb/2OJ44G5XyGiYs4P8C/4qOBBa/iouRKN7KESpehPWDWTGQJjcnYEVAmgRew4H85A5BnhA90FHYwdPTULyJo9QHvje0usoLiQOGx6ASf4JDu+as4nBIyd148KpoqzKZJEg/U7V2LuWMY/Ib+Icin9QgAu/qOZhMYkMvwQxES77NkrJm2aAvRtxWHIlUnx2/zGkox4OKb3XrFHUW2GcXWoX/MYd/IIg/H/s8ZTcuuzoTHERaE6wg/txZKxy2Z5tD7HFk1W/KF0fKmJWQB97+jbdC98oheuL+lIEOTtbuMMCA+/GwMnC7n3RvbCMyB2Ctl7bmFp2zuBT1VaIC1oNKxIZdaderXTfRT7as6C8ncddTayP3pXJ8zTyqxzA+ZQcaM3v4CTya3cswCNsDQ4HKkWDU0bNnnxPhRr7djxKesE2OrGexq87iha88UwIDetqVac1NiyX3STxGbYzRoE3J4Eag= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(376002)(396003)(366004)(136003)(451199015)(4744005)(2616005)(66946007)(31686004)(54906003)(316002)(6916009)(4326008)(66476007)(26005)(8676002)(66556008)(53546011)(6506007)(41300700001)(478600001)(6512007)(6486002)(2906002)(8936002)(5660300002)(186003)(31696002)(36756003)(86362001)(83380400001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c25kVmtVNHJVbVpjZ3gxaDBxMWxMbjRYZDI3Rk1KVGh1a1AxVXJGMnl5Q0lB?= =?utf-8?B?VjdJZzR1SkVkWkpxUk5kRUNONHNOYUxwMVYxR01OVFRsV0hydFZPamd3QTVm?= =?utf-8?B?a0c1Q1QxNXBPZEoyWmtPOFpmaFl0NSsxNm54ZC83YTE3OHg1U0RBYzlKVnNH?= =?utf-8?B?OWZjeEh2TXlQYUh0ekE3eVUvVFJNVEE3eTl6a0loWURFK1ljcnRFVWM4S2E3?= =?utf-8?B?YXhabGhhbDNjMk1uSDhFa3ZLQnlMU3o1WnlGS2FRK1Uwa0wzVWEya2wzVGpH?= =?utf-8?B?bEhuWDdhZDFNeThSYTlLQlptVnE4cm81WFRLYTFOUFhzblpaclNVYmlMREdu?= =?utf-8?B?czFqeG51L1dJd0ZwaTQrWkd5Y3hqNlBnZTJlV2ZVbXV0N1h4VE1ZQlc5cjB4?= =?utf-8?B?dUFkY3NsM0ZQcVF6KzZCcWNvSnB1blVOUHV5TWVicHlrZGt2MVA4YXZvbkhR?= =?utf-8?B?NE1HS29PZ1ZDUEs2ZHFSWE9HS2kveTEveHFsRHBEWW9Zd1Z2bjNtaFpORnpR?= =?utf-8?B?bk4xcTMvVDNkb0s2V2pUcTRCQmR3WDZyVGViQ20wVTFmUlp2TjlCNVRNTDA0?= =?utf-8?B?S3Y1cjhub2UzZksyZ2Nvb2tQZm1ud0o3N1VyTW80Myt1b3R6N2hwaFM0bEhI?= =?utf-8?B?Z1pUS2gvcW5XSld3WjZTeTlEOEtYNHYvZHBBblJ5VWFCYjBJNWc3UXJYRE9B?= =?utf-8?B?eGlGZ0w4Sm9OdEdIeGJYN2t5SFUrZUp5bkhZSmhjZXJPeUZXcmhPOXZ1ZDdT?= =?utf-8?B?ZkZSMUZwV3BQajAreUd5OTAwSGI1OGN0RmRPY2pPQkl6eitkZHkyR2U0R1VO?= =?utf-8?B?MFhMajRYOFA2cytGMUlkWTdGQlBYOXQzTzRKZE5vcmlLMnRDRXdYaVdXaEFj?= =?utf-8?B?OFZSa0piMllXQU1ORDhKTVZaUWJPZ0FhV2F0Q21rb1dsbE8zRlBpNjZ1YmY0?= =?utf-8?B?RndhUHo4aXcySHBDdnBVSHNycS9DNTBlQmdIaEpIYzZSVWZ2dUs4NFg2emhX?= =?utf-8?B?NmZqZS9uYzgzbnR6am9Jc2wxZ2VoancyaDRhek0wa3NBeFFmMlM0alNWMDRx?= =?utf-8?B?TUNyYklrZzc3eTIxOExWaEZrd3JQNmw3TUhPNTZlQUE4RG8wYk52aVJZb3RZ?= =?utf-8?B?blRJeGRYSzV2QlRkU1pyTjZQL2ZINEpJS2lzM2tlczFXTDl4WmN5dHFNSGlL?= =?utf-8?B?OHRvZSs5VnJuLzZESjlSMWkyQ0xXQUU3cG53ZW5RTlR5RHNTNC9JdWxqZ2Fw?= =?utf-8?B?SFZ4NXhvdmVyclk4UDBjcHFVR1ovQk5VQzIydHFLUlFLci81OW0zTmdZMFFI?= =?utf-8?B?bmg1RklONmg5elF4UTdSNTFseWRDcWkyaDdGdjdSM0pSM1FNSWFzeklMUGtU?= =?utf-8?B?K0VKVGtpRmsybTZrOHZYZTZCWXp4YWJ5azM5K2tUbGZOdml3U3NFZ1RJWWxI?= =?utf-8?B?dzRZSlEwRkNxYmtGdlFabVRUcXFjSjlZemIydEpDbU5QV0ZLUEZaZXhyTnRj?= =?utf-8?B?dWdLRkVoUnQ4YTltejhYQVprRG1mVzBkejl6U1BhcWV3VktLaGhtY1BFalNt?= =?utf-8?B?TThXNzV5dDNQVVRNOHpCRE1DZTVyb3JTcWNZSkxKdG85c0pUY3NSOHI3MjFm?= =?utf-8?B?TG1MckE5cVU0S2VaKzFtOTIrRE5WL2R2MEVWc08weEh3ZzJWMWRnV1V2VmN3?= =?utf-8?B?ZVJ5elpidmRZcWRUNGRVM0pOaWdoQTdubU80eFBqTzJkZUhkYnpyRlZnNEY4?= =?utf-8?B?d1JQVFV6c2VFZkFqUDV4d0hINXF1dXVEbXFFREJWeTM0Uk82bkZiQ29SUDlp?= =?utf-8?B?K2NkRXVpVWh2N1dEWmI3VGZhNForWVJDc1ZBUWVxWEhRRDEyQ0RSQVJCMWZu?= =?utf-8?B?djU0S2hZTkR5Y1FSR1F3TmJTOWdxUG9Ra1gwRjdzSXVLUHNJdEZnNnRHY0or?= =?utf-8?B?VHMzb1lTV0l1a1EvQ0lhSnVJbFo0ZmcxQnp3R3pEeCtnU1hiVjZBb1pKWFVP?= =?utf-8?B?WC9PblZmZTA4UjBML09kRGFZSVBkWjlmRE1RTEl6Nld5RFhXODV6Sm9tT0FT?= =?utf-8?B?RVVhWCtQWVB1SGpCY0twREd4Rm1mbC9vam5yaWpNaTFyUHo5TE16a2JDSzd2?= =?utf-8?Q?12OaDXwFHPv1T5WrWDd7HTn7F?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66621a27-ab00-4799-a162-08dabcd1e576 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 12:58:11.1383 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PI1AItca1gtYagYcJ5bCywhBL+ktau2SV7zKPUZ5OfDi8HULNP8qA7H8hT2yXm0GQFqZR8M4B6JewAvHvSUdQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7283 On 02.11.2022 12:28, Anthony PERARD wrote: > Fixes: 81f559e97974 ("make error codes a formal part of the ABI") > Reported-by: Andrew Cooper > Signed-off-by: Anthony PERARD > --- > xen/include/public/errno.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/include/public/errno.h b/xen/include/public/errno.h > index 5c53af6af9..6bdc8c5079 100644 > --- a/xen/include/public/errno.h > +++ b/xen/include/public/errno.h > @@ -1,3 +1,5 @@ > +/* SPDX-License-Identifier: MIT */ > + > /* > * There are two expected ways of including this header. > * Doesn't this require at least part of Stefano's "[PATCH v4 0/4] introduce SPDX" as a prereq? I notice quite a few files already use leading SPDX comments, but perhaps wrongly so without it being explained anywhere in tree what this is about? Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 02 13:00:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 13:00:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435928.689876 (Exim 4.92) (envelope-from ) id 1oqDLr-0006Er-Nj; Wed, 02 Nov 2022 13:00:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435928.689876; Wed, 02 Nov 2022 13:00:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqDLr-0006Ek-Km; Wed, 02 Nov 2022 13:00:15 +0000 Received: by outflank-mailman (input) for mailman id 435928; Wed, 02 Nov 2022 13:00:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqDLq-0006Ec-7j for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 13:00:14 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 485290ee-5aae-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 14:00:12 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Nov 2022 09:00:08 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH2PR03MB5240.namprd03.prod.outlook.com (2603:10b6:610:93::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Wed, 2 Nov 2022 13:00:04 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 13:00:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 485290ee-5aae-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667394012; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=FCG69aKwVCPCDrV9hAw10OX+sU/2RfItZY3wwI9TkXk=; b=ZMPUkoUhkSShbcKE+h9/lJBAPL7OugazOhqc2K9c4/7UkhvBE2QRSJkQ apsLvSiQvnDwmQBJTGvzcXazRh+6JhYVlUskzsJ07aoIqi7bTDawXH/qs Jfry1ADrK5oQTJJBkmwmQtl8LFEZC6y44DomtAw1DygYricKUgsZoIly/ I=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 84024085 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:rnaraa8as7FlIJWjQ9FtDrUDZn+TJUtcMsCJ2f8bNWPcYEJGY0x3x jNOW2mDbqnZYDf0c492Od61oEwOsMfcztZnSgZlqyA8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPKgR5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklk6 tdDBishNCuOoP7un6uRTMkwhP48eZyD0IM34hmMzBn/JNN/GNXpZfWP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUvgNABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCN5KTuHgpqMCbFu72WoKL0wVX3GB8LqUqUzhXOluL lYx0397xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnO87QyY7k GCAmdzBDCZq9raSTBq19L2ZsDezMig9NnIZaGkPSg5ty9v+pIA+iDrfQ9AlF7S65vXuAi35y T2OqCk4hp0QgNQN2qH9+krI6xqzorDZQwhz4R/YNl9J9St8bY+hIoauuV7S6K8ZKJ7DFwfR+ n8Zh8KZ8eYCS4mXkzCAS/kMG7fv4OuZNDrbghhkGJxJGymRxkNPtLt4uFlWTHqF+O5YEdM1S Cc/YT9s2aI= IronPort-HdrOrdr: A9a23:kaE5Aqk5tnvsvdmTnHzUAWdRA4HpDfOgimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdC9qADnhOZICOgqXItKOTOLhILGFvAE0WKP+V3d8k7Fh6dgPM VbAs5D4bTLZDAU4/oSizPIcerIteP3lJxA8t2uqkuFIzsaCJ1I3kNcMEK2A0d2TA5JCd4SD5 yH/PdKoDKmZDA+ctm7LmNtZZmJm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYZ93 TfmQCR3NTojxj78G6Q64bg1eUYpDLT8KoMOCVKsLlVFtzYsHflWG2mYczDgNl6mpDt1L9gqq i2n/5pBbUI15qWRBD8nfKl4Xic7B8+r3Dl0lOWmn3lvIjwQy87EdNIgcZDfgLe8FdIhqAJ7E tn5RPqi3NsN2K0oA3to9zTEx16nEu9pnQv1eYVknxESIMbLLtct5YW8k9ZGIoJWHuS0vFQLM B+SMXHoPpGe1KTaH7U+mFp3dy3R3w2WhOLWFILtMCZ2yVf2Hp500wbzsoCmWpozuNLd7BUo+ Dfdqh4nrBHScEbKap7GecaWMOyTnfARBrdWVjiUmgP1Jt3S04lh6SHnondvtvaBKDg5KFC56 jpQRdfqXM4fV7oBImHwIBLmyq9MVmAYQ== X-IronPort-AV: E=Sophos;i="5.95,234,1661832000"; d="scan'208";a="84024085" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fraDem14VvtsV6lzKTLvjGhIPD6EdJXyRB5KDx9c1Kk8dwJYBQ+/jhTzzWFUjCZ4pkAGnutT1Dawbe9tsSeIeR9nzllOuip7s0SUde6H7SvT0pL8dDAKhDpUazVBisN1QzD2J/ETbayw+LedWXp/20+h4dpM0c4TV2ALtJi6ouzjEhPjjmJKKDoX8HTbeFv11F6Kp657icbFw/S7RULVeWBd4YviriS/68G5rbhDHtaSi9xTiF3Qb6L76O89k5AXkghjRdZ8tI4aUSfFkApj6eyymN+/PfWsaFfeZDDWyn7wUXlrRsBOIUDFztWJtUrttw1LmrDe1tKc0uGFKEQcCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FCG69aKwVCPCDrV9hAw10OX+sU/2RfItZY3wwI9TkXk=; b=EjKrHcDpyxg6IkXnKMJ4thLHieMMpValAi7cAOSoVIBQjRT35V4EFqgt26P9cRfyqekUyyFSlfBg8cBoBC9F/IaPfgun4AxDNEy3c7LVseSjET1RKPjfcV/5D1znjEWWWKWH66fNIlbvgJFuVOn99m/53XzDfqwq8L5MOS8LdcHuuW+ga6RiAPf6kJwuFTV8yl7bKcblnbrlAHxEmCK5O4MVaJ4wCJOKq+DRtwX46oNdhj2FEPV5P+vfV+Eoz0JHdWUKpZC5Rcx/vUDrKI46VU9LyJMgP/e0tj/nQL4rBS1SeawhL/N9YgeCAaRdKv77RW08/58yqCV7Xg/PHwy4Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FCG69aKwVCPCDrV9hAw10OX+sU/2RfItZY3wwI9TkXk=; b=H8huxwCjnZCgUfOrqR+2Ig1K8fhgivwRATeLiplxm0nUDd4S9kDOVmwuekZCEz7VxjepBcEK1JTXhSKi8IJkv31QBVs7CbTRNf+XgT00G99ZBS6A1eFzamE8fMFqVBLNFIu6AwS8fg84pMzkcP6wWEY0YP+cG34+vv37TXUlN3Q= From: Andrew Cooper To: Anthony Perard , "xen-devel@lists.xenproject.org" CC: Henry Wang , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH for-4.17 3/4] xen: Add licence header to device_tree_defs.h Thread-Topic: [XEN PATCH for-4.17 3/4] xen: Add licence header to device_tree_defs.h Thread-Index: AQHY7q5c3VQOfOFuk0qA+nRDI2AEY64rmK6A Date: Wed, 2 Nov 2022 13:00:04 +0000 Message-ID: <5e3c45f1-7d31-f0e0-4224-e5317b004051@citrix.com> References: <20221102112854.49020-1-anthony.perard@citrix.com> <20221102112854.49020-4-anthony.perard@citrix.com> In-Reply-To: <20221102112854.49020-4-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CH2PR03MB5240:EE_ x-ms-office365-filtering-correlation-id: 80a66a47-5756-4863-8f70-08dabcd228df x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EmUnNNwu7EBj8cD4GPFN0ryhhVmeoe/kCs5WDtS5GY/nTtrY924pjVUOkXe+MbG+/JBBV5YDU5YbiLeRqSHzwU991hL6sCkJyIaapfSSSag0/jNV1y0CvGDnGFH6hzEZJ+rXW8dCvCPBWntCJbaLhvAg9Uq07KB3ZeFmP9VaWc3d4sTR1bwoZbrpmaJNuddbtH7megh9qhPZWENF9UF0SLbdoBBrDjOy0j9+WCzyAEJrnCB7X6Lcu5Uno2nNg9tfqCocKdGjz+wAX7y/8laWwoTT3osf6qZrkq5/6iycTEdz0LazoPk62ghYD7ut256grYcqKgxjhQOsJTXFKXT56ZWQZNdSmDaepzHA880QymQWG2Eatu74etFRTPZFwZ0lbFb/l1GjnwrhYNXkQkySwdvH+wbg7wD4ePEaVPIW8jOHyXtO1PLtQ34f6iMqoI1ivTxvApitq+mlBi1wApyRJhMIYqxPjxRRTurd1Wev3cWUSlVLZkMVLHShGYeUAPCXi7sq/1PcFzMCn7WXhk9SKhmgUTue4UGtmh4NwCA+UT77A+jtPFwAxOjM6nnDrsf4bEhLFmRooet94FYbZh0swkRY6ZTEJZTr1KAF+6PZ6P1ALaabBlpWykd4GHNHRAHuHuirDh7X8UgdC93wCstzL3kYKZMOgY2jVbqsR6BC85oYhl2ze882eVsRuj0yvMOBOH84G0fzztYpVphDOTLXoAPpEjI6o7ueTi3PABEl4HXwVWYZPUTqdN21nixp/iwr+ivPZ+OOmLdoZ6nbq4hKV/zD4UUn0O+PSbzoRejDzMAW9394sZp33d3CfcUX/ktEatc645i3W1RjRZTJY/kBQw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(136003)(376002)(346002)(451199015)(316002)(110136005)(38070700005)(54906003)(8936002)(36756003)(5660300002)(4744005)(66476007)(66446008)(64756008)(8676002)(4326008)(66556008)(76116006)(91956017)(86362001)(31696002)(66946007)(41300700001)(26005)(6512007)(6506007)(53546011)(2616005)(186003)(71200400001)(82960400001)(38100700002)(122000001)(478600001)(6486002)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eDVEU1R0OGFMMVhkaGJhYmlqZGVIVWdGVmsvRkN6Z0tjNW9nZktuWGJkUUJJ?= =?utf-8?B?d2YrVTkxUnBWTGE2bS9oeFNJdEozQ3pEUVltYzUwQUQreVprOW1URGt5aEFM?= =?utf-8?B?aVJZakpBcE9nYlpnZ0kwcjdiSDRMKzB3cUsySEc3UEs2eHZud3dKMFRJM2dS?= =?utf-8?B?WDN4UWIyWVVxa3o1MWNnRFhKb2lOUjQ2VDhWanJZMldKRk1pWUFhdGpkZDM0?= =?utf-8?B?UmxKZlluNDZWZVBBSTE3M0FVNkxGbHcrcHdKUXBCM1JIN0M4RjRWeGpmaXVk?= =?utf-8?B?SCtWQWpSNjh5K2JTZ3R3MDkweFo1QnZmY0lWL2JmNmZyL1phTXcycmpzU2Ix?= =?utf-8?B?Y3VFTDd5U2lzVnc0QlNOSmVVanVESVRERUp5K09rajRMOHBKSktNVFV4cFc5?= =?utf-8?B?YzJzZVUxYXJLbCtnVjdsbzN1djVhL3hlaVI3aFFFWGwzUjNPMXlZSnFEZXAw?= =?utf-8?B?N3ZycENmbjZhTVJudkh5YjhESmd1QVAvci9ONHdETXJjdWpUb2gxK0NEczAx?= =?utf-8?B?MlE4cmsvSCt3ZmJuUFJ4WFRiQ0ZYSEpoQ2lad0FnT2c0VzBhL3QzVm12cHI0?= =?utf-8?B?dU5kMWNnNkY5OGtLbTR1ZGlORUtwQnZuVC9PN1lJbXNNclZMaVVIMklZNk84?= =?utf-8?B?TzVPQjF0bDYwbmpvSU9DTElkR1NraGh5bXU5UG9sdXZiSERoVG1Xbk1iK252?= =?utf-8?B?Q1BTKzBJNnplRklCVzdNS0ppMmppajlEVjVpbmUzZGRlRnhCYnc1czBieGUz?= =?utf-8?B?N2U0WW9ZcUpUTGkyTitsU2pIZCt0YVFLa2pzS2kyRFRXVVdOZURoUHJUOE9y?= =?utf-8?B?OWpMS2J2Q3JUdkJJaWdpN1BvakRyMWxmRXFySnpkcFBlcGV2aCtwdm9HQW5i?= =?utf-8?B?bkpoR3RFRU9QbHVqMWdiOVBtQVRhWnBYZjFDajRaYm8xUlRNZmp1UVZ3Qkd5?= =?utf-8?B?bmtGYmtZYkxBNVRTTFZCRkloZW9ZOUViN2x4bmxIQW1TYlZjYXZPVVZ2MjBP?= =?utf-8?B?M2hkSFlBZDVjbXN5S1RXUUU1UXBHa2NFK1B6SGhWMS8zNnJTazRJMSt1LzhC?= =?utf-8?B?c054aEJ2YzFob3N1WWErSWZKdTYyRXZQdXR2TEVabllKY0M3STh1S0N2d1l1?= =?utf-8?B?TGJBb29PckJ2NTBycWZGS255Mys1aHBQRjYzN2FrZEo4N0hhTjRKSStQRHpW?= =?utf-8?B?YUZuc2J2UXNPYk8rVTd0YklnNHpldlZuZmRMdHE4VkN6T0ZXcXZMQVc1ZCtU?= =?utf-8?B?QWNTUWJRcTBMYjVrWUkrWHpONkVXYi9ZZlRmRGwwVmJsMGhuVU9hNDlid0dZ?= =?utf-8?B?YVN6eXEyZlhWajJ3SFFtT3JFNFM5dUhySjBXdGVwaHIrRzBFeFl2YkJWbWpF?= =?utf-8?B?bkxxK3l6dHorcW9ISlhkWktWbWRPWkpNdEpvQ01JcGw0OWRQaGtQNjN5OXd4?= =?utf-8?B?NUc1dGhtaDBMcENaaGtxMER4RHd6eVo5bytITUZWREM0NUN3Yk1vQVEvazFa?= =?utf-8?B?VUlGNWNFaTlNOFpBNVoxTUtpSFlPbko2UmEzYnBlbHlYTUpkWmdEWmxoV2FW?= =?utf-8?B?S0pSZVFWOEJsN1NqKzdPcS9OSEZiWlVieUY0UEkxbk9sY0I0emw2WTFxdFVi?= =?utf-8?B?YUZrL3pMOGV0dC9MNjl1UTkvWHJHRit1dkkySUpFL2N2VW5oNEJNS0trYUMx?= =?utf-8?B?R2dFelVMdk5lZ2s3YXpVeVp4ck1uVGlqR1gwTnBkMDRMUjVWL1hyUjREN29w?= =?utf-8?B?L0R5M0NmWkVZQ0IxalFnRVNWc3dQN2d4V3FDK0tYV2k0TWc5RnhYSWYzN1lY?= =?utf-8?B?V2h2UUU2Zk4xeE5BREtEd0pBV2pKaWJRNG5HUTdIU0FXK3ErZjFqMm5yZFJ4?= =?utf-8?B?eDlmR1VTTkhVdy9XQWxXay8rNG43bG5IVm5odi8rUGlTSGk1WTZRdHdnTUU3?= =?utf-8?B?OUsvSVN3aE5xbWgyYXcrc1NwdVpFWnNnMDZRNjJVV2diVnNtZGs2MzM2eG9x?= =?utf-8?B?MktrUVlhdFlmWkV6QTRRSlNMYnNwUEpndUk2SjJybDVEUFdwQXk4Vy9PSEtQ?= =?utf-8?B?RE8rV0l4ZExZOGJEcFJ5UlVTcDU5eitIK0tVVEdrL1JHMjcwU2lRVytKTVZC?= =?utf-8?Q?1SjH8VZvEo208sbvnJ3L2QLYW?= Content-Type: text/plain; charset="utf-8" Content-ID: <732FC1DF9CCCDF468F8C0061177C2A4A@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80a66a47-5756-4863-8f70-08dabcd228df X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 13:00:04.0615 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EqMH9hEM64rKYrzmejF6PxoGByHZzqVWJEkALu1xnOy8XS8CS3eVAX9j6w7+LZ5Qco/K9UGTYPaLHS8nzI0I6gyxOXK5thJVV4qoQ0rwdO4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5240 T24gMDIvMTEvMjAyMiAxMToyOCwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IFRoaXMgaGVhZGVy IGhhdmUgYmVlbiBjcmVhdGVkIGJ5IG1vdmluZyBjb2RlIGZyb20gb3RoZXIgcGFydCBvZiB0aGUN Cj4gcHJvamVjdCBhbmQgbWlzcyBhIGxpY2VuY2UgaGVhZGVyLiBUaGUgb3JpZ2luYWwgc291cmNl IGNvZGUgd2FzIHNvbWUNCj4gdmVyc2lvbiBvZiBHUEwgb3IgTEdQTCBidXQgd2UgaW50ZW5kIHRv IGhhdmUgdGhlIHB1YmxpYyBoZWFkZXIgdG8gYmUNCj4gTUlUIHNvIHRoZXkgY2FuIGJlIGluY2x1 ZGVkIGVhc2lseSBpbiBvdGhlciBwcm9qZWN0cy4NCj4NCj4gUGFydCBvZiBkZXZpY2VfdHJlZV9k ZWZzLmggd2VyZSBtb3ZlZCBmcm9tIGxpYnhsX2FybS5jIHdoaWNoIGlzDQo+IExHUEwtMi4xLW9u bHkuIEFuZCBwYXJ0IHdlcmUgbW92ZWQgZnJvbSBkZXZpY2VfdHJlZS5oIHRoYXQgaXMNCj4gR1BM LTIuMC1vbmx5Lg0KPg0KPiBQYXJ0IG9mIHRoZSBvcmlnaW5hbCBjb2RlIHdlcmUgYWRkZWQgYnkg SnVsaWVuIEdyYWxsIEAgQ2l0cml4IHdpdGggYQ0KPiBMaW5hcm8gImhhdCIgaW4gY29tbWl0cyBj M2JhNTJhODRkZDggYW5kIDQwNWMxNjdmMGVjOSBhbmQNCj4gODg2ZjM0MDQ1YmYwLiBUaGUgb3Ro ZXIgcGFydCB3ZXJlIGFkZGVkIGJ5IElhbiBDYW1wYmVsbCBAIENpdHJpeCwgd2l0aA0KPiBjb21t aXQgMGM2NDUyN2U3ZmM5Lg0KPg0KPiBSZXNvbHZlczogeGVuLXByb2plY3QveGVuIzM1DQo+IEZp eGVzOiAxYzg5OGE5ZmVjN2UgKCJ4ZW4vYXJtOiBtb3ZlIGEgZmV3IERUIHJlbGF0ZWQgZGVmaW5l cyB0byBwdWJsaWMvZGV2aWNlX3RyZWVfZGVmcy5oIikNCj4gUmVwb3J0ZWQtYnk6IEFuZHJldyBD b29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IEFudGhv bnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPg0KDQpJJ3ZlIGNoZWNrZWQgd2l0 aCByZWxldmFudCBwZW9wbGUuwqAgQ2l0cml4IGlzIGhhcHB5IGZvciB0aGlzIHRvIGJlDQpyZWxp Y2Vuc2VkIGFzIHByb3Bvc2VkLg0KDQpBY2tlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNv b3BlcjNAY2l0cml4LmNvbT4NCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 02 13:09:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 13:09:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435934.689887 (Exim 4.92) (envelope-from ) id 1oqDUX-0007Rt-KR; Wed, 02 Nov 2022 13:09:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435934.689887; Wed, 02 Nov 2022 13:09:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqDUX-0007Rm-H5; Wed, 02 Nov 2022 13:09:13 +0000 Received: by outflank-mailman (input) for mailman id 435934; Wed, 02 Nov 2022 13:09:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqDUW-0007Rg-97 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 13:09:12 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2086.outbound.protection.outlook.com [40.107.20.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8a3db6fd-5aaf-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 14:09:10 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7250.eurprd04.prod.outlook.com (2603:10a6:20b:1dc::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Wed, 2 Nov 2022 13:09:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 13:09:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a3db6fd-5aaf-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fCdWolnxcn1CkZ/dF50qh4YulwkPbc/tWnOry0yjv1vd9RxKwgPT2cf0osgYb/omBH5/vQhurTZP6sEg7PcmCIOunxDSXLTDg+uPqJYmWtjPhrGgwVd8wWWqVaasjbnOND9JZVmpcRVAfvAVIewDp1ORD5TZXOvl+Ln25yTU3gQ1HTYjsQ9dngtGrtrNiHLs0NqJN58befBR5bxSOWHBBnigx2Fre/JUPNk5V1ZuMDnLHbi4TBlHKIerD7Rf4/bSh3yYdYb6ie1Asq3H7XCWxysV2BJLZbtKTz/3AdMzOLAq024C2jhApwVShPJMMHis3wDmT9zjdKfbp/T/Wo59Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l7PjWG5zhvwbDgEjsAi6R7qZWOIjGlDWOcgveurhg1k=; b=FBMa1Wt5MMYYLVGv2LWHkTt6a9jU6/hKPi99BaMEl90yzRCgM/GctLMDOiyzIsH6IYS2mcrrqPRkM9Ud2yM5D4S/HDbj2N9gGtQQof/Fmm7XVm9a2tpLkRUYpDt6cxWqLJ3emrd6vVBpwJ4+rvgm3+AAf63pWfCPHXryrh5XdZKYQ2830Y6NQMMQtqRnXq0lPanKfrY+jPuiiJyMl1cXAPfZfTjtj0im9njQBy1i5PaTZFA8hu58yFId7Hbi2i4cVAFiN50q8Doml8C26AKc03tn0vnHbl2J6zpa0uZXvhkqsAGV75kDBngKcDTeCvJkSFRWzGkwS2pCdax3Pc3NMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l7PjWG5zhvwbDgEjsAi6R7qZWOIjGlDWOcgveurhg1k=; b=tCPJemhU+5d7fgmaruMEbX0nZBLeQb5eoVAuPTbuiXsUpJPAEDOptfxXFefW4Ke1uFkV1q9ZPTDS2IDS9Lxzt852ElCKKAOhBLBUuoB6Up/SYMkVQDGqpOr3oPKNfecqDl90F+KIXV+L2WecMC2LrtW478oQhkUFJRnt+VPs8FYOcjYGEm/PaF3mj+9ZE8V+UP5rVMi97JPStEhb0L69G5KkQmb1+GS5uW1Ez7jOafuKQHas8rPlF3I5qpiQCAh5tngsu01glJTSQtM9Gk2aZVNpVaTTuV82iHfaq0lrgcvb4jLl/NwoM0iELj7Q3zncweZ/IKNejFFbt3EUQRbmKQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <619bb7bb-a60a-5f13-53da-72e1d3a4aaf1@suse.com> Date: Wed, 2 Nov 2022 14:09:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN PATCH for-4.17 4/4] Rework COPYING installed in /usr/include/xen/, due to several licences Content-Language: en-US To: Anthony PERARD Cc: Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20221102112854.49020-1-anthony.perard@citrix.com> <20221102112854.49020-5-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: <20221102112854.49020-5-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR1001CA0015.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7250:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c2e0187-1d15-4ecf-a1d5-08dabcd36d11 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bISqUmoa29kQOGht5kx8tVNFRm41wiVzT836OwBREVenN4sP/L24kKQjFC/8g9uglf1US1yLH8Devu59jcceUQxa4LEVWSlHpCJJ3e0wUBT6WA+u8Qho3Nvca4Kt3YYvvBtZEdG7nuFmE8mL0aiOzcQdrPNZUYlkgtAV42EFwucqJaR6YTpfmK17jgTIWDjFqMMLBt8tyr0if7oD1fbBEKTXL0uPNQg0gsk/WRmstt2+k/JKVbrwQsps51Kc4IwQtxXDjIGpV473sISe9wePRvrZxWyLves+8AUGpcTIKb/MMuk4OpbLdAXUcbfdmIqiq1Er9CkTg9SZsnPvUMjNJGlJQKZSAaFJ9sWWwIcaNOEtW5I4sp2SvELzpNfyqQKW+LEisthh3qZUhunI/lanlj2lgXjmQ2k3jvA5m4bDhS0VhjvgNXTRoEddEf71hrI7AK3JC/m9VqSvzNGnpjpIum0vSHHOKDpt6zekCrjW/PQ4j6N2PHB4JaE429XSMFSIlL0tbNY74QYP2/w6zEA4qAsOrB+drSAlECvLiFehAfncNrJ7z2m8LeAH4HF61kU0R9yTTA6WgXq+N9062ie14caBpWn1MKcL+7czjQ3kc7uIi+jXPZEKUHOhw9AtoH6nL+NBMe50QJIRmtueyvuahEaGp0KzG8hMcDyYZvJnJELMiiIbndpCrPTNmgflFcrmnmmzPfRwrNjf/hlb2Ipls8XQMHxiYiIpa06NEaTys+uoi93IgUMBPJrIlSwA6ieM/gYB2NURVGUJIh55VAHWSByTR43V9r/c46BmUb3HPpbqQIiBkg5cu2GAj+9bqkF6/BE0IoCr1npoZEsK/1Hc9RrhSMcU6RGpbSw9py6/5QQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(376002)(366004)(39860400002)(346002)(451199015)(66899015)(31686004)(2616005)(2906002)(8936002)(5660300002)(41300700001)(8676002)(66946007)(66476007)(31696002)(38100700002)(316002)(83380400001)(186003)(53546011)(54906003)(6916009)(36756003)(86362001)(6512007)(66556008)(4326008)(6506007)(26005)(6486002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1dOWmg4NTBLdVlxT2dHWHVjVDlFQ2gzcW5qUUZpeEJxM21NSE9nZ2tZYlpO?= =?utf-8?B?K3g4Y24xejh1NC9uYmY0UDBBRndodE5EMGcrcENxaTg1cHc2VWRDMUJNcmd6?= =?utf-8?B?VXd1NTdrMGlQVEhsT3N3V3BPb24yTFdiRXE1VUNzazJGRy9wMUlzNVNMWTEr?= =?utf-8?B?RE92WWxmclRhVDJZVzlydVhMc1dRaExqb3kzNFpZQUZ4TFBEaEcrNGpRMHJX?= =?utf-8?B?NVRWZ2l2RlBNRitTdm9tamVVaDJ0b3FvWGxaM1ZyTnJpNXVWWnZlS0pzdDB1?= =?utf-8?B?bVRXMytwN1FtZmh6ZXp2OWhDWVl6Z2kzTUdzNFNFUit4QUtFNjBRQk13UW5l?= =?utf-8?B?SnNGd2NSOW9WbGFRZlF4dUZHeTNCdFV0OXc4N0Y5SVJvZmt1QWpKejdIZk83?= =?utf-8?B?aE8vNVR3QXpxVEYydnU4SGozdXBjV09NYlJkUlBvYm1BUUY0RGs0Y0kvZWtK?= =?utf-8?B?ZU9UaXZ6ZFE2V0Fpd2QwZzBFV0JEd0UwanBtY3I2U2lkOXcydVZTemt0bHNX?= =?utf-8?B?Q1JteEFGT09XNE9IeUEyTFJTc3NOeE9mc1BjNEJzWFAzdi9QNzIwSWM0eFFB?= =?utf-8?B?R0g0NnpNMDJjM25aWlFOQ3ZWaXlCUDAvWTJDN2xRejQwV1poV1hybWJiR0VV?= =?utf-8?B?KzN3WU96QkRyVXhtZmdjTVlqSVBFTEZFcXV5WkY5eGhvMXFlNUdxSU9xSmpj?= =?utf-8?B?Z1pCMDhVTWNuQ1pxcjZkZ09CUlhpVFZxYWN0Um1pR0ZRalB3M1M3b0lUNzdY?= =?utf-8?B?Z28xK05UZG1kOFBTUEg3QTh2SkRaSUcybWszUlladXkvOGNBZER5Z0V0d09i?= =?utf-8?B?SGJpTkduRTkxVERvZEJibVExdDRHaEhvV1VheWtLMDllN2V3Wjd5VTMwQWxs?= =?utf-8?B?VFIycGRMY2FDUkNEc1JaZDNmOU5wKzRnTENFOThCM1ZaTWFhNUszRGxTbjRx?= =?utf-8?B?YlJYVGZiRHNSSWNHVWk1QTFYNldnZXNQemJnQUdMdzM4WU01UDY0VWJRYlZ6?= =?utf-8?B?UnYwSW54NUpFUHVsc0kzbitJbWV2alJCVXlZbzRyUmdxa1lFL0dEbE91RXRB?= =?utf-8?B?Q3VUbDJaT0F2M0tzRE9KQmdRYm5DbDN0S0NIY2hyYk1DMkY4QUlqcWRJNmRT?= =?utf-8?B?NEVmek9MZkduY012NnJXUGNFZEJRQmNrdEkvN05JQ2R4SXo5RzlBek9RamdX?= =?utf-8?B?enVhUVp2MGs4NHRIdFBKOWVvY3ZVSllnNU5aZ3M5dGNReHZ0eDVkUEF6bjBJ?= =?utf-8?B?akhxV3pGZVdocFFXQVBOMzQ3MlFKZWdrR1B4S2I0QXJ2Ym00eXpIWkRTSFFF?= =?utf-8?B?bEFuQUZERUhCQ3VsUk1zSURzcWhoeU5vZUZxVCsyblhzNmkydnR3NkgyK1pG?= =?utf-8?B?b0xLQ3MwcmZ0VGhteFBjTTRDc252TE1STEtwTDZjaTBYR2YvNHBESjdIdXhq?= =?utf-8?B?c0NnOWx5bU1pd2xLSDJybStxWUR3ajVWOWlqdzF2T29JdUdMbmRTanpCcFZZ?= =?utf-8?B?UjZINUErekYvc0dBd1UraDh4S1Z6WXhUM0w4ZHc5UFpaRnlnVmZJeDhwSGpQ?= =?utf-8?B?VjVxVkNlS2VOd3hWSkZ3K3k5WXl5UWVsYmdPMHNtczIyWVlQeTlsd0xIS3lE?= =?utf-8?B?MFpiaG1jd3NOWUVpdHdUR3BlWlkzTGhYVnNiTXlQWUJqUWh6T252akg4VUVV?= =?utf-8?B?a2lqN3U3QlErZ0VHRXNoYzRjUjhGQ3ZUV0lpL204Y1ZCQTVEbXNuTkw4ZWNL?= =?utf-8?B?VVNuK0QyMlVKVnNVcnY4emN2NFE1YVdRUk5qazVDZFM0SzBVV0grdnpWRk1z?= =?utf-8?B?TGloSjJBc0dMeVpzS3c2eGs2cVJuTDRmbElZdVAvdzdpYmNuM2MwazlGQ0Qr?= =?utf-8?B?WklJR3RYR3AvbFpsRzRLYWdzRUlzRkZTZE5QVHM5Ui8ybERzaHVvOHVJbHFp?= =?utf-8?B?UWVjUlNQTmNodUprZHhhNmtKME4waWJZdjdVWHJ4NXVkRmlOa2dLYnB4bzFR?= =?utf-8?B?dUNycEo3bkF1a29VdUE0LzNCYVJidDg2TmRnZitzcE93YlFRenVWYytaRkxx?= =?utf-8?B?UXNPWHZSNXZMeEw0WTZEY0NvNFk0UlVqYXFqcHV3VGFITk5RTnFDYlMzTzVV?= =?utf-8?Q?tKeeuazBcOun/6XHqeKMyvJlp?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c2e0187-1d15-4ecf-a1d5-08dabcd36d11 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 13:09:08.1902 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gmnDJmSK5r6Z0ZUKjuP357s2zyN6J8Z2eQ1NpOpP8OZKqcOe1swz5gNJQU1wERuDKHGfN3na8rYK2E62qcf+PA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7250 On 02.11.2022 12:28, Anthony PERARD wrote: > --- /dev/null > +++ b/tools/include/xen/COPYING > @@ -0,0 +1,26 @@ > +XEN NOTICE > +========== > + > +This licence applies to all files within this subdirectory ("/usr/include/xen") > +with the exception of "sys/" which may include an header under public domain or > +BSD-2 licence. Nit: s/an header/headers/ ? And perhaps better to not name the two licenses here but instead keep this more generic so it wouldn't need changing if a header with yet another license appeared? > +===================================================================== > + > +Permission is hereby granted, free of charge, to any person obtaining a copy > +of this software and associated documentation files (the "Software"), to > +deal in the Software without restriction, including without limitation the I understand you've simply copied this from ./COPYING, but shouldn't it be "limitation of" or "limiting"? Jan > +rights to use, copy, modify, merge, publish, distribute, sublicense, and/or > +sell copies of the Software, and to permit persons to whom the Software is > +furnished to do so, subject to the following conditions: > + > +The above copyright notice and this permission notice shall be included in > +all copies or substantial portions of the Software. > + > +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE > +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > +FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > +DEALINGS IN THE SOFTWARE. From xen-devel-bounces@lists.xenproject.org Wed Nov 02 13:16:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 13:16:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435942.689898 (Exim 4.92) (envelope-from ) id 1oqDbF-00011F-Eh; Wed, 02 Nov 2022 13:16:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435942.689898; Wed, 02 Nov 2022 13:16:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqDbF-000118-Bl; Wed, 02 Nov 2022 13:16:09 +0000 Received: by outflank-mailman (input) for mailman id 435942; Wed, 02 Nov 2022 13:16:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqDbD-000112-Pz for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 13:16:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqDbD-0001zR-Hg; Wed, 02 Nov 2022 13:16:07 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.20.91]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oqDbD-0004l3-7C; Wed, 02 Nov 2022 13:16:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=7+JvXZyYtt5ysBoPO3lLZpX41CSdzaCd3dJ2JGRqb4g=; b=x5kN9NrNhdsWuCNsQEeufidbud p2F0KUGuUnOlUCT3v+9IeCh0IqZJRPUI2AjgoDmpe9ydvOqSZB1EUF+bmsWu7uKHpjpqduFhBrgg2 bujn5btpV3NQmDgvEuzkK7JsRh+tKnhCk6wXroRcct41bqC3c0nEZuqzWf7JRwiV1JWw=; Message-ID: Date: Wed, 2 Nov 2022 13:16:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN PATCH for-4.17 3/4] xen: Add licence header to device_tree_defs.h Content-Language: en-US To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Henry Wang , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20221102112854.49020-1-anthony.perard@citrix.com> <20221102112854.49020-4-anthony.perard@citrix.com> From: Julien Grall In-Reply-To: <20221102112854.49020-4-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 02/11/2022 11:28, Anthony PERARD wrote: > This header have been created by moving code from other part of the > project and miss a licence header. The original source code was some > version of GPL or LGPL but we intend to have the public header to be > MIT so they can be included easily in other projects. > > Part of device_tree_defs.h were moved from libxl_arm.c which is > LGPL-2.1-only. And part were moved from device_tree.h that is > GPL-2.0-only. > > Part of the original code were added by Julien Grall @ Citrix with a > Linaro "hat" in commits c3ba52a84dd8 and 405c167f0ec9 and > 886f34045bf0. From this comment it is not entirely who you think the copyright owner is. IIRC, part of the agreement was that all code written with my Linaro "hat" would be copyrighted by Linaro rather than Citrix. So I think we would need Linaro's agreement for the relicensing. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 02 14:08:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 14:08:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435948.689909 (Exim 4.92) (envelope-from ) id 1oqEPS-000888-GJ; Wed, 02 Nov 2022 14:08:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435948.689909; Wed, 02 Nov 2022 14:08:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqEPS-00087i-6H; Wed, 02 Nov 2022 14:08:02 +0000 Received: by outflank-mailman (input) for mailman id 435948; Wed, 02 Nov 2022 14:08:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqEPP-00087Z-KS for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 14:07:59 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60078.outbound.protection.outlook.com [40.107.6.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c06395f9-5ab7-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 15:07:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9068.eurprd04.prod.outlook.com (2603:10a6:10:2f3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.18; Wed, 2 Nov 2022 14:07:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 14:07:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c06395f9-5ab7-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dzhIE70kjY+y+cuY46maKKB5pnsYXCbwcXN0hZ6Mz84WiezyubOx3FMIZgRsUm2/x31mBYNYQUSO5VptWrsZWQae8/7JR3ov7eFf4Q57EXIJHhlxbeyLMNnXQLMaLYv9xfMqbdF3pFnw0Ubo1DsvG1FoBntY3AaX0vgdGeZTMxyDfkpAQZ3gS4+ofObDgF9wQ10kPAiYGwydHTHa6ZsCv2j+gJt1HkDVR9bEFsmSmRq+fhc6GL3PxZAVHQuA4CkVlLgOEc07axYsJ3lhn/qGKGTOW8YTsVKWpX5CUeYrk+4OJPvGRFuRhr3EfBz482ZzX2oNZ1tQ0MJ10+mGUwt4vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MNImGd2VfP1X7a4ep1HdEPAIBmU3R5jAKZYwcxXLpUY=; b=UYlCt+EDBoJhMYlJCyPcymyvtDV7maBdLMRQeCNox7oPr2Trdg54JWSamH0wZOSYVX/KcBKYMP5CwxDbHn7IOPij1sDc692/9YTiABDGkHaEyJkT/MOeEgng64iUMVHx4f4leGW7Kxr2HKy+p7Lf/93LIevpC2Nq1NhTU/sgFBDc++Siau6ZK7iNA0xJh4DA2akk7BS0dUrV//LQ1SbZrMuZ/5OQUt+e90BXjeYxWXQe+uc0kFlL4wYECBgBTn6mXGhk/gex0KFnTPYLEyl8OmVoiZ1EiQ8u+7XbrwcssaGDZsnbJ2mT51QRA3c9YHXX4YuvyTJqTlZhiWSM4DA//g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MNImGd2VfP1X7a4ep1HdEPAIBmU3R5jAKZYwcxXLpUY=; b=1pNJO/B5IO/VgQIVd4hIBKjxBCPbhXoVORC7zHj29JZ4tS/z/HL++w8UUPlAUrzhbll/Zpg1wIOYhTc9dWUjvoqUI1MwDD9ZB7np9IEr0BHGTPp05dLrDM3Sk+q9nYv8x99fo+efb4B/0Cumeh0FabUzZqYjmiR1WQb5E5T3i01yxs84veoDDB0NMUVIudfhIxUmm1sl9al5ETblcN2lavbAv/vgcHGos+qzPTI8E+ctZG8MJsDvI5ARRJw4jNfb2l5RHELmm7RxDdXbI4GZcoQgk7cc5QrO5jshnNgXAJ8gRN8qMtrlz+Lb2y9g9yHvUDXo/vZygqc8s4JNZmxgNw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 2 Nov 2022 15:07:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH-for-4.17 v2] xen/sched: migrate timers to correct cpus after suspend Content-Language: en-US To: Juergen Gross Cc: George Dunlap , Dario Faggioli , Meng Xu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Henry Wang , xen-devel@lists.xenproject.org References: <20221028111231.31355-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20221028111231.31355-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0137.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9068:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b6e652b-acc1-420c-6831-08dabcdba31b X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CVFDTIE12RxsdrowLnpSe2fQpiLBl4CGH1+NLv7Tu2IYs6k1Hgpv5TWTA56KO/TnZt6AYTEG0yfBVH9MSjJnZgBPkjfoeijlFnaabYTMNl0nBgj8i6vEJcZSixxJudgG+FVXMvn7Am+edYoX+TbkSvGVc9GNLlEv9Rturh/accj42XApsjKrICIT7oDgcBetPid3N1+KgmMNpOlHxEChG3o7htzhL9Wg3i7xkgkv4K/8HxuAhnUHmBdAMimNqJvN8m3MIqcz0GDcvdKRWDei5+A37tdR6BE9ofqxWAco5Fl+oQa5kVW71stFxdyyDOpjyxxqquG8oR1I5Cnze2Xh8ypBkuaZ+fyJIdIa1SUgSzE1UZ+9zDLLnKfovXM7cMGgtxpUkeWO2dDYMCehoBR+f5Ak/W1JKKsSLCXAVcP0Aj1OpkYNdbrKDRkdZ1aURyek2MfOV0WrDgQGDknlAIGC+1KMFX/zIuxI0ZaqbjdkRaCYdBpH7Pphb9085uOPJXvz0xpTDeNvHjEq5T7aZgdgvWbISQ9x9rWVoeEzYJLbJzRiyXICaf6Z+TOJgJT9k4BOEWeSuW1e5x78yeztAKnRUXZNYd3BTL0Oxo9tbkVnVJcSI2NrLN6q32nA1puR7dOtyybpZQnt8Y5Tqm2WoHspeVdaZ1l4uTgb9lp1PxzHhbElwbWmVrFEcG3l94gDcgeT5UXtwBadfTZEhvMPltGg8L+443sLmwS2Y0koTtOXchxx8HfG9FHMgBOHUlJpX5NuWJGRximbpwqpZk0r0Fr8vX3YuD9IqjOpN9pamn5f9Ls= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(366004)(346002)(39860400002)(136003)(451199015)(2616005)(6512007)(478600001)(26005)(6506007)(83380400001)(54906003)(186003)(53546011)(15650500001)(2906002)(66556008)(66946007)(6636002)(37006003)(8676002)(66476007)(6486002)(5660300002)(4326008)(8936002)(316002)(6862004)(41300700001)(31696002)(86362001)(36756003)(38100700002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WHYvenZQRjdFUitoQkYyMkVIdEVzOUFnbXR5VlVaRVpxSkxRY3pCNGxwUXVs?= =?utf-8?B?cnZSc3YxV2YyYThJVVpNR2F4cEdMVS9EWURMOVUxSG42Ym5kd3ZlT255QTFI?= =?utf-8?B?aFlZdndGTFp6a28vbFlUUVYwaEhGa3dSVXQ3ZlF0SkJCbE90UEMwd2NLaGFr?= =?utf-8?B?ZHY4QkRPK1NwcHVEUlRubWVsVGRkUFRhbG1uR1VHUTRZTVlJOW1aY1JSQ21X?= =?utf-8?B?T3NUbEgyM2x4VENUUDZQdlFocU4wckEybVE4b0djNWV3T1MySzZJbTZQWWxC?= =?utf-8?B?SDZvQTBkdjIrR2hkMDVQSWJacVptREF1U2UyVnBrd0tmZ1ByVVNXOUpoeFRB?= =?utf-8?B?Z0JDRTRjYXhUMThpdjROOEx0WGR0V2FUSytpMGhrTGNuL3VldFRPbDVxYWhu?= =?utf-8?B?ZlRqajgwb1lydHFyMHRhWU5pRUJ4WjdUS2NNbE9OdS81Z1dKSm5hN0xpRWhX?= =?utf-8?B?RlJlbmlBdGRJMEVqMDRTRmJPNlg0Ukw2M0pjdTVLdmhFeEtacU05eVA1Smd5?= =?utf-8?B?T2s1OGJrQjdaRmJzS29GN0t1TVBtODdMcXhEZS9FdHUveHdtUG9SMnR5bGt0?= =?utf-8?B?NkpwMFJSWlZiRzFBMm9nZ3NCK3ZZejUwendONXVCUEZGbnM1dkVOWVI1cUJ0?= =?utf-8?B?YnBrOUpOSE5aQkg3T2xhMy9ZSHp2dG5WK0h4bm0xU0pmRUFselhjRkRRSTFp?= =?utf-8?B?ZjVrL3RVWDIwaGFPakVHY1BWY1RJbjFGUVdPMEhHYXNoM0lPNXZWZzJ3dE96?= =?utf-8?B?akFUVzJSR1NSNjg5SmtobUlSM0lYRjAvMjc0QS9JeFZ0b3ZxM0lld21KM1VP?= =?utf-8?B?bXRLakthanpLWVFFRFBDUW9NWDNTZkNYSFIzNXNIeVYwZFg4Qkd1NkFwWWwx?= =?utf-8?B?Uy84Z1kzdXp4TWpYeEszNll0YkRSekY5M1FiQW93b3l0NjA2bUFNTUNqd3BP?= =?utf-8?B?em9tL1hubEhEenJVY0ZwRXlWek1rbEZTNTlobHhweEUrMmtJQ1F4VEp2aFZv?= =?utf-8?B?YnhNTWwrUzNjRjFrcDhYUU9xZ2RYQ0hVVTdBa1pqSkowNUNkRXc1OG1Hbmoz?= =?utf-8?B?SHF2RlBpRUtFNHRoRDk4R2oxUWdYWGE4aDBlazlkb3hkMzFXU0pya25DUktI?= =?utf-8?B?UjQ2UkdXL2h0OWZXczBVUUV1bXgyUXU0SE52VHJwTDdnV3BBNkhXNjFSUDFD?= =?utf-8?B?a3FQQ0VKREZFNkkrcnF3bm51aGk2THFaZ3ZFYkE0OWhIZHpjVFE0b2ZkdUNU?= =?utf-8?B?eHdYeEN4Vng5eXhCUmxHZEtUNEpwUkF5VGxSRWd5ekNsWnEwdmVLa2dPczBB?= =?utf-8?B?RHJiakZuSklMNlkxcmpkQUl0MnNIN24zUjlrb3NESTNQanY2eWdMUC9HVWtu?= =?utf-8?B?YlFLckNwbEdHMnBLZ2JyTFU1REpOZVhRNUJRaVpyNGgvc00yU09COWF5dlRW?= =?utf-8?B?UU9RZzNyS3pMd01oTnUrY1R4cm5XdnZidk1teWlTSmNsNkJYWGx4RjlaSUVv?= =?utf-8?B?TXkzaW9RaVRVNnJ3TlZueS92cGpxclJoY0M2eXBVeklSUmRBamN4RlhIM3Vh?= =?utf-8?B?TUw1OTM5UHBzMXNJYUdNNkVKQUxCRk9ZSENUVGJvdW9SMi8wR3NuWEppKy9p?= =?utf-8?B?WlhQODBDcXJxWGVtMTRCYTlURmJhaXRoajl4L29oeW1tN2JBYVhBSWtUaW1i?= =?utf-8?B?cEtzNThmZ1dhN0IvOU1WT0xIc0ordXRocEZVQ0FDakRIOWFVOTJrSms4WUxj?= =?utf-8?B?SFZYOHRlQ045OU85bjIzSklldnMzQ1dnNDBzWXBtK2pOOSsraUFIeW9ENzZr?= =?utf-8?B?ZW5ueUZWTGtoVEsra2NwV0RrbXRWVlZBL0Nsc294QlZ4dFlMR1JvOGN4Ykkx?= =?utf-8?B?bXJCTlVVUXo0K05OUlFkMG5Ub2xxYTFObjhFbk42dFlzam01aFU0dXIwYXBp?= =?utf-8?B?K1lvK1E4ajlCaVZiWnMyaTJjRVhCdUo5aXBMVWdmcnRrQlhjNUp3RHNRaDRj?= =?utf-8?B?RC9JaC9tUUJ6TVNLclp6a0RwYmtDR3RQQ01YQjJFY3I1TkZibEd5Q1FiTDRE?= =?utf-8?B?MWt5Z2M3WEhta3VZMmJpY3lrcFFGRG5YZmpGVHR2NlRYaG9RdWQ5enJQWTI2?= =?utf-8?Q?dwmpMMjfTWsytXPiiqKV/pGMH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b6e652b-acc1-420c-6831-08dabcdba31b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 14:07:54.7625 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1tYdCZpmvPeyTubAREsc6CmIeZP/raj+6tb6Kj6BayoIH9QDJzRMs0v4jNGRj9uTr1Lam/Mws3fGZ9lWdsAZjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9068 On 28.10.2022 13:12, Juergen Gross wrote: > Today all timers are migrated to cpu 0 when the system is being > suspended. They are not migrated back after resuming the system again. > > This results (at least) to problems with the credit scheduler, as the > timer isn't handled on the cpu it was expected to occur. While you say "at least", this doesn't really make clear in how far all four timers for which you change their handling are actually problematic, or whether for some you make the adjustment "just in case". Looking at core.c's s_timer I'm inclined to say that with s_timer_fn() raising the schedule softirq things can't go well when this doesn't happen on the correct CPU. Just that it won't be an obvious problem like the crash in credit1 which had prompted the creation of this patch. > Add migrating the scheduling related timers of a specific cpu from cpu > 0 back to its original cpu when that cpu has gone up when resuming the > system. > > Signed-off-by: Juergen Gross Is there any Fixes: tag possible? If not, could you add a respective note in the post-commit-message area, to increase the chance of recalling that this will want queuing for backport? (Or maybe the lack of a reasonable Fixes: tag could actually justify the use of the Backport: one.) > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -1284,6 +1284,32 @@ static int cpu_disable_scheduler_check(unsigned int cpu) > return 0; > } > > +/* > + * Called after a cpu has come up again in a suspend/resume cycle. > + * Note that on a system with smt=0 this will be called for the sibling cpus, > + * too, so the case for no scheduling resource being available must be > + * considered. I think this part of the comment would better live ... > + * Migrate all timers for this cpu (they have been migrated to cpu 0 when the > + * cpu was going down). > + * Note that only timers related to a physical cpu are migrated, not the ones > + * related to a vcpu or domain. > + */ > +void sched_migrate_timers(unsigned int cpu) > +{ > + struct sched_resource *sr; > + > + rcu_read_lock(&sched_res_rculock); > + > + sr = get_sched_res(cpu); ... inbetween here, increasing the chance that there won't be someone trying to remove the extra check ... > + if ( sr && sr->master_cpu == cpu ) ... from here. I further think that explicitly mentioning "smt=0" isn't very helpful. Aiui a system with some CPUs otherwise soft-offlined would suffer the same problem. And I further assume no problem would occur even with "smt=0" on AMD hardware or Arm (where we don't park CPUs). At the very least I'd therefore like to ask for "e.g." to be inserted; better would be a more generic statement like "with some CPUs parked". Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 02 14:20:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 14:20:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435953.689920 (Exim 4.92) (envelope-from ) id 1oqEbM-0002NN-HR; Wed, 02 Nov 2022 14:20:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435953.689920; Wed, 02 Nov 2022 14:20:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqEbM-0002Mx-BR; Wed, 02 Nov 2022 14:20:20 +0000 Received: by outflank-mailman (input) for mailman id 435953; Wed, 02 Nov 2022 14:20:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqEbM-0002Mr-12 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 14:20:20 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 78c0615d-5ab9-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 15:20:17 +0100 (CET) Received: from mail-dm6nam12lp2172.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Nov 2022 10:20:14 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5721.namprd03.prod.outlook.com (2603:10b6:806:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Wed, 2 Nov 2022 14:20:13 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 14:20:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78c0615d-5ab9-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667398817; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Gk+1qxE1/RsLDG9ozR69RKKHZaooRnR1lsHp0T+oddk=; b=TB1X7ypyGjIujZCaZe1sxQdJSJeEgZqIL4vdbGxSD8o/cKg0tQqJTWXx /9R5cwmP1j1nRE8CQBR7k/LHRhKHhQ6Z21kNYjEW68xLuA1AeSp1KeP9Z 51mUluQZUyjm3j2m8iZTO/sBdePxFRfj67GO8r9bXlw7BuiDvJbKrEDA6 E=; X-IronPort-RemoteIP: 104.47.59.172 X-IronPort-MID: 84031891 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:nqT0t6sgF5RVYKQdPxEH48qSAefnVGhfMUV32f8akzHdYApBsoF/q tZmKWnSPvbYYmT3fI9/OYW3900PsJKEzIVlQVZprC1nEn8W+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5Vv0gnRkPaoR5QaGzSFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwKh8/diCJm/yPmomDZsJSo88cJsrsBdZK0p1g5Wmx4fcOZ7nmGv+PyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgf60b4C9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPO3krqUz0AzKroAVIDIkeByQj+LisR+jC9ZiF X5X/DYwlZFnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQK2 1mTjpXWDDpgmLSPTDSW8bL8hTG4NDURLGQCTTQZVgZD6N7myKksijrfQ9AlF7S65uAZAhn1y jGO6SQ72bMaiJdR073hpA+dxTWxupLOUwg5oB3NWX6o5R94Y4jjYJG07V/c7rBLK4PxokS9g UXoUvO2tIgmZaxhXgTUKAnRNNlFP8q4DQA= IronPort-HdrOrdr: A9a23:oq5zKapF92uGbhjy58dggx4aV5uIL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcItKLzOWwldAS7sSobcKogeQUREWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZa6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInJy6IZn1V KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0aVjcVaKv6/VQIO0aSSAWUR4Z 3xStAbToNOAkbqDyOISN3Wqk/dOXgVmibfIBSj8AbeSITCNU4H4ox69Mxkm1LimjQdVJsX6t M140uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pWVFZ9l/1pwKpuKuZ3IAvqrIQ8VO V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkcoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWuKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFEhVsGYjEnieffFmHKc7hywlbF/NLggFkPsulqSRkoeMNIbDIGmEVE0kldemrrEWHtDbMs zDSq5rPw== X-IronPort-AV: E=Sophos;i="5.95,234,1661832000"; d="scan'208";a="84031891" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XQpHE628SrfpSiLfSy1QG2pE0KDV5JjTc/YfNvSFvdnQgQDbx+dfFiBs+KwZbj5hxU0Y5Lcizv32V97bK9jg+2qvTWaBLWKAWY2JixKuAarMg5HmhKVkfwQOOp39PXsdEovosRid5ThJAzxC0Fg9nbYU1J+dmtpv3+V/91LuCpG63sQ2Y4aRFoga1N+01vqaX5u49PWlBANxgnvCFyHY+HelExeyW/a0Ka6Wh+fTJCgb7OxR5Xc45wJ2iH3oo9f+1DyDg39tTE+mfPVtWy0YuqhESK6ud8RhX1e2a5YhwBzD7ukvPL7saLqai5gRVrfyFnSg1Mh8SFlucGsfyfVwlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gk+1qxE1/RsLDG9ozR69RKKHZaooRnR1lsHp0T+oddk=; b=HsqgJxa6sVq+3P0USnEfTss26aThSryuCJzkSPomla7oONsYB2GiDz5ipltLT78J8fM/X/RR+dBv+CZw/olCWED+PevzME1l6xpPeo9YEnbpavt57Skd7C0ucVnOVNLuGM8mQM9q/ceSk0UUP6j7rAja5TN7sSHWgWWdLfbv4qwze/RIflU0LFPpilx8F5GE3jrYjaS1UKsAmomqL+KAVaFY+dZ1nPf1wj3Lz7ZYfxR4q+5eugZyNLJ2hNir/BUriZsqJeFd29bXREPyDFRxrkm6wcLE4TotPcdXJK/FDk5bRLi/y9R6QuxyKZJv9TnZ4IiB31pkab47V/jotN0tLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gk+1qxE1/RsLDG9ozR69RKKHZaooRnR1lsHp0T+oddk=; b=u2+IwBonDSME7femV2Z5tmVTF917cSAyfLsqNVorCLjt/BdH3CtG6uj0RZHZD3OqzsJ468ETWbw3WB4yCNO20E16sbyHRBYiAA+mc6UfxMVByNnfQk82S0TcBLJSAzJf+p8IOfyaazsjuN155m0DrWiBWVxKKjhWi7fh8sbtkBU= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: "Henry.Wang@arm.com" , Jan Beulich , Wei Liu Subject: Re: [PATCH for-4.17 v2 1/3] hvm/msr: load VIRT_SPEC_CTRL Thread-Topic: [PATCH for-4.17 v2 1/3] hvm/msr: load VIRT_SPEC_CTRL Thread-Index: AQHY6sNZyDs+pahU70+VbMHdR6akRa4rtukA Date: Wed, 2 Nov 2022 14:20:12 +0000 Message-ID: References: <20221028114913.88921-1-roger.pau@citrix.com> <20221028114913.88921-2-roger.pau@citrix.com> In-Reply-To: <20221028114913.88921-2-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA2PR03MB5721:EE_ x-ms-office365-filtering-correlation-id: 78951c65-71d9-4547-66c8-08dabcdd5b31 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QKNPtbcge/rbZvoeUB6S8nMSQKY6u/0GZt7zxznrG78am8tdnV+Sa4u7zBBApSh7RtP1HG9WlYoIhs4xSXD2VKZNvvdtyeJgwTUz0zba1t2sHV3w5OBP8NfUXVhRm93KyJNQMl0zIfuLRz5mSUi8GftQMQLFWVol0aaSX/3+kRyFTLKaieNhpLpaorA/rbpL0QQUR0hTJtdDkOosSCHd4YHoq+XgOdG6HaYx/lRr+YwotBw7Ue5jB6ESNaUwiRa7rW99xnpLTOczNNVwZErAqL64tVJDMLfRNnxpSm871d4Z+YM1V4iMAvJtzwHPosf0gov/FL19kS1QM6WKhKBwP/GHHPhMF9Z/s4J7f/xFpOMxNzjQOsZKhBDKbbf2nh82q0O/RE8Z0E7wMjbHL2ZaUNy49Lc+9IfpVwXbeIQISRlRmqcXfYFFZEFtgxFjTDFisGWqV/hIIl7xkqtF611gMHbjNvykKP0UNOr/S674UmfP/iE8K+yxQxDP7oNR731Yw41nGWq3xgtmGyojl0GG6AAn37XQ0yq2JeoOeMTuH8ClEPdm5Tkt/L3D4yrrSsOK8nwiHGHGyKVCCcxy1M5jax6ZNqoyTFiqlowLmfRkjnQj4ltFSaIwbbiENZHZXw8cegramP9UuWVjDjCrbAFd86Zvs9N1ffwfYQdUYT8S84iygNU8B/xwbPo6tHeG68AB2UToCF6G83aKaNQiml4YuBOdLGJyQ6a2bWcy5Vu2VCjUxKFBeb4W1JD1yAuQt0nGhyP8ccIY5otHbsg+pnDR499K1gXZupfvWVLZ04v++CbFRz2I0mnwdzZCUNpZgzpL8Cgnu8XPCWw/C4oEzekgOw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(366004)(346002)(396003)(451199015)(316002)(54906003)(110136005)(71200400001)(66446008)(8676002)(478600001)(66556008)(76116006)(6486002)(4326008)(91956017)(66946007)(53546011)(31686004)(66476007)(6506007)(64756008)(26005)(6512007)(8936002)(5660300002)(4744005)(186003)(2616005)(2906002)(38070700005)(36756003)(86362001)(31696002)(122000001)(41300700001)(82960400001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bXdqQ29RU1U1akZrTmhzajAyZWxoSkhrbWcwWTVvMStSbUdWVUJrNlM0eU9s?= =?utf-8?B?NzdvWUw1bHFDalpDYkVWRmpHQmx2SU5pZUE5MjhlbkxUYnFZdUZIWTZMMlBY?= =?utf-8?B?WXdLQWdrN1Ryam1ENkNQL1lTcVBCZng2SlZjYjYrODA2UDl0bU51TVJxeHBn?= =?utf-8?B?cUJUTTd3VkN0TjJsaXVBUXM0ekpRZkszWDVCZVZyTEhYRUZCU0sxTTExUkQ3?= =?utf-8?B?TlhXUFhhVmRZTGhpMGtHUnhjN2VQNVlNRGZBT2lqSERCSXgwMFoxcDRHdm5H?= =?utf-8?B?akdlbkUrMktrMGVGVm5yUkpzZlREdVUxb1BFdnprNWJZMnRoRFBnM3l3ajhv?= =?utf-8?B?aWIzVGhzWXFMVlFES2xXOVdoMC82NzJocGNackpKVTVnQ3U3Rk9tYld4ai9N?= =?utf-8?B?ZEN0OU9CeitDbjU4b2lVbVJBenZ6WkNwdTZ6UkRwdkhYTVpkbWRDYjhSdm1N?= =?utf-8?B?ZGxEZFRxeEZtUkc0RkRPVG1VcnR4UFQ5OHdaMEZyYmxMeHNKU1ZYaWRYRVRm?= =?utf-8?B?U0o3eW9qTWp2OGh0MVcwMFpVRzFOeEJOS2swaWNPY2ljb3FRL3VjNEpScFJD?= =?utf-8?B?OEJFQzNGb0ZsbXhLcUVCYWZLOUE5a2tPZUdtdmVoOEVnWndab0cwb2h1bTNL?= =?utf-8?B?WGxhODl6ZWgwTHJyL2svdmRtN0wwNXZCSGc5TjkzbTVSaXN3aVl2My9JbXRS?= =?utf-8?B?dENpQmRsdlIzWWs1RTNrdmRDQS9oVnQ0NDBJSjNBd2JKM3BzZExoSTVhUTBB?= =?utf-8?B?NmxkWlFGVFJQR0U5WWdOVDdBMlZQL3JWWTRlZElKVTNiYThlY0N2V2tjc3RD?= =?utf-8?B?Q003MnNpeUlVN0hvRkxzUUlhL2VpcTRlY05nalZ0emhyTDBBM3FSMWFsM084?= =?utf-8?B?WHBvNXU1VlhJeUhqOE9zcVdIL2dTUkJVb24yd2NWVDE1SmJiUG5GS1ZqdFNZ?= =?utf-8?B?c1BndXBtcmZDam1ZeEdmUit1NWE0c1UvZ2ZlSThSNThMNFFnejk1MkpVMXlw?= =?utf-8?B?R21CaWRaelR4dVF4di9UZHlSUEMySWsvUHk5LzdtVU5jbWhXbjB5R2xIVVNq?= =?utf-8?B?NzVDNWxIKytuUnVqM0lUN1JzUVF6SHlVS1MwN1RMbFA3c1dWcnZYT1Zlc1B6?= =?utf-8?B?M0w5eGFqbzNtbzJ3MnZDNEFOVHFacWYvN29BeDhleDI4SHpxNGgzNW16clVs?= =?utf-8?B?MXJzRS9WSDNuSy9CK08vZlBsbktwOHQ4T1JXTGZuMmpCQyt1bXdhdHkxR1Zm?= =?utf-8?B?YmY5S3NQVjJPNUsrWVNjNDhLM01HVUQzNVM5aFVwaER3ZUtWWkY5c0gxeE8x?= =?utf-8?B?eFpoZ1ZjQ1Bib1RnWTZ4WmZSRER2WkpaNis4Q1Zzc2MvV1hWL2ZQa3hVOHNI?= =?utf-8?B?NFdoK0Vabk16WG9ZQzE1eUlUOEFnc0JZSENYMTdQdTBHbkhDR2VtTFluWm9L?= =?utf-8?B?dUQ2RkhuRVlNSDRTY29JVWlBYlJCWGdkRTA5eW9MbHdEbDk4dzljbnpLK2ta?= =?utf-8?B?RE85M0o3R2czUVZXWWNDNnNPSThkOTNjcUhZcDM2M0FrM3gvc0ZBZlIvUmVz?= =?utf-8?B?T0F4TStiU2Fsa1pxWHd0M2cycStJeDRxUG4rYUc0c3lnQ0Y1aXlDUVB1OFBm?= =?utf-8?B?aklMS2tJeU5vZVl2ZTVGTjNXaFhKTkQyaXVwVXBDNjZQdGxWOTVjbHdQdDhJ?= =?utf-8?B?cFVPbEg5TitXdGgreTF4d2JTUVdIcThYb3BBY2lTcy9JRHBnV2ZBRm9RSlBC?= =?utf-8?B?YWxYb3V6ZVQ0anBOOEd5eXBMU2phekRYbTQ0V3VIM3R5K2ZPM3k2U0NSQVZy?= =?utf-8?B?ZTk0ellEUUltUEhrWlFxQ2JGdlVHcDJEYnhvd1hmQXlIblIyRnk5WmlSMDJB?= =?utf-8?B?VVJCbytYcXEvRGFWZGZMczdOc2xNUlZoV0dTRndxa2ptTmlqUHJlNnhOVlhv?= =?utf-8?B?QTBubFJKbWFEeXFHNU1Gc3FYeFg5cHhYY0dFWmtoQ0VsVjY1RWRJTjVQWEE4?= =?utf-8?B?dXJ5WTRFdDE4ZU9XYjRLcEdicjBnMnY1UmNaOVkxTngyNDMwREpBQWhMZkl4?= =?utf-8?B?SUswNDI3aVZGNVdYZkRnejdPdC8wcS91anBISjVXaTd1OUdUdXNtWStrWHRV?= =?utf-8?Q?gu3Gacqz5uaooPLeB+ama4PVb?= Content-Type: text/plain; charset="utf-8" Content-ID: <4E4191424160314C8D35F46213C0C27A@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78951c65-71d9-4547-66c8-08dabcdd5b31 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 14:20:12.9948 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M1Dfb6z6XPqXvxmAmZ6m4NdWEw3S9d2rq45F3K/j87CGCQP9c4dBcDfK3wqjPGXxAb6osCqcVoq/Ssy3QAViTfr3tJRcj+o+grdonl+oppA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5721 T24gMjgvMTAvMjAyMiAxMjo0OSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBBZGQgTVNSX1ZJ UlRfU1BFQ19DVFJMIHRvIHRoZSBsaXN0IG9mIE1TUnMgaGFuZGxlZCBieQ0KPiBodm1fbG9hZF9j cHVfbXNycygpLCBvciBlbHNlIGl0IHdvdWxkIGJlIGxvc3QuDQo+DQo+IEZpeGVzOiA4ZmZkNTQ5 NmY0ICgnYW1kL21zcjogaW1wbGVtZW50IFZJUlRfU1BFQ19DVFJMIGZvciBIVk0gZ3Vlc3RzIG9u IHRvcCBvZiBTUEVDX0NUUkwnKQ0KPiBTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxy b2dlci5wYXVAY2l0cml4LmNvbT4NCj4gLS0tDQo+IEknbSBjb25mdXNlZCBhcyB0byB3aHkgd2Ug aGF2ZSB0d28gZGlmZmVyZW50IGxpc3Qgb2YgTVNSIHRvIHNlbmQgYW5kDQo+IGxvYWQsIG9uZSBp biBtc3JzX3RvX3NlbmRbXSBhbmQgdGhlIG90aGVyIG9wZW4tY29kZWQgaW4NCj4gaHZtX2xvYWRf Y3B1X21zcnMoKSwgYnV0IGdpdmVuIHRoZSByZWxlYXNlIHN0YXR1cyBpdCdzIG5vIHRpbWUgdG8N Cj4gY2xlYW4gdGhhdCB1cC4NCg0KSXQncyBuZWNlc3NhcnkgKGZvciBub3cpLg0KDQpndWVzdF93 cm1zcigpIHN0YXJ0ZWQgYXMgb25seSBzYWZlIGluIGN1cnJlbnQgY29udGV4dC7CoCBUaGUgY29u dmVyc2lvbg0Kd29yayAodG8gbWFrZSBpdCBzYWZlIGluIHJlbW90ZS1idXQtcGF1c2VkIGNvbnRl eHQpIGlzIGluIHByb2dyZXNzLg0KDQplLmcuIGd1ZXN0X3dybXNyKCkncyBjYWxsIGludG8gdm1j ZV93cm1zcigpIHdpbGwgbWFsZnVuY3Rpb24gaW4NCm5vbi1jdXJyZW50IGNvbnRleHQuwqAgVGhl cmUgYXJlIHByb2JhYmx5IG90aGVycyAoYWx0aG91Z2ggSSB0aGluayBtb3N0DQpvZiBwcm9ibGVt IHdlbnQgYXdheSB3aGVuIHJlc3RydWN0dXJlZCB0aGUgaGFuZGxlcnMuKQ0KDQpUaGUgbGlzdCBp cyB0aGUgbGlzdCBvZiBNU1JzIGlzIHRoZSBzdWJzZXQga25vd24gc2FmZSBmb3IgcmVtb3RlDQp3 cml0ZXMuwqAgSXQgc2hvdWxkIGJlIGRyb3BwZWQgd2hlbiBndWVzdF93cm1zcigpIGlzIGZ1bGx5 IHNhZmUuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 02 14:23:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 14:23:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435957.689931 (Exim 4.92) (envelope-from ) id 1oqEe4-0002yB-18; Wed, 02 Nov 2022 14:23:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435957.689931; Wed, 02 Nov 2022 14:23:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqEe3-0002xl-Oi; Wed, 02 Nov 2022 14:23:07 +0000 Received: by outflank-mailman (input) for mailman id 435957; Wed, 02 Nov 2022 14:23:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqEe2-0002xK-TN for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 14:23:06 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ddda2bcd-5ab9-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 15:23:05 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2C4992275B; Wed, 2 Nov 2022 14:23:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E8FE313AE0; Wed, 2 Nov 2022 14:23:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Wed8N0h9YmMmWAAAMHmgww (envelope-from ); Wed, 02 Nov 2022 14:23:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ddda2bcd-5ab9-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667398985; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LJAo3gqPTp8Orsxtic1quHFTdRiwvXrv/5/2uhasay8=; b=bW6SuY+uF78250akBRtgJBMhltenqJJ9LlwitamPeP7sC54AcVuR07noGVXfB/AuWv021g WLr+HxSwTOAdah5IDQopAOytpqZ67DxBWaSzNryOgTo45eT7evZjTAH8A+bMkt8tbKV2U9 HSW/PybvQR38+eQ22o/tFpucY2DmIzA= Message-ID: Date: Wed, 2 Nov 2022 15:23:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Content-Language: en-US To: Jan Beulich Cc: George Dunlap , Dario Faggioli , Meng Xu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Henry Wang , xen-devel@lists.xenproject.org References: <20221028111231.31355-1-jgross@suse.com> From: Juergen Gross Subject: Re: [PATCH-for-4.17 v2] xen/sched: migrate timers to correct cpus after suspend In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------qGAe3Qu00wlImgkbLbEnQwXD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------qGAe3Qu00wlImgkbLbEnQwXD Content-Type: multipart/mixed; boundary="------------phEBqqbFRTkO94t0cIMRLoRT"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: George Dunlap , Dario Faggioli , Meng Xu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Henry Wang , xen-devel@lists.xenproject.org Message-ID: Subject: Re: [PATCH-for-4.17 v2] xen/sched: migrate timers to correct cpus after suspend References: <20221028111231.31355-1-jgross@suse.com> In-Reply-To: --------------phEBqqbFRTkO94t0cIMRLoRT Content-Type: multipart/mixed; boundary="------------1zpEi0ObdjF8TLIYNnSQpALV" --------------1zpEi0ObdjF8TLIYNnSQpALV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDIuMTEuMjIgMTU6MDcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyOC4xMC4yMDIy IDEzOjEyLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gVG9kYXkgYWxsIHRpbWVycyBhcmUg bWlncmF0ZWQgdG8gY3B1IDAgd2hlbiB0aGUgc3lzdGVtIGlzIGJlaW5nDQo+PiBzdXNwZW5k ZWQuIFRoZXkgYXJlIG5vdCBtaWdyYXRlZCBiYWNrIGFmdGVyIHJlc3VtaW5nIHRoZSBzeXN0 ZW0gYWdhaW4uDQo+Pg0KPj4gVGhpcyByZXN1bHRzIChhdCBsZWFzdCkgdG8gcHJvYmxlbXMg d2l0aCB0aGUgY3JlZGl0IHNjaGVkdWxlciwgYXMgdGhlDQo+PiB0aW1lciBpc24ndCBoYW5k bGVkIG9uIHRoZSBjcHUgaXQgd2FzIGV4cGVjdGVkIHRvIG9jY3VyLg0KPiANCj4gV2hpbGUg eW91IHNheSAiYXQgbGVhc3QiLCB0aGlzIGRvZXNuJ3QgcmVhbGx5IG1ha2UgY2xlYXIgaW4g aG93IGZhciBhbGwNCj4gZm91ciB0aW1lcnMgZm9yIHdoaWNoIHlvdSBjaGFuZ2UgdGhlaXIg aGFuZGxpbmcgYXJlIGFjdHVhbGx5IHByb2JsZW1hdGljLA0KPiBvciB3aGV0aGVyIGZvciBz b21lIHlvdSBtYWtlIHRoZSBhZGp1c3RtZW50ICJqdXN0IGluIGNhc2UiLiBMb29raW5nIGF0 DQo+IGNvcmUuYydzIHNfdGltZXIgSSdtIGluY2xpbmVkIHRvIHNheSB0aGF0IHdpdGggc190 aW1lcl9mbigpIHJhaXNpbmcgdGhlDQo+IHNjaGVkdWxlIHNvZnRpcnEgdGhpbmdzIGNhbid0 IGdvIHdlbGwgd2hlbiB0aGlzIGRvZXNuJ3QgaGFwcGVuIG9uIHRoZQ0KPiBjb3JyZWN0IENQ VS4gSnVzdCB0aGF0IGl0IHdvbid0IGJlIGFuIG9idmlvdXMgcHJvYmxlbSBsaWtlIHRoZSBj cmFzaCBpbg0KPiBjcmVkaXQxIHdoaWNoIGhhZCBwcm9tcHRlZCB0aGUgY3JlYXRpb24gb2Yg dGhpcyBwYXRjaC4NCj4gDQo+PiBBZGQgbWlncmF0aW5nIHRoZSBzY2hlZHVsaW5nIHJlbGF0 ZWQgdGltZXJzIG9mIGEgc3BlY2lmaWMgY3B1IGZyb20gY3B1DQo+PiAwIGJhY2sgdG8gaXRz IG9yaWdpbmFsIGNwdSB3aGVuIHRoYXQgY3B1IGhhcyBnb25lIHVwIHdoZW4gcmVzdW1pbmcg dGhlDQo+PiBzeXN0ZW0uDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8 amdyb3NzQHN1c2UuY29tPg0KPiANCj4gSXMgdGhlcmUgYW55IEZpeGVzOiB0YWcgcG9zc2li bGU/IElmIG5vdCwgY291bGQgeW91IGFkZCBhIHJlc3BlY3RpdmUNCj4gbm90ZSBpbiB0aGUg cG9zdC1jb21taXQtbWVzc2FnZSBhcmVhLCB0byBpbmNyZWFzZSB0aGUgY2hhbmNlIG9mDQo+ IHJlY2FsbGluZyB0aGF0IHRoaXMgd2lsbCB3YW50IHF1ZXVpbmcgZm9yIGJhY2twb3J0PyAo T3IgbWF5YmUgdGhlIGxhY2sNCj4gb2YgYSByZWFzb25hYmxlIEZpeGVzOiB0YWcgY291bGQg YWN0dWFsbHkganVzdGlmeSB0aGUgdXNlIG9mIHRoZQ0KPiBCYWNrcG9ydDogb25lLikNCg0K SSdtIG5vdCBzdXJlIHdoZXRoZXIgaXQgaXMgcmVhbGx5IGNvcnJlY3QsIGJ1dCBJIGFzc3Vt ZSB0aGUgbW9zdCBwcm9iYWJsZQ0KY2FuZGlkYXRlIGZvciBhIEZpeGVzOiB0YWcgd291bGQg YmUgY29tbWl0IDA3NjNjZDI2ODc4OS4NCg0KPiANCj4+IC0tLSBhL3hlbi9jb21tb24vc2No ZWQvY29yZS5jDQo+PiArKysgYi94ZW4vY29tbW9uL3NjaGVkL2NvcmUuYw0KPj4gQEAgLTEy ODQsNiArMTI4NCwzMiBAQCBzdGF0aWMgaW50IGNwdV9kaXNhYmxlX3NjaGVkdWxlcl9jaGVj ayh1bnNpZ25lZCBpbnQgY3B1KQ0KPj4gICAgICAgcmV0dXJuIDA7DQo+PiAgIH0NCj4+ICAg DQo+PiArLyoNCj4+ICsgKiBDYWxsZWQgYWZ0ZXIgYSBjcHUgaGFzIGNvbWUgdXAgYWdhaW4g aW4gYSBzdXNwZW5kL3Jlc3VtZSBjeWNsZS4NCj4+ICsgKiBOb3RlIHRoYXQgb24gYSBzeXN0 ZW0gd2l0aCBzbXQ9MCB0aGlzIHdpbGwgYmUgY2FsbGVkIGZvciB0aGUgc2libGluZyBjcHVz LA0KPj4gKyAqIHRvbywgc28gdGhlIGNhc2UgZm9yIG5vIHNjaGVkdWxpbmcgcmVzb3VyY2Ug YmVpbmcgYXZhaWxhYmxlIG11c3QgYmUNCj4+ICsgKiBjb25zaWRlcmVkLg0KPiANCj4gSSB0 aGluayB0aGlzIHBhcnQgb2YgdGhlIGNvbW1lbnQgd291bGQgYmV0dGVyIGxpdmUgLi4uDQo+ IA0KPj4gKyAqIE1pZ3JhdGUgYWxsIHRpbWVycyBmb3IgdGhpcyBjcHUgKHRoZXkgaGF2ZSBi ZWVuIG1pZ3JhdGVkIHRvIGNwdSAwIHdoZW4gdGhlDQo+PiArICogY3B1IHdhcyBnb2luZyBk b3duKS4NCj4+ICsgKiBOb3RlIHRoYXQgb25seSB0aW1lcnMgcmVsYXRlZCB0byBhIHBoeXNp Y2FsIGNwdSBhcmUgbWlncmF0ZWQsIG5vdCB0aGUgb25lcw0KPj4gKyAqIHJlbGF0ZWQgdG8g YSB2Y3B1IG9yIGRvbWFpbi4NCj4+ICsgKi8NCj4+ICt2b2lkIHNjaGVkX21pZ3JhdGVfdGlt ZXJzKHVuc2lnbmVkIGludCBjcHUpDQo+PiArew0KPj4gKyAgICBzdHJ1Y3Qgc2NoZWRfcmVz b3VyY2UgKnNyOw0KPj4gKw0KPj4gKyAgICByY3VfcmVhZF9sb2NrKCZzY2hlZF9yZXNfcmN1 bG9jayk7DQo+PiArDQo+PiArICAgIHNyID0gZ2V0X3NjaGVkX3JlcyhjcHUpOw0KPiANCj4g Li4uIGluYmV0d2VlbiBoZXJlLCBpbmNyZWFzaW5nIHRoZSBjaGFuY2UgdGhhdCB0aGVyZSB3 b24ndCBiZSBzb21lb25lDQo+IHRyeWluZyB0byByZW1vdmUgdGhlIGV4dHJhIGNoZWNrIC4u Lg0KDQpPa2F5Lg0KDQo+IA0KPj4gKyAgICBpZiAoIHNyICYmIHNyLT5tYXN0ZXJfY3B1ID09 IGNwdSApDQo+IA0KPiAuLi4gZnJvbSBoZXJlLg0KPiANCj4gSSBmdXJ0aGVyIHRoaW5rIHRo YXQgZXhwbGljaXRseSBtZW50aW9uaW5nICJzbXQ9MCIgaXNuJ3QgdmVyeSBoZWxwZnVsLg0K PiBBaXVpIGEgc3lzdGVtIHdpdGggc29tZSBDUFVzIG90aGVyd2lzZSBzb2Z0LW9mZmxpbmVk IHdvdWxkIHN1ZmZlciB0aGUNCj4gc2FtZSBwcm9ibGVtLiBBbmQgSSBmdXJ0aGVyIGFzc3Vt ZSBubyBwcm9ibGVtIHdvdWxkIG9jY3VyIGV2ZW4gd2l0aA0KPiAic210PTAiIG9uIEFNRCBo YXJkd2FyZSBvciBBcm0gKHdoZXJlIHdlIGRvbid0IHBhcmsgQ1BVcykuIEF0IHRoZSB2ZXJ5 DQo+IGxlYXN0IEknZCB0aGVyZWZvcmUgbGlrZSB0byBhc2sgZm9yICJlLmcuIiB0byBiZSBp bnNlcnRlZDsgYmV0dGVyDQo+IHdvdWxkIGJlIGEgbW9yZSBnZW5lcmljIHN0YXRlbWVudCBs aWtlICJ3aXRoIHNvbWUgQ1BVcyBwYXJrZWQiLg0KDQpJJ2xsIGdvIHdpdGggdGhlIGxhdHRl ci4NCg0KDQpKdWVyZ2VuDQo= --------------1zpEi0ObdjF8TLIYNnSQpALV Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------1zpEi0ObdjF8TLIYNnSQpALV-- --------------phEBqqbFRTkO94t0cIMRLoRT-- --------------qGAe3Qu00wlImgkbLbEnQwXD Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNifUgFAwAAAAAACgkQsN6d1ii/Ey+n Twf8CTjZU7GA4g4HXYuM/4IRp0q17HgdwcCXkTSxtCbplsLh+hJYNLOQC0k592CCNrwWV8Ll0bhP 77qXjBNPOqI2Duk5IMFAGxNVeYprnOJJ0ggcF3g8n8KzgHQgJfcudBJ3vWRraO+xqCSMzOeu/xeN FFJbWvOjOKn9Tc/cBJlqSyMWTj7JhOT+r4eHgRAlXa9tcJOS4QDSkbAyTdVW/N0TvUsovpoYd8ix ay28m3XjodZMoPvLRr0AO8mcRLqrWztgk9TnOAIfcvJLsUyzeZ/A0+OxUYAdUY2K0f04ExU6Olzj /P3KEmUxFvA7uCrA/qJhaxV6Bdq11IgtUsZQ0COFZQ== =1oY8 -----END PGP SIGNATURE----- --------------qGAe3Qu00wlImgkbLbEnQwXD-- From xen-devel-bounces@lists.xenproject.org Wed Nov 02 15:00:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 15:00:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435970.689942 (Exim 4.92) (envelope-from ) id 1oqFEP-0000Cs-2o; Wed, 02 Nov 2022 15:00:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435970.689942; Wed, 02 Nov 2022 15:00:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqFEO-0000Ck-TG; Wed, 02 Nov 2022 15:00:40 +0000 Received: by outflank-mailman (input) for mailman id 435970; Wed, 02 Nov 2022 15:00:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqFEO-0000Ce-7I for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 15:00:40 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c980c8c-5abf-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 16:00:38 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EDEEF22BC1; Wed, 2 Nov 2022 15:00:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B425013AE0; Wed, 2 Nov 2022 15:00:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ynSiKhWGYmOIcAAAMHmgww (envelope-from ); Wed, 02 Nov 2022 15:00:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c980c8c-5abf-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667401237; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xNCfxi96uIUvgpHLKVAC+IBUegMYVriE//mcaTsisWs=; b=Dw3EU0OT5O9jA9yNut1p5qnjHCtfmN2bw9l+LS09rzgQHVVDGO4cQoDVm8ZhLhABlTtASd Qg6D/HvC/4RScjxnxP34MVLDNpQCgu5yDRZDOpjigUHWfTgdwA1ibpAZmtMBzUMJD1zpo7 O+t8dJ1agX/hpqaRL1D4T4qtyDGJSPQ= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , George Dunlap , Dario Faggioli , Meng Xu , Henry Wang , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH-for-4.17 v3] xen/sched: migrate timers to correct cpus after suspend Date: Wed, 2 Nov 2022 16:00:35 +0100 Message-Id: <20221102150035.4885-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Today all timers are migrated to cpu 0 when the system is being suspended. They are not migrated back after resuming the system again. This results (at least) to visible problems with the credit scheduler, as the timer isn't handled on the cpu it was expected to occur, which will result in an ASSERT() triggering. Other more subtle problems, like uninterrupted elongated time slices, are probable. The least effect will be worse performance on cpu 0 resulting from most scheduling related timer interrupts happening there after suspend/resume. Add migrating the scheduling related timers of a specific cpu from cpu 0 back to its original cpu when that cpu has gone up when resuming the system. Fixes: 0763cd268789 ("xen/sched: don't disable scheduler on cpus during suspend") Signed-off-by: Juergen Gross Tested-by: Marek Marczykowski-Górecki --- V2: - fix smt=0 case (Marek Marczykowski-Górecki) V3: - minor comment and commit message adjustments (Jan Beulich) --- xen/common/sched/core.c | 29 +++++++++++++++++++ xen/common/sched/cpupool.c | 2 ++ xen/common/sched/credit.c | 13 +++++++++ xen/common/sched/private.h | 10 +++++++ xen/common/sched/rt.c | 58 ++++++++++++++++++++++++++------------ 5 files changed, 94 insertions(+), 18 deletions(-) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 23fa6845a8..43132ff6e0 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -1284,6 +1284,35 @@ static int cpu_disable_scheduler_check(unsigned int cpu) return 0; } +/* + * Called after a cpu has come up again in a suspend/resume cycle. + * Migrate all timers for this cpu (they have been migrated to cpu 0 when the + * cpu was going down). + * Note that only timers related to a physical cpu are migrated, not the ones + * related to a vcpu or domain. + */ +void sched_migrate_timers(unsigned int cpu) +{ + struct sched_resource *sr; + + rcu_read_lock(&sched_res_rculock); + + sr = get_sched_res(cpu); + + /* + * Note that on a system with parked cpus (e.g. smt=0 on Intel cpus) this + * will be called for the parked cpus, too, so the case for no scheduling + * resource being available must be considered. + */ + if ( sr && sr->master_cpu == cpu ) + { + migrate_timer(&sr->s_timer, cpu); + sched_move_timers(sr->scheduler, sr); + } + + rcu_read_unlock(&sched_res_rculock); +} + /* * In general, this must be called with the scheduler lock held, because the * adjust_affinity hook may want to modify the vCPU state. However, when the diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c index b2c6f520c3..bdf6030ab0 100644 --- a/xen/common/sched/cpupool.c +++ b/xen/common/sched/cpupool.c @@ -1035,6 +1035,8 @@ static int cf_check cpu_callback( case CPU_ONLINE: if ( system_state <= SYS_STATE_active ) rc = cpupool_cpu_add(cpu); + else + sched_migrate_timers(cpu); break; case CPU_DOWN_PREPARE: /* Suspend/Resume don't change assignments of cpus to cpupools. */ diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c index 47945c2834..f2cd3d9da3 100644 --- a/xen/common/sched/credit.c +++ b/xen/common/sched/credit.c @@ -614,6 +614,18 @@ init_pdata(struct csched_private *prv, struct csched_pcpu *spc, int cpu) spc->nr_runnable = 0; } +static void cf_check +csched_move_timers(const struct scheduler *ops, struct sched_resource *sr) +{ + struct csched_private *prv = CSCHED_PRIV(ops); + struct csched_pcpu *spc = sr->sched_priv; + + if ( sr->master_cpu == prv->master ) + migrate_timer(&prv->master_ticker, prv->master); + + migrate_timer(&spc->ticker, sr->master_cpu); +} + /* Change the scheduler of cpu to us (Credit). */ static spinlock_t *cf_check csched_switch_sched(struct scheduler *new_ops, unsigned int cpu, @@ -2264,6 +2276,7 @@ static const struct scheduler sched_credit_def = { .switch_sched = csched_switch_sched, .alloc_domdata = csched_alloc_domdata, .free_domdata = csched_free_domdata, + .move_timers = csched_move_timers, }; REGISTER_SCHEDULER(sched_credit_def); diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h index 0126a4bb9e..0527a8c70d 100644 --- a/xen/common/sched/private.h +++ b/xen/common/sched/private.h @@ -331,6 +331,8 @@ struct scheduler { struct xen_sysctl_scheduler_op *); void (*dump_settings) (const struct scheduler *); void (*dump_cpu_state) (const struct scheduler *, int); + void (*move_timers) (const struct scheduler *, + struct sched_resource *); }; static inline int sched_init(struct scheduler *s) @@ -485,6 +487,13 @@ static inline int sched_adjust_cpupool(const struct scheduler *s, return s->adjust_global ? s->adjust_global(s, op) : 0; } +static inline void sched_move_timers(const struct scheduler *s, + struct sched_resource *sr) +{ + if ( s->move_timers ) + s->move_timers(s, sr); +} + static inline void sched_unit_pause_nosync(const struct sched_unit *unit) { struct vcpu *v; @@ -622,6 +631,7 @@ struct cpu_rm_data *alloc_cpu_rm_data(unsigned int cpu, bool aff_alloc); void free_cpu_rm_data(struct cpu_rm_data *mem, unsigned int cpu); int schedule_cpu_rm(unsigned int cpu, struct cpu_rm_data *mem); int sched_move_domain(struct domain *d, struct cpupool *c); +void sched_migrate_timers(unsigned int cpu); struct cpupool *cpupool_get_by_id(unsigned int poolid); void cpupool_put(struct cpupool *pool); int cpupool_add_domain(struct domain *d, unsigned int poolid); diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c index 1f8d074884..d443cd5831 100644 --- a/xen/common/sched/rt.c +++ b/xen/common/sched/rt.c @@ -750,6 +750,27 @@ rt_switch_sched(struct scheduler *new_ops, unsigned int cpu, return &prv->lock; } +static void move_repl_timer(struct rt_private *prv, unsigned int old_cpu) +{ + cpumask_t *online = get_sched_res(old_cpu)->cpupool->res_valid; + unsigned int new_cpu = cpumask_cycle(old_cpu, online); + + /* + * Make sure the timer run on one of the cpus that are still available + * to this scheduler. If there aren't any left, it means it's the time + * to just kill it. + */ + if ( new_cpu >= nr_cpu_ids ) + { + kill_timer(&prv->repl_timer); + dprintk(XENLOG_DEBUG, "RTDS: timer killed on cpu %d\n", old_cpu); + } + else + { + migrate_timer(&prv->repl_timer, new_cpu); + } +} + static void cf_check rt_deinit_pdata(const struct scheduler *ops, void *pcpu, int cpu) { @@ -759,25 +780,25 @@ rt_deinit_pdata(const struct scheduler *ops, void *pcpu, int cpu) spin_lock_irqsave(&prv->lock, flags); if ( prv->repl_timer.cpu == cpu ) - { - cpumask_t *online = get_sched_res(cpu)->cpupool->res_valid; - unsigned int new_cpu = cpumask_cycle(cpu, online); + move_repl_timer(prv, cpu); - /* - * Make sure the timer run on one of the cpus that are still available - * to this scheduler. If there aren't any left, it means it's the time - * to just kill it. - */ - if ( new_cpu >= nr_cpu_ids ) - { - kill_timer(&prv->repl_timer); - dprintk(XENLOG_DEBUG, "RTDS: timer killed on cpu %d\n", cpu); - } - else - { - migrate_timer(&prv->repl_timer, new_cpu); - } - } + spin_unlock_irqrestore(&prv->lock, flags); +} + +static void cf_check +rt_move_timers(const struct scheduler *ops, struct sched_resource *sr) +{ + unsigned long flags; + struct rt_private *prv = rt_priv(ops); + unsigned int old_cpu; + + spin_lock_irqsave(&prv->lock, flags); + + old_cpu = prv->repl_timer.cpu; + if ( prv->repl_timer.status != TIMER_STATUS_invalid && + prv->repl_timer.status != TIMER_STATUS_killed && + !cpumask_test_cpu(old_cpu, sr->cpupool->res_valid) ) + move_repl_timer(prv, old_cpu); spin_unlock_irqrestore(&prv->lock, flags); } @@ -1561,6 +1582,7 @@ static const struct scheduler sched_rtds_def = { .sleep = rt_unit_sleep, .wake = rt_unit_wake, .context_saved = rt_context_saved, + .move_timers = rt_move_timers, }; REGISTER_SCHEDULER(sched_rtds_def); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Nov 02 15:14:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 15:14:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435976.689953 (Exim 4.92) (envelope-from ) id 1oqFRs-00025A-81; Wed, 02 Nov 2022 15:14:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435976.689953; Wed, 02 Nov 2022 15:14:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqFRs-000253-54; Wed, 02 Nov 2022 15:14:36 +0000 Received: by outflank-mailman (input) for mailman id 435976; Wed, 02 Nov 2022 15:14:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqFRq-00024w-Jh for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 15:14:34 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0cf5b643-5ac1-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 16:14:32 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cf5b643-5ac1-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667402072; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Td5ryp8rA6pquA5v2pG6pPMTZhXTU6pX6MSes+dwgM4=; b=eTKPmm0hD/g7pWg344BGfraZ6Bid2ElKWSVYcRQp7u49fREVSuAIdCj9 fD8soco4//flCRMBMWcaCn/V2h4QgB8tdYuACQO5azSxWf1hCa5GK379/ 6+MuH24RBGu4fDJjHEozephZbEfjyIP4x4GNiO4/BulnNDX+2LGALEzRe 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 84017866 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:+rEuCKk97edUIXUCTa10PJTo5gxMJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJMXTuGaPzZYGamedB1aY+28h9V7ZPcmIM1QQA/ry03HyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7amaVA8w5ARkP6kS5AWGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 fIHBDYmSDPTvMGz8rmqWq58i+gJAMa+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsfYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9zhrA/ z2WoTqR7hcyFZ+HyzqK3E2Q3OqQuyLEW7hJDZayz6s/6LGU7jNKU0BHPbehmtG7l0q/VtR3O 0ESvC00osAa9kamU938VB2Qu2Ofs1gXXN84O/I+wBGAzOzT+QnxLnMfUjdLZdgitck3bT8nz FmEm5XuHzMHmK2YTzeR+6mZqRu2ODMJNikSaCkcVwwH7tL/5oYpgXrnbttlCr/zsdTzFhn52 TXMpy8774j/luZSif/9pwqexWvx+N6ZFWbZ+zk7QEqr8S9/T6iGN7eL7GrQ/OYHPIu1ZHWO6 S1sd9el0MgCCpSElSqoSeoLHa206/vtDAAwkWKDDLF6qW3zpifLkZR4pWgneRw3appslSrBO he7hO9H2HNE0JJGh4dTapn5NcklxLOI+T/NBqGNNYomjnScmWa6EMBSiay4hT6FfKsEy/tX1 XKnnSGEVC9yNEif5GDqL9rxKJdyrszE+UvdRIrg0zOs2qeEaXieRN8taQXQMbtjs/zc8VSMr 76z0vdmLD0GDoXDjtT/q9ZPfTjm01BmbXwJlyCnXrHaeVc3cI3QI/TQ3akga+RYc1d9z4/1E oWGchYBkDLCaYjvc1rihoZLNOyyBv6SbBsTYUQRALpf8yN5O9fwsPZPLspfkHtO3LUL8MOYh sItI62oasmjgBydk9jBRfERdLBfSSk= IronPort-HdrOrdr: A9a23:2TGFI64IpzzwS0cRoQPXwM7XdLJyesId70hD6qhwISY6TiW9rb HLoB19726StN9xYgBEpTnuAsS9qB/nmaKdpLNhW4tKPzOW2ldATrsD0WKK+VSJcEfDH6xmpM RdmsBFeaTN5DNB7PoSjjPWL+od X-IronPort-AV: E=Sophos;i="5.95,234,1661832000"; d="scan'208";a="84017866" Date: Wed, 2 Nov 2022 15:14:26 +0000 From: Anthony PERARD To: Andrew Cooper CC: "xen-devel@lists.xenproject.org" , Henry Wang , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH for-4.17 2/4] tools/include/xen-foreign: Capture licences from the input headers Message-ID: References: <20221102112854.49020-1-anthony.perard@citrix.com> <20221102112854.49020-3-anthony.perard@citrix.com> <822f8cb3-6f13-d729-9779-0aeceda46272@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <822f8cb3-6f13-d729-9779-0aeceda46272@citrix.com> On Wed, Nov 02, 2022 at 12:24:21PM +0000, Andrew Cooper wrote: > On 02/11/2022 11:28, Anthony PERARD wrote: > > Notes: > > Maybe instead of this, we should just stamp this on the generated header > > /* SPDX-License-Identifier: MIT */ > > > > but we would be missing the "Copyright" informations. I guess we could > > look for those line with Copyright and copy them. > > > > Or, we could replace the licence in the input header by a SPDX and have > > the script parse that. (Probably still need to grab the Copyright lines) > > All public headers (except one :-( ) are MIT. > > We should SPDX the lot, not least because that removes all the > guestimation from this script; we can require that the SPDX line is the > first line, and sanity check it as we process it. Yes, but I'm not sure I want to do the SPDX change when the tree is supposed to be frozen. > The headers also ought to say "automatically generated from $OTHER", and > include no other information. That's now most autogen headers work. > > So the generated files ought to end up looking like: > > /* SPDX-License-Identifier: MIT */ > /* Automatically generated from $FILE */ So the headers already have: /* * public xen defines and struct for arm32 * generated by mkheader.py -- DO NOT EDIT */ So we just miss the source files used as input by mkheader.py. I can fix that. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Nov 02 15:26:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 15:26:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435981.689964 (Exim 4.92) (envelope-from ) id 1oqFdc-0004IL-B1; Wed, 02 Nov 2022 15:26:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435981.689964; Wed, 02 Nov 2022 15:26:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqFdc-0004IE-6v; Wed, 02 Nov 2022 15:26:44 +0000 Received: by outflank-mailman (input) for mailman id 435981; Wed, 02 Nov 2022 15:26:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqFda-0004I8-M6 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 15:26:42 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be757f72-5ac2-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 16:26:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be757f72-5ac2-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667402799; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=H963iADFFHE0RAKLVSkRhg3KPlfTRTn86dkD/1P0sEk=; b=K7g02+QpuDt3Mf+RH4QwVCvzBTEyWqktU9SHOvaaEBBl12DiQZIfpEky kU5Mm1ykV3ZD0An1CLCA040UJVDNN+h/Vl19+h3b0YxIDCvboq3/Jr6mx DydIPFz0MRQ5VQoXC49hn67raKBvxAtYEr4WLTSqWGM7Nob2kmHseKpHa Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 84019006 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:46Yz8q7IXuSuPeivfcGzLgxRtPXHchMFZxGqfqrLsTDasY5as4F+v mdMW2/QbqmMNmHwKdp2b46180kH6MfVxtEyGVFqq3o1Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKkT5geE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m0 sMHNjEBaCG6pqGJ4+24b+Vigp4lBZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJU0UUrsUIMtWcOOAj3/jczpeuRSNqLA++WT7xw1tyrn9dtHSf7RmQO0Fwh7B9 zqeoQwVBDlKa/2WkjCPyUi9xf7mhDLgeaw0Oeeno6sCbFq7mTVIVUx+uUGAieKilke0VtZbK koV0ikjt64/8AqsVNaVdx+lpH+JuDYMVtwWFPc1gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaEQgYK3UTIxANSwQt6sPm5oo0i3rnTNxuDaq0hd3dAizrz naBqy1WulkIpZdVjePhpwmB2m/y4MiSJuIo2unJdkWa8R14aIiUXq3r1nuE7tNMIoLDSHDU6 RDohPOixOwJCJiMkgmET+MMAKyl6p65DdHMvbJ8N8J/rmrwohZPaagVuWgjfxkxbq7obBezO CfuVRVtCIi/1ZdARYt+eMqPBssj1sAM/vy1B6mPPrKijnWcHTJrHR2Ch2bKgQgBc2B2y8nT3 Kt3lu71VB4n5VxPlmbeegvk+eZDKtoC7W3SX4vn6B+szKCTYnWYIZ9cbgXRNbpms/vV8VyJm zq6Cydt40wBONASnwGNqdJDRbz0BSVT6W/KRzx/KbfYf1sO9JAJAP7N27IxE7GJbIwM/tokC kqVAxYAoGcTcFWddm1mnFg/N+60NXu+xFpnVRER0aGAgCJ5MNnzvfdGJvPav9APrYRe8BK9d NFdE+3oPxiFYm6vF+g1BXUlkLFfSQ== IronPort-HdrOrdr: A9a23:CigtYqsBxUAabURrVxwX05zC7skDdtV00zEX/kB9WHVpmszxra 6TddAgpHvJYVcqKRQdcL+7VZVoLUmxyXcx2/h3AV7AZniFhILLFuFfBOLZqlWKcREWtNQttp uIG5IObuEYZmIasS+V2maFL+o= X-IronPort-AV: E=Sophos;i="5.95,234,1661832000"; d="scan'208";a="84019006" Date: Wed, 2 Nov 2022 15:26:33 +0000 From: Anthony PERARD To: Jan Beulich CC: Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Subject: Re: [XEN PATCH for-4.17 1/4] xen: Add licence information to public/errno.h Message-ID: References: <20221102112854.49020-1-anthony.perard@citrix.com> <20221102112854.49020-2-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Wed, Nov 02, 2022 at 01:58:11PM +0100, Jan Beulich wrote: > On 02.11.2022 12:28, Anthony PERARD wrote: > > Fixes: 81f559e97974 ("make error codes a formal part of the ABI") > > Reported-by: Andrew Cooper > > Signed-off-by: Anthony PERARD > > --- > > xen/include/public/errno.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/xen/include/public/errno.h b/xen/include/public/errno.h > > index 5c53af6af9..6bdc8c5079 100644 > > --- a/xen/include/public/errno.h > > +++ b/xen/include/public/errno.h > > @@ -1,3 +1,5 @@ > > +/* SPDX-License-Identifier: MIT */ > > + > > /* > > * There are two expected ways of including this header. > > * > > Doesn't this require at least part of Stefano's "[PATCH v4 0/4] introduce > SPDX" as a prereq? I notice quite a few files already use leading SPDX > comments, but perhaps wrongly so without it being explained anywhere in > tree what this is about? I don't think Stefano's work is required or needed, beside pointing out that new file should use SPDX, and providing guidelines. It seems that using the SPDX identifier in a project without explanation is enough. It could be seen as a useless comment if not understood (but useful for some tools) and in this case the COPYING files (in our case) would tell the licence been used. But, if used, "SPDX-License-Identifier: MIT" have a very specific meaning, it means that the licence used in question is https://spdx.org/licenses/MIT.html, and Stefano's work shouldn't change that meaning. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Nov 02 15:39:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 15:39:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435986.689975 (Exim 4.92) (envelope-from ) id 1oqFpY-00067c-Bm; Wed, 02 Nov 2022 15:39:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435986.689975; Wed, 02 Nov 2022 15:39:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqFpY-00067V-8w; Wed, 02 Nov 2022 15:39:04 +0000 Received: by outflank-mailman (input) for mailman id 435986; Wed, 02 Nov 2022 15:39:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqFpW-00067P-Oj for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 15:39:02 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 77d2c749-5ac4-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 16:39:00 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77d2c749-5ac4-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667403540; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RGEEqNl9smxBROa5nfaheIgphZedWkrD7OyQg4TiCwE=; b=UDZRPMbssdVtEJcGBsI7hl2DToL41ulmIVI9RQA6RgpTaBUSxPaaAaCF jufnjZnUfv9M0nZiFBrVm7f7IsYDuspKY/jx3aprdNuO7u8g93agcU/D4 QvclIT2br8i0fGUbBER5V6JsYkS3/Rb1T1XSukSRFAWucOGV93FubK8jn I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 83111231 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:+JW3kqJffrxza5XiFE+RHJUlxSXFcZb7ZxGr2PjKsXjdYENS0DYAn GpNWGCCOK6NZjSmfdtxOoq1/EhQ7JSDnddhTFRlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5wRkPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5WGEZE/ 6YWEAkHNAyniPqbmpO+T8Jj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUozRHJwMxB3Bz o7A13nVUhpGGNW69SCA0Sjwp8GMvw3DVY1HQdVU8dY12QbOlwT/EiY+TkCnqPO0jkq/XdN3K EEO/Ccq668o+ySDUd3VTxC+5nmesXY0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv neLld70AT1ksJWOVGmQsLyTqFuaGSUTN35EWiYCQiMM+dylq4Y25jrNU9JiHaidntDzXzbqz Fi3QDMW3utJy5RRjuPioA6B02nESoX1ohAdxxzwVGj/4DtAbtS5Q4OwxAL66PNrI9PMJrWeh 0Qsl8+b5eEIKJiCki2RXekAdI2UC+a53C702gA2QcR4n9i50zv6JN0LvmkiTKt8GpxcEQIFd nM/ru+4CHV7GHKxJZF6bIuqYyjB5fixTI+1Phw4gzcnX3SQSONl1HswDaJz9zq3+KTJrU3YE c7CGftA9V5AVcxaIMOeHo/xK4MDyCEk3n/0Tpvm1Rmh2rf2TCfLF+heagTRNrFotf/sTODpH zF3bpXi9vmieLemPnm/HXA7cDjm0kTX9bip8pcKJ4Zv0yJtGX07Cu+5/F/SU9UNokihrc+Rp ynVZ6Ot4ACg7ZExAVnVNysLhXKGdcoXkE/XygR3Zwz5hCRyMd/+hErdHrNuFYQaGCVY5aYcZ 5E4lw+oWZyjlhyvF+whUKTA IronPort-HdrOrdr: A9a23:XIic2KikCIeD3kDh+09O+XBIQnBQXtgji2hC6mlwRA09TySZ// rOoB0+726StN9xYgBFpTnuAsW9qB/nmqKdpLNhW4tKPzOW3VdATrsSjrcKqgeIc0aVm9K1l5 0QEZSWYOeAdGSS5vyb3ODXKbgd/OU= X-IronPort-AV: E=Sophos;i="5.95,234,1661832000"; d="scan'208";a="83111231" Date: Wed, 2 Nov 2022 15:38:38 +0000 From: Anthony PERARD To: Jan Beulich CC: Henry Wang , Andrew Cooper , George Dunlap , "Julien Grall" , Stefano Stabellini , Wei Liu , Subject: Re: [XEN PATCH for-4.17 4/4] Rework COPYING installed in /usr/include/xen/, due to several licences Message-ID: References: <20221102112854.49020-1-anthony.perard@citrix.com> <20221102112854.49020-5-anthony.perard@citrix.com> <619bb7bb-a60a-5f13-53da-72e1d3a4aaf1@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <619bb7bb-a60a-5f13-53da-72e1d3a4aaf1@suse.com> On Wed, Nov 02, 2022 at 02:09:08PM +0100, Jan Beulich wrote: > On 02.11.2022 12:28, Anthony PERARD wrote: > > --- /dev/null > > +++ b/tools/include/xen/COPYING > > @@ -0,0 +1,26 @@ > > +XEN NOTICE > > +========== > > + > > +This licence applies to all files within this subdirectory ("/usr/include/xen") > > +with the exception of "sys/" which may include an header under public domain or > > +BSD-2 licence. > > Nit: s/an header/headers/ ? And perhaps better to not name the two licenses > here but instead keep this more generic so it wouldn't need changing if a > header with yet another license appeared? I guess I can make the text more generic without to much issue. As long as the exception is for the "sys/" headers, we would probably be fine. New change would be: +with the exception of "sys/" which may include headers under different +licences. > > +===================================================================== > > + > > +Permission is hereby granted, free of charge, to any person obtaining a copy > > +of this software and associated documentation files (the "Software"), to > > +deal in the Software without restriction, including without limitation the > > I understand you've simply copied this from ./COPYING, but shouldn't it be > "limitation of" or "limiting"? The text match the text at https://spdx.org/licenses/MIT.html, so I'm not going to change it. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Nov 02 15:57:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 15:57:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435991.689986 (Exim 4.92) (envelope-from ) id 1oqG7h-0000mL-Tr; Wed, 02 Nov 2022 15:57:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435991.689986; Wed, 02 Nov 2022 15:57:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqG7h-0000mE-R9; Wed, 02 Nov 2022 15:57:49 +0000 Received: by outflank-mailman (input) for mailman id 435991; Wed, 02 Nov 2022 15:57:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqG7g-0000m8-Kp for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 15:57:48 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 178c6138-5ac7-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 16:57:47 +0100 (CET) Received: from mail-bn8nam12lp2174.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Nov 2022 11:57:44 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5340.namprd03.prod.outlook.com (2603:10b6:5:24d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Wed, 2 Nov 2022 15:57:41 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 15:57:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 178c6138-5ac7-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667404667; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=7MKrfU+TfDZRRvp/RX8s8mz2mvqkzu6dKND9Aya/as0=; b=Kyne4kAzy3/+fsUWwmE7ss3JAOb4GeFpgaZpBMFjCEQCok8QABG4zJ6p 1QRk+56aZXeMpwA5mJ8SJ/4yjqEpu5PPoLJqBiKkE8xQTUr88nsjZ1P0a AOjMsoNx1B4fmAQxO/JLxvtBjd4oiXJDhxr/EPc1hGMoMteLST5lf6F7f k=; X-IronPort-RemoteIP: 104.47.55.174 X-IronPort-MID: 84042200 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:vri6+6+wN1RKiY7SHrSlDrUDZn+TJUtcMsCJ2f8bNWPcYEJGY0x3m mAXXT+Ha62Dazf9KdkiYIu1805VsZDQnNRnG1A++X88E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPKgR5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklk5 +RIDWwkYim6mrvm3Yz4dvh3oM8KeZyD0IM34hmMzBn/JNN/G9XpZfWP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUujNABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCN5KSOfirqYCbFu7z0UDESYIeFaBuKe8pmWQBctbJ hctw397xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnO87QyY7k GCAmdzBDCZq9raSTBq19L2ZsDezMig9NnIZaGkPSg5ty9v+pIA+iDrfQ9AlF7S65vXuAi35y T2OqCk4hp0QgNQN2qH9+krI6xqzorDZQwhz4R/YNl9J9St8bY+hIoauuV7S6K8aKJ7DFwbd+ n8Zh8KZ8eYCS4mXkzCAS/kMG7fv4OuZNDrbghhkGJxJGymRxkNPtLt4uFlWTHqF+O5eEdM1S Cc/YT9s2aI= IronPort-HdrOrdr: A9a23:d8lHva4qfA1hgQVvowPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+ O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCcwoSAbza5B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuKYlGchsRLYkjTVoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+ CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5 jFWEMwjx9HR6svM7z64HRmyGG/fIzmZ0Wd9ih33ekIhpTsALz2LCaEVFci18O9vvR3OLyoZ8 qO X-IronPort-AV: E=Sophos;i="5.95,234,1661832000"; d="scan'208";a="84042200" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TvXhTcGt8F77zDSaup5ED+vlUn/NT256DrLBBfu2uxtSh45FJf0juvlR/QNzmZ+rHTf0xJCli2jOZZfQORPn/JiYheXYW2Lhpkr3WwnVrgqjSdRreQtnk37XpBPlUnX2PO60MXR3j89YVNW+P3UnSS7k+WJY1KusObwFrwb+X04EmSeiyAqlT3i7+nOxhi9Mpptgo7hZyj/U6XDOARGcxfYAE3EtejvT4L+saXe4S62fDvVg4TZXoFPro+f7jmZApnu7jnykv3hlMx7Pv3Fc/K+5ezg/ZQXbjVXZMtyXwtZffJDdbVmmxXwa/U2oLpYnJdEUQo51u7oUUaTksMUSTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7MKrfU+TfDZRRvp/RX8s8mz2mvqkzu6dKND9Aya/as0=; b=FcAN/db4lpECOlA+U6NQ1J1hxZpXyUvVZUTPRoff3MLRZtoN+J0wqlOD2QdH9meQZogft8lNBM2uR5HHawbhcaVR9aHkO2XlCxd0rC0DoHFrGqTZ1MkGb/qy85VIJRqPZa/b28lrapTPW413+dQeyfwRJuF2XFp0P9wxrwCfBFysJIvo1CC4Z2jhBcZlxvoiKIAXCjnUPavSBwB55K0qaoTGjsBr38zKFkzzTbzF/xga+mZ7Q/JqOfYQnI3VZJ16jbplQTIr1BzpJ/Kjzqp3YPatF7Y9R2AFKOZo4x7VSw81QqDdRg5Nlx09ACQFqLOq/mApMvC3b89ubzcOoLTDTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7MKrfU+TfDZRRvp/RX8s8mz2mvqkzu6dKND9Aya/as0=; b=cWXvA28fcwnJ+6OhCWvC6ZO3AwOfpO9AotzywC2wbp5v70HToXfE/37VHs9h7FEYkwbRAdgsN/nEIEkhHE+aH3KI61g+vKJTFcP21MPnvqI8pymUNnBdPv/6PHDqtj7URBDggUHbXp22iTa2sSSBdJV63lszxYyxdxMHtjmwdmM= From: Andrew Cooper To: Anthony Perard CC: "xen-devel@lists.xenproject.org" , Henry Wang , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH for-4.17 2/4] tools/include/xen-foreign: Capture licences from the input headers Thread-Topic: [XEN PATCH for-4.17 2/4] tools/include/xen-foreign: Capture licences from the input headers Thread-Index: AQHY7q5XVsL2+RG/AUCiEkMy4e8OGa4rjrQAgAAvhgCAAAwWgA== Date: Wed, 2 Nov 2022 15:57:41 +0000 Message-ID: References: <20221102112854.49020-1-anthony.perard@citrix.com> <20221102112854.49020-3-anthony.perard@citrix.com> <822f8cb3-6f13-d729-9779-0aeceda46272@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM6PR03MB5340:EE_ x-ms-office365-filtering-correlation-id: b8b93234-eee7-4cbb-9cfa-08dabceaf945 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PsL8uDPmPMBcUhbdacSpyOtHNPN71F0HPv7ROKzbsIlNhBD3KqBys7Av42u58vdOl79PqSlS70oJ/d75NdXrVLWVPL6b6/5MC78PkmzrBuyEPZbbAuznElDKLlQg5PkifoRKb6uyXPGLtv6QNjKwVIKJwW8UsnHtCII9heDfQi5Dyhi9FwernzUlnTghxDzloVw9zI7KzqtdZtrAbai7rcnUgmy1QIB5qE7jdkh2oaWe0xprp+f9nSgOAF0bPaRfKxyfEUngM4tYFZ6FMj4iDi9aViG53Je9dF6pPXabvaOHDKL1Dfam27qSlJGkDXQKMEQquTzYmUxSUe5wbpPDy9XJK1/+argo2M+DuwRDOhxHCnH8LP8ak413EVc53i+kT31l5GXlQfhMjtxlTxXmye+28ovkN75E2v2g50HmLnNPAlPR+Eo0q0dRYOxHd6V1lVVGgbI9JHagBgrodQPoqALcqpkgw+N65oIZx103B53De1HeoeW2T8Hhdcr5ucY1ZnJPf2lUIS7rn52czNIqeGDcoqMdeSQoeh8AW/viov5KN6QnS3rcg8Rq11Lu6mYBwtDIwq26pITafUt8ARDphw6B7NKgH1dex8gM8pC/2T/govSSioEyfv3GsUmtw3YbLA76osvHitBvcbGsbCEww61LhlduinHlFAW4ANvADeOsfaHJRmmnzOST4CMR2omK6F0jqK7n9VeZmfGbveWeJEPm6+x7IvA74ibX7WZFnQezqzSJR/6eiYNg7odWwyc2tXFBbLlMcvY2yofsPkUTKQ49VPLOduGiVF6GsGIeFzPEyKzYptVLgPc6sGI3Uevc0wDSsukS6LEVXC4pQl7UoA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(376002)(39860400002)(136003)(396003)(451199015)(2906002)(31686004)(83380400001)(5660300002)(478600001)(8936002)(6862004)(31696002)(86362001)(66446008)(41300700001)(186003)(6506007)(66556008)(66476007)(64756008)(4326008)(2616005)(8676002)(91956017)(76116006)(66946007)(36756003)(38070700005)(54906003)(38100700002)(316002)(6636002)(37006003)(26005)(6512007)(53546011)(71200400001)(122000001)(82960400001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YldFL21sWCswMmxvbWp2SnVlblRQZGJpeGwwMnJxY2VUL0JUZVdwYVRud2JP?= =?utf-8?B?VDhFeCtEZ0VyNG54RWxSS2ZoUWRtWUJ6Z09MMjR2UGluNENSR2FzbEsxN3Ez?= =?utf-8?B?MmVtNzBCbE5BeXIxQWhlRVhEM2ovVzBlc2pYVCt5T1RuUmtGMmV3ejdvdG5W?= =?utf-8?B?NkxnU1hobmpjemNEenVvVnZCcmZ4YjVrZ1RXWVhSVTYxRitVWkdmRUQ2M2tY?= =?utf-8?B?NzRBc2JncHRBRThFdUVIeldKNWp2L3JSSW1XSG1ybUJ5Y1ZtczJUeXoxazBk?= =?utf-8?B?bVFQb3BiS0RrcXkxcCs0ek81MVJxSGUxTSs1d000NzRBZVIxWXc5VkhyWGxK?= =?utf-8?B?cXhteDZnd3dYUWh4SS9FVWdHSHVQaGdTVkZhU3hrMHVQY21UYmVVZXBqTGti?= =?utf-8?B?bS9xR2M0bUI1ZWdCVmpzYmdSZGRvT2xaMWpsdFFGeGZiM2RIWUJvb3lSRlZy?= =?utf-8?B?bDlzU0owUSt2SGw2UjhEb1U3d01OMjNyZXUvUFEwODZKQ2U0MEc1ZU51U0Nl?= =?utf-8?B?UXlFUzRKUktMMVBXSHArclBiUFQvQ3FRTXRqVWdZT3lpdFI0RHNiTVkrbWh2?= =?utf-8?B?MzBCNGgyQW55UnBwMFhKMVJ3eHYvNC95aVF0Zy9SMm1KWm5jVDNBRHhFWHNQ?= =?utf-8?B?N1FBQ0dKbjdJRnNzSG1od29nYUFvT2Q1bGcwM1Q2YURzL2lTa1hKQmQxMGlw?= =?utf-8?B?VUxXb0J3QmFFRE5lVnRnVTNRQkZhaG1sSW5YT1RzeklnRi8zUGI4Zk0yTThP?= =?utf-8?B?NnBrWnpBK05YMjViTjdpSG5JVDB1U044bWlmbFFlUG92QzQzaFpuR2VJVWpy?= =?utf-8?B?b3FYcTdZeGJNV201alY3U1JzTzZoVXRUcmlKbjRUaEpSck5FL1EzbWlWU3ZO?= =?utf-8?B?a1ROcFdoWU9wcHd5L0lVUDRaVG1qVXdJdXo0MVF1OUxrRDMwNmxyZWxQa01o?= =?utf-8?B?dkxiNk1PeGpDUy92MDNzSE0xK2h2bkNsU1dNZGdUbzJaaEs3Vm10ZXRTa3BW?= =?utf-8?B?Z0VpT1VSMnhPVDdzV0YwSSt6WE9RdHIwbHU1ejkvVFpjV0hOUEV4NUhmMm5U?= =?utf-8?B?Z0ZmOTZSaTNRci81NWxlWjJENVNSdDgyajFiY2dLZkg0NXRJYWNGWGs3M1J4?= =?utf-8?B?ckU5b1lYMm1VbWw2eU1EWlZIK0l5dzJ0WU9hVVFGYWlLQmhkOEI4UDRlUU1P?= =?utf-8?B?Z0NQZ1Y4Zk8zakdXYUxqWDNMTHQrdlIvL1JnWVhnRmszYzdjbVRVRUVVcE15?= =?utf-8?B?REczaHVjSlBNQmxsL0NhcTFKV3JNdkRnRmcvdlBzU3IvOEtVOG1jWDJlTUM4?= =?utf-8?B?UVU4ekZ5ZmdBbU9WYVdFNkw4aEoweTRxZVpzczkzMStSSHVldGFSV01DUHJD?= =?utf-8?B?YnhqZGdLbTBNb21DTno4SnVSQThBU3NIUUNSVytxSlpIM1c4VXJRNWlaaUxO?= =?utf-8?B?Q0Q0ek85SkFVWkFiOWhsdXZVWVJkbGJ6SDhCbk9rN0hEdnhLK2UySWdyUkw5?= =?utf-8?B?Mi9Gd2JkK3JKVGMwbU5nYlZiUEJKeVh4MFlPWE5sTmYrSlVZUjIycFRBRDV1?= =?utf-8?B?WFJGRlJ2LzRGZGlTYXNEMjhJc2F3UFg1RFJCL0xKOGQrdWtyMUtFZWQyK3RI?= =?utf-8?B?Q3RtQ3dkRm40dnF0N09zM0RKNGpRbzV1TVJCNDlQWlpzYlI0N3VoRmRJS1Bp?= =?utf-8?B?V01hSHordXVMQjQ5MHdjaEJaTHZPQ29MZWs2K2RldklaK2F4SkhrZk1kU2Jt?= =?utf-8?B?VnJvRHBtTGtCVU5BQjNWSU9HeHpEaVFXTzZNMlRwWmpsQlRXSC9pWWhyTUxL?= =?utf-8?B?dWtad2VWQ3Ayd3BBUjd5eW5BUURKWjlyNzJNbCt6Zk4va1J6WEZTTkNVTVY5?= =?utf-8?B?TlY3TnNrK01KejZHTXkyVlAyUDZnZTVqTmtmMGRpSWZMTXRCY2xyR3ovU3FB?= =?utf-8?B?YzhsUXpBaSt0VFNzR3VZYzFIUnZZY2FQOUdDajM2dmltbzVoUC9pd1Z3cXZx?= =?utf-8?B?SzRBekpOOTgrQUh3S0JteS8vNzdGZ0pIWkp5ZGlSdHorRjQ3bVpDOWFwSWxI?= =?utf-8?B?K3NhaldsOFQ2Sy92Q1BYUjBpZG9wMkN1Z05ieThSM2loNmZESlBZZ2NtWWl0?= =?utf-8?Q?gsNa+DjxYn5/xwTYwQFJ10uYa?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8b93234-eee7-4cbb-9cfa-08dabceaf945 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 15:57:41.6335 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DUV+35fL/aiFZiP1OnCM+GB3vc2+oETkuE6qRWsJm9eX+Se/G670mosRBgyRuPUWZdb6AY0qNWwDe0aRfjhPNi21HizMBEGXSzFPzXw1Fyo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5340 T24gMDIvMTEvMjAyMiAxNToxNCwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IE9uIFdlZCwgTm92 IDAyLCAyMDIyIGF0IDEyOjI0OjIxUE0gKzAwMDAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBP biAwMi8xMS8yMDIyIDExOjI4LCBBbnRob255IFBFUkFSRCB3cm90ZToNCj4+PiBOb3RlczoNCj4+ PiAgICAgTWF5YmUgaW5zdGVhZCBvZiB0aGlzLCB3ZSBzaG91bGQganVzdCBzdGFtcCB0aGlzIG9u IHRoZSBnZW5lcmF0ZWQgaGVhZGVyDQo+Pj4gICAgICAgICAvKiBTUERYLUxpY2Vuc2UtSWRlbnRp ZmllcjogTUlUICovDQo+Pj4gICAgIA0KPj4+ICAgICBidXQgd2Ugd291bGQgYmUgbWlzc2luZyB0 aGUgIkNvcHlyaWdodCIgaW5mb3JtYXRpb25zLiBJIGd1ZXNzIHdlIGNvdWxkDQo+Pj4gICAgIGxv b2sgZm9yIHRob3NlIGxpbmUgd2l0aCBDb3B5cmlnaHQgYW5kIGNvcHkgdGhlbS4NCj4+PiAgICAg DQo+Pj4gICAgIE9yLCB3ZSBjb3VsZCByZXBsYWNlIHRoZSBsaWNlbmNlIGluIHRoZSBpbnB1dCBo ZWFkZXIgYnkgYSBTUERYIGFuZCBoYXZlDQo+Pj4gICAgIHRoZSBzY3JpcHQgcGFyc2UgdGhhdC4g KFByb2JhYmx5IHN0aWxsIG5lZWQgdG8gZ3JhYiB0aGUgQ29weXJpZ2h0IGxpbmVzKQ0KPj4gQWxs IHB1YmxpYyBoZWFkZXJzIChleGNlcHQgb25lIDotKCApIGFyZSBNSVQuDQo+Pg0KPj4gV2Ugc2hv dWxkIFNQRFggdGhlIGxvdCwgbm90IGxlYXN0IGJlY2F1c2UgdGhhdCByZW1vdmVzIGFsbCB0aGUN Cj4+IGd1ZXN0aW1hdGlvbiBmcm9tIHRoaXMgc2NyaXB0OyB3ZSBjYW4gcmVxdWlyZSB0aGF0IHRo ZSBTUERYIGxpbmUgaXMgdGhlDQo+PiBmaXJzdCBsaW5lLCBhbmQgc2FuaXR5IGNoZWNrIGl0IGFz IHdlIHByb2Nlc3MgaXQuDQo+IFllcywgYnV0IEknbSBub3Qgc3VyZSBJIHdhbnQgdG8gZG8gdGhl IFNQRFggY2hhbmdlIHdoZW4gdGhlIHRyZWUgaXMNCj4gc3VwcG9zZWQgdG8gYmUgZnJvemVuLg0K DQpUaGUgbGljZW5zaW5nIGNvcnJlY3Rpb25zIGFyZSBhIHJlbGVhc2UgYmxvY2tlci4NCg0KVGhl IGZyb3plbm5lc3Mgb2YgdGhlIHRyZWUgaGFzIG5vIGJlYXJpbmcgb24gdGhlIGFjY2VwdGFibGVu ZXNzIG9mIHRoZQ0KZml4LsKgIEVzcGVjaWFsbHkgd2hlbiBhbGwgd2UncmUgdGFsa2luZyBhYm91 dCBpcyBhZGp1c3RtZW50IG9mIHNvbWUNCihsZWdhbGx5LXJlbGV2YW50KSBjb21tZW50cy4NCg0K SW4gdGhpcyBjYXNlLCBzd2l0Y2hpbmcgdG8gYSBtb3JlIG1hY2hpbmUtcGFyc2FibGUgZm9ybSwg aW4gb3JkZXIgdG8gZ2V0DQp0aGUgYXV0b2dlbmVyYXRpb24gY29ycmVjdCwgaXMgSU1PIGZ1bGx5 IGFjY2VwdGFibGUgZXZlbiBhdCB0aGlzIHBvaW50DQppbiB0aGUgcmVsZWFzZS4NCg0KfkFuZHJl dw0K From xen-devel-bounces@lists.xenproject.org Wed Nov 02 16:00:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 16:00:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.435996.689997 (Exim 4.92) (envelope-from ) id 1oqGAD-0002dr-Gm; Wed, 02 Nov 2022 16:00:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 435996.689997; Wed, 02 Nov 2022 16:00:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqGAD-0002dk-CT; Wed, 02 Nov 2022 16:00:25 +0000 Received: by outflank-mailman (input) for mailman id 435996; Wed, 02 Nov 2022 16:00:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqGAB-0002da-WA; Wed, 02 Nov 2022 16:00:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqGAB-0005Kw-Rz; Wed, 02 Nov 2022 16:00:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqGAB-0004Ae-Fs; Wed, 02 Nov 2022 16:00:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqGAB-0000NH-F5; Wed, 02 Nov 2022 16:00:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XHAgGQ0hiKYXzCnAQBqmtFTeSlNjExQUQcQkZqvm+W4=; b=XN8aKMbwKeTU0/gtEpqcWSZT5D UMGVfNeQcDGdnlNvRr9oCnt4oJU7m3vZhebWN4HniaslJTlUsFgIigSkEs8Vh4UKxAcRT2EZyO2T6 G0G4aHwA7U9K3qdc7SLgXuovc7VVVtS+TTCiKNPPKugTHeZ+Svl3NT1WVklOwklnlyx8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174585: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0751a75e3996cf6efd3925a90b4776660d8df2bc X-Osstest-Versions-That: xen=2dd823ca7237e7fb90c890642d6a3b357a26fcff From: osstest service owner Date: Wed, 02 Nov 2022 16:00:23 +0000 flight 174585 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174585/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass version targeted for testing: xen 0751a75e3996cf6efd3925a90b4776660d8df2bc baseline version: xen 2dd823ca7237e7fb90c890642d6a3b357a26fcff Last test of basis 174567 2022-11-01 14:00:28 Z 1 days Testing same since 174585 2022-11-02 12:02:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Juergen Gross Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2dd823ca72..0751a75e39 0751a75e3996cf6efd3925a90b4776660d8df2bc -> smoke From xen-devel-bounces@lists.xenproject.org Wed Nov 02 16:37:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 16:37:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436004.690008 (Exim 4.92) (envelope-from ) id 1oqGjq-0007aA-4u; Wed, 02 Nov 2022 16:37:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436004.690008; Wed, 02 Nov 2022 16:37:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqGjq-0007a3-1u; Wed, 02 Nov 2022 16:37:14 +0000 Received: by outflank-mailman (input) for mailman id 436004; Wed, 02 Nov 2022 16:37:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqGjp-0007Zx-83 for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 16:37:13 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 978a2557-5acc-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 17:37:09 +0100 (CET) Received: from mail-mw2nam10lp2104.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Nov 2022 12:37:06 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6204.namprd03.prod.outlook.com (2603:10b6:408:101::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 16:37:04 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 16:37:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 978a2557-5acc-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667407030; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=HHxh1qINTtfLJ6s66FFQtwwgBK4yFteoIgOu0z7vcyE=; b=emWsXVjX0SS6p2efTvmBqDHw260cHMvlkCNbN1h8Qjy730kNNfrxxKDJ Zolm1eGGP+VQiJHTqFOe2imDeFLMV71tJkycFByWdbN/buXIz+S6Ykvie tpJeTP1QIIo+sTe9UBb30hdzUNp9m4tK/B4R5kKyTFAt9cSvliCLXJ8HA 4=; X-IronPort-RemoteIP: 104.47.55.104 X-IronPort-MID: 84046484 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jjP2YqnGfz/0IeZFxYX0yrjo5gxnJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJJXmrUOqrcY2LxLtoiPIS19EgOvZbVm9c2TQtrr3o1HyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7amaVA8w5ARkP6kS5AWGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 dg5cD4tay6qvLno27Pmd9FPvd5/PvC+aevzulk4pd3YJdAPZMmbBoD1v5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3ieCxWDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapCSOXkqKI63DV/wEQ5DUQNZXnkgMKnsUSfRex7N mIsxwwX+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy65C24eX3h+YdopnMYsQHoh0 Vrht9H0AT1itpWFRHTb8a2bxRupIjQcJ2IGYS4CTCMG7sPlrYV1iQjAJv58FIalg9uzHiv/q xiaoS57i7gNgMoj06Sg4UuBkz+qvoLOTAM++kPQRG3N0+9iTIusZojt7EeB6/9Fdd6dVgPY5 CRCnNWC5ucTC53LjDaKXOgGALCu4bCCLSHYhllsWZIm8lxB5kKeQGyZ2xkmTG8BDyrOUWKBj JP70e+J2KJuAQ== IronPort-HdrOrdr: A9a23:POiftqtC1kNgFaTCo0H40Scm7skC1YMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIP/Z4StU z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfpWG0hYczAgNkGmpDr1L8Yqq iJn/7mBbU115rlRBD2nfIq4Xin7N9h0Q669bbSuwqfnSWwfkNHNyMGv/MWTvKR0TtfgDk3up g7oF6xpt5ZCwjNkz/64MWNXxZ2llCsqX5niuILiWdDOLFuIYO5gLZvi3+9Kq1wah7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm10xR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XXJ0vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLmzNV1wg2XwqUmGLEfQI5tllulEU5XHNcrWGDzGTkwymM29pPhaCtHHWp +ISeBrP8M= X-IronPort-AV: E=Sophos;i="5.95,234,1661832000"; d="scan'208";a="84046484" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zy5/GEh85eybDI9QnNYNUmlIePhJ3QwLbc5J3VVrej29o3QEsjQMwMMZure1BRRQCgYoX2oAMYZpv3f/BurOXMW560Sn9BHzVLa2/LrECYaY39EOxZHEiKVZAHQXUCWUpzzI84wxpGtcp9/uwb6dqH4lEJFInnNevOtfjdGs5FzXFXD9gNVE2MzDdjKSKdadR0CCsGM8yLftfv9Nt0KwRiww8Iah7k++Xagsg3q6CjO+oNr7YhqwKX3C2Ieke+/riqEd9RfzwtciadMa6jbCIqOTh6qDar6ZissMp8g+1qxW2uEckNWejJY4CRaS2Lb7Mf4K1tbit584R3LP4sJHyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HHxh1qINTtfLJ6s66FFQtwwgBK4yFteoIgOu0z7vcyE=; b=HyDfASdQtVkt7lHx/XA6yZmQ/BBSkyiVpE5W/Wm3M4423aymE3/6JwunYW35LMuuFPnJoAPEqeZzDhS7bZmQtkFoFlvi1wNb7ZrTjc1egQigCGQcsQbQtV7oILiDCjfisyTvolvt4qQxOLhEqDMn2M5c4GoYRa7dcTgZAEBTpdOHdqsVn5LDkgOwiAfa1mV8E9g6LzVhVsUPR+lJmjjmD9jetEZD3Agc8EstfYT0E8qUTupDZ9IPSRNa+Mo57T1hvPkR/yVXJhsSSQQ0CEZ54i8fkrFI1c9dv+Ux6279L4792UqmtViOdnww+3nVp7lt4djOkJm/LKlKr1OSWYZ8qQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HHxh1qINTtfLJ6s66FFQtwwgBK4yFteoIgOu0z7vcyE=; b=oJ1VjrwO9CpMu2pLQwIzBwCjjp51Pk73lVcNY9CbxMhdjlWZVuY2KzpyD5sad3VcjytaP1FwlWhBrUdGe60p/lVRKISsuE4zGfZQXw/V7GWOaTlhUcLOlmXViKNlReL9+e1ORLDrcmjMn/9PWKH8vdEc/aZKc6QevaSE2YP0pG8= From: Andrew Cooper To: Jan Beulich , Anthony Perard CC: Henry Wang , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [XEN PATCH for-4.17 1/4] xen: Add licence information to public/errno.h Thread-Topic: [XEN PATCH for-4.17 1/4] xen: Add licence information to public/errno.h Thread-Index: AQHY7q5SGNNHOrsJDECKUEgTCIsdLq4rmCmAgAA9KAA= Date: Wed, 2 Nov 2022 16:37:04 +0000 Message-ID: <21012e3b-a30a-57e5-04c2-b49ef45daaa6@citrix.com> References: <20221102112854.49020-1-anthony.perard@citrix.com> <20221102112854.49020-2-anthony.perard@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BN9PR03MB6204:EE_ x-ms-office365-filtering-correlation-id: bc66d309-cc8f-4638-bbb3-08dabcf079b3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bjU4W8nAnLQKVclva2TjdfG7XKNLf9/vomCUhL9ZDs6i7x5aQMdKmCOO/DivhfOLXxnVwLS7Jvi3dlL5FhNbKLrDVU5MMzq5vjE8uchsbAdchF/oRskdv70H2Lq+ktJvOS0FIEYWQ15aQ1uRhc6hxyQwc+4VUD1+NnXVqubOhgVXbRyWo1mhvU5GIRiNTbxAaQHaYOEyweDgpPGZVsTZ4zyTL0XadeSxVF4E1GmLdcNxBb8dgxMIjOGWLuZ6qOgtIXCe3omnqBriYblkA18g6ZByq3Le/5WzcR7OUA5G2zvf6w39f/Ma2WnZ/9rRUAnBkP0dwvtwGrYAfQEa5JNJ7qWC+aR5uxNWzvwnPryUFFg2FKwAeAjwBAuhOTlQ3SBm52iUhVV8kQgv5h/6Cty6WYTupyDpCEwmtp5EmkP1QsMZk+UNC5L75V27Gsjj2jLh6BQ6hVW6caMLQLcNxbtF9teKm78cPAXzdFn7s4utCQArzEC+zcaIz39CaMgyPjmUH8rCR9FkOnFrb6+J42UGLH+aszPNYWB3Dts3MftpsRXCsWI/8+9oC7/qqMLbnvFSLd6lzYuw215lLivxaI/SwaaS50gn51/isQmsNAm0jHJZo1efuvaFhijpFnNY5A4+l+RN5U0CLm/kA1JvoKPb2uJS1FzVMaPjWyP2LbQ7ciJsd2HyDByCxyeX9/ftphzJkG1IKfbK4K0Hj/KGcg6eyPrcPJSkLu7lR0aFXUEXwKH9IxVqqWCTGD56gongFzqFeCHLcId6iih8sUJRO84onL5/09f/8cMiGL7UvhcG9sZP/u2NH7QZdWPTlbKAT4y6uiPinigbWKzd9jJDE6M22w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(366004)(39860400002)(376002)(396003)(451199015)(31686004)(2906002)(31696002)(6506007)(6486002)(4744005)(38070700005)(82960400001)(38100700002)(478600001)(71200400001)(36756003)(122000001)(26005)(186003)(6512007)(53546011)(91956017)(2616005)(4326008)(316002)(66476007)(66556008)(66446008)(64756008)(8676002)(86362001)(66946007)(110136005)(54906003)(76116006)(8936002)(6636002)(41300700001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Y1VaR0d1UGRwWTdKMDlRTlVtS2tpcG5oR1VxQ0l3R1IvY2NnZEdIeWYweVRB?= =?utf-8?B?M2s2ZHpyZXlPUVozdUNnYlp3YVZ3RXl4R1NLOXR0NzI1N3lHelR0N0EvSjl4?= =?utf-8?B?NUloRkxTR3NFdzRidUFzR2ZTemRZR2RtY09nN0t2VkplZmdTc1JmaHVzOVhO?= =?utf-8?B?WEhqSHpGZkV6Q1hoNHZ3K2NrdE1SUEdzTWxoTlNYSDd1SGFMcGVUMlI0T0hD?= =?utf-8?B?ak9JOUlrVWxSWWRMNzRwaTNUYnJMdFN1bHU1QkZQVVFIbkFYMDF0bmpiRWNl?= =?utf-8?B?Ym1NMXU4c1FBZGNUS3lhT1p1Um54ZWVmeC9PNGdqNWpHY0lCWDdrWFlmQ1lv?= =?utf-8?B?V1N3bll4dWJiTWVOdHdWTjVKTnNxalUyYWJmMXFIemJ0c3ZpK1VkYnBjV2Ru?= =?utf-8?B?ZllzZ0Z2Y05yaUVOTEZjYWFUd2NoOTA2VnQzbjJZYlVzcEVvWThBMTVwcGVX?= =?utf-8?B?bURDdDN1QWYxSGN5NWlTWGNaVVlYbW1QbGlZcFd0TUdiNXMxdGYrVWR2UENL?= =?utf-8?B?cmhPaGxRN0pvVVJtSGQxcUgrelVHdkIzZFh2WTVPd2tQczZ6SENHUFRZM0Ns?= =?utf-8?B?WXhQdzljUStzV0ZDNm5nampDRmZwdmh4MFNNd0lYOUZzSmkxWmxQa1UrRzly?= =?utf-8?B?RXVGVHJUTzNiaFkzQitzWXFBb0tHS3NDSXN0Ym9NWDJDV2JibDFHZVVxQzM2?= =?utf-8?B?QlNTVnEzY1NLNzlIQWd6aFRSVWhSL25ycjc3R0tFSFBLeCt1MXk0U3NYYlNv?= =?utf-8?B?Mjh5NldqcTVBNkFlVGdJK1MvWkpYUHpVUjdncjNFanNsNVlob2hyNzI0VS9B?= =?utf-8?B?dUs1Z0JhcldPbEprRlAwcndhc25kc0liN3oxRWxPa1Q5b0YwTWw0SkZZUkVT?= =?utf-8?B?Umw2TlFCMisrT0NmUHd0cjNvQ1VoQVAxYlR1cVYwaDdkelkyYWFKQ1hqR2JD?= =?utf-8?B?b1hDSmVaMnZuaW4wZGpjcnpyMEpmaWZnNmZzdStsbmF3bk1OUVg5NGVyRkMv?= =?utf-8?B?NUUvT0t3ZXhpQnRydzhoekdaQUpvNkdqaGRhZmMzZzlWOHBPdEJKWUdmNDN5?= =?utf-8?B?TDV6VXQ0VDBaRHpkRmFGdkZlNDF5eWJYelE1U1hIajRaT2pBMC94bEVBNkxP?= =?utf-8?B?dnJtcUFpMEZFUGJyY0IvRFI0VTJjam0zVmNNbUtJZnl1eUFOYkFWQzdwUjN4?= =?utf-8?B?S3FTajdDQkpCek1iZ1VzTUY5dEYxSjlFZDlpNWx4NEM0UEloNU41SEtQL080?= =?utf-8?B?QjBZbktCcXkwNUtTZng4b1FCUXJQRDhQaW1Ea0U4VS91RDY0MWtxMkJUVmc0?= =?utf-8?B?c3VvQUZ0a2ZqaUE1SmpPODVvMEVHb2xHNUNIeVFMT2QyZHFic2VKb2xyVDk2?= =?utf-8?B?eW56eFVacUtCL1h5ZWpVMUovMGd5ZDQweTJLNWR0cFQzN0dzL1gxMkFEb3dR?= =?utf-8?B?bUkzRjZ2blhPZDR3MFByVXJJbTF4U3B5SEl5Q1ZBSWl4ZmVMUzZEdTJrVEp5?= =?utf-8?B?cHNlOGpocXlTWnZWN0tJdGFiemdvTzZwSXJUc3NreG5JRHRjVEhLUlY0c3Zn?= =?utf-8?B?dDRqM0xZTWwzZTFSTWVWUTRjckN4QXlSNU84M0luY01CbjNiQ25YUklBdmc0?= =?utf-8?B?b3JwN1VsUzRBdjQ0SHNEbFFGdis5eSthOVJ2Ym8rQTRmRFFQNzBQS2FHVWJh?= =?utf-8?B?VENPUkFSMVJkTmhWcHNWNHpvY1c1ZXkzUG1CQUtXckFFWTF6ZlVjTkhPYTRN?= =?utf-8?B?SjZzcyt5MUxKdEYySWMyMlNLazV1OHNHVGxZR2tXMmMwVmtMbXlBQUhkVTh4?= =?utf-8?B?MURreDBIeHZWQnBmbGtqT1JyNDhyTXdhMzJMMjlCY1RRZ3lSL25UNktTTm93?= =?utf-8?B?ZUhZYkNCeTZCY2ZIZE1vaXZDQStNSFFwSmo4YUNJRlUxT0FjK3ZQYmlYWUQ1?= =?utf-8?B?VE5YdzlSbGhrMEdTcXBsRFZLOG40Vm5qMGlQc2ErSVc4eEZtMVd6bXQzUUpT?= =?utf-8?B?Ly9BWjd6eS9tNER6Mjl3K3h3YVNmYTdRWVljNnFmamd6U01NNkQ0eXl2dFVo?= =?utf-8?B?SzY0UUlpWjNwdEJ0WnlkR3YxRmUrODA4RUhXb0M2SUtsY3gvZENlSFJKMStV?= =?utf-8?Q?M5tAu+u1F7pePw+zbQ02o1IY7?= Content-Type: text/plain; charset="utf-8" Content-ID: <8BC1292DE9FAA5489203E028D1F86D23@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc66d309-cc8f-4638-bbb3-08dabcf079b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 16:37:04.6029 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fk5jKnrZMO66Ri2Pmtx11Zwb3x5GpNL856a/yz1THefg+cqQTpvszfutaQBkJq86i0cCmJNqfzO7btvUowZPm/JP/vEjWAydi2SrqPsuMZE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6204 T24gMDIvMTEvMjAyMiAxMjo1OCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAyLjExLjIwMjIg MTI6MjgsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPj4gRml4ZXM6IDgxZjU1OWU5Nzk3NCAoIm1h a2UgZXJyb3IgY29kZXMgYSBmb3JtYWwgcGFydCBvZiB0aGUgQUJJIikNCj4+IFJlcG9ydGVkLWJ5 OiBBbmRyZXcgQ29vcGVyIDxBbmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPg0KPj4gU2lnbmVkLW9m Zi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+DQo+PiAtLS0N Cj4+ICB4ZW4vaW5jbHVkZS9wdWJsaWMvZXJybm8uaCB8IDIgKysNCj4+ICAxIGZpbGUgY2hhbmdl ZCwgMiBpbnNlcnRpb25zKCspDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3B1Ymxp Yy9lcnJuby5oIGIveGVuL2luY2x1ZGUvcHVibGljL2Vycm5vLmgNCj4+IGluZGV4IDVjNTNhZjZh ZjkuLjZiZGM4YzUwNzkgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vaW5jbHVkZS9wdWJsaWMvZXJybm8u aA0KPj4gKysrIGIveGVuL2luY2x1ZGUvcHVibGljL2Vycm5vLmgNCj4+IEBAIC0xLDMgKzEsNSBA QA0KPj4gKy8qIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBNSVQgKi8NCj4+ICsNCj4+ICAvKg0K Pj4gICAqIFRoZXJlIGFyZSB0d28gZXhwZWN0ZWQgd2F5cyBvZiBpbmNsdWRpbmcgdGhpcyBoZWFk ZXIuDQo+PiAgICoNCj4gRG9lc24ndCB0aGlzIHJlcXVpcmUgYXQgbGVhc3QgcGFydCBvZiBTdGVm YW5vJ3MgIltQQVRDSCB2NCAwLzRdIGludHJvZHVjZQ0KPiBTUERYIiBhcyBhIHByZXJlcT8NCg0K Tm8uDQoNCkEgcmV0cm9hY3RpdmUgY29tbWVudGFyeSBvbiBTUERYIHRhZ3MgZG9lc24ndCBjaGFu Z2UgdGhlIHZhbGlkaXR5IG9mIHRoZQ0KdGFncyB0aGVtc2VsdmVzLCBub3IgdGhlIGZhY3QgdGhl eSd2ZSBiZWVuIGEgc3BlY2lmaWNhbGx5IGFncmVlZCB0aGluZw0KZm9yIHllYXJzIG5vdyAoY29u c2lkZXJpbmcgaXQgd2FzIExhcnMgd2hvIHNldHRsZWQgdGhlIFNQRFggZGViYXRlIHdpdGgNCmFu IGV4cGxpY2l0IHllcykuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 02 16:59:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 16:59:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436010.690022 (Exim 4.92) (envelope-from ) id 1oqH4x-0002Gx-VP; Wed, 02 Nov 2022 16:59:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436010.690022; Wed, 02 Nov 2022 16:59:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqH4x-0002Gq-SE; Wed, 02 Nov 2022 16:59:03 +0000 Received: by outflank-mailman (input) for mailman id 436010; Wed, 02 Nov 2022 16:59:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqH4w-0002Gk-DT for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 16:59:02 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2053.outbound.protection.outlook.com [40.107.21.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a5de1714-5acf-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 17:59:01 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7597.eurprd04.prod.outlook.com (2603:10a6:102:e0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Wed, 2 Nov 2022 16:58:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 16:58:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5de1714-5acf-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mvUXTMM+P+jhIsO8H887gdxI15wWmsF82XTmxSq/Bp460v3OLPpOvMbZRyCoAmxIBE1IseGToK3LJlf1z3tgGiXzycenps3dT2397Ok51VFKxBlEph1166cKF6N8oj44a9rsTiDiJiveKqWY6PbjWtSxTi76vzQpLyclISgIey0Dv03CIgpNb3BQCRion8Er5lveXXKWnpu3U40X2nHcnL7U98LNQQ7FTllxg1A2+7y87gz1IdAQq0sAG/dDwojbswYItljjw8pOB6C04ISWhfP1g5qxqcbJDs2zNVVldhUlCW5i1kf2N7F/6ILBJIsJS2ZZGK7kdzC9c0Ho18wzTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IomqiuNnTUlFiZ1chlqnwiTLBJlaV13P7OUVhimZalA=; b=grkF5cqm8vyg0+rsw67Th5iWewV3void9B/aI3RlZxgrcxvzhv/dlsvSaY8zmW3lj+ZFKfrnb+CSZMVO7nf5ZkoEat2if+iQTOZtYTbSwyBvL+Zz9nxi8bP9XaqAN4OpoV5QyqI4mjVKceSu600f8N7NNkcroHQdqigPc1esmzf2/vJYCqP/gKLzYOeBhdNeIH14RBZ3GVbNgGplcVGCdox//FJ8HA+OBSvSQ0Tgz2Btr/Ajyldi6mmyf7Hs/iY+n6BINUehx8a9P6npIjZ7+hGrtvJQLXrTg/uVOvkaEsJWb7AGsLGdthQnza47Rn0mwPQFOYsQp9SMfyu3eI1KJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IomqiuNnTUlFiZ1chlqnwiTLBJlaV13P7OUVhimZalA=; b=W6ES+/IMlbDQ7oXCKnhUPhjM7DNr8ww3l9i6rTfqmzQ7ynZEdMvEL8So1PkWzMwWR/djHGAE0KpFzGZtthqE6vv/+EzpuhGBLylmN9VARLNUOZDsx7X9hUCKjfAzlCv+mV81uA8+h0P01FKAN2a5tnh2gMDsALgG3gyBp+1raK6feoNZxkSQZye2Pl5K4bdLUWc7xRZs4xE08ckPj9/V1oDPQWyih5SIpPXhBC011vTjca+k3MvIIcdeW/iT6Y9XxP8TcEEoBHWLhcDYstEv8tkS2f3cd16t5jAZblRbLatBXe24rcdDPJNzHSRy55VWnZzK4C0MhFQ4TmZUHxFzAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2ee2c1f9-a6bf-7641-16fa-ce2ea90f377b@suse.com> Date: Wed, 2 Nov 2022 17:58:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory API Content-Language: en-US From: Jan Beulich To: Henry Wang Cc: Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , "xen-devel@lists.xenproject.org" References: <2214fd86-0cfa-58ef-39db-6f913a9de75e@suse.com> In-Reply-To: <2214fd86-0cfa-58ef-39db-6f913a9de75e@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7597:EE_ X-MS-Office365-Filtering-Correlation-Id: abc89822-d461-45e6-1687-08dabcf38896 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z70dDITH+7ZNlt7cr9FjopGajZIeSqVn3Rhu1rwq5ZYXPFeXHFctixHSOATpvb57ERecWQtp4JLpCBUNdYEy0HcjMUNbQF6zW1IFOwJNQ4V10QQ5hFKnhuubdJFE8IihQWSvb8bS/HxhK50IDNzD+ZLCCzD4VAXRda2e93kOzirdvL2HTM/JbFcsK843aMfuObG7v8MDG56micYHrSz5v7D5VbOxGXbTtjgKgrq5uPK9UqSAjH+iSIUKA9GcPsZoaVz10iPpOByUZkxaxQJUyofEtciSD7lDdCnxNimJIZcT8tPdzIGisUx2nkShyVBhvy0dVAlOH1JCxN7RGiEP10OpbEAOKPk5j85UGGnQMsaCMefM3QpP7PehNhlgxsV2vJSl7AZTyYiEkV/1n7txNwy2e/mH0XfTZ269Q6KHZ02IOtyF6uWIYWhJoyESKPuv9oBKiL7JzvSSeLwoXLwCYGbp/Y7CotdH2FbftZwoDvLIWRMfFrhRgDNSs0YSRD5QimopXyhu95nuu08WqoINYVvGFd08+D9M1eWbajMo7Hx/JOSR4Yf7H5gLNujzbd2aYPeiJF1hBsa+p6AAMZvqBII5MbCdZPWkKwTTg2pkeq7SWcgNmq3aCJCa44kpubdHHdYtfgem5/ttHo6wx2a7hdZJG5k+RAKFz3St5tTZiOtqpxvyK4voIjx7jpKTp2NVQPRqEti1t2fSFoz9VuT70d7Q2TH3EYyz8aZj91VyETScTcnctfyP9YK2Y7UML1TeURo1PzoWmiVhuyCQI3Nud+Tfx7+VcjdsPL+BgIxQJ5Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199015)(83380400001)(31696002)(66574015)(86362001)(66556008)(6512007)(38100700002)(2906002)(5660300002)(66476007)(4326008)(8936002)(8676002)(41300700001)(186003)(6506007)(53546011)(2616005)(26005)(316002)(66946007)(54906003)(6916009)(478600001)(6486002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDhNOG1QbU9hSDRiVXB1bjJEY2NpTldkNzZEUGphVEltWGRuS1NrMWwzS2ZG?= =?utf-8?B?a0x6TitTejBTc0dza1hkZHZpNHZKbXE1dURVZlVkb0xCY2oyaEJ0YTkvL3R6?= =?utf-8?B?aVdDR1czTUFETWU4U1JHOEVRdFZVc0crZU5RQXhNQnFEUEI4Qk5RYmRFdVpy?= =?utf-8?B?cStmRXBsV2VvZXRMdzMwU3VZMGRwOG1HdWxvU2lOWFphTnROeFJFZ1NXTk5B?= =?utf-8?B?b2tmc1lvQUhpV1VHeS9XcXJWanFORk4rL0dOR2UyOTRyd2tIWkJuUTRDZk5E?= =?utf-8?B?SXd1cTZWZ3IzUDJkbUZUTmI3ZGNyZEZaVFFnTk5DZGhnTG1xaTMzQURka2lX?= =?utf-8?B?Z29PTDd1WDdFVngzbit3NkdWQVpEN0tSQjRtZ3o3SFM3c2RhSzRSOUtTcFZP?= =?utf-8?B?d2VJVHBCV0dzNm40QVMxRDF5bFNmWXhJRjlSRzg5VlcxMlMrYU1nYk5pcXJC?= =?utf-8?B?Wk12ZXQvSkViekFnZ3pJMCtISEZoaXRaYnhNT1IzWDN1ZU85RFZxQjdtaGVl?= =?utf-8?B?a3dGU2ltSG9kOWIreXZoRnhGMnptSklReWhMZDB6UEViOEV0bXFwTzlVbjFQ?= =?utf-8?B?NmdpU3RhRnF2cExPWXZ3NXFZVlprTTl0VGdnSzlWYWpaODBGbmhYY2V4RzIy?= =?utf-8?B?WXlocFEzalRXTk5OdG1kZ2VjWHFlTzBndEtRK3h6M0xETG5TdnBxWHBQMUZa?= =?utf-8?B?cTd2MGY5SmVHNk0vSFBKeUtzd0FXMVJzeXMxSUcxV1p3VHlCZU02d3ovYmto?= =?utf-8?B?eEJ0bG1TYVpCVVgwR3E1Q25KZldQaWJZVzZ4bzVucjBkQ2ptSW5wdkhGNzMw?= =?utf-8?B?YW5nWlpmd2tDT2xwbWg3NHVyZWkzb2JyU2pJcUNJakJJQWFZRVZ4KzRJOFp0?= =?utf-8?B?eGkvbVJTcVVhbUo0bGY1VllxZldZVHJpaGRGR3I3QXJ6RGt6NlRQOEtmcWlD?= =?utf-8?B?cUxVa1lsa3VkNXdwZ2hUL0lRMG9RQllKY0FGMzVxUmNQY1p6ZmNNekMzLy9k?= =?utf-8?B?TE54dm1mb2ZaTWN2eE1YTkg4b0taUnhpOUpCakxuYkRqSlFEeVNzdmtuQkFR?= =?utf-8?B?Sk5nZHVyTUVTd0p4ZGhGUHVIOTRjUy83UVViWmhkOGFaTzdMTSt0Q3hCdlJY?= =?utf-8?B?U0FxK0tsVkIzTVFtY0RONnF4QzVlTkFxVTd3VnlDdXliSE5pOGcyMVhhOHdX?= =?utf-8?B?c0E2RkNqdnU3ejgyMUsvdmk5NWdlM2tRYTFuZTBCZU9MQ3FwWVBFc0tqOXhU?= =?utf-8?B?b1ozcVZTb0Zkc2U3ZVN0dE16UkJlWEZqYkh6Q0lUZ3JLQ3hreEdTUlB6bkxr?= =?utf-8?B?QUJadlZneXl0bVh5RzlremIrakV1TDZwRERHRXBMUnFaRVlWNXhwdWlFRmQ4?= =?utf-8?B?UUxIVGYrM2JZcm1MTmczaUkvNnJ0U2xqd25qSDZNQzRuWmNucjVlMXBGQUdh?= =?utf-8?B?K0NqYjhweVJxOHgycEt5eE93ZDc1WllLZ2V5WmlTK1MrMjRhenJYWmNrVHBY?= =?utf-8?B?U0Q2ait1aGxZS1JwZkxDWnpoWDY3TjlGb1ZNeUhSaW5VMHJQM2pxQ1pDTzMr?= =?utf-8?B?TGNvUzNvUTFOdW42UHNDdTVDbVlkTkp0TGN1UUx6ZTFPcW50cWdmU3RxMXg2?= =?utf-8?B?enlJMW1Ib210QmFnUEtMeDR5Qk9WRk9FREpadk81OFNXUmtkbUdPUWtHOUxw?= =?utf-8?B?Q1U4aWJxeUhENWEvRHA1cTZweUJ6M2xtK09hNHBtOGVDTnpEbWk1YU1rUThx?= =?utf-8?B?MUJySXJWL2FhRHVqNGgxTnZVcW01M2JVMTVLd3VxSXdjUFQxRE1aQW50Qm8y?= =?utf-8?B?QzV4VGNYaHVxSml5c0x5SWNDbzdFUldsVk5FaTJyWEpTS1FmKzd5Q0hmZmJX?= =?utf-8?B?KzNDOXpDZmJWSVRZMmJGZzQ5SnlrNWdGeFlCeVNkeEJCK3E1cnVNTjVid0Fl?= =?utf-8?B?Mk1kbUJwSkpvNjdBN0VzQlV2TjdOZWh0aWVpWGZzT3hxY0p2ZnVPMTFwNlY0?= =?utf-8?B?MlNGR3ZpdVMrYVNSUGVTdnlSekZHczJLa2Ftamh0ZXFCNnlKVHZiSTNGbDB2?= =?utf-8?B?bU5HdFZhamZBV2VRSU8wTi83d1pNVWN1S21WQk9xRHMwd1pPRFRBbUlXeGhM?= =?utf-8?Q?d8nRA79ui0JmgL/gsKsNRihio?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: abc89822-d461-45e6-1687-08dabcf38896 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 16:58:58.2833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KOTY8ht7dxeDq0GDRZVNDXXs+60kHYq6biBQnC4/iTOOTtkUWWVABURBF3JDarqaWw9ayfYgQri7HruqFoMhWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7597 On 17.10.2022 10:55, Jan Beulich wrote: > On 17.10.2022 03:20, Henry Wang wrote: >>> -----Original Message----- >>> From: Marek Marczykowski-Górecki >>> >>> On Thu, Sep 29, 2022 at 03:33:12PM +0200, Marek Marczykowski-Górecki >>> wrote: >>>> Re-use rmrr= parameter handling code to handle common device reserved >>>> memory. >>>> >>>> Move MAX_USER_RMRR_PAGES limit enforcement to apply only to >>>> user-configured ranges, but not those from internal callers. >>>> >>>> Signed-off-by: Marek Marczykowski-Górecki >>> >>>> Reviewed-by: Kevin Tian >>> >>> Henry, can this be included in 4.17? The AMD counterpart went in >>> earlier, but due to late review on Intel part, this one didn't. >> >> Thanks for the information. I agree this is a valid reason, but to be >> safe I would like to hear opinions from the x86 maintainers (added >> in CC). >> >> Andrew/Jan/Roger: May I have your feedback about this? Thanks! > > Hmm, not sure what to say here. Yes, it would be nice for things to end > up consistent across vendors. And yes, the change here is largely > mechanical (afaics) and to code most of which shouldn't typically be in > use on systems anyway, and so should not pose an undue risk. But still > it is quite a bit of code churn ... Was this lost, did you decide against allowing this in, or were you hoping for further responses by others? Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 02 16:59:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 16:59:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436015.690033 (Exim 4.92) (envelope-from ) id 1oqH5p-0002nN-Bz; Wed, 02 Nov 2022 16:59:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436015.690033; Wed, 02 Nov 2022 16:59:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqH5p-0002nG-95; Wed, 02 Nov 2022 16:59:57 +0000 Received: by outflank-mailman (input) for mailman id 436015; Wed, 02 Nov 2022 16:59:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqH5n-0002n2-Qb; Wed, 02 Nov 2022 16:59:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqH5n-0006Jb-NB; Wed, 02 Nov 2022 16:59:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqH5n-0000hU-7d; Wed, 02 Nov 2022 16:59:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqH5n-0002UY-7C; Wed, 02 Nov 2022 16:59:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wr+Pkzxq2TJIp/GBjodrEpy4o2rEN+hmE6Vc3I6ox78=; b=uIUAlgFqEtw8vdKW8nvTaXwFiH BXfKA1gNXV+vWjIIwETmNbvpuS9BTOQG17SIyObFf+SR2WbIxeP6hHgsIATIvsVT5Fwwc9a48QUmO se+dCJYzhIdxzf0RFTdh7Rf8zFC4ZSA7jR6GsUmuhzZ+dHqPGnm2fNL/RJmU6DWhFYb8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174575: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start.2:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=5282d4de783b727f9e5e6e90d90a3eff53ef5c31 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Wed, 02 Nov 2022 16:59:55 +0000 flight 174575 linux-5.4 real [real] flight 174588 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174575/ http://logs.test-lab.xenproject.org/osstest/logs/174588/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 19 guest-start.2 fail in 174588 REGR. vs. 174540 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174588 REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail pass in 174588-retest test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail pass in 174588-retest test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 174588-retest test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 174588-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 174540 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 174588 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 174588 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 5282d4de783b727f9e5e6e90d90a3eff53ef5c31 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 4 days Testing same since 174575 2022-11-01 18:42:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Greg Kroah-Hartman Yongqin Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 5282d4de783b727f9e5e6e90d90a3eff53ef5c31 Author: Greg Kroah-Hartman Date: Tue Nov 1 19:06:42 2022 +0100 Linux 5.4.222 Signed-off-by: Greg Kroah-Hartman commit 59f89518f51004bcdb05a92e462e2298989294f9 Author: Greg Kroah-Hartman Date: Tue Nov 1 18:12:39 2022 +0100 once: fix section mismatch on clang builds On older kernels (5.4 and older), building the kernel with clang can cause the section name to end up with "" in them, which can cause lots of runtime issues as that is not normally a valid portion of the string. This was fixed up in newer kernels with commit 33def8498fdd ("treewide: Convert macro and uses of __section(foo) to __section("foo")") but that's too heavy-handed for older kernels. So for now, fix up the problem that commit 62c07983bef9 ("once: add DO_ONCE_SLOW() for sleepable contexts") caused by being backported by removing the "" characters from the section definition. Reported-by: Oleksandr Tymoshenko Reported-by: Yongqin Liu Tested-by: Yongqin Liu Cc: Naresh Kamboju Link: https://lore.kernel.org/r/20221029011211.4049810-1-ovt@google.com Link: https://lore.kernel.org/r/CAMSo37XApZ_F5nSQYWFsSqKdMv_gBpfdKG3KN1TDB+QNXqSh0A@mail.gmail.com Cc: Christophe Leroy Cc: Eric Dumazet Cc: Willy Tarreau Cc: Christophe Leroy Cc: David S. Miller Cc: Sasha Levin Cc: Nathan Chancellor Signed-off-by: Greg Kroah-Hartman From xen-devel-bounces@lists.xenproject.org Wed Nov 02 17:26:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 17:26:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436024.690047 (Exim 4.92) (envelope-from ) id 1oqHVT-0007GS-Ed; Wed, 02 Nov 2022 17:26:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436024.690047; Wed, 02 Nov 2022 17:26:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqHVT-0007GL-Ba; Wed, 02 Nov 2022 17:26:27 +0000 Received: by outflank-mailman (input) for mailman id 436024; Wed, 02 Nov 2022 17:26:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqHVS-0007GF-DI for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 17:26:26 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78fa247e-5ad3-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 18:26:24 +0100 (CET) Received: from mail-bn8nam04lp2047.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Nov 2022 13:26:12 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5193.namprd03.prod.outlook.com (2603:10b6:5:241::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 17:26:10 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 17:26:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78fa247e-5ad3-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667409984; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=EDxHCF7Nmi72tXTpt26cinldWFyy5ix/bNnqKe/wfes=; b=T56Qj9yWBn85tIoK7qz55X4AhT4/un1CrSI4hwdRI3yKKus4qUD5hJSj 5WDjQ2+GonZ99ftwMimo3OZC3/XD1BCrYSFuB+jb9XD/qgUPGlLnYgMzh OyoKz/BRkUFk/8m8ByVkfQFQaO6K8MPWtMWTBUCc3sirY2bmwTWGSbaY8 o=; X-IronPort-RemoteIP: 104.47.74.47 X-IronPort-MID: 83122164 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:nNWuIqPHDl0QRPvvrR2YlsFynXyQoLVcMsEvi/4bfWQNrUp2gzIOn WNKC2uGa/uCY2ujed0laIixpExXu8CAm4RhSgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpB5gZmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0sluDGMU+ 7sWEigEPxWm2sGHxbenE/Y506zPLOGzVG8ekldJ6GmFSNwAEdXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vZxvze7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr+UxHmhAdxOfFG+3sBEhASww30yMx9VanenkeWIlHahUM0Kf iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZNYcIrnNU7Tjsr0 hmOhdyBLSNrmK2YTzSa7Lj8hRO/PzIEa1ALYyAsRBEApdLkpekOYgnnS99iFOu/iI3zEDSon zSS9nBi2PMUkNIB0Li98RbfmTWwq5PVTwkzoALKQmai6QA/b4mgD2C11WXmAT97BN7xZjG8U LIswqByMMhm4UmxqRGw IronPort-HdrOrdr: A9a23:yrtGf6n67j2QuWYj2cLdiCpo0jHpDfOPimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza9BOO gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4ZkWUzxjIjLH47JlON1Kk3VO 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEz82IIgMgE2nsQ/pM0TJdJo+ zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBOB1vd75rspLkl7uCjf5IFiJM0hZ TaSVtd8XU/fkr/YPf+qKGjMiq9NVlVcQ6duf22vaIJy4EUbICbQRGrWRQpj9aqpekZD4nSR+ uzUagmccPeEQ== X-IronPort-AV: E=Sophos;i="5.95,234,1661832000"; d="scan'208";a="83122164" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k8Ep+YxUgkxsMwBql+EHJKYDTTihy67ESMflEkc27Jiauv9tcdysO5JEwmQTFkEOJJpOlcj99TSF4CMz+OyJF1Idt8/HuPowLRL3bYL8pTrdLW4/eRaA5mq+f/IMiI2+jBeI941o4wKrKj2zR5CLcUnwtpBKXCD8a/rIsCxHUU30qJWKPj4p6B0T7Du65+vnWiP7deTimn14RjXpwdKfHpTn1rH5qWqIx4GAtMC7naivnxl5pako1RWgsC/TPvBsN0robtCS4OgqmGURbhEIVi9sh/m3B49sA7pPEvxPVj1S1fOqubCwmXd/+e4D5SaU9/rEbnUbalo/4OCBs5x42Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EDxHCF7Nmi72tXTpt26cinldWFyy5ix/bNnqKe/wfes=; b=TkviYj8whUrBr/9vyQfFESpbDL8oq1dsDrSoOS6VSMdmVnD0/xn+qOQ6h7QhiCclFLMx0VKefpLXuPz+sozZ1ooRm/IONDnkOMKddWZYmNyK7/YmQ8ZNRfN8yPVtaD6MQ9wh269uUhmbJR/Fj0GJ12qyHFKie7G43vjRnznZ8b8AR0xCCMCaAQ1+IeMJZtkZM/+B/WhP+MZM+jsXNO1SE2eOZBPPDg7kiiLSIdupZj3svKZ3OpQJxMFotmKzL4iYH5mbCN2RfYoRYNGY18/uRA+Nwtwz7pV0ST0fCrxh8lKvLec0MSg0ZBgPPVOB9rOKuq0xCsgcwFcTd+V1ojDEsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EDxHCF7Nmi72tXTpt26cinldWFyy5ix/bNnqKe/wfes=; b=Hd9LQY2eDZGSYYE8hXcVxdfeBMPj6saRltID3IrpiiJ1YO32iyVFIwOarGl5C8ASYhPs/rqyif4PF7AQrZMT7eAQIU5+6C5coOqJSKeFuV0Qkv+5xMQPV1uQb/Wes0SNOTXEHBsJv4kt4WjnUoShEGwMc0pUKIyC58UQGWvDhM4= From: Andrew Cooper To: Edwin Torok , "xen-devel@lists.xenproject.org" CC: Pau Ruiz Safont , Christian Lindig , David Scott , Wei Liu , Anthony Perard , Henry Wang Subject: Further issues Re: [PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist Thread-Topic: Further issues Re: [PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist Thread-Index: AQHY7hvRP8qjKADr4EWYXnGWkvQZoK4r5CyA Date: Wed, 2 Nov 2022 17:26:10 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM6PR03MB5193:EE_ x-ms-office365-filtering-correlation-id: c69683ce-622c-46b4-9600-08dabcf75590 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CBNeo5sjFtPf94+2RX7cMqr2eFRmsfUJIPg8CICCiWpgdckAzO/FZo2QkmNa4/E/IQRmfDRfVj5JQGAfBUqtN1dglljZvmFkMUXVFAC0HTCmhLLchjjWs61rMJ8xx/D6vu0kSIBnmLN0vVoLFoZSMFlCfcrwcs7Uee5b4ZFODiexVef+lofpEFnX4d9QzVhu4ny3u2+U2QvDnOZW9znI2KGc5cbJZ3e9yMeBFZ2TblgCA08aRWfB90q4ZkfTpT8cFcJwc2B0PXucKmTsnJM4CMNcZsJyEdi303veTUHUjO/uaKfvb+QItI27Tf+FMsMXj7LeG7onjxFsBw4azD7b4uvP6K5lxnBFuud+hgGJYRg5/GtLo40eZbvIGIt+LLwgyiO8POt/+8mA29qBa2jqdVEEL6O3YM264h1WeQj5MzebvBf/LKOFO0j2nT99/M7hZItC1bjTCYHJxv0ArtT0c2pN5zovrXvzcO5HosFY12D/7u0wChoV/YIpA+q/4uKucbK2JvbwDv7qqnWfFHuPRonNu6iniJmwY4nahBv8+L4+yWN5+tMERwWdha/+pCn4NGOwkRzdcY5hGW5cWCWS8wldgfzRPlm6Y6tCEik48MBEneYcropbr8CjEVUxJgtrjlE/ZXRMvjACndOaSuFN+4S7Y8N+Bjj3Ox6//6YjFEzDIta3YkunCJJ8wA6vf+BUaxV4KmDt9M/p3Flv1tT5N1IoMOz/E9stf9tbMz22wjqSqYj88FRaLNcT2MUXJVC6BXggZzj2h6IXfqn5LhuCGZKGZU31HZrExyxXOi8ujjqHyzmipA8v5o6964Emk7G7mt+B28zCNek2OyqsMIrTeg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(376002)(396003)(366004)(451199015)(71200400001)(38070700005)(6486002)(478600001)(31696002)(41300700001)(91956017)(86362001)(8676002)(66946007)(66556008)(66476007)(66446008)(64756008)(76116006)(4326008)(8936002)(5660300002)(36756003)(83380400001)(316002)(54906003)(110136005)(31686004)(26005)(6512007)(122000001)(2906002)(82960400001)(186003)(6506007)(2616005)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TDNOYnUrbVFTcmt2MjBxR1hXcldqWUJUQXpHMENYS0ppdi9IdmQvYXlFUkly?= =?utf-8?B?MXFRTldndXVodzRJbTNmUDVrcklhcndJZ2ExWlpjQmdES20wMS9MekVVWGlT?= =?utf-8?B?YnhHN0IwdlF0T3ZEVG5pbFFvTlNCb2k0Q2JFek83dDVoS1JUQm5jOW5CTXU5?= =?utf-8?B?b3hNZ21EQkxHTVVJWnRaQTNlaGRHdTRRQWVuTUpJNjN3VlladHcvV3Nwbi9J?= =?utf-8?B?TDRROTg5WHllUDVKeTkxYWNPZFREOGI0bDJpU0tCL29qTU1pQVFuYVlhWkFZ?= =?utf-8?B?L2FZNUNCMG1GWGJNTXJYRmJKY080citJQjZkRUdhTURBTWVXL1dVMWZYWGF1?= =?utf-8?B?R0lqZ0x4Q2tqKzhRcXVwU2NwNncrZExTOHVEK2tKV1ZGSmh4NDd1Q2xFemo4?= =?utf-8?B?Vmp3eUhENnBuVnNLMkkvcGYrcVRoVzdmOFpXemVHL2h0MkFZbFNrM2xpUUs5?= =?utf-8?B?bGtHSzlNcW9mSXRxL1pVY0JyVkcyNnpmZTR6QVhQeHNPRjBZOWsrQnd1dkFY?= =?utf-8?B?K0JYUXpaNVlXUDYzbzgzYTZ1YkNWcU1WVGU1VG9sVFhEc01oRWQzU0dJY1l2?= =?utf-8?B?SWpmN2pvNnRZRzRiMlB3Mkp2S1M3amZEQ2dQRGdQbTRndnNPM1dRL0FYV0dG?= =?utf-8?B?M0hHNUs4ZHRLUGdiaHRDcGJKQk5KaFQrRVdGTFJmUndJdVBvb2UvdjJBV1FG?= =?utf-8?B?d0hFMEhjZFB5MzBBSjA0YmhoV1RwTnJnNVdxWEVtQW5ENnZWVHJKemZQdTZN?= =?utf-8?B?YzErR0lMbk0rc2ZKUHJEREZCY0c2dm5XSjlqdXFYdE8vLysyRmEzQWZDWjh6?= =?utf-8?B?OEdBb2pPT1NqUld3bnBVL0RrMERZSDhtU0NGVWVGbzVac2tqdUVUZWM3U091?= =?utf-8?B?VVZoaHVXSnFQMmhLSHlQVzJPSkVaZXlaRWdmdUpPSWFHN0dWSm5PVko2akVH?= =?utf-8?B?azJqVUpCdGw1KzVuTGt4Y0ZidXdrK1dka2FPREhnUWJQbk54b3duak1CeUhM?= =?utf-8?B?R0E2T211MmkxS1NWdzdFeGdyRzduWTQ5dCtPQjVZVDY5RTZXbVlSWWczb0dD?= =?utf-8?B?MjlyZno2K0NRY3RaeEpiZW51dzhmSUlwWWdrL3kvbzdSUWVMT0x2K3NXSHQx?= =?utf-8?B?bFRRUGhDSEVZbi9BOGY4d3pGSnkxczN6bE50NFdUZVNUSXl0dEF5RWV4N0xN?= =?utf-8?B?L2FjeE0rdERWRjQ2MUltZDdFVWpSL3QyMnFFaXJYc2RDWnNFRmU3dWFhdFB4?= =?utf-8?B?SGpFU3E4K2d2akxTd1BaUlJVQWgzakRTMEtKVjc2eWVWUVFHWC85Sjg1L1Nr?= =?utf-8?B?dktHMXo4Y0prS3RUZWFMU3duaXBnQ3NlZEFIVVdtSzBPR3dNazFvcmdnaXRK?= =?utf-8?B?ZytTRmdQWlppbXlocUNIeU84d25GUjcwWnJudkYxWFFYYis1cUc2YjM1bTgx?= =?utf-8?B?US90VGtpNVF2NWRNUGhVaTJjNndFTzB5S3NKbmdUay8yY0lQcVIvWG9VMFJo?= =?utf-8?B?d1VkMkhPOVVrSndaUHA2dnpKbXAzakdyYWZRMzBzbDRWOGpPaFlXVzQ4cGtK?= =?utf-8?B?bWp3ZlZvUUptSnJPbTd1S2x0QVJDT3VWaW5FOTJSNUdiRUI4Z2k0eUF2Unh1?= =?utf-8?B?a3NicExHL1NXWjJEcStONTZoSFBvMks5SGtVSjk2WTd2elowRHF5RDZCQXJY?= =?utf-8?B?VWJiZ0lWNENZSzZBck4rcTJsYkRZaVQxeGNoYWEyT2FoMjc1di8zOVJ5K0t1?= =?utf-8?B?c0YvT0JLdXIvam1kTzRuYjNvR0w1MVZBNlc4VnhqM3BVenJlMWpGODZUR083?= =?utf-8?B?bmdtWjVBRWhtZVFBTGlMRzdyZmNEcXFZSVViTTAySVAxbFJhd1VTK0xrMTVT?= =?utf-8?B?UGpVKzVzWjhlZGJXcUthU2FvSnNLS0ZGU29TdTlrYnpFLzdYc0tpNVNERFJ0?= =?utf-8?B?MFVucHNHVWJ6OVI1WHU2bG5vOE9pQWQ0b29tK0FrUEZlRnFxTHZCS2Raa2k2?= =?utf-8?B?MTRPemI0K25hRWlkbWJDSzF4VTZIaHFlN0pmeXdIcW1CTzFqWVB1OXdSVys0?= =?utf-8?B?OUF2NjFPaTZlMWNSU3BYRCt3YXFjQmxJZ0VmN05KazRkTEtmY1QzZFc3OEFa?= =?utf-8?Q?DODJ5yggvtNZ3avH3KrICq+wG?= Content-Type: text/plain; charset="utf-8" Content-ID: <5075355C2ECED041B9534C8935354DD6@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c69683ce-622c-46b4-9600-08dabcf75590 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 17:26:10.4204 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PSmnx7RQWEuINbcxoomJBSQ1F32k9AyAMKZx2ChyJ93ZgAGDNixshBASWK6z5XOwmq64UW4Ki75LW6azKqZOMWZsJKTNk6f1DyQ3R4P414E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5193 SGksDQoNClRvIGJlIGNsZWFyLCB3aGF0IGlzIHByZXNlbnRlZCBoZXJlIGFyZSBjbGVhciBpbXBy b3ZlbWVudHMgaW4gdGhlIHN0YXR1cw0KcXVvLCBhbmQgcXVhbGlmeSBmb3IgaW5jbHVzaW9uIG9u IHRoZWlyIG93biBtZXJpdHMuwqAgQW5kIGRlZmluaXRlbHkNCnNob3VsZCBiZSBjb25zaWRlcmVk Lg0KDQoNClRoYXQgc2FpZCwgdGhpcyBpcyBhIHN3YW1wIHdpdGggZnV0dXJlIHByb2JsZW1zLCBh bmQgb25lIHJhdGhlcg0KZnVuZGFtZW50YWwgb25lIGluIFhlbiB3aGljaCBJIGlzIG5vdCBnb2lu ZyB0byBiZSBlYXN5IHRvIGZpeC4NCg0KMSkgKHNpbXBsZSksIHRoZXJlIGFyZSBhIGJ1bmNoIG9m IHN0dWJzLCBpbmNsdWRpbmcNCnN0dWJfeGNfZG9tYWluX2dldGluZm8oKSB3aGljaCBkb24ndCB1 c2UNCmNhbWxfe2VudGVyLGxlYXZlfV9ibG9ja2luZ19zZWN0aW9uKCkgd2hlbiB0aGV5IHNob3Vs ZC4NCg0KMikgc3R1Yl94Y19kb21haW5fZ2V0aW5mbygpIHJldXNlcyB4Y19kb21haW5fZ2V0aW5m b2xpc3QoKSBtZWFuaW5nIHRoYXQNCml0IHVzZXMgWEVOX1NZU0NUTF9nZXRkb21haW5pbmZvbGlz dCByYXRoZXIgdGhhbg0KWEVOX0RPTUNUTF9nZXRkb21haW5pbmZvLCB3aGljaCBpcyBhIHByb2Js ZW0gYmVjYXVzZS4uLg0KDQozKSBXaGlsZSBib3RoIG9mIHRoZXNlIGh5cGVyY2FsbHMgaGF2ZSBj cmF6eSBBUElzIGxlYWRpbmcgdG8gbG9hZHMgb2YNCmJyb2tlbiBjYWxsZXJzLCBhdCBsZWFzdCB0 aGUgRE9NQ1RMIGhhcyBhIGZhc3RwYXRoIGZvciB3aGVuIHlvdSBzcGVjaWZ5DQphIHZhbGlkIGRv bWlkLsKgIFRoZSBTWVNDVEwgKGFuZCBET01DVEwgc2xvd3BhdGgpIGlzIGFuIE8oTikgc2VhcmNo IG9mDQphbGwgZG9tYWlucyBzdGFydGluZyBmcm9tIGQwIHRvIGZpbmQgdGhlIGZpcnN0IGRvbWFp biB3aXRoIGFuIGlkID49IHRoZQ0KaW5wdXQgcmVxdWVzdC4NCg0KVGhlIERPTUNUTCBzbG93cGF0 aCBpcyB1c2VsZXNzLsKgIE5vdCBhIHNpbmdsZSBjYWxsZXIgKEkndmUgZXZlcg0KZW5jb3VudGVy ZWQpIHdhbnRzIHRoYXQgYmVoYXZpb3VyLCB3aGVyZWFzIEkndmUgbmVlZGVkIHRvIGJ1Z2ZpeCBj YWxsZXINCndoaWNoIGRpZG4ndCBoYXZlIGFuICImJiBpbmZvLmRvbWlkID09IGRvbWlkIiB0byBo YXZlIG9uZSwgdG8gZ2V0IHRoZQ0Kc2VtYW50aWNzIHRoZXkgd2FudGVkLsKgIENsZWFuaW5nIHRo aXMgdXAgd2lsbCBiZSBhIGdvb2QgaW1wcm92ZW1lbnQuDQoNCjQpIFRoZSAoYWRqdXN0ZWQpIGFs Z29yaXRobSBpbiBwYXRjaCAxIHN0aWxsIGxvb3BzIHVudGlsIGl0IGdldHMgYQ0KcmVzdWx0IHdp dGggbm8gZW50cmllcy7CoCBNZWFuaW5nIHRoYXQgaXQncyBzdGlsbCBnb2luZyB0byBtYWtlIG9u ZQ0KaHlwZXJjYWxsIHRvbyBtYW55LCBzZWFyY2hpbmcgdGhlIGVudGlyZSBkb21saXN0LCB0byBy ZXR1cm4gbm8gZGF0YS7CoCBJbg0KcHJpbmNpcGxlIHlvdSBjb3VsZCBvcHRpbWlzZSB0byBzdG9w IGF0IGFueSBoeXBlcmNhbGwgd2hpY2ggcmV0dXJucw0KZmV3ZXIgdGhhbiB0aGUgcmVxdWVzdGVk IG51bWJlciBvZiBkb21haW5zLCBleGNlcHQuLi4NCg0KNSkgLi4uIGlmIHlvdSBldmVyIHVzZSBt b3JlIHRoYW4gYSBzaW5nbGUgaHlwZXJjYWxsLCBYZW4gaGFzIGRyb3BwZWQgYW5kDQpyZS1hY3F1 aXJlZCB0aGUgZG9tbGlzdCByZWFkIGxvY2ssIG1lYW5pbmcgdGhhdCB5b3UgY2FuJ3QgdXNlIHRo ZSByZXN1bHQNCmFueXdheS7CoCBDYXVzYWxpdHkgY291bGRuJ3QgYmUgYnJva2VuIHdoZW4gZG9t YWlucyB3ZXJlIGFsbG9jYXRlZA0Kc2VxdWVudGlhbGx5LCBidXQgd2UgaGF2ZSBhIHJhbmRvbSBh bGxvY2F0aW9uIG1vZGUgbm93IHNvIHlvdSBjYW4NCm9ic2VydmUgdGhpbmdzIG91dCBvZiBvcmRl ci4NCg0KVGhlIG9ubHkgc2FmZSBhY3Rpb24gaXMgdG8gYXNrIGZvciBhbGwgMzJrIGRvbWFpbnMg aW4gYSBzaW5nbGUgZ28sIGFuZA0KdXNlIGEgc2luZ2xlIGh5cGVyY2FsbC4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Nov 02 17:39:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 17:39:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436030.690058 (Exim 4.92) (envelope-from ) id 1oqHhQ-0000kF-My; Wed, 02 Nov 2022 17:38:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436030.690058; Wed, 02 Nov 2022 17:38:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqHhQ-0000k8-JA; Wed, 02 Nov 2022 17:38:48 +0000 Received: by outflank-mailman (input) for mailman id 436030; Wed, 02 Nov 2022 17:38:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqHhO-0000k2-4E for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 17:38:46 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 30d6c773-5ad5-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 18:38:43 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Nov 2022 13:38:39 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB6503.namprd03.prod.outlook.com (2603:10b6:a03:38f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Wed, 2 Nov 2022 17:38:36 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%5]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 17:38:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30d6c773-5ad5-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667410723; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=UoTm6DEXNkoE2YHUgbnwgkIb+BKmSM6XeX2yqM43D4s=; b=SNppScUXIDznmYX1Nym7hV6dnFEjMPeAMKwlyUBZyutQSBHJSuIeC6dS bf0NpIfBqWk130WiXwLc6J1+X/yJA8UxA3KG4KmjCXQVg8VTNRM1J26Lx 5SS+Tin5sq0X4Kozmp3hUvHlBZs5EFtEIc/Wh+XfxLbLEYoZItPv26FDp o=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 84461793 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:0959xqkVK5Fs/ecca0ZVJqTo5gxaJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJOX2uBaK2MYzH8e9wibdngp0JS6MWHy9RjGQU5pC09FiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7amaVA8w5ARkP6kS5AWGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 acicRAXZ0C+vMuZx5ucbflzt5gFdMa+aevzulk4pd3YJdAPZMmaBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3iea9WDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnzX+nBttNRebQGvhCnF+36C8/FAIvSnSV8Oe+p3awcPdjJ BlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml6qfS+RffOWECQRZIctlgv8gzLRQoy 1uIktXBFTFp9rqPRhq17ayIpDm/PSwUK24qZiIeSwYBpd75r+kbkRbnXttlVqmvgbXdCTz2h jyHsiU6r7ESltIQkbW2+0jdhDChrYSPSRQ6jjg7RUqg5wJ9IYSjN4qh7AGC6e4addjJCF6co HIDhs6SqvgUCo2AnzCMR+NLG6y14/GCM3vXhlsH84QdyglBMkWLJeh4iAyS7m8wWirYUVcFu HPuhD4= IronPort-HdrOrdr: A9a23:hRBrMK8+gBEiuwUEBqBuk+E9db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdgLNhRItKOTOLhILGFuFfBOfZsl7d8mjFh5VgPM RbAtRD4b/LfD9HZK/BiWHXcurIguP3lpxA7d2uskuFJjsaD52IgT0JaDpyRSZNNXN77NcCZe 2hz/sCgwDlVWUcb8y9CHVAd+/fp+fTnJajRRIdHRYo5CSHkDvtsdfBYlGl9yZbdwkK7aYp8G DDnQC8zqK/s8ujwhuZ82PI9ZxZlPbo19MGLs2Rjco+LCnql2+TFfJccozHmApwjPCk6V4snt WJixA8P/5r43eURW2xqQuF4XiT7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twri+knqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYd099RrBmc8a+d RVfY/hDK48SyLaU5mZhBgl/DWUZAV+Iv/cKXJy+vB80FBt7QNEJgUjtY8id0w7heMAoql/lp v525tT5c9zp+8tHNdA7bQ6ML+KI12IZy7wG0SvBnmiPJ07Ghv22u7KCfMOlamXRKA= X-IronPort-AV: E=Sophos;i="5.95,234,1661832000"; d="scan'208";a="84461793" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GFaroxxkxmuJEmWMPJtgcl+gj6NHN3F8q7qhe52VoVkgZraB1rLgFhdCwfgtt0NbHXzPW0aYCoXtFED5gUzAHl7V1/NugeYCt6PzGfhr5CIemZX9FuzusijP5z6k0tTIA3D8ubNpVT48UtLDvcXgOkSpQCbxR/8/0aNhhr65NLReSXFY4/oE6GVrEZfgd8BhbnBlrEr1jM3zY0C3P0G5vcwyTlhRj/6XNGQYuvgoxgmUvSzJkWCl7L/hZ2OomcI++ExSy1ytiYgq4czFTZKIyjoCfcScTUMClhoC2l5XeM815gVZLlNisXMkfbNO8MaVTpOncOXpeBkQAREegcbC1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o673HJgWK3W6ndtl/OoP3kyH7UmSQIw08cj5zAN14ww=; b=lYzsNlY7+H56pmFyjNH4nc35aOVcdMPGRdrmdOlB9FBbypYejI0YNxpWWgGZjd4fqY0MPhpsvGteyf7mfVIpsFNy5z4O8j6wcxno4QH7SpzIitPlSZbEeCV45myQ5h4dH7q/ByGU52S4mjvBC0fJILkBimkWJyWvsbAD3gLLTdzUTjhdu9NNtA3e97ndyYicSQM7spWN/xkHliqIYS/yjZALdImsH07QK1yH6EeKhJj+NQ43jOIq6VkEaasXklO1rWXm75SUfmZx/8HfVRJY7Yjuxs/Spq95f7QmnCNt9RMFill9xfOtI9L5VS/UrYWQpLYzfGTUBQRVvtd0sFp9QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o673HJgWK3W6ndtl/OoP3kyH7UmSQIw08cj5zAN14ww=; b=ZTlD/qmyGn6dsrR+F/OR+vWdy3nOb1YoNetMVAbnQxZN219r9rqvJG+dSJZUTF6uVl8V0jewFQRm+T8TB62SXR7tr5Tvq1IieqalG7pdJxR2s4ZTwaBIWrYRZ+teNErVWrjEQLYDwh809dZb9CoZBWu6X3hsyY23NZazmBVN1ZA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 2 Nov 2022 18:38:31 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.17 v2.1 2/3] amd/virt_ssbd: set SSBD at vCPU context switch Message-ID: References: <20221028114913.88921-3-roger.pau@citrix.com> <20221029131258.95811-1-roger.pau@citrix.com> <198d04be-e7f2-dc11-18b7-ef3352d07b80@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <198d04be-e7f2-dc11-18b7-ef3352d07b80@suse.com> X-ClientProxiedBy: LO6P265CA0008.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::18) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6503:EE_ X-MS-Office365-Filtering-Correlation-Id: d628de93-a669-4cba-3191-08dabcf911b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fw3kl12kbHZkLPqXvWaSX6nFTSqeYgDpuRrgoNSbNc7q/zQ5e+WOv/kRCb8/1PLcbGqP4eVODUl5UVdlWmCI/HRtsnrQn7tExWe40fZxnf8BpDrbJZW0GmmdrlprZHqQCiiUgmzhsFclwcY1S0I2y+FXSr8hQR/kvD/jfa/trfX/j1mjQGPh9v1bviGZObxs3ZQS/EZIUKF055WJZFoLo8bhfSdZTRJ+67DNPyqULUkZKlqgC00m6tFkS9LhRgSEMCIrzjh8g/2AI8VQy1A3R3ViwVxo+XiaTYgvaNHzFnOBkwqL1I7K3CX4cgZjJjpTVuNl6xz9v6YZwkysEgUsRcUtlzPs8xX3rPC+oZpAG4rQgEq42tlTphHFWftyssEtLp5yovfZgN7CVO5+YZHCKCzhVbn5JGMjPRu//G0yJ7snMo9kM8eMSOOgQhNjBIMJsz4FlGjVKQxOwhBMnc0jhupn/L6ghDw7u4KEwfp2FLlq4YEiyNPwcyliTZh3xK8Cnfy+eZiskgODiSDiwXs4jxaUJqLw2MhdkEOL0JJvaBLHyt1pgdf5SRJyZ9Z1jt3pbN6YlVr1WwkqccRC64ch73sqdAW9ddACzboBsheIwzujtq9buTX8NXCkoTeaNfq0w2cE+6PGk8sQeV0BkCoHjtgXH9AczN0SS7KyJoMb8p7E/xecSJtXwPpEg2R1kAblRqi3c8DToJGaWvxl8liOIxdTmnqEDWXeJgVTpvUy/qqW6yuS04g2dML0zbuQEqrT X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(376002)(136003)(366004)(396003)(39860400002)(346002)(451199015)(6916009)(8936002)(54906003)(5660300002)(85182001)(4326008)(8676002)(66946007)(86362001)(41300700001)(26005)(6512007)(9686003)(66476007)(6506007)(66556008)(53546011)(316002)(186003)(33716001)(82960400001)(38100700002)(478600001)(6486002)(6666004)(2906002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODdoS1JvQmZNRmdTVUplTk82VURmNm9xOGpObS9MOHZXbHFEQWJGQStneDZP?= =?utf-8?B?YTNPZk5QV3ZVMVY5OEVCaUhBeEViRDdnTWZscnVvMmdCbGc4ZkJUZnVDK000?= =?utf-8?B?Ui9pWC8zU2duOXk0a2ZEd2l2VGh4WWZHTlUza0J0OU1vSU5ETGY0M0JwM2M0?= =?utf-8?B?ZVJDVzhqQ3ErUUZUR1BnUGpsTThPcFRlT0NBUnF4YnQvbFloblZjMU4zbXhv?= =?utf-8?B?anNKcDdNTkZ0Z09tYzhHaGxuNmhNejNyQUw0Y1hNam5mV2FnbDJ1ZWtGejEw?= =?utf-8?B?c3dMWnM0aW05NldodllnMkhJRlJYbEFDN2NXWWhvZ05JYzJaTHR3aTk5Sm54?= =?utf-8?B?NEdCN2tRUzhTV1B3Q0ZCLzJBakdZSDBsSmpDZ0h1MXJOWGNvVkdIbkd6Y1A5?= =?utf-8?B?Q0tveDBJbHF0RVlNcW15bjhiNW5FTmdLb1hMZGk5ZDZHVHEwWnNoeWl5Vm1Z?= =?utf-8?B?d3QwM2ZGVFJHVmFYM0svQWtDTU1CbVlmakpwVEhQQWF1NWt6dEkxZ0VmeHcz?= =?utf-8?B?Y3BKNWVkWE9GeGw2bWk2WWU2dXVzYUpmNTkyK2RrVFNMNkg2bE5GY3RNTXJ0?= =?utf-8?B?U1JLVmM4alAxUFVSNDMvVUt4UGc5aXcvNUYwY29Va2RKMmtCUVNRSk5JZlVm?= =?utf-8?B?c0ZJTm1vUlpKR0NoM0NTMUlJU21FTklyNGNjWDRlZDFheVN4eXRvempjNU5z?= =?utf-8?B?TFRoQ1lnSDlMcFlkNzg4TG9TWDBGd01QMU53SDRRM1BUNHR6NmpKV0J5cGVz?= =?utf-8?B?V1pZNXcxdDF4Sm50ZEVNWmVhSzc5b3JDell6amJvMGlPK3BhcE82VTVHU21z?= =?utf-8?B?L3NNR3g1MHl2TGlIY1c2K01OR2tnSFNLMUNSbUpRcWVFUGRwZkRJYXNEdDVk?= =?utf-8?B?MFFvL3Z2RXkzRVF6WmlkUHFZb0ZvVEVVM2hqTnJ6Nk5nM1VDQ2wvaiswWXBG?= =?utf-8?B?WnpqV0tuOXdaUmFzZFBlYktPcEtZS1ZscHFZL3hYK0l3UUo1ZlJRTStjWDIw?= =?utf-8?B?a2plNVMvbTdaR2RGNVNhZk5ySWJmZExkU054cDZ3aUpzQ0d0ajViQWcybjVM?= =?utf-8?B?Tm5BVFRzOVo2cStQUmNzZElSckxKL1V5cHRYMVpia2xhTzQzQ2lkZkdLZFNm?= =?utf-8?B?c1VNSmg2cElrbXBBTU5lUnBYUjllNkJ2VW5YVit5aCsyNFcyemdRN3ZIbUI0?= =?utf-8?B?UHZpcVBTdjlVcTI0bkJXVHkxVWQ1RFRjWWVhRThOWXE1aTgzU1BuWWdrWWZG?= =?utf-8?B?OFYvYnFCTVZhNDVjR0YzRDF1cmY0L3JEcVEwbWFGUG53YmJGWjR6YlByZ1RI?= =?utf-8?B?NVhUeWFWSHNvUEVSOGFpK0h6NnpSZ1NjUVd1eUFoZ1g0ZlhOVzNpLzdhS0Rn?= =?utf-8?B?ZXFaQzdWMHB2SzNmelAvaC9jZmtpY2lDNUtOWjFZV251T2ZzQjZjQ29HZUdO?= =?utf-8?B?amxSdWs4cTkydDhJaktscGNnZTZoNExsZ01DeFlCV3VUeHp6RXdSZ0d0WkVi?= =?utf-8?B?UDFiM0YrS2FXQUpwdm9sTTZ0ZDY1MXpKYkIxTTc1ZW5qdi9TcVJ5dUJ6cFJY?= =?utf-8?B?YzcrSE94YmU3aElqMy9GM2tnZXMzRXExTmhhT3R6WjFUbHBRcGVmZm8xQi9M?= =?utf-8?B?bUdIcjFUK1A5bnU3c1FxY3Jac29zeG1rNjBLMVJxVm9VOW9HMkFSV2xyajJn?= =?utf-8?B?NDN2MlFUSS9WbDJCdmNhQUhzZExrNVAvOFh2UkdPWktGcjRkSmpNVVZyS3JN?= =?utf-8?B?a2NUSkIyNFp2d1dwN3crU2hZRVdIM3hXVTgxaXlWQnA4MDh3NllKOThHZ2pJ?= =?utf-8?B?NUpxNmJ1djhyQVlxWGsrVCt4YWFQeFJJSnN2KzBCQUh3dGQxQXZxYXp5ZS9D?= =?utf-8?B?UkRJZGxYczVSY1lOSkZGNlVQclBZWHhHS0VGaUZBMkFGZlc5RVpWbks0ZFRm?= =?utf-8?B?Q1o2UmI1OHl0V0ZienpNMU9yQ29Jdi9JWDhXY2NKTzQvSmRYYlYzSkN6TUVK?= =?utf-8?B?TE9IWlh3WmJTbUV5TTRTOVMxdEhWcXJRM2FNam9wT2prWDdtdS93dVF6bjZG?= =?utf-8?B?cGdxRXJFRDlIdlJOSE1VRFVpU1dVWlJranpqZTdIOXEwbUdLQnBSUG83dnRN?= =?utf-8?Q?5erlTjDB9VZWnIdG9UjRKpKsd?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d628de93-a669-4cba-3191-08dabcf911b1 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 17:38:36.0282 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qqJmpSCryYJKB2Bp5TgxEnAzOcYQA5vhZAJRyUWvyGSwPTCxc7Ghcn17SEkZHx1xPhFUBo62NEXynz+sODhVbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6503 On Wed, Nov 02, 2022 at 12:49:17PM +0100, Jan Beulich wrote: > On 29.10.2022 15:12, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/svm/svm.c > > +++ b/xen/arch/x86/hvm/svm/svm.c > > @@ -973,6 +973,16 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v) > > > > /* Resume use of ISTs now that the host TR is reinstated. */ > > enable_each_ist(idt_tables[cpu]); > > + > > + /* > > + * Clear previous guest selection of SSBD if set. Note that SPEC_CTRL.SSBD > > + * is already cleared by svm_vmexit_spec_ctrl. > > + */ > > + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) > > + { > > + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); > > + amd_set_ssbd(false); > > + } > > } > > Aren't you potentially turning off SSBD here just to ... > > > @@ -1000,6 +1010,13 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v) > > > > if ( cpu_has_msr_tsc_aux ) > > wrmsr_tsc_aux(v->arch.msrs->tsc_aux); > > + > > + /* Load SSBD if set by the guest. */ > > + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) > > + { > > + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); > > + amd_set_ssbd(true); > > + } > > } > > ... turn it on here again? IOW wouldn't switching better be isolated to > just svm_ctxt_switch_to(), doing nothing if already in the intended mode? What if we switch from a HVM vCPU into a PV one? AFAICT then svm_ctxt_switch_to() won't get called and we would be running the PV guest with the previous HVM domain SSBD selection. > > --- a/xen/arch/x86/msr.c > > +++ b/xen/arch/x86/msr.c > > @@ -697,7 +697,15 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) > > msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD; > > } > > else > > + { > > msrs->virt_spec_ctrl.raw = val & SPEC_CTRL_SSBD; > > + if ( v == curr ) > > + /* > > + * Propagate the value to hardware, as it won't be context > > + * switched on vmentry. > > + */ > > I have to admit that I find "on vmentry" in the comment misleading: Reading > it I first thought you're still alluding to the old model. Plus I also find > the combination of "context switched" and "on vmentry" problematic, as we > generally mean something else when we say "context switch". I had a hard time wording this, because of the Xen/guest vs vCPU context switches. What about: "Propagate the value to hardware, as it won't we set on guest resume path." > > + goto set_reg; > > It's not clear why you want to use hvm_set_reg() in the first place - the > comment says "propagate to hardware", which would mean wrmsrl() in the > usual case. Here it would mean a direct call to amd_set_ssbd() imo. That > would then also be in line with all other "v == curr" conditionals, none > of which apply to any "goto set_reg". ..._set_reg(), aiui, is meant only > for use in cases where vCPU state needs updating such that proper state > would be loaded later (e.g. during VM entry). I thought it was better to hide those vendor specific calls in the already existing vendor hooks (set_reg). I don't mind calling amd_set_ssbd() directly here if that's preferred, it seemed kind of a layering violation when we have vendor specific hooks in place. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Nov 02 18:01:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 18:01:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436035.690069 (Exim 4.92) (envelope-from ) id 1oqI34-0004lo-FL; Wed, 02 Nov 2022 18:01:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436035.690069; Wed, 02 Nov 2022 18:01:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqI34-0004lh-CZ; Wed, 02 Nov 2022 18:01:10 +0000 Received: by outflank-mailman (input) for mailman id 436035; Wed, 02 Nov 2022 18:01:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqI33-0004lE-1m; Wed, 02 Nov 2022 18:01:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqI32-0007Rc-Uf; Wed, 02 Nov 2022 18:01:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqI32-0005tk-Kp; Wed, 02 Nov 2022 18:01:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqI32-0005MA-KK; Wed, 02 Nov 2022 18:01:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xI7POkI9cMcrKicaoSZ1SBvfHViphHXOHJE4j0Jolj4=; b=14827oX73rBDUUunubM89BrGgH NEm67eHqq6g5DEGNTrfby+5owa5N1Lme+lSH8xC0rPgU60jfsJCLTOHcn0Mq2YPuS1nfnfuwXDUjv v8CyFWBEHTF1gDC9fPJhrxW2iksqq37GGMsuXW2XrY7/1viEHIHjUWAf6/i2h/hGYCC0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174576: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=8f71a2b3f435f29b787537d1abedaa7d8ebe6647 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 02 Nov 2022 18:01:08 +0000 flight 174576 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174576/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10 fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 build-arm64-pvops 6 kernel-build fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 8f71a2b3f435f29b787537d1abedaa7d8ebe6647 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 25 days Failing since 173470 2022-10-08 06:21:34 Z 25 days 40 attempts Testing same since 174576 2022-11-01 23:43:36 Z 0 days 1 attempts ------------------------------------------------------------ 1535 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 144299 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Nov 02 18:14:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 18:14:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436042.690080 (Exim 4.92) (envelope-from ) id 1oqIGB-0006dH-Mv; Wed, 02 Nov 2022 18:14:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436042.690080; Wed, 02 Nov 2022 18:14:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqIGB-0006dA-JQ; Wed, 02 Nov 2022 18:14:43 +0000 Received: by outflank-mailman (input) for mailman id 436042; Wed, 02 Nov 2022 18:14:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqIGA-0006d4-Ir for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 18:14:42 +0000 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 38498dbe-5ada-11ed-91b5-6bf2151ebd3b; Wed, 02 Nov 2022 19:14:41 +0100 (CET) Received: from [192.168.100.1] ([82.142.8.70]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.119]) with ESMTPSA (Nemesis) id 1Mnac7-1pHtiV2JQT-00jXUa; Wed, 02 Nov 2022 19:14:39 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38498dbe-5ada-11ed-91b5-6bf2151ebd3b Message-ID: <35fe81de-09f1-ff7f-e5e5-c738ab838d08@vivier.eu> Date: Wed, 2 Nov 2022 19:14:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations Content-Language: fr To: Chuck Zmudzinski , qemu-devel@nongnu.org Cc: Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org, "qemu-trivial@nongnu.org" References: <5f1342a13c09af77b1a7b0aeaba5955bcea89731.1667242033.git.brchuckz@aol.com> From: Laurent Vivier In-Reply-To: <5f1342a13c09af77b1a7b0aeaba5955bcea89731.1667242033.git.brchuckz@aol.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:YmNRBUh1eQf7TTKBM/iVtRO1kaUeOTeXBvFAcaihbFsSqA9ZvA1 kK3Vnmn7mBQtNiaimRCViGQuGDgoXoPI727JQYVauMWJvaMri+Jq37KQW72Ru/oJemiGfR+ qU1VuKqxEbp5wa7xSWf6h3HT6bNJ9vxsHnt9oUm+3X1nBtFtbDPS61DSdRjFmA0PJW/8lPU O+F8V+ZvH3xa2mHlnq9Tg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:AZBiDhr4XXE=:TKhATEVUhaRnQCgM2sVFYM vwhUc2qw4CuFCXsTGsh/SNl25uX6dQmhDFBuw4/t0gx0nGK5vYkQUviabh27PN92q/TLCk4qv Iu+51zTKB84PPMTmE6cz2hVNI70yvz07u+MYkKzCfRYD3McikYH2EsEtTmZFoYO7fReF0HQxz v7XAWUVuym8vFi2ZlnSM0cz938gjQ2+a2UNQ2fbsgXfzimcVCV1GtvE1XksZM7Ak9tMyNbFyV bxRqSi6LfvunZqhznEfQEqT2bOoqvckx3FOgI2YqsECjENPmtDMeDC0ivCuZPEztHIIBoJscP xBwaN/yd42e93AtqTA3+oQvQD//eTF5rD2Rzkurrej26fLK0XTuRYhSgm8VIkBi6c9lZGo++c ziTdV/sY/lVnIdzYaOSGnPMWVOeckJAs//Ap0zByaZlKdwlxG5FJO3LF4Bcyi2SSZfXnhhaAa j0HGBSbIuYz+IXjrGNwb1xhRytfuxgLknMhvksc0aK9f7+2SrN8D1y/ojM/WplaIzB29j0myb /w3beaOFheauZ+MLJTj102mij5hRycMYV//tZ8jNdbpwqfh8QrfnwTMXuygmG+N4rMU+fkTc+ zkXV/vmqYK9lYy0iK+t7cLj1KwjDtgUJz/iOhk1/NU6HeJswR1w/SeRBqB6TTam4vxkYmdY36 BAaejozhRoKu0DLhK/QK4wFk1wxKMmppXsSu4BPU49NQ+EpexilqujTPogBn/x6ovGFs1pLu9 ylHO3nSl+yTgOR7CP4zkBpS4cRxE90q2mv3r+A7dmyBMmqlSDiFkG22RXcGovwraQlchl+4f3 MTxOYLl Le 31/10/2022 à 22:35, Chuck Zmudzinski a écrit : > When Qemu is built with --enable-xen and --disable-xen-pci-passthrough > and the target os is linux, the build fails with: > > meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist. > > Fixes: 582ea95f5f93 ("meson: convert hw/xen") > > Signed-off-by: Chuck Zmudzinski > --- > v2: Remove From: tag at top of commit message > > v3: No change to this patch since v2 > > v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's > email address to match the address used by the same author in commits > be9c61da and c0e86b76 > > hw/xen/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/xen/meson.build b/hw/xen/meson.build > index 08dc1f6857..ae0ace3046 100644 > --- a/hw/xen/meson.build > +++ b/hw/xen/meson.build > @@ -18,7 +18,7 @@ if have_xen_pci_passthrough > 'xen_pt_msi.c', > )) > else > - xen_specific_ss.add('xen_pt_stub.c') > + xen_specific_ss.add(files('xen_pt_stub.c')) > endif > > specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss) Applied to my trivial-patches branch. Thanks, Laurent From xen-devel-bounces@lists.xenproject.org Wed Nov 02 19:26:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 19:26:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436049.690091 (Exim 4.92) (envelope-from ) id 1oqJNY-0008B5-4f; Wed, 02 Nov 2022 19:26:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436049.690091; Wed, 02 Nov 2022 19:26:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqJNY-0008Ay-1V; Wed, 02 Nov 2022 19:26:24 +0000 Received: by outflank-mailman (input) for mailman id 436049; Wed, 02 Nov 2022 19:26:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqJNV-0008Ao-S1; Wed, 02 Nov 2022 19:26:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqJNV-0000R7-Of; Wed, 02 Nov 2022 19:26:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqJNV-0002tb-Cf; Wed, 02 Nov 2022 19:26:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqJNV-0004VL-CC; Wed, 02 Nov 2022 19:26:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Pie7zbm6e2Q5UBN5FIPTB9yMd+Dn/wi4/RyP+wqZjH0=; b=yKDzgBpBlYiuyjfyC9i7xCYWvA 0GwPIS0IAcAiG56B6vMqqTUH2bosh879/tZaj8lzB3a9Y4oVSuoSP2rAEVgnezcAu8HQPYjkx/+EI FRDIqsuwtMmtoksWS2+4nIVDd+Az04GprG2SNElbI/onlAJQVM9dkSwSXFKOf7wYgKVg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174578: trouble: broken/pass X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt::broken:regression libvirt:test-armhf-armhf-libvirt:host-install(5):broken:regression libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=fd97c85b95a6507638a4e8517f8b41330dcca8ed X-Osstest-Versions-That: libvirt=72d4709ab901dd3699d342f15ca3aff9bffddf96 From: osstest service owner Date: Wed, 02 Nov 2022 19:26:21 +0000 flight 174578 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174578/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-libvirt 5 host-install(5) broken REGR. vs. 174549 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174549 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174549 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt fd97c85b95a6507638a4e8517f8b41330dcca8ed baseline version: libvirt 72d4709ab901dd3699d342f15ca3aff9bffddf96 Last test of basis 174549 2022-10-31 04:18:59 Z 2 days Testing same since 174578 2022-11-02 04:20:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Han Han Jiri Denemark Michal Privoznik Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt broken test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt broken broken-step test-armhf-armhf-libvirt host-install(5) Not pushing. (No revision log; it would be 551 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Nov 02 21:03:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 21:03:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436057.690101 (Exim 4.92) (envelope-from ) id 1oqKt5-0004j4-Vg; Wed, 02 Nov 2022 21:03:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436057.690101; Wed, 02 Nov 2022 21:03:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqKt5-0004ix-Sg; Wed, 02 Nov 2022 21:03:03 +0000 Received: by outflank-mailman (input) for mailman id 436057; Wed, 02 Nov 2022 21:03:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqKt4-0004ip-Ju for xen-devel@lists.xenproject.org; Wed, 02 Nov 2022 21:03:02 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bb045e9e-5af1-11ed-8fd0-01056ac49cbb; Wed, 02 Nov 2022 22:03:00 +0100 (CET) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 2A2L2QDf045183 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Nov 2022 17:02:32 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 2A2L2PVA045182; Wed, 2 Nov 2022 14:02:25 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb045e9e-5af1-11ed-8fd0-01056ac49cbb Date: Wed, 2 Nov 2022 14:02:25 -0700 From: Elliott Mitchell To: Bertrand Marquis Cc: Stefano Stabellini , Julien Grall , Rahul Singh , Xen developer discussion , Michal Orzel , Oleksandr Tyshchenko , Oleksandr Andrushchenko , Volodymyr Babchuk , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Andrew Cooper , Juergen Gross Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices Message-ID: References: <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com> <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org> <82c45bc1-6052-502b-3007-8a16fbd1d433@xen.org> <9F323893-B1C9-4D31-9A40-213345421860@arm.com> <947E315E-6537-48DC-8AC6-5218C12B604C@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.0 required=10.0 tests=KHOP_HELO_FCRDNS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com On Wed, Nov 02, 2022 at 08:50:58AM +0000, Bertrand Marquis wrote: > > > On 1 Nov 2022, at 20:25, Elliott Mitchell wrote: > > > > Allocate a domain Id to each IOMMU domain and this very much seems quite > > similar to Xen's grant tables. I'm unsure the two can be unified, but > > they appear to have many common aspects. > > >From an high level point of view it might but from the guest point of view the > IOMMU is something used with or without Xen where grant tables are very > specific to Xen. I do not see anything that could be unified there. > > Maybe I am missing something here that other could see though :-) Imagine a SoC design which has a bunch of cores, memory and 48 IOMMUs. On a particular board, the designer finds they only need 16 of the IOMMUs for devices. Since nothing needs to be done, the designer leaves IOMMUs 16-47 wired together as loopback. ie a write to IOMMU 16 will show up as a DMA write on IOMMU 17 and vice versa, similar situation with 18/19 and all the remaining IOMMUs. Imagine running Xen on such a hypothetical board. If there were less than 16 DomUs and all I/O went through Dom0, the loopback pairs could do a job very similar to the grant tables. Adjustments would be needed to make use of this, but it seems an interesting thought experiment. This requires hardware support with the hardware setup in a particular way, but doesn't really seem like that much of a stretch. Virtualization support has been increasing, so perhaps something akin to a next-generation IOMMU would include the needed functionality. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Nov 02 21:33:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 21:33:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436065.690113 (Exim 4.92) (envelope-from ) id 1oqLMB-0000sM-Bv; Wed, 02 Nov 2022 21:33:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436065.690113; Wed, 02 Nov 2022 21:33:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqLMB-0000sF-8z; Wed, 02 Nov 2022 21:33:07 +0000 Received: by outflank-mailman (input) for mailman id 436065; Wed, 02 Nov 2022 21:33:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqLMA-0000s5-1N; Wed, 02 Nov 2022 21:33:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqLM9-0002gr-U7; Wed, 02 Nov 2022 21:33:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqLM9-0003mN-E4; Wed, 02 Nov 2022 21:33:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqLM9-0005m6-Da; Wed, 02 Nov 2022 21:33:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SvwLHhYWXJMBZprXlLH4JxWhMeyAsYEFVD6el+MOevQ=; b=AKZGoqfLpUJTjymHZgv2Rtj5XH nFEiHu3WYakQjW/gIQaaTkt/nM7BLF9G3S7YSO7knimy3JoupBWeslD3Y4D/trmR1joYnKv8ZMvI+ El282LlJRj3jkcwJZGKBR8qPLUkZMh2TS0RC960hdAajZ2ohPQ9FQR00SUTd8jNdEpRU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174587: all pass - PUSHED X-Osstest-Versions-This: ovmf=957a15adaf72b945d50703977475bf45cbd18c20 X-Osstest-Versions-That: ovmf=b5dbf8267b2596f4a28cdb30d1f533b958ddd4ed From: osstest service owner Date: Wed, 02 Nov 2022 21:33:05 +0000 flight 174587 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174587/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 957a15adaf72b945d50703977475bf45cbd18c20 baseline version: ovmf b5dbf8267b2596f4a28cdb30d1f533b958ddd4ed Last test of basis 174577 2022-11-02 02:43:42 Z 0 days Testing same since 174587 2022-11-02 12:11:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Michael D Kinney jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b5dbf8267b..957a15adaf 957a15adaf72b945d50703977475bf45cbd18c20 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Nov 02 23:59:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Nov 2022 23:59:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436078.690124 (Exim 4.92) (envelope-from ) id 1oqNe2-0003a8-RF; Wed, 02 Nov 2022 23:59:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436078.690124; Wed, 02 Nov 2022 23:59:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqNe2-0003a1-OC; Wed, 02 Nov 2022 23:59:42 +0000 Received: by outflank-mailman (input) for mailman id 436078; Wed, 02 Nov 2022 23:59:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqNe1-0003Zr-Jw; Wed, 02 Nov 2022 23:59:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqNe1-0005DP-Hy; Wed, 02 Nov 2022 23:59:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqNe1-0004XN-02; Wed, 02 Nov 2022 23:59:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqNe0-0006Uq-UC; Wed, 02 Nov 2022 23:59:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nKsVFyYdhF5sMtJhKFeX/X9g688TL6HEWkebApRnoxU=; b=2wpkpYXDS3A3j4wblShHKB2nWZ +UrRjmXKct2MRHRoGK8m6Y0su9hm0EBa8hdarYwUa5vU8NCPYqwqs2wesToqhpjCr9EeM/fihE1nl kqSTP5OImfKbk5j1AIKTAWz7ZJF9CTYa3SSVCbx6xUQX4hn9UqDnLzV1JJbat9wNueKY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174582: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-vhd:xen-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=a11f65ec1b8adcb012b89c92819cbda4dc25aaf1 X-Osstest-Versions-That: qemuu=18cd31ff30883707408c7d6d952310189903939e From: osstest service owner Date: Wed, 02 Nov 2022 23:59:40 +0000 flight 174582 qemu-mainline real [real] flight 174594 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174582/ http://logs.test-lab.xenproject.org/osstest/logs/174594/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-vhd 7 xen-install fail pass in 174594-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174573 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174573 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174573 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174573 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174573 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174573 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174573 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174573 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu a11f65ec1b8adcb012b89c92819cbda4dc25aaf1 baseline version: qemuu 18cd31ff30883707408c7d6d952310189903939e Last test of basis 174573 2022-11-01 15:38:56 Z 1 days Testing same since 174582 2022-11-02 09:34:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alberto Faria Alex Bennée Anton Johansson Bin Meng Gerd Hoffmann Ilya Leoshkevich Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Stefan Hajnoczi Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 18cd31ff30..a11f65ec1b a11f65ec1b8adcb012b89c92819cbda4dc25aaf1 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Nov 03 01:55:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 01:55:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436087.690139 (Exim 4.92) (envelope-from ) id 1oqPSE-0002Tq-8b; Thu, 03 Nov 2022 01:55:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436087.690139; Thu, 03 Nov 2022 01:55:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqPSE-0002Ti-29; Thu, 03 Nov 2022 01:55:38 +0000 Received: by outflank-mailman (input) for mailman id 436087; Thu, 03 Nov 2022 01:55:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqPSD-0002TY-Dc; Thu, 03 Nov 2022 01:55:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqPSD-0006BK-B0; Thu, 03 Nov 2022 01:55:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqPSC-0005RS-Qx; Thu, 03 Nov 2022 01:55:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqPSC-0004Ls-QC; Thu, 03 Nov 2022 01:55:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LM1phNXySqh5dYwqHZ5uLWyFRg6LeriwynlW6vs6eBQ=; b=l/DEk15IreY6diDYLUqoXvQ9iD 2VulrtdnSFJpMfMk2y5QFFb8fZHsM+y9uTWKIryjUlpzLRXqoVMVDZphaeN5ahejscos/4mAkbWfN 4qx75qIubCQVtdQi7F8Yc3MBTJxTlcFzGW17JXefKlBvQHWDXdDR5orAAUtlrsIKJ9D0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.13-testing test] 174583: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.13-testing:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4d753ccf9ddf12332435f50d88e8cf0161e7a5b3 X-Osstest-Versions-That: xen=377dbf9cea55a1976d0957c1f209b083c734c250 From: osstest service owner Date: Thu, 03 Nov 2022 01:55:36 +0000 flight 174583 xen-4.13-testing real [real] flight 174595 xen-4.13-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174583/ http://logs.test-lab.xenproject.org/osstest/logs/174595/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 174595-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174570 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174570 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174570 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174570 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174570 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174570 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174570 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174570 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174570 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174570 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174570 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174570 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 4d753ccf9ddf12332435f50d88e8cf0161e7a5b3 baseline version: xen 377dbf9cea55a1976d0957c1f209b083c734c250 Last test of basis 174570 2022-11-01 15:38:01 Z 1 days Testing same since 174583 2022-11-02 11:38:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 377dbf9cea..4d753ccf9d 4d753ccf9ddf12332435f50d88e8cf0161e7a5b3 -> stable-4.13 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 02:56:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 02:56:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436094.690150 (Exim 4.92) (envelope-from ) id 1oqQOQ-0003X8-L1; Thu, 03 Nov 2022 02:55:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436094.690150; Thu, 03 Nov 2022 02:55:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqQOQ-0003X1-IG; Thu, 03 Nov 2022 02:55:46 +0000 Received: by outflank-mailman (input) for mailman id 436094; Thu, 03 Nov 2022 02:55:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqQOP-0003Wv-Et for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 02:55:45 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2079.outbound.protection.outlook.com [40.107.105.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 00fa87d4-5b23-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 03:55:42 +0100 (CET) Received: from AM7PR03CA0010.eurprd03.prod.outlook.com (2603:10a6:20b:130::20) by AS8PR08MB6664.eurprd08.prod.outlook.com (2603:10a6:20b:351::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 02:55:39 +0000 Received: from AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:130:cafe::b7) by AM7PR03CA0010.outlook.office365.com (2603:10a6:20b:130::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Thu, 3 Nov 2022 02:55:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT028.mail.protection.outlook.com (100.127.140.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 02:55:39 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Thu, 03 Nov 2022 02:55:38 +0000 Received: from 3c41889b9e21.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9524A1CE-82D2-4948-8BDB-1AC55EC908CA.1; Thu, 03 Nov 2022 02:55:33 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3c41889b9e21.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Nov 2022 02:55:33 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM9PR08MB5940.eurprd08.prod.outlook.com (2603:10a6:20b:281::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 02:55:31 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Thu, 3 Nov 2022 02:55:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00fa87d4-5b23-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=liz0AGNoPnZwhlLsyzqWLuhYQmSJJO5rL5rpHaATjeu+BlUM8mx0x1ZVcSFkaMdGMcmcGyJpfUBQ5qIfOtVod6Cv7DydzuXFuKYxXBON+DWL4Q9CYhLrLd4ymWCGvxseWbgBcv1bug9WIALBeLH3NZl7tkH1j0+oZO/BzXbMkB7l9CEXDqs+bij5TepGDEtlz26r4XRoTyZAuH2uqJoLA+J3XcqMeh02c8DEox8IPuPRv7OF/E2RExLbPjVW7NsbEBN+eIq5VAJqm/oEYA9i3yx6mNi2wnFoxGKJnEse7VwzmMAwUhJ0Yy8qxNTHZ1vXyVGZlRYR4Z9emT4NpGhlYg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qIT9LprgSRFBcCa9TxDmUx44WO9AYHASbD+ip3glvVI=; b=bnWKU2Ds7vPCaxwMWHIG8SK76UZvczL1MYE9iznWiXB2/Px8whLD3fZBmT1QZQ8nbMvWIUosU+dUhB3+QC0uDMv7QWE2xol9GBpZyeYKcaeunieoqtgUxIc2djfTHBZprENeZbGLCa14b3vVESNKFKEajyqY2DlEniZcFZAjsji/Bt5pUYOu/+OFSDbEBz8u2M55+0lZcjqpEoNB1qMl/SoKF+bIz7AYOpCFuroKpEDSk3zhHTCPHTu5jDMK3P8chXkLCr4+2/z+vMos2mI/0dabJK8OpGq5eXIUsFVmgRGqad9kZuz3vezKR07N9c254Slln6liVK3Novn4NAb55Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qIT9LprgSRFBcCa9TxDmUx44WO9AYHASbD+ip3glvVI=; b=e1dsSzWATnUiF4CMHY5BPxROz//v2xYQGTi9d4Q4HeAKRIlK7+LvlSTYaqknHqwBlKtreVJERnQoQtmOOXT7kHGunynoLRivyFzVXXsApzYjealnjIbnyKZeFnLaN2KjCnfq+ZRIlpyG1A3nWRR3FK/UmS72M73ooxb+j5sJWwQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AmpaIl3YaRJ2P9obeoClZn9j7hiUSK+xgJB5huoT3A3Lz4O4V4NCH8hmYVmuxpZ5hOJY2DdR7hZpedjjfasO3S7bPajb+NgOQtCs5jAB2KzDOvaV9dRcPq9OmM/bDSQWBGEWw35WeDt7W+8mqptL5Em93so1h+u5LrHxfUNcfw+WuF0R9YtZ15jUh0YtvPCzVFz9AFKZsV9VG8sZZlOb5PyGAkXl6lYtI18Mb/eOk2rv69JApZFAXoKbRGpvfZgDlKfNE094nP5OVUENlHAuHeAp7PTl/JN5kELEwIbYQ/QWq91ujTPitBYkc/Ugt9T1ibEQU0oH5wdfVzs04N2owg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qIT9LprgSRFBcCa9TxDmUx44WO9AYHASbD+ip3glvVI=; b=KURiaMxVsmWCgG3sQSLXETESlAPISGGPF8VzhfMWuT0XtlrlpyqL2Yn5G24aUICwWAu4bGalDxF1mFRlQrXMubKzn/sFjFOWTGc39G5D5rXF1pb/MfmXiDuo8Pu4qRlpq/BsswV1h+FBx09+PzLnTsjw7FhsOaEe1JDGCa2CUhkGdgzFGYP78K8+NpNtblE7aj7r9u5ApxaN43eKL/+B3SIkS/r/iQkpGAcD0onwaRr4YGU/DOCapZN//i/GTp/CFAw+lgYIC4CTVBK8xubk/Oaz+ZP8mwn/1hC9xz/VcrBR8PxzYvjIsdUPq8D8S2AUco75oQR5PMv/N3Wy0CyabQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qIT9LprgSRFBcCa9TxDmUx44WO9AYHASbD+ip3glvVI=; b=e1dsSzWATnUiF4CMHY5BPxROz//v2xYQGTi9d4Q4HeAKRIlK7+LvlSTYaqknHqwBlKtreVJERnQoQtmOOXT7kHGunynoLRivyFzVXXsApzYjealnjIbnyKZeFnLaN2KjCnfq+ZRIlpyG1A3nWRR3FK/UmS72M73ooxb+j5sJWwQ= From: Henry Wang To: Jan Beulich CC: Kevin Tian , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory API Thread-Topic: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory API Thread-Index: AQHY1AgeJwq4WhKefkGyVS1JhkdRo64QKSwAgAG7SUCAAH/pgIAZrF0AgAClVGA= Date: Thu, 3 Nov 2022 02:55:31 +0000 Message-ID: References: <2214fd86-0cfa-58ef-39db-6f913a9de75e@suse.com> <2ee2c1f9-a6bf-7641-16fa-ce2ea90f377b@suse.com> In-Reply-To: <2ee2c1f9-a6bf-7641-16fa-ce2ea90f377b@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 9948C8FCC6AFF74591E9D832BBF4FFAC.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM9PR08MB5940:EE_|AM7EUR03FT028:EE_|AS8PR08MB6664:EE_ X-MS-Office365-Filtering-Correlation-Id: 22f8ad0b-0461-4d2d-1810-08dabd46e3b0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OjVaNiGP3/EEoCsKxXWvxNA70/CM4njNBVL6FvGYt5zFIg+U6tmSuxUrYI8HO3klhA+AHgjbGG5kQJotWUkOCumaFT7xEs9Kr0swatAujrN+zaoWAdnm/8eYPT28X5q7ipzNSxpR+xzsf5DnvAZgsGf/gVw6+Jsp0RLA3uH+/PD8z5N9T39PcEYKrCo/ch5jHasfdtqN9Z4XIVIfBev3IFIQXbZI4SfTU1eEtCq/P3mVEwlprg6kw3HtL15QuVP6XY3+ZkVS1ciiiJY12n/PevCtqTdBbmon5ROOclZ79xfgIYPKFxBIuxyfUg48W+YebVnIGMzL3y43Eth+eMVrH6Q0jpwd9mFfZtdKSAjYdmNFEpQFkjK19yWy8833ojRAgZ/h2+xN6hioCCFaSoU58js0nlBVVfl7p4WwIl48L48SbCW8HkitlPHYozdA/t+tgo1jU9YdMw9yBJfcrlux2paTf5fMVBVd8BEJvWvq7RXamcfaXY3VuFb5gz3LGqhjzj3BmqceDZCxykGe6i5v/RqFcmyaIeiFPkw1MewoOFaDSCdl1C7Ot7C/s41ENy5Abjwm6NmPLbSbKGIy6j6atrdnyXyhTZg6IkRVlXz40s9bh6FJnyM4gMdlFHRLV9Ocaf+mgrQjy0NM1xCGnno+7S+GXD/QY12fm2akT594f9w6yqO4UcbgHPnsbsJNVvsBFBA9FHCGcuUIqc+2cjQZeHps05eb77xXAOh2Q/pTiItlAlT2hOxNpJKAxXtUUEoBq0P+Z41tO/PqUNYiJY1Vhw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(451199015)(38070700005)(2906002)(55016003)(186003)(33656002)(5660300002)(54906003)(83380400001)(6916009)(316002)(52536014)(8936002)(66574015)(71200400001)(86362001)(26005)(7696005)(6506007)(9686003)(66946007)(478600001)(38100700002)(8676002)(41300700001)(4326008)(76116006)(66446008)(122000001)(64756008)(66476007)(66556008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5940 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e997d4f0-3e85-4799-9122-08dabd46df5e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M6zXdjBvYeZDtTwple3BFX2X0hp7VVw2+xksTv2c6JXs3BAdrB9pJVscGY5RY6Y8BuGP5zXhiiPUe8Vyoen+1syamNWqV6TgWn70Lv99sQX1M5f9SNTswJ2/keR/T7n6qXz2hUfsEQenL5c5AjpBTEzis4Gl825zbbZUM8iiIdwg+6FLx1UVtCahY2vBxB25kgiuzN8sWdkTu1I7tOvKHb0yy/fqigfKfd7NKlJEvSkxV2alG1b0DlRLO9uldCfxmEBSrVGlUDFEIfsP+b49Kvy3ro9qmP9xyUm2ARqUitPXDsGMk6TAUZwOF8TXyYmomROyFgLHc18o16gEcp1K+0hyE7xJ/kjdDAs75LFI+sjN0iBSAqdQBn6hE7w8uTAcXG5xxXVVwJi6pGuFNqbQCJOdaPgovmjIbW4ajoO+0WBY0p1vfsuA3lrkRuzE1vd0V/diPzKA2iHRx1OCWvuhbXdP3PPCnx9K+NjupmYygC7BpaZdenuKZroIEVra0qHeuStc1Ym4IV7geiK7oNeGuBvRHsMereMtHgA88hYUNSXbX8/wvE+Q6tTlDWJnxRoUzt46K8H7qNgxDCQsti1KY54vTOHavcMN3G8sozCH5uBPm6HuoSLmyjVeCHsQ59RCsNWdGJdxxj5aHnqkH+UnJ1DmKPfCp8cGcoUPM1MLCg8gbJCr7rg6qRMIpI3r1VCr9fgPuqpbX2X5y/OIpdLjVsy0P3BAnsbd/X53PmJnrnnfyrTNHfd5HJrlntycuKn2dpprG4ufdwLybLix25wvfg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(376002)(346002)(451199015)(36840700001)(40470700004)(46966006)(41300700001)(33656002)(8676002)(4326008)(70206006)(70586007)(2906002)(316002)(5660300002)(82740400003)(36860700001)(8936002)(52536014)(6506007)(7696005)(356005)(9686003)(26005)(6862004)(336012)(83380400001)(40460700003)(186003)(478600001)(55016003)(40480700001)(81166007)(54906003)(86362001)(47076005)(82310400005)(66574015);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 02:55:39.1206 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22f8ad0b-0461-4d2d-1810-08dabd46e3b0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6664 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2OCAxLzJdIElP TU1VL1ZULWQ6IHdpcmUgY29tbW9uIGRldmljZSByZXNlcnZlZA0KPiBtZW1vcnkgQVBJDQo+IA0K PiA+Pj4+IFNpZ25lZC1vZmYtYnk6IE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraQ0KPiA+Pj4g PG1hcm1hcmVrQGludmlzaWJsZXRoaW5nc2xhYi5jb20+DQo+ID4+Pj4gUmV2aWV3ZWQtYnk6IEtl dmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPg0KPiA+Pj4NCj4gPj4+IEhlbnJ5LCBjYW4g dGhpcyBiZSBpbmNsdWRlZCBpbiA0LjE3PyBUaGUgQU1EIGNvdW50ZXJwYXJ0IHdlbnQgaW4NCj4g Pj4+IGVhcmxpZXIsIGJ1dCBkdWUgdG8gbGF0ZSByZXZpZXcgb24gSW50ZWwgcGFydCwgdGhpcyBv bmUgZGlkbid0Lg0KPiA+Pg0KPiA+PiBUaGFua3MgZm9yIHRoZSBpbmZvcm1hdGlvbi4gSSBhZ3Jl ZSB0aGlzIGlzIGEgdmFsaWQgcmVhc29uLCBidXQgdG8gYmUNCj4gPj4gc2FmZSBJIHdvdWxkIGxp a2UgdG8gaGVhciBvcGluaW9ucyBmcm9tIHRoZSB4ODYgbWFpbnRhaW5lcnMgKGFkZGVkDQo+ID4+ IGluIENDKS4NCj4gPj4NCj4gPj4gQW5kcmV3L0phbi9Sb2dlcjogTWF5IEkgaGF2ZSB5b3VyIGZl ZWRiYWNrIGFib3V0IHRoaXM/IFRoYW5rcyENCj4gPg0KPiA+IEhtbSwgbm90IHN1cmUgd2hhdCB0 byBzYXkgaGVyZS4gWWVzLCBpdCB3b3VsZCBiZSBuaWNlIGZvciB0aGluZ3MgdG8gZW5kDQo+ID4g dXAgY29uc2lzdGVudCBhY3Jvc3MgdmVuZG9ycy4gQW5kIHllcywgdGhlIGNoYW5nZSBoZXJlIGlz IGxhcmdlbHkNCj4gPiBtZWNoYW5pY2FsIChhZmFpY3MpIGFuZCB0byBjb2RlIG1vc3Qgb2Ygd2hp Y2ggc2hvdWxkbid0IHR5cGljYWxseSBiZSBpbg0KPiA+IHVzZSBvbiBzeXN0ZW1zIGFueXdheSwg YW5kIHNvIHNob3VsZCBub3QgcG9zZSBhbiB1bmR1ZSByaXNrLiBCdXQgc3RpbGwNCj4gPiBpdCBp cyBxdWl0ZSBhIGJpdCBvZiBjb2RlIGNodXJuIC4uLg0KPiANCj4gV2FzIHRoaXMgbG9zdCwgZGlk IHlvdSBkZWNpZGUgYWdhaW5zdCBhbGxvd2luZyB0aGlzIGluLCBvciB3ZXJlIHlvdSBob3BpbmcN Cj4gZm9yIGZ1cnRoZXIgcmVzcG9uc2VzIGJ5IG90aGVycz8NCg0KU29ycnkgZm9yIHRoZSBjb25m dXNpb24uIFllYWggSSB3YXMgaG9waW5nIHRvIHNlZSBpZiB3ZSBjYW4gaGF2ZSBmdXJ0aGVyDQpy ZXNwb25zZXMgZnJvbSBvdGhlcnMsIGJ1dCBpdCBzZWVtcyBubyByZXNwb25zZXMgc28gZmFyLi4u DQoNCkkgaGF2ZSB0aGUgZXhhY3Qgc2FtZSBvcGluaW9uIGFzIHlvdXJzIHNvIEkgYW0gYWxzbyBu b3Qgc3VyZS4gQnV0IGlmIHlvdQ0KY2hhbmdlZCB5b3VyIG1pbmQgYW5kIHdvdWxkIGxpa2UgdG8g Y29tbWl0IHRoZSBwYXRjaCBmb3IgY29tcGxldGVuZXNzDQpvZiB0aGUgb3JpZ2luYWwgc2VyaWVz LCBwbGVhc2UgZmVlbCBmcmVlIHRvIGFkZCBteSByZWxlYXNlLWFjay4gSSB3b3VsZCBub3QNCmJs b2NrIHRoaXMgcGF0Y2guDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Thu Nov 03 03:09:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 03:09:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436100.690161 (Exim 4.92) (envelope-from ) id 1oqQc2-0005Yj-0Z; Thu, 03 Nov 2022 03:09:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436100.690161; Thu, 03 Nov 2022 03:09:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqQc1-0005Yc-UA; Thu, 03 Nov 2022 03:09:49 +0000 Received: by outflank-mailman (input) for mailman id 436100; Thu, 03 Nov 2022 03:09:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqQc0-0005YS-LN; Thu, 03 Nov 2022 03:09:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqQc0-00085Y-Hu; Thu, 03 Nov 2022 03:09:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqQc0-0000XL-0p; Thu, 03 Nov 2022 03:09:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqQc0-0000O1-0I; Thu, 03 Nov 2022 03:09:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Qsx7vpO+y59ztE9DEwMi/c+5ClDMr/KtvKPXa12FHVg=; b=tuFPU1Dj9C8Hzl9w0Qo9zuHw2W oJA0oLNRKF8ojYs+l7A3QF2z5/yH8JhoBXGnhiXvH3RY4gS4U4KefJbUMsTb2S56Ic/Jlx6yzCxmd y+N8acKYZEtKH1of+S8UWga3bxFKRojvggrPh0ZPxIVmG5hiIorRw9FKXq/ivzIr+krM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174593: all pass - PUSHED X-Osstest-Versions-This: ovmf=c46204e25f5b929fae2b336c03c73fada632d4f4 X-Osstest-Versions-That: ovmf=957a15adaf72b945d50703977475bf45cbd18c20 From: osstest service owner Date: Thu, 03 Nov 2022 03:09:48 +0000 flight 174593 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174593/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c46204e25f5b929fae2b336c03c73fada632d4f4 baseline version: ovmf 957a15adaf72b945d50703977475bf45cbd18c20 Last test of basis 174587 2022-11-02 12:11:56 Z 0 days Testing same since 174593 2022-11-02 21:43:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chasel Chiu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 957a15adaf..c46204e25f c46204e25f5b929fae2b336c03c73fada632d4f4 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Nov 03 04:05:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 04:05:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436107.690172 (Exim 4.92) (envelope-from ) id 1oqRTn-0005iT-4N; Thu, 03 Nov 2022 04:05:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436107.690172; Thu, 03 Nov 2022 04:05:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqRTn-0005iM-1f; Thu, 03 Nov 2022 04:05:23 +0000 Received: by outflank-mailman (input) for mailman id 436107; Thu, 03 Nov 2022 04:05:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqRTm-0005iC-2s; Thu, 03 Nov 2022 04:05:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqRTl-0000hp-Uq; Thu, 03 Nov 2022 04:05:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqRTl-00027F-EV; Thu, 03 Nov 2022 04:05:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqRTl-0002re-E2; Thu, 03 Nov 2022 04:05:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AagYgz89oHKxk+vrIy2bo8OPv8Zi5vXngNRtxCIiHsk=; b=ELYWaglQkXdnW8SXGcT+5Z2EKV zjSk8Po10wgqm2a3jE8YddPBrguNJsIzlNau8BgxkGNdSCJzo518Qad7WxiByFGz1Oa8FL4kp9Ywx 3PvA8G34ktSp4VJ496OMohm6i848Muk1ikQH93IMJjnZ2vI126k7P1V/at0CUZ8biY98=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174586: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2dd823ca7237e7fb90c890642d6a3b357a26fcff X-Osstest-Versions-That: xen=2dd823ca7237e7fb90c890642d6a3b357a26fcff From: osstest service owner Date: Thu, 03 Nov 2022 04:05:21 +0000 flight 174586 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174586/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-ws16-amd64 18 guest-localmigrate/x10 fail pass in 174574 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail in 174574 blocked in 174586 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174574 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174574 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174574 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174574 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174574 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174574 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174574 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174574 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174574 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174574 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174574 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 2dd823ca7237e7fb90c890642d6a3b357a26fcff baseline version: xen 2dd823ca7237e7fb90c890642d6a3b357a26fcff Last test of basis 174586 2022-11-02 12:11:56 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Nov 03 05:02:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 05:02:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436115.690186 (Exim 4.92) (envelope-from ) id 1oqSN4-00061i-G7; Thu, 03 Nov 2022 05:02:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436115.690186; Thu, 03 Nov 2022 05:02:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqSN4-00061b-DL; Thu, 03 Nov 2022 05:02:30 +0000 Received: by outflank-mailman (input) for mailman id 436115; Thu, 03 Nov 2022 05:02:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqSN2-00061O-91; Thu, 03 Nov 2022 05:02:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqSN2-0002A5-6T; Thu, 03 Nov 2022 05:02:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqSN1-0003UN-Q5; Thu, 03 Nov 2022 05:02:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqSN1-0002pr-Jy; Thu, 03 Nov 2022 05:02:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3UmaAgcd4tTd2SW/64ruE3yZNCbhL7LHrDtaE93kgTg=; b=ieeWdtSkf6ZrhUW/eBqkqAbZSn +BwSCQNw+lm8J5PEcQV890qvO2oxbMOhNdc8L86CCnI8aft9RraTwPJOjOzL/UCfCCBIu9UO+UoF0 88duHuJfFBT90GDkTGePPufFI30uOKnGGeeU/nqLPeWHAQ3Z+L/hkMsL1FWbfe5RrjZQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 174584: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6222bb8bd76a0f21048c852acd2542fa2494a907 X-Osstest-Versions-That: xen=1c354767d58cd80224f0dfb107584bc8bd629b00 From: osstest service owner Date: Thu, 03 Nov 2022 05:02:27 +0000 flight 174584 xen-4.14-testing real [real] flight 174596 xen-4.14-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174584/ http://logs.test-lab.xenproject.org/osstest/logs/174596/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174596-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174571 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174571 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174571 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174571 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174571 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174571 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174571 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174571 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174571 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174571 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174571 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174571 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: xen 6222bb8bd76a0f21048c852acd2542fa2494a907 baseline version: xen 1c354767d58cd80224f0dfb107584bc8bd629b00 Last test of basis 174571 2022-11-01 15:38:01 Z 1 days Testing same since 174584 2022-11-02 11:38:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 1c354767d5..6222bb8bd7 6222bb8bd76a0f21048c852acd2542fa2494a907 -> stable-4.14 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 06:59:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 06:59:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436125.690197 (Exim 4.92) (envelope-from ) id 1oqUBl-00057l-Ss; Thu, 03 Nov 2022 06:58:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436125.690197; Thu, 03 Nov 2022 06:58:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqUBl-00057e-QL; Thu, 03 Nov 2022 06:58:57 +0000 Received: by outflank-mailman (input) for mailman id 436125; Thu, 03 Nov 2022 06:58:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqUBk-00057Y-U7 for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 06:58:57 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [85.215.255.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fac11bef-5b44-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 07:58:54 +0100 (CET) Received: from mail.onlineschubla.de by smtp.strato.de (RZmta 48.2.1 DYNA|AUTH) with ESMTPSA id U559b8yA36wrPKP (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate) for ; Thu, 3 Nov 2022 07:58:53 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail.onlineschubla.de (Postfix) with ESMTP id 3DDDB201C6 for ; Thu, 3 Nov 2022 07:58:53 +0100 (CET) Received: from mail.onlineschubla.de ([127.0.0.1]) by localhost (mail.onlineschubla.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iZOmTMO2LQqH for ; Thu, 3 Nov 2022 07:58:52 +0100 (CET) Received: from [192.168.178.167] (unknown [192.168.12.2]) by mail.onlineschubla.de (Postfix) with ESMTPA id 4766520157 for ; Thu, 3 Nov 2022 07:58:52 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fac11bef-5b44-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1667458733; s=strato-dkim-0002; d=onlineschubla.de; h=In-Reply-To:From:References:To:Subject:Date:Message-ID:Cc:Date:From: Subject:Sender; bh=HL5Rs1p4VGc86jYsZXj8jtLsWSZG7/oFL/FWfFH+RzY=; b=KnCgqQSP96edQgD3epReU4cvuNr7zev1c97DU2L/CMt524hloWr6z1wZLD0NJACDoT x0uDdzmjD0Nnx5fzQdnRkGwraNc7pxKTolTZA+1waa7R3dvDIFNLIkiQN6r8IzgCqJ4d jNiW9EHPYqO/eAD1gjqlsin2A1mhWoG+YEAxS9+RFG9j2pKKg3PTsWmlJJcI0ULu7OwC OiDsEG43tt7wmBRBOKACGk9OHD9CSLk3b9BRgaOrUen9/ZQZXEUGuN3orUPXyxksY61r 1SjtCpW1MUDZx0A8dlmqJmk7dP+tu3rLEHKjCVk1WO8wOVau5YEiPO9tWYPJA+DZRmEt +6Dg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":PG0ReWCndfO3rCSML4AvNaDxJ7WJyilEI/NMX3IPsStZLbcZC9mNZx0oO96cCwabxEcCkdg/gSnE" X-RZG-CLASS-ID: mo00 X-Virus-Scanned: Debian amavisd-new at onlineschubla.de Message-ID: <735adbe4-238b-bb7b-ba91-eb53759223aa@onlineschubla.de> Date: Thu, 3 Nov 2022 07:58:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: Possible bug? DOM-U network stopped working after fatal error reported in DOM0 Content-Language: en-US To: xen-devel@lists.xenproject.org References: From: Paul Leiber In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Am 30.10.2022 um 17:36 schrieb G.R.: > On Mon, Jan 10, 2022 at 10:54 PM Roger Pau Monné wrote: >>> So looks like at least the imbalance between two directions are not >>> related to your patch. >>> Likely the debug build is a bigger contributor to the perf difference >>> in both directions. >>> >>> I also tried your patch on a release build, and didn't observe any >>> major difference in iperf3 numbers. >>> Roughly match the 30Gbps and 1.xGbps number on the stock release kernel. >> Thanks a lot, will try to get this upstream then. >> >> Roger. > Hi Roger, any news for the upstream fix? I haven't heard any news since... > The reason I came back to this thread is that I totally forgot about > this issue and upgraded to FreeNAS 13 only to rediscover this issue > once again :-( > > Any chance the patch can apply on FreeBSD 13.1-RELEASE-p1 kernel? > > Thanks, > G.R. > Hi, I want to confirm that the patch in an official release would make quite some people very happy. E.g. among OPNsense users, there are some who suffer from the network issue [1]. FWIW, I compiled a kernel including Roger's patch, and it seems to be working without trouble in my OPNsense DomU. Best regards, Paul [1] https://forum.opnsense.org/index.php?topic=28708.15 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 07:39:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 07:39:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436139.690208 (Exim 4.92) (envelope-from ) id 1oqUog-0002eb-Vf; Thu, 03 Nov 2022 07:39:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436139.690208; Thu, 03 Nov 2022 07:39:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqUog-0002eU-Sz; Thu, 03 Nov 2022 07:39:10 +0000 Received: by outflank-mailman (input) for mailman id 436139; Thu, 03 Nov 2022 07:39:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqUof-0002eK-96; Thu, 03 Nov 2022 07:39:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqUoe-00053o-VL; Thu, 03 Nov 2022 07:39:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqUoe-00047l-IP; Thu, 03 Nov 2022 07:39:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqUoe-0004PQ-Hv; Thu, 03 Nov 2022 07:39:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JD98hU2qTO0n9bq5/pnvwNdDRYXq4FErV3PT3pEeXns=; b=AFXZPSJ6YDynoWNehuYR2UaUUD ukWqkVns4ren8xdcIPlnGPJGPCtJmpfPW7xfWiyGfedfqisMbvW4WHk31763Q/HF/oU7/Cz+Va58N CnvYJ51Ihqwc3FwQwcF/XEQSBeIL6Oyt1iQeslexEFF1He5eWidrQ/OqOQFEJQ8riXJ0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174590: regressions - FAIL X-Osstest-Failures: linux-5.4:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=5282d4de783b727f9e5e6e90d90a3eff53ef5c31 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Thu, 03 Nov 2022 07:39:08 +0000 flight 174590 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174590/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 174540 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 174575 pass in 174590 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 174575 pass in 174590 test-armhf-armhf-xl-rtds 14 guest-start fail in 174575 pass in 174590 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 174575 pass in 174590 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 174575 test-armhf-armhf-xl-vhd 13 guest-start fail pass in 174575 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 174575 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 174575 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 5282d4de783b727f9e5e6e90d90a3eff53ef5c31 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 4 days Testing same since 174575 2022-11-01 18:42:39 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Greg Kroah-Hartman Yongqin Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 5282d4de783b727f9e5e6e90d90a3eff53ef5c31 Author: Greg Kroah-Hartman Date: Tue Nov 1 19:06:42 2022 +0100 Linux 5.4.222 Signed-off-by: Greg Kroah-Hartman commit 59f89518f51004bcdb05a92e462e2298989294f9 Author: Greg Kroah-Hartman Date: Tue Nov 1 18:12:39 2022 +0100 once: fix section mismatch on clang builds On older kernels (5.4 and older), building the kernel with clang can cause the section name to end up with "" in them, which can cause lots of runtime issues as that is not normally a valid portion of the string. This was fixed up in newer kernels with commit 33def8498fdd ("treewide: Convert macro and uses of __section(foo) to __section("foo")") but that's too heavy-handed for older kernels. So for now, fix up the problem that commit 62c07983bef9 ("once: add DO_ONCE_SLOW() for sleepable contexts") caused by being backported by removing the "" characters from the section definition. Reported-by: Oleksandr Tymoshenko Reported-by: Yongqin Liu Tested-by: Yongqin Liu Cc: Naresh Kamboju Link: https://lore.kernel.org/r/20221029011211.4049810-1-ovt@google.com Link: https://lore.kernel.org/r/CAMSo37XApZ_F5nSQYWFsSqKdMv_gBpfdKG3KN1TDB+QNXqSh0A@mail.gmail.com Cc: Christophe Leroy Cc: Eric Dumazet Cc: Willy Tarreau Cc: Christophe Leroy Cc: David S. Miller Cc: Sasha Levin Cc: Nathan Chancellor Signed-off-by: Greg Kroah-Hartman From xen-devel-bounces@lists.xenproject.org Thu Nov 03 08:10:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 08:10:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436151.690222 (Exim 4.92) (envelope-from ) id 1oqVIK-0007oW-SQ; Thu, 03 Nov 2022 08:09:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436151.690222; Thu, 03 Nov 2022 08:09:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqVIK-0007oP-Pf; Thu, 03 Nov 2022 08:09:48 +0000 Received: by outflank-mailman (input) for mailman id 436151; Thu, 03 Nov 2022 08:09:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqVIJ-0007oJ-E9 for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 08:09:47 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e0639bfd-5b4e-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 09:09:45 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8220.eurprd04.prod.outlook.com (2603:10a6:10:242::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 08:09:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 08:09:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0639bfd-5b4e-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nSkZX6phjw3y0cfMsUcoIEZi6zt57DMKYPqMp6LJOeC1zTiwrJBaGOgveMKm/8kgwcIkP3sC+H7u89TtcID4M0X/cmNNWBBl5jvIQiyqzYDbfNz/UdggcN0TF80YqBbGdoVQ9SuyeU+gC5NErV5yMm2XPmw9xHv6XVOcxkw1SOXgQGKXTxYrpVJMkokzAm8mjdbkz1vw19tcTD6bMXC09kVc5MPVwlrR8M0TtAmoG8omrjgllPOM2DezfsKQ9u316o5Je8gXVZ8x8e+OIGo4iyIfiNMiZRR0J3fU7vlJy9kAwbjb4t70xvHbINuH1PnPFrM2cLvJ2iTDZXrkUDBUQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iiYtT3YjCmRsXNtJCT7zFffOR6d2OnrN/dQgPKbsIkk=; b=HYRVNUGuAD0V+rvDeQMM5dW4Jd6CpDYlEsL7ucpmfCvrLfJsTZU6frgHYelOlh3BIJxbwoQ8wMhh+jPGmM/huqz9/xAS0JOBoQkNMMhFrfdSghfnSfRYDpSQIVK+YrpvMkHr+fHh3pA//OZyYkEokR1bj0sex+E0s9XY8aVrpZjp7Bk5wSs655YZXtPvJbYdQnIJ8OzMwZIKrNsTjXPqN9DPr5tA/Y/1EJHZQsZbYVurysE4vq4QkStcqwGeWKenrQ4F8Q2tG+reVbqEJqwIYT3SjgV1Jvx0uFEBepMpXrJjKxOWv5kSv1/4G59FPvkUL3aQbonqiLC5wXaFGZlKSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iiYtT3YjCmRsXNtJCT7zFffOR6d2OnrN/dQgPKbsIkk=; b=2BbqHAkkRQKIOUlLUjm8QujDLF8fUzpav9Ao8bRj6AnOit81bwIQ/VBI2Mle2Q/hVGmWGMnXGEY62HsOeBdbOBdQvaRvK/RPW316+AFfgCFszdrWlZ2NY2zLEcGWY7pdUGguPcuRpRfythlcYhxtqDVQ1J/q8GwbdcYWpHXhHkVybZyqv5aRAWFy6tDazc2wJ0KlBaLJr79B8v24bSeexuxVdNQ0F/hEMpWX1sTG3AkWkqtU0kLde8Pv+nvPmP6yCkT3HtCGKZityWka9/7ERuLjCSyvFly4UNG8FppjfNiuC/ECd8I/YjqqpYZZG2rw7FfVtJOIJ69SJOH1WOzxQA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <20869a2c-224e-698a-b927-96d6ad752b9a@suse.com> Date: Thu, 3 Nov 2022 09:09:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 v2.1 2/3] amd/virt_ssbd: set SSBD at vCPU context switch Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20221028114913.88921-3-roger.pau@citrix.com> <20221029131258.95811-1-roger.pau@citrix.com> <198d04be-e7f2-dc11-18b7-ef3352d07b80@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0053.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8220:EE_ X-MS-Office365-Filtering-Correlation-Id: 532ad07e-76bf-4b83-3942-08dabd72c375 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X0/xizwWvS5ZkRoIoVtDHouekdgOJLV6TYS10GQ6H7hyT9XAvDSZ+xMjFZQCsBQ+hduNxOZkSLKf0pCOC0XyN79/io3mqDBMqSz51AdGey7/l+oz9ZOEMOesANOumg9V9NpUDGMmveOeLtC51OO0n+ucZwQLRzr5cC2DxlhnPmzHDZEwKZ9NvKPzkzxac49SFPOZsJsXi3jXfnK3sf7kR13ykpeuMEv5N89lrU6AlOPi9X/P3UTZWOiTeJjplXJ5MdNUqtgrNZ9XbN51DFiuWeDo8RmBcqc8WKQ8YV3srvTYbzwNmkYB7J4B8fkng02o46MUyReYFBuCWB6k6EstHR1DDXFIwgWvvrdIVZ+FXMySM612XHtlYvfQep0vfS5VE8wKjtMqFMPyS7tIYAshj8HUUQORdSR7LXQn9joVFJG4SS4jkEQyyGxFZ3W38RaNiuukPDSNxiQktSZovtUwMROAyrkm9C8UH2O/AeQy1A9iT1np45S/U3uUm+FNDY1u4Di+GbAqf1lg3ZOkvjXx0VlIo8zClfxxS4sVQo9guUwWwo2WIbi5gN1b4ephQIlX/uhKrVy+6z65SUGBsIGhl1nKrYplsuhPmMFUvydm3SLcWDn2p552lin4GzJwBQ75HBJ8XR9zL+h4VPCMoQbDFfpOTtUxAsgZDKdQvX7boSSXLKVhpepcgagq7zhJ5rUB2tMtpIbdkdGxWZWmM2rr1s3aJBO7CCjWVRwudxBJ9EQCdbuhTUc+L/TkfDQBrkeQZSXen7il8RLS7kmz48PQ0MDous7MHqjd9Y+jXsjFXAw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(346002)(366004)(396003)(451199015)(36756003)(86362001)(31696002)(31686004)(38100700002)(2616005)(186003)(6506007)(26005)(53546011)(478600001)(6486002)(41300700001)(6916009)(316002)(66476007)(4326008)(8676002)(66556008)(54906003)(6512007)(8936002)(5660300002)(2906002)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VENuZitZR2RVU0FXQkd5L1ZrNFAxeU5ta3hQZm1DSTdJeUdab1Z5UzJteEk2?= =?utf-8?B?VStyRGJaZUZySHdiZ0x4SVNKT1d0YWxNMFJxbHVYT0FwOGNtUnEzcHpwYXRK?= =?utf-8?B?WTBtaTN4cVZSSkZOcWYydEsxb0JlZXFaSVp3aVJ4OXZVOEZpT2huZmN2angr?= =?utf-8?B?VEVSZEVrR3BRZjRzRnY0TUhkKzc2UXVSVllXSGE1b1l1K1FQTWFsa2dIdVpG?= =?utf-8?B?b2UzWmhLeGprUnZEaGs1cFdlV1NFNCtmSzF2TEhUMmY4dGtiYTRKb2JUNlVR?= =?utf-8?B?WDV5T0JwOGVIdGNLMHJtUzRCSUtPZnhLQS82SkZMU2g2YzIwYjBoTSs4eG44?= =?utf-8?B?YlRGUVJxSTdhcFJZV2VVVytGRjdOUkgxRWlFdVg3TEhnVnJrT2RFTGlZYzdC?= =?utf-8?B?b1RBSElnR1k2Lzd1dnFtT1Qrc2VNR01vQUtIQjdqTnJTQTlydFRPVE5YZGNC?= =?utf-8?B?TnZvYzdNV0czOENCQTZzZG4wQVIrYm1yZDR2U1lFc2w4L29UNllxU3lxSFM4?= =?utf-8?B?LzVkQUs0dUFqYXdlUEtrdHZ6ZzFZVUk2OXdqdzBYN2Y4M1ppL2FtU3NhT2dC?= =?utf-8?B?eGhlYU50WnpzS1BUTldxU0VSMGJqM0M1eGN3eVJUMkVKSUZqcFhPdjhwUm9K?= =?utf-8?B?THhsdzZEeWhGUEllTlRBOFQyRlhUUTJvTzEzZzhKeVdFMjJjVTVqUVVUSExN?= =?utf-8?B?RHUzRTZpMjBPTHF5cTNvOHZyZlFCWU5DVmpmaVorMHEzOHFZUC8ybEZ0bm1h?= =?utf-8?B?QVJ1YjlNRlhKMnVjcXJENHNHSjdyRVZ6R1lMdkkxY3RJbGNoQjhxR3AzUUl3?= =?utf-8?B?TC9hNm1hSjRrK1FqV1JQYVl6WFJ1dDQ4R0taa0QvSXo1UGZtYWhEN0QzZ281?= =?utf-8?B?NUQ5Zk9LOXBHWktLVHgxOENOZEtXdXp6K3U0NWtVU3ZBZlpJbnZ5Ly9LOTFJ?= =?utf-8?B?Q3A4bzhBWGs5eWxlS2Y1cnlxQW52NFdHaVp4ZXk1MFMxcHZBajNLZVBIcjR6?= =?utf-8?B?Y0hSOW5jMVJXRUJYOENFRXEyeDlxMjh5NzhrRExiZkdNYUVFQWd2YlEvWmpF?= =?utf-8?B?NVNGaHlmOTY1eGROY2RUT0pmQmQweXRzZlo0bzM5MzlLaDRyOENCdDhrcE0w?= =?utf-8?B?MTZxVlVuM01JRlFjaHRiWkoyQk12UkRRSWlUS2pvWjZmZE9GdEdKV0tCRUtF?= =?utf-8?B?UTE2VXhkWmlKM2Znb2VpRjlVUUM0Q3hBbENqc2NBdFd3TUs2RnA4K1NmU1Rn?= =?utf-8?B?cm1hSHltUGdQUTdxZVBZdHFQTkxxMmJVN3VXNWM0akVFYms2RzYrc0QzdFAx?= =?utf-8?B?dmFPZVB0bTVyVStVeGJ5YnV5dHhFTEFYei93cmlDZEE3TFJxWm5ZNFRHRHZj?= =?utf-8?B?TFBFaGtiRzZrZmVsMk0wSmk5a2xoMGwxQkh5M3pEakFiZkkzTkxlbVFCUFZ0?= =?utf-8?B?bVJhRW1EazIxcUQrVEtrQ3pWWVhjakM4NEJLMjF3a0JVWitPTUZvMmtGb0RD?= =?utf-8?B?WExuaVJjQXFUOWFmQ2ZmM3U1RFQvSmtQSVhndkUxblBOcU02MnlEWFh2d2Yw?= =?utf-8?B?R1VrV2RrUkZOcGZOck9paEh4RFJaY0hmRFhWK1JPUm1xZnIzYm51TGhWNWFY?= =?utf-8?B?Wk5JQW9vR2hyczc1Nk5xa1RXbDBEbElEYjIvK3l1Nm9YaXVFL1VFSkpkRnZq?= =?utf-8?B?djViWm1qeHF3WUIyai9kWm1mOGJqK0V0VXpwTGRJc3dLblF1ZlN0d3FONWhu?= =?utf-8?B?SHBEZDhxYytRVTBvb0R1S0FBZVVaRm4vYWZJY1RSVlM0Y3FlTDUyUXlFRkpi?= =?utf-8?B?c05BZWRjdDFRcGdsU2VjNzRXWnVhWHRTMmphaWVBVDFwakxHRW9mWFpBMlJp?= =?utf-8?B?VTl3Tjd3NTlDaHlZYUlXODVIaC9pNEdlVFhQeFJWL003OWIxOUtKWE9EUEor?= =?utf-8?B?aWUreDFFWlZQM253N0N1a2ZKRzY0blMwTlMzb3RVcC93RnhMdFFyYlRmcmw4?= =?utf-8?B?NDBJSnBjd1hCVEgvdXNpUlgwc3BmOUFrRjR6ZUttbmhvZGRoaVRxcFlrNXNl?= =?utf-8?B?bTJBN0dWbE9iSWRuRUtkNGdzdHpKeHEyRStIbDk1UUZmR2MwTmRuWmlJeW9E?= =?utf-8?Q?//2QiWIFsLuaHy/K+0zkrGcaK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 532ad07e-76bf-4b83-3942-08dabd72c375 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 08:09:43.0757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nlo/KxqJEbRadD7Go3wnzFraswlPOc3NGhuxv7XpHxN3wuct2gNox34+b0YE4D03qwJbdqMJrh+P3k0nOdl1UQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8220 On 02.11.2022 18:38, Roger Pau Monné wrote: > On Wed, Nov 02, 2022 at 12:49:17PM +0100, Jan Beulich wrote: >> On 29.10.2022 15:12, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/hvm/svm/svm.c >>> +++ b/xen/arch/x86/hvm/svm/svm.c >>> @@ -973,6 +973,16 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v) >>> >>> /* Resume use of ISTs now that the host TR is reinstated. */ >>> enable_each_ist(idt_tables[cpu]); >>> + >>> + /* >>> + * Clear previous guest selection of SSBD if set. Note that SPEC_CTRL.SSBD >>> + * is already cleared by svm_vmexit_spec_ctrl. >>> + */ >>> + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) >>> + { >>> + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); >>> + amd_set_ssbd(false); >>> + } >>> } >> >> Aren't you potentially turning off SSBD here just to ... >> >>> @@ -1000,6 +1010,13 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v) >>> >>> if ( cpu_has_msr_tsc_aux ) >>> wrmsr_tsc_aux(v->arch.msrs->tsc_aux); >>> + >>> + /* Load SSBD if set by the guest. */ >>> + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) >>> + { >>> + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); >>> + amd_set_ssbd(true); >>> + } >>> } >> >> ... turn it on here again? IOW wouldn't switching better be isolated to >> just svm_ctxt_switch_to(), doing nothing if already in the intended mode? > > What if we switch from a HVM vCPU into a PV one? AFAICT then > svm_ctxt_switch_to() won't get called and we would be running the PV > guest with the previous HVM domain SSBD selection. Would that be a problem? Or in other words: What is the intended behavior for PV? PV domains can control SSBD via SPEC_CTRL (only), so all we need to guarantee is that we respect their choice there. >>> --- a/xen/arch/x86/msr.c >>> +++ b/xen/arch/x86/msr.c >>> @@ -697,7 +697,15 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) >>> msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD; >>> } >>> else >>> + { >>> msrs->virt_spec_ctrl.raw = val & SPEC_CTRL_SSBD; >>> + if ( v == curr ) >>> + /* >>> + * Propagate the value to hardware, as it won't be context >>> + * switched on vmentry. >>> + */ >> >> I have to admit that I find "on vmentry" in the comment misleading: Reading >> it I first thought you're still alluding to the old model. Plus I also find >> the combination of "context switched" and "on vmentry" problematic, as we >> generally mean something else when we say "context switch". > > I had a hard time wording this, because of the Xen/guest vs vCPU > context switches. > > What about: > > "Propagate the value to hardware, as it won't we set on guest resume > path." Sounds better, thanks (with s/we/be/). >>> + goto set_reg; >> >> It's not clear why you want to use hvm_set_reg() in the first place - the >> comment says "propagate to hardware", which would mean wrmsrl() in the >> usual case. Here it would mean a direct call to amd_set_ssbd() imo. That >> would then also be in line with all other "v == curr" conditionals, none >> of which apply to any "goto set_reg". ..._set_reg(), aiui, is meant only >> for use in cases where vCPU state needs updating such that proper state >> would be loaded later (e.g. during VM entry). > > I thought it was better to hide those vendor specific calls in the > already existing vendor hooks (set_reg). I don't mind calling > amd_set_ssbd() directly here if that's preferred, it seemed kind of a > layering violation when we have vendor specific hooks in place. Well, Andrew of course should correct me if I'm wrong, but my understanding of the get/set-reg interface is as described. On which grounds I don't see any layering violation here - doing the call right here is merely a more involved flavor of wrmsrl(). Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 03 08:48:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 08:48:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436157.690233 (Exim 4.92) (envelope-from ) id 1oqVtl-0005Md-WA; Thu, 03 Nov 2022 08:48:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436157.690233; Thu, 03 Nov 2022 08:48:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqVtl-0005MW-T2; Thu, 03 Nov 2022 08:48:29 +0000 Received: by outflank-mailman (input) for mailman id 436157; Thu, 03 Nov 2022 08:48:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqVtk-0005MQ-Jm for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 08:48:28 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150085.outbound.protection.outlook.com [40.107.15.85]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4709432d-5b54-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 09:48:26 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8834.eurprd04.prod.outlook.com (2603:10a6:20b:42d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 08:48:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 08:48:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4709432d-5b54-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PjE8DBIj4LR+RT1euuh+lU+z422amGx86uauBCdOPfxaGIE9+ADF2HY++QUn2fn860xO/fbQ/qjHeTaIdTQpNtNooPGOzrdIMjRMwOPJhC5c7JaIrf4q3fv7dE6rVRVOTS7MsuTXGpxocSOu0HMKlmLoHQr5x+VMUOtbHKv5L5RpEheJBmtGFxG45nqrl5ALfjfkzwMYKpGF+x0rQweGKDPsPHgWX5KmVeospdzTLWFegVddGAyLZIM1OG/HDF2s858J52Ah1WqdAML3q8qBUAM2GVFQ5JnZhRigbEqqCejOrjpjpDupT/hqJV3K5eM9H5LWCdoVVrNMVW2H5QmP0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xi1pBCMH3iFyLLmMgDBJQHipe45LdC7rPoIOb0Jln7Q=; b=LfVIUS9bqcp+Rm0jtVH/DHgrJs++yyL8Gf4cDBVNpMeWLDeTzPfeJqJKH3tTeEkNNPRL+AhQW5moe1nCga46IeUsCCuZoVpGhPVkmx54Qe378vu29dwud4/87uOKlYHRKkP1OCS+bkUULODwW19lz4QRm/q5XTr06oJ748Z2x1e7L4RyoZE72C7YFyc8Uze66eNwr4fWqAyDtYGM7YNbHwa15x3Ss0wALQ1WgHvTRD5E5L+0w5ZrakXKoZkulRJu+V8bhbskIJWY9uMZha5fPNO5Qcoxo8bDqcmPqWTSlezwyVVhADPJkVS9mno9jU3uHIjVrggBeCVHkmUMvYcHGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xi1pBCMH3iFyLLmMgDBJQHipe45LdC7rPoIOb0Jln7Q=; b=14D2/wFah+SYC3M3MYxQULSgIrkm2lrRfoxB43/LRI/j/9zAMQ6ngzbphJoSKHBj4Vo8+ztINd2EGeAxKZb1JuKohPkHYyvjRWxQn7xJFzhZAhJeR9Hi9XGaYpPAdtVB7TcBqvOkhyOPVhKu7FtHEvPAFJgvKlbUy0gf3RMBd7LRRN+RMZ44qpcQg65SyPEkICFJJQYVx8Ofv5VjnRtEN7j17RQYmhnBuKIWsO509dIUNuX4KkBjz0O6niTbYBvfbF/YWYTJCU2eYjeOOspxYwqNqPjEehI0UBPS1eCKE8KQTAFfRAmbVP3cj43f6dyhUTzYJhWPPgHrhp2W59d99w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 3 Nov 2022 09:48:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: x86/HVM: Linux'es apic_pending_intr_clear() warns about stale IRR Content-Language: en-US To: Andrew Cooper Cc: Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <7d9022ce-4a46-e0cb-67c3-4124e1c0d2db@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0154.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8834:EE_ X-MS-Office365-Filtering-Correlation-Id: 4fcd1651-c23b-45b5-8329-08dabd782a0c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v2xb+lAeh1E+Zh+1f3A6iL0JTcHuulnY5XUQSzHH+xAkErSejNA7XXEjr3/aE8raFUQ7Th1YThuMupfNgLC3uMewk0nRP85rYO+edlEmYP40kP6mYSlIr4rEbWQl2F18RDTpMi6/Sc6KfBqFsWgoB3Qo/u9PsPp5K06cVpFVbxFweX3CdvXh6qKORAIlLkwrDmEVxDu7rhh/g+PC4laPo8lnNLUMZTH8as1sWXMfLzTb+WruP7o7GmJkEVDPNUsCipi7j7WF9wqFSJLdDpTYH+OWAkBb1KhLSD8lNrjWwdqbMXFhXLdfJ311TpEFwJEE6S3tLziO/EBeVyapDTvenTXq3PeIA1S/QMJITrXqS+QWHqJSs15pAg3WUJMnF+CntU+UaBnPGIYFrF129Byv8Yl4xK3mN3gunS8BNn/aDGucH1IW20j5sMKOx3FT+udZhl1DRh55FLs61evYFwmO1IOQid62NaRDNYbtgj+DqCKt7g6FYu+jGhMCDegAxtWMBkUZpNWbWLqFP+9heD+22HZksvsKtPyaZBq23OoZOJGlaYJC2Wk29IiOJCqY6u+GlOoBTcXkWcS6qQcZ10w61fjPizDuZC4TgAnE/8Y55PlHMQyRLu8KYCvUMaRNKOzFpxQpR37EYQU0FYaNNeyViXx0pF14eFGWdIY6jDYrVrREpeOjbIeP9wmSa2l0yqH2npsi8OLhEAXY8B07R7OGyD4nCzj0TkYbp0LZk4KboIBsycyCyqL1GfVFroz6l1KsUjiLFLBZ0vu3qbxd9pWDC1Rcjsa4JdKtMk8zbk4Vw7E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199015)(6512007)(31686004)(316002)(2616005)(6916009)(66556008)(8936002)(8676002)(41300700001)(2906002)(86362001)(4326008)(5660300002)(54906003)(66476007)(66946007)(38100700002)(83380400001)(36756003)(186003)(31696002)(478600001)(6486002)(53546011)(26005)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTJQd3lUc1V6K09Jc0ViR3ZpYmkrQU96Y3dIVTBGbC9BMjdaVHNIemJWVkY1?= =?utf-8?B?S2pkU3ZhcE9XV0hXYUtIMklmSmk5R1oyb3M0VWYxbE1tNEJEUTNFcHc3NXBX?= =?utf-8?B?TjdxTU0wN1hpNDdHcytWaVozTEwyUUZKN2l3ZWVjajdudTBCZ0YvQ3hHWjFO?= =?utf-8?B?V3Vhb0c5L2plSEVVUEtTSVFIdVBjUHNYQXpOM09KYU1GZkdMU1dTSXdVd0RH?= =?utf-8?B?RGF0SFgyWndGYWNtTnhqZnk0THp5V2lWTFBEbitEYW5DYlBJZ2NYRG5NeHc2?= =?utf-8?B?RzhhTmlWT3FDS281U0pYNEFNYnQ2ZTkzNUR6cXVRL1lBeXRWM1NwREhNajBk?= =?utf-8?B?bDgxUHpHVmM3UytKSTBrVUxadlFpUDZ5MnNOOGZMUWZwTHFUMW54bzkrS2JY?= =?utf-8?B?QlNSRlVTZHVjZmdtdmVPbHZDM013RitIV0xzUjJqTEViVFd3aCs1TU9tUStL?= =?utf-8?B?MmVBank5NGlCdGg0OWtQSlhjZ253VFVvTjNENmpUNWVKT3R2ZjBYSFRGT1VQ?= =?utf-8?B?dkNxUGlyQlVEUGk5ZEtOR24xSGJOT1NpSm9icndxZWR6L2UxRy9kWG10UVIy?= =?utf-8?B?OHZCOXBVRC9SN1RIMU9XMXJnTE1OY2lJUzdlUGlxT3ZHUlRPcWJ5NWZaYU13?= =?utf-8?B?UGczWTF5YjZMQTcwZmdjMTRJMDAvaFpmeUt5bFh0WitoenJqL1dWTTExM2NJ?= =?utf-8?B?azdzQWJobXRxVktRclM0QVFuQmlQQm9nYzA5bG9QRWNSYW9KbG9RbHF4aHdz?= =?utf-8?B?NURJNDkweXJoQXQxNjNkaElIYnRMY3dOdTIrczJmR2V0eFFidld6eE50RDBz?= =?utf-8?B?WXdkcTZ1d3paRm5pRlNqemVMNjB6d3VESEZYY2pJMXF1U0tzc3Q0NG9OS3hs?= =?utf-8?B?VzlhMTRIdnd3c1R0cm0vSnM2Nm5SdmllSTlkSEVYY0MwSTVuaVVFZmx3V0JR?= =?utf-8?B?NHJzWkdDTDh5OTREOWh6b0F3Q0dJekMyb1VzamFYRW14dU1UZnptVCtwelND?= =?utf-8?B?S0VRVDhCbVFkOWRPQXdpWmU0TE5hQnFndlhLdERnYW5OT25wTVlveHBvSkJX?= =?utf-8?B?SElQMkJwUHEyOUdNdSs2VXdncmV4dEcwZ0VSaG40Zk5NVllteXNiRW1IY1pX?= =?utf-8?B?eVNubzY0SVZHdWVKRjB6d2J1WGJZSzFQRnJ3ZFhpLzhnenBZQUdWVlRqWmNp?= =?utf-8?B?TnRDQ2U3TWkrNUZkZjB4T3NtY1hmL2MzVTVweU9UdTZiek5YTVBJOFh5QUJq?= =?utf-8?B?K0hSdXovS2E4cDFVRXUrQldJT3FmSkZUSmJWZEswbzV6VklDMUluNFAza2VR?= =?utf-8?B?MWVRNy9HTjFiUW05TUtuS0s3T29zZnQySzdhNVhzQmxIcW94YXB3THozUFZv?= =?utf-8?B?ZnphWFgzeE5iL2N1YXRBbENCQ0JOMUNhc05NaGhsZDN6LzNuUjhPSmNJa2RI?= =?utf-8?B?SU90S1VENFRZd2hrTE01MXI2bHZRbkhRa0E3TUhpOGFkMTJ5WGc0T1VDMUR1?= =?utf-8?B?QTdJU0o0ZHVObHpLWVNTa0tLbnhPS1Q2UTVBNWw0Mmxpc09IcXlnbG05WVFV?= =?utf-8?B?T1lvbGI0aXA1ZGgydGpML0h1Mzh1M1RLbTA5TmNnZXMyM1hBZ2FWVG9MdWlX?= =?utf-8?B?UkdlaThITkx3R25Qb0JCb2tFQ3h6ZlJ2VWdGVEQ3ZU14SzNTZ2xaUXlQOFgx?= =?utf-8?B?Y0txeDlGSEZuOHRMdnJIQkZJbStHNllvUkphMTVWa3JaY2Q5ZUVsbk1nTHBl?= =?utf-8?B?RGF0VE9Da2NGM0tJb0pEMER5TTdxTzAzK3BxMS9kY2FpdlZsbHRTUlcvc3VD?= =?utf-8?B?ZFUwQUJoRmVPYTd2SU1CQm8rc1k1dmNCN2ZpTjN2bUV5Z1ltRXdxbU9QMWYy?= =?utf-8?B?MWEzYzZrdjRtRll4T0grRUVWMXc3TXorM1ZDT0Q5dXdzR0ZaK1FqbGg3enpz?= =?utf-8?B?cmY1YzlGSGhFbGdhOE1ucVBiUXFvaTNGZllxVWw5and2b0djRTJWTk9CSnJ1?= =?utf-8?B?eFNwN3FkeEEwZ21ibEpRRkMyTXFLYVJHcDUvMnJaS0RKWGxEemVZMVFsVTZw?= =?utf-8?B?aVg5bTlRdExNUFRsaU1WdlJDTWJoNEFYM2VTYVpBUGRQK3JFcG53VzdUQ2d2?= =?utf-8?Q?9f/FtOGgOlT3G1NCqGsnq33lM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fcd1651-c23b-45b5-8329-08dabd782a0c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 08:48:22.7409 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6jyGs6E8owV96dNHMG0pUFgk+rairRo1sJwJ8Z9vnq1JwRuKLYXRA3dzQyUZpjyvzBX3XcJUb2AzRsBawF36aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8834 On 31.10.2022 19:37, Andrew Cooper wrote: > On 31/10/2022 15:55, Jan Beulich wrote: >> Hello, >> >> quite likely this isn't new, but I've ended up noticing it only recently: >> On an oldish system where I hand a HVM guest an SR-IOV NIC (not sure yet >> whether that actually matters) all APs have that warning issued, with all >> reported values zero except for the very first IRR one - that's 00080000. >> Which is suspicious by itself, for naming vector 0x13, i.e. below 0x20 >> and hence within CPU exception range. > > To be clear, these are the VM's APs ? Yes. I'm now also pretty sure this is a Linux side issue, as I've verified it to be new in 6.0. Debugging is complicated some by the host not being very reliable anymore - the SR-IOV card has been producing floods of corrected errors for a long time, but recently apparently uncorrected errors have been occurring every now and then, resulting in a host reset. But I'll keep trying to see if I can spot where this behavior is coming from. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 03 08:52:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 08:52:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436161.690245 (Exim 4.92) (envelope-from ) id 1oqVxm-0006lA-HL; Thu, 03 Nov 2022 08:52:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436161.690245; Thu, 03 Nov 2022 08:52:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqVxm-0006l3-EX; Thu, 03 Nov 2022 08:52:38 +0000 Received: by outflank-mailman (input) for mailman id 436161; Thu, 03 Nov 2022 08:52:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqVxk-0006kx-Rz for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 08:52:37 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id da65b143-5b54-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 09:52:34 +0100 (CET) Received: from mail-mw2nam10lp2100.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Nov 2022 04:52:30 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM6PR03MB5018.namprd03.prod.outlook.com (2603:10b6:5:1ea::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov 2022 08:52:28 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%5]) with mapi id 15.20.5769.021; Thu, 3 Nov 2022 08:52:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da65b143-5b54-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667465554; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=QskB8PMeRAs940sXfZmevqd1rnlBhFvS+0itl91ODw4=; b=YVIvK8CiwGajwamUTdHQpLYS4iu9xxOfrzvaqvd7QheISz+IuX7m7FFC RxGBcOeYKQRhi9pdGbto99PACOofiEWLrDj6Igf9nM5Eai2HmVmSeayIl 1etYDo6v27g7F1Qh64CDErLNk/whY+Ec2x6TScoV9pxVGsvBiyBq/5Jxi w=; X-IronPort-RemoteIP: 104.47.55.100 X-IronPort-MID: 84074864 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:PkT9T6utZIJnRr+gCanXYV6HGefnVI1fMUV32f8akzHdYApBsoF/q tZmKW+CP6zZYjCmc4wgbdm3/UxXvZTQzt5gTVBsryFhECoV+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5Vv0gnRkPaoR5QaGzCFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwLyEDRAiip+OK8uyYbdg2oNs5D8bTI9ZK0p1g5Wmx4fcOZ7nmGv2PwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjf60aIK9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAurBNpNSO3mqpaGhnWY3zY+VSQ5XGCWrNunimPjReNvN k49r39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooL07gCDFy47RzhOQNU8sYk9QjlC/ l2Um9LkAxR/vbvTTmiSnp+Pti+7MyURKW4EZAcHQBED7t2lp5s85jrQSv5zHajzicf6cRngz jbPoCUgirE7ic8Qy7797V3BmyirpJXCUkgy/Aq/Y46+xgZwZYrgYpPy71HetK5ENNzAFgHHu 2UYkc+D6uxIFYuKiCGGXOQKGveu+uqBNzrfx1VoGvHN6giQxpJqRqgIiBkWGaujGpxslePBC KMLhT5s2Q== IronPort-HdrOrdr: A9a23:E1xKUq+3Z8uIQFVCSqpuk+FDdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp T525RT5c9zp/AtHNNA7cc6ML+K4z/2MGXxGVPXB2jbP4c6HF+Ig6LLwdwOlZKXkdozvdAPpK g= X-IronPort-AV: E=Sophos;i="5.95,235,1661832000"; d="scan'208";a="84074864" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kj0flFnyx018w/3r7rPb9fdRHVJbafwc3s+aO/SD9Fn7+pr4TntxWk8y0IEmjc0g/gth7cBiMEqqmpcQfNB75tZlaJk3Dh5YfOxVXoNsnbgnkuzbLCqNlqXMh4WcHDpIMbO9pD7jUqZSUFdgNSuxkm39uFf9MH1O03a5P5C2dP5x13qIRzTdSNQTOHhYrx3s/spXDcW43xs/fySCoifI2tjy4yWfQ7MVMqwBdAmIMT/sK17PGVzFUKCCAw+PGgetod8ZunWiBdT/wxZwTBe31zOWyEFc0twc87A7OJZjtVfO42pOCV5Gi55uAOc45YAHTD/dQiZ8Zfb6nefGHQxO4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b2rTuwT8cYHxszVjf1Bj9Peq3Hqa12vcBCHZTZ11GoQ=; b=hEWx/WcxCOmOaVHlDmgEgZrM5KjbokAg8h4ug3JbM8BetyMm/wafGLYD9J4IshMpGAGIjq3CzgrUi1mCVjcF6PR5nO3U0Lyuy58yV/qpqIDCd7RDCTLjK6ARZsUkLSBX/7DEKUXY/g/4czChYiwFvBCa7hOzfFWmaPoc2OEY1qj7Qsa6KTSBq5xo/KaLEJ/t+jY98Oxt1htpMajw9sa9f5u1HHFX/MVgyGr4lkRxpOOkpxxSkJFkvFfvZRGU4UtKv1W/B468Tq4Xm9bM0ZjBaZqqO9ousBiUfXgyz9xmh45PlDDhDizhTdEH8C8b/zf4CCM47UPwIfMP/+5W8KeFmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b2rTuwT8cYHxszVjf1Bj9Peq3Hqa12vcBCHZTZ11GoQ=; b=Nz9y3tKqoWvGhpCEBI7F7aVkW2ZQGEHghyPl/G02tQDc29s3IoUFWPpircw4Up2u/eqGmQvpJRqEfb51oNchl0E2Unu3S3NWA5rNpCe3fXQh70fQaIYpsXIc06moUF7bDA/HZfEEaiuM2UruVsnQwWV0slpc0K+pAxG/p3eZrs0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 3 Nov 2022 09:52:22 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.17 v2.1 2/3] amd/virt_ssbd: set SSBD at vCPU context switch Message-ID: References: <20221028114913.88921-3-roger.pau@citrix.com> <20221029131258.95811-1-roger.pau@citrix.com> <198d04be-e7f2-dc11-18b7-ef3352d07b80@suse.com> <20869a2c-224e-698a-b927-96d6ad752b9a@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20869a2c-224e-698a-b927-96d6ad752b9a@suse.com> X-ClientProxiedBy: LO2P265CA0292.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::16) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB5018:EE_ X-MS-Office365-Filtering-Correlation-Id: bdb9b41e-0e71-4d10-0a8f-08dabd78bc53 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +NG1TNLKJSWdDM8XZ5BcY/HaOs0QVPx4jVJXO3XznURZVeYA16AwmO+0ImD0OqFTkcZoNuEcz8IgaJtXaQGa7zFwBLsCKZ+Np5RiIXJ6DjbwuCHRSD5twz0no3XXAj2VDPJMW+ieuRO4QnxPnhzJ1zWvrv1Mr3+dOSuqRjdd39W78nbKtOUXTcGw8UyoR4/EMZLE1UEC/FzSisZUPryFqUcllfgUnsGYIa6TXGdO4PYDfykWStTydsUeNriOXyiAb3lGPk48LPfFMQapesnGWLMdJTpvugAO4SeZvU1fVqqCS1VnXFgSpPWUOYD6+CLVMfMdKCUN6Dz1LIXkdToZv3IqKGR4OtvgAJZR/4VrAql+gU5Ybf7r0jqC/8OwDnUVl1K5qjq7hEYzTh8LEGZgf0Z1eWda0Y6XttbCzNRcUihuKtWAj4Fl3vsIKSitCJSAj0ChkqVqbdgVbFM7zj1oV3J7ykZlYr0RgteigD1Ym6ukC4Hjqh/C5UGuNEFJlDcYPVLVQiqpgfWnaY26iGgF/dJhzAYnVCRTKCyObEZYIyi9kEirqQGH8B2aRLCGc41mlj2+q7XD/wwim3VFfQFqEn2q5Hdvkb+H3PZvZ14NtN3dzsxfoZelMc7uHUi0e4hSTGiHzF/nW8+57L6/uul4Pf2/jWkicVyaaDA9TcAFAm+VQSsfqtR+w8aCaPws7BhXJpqhB3uHxP7PEsYE7LpbJA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(396003)(366004)(39860400002)(346002)(376002)(136003)(451199015)(4326008)(86362001)(38100700002)(82960400001)(316002)(5660300002)(2906002)(8936002)(66476007)(33716001)(66556008)(8676002)(41300700001)(66946007)(9686003)(6506007)(53546011)(6666004)(186003)(26005)(6486002)(6512007)(54906003)(6916009)(478600001)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUVJTXN2Skk1dkEvclljaG5NZ21WQzlsU1BETWxUMTQyZVhENnRwUVJCTWNO?= =?utf-8?B?STQxRGprdThLcGhMeHJja1dkODllR3ZSOVVLd0wzYWRLV3U5ZDZzb0FtazRw?= =?utf-8?B?OGpjRE1VM2FKN2tKTTVnSzhJL2IwN3JJSDFFalBJOWFycklsOUhuT2F1Q0w5?= =?utf-8?B?d21vNGdQUWNUL1BlYUE0OUd5MnJCQ1N5RXRoV3NWRWd4OWNKdHlvTkEzQ0Ni?= =?utf-8?B?U2t6R2JPNW4ycElkUjVHbHAwL1l6U25XZjcyamlDTm1mTjFkeW1JNXBDZFBy?= =?utf-8?B?YzdSUnQwOVNhTUVnQU80cTB3eWkvc0RQemlXVUJsQmhJeGVoRktZejI4NnR2?= =?utf-8?B?QmRpY1A5RmRlYW1KN3FJcWRTTG9YZEl0Z0dqSGN4Ujl6TTdRYUZQU3Y5OXE4?= =?utf-8?B?TUhpblNFSDZReDNxRCthdm1pSkdZVjl3VjRaM2w3Vm1FUHRaTTlFUlYyeG9Q?= =?utf-8?B?ckQrdmVwMkROM1BYN29VbWlKS2hCOWd5L2tRbVluRDZ0KzF1cWxHYXU4ZGsx?= =?utf-8?B?ZUgwcGRmR3k5ZWdlU3FPMzdackw0ZnBhQjJGaGJlOG5MTlRBdlZyVzd6SjJa?= =?utf-8?B?SXltYTdUYWhZUXZVMWxEblNlNGI5MWlMdUNwYUt0cHJpQ2YvTHh6Q3crQ0Fr?= =?utf-8?B?WE1tNnBtYkJtczVNdHU3YkFXYm9MbjlONC9mSmlYYkU4emlDTks4dVk1WDFx?= =?utf-8?B?UTFBRlhhSytFVDlzMXh2M0paWE9mekVzcEl0VlFCUTlycUFLU1A2ZFVpdS9O?= =?utf-8?B?RGFVNUlBcDN1SmZ3emhpV3h2OUlxdGRNSmRsZ2JFNkI4Rm94aWw3NWZmbUQz?= =?utf-8?B?cEJFOEdKNXBxVEswZndtQzc4eTU3eXhkQ0pERG4xZ3lPY2tCbW45ZEZSNWFX?= =?utf-8?B?YjhpTEo5TjkrZGNuUzJVbitZRmgzTHdrWlVMUkNRWU9lbGh0Y2VOTHc1Yk9l?= =?utf-8?B?bk5wdlFTdGZtZGdEVXVOblJJdzRqaWx0blRaWmFiWFpvaWJSL2hSa2pIc3I3?= =?utf-8?B?K2dFQkV6Rms4dVh0d2lGVC93Z3VEUXZLQ3NMQUZ2OCthajA1WUVNdjBaOHpS?= =?utf-8?B?cU9XTlVVckN6REZlcGtyaWlQK09ldldrL1RXaHpjV2xpdFhSRkJySXZQeVBE?= =?utf-8?B?eFNIQU1vcGl5VkF3Q2Y1YjRFZnRFbkthVFd3OWpjOWo5YUQ0U3IwcE9QNU5t?= =?utf-8?B?ckJibUdJRTJDS2tZWWxXQ1VEdmU2d241WDk0UGFrNE5yRE1DMlp4SkVGK2Vy?= =?utf-8?B?VlBKYzNOaFFERXF0RzBtS0U5YTQ2R1BMWDdDK2xwRFl1M2xiVnBKMkRKRUZU?= =?utf-8?B?ZzBHTG1TNnRsSFprVFNyV1daY1R2M2w1em0rejVZL3p5YkovYzFETEh5ZkxX?= =?utf-8?B?QkRlUDJtcUxQVlJSeFNVeFZNQWg4dkMwQkxybkxJS3ZjZTBCa3lYVko4N3Iv?= =?utf-8?B?NmtlM0RueUlYb1ZraEMxUU1ZamhCcTM5NHNHaUd4M1VnakJ2Y3YzQmVtNHdZ?= =?utf-8?B?MWlUOW02WFpQcG5GVTNDMllVcFJZSnZEalB0NEl2Nlc3MFZ2Qk84N09JRFVq?= =?utf-8?B?dG1EQTVPUURNWUJSWXNyT2syTU4yRlN2ek5HeUFnTnQ2NWRKM0lsR1FzcDVT?= =?utf-8?B?Q2ZCQ1B0WWR5c0NTY1VXU0tCczFxWVpFeERPSkFzQmFaVE1acktza0xiYnpN?= =?utf-8?B?OTdKZThud0xkaXdDdkJKc1FoM0V5Z0psYzlIMmx5Q25leE9xZWJBK0VJcTcy?= =?utf-8?B?OFV4c1pGVVQ1Wk5JRGJMUW1paTJoRDFQelJUM1pUSkFDSHNQM0lWZkY2TmJH?= =?utf-8?B?V0lIcWxpTWJwcUpGcFI0amkxZUVoeDFOQmZBOHBkK2NMRHVHYmppWFh2QXVP?= =?utf-8?B?YUE3K3Z2TTFrb1krWUtMWHlzajh0dzNKVU81NmRncVMyRXljd05vL0hSL3BL?= =?utf-8?B?TzhKRXBkQURlVEUvZnp4cXNzS3g4eTlScGVVKzJrUGE2UGNrNUtvaExIaXJQ?= =?utf-8?B?UGpjZVBuRDUrRU50dG9OTUhydFJnZytYOHdMdHlCbGRjcG1VZmZsbW1ic0xT?= =?utf-8?B?YWdwdFcrTlVhZ2dZZnowVVFZYTdxTnkvQ0JoUHJlVTN6djJWVUVLSEhVN1hJ?= =?utf-8?Q?m+78qZ0yisPt73wGwjqWpLK9D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdb9b41e-0e71-4d10-0a8f-08dabd78bc53 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 08:52:28.2130 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2DDy+m05HOk9Z85qOglc1yKIPrBWe6h77dTzUyo1TU6XqCi1BtQqhgmsAn52h6NRYapcz05iSP4G8+PmRDgYTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5018 On Thu, Nov 03, 2022 at 09:09:41AM +0100, Jan Beulich wrote: > On 02.11.2022 18:38, Roger Pau Monné wrote: > > On Wed, Nov 02, 2022 at 12:49:17PM +0100, Jan Beulich wrote: > >> On 29.10.2022 15:12, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/hvm/svm/svm.c > >>> +++ b/xen/arch/x86/hvm/svm/svm.c > >>> @@ -973,6 +973,16 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v) > >>> > >>> /* Resume use of ISTs now that the host TR is reinstated. */ > >>> enable_each_ist(idt_tables[cpu]); > >>> + > >>> + /* > >>> + * Clear previous guest selection of SSBD if set. Note that SPEC_CTRL.SSBD > >>> + * is already cleared by svm_vmexit_spec_ctrl. > >>> + */ > >>> + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) > >>> + { > >>> + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); > >>> + amd_set_ssbd(false); > >>> + } > >>> } > >> > >> Aren't you potentially turning off SSBD here just to ... > >> > >>> @@ -1000,6 +1010,13 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v) > >>> > >>> if ( cpu_has_msr_tsc_aux ) > >>> wrmsr_tsc_aux(v->arch.msrs->tsc_aux); > >>> + > >>> + /* Load SSBD if set by the guest. */ > >>> + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) > >>> + { > >>> + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); > >>> + amd_set_ssbd(true); > >>> + } > >>> } > >> > >> ... turn it on here again? IOW wouldn't switching better be isolated to > >> just svm_ctxt_switch_to(), doing nothing if already in the intended mode? > > > > What if we switch from a HVM vCPU into a PV one? AFAICT then > > svm_ctxt_switch_to() won't get called and we would be running the PV > > guest with the previous HVM domain SSBD selection. > > Would that be a problem? Or in other words: What is the intended behavior > for PV? PV domains can control SSBD via SPEC_CTRL (only), so all we need > to guarantee is that we respect their choice there. If the hardware only supports non-architectural way (LS_CFG) or VIRT_SPEC_CTRL to set SSBD then PV guests won't be able to change the setting inherited from a previously running HVM guest. IMO it's fine to run Xen code with the guest selection of SSBD, but carrying such selection (ie: SSBD set) across guest context switches will be a too big penalty. > >>> --- a/xen/arch/x86/msr.c > >>> +++ b/xen/arch/x86/msr.c > >>> @@ -697,7 +697,15 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) > >>> msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD; > >>> } > >>> else > >>> + { > >>> msrs->virt_spec_ctrl.raw = val & SPEC_CTRL_SSBD; > >>> + if ( v == curr ) > >>> + /* > >>> + * Propagate the value to hardware, as it won't be context > >>> + * switched on vmentry. > >>> + */ > >> > >> I have to admit that I find "on vmentry" in the comment misleading: Reading > >> it I first thought you're still alluding to the old model. Plus I also find > >> the combination of "context switched" and "on vmentry" problematic, as we > >> generally mean something else when we say "context switch". > > > > I had a hard time wording this, because of the Xen/guest vs vCPU > > context switches. > > > > What about: > > > > "Propagate the value to hardware, as it won't we set on guest resume > > path." > > Sounds better, thanks (with s/we/be/). Oh, yes, sorry. > > >>> + goto set_reg; > >> > >> It's not clear why you want to use hvm_set_reg() in the first place - the > >> comment says "propagate to hardware", which would mean wrmsrl() in the > >> usual case. Here it would mean a direct call to amd_set_ssbd() imo. That > >> would then also be in line with all other "v == curr" conditionals, none > >> of which apply to any "goto set_reg". ..._set_reg(), aiui, is meant only > >> for use in cases where vCPU state needs updating such that proper state > >> would be loaded later (e.g. during VM entry). > > > > I thought it was better to hide those vendor specific calls in the > > already existing vendor hooks (set_reg). I don't mind calling > > amd_set_ssbd() directly here if that's preferred, it seemed kind of a > > layering violation when we have vendor specific hooks in place. > > Well, Andrew of course should correct me if I'm wrong, but my understanding > of the get/set-reg interface is as described. On which grounds I don't see > any layering violation here - doing the call right here is merely a more > involved flavor of wrmsrl(). OK, will change, but first we need an agreement on the SSBD context switch comment. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Nov 03 09:02:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 09:02:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436167.690256 (Exim 4.92) (envelope-from ) id 1oqW6n-0000Fl-CW; Thu, 03 Nov 2022 09:01:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436167.690256; Thu, 03 Nov 2022 09:01:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqW6n-0000Fe-9b; Thu, 03 Nov 2022 09:01:57 +0000 Received: by outflank-mailman (input) for mailman id 436167; Thu, 03 Nov 2022 09:01:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqW6l-0000FY-Dv for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 09:01:55 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20074.outbound.protection.outlook.com [40.107.2.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29687d57-5b56-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 10:01:54 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7475.eurprd04.prod.outlook.com (2603:10a6:20b:1d4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov 2022 09:01:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 09:01:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29687d57-5b56-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TBgiln3amo2L8I8aPZoSG5Xatbxt5VKPqtXOvHi4zuHpm7oU68XioWMWWRYSNYNLYc6uL7vE6A/Xxx1V76Wv29FhyRcucECLcscZ/KRAip2UwUUIcTg7pfSi1iwUAbOvcuaNwXAIrxZm/Rql77WQd2Ni0ywt/OOgow6owGPbowKqRz/5VnyAKbduA28xV/bXN6kfgt86lr3pK1wvyI7BDh/+evDfiE6OSGb/28FRMjrma2ZmRTDgIzGB1vmWqQaW7C3C/rctacn+YbF7Cm4xoRk8DECIjGChlX24RA3xaoYBlojBFxs1aChtuQT8hqtjKWCM/lJKHGod0ruXSsf8xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tyrQOpxCKpNSbhCdvuOVZUNZOlBP/ux2MXuEEX2JsJU=; b=NKU3vXYbWlUvXvIwd3TWpYLd7r2xah03xt5uUqqHqqXq7pq2Iz1ATP1fBo34VO0dddnNlgu9EPgw5dOzu2YCJuVFUQNxHRV2oUnOqqLZYJHogMbrHi8dfH5ws2ESuC0X1X2pb+kVVzvqtf0IxcwcHK2lwui/+yFXOpHLcvBQtTjR26t2B0MhHlaJB+EqRcCPlt4BGAJHS/O45mulGXX85tkSrZhCGV+mdzSzDOKxcExPxb9Xnj4kH9HA+xgUp4rEjM2Rl738JAs7beZUF2h7fL4WJMakl9rjvSrYtA4tEJzY2ji533HrQpYe7JIRdTCo0bdjwDXHRGs1PzXg1uB+8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tyrQOpxCKpNSbhCdvuOVZUNZOlBP/ux2MXuEEX2JsJU=; b=jH8RWQ7jTmwr91dEFh22KczUrOgmcb1ZzYsS8dEKNpodsGE7w160C0w2+XV9sUVCrIU4kQp3WoaPplHC6pW91nNVhABlPN+SP3bIJWiN9LA84nF5aNdTs8GJ6WxWgHr3JptQCce99giAfdDDkF7ZG6cW/DaU5GyhxuVKkR8psNMktaDLOHHYTHo0eXnJS5c4heeMOKrHf+m58pUv6L94/PZm7HMzzCLiUTcxy4NvGfElvoxXBs7EuiWCsSFXPJ7SrUeKxLm863fRkTKKct8eUvSZgwR5G3CZEH/FFjLImZaRC0ZNAcVXP3zK9/+rC88TOXrK5YNEHa9wNKgQK/PLwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <37c145b3-9667-200d-c13b-912f3d9b8a0f@suse.com> Date: Thu, 3 Nov 2022 10:01:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 v2.1 2/3] amd/virt_ssbd: set SSBD at vCPU context switch Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20221028114913.88921-3-roger.pau@citrix.com> <20221029131258.95811-1-roger.pau@citrix.com> <198d04be-e7f2-dc11-18b7-ef3352d07b80@suse.com> <20869a2c-224e-698a-b927-96d6ad752b9a@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7475:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a60dff4-708a-4b6e-6089-08dabd7a0c44 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GCCqffV3mkEsrGVGN2SUnkQZ0pM7wXX/0SXeNt3eOu3BJocy7S8V21V/F9/Yjf3oGosIzJX327RCAfQt+sl6QpdaW3EZVmZhm1Z/GvqOpxoiZ2LLOwY+m1lIohE/ncNjpIu/WZ34ST/uMHyy76JtnF+8SY0cJVNqor8bm94vmR28oBrl/ARPzwsw7swD0wtIQKuyx9FkTkQeg8yYUL4hVG6XcAMuedusqyOPqXUy4e30pcLlt5iXaD6I0ClFas5qWXyQiAskgQd2PhyAnkEGsnu5Z4iXrBAb/OKE+tNT3I3XPPjQuittPzc2gipTLopQa6XUSii4uMAermkB0i/OkIQaqARmti9vFZAlyvIhGQEPlnn8BT2SJnvVpEdcdSn7X3DhCOZB5WMLYIIPs60qOYjd7kuc8juS44MqDMur8ULxipiZBXwthR3sBNQUvWI156ChpuDmP5us9vV3KgtdSXWhHQDAVLRR9cbzkgnAebsK3EaLJzP9GIJoNybHgi7BPSfc++1rlHN7+uQKcLdpPx6gwic8rk1lvUaBnz7sI7CPqw5yQP6yZDbLWoXiXdTM9UEru44NEo/Mka576I5uXK78rXTPzkwoze0V57XoPuFRrblskUWnvfUxiGf8T1iUsqzrXPDR+HxthLyK0ihgMffKOSfsWfJVCPG/96cG0ef9Z7Wvhw0+qgsbu7kUi/QNk6V1RZDV1uWfeBlcCUjtGnk3CQceAWS6+IFwr2n8S8I2Led82bXwXoqzQgiHA6Tp1YEQ/mT54selG2iC2RZmaaU1XJm8kg9H5QfyA9tQnqI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(366004)(39860400002)(376002)(346002)(451199015)(186003)(6666004)(478600001)(36756003)(26005)(38100700002)(6512007)(6506007)(53546011)(2616005)(41300700001)(5660300002)(2906002)(8936002)(31686004)(31696002)(6486002)(8676002)(316002)(86362001)(66476007)(54906003)(4326008)(66556008)(66946007)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3QzVngwSm1GSmVvN0JGOGM0dzV3YnFnd3BHejNPVFpRSnBYS0ZDVjlIRFVn?= =?utf-8?B?c1oxSS9DMUJtTFlTdFhFSzZPMFVCYnVzdERjdWloN2h0Z2ExanRJT042Vytl?= =?utf-8?B?VW1WS3c5L0J5MS9JR3ZFWjJZSXJTbEduVGl2SVhwSS9yZ1BOUkRZKytYV0E2?= =?utf-8?B?dUdFYlU2dG9vSzBaQXpuWGJwN1Y1NWFTWFRCOHg5cGxvMWExSXVkMlNaR2RJ?= =?utf-8?B?Q3BtM0xzNFlYNXVldDNoRVQ1dnc1Nkp4eHB2R3ZzQUI1WXpFbnpXbmJoMTU1?= =?utf-8?B?VVhmUFRPWTVTU3FLMEx5clZMV2dwNGlrSXVwQU96akVSYWI4SDhsWGNpUDJU?= =?utf-8?B?TEtDTDZDTnMrMStIN2piNEk3NFdVd2lvM003SEsweTRNTjdqMU8vTmRHUGR3?= =?utf-8?B?VE1sTjhVa2MvOWlGQW9lc1B0SzJ5bG5mTXZJL0o1UE9CMU8rY2gxamZhZElD?= =?utf-8?B?QXdzaVhXZWc2RmZ0TFB5S1U0L0x5ZEV2TElwUUl3Z3lodHg3SmJwdHMwVnBJ?= =?utf-8?B?Skx5S1hQTUNCeFNHM0EzcVFLV0NnQkFpd3NoZXEzT3JoTVdWVlpsVjVBYWVU?= =?utf-8?B?aUNlR0hkdENIWXY4TUxZWURkSGNwZWU3UVZKS3FCdTYvSEt4QVk4SVp3MU5G?= =?utf-8?B?QnhvMDcrWXlBbmtvMHpXTmpsN3lrM3ZYeGJTc2VxN3ZjU0JsQnFMQldiSXFx?= =?utf-8?B?V3pSZ0sxdGx1STVBRE1OeEtNclpEbEJWc3hFZXNQVlpWbVRuTm0vMnpKRTZI?= =?utf-8?B?ekh3QkZzY29CdVBTRFNidVZXcVFLdFJiRmVmbnkvUWRUUnlMUTBjYmt6a2Za?= =?utf-8?B?RDZLUkgrRnpQT2tVZ3VuSjZWSHNKTTY4aTVGbnYvKzJxWTVEVVI2QXNKUmJ5?= =?utf-8?B?V3hHUXdjSWZmUkp4ZlJuN1B2TGNRWWhrVmcrMHlCQnpKQVlBTzhKMHBja2E0?= =?utf-8?B?SFJZcDhvcHQ1SVMzRDhPM2gxQWYrUEFjMnBCbE12QmJ3cUFlNzVyUXRyVlJs?= =?utf-8?B?M2o1Y09oRkxSM3gwcjFiVFBuUFVaWWFNM2VMN1lCdk1rUTRPRjhtSENVTHVR?= =?utf-8?B?TDgwTHRCWlZ4ZXFXYldpU0ErZktlV3Q0Zy9jVEVmVGFWeWVHM05DWGRrVjMw?= =?utf-8?B?VUpzUG9XVHBYYWN0Z2xKZ3VwWHdPS1lISzRZQW5wSXhPeG5pYmE3bkNib01F?= =?utf-8?B?cU5iYTRxNmcwb21DRi9LR21QRWF0RU9xRVFjeUhPbS8wMDdGS1VzYWN2NGdV?= =?utf-8?B?ejVQblNvYXpoT2R1cUp1RitTZS9tV1ZsODhEV1o4TmJ3dDJuajdPaUtBdm8v?= =?utf-8?B?U2FzNnl0K01FdnhLa3FZR0xJeFZ1emY5VEhraU5KYklDdDZleGtQNks5TDc3?= =?utf-8?B?UkdQTDIvaEhYbTRqMW45NUpzRGlJVExKM3R5V1NDbW1PNEs2aEY0KysxaG9Y?= =?utf-8?B?cXdpZTJSMWNRbG93WXNtNzQ5SGNqYjlyVzFjYm1mS3U2U0tWZEFBOEpha0pW?= =?utf-8?B?T2lTUWdsbVYwbGZsYzhNQkhSd1ljVUdEOFlVV2ZkTGt1enJhNUc2RktLd05E?= =?utf-8?B?c1FXc3g0cWxIUXd1ejR2eXF6b0o5K2RmUXNJaXFUT0U2Y2hEWGxVbGdWYk9R?= =?utf-8?B?RVRjMHNVSjQ0SEdhd2luUmN0NG9mVWloellXdnd4dWt1akp0QkJ6dFVMa2dn?= =?utf-8?B?RDFsTy9xc3hPU1hUcHNpY1AxTmgwWjYwbUNjU3NUZXpQTThsSDFPVys2Q2F6?= =?utf-8?B?cVZ2T0dIS0ZUelk0ZktXaU5wWm96czI1NHZST0tBZ1Y0RXZJdmxIaEltVlRO?= =?utf-8?B?M1h3TUVnSjFSY0xybTkvL1JsZm45T3Z5dk5rcTh3V2EwL0tLVllUbmFHU3ZQ?= =?utf-8?B?TlZmTEltaGNvd1dXL2N4aENGK1pPOW93ZUhyUXhKbjU3S1dNUmpHb3RRT211?= =?utf-8?B?cEdTMTdEajJtUHliN0x0NmI5d1ZaNmllaWczVy9rTWZaRllISXNJWjVoTU56?= =?utf-8?B?MEdGSHNQZVRoMUFHU3FPL1BDaUN4Vmh6eWQyTUdmNVpyWUNEV2NNVHhuQ3dC?= =?utf-8?B?SjczTXNVWEdGckNxSzR4anFFc1pqZ1JReU5Tdkc2N21heVJtVlBHdUFIVnRy?= =?utf-8?Q?+EuxzHJHMStUj3nZy0JTmRLMe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a60dff4-708a-4b6e-6089-08dabd7a0c44 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 09:01:51.9407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RhGIdAHZlvGygZBR5G+sKUp2L7BQ48A9O23Y79OnD713qOCjgfuK+jnoyZrWw96fZkPbciJHhRoRVpyHFuneow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7475 On 03.11.2022 09:52, Roger Pau Monné wrote: > On Thu, Nov 03, 2022 at 09:09:41AM +0100, Jan Beulich wrote: >> On 02.11.2022 18:38, Roger Pau Monné wrote: >>> On Wed, Nov 02, 2022 at 12:49:17PM +0100, Jan Beulich wrote: >>>> On 29.10.2022 15:12, Roger Pau Monne wrote: >>>>> --- a/xen/arch/x86/hvm/svm/svm.c >>>>> +++ b/xen/arch/x86/hvm/svm/svm.c >>>>> @@ -973,6 +973,16 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v) >>>>> >>>>> /* Resume use of ISTs now that the host TR is reinstated. */ >>>>> enable_each_ist(idt_tables[cpu]); >>>>> + >>>>> + /* >>>>> + * Clear previous guest selection of SSBD if set. Note that SPEC_CTRL.SSBD >>>>> + * is already cleared by svm_vmexit_spec_ctrl. >>>>> + */ >>>>> + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) >>>>> + { >>>>> + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); >>>>> + amd_set_ssbd(false); >>>>> + } >>>>> } >>>> >>>> Aren't you potentially turning off SSBD here just to ... >>>> >>>>> @@ -1000,6 +1010,13 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v) >>>>> >>>>> if ( cpu_has_msr_tsc_aux ) >>>>> wrmsr_tsc_aux(v->arch.msrs->tsc_aux); >>>>> + >>>>> + /* Load SSBD if set by the guest. */ >>>>> + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) >>>>> + { >>>>> + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); >>>>> + amd_set_ssbd(true); >>>>> + } >>>>> } >>>> >>>> ... turn it on here again? IOW wouldn't switching better be isolated to >>>> just svm_ctxt_switch_to(), doing nothing if already in the intended mode? >>> >>> What if we switch from a HVM vCPU into a PV one? AFAICT then >>> svm_ctxt_switch_to() won't get called and we would be running the PV >>> guest with the previous HVM domain SSBD selection. >> >> Would that be a problem? Or in other words: What is the intended behavior >> for PV? PV domains can control SSBD via SPEC_CTRL (only), so all we need >> to guarantee is that we respect their choice there. > > If the hardware only supports non-architectural way (LS_CFG) or > VIRT_SPEC_CTRL to set SSBD then PV guests won't be able to change the > setting inherited from a previously running HVM guest. IMO it's fine > to run Xen code with the guest selection of SSBD, but carrying such > selection (ie: SSBD set) across guest context switches will be a too > big penalty. Hmm, perhaps. Question then is whether to better turn it off from paravirt_ctxt_switch_to() (which would take care of the idle domain as well, if we want it off there rather than considering the idle domain as "Xen context"). Or, yet another option, don't use *_ctxt_switch_{from,to}() at all but invoke it directly from __context_switch(). Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 03 09:29:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 09:29:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436173.690267 (Exim 4.92) (envelope-from ) id 1oqWXD-00047C-JB; Thu, 03 Nov 2022 09:29:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436173.690267; Thu, 03 Nov 2022 09:29:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqWXD-000475-GU; Thu, 03 Nov 2022 09:29:15 +0000 Received: by outflank-mailman (input) for mailman id 436173; Thu, 03 Nov 2022 09:29:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqWXC-00046z-8A for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 09:29:14 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2043.outbound.protection.outlook.com [40.107.249.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f9cdccc8-5b59-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 10:29:12 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9406.eurprd04.prod.outlook.com (2603:10a6:20b:4da::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Thu, 3 Nov 2022 09:29:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 09:29:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9cdccc8-5b59-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V+paBPQ/3KIUQ5FUjvcgdV7B4AFOYXstYVL8t42inz+i+Fmlv/ERXEormLnkoVBozPlpj64EBFrdgYVWCk/upVyapebGdGZ7SL3FhN+21M3ioUxO941o078uhp5A6G/CLtAZnTyidOlHfqE2qZEdA3C2Z4k5Q/EoX4bYmUmfzb0q9Yeeo/TTIGO3LiHcrhcSchn+gSU4K8LMm6H4Y00xnF0QGixiglsB/SPDJ0KxVitvGLLzsVXE9pKtWykjEnxNi/NiJPnYOKe969e321G4MxWV8muLLmcM6Nzu1HgNMyK9uo1J2k6dndn1biKdfLb3xP303fYIimvTldcIqpQT2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zJL0LLTJg4jnPn1uIkjfLhClxTDveBtUwKRhbC5dgLw=; b=Odv/QfOlRgPxptOUzwv0Dx8cp5T8a86+HzH01ET9Eie7XA6vwLV0mK0ldWTQbA449nRiCOOl/0uHT5RrCt5pPm7FYpg5arMDQ/BMdl3rJDI38/8v3iPLEex1DrT3JIkfdQyHJuf4q0u5k1Uhn/E7IDMGF0J9ModeUFMcNJSACyEtNlA/sDUALo7fY8Y3p6ocMfPyPUDoOFy8xGDNCm70ScjX8Pi4tobNo1auw0n/22RHNunL/4KmNMwz1ADVChr/q+nenxmSI1bnDIpjfmPWTmgTiYI+luxr7L3iQXevmY7584GmjBDsaNjbyvMZeoSPZ0gaJAJafs/8j9HJkn9XDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zJL0LLTJg4jnPn1uIkjfLhClxTDveBtUwKRhbC5dgLw=; b=dgf/TV+SzdbxZDz1oCjL3y3hPjRYXRHqiOtARAIKxNnAIjquhagieSZJbL/tshIUImkmHdPpS8/Cvvdldkppp+exm2ypbwoNnjBLQ+Bj4ARbcpmMXY/Iy8kj8k+DC4aug/zrVeLipiZXPbWkebb+7vLfDqz/IaAgkKUGd9KCoPbq/4lkgHobTTIcTUAmGF+ES0JIFr5VbaNo8p+8Rkaqc9TH71uxbu7VvNODmkGMrPIua2paZrcYjrqwP1s+7zYhXZB5WFFcGK1FBcOdBkb/W4mrgbiEiQ1cTt7IKuBBcCQ/g6Q1i1GklEFGVz1JNHkFwCeRcKL000OqHyeyvEnUJw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <82d4aea8-aa23-fc6a-47ba-deb7d182012d@suse.com> Date: Thu, 3 Nov 2022 10:29:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: Xen vs Trenchboot: TXT AP bringup Content-Language: en-US To: Andrew Cooper Cc: Roger Pau Monne , Krystian Hebel , Daniel Smith , xen-devel , "trenchboot-devel@googlegroups.com" References: <6ccbcaf7-29f4-6477-2f1f-0aa4de64e8c3@citrix.com> From: Jan Beulich In-Reply-To: <6ccbcaf7-29f4-6477-2f1f-0aa4de64e8c3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9406:EE_ X-MS-Office365-Filtering-Correlation-Id: 8935f165-a8e8-4202-426e-08dabd7dd913 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7Ey52WEEYZ++NiihlTK8jA0i+uzWh6tQvbZRG5EZxbYq5q/tmWXpoIwbAlZo1gsyMCIDptRm81f2PuW7/QKRy/SrVir4ErIo1i5xak3mvhL7Q7InfsdZE+qFBMHtT7BDqFEbFCkUl9jYup9C8zsPRRBFbWFa4ny1n/eZZoJpAhsBVFIDE0Yab4Q90NEn2PC1EB0ac19o08xWB88vPefvcgDPw6ya5TfDahRhVqcT1DjAkUpPNSmWO7EkU46kgGxmS6J0O8+InfaEusCiz4aprpw9eKsI6Ii7dqj2zbAWi99ojtNPfZZpNW5yx6IeRhXKJar9QeZ36E7OHsBOPwyIrh+rR8HMCVqpH4kVujMJwbv9XrmzyQn1odlLtr2a2FqJ0GmY5B/pUoBLcbwgDDRzOihCoD3dQzy9jtnWnm7HDi+8zVD0h2XWJmvrQEW2nQyZFwa9GEbGVA9usH7kuZJ7jbQ9kAWtl5OXlX8YD4tXul24rBA93KawppnN/O4XJWyt2AIWD91RhtVUhILAnuRdrf79jbLEFZ+VjIYgWcX8l26YRqEJvFvvTYWILoZdlfBquiFAjh7mpGGx5e1ffmVhNsEoIuN3zQrKZu7YwDODOph9Zo8cMW244VrB0eIor2kYGrj3iw+byw+653b7Dn7nYAmzzoRG2ps0WbWiZDbY2s89Gi4XQ5vCg6WbVJ7YG8eU6FUj2oucyGAxd1d6WJ0cBNImT34kyekwwnsio2wH3yTU087sqEdf3bvLfyj6oth6rfESlOUTJkpCn9imz0S8y2vN8dmI3T8xGsTvMZEx4KY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(396003)(39860400002)(346002)(376002)(451199015)(83380400001)(4326008)(41300700001)(26005)(66556008)(66476007)(8676002)(6512007)(6506007)(66946007)(316002)(53546011)(6486002)(36756003)(186003)(6916009)(54906003)(2906002)(5660300002)(478600001)(31686004)(2616005)(31696002)(8936002)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0VNT0s1V1owUjBFVFJUdytIUDdjYUNvV1UzVTEzUGNQeERaSm9JOGVyYUxq?= =?utf-8?B?L3NrL2FicTB1VHZIMnloU0VRMnphdDM5TExzVERCU0hRbHFsMDJzcFVWd3Yy?= =?utf-8?B?NWdVQ29oZ1FTRllQRjdUSVluVVRmSkZ5SDA5aEdvbmJNM3NPK1R0MWx2TENF?= =?utf-8?B?bjZDYm5IQzUrenhidm10ZCtWbGhqVUNrbkIrME9iT3B1eWtzdDJWb0FYREFR?= =?utf-8?B?VkVwb0dYSVpmc3FHV2FNcVh0c2RKN2JLbW42aTlsOGJ5U013dHNTS1djZGJM?= =?utf-8?B?YVlCaWl3elZuNUpvTVc0SFJlK210ZnhablF6QVF4bkdmQXBHOUNiS0VtaTI4?= =?utf-8?B?MDJIcEw0eUtFVS9NUDN0QWZydklVUXRVSDQrdHJlZ005RVRLZjMyNzZrYWsz?= =?utf-8?B?eWFCUkRSRmI4TzA3YjZQMTdFcmV6dDZXR2Vxd3NUTzJDbFlBRUNQdHVHYWx5?= =?utf-8?B?YTRxQ2NLOVZVRmZoUDVld2hkWmdmM3NhWGYzS2JQNlptaTF0M2V1UWtQZ1BW?= =?utf-8?B?cVZ0bE9FK01JRjBLZmZnSWtGRVYyRmpjUXFkQlhYd3pXbDh5UmRWYnhFOTFa?= =?utf-8?B?NTRTT1drWnhRTE9tMVgwSE5zc0IweEpnQTMxNXNKT1NzS0pOSkh1V00zaUwx?= =?utf-8?B?bUlBSlVHY0IrcXNYU2NKMjhWVGRpTDFJSUprby96UWRISzhGZWNDdkJPVTFG?= =?utf-8?B?Rm9ZemsvVlNRRVB6TUJvcWZ4bGIyNWdkYjMxanIyMm45WkpaeVhWZ3NoVjlx?= =?utf-8?B?cC92aGFzNElkSlVCNzhoTHk3MHJzYTdvZDE0MG92WVhEMmZySlpRMjhROVVp?= =?utf-8?B?aWJnblF0M2dDclJHMFFhN3dveXk0ZGZKVW9IbGtTaEFTNE1kOURTa2pjdDR2?= =?utf-8?B?MmY2a0FicnYrZHVFRXhqc3Rnd3o5NnRqajRVVzQyVm9DdDVXWXg5YXRjeGJs?= =?utf-8?B?Uk83UnZwSVJIMEl2VVZvR2JRMGcxVHlzSGEwbnV4S0xKOS96WEhldlhYQ1Vl?= =?utf-8?B?b2JFMjlXMzZmdXIvSUR0VzJIRi81M0hJWVRNQzNIYXNYT0wvdXJJMG05Znhw?= =?utf-8?B?dCtRc2h3VmtJOEZMeVF2NHJzejZRWnI0c2ZlVWhGeVFWcWMvVzlVMjByRjM0?= =?utf-8?B?VS9vb3BOTEJrMHErcTlwTjVpcDFwOGk1NWZuQlZqR1FmbSsxUC9Ua01sdGVL?= =?utf-8?B?VnN5Zm9TSnkvN0Y3bGpMZFQwUG1iTzdTOGsxdWJwSWF2bDhaTW01SkFlcXcv?= =?utf-8?B?TE92R28wNmR6Q2tDcXF0UU5YWnZiZVhmaTFNOFVzVmsyZTRZRm9GRUM2T1c4?= =?utf-8?B?Mms3cUFKMWRhT2pyblM5UVdqOTRHa3FNLzB5cDI4UXhKN2VGNmhxRUZFbk8z?= =?utf-8?B?SDRQTlRheExrYnRTN21sNHduNXVsNHdJSTFwalRXalJwL3h0bmxveURHb3JO?= =?utf-8?B?SjFjcGJMb2Q0UXE3MkNQWmY1b0lIWnR1dHdNc2pJQ2VJcTB2KzNZVDlURThk?= =?utf-8?B?dmNvQTRQVERReFVjWDhoR0hGelpZdUlTZU5vYzVIOGxlS1ppRXhJUTlaYmU4?= =?utf-8?B?ZWZMZ1RlZTcvUGxrcUZBSW5kVkZvZnJXOFhhWDNmSmhSVGJpbHE5ZElVdGMz?= =?utf-8?B?Y0lsQmxsN2hLUk9vNVIwUlBabUlDOUM0ZmFSeEh0RE5tSzdtaTF1aU1kelgx?= =?utf-8?B?OGRHb0hIVEcxM3FYazhIelhIak9WWElWaEk4cFN4azBDOGVZYmsrTjkyWlVI?= =?utf-8?B?UEl4V1JObGdOTGpqS0d4V254MndTNzBWdzJ5SE1yTDh1SVN3R044TzdWcFBM?= =?utf-8?B?TnprK0FSd1NCSlYxdU00d0RCZkJxSU5YWmk0VVllanRLZjM5TEp2b0JHdkVB?= =?utf-8?B?ZlA5QzdvSUdvc1FRY2xSeDN3bFB3a3YvbU1aODZlMnJVMUpsNXNWL0h4UTNr?= =?utf-8?B?bjRFb2VTVHljMWZXa0lCaFNkdENmNmtpZE1Tck53TXZsT3VmWFJDRjJtL2xp?= =?utf-8?B?V0ZQMnBUVlAyVlEwUlJ5czVrbkxROHFLM2RqQkR1QWFXR1JEMG5na1I2aUdJ?= =?utf-8?B?U0ZsbXhxNFljaFN0bzBIZkNQSDUwazFxTWxuQXlpNE1NQmpBdFArUjE0K3BY?= =?utf-8?Q?Xra41BeJr9F8g2uVLdtlcTVe0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8935f165-a8e8-4202-426e-08dabd7dd913 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 09:29:03.7919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KaF0o5QDxo58aEp/HFZO2GsAfpobCkAaDu9n6CRfXBve7a0i4fazkyoRb+XdfE2j9C9l5FKExgjlZOilRCg+Pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9406 On 27.10.2022 21:37, Andrew Cooper wrote: > However, we're also very close to supporting parallel boot.  The > serialising point we currently have is __high_start loading %rsp from > stack_start, because that's a single pointer adjusted by do_boot_cpu().  > Everything else, even the processor's idea of Xen's CPU id is derived > from the stack; specifically in the cpu_info block on the top of the > stack, which is prepared by the BSP. > > All we need to do full parallel boot is an array mapping APIC_ID -> Xen > CPU index.  The AP boot path doesn't use the trampoline stack at all.  > Given some way of transforming APIC_ID into a Xen CPU index, the APs > could pull their stack pointer straight out of the stack_bases[] array.  > This would allow us in the general case to boot APs using an > all-but-self INIT-SIPI-SIPI.  (This is how firmware does AP bringup anyway.) > > > Thoughts?  In particular, is there an obvious option I've missed[1]? Well, I don't see other options, but I'm not sure we're as close as you describe. I'm pretty sure we have assumptions elsewhere that multiple CPUs won't be starting in parallel. Those places will need finding and adjusting. Plus the generic CPU infrastructure also assumes things are done one by one, with (for example) cpu_up() taking a CPU number, not a CPU mask. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 03 09:34:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 09:34:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436179.690278 (Exim 4.92) (envelope-from ) id 1oqWbz-0005X7-69; Thu, 03 Nov 2022 09:34:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436179.690278; Thu, 03 Nov 2022 09:34:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqWbz-0005X0-3N; Thu, 03 Nov 2022 09:34:11 +0000 Received: by outflank-mailman (input) for mailman id 436179; Thu, 03 Nov 2022 09:34:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqWby-0005Wn-By for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 09:34:10 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a982880a-5b5a-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 10:34:08 +0100 (CET) Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-651-l1Cdt_c6ONK92lEfuwtj4A-1; Thu, 03 Nov 2022 05:34:05 -0400 Received: by mail-qt1-f200.google.com with SMTP id y8-20020ac87088000000b003a528a5b844so1441590qto.18 for ; Thu, 03 Nov 2022 02:34:05 -0700 (PDT) Received: from [192.168.100.30] ([82.142.8.70]) by smtp.gmail.com with ESMTPSA id m4-20020ac866c4000000b0039cc7ebf46bsm181307qtp.93.2022.11.03.02.34.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 02:34:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a982880a-5b5a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667468046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gZR2OFVocz6kJ+L6ckJorPi7uGwBY94ZglCfP5VOmhw=; b=hPrxQVEjQcFcsNEBFwrthu/x9kISKIfUa9RLNFMU7m923mjvEE7nf/g76IgOP4RCRDSxdn FCsthxIld0cXg8Vxnp8XaFH6XHC3diyKc/QNncrYZEp+xPJn2t9Mmf7WPInsef/mg9WQbf 2VTVOD1sWYhz/yJJyDrai+Z60kH32W4= X-MC-Unique: l1Cdt_c6ONK92lEfuwtj4A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gZR2OFVocz6kJ+L6ckJorPi7uGwBY94ZglCfP5VOmhw=; b=bt0UlYjJ+p6Go9PwzRPXVnM7UTP3inEaMuUImunmeu9cfOL6p7m2NABwp11Ksu5xxv d31TwPIH8TxpEw+vbLmFCnYeIR1nq6j3u1u9Oj8moAiMGjkAN+UU54FBgxlwQ0K0RgM/ ua98eGJzs4BZzuwwsCnQSFjAHup8cj8D0Iw9XhRMHREhDW/nsCoCMs5SU59QAn+PCKSW eu3rwjKtmzk9OIKAzFvRny/0buPM4NcREpbYr34WrKzvrOLrcKcOB3zHAiIhJJTtfVdo sykNjPB6M1uu1K8DsYsitc3pbLBl3MpulDmSOL3h/gbC+9m3HQAmTYevpWwRQM8TZJk1 v/uQ== X-Gm-Message-State: ACrzQf1sVO+laFuwQGBV2aPmeC7NxULgH2IQnbNvxFg2Cru0phex577o LzvshjuIkTvMEHyBHsMd3zMvDwijphA9SLuWsex52e+5Z7zdc7W9HarUmqLWWxJE7eZ/UepjMHt bTKR8FAYmrbCxzltZm50fpqmUCbk= X-Received: by 2002:a05:620a:1476:b0:6fa:4c67:83ec with SMTP id j22-20020a05620a147600b006fa4c6783ecmr9443015qkl.23.1667468044922; Thu, 03 Nov 2022 02:34:04 -0700 (PDT) X-Google-Smtp-Source: AMsMyM61B3CKx0tKxBrzDYllgkLf+57PFgkDaree4gsL0Eyl4wlfGwGUj1xL01wTG6Emx1VJNx7whQ== X-Received: by 2002:a05:620a:1476:b0:6fa:4c67:83ec with SMTP id j22-20020a05620a147600b006fa4c6783ecmr9443002qkl.23.1667468044643; Thu, 03 Nov 2022 02:34:04 -0700 (PDT) Message-ID: <0fd82709-7612-25e0-66c0-d9494931d8c4@redhat.com> Date: Thu, 3 Nov 2022 10:33:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v14 16/17] tests/qtest: netdev: test stream and dgram backends To: Jason Wang , qemu-devel@nongnu.org Cc: Thomas Huth , xen-devel@lists.xenproject.org, "Dr. David Alan Gilbert" , Anthony Perard , Stefan Weil , David Gibson , Stefano Stabellini , Paul Durrant , Eric Blake , "Michael S. Tsirkin" , Paolo Bonzini , Markus Armbruster , Samuel Thibault , Greg Kurz , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <20221021090922.170074-1-lvivier@redhat.com> <20221021090922.170074-17-lvivier@redhat.com> <700ef645-6cb6-66e6-00a9-3db187be0c43@redhat.com> From: Laurent Vivier In-Reply-To: <700ef645-6cb6-66e6-00a9-3db187be0c43@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/28/22 07:04, Jason Wang wrote: > > 在 2022/10/21 17:09, Laurent Vivier 写道: >> Signed-off-by: Laurent Vivier >> Acked-by: Michael S. Tsirkin >> --- > > > I got this: > > 63/63 ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: assertion failed > (resp == expect): ("st0: index=0,type=stream,connection error\r\n" == "st0: > index=0,type=stream,tcp:::1:40389\r\n") ERROR > 63/63 qemu:qtest+qtest-x86_64 / qtest-x86_64/netdev-socket                  ERROR 5.29s > killed by signal 6 SIGABRT > >>> QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64 MALLOC_PERTURB_=96 > QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon > G_TEST_DBUS_DAEMON=/home/devel/git/qemu/tests/dbus-vmstate-daemon.sh > /home/devel/git/qemu/build/tests/qtest/netdev-socket --tap -k > ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀ > ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― > stderr: > ** > ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: assertion failed (resp == > expect): ("st0: index=0,type=stream,connection error\r\n" == "st0: > index=0,type=stream,tcp:::1:40389\r\n") > > (test program exited with status code -6) I'm not able to reproduce the problem. Is this 100% reproducible? Is IPv6 enabled on your test machine? Thanks, Laurent From xen-devel-bounces@lists.xenproject.org Thu Nov 03 09:59:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 09:59:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436189.690295 (Exim 4.92) (envelope-from ) id 1oqX0M-0000s8-4w; Thu, 03 Nov 2022 09:59:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436189.690295; Thu, 03 Nov 2022 09:59:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqX0M-0000s1-29; Thu, 03 Nov 2022 09:59:22 +0000 Received: by outflank-mailman (input) for mailman id 436189; Thu, 03 Nov 2022 09:59:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqX0L-0000rq-3j for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 09:59:21 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130073.outbound.protection.outlook.com [40.107.13.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2cb64a2e-5b5e-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 10:59:18 +0100 (CET) Received: from AM6PR10CA0094.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::35) by AS8PR08MB6645.eurprd08.prod.outlook.com (2603:10a6:20b:38f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 09:59:14 +0000 Received: from AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::27) by AM6PR10CA0094.outlook.office365.com (2603:10a6:209:8c::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Thu, 3 Nov 2022 09:59:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT041.mail.protection.outlook.com (100.127.140.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 09:59:13 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Thu, 03 Nov 2022 09:59:13 +0000 Received: from 1b20ef9a2768.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4027BB65-1B8D-45C1-85D3-362CC7E0588F.1; Thu, 03 Nov 2022 09:59:07 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1b20ef9a2768.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Nov 2022 09:59:07 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VE1PR08MB5709.eurprd08.prod.outlook.com (2603:10a6:800:1a7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov 2022 09:59:05 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Thu, 3 Nov 2022 09:59:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2cb64a2e-5b5e-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=d6doMZEylbqprZPDUNwYjLTZf8zpngl+6OhBNKH2Pw3upJvgPMBvIKrpQ5QSg9N+A3qJ/IDWeMqG2m4raTu+/fPBrQvfobc1wlj1Uh1uEHvl/35wIEBnqgMWyCnHhJCBUcn3fC+eHpSkST8kAuTYDcQl+SXGY9sojCyMv9KT/yLr2O5tP/hNAxyA7VDQfeZHkxdpir3X+lLRKfwHkg794rduHSIIbhzH61k+dDD+tXFovC9R1RbdV/M+rWxel3SGv3G1FROpthKNe3f1gao1MNNgYss9JoB6ouxzTMFyl02UeGtJ1TrV6D39tYYAUb3ewrfn4Oefw9Q35gBcMbR0rA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t0uC2b2s3F4TvY3GnAjxpg39NUmcfSnu2oJyIz8MvhU=; b=JD+eigbUzvYmaUo7gHP+NGd6IfpTpe7CSqGxgrz1gasiDij/R0mQ+GXwZ6MkmVBcLdjDO9CAOJGPjw91xqa93E5G87xOqgVBszs8YVt/Pra03XeUkPlvmzvXbT9GcS9l/2ka1QI9fGwBM+4k1hEPq6Amc1CDIkZI038HJr0sz5uTBhU0ci6PK1ANlukP7/o+1Otu/UTXv/DX0RDLNWAUkolI25qRNIksiaK1RSPeXJxGNhIUVVzCadeZ+pUBsnd9Cs+03mE55OzstUeWYN7hG93cJAiOubeb8HsSVPwqhv1BmngDxuBqy4KpwG4s0pYAMU74XQHaCGLcSJOUm50YJw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t0uC2b2s3F4TvY3GnAjxpg39NUmcfSnu2oJyIz8MvhU=; b=JX13WiOOpmH6I2J05JG5qmL4RoIiO/Vp7LcfysTiqgokawdzllsbMaDoGnS7f2Nd/NM+UcMyRhATvPVFqxUS1VAxTJQ6srQpyfzqZLJ94QUBwIgLfDW+QN4zuRpxYZEs2hmqR8ryCXZfYsb+46yyfWMajNB6lED9SOHuEfjRqMU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=InfAgC48BeqT4hVM5Q1MqdS41VJC2JJqtFIkayL4yADcw3l5VJIyrUiUG5UlXvqv4/6GhSulbbmB1QphvjLl83yXXPIkUZ9KuTOGZhJjX5NEVz8TntaZwjfpD874DU9lTexoYhqgwerjgipsKk2+liYD6wjmrpKzHayZ9S2wCy4Mq8u94ha2AJfgMumohd/+qyfMlGwcp26SYi+8Y6cr3Ks1QNct3sy6G4uPLLxuXrpzt7z9D/yHbbwZV/XeZFWsz5eDZ0hCW8144vHGGcc95W3YEdt2LP46/XpAvoRMk6/tKjrjHiBqTzPOFk5iXkzf7amXnwWWdnFZya5Ujir9Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t0uC2b2s3F4TvY3GnAjxpg39NUmcfSnu2oJyIz8MvhU=; b=jo1XpLSc2FKkr3TzQCHCBf5itaI0AYke43541BGoX4zqqmYB19AZXqKoNNHk25jHpGtVFoN7JM7td+Pjv67bEjwzGK/CkK/OpV5X8vS0eX41wHnx3lQaMXaTXHooacKXb32cvg5FJL/KN0doRB7YcgIBGezFKTtLlqAjaA7UMcPNJwWK8ah2lYZvBIqdtB/PrgQ5vYtSoxXARxipvbl4lp6W1QNPU+OL9ehZCZEwuNS7IA1E0tHdQKywLyEvg6IfNr1m/pUv1Mdg710wf03q7y04bXFWM3k0QfOwx7iHtbt5gbZEeDjCnR6/ySUynEBrgrHdA14G7ChEjhK5nFzSAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t0uC2b2s3F4TvY3GnAjxpg39NUmcfSnu2oJyIz8MvhU=; b=JX13WiOOpmH6I2J05JG5qmL4RoIiO/Vp7LcfysTiqgokawdzllsbMaDoGnS7f2Nd/NM+UcMyRhATvPVFqxUS1VAxTJQ6srQpyfzqZLJ94QUBwIgLfDW+QN4zuRpxYZEs2hmqR8ryCXZfYsb+46yyfWMajNB6lED9SOHuEfjRqMU= From: Henry Wang To: "xen-devel@lists.xenproject.org" , "xen-announce@lists.xenproject.org" , "xen-users@lists.xenproject.org" Subject: Xen 4.17 rc3 Thread-Topic: Xen 4.17 rc3 Thread-Index: AdjvatWhp23HfwW2SpaZxhLMVRhDUA== Date: Thu, 3 Nov 2022 09:59:04 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 714023CD61CB2B4280587CE8B5747C3A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|VE1PR08MB5709:EE_|AM7EUR03FT041:EE_|AS8PR08MB6645:EE_ X-MS-Office365-Filtering-Correlation-Id: 3b792e93-9530-4ac8-702a-08dabd820fc3 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9NBG0QrMBDK4+aKiAX4DPOb03jQubPaHRmFySaCzHlRrdFBmh58i3IixSt1f0uyXPcg27y6oZE1d7MWEjR/MwGA93JIN1sjaDrXgm6PbCtvAm8DZ4sZ9N0VoHmoBCyAPhnKfNvkOzADiMt9tNoMOmCIbdTZCKj2P+rFX4hQiMdS+O7KUtX7lhkIGHtMFE0HjJs0QoLk2EW1eYTH9aLVnS19H8RReVtfaTuAmI8St1MAtBdmM+eLsL1VHPH0SJM4wroqK5VJ/CupFH5QH3iaPjlj09VxFhpSJxdYMmQr0HQr3THST63DOWvNy8UZ+bXdEmhWBzAIEhHwMGeWDOphXmPtb00SAQpwKcKs79cuYHTo4mxgeKDavP17aYwNOnuYzbN4m1+vCG8YMg05irnyoshJ6yyOBJZpYb+BJCd3ocPSysqtzpZnMfaa7sVqAyt8A9nM08h4008TEXfHndT1C4UsrRu5uzrOCCk+UvHFZ5PCRet9jlpAQVbkRVKnvuRQ4geNYVybMurl8OdC0Wn9XIv3CHsZMKayYUsfOgAtuvx/ufdnaP6aZrckAqksowto0FZy4Z0Nk8mw2kcF+GjCb+9cMhlHeR4EmCw6ZuzOtJVdGBPqDFL8eaka6Zc/RXCON5DN9RfbiVWtozelzMGuA5z/HUYXcHGhVY0U7UXfA1IC7Oyho9ZLSfBrEFkVa8YeCf0PtTcTgoV9h/vgbW6Bndc4wEZkJQcIOk08VzxJBRmCKT6C6zGxj27h8izuglXT+H3FPY/jcG7VpzAGFibctI05pHl2DTI48qFHwMb8sjAuAz/JMr0l3+DMj4YxoWTVc79W078FeRRf70d8QklQs5A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(366004)(136003)(376002)(396003)(451199015)(38070700005)(110136005)(478600001)(186003)(76116006)(450100002)(7696005)(2906002)(8676002)(66946007)(66556008)(71200400001)(966005)(9686003)(41300700001)(7116003)(26005)(83380400001)(5660300002)(4744005)(8936002)(66476007)(66446008)(52536014)(55016003)(6506007)(316002)(64756008)(122000001)(38100700002)(33656002)(86362001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5709 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6e9a6361-1c6c-49b4-0f14-08dabd820ad0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rDfXsi8xgvMmz8QYObVqr2Edf5rCRGyrcHNLoM45plQ4EHzN/1ZlOJdWJbQEArHhoPUxb7OPPKyK4v8bmDo/Wa1TbVr0Cy4f+ofFrjmPpbRM55f9buJV0e50uuZXDCG2Jjk4w5NgXVpLu3ki46OWaP+kqZoL4QQSF/HkQaEpklHG/xhlBGKvyWLhJok9BlQA5x2OAKf1swtaAV06tHMRZKHY93w2G5ey0bpbPXylNl1l7xqMjTx2UcMHALQkQf73FTBtrxaRmdyYlUg4kgVF6A9IsCmuXQ8EPwYt3NQZA2CEEEAUrDiOyWMLsx92fJOztOMYspU95uxXm+Y4EtbO2Qb6qvMH5DrGwBbDKuQB1aTLO38mHbC1HWZr3wo06DYvSM7ahgOk26mAON5JzfQK0cm7QwMhEgfEY8LaKpBykqYI8IlJT13mCAPVdTV7Y284tGx4IkI+dN5v5BLfAaODSDr8ZGntypEct/0/lXibFe71AeNWfmNEEg6pUdlkaVLulfy15XfeRlPYUP7nBPNjluCwKJkaaffqFj4vQvXnUC1hr1XTNKftutxQO6iQ+4aJUNiyVUbJqVBgxV5DDrLW+GinCvWQ6q+JpMfkyun+IYBHvxI2N1NbiKd0pFHSerEs/U+n33fanOmjivRasYaT+EVMYdnCMLe/wwgux509QujRkYtFa5jKjYIM9NtcJb+YVp8wFf6FxPZl10Li0DakLcfu5XEEEImvtFfi/iSNWZmsGU9CFu0hYikGFGNmsWizrFXF/XfzuKnGKbPBjKeO1kRtRwj8SrsnHZSZnrmlkw8o7Ulu/7lA972/+q7BvehEGBOokHxGkUtTIcRusfsX3A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(346002)(396003)(451199015)(36840700001)(46966006)(40470700004)(52536014)(41300700001)(8676002)(7116003)(5660300002)(478600001)(8936002)(70586007)(110136005)(966005)(33656002)(70206006)(450100002)(40480700001)(316002)(55016003)(83380400001)(81166007)(356005)(36860700001)(82740400003)(6506007)(7696005)(86362001)(336012)(186003)(40460700003)(47076005)(9686003)(26005)(82310400005)(4744005)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 09:59:13.3273 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3b792e93-9530-4ac8-702a-08dabd820fc3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6645 Hi all, Xen 4.17 rc3 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.17.0-rc3 For your convenience there is also a tarball at: https://downloads.xenproject.org/release/xen/4.17.0-rc3/xen-4.17.0-rc3.tar.= gz And the signature is at: https://downloads.xenproject.org/release/xen/4.17.0-rc3/xen-4.17.0-rc3.tar.= gz.sig Please send bug reports and test reports to xen-devel@lists.xenproject.org. When sending bug reports, please CC relevant maintainers and me (Henry.Wang@arm.com). Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Nov 03 10:36:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 10:36:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436330.690355 (Exim 4.92) (envelope-from ) id 1oqXaH-0001g6-4A; Thu, 03 Nov 2022 10:36:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436330.690355; Thu, 03 Nov 2022 10:36:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqXaH-0001fz-1P; Thu, 03 Nov 2022 10:36:29 +0000 Received: by outflank-mailman (input) for mailman id 436330; Thu, 03 Nov 2022 10:36:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqXaF-0001fo-RL for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 10:36:28 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d1476cb-5b63-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 11:36:26 +0100 (CET) Received: from mail-dm6nam10lp2100.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Nov 2022 06:36:22 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB6778.namprd03.prod.outlook.com (2603:10b6:a03:40d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov 2022 10:36:20 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%5]) with mapi id 15.20.5769.021; Thu, 3 Nov 2022 10:36:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d1476cb-5b63-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667471786; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=07Y6xmf+d46i1QrVg+lGFCq4Hhz0Ac+JJLWYw9JyAUQ=; b=T2Z6wkM+/TDmlcXaeHGVjj5kj2mvNEoXaZV/gYLU4+PzOowFu5FXS9ej xyEgsTrErfIRPhBiEXRTHOBzJMY+FM3tE8m9mfduVZ76HlGRQKxFVbuvR dhRHw2eOaynyUbnz0JOhWEp1kQUYETbhRqaIfmqtVEx5R1rdOJF8/hggq U=; X-IronPort-RemoteIP: 104.47.58.100 X-IronPort-MID: 84508631 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:90WwYq6RSBC53ty9eCf9lQxRtOPGchMFZxGqfqrLsTDasY5as4F+v mAWCziPOfyIamT1edAibo6xpkoF6J6HzdYwSQI9/C41Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKkT5weH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m9 sI7IxcrTzO6tu+5h6qyavVtqNkpBZy+VG8fkikIITDxK98DGMiGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnEooiOCF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efwX6jCNxJTdVU8NZBuVqsmGYPJiYwVECb/N271UDjdPVAf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmtx6zO8kCmD24LZjdbbZots8pebT430 l6Emfv5CDopt6eaIVqG7audpz62PSkTLEcBaDUCQA9D5MPsyKksijrfQ9AlF7S65vXlFDe1z z2UoSwWg7QIkdVNx6i95UrAgT+nut7OVAFd2+nMdmes7wc8aIv7YYWtsADf9awZdN7fSUSdt n8ZncTY9PoJEZyGiC2KRqMKAa2t4PGGdjbbhDaDAqUcythkwFb7Fag43d20DB4B3hosEdMxX HLuhA== IronPort-HdrOrdr: A9a23:x+aJZ6sY051RKnQ2g3CaT9Kv7skD7NV00zEX/kB9WHVpm5Sj5q aTdPRy73HJYUUqKQgdcLG7Sda9qBznhPxICOUqUYtKGTOW31dAT7sSk7cKoQeQfhEWn9Q1vc wLHpSWSueAaWSS5vya3ODMKadC/DDxysCVbInloEtFfEVHUY8lwyBSMTajLwlKbCcuP+tIKH PW3Ls+m9PpQwVtUu2rQnQMQuDZp8fInpfvewQHCB4s4BSPizTA0s+GLzGImhgGXyxGxN4ZgB n4eiLCl9meW0bQ8G6n61Pu X-IronPort-AV: E=Sophos;i="5.95,235,1661832000"; d="scan'208";a="84508631" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d17MZRDXkUUIAJnJxtQZM6sj86vLZ/4utr/yK932tKModGEVLkNjsynX0g/ki3uBwOGzCOz6M2Y/4jyBp/QqbHf7/UXItGGjGNflDDSV7o/WZ/kErdsS13KfhoMGpd3vKJYheYpVgfdLptn2seTuP/DUuOxg6HGhY94Qse7biIR03f4PoMMZcj4dZmH9MfI+uYcUszJhSszaF/OgI5hbjsCYcQhHOZxQdt7jJe0Q/8VQwc4U0EbHtwB20gS0yavZi6yZkSs+KtiOWKH7HCzrVlVKu8CeBK8NBoYY65fZyNNsN2ngxtzpq0vlvB8rL3i/qr0DGKW5ZyJU6jboQeXQ+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MOlqFFdlqkSrSuHO7CBiVu6CfT8Hc2+Tr2HU8NrDTG0=; b=MuAUXhJBU1m33lkhypHozFLHNnPpAa4dVj7g/vm+TAxP4nxpyHOpTJS2AnL08C2MVyO5/ZAv4SO2dI9w3H3VLFi1r41MSaawNUMNesJ9xHqpdWZV0Ev4Gv5ivR+mwNlgvKs+G9Pyad3tbDCb+vx2bVfcLyDUS43W6hS1Tytrpay9Kgzk/tnHHec6sXaz2xtmFvsmKDQfcEJHq7WTb6QEYndDMFSN8uMLEhtChzK109BzR+k2fbmoMrle0V6uexBcQDegy3qsbTO4Y67I9KzTrZnV60vd0QLR7UoeMLW085ISC+5Zoyq1g704U7MC65c7BvkrMU2ry7/+aO+B5D9aMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MOlqFFdlqkSrSuHO7CBiVu6CfT8Hc2+Tr2HU8NrDTG0=; b=F6d0dHFIIoh+/Xdf7uqYeiykgLP4q+kmmaD2JtEXTfaY+5jUZn0tkWX6Vi4PQsu63qS10VF7IkFfMv8wb1JLS7Ui+U3ia/P93AUgjt3AiCZvveSu6+QtIumYOj4NS4S2OIFSwmOSEkxr82GkP3iaOt45QXvU2Chcg/K3Z/SlvR0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 3 Nov 2022 11:36:15 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.17 v2.1 2/3] amd/virt_ssbd: set SSBD at vCPU context switch Message-ID: References: <20221028114913.88921-3-roger.pau@citrix.com> <20221029131258.95811-1-roger.pau@citrix.com> <198d04be-e7f2-dc11-18b7-ef3352d07b80@suse.com> <20869a2c-224e-698a-b927-96d6ad752b9a@suse.com> <37c145b3-9667-200d-c13b-912f3d9b8a0f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <37c145b3-9667-200d-c13b-912f3d9b8a0f@suse.com> X-ClientProxiedBy: LO2P265CA0430.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::34) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6778:EE_ X-MS-Office365-Filtering-Correlation-Id: 7cc42ae8-1ea5-4160-7905-08dabd873f38 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DijVg3qFJMbkU3hOLOM2ArpNopw44BpeAbpsGRTcXp4/Q31rJo/Pkk77KI10FVP8UxPKvSGGc+6otRxYdPjItDr5fiDWMj3+/4GjPkwcb/cJIUdEXP7tZoGhud3R6FPEcUjqM4JLaZwabOb38loZKd5ZEeUw5GnJ3movlN7Ti4Ah+OA167KEAXPOpFUKczGcIW2nxJK0tLC7lHZ4VXarW5MixCthcW5x42NJRiPtZai4qCcyziHK3hpPTIFVfoiyoFjb+HtqHqyaqKaosFICqikK4jd9EssEfGWX+mCHUySMXJJ35ARLmm2qW22CoWEFEpknK5iI4GT66R6TVybE74VGP51I8a7kLXgV2vnA53RXZXyZWkq3govntjaTHNV3iF9p+0ctFx7UhozgC3AY7ufCTq+Vh+aB5OWIlu82XVbRvl9lz/LODDtz8hnNFELqLdsW2HpHtqDsuBFFU8uIkBXU0wZVpDwRk7AicxptTSuSuAPR6I5c4N1NVZzKTvPM0lsQvGpBBIp5iJHPLPjuuVqYv/exb0V58qpQbrHbxg0N+fXH7l8JGAoZawm61Wt0Pl28IqJ3oa/S++2ut/0BplJF2EYIEUAwPeJoAZ5RXEIgt9kXgxDyYtmFYoy4dE7tnH6iQPKMmgVZw51wdSKHXrikJ9tg3Zmh5P2F3qmVOcbD+s5zjThFPTpJKL6UY0/KY46smiQpr1+1JuvhM7kjIw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(366004)(396003)(136003)(346002)(39860400002)(376002)(451199015)(85182001)(6486002)(66899015)(9686003)(86362001)(5660300002)(8936002)(2906002)(38100700002)(186003)(316002)(53546011)(82960400001)(54906003)(6506007)(6512007)(6666004)(26005)(8676002)(6916009)(478600001)(66946007)(66556008)(4326008)(66476007)(33716001)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjhLZ2RTM3cwOStuRzZJSDM4MGRsZ3lQLzdndDZ6dHZya3ExK2dRU1JPelNn?= =?utf-8?B?L253anJWNUdRRk9QQ3RJMVJQYnBOVWRucHI3M05qS25Xck5OUFlsVVFFRHJj?= =?utf-8?B?NHNZRlRCUWZOcFdBZ3F3d3hsU29iZ1JiZTZ4Qk1NU29QRENrMEdYNjNlM3Q4?= =?utf-8?B?RWZQczQ3RnRLekRYSlgzelJyWGNqRlR1WnFrZFJPNVQzWXE3MXE2UEVkaC9Z?= =?utf-8?B?ais4clBsOEhvSXdZUTBFU0NOR1Y2bTk1QlU4UGlTbm5SbC9sQmFrL0dnM0NW?= =?utf-8?B?ZU9veWhQRFAvbFU3RVlrQTl4dXFEZ1dDYk1WaU5ybDlXOHMzTjQyNUNKMTI4?= =?utf-8?B?aEIza0ViZDdYNi82c3VEdlg5Y09TK3NxSStmc0ZCWDZoeXZWaXNkRmEzWWJO?= =?utf-8?B?Y2d3blA0NUExbEFqSGQwZVh5dFBnQlJiWnFIM1lXTnoxOXFvN29nTkljaUdj?= =?utf-8?B?bnd4OEdyV28zR0NsZnlLRmFUTStaNS9CWWZHUWZjNlN4QjZmUzQvUllva1Nm?= =?utf-8?B?cU1sN0JLM09qL2tqME8vZW1hd0ROUnZFaGIrVFNHNDNuYmpkQU9SSmpkK0xx?= =?utf-8?B?R1h2eHVTbUprdVpKZGJ1cHVHcFBuQzl0VnFWYy9lR3ZuNmJCaE5MMGtBTWZG?= =?utf-8?B?TG5YL1RJU21ybk5xcGkzSWVIdXExM09IQldBRS8xUDNJcjg0N0RyRGhHM0xp?= =?utf-8?B?WTV3WW85aENIMFdzV2tvY29yMzRGcEdJVXEwSXRHWWtNY1NiU0ZoQmFKTEhM?= =?utf-8?B?SmEzK0dKWjZ5LzJ6RU9FS2U3LzVEMzJ5Nm91aXF4UUNpUjVhQUFzYjAzUHpT?= =?utf-8?B?UkRwanVLREo3VEs3VnhaVjJRUjlPUlZDRWNuUlpMdWlXVmU2TkNUMC9xcmE5?= =?utf-8?B?aG9KbExrVHNnNXJaZEpCMWphc0IrMVBieGtwYXBabUttdlA3QTVXcW55bEFn?= =?utf-8?B?VFh5WWM4RlNuTUx6R294Y3Q5QzlTL01HUXhNUk5jRnBRN2NRd1pjdVdyRzdy?= =?utf-8?B?NFppSzZxcXhvS1FRRHhmWjE2QVEzYlVzVW9uUVA3eVBESGsySXVwdklhWTFo?= =?utf-8?B?eVZJNXdYaXM5MXZRMmFLOU51dkY1V3Vna1BkQzkwM3AwaThPWW1KaytTek1u?= =?utf-8?B?QXhaV2ZlWDJGN2FJbVhIc0t2SHRSVFUwVjBEWCt0QTlNVkNnaHZmaEZEZjlR?= =?utf-8?B?Q0UxNmQyZmFwMk1pVTBvQnZCVE1LRG8xOEJLSVJNVDZ4VC8rZXlUUVNHRGc0?= =?utf-8?B?QjBjNmozOVdpeENyZHB5eEFtUFBXemJJK1hGdC9wcC82Z3c4VkNsOGREYlVs?= =?utf-8?B?d1RhRmV1K0V1emJTcDloS1E0SDd1SkNVcXVRdlJKeGVzMDBVaHNiSVBhYkEz?= =?utf-8?B?WUQyL3grRjNrSjd2QVJ2YlZ4NlE2alM2VHhndGJwRGZqODJlTy83Rzcyb3U5?= =?utf-8?B?RHEyTFJNb0hLZFZtNVFnRVNyQVJaMEc5NEQ1TytzNFdWcjBzVWJ6L2Z0ZzJM?= =?utf-8?B?WnJIcFUwUHpUWTNlcWxrb1FURzE5K0FZNnBWak1MMEpudk9FVXEvcWVFeWgz?= =?utf-8?B?QWhzRDl4RWZoY3ZlNHZSdVhjTnBZdlUwUDdvNTdRUVZPdm0wVVFMeit2eEZ6?= =?utf-8?B?WXVGQjcvSHdxcUNHeUpSc1NQYVlIc0p0cWljVFZJdjg0VXRSYk9oaWlnVnlo?= =?utf-8?B?TEU3SE9VVnlFTm1ldGRZTHM5WElDLzdEQnNVejM3QW1oMWZRaTh3eTFUVmZH?= =?utf-8?B?WVRIdHRLUGE5bjNLdTdRZjFLaDlzT0pWVkpwaGdDdzl4T2lBcXM2T05udit4?= =?utf-8?B?RmdPRnA3b1ByRktiYWJoaUtEalJ3MnBrV3UwRG1ndG5jVEw3NlVObGlUS0tl?= =?utf-8?B?YUJoZUp0cWlONXVXc242L0VHOXRKd3BhcjJhNXlDcDVQSmxyV0pyQ1Y1NGNX?= =?utf-8?B?ZTlOOVNVM2prbGJmcEFSSFdHdGpsa21jQVhiMTZBS0dlRlEycHYwM3drZ2lK?= =?utf-8?B?aUsrNDg3a3FxUFVQcmdXU3ZQYlVDUEFIN29XT3FISk5vOGRiNi9iQlIyYURq?= =?utf-8?B?VFc1UGtWWFhKTmxiZ0h4RU0xbTcwZGl1K1hCL0Q3WEVTUDA0aDBSWjdUZEFU?= =?utf-8?Q?SutNLjAt+85nochH+XeTfSgU/?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7cc42ae8-1ea5-4160-7905-08dabd873f38 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 10:36:20.8058 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ikCGYHiXZa7Axjz4yD07D/eq/jXr+Dzr49AroImMPGhjH14/yaPlYUNtru2vqrm3oo9HKPTNa3NlQXfX4MD6LQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6778 On Thu, Nov 03, 2022 at 10:01:49AM +0100, Jan Beulich wrote: > On 03.11.2022 09:52, Roger Pau Monné wrote: > > On Thu, Nov 03, 2022 at 09:09:41AM +0100, Jan Beulich wrote: > >> On 02.11.2022 18:38, Roger Pau Monné wrote: > >>> On Wed, Nov 02, 2022 at 12:49:17PM +0100, Jan Beulich wrote: > >>>> On 29.10.2022 15:12, Roger Pau Monne wrote: > >>>>> --- a/xen/arch/x86/hvm/svm/svm.c > >>>>> +++ b/xen/arch/x86/hvm/svm/svm.c > >>>>> @@ -973,6 +973,16 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v) > >>>>> > >>>>> /* Resume use of ISTs now that the host TR is reinstated. */ > >>>>> enable_each_ist(idt_tables[cpu]); > >>>>> + > >>>>> + /* > >>>>> + * Clear previous guest selection of SSBD if set. Note that SPEC_CTRL.SSBD > >>>>> + * is already cleared by svm_vmexit_spec_ctrl. > >>>>> + */ > >>>>> + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) > >>>>> + { > >>>>> + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); > >>>>> + amd_set_ssbd(false); > >>>>> + } > >>>>> } > >>>> > >>>> Aren't you potentially turning off SSBD here just to ... > >>>> > >>>>> @@ -1000,6 +1010,13 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v) > >>>>> > >>>>> if ( cpu_has_msr_tsc_aux ) > >>>>> wrmsr_tsc_aux(v->arch.msrs->tsc_aux); > >>>>> + > >>>>> + /* Load SSBD if set by the guest. */ > >>>>> + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) > >>>>> + { > >>>>> + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); > >>>>> + amd_set_ssbd(true); > >>>>> + } > >>>>> } > >>>> > >>>> ... turn it on here again? IOW wouldn't switching better be isolated to > >>>> just svm_ctxt_switch_to(), doing nothing if already in the intended mode? > >>> > >>> What if we switch from a HVM vCPU into a PV one? AFAICT then > >>> svm_ctxt_switch_to() won't get called and we would be running the PV > >>> guest with the previous HVM domain SSBD selection. > >> > >> Would that be a problem? Or in other words: What is the intended behavior > >> for PV? PV domains can control SSBD via SPEC_CTRL (only), so all we need > >> to guarantee is that we respect their choice there. > > > > If the hardware only supports non-architectural way (LS_CFG) or > > VIRT_SPEC_CTRL to set SSBD then PV guests won't be able to change the > > setting inherited from a previously running HVM guest. IMO it's fine > > to run Xen code with the guest selection of SSBD, but carrying such > > selection (ie: SSBD set) across guest context switches will be a too > > big penalty. > > Hmm, perhaps. Question then is whether to better turn it off from > paravirt_ctxt_switch_to() (which would take care of the idle domain as > well, if we want it off there rather than considering the idle domain > as "Xen context"). Or, yet another option, don't use > *_ctxt_switch_{from,to}() at all but invoke it directly from > __context_switch(). I consider it fine to run the idle domain with the guest SSBD selection, or else switching to/from the idle domain could cause toggling of SSBD which is an unneeded penalty. If there's an specific issue that needs dealing with I'm happy to adjust, otherwise I think the proposed approach is an acceptable compromise to avoid excessive toggling of SSBD when not using SPEC_CTRL. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:07:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:07:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436336.690367 (Exim 4.92) (envelope-from ) id 1oqY48-0006Op-Cy; Thu, 03 Nov 2022 11:07:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436336.690367; Thu, 03 Nov 2022 11:07:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqY48-0006Oi-AG; Thu, 03 Nov 2022 11:07:20 +0000 Received: by outflank-mailman (input) for mailman id 436336; Thu, 03 Nov 2022 11:07:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqY46-0006OJ-Nu for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:07:18 +0000 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [2a00:1450:4864:20::436]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad8b7d40-5b67-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 12:07:17 +0100 (CET) Received: by mail-wr1-x436.google.com with SMTP id z14so2206443wrn.7 for ; Thu, 03 Nov 2022 04:07:17 -0700 (PDT) Received: from [192.168.182.175] (216.red-88-29-181.dynamicip.rima-tde.net. [88.29.181.216]) by smtp.gmail.com with ESMTPSA id l16-20020adfa390000000b002362f6fcaf5sm619394wrb.48.2022.11.03.04.07.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 04:07:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad8b7d40-5b67-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ioAj/03PTFf/uaiN9wTTpWC9jrZkUh7XgFAdXmVFeT0=; b=j0V8X8STX7IWgaMvz/VBrVye0Zw1tiw9dS0tetGfb65dn/24Em4poHnWrjFjPRu1rW QPF06iaqBLCbRK6LCjsRkgQmrsZbVF0k2ri6CHtKeYb+paUGktf4erRVPj4BQT3qQQjB 29a584Pa2jOV2tTR2UAMow5MJ2eJ++FQDxg65xYCJeW+ps2Osv1OeKUFXUoLCgAr2g79 oQP9zTPuBFnyFufkdvLPz0fQB1DlD33oHRBxenaInenjUnLdj2riIZTh3djfxjPzPvYs zsGgVwuuhjJkz5YO6NIgE1ymjoIaajiow9YxleDaIhXGJK/WusZHNC78e14PJ0+zE/XV zd2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ioAj/03PTFf/uaiN9wTTpWC9jrZkUh7XgFAdXmVFeT0=; b=2LwxZDECvuAwqmqkpCfv9/5V/O23NjFqvhgfEa2BlRy0p3tjysITe7fb6CwYZL1OPD qfDcwkjf+vMUdsRWODAcaEt5MI2BgLYqMTrl22EecVmQobhLrLzqjaLC6KmS+9m+X9Hn dn0D8Uv56cuM6zgAEfxnctfxTVW9lzNpCgIATurHbPW7/h71BtLChYkZrz84LEg2eN/9 EMwTvOPrHAkFC8sLBaBAXwJYYkv7lew28RpQ0IcYp4wRhYNHnKfaLt8t/IyeVqoP7QY2 aKkng+lzf4mwK84hVTkiRyh7a7mdmsxFFPtKnyU+ou3n4m67tcrjqGZ95aRJHA4mk9IR bUnA== X-Gm-Message-State: ACrzQf2WCO45x2sPygWNXuxrAj9dBpLJMA6mnoXIuSERsHnM7DEZoOWQ I3c3udF5/ImxaPL6kZsWtiCI5g== X-Google-Smtp-Source: AMsMyM7NGSI02kuYWsWBe/V7h4jAfDD1+ML65sT6lw5hyMNAqTtrwDeLdnnqMIolLSgYthT6UlPUSg== X-Received: by 2002:a5d:50ca:0:b0:236:776c:3075 with SMTP id f10-20020a5d50ca000000b00236776c3075mr18645206wrt.656.1667473636709; Thu, 03 Nov 2022 04:07:16 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 12:07:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v14 16/17] tests/qtest: netdev: test stream and dgram backends Content-Language: en-US To: Laurent Vivier , Jason Wang , qemu-devel@nongnu.org Cc: Thomas Huth , xen-devel@lists.xenproject.org, "Dr. David Alan Gilbert" , Anthony Perard , Stefan Weil , David Gibson , Stefano Stabellini , Paul Durrant , Eric Blake , "Michael S. Tsirkin" , Paolo Bonzini , Markus Armbruster , Samuel Thibault , Greg Kurz , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <20221021090922.170074-1-lvivier@redhat.com> <20221021090922.170074-17-lvivier@redhat.com> <700ef645-6cb6-66e6-00a9-3db187be0c43@redhat.com> <0fd82709-7612-25e0-66c0-d9494931d8c4@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <0fd82709-7612-25e0-66c0-d9494931d8c4@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/11/22 10:33, Laurent Vivier wrote: > On 10/28/22 07:04, Jason Wang wrote: >> >> 在 2022/10/21 17:09, Laurent Vivier 写道: >>> Signed-off-by: Laurent Vivier >>> Acked-by: Michael S. Tsirkin >>> --- >> >> >> I got this: >> >> 63/63 ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: >> assertion failed (resp == expect): ("st0: >> index=0,type=stream,connection error\r\n" == "st0: >> index=0,type=stream,tcp:::1:40389\r\n") ERROR >> 63/63 qemu:qtest+qtest-x86_64 / >> qtest-x86_64/netdev-socket                  ERROR 5.29s killed by >> signal 6 SIGABRT >>  >>> QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64 >> MALLOC_PERTURB_=96 >> QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon >> G_TEST_DBUS_DAEMON=/home/devel/git/qemu/tests/dbus-vmstate-daemon.sh >> /home/devel/git/qemu/build/tests/qtest/netdev-socket --tap -k >> ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀ ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― >> stderr: >> ** >> ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: >> assertion failed (resp == expect): ("st0: >> index=0,type=stream,connection error\r\n" == "st0: >> index=0,type=stream,tcp:::1:40389\r\n") >> >> (test program exited with status code -6) > > I'm not able to reproduce the problem. > > Is this 100% reproducible? > Is IPv6 enabled on your test machine? If IPv6 is not available, this test should be skipped, not failing. From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:22:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:22:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436342.690381 (Exim 4.92) (envelope-from ) id 1oqYIR-0000l8-MV; Thu, 03 Nov 2022 11:22:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436342.690381; Thu, 03 Nov 2022 11:22:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYIR-0000l1-JO; Thu, 03 Nov 2022 11:22:07 +0000 Received: by outflank-mailman (input) for mailman id 436342; Thu, 03 Nov 2022 11:22:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYIQ-0000kv-9N for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:22:06 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be1c1b1d-5b69-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 12:22:04 +0100 (CET) Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-32-3CwrbiNXMgWlw8zr6uiTsw-1; Thu, 03 Nov 2022 07:22:00 -0400 Received: by mail-qk1-f197.google.com with SMTP id i17-20020a05620a249100b006fa2e10a2ecso1674308qkn.16 for ; Thu, 03 Nov 2022 04:22:00 -0700 (PDT) Received: from [192.168.100.30] ([82.142.8.70]) by smtp.gmail.com with ESMTPSA id c18-20020ac85192000000b0035bafecff78sm327917qtn.74.2022.11.03.04.21.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 04:21:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be1c1b1d-5b69-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667474523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ux3m9Pk64tq6UdkJ4I6mb58Aa13yWuk+ekJZSNfZ/b4=; b=a4pLayP1N/n0epfqPjZA9sxb0ztGBVIRDDNejoLxQzPSCKKxSrgRteUZ5XwQ4uPfh+n5KJ tprV7DKpkNHFPNoyAgx0e7E/mSILW4rIYFhlyJWdXLWA8Pmg+pqcYpJDEzRZKGedGXCSSS h5eyEm5SZs0TLQgMe+rLH4rw9i/xWNA= X-MC-Unique: 3CwrbiNXMgWlw8zr6uiTsw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ux3m9Pk64tq6UdkJ4I6mb58Aa13yWuk+ekJZSNfZ/b4=; b=BxB7ikl6f5GyDWyFJ1eJFhyB77nlozq4B7k9+ks5gcctOhModKkowgMRirRA6fg8WC zC/jHDf5McFbdB8EPyapmO/jxoylpQhJPQGoU5EY8Fkf7UUPYrWfypE0WMUeANcSKXhJ 2tEhFogDygSN3zg8LLZ9H1CbCA25D7Y1rRu1FvPcWFgU6N2RkFaz/NkigwX5GR/qdXxK dmHG75pgsOYsVpZOmw0lWAxBlQRWkkAZAPB9jfwtjI8t7pTncJ0xxWF10CFtXndGtlvw c4HHVw20WafFvu1Rh6vfRfAX9HCjZAxb49s8Rlm8CW2SoUMJlrp2nNbc0yd7tELl0Var lMTg== X-Gm-Message-State: ACrzQf21ab54SAZBOPSExS+dCma8DCAcEenDNqzTkhhs0ecWxILRbak2 0EjEAQzK8HP2APy+1ZZL09TA1x+hjjjoRo1WYMZs20uq8KkNIM/qptEdBPTZjQ3FAlLESOudiZw WUHMKqaOigsNozQudSxqdaykihIw= X-Received: by 2002:a05:620a:414d:b0:6ee:e31f:6253 with SMTP id k13-20020a05620a414d00b006eee31f6253mr21624286qko.350.1667474519858; Thu, 03 Nov 2022 04:21:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4gKGp5Esn4q08oqlevXnjWnv1AM/gAdKIVaBYMoJfq1kW9W2Rn8Rhkj6rgw0J/XOHyiE3bVw== X-Received: by 2002:a05:620a:414d:b0:6ee:e31f:6253 with SMTP id k13-20020a05620a414d00b006eee31f6253mr21624267qko.350.1667474519626; Thu, 03 Nov 2022 04:21:59 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 12:21:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v14 16/17] tests/qtest: netdev: test stream and dgram backends To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Jason Wang , qemu-devel@nongnu.org Cc: Thomas Huth , xen-devel@lists.xenproject.org, "Dr. David Alan Gilbert" , Anthony Perard , Stefan Weil , David Gibson , Stefano Stabellini , Paul Durrant , Eric Blake , "Michael S. Tsirkin" , Paolo Bonzini , Markus Armbruster , Samuel Thibault , Greg Kurz , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <20221021090922.170074-1-lvivier@redhat.com> <20221021090922.170074-17-lvivier@redhat.com> <700ef645-6cb6-66e6-00a9-3db187be0c43@redhat.com> <0fd82709-7612-25e0-66c0-d9494931d8c4@redhat.com> From: Laurent Vivier In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/3/22 12:07, Philippe Mathieu-Daudé wrote: > On 3/11/22 10:33, Laurent Vivier wrote: >> On 10/28/22 07:04, Jason Wang wrote: >>> >>> 在 2022/10/21 17:09, Laurent Vivier 写道: >>>> Signed-off-by: Laurent Vivier >>>> Acked-by: Michael S. Tsirkin >>>> --- >>> >>> >>> I got this: >>> >>> 63/63 ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: assertion failed >>> (resp == expect): ("st0: index=0,type=stream,connection error\r\n" == "st0: >>> index=0,type=stream,tcp:::1:40389\r\n") ERROR >>> 63/63 qemu:qtest+qtest-x86_64 / qtest-x86_64/netdev-socket                  ERROR 5.29s >>> killed by signal 6 SIGABRT >>>  >>> QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64 >>> MALLOC_PERTURB_=96 >>> QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon >>> G_TEST_DBUS_DAEMON=/home/devel/git/qemu/tests/dbus-vmstate-daemon.sh >>> /home/devel/git/qemu/build/tests/qtest/netdev-socket --tap -k >>> ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀ >>> ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― >>> stderr: >>> ** >>> ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: assertion failed (resp >>> == expect): ("st0: index=0,type=stream,connection error\r\n" == "st0: >>> index=0,type=stream,tcp:::1:40389\r\n") >>> >>> (test program exited with status code -6) >> >> I'm not able to reproduce the problem. >> >> Is this 100% reproducible? >> Is IPv6 enabled on your test machine? > > If IPv6 is not available, this test should be skipped, not failing. I agree. But I'm not sure it's the real cause of the problem (perhaps a firewall problem?). I think I should update my inet_get_free_port_socket() to get a free port from AF_INET6 and not only from AF_INET. Thanks, Laurent From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:37:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:37:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436348.690403 (Exim 4.92) (envelope-from ) id 1oqYWk-0003TB-A6; Thu, 03 Nov 2022 11:36:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436348.690403; Thu, 03 Nov 2022 11:36:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYWk-0003T1-7K; Thu, 03 Nov 2022 11:36:54 +0000 Received: by outflank-mailman (input) for mailman id 436348; Thu, 03 Nov 2022 11:36:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYWi-0003ST-Bj for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:36:52 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ced2a0dc-5b6b-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 12:36:51 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B5D0921D0A; Thu, 3 Nov 2022 11:36:50 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 72B7713480; Thu, 3 Nov 2022 11:36:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sJJtGtKnY2P4HgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 11:36:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ced2a0dc-5b6b-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667475410; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7CU5Zv+MxpH9Viqrq9cuAJbtGqlqKE19LW/YuoUb07c=; b=EoOrn3NQCcelDwLrz6uRb8Qdpe2LcmeDtFqRskvTLgiYp1OIbmEUexGEbMyEIOYJ42dKu/ 12zWG8reRqNsGvcRjBnqFgs8u2C5XKriMxPc4fnl1Yc+FvgUrhX7K0Dl2C6TbloaatAyqV ljzr7Loq/CVmv4IC7XuZaPSEWg0URFU= From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH 1/4] x86: add X86_FEATURE_XENPV to disabled-features.h Date: Thu, 3 Nov 2022 12:36:33 +0100 Message-Id: <20221103113636.25543-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221103113636.25543-1-jgross@suse.com> References: <20221103113636.25543-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add X86_FEATURE_XENPV to the features handled specially in disabled-features.h. Signed-off-by: Juergen Gross --- arch/x86/include/asm/disabled-features.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/disabled-features.h b/arch/x86/include/asm/disabled-features.h index 33d2cd04d254..c862552d7d6d 100644 --- a/arch/x86/include/asm/disabled-features.h +++ b/arch/x86/include/asm/disabled-features.h @@ -81,6 +81,12 @@ # define DISABLE_SGX (1 << (X86_FEATURE_SGX & 31)) #endif +#ifdef CONFIG_XEN_PV +# define DISABLE_XENPV 0 +#else +# define DISABLE_XENPV (1 << (X86_FEATURE_XENPV & 31)) +#endif + #ifdef CONFIG_INTEL_TDX_GUEST # define DISABLE_TDX_GUEST 0 #else @@ -98,7 +104,7 @@ #define DISABLED_MASK5 0 #define DISABLED_MASK6 0 #define DISABLED_MASK7 (DISABLE_PTI) -#define DISABLED_MASK8 (DISABLE_TDX_GUEST) +#define DISABLED_MASK8 (DISABLE_XENPV|DISABLE_TDX_GUEST) #define DISABLED_MASK9 (DISABLE_SGX) #define DISABLED_MASK10 0 #define DISABLED_MASK11 (DISABLE_RETPOLINE|DISABLE_RETHUNK|DISABLE_UNRET) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:37:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:37:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436349.690414 (Exim 4.92) (envelope-from ) id 1oqYWp-0003ma-IM; Thu, 03 Nov 2022 11:36:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436349.690414; Thu, 03 Nov 2022 11:36:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYWp-0003mQ-EJ; Thu, 03 Nov 2022 11:36:59 +0000 Received: by outflank-mailman (input) for mailman id 436349; Thu, 03 Nov 2022 11:36:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYWn-0003Ct-Cu for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:36:57 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d23708ba-5b6b-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 12:36:56 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 64E041F385; Thu, 3 Nov 2022 11:36:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2225213480; Thu, 3 Nov 2022 11:36:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5ETtBtinY2MEHwAAMHmgww (envelope-from ); Thu, 03 Nov 2022 11:36:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d23708ba-5b6b-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667475416; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mK6Yb+HDZYey+MdThM5vOztF2LsAJko2NCXxRRCzJLc=; b=kXqfwiKMdh9juEVxLq/XwrPXmX7SB2cxef3a31IZCdP9dQWBaNfSqFJxrMjZHT4Z9ML6rG pVIF8wHcHue8M1//i+/XCN0IhieNQ20fbVOJsCKv5zlarDyZcQQnAH0zAxIADInsArD5tT 8T43gbRaTSNsxxlmazfgdFihOv9Swfw= From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH 2/4] x86: remove unneeded 64-bit dependency in arch_enter_from_user_mode() Date: Thu, 3 Nov 2022 12:36:34 +0100 Message-Id: <20221103113636.25543-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221103113636.25543-1-jgross@suse.com> References: <20221103113636.25543-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The check for 64-bit mode when testing X86_FEATURE_XENPV isn't needed, as Xen PV guests are no longer supported in 32-bit mode. While at it switch from boot_cpu_has() to cpu_feature_enabled(). Signed-off-by: Juergen Gross --- arch/x86/include/asm/entry-common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/entry-common.h b/arch/x86/include/asm/entry-common.h index 674ed46d3ced..117903881fe4 100644 --- a/arch/x86/include/asm/entry-common.h +++ b/arch/x86/include/asm/entry-common.h @@ -24,8 +24,8 @@ static __always_inline void arch_enter_from_user_mode(struct pt_regs *regs) /* * For !SMAP hardware we patch out CLAC on entry. */ - if (boot_cpu_has(X86_FEATURE_SMAP) || - (IS_ENABLED(CONFIG_64BIT) && boot_cpu_has(X86_FEATURE_XENPV))) + if (cpu_feature_enabled(X86_FEATURE_SMAP) || + cpu_feature_enabled(X86_FEATURE_XENPV)) mask |= X86_EFLAGS_AC; WARN_ON_ONCE(flags & mask); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:37:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:37:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436347.690392 (Exim 4.92) (envelope-from ) id 1oqYWf-0003D6-U9; Thu, 03 Nov 2022 11:36:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436347.690392; Thu, 03 Nov 2022 11:36:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYWf-0003Cz-R2; Thu, 03 Nov 2022 11:36:49 +0000 Received: by outflank-mailman (input) for mailman id 436347; Thu, 03 Nov 2022 11:36:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYWe-0003Ct-Cd for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:36:48 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cc1e893f-5b6b-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 12:36:46 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0B6971F88C; Thu, 3 Nov 2022 11:36:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A806913480; Thu, 3 Nov 2022 11:36:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zT6jJ8ynY2PoHgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 11:36:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc1e893f-5b6b-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667475405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=R2jqME7F+qdUftTzWR72PDDjTzwv0qCQjs1xhw+ZdsU=; b=lMyg6ETc97azzoW47K210vpzsQEyM8fTV4c+5WVVzcj+0lcLDHxabMpcsuQMWDFQvtAZN4 0hHPII4l8tRuDyGpgjP5TscidSmhQjiCJvhdysgX8my9WIWoEW2vGXjt+IpIi1/24B0r9O Dk7aO6PBwgzOCy9oygMAKvYkeLf/lvk= From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Pu Wen , Andy Lutomirski , Peter Zijlstra Subject: [PATCH 0/4] Switch X86_FEATURE_XENPV to cpu_feature_enabled() use Date: Thu, 3 Nov 2022 12:36:32 +0100 Message-Id: <20221103113636.25543-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make especially kernels without CONFIG_XEN_PV more efficient by using cpu_feature_enabled(X86_FEATURE_XENPV) instead of boot_cpu_has() and friends. Juergen Gross (4): x86: add X86_FEATURE_XENPV to disabled-features.h x86: remove unneeded 64-bit dependency in arch_enter_from_user_mode() x86: drop 32-bit Xen PV guest code in update_task_stack() x86: switch to cpu_feature_enabled() for X86_FEATURE_XENPV arch/x86/include/asm/disabled-features.h | 8 +++++++- arch/x86/include/asm/entry-common.h | 4 ++-- arch/x86/include/asm/switch_to.h | 7 ++----- arch/x86/kernel/cpu/amd.c | 2 +- arch/x86/kernel/cpu/bugs.c | 2 +- arch/x86/kernel/cpu/hygon.c | 2 +- arch/x86/kernel/process_64.c | 4 ++-- arch/x86/kernel/topology.c | 2 +- arch/x86/mm/cpu_entry_area.c | 2 +- 9 files changed, 18 insertions(+), 15 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:37:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:37:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436350.690425 (Exim 4.92) (envelope-from ) id 1oqYWt-00046q-Qa; Thu, 03 Nov 2022 11:37:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436350.690425; Thu, 03 Nov 2022 11:37:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYWt-00046h-Mm; Thu, 03 Nov 2022 11:37:03 +0000 Received: by outflank-mailman (input) for mailman id 436350; Thu, 03 Nov 2022 11:37:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYWt-0003Ct-2Y for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:37:03 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d5a22055-5b6b-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 12:37:02 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 166CC21D0A; Thu, 3 Nov 2022 11:37:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C477313480; Thu, 3 Nov 2022 11:37:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3+lKLt2nY2MLHwAAMHmgww (envelope-from ); Thu, 03 Nov 2022 11:37:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5a22055-5b6b-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667475422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZIOvMf0VCiOOdx+pSynOR3iuEcnpBNHWVTTFgfhwJA0=; b=fO1ejgT0w/DmBPnCcekStE+j5Ba1MxipPnWjty4ItWonrZW8emL13QsK3CyLpMp7ti2ocl NPZwcfbd0UZyS8/Ymg+PB5tihoXT+b1ROeA1QuVQVER0mOInjZL2lvDz3TUAceDiQgIi/r 8OyYwe/f9Kxj1WP9EttpVfi85fRi2Jk= From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH 3/4] x86: drop 32-bit Xen PV guest code in update_task_stack() Date: Thu, 3 Nov 2022 12:36:35 +0100 Message-Id: <20221103113636.25543-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221103113636.25543-1-jgross@suse.com> References: <20221103113636.25543-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Testing for Xen PV guest mode in a 32-bit only code section can be dropped, as Xen PV guests are supported in 64-bit mode only. While at it switch from boot_cpu_has() to cpu_feature_enabled() in the 64-bit part of the code. Signed-off-by: Juergen Gross --- arch/x86/include/asm/switch_to.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/x86/include/asm/switch_to.h b/arch/x86/include/asm/switch_to.h index c08eb0fdd11f..5c91305d09d2 100644 --- a/arch/x86/include/asm/switch_to.h +++ b/arch/x86/include/asm/switch_to.h @@ -66,13 +66,10 @@ static inline void update_task_stack(struct task_struct *task) { /* sp0 always points to the entry trampoline stack, which is constant: */ #ifdef CONFIG_X86_32 - if (static_cpu_has(X86_FEATURE_XENPV)) - load_sp0(task->thread.sp0); - else - this_cpu_write(cpu_tss_rw.x86_tss.sp1, task->thread.sp0); + this_cpu_write(cpu_tss_rw.x86_tss.sp1, task->thread.sp0); #else /* Xen PV enters the kernel on the thread stack. */ - if (static_cpu_has(X86_FEATURE_XENPV)) + if (cpu_feature_enabled(X86_FEATURE_XENPV)) load_sp0(task_top_of_stack(task)); #endif } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:37:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:37:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436352.690436 (Exim 4.92) (envelope-from ) id 1oqYX0-0004cI-4z; Thu, 03 Nov 2022 11:37:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436352.690436; Thu, 03 Nov 2022 11:37:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYX0-0004c6-1l; Thu, 03 Nov 2022 11:37:10 +0000 Received: by outflank-mailman (input) for mailman id 436352; Thu, 03 Nov 2022 11:37:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYWy-0003Ct-RY for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:37:08 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d907e554-5b6b-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 12:37:08 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D0F0C1F88F; Thu, 3 Nov 2022 11:37:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7ABA613480; Thu, 3 Nov 2022 11:37:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3qiHHOOnY2McHwAAMHmgww (envelope-from ); Thu, 03 Nov 2022 11:37:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d907e554-5b6b-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667475427; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JbTtzDPkc2Z0HXkinvq56o0oqCsbj4jxT6+YNZSa1dg=; b=sydXpXUw5sQi1V2fXzxjPOxoy9NCGXsDl7dVXLB2uiATJ0WdQuSvpKrLSfJQeqn7lbc6HD eZ8w6V0z388egjWyFL7OwV/sXlJj+XSBK+ln7dSy6iaQz308OfrscYVGsz+ovc+m45MSLX 7UwWZlVGoaJbGnwNV071MwGELevOpy8= From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Pu Wen , Andy Lutomirski , Peter Zijlstra Subject: [PATCH 4/4] x86: switch to cpu_feature_enabled() for X86_FEATURE_XENPV Date: Thu, 3 Nov 2022 12:36:36 +0100 Message-Id: <20221103113636.25543-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221103113636.25543-1-jgross@suse.com> References: <20221103113636.25543-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert the remaining cases of static_cpu_has(X86_FEATURE_XENPV) and boot_cpu_has(X86_FEATURE_XENPV) to use cpu_feature_enabled(), allowing more efficient code in case the kernel is configured without CONFIG_XEN_PV. Signed-off-by: Juergen Gross --- arch/x86/kernel/cpu/amd.c | 2 +- arch/x86/kernel/cpu/bugs.c | 2 +- arch/x86/kernel/cpu/hygon.c | 2 +- arch/x86/kernel/process_64.c | 4 ++-- arch/x86/kernel/topology.c | 2 +- arch/x86/mm/cpu_entry_area.c | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index 860b60273df3..697fe881e967 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -985,7 +985,7 @@ static void init_amd(struct cpuinfo_x86 *c) set_cpu_cap(c, X86_FEATURE_3DNOWPREFETCH); /* AMD CPUs don't reset SS attributes on SYSRET, Xen does. */ - if (!cpu_has(c, X86_FEATURE_XENPV)) + if (!cpu_feature_enabled(X86_FEATURE_XENPV)) set_cpu_bug(c, X86_BUG_SYSRET_SS_ATTRS); /* diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c index da7c361f47e0..7f78e1527c5e 100644 --- a/arch/x86/kernel/cpu/bugs.c +++ b/arch/x86/kernel/cpu/bugs.c @@ -1302,7 +1302,7 @@ static enum spectre_v2_mitigation_cmd __init spectre_v2_parse_cmdline(void) return SPECTRE_V2_CMD_AUTO; } - if (cmd == SPECTRE_V2_CMD_IBRS && boot_cpu_has(X86_FEATURE_XENPV)) { + if (cmd == SPECTRE_V2_CMD_IBRS && cpu_feature_enabled(X86_FEATURE_XENPV)) { pr_err("%s selected but running as XenPV guest. Switching to AUTO select\n", mitigation_options[i].option); return SPECTRE_V2_CMD_AUTO; diff --git a/arch/x86/kernel/cpu/hygon.c b/arch/x86/kernel/cpu/hygon.c index 21fd425088fe..1c27645fd429 100644 --- a/arch/x86/kernel/cpu/hygon.c +++ b/arch/x86/kernel/cpu/hygon.c @@ -339,7 +339,7 @@ static void init_hygon(struct cpuinfo_x86 *c) set_cpu_cap(c, X86_FEATURE_ARAT); /* Hygon CPUs don't reset SS attributes on SYSRET, Xen does. */ - if (!cpu_has(c, X86_FEATURE_XENPV)) + if (!cpu_feature_enabled(X86_FEATURE_XENPV)) set_cpu_bug(c, X86_BUG_SYSRET_SS_ATTRS); check_null_seg_clears_base(c); diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index 6b3418bff326..e2f469175be8 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c @@ -165,7 +165,7 @@ static noinstr unsigned long __rdgsbase_inactive(void) lockdep_assert_irqs_disabled(); - if (!static_cpu_has(X86_FEATURE_XENPV)) { + if (!cpu_feature_enabled(X86_FEATURE_XENPV)) { native_swapgs(); gsbase = rdgsbase(); native_swapgs(); @@ -190,7 +190,7 @@ static noinstr void __wrgsbase_inactive(unsigned long gsbase) { lockdep_assert_irqs_disabled(); - if (!static_cpu_has(X86_FEATURE_XENPV)) { + if (!cpu_feature_enabled(X86_FEATURE_XENPV)) { native_swapgs(); wrgsbase(gsbase); native_swapgs(); diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c index 8617d1ed9d31..1b83377274b8 100644 --- a/arch/x86/kernel/topology.c +++ b/arch/x86/kernel/topology.c @@ -106,7 +106,7 @@ int arch_register_cpu(int num) * Xen PV guests don't support CPU0 hotplug at all. */ if (c->x86_vendor != X86_VENDOR_INTEL || - boot_cpu_has(X86_FEATURE_XENPV)) + cpu_feature_enabled(X86_FEATURE_XENPV)) cpu0_hotpluggable = 0; /* diff --git a/arch/x86/mm/cpu_entry_area.c b/arch/x86/mm/cpu_entry_area.c index 6c2f1b76a0b6..c83799753d44 100644 --- a/arch/x86/mm/cpu_entry_area.c +++ b/arch/x86/mm/cpu_entry_area.c @@ -147,7 +147,7 @@ static void __init setup_cpu_entry_area(unsigned int cpu) * On Xen PV, the GDT must be read-only because the hypervisor * requires it. */ - pgprot_t gdt_prot = boot_cpu_has(X86_FEATURE_XENPV) ? + pgprot_t gdt_prot = cpu_feature_enabled(X86_FEATURE_XENPV) ? PAGE_KERNEL_RO : PAGE_KERNEL; pgprot_t tss_prot = PAGE_KERNEL; #endif -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:42:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:42:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436369.690446 (Exim 4.92) (envelope-from ) id 1oqYc0-0006we-OK; Thu, 03 Nov 2022 11:42:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436369.690446; Thu, 03 Nov 2022 11:42:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYc0-0006wH-Le; Thu, 03 Nov 2022 11:42:20 +0000 Received: by outflank-mailman (input) for mailman id 436369; Thu, 03 Nov 2022 11:42:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYbz-0006w7-DL; Thu, 03 Nov 2022 11:42:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYbz-0001m2-9r; Thu, 03 Nov 2022 11:42:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYby-0002Bs-QX; Thu, 03 Nov 2022 11:42:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqYby-0007SJ-Q8; Thu, 03 Nov 2022 11:42:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oTuTIHq2oQRS8OPTTle62966y1cxxFSivo1TvnuNE+Y=; b=kPFt9cxyxLvqD/IvB6rt/94GkW Dwvpm8X0IVK0FswyzD9QFeMD+xRfA/aXU6SYiMPQIgPse8+oc5MFdYerRDmLhnWrP8A4lsxM3Rk3H T6hv7OFX0jW/v+qg7QfqnvqsIQsoYajnBcWfJo/x0gh7hwSBPxetAWID1tfxA/BuSNZk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174601: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2d9b3699136d20e354a94daefebbeefa9ceec7b6 X-Osstest-Versions-That: xen=0751a75e3996cf6efd3925a90b4776660d8df2bc From: osstest service owner Date: Thu, 03 Nov 2022 11:42:18 +0000 flight 174601 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174601/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass version targeted for testing: xen 2d9b3699136d20e354a94daefebbeefa9ceec7b6 baseline version: xen 0751a75e3996cf6efd3925a90b4776660d8df2bc Last test of basis 174585 2022-11-02 12:02:10 Z 0 days Testing same since 174601 2022-11-03 09:00:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Marek Marczykowski-Górecki jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 0751a75e39..2d9b369913 2d9b3699136d20e354a94daefebbeefa9ceec7b6 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:44:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:44:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436375.690458 (Exim 4.92) (envelope-from ) id 1oqYeU-0007Vi-5V; Thu, 03 Nov 2022 11:44:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436375.690458; Thu, 03 Nov 2022 11:44:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYeU-0007Vb-2q; Thu, 03 Nov 2022 11:44:54 +0000 Received: by outflank-mailman (input) for mailman id 436375; Thu, 03 Nov 2022 11:44:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYeS-0007VT-Bk for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:44:52 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ebb0ccd4-5b6c-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 12:44:50 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebb0ccd4-5b6c-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667475890; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cYi/ZuaPzd42DGLG3VnTKnMCeYaXtJay8PAOFO5Gtp4=; b=iJrxfk2b3C/mq6BSs+aUUOuXh3gcRn6X8BVBz5qR8xKsIkXNJchOLXnK VKwctVlppISA7V7LPj8RosCyYrc0m4BBDyzBuIE2iI6lxcO1a2yRDEaqE /DedQ0LWxC9GCI6WVlQM5w1whclxVif8KYKsypPrzdsLBEGevUgoDoKpD M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 84512473 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:USSv7a93CieZhi+Cds2aDrUDV36TJUtcMsCJ2f8bNWPcYEJGY0x3x zRNC2qEaa3ZYWSjKN93YYzj8U0EuJ7Uz9ZqSVdqqXg8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPKgQ5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkQq tAZLTxWLSrZuPip8Y+DDbFy1/oKeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGM0Yn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZUJwx/C+ j2dl4j/KgwBZJuAmTquy3KlvubIjTH0SLkOSaLto5aGh3XMnzdOWXX6T2CTo/O0l0q/UNJ3M FEP92wlqq1a3FOvZsnwWVu/unHslgUHR9NaHuk+6QeM4qnZ+QCUAi4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkA9L3IGZCICZRsI5Z/kuo5bpjLCSMxyVpG8iNLdECv1h TuNqUADa6471JBRkf/hpBae3mzq9sOhohMJChv/AD2J7wZ1P82fPbOy9mnm1bEYMtenZwzU1 JQboPS24OcLBJCLsSWCRuQRAb2kj8q43C3gbU1HRMd4qWn0k5K3VcUJuWwleh81WioRUWWxC HI/rz+983O60JGCSaZsK7y8BM0xpUQLPYS0D6uEBjaij3UYSeNmwM2MTRTNt4wOuBJ2+U3aB Xt8WZ/1ZUv28Yw9kFKLqx0h+bEq3Dsi4mjYWIr2yR+quZLHOiDKFe5ZaQDTNL5mhE9hnOky2 48BX/ZmNj0FCLGuCsUp2dN7wa82wYgTWsmt9p0/mh+rKQt6AmAxY8I9Mpt4E7GJa599z76Ql kxRr2cClzLXn2PcEwyWZxhLMPW/AP6TW1pnYnF3VbtpslB/CbuSAFA3LctvIed/r7I/kpaZj ZAtIq29PxiGcRyfkxx1UHU3hNUKmMiD7e5WAxeYXQ== IronPort-HdrOrdr: A9a23:R/cawaGJDpI5icBspLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5 uIGJIeNDSfNzdHsfo= X-IronPort-AV: E=Sophos;i="5.95,235,1661832000"; d="scan'208";a="84512473" Date: Thu, 3 Nov 2022 11:44:44 +0000 From: Anthony PERARD To: Julien Grall CC: , Henry Wang , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH for-4.17 3/4] xen: Add licence header to device_tree_defs.h Message-ID: References: <20221102112854.49020-1-anthony.perard@citrix.com> <20221102112854.49020-4-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Wed, Nov 02, 2022 at 01:16:04PM +0000, Julien Grall wrote: > Hi, > > On 02/11/2022 11:28, Anthony PERARD wrote: > > This header have been created by moving code from other part of the > > project and miss a licence header. The original source code was some > > version of GPL or LGPL but we intend to have the public header to be > > MIT so they can be included easily in other projects. > > > > Part of device_tree_defs.h were moved from libxl_arm.c which is > > LGPL-2.1-only. And part were moved from device_tree.h that is > > GPL-2.0-only. > > > > Part of the original code were added by Julien Grall @ Citrix with a > > Linaro "hat" in commits c3ba52a84dd8 and 405c167f0ec9 and > > 886f34045bf0. > > From this comment it is not entirely who you think the copyright owner is. That's because I'm not sure. > IIRC, part of the agreement was that all code written with my Linaro "hat" > would be copyrighted by Linaro rather than Citrix. > > So I think we would need Linaro's agreement for the relicensing. Sounds good to me. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:52:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:52:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436387.690475 (Exim 4.92) (envelope-from ) id 1oqYlq-0001A1-B5; Thu, 03 Nov 2022 11:52:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436387.690475; Thu, 03 Nov 2022 11:52:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYlq-00019N-5v; Thu, 03 Nov 2022 11:52:30 +0000 Received: by outflank-mailman (input) for mailman id 436387; Thu, 03 Nov 2022 11:52:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYlo-00016T-Vz for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:52:28 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fd29f0bb-5b6d-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 12:52:27 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd29f0bb-5b6d-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667476347; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=sdBaG8nza+w2eZvi73Kk9Zj+hZVkMYunpXxpVdr9hzQ=; b=UOmyRt+kcbj3C3UpixAozeGcy/5XSIT3+/A715IkSTCP/qx77gWa3DZd OepW6vW2PURtHFpCBD9QxXKQYhTpBS82Q5WgT84k94hG3NCQJwngkYI2n JV4oXeL6oLJ9wO0mPIoK4ARVTGD1pJjnKDL6hzOuO0cqGPzPyinJzPqrL 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 83173629 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:p5esJqiX0wp5SSvWRBL6gcgmX161rRAKZh0ujC45NGQN5FlHY01je htvDTqAOvqCZTfwfd5wOo639khU7MPUmIQySlRqpHg1EXwb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWv0N8klgZmP6oS5QeFzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQxN2sKPx6EjN6a76+XDctLgeMENo7kadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglH2dSFYr1SE47I6+WHJwCR60aT3McqTcduPLSlQthbD/ z2doT6oav0cHOC6ih/bqXOzuuXevDv0Rr81V5nn1tc/1TV/wURMUUZLBDNXu8KRqkO4QcMZF EUS9QInt610/0uuJvH/VRClpH+PvjYHRsFdVeY97WmlyLfQ4gufLngJSHhGctNOnNAybSwn0 BmOhdyBLSxitviZRGyQ8p+QrCiuIm4FIGkafygGQAAZpd75r+kblQnTR9xuFKq0iNzdGjzqx T2O6i8kiN0uYdUjjvvhuwqd2nT1+8aPHlVdChjrsnyNxxwiY9+rYIeUxXfGwbFiC4G+aUPGs y1R8ySB19wmAZaInS2LZewCGrC1+vqIWAHhbU5T84oJrGr0pSP6FWxEyHQnfRoybJ5YEdP8S BWL0T698qO/K5dDgUVfR4uqQ/onwqH7fTgOfqCFN4EeCnSdmeLuwc2PWaJy9zqw+KTPuftlU Xt+TSpLJS9DYZmLNBLsG48gPUYDn0jSP1/7S5Hh1AiA2rGDfnOTQrptGALQML9ltf/d+1iPr Yk32y62J/J3CbOWX8Uq2dRLcQBiwYYTWPgaVPC7hsbce1E7SQnN+tfawK87epwNokimvr6gw 51JYWcBkQKXuJEyAV/VApyVQO+wAM0XQLNSFXBEAGtELFB5Md7zsv9EKcdoFVTlncQ6pcNJo zA+U53oKpxypv7volzxsbGVQFReSSmW IronPort-HdrOrdr: A9a23:m4M2+aELXJa0bB86pLqE7seALOsnbusQ8zAXP0AYc3Nom6uj5q eTdZUgpGbJYVkqOU3I9ersBEDEewK/yXcX2/h0AV7BZmnbUQKTRekIh7cKgQeQfhEWntQts5 uIGJIRNDSfNzRHZL7BkWqFL+o= X-IronPort-AV: E=Sophos;i="5.95,235,1661832000"; d="scan'208";a="83173629" From: Anthony PERARD To: CC: Wei Liu , Stefano Stabellini , George Dunlap , Julien Grall , Jan Beulich , Henry Wang , Andrew Cooper , Anthony PERARD , Andrew Cooper Subject: [XEN PATCH for-4.17 v2 1/6] xen: Add licence information to public/errno.h Date: Thu, 3 Nov 2022 11:51:59 +0000 Message-ID: <20221103115204.49610-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221103115204.49610-1-anthony.perard@citrix.com> References: <20221103115204.49610-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Fixes: 81f559e97974 ("make error codes a formal part of the ABI") Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD --- xen/include/public/errno.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/include/public/errno.h b/xen/include/public/errno.h index 5c53af6af9..6bdc8c5079 100644 --- a/xen/include/public/errno.h +++ b/xen/include/public/errno.h @@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: MIT */ + /* * There are two expected ways of including this header. * -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:52:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:52:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436386.690469 (Exim 4.92) (envelope-from ) id 1oqYlq-00016o-1f; Thu, 03 Nov 2022 11:52:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436386.690469; Thu, 03 Nov 2022 11:52:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYlp-00016h-Ui; Thu, 03 Nov 2022 11:52:29 +0000 Received: by outflank-mailman (input) for mailman id 436386; Thu, 03 Nov 2022 11:52:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYlo-00016T-9K for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:52:28 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fb8e58b7-5b6d-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 12:52:26 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb8e58b7-5b6d-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667476346; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=bm7CEDt1IIOJfCFtzY4UsPBKwmFDLn8BiNg0GohoZf4=; b=Ux1H7ITp4iaH9yGOR5g+eGJYQpQ1qnvvoR7UHuMynJO6M4wlhLo7/l6i 3NvDZRZ5riYIyE5GiytCFRiWhLAziHxZKY9nUqMD4PZbp1mMQdewTKDHB UkVElPUt1tYNZjVjGNYO23vPYNJdmhVr8hCL/3P27ccrXzmfr+xsfHAKv 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 83173624 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:VA7aKKzluh1u3KyECpJ6t+c0wSrEfRIJ4+MujC+fZmUNrF6WrkUOy 2NMDWyBb6yNY2ahKt4jPtmy8E0BvcOEm4djSlNvpCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U4HUMja4mtC5AVnPasT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KU9i7 9g5dzkQVzSk38u34e60aPhtj9t2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tO6umnn4dSwesF+PrLA7y2PS0BZwwP7mN9+9ltmiFZ4MwR3G/ D6uE2LRKD0qE+6Dk2a/4Gu9vbHQsz7BXLAjG+jtnhJtqALKnTFCYPEMbnO5vP24h0iWS99Zb UsO9UIGr6I/6UiqRdnVRACjrTiPuRt0c/pdFfcrrj6EzKX86hycQGMDS1Zpc8c6vcU7QTgr0 F6hnN7zAzFr9rqPRhq1/beOrCiuPjAVIHVEemkPSQIf4PHspYgyilTESdMLOLa8k9ndCTz2h TeQo0AWmLE7ncMNkaKh8jjvvTWooZTYSx8v0S/eVGml8wBRaZasYsqj7l2zxfRPNoGCVXGao WMJ3cOZ6YgmHZyL0SCAXugJNLWo/Oqedi3Rh0Z1GJss/Cjr/GSsFahM6TR3P291McIJfzD4b UuVsgRUjLdZMWG2d6Zxb8S0At4z0Kn7Pd3/U7bfad8mSoBpdRWM9SVnb1O41WHxnEUinKczN I3desGpZV4TCL9uzT6/b+0czbMmyC04yW7JA5v8ynyaPaG2PSDPD+1faR3XM75/vPjsTBjpH 8h3GeeQ7zQAWfDHRg6P2I8ycV8oPHkyGsWjwyBITdKrLg1jEWAnLvbex7I9ZoBo95hoevf0E mKVAREBlgem7ZHTAUDTMy04NuuzNXpqhShjVRHAK2pEzJTKjWyHyK4EP6U6crA8nACI5a4lF qJVEyls7xkmd9gmx9j/RcOgxGCBXE7x7e5rA8ZCSGFmF6OMvySTprfZkvLHrUHi9Bafu8oku KGH3QjGW5cFTAkKJJ+INq3zlg/o5iVHxr0as670zj57IRuEzWSXA3ap0q9fzz8kdH0vOQd2J y7JWExF9IEhUqc+8cXThLDskmtaO7IWI6auJEGCtO7eCMUv1jD8qWO2eLrXIGu1uaKd0PnKW Ni5ONmmYKVbwg4R7dYje1uppIpnj+bSS3Zh5lwMNB32g56DU9uM/lHuMRFzi5Bw IronPort-HdrOrdr: A9a23:3f5ia6GQ+97UJPnHpLqE5MeALOsnbusQ8zAXP0AYc3Jom6uj5q STdZUgpHnJYVkqOE3I9ertBEDiewK4yXcW2/hzAV7KZmCP0wHEEGgL1/qE/9SKIUzDH4Bmup uIC5IOauHNMQ== X-IronPort-AV: E=Sophos;i="5.95,235,1661832000"; d="scan'208";a="83173624" From: Anthony PERARD To: CC: Wei Liu , Stefano Stabellini , "George Dunlap" , Julien Grall , Jan Beulich , Henry Wang , Andrew Cooper , Anthony PERARD , Bertrand Marquis , Petre Pircalabu , Alexandru Isaila , Tamas K Lengyel , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Juergen Gross , Paul Durrant , Christopher Clark Subject: [XEN PATCH for-4.17 v2 0/6] Fixing some licences issue in public headers Date: Thu, 3 Nov 2022 11:51:58 +0000 Message-ID: <20221103115204.49610-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.licences-fix-public-headers-v2 Hi, Andrew pointed out some licences issue: https://lore.kernel.org/xen-devel/b58f5340-d4fa-df9d-89de-6137005add77@citrix.com/T/#u tracked here: https://gitlab.com/xen-project/xen/-/issues/35 So I attempt to fix them with this series. For 4.17: This mostly change "documentation" so little risk for those patch, except "xen-foreign: Capture licences from the input headers" which changes "mkheader.py" which could generate broken headers. Anthony PERARD (6): xen: Add licence information to public/errno.h xen: Used SPDX identifier in some public headers tools/include/xen-foreign: Add SPDX identifier to generated headers xen: Add licence header to device_tree_defs.h Rework COPYING installed in /usr/include/xen/, due to several licences xen: Used SPDX identifier in public headers tools/include/Makefile | 1 - xen/include/public/arch-arm.h | 19 +------------- xen/include/public/arch-arm/hvm/save.h | 19 +------------- xen/include/public/arch-arm/smccc.h | 19 +------------- xen/include/public/arch-x86/cpufeatureset.h | 19 +------------- xen/include/public/arch-x86/cpuid.h | 19 +------------- xen/include/public/arch-x86/guest-acpi.h | 19 +------------- xen/include/public/arch-x86/hvm/save.h | 19 +------------- xen/include/public/arch-x86/hvm/start_info.h | 19 +------------- xen/include/public/arch-x86/pmu.h | 19 +------------- xen/include/public/arch-x86/xen-mca.h | 19 +------------- xen/include/public/arch-x86/xen-x86_32.h | 19 +------------- xen/include/public/arch-x86/xen-x86_64.h | 19 +------------- xen/include/public/arch-x86/xen.h | 19 +------------- xen/include/public/arch-x86_32.h | 19 +------------- xen/include/public/arch-x86_64.h | 19 +------------- xen/include/public/argo.h | 19 +------------- xen/include/public/callback.h | 19 +------------- xen/include/public/device_tree_defs.h | 6 +++++ xen/include/public/dom0_ops.h | 19 +------------- xen/include/public/domctl.h | 19 +------------- xen/include/public/elfnote.h | 19 +------------- xen/include/public/errno.h | 2 ++ xen/include/public/event_channel.h | 19 +------------- xen/include/public/features.h | 19 +------------- xen/include/public/grant_table.h | 19 +------------- xen/include/public/hvm/dm_op.h | 19 +------------- xen/include/public/hvm/e820.h | 19 +------------- xen/include/public/hvm/hvm_info_table.h | 19 +------------- xen/include/public/hvm/hvm_op.h | 19 +------------- xen/include/public/hvm/hvm_vcpu.h | 19 +------------- xen/include/public/hvm/hvm_xs_strings.h | 19 +------------- xen/include/public/hvm/ioreq.h | 19 +------------- xen/include/public/hvm/params.h | 19 +------------- xen/include/public/hvm/pvdrivers.h | 19 +------------- xen/include/public/hvm/save.h | 19 +------------- xen/include/public/hypfs.h | 19 +------------- xen/include/public/io/9pfs.h | 19 +------------- xen/include/public/io/blkif.h | 19 +------------- xen/include/public/io/cameraif.h | 19 +------------- xen/include/public/io/console.h | 19 +------------- xen/include/public/io/displif.h | 19 +------------- xen/include/public/io/fbif.h | 19 +------------- xen/include/public/io/fsif.h | 19 +------------- xen/include/public/io/kbdif.h | 19 +------------- xen/include/public/io/libxenvchan.h | 19 +------------- xen/include/public/io/netif.h | 19 +------------- xen/include/public/io/pciif.h | 19 +------------- xen/include/public/io/protocols.h | 19 +------------- xen/include/public/io/pvcalls.h | 19 +------------- xen/include/public/io/ring.h | 19 +------------- xen/include/public/io/sndif.h | 19 +------------- xen/include/public/io/tpmif.h | 19 +------------- xen/include/public/io/usbif.h | 19 +------------- xen/include/public/io/vscsiif.h | 19 +------------- xen/include/public/io/xenbus.h | 19 +------------- xen/include/public/io/xs_wire.h | 19 +------------- xen/include/public/kexec.h | 19 +------------- xen/include/public/memory.h | 19 +------------- xen/include/public/nmi.h | 19 +------------- xen/include/public/physdev.h | 19 +------------- xen/include/public/platform.h | 19 +------------- xen/include/public/pmu.h | 19 +------------- xen/include/public/sched.h | 19 +------------- xen/include/public/sysctl.h | 19 +------------- xen/include/public/tmem.h | 19 +------------- xen/include/public/trace.h | 19 +------------- xen/include/public/vcpu.h | 19 +------------- xen/include/public/version.h | 19 +------------- xen/include/public/vm_event.h | 19 +------------- xen/include/public/xen-compat.h | 19 +------------- xen/include/public/xen.h | 19 +------------- xen/include/public/xencomm.h | 19 +------------- xen/include/public/xenoprof.h | 19 +------------- xen/include/public/xsm/flask_op.h | 19 +------------- tools/include/xen-foreign/mkheader.py | 23 ++++++++++++++--- tools/include/xen/COPYING | 26 ++++++++++++++++++++ 77 files changed, 125 insertions(+), 1301 deletions(-) create mode 100644 tools/include/xen/COPYING -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:52:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:52:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436388.690491 (Exim 4.92) (envelope-from ) id 1oqYlx-0001fj-Ho; Thu, 03 Nov 2022 11:52:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436388.690491; Thu, 03 Nov 2022 11:52:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYlx-0001fc-F4; Thu, 03 Nov 2022 11:52:37 +0000 Received: by outflank-mailman (input) for mailman id 436388; Thu, 03 Nov 2022 11:52:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYlw-0001eL-NA for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:52:36 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0062c129-5b6e-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 12:52:34 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0062c129-5b6e-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667476354; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BNAyLUdt4UV1P3pSVrxGUK3VQpouEea1kpneLROz3mM=; b=P7N6vOG/M+9WaPf+VqTs2o733SFxpcdj5jedGGTm3FIeQYPY8v+1uxB5 gdGoh+y/T92SX6q5tTo8H7aXwSmPUB75Usm/EMUegm9WXX082zstf+vkO o5BfenL7zBqCOvKDdp3teEZuQAymXLwDsgLCJPSJmYFJqAvPXVWCznf/U g=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 83691348 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Ckr0r69rbsDPiKSsfzZZDrUDe36TJUtcMsCJ2f8bNWPcYEJGY0x3x mMeXWmDOffeNGv3fIx2Ooy/9kwGuJfRxtVkHVFr+yE8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPKgQ5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklrr t5bdRxddSqjxMCEh5iQVvtSmd4KeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGM0Yn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZUOwBfB/ T6Wl4j/KhcRaOSekzWnyWC9hcCSzTOkH4gLEpTto5aGh3XMnzdOWXX6T2CTgfS/kF/4ZNtZJ GQd4C9opq83nGSpRNTgWxyzoFafowURHdFXFoUS1gaJzabF5heDMUINRDVBdd8Oudc/QHoh0 Vrht9nkHyB1ubuZD3eU7K6JrCiaMDIQa2QFYEcsUg8t89Tl5oYpgXrnXttlVaK4kNDxMTXx2 CyR6jgzga0JiswG3Ln9+krI6xquu5zIQwgd9gjRGGW/4WtRf5W5boal7Vza6/doL4uDSFSF+ n8elKCjAPsmVM/X0nbXGaNUQe/vt63t3CDgbUBHOsIDtGmBq2WZXcNy0nZUD1t7DNkeUGq8C KPMgj956JhWNXqsSKZ4ZYOtFsgnpZTd+cTZuuP8NYQXPMUoHOOT1GQ3PBPLgTix+KQ5uftnU ap3Z/pAGprz5U5P6DOtD9kQ3rYwrszV7TOCHMurp/hLPFf3WZJ0dVvnGAHTBgzaxPneyOkwz zq4H5LToyizqMWkPkHqHXc7dDjm10QTC5HssNBwfeWeOAdgE2xJI6aPn+x9ItA8xPkPyLigE pSBtqhwkQSXuJE6AV/SNiALhE3HAP6TUk7XzQRzZA31ihDPkK6k7bsFdotfQFXU3LUL8BKAd NFcIp3oPxi6Ym6Yk9jrRcWi8dcKmdXCrV7mAhdJlxBlL8Y8GVSSpIO7FuYtnQFXZheKWQIFi +XI/mvmrVArHmyO0O6+hCqT8m6M IronPort-HdrOrdr: A9a23:Bn/aMK+3uQ9v9Tnc+oVuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P re+sjztCWE8Ar5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM 9bAtFD4bbLbGSS4/yU3ODBKadD/OW6 X-IronPort-AV: E=Sophos;i="5.95,235,1661832000"; d="scan'208";a="83691348" From: Anthony PERARD To: CC: Wei Liu , Stefano Stabellini , "George Dunlap" , Julien Grall , Jan Beulich , Henry Wang , Andrew Cooper , Anthony PERARD , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH for-4.17 v2 2/6] xen: Used SPDX identifier in some public headers Date: Thu, 3 Nov 2022 11:52:00 +0000 Message-ID: <20221103115204.49610-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221103115204.49610-1-anthony.perard@citrix.com> References: <20221103115204.49610-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The script "tools/include/xen-foreign/mkheader.py" is going to do a sanity check on the licences of those headers. To ease this, we will replace the verbatim copy of the MIT licence by its SPDX identifier equivalent. The text of the licence has been check to be the same as the one at https://spdx.org/licenses/MIT.html, except we don't have "(including the next paragraph)". The text is also the same as the one in "xen/include/public/COPYING". Signed-off-by: Anthony PERARD --- Notes: v2: - new patch xen/include/public/arch-arm.h | 19 +------------------ xen/include/public/arch-x86/xen-x86_32.h | 19 +------------------ xen/include/public/arch-x86/xen-x86_64.h | 19 +------------------ xen/include/public/arch-x86/xen.h | 19 +------------------ xen/include/public/xen.h | 19 +------------------ 5 files changed, 5 insertions(+), 90 deletions(-) diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index c8b6058d3a..1528ced509 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * arch-arm.h * * Guest OS interface to ARM Xen. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright 2011 (C) Citrix Systems */ diff --git a/xen/include/public/arch-x86/xen-x86_32.h b/xen/include/public/arch-x86/xen-x86_32.h index 19d7388633..139438e835 100644 --- a/xen/include/public/arch-x86/xen-x86_32.h +++ b/xen/include/public/arch-x86/xen-x86_32.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * xen-x86_32.h * * Guest OS interface to x86 32-bit Xen. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2004-2007, K A Fraser */ diff --git a/xen/include/public/arch-x86/xen-x86_64.h b/xen/include/public/arch-x86/xen-x86_64.h index 40aed14366..5d9035ed22 100644 --- a/xen/include/public/arch-x86/xen-x86_64.h +++ b/xen/include/public/arch-x86/xen-x86_64.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * xen-x86_64.h * * Guest OS interface to x86 64-bit Xen. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2004-2006, K A Fraser */ diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h index 546dd4496a..93b9d600b0 100644 --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * arch-x86/xen.h * * Guest OS interface to x86 Xen. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2004-2006, K A Fraser */ diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h index e373592c33..920567e006 100644 --- a/xen/include/public/xen.h +++ b/xen/include/public/xen.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * xen.h * * Guest OS interface to Xen. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2004, K A Fraser */ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:52:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:52:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436389.690502 (Exim 4.92) (envelope-from ) id 1oqYlz-0001xb-RU; Thu, 03 Nov 2022 11:52:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436389.690502; Thu, 03 Nov 2022 11:52:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYlz-0001xU-OA; Thu, 03 Nov 2022 11:52:39 +0000 Received: by outflank-mailman (input) for mailman id 436389; Thu, 03 Nov 2022 11:52:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYly-0001eL-F2 for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:52:38 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 02192e2f-5b6e-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 12:52:37 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02192e2f-5b6e-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667476357; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BH7twRAUiMUydBZO/gMO5ZlXmj/1kHRKCl6OFwwuGo4=; b=GM4DdemX+/3OmS9drU8MHzBwrDUfsKtcC2FfJyIRksfAJhA2LUXRF+m8 px9Q+MClUjT5nPL6nSE6Gx0cMYRNvbR44dUYhSyQu1CNIPYqemtN4idbs g22OD+rpS1uaaxLx0PzqrrQuJoeClZLBgQ8ZQq3D44gbqscQlhwxGJDsC g=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 84512859 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:VOhq263bOAfYPgR0JfbD5R5xkn2cJEfYwER7XKvMYLTBsI5bpzQGy WZNX2rTOPqONDH0L49+Otiy90kOscDTzIQ2SQE/pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wVmPqgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfXHFkq /g0AT83QhmFh+Pt66K7dMM1r5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKkSbC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TaGZgMxBbF9 woq+UyjBRURC8aW1gaqrHmMns/KnSOqCII7QejQGvlC3wTImz175ActfVmmpfi0jGauVtQZL FYbkgIsp6Uv8E2gTvHmQga15nWDu3Y0e9dWCfx81wiLxYLd+QPfDW8BJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaETcRBX8PY2kDVwRty8L4vIg5gxbLT9BiOK24lNv4HXf32 T/ikcQlr+xN14hRjfz9pA2ZxWL3znTUcuIrzljHdDyhwip2XqKsYYypsnPL7chqda/MGzFto 0M4s8SZ6ekPC7SEmyqMXPgBEdmV2hqVDNHPqQUxRsd8rlxB71bmJNkNu28meC+FJ+5eIVfUj FnvVRS9DXO5FF+jdudJbo24EKzGJoCwRI2+Bpg4gjejC6WdlTNrHgk0OCZ8PEi3yiDAdJ3T3 r/CKK6R4Y4yU/gP8dZPb751PUUX7i4/33jPYpvw0g6q17GTDFbMF+labALSN7tktv3byOkwz zq4H5LUoyizrcWkOnWHmWLtBQ1iwYcH6WDe9JUMK7/rzvtOE2A9Ef7BqY7NiKQ895m5Ytzgp yjlMnK0PXKl2hUr3y3WNS04AF4uNL4jxU8G0dsEZwbwhyZ7Otjzs8/ytfIfJNEayQCq9tYsJ 9FtRilKKq0npujvk9jFUaTAkQ== IronPort-HdrOrdr: A9a23:Dnlafa0BB8cLsyPYVg+hmQqjBIokLtp133Aq2lEZdPRUGvb3qy nIpoV86faUskdoZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ uIG5IOceEYZmIasS+V2maF+q4bsbu6zJw= X-IronPort-AV: E=Sophos;i="5.95,235,1661832000"; d="scan'208";a="84512859" From: Anthony PERARD To: CC: Wei Liu , Stefano Stabellini , "George Dunlap" , Julien Grall , Jan Beulich , Henry Wang , Andrew Cooper , Anthony PERARD , Andrew Cooper Subject: [XEN PATCH for-4.17 v2 3/6] tools/include/xen-foreign: Add SPDX identifier to generated headers Date: Thu, 3 Nov 2022 11:52:01 +0000 Message-ID: <20221103115204.49610-4-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221103115204.49610-1-anthony.perard@citrix.com> References: <20221103115204.49610-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The headers install in "/usr/include/xen/foreign/" are missing a licence header. This patch adds a SPDX identifier to clarify that the MIT licence is used. The script now check that the licence of the input file is also MIT, by checking for the presence of the SPDX identifier. Also add information about which files are used to generate the headers. Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD --- Notes: v2: - Add a SPDX identifier instead of trying to capture the original licence text. - Check the SPDX identifier of the input headers. - Add information about which headers are used as input. tools/include/xen-foreign/mkheader.py | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/tools/include/xen-foreign/mkheader.py b/tools/include/xen-foreign/mkheader.py index fb268f0dce..ec8a321395 100644 --- a/tools/include/xen-foreign/mkheader.py +++ b/tools/include/xen-foreign/mkheader.py @@ -1,5 +1,6 @@ #!/usr/bin/python +from __future__ import print_function import sys, re; from structs import unions, structs, defines; @@ -114,23 +115,37 @@ input = ""; output = ""; fileid = re.sub("[-.]", "_", "__FOREIGN_%s__" % outfile.upper()); -# read input header files for name in infiles: f = open(name, "r"); + # Check the licence of the input file, only SPDX identifier is accepted by + # this script. + line = f.readline() + if not line == "/* SPDX-License-Identifier: MIT */\n": + print("%s: Error: %s is missing SPDX identifier" % (sys.argv[0], name), file=sys.stderr) + exit(1) input += f.read(); f.close(); +# replace path in "infiles" by path in '/usr/include' to avoid exposing the +# build directory path in the generated headers. +headers_name_list = "" +public_headers_location = 'xen/include/public/' +for name in infiles: + i = name.rindex(public_headers_location) + i += len(public_headers_location) + headers_name_list += " xen/%s" % (name[i:]) + # add header -output += """ +output += """/* SPDX-License-Identifier: MIT */ /* * public xen defines and struct for %s - * generated by %s -- DO NOT EDIT + * generated from%s by %s -- DO NOT EDIT */ #ifndef %s #define %s 1 -""" % (arch, sys.argv[0], fileid, fileid) +""" % (arch, headers_name_list, sys.argv[0], fileid, fileid) if arch in header: output += header[arch]; -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:52:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:52:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436391.690513 (Exim 4.92) (envelope-from ) id 1oqYm6-0002TJ-8I; Thu, 03 Nov 2022 11:52:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436391.690513; Thu, 03 Nov 2022 11:52:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYm6-0002TA-5Q; Thu, 03 Nov 2022 11:52:46 +0000 Received: by outflank-mailman (input) for mailman id 436391; Thu, 03 Nov 2022 11:52:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYm4-0001eL-Of for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:52:44 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0638a22b-5b6e-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 12:52:43 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0638a22b-5b6e-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667476363; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qP6CbInANoKRmwMgk+a5Z5s50q5J3NmEB9ca9VSqoig=; b=GhcOvmGWf8KbDz1mtR5X6+MphckbK7vR5APn6Y5k4JGKPd6vCZXr+3wi 0bsSezvUSsoWBXADLajiECe1g8D3JkOBjVQlVNfNQ90+nMXV7K4BK1X2m Zcx8//WQtCtWSqWtYXDWwC8q8KJ7SfDoOMn2nyHWqRFoEL1I5I2iHyZWz 8=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 84512867 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Jw8s9qytaORAv0jq+Xx6t+f6xirEfRIJ4+MujC+fZmUNrF6WrkUGm 2RODGzVbv6PZWT3eooiPoi+oE8GucLUyt8yTQZqriAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U4HUMja4mtC5AVnPasT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KW5h2 eQFBh1SUgKs1t2x6pbjdvZMv8t2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tO6umnn4dSwesF+PrLA7y2PS0BZwwP7mN9+9ltmiFZkIxxzI+ D2uE2LRXTQHE9+jmD259lWXo8Dhs3OiY4cePejtnhJtqALKnTFCYPEMbnObrP+jmwiBUtRQA 0UO/2wlqq1a3E6hQ8T5Xha4iGWZpRNaUN1Ve8U49QWMx6z88wufQG8eQVZpd9gOpMIwAzsw2 Tehj97vQDBirrCRYXac7auP6yO/PzAPKm0PbjNCShEKi/H4u506hB/LStdlEYa2g8fzFDW2x CqFxBXSnJ1K05RNjf/iuwma3XT8/fAlUzLZ+C3YcU698y1UO7K3SN2X7nL/tcpfDL+WGwzpU Gc/p+CS6+UHDJeonSOLQfkQELzB28tpIAEwknY0QcB/qm3FF2qLONkJvWogfBsB3tMsI2eBX aPFhe9GCHa/1lOOZLQ/XY++At9CIUPIRYW8DaC8gjajj/FMmO67EMNGPxP4M4PFyhJEfUQD1 XCzKJ/EMJriIf47pAdavs9EuVPR+ggwxHnIWbfwxAm93LyVaRa9EOlbbwfXMrlisfna/205F uqz0OPTlX1ivBDWOHGLoeb/03hXRZTEOXwGg5MOLbPSSuaXMGogF+XQ0dscl39NxsxoehPz1 ijkAidlJK/X3yKvxfOiNi8+M9sCnP9X8RoGAMDbFQz4gyR9Od3xsPh3mlleVeBPydGPBMVcF 5EtE/hsyNwWItgb01zxtaXAkbE= IronPort-HdrOrdr: A9a23:ucZH4a3CMXMd0Sk3HuyISQqjBLQkLtp133Aq2lEZdPRUGvb2qy nIpoV96faUskdpZJhOo7G90cW7LE80sKQFg7X5Xo3SODUO2lHJEGgK1+KLqFfd8m/Fh4tgPM 9bAs5D4bbLY2SS4/yX3ODBKadC/OW6 X-IronPort-AV: E=Sophos;i="5.95,235,1661832000"; d="scan'208";a="84512867" From: Anthony PERARD To: CC: Wei Liu , Stefano Stabellini , George Dunlap , Julien Grall , Jan Beulich , Henry Wang , Andrew Cooper , Anthony PERARD , Andrew Cooper Subject: [XEN PATCH for-4.17 v2 4/6] xen: Add licence header to device_tree_defs.h Date: Thu, 3 Nov 2022 11:52:02 +0000 Message-ID: <20221103115204.49610-5-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221103115204.49610-1-anthony.perard@citrix.com> References: <20221103115204.49610-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This header have been created by moving code from other part of the project and miss a licence header. The original source code was some version of GPL or LGPL but we intend to have the public header to be MIT so they can be included easily in other projects. Part of device_tree_defs.h were moved from libxl_arm.c which is LGPL-2.1-only. And part were moved from device_tree.h that is GPL-2.0-only. Part of the original code were added by Julien Grall @ Linaro in commits c3ba52a84dd8 and 405c167f0ec9 and 886f34045bf0. The other part were added by Ian Campbell @ Citrix, with commit 0c64527e7fc9. Resolves: xen-project/xen#35 Fixes: 1c898a9fec7e ("xen/arm: move a few DT related defines to public/device_tree_defs.h") Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper --- Notes: Probably needs an ack from Linaro: https://lore.kernel.org/r/fad0265d-a736-5135-b5ea-3735a8bc72da@xen.org/ v2: - ack from Citrix - rewrite message to say "Julian @ Linaro" instead of "Julian with a Linaro hat". xen/include/public/device_tree_defs.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/device_tree_defs.h index 228daafe81..9e80d0499d 100644 --- a/xen/include/public/device_tree_defs.h +++ b/xen/include/public/device_tree_defs.h @@ -1,3 +1,9 @@ +/* SPDX-License-Identifier: MIT */ +/* + * Copyright (c) 2013 Linaro Limited + * Copyright (c) 2015 Citrix Systems, Inc + */ + #ifndef __XEN_DEVICE_TREE_DEFS_H__ #define __XEN_DEVICE_TREE_DEFS_H__ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:52:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:52:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436396.690524 (Exim 4.92) (envelope-from ) id 1oqYmE-0003Ax-Kt; Thu, 03 Nov 2022 11:52:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436396.690524; Thu, 03 Nov 2022 11:52:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYmE-0003Ai-I1; Thu, 03 Nov 2022 11:52:54 +0000 Received: by outflank-mailman (input) for mailman id 436396; Thu, 03 Nov 2022 11:52:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYmC-00016T-W4 for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:52:53 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0a6def8a-5b6e-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 12:52:51 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a6def8a-5b6e-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667476371; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mk0ItgibVfLUgrlbVRLDfctz2qQER5glO6g98oh7u4s=; b=Ioqa121hyfLBf5NJeXGcmgih5PNRUYiZ0BAqXrnsB75o5A7V2ZWp2zc7 /dkS6RaVXwGQmnJmE4tWNv08cD3RUOHQLSnTc14angcXxf5po5BUz33nj OeuHeOvKhbB4n62mLRtJymcEozcZGaqeopIE6+AHkAx3RmhNTNJfWWY0n k=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 83691397 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:jTkLwaLd2pVy8aJ4FE+RHJUlxSXFcZb7ZxGr2PjKsXjdYENS1GFUz GAZDT3Xa/uCZmWmct9xaN++90tX7cLcm9IxGlRlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5wRlPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5LLiJc2 MREGQpWTS+IgMmZwLWeeNJj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUozRG5QMxRfHz o7A13jpBksXP/Kk8yPb61Wrt97gw3P9So1HQdVU8dY12QbOlwT/EiY+dVa9u+j/tUe4VPpWM UlS8S0rxYAw/kG2Stj2XzWjvWWJ+BUbXrJ4EfA+6QyL4rrZ5UCeHGdsZiFFQMwrsokxXzNC/ k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz Fi3QDMW3utJy5RRjuPioA6B02nESoX1ohAd2iqUTE+dsjJDP62abIuDxljcyMR7I9PMJrWeh 0Qsl8+b5eEIKJiCki2RXekAdI2UC+a53C702gA2QcR4n9i50zv6JN0LvmkiTKt8GpxcEQIFd nM/ru+4CHV7GHKxJZF6bIuqYyjB5fixTI+1Phw4gzcnX3SQSONl1HszDaJz9zq3+KTJrU3YE c7CGftA9V5AVcxaIMOeHo/xK4MDyCEk3n/0Tpvm1Rmh2rf2TCfLF+hZaQfXNb1jsvzsTODpH zF3bpXi9vmieLemPnm/HXA7cDjm0kTX9bip8pcKJ4Zv0yJtGX07Cu+5/F/SU9UNokihrc+Rp ynVZ6Ot4ACg7ZExAVnVNysLhXKGdcoXkE/XygR2bQ70hSB4P9rwhErdHrNuFYQaGCVY5aYcZ 5E4lw+oW5yjlhyvF+whUKTA IronPort-HdrOrdr: A9a23:rjMKGK0D2ieGtnFcOr10qgqjBL4kLtp133Aq2lEZdPRUGvb3qy nIpoV+6faUskd2ZJhOo7C90cW7LU80lqQFhLX5X43SPzUO0VHAROoJgLcKqweQfBEWndQ96U 4PScdD4aXLfDpHsfo= X-IronPort-AV: E=Sophos;i="5.95,235,1661832000"; d="scan'208";a="83691397" From: Anthony PERARD To: CC: Wei Liu , Stefano Stabellini , George Dunlap , Julien Grall , Jan Beulich , Henry Wang , Andrew Cooper , Anthony PERARD , Andrew Cooper Subject: [XEN PATCH for-4.17 v2 5/6] Rework COPYING installed in /usr/include/xen/, due to several licences Date: Thu, 3 Nov 2022 11:52:03 +0000 Message-ID: <20221103115204.49610-6-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221103115204.49610-1-anthony.perard@citrix.com> References: <20221103115204.49610-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The notice in the COPYING file in "xen/include/public/COPYING" doesn't really apply to the files that ultimately are been install at "/usr/include/xen". The issue are headers in the "sys/" subdirectory that comes from other projects such as Linux or FreeBSD. The main issue is that there are two headers that have a different licence than the MIT licence: - xen-sys/Linux/gntalloc.h (installed as "sys/gntalloc.h") is public domain. - xen-sys/FreeBSD/gntdev.h (installed as "sys/gntdev.h") is BSD-2. To clarify this, we'll install a COPYING file with a different notice. Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD --- Notes: v2: - change notice to be more generic and allow more headers and more licence exception without having to rewrite the notice. tools/include/Makefile | 1 - tools/include/xen/COPYING | 26 ++++++++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 tools/include/xen/COPYING diff --git a/tools/include/Makefile b/tools/include/Makefile index 81c3d09039..f838171e8c 100644 --- a/tools/include/Makefile +++ b/tools/include/Makefile @@ -24,7 +24,6 @@ xen-foreign: xen-dir: mkdir -p xen/libelf acpi find xen/ acpi/ -type l -exec rm '{}' + - ln -s $(XEN_ROOT)/xen/include/public/COPYING xen/ ln -s $(XEN_ROOT)/xen/include/public/*.h xen/ ln -s $(XEN_ROOT)/xen/include/public/*/ xen/ ln -s ../xen-sys/$(XEN_OS) xen/sys diff --git a/tools/include/xen/COPYING b/tools/include/xen/COPYING new file mode 100644 index 0000000000..fe3f9b7557 --- /dev/null +++ b/tools/include/xen/COPYING @@ -0,0 +1,26 @@ +XEN NOTICE +========== + +This licence applies to all files within this subdirectory ("/usr/include/xen") +with the exception of "sys/" which may include headers under different +licences. + +===================================================================== + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to +deal in the Software without restriction, including without limitation the +rights to use, copy, modify, merge, publish, distribute, sublicense, and/or +sell copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in +all copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER +DEALINGS IN THE SOFTWARE. -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 03 11:53:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 11:53:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436402.690535 (Exim 4.92) (envelope-from ) id 1oqYmO-0003ws-V4; Thu, 03 Nov 2022 11:53:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436402.690535; Thu, 03 Nov 2022 11:53:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYmO-0003wj-Qp; Thu, 03 Nov 2022 11:53:04 +0000 Received: by outflank-mailman (input) for mailman id 436402; Thu, 03 Nov 2022 11:53:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqYmM-00016T-P2 for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 11:53:03 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e493361-5b6e-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 12:52:57 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e493361-5b6e-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667476377; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9eKd17q2BrI5Ohyg7Oayzu2SzNf6KmJ5QzViLrh+cxQ=; b=ChHHoj7UAKIti4Fd6Q8xYapCfElF0ZoS0IsOZ2w1hcsgjtQA6inhrREz x8HUiKm2bgPtYFZ4ssKzTZLo9l3KpUhYS3yq4KPTmD+KcgjnNyBnXNhsi 7ASpThW5vdFVdOb780xhq+T9VlbUglKhAwlkgFuakyoMYmJMbQlYKFK49 s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 84104711 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:9ZsTNarhnhipZJSX5Xuj1NRqayteBmIbYhIvgKrLsJaIsI4StFCzt garIBmBP66ONDOgeNtzbYrn90wD7cPQxtBkSVZlqyE8RHgT9ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W5wUmAWP6gR5gaHzyJNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACwBayqp3LK3+4qyUO91t54RLdL1MLpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFHU/rSn8/x7pX7WzRetFKSo7tx+2XJxRZ9+LPsLMDUapqBQsA9ckOw9 j6fpzimW0hy2Nq38ziMyHmiov30uyKkYJkpFKW58MFsuQjGroAUIEJPDgbqyRWjsWa8RtZeJ ko86ico668o+ySDTNPwQhm5q36spQMHVpxbFOhSwCGAzLDFpTmQAGcsRyRELtchsaceXic23 1WEm9foAz1Hs7CPT3+ZsLCOoluaITAUN2QLYSYOUCMP4sXvrY8+iB7CVJBoF6vdptT0Ajjxx zmipikii7gdgMgH2r/99lfC6xqzorDZQwhz4R/YNkqn4Rl+f5WNfJGz5B7Q6vMoBJqQS1Cal GQHn8WY4/EDCdeGkynlaPUAGvSl6uiINBXYgEVzBN8x+jK14XmhcItMpjZkKy9BKs8ZfRf5b UmVvhlejLdZMWG2d6Zxb8S0At4z0Kn7Pd3/U7bfad8mSqZ2cAiL7SR/f3m61mrmkFUvuawnM JLdesGpZV4RCb5m1yaxX+cQy/k0gCs6zHnQbZ/+xhWjl7GZYRaopawtaQXUKLpjteXd/VuTo 40329a2Jwt3TOH7WAOMoY8oFVkQK2EKX6L3sNJbT7vWSuZ5I10JB/jUyLInXoVqmaVJi+vFl k2Atl9kJEnX3iOed1jTApx3QPa2BMsk8ypnVcA5FQzws0XPd7pD+0v2m3EfWbA8vNJuwvdvJ xXuU5XRW68fItgrFtl0UHUckGCAXE727e5tF3D/CNTaQ3KHb1WQkuIIhiO1qEEz4tOf7KPSW YGI2ALBWoYkTA9/FsvQY//H5wrv4ydBwb4rBBaSfIY7lKDQHG9CcnKZsxPKC5tUdUWrKsWyi m56/iv0VcGS+tRoobEldIiPrpuzEvsWI6apNzCz0FpCDgGDpzLL/GO1eLzXFdwrfD+rpf7Ki CQ8562UDcDra34Q49IgTe4wk/5hjzYtzpcDpjlZ8LzwRwzDIttdzrOuhKGjaoUlKmdlhDaL IronPort-HdrOrdr: A9a23:aU7ug6oZdPSKHZv2z6jo3bIaV5oteYIsimQD101hICG8cqSj+P xG+85rsiMc6QxhIU3I9urgBEDtex7hHNtOkOss1NSZLW3bUQmTTL2KhLGKq1aLJ8S9zJ856U 4JSdkZNDSaNzZHZKjBjDVQa+xQo+W6zA== X-IronPort-AV: E=Sophos;i="5.95,235,1661832000"; d="scan'208";a="84104711" From: Anthony PERARD To: CC: Wei Liu , Stefano Stabellini , "George Dunlap" , Julien Grall , Jan Beulich , Henry Wang , Andrew Cooper , Anthony PERARD , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Christopher Clark , Paul Durrant , Juergen Gross , Tamas K Lengyel , Alexandru Isaila , "Petre Pircalabu" Subject: [XEN PATCH for-4.17 v2 6/6] xen: Used SPDX identifier in public headers Date: Thu, 3 Nov 2022 11:52:04 +0000 Message-ID: <20221103115204.49610-7-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221103115204.49610-1-anthony.perard@citrix.com> References: <20221103115204.49610-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The text of the licence has been check to be the same as the one at https://spdx.org/licenses/MIT.html, except we don't have "(including the next paragraph)". Mecanical change done with a script. Signed-off-by: Anthony PERARD --- Notes: v2: - new patch This patch could be squashed into "xen: Used SPDX identifier in some public headers", if both are acceptable for the 4.17 release. python script ------------- import sys mit_licence = """ * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to * deal in the Software without restriction, including without limitation the * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or * sell copies of the Software, and to permit persons to whom the Software is * furnished to do so, subject to the following conditions: * * The above copyright notice and this permission notice shall be included in * all copies or substantial portions of the Software. * * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER * DEALINGS IN THE SOFTWARE. """ mit_spdx = "/* SPDX-License-Identifier: MIT */\n" print(f"reading {sys.argv[1]}") with open(sys.argv[1], 'r') as f: whole_file = f.read() try: licence_loc = whole_file.index(mit_licence) except ValueError: print(". mit licence not found") exit(1) whole_file = whole_file.replace(mit_licence + ' *\n', '') whole_file = whole_file.replace(' *\n' + mit_licence, '') with open('%s' % sys.argv[1], 'w') as f: f.write(mit_spdx) f.write(whole_file) xen/include/public/arch-arm/hvm/save.h | 19 +------------------ xen/include/public/arch-arm/smccc.h | 19 +------------------ xen/include/public/arch-x86/cpufeatureset.h | 19 +------------------ xen/include/public/arch-x86/cpuid.h | 19 +------------------ xen/include/public/arch-x86/guest-acpi.h | 19 +------------------ xen/include/public/arch-x86/hvm/save.h | 19 +------------------ xen/include/public/arch-x86/hvm/start_info.h | 19 +------------------ xen/include/public/arch-x86/pmu.h | 19 +------------------ xen/include/public/arch-x86/xen-mca.h | 19 +------------------ xen/include/public/arch-x86_32.h | 19 +------------------ xen/include/public/arch-x86_64.h | 19 +------------------ xen/include/public/argo.h | 19 +------------------ xen/include/public/callback.h | 19 +------------------ xen/include/public/dom0_ops.h | 19 +------------------ xen/include/public/domctl.h | 19 +------------------ xen/include/public/elfnote.h | 19 +------------------ xen/include/public/event_channel.h | 19 +------------------ xen/include/public/features.h | 19 +------------------ xen/include/public/grant_table.h | 19 +------------------ xen/include/public/hvm/dm_op.h | 19 +------------------ xen/include/public/hvm/e820.h | 19 +------------------ xen/include/public/hvm/hvm_info_table.h | 19 +------------------ xen/include/public/hvm/hvm_op.h | 19 +------------------ xen/include/public/hvm/hvm_vcpu.h | 19 +------------------ xen/include/public/hvm/hvm_xs_strings.h | 19 +------------------ xen/include/public/hvm/ioreq.h | 19 +------------------ xen/include/public/hvm/params.h | 19 +------------------ xen/include/public/hvm/pvdrivers.h | 19 +------------------ xen/include/public/hvm/save.h | 19 +------------------ xen/include/public/hypfs.h | 19 +------------------ xen/include/public/io/9pfs.h | 19 +------------------ xen/include/public/io/blkif.h | 19 +------------------ xen/include/public/io/cameraif.h | 19 +------------------ xen/include/public/io/console.h | 19 +------------------ xen/include/public/io/displif.h | 19 +------------------ xen/include/public/io/fbif.h | 19 +------------------ xen/include/public/io/fsif.h | 19 +------------------ xen/include/public/io/kbdif.h | 19 +------------------ xen/include/public/io/libxenvchan.h | 19 +------------------ xen/include/public/io/netif.h | 19 +------------------ xen/include/public/io/pciif.h | 19 +------------------ xen/include/public/io/protocols.h | 19 +------------------ xen/include/public/io/pvcalls.h | 19 +------------------ xen/include/public/io/ring.h | 19 +------------------ xen/include/public/io/sndif.h | 19 +------------------ xen/include/public/io/tpmif.h | 19 +------------------ xen/include/public/io/usbif.h | 19 +------------------ xen/include/public/io/vscsiif.h | 19 +------------------ xen/include/public/io/xenbus.h | 19 +------------------ xen/include/public/io/xs_wire.h | 19 +------------------ xen/include/public/kexec.h | 19 +------------------ xen/include/public/memory.h | 19 +------------------ xen/include/public/nmi.h | 19 +------------------ xen/include/public/physdev.h | 19 +------------------ xen/include/public/platform.h | 19 +------------------ xen/include/public/pmu.h | 19 +------------------ xen/include/public/sched.h | 19 +------------------ xen/include/public/sysctl.h | 19 +------------------ xen/include/public/tmem.h | 19 +------------------ xen/include/public/trace.h | 19 +------------------ xen/include/public/vcpu.h | 19 +------------------ xen/include/public/version.h | 19 +------------------ xen/include/public/vm_event.h | 19 +------------------ xen/include/public/xen-compat.h | 19 +------------------ xen/include/public/xencomm.h | 19 +------------------ xen/include/public/xenoprof.h | 19 +------------------ xen/include/public/xsm/flask_op.h | 19 +------------------ 67 files changed, 67 insertions(+), 1206 deletions(-) diff --git a/xen/include/public/arch-arm/hvm/save.h b/xen/include/public/arch-arm/hvm/save.h index 75b8e65bcb..fc1b28f59b 100644 --- a/xen/include/public/arch-arm/hvm/save.h +++ b/xen/include/public/arch-arm/hvm/save.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /* * Structure definitions for HVM state that is held by Xen and must * be saved along with the domain's memory and device-model state. * * Copyright (c) 2012 Citrix Systems Ltd. - * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. */ #ifndef __XEN_PUBLIC_HVM_SAVE_ARM_H__ diff --git a/xen/include/public/arch-arm/smccc.h b/xen/include/public/arch-arm/smccc.h index 17dc6d8829..802d800aad 100644 --- a/xen/include/public/arch-arm/smccc.h +++ b/xen/include/public/arch-arm/smccc.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /* * smccc.h * * SMC/HVC interface in accordance with SMC Calling Convention. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright 2017 (C) EPAM Systems */ diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h index 42f48a8ae2..80f44df73f 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /* * arch-x86/cpufeatureset.h * * CPU featureset definitions * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2015, 2016 Citrix Systems, Inc. */ diff --git a/xen/include/public/arch-x86/cpuid.h b/xen/include/public/arch-x86/cpuid.h index c49eefeaf8..7ecd16ae05 100644 --- a/xen/include/public/arch-x86/cpuid.h +++ b/xen/include/public/arch-x86/cpuid.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * arch-x86/cpuid.h * * CPUID interface to Xen. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2007 Citrix Systems, Inc. * * Authors: diff --git a/xen/include/public/arch-x86/guest-acpi.h b/xen/include/public/arch-x86/guest-acpi.h index 3d79a31fd8..de40259b6a 100644 --- a/xen/include/public/arch-x86/guest-acpi.h +++ b/xen/include/public/arch-x86/guest-acpi.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * arch-x86/guest-acpi.h * * Guest ACPI interface to x86 Xen. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * */ #ifndef __XEN_PUBLIC_ARCH_X86_GUEST_ACPI_H__ diff --git a/xen/include/public/arch-x86/hvm/save.h b/xen/include/public/arch-x86/hvm/save.h index 773a380bc2..7ecacadde1 100644 --- a/xen/include/public/arch-x86/hvm/save.h +++ b/xen/include/public/arch-x86/hvm/save.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /* * Structure definitions for HVM state that is held by Xen and must * be saved along with the domain's memory and device-model state. * * Copyright (c) 2007 XenSource Ltd. - * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. */ #ifndef __XEN_PUBLIC_HVM_SAVE_X86_H__ diff --git a/xen/include/public/arch-x86/hvm/start_info.h b/xen/include/public/arch-x86/hvm/start_info.h index 50af9ea2ff..e33557c0b4 100644 --- a/xen/include/public/arch-x86/hvm/start_info.h +++ b/xen/include/public/arch-x86/hvm/start_info.h @@ -1,22 +1,5 @@ +/* SPDX-License-Identifier: MIT */ /* - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2016, Citrix Systems, Inc. */ diff --git a/xen/include/public/arch-x86/pmu.h b/xen/include/public/arch-x86/pmu.h index 464c65dac1..d0a99268af 100644 --- a/xen/include/public/arch-x86/pmu.h +++ b/xen/include/public/arch-x86/pmu.h @@ -1,22 +1,5 @@ +/* SPDX-License-Identifier: MIT */ /* - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved. */ diff --git a/xen/include/public/arch-x86/xen-mca.h b/xen/include/public/arch-x86/xen-mca.h index d930c344c0..b897536ec5 100644 --- a/xen/include/public/arch-x86/xen-mca.h +++ b/xen/include/public/arch-x86/xen-mca.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * arch-x86/mca.h * @@ -5,24 +6,6 @@ * Author: Christoph Egger * * Guest OS machine check interface to x86 Xen. - * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. */ /* Full MCA functionality has the following Usecases from the guest side: diff --git a/xen/include/public/arch-x86_32.h b/xen/include/public/arch-x86_32.h index dfabdcc345..c0cf8c7bcd 100644 --- a/xen/include/public/arch-x86_32.h +++ b/xen/include/public/arch-x86_32.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * arch-x86_32.h * * Guest OS interface to x86 32-bit Xen. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2004-2006, K A Fraser */ diff --git a/xen/include/public/arch-x86_64.h b/xen/include/public/arch-x86_64.h index c40b3f9651..5db52de695 100644 --- a/xen/include/public/arch-x86_64.h +++ b/xen/include/public/arch-x86_64.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * arch-x86_64.h * * Guest OS interface to x86 64-bit Xen. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2004-2006, K A Fraser */ diff --git a/xen/include/public/argo.h b/xen/include/public/argo.h index 3397a3a33f..84a4cb118b 100644 --- a/xen/include/public/argo.h +++ b/xen/include/public/argo.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * Argo : Hypervisor-Mediated data eXchange * @@ -6,24 +7,6 @@ * Copyright (c) 2010, Citrix Systems * Copyright (c) 2018-2019, BAE Systems * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * */ #ifndef __XEN_PUBLIC_ARGO_H__ diff --git a/xen/include/public/callback.h b/xen/include/public/callback.h index 8f937880e2..7f13be66f3 100644 --- a/xen/include/public/callback.h +++ b/xen/include/public/callback.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * callback.h * * Register guest OS callbacks with Xen. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2006, Ian Campbell */ diff --git a/xen/include/public/dom0_ops.h b/xen/include/public/dom0_ops.h index 76598dda18..9fba71d3a8 100644 --- a/xen/include/public/dom0_ops.h +++ b/xen/include/public/dom0_ops.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * dom0_ops.h * * Process command requests from domain-0 guest OS. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2002-2003, B Dragovic * Copyright (c) 2002-2006, K Fraser */ diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index b2ae839c36..966bf4323c 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * domctl.h * * Domain management operations. For use by node control stack. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2002-2003, B Dragovic * Copyright (c) 2002-2006, K Fraser */ diff --git a/xen/include/public/elfnote.h b/xen/include/public/elfnote.h index 181cbc4ec7..8bf54d035b 100644 --- a/xen/include/public/elfnote.h +++ b/xen/include/public/elfnote.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * elfnote.h * * Definitions used for the Xen ELF notes. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2006, Ian Campbell, XenSource Ltd. */ diff --git a/xen/include/public/event_channel.h b/xen/include/public/event_channel.h index 73c9f38ce1..0d91a1c4af 100644 --- a/xen/include/public/event_channel.h +++ b/xen/include/public/event_channel.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * event_channel.h * * Event channels between domains. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2003-2004, K A Fraser. */ diff --git a/xen/include/public/features.h b/xen/include/public/features.h index 9ee2f760ef..d2a9175aae 100644 --- a/xen/include/public/features.h +++ b/xen/include/public/features.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * features.h * * Feature flags, reported by XENVER_get_features. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2006, Keir Fraser */ diff --git a/xen/include/public/grant_table.h b/xen/include/public/grant_table.h index 7934d7b718..1dfa17a6d0 100644 --- a/xen/include/public/grant_table.h +++ b/xen/include/public/grant_table.h @@ -1,27 +1,10 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * grant_table.h * * Interface for granting foreign access to page frames, and receiving * page-ownership transfers. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2004, K A Fraser */ diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h index fa3f083fed..acdf91693d 100644 --- a/xen/include/public/hvm/dm_op.h +++ b/xen/include/public/hvm/dm_op.h @@ -1,24 +1,7 @@ +/* SPDX-License-Identifier: MIT */ /* * Copyright (c) 2016, Citrix Systems Inc * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * */ #ifndef __XEN_PUBLIC_HVM_DM_OP_H__ diff --git a/xen/include/public/hvm/e820.h b/xen/include/public/hvm/e820.h index 4c42f3341e..5879b8ff7b 100644 --- a/xen/include/public/hvm/e820.h +++ b/xen/include/public/hvm/e820.h @@ -1,22 +1,5 @@ +/* SPDX-License-Identifier: MIT */ /* - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2006, Keir Fraser */ diff --git a/xen/include/public/hvm/hvm_info_table.h b/xen/include/public/hvm/hvm_info_table.h index c46e03ef17..a885f356db 100644 --- a/xen/include/public/hvm/hvm_info_table.h +++ b/xen/include/public/hvm/hvm_info_table.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * hvm/hvm_info_table.h * * HVM parameter and information table, written into guest memory map. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2006, Keir Fraser */ diff --git a/xen/include/public/hvm/hvm_op.h b/xen/include/public/hvm/hvm_op.h index 870ec52060..e22adf0319 100644 --- a/xen/include/public/hvm/hvm_op.h +++ b/xen/include/public/hvm/hvm_op.h @@ -1,22 +1,5 @@ +/* SPDX-License-Identifier: MIT */ /* - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2007, Keir Fraser */ diff --git a/xen/include/public/hvm/hvm_vcpu.h b/xen/include/public/hvm/hvm_vcpu.h index 661cf89e1e..4a43401144 100644 --- a/xen/include/public/hvm/hvm_vcpu.h +++ b/xen/include/public/hvm/hvm_vcpu.h @@ -1,22 +1,5 @@ +/* SPDX-License-Identifier: MIT */ /* - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2015, Roger Pau Monne */ diff --git a/xen/include/public/hvm/hvm_xs_strings.h b/xen/include/public/hvm/hvm_xs_strings.h index fba2546424..e1ed078628 100644 --- a/xen/include/public/hvm/hvm_xs_strings.h +++ b/xen/include/public/hvm/hvm_xs_strings.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * hvm/hvm_xs_strings.h * * HVM xenstore strings used in HVMLOADER. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2013, Citrix Systems */ diff --git a/xen/include/public/hvm/ioreq.h b/xen/include/public/hvm/ioreq.h index c511fae8e7..7a6bc760d0 100644 --- a/xen/include/public/hvm/ioreq.h +++ b/xen/include/public/hvm/ioreq.h @@ -1,24 +1,7 @@ +/* SPDX-License-Identifier: MIT */ /* * ioreq.h: I/O request definitions for device models * Copyright (c) 2004, Intel Corporation. - * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. */ #ifndef _IOREQ_H_ diff --git a/xen/include/public/hvm/params.h b/xen/include/public/hvm/params.h index c9d6e70d7b..a22b4ed45d 100644 --- a/xen/include/public/hvm/params.h +++ b/xen/include/public/hvm/params.h @@ -1,22 +1,5 @@ +/* SPDX-License-Identifier: MIT */ /* - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2007, Keir Fraser */ diff --git a/xen/include/public/hvm/pvdrivers.h b/xen/include/public/hvm/pvdrivers.h index 3241f94eb9..62252db626 100644 --- a/xen/include/public/hvm/pvdrivers.h +++ b/xen/include/public/hvm/pvdrivers.h @@ -1,24 +1,7 @@ +/* SPDX-License-Identifier: MIT */ /* * pvdrivers.h: Register of PV drivers product numbers. * Copyright (c) 2012, Citrix Systems Inc. - * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. */ #ifndef _XEN_PUBLIC_PVDRIVERS_H_ diff --git a/xen/include/public/hvm/save.h b/xen/include/public/hvm/save.h index bea5e9f50f..464ebdb0da 100644 --- a/xen/include/public/hvm/save.h +++ b/xen/include/public/hvm/save.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: MIT */ /* * hvm/save.h * @@ -5,24 +6,6 @@ * be saved along with the domain's memory and device-model state. * * Copyright (c) 2007 XenSource Ltd. - * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. */ #ifndef __XEN_PUBLIC_HVM_SAVE_H__ diff --git a/xen/include/public/hypfs.h b/xen/include/public/hypfs.h index 2b7a66d68d..70047e1762 100644 --- a/xen/include/public/hypfs.h +++ b/xen/include/public/hypfs.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * Xen Hypervisor Filesystem * * Copyright (c) 2019, SUSE Software Solutions Germany GmbH * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * */ #ifndef __XEN_PUBLIC_HYPFS_H__ diff --git a/xen/include/public/io/9pfs.h b/xen/include/public/io/9pfs.h index 4bfd5d48b1..ad26bd69eb 100644 --- a/xen/include/public/io/9pfs.h +++ b/xen/include/public/io/9pfs.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /* * 9pfs.h -- Xen 9PFS transport * * Refer to docs/misc/9pfs.markdown for the specification * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (C) 2017 Stefano Stabellini */ diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h index ab863f175a..22f1eef0c0 100644 --- a/xen/include/public/io/blkif.h +++ b/xen/include/public/io/blkif.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * blkif.h * * Unified block-device I/O interface for Xen guest OSes. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2003-2004, Keir Fraser * Copyright (c) 2012, Spectra Logic Corporation */ diff --git a/xen/include/public/io/cameraif.h b/xen/include/public/io/cameraif.h index acbcbf3bd4..13763abef9 100644 --- a/xen/include/public/io/cameraif.h +++ b/xen/include/public/io/cameraif.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * cameraif.h * * Unified camera device I/O interface for Xen guest OSes. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (C) 2018-2019 EPAM Systems Inc. * * Author: Oleksandr Andrushchenko diff --git a/xen/include/public/io/console.h b/xen/include/public/io/console.h index 4811f47220..4509b4b689 100644 --- a/xen/include/public/io/console.h +++ b/xen/include/public/io/console.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * console.h * * Console I/O interface for Xen guest OSes. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2005, Keir Fraser */ diff --git a/xen/include/public/io/displif.h b/xen/include/public/io/displif.h index 0055895510..73d0cbdf15 100644 --- a/xen/include/public/io/displif.h +++ b/xen/include/public/io/displif.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * displif.h * * Unified display device I/O interface for Xen guest OSes. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (C) 2016-2017 EPAM Systems Inc. * * Authors: Oleksandr Andrushchenko diff --git a/xen/include/public/io/fbif.h b/xen/include/public/io/fbif.h index cc25aab32e..93c73195d8 100644 --- a/xen/include/public/io/fbif.h +++ b/xen/include/public/io/fbif.h @@ -1,24 +1,7 @@ +/* SPDX-License-Identifier: MIT */ /* * fbif.h -- Xen virtual frame buffer device * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (C) 2005 Anthony Liguori * Copyright (C) 2006 Red Hat, Inc., Markus Armbruster */ diff --git a/xen/include/public/io/fsif.h b/xen/include/public/io/fsif.h index a8bea193b5..ec57850233 100644 --- a/xen/include/public/io/fsif.h +++ b/xen/include/public/io/fsif.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * fsif.h * * Interface to FS level split device drivers. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2007, Grzegorz Milos, . */ diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h index a6b01c52c7..4bde6b3821 100644 --- a/xen/include/public/io/kbdif.h +++ b/xen/include/public/io/kbdif.h @@ -1,24 +1,7 @@ +/* SPDX-License-Identifier: MIT */ /* * kbdif.h -- Xen virtual keyboard/mouse * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (C) 2005 Anthony Liguori * Copyright (C) 2006 Red Hat, Inc., Markus Armbruster */ diff --git a/xen/include/public/io/libxenvchan.h b/xen/include/public/io/libxenvchan.h index 44284f437a..2eab65cb19 100644 --- a/xen/include/public/io/libxenvchan.h +++ b/xen/include/public/io/libxenvchan.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: MIT */ /** * @file * @section AUTHORS @@ -10,24 +11,6 @@ * * @section LICENSE * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * @section DESCRIPTION * * Originally borrowed from the Qubes OS Project, http://www.qubes-os.org, diff --git a/xen/include/public/io/netif.h b/xen/include/public/io/netif.h index 3509b096f8..c13b85061d 100644 --- a/xen/include/public/io/netif.h +++ b/xen/include/public/io/netif.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * netif.h * * Unified network-device I/O interface for Xen guest OSes. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2003-2004, Keir Fraser */ diff --git a/xen/include/public/io/pciif.h b/xen/include/public/io/pciif.h index a4ba13cc13..dbe825ecc3 100644 --- a/xen/include/public/io/pciif.h +++ b/xen/include/public/io/pciif.h @@ -1,24 +1,7 @@ +/* SPDX-License-Identifier: MIT */ /* * PCI Backend/Frontend Common Data Structures & Macros * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Author: Ryan Wilson */ #ifndef __XEN_PCI_COMMON_H__ diff --git a/xen/include/public/io/protocols.h b/xen/include/public/io/protocols.h index 52b4de0f81..7815e1ff0f 100644 --- a/xen/include/public/io/protocols.h +++ b/xen/include/public/io/protocols.h @@ -1,24 +1,7 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * protocols.h * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2008, Keir Fraser */ diff --git a/xen/include/public/io/pvcalls.h b/xen/include/public/io/pvcalls.h index 6da6b5533a..230b0719e3 100644 --- a/xen/include/public/io/pvcalls.h +++ b/xen/include/public/io/pvcalls.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: MIT */ /* * pvcalls.h -- Xen PV Calls Protocol * @@ -6,24 +7,6 @@ * The header is provided as a C reference for the specification. In * case of conflict, the specification is authoritative. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (C) 2017 Stefano Stabellini */ diff --git a/xen/include/public/io/ring.h b/xen/include/public/io/ring.h index ab3439bd58..025939278b 100644 --- a/xen/include/public/io/ring.h +++ b/xen/include/public/io/ring.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * ring.h * * Shared producer-consumer ring macros. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Tim Deegan and Andrew Warfield November 2004. */ diff --git a/xen/include/public/io/sndif.h b/xen/include/public/io/sndif.h index 402033cf49..4234a47c87 100644 --- a/xen/include/public/io/sndif.h +++ b/xen/include/public/io/sndif.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * sndif.h * * Unified sound-device I/O interface for Xen guest OSes. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (C) 2013-2015 GlobalLogic Inc. * Copyright (C) 2016-2017 EPAM Systems Inc. * diff --git a/xen/include/public/io/tpmif.h b/xen/include/public/io/tpmif.h index 9743dc9369..ad02dbaf1a 100644 --- a/xen/include/public/io/tpmif.h +++ b/xen/include/public/io/tpmif.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * tpmif.h * * TPM I/O interface for Xen guest OSes. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2005, IBM Corporation * * Author: Stefan Berger, stefanb@us.ibm.com diff --git a/xen/include/public/io/usbif.h b/xen/include/public/io/usbif.h index c0a552e195..875af0dc7c 100644 --- a/xen/include/public/io/usbif.h +++ b/xen/include/public/io/usbif.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: MIT */ /* * usbif.h * @@ -5,24 +6,6 @@ * * Copyright (C) 2009, FUJITSU LABORATORIES LTD. * Author: Noboru Iwamatsu - * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. */ #ifndef __XEN_PUBLIC_IO_USBIF_H__ diff --git a/xen/include/public/io/vscsiif.h b/xen/include/public/io/vscsiif.h index 8553b17cc6..f5fc7de725 100644 --- a/xen/include/public/io/vscsiif.h +++ b/xen/include/public/io/vscsiif.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * vscsiif.h * * Based on the blkif.h code. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright(c) FUJITSU Limited 2008. */ diff --git a/xen/include/public/io/xenbus.h b/xen/include/public/io/xenbus.h index 927f9db552..9cd0cd7c67 100644 --- a/xen/include/public/io/xenbus.h +++ b/xen/include/public/io/xenbus.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /***************************************************************************** * xenbus.h * * Xenbus protocol details. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (C) 2005 XenSource Ltd. */ diff --git a/xen/include/public/io/xs_wire.h b/xen/include/public/io/xs_wire.h index 05d3069e63..04e6849feb 100644 --- a/xen/include/public/io/xs_wire.h +++ b/xen/include/public/io/xs_wire.h @@ -1,25 +1,8 @@ +/* SPDX-License-Identifier: MIT */ /* * Details of the "wire" protocol between Xen Store Daemon and client * library or guest kernel. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (C) 2005 Rusty Russell IBM Corporation */ diff --git a/xen/include/public/kexec.h b/xen/include/public/kexec.h index 3f2a118381..a6c5fc8d13 100644 --- a/xen/include/public/kexec.h +++ b/xen/include/public/kexec.h @@ -1,24 +1,7 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * kexec.h - Public portion * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Xen port written by: * - Simon 'Horms' Horman * - Magnus Damm diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h index f8d26fb77d..29cf5c8239 100644 --- a/xen/include/public/memory.h +++ b/xen/include/public/memory.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * memory.h * * Memory reservation and information. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2005, Keir Fraser */ diff --git a/xen/include/public/nmi.h b/xen/include/public/nmi.h index 4dd7294d72..5900703f5f 100644 --- a/xen/include/public/nmi.h +++ b/xen/include/public/nmi.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * nmi.h * * NMI callback registration and reason codes. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2005, Keir Fraser */ diff --git a/xen/include/public/physdev.h b/xen/include/public/physdev.h index f8d1905e30..f0c0d4727c 100644 --- a/xen/include/public/physdev.h +++ b/xen/include/public/physdev.h @@ -1,22 +1,5 @@ +/* SPDX-License-Identifier: MIT */ /* - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2006, Keir Fraser */ diff --git a/xen/include/public/platform.h b/xen/include/public/platform.h index 8100133509..5e1494fe9a 100644 --- a/xen/include/public/platform.h +++ b/xen/include/public/platform.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * platform.h * * Hardware platform operations. Intended for use by domain-0 kernel. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2002-2006, K Fraser */ diff --git a/xen/include/public/pmu.h b/xen/include/public/pmu.h index cc2fcf8816..eb87a81e7b 100644 --- a/xen/include/public/pmu.h +++ b/xen/include/public/pmu.h @@ -1,22 +1,5 @@ +/* SPDX-License-Identifier: MIT */ /* - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved. */ diff --git a/xen/include/public/sched.h b/xen/include/public/sched.h index 811bd87c82..b4362c6a1d 100644 --- a/xen/include/public/sched.h +++ b/xen/include/public/sched.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * sched.h * * Scheduler state interactions * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2005, Keir Fraser */ diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 5672906729..051bff39b3 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * sysctl.h * * System management operations. For use by node control stack. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2002-2006, K Fraser */ diff --git a/xen/include/public/tmem.h b/xen/include/public/tmem.h index 362ba45d5a..da68de76fe 100644 --- a/xen/include/public/tmem.h +++ b/xen/include/public/tmem.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * tmem.h * * Guest OS interface to Xen Transcendent Memory. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2004, K A Fraser */ diff --git a/xen/include/public/trace.h b/xen/include/public/trace.h index d5fa4aea8d..62a179971d 100644 --- a/xen/include/public/trace.h +++ b/xen/include/public/trace.h @@ -1,24 +1,7 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * include/public/trace.h * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Mark Williamson, (C) 2004 Intel Research Cambridge * Copyright (C) 2005 Bin Ren */ diff --git a/xen/include/public/vcpu.h b/xen/include/public/vcpu.h index 3623af932f..81a3b3a743 100644 --- a/xen/include/public/vcpu.h +++ b/xen/include/public/vcpu.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * vcpu.h * * VCPU initialisation, query, and hotplug. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2005, Keir Fraser */ diff --git a/xen/include/public/version.h b/xen/include/public/version.h index 17a81e23cd..9c78b4f3b6 100644 --- a/xen/include/public/version.h +++ b/xen/include/public/version.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * version.h * * Xen version, type, and compile information. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2005, Nguyen Anh Quynh * Copyright (c) 2005, Keir Fraser */ diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h index 56b429a975..0035c26e12 100644 --- a/xen/include/public/vm_event.h +++ b/xen/include/public/vm_event.h @@ -1,27 +1,10 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * vm_event.h * * Memory event common structures. * * Copyright (c) 2009 by Citrix Systems, Inc. (Patrick Colp) - * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. */ #ifndef _XEN_PUBLIC_VM_EVENT_H diff --git a/xen/include/public/xen-compat.h b/xen/include/public/xen-compat.h index e1c027a95c..97fe698498 100644 --- a/xen/include/public/xen-compat.h +++ b/xen/include/public/xen-compat.h @@ -1,26 +1,9 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * xen-compat.h * * Guest OS interface to Xen. Compatibility layer. * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (c) 2006, Christian Limpach */ diff --git a/xen/include/public/xencomm.h b/xen/include/public/xencomm.h index ac45e0712a..a441f3e270 100644 --- a/xen/include/public/xencomm.h +++ b/xen/include/public/xencomm.h @@ -1,22 +1,5 @@ +/* SPDX-License-Identifier: MIT */ /* - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (C) IBM Corp. 2006 */ diff --git a/xen/include/public/xenoprof.h b/xen/include/public/xenoprof.h index 9f5ca87d9e..2298b6759e 100644 --- a/xen/include/public/xenoprof.h +++ b/xen/include/public/xenoprof.h @@ -1,27 +1,10 @@ +/* SPDX-License-Identifier: MIT */ /****************************************************************************** * xenoprof.h * * Interface for enabling system wide profiling based on hardware performance * counters * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. - * * Copyright (C) 2005 Hewlett-Packard Co. * Written by Aravind Menon & Jose Renato Santos */ diff --git a/xen/include/public/xsm/flask_op.h b/xen/include/public/xsm/flask_op.h index b41dd6dac8..7185e80621 100644 --- a/xen/include/public/xsm/flask_op.h +++ b/xen/include/public/xsm/flask_op.h @@ -1,25 +1,8 @@ +/* SPDX-License-Identifier: MIT */ /* * This file contains the flask_op hypercall commands and definitions. * * Author: George Coker, - * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - * DEALINGS IN THE SOFTWARE. */ #ifndef __FLASK_OP_H__ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 03 12:14:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 12:14:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436443.690546 (Exim 4.92) (envelope-from ) id 1oqZ6o-0008Jk-Ba; Thu, 03 Nov 2022 12:14:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436443.690546; Thu, 03 Nov 2022 12:14:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqZ6o-0008Jd-87; Thu, 03 Nov 2022 12:14:10 +0000 Received: by outflank-mailman (input) for mailman id 436443; Thu, 03 Nov 2022 12:14:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqZ6m-0008JW-DY for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 12:14:08 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2084.outbound.protection.outlook.com [40.107.244.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 02994a70-5b71-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 13:14:06 +0100 (CET) Received: from MW4PR03CA0342.namprd03.prod.outlook.com (2603:10b6:303:dc::17) by PH0PR12MB7077.namprd12.prod.outlook.com (2603:10b6:510:21d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Thu, 3 Nov 2022 12:14:02 +0000 Received: from CO1NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dc:cafe::6e) by MW4PR03CA0342.outlook.office365.com (2603:10b6:303:dc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Thu, 3 Nov 2022 12:14:02 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT056.mail.protection.outlook.com (10.13.175.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 12:14:01 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov 2022 07:14:01 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov 2022 07:14:00 -0500 Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Thu, 3 Nov 2022 07:13:59 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02994a70-5b71-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CEhGHT90qbPJKCah85fCGbbtLnfcRSUclIVppeaObZD6xuaZSCrzkyNHvYwVEBGyFpzU+3k9dY+vxwx0AbIRRVA6eVYgqFy8s/nIbnPx0S9JKrOaxnKLDIA40nmdsmcoqSV/H7Thk+/6pog436OnDmJjn6NLeJLPvoHpJH7AzZpFJZ95g6cqD58auD0pF/+YEfEbgZ1T9cf61XoNpcsy6BDd6f3Id9eEOYCgAbJHWk4D9DDfyqbl5L9KMW91vCTvWOqC0/Wiua8tW+D+1JXjQserYDeHoViXGE8cOnIftckvIe3reRNyEusb0oiIYFL6TPrOpNngin7B3X0YLTkWAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z3VUuimEL0Buz3Hv0OOVcwmdVzCYQYX/wD+fO26Vmuc=; b=LXKSc8/f0ssyUQHa+94n/sf0vVf256LQ4C1RIDAEWRGXz6bp+DoB3Lig5A8qQoIOHFuraU9MZKE7f+ovhtxshl8hX+47gLRzZEOtKo5/W3oeJT8d35C72Udrh93ZQKqdOKbNMKHYFviH9L4wuk4UVbWFGxv/Eh0GyozgWR/cCyjFxAspNAGSdErzFHdCLkblf/yJtlsdYZ7xVZ66IaSxGVtxpx3r/BATTSgQQ1AcwJ1c/yDoyY25XUuR7c43Q5g3ridosgwK9ZWDSSzTWjgdN29MUuCwMpUIj6327XSXv3c9nnEJJLyB19/NElN4wwSaMJcWd6f8bDMXscNiI5weag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z3VUuimEL0Buz3Hv0OOVcwmdVzCYQYX/wD+fO26Vmuc=; b=FiUi74a40m47J7kwBLlXNzLqrjTBgDM9a9y1T8J5U46yY19tWBlgWC0qCCwPkdJVV+4CulC2nJdyGWnblgebWzWUeWFNMadikAYU/5t/tKf25kgk25Aka8bc65y7BU+yCN+RDiIOTz4xQFgqV6BF67NNzqwqysWytV3nGzJPAWI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Thu, 3 Nov 2022 13:13:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 07/12] xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32 To: Ayan Kumar Halder , CC: , , , , , References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-8-ayankuma@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: <20221031151326.22634-8-ayankuma@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT056:EE_|PH0PR12MB7077:EE_ X-MS-Office365-Filtering-Correlation-Id: 5524a5b9-db99-448b-35b2-08dabd94e4cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UBx+a0Xi0VAiWP8BfBzdbFa2WFPsNJ6YHbbuu1aVjY8qO3CVnAmD+Ai/bhuNMQJ83nkTNgXGH8D+8CwSUbpZNY6tnbK4wxeyt2pklg9u8iSSDI6L9hA2mhnXx/F35+1BUwMXbzvq9L5cWlTZ8qrXlW0t+/SKFcN/4l3gtlne2GivrEVboxPclaL3JYsxkEtrXS0kWH/qGNwDVBVV0m9uGMWvSqU9yxuxNIDuucT9bpxepbgkVf9PES6abl3I5rShMF91ZMBipDk7K/dwCMqo+QmzWrffSP1WJgOeM1K/G+nl9w1PHGX+VARZ4ibR2cjEc+/0362AXEjEU8SEu7lkYaTCSX1Tr+67HQ6KG05A7Hb52WdFOGz7WzXEuO7xChgqDOEzDUXKRZdhJrjuuP5WiCMvvmaSHzQOf66o24Z46AljAMPTPeaNghS4JUkBN9MDfpU7fb2dmp2+bmIPcu+IZE8U6ZDKDp9TAJR4a24NrpuANbc+KL9xPWspgYqfR3OZUkdiio24UIlDHzzoXqu0/PNwQgKJ2VsAri2IIKDtNZY4XJHNeKTm7nUypQBd0qUubyBSGg0D+KNbneHUfJtsHxcG1LMWQFHaDgRH66Vq3hrgkMfbL8ucVo+C8KAijwJBKFmTI7lDOQX96ytmWpEsENTg1JSym4TuTsr8cb6/7VChI/RXCetGqLz6uMcMvENi2F59JKv761lBhOq+Z/cptqOxNa12HQAYwkvNlDB6PKSod3TsyQeGSK970JQvKOcPMIYvnh32lOqFj9ok5PNm4S03FKl9VmMCJ3lu4iW7N2rQ/ZlHsiQjm8RPPSCx0Ku/oX0peza2SwuwCQyLgowbgQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199015)(40470700004)(46966006)(36840700001)(356005)(4326008)(40460700003)(2616005)(36756003)(81166007)(86362001)(31696002)(26005)(2906002)(41300700001)(82310400005)(40480700001)(53546011)(8676002)(44832011)(186003)(8936002)(478600001)(110136005)(5660300002)(70586007)(16576012)(316002)(54906003)(36860700001)(82740400003)(70206006)(47076005)(83380400001)(31686004)(336012)(426003)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 12:14:01.5803 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5524a5b9-db99-448b-35b2-08dabd94e4cb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7077 Hi Ayan, On 31/10/2022 16:13, Ayan Kumar Halder wrote: > > > Refer "Arm IHI 0069H ID020922", 12.4.6, Interrupt Controller List Registers > > AArch64 System register ICH_LR_EL2 bits [31:0] are architecturally > mapped to AArch32 System register ICH_LR[31:0]. > AArch64 System register ICH_LR_EL2 bits [63:32] are architecturally > mapped to AArch32 System register ICH_LRC[31:0]. > > Defined ICH_LR<0...15>_EL2 and ICH_LRC<0...15>_EL2 for Aarch32. > For AArch32, the link register is stored as :- > (((uint64_t) ICH_LRC<0...15>_EL2) << 32) | ICH_LR<0...15>_EL2 > > Also, ICR_LR macros need to be modified as ULL is 64 bits for AArch32 and > AArch64. > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from :- > v1 - 1. Moved the coproc register definitions to asm/cpregs.h. > 2. Use GENMASK(31, 0) to represent 0xFFFFFFFF > 3. Use READ_CP32()/WRITE_CP32() instead of READ_SYSREG()/WRITE_SYSREG(). > 4. Multi-line macro definitions should be enclosed within ({ }). > > xen/arch/arm/gic-v3.c | 132 +++++++++++------------ > xen/arch/arm/include/asm/arm32/sysregs.h | 17 +++ > xen/arch/arm/include/asm/arm64/sysregs.h | 3 + > xen/arch/arm/include/asm/cpregs.h | 42 ++++++++ > xen/arch/arm/include/asm/gic_v3_defs.h | 6 +- > 5 files changed, 131 insertions(+), 69 deletions(-) > > diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h > index 6841d5de43..8a9a014bef 100644 > --- a/xen/arch/arm/include/asm/arm32/sysregs.h > +++ b/xen/arch/arm/include/asm/arm32/sysregs.h > @@ -62,6 +62,23 @@ > #define READ_SYSREG(R...) READ_SYSREG32(R) > #define WRITE_SYSREG(V, R...) WRITE_SYSREG32(V, R) > > +#define ICH_LR_REG(INDEX) ICH_LR ## INDEX ## _EL2 > +#define ICH_LRC_REG(INDEX) ICH_LRC ## INDEX ## _EL2 You could align to WRITE_SYSREG32(V, R). Apart from that it would be good to add some comment before the code you added (ICH_LR_REG) to separate from the code above and its comment about registers coming in 3 types. Something like: /* Wrappers for accessing interrupt controller list registers. */ > + > +#define READ_SYSREG_LR(INDEX) ({ \ Opening ({ should be placed one space after READ_SYSREG_LR(INDEX). It does not need to be aligned. > + uint64_t _val; \ val is not really necessary. You could directly return the ((uint64_t) _lrc << 32) | _lr; Just something to consider, no need to replace. > + uint32_t _lrc = READ_CP32(ICH_LRC_REG(INDEX)); \ > + uint32_t _lr = READ_CP32(ICH_LR_REG(INDEX)); \ > + \ > + _val = ((uint64_t) _lrc << 32) | _lr; \ > + _val; }) Here, you did put }) at the same line... > + > +#define WRITE_SYSREG_LR(INDEX, V) ({ \ > + uint64_t _val = (V); \ > + WRITE_CP32(_val & GENMASK(31, 0), ICH_LR_REG(INDEX)); \ > + WRITE_CP32(_val >> 32, ICH_LRC_REG(INDEX)); \ Please, align \ > +}); ... and here you did not. > + > /* MVFR2 is not defined on ARMv7 */ > #define MVFR2_MAYBE_UNDEFINED > > diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h > index 54670084c3..353f0eea29 100644 > --- a/xen/arch/arm/include/asm/arm64/sysregs.h > +++ b/xen/arch/arm/include/asm/arm64/sysregs.h > @@ -471,6 +471,9 @@ > > #define READ_SYSREG(name) READ_SYSREG64(name) > #define WRITE_SYSREG(v, name) WRITE_SYSREG64(v, name) Here, I would separate the below macros by adding the comment similar to the one I showed above. Or at least add a blank line. > +#define ICH_LR_REG(index) ICH_LR ## index ## _EL2 > +#define WRITE_SYSREG_LR(index, v) WRITE_SYSREG(v, ICH_LR_REG(index)) > +#define READ_SYSREG_LR(index) READ_SYSREG(ICH_LR_REG(index)) I find it a bit odd that the macro param 'index' is written in lower case and for arm32 in upper case. > > #endif /* _ASM_ARM_ARM64_SYSREGS_H */ > > diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h > index 6daf2b1a30..4421dd49ac 100644 > --- a/xen/arch/arm/include/asm/cpregs.h > +++ b/xen/arch/arm/include/asm/cpregs.h > @@ -362,6 +362,48 @@ > #define MVFR0_EL1 MVFR0 > #define MVFR1_EL1 MVFR1 > #define MVFR2_EL1 MVFR2 > + You could align everything below to MVFR2. Also maybe you could add some comment stating that the below relates to GIC system registers? > +#define ___CP32(a,b,c,d,e) a,b,c,d,e > +#define __LR0_EL2(x) ___CP32(p15,4,c12,c12,x) > +#define __LR8_EL2(x) ___CP32(p15,4,c12,c13,x) > + > +#define __LRC0_EL2(x) ___CP32(p15,4,c12,c14,x) > +#define __LRC8_EL2(x) ___CP32(p15,4,c12,c15,x) > + > +#define ICH_LR0_EL2 __LR0_EL2(0) > +#define ICH_LR1_EL2 __LR0_EL2(1) > +#define ICH_LR2_EL2 __LR0_EL2(2) > +#define ICH_LR3_EL2 __LR0_EL2(3) > +#define ICH_LR4_EL2 __LR0_EL2(4) > +#define ICH_LR5_EL2 __LR0_EL2(5) > +#define ICH_LR6_EL2 __LR0_EL2(6) > +#define ICH_LR7_EL2 __LR0_EL2(7) > +#define ICH_LR8_EL2 __LR8_EL2(0) > +#define ICH_LR9_EL2 __LR8_EL2(1) > +#define ICH_LR10_EL2 __LR8_EL2(2) > +#define ICH_LR11_EL2 __LR8_EL2(3) > +#define ICH_LR12_EL2 __LR8_EL2(4) > +#define ICH_LR13_EL2 __LR8_EL2(5) > +#define ICH_LR14_EL2 __LR8_EL2(6) > +#define ICH_LR15_EL2 __LR8_EL2(7) > + > +#define ICH_LRC0_EL2 __LRC0_EL2(0) > +#define ICH_LRC1_EL2 __LRC0_EL2(1) > +#define ICH_LRC2_EL2 __LRC0_EL2(2) > +#define ICH_LRC3_EL2 __LRC0_EL2(3) > +#define ICH_LRC4_EL2 __LRC0_EL2(4) > +#define ICH_LRC5_EL2 __LRC0_EL2(5) > +#define ICH_LRC6_EL2 __LRC0_EL2(6) > +#define ICH_LRC7_EL2 __LRC0_EL2(7) > +#define ICH_LRC8_EL2 __LRC8_EL2(0) > +#define ICH_LRC9_EL2 __LRC8_EL2(1) > +#define ICH_LRC10_EL2 __LRC8_EL2(2) > +#define ICH_LRC11_EL2 __LRC8_EL2(3) > +#define ICH_LRC12_EL2 __LRC8_EL2(4) > +#define ICH_LRC13_EL2 __LRC8_EL2(5) > +#define ICH_LRC14_EL2 __LRC8_EL2(6) > +#define ICH_LRC15_EL2 __LRC8_EL2(7) > + > #endif > > #endif > diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h > index 48a1bc401e..87115f8b25 100644 > --- a/xen/arch/arm/include/asm/gic_v3_defs.h > +++ b/xen/arch/arm/include/asm/gic_v3_defs.h > @@ -185,9 +185,9 @@ > #define ICH_LR_HW_SHIFT 61 > #define ICH_LR_GRP_MASK 0x1 > #define ICH_LR_GRP_SHIFT 60 > -#define ICH_LR_MAINTENANCE_IRQ (1UL<<41) > -#define ICH_LR_GRP1 (1UL<<60) > -#define ICH_LR_HW (1UL<<61) > +#define ICH_LR_MAINTENANCE_IRQ (1ULL<<41) > +#define ICH_LR_GRP1 (1ULL<<60) > +#define ICH_LR_HW (1ULL<<61) You could take the opportunity to add spaces between << to adhere to similar uses in this file. > > #define ICH_VTR_NRLRGS 0x3f > #define ICH_VTR_PRIBITS_MASK 0x7 > -- > 2.17.1 > > ~Michal From xen-devel-bounces@lists.xenproject.org Thu Nov 03 12:22:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 12:22:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436448.690557 (Exim 4.92) (envelope-from ) id 1oqZEr-0001pr-6B; Thu, 03 Nov 2022 12:22:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436448.690557; Thu, 03 Nov 2022 12:22:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqZEr-0001pk-1t; Thu, 03 Nov 2022 12:22:29 +0000 Received: by outflank-mailman (input) for mailman id 436448; Thu, 03 Nov 2022 12:22:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqZEp-0001pe-7e for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 12:22:27 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2bad08dd-5b72-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 13:22:25 +0100 (CET) Received: from mail-dm3nam02lp2044.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Nov 2022 08:22:15 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB6630.namprd03.prod.outlook.com (2603:10b6:a03:38a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov 2022 12:22:13 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%5]) with mapi id 15.20.5769.021; Thu, 3 Nov 2022 12:22:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2bad08dd-5b72-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667478145; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=KOAUBAuyUvN9JIeHF+V2qhgbd3oiAxvtloICLMP7GTQ=; b=dTUO61Jlk/s5ri+G/jqAUihZvj5rOxpsn4yd+GTboOzmatywNITWlv1M puvELRx4iKQejlQi6uYe+oksLW1pF6vfasxbobVbS7j/p3T5RcUY7RjAu 3Ju/F+51ecgg0gd++T2XjpicEeuPKrn0sPG+4wARqmd+EC3qhXI0ueNu0 E=; X-IronPort-RemoteIP: 104.47.56.44 X-IronPort-MID: 86623273 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:UeNm7KM7CIxZayTvrR2blsFynXyQoLVcMsEvi/4bfWQNrUongjQFy GUZWm7TaK6LN2akKIp3OY6w8U9Svp/cyddkHgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpB5gdmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0spYGGJg7 6YWFBMURTWZ2MeZ8ainY+Y506zPLOGzVG8ekldJ6GmDSNoDGtXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PRxvzS7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLVrCz23bWQxksXXqoyV+GC+6A7p2bD22k0JhYIXACWk8uQ3xvWt9V3b hZ8FjAVhbA76UiDSd/5Xhu1u3WEoxQYUpxcHoUS5gCXx6/Z/wueHEAZVTNbc5o9s9IsTjEk0 UWGkpXvCCAHmK2YTzeR+6mZqRu2ODMJNikSaCkcVwwH7tL/5oYpgXryos1LFae0ipj5HGr2y jXS9iwm3e1P0YgMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl BA5dwK2tYji0bnlePSxfdgw IronPort-HdrOrdr: A9a23:YyjKDa0uw5dixSNsQ5lhzAqjBEgkLtp133Aq2lEZdPU0SKGlfg 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8= X-IronPort-AV: E=Sophos;i="5.95,235,1661832000"; d="scan'208";a="86623273" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F6iv+zR8Oy3nVRaPzJ9Qi5EsHKXa3DdCwmsxUBCtG7Bqb2g+ZcKbscpxqwnODVi1sUplr6Q6ILkj5oC7PQdbrmWAt8qKx6C60R112Ylm54JRSt0O0LwDvVrjkXvJeTvAwsv9ztqbDwDwjzWz46cPnHAmUzzmlTGRG8fpgk427qcr284N3AkzUPg2AaQoDjkuhUntOCe6R3fHuYDmvBBKU/YlW8NCDirhR4X+yAAnzZO4mWF3tw1MlQGwrYooqZ60hj4AgfavWGHy5SUtBStGLVvpd3cSovlVUET6AMjcIEfxnxMjXaE08BvBfOwL44oNae4jJJgNLfGo4ccBD/8qBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3t9xB6iOPr8y/byF6KKMPelveYpY7HLpyDfj/bV7PVo=; b=Q/vIyR3b9cdldzARxh9zgKntnVNYIrKaZYKPnwDEX+WkPtAM+wy7a8XpNJZpKKQrPCwazrGNXf70PGHEw1Gbx61R8N4FAwLlr88Wsl5w/8lqtKuN2bfwooMHl9jL3X26H0AWQa9acz4qvWP2EPST8QtQbkrcsXC2iCF7aZlQQVyG/LGNZ3wlLOTAnCoa+c6Abw4qezeW0DhOR1h8aVMzgbZ53s9l226NyYtAoAmdVXp6le3LafBCVeiUcRZI4u30PNX10kQsOcR3f4kQXVRC28KBSJcBKkvKGIUCC+Jwrpbg6teui30spWSQ3qvISrPAwpeTilvc5xvURuEivwP6eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3t9xB6iOPr8y/byF6KKMPelveYpY7HLpyDfj/bV7PVo=; b=AD6h0msUs2teZ2wMeHuUCzQHIkmzqA4lwQlrgLlTDydsxxtCnGs4mTNs9g+hCKE+TyBbjxqx26L/314eDfUyppqCIOorDi0+R5vEcRAEm0zGTyKjbdZxXxW6mzOuLnQ2gbqF/g+NDuDT7of+nU4tcUwUQvMZCR0Wzpo372wtuNo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 3 Nov 2022 13:22:07 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Paul Leiber , "G.R." Cc: xen-devel@lists.xenproject.org Subject: Re: Possible bug? DOM-U network stopped working after fatal error reported in DOM0 Message-ID: References: <735adbe4-238b-bb7b-ba91-eb53759223aa@onlineschubla.de> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <735adbe4-238b-bb7b-ba91-eb53759223aa@onlineschubla.de> X-ClientProxiedBy: LO6P123CA0016.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::6) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6630:EE_ X-MS-Office365-Filtering-Correlation-Id: 53890bbd-6389-420d-c2e6-08dabd96094a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U17LPD2XO/NMNSdXlx33rTvRvYFFHgH9IXxQU0W1Sut83SzZNvpCRIL17YpZw3MQwNHeidLxoXCLkjsoggEwd3NiNt+y8jkBd/ic2rQvg+yYzixEZe63ZrNi59Rr3OmgPhiATGlz7eUVpJllYQORn6ST0gSN4/+px88L2TatScdIUG/Rg7BvYi6/NusVOErnoCvBSg7EEBoiCfOlymhL19g8k8hpFtGCKC3YIfTp/DOyIxJhs/OvokLG+wqvC8KDthMsrw0T0N4bO+VJwpXELl2N8hpQtQDCUmygRg9Xd5jrd8H4aPyIK5ZScpbmG4WQqGgMtIeMyOiblM7tfTX0CMlo0GrwZi4yfaVll5JWyzsSs2/LSgkvVQnvu1aQxtbEQ0xJJYqTNZCWP7LtjY0PSnKYg2TY+V8MaKI9NoRsPVm61mXYXZt7w3thaiYz79zirgL9QFyjw5M8WtZB7cCcJLCxJriHUQsWK78gLUxw0lx6E5bVyfj5xMiUavT8wCGJ7tfj2gVNqFpiXdnv3+uTgBt0gTFklsWlQNpeQhlUzAFgGa8EirNCF4/mnZP5QHr93vn5L0I4rs/UYPYraKPLbPb1HE4Ez78laXBO6vIQsVsmMyo0ZjFbusX8hFWPrVoiLRkJAdpIIPFcpqvABDXYxM6yMMyECqKWVxaX5BRTcvhlvw7ZXP5qINldEX0w5+kmOKo94Ye6x9TOMvN43iBttA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(366004)(396003)(39860400002)(136003)(376002)(346002)(451199015)(82960400001)(38100700002)(85182001)(86362001)(2906002)(6486002)(478600001)(6506007)(6666004)(26005)(66476007)(8676002)(66556008)(8936002)(110136005)(66946007)(5660300002)(41300700001)(4326008)(33716001)(9686003)(316002)(186003)(53546011)(6512007)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUFtN1pEMmdocngzZFluWENLd0tJcFN4L0dQTzA3WXRoR1VocjRXTytGazZ3?= =?utf-8?B?QSszUTB1M2R6SkxOL1M2ZkRtQ0tPTTM1cmhqUjVaWU40WHcyMlErL0xWUlFu?= =?utf-8?B?NFB4YkhNdnVjRzlISm5wWHdPbnpoNHRTZ1FmZC8rczZnaGVKK2FJc3lpb3BM?= =?utf-8?B?amFQY09JY3lYb1VoTHh6Yys0aURqZ1d6TkxmVFk3ZVFCL3NlUnV3bXJzNkdM?= =?utf-8?B?Q1dkdmtQY3ltWDI4RXB4YWlDSWJ4YVNQdmlnTTQ0bWlRc0lvcE5XdXVsRTFs?= =?utf-8?B?dWJYcXdwcXVlV3ZiK0JXbXlyWGhDa2RTYmhxeWhjNnN2RysxSVc2NE1QMHQy?= =?utf-8?B?YTYxejFqN21EdzBHdmZ2akh0U1ppcG9WeWdTa2hDQVp5QzlETENGSmFkakJk?= =?utf-8?B?b2VmYTlHNkFhbTZYUVNUcTdEMlpvRnJLbHd1azlocEpMOU9ZcmtOMTlWc2wz?= =?utf-8?B?eURjenZCZStqajJSMFp3emsvck4vVHJUNWRHbENRSE1TeFZrNTB2ekU4dnpx?= =?utf-8?B?YVJ3eFBJbklvZW5EVlVFMEpqSWlybHpQVSs1TVV1WFYwaU5yVENoak1HTnRM?= =?utf-8?B?R0c0dEJIRDJQSWFPdDYxVklWUmE3QzQ3NWJJS1J3MEVBVmlNQ05wbHhLaFo2?= =?utf-8?B?QnhoQVM5cnVYREx6cGx5Q2gwcTVwWE5tKzR2cHF6UDh5TEdmN0F3WUJnMnBU?= =?utf-8?B?dTE5dHVIUjhUSjZEbFVxWVk5Q2VEWlk2K3NINmk1TEdRVUM3dWhoM210RVRJ?= =?utf-8?B?SVBERWtYOGZFKzVVN1RtZTBucERHbmRPYjRtQlZoT0JsUWg1eE1sak8wb25v?= =?utf-8?B?V3FVTUFBQWRJaE4xRWM5enBDcU1lV0JkNkF3bU5WOWJkNlVNM0JWTjRtTkNv?= =?utf-8?B?ZnZBSnBqYWFIQVRuZk5TTDFFTkRqV2ZhT3hnYTFQaXczWkpKUmFzaGFzbm9K?= =?utf-8?B?c3dRaGpEWGVnTkdDUERJOWFUMXFHS1JSY3czcDkrUmZuZnNXR3NteGdHMjJC?= =?utf-8?B?M2xTa25LWFhxQVJweWtpeDVJeXhQZU44bUdja1dQaFY4ZGlZT2tlc2tndWJM?= =?utf-8?B?a3dmczBSbkY3Vm53ZHI2bDZYT29YMC9EaDhjNlZBS2I2UlpNSnd1eEQ5MXU4?= =?utf-8?B?TWpSaGxON0VtcXNISjZZM3BaUGUyKzIraEo1VlJ6WUNYN29wUkpjOEdxZTYy?= =?utf-8?B?UnBzbDlnUmdNbDFKTTltdllTZUE5T1JSN21sMUZabzdoUG9ONHgzYk5CK3VT?= =?utf-8?B?UFF2YzBiVDNDaUo4NmQ4OHFTQW1YLzJNb0JZZjd1VkxneGwyZWJsb0IvTEQ2?= =?utf-8?B?TXQ5ekY2SmViWWRnV2xvZENTdDlDWDJ4WWgxUDJSb1QrQnJSdUVZVFp5eWhn?= =?utf-8?B?bDE2UXdMZXNCdjdxNkV6UFRxZDF4QnhTTjdWLzVHRXQxZ1NCK1BGemlGOVNT?= =?utf-8?B?NUNoc3pQaHdhbW0yaUZWYjhzWk84NldiazRYZXJHZUJhV1A2am1pMy9MdTh6?= =?utf-8?B?Q01DZ2p5VjNjcCt3S1NFSTFsZ2dPdjc3SElMVEFnMkpiUWp2UDJlT21ERUR2?= =?utf-8?B?REREbDVJeHdNUW5KTC9TajllUHVQNUR5cmk3RllRNFg5YW9WcDQ0V2VnKzdE?= =?utf-8?B?RVByTlVhZnJSV1BaSUFqUnV5bmpLcUp5YmhmTEs2MmJBeDJTQjdJekJYK1pU?= =?utf-8?B?cW14UTVKTXQzYWRZWGRBRFZkbFZSeHl2MUFEY1oxWU12YkI3OElqNzllL0w4?= =?utf-8?B?QWpFY1lkdUQrLzU3aW5ERG5JSmNRbVB2dU5hV0FQdEMwY25RQkUydXRLUE1o?= =?utf-8?B?Ui9pMW5Xa2ZxSkhqT3RoRVRqNWNuWTI0VWxJSWg2NCtIVEVPS3BBRUUvL3Js?= =?utf-8?B?THA0Q3lLcDRUaFZIZkp2clgyQzlzRkQrTEQxUHFhNGRjVUxSbXdDcUJka3Fx?= =?utf-8?B?OGVqYlRhTURjWkQwTTk1RkRJK0pESjFGM0FiWlZUVkZWQVF6aHIvYkZnZUZF?= =?utf-8?B?blBlaU5yV3JrSk1pQ3JWQWNyWTFvbWVNSDE5d1p5TldkZ3RYZXNmSXl2ZzBY?= =?utf-8?B?ZEc0V09WbFJvNEcxS3k4Q0xmLzRjaUR4SkU1NW5kMHB6aStHYzhJcmFiQVpL?= =?utf-8?B?Uk9aMERiSWRzb3ZvaXhyY3FUaUc0OFFNaFQ1ZlFsRWoyem81aXlVZmNseStn?= =?utf-8?B?OXc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53890bbd-6389-420d-c2e6-08dabd96094a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 12:22:13.3750 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BHRyhIVAp7GsWtUnmel3wfCFN6TH+lRwYutvF5mNHTWXTJNTRUs7ZnDPTucPLB6oq8UB2OJUoTD6dxXPdJCElA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6630 On Thu, Nov 03, 2022 at 07:58:52AM +0100, Paul Leiber wrote: > > > Am 30.10.2022 um 17:36 schrieb G.R.: > > On Mon, Jan 10, 2022 at 10:54 PM Roger Pau Monné wrote: > > > > So looks like at least the imbalance between two directions are not > > > > related to your patch. > > > > Likely the debug build is a bigger contributor to the perf difference > > > > in both directions. > > > > > > > > I also tried your patch on a release build, and didn't observe any > > > > major difference in iperf3 numbers. > > > > Roughly match the 30Gbps and 1.xGbps number on the stock release kernel. > > > Thanks a lot, will try to get this upstream then. > > > > > > Roger. > > Hi Roger, any news for the upstream fix? I haven't heard any news since... > > The reason I came back to this thread is that I totally forgot about > > this issue and upgraded to FreeNAS 13 only to rediscover this issue > > once again :-( > > > > Any chance the patch can apply on FreeBSD 13.1-RELEASE-p1 kernel? > > > > Thanks, > > G.R. > > > > Hi, > > I want to confirm that the patch in an official release would make quite some people very happy. E.g. among OPNsense users, there are some who > suffer from the network issue [1]. FWIW, I compiled a kernel including Roger's patch, and it seems to be working without trouble in my OPNsense DomU. Hello to both, Sorry, I completely dropped the ball on that patch, didn't even remember I had it pending :(. Will do a build test with it and commit later today, I don't think I will get any feedback, and it seems to improve the situation for your use-cases. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Nov 03 12:23:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 12:23:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436452.690568 (Exim 4.92) (envelope-from ) id 1oqZGE-0002Ns-IL; Thu, 03 Nov 2022 12:23:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436452.690568; Thu, 03 Nov 2022 12:23:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqZGE-0002Nl-EJ; Thu, 03 Nov 2022 12:23:54 +0000 Received: by outflank-mailman (input) for mailman id 436452; Thu, 03 Nov 2022 12:23:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqZGD-0002Nb-5i for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 12:23:53 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5fe2e66a-5b72-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 13:23:52 +0100 (CET) Received: from BN8PR03CA0036.namprd03.prod.outlook.com (2603:10b6:408:94::49) by DS7PR12MB6048.namprd12.prod.outlook.com (2603:10b6:8:9f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Thu, 3 Nov 2022 12:23:49 +0000 Received: from BN8NAM11FT067.eop-nam11.prod.protection.outlook.com (2603:10b6:408:94:cafe::2d) by BN8PR03CA0036.outlook.office365.com (2603:10b6:408:94::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Thu, 3 Nov 2022 12:23:48 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT067.mail.protection.outlook.com (10.13.177.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 12:23:48 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov 2022 07:23:45 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov 2022 07:23:39 -0500 Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Thu, 3 Nov 2022 07:23:37 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5fe2e66a-5b72-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QqJCyvksQLWIaeefeFVhFsG2q2zOko56ttuNVLaLqh23EKf1kn+uJI0KWZ5zd8bRY+xt4r+vq4n4N5+mga+muMvQ5uB3AINlRpmy3pLb24004FEte+i0Vn8E0RW5KNVfHjAQKDkmt33GhCWrisVA7MnocCEWSN8SlODgc4jEoeQow4Er4hZV91g9KZiGGu3qdUZOgQp08Lus+NQ655pFNjtxt+hDFZ7NwrjXUARvDSsbmBEyLJMc8t+CH3HPnOoKZdEskT/7LYQCHp4LV3xdPx8iiu/tgREpGCG1xLMQ1zWClJ29S4z4l5d73loXBWs7DhW7sb3kAmtGL0BpDCeLQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F878IsiQbjU+ZsSiPuBtZniEpdcnFqckNkKCyzx5iYc=; b=C10xl/iqHYm9FA6XywYKWnHLrKoMxdrXoxjxoJDgDT+K09s45IuXP+pof5RO30SosFg+jjJX0MLPO8dM6EX40DgmNLTaV9nMLUyXhJ1pAgdJY6mPx0YradsCZcE4Dv8uuBqJaa0++XuisNAeopGHinSgNQ6MXTwzWu6ngnJcaSLeneS91YUZG0ghclLepxtD9fG3Xa5tB1fP0vMqaBZS8hVGZcwV1FuDEvs5hpL4oY6l5ahVeJcDWH0tnp1BxhEkD2Hq6+VbxkFWT6tHETevfc3hugkDo7nMLZS7UcOzo9Y7aSRzURkd6Hov0GHuymg8341VGEKEg2CWUs89X4aEiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F878IsiQbjU+ZsSiPuBtZniEpdcnFqckNkKCyzx5iYc=; b=B8fF5gF1Bhye2m6qX5tQw6HYvQHs/06M5z3lfpzuz9Ox9GySux7rNAJTPn6WFl/gsXGn4dddswnGDDWlahJHjtwjDXv4HQ+VT3YzenISTMOYjxOCqZQycwST2rhfNRTPHX1XK41OPBM79GR7p9i7ui3V/0iG/aEOyWr2zUYdros= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Thu, 3 Nov 2022 13:23:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v1] xen/Arm: Enforce alignment check for atomic read/write Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , References: <20221029224802.464-1-ayankuma@amd.com> From: Michal Orzel In-Reply-To: <20221029224802.464-1-ayankuma@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT067:EE_|DS7PR12MB6048:EE_ X-MS-Office365-Filtering-Correlation-Id: df5a9b30-e090-43a6-032b-08dabd96428b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HMg2DE6lUK89OwCG65io6irrdmSA1l+knpI2diDTDowcNgXNPs80NnV4UoRqNe5EfIUkSNBXYmfP4tMAk7F6M/eLA77z+9MHXVpv01jJ5Xwa2jnYe2Jmcxxu3KUDjEA6RTOSU1yoRwdpCqyD8WwNHMjOps4qVqSOAcDDTvXUL7U9Bmzbb+5eZw2uH31eAtZBvyjiTmHa5BPfCwNGua8ywLuT8QWU9pLY3pTmpz5IJvgB0iJ7pXLke2Mfu82z4iSM6txLNW3zqDzzYHA9C1fkuwXJYU7Ryim7hihlshJqHJvYTApqOsoASrs3L/xd6dSHzUsntvxrMPiCiFQ3e2gQNb3BWAYfsqRs49aNSButCkM1UZGZoes7weZ4GkWEE1NAbV17mKKhCia49SgvvbR54S2625WQohnINiPScc2ohGDj70I8Qxo5yZHTrvipva1wQU9RZ6+98CQnW2sWYqqzdvJA5q1d1gNxu/Z81CQL34wqdsHBjAZu0BHZHdVtw6siFdT4iWTZStSpkthQbUjXzpUzPkfRVJ9gfvzTkXLdQA9CvOaEydNTF/DKVv+s/1u5hfrBoTx9sJyQ5sdUKDENp5mutnt3MeiHy5LgunEsf/MGa+OZJcMO9liwGuU6wkaAvmOTeZ1TwLE98XX13sHyevcI2Gs3MGok0r+wUmVNQBQlM/IPmVza5ZZBkc/za3FG22Jo5B7zfgCpZSoEPNpzTS3jW1ed7J9ZP+GCvlXj/rAArDRZe2nZWmNHDH3MHXa4Bzc+/NWpVtgtWOsHCcrGYlwMaZQZWaLgNUiJKYYPPloprCKy3pGGbge0cibZ7Xuh162gi+96+BZZiwqSMXRNng== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199015)(46966006)(36840700001)(40470700004)(86362001)(36756003)(31696002)(31686004)(81166007)(82740400003)(356005)(40480700001)(186003)(336012)(44832011)(40460700003)(47076005)(4744005)(2906002)(53546011)(426003)(2616005)(110136005)(478600001)(26005)(36860700001)(54906003)(41300700001)(70586007)(16576012)(82310400005)(8676002)(5660300002)(4326008)(316002)(8936002)(70206006)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 12:23:48.5028 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df5a9b30-e090-43a6-032b-08dabd96428b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT067.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6048 Hi Ayan, On 30/10/2022 00:48, Ayan Kumar Halder wrote: > > > Refer ARM DDI 0487G.b ID072021, B2.2.1 Please refer to the latest spec. Apart from that... > "Requirements for single-copy atomicity > > - A read that is generated by a load instruction that loads a single > general-purpose register and is aligned to the size of the read in the > instruction is single-copy atomic. > > -A write that is generated by a store instruction that stores a single > general-purpose register and is aligned to the size of the write in the > instruction is single-copy atomic" > > On AArch32, the alignment check is enabled at boot time by setting HSCTLR.A bit. > ("HSCTLR, Hyp System Control Register"). > However in AArch64, alignment check is not enabled at boot time. > > Thus, one needs to check for alignment when performing atomic operations. > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 12:35:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436479.690597 (Exim 4.92) (envelope-from ) id 1oqZRj-0005D5-4R; Thu, 03 Nov 2022 12:35:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436479.690597; Thu, 03 Nov 2022 12:35:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqZRj-0005Cw-1N; Thu, 03 Nov 2022 12:35:47 +0000 Received: by outflank-mailman (input) for mailman id 436479; Thu, 03 Nov 2022 12:35:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqZRh-0004w1-M6 for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 12:35:45 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0548106c-5b74-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 13:35:39 +0100 (CET) Received: from MW4PR04CA0110.namprd04.prod.outlook.com (2603:10b6:303:83::25) by MN2PR12MB4304.namprd12.prod.outlook.com (2603:10b6:208:1d0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Thu, 3 Nov 2022 12:35:40 +0000 Received: from CO1NAM11FT078.eop-nam11.prod.protection.outlook.com (2603:10b6:303:83:cafe::4) by MW4PR04CA0110.outlook.office365.com (2603:10b6:303:83::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Thu, 3 Nov 2022 12:35:40 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT078.mail.protection.outlook.com (10.13.175.177) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 12:35:40 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov 2022 07:35:39 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov 2022 05:35:38 -0700 Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Thu, 3 Nov 2022 07:35:37 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0548106c-5b74-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fZMcwA8oxN0cAJYfDfkPa0hUBiz8sE2AHEaTZNBwNnd+yDvGP+V+QylfletvCVmxH9r787O7y8lEMHP5kYpF+gE/j6Knl6LfUwC1nHHd39g/cfFAQMq9CJMaqwYCbiM880RsblBFQyG4pZemndVaE5y9AmDf0LlDWVxZGu0hgqRgoZGVEae9UBnA+27cnPDWrM+dkJ6l0rfYcZCJ7NkWhDVN+rBctI/LnxtibbwS8kUBr/aRit2u/Y2hCa72g540oDMgxOecXHw0iM0FcX++H3KAI2LvhhWFvQ7T+56aQNN0y0kqdZx2Vr5MGMrlmfFwEKgylh9aK9ico+pUdBVGHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TZFsm3BApYRO9hcpsGrRitwNhBice3gGcWc2UUbeIiY=; b=JsaL1GC3LA7Ak2vv306u4hwZR97DlBdcbvPqOHpZD6aBoqaGnbukpsDl8bnOao1lq+ANDTOQ4mcDs8ABKxhDnpoANOhZ7/pPJdYpxu5K2XVTt4C11jnVSYGSaPEpeX0ag/GP14z7WUNeUTtKGwsRdtIhwjtiq9ZrfEPwG8mJAnPdzBwOSeYezxG/fKZxNMOYds5glpYLQUa3Kip+VuezTj21DUjMxkAUSOF5MrQflw3bueuVdQ1lsHvhO2FBmX2SDRGKO6ieeIz4XGmpV9gh1Da3wE+XmKgXj4ReHuat6jzftKSRycrjYatPK50QpDhk69Ox12SHBq+eTeSoemZr6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TZFsm3BApYRO9hcpsGrRitwNhBice3gGcWc2UUbeIiY=; b=IqzrUkdP//d2d0Nm3TXF+RQYSprrgVgllZ82MajCeof/T394V+jr4cU/y8aHqKM2ckx9puk9hjpwNtbtq8BYLmnjtd0xET4QWIdjx5Qoo3tsuTsytjd/bgeVEYz6y+2bHoB/V0aPBJY85yozuZSWd1SfHJBtBNpIX0NeYq8lktE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <64dbd0a2-3629-ff88-0b23-0fc8b087ada2@amd.com> Date: Thu, 3 Nov 2022 13:35:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 08/12] xen/Arm: GICv3: Define ICH_AP0R and ICH_AP1R for AArch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-9-ayankuma@amd.com> From: Michal Orzel In-Reply-To: <20221031151326.22634-9-ayankuma@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT078:EE_|MN2PR12MB4304:EE_ X-MS-Office365-Filtering-Correlation-Id: 88aea126-0a05-43ec-262c-08dabd97eabf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aNZjes1XhIZLjBaw/G0k4W9AdY/HSnhHPGhyqKzlV6qar2nXT7B3mXtTFxhgi/q9p4WrXL6/FBOnluRtY2Ulp/1Qc1+nRwsBbWVnWFgw/xvWwks67oiak765ldnuG2a66OUbGLQK4Sm/UNbsM4i3b62CBFg832Lx0MMvQPCbjC8M/uJKHpMzu+T219s5EKXYsXltR+ewOLT2ZwvvLn9q7czzJRmQK6MRfVN9K6u5fh7cokfJ/1+VHH/sb6MId0Fzrspdnjp1iNKYckGXTEijOdE4I+469aDvtqTTOStHKdaBA2IcuQdMTP0LLb53HTs4diCgHnNG3AjoFPKpBx+YUgHMUXUutfLM6gzO/OlI043sTqvPT5qz+XWbgOgidOPLxV78GADTgqmgoinrlwZhHcm5ex16SMLC1vI8C3JvzhtVTxW/UeSsF0Fvd+iwOkKE+6lcFN7J1Jr4h9SoO98xmnak0oxNKDTOL/EpgdS+DSMsfe7Mfn4N3QuIHVwH2fdiH/y4ozx8bUBt+uyDHEE/KdC+8feAjhujw0j+CcsnijM/5GKJ951W4EENZc+rr2ddNpNLgiVO/8Xppj+gvI9dLtfE8TVO4OCvlaw4LmwdTVayWLgCRnG8DLGhI6T0t2yZ5UF5Trpc/MkhOTblnMmlF4CZ1veJ+3cQX+nfcKX/MZCMKeOCXtqIve6DbjGYQRVFWY2EZnlf45iRJ02uQSRZY7zgTqegwfK+5v8gfUjkwmFHndn4QlsO8fm+BsCNeUET6mGEwt/LfRqpBFh6qxCwxrJtuR4k5P1Ra2cECdT6Kwzb5RZrF3tP4CcGlhK/ujb6Jkf0jOk2ItSKroLoNu6nIA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(346002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(40460700003)(31686004)(36756003)(40480700001)(426003)(336012)(36860700001)(82740400003)(2906002)(5660300002)(83380400001)(47076005)(44832011)(81166007)(86362001)(356005)(31696002)(26005)(110136005)(2616005)(316002)(478600001)(41300700001)(4326008)(54906003)(16576012)(70586007)(53546011)(70206006)(186003)(8676002)(8936002)(82310400005)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 12:35:40.0734 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88aea126-0a05-43ec-262c-08dabd97eabf X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT078.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4304 Hi Ayan, On 31/10/2022 16:13, Ayan Kumar Halder wrote: > > > Refer "Arm IHI 0069H ID020922", > 12.7.1 - Interrupt Controller Hyp Active Priorities Group0 Registers 0-3 > 12.7.2 - Interrupt Controller Hyp Active Priorities Group1 Registers 0-3 > Commit msg like this is not really beneficial as it requires someone to have this spec and only tells that such registers exist on AArch32. It is missing some information e.g. what is the purpose of defining them. > Signed-off-by: Ayan Kumar Halder > --- > > Changes from :- > v1 - 1. Moved coproc register definition to asm/cpregs.h. > > xen/arch/arm/include/asm/arm32/sysregs.h | 1 - > xen/arch/arm/include/asm/cpregs.h | 11 +++++++++++ > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h > index 8a9a014bef..1b2915a526 100644 > --- a/xen/arch/arm/include/asm/arm32/sysregs.h > +++ b/xen/arch/arm/include/asm/arm32/sysregs.h > @@ -81,7 +81,6 @@ > > /* MVFR2 is not defined on ARMv7 */ > #define MVFR2_MAYBE_UNDEFINED > - > #endif /* __ASSEMBLY__ */ > > #endif /* __ASM_ARM_ARM32_SYSREGS_H */ > diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h > index 4421dd49ac..bfabee0bc3 100644 > --- a/xen/arch/arm/include/asm/cpregs.h > +++ b/xen/arch/arm/include/asm/cpregs.h > @@ -404,6 +404,17 @@ > #define ICH_LRC14_EL2 __LRC8_EL2(6) > #define ICH_LRC15_EL2 __LRC8_EL2(7) > > +#define __AP0Rx_EL2(x) ___CP32(p15,4,c12,c8,x) > +#define ICH_AP0R0_EL2 __AP0Rx_EL2(0) > +#define ICH_AP0R1_EL2 __AP0Rx_EL2(1) > +#define ICH_AP0R2_EL2 __AP0Rx_EL2(2) > +#define ICH_AP0R3_EL2 __AP0Rx_EL2(3) > + > +#define __AP1Rx_EL2(x) ___CP32(p15,4,c12,c9,x) > +#define ICH_AP1R0_EL2 __AP1Rx_EL2(0) > +#define ICH_AP1R1_EL2 __AP1Rx_EL2(1) > +#define ICH_AP1R2_EL2 __AP1Rx_EL2(2) > +#define ICH_AP1R3_EL2 __AP1Rx_EL2(3) This might need to be re-aligned after you fix patch no. 7. Then, you can add: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu Nov 03 12:56:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 12:56:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436509.690608 (Exim 4.92) (envelope-from ) id 1oqZld-0000eC-QA; Thu, 03 Nov 2022 12:56:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436509.690608; Thu, 03 Nov 2022 12:56:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqZld-0000e5-MY; Thu, 03 Nov 2022 12:56:21 +0000 Received: by outflank-mailman (input) for mailman id 436509; Thu, 03 Nov 2022 12:56:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqZlb-0000de-Q1 for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 12:56:19 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2079.outbound.protection.outlook.com [40.107.22.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e7dda0e1-5b76-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 13:56:18 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9006.eurprd04.prod.outlook.com (2603:10a6:102:20e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov 2022 12:56:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 12:56:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7dda0e1-5b76-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=evLDLtKE4GNlHPJau7PRxggMOZ8IvK6bjoO4vNUnzQxFeNT8kcrgPPrbrxgJ4lwCeVqa7swgmMh1Rb5p5WGn14kJRsHXjiKsgRFfXq4pKtf92BMS6AYGWFQadMuYupzRxk0HwV3oewrqStFP365YZDgVnPoBaqNlIsxq4PZZd9DPQCamtX+3nft5YehDsd/60kQ+3oKxARV8oyDWjsy1WXLOzkmHNdsGwawUT85crOjl+6hDOxslnd4qMV4YKPrwpOmy0SX/8D2XtfSgaJ7QhyEyjKKQXa+K59pH8ZJeO6hrhqudEd+MetYRS1uhc4GTfULLSlkSqo+qZ0fY75TOzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9f2gBqeoiq55r67JYtIZwPfGfWOyDmu9Wq/m5d9fQn0=; b=JKv2FqrgwfxQbyoBChCTr1VxggXiLSfjx7gihgbuY1boYR7ZHevkth5MqXQMWb4o/JO17YsVfQOFJdMJtVI3TmXTZhaLSlHBG4tzUbHKzb27aFnpEn7yF6Y7p3Ww2JdxP0ZcvJaVid0KDHZ6Ht/3/5TaZTNGRNE8cqKBoEmb4zVk7aP+/xSpO+jlGr7ZzAiBUSUdvnBqi8bfYkSryIlEffs48GFAiSGgn5vUpoRw1UsEOpdCE8KzwwQn2CQy8XcOClVrYcTBpafVWY7fkYGFEaMZfiix3A9shA6LpQjDg4QVFvtm8iPyFXtrye6W5keEktVsLMw3P0DIYB6dV+UoVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9f2gBqeoiq55r67JYtIZwPfGfWOyDmu9Wq/m5d9fQn0=; b=Cv6nmzJcujx0//Azd4DkdPk7ilLYpKbfyUr5rZLnBTSxP3gBv7Lap2JwDUpSrnAXuPyWKGkTDA3LrNullhZG6AL4kCy5kngiPrwndVfB1H8VxWIzwChJmqjod2VA265I/d/7XYj8YXxZVhDV3oeD+KWW9nV8G/T+M2Ad/xPhCc7CRZW3VyLKpt8Zu+5QXfQi6nGsxoiL5n/gf75nwmkb/JuaribQgorniRJD0+jzjW9icrpXxhCMuX4wWhKUlpbnJ6BHmIWEcgqcvBItYFaRoik4NfKMDJHb/v9j5uUyNGl8gPj/qusELBqPBMk3b0FEUp6KZW5Bzuzbi0U85h5o6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 3 Nov 2022 13:56:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 From: Jan Beulich Subject: Xen 4.16.2 released To: xen-announce@lists.xenproject.org Cc: "xen-devel@lists.xenproject.org" Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0048.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9006:EE_ X-MS-Office365-Filtering-Correlation-Id: ff6fb70a-cd92-47f0-343f-08dabd9aca92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RtNf9vh1dXyd+Zl/EvjUilU1roww8inQn4uUwWXu6JtJMwCxP7bkpcLjOyvW6/Gqw4fv4I0mmV8lrwqhvi6H4BM5VP2PaCNaSHx1HRcH0T5FhZmX96qM4IfLVlJ7D7DGQ+SyFpMYWe9pP8257wc8AhMMcbnFtXcTN1dtEt+7rXaaJRlKspsD4RN0vGXer29J9lvoi9oPIxPt/CeWjuCmbgYjoc4tdL+yJMNR1JNxkWLad1hlMCjTWTSr/HjM6qJnOBYYBjrHAwos4JhgApB6LQMXo1iUiCmIJRU2LvXR5YoUsxsMQ8PWK5CVEyHwhQCNdvXnmBmqdZMC6kcdwDAUfrCYxp+qmVgWzwXt4j/MbZACQRbtEDUDpEhwVXMVsYAFiTIGDNPr3Y6z/DTHbePs41WbqQelwO1J6Ti7P4pv7qTIz/LM/Jk57uUQaNhwP40BbenaW+6L/wFAOF8UgcwEgYrFty6c1mstDgzL3xZcpMOJfTFxHE9bZ5EBhuP+lmuOP0Oknss9e9U3dO8Nvjpn7KOQxytaU2ZQNYCI55wIuWxD84YAH93eeQxu84FjnMNZTSXrp8Ltk36hVxPbTXvXqF4soXwYT4ltYVk1VmTChe3Ax3ivwLrOVGcernNmHi6Jkzc1blk+j2Dj34yGBAe9CWNtgsgRsyVtfJbwozAQzeUzv1ctqsjMGzzXIVKzuBNAvfkhFvMQ8zx77sBRA4nH1O9O/WSdlvn1ZKcwJhzjvB7W/MYdl0bAtnMG/9+r7x2O4tzvVsgt7QCbXR2aiGW8bgVfoV73u08qvul7RrvfRhe4kfUNtSjBRXerjdOdl1PQikY0v9x92bknDUI0ux8qLw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(136003)(39860400002)(366004)(451199015)(38100700002)(86362001)(83380400001)(31696002)(5660300002)(26005)(4744005)(2906002)(66476007)(66946007)(8936002)(4326008)(8676002)(41300700001)(7116003)(66556008)(6506007)(6512007)(186003)(450100002)(6486002)(316002)(2616005)(6916009)(478600001)(966005)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWVzOWJiVDlxY3grbU9zK3NYRk16YVp2cFkybkVOWksvclNoL2p1aGhudFhi?= =?utf-8?B?VW1UaTFLSUozTEk1ZDJwNDloK2hZL0FJZHloS0VQTlFmVCttNjVjWUlrTkZa?= =?utf-8?B?Nkl0K2Z0M1VFRTIwbVU5U3FxT3Q3QitSb3dNVkRWMlh3YVplTnprM1pLV1FU?= =?utf-8?B?SWE1WUpQOUx2bWZ6aWVDdXljeEdzYnFkZWV6WHZacERWRWVZQThRWFVUZ2Qr?= =?utf-8?B?Y2hPOUNWYTlGU3h6QVExRHZCTlFhNmpGTGdSbmNrT1V2eTlDTFVlWG1vYTZU?= =?utf-8?B?U1NJSlMzQU5aZkJSckcxc3dRUTl2QklUb1phNDJlVnpkSXFKaE93THRhbFFS?= =?utf-8?B?UGdKWVlPYk5wZWJIZ2IzeU11L0tXdUEzVmV3TkdNMmpLVFRpREkvZGE4MUNh?= =?utf-8?B?VFd4em1MU3lVZFhkamF2ckdvVlVJUExWalhaVGFVaGVGQ0FwT0NGa1I3WWkv?= =?utf-8?B?K29WUFYrbysyMmppM1U4SURPWGEyWlk2ZksxSldabXZrNER5SWw4OFlRY0JT?= =?utf-8?B?T2dXOGJVb0xSNkcxMzlTS1g3Rkdna29SZGluQklzemtvSHd1cnFXdXZ3YVo5?= =?utf-8?B?RFBZWUE4OHF2cEhqZ3N6c1hNa1BSOHYrbjlIY0x0VlVWbXo3Vk9pTzlrcUsz?= =?utf-8?B?TzJMd1pMekk0MzFXejIvdUlNWFZvZjljaFR4RmRDNjNKempTSjhGUE5McFox?= =?utf-8?B?S0l2ZVRyakVLV1MwdkxPNnYvemFzTThmYkhtenczbFA3NTVHTTllSHlVcFVS?= =?utf-8?B?WFJpL2lBMWV3OFVVTnRUeGlUTDdhYmlSNXcrN21qeU5lYTVCM1dyekU3anF1?= =?utf-8?B?Uk1EeTNZcmEzZGl3VFhTN3BWa0J2QzR0WXYyQktTLzZ3ZmZub2NEbUZPNncz?= =?utf-8?B?Q0FkQ0NxK09qS1dnZG5jTGVJaVZMK3ZyTUVLZlhMeFhZRGIrZGlmN1MrZ0kx?= =?utf-8?B?WWc4dUVwcy9KSTAvYVAxMDcvd2NUYWVidStaQ0pkK2Y4dzkyak0yVXVHRkhh?= =?utf-8?B?dWVyZVlaUXVKS1FGZE1wK3FWQ0M5VTMzazRKZ1RPOHZ3L01YbHlna0Y1N0w2?= =?utf-8?B?cFloMWd1VmRZLzVDTVhTSG9mY0hndmVoTTdDOVQ3dmxDdE1aYzl2eTZ5cUVp?= =?utf-8?B?ak84R211RkhUbGt4aEhSTnpBankxOGNxU1ZSeUtsZDVudW5wWTdMdE96dk8v?= =?utf-8?B?SkNHWjdGanFjWTVTYXhtUjdsc1A2L3NCdmtCcUJvWTQwNUczSDA5U0JNd2F1?= =?utf-8?B?SUp5ZStWdmJiRGpzbHpMNDUrUFM5QTV5a28vWFM2UE4raTROZWRvR3dUUmwv?= =?utf-8?B?T0p4a3RXV1JRdklVTkhDaU9jR3ZMcFpWZytYL0dYNS9CVS9mM3NzWjUzZ2U1?= =?utf-8?B?cmFwV0F3eGdMQkFxNEdnVGNBakEwZU9UT2NwQUlXT3JjL1RTWjVOdlh6ZHRS?= =?utf-8?B?d3lPcjlPMGY2cGh5UmJoaWtkbkkvbnM4ODlGWTVLbUt4eENmNmpBeGdXYW5F?= =?utf-8?B?TjdQOVc5QWlYYjNyelhIRzRydjlMZjRkd1JESm93eWlidGJ5enp4OWt3N0J1?= =?utf-8?B?SEY1dWVia2pqOExMbXFlS05raG84RGxxQUdHSGdnbXV5NWw3MjA4bVdGN0RJ?= =?utf-8?B?cE15REZiSnFpaU81anpyUDJRTGF6TGV2cGtlckRqR0VlYzA5NFBtSk85SmNv?= =?utf-8?B?ai9PaGNJV0tHNzlqQ2FZT2ZkbGwvb09Ja2thWG85SWdGVGVXOWU4YmQ1bmNl?= =?utf-8?B?M0NwMk9ldVF4V3YrNXg1ZmtBdWdlZ1FwOHc0bzVhZTEyVXdFK2hQaWVuUURn?= =?utf-8?B?TEZKcWhiOTE0WDdHbkUyb1E5ZzBXZG1yaUZqREZ5VjNDZGNXbHlUWSt2ZlBS?= =?utf-8?B?VXhNVkZRSDkxMUc3VUI0OHZMV2NmVGo3SXJRYTJaOUdQaFZNTlRHeEU3OUx4?= =?utf-8?B?Z25KNUpnZno0bXJFOTMwZ2t3YXp5bGswaWcvK2ovZUhQODYwUnQ4L0Rtb2p0?= =?utf-8?B?VkhjMDM2bXFkdVpwYmJJV2dudS96ZlJPSEhGOW14OEF4V0hrUEZwYWhxUUZN?= =?utf-8?B?WGc3bndmWGNNZ3RFd01KdGZJcnlKd2Q0TzkzL0tycXE1OHp3K1QzRVlHakRt?= =?utf-8?Q?XPGIhGBulsubcYHaOt4yAhpP4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff6fb70a-cd92-47f0-343f-08dabd9aca92 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 12:56:14.8945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QGr8vkNQOEivvl7l42dZ12DIkUZ6sm7OSHAkqEsebYwzKHQ+7R/5KTcQBws5X5n/mDwsJ9JyKlCchAjMEEo7vA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9006 All, we're pleased to announce the release of Xen 4.16.2. This has been available for a while from its git repository http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.16 (tag RELEASE-4.16.2) or from the XenProject download page https://xenproject.org/downloads/xen-project-archives/xen-project-4-16-series/xen-project-4-16-2/ (where a list of changes can also be found). We recommend all users of the 4.16 stable series to update to this latest point release. I apologize for the delayed announcement. Regards, Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 03 13:06:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 13:06:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436575.690633 (Exim 4.92) (envelope-from ) id 1oqZvd-0003u8-2n; Thu, 03 Nov 2022 13:06:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436575.690633; Thu, 03 Nov 2022 13:06:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqZvd-0003u1-06; Thu, 03 Nov 2022 13:06:41 +0000 Received: by outflank-mailman (input) for mailman id 436575; Thu, 03 Nov 2022 13:06:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqZvc-0003tr-Fe; Thu, 03 Nov 2022 13:06:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqZvc-0003Tt-CK; Thu, 03 Nov 2022 13:06:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqZvb-0004dd-R6; Thu, 03 Nov 2022 13:06:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqZvb-00026O-Qe; Thu, 03 Nov 2022 13:06:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iU84jy0+CaE2glHtokSWsZwynpSg/0XQAzKhP5C52D8=; b=jrcqQWwk37pKSqptsy1GlRVnLQ pBXb/DKIpmf+iWlEWYzKlL1ixxdAj/b83ebb/+GsSjScCERfc2y0NDYixdloPRw+Oq9iOsZtnQS5x GI00XoG3upatL6dcDW/65zTmc0qL+FUY0MF1Sy6JjYnQTGzqWh3GLALKOn5581mQg2iU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174592: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=8f71a2b3f435f29b787537d1abedaa7d8ebe6647 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 03 Nov 2022 13:06:39 +0000 flight 174592 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174592/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 8f71a2b3f435f29b787537d1abedaa7d8ebe6647 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 26 days Failing since 173470 2022-10-08 06:21:34 Z 26 days 41 attempts Testing same since 174576 2022-11-01 23:43:36 Z 1 days 2 attempts ------------------------------------------------------------ 1535 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 144299 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Nov 03 13:19:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 13:19:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436583.690644 (Exim 4.92) (envelope-from ) id 1oqa7w-0005xX-B9; Thu, 03 Nov 2022 13:19:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436583.690644; Thu, 03 Nov 2022 13:19:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqa7w-0005xQ-8W; Thu, 03 Nov 2022 13:19:24 +0000 Received: by outflank-mailman (input) for mailman id 436583; Thu, 03 Nov 2022 13:19:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqa7u-0005xK-Vi for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 13:19:23 +0000 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [2607:f8b0:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 206b9cb2-5b7a-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 14:19:21 +0100 (CET) Received: by mail-ot1-x32f.google.com with SMTP id k59-20020a9d19c1000000b0066c45cdfca5so935394otk.10 for ; Thu, 03 Nov 2022 06:19:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 206b9cb2-5b7a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=iQ8PQVj82FaQ9LUd3o9QfAubExvzsF8Edqea9t2SIG8=; b=a4sRTXzkK9mF4OQewlFU3sQTKQzC+mDlvEiTdM1XHvOMXwPeRwDs+bfCvYwYbiVxfl p9Z9PEWlo6Y+o39oSTejZzgrz+UrIJd0GMxOi34rF8aHLRM2O17GZmRma8nBtBJI5TBU AxgwRByGV18v8HEC+nvBXCdXwhCv5HU7rT47jLNNyPDoD3rjhzvu2N6lzPkTyr/IMujp YWqVIxZRi6d1aAwBdadWgTH1s21On3muSijmVQNADKEX48eYKN/j5oq67HfVq1055mDb 2WWaX/rjmrLwoC0uTjnthGlqr9kSJIXnSBdjNlJZEIIigGgurdUswULX6KUaCB6k9umR Y0EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iQ8PQVj82FaQ9LUd3o9QfAubExvzsF8Edqea9t2SIG8=; b=6escNit0RunwSsLPG3ceegHVy2LzO8hWfNTtUP9agwUR6n7d6jt9iGfk3vgO0GyASV 8BRtuOa+tNN0AW2G7040O/cBsqtE8qX+/9podXH6OdtXfy7k8wFq5eJHVOsd8IzWXVG5 R9yI82tC1PovPe1hHIuEXcBTn7kRfusbtW7wRns1C9/18jWhVlj4eMCOFEruHkG3H8J4 gBnU89JYJr7CSTdK47Uz/HUuugjjrJMfbTZmlLFsgzQDTQbWbLi0Rwr58KY2jelGFJZe LkdR6MsCbKngNu727M7LgO2mqT/8dIur40ATUGHURjgbybTXlvxekco9/sHmIvbVECzf s00w== X-Gm-Message-State: ACrzQf3FGyVO8P07jc2q6VfALHBkOpSl7pnkOR2jIXjzrqf2k7GEY8Ih ccwGJ3tqn9bNBLzfQZVohfznX2gVD8VmtRNnBA== X-Google-Smtp-Source: AMsMyM5At5QIXD+W1ctPricPlnnX9xjVg0QTOE8jZ8RNtVL0/JksfYeTA1uggniA1HiVbfFClLRC6HVvFPEErGKIMeg= X-Received: by 2002:a05:6830:148a:b0:66c:7b8c:4598 with SMTP id s10-20020a056830148a00b0066c7b8c4598mr3443204otq.81.1667481560181; Thu, 03 Nov 2022 06:19:20 -0700 (PDT) MIME-Version: 1.0 References: <20221103113636.25543-1-jgross@suse.com> <20221103113636.25543-5-jgross@suse.com> In-Reply-To: <20221103113636.25543-5-jgross@suse.com> From: Brian Gerst Date: Thu, 3 Nov 2022 09:19:06 -0400 Message-ID: Subject: Re: [PATCH 4/4] x86: switch to cpu_feature_enabled() for X86_FEATURE_XENPV To: Juergen Gross Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Pu Wen , Andy Lutomirski , Peter Zijlstra Content-Type: text/plain; charset="UTF-8" On Thu, Nov 3, 2022 at 8:37 AM Juergen Gross wrote: > > Convert the remaining cases of static_cpu_has(X86_FEATURE_XENPV) and > boot_cpu_has(X86_FEATURE_XENPV) to use cpu_feature_enabled(), allowing > more efficient code in case the kernel is configured without > CONFIG_XEN_PV. > > Signed-off-by: Juergen Gross > --- > arch/x86/kernel/cpu/amd.c | 2 +- > arch/x86/kernel/cpu/bugs.c | 2 +- > arch/x86/kernel/cpu/hygon.c | 2 +- > arch/x86/kernel/process_64.c | 4 ++-- > arch/x86/kernel/topology.c | 2 +- > arch/x86/mm/cpu_entry_area.c | 2 +- > 6 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c > index 860b60273df3..697fe881e967 100644 > --- a/arch/x86/kernel/cpu/amd.c > +++ b/arch/x86/kernel/cpu/amd.c > @@ -985,7 +985,7 @@ static void init_amd(struct cpuinfo_x86 *c) > set_cpu_cap(c, X86_FEATURE_3DNOWPREFETCH); > > /* AMD CPUs don't reset SS attributes on SYSRET, Xen does. */ > - if (!cpu_has(c, X86_FEATURE_XENPV)) > + if (!cpu_feature_enabled(X86_FEATURE_XENPV)) > set_cpu_bug(c, X86_BUG_SYSRET_SS_ATTRS); > > /* > diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c > index da7c361f47e0..7f78e1527c5e 100644 > --- a/arch/x86/kernel/cpu/bugs.c > +++ b/arch/x86/kernel/cpu/bugs.c > @@ -1302,7 +1302,7 @@ static enum spectre_v2_mitigation_cmd __init spectre_v2_parse_cmdline(void) > return SPECTRE_V2_CMD_AUTO; > } > > - if (cmd == SPECTRE_V2_CMD_IBRS && boot_cpu_has(X86_FEATURE_XENPV)) { > + if (cmd == SPECTRE_V2_CMD_IBRS && cpu_feature_enabled(X86_FEATURE_XENPV)) { > pr_err("%s selected but running as XenPV guest. Switching to AUTO select\n", > mitigation_options[i].option); > return SPECTRE_V2_CMD_AUTO; > diff --git a/arch/x86/kernel/cpu/hygon.c b/arch/x86/kernel/cpu/hygon.c > index 21fd425088fe..1c27645fd429 100644 > --- a/arch/x86/kernel/cpu/hygon.c > +++ b/arch/x86/kernel/cpu/hygon.c > @@ -339,7 +339,7 @@ static void init_hygon(struct cpuinfo_x86 *c) > set_cpu_cap(c, X86_FEATURE_ARAT); > > /* Hygon CPUs don't reset SS attributes on SYSRET, Xen does. */ > - if (!cpu_has(c, X86_FEATURE_XENPV)) > + if (!cpu_feature_enabled(X86_FEATURE_XENPV)) > set_cpu_bug(c, X86_BUG_SYSRET_SS_ATTRS); > > check_null_seg_clears_base(c); > diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c > index 6b3418bff326..e2f469175be8 100644 > --- a/arch/x86/kernel/process_64.c > +++ b/arch/x86/kernel/process_64.c > @@ -165,7 +165,7 @@ static noinstr unsigned long __rdgsbase_inactive(void) > > lockdep_assert_irqs_disabled(); > > - if (!static_cpu_has(X86_FEATURE_XENPV)) { > + if (!cpu_feature_enabled(X86_FEATURE_XENPV)) { > native_swapgs(); > gsbase = rdgsbase(); > native_swapgs(); > @@ -190,7 +190,7 @@ static noinstr void __wrgsbase_inactive(unsigned long gsbase) > { > lockdep_assert_irqs_disabled(); > > - if (!static_cpu_has(X86_FEATURE_XENPV)) { > + if (!cpu_feature_enabled(X86_FEATURE_XENPV)) { > native_swapgs(); > wrgsbase(gsbase); > native_swapgs(); > diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c > index 8617d1ed9d31..1b83377274b8 100644 > --- a/arch/x86/kernel/topology.c > +++ b/arch/x86/kernel/topology.c > @@ -106,7 +106,7 @@ int arch_register_cpu(int num) > * Xen PV guests don't support CPU0 hotplug at all. > */ > if (c->x86_vendor != X86_VENDOR_INTEL || > - boot_cpu_has(X86_FEATURE_XENPV)) > + cpu_feature_enabled(X86_FEATURE_XENPV)) > cpu0_hotpluggable = 0; > > /* > diff --git a/arch/x86/mm/cpu_entry_area.c b/arch/x86/mm/cpu_entry_area.c > index 6c2f1b76a0b6..c83799753d44 100644 > --- a/arch/x86/mm/cpu_entry_area.c > +++ b/arch/x86/mm/cpu_entry_area.c > @@ -147,7 +147,7 @@ static void __init setup_cpu_entry_area(unsigned int cpu) > * On Xen PV, the GDT must be read-only because the hypervisor > * requires it. > */ > - pgprot_t gdt_prot = boot_cpu_has(X86_FEATURE_XENPV) ? > + pgprot_t gdt_prot = cpu_feature_enabled(X86_FEATURE_XENPV) ? > PAGE_KERNEL_RO : PAGE_KERNEL; > pgprot_t tss_prot = PAGE_KERNEL; > #endif This is another case that can be removed because it's for 32-bit. -- Brian Gerst From xen-devel-bounces@lists.xenproject.org Thu Nov 03 13:25:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 13:25:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436588.690655 (Exim 4.92) (envelope-from ) id 1oqaDM-0007MY-W3; Thu, 03 Nov 2022 13:25:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436588.690655; Thu, 03 Nov 2022 13:25:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqaDM-0007MR-TJ; Thu, 03 Nov 2022 13:25:00 +0000 Received: by outflank-mailman (input) for mailman id 436588; Thu, 03 Nov 2022 13:24:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqaDL-0007ML-La for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 13:24:59 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e62dc2f1-5b7a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 14:24:52 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BD4EC1F8AC; Thu, 3 Nov 2022 13:24:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5330213480; Thu, 3 Nov 2022 13:24:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BRiJEinBY2PIWwAAMHmgww (envelope-from ); Thu, 03 Nov 2022 13:24:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e62dc2f1-5b7a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667481897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9QUBuAHAGVF7m7eXHendyTsjI0pf2J3nOGew5yAs+24=; b=esQdGQ0tva4WxTGogmfCC1IScUwpk1vEqHcXc5keyuCapEtn1EXqCwmkYMdUdot1N6qq25 S2NhndoR+fNVtIRdKegZjGz194e49WFuD5g7WzWFA/2hXL1gOboZdcXw/ox+NbBibcZvdt FZ0S1SeXeKqqhdi7Uxlxi/vbSqqLEBA= Message-ID: <55fd2726-b54a-73a7-49ec-e66e025699a7@suse.com> Date: Thu, 3 Nov 2022 14:24:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 4/4] x86: switch to cpu_feature_enabled() for X86_FEATURE_XENPV Content-Language: en-US To: Brian Gerst Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Pu Wen , Andy Lutomirski , Peter Zijlstra References: <20221103113636.25543-1-jgross@suse.com> <20221103113636.25543-5-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------VyAi3UNXOOv0ZoAGGUlMSoRG" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------VyAi3UNXOOv0ZoAGGUlMSoRG Content-Type: multipart/mixed; boundary="------------q41ebvyIk77bWh0cY3Pf4Dl3"; protected-headers="v1" From: Juergen Gross To: Brian Gerst Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Pu Wen , Andy Lutomirski , Peter Zijlstra Message-ID: <55fd2726-b54a-73a7-49ec-e66e025699a7@suse.com> Subject: Re: [PATCH 4/4] x86: switch to cpu_feature_enabled() for X86_FEATURE_XENPV References: <20221103113636.25543-1-jgross@suse.com> <20221103113636.25543-5-jgross@suse.com> In-Reply-To: --------------q41ebvyIk77bWh0cY3Pf4Dl3 Content-Type: multipart/mixed; boundary="------------F1B2CDT0BNIzH628RfrxfcCc" --------------F1B2CDT0BNIzH628RfrxfcCc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMTEuMjIgMTQ6MTksIEJyaWFuIEdlcnN0IHdyb3RlOg0KPiBPbiBUaHUsIE5vdiAz LCAyMDIyIGF0IDg6MzcgQU0gSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPiB3cm90 ZToNCj4+DQo+PiBDb252ZXJ0IHRoZSByZW1haW5pbmcgY2FzZXMgb2Ygc3RhdGljX2NwdV9o YXMoWDg2X0ZFQVRVUkVfWEVOUFYpIGFuZA0KPj4gYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJF X1hFTlBWKSB0byB1c2UgY3B1X2ZlYXR1cmVfZW5hYmxlZCgpLCBhbGxvd2luZw0KPj4gbW9y ZSBlZmZpY2llbnQgY29kZSBpbiBjYXNlIHRoZSBrZXJuZWwgaXMgY29uZmlndXJlZCB3aXRo b3V0DQo+PiBDT05GSUdfWEVOX1BWLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4g R3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+IC0tLQ0KPj4gICBhcmNoL3g4Ni9rZXJuZWwv Y3B1L2FtZC5jICAgIHwgMiArLQ0KPj4gICBhcmNoL3g4Ni9rZXJuZWwvY3B1L2J1Z3MuYyAg IHwgMiArLQ0KPj4gICBhcmNoL3g4Ni9rZXJuZWwvY3B1L2h5Z29uLmMgIHwgMiArLQ0KPj4g ICBhcmNoL3g4Ni9rZXJuZWwvcHJvY2Vzc182NC5jIHwgNCArKy0tDQo+PiAgIGFyY2gveDg2 L2tlcm5lbC90b3BvbG9neS5jICAgfCAyICstDQo+PiAgIGFyY2gveDg2L21tL2NwdV9lbnRy eV9hcmVhLmMgfCAyICstDQo+PiAgIDYgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCsp LCA3IGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni9rZXJuZWwv Y3B1L2FtZC5jIGIvYXJjaC94ODYva2VybmVsL2NwdS9hbWQuYw0KPj4gaW5kZXggODYwYjYw MjczZGYzLi42OTdmZTg4MWU5NjcgMTAwNjQ0DQo+PiAtLS0gYS9hcmNoL3g4Ni9rZXJuZWwv Y3B1L2FtZC5jDQo+PiArKysgYi9hcmNoL3g4Ni9rZXJuZWwvY3B1L2FtZC5jDQo+PiBAQCAt OTg1LDcgKzk4NSw3IEBAIHN0YXRpYyB2b2lkIGluaXRfYW1kKHN0cnVjdCBjcHVpbmZvX3g4 NiAqYykNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICBzZXRfY3B1X2NhcChjLCBYODZf RkVBVFVSRV8zRE5PV1BSRUZFVENIKTsNCj4+DQo+PiAgICAgICAgICAvKiBBTUQgQ1BVcyBk b24ndCByZXNldCBTUyBhdHRyaWJ1dGVzIG9uIFNZU1JFVCwgWGVuIGRvZXMuICovDQo+PiAt ICAgICAgIGlmICghY3B1X2hhcyhjLCBYODZfRkVBVFVSRV9YRU5QVikpDQo+PiArICAgICAg IGlmICghY3B1X2ZlYXR1cmVfZW5hYmxlZChYODZfRkVBVFVSRV9YRU5QVikpDQo+PiAgICAg ICAgICAgICAgICAgIHNldF9jcHVfYnVnKGMsIFg4Nl9CVUdfU1lTUkVUX1NTX0FUVFJTKTsN Cj4+DQo+PiAgICAgICAgICAvKg0KPj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L2tlcm5lbC9j cHUvYnVncy5jIGIvYXJjaC94ODYva2VybmVsL2NwdS9idWdzLmMNCj4+IGluZGV4IGRhN2Mz NjFmNDdlMC4uN2Y3OGUxNTI3YzVlIDEwMDY0NA0KPj4gLS0tIGEvYXJjaC94ODYva2VybmVs L2NwdS9idWdzLmMNCj4+ICsrKyBiL2FyY2gveDg2L2tlcm5lbC9jcHUvYnVncy5jDQo+PiBA QCAtMTMwMiw3ICsxMzAyLDcgQEAgc3RhdGljIGVudW0gc3BlY3RyZV92Ml9taXRpZ2F0aW9u X2NtZCBfX2luaXQgc3BlY3RyZV92Ml9wYXJzZV9jbWRsaW5lKHZvaWQpDQo+PiAgICAgICAg ICAgICAgICAgIHJldHVybiBTUEVDVFJFX1YyX0NNRF9BVVRPOw0KPj4gICAgICAgICAgfQ0K Pj4NCj4+IC0gICAgICAgaWYgKGNtZCA9PSBTUEVDVFJFX1YyX0NNRF9JQlJTICYmIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9YRU5QVikpIHsNCj4+ICsgICAgICAgaWYgKGNtZCA9PSBT UEVDVFJFX1YyX0NNRF9JQlJTICYmIGNwdV9mZWF0dXJlX2VuYWJsZWQoWDg2X0ZFQVRVUkVf WEVOUFYpKSB7DQo+PiAgICAgICAgICAgICAgICAgIHByX2VycigiJXMgc2VsZWN0ZWQgYnV0 IHJ1bm5pbmcgYXMgWGVuUFYgZ3Vlc3QuIFN3aXRjaGluZyB0byBBVVRPIHNlbGVjdFxuIiwN Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgIG1pdGlnYXRpb25fb3B0aW9uc1tpXS5vcHRp b24pOw0KPj4gICAgICAgICAgICAgICAgICByZXR1cm4gU1BFQ1RSRV9WMl9DTURfQVVUTzsN Cj4+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni9rZXJuZWwvY3B1L2h5Z29uLmMgYi9hcmNoL3g4 Ni9rZXJuZWwvY3B1L2h5Z29uLmMNCj4+IGluZGV4IDIxZmQ0MjUwODhmZS4uMWMyNzY0NWZk NDI5IDEwMDY0NA0KPj4gLS0tIGEvYXJjaC94ODYva2VybmVsL2NwdS9oeWdvbi5jDQo+PiAr KysgYi9hcmNoL3g4Ni9rZXJuZWwvY3B1L2h5Z29uLmMNCj4+IEBAIC0zMzksNyArMzM5LDcg QEAgc3RhdGljIHZvaWQgaW5pdF9oeWdvbihzdHJ1Y3QgY3B1aW5mb194ODYgKmMpDQo+PiAg ICAgICAgICBzZXRfY3B1X2NhcChjLCBYODZfRkVBVFVSRV9BUkFUKTsNCj4+DQo+PiAgICAg ICAgICAvKiBIeWdvbiBDUFVzIGRvbid0IHJlc2V0IFNTIGF0dHJpYnV0ZXMgb24gU1lTUkVU LCBYZW4gZG9lcy4gKi8NCj4+IC0gICAgICAgaWYgKCFjcHVfaGFzKGMsIFg4Nl9GRUFUVVJF X1hFTlBWKSkNCj4+ICsgICAgICAgaWYgKCFjcHVfZmVhdHVyZV9lbmFibGVkKFg4Nl9GRUFU VVJFX1hFTlBWKSkNCj4+ICAgICAgICAgICAgICAgICAgc2V0X2NwdV9idWcoYywgWDg2X0JV R19TWVNSRVRfU1NfQVRUUlMpOw0KPj4NCj4+ICAgICAgICAgIGNoZWNrX251bGxfc2VnX2Ns ZWFyc19iYXNlKGMpOw0KPj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L2tlcm5lbC9wcm9jZXNz XzY0LmMgYi9hcmNoL3g4Ni9rZXJuZWwvcHJvY2Vzc182NC5jDQo+PiBpbmRleCA2YjM0MThi ZmYzMjYuLmUyZjQ2OTE3NWJlOCAxMDA2NDQNCj4+IC0tLSBhL2FyY2gveDg2L2tlcm5lbC9w cm9jZXNzXzY0LmMNCj4+ICsrKyBiL2FyY2gveDg2L2tlcm5lbC9wcm9jZXNzXzY0LmMNCj4+ IEBAIC0xNjUsNyArMTY1LDcgQEAgc3RhdGljIG5vaW5zdHIgdW5zaWduZWQgbG9uZyBfX3Jk Z3NiYXNlX2luYWN0aXZlKHZvaWQpDQo+Pg0KPj4gICAgICAgICAgbG9ja2RlcF9hc3NlcnRf aXJxc19kaXNhYmxlZCgpOw0KPj4NCj4+IC0gICAgICAgaWYgKCFzdGF0aWNfY3B1X2hhcyhY ODZfRkVBVFVSRV9YRU5QVikpIHsNCj4+ICsgICAgICAgaWYgKCFjcHVfZmVhdHVyZV9lbmFi bGVkKFg4Nl9GRUFUVVJFX1hFTlBWKSkgew0KPj4gICAgICAgICAgICAgICAgICBuYXRpdmVf c3dhcGdzKCk7DQo+PiAgICAgICAgICAgICAgICAgIGdzYmFzZSA9IHJkZ3NiYXNlKCk7DQo+ PiAgICAgICAgICAgICAgICAgIG5hdGl2ZV9zd2FwZ3MoKTsNCj4+IEBAIC0xOTAsNyArMTkw LDcgQEAgc3RhdGljIG5vaW5zdHIgdm9pZCBfX3dyZ3NiYXNlX2luYWN0aXZlKHVuc2lnbmVk IGxvbmcgZ3NiYXNlKQ0KPj4gICB7DQo+PiAgICAgICAgICBsb2NrZGVwX2Fzc2VydF9pcnFz X2Rpc2FibGVkKCk7DQo+Pg0KPj4gLSAgICAgICBpZiAoIXN0YXRpY19jcHVfaGFzKFg4Nl9G RUFUVVJFX1hFTlBWKSkgew0KPj4gKyAgICAgICBpZiAoIWNwdV9mZWF0dXJlX2VuYWJsZWQo WDg2X0ZFQVRVUkVfWEVOUFYpKSB7DQo+PiAgICAgICAgICAgICAgICAgIG5hdGl2ZV9zd2Fw Z3MoKTsNCj4+ICAgICAgICAgICAgICAgICAgd3Jnc2Jhc2UoZ3NiYXNlKTsNCj4+ICAgICAg ICAgICAgICAgICAgbmF0aXZlX3N3YXBncygpOw0KPj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2 L2tlcm5lbC90b3BvbG9neS5jIGIvYXJjaC94ODYva2VybmVsL3RvcG9sb2d5LmMNCj4+IGlu ZGV4IDg2MTdkMWVkOWQzMS4uMWI4MzM3NzI3NGI4IDEwMDY0NA0KPj4gLS0tIGEvYXJjaC94 ODYva2VybmVsL3RvcG9sb2d5LmMNCj4+ICsrKyBiL2FyY2gveDg2L2tlcm5lbC90b3BvbG9n eS5jDQo+PiBAQCAtMTA2LDcgKzEwNiw3IEBAIGludCBhcmNoX3JlZ2lzdGVyX2NwdShpbnQg bnVtKQ0KPj4gICAgICAgICAgICogWGVuIFBWIGd1ZXN0cyBkb24ndCBzdXBwb3J0IENQVTAg aG90cGx1ZyBhdCBhbGwuDQo+PiAgICAgICAgICAgKi8NCj4+ICAgICAgICAgIGlmIChjLT54 ODZfdmVuZG9yICE9IFg4Nl9WRU5ET1JfSU5URUwgfHwNCj4+IC0gICAgICAgICAgIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9YRU5QVikpDQo+PiArICAgICAgICAgICBjcHVfZmVhdHVy ZV9lbmFibGVkKFg4Nl9GRUFUVVJFX1hFTlBWKSkNCj4+ICAgICAgICAgICAgICAgICAgY3B1 MF9ob3RwbHVnZ2FibGUgPSAwOw0KPj4NCj4+ICAgICAgICAgIC8qDQo+PiBkaWZmIC0tZ2l0 IGEvYXJjaC94ODYvbW0vY3B1X2VudHJ5X2FyZWEuYyBiL2FyY2gveDg2L21tL2NwdV9lbnRy eV9hcmVhLmMNCj4+IGluZGV4IDZjMmYxYjc2YTBiNi4uYzgzNzk5NzUzZDQ0IDEwMDY0NA0K Pj4gLS0tIGEvYXJjaC94ODYvbW0vY3B1X2VudHJ5X2FyZWEuYw0KPj4gKysrIGIvYXJjaC94 ODYvbW0vY3B1X2VudHJ5X2FyZWEuYw0KPj4gQEAgLTE0Nyw3ICsxNDcsNyBAQCBzdGF0aWMg dm9pZCBfX2luaXQgc2V0dXBfY3B1X2VudHJ5X2FyZWEodW5zaWduZWQgaW50IGNwdSkNCj4+ ICAgICAgICAgICAqIE9uIFhlbiBQViwgdGhlIEdEVCBtdXN0IGJlIHJlYWQtb25seSBiZWNh dXNlIHRoZSBoeXBlcnZpc29yDQo+PiAgICAgICAgICAgKiByZXF1aXJlcyBpdC4NCj4+ICAg ICAgICAgICAqLw0KPj4gLSAgICAgICBwZ3Byb3RfdCBnZHRfcHJvdCA9IGJvb3RfY3B1X2hh cyhYODZfRkVBVFVSRV9YRU5QVikgPw0KPj4gKyAgICAgICBwZ3Byb3RfdCBnZHRfcHJvdCA9 IGNwdV9mZWF0dXJlX2VuYWJsZWQoWDg2X0ZFQVRVUkVfWEVOUFYpID8NCj4+ICAgICAgICAg ICAgICAgICAgUEFHRV9LRVJORUxfUk8gOiBQQUdFX0tFUk5FTDsNCj4+ICAgICAgICAgIHBn cHJvdF90IHRzc19wcm90ID0gUEFHRV9LRVJORUw7DQo+PiAgICNlbmRpZg0KPiANCj4gVGhp cyBpcyBhbm90aGVyIGNhc2UgdGhhdCBjYW4gYmUgcmVtb3ZlZCBiZWNhdXNlIGl0J3MgZm9y IDMyLWJpdC4NCg0KT2ggeWVzLCBpbmRlZWQuIFRoYW5rcyBmb3Igbm90aWNpbmcuDQoNCg0K SnVlcmdlbg0KDQo= --------------F1B2CDT0BNIzH628RfrxfcCc Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------F1B2CDT0BNIzH628RfrxfcCc-- --------------q41ebvyIk77bWh0cY3Pf4Dl3-- --------------VyAi3UNXOOv0ZoAGGUlMSoRG Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNjwSgFAwAAAAAACgkQsN6d1ii/Ey9S Qwf8DAg2WORBlH4UtVe5sxilRRF+JJ/5DXToY6JWvsLa+H0nNrvRdrkL1SN/J7UZdv98T1e9faOM pu4RYI3jzPItVJOD6/g9bjm3ip0a/iiWWbCCOPMJ7P88DBGgYL/+YlFTJTp2UkfeJ4UEYJcNGsEr MSOdgELW8YBEKtlETTKnfMW1MR5pC6ejzJMtdF6XJsiyPkUCXXCy6IipnXiS5VkFOzrcht1rQ6Er FB/7JBor8jG1npjSlnQhgEkdvglmZdv87bMeaPkvaWe/d2TajUqSrreJ1rmv0eqnIFRKhhXDzw6u 3Lg7Eiw0Tce4vvPk1bOLjPl/Yg095U76OJ2GSIShag== =bQOZ -----END PGP SIGNATURE----- --------------VyAi3UNXOOv0ZoAGGUlMSoRG-- From xen-devel-bounces@lists.xenproject.org Thu Nov 03 13:38:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 13:38:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436594.690665 (Exim 4.92) (envelope-from ) id 1oqaQB-0001TD-6N; Thu, 03 Nov 2022 13:38:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436594.690665; Thu, 03 Nov 2022 13:38:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqaQB-0001T6-3c; Thu, 03 Nov 2022 13:38:15 +0000 Received: by outflank-mailman (input) for mailman id 436594; Thu, 03 Nov 2022 13:38:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqaQ9-0001T0-9U for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 13:38:13 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2083.outbound.protection.outlook.com [40.107.247.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c26c30a3-5b7c-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 14:38:11 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7479.eurprd04.prod.outlook.com (2603:10a6:10:1ad::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Thu, 3 Nov 2022 13:38:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 13:38:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c26c30a3-5b7c-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5CDuMRI2Zvay+SEXuf7ZeO/4qtA/aYzAHJa7s3Ga7y3gKGKlaJsTtx0cpYmlG2xK4+eomzARik8xhUFSmYUbQu9JbFB7xb0pGH605o4P/KhjJkc3WZHcDknpImtKS+1HvlYHdBz7B7k48iwxqfFPyYg05q0ydt5GqTfBz9zMljZeRNMztu3Dkki+75VLKKdLQFWHpCiHUZVRrC6Qf5udFC4SwIspohjzZAt99fvPwX5357kpEFSWON3z0PQPkA4d38cA42ciA0bjuwfo0roOdx5MU8NqQR6Rs9vlFkaxV+pCvyMHfaSoidZ2ZtjYo9D3Nhp9mjnhjhxWRKTuPRGlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sfPlsqr5AtPpiPki5rWSbZySHT67nxhGfOGkd04WqFk=; b=fkdz+T9EuRKr/AK5bVndZt72Ro7UkSA8R/LZAs781iNVFc9DHQi19i9kV7LZ3Zcz0zVn9luNx/j/8buzVrPwGDAfmBbdLmSf8rMXQzG1X1IlnHd03R+zLMYNl53JRx6f331N9d+0lFxZoZgTzBJH0EbxgF7pHqbUm/Nb9LVPTQ7g1Cg+Vf4ytl1mR/0JnpVATyOq2Y6m36Yh6dgz2WAWfx0qYSUpv4m66VfGZ01QTdE0GDHrRPzHCzoIAWtfby7rlfJtx5STGRIY1OFCBm6LoQXoa6vlHgyTrHXKWBO+SQz9EPLs9fojYSa+N4KFEgmGjMD0ptH8gMylsvTdWaysvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sfPlsqr5AtPpiPki5rWSbZySHT67nxhGfOGkd04WqFk=; b=YxmTjKj0GifexNdvth5/hVc9kQ0sQ52Fpa8oUFEPNhb4TSvLIAfkXJR0Ncu02UcIsgm8Rrmbb0d4Z8l6YILcaEU6LBHJLTQs9v4MUtUWqE8LmlpTb0cPkb8VHrl8yKKFOLgoh+e3DG3RDfjbAHez3CkY+pM5VHqByum0ESmFuRbrKyKTV08tMVviN1fvMRDMz0/GioiIFO5J4jJwcUIRnh1qddeR38EjNwVkkqGTyrvdA6fEj2IDDEyg99VqFrXz1M0es62qJw8WEuhiIyhBWZkrGxWtinUavxDg34hEdd0yNrb0qvAvD6EEcNmKBc8sLcSXb3hZH5dhN6o14Ept9g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1918c63f-0065-b468-3691-de6e314f4374@suse.com> Date: Thu, 3 Nov 2022 14:38:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v4] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Content-Language: en-US To: Jane Malalane Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , xen-devel@lists.xenproject.org, LKML References: <20220729070416.23306-1-jane.malalane@citrix.com> From: Jan Beulich In-Reply-To: <20220729070416.23306-1-jane.malalane@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7479:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f438a99-6dc3-4ffc-0b4a-08dabda0a575 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 855uxulNX1IZZ3wIgTEhzQlEI/4NZgxFvpF23Ns0Vs7i4dYGSp8v+NsSpKTanR05u5oq5k2Qt0MYPhJhd+H2b2FyEhr8m8npC5eC/UxpV714cz6txvra2hHJdieb+fT4v8Dd+kFqNi5A6DyH5XsLhcZVGm5KA5ZozhJz25iUaosMh6l62sRLBdtWBZrAC3G3/WGYhYpMQKhopbVSMrZD8doWWNaWUbTVwztQ0d4whkzLYDxcSLM+UY8Jqwx1IWwxSnMXBBcfbYOkX56lz3sAwF4Uyms1chWNgmgM6A9wChDpK2uK2ItL3lc0pQ8//EoWHmAmlitqvWZb4zwTW8GpF0Hk+Tvg31oBT1goQ8GgKG1HH/9MRxtGWGrMqEgc1iG9t5cIPFWVHfOohpvtQRMLr421WNcf23ocifyeV/sfcNO2DE5mZP1+pa+lysaFkHDxD0coSR4YAwLcszfBB9QyFh1bKqrZd0R3PvHB17tCRvSkvc89slGE6lZ9gF03buHyybkbQPP2Tem2n38j4qb3H6ZiyDAqaS242QidvQTJ3Yl+r+M7IObbDwGB7dhtET1cPwzSknUT5KjMlSkps+Z4Ud95mYU0N5gU4sw4Wm858fJC5fZxfRUZWqlEXiOeo79fW+PXf1CC/T1Si98QaSJ3+nNWLgY4Gzo5AqwYpnTFA6PUJixjZY4qCMwWBs+hYrpeqAeAzYfIR6hA1RiVTFQYkS91ZPX3pKhJMXdDbrGa5BKEnoLpGEtn18GWjHVro5sp86T2L6RdW3IYAn7dkxpI1Zinpuv2aCS8/5NU23M3ukc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(366004)(396003)(136003)(39860400002)(451199015)(478600001)(66899015)(6486002)(6506007)(2616005)(66476007)(2906002)(66556008)(66946007)(53546011)(7416002)(41300700001)(5660300002)(26005)(4326008)(8676002)(6512007)(8936002)(186003)(31696002)(83380400001)(38100700002)(54906003)(316002)(86362001)(31686004)(6916009)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWpDMFptaHF1d1pxOWRYeVQ1Sk5uNk9rSGRDZU5iM1oxMDdya0tXMkpBa204?= =?utf-8?B?Skg0QS9NUlZ3eUZqVUhVRWRTRUoxa0hZMzRneGpkOFhpVEhrVWpRUlNZWHhZ?= =?utf-8?B?eFg1SDQ3T2p6ZTNGZ0RnVkdzUlBReXh2VFQrWk5uTGtaVGhPQUVSN0tYOWdv?= =?utf-8?B?NGJGUWsyVzRTY1NhdVlUNCttb3BKREdyQk5XblJyZXYxVUdidFhrUG12cUsr?= =?utf-8?B?MS9wNXd2V1JQSVVDRkxhT0c3ZTdHYy9MYzlFU3VPZkVGaXhsdEpmRWI0SHN3?= =?utf-8?B?ZTFSUXkrdE1YSm1VUVNsNHRDZk9vbERFdlNzRmFqNWNFci93UmxncmNVYUhZ?= =?utf-8?B?VVVQdWZvdm1aMUlNSDlBVzNxaTZPalNZVFpwcXpEUGNzclBxdHZGR2VjeC9E?= =?utf-8?B?a1hpaGlmMlFOcTdQam8zay80Q1RnS2g4VkVIVk9TZVBGTjBEM2d0M2J2RkUw?= =?utf-8?B?UDNXNVcwZUplZWRTbi9VNEJNem00TjBzbFF2QmpkV3dnM1NadndlQlZwa1Vw?= =?utf-8?B?NU1VWkFnK3JBdXh6bmhpU3Z3UXBwbi9JVk1EelI1UEdZeWRldVRWcUlCRzU5?= =?utf-8?B?Y2JIL2hqYnFBRXlzTVBUSHUwNzczZjJONHdVOXNWZ3J2UzdZTUNCL1Jpc3lZ?= =?utf-8?B?bTJKRjViMThmNlA0NU5VSU8wMHVqOUUzSlcva3dBdk9TWjg1cGtPc1ZXQmVU?= =?utf-8?B?My9MNGVBKzIrSTg5dkxtZDY0clR2M0FBSDBnNWYwaVlCY0k1dWF1SXFybFY4?= =?utf-8?B?WGxva3B1Rmk2UVR6OURPekpvWS9jNGk0dEdYUTRRcEgzNnJHd1BlNVoycUhz?= =?utf-8?B?S2ZsSnNwY1FNRm1FdEkzZS9PaXpsVHhMYWhFbDk2YVVXUGVVRHU5eEZoWVJs?= =?utf-8?B?MlExc3Z1SmNYV3RWNi9SeHpDN0ZDU2lvZDRNQVhMclVnMllHRnZsNkhaRHFS?= =?utf-8?B?dGNyOG1IblFicXI1b25DVHFldFROd0VXYzdQc3J4dER6dDNRUWt4ai9rM21x?= =?utf-8?B?N3pjOTVRcC9hU3BOWnlSRkYxdkg5YmRZYUZtZEgwVnpmMGhQMGMwa3N5aDVn?= =?utf-8?B?eVVBR0RnUm8xV3ZFU0pmZnQ1blArNnNGYTY0L3V0TTVBczlxMGFtME53Qi9C?= =?utf-8?B?aDdUYTliU1p2VksxSWFjZGZlY0dKSC82Z2VCU3pxK3dBNWtlR0hkdHUzcE1j?= =?utf-8?B?azMvSHhLVFUxSldod0MwdzFwQmhDekQrQWRPZ1RHblJvWmVucXBXZ1c1eGE4?= =?utf-8?B?RXgraytpS1RORktxdTVQa255eUhUd3hhYkgvNStocUl6UytmSHYyS1lNVjFI?= =?utf-8?B?SFRRM01hczJjRWtrM0RzdVpGQWI0S29abVVTRXN4UXhrdytlWHVYSGdUY1p6?= =?utf-8?B?dGE4bXByMEZraCtKcDE1bHhuOVl3TVU5cUtRSXJ2Z2JTTFR3V1FpenFuMU1S?= =?utf-8?B?NWdaSk9pWWxPempOYjFaTHF1TEt1SVFVWno0U0pDT0VmaEp0dlVyZWJnMGtt?= =?utf-8?B?US9hVlVTb2RLV1VKOVNLemk4V2VFZ3Q2Z2MrbWlSbVNTMWk4Znp3Rk9Kbmhj?= =?utf-8?B?Y0ZyaGJiRFFBd21uUkRJR2RKbjRqYnVvYUMwZWx6K2ptYklVcmVGQncycXU0?= =?utf-8?B?UXlqRW1Ea3hQLytKcHRxVjVwU0xOYUQrTytFR28wNEkvclk3TUtnRXRZODlM?= =?utf-8?B?MlVobkQ3d3c4MTk5WDR0OUI3eVB6Ukg3NndZRGRBenY4SFQva2RxMFNRRjFM?= =?utf-8?B?WHNrSjNMSjhaZk9OVVd1S3FKcTFLUlBmWHNFUFpta2liZm1UZndiWHlCTElJ?= =?utf-8?B?LzczYS90MGxBcWtxU3NBQWdvQnF3aU1UVG9Oc1hkcW5TZlhHN3JLYnI1SDE3?= =?utf-8?B?NXFwalFPVWhpbXpxQ0F1d2E0NmdnTWpSeGhGYU1kdG1Xc3dDbjExb1hrdDhT?= =?utf-8?B?MjZnajFIQXpxckRsb3RTeVN3RitONGREY0p5a1pVZnNGMkFCdjlSRUF3N2xS?= =?utf-8?B?cE5zN2h2T25abFE1VGVkUmRkSlhxRkhQTnJGUFpxQTVSUXArY20vN1k2eW1P?= =?utf-8?B?ajljL1lHckNkRXM4UnR5TnMzL0d4NThUVnA2Tk45a282YnNzZFFPYnB5ak5p?= =?utf-8?Q?TxemHabsi/L4YNT6uNIqwJYtO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f438a99-6dc3-4ffc-0b4a-08dabda0a575 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 13:38:09.5924 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GS5b3e/8f3kjUo6tQodGbGEJk4Czbt+2SmMhDGtCUfWa5jyosncZBNLSScEE8eMOAAchCvnsct3gu4iSMPv+kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7479 On 29.07.2022 09:04, Jane Malalane wrote: > @@ -125,6 +130,9 @@ DEFINE_IDTENTRY_SYSVEC(sysvec_xen_hvm_callback) > { > struct pt_regs *old_regs = set_irq_regs(regs); > > + if (xen_percpu_upcall) > + ack_APIC_irq(); > + > inc_irq_stat(irq_hv_callback_count); > > xen_hvm_evtchn_do_upcall(); > @@ -168,6 +176,15 @@ static int xen_cpu_up_prepare_hvm(unsigned int cpu) > if (!xen_have_vector_callback) > return 0; > > + if (xen_percpu_upcall) { > + rc = xen_set_upcall_vector(cpu); >From all I can tell at least for APs this happens before setup_local_apic(). With there being APIC interaction in this operation mode, as seen e.g. in the earlier hunk above, I think this is logically wrong. And it leads to apic_pending_intr_clear() issuing its warning: The vector registration, as an intentional side effect, marks the vector as pending. Unless IRQs were enabled at any point between the registration and the check, there's simply no way for the corresponding IRR bit to be dealt with (by propagating to ISR when the interrupt is delivered, and then being cleared from ISR by EOI). As a note to x86 maintainers: This comment there /* * If the ISR map is not empty. ACK the APIC and run another round * to verify whether a pending IRR has been unblocked and turned * into a ISR. */ is pretty clearly wrong - with IRQs disabled there's no way for a pending IRR bit to be "unblocked and turned into a ISR" one. And even if IRQs were enabled TPR would still prevent the handling of any bits potentially set in the 16....31 range. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 03 13:48:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 13:48:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436600.690677 (Exim 4.92) (envelope-from ) id 1oqaaD-0003Wc-9A; Thu, 03 Nov 2022 13:48:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436600.690677; Thu, 03 Nov 2022 13:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqaaD-0003WV-6E; Thu, 03 Nov 2022 13:48:37 +0000 Received: by outflank-mailman (input) for mailman id 436600; Thu, 03 Nov 2022 13:48:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqaaC-0003WP-Ii for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 13:48:36 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80059.outbound.protection.outlook.com [40.107.8.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 32a90caa-5b7e-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 14:48:29 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB8058.eurprd04.prod.outlook.com (2603:10a6:10:1e7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 13:48:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 13:48:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32a90caa-5b7e-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JmLPJJ/eSqTPv49t9fn5VPe5PPKdQmKeHK9xFpG6AxswgTIGG343V27oYcvrbTIDzFKDN65kKTtstkDrkXqu0lko3nTqeQuUU+N4EMXSvEoyBuCL6Vlua7eEzjQx8JKqTwBrFLCbEAfWfWIbdl9EB2Aca6OF+GJ97eweEI2F1IFbvYXyoWjTMzNIy6q3Z9foYmja2hWscla4Ab25rm/sH2PQWtER7f0g+g8tYrvs1/aJfC6rHWA2UEKuV3DXLGJpuEMTw8dNVgXga8kHkc8GIxoRB45bRZ7TPItR0O9nmDDl0BbLdQCpsEIT44VwykYFCQ+BbX7Qtg5df1tcThJbBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oe54xzSNXVksQiYOAH50cmCOIBeSDqgVz6CHue0NchU=; b=Es8hYcVkSxNkwq1nEhf5E2VoMcKmVfzRuLxxGoCxCj7JuVX4NJ+Y/qoPSioS4/1A7h1X77gbQ5rOEkSySBXUWqSgrwielNc4oMw8JwLTK9T/SbNT8mUh6tfZeuj9wv0wv3HbkegGqsbBPMWPNuIjvfmji6YTUZECqq7T+jO2N2ms2fxc7unIRkC4A04/PP2NO1g8BslimT+q1An3ySkM+mzap84vTaf82vR4ft1Iuru5xMEYXNszaIlViDFjOLFrxtiKHiti9+1UM5eFWtH1YHn6qf+oNM5LOYq74wJRWGiMffq2BpbrLXj/vkeOj4UP2PF7ERoHndh/dLAHfqNMJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oe54xzSNXVksQiYOAH50cmCOIBeSDqgVz6CHue0NchU=; b=h0etp0p97ILY/vWaN/Wkx/tLVxNWG8DZBEgHUI1xqN/R/BrfNSyhNEbS0EwL5kVnMmJ+cqYinytdaNnshl+23hovAXV3DDHcgAzMVA7IDMSdlHKKYZERce84xEcLZA8jIM2ZJFl+2xzKhLFF+mrJlA+OH5/6fnePRdoQJtnphrOJHTZ15YeeZu5ooOVwxy+oDwLFto7gHhU2nGn8+xmciKu0KEF3LER0THV/tGpaP6OCb4+4Lm5r8ZNAjrsdLmCpib5brd4C6WiHyV6SoONXfsEolMnyltEmZbHK7QM55ZVub68tckhKnLhuBn8fTlUvaFIKjBGBwdeCoy9Fsvbpwg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <069b911a-bd38-ee07-e396-afbaf1838212@suse.com> Date: Thu, 3 Nov 2022 14:48:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: x86/HVM: Linux'es apic_pending_intr_clear() warns about stale IRR Content-Language: en-US To: Andrew Cooper Cc: Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <7d9022ce-4a46-e0cb-67c3-4124e1c0d2db@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0062.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB8058:EE_ X-MS-Office365-Filtering-Correlation-Id: 61d41f62-7e13-48b8-30b0-08dabda218ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y4wQVjC9iR993sjBpjLe337UaPFacqEdm/t2yy3/Y7PR13TMYUWIPSWk3jkd8/5cXvg0lAOfGU7DJUEGxXNFvzSHKqXTX2K8euy8m7qpRgdokH7l57zYMLDkRL55IvNSWuteMkmU3zSUkdr674vipQoCGH0ks4GMhpDVMfmxNexYksm6lKCSzFBXYV16KRo0tybAABOUOzcLp6oCTcsAsmYwY2WyOTV7bB9hmkbDc632dwu15SQxdYuTN6aQXTB+Kw5wjcKXciBnKeEg8J514v7qbDlYS44A5JU1MZVqTs6Cu7WJwyUjdZm6TR2w5kUoyUyb09wfLqemklJNdwqHRwKhf7fKNuLpA8M1RBHHkZAsIdElT698EE78ZzcYiLCGXCyq4cOL+2hL2+wa9DEAkj/TWbWbq6c/1DTt8kzlYDs/W4geFgFjLvui8+iW9TvQ0zH99QHLWjiSKJcbrzJ8P9fPmsAdA2plM8wrBh1/sW7yqK5fDZLREL6fG++MXNR5re3Q88lXfvrmqIlTxHj8R2PUgFC6DRFilpBQHCf53l3eyKmbGUpKzJXaxoEjh1S1Ee9l2PgVRRa0d6+P1vpp3aR/gjojvCFiOoNq9wZjTof6UQ1QnwD82Eng+ZbnoTidjOipnULWmpOlCSybP4vqMIn59xxNNul4eJtRw7wOFtHtKHoOuec3xwF+HCFbqxDvRUxrLcd1OLpLx3ILjW4NlMdD8aySP7+Zua39i7NUgTOm7hiHPUPTPkv9QEK3TjnUSnaZhVi9/RjzuI4OYQbG5fRDwiW8WJPEwzlUTO5s5EeW7gfwgZgaqdW5ojt4n/DLjKeF/JbqdQCuFd0xu21Gww== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(396003)(366004)(346002)(451199015)(6512007)(26005)(4744005)(5660300002)(2616005)(41300700001)(8936002)(478600001)(966005)(186003)(6486002)(31686004)(36756003)(86362001)(83380400001)(66476007)(66556008)(66946007)(8676002)(31696002)(4326008)(53546011)(38100700002)(2906002)(6506007)(6916009)(316002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?andRem9BdmR2VEV0V1dvanBVajlieUNvY0twUXZRcXFlSVZTOHZXWUEzeDV1?= =?utf-8?B?TXJDdHk3TkFoNmZRa2JzRFh2Z0ZVOE5NRG4yOWxtbHVMeUVhQW4zVktueGxz?= =?utf-8?B?ZlJOUTZRSWdGU1RGSkFaS1ZjL3N4czhBZHJrVHpkc1BFVEJXblZUZHdGcE1v?= =?utf-8?B?ZHJZRjhEQ2pTTVg3bWtoWE14MHZIYlBHeHV3cnZmR3RDVlRIY3lrVEZKMFJz?= =?utf-8?B?eHB3NkVGVUwwaUk0aHdCTHA4a0xCckRieVJuREhYOVhvZTdRZDRsSTJvRVhk?= =?utf-8?B?YUVHaVlVZ0dMSFQ0ejIySEVMbjIzT0ZZakFYNDhLa2pHSmVVb3BjZzJPenZP?= =?utf-8?B?UW1nUHRpSkhoekRlNE1ZMStrS00rV0k4cEVHZ0xuOS96RzBXc3hGbzVPcC9x?= =?utf-8?B?MnB6dmV5RDMvOXFSbi9YblB6Zm5YVXY2UklKNzE2ZGxGcWVQZ05DOWFSUWRi?= =?utf-8?B?VEVMWG80R0RkcnFHVWdFS1FQZHFZdVliOEhwbk5nQ0MzQTJHZGVkT3BGdFVx?= =?utf-8?B?UVhzbXlTQ2JNS200aTdoQnpuYkpDczBBVFFrZnZCVXZuUHM3eE03aGkraGxZ?= =?utf-8?B?OTBtenZrTjRGQUlLUnhTWnJ5dTNCMUJ6TnFsWGVFYVhhYnY5Zk4yNDgyazBH?= =?utf-8?B?Q1hEN2xVZ3dyeUxOREI0cXowUnRXS3FUTm4vaXdFYm84b3F0ei94OE5zcVl6?= =?utf-8?B?QzI3eXFMbklKMVRzQ0M4eUpvVHhUSUxac1F2cS9lVllMTThaR1Vib2ZMSXVn?= =?utf-8?B?a2lkcWdKUHVzc1RoYUc0THIyT2JUQUJzN0RKUGlyanBZbUQrSlRPUndVM2FE?= =?utf-8?B?RytqMkdHSnprTmlMTHlRbWdmLzNKQ0MzajBQRWZabU42dnB4YmJKWEs2ZXlK?= =?utf-8?B?UnE2V1VOODd2d1hJNUtuN203aXRPWGhQazNHbjZFTmdMUEkxZnpMU0pXMW1I?= =?utf-8?B?Um4xQTJGeEp3MUZGZXJQRXg0c05TZGo5SlV3MEszbWdWck82TjdRY0IzLzNw?= =?utf-8?B?a3ZEeHRyTmxwNG5zS1kzUVVsQjNaT2xXMVo0ZnRkZjRGS1Q0VFdGbndTUnFh?= =?utf-8?B?VGhHZ3k2UFlTclQ0ZDgyRlFnZlBUQXhKMFoyU1FhL0MreStibnVHcHpObDNS?= =?utf-8?B?WXJIWW42UHRMYzI2VGpVZFRsdGl3QWw0enpobmVObDFVTVh6NkkxZ2lRcWVG?= =?utf-8?B?aWhnYUc1Mk9NU3k4ckk2cGh2aUt0MDRjbWg4a29zRGUwckxlRGZFN2RmeUl1?= =?utf-8?B?d3l6YmNoclYycittQTJzM3puem9EV0dsUngwQWNSNkxMSE81OSs0QzUrYVF6?= =?utf-8?B?MEFGRi9aSDdXTUFtOFUrT29RNngxOWZXVHdEM2lvSGo3M01PdkYyN2lQUmds?= =?utf-8?B?NVp0NDdpOFlKLytUK2V4a0FtdFNjbHBiaVhsUnFRRTVpR2ZwUFFNeStxdnFD?= =?utf-8?B?dHRjaVBpMXpLRGRld285eCtjcllWbXRBT1RmWFFDeWpXT05OZmliTktLMjVz?= =?utf-8?B?VHdWa1U2L2RMSGhJYmV2YkZiNGU3eng4SW9TZEVYVG53SFZiQWRHVGdROElu?= =?utf-8?B?bFlZV2tDbzJvYUZDL2F2OUF6ZklHY1V1a1JLTmo4R1hBODB5UkNtNkdOQ3Z5?= =?utf-8?B?T2N4TlE0b284SUs4QXVTWWloQWxGM3M2ZHMxaWloN0RKamFUL1dYQ3JBOXFT?= =?utf-8?B?MjdmUG9jbm15RHh5enZ3STFHK0FYWDExTUFFMWFVeGJOeis1N1hTNm5MUm01?= =?utf-8?B?NDcxNlhsNDc1bzZFOWpZdDViVW9jK2ZmU291ZlVWM1pza1JTR1psK1dVS2J5?= =?utf-8?B?b3M2cW81SCsyUVJ6Rm9DZ0FNZi90bXVZWWdkNytXd2gyb0REdUhrK0hoYnVw?= =?utf-8?B?VEZqTlFlYU0wVU4zeWtIWGNOT3pCbnB0UGY5OWU4TU5UZ3lhWUFMREs5V3Jq?= =?utf-8?B?a0gySVI5ZEJRdFk1OGpoaXAzQlN5VWNwMHk4NEpOdEZXNGJOYVFRL0xySVRw?= =?utf-8?B?ZzdZQnJJTEdkWFYwQ2hxUmFWOFBFbnIrb1kzUEl4VExKc2pYaFNjRkpNQkZN?= =?utf-8?B?d2VULzFjdEZYODBsSGs4TktRY0c3OE1TSHBIVGsxZS9VZFVWMUNRRjZxK1Bl?= =?utf-8?Q?KURyAO4I8HVqnyH673RYxHS7g?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61d41f62-7e13-48b8-30b0-08dabda218ca X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 13:48:32.5695 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bBzZ1DegANM4IJ/Vblue89/HYXWsWBE3cV/5PbqTXaSy6sCvz9H3IzTPj43WLmpJhL8OidgU9a7qo+bT+zMa7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8058 On 31.10.2022 19:37, Andrew Cooper wrote: > On 31/10/2022 15:55, Jan Beulich wrote: >> Of course I'm yet to figure out how IRR bit 0x13 ends up being set in >> the first place. > > 0x13 is a legal vector for incoming interrupts (for reasons of Windows > using 0x1f for self-IPI.) I was wrong here, mislead by the way Linux logs the IRR and ISR: About any other separator than comma (and perhaps a blank) would likely have made me check the order of elements. With commas it was pretty natural to assume the logged items are in array element order. Turns out they are not, so the bit in question corresponds to vector 0xf3. Which then pretty cleanly connects to a new feature in 6.0 - see https://lists.xen.org/archives/html/xen-devel/2022-11/msg00199.html. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 03 14:05:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 14:05:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436605.690687 (Exim 4.92) (envelope-from ) id 1oqaqM-0006ST-Nw; Thu, 03 Nov 2022 14:05:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436605.690687; Thu, 03 Nov 2022 14:05:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqaqM-0006SM-K8; Thu, 03 Nov 2022 14:05:18 +0000 Received: by outflank-mailman (input) for mailman id 436605; Thu, 03 Nov 2022 14:05:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqaqL-0006SE-PR for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 14:05:17 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2047.outbound.protection.outlook.com [40.107.21.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8ae78492-5b80-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 15:05:16 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9571.eurprd04.prod.outlook.com (2603:10a6:102:24e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov 2022 14:05:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 14:05:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ae78492-5b80-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dH/vPbu8IVqZ4zCBGdazgriZRhb1P2BO4wissWKSghj7NAgzN9LcZ2AJY/Ak+pnBahUFYHA5sw9kBdZx/lkf2QNX0tb9T7KuzbXIyIMfGEYY9yx2duhW4wGqqhB5A/Y23hwmnV8i1HZpiYWip5KTUCpVb3xkO+uw1wdtLGoij/nPj5Trr3/B6KnzKRTqJj/oeuF+fI4eP7XeLIFWBUaXQ/dkCxDE1kdt1podPjc2uFBDobteviQj2gFOLbUX6qYglztpjafGWSpCz1vpUrADpan9bm+ifTEnydK38r93zKk8g/GpziO+1esyjJWeC2GzY6+D3F5xzpzVtuSPyeX52Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VMyWF/gwKvnIWN63Enwct1+di2aHXK1Zxpo0YArVQjA=; b=U0w0lBZM+iESlLAAoJpeYEdhj/yDz8inDOqZWJR99tYrCtG1FWeZm6rCAjlPis+/Wg7ChzxBEPUSK1FYJWJbTD68wfzyHwNoHjtHLCTK0r5GpeSREg1aGOCstqRgg0DMiDAo2FdMrxVGxWAb1LYb0mg8mR5rExiSsvZtJgZHOLAb82vEqdORmoJLWAH446xs2loMqy4kUbIKTWQAZnkqdGwYD0JiAARjI6dnzkMkNT2Ljwb7kXoITDrDObHRCiOrrfweY34pb5+T2KnLFEABotYbRznVY5zca2omSj8GaEkk+t+jbTg5bvTz4EqgtzajXyvu2JPXsBI3xd+NW0coKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VMyWF/gwKvnIWN63Enwct1+di2aHXK1Zxpo0YArVQjA=; b=q2OVZSsD7ZIMUl+RF2iCAW648L2eRWs0g5nxLuhbPgoovcCOHmnRQqOL9j7sYV7xB4EqYSJMkJeQEdJsT18ycMcChnY5HFuTymk2ICRYpapf5p0RHSHbMbsoGBqd22OFPb+/OLhoAzPAw8tDfWbmF7XOIFImqnitC/y3LBUvjOBKYeyZ1DGF/1tN3Js44TNqM9D4vdQ4ilhaO5xwaMJcwITQS24+YwzpO3aIC0XBVHBtiXvP6EGnTOKRnbg3RQMKDB6et+GB+q2W8E/zeD9wXky1klcBqkYx7h4J8Td8IduhsE4yzfQZ98ovueNwssWsQoHL20mV0e+q4I0Z8TsKIg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7c40eea6-f167-6196-ac35-4c0044bf2cff@suse.com> Date: Thu, 3 Nov 2022 15:05:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 v2.1 2/3] amd/virt_ssbd: set SSBD at vCPU context switch Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20221028114913.88921-3-roger.pau@citrix.com> <20221029131258.95811-1-roger.pau@citrix.com> <198d04be-e7f2-dc11-18b7-ef3352d07b80@suse.com> <20869a2c-224e-698a-b927-96d6ad752b9a@suse.com> <37c145b3-9667-200d-c13b-912f3d9b8a0f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0062.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9571:EE_ X-MS-Office365-Filtering-Correlation-Id: dec04ab4-1964-44e2-b0ad-08dabda46da7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tdIPT1DMb7N3kGa+HoELH/v7/6czAbC+Y9FKhCuOcOltTMPQ6AJg2EwEBjae4ttlGxtM7wAGdQ+XqVg4XpQfA1sryGcGHSXLYbi6FroXZoLssjr6mThrzdP6RQOuISgjNbVesoDERE4TWRgU2r+Kl4Sil5RLofox74dxPsbRhEBPDt0j2AKSOfOWIkuaVwXRwWLQphoKVJABL3K2EFBnBqsSYUhbNMtpaLDQt5KGSAfLTYN4EEZLI0yClBWKDQstbRGeA38sgikNJEwKhaoDLXsxsro6IQOpzFA8L4OQ7t7oTEcmIKIXOU5IArFzidw/NWwtJLw1FCgyb+cCACRSTaLy6Gq80iLeNWhQ1POAu7JVrufZmFvv0tatqH0KKMNDChxNuf/WJDBiNAKrv7EYI7ItERAOKouApgQMjUfQDvtaPsV9AcIGFTd+9rPtslXh+jORT2T0HiE1Ztldmq1h5Dq83Zm80xbWLk7iSMpOKTUTpGt6hOu/lCqPpy9Kr9fHEaPJ3flys4NMWLrIvg20Gf4Zb4p1zV5wbm+lALiNfLc7Sk0h1h7gLphBrCGEHcAyyAc813eREMcEEhRxp2kNljQpJ3EVDPU+Hi1rsWhsY/us1lrBYqBGt7GHzdOOSnWcjVggiaGyh8V3GZyrcOF0zpx0CwNWbILyNd6t4Hco0mZut7y1kw7gYObsgGhBZL/EuKmz9wDxh68dqud53Ju76ev6OeFAf/btndnq2p4YaY7j1TjRBXui3o54Wchh3xTAcH2V5sUW9fWJCBgnejga/muKz74M24x5ppq9RMevXD4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(366004)(136003)(39860400002)(396003)(451199015)(2906002)(66899015)(36756003)(5660300002)(38100700002)(8676002)(8936002)(66946007)(4326008)(66556008)(66476007)(54906003)(41300700001)(6486002)(6916009)(83380400001)(6506007)(86362001)(31696002)(31686004)(26005)(2616005)(53546011)(186003)(478600001)(6512007)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0MyM3g1ckhpenJ4MHlUN2dHTDc5aDk4TzBEOVlONWVqR0NtRlM1ejdid3pF?= =?utf-8?B?R1IyZ2M2RGxuSVlFT2JpQWVqRzMrYWFUcHhiQkRTZldSMHZrNzh2djNTNzlV?= =?utf-8?B?Y1lVVGE0aWF5TTRLUDBWSzRQaGRRSEc1cnpFWWhzY2ExQ2NwT1hQMlArai9O?= =?utf-8?B?aUFUVFNlaEQramVZeWV6MlpOK0dmNDBSd2NMNGdVSWxZMFl3MnJsbDZiUmEz?= =?utf-8?B?bTNpS09FR3grRXcwTE9UdkZLa1NHS1Z6VWJVQmJSSS91cmtvQi9LL1NwdW1G?= =?utf-8?B?c0FHMXo3RVpEazUwRTQxdXdMdkVONUpjOTZVQWlBUEFkOEpmL2lqQnJYNUYw?= =?utf-8?B?MUJ2eXhma1ZhbW12Vk84ODFXVXhKajZ3QVFBdzBEZVhsZ2dMOG0vQjBZSk1a?= =?utf-8?B?VUdnWi9Dem0vbC80ckMzMjY4bFBWbjIrRmR5c0NaaEhCblZnYnZwWVpTM3dl?= =?utf-8?B?bVczdzRJRG0ybXhORjZpQzk2djNVT1d4cURLZlZJbG50ZkJVUXEzMjFkem1a?= =?utf-8?B?TDRyeDJKMjUvWGVhYWpiMUdEa1d2ODNpUzlQV25acGVxZXg4MFBYd2F2Wlpv?= =?utf-8?B?a0R2OTFGT2tJenFXZ3lQL09FOGZXZGNybjRmc3NFREhxdm5waTIydXhkaFZi?= =?utf-8?B?c2pqSDRxLzlFdHRtNU92T3dpVS9oWmhDakg4UDRyRDVDdzdac3Aydkx2SVZZ?= =?utf-8?B?RytiY2xFUElkQklKSkFMa2J6d3ZnY0xJL1A2RE0vWE9pSzFBeHkyNDI0S003?= =?utf-8?B?Lzh0VFcyblJrSy9wRHMvTEovUUtkd3plNDRURGhEVGVQbk55SG5odG4ramtj?= =?utf-8?B?enVFeml4UnE2dTNucWFrRXFVUUhPVjZQZE04bzUvek9Eemtsby9sT2dxNlNV?= =?utf-8?B?Q1MzV3pNcFlMMFVRenpPY2VGN2dTdVNhMFlnRnJteXBCU1FtUkNxMjcxYlJB?= =?utf-8?B?SEhnc1BmNGdNV2h3bXFPWDcxVDFYZ3RNSVYwQkJGMnZRbndhTXF4dWNkS0FW?= =?utf-8?B?ZkNtZjhKb0huY0piUUxYUjFEZ2ptZU41cTJETWl0SStMd2ViMEhSanF6TjBO?= =?utf-8?B?TVg1WHNGL3pRd1Q1UlZjRk1nSDlEbEphVGdNZ25CVktOM3JlM0lZRjU5bDE4?= =?utf-8?B?VUlzODMyelR1ZkVWNUZuek5PRHhWSzVVRE51UXpEaTJ5RTV2UzVsVmJ0d1FD?= =?utf-8?B?dUhVY0c3ek1ONmw5UnA3cDJNNzRuVmRIVWNtdVBpRDZ0a3RPQTNiWnF5Sk15?= =?utf-8?B?Mkd0c2hVNTJLTWthQnZYazkzZkxRdkc4cXlUTXdJck9Vb3llQzBSeUxmeGtP?= =?utf-8?B?NTVsNWRBdzhWZWlCTFdDNGF1V3JIVWlDcHRLcTgwYjJsSVZZaStGVnVJck9I?= =?utf-8?B?MTZ4Y2N5dnlqQ0RFUjN4SFI2NjJLOUhvODl6NUJKSTdyVlFVeUpuT21qVE1t?= =?utf-8?B?UkFDN3FDSUU5NUQrN0FKSldVbHRqZlFhQnQvU1RpQ1BkVmhxSXVYZ2U1OUE0?= =?utf-8?B?UkdvaXdZb0xORjYrVEhUNGdCNWR1TXFjeU85YkhCdzlqNyt4akhTdDd6bnBO?= =?utf-8?B?QnRFbTQ0Zkl1TTU2eENWYmYrUFYxaW9XMmcrMDZGMkRqUHNaOTgvbFBsV1Qz?= =?utf-8?B?RjlYOEViL1QxUVFTcHNIWTlyYjdWRnp1cWJ4SkdrSXhBU0FvNjVValZ5MVBR?= =?utf-8?B?cUh0cWZEV3ZaRkJlSi85ekFSTW0vU0xsdmtNWTI5dXVNZ1FKeVdORklkdTlJ?= =?utf-8?B?cEZZeWNabVpCOUhWVXViRnRBbTcxWEtxbUtjMUdVOFVTeHhScDdVSHZRNnhT?= =?utf-8?B?Q1NKdzVMSlhneEVMa1ZFRk9WYmZGUDZ6QzQrcFlMRkNMU2JEQTNyaEhYbFRO?= =?utf-8?B?SjJtQWpwSCtidGRhcHFBVmdDYWNhVXRRNnRGK1RqVWZIaEE2bnlsaU43UENP?= =?utf-8?B?bVpNZVNPSFNYNnM3RXpPR0xieUtuRzMxT25YQmJ4UnhGSVBtVk9Fc1BoalVq?= =?utf-8?B?REV1dGhLSVBmMnJnQTBJVUxQMU9ZSk5PaWJIallWTTBaanRtQ2Z1VFpYMnlP?= =?utf-8?B?UThBY1VIa1RsZ1FPZ0tqUk52b1QrQXh5bGRFdVNaUWlQdVVGUUFZdUdFMEVa?= =?utf-8?Q?7us4n9jI0dgaQCXqKc5DNJvdt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dec04ab4-1964-44e2-b0ad-08dabda46da7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 14:05:13.9745 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f5sqALKJbj/YATPWDeDj5KbINWZdvU5VcYl/3e81bAipYP6Qvg3IjXQoKdON/F9TCeOpY0r3Z6T5kjjiC+//SA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9571 On 03.11.2022 11:36, Roger Pau Monné wrote: > On Thu, Nov 03, 2022 at 10:01:49AM +0100, Jan Beulich wrote: >> On 03.11.2022 09:52, Roger Pau Monné wrote: >>> On Thu, Nov 03, 2022 at 09:09:41AM +0100, Jan Beulich wrote: >>>> On 02.11.2022 18:38, Roger Pau Monné wrote: >>>>> On Wed, Nov 02, 2022 at 12:49:17PM +0100, Jan Beulich wrote: >>>>>> On 29.10.2022 15:12, Roger Pau Monne wrote: >>>>>>> --- a/xen/arch/x86/hvm/svm/svm.c >>>>>>> +++ b/xen/arch/x86/hvm/svm/svm.c >>>>>>> @@ -973,6 +973,16 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v) >>>>>>> >>>>>>> /* Resume use of ISTs now that the host TR is reinstated. */ >>>>>>> enable_each_ist(idt_tables[cpu]); >>>>>>> + >>>>>>> + /* >>>>>>> + * Clear previous guest selection of SSBD if set. Note that SPEC_CTRL.SSBD >>>>>>> + * is already cleared by svm_vmexit_spec_ctrl. >>>>>>> + */ >>>>>>> + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) >>>>>>> + { >>>>>>> + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); >>>>>>> + amd_set_ssbd(false); >>>>>>> + } >>>>>>> } >>>>>> >>>>>> Aren't you potentially turning off SSBD here just to ... >>>>>> >>>>>>> @@ -1000,6 +1010,13 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v) >>>>>>> >>>>>>> if ( cpu_has_msr_tsc_aux ) >>>>>>> wrmsr_tsc_aux(v->arch.msrs->tsc_aux); >>>>>>> + >>>>>>> + /* Load SSBD if set by the guest. */ >>>>>>> + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) >>>>>>> + { >>>>>>> + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); >>>>>>> + amd_set_ssbd(true); >>>>>>> + } >>>>>>> } >>>>>> >>>>>> ... turn it on here again? IOW wouldn't switching better be isolated to >>>>>> just svm_ctxt_switch_to(), doing nothing if already in the intended mode? >>>>> >>>>> What if we switch from a HVM vCPU into a PV one? AFAICT then >>>>> svm_ctxt_switch_to() won't get called and we would be running the PV >>>>> guest with the previous HVM domain SSBD selection. >>>> >>>> Would that be a problem? Or in other words: What is the intended behavior >>>> for PV? PV domains can control SSBD via SPEC_CTRL (only), so all we need >>>> to guarantee is that we respect their choice there. >>> >>> If the hardware only supports non-architectural way (LS_CFG) or >>> VIRT_SPEC_CTRL to set SSBD then PV guests won't be able to change the >>> setting inherited from a previously running HVM guest. IMO it's fine >>> to run Xen code with the guest selection of SSBD, but carrying such >>> selection (ie: SSBD set) across guest context switches will be a too >>> big penalty. >> >> Hmm, perhaps. Question then is whether to better turn it off from >> paravirt_ctxt_switch_to() (which would take care of the idle domain as >> well, if we want it off there rather than considering the idle domain >> as "Xen context"). Or, yet another option, don't use >> *_ctxt_switch_{from,to}() at all but invoke it directly from >> __context_switch(). > > I consider it fine to run the idle domain with the guest SSBD > selection, or else switching to/from the idle domain could cause > toggling of SSBD which is an unneeded penalty. > > If there's an specific issue that needs dealing with I'm happy to > adjust, otherwise I think the proposed approach is an acceptable > compromise to avoid excessive toggling of SSBD when not using > SPEC_CTRL. Well, perhaps. What I was suggesting would further limit the toggling, but I'm not going to insist on you going that route. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 03 14:16:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 14:16:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436610.690699 (Exim 4.92) (envelope-from ) id 1oqb0z-0000X3-N3; Thu, 03 Nov 2022 14:16:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436610.690699; Thu, 03 Nov 2022 14:16:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqb0z-0000Ww-KH; Thu, 03 Nov 2022 14:16:17 +0000 Received: by outflank-mailman (input) for mailman id 436610; Thu, 03 Nov 2022 14:16:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqb0x-0000Wq-TH for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 14:16:16 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 13003511-5b82-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 15:16:14 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B0AA321BF4; Thu, 3 Nov 2022 14:16:13 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 31ED313480; Thu, 3 Nov 2022 14:16:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id N6NiCizNY2OldwAAMHmgww (envelope-from ); Thu, 03 Nov 2022 14:16:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13003511-5b82-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667484973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qVMqUeoO0aO1L3cL/tTLn6wdbhcaYYtz8/othx0or1E=; b=vXCifq+gXnQnW4jR6gfL/MzD5WI/p4QA1EHSXA3YD2RFvZNiDpxtjhGBG1dvkh5lnQYnmN 8A6uBM3c9yhNuwR/m1IDXdNLTlDciqw1uhrdSS+0Q3Ep2wScshlJp/v9/oQNHPx9IfQSfM cti2u0XGItRSQpkKcrZrNko2lVvsdH8= Message-ID: Date: Thu, 3 Nov 2022 15:16:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [XEN PATCH for-4.17 v2 6/6] xen: Used SPDX identifier in public headers Content-Language: en-US To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Wei Liu , Stefano Stabellini , George Dunlap , Julien Grall , Jan Beulich , Henry Wang , Andrew Cooper , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Christopher Clark , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu References: <20221103115204.49610-1-anthony.perard@citrix.com> <20221103115204.49610-7-anthony.perard@citrix.com> From: Juergen Gross In-Reply-To: <20221103115204.49610-7-anthony.perard@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ZAPRD0AsbKChNB0IzGzY3x8A" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ZAPRD0AsbKChNB0IzGzY3x8A Content-Type: multipart/mixed; boundary="------------TdHR4i4pnmohCdpzFVMqbBjN"; protected-headers="v1" From: Juergen Gross To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Wei Liu , Stefano Stabellini , George Dunlap , Julien Grall , Jan Beulich , Henry Wang , Andrew Cooper , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Christopher Clark , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu Message-ID: Subject: Re: [XEN PATCH for-4.17 v2 6/6] xen: Used SPDX identifier in public headers References: <20221103115204.49610-1-anthony.perard@citrix.com> <20221103115204.49610-7-anthony.perard@citrix.com> In-Reply-To: <20221103115204.49610-7-anthony.perard@citrix.com> --------------TdHR4i4pnmohCdpzFVMqbBjN Content-Type: multipart/mixed; boundary="------------fbZdWjhw0HOGlLdixjkIB6kK" --------------fbZdWjhw0HOGlLdixjkIB6kK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMTEuMjIgMTI6NTIsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBUaGUgdGV4dCBv ZiB0aGUgbGljZW5jZSBoYXMgYmVlbiBjaGVjayB0byBiZSB0aGUgc2FtZSBhcyB0aGUgb25l IGF0DQo+IGh0dHBzOi8vc3BkeC5vcmcvbGljZW5zZXMvTUlULmh0bWwsIGV4Y2VwdCB3ZSBk b24ndCBoYXZlICIoaW5jbHVkaW5nDQo+IHRoZSBuZXh0IHBhcmFncmFwaCkiLg0KPiANCj4g TWVjYW5pY2FsIGNoYW5nZSBkb25lIHdpdGggYSBzY3JpcHQuDQo+IA0KPiBTaWduZWQtb2Zm LWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4NCg0KUmV2 aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2Vu DQoNCg== --------------fbZdWjhw0HOGlLdixjkIB6kK Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------fbZdWjhw0HOGlLdixjkIB6kK-- --------------TdHR4i4pnmohCdpzFVMqbBjN-- --------------ZAPRD0AsbKChNB0IzGzY3x8A Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNjzSsFAwAAAAAACgkQsN6d1ii/Ey9U Awf/c9+pMnPRpM7XSPT/JK5klc/Djn0XkF+oVOsVqdWiZcKlDLQRfrMOqANvpgN5r72VATAjMPFU 1qeZph+TPlO30oa1M3GLtPlAhsUNOWqDOssJ8XuhQ8PKqL9/e/CIX/JueHii1Y0Q1e0xXUFnNkxz jKrOPv6c5WFIdYG6qtdT0AKpv8ikEAm9AdtNbw4zEYglfRRkagjy2zH9/7sgmMLfvOKHGHykPYfH 5QPki+kKlrFGFRlqeC2yNoh0fgjvBTFiYMVbrK/mXPsJhNIVuNF2WOhbC/MQO+lAvpHcoB+o8Pqa YpZr02Zm7Z0aLjWxknCYIqnOEXegBjotwUy6S87Esw== =tGX/ -----END PGP SIGNATURE----- --------------ZAPRD0AsbKChNB0IzGzY3x8A-- From xen-devel-bounces@lists.xenproject.org Thu Nov 03 14:25:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 14:25:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436617.690710 (Exim 4.92) (envelope-from ) id 1oqbAD-0002MU-NT; Thu, 03 Nov 2022 14:25:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436617.690710; Thu, 03 Nov 2022 14:25:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbAD-0002MN-Kc; Thu, 03 Nov 2022 14:25:49 +0000 Received: by outflank-mailman (input) for mailman id 436617; Thu, 03 Nov 2022 14:25:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbAC-0002MH-Az for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 14:25:48 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80082.outbound.protection.outlook.com [40.107.8.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 68610276-5b83-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 15:25:47 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7488.eurprd04.prod.outlook.com (2603:10a6:800:1b0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 14:25:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 14:25:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68610276-5b83-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PV4gjTcQVIXgzPmFi5qenhpfJZMvk3iKPY61Ozm9fov+HZWqvv0BCkzXYRkF7OaEd2IbkJ5w04ASpSC2pZN4SpTVk3VOQHZR/0TX0V0CkxO0vpgVmRE8MHkVnN0X7GmEGGUtGsgEIhZbgHpR/9yvxuqEQjAtiIcT1hJXvnHEPElob/UIkJBcG71H+oJL8TdrdaydU/SqAIMBGy79IdgmxdNJz9LtwKQI2h7zVSo00hMoXRrnngarPJahSLuNiBw0LTfiVhO6eYwlByZVwPCKfGBnnalvCX0Wu3NGpTkmcjCmVZlpU+O4EP9HcK7UF33e2gvosVlcwnTLu9TmCxqRPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LpqAWvObSakRB8G6+YRWLr7Ct3e/WECL3xkc6vwkUfk=; b=Dn6ngWtC1iwZAVSKNpiGKqc+ldNMOR2ygvkrXzNb3A4xAHpVno71uoXfUiSL8OuxHXfYe/vCx7nePaa1+iV/DWh1N5WwE0DKnnOzHstbfRO+pwz55KBpcqsrJT6t5wS3JNhNssp/BXWkPTXcg3h3bWV7owTg9AFfVG9M6G7ufeGe8BVK+PZYrmZxkGD92qB6x28KgqH3GI0tfEa69BV2JRgZG2i5R6M01cM9L2KvlZN9EQB8J5H0bDdwSbZTtbPrLDrIKAsRq/hBGTUaMAq90j/GUlgmPd2vS4xoLzIbDi7I9M/9wcmhuKlMMVBV++nIwo8gO8hvrkoQtgWmmglaQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LpqAWvObSakRB8G6+YRWLr7Ct3e/WECL3xkc6vwkUfk=; b=AmEMa+jZs4fPuYp53KPEvPBYmA1H+r/e5YCCUbVzRuD7NUEOUPVwR/u/UYmmNsbgXmte7z5ZkXpdcnBtBkHz178s0IcWYULkZY2e4qbnS63x+0t7saqwRyc3XmY65FEuke16qUoGIriT+Pq6dVAgjYrqoJixoL2kVQjPIH2KNFnyOtYiDp8H7NfaYnIJtbzc1ingf2fsVmJ1XEtNoDEgvPQ2X32XRhrzRdKMGr3PhueeopBgv0Hsk70RudLIzuP1td5Lqb2cYCxoAFswXVpz1RYUYs82wo20BXYPOgeVbDxUVjLAELi6OdgC9P4WEPrltueml0snbQwwGu0NslBP/w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <78036eeb-2585-97e5-9f80-bb84f297cc08@suse.com> Date: Thu, 3 Nov 2022 15:25:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v7 2/6] xen/x86: move generically usable NUMA code from x86 to common Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20221020061445.288839-1-wei.chen@arm.com> <20221020061445.288839-3-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20221020061445.288839-3-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0114.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7488:EE_ X-MS-Office365-Filtering-Correlation-Id: 10033d96-0371-433a-5441-08dabda74bb4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1mtHkAyWMW8rwktGlE2vine26LlSUV+D36QJSRPltp0hNuCGBcwElq25ujs+Z9f06yWLLuabdFlykdIrfRtQD4CThWRKYftmPtl99dS9+3FpeSPlAUJb+dkrWser4fvQoVsF2Ty99Orw/nuIRkVCok7O726K57eJc9MYeFYv2MZovm4AaRByD3ns7XqEG4dnA/ZqQkjvySsbff3R2mrqx1SR8GGO6c7jFWvqwLN+j5+MX8rmiI+OsQQJOXEXYYPdYEGky0iWNyLADKPS4CDGVSqUdIt1fcIVXy7+pwjRpnVDA8f+tG0VE+rHkCP9FCLE2Kx73eirP5TAIBi0tTlryRBYyh7u4oIGwc2Chzdpvm1LCkQJ56auUFqOFtzGtgXWeyAQBNGrF4b33DErTEXSKQ6fVSmy0yMDvVdihpXrxlXrmWhLn+YQOdD/fuxoOh09/N+hd4QbayyRbj/edFNTWEFQrpi+7GaAzmIxhiBYoKsL7QTsuWWhH6mI2PiOkDZYYT60bqK0tTd9zeCpENFpr8RGRKrA3RS2s0GRj4BR81VV7vDKE3Pjy4O92a7kW6LKqohfQ25lyEVIR1i2OSYIlP94JxCDFkPNcswq65O9dltrefg7KLMy32o3H9Pw/TRSl1JwNYGx6jtMKeokz8DaWn1AsTAm6FAtMgdZ8eExoO3R8tAnPvDcQxmR/r7bLCdiTS6ryt9r34DhawvdTvG5QMOAZPQV5pHfHJN6ul/b8gClPOqtxobs35S3l14jwGytgRleX5d7vsKObN6u0YqJ70acXDGTFxCq7jKTCXM3f6Rt8LB1j0KqmjNyyAdJV320t5cs5BSmQ/b76GX2V1eaxg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(396003)(39860400002)(346002)(366004)(451199015)(316002)(54906003)(2616005)(53546011)(6916009)(26005)(6512007)(8676002)(6486002)(478600001)(66946007)(36756003)(8936002)(41300700001)(5660300002)(4326008)(66556008)(6506007)(66476007)(2906002)(31686004)(38100700002)(86362001)(31696002)(83380400001)(186003)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWRzL2FoVjZsL0xDZVk4UHc4ZmttL1JzZjU4TTJNQktmSUZwMXNjM3dtUWlO?= =?utf-8?B?aUhRSlJVc2d0dmJ5VTVsY05nZ0xrWEkxeHo3Uko3bWdhelZNSEx1dnFrL2JG?= =?utf-8?B?cHEyamJJSlJlTDBBNEZTZ0dlOENPT0o4ZDNNSjRuQmpkQTdtak9ZaVg5SlFa?= =?utf-8?B?WFhadlFnU1pwWXpXbTNkUkZUbzJ0bjc0NGlaL3FmRG1JRW9GckFvTmZnL3hk?= =?utf-8?B?RlpvK3Z3RjlHZjdmMU5EQnFqV3lQZ0tMUDg1V2NIK0dpdEVYRS9VRjBPWlhm?= =?utf-8?B?djNTclBXd0hlT01yS2FTbGFxSk1LSXdNL1lwYWlBTDRKLy9yK1ZDM0NxZW5v?= =?utf-8?B?WTN0Mi9yRHdrL24yUFV0MlM1Q2F6MkZQbjU2ZUYreU9FR2xpaVFTVXV5WDZp?= =?utf-8?B?dnV3UkNMcjlLNVVBdm9RQWlnRlBremtVYXNUbEVvQ2hrN0diQWZ2K0ZCeTMw?= =?utf-8?B?MjRNOEtQVlpNUTRtUGgxcWs3VGdGNGVpcTZhMlhYbHBlUSsvaWhOUisxZDk3?= =?utf-8?B?U0JqNFpxK0JTQXZ2QjQ5N0IyUTZCSHFlaTZ0cldibUE5Z1U1RFZ1cE5sTFoy?= =?utf-8?B?SnQrTHQ5N2ZxQ2NmL3V0WVVDY2ZkcTBiRXhNcmMzYnIzbVZQc3NWb09PdG00?= =?utf-8?B?UTlQQmVjSHZ3QTEyN0s4Y3pnNE1QRXZHWTZNa25aVDB6bE1tTXpHY2grQWQw?= =?utf-8?B?ZXpzbG9nY1FHU1ZaUisyZkE2M1ZsOUxYcTcva2R0UzhaMUh0MHVLekhicSs0?= =?utf-8?B?b3NJR1dOb0liOTFRcGhYQzZ1TkVsNk43ZEh3TnJSMy9qWGgrMGNnVzgzU3lS?= =?utf-8?B?ZDRDV01uWktMM2JPZFJMRnNyRllOdHpwTENNbE1TMzBrVVJvV0dkUkZCdXRq?= =?utf-8?B?L2pxUFJVQmI4VXkzN1VZeC9oemFrRDMwbStQdTVhUUk0RVU1VWF0aFhiWVVz?= =?utf-8?B?ZW0yRjNzUVNFbFBlM2I0UHdBZUswc3lVZ25YYy9HYW9BK09uVEl5RUdyeWRW?= =?utf-8?B?QlQ2UnBQc014ckVLN21ld3E1aUdBUWk3b04wL0tOeVFhejBHMFJUejkzaXNN?= =?utf-8?B?VUtucDR1VVhnQ2lveHA5NG1Ub0ZianNFc2xoV3dqS1JsVk1sdjZLamtDL3FZ?= =?utf-8?B?TTYwRDBLQnRIekN6OWlyc1RQYnRDVytSUm1oOFZ3YW9yWjZsZkNtQzMxOTRh?= =?utf-8?B?Zk1wcGRwbTRzc0VHVHNnbUtXY3paMEQvMEEzMEFROXFKZ2NqUmNXUWdlRTZH?= =?utf-8?B?dDlBWTBrbGg4czUrbzBkRmo5enJLcWRIaS9ROG8ybjR4NFpzS045Zm9hWFB2?= =?utf-8?B?dHhsUDJ6djR3K2dINDR5cEcwT2QzaW1ZQVlYNk9DZjVxa2I3OGtsRHNsbSs5?= =?utf-8?B?VkhzN3Q4dTA4bGgwTjNiN0tiQmFBbmdlVTFpREYvNU1IY25ndXAva05CM3VN?= =?utf-8?B?alVhc2NhYTBkbVJFQ1ROK1hqak1YRmVRcVRNMG01Z3ZkNWZJelVSTzl0Qkw2?= =?utf-8?B?RXdaUHhyZWZSZXNTS2tFQ3J4eXpWUmNoRitwNkZNNlF5d2Z1T2tVcFF6SHhl?= =?utf-8?B?ek50M2MwODg2YWNqVFc0SWladWlVQlE0WkxqU0JUcEZQaDJETTZPUW5hVFNN?= =?utf-8?B?SFlwcUZRQXJYZ1hGNENPVFcvQm95TWJGaEJ2a1UrUGZmUENJdlBsbnFkemNN?= =?utf-8?B?RGFiN3lKNW1wczkzRHdxbGVvMFg3V0ZoV2J1djhLcFdGS0dXUmlJWEZiWFho?= =?utf-8?B?NkNTcHVuNXlUOXlYZlVKV1FCN2pYakp2ZlI5aGQ4S0tURSt3MnV6U29LVGJI?= =?utf-8?B?cTA3eEJhWHdSbWFLSzJkRHZsMC9hblJxS0FHTmZVMDBLUzI1RVNWcHUrTVRD?= =?utf-8?B?RlhpNTBhbU5EMUt4TkQvdklENlY2Mm0zeDI0dkJvRVYvQitXRWpobCtBeU9S?= =?utf-8?B?Q2s3MzdpaTZlSmNNNEVRdXo1U0V5UXRRWXkvZm5TWkVPV01kdkhNT3QvQ1NK?= =?utf-8?B?MkIyN1J2akdhRzh5NHBEQWM3dlpvMzlrWUZhKzNhdlhqZVZwZjZlaGtsaC9F?= =?utf-8?B?eGVvcTdXajQyV2R6UklHREM5bEQwbzNNM2lDaWtwcVNPYWF0UGZLejA3dEo3?= =?utf-8?Q?0doXfIvjS6N1C/0VKjVi2V8LW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10033d96-0371-433a-5441-08dabda74bb4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 14:25:45.4893 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gp65aVLYQ0LeqwZ1ivC0Kmx9B/yyZMWpe1IIz8NyNM3pyF9trESZjM7xY5uVVX56mk2sOymwA6C4LXgNe3XIyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7488 On 20.10.2022 08:14, Wei Chen wrote: > There are some codes in x86/numa.c can be shared by common > architectures to implememnt NUMA support. Just like some > variables and functions to check and store NUMA memory map. > And some variables and functions to do NUMA initialization. > > In this patch, we move them to common/numa.c and xen/numa.h > and use the CONFIG_NUMA to gate them for non-NUMA supported > architectures. As the target header file is Xen-style, so > we trim some spaces and replace tabs for the codes that has > been moved to xen/numa.h at the same time. > > As acpi_scan_nodes has been used in a common function, it > doesn't make sense to use acpi_xxx in common code, so we > rename it to numa_process_nodes in this patch too. After that > if we still use CONFIG_ACPI_NUMA in to gate numa_process_nodes > in numa_initmem_init, that doesn't make sense. As CONFIG_NUMA > will be selected by CONFIG_ACPI_NUMA for x86. So, we replace > CONFIG_ACPI_NUMA by CONFIG_NUMA to gate numa_process_nodes. > > As arch_numa_disabled has been implememnted for ACPI NUMA, > we can rename srat_disabled to numa_disabled and move it > to common code as well. > > The macro node_to_first_cpu(node) hasn't been used anywhere, > so we drop it in this patch too. > > Because some architectures allow to use all 64 physical address > bits, but some architectures are not (like Arm64 allows 52, 48 > bits). In this case, we use min(PADDR_BITS, BITS_PER_LONG - 1) > to calculate the shift when only one node is in the system in > this patch too. > > Signed-off-by: Wei Chen Reviewed-by: Jan Beulich with one small further request (could be taken care of also while committing if no other need for a v8 arises): > --- /dev/null > +++ b/xen/common/numa.c > @@ -0,0 +1,464 @@ > +/* > + * Generic VM initialization for NUMA setups. > + * Copyright 2002,2003 Andi Kleen, SuSE Labs. > + * Adapted for Xen: Ryan Harper > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +struct node_data __ro_after_init node_data[MAX_NUMNODES]; > + > +/* Mapping from pdx to node id */ > +unsigned int __ro_after_init memnode_shift; > +unsigned long __ro_after_init memnodemapsize; > +nodeid_t *__ro_after_init memnodemap; > +static typeof(*memnodemap) __ro_after_init _memnodemap[64]; > + > +nodeid_t __read_mostly cpu_to_node[NR_CPUS] = { > + [0 ... NR_CPUS-1] = NUMA_NO_NODE > +}; > + > +cpumask_t __read_mostly node_to_cpumask[MAX_NUMNODES]; > + > +nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; > + > +bool __ro_after_init numa_off; > + > +bool numa_disabled(void) > +{ > + return numa_off || arch_numa_disabled(); > +} > + > +/* > + * Given a shift value, try to populate memnodemap[] > + * Returns : > + * 1 if OK > + * 0 if memnodmap[] too small (of shift too small) May I ask that you correct this comment line: "of" (alone) makes no sense here. Either "or" was meant or it would want to be "because of". Unless this is a language tweak I'm entirely unaware of ... Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:09:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:09:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436626.690720 (Exim 4.92) (envelope-from ) id 1oqbpq-0000Nr-1Y; Thu, 03 Nov 2022 15:08:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436626.690720; Thu, 03 Nov 2022 15:08:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbpp-0000Nk-UV; Thu, 03 Nov 2022 15:08:49 +0000 Received: by outflank-mailman (input) for mailman id 436626; Thu, 03 Nov 2022 15:08:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbpo-0000Ne-Bi for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:08:48 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2089.outbound.protection.outlook.com [40.107.92.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 69120864-5b89-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 16:08:46 +0100 (CET) Received: from DM6PR04CA0021.namprd04.prod.outlook.com (2603:10b6:5:334::26) by PH8PR12MB7349.namprd12.prod.outlook.com (2603:10b6:510:217::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Thu, 3 Nov 2022 15:08:40 +0000 Received: from DM6NAM11FT100.eop-nam11.prod.protection.outlook.com (2603:10b6:5:334:cafe::95) by DM6PR04CA0021.outlook.office365.com (2603:10b6:5:334::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Thu, 3 Nov 2022 15:08:39 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT100.mail.protection.outlook.com (10.13.172.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 15:08:39 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov 2022 10:08:37 -0500 Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Thu, 3 Nov 2022 10:08:35 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69120864-5b89-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d8Z/iLNNNOzm4QG9eC+AePu4GET5M5OBqvGrMJmQ2WOqV/pzZb5PjUgtxpDAbF6kNUD6k5JvLtaLfapu7KthjpdEeSGOWzsBnWohKNdkyDlp6GzKTEJMBGYEoj4gXKMULt6EMhNla32lx57zBVab7YQWin+9gaDRed7daQYeY+9qamvKc1RTeyHS0qRJJoxMYmN0B71OLVIT+kv4FEJv53TDY5imNkdo7sVuc2vla8QLzIjs4b6bQriSbyTDVh4Ylku/bXarnm26ntp3VdKj9B5VkPEnyv4FwJRnRRGElOXQJQfzptMSCd7lC1IeS9dxzpkBL6Qh5xGAiqBB0/wQng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vUamV8ns79Uz6qy1FNonxnhqJWgCwThEMbkZfgiAeFU=; b=lUDh187gMpSlO8uR5Mp/6sqKrAouITPA7aXU31ymMRLavU1VrotaHsxwAAWoTuq6LpkzfVMussfeZjII376vdQrFVIb17fUGyteQCuUjdH/UGMZGvJJ1Y0CyNYxfZvR3boD56PDgjVX2IHbPWa1hHx4w3qyKiD4hlszyuFS8M6Xos7AGQNIUG6W8QXmO+qrKhGbasXh8rOF5wbBDEFCluzJBZcHS3zLiYr6Bt3vQy9l5hg1F0iKsokzwzqNBmJoHVYxtyriSG+dO7lh93tTLfhPQb6Omg3FA1yFoT/26I+8OtOMGRx7e5O/WE1Ov1/C1zktvn/Ln5wSVva0WHuS3/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vUamV8ns79Uz6qy1FNonxnhqJWgCwThEMbkZfgiAeFU=; b=TrufrXPs+g0Cy/H46qXB3O8XxqDxgVtmbmQ9vpVCzLBnOLig84GOssOKgK/yIAx+0QEcNhd9D2cQqq2NINIqbyoG9VosESLMrdA4Rn+q9tlIyva+q6RISTATOspK+OJL8CEeA7eHNjywi2kU5+7z7bOPbQGByj2Kwd7ltIznpJk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Thu, 3 Nov 2022 16:08:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 09/12] xen/Arm: GICv3: Define GIC registers for AArch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-10-ayankuma@amd.com> From: Michal Orzel In-Reply-To: <20221031151326.22634-10-ayankuma@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT100:EE_|PH8PR12MB7349:EE_ X-MS-Office365-Filtering-Correlation-Id: 60dc4a5c-2d1f-4d35-a1ba-08dabdad4a02 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +cevpXBz4iEKL8ssCTvKYaBeINlUHUhnQ74DKwPMrBDqcOq+loma0Tw69FBw5GV84lj4TDN1QPwW/wQRHcEMWe5tVQ5x+uh9s/GU4EDP4GXzf66DM37eIjtu9x0wilqCfQtvOFBJQjvIbOn+McgwmRrO28d6uGHF4RZlMQ0wvS7SIxhT0cEv1FIDIk9Y0iLTqkVTkNp3JIZ+F2Tam9FGay0svCjFO+Zbw2z2y0mlKgaTwJBBJNpJd0lqjNF6/Mmf/aMXOWu4mSdiE3MuGZi5fmWy+C+7n/Cb2hhP6mL4GgMnLVbL8qZHjYJBoFpT0ZwFejlgm90aSNoFigQgnzj/OkOOOfSy6fxQHTK6mBvtebfmc6UA62XrSybXlwj/xRIs+O6qCwguAQkOptiqhH0VRNssl1jHBai24l2XS14jScTBqkeQKmUQUZNCJ6D06Vmhf7IfcH1kNM8pFxXzhycW4mOywzrdrXI5kuhbiLdDGqlfTcLh5M0dc5V7DDVdBuTIZFVrVadJt0/U/iSy4Pu+q7DSEolUQNt8xlKtCsYBgo9mohIHU4e9Pwzsw5XFdK1uz0NSIF+2pGAbqB8AV2svB2Whg5VfEyYbVkJPTcv+yBsjLgccDCrTsIGN5cpw/KkSKhU/9DHsYnuE150yaHT7+5FP3AceeFQCsXUzcHMrM9Lvj98BtgdNr6SOPOeeXoljGCBE27HmRuvjO9S/dcpEg5cHN2pHlhGDLf7Ln7ODROwKspP0leJttNoYHuzVauMZUAQn7kZp+dCwlfQ01MhyCg6MMRoFfZYc2fIZ5lz+yjyIzfjxdckGTyVD3X3E1HjhzP9XhZ54nyyUd8P5RVQXag== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(396003)(376002)(451199015)(46966006)(40470700004)(36840700001)(70206006)(36860700001)(40460700003)(2906002)(426003)(478600001)(54906003)(53546011)(41300700001)(16576012)(26005)(110136005)(8676002)(4326008)(40480700001)(186003)(70586007)(8936002)(336012)(47076005)(83380400001)(31686004)(31696002)(316002)(2616005)(5660300002)(82310400005)(356005)(86362001)(81166007)(44832011)(36756003)(82740400003)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 15:08:39.4243 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 60dc4a5c-2d1f-4d35-a1ba-08dabdad4a02 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT100.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7349 Hi Ayan, On 31/10/2022 16:13, Ayan Kumar Halder wrote: > The title is a bit ambiguous given that the previous patches were also defining GIC registers. Maybe adding "remaining" would result in a better commit title. > > Refer "Arm IHI 0069H ID020922" > 12.5.23 ICC_SGI1R, Interrupt Controller Software Generated Interrupt > Group 1 Register > 12.5.12 ICC_HSRE, Interrupt Controller Hyp System Register Enable register > 12.7.10 ICH_VTR, Interrupt Controller VGIC Type Register > 12.7.5 ICH_HCR, Interrupt Controller Hyp Control Register > 12.5.20 ICC_PMR, Interrupt Controller Interrupt Priority Mask Register > 12.5.24 ICC_SRE, Interrupt Controller System Register Enable register > 12.5.7 ICC_DIR, Interrupt Controller Deactivate Interrupt Register > 12.5.9 ICC_EOIR1, Interrupt Controller End Of Interrupt Register 1 > 12.5.14 ICC_IAR1, Interrupt Controller Interrupt Acknowledge Register 1 > 12.5.5 ICC_BPR1, Interrupt Controller Binary Point Register 1 > 12.5.6 ICC_CTLR, Interrupt Controller Control Register > 12.5.16 ICC_IGRPEN1, Interrupt Controller Interrupt Group 1 Enable register > 12.7.9 ICH_VMCR, Interrupt Controller Virtual Machine Control Register > As said in the previous patches: this may be my personal opinion but sth like this would be easier to read: " Define missing assembly aliases for GIC registers on arm32, taking the ones defined already for arm64 as a base. Aliases are defined according to the GIC Architecture Specification ARM IHI 0069H. " > Signed-off-by: Ayan Kumar Halder > --- > > Changes from :- > v1 - 1. Moved coproc regs definition to asm/cpregs.h > > xen/arch/arm/include/asm/cpregs.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h > index bfabee0bc3..62b63f4cef 100644 > --- a/xen/arch/arm/include/asm/cpregs.h > +++ b/xen/arch/arm/include/asm/cpregs.h > @@ -415,6 +415,22 @@ > #define ICH_AP1R1_EL2 __AP1Rx_EL2(1) > #define ICH_AP1R2_EL2 __AP1Rx_EL2(2) > #define ICH_AP1R3_EL2 __AP1Rx_EL2(3) > + > +#define ICC_SGI1R_EL1 p15,0,c12 > + > +#define ICC_SRE_EL2 p15,4,c12,c9,5 > +#define ICH_VTR_EL2 p15,4,c12,c11,1 > +#define ICH_HCR_EL2 p15,4,c12,c11,0 > + > +#define ICC_PMR_EL1 p15,0,c4,c6,0 > +#define ICC_SRE_EL1 p15,0,c12,c12,5 > +#define ICC_DIR_EL1 p15,0,c12,c11,1 > +#define ICC_EOIR1_EL1 p15,0,c12,c12,1 > +#define ICC_IAR1_EL1 p15,0,c12,c12,0 > +#define ICC_BPR1_EL1 p15,0,c12,c12,3 > +#define ICC_CTLR_EL1 p15,0,c12,c12,4 > +#define ICC_IGRPEN1_EL1 p15,0,c12,c12,7 > +#define ICH_VMCR_EL2 p15,4,c12,c11,7 I did not check this in previous patches but in which order are you defining these registers? I took a look at arm64/sysregs.h and these regs are placed in assembly aliases name order. So for instance ICC_PMR_EL1 would be defined before ICC_SRE_EL2, etc. Also, I cannot see some regs like MISR, EISR that are defined for arm64. Did you decide not to define them for arm32 because they are not used by Xen? ~Michal From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:14:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:14:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436631.690732 (Exim 4.92) (envelope-from ) id 1oqbvg-0001na-M4; Thu, 03 Nov 2022 15:14:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436631.690732; Thu, 03 Nov 2022 15:14:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvg-0001nT-Ig; Thu, 03 Nov 2022 15:14:52 +0000 Received: by outflank-mailman (input) for mailman id 436631; Thu, 03 Nov 2022 15:14:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvf-0001nI-8W for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:14:51 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 41634e3a-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:48 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0CAC91F88F; Thu, 3 Nov 2022 15:14:50 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7D75213ADB; Thu, 3 Nov 2022 15:14:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sPW+HenaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41634e3a-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fXspxYMgjyOovtynN/zR0qyBvE5gyhdfPTPL365XZls=; b=qIBvwbT+lwZMaA6sGyT9BtoBqRIyBjEzJYhvn1DFBIvY3BrM8D6bNqtaXfRjFnM8KTD/yD Q6d+9YKtP2L/LaFLyM0ljPNq9k6kb0dW2V8Xrol1bNwEp3RlLE0M7WBFXktWDuVowjI8RK iWnikur7XM9oFmJLjNsfE5LnvNtUNII= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fXspxYMgjyOovtynN/zR0qyBvE5gyhdfPTPL365XZls=; b=dC2sWtRYBu/BU5h1G7EDnJGIO86fKJfOt8uxV5FkJNTaH/L+7yEV9bOlX/f9l4+3tIltY6 91lwwsVr4KJhbsAg== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 01/23] drm/komeda: Don't set struct drm_driver.lastclose Date: Thu, 3 Nov 2022 16:14:24 +0100 Message-Id: <20221103151446.2638-2-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as komeda uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c index 451746ebbe713..62dc64550793e 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c @@ -10,7 +10,6 @@ #include #include #include -#include #include #include #include @@ -59,7 +58,6 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data) static const struct drm_driver komeda_kms_driver = { .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, - .lastclose = drm_fb_helper_lastclose, DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(komeda_gem_dma_dumb_create), .fops = &komeda_cma_fops, .name = "komeda", -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:14:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:14:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436633.690754 (Exim 4.92) (envelope-from ) id 1oqbvj-0002Jj-A2; Thu, 03 Nov 2022 15:14:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436633.690754; Thu, 03 Nov 2022 15:14:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvj-0002Ja-6x; Thu, 03 Nov 2022 15:14:55 +0000 Received: by outflank-mailman (input) for mailman id 436633; Thu, 03 Nov 2022 15:14:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvg-0001nI-W5 for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:14:53 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 41c2b40f-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:48 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 97A1F1F8AC; Thu, 3 Nov 2022 15:14:50 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 11CBE13AAF; Thu, 3 Nov 2022 15:14:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wOZpA+raY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41c2b40f-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uVFjCJGoNw4AfgA4Wmezl+t3QboOrXGyxnyiCXI4wgY=; b=aeitxOzIfZfT9Dkg3Da9tXRthbRhimHuVy9WXpetW5HFYCVf9XNDxHwWQKoTcjy5rUDVTf T8vGhO0LviIspWzGSdxZXQhxZhS06j+XUc8qb4+FqFgvFLsaN1sUUalnSyudvRe2x6zPXE IZ9De10TJD23YVpx9fDJjyqhcg3WM+8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uVFjCJGoNw4AfgA4Wmezl+t3QboOrXGyxnyiCXI4wgY=; b=YMFXnRboIun21V1JVenmGaFy/T7fqydIIheoE7IDub++43bUFId0c4nXqptJxELAHV4w58 v5yHUKBLT2Df2NDQ== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 02/23] drm/mcde: Don't set struct drm_driver.lastclose Date: Thu, 3 Nov 2022 16:14:25 +0100 Message-Id: <20221103151446.2638-3-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as mcde uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/mcde/mcde_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c index 1c4482ad507d9..38c3907bb151a 100644 --- a/drivers/gpu/drm/mcde/mcde_drv.c +++ b/drivers/gpu/drm/mcde/mcde_drv.c @@ -203,7 +203,6 @@ DEFINE_DRM_GEM_DMA_FOPS(drm_fops); static const struct drm_driver mcde_drm_driver = { .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC, - .lastclose = drm_fb_helper_lastclose, .ioctls = NULL, .fops = &drm_fops, .name = "mcde", -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:14:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:14:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436634.690759 (Exim 4.92) (envelope-from ) id 1oqbvj-0002MW-Kf; Thu, 03 Nov 2022 15:14:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436634.690759; Thu, 03 Nov 2022 15:14:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvj-0002Lj-GD; Thu, 03 Nov 2022 15:14:55 +0000 Received: by outflank-mailman (input) for mailman id 436634; Thu, 03 Nov 2022 15:14:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvh-0001zN-QG for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:14:53 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 440f49fc-5b8a-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 16:14:52 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 38AE621DD6; Thu, 3 Nov 2022 15:14:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B7AE613ADB; Thu, 3 Nov 2022 15:14:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KOLnK+vaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 440f49fc-5b8a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g32cPPyLiHLtpD0q75pbEdOkYrw534GYboHCIoW0rMs=; b=QQ0hGHL3lhq/lGKYmDP6NEUgfd53Y1VFgCWOLFm9U/8/eUbskpw4bwjHTgVqXafKVcIP9F JIZtFqTcK+TpYG2kLbIBM3Y1jfy4SyVFn5J8iGczNOSSrCBF+KjaW8d6k4HjhFluVQea6q /LLAbxDt0kknL2ARPDnwKRz220jQgXw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g32cPPyLiHLtpD0q75pbEdOkYrw534GYboHCIoW0rMs=; b=9P5ZPHB1OPm/aHZvD/wVzAtGZ8Phyk9xHD8qj4269kUc2NReoGQ2aYUZxcXmsInJVbUxVh vLNFy1vjcWGI5eDA== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 05/23] drm/imx/dcss: Don't set struct drm_driver.output_poll_changed Date: Thu, 3 Nov 2022 16:14:28 +0100 Message-Id: <20221103151446.2638-6-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as DCSS uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. v2: * fix commit description (Christian) Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c index b4f82ebca5325..1defd6a40f11d 100644 --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c @@ -21,7 +21,6 @@ DEFINE_DRM_GEM_DMA_FOPS(dcss_cma_fops); static const struct drm_mode_config_funcs dcss_drm_mode_config_funcs = { .fb_create = drm_gem_fb_create, - .output_poll_changed = drm_fb_helper_output_poll_changed, .atomic_check = drm_atomic_helper_check, .atomic_commit = drm_atomic_helper_commit, }; -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:14:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:14:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436632.690743 (Exim 4.92) (envelope-from ) id 1oqbvh-000231-VL; Thu, 03 Nov 2022 15:14:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436632.690743; Thu, 03 Nov 2022 15:14:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvh-00022o-QZ; Thu, 03 Nov 2022 15:14:53 +0000 Received: by outflank-mailman (input) for mailman id 436632; Thu, 03 Nov 2022 15:14:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvf-0001nI-W4 for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:14:52 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 41342fa9-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:47 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 77F601F88C; Thu, 3 Nov 2022 15:14:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E34DA13AAF; Thu, 3 Nov 2022 15:14:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oqOUNujaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41342fa9-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488489; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=HedAlrS8erHkRoHUc/nk9PZPahT98wWins1TZNQ+myo=; b=ts+mFZqzw7nt496UOWxsBj/xG6sJKPY/ZWmHdFZxUG6ONqcbseLnVXu/wXRLAFn+VGn/YR Rqass7K9e5Tf8KqeYY+gKZRv+JgfpuuYK6ggxjkZHiOpS0V3LO8NFAUASBN8QOA44nud45 u9o1mCiJIX4XReB+zkbZ4HbcduFUihs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488489; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=HedAlrS8erHkRoHUc/nk9PZPahT98wWins1TZNQ+myo=; b=lsvt5cpyVTNQvpmzx5qsqs1XtiL2L/Eibv9TPCR/dY0Qky34DmnJAVBCZYMH6j2JOe7LS2 KLgvNS9ctlteh0Cg== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 00/23] drm/fb-helper: Untangle fbdev emulation and helpers Date: Thu, 3 Nov 2022 16:14:23 +0100 Message-Id: <20221103151446.2638-1-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Separate generic fbdev emulation from the helper code that is shared among the various fbdev implementations within DRM. Affects many drivers. It has become apparent that our fully generic fbdev emulation will never produce optimal results for all drivers. In its current form, it is also hard to maintain. The goal of this patchset is to improve readability and streamline the fbdev helper code within DRM. In the long term, we want to get to a point where drivers or memory managers can pick and combine the various helpers for optimal fbdev support. Patches 1 to 8 start by preparing drivers. Setting struct drm_driver's lastclose and output_poll_changed is not required by generic fbdev emulation. Two drivers depend on fb helpers implicitly including other Linux header files. Fixing this in patches 9 and 10 allows to remove unnecesary include statements from the fb-helper header in patch 11. Do some renaming in patches 12 to 14. There are currently various implementation of the fbdev I/O helpers with varying feature sets. The fb helpers for fbdev I/O should all call fb_sync, which is what fbdev's internal implementation does. For DRM, damage handling needs to be performed after updating a framebuffer. The damage worker is part of the fb helpers, but the actual update logic only works with generic fbdev emulation. Separate the two, which also gives other drivers an option to set their own damage handling if neccessary. The full-featured I/O helpers can be moved under a shared implementation and called by all drivers. Patches 15 to 18 resolve these issues. Patch 19 changes fbdev disablement to work at the level of display detection. If disabled, generic fbdev emulation will be initialized, but no display will be detected. It can later be enabled by changing the parameter in sysfs and plugging in a connector. Patches 20 to 22 move the generic fbdev emulation into their own source and header files and clean up the include statements throughout DRM. Many drivers only call drm_fbdev_generic_setup() and can avoid including other Linux header files. Patch 23 is a documentation update. Built on x86-64, aarch64, arm, ppc64le. Tested with various combinations of bochs, i915, simpledrm. v3: * documentation fixes (Javier) * rename drm_fbdev.{c,h} to drm_fbdev_generic.{c,h} * keep drm_leak_fbdev_smem in drm_fb_helper.c * fix several include statements * rebases v2: * fixed commit descriptions (Christian, Sergey) Thomas Zimmermann (23): drm/komeda: Don't set struct drm_driver.lastclose drm/mcde: Don't set struct drm_driver.lastclose drm/vboxvideo: Don't set struct drm_driver.lastclose drm/amdgpu: Don't set struct drm_driver.output_poll_changed drm/imx/dcss: Don't set struct drm_driver.output_poll_changed drm/ingenic: Don't set struct drm_driver.output_poll_changed drm/logicvc: Don't set struct drm_driver.output_poll_changed drm/rockchip: Don't set struct drm_driver.output_poll_changed drm/panel-ili9341: Include drm/tve200: Include drm/fb-helper: Cleanup include statements in header file drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix drm/fb-helper: Rename drm_fb_helper_unregister_fbi() to use _info postfix drm/fb-helper: Disconnect damage worker from update logic drm/fb-helper: Call fb_sync in I/O functions drm/fb-helper: Perform all fbdev I/O with the same implementation drm/fb_helper: Minimize damage-helper overhead drm/fb-helper: Always initialize generic fbdev emulation drm/fb-helper: Set flag in struct drm_fb_helper for leaking physical addresses drm/fb-helper: Move generic fbdev emulation into separate source file drm/fb-helper: Remove unnecessary include statements drm/fb-helper: Clarify use of last_close and output_poll_changed drivers/gpu/drm/Makefile | 4 +- .../gpu/drm/amd/amdgpu/amdgpu_connectors.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 - drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 1 + drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 1 + drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 1 + drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 1 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 - .../gpu/drm/arm/display/komeda/komeda_drv.c | 2 +- .../gpu/drm/arm/display/komeda/komeda_kms.c | 2 - drivers/gpu/drm/arm/hdlcd_crtc.c | 1 - drivers/gpu/drm/arm/hdlcd_drv.c | 2 +- drivers/gpu/drm/arm/malidp_drv.c | 2 +- drivers/gpu/drm/armada/armada_fbdev.c | 6 +- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 2 +- drivers/gpu/drm/ast/ast_drv.c | 1 + drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +- drivers/gpu/drm/bridge/tc358762.c | 2 +- drivers/gpu/drm/drm_crtc_helper.c | 1 - drivers/gpu/drm/drm_fb_helper.c | 1008 ++++++----------- drivers/gpu/drm/drm_fbdev_generic.c | 493 ++++++++ drivers/gpu/drm/drm_gem_framebuffer_helper.c | 1 - drivers/gpu/drm/drm_probe_helper.c | 1 - drivers/gpu/drm/etnaviv/etnaviv_drv.h | 3 +- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 6 +- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +- drivers/gpu/drm/gma500/framebuffer.c | 6 +- drivers/gpu/drm/gud/gud_drv.c | 2 +- .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 + .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 1 - .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +- drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 2 +- drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 1 - drivers/gpu/drm/i915/display/intel_fbdev.c | 8 +- drivers/gpu/drm/imx/dcss/dcss-kms.c | 3 +- drivers/gpu/drm/imx/imx-drm-core.c | 2 +- drivers/gpu/drm/imx/imx-ldb.c | 2 +- drivers/gpu/drm/imx/imx-tve.c | 1 - drivers/gpu/drm/imx/parallel-display.c | 2 +- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 3 +- drivers/gpu/drm/kmb/kmb_drv.c | 2 +- drivers/gpu/drm/kmb/kmb_plane.c | 1 - drivers/gpu/drm/logicvc/logicvc_drm.c | 2 +- drivers/gpu/drm/logicvc/logicvc_mode.c | 2 - drivers/gpu/drm/mcde/mcde_drv.c | 3 +- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- drivers/gpu/drm/meson/meson_drv.c | 2 +- drivers/gpu/drm/mgag200/mgag200_drv.c | 1 + drivers/gpu/drm/mgag200/mgag200_drv.h | 1 - drivers/gpu/drm/msm/msm_fbdev.c | 4 +- drivers/gpu/drm/mxsfb/lcdif_drv.c | 2 +- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 27 +- drivers/gpu/drm/omapdrm/omap_fbdev.c | 6 +- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 3 +- drivers/gpu/drm/pl111/pl111_drv.c | 2 +- drivers/gpu/drm/qxl/qxl_drv.c | 1 + drivers/gpu/drm/qxl/qxl_drv.h | 1 - drivers/gpu/drm/radeon/radeon_fb.c | 6 +- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 2 - drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 + drivers/gpu/drm/solomon/ssd130x.c | 2 +- drivers/gpu/drm/sti/sti_drv.c | 2 +- drivers/gpu/drm/stm/drv.c | 2 +- drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +- drivers/gpu/drm/tegra/fb.c | 8 +- drivers/gpu/drm/tidss/tidss_drv.c | 2 +- drivers/gpu/drm/tidss/tidss_kms.c | 1 - drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- drivers/gpu/drm/tiny/arcpgu.c | 2 +- drivers/gpu/drm/tiny/bochs.c | 2 +- drivers/gpu/drm/tiny/cirrus.c | 2 +- drivers/gpu/drm/tiny/gm12u320.c | 2 +- drivers/gpu/drm/tiny/hx8357d.c | 2 +- drivers/gpu/drm/tiny/ili9163.c | 2 +- drivers/gpu/drm/tiny/ili9225.c | 2 +- drivers/gpu/drm/tiny/ili9341.c | 2 +- drivers/gpu/drm/tiny/ili9486.c | 2 +- drivers/gpu/drm/tiny/mi0283qt.c | 2 +- drivers/gpu/drm/tiny/ofdrm.c | 2 +- drivers/gpu/drm/tiny/panel-mipi-dbi.c | 2 +- drivers/gpu/drm/tiny/repaper.c | 2 +- drivers/gpu/drm/tiny/simpledrm.c | 2 +- drivers/gpu/drm/tiny/st7586.c | 2 +- drivers/gpu/drm/tiny/st7735r.c | 2 +- drivers/gpu/drm/tve200/tve200_drv.c | 3 +- drivers/gpu/drm/udl/udl_drv.c | 2 +- drivers/gpu/drm/v3d/v3d_drv.c | 1 - drivers/gpu/drm/vboxvideo/vbox_drv.c | 4 +- drivers/gpu/drm/vboxvideo/vbox_main.c | 1 - drivers/gpu/drm/vc4/vc4_drv.c | 2 +- drivers/gpu/drm/virtio/virtgpu_drv.c | 1 + drivers/gpu/drm/virtio/virtgpu_drv.h | 1 - drivers/gpu/drm/vkms/vkms_drv.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 +- drivers/gpu/drm/xen/xen_drm_front_gem.c | 1 - drivers/gpu/drm/xlnx/zynqmp_kms.c | 2 +- include/drm/drm_fb_helper.h | 61 +- include/drm/drm_fbdev_generic.h | 15 + 107 files changed, 987 insertions(+), 835 deletions(-) create mode 100644 drivers/gpu/drm/drm_fbdev_generic.c create mode 100644 include/drm/drm_fbdev_generic.h base-commit: f5a9fb2d688dfc6efa1fd779a2d225048bfb10f9 prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 prerequisite-patch-id: 3f204510fcbf9530d6540bd8e6128cce598988b6 prerequisite-patch-id: db1c43fc253bf3b55cfa09128a2d83d960599ead prerequisite-patch-id: 007fca7c89f5fe0e5279021fcac49fb621bf5708 -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:14:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:14:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436635.690765 (Exim 4.92) (envelope-from ) id 1oqbvk-0002Vd-6l; Thu, 03 Nov 2022 15:14:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436635.690765; Thu, 03 Nov 2022 15:14:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvj-0002TN-W9; Thu, 03 Nov 2022 15:14:55 +0000 Received: by outflank-mailman (input) for mailman id 436635; Thu, 03 Nov 2022 15:14:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvh-0001nI-WA for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:14:54 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 420ae43e-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:49 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 297B121D9F; Thu, 3 Nov 2022 15:14:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9D00913ADB; Thu, 3 Nov 2022 15:14:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2IVoJeraY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 420ae43e-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488491; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oSkXEP/N0F8bqfQxe+3kiz0JGWByLoSpN5ingU+S7p4=; b=dhhbwUeAqHcS82EYirvfoPmjFK5AQ7FFz08RTtBUDGwK9vAKUIkMqfs9n5m9DBMmx5rkC8 bKGAhGpULqR8cyD64IyT6FyNuPDcnd/vpgjyFHXiWLXuv4oOraQ5Lu/fik3HbZB+hvg1DK k6+zno+BEO3aUVpDRd1d0Ii9q2rAF/E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488491; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oSkXEP/N0F8bqfQxe+3kiz0JGWByLoSpN5ingU+S7p4=; b=Fc/dAj5GdfsctmDYZX2Vgt/xNU4iA3AHbfQzsrOuITdIkHbO4gcW5tuqhnJeiuwGUE0IEH FFHqhoQf5IasXdBw== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 03/23] drm/vboxvideo: Don't set struct drm_driver.lastclose Date: Thu, 3 Nov 2022 16:14:26 +0100 Message-Id: <20221103151446.2638-4-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as vboxvideo uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/vboxvideo/vbox_drv.c b/drivers/gpu/drm/vboxvideo/vbox_drv.c index f4f2bd79a7cb6..1cd716eb17a1c 100644 --- a/drivers/gpu/drm/vboxvideo/vbox_drv.c +++ b/drivers/gpu/drm/vboxvideo/vbox_drv.c @@ -178,8 +178,6 @@ static const struct drm_driver driver = { .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC, - .lastclose = drm_fb_helper_lastclose, - .fops = &vbox_fops, .name = DRIVER_NAME, .desc = DRIVER_DESC, -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:14:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:14:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436636.690771 (Exim 4.92) (envelope-from ) id 1oqbvk-0002ai-Hn; Thu, 03 Nov 2022 15:14:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436636.690771; Thu, 03 Nov 2022 15:14:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvk-0002Yi-9T; Thu, 03 Nov 2022 15:14:56 +0000 Received: by outflank-mailman (input) for mailman id 436636; Thu, 03 Nov 2022 15:14:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvi-0001zN-HO for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:14:54 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 449bb368-5b8a-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 16:14:53 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 382061F8C7; Thu, 3 Nov 2022 15:14:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B24C413ADB; Thu, 3 Nov 2022 15:14:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gJTAKuzaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 449bb368-5b8a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xjxS/GfnitqpIX/oT1VDr+4iEgFe/+oN1n1IofhuZsY=; b=utvMig1eoj479eEriWrJ0nVTCL5Lk9KTSWVVHrqrowWjVIG9DcwMkAyKHQsokhUAZ/vfMH CbiE82hRJwGqH4DJZO+M+ZfnFfFE15gZZZvFO9Kjd3zgY9PKFOebOIJ3YCpvT2mUTjYImS GVI9v08EO77cHzHLlYtnySmWx3JwW84= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xjxS/GfnitqpIX/oT1VDr+4iEgFe/+oN1n1IofhuZsY=; b=+fI4CarHR9yIQjwk6lIjBSv0KJzOZE4PnC+U4vE+56gARj3H/onb+TrQGL6o0rt+MuGYBt 9zhCVmzjlb45cQDg== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 07/23] drm/logicvc: Don't set struct drm_driver.output_poll_changed Date: Thu, 3 Nov 2022 16:14:30 +0100 Message-Id: <20221103151446.2638-8-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as logicvc uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. v2: * fix commit description (Christian) Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/logicvc/logicvc_mode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/logicvc/logicvc_mode.c b/drivers/gpu/drm/logicvc/logicvc_mode.c index d8207ffda1af9..9971950ebd4ee 100644 --- a/drivers/gpu/drm/logicvc/logicvc_mode.c +++ b/drivers/gpu/drm/logicvc/logicvc_mode.c @@ -10,7 +10,6 @@ #include #include #include -#include #include #include #include @@ -26,7 +25,6 @@ static const struct drm_mode_config_funcs logicvc_mode_config_funcs = { .fb_create = drm_gem_fb_create, - .output_poll_changed = drm_fb_helper_output_poll_changed, .atomic_check = drm_atomic_helper_check, .atomic_commit = drm_atomic_helper_commit, }; -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:14:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:14:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436637.690779 (Exim 4.92) (envelope-from ) id 1oqbvl-0002kK-4g; Thu, 03 Nov 2022 15:14:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436637.690779; Thu, 03 Nov 2022 15:14:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvk-0002hl-RV; Thu, 03 Nov 2022 15:14:56 +0000 Received: by outflank-mailman (input) for mailman id 436637; Thu, 03 Nov 2022 15:14:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvj-0001nI-0L for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:14:55 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42682e74-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:49 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B1A2821DCC; Thu, 3 Nov 2022 15:14:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2EC3013AAF; Thu, 3 Nov 2022 15:14:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aIF1CuvaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42682e74-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488491; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z0wfNAEJd89nT4SyNUVt6p4RuNoCzMIzBFEMM4zIO5U=; b=i8+DCMmnRejJUBw11UFIc7YVWo+wNl2Ude1Om07l7QVPjXzjv/q2TyhyT36qe2omb+DC52 PzMZ8AcArVHhs+jNBUYAtX05fXJhKe/Tru6HQuL3SzjND7bsnFhPaeM9+O5PhVhUPfz63G coAzCVH9m1p9BvhdkBiv0gGmCw5oBE4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488491; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z0wfNAEJd89nT4SyNUVt6p4RuNoCzMIzBFEMM4zIO5U=; b=8Is+1fD2IaqB4CGmTpfRMWC03nC8mJwB00gGEQD1UClP1k1DS5h4SJl2pBqsrhOxtc42s5 OQ6nDjNmA7ogSBCw== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 04/23] drm/amdgpu: Don't set struct drm_driver.output_poll_changed Date: Thu, 3 Nov 2022 16:14:27 +0100 Message-Id: <20221103151446.2638-5-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as amdgpu uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. v2: * fix commit description (Christian) Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 - drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c index 1a06b8d724f39..dd6f9ae6fbe9f 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c @@ -1214,7 +1214,6 @@ amdgpu_display_user_framebuffer_create(struct drm_device *dev, const struct drm_mode_config_funcs amdgpu_mode_funcs = { .fb_create = amdgpu_display_user_framebuffer_create, - .output_poll_changed = drm_fb_helper_output_poll_changed, }; static const struct drm_prop_enum_list amdgpu_underscan_enum_list[] = diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 3c072754738d2..d58dd916488a1 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -82,7 +82,6 @@ #include #include #include -#include #include #include #include @@ -2810,7 +2809,6 @@ const struct amdgpu_ip_block_version dm_ip_block = static const struct drm_mode_config_funcs amdgpu_dm_mode_funcs = { .fb_create = amdgpu_display_user_framebuffer_create, .get_format_info = amd_get_format_info, - .output_poll_changed = drm_fb_helper_output_poll_changed, .atomic_check = amdgpu_dm_atomic_check, .atomic_commit = drm_atomic_helper_commit, }; -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:14:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:14:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436638.690790 (Exim 4.92) (envelope-from ) id 1oqbvm-0002uV-1i; Thu, 03 Nov 2022 15:14:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436638.690790; Thu, 03 Nov 2022 15:14:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvl-0002rV-B7; Thu, 03 Nov 2022 15:14:57 +0000 Received: by outflank-mailman (input) for mailman id 436638; Thu, 03 Nov 2022 15:14:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvj-0001zN-HT for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:14:55 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44db0149-5b8a-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 16:14:53 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A05411F8D0; Thu, 3 Nov 2022 15:14:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3137313AAF; Thu, 3 Nov 2022 15:14:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0CU2C+3aY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44db0149-5b8a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EFk8gpKJydjM+fwMWE9ut0kHu5wwTQClJK0OS12MSKc=; b=f492smjEQCmdi3Dsdo/Ey7rUqRWTZBazpiRCvsxccZ5pk+IqU+l2jP98mg2AqAYsY5OZTH 8ttUnMBMm/YowH8elwLoezAB7lpvKQ54XusD4G4OcwJ2iELNOvf/SxuYt7k6QYTnrzPaED WV2jr0n8+23t8XnbHwfNYnL1NGwTmHg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EFk8gpKJydjM+fwMWE9ut0kHu5wwTQClJK0OS12MSKc=; b=0OWWqS/ATSchqMJpxB8R5mVbqv+v1fCQwAfHIS01vRBK3a4fqcoXlsoRnFSrw0ImmQXMSP PwwNXJaQDMGj2WAg== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 08/23] drm/rockchip: Don't set struct drm_driver.output_poll_changed Date: Thu, 3 Nov 2022 16:14:31 +0100 Message-Id: <20221103151446.2638-9-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as rockchip uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. v2: * fix commit description (Christian) Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c index 092bf863110b7..7de64b0ad047f 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c @@ -9,7 +9,6 @@ #include #include #include -#include #include #include #include @@ -101,7 +100,6 @@ rockchip_fb_create(struct drm_device *dev, struct drm_file *file, static const struct drm_mode_config_funcs rockchip_drm_mode_config_funcs = { .fb_create = rockchip_fb_create, - .output_poll_changed = drm_fb_helper_output_poll_changed, .atomic_check = drm_atomic_helper_check, .atomic_commit = drm_atomic_helper_commit, }; -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:14:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:14:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436639.690796 (Exim 4.92) (envelope-from ) id 1oqbvm-00038P-NW; Thu, 03 Nov 2022 15:14:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436639.690796; Thu, 03 Nov 2022 15:14:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvm-00034W-8Z; Thu, 03 Nov 2022 15:14:58 +0000 Received: by outflank-mailman (input) for mailman id 436639; Thu, 03 Nov 2022 15:14:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvk-0001nI-0F for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:14:56 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 430583d6-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:51 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AEA7821DE0; Thu, 3 Nov 2022 15:14:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3EAE213AAF; Thu, 3 Nov 2022 15:14:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OHhLDuzaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 430583d6-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D7A0BT0Vh8AgLJUbTrGZC771i4laNkvN7+YXn/oSiXM=; b=teaI80VNLtAMlz1n/ply3x2TwZGNebhz0A+J6/5WgOT2AF8S0bKZz1Vl5kBK8EMOKDCZ5X 48i1H/SQPsjDvzmwDmW/ZVQquMM4yYzsv3tYQDBndqq02yfm2e/rRgJb1X0+Fz80M03tZZ ojfKdm26W/HeGJGMgxIi4rID1/OZTtc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D7A0BT0Vh8AgLJUbTrGZC771i4laNkvN7+YXn/oSiXM=; b=jkXjgKm0Clu9GzzE9jAeZXIa5UvldCgq+ZLL8ukN/N/+Wb1G9RP4PPzj4gslAzEIUY+OVX Cz9WQAA5z+R1alDw== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 06/23] drm/ingenic: Don't set struct drm_driver.output_poll_changed Date: Thu, 3 Nov 2022 16:14:29 +0100 Message-Id: <20221103151446.2638-7-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as ingenic uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c. v2: * fix commit description (Christian, Sergey) Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c index ab0515d2c420a..99f86f1ba8bee 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c @@ -1018,7 +1018,6 @@ static const struct drm_bridge_funcs ingenic_drm_bridge_funcs = { static const struct drm_mode_config_funcs ingenic_drm_mode_config_funcs = { .fb_create = ingenic_drm_gem_fb_create, - .output_poll_changed = drm_fb_helper_output_poll_changed, .atomic_check = drm_atomic_helper_check, .atomic_commit = drm_atomic_helper_commit, }; -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:15:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:15:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436641.690809 (Exim 4.92) (envelope-from ) id 1oqbvn-0003TZ-Tu; Thu, 03 Nov 2022 15:14:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436641.690809; Thu, 03 Nov 2022 15:14:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvn-0003QZ-Hl; Thu, 03 Nov 2022 15:14:59 +0000 Received: by outflank-mailman (input) for mailman id 436641; Thu, 03 Nov 2022 15:14:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvk-0001zN-Vo for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:14:57 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46123535-5b8a-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 16:14:55 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A69941F8DA; Thu, 3 Nov 2022 15:14:55 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1EE2713AAF; Thu, 3 Nov 2022 15:14:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kBB8Bu/aY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46123535-5b8a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488495; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ioVpD1VnfAgE1jzOCU0p+/zqngOSQZqcoisp6xSpRNA=; b=n3GB8msUesi+LtsosMhiI/Fk8UsyGEj3Ydrfavt+erXMqtxd7sFyE+2KDIxUhfsbPM0mqE xM0wplooBBe0kSXLSVfkKMqZvxjoASdESYmEG41xbeGK9xgNC8CRHPoNiFAXThbmOpBdjq Jr/OTMyL9UzoV7dsvRtkXd5iYO0T+YE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488495; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ioVpD1VnfAgE1jzOCU0p+/zqngOSQZqcoisp6xSpRNA=; b=9KQk+v7AjiJ9l6EwJpmMWbb+bJyE/Sm0WYtYPdvXei4JpSQnGB61Y4OXyMlQHX63XOgPIt ecu1LJ6TUTjBB4CQ== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 12/23] drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper Date: Thu, 3 Nov 2022 16:14:35 +0100 Message-Id: <20221103151446.2638-13-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rename struct drm_fb_helper.fbdev to info. The current name is misleading as it overlaps with generic fbdev naming conventions. Adapt to the usual naming in fbdev drivers by calling the field 'info'. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fb_helper.c | 40 +++++++++++----------- drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 23 ++++++------- drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +- drivers/gpu/drm/tegra/fb.c | 2 +- include/drm/drm_fb_helper.h | 4 +-- 6 files changed, 36 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 71edb80fe0fb9..480bf4f568b7b 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -368,7 +368,7 @@ static void drm_fb_helper_resume_worker(struct work_struct *work) resume_work); console_lock(); - fb_set_suspend(helper->fbdev, 0); + fb_set_suspend(helper->info, 0); console_unlock(); } @@ -401,7 +401,7 @@ static void drm_fb_helper_damage_blit_real(struct drm_fb_helper *fb_helper, break; } - src = fb_helper->fbdev->screen_buffer + offset; + src = fb_helper->info->screen_buffer + offset; iosys_map_incr(dst, offset); /* go to first pixel within clip rect */ for (y = clip->y1; y < clip->y2; y++) { @@ -598,7 +598,7 @@ struct fb_info *drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper) goto err_free_cmap; } - fb_helper->fbdev = info; + fb_helper->info = info; info->skip_vt_switch = true; return info; @@ -621,8 +621,8 @@ EXPORT_SYMBOL(drm_fb_helper_alloc_fbi); */ void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper) { - if (fb_helper && fb_helper->fbdev) - unregister_framebuffer(fb_helper->fbdev); + if (fb_helper && fb_helper->info) + unregister_framebuffer(fb_helper->info); } EXPORT_SYMBOL(drm_fb_helper_unregister_fbi); @@ -647,13 +647,13 @@ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper) cancel_work_sync(&fb_helper->resume_work); cancel_work_sync(&fb_helper->damage_work); - info = fb_helper->fbdev; + info = fb_helper->info; if (info) { if (info->cmap.len) fb_dealloc_cmap(&info->cmap); framebuffer_release(info); } - fb_helper->fbdev = NULL; + fb_helper->info = NULL; mutex_lock(&kernel_fb_helper_lock); if (!list_empty(&fb_helper->kernel_fb_list)) { @@ -914,8 +914,8 @@ EXPORT_SYMBOL(drm_fb_helper_cfb_imageblit); */ void drm_fb_helper_set_suspend(struct drm_fb_helper *fb_helper, bool suspend) { - if (fb_helper && fb_helper->fbdev) - fb_set_suspend(fb_helper->fbdev, suspend); + if (fb_helper && fb_helper->info) + fb_set_suspend(fb_helper->info, suspend); } EXPORT_SYMBOL(drm_fb_helper_set_suspend); @@ -938,20 +938,20 @@ EXPORT_SYMBOL(drm_fb_helper_set_suspend); void drm_fb_helper_set_suspend_unlocked(struct drm_fb_helper *fb_helper, bool suspend) { - if (!fb_helper || !fb_helper->fbdev) + if (!fb_helper || !fb_helper->info) return; /* make sure there's no pending/ongoing resume */ flush_work(&fb_helper->resume_work); if (suspend) { - if (fb_helper->fbdev->state != FBINFO_STATE_RUNNING) + if (fb_helper->info->state != FBINFO_STATE_RUNNING) return; console_lock(); } else { - if (fb_helper->fbdev->state == FBINFO_STATE_RUNNING) + if (fb_helper->info->state == FBINFO_STATE_RUNNING) return; if (!console_trylock()) { @@ -960,7 +960,7 @@ void drm_fb_helper_set_suspend_unlocked(struct drm_fb_helper *fb_helper, } } - fb_set_suspend(fb_helper->fbdev, suspend); + fb_set_suspend(fb_helper->info, suspend); console_unlock(); } EXPORT_SYMBOL(drm_fb_helper_set_suspend_unlocked); @@ -1850,7 +1850,7 @@ EXPORT_SYMBOL(drm_fb_helper_fill_info); /* * This is a continuation of drm_setup_crtcs() that sets up anything related * to the framebuffer. During initialization, drm_setup_crtcs() is called before - * the framebuffer has been allocated (fb_helper->fb and fb_helper->fbdev). + * the framebuffer has been allocated (fb_helper->fb and fb_helper->info). * So, any setup that touches those fields needs to be done here instead of in * drm_setup_crtcs(). */ @@ -1858,7 +1858,7 @@ static void drm_setup_crtcs_fb(struct drm_fb_helper *fb_helper) { struct drm_client_dev *client = &fb_helper->client; struct drm_connector_list_iter conn_iter; - struct fb_info *info = fb_helper->fbdev; + struct fb_info *info = fb_helper->info; unsigned int rotation, sw_rotations = 0; struct drm_connector *connector; struct drm_mode_set *modeset; @@ -1942,7 +1942,7 @@ __drm_fb_helper_initial_config_and_unlock(struct drm_fb_helper *fb_helper, fb_helper->deferred_setup = false; - info = fb_helper->fbdev; + info = fb_helper->info; info->var.pixclock = 0; /* Shamelessly allow physical address leaking to userspace */ #if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM) @@ -2077,7 +2077,7 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper) drm_setup_crtcs_fb(fb_helper); mutex_unlock(&fb_helper->lock); - drm_fb_helper_set_par(fb_helper->fbdev); + drm_fb_helper_set_par(fb_helper->info); return 0; } @@ -2135,7 +2135,7 @@ static int drm_fbdev_fb_release(struct fb_info *info, int user) static void drm_fbdev_cleanup(struct drm_fb_helper *fb_helper) { - struct fb_info *fbi = fb_helper->fbdev; + struct fb_info *fbi = fb_helper->info; void *shadow = NULL; if (!fb_helper->dev) @@ -2495,7 +2495,7 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client) { struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client); - if (fb_helper->fbdev) + if (fb_helper->info) /* drm_fbdev_fb_destroy() takes care of cleanup */ drm_fb_helper_unregister_fbi(fb_helper); else @@ -2546,7 +2546,7 @@ static int drm_fbdev_client_hotplug(struct drm_client_dev *client) drm_fbdev_cleanup(fb_helper); err: fb_helper->dev = NULL; - fb_helper->fbdev = NULL; + fb_helper->info = NULL; drm_err(dev, "fbdev: Failed to setup generic emulation (ret=%d)\n", ret); diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c index ab385d18ddcc3..d533ecd451025 100644 --- a/drivers/gpu/drm/i915/display/intel_fbdev.c +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c @@ -627,7 +627,7 @@ void intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous if (!ifbdev || !ifbdev->vma) goto set_suspend; - info = ifbdev->helper.fbdev; + info = ifbdev->helper.info; if (synchronous) { /* Flush any pending work to turn the console on, and then diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index 3c7e0c9d6baf1..ac4bd529ae2e8 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c @@ -231,9 +231,9 @@ void nouveau_fbcon_accel_save_disable(struct drm_device *dev) { struct nouveau_drm *drm = nouveau_drm(dev); - if (drm->fbcon && drm->fbcon->helper.fbdev) { - drm->fbcon->saved_flags = drm->fbcon->helper.fbdev->flags; - drm->fbcon->helper.fbdev->flags |= FBINFO_HWACCEL_DISABLED; + if (drm->fbcon && drm->fbcon->helper.info) { + drm->fbcon->saved_flags = drm->fbcon->helper.info->flags; + drm->fbcon->helper.info->flags |= FBINFO_HWACCEL_DISABLED; } } @@ -241,9 +241,8 @@ void nouveau_fbcon_accel_restore(struct drm_device *dev) { struct nouveau_drm *drm = nouveau_drm(dev); - if (drm->fbcon && drm->fbcon->helper.fbdev) { - drm->fbcon->helper.fbdev->flags = drm->fbcon->saved_flags; - } + if (drm->fbcon && drm->fbcon->helper.info) + drm->fbcon->helper.info->flags = drm->fbcon->saved_flags; } static void @@ -253,8 +252,8 @@ nouveau_fbcon_accel_fini(struct drm_device *dev) struct nouveau_fbdev *fbcon = drm->fbcon; if (fbcon && drm->channel) { console_lock(); - if (fbcon->helper.fbdev) - fbcon->helper.fbdev->flags |= FBINFO_HWACCEL_DISABLED; + if (fbcon->helper.info) + fbcon->helper.info->flags |= FBINFO_HWACCEL_DISABLED; console_unlock(); nouveau_channel_idle(drm->channel); nvif_object_dtor(&fbcon->twod); @@ -272,7 +271,7 @@ nouveau_fbcon_accel_init(struct drm_device *dev) { struct nouveau_drm *drm = nouveau_drm(dev); struct nouveau_fbdev *fbcon = drm->fbcon; - struct fb_info *info = fbcon->helper.fbdev; + struct fb_info *info = fbcon->helper.info; int ret; if (drm->client.device.info.family < NV_DEVICE_INFO_V0_TESLA) @@ -290,7 +289,7 @@ nouveau_fbcon_accel_init(struct drm_device *dev) static void nouveau_fbcon_zfill(struct drm_device *dev, struct nouveau_fbdev *fbcon) { - struct fb_info *info = fbcon->helper.fbdev; + struct fb_info *info = fbcon->helper.info; struct fb_fillrect rect; /* Clear the entire fbcon. The drm will program every connector @@ -586,8 +585,8 @@ nouveau_fbcon_init(struct drm_device *dev) if (ret) goto fini; - if (fbcon->helper.fbdev) - fbcon->helper.fbdev->pixmap.buf_align = 4; + if (fbcon->helper.info) + fbcon->helper.info->pixmap.buf_align = 4; return 0; fini: diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c index ed67dd25794c8..92d505be53e06 100644 --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c @@ -38,7 +38,7 @@ static struct drm_fb_helper *get_fb(struct fb_info *fbi); static void pan_worker(struct work_struct *work) { struct omap_fbdev *fbdev = container_of(work, struct omap_fbdev, work); - struct fb_info *fbi = fbdev->base.fbdev; + struct fb_info *fbi = fbdev->base.info; int npages; /* DMM roll shifts in 4K pages: */ diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index bce71c0ccc9ef..6fe24535d0e43 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @@ -261,7 +261,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, fb = fbdev->fb; helper->fb = fb; - helper->fbdev = info; + helper->info = info; info->fbops = &tegra_fb_ops; diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index e923089522896..d83e2d8e92eb9 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -96,7 +96,7 @@ struct drm_fb_helper_funcs { * @fb: Scanout framebuffer object * @dev: DRM device * @funcs: driver callbacks for fb helper - * @fbdev: emulated fbdev device info struct + * @info: emulated fbdev device info struct * @pseudo_palette: fake palette of 16 colors * @damage_clip: clip rectangle used with deferred_io to accumulate damage to * the screen buffer @@ -127,7 +127,7 @@ struct drm_fb_helper { struct drm_framebuffer *fb; struct drm_device *dev; const struct drm_fb_helper_funcs *funcs; - struct fb_info *fbdev; + struct fb_info *info; u32 pseudo_palette[17]; struct drm_clip_rect damage_clip; spinlock_t damage_lock; -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:15:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:15:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436640.690822 (Exim 4.92) (envelope-from ) id 1oqbvp-0003od-JK; Thu, 03 Nov 2022 15:15:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436640.690822; Thu, 03 Nov 2022 15:15:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvo-0003lS-N3; Thu, 03 Nov 2022 15:15:00 +0000 Received: by outflank-mailman (input) for mailman id 436640; Thu, 03 Nov 2022 15:14:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvl-0001nI-0R for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:14:57 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 43c7a172-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:52 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 181AB21DE2; Thu, 3 Nov 2022 15:14:54 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A1AEE13ADB; Thu, 3 Nov 2022 15:14:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UCGuJu3aY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43c7a172-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488494; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DAeMCwRCJM5hznGIXRhbDEzf9LOpLMgsqs12CnL2W3Y=; b=zCzHweR6BnCedpkcTlfiK+JVAZLFhSUtaTciouOpNU3CvL1HPp1mHw+SNd0AEa0gpfc8Gd dqd9mR7dMx4wPMwRBpSTBK10OvAW4U7cYCgkIYFln0/pKqhd/lWyqNF9/xv44+znJcgDcf 770aUvTU8jbIsmPqWEKZYQzdJNhMfds= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488494; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DAeMCwRCJM5hznGIXRhbDEzf9LOpLMgsqs12CnL2W3Y=; b=paKS2cvRRwa0Vi1ztoK9HitUEgaOXprUJdSvgtBEQ8sBWSJSo8uFGwcFxNSL6ZS1xGodf8 3VE/OD++GHQfnYCQ== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 09/23] drm/panel-ili9341: Include Date: Thu, 3 Nov 2022 16:14:32 +0100 Message-Id: <20221103151446.2638-10-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Include for devm_of_find_backlight(). Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c index 39dc40cf681f0..b59472c29a40d 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c @@ -18,6 +18,7 @@ * Copyright 2018 David Lechner */ +#include #include #include #include -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:15:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:15:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436642.690833 (Exim 4.92) (envelope-from ) id 1oqbvr-000438-Ef; Thu, 03 Nov 2022 15:15:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436642.690833; Thu, 03 Nov 2022 15:15:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvp-0003vP-P0; Thu, 03 Nov 2022 15:15:01 +0000 Received: by outflank-mailman (input) for mailman id 436642; Thu, 03 Nov 2022 15:14:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvm-0001nI-0R for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:14:58 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 441219a5-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:52 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8E52421DEF; Thu, 3 Nov 2022 15:14:54 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1C74013AAF; Thu, 3 Nov 2022 15:14:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cIscBu7aY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 441219a5-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488494; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EkoY2CiiAEHjZ/OYnuapD4MfGy2oyIAq4b5o8EaQT3s=; b=lR4Tb56okc+sFQIRKH0CzelfQbheRV7Qr0iaco7WcMuBYnmsh9gZSKNhKuDUtXJOo9XKcw b2B8BHsarB4u1uw4Xb4kGw+hdo7OMM/z3AhsxcsQPEkF2paFEOjMBEX/QgauRWn8PyUMsh R5pD0wtwcpSLiMHxZmfhQ1sni3ZMMFY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488494; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EkoY2CiiAEHjZ/OYnuapD4MfGy2oyIAq4b5o8EaQT3s=; b=/u2ehk8wsr8fqjo0X1DYqzXBCnnMezfxNTs00QEevNrbWKXPRo3uIzQb8Ja7nosLrLjOfi F3NmzSzNp2xT9LAg== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 10/23] drm/tve200: Include Date: Thu, 3 Nov 2022 16:14:33 +0100 Message-Id: <20221103151446.2638-11-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Include for of_match_ptr(). Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/tve200/tve200_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c index 04db72e3fa9c2..611785e097576 100644 --- a/drivers/gpu/drm/tve200/tve200_drv.c +++ b/drivers/gpu/drm/tve200/tve200_drv.c @@ -32,6 +32,7 @@ #include #include #include +#include #include #include #include -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:15:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:15:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436643.690844 (Exim 4.92) (envelope-from ) id 1oqbvs-0004Tw-Qf; Thu, 03 Nov 2022 15:15:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436643.690844; Thu, 03 Nov 2022 15:15:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvr-0004OW-U7; Thu, 03 Nov 2022 15:15:03 +0000 Received: by outflank-mailman (input) for mailman id 436643; Thu, 03 Nov 2022 15:14:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvm-0001zN-I0 for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:14:58 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4722e4b8-5b8a-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 16:14:57 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6986D1F8E8; Thu, 3 Nov 2022 15:14:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C013E13ADB; Thu, 3 Nov 2022 15:14:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6Br3LfDaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4722e4b8-5b8a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488497; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dABgwN8DHhdSFdmvQoS/APAuOZCTk1xcbptlf+la6g4=; b=1fEWnQEjouTz99410aQ2anAaiojfO8tPz++OQGD4WLXZ5gUEs5b4vO3deaLmKA46XXR21y avVCsHH1123TCT1exnwybLBw+OQiTgY5gGkb/lqMYcFAHHsfTGwI8isTWVnXcMxWET0zNW 1sq8yOCX9pqrrch+8QWsIixla0xuW8U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488497; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dABgwN8DHhdSFdmvQoS/APAuOZCTk1xcbptlf+la6g4=; b=ZokmNUdMSJRJ9i5LRSqQeKRvJ0QKrtIGSwBrmgjoRLTeTl63HGF+ZvAODGfQ3gcCi9x9A6 JkgPgPCVvycn0aDQ== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 15/23] drm/fb-helper: Disconnect damage worker from update logic Date: Thu, 3 Nov 2022 16:14:38 +0100 Message-Id: <20221103151446.2638-16-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The fbdev helpers implement a damage worker that forwards fbdev updates to the DRM driver. The worker's update logic depends on the generic fbdev emulation. Separate the two via function pointer. The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty, a new callback that hides the update logic from the damage worker. It's not possible to use the generic logic with other fbdev emulation, because it contains additional code for the shadow buffering that the generic emulation employs. DRM drivers with internal fbdev emulation can set fb_dirty to their own implementation if they require damage handling; although no such drivers currently exist. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fb_helper.c | 75 ++++++++++++++++++++------------- include/drm/drm_fb_helper.h | 15 +++++++ 2 files changed, 61 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index bfbb2af144060..f6d22cc4cd876 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -448,35 +448,24 @@ static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper, static void drm_fb_helper_damage_work(struct work_struct *work) { - struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, - damage_work); - struct drm_device *dev = helper->dev; + struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work); struct drm_clip_rect *clip = &helper->damage_clip; struct drm_clip_rect clip_copy; unsigned long flags; int ret; + if (!helper->funcs->fb_dirty) + return; + spin_lock_irqsave(&helper->damage_lock, flags); clip_copy = *clip; clip->x1 = clip->y1 = ~0; clip->x2 = clip->y2 = 0; spin_unlock_irqrestore(&helper->damage_lock, flags); - /* Call damage handlers only if necessary */ - if (!(clip_copy.x1 < clip_copy.x2 && clip_copy.y1 < clip_copy.y2)) - return; - - if (helper->buffer) { - ret = drm_fb_helper_damage_blit(helper, &clip_copy); - if (drm_WARN_ONCE(dev, ret, "Damage blitter failed: ret=%d\n", ret)) - goto err; - } - - if (helper->fb->funcs->dirty) { - ret = helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, &clip_copy, 1); - if (drm_WARN_ONCE(dev, ret, "Dirty helper failed: ret=%d\n", ret)) - goto err; - } + ret = helper->funcs->fb_dirty(helper, &clip_copy); + if (ret) + goto err; return; @@ -670,16 +659,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper) } EXPORT_SYMBOL(drm_fb_helper_fini); -static bool drm_fbdev_use_shadow_fb(struct drm_fb_helper *fb_helper) -{ - struct drm_device *dev = fb_helper->dev; - struct drm_framebuffer *fb = fb_helper->fb; - - return dev->mode_config.prefer_shadow_fbdev || - dev->mode_config.prefer_shadow || - fb->funcs->dirty; -} - static void drm_fb_helper_damage(struct fb_info *info, u32 x, u32 y, u32 width, u32 height) { @@ -687,7 +666,7 @@ static void drm_fb_helper_damage(struct fb_info *info, u32 x, u32 y, struct drm_clip_rect *clip = &helper->damage_clip; unsigned long flags; - if (!drm_fbdev_use_shadow_fb(helper)) + if (!helper->funcs->fb_dirty) return; spin_lock_irqsave(&helper->damage_lock, flags); @@ -2111,6 +2090,16 @@ void drm_fb_helper_output_poll_changed(struct drm_device *dev) } EXPORT_SYMBOL(drm_fb_helper_output_poll_changed); +static bool drm_fbdev_use_shadow_fb(struct drm_fb_helper *fb_helper) +{ + struct drm_device *dev = fb_helper->dev; + struct drm_framebuffer *fb = fb_helper->fb; + + return dev->mode_config.prefer_shadow_fbdev || + dev->mode_config.prefer_shadow || + fb->funcs->dirty; +} + /* @user: 1=userspace, 0=fbcon */ static int drm_fbdev_fb_open(struct fb_info *info, int user) { @@ -2487,8 +2476,36 @@ static int drm_fb_helper_generic_probe(struct drm_fb_helper *fb_helper, return 0; } +static int drm_fbdev_fb_dirty(struct drm_fb_helper *helper, struct drm_clip_rect *clip) +{ + struct drm_device *dev = helper->dev; + int ret; + + if (!drm_fbdev_use_shadow_fb(helper)) + return 0; + + /* Call damage handlers only if necessary */ + if (!(clip->x1 < clip->x2 && clip->y1 < clip->y2)) + return 0; + + if (helper->buffer) { + ret = drm_fb_helper_damage_blit(helper, clip); + if (drm_WARN_ONCE(dev, ret, "Damage blitter failed: ret=%d\n", ret)) + return ret; + } + + if (helper->fb->funcs->dirty) { + ret = helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, clip, 1); + if (drm_WARN_ONCE(dev, ret, "Dirty helper failed: ret=%d\n", ret)) + return ret; + } + + return 0; +} + static const struct drm_fb_helper_funcs drm_fb_helper_generic_funcs = { .fb_probe = drm_fb_helper_generic_probe, + .fb_dirty = drm_fbdev_fb_dirty, }; static void drm_fbdev_client_unregister(struct drm_client_dev *client) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index edc697a2fde24..3d7a3d68dab8a 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -30,6 +30,7 @@ #ifndef DRM_FB_HELPER_H #define DRM_FB_HELPER_H +struct drm_clip_rect; struct drm_fb_helper; #include @@ -89,6 +90,20 @@ struct drm_fb_helper_funcs { */ int (*fb_probe)(struct drm_fb_helper *helper, struct drm_fb_helper_surface_size *sizes); + + /** + * @fb_dirty: + * + * Driver callback to update the framebuffer memory. If set, fbdev + * emulation will invoke this callback in regular intervals after + * the framebuffer has been written. + * + * This callback is optional. + * + * Returns: + * 0 on success, or an error code otherwise. + */ + int (*fb_dirty)(struct drm_fb_helper *helper, struct drm_clip_rect *clip); }; /** -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:15:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:15:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436644.690859 (Exim 4.92) (envelope-from ) id 1oqbvv-00054t-Iv; Thu, 03 Nov 2022 15:15:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436644.690859; Thu, 03 Nov 2022 15:15:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvu-0004yl-PE; Thu, 03 Nov 2022 15:15:06 +0000 Received: by outflank-mailman (input) for mailman id 436644; Thu, 03 Nov 2022 15:14:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvn-0001nI-0S for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:14:59 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4461159f-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:53 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1A2DD1F8D4; Thu, 3 Nov 2022 15:14:55 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 919ED13ADB; Thu, 3 Nov 2022 15:14:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4CfBIu7aY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4461159f-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488495; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T97NNzQIXdQboHVakcc3btWsx14G704vol4zvtyaVcE=; b=T8XjDQ6xPKBfMRAtCwREAQEqcOHcnSJ8e7yYXElg8636mpxy7T113a3aEVDZJuhWQe8pHh bVa8tGF8Z7xVZP/DhEoa2+kLzM1ifm4V07JGMJtmY07uTjp7Blasqo82+FeRsTA1d9rz0b 8RSxcJlXOuyVutkVHvTTxeUQO9HslAI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488495; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T97NNzQIXdQboHVakcc3btWsx14G704vol4zvtyaVcE=; b=v1n4yUF7hYIpMabvz8Cc8U0ElcngH7QHxWhN64QcYf7H7RteXIxt7UKDjlTP1taWpeMxBn Gzp6HrdqWh/c6/Dg== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 11/23] drm/fb-helper: Cleanup include statements in header file Date: Thu, 3 Nov 2022 16:14:34 +0100 Message-Id: <20221103151446.2638-12-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Only include what we have to. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- include/drm/drm_fb_helper.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index fddd0d1af6891..e923089522896 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -32,11 +32,9 @@ struct drm_fb_helper; -#include -#include -#include #include -#include + +#include enum mode_set_atomic { LEAVE_ATOMIC_MODE_SET, -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:15:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:15:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436645.690868 (Exim 4.92) (envelope-from ) id 1oqbvx-0005Ky-44; Thu, 03 Nov 2022 15:15:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436645.690868; Thu, 03 Nov 2022 15:15:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvw-0005FT-3a; Thu, 03 Nov 2022 15:15:08 +0000 Received: by outflank-mailman (input) for mailman id 436645; Thu, 03 Nov 2022 15:15:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvo-0001nI-0i for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:15:00 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 450b30df-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:54 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 27E9A1F8DC; Thu, 3 Nov 2022 15:14:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AD01B13ADB; Thu, 3 Nov 2022 15:14:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8D5wKe/aY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 450b30df-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488496; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B4aPgzZZorCQLl3vAvSSMp+NdFC9o0tszL97E4EWDSk=; b=I/+haJyfr+gENHgrb5PmCYXiaIqSiRlc6gzw3E11wcwkELm+bxwmry634/+fD/O1hXtiY2 3IJ7AOUJ6wo0W34ZbqvRpJrStx6TtNCANoQzS4TIU++Nsq9eRFXG2AoxtzUM6gNEZmAxPn xbFTzGILmwQadcevn2+sH38LPYW4QkY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488496; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B4aPgzZZorCQLl3vAvSSMp+NdFC9o0tszL97E4EWDSk=; b=JReK5h56PGHBX9lsa3CqhzBTgE6WBJBvk5ZBwQ5LfSS97qrXGbiVWzt/wN10p1acycBkLN /04HGKYEusyunADA== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 13/23] drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix Date: Thu, 3 Nov 2022 16:14:36 +0100 Message-Id: <20221103151446.2638-14-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rename drm_fb_helper_alloc_fbi() to drm_fb_helper_alloc_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/drm_fb_helper.c | 8 ++++---- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +- drivers/gpu/drm/gma500/framebuffer.c | 2 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +- drivers/gpu/drm/msm/msm_fbdev.c | 2 +- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 2 +- drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +- drivers/gpu/drm/radeon/radeon_fb.c | 2 +- drivers/gpu/drm/tegra/fb.c | 2 +- include/drm/drm_fb_helper.h | 4 ++-- 11 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c index 38f5170c0fea6..eaae98d9377ae 100644 --- a/drivers/gpu/drm/armada/armada_fbdev.c +++ b/drivers/gpu/drm/armada/armada_fbdev.c @@ -72,7 +72,7 @@ static int armada_fbdev_create(struct drm_fb_helper *fbh, if (IS_ERR(dfb)) return PTR_ERR(dfb); - info = drm_fb_helper_alloc_fbi(fbh); + info = drm_fb_helper_alloc_info(fbh); if (IS_ERR(info)) { ret = PTR_ERR(info); goto err_fballoc; diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 480bf4f568b7b..881e6a04fa706 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -558,7 +558,7 @@ int drm_fb_helper_init(struct drm_device *dev, EXPORT_SYMBOL(drm_fb_helper_init); /** - * drm_fb_helper_alloc_fbi - allocate fb_info and some of its members + * drm_fb_helper_alloc_info - allocate fb_info and some of its members * @fb_helper: driver-allocated fbdev helper * * A helper to alloc fb_info and the members cmap and apertures. Called @@ -570,7 +570,7 @@ EXPORT_SYMBOL(drm_fb_helper_init); * fb_info pointer if things went okay, pointer containing error code * otherwise */ -struct fb_info *drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper) +struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper) { struct device *dev = fb_helper->dev->dev; struct fb_info *info; @@ -609,7 +609,7 @@ struct fb_info *drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper) framebuffer_release(info); return ERR_PTR(ret); } -EXPORT_SYMBOL(drm_fb_helper_alloc_fbi); +EXPORT_SYMBOL(drm_fb_helper_alloc_info); /** * drm_fb_helper_unregister_fbi - unregister fb_info framebuffer device @@ -2440,7 +2440,7 @@ static int drm_fb_helper_generic_probe(struct drm_fb_helper *fb_helper, fb_helper->fb = buffer->fb; fb = buffer->fb; - fbi = drm_fb_helper_alloc_fbi(fb_helper); + fbi = drm_fb_helper_alloc_info(fb_helper); if (IS_ERR(fbi)) return PTR_ERR(fbi); diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index 767afd2bfa822..8741eb0b1b604 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -63,7 +63,7 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper, unsigned int size = fb->width * fb->height * fb->format->cpp[0]; unsigned long offset; - fbi = drm_fb_helper_alloc_fbi(helper); + fbi = drm_fb_helper_alloc_info(helper); if (IS_ERR(fbi)) { DRM_DEV_ERROR(to_dma_dev(helper->dev), "failed to allocate fb info.\n"); diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index 5f502a0048ab8..6d0e3bf6435ee 100644 --- a/drivers/gpu/drm/gma500/framebuffer.c +++ b/drivers/gpu/drm/gma500/framebuffer.c @@ -268,7 +268,7 @@ static int psbfb_create(struct drm_fb_helper *fb_helper, memset(dev_priv->vram_addr + backing->offset, 0, size); - info = drm_fb_helper_alloc_fbi(fb_helper); + info = drm_fb_helper_alloc_info(fb_helper); if (IS_ERR(info)) { ret = PTR_ERR(info); goto err_drm_gem_object_put; diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c index d533ecd451025..05b841343ea3e 100644 --- a/drivers/gpu/drm/i915/display/intel_fbdev.c +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c @@ -254,7 +254,7 @@ static int intelfb_create(struct drm_fb_helper *helper, goto out_unlock; } - info = drm_fb_helper_alloc_fbi(helper); + info = drm_fb_helper_alloc_info(helper); if (IS_ERR(info)) { drm_err(&dev_priv->drm, "Failed to allocate fb_info (%pe)\n", info); ret = PTR_ERR(info); diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c index b373e30003203..4d9a0fcbf95b6 100644 --- a/drivers/gpu/drm/msm/msm_fbdev.c +++ b/drivers/gpu/drm/msm/msm_fbdev.c @@ -93,7 +93,7 @@ static int msm_fbdev_create(struct drm_fb_helper *helper, goto fail; } - fbi = drm_fb_helper_alloc_fbi(helper); + fbi = drm_fb_helper_alloc_info(helper); if (IS_ERR(fbi)) { DRM_DEV_ERROR(dev->dev, "failed to allocate fb info\n"); ret = PTR_ERR(fbi); diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index ac4bd529ae2e8..fca40124fc17c 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c @@ -362,7 +362,7 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, } } - info = drm_fb_helper_alloc_fbi(helper); + info = drm_fb_helper_alloc_info(helper); if (IS_ERR(info)) { ret = PTR_ERR(info); goto out_unlock; diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c index 92d505be53e06..ab30c64e97043 100644 --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c @@ -161,7 +161,7 @@ static int omap_fbdev_create(struct drm_fb_helper *helper, goto fail; } - fbi = drm_fb_helper_alloc_fbi(helper); + fbi = drm_fb_helper_alloc_info(helper); if (IS_ERR(fbi)) { dev_err(dev->dev, "failed to allocate fb info\n"); ret = PTR_ERR(fbi); diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c index cc6754d88b819..0c6a227929db2 100644 --- a/drivers/gpu/drm/radeon/radeon_fb.c +++ b/drivers/gpu/drm/radeon/radeon_fb.c @@ -243,7 +243,7 @@ static int radeonfb_create(struct drm_fb_helper *helper, rbo = gem_to_radeon_bo(gobj); /* okay we have an object now allocate the framebuffer */ - info = drm_fb_helper_alloc_fbi(helper); + info = drm_fb_helper_alloc_info(helper); if (IS_ERR(info)) { ret = PTR_ERR(info); goto out; diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index 6fe24535d0e43..a09c071f35120 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @@ -243,7 +243,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, if (IS_ERR(bo)) return PTR_ERR(bo); - info = drm_fb_helper_alloc_fbi(helper); + info = drm_fb_helper_alloc_info(helper); if (IS_ERR(info)) { dev_err(drm->dev, "failed to allocate framebuffer info\n"); drm_gem_object_put(&bo->gem); diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index d83e2d8e92eb9..5ec9d9c68d144 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -222,7 +222,7 @@ int drm_fb_helper_check_var(struct fb_var_screeninfo *var, int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper); -struct fb_info *drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper); +struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper); void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper); void drm_fb_helper_fill_info(struct fb_info *info, struct drm_fb_helper *fb_helper, @@ -320,7 +320,7 @@ drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) } static inline struct fb_info * -drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper) +drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper) { return NULL; } -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:15:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:15:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436646.690878 (Exim 4.92) (envelope-from ) id 1oqbvy-0005j8-U1; Thu, 03 Nov 2022 15:15:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436646.690878; Thu, 03 Nov 2022 15:15:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvx-0005Zi-Jq; Thu, 03 Nov 2022 15:15:09 +0000 Received: by outflank-mailman (input) for mailman id 436646; Thu, 03 Nov 2022 15:15:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvo-0001zN-G4 for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:15:00 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 47e52fa4-5b8a-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 16:14:59 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B695B21DEE; Thu, 3 Nov 2022 15:14:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1658D13AAF; Thu, 3 Nov 2022 15:14:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sBd/BPLaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47e52fa4-5b8a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488498; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SotlzbMIFRL9v0KTZHyxFRipdSEQQSPUMfNHR83x5EY=; b=PDZXVu/i+LpGd/FOVJ4CtkS4GxIzhSOSRo1+zEaUTh5jGxEuVli6a4fqjug0o6eE3rbJI9 zH6Fw3zPCpkUNHl1YiK+gk+OPfWMCE0y1TDhTATbEmWQYks3Tz1gbsoRqqMgdj2qw6UgDd MXCD64RK3yu6ZlG89myfxApCYJR3vFQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488498; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SotlzbMIFRL9v0KTZHyxFRipdSEQQSPUMfNHR83x5EY=; b=1D2xNvf8vsnumL3E2WeVZuxoi+pkA0EJGU9PpFGu6iabSWDf05OU6gmWkluwzJaNx0b96E R8aEb4AWWbbranCA== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 17/23] drm/fb-helper: Perform all fbdev I/O with the same implementation Date: Thu, 3 Nov 2022 16:14:40 +0100 Message-Id: <20221103151446.2638-18-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Implement the fbdev's read/write helpers with the same functions. Use the generic fbdev's code as template. Convert all drivers. DRM's fb helpers must implement regular I/O functionality in struct fb_ops and possibly perform a damage update. Handle all this in the same functions and convert drivers. The functionality has been used as part of the generic fbdev code for some time. The drivers don't set struct drm_fb_helper.fb_dirty, so they will not be affected by damage handling. For I/O memory, fb helpers now provide drm_fb_helper_cfb_read() and drm_fb_helper_cfb_write(). Several drivers require these. Until now tegra used I/O read and write, although the memory buffer appears to be in system memory. So use _sys_ helpers now. v3: * fix docs (Javier) v2: * rebase onto vmwgfx changes Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/armada/armada_fbdev.c | 2 + drivers/gpu/drm/drm_fb_helper.c | 383 ++++++++++++--------- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 + drivers/gpu/drm/gma500/framebuffer.c | 2 + drivers/gpu/drm/i915/display/intel_fbdev.c | 2 + drivers/gpu/drm/radeon/radeon_fb.c | 2 + drivers/gpu/drm/tegra/fb.c | 2 + include/drm/drm_fb_helper.h | 17 + 8 files changed, 254 insertions(+), 158 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c index f02f6a5ba8320..584cee123bd8e 100644 --- a/drivers/gpu/drm/armada/armada_fbdev.c +++ b/drivers/gpu/drm/armada/armada_fbdev.c @@ -19,6 +19,8 @@ static const struct fb_ops armada_fb_ops = { .owner = THIS_MODULE, DRM_FB_HELPER_DEFAULT_OPS, + .fb_read = drm_fb_helper_cfb_read, + .fb_write = drm_fb_helper_cfb_write, .fb_fillrect = drm_fb_helper_cfb_fillrect, .fb_copyarea = drm_fb_helper_cfb_copyarea, .fb_imageblit = drm_fb_helper_cfb_imageblit, diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 379e0d2f67198..c7c0c0a8532b4 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -747,30 +747,132 @@ void drm_fb_helper_deferred_io(struct fb_info *info, struct list_head *pagerefli } EXPORT_SYMBOL(drm_fb_helper_deferred_io); +typedef ssize_t (*drm_fb_helper_read_screen)(struct fb_info *info, char __user *buf, + size_t count, loff_t pos); + +static ssize_t __drm_fb_helper_read(struct fb_info *info, char __user *buf, size_t count, + loff_t *ppos, drm_fb_helper_read_screen read_screen) +{ + loff_t pos = *ppos; + size_t total_size; + ssize_t ret; + + if (info->screen_size) + total_size = info->screen_size; + else + total_size = info->fix.smem_len; + + if (pos >= total_size) + return 0; + if (count >= total_size) + count = total_size; + if (total_size - count < pos) + count = total_size - pos; + + if (info->fbops->fb_sync) + info->fbops->fb_sync(info); + + ret = read_screen(info, buf, count, pos); + if (ret > 0) + *ppos += ret; + + return ret; +} + +typedef ssize_t (*drm_fb_helper_write_screen)(struct fb_info *info, const char __user *buf, + size_t count, loff_t pos); + +static ssize_t __drm_fb_helper_write(struct fb_info *info, const char __user *buf, size_t count, + loff_t *ppos, drm_fb_helper_write_screen write_screen) +{ + loff_t pos = *ppos; + size_t total_size; + ssize_t ret; + int err = 0; + + if (info->screen_size) + total_size = info->screen_size; + else + total_size = info->fix.smem_len; + + if (pos > total_size) + return -EFBIG; + if (count > total_size) { + err = -EFBIG; + count = total_size; + } + if (total_size - count < pos) { + if (!err) + err = -ENOSPC; + count = total_size - pos; + } + + if (info->fbops->fb_sync) + info->fbops->fb_sync(info); + + /* + * Copy to framebuffer even if we already logged an error. Emulates + * the behavior of the original fbdev implementation. + */ + ret = write_screen(info, buf, count, pos); + if (ret < 0) + return ret; /* return last error, if any */ + else if (!ret) + return err; /* return previous error, if any */ + + *ppos += ret; + + return ret; +} + +static ssize_t drm_fb_helper_read_screen_buffer(struct fb_info *info, char __user *buf, + size_t count, loff_t pos) +{ + const char *src = info->screen_buffer + pos; + + if (copy_to_user(buf, src, count)) + return -EFAULT; + + return count; +} + /** - * drm_fb_helper_sys_read - wrapper around fb_sys_read + * drm_fb_helper_sys_read - Implements struct &fb_ops.fb_read for system memory * @info: fb_info struct pointer * @buf: userspace buffer to read from framebuffer memory * @count: number of bytes to read from framebuffer memory * @ppos: read offset within framebuffer memory * - * A wrapper around fb_sys_read implemented by fbdev core + * Returns: + * The number of bytes read on success, or an error code otherwise. */ ssize_t drm_fb_helper_sys_read(struct fb_info *info, char __user *buf, size_t count, loff_t *ppos) { - return fb_sys_read(info, buf, count, ppos); + return __drm_fb_helper_read(info, buf, count, ppos, drm_fb_helper_read_screen_buffer); } EXPORT_SYMBOL(drm_fb_helper_sys_read); +static ssize_t drm_fb_helper_write_screen_buffer(struct fb_info *info, const char __user *buf, + size_t count, loff_t pos) +{ + char *dst = info->screen_buffer + pos; + + if (copy_from_user(dst, buf, count)) + return -EFAULT; + + return count; +} + /** - * drm_fb_helper_sys_write - wrapper around fb_sys_write + * drm_fb_helper_sys_write - Implements struct &fb_ops.fb_write for system memory * @info: fb_info struct pointer * @buf: userspace buffer to write to framebuffer memory * @count: number of bytes to write to framebuffer memory * @ppos: write offset within framebuffer memory * - * A wrapper around fb_sys_write implemented by fbdev core + * Returns: + * The number of bytes written on success, or an error code otherwise. */ ssize_t drm_fb_helper_sys_write(struct fb_info *info, const char __user *buf, size_t count, loff_t *ppos) @@ -779,7 +881,7 @@ ssize_t drm_fb_helper_sys_write(struct fb_info *info, const char __user *buf, ssize_t ret; struct drm_rect damage_area; - ret = fb_sys_write(info, buf, count, ppos); + ret = __drm_fb_helper_write(info, buf, count, ppos, drm_fb_helper_write_screen_buffer); if (ret <= 0) return ret; @@ -837,6 +939,119 @@ void drm_fb_helper_sys_imageblit(struct fb_info *info, } EXPORT_SYMBOL(drm_fb_helper_sys_imageblit); +static ssize_t fb_read_screen_base(struct fb_info *info, char __user *buf, size_t count, + loff_t pos) +{ + const char __iomem *src = info->screen_base + pos; + size_t alloc_size = min_t(size_t, count, PAGE_SIZE); + ssize_t ret = 0; + int err = 0; + char *tmp; + + tmp = kmalloc(alloc_size, GFP_KERNEL); + if (!tmp) + return -ENOMEM; + + while (count) { + size_t c = min_t(size_t, count, alloc_size); + + memcpy_fromio(tmp, src, c); + if (copy_to_user(buf, tmp, c)) { + err = -EFAULT; + break; + } + + src += c; + buf += c; + ret += c; + count -= c; + } + + kfree(tmp); + + return ret ? ret : err; +} + +/** + * drm_fb_helper_cfb_read - Implements struct &fb_ops.fb_read for I/O memory + * @info: fb_info struct pointer + * @buf: userspace buffer to read from framebuffer memory + * @count: number of bytes to read from framebuffer memory + * @ppos: read offset within framebuffer memory + * + * Returns: + * The number of bytes read on success, or an error code otherwise. + */ +ssize_t drm_fb_helper_cfb_read(struct fb_info *info, char __user *buf, + size_t count, loff_t *ppos) +{ + return __drm_fb_helper_read(info, buf, count, ppos, fb_read_screen_base); +} +EXPORT_SYMBOL(drm_fb_helper_cfb_read); + +static ssize_t fb_write_screen_base(struct fb_info *info, const char __user *buf, size_t count, + loff_t pos) +{ + char __iomem *dst = info->screen_base + pos; + size_t alloc_size = min_t(size_t, count, PAGE_SIZE); + ssize_t ret = 0; + int err = 0; + u8 *tmp; + + tmp = kmalloc(alloc_size, GFP_KERNEL); + if (!tmp) + return -ENOMEM; + + while (count) { + size_t c = min_t(size_t, count, alloc_size); + + if (copy_from_user(tmp, buf, c)) { + err = -EFAULT; + break; + } + memcpy_toio(dst, tmp, c); + + dst += c; + buf += c; + ret += c; + count -= c; + } + + kfree(tmp); + + return ret ? ret : err; +} + +/** + * drm_fb_helper_cfb_write - Implements struct &fb_ops.fb_write for I/O memory + * @info: fb_info struct pointer + * @buf: userspace buffer to write to framebuffer memory + * @count: number of bytes to write to framebuffer memory + * @ppos: write offset within framebuffer memory + * + * Returns: + * The number of bytes written on success, or an error code otherwise. + */ +ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf, + size_t count, loff_t *ppos) +{ + loff_t pos = *ppos; + ssize_t ret; + struct drm_rect damage_area; + + ret = __drm_fb_helper_write(info, buf, count, ppos, fb_write_screen_base); + if (ret <= 0) + return ret; + + drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area); + drm_fb_helper_damage(info, damage_area.x1, damage_area.y1, + drm_rect_width(&damage_area), + drm_rect_height(&damage_area)); + + return ret; +} +EXPORT_SYMBOL(drm_fb_helper_cfb_write); + /** * drm_fb_helper_cfb_fillrect - wrapper around cfb_fillrect * @info: fbdev registered by the helper @@ -2183,176 +2398,28 @@ static bool drm_fbdev_use_iomem(struct fb_info *info) return !drm_fbdev_use_shadow_fb(fb_helper) && buffer->map.is_iomem; } -static ssize_t fb_read_screen_base(struct fb_info *info, char __user *buf, size_t count, - loff_t pos) -{ - const char __iomem *src = info->screen_base + pos; - size_t alloc_size = min_t(size_t, count, PAGE_SIZE); - ssize_t ret = 0; - int err = 0; - char *tmp; - - tmp = kmalloc(alloc_size, GFP_KERNEL); - if (!tmp) - return -ENOMEM; - - while (count) { - size_t c = min_t(size_t, count, alloc_size); - - memcpy_fromio(tmp, src, c); - if (copy_to_user(buf, tmp, c)) { - err = -EFAULT; - break; - } - - src += c; - buf += c; - ret += c; - count -= c; - } - - kfree(tmp); - - return ret ? ret : err; -} - -static ssize_t fb_read_screen_buffer(struct fb_info *info, char __user *buf, size_t count, - loff_t pos) -{ - const char *src = info->screen_buffer + pos; - - if (copy_to_user(buf, src, count)) - return -EFAULT; - - return count; -} - static ssize_t drm_fbdev_fb_read(struct fb_info *info, char __user *buf, size_t count, loff_t *ppos) { - loff_t pos = *ppos; - size_t total_size; ssize_t ret; - if (info->screen_size) - total_size = info->screen_size; - else - total_size = info->fix.smem_len; - - if (pos >= total_size) - return 0; - if (count >= total_size) - count = total_size; - if (total_size - count < pos) - count = total_size - pos; - - if (info->fbops->fb_sync) - info->fbops->fb_sync(info); - if (drm_fbdev_use_iomem(info)) - ret = fb_read_screen_base(info, buf, count, pos); + ret = drm_fb_helper_cfb_read(info, buf, count, ppos); else - ret = fb_read_screen_buffer(info, buf, count, pos); - - if (ret > 0) - *ppos += ret; + ret = drm_fb_helper_sys_read(info, buf, count, ppos); return ret; } -static ssize_t fb_write_screen_base(struct fb_info *info, const char __user *buf, size_t count, - loff_t pos) -{ - char __iomem *dst = info->screen_base + pos; - size_t alloc_size = min_t(size_t, count, PAGE_SIZE); - ssize_t ret = 0; - int err = 0; - u8 *tmp; - - tmp = kmalloc(alloc_size, GFP_KERNEL); - if (!tmp) - return -ENOMEM; - - while (count) { - size_t c = min_t(size_t, count, alloc_size); - - if (copy_from_user(tmp, buf, c)) { - err = -EFAULT; - break; - } - memcpy_toio(dst, tmp, c); - - dst += c; - buf += c; - ret += c; - count -= c; - } - - kfree(tmp); - - return ret ? ret : err; -} - -static ssize_t fb_write_screen_buffer(struct fb_info *info, const char __user *buf, size_t count, - loff_t pos) -{ - char *dst = info->screen_buffer + pos; - - if (copy_from_user(dst, buf, count)) - return -EFAULT; - - return count; -} - static ssize_t drm_fbdev_fb_write(struct fb_info *info, const char __user *buf, size_t count, loff_t *ppos) { - loff_t pos = *ppos; - size_t total_size; ssize_t ret; - struct drm_rect damage_area; - int err = 0; - if (info->screen_size) - total_size = info->screen_size; - else - total_size = info->fix.smem_len; - - if (pos > total_size) - return -EFBIG; - if (count > total_size) { - err = -EFBIG; - count = total_size; - } - if (total_size - count < pos) { - if (!err) - err = -ENOSPC; - count = total_size - pos; - } - - if (info->fbops->fb_sync) - info->fbops->fb_sync(info); - - /* - * Copy to framebuffer even if we already logged an error. Emulates - * the behavior of the original fbdev implementation. - */ if (drm_fbdev_use_iomem(info)) - ret = fb_write_screen_base(info, buf, count, pos); + ret = drm_fb_helper_cfb_write(info, buf, count, ppos); else - ret = fb_write_screen_buffer(info, buf, count, pos); - - if (ret < 0) - return ret; /* return last error, if any */ - else if (!ret) - return err; /* return previous error, if any */ - - *ppos += ret; - - drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area); - drm_fb_helper_damage(info, damage_area.x1, damage_area.y1, - drm_rect_width(&damage_area), - drm_rect_height(&damage_area)); + ret = drm_fb_helper_sys_write(info, buf, count, ppos); return ret; } diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index 86c489d945849..55c92372fca04 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -49,6 +49,8 @@ static const struct fb_ops exynos_drm_fb_ops = { .owner = THIS_MODULE, DRM_FB_HELPER_DEFAULT_OPS, .fb_mmap = exynos_drm_fb_mmap, + .fb_read = drm_fb_helper_cfb_read, + .fb_write = drm_fb_helper_cfb_write, .fb_fillrect = drm_fb_helper_cfb_fillrect, .fb_copyarea = drm_fb_helper_cfb_copyarea, .fb_imageblit = drm_fb_helper_cfb_imageblit, diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index 6098d936e44b6..8d5a37b8f1100 100644 --- a/drivers/gpu/drm/gma500/framebuffer.c +++ b/drivers/gpu/drm/gma500/framebuffer.c @@ -147,6 +147,8 @@ static const struct fb_ops psbfb_unaccel_ops = { .owner = THIS_MODULE, DRM_FB_HELPER_DEFAULT_OPS, .fb_setcolreg = psbfb_setcolreg, + .fb_read = drm_fb_helper_cfb_read, + .fb_write = drm_fb_helper_cfb_write, .fb_fillrect = drm_fb_helper_cfb_fillrect, .fb_copyarea = drm_fb_helper_cfb_copyarea, .fb_imageblit = drm_fb_helper_cfb_imageblit, diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c index 1b576c859837b..5575d7abdc092 100644 --- a/drivers/gpu/drm/i915/display/intel_fbdev.c +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c @@ -124,6 +124,8 @@ static const struct fb_ops intelfb_ops = { .owner = THIS_MODULE, DRM_FB_HELPER_DEFAULT_OPS, .fb_set_par = intel_fbdev_set_par, + .fb_read = drm_fb_helper_cfb_read, + .fb_write = drm_fb_helper_cfb_write, .fb_fillrect = drm_fb_helper_cfb_fillrect, .fb_copyarea = drm_fb_helper_cfb_copyarea, .fb_imageblit = drm_fb_helper_cfb_imageblit, diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c index f06fed2030a89..c1710ed1cab83 100644 --- a/drivers/gpu/drm/radeon/radeon_fb.c +++ b/drivers/gpu/drm/radeon/radeon_fb.c @@ -80,6 +80,8 @@ static const struct fb_ops radeonfb_ops = { DRM_FB_HELPER_DEFAULT_OPS, .fb_open = radeonfb_open, .fb_release = radeonfb_release, + .fb_read = drm_fb_helper_cfb_read, + .fb_write = drm_fb_helper_cfb_write, .fb_fillrect = drm_fb_helper_cfb_fillrect, .fb_copyarea = drm_fb_helper_cfb_copyarea, .fb_imageblit = drm_fb_helper_cfb_imageblit, diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index 84b7f1dd9fb57..a900300ae5bdc 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @@ -206,6 +206,8 @@ static int tegra_fb_mmap(struct fb_info *info, struct vm_area_struct *vma) static const struct fb_ops tegra_fb_ops = { .owner = THIS_MODULE, DRM_FB_HELPER_DEFAULT_OPS, + .fb_read = drm_fb_helper_sys_read, + .fb_write = drm_fb_helper_sys_write, .fb_fillrect = drm_fb_helper_sys_fillrect, .fb_copyarea = drm_fb_helper_sys_copyarea, .fb_imageblit = drm_fb_helper_sys_imageblit, diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 3d7a3d68dab8a..6581183618b89 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -257,6 +257,11 @@ void drm_fb_helper_sys_copyarea(struct fb_info *info, void drm_fb_helper_sys_imageblit(struct fb_info *info, const struct fb_image *image); +ssize_t drm_fb_helper_cfb_read(struct fb_info *info, char __user *buf, + size_t count, loff_t *ppos); +ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf, + size_t count, loff_t *ppos); + void drm_fb_helper_cfb_fillrect(struct fb_info *info, const struct fb_fillrect *rect); void drm_fb_helper_cfb_copyarea(struct fb_info *info, @@ -402,6 +407,18 @@ static inline void drm_fb_helper_sys_imageblit(struct fb_info *info, { } +static inline ssize_t drm_fb_helper_cfb_read(struct fb_info *info, char __user *buf, + size_t count, loff_t *ppos) +{ + return -ENODEV; +} + +static inline ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf, + size_t count, loff_t *ppos) +{ + return -ENODEV; +} + static inline void drm_fb_helper_cfb_fillrect(struct fb_info *info, const struct fb_fillrect *rect) { -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:15:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:15:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436648.690906 (Exim 4.92) (envelope-from ) id 1oqbw4-0007YA-Ky; Thu, 03 Nov 2022 15:15:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436648.690906; Thu, 03 Nov 2022 15:15:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbw4-0007Pn-21; Thu, 03 Nov 2022 15:15:16 +0000 Received: by outflank-mailman (input) for mailman id 436648; Thu, 03 Nov 2022 15:15:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvr-0001nI-3q for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:15:03 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46e9d797-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:57 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 53B241F8EF; Thu, 3 Nov 2022 15:14:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C126013AAF; Thu, 3 Nov 2022 15:14:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uGieLPLaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46e9d797-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6vZDLOJd6MhABJ+xWbcToVn7E+N8T6jjqOm5hhU1vcE=; b=yti9r2qWk9MpHeMKTVrTMsnHKmzs8r+WSILqoCaZXPgCYKo3JnU+BAsP+TuN/aPI5uwdMK HvGlepxAFJWH/SUvWHhKbVoa/ldyIVEi8Xs3FEzrkEjof9lErKuo1XrDINe4NXuwjSekIW jVZSiu0fEpk7WQwyTdPfVeWnQY832A4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6vZDLOJd6MhABJ+xWbcToVn7E+N8T6jjqOm5hhU1vcE=; b=2ajT4ujFWhdm3DtOFuj2efRbCkmjwPhuuTSrUUsdxA2jpJJ/72DvyMCD42cLpJ0XRfHVR3 MgsQNmAGVakNH3Bw== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 18/23] drm/fb_helper: Minimize damage-helper overhead Date: Thu, 3 Nov 2022 16:14:41 +0100 Message-Id: <20221103151446.2638-19-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Pull the test for fb_dirty into the caller to avoid extra work if no callback has been set. In this case no damage handling is required and no damage area needs to be computed. Print a warning if the damage worker runs without getting an fb_dirty callback. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fb_helper.c | 90 ++++++++++++++++++++++----------- 1 file changed, 60 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index c7c0c0a8532b4..3dfda1e3830b3 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -449,12 +449,13 @@ static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper, static void drm_fb_helper_damage_work(struct work_struct *work) { struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work); + struct drm_device *dev = helper->dev; struct drm_clip_rect *clip = &helper->damage_clip; struct drm_clip_rect clip_copy; unsigned long flags; int ret; - if (!helper->funcs->fb_dirty) + if (drm_WARN_ON_ONCE(dev, !helper->funcs->fb_dirty)) return; spin_lock_irqsave(&helper->damage_lock, flags); @@ -659,16 +660,12 @@ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper) } EXPORT_SYMBOL(drm_fb_helper_fini); -static void drm_fb_helper_damage(struct fb_info *info, u32 x, u32 y, +static void drm_fb_helper_damage(struct drm_fb_helper *helper, u32 x, u32 y, u32 width, u32 height) { - struct drm_fb_helper *helper = info->par; struct drm_clip_rect *clip = &helper->damage_clip; unsigned long flags; - if (!helper->funcs->fb_dirty) - return; - spin_lock_irqsave(&helper->damage_lock, flags); clip->x1 = min_t(u32, clip->x1, x); clip->y1 = min_t(u32, clip->y1, y); @@ -718,6 +715,7 @@ static void drm_fb_helper_memory_range_to_clip(struct fb_info *info, off_t off, */ void drm_fb_helper_deferred_io(struct fb_info *info, struct list_head *pagereflist) { + struct drm_fb_helper *helper = info->par; unsigned long start, end, min_off, max_off; struct fb_deferred_io_pageref *pageref; struct drm_rect damage_area; @@ -733,17 +731,19 @@ void drm_fb_helper_deferred_io(struct fb_info *info, struct list_head *pagerefli if (min_off >= max_off) return; - /* - * As we can only track pages, we might reach beyond the end - * of the screen and account for non-existing scanlines. Hence, - * keep the covered memory area within the screen buffer. - */ - max_off = min(max_off, info->screen_size); + if (helper->funcs->fb_dirty) { + /* + * As we can only track pages, we might reach beyond the end + * of the screen and account for non-existing scanlines. Hence, + * keep the covered memory area within the screen buffer. + */ + max_off = min(max_off, info->screen_size); - drm_fb_helper_memory_range_to_clip(info, min_off, max_off - min_off, &damage_area); - drm_fb_helper_damage(info, damage_area.x1, damage_area.y1, - drm_rect_width(&damage_area), - drm_rect_height(&damage_area)); + drm_fb_helper_memory_range_to_clip(info, min_off, max_off - min_off, &damage_area); + drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1, + drm_rect_width(&damage_area), + drm_rect_height(&damage_area)); + } } EXPORT_SYMBOL(drm_fb_helper_deferred_io); @@ -877,6 +877,7 @@ static ssize_t drm_fb_helper_write_screen_buffer(struct fb_info *info, const cha ssize_t drm_fb_helper_sys_write(struct fb_info *info, const char __user *buf, size_t count, loff_t *ppos) { + struct drm_fb_helper *helper = info->par; loff_t pos = *ppos; ssize_t ret; struct drm_rect damage_area; @@ -885,10 +886,12 @@ ssize_t drm_fb_helper_sys_write(struct fb_info *info, const char __user *buf, if (ret <= 0) return ret; - drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area); - drm_fb_helper_damage(info, damage_area.x1, damage_area.y1, - drm_rect_width(&damage_area), - drm_rect_height(&damage_area)); + if (helper->funcs->fb_dirty) { + drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area); + drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1, + drm_rect_width(&damage_area), + drm_rect_height(&damage_area)); + } return ret; } @@ -904,8 +907,12 @@ EXPORT_SYMBOL(drm_fb_helper_sys_write); void drm_fb_helper_sys_fillrect(struct fb_info *info, const struct fb_fillrect *rect) { + struct drm_fb_helper *helper = info->par; + sys_fillrect(info, rect); - drm_fb_helper_damage(info, rect->dx, rect->dy, rect->width, rect->height); + + if (helper->funcs->fb_dirty) + drm_fb_helper_damage(helper, rect->dx, rect->dy, rect->width, rect->height); } EXPORT_SYMBOL(drm_fb_helper_sys_fillrect); @@ -919,8 +926,12 @@ EXPORT_SYMBOL(drm_fb_helper_sys_fillrect); void drm_fb_helper_sys_copyarea(struct fb_info *info, const struct fb_copyarea *area) { + struct drm_fb_helper *helper = info->par; + sys_copyarea(info, area); - drm_fb_helper_damage(info, area->dx, area->dy, area->width, area->height); + + if (helper->funcs->fb_dirty) + drm_fb_helper_damage(helper, area->dx, area->dy, area->width, area->height); } EXPORT_SYMBOL(drm_fb_helper_sys_copyarea); @@ -934,8 +945,12 @@ EXPORT_SYMBOL(drm_fb_helper_sys_copyarea); void drm_fb_helper_sys_imageblit(struct fb_info *info, const struct fb_image *image) { + struct drm_fb_helper *helper = info->par; + sys_imageblit(info, image); - drm_fb_helper_damage(info, image->dx, image->dy, image->width, image->height); + + if (helper->funcs->fb_dirty) + drm_fb_helper_damage(helper, image->dx, image->dy, image->width, image->height); } EXPORT_SYMBOL(drm_fb_helper_sys_imageblit); @@ -1035,6 +1050,7 @@ static ssize_t fb_write_screen_base(struct fb_info *info, const char __user *buf ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf, size_t count, loff_t *ppos) { + struct drm_fb_helper *helper = info->par; loff_t pos = *ppos; ssize_t ret; struct drm_rect damage_area; @@ -1043,10 +1059,12 @@ ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf, if (ret <= 0) return ret; - drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area); - drm_fb_helper_damage(info, damage_area.x1, damage_area.y1, - drm_rect_width(&damage_area), - drm_rect_height(&damage_area)); + if (helper->funcs->fb_dirty) { + drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area); + drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1, + drm_rect_width(&damage_area), + drm_rect_height(&damage_area)); + } return ret; } @@ -1062,8 +1080,12 @@ EXPORT_SYMBOL(drm_fb_helper_cfb_write); void drm_fb_helper_cfb_fillrect(struct fb_info *info, const struct fb_fillrect *rect) { + struct drm_fb_helper *helper = info->par; + cfb_fillrect(info, rect); - drm_fb_helper_damage(info, rect->dx, rect->dy, rect->width, rect->height); + + if (helper->funcs->fb_dirty) + drm_fb_helper_damage(helper, rect->dx, rect->dy, rect->width, rect->height); } EXPORT_SYMBOL(drm_fb_helper_cfb_fillrect); @@ -1077,8 +1099,12 @@ EXPORT_SYMBOL(drm_fb_helper_cfb_fillrect); void drm_fb_helper_cfb_copyarea(struct fb_info *info, const struct fb_copyarea *area) { + struct drm_fb_helper *helper = info->par; + cfb_copyarea(info, area); - drm_fb_helper_damage(info, area->dx, area->dy, area->width, area->height); + + if (helper->funcs->fb_dirty) + drm_fb_helper_damage(helper, area->dx, area->dy, area->width, area->height); } EXPORT_SYMBOL(drm_fb_helper_cfb_copyarea); @@ -1092,8 +1118,12 @@ EXPORT_SYMBOL(drm_fb_helper_cfb_copyarea); void drm_fb_helper_cfb_imageblit(struct fb_info *info, const struct fb_image *image) { + struct drm_fb_helper *helper = info->par; + cfb_imageblit(info, image); - drm_fb_helper_damage(info, image->dx, image->dy, image->width, image->height); + + if (helper->funcs->fb_dirty) + drm_fb_helper_damage(helper, image->dx, image->dy, image->width, image->height); } EXPORT_SYMBOL(drm_fb_helper_cfb_imageblit); -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:15:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:15:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436650.690917 (Exim 4.92) (envelope-from ) id 1oqbw7-0008G5-9y; Thu, 03 Nov 2022 15:15:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436650.690917; Thu, 03 Nov 2022 15:15:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbw6-0008E3-VN; Thu, 03 Nov 2022 15:15:18 +0000 Received: by outflank-mailman (input) for mailman id 436650; Thu, 03 Nov 2022 15:15:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvp-0001nI-1f for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:15:01 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 455fbdce-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:54 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BAF951F8E3; Thu, 3 Nov 2022 15:14:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2AA7D13AAF; Thu, 3 Nov 2022 15:14:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ODSeCfDaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 455fbdce-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488496; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wHcFkkZx1qoGdGGw38npsZkDf9XLCcAsw1vgXHR4r9c=; b=JjKJvPB/qRxKFqHw1U29m8E0cvnmPyoVHeFthkW29kVOhRff3GnqHoT9ZnKa3/sivEaGXh VOQwtx0dSXP6U9JvE7ppy/DRynLmaN1iOy3pkD+FIkbYM4FO5N8QlDA3LoBVEbAX76UeTZ vRY3ONng4s4TK13tL5edjEkAID1cq2Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488496; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wHcFkkZx1qoGdGGw38npsZkDf9XLCcAsw1vgXHR4r9c=; b=pk7M7BuDJ2aVjhDvwzYotWXbDwSdhZPVztKaVdlIARFwx0azBKAE2llyca8r3FB5fcJLPo BNqw90S8fBCoZ9Cg== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 14/23] drm/fb-helper: Rename drm_fb_helper_unregister_fbi() to use _info postfix Date: Thu, 3 Nov 2022 16:14:37 +0100 Message-Id: <20221103151446.2638-15-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rename drm_fb_helper_unregister_fbi() to drm_fb_helper_unregister_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/drm_fb_helper.c | 8 ++++---- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +- drivers/gpu/drm/gma500/framebuffer.c | 2 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +- drivers/gpu/drm/msm/msm_fbdev.c | 2 +- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 2 +- drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +- drivers/gpu/drm/radeon/radeon_fb.c | 2 +- drivers/gpu/drm/tegra/fb.c | 2 +- include/drm/drm_fb_helper.h | 4 ++-- 11 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c index eaae98d9377ae..f02f6a5ba8320 100644 --- a/drivers/gpu/drm/armada/armada_fbdev.c +++ b/drivers/gpu/drm/armada/armada_fbdev.c @@ -155,7 +155,7 @@ void armada_fbdev_fini(struct drm_device *dev) struct drm_fb_helper *fbh = priv->fbdev; if (fbh) { - drm_fb_helper_unregister_fbi(fbh); + drm_fb_helper_unregister_info(fbh); drm_fb_helper_fini(fbh); diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 881e6a04fa706..bfbb2af144060 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -612,19 +612,19 @@ struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper) EXPORT_SYMBOL(drm_fb_helper_alloc_info); /** - * drm_fb_helper_unregister_fbi - unregister fb_info framebuffer device + * drm_fb_helper_unregister_info - unregister fb_info framebuffer device * @fb_helper: driver-allocated fbdev helper, can be NULL * * A wrapper around unregister_framebuffer, to release the fb_info * framebuffer device. This must be called before releasing all resources for * @fb_helper by calling drm_fb_helper_fini(). */ -void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper) +void drm_fb_helper_unregister_info(struct drm_fb_helper *fb_helper) { if (fb_helper && fb_helper->info) unregister_framebuffer(fb_helper->info); } -EXPORT_SYMBOL(drm_fb_helper_unregister_fbi); +EXPORT_SYMBOL(drm_fb_helper_unregister_info); /** * drm_fb_helper_fini - finialize a &struct drm_fb_helper @@ -2497,7 +2497,7 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client) if (fb_helper->info) /* drm_fbdev_fb_destroy() takes care of cleanup */ - drm_fb_helper_unregister_fbi(fb_helper); + drm_fb_helper_unregister_info(fb_helper); else drm_fbdev_release(fb_helper); } diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index 8741eb0b1b604..86c489d945849 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -201,7 +201,7 @@ static void exynos_drm_fbdev_destroy(struct drm_device *dev, drm_framebuffer_remove(fb); } - drm_fb_helper_unregister_fbi(fb_helper); + drm_fb_helper_unregister_info(fb_helper); drm_fb_helper_fini(fb_helper); } diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index 6d0e3bf6435ee..6098d936e44b6 100644 --- a/drivers/gpu/drm/gma500/framebuffer.c +++ b/drivers/gpu/drm/gma500/framebuffer.c @@ -383,7 +383,7 @@ static int psb_fbdev_destroy(struct drm_device *dev, { struct drm_framebuffer *fb = fb_helper->fb; - drm_fb_helper_unregister_fbi(fb_helper); + drm_fb_helper_unregister_info(fb_helper); drm_fb_helper_fini(fb_helper); drm_framebuffer_unregister_private(fb); diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c index 05b841343ea3e..1b576c859837b 100644 --- a/drivers/gpu/drm/i915/display/intel_fbdev.c +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c @@ -584,7 +584,7 @@ void intel_fbdev_unregister(struct drm_i915_private *dev_priv) if (!current_is_async()) intel_fbdev_sync(ifbdev); - drm_fb_helper_unregister_fbi(&ifbdev->helper); + drm_fb_helper_unregister_info(&ifbdev->helper); } void intel_fbdev_fini(struct drm_i915_private *dev_priv) diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c index 4d9a0fcbf95b6..31e1e30cb52a2 100644 --- a/drivers/gpu/drm/msm/msm_fbdev.c +++ b/drivers/gpu/drm/msm/msm_fbdev.c @@ -182,7 +182,7 @@ void msm_fbdev_free(struct drm_device *dev) DBG(); - drm_fb_helper_unregister_fbi(helper); + drm_fb_helper_unregister_info(helper); drm_fb_helper_fini(helper); diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index fca40124fc17c..e87de7906f780 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c @@ -419,7 +419,7 @@ nouveau_fbcon_destroy(struct drm_device *dev, struct nouveau_fbdev *fbcon) struct drm_framebuffer *fb = fbcon->helper.fb; struct nouveau_bo *nvbo; - drm_fb_helper_unregister_fbi(&fbcon->helper); + drm_fb_helper_unregister_info(&fbcon->helper); drm_fb_helper_fini(&fbcon->helper); if (fb && fb->obj[0]) { diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c index ab30c64e97043..98d8758048fc1 100644 --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c @@ -272,7 +272,7 @@ void omap_fbdev_fini(struct drm_device *dev) if (!helper) return; - drm_fb_helper_unregister_fbi(helper); + drm_fb_helper_unregister_info(helper); drm_fb_helper_fini(helper); diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c index 0c6a227929db2..f06fed2030a89 100644 --- a/drivers/gpu/drm/radeon/radeon_fb.c +++ b/drivers/gpu/drm/radeon/radeon_fb.c @@ -309,7 +309,7 @@ static int radeon_fbdev_destroy(struct drm_device *dev, struct radeon_fbdev *rfb { struct drm_framebuffer *fb = &rfbdev->fb; - drm_fb_helper_unregister_fbi(&rfbdev->helper); + drm_fb_helper_unregister_info(&rfbdev->helper); if (fb->obj[0]) { radeonfb_destroy_pinned_object(fb->obj[0]); diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index a09c071f35120..84b7f1dd9fb57 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @@ -347,7 +347,7 @@ static int tegra_fbdev_init(struct tegra_fbdev *fbdev, static void tegra_fbdev_exit(struct tegra_fbdev *fbdev) { - drm_fb_helper_unregister_fbi(&fbdev->base); + drm_fb_helper_unregister_info(&fbdev->base); if (fbdev->fb) { struct tegra_bo *bo = tegra_fb_get_plane(fbdev->fb, 0); diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 5ec9d9c68d144..edc697a2fde24 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -223,7 +223,7 @@ int drm_fb_helper_check_var(struct fb_var_screeninfo *var, int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper); struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper); -void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper); +void drm_fb_helper_unregister_info(struct drm_fb_helper *fb_helper); void drm_fb_helper_fill_info(struct fb_info *info, struct drm_fb_helper *fb_helper, struct drm_fb_helper_surface_size *sizes); @@ -325,7 +325,7 @@ drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper) return NULL; } -static inline void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper) +static inline void drm_fb_helper_unregister_info(struct drm_fb_helper *fb_helper) { } -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:15:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:15:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436653.690930 (Exim 4.92) (envelope-from ) id 1oqbwD-0001R0-MK; Thu, 03 Nov 2022 15:15:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436653.690930; Thu, 03 Nov 2022 15:15:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbwD-0001PV-G2; Thu, 03 Nov 2022 15:15:25 +0000 Received: by outflank-mailman (input) for mailman id 436653; Thu, 03 Nov 2022 15:15:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbwC-00018W-9U; Thu, 03 Nov 2022 15:15:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbwC-000636-55; Thu, 03 Nov 2022 15:15:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbwB-0000cH-IY; Thu, 03 Nov 2022 15:15:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqbwB-0000ls-Hr; Thu, 03 Nov 2022 15:15:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HpTI8ikwGwPqSasvEgiZMTNRs48muFAhOzB98Dh39sw=; b=keWWO26WZBMSt94qxnklJcE4Bp jC6jfDYpRDFr0SC0AXfy43ovXrbq2qPCTGUhv5VssJ05DVLnsHFT+dAzoawYQ7/XmVz7YkGy10fKK 6J6KdyxrJLuVPjpoRQHUpiNXI33sCGY+moBOFhgJh+ZXqviVeFGowsQW6z44kROk6Nog=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174597: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0751a75e3996cf6efd3925a90b4776660d8df2bc X-Osstest-Versions-That: xen=2dd823ca7237e7fb90c890642d6a3b357a26fcff From: osstest service owner Date: Thu, 03 Nov 2022 15:15:23 +0000 flight 174597 xen-unstable real [real] flight 174604 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174597/ http://logs.test-lab.xenproject.org/osstest/logs/174604/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 174586 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174604-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174574 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174586 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174586 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174586 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174586 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174586 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174586 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174586 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174586 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174586 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174586 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174586 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 0751a75e3996cf6efd3925a90b4776660d8df2bc baseline version: xen 2dd823ca7237e7fb90c890642d6a3b357a26fcff Last test of basis 174586 2022-11-02 12:11:56 Z 1 days Testing same since 174597 2022-11-03 04:07:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Juergen Gross Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 0751a75e3996cf6efd3925a90b4776660d8df2bc Author: Juergen Gross Date: Wed Nov 2 12:08:22 2022 +0100 tools/xenstore: call remove_domid_from_perm() for special nodes When destroying a domain, any stale permissions of the domain must be removed from the special nodes "@...", too. This was not done in the fix for XSA-322. Fixes: 496306324d8d ("tools/xenstore: revoke access rights for removed domains") Signed-off-by: Juergen Gross Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 1283af6465cd14934e89a088f8abef577d013761 Author: Juergen Gross Date: Wed Nov 2 12:07:57 2022 +0100 tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR XEN_LIB_STORED is serving no real purpose, as it is a mount point for a tmpfs, so it can be replaced easily by XEN_RUN_STORED. XENSTORED_ROOTDIR is basically unused already, there is just a single reference in xs_daemon_rootdir() with a fallback to XEN_LIB_STORED, and a .gdbinit file setting it. Remove the .gdbinit file, as it is not known having been used since ages, and make xs_daemon_rootdir() an alias of xs_daemon_rundir(). Reported-by: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Andrew Cooper Release-acked-by: Henry Wang commit 0d251a1dd15f9c406de2d7d7fe018c4e6e454215 Author: Roger Pau Monné Date: Wed Nov 2 12:06:37 2022 +0100 hvm/msr: load VIRT_SPEC_CTRL Add MSR_VIRT_SPEC_CTRL to the list of MSRs handled by hvm_load_cpu_msrs(), or else it would be lost. Fixes: 8ffd5496f4 ('amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL') Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:15:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:15:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436656.690940 (Exim 4.92) (envelope-from ) id 1oqbwI-0002Sb-IL; Thu, 03 Nov 2022 15:15:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436656.690940; Thu, 03 Nov 2022 15:15:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbwI-0002SF-E5; Thu, 03 Nov 2022 15:15:30 +0000 Received: by outflank-mailman (input) for mailman id 436656; Thu, 03 Nov 2022 15:15:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvt-0001nI-2I for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:15:05 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 478b8c1f-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:58 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 65D8E1F8F3; Thu, 3 Nov 2022 15:15:00 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DAEFB13AAF; Thu, 3 Nov 2022 15:14:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kA2nM/PaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 478b8c1f-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488500; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wr52WabQn4KK+bwhCdJXRXC0GHxQRZf3tOH2OwXrlI4=; b=2IHU9odfZVC/BEosd5kYe2nSLZ0DFNgEeVXJI5zLv+JKV2wN30OSjGQ+p+oRUTcnBI+aSY pkhdYXovwCXBs4Bkt8vaHgMYWDzvbQSgHd0WfjuIdzacDrsUKfmLPmD7qtna79oEsJ6XuK jJL/sse9X2zXCpuZbC6pTPqYFUYFoHo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488500; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wr52WabQn4KK+bwhCdJXRXC0GHxQRZf3tOH2OwXrlI4=; b=3Zy/+KY1PXJuswjeMIT6ebHMi8zktn+cASefhirMXLxQQC/cH2yhbAYxRTqiOd8n2gteRF me+3Ej2BR8ugj7AQ== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 20/23] drm/fb-helper: Set flag in struct drm_fb_helper for leaking physical addresses Date: Thu, 3 Nov 2022 16:14:43 +0100 Message-Id: <20221103151446.2638-21-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Uncouple the parameter drm_leak_fbdev_smem from the implementation by setting a flag in struct drm_fb_helper. This will help to move the generic fbdev emulation into its own source file, while keeping the parameter in drm_fb_helper.c. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 10 +++++++--- include/drm/drm_fb_helper.h | 2 ++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 95f389433c4a6..105d9c8fe3250 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -74,7 +74,7 @@ MODULE_PARM_DESC(drm_fbdev_overalloc, * considered as a broken and legacy behaviour from a modern fbdev device. */ #if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM) -static bool drm_leak_fbdev_smem = false; +static bool drm_leak_fbdev_smem; module_param_unsafe(drm_leak_fbdev_smem, bool, 0600); MODULE_PARM_DESC(drm_leak_fbdev_smem, "Allow unsafe leaking fbdev physical smem address [default=false]"); @@ -1968,6 +1968,10 @@ static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper, sizes.surface_height = config->max_height; } +#if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM) + fb_helper->hint_leak_smem_start = drm_leak_fbdev_smem; +#endif + /* push down into drivers */ ret = (*fb_helper->funcs->fb_probe)(fb_helper, &sizes); if (ret < 0) @@ -2165,7 +2169,7 @@ __drm_fb_helper_initial_config_and_unlock(struct drm_fb_helper *fb_helper, info->var.pixclock = 0; /* Shamelessly allow physical address leaking to userspace */ #if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM) - if (!drm_leak_fbdev_smem) + if (!fb_helper->hint_leak_smem_start) #endif /* don't leak any physical addresses to userspace */ info->flags |= FBINFO_HIDE_SMEM_START; @@ -2564,7 +2568,7 @@ static int drm_fb_helper_generic_probe(struct drm_fb_helper *fb_helper, * case. */ #if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM) - if (drm_leak_fbdev_smem && fbi->fix.smem_start == 0 && + if (fb_helper->hint_leak_smem_start && fbi->fix.smem_start == 0 && !drm_WARN_ON_ONCE(dev, map.is_iomem)) fbi->fix.smem_start = page_to_phys(virt_to_page(fbi->screen_buffer)); diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 6581183618b89..3dfb5d1093871 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -199,6 +199,8 @@ struct drm_fb_helper { * See also: @deferred_setup */ int preferred_bpp; + + bool hint_leak_smem_start; }; static inline struct drm_fb_helper * -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:15:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:15:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436657.690952 (Exim 4.92) (envelope-from ) id 1oqbwL-0003GK-Uq; Thu, 03 Nov 2022 15:15:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436657.690952; Thu, 03 Nov 2022 15:15:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbwL-0003Fv-PT; Thu, 03 Nov 2022 15:15:33 +0000 Received: by outflank-mailman (input) for mailman id 436657; Thu, 03 Nov 2022 15:15:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvq-0001nI-2W for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:15:02 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46242308-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:56 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0FB361F8ED; Thu, 3 Nov 2022 15:14:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6614913AAF; Thu, 3 Nov 2022 15:14:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GBP+F/HaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46242308-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488498; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Rdbs1K7PrH8FqVsteDFsz2Pg6HAnz17D2gSGEJwptg=; b=1QzEPzAu/XO9DJ7+I1Ls8u6iVJBqVfE0RfLcCGHCvzFb6nbQG7y/8DBvVDIcFJv1lnC+hZ VFTTseMsIGFGbvg8BElx17Rw50wWqUakn6xd0cxmAnfTlDeZZ0lw1h6Wt06aRSUVnZwveH he9C374VbO9S3fUtNy62s5HXA9q9xCo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488498; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Rdbs1K7PrH8FqVsteDFsz2Pg6HAnz17D2gSGEJwptg=; b=f8pZPqG9V3vdxDoWdtzuNcpX0gB4bZkuJ5Drjrd7WuBVLUdk/140+GTeZY398tPnBeuus7 WLY+csOh/CkEJuAA== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 16/23] drm/fb-helper: Call fb_sync in I/O functions Date: Thu, 3 Nov 2022 16:14:39 +0100 Message-Id: <20221103151446.2638-17-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Call struct fb_ops.fb_sync in drm_fbdev_{read,write}() to mimic the behavior of fbdev. Fbdev implementations of fb_read and fb_write in struct fb_ops invoke fb_sync to synchronize with outstanding operations before I/O. Doing the same in DRM implementations will allow us to use them throughout DRM drivers. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fb_helper.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index f6d22cc4cd876..379e0d2f67198 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -2246,6 +2246,9 @@ static ssize_t drm_fbdev_fb_read(struct fb_info *info, char __user *buf, if (total_size - count < pos) count = total_size - pos; + if (info->fbops->fb_sync) + info->fbops->fb_sync(info); + if (drm_fbdev_use_iomem(info)) ret = fb_read_screen_base(info, buf, count, pos); else @@ -2327,6 +2330,9 @@ static ssize_t drm_fbdev_fb_write(struct fb_info *info, const char __user *buf, count = total_size - pos; } + if (info->fbops->fb_sync) + info->fbops->fb_sync(info); + /* * Copy to framebuffer even if we already logged an error. Emulates * the behavior of the original fbdev implementation. -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:15:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:15:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436658.690962 (Exim 4.92) (envelope-from ) id 1oqbwN-0003gz-B6; Thu, 03 Nov 2022 15:15:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436658.690962; Thu, 03 Nov 2022 15:15:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbwN-0003gI-6I; Thu, 03 Nov 2022 15:15:35 +0000 Received: by outflank-mailman (input) for mailman id 436658; Thu, 03 Nov 2022 15:15:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvs-0001nI-2R for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:15:04 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4737053f-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:57 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D1F3C21E06; Thu, 3 Nov 2022 15:14:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 55B7F13ADB; Thu, 3 Nov 2022 15:14:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OMwZFPPaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:14:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4737053f-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UVBxH0SCO//07QUQ6EK/LfA90pQs6KDqJ9dD5J474xM=; b=yvt0gOxB2lenOEStb/UiJX1DHn3g2kKsI7mtE4SGpNQSAhB7lYBWctzlz1reFVQJV5Q7Dr 9KtiNP07UesIRoJkQ20OBX+QffIA0guywKHcw8bFrTEd942EgwbZfJYBXbqYb3+CHu7FpM 9uqeHjGX+09FJKRvQbcgI46xl268Eu8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UVBxH0SCO//07QUQ6EK/LfA90pQs6KDqJ9dD5J474xM=; b=JgfauNgkk7JwnVqiJlezA/GaUozyirPiPZWwmsrpZSHazdzqxSROAFO3R1veLQkMRJ/Bf/ B6Qfs11b1jHuJuBQ== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 19/23] drm/fb-helper: Always initialize generic fbdev emulation Date: Thu, 3 Nov 2022 16:14:42 +0100 Message-Id: <20221103151446.2638-20-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Initialize the generic fbdev emulation even if it has been disabled on the kernel command line. The hotplug and mode initialization will fail accordingly. The kernel parameter can still be changed at runtime and the emulation will initialize after hotplugging the connector. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fb_helper.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 3dfda1e3830b3..95f389433c4a6 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -526,11 +526,6 @@ int drm_fb_helper_init(struct drm_device *dev, { int ret; - if (!drm_fbdev_emulation) { - dev->fb_helper = fb_helper; - return 0; - } - /* * If this is not the generic fbdev client, initialize a drm_client * without callbacks so we can use the modesets. @@ -2716,9 +2711,6 @@ void drm_fbdev_generic_setup(struct drm_device *dev, drm_WARN(dev, !dev->registered, "Device has not been registered.\n"); drm_WARN(dev, dev->fb_helper, "fb_helper is already set!\n"); - if (!drm_fbdev_emulation) - return; - fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL); if (!fb_helper) { drm_err(dev, "Failed to allocate fb_helper\n"); -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:22:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:22:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436681.690974 (Exim 4.92) (envelope-from ) id 1oqc2r-0007Tr-81; Thu, 03 Nov 2022 15:22:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436681.690974; Thu, 03 Nov 2022 15:22:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqc2r-0007Tk-3I; Thu, 03 Nov 2022 15:22:17 +0000 Received: by outflank-mailman (input) for mailman id 436681; Thu, 03 Nov 2022 15:22:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqc2q-0007Ta-1e; Thu, 03 Nov 2022 15:22:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqc2p-0006G9-Ub; Thu, 03 Nov 2022 15:22:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqc2p-0000p1-Jl; Thu, 03 Nov 2022 15:22:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqc2p-00030H-Iq; Thu, 03 Nov 2022 15:22:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8xkgavQ85CNBFtnBncncO4jBKsy8P36yEgb3Br8wSwo=; b=zIRNc0tvlrg9NA4Kc6vNQmSdtP FkhjRvKwAMC5kCtMpePvadxbFDw/8kGySD8/UtPmlPe/gO2FV3+p9gxtIJRq0AVG7z7he52eTyYUI IYIgmGJpp0ziNzNYjl8OtJmBCoUS+LZ/moNTAJoY1GVUltrHI+UDhKAzWRBCa3djHBbE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174598: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=a607baf65a66491d5bcbca1e3fa4e672a9ec8611 X-Osstest-Versions-That: libvirt=72d4709ab901dd3699d342f15ca3aff9bffddf96 From: osstest service owner Date: Thu, 03 Nov 2022 15:22:15 +0000 flight 174598 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174598/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174549 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174549 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174549 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt a607baf65a66491d5bcbca1e3fa4e672a9ec8611 baseline version: libvirt 72d4709ab901dd3699d342f15ca3aff9bffddf96 Last test of basis 174549 2022-10-31 04:18:59 Z 3 days Failing since 174578 2022-11-02 04:20:17 Z 1 days 2 attempts Testing same since 174598 2022-11-03 04:18:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Han Han Jiri Denemark Michal Privoznik Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 72d4709ab9..a607baf65a a607baf65a66491d5bcbca1e3fa4e672a9ec8611 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:25:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:25:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436721.690989 (Exim 4.92) (envelope-from ) id 1oqc5w-0008SR-QG; Thu, 03 Nov 2022 15:25:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436721.690989; Thu, 03 Nov 2022 15:25:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqc5w-0008SK-KN; Thu, 03 Nov 2022 15:25:28 +0000 Received: by outflank-mailman (input) for mailman id 436721; Thu, 03 Nov 2022 15:25:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvv-0001nI-3J for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:15:07 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 48546afb-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:59 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ADBCA21E0F; Thu, 3 Nov 2022 15:15:01 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2463D13ADB; Thu, 3 Nov 2022 15:15:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sNoICPXaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:15:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48546afb-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tKKDgnAGRekThl+Kef4OIp3bhWwiXQhMBkwOIt4sJLE=; b=qcoaEe5YDt/TSoDF9LlZD6Ng+7gD76PPx58VoLgyC2ai3047WiYzO6VG3UqAQIKy3YKHXg REz70h7mZR412dIJJPtt6KeG1I2HUyUb1PBRsZuXjXfuKD9CPq7uVKM+mBw35lKrclD5/3 d/CmcLsUtt54A7ePpp2jBuYDLUuRSlM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tKKDgnAGRekThl+Kef4OIp3bhWwiXQhMBkwOIt4sJLE=; b=vNkdqKAyelvn3nPdMe6vc+09jji6Lk7jXBt2wG5SEJu98SaBJt2CYv2mNsp1sZeqm7L53F HQNJ4nEa4KQxHwDA== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 22/23] drm/fb-helper: Remove unnecessary include statements Date: Thu, 3 Nov 2022 16:14:45 +0100 Message-Id: <20221103151446.2638-23-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove include statements for where it is not required (i.e., most of them). In a few places include other header files that are required by the source code. v3: * fix amdgpu include statements * fix rockchip include statements Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 - drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 1 + drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 1 + drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 1 + drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 1 + drivers/gpu/drm/arm/hdlcd_crtc.c | 1 - drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/drm/bridge/tc358762.c | 2 +- drivers/gpu/drm/drm_crtc_helper.c | 1 - drivers/gpu/drm/drm_gem_framebuffer_helper.c | 1 - drivers/gpu/drm/drm_probe_helper.c | 1 - drivers/gpu/drm/etnaviv/etnaviv_drv.h | 3 ++- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 1 - drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 1 - drivers/gpu/drm/imx/imx-ldb.c | 2 +- drivers/gpu/drm/imx/imx-tve.c | 1 - drivers/gpu/drm/imx/parallel-display.c | 2 +- drivers/gpu/drm/kmb/kmb_plane.c | 1 - drivers/gpu/drm/mgag200/mgag200_drv.h | 1 - drivers/gpu/drm/qxl/qxl_drv.h | 1 - drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 + drivers/gpu/drm/tidss/tidss_kms.c | 1 - drivers/gpu/drm/v3d/v3d_drv.c | 1 - drivers/gpu/drm/vboxvideo/vbox_main.c | 1 - drivers/gpu/drm/virtio/virtgpu_drv.h | 1 - drivers/gpu/drm/xen/xen_drm_front_gem.c | 1 - 31 files changed, 14 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c index 491d4846fc02c..e1320edfc5274 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c @@ -26,7 +26,6 @@ #include #include -#include #include #include #include "amdgpu.h" diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index ddaecb2610c94..56a031a2e087e 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -37,6 +37,7 @@ #include #include +#include #include #include #include diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c index dd6f9ae6fbe9f..311a8ea6f0654 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c @@ -39,8 +39,8 @@ #include #include #include -#include #include +#include #include #include diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c index bf1ff8f0e7120..e3a18f069ce5e 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c @@ -29,6 +29,7 @@ #include "amdgpu.h" #include #include +#include #include "amdgpu_uvd.h" #include "amdgpu_vce.h" #include "atom.h" diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h index 37322550d7508..8a39300b1a845 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h @@ -36,7 +36,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c index 05051d5d2ec31..90f87b2d985b5 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c @@ -21,6 +21,7 @@ * */ +#include #include #include diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c index c928bc9eb2026..0352de72c886a 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c @@ -21,6 +21,7 @@ * */ +#include #include #include diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c index 62315fd5a05f2..07bd16e820461 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c @@ -23,6 +23,7 @@ #include +#include #include #include diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c index 87d5e4c21cb37..d73df100f2b3b 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c @@ -21,6 +21,7 @@ * */ +#include #include #include diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c index 7030339fa2323..ddbe1dd2d44ef 100644 --- a/drivers/gpu/drm/arm/hdlcd_crtc.c +++ b/drivers/gpu/drm/arm/hdlcd_crtc.c @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h index 74f41282444f6..d51b81fea9c80 100644 --- a/drivers/gpu/drm/ast/ast_drv.h +++ b/drivers/gpu/drm/ast/ast_drv.h @@ -38,7 +38,6 @@ #include #include #include -#include #define DRIVER_AUTHOR "Dave Airlie" diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c index 7f4fce1aa9988..0b6a284368859 100644 --- a/drivers/gpu/drm/bridge/tc358762.c +++ b/drivers/gpu/drm/bridge/tc358762.c @@ -11,6 +11,7 @@ */ #include +#include #include #include #include @@ -19,7 +20,6 @@ #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index f5fb22e0d0337..a209659a996c7 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -43,7 +43,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c index e35e224e6303a..e93533b86037f 100644 --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c @@ -9,7 +9,6 @@ #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c index 2fc21df709bcb..bcd9611dabfd9 100644 --- a/drivers/gpu/drm/drm_probe_helper.c +++ b/drivers/gpu/drm/drm_probe_helper.c @@ -36,7 +36,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h index f32f4771dada7..2bb4c25565dcb 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h @@ -6,13 +6,14 @@ #ifndef __ETNAVIV_DRV_H__ #define __ETNAVIV_DRV_H__ +#include #include #include #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h index 4a0cd22c10e21..f957552c6c507 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h @@ -19,7 +19,6 @@ #include #include -#include #include struct hibmc_connector { diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c index 28e732f94bf2f..6c6b572987973 100644 --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index 41799011f73b6..c45fc8f4744d0 100644 --- a/drivers/gpu/drm/imx/imx-ldb.c +++ b/drivers/gpu/drm/imx/imx-ldb.c @@ -7,6 +7,7 @@ #include #include +#include #include #include #include @@ -23,7 +24,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index 6b34fac3f73a0..d64ebd2cf15e8 100644 --- a/drivers/gpu/drm/imx/imx-tve.c +++ b/drivers/gpu/drm/imx/imx-tve.c @@ -19,7 +19,6 @@ #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c index 06723b2e9b847..0fa0b590830b6 100644 --- a/drivers/gpu/drm/imx/parallel-display.c +++ b/drivers/gpu/drm/imx/parallel-display.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include @@ -16,7 +17,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plane.c index a42f63f6f9573..d172a302f9024 100644 --- a/drivers/gpu/drm/kmb/kmb_plane.c +++ b/drivers/gpu/drm/kmb/kmb_plane.c @@ -9,7 +9,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers/gpu/drm/mgag200/mgag200_drv.h index f0c2349404b46..9e604dbb8e448 100644 --- a/drivers/gpu/drm/mgag200/mgag200_drv.h +++ b/drivers/gpu/drm/mgag200/mgag200_drv.h @@ -18,7 +18,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h index 432758ad39a35..76f060810f634 100644 --- a/drivers/gpu/drm/qxl/qxl_drv.h +++ b/drivers/gpu/drm/qxl/qxl_drv.h @@ -38,7 +38,6 @@ #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h b/drivers/gpu/drm/rockchip/rockchip_drm_drv.h index 1641440837af5..aeb03a57240fd 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.h @@ -9,10 +9,10 @@ #ifndef _ROCKCHIP_DRM_DRV_H #define _ROCKCHIP_DRM_DRV_H -#include #include #include +#include #include #include diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index da8a69953706d..6edb7c52cb3dc 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c @@ -9,6 +9,7 @@ #include #include +#include #include #include #include diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c index afb2879980c6c..345bcc3011e4f 100644 --- a/drivers/gpu/drm/tidss/tidss_kms.c +++ b/drivers/gpu/drm/tidss/tidss_kms.c @@ -10,7 +10,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c index e8c975b815859..478f1f0f60dec 100644 --- a/drivers/gpu/drm/v3d/v3d_drv.c +++ b/drivers/gpu/drm/v3d/v3d_drv.c @@ -22,7 +22,6 @@ #include #include -#include #include #include diff --git a/drivers/gpu/drm/vboxvideo/vbox_main.c b/drivers/gpu/drm/vboxvideo/vbox_main.c index c9e8b3a63c621..3b83e550f4df5 100644 --- a/drivers/gpu/drm/vboxvideo/vbox_main.c +++ b/drivers/gpu/drm/vboxvideo/vbox_main.c @@ -11,7 +11,6 @@ #include #include -#include #include #include diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h index 9b98470593b06..b7a64c7dcc2c9 100644 --- a/drivers/gpu/drm/virtio/virtgpu_drv.h +++ b/drivers/gpu/drm/virtio/virtgpu_drv.h @@ -35,7 +35,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c index e31554d7139f1..4c95ebcdcc2d3 100644 --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c @@ -12,7 +12,6 @@ #include #include -#include #include #include #include -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:25:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:25:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436744.690999 (Exim 4.92) (envelope-from ) id 1oqc6D-0000iL-5a; Thu, 03 Nov 2022 15:25:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436744.690999; Thu, 03 Nov 2022 15:25:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqc6D-0000iA-29; Thu, 03 Nov 2022 15:25:45 +0000 Received: by outflank-mailman (input) for mailman id 436744; Thu, 03 Nov 2022 15:25:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvw-0001nI-KX for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:15:09 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47fe814a-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:14:59 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 24C2F1F8FA; Thu, 3 Nov 2022 15:15:01 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6FBE413AAF; Thu, 3 Nov 2022 15:15:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kKdTGvTaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:15:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47fe814a-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zC11rpTlFv/eSsE6Q8cq84lFr/fdZ65Sme2rFQ6bjpw=; b=CAz9QtHAtg90PCLlpLn/VrRPofsbdkZ/9SaYP4d9LCBurxoMCpCzE1fXnlz/2WoEPoFzFC 7z3GqiG8ozF0cn1XTOiX9kNDHcvf2kg0MqJXiJptPIACARhMneMaznKeYbcD5VHHJT7J00 T+kS3GcH9tGgZBS4XyJRwWmS+7erTBY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zC11rpTlFv/eSsE6Q8cq84lFr/fdZ65Sme2rFQ6bjpw=; b=vdvHJt3Cqwlmpvn75MYaQAM+Eq3sxHWDDDrth1WJ7L/M3dWxTdsGaBwlxySK/qhgdke7cv PiFcpoKcWZIy2tCA== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 21/23] drm/fb-helper: Move generic fbdev emulation into separate source file Date: Thu, 3 Nov 2022 16:14:44 +0100 Message-Id: <20221103151446.2638-22-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move the generic fbdev implementation into its own source and header file. Adapt drivers. No functional changes, but some of the internal helpers have been renamed to fit into the drm_fbdev_ naming scheme. v3: * rename drm_fbdev.{c,h} to drm_fbdev_generic.{c,h} * rebase onto vmwgfx changes * rebase onto xlnx changes * fix include statements in amdgpu Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/Makefile | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + .../gpu/drm/arm/display/komeda/komeda_drv.c | 2 +- drivers/gpu/drm/arm/hdlcd_drv.c | 2 +- drivers/gpu/drm/arm/malidp_drv.c | 2 +- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 2 +- drivers/gpu/drm/ast/ast_drv.c | 1 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +- drivers/gpu/drm/drm_fb_helper.c | 498 +----------------- drivers/gpu/drm/drm_fbdev_generic.c | 493 +++++++++++++++++ drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +- drivers/gpu/drm/gud/gud_drv.c | 2 +- .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 + .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +- drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 2 +- drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 +- drivers/gpu/drm/imx/imx-drm-core.c | 2 +- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- drivers/gpu/drm/kmb/kmb_drv.c | 2 +- drivers/gpu/drm/logicvc/logicvc_drm.c | 2 +- drivers/gpu/drm/mcde/mcde_drv.c | 2 +- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- drivers/gpu/drm/meson/meson_drv.c | 2 +- drivers/gpu/drm/mgag200/mgag200_drv.c | 1 + drivers/gpu/drm/mxsfb/lcdif_drv.c | 2 +- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 2 +- drivers/gpu/drm/pl111/pl111_drv.c | 2 +- drivers/gpu/drm/qxl/qxl_drv.c | 1 + drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- drivers/gpu/drm/solomon/ssd130x.c | 2 +- drivers/gpu/drm/sti/sti_drv.c | 2 +- drivers/gpu/drm/stm/drv.c | 2 +- drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +- drivers/gpu/drm/tidss/tidss_drv.c | 2 +- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- drivers/gpu/drm/tiny/arcpgu.c | 2 +- drivers/gpu/drm/tiny/bochs.c | 2 +- drivers/gpu/drm/tiny/cirrus.c | 2 +- drivers/gpu/drm/tiny/gm12u320.c | 2 +- drivers/gpu/drm/tiny/hx8357d.c | 2 +- drivers/gpu/drm/tiny/ili9163.c | 2 +- drivers/gpu/drm/tiny/ili9225.c | 2 +- drivers/gpu/drm/tiny/ili9341.c | 2 +- drivers/gpu/drm/tiny/ili9486.c | 2 +- drivers/gpu/drm/tiny/mi0283qt.c | 2 +- drivers/gpu/drm/tiny/ofdrm.c | 2 +- drivers/gpu/drm/tiny/panel-mipi-dbi.c | 2 +- drivers/gpu/drm/tiny/repaper.c | 2 +- drivers/gpu/drm/tiny/simpledrm.c | 2 +- drivers/gpu/drm/tiny/st7586.c | 2 +- drivers/gpu/drm/tiny/st7735r.c | 2 +- drivers/gpu/drm/tve200/tve200_drv.c | 2 +- drivers/gpu/drm/udl/udl_drv.c | 2 +- drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +- drivers/gpu/drm/vc4/vc4_drv.c | 2 +- drivers/gpu/drm/virtio/virtgpu_drv.c | 1 + drivers/gpu/drm/vkms/vkms_drv.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 +- drivers/gpu/drm/xlnx/zynqmp_kms.c | 2 +- include/drm/drm_fb_helper.h | 9 - include/drm/drm_fbdev_generic.h | 15 + 63 files changed, 571 insertions(+), 558 deletions(-) create mode 100644 drivers/gpu/drm/drm_fbdev_generic.c create mode 100644 include/drm/drm_fbdev_generic.h diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 6e55c47288e42..c44a54cadb618 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -117,7 +117,9 @@ drm_kms_helper-y := \ drm_self_refresh_helper.o \ drm_simple_kms_helper.o drm_kms_helper-$(CONFIG_DRM_PANEL_BRIDGE) += bridge/panel.o -drm_kms_helper-$(CONFIG_DRM_FBDEV_EMULATION) += drm_fb_helper.o +drm_kms_helper-$(CONFIG_DRM_FBDEV_EMULATION) += \ + drm_fbdev_generic.o \ + drm_fb_helper.o obj-$(CONFIG_DRM_KMS_HELPER) += drm_kms_helper.o # diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 3c9fecdd6b2f3..ca96ee2c2c962 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c index 9fce4239d4ad4..3f4e719eebd85 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c @@ -9,7 +9,7 @@ #include #include #include -#include +#include #include #include #include "komeda_dev.h" diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c index a032003c340cc..3219cc33d7f69 100644 --- a/drivers/gpu/drm/arm/hdlcd_drv.c +++ b/drivers/gpu/drm/arm/hdlcd_drv.c @@ -26,7 +26,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index 1d0b0c54ccc74..b734dbdcc5773 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c @@ -19,7 +19,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c index a94f1a9e8f409..718119e168a69 100644 --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c @@ -16,7 +16,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c index bbeb5defc8f5c..420fc75c240e4 100644 --- a/drivers/gpu/drm/ast/ast_drv.c +++ b/drivers/gpu/drm/ast/ast_drv.c @@ -33,6 +33,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c index f7e7f4e919c77..a2bb5b9162352 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c @@ -19,7 +19,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 105d9c8fe3250..5eb2f0d4bf8d4 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -30,24 +30,17 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include -#include -#include -#include -#include #include -#include #include -#include -#include #include #include #include #include +#include #include #include -#include "drm_crtc_helper_internal.h" #include "drm_internal.h" static bool drm_fbdev_emulation = true; @@ -372,80 +365,6 @@ static void drm_fb_helper_resume_worker(struct work_struct *work) console_unlock(); } -static void drm_fb_helper_damage_blit_real(struct drm_fb_helper *fb_helper, - struct drm_clip_rect *clip, - struct iosys_map *dst) -{ - struct drm_framebuffer *fb = fb_helper->fb; - size_t offset = clip->y1 * fb->pitches[0]; - size_t len = clip->x2 - clip->x1; - unsigned int y; - void *src; - - switch (drm_format_info_bpp(fb->format, 0)) { - case 1: - offset += clip->x1 / 8; - len = DIV_ROUND_UP(len + clip->x1 % 8, 8); - break; - case 2: - offset += clip->x1 / 4; - len = DIV_ROUND_UP(len + clip->x1 % 4, 4); - break; - case 4: - offset += clip->x1 / 2; - len = DIV_ROUND_UP(len + clip->x1 % 2, 2); - break; - default: - offset += clip->x1 * fb->format->cpp[0]; - len *= fb->format->cpp[0]; - break; - } - - src = fb_helper->info->screen_buffer + offset; - iosys_map_incr(dst, offset); /* go to first pixel within clip rect */ - - for (y = clip->y1; y < clip->y2; y++) { - iosys_map_memcpy_to(dst, 0, src, len); - iosys_map_incr(dst, fb->pitches[0]); - src += fb->pitches[0]; - } -} - -static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper, - struct drm_clip_rect *clip) -{ - struct drm_client_buffer *buffer = fb_helper->buffer; - struct iosys_map map, dst; - int ret; - - /* - * We have to pin the client buffer to its current location while - * flushing the shadow buffer. In the general case, concurrent - * modesetting operations could try to move the buffer and would - * fail. The modeset has to be serialized by acquiring the reservation - * object of the underlying BO here. - * - * For fbdev emulation, we only have to protect against fbdev modeset - * operations. Nothing else will involve the client buffer's BO. So it - * is sufficient to acquire struct drm_fb_helper.lock here. - */ - mutex_lock(&fb_helper->lock); - - ret = drm_client_buffer_vmap(buffer, &map); - if (ret) - goto out; - - dst = map; - drm_fb_helper_damage_blit_real(fb_helper, clip, &dst); - - drm_client_buffer_vunmap(buffer); - -out: - mutex_unlock(&fb_helper->lock); - - return ret; -} - static void drm_fb_helper_damage_work(struct work_struct *work) { struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work); @@ -2326,423 +2245,10 @@ EXPORT_SYMBOL(drm_fb_helper_lastclose); * * This function can be used as the * &drm_mode_config_funcs.output_poll_changed callback for drivers that only - * need to call drm_fb_helper_hotplug_event(). + * need to call drm_fbdev.hotplug_event(). */ void drm_fb_helper_output_poll_changed(struct drm_device *dev) { drm_fb_helper_hotplug_event(dev->fb_helper); } EXPORT_SYMBOL(drm_fb_helper_output_poll_changed); - -static bool drm_fbdev_use_shadow_fb(struct drm_fb_helper *fb_helper) -{ - struct drm_device *dev = fb_helper->dev; - struct drm_framebuffer *fb = fb_helper->fb; - - return dev->mode_config.prefer_shadow_fbdev || - dev->mode_config.prefer_shadow || - fb->funcs->dirty; -} - -/* @user: 1=userspace, 0=fbcon */ -static int drm_fbdev_fb_open(struct fb_info *info, int user) -{ - struct drm_fb_helper *fb_helper = info->par; - - /* No need to take a ref for fbcon because it unbinds on unregister */ - if (user && !try_module_get(fb_helper->dev->driver->fops->owner)) - return -ENODEV; - - return 0; -} - -static int drm_fbdev_fb_release(struct fb_info *info, int user) -{ - struct drm_fb_helper *fb_helper = info->par; - - if (user) - module_put(fb_helper->dev->driver->fops->owner); - - return 0; -} - -static void drm_fbdev_cleanup(struct drm_fb_helper *fb_helper) -{ - struct fb_info *fbi = fb_helper->info; - void *shadow = NULL; - - if (!fb_helper->dev) - return; - - if (fbi) { - if (fbi->fbdefio) - fb_deferred_io_cleanup(fbi); - if (drm_fbdev_use_shadow_fb(fb_helper)) - shadow = fbi->screen_buffer; - } - - drm_fb_helper_fini(fb_helper); - - if (shadow) - vfree(shadow); - else if (fb_helper->buffer) - drm_client_buffer_vunmap(fb_helper->buffer); - - drm_client_framebuffer_delete(fb_helper->buffer); -} - -static void drm_fbdev_release(struct drm_fb_helper *fb_helper) -{ - drm_fbdev_cleanup(fb_helper); - drm_client_release(&fb_helper->client); - kfree(fb_helper); -} - -/* - * fb_ops.fb_destroy is called by the last put_fb_info() call at the end of - * unregister_framebuffer() or fb_release(). - */ -static void drm_fbdev_fb_destroy(struct fb_info *info) -{ - drm_fbdev_release(info->par); -} - -static int drm_fbdev_fb_mmap(struct fb_info *info, struct vm_area_struct *vma) -{ - struct drm_fb_helper *fb_helper = info->par; - - if (drm_fbdev_use_shadow_fb(fb_helper)) - return fb_deferred_io_mmap(info, vma); - else if (fb_helper->dev->driver->gem_prime_mmap) - return fb_helper->dev->driver->gem_prime_mmap(fb_helper->buffer->gem, vma); - else - return -ENODEV; -} - -static bool drm_fbdev_use_iomem(struct fb_info *info) -{ - struct drm_fb_helper *fb_helper = info->par; - struct drm_client_buffer *buffer = fb_helper->buffer; - - return !drm_fbdev_use_shadow_fb(fb_helper) && buffer->map.is_iomem; -} - -static ssize_t drm_fbdev_fb_read(struct fb_info *info, char __user *buf, - size_t count, loff_t *ppos) -{ - ssize_t ret; - - if (drm_fbdev_use_iomem(info)) - ret = drm_fb_helper_cfb_read(info, buf, count, ppos); - else - ret = drm_fb_helper_sys_read(info, buf, count, ppos); - - return ret; -} - -static ssize_t drm_fbdev_fb_write(struct fb_info *info, const char __user *buf, - size_t count, loff_t *ppos) -{ - ssize_t ret; - - if (drm_fbdev_use_iomem(info)) - ret = drm_fb_helper_cfb_write(info, buf, count, ppos); - else - ret = drm_fb_helper_sys_write(info, buf, count, ppos); - - return ret; -} - -static void drm_fbdev_fb_fillrect(struct fb_info *info, - const struct fb_fillrect *rect) -{ - if (drm_fbdev_use_iomem(info)) - drm_fb_helper_cfb_fillrect(info, rect); - else - drm_fb_helper_sys_fillrect(info, rect); -} - -static void drm_fbdev_fb_copyarea(struct fb_info *info, - const struct fb_copyarea *area) -{ - if (drm_fbdev_use_iomem(info)) - drm_fb_helper_cfb_copyarea(info, area); - else - drm_fb_helper_sys_copyarea(info, area); -} - -static void drm_fbdev_fb_imageblit(struct fb_info *info, - const struct fb_image *image) -{ - if (drm_fbdev_use_iomem(info)) - drm_fb_helper_cfb_imageblit(info, image); - else - drm_fb_helper_sys_imageblit(info, image); -} - -static const struct fb_ops drm_fbdev_fb_ops = { - .owner = THIS_MODULE, - DRM_FB_HELPER_DEFAULT_OPS, - .fb_open = drm_fbdev_fb_open, - .fb_release = drm_fbdev_fb_release, - .fb_destroy = drm_fbdev_fb_destroy, - .fb_mmap = drm_fbdev_fb_mmap, - .fb_read = drm_fbdev_fb_read, - .fb_write = drm_fbdev_fb_write, - .fb_fillrect = drm_fbdev_fb_fillrect, - .fb_copyarea = drm_fbdev_fb_copyarea, - .fb_imageblit = drm_fbdev_fb_imageblit, -}; - -static struct fb_deferred_io drm_fbdev_defio = { - .delay = HZ / 20, - .deferred_io = drm_fb_helper_deferred_io, -}; - -/* - * This function uses the client API to create a framebuffer backed by a dumb buffer. - * - * The _sys_ versions are used for &fb_ops.fb_read, fb_write, fb_fillrect, - * fb_copyarea, fb_imageblit. - */ -static int drm_fb_helper_generic_probe(struct drm_fb_helper *fb_helper, - struct drm_fb_helper_surface_size *sizes) -{ - struct drm_client_dev *client = &fb_helper->client; - struct drm_device *dev = fb_helper->dev; - struct drm_client_buffer *buffer; - struct drm_framebuffer *fb; - struct fb_info *fbi; - u32 format; - struct iosys_map map; - int ret; - - drm_dbg_kms(dev, "surface width(%d), height(%d) and bpp(%d)\n", - sizes->surface_width, sizes->surface_height, - sizes->surface_bpp); - - format = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth); - buffer = drm_client_framebuffer_create(client, sizes->surface_width, - sizes->surface_height, format); - if (IS_ERR(buffer)) - return PTR_ERR(buffer); - - fb_helper->buffer = buffer; - fb_helper->fb = buffer->fb; - fb = buffer->fb; - - fbi = drm_fb_helper_alloc_info(fb_helper); - if (IS_ERR(fbi)) - return PTR_ERR(fbi); - - fbi->fbops = &drm_fbdev_fb_ops; - fbi->screen_size = sizes->surface_height * fb->pitches[0]; - fbi->fix.smem_len = fbi->screen_size; - fbi->flags = FBINFO_DEFAULT; - - drm_fb_helper_fill_info(fbi, fb_helper, sizes); - - if (drm_fbdev_use_shadow_fb(fb_helper)) { - fbi->screen_buffer = vzalloc(fbi->screen_size); - if (!fbi->screen_buffer) - return -ENOMEM; - fbi->flags |= FBINFO_VIRTFB | FBINFO_READS_FAST; - - fbi->fbdefio = &drm_fbdev_defio; - fb_deferred_io_init(fbi); - } else { - /* buffer is mapped for HW framebuffer */ - ret = drm_client_buffer_vmap(fb_helper->buffer, &map); - if (ret) - return ret; - if (map.is_iomem) { - fbi->screen_base = map.vaddr_iomem; - } else { - fbi->screen_buffer = map.vaddr; - fbi->flags |= FBINFO_VIRTFB; - } - - /* - * Shamelessly leak the physical address to user-space. As - * page_to_phys() is undefined for I/O memory, warn in this - * case. - */ -#if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM) - if (fb_helper->hint_leak_smem_start && fbi->fix.smem_start == 0 && - !drm_WARN_ON_ONCE(dev, map.is_iomem)) - fbi->fix.smem_start = - page_to_phys(virt_to_page(fbi->screen_buffer)); -#endif - } - - return 0; -} - -static int drm_fbdev_fb_dirty(struct drm_fb_helper *helper, struct drm_clip_rect *clip) -{ - struct drm_device *dev = helper->dev; - int ret; - - if (!drm_fbdev_use_shadow_fb(helper)) - return 0; - - /* Call damage handlers only if necessary */ - if (!(clip->x1 < clip->x2 && clip->y1 < clip->y2)) - return 0; - - if (helper->buffer) { - ret = drm_fb_helper_damage_blit(helper, clip); - if (drm_WARN_ONCE(dev, ret, "Damage blitter failed: ret=%d\n", ret)) - return ret; - } - - if (helper->fb->funcs->dirty) { - ret = helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, clip, 1); - if (drm_WARN_ONCE(dev, ret, "Dirty helper failed: ret=%d\n", ret)) - return ret; - } - - return 0; -} - -static const struct drm_fb_helper_funcs drm_fb_helper_generic_funcs = { - .fb_probe = drm_fb_helper_generic_probe, - .fb_dirty = drm_fbdev_fb_dirty, -}; - -static void drm_fbdev_client_unregister(struct drm_client_dev *client) -{ - struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client); - - if (fb_helper->info) - /* drm_fbdev_fb_destroy() takes care of cleanup */ - drm_fb_helper_unregister_info(fb_helper); - else - drm_fbdev_release(fb_helper); -} - -static int drm_fbdev_client_restore(struct drm_client_dev *client) -{ - drm_fb_helper_lastclose(client->dev); - - return 0; -} - -static int drm_fbdev_client_hotplug(struct drm_client_dev *client) -{ - struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client); - struct drm_device *dev = client->dev; - int ret; - - /* Setup is not retried if it has failed */ - if (!fb_helper->dev && fb_helper->funcs) - return 0; - - if (dev->fb_helper) - return drm_fb_helper_hotplug_event(dev->fb_helper); - - if (!dev->mode_config.num_connector) { - drm_dbg_kms(dev, "No connectors found, will not create framebuffer!\n"); - return 0; - } - - drm_fb_helper_prepare(dev, fb_helper, &drm_fb_helper_generic_funcs); - - ret = drm_fb_helper_init(dev, fb_helper); - if (ret) - goto err; - - if (!drm_drv_uses_atomic_modeset(dev)) - drm_helper_disable_unused_functions(dev); - - ret = drm_fb_helper_initial_config(fb_helper, fb_helper->preferred_bpp); - if (ret) - goto err_cleanup; - - return 0; - -err_cleanup: - drm_fbdev_cleanup(fb_helper); -err: - fb_helper->dev = NULL; - fb_helper->info = NULL; - - drm_err(dev, "fbdev: Failed to setup generic emulation (ret=%d)\n", ret); - - return ret; -} - -static const struct drm_client_funcs drm_fbdev_client_funcs = { - .owner = THIS_MODULE, - .unregister = drm_fbdev_client_unregister, - .restore = drm_fbdev_client_restore, - .hotplug = drm_fbdev_client_hotplug, -}; - -/** - * drm_fbdev_generic_setup() - Setup generic fbdev emulation - * @dev: DRM device - * @preferred_bpp: Preferred bits per pixel for the device. - * @dev->mode_config.preferred_depth is used if this is zero. - * - * This function sets up generic fbdev emulation for drivers that supports - * dumb buffers with a virtual address and that can be mmap'ed. - * drm_fbdev_generic_setup() shall be called after the DRM driver registered - * the new DRM device with drm_dev_register(). - * - * Restore, hotplug events and teardown are all taken care of. Drivers that do - * suspend/resume need to call drm_fb_helper_set_suspend_unlocked() themselves. - * Simple drivers might use drm_mode_config_helper_suspend(). - * - * Drivers that set the dirty callback on their framebuffer will get a shadow - * fbdev buffer that is blitted onto the real buffer. This is done in order to - * make deferred I/O work with all kinds of buffers. A shadow buffer can be - * requested explicitly by setting struct drm_mode_config.prefer_shadow or - * struct drm_mode_config.prefer_shadow_fbdev to true beforehand. This is - * required to use generic fbdev emulation with SHMEM helpers. - * - * This function is safe to call even when there are no connectors present. - * Setup will be retried on the next hotplug event. - * - * The fbdev is destroyed by drm_dev_unregister(). - */ -void drm_fbdev_generic_setup(struct drm_device *dev, - unsigned int preferred_bpp) -{ - struct drm_fb_helper *fb_helper; - int ret; - - drm_WARN(dev, !dev->registered, "Device has not been registered.\n"); - drm_WARN(dev, dev->fb_helper, "fb_helper is already set!\n"); - - fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL); - if (!fb_helper) { - drm_err(dev, "Failed to allocate fb_helper\n"); - return; - } - - ret = drm_client_init(dev, &fb_helper->client, "fbdev", &drm_fbdev_client_funcs); - if (ret) { - kfree(fb_helper); - drm_err(dev, "Failed to register client: %d\n", ret); - return; - } - - /* - * FIXME: This mixes up depth with bpp, which results in a glorious - * mess, resulting in some drivers picking wrong fbdev defaults and - * others wrong preferred_depth defaults. - */ - if (!preferred_bpp) - preferred_bpp = dev->mode_config.preferred_depth; - if (!preferred_bpp) - preferred_bpp = 32; - fb_helper->preferred_bpp = preferred_bpp; - - ret = drm_fbdev_client_hotplug(&fb_helper->client); - if (ret) - drm_dbg_kms(dev, "client hotplug ret=%d\n", ret); - - drm_client_register(&fb_helper->client); -} -EXPORT_SYMBOL(drm_fbdev_generic_setup); diff --git a/drivers/gpu/drm/drm_fbdev_generic.c b/drivers/gpu/drm/drm_fbdev_generic.c new file mode 100644 index 0000000000000..2d6083ad2e3c7 --- /dev/null +++ b/drivers/gpu/drm/drm_fbdev_generic.c @@ -0,0 +1,493 @@ +// SPDX-License-Identifier: MIT + +#include + +#include +#include +#include +#include +#include + +#include + +static bool drm_fbdev_use_shadow_fb(struct drm_fb_helper *fb_helper) +{ + struct drm_device *dev = fb_helper->dev; + struct drm_framebuffer *fb = fb_helper->fb; + + return dev->mode_config.prefer_shadow_fbdev || + dev->mode_config.prefer_shadow || + fb->funcs->dirty; +} + +/* @user: 1=userspace, 0=fbcon */ +static int drm_fbdev_fb_open(struct fb_info *info, int user) +{ + struct drm_fb_helper *fb_helper = info->par; + + /* No need to take a ref for fbcon because it unbinds on unregister */ + if (user && !try_module_get(fb_helper->dev->driver->fops->owner)) + return -ENODEV; + + return 0; +} + +static int drm_fbdev_fb_release(struct fb_info *info, int user) +{ + struct drm_fb_helper *fb_helper = info->par; + + if (user) + module_put(fb_helper->dev->driver->fops->owner); + + return 0; +} + +static void drm_fbdev_cleanup(struct drm_fb_helper *fb_helper) +{ + struct fb_info *fbi = fb_helper->info; + void *shadow = NULL; + + if (!fb_helper->dev) + return; + + if (fbi) { + if (fbi->fbdefio) + fb_deferred_io_cleanup(fbi); + if (drm_fbdev_use_shadow_fb(fb_helper)) + shadow = fbi->screen_buffer; + } + + drm_fb_helper_fini(fb_helper); + + if (shadow) + vfree(shadow); + else if (fb_helper->buffer) + drm_client_buffer_vunmap(fb_helper->buffer); + + drm_client_framebuffer_delete(fb_helper->buffer); +} + +static void drm_fbdev_release(struct drm_fb_helper *fb_helper) +{ + drm_fbdev_cleanup(fb_helper); + drm_client_release(&fb_helper->client); + kfree(fb_helper); +} + +/* + * fb_ops.fb_destroy is called by the last put_fb_info() call at the end of + * unregister_framebuffer() or fb_release(). + */ +static void drm_fbdev_fb_destroy(struct fb_info *info) +{ + drm_fbdev_release(info->par); +} + +static int drm_fbdev_fb_mmap(struct fb_info *info, struct vm_area_struct *vma) +{ + struct drm_fb_helper *fb_helper = info->par; + + if (drm_fbdev_use_shadow_fb(fb_helper)) + return fb_deferred_io_mmap(info, vma); + else if (fb_helper->dev->driver->gem_prime_mmap) + return fb_helper->dev->driver->gem_prime_mmap(fb_helper->buffer->gem, vma); + else + return -ENODEV; +} + +static bool drm_fbdev_use_iomem(struct fb_info *info) +{ + struct drm_fb_helper *fb_helper = info->par; + struct drm_client_buffer *buffer = fb_helper->buffer; + + return !drm_fbdev_use_shadow_fb(fb_helper) && buffer->map.is_iomem; +} + +static ssize_t drm_fbdev_fb_read(struct fb_info *info, char __user *buf, + size_t count, loff_t *ppos) +{ + ssize_t ret; + + if (drm_fbdev_use_iomem(info)) + ret = drm_fb_helper_cfb_read(info, buf, count, ppos); + else + ret = drm_fb_helper_sys_read(info, buf, count, ppos); + + return ret; +} + +static ssize_t drm_fbdev_fb_write(struct fb_info *info, const char __user *buf, + size_t count, loff_t *ppos) +{ + ssize_t ret; + + if (drm_fbdev_use_iomem(info)) + ret = drm_fb_helper_cfb_write(info, buf, count, ppos); + else + ret = drm_fb_helper_sys_write(info, buf, count, ppos); + + return ret; +} + +static void drm_fbdev_fb_fillrect(struct fb_info *info, + const struct fb_fillrect *rect) +{ + if (drm_fbdev_use_iomem(info)) + drm_fb_helper_cfb_fillrect(info, rect); + else + drm_fb_helper_sys_fillrect(info, rect); +} + +static void drm_fbdev_fb_copyarea(struct fb_info *info, + const struct fb_copyarea *area) +{ + if (drm_fbdev_use_iomem(info)) + drm_fb_helper_cfb_copyarea(info, area); + else + drm_fb_helper_sys_copyarea(info, area); +} + +static void drm_fbdev_fb_imageblit(struct fb_info *info, + const struct fb_image *image) +{ + if (drm_fbdev_use_iomem(info)) + drm_fb_helper_cfb_imageblit(info, image); + else + drm_fb_helper_sys_imageblit(info, image); +} + +static const struct fb_ops drm_fbdev_fb_ops = { + .owner = THIS_MODULE, + DRM_FB_HELPER_DEFAULT_OPS, + .fb_open = drm_fbdev_fb_open, + .fb_release = drm_fbdev_fb_release, + .fb_destroy = drm_fbdev_fb_destroy, + .fb_mmap = drm_fbdev_fb_mmap, + .fb_read = drm_fbdev_fb_read, + .fb_write = drm_fbdev_fb_write, + .fb_fillrect = drm_fbdev_fb_fillrect, + .fb_copyarea = drm_fbdev_fb_copyarea, + .fb_imageblit = drm_fbdev_fb_imageblit, +}; + +static struct fb_deferred_io drm_fbdev_defio = { + .delay = HZ / 20, + .deferred_io = drm_fb_helper_deferred_io, +}; + +/* + * This function uses the client API to create a framebuffer backed by a dumb buffer. + */ +static int drm_fbdev_fb_probe(struct drm_fb_helper *fb_helper, + struct drm_fb_helper_surface_size *sizes) +{ + struct drm_client_dev *client = &fb_helper->client; + struct drm_device *dev = fb_helper->dev; + struct drm_client_buffer *buffer; + struct drm_framebuffer *fb; + struct fb_info *fbi; + u32 format; + struct iosys_map map; + int ret; + + drm_dbg_kms(dev, "surface width(%d), height(%d) and bpp(%d)\n", + sizes->surface_width, sizes->surface_height, + sizes->surface_bpp); + + format = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth); + buffer = drm_client_framebuffer_create(client, sizes->surface_width, + sizes->surface_height, format); + if (IS_ERR(buffer)) + return PTR_ERR(buffer); + + fb_helper->buffer = buffer; + fb_helper->fb = buffer->fb; + fb = buffer->fb; + + fbi = drm_fb_helper_alloc_info(fb_helper); + if (IS_ERR(fbi)) + return PTR_ERR(fbi); + + fbi->fbops = &drm_fbdev_fb_ops; + fbi->screen_size = sizes->surface_height * fb->pitches[0]; + fbi->fix.smem_len = fbi->screen_size; + fbi->flags = FBINFO_DEFAULT; + + drm_fb_helper_fill_info(fbi, fb_helper, sizes); + + if (drm_fbdev_use_shadow_fb(fb_helper)) { + fbi->screen_buffer = vzalloc(fbi->screen_size); + if (!fbi->screen_buffer) + return -ENOMEM; + fbi->flags |= FBINFO_VIRTFB | FBINFO_READS_FAST; + + fbi->fbdefio = &drm_fbdev_defio; + fb_deferred_io_init(fbi); + } else { + /* buffer is mapped for HW framebuffer */ + ret = drm_client_buffer_vmap(fb_helper->buffer, &map); + if (ret) + return ret; + if (map.is_iomem) { + fbi->screen_base = map.vaddr_iomem; + } else { + fbi->screen_buffer = map.vaddr; + fbi->flags |= FBINFO_VIRTFB; + } + + /* + * Shamelessly leak the physical address to user-space. As + * page_to_phys() is undefined for I/O memory, warn in this + * case. + */ +#if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM) + if (fb_helper->hint_leak_smem_start && fbi->fix.smem_start == 0 && + !drm_WARN_ON_ONCE(dev, map.is_iomem)) + fbi->fix.smem_start = + page_to_phys(virt_to_page(fbi->screen_buffer)); +#endif + } + + return 0; +} + +static void drm_fbdev_damage_blit_real(struct drm_fb_helper *fb_helper, + struct drm_clip_rect *clip, + struct iosys_map *dst) +{ + struct drm_framebuffer *fb = fb_helper->fb; + size_t offset = clip->y1 * fb->pitches[0]; + size_t len = clip->x2 - clip->x1; + unsigned int y; + void *src; + + switch (drm_format_info_bpp(fb->format, 0)) { + case 1: + offset += clip->x1 / 8; + len = DIV_ROUND_UP(len + clip->x1 % 8, 8); + break; + case 2: + offset += clip->x1 / 4; + len = DIV_ROUND_UP(len + clip->x1 % 4, 4); + break; + case 4: + offset += clip->x1 / 2; + len = DIV_ROUND_UP(len + clip->x1 % 2, 2); + break; + default: + offset += clip->x1 * fb->format->cpp[0]; + len *= fb->format->cpp[0]; + break; + } + + src = fb_helper->info->screen_buffer + offset; + iosys_map_incr(dst, offset); /* go to first pixel within clip rect */ + + for (y = clip->y1; y < clip->y2; y++) { + iosys_map_memcpy_to(dst, 0, src, len); + iosys_map_incr(dst, fb->pitches[0]); + src += fb->pitches[0]; + } +} + +static int drm_fbdev_damage_blit(struct drm_fb_helper *fb_helper, + struct drm_clip_rect *clip) +{ + struct drm_client_buffer *buffer = fb_helper->buffer; + struct iosys_map map, dst; + int ret; + + /* + * We have to pin the client buffer to its current location while + * flushing the shadow buffer. In the general case, concurrent + * modesetting operations could try to move the buffer and would + * fail. The modeset has to be serialized by acquiring the reservation + * object of the underlying BO here. + * + * For fbdev emulation, we only have to protect against fbdev modeset + * operations. Nothing else will involve the client buffer's BO. So it + * is sufficient to acquire struct drm_fb_helper.lock here. + */ + mutex_lock(&fb_helper->lock); + + ret = drm_client_buffer_vmap(buffer, &map); + if (ret) + goto out; + + dst = map; + drm_fbdev_damage_blit_real(fb_helper, clip, &dst); + + drm_client_buffer_vunmap(buffer); + +out: + mutex_unlock(&fb_helper->lock); + + return ret; +} + +static int drm_fbdev_fb_dirty(struct drm_fb_helper *helper, struct drm_clip_rect *clip) +{ + struct drm_device *dev = helper->dev; + int ret; + + if (!drm_fbdev_use_shadow_fb(helper)) + return 0; + + /* Call damage handlers only if necessary */ + if (!(clip->x1 < clip->x2 && clip->y1 < clip->y2)) + return 0; + + if (helper->buffer) { + ret = drm_fbdev_damage_blit(helper, clip); + if (drm_WARN_ONCE(dev, ret, "Damage blitter failed: ret=%d\n", ret)) + return ret; + } + + if (helper->fb->funcs->dirty) { + ret = helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, clip, 1); + if (drm_WARN_ONCE(dev, ret, "Dirty helper failed: ret=%d\n", ret)) + return ret; + } + + return 0; +} + +static const struct drm_fb_helper_funcs drm_fb_helper_generic_funcs = { + .fb_probe = drm_fbdev_fb_probe, + .fb_dirty = drm_fbdev_fb_dirty, +}; + +static void drm_fbdev_client_unregister(struct drm_client_dev *client) +{ + struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client); + + if (fb_helper->info) + /* drm_fbdev_fb_destroy() takes care of cleanup */ + drm_fb_helper_unregister_info(fb_helper); + else + drm_fbdev_release(fb_helper); +} + +static int drm_fbdev_client_restore(struct drm_client_dev *client) +{ + drm_fb_helper_lastclose(client->dev); + + return 0; +} + +static int drm_fbdev_client_hotplug(struct drm_client_dev *client) +{ + struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client); + struct drm_device *dev = client->dev; + int ret; + + /* Setup is not retried if it has failed */ + if (!fb_helper->dev && fb_helper->funcs) + return 0; + + if (dev->fb_helper) + return drm_fb_helper_hotplug_event(dev->fb_helper); + + if (!dev->mode_config.num_connector) { + drm_dbg_kms(dev, "No connectors found, will not create framebuffer!\n"); + return 0; + } + + drm_fb_helper_prepare(dev, fb_helper, &drm_fb_helper_generic_funcs); + + ret = drm_fb_helper_init(dev, fb_helper); + if (ret) + goto err; + + if (!drm_drv_uses_atomic_modeset(dev)) + drm_helper_disable_unused_functions(dev); + + ret = drm_fb_helper_initial_config(fb_helper, fb_helper->preferred_bpp); + if (ret) + goto err_cleanup; + + return 0; + +err_cleanup: + drm_fbdev_cleanup(fb_helper); +err: + fb_helper->dev = NULL; + fb_helper->info = NULL; + + drm_err(dev, "fbdev: Failed to setup generic emulation (ret=%d)\n", ret); + + return ret; +} + +static const struct drm_client_funcs drm_fbdev_client_funcs = { + .owner = THIS_MODULE, + .unregister = drm_fbdev_client_unregister, + .restore = drm_fbdev_client_restore, + .hotplug = drm_fbdev_client_hotplug, +}; + +/** + * drm_fbdev_generic_setup() - Setup generic fbdev emulation + * @dev: DRM device + * @preferred_bpp: Preferred bits per pixel for the device. + * @dev->mode_config.preferred_depth is used if this is zero. + * + * This function sets up generic fbdev emulation for drivers that supports + * dumb buffers with a virtual address and that can be mmap'ed. + * drm_fbdev_generic_setup() shall be called after the DRM driver registered + * the new DRM device with drm_dev_register(). + * + * Restore, hotplug events and teardown are all taken care of. Drivers that do + * suspend/resume need to call drm_fb_helper_set_suspend_unlocked() themselves. + * Simple drivers might use drm_mode_config_helper_suspend(). + * + * Drivers that set the dirty callback on their framebuffer will get a shadow + * fbdev buffer that is blitted onto the real buffer. This is done in order to + * make deferred I/O work with all kinds of buffers. A shadow buffer can be + * requested explicitly by setting struct drm_mode_config.prefer_shadow or + * struct drm_mode_config.prefer_shadow_fbdev to true beforehand. This is + * required to use generic fbdev emulation with SHMEM helpers. + * + * This function is safe to call even when there are no connectors present. + * Setup will be retried on the next hotplug event. + * + * The fbdev is destroyed by drm_dev_unregister(). + */ +void drm_fbdev_generic_setup(struct drm_device *dev, + unsigned int preferred_bpp) +{ + struct drm_fb_helper *fb_helper; + int ret; + + drm_WARN(dev, !dev->registered, "Device has not been registered.\n"); + drm_WARN(dev, dev->fb_helper, "fb_helper is already set!\n"); + + fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL); + if (!fb_helper) + return; + + ret = drm_client_init(dev, &fb_helper->client, "fbdev", &drm_fbdev_client_funcs); + if (ret) { + kfree(fb_helper); + drm_err(dev, "Failed to register client: %d\n", ret); + return; + } + + /* + * FIXME: This mixes up depth with bpp, which results in a glorious + * mess, resulting in some drivers picking wrong fbdev defaults and + * others wrong preferred_depth defaults. + */ + if (!preferred_bpp) + preferred_bpp = dev->mode_config.preferred_depth; + if (!preferred_bpp) + preferred_bpp = 32; + fb_helper->preferred_bpp = preferred_bpp; + + ret = drm_fbdev_client_hotplug(&fb_helper->client); + if (ret) + drm_dbg_kms(dev, "client hotplug ret=%d\n", ret); + + drm_client_register(&fb_helper->client); +} +EXPORT_SYMBOL(drm_fbdev_generic_setup); diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index b4acc3422ba45..8579c7629f5e1 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c @@ -20,7 +20,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud_drv.c index 8d1630b8edac1..d57dab104358b 100644 --- a/drivers/gpu/drm/gud/gud_drv.c +++ b/drivers/gpu/drm/gud/gud_drv.c @@ -18,7 +18,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c index 5a2e1cac06b2e..22053c613644a 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c index 73ee7f25f7346..9c5d49bf40c97 100644 --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c @@ -19,7 +19,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c index ca127ff797f75..427c20ba34045 100644 --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c @@ -11,7 +11,7 @@ #include #include #include -#include +#include #include #include diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c index 1defd6a40f11d..18df3888b7f94 100644 --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c @@ -7,7 +7,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index 8dd8b0f912af6..e060fa6cbcb92 100644 --- a/drivers/gpu/drm/imx/imx-drm-core.c +++ b/drivers/gpu/drm/imx/imx-drm-core.c @@ -16,7 +16,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c index 99f86f1ba8bee..fc9de7e373ae3 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c @@ -32,7 +32,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c index 2382ccb3ee99d..d29c678f6c912 100644 --- a/drivers/gpu/drm/kmb/kmb_drv.c +++ b/drivers/gpu/drm/kmb/kmb_drv.c @@ -15,7 +15,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c index cc9a4e965f779..9de24d9f0c963 100644 --- a/drivers/gpu/drm/logicvc/logicvc_drm.c +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c @@ -17,7 +17,7 @@ #include #include -#include +#include #include #include diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c index 38c3907bb151a..4aedb050d2a59 100644 --- a/drivers/gpu/drm/mcde/mcde_drv.c +++ b/drivers/gpu/drm/mcde/mcde_drv.c @@ -69,7 +69,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 91f58db5915f5..39a42dc8fb851 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -17,7 +17,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c index 3b24a924b7b97..79bfe3938d3c6 100644 --- a/drivers/gpu/drm/meson/meson_drv.c +++ b/drivers/gpu/drm/meson/meson_drv.c @@ -18,7 +18,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c index ece6cd102dbb1..976f0ab2006b5 100644 --- a/drivers/gpu/drm/mgag200/mgag200_drv.c +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c @@ -11,6 +11,7 @@ #include #include +#include #include #include #include diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c index 075002ed6fb09..cc2ceb301b96d 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c @@ -16,7 +16,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c index b29b332ed3814..810edea0a31e5 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -20,7 +20,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c index b59472c29a40d..384a724f2822e 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c @@ -31,7 +31,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c index eb25eedb5ee00..00deba0b72716 100644 --- a/drivers/gpu/drm/pl111/pl111_drv.c +++ b/drivers/gpu/drm/pl111/pl111_drv.c @@ -48,7 +48,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c index 3044ca948ce22..a3b83f89e0616 100644 --- a/drivers/gpu/drm/qxl/qxl_drv.c +++ b/drivers/gpu/drm/qxl/qxl_drv.c @@ -37,6 +37,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index a2776f1d6f2c2..d003e8d9e7a26 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -20,7 +20,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index 813f9f8c86982..6e0788d14c10f 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c @@ -17,7 +17,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c index f2795f90ea693..53464afc2b9ac 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -23,7 +23,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index 7abf010a32935..ef6a4e63198f5 100644 --- a/drivers/gpu/drm/sti/sti_drv.c +++ b/drivers/gpu/drm/sti/sti_drv.c @@ -14,7 +14,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c index d7914f5122dff..50410bd99dfe1 100644 --- a/drivers/gpu/drm/stm/drv.c +++ b/drivers/gpu/drm/stm/drv.c @@ -18,7 +18,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c index d06ffd99d86e1..cc94efbbf2d4e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_drv.c +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c @@ -17,7 +17,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c index 15cd9b91b7e2a..07d94b1e80895 100644 --- a/drivers/gpu/drm/tidss/tidss_drv.c +++ b/drivers/gpu/drm/tidss/tidss_drv.c @@ -14,7 +14,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index f72755b8ea14c..80615ecdae0b2 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -16,7 +16,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.c index bb302a3fd6b5f..611bbee150719 100644 --- a/drivers/gpu/drm/tiny/arcpgu.c +++ b/drivers/gpu/drm/tiny/arcpgu.c @@ -12,7 +12,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c index 04682f831544c..024346054c70e 100644 --- a/drivers/gpu/drm/tiny/bochs.c +++ b/drivers/gpu/drm/tiny/bochs.c @@ -7,7 +7,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/cirrus.c b/drivers/gpu/drm/tiny/cirrus.c index 354d5e854a6f0..678c2ef1cae70 100644 --- a/drivers/gpu/drm/tiny/cirrus.c +++ b/drivers/gpu/drm/tiny/cirrus.c @@ -30,7 +30,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/drivers/gpu/drm/tiny/gm12u320.c index 7441d992a5d7a..130fd07a967d8 100644 --- a/drivers/gpu/drm/tiny/gm12u320.c +++ b/drivers/gpu/drm/tiny/gm12u320.c @@ -12,7 +12,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/hx8357d.c b/drivers/gpu/drm/tiny/hx8357d.c index 48c24aa8c28a1..9f634f720817b 100644 --- a/drivers/gpu/drm/tiny/hx8357d.c +++ b/drivers/gpu/drm/tiny/hx8357d.c @@ -18,7 +18,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/ili9163.c b/drivers/gpu/drm/tiny/ili9163.c index 9a1a5943bee01..ca0451f799625 100644 --- a/drivers/gpu/drm/tiny/ili9163.c +++ b/drivers/gpu/drm/tiny/ili9163.c @@ -9,7 +9,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/ili9225.c b/drivers/gpu/drm/tiny/ili9225.c index a79da2b4af647..815bab2858231 100644 --- a/drivers/gpu/drm/tiny/ili9225.c +++ b/drivers/gpu/drm/tiny/ili9225.c @@ -20,7 +20,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/ili9341.c b/drivers/gpu/drm/tiny/ili9341.c index 69b265e78096b..420f6005a9568 100644 --- a/drivers/gpu/drm/tiny/ili9341.c +++ b/drivers/gpu/drm/tiny/ili9341.c @@ -17,7 +17,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c index c80028bb1d110..1bb847466b107 100644 --- a/drivers/gpu/drm/tiny/ili9486.c +++ b/drivers/gpu/drm/tiny/ili9486.c @@ -16,7 +16,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/mi0283qt.c b/drivers/gpu/drm/tiny/mi0283qt.c index bc522fb3d94d1..47df2b5a3048f 100644 --- a/drivers/gpu/drm/tiny/mi0283qt.c +++ b/drivers/gpu/drm/tiny/mi0283qt.c @@ -15,7 +15,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/ofdrm.c b/drivers/gpu/drm/tiny/ofdrm.c index 0e1cc2369afcc..cee626f730e79 100644 --- a/drivers/gpu/drm/tiny/ofdrm.c +++ b/drivers/gpu/drm/tiny/ofdrm.c @@ -11,7 +11,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/panel-mipi-dbi.c b/drivers/gpu/drm/tiny/panel-mipi-dbi.c index 955a61d628e7c..03a7d569cd568 100644 --- a/drivers/gpu/drm/tiny/panel-mipi-dbi.c +++ b/drivers/gpu/drm/tiny/panel-mipi-dbi.c @@ -16,7 +16,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c index e62f4d16b2c6b..c2677d081a7b6 100644 --- a/drivers/gpu/drm/tiny/repaper.c +++ b/drivers/gpu/drm/tiny/repaper.c @@ -26,7 +26,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c index cbb100753154e..162eb44dcba89 100644 --- a/drivers/gpu/drm/tiny/simpledrm.c +++ b/drivers/gpu/drm/tiny/simpledrm.c @@ -15,7 +15,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/st7586.c b/drivers/gpu/drm/tiny/st7586.c index b6f620b902e6d..ce57fa9917e51 100644 --- a/drivers/gpu/drm/tiny/st7586.c +++ b/drivers/gpu/drm/tiny/st7586.c @@ -16,7 +16,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tiny/st7735r.c b/drivers/gpu/drm/tiny/st7735r.c index c36ba08acda18..15d9cf283c66a 100644 --- a/drivers/gpu/drm/tiny/st7735r.c +++ b/drivers/gpu/drm/tiny/st7735r.c @@ -18,7 +18,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c index 611785e097576..0d05c386d3030 100644 --- a/drivers/gpu/drm/tve200/tve200_drv.c +++ b/drivers/gpu/drm/tve200/tve200_drv.c @@ -40,7 +40,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c index 91effdcefb6d5..e81352126a0f2 100644 --- a/drivers/gpu/drm/udl/udl_drv.c +++ b/drivers/gpu/drm/udl/udl_drv.c @@ -7,7 +7,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/vboxvideo/vbox_drv.c b/drivers/gpu/drm/vboxvideo/vbox_drv.c index 1cd716eb17a1c..b450f449a3aba 100644 --- a/drivers/gpu/drm/vboxvideo/vbox_drv.c +++ b/drivers/gpu/drm/vboxvideo/vbox_drv.c @@ -14,7 +14,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 2027063fdc309..b66bf7aea6327 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.c +++ b/drivers/gpu/drm/vc4/vc4_drv.c @@ -33,7 +33,7 @@ #include #include #include -#include +#include #include #include diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_drv.c index 0035affc3e590..ae97b98750b6d 100644 --- a/drivers/gpu/drm/virtio/virtgpu_drv.c +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c @@ -35,6 +35,7 @@ #include #include #include +#include #include #include "virtgpu_drv.h" diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index 0ffe5f0e33f75..293dbca50c316 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -17,7 +17,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c index 63496773f7142..bd02cb0e6837f 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c @@ -35,7 +35,7 @@ #include #include -#include +#include #include #include #include diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c index 1847792cf13db..776ef54802064 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c @@ -19,7 +19,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 3dfb5d1093871..ecfcd2c56d95a 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -287,9 +287,6 @@ int drm_fb_helper_debug_leave(struct fb_info *info); void drm_fb_helper_lastclose(struct drm_device *dev); void drm_fb_helper_output_poll_changed(struct drm_device *dev); - -void drm_fbdev_generic_setup(struct drm_device *dev, - unsigned int preferred_bpp); #else static inline void drm_fb_helper_prepare(struct drm_device *dev, struct drm_fb_helper *helper, @@ -474,12 +471,6 @@ static inline void drm_fb_helper_lastclose(struct drm_device *dev) static inline void drm_fb_helper_output_poll_changed(struct drm_device *dev) { } - -static inline void -drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp) -{ -} - #endif #endif diff --git a/include/drm/drm_fbdev_generic.h b/include/drm/drm_fbdev_generic.h new file mode 100644 index 0000000000000..75799342098dc --- /dev/null +++ b/include/drm/drm_fbdev_generic.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: MIT */ + +#ifndef DRM_FBDEV_GENERIC_H +#define DRM_FBDEV_GENERIC_H + +struct drm_device; + +#ifdef CONFIG_DRM_FBDEV_EMULATION +void drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp); +#else +static inline void drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp) +{ } +#endif + +#endif -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:25:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:25:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436747.691004 (Exim 4.92) (envelope-from ) id 1oqc6D-0000lX-GE; Thu, 03 Nov 2022 15:25:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436747.691004; Thu, 03 Nov 2022 15:25:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqc6D-0000kt-AP; Thu, 03 Nov 2022 15:25:45 +0000 Received: by outflank-mailman (input) for mailman id 436747; Thu, 03 Nov 2022 15:25:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqbvu-0001nI-2M for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:15:06 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 48a8c2d0-5b8a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:15:00 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 426EA1F900; Thu, 3 Nov 2022 15:15:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B325D13AAF; Thu, 3 Nov 2022 15:15:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8LVrKvXaY2PBGgAAMHmgww (envelope-from ); Thu, 03 Nov 2022 15:15:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48a8c2d0-5b8a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667488502; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HgxG97nmydzNCVipkHzgPf3aCI1grjy0cqRB+0/Ck74=; b=kcgtu9PKiyMKUj8GxwYh+/ORcWz7+UhaRslLpGT/0EYXH4EiaVWbRO1rXX+RnuBF5OjTj2 Xec3+JBI90xwvAliyOtjTY3B94F0kq3muNjviJe52VZzz9N0Nd9Yc6Mfuv+xD0GBg/lfBm F9ORYgDvXcxRapg5A3YBRJRoUxxeEtI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667488502; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HgxG97nmydzNCVipkHzgPf3aCI1grjy0cqRB+0/Ck74=; b=BTICG+mmiOcUdGuFYoU4C0nyEBYhfhmngf4Ev9loTA8Jed/wbNJaxvDDbye+EQL4FS5m+K t/wO99a1pUjQkKCQ== From: Thomas Zimmermann To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: "linux-hyperv@vger.kernel.orglinux-hyperv"@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 23/23] drm/fb-helper: Clarify use of last_close and output_poll_changed Date: Thu, 3 Nov 2022 16:14:46 +0100 Message-Id: <20221103151446.2638-24-tzimmermann@suse.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221103151446.2638-1-tzimmermann@suse.de> References: <20221103151446.2638-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Clarify documentation in the use of struct drm_driver.last_close and struct drm_mode_config_funcs.output_poll_changed. Those callbacks should not be said for fbdev implementations on top of struct drm_client_funcs. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 5eb2f0d4bf8d4..e0384f967c0b3 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -89,11 +89,13 @@ static DEFINE_MUTEX(kernel_fb_helper_lock); * It will automatically set up deferred I/O if the driver requires a shadow * buffer. * - * At runtime drivers should restore the fbdev console by using + * Existing fbdev implementations should restore the fbdev console by using * drm_fb_helper_lastclose() as their &drm_driver.lastclose callback. * They should also notify the fb helper code from updates to the output * configuration by using drm_fb_helper_output_poll_changed() as their - * &drm_mode_config_funcs.output_poll_changed callback. + * &drm_mode_config_funcs.output_poll_changed callback. New implementations + * of fbdev should be build on top of struct &drm_client_funcs, which handles + * this automatically. Setting the old callbacks should be avoided. * * For suspend/resume consider using drm_mode_config_helper_suspend() and * drm_mode_config_helper_resume() which takes care of fbdev as well. -- 2.38.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 15:41:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 15:41:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436773.691020 (Exim 4.92) (envelope-from ) id 1oqcLP-0004XL-0f; Thu, 03 Nov 2022 15:41:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436773.691020; Thu, 03 Nov 2022 15:41:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqcLO-0004XE-UF; Thu, 03 Nov 2022 15:41:26 +0000 Received: by outflank-mailman (input) for mailman id 436773; Thu, 03 Nov 2022 15:41:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqcLN-0004X8-Ra for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 15:41:26 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70053.outbound.protection.outlook.com [40.107.7.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f4bd02ba-5b8d-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 16:41:17 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9276.eurprd04.prod.outlook.com (2603:10a6:10:357::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov 2022 15:41:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 15:41:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4bd02ba-5b8d-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TTTlEDKHK6F7PLDfjtLtgiQIYTwMKB2NK3XLzkVUOp3QG6M4b8IXAR0a6DqUfxvlFu85OadpgCWor8a7FJzb2JZ0tga1s+xNdP+sAiZrUoGarQda3HGB39LDA1JwgbG4ZA1G+6aTqqGoH0zOpKvW7CnVS5/0/+JiSI1UqCYSW546on7sh8NXYyVfDzehT+82DwecDR/I64PMGulv5lndbpwQE4XnJLNgHnJ0z0N7odFgOYmQrqbZ3dNjPTsrHvehuvASj8HWuIy2jOvoMdPrizQcFtXutq2vJpKQIxX6B9kW0qKCiBLG024TcfFhZpHREKoYDK8qD9DrScSR/PmyzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+hmyyJDgZX+O8LBzevAvj94q2P3zDTo/q2+m2tXPemk=; b=XFcFDn8QnunmAO9/gE7RphsZTpg53Ehe9v+y7PryenFag555n2ICKlsC/dtAAjDyLhJF2mE0s7uUWb/W20I2OtzBB8DmnujbIkuYkEN9Thc1/T5ljlomG5vFxWK7pEqg/E8W6gg9zg9cdF5XVkBABFRu6YacVMXkb2u4kzKN/KOr0IxsN2HeyU/ztYcTYQ0pFUK/r28stm6vJOJxqhqBAnXoiwxxfqCQJtsI8GvCdtLisOi9TEzALvq17CDQGQsstgbTXfKHdLQOGCuRdWop9ApFUP9MnaQKSufWHYjs5VN/R4jKF8+5pa2eeU5/8h09IpVuvPlSm7IhIlELTID2Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+hmyyJDgZX+O8LBzevAvj94q2P3zDTo/q2+m2tXPemk=; b=SEV6zJzZST2Ey49GCuJnErx2jyNO5fCUh/sNxVJ7g8E8uiz6doR4xAoOKHTBpkE3ib4K1EK7F9Z+40hpFnu3yKxO6J/MGjIdAKA3LJE5v22wliL/jR7K5/2gRislFgVqCzMlImkX+imeBkgyXTdYh1n8UN91pGAr68qcoZ270zgBPq4t6HZ5wQnDCI+ziocEs3TplQ42P80vtH8UUYI0UMa1/51v6dDh3CR21DnYkny7A33Z+0xRSoWSnFYRcpPb+aOpp3LxHNtI8uoP0M2k+XrLwUPQ2uQig25XL4meYJKQA2sP815NIGVDQWwxmk+TH1iFjAHYr+cgOJ1op5fuOA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 3 Nov 2022 16:41:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v4] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Content-Language: en-US From: Jan Beulich To: Jane Malalane Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , xen-devel@lists.xenproject.org, LKML References: <20220729070416.23306-1-jane.malalane@citrix.com> <1918c63f-0065-b468-3691-de6e314f4374@suse.com> In-Reply-To: <1918c63f-0065-b468-3691-de6e314f4374@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0124.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9276:EE_ X-MS-Office365-Filtering-Correlation-Id: 2226bb3c-ec66-4738-e682-08dabdb1db00 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4aFa/tXcH3M3RSsGsAHkOhm0MzmyOgKohsrKdUuPEvviNUuaEyjhyhhtucyUFc59rkchqy+XIyALWvllgUoTe2E/PvA0wNGI63sqBZmodnEF3tbx8QPIlJhU0QJ7nXH0ZSkhWcddZZWMqstBCepM0tUwMIOoSEB/ymkjaqlJURWxyZvE1Pdx8zAGFFtGnAVznRfh4dLoFdCV7tc7kGGDqe8pC89A1NqENon0tREEsycsn6QcX4jmQBMM5bPKZDC3+R2GdAjRLBw95TAVAun7yMg2XAWDFmcnYNPU+YVpZ55YU0UuoiKB1GgVHnqm++oNDuqtdjxxzm/7To1nttJCFCMU9L5TfR8hoPdj4ju+1Wyjl+Zpmhhp8TIJR4P1i2ngC8LhSJzo6JqRLg7G0Lp900f1NF+dS/7uf7oD0zQAG54dHAQPuqF/Xk/uAYit9/K2xodpoDnpwDtveDjMrmPvHSpfEejZQGSHZp/1SKEnk1FIY9jvENwARnvf1blp5jR1lD2gVAc0rsiTnW+GZCkhkPat6QgcF1akvyFxyr5UqrI8fZW1b5VoyKHPdgww67YpnBQcwTmzk3Y/4sXlQjzlvef+fmaCwW+d0tVLW+LqrLATcnlnz9wLAxAfs/5Aly5HqHYzXxCGNTlZlmbr5dJ1b3euSNBck/ggcw/C46VTd7NszKWYIJxFuufqlhCzbG+2iv9hzjjy13faar9cujGulQixP6v1L6GW833103dJv+cPwT+hfQNmQCz7MLZyYtOSPyDxfrzlOyOLjFfy6K8PbVwDsBWg2XZEaAj6JC9gbMCYtS1oq6Gj3K3vAeBc24WCH8F9w0ePhnrTg/yKBHq4Zw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(396003)(39860400002)(376002)(346002)(451199015)(31686004)(36756003)(66899015)(7416002)(38100700002)(5660300002)(2906002)(86362001)(83380400001)(31696002)(6512007)(186003)(6486002)(2616005)(6916009)(966005)(478600001)(26005)(4326008)(54906003)(66476007)(41300700001)(8936002)(8676002)(66556008)(66946007)(6506007)(316002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nk1PdmpyKytBcE9KUzN1S0oyTnJGdlJYN3BZU3hEZnloczgzTGYvQ3c3dHlY?= =?utf-8?B?NjFQYmJnV05CcTUzR3huMzN1WE0rT0xiRXgwaEdicEF0VFRJMVU0dXc2UllJ?= =?utf-8?B?ek9wSis1TmwwSURjako2Y2VsQTFrZkhOK3dYa0JHQkp0bFBDWVR3b2hYQ2hC?= =?utf-8?B?YUUzSU1xdE95cFBnWnRwdkt5TzNVeEFxYW5Bck9GRUFmMmxMbk1MaXkrc2Rs?= =?utf-8?B?dlF6UFl4Kzk5YWFJTklqSm5vR1kzMmtIV2ZqUlI2a0JoOVYyMnF6R0NXaWIx?= =?utf-8?B?L0JwRzlDaDlMZXlHU29OYTZBNDgrMjlrdk5pdU05MFZxb2w1NTI3S0lSRzI3?= =?utf-8?B?Z0RyenpNNUp3TFhVNHpsVk1SV2JlSDZ0UUhxeGNnbFBreHdpRWlMS3pJUGU4?= =?utf-8?B?T0daMVdaMnNPbUhtajdJOVBtVldES3lkMzVpVDQ0a1dlQUdCNVZ2b2VCQmhC?= =?utf-8?B?TTZZc2RTTVIreXZ5Y2U1eE9jRmI2ek5TWDVYOWpDV1kxVllHM3RybHNSM3lr?= =?utf-8?B?NFc4ZHBIOVZpZDBod0g0Y2hoMytaYWpkUnJyNWE1K01VZHVPd2hFV0xBekNO?= =?utf-8?B?Mk9pc2p0MUIycm8rQ3gvSXpuWUV6Yk5IS0c3eUE1b2VkWjdGQWFhQjdsbkhY?= =?utf-8?B?d25oWnNvZHE2M0xJck8wUlhxVVRqZmRZLzZhTERnMGdQUkVSRVRQbDVKZ2Zo?= =?utf-8?B?QmluOTNSV0lydUlMOTdjdStXNFZXZnRzQnN1Y2tNUlBkWWFRTnRYNU9pKzZx?= =?utf-8?B?RUl1MDh6YXNuQUdVMDBmTStIVk1heEFMdDQ5ZXA3Z0RLa0V5Q1lpNVN6Q1c2?= =?utf-8?B?SXhnd3FGdWx3SStpbXV4cjVvdnZKbFFJd21nN2lkNFJiRHZmUGJSSjFhSkFa?= =?utf-8?B?QldNcVRqZEJ3SmZqYnZkTTdYNG9EYWo1MDAvQlBjTG5RWGxZNGFCTS9jdmF6?= =?utf-8?B?a3FXQzJnN0pGK3QwYXo4ekhXcUZYQmZNWHRvY0xNMFY1UHd5SkE1dlVkS0tX?= =?utf-8?B?cGk4MWpXZEwwK09lTXI4eWNmdXp3eXdHbzV4ZUJ4N2lRakg0SHB2UUs2M3di?= =?utf-8?B?RjFmZlRFLzJ0SWJwTkdacjBsdXVvaTU4SDF5RWZCZDMxUDlvM1dMdTlydWNl?= =?utf-8?B?ZHVhU1ZQSDBPNWQzQ1A0TElGaDJnT2I0Y0E2SUlxS0VhQ0xXWHFOSjhiMHhC?= =?utf-8?B?dHJoUVFRdE1MUitvNDJ6TThmOEczekJGTHVjakhwYmJLNU1DaCthZWFpOEFF?= =?utf-8?B?TU5IWnRPMWw2cUJ0SDI1MWxCR3hDWUlHdW1xdnE5b3FacDZaVi9LYWJ0VlFk?= =?utf-8?B?bjRvZEFldTR4bE81bUEwY0VYSkRTUUFQWVFxdWF6S2dJMmFBRlJNNTRHbW5E?= =?utf-8?B?VmhSc0NmSkp1TlFHeWxrN212WnpLRU1XRFVPdWczVFQ4RkhMU0JzWU81bk43?= =?utf-8?B?c2R2a1FJSzI5VGU3OTB3MmdsK1ZIbFJXVGZEUlpKWVNPajFkb3IzaGYySkhY?= =?utf-8?B?TFRNSlhzcitmcjBMY1luOFNaTnd6OTBNaGJmcE03NzJRWjBTV1U0WjFnRTAy?= =?utf-8?B?WFd5R1BRdXl0QkVmQXhZdEJVbVhoRjR1NWQyYWtqaVFrQy9qc0RMLyt5OE9a?= =?utf-8?B?Qzg5YWlyaVIzeDhmd3lMYmRqWmZHMTR3R3huY2ZjSzVUQlNHSk9mSGw1MGlU?= =?utf-8?B?WVVoU2FMZFoyUExwLzdyWUJZMkVWYk9zU0VPSitRRjVSSkFxQlZXcTFFZFVH?= =?utf-8?B?VGFtTVdMM2lCVTNGV2s4MkRNYTVjMEpmdHZNQzdsYjlGbWY0L1pEZ2ZZcmUx?= =?utf-8?B?QytvT0d1UldaYmJhbWRkZ09BZHhxM3cyWjZqa3Zqa3JEWUoyV0wyN0VzU1pm?= =?utf-8?B?K0dYZDE3ZjNJRFhGK2kwaWtWc1A0N29FKzhYN3hHWkRzSXB2bTNmaVI1b05u?= =?utf-8?B?WkoxV0kyK3NicjJkcTBhZ0FDZmdzTmRZR040Z0haVTc4c1FQVU1aRnZvMS9Z?= =?utf-8?B?c0MrTmhWei9FR3dRZHpnT1Zid1dKMWF0OFhQYVpSSndhTko4ZGc3QUhqc284?= =?utf-8?B?YjFKWjk1V251SWpBc2VXQnZ0akUrSys5Z2tmcGtLR282ZUhWSTBSOXBuS1Z3?= =?utf-8?Q?ItHdY98FLNXe7Di3gggf3XrTW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2226bb3c-ec66-4738-e682-08dabdb1db00 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 15:41:20.8570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kDVNdi7mCwnlptPV9/Q2uSZKne8iQVH1ZlRq2dZeLHaAl4QaIcLmsLnjSfmfAtWbwFyJsptnZDZsLkfnr9uc6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9276 On 03.11.2022 14:38, Jan Beulich wrote: > On 29.07.2022 09:04, Jane Malalane wrote: >> @@ -125,6 +130,9 @@ DEFINE_IDTENTRY_SYSVEC(sysvec_xen_hvm_callback) >> { >> struct pt_regs *old_regs = set_irq_regs(regs); >> >> + if (xen_percpu_upcall) >> + ack_APIC_irq(); >> + >> inc_irq_stat(irq_hv_callback_count); >> >> xen_hvm_evtchn_do_upcall(); >> @@ -168,6 +176,15 @@ static int xen_cpu_up_prepare_hvm(unsigned int cpu) >> if (!xen_have_vector_callback) >> return 0; >> >> + if (xen_percpu_upcall) { >> + rc = xen_set_upcall_vector(cpu); > > From all I can tell at least for APs this happens before setup_local_apic(). > With there being APIC interaction in this operation mode, as seen e.g. in > the earlier hunk above, I think this is logically wrong. And it leads to > apic_pending_intr_clear() issuing its warning: The vector registration, as > an intentional side effect, marks the vector as pending. Unless IRQs were > enabled at any point between the registration and the check, there's > simply no way for the corresponding IRR bit to be dealt with (by > propagating to ISR when the interrupt is delivered, and then being cleared > from ISR by EOI). With Roger's help I now have a pointer to osstest also exposing the issue: http://logs.test-lab.xenproject.org/osstest/logs/174592/test-amd64-amd64-xl-pvhv2-intel/huxelrebe0---var-log-xen-console-guest-debian.guest.osstest.log.gz Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 03 16:36:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 16:36:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436879.691067 (Exim 4.92) (envelope-from ) id 1oqdCn-0007kM-PW; Thu, 03 Nov 2022 16:36:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436879.691067; Thu, 03 Nov 2022 16:36:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdCn-0007kF-Mr; Thu, 03 Nov 2022 16:36:37 +0000 Received: by outflank-mailman (input) for mailman id 436879; Thu, 03 Nov 2022 16:36:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdCl-0007k8-UH for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 16:36:35 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad908be4-5b95-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 17:36:34 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8A1CA1F385; Thu, 3 Nov 2022 16:36:33 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3EA7213480; Thu, 3 Nov 2022 16:36:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BTUmDRHuY2NdSAAAMHmgww (envelope-from ); Thu, 03 Nov 2022 16:36:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad908be4-5b95-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667493393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=N8W4oIeALHkDkc0s+2qqiC97IZ8xBjyHM6ZTLQ6KBMQ=; b=m+e4pIr7U1jmpOa9v53WsjZG5ot6rqm9m/CUraOhoWrv5DnAW1oMk5PYFF3DEkwmB25rY9 uZzC8NUyEz1LPuYM7mJPEZXEKDLRmpkUJayONEyKFrkC0M7FeRkig2CytY84o80gs0+4pt jQzpbP2VF0D7By95XbveBatqDk+/Lgw= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang Subject: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers Date: Thu, 3 Nov 2022 17:36:31 +0100 Message-Id: <20221103163631.13145-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The code generated for the call_handlers_*() macros needs to avoid undefined behavior when multiple handlers share the same priority. The issue is the hypercall number being unverified fed into the macros and then used to set a mask via "mask = 1ULL << ". Avoid a shift amount of more than 63 by setting mask to zero in case the hypercall number is too large. Fixes: eca1f00d0227 ("xen: generate hypercall interface related code") Signed-off-by: Juergen Gross --- xen/scripts/gen_hypercall.awk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/scripts/gen_hypercall.awk b/xen/scripts/gen_hypercall.awk index 34840c514f..08b2f70bdb 100644 --- a/xen/scripts/gen_hypercall.awk +++ b/xen/scripts/gen_hypercall.awk @@ -263,7 +263,7 @@ END { printf("#define call_handlers_%s(num, ret, a1, a2, a3, a4, a5) \\\n", ca); printf("({ \\\n"); if (need_mask) - printf(" uint64_t mask = 1ULL << num; \\\n"); + printf(" uint64_t mask = (num > 63) ? 0 : 1ULL << num; \\\n"); printf(" "); for (pl = 1; pl <= n_prios[ca]; pl++) { if (prios[ca, p_list[pl]] > 1) { -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 16:45:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 16:45:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436888.691079 (Exim 4.92) (envelope-from ) id 1oqdLb-0001AB-QU; Thu, 03 Nov 2022 16:45:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436888.691079; Thu, 03 Nov 2022 16:45:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdLb-0001A4-NI; Thu, 03 Nov 2022 16:45:43 +0000 Received: by outflank-mailman (input) for mailman id 436888; Thu, 03 Nov 2022 16:45:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdLa-000197-S2 for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 16:45:43 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2086.outbound.protection.outlook.com [40.107.103.86]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f3ea666c-5b96-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 17:45:41 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6846.eurprd04.prod.outlook.com (2603:10a6:803:12f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov 2022 16:45:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 16:45:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3ea666c-5b96-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IUKtGXSkLvaco79hV0W2ZSiMcVT0KvJwfMYKCdznPrf9rlaPQm/BsiROJ19xSGURHjoA3qYBXS203no8zvqKzVgVEonJUsW2Jms/E3Ylj7vrc5U286D08e6KrO5qpzgA6I6hDEoftFRkLOem8gYYccIE83L5tELoW1jYTx/hUHqqOJkZnlWj1wtbexJviOxtnUT/+sulpjWujVzKllFKba24zySXKdfMVwoTu6aZLn3WegKgW5TpVA+DVtXNVuAnbDq9OJJtno78d49noJL7HtI/FeNX9D3edhyxjoPLwvlL+Vz09slfgu3Odw6Zwm6/lZqXfG5P1d4juwmbGh8eGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ciM688YFTQ2O2s8+rccgGozuFycwStj+ET2HgOKN0Jc=; b=XQ6tt//dC5PtUYSGwDdZNWVAVSUDDzusfUhdIXmpzBkMf28qI5yK11pM7luNn8Cfokfw2216O+B1zfuODYgZGTiSwnM4YefG2EEbhLw5MUvxPGn8hbsOpeM8cstKemreG9waTpTaNckLIAH6EBE1E+yPKd9IsX+C8xavUrOBlYQYXSs4AzqnsqaNjShcu/4pLPoIXj9peHfxQT5/cPTtWaYYKSb/Gkmssxg12CpapUZW0bTnN7Js8s/T8fTntPYtDleTGI4XKlVDUowqM4TeICzyvfDdj4vSjPwKLThHYKf4/OoW07D5ZyIWR9XOCPqJsLbwUSHGp7O8//fO5Ogiiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ciM688YFTQ2O2s8+rccgGozuFycwStj+ET2HgOKN0Jc=; b=24gUraJCoz7siwrRSngEt1iVIPzyKdBeTVhRk+46OYyiL0ZVkSl4YY5e/dVey8pkwyZCeEe4tUK3Spw3+eQtZR/5+Z4IxJptNiGT2I9OOLuH2CqufviO1U1J4FWHT73DGraDmDvrWrp8WBssu/haOPJ80kmchlh5RhVk60s3SqUJSW7nRaqskpACqMyBc9JWj968CIXimygkb8aeyl+quPjM7FsFPxXu/7CIUnKx8eZs22+5XQ9gEqIQn51h0j93247WI/hlNCmEYetdRy2qh7/1FcMJOU5vg8xbIouxSqfgs/fKsuu36e5tER0mDtVikd0tBACsGUFxOhon8YyqFQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 3 Nov 2022 17:45:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang , xen-devel@lists.xenproject.org References: <20221103163631.13145-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20221103163631.13145-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6846:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e6513b1-e413-4148-3593-08dabdbad6fb X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8wJ2oNopDhEEMkT4fM136HZo6TOa6yU6P6s3s1Oa5tkvivanmfsNvB3lNRNem9RMq4VpM6tULvy6qQrl2/CjV/hwX/UfZpLD+qZWgfbOcRqoEIYVnN3TEMWr8adxFXFptdTIf8iRSeJDU9J20pTeXN5Fsf73OS5niDUuHF7O3kmiuC9dsI7OM2FsOs7IeMkmpcvewVP5iCW3RbdqSQFzvqxghvLaTnMCd/bK1khVgO5nFA/y7qy4WFRnChqsWfZaimlHmyZxVSd1zbJmXSCE4ykhTjHOM4+04oBqybrco1c7onYqRf5dQXSKln7Y/wGZICgqN8XZxkDCyZadvNPZnRKvHlmTnBQ1Lns48Fs1zuJ9NPg+v+bCZNv0UbkUMQV3233WWPq6prVkR4WV2SPHuPr5jgxkm+aFBjTWRioJLA7su9rnE9vzDkrU8Kyb3Xtl1kVbH/shFXOSt+8JsWqcgZJx26bVPW1aenDdu1hSPAEZgxmaUGiYeoxoE6rA/GiuhHTLqu3B1zLzpaRohJKGK7o1SML/meBkAKyftyN9Ue8TvBAk4qdCgjlAEhvEmL6ho4RRVZaa/+CJ4fQZp1JLEOa+Z2bmGrhGReq+iQbe0S+a9cUKDvENJFTR1az+TXVDOkS/QFWJ5Sz2aZ7U9cBfUlbDo++3M3blFuQ20JXhCMcTE+HqyXbcPD91JaO4zR3LpwjLte0NAWVDgS2N6gHlIv/F7iFe+4bMtTUhCzgPEIhREZlCQm1DrOM+izGMQlcQ6JwNVxQ6RFA+DQ2RkNyfEEHVhuL4wg87dzoskC/y5dM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(396003)(366004)(39860400002)(136003)(451199015)(6486002)(186003)(478600001)(2616005)(2906002)(54906003)(38100700002)(6636002)(37006003)(4326008)(86362001)(8936002)(26005)(6512007)(41300700001)(66476007)(316002)(31696002)(6862004)(66946007)(53546011)(66556008)(31686004)(8676002)(5660300002)(36756003)(83380400001)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEt1WkR0SFI3ZUN3bjdZVi9kQ3lPS3R0WStkZlpYN1dXWWpMZmp6R1BmOW5o?= =?utf-8?B?Mm1iQ3MrZDRRbUd4bzFxczZWMHVOVzdVMkFXOTg1ZDBUOXRoM2tSOHlFSmdn?= =?utf-8?B?SXd0WHhoYW9CSnFlWDh2Q05yQ3ZZdnJPSXJqSWZLT3ovT3B3dEhqc2ZMMjAr?= =?utf-8?B?bVM5MlhycjU4OWNQcnQ3cHU0WllzS1pzVU5UMFdvZVFqNWJST1hiUlN4eTBU?= =?utf-8?B?c3MrU3NEODFpdUx0OS9MTGJvdE5hcmZySkFNbitxU2p2MzV6TWZ3c1hUakNl?= =?utf-8?B?Y3MzSWxKemRaNWZDS3NnbkhXenVVUFhKd3lBYkxqdnF0Z3ZHTzZvZGVJUzFh?= =?utf-8?B?b21oaXlGTTQyMWxaV09DeFpvOXRQRUlsem9FMTZ3c091dHg3R0htaFRpdmVj?= =?utf-8?B?TDlabWRRQWtWVXAxbE5rWElsTmE5aVJJT1RzVVpQZ1RyQ3cvL0p5SGIxL0U0?= =?utf-8?B?cUU5M3pkWHRrZUFBejhUYlNJREVGcXJoUFNRVWhlWkVpSlBnQUJ6cjVveDda?= =?utf-8?B?eUVWd0IvQ2pNeGtVUGc0ZnZCTVJSMk5VU0JPY3lndFRHY3l4QXZsYjRldXpU?= =?utf-8?B?WS9tYXZZcFpUeVZka2VPVHQxVXRJWFh5L3ZCQ2hQS1dyQzF2Z1QyQWxqZXRm?= =?utf-8?B?UlJwZ0dhUDJUM3Fueko4dHUyTVl5L0EyZko0SndGeWRxblc5VjVHcGYzWjdE?= =?utf-8?B?TmlTR25qNFVrOGJvYjgySXJyWWNaUlB6Y1Z1SFBVcWpsTFhRM05ydlBoaHVW?= =?utf-8?B?M2l1NmMvSmt1dE9sV2dqMWIzUGxabTk0d3FZMkNVS2piUlNmL0gzOFVyQWZZ?= =?utf-8?B?NnZsVmZtYjhJQTJwWGxXckJFNnE5QjREalNmYkpkekJZeUU1MjFSbGxnYklK?= =?utf-8?B?S09lamdNdUpZK1AyckU4eUJGNEhOOHZWRERlaTJTU09neXhDUHpjakV1YkdK?= =?utf-8?B?MUt5RSt3QjV6NitQNXZicFFPSFQ2SXRjUTNHZDBxcEwwVlpnRkNacDRyUDdu?= =?utf-8?B?QXgxMkluaXNzd1RibElrVHVQSGh5NG5aNStxZmRRRGsyM1FkQms1UUtEazlT?= =?utf-8?B?VVhkbFBSaXVZUmczcUQ4ZlF1aFNicFc4MFU1OTFVejBkREJHbjAwR0NUdktu?= =?utf-8?B?SUR2UXVscjVlcnU4QjdTMzRHKzVEWkV1cjBLU0JQc1NaNnQ1d0VEdjZHZm9y?= =?utf-8?B?THQwWmxZNW45YUMwOWU3cGhWUmpaYUk0aHFlTUhUb2o5SlUrNXhXcTNtT01y?= =?utf-8?B?a1BtUnMva2doNDVGRWJ1WThNM1B1VUhTUEhIbmZJZ3ZEQmI4Z3pOSVNBTWNC?= =?utf-8?B?MUZDTUppUEdTR1JMeWF2cVZsOGV6cGNFZjh3YmpyeFN3WHpRZ1VTcTF0OVl5?= =?utf-8?B?VHRIYzBGSmd6MHRoVUloZEI3a3orRFpLQU1MMm5IWUpUNVg3YUtUZmVlL1lk?= =?utf-8?B?TzZFTFprRFFMQnBxZkNGSlB5eU0rb1JLYlpoWFh2R3k4UGtkL1gxNnVUd0Vk?= =?utf-8?B?TFFRMUJpSVp3V1UyRkJqQ2VOKzJLTldtVTVoQ05zeXovdWhMUXZUSVJ3Vngz?= =?utf-8?B?d01pVmtuekZrYlNsU0xLU3B2c3NtSkxRMzlWYndmTmhIcTh5Sk1MN2pWNVlz?= =?utf-8?B?d0U2Q3YwSkZmc1J0TEdUanBFZzhUVDhmYit1eUt3K1hIV0pJMDJkRVBIVnhj?= =?utf-8?B?cytXL2FScmU4RGxGU1l6aVplMFBJdDB6VmZQN1dsUTF0clFOUGg2NE9qalJ4?= =?utf-8?B?UkRtN1g4NjRyYmhsSlNWOXlROXcvcGwvUXBEaDNuMjVVVnNRbFVMa3J0WlhU?= =?utf-8?B?VGVrVkV4dFhwNnRwRFFYOGJjdDR5eVpmdGRZRktzb0lmc0xOTW53VnZkVENy?= =?utf-8?B?OURtdHkrN2w1V0tXVmgvVkhIVnk1VDhxZlIwZERVbXNvUFpxSEJ0ZFphY2Rq?= =?utf-8?B?ckkranoyelZMT0twRjluN0RrMkd2UUE2RnlrbWpsQU1oMCt6S1ZqU215b1FF?= =?utf-8?B?Ky9Mc0t0Q3g2THZyM2hYSnI3MXJFWXBvVlVvVHZRMmR5RFBtMWh1SnN6MitC?= =?utf-8?B?emd4WUg3VkdMYnhIUDRFUmMwcU5SL2NxY3IzMTMyVVpGU000WGg1Y2FCa1Nk?= =?utf-8?Q?EA3sR4b17sDMwcy80f9beCNyH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e6513b1-e413-4148-3593-08dabdbad6fb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 16:45:39.5950 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pq/YORNNkMGmJYG+m0gdwlej42ma4R7e2E0gdvhVILx5OxiEc7ziCtLWDJ1tFsIuvoKfILNLd2OsY9NJ6W7Tpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6846 On 03.11.2022 17:36, Juergen Gross wrote: > The code generated for the call_handlers_*() macros needs to avoid > undefined behavior when multiple handlers share the same priority. > The issue is the hypercall number being unverified fed into the macros > and then used to set a mask via "mask = 1ULL << ". > > Avoid a shift amount of more than 63 by setting mask to zero in case > the hypercall number is too large. > > Fixes: eca1f00d0227 ("xen: generate hypercall interface related code") > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich albeit preferably with ... > --- a/xen/scripts/gen_hypercall.awk > +++ b/xen/scripts/gen_hypercall.awk > @@ -263,7 +263,7 @@ END { > printf("#define call_handlers_%s(num, ret, a1, a2, a3, a4, a5) \\\n", ca); > printf("({ \\\n"); > if (need_mask) > - printf(" uint64_t mask = 1ULL << num; \\\n"); > + printf(" uint64_t mask = (num > 63) ? 0 : 1ULL << num; \\\n"); ... "num" also properly parenthesized (this is part of a macro definition in the output after all). Easy enough to take care of while committing. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 03 16:46:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 16:46:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436893.691090 (Exim 4.92) (envelope-from ) id 1oqdMa-0001lV-74; Thu, 03 Nov 2022 16:46:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436893.691090; Thu, 03 Nov 2022 16:46:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdMa-0001lO-49; Thu, 03 Nov 2022 16:46:44 +0000 Received: by outflank-mailman (input) for mailman id 436893; Thu, 03 Nov 2022 16:46:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdMY-000197-0X for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 16:46:42 +0000 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1548d4d0-5b97-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 17:46:39 +0100 (CET) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2022 09:46:36 -0700 Received: from black.fi.intel.com ([10.237.72.28]) by orsmga007.jf.intel.com with ESMTP; 03 Nov 2022 09:46:29 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 858A5F7; Thu, 3 Nov 2022 18:46:52 +0200 (EET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1548d4d0-5b97-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667493999; x=1699029999; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=6sEwb2LvPX9v9prH3mu2nEGi0LVqQc1+Me9tIfh9Gsk=; b=Nd7KO1lUqzSnMtk3j7fYSRN4GBMulzyp8KtXzvtG6CJ3U8l0+Bw02ZYM 56Q0/w04hbsprEsCu7TpWXhSVHW587RksAV9JZ3yEL2KDC35A8DgUON9T S9V3ICr0AbOnFFdGzl+JWCeDkn+TJ2uCNhdvnrKcDIYU80ENRVrjjvMF4 QUfEk+tVFXZSWMcVeL34qNT0ZZ1z/dnzaFvI2fa3BGd6WgiLFY42JwZV0 FZvWu40M4ewv8maytGzDy0gsJ2WHoIajwyNW4eo7g+olJU+E9weHXxkKP gTgBjOqn60ynR9iyRXS6K2OkGl47/em5PD+/9CmQm1sHGCEdA6k878nFy g==; X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="309732828" X-IronPort-AV: E=Sophos;i="5.96,134,1665471600"; d="scan'208";a="309732828" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="629408020" X-IronPort-AV: E=Sophos;i="5.96,134,1665471600"; d="scan'208";a="629408020" From: Andy Shevchenko To: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Andy Shevchenko , Mika Westerberg , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH v2 0/4] PCI: Add pci_dev_for_each_resource() helper and refactor bus one Date: Thu, 3 Nov 2022 18:46:40 +0200 Message-Id: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Provide two new helper macros to iterate over PCI device resources and convert users. Looking at it, refactor existing pci_bus_for_each_resource() and convert users accordingly. This applies on top of this patch Mika sent out earlier: https://lore.kernel.org/linux-pci/20221103103254.30497-1-mika.westerberg@linux.intel.com/ Changelog v2: - refactor to have two macros - refactor existing pci_bus_for_each_resource() in the same way and convert users Andy Shevchenko (3): PCI: Split pci_bus_for_each_resource_p() out of pci_bus_for_each_resource() EISA: Convert to use pci_bus_for_each_resource_p() pcmcia: Convert to use pci_bus_for_each_resource_p() Mika Westerberg (1): PCI: Introduce pci_dev_for_each_resource() .clang-format | 3 +++ arch/alpha/kernel/pci.c | 5 ++--- arch/arm/kernel/bios32.c | 16 ++++++------- arch/mips/pci/pci-legacy.c | 3 +-- arch/powerpc/kernel/pci-common.c | 5 ++--- arch/sparc/kernel/leon_pci.c | 5 ++--- arch/sparc/kernel/pci.c | 10 ++++----- arch/sparc/kernel/pcic.c | 5 ++--- drivers/eisa/pci_eisa.c | 4 ++-- drivers/pci/bus.c | 7 +++--- drivers/pci/hotplug/shpchp_sysfs.c | 8 +++---- drivers/pci/pci.c | 5 ++--- drivers/pci/probe.c | 2 +- drivers/pci/remove.c | 5 ++--- drivers/pci/setup-bus.c | 36 ++++++++++++------------------ drivers/pci/setup-res.c | 4 +--- drivers/pci/xen-pcifront.c | 4 +--- drivers/pcmcia/rsrc_nonstatic.c | 9 +++----- drivers/pcmcia/yenta_socket.c | 3 +-- include/linux/pci.h | 25 +++++++++++++++++---- 20 files changed, 78 insertions(+), 86 deletions(-) -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 16:46:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 16:46:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436894.691101 (Exim 4.92) (envelope-from ) id 1oqdMb-00021A-Er; Thu, 03 Nov 2022 16:46:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436894.691101; Thu, 03 Nov 2022 16:46:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdMb-00020z-BD; Thu, 03 Nov 2022 16:46:45 +0000 Received: by outflank-mailman (input) for mailman id 436894; Thu, 03 Nov 2022 16:46:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdMZ-000197-8j for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 16:46:43 +0000 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 17dbde70-5b97-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 17:46:42 +0100 (CET) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2022 09:46:37 -0700 Received: from black.fi.intel.com ([10.237.72.28]) by orsmga007.jf.intel.com with ESMTP; 03 Nov 2022 09:46:29 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id AA5DF1E5; Thu, 3 Nov 2022 18:46:52 +0200 (EET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17dbde70-5b97-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667494002; x=1699030002; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=S2RJPvl3baq0S1jZ0H3vH8ZxE7YEfK7nHVPBJ+ytMMo=; b=b9zyzqy4nyQafoLSSALcjyBPGKY3fREchT6AelebUyev9oFblQH7KXQV 3i55+GvtyqJrrTvY5G+9e0VtyfOatVwmYFx0/hYY7nwL+5TMDWw5gC7Bs 8CkCYiSvoctKfWV4ZeryWgL4vhu2Ao3PyudurXF/CZz7j+1oIfWyDJ2LR xgbCu2MOOrgH7oxDnNFSyqy0rVNolfWy1pYs5ffjAOlhvYp20P9VKdIPw q3dkYIUnAPZ7Z1kErE782BUt+iTq53FYlmhGphQ0yBhkoy6O1OIEiidvI AoXqr496QBuXLPsHBBC9BrBoq1C8pvPlp0VWsWIukKBzZKKpY1Mz70Mg5 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="309732834" X-IronPort-AV: E=Sophos;i="5.96,134,1665471600"; d="scan'208";a="309732834" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="629408025" X-IronPort-AV: E=Sophos;i="5.96,134,1665471600"; d="scan'208";a="629408025" From: Andy Shevchenko To: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Andy Shevchenko , Mika Westerberg , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH v2 2/4] PCI: Split pci_bus_for_each_resource_p() out of pci_bus_for_each_resource() Date: Thu, 3 Nov 2022 18:46:42 +0200 Message-Id: <20221103164644.70554-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> References: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Refactor pci_bus_for_each_resource() in the same way as it's done in pci_dev_for_each_resource() case. This will allow to hide iterator inside the loop, where it's not used otherwise. No functional changes intended. Signed-off-by: Andy Shevchenko --- .clang-format | 1 + drivers/pci/bus.c | 7 +++---- drivers/pci/hotplug/shpchp_sysfs.c | 8 ++++---- drivers/pci/pci.c | 5 ++--- drivers/pci/probe.c | 2 +- drivers/pci/setup-bus.c | 10 ++++------ include/linux/pci.h | 14 ++++++++++---- 7 files changed, 25 insertions(+), 22 deletions(-) diff --git a/.clang-format b/.clang-format index 08d579fea6cf..b61fd8791346 100644 --- a/.clang-format +++ b/.clang-format @@ -520,6 +520,7 @@ ForEachMacros: - 'of_property_for_each_string' - 'of_property_for_each_u32' - 'pci_bus_for_each_resource' + - 'pci_bus_for_each_resource_p' - 'pci_dev_for_each_resource' - 'pci_dev_for_each_resource_p' - 'pci_doe_for_each_off' diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c index 3cef835b375f..fc8e9c11c5f2 100644 --- a/drivers/pci/bus.c +++ b/drivers/pci/bus.c @@ -161,13 +161,13 @@ static int pci_bus_alloc_from_region(struct pci_bus *bus, struct resource *res, void *alignf_data, struct pci_bus_region *region) { - int i, ret; struct resource *r, avail; resource_size_t max; + int ret; type_mask |= IORESOURCE_TYPE_BITS; - pci_bus_for_each_resource(bus, r, i) { + pci_bus_for_each_resource_p(bus, r) { resource_size_t min_used = min; if (!r) @@ -264,9 +264,8 @@ bool pci_bus_clip_resource(struct pci_dev *dev, int idx) struct resource *res = &dev->resource[idx]; struct resource orig_res = *res; struct resource *r; - int i; - pci_bus_for_each_resource(bus, r, i) { + pci_bus_for_each_resource_p(bus, r) { resource_size_t start, end; if (!r) diff --git a/drivers/pci/hotplug/shpchp_sysfs.c b/drivers/pci/hotplug/shpchp_sysfs.c index 64beed7a26be..ff04f0c5e7c3 100644 --- a/drivers/pci/hotplug/shpchp_sysfs.c +++ b/drivers/pci/hotplug/shpchp_sysfs.c @@ -24,16 +24,16 @@ static ssize_t show_ctrl(struct device *dev, struct device_attribute *attr, char *buf) { struct pci_dev *pdev; - int index, busnr; struct resource *res; struct pci_bus *bus; size_t len = 0; + int busnr; pdev = to_pci_dev(dev); bus = pdev->subordinate; len += sysfs_emit_at(buf, len, "Free resources: memory\n"); - pci_bus_for_each_resource(bus, res, index) { + pci_bus_for_each_resource_p(bus, res) { if (res && (res->flags & IORESOURCE_MEM) && !(res->flags & IORESOURCE_PREFETCH)) { len += sysfs_emit_at(buf, len, @@ -43,7 +43,7 @@ static ssize_t show_ctrl(struct device *dev, struct device_attribute *attr, char } } len += sysfs_emit_at(buf, len, "Free resources: prefetchable memory\n"); - pci_bus_for_each_resource(bus, res, index) { + pci_bus_for_each_resource_p(bus, res) { if (res && (res->flags & IORESOURCE_MEM) && (res->flags & IORESOURCE_PREFETCH)) { len += sysfs_emit_at(buf, len, @@ -53,7 +53,7 @@ static ssize_t show_ctrl(struct device *dev, struct device_attribute *attr, char } } len += sysfs_emit_at(buf, len, "Free resources: IO\n"); - pci_bus_for_each_resource(bus, res, index) { + pci_bus_for_each_resource_p(bus, res) { if (res && (res->flags & IORESOURCE_IO)) { len += sysfs_emit_at(buf, len, "start = %8.8llx, length = %8.8llx\n", diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 2127aba3550b..ff5b34337dab 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -782,9 +782,8 @@ struct resource *pci_find_parent_resource(const struct pci_dev *dev, { const struct pci_bus *bus = dev->bus; struct resource *r; - int i; - pci_bus_for_each_resource(bus, r, i) { + pci_bus_for_each_resource_p(bus, r) { if (!r) continue; if (resource_contains(r, res)) { @@ -802,7 +801,7 @@ struct resource *pci_find_parent_resource(const struct pci_dev *dev, * be both a positively-decoded aperture and a * subtractively-decoded region that contain the BAR. * We want the positively-decoded one, so this depends - * on pci_bus_for_each_resource() giving us those + * on pci_bus_for_each_resource_p() giving us those * first. */ return r; diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index b66fa42c4b1f..3662e867a124 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -533,7 +533,7 @@ void pci_read_bridge_bases(struct pci_bus *child) pci_read_bridge_mmio_pref(child); if (dev->transparent) { - pci_bus_for_each_resource(child->parent, res, i) { + pci_bus_for_each_resource_p(child->parent, res) { if (res && res->flags) { pci_bus_add_resource(child, res, PCI_SUBTRACTIVE_DECODE); diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index 336d6e6ef76a..83b2f308be7e 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -770,9 +770,8 @@ static struct resource *find_bus_resource_of_type(struct pci_bus *bus, unsigned long type) { struct resource *r, *r_assigned = NULL; - int i; - pci_bus_for_each_resource(bus, r, i) { + pci_bus_for_each_resource_p(bus, r) { if (r == &ioport_resource || r == &iomem_resource) continue; if (r && (r->flags & type_mask) == type && !r->parent) @@ -1204,7 +1203,7 @@ void __pci_bus_size_bridges(struct pci_bus *bus, struct list_head *realloc_head) additional_mmio_pref_size = 0; struct resource *pref; struct pci_host_bridge *host; - int hdr_type, i, ret; + int hdr_type, ret; list_for_each_entry(dev, &bus->devices, bus_list) { struct pci_bus *b = dev->subordinate; @@ -1228,7 +1227,7 @@ void __pci_bus_size_bridges(struct pci_bus *bus, struct list_head *realloc_head) host = to_pci_host_bridge(bus->bridge); if (!host->size_windows) return; - pci_bus_for_each_resource(bus, pref, i) + pci_bus_for_each_resource_p(bus, pref) if (pref && (pref->flags & IORESOURCE_PREFETCH)) break; hdr_type = -1; /* Intentionally invalid - not a PCI device. */ @@ -1333,12 +1332,11 @@ EXPORT_SYMBOL(pci_bus_size_bridges); static void assign_fixed_resource_on_bus(struct pci_bus *b, struct resource *r) { - int i; struct resource *parent_r; unsigned long mask = IORESOURCE_IO | IORESOURCE_MEM | IORESOURCE_PREFETCH; - pci_bus_for_each_resource(b, parent_r, i) { + pci_bus_for_each_resource_p(b, parent_r) { if (!parent_r) continue; diff --git a/include/linux/pci.h b/include/linux/pci.h index 3940435fa90a..165e4713360f 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1433,10 +1433,16 @@ int devm_request_pci_bus_resources(struct device *dev, /* Temporary until new and working PCI SBR API in place */ int pci_bridge_secondary_bus_reset(struct pci_dev *dev); -#define pci_bus_for_each_resource(bus, res, i) \ - for (i = 0; \ - (res = pci_bus_resource_n(bus, i)) || i < PCI_BRIDGE_RESOURCE_NUM; \ - i++) +#define __pci_bus_for_each_resource(bus, res, __i, vartype) \ + for (vartype __i = 0; \ + res = pci_bus_resource_n(bus, __i), __i < PCI_BRIDGE_RESOURCE_NUM; \ + __i++) + +#define pci_bus_for_each_resource(bus, res, i) \ + __pci_bus_for_each_resource(bus, res, i, ) + +#define pci_bus_for_each_resource_p(bus, res) \ + __pci_bus_for_each_resource(bus, res, i, unsigned int) int __must_check pci_bus_alloc_resource(struct pci_bus *bus, struct resource *res, resource_size_t size, -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 16:46:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 16:46:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436895.691112 (Exim 4.92) (envelope-from ) id 1oqdMc-0002He-M7; Thu, 03 Nov 2022 16:46:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436895.691112; Thu, 03 Nov 2022 16:46:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdMc-0002HR-I6; Thu, 03 Nov 2022 16:46:46 +0000 Received: by outflank-mailman (input) for mailman id 436895; Thu, 03 Nov 2022 16:46:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdMa-000197-OP for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 16:46:45 +0000 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 18a401a8-5b97-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 17:46:43 +0100 (CET) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2022 09:46:37 -0700 Received: from black.fi.intel.com ([10.237.72.28]) by orsmga007.jf.intel.com with ESMTP; 03 Nov 2022 09:46:29 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 9492D84; Thu, 3 Nov 2022 18:46:52 +0200 (EET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18a401a8-5b97-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667494003; x=1699030003; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7KOeu9S/6WwS70MbWmycrnSpR5o2Z9FEl6F8XDmROM0=; b=cWEU3n5oqQfsxlb0VcV7T6y/jnsjIJrVSlUQ4I59feLbCShG8pFK94kN ndsGfT8ea7HNEU+1fOj0WlNPXyGEvirBOKHmycd+JGb1p6S7tlkAD2D0L tncdoG/qX4GV22m9pcyhJ0tsRYB0Uob+CqGtAUAgSLd31D+cCcij/2Xk2 6bYN4zMPCHIMSCpQzputx5uEz2TanmIG9SvvlqbFgAbw37lOuy3B+vlru UmooJm5XxGkvMfRsvSA2lLvlNVb1qgzCc337sehyQfy7Tnd4WDVFpdaIS MJgYxJDHIIFceMsVEGO7X0xB1RApu00JdVcuiSoaOvTfpYFjFpJoPghNi w==; X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="309732836" X-IronPort-AV: E=Sophos;i="5.96,134,1665471600"; d="scan'208";a="309732836" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="629408023" X-IronPort-AV: E=Sophos;i="5.96,134,1665471600"; d="scan'208";a="629408023" From: Andy Shevchenko To: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Andy Shevchenko , Mika Westerberg , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH v2 1/4] PCI: Introduce pci_dev_for_each_resource() Date: Thu, 3 Nov 2022 18:46:41 +0200 Message-Id: <20221103164644.70554-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> References: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mika Westerberg Instead of open-coding it everywhere introduce a tiny helper that can be used to iterate over each resource of a PCI device, and convert the most obvious users into it. While at it drop doubled empty line before pdev_sort_resources(). No functional changes intended. Suggested-by: Andy Shevchenko Signed-off-by: Mika Westerberg Signed-off-by: Andy Shevchenko --- .clang-format | 2 ++ arch/alpha/kernel/pci.c | 5 ++--- arch/arm/kernel/bios32.c | 16 +++++++--------- arch/mips/pci/pci-legacy.c | 3 +-- arch/powerpc/kernel/pci-common.c | 5 ++--- arch/sparc/kernel/leon_pci.c | 5 ++--- arch/sparc/kernel/pci.c | 10 ++++------ arch/sparc/kernel/pcic.c | 5 ++--- drivers/pci/remove.c | 5 ++--- drivers/pci/setup-bus.c | 26 ++++++++++---------------- drivers/pci/setup-res.c | 4 +--- drivers/pci/xen-pcifront.c | 4 +--- include/linux/pci.h | 11 +++++++++++ 13 files changed, 47 insertions(+), 54 deletions(-) diff --git a/.clang-format b/.clang-format index f98481a53ea8..08d579fea6cf 100644 --- a/.clang-format +++ b/.clang-format @@ -520,6 +520,8 @@ ForEachMacros: - 'of_property_for_each_string' - 'of_property_for_each_u32' - 'pci_bus_for_each_resource' + - 'pci_dev_for_each_resource' + - 'pci_dev_for_each_resource_p' - 'pci_doe_for_each_off' - 'pcl_for_each_chunk' - 'pcl_for_each_segment' diff --git a/arch/alpha/kernel/pci.c b/arch/alpha/kernel/pci.c index 64fbfb0763b2..4458eb7f44f0 100644 --- a/arch/alpha/kernel/pci.c +++ b/arch/alpha/kernel/pci.c @@ -288,11 +288,10 @@ pcibios_claim_one_bus(struct pci_bus *b) struct pci_bus *child_bus; list_for_each_entry(dev, &b->devices, bus_list) { + struct resource *r; int i; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *r = &dev->resource[i]; - + pci_dev_for_each_resource(dev, r, i) { if (r->parent || !r->start || !r->flags) continue; if (pci_has_flag(PCI_PROBE_ONLY) || diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c index e7ef2b5bea9c..5254734b23e6 100644 --- a/arch/arm/kernel/bios32.c +++ b/arch/arm/kernel/bios32.c @@ -142,15 +142,15 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_WINBOND2, PCI_DEVICE_ID_WINBOND2_89C940F, */ static void pci_fixup_dec21285(struct pci_dev *dev) { - int i; - if (dev->devfn == 0) { + struct resource *r; + dev->class &= 0xff; dev->class |= PCI_CLASS_BRIDGE_HOST << 8; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - dev->resource[i].start = 0; - dev->resource[i].end = 0; - dev->resource[i].flags = 0; + pci_dev_for_each_resource_p(dev, r) { + r->start = 0; + r->end = 0; + r->flags = 0; } } } @@ -162,13 +162,11 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_DEC, PCI_DEVICE_ID_DEC_21285, pci_fixup_d static void pci_fixup_ide_bases(struct pci_dev *dev) { struct resource *r; - int i; if ((dev->class >> 8) != PCI_CLASS_STORAGE_IDE) return; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - r = dev->resource + i; + pci_dev_for_each_resource_p(dev, r) { if ((r->start & ~0x80) == 0x374) { r->start |= 2; r->end = r->start; diff --git a/arch/mips/pci/pci-legacy.c b/arch/mips/pci/pci-legacy.c index 468722c8a5c6..ec2567f8efd8 100644 --- a/arch/mips/pci/pci-legacy.c +++ b/arch/mips/pci/pci-legacy.c @@ -249,12 +249,11 @@ static int pcibios_enable_resources(struct pci_dev *dev, int mask) pci_read_config_word(dev, PCI_COMMAND, &cmd); old_cmd = cmd; - for (idx = 0; idx < PCI_NUM_RESOURCES; idx++) { + pci_dev_for_each_resource(dev, r, idx) { /* Only set up the requested stuff */ if (!(mask & (1<resource[idx]; if (!(r->flags & (IORESOURCE_IO | IORESOURCE_MEM))) continue; if ((idx == PCI_ROM_RESOURCE) && diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c index d67cf79bf5d0..8ddcfa6bcb50 100644 --- a/arch/powerpc/kernel/pci-common.c +++ b/arch/powerpc/kernel/pci-common.c @@ -1452,11 +1452,10 @@ void pcibios_claim_one_bus(struct pci_bus *bus) struct pci_bus *child_bus; list_for_each_entry(dev, &bus->devices, bus_list) { + struct resource *r; int i; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *r = &dev->resource[i]; - + pci_dev_for_each_resource(dev, r, i) { if (r->parent || !r->start || !r->flags) continue; diff --git a/arch/sparc/kernel/leon_pci.c b/arch/sparc/kernel/leon_pci.c index e5e5ff6b9a5c..b6663a3fbae9 100644 --- a/arch/sparc/kernel/leon_pci.c +++ b/arch/sparc/kernel/leon_pci.c @@ -62,15 +62,14 @@ void leon_pci_init(struct platform_device *ofdev, struct leon_pci_info *info) int pcibios_enable_device(struct pci_dev *dev, int mask) { + struct resource *res; u16 cmd, oldcmd; int i; pci_read_config_word(dev, PCI_COMMAND, &cmd); oldcmd = cmd; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *res = &dev->resource[i]; - + pci_dev_for_each_resource(dev, res, i) { /* Only set up the requested stuff */ if (!(mask & (1<devices, bus_list) { + struct resource *r; int i; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *r = &dev->resource[i]; - + pci_dev_for_each_resource(dev, r, i) { if (r->parent || !r->start || !r->flags) continue; @@ -724,15 +723,14 @@ struct pci_bus *pci_scan_one_pbm(struct pci_pbm_info *pbm, int pcibios_enable_device(struct pci_dev *dev, int mask) { + struct resource *res; u16 cmd, oldcmd; int i; pci_read_config_word(dev, PCI_COMMAND, &cmd); oldcmd = cmd; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *res = &dev->resource[i]; - + pci_dev_for_each_resource(dev, res, i) { /* Only set up the requested stuff */ if (!(mask & (1<resource[i]; - + pci_dev_for_each_resource(dev, res, i) { /* Only set up the requested stuff */ if (!(mask & (1<resource + i; + pci_dev_for_each_resource_p(dev, res) { if (res->parent) release_resource(res); } diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index e512f9ecb9d0..336d6e6ef76a 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -124,20 +124,17 @@ static resource_size_t get_res_add_align(struct list_head *head, return dev_res ? dev_res->min_align : 0; } - /* Sort resources by alignment */ static void pdev_sort_resources(struct pci_dev *dev, struct list_head *head) { + struct resource *r; int i; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *r; + pci_dev_for_each_resource(dev, r, i) { struct pci_dev_resource *dev_res, *tmp; resource_size_t r_align; struct list_head *n; - r = &dev->resource[i]; - if (r->flags & IORESOURCE_PCI_FIXED) continue; @@ -895,10 +892,9 @@ static void pbus_size_io(struct pci_bus *bus, resource_size_t min_size, min_align = window_alignment(bus, IORESOURCE_IO); list_for_each_entry(dev, &bus->devices, bus_list) { - int i; + struct resource *r; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *r = &dev->resource[i]; + pci_dev_for_each_resource_p(dev, r) { unsigned long r_size; if (r->parent || !(r->flags & IORESOURCE_IO)) @@ -1014,10 +1010,10 @@ static int pbus_size_mem(struct pci_bus *bus, unsigned long mask, size = 0; list_for_each_entry(dev, &bus->devices, bus_list) { + struct resource *r; int i; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *r = &dev->resource[i]; + pci_dev_for_each_resource(dev, r, i) { resource_size_t r_size; if (r->parent || (r->flags & IORESOURCE_PCI_FIXED) || @@ -1358,11 +1354,10 @@ static void assign_fixed_resource_on_bus(struct pci_bus *b, struct resource *r) */ static void pdev_assign_fixed_resources(struct pci_dev *dev) { - int i; + struct resource *r; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { + pci_dev_for_each_resource_p(dev, r) { struct pci_bus *b; - struct resource *r = &dev->resource[i]; if (r->parent || !(r->flags & IORESOURCE_PCI_FIXED) || !(r->flags & (IORESOURCE_IO | IORESOURCE_MEM))) @@ -1845,7 +1840,7 @@ static void pci_bus_distribute_available_resources(struct pci_bus *bus, * distributing the rest. */ list_for_each_entry(dev, &bus->devices, bus_list) { - int i; + struct resource *dev_res; if (dev == bridge) continue; @@ -1857,8 +1852,7 @@ static void pci_bus_distribute_available_resources(struct pci_bus *bus, if (!dev->multifunction) return; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - const struct resource *dev_res = &dev->resource[i]; + pci_dev_for_each_resource_p(dev, dev_res) { resource_size_t dev_sz; struct resource *b_res; diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c index b492e67c3d87..967f9a758923 100644 --- a/drivers/pci/setup-res.c +++ b/drivers/pci/setup-res.c @@ -484,12 +484,10 @@ int pci_enable_resources(struct pci_dev *dev, int mask) pci_read_config_word(dev, PCI_COMMAND, &cmd); old_cmd = cmd; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { + pci_dev_for_each_resource(dev, r, i) { if (!(mask & (1 << i))) continue; - r = &dev->resource[i]; - if (!(r->flags & (IORESOURCE_IO | IORESOURCE_MEM))) continue; if ((i == PCI_ROM_RESOURCE) && diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c index 7378e2f3e525..ce485ef59656 100644 --- a/drivers/pci/xen-pcifront.c +++ b/drivers/pci/xen-pcifront.c @@ -390,9 +390,7 @@ static int pcifront_claim_resource(struct pci_dev *dev, void *data) int i; struct resource *r; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - r = &dev->resource[i]; - + pci_dev_for_each_resource(dev, r, i) { if (!r->parent && r->start && r->flags) { dev_info(&pdev->xdev->dev, "claiming resource %s/%d\n", pci_name(dev), i); diff --git a/include/linux/pci.h b/include/linux/pci.h index 2bda4a4e47e8..3940435fa90a 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1407,6 +1407,17 @@ int pci_request_selected_regions(struct pci_dev *, int, const char *); int pci_request_selected_regions_exclusive(struct pci_dev *, int, const char *); void pci_release_selected_regions(struct pci_dev *, int); +#define __pci_dev_for_each_resource(dev, res, __i, vartype) \ + for (vartype __i = 0; \ + res = &(dev)->resource[__i], __i < PCI_NUM_RESOURCES; \ + __i++) + +#define pci_dev_for_each_resource(dev, res, i) \ + __pci_dev_for_each_resource(dev, res, i, ) + +#define pci_dev_for_each_resource_p(dev, res) \ + __pci_dev_for_each_resource(dev, res, i, unsigned int) + /* drivers/pci/bus.c */ void pci_add_resource(struct list_head *resources, struct resource *res); void pci_add_resource_offset(struct list_head *resources, struct resource *res, -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 16:47:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 16:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436903.691123 (Exim 4.92) (envelope-from ) id 1oqdN7-0003Ln-2r; Thu, 03 Nov 2022 16:47:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436903.691123; Thu, 03 Nov 2022 16:47:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdN6-0003Lg-V3; Thu, 03 Nov 2022 16:47:16 +0000 Received: by outflank-mailman (input) for mailman id 436903; Thu, 03 Nov 2022 16:47:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdN6-0002ih-1H for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 16:47:16 +0000 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 25b81a63-5b97-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 17:47:07 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2022 09:46:36 -0700 Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 03 Nov 2022 09:46:29 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id B75E129D; Thu, 3 Nov 2022 18:46:52 +0200 (EET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25b81a63-5b97-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667494033; x=1699030033; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EaNuN468AX7oVVNzygbZKjeVdiuKUVO8jdpIxMpvwBE=; b=Voi+kRr9Zp10H+K4cuAxV1LmnyNY6gKw/G0DgaycWnXEatL6nDgX2Wzh RW+uPVvrCWpkbKi8jCYl79gAnuQgATfINATvUFE3Fdir0x4Wkt9qjWcRk KxFtBXStZnga813ivkRQqyE/1wMQ8Ns3FTNPT5q+OeiECCEsipFOIm9TW E1W1WSCqf4ChYPKHf/VWH97ZUb96kdzQAyXp7n/XAajpeFvZCwclpR7pE UIUFCQYNtwXF7hlRhGB5vrV3taGM7vuOGJDZBGIHMWAEPu3uukwM7bKIw 9s7Rj1Ua/JZCQQbVXCJuHfO1SbSkbm1HxTlg/lk18RSCfFiJRV488uCjP w==; X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="293061340" X-IronPort-AV: E=Sophos;i="5.96,134,1665471600"; d="scan'208";a="293061340" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="809735378" X-IronPort-AV: E=Sophos;i="5.96,134,1665471600"; d="scan'208";a="809735378" From: Andy Shevchenko To: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Andy Shevchenko , Mika Westerberg , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH v2 3/4] EISA: Convert to use pci_bus_for_each_resource_p() Date: Thu, 3 Nov 2022 18:46:43 +0200 Message-Id: <20221103164644.70554-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> References: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The pci_bus_for_each_resource_p() hides the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Signed-off-by: Andy Shevchenko --- drivers/eisa/pci_eisa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/eisa/pci_eisa.c b/drivers/eisa/pci_eisa.c index 930c2332c3c4..907b86384396 100644 --- a/drivers/eisa/pci_eisa.c +++ b/drivers/eisa/pci_eisa.c @@ -20,8 +20,8 @@ static struct eisa_root_device pci_eisa_root; static int __init pci_eisa_init(struct pci_dev *pdev) { - int rc, i; struct resource *res, *bus_res = NULL; + int rc; if ((rc = pci_enable_device (pdev))) { dev_err(&pdev->dev, "Could not enable device\n"); @@ -38,7 +38,7 @@ static int __init pci_eisa_init(struct pci_dev *pdev) * eisa_root_register() can only deal with a single io port resource, * so we use the first valid io port resource. */ - pci_bus_for_each_resource(pdev->bus, res, i) + pci_bus_for_each_resource_p(pdev->bus, res) if (res && (res->flags & IORESOURCE_IO)) { bus_res = res; break; -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 16:47:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 16:47:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436904.691134 (Exim 4.92) (envelope-from ) id 1oqdN9-0003cc-9s; Thu, 03 Nov 2022 16:47:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436904.691134; Thu, 03 Nov 2022 16:47:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdN9-0003cV-6B; Thu, 03 Nov 2022 16:47:19 +0000 Received: by outflank-mailman (input) for mailman id 436904; Thu, 03 Nov 2022 16:47:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdN7-0002ih-Dd for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 16:47:17 +0000 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 28ec424c-5b97-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 17:47:10 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2022 09:46:36 -0700 Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 03 Nov 2022 09:46:29 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id C452A2B7; Thu, 3 Nov 2022 18:46:52 +0200 (EET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28ec424c-5b97-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667494036; x=1699030036; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NhBC+PjScBp2IdaVXcj0juh1+PhjepKM9lxMzcbPhAU=; b=f0MSA++lXlrN/79oRNIleUmCvbHBUEKrQrS2JFURHFSrBDfNdMjLYAjr WFWU+w4WlaSDu4GSo97C9YYL35hch5P0bEPhhbPYl2abUFdVyqqBy2yAU rjfoA2q2RHvQ9T/bvFaCC90rWLUD1zD2hBwPtZHuTtN0AaCqlr9+BX+pF DqczfQhPxBV9cDyBYclP3x+dkAhgseB4c3H/a96YXz4jVNIAWobzrBPBO HEvEDWGIZ3NSnFFYVrSDfqprcFOPi514pETkxkvNQI8E2lX6qHozSqHVu u2GWIUapww7zIKUdk0b7RV3wdYXUtxH/Ca/f7cOjiBCyr8YR2Atpsx2wa Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="293061345" X-IronPort-AV: E=Sophos;i="5.96,134,1665471600"; d="scan'208";a="293061345" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="809735385" X-IronPort-AV: E=Sophos;i="5.96,134,1665471600"; d="scan'208";a="809735385" From: Andy Shevchenko To: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Andy Shevchenko , Mika Westerberg , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH v2 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p() Date: Thu, 3 Nov 2022 18:46:44 +0200 Message-Id: <20221103164644.70554-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> References: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The pci_bus_for_each_resource_p() hides the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Signed-off-by: Andy Shevchenko --- drivers/pcmcia/rsrc_nonstatic.c | 9 +++------ drivers/pcmcia/yenta_socket.c | 3 +-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c index ad1141fddb4c..9d92d4bb6239 100644 --- a/drivers/pcmcia/rsrc_nonstatic.c +++ b/drivers/pcmcia/rsrc_nonstatic.c @@ -934,7 +934,7 @@ static int adjust_io(struct pcmcia_socket *s, unsigned int action, unsigned long static int nonstatic_autoadd_resources(struct pcmcia_socket *s) { struct resource *res; - int i, done = 0; + int done = 0; if (!s->cb_dev || !s->cb_dev->bus) return -ENODEV; @@ -960,12 +960,9 @@ static int nonstatic_autoadd_resources(struct pcmcia_socket *s) */ if (s->cb_dev->bus->number == 0) return -EINVAL; - - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) { - res = s->cb_dev->bus->resource[i]; -#else - pci_bus_for_each_resource(s->cb_dev->bus, res, i) { #endif + + pci_bus_for_each_resource_p(s->cb_dev->bus, res) { if (!res) continue; diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c index 3966a6ceb1ac..b200f2b99a7a 100644 --- a/drivers/pcmcia/yenta_socket.c +++ b/drivers/pcmcia/yenta_socket.c @@ -673,9 +673,8 @@ static int yenta_search_res(struct yenta_socket *socket, struct resource *res, u32 min) { struct resource *root; - int i; - pci_bus_for_each_resource(socket->dev->bus, root, i) { + pci_bus_for_each_resource_p(socket->dev->bus, root) { if (!root) continue; -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 16:50:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 16:50:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436909.691144 (Exim 4.92) (envelope-from ) id 1oqdQN-0005fq-PM; Thu, 03 Nov 2022 16:50:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436909.691144; Thu, 03 Nov 2022 16:50:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdQN-0005fj-MD; Thu, 03 Nov 2022 16:50:39 +0000 Received: by outflank-mailman (input) for mailman id 436909; Thu, 03 Nov 2022 16:50:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdQM-0005fd-DM for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 16:50:38 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60085.outbound.protection.outlook.com [40.107.6.85]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a041df93-5b97-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 17:50:30 +0100 (CET) Received: from DB8PR06CA0029.eurprd06.prod.outlook.com (2603:10a6:10:100::42) by DBBPR08MB6108.eurprd08.prod.outlook.com (2603:10a6:10:1f4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Thu, 3 Nov 2022 16:50:26 +0000 Received: from DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::f6) by DB8PR06CA0029.outlook.office365.com (2603:10a6:10:100::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Thu, 3 Nov 2022 16:50:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT030.mail.protection.outlook.com (100.127.142.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 16:50:26 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Thu, 03 Nov 2022 16:50:25 +0000 Received: from c7e8a47af215.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E6D80C10-A0BA-45DA-904F-18AD22829D40.1; Thu, 03 Nov 2022 16:50:19 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c7e8a47af215.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Nov 2022 16:50:19 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DBAPR08MB5765.eurprd08.prod.outlook.com (2603:10a6:10:1ac::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov 2022 16:50:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Thu, 3 Nov 2022 16:50:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a041df93-5b97-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BOhWv29djl2GBgLYIWiBcREszHUCEGInsOxcMWkOOOxBouWllYyr7foWZmaIaP3uyy3BO8yCDqs9Q1cdVIemFtWLKbR2+zSqoTHVQcho1k2LuE2wyFMSH2YeLY3OM94TgeTJJ1zdyC12RyIvZ8+C575Hkm0elAISsOhwrc2YMlqBnwZoLW2/Hh5MOtgsN3qJRpBbrgun5wTMYLh+aerF8GIbIPIG59dThfMS4NXVtRA/VFWmohIdczDlrq7RbEZz0JPYhLEhGgPHloljEQET7F0bsw/Oqr3OL8MJMcQSEjaZ05kUiWJ3Q1NpYUs4XyevVYgiV87an3qGyhEyFq9nTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vS9rGZjA096Wtu2NF9SeKTN/1BqZDtC152/38ubEOJQ=; b=hWb8AAsZnUiYRUpFvw36wj9lOZ+KzK1PAcEpN622rchKFyQ2KRcm2EZPBlDn5FMviGN1tkRRGe/EK+pav06dkqc5WEVR+QIGxjqCd+Lxe1w6OH7NksLV8KbNgrifNM3ZYqjpos3Z9KL2sh8FwGljqhbBsaEmc1nsdAiTwH2FF7b0JIytQCdi78UL74wTFg41FB7iY+EYoM2le7Q/MvUi0vJx7r+t5jHnEryU/0vCkJF12q6G30kFGlin0q1SqWG2kB4vs9bHVpO1QvQ/g4fIfiibZMmRnd5/p3uQVkRbIAdiKgb4rYJb18nF9XvhwP7c3GYIX3jt3xFkYf0HrHLduw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vS9rGZjA096Wtu2NF9SeKTN/1BqZDtC152/38ubEOJQ=; b=dKJ97EFlun7wfhMeDgfkzBhx2FncfXxrar35s7mQLnEhzvQFSQRuhpD+DgFXF2iSUad4vPziHnHDRYeQdNFJdQAN049QjwWEEg93Leh5QKuFV5WoV5taiwbz8vlPx6E1tRN5iN/9hIfy7JwSHUPrhttY/B4tWreJN4D3oJLCZPs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L2EXT93chYEM5IywsclRGTj7+SdptJVjRIO+GGkHpne08O9soQd0o20UEUo4bpFC4yZAe7lIPho+3NUvExQcqHCcDX7t5N6wNEGXWT7MoB7hi0nW2KSZAHOjgdaPclF2gQoJWo1Vi1Go37ZxrDkpi0ZzrOX3hcV6JqTcLUH/hUv4hheziKCPkLqV+tVI4jId+nAciYqk/jgC5vKJMayBVFNTgTzMcYngtlSJZlwqzRG7kUaMA0hzB6amaFdizN9DcRUza8bVkARBqr2I5DE1RKpWIwQLDojGMpV5A3o8UoiP1oGZwombzV2j2r8fAEdsJakX0dpmBRORB4Q0HTp3hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vS9rGZjA096Wtu2NF9SeKTN/1BqZDtC152/38ubEOJQ=; b=llCgle65p4XTwqOCSnINQ9CMDN/slFoQVI+nv3kO5IjuUI3TmJ169SbiFZRWwJZhH0ISHsA10jXC7Ht2L3R2WuHspzBY7HAqwS+LIkpSferwMb5P3hSkb2XiOAHV3D0ZeikV9bRO/EA4+LJeQOgZZuwFrjiH2m5nS5qthtboriZHW2LCl3EvpJ/c4gLMjhNCb7XFTBju177tOjJtH5/bnKHr6XM1gDb36szzjSmk5lTKEOlQfTgHadDmoJ3kcVKmPch61k9BYfBopAwJfOsiqVLV+P5U0/Xx0LMHGgqrxcxcX7C5tmwlx1+Pnv+CY8pvmXx5GOkQ6jk692okPL0DVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vS9rGZjA096Wtu2NF9SeKTN/1BqZDtC152/38ubEOJQ=; b=dKJ97EFlun7wfhMeDgfkzBhx2FncfXxrar35s7mQLnEhzvQFSQRuhpD+DgFXF2iSUad4vPziHnHDRYeQdNFJdQAN049QjwWEEg93Leh5QKuFV5WoV5taiwbz8vlPx6E1tRN5iN/9hIfy7JwSHUPrhttY/B4tWreJN4D3oJLCZPs= From: Henry Wang To: Jan Beulich , Juergen Gross CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers Thread-Topic: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers Thread-Index: AQHY76J0n3XAu9trAECn0VzPTwDhaq4taCGAgAAA7RA= Date: Thu, 3 Nov 2022 16:50:16 +0000 Message-ID: References: <20221103163631.13145-1-jgross@suse.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3D862D1BD47001478A7834DA3EEB2122.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DBAPR08MB5765:EE_|DBAEUR03FT030:EE_|DBBPR08MB6108:EE_ X-MS-Office365-Filtering-Correlation-Id: 0dd31ad2-7d5e-42d3-b905-08dabdbb81de x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QP46ZhqqBvxGj7Hf79s70RMKImgtknD3rUciRnlL9yNeg+k5WhWehIvxRkFZE9/FMBNdUyot8/sUv7JDpvN8fE5qDwxjQ/qfOwLM1SlgqJFrcoTBSwrJOVmVWlPOs9jXnCgF82W/4DWFAFupwpcev1th2KaYUqrlANa+s1M8rZM+B8hgNoqw984Fjb/dn0U5fitXXvV+LmMG44PXjeDlIe6JXQ+h4f5t4kGJawwAheQdbJlp03luA1HOE4/eIjV7h7JcQjWK470rfPm/pIT+cDg9MxbOYM4guB/4GJ2+JlJXCSmeRGQQKPkaryEodYOWk/n8JcQF4BFZOuPrQubWzQq3wEuh/BiK1ugi4nYW4S/+U+VWy3zkPMx2aUrKVoQ3I1UUNPh/Pa9J+m2ivhelH6yzgm7V33BNqa+rTEn/CuFaNyGk1FqAl9AxR3qldn56g73yxr2mXqAl/4T7eKW5ZRvISXEMGsuLDDekVF5nHJpZk9hDM6o8tuOI9dEKMfl78n9NNP6GUbMRdIJ1SO8RB4HRxoKVxrbY3P6NsmJGMSSRRCQh493vhJRvkY1mfDuLOGj5/0gRlBbjUUvCWAwzzqHqOQQOxbr6dTX7D7/EWoO0kZB14X8Z/Yz6gbbZRl6Xyi0fYzorgwYnkb8tjXKGLe4oAu25h4f9ta/Tem6T3p3gO9ZGeBkJCLvoFzj72VYkZKworulhiMY/LrU6BUFER0SkbYFypnDxYoBGte60NxltfTpR9wZSikj/dsgfbknOQ00QThXynoPwHVoPhxBj/w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(396003)(376002)(366004)(136003)(451199015)(83380400001)(33656002)(38070700005)(8676002)(122000001)(38100700002)(5660300002)(86362001)(41300700001)(66556008)(66446008)(7696005)(52536014)(8936002)(2906002)(55016003)(6506007)(64756008)(9686003)(76116006)(316002)(71200400001)(186003)(26005)(66946007)(54906003)(4326008)(110136005)(478600001)(53546011)(66476007);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5765 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 151bdbc2-16a3-4d7f-a0c6-08dabdbb7c21 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A5tvaVsj+B/T66usAAmjqkRnK1HCctJ0Zr9OOtUqqxtyqosY9b+jgxlzFTyjPwzbAJcBsTWsmVCPvycrcZ28KOWHzVZOboYet/KujmjiSLOTzLvcrNxXvK/+gcB9DHPAUAzJaZuxQNejoNx9fx9VSzArj8LnboiNQDfdlatPl20gl0Se2WXk6Ff4ahVlBKbPdQXr2i2ywOjLMg+KAg1Vsg37Ile4j0YUCB6BlJ5aorw01dDlSC81p2BQNWFO+2YyjcGmypJmXE2MGt1CVyYGLtj5D5gY8qXo4mV5VrjAbDPfbUVhnQRggivzvxlO3NqwsS0nK/IqekfVUrsVfk9cLEOaTYGGeXWs0v/BHGUlwT1WasV1VcB3D73hHNZecNeZNBpqbFtBYtWlkOepYl7Qjg2UKFO3CI2BmCz2bgfCieT+nLvCEWr2WJ7TB/tT3s9nH2vW66PSaPRJsTTkafaZiFjscRchL3Kxmv7WGgPqDzWIbXYaP0/ceco1tIt/12Dqeky5bPUqcaa9G30ktCEppjz0M0g6gDJfQiQ0OkABvgUi4sSg+R4IatP0//za2/1aElGZebZV769xD2v/HAhvIzVRxhFBMFc3wPPPEG206QyBTnkV/+etHHNS/cKLcqxc/wbY5+gvf4ecIsTsp8T03O1VSB+0AfH73P1xMj1CVtwhQdiCnLsymK4x9T+/XLS6Co/N+xj2KSKiq7AskYGk4lYEOzGAak97zRfJigyn7fNQc/Ayml4cWNmf4IadCEyloJc7PecOuIbIuXQStk0ELg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(136003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(6506007)(186003)(2906002)(336012)(83380400001)(110136005)(40460700003)(53546011)(70586007)(7696005)(82740400003)(70206006)(55016003)(4326008)(52536014)(41300700001)(40480700001)(8676002)(33656002)(82310400005)(47076005)(8936002)(54906003)(478600001)(316002)(5660300002)(26005)(9686003)(86362001)(356005)(81166007)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 16:50:26.1737 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0dd31ad2-7d5e-42d3-b905-08dabdbb81de X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6108 SGkgSnVlcmdlbiBhbmQgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZy b206IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRD SC1mb3ItNC4xN10geGVuOiBmaXggZ2VuZXJhdGVkIGNvZGUgZm9yIGNhbGxpbmcgaHlwZXJjYWxs DQo+IGhhbmRsZXJzDQo+IA0KPiBPbiAwMy4xMS4yMDIyIDE3OjM2LCBKdWVyZ2VuIEdyb3NzIHdy b3RlOg0KPiA+IFRoZSBjb2RlIGdlbmVyYXRlZCBmb3IgdGhlIGNhbGxfaGFuZGxlcnNfKigpIG1h Y3JvcyBuZWVkcyB0byBhdm9pZA0KPiA+IHVuZGVmaW5lZCBiZWhhdmlvciB3aGVuIG11bHRpcGxl IGhhbmRsZXJzIHNoYXJlIHRoZSBzYW1lIHByaW9yaXR5Lg0KPiA+IFRoZSBpc3N1ZSBpcyB0aGUg aHlwZXJjYWxsIG51bWJlciBiZWluZyB1bnZlcmlmaWVkIGZlZCBpbnRvIHRoZSBtYWNyb3MNCj4g PiBhbmQgdGhlbiB1c2VkIHRvIHNldCBhIG1hc2sgdmlhICJtYXNrID0gMVVMTCA8PCA8aHlwZXJj YWxsLW51bWJlcj4iLg0KPiA+DQo+ID4gQXZvaWQgYSBzaGlmdCBhbW91bnQgb2YgbW9yZSB0aGFu IDYzIGJ5IHNldHRpbmcgbWFzayB0byB6ZXJvIGluIGNhc2UNCj4gPiB0aGUgaHlwZXJjYWxsIG51 bWJlciBpcyB0b28gbGFyZ2UuDQo+ID4NCj4gPiBGaXhlczogZWNhMWYwMGQwMjI3ICgieGVuOiBn ZW5lcmF0ZSBoeXBlcmNhbGwgaW50ZXJmYWNlIHJlbGF0ZWQgY29kZSIpDQo+ID4gU2lnbmVkLW9m Zi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiANCj4gUmV2aWV3ZWQtYnk6 IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KUmVsZWFzZS1hY2tlZC1ieTogSGVu cnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KDQpXaXRoLi4uDQoNCj4gYWxiZWl0IHByZWZl cmFibHkgd2l0aCAuLi4NCj4gDQo+ID4gLS0tIGEveGVuL3NjcmlwdHMvZ2VuX2h5cGVyY2FsbC5h d2sNCj4gPiArKysgYi94ZW4vc2NyaXB0cy9nZW5faHlwZXJjYWxsLmF3aw0KPiA+IEBAIC0yNjMs NyArMjYzLDcgQEAgRU5EIHsNCj4gPiAgICAgICAgICBwcmludGYoIiNkZWZpbmUgY2FsbF9oYW5k bGVyc18lcyhudW0sIHJldCwgYTEsIGEyLCBhMywgYTQsIGE1KSBcXFxuIiwNCj4gY2EpOw0KPiA+ ICAgICAgICAgIHByaW50ZigiKHsgXFxcbiIpOw0KPiA+ICAgICAgICAgIGlmIChuZWVkX21hc2sp DQo+ID4gLSAgICAgICAgICAgIHByaW50ZigiICAgIHVpbnQ2NF90IG1hc2sgPSAxVUxMIDw8IG51 bTsgXFxcbiIpOw0KPiA+ICsgICAgICAgICAgICBwcmludGYoIiAgICB1aW50NjRfdCBtYXNrID0g KG51bSA+IDYzKSA/IDAgOiAxVUxMIDw8IG51bTsgXFxcbiIpOw0KPiANCj4gLi4uICJudW0iIGFs c28gcHJvcGVybHkgcGFyZW50aGVzaXplZCAodGhpcyBpcyBwYXJ0IG9mIGEgbWFjcm8gZGVmaW5p dGlvbg0KPiBpbiB0aGUgb3V0cHV0IGFmdGVyIGFsbCkuIEVhc3kgZW5vdWdoIHRvIHRha2UgY2Fy ZSBvZiB3aGlsZSBjb21taXR0aW5nLg0KDQouLi5KYW4ncyBjb21tZW50IGZpeGVkIChvciBhZ3Jl ZW1lbnQgdG8gbGV0IHRoZSBjb21taXR0ZXIgZml4IG9uIGNvbW1pdCkuDQoNCktpbmQgcmVnYXJk cywNCkhlbnJ5DQoNCj4gDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Thu Nov 03 16:57:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 16:57:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436926.691156 (Exim 4.92) (envelope-from ) id 1oqdWn-0006vX-FE; Thu, 03 Nov 2022 16:57:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436926.691156; Thu, 03 Nov 2022 16:57:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdWn-0006vQ-CH; Thu, 03 Nov 2022 16:57:17 +0000 Received: by outflank-mailman (input) for mailman id 436926; Thu, 03 Nov 2022 16:57:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdWl-0006vJ-PQ for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 16:57:16 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8ce35981-5b98-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 17:57:07 +0100 (CET) Received: by mail-ej1-x635.google.com with SMTP id q9so7096212ejd.0 for ; Thu, 03 Nov 2022 09:57:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ce35981-5b98-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GNSNEqIxz8zzf8tSbsp0rWUlVEEaNFYWZk5Z8L0QJ08=; b=RayusriEt0H7qtXu9wH/lDnNKQ2gO+Nxp6CU5+VKy6ihekgx2frUFV059UQD+zMXy8 LrfWyM4hfSu+LAkMKd7wmYX5Psy+AmiZWC1esFDZilvo25HX3KoZb1Ml6SFG6+IoVi6V LagMUw3KsChko/MwkYGSYozyIh5EQ9R51gpD8pVE0lmMM3ukbvvf4AqGxm4QW4vgKAya 2iXdH1FfmMdVjRCP4N9F4U7W/rCzBGGvI7dM3huSzTcaunmEpUFD67oiH510BLS+Z1+S A4vTy8sllZYPUU+jHbvZoDAfWTp7eitF2LxViPLB6p8K5n5P0AGZXLIN8E27DlTxBwGw x2yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GNSNEqIxz8zzf8tSbsp0rWUlVEEaNFYWZk5Z8L0QJ08=; b=dTEAHRAXW/Pvqz71hp8aBxXTb5bPZ9FuZqa6IgIPjqHuDhDpMVo/kyy9F/3e3I46qJ eFC7ACfs/VKh7tTgasDakBRAc7Qv0Bui26DqVb2k1alOIFSJek1UAk8Y4NLfLRBogRkB bQxGPFbXf9JVVOyhstYGxiNyYoEciQqFTtGt5d9T7laxtWB625dzbsG9BriiXDLk/6Sa CKSVCZ53j9LfpDvnTiXz0iehrBe0pdgOOCZ8YENWU4zqSBkAq06lyQ5F0dxcvCOnuMp2 WgCw8GIHQO75bNFcHBSul12ciNsDYo+uRwbHG+vkwzvT/kGFEr81M65VdK+ai48cMyKr DADQ== X-Gm-Message-State: ACrzQf0Km1O7Wahqu9xxH378kr1bE9lKmj7rc+6m5JTAUlM4Lp8fnb7u 24pZWlXwRLvMwH3HGsc5W6/wdJMwy5qQ86Bp0WT9bFXzIkc= X-Google-Smtp-Source: AMsMyM69DiUkMpphTMvRhzKRZQBBpYN9YDp7lBHJipxDo35o6zs1j4XMMISq9K11pQxA+cqkwf3HON4tFAVfY+DM+wA= X-Received: by 2002:a17:907:72cf:b0:7ad:7e95:69d7 with SMTP id du15-20020a17090772cf00b007ad7e9569d7mr28528953ejc.97.1667494632707; Thu, 03 Nov 2022 09:57:12 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Vipul Suneja Date: Thu, 3 Nov 2022 22:27:00 +0530 Message-ID: Subject: Re: Porting Xen in raspberry pi4B To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, oleksandr_andrushchenko@epam.com, oleksandr_tyshchenko@epam.com, jgross@suse.com, boris.ostrovsky@oracle.com, Bertrand.Marquis@arm.com Content-Type: multipart/alternative; boundary="0000000000003f5b9605ec93d92d" --0000000000003f5b9605ec93d92d Content-Type: text/plain; charset="UTF-8" Hi Stefano, Thanks! I used xen-guest-image-minimal(simple console based image) as a guest with fbcon & fbdev enabled in kernel configurations but still the same error can't open the display. below are the outcome of "xenstore-ls": *root@raspberrypi4-64:~/guest1# xenstore-lstool = "" xenstored = ""local = "" domain = "" 0 = "" control = "" feature-poweroff = "1" feature-reboot = "1" domid = "0" name = "Domain-0" device-model = "" 0 = "" backends = "" console = "" vkbd = "" vfb = "" qnic = "" state = "running" 1 = "" backends = "" console = "" vkbd = "" vfb = "" qnic = "" state = "running" backend = "" vbd = "" 1 = "" 51712 = "" frontend = "/local/domain/1/device/vbd/51712" params = "/home/root/guest2/xen-guest-image-minimal-raspberrypi4-64.ext3" script = "/etc/xen/scripts/block" frontend-id = "1" online = "1" removable = "0" bootable = "1" state = "4" dev = "xvda" type = "phy" mode = "w" device-type = "disk" discard-enable = "1" feature-max-indirect-segments = "256" multi-queue-max-queues = "4" max-ring-page-order = "4" node = "/dev/loop0" physical-device = "7:0" physical-device-path = "/dev/loop0" hotplug-status = "connected" feature-flush-cache = "1" discard-granularity = "4096" discard-alignment = "0" discard-secure = "0" feature-discard = "1" feature-barrier = "1" feature-persistent = "1" sectors = "1794048" info = "0" sector-size = "512" physical-sector-size = "512" vfb = "" 1 = "" 0 = "" frontend = "/local/domain/1/device/vfb/0" frontend-id = "1" online = "1" state = "4" vnc = "1" vnclisten = "127.0.0.1" vncdisplay = "0" vncunused = "1" sdl = "0" opengl = "0" feature-resize = "1" hotplug-status = "connected" request-update = "1" vkbd = "" 1 = "" 0 = "" frontend = "/local/domain/1/device/vkbd/0" frontend-id = "1" online = "1" state = "4" feature-abs-pointer = "1" feature-raw-pointer = "1" hotplug-status = "connected" console = "" 1 = "" 0 = "" frontend = "/local/domain/1/console" frontend-id = "1" online = "1" state = "1" protocol = "vt100" vif = "" 1 = "" 0 = "" frontend = "/local/domain/1/device/vif/0" frontend-id = "1" online = "1" state = "4" script = "/etc/xen/scripts/vif-bridge" mac = "e4:5f:01:cd:7b:dd" bridge = "xenbr0" handle = "0" type = "vif" hotplug-status = "connected" feature-sg = "1" feature-gso-tcpv4 = "1" feature-gso-tcpv6 = "1" feature-ipv6-csum-offload = "1" feature-rx-copy = "1" feature-xdp-headroom = "1" feature-rx-flip = "0" feature-multicast-control = "1" feature-dynamic-multicast-control = "1" feature-split-event-channels = "1" multi-queue-max-queues = "4" feature-ctrl-ring = "1" 1 = "" vm = "/vm/d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f" name = "guest2" cpu = "" 0 = "" availability = "online" 1 = "" availability = "online" memory = "" static-max = "2097152" target = "2097152" videoram = "0" device = "" suspend = "" event-channel = "" vbd = "" 51712 = "" backend = "/local/domain/0/backend/vbd/1/51712" backend-id = "0" state = "4" virtual-device = "51712" device-type = "disk" multi-queue-num-queues = "2" queue-0 = "" ring-ref = "8" event-channel = "4" queue-1 = "" ring-ref = "9" event-channel = "5" protocol = "arm-abi" feature-persistent = "1" vfb = "" 0 = "" backend = "/local/domain/0/backend/vfb/1/0" backend-id = "0" state = "4" page-ref = "275022" event-channel = "3" protocol = "arm-abi" feature-update = "1" vkbd = "" 0 = "" backend = "/local/domain/0/backend/vkbd/1/0" backend-id = "0" state = "4" request-abs-pointer = "1" page-ref = "275322" page-gref = "1284" event-channel = "10" vif = "" 0 = "" backend = "/local/domain/0/backend/vif/1/0" backend-id = "0" state = "4" handle = "0" mac = "e4:5f:01:cd:7b:dd" mtu = "1500" xdp-headroom = "0" multi-queue-num-queues = "2" queue-0 = "" tx-ring-ref = "1280" rx-ring-ref = "1281" event-channel-tx = "6" event-channel-rx = "7" queue-1 = "" tx-ring-ref = "1282" rx-ring-ref = "1283" event-channel-tx = "8" event-channel-rx = "9" request-rx-copy = "1" feature-rx-notify = "1" feature-sg = "1" feature-gso-tcpv4 = "1" feature-gso-tcpv6 = "1" feature-ipv6-csum-offload = "1" control = "" shutdown = "" feature-poweroff = "1" feature-reboot = "1" feature-suspend = "" sysrq = "" platform-feature-multiprocessor-suspend = "1" platform-feature-xs_reset_watches = "1" data = "" drivers = "" feature = "" attr = "" error = "" domid = "1" store = "" port = "1" ring-ref = "233473" console = "" backend = "/local/domain/0/backend/console/1/0" backend-id = "0" limit = "1048576" type = "xenconsoled" output = "pty" tty = "/dev/pts/1" port = "2" ring-ref = "233472" vnc-listen = "127.0.0.1" vnc-port = "5900" image = "" device-model-pid = "788"vm = "" d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f = "" name = "guest2" uuid = "d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f" start_time = "1520600274.27"libxl = "" 1 = "" device = "" vbd = "" 51712 = "" frontend = "/local/domain/1/device/vbd/51712" backend = "/local/domain/0/backend/vbd/1/51712" params = "/home/root/guest2/xen-guest-image-minimal-raspberrypi4-64.ext3" script = "/etc/xen/scripts/block" frontend-id = "1" online = "1" removable = "0" bootable = "1" state = "1" dev = "xvda" type = "phy" mode = "w" device-type = "disk" discard-enable = "1" vfb = "" 0 = "" frontend = "/local/domain/1/device/vfb/0" backend = "/local/domain/0/backend/vfb/1/0" frontend-id = "1" online = "1" state = "1" vnc = "1" vnclisten = "127.0.0.1" vncdisplay = "0" vncunused = "1" sdl = "0" opengl = "0" vkbd = "" 0 = "" frontend = "/local/domain/1/device/vkbd/0" backend = "/local/domain/0/backend/vkbd/1/0" frontend-id = "1" online = "1" state = "1" console = "" 0 = "" frontend = "/local/domain/1/console" backend = "/local/domain/0/backend/console/1/0" frontend-id = "1" online = "1" state = "1" protocol = "vt100" vif = "" 0 = "" frontend = "/local/domain/1/device/vif/0" backend = "/local/domain/0/backend/vif/1/0" frontend-id = "1" online = "1" state = "1" script = "/etc/xen/scripts/vif-bridge" mac = "e4:5f:01:cd:7b:dd" bridge = "xenbr0" handle = "0" type = "vif" hotplug-status = "" type = "pvh" dm-version = "qemu_xen"root@raspberrypi4-64:~/guest1#* Any input as per above? Looking forward to hearing from you. Regards, Vipul Kumar On Wed, Oct 26, 2022 at 5:21 AM Stefano Stabellini wrote: > Hi Vipul, > > If you look at the QEMU logs, it says: > > VNC server running on 127.0.0.1:5900 > > That is the VNC server you need to connect to. So in theory: > > vncviewer 127.0.0.1:5900 > > should work correctly. > > > If you have: > > vfb = ["type=vnc"] > > in your xl config file and you have "fbdev" in your Linux guest, it > should work. > > If you connect to the VNC server but you get a black screen, it might be > a guest configuration issue. I would try with a simpler guest, text only > (no X11, no Wayland) and enable the fbdev console (fbcon). See > Documentation/fb/fbcon.rst in Linux. You should be able to see a > graphical console over VNC. > > If that works, then you know that the fbdev kernel driver (xen-fbfront) > works correctly. > > If it doesn't work, the output of "xenstore-ls" would be interesting. > > Cheers, > > Stefano > > > On Wed, 19 Oct 2022, Vipul Suneja wrote: > > Hi Stefano, > > > > Thanks for the response! > > > > I am following the same link you shared from the beginning. Tried the > command "vncviewer localhost:0" in DOM0 but same issue "Can't open > > display", below are the logs: > > > > root@raspberrypi4-64:~# vncviewer localhost:0 > > > > TigerVNC Viewer 64-bit v1.11.0 > > Built on: 2020-09-08 12:16 > > Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst) > > See https://www.tigervnc.org for information on TigerVNC. > > Can't open display: > > > > Below are the netstat logs, i couldn't see anything running at port 5900 > or 5901: > > > > root@raspberrypi4-64:~# netstat -tuwx > > Active Internet connections (w/o servers) > > Proto Recv-Q Send-Q Local Address Foreign Address > State > > tcp 0 164 192.168.1.39:ssh 192.168.1.38:37472 > ESTABLISHED > > Active UNIX domain sockets (w/o servers) > > Proto RefCnt Flags Type State I-Node Path > > unix 8 [ ] DGRAM CONNECTED 10565 /dev/log > > unix 3 [ ] STREAM CONNECTED 10891 > /var/run/xenstored/socket > > unix 3 [ ] STREAM CONNECTED 13791 > > unix 3 [ ] STREAM CONNECTED 10843 > /var/run/xenstored/socket > > unix 3 [ ] STREAM CONNECTED 10573 > /var/run/xenstored/socket > > unix 2 [ ] DGRAM CONNECTED 14510 > > unix 3 [ ] STREAM CONNECTED 13249 > > unix 2 [ ] DGRAM CONNECTED 13887 > > unix 2 [ ] DGRAM CONNECTED 10599 > > unix 3 [ ] STREAM CONNECTED 14005 > > unix 3 [ ] STREAM CONNECTED 13258 > > unix 3 [ ] STREAM CONNECTED 13248 > > unix 3 [ ] STREAM CONNECTED 14003 > > unix 3 [ ] STREAM CONNECTED 10572 > /var/run/xenstored/socket > > unix 3 [ ] STREAM CONNECTED 10786 > /var/run/xenstored/socket > > unix 3 [ ] DGRAM CONNECTED 13186 > > unix 3 [ ] STREAM CONNECTED 10864 > /var/run/xenstored/socket > > unix 3 [ ] STREAM CONNECTED 10812 > /var/run/xenstored/socket > > unix 2 [ ] DGRAM CONNECTED 14083 > > unix 3 [ ] STREAM CONNECTED 10813 > /var/run/xenstored/socket > > unix 3 [ ] STREAM CONNECTED 14068 > > unix 3 [ ] STREAM CONNECTED 13256 > > unix 3 [ ] STREAM CONNECTED 10571 > /var/run/xenstored/socket > > unix 3 [ ] STREAM CONNECTED 10842 > > unix 3 [ ] STREAM CONNECTED 13985 > > unix 3 [ ] DGRAM CONNECTED 13185 > > unix 2 [ ] STREAM CONNECTED 13884 > > unix 2 [ ] DGRAM CONNECTED 14528 > > unix 2 [ ] DGRAM CONNECTED 13785 > > unix 3 [ ] STREAM CONNECTED 14034 > > > > Attaching xen log files of /var/log/xen. > > I didn't get the role of QEMU here because as mentioned earlier, I am > porting in raspberrypi 4B. > > > > Regards, > > Vipul Kumar > > > > On Wed, Oct 19, 2022 at 12:43 AM Stefano Stabellini < > sstabellini@kernel.org> wrote: > > It usually works the way it is described in the guide: > > > > > https://www.virtuatopia.com/index.php?title=Configuring_a_VNC_based_Graphical_Console_for_a_Xen_Paravirtualized_domainU_Guest > > > > You don't need to install any VNC-related server software because > it is > > already provided by Xen (to be precise it is provided by QEMU > working > > together with Xen.) > > > > You only need the vnc client in dom0 so that you can connect, but > you > > could also run the vnc client outside from another host. So > basically > > the following should work when executed in Dom0 after creating > DomU: > > > > vncviewer localhost:0 > > > > Can you attach the Xen and QEMU logs (/var/log/xen/*)? And also use > > netstat -taunp to check if there is anything running at port 5900 > or > > 5901? > > > > Cheers, > > > > Stefano > > > > > > On Tue, 18 Oct 2022, Vipul Suneja wrote: > > > Hi Stefano, > > > > > > Thanks for the response! > > > > > > I could install tigerVNC, x11vnc & libvncserver in Dom0 > xen-image-minimal but only manage to install libvncserver(couldn't > > install tigervnc > > > & x11vnc because of x11 > > > support missing, it's wayland) in DOMU custom graphical image. I > tried running vncviewer with IP address & port in dom0 to > > access the domu > > > graphical image display as per below commands. > > > > > > vncviewer 192.168.1.42:5901 > > > > > > But it showing can't open display, below are the logs: > > > > > > root@raspberrypi4-64:~/guest1# vncviewer 192.168.1.42:5901 > > > > > > TigerVNC Viewer 64-bit v1.11.0 > > > Built on: 2020-09-08 12:16 > > > Copyright (C) 1999-2020 TigerVNC Team and many others (see > README.rst) > > > See https://www.tigervnc.org for information on TigerVNC. > > > Can't open display: > > > root@raspberrypi4-64:~/guest1# > > > > > > I am not exactly sure what the issue is but I thought only > libvncserver in DOMU could work to get access but it did not > > work. > > > If TigerVNC is the issue here then is there any other VNC source > which could be installed for both x11 & wayland supported > > images? > > > > > > Regards, > > > Vipul Kumar > > > > > > On Tue, Oct 18, 2022 at 2:40 AM Stefano Stabellini < > sstabellini@kernel.org> wrote: > > > VNC is typically easier to setup, because SDL needs extra > libraries at > > > build time and runtime. If QEMU is built without SDL > support it won't > > > start when you ask for SDL. > > > > > > VNC should work with both x11 and wayland in your domU. It > doesn't work > > > at the x11 level, it exposes a special fbdev device in > your domU that > > > should work with: > > > - a graphical console in Linux domU > > > - x11 > > > - wayland (but I haven't tested this so I am not 100% sure > about it) > > > > > > When you say "it doesn't work", what do you mean? Do you > get a black > > > window? > > > > > > You need CONFIG_XEN_FBDEV_FRONTEND in Linux domU > > > (drivers/video/fbdev/xen-fbfront.c). I would try to get a > graphical text > > > console up and running in your domU before attempting > x11/wayland. > > > > > > Cheers, > > > > > > Stefano > > > > > > On Mon, 17 Oct 2022, Vipul Suneja wrote: > > > > Hi, > > > > Thanks! > > > > > > > > I have ported xen minimal image as DOM0 & custom wayland > GUI based image as DOMU in raspberry pi4B. I am trying to > > make GUI > > > display up > > > > for guest machine. I tried using sdl, included below > line in guest.conf file > > > > vfb= [ 'sdl=1' ] > > > > > > > > But it is throwing below error: > > > > > > > > root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg > > > > Parsing config from guest1.cfg > > > > libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: > Domain 3:error on QMP socket: Connection reset by peer > > > > libxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback: > Domain 3:Error happened with the QMP connection to QEMU > > > > libxl: error: > libxl_dm.c:3351:device_model_postconfig_done: Domain 3:Post DM startup > configs failed, rc=-26 > > > > libxl: error: > libxl_create.c:1867:domcreate_devmodel_started: Domain 3:device model did > not start: -26 > > > > libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: > Device Model already exited > > > > libxl: error: libxl_domain.c:1183:libxl__destroy_domid: > Domain 3:Non-existant domain > > > > libxl: error: > libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to destroy > guest > > > > libxl: error: libxl_domain.c:1064:domain_destroy_cb: > Domain 3:Destruction of domain failed > > > > > > > > Another way is VNC, i could install tigervnc in DOM0 but > same i couldn't in guest machine because it doesn't support > > > x11(supports wayland > > > > only). I am completely blocked here, Need your support > to enable the display up. > > > > Any alternative of VNC which could work in both x11 & > wayland supported images? > > > > > > > > Any input on VNC, SDL or any other way to proceed on > this? Looking forward to hearing from you. > > > > > > > > Regards, > > > > Vipul Kumar > > > > > > > > > > > > > > > --0000000000003f5b9605ec93d92d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Stefano,

Thanks!

I used xen-guest-image-minimal(simple console based image) as a guest= with fbcon & fbdev enabled in kernel configurations but still the same= error can't open the display.
below are the outcome of "= ;xenstore-ls":

root@raspberrypi4-64:~/gues= t1# xenstore-ls
tool =3D ""
=C2=A0xenstored =3D ""= ;
local =3D ""
=C2=A0domain =3D ""
=C2=A0 0 = =3D ""
=C2=A0 =C2=A0control =3D ""
=C2=A0 =C2=A0 = feature-poweroff =3D "1"
=C2=A0 =C2=A0 feature-reboot =3D &quo= t;1"
=C2=A0 =C2=A0domid =3D "0"
=C2=A0 =C2=A0name =3D = "Domain-0"
=C2=A0 =C2=A0device-model =3D ""
=C2= =A0 =C2=A0 0 =3D ""
=C2=A0 =C2=A0 =C2=A0backends =3D "&qu= ot;
=C2=A0 =C2=A0 =C2=A0 console =3D ""
=C2=A0 =C2=A0 =C2= =A0 vkbd =3D ""
=C2=A0 =C2=A0 =C2=A0 vfb =3D ""
= =C2=A0 =C2=A0 =C2=A0 qnic =3D ""
=C2=A0 =C2=A0 =C2=A0state =3D= "running"
=C2=A0 =C2=A0 1 =3D ""
=C2=A0 =C2=A0 = =C2=A0backends =3D ""
=C2=A0 =C2=A0 =C2=A0 console =3D "&= quot;
=C2=A0 =C2=A0 =C2=A0 vkbd =3D ""
=C2=A0 =C2=A0 =C2=A0= vfb =3D ""
=C2=A0 =C2=A0 =C2=A0 qnic =3D ""
=C2= =A0 =C2=A0 =C2=A0state =3D "running"
=C2=A0 =C2=A0backend =3D = ""
=C2=A0 =C2=A0 vbd =3D ""
=C2=A0 =C2=A0 =C2=A01= =3D ""
=C2=A0 =C2=A0 =C2=A0 51712 =3D ""
=C2=A0 = =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/vbd/51712&quo= t;
=C2=A0 =C2=A0 =C2=A0 =C2=A0params =3D "/home/root/guest2/xen-gue= st-image-minimal-raspberrypi4-64.ext3"
=C2=A0 =C2=A0 =C2=A0 =C2=A0s= cript =3D "/etc/xen/scripts/block"
=C2=A0 =C2=A0 =C2=A0 =C2=A0= frontend-id =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0online =3D &quo= t;1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0removable =3D "0"
=C2= =A0 =C2=A0 =C2=A0 =C2=A0bootable =3D "1"
=C2=A0 =C2=A0 =C2=A0 = =C2=A0state =3D "4"
=C2=A0 =C2=A0 =C2=A0 =C2=A0dev =3D "x= vda"
=C2=A0 =C2=A0 =C2=A0 =C2=A0type =3D "phy"
=C2=A0 = =C2=A0 =C2=A0 =C2=A0mode =3D "w"
=C2=A0 =C2=A0 =C2=A0 =C2=A0de= vice-type =3D "disk"
=C2=A0 =C2=A0 =C2=A0 =C2=A0discard-enable= =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-max-indirect-segme= nts =3D "256"
=C2=A0 =C2=A0 =C2=A0 =C2=A0multi-queue-max-queue= s =3D "4"
=C2=A0 =C2=A0 =C2=A0 =C2=A0max-ring-page-order =3D &= quot;4"
=C2=A0 =C2=A0 =C2=A0 =C2=A0node =3D "/dev/loop0"<= br>=C2=A0 =C2=A0 =C2=A0 =C2=A0physical-device =3D "7:0"
=C2=A0= =C2=A0 =C2=A0 =C2=A0physical-device-path =3D "/dev/loop0"
=C2= =A0 =C2=A0 =C2=A0 =C2=A0hotplug-status =3D "connected"
=C2=A0 = =C2=A0 =C2=A0 =C2=A0feature-flush-cache =3D "1"
=C2=A0 =C2=A0 = =C2=A0 =C2=A0discard-granularity =3D "4096"
=C2=A0 =C2=A0 =C2= =A0 =C2=A0discard-alignment =3D "0"
=C2=A0 =C2=A0 =C2=A0 =C2= =A0discard-secure =3D "0"
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-d= iscard =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-barrier =3D = "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-persistent =3D "1&= quot;
=C2=A0 =C2=A0 =C2=A0 =C2=A0sectors =3D "1794048"
=C2= =A0 =C2=A0 =C2=A0 =C2=A0info =3D "0"
=C2=A0 =C2=A0 =C2=A0 =C2= =A0sector-size =3D "512"
=C2=A0 =C2=A0 =C2=A0 =C2=A0physical-s= ector-size =3D "512"
=C2=A0 =C2=A0 vfb =3D ""
=C2= =A0 =C2=A0 =C2=A01 =3D ""
=C2=A0 =C2=A0 =C2=A0 0 =3D "&qu= ot;
=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device= /vfb/0"
=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"=C2=A0 =C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0 =C2=A0 =C2= =A0 =C2=A0state =3D "4"
=C2=A0 =C2=A0 =C2=A0 =C2=A0vnc =3D &qu= ot;1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0vnclisten =3D "127.0.0.1"= ;
=C2=A0 =C2=A0 =C2=A0 =C2=A0vncdisplay =3D "0"
=C2=A0 =C2= =A0 =C2=A0 =C2=A0vncunused =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0= sdl =3D "0"
=C2=A0 =C2=A0 =C2=A0 =C2=A0opengl =3D "0"= ;
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-resize =3D "1"
=C2=A0 = =C2=A0 =C2=A0 =C2=A0hotplug-status =3D "connected"
=C2=A0 =C2= =A0 =C2=A0 =C2=A0request-update =3D "1"
=C2=A0 =C2=A0 vkbd =3D= ""
=C2=A0 =C2=A0 =C2=A01 =3D ""
=C2=A0 =C2=A0 = =C2=A0 0 =3D ""
=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend =3D "= /local/domain/1/device/vkbd/0"
=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-= id =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0online =3D "1"=
=C2=A0 =C2=A0 =C2=A0 =C2=A0state =3D "4"
=C2=A0 =C2=A0 =C2= =A0 =C2=A0feature-abs-pointer =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2= =A0feature-raw-pointer =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0hotp= lug-status =3D "connected"
=C2=A0 =C2=A0 console =3D "&qu= ot;
=C2=A0 =C2=A0 =C2=A01 =3D ""
=C2=A0 =C2=A0 =C2=A0 0 =3D= ""
=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domai= n/1/console"
=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1&quo= t;
=C2=A0 =C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0 =C2=A0 = =C2=A0 =C2=A0state =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0protocol= =3D "vt100"
=C2=A0 =C2=A0 vif =3D ""
=C2=A0 =C2= =A0 =C2=A01 =3D ""
=C2=A0 =C2=A0 =C2=A0 0 =3D ""
= =C2=A0 =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/vif/0&= quot;
=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
=C2=A0= =C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2= =A0state =3D "4"
=C2=A0 =C2=A0 =C2=A0 =C2=A0script =3D "/= etc/xen/scripts/vif-bridge"
=C2=A0 =C2=A0 =C2=A0 =C2=A0mac =3D &quo= t;e4:5f:01:cd:7b:dd"
=C2=A0 =C2=A0 =C2=A0 =C2=A0bridge =3D "xe= nbr0"
=C2=A0 =C2=A0 =C2=A0 =C2=A0handle =3D "0"
=C2=A0= =C2=A0 =C2=A0 =C2=A0type =3D "vif"
=C2=A0 =C2=A0 =C2=A0 =C2= =A0hotplug-status =3D "connected"
=C2=A0 =C2=A0 =C2=A0 =C2=A0f= eature-sg =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-gso-tcpv4= =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-gso-tcpv6 =3D &quo= t;1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-ipv6-csum-offload =3D "= ;1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-rx-copy =3D "1"=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-xdp-headroom =3D "1"
=C2= =A0 =C2=A0 =C2=A0 =C2=A0feature-rx-flip =3D "0"
=C2=A0 =C2=A0 = =C2=A0 =C2=A0feature-multicast-control =3D "1"
=C2=A0 =C2=A0 = =C2=A0 =C2=A0feature-dynamic-multicast-control =3D "1"
=C2=A0 = =C2=A0 =C2=A0 =C2=A0feature-split-event-channels =3D "1"
=C2= =A0 =C2=A0 =C2=A0 =C2=A0multi-queue-max-queues =3D "4"
=C2=A0 = =C2=A0 =C2=A0 =C2=A0feature-ctrl-ring =3D "1"
=C2=A0 1 =3D &qu= ot;"
=C2=A0 =C2=A0vm =3D "/vm/d81ec5a9-5bf9-4f2b-89e8-0f60d6da= 948f"
=C2=A0 =C2=A0name =3D "guest2"
=C2=A0 =C2=A0cpu = =3D ""
=C2=A0 =C2=A0 0 =3D ""
=C2=A0 =C2=A0 =C2= =A0availability =3D "online"
=C2=A0 =C2=A0 1 =3D ""<= br>=C2=A0 =C2=A0 =C2=A0availability =3D "online"
=C2=A0 =C2=A0= memory =3D ""
=C2=A0 =C2=A0 static-max =3D "2097152"=
=C2=A0 =C2=A0 target =3D "2097152"
=C2=A0 =C2=A0 videoram = =3D "0"
=C2=A0 =C2=A0device =3D ""
=C2=A0 =C2=A0 = suspend =3D ""
=C2=A0 =C2=A0 =C2=A0event-channel =3D "&qu= ot;
=C2=A0 =C2=A0 vbd =3D ""
=C2=A0 =C2=A0 =C2=A051712 =3D = ""
=C2=A0 =C2=A0 =C2=A0 backend =3D "/local/domain/0/back= end/vbd/1/51712"
=C2=A0 =C2=A0 =C2=A0 backend-id =3D "0"<= br>=C2=A0 =C2=A0 =C2=A0 state =3D "4"
=C2=A0 =C2=A0 =C2=A0 vir= tual-device =3D "51712"
=C2=A0 =C2=A0 =C2=A0 device-type =3D &= quot;disk"
=C2=A0 =C2=A0 =C2=A0 multi-queue-num-queues =3D "2&= quot;
=C2=A0 =C2=A0 =C2=A0 queue-0 =3D ""
=C2=A0 =C2=A0 =C2= =A0 =C2=A0ring-ref =3D "8"
=C2=A0 =C2=A0 =C2=A0 =C2=A0event-ch= annel =3D "4"
=C2=A0 =C2=A0 =C2=A0 queue-1 =3D ""=C2=A0 =C2=A0 =C2=A0 =C2=A0ring-ref =3D "9"
=C2=A0 =C2=A0 =C2= =A0 =C2=A0event-channel =3D "5"
=C2=A0 =C2=A0 =C2=A0 protocol = =3D "arm-abi"
=C2=A0 =C2=A0 =C2=A0 feature-persistent =3D &quo= t;1"
=C2=A0 =C2=A0 vfb =3D ""
=C2=A0 =C2=A0 =C2=A00 = =3D ""
=C2=A0 =C2=A0 =C2=A0 backend =3D "/local/domain/0/= backend/vfb/1/0"
=C2=A0 =C2=A0 =C2=A0 backend-id =3D "0"<= br>=C2=A0 =C2=A0 =C2=A0 state =3D "4"
=C2=A0 =C2=A0 =C2=A0 pag= e-ref =3D "275022"
=C2=A0 =C2=A0 =C2=A0 event-channel =3D &quo= t;3"
=C2=A0 =C2=A0 =C2=A0 protocol =3D "arm-abi"
=C2= =A0 =C2=A0 =C2=A0 feature-update =3D "1"
=C2=A0 =C2=A0 vkbd = =3D ""
=C2=A0 =C2=A0 =C2=A00 =3D ""
=C2=A0 =C2=A0= =C2=A0 backend =3D "/local/domain/0/backend/vkbd/1/0"
=C2=A0 = =C2=A0 =C2=A0 backend-id =3D "0"
=C2=A0 =C2=A0 =C2=A0 state = =3D "4"
=C2=A0 =C2=A0 =C2=A0 request-abs-pointer =3D "1&q= uot;
=C2=A0 =C2=A0 =C2=A0 page-ref =3D "275322"
=C2=A0 =C2= =A0 =C2=A0 page-gref =3D "1284"
=C2=A0 =C2=A0 =C2=A0 event-cha= nnel =3D "10"
=C2=A0 =C2=A0 vif =3D ""
=C2=A0 =C2= =A0 =C2=A00 =3D ""
=C2=A0 =C2=A0 =C2=A0 backend =3D "/loc= al/domain/0/backend/vif/1/0"
=C2=A0 =C2=A0 =C2=A0 backend-id =3D &q= uot;0"
=C2=A0 =C2=A0 =C2=A0 state =3D "4"
=C2=A0 =C2= =A0 =C2=A0 handle =3D "0"
=C2=A0 =C2=A0 =C2=A0 mac =3D "e= 4:5f:01:cd:7b:dd"
=C2=A0 =C2=A0 =C2=A0 mtu =3D "1500"
= =C2=A0 =C2=A0 =C2=A0 xdp-headroom =3D "0"
=C2=A0 =C2=A0 =C2=A0= multi-queue-num-queues =3D "2"
=C2=A0 =C2=A0 =C2=A0 queue-0 = =3D ""
=C2=A0 =C2=A0 =C2=A0 =C2=A0tx-ring-ref =3D "1280&q= uot;
=C2=A0 =C2=A0 =C2=A0 =C2=A0rx-ring-ref =3D "1281"
=C2= =A0 =C2=A0 =C2=A0 =C2=A0event-channel-tx =3D "6"
=C2=A0 =C2=A0= =C2=A0 =C2=A0event-channel-rx =3D "7"
=C2=A0 =C2=A0 =C2=A0 qu= eue-1 =3D ""
=C2=A0 =C2=A0 =C2=A0 =C2=A0tx-ring-ref =3D "= 1282"
=C2=A0 =C2=A0 =C2=A0 =C2=A0rx-ring-ref =3D "1283"=C2=A0 =C2=A0 =C2=A0 =C2=A0event-channel-tx =3D "8"
=C2=A0 = =C2=A0 =C2=A0 =C2=A0event-channel-rx =3D "9"
=C2=A0 =C2=A0 =C2= =A0 request-rx-copy =3D "1"
=C2=A0 =C2=A0 =C2=A0 feature-rx-no= tify =3D "1"
=C2=A0 =C2=A0 =C2=A0 feature-sg =3D "1"=
=C2=A0 =C2=A0 =C2=A0 feature-gso-tcpv4 =3D "1"
=C2=A0 =C2= =A0 =C2=A0 feature-gso-tcpv6 =3D "1"
=C2=A0 =C2=A0 =C2=A0 feat= ure-ipv6-csum-offload =3D "1"
=C2=A0 =C2=A0control =3D "&= quot;
=C2=A0 =C2=A0 shutdown =3D ""
=C2=A0 =C2=A0 feature-p= oweroff =3D "1"
=C2=A0 =C2=A0 feature-reboot =3D "1"=
=C2=A0 =C2=A0 feature-suspend =3D ""
=C2=A0 =C2=A0 sysrq = =3D ""
=C2=A0 =C2=A0 platform-feature-multiprocessor-suspend = =3D "1"
=C2=A0 =C2=A0 platform-feature-xs_reset_watches =3D &q= uot;1"
=C2=A0 =C2=A0data =3D ""
=C2=A0 =C2=A0drivers = =3D ""
=C2=A0 =C2=A0feature =3D ""
=C2=A0 =C2=A0a= ttr =3D ""
=C2=A0 =C2=A0error =3D ""
=C2=A0 =C2= =A0domid =3D "1"
=C2=A0 =C2=A0store =3D ""
=C2=A0= =C2=A0 port =3D "1"
=C2=A0 =C2=A0 ring-ref =3D "233473&q= uot;
=C2=A0 =C2=A0console =3D ""
=C2=A0 =C2=A0 backend =3D = "/local/domain/0/backend/console/1/0"
=C2=A0 =C2=A0 backend-id= =3D "0"
=C2=A0 =C2=A0 limit =3D "1048576"
=C2=A0= =C2=A0 type =3D "xenconsoled"
=C2=A0 =C2=A0 output =3D "= pty"
=C2=A0 =C2=A0 tty =3D "/dev/pts/1"
=C2=A0 =C2=A0 = port =3D "2"
=C2=A0 =C2=A0 ring-ref =3D "233472"
= =C2=A0 =C2=A0 vnc-listen =3D "127.0.0.1"
=C2=A0 =C2=A0 vnc-por= t =3D "5900"
=C2=A0 =C2=A0image =3D ""
=C2=A0 =C2= =A0 device-model-pid =3D "788"
vm =3D ""
=C2=A0d8= 1ec5a9-5bf9-4f2b-89e8-0f60d6da948f =3D ""
=C2=A0 name =3D &quo= t;guest2"
=C2=A0 uuid =3D "d81ec5a9-5bf9-4f2b-89e8-0f60d6da948= f"
=C2=A0 start_time =3D "1520600274.27"
libxl =3D &qu= ot;"
=C2=A01 =3D ""
=C2=A0 device =3D ""
= =C2=A0 =C2=A0vbd =3D ""
=C2=A0 =C2=A0 51712 =3D ""=C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/vbd/51712&q= uot;
=C2=A0 =C2=A0 =C2=A0backend =3D "/local/domain/0/backend/vbd/1= /51712"
=C2=A0 =C2=A0 =C2=A0params =3D "/home/root/guest2/xen-= guest-image-minimal-raspberrypi4-64.ext3"
=C2=A0 =C2=A0 =C2=A0scrip= t =3D "/etc/xen/scripts/block"
=C2=A0 =C2=A0 =C2=A0frontend-id= =3D "1"
=C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2= =A0 =C2=A0 =C2=A0removable =3D "0"
=C2=A0 =C2=A0 =C2=A0bootabl= e =3D "1"
=C2=A0 =C2=A0 =C2=A0state =3D "1"
=C2= =A0 =C2=A0 =C2=A0dev =3D "xvda"
=C2=A0 =C2=A0 =C2=A0type =3D &= quot;phy"
=C2=A0 =C2=A0 =C2=A0mode =3D "w"
=C2=A0 =C2= =A0 =C2=A0device-type =3D "disk"
=C2=A0 =C2=A0 =C2=A0discard-e= nable =3D "1"
=C2=A0 =C2=A0vfb =3D ""
=C2=A0 =C2= =A0 0 =3D ""
=C2=A0 =C2=A0 =C2=A0frontend =3D "/local/dom= ain/1/device/vfb/0"
=C2=A0 =C2=A0 =C2=A0backend =3D "/local/do= main/0/backend/vfb/1/0"
=C2=A0 =C2=A0 =C2=A0frontend-id =3D "1= "
=C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0 =C2=A0 =C2= =A0state =3D "1"
=C2=A0 =C2=A0 =C2=A0vnc =3D "1"
= =C2=A0 =C2=A0 =C2=A0vnclisten =3D "127.0.0.1"
=C2=A0 =C2=A0 = =C2=A0vncdisplay =3D "0"
=C2=A0 =C2=A0 =C2=A0vncunused =3D &qu= ot;1"
=C2=A0 =C2=A0 =C2=A0sdl =3D "0"
=C2=A0 =C2=A0 = =C2=A0opengl =3D "0"
=C2=A0 =C2=A0vkbd =3D ""
=C2= =A0 =C2=A0 0 =3D ""
=C2=A0 =C2=A0 =C2=A0frontend =3D "/lo= cal/domain/1/device/vkbd/0"
=C2=A0 =C2=A0 =C2=A0backend =3D "/= local/domain/0/backend/vkbd/1/0"
=C2=A0 =C2=A0 =C2=A0frontend-id = =3D "1"
=C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0= =C2=A0 =C2=A0state =3D "1"
=C2=A0 =C2=A0console =3D "&qu= ot;
=C2=A0 =C2=A0 0 =3D ""
=C2=A0 =C2=A0 =C2=A0frontend =3D= "/local/domain/1/console"
=C2=A0 =C2=A0 =C2=A0backend =3D &qu= ot;/local/domain/0/backend/console/1/0"
=C2=A0 =C2=A0 =C2=A0fronten= d-id =3D "1"
=C2=A0 =C2=A0 =C2=A0online =3D "1"
= =C2=A0 =C2=A0 =C2=A0state =3D "1"
=C2=A0 =C2=A0 =C2=A0protocol= =3D "vt100"
=C2=A0 =C2=A0vif =3D ""
=C2=A0 =C2= =A0 0 =3D ""
=C2=A0 =C2=A0 =C2=A0frontend =3D "/local/dom= ain/1/device/vif/0"
=C2=A0 =C2=A0 =C2=A0backend =3D "/local/do= main/0/backend/vif/1/0"
=C2=A0 =C2=A0 =C2=A0frontend-id =3D "1= "
=C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0 =C2=A0 =C2= =A0state =3D "1"
=C2=A0 =C2=A0 =C2=A0script =3D "/etc/xen= /scripts/vif-bridge"
=C2=A0 =C2=A0 =C2=A0mac =3D "e4:5f:01:cd:= 7b:dd"
=C2=A0 =C2=A0 =C2=A0bridge =3D "xenbr0"
=C2=A0 = =C2=A0 =C2=A0handle =3D "0"
=C2=A0 =C2=A0 =C2=A0type =3D "= ;vif"
=C2=A0 =C2=A0 =C2=A0hotplug-status =3D ""
=C2=A0= type =3D "pvh"
=C2=A0 dm-version =3D "qemu_xen"
= root@raspberrypi4-64:~/guest1#

Any input a= s per above? Looking forward to hearing from you.

= Regards,
Vipul Kumar

On Wed, Oct 26, 2022 at 5:21 AM Stefano= Stabellini <sstabellini@kerne= l.org> wrote:
Hi Vipul,

If you look at the QEMU logs, it says:

VNC server running on 127.0.0.1:5900

That is the VNC server you need to connect to. So in theory:

=C2=A0 vncviewer 127.0.0.1:5900

should work correctly.


If you have:

=C2=A0 vfb =3D ["type=3Dvnc"]

in your xl config file and you have "fbdev" in your Linux guest, = it
should work.

If you connect to the VNC server but you get a black screen, it might be a guest configuration issue. I would try with a simpler guest, text only (no X11, no Wayland) and enable the fbdev console (fbcon). See
Documentation/fb/fbcon.rst in Linux. You should be able to see a
graphical console over VNC.

If that works, then you know that the fbdev kernel driver (xen-fbfront)
works correctly.

If it doesn't work, the output of "xenstore-ls" would be inte= resting.

Cheers,

Stefano


On Wed, 19 Oct 2022, Vipul Suneja wrote:
> Hi Stefano,
>
> Thanks for the response!
>
> I am following the same link you shared from the beginning. Tried the = command "vncviewer localhost:0" in DOM0 but same issue "Can&= #39;t open
> display", below are the logs:
>
> root@raspberrypi4-64:~# vncviewer localhost:0
>
> TigerVNC Viewer 64-bit v1.11.0
> Built on: 2020-09-08 12:16
> Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst)=
> See https://www.tigervnc.org for information on TigerVNC.
> Can't open display:
>
> Below are the netstat logs, i couldn't see anything running at por= t 5900 or 5901:
>
> root@raspberrypi4-64:~# netstat -tuwx
> Active Internet connections (w/o servers)
> Proto Recv-Q Send-Q Local Address =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 F= oreign Address =C2=A0 =C2=A0 =C2=A0 =C2=A0 State =C2=A0 =C2=A0 =C2=A0
> tcp =C2=A0 =C2=A0 =C2=A0 =C2=A00 =C2=A0 =C2=A0164 192.168.1.39:ssh =C2= =A0 =C2=A0 =C2=A0 =C2=A0192.168.1.38:37472 =C2=A0 =C2=A0 =C2=A0ESTABLIS= HED
> Active UNIX domain sockets (w/o servers)
> Proto RefCnt Flags =C2=A0 =C2=A0 =C2=A0 Type =C2=A0 =C2=A0 =C2=A0 Stat= e =C2=A0 =C2=A0 =C2=A0 =C2=A0 I-Node Path
> unix =C2=A08 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A010565 /dev/log
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010891 /var/run/xenstored/sock= et
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013791
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010843 /var/run/xenstored/sock= et
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010573 /var/run/xenstored/sock= et
> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A014510
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013249
> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A013887
> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A010599
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A014005
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013258
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013248
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A014003
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010572 /var/run/xenstored/sock= et
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010786 /var/run/xenstored/sock= et
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A013186
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010864 /var/run/xenstored/sock= et
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010812 /var/run/xenstored/sock= et
> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A014083
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010813 /var/run/xenstored/sock= et
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A014068
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013256
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010571 /var/run/xenstored/sock= et
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010842
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013985
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A013185
> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013884
> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A014528
> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A013785
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A014034
>
> Attaching xen log files of /var/log/xen.
> I didn't get the role of QEMU here because as mentioned earlier, I= am porting in raspberrypi 4B.
>
> Regards,
> Vipul Kumar
>
> On Wed, Oct 19, 2022 at 12:43 AM Stefano Stabellini <sstabellini@kernel.org>= ; wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0It usually works the way it is described in = the guide:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0https://www.virtu= atopia.com/index.php?title=3DConfiguring_a_VNC_based_Graphical_Console_for_= a_Xen_Paravirtualized_domainU_Guest
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0You don't need to install any VNC-relate= d server software because it is
>=C2=A0 =C2=A0 =C2=A0 =C2=A0already provided by Xen (to be precise it is= provided by QEMU working
>=C2=A0 =C2=A0 =C2=A0 =C2=A0together with Xen.)
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0You only need the vnc client in dom0 so that= you can connect, but you
>=C2=A0 =C2=A0 =C2=A0 =C2=A0could also run the vnc client outside from a= nother host. So basically
>=C2=A0 =C2=A0 =C2=A0 =C2=A0the following should work when executed in D= om0 after creating DomU:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 vncviewer localhost:0
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Can you attach the Xen and QEMU logs (/var/l= og/xen/*)? And also use
>=C2=A0 =C2=A0 =C2=A0 =C2=A0netstat -taunp to check if there is anything= running at port 5900 or
>=C2=A0 =C2=A0 =C2=A0 =C2=A05901?
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Cheers,
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Stefano
>
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0On Tue, 18 Oct 2022, Vipul Suneja wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Hi Stefano,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Thanks for the response!
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> I could install tigerVNC, x11vnc & = libvncserver in Dom0 xen-image-minimal but only manage to install libvncser= ver(couldn't
>=C2=A0 =C2=A0 =C2=A0 =C2=A0install tigervnc
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> & x11vnc because of x11
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> support missing, it's wayland) in D= OMU custom graphical image. I tried running vncviewer with IP address &= port in dom0 to
>=C2=A0 =C2=A0 =C2=A0 =C2=A0access the domu
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> graphical image display as per below co= mmands.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0vncviewer 192.168.1.42:5901 >=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0But it showing can't open dis= play, below are the logs:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> root@raspberrypi4-64:~/guest1# vncviewe= r 192.168.1.42:5901
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> TigerVNC Viewer 64-bit v1.11.0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Built on: 2020-09-08 12:16
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Copyright (C) 1999-2020 TigerVNC Team a= nd many others (see README.rst)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> See https://www.tigervnc.org for inf= ormation on TigerVNC.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Can't open display:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> root@raspberrypi4-64:~/guest1#
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> I am not exactly=C2=A0sure what the iss= ue is but I thought only libvncserver in DOMU could work to get access but = it did not
>=C2=A0 =C2=A0 =C2=A0 =C2=A0work.=C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> If TigerVNC is the issue here then is t= here any other VNC source which could be installed for both x11 & wayla= nd supported
>=C2=A0 =C2=A0 =C2=A0 =C2=A0images?
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Regards,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Vipul Kumar
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> On Tue, Oct 18, 2022 at 2:40 AM Stefano= Stabellini <sstabellini@kernel.org> wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0VNC is typica= lly easier to setup, because SDL needs extra libraries at
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0build time an= d runtime. If QEMU is built without SDL support it won't
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0start when yo= u ask for SDL.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0VNC should wo= rk with both x11 and wayland in your domU. It doesn't work
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0at the x11 le= vel, it exposes a special fbdev device in your domU that
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0should work w= ith:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0- a graphical= console in Linux domU
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0- x11
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0- wayland (bu= t I haven't tested this so I am not 100% sure about it)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0When you say = "it doesn't work", what do you mean? Do you get a black
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0window?
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0You need CONF= IG_XEN_FBDEV_FRONTEND in Linux domU
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0(drivers/vide= o/fbdev/xen-fbfront.c). I would try to get a graphical text
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0console up an= d running in your domU before attempting x11/wayland.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0Cheers,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0Stefano
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0On Mon, 17 Oc= t 2022, Vipul Suneja wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Hi,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Thanks!<= br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> I have p= orted xen minimal image as DOM0 & custom wayland GUI based image as DOM= U in raspberry pi4B. I am trying to
>=C2=A0 =C2=A0 =C2=A0 =C2=A0make GUI
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0display up >=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> for=C2= =A0guest machine. I tried using=C2=A0sdl, included below line in guest.conf= file
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> vfb=3D [= 'sdl=3D1' ]
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> But it i= s throwing below error:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> root@ras= pberrypi4-64:~/guest1# xl create -c guest1.cfg
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Parsing = config from guest1.cfg
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain 3:error on QMP socket: Co= nnection reset by peer
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the= QMP connection to QEMU
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_dm.c:3351:device_model_postconfig_done: Domain 3:Post DM startu= p configs failed, rc=3D-26
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_create.c:1867:domcreate_devmodel_started: Domain 3:device model= did not start: -26
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_aoutils.c:646:libxl__kill_xs_path: Device Model already exited<= br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_domain.c:1183:libxl__destroy_domid: Domain 3:Non-existant domai= n
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to destr= oy guest
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_domain.c:1064:domain_destroy_cb: Domain 3:Destruction of domain= failed
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Another = way is VNC, i could install tigervnc in DOM0 but same i couldn't in gue= st machine because it doesn't support
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0x11(supports = wayland
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> only). I= am completely blocked here, Need your support to enable the display up. >=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Any alte= rnative of VNC which could work in both x11 & wayland supported images?=
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Any inpu= t on VNC, SDL or any other way to proceed on this? Looking forward to heari= ng from you.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Regards,=
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Vipul Ku= mar
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>
>
>
--0000000000003f5b9605ec93d92d-- From xen-devel-bounces@lists.xenproject.org Thu Nov 03 17:00:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 17:00:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436931.691167 (Exim 4.92) (envelope-from ) id 1oqdZh-0008Mj-1l; Thu, 03 Nov 2022 17:00:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436931.691167; Thu, 03 Nov 2022 17:00:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdZg-0008Mc-UY; Thu, 03 Nov 2022 17:00:16 +0000 Received: by outflank-mailman (input) for mailman id 436931; Thu, 03 Nov 2022 17:00:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdZg-0008MW-EN for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 17:00:16 +0000 Received: from dibed.net-space.pl (dibed.net-space.pl [84.10.22.86]) by se1-gles-sth1.inumbo.com (Halon) with SMTP id fc43d110-5b98-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 18:00:14 +0100 (CET) Received: from router-fw.i.net-space.pl ([192.168.52.1]:42450 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S2156408AbiKCQjb (ORCPT ); Thu, 3 Nov 2022 17:39:31 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc43d110-5b98-11ed-91b5-6bf2151ebd3b X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Thu, 3 Nov 2022 17:39:25 +0100 From: Daniel Kiper To: grub-devel@gnu.org, Denton Liu , mathieu.desnoyers@efficios.com, rharwood@redhat.com, samuel.thibault@ens-lyon.org, debian-bsd@lists.debian.org, xen-devel@lists.xenproject.org, Olaf Hering Subject: Re: [PATCH v5] templates: introduce GRUB_TOP_LEVEL_* vars Message-ID: <20221103163925.kmisraj4l2d5inbr@tomti.i.net-space.pl> References: <20221024104642.251016-1-liu.denton@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) On Mon, Oct 24, 2022 at 10:21:25PM -0500, Oskari Pirhonen wrote: > On Mon, Oct 24, 2022 at 03:46:42 -0700, Denton Liu wrote: > > A user may wish to use an image that is not sorted as the "latest" > > version as the top-level entry. For example, in Arch Linux, if a user > > has the LTS and regular kernels installed, `/boot/vmlinuz-linux-lts` > > gets sorted as the "latest" compared to `/boot/vmlinuz-linux`, meaning > > the LTS kernel becomes the top-level entry. However, a user may wish to > > use the regular kernel as the top-level default with the LTS only > > existing as a backup. > > > > This need can be seen in Arch Linux's AUR with two user-submitted > > packages[0][1] providing an update hook which patches > > /etc/grub.d/10_linux to move the desired kernel to the top-level. This > > patch serves to solve this in a more generic way. > > > > Introduce the GRUB_TOP_LEVEL, GRUB_TOP_LEVEL_XEN and > > GRUB_TOP_LEVEL_OS_PROBER variables to allow users to specify the > > top-level entry. > > > > Create grub_move_to_front() as a helper function which moves entries to > > the front of a list. This function does the heavy lifting of moving > > the menu entry to the front in each script. > > > > In 10_netbsd, since there isn't an explicit list variable, extract the > > items that are being iterated through into a list so that we can > > optionally apply grub_move_to_front() to the list before the loop. > > > > [0]: https://aur.archlinux.org/packages/grub-linux-default-hook > > [1]: https://aur.archlinux.org/packages/grub-linux-rt-default-hook > > > > Signed-off-by: Denton Liu > > Reviewed-by: Oskari Pirhonen Reviewed-by: Daniel Kiper If I do not hear any objections in a week or so I will merge this patch. Daniel From xen-devel-bounces@lists.xenproject.org Thu Nov 03 17:03:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 17:03:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436936.691177 (Exim 4.92) (envelope-from ) id 1oqdcU-0000YB-F5; Thu, 03 Nov 2022 17:03:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436936.691177; Thu, 03 Nov 2022 17:03:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdcU-0000Y4-Bl; Thu, 03 Nov 2022 17:03:10 +0000 Received: by outflank-mailman (input) for mailman id 436936; Thu, 03 Nov 2022 17:03:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdcT-0000Xu-Kw for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 17:03:09 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f03ef7f-5b99-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 18:03:01 +0100 (CET) Received: from mail-bn8nam12lp2168.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Nov 2022 13:03:04 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MN2PR03MB5312.namprd03.prod.outlook.com (2603:10b6:208:1e9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 17:03:01 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%5]) with mapi id 15.20.5769.021; Thu, 3 Nov 2022 17:03:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f03ef7f-5b99-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667494987; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=IAdatCBRiJyPT49nYFGLUm0dyNTv3CsYX7ltbfuooKQ=; b=Dv4IgRkcUVC6sSHsKHUzvH6vGanORXqiHfCI83I41d5LkjI9DjtEaX7H acafStvbIszSZbBwF0obqBvLWHiVK1TYBHLhf8jb0WPmAU1hoUGy9yL/d id0h9BhWgsRxh/raFKIZQQlfxrEJf0GM5ncnKuJfVFdga4j+5JgD2jv+o 8=; X-IronPort-RemoteIP: 104.47.55.168 X-IronPort-MID: 84136002 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:wKrhJqkX1VKOEcqUQ+w3cHjo5gxaJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJLDWyDb6mJYzHzeNxxb4uz90kDuJHXydFqHAZq/CA2ECMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5ASGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 e0YBWtXdxadveaVwZHhYbBrr5UbPNa+aevzulk4pd3YJdAPZMmZBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3iea9WDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnzX+iA9xKTOfQGvhCoH6252FMLx4sZ3T8iKjokESFaoNVA hlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQPwrstUnAwMj0 FChlsnsQzdotdW9S3iQ67OVpjOaIjUOICkJYipsZQkY59jupqkjgxSJScxseIaulcH8Ezz0x zGMrQA9iq8VgMpN0L+0lXjYhxq8q56PSRQ6jjg7RUqg5wJ9IYSjN4qh7AGB6e4addjJCF6co HIDhs6SqvgUCo2AnzCMR+NLG6y14/GCM3vXhlsH84QdyglBMkWLJeh4iAyS7m8zWirYUVcFu HPuhD4= IronPort-HdrOrdr: A9a23:+useRqOZxXFWWMBcTy7155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBDpTnmAtj5fZq8z+8N3WB1B9uftWbdyQ+Vxe1ZjbcKoAeQZhEWiNQtsp uIGpIWYLOQMbETt7eB3ODSKadE/DDoytHKuQ+IpE0dNj2CJpsQmztRO0K+KAlbVQNGDZ02GN 614ddGnSOpfTAyYt6gDncIcuDfr5mT/aiWFyIuNloC0k2jnDmo4Ln1H1yx2QofaSpGxfMH/X LemwL0y62/u7WQywPa1UXU85NK8eGRvedrNYipsIw4Oz/sggGnaMBIXKCDhik8pKWV5FMjgL D30mQdFvU2z0mUUnC+oBPr1QWl+i0p8WXexViRhmamidDlRRohYvAxz75xQ1/80Q4Nrdt82K VE0yayrJxMFy7Nmyz7+pzhSwxqrEypunAv+NRjxEC3abFuJIO5kLZvs3+8SPw7bWzHAcEcYa FT5fjnlbtrmQjwVQGZgoFtqObcLkjbUC32AnTqgfblrQS+rEoJs3fw+/Zv4UvojKhNLaWsx9 60QJiAx4s+O/M+XOZaONorZ/eRJyjkfS/sWVjiUGgPUpt3ck7wlw== X-IronPort-AV: E=Sophos;i="5.96,134,1665460800"; d="scan'208";a="84136002" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZHMkGdB4I2y1XxP8fEM/yZEh0bnewL1co7Ao7zjGJG0XVGYj29/XgNVXYLtJZ8b7O8XWwfzMm/A+UHR01p5OIeiHiWwPdggNmoEIkCxbrVLtbHnUEds5xBadWNrQL0bjrh5IhRc/7wl0uhjJbe+zDnrdPlcwmKVvJcnYHlS4Sje9ILtcUTmCwufJS1AEkb2SdbRcZ6uha+dKJQlr9ybF5Ivn4JF3+XowlWcT9qu3YjHLzGQJDjXq4jrV1qKrv8T7d7AIOsQx6LLMYqp6ZkjFv5YviicXoap85i5faQ0MSzLdS/igic+sNT82qfyLCs/XLJon/hqZpe9vdnZuybNU8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EIU2lRGYZkbDmSI0A87U+VhmPegTQ3g81V0phGsulak=; b=mr8xqgDHKwtV1wBS9S8J+RSmbsIrriKZRGbsIP2rWSC2sHDJcZIWeWPDCA+8eKO1kvYGkckG6wPR3035wLVZ3PxccgAoA56sy7CCxdIM+R9c/nTFeN1w6lBTCzQvMaWJSE/pEuV8Qh6amN61Z6rqxZyToztnEiAw/LMVkqFINUy7jUwSC3hjP+SCwGKg22lGx4fnGkcogyqjjOIDZl8EnEQaIyp7KCAEByXwNLIP2U++s1laysMV+oiO3+wDSo3ukna+oXfH4tO1TirBnZHvwh16Mmt13wcwJlgK+/Y0nig38hc4sTPsY0ATei24WE/3U7PhVwh10dn49eKHshZM+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EIU2lRGYZkbDmSI0A87U+VhmPegTQ3g81V0phGsulak=; b=uotWCYIptuTrJTd54Avt4IYExz8cIx44mRayd5nmz8HJYLRz/KjiPGTvrQzGMLyGRyA/pAd4T4vrFHNI4e9ikqiUnELVcP4+03R+0QCwQapSVFIs4UTOMnLjKwEu+K1iXr8n/ElGmGMjvIq7vvbFpa5rbuSOUo4NAdISlQCtU8E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Roger Pau Monne , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH for-4.17 v3 0/2] amd/virt_ssbd: refactoring and fixes Date: Thu, 3 Nov 2022 18:02:42 +0100 Message-Id: <20221103170244.29270-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0451.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::6) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB5312:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c578e49-a089-452a-7b13-08dabdbd4407 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fqUX+/2tfSoeo3lRx48tYwth+6kZlPFNlAgbT49yw7nLTO2+NUf4EOzpVLSF6yOVEKJlBlaeB9xNTepuvSs2RcmzQOA/euQlP/144fjSUA1b3opKqqOEMjkacQYXcKB5ZknbuE3IaM1GNM3dgzRZwyTMcadXiJShChCNL1XV/Ww6Xx/1TVt3xwHal+vO2GpCflbvIGZ5FaZVOeIEQZL/ol1ToVineZR9Lj2ng4fqL4K8uuF0NSs6NSLa9+iPbLSUws/KLoN3yoHb6UMunPTBNqAmR5pYM7dPbLKmHBnFdOVXfUmoTPfU+duJaOjAeSNyqgrfyolZdS+UryBloaseD9MfSeoxWyjGaBylxr+jbgidZajDDDi3dHitTfSZnKq3yf9lvrkhuT9WGaVXEV5pRJZ3Lcce8Jn/D1WyBXeK0zqR8mWk4FgcNxPowMQ806s7mVusY/hhysyhcdBSo6WoIFl+xRjMFcAHzvBHBXt+MFMAp/N4u/xM4gwHKOjXljrTe106jAdTlvjr6P8ctffvQaQPuPvenbfvuxLJVNL1pb0m0vA+MqZ1Oy4uRJS5WpTlWepdrdXG1HXlQAN+ozGocnxBU63c9K6LalhDF2PVLLxE9fjKOI9serfsL1DB3y3aczdseI38kS1B8phpUl3hVd+myHIjmyDFZTsE67gxt7L6soSuGAgTTLnr2FDFRmVrkEYn3LMo1XXyOlZ+vS0u5Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(136003)(396003)(346002)(376002)(451199015)(66899015)(36756003)(5660300002)(86362001)(4326008)(6916009)(4744005)(82960400001)(38100700002)(316002)(54906003)(8676002)(186003)(1076003)(66946007)(8936002)(83380400001)(6512007)(2616005)(2906002)(478600001)(6666004)(41300700001)(6486002)(26005)(6506007)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEoxOFFTUThTS2ljYXFPU3NmM2s5UFplT3dnUjZMQ3l1QlczeGlRT2VlVjFi?= =?utf-8?B?MENhU3pmUlk3KzVZQzFSWDZiUHZEZjVPRE1haGZqY0F2MDF4aHpVVDk3a2tI?= =?utf-8?B?S3BrMnFWbEhXNmkxNkNBYU9nZkMwZExEdDdRTGVFMVh2c3JKendSaXo5Ry9K?= =?utf-8?B?VDV1Z1luZXFSaktIZEd3ZTZHVURkb1E0a3MxWjQxS1p6ZlU2SWpWUTNhV0xL?= =?utf-8?B?Q1Fob0ZJdDR0MExKUEhGdHRzZzdyekdLQittZ2h4d2Z5UVhEUDJDSWZ4RTho?= =?utf-8?B?bWVvN3VKTHUzZUVmUzJHOE9YY3hOc1VURElHR1hsS2hHM056T0ZEVDZIbEIy?= =?utf-8?B?MlRGckVQK2NWZWpDM1RoMXdZdHg3aUd2encrbk1CTEM5MTAvR25DdDhNcmE4?= =?utf-8?B?Q3o2UW5ZM1pFeHlJQ2w3Tm5YRVdqbVU1Wk84UFlJQU5yWWJQaWJ5cDgrZ0tG?= =?utf-8?B?TkhVWTVHZVlhVXJCVTlab1JrK3pkbVQ0MWtJcEpxaEV6K29uN3h2OW8vTDZ2?= =?utf-8?B?LzhHZHU1ZUhOWVJhZGx0OXlrN2diSUpTcGhPbHVzcVRXNG5iRVkveGwxMGJP?= =?utf-8?B?NlAxTWdoeGdrdGxBN3VGUytwN1lrWmdEV1RmWnlvTzM5WkNLNktUeVN2NXZ6?= =?utf-8?B?cFZDMm9PNkZMbzhoSVdrYXhaalBOM2V5c1pmRWEvUW5RdVpud3YvYURvK0xO?= =?utf-8?B?c1kvSmlIL3NIbE93OWpRU1ZTYkJmWGlnNlh4TS9jYnIyamxtSUw0NmZqYnhV?= =?utf-8?B?RWNPM0hqUVNLMVR6V0o4S1NEc1BmSW1wcUpwSXRkRmMwTml0YTRqRGtjWU84?= =?utf-8?B?L2lsdUpNUjE0M1hrMGJjQ1hHOGpzSXowZkpTV29sbnJPbWM3QWNCdlh1dGkw?= =?utf-8?B?SzdBelRsN0dPeEVpdzlIS0VqQU5YdHhPMWpPWWVqbkJScW85YzRHVlRiVUJ2?= =?utf-8?B?Yk5pa1IxVVJRUFAwcDRMenpYdFJ0QW45WkxBTFdDUnVWbmNqSVVtTzJNUEtJ?= =?utf-8?B?UTRrL0ZhWFRoSDM5N3hSR2xhYW1ES3p1TmN6bUJUNTl3T2ZBT3Rnalp6WFg2?= =?utf-8?B?b281dnJYdGd6ZmR1eERDRHdobTZ3azFTbFdMTkN6aDJkTE14NUhtc1lpMG5G?= =?utf-8?B?RDZDL1hCaWxDRmwzdUtuYUhPbFd0UGpJc3hsNE5FZXB0L2VCNTFZUlZkNHFk?= =?utf-8?B?Sjc3VTVkUHhhc2lqTEdwYTJaNXIybFRDdWNjZkwybndYN2dNZ3ZJb2Ewb0Iy?= =?utf-8?B?eXZyWGphYStuZVhNb0oyQUlkZHI5WmtoYkxIMlNBYkNKb2xrTkh2U092NXFw?= =?utf-8?B?QWovd2tCQmhlcnZoaE5nVHVmWjBuUXd3U1VJNG04TnJBdHFQRElTaHdnd01V?= =?utf-8?B?WDE2Q1ZhUzFkR3Q1L1ZvUWZFTVpVU1JEVWxDeTNHYUpSSUxUd3ZLV0FLVTlI?= =?utf-8?B?QS9DcXQxL0JkUHBSSVZJblEzenk2SFJRZ0doVFJaVWNmVVFFeHB0eHlmMGpH?= =?utf-8?B?c210aGxIS1R1NFFvTjNRQWpXaHBMUVlFT1lQQ3BiRVRGdjZ4NXBwRjFmL1U4?= =?utf-8?B?RzJmNVBmQXZHbXFGK0JVcnlHN0E2YjZ4cTJxelJPOVRDY1VKZmJMS3p1djZE?= =?utf-8?B?S0tyQklLdTFrUGxUMGZlT0xHZE5rbys1ZkVZL3N0YnRxV0ppOFljM0hBeE1P?= =?utf-8?B?Nmh1MXVheWVNNDgvcjdkUGtOSTFWdzhVWTc4WDh0RzNxYUl0TE04Y2FsbTFS?= =?utf-8?B?TjBDdmlTemd0aEpLWWIrcU00dUx4Q3owMGlzMjRCRnVMUGxibitCN0tDZDhl?= =?utf-8?B?NWdYT3o1NmlQTDhUTHN5aHpZODhqUzhkYXZhQ3N4Z1o2Z2JpemQ3bmZReVVr?= =?utf-8?B?L1Z0MmU0ZGR3c25lZDg3a0dYUnhBVDNxL3pmb2I3V1h2S3pwMG1tSWUwR2RL?= =?utf-8?B?V0YwT2MwalpwcU1hTXF5eE5MaGxGME8rNE5SZVpVNzZleXdiblZKK1R3cVI4?= =?utf-8?B?eG9pTS9VdHBGeFIzdUdReTdSdllGVUtDNTI5Yk5IcU0yeHRiZXJRT29LM3lt?= =?utf-8?B?d3g0L1YrbjlJZ1Y1NnZTU3NDWTg0VU1FNlRGVE9Wa0NLcXFhaDQ3SEQ5allB?= =?utf-8?Q?pA/dujIsP6uFCfqbMvMCpd+rN?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c578e49-a089-452a-7b13-08dabdbd4407 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 17:03:01.5718 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: enjedoF5s+71DxwztSplXjp8jvJWwAp7Qe4OnxluP2+BmGoripYSVcY5aEmFseGCmhhklWCDLagq+BZ2A1tYSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5312 Hello, Just two patches remaining, and the last one is already Acked. First patch deals with moving the switching of SSBD from guest vm{entry,exit} to vCPU context switch, and lets Xen run with the guest SSBD selection under some circumstances by default. Thanks, Roger. Roger Pau Monne (2): amd/virt_ssbd: set SSBD at vCPU context switch amd: remove VIRT_SC_MSR_HVM synthetic feature docs/misc/xen-command-line.pandoc | 10 +++-- xen/arch/x86/cpu/amd.c | 56 ++++++++++++++------------ xen/arch/x86/cpuid.c | 9 +++-- xen/arch/x86/hvm/svm/entry.S | 6 --- xen/arch/x86/hvm/svm/svm.c | 45 ++++++++------------- xen/arch/x86/include/asm/amd.h | 3 +- xen/arch/x86/include/asm/cpufeatures.h | 2 +- xen/arch/x86/msr.c | 9 +++++ xen/arch/x86/spec_ctrl.c | 8 ++-- 9 files changed, 75 insertions(+), 73 deletions(-) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 17:03:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 17:03:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436937.691189 (Exim 4.92) (envelope-from ) id 1oqdce-0000qI-N5; Thu, 03 Nov 2022 17:03:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436937.691189; Thu, 03 Nov 2022 17:03:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdce-0000q9-Jp; Thu, 03 Nov 2022 17:03:20 +0000 Received: by outflank-mailman (input) for mailman id 436937; Thu, 03 Nov 2022 17:03:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdcc-0000Xu-RQ for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 17:03:19 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 65401f76-5b99-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 18:03:11 +0100 (CET) Received: from mail-bn8nam12lp2172.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Nov 2022 13:03:15 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MN2PR03MB5312.namprd03.prod.outlook.com (2603:10b6:208:1e9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 17:03:13 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%5]) with mapi id 15.20.5769.021; Thu, 3 Nov 2022 17:03:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65401f76-5b99-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667494997; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=PLbpNoBl19EFTypyz3W81ikc0X/QmIRH0jO2ZY90Z1k=; b=fMDCSpwn2pDh8obL0Mq8kyKPqOLp17r/ahK0zgvIdpDwsWFd2yLr95pm ElEax9R7o3ALUqNsuucxJcLY2LRnrLi3WxgM1s0pnP5hpj/RuCg5f8p1y z8xUs+YdBSdrLTp6EvlyXe8ShxerAuLbhelV34ihmP9ICq3T9SIqAG3lV U=; X-IronPort-RemoteIP: 104.47.55.172 X-IronPort-MID: 84136024 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:pLoiOahPhD8mD327IYSj67PBX161UxEKZh0ujC45NGQN5FlHY01je htvD2nVPf/cYDTzeNF3a4znpEJUvpTdn4I3HAM4qH9hRi4b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QeFzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQfIQ4MUk7Ao9icnqKCUdtnheIec/bkadZ3VnFIlVk1DN4AaLWaGeDgw48d2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEsluGyarI5efTTLSlRtlyfq W/cuXzwHzkRNcCFyCrD+XWp7gPKtXOnAdlMTOfknhJsqE+I7FY9IxAPbwTlgenn0Vz9UN9TA lNBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQGucksVHoV3 1mGt9rzAHpkt7j9YXCX+6qQrDiyETMINmJEbigBJSMa5/HzrYd1iQjAJuuPC4awh9zxXDv2k zaDqXFkg61J1JFRkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5 BAs8/VyJshVZX1RvERhmNkwIYw= IronPort-HdrOrdr: A9a23:tkdPZ6iTTiOp2jsISb8UgtbVyHBQX0F13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK/yXcT2/hqAV7CZnichILMFu1fBOTZslnd8kHFltK1kJ 0QCpSWa+eAcmSS8/yKhzVQeuxIqLfnzEnrv5an854Ed3AXV0gK1XYdNu/0KDwUeOEQbqBJaa Z0q/A30QaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9QwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgrf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQS/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpbzPKN MeQv002cwmMG9zNxvizylSKZ2XLz4O9y69Mwc/Upf/6UkUoJh7p3FotvD30E1wtq7VcKM0l9 gsAp4Y6o2mcfVmHJ6VfN1xJ/dfKla9NS4kY1jiVmjPJeUgB0/njaLRzfEc2NyKEaZ4v6fa3q 6xG29liQ== X-IronPort-AV: E=Sophos;i="5.96,134,1665460800"; d="scan'208";a="84136024" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TwYokqzqKMS2vY6BV5PHTqrajLQFqTu042hm8OdBNwqujc8+pUgMGAw4qCRhXanwHXwnrbz7h2ut9QQcu30vCT1LIOQbo04FQdswvd4GBay4hz9wQHJkTGqQd47K6I6fJ/cvBhJGC6MgiHqGZ3ledwdX3y0iXnRc5j45oNevYS7qjM9v9mddUK9a1n4URggh8kkxOcJdE5oc0A8K4iTbmppv9ypMmu5eF6CK8PquWDWe4WezoAGD05d72qFz42dQHB/afIu+hM6HlmqAn6sYQcrKZPGAS7bPIOwZw6m3260H0eJ7Tr7Jc8+tH+asgiIuCayv0mXqPmFEKtmhXZpzAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4CElUPn28iYIvbpP32jZwx7fJ1f1O4O5cnT/1nta7z4=; b=RXOeczk4myTxOu1PA0rERkL8MfCZhlTR7/FbfoS/Eovir+X49ibHOGs5v2Ju//wHwas9uTZpIa/JPhE5MW3vSujuMv0A74nNI9NVn8zUIOAsYsr+NTb0HSP6tqdWUqJ2BtqaDK8JW9xNUvr4cg5MpvlbnOPlf9BHZl8PmaBFwuHrd7g1WGL3S6AZ37gn+PRpi81QgOAlPxUfHITFMYKB17ioUpD4hxc1PFVmua7RazoCkZ97Gzduwg1XYAz7OkWaoBXdMZQnFFyMsY9/LqX4EEDVmTe9X1mEKSuAV6yoxyMtBwKnjFQoZ6iU7Qg7//sC1TuScDEcaW/1MVqrrSZa8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4CElUPn28iYIvbpP32jZwx7fJ1f1O4O5cnT/1nta7z4=; b=DAj3pZTX53z355s5uSrFFQAogh86/DzUMVYZ2WylRukfgQ0cwH9fe9E3hllYbT/WMI/LSYS43i8i/BJA+QC8xmLFz4anuwlODTO1vf4BAwcHywoS9GYWgJwUPOUwOry8a3VoZQ/b2yNYFIfLn0OLAN+3cD3vj3sCZbVoJ57A64E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH for-4.17 v3 2/2] amd: remove VIRT_SC_MSR_HVM synthetic feature Date: Thu, 3 Nov 2022 18:02:44 +0100 Message-Id: <20221103170244.29270-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221103170244.29270-1-roger.pau@citrix.com> References: <20221103170244.29270-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0059.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::10) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB5312:EE_ X-MS-Office365-Filtering-Correlation-Id: cf2c677b-b2ce-4c4e-b771-08dabdbd4aba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P+ia/89gSe1BTIiPFvgjSgqkepReIuArpdYkCjtiCHY2Moc6fklxvpLYQWYmC4kTxJJGqmUlSEHEpmKIWwwnU1C4B5CgCX1TgOVJjc2gNp2lFpS36WF9rjV6LwqZY+CJ+0CSwk0OvIcn0+mRDfDWmEm9zgJ4jaAh/Nbh5zYk1FFQf51BTsW3/lfID9oVr7Atv7RmiOgQOwejwssviAW8pWGghtQJPLr8Oa7kiQOUkQNPuzV83IaA4hhidLFnxnlgY6eCaKnj5iGZtvtRAVQ1bhkM7fQoL20cADvGeb0/QFrg9D4GcjbjimUJrpun3cDae2NCwdGNJrTc1n+gG7RkIFqB6tZi/cMj4FmMnzFq0lK0c6UwsX+BFHMRDJ/Ydylx2/rhzzJz+Omasv9AZxEVK3VOZ41T4X1QUyF5iBuhH4nhDLEFR7torM18FiinYkfFR7ll0Tj9D4G/Zf/SXuTgGb1NBOWGgIciBkegktOXxCRNqjdwBHjBtKzxEp5Zc2PCpN6vEBDICfhxATS4Uwfxq9KJpYFsJT0YtzM9fpS+oFR+Wp54WrT4MBndd8PEMv/VddUg9Kih3K5WBCsEhEyB48ni447WUqeb4d3LHggQpk4/2AaQPe92lQGbFQ0gY5gQeHMvVWqT4KF3g5SHuTAPnnxhLn7pdBFCyo6dGd1uLKgAPPXdGATLPR/qeF+GCXMzJRMOnF/Nzh5fr4QtZhBOPQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(136003)(396003)(346002)(376002)(451199015)(36756003)(5660300002)(86362001)(4326008)(6916009)(82960400001)(38100700002)(316002)(54906003)(8676002)(186003)(1076003)(66946007)(8936002)(83380400001)(6512007)(2616005)(2906002)(478600001)(6666004)(41300700001)(6486002)(26005)(6506007)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDBmb1UwRnVXUWtpMUdwak4rdjVzS05lcnIwUXY2WEtyREhhYlRORVhodjhI?= =?utf-8?B?YU5tckwrekZ0Z0g0ZGlJV0dYa0ltQlpRUEdvTk8vdE5sL01HNWVkTWU5Znll?= =?utf-8?B?VVJKZlZSZmx3aXoxWFU4QkJydXFZbGdXL3BKcTV0MW84aFFpb2dHdVFyR1U3?= =?utf-8?B?TlE0b1VqbDMyQUd4WlppeDNDOHBJdENJWGlLT25xY1dFbjQxOW56Y0xERWJR?= =?utf-8?B?YndQNndUeFhsbXlUQmQyVXlXWk8rQ3ZYajkrUGw2QzJ4QjBoNHpPUTBzYVNm?= =?utf-8?B?UE55aEZJVUkzUXpmUXYyTUVnN2FSVFVuVUpwWVdrdEJsZGttd3BLMDZaWW1T?= =?utf-8?B?Q2RnZFptQUppVHRQK0pqT2JaMDFxTG12ZzBYTk5Uekt0bDdFR0t5TkJSRTZF?= =?utf-8?B?Mit3ZTdMUW0vZDlHaDJ4d0ZnNWR0cWwrQ2tWQ1ZJT2R2SUNhSDRCKzRCTSts?= =?utf-8?B?c2RZZ1BSQWpoZk03aHdhWVZMT3g0djRiYUQ2Y1gxbE9qWDhRamV0V0dwaFhS?= =?utf-8?B?Y1ZxRlp6VG1pN0YvVkNkTmtna1NpTU1zc0dQc0g4WW4xV1llUkMwVlZ4aVg0?= =?utf-8?B?b3FDbjNYYWd5OFFPeG14a0dKcGpxODNxR3hzSVZ1V0d1K2p1eTdSeEl6bDhZ?= =?utf-8?B?a1c5ci9sK3p4dWZTTHc2TkFlTDJEMHJuUzA1UEw1eE8xUXdHWlFpVTZPU1Nm?= =?utf-8?B?ZHJmaWJ2cFgySEV3bjlGa1h1MEZhTU1QTG15ZVZiNEhneXB0SmdhTlJJWTln?= =?utf-8?B?YWVHNjRpRUZZUEhyeFFsTmhkVENOeTZSbmdNSElDTDBubUFqM3JFSE5jV1pF?= =?utf-8?B?VHdOWlV5Z2J1eGZrTEpvbFRUbnpzYlB1ZVdXTWcyRm1NZmE3NHlPWlFLcS85?= =?utf-8?B?akxTVzlGK1pOM1dkZzZqZCtZYXZaSUsyUkZrS05aU3JWVDI1RFhvVkRhWkk1?= =?utf-8?B?ZTNVRmxhUDFYZUpRbUJMVEE1aEY1eElCMmNrSmxObFVhVm5lVnhCS2R3WXpY?= =?utf-8?B?b1FPbkVpN3JQZE9Dek9NSXpvZGt5cy9XOXRmalEwSmFUVkJNbm52cHIxSk5Q?= =?utf-8?B?aUE3VW9xNE0zZ2FhYkIwTlJMNnNVcmZBVERVQ1hhYXJhZ0hlRkNhOTFtTW1x?= =?utf-8?B?Qml4MTVrSFBpRFozUVdyZ2JJa2x3S292cmk5ck1aODkxbmhGdnFwMlNERnRa?= =?utf-8?B?SVU1RXRCVmFvdjRiU1A3aG96S05BUk9LNzF3RHpTWm52YU5UWVNYeEZRY2J3?= =?utf-8?B?U3ozZHhLaU51b3RhTWl2VFpVRUwzQnU1QTJhWUlOOGU3T1dOVGQxSGt4TEZr?= =?utf-8?B?M0Z2cFM5cnY2aEZXZTJrVHRrcm1MT0YzUGhHR1dMRUxCMnJMYUt3UlE2VHB4?= =?utf-8?B?VmRjdStZY01nd2NFYVRtZStXSUFZL2dTWlJJSDYyUExpY0J3VnoyZ0c4RDdB?= =?utf-8?B?eS9BKzhZdW1BOVQrNzY3UUIxYlprTDZiMENHWlF3MHFHbkdsTzlIbGI0eTZm?= =?utf-8?B?U0JRYzdVREdIdVprV3BoV3Q1dlNERUt5UlYxK3pKaTZJYWU1V1YvUzBCYjBm?= =?utf-8?B?djBHMnYrTFRyMnU0UUFmUFhrSGtDYjZScWVwemNjTVNEd0hVMk1WZU4xTTR4?= =?utf-8?B?eVk0YktCSFpmdVZVSzVrZ3kzKzFQVzhWQkZESEgwaHI2VlU1ZllGUEhLeDdm?= =?utf-8?B?ZzQrdGNxZUtkZmt4dnJWZ2pLeVRGRHRNUWhOSi9wbnZ3bU0wbzNxK3YxVHpy?= =?utf-8?B?dnNNQ1I1RlRidWVQa0JDZDJNQ2NGYjlEa0J6dmIxN0ZlVm43dE5rL1I0bEZr?= =?utf-8?B?MjBWYndkNDlmdEUvenh3M1VnbnNORTRPTGtFVTcvNENyR25OeFhna0pGdjVY?= =?utf-8?B?aXl4VEc0ODhYcWZRYWVseVQyTEp3Y0c4K0Z1YVJlcUpZWDhRRWJHTnpSMjBK?= =?utf-8?B?blc1bFF0ajYvVDhBMVNFM1FvbVVSZXRocUVJVk0zK1ZUTkZPY3NNbkppWDdC?= =?utf-8?B?SHVEY1ErRzltNm5WejM0a1JVdVlhREpSTnYzNDlycnFpbktHSzhqOWJRN2U3?= =?utf-8?B?Z2Y0cUROcnBZek1IWFkyUEsreDIzTU1BekFnZVdhTjFhNk1rcEcxLzZvNXFT?= =?utf-8?Q?KJC8cqL7Eykjm1YlozL/8wXqs?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf2c677b-b2ce-4c4e-b771-08dabdbd4aba X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 17:03:12.9846 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xnZGggXsFmLgyndIcr1WI7e/s11V3LGQ1Rv17B2+cy+AhPp+TYMSr/CINBUj6aW45HeKzRKZ9euLSi0V23RHVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5312 Since the VIRT_SPEC_CTRL.SSBD selection is no longer context switched on vm{entry,exit} there's no need to use a synthetic feature bit for it anymore. Remove the bit and instead use a global variable. No functional change intended. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Release-acked-by: Henry Wang --- xen/arch/x86/cpu/amd.c | 1 + xen/arch/x86/cpuid.c | 9 +++++---- xen/arch/x86/include/asm/amd.h | 1 + xen/arch/x86/include/asm/cpufeatures.h | 2 +- xen/arch/x86/spec_ctrl.c | 8 ++++---- 5 files changed, 12 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index 05d72c6501..11f8e1d359 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -49,6 +49,7 @@ boolean_param("allow_unsafe", opt_allow_unsafe); /* Signal whether the ACPI C1E quirk is required. */ bool __read_mostly amd_acpi_c1e_quirk; bool __ro_after_init amd_legacy_ssbd; +bool __ro_after_init amd_virt_spec_ctrl; static inline int rdmsr_amd_safe(unsigned int msr, unsigned int *lo, unsigned int *hi) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 822f9ace10..acc2f606ce 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -3,6 +3,7 @@ #include #include #include +#include #include #include #include @@ -543,9 +544,9 @@ static void __init calculate_hvm_max_policy(void) /* * VIRT_SSBD is exposed in the default policy as a result of - * VIRT_SC_MSR_HVM being set, it also needs exposing in the max policy. + * amd_virt_spec_ctrl being set, it also needs exposing in the max policy. */ - if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) + if ( amd_virt_spec_ctrl ) __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); /* @@ -606,9 +607,9 @@ static void __init calculate_hvm_def_policy(void) /* * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus - * VIRT_SC_MSR_HVM is set. + * amd_virt_spec_ctrl is set. */ - if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) + if ( amd_virt_spec_ctrl ) __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); sanitise_featureset(hvm_featureset); diff --git a/xen/arch/x86/include/asm/amd.h b/xen/arch/x86/include/asm/amd.h index 81ed71710f..5c100784dd 100644 --- a/xen/arch/x86/include/asm/amd.h +++ b/xen/arch/x86/include/asm/amd.h @@ -152,6 +152,7 @@ extern bool amd_acpi_c1e_quirk; void amd_check_disable_c1e(unsigned int port, u8 value); extern bool amd_legacy_ssbd; +extern bool amd_virt_spec_ctrl; bool amd_setup_legacy_ssbd(void); void amd_set_ssbd(bool enable); diff --git a/xen/arch/x86/include/asm/cpufeatures.h b/xen/arch/x86/include/asm/cpufeatures.h index 3895de4faf..efd3a667ef 100644 --- a/xen/arch/x86/include/asm/cpufeatures.h +++ b/xen/arch/x86/include/asm/cpufeatures.h @@ -24,7 +24,7 @@ XEN_CPUFEATURE(APERFMPERF, X86_SYNTH( 8)) /* APERFMPERF */ XEN_CPUFEATURE(MFENCE_RDTSC, X86_SYNTH( 9)) /* MFENCE synchronizes RDTSC */ XEN_CPUFEATURE(XEN_SMEP, X86_SYNTH(10)) /* SMEP gets used by Xen itself */ XEN_CPUFEATURE(XEN_SMAP, X86_SYNTH(11)) /* SMAP gets used by Xen itself */ -XEN_CPUFEATURE(VIRT_SC_MSR_HVM, X86_SYNTH(12)) /* MSR_VIRT_SPEC_CTRL exposed to HVM */ +/* Bit 12 unused. */ XEN_CPUFEATURE(IND_THUNK_LFENCE, X86_SYNTH(13)) /* Use IND_THUNK_LFENCE */ XEN_CPUFEATURE(IND_THUNK_JMP, X86_SYNTH(14)) /* Use IND_THUNK_JMP */ XEN_CPUFEATURE(SC_NO_BRANCH_HARDEN, X86_SYNTH(15)) /* (Disable) Conditional branch hardening */ diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index 4e53056624..0b94af6b86 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -514,12 +514,12 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps) (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) || boot_cpu_has(X86_FEATURE_SC_RSB_HVM) || boot_cpu_has(X86_FEATURE_IBPB_ENTRY_HVM) || - boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) || + amd_virt_spec_ctrl || opt_eager_fpu || opt_md_clear_hvm) ? "" : " None", boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ? " MSR_SPEC_CTRL" : "", (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) || - boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM)) ? " MSR_VIRT_SPEC_CTRL" - : "", + amd_virt_spec_ctrl) ? " MSR_VIRT_SPEC_CTRL" + : "", boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ? " RSB" : "", opt_eager_fpu ? " EAGER_FPU" : "", opt_md_clear_hvm ? " MD_CLEAR" : "", @@ -1247,7 +1247,7 @@ void __init init_speculation_mitigations(void) /* Support VIRT_SPEC_CTRL.SSBD if AMD_SSBD is not available. */ if ( opt_msr_sc_hvm && !cpu_has_amd_ssbd && (cpu_has_virt_ssbd || (amd_legacy_ssbd && amd_setup_legacy_ssbd())) ) - setup_force_cpu_cap(X86_FEATURE_VIRT_SC_MSR_HVM); + amd_virt_spec_ctrl = true; /* Figure out default_xen_spec_ctrl. */ if ( has_spec_ctrl && ibrs ) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 17:03:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 17:03:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436939.691200 (Exim 4.92) (envelope-from ) id 1oqdcl-0001Ag-5U; Thu, 03 Nov 2022 17:03:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436939.691200; Thu, 03 Nov 2022 17:03:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdcl-0001AZ-2h; Thu, 03 Nov 2022 17:03:27 +0000 Received: by outflank-mailman (input) for mailman id 436939; Thu, 03 Nov 2022 17:03:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdck-00019m-Dg for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 17:03:26 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6c6b910b-5b99-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 18:03:24 +0100 (CET) Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Nov 2022 13:03:10 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MN2PR03MB5312.namprd03.prod.outlook.com (2603:10b6:208:1e9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 17:03:07 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%5]) with mapi id 15.20.5769.021; Thu, 3 Nov 2022 17:03:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c6b910b-5b99-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667495004; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=Qtv7Cj22TjoQNgd8JyviLQaV2AH3o8KFjKIzwfUD6sU=; b=Pc/G3C09GUE5Itx0InR43597E0yS/2Pp153JnaQ2NjbGPqgHYMVD0XZb HVRdibriix/cTMmeITpFLRMN8TnbRcfWl/QvDYsVxUcqLLskW9K4owrk4 7tCd6VWcX2mOmIFth3LIxUm9vPjnCGvVwJSub42DXtkfTwUkyay5qW5jN w=; X-IronPort-RemoteIP: 104.47.55.176 X-IronPort-MID: 83721395 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:XrTu5K5VjjaZiGc7+ZXN7gxRtOPGchMFZxGqfqrLsTDasY5as4F+v jNLCG3TPfiOY2v8KY9xO463800HsMDdm4I1GQdv/y5hHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkT5weE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m7 +0eEhJUdw+5oOek5YuYYLhhmuE9M5y+VG8fkikIITDxK98DGMqGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooj+aF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efxnyhAdlDSdVU8NZIoW/NymUvOSdVREK9p//lrGKXRNJQf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpSNEgrt5wejUs2 XeAhdavDjtq2JWXQ3+A8rafrRupJDMYa2QFYEcsTxYB4tTliJE+iFTIVNkLOLWuktT/FDX0w jaLhCsznbMeiYgMzarT1U/DqyKhoN7OVAFd2+nMdmes7wc8boj1YYWtsALf9awZc9jfSUSdt n8ZncTY9PoJEZyGiC2KRqMKAa2t4PGGdjbbhDaDAqUcythkwFb7Fag43d20DB4B3hosEdMxX HLuhA== IronPort-HdrOrdr: A9a23:8KLP6aOvFT4YtcBcT1r155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBDpTnmAtj7fZq8z+8P3WB1B9uftWbdyQ+Vxe1ZjbcKhgeQYhEWldQtqp uIDZIOb+EYZGIS5aia3OD7KadZ/DDuytHVuQ609QYJcegFUdAC0+8vYTzrb3GeCTM2c6YRJd 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYoILSIly95FMzQjlPybAt/S zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+cwzqAVcBEYfmvrTo1qOag5BIDl8 TNmQ4pO4BJ53bYbgiO0G7Q8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMnJ 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvsX+9KK1wUh4S1bpXUd WHVKrnlbZrmBKhHjrkV1BUsZORti9ZJGbEfqAA0vbloQS+0koJjXfw//Zv7kvoxKhNNaWs2N 60Q5iA7Is+KPP+TZgNcNvpEvHHfVDlcFbrDF+4B2jBOeUuB0/twqSHk4ndotvaM6A18A== X-IronPort-AV: E=Sophos;i="5.96,134,1665460800"; d="scan'208";a="83721395" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YKR+D5q+wSrXQ/2MeJsnaC79F7hf5REi8lRrQxe0wSWHEYqabe61/kE/ycuGoRC8hpIorkiRuHR6hX0hIxXoWYgUcjLFYd31Akqb4W16oS/r+b85K9AKLwiPA/RWHK36MM6zs78HJDEnEly0MkgZkBi5QvC/Thn+J+bS1A8fGCDDvcSMi2eJVS5DEr8v/HvtTUCbkK2hleEE/zb0HZvUbmJlZVbsrFvoduz+HWirp/JAf1xKyjBwOoiklPAfZ1XIy8U+5zLmc+Hrv2MTzig/iNPrrYfN4ogsxcPudWdoe7GW7i+d6hphB+j+Uj1IdqkmyiA+Dyr6kMdgr9QL5Lg9Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N41NuLnpI1Kxzwq/zU/F9XdrxfEQCxO44x4XXoUhJ0M=; b=ZfeL4lIY62sm5RW+b02jWr2uqi4V+8PR7+MUzfddX2Kpm51ngghTopSGyoDjVCvLZPF/ZlIfOHe9Zk7thNTeWOWD+QxF+f2c637uDtpDufXinCkkKuYng2MQhQmViBzdKBkxBGC0w444B8IYaSfu6CWCBSqg1V58redUw3R3gUZEwNP0eRfhzb8w8sOCt6qVnEVDbtbC/IBDsVUcTkmHvB5ksO4aF5KfUUhP9XZCamzpharg2cnm84bq1G4ZHKbpM84Hc/iSZompI5svTB6cVYfMw1PGy6JSLyuCPwqWf2nxbmq9KB/5OfVZs0F2wK/xWzbJEDrKT4DI1hbIkSfAsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N41NuLnpI1Kxzwq/zU/F9XdrxfEQCxO44x4XXoUhJ0M=; b=wskhWr6i1QScDxcmSGHohvsdM+EhUHRiWHg6nbesI1pqDumg4jHUTEvJ21wCQ/4SBGLIcp7g9vi758+SRDdjz9Pnq698gcQPsY9I28GXdLB1RUbA5RDmUCy4h/MrobjIK60iBKfTyYUybTcbQesAr4iNSXd4DcpDYjZ7KY7+jTU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Roger Pau Monne , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH for-4.17 v3 1/2] amd/virt_ssbd: set SSBD at vCPU context switch Date: Thu, 3 Nov 2022 18:02:43 +0100 Message-Id: <20221103170244.29270-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221103170244.29270-1-roger.pau@citrix.com> References: <20221103170244.29270-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0517.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::20) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB5312:EE_ X-MS-Office365-Filtering-Correlation-Id: a44c8acd-98bb-4566-752c-08dabdbd476c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uL5FVBOVAnNlZy3DswuFDofwp8RamILugc5Kpt1dMhoEkYPDFJYXXXcNlsrOL8yFlJd9HopLOP6kfWfVO64AW8OWFvgwSdh/Uc3rImbHSGJG+M4PtGEUK59FeBkmnufmQhjv0kTTKXeWRnNHxUls3qbL+/gLqeUC+zqKKA1OSN2PGhPLukxp92YtTzCK85m4Jgaujlz0CN1iPHpAqvFyDeJyUN6oe4qWlmWTNgFPXreS32LSC8tKB2aZA4INhYDOoryCgK4pWISxNZeUjODXQMBp8OuRlGTSuq6hNM/qqn4S5RCJlCBnDa1pn6s48jmFMShR/Zztvx5Ve2GbGOvV5itsfp+L7mT6URqNA+iIWxAbfKrAFIaC+4XOkD4YAyGkqNchxzxNn5InYRtLURQXywdbd0c+BubZIiCbPcxIPjUB3rh3qjxuI+vOFfz1e+Jx8xodpsYha7CUA5d53cRnb5DoGrOrF1a1JcxaQ3DV+REcX5QaVQScMu4gytHyxIfvDe9i/agvbYX/c5IguhAgmSGW4YT2AH3tXNtiDAFbVODeNbFZS2TNGKq1aiL2UO7K+vZkx9/sqEMgG60/Yz7Daxhqpkj9Sj9pgj/tJKWa3DdGKRylq2YP3nT8eES92QDmfXZ8TddGV1FSWdkwcuVTgmu6QLeQpu5GC8TUGFiSpJnIA2xfy6lGDVeZNcrg+JKdmS9z0Pc466P+mghN6FT2zQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(136003)(396003)(346002)(376002)(451199015)(36756003)(5660300002)(86362001)(4326008)(6916009)(82960400001)(38100700002)(316002)(54906003)(8676002)(186003)(1076003)(66946007)(8936002)(83380400001)(6512007)(2616005)(2906002)(478600001)(6666004)(41300700001)(6486002)(26005)(6506007)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFRCckt2cW5ZWkJyQWpnRndLajhqWkNtNGZHNXdoMDNGUXpZV2xaaUNPMGow?= =?utf-8?B?cnlwUVdxR0IwSjhHdmUxQU5mK1F0TWh4azNRK0t2dEV0SlF4U3lwTGEyTmlQ?= =?utf-8?B?RFJLODJpbjBJREtSNlZGbUhiWm50VGRtQStuOS9JK3dZZS9XVEFKYVRKOVJB?= =?utf-8?B?Q2NkUHZ2MDNoTjdaanFia0pkdXAweWJGaWtjeGpVdzArV0FxQlVocWlPM3FH?= =?utf-8?B?NjRiMmpDUzNvek5sYTdlSFNxcUJkajhUV3FyNTNmdlovaVBmR3ZsT0ZTUW5B?= =?utf-8?B?Zmg5NjV0dmt4N0dnc1BCdWwzTXRYNUw5bG15dnhKM2FKbjZvU3pENDFhV1pn?= =?utf-8?B?ZVZsd3hLUitHSWZWcXh2eXZOZ1NvRWsraEhJTEkrbmJScnRBTGp1aytNWE83?= =?utf-8?B?YUJ1ZVB1TGM1Si9POEluN3UyL0p4V09hTFdFS2ViR0lVdGZXSzVIMnBka2lB?= =?utf-8?B?TnVoQm9mKzBVVjQxdXBXUzk2cW9QajExUGhQSmRDWURLTXNtZ0NJWHBsZDlR?= =?utf-8?B?aWJxU1RWU3luUDZGdWVDWDdvYjBXRFNHRFpKNTlNeDVlTDVVQVkwR1NXQTVs?= =?utf-8?B?S1E0ZzhZZm1ucnpmc0cyYk9IaTRXU3BGRkh2U1NKQ21oNUVkT1UrMmw5UTkr?= =?utf-8?B?ckFZZG9RdSswRGlWa2pESG1PUUZON0k2UGc0S0U3UVZPWGlEcDNseEd0SUdm?= =?utf-8?B?RndaYXk4TldFNksrczJuRUNpU1FqeVVtZlBEWjJDWmhMRmhuVFdNN2kwWHd1?= =?utf-8?B?UUJmN0ZkZmhkQlczZFphWXJTMWl5ZGY3d2s4ZE1iK0NJeU9XcUFMSGt3Q0Zn?= =?utf-8?B?dXJkK3g0S3Jvc3duRXNwUXMvSG91VWhwMDBBa0RSbnlBWkJmYnlqeDc2SjIv?= =?utf-8?B?WmFBZ1FWQVMrWEpncTlOUEgyQjMwSFJNblQxZVliNkFOdE4zV20vbTRVeEZa?= =?utf-8?B?Vzl1ZXhlS0dIZmRSSDBFenFobndRWnhpMXFqRnpNcnBiSFlraXpwWXZjWll3?= =?utf-8?B?TkVCU0lwcjNRVFpYSTFUb3lpR1hmamE4UEtaRlJ1dVNBUGJoaGhWa3lvNzJk?= =?utf-8?B?ZlNvQUY1RTFmTlllVXk2a1JsbU1vdXRITWw0emRqb1N0Qkl4Vng2NUxWZkE5?= =?utf-8?B?VXRDNVpwd0Z6eU5sZGNYc2dCdW16QlFCNUs5NHpZemtvUDQzMFZWSjltdFJw?= =?utf-8?B?K1NGUlNTcWdXZzNBa1FXL21YUEQ4Mzhqd1ZVYkJza08wdVF5d214S01STDNV?= =?utf-8?B?WjlrSW5tL1pkS2doV3MrVUJ3TmNSYlFEb1hMNFFtSmxQWml3VDdYL0hqbG1N?= =?utf-8?B?NjlQQndLTXFNTHViS1Nrblh3S2hjWDZ3ckhlNktQRUJSVDRodXM0UXM3NzJ2?= =?utf-8?B?aFFWZE9aY1liSWpqTkljRWk4TDA2TjREbUx2QWJRVWlXRUd6V1dsZUtKdzg3?= =?utf-8?B?eXZQNGtjRFZpcVNzK1NjTm8zbmI5eURPbDhCRHNzNmZoVGxRMjFwZkJvZHBN?= =?utf-8?B?ZWFOU21aMnhYbU1wYzEybWtzQU13VGtHS1hBckhVempXTlJybVhEVDBCbXZ5?= =?utf-8?B?SW40L21XS3pYbndUVjNjT3lJdFdIbk9Dd0xxM0syNUJMU0FTbjFCY2x1T0d2?= =?utf-8?B?WFJma3NWcDR5ZGJWRXl3SVFxUkVEdmhXTTRzbzR0Nm9pVHM3cVMwN3J4RzZB?= =?utf-8?B?ZXorb0MvTUFiSFZFMnZzMWxxd0Y3VjFzTHpKS3EwZ3Zkb0ZkZW5kRHN6WktL?= =?utf-8?B?ZXJuMUNNUWV3ZnZ2R3IwNTVHMlc1ZWhHS3pjRTBrMC9YdjBmcFVrTFhrTDR2?= =?utf-8?B?eHE0cFh5WXpTQXpTdVF5YWlXa2N0SWhuY1BRTjFtczAxOGJ5dFN1dHV6ZHlp?= =?utf-8?B?UTRmNUJTYVJFaFVKUFRaSFBLWDNzUWROOW9RMmhzVGVXRVA0UTJ3SlJoWmsv?= =?utf-8?B?bmxMMXNBbnJtVEZxWTdKTG85OTJKODF0M2diQUsrWS83TTc4OVhISkxySkxi?= =?utf-8?B?VUprT2JEVGdaOTFISzJHY1M4VS9qZzRlcFNPd0lYNWZYN3crek5wSVJlRFVj?= =?utf-8?B?enMyZWdSbU50cjAzU2pwVTNibGpEckpUaXNGSU5lRC9CcXlJeVpCdkZBNnlH?= =?utf-8?Q?MbKDZjFfVcscu5IFKchDtV1gM?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a44c8acd-98bb-4566-752c-08dabdbd476c X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 17:03:07.2979 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hL081M3TxKcbGwi1UZWwZO/iWCb8gS8eVmbnbPt70Np7Nizlmk+r8z95qBKG63/Xs+NjoSWIdUvC+uoFYn1P8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5312 The current logic for AMD SSBD context switches it on every vm{entry,exit} if the Xen and guest selections don't match. This is expensive when not using SPEC_CTRL, and hence should be avoided as much as possible. When SSBD is not being set from SPEC_CTRL on AMD don't context switch at vm{entry,exit} and instead only context switch SSBD when switching vCPUs. This has the side effect of running Xen code with the guest selection of SSBD, the documentation is updated to note this behavior. Also note that then when `ssbd` is selected on the command line guest SSBD selection will not have an effect, and the hypervisor will run with SSBD unconditionally enabled when not using SPEC_CTRL itself. This fixes an issue with running C code in a GIF=0 region, that's problematic when using UBSAN or other instrumentation techniques. As a result of no longer running the code to set SSBD in a GIF=0 region the locking of amd_set_legacy_ssbd() can be done using normal spinlocks, and some more checks can be added to assure it works as intended. Finally it's also worth noticing that since the guest SSBD selection is no longer set on vmentry the VIRT_SPEC_MSR handling needs to propagate the value to the hardware as part of handling the wrmsr. Signed-off-by: Roger Pau Monné --- Changes since v2: - Fix calling set_reg unconditionally. - Fix comment. - Call amd_set_ssbd() from guest_wrmsr(). Changes since v1: - Just check virt_spec_ctrl value != 0 on context switch. - Remove stray asm newline. - Use val in svm_set_reg(). - Fix style in amd.c. - Do not clear ssbd --- docs/misc/xen-command-line.pandoc | 10 +++--- xen/arch/x86/cpu/amd.c | 55 +++++++++++++++++-------------- xen/arch/x86/hvm/svm/entry.S | 6 ---- xen/arch/x86/hvm/svm/svm.c | 45 ++++++++++--------------- xen/arch/x86/include/asm/amd.h | 2 +- xen/arch/x86/msr.c | 9 +++++ 6 files changed, 63 insertions(+), 64 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 0fbdcb574f..424b12cfb2 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -2372,10 +2372,12 @@ By default, Xen will use STIBP when IBRS is in use (IBRS implies STIBP), and when hardware hints recommend using it as a blanket setting. On hardware supporting SSBD (Speculative Store Bypass Disable), the `ssbd=` -option can be used to force or prevent Xen using the feature itself. On AMD -hardware, this is a global option applied at boot, and not virtualised for -guest use. On Intel hardware, the feature is virtualised for guests, -independently of Xen's choice of setting. +option can be used to force or prevent Xen using the feature itself. The +feature is virtualised for guests, independently of Xen's choice of setting. +On AMD hardware, disabling Xen SSBD usage on the command line (`ssbd=0` which +is the default value) can lead to Xen running with the guest SSBD selection +depending on hardware support, on the same hardware setting `ssbd=1` will +result in SSBD always being enabled, regardless of guest choice. On hardware supporting PSFD (Predictive Store Forwarding Disable), the `psfd=` option can be used to force or prevent Xen using the feature itself. By diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index 98c52d0686..05d72c6501 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -742,7 +742,7 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c) } static struct ssbd_ls_cfg { - bool locked; + spinlock_t lock; unsigned int count; } __cacheline_aligned *ssbd_ls_cfg; static unsigned int __ro_after_init ssbd_max_cores; @@ -753,7 +753,7 @@ bool __init amd_setup_legacy_ssbd(void) unsigned int i; if ((boot_cpu_data.x86 != 0x17 && boot_cpu_data.x86 != 0x18) || - boot_cpu_data.x86_num_siblings <= 1) + boot_cpu_data.x86_num_siblings <= 1 || opt_ssbd) return true; /* @@ -776,46 +776,51 @@ bool __init amd_setup_legacy_ssbd(void) if (!ssbd_ls_cfg) return false; - if (opt_ssbd) - for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++) - /* Set initial state, applies to any (hotplug) CPU. */ - ssbd_ls_cfg[i].count = boot_cpu_data.x86_num_siblings; + for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++) + spin_lock_init(&ssbd_ls_cfg[i].lock); return true; } -/* - * Executed from GIF==0 context: avoid using BUG/ASSERT or other functionality - * that relies on exceptions as those are not expected to run in GIF==0 - * context. - */ -void amd_set_legacy_ssbd(bool enable) +static void core_set_legacy_ssbd(bool enable) { const struct cpuinfo_x86 *c = ¤t_cpu_data; struct ssbd_ls_cfg *status; + unsigned long flags; if ((c->x86 != 0x17 && c->x86 != 0x18) || c->x86_num_siblings <= 1) { - set_legacy_ssbd(c, enable); + BUG_ON(!set_legacy_ssbd(c, enable)); return; } + BUG_ON(c->phys_proc_id >= AMD_FAM17H_MAX_SOCKETS); + BUG_ON(c->cpu_core_id >= ssbd_max_cores); status = &ssbd_ls_cfg[c->phys_proc_id * ssbd_max_cores + c->cpu_core_id]; - /* - * Open code a very simple spinlock: this function is used with GIF==0 - * and different IF values, so would trigger the checklock detector. - * Instead of trying to workaround the detector, use a very simple lock - * implementation: it's better to reduce the amount of code executed - * with GIF==0. - */ - while (test_and_set_bool(status->locked)) - cpu_relax(); + spin_lock_irqsave(&status->lock, flags); status->count += enable ? 1 : -1; + ASSERT(status->count <= c->x86_num_siblings); if (enable ? status->count == 1 : !status->count) - set_legacy_ssbd(c, enable); - barrier(); - write_atomic(&status->locked, false); + BUG_ON(!set_legacy_ssbd(c, enable)); + spin_unlock_irqrestore(&status->lock, flags); +} + +void amd_set_ssbd(bool enable) +{ + if (opt_ssbd) + /* + * Ignore attempts to turn off SSBD, it's hardcoded on the + * command line. + */ + return; + + if (cpu_has_virt_ssbd) + wrmsr(MSR_VIRT_SPEC_CTRL, enable ? SPEC_CTRL_SSBD : 0, 0); + else if (amd_legacy_ssbd) + core_set_legacy_ssbd(enable); + else + ASSERT_UNREACHABLE(); } /* diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S index a26589aa9a..981cd82e7c 100644 --- a/xen/arch/x86/hvm/svm/entry.S +++ b/xen/arch/x86/hvm/svm/entry.S @@ -59,9 +59,6 @@ __UNLIKELY_END(nsvm_hap) clgi - ALTERNATIVE "", STR(call vmentry_virt_spec_ctrl), \ - X86_FEATURE_VIRT_SC_MSR_HVM - /* WARNING! `ret`, `call *`, `jmp *` not safe beyond this point. */ /* SPEC_CTRL_EXIT_TO_SVM Req: b=curr %rsp=regs/cpuinfo, Clob: acd */ .macro svm_vmentry_spec_ctrl @@ -131,9 +128,6 @@ __UNLIKELY_END(nsvm_hap) ALTERNATIVE "", svm_vmexit_spec_ctrl, X86_FEATURE_SC_MSR_HVM /* WARNING! `ret`, `call *`, `jmp *` not safe before this point. */ - ALTERNATIVE "", STR(call vmexit_virt_spec_ctrl), \ - X86_FEATURE_VIRT_SC_MSR_HVM - /* * STGI is executed unconditionally, and is sufficiently serialising * to safely resolve any Spectre-v1 concerns in the above logic. diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 1aeaabcb13..8b101d4f27 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -973,6 +973,16 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v) /* Resume use of ISTs now that the host TR is reinstated. */ enable_each_ist(idt_tables[cpu]); + + /* + * Clear previous guest selection of SSBD if set. Note that SPEC_CTRL.SSBD + * is already cleared by svm_vmexit_spec_ctrl. + */ + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) + { + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); + amd_set_ssbd(false); + } } static void cf_check svm_ctxt_switch_to(struct vcpu *v) @@ -1000,6 +1010,13 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v) if ( cpu_has_msr_tsc_aux ) wrmsr_tsc_aux(v->arch.msrs->tsc_aux); + + /* Load SSBD if set by the guest. */ + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) + { + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); + amd_set_ssbd(true); + } } static void noreturn cf_check svm_do_resume(void) @@ -3116,34 +3133,6 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) vmcb_set_vintr(vmcb, intr); } -/* Called with GIF=0. */ -void vmexit_virt_spec_ctrl(void) -{ - unsigned int val = opt_ssbd ? SPEC_CTRL_SSBD : 0; - - if ( val == current->arch.msrs->virt_spec_ctrl.raw ) - return; - - if ( cpu_has_virt_ssbd ) - wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); - else - amd_set_legacy_ssbd(val); -} - -/* Called with GIF=0. */ -void vmentry_virt_spec_ctrl(void) -{ - unsigned int val = current->arch.msrs->virt_spec_ctrl.raw; - - if ( val == (opt_ssbd ? SPEC_CTRL_SSBD : 0) ) - return; - - if ( cpu_has_virt_ssbd ) - wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); - else - amd_set_legacy_ssbd(val); -} - /* * Local variables: * mode: C diff --git a/xen/arch/x86/include/asm/amd.h b/xen/arch/x86/include/asm/amd.h index 6a42f68542..81ed71710f 100644 --- a/xen/arch/x86/include/asm/amd.h +++ b/xen/arch/x86/include/asm/amd.h @@ -153,6 +153,6 @@ void amd_check_disable_c1e(unsigned int port, u8 value); extern bool amd_legacy_ssbd; bool amd_setup_legacy_ssbd(void); -void amd_set_legacy_ssbd(bool enable); +void amd_set_ssbd(bool enable); #endif /* __AMD_H__ */ diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 95416995a5..5609b71e99 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -24,6 +24,7 @@ #include #include +#include #include #include #include @@ -697,7 +698,15 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD; } else + { msrs->virt_spec_ctrl.raw = val & SPEC_CTRL_SSBD; + if ( v == curr ) + /* + * Propagate the value to hardware, as it won't be set on guest + * resume path. + */ + amd_set_ssbd(val & SPEC_CTRL_SSBD); + } break; case MSR_AMD64_DE_CFG: -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 17:06:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 17:06:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436952.691210 (Exim 4.92) (envelope-from ) id 1oqdfl-0002uY-NB; Thu, 03 Nov 2022 17:06:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436952.691210; Thu, 03 Nov 2022 17:06:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdfl-0002uR-KH; Thu, 03 Nov 2022 17:06:33 +0000 Received: by outflank-mailman (input) for mailman id 436952; Thu, 03 Nov 2022 17:06:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdfk-0002uF-Pl for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 17:06:32 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2075.outbound.protection.outlook.com [40.107.20.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dcd99239-5b99-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 18:06:31 +0100 (CET) Received: from AS9PR06CA0483.eurprd06.prod.outlook.com (2603:10a6:20b:49b::8) by DBAPR08MB5573.eurprd08.prod.outlook.com (2603:10a6:10:1a2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 17:06:28 +0000 Received: from AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49b:cafe::e9) by AS9PR06CA0483.outlook.office365.com (2603:10a6:20b:49b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Thu, 3 Nov 2022 17:06:28 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT030.mail.protection.outlook.com (100.127.140.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 17:06:27 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Thu, 03 Nov 2022 17:06:27 +0000 Received: from 94954ca5c007.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FD6C8E56-278F-4A95-9830-D38EEB7BC147.1; Thu, 03 Nov 2022 17:06:21 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 94954ca5c007.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Nov 2022 17:06:21 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB4PR08MB8006.eurprd08.prod.outlook.com (2603:10a6:10:38e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Thu, 3 Nov 2022 17:06:19 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Thu, 3 Nov 2022 17:06:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dcd99239-5b99-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ER6Ov0XGtPvYVOVz1m8flvuystqaPNNV0/gG1VJduZmlr1h7GJuO4Pgzo5FA+KWvd2+HvYkJLZqFm2efV/6awBlG7UbE4QVqAwLChe5oaJ92DKDorDAQr+DozB5B5DyMmrYXHvzm8d3G+/cW/Ki6qjggaP1+vT1J0RjqDhaKdaAQvc8BLhyERSYbCKi52DEc6MV7PFZ4l13Mvq5yd/81p1wpCfK2+oQyqiV6MJCZxqt3JVM+P0ceMUY09SOnRWLzyNgrQ2miM6Vxv5ym2Q7yVSrGXzHGeOoTzm8uVs+BGVn/ZDFe39w/F90+fNUpvOjKx3BwYMrtp0ZB+qwWx+dxHA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=09TC2OjTAstvwX+aOcOTzRe5uVb8e6TNwkmQHhTATSo=; b=IId4kwDYsAgmjwgOUZyv/ye3pRSfzQY/gCnE0pDDxUj+U/XW/EeE8+sM8gJ3cdX339Bf2mRQSnUxdhMGJJ6ngmBqLrX4mD/a1Pg56FjS1x/lPH3pSA4RV1CRVo82WBra6YSibYYxztuE9clp/96xot7POl0rSCFXw5DD5Ptl9XpD4c2nQ7StFqZg1ZkmbXiKztxdA5RGYOuWbjudetxoMcAE1r4bfMJ7HTeD4jPph5aPzdvWYufYH+x+zMOcm1e9Vgk12r+LQP1OWgvymQkvB//Vvi6WnYTKX4rQd00sJh6iXTVTuXxTN/U+RZIycNHd/Plg+KMJWbVfIBTCaZxYeQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=09TC2OjTAstvwX+aOcOTzRe5uVb8e6TNwkmQHhTATSo=; b=AYVt5mG8f2Pe5yDfxso2kcNNN1SNE1KdpeX4MG7hmO2imcP0F0LcH0SKN+lTiwYJ8zETNEm772Yvel9adOD4I0MlGteGyuE+oK2W+FD5yCDVM7gdDlHWWy2zZYaHY8CShWjf6hFAHWm/d8Y9sm+hUgpqELboEYG9rVB64HHsK2o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VJNgC3XYTeXFjHz1EHxrRgH7Syv/ngFoKues6+V6L1Zna+4VASOZrLapIeKO3i7EXy6thZ2UbjRHYxe58IKdAh1Al6gVyfQFQvLWpt8AH+ZSXXzR5PEI0YX9Wl0SyB8skosUAYB5S9Dlw1K/sBkxBpLrfU2iIzj7Qm5chpK4zY26E5BSwuHSLX0ejTd/BxtNzcqyPhRSRE0uW2mWfBxi3/DtpiZH9CKrYEUwxnv+BVYhasktbgsisCZw53ZOwIDJRFwrr/xXg7pJ5nKCJQydx20fWGaXoP9fYPBrWPN+C1led6RbuRsES6o7eYnPtkxlfms2QhCxmIhcx3fXt+XvdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=09TC2OjTAstvwX+aOcOTzRe5uVb8e6TNwkmQHhTATSo=; b=lOxaB0qY0hNS/aJpdShkzoPpDOJ5bJ9w0oBxKyTNgImT860ujZL5msSL8iQsPduyYLH9TmHxzQ9CLde4dAzSLpJ9U701tszrLQTg65Q7AwExJjtUXcSLGV6EzRLXjvCLZ/iLDcGbzO1Gl9wFmu3au2GwxaJ4fiqo2PH8Ceqn0GZqioAvywiBcyJrVWm0o8ULrZ/ldswFyTxKB1ZRe59Ijo2TLS0N6UnilXOOCsWSh0EQK1ErUIST2OplC0wja0VfNqYd9P4ZcXbgzRK/oEu2kI7bavWIuheHnIFmfCbWOuQwWmaNcxwqh939d6Z2PBTYOMrPR2FXNeurUzAx0xrsXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=09TC2OjTAstvwX+aOcOTzRe5uVb8e6TNwkmQHhTATSo=; b=AYVt5mG8f2Pe5yDfxso2kcNNN1SNE1KdpeX4MG7hmO2imcP0F0LcH0SKN+lTiwYJ8zETNEm772Yvel9adOD4I0MlGteGyuE+oK2W+FD5yCDVM7gdDlHWWy2zZYaHY8CShWjf6hFAHWm/d8Y9sm+hUgpqELboEYG9rVB64HHsK2o= From: Henry Wang To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: RE: [PATCH for-4.17 v3 1/2] amd/virt_ssbd: set SSBD at vCPU context switch Thread-Topic: [PATCH for-4.17 v3 1/2] amd/virt_ssbd: set SSBD at vCPU context switch Thread-Index: AQHY76ZET1O4McAMZk+SDG8R2oR8564tbbLA Date: Thu, 3 Nov 2022 17:06:19 +0000 Message-ID: References: <20221103170244.29270-1-roger.pau@citrix.com> <20221103170244.29270-2-roger.pau@citrix.com> In-Reply-To: <20221103170244.29270-2-roger.pau@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4743EF7AEBDAC84A850A8BD367F8EF87.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB4PR08MB8006:EE_|AM7EUR03FT030:EE_|DBAPR08MB5573:EE_ X-MS-Office365-Filtering-Correlation-Id: ab53b349-76f7-4b38-5be0-08dabdbdbf1f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hcKx2ZK5if9UW/ntBBSW12rAg96svISIbgi06Twn1Dsqje/hkx1nFrOtPpV+fyYQBmd+/esLfx+rwOepdKIT0A7/nDmQCngEptpSJiZw+0hc9w7BR2n4gl2nx7I/ngHZ5PCW2HonZt/YMV5QrYGbAIPr/HmXMGsZZibDkSmdtUP26MeGszm3q/K+dzjNFIoI1prVYiZnXCyoZwhrdT5pdjsNdMpHfuhm8GEVpjsU0iHm2HM/zV8nmwW66onqOwHqIBAePhhChjNiukzHzEBA1aiKmLoVbcnyEaQvKb+BeUfTtkbzhWvHZ/NYJaopF3sxXNAGIEv++bcy+S9gGTfJ6XDPC+NFbmDVr8q/eZKEuuTUVnJwqSVvZgY7NmCbdt69tcD4mC4IUKz/YNhjBXlUAVWuzmei/CuHgPOMER5/pJHGOaOVLPVO3a9/aI0GoljY924JlNAolrCHh++W/FKa2QrVzbZ3uUgMHWojS50uABSDePS0RfX+M7F4PN5TtGjjbGtZrvYYCrnk0lE/VML52qYBYR4H+ZD+aaA2YRiZeRAsO5ZSB01xPkk9s4+0uESuvhcaJ4OBAa3LpyJfmvYJe12SyjfDDu8YzLhZumNf2iviJVFmdXqEg3TpyWnXR4BwkqN7JHjgrGhPPorPW6OlUqcExfWGdvCrhr59rUaqDFEiCwUWbCs3reQETfD+fhZwcurG4fmmInF5tXR4fcgztyqVSm6V7bIruM12s8jG2dk9Mh648qAOBRqagxyI6UpB+8ceG8OdqlRCCZbMmtCsyQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199015)(55016003)(5660300002)(38070700005)(122000001)(83380400001)(2906002)(9686003)(33656002)(86362001)(52536014)(7696005)(26005)(54906003)(478600001)(316002)(71200400001)(64756008)(41300700001)(38100700002)(8676002)(66946007)(8936002)(110136005)(66446008)(66556008)(76116006)(66476007)(4326008)(6506007)(186003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8006 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ba299566-2e8a-4241-7b46-08dabdbdba2a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R/l21/Gyl1GvheNcXELGrgAJhNAz+1kMcXd3OQr1R4mDcnhvBcPsleXiBBoqx6LJipclZ6amsQ2CVQnEOuUAaH8x4kiMvOapFyeCq9v/6hEXZ7+L+RaDa8CY3w14x4/lp2mYlMlFdEGpOZgS5CdRVExgRXtrhdqDt+D6NwMUHT2cIEV20VK8sBlRyRW5VVK7pxLczdWpd+utWy7c3HIbsVCJo/ehfwmD+rWCNtkzMKwzj/FtedVj+W8iHe+vQq3noTbD9BHk3K+wR9pyUh7BeiBM4Lx5itLuINUFXtxtK9+fgQ0Fmscnp87dOqu+jgcg6VO7tb6mlfbT2gNElcJcrKorOgODKmM4K20XwtC4x4jKOqu2lI40KbVD3U6gzacbykoiHFLSLnuYiWnfG489A+XAF4WVgsn116+5h7R8UfMW7mgHmDEPiWShjLB7TNS6ELLIl0iuTZT28CZ2lEKK+cb1CwqV6qDvA8NGS3yUVHCDs/0ukaeDciUZ0J2Bvuy09D8KM3jYfTyLWS3mK+hJ1GZDdY2HQ8UfVdqxZ4dGZ8Zuxv4Vyqq8OViupGjrJVvbYck0cfOmoGIdLApyRfyVCEueiA7oH+7KwE7iR/+HV5bxSiXRKAbrjXwqrYe/ynvtceWDM5UbzXT/ikH/6Vueoc3lA0JBvFypyskSfOO8XLgammaFePgQpE/EqpM8BqQ2T35lCfKDr3Fmwthl1dPdplQgLgUrz3NZd+bwoYdQ/8ekS8d1vrCjauoqVwtDQ9/lN7+xZUAJ6uwiwRI3A7KIpg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(376002)(136003)(451199015)(36840700001)(40470700004)(46966006)(6506007)(7696005)(336012)(41300700001)(8936002)(52536014)(2906002)(26005)(9686003)(4326008)(356005)(70586007)(316002)(8676002)(82740400003)(33656002)(70206006)(5660300002)(36860700001)(82310400005)(55016003)(40460700003)(478600001)(83380400001)(186003)(40480700001)(81166007)(110136005)(86362001)(54906003)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 17:06:27.8693 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ab53b349-76f7-4b38-5be0-08dabdbdbf1f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5573 SGkgUm9nZXIsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUm9nZXIg UGF1IE1vbm5lIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogW1BBVENIIGZvci00 LjE3IHYzIDEvMl0gYW1kL3ZpcnRfc3NiZDogc2V0IFNTQkQgYXQgdkNQVSBjb250ZXh0DQo+IHN3 aXRjaA0KPiANCj4gVGhlIGN1cnJlbnQgbG9naWMgZm9yIEFNRCBTU0JEIGNvbnRleHQgc3dpdGNo ZXMgaXQgb24gZXZlcnkNCj4gdm17ZW50cnksZXhpdH0gaWYgdGhlIFhlbiBhbmQgZ3Vlc3Qgc2Vs ZWN0aW9ucyBkb24ndCBtYXRjaC4gIFRoaXMgaXMNCj4gZXhwZW5zaXZlIHdoZW4gbm90IHVzaW5n IFNQRUNfQ1RSTCwgYW5kIGhlbmNlIHNob3VsZCBiZSBhdm9pZGVkIGFzDQo+IG11Y2ggYXMgcG9z c2libGUuDQo+IA0KPiBXaGVuIFNTQkQgaXMgbm90IGJlaW5nIHNldCBmcm9tIFNQRUNfQ1RSTCBv biBBTUQgZG9uJ3QgY29udGV4dCBzd2l0Y2gNCj4gYXQgdm17ZW50cnksZXhpdH0gYW5kIGluc3Rl YWQgb25seSBjb250ZXh0IHN3aXRjaCBTU0JEIHdoZW4gc3dpdGNoaW5nDQo+IHZDUFVzLiAgVGhp cyBoYXMgdGhlIHNpZGUgZWZmZWN0IG9mIHJ1bm5pbmcgWGVuIGNvZGUgd2l0aCB0aGUgZ3Vlc3QN Cj4gc2VsZWN0aW9uIG9mIFNTQkQsIHRoZSBkb2N1bWVudGF0aW9uIGlzIHVwZGF0ZWQgdG8gbm90 ZSB0aGlzIGJlaGF2aW9yLg0KPiBBbHNvIG5vdGUgdGhhdCB0aGVuIHdoZW4gYHNzYmRgIGlzIHNl bGVjdGVkIG9uIHRoZSBjb21tYW5kIGxpbmUgZ3Vlc3QNCj4gU1NCRCBzZWxlY3Rpb24gd2lsbCBu b3QgaGF2ZSBhbiBlZmZlY3QsIGFuZCB0aGUgaHlwZXJ2aXNvciB3aWxsIHJ1bg0KPiB3aXRoIFNT QkQgdW5jb25kaXRpb25hbGx5IGVuYWJsZWQgd2hlbiBub3QgdXNpbmcgU1BFQ19DVFJMIGl0c2Vs Zi4NCj4gDQo+IFRoaXMgZml4ZXMgYW4gaXNzdWUgd2l0aCBydW5uaW5nIEMgY29kZSBpbiBhIEdJ Rj0wIHJlZ2lvbiwgdGhhdCdzDQo+IHByb2JsZW1hdGljIHdoZW4gdXNpbmcgVUJTQU4gb3Igb3Ro ZXIgaW5zdHJ1bWVudGF0aW9uIHRlY2huaXF1ZXMuDQo+IA0KPiBBcyBhIHJlc3VsdCBvZiBubyBs b25nZXIgcnVubmluZyB0aGUgY29kZSB0byBzZXQgU1NCRCBpbiBhIEdJRj0wDQo+IHJlZ2lvbiB0 aGUgbG9ja2luZyBvZiBhbWRfc2V0X2xlZ2FjeV9zc2JkKCkgY2FuIGJlIGRvbmUgdXNpbmcgbm9y bWFsDQo+IHNwaW5sb2NrcywgYW5kIHNvbWUgbW9yZSBjaGVja3MgY2FuIGJlIGFkZGVkIHRvIGFz c3VyZSBpdCB3b3JrcyBhcw0KPiBpbnRlbmRlZC4NCj4gDQo+IEZpbmFsbHkgaXQncyBhbHNvIHdv cnRoIG5vdGljaW5nIHRoYXQgc2luY2UgdGhlIGd1ZXN0IFNTQkQgc2VsZWN0aW9uDQo+IGlzIG5v IGxvbmdlciBzZXQgb24gdm1lbnRyeSB0aGUgVklSVF9TUEVDX01TUiBoYW5kbGluZyBuZWVkcyB0 bw0KPiBwcm9wYWdhdGUgdGhlIHZhbHVlIHRvIHRoZSBoYXJkd2FyZSBhcyBwYXJ0IG9mIGhhbmRs aW5nIHRoZSB3cm1zci4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJv Z2VyLnBhdUBjaXRyaXguY29tPg0KDQpUaGFua3MgZm9yIHJlc3Bpbm5pbmcgdGhlIHBhdGNoIQ0K DQpSZWxlYXNlLWFja2VkLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQoNCktp bmQgcmVnYXJkcywNCkhlbnJ5DQo= From xen-devel-bounces@lists.xenproject.org Thu Nov 03 17:13:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 17:13:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436961.691221 (Exim 4.92) (envelope-from ) id 1oqdmJ-0004QK-Go; Thu, 03 Nov 2022 17:13:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436961.691221; Thu, 03 Nov 2022 17:13:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdmJ-0004QD-EB; Thu, 03 Nov 2022 17:13:19 +0000 Received: by outflank-mailman (input) for mailman id 436961; Thu, 03 Nov 2022 17:13:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdmH-0004Q7-Sh for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 17:13:18 +0000 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c824da70-5b9a-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 18:13:08 +0100 (CET) Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2022 10:12:56 -0700 Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 03 Nov 2022 10:12:50 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oqdlm-006wiw-0o; Thu, 03 Nov 2022 19:12:46 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c824da70-5b9a-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667495594; x=1699031594; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7YpyRAArYVbF9WNy66xCFId6MSUjEg0Z+IBgztnk6pE=; b=jq5nzAvpIgGZZdrtliRRJKRfoZhhV/TY4FJPDv+HyTrfZbZCb4ZatUBd dn61FPyRCOAEuJ+OALQ/SOlP5PVk3/pJPzfIWkQuGNFFpS62yb+UMkGSY 8O34bJ/dCYQvnqs1lKsrQqSrys3v2/Cc9lDRVNtgYuHZoeZekwbTIwv/c lbNlhQmTzXavpF3NKefF4XkilpCW4A5nUFxt+29DQqIBdGTbRzbZwkOyj C/YTVq1/WfXTrOOWFbqc7JT00OEtHuiZsma4NXavAghA/jl/SRRYV2uzG nrAQCQMekuQ0zER6a43+iHChxhdLPmaCnWVAYaSH5HZ5pdzsdjuzUfBCL g==; X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="308462883" X-IronPort-AV: E=Sophos;i="5.96,134,1665471600"; d="scan'208";a="308462883" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="666046647" X-IronPort-AV: E=Sophos;i="5.96,134,1665471600"; d="scan'208";a="666046647" Date: Thu, 3 Nov 2022 19:12:45 +0200 From: Andy Shevchenko To: Dominik Brodowski Cc: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mika Westerberg , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Juergen Gross , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v2 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p() Message-ID: References: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> <20221103164644.70554-5-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Nov 03, 2022 at 06:03:24PM +0100, Dominik Brodowski wrote: > Am Thu, Nov 03, 2022 at 06:46:44PM +0200 schrieb Andy Shevchenko: ... > > - > > - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) { > > - res = s->cb_dev->bus->resource[i]; > > -#else > > - pci_bus_for_each_resource(s->cb_dev->bus, res, i) { > > #endif > > + > > + pci_bus_for_each_resource_p(s->cb_dev->bus, res) { > > if (!res) > > continue; > > Doesn't this remove the proper iterator for X86? Even if that is the right > thing to do, it needs an explict explanation. I dunno what was in 2010, but reading code now I have found no differences in the logic on how resources are being iterated in these two pieces of code. But fine, I will add a line to a commit message about this change. Considering this is done, can you issue your conditional tag so I will incorporate it in v3? -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Thu Nov 03 17:43:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 17:43:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436968.691232 (Exim 4.92) (envelope-from ) id 1oqeFg-0000zi-Vo; Thu, 03 Nov 2022 17:43:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436968.691232; Thu, 03 Nov 2022 17:43:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqeFg-0000zb-T0; Thu, 03 Nov 2022 17:43:40 +0000 Received: by outflank-mailman (input) for mailman id 436968; Thu, 03 Nov 2022 17:43:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqeFe-0000zV-Mh for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 17:43:38 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70088.outbound.protection.outlook.com [40.107.7.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0ad26626-5b9f-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 18:43:36 +0100 (CET) Received: from ZR0P278CA0108.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::23) by PAXPR08MB7598.eurprd08.prod.outlook.com (2603:10a6:102:23d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Thu, 3 Nov 2022 17:43:33 +0000 Received: from VI1EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:910:23:cafe::76) by ZR0P278CA0108.outlook.office365.com (2603:10a6:910:23::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.22 via Frontend Transport; Thu, 3 Nov 2022 17:43:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT027.mail.protection.outlook.com (100.127.144.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 17:43:32 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Thu, 03 Nov 2022 17:43:32 +0000 Received: from d39feeff38a7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C6AB13A9-DB60-4A30-9278-071F1655F115.1; Thu, 03 Nov 2022 17:43:24 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d39feeff38a7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Nov 2022 17:43:24 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAXPR08MB6464.eurprd08.prod.outlook.com (2603:10a6:102:df::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 17:43:22 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 17:43:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ad26626-5b9f-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aHSeUQkvjlwbleCnfwSjocmh6vObfAfCEcvWwzCAeW+BEifUGux0UfGDAp97EVG52fGRsU/iXX25MKOoIgz5Qy9WacGhWWBXRONLYJR6OO6JHFslgmAy5DfI6soIciSpHZb7nyGqyZ2LVxWb/hMg4/qQX7UWPxsN+gwvGgqKv0m/dXa+l4jAfVIuIq6W7OUFEeTrDWuhhwJTPFc/PAx+g7ahviAvH7JBnv/k9Mb9dnYV7rRAcCaVdE3QAWwd4ASkoz/hIb82kcziNzTy1a/uC7PPtocBiXgBC3d6X9fJwG1gNn6JjrS0NM7TPWw8clt8FFZbK071vlO/S/+dUaG5SQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UjxrKjPFZQds5WVF8IDxnIaxCFmmFKKiaeKQ8ufQvIE=; b=G9eJ1XMrvoORkc0qqMYKFumsIXKEbUxOGodd/2kqV3F11eMNW9oZat/d2UZl75xaCKaLMi5UqUbAk5H3gfaD8YNVts9bQZdwXr7MZQazOeKZXl78l36ppwyLbtS8EQtWdw/jevZWMGJcymISxyrJeYinghN7qPTIIwhpU//guOZv+ooDbridyCUQZf3hTPumTtGPWYdPOqUkGkoWTJIiGeMRmiuWtXC2k7t6VKTxHzMSU76MYONI5faZvDdGyVVmsBSj2TteWtxfKkbVYwPZZfmcfh6E06e2L74AtwPe9vyqsDeRlyIEODTeG8G4q/Z2LoJy30ST3CKw93U89nZk1g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UjxrKjPFZQds5WVF8IDxnIaxCFmmFKKiaeKQ8ufQvIE=; b=EM7trJgth00TgcOjVIw4Q9QbNRhgP6mPEKsdz0y/gWrpNP+MkPWd/bSqGwUNi75gAHpKGMwb2Mye31BWTtoQOLCUHnSv6EbGqcjFuipeMAnA/u7gPT4gJjfCnesBZlc942t7ENxc1lpf0n6wstHQfQJsm2x90h/EGbD8cmO+laE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 702141cb395c1d91 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lSOACYdvrbOytmGBGYCPmmHS7ojooEy8bAgR8dmsIg7t0quAYxddvp9p9JkWN3zHSkCJWSzivNDAyvpoKmGK1FlulKcumLlY5K37Zm0wsNzvzRDb7jCtKbMVV96joQrlzYmiDqI8Gg2hLUI5cr3e6zNhitz1p03Sk0UBosGoRidSsZbR0yQByV1lzmFVibd+bIZU0WnEz91mtA/paDgPyFNxlr6VxrV8+JwbmbVUZ0vp1JFRg1H7mnXJFFstdolJXf6/mtK3qlh8yQq+E9z7FyPd4g4FRBB7kLq/8edbghD1ozE3/1lJXhpIh4ErvZtvi+bVG6PZy636AVFMWjFRjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UjxrKjPFZQds5WVF8IDxnIaxCFmmFKKiaeKQ8ufQvIE=; b=JDkz1Fu3DalGpL5lPBAGMALwweUI9TVMHW4+4KEY6JOgf8t5M+w+rtcYQ0yT3JnvzXpYl7EwRBtiordNTb3lZup6/nbmiMPi4BDu6NKnEHhtqyC42vWyCOPR6E/J6fG6whXEtHVBNrXTtQzz9OHuqUyloh7R7ZUEc2zR2QcB/zioq+pSmtuuSNn4Q0c6jS7ytiPNYpBmNNzmEkbM3Di9ejc8WHfMJ6xn49gnOM43IJ/jyMbXZUqKa271290GmPhdAE73K2hpKfgCNbUlrhKdqZ21xPWje+4ioBKGE6DdQKZHfL73+l5X78e9tffXgtQmQTqGPhe+XHP3p9h+Y91bxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UjxrKjPFZQds5WVF8IDxnIaxCFmmFKKiaeKQ8ufQvIE=; b=EM7trJgth00TgcOjVIw4Q9QbNRhgP6mPEKsdz0y/gWrpNP+MkPWd/bSqGwUNi75gAHpKGMwb2Mye31BWTtoQOLCUHnSv6EbGqcjFuipeMAnA/u7gPT4gJjfCnesBZlc942t7ENxc1lpf0n6wstHQfQJsm2x90h/EGbD8cmO+laE= From: Bertrand Marquis To: Jan Beulich , Stefano Stabellini , Julien Grall CC: Juergen Gross , osstest service owner , "xen-devel@lists.xenproject.org" Subject: Re: [linux-linus test] 174539: regressions - FAIL Thread-Topic: [linux-linus test] 174539: regressions - FAIL Thread-Index: AQHY6+CQ4VZAde/T6k6I0fM4JzEhfa4ptwOAgAG0q4CAAhQYgA== Date: Thu, 3 Nov 2022 17:43:21 +0000 Message-ID: <3BA37602-681E-4A1F-8C01-0DAB8FB9262B@arm.com> References: <3c8a3be2-db65-253d-94ae-1bfcad1b94e2@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|PAXPR08MB6464:EE_|VI1EUR03FT027:EE_|PAXPR08MB7598:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a58d307-5148-459d-865d-08dabdc2ed58 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: TLK47104wnaQMuNIL3BCDm1xYvjshFDqBg+mDDZcAVdOnUTT5nJwi/17sFntO7Mgms7otbk8h5F8aZL35U5602yaBcTP6lvhPdizKRgMYodx/wqqCagIhEUjm17fmiw451/iRzhekw4OYZoauWP+2i4grfzvbij6Lz+JN+rifhxWpeZkvG98O2p9MwJuU5TaIim0yRt/RZzCcd8dZBw6oHUQgbqM+V7cZLtgk/1ubwLS/84yzpEEfkiF6MOKFTVMjFkI6co6LJQZZ0IDQgcd4KC4fx4G8EfU79XN1bYcb2xt68z+d10AmG9WXHDLv2u82i9iGKs0xdAsIS6U0j8zspwaWnUO2KzcN969VdvwlWeuGfiC8vyCcBj42RmRrqKYM9z7QAW7HXqs/76zu3eMKKQJnVGCjk/xtyd9Avf41qn7H4I++ScU07zhA4jW4y5lKAerzw3tn79OUgFgImz5bzS7bTWQg0A4STFm3SUZvtbPiEkor9hNXX8Um5VEEp0xhy3DFBH2ENqECE+3mPq3gkdnTggcuSUvzfDZbnzZc/JhtiaU6g/z0HsS3gW/gjoB/xV5mwo9ee6lRAsCnZCscN2CtmlErggTD47RH5Rg+viNhqgzN7svTZPl+gP7tRdxYBLW/BH1mxKEGCQc2m1wP0zeArEN4ffE0X1+hLd8OjQdvyZpoGKOnOwQ0q1e9a/2Q9ISojNZfE02uf9UtK9mLxA8Kw3xfpWLaiRvS+EJTzrHmx3FAxLdYIP6aLpOHoYUKypzgpGWBvrXNkJB9/gpExm+IlP3bLykApIaJVUNxJHIPhASFmVvRVW8mXCgvXEQDRjaUZqXYgDRN+ymccWejg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(136003)(39860400002)(396003)(346002)(451199015)(36756003)(38100700002)(33656002)(38070700005)(122000001)(86362001)(6512007)(26005)(316002)(53546011)(478600001)(2616005)(6506007)(966005)(6486002)(71200400001)(64756008)(54906003)(66556008)(91956017)(66476007)(66946007)(2906002)(8676002)(8936002)(4326008)(76116006)(110136005)(5660300002)(41300700001)(186003)(66446008)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6464 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a7e55954-0a66-496f-a0c9-08dabdc2e6c6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vcQBM7xImmDvl8ZorsPVzmChfWU6SFZGrJ8VqSjFIfPQAtWgY+WhCyKCf7MVnYSVQVBLJUpfOEec64BpAgq1yRpUsCbtiAQe99uSesdAYszJtS8Ih7q59p9KUXwiUHKeFKMFe/4A+C2fmYYDIwvIYK1zGsG9CF3X/SBNu2lpsPRSD8LxtvQvTk8TqpySoSP9lluEYNRGbdth4vOeB8mrcRWdEOo27HrSM4DOnVu/eOyaGLITZ8wGW8bQed+x+otttsdIPJGub9lADbxsp2xdaOi2+oUflCkf5WtiiiKppshP4pd6J77zmVyG1kfLDJljbdb4iZh0SPZ7hfPZh6kzkFMJGKywsrp8ep6zoszDv3hw9hbym+wbTHYZDYp8PtcsnLGNAlab5PYOiCY0V+hwpNiiRa1cVVEOh0ubLVTpG5ArLYdYMWFn7v09CKqQf1cKBEVA9UNDmV8rRHp2wqXCYVDkZHNZ8Mqb4e/dMkvhUcu+2YFpS+O2q7uR3db1sa/VevtMDTqvXPWD5SqWF2aR3sYmjNrZ96HIOZ/0p+t/veLdh2LCIYZCpKEtQXYfLbGYLwPHe5jF+Izsh++J3HN7BY1m+yYzJrf2Mpi/l5q879AbmjL/gkIBp/c9v9dyw9BQjvQrX2tCgvTvnHWaiYw75jbhrSsVSZVrR2TnH++V0/RzPtiCs+WwyPKJCXlt4lEbAAKPWYshmBYtmO095h2WGv7Qd8Oh29M1307ppZaENathj3DAP8TYhs8qP3PK0NrNZdiGYZvN+3PN9SBU4WSUxEO2ZWTaD0uOrqc/44qrEkiLiruUkMb7BYyOGCUUkzyl X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(136003)(451199015)(40470700004)(36840700001)(46966006)(40480700001)(33656002)(6486002)(36756003)(47076005)(186003)(6506007)(2616005)(8936002)(5660300002)(356005)(81166007)(82740400003)(478600001)(966005)(336012)(26005)(53546011)(41300700001)(86362001)(2906002)(83380400001)(8676002)(6512007)(54906003)(40460700003)(70586007)(316002)(70206006)(36860700001)(4326008)(110136005)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 17:43:32.7622 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a58d307-5148-459d-865d-08dabdc2ed58 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7598 Hi, +Julien and Stefano > On 2 Nov 2022, at 09:58, Jan Beulich wrote: >=20 > On 01.11.2022 08:56, Juergen Gross wrote: >> On 29.10.22 23:50, osstest service owner wrote: >>> flight 174539 linux-linus real [real] >>> http://logs.test-lab.xenproject.org/osstest/logs/174539/ >>>=20 >>> Regressions :-( >>=20 >> I'm rather sure this is not kernel related, as the issue is occurring on= ly on >> Arm and it doesn't seem to be an architecture related issue (the volume = group >> containing the root file system couldn't be found). >>=20 >> Could it be an infrastructure problem? >=20 > Why would such manifest on only linux-linus? Along the lines of what I > did say in reply to flight 173480's report I continue to think that > there's an issue with the loading of a driver, perhaps because of a > bad / missing dependency just on Arm. Sadly the log doesn't have any > data in that regard (perhaps because of too low verbosity), so I > suspect finding out can only be done by someone with actual access to > one of the affected systems. @Julien or Stefano: Can one of you check this ? If not I can try next week to get an access on the system and check what is going on but it might take some time to get in the game. Cheers Bertrand >=20 > Jan >=20 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 17:53:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 17:53:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436942.691244 (Exim 4.92) (envelope-from ) id 1oqeP0-00031G-Qz; Thu, 03 Nov 2022 17:53:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436942.691244; Thu, 03 Nov 2022 17:53:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqeP0-000319-OM; Thu, 03 Nov 2022 17:53:18 +0000 Received: by outflank-mailman (input) for mailman id 436942; Thu, 03 Nov 2022 17:03:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdcw-0000Xu-B0 for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 17:03:38 +0000 Received: from isilmar-4.linta.de (isilmar-4.linta.de [136.243.71.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 71513021-5b99-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 18:03:31 +0100 (CET) Received: from owl.dominikbrodowski.net (owl.brodo.linta [10.2.0.111]) by isilmar-4.linta.de (Postfix) with ESMTPSA id EACA0201349; Thu, 3 Nov 2022 17:03:34 +0000 (UTC) Received: by owl.dominikbrodowski.net (Postfix, from userid 1000) id 7BB42801C7; Thu, 3 Nov 2022 18:03:24 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71513021-5b99-11ed-8fd0-01056ac49cbb X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES Date: Thu, 3 Nov 2022 18:03:24 +0100 From: Dominik Brodowski To: Andy Shevchenko Cc: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mika Westerberg , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Juergen Gross , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v2 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p() Message-ID: References: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> <20221103164644.70554-5-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221103164644.70554-5-andriy.shevchenko@linux.intel.com> Am Thu, Nov 03, 2022 at 06:46:44PM +0200 schrieb Andy Shevchenko: > The pci_bus_for_each_resource_p() hides the iterator loop since > it may be not used otherwise. With this, we may drop that iterator > variable definition. Thanks for your patch! > diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c > index ad1141fddb4c..9d92d4bb6239 100644 > --- a/drivers/pcmcia/rsrc_nonstatic.c > +++ b/drivers/pcmcia/rsrc_nonstatic.c > @@ -934,7 +934,7 @@ static int adjust_io(struct pcmcia_socket *s, unsigned int action, unsigned long > static int nonstatic_autoadd_resources(struct pcmcia_socket *s) > { > struct resource *res; > - int i, done = 0; > + int done = 0; > > if (!s->cb_dev || !s->cb_dev->bus) > return -ENODEV; > @@ -960,12 +960,9 @@ static int nonstatic_autoadd_resources(struct pcmcia_socket *s) > */ > if (s->cb_dev->bus->number == 0) > return -EINVAL; > - > - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) { > - res = s->cb_dev->bus->resource[i]; > -#else > - pci_bus_for_each_resource(s->cb_dev->bus, res, i) { > #endif > + > + pci_bus_for_each_resource_p(s->cb_dev->bus, res) { > if (!res) > continue; Doesn't this remove the proper iterator for X86? Even if that is the right thing to do, it needs an explict explanation. > > diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c > index 3966a6ceb1ac..b200f2b99a7a 100644 > --- a/drivers/pcmcia/yenta_socket.c > +++ b/drivers/pcmcia/yenta_socket.c > @@ -673,9 +673,8 @@ static int yenta_search_res(struct yenta_socket *socket, struct resource *res, > u32 min) > { > struct resource *root; > - int i; > > - pci_bus_for_each_resource(socket->dev->bus, root, i) { > + pci_bus_for_each_resource_p(socket->dev->bus, root) { > if (!root) > continue; > That looks fine! Thanks, Dominik From xen-devel-bounces@lists.xenproject.org Thu Nov 03 17:53:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 17:53:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436966.691248 (Exim 4.92) (envelope-from ) id 1oqeP1-00034B-4L; Thu, 03 Nov 2022 17:53:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436966.691248; Thu, 03 Nov 2022 17:53:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqeP0-00033D-W8; Thu, 03 Nov 2022 17:53:18 +0000 Received: by outflank-mailman (input) for mailman id 436966; Thu, 03 Nov 2022 17:25:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqdyY-0006Wd-Dd for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 17:25:58 +0000 Received: from isilmar-4.linta.de (isilmar-4.linta.de [136.243.71.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 93655017-5b9c-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 18:25:56 +0100 (CET) Received: from owl.dominikbrodowski.net (owl.brodo.linta [10.2.0.111]) by isilmar-4.linta.de (Postfix) with ESMTPSA id 5C1742013E3; Thu, 3 Nov 2022 17:25:53 +0000 (UTC) Received: by owl.dominikbrodowski.net (Postfix, from userid 1000) id 6880A8024B; Thu, 3 Nov 2022 18:25:45 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93655017-5b9c-11ed-91b5-6bf2151ebd3b X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES Date: Thu, 3 Nov 2022 18:25:45 +0100 From: Dominik Brodowski To: Andy Shevchenko Cc: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mika Westerberg , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Juergen Gross , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v2 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p() Message-ID: References: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> <20221103164644.70554-5-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Am Thu, Nov 03, 2022 at 07:12:45PM +0200 schrieb Andy Shevchenko: > On Thu, Nov 03, 2022 at 06:03:24PM +0100, Dominik Brodowski wrote: > > Am Thu, Nov 03, 2022 at 06:46:44PM +0200 schrieb Andy Shevchenko: > > ... > > > > - > > > - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) { > > > - res = s->cb_dev->bus->resource[i]; > > > -#else > > > - pci_bus_for_each_resource(s->cb_dev->bus, res, i) { > > > #endif > > > + > > > + pci_bus_for_each_resource_p(s->cb_dev->bus, res) { > > > if (!res) > > > continue; > > > > Doesn't this remove the proper iterator for X86? Even if that is the right > > thing to do, it needs an explict explanation. > > I dunno what was in 2010, but reading code now I have found no differences in > the logic on how resources are being iterated in these two pieces of code. > > But fine, I will add a line to a commit message about this change. > > Considering this is done, can you issue your conditional tag so I will > incorporate it in v3? Certainly, feel free to add Acked-by: Dominik Brodowski Thanks, Dominik From xen-devel-bounces@lists.xenproject.org Thu Nov 03 18:01:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 18:01:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436982.691266 (Exim 4.92) (envelope-from ) id 1oqeXH-0005ll-43; Thu, 03 Nov 2022 18:01:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436982.691266; Thu, 03 Nov 2022 18:01:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqeXH-0005le-1R; Thu, 03 Nov 2022 18:01:51 +0000 Received: by outflank-mailman (input) for mailman id 436982; Thu, 03 Nov 2022 18:01:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqeXE-0005lY-UC for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 18:01:49 +0000 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9344c94e-5ba1-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 19:01:45 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2022 11:01:43 -0700 Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 03 Nov 2022 11:01:36 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oqeWy-006xtO-3D; Thu, 03 Nov 2022 20:01:33 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9344c94e-5ba1-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667498505; x=1699034505; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=yb2Mq3fbpPtLAnjCVdV2BEIMFU/XQ1cYRIu5k0HafqM=; b=QawNy6MCX1+5ktWAplobfXkYqgAkMLc9J1Ts6EjU3++8Dj486ixCVwJf 7yBcGzXWd0exg+s579XGAxjcfcycD4UwUMFs/ACPTVbnxN7EFP56BCG14 m8WLn0HPenmWa/SPu9VPnuzQuCZ+nG6qo3aW9jDXx/xMYl/kpZE9uYOKK sFN81QNyO+FEN3cGfhddm2Yk9zGW47ktq5CG8sAbz8Gxn7HEFgkQwBkuW mLwZgVc8GWHBkvPSD1q679ncO1PpI8LEhEU0y3qGmSsPAi1ZHnQo9cgNg sP5o+i3orj4U98Yg4AH+yTNTYS+ZcTX2fHT2GLoEliZ9wZYrL/wBVX798 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="396065308" X-IronPort-AV: E=Sophos;i="5.96,134,1665471600"; d="scan'208";a="396065308" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="740290898" X-IronPort-AV: E=Sophos;i="5.96,134,1665471600"; d="scan'208";a="740290898" Date: Thu, 3 Nov 2022 20:01:32 +0200 From: Andy Shevchenko To: Dominik Brodowski Cc: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mika Westerberg , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Juergen Gross , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v2 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p() Message-ID: References: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> <20221103164644.70554-5-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Nov 03, 2022 at 06:25:45PM +0100, Dominik Brodowski wrote: > Am Thu, Nov 03, 2022 at 07:12:45PM +0200 schrieb Andy Shevchenko: > > On Thu, Nov 03, 2022 at 06:03:24PM +0100, Dominik Brodowski wrote: ... > > Considering this is done, can you issue your conditional tag so I will > > incorporate it in v3? > > Certainly, feel free to add > > Acked-by: Dominik Brodowski Thank you for the review! -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Thu Nov 03 18:43:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 18:43:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436989.691277 (Exim 4.92) (envelope-from ) id 1oqfBg-0003pd-7s; Thu, 03 Nov 2022 18:43:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436989.691277; Thu, 03 Nov 2022 18:43:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqfBg-0003pW-4m; Thu, 03 Nov 2022 18:43:36 +0000 Received: by outflank-mailman (input) for mailman id 436989; Thu, 03 Nov 2022 18:43:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqfBe-0003pQ-LD for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 18:43:34 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 689c9811-5ba7-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 19:43:31 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 689c9811-5ba7-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667501012; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=oyPCAImnaj09tKU7y54YtIG3O9iSVzO1A8cCcxhoV8M=; b=AyH6yFNhfeS10ZgWOAlnBHQcHG2aDIzc88R7VKhGol3lAoFbkqQe/SD6 WbY1n8McRF74WlRsjmC2572KUj1TSMvghVKRwffddmaN+2Qe9tH8cjCj3 3m10Nbonbr9PEIb+UUUL9VDmaCwTDcPZv2o0oUret+dv9a2FQ+Iqsw3Yf E=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 84124329 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:IOXL+aChEiGSChVW/zbjw5YqxClBgxIJ4kV8jS/XYbTApD4i02QOy TNKXmmAPfvbYjakeNEkPdiz8UkEsZLWztMwQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpA5QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw0+h4Ez8N+ eAkCg8vNy293uKz44qGY7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/BZ4gneHumn7ldD5wo1OJv6snpWPUyWSd1ZC9bIOPJofQFK25mG6nv DKBo2bQLygjD/vcwiGUw1utnNDmyHaTtIU6S+Tjq68CbEeo7mAaFhA+T1awpvi9zEmkVLp3N Eg86ico668o+ySDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZhZdo8pYkJTDol/ laTmpXiAjkHjVGOYSvDrPHO92r0YHVLaz9ZDcMZcecby/Dtr5NtzR7TcvRcMveIsIT1HBLI/ hnf+UDSmI4vpcIM0qy6+3XOjDStuoXFQ2YJ2+nHYo62xlgnPdD4PuRE/XCetK8dd9jBEjFtq VBew6CjAPYy4YZhfcBnaMEEB/mX6vmMK1UwanY/TsB6p1xBF5NOFL28AQ2Sxm8zb67omhezO ic/XD+9A7cKZROXgVdfOd7ZNijT5fGI+S7Zfv7VdMFSRZN6aRWK+ipjDWbJgT6yzBFwyPpiY 8nEGSpJMZr9If05pAdaus9HieN7rszA7T67qW/HI+SPjuPFOS/9pUYtO1qSdOEphJ5oUy2Mm +uzw/CikkwHONASlwGNrub/23hWciVgbX03wuQLHtO+zv1ORzp9VqaBmuN6E2Gn9owM/tr1E riGchcw4DLCabfvcG1mtlgLhGvTYKtC IronPort-HdrOrdr: A9a23:uQCQZKOQN43/T8BcTs+jsMiBIKoaSvp037Eqv3oRdfUzSL3/qy nOpoV96faaskdzZJhNo7+90cq7MBfhHPxOkOss1N6ZNWGM0gbFEGgL1/qa/9SKIU3DH4Bmu5 uIC5IObeHNMQ== X-IronPort-AV: E=Sophos;i="5.96,134,1665460800"; d="scan'208";a="84124329" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [[PATCH for-4.17 v1]] tools/ocaml/xenstored/store.ml: fix build error Date: Thu, 3 Nov 2022 18:42:50 +0000 Message-ID: <5a453393dad1de8286fe5db16504d3db2906eef8.1667500970.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Building with Dune in release mode fails with: ``` File "ocaml/xenstored/store.ml", line 464, characters 13-32: Warning 18: this type-based record disambiguation is not principal. File "ocaml/xenstored/store.ml", line 1: Error: Some fatal warnings were triggered (1 occurrences) ``` This is a warning to help keep the code futureproof, quoting from its documentation: > Check information path during type-checking, to make sure that all types are > derived in a principal way. When using labelled arguments and/or polymorphic > methods, this flag is required to ensure future versions of the compiler will > be able to infer types correctly, even if internal algorithms change. All > programs accepted in -principal mode are also accepted in the default mode with > equivalent types, but different binary signatures, and this may slow down type > checking; yet it is a good idea to use it once before publishing source code. Fixes: db471408edd46 "tools/ocaml/xenstored: Fix quota bypass on domain shutdown" Signed-off-by: Edwin Török --- tools/ocaml/xenstored/store.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/ocaml/xenstored/store.ml b/tools/ocaml/xenstored/store.ml index 14ec404988..38a4945372 100644 --- a/tools/ocaml/xenstored/store.ml +++ b/tools/ocaml/xenstored/store.ml @@ -461,7 +461,7 @@ let reset_permissions store domid = | Some perms -> if perms <> node.perms then Logging.debug "store|node" "Changed permissions for node %s" (Node.get_name node); - Some { node with perms } + Some { node with Node.perms } ) store.root type ops = { -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 03 18:50:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 18:50:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436994.691287 (Exim 4.92) (envelope-from ) id 1oqfI6-0005pM-Sn; Thu, 03 Nov 2022 18:50:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436994.691287; Thu, 03 Nov 2022 18:50:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqfI6-0005pF-Q0; Thu, 03 Nov 2022 18:50:14 +0000 Received: by outflank-mailman (input) for mailman id 436994; Thu, 03 Nov 2022 18:50:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqfI5-0005p5-By for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 18:50:13 +0000 Received: from isilmar-4.linta.de (isilmar-4.linta.de [136.243.71.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5666f69c-5ba8-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 19:50:09 +0100 (CET) Received: from owl.dominikbrodowski.net (owl.brodo.linta [10.2.0.111]) by isilmar-4.linta.de (Postfix) with ESMTPSA id A7E69201457; Thu, 3 Nov 2022 18:50:07 +0000 (UTC) Received: by owl.dominikbrodowski.net (Postfix, from userid 1000) id 564FF801F1; Thu, 3 Nov 2022 19:38:07 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5666f69c-5ba8-11ed-8fd0-01056ac49cbb X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES Date: Thu, 3 Nov 2022 19:38:07 +0100 From: Dominik Brodowski To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: Andy Shevchenko , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mika Westerberg , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Juergen Gross , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v2 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p() Message-ID: References: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> <20221103164644.70554-5-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Am Fri, Nov 04, 2022 at 03:29:44AM +0900 schrieb Krzysztof Wilczyński: > Hello, > > [...] > > > > - > > > > - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) { > > > > - res = s->cb_dev->bus->resource[i]; > > > > -#else > > > > - pci_bus_for_each_resource(s->cb_dev->bus, res, i) { > > > > #endif > > > > + > > > > + pci_bus_for_each_resource_p(s->cb_dev->bus, res) { > > > > if (!res) > > > > continue; > > > > > > Doesn't this remove the proper iterator for X86? Even if that is the right > > > thing to do, it needs an explict explanation. > > > > I dunno what was in 2010, but reading code now I have found no differences in > > the logic on how resources are being iterated in these two pieces of code. > > This code is over a decade old (13 years old to be precise) and there was > something odd between Bjorn's and Jesse's patches, as per: > > 89a74ecccd1f ("PCI: add pci_bus_for_each_resource(), remove direct bus->resource[] refs") > cf26e8dc4194 ("pcmcia: do not autoadd root PCI bus resources") > > > But fine, I will add a line to a commit message about this change. > > I wouldn't, personally. The change you are proposing is self-explanatory > and somewhat in-line with what is there already - unless I am also reading > the current implementation wrong. > > That said, Dominik is the maintainer of PCMCIA driver, so his is the last > word, so to speak. :) > > > Considering this is done, can you issue your conditional tag so I will > > incorporate it in v3? > > No need, really. Again, unless Dominik thinks otherwise. Ah, thanks for the correction. Then v2 is perfectly fine. Thanks, Dominik From xen-devel-bounces@lists.xenproject.org Thu Nov 03 18:59:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 18:59:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.436987.691298 (Exim 4.92) (envelope-from ) id 1oqfQp-00074f-Nk; Thu, 03 Nov 2022 18:59:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 436987.691298; Thu, 03 Nov 2022 18:59:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqfQp-00074Y-LC; Thu, 03 Nov 2022 18:59:15 +0000 Received: by outflank-mailman (input) for mailman id 436987; Thu, 03 Nov 2022 18:29:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqeyR-00011G-GP for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 18:29:55 +0000 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8236c6f2-5ba5-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 19:29:54 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id f63so2421444pgc.2 for ; Thu, 03 Nov 2022 11:29:53 -0700 (PDT) Received: from rocinante (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id o14-20020a170902d4ce00b0018157b415dbsm1034089plg.63.2022.11.03.11.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 11:29:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8236c6f2-5ba5-11ed-91b5-6bf2151ebd3b X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pZjEyPGh7N/ck24vh/VKMs5s50UIlOa2pgI4ml3dqpA=; b=nYo1vbk9UDNpY1maOTBkxOBgqZyfZiaz2NO7leQKbBvnBeCbgDxdHSNSuyx30uG7q2 5ZROmmuEio4uvxnlwxepe7o9r19OWmaPVFklaMKDZmWTvsEZkeWiJ6IxWLGVoalR8h6m CA04rBt0tMELbCTsM+R75mx9S69LoSoa9j0idmYdvrKwjICqd8DaLMhU3CSJcjg1OSKd 1GKMofnZd73OHXx62LraoloQEnMVgHXMtoxitI8QlvcyWQujdZ3LRQgq+HMnbDv7Vg2r 4KAYjF+uz7LpuoxSDIcGok5P8ACLb8qwlTPKpKs3iLUQtqxQYp8PcBFtP8KD9OS/xHHn ByWQ== X-Gm-Message-State: ACrzQf1novfyieDG4+Xi35YmuzRNWwmlB/H9GPz/jqEXI0aT8C8ZMXbl HGFHWkc1ngVANyvtsSBITbk= X-Google-Smtp-Source: AMsMyM4MMb94EAGz1kO2Q0DRDyjidkdmznJiyzQZ8JfQK1Y1FbZfy+aOFpE2yYDeDmYpBxRHuxCHKQ== X-Received: by 2002:aa7:8c15:0:b0:56b:ead2:3950 with SMTP id c21-20020aa78c15000000b0056bead23950mr32086578pfd.77.1667500192405; Thu, 03 Nov 2022 11:29:52 -0700 (PDT) Date: Fri, 4 Nov 2022 03:29:44 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Andy Shevchenko Cc: Dominik Brodowski , =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Mika Westerberg , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Juergen Gross , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v2 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p() Message-ID: References: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> <20221103164644.70554-5-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Hello, [...] > > > - > > > - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) { > > > - res = s->cb_dev->bus->resource[i]; > > > -#else > > > - pci_bus_for_each_resource(s->cb_dev->bus, res, i) { > > > #endif > > > + > > > + pci_bus_for_each_resource_p(s->cb_dev->bus, res) { > > > if (!res) > > > continue; > > > > Doesn't this remove the proper iterator for X86? Even if that is the right > > thing to do, it needs an explict explanation. > > I dunno what was in 2010, but reading code now I have found no differences in > the logic on how resources are being iterated in these two pieces of code. This code is over a decade old (13 years old to be precise) and there was something odd between Bjorn's and Jesse's patches, as per: 89a74ecccd1f ("PCI: add pci_bus_for_each_resource(), remove direct bus->resource[] refs") cf26e8dc4194 ("pcmcia: do not autoadd root PCI bus resources") > But fine, I will add a line to a commit message about this change. I wouldn't, personally. The change you are proposing is self-explanatory and somewhat in-line with what is there already - unless I am also reading the current implementation wrong. That said, Dominik is the maintainer of PCMCIA driver, so his is the last word, so to speak. :) > Considering this is done, can you issue your conditional tag so I will > incorporate it in v3? No need, really. Again, unless Dominik thinks otherwise. Krzysztof From xen-devel-bounces@lists.xenproject.org Thu Nov 03 19:00:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 19:00:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437003.691310 (Exim 4.92) (envelope-from ) id 1oqfRd-0008D3-2O; Thu, 03 Nov 2022 19:00:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437003.691310; Thu, 03 Nov 2022 19:00:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqfRc-0008Cc-UJ; Thu, 03 Nov 2022 19:00:04 +0000 Received: by outflank-mailman (input) for mailman id 437003; Thu, 03 Nov 2022 19:00:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqfRb-0007xe-Tk for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 19:00:04 +0000 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b55626e1-5ba9-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 19:59:59 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2022 11:59:44 -0700 Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 03 Nov 2022 11:59:37 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oqfR8-006zVP-0o; Thu, 03 Nov 2022 20:59:34 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b55626e1-5ba9-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667502000; x=1699038000; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=iDzJkwIYDgDj9s9QyYyQqMun6Fj8NrFnD6UKX0fcnAs=; b=XKlkx+pizdP9SQ+CvvSk+q2afZp1itWZMQrLPLAU/PLsgtFCoPBcPN0G DfFjQ3Qtqdvp4W0Zt7OauTxV5UOB9mIM06Ltk+6Aw2yStyVPaL5hdLjoz FOdJztpUPPd4cXPVn/MNkTeZpfcGTkmAn+gywxjqgxgq1ORnC1uafvPfB 2i6dN6HP1bgBFi6OwLIhxwHDZ+yTqYHaGKwhClLbnUMDiTlQ0rnM/rM3i 3yj056TooV6TrV+P2DxqeOKBEjnD92Z12DX+7ShWZDhGfUozUZOSK5IZT p59C0eHJq7EcP+4+nfCG5m/byRU6Ozh14ymbNJSjMn/LwzGnPmYnoysGL g==; X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="307395131" X-IronPort-AV: E=Sophos;i="5.96,135,1665471600"; d="scan'208";a="307395131" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="724055696" X-IronPort-AV: E=Sophos;i="5.96,135,1665471600"; d="scan'208";a="724055696" Date: Thu, 3 Nov 2022 20:59:33 +0200 From: Andy Shevchenko To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: Dominik Brodowski , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mika Westerberg , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Juergen Gross , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v2 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p() Message-ID: References: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> <20221103164644.70554-5-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Nov 04, 2022 at 03:29:44AM +0900, Krzysztof Wilczyński wrote: > > > > - > > > > - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) { > > > > - res = s->cb_dev->bus->resource[i]; > > > > -#else > > > > - pci_bus_for_each_resource(s->cb_dev->bus, res, i) { > > > > #endif > > > > + > > > > + pci_bus_for_each_resource_p(s->cb_dev->bus, res) { > > > > if (!res) > > > > continue; > > > > > > Doesn't this remove the proper iterator for X86? Even if that is the right > > > thing to do, it needs an explict explanation. > > > > I dunno what was in 2010, but reading code now I have found no differences in > > the logic on how resources are being iterated in these two pieces of code. > > This code is over a decade old (13 years old to be precise) and there was > something odd between Bjorn's and Jesse's patches, as per: > > 89a74ecccd1f ("PCI: add pci_bus_for_each_resource(), remove direct bus->resource[] refs") > cf26e8dc4194 ("pcmcia: do not autoadd root PCI bus resources") Yeah, thanks for pointing out to the other patch from the same 2010 year. It seems the code was completely identical that time, now it uses more sophisticated way of getting bus resources, but it's kept the same for the resources under PCI_BRIDGE_RESOURCE_NUM threshold. > > But fine, I will add a line to a commit message about this change. > > I wouldn't, personally. The change you are proposing is self-explanatory > and somewhat in-line with what is there already - unless I am also reading > the current implementation wrong. But it wouldn't be harmful either. > That said, Dominik is the maintainer of PCMCIA driver, so his is the last > word, so to speak. :) > > > Considering this is done, can you issue your conditional tag so I will > > incorporate it in v3? > > No need, really. Again, unless Dominik thinks otherwise. I think that what is wanted to have to get his tag. Thanks for review, both of you, guys! -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Thu Nov 03 19:01:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 19:01:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437007.691321 (Exim 4.92) (envelope-from ) id 1oqfSw-0000aI-DW; Thu, 03 Nov 2022 19:01:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437007.691321; Thu, 03 Nov 2022 19:01:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqfSw-0000aB-AM; Thu, 03 Nov 2022 19:01:26 +0000 Received: by outflank-mailman (input) for mailman id 437007; Thu, 03 Nov 2022 19:01:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqfSv-0000Ze-4H for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 19:01:25 +0000 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e682196f-5ba9-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 20:01:21 +0100 (CET) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2022 12:01:18 -0700 Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 03 Nov 2022 12:01:11 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oqfSd-006zXu-1O; Thu, 03 Nov 2022 21:01:07 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e682196f-5ba9-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667502081; x=1699038081; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=sNkpjDaE4wFtOA2SWrBA99Yi2yLtSUQQFYkHqzgZpY0=; b=bjjERSibgTNUU85Hg7P6wSvUP770XMf72qD1UXaO+5D3TRBcX1RWt/ds UEoeNDbR6gIrc3dwng7ZjogkA9dtx2rD9FsSOn6qfcC4sqFOeW/uL+0JN epwlVg5QaoL/Ryi/rPUbkhLIx+FL+4v5HKhZj1aM1wYVwxLoqlbw6rvsa oPXvxe3M7mrGwL+zYN8MZxjY27Wuwt2vGYqHta/Dz4hQxzNpdFmmwauwZ l6gcKK/U6IxXstGnRSLmaAoviY6fMWIyGGOMQYqEtz795WTjalDMLLg5q RsQxF/J/OmqMMZjkcR2jpvRYfhom/VXZXJLYXsANd05L5ks0W+wHkf5eK w==; X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="336475096" X-IronPort-AV: E=Sophos;i="5.96,135,1665471600"; d="scan'208";a="336475096" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10520"; a="629452994" X-IronPort-AV: E=Sophos;i="5.96,135,1665471600"; d="scan'208";a="629452994" Date: Thu, 3 Nov 2022 21:01:07 +0200 From: Andy Shevchenko To: Dominik Brodowski Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mika Westerberg , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Juergen Gross , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v2 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p() Message-ID: References: <20221103164644.70554-1-andriy.shevchenko@linux.intel.com> <20221103164644.70554-5-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Nov 03, 2022 at 07:38:07PM +0100, Dominik Brodowski wrote: > Am Fri, Nov 04, 2022 at 03:29:44AM +0900 schrieb Krzysztof Wilczyński: ... > > That said, Dominik is the maintainer of PCMCIA driver, so his is the last > > word, so to speak. :) > > > > > Considering this is done, can you issue your conditional tag so I will > > > incorporate it in v3? > > > > No need, really. Again, unless Dominik thinks otherwise. > > Ah, thanks for the correction. Then v2 is perfectly fine. I'm fine with either, thanks! -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Thu Nov 03 19:08:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 19:08:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437015.691332 (Exim 4.92) (envelope-from ) id 1oqfZw-0001u5-As; Thu, 03 Nov 2022 19:08:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437015.691332; Thu, 03 Nov 2022 19:08:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqfZw-0001ty-6R; Thu, 03 Nov 2022 19:08:40 +0000 Received: by outflank-mailman (input) for mailman id 437015; Thu, 03 Nov 2022 19:08:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqfZv-0001to-Fe; Thu, 03 Nov 2022 19:08:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqfZv-0002wI-9s; Thu, 03 Nov 2022 19:08:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqfZu-0006sY-RL; Thu, 03 Nov 2022 19:08:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqfZu-0000SZ-Ql; Thu, 03 Nov 2022 19:08:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wLiGTbQ54wgVEiEmbg/JopsajAq6fTt7ctvxIBC2NPA=; b=cZZG+31tLxXHwOGfqydrxH6GN3 tSwBcmaV8/WLKvbHrqXmXv1qzqr7AXThLObMX/BVCo4mwRowSe6+Df+UU54D7Gwl2qPSHPtwTE4Kq Qyx0f6dOoFo9c2tPeZVM/meAb6l7xdD83juBT7HhN7y4dAVJlmLwWGM27UWx/g77uuTc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174599: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=5282d4de783b727f9e5e6e90d90a3eff53ef5c31 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Thu, 03 Nov 2022 19:08:38 +0000 flight 174599 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174599/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 14 guest-start fail in 174575 pass in 174599 test-armhf-armhf-xl-rtds 14 guest-start fail in 174575 pass in 174599 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 174575 pass in 174599 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail in 174590 pass in 174599 test-armhf-armhf-xl-vhd 13 guest-start fail in 174590 pass in 174599 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 174575 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail pass in 174590 test-armhf-armhf-libvirt-qcow2 13 guest-start fail pass in 174590 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 174590 like 174540 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 174590 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 5282d4de783b727f9e5e6e90d90a3eff53ef5c31 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 5 days Testing same since 174575 2022-11-01 18:42:39 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Greg Kroah-Hartman Yongqin Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 5282d4de783b727f9e5e6e90d90a3eff53ef5c31 Author: Greg Kroah-Hartman Date: Tue Nov 1 19:06:42 2022 +0100 Linux 5.4.222 Signed-off-by: Greg Kroah-Hartman commit 59f89518f51004bcdb05a92e462e2298989294f9 Author: Greg Kroah-Hartman Date: Tue Nov 1 18:12:39 2022 +0100 once: fix section mismatch on clang builds On older kernels (5.4 and older), building the kernel with clang can cause the section name to end up with "" in them, which can cause lots of runtime issues as that is not normally a valid portion of the string. This was fixed up in newer kernels with commit 33def8498fdd ("treewide: Convert macro and uses of __section(foo) to __section("foo")") but that's too heavy-handed for older kernels. So for now, fix up the problem that commit 62c07983bef9 ("once: add DO_ONCE_SLOW() for sleepable contexts") caused by being backported by removing the "" characters from the section definition. Reported-by: Oleksandr Tymoshenko Reported-by: Yongqin Liu Tested-by: Yongqin Liu Cc: Naresh Kamboju Link: https://lore.kernel.org/r/20221029011211.4049810-1-ovt@google.com Link: https://lore.kernel.org/r/CAMSo37XApZ_F5nSQYWFsSqKdMv_gBpfdKG3KN1TDB+QNXqSh0A@mail.gmail.com Cc: Christophe Leroy Cc: Eric Dumazet Cc: Willy Tarreau Cc: Christophe Leroy Cc: David S. Miller Cc: Sasha Levin Cc: Nathan Chancellor Signed-off-by: Greg Kroah-Hartman From xen-devel-bounces@lists.xenproject.org Thu Nov 03 19:57:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 19:57:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437022.691342 (Exim 4.92) (envelope-from ) id 1oqgKj-0001Rq-No; Thu, 03 Nov 2022 19:57:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437022.691342; Thu, 03 Nov 2022 19:57:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqgKj-0001Rj-L5; Thu, 03 Nov 2022 19:57:01 +0000 Received: by outflank-mailman (input) for mailman id 437022; Thu, 03 Nov 2022 19:57:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqgKi-0001Rd-La for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 19:57:01 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9d5054b-5bb1-11ed-91b5-6bf2151ebd3b; Thu, 03 Nov 2022 20:56:57 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 0990E320030E; Thu, 3 Nov 2022 15:56:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 03 Nov 2022 15:56:52 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 3 Nov 2022 15:56:49 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9d5054b-5bb1-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1667505411; x= 1667591811; bh=cbyVflLeIMmEFWy7x4clexNUFMuHe7NwhfURRALJF6w=; b=f IoPHM57F4SYkwI56VFufDQrtL+PmfvaGEU/67yRYEAfgMTVF8tlG7vXtQ3ItDLNh 23PwM/+wEWFtPmjXSE97efc+nIVEkH11HzLyz0lHOx1vxQRf5IWNNLyN/ZcjlJwr RlaVi8YCyjSYVpqAhdB2RiBxcmobZykh2Ph+29cCGL7IO4koyBeh4k8+c5TdLdcB WZXo7Gt04QlR+HEPXzLHrQ6KTxZ4Twoykof1hMlDrhpbjutPORPfFJvnEWTI4kcZ +puVbx6XxLFitdvOjaQU03g0RwNinC3JxkCaOUd8JW+fein/oAqCsunuxs0ZxPwS R/7yAQ/rbTykjVBKpW4cA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1667505411; x=1667591811; bh=cbyVflLeIMmEFWy7x4clexNUFMuH e7NwhfURRALJF6w=; b=BMp0bf18rSjjc+udwSi2vU80xSOJIfjZOThDJvRWU8N+ L0fDkYCkmRZQpuDF28M181ZFwsvpkLTQWP1AwwbLoPSoNt+Qx/bLonuo0Ry21AHm DakELIpmEnQ+xxbaD+L7AnakQw5JNCpnn5BA2Zg4lrg7EUvFFQ68pU+k1bWU2ZPm B+R7Df9MjCtJK1rBZpQdTg8myUHf8xLhok5ty9sGAPU5xZv9bB3GK9XxwtP70KXC fWXSpVj6RzkeA4BqbLiD4yYpndwyqeRc/KfNW3C8aEP8bNSQbttHgqDw1aTrrxZF nZ10w4nj9gIxGY6yhyEQDDWNVh3nI+QIzkkAUWKZTQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudelgdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 3 Nov 2022 20:56:45 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Henry Wang Cc: Jan Beulich , Kevin Tian , Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory API Message-ID: References: <2214fd86-0cfa-58ef-39db-6f913a9de75e@suse.com> <2ee2c1f9-a6bf-7641-16fa-ce2ea90f377b@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BW1v4jERWnm7xIGu" Content-Disposition: inline In-Reply-To: --BW1v4jERWnm7xIGu Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 3 Nov 2022 20:56:45 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Henry Wang Cc: Jan Beulich , Kevin Tian , Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory API On Thu, Nov 03, 2022 at 02:55:31AM +0000, Henry Wang wrote: > Hi Jan, >=20 > > -----Original Message----- > > From: Jan Beulich > > Subject: Re: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved > > memory API > >=20 > > >>>> Signed-off-by: Marek Marczykowski-G=C3=B3recki > > >>> > > >>>> Reviewed-by: Kevin Tian > > >>> > > >>> Henry, can this be included in 4.17? The AMD counterpart went in > > >>> earlier, but due to late review on Intel part, this one didn't. > > >> > > >> Thanks for the information. I agree this is a valid reason, but to be > > >> safe I would like to hear opinions from the x86 maintainers (added > > >> in CC). > > >> > > >> Andrew/Jan/Roger: May I have your feedback about this? Thanks! > > > > > > Hmm, not sure what to say here. Yes, it would be nice for things to e= nd > > > up consistent across vendors. And yes, the change here is largely > > > mechanical (afaics) and to code most of which shouldn't typically be = in > > > use on systems anyway, and so should not pose an undue risk. But still > > > it is quite a bit of code churn ... > >=20 > > Was this lost, did you decide against allowing this in, or were you hop= ing > > for further responses by others? >=20 > Sorry for the confusion. Yeah I was hoping to see if we can have further > responses from others, but it seems no responses so far... >=20 > I have the exact same opinion as yours so I am also not sure. But if you > changed your mind and would like to commit the patch for completeness > of the original series, please feel free to add my release-ack. I would n= ot > block this patch. FWIW, most of the diff is just extracting loop body into a function, the only functional difference is a new called for this function, and moving one of the checks (MAX_USER_RMRR_PAGES enforcement) outside of it. So, my (biased) opinion is, it's rather low risk. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --BW1v4jERWnm7xIGu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmNkHP4ACgkQ24/THMrX 1yxMVwf+Ortf73eYGBgsWy3r7xRk2quPA58zbmX1nPrcg3kkhc9G9AJBGdHNNNiI 4RhHEAjyuiqHBwcg22hSH11sd/keWSIgyyHmVhXCkW8oGaN2u7DxqAAck8Ln0hK+ ePmwO8tf8V5xpiK2DtTkOx3xi1IMft6B5VXelDVMfeHb4Qqri/biHTAvIOVb8+33 xxb1+fGKshpElxrlUavFRQCCwAMzwwUdS+AyDLZufYyauk4S5KvSHl5gBdpEXFYF RXF+T6sYSaeV/etOk9KqrogQMCcBFxjK2kFQcitYPD4w9hfzP4UCDTYhhmv89lbL l/YfhjfaYwTimgY4D18Pp+0ThvwbGg== =I9/e -----END PGP SIGNATURE----- --BW1v4jERWnm7xIGu-- From xen-devel-bounces@lists.xenproject.org Thu Nov 03 20:14:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Nov 2022 20:14:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437031.691354 (Exim 4.92) (envelope-from ) id 1oqgbO-0004Ub-AF; Thu, 03 Nov 2022 20:14:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437031.691354; Thu, 03 Nov 2022 20:14:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqgbO-0004UU-6M; Thu, 03 Nov 2022 20:14:14 +0000 Received: by outflank-mailman (input) for mailman id 437031; Thu, 03 Nov 2022 20:14:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqgbM-0004UO-AY for xen-devel@lists.xenproject.org; Thu, 03 Nov 2022 20:14:12 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2046.outbound.protection.outlook.com [40.107.243.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 12fdfc35-5bb4-11ed-8fd0-01056ac49cbb; Thu, 03 Nov 2022 21:14:10 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CY8PR12MB7148.namprd12.prod.outlook.com (2603:10b6:930:5c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov 2022 20:14:06 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 20:14:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12fdfc35-5bb4-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KY8qVKdpm+9Z0RwmPKEP0xPhB5/k6JbIUiSax6PLCD/HsyLrLi3hBS4YRl/zSDhwy86YSZ51ol0vQMSAjPBmwQ1T4A43bjCbBqL9VT1qOezyzwh17yQIh4W4+cckI4Mrt9XpTN6BvVnaQH1FAnMwwAscUWrgmVLCXEq8ti9ltu+oKAakEmIx7E7xcC1YBfmq2uUUM4+M16GiRS/X3LS4th2WgyTMjPQHXB44Nz9eGZNvbGsKUWxOn7OUCQ/CjPOk2xWjRpv4PtHZr6VH2PPPLT13STbva/T6uI8eYwRAOQ+MMIh1wrYeyNsa1A0s+GpzPsouSpxMuDwevm9Dk2hy3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oM+niLR18nMnodEP/UieSjbRtcSxSxYLgGH07V9S5Xk=; b=HL2iheRR5ACIk7oqR4FawNqLEJ85NmDtQNmabXOKNizJBPQr1mWTECJuw64T6JMQoL2k2DA0KGKrHoDsX2RnNXzYRbNWMWiAiwSjVfIh13visnVXosRO3d9uht7/K1NpfW1WRscGea5u8jFEHzEJAgvNDDwEwmSIl1HC/iHUy8dWfNpfb89qwqrZmzoOqw8bGm240HwG0udo/0eh8RLamC0r9bp9CaL5AAejidtT2Fya6duUHsTiBSRHekUo5bPoU+cKWYpS6RTLlkC0/nUzl2fj3Im/qxYBMMbJqKizcJB53H5V+CAV/4I2tR/Cq+LS0xXHQ4mz3tmDgfHYiDA2JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oM+niLR18nMnodEP/UieSjbRtcSxSxYLgGH07V9S5Xk=; b=x9E1fYMfOhyhVg7Z1ZonQCnexkX6wBJ12f+CGlz8gen0Tex/kc8hmfdlgr5q6h9YfF+gr2BGEngxzkzOwnCVVhgSmXY93BrG3Z6MT8axiTJBSmF/aaR5ewT0ixuqD4E6ULnSNJ2OwM8MfquYEIqzh8pvbS/8YiWHOXjp+LKCPWY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Thu, 3 Nov 2022 20:14:00 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 09/12] xen/Arm: GICv3: Define GIC registers for AArch32 To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-10-ayankuma@amd.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0566.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::16) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CY8PR12MB7148:EE_ X-MS-Office365-Filtering-Correlation-Id: e21dd235-e439-4f2f-fea7-08dabdd7f52f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N0h82RPVFNRcTyHJwOLJZ2Cpm1gAx+p0rkXMtQ4SEgYcDYBDpHxiun6woxvlJnoaRWactHS05rPCMlbeRulVDtq74zBK0zQMyjm7dKaWl6bmCnmDeqrozxxmSd9YfopjmviT/R777VFp+BcXM7eoVMRQZbtiZqO+NPd1SJlKi99/CTNOXPklbaISNZ/9VMXdV1VKkK+rK46rMXte7TYF+q/2giWT0PqSKC9aauqCpbI8GXnjE8Cauem3BE1KfFXbvMJtvGzFrBMVbqAlqz24Mj4clZJGWUE/iaGbZtXoCuzvyuxKmbec7OvXNpHpPh9JG0qsInLPShhEi+gtqfkB12c/3eb9ncaxIwnuRoE4kBcEoIZ9qPhUjrQ7+91nWDk/d+Z2gNDnXeDrkPk1i1Vphcm2neP7GpcieCpn3igXbJXfPgZcRINVaxxpjucW4NuNZT/xZf/YC92JRnfdXGaNKYpQ3B2rtnwWwa2N2vx664qVhXvOcwPqPvlz132QP/yDkdtq69vl2e/1loD1/plNQICPQT7RS5UAypEFVeeYTcvT0m9KvuFNhJfR8Cy2OsyZvu7/sLr17jia+OupHvP/JlWuWfYpMrBATRswHebooi80DK+1IjLlbHClhWXIFAIoa7J3v4DcWJDZ7MljO+a5WySaulDoqv1q577TFRaLJ5x7gVDcZ7z3L2XWehj4W9dlOJt8h2aJJk85CH+Ja5+4Z69lhI5kPX6bbHKqCBAOXlfO6KbzCxCqw7uDZ2r4IaDmUrToNHCOyBbtAasW93roG9bFcv0+aS6WfW0H9JjbirE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(396003)(366004)(346002)(451199015)(6486002)(83380400001)(478600001)(6512007)(31686004)(31696002)(8936002)(26005)(5660300002)(2616005)(2906002)(38100700002)(36756003)(316002)(41300700001)(53546011)(8676002)(66476007)(6506007)(66946007)(66556008)(186003)(6666004)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGszSjFkeGJVU3NReW1aSHczTXVUL2tMS2lwR2xobFBXdnp0bFRITk5zVkpM?= =?utf-8?B?Y0FIUGVrQnpGU1F2b2tjOXBZbG5YTUUzTUI2N1NFUW5tOU9kWnJrcHh2WEhS?= =?utf-8?B?RlR6SlM1NE9tQ25wUDlOMHlJdlZVRnpneUM2R1YxTlRDZU1MaFp0Y3lJWFRX?= =?utf-8?B?OGR2WVVJOWlvUzVEaThpM2VXWE9abEJvMzFYazV0azNjMzQrUUNiZmc0ZjJN?= =?utf-8?B?d2E5dVp6TWRZNHdsaWNNR0k4NDVoQWtCUnliQjdzUHIvYVRoQklaZ1ZDUlp0?= =?utf-8?B?cnVTdjNnLytnZlRLVklNSklYb05lT0srT25XMDlQZHo1aTN5RDJjbENBdWY1?= =?utf-8?B?c2ZNUzVWZXJaK2pMcjJrVW5VK1AvVERBWWFVT3ZKanR2QUtmcGYxWllkMWN6?= =?utf-8?B?b0cwZG5jMko4aVpjSTl1aVJOTTliQUx3T0FabDkwTjJZZkZCRGtPcEUreHJL?= =?utf-8?B?aVB2dTNNZVZSZVpmMy9hK0RyNVJwMUhvZzZLMUpDQzBuSW51ZWNmSTVsd2ZP?= =?utf-8?B?ZU9FemNjMFg5ZXR3ejVvQzdyUm10dWRIM3RVTlIxMXA1YjBRd2FXN2pZclJP?= =?utf-8?B?QXZPT09qSmo4TnFrcEFMTWwxU0tCTFBKUkRaZjk1b1pDcGtaZE0rTFVPazdG?= =?utf-8?B?bnhOalhDSksvYStlb3Y2OFNJV2pDaE50Ym93MjV1SWxEZjdYaEZjRzJCTnNT?= =?utf-8?B?aDBQSTN6aEVHemVSdlpBdTQ4TklmL1lkNXl6Lzhlc1pzTkszMUF6MGtKZkJm?= =?utf-8?B?K2laeGtHc0hsVVNQd3FLeDZYVWY5Rmxkc1FudEpSWnNMRGpnSkRtbUVCNDUw?= =?utf-8?B?ZDUvRTJuT2tBZ3o0MjRvYWtjdHUyTXFiNDlNRk82MDE1SmxLb1VUUDQ4RGZr?= =?utf-8?B?YmU1d3ZnZURoZ3NiTFBCY1c2QkM3U0NZSnpvWk5tTExsVStYRnViZVV1S005?= =?utf-8?B?TGNsTGpvWWZwUFVhSk1mM0JUMUtQSGRVMFhVTkJ2TWJLTEpWS1F0d2wydzNX?= =?utf-8?B?RGlHMzJWaWJOTTdJWWczZjE5djc1UFBnODA1amp3S3BoOHg2YWdlQ0tabW9Z?= =?utf-8?B?djFKWThxQVlpSll5d2lPelVIaVl6OVFINkZLYitsSnBuODBNcE5SMTlFN0xK?= =?utf-8?B?enpIQ2tFa3pDUkMvMnBrMkJoVW04Ynl0ZmtJQkc1eUd1WmFkMVo2c0hoTGMy?= =?utf-8?B?ZW44Q3lGN3krSmlzVWJuTXlrWUxhZmpHMDBPZ0kyZWpQMnlpcnd6eHJCYytl?= =?utf-8?B?eHVsWjBmK3g3ZWlsSFBJUHlqU0tQUENBMHFUa2pQQVNpQVB0M2NVa0NRaUtl?= =?utf-8?B?cnJ4Y0JHci9ORW15ODRwQUR3Z0FoOXk5QkhJNVF3bUpCOGwzWnUvNC9ReUsv?= =?utf-8?B?RDhpdkw5TGEwdW5PSVl6V1k2ZkhEVUJBVlpHUktyYUNzNXgvNTZ6enZXVWFl?= =?utf-8?B?TFdGMzNqQ05aeFVuL24yV0JQNGFJanAwWGFsUzlGbTM1QlMvTm9Hb2VKZ084?= =?utf-8?B?S3NkT0tYVE9xMGF5Qm81djl3bHBlL21pa0pvdG15WHBLZXhSR1NSMlF4QWxm?= =?utf-8?B?WGJEYWg2TlQ0blAzbXExRjVFOGR5czVDbGtZdlNHTERtV1dVc2pnTDNpOURw?= =?utf-8?B?WXVVcTZxOUo5ZWFBejczTlNFTHY2UFk4bEc0WVE3MEJmWVV5UERJNFpIT2Y1?= =?utf-8?B?ckZMRjBReW9pMllhdXFkZHgyQWtRR1FCSW9YQWtGMGRrUVBiQWI4ZzB5dmpF?= =?utf-8?B?bU1UNVBITi9vMkhUZEdSdnJWU2I1OTQ3cGlCUmNlVzBvNDMzNnJlT011KzY1?= =?utf-8?B?RDZMT21BTDJ4S0tBSEU3M3BOaVc0MWRhZFJWVE9RTmVLTUsxMHpUMUZoT2Fs?= =?utf-8?B?SEdBUUJ2QU1YcVpRUkFKNDJiaklFb2syeDhyNGE1T0RXZ2ZPT0pqZXJYQmRN?= =?utf-8?B?WUVPSzA1NGZ4ZmZlUXh5NVpnbHBZNitEOVBOY2lqSlBDOEw3cFA0MHc0SU1M?= =?utf-8?B?N2FEZmJpQis3aDk1Q29SZlVoMmo5ckJVK1NTN2FNSktWQzNiZmFnOE5mL2Q3?= =?utf-8?B?QkNRaytIYndBc0ROTERyRS8wRlEzZzNLOTRPM1BSaW5XRXVBZGVYRG8zK2Zj?= =?utf-8?Q?iO8pweU1/PCjv6mJpmxBFJJbJ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e21dd235-e439-4f2f-fea7-08dabdd7f52f X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 20:14:05.9590 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LhAsEWS+xwdbg5rBDk9LkHuKKmyvqP4ak0coBrXWMqvU1cpQPts9tTH8IN/15O3/4E4D+dSOr4XkoFIHpqecnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7148 On 03/11/2022 15:08, Michal Orzel wrote: > Hi Ayan, Hi Michal, > > On 31/10/2022 16:13, Ayan Kumar Halder wrote: > The title is a bit ambiguous given that the previous patches were also defining GIC registers. > Maybe adding "remaining" would result in a better commit title. > >> Refer "Arm IHI 0069H ID020922" >> 12.5.23 ICC_SGI1R, Interrupt Controller Software Generated Interrupt >> Group 1 Register >> 12.5.12 ICC_HSRE, Interrupt Controller Hyp System Register Enable register >> 12.7.10 ICH_VTR, Interrupt Controller VGIC Type Register >> 12.7.5 ICH_HCR, Interrupt Controller Hyp Control Register >> 12.5.20 ICC_PMR, Interrupt Controller Interrupt Priority Mask Register >> 12.5.24 ICC_SRE, Interrupt Controller System Register Enable register >> 12.5.7 ICC_DIR, Interrupt Controller Deactivate Interrupt Register >> 12.5.9 ICC_EOIR1, Interrupt Controller End Of Interrupt Register 1 >> 12.5.14 ICC_IAR1, Interrupt Controller Interrupt Acknowledge Register 1 >> 12.5.5 ICC_BPR1, Interrupt Controller Binary Point Register 1 >> 12.5.6 ICC_CTLR, Interrupt Controller Control Register >> 12.5.16 ICC_IGRPEN1, Interrupt Controller Interrupt Group 1 Enable register >> 12.7.9 ICH_VMCR, Interrupt Controller Virtual Machine Control Register >> > As said in the previous patches: this may be my personal opinion but sth like this would be easier to read: > " > Define missing assembly aliases for GIC registers on arm32, taking the ones > defined already for arm64 as a base. Aliases are defined according to the > GIC Architecture Specification ARM IHI 0069H. > " >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changes from :- >> v1 - 1. Moved coproc regs definition to asm/cpregs.h >> >> xen/arch/arm/include/asm/cpregs.h | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h >> index bfabee0bc3..62b63f4cef 100644 >> --- a/xen/arch/arm/include/asm/cpregs.h >> +++ b/xen/arch/arm/include/asm/cpregs.h >> @@ -415,6 +415,22 @@ >> #define ICH_AP1R1_EL2 __AP1Rx_EL2(1) >> #define ICH_AP1R2_EL2 __AP1Rx_EL2(2) >> #define ICH_AP1R3_EL2 __AP1Rx_EL2(3) >> + >> +#define ICC_SGI1R_EL1 p15,0,c12 >> + >> +#define ICC_SRE_EL2 p15,4,c12,c9,5 >> +#define ICH_VTR_EL2 p15,4,c12,c11,1 >> +#define ICH_HCR_EL2 p15,4,c12,c11,0 >> + >> +#define ICC_PMR_EL1 p15,0,c4,c6,0 >> +#define ICC_SRE_EL1 p15,0,c12,c12,5 >> +#define ICC_DIR_EL1 p15,0,c12,c11,1 >> +#define ICC_EOIR1_EL1 p15,0,c12,c12,1 >> +#define ICC_IAR1_EL1 p15,0,c12,c12,0 >> +#define ICC_BPR1_EL1 p15,0,c12,c12,3 >> +#define ICC_CTLR_EL1 p15,0,c12,c12,4 >> +#define ICC_IGRPEN1_EL1 p15,0,c12,c12,7 >> +#define ICH_VMCR_EL2 p15,4,c12,c11,7 > I did not check this in previous patches but in which order are you defining these registers? My bad, I did not follow any particular order. > I took a look at arm64/sysregs.h and these regs are placed in assembly aliases name order. > So for instance ICC_PMR_EL1 would be defined before ICC_SRE_EL2, etc. This makes sense. I will fix this in v3. > > Also, I cannot see some regs like MISR, EISR that are defined for arm64. Did you decide not to define them > for arm32 because they are not used by Xen? Actually these registers are not being used by arm64 as well. A grep for "ICH_MISR" or "ICH_EISR" did not return any usage of these registers ayankuma@xcbayankuma41x:/scratch/ayankuma/upstream_xen/xen$ grep -ri ICH_MISR * xen/arch/arm/include/asm/gic.h:#define GICH_MISR       (0x10) xen/arch/arm/include/asm/gic.h:#define GICH_MISR_EOI     (1 << 0) xen/arch/arm/include/asm/gic.h:#define GICH_MISR_U       (1 << 1) xen/arch/arm/include/asm/gic.h:#define GICH_MISR_LRENP   (1 << 2) xen/arch/arm/include/asm/gic.h:#define GICH_MISR_NP      (1 << 3) xen/arch/arm/include/asm/gic.h:#define GICH_MISR_VGRP0E  (1 << 4) xen/arch/arm/include/asm/gic.h:#define GICH_MISR_VGRP0D  (1 << 5) xen/arch/arm/include/asm/gic.h:#define GICH_MISR_VGRP1E  (1 << 6) xen/arch/arm/include/asm/gic.h:#define GICH_MISR_VGRP1D  (1 << 7) xen/arch/arm/include/asm/arm64/sysregs.h:#define ICH_MISR_EL2              S3_4_C12_C11_2 ayankuma@xcbayankuma41x:/scratch/ayankuma/upstream_xen/xen$ grep -ri ICH_EISR * xen/arch/arm/include/asm/gic.h:#define GICH_EISR0      (0x20) xen/arch/arm/include/asm/gic.h:#define GICH_EISR1      (0x24) xen/arch/arm/include/asm/arm64/sysregs.h:#define ICH_EISR_EL2              S3_4_C12_C11_3 As I see, they seem deadcode for me. Do you suggest that we should remove them ? If so, I can send a patch for this. - Ayan > > ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 04 02:28:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 02:28:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437224.691437 (Exim 4.92) (envelope-from ) id 1oqmRM-0005dw-Sa; Fri, 04 Nov 2022 02:28:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437224.691437; Fri, 04 Nov 2022 02:28:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqmRM-0005do-N9; Fri, 04 Nov 2022 02:28:16 +0000 Received: by outflank-mailman (input) for mailman id 437224; Fri, 04 Nov 2022 02:28:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqmRL-0005de-Nq; Fri, 04 Nov 2022 02:28:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqmRL-0002qB-L3; Fri, 04 Nov 2022 02:28:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqmRL-0003SI-2k; Fri, 04 Nov 2022 02:28:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqmRL-0001YX-0g; Fri, 04 Nov 2022 02:28:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6dstfXB3DFSIOL40IMcFrDM7tP7L198v57YI15l6Q0Q=; b=2D6NRwCcF39Q2GpOA1uJdhbMT+ FICU+3Xh4s1Axir2Yot0g5tKe2tgKYnNvZq+sr9nLyhwtB+aadnlJ41YIhL+uJWhszzr4+bs+aCqo 7Y87AmgWsgb+8Cpjmhyk5DVEsOjeV6R2zHYGIk7zFPVZ8q8f4uoMJR8ccd0eWGYVF8uw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174603: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=8e5423e991e8cd0988d0c4a3f4ac4ca1af7d148a X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Fri, 04 Nov 2022 02:28:15 +0000 flight 174603 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174603/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 8e5423e991e8cd0988d0c4a3f4ac4ca1af7d148a baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 27 days Failing since 173470 2022-10-08 06:21:34 Z 26 days 42 attempts Testing same since 174603 2022-11-03 13:11:06 Z 0 days 1 attempts ------------------------------------------------------------ 1539 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 144959 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Nov 04 02:34:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 02:34:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437230.691448 (Exim 4.92) (envelope-from ) id 1oqmXU-00073m-Gn; Fri, 04 Nov 2022 02:34:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437230.691448; Fri, 04 Nov 2022 02:34:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqmXU-00073f-E2; Fri, 04 Nov 2022 02:34:36 +0000 Received: by outflank-mailman (input) for mailman id 437230; Fri, 04 Nov 2022 02:34:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqmXS-00073Z-N0 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 02:34:34 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60051.outbound.protection.outlook.com [40.107.6.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 368f90b6-5be9-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 03:34:32 +0100 (CET) Received: from AS9PR06CA0749.eurprd06.prod.outlook.com (2603:10a6:20b:487::35) by DU0PR08MB7737.eurprd08.prod.outlook.com (2603:10a6:10:3bf::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Fri, 4 Nov 2022 02:34:26 +0000 Received: from AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:487:cafe::f6) by AS9PR06CA0749.outlook.office365.com (2603:10a6:20b:487::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 02:34:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT046.mail.protection.outlook.com (100.127.140.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 02:34:25 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Fri, 04 Nov 2022 02:34:25 +0000 Received: from 203ee45efe32.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 630CE2A2-FC6C-41CB-9835-76201F7C5587.1; Fri, 04 Nov 2022 02:34:19 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 203ee45efe32.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 02:34:19 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB6332.eurprd08.prod.outlook.com (2603:10a6:10:258::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 02:34:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Fri, 4 Nov 2022 02:34:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 368f90b6-5be9-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Wbo0WZMES99eWhGddc52bNu59go2GkSyaPEvGmFGkRYq/slp0drhXt8LaVhHqaMS8p5Ym+dgAKJRuXypUCV8m9mWU6MlOpzDmnSnroR9lJ7lQo+pvgUKawmTyLwss/IneZP85+jZt7aQfwlMwzcZvlYBBqqiocAqFq0XyHXEvJUsNF93FwWDkB9OwD/mJaCDNWeD5pTeUsN2IOaRC8Of6ywzWZ6ToaqFGzhS8gaEFCiEhvz0GmeGXkaf0nUgLZ/FZq9rNJGAuKea8P6erKLJMgOYSRlKLpCNNxYNM73Oa443q+o3Ah1eso6O4+AMQoe8mbbLHedQkw4OlUaDb2X34A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=23qKp8ButlWL4cXYmnm1YOIdtG+G16PRwEGbMk8Vgmg=; b=IwJdtFjtm6wD4GuwpdcAtriwOYOicDUf0Ob6qBWWb7pyju3twrAPfQTDL9OvfV320Wg0Uo+4cltlnwwNfU8dFAXJ21hJTZ+4lhNYpQPeceLC09zfYDeAFitl/XexSgb0gB67RaXv3Tt6EGw0IPHRS+FHwU8MR9FL8XfME840gPi5+LB0AWu4LtihZQ31nrM07fkdZPABX7/16tne4BsEJrY46/DDP1tGSjO8x3uxVXMTuUZxxYuVNwP5v5w/x74VVVwfq/FIONUufoc58zSqOdATXEu5fMB3WFpHcnk90u3HlmCvECvpnSotXe8hWh2EnVI8Am6w5HEvvRciTukIpw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=23qKp8ButlWL4cXYmnm1YOIdtG+G16PRwEGbMk8Vgmg=; b=LgCUvHVt+flEzztU08kTMVUMGS1VuBM4FdL26dnweyk9p5D7xsg7o0dtLTpJrXlooRRbgJzkX88ji1OhKiP18BjqBFieLQZ49/1yEqsaSG8d9Q6n8C3sLg9TLcMK+xv3Rhny8DECksNIFc0ApWhTI147tc4gT0Fmah/JpLF45Lk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MruC0lOsSv3abyAPShdVLDD5FGQ8S7ltajoPpG+1FgxAJI2pH0S/PQTITh+NzQ4AcxbUFUBGnz7pPoDcFz7rAt9TYfaob+rmlwrqigY/QoMhLwYFBEzdOsbDuovN6/SfzWq8NBHw3av10B1pnMk1wGGIjprnri9uxbI2oENTHsch2vLpyqM9SlvGmF0C60sNNF0TWc8aGQ8ljCru1ExhKL9M2o67Bqqj54g2mHPOrU/6JrBCHme0zgebvvFeWGHt2pfFSGrEqcIX97DR6/LbR90LXxeBhFIYm9MS2AMlOxt6st2291IwaEUeVEA5nA2KebgoYlkah8goGt7CFuF22Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=23qKp8ButlWL4cXYmnm1YOIdtG+G16PRwEGbMk8Vgmg=; b=SOZ3W4KSdy3nufyDxgmEUImHiUFSS97yln5YqUEqccYyV2o+LkHDXq1oooKmrCVMmpx2e9S7NkRWtwqskYL83yyU+rvgTI3Fgi5fYeAwcF0YtDd7mRWZEem2PxubZbaCNTVI/1s8ZqiIMAsRuS1SoF0KHuBY19HHH+5dJb0seVrBfXtin/dbFg12aazbnnUscyVmwRQ8ms/6BqSodScZznB1o81wK9VrEp3xMx+GfAoBDv3ke44sr6wN3ZGv0hnCBxTOpFI4MU76/1Tw0ify9WYyyVCBwZ0frPYyKUpRXStnP7WEPQPOx3NajF2dbwItY4KDJ/pnl/OjIY/p8LorLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=23qKp8ButlWL4cXYmnm1YOIdtG+G16PRwEGbMk8Vgmg=; b=LgCUvHVt+flEzztU08kTMVUMGS1VuBM4FdL26dnweyk9p5D7xsg7o0dtLTpJrXlooRRbgJzkX88ji1OhKiP18BjqBFieLQZ49/1yEqsaSG8d9Q6n8C3sLg9TLcMK+xv3Rhny8DECksNIFc0ApWhTI147tc4gT0Fmah/JpLF45Lk= From: Henry Wang To: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= CC: Jan Beulich , Kevin Tian , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory API Thread-Topic: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory API Thread-Index: AQHY1AgeJwq4WhKefkGyVS1JhkdRo64QKSwAgAG7SUCAAH/pgIAZrF0AgAClVGCAAR6tgIAAbuMg Date: Fri, 4 Nov 2022 02:34:16 +0000 Message-ID: References: <2214fd86-0cfa-58ef-39db-6f913a9de75e@suse.com> <2ee2c1f9-a6bf-7641-16fa-ce2ea90f377b@suse.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 947DB807AF30744E98408F7E2B3B5F5D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB9PR08MB6332:EE_|AM7EUR03FT046:EE_|DU0PR08MB7737:EE_ X-MS-Office365-Filtering-Correlation-Id: ef430195-1947-4b2d-851c-08dabe0d1709 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JO5FV/4n1tYoPzpaNDLFThN7ubvybOS5B4bgTPP0/qljMLRdO89LLFI9xkLMcX+JYhUXLcL0XXQX4GZLMkrxDDGfUhGe0WFB7d01zj3vjyRjizbQfGS6IXzuLk/gev01PYdIaL4Dl81aRgbc+CSdJrH1Cxo0flE04BvPh6/3Z0XNo0ptjMq0XXQUJJYauiv/Vi3NVzXoS87QQnR2Y63ZQk4fo8MVUp/gC2xtSf5tBGlsg40iSI4AsZpbpexiwFyuwyeM30LmKQki2V5mngEyBaxrX4aZEpVJuVLQq/Vmxh4FaQbrGk/1LZqrpVyy/yDiUq3Oc6H0H/3AIdcFDPMPywIm4LnendcSX7teJyXYSvZy1uQTdcakzKRmTg027BNPoeSSMwTZzH8gbUZ0K53qCaWX/kilHRvyu5xtXYe0t6Jen+lkFDFepCyt0U0J/G/RSteSMnAW3N8uxsJx3NcBm+Fk10pf65TdZUxnNmx2buUxUBokEXtf7p+rvgR0FAwEMo2V3fqKZMsxmaAPXtIOOfh86ZF5aQLKir0WOo9oUK9ETemCSmPXGRvGO7SNH+UQCVmJOo+woi1fH8UHvlB70JHc8N+V9MGVotfqDviSolFEXQoNCJAetzKm7Hwb61qL6tR5wryjrVIqi7uwJvj6riKIwqvTCY3uajgh+28VJX/QYHUZS1ZHPOYbzEST/gzyYS/lcRCCDOmCZxUI21pxsGzP8Ekz+DKUTsW4e0GCjtzdq65FVJ6c/rFyNCob7rpbB/kutrui0CIViSKgZwDShA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(136003)(376002)(346002)(451199015)(38070700005)(55016003)(33656002)(86362001)(41300700001)(66446008)(9686003)(64756008)(66476007)(66556008)(4326008)(8676002)(76116006)(66946007)(26005)(4744005)(71200400001)(5660300002)(8936002)(52536014)(478600001)(7696005)(6506007)(122000001)(54906003)(6916009)(316002)(186003)(38100700002)(2906002)(66574015)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6332 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a4f16303-5446-4d1b-9651-08dabe0d11ce X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IQAof5Idf/jG9PV7ejbcjLVI8bytknEDP6kXiffcNRZbt99+ZZusv6xJx4I1NUewjlDVZkeuzGdYH4CC7rr2fR1ztIobmQ7ZTaT7pACQKarirdSZQk1sXlKxHhIE30oO4hzo+T9K3PtWEMPeO37R6AD2hG63eF4elCkzUc7/FdD80waFtzBHkHosnuOrbDpraTDglhTgO82XaCQzD85K7LCQuQUU8vFplMKHen81TLrGzBueedmON2Xqkf+8zemAx7Gv5cIqWd8NRGRcKEDhokDTP9eSrEb1JknahQn9SwUWsCTSM1DUNnd47itPYhzi0XqHdXOg+eLwPsQZkbx/89pMI+VOAAlbh6GUnMahNHWJb/GCdESjvi+aAEMm4IghYBMQDCv0xpMkYtWfrYCd14HcKlfZqXaQXiEYxAeF8hIWg1pF+7lrzssORUvCNhEwfZXlUO7eMhSNky8b6BGBQqz1QwSQV0da7yv7c9746dSsFTS43QI8N1hbD+i8iGgiBjR9hiOnzoNAmny8msA2DHCyZZmsLyBNheo86H5+Ojj0Qkcjm2JsO7lR002Xwp6GlP0PT7C9+p2BGxtoKV4oNjWcN+/rKV/HUxLtV38R0AkXpmYiLtPVUptTvbqwydD2rmJOnonnjxAqJXTn8uoPzhKmiN4NlFlHix5rVO4kAjVlSXwgynO1/FwUJBJ8Gx8gUXX3ggdjPtXIzxORD64ortOipn57Pcq//kmUgUSlPlaW3z9KWxx1wxVRV7cUTfBU+/srMRINfqCmeLth87M7DA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199015)(40470700004)(36840700001)(46966006)(52536014)(40480700001)(8936002)(41300700001)(6862004)(478600001)(55016003)(33656002)(5660300002)(70586007)(70206006)(316002)(36860700001)(8676002)(4744005)(356005)(83380400001)(54906003)(6506007)(4326008)(86362001)(81166007)(26005)(82740400003)(186003)(47076005)(40460700003)(336012)(7696005)(9686003)(66574015)(82310400005)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 02:34:25.5604 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef430195-1947-4b2d-851c-08dabe0d1709 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7737 SGkgTWFyZWssDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gDQo+IEZXSVcsIG1v c3Qgb2YgdGhlIGRpZmYgaXMganVzdCBleHRyYWN0aW5nIGxvb3AgYm9keSBpbnRvIGEgZnVuY3Rp b24sIHRoZQ0KPiBvbmx5IGZ1bmN0aW9uYWwgZGlmZmVyZW5jZSBpcyBhIG5ldyBjYWxsZWQgZm9y IHRoaXMgZnVuY3Rpb24sIGFuZCBtb3ZpbmcNCj4gb25lIG9mIHRoZSBjaGVja3MgKE1BWF9VU0VS X1JNUlJfUEFHRVMgZW5mb3JjZW1lbnQpIG91dHNpZGUgb2YgaXQuIFNvLA0KPiBteSAoYmlhc2Vk KSBvcGluaW9uIGlzLCBpdCdzIHJhdGhlciBsb3cgcmlzay4NCg0KSSB0aGluayB5ZXN0ZXJkYXkg SmFuIGhhcyBjb21taXR0ZWQgdGhpcyBwYXRjaCA6KQ0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0K DQo+IA0KPiAtLQ0KPiBCZXN0IFJlZ2FyZHMsDQo+IE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNr aQ0KPiBJbnZpc2libGUgVGhpbmdzIExhYg0K From xen-devel-bounces@lists.xenproject.org Fri Nov 04 02:35:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 02:35:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437236.691459 (Exim 4.92) (envelope-from ) id 1oqmYO-0008Gj-U4; Fri, 04 Nov 2022 02:35:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437236.691459; Fri, 04 Nov 2022 02:35:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqmYO-0008Gc-QT; Fri, 04 Nov 2022 02:35:32 +0000 Received: by outflank-mailman (input) for mailman id 437236; Fri, 04 Nov 2022 02:35:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqmYM-0007PL-Ji for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 02:35:30 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20060.outbound.protection.outlook.com [40.107.2.60]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57ca3ecb-5be9-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 03:35:28 +0100 (CET) Received: from FR3P281CA0027.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::14) by DU0PR08MB9584.eurprd08.prod.outlook.com (2603:10a6:10:448::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Fri, 4 Nov 2022 02:35:24 +0000 Received: from VI1EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1c:cafe::80) by FR3P281CA0027.outlook.office365.com (2603:10a6:d10:1c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 02:35:24 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT014.mail.protection.outlook.com (100.127.145.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 02:35:23 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Fri, 04 Nov 2022 02:35:23 +0000 Received: from a2637bde196d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4CEFD1D6-FEA1-45C9-BED9-B75556D0CDB7.1; Fri, 04 Nov 2022 02:35:17 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a2637bde196d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 02:35:17 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB6332.eurprd08.prod.outlook.com (2603:10a6:10:258::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 02:35:15 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Fri, 4 Nov 2022 02:35:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57ca3ecb-5be9-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FjH+T3kKk28uGmsBlM0/n9N/rTvkBPaITjJMbzEoEolnYHdiqdNEmQkZaUscf0kTMRpejDNxk8Ouq5Js3SzSQWaSa78NiBDV2OpdVs6P+VZFzDTM9Vc7Od5CAPgUsp+AoPdAvpa1tMxtGsCHbDuQPSWacx0EJP5nmjp6ToBcmM8Cz7W0TPfrcF2f9J8nqID5a25OQEDawDr2Lc3CfwyWyexpsm1Waggb8pmWWcpjtDijhZu9Ycsr1SaU0TNAgqUidOyppJILVX3F7QmdjPdDt5Zjal+Pf3l3UKbS9vloV+wg0V9fG5lf1kBPs0wNA8ZH35z65XDGoDxTv2WouzRTbQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RBn5TQGgxiVIC4cO9L5KU+xwOOb0iRS6HUmpc336E3M=; b=kVNxRjQtPxjERQgUCHzjzWU6AsuAUwf1/gmKYdexexdmt1jcFfc6GNQGPAQs6kAdP+DYPAytq52dYLAdDvi/StOyBULNQEOPAH38+SE1mvtxKxiHcvdtdmMUWNrGcVddL/QCq+WxRYVVPtCDXGDac1iNPgYfHLcpnd9kj1ShP8SIXFx1OzMwQHHxA7GZ/SeumWHiaY5nN+Aw0FDBK5c0/HxXhjteezlTJ4jqH0P61+Bd4yb5iFHWXsVAq5W5gtsOwou5vOTh25ezJKM0iZekMDyiP/U+kSAAbUTnAzJgKauHYUZ/rGEnzFk1xPi58ZnRuvl6KPlPnMBDu8vgPvPcCg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RBn5TQGgxiVIC4cO9L5KU+xwOOb0iRS6HUmpc336E3M=; b=vKUMrn9gnvD/yfVJuKqidlmbGxmXnH3F3zpGZ9DKPU/rpTrTu8zAfH25IhR9H3dnMHZc2q1yQoJZgbVF8Mkc3F3r0RsiEAklV0gM9puzWitz/PHa1PAXrwCQJL+bY6DKBv8F5znWex1QPWbbi34VnUs4gE5uKzZvX9jKtW8F1+g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EXF/Xz2a1V2bLsMkKm1EG5bnfE/nOVABhSWlEmfZdbag85NHx6j0EJLkOKh2tiQ47H34/au2xWJvg43F9ypmquEL3HFvYisPp0IXQCT9VMWnatbvZPXpBiEx8C1FeOpJye6+apbv092pL+Uav/2BNxaZMxSZH/p9mlH6yEmWHQmZax7lq1jYOvOsy5NXFJsQl48/VOZgIkldudZsbeWuRPboTrvXjYonPa6IGHxyDMmv4uTmZ2ZmDu/7tjPjyX6ZDnhdMV2vFY6TGhrK4f2Irh4hZPuzVQvE61Coo8OePyZ9F25GOqSXvcPMzzT+h0dTIotd2WPX/KSUfLtgbpFo6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RBn5TQGgxiVIC4cO9L5KU+xwOOb0iRS6HUmpc336E3M=; b=JUiC8Xj6JITdAhitlEWSnbizh1c+WLYd+eLdl95A/U70/DKf6LHg0lZxcLmYjj3Jy/2/1xQiyxOnIBod+mGUXUcez733vHiL8Oh0qATlSh8yOOtbfIkH3rko7ApVKa0t1dnUo2rE7zcWt4GQygOC2b0s0Ti2c4m8ca7+rhJyQkGZl5bK89kzjwmO4ZM1Xqy4c3ij1fqTyatpMT17RyuDWtFXXOAh1SKBS5RGz2rVxX2Os7fDtldhn5qiFk5SHTyaXGd7HhlTs1KjjmcckKGeAWaXOR6HwUYDshFoPCwBx/EvKIzAsu7Iy/T+Nttn3BGLyMAZCoKtULaojRUOq8vArw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RBn5TQGgxiVIC4cO9L5KU+xwOOb0iRS6HUmpc336E3M=; b=vKUMrn9gnvD/yfVJuKqidlmbGxmXnH3F3zpGZ9DKPU/rpTrTu8zAfH25IhR9H3dnMHZc2q1yQoJZgbVF8Mkc3F3r0RsiEAklV0gM9puzWitz/PHa1PAXrwCQJL+bY6DKBv8F5znWex1QPWbbi34VnUs4gE5uKzZvX9jKtW8F1+g= From: Henry Wang To: =?utf-8?B?RWR3aW4gVMO2csO2aw==?= , "xen-devel@lists.xenproject.org" CC: Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: RE: [[PATCH for-4.17 v1]] tools/ocaml/xenstored/store.ml: fix build error Thread-Topic: [[PATCH for-4.17 v1]] tools/ocaml/xenstored/store.ml: fix build error Thread-Index: AQHY77Qw3hE4IDWTwEGKql4errGNq64uDKBg Date: Fri, 4 Nov 2022 02:35:15 +0000 Message-ID: References: <5a453393dad1de8286fe5db16504d3db2906eef8.1667500970.git.edvin.torok@citrix.com> In-Reply-To: <5a453393dad1de8286fe5db16504d3db2906eef8.1667500970.git.edvin.torok@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3A5CBBCC00607A4D92DE5F76F56424A0.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB9PR08MB6332:EE_|VI1EUR03FT014:EE_|DU0PR08MB9584:EE_ X-MS-Office365-Filtering-Correlation-Id: 40bc9559-05f4-4a52-434a-08dabe0d39db x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KsjZplfEOrAx7HBp1YAmXHq2DJaAx6h1D6U7mJTnWPjw1JShA3qxQ5GV1/QY+BWM1R20bd3jmEiZqT3YmkM4bZArrbxrGnScrK9kKayl1wAAemESWYMHCBuH53apQKCALQbzKi7tEJw+j1STy9dJ0MLkvMS8uT0rIENBVm7wobMZR6O8MpHBccCIgA1kyXn2t5TC2asRRSKOcxlcRu1JO+t2n83tqOc/UiTWeYvAlAygpdo5Psv8plmjwoNpC8s3kHA+ZEzgy/a7ati02JaUXjbYXzrsAGzrB3m6xkUZNk+N9Y1qLf0t2Rztnua9AlfCcrhFNQvKrfT10VdiE4/5MqHFkf7ZwuLFrGd8w+G4Enf63DtqHWLZjzq+DUSSrmlnjr2pK7mWSJ0DrmWVuQDLujT6I/PGjRYOuglOqcDydB1BKCfRc4wvNwgvzYAnn/FZne5YbtHPmduDRflXZXjwYaCsbscnlYjEYsH3k27qv0ucg3qNE93Jb3zD9Ss930354KqmT6oFvez1pscMKFNfPo5VaG3la25M3FyzaHmrvc6pBcP0vrOzShangqwSUhWqUyAl5BMmoCXYV0MYHl0cCezV5RqsmBiphZxZVVmnVtGPyT8+63iagtkAY3dG56QsMwSLzpKvOuuZpF/of4h53HVwTX1To7LjNiNDaNKeq/UnAIKlKmjYkMkOJADBfggi4WgW2b5leeeNL+KrNYaKW/Umk/9jWYXmI3Z30cs6diomrjkvzR6WH4kMfazmdMNIiH0K5k49Z24OnPj1QuCUIw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(136003)(376002)(346002)(451199015)(38070700005)(55016003)(33656002)(86362001)(41300700001)(66446008)(9686003)(64756008)(66476007)(66556008)(4326008)(8676002)(76116006)(66946007)(26005)(71200400001)(5660300002)(8936002)(52536014)(478600001)(7696005)(6506007)(122000001)(54906003)(110136005)(316002)(186003)(38100700002)(2906002)(66574015)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6332 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7b69a064-74e9-44e8-e9e5-08dabe0d34ee X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ij3ILSOGDBC5hFlNi5r3XlnY6N9vR4J4PXHMHpSWYNL1HcyCazVZ2QnWLYl/K2akTt9CcqA68D3HQNH5TFfdWJjPzvfAhhnVO14BonHeH6dmBsSpJnV1jWCNJlOKKV+K2c6i6i0tWUSGYP/pO9c51lNsDyiIcIy6pj9Ii4KFYP7DJmwl6GoVDC9q+WRYSXB/9ivpsoeWxEAh2GDUMDumJINmUucAf0hzaah+O2CHjKD0S+1bHswfz0ZGBqij/i0Tx8XFcXEVBkXwc5eklE8iaFoXIHWju+q76kWhx6zrCYmSwJhXLhl0PWOPoPx0fGwURiCTAK8SSsB/wlvsSD59rcJ7skC6Ra90Auap8K+f1BBdHA8GkOLQ8zrYI1esl3tqYfnB3de9LpCcKCv01zAKQOj/bm2/egY4Ao6GMX4YZhbAFzL2HF84q095X3cfrUxlYCGC5TjrcAJcw0y7cXN85fTz49WBGtk7jUIeD9z5U5/+xUEYxzHmdPj6ADBCv0jpv3c1A6yiR4JazYi74gqeOsuym39sGm0mF1I/XIsSjAp5CDNXIIvLvU2aIWFAYsphMJIB384LrQVnlad2nOJLmTnWK4F9wDdwOCv2Vd1q3vxNh3K5INkmaUVTW7hhdZkQRpJThJPjBXKVdWtOd3HoB/Jrock1Zm+OBpNN4VolBQkPT6Z8S+y5GNwifWyUypGIHF9YanCi/9yob8IDJqg15qYs0yAWnC+WPCzCXuF41kvzpTIxJCZneens9niDEG3DwQTNfUd0dGXE3fBZNmXUGA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(39860400002)(376002)(451199015)(46966006)(36840700001)(40470700004)(2906002)(82310400005)(110136005)(81166007)(40460700003)(5660300002)(107886003)(66574015)(55016003)(186003)(83380400001)(33656002)(336012)(47076005)(356005)(41300700001)(52536014)(8936002)(8676002)(70586007)(7696005)(478600001)(36860700001)(6506007)(82740400003)(316002)(86362001)(54906003)(70206006)(9686003)(26005)(4326008)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 02:35:23.9776 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 40bc9559-05f4-4a52-434a-08dabe0d39db X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9584 SGkgRWR3aW4sDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogRWR3aW4g VMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogW1tQQVRDSCBmb3It NC4xNyB2MV1dIHRvb2xzL29jYW1sL3hlbnN0b3JlZC9zdG9yZS5tbDogZml4IGJ1aWxkDQo+IGVy cm9yDQo+IA0KPiBCdWlsZGluZyB3aXRoIER1bmUgaW4gcmVsZWFzZSBtb2RlIGZhaWxzIHdpdGg6 DQo+IGBgYA0KPiBGaWxlICJvY2FtbC94ZW5zdG9yZWQvc3RvcmUubWwiLCBsaW5lIDQ2NCwgY2hh cmFjdGVycyAxMy0zMjoNCj4gV2FybmluZyAxODogdGhpcyB0eXBlLWJhc2VkIHJlY29yZCBkaXNh bWJpZ3VhdGlvbiBpcyBub3QgcHJpbmNpcGFsLg0KPiBGaWxlICJvY2FtbC94ZW5zdG9yZWQvc3Rv cmUubWwiLCBsaW5lIDE6DQo+IEVycm9yOiBTb21lIGZhdGFsIHdhcm5pbmdzIHdlcmUgdHJpZ2dl cmVkICgxIG9jY3VycmVuY2VzKQ0KPiBgYGANCj4gDQo+IFRoaXMgaXMgYSB3YXJuaW5nIHRvIGhl bHAga2VlcCB0aGUgY29kZSBmdXR1cmVwcm9vZiwgcXVvdGluZyBmcm9tIGl0cw0KPiBkb2N1bWVu dGF0aW9uOg0KPiA+IENoZWNrIGluZm9ybWF0aW9uIHBhdGggZHVyaW5nIHR5cGUtY2hlY2tpbmcs IHRvIG1ha2Ugc3VyZSB0aGF0IGFsbCB0eXBlcw0KPiBhcmUNCj4gPiBkZXJpdmVkIGluIGEgcHJp bmNpcGFsIHdheS4gV2hlbiB1c2luZyBsYWJlbGxlZCBhcmd1bWVudHMgYW5kL29yDQo+IHBvbHlt b3JwaGljDQo+ID4gbWV0aG9kcywgdGhpcyBmbGFnIGlzIHJlcXVpcmVkIHRvIGVuc3VyZSBmdXR1 cmUgdmVyc2lvbnMgb2YgdGhlIGNvbXBpbGVyIHdpbGwNCj4gPiBiZSBhYmxlIHRvIGluZmVyIHR5 cGVzIGNvcnJlY3RseSwgZXZlbiBpZiBpbnRlcm5hbCBhbGdvcml0aG1zIGNoYW5nZS4gQWxsDQo+ ID4gcHJvZ3JhbXMgYWNjZXB0ZWQgaW4gLXByaW5jaXBhbCBtb2RlIGFyZSBhbHNvIGFjY2VwdGVk IGluIHRoZSBkZWZhdWx0DQo+IG1vZGUgd2l0aA0KPiA+IGVxdWl2YWxlbnQgdHlwZXMsIGJ1dCBk aWZmZXJlbnQgYmluYXJ5IHNpZ25hdHVyZXMsIGFuZCB0aGlzIG1heSBzbG93IGRvd24NCj4gdHlw ZQ0KPiA+IGNoZWNraW5nOyB5ZXQgaXQgaXMgYSBnb29kIGlkZWEgdG8gdXNlIGl0IG9uY2UgYmVm b3JlIHB1Ymxpc2hpbmcgc291cmNlIGNvZGUuDQo+IA0KPiBGaXhlczogZGI0NzE0MDhlZGQ0NiAi dG9vbHMvb2NhbWwveGVuc3RvcmVkOiBGaXggcXVvdGEgYnlwYXNzIG9uIGRvbWFpbg0KPiBzaHV0 ZG93biINCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9rQGNp dHJpeC5jb20+DQoNClJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJt LmNvbT4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg== From xen-devel-bounces@lists.xenproject.org Fri Nov 04 02:39:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 02:39:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437242.691470 (Exim 4.92) (envelope-from ) id 1oqmcW-0000Vb-EA; Fri, 04 Nov 2022 02:39:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437242.691470; Fri, 04 Nov 2022 02:39:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqmcW-0000VU-BD; Fri, 04 Nov 2022 02:39:48 +0000 Received: by outflank-mailman (input) for mailman id 437242; Fri, 04 Nov 2022 02:39:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqmcU-0000VO-Ph for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 02:39:47 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f160d7ba-5be9-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 03:39:45 +0100 (CET) Received: from AS9PR04CA0059.eurprd04.prod.outlook.com (2603:10a6:20b:46a::9) by AS1PR08MB7500.eurprd08.prod.outlook.com (2603:10a6:20b:4db::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Fri, 4 Nov 2022 02:39:35 +0000 Received: from AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46a:cafe::73) by AS9PR04CA0059.outlook.office365.com (2603:10a6:20b:46a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 02:39:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT018.mail.protection.outlook.com (100.127.140.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 02:39:34 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Fri, 04 Nov 2022 02:39:34 +0000 Received: from 444d75fd1051.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 25754052-EEE1-4E30-AF55-1EF2AFDEB121.1; Fri, 04 Nov 2022 02:39:28 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 444d75fd1051.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 02:39:28 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB6279.eurprd08.prod.outlook.com (2603:10a6:20b:294::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Fri, 4 Nov 2022 02:39:27 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Fri, 4 Nov 2022 02:39:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f160d7ba-5be9-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hPuDz7v8XI82wbDP2bNNucO3b8Px8nAjSkzyprxVkQOWgd1op1DvcmR0ZL2r0EYKK0T/4qSnDSMmYaUc6xX8EYt49zFYTHImMQa+rtld5DXMNp4FtbX8YKVgQuHlsesht5FLBBQGNISbmTd0KsG2ETdwHXAdE98Wr0qxmJizhqpUsoH/jsUF3wM6/IQtPpToMciMxT3NFYP3bv8UFGsekS2t9MYB2U2DxtNrmIOProVE4JdbdbJzX5OpoVBFjiI68A8dD2/++T8BPwSCzIaeQUO0OjqT6LZ99Z7MvGsDtcAdSpEDXXCWEQk01M/oGp5fzoXSPUdf422qnt6FZJnCRg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uKLhjeN6o45WTc5+DVVRmL+vTCD6wVUety8LtgAKsn4=; b=JMwm+9rpSccCwaE7NTUklSX/XzVwLd6VXYBuBZ4mm8OSR9NFghsyNKx/5AGWHH6WJ82w6JlpT+Kx3ZTasgERUiSCnMLFc5QhBOboorrvBomA0bqUfkyEBYINGUblkzcL8GTyp/YC2t25rsw0XiTANBXwZcmrdwxiarIoiIpRXtDTnDnh5jwhGvhtUMFF8WtHvPRdFyGWBGAPFXvV/UOUvk8iirXtc+7ODzTkobwsy5lT7dLmTFfHNOh4e7Q2v3gj7nGKGxCBJzY7oRot2e8sUB2GdS9ApMU2fajKZvMglAMXKeDnF5cuszStYgeiuKR+6Ano4urIDMwEKk2C0yGi8Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uKLhjeN6o45WTc5+DVVRmL+vTCD6wVUety8LtgAKsn4=; b=mAvQnigZBx9+fbiQOgbFjIYpiDMY6YPGgwZLdT9WePZzu4DQQRO5j0dc/lMnik7IUU9j5zLs819TRgZ+NrF+BF6X9yybq7KpWCjV1/IeqaBLXOIHBN7RiJrCMiqy6FlYewK0fOt0ZYmiUHZhIp+b3ijUwRgWjrNd8OWPMp4gA/I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JF3V/OSXKNeRKTDwFM/JL4DzAYD7ovpGlx1JMrJe1iGl+skP1BXf3KhkR2eZPEhQiCyvhhHASzm3yifm6CQYL9MTc+iiBoeEHQVCnMjkx6/C1CKbAEfZjC7rieRBIO8ECu0mMignfznVQLcmnb5dSd6dU6sJAAH77Ryx1T114XJA7eFuzs1TJoFX1F5XWXewm3Ikyw/lJdCdeS9MUIoL81Ye5Khpy1UEtTT1tdtcmV/8DDkcwi9z68U7aEGyGg5gjTOfOBuoKLAhuERIMjWfWtjtCBCIDNwDSe2is304ixizfA+W9VAqP1z4at1Ze0cIPK7xCSbi05Q43mVqRRiBQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uKLhjeN6o45WTc5+DVVRmL+vTCD6wVUety8LtgAKsn4=; b=BhvCNIYWi92knEbK5R0c+RdHbay8D3F96yi3NHJNf72JmTI91LvHdNMUUuLEFNa/lJcz/q3ZRzHjHDMWKByc8IASQeHb6Ltz7GKTKvp+GVkgbdWHCjn5x+QOEysy3xjBCCale3Nd6xyJoVkvF1/pX/M5Va28uJ8bskFWcyPLgbUpkqBdE8Jdqu0ektG93AwTZjVCIO3Rdy3M1Rq1/kaDuQdq8fpOMBEt+72W6ttHzlQxhLywSXyhc/gKMTo8NNNjhdSvej2Hpcq5fGXnfCYzpUqU3elF+Tma5yx33CGqOHpD/Bj+S6RvkFuXeirnv9sPVAWvFWKc2ayPDSjg6z2QFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uKLhjeN6o45WTc5+DVVRmL+vTCD6wVUety8LtgAKsn4=; b=mAvQnigZBx9+fbiQOgbFjIYpiDMY6YPGgwZLdT9WePZzu4DQQRO5j0dc/lMnik7IUU9j5zLs819TRgZ+NrF+BF6X9yybq7KpWCjV1/IeqaBLXOIHBN7RiJrCMiqy6FlYewK0fOt0ZYmiUHZhIp+b3ijUwRgWjrNd8OWPMp4gA/I= From: Henry Wang To: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: RE: [PATCH v8 2/2] drivers/char: suspend handling in XHCI console driver Thread-Topic: [PATCH v8 2/2] drivers/char: suspend handling in XHCI console driver Thread-Index: AQHY1Agq3zcKCbhszkCMLD93E3RjZK4uRM4g Date: Fri, 4 Nov 2022 02:39:26 +0000 Message-ID: References: <5ebc3a1176fcb9f1e4852826edfe67fe62062d05.1664458360.git-series.marmarek@invisiblethingslab.com> In-Reply-To: <5ebc3a1176fcb9f1e4852826edfe67fe62062d05.1664458360.git-series.marmarek@invisiblethingslab.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D2E23BAE300A474E8A931BA905305220.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB6279:EE_|AM7EUR03FT018:EE_|AS1PR08MB7500:EE_ X-MS-Office365-Filtering-Correlation-Id: cee3a09d-7808-4442-cb89-08dabe0dcf69 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2rk33ski/B6YK4kbZzLgHcVImd7D/Wn5llJRasmF2uRIn1DmiIt/rBHDxw+qFSuhdfKFxWSAWJOHW6eyQOo/ifOAlKgobydnUCkcgD2aJcbqhGImKVUiiugfbFfPqfmZGI7ma7GIdpquvKXQ6EPN4sTcCZWPHUNxAtvJ5pVBUAFj2meo059jJQOsx9fO/0Uyu3RM/hVS2xJp/84gZ7eZtcP4nnHNBF54i0w+Ir6iiBf+5HAJatsXbkEcHoiwAOi7M44upBesFMZOkH/k1h4SeYADRGOVzl+QZMM0ddi0ACVUMZadRJhsXs+gBeGi+XodaLE10/LyjpGIdNN0zCDrxg+TGof5+hqgx07eXVWzjEdPKBRIeMZYXsGieHi8pprNjTJ7cbk5lZk7jpwq96b6ltpr0YF8Lw1UrhJghRJkYY4ZZlKbxCwE1U7jp6Cnj2bxXfet2bnSrvp6DzgmU04neKwOeF+OV8YVqTFGXy0tlUkINfiGUuC0GU2XzXNfyDpZ/tlV2q43nG9nIhN1DHqDd/p2df6IkHetCzB4iMUEyggZhk17L8m0qxXzO5vNUAGM2kiF5KVZh23pjHGH4xxq14Xwxjyk+ELvkk8OLV0QeIyLrKWVeLGldLbkzQ1DhWtKOUe1XFLwRgFJ5sC6TspHAdg5XgbLOPRaDq5b5YZm+J090uTwCnEI6nwZi4ET/oTCfVrZb82tGxRPiONs5EbzT0jLayqwaudpf4bRtJuQS1/Ts8z3MleP/f9WeKGWQ/vhPd6v5ME67GEDdwCtJCFdaA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199015)(55016003)(66574015)(83380400001)(33656002)(38070700005)(86362001)(122000001)(5660300002)(38100700002)(2906002)(41300700001)(8676002)(54906003)(52536014)(4326008)(7696005)(66446008)(66556008)(6506007)(66476007)(64756008)(76116006)(110136005)(186003)(66946007)(9686003)(8936002)(26005)(316002)(71200400001)(15650500001)(478600001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6279 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fc776374-2bf9-4e5c-ae63-08dabe0dcab0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b7qHpeptOJzfOgnmQPAJn0s4BEzVnH0jC7kphsfJ66xnyz9GcjUei8qWOQYPsOv7V8t+75RY/0BeWvYEmR9xQkCswP2v+O2EwpxAvT7iZNSSV4Nopwx7CdbiPWNOMt9h+tg2+r0QV+gZ6HYNhKDUqx6ddixG7g9sHfRKV/cAM2niKTs4eLbpz6sTyg40N+6nX+tu+M4JfVTCBiGDYYCwsfLmDWuOBEsdspy3uIaQp0GbWX/tUELJc2Zv0LCOvNl9Gx/Vl5WTekGqIfk92MRR9TtO+Lvlo2P+xjZLmHkg0Qug4JlT/Vb+S7mja2uigUJAPUe9QbCM0LgMEC+QxiXwoJZ0YycfFJbLz6eoYpMaPnJYj8ckZ7jT0KUyVsEVHmIVf0IUc7OwOpWmaIaEJol+A8lk8iMNKTcrFmT+P8ZDrHGEUnronvmktBC+svB31824f/TrLl27boCtxwEu37D6oHWLCHnqNO5UitXfempcHMBdvspFHnaQnqIzpRGMSQJJE9LoLBXAfARZJ9WWweTKBJxV2gFoRYlBYxHN7wswIADHKTNaH1Idf+EmVyBJMZBV/OGlaSzbkmOyKS2snw2qA8FsjLzUQsRfIuAAMaWAYzACy+FcAWwndDE3HHoq5mQoQMxlc1PRBttA4rT2e3x1Axuck6/90LYnt+atpoi1hUrsLCBHMUA/K+iP9ceYwyu+dt3VCpyPGJGNQJGgZQ4uMaHrry7aVkt344+Qur/P7ahhC/fCMFtLmbRElnjw299frPxGwUaX329C2OWAm4u9lg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(39860400002)(376002)(451199015)(40470700004)(46966006)(36840700001)(83380400001)(33656002)(81166007)(186003)(47076005)(66574015)(86362001)(356005)(36860700001)(82740400003)(2906002)(5660300002)(9686003)(70206006)(70586007)(52536014)(4326008)(15650500001)(41300700001)(7696005)(6506007)(82310400005)(110136005)(336012)(54906003)(26005)(316002)(40460700003)(8676002)(8936002)(55016003)(478600001)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 02:39:34.8922 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cee3a09d-7808-4442-cb89-08dabe0dcf69 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7500 SGkgTWFyZWssDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogWGVuLWRl dmVsIDx4ZW4tZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9m DQo+IFN1YmplY3Q6IFtQQVRDSCB2OCAyLzJdIGRyaXZlcnMvY2hhcjogc3VzcGVuZCBoYW5kbGlu ZyBpbiBYSENJIGNvbnNvbGUNCj4gZHJpdmVyDQo+IA0KPiBTaW1pbGFyIHRvIHRoZSBFSENJIGRy aXZlciAtIHNhdmUvcmVzdG9yZSByZWxldmFudCBCQVIgYW5kIGNvbW1hbmQNCj4gcmVnaXN0ZXIs IHJlLWNvbmZpZ3VyZSBEYkMgb24gcmVzdW1lIGFuZCBzdG9wL3N0YXJ0IHRpbWVyLg0KPiBPbiBy ZXN1bWUgdHJpZ2dlciBzZW5kaW5nIGFueXRoaW5nIHRoYXQgd2FzIHF1ZXVlZCBpbiB0aGUgbWVh bnRpbWUuDQo+IFNhdmUgZnVsbCBCQVIgdmFsdWUsIGluc3RlYWQgb2YganVzdCB0aGUgYWRkcmVz cyBwYXJ0LCB0byBlYXNlIHJlc3RvcmluZw0KPiBvbiByZXN1bWUuDQo+IA0KPiBTaWduZWQtb2Zm LWJ5OiBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kNCj4gPG1hcm1hcmVrQGludmlzaWJsZXRo aW5nc2xhYi5jb20+DQo+IEFja2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ DQoNCkFzIHBlciBNYXRyaXggZGlzY3Vzc2lvbiwgdGhpcyBpcyB0aGUgb25seSBvbmUgbGVmdCBp biB0aGlzIHNlcmllcyBhbmQNCmFjY29yZGluZyB0byBBbmRyZXcsIHRoaXMgcGF0Y2ggd2FzIGFs cmVhZHkgYWNrZWQgYW5kIGVudGlyZWx5DQpjb250YWluZWQgd2l0aGluIHRoZSBuZXcgZHJpdmVy IGl0c2VsZiwgZml4aW5nIGEgcmVhbCBidWcsIHNvIGlmIG5vDQpvYmplY3Rpb25zIGZyb20gb3Ro ZXIgbWFpbnRhaW5lcnM6DQoNClJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5Lldh bmdAYXJtLmNvbT4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KDQo+IC0tLQ0KPiBDaGFuZ2Vz IGluIHY4Og0KPiAgLSBtb3ZlICdib29sIHN1c3BlbmRlZCcgdG8gb3RoZXIgYm9vbHMNCj4gTmV3 IGluIHY3DQo+IA0KPiBXaXRob3V0IHRoaXMgcGF0Y2gsIHRoZSBjb25zb2xlIGlzIGJyb2tlbiBh ZnRlciBTMywgYW5kIGluIHNvbWUgY2FzZXMNCj4gdGhlIHN1c3BlbmQgZG9lc24ndCBzdWNjZWVk IGF0IGFsbCAod2hlbiB4aGNpIGNvbnNvbGUgaXMgZW5hYmxlZCkuDQo+IA0KPiBWZXJ5IHNpbWls YXIgKGlmIG5vdCB0aGUgc2FtZSkgZnVuY3Rpb25zIG1pZ2h0IGJlIHVzZWQgZm9yIGNvb3JkaW5h dGVkDQo+IHJlc2V0IGhhbmRsaW5nLiBJIHRyaWVkIHRvIGluY2x1ZGUgaXQgaW4gdGhpcyBwYXRj aCB0b28sIGJ1dCBpdCdzIGEgYml0DQo+IG1vcmUgaW52b2x2ZWQsIG1vc3RseSBkdWUgdG8gc2hh cmU9eWVzIGNhc2UgKFBIWVNERVZPUF9kYmdwX29wIGNhbiBiZQ0KPiBjYWxsZWQgYnkgdGhlIGhh cmR3YXJlIGRvbWFpbiBvbmx5KS4NCj4gLS0tDQo+ICB4ZW4vZHJpdmVycy9jaGFyL3hoY2ktZGJj LmMgfCA1NSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQ0KPiAgMSBmaWxl IGNoYW5nZWQsIDQ5IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0t Z2l0IGEveGVuL2RyaXZlcnMvY2hhci94aGNpLWRiYy5jIGIveGVuL2RyaXZlcnMvY2hhci94aGNp LWRiYy5jDQo+IGluZGV4IDQzZWQ2NGEwMDRlMi4uODZmNmRmNmJlZjY3IDEwMDY0NA0KPiAtLS0g YS94ZW4vZHJpdmVycy9jaGFyL3hoY2ktZGJjLmMNCj4gKysrIGIveGVuL2RyaXZlcnMvY2hhci94 aGNpLWRiYy5jDQo+IEBAIC0yNTEsMTQgKzI1MSwxNyBAQCBzdHJ1Y3QgZGJjIHsNCj4gICAgICBz dHJ1Y3QgeGhjaV9zdHJpbmdfZGVzY3JpcHRvciAqZGJjX3N0cjsNCj4gDQo+ICAgICAgcGNpX3Ni ZGZfdCBzYmRmOw0KPiAtICAgIHVpbnQ2NF90IHhoY19tbWlvX3BoeXM7DQo+ICsgICAgdWludDY0 X3QgYmFyX3ZhbDsNCj4gICAgICB1aW50NjRfdCB4aGNfZGJjX29mZnNldDsNCj4gICAgICB2b2lk IF9faW9tZW0gKnhoY19tbWlvOw0KPiANCj4gICAgICBib29sIGVuYWJsZTsgLyogd2hldGhlciBk YmdwPXhoY2kgd2FzIHNldCBhdCBhbGwgKi8NCj4gICAgICBib29sIG9wZW47DQo+ICsgICAgYm9v bCBzdXNwZW5kZWQ7DQo+ICAgICAgZW51bSB4aGNpX3NoYXJlIHNoYXJlOw0KPiAgICAgIHVuc2ln bmVkIGludCB4aGNfbnVtOyAvKiBsb29rIGZvciBuLXRoIHhoYyAqLw0KPiArICAgIC8qIHN0YXRl IHNhdmVkIGFjcm9zcyBzdXNwZW5kICovDQo+ICsgICAgdWludDE2X3QgcGNpX2NyOw0KPiAgfTsN Cj4gDQo+ICBzdGF0aWMgdm9pZCAqZGJjX3N5c19tYXBfeGhjKHVpbnQ2NF90IHBoeXMsIHNpemVf dCBzaXplKQ0KPiBAQCAtMzU4LDggKzM2MSw5IEBAIHN0YXRpYyBib29sIF9faW5pdCBkYmNfaW5p dF94aGMoc3RydWN0IGRiYyAqZGJjKQ0KPiANCj4gICAgICBwY2lfY29uZl93cml0ZTE2KGRiYy0+ c2JkZiwgUENJX0NPTU1BTkQsIGNtZCk7DQo+IA0KPiAtICAgIGRiYy0+eGhjX21taW9fcGh5cyA9 IChiYXIwICYgUENJX0JBU0VfQUREUkVTU19NRU1fTUFTSykgfCAoYmFyMQ0KPiA8PCAzMik7DQo+ IC0gICAgZGJjLT54aGNfbW1pbyA9IGRiY19zeXNfbWFwX3hoYyhkYmMtPnhoY19tbWlvX3BoeXMs DQo+IHhoY19tbWlvX3NpemUpOw0KPiArICAgIGRiYy0+YmFyX3ZhbCA9IGJhcjAgfCAoYmFyMSA8 PCAzMik7DQo+ICsgICAgZGJjLT54aGNfbW1pbyA9IGRiY19zeXNfbWFwX3hoYyhkYmMtPmJhcl92 YWwgJg0KPiBQQ0lfQkFTRV9BRERSRVNTX01FTV9NQVNLLA0KPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgeGhjX21taW9fc2l6ZSk7DQo+IA0KPiAgICAgIGlmICggZGJjLT54 aGNfbW1pbyA9PSBOVUxMICkNCj4gICAgICAgICAgcmV0dXJuIGZhbHNlOw0KPiBAQCAtOTc5LDYg Kzk4Myw5IEBAIHN0YXRpYyBib29sIGRiY19lbnN1cmVfcnVubmluZyhzdHJ1Y3QgZGJjICpkYmMp DQo+ICAgICAgdWludDMyX3QgY3RybDsNCj4gICAgICB1aW50MTZfdCBjbWQ7DQo+IA0KPiArICAg IGlmICggZGJjLT5zdXNwZW5kZWQgKQ0KPiArICAgICAgICByZXR1cm4gZmFsc2U7DQo+ICsNCj4g ICAgICBpZiAoIGRiYy0+c2hhcmUgIT0gWEhDSV9TSEFSRV9OT05FICkNCj4gICAgICB7DQo+ICAg ICAgICAgIC8qDQo+IEBAIC0xMjEzLDkgKzEyMjAsMTEgQEAgc3RhdGljIHZvaWQgX19pbml0IGNm X2NoZWNrDQo+IGRiY191YXJ0X2luaXRfcG9zdGlycShzdHJ1Y3Qgc2VyaWFsX3BvcnQgKnBvcnQp DQo+ICAgICAgICogcGFnZSwgc28ga2VlcCBpdCBzaW1wbGUuDQo+ICAgICAgICovDQo+ICAgICAg aWYgKCByYW5nZXNldF9hZGRfcmFuZ2UobW1pb19yb19yYW5nZXMsDQo+IC0gICAgICAgICAgICAg ICAgUEZOX0RPV04odWFydC0+ZGJjLnhoY19tbWlvX3BoeXMgKyB1YXJ0LQ0KPiA+ZGJjLnhoY19k YmNfb2Zmc2V0KSwNCj4gLSAgICAgICAgICAgICAgICBQRk5fVVAodWFydC0+ZGJjLnhoY19tbWlv X3BoeXMgKyB1YXJ0LT5kYmMueGhjX2RiY19vZmZzZXQgKw0KPiAtICAgICAgICAgICAgICAgICAg ICAgICBzaXplb2YoKnVhcnQtPmRiYy5kYmNfcmVnKSkgLSAxKSApDQo+ICsgICAgICAgICAgICAg ICAgUEZOX0RPV04oKHVhcnQtPmRiYy5iYXJfdmFsICYNCj4gUENJX0JBU0VfQUREUkVTU19NRU1f TUFTSykgKw0KPiArICAgICAgICAgICAgICAgICAgICAgICAgIHVhcnQtPmRiYy54aGNfZGJjX29m ZnNldCksDQo+ICsgICAgICAgICAgICAgICAgUEZOX1VQKCh1YXJ0LT5kYmMuYmFyX3ZhbCAmIFBD SV9CQVNFX0FERFJFU1NfTUVNX01BU0spICsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgdWFy dC0+ZGJjLnhoY19kYmNfb2Zmc2V0ICsNCj4gKyAgICAgICAgICAgICAgICBzaXplb2YoKnVhcnQt PmRiYy5kYmNfcmVnKSkgLSAxKSApDQo+ICAgICAgICAgIHByaW50ayhYRU5MT0dfSU5GTw0KPiAg ICAgICAgICAgICAgICAgIkVycm9yIHdoaWxlIGFkZGluZyBNTUlPIHJhbmdlIG9mIGRldmljZSB0 byBtbWlvX3JvX3Jhbmdlc1xuIik7DQo+ICAjZW5kaWYNCj4gQEAgLTEyNTUsNiArMTI2NCwzOCBA QCBzdGF0aWMgdm9pZCBjZl9jaGVjayBkYmNfdWFydF9mbHVzaChzdHJ1Y3QNCj4gc2VyaWFsX3Bv cnQgKnBvcnQpDQo+ICAgICAgICAgIHNldF90aW1lcigmdWFydC0+dGltZXIsIGdvYWwpOw0KPiAg fQ0KPiANCj4gK3N0YXRpYyB2b2lkIGNmX2NoZWNrIGRiY191YXJ0X3N1c3BlbmQoc3RydWN0IHNl cmlhbF9wb3J0ICpwb3J0KQ0KPiArew0KPiArICAgIHN0cnVjdCBkYmNfdWFydCAqdWFydCA9IHBv cnQtPnVhcnQ7DQo+ICsgICAgc3RydWN0IGRiYyAqZGJjID0gJnVhcnQtPmRiYzsNCj4gKw0KPiAr ICAgIGRiY19wb3BfZXZlbnRzKGRiYyk7DQo+ICsgICAgc3RvcF90aW1lcigmdWFydC0+dGltZXIp Ow0KPiArICAgIGRiYy0+cGNpX2NyID0gcGNpX2NvbmZfcmVhZDE2KGRiYy0+c2JkZiwgUENJX0NP TU1BTkQpOw0KPiArICAgIGRiYy0+c3VzcGVuZGVkID0gdHJ1ZTsNCj4gK30NCj4gKw0KPiArc3Rh dGljIHZvaWQgY2ZfY2hlY2sgZGJjX3VhcnRfcmVzdW1lKHN0cnVjdCBzZXJpYWxfcG9ydCAqcG9y dCkNCj4gK3sNCj4gKyAgICBzdHJ1Y3QgZGJjX3VhcnQgKnVhcnQgPSBwb3J0LT51YXJ0Ow0KPiAr ICAgIHN0cnVjdCBkYmMgKmRiYyA9ICZ1YXJ0LT5kYmM7DQo+ICsNCj4gKyAgICBwY2lfY29uZl93 cml0ZTMyKGRiYy0+c2JkZiwgUENJX0JBU0VfQUREUkVTU18wLCBkYmMtPmJhcl92YWwgJg0KPiAw eEZGRkZGRkZGKTsNCj4gKyAgICBwY2lfY29uZl93cml0ZTMyKGRiYy0+c2JkZiwgUENJX0JBU0Vf QUREUkVTU18xLCBkYmMtPmJhcl92YWwgPj4gMzIpOw0KPiArICAgIHBjaV9jb25mX3dyaXRlMTYo ZGJjLT5zYmRmLCBQQ0lfQ09NTUFORCwgZGJjLT5wY2lfY3IpOw0KPiArDQo+ICsgICAgaWYgKCAh ZGJjX2luaXRfZGJjKGRiYykgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgZGJjX2Vycm9yKCJyZXN1 bWUgZmFpbGVkXG4iKTsNCj4gKyAgICAgICAgcmV0dXJuOw0KPiArICAgIH0NCj4gKw0KPiArICAg IGRiY19lbmFibGVfZGJjKGRiYyk7DQo+ICsgICAgZGJjLT5zdXNwZW5kZWQgPSBmYWxzZTsNCj4g KyAgICBkYmNfZmx1c2goZGJjLCAmZGJjLT5kYmNfb3JpbmcsICZkYmMtPmRiY19vd29yayk7DQo+ ICsgICAgc2V0X3RpbWVyKCZ1YXJ0LT50aW1lciwgTk9XKCkgKyBNSUNST1NFQ1MoREJDX1BPTExf SU5URVJWQUwpKTsNCj4gK30NCj4gKw0KPiAgc3RhdGljIHN0cnVjdCB1YXJ0X2RyaXZlciBkYmNf dWFydF9kcml2ZXIgPSB7DQo+ICAgICAgLmluaXRfcHJlaXJxID0gZGJjX3VhcnRfaW5pdF9wcmVp cnEsDQo+ICAgICAgLmluaXRfcG9zdGlycSA9IGRiY191YXJ0X2luaXRfcG9zdGlycSwNCj4gQEAg LTEyNjIsNiArMTMwMyw4IEBAIHN0YXRpYyBzdHJ1Y3QgdWFydF9kcml2ZXIgZGJjX3VhcnRfZHJp dmVyID0gew0KPiAgICAgIC5wdXRjID0gZGJjX3VhcnRfcHV0YywNCj4gICAgICAuZ2V0YyA9IGRi Y191YXJ0X2dldGMsDQo+ICAgICAgLmZsdXNoID0gZGJjX3VhcnRfZmx1c2gsDQo+ICsgICAgLnN1 c3BlbmQgPSBkYmNfdWFydF9zdXNwZW5kLA0KPiArICAgIC5yZXN1bWUgPSBkYmNfdWFydF9yZXN1 bWUsDQo+ICB9Ow0KPiANCj4gIC8qIFRob3NlIGFyZSBhY2Nlc3NlZCB2aWEgRE1BLiAqLw0KPiAt LQ0KPiBnaXQtc2VyaWVzIDAuOS4xDQoNCg== From xen-devel-bounces@lists.xenproject.org Fri Nov 04 03:06:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 03:06:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437248.691481 (Exim 4.92) (envelope-from ) id 1oqn2d-0005eE-MS; Fri, 04 Nov 2022 03:06:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437248.691481; Fri, 04 Nov 2022 03:06:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqn2d-0005e7-Jg; Fri, 04 Nov 2022 03:06:47 +0000 Received: by outflank-mailman (input) for mailman id 437248; Fri, 04 Nov 2022 03:06:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqn2c-0005e1-LT for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 03:06:46 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2089.outbound.protection.outlook.com [40.107.22.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b6ba5f21-5bed-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 04:06:45 +0100 (CET) Received: from DB6PR0301CA0031.eurprd03.prod.outlook.com (2603:10a6:4:3e::41) by DB9PR08MB7399.eurprd08.prod.outlook.com (2603:10a6:10:371::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 4 Nov 2022 03:06:35 +0000 Received: from DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3e:cafe::38) by DB6PR0301CA0031.outlook.office365.com (2603:10a6:4:3e::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 03:06:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT036.mail.protection.outlook.com (100.127.142.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 03:06:34 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Fri, 04 Nov 2022 03:06:34 +0000 Received: from c85e0916c095.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 566A5C33-3932-484B-88FB-68147DB54A04.1; Fri, 04 Nov 2022 03:06:24 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c85e0916c095.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 03:06:24 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB9002.eurprd08.prod.outlook.com (2603:10a6:10:467::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 03:06:21 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Fri, 4 Nov 2022 03:06:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6ba5f21-5bed-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FnaxPyhF/pluwCHwd1FyqRAfFomuY+nzuH9vepMDbDBSKDyGJsfo+O1oNEqmZlxXIytNGEvQtre2g8k9Ke55b3NboI3UpVooTddPbB8M8mZuKLIOoooMhRFiw7UDk6TBmSTzVZS9mdWR8fVWaF/7hnGksQNwhYO4qvYq8ezylhCYy4n4PbizvimSJeQFepo1ci5O95xs2q6dNdH0TfhLafwFDjPSim5f5sTNVEfSei4ttRuekfnG3+141wxWfqrDVsaVLFgNrqNrChGBYkZrvwZn4ywmqfj7gt1dFOUpGUQTgn4oRbDRH9Mnq0ihj9ztRtu7G9v6sYxjUfLJGc2BVw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xeZfdRogX/r+zVTMHCsQ5iFcWzisNuN5PB7+2sEschk=; b=NHJ9TVWHjwi+c7To0SOqOkNRP+yUvo3rUGOwp5aTLOvTBeWzrw2wZNwzQYcNjPv5lSHrNZo4UZmz7ifrMpPut7YStsMF9UurMmWPED63X+bEm9ZsGO0kH1ddSIxBaSzA+E8L7keA0sJS75+sJeRXarWTVNhqsX+yAJ5eQPtZb+I4YgthkE61GB/XtbVhvgEAeXLyv7yIqlFDlTZVcIxBwITVn1+swCCkSUeYP/PpQ8HFa7JbeyrhTdk1lkAfOd2ftaEo1bCXPxTCcE0AqlEBaThMCQ2ZIOKklxktfdaXzT+xpxlj21yho1sO6pTlCEmGBYrv7EAAujismF6699yfNA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xeZfdRogX/r+zVTMHCsQ5iFcWzisNuN5PB7+2sEschk=; b=afUhlIiRr0UvGDX+wnQSN4yk27dnIEftkT7rqUoWekSrm+VOPBfjyuaYOGvgt5XnTVThO8OelyYrNf8H2aU76+W90CT6MtsOlU8YKzhnkeCxDQpS6rxZK607CkOjxHVGOLQEYtByW072IzxPerAxtgRfqrmwLbtDvnxFeySg+H0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G/OqHQ4jS9CulDq5t2lsd5ktr6DGwyt/Cs/3hW/fCduP3tFkhUAjhDbwpSS4qBFp/MwD9Yn0B+R2AhOEcWx43EbQVRJvwbIL1aHawqgrbtDTbvmLUlNZbLZwW6AJPgdY8Tk+ct2YsxcVhgOtJexA3gqlZgz0l9d3vjx2u2+8m07fcLlW2mTp+Vevk73FUhoT7kNdFWU0G0qJ52dAbj/qGLToGwdH46QcOOSGNHIaQJXZX+U3XYaFK9JvM1qbxjOoSuOedEJy+K0006boYKJmb2hWyNWqUBLrlmoW3Pqnv/mDEhMRAVxcCPn6I9awIVe9Q/aBWqYul4ayq2IiJHz5zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xeZfdRogX/r+zVTMHCsQ5iFcWzisNuN5PB7+2sEschk=; b=RXbvQj88/sfqJjzCh8d/ZC1n2NO5sv4r7tvopEk54IaW2RQp+/MfemnMwcKWnP5ibziHV3TTK08OplSqxBFywcicsgZVRMgXTg0e8kn9RIoHKsGVHdmhKdf/Z8b73MoGSs3Xpm4lxNF88wtUliLIxn+8GDWV9lNGSZE/8DlcheZpHQlQG0BaHrY+oxYELqHAjcmw6MDOAYPi0UifpKp9jkVTryFDkTsJpVC1ygtKBFPbqdfFH6b6I/I6xKgZ3Ze0zj0AjAZOZBlFpvRparbq1XakIMPrGTS1UwPUy1DaLdh7gVv8xZ/n82PI/b2vw8HXXXwmWT8sOUi76gvPX09Yuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xeZfdRogX/r+zVTMHCsQ5iFcWzisNuN5PB7+2sEschk=; b=afUhlIiRr0UvGDX+wnQSN4yk27dnIEftkT7rqUoWekSrm+VOPBfjyuaYOGvgt5XnTVThO8OelyYrNf8H2aU76+W90CT6MtsOlU8YKzhnkeCxDQpS6rxZK607CkOjxHVGOLQEYtByW072IzxPerAxtgRfqrmwLbtDvnxFeySg+H0= From: Henry Wang To: Andrew Cooper CC: Jan Beulich , Juergen Gross , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Bertrand Marquis , Julien Grall , "sstabellini@kernel.org" , "xen-devel@lists.xenproject.org" Subject: Need updates on some release blockers Thread-Topic: Need updates on some release blockers Thread-Index: Adjv+kQNrAwcokZLQqKTDZ49PUC6/w== Date: Fri, 4 Nov 2022 03:06:21 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: EC9B5A5E6BBCCE4C8F961907BD236BC7.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DU0PR08MB9002:EE_|DBAEUR03FT036:EE_|DB9PR08MB7399:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e0cc432-c089-4704-3aea-08dabe1194a6 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: h5hq4NZV5pe/BN6R74CjILgoI5Ri9Nmjzfs+xOIfsKkJTo4uEBmcXnoFb/E1yyt+6bqC/44WnLzihwep5VaRyCxwfYmnwOcUZAYBq45pfx0ZDEr13cwE7cYFkEGFKNPmEAiXLW5nUQzVQ3UReCPMw/UAnOdo3IdA/XxmnRC1u605mWOS3PPoCmiG8m02qgtfn1Z/NjJmmOZCYbA6/cfcPltl49LjUwEd9/ucdhczD2bKwP37Z4AwMTXLUQXApoSTP/yrsQEZ9FIR+cZ0rcdci1eIQ/i8lLZPbnj3r2rpfv2AkDCYtp65PBzmEqkKaI817HOl63lbRlTwgb5v0ZgP1myfOiPoz5/Yv4UGadJKZp0wdgxpcGA+2poBLCW6JUkKXh30hoAGVSZEphYet9FH5aB+UmNh59eZrznnmXnxs6M+YJqWcM9su7kBDIJiy5F0Tlw/dAah7Nd0iIeJNEB+sMpCXbGpemIq1blWZmzFW7uqSy7yl8YAho7Nx6bJwt7qpgaoyB4WoSQ4n3ycrt4K1TFKp1ALbBBne/BMgaba72dk6Vt9FBUaSJkdbBLLu1gd4y0F5afVTVjARlRxArCourtew4jQreVt2F5j7udFLgKTRlXV88XpcOgrfeyiJsoZ+AZJlokk5imScmIZEv95PqRHwlKid9dGW+I0h9YNgTNj/qXPeNByWWy5NhqLu2YKD5xkkTltm7+hDmGkcGtnTQn0/Fl17SzUy2HH9qJ11n+nTkduOe/SE2oCyrmtltaVkRVsDWPqxycXYjXlJjTxMJX8cSkaUv8X2VP+V/gLjy2fMEOtUrR5WbkJC3iPzHe3SQ6N5l4bz0h3cWmuJvmMsw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(39860400002)(376002)(136003)(451199015)(38070700005)(86362001)(33656002)(41300700001)(55016003)(9686003)(8676002)(64756008)(4326008)(66946007)(66476007)(66556008)(26005)(76116006)(66446008)(186003)(5660300002)(52536014)(8936002)(6506007)(478600001)(966005)(71200400001)(15650500001)(7696005)(6916009)(316002)(122000001)(38100700002)(54906003)(2906002)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9002 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d3a8ab79-aa86-4fa4-852f-08dabe118d1b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rlvr1kTcUxK6rvoC1drrGuIO9S6L0gJROtfq6bubPfWM1FhmdKqD7KEFT+o+F2MIGzUbUzwehI2U9gRalqy6UoW+ilYlIdDRvetZVlMHdiSqKdH03qVPsOamjYJCTzIq4JyL1LOh4dpCKLbilPo8U0gCHywMCLbYK2M0B9Sa6yj29R89QvIVnX7Yh455dSRK6tyDxpRMY5tDFSR5gl6F44HnWxcTXPeNM8nhOu/Db/1m0KPUTzRHHy/5PatzsNF1Jcw1kP13fzWWfSidBzkF5W0N/K+7a98QxBaC2yCxVYXO/Bq9YxzOKXV4XZk7LMeq+FD3/OZqU09QSLYZi1U+5JplE4PzWtXOwZr0Z4fUwJgZK7NgpvFlEWbKou5Q9zheHJs8babcsqSHgP+JV1men35mnwtTwyS8eWLRqv0yyUuyN7DS4abH4MMZIcVSaGSjMm1/y4cDk7aCfqifDSzL/fH7LnyGfmOQREefzIvbX/UGj8M59j77+OEyCw9hYSmwhJccWU6D3dxfQ7aGR76lj2JoeZsi0c8IyrJ8hyg6ak06AiBAxbfRMlP5Jfwz+KQo5OQ0Rbran58MFFGpwTElA5hcqNZswTBsG2+bZgTkWnmN7QULQpBwnFDtcqgvUZetKATQSeWmzMQZ264x6NwtUW4OeNXQBgNSUAP1q6XhQ/hTlxhE9fIQNk3Tn4LccxNZ4SgGiDCHJA/2/rqWbhvj9WliO9o+B6CAnrGdaBjgdxyFzTK05otZXYG+RA96yJ3rKmUau1X405iCEwxvp/nO5XNEIw+k18lw6S8/VKbL4810TW5PLvQrVHsrr+NYMnMm+VV7HIlAdWXF2/iaZi/3AA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(136003)(396003)(451199015)(46966006)(40470700004)(36840700001)(6506007)(70206006)(336012)(9686003)(4326008)(52536014)(7696005)(70586007)(33656002)(82740400003)(8936002)(40460700003)(2906002)(15650500001)(5660300002)(83380400001)(8676002)(41300700001)(47076005)(36860700001)(186003)(6862004)(966005)(356005)(86362001)(55016003)(478600001)(82310400005)(54906003)(316002)(40480700001)(81166007)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 03:06:34.3833 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e0cc432-c089-4704-3aea-08dabe1194a6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7399 Hi Andrew, Following yesterday's community call, there are 4 open release blockers whi= ch we don't know the status. So I am sending this email to ask if you have any updates on them or if there is anything that I can help to keep these relea= se blockers processing. 1. APIC hardware assistance selection [1] 2. Concerns with hypercall table changes [2] - I hope patch from Juergen [3] will address your concerns. Could you pleas= e provide any feedback about this? 3. DOITM Changes [4] - This is a ticket with no descriptions. Could you please elaborate on this= issue? 4. Patch: x86 :Enable interrupts around dump_execstate() [5] - I think your opinion is needed so that the discussion can continue whethe= r this patch can process or the previous patch needs to be reverted. May I please have some feedback before the end of next week (Nov. 11). We w= ill need to decide whether they are really blockers or whether the release can = be properly unblocked from them. Thank you very much! [1] https://gitlab.com/xen-project/xen/-/issues/91 [2] https://gitlab.com/xen-project/xen/-/issues/93 [3] https://lore.kernel.org/xen-devel/20221103163631.13145-1-jgross@suse.co= m/ [4] https://gitlab.com/xen-project/xen/-/issues/94 [5] https://gitlab.com/xen-project/xen/-/issues/32 Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Nov 04 04:02:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 04:02:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437254.691491 (Exim 4.92) (envelope-from ) id 1oqnud-0006Gi-PQ; Fri, 04 Nov 2022 04:02:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437254.691491; Fri, 04 Nov 2022 04:02:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqnud-0006Gb-MZ; Fri, 04 Nov 2022 04:02:35 +0000 Received: by outflank-mailman (input) for mailman id 437254; Fri, 04 Nov 2022 04:02:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqnuc-0006GR-Gb; Fri, 04 Nov 2022 04:02:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqnuc-0004qk-E1; Fri, 04 Nov 2022 04:02:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqnub-0006n8-UH; Fri, 04 Nov 2022 04:02:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqnub-00018W-Te; Fri, 04 Nov 2022 04:02:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NhwfDOyBNqfBravvjhQJWEgmQBHqDjW8kcRYYKUQQJo=; b=SOu1x9K5hkmJcyn+IGbYiuqrI2 3Y29fmvMHeeVwv08UNzG0qG7V86VK5MCIFbA6ilTv3lq0XqziV6vfaDCQJfcUA28k/RPnSo6QJ8Zr EzZ+itcNz1UnABR1VJjOuqqiNOz2L6HjKxPVdutF7GCQIZ6HatYzdjxK+79RuVrLRpqI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174610: all pass - PUSHED X-Osstest-Versions-This: ovmf=cab1f02565d3b29081dd21afb074f35fdb4e1fd6 X-Osstest-Versions-That: ovmf=c46204e25f5b929fae2b336c03c73fada632d4f4 From: osstest service owner Date: Fri, 04 Nov 2022 04:02:33 +0000 flight 174610 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174610/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf cab1f02565d3b29081dd21afb074f35fdb4e1fd6 baseline version: ovmf c46204e25f5b929fae2b336c03c73fada632d4f4 Last test of basis 174593 2022-11-02 21:43:39 Z 1 days Testing same since 174610 2022-11-04 02:11:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Miki Demeter jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git c46204e25f..cab1f02565 cab1f02565d3b29081dd21afb074f35fdb4e1fd6 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Nov 04 04:40:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 04:40:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437261.691503 (Exim 4.92) (envelope-from ) id 1oqoVR-0004Yd-Kq; Fri, 04 Nov 2022 04:40:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437261.691503; Fri, 04 Nov 2022 04:40:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqoVR-0004YW-Hk; Fri, 04 Nov 2022 04:40:37 +0000 Received: by outflank-mailman (input) for mailman id 437261; Fri, 04 Nov 2022 04:40:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqoVP-0004YM-U5; Fri, 04 Nov 2022 04:40:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqoVP-0005hk-Q4; Fri, 04 Nov 2022 04:40:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqoVP-0001PZ-Bf; Fri, 04 Nov 2022 04:40:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqoVP-0003m7-B1; Fri, 04 Nov 2022 04:40:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rIqFf89bVdBGOMe+7KTz+5O0fq36vwoNXqRi7VbaO0g=; b=4aQtgHf4VkpCx8IIqCrljjwEqv g8E1ScT2bO9/T8xbOGQ6HLsWBQRx1zr+qCFCAgMf9SFQtQ5Dw01zY5qIBjZ01Q0jMCB7Kdg1wG8u/ RXYt9XF9vqPFAM6D4qBPKrywSxwAiXHqf/GIZThe3Xxgr1NIqsFraTX+Tv2qdQndegPU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174607: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2d9b3699136d20e354a94daefebbeefa9ceec7b6 X-Osstest-Versions-That: xen=2dd823ca7237e7fb90c890642d6a3b357a26fcff From: osstest service owner Date: Fri, 04 Nov 2022 04:40:35 +0000 flight 174607 xen-unstable real [real] flight 174612 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174607/ http://logs.test-lab.xenproject.org/osstest/logs/174612/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174612-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174574 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174586 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174586 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174586 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174586 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174586 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174586 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174586 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174586 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174586 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174586 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174586 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 2d9b3699136d20e354a94daefebbeefa9ceec7b6 baseline version: xen 2dd823ca7237e7fb90c890642d6a3b357a26fcff Last test of basis 174586 2022-11-02 12:11:56 Z 1 days Failing since 174597 2022-11-03 04:07:57 Z 1 days 2 attempts Testing same since 174607 2022-11-03 15:40:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Juergen Gross Marek Marczykowski-Górecki Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2dd823ca72..2d9b369913 2d9b3699136d20e354a94daefebbeefa9ceec7b6 -> master From xen-devel-bounces@lists.xenproject.org Fri Nov 04 05:02:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 05:02:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437273.691529 (Exim 4.92) (envelope-from ) id 1oqoqB-0000Kd-Mw; Fri, 04 Nov 2022 05:02:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437273.691529; Fri, 04 Nov 2022 05:02:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqoqB-0000KW-Jw; Fri, 04 Nov 2022 05:02:03 +0000 Received: by outflank-mailman (input) for mailman id 437273; Fri, 04 Nov 2022 05:02:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqoqA-0000KQ-DX for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 05:02:02 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cf54cdc2-5bfd-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 06:01:59 +0100 (CET) Received: from mail-bn8nam12lp2177.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Nov 2022 01:01:49 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5474.namprd03.prod.outlook.com (2603:10b6:208:285::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Fri, 4 Nov 2022 05:01:35 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5769.026; Fri, 4 Nov 2022 05:01:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf54cdc2-5bfd-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667538119; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=7v4JX06bnruSnfUstudr0IiKSAjk/5gSwhWdF4I81vY=; b=F3RmZzVKc5zcblrw+NN2YyIuv1h7lFOYeZbAyNLI7AHDxu4xb0sQN4Vk b0hAvpN6Zq+D1gMIZJxL4+QS8mLUAw5/8cWMJ9XMtHrlHCDqNk2QVUBmR l0vdUzKAe+Ue4fApiyRGEpKfnvcG8JTcT0HU6lGrfLd3CGvU1VnX0yy6X A=; X-IronPort-RemoteIP: 104.47.55.177 X-IronPort-MID: 83755405 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:nGrDw6z4dxATpMzUnxN6t+fGxyrEfRIJ4+MujC+fZmUNrF6WrkVUn GUbX2vSMvyPYGOgc9BzO9ng9ktTv8LXmN9nQFBu+SAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPawT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KXxXy /gFcxczVC2K1rKcw72WCfRRtst2eaEHPKtH0p1h5RfwKK98BLrlE+DN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjWVlVMuuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAurA91PSeHgq5aGhnW64WIyBxgzeGCmgqS3hGC8VOxcc EgLr39GQa8asRbDosPGdx+3unmfpTYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWXQ3+A8rafrRupJDMYa2QFYEcsTxYB4tTliJE+iFTIVNkLOLWuktT/FDX0w jaLhCsznbMeiYgMzarT1U/DqyKhoN7OVAFdziXaWHi0qDxwYoGNbpatr1Pc6J59wJ2xS1CAu D0OnZiY5eVXV5WVznXSH6MKAa2j4OuDPHvEm1lzEpI99jOrvXm+YYRX5zI4L0BsWioZRQLUj IbokVs5zPdu0LGCMcebv6rZ5xwW8JXd IronPort-HdrOrdr: A9a23:z0qMo698xpneWZ5MWMFuk+F7db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuCKlaDPY0LDErXQBeoR8bMtiA2XkAwBLhqAC7I tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0XbWIyUs4nkWUkxjIiLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3f7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPbHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCD34Gyff+qaGj3iq9M1lVBw6du/22z6IJyoHUVf7sLTCJTkwono+pv+gfa/erKc qOBA== X-IronPort-AV: E=Sophos;i="5.96,136,1665460800"; d="scan'208";a="83755405" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ISMV8mhKGnqed0j1an0V4q0LMn6k7RSckYyYe4Y6PCqC/65/7d2o+3r/ns8y4DjNG4jmrBFWpjcTK9ZbtxipvtyZXL+sv1TemgTrKPqcmatY+7/x7efmaD/u0aRcOw0lgfS5Zo3i7aU7TT/iR/gUk89LwK2WYgrThBTQ5Z+hZ56BjAGHR9a7pZSAYFxV8btQvmQM+RoPpjI6Jx0hgxNWO+rFNx8Kah1PvVU1RcqKQAFM8ZBDxZjPKIayOEvivofmifkzydk+IhgUiNe+fSOxKgExKj8Sj97pjA6OUQfiyPnRKrJc+IhxteuY0nLSJocO07DXBqcgeEufSscOBVcFsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7v4JX06bnruSnfUstudr0IiKSAjk/5gSwhWdF4I81vY=; b=W4RXbICabCEyqvgXhiInmNP7glyg9wydpdsVHQOyatjZavylYwhoGABQjPpKTdXddVQNqJu7S76SQKe7Sd28q8qxX0pdl4xq3Rbj16kLunoywJDC2TK59eGG1pGM6JK6EfXEs2T6e924BfEt4yWKu12SANiYt5cA62Pq0Xc0BMijxzcFpSGV6UXouj0gBrMOLjFWM/Us6LhfuHd3PbodFnt9pAfsucqaCMzSqJU8SMeyJ47Y/Pj0pQzXbFOUDhIW0MJAeRb9vHE4GSzn3GE/PdJzZv8Kb23rDfPeUSxHW3GUjOX4M3InP1FIr7HEMzblIyPp/seLdOW8lqUSWuYujQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7v4JX06bnruSnfUstudr0IiKSAjk/5gSwhWdF4I81vY=; b=vTvnwaKJ51Sp5YQ7gJnS3zaJJBf7kkMiP2rIZel72p+SoB7ZCLmGSm4EoFeOrgYAzJL8TRC4TrqXfRkl0x17NqwAjYvA3fdR8JdO+GiogEzAFxPkeE2HN2YR5QJqytq/pFBcNalg/1AIHerScVFfH9UYG6PWJf2/vRWhL64PEjk= From: Andrew Cooper To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang Subject: Revert of the 4.17 hypercall handler changes Re: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers Thread-Topic: Revert of the 4.17 hypercall handler changes Re: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers Thread-Index: AQHY76JzuJHqrt9HWkCsd/BvJMgfvK4uNcAA Date: Fri, 4 Nov 2022 05:01:34 +0000 Message-ID: References: <20221103163631.13145-1-jgross@suse.com> In-Reply-To: <20221103163631.13145-1-jgross@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5474:EE_ x-ms-office365-filtering-correlation-id: e74bc54d-3992-4ea8-03d5-08dabe21a57e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HwGJYw+ovL7yoP0/S9NhlQq+j+6/uW4ErBUyDzyr/yzA/7Fw5btZkWu5s5m4TAWGrm4VDOmJ/G65hwxbzSDJVHlCA9Z1Q9TU063gwXcHGpUobA2tZWctIYxeb7Fmdj0hQfSRrrYvcYJm6eG66jMb0wejmtCeeW4jQ3XUXfFpy89Au8CE61P+PrLnx/pVYl8Qz7puZY1YkJbKcpY5NlhLBfE8yYmj3zqcTsfQ3Fjc8joVr1MrV+IVR3zGsnzbuhQg96zNfqFtuRkuSiDN9OzMddXL8UfGFhcyDTk6FXOR6lRKOU1AghNSgHMIJQEKN+a2vIzjkizZDC6TOfy6BXAeVgb4z0GNw614FW2ZZNfg9Splov2pllsbjrPEgm1BEsudj8ZqpARiJlgcS19pyWlZO1vNzpwr16F0xR6/SGcGCBSpv9GeWNGD1ITuF0/flcmX3VWNg36cBqYwSFpZEsHvX6ADPJiz8LQxKURuwferYCxb7b8xYlSIvKZeHqq8609RdjRaDRUINoWvfF9F5WFv4Bn62M0lm0xK+gmYWWrJEB+pt6VD7De6QabE1WDceU0aM6ozZSJLgzHCArzvZdHrObsBpDtvXtJd0igis7K87CxMAonu1wBJstclCeefD72rVaoGZp9HS1rK04ZDb64kEax3VZqjVLkeMRdN10y3xVOHVkwSCwF+fOT8rBt2xLIVG5/ko0MWhxsMc1vh+dGYVUOFJo4etAJyivkPWUldNwfnv21d1ddHbAGgAFqtTXhigExxWq8LFGdcN5ZujmGdVsZiGx4D2JN/B9jnajyKyxz8UX3057CSS+PGJX4XHYTX+U8MbijNbFl9q4WCqch4pesesWf42TvK93PH4rsBY68= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(366004)(39860400002)(396003)(346002)(451199015)(76116006)(31686004)(54906003)(8676002)(316002)(66476007)(66556008)(6486002)(110136005)(66446008)(71200400001)(91956017)(66946007)(38070700005)(478600001)(4326008)(86362001)(186003)(64756008)(31696002)(36756003)(966005)(5660300002)(2906002)(83380400001)(8936002)(41300700001)(122000001)(82960400001)(53546011)(6512007)(38100700002)(6506007)(26005)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cS9KMnAzWlNTbEhWL1F3Q1hpYWFGVjBkc2RoN1pwSy9DM2ZMdWdjeDlwR3FB?= =?utf-8?B?STczUFdhdkZBTUsyS1lscDh2Zk5ZeENuV3hDVVVJRHNlMTF0UWZZQTRFYjg2?= =?utf-8?B?MnNrQVFIU1NrbytvK2NLSmdram9tZW40TmpCYSs1WTFiYkRLUEJrV1RiMWhp?= =?utf-8?B?aGh6amM3anhhb1FTTVFXZ0F6M0R5d0pic3JkNGpETTYvcDFlaXd4dDhVU21r?= =?utf-8?B?djZGSHp4U0Y4SkxvM3ljTGtMeDEzZHFtUUJPUmJjTmNjRmVhTDZCQ2hSeWlL?= =?utf-8?B?SmxVaEhGVnF4RldrYXlFdTRKQjY5QkhydGs1RzNpSzhUZEYvdUFrMzZvL2Er?= =?utf-8?B?L3pBcXdiOXlMbEhtenBsZHhWUGhwVXdkNmNiVCtBdjBSSDJpeEp3V2N1MWxJ?= =?utf-8?B?T0RsVStKL2ZTZnMwLzdxdFdOWHREZ0NBcE9NNEVHR0FOcjgwRFU2U3I2K2hW?= =?utf-8?B?L0dNNnliRTFGbGd4N2hUUWkza2NnT1dzYzlDeGlRZEpyN1pGVzl3Vzk2U1lS?= =?utf-8?B?MFVUZWNvWnE0Y3l5Q0ZUMVZKMEFjeHpHd1Rpb3V2Y253dmJXR2tQeEJxcm9q?= =?utf-8?B?UE5POHp1aUY3YWpOWGRRb3JTYUhQTU90bVJycDZHTmhkTGZkMGlxeHhuTitH?= =?utf-8?B?TWtBbFZVbXJSOTF6cXpkMVpvYldab0VmV3VMV2dhZXBnMmljdGoyZVB1N09u?= =?utf-8?B?ZE5ZUHYxcUQ3QVhuczBRS2dFVUdZRTJmR1dOL2VhSnhpdzgxYlV5VGsyS1R0?= =?utf-8?B?WUI0L2xTdFBrQkpLckphakh6YlFkNVAxZE9VSnRlSDBDeWlmWEtqa1MwZFZ0?= =?utf-8?B?ZEpPTFVXUVJEVHNCWjZsQzlBaTlCLytNYkNTOUF4ZHFPY2tNWWR1YzFoMzV2?= =?utf-8?B?bVRyNG5rblZhTWdoencwWTJkT1NQdUJHaFZSbURsNngyemszc1NiUUhEWkNz?= =?utf-8?B?N2pKaXRrNHA2UGs1UVBqL0FXbkZ2T0tyMUNZMHgxbzF5TjBpNXdvZHA2K3JY?= =?utf-8?B?cHEyMVdHTFFVTjdSWUhhSHA0L21mT0FiaU9sbERpNWVZR0UxdVpGdDNIMUlY?= =?utf-8?B?VGs1NVVKMDNHMVo4d2h6alZqTzR5ci96Y0lQZ0R6TFpEWEpMcCsvcnlsbXdi?= =?utf-8?B?alprNVJqU3hEMmg0N0tXUHFQMUc1Z1B3Y2p0ck1vNzY4eWxTcnNZc2trbVlX?= =?utf-8?B?bTJrME9LTU53SXpwQ1p6QUk2cGxPVUFhUjAzQTFDWC9JMEtGSk0xcTZueVFL?= =?utf-8?B?aHkwL2g0U0pEQTJwS29KWjdKNUJMWElwbmlHTWZuQzJDSkZ0a0c5cUE2ZjJt?= =?utf-8?B?b1pJSmpzQW83UXZuNHNLUjlybXc2cGVGYXp0S1U5OVd1L2JwOEZ6UUR5ZFU2?= =?utf-8?B?cmtlWFlyU3ZydHRLVlE2OXBvSUdtU2R3ekQyUUVjM0NvYW5STUV1cmoyL3Y4?= =?utf-8?B?dUNwN1UzZWhKTFgySGxVdUsxdit2ZHM3dmZ1cXUySTl0d2NXZGQxU0RDTnYw?= =?utf-8?B?OGVNRmNZUWlWNGNRSkg3c2FXVlIvT0xiQXVhWis5ZFRDQ3Y2Zy9kUTRCMVVW?= =?utf-8?B?QmNjc0MyNFdIbHVvbEN5ZHNYYkptSzU3OVZDcGNMaGk4QStRZ1ZrYk9nTm91?= =?utf-8?B?SGg2LzdYWVQ2R01EY1NJc2RoUzF3ZTZYZ2pxdDFJaVBndmZIb3R4blJqRUFh?= =?utf-8?B?cnNjODNGSm5SaWVjVXJuUW9kY3Y4MUJjNk5iWkpJTElkdEhlU3k2WVhwMnlY?= =?utf-8?B?a2thNHA4TXBDalAzMksyS3l2N0xZbDJsTVhPa2pXMUg1K0dOY0JxaXdadnl0?= =?utf-8?B?ck9QaEdnOXorUVorQmsydmlZN29QdUEvSnRTY3hTSHpvR3BhR3hDaUlMc3N6?= =?utf-8?B?TnJpV0ovaHV4cUxkWGw5M281WjVFTDlnZ1FxQk5CTGRHdmhWZDMwRzMxL0h5?= =?utf-8?B?RkRNb3VKOXYyV2FjR1VCSVgwM3VZeHhaMzAzazZkQzJsQ1ByN0lFdS82ZTZG?= =?utf-8?B?YkJGSkQwMDFhZldWMDJUWGh4TkV3WEpoN2FESW84TkhsVjRpTGp3eEJFbmwx?= =?utf-8?B?ZDJXOExkeE54bkN6YnppMEdvREN3UEZUZFdUcmtUNTFrcmNlV3JqQ1cwOExP?= =?utf-8?Q?PdaNwVE4e85UjGzjlllZDKhYe?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e74bc54d-3992-4ea8-03d5-08dabe21a57e X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2022 05:01:34.5887 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xrp0Ya9PkgVM2eep68lYj+ctsBco9ID+r9mZsLgrgMTXCdKLmgoZixB1Hto282NsrYp6Sn9ZzDPd726VFJMOLvgh+yYpmD9XqCcwXI+2qhA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5474 T24gMDMvMTEvMjAyMiAxNjozNiwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gVGhlIGNvZGUgZ2Vu ZXJhdGVkIGZvciB0aGUgY2FsbF9oYW5kbGVyc18qKCkgbWFjcm9zIG5lZWRzIHRvIGF2b2lkDQo+ IHVuZGVmaW5lZCBiZWhhdmlvciB3aGVuIG11bHRpcGxlIGhhbmRsZXJzIHNoYXJlIHRoZSBzYW1l IHByaW9yaXR5Lg0KPiBUaGUgaXNzdWUgaXMgdGhlIGh5cGVyY2FsbCBudW1iZXIgYmVpbmcgdW52 ZXJpZmllZCBmZWQgaW50byB0aGUgbWFjcm9zDQo+IGFuZCB0aGVuIHVzZWQgdG8gc2V0IGEgbWFz ayB2aWEgIm1hc2sgPSAxVUxMIDw8IDxoeXBlcmNhbGwtbnVtYmVyPiIuDQo+DQo+IEF2b2lkIGEg c2hpZnQgYW1vdW50IG9mIG1vcmUgdGhhbiA2MyBieSBzZXR0aW5nIG1hc2sgdG8gemVybyBpbiBj YXNlDQo+IHRoZSBoeXBlcmNhbGwgbnVtYmVyIGlzIHRvbyBsYXJnZS4NCj4NCj4gRml4ZXM6IGVj YTFmMDBkMDIyNyAoInhlbjogZ2VuZXJhdGUgaHlwZXJjYWxsIGludGVyZmFjZSByZWxhdGVkIGNv ZGUiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoN ClRoaXMgaXMgbm90IGEgc3VpdGFibGUgZml4LsKgIFRoZXJlIGJlaW5nIGEgc2VjdXJpdHkgaXNz dWUgaXMganVzdCB0aGUNCnRpcCBvZiB0aGUgaWNlYmVyZy7CoA0KDQpUaGUgY2hhbmdlcyBicm9r ZSB0aGUga2V4ZWNfb3AoKSBBQkkgYW5kIHRoaXMgaXMgYSBibG9ja2luZyByZWdyZXNzaW9uDQp2 cyA0LjE2Lg0KDQpJbiBsaWV1IG9mIGhhdmluZyB0aW1lIHRvIGRvDQpodHRwczovL2dpdGxhYi5j b20veGVuLXByb2plY3QveGVuLy0vaXNzdWVzLzkzLCBoZXJlJ3MgdGhlIGFicmlkZ2VkIGxpc3QN Cm9mIGVycm9ycw0KDQpUaGUgc2VyaWVzIGNsYWltcyAiVGhpcyBpcyBiZW5lZmljaWFsIHRvIHBl cmZvcm1hbmNlIGFuZCBhdm9pZHMNCnNwZWN1bGF0aW9uIGlzc3Vlcy4iLCBjL3MgODUyMzg1MWRi YzQuDQoNClRoYXQgaGFsZiBzZW50ZW5jZSBpcyBsaXRlcmFsbHkgdGhlIHN1bSB0b3RhbCBvZiBq dXN0aWZpY2F0aW9uIGdpdmVuIGZvcg0KdGhpcyBiZWluZyByZWxhdGVkIHRvIHNwZWN1bGF0aW9u Lg0KDQpUaGUgb3RoZXIgaGFsZiBvZiB0aGUgc2VudGVuY2UgY2xhaW1zIHBlcmZvcm1hbmNlLsKg IEJ1dCBubyBwZXJmb3JtYW5jZQ0KdGVzdGluZyB3YXMgZG9uZTsgdGhlIGNvdmVyIGxldHRlciB0 YWxrcyBhYm91dCBvbmUgdGVzdCB3aXRoIHNwZWNpZmljcywNCmJ1dCBpdCBkZXNjcmliZXMgYSBz Y2VuYXJpbyB3aGVyZSB0aGUgZGVsdGEgd2FzIGEgaGFuZGZ1bCBvZiBjeWNsZXMNCmRpZmZlcmVu Y2UsIGFzIG9uZSBwYXJ0IGluIG11bHRpLW1pbGxpb25zLCBwcm9iYWJseSBiaWxsaW9ucy7CoCBU aGVyZSBpcw0Kbm8gcGxhdXNpYmxlIHdheSB0aGF0IHdoYXRldmVyIHJhdyBkYXRhIGxlYWQgdG8g dGhlICI8MSUgaW1wcm92ZW1lbnQiDQpjbGFpbSB3YXMgc3RhdGlzdGljYWxseSBzaWduaWZpY2Fu dC4NCg0KVGhlIHJlYXNvbiBhIHBlcmZvcm1hbmNlIGltcHJvdmVtZW50IGNhbm5vdCBiZSBtZWFz dXJlZCBpcyB0aGF0IGEgYmlnDQpvdXQtb2Ytb3JkZXIgY29yZSBjYW4gZWFzaWx5IGFic29yYiB0 aGUgaGl0IGluIHRoZSBzaGFkb3cgb2Ygb3RoZXINCm9wZXJhdGlvbnMuwqDCoCBTbWFsbGVyIGNv cmVzIGNhbm5vdCwgYW5kIEknbSBjb25maWRlbnQgdGhhdCBhZGVxdWF0ZQ0KcGVyZm9ybWFuY2Ug dGVzdGluZyB3b3VsZCBoYXZlIGRlbW9uc3RyYXRlZCB0aGlzLg0KDQpVbmFkZHJlc3NlZCBpcyB0 aGUgY29kZSBibG9hdCBmcm9tIHRoZSBjaGFuZ2U7IHJlbGV2YW50IGJlY2F1c2UgaXQgaXMNCnRo ZSBuZWdhdGl2ZSBoYWxmIG9mIHRoZSB0cmFkZW9mZiBvbiB3aGF0IGlzIGFsbGVnZWRseSBhIG5l dCBpbXByb3ZlbWVudA0Kb24gYSBmYXN0cGF0aC7CoCBBY3R1YWxseSB0cnlpbmcgdG8gcmVhc29u IGFib3V0IHRoZSBjb2RlIGJsb2F0IHdvdWxkDQpoYXZlIGhpZ2hsaWdodGVkIHdoeSBpdCdzIHJh dGhlciBpbXBvcnRhbnQgdGhhdCB0aGUgbG9naWMgYmUgaW1wbGVtZW50ZWQNCmFzIGEgcmVhbCBm dW5jdGlvbiByYXRoZXIgdGhhbiBhIG1hY3JvLg0KDQpBbHNvIHVuYWRkcmVzc2VkIGlzIHdoZXRo ZXIgdGhlIG11bHRpLW5lc3RpbmcgZXZlbiBoYXMgYW55IHV0aWxpdHksIGFuZA0KaWYgaXQgZG9l cywgd2hhdCBpdCBkb2VzIHRvIHRoZSBvdGhlciBraW5kcyBvZiB3b3JrbG9hZHMuDQoNClVuYWRk cmVzc2VkIHRvbyBpcyB0aGUgaW1wYWN0IGZyb20gWFNBcyAzOTggYW5kIDQwNyB3aGljaCwgYXMg bWVtYmVycyBvZg0KdGhlIHNlY3VyaXR5IHRlYW0sIHlvdSBoYWQgc3Vic3RhbnRpYWxseSBtb3Jl IGV4cG9zdXJlIHRvIHRoYW4gbW9zdC4NCg0KDQpUYWtpbmcgYSBzdGVwIGJhY2sgZnJvbSBsb3cg bGV2ZWwgaXNzdWVzLg0KDQpUaGlzIHNlcmllcyBpbnRyb2R1Y2VzIGEgTklIIGRvbWFpbi1zcGVj aWZpYyBsYW5ndWFnZSBmb3IgZGVzY3JpYmluZw0KaHlwZXJjYWxscywgYnV0IGxhY2tpbmcgaW4g YW55IGRvY3VtZW50YXRpb24uwqAgQXMgYW4gZXhlcmNpc2UgdG8gb3RoZXJzLA0KdGltZSBob3cg bG9uZyBpdCB0YWtlcyB5b3UgdG8gZ2V0IGNvbXBpbGUgYSBoeXBlcnZpc29yIHdpdGggYSBuZXcN Cmh5cGVyY2FsbCB0aGF0IHRha2VzIGUuZy4gb25lIGludGVnZXIgYW5kIG9uZSBwb2ludGVyIHBh cmFtZXRlci7CoCBUaGVyZQ0Kc2hvdWxkIGJlIGEgd2hvbGUgbG90IG1vcmUgYWNrcyBvbiB0aGF0 IHBhdGNoIGZvciBpdCB0byBiZSBjb25zaWRlcmVkIHRvDQpoYXZlIGFuIGFkZXF1YXRlIHJldmll dy4NCg0KU29tZXdoZXJlIChJIGNhbid0IHJlY2FsbCB3aGVyZSwgYnV0IGl0J3MgNCBpbiB0aGUg bW9ybmluZyBzbyBJJ20gbm90DQpsb29raW5nIGZvciBpdCBub3cpLCBhIHN0YXRlbWVudCB3YXMg bWFkZSB0aGF0IGlmIGlzc3VlcyB3ZXJlIGZvdW5kIHRoZXkNCmNvdWxkIGJlIGFkZHJlc3NlZCBn b2luZyBmb3J3YXJkcy7CoCBCdXQgdGhlIHNlcmllcyB3YXMgY29tbWl0dGVkIHdpdGhvdXQNCmFu eSBwb3NzaWJpbGl0eSBmb3IgYW55b25lIHRvIHBlcmZvcm0gdGhlIHRlc3RpbmcgcmVxdWVzdGVk IG9mIHRoZQ0Kb3JpZ2luYWwgc3VibWlzc2lvbi4NCg0KVGhlcmUgd2FzIG9uZSByZWRlZW1pbmcg cHJvcGVydHkgb2YgdGhlIHNlcmllcywgYW5kIHlldCB0aGVyZSB3YXMgbm8NCmRpc2N1c3Npb24g YW55d2hlcmUgYWJvdXQgZnVuY3Rpb24gcG9pbnRlciBjYXN0cy7CoCBCdXQgZ2l2ZW4gdGhhdCB0 aGUNCnByZW1pc2Ugd2FzIGRpc3B1dGVkIHRvIGJlZ2luIHdpdGgsIGFuZCB0aGUgcGVyZm9ybWFu Y2UgdGVzdGluZyB0aGF0DQpzdG9vZCBhbiBvdXRzaWRlIGNoYW5jZSBvZiBjb3VudGVyaW5nIHRo ZSBkaXNwdXRlIHdhcyBpZ25vcmVkLCBhbmQNCi90aGVuLyB0aGF0IG15IG9iamVjdGlvbnMgd2Vy ZSBkaXNyZWdhcmRlZCBhbmQgdGhlIHNlcmllcyBjb21taXR0ZWQNCndpdGhvdXQgY2FsbGluZyBh IHZvdGUsIEkgaGF2ZSB0byBzYXkgdGhhdCBJJ20gdmVyeSBkaXNwbGVhc2VkIHdpdGggaG93DQp0 aGlzIHdlbnQuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri Nov 04 05:26:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 05:26:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437278.691541 (Exim 4.92) (envelope-from ) id 1oqpDc-0004Yw-MI; Fri, 04 Nov 2022 05:26:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437278.691541; Fri, 04 Nov 2022 05:26:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqpDc-0004Yp-Ib; Fri, 04 Nov 2022 05:26:16 +0000 Received: by outflank-mailman (input) for mailman id 437278; Fri, 04 Nov 2022 05:26:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqpDb-0004Yj-En for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 05:26:15 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 325a7165-5c01-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 06:26:13 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 603E72189A; Fri, 4 Nov 2022 05:26:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 220E71346F; Fri, 4 Nov 2022 05:26:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IE34BnSiZGOfDgAAMHmgww (envelope-from ); Fri, 04 Nov 2022 05:26:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 325a7165-5c01-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667539572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Djrd93CGqgfukS0X6L4qoN5LdoVsSUW9kV4JSANiJ6Y=; b=n2JkqHahQfBb5RCUC8Rx0Xi9eVjcl/fTNpXFXfHj6sRFa1KWqiBYmiU6j0S48GLBjHX7Qq La0QC9+B1JUqtA+X618DRtE+Op29VEL0DHW65otXi+j+R7/ldWMHBQLIJ55tAh/bkvDS6Z 0ZmxW2B73aUHAHjmoy0bcYUsDu8UT24= Message-ID: Date: Fri, 4 Nov 2022 06:26:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Content-Language: en-US To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang References: <20221103163631.13145-1-jgross@suse.com> From: Juergen Gross Subject: Re: Revert of the 4.17 hypercall handler changes Re: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------HtzEsG4XTbMGCMJUqeL4ZwUF" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------HtzEsG4XTbMGCMJUqeL4ZwUF Content-Type: multipart/mixed; boundary="------------CNhJV7xvs6AgUgbVyiCDXkPQ"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang Message-ID: Subject: Re: Revert of the 4.17 hypercall handler changes Re: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers References: <20221103163631.13145-1-jgross@suse.com> In-Reply-To: --------------CNhJV7xvs6AgUgbVyiCDXkPQ Content-Type: multipart/mixed; boundary="------------UPuAP82ACL0jTna2VviEimP1" --------------UPuAP82ACL0jTna2VviEimP1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMTEuMjIgMDY6MDEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDAzLzExLzIw MjIgMTY6MzYsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBUaGUgY29kZSBnZW5lcmF0ZWQg Zm9yIHRoZSBjYWxsX2hhbmRsZXJzXyooKSBtYWNyb3MgbmVlZHMgdG8gYXZvaWQNCj4+IHVu ZGVmaW5lZCBiZWhhdmlvciB3aGVuIG11bHRpcGxlIGhhbmRsZXJzIHNoYXJlIHRoZSBzYW1l IHByaW9yaXR5Lg0KPj4gVGhlIGlzc3VlIGlzIHRoZSBoeXBlcmNhbGwgbnVtYmVyIGJlaW5n IHVudmVyaWZpZWQgZmVkIGludG8gdGhlIG1hY3Jvcw0KPj4gYW5kIHRoZW4gdXNlZCB0byBz ZXQgYSBtYXNrIHZpYSAibWFzayA9IDFVTEwgPDwgPGh5cGVyY2FsbC1udW1iZXI+Ii4NCj4+ DQo+PiBBdm9pZCBhIHNoaWZ0IGFtb3VudCBvZiBtb3JlIHRoYW4gNjMgYnkgc2V0dGluZyBt YXNrIHRvIHplcm8gaW4gY2FzZQ0KPj4gdGhlIGh5cGVyY2FsbCBudW1iZXIgaXMgdG9vIGxh cmdlLg0KPj4NCj4+IEZpeGVzOiBlY2ExZjAwZDAyMjcgKCJ4ZW46IGdlbmVyYXRlIGh5cGVy Y2FsbCBpbnRlcmZhY2UgcmVsYXRlZCBjb2RlIikNCj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4gDQo+IFRoaXMgaXMgbm90IGEgc3VpdGFi bGUgZml4LsKgIFRoZXJlIGJlaW5nIGEgc2VjdXJpdHkgaXNzdWUgaXMganVzdCB0aGUNCj4g dGlwIG9mIHRoZSBpY2ViZXJnLg0KPiANCj4gVGhlIGNoYW5nZXMgYnJva2UgdGhlIGtleGVj X29wKCkgQUJJIGFuZCB0aGlzIGlzIGEgYmxvY2tpbmcgcmVncmVzc2lvbg0KPiB2cyA0LjE2 Lg0KDQpJIHQgd291bGQgcmVhbGx5IGJlIGJlbmVmaWNpYWwgaWYgeW91IHdvdWxkIGp1c3Qg dGVsbCB3aGF0IHRoZSBpc3N1ZXMNCmFyZSBpbnN0ZWFkIG9mIHZvaWNpbmcgc29tZSB2YWd1 ZSBjb25jZXJucyBhbmQgdGhlbiBkcm9wcGluZyBvZmYgdG8NCnNpbGVuY2UgYWdhaW4gd2hl biBhc2tlZCAocGFydGlhbGx5IG11bHRpcGxlIHRpbWVzKSB3aGF0IHRoZSByZWFsDQpwcm9i bGVtcyBhcmUuDQoNCj4gSW4gbGlldSBvZiBoYXZpbmcgdGltZSB0byBkbw0KPiBodHRwczov L2dpdGxhYi5jb20veGVuLXByb2plY3QveGVuLy0vaXNzdWVzLzkzLCBoZXJlJ3MgdGhlIGFi cmlkZ2VkIGxpc3QNCj4gb2YgZXJyb3JzDQo+IA0KPiBUaGUgc2VyaWVzIGNsYWltcyAiVGhp cyBpcyBiZW5lZmljaWFsIHRvIHBlcmZvcm1hbmNlIGFuZCBhdm9pZHMNCj4gc3BlY3VsYXRp b24gaXNzdWVzLiIsIGMvcyA4NTIzODUxZGJjNC4NCj4gDQo+IFRoYXQgaGFsZiBzZW50ZW5j ZSBpcyBsaXRlcmFsbHkgdGhlIHN1bSB0b3RhbCBvZiBqdXN0aWZpY2F0aW9uIGdpdmVuIGZv cg0KPiB0aGlzIGJlaW5nIHJlbGF0ZWQgdG8gc3BlY3VsYXRpb24uDQo+IA0KPiBUaGUgb3Ro ZXIgaGFsZiBvZiB0aGUgc2VudGVuY2UgY2xhaW1zIHBlcmZvcm1hbmNlLsKgIEJ1dCBubyBw ZXJmb3JtYW5jZQ0KPiB0ZXN0aW5nIHdhcyBkb25lOyB0aGUgY292ZXIgbGV0dGVyIHRhbGtz IGFib3V0IG9uZSB0ZXN0IHdpdGggc3BlY2lmaWNzLA0KPiBidXQgaXQgZGVzY3JpYmVzIGEg c2NlbmFyaW8gd2hlcmUgdGhlIGRlbHRhIHdhcyBhIGhhbmRmdWwgb2YgY3ljbGVzDQo+IGRp ZmZlcmVuY2UsIGFzIG9uZSBwYXJ0IGluIG11bHRpLW1pbGxpb25zLCBwcm9iYWJseSBiaWxs aW9ucy7CoCBUaGVyZSBpcw0KPiBubyBwbGF1c2libGUgd2F5IHRoYXQgd2hhdGV2ZXIgcmF3 IGRhdGEgbGVhZCB0byB0aGUgIjwxJSBpbXByb3ZlbWVudCINCj4gY2xhaW0gd2FzIHN0YXRp c3RpY2FsbHkgc2lnbmlmaWNhbnQuDQoNClllcywgYW5kIHlvdSB0b2xkIG1lIHRvIGRvIHNv bWUgbW9yZSBwZXJmb3JtYW5jZSB0ZXN0aW5nIHdpdGggWGVuU2VydmVyDQphbmQgeW91IGV2 ZW4gZGlkbid0IHJlc3BvbmQgdG8gcXVlcmllcyByZWdhcmRpbmcgdGhlIHN0YXRlIG9mIHRo YXQNCnRlc3RpbmcuDQoNCj4gVGhlIHJlYXNvbiBhIHBlcmZvcm1hbmNlIGltcHJvdmVtZW50 IGNhbm5vdCBiZSBtZWFzdXJlZCBpcyB0aGF0IGEgYmlnDQo+IG91dC1vZi1vcmRlciBjb3Jl IGNhbiBlYXNpbHkgYWJzb3JiIHRoZSBoaXQgaW4gdGhlIHNoYWRvdyBvZiBvdGhlcg0KPiBv cGVyYXRpb25zLsKgwqAgU21hbGxlciBjb3JlcyBjYW5ub3QsIGFuZCBJJ20gY29uZmlkZW50 IHRoYXQgYWRlcXVhdGUNCj4gcGVyZm9ybWFuY2UgdGVzdGluZyB3b3VsZCBoYXZlIGRlbW9u c3RyYXRlZCB0aGlzLg0KPiANCj4gVW5hZGRyZXNzZWQgaXMgdGhlIGNvZGUgYmxvYXQgZnJv bSB0aGUgY2hhbmdlOyByZWxldmFudCBiZWNhdXNlIGl0IGlzDQo+IHRoZSBuZWdhdGl2ZSBo YWxmIG9mIHRoZSB0cmFkZW9mZiBvbiB3aGF0IGlzIGFsbGVnZWRseSBhIG5ldCBpbXByb3Zl bWVudA0KPiBvbiBhIGZhc3RwYXRoLsKgIEFjdHVhbGx5IHRyeWluZyB0byByZWFzb24gYWJv dXQgdGhlIGNvZGUgYmxvYXQgd291bGQNCj4gaGF2ZSBoaWdobGlnaHRlZCB3aHkgaXQncyBy YXRoZXIgaW1wb3J0YW50IHRoYXQgdGhlIGxvZ2ljIGJlIGltcGxlbWVudGVkDQo+IGFzIGEg cmVhbCBmdW5jdGlvbiByYXRoZXIgdGhhbiBhIG1hY3JvLg0KDQpZb3UgaGFkIHNldmVyYWwg d2Vla3MgdG8gYnJpbmcgdXAgdGhhdCBjb25jZXJuLCB5ZXQgeW91IGRpZG4ndC4NCg0KPiBB bHNvIHVuYWRkcmVzc2VkIGlzIHdoZXRoZXIgdGhlIG11bHRpLW5lc3RpbmcgZXZlbiBoYXMg YW55IHV0aWxpdHksIGFuZA0KPiBpZiBpdCBkb2VzLCB3aGF0IGl0IGRvZXMgdG8gdGhlIG90 aGVyIGtpbmRzIG9mIHdvcmtsb2Fkcy4NCj4gDQo+IFVuYWRkcmVzc2VkIHRvbyBpcyB0aGUg aW1wYWN0IGZyb20gWFNBcyAzOTggYW5kIDQwNyB3aGljaCwgYXMgbWVtYmVycyBvZg0KPiB0 aGUgc2VjdXJpdHkgdGVhbSwgeW91IGhhZCBzdWJzdGFudGlhbGx5IG1vcmUgZXhwb3N1cmUg dG8gdGhhbiBtb3N0Lg0KPiANCj4gDQo+IFRha2luZyBhIHN0ZXAgYmFjayBmcm9tIGxvdyBs ZXZlbCBpc3N1ZXMuDQo+IA0KPiBUaGlzIHNlcmllcyBpbnRyb2R1Y2VzIGEgTklIIGRvbWFp bi1zcGVjaWZpYyBsYW5ndWFnZSBmb3IgZGVzY3JpYmluZw0KPiBoeXBlcmNhbGxzLCBidXQg bGFja2luZyBpbiBhbnkgZG9jdW1lbnRhdGlvbi7CoCBBcyBhbiBleGVyY2lzZSB0byBvdGhl cnMsDQo+IHRpbWUgaG93IGxvbmcgaXQgdGFrZXMgeW91IHRvIGdldCBjb21waWxlIGEgaHlw ZXJ2aXNvciB3aXRoIGEgbmV3DQo+IGh5cGVyY2FsbCB0aGF0IHRha2VzIGUuZy4gb25lIGlu dGVnZXIgYW5kIG9uZSBwb2ludGVyIHBhcmFtZXRlci7CoCBUaGVyZQ0KPiBzaG91bGQgYmUg YSB3aG9sZSBsb3QgbW9yZSBhY2tzIG9uIHRoYXQgcGF0Y2ggZm9yIGl0IHRvIGJlIGNvbnNp ZGVyZWQgdG8NCj4gaGF2ZSBhbiBhZGVxdWF0ZSByZXZpZXcuDQo+IA0KPiBTb21ld2hlcmUg KEkgY2FuJ3QgcmVjYWxsIHdoZXJlLCBidXQgaXQncyA0IGluIHRoZSBtb3JuaW5nIHNvIEkn bSBub3QNCj4gbG9va2luZyBmb3IgaXQgbm93KSwgYSBzdGF0ZW1lbnQgd2FzIG1hZGUgdGhh dCBpZiBpc3N1ZXMgd2VyZSBmb3VuZCB0aGV5DQo+IGNvdWxkIGJlIGFkZHJlc3NlZCBnb2lu ZyBmb3J3YXJkcy7CoCBCdXQgdGhlIHNlcmllcyB3YXMgY29tbWl0dGVkIHdpdGhvdXQNCj4g YW55IHBvc3NpYmlsaXR5IGZvciBhbnlvbmUgdG8gcGVyZm9ybSB0aGUgdGVzdGluZyByZXF1 ZXN0ZWQgb2YgdGhlDQo+IG9yaWdpbmFsIHN1Ym1pc3Npb24uDQoNCkZ1bm55IHN0YXRlbWVu dC4NCg0KVGhlIHNlcmllcyB3YXMgcGVuZGluZyBmb3IgYmVpbmcgY29tbWl0dGVkIGZvciBz ZXZlcmFsIG1vbnRocywgSSBkaWQgcGluZw0KbXVsdGlwbGUgdGltZXMgZm9yIGFueSBmZWVk YmFjayAoZXNwZWNpYWxseSB5b3UpIGFuZCB5b3UgZGlkbid0IGV2ZW4NCnJlc3BvbmQgd2l0 aCBhICJJJ2xsIGNvbWUgYmFjayB0byBpdCBsYXRlciIuIFlvdSBqdXN0IGJlaGF2ZWQgbGlr ZQ0KL2Rldi9udWxsLiBUaGF0IHdhcyBkaXNjdXNzZWQgZXZlbiBpbiB0aGUgY29tbXVuaXR5 IGNhbGwsIHdoZXJlIHRoZQ0KZGVjaXNpb24gd2FzIHRha2VuIHRvIGZpbmFsbHkgYXBwbHkg dGhlIHNlcmllcyB3aXRoIHlvdSBub3QgZXZlbiByZWFjdGluZw0KaW4gYSBtaW5pbWFsIHdh eS4NCg0KPiBUaGVyZSB3YXMgb25lIHJlZGVlbWluZyBwcm9wZXJ0eSBvZiB0aGUgc2VyaWVz LCBhbmQgeWV0IHRoZXJlIHdhcyBubw0KPiBkaXNjdXNzaW9uIGFueXdoZXJlIGFib3V0IGZ1 bmN0aW9uIHBvaW50ZXIgY2FzdHMuwqAgQnV0IGdpdmVuIHRoYXQgdGhlDQo+IHByZW1pc2Ug d2FzIGRpc3B1dGVkIHRvIGJlZ2luIHdpdGgsIGFuZCB0aGUgcGVyZm9ybWFuY2UgdGVzdGlu ZyB0aGF0DQo+IHN0b29kIGFuIG91dHNpZGUgY2hhbmNlIG9mIGNvdW50ZXJpbmcgdGhlIGRp c3B1dGUgd2FzIGlnbm9yZWQsIGFuZA0KPiAvdGhlbi8gdGhhdCBteSBvYmplY3Rpb25zIHdl cmUgZGlzcmVnYXJkZWQgYW5kIHRoZSBzZXJpZXMgY29tbWl0dGVkDQo+IHdpdGhvdXQgY2Fs bGluZyBhIHZvdGUsIEkgaGF2ZSB0byBzYXkgdGhhdCBJJ20gdmVyeSBkaXNwbGVhc2VkIHdp dGggaG93DQo+IHRoaXMgd2VudC4NCg0KWWVzLCBtZSB0b28uDQoNCkJlaW5nIGFza2VkIGZv ciBzcGVjaWZpYyBjb25jZXJucyBtdWx0aXBsZSB0aW1lcywgbm90IHJlYWN0aW5nLCBhbmQg dGhlbg0KY29taW5nIGJhY2sgYWZ0ZXIgbW9udGhzIHRoYXQgeW91IGhhdmUgYmVlbiBpZ25v cmVkIGlzIGp1c3QgZGlzZ3VzdGluZy4NCg0KDQpKdWVyZ2VuDQo= --------------UPuAP82ACL0jTna2VviEimP1 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------UPuAP82ACL0jTna2VviEimP1-- --------------CNhJV7xvs6AgUgbVyiCDXkPQ-- --------------HtzEsG4XTbMGCMJUqeL4ZwUF Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNkonMFAwAAAAAACgkQsN6d1ii/Ey9n wggAkFBc2qPkS7HL4sxv9lcMtw+li82FEwMhbT7gEdGmkbDQP1hjUXdXxGERPvQeQtxhsOjK1cFt NYfu/psMU17ynjYkWX/lXYJa4Zrjz4nbAFI3plxg1mC05+y1fdlicaRV6lvPYoTiIOB02iiy092i Zy+/SP2Kco1E3DvK/fH9MNd9MGqHNGsxOqMsrlot71AEvzrAb3ImrBQ0+CnskO32HtvOJBJfcstF 7f8kKNSVOfSGFmUgxHNELweQHa76F1mk6Zs9sbX9YLd/HqQFmPKD/4hdGz+GwPlDS3YzizyXAU05 Lu+9egKhJ/O2zEIQPrtFYJdkq9eZuxTY2aNOCOMnVg== =FdzR -----END PGP SIGNATURE----- --------------HtzEsG4XTbMGCMJUqeL4ZwUF-- From xen-devel-bounces@lists.xenproject.org Fri Nov 04 06:10:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 06:10:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437286.691552 (Exim 4.92) (envelope-from ) id 1oqpum-0003jv-4k; Fri, 04 Nov 2022 06:10:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437286.691552; Fri, 04 Nov 2022 06:10:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqpum-0003jo-0n; Fri, 04 Nov 2022 06:10:52 +0000 Received: by outflank-mailman (input) for mailman id 437286; Fri, 04 Nov 2022 06:10:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqpuk-0003je-QF; Fri, 04 Nov 2022 06:10:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqpuk-0007ue-MZ; Fri, 04 Nov 2022 06:10:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqpuk-0005KJ-2e; Fri, 04 Nov 2022 06:10:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqpuk-0003Tc-25; Fri, 04 Nov 2022 06:10:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AcqRnhPEe5Kth0uXj+407HM/qvE5tJLHe6oie4q+tKk=; b=q5O5Rn7Uw856rVe/aCY8GPCSjz SNVZlu/KRSK7pvBKc8wZAQ5gs/x+OHi+Sr2TGnDngX6MgF5WrJ+LwOGyKRsQ9eP/6cfmc3AMD33WG TfPQQ/IvYymRj/W121hInf0JsDrfj9TJ5mhPg7qkZJRolCmp9KIG2C1oAmyOMU96qSe4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174608: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a0d9384967214783a92973c920092b7251c03e57 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Fri, 04 Nov 2022 06:10:50 +0000 flight 174608 linux-5.4 real [real] flight 174615 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174608/ http://logs.test-lab.xenproject.org/osstest/logs/174615/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174615 REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-shadow 7 xen-install fail pass in 174615-retest test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 174615-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 174615 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 174615 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux a0d9384967214783a92973c920092b7251c03e57 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 5 days Failing since 174575 2022-11-01 18:42:39 Z 2 days 4 attempts Testing same since 174608 2022-11-03 19:46:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anssi Hannula Arnaldo Carvalho de Melo Biju Das Brian Foster Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Darrick J. Wong Darrick J. Wong Dave Chinner David S. Miller Demi Marie Obenour Dongliang Mu Eric Dumazet Florian Fainelli Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hannu Hartikainen Hans Verkuil Heiko Carstens Helge Deller Hyong Youb Kim Hyunwoo Kim Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jeff Vanhoof Jens Glathe Jimmy Assarsson Johan Hovold Jon Hunter Jon Maloy Jonathan Cameron Josh Poimboeuf Juergen Gross Justin Chen Konrad Jankowski Kuogee Hsieh Leon Romanovsky Linux Kernel Functional Testing Luiz Capitulino M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Michal Jaron Mike Kravetz Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Paolo Abeni Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rik van Riel Saeed Mahameed Sakari Ailus Sasha Levin Shreeya Patel Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Thinh Nguyen Tom Lendacky Tony O'Brien Ulf Hansson Vasily Gorbik Vineet Gupta Vladimir Oltean Wei Yongjun Xin Long Yang Yingliang Yongqin Liu Zhang Changzhong Zhengchao Shao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2244 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Nov 04 06:11:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 06:11:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437291.691562 (Exim 4.92) (envelope-from ) id 1oqpve-0004GF-EZ; Fri, 04 Nov 2022 06:11:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437291.691562; Fri, 04 Nov 2022 06:11:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqpve-0004G8-Bj; Fri, 04 Nov 2022 06:11:46 +0000 Received: by outflank-mailman (input) for mailman id 437291; Fri, 04 Nov 2022 06:11:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqpvd-0004Fw-3d; Fri, 04 Nov 2022 06:11:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqpvd-0007vq-2l; Fri, 04 Nov 2022 06:11:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqpvc-0005M9-MC; Fri, 04 Nov 2022 06:11:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqpvc-0004PB-Lj; Fri, 04 Nov 2022 06:11:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Q1z68JeZUc1+Q98M+Cw4vgXbBMdbeG39kObe+f87W0k=; b=V6kjWqPNGPe7YBIiQ7cyZF7uvW F0CeUiZfQN/7M47hp8Z6zMNeaLsCckYHf+dMdiwr+lOdp7uqbbIAWoFwp+mf52lGG9PmlnonsEzTL Hu5pbFg0byoV7qkXYoDPkk+4EWD7TXaw48tfxF+nXqS5trT31nIDGDZyzNA+5TV0r+aM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174613: all pass - PUSHED X-Osstest-Versions-This: ovmf=ee3da09bb2b7284a8bda6b7d85160cdd63cfb405 X-Osstest-Versions-That: ovmf=cab1f02565d3b29081dd21afb074f35fdb4e1fd6 From: osstest service owner Date: Fri, 04 Nov 2022 06:11:44 +0000 flight 174613 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174613/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ee3da09bb2b7284a8bda6b7d85160cdd63cfb405 baseline version: ovmf cab1f02565d3b29081dd21afb074f35fdb4e1fd6 Last test of basis 174610 2022-11-04 02:11:52 Z 0 days Testing same since 174613 2022-11-04 04:10:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chasel Chiu Sivaparvathi C Sivaparvathi chellaiah jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git cab1f02565..ee3da09bb2 ee3da09bb2b7284a8bda6b7d85160cdd63cfb405 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Nov 04 06:54:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 06:54:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437304.691576 (Exim 4.92) (envelope-from ) id 1oqqb1-0002aZ-Pc; Fri, 04 Nov 2022 06:54:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437304.691576; Fri, 04 Nov 2022 06:54:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqqb1-0002aS-My; Fri, 04 Nov 2022 06:54:31 +0000 Received: by outflank-mailman (input) for mailman id 437304; Fri, 04 Nov 2022 06:54:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqqb0-0002aM-Ff for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 06:54:30 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 867b9e33-5c0d-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 07:54:29 +0100 (CET) Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-66-83zJb6djOW-xhVjVFiHnpA-1; Fri, 04 Nov 2022 02:54:24 -0400 Received: by mail-pf1-f197.google.com with SMTP id f19-20020a056a001ad300b0056dd07cebfcso1956783pfv.3 for ; Thu, 03 Nov 2022 23:54:24 -0700 (PDT) Received: from [10.72.13.71] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id p188-20020a62d0c5000000b005668b26ade0sm1863136pfg.136.2022.11.03.23.54.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 23:54:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 867b9e33-5c0d-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667544867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1PLwjNrS10hAl93Noag9w4eSRGv8NX8MdSS5oxSA4BI=; b=NWuvKMgQ0QkWOfkeqq/CcGC/Jt0iXqri+o9K6aO3z3WOIgJt2ZNhTl/CgBjXkHMtsC890o m07qBdLlUPdrlGWHff/dHxNwcPMy04TTJUOJbuTLu0b7UwuKE1l2OGszhhooksOYIYmluo 2A41+L4lhUhwNFJfqNBG1WRi/cpIXC4= X-MC-Unique: 83zJb6djOW-xhVjVFiHnpA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1PLwjNrS10hAl93Noag9w4eSRGv8NX8MdSS5oxSA4BI=; b=b4AsANUzE+t8UjYQ574Q0IavlXTWX5Qh9fBdFW4RiwfIEfY0zaMqlqTbsmeGXJ7rmj U7XvOT8Eg7z7AcuvmwivIq3nrcvQUBEW3GsMeYft4lty7TvSzKwAAZWwuzPflvh+REj8 quCHrEoAjOAoTB2oIyLPnBusdtPUj1cqTTyX1jDH5BU+qjL3dM1oLNUgf1W6mwBXV9Am A6V4w7nJ/lXBT5k/LBCvy7Zi5fUe7PiEZJ/uki6BWJc2CN0fsvjGonmaWurSyMLl1WFM PdbQZWEZ5fCe1z7Uwc/JCG+Mqe8eyHaztIVhGqeofygmvAC7RuRuDPlhg+Gj0o7AJKy2 MHNQ== X-Gm-Message-State: ACrzQf0Sb0b67+PXvQ2w2zW2VWxJoNe4OtDjy7r7wsIahChzaAy7Qlwt gCWlged+i83VUe5hInWIPJ0f/K9EUM3GBuWtPqSkT8/fgdaIqmAJH1Sn9DRHTJ4Bii/cGNV+KNa it4XPegNqPp4meV+33ydUuzuYHlk= X-Received: by 2002:a17:902:eb8a:b0:186:949e:8eb6 with SMTP id q10-20020a170902eb8a00b00186949e8eb6mr34444902plg.63.1667544863243; Thu, 03 Nov 2022 23:54:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5oynVY5eRCch1+7iu0gHDiqvgDtt/2V13XPjw3vIEzqAfpQKMY9zH+TdeGGfW+fRvotJU5mg== X-Received: by 2002:a17:902:eb8a:b0:186:949e:8eb6 with SMTP id q10-20020a170902eb8a00b00186949e8eb6mr34444879plg.63.1667544862994; Thu, 03 Nov 2022 23:54:22 -0700 (PDT) Message-ID: Date: Fri, 4 Nov 2022 14:54:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v14 16/17] tests/qtest: netdev: test stream and dgram backends To: Laurent Vivier , qemu-devel@nongnu.org Cc: Thomas Huth , xen-devel@lists.xenproject.org, "Dr. David Alan Gilbert" , Anthony Perard , Stefan Weil , David Gibson , Stefano Stabellini , Paul Durrant , Eric Blake , "Michael S. Tsirkin" , Paolo Bonzini , Markus Armbruster , Samuel Thibault , Greg Kurz , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <20221021090922.170074-1-lvivier@redhat.com> <20221021090922.170074-17-lvivier@redhat.com> <700ef645-6cb6-66e6-00a9-3db187be0c43@redhat.com> <0fd82709-7612-25e0-66c0-d9494931d8c4@redhat.com> From: Jason Wang In-Reply-To: <0fd82709-7612-25e0-66c0-d9494931d8c4@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2022/11/3 17:33, Laurent Vivier 写道: > On 10/28/22 07:04, Jason Wang wrote: >> >> 在 2022/10/21 17:09, Laurent Vivier 写道: >>> Signed-off-by: Laurent Vivier >>> Acked-by: Michael S. Tsirkin >>> --- >> >> >> I got this: >> >> 63/63 ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: >> assertion failed (resp == expect): ("st0: >> index=0,type=stream,connection error\r\n" == "st0: >> index=0,type=stream,tcp:::1:40389\r\n") ERROR >> 63/63 qemu:qtest+qtest-x86_64 / >> qtest-x86_64/netdev-socket                  ERROR 5.29s   killed by >> signal 6 SIGABRT >>  >>> QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64 >> MALLOC_PERTURB_=96 >> QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon >> G_TEST_DBUS_DAEMON=/home/devel/git/qemu/tests/dbus-vmstate-daemon.sh >> /home/devel/git/qemu/build/tests/qtest/netdev-socket --tap -k >> ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― >> ✀ >> ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― >> stderr: >> ** >> ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: >> assertion failed (resp == expect): ("st0: >> index=0,type=stream,connection error\r\n" == "st0: >> index=0,type=stream,tcp:::1:40389\r\n") >> >> (test program exited with status code -6) > > I'm not able to reproduce the problem. > > Is this 100% reproducible? Yes. > Is IPv6 enabled on your test machine? Yes. Try to investigate it more, it looks like the reason is hostname. I'm testing in ubunut which has the following things in /etc/hosts 127.0.0.1    localhost 127.0.1.1    jason-ThinkPad-X1-Carbon-6th 192.168.100.2   guest # The following lines are desirable for IPv6 capable hosts ::1     ip6-localhost ip6-loopback fe00::0 ip6-localnet ff00::0 ip6-mcastprefix ff02::1 ip6-allnodes ff02::2 ip6-allrouters So localhost is mapped to ipv4 and there's no ipv6 mappings here. Using "::1" for the address seems to fix the issue. Thanks > > Thanks, > Laurent > From xen-devel-bounces@lists.xenproject.org Fri Nov 04 07:27:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 07:27:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437311.691599 (Exim 4.92) (envelope-from ) id 1oqr6e-0008J0-G8; Fri, 04 Nov 2022 07:27:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437311.691599; Fri, 04 Nov 2022 07:27:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqr6e-0008Ir-DG; Fri, 04 Nov 2022 07:27:12 +0000 Received: by outflank-mailman (input) for mailman id 437311; Fri, 04 Nov 2022 07:27:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqr6d-0008IY-84 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 07:27:11 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 17daa2e5-5c12-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 08:27:10 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A291E1F45F; Fri, 4 Nov 2022 07:27:09 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 617DD1346F; Fri, 4 Nov 2022 07:27:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6mJuFs2+ZGPoQAAAMHmgww (envelope-from ); Fri, 04 Nov 2022 07:27:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17daa2e5-5c12-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667546829; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7CU5Zv+MxpH9Viqrq9cuAJbtGqlqKE19LW/YuoUb07c=; b=qYkY9pxgxg6T+WYDFEQiekn/4osT4g0p35HAaGDSfQwQrKhhNctHZb1BWOBAeTR+dlMt8T uKHXbdN891CkVW7s6SwPTrRIkHL4g9nbqHnCI6yuFWgngtrdQ67iYXEVUVmSIZgxOSkMC/ 1Wx0uzPfLiRHT8WEvQZQaBGGfnNcpZQ= From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH v2 1/5] x86: add X86_FEATURE_XENPV to disabled-features.h Date: Fri, 4 Nov 2022 08:26:57 +0100 Message-Id: <20221104072701.20283-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221104072701.20283-1-jgross@suse.com> References: <20221104072701.20283-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add X86_FEATURE_XENPV to the features handled specially in disabled-features.h. Signed-off-by: Juergen Gross --- arch/x86/include/asm/disabled-features.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/disabled-features.h b/arch/x86/include/asm/disabled-features.h index 33d2cd04d254..c862552d7d6d 100644 --- a/arch/x86/include/asm/disabled-features.h +++ b/arch/x86/include/asm/disabled-features.h @@ -81,6 +81,12 @@ # define DISABLE_SGX (1 << (X86_FEATURE_SGX & 31)) #endif +#ifdef CONFIG_XEN_PV +# define DISABLE_XENPV 0 +#else +# define DISABLE_XENPV (1 << (X86_FEATURE_XENPV & 31)) +#endif + #ifdef CONFIG_INTEL_TDX_GUEST # define DISABLE_TDX_GUEST 0 #else @@ -98,7 +104,7 @@ #define DISABLED_MASK5 0 #define DISABLED_MASK6 0 #define DISABLED_MASK7 (DISABLE_PTI) -#define DISABLED_MASK8 (DISABLE_TDX_GUEST) +#define DISABLED_MASK8 (DISABLE_XENPV|DISABLE_TDX_GUEST) #define DISABLED_MASK9 (DISABLE_SGX) #define DISABLED_MASK10 0 #define DISABLED_MASK11 (DISABLE_RETPOLINE|DISABLE_RETHUNK|DISABLE_UNRET) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 07:27:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 07:27:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437310.691588 (Exim 4.92) (envelope-from ) id 1oqr6Z-000839-9a; Fri, 04 Nov 2022 07:27:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437310.691588; Fri, 04 Nov 2022 07:27:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqr6Z-000832-61; Fri, 04 Nov 2022 07:27:07 +0000 Received: by outflank-mailman (input) for mailman id 437310; Fri, 04 Nov 2022 07:27:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqr6Y-00082w-KZ for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 07:27:06 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1492f60a-5c12-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 08:27:05 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 023DE1F74A; Fri, 4 Nov 2022 07:27:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A76AD1346F; Fri, 4 Nov 2022 07:27:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MCOfJ8e+ZGPWQAAAMHmgww (envelope-from ); Fri, 04 Nov 2022 07:27:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1492f60a-5c12-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667546824; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=bESrsZp5nkJG/KdIDLKESNyabZqvX9dwTKnh7zplFPc=; b=n9o+6s3UG78TbvKngU6Oi+3uY2MUMWfFweD7Wtr6ymwqRx4TqaGq8uvAMGtf83rd5scylQ CVX9dPWF40VZMavSSC6wYSTPb4UhtbL+OspARLblOSHwGV3nXiydvJ94caPsOJUvkYjpCW ITxrIbaCKjSBJNpgH6PrJran/aYm0MA= From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Pu Wen Subject: [PATCH v2 0/5] x86: Switch X86_FEATURE_XENPV to cpu_feature_enabled() use Date: Fri, 4 Nov 2022 08:26:56 +0100 Message-Id: <20221104072701.20283-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make especially kernels without CONFIG_XEN_PV more efficient by using cpu_feature_enabled(X86_FEATURE_XENPV) instead of boot_cpu_has() and friends. Changes in V2: - new patch 4 Juergen Gross (5): x86: add X86_FEATURE_XENPV to disabled-features.h x86: remove unneeded 64-bit dependency in arch_enter_from_user_mode() x86: drop 32-bit Xen PV guest code in update_task_stack() x86: remove X86_FEATURE_XENPV usage in setup_cpu_entry_area() x86: switch to cpu_feature_enabled() for X86_FEATURE_XENPV arch/x86/include/asm/disabled-features.h | 8 +++++++- arch/x86/include/asm/entry-common.h | 4 ++-- arch/x86/include/asm/switch_to.h | 7 ++----- arch/x86/kernel/cpu/amd.c | 2 +- arch/x86/kernel/cpu/bugs.c | 2 +- arch/x86/kernel/cpu/hygon.c | 2 +- arch/x86/kernel/process_64.c | 4 ++-- arch/x86/kernel/topology.c | 2 +- arch/x86/mm/cpu_entry_area.c | 8 ++------ 9 files changed, 19 insertions(+), 20 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 07:27:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 07:27:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437312.691609 (Exim 4.92) (envelope-from ) id 1oqr6j-0000B9-Nk; Fri, 04 Nov 2022 07:27:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437312.691609; Fri, 04 Nov 2022 07:27:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqr6j-0000As-Kx; Fri, 04 Nov 2022 07:27:17 +0000 Received: by outflank-mailman (input) for mailman id 437312; Fri, 04 Nov 2022 07:27:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqr6i-0008IY-AR for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 07:27:16 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1b3dc702-5c12-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 08:27:15 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5DDD71F88E; Fri, 4 Nov 2022 07:27:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 141161346F; Fri, 4 Nov 2022 07:27:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id g8RvA9O+ZGPxQAAAMHmgww (envelope-from ); Fri, 04 Nov 2022 07:27:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b3dc702-5c12-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667546835; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mK6Yb+HDZYey+MdThM5vOztF2LsAJko2NCXxRRCzJLc=; b=t3mgxfquxmqCHwEFGv0Srb4QFx+nwnJALEZtwSkmnIZa5QyQvTvP3kpfqv/K5cOhfote+p /6XtoH9b9jQ7QKZsswIc2w6HhjyjLmX6LHGnp8tZNaIvJHApg+HmnQoo5vQOu1OIrl4uXc ChvpghyJuz4ckYNeOxBRjHbbqoKGEKA= From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH v2 2/5] x86: remove unneeded 64-bit dependency in arch_enter_from_user_mode() Date: Fri, 4 Nov 2022 08:26:58 +0100 Message-Id: <20221104072701.20283-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221104072701.20283-1-jgross@suse.com> References: <20221104072701.20283-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The check for 64-bit mode when testing X86_FEATURE_XENPV isn't needed, as Xen PV guests are no longer supported in 32-bit mode. While at it switch from boot_cpu_has() to cpu_feature_enabled(). Signed-off-by: Juergen Gross --- arch/x86/include/asm/entry-common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/entry-common.h b/arch/x86/include/asm/entry-common.h index 674ed46d3ced..117903881fe4 100644 --- a/arch/x86/include/asm/entry-common.h +++ b/arch/x86/include/asm/entry-common.h @@ -24,8 +24,8 @@ static __always_inline void arch_enter_from_user_mode(struct pt_regs *regs) /* * For !SMAP hardware we patch out CLAC on entry. */ - if (boot_cpu_has(X86_FEATURE_SMAP) || - (IS_ENABLED(CONFIG_64BIT) && boot_cpu_has(X86_FEATURE_XENPV))) + if (cpu_feature_enabled(X86_FEATURE_SMAP) || + cpu_feature_enabled(X86_FEATURE_XENPV)) mask |= X86_EFLAGS_AC; WARN_ON_ONCE(flags & mask); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 07:27:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 07:27:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437314.691621 (Exim 4.92) (envelope-from ) id 1oqr6q-0000XA-1U; Fri, 04 Nov 2022 07:27:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437314.691621; Fri, 04 Nov 2022 07:27:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqr6p-0000X2-TZ; Fri, 04 Nov 2022 07:27:23 +0000 Received: by outflank-mailman (input) for mailman id 437314; Fri, 04 Nov 2022 07:27:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqr6o-0008IY-33 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 07:27:22 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1e9fd6f3-5c12-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 08:27:21 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0D699218EF; Fri, 4 Nov 2022 07:27:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BE74F1346F; Fri, 4 Nov 2022 07:27:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wt8nLdi+ZGP8QAAAMHmgww (envelope-from ); Fri, 04 Nov 2022 07:27:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e9fd6f3-5c12-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667546841; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZIOvMf0VCiOOdx+pSynOR3iuEcnpBNHWVTTFgfhwJA0=; b=EnjxfVY16idoJh9IIy4JkGsUyUCXsUVwU0w51egCCLg5DyQj3J7jxrbkA4rfngpNO2Pwv9 wov57FtNfpnF/SBFt652DKi5Xmswq2R3f0Y6Q5BJrjFYmZf8ZvCWawW+KwYgwKKIJlgZd1 wTqlkt/BxLqs95Vk1s+327B34/LytLo= From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH v2 3/5] x86: drop 32-bit Xen PV guest code in update_task_stack() Date: Fri, 4 Nov 2022 08:26:59 +0100 Message-Id: <20221104072701.20283-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221104072701.20283-1-jgross@suse.com> References: <20221104072701.20283-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Testing for Xen PV guest mode in a 32-bit only code section can be dropped, as Xen PV guests are supported in 64-bit mode only. While at it switch from boot_cpu_has() to cpu_feature_enabled() in the 64-bit part of the code. Signed-off-by: Juergen Gross --- arch/x86/include/asm/switch_to.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/x86/include/asm/switch_to.h b/arch/x86/include/asm/switch_to.h index c08eb0fdd11f..5c91305d09d2 100644 --- a/arch/x86/include/asm/switch_to.h +++ b/arch/x86/include/asm/switch_to.h @@ -66,13 +66,10 @@ static inline void update_task_stack(struct task_struct *task) { /* sp0 always points to the entry trampoline stack, which is constant: */ #ifdef CONFIG_X86_32 - if (static_cpu_has(X86_FEATURE_XENPV)) - load_sp0(task->thread.sp0); - else - this_cpu_write(cpu_tss_rw.x86_tss.sp1, task->thread.sp0); + this_cpu_write(cpu_tss_rw.x86_tss.sp1, task->thread.sp0); #else /* Xen PV enters the kernel on the thread stack. */ - if (static_cpu_has(X86_FEATURE_XENPV)) + if (cpu_feature_enabled(X86_FEATURE_XENPV)) load_sp0(task_top_of_stack(task)); #endif } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 07:27:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 07:27:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437315.691632 (Exim 4.92) (envelope-from ) id 1oqr6u-0000yc-89; Fri, 04 Nov 2022 07:27:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437315.691632; Fri, 04 Nov 2022 07:27:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqr6u-0000yO-5F; Fri, 04 Nov 2022 07:27:28 +0000 Received: by outflank-mailman (input) for mailman id 437315; Fri, 04 Nov 2022 07:27:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqr6t-0008IY-N1 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 07:27:27 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 22084a9b-5c12-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 08:27:27 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B9907218EE; Fri, 4 Nov 2022 07:27:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 69AA81346F; Fri, 4 Nov 2022 07:27:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RA1rGN6+ZGMMQQAAMHmgww (envelope-from ); Fri, 04 Nov 2022 07:27:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22084a9b-5c12-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667546846; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ly27pQKB8zJ1EGsnrKjc1hdO+HpUmQnfYr1acXfsIKI=; b=pWWGyaE1jxFj4EjMVnygdiccjsW9T7hMUI/EjyWLk8AOcDK33Qd3GEW3K8SxWXeOgef95G 4pBmTHfQ3c1oRljU9jKJyr7IKQEcy9YZVxjmPxb3hvDc/bi4jjizmVf1+YSdSVhgHNDng6 z8vF1yxfGykjPIdwW/UFsd6/FHzWfwI= From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Juergen Gross , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: [PATCH v2 4/5] x86: remove X86_FEATURE_XENPV usage in setup_cpu_entry_area() Date: Fri, 4 Nov 2022 08:27:00 +0100 Message-Id: <20221104072701.20283-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221104072701.20283-1-jgross@suse.com> References: <20221104072701.20283-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Testing of X86_FEATURE_XENPV in setup_cpu_entry_area() can be removed, as this code path is 32-bit only, and Xen PV guests are not supporting 32-bit mode. Signed-off-by: Juergen Gross --- V2: - new patch --- arch/x86/mm/cpu_entry_area.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/x86/mm/cpu_entry_area.c b/arch/x86/mm/cpu_entry_area.c index 6c2f1b76a0b6..42cd96e7d733 100644 --- a/arch/x86/mm/cpu_entry_area.c +++ b/arch/x86/mm/cpu_entry_area.c @@ -138,17 +138,13 @@ static void __init setup_cpu_entry_area(unsigned int cpu) pgprot_t tss_prot = PAGE_KERNEL_RO; #else /* - * On native 32-bit systems, the GDT cannot be read-only because + * On 32-bit systems, the GDT cannot be read-only because * our double fault handler uses a task gate, and entering through * a task gate needs to change an available TSS to busy. If the * GDT is read-only, that will triple fault. The TSS cannot be * read-only because the CPU writes to it on task switches. - * - * On Xen PV, the GDT must be read-only because the hypervisor - * requires it. */ - pgprot_t gdt_prot = boot_cpu_has(X86_FEATURE_XENPV) ? - PAGE_KERNEL_RO : PAGE_KERNEL; + pgprot_t gdt_prot = PAGE_KERNEL; pgprot_t tss_prot = PAGE_KERNEL; #endif -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 07:27:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 07:27:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437318.691643 (Exim 4.92) (envelope-from ) id 1oqr71-0001Yn-M6; Fri, 04 Nov 2022 07:27:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437318.691643; Fri, 04 Nov 2022 07:27:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqr71-0001YB-IR; Fri, 04 Nov 2022 07:27:35 +0000 Received: by outflank-mailman (input) for mailman id 437318; Fri, 04 Nov 2022 07:27:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqr6z-00082w-UQ for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 07:27:34 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 255d91ac-5c12-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 08:27:33 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5C775218EF; Fri, 4 Nov 2022 07:27:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1CDC51346F; Fri, 4 Nov 2022 07:27:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ITjcBeS+ZGMZQQAAMHmgww (envelope-from ); Fri, 04 Nov 2022 07:27:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 255d91ac-5c12-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667546852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ETDMSDRjzWVlC2eQNNmpxl8Qm+9vtlmDFMYqkaHH46A=; b=eJn1trHVH1GRxxTQIn3/dsYTb5dd6wFDdzEmr/pcuLJJrPFpEG0eUfoI8DIfdNdH2y+4rh u7Oyhpi+e9xO2n6z0/19haLXwlav+3Ni90QaysufhNHcaBLTqERRceU691XKyTAp6aS58d ABYUnkrtYpEaAfSJGb5XlddGJwlbvIg= From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Pu Wen Subject: [PATCH v2 5/5] x86: switch to cpu_feature_enabled() for X86_FEATURE_XENPV Date: Fri, 4 Nov 2022 08:27:01 +0100 Message-Id: <20221104072701.20283-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221104072701.20283-1-jgross@suse.com> References: <20221104072701.20283-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert the remaining cases of static_cpu_has(X86_FEATURE_XENPV) and boot_cpu_has(X86_FEATURE_XENPV) to use cpu_feature_enabled(), allowing more efficient code in case the kernel is configured without CONFIG_XEN_PV. Signed-off-by: Juergen Gross --- arch/x86/kernel/cpu/amd.c | 2 +- arch/x86/kernel/cpu/bugs.c | 2 +- arch/x86/kernel/cpu/hygon.c | 2 +- arch/x86/kernel/process_64.c | 4 ++-- arch/x86/kernel/topology.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index 860b60273df3..697fe881e967 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -985,7 +985,7 @@ static void init_amd(struct cpuinfo_x86 *c) set_cpu_cap(c, X86_FEATURE_3DNOWPREFETCH); /* AMD CPUs don't reset SS attributes on SYSRET, Xen does. */ - if (!cpu_has(c, X86_FEATURE_XENPV)) + if (!cpu_feature_enabled(X86_FEATURE_XENPV)) set_cpu_bug(c, X86_BUG_SYSRET_SS_ATTRS); /* diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c index da7c361f47e0..7f78e1527c5e 100644 --- a/arch/x86/kernel/cpu/bugs.c +++ b/arch/x86/kernel/cpu/bugs.c @@ -1302,7 +1302,7 @@ static enum spectre_v2_mitigation_cmd __init spectre_v2_parse_cmdline(void) return SPECTRE_V2_CMD_AUTO; } - if (cmd == SPECTRE_V2_CMD_IBRS && boot_cpu_has(X86_FEATURE_XENPV)) { + if (cmd == SPECTRE_V2_CMD_IBRS && cpu_feature_enabled(X86_FEATURE_XENPV)) { pr_err("%s selected but running as XenPV guest. Switching to AUTO select\n", mitigation_options[i].option); return SPECTRE_V2_CMD_AUTO; diff --git a/arch/x86/kernel/cpu/hygon.c b/arch/x86/kernel/cpu/hygon.c index 21fd425088fe..1c27645fd429 100644 --- a/arch/x86/kernel/cpu/hygon.c +++ b/arch/x86/kernel/cpu/hygon.c @@ -339,7 +339,7 @@ static void init_hygon(struct cpuinfo_x86 *c) set_cpu_cap(c, X86_FEATURE_ARAT); /* Hygon CPUs don't reset SS attributes on SYSRET, Xen does. */ - if (!cpu_has(c, X86_FEATURE_XENPV)) + if (!cpu_feature_enabled(X86_FEATURE_XENPV)) set_cpu_bug(c, X86_BUG_SYSRET_SS_ATTRS); check_null_seg_clears_base(c); diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index 6b3418bff326..e2f469175be8 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c @@ -165,7 +165,7 @@ static noinstr unsigned long __rdgsbase_inactive(void) lockdep_assert_irqs_disabled(); - if (!static_cpu_has(X86_FEATURE_XENPV)) { + if (!cpu_feature_enabled(X86_FEATURE_XENPV)) { native_swapgs(); gsbase = rdgsbase(); native_swapgs(); @@ -190,7 +190,7 @@ static noinstr void __wrgsbase_inactive(unsigned long gsbase) { lockdep_assert_irqs_disabled(); - if (!static_cpu_has(X86_FEATURE_XENPV)) { + if (!cpu_feature_enabled(X86_FEATURE_XENPV)) { native_swapgs(); wrgsbase(gsbase); native_swapgs(); diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c index 8617d1ed9d31..1b83377274b8 100644 --- a/arch/x86/kernel/topology.c +++ b/arch/x86/kernel/topology.c @@ -106,7 +106,7 @@ int arch_register_cpu(int num) * Xen PV guests don't support CPU0 hotplug at all. */ if (c->x86_vendor != X86_VENDOR_INTEL || - boot_cpu_has(X86_FEATURE_XENPV)) + cpu_feature_enabled(X86_FEATURE_XENPV)) cpu0_hotpluggable = 0; /* -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 07:36:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 07:36:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437343.691655 (Exim 4.92) (envelope-from ) id 1oqrFU-0004x2-JV; Fri, 04 Nov 2022 07:36:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437343.691655; Fri, 04 Nov 2022 07:36:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrFU-0004wv-E5; Fri, 04 Nov 2022 07:36:20 +0000 Received: by outflank-mailman (input) for mailman id 437343; Fri, 04 Nov 2022 07:36:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrFT-0004wl-7s; Fri, 04 Nov 2022 07:36:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrFT-0001H6-4U; Fri, 04 Nov 2022 07:36:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrFS-0000eT-EV; Fri, 04 Nov 2022 07:36:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqrFS-0002Pc-E3; Fri, 04 Nov 2022 07:36:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ud0O0tur8JG//jo+Vz/kaMqRgXlGcm9nNntHHVbN7B8=; b=2KAbqefp4qsPfykhtODR1OKjOe ioX4iZj1FtUuHd8ciB62Ob/U/s2cDObUsvXXRRYUnBid9mRxwO9DN+FGvYTqhtrzciKxs81PphxT0 /AqCuLN8TQP8GTmU6rX1/wa/MkfUSX7rgvao9dfj0D1nYYHhYk9w/uoZYEONHE5w4rvk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174609: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-xsm:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=ece5f8374d0416a339f0c0a9399faa2c42d4ad6f X-Osstest-Versions-That: qemuu=a11f65ec1b8adcb012b89c92819cbda4dc25aaf1 From: osstest service owner Date: Fri, 04 Nov 2022 07:36:18 +0000 flight 174609 qemu-mainline real [real] flight 174619 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174609/ http://logs.test-lab.xenproject.org/osstest/logs/174619/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-xsm 20 guest-localmigrate/x10 fail pass in 174619-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174582 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174582 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174582 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174582 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174582 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174582 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174582 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174582 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu ece5f8374d0416a339f0c0a9399faa2c42d4ad6f baseline version: qemuu a11f65ec1b8adcb012b89c92819cbda4dc25aaf1 Last test of basis 174582 2022-11-02 09:34:03 Z 1 days Testing same since 174609 2022-11-03 21:37:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Claudio Imbrenda Francis Pravin Antony Michael Raj Greg Kurz Helge Deller Icenowy Zheng Jonathan Derrick Klaus Jensen Laurent Vivier Michael S. Tsirkin Murilo Opsfelder Araujo Paolo Bonzini Peter Xu Qi Hu Richard Henderson Stefan Hajnoczi Xuehai Chen Zeng Guang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git a11f65ec1b..ece5f8374d ece5f8374d0416a339f0c0a9399faa2c42d4ad6f -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Nov 04 07:36:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 07:36:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437346.691664 (Exim 4.92) (envelope-from ) id 1oqrFi-0005J3-Q4; Fri, 04 Nov 2022 07:36:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437346.691664; Fri, 04 Nov 2022 07:36:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrFi-0005Iw-N3; Fri, 04 Nov 2022 07:36:34 +0000 Received: by outflank-mailman (input) for mailman id 437346; Fri, 04 Nov 2022 07:36:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrFh-0005GR-55 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 07:36:33 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70040.outbound.protection.outlook.com [40.107.7.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 66c92875-5c13-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 08:36:32 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7275.eurprd04.prod.outlook.com (2603:10a6:102:8d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 07:36:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 07:36:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66c92875-5c13-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FHuzz8QiJ3++L3n1KHr+kiIszXGORMp4ZZHX8L3DkA/5Qrr6IYl1pv72uD0JcOG/kTGbkivXJpS1uv64s/Fg5i0zTaNYCPUIbBodq98SXrBKAhl+vt1qCXEURLzgfc3Ap2At7vr9+A+lH8I52sufsP1zDZD8Xlr7hQOxp8JOrgVPdwr6i6mFJxqCNSwyQS4usFbVKDkcjQ61ZXvWaPmDSDFMpwFX7fdiDrQmTtoOzjD8TLre1+z5hy5+Kr6CxERJpCKQ3Tp7T9oIqKe4vMDUSghEyex3u8EmuAJ2Pb7gTJ0aoNS7IDY0R3y0U4o+EvewNnd0mB0rYJas8o2KMO8HRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6o5I+unWrKBz23NDGdU2Nfnf2XkDseZ3RkXPVSz1gYk=; b=LuF3uyuBmCXFyUXZLAxHqnDTfy7RAFpAdDSrgJLTaDRS2MkbY6Lo55TThyXxAd60a6a0M7bcKYTqufAGuRMyuEXFkkLXFiI/U1E9j7CY2ULHsul+vfcj7CE0+TtKNModFCWWW2uwUI6X/pB509vRdIHJ5DY/g1VFImoeHsf5T6y8PBeL9yLfjMMQofrVlT/I/jAMqtxbYE3xAZyEka9FnrVbF5YqUXy3bfZyVzoHYEWVR4wLp+n/xbSf9Iwgqcrm5KkjAAfIjgFa6Oa1IuPNlQVHEiTpv68eWfS+Be8u2iR4n39Q0rl1sEUAspnfauFF3b4Gwk6lgJ3sJo7GZZ5GGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6o5I+unWrKBz23NDGdU2Nfnf2XkDseZ3RkXPVSz1gYk=; b=p7Wv5jbTPHK87yyY5g88bk6dITyP6GtJAf0MQqJU/V62ntjFFxqtXMPvbu1oynf9cC65lZ2kIktHy+EqIFPKxVheO5sV4ZhqPaVCA/RGMgDm0Lg22sibAIDrOVEe44YVkgWDybwA5Hfze4nAL4N5LflQfKQbSToFrJrF3S7wTJzCwFi23MDq3UvR0FKx8LObVMp62SqHSga99IlbPLysFrGGYmCm7n8Jo7zXYcUGo+VWQthNSgXZSYTLOjBA4QWIbFtxmFn/lne0P9fl+tjoDmCymGJrDXuhaeEuvM64IolZEATYZkaUKAuNUVGWtRPNWtThk6b9/e+G+1TOqY5D0A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <57892137-b99a-53a6-b306-d697bec15d27@suse.com> Date: Fri, 4 Nov 2022 08:36:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: Revert of the 4.17 hypercall handler changes Re: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang , Juergen Gross , "xen-devel@lists.xenproject.org" References: <20221103163631.13145-1-jgross@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0027.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7275:EE_ X-MS-Office365-Filtering-Correlation-Id: 33ebc0be-e4da-43e5-bf0a-08dabe3749c1 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7iZ6uCG8Dv/07iae5WcPapqcII2NxDxZFzH9DzCwK2WzgVZf/wCATj1glFTV6RyhNZZ3Lo826bBJHJfIvL2Sl1pjQp1Cc/upr3Z+DnGn90/BCcHqNfDC0FXTqp0qYc8pkXImI6vwQ8QJYDvPdMCsZEUf6LBBRGphHXhH3KgQkse26XSYqfKtgoBMWeP2erjjnXVfOqQ/TPUkaXEICchpq1JGfeO2oApRTv3mUL7r4Jo4kEbH/nXLDSSfZ7mwPFZsLF9Bd0EQn78rnfC1dBdChCGpfXjgNIb8Jjxkuxl5kqTzalETCV8wT97IWrT+c99s4Ms1L5JwHKh7YM4LkUEQnzbHG9PLXcIhjrdHq2/JUQ/3R393RTICpWoOvS+GkXYdnzjH6PY91X//BJJGbZBsMrVUDcPBqYild/qOyhrnNr6oKBtZPrrQM6kH7aytCdvxC3htjroAG0DQzAsPnAPACaPPgFRFlVeM+KwaZfcKuCs+qhbweKVr3KDPplHaYFKKpPYkkt+L1SdmmBUMc4sNC+7Mbl8T26glsDcljicp7AzyGDOaypASIZwYtR5Jd7ShqdxdP/RlNeBlMsEGBRF46yb2Gewm1OtOdh5Mmn780qaNM4YoB+HwP1D612lfiOvcOjZfvxs1tTj5eyazFT+Z3k+kQIwUilHAf4s3jMz3pK41eDYMrAiDY0mdqiMkxX5tt+IRUeUcuRirnh3Rkhal//3zQrhe6QQFFPflP5lGDk8WpumMMZmb0IU7ln6YNrpzZJ0eMx/utVHdErcC7iGYxxtoYRArIlXi5JGQpJku6pksH2cN3lZe96iQg8q4i2zhvVGYSErXxerYmkocXtJIbA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(366004)(396003)(136003)(346002)(451199015)(86362001)(31696002)(316002)(6916009)(54906003)(36756003)(2906002)(5660300002)(186003)(38100700002)(2616005)(83380400001)(66574015)(8676002)(6512007)(26005)(66946007)(66556008)(41300700001)(4326008)(66476007)(53546011)(6506007)(8936002)(478600001)(31686004)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHdxK2xwQnJLKzFBZE9ONVEvNHJDMkxyMy9IMHNhSmVqSnhBU1o3b2JsUXR1?= =?utf-8?B?cXN4RmNRb0p4R211QXltYXdXVDFlTGxpRlRORElsdm93aE9UWWdXUFc4WFNM?= =?utf-8?B?S2VEc3A5N3ZGRDFqeVpGaFJEYUlGaERHUmtnRlBzUFV3ejVOOGZTNG5nQnI5?= =?utf-8?B?a3U4dERQaG1PZ0xyNGZYZytwNXhSZjcrWTY3YndhY0M4eGhiS3dnbFh5QnBk?= =?utf-8?B?Kzl0TDhheVZyemhmaFVia29hSmhyZk45QmovV0M5V1ZCT2xKQmVtSEh4aWk1?= =?utf-8?B?ZGp4cUV0VXl4Nm5oZDNIWFFFWmwyc3BSVFRPdjlQSkFZT0ROK3NxcGxzSk9j?= =?utf-8?B?bWFjL09ZN0dLT0NxeFUyNnhkUzN5eExMaTBuRnZET3hUNFNMeTdabmxydmts?= =?utf-8?B?dDBOcUtDelVQR2g1M3RyV1ZXcHQ2S21wL2thejc5cks5K2VIOEUvdkR0dzha?= =?utf-8?B?WkpwcVhyOE9WWTlXMVkvT09MdURlNzlyZXc2d3RUbWF0NU11Si9pOE9qR0g0?= =?utf-8?B?OHpPVGtydHpNY3Z0VERvMklicks0bDNod2t2TjlVQlRUWDU2NGFXTFdkWG5Q?= =?utf-8?B?S1VNcHZodWNuVFFBS1M5aUFxU0dqYTdvcC9PdFJuN2tjQVg0aUNCZi92Y2JL?= =?utf-8?B?YW9YVTdHcThoRHBrNUVFTlUwRnFTbnhyMnBLai9VRnN0TEJnN245NnhXYXBS?= =?utf-8?B?SHF1dDhNUE1aUCtvSXlMNGpoZDZsTnpiOVc1RDErbVhKOGJZQkQwTFNKVE9N?= =?utf-8?B?TW1vcTlPWStvYmFuWUsyVXVsVEVRMEo4RURrcUZJcHkveWQxSVpzWGRvejdy?= =?utf-8?B?eVdHRjFQS3lwVWNiS0JnbXl2TWIxYXJ1cTV3ejg4cStGSWlkM0ZmNlhvai8r?= =?utf-8?B?d01zRVNYUWVoeDk2QmhpSlFNUGdEYXpoR0JnZm9CTWhkVytLK3RZc1d4cGhh?= =?utf-8?B?WGxLNUxBTUl5YlhHNllFcjFNUDgzZ0xVN3RWWlkzdENaSzRKbk1KK240NWVM?= =?utf-8?B?SVB6bFZDNkpOWlB5THljdkxtMUlTK09KcXA0MWc5Vk85TFdoc0xtVnRtV1VO?= =?utf-8?B?RitmT1ZDNmNQS1JOR0dORjM1UGhPNlk5UERUeDhNUnkvUVFqZElTczFNMjhx?= =?utf-8?B?Z2hTUHNOU2JjWkhueXFucXJwNW1LMzVFTTU0Nmw3TU55dFZEYkVudmVaSk9t?= =?utf-8?B?QXMza0FKS1BZSmhVOEo4QzVmUXFHTzlLK0tmdTFLcmZRYXJ3ZUM4eHRBSkJD?= =?utf-8?B?TktLR2NVa3JFY0E3U05KL2ZRSFNQQlRtMWdKKzVXZ0EzWlh0U0dwdU0wcTZl?= =?utf-8?B?NmRCVFlTQ3NNc3RNZ1B6RGoxWU11MVFRWEE3RlBqNThsaVlzalgyTlZnWWw3?= =?utf-8?B?elFiazdNdVpvUmNkb0dLN3F1U3QwWDhFVVdmNytPUUw0NDQzeVlxTnJEc3FV?= =?utf-8?B?UFhOVnI1WW9GdUlkWUI5RzVncm1sUmdCMVJMZ05NbTV6UDdRNk4yYTFwNnk5?= =?utf-8?B?WjgyNTB3ZEpNdmZsTFpQVGZmQlpEaGU1bDJ4cFpNR2dwaTNsdk5BMm5KRFln?= =?utf-8?B?cHVWckR6VWQ5a1Z5Nk1ybU1Tdnp4UmhjWTZHWmprVks1YWlWdHJ2N0FoZEE5?= =?utf-8?B?YU8wSVI5Wmc2Tlp4UEpMamN3NURlUnA1VVhwcmVrZEtRaUVaai9NMnEvTFVI?= =?utf-8?B?REFqQnVkeElkZlk4eE5HRm9oUmVvR3Vva0liODRXcWtQNEdsTkZjLzlFWE0z?= =?utf-8?B?OUtaUDBpTDJObXNUSlRjU0JwUTJ6YVlRV2krQmI1akJuSENya0Jkb3ZUb1Nm?= =?utf-8?B?WVYyM2ZlR3hFU01QTU5sMEc4NXQ5SnRmQjBRaE1QQUIzQ3hlZExGK21FeEtW?= =?utf-8?B?V1F3ZmsrWkhJbDllYW0rWTNvUGxPdm8zVmFiSktuOEpRMGJ2UWI3RHdKelBi?= =?utf-8?B?NTNTZlhXSXJkQ3VyZHVacWRwOEJsc1diTnE0bm9XRzBoWnp3ZFJVMXZZVmFi?= =?utf-8?B?QlYzZE0xaTZwMDFNUVpEMzYxVE1hMVJxV0djUHVRQUZQaktjZElDeTQvOEp1?= =?utf-8?B?UUk4SkRjcVQ3NDZjamtKUkR3Y2tBR3MvMHZ6V1dmZUZqdnRNS3RvalByVW5x?= =?utf-8?Q?3kbrRCZ/x3q9+q2qjBfuyok9e?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33ebc0be-e4da-43e5-bf0a-08dabe3749c1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 07:36:29.7977 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Lxu5/6rb3NZdpQPDLuRi4Bd7W6Uzyuexuq2E7dh/8pv2hn+HKrlCoZSSnmpFvfQIAQ6IXjAXfa3HkLy/3NyzZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7275 On 04.11.2022 06:01, Andrew Cooper wrote: > On 03/11/2022 16:36, Juergen Gross wrote: >> The code generated for the call_handlers_*() macros needs to avoid >> undefined behavior when multiple handlers share the same priority. >> The issue is the hypercall number being unverified fed into the macros >> and then used to set a mask via "mask = 1ULL << ". >> >> Avoid a shift amount of more than 63 by setting mask to zero in case >> the hypercall number is too large. >> >> Fixes: eca1f00d0227 ("xen: generate hypercall interface related code") >> Signed-off-by: Juergen Gross > > This is not a suitable fix.  There being a security issue is just the > tip of the iceberg.  I'm going to commit that change nevertheless. _If_ we decide to revert, reverting this change as well is going to be easy enough. Apart of this I can only fully support Jürgen's earlier reply, adding that iirc it was in part you supporting and/or motivating the change originally. It is perfectly fine for you to have changed your mind, but it doesn't help at all if you indicate you did but don't say why. Even for the change done here you left everyone guessing where the problem would be that you did hint at in, afaict, merely a private discussion with George originally. I'm glad it was enough of a hint for Jürgen to spot the issue. But then ... > The changes broke the kexec_op() ABI and this is a blocking regression > vs 4.16. ... you repeat the same pattern here. > There was one redeeming property of the series, and yet there was no > discussion anywhere about function pointer casts. But given that the > premise was disputed to begin with, and the performance testing that > stood an outside chance of countering the dispute was ignored, and > /then/ that my objections were disregarded and the series committed > without calling a vote, I have to say that I'm very displeased with how > this went. For there to be a need to vote, there needs to be an active discussion, laying out all the issues, such that everyone who would eventually have to vote can actually form an opinion. We were quite far from that point. In fact, seeing the repeating pattern of you voicing objections without then following up, in the "Progressing of pending patch series" design session in September in Cambridge I did suggest that not followed-up on objections should expire after a reasonable amount of time. Just giving a vague "no" (not always quite as brief, but we had extreme cases) should not be sufficient to block a patch or series indefinitely. This is still only a suggestion of mine, not the least because it's not really clear to me how to progress this into something more formal, but there were no objections to such a model there nor in reply to the notes that were sent afterwards. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 04 07:45:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 07:45:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437357.691675 (Exim 4.92) (envelope-from ) id 1oqrOB-0007eJ-Oq; Fri, 04 Nov 2022 07:45:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437357.691675; Fri, 04 Nov 2022 07:45:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrOB-0007eC-M8; Fri, 04 Nov 2022 07:45:19 +0000 Received: by outflank-mailman (input) for mailman id 437357; Fri, 04 Nov 2022 07:45:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrOA-0007e6-4q for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 07:45:18 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2075.outbound.protection.outlook.com [40.107.20.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9fa3513d-5c14-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 08:45:17 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9485.eurprd04.prod.outlook.com (2603:10a6:102:27d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 4 Nov 2022 07:45:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 07:45:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fa3513d-5c14-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BwsEoRcxPDPIoP4v68lEtcYTRPsKVhSz8H6VPJHTxfojBNcYPTkGifh/Ldu/wCFMWYeQdVtdgLJUxt8c4xMHn5gKfMvIySs+i8PALr+5821DiQLn0qpEH5jcvvYwGJkCyMfystmCDppGdWIejAtITr5KpLdXeyTJDTqhjDFh2AiZsPO53DedgTJFQ9Mbs8Nit/wqv+moiNDH0IaQvTmo9MRALpfOw+gj3La4W1jkebtzQ43a66j2vk60+x0V13bFzib4Eoa0XPRI73vGk62Ls7CDyTcBbU7E0DpU2ufGBcApjfm7Vn5y4TmswZPcgOfOHif4g0eRafGoy5HATQDjEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KFe8VA6JYs8yWUXGFwAQdEhirvPHmkE2JympZj9mJb0=; b=lH11faPCjbKupEoPNu9LQIjAdWe3E5qfGaUOGIazacIiz+ffwwI+3pVQkNiBmbl+WtskGHyom6HybXKW/czuOqBS5Fhf8UH02MUKbUCJTk1PDQFIuCTO7Bs4L4ZL4W39cJx4j2o0aSGLlSfuyT7YRyBX53HBVqvDPoIcxSiCTXXBokuEziQHLtg9xp4cdEA3aTpPX0N68WWziw51pN8KL2I39krBF/W2sDWY9OO3c2W9p9t0ZWVz3lUyVK+EyPf2ynxfQEbswxArFJQHjJEBy9EUrH2OsAf0AOyAUM3GpgU+ji1nY/q8+R/KMmAgXUVf0NWTcSgA37N0A/pW74qt4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KFe8VA6JYs8yWUXGFwAQdEhirvPHmkE2JympZj9mJb0=; b=zI9VGe1Hxk6IfcaebEeHJV3r6Tr2fGNNEZa4WQYbR7kZzZia++zmPzvOup70ZgcaMHbmPy3EDPSUMLAQ3J+A2eXLcmGmsXrF4xqAkCHr9+8FCLiC/0sM5QMpTHuaeo7FQomSRM3pJ2/9+KZPe3dHzoJNrDi+wdTKIslRNdHmpPL2C6F9ND/4sfBRQYPyK2yYLg5tIWPC6leG2xlVnTz+ZHuPvFVc8K6W9qJtq46oBda17oHl4st2CsyJnP1cIbxsejSQSQBoJ3ML6zZ4Ain8lw8Jq3hcxeASqXMGj5clH4qvLYiRrQANYnNwuCyhhdNjcQ/7yaq+vaN2av++s7cnQA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <76e4e06e-7c48-57c5-f73b-5f59167a0e4d@suse.com> Date: Fri, 4 Nov 2022 08:45:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: Need updates on some release blockers Content-Language: en-US To: Henry Wang Cc: Juergen Gross , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Julien Grall , "sstabellini@kernel.org" , "xen-devel@lists.xenproject.org" , Andrew Cooper References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0087.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9485:EE_ X-MS-Office365-Filtering-Correlation-Id: 71172e87-b8e7-426a-e83d-08dabe3882be X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fqZwNPLWiJV4kBLHH8HFTiF36fQc8e9X73RyngIT+VEX3PuKai6ttxjVaj6k5IRYGC1CWXjrgM27i0b4gdQtsByPhughvSsSYkoNa1HhY4iEGYvFVrX6GD7j+5UA+EcKoEiEFhJaJYhxIe3g7bCeN2of+1VbYEI0c38lGvLs6Pv2fL0v76u3ehrE7N0pUdDiWe1iHwlkQ4gA4zIDKzyW2mNJFK9LtQ6DXWHZ4715D/Fhn+ej9U74Y3HqtnaQnMw3YyMz3nnrurEOTS393SNo+o12lM7s9ZH+jw98ozmlb0SNa8oukQAZbXaUpoe+d0lLjXLGRsu+hJq/v5fFDuOVs5yfV0Uv2BvsBlY2T49ynfatRB+0FMWmN4x5bi3AjYg2Eyd99ngAUzESpWEC1oZDrylBnz4Y8vcLaD0dVfOreoToVUOke2QfuQjQFPFuEi8FycShbHo/TmHX5lU1jxADQ49A4Ahers3pSU0O4H8lTu2/2Y0nP43NGLma/Isnl72U8ZUbFk1aD7gb9fBxauD0qgzVqK64xZ2GbSSCq5H/2X3P8Obp7MUXl94HmrkmwXqvggKdabn8uZr03jq4v1WJclm1fbm1INTbOZUh9QzolaB2A6GRqMjEScNpmM2lBcSXHn/cgHTIQCaLGpqfwbDexKtQqATDMEMJrBVNvPlq4ujlY1keW2WvibmX3p8Yuy0zH26H9qg1x0nAUCYkE1peUsH9iSumvLh2FL52j2KY2zyu8yZjG/71ejUEoHoqFAHKIuC50FlR+v2kqU9ANPSuJln0ZUB2HVtdv6zUySwTN7c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(346002)(376002)(366004)(396003)(451199015)(38100700002)(478600001)(2906002)(8936002)(6486002)(41300700001)(31696002)(86362001)(6506007)(53546011)(6512007)(26005)(2616005)(5660300002)(4744005)(54906003)(6916009)(316002)(8676002)(186003)(66556008)(66476007)(36756003)(66946007)(4326008)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDRQUUl0Wk5sNUZJVUVXU29JRURuYU5hamhkbFdoS1JTQ2M3UUNWQWhPaGZF?= =?utf-8?B?ZUFGM2VqVDMxQnpCRFV2ckUrWEd4R1NuRy9VUDRQWmdTUHlOTlZ6dFlpWmtQ?= =?utf-8?B?Q2NyRWpmM1Q0OXppUzRBcVZqbTlTbnhTQTNaRmdNRm5sQTNwYXBVRHcxSDRO?= =?utf-8?B?UWlab0JKTWhtOE9LNXhjNTduT3FRUVYyRlMyY0ViRFVRdGp1OFI2M1pFcFBU?= =?utf-8?B?ZkpObDd3QnFiQUtpSEVrNkpVb255bUw4bUp3dWNkQTUrTVVQS2dFdGNUa29N?= =?utf-8?B?NUh6dHgzWXVHckFMaUREMXJNNXFkdlR5VUtSQi9BMVh2MHJ5YVFRWVgrRXEw?= =?utf-8?B?eFk0dVdyVkpWZGVsVlN4OG5rUzNpNUF4QnNxcW5oZmNvdTZ0L1hyOFlOOFd5?= =?utf-8?B?Z3hmQ0VoQUYxRWdHQXFySFZGNzYrTnpDblA5YlpJTGlWMXlrOHBVQmtNVGdq?= =?utf-8?B?T2ZsSncvRUNGeUNiWTZPdXM5RStnb1AzeEtLZTAyaEVMTTFFODFVc0hOaDE3?= =?utf-8?B?UVdMMUxteGkzN1QzYXpBdENMbEI3NXJidk5Fanh5ZWRENkpQSk10cmVwSFN6?= =?utf-8?B?b1JEMFBLTHZEWXFETTZSTG8xbktzRmtIUm9zK1Fyb1NSSUZob2k0bFFJVlJK?= =?utf-8?B?RXE1d3JjK1lXWjJtL05sRGZ4RU53MUJSL2NRUXhIZjNuYjB1RE1uak50QTVs?= =?utf-8?B?QVFiWEZSK3ZFQlhiNW5aVkRWLzZCS0d2M3phN2UwNEVrSktoOG9JanAvMjZx?= =?utf-8?B?Y0tXaXRNRVUvSDlLNS9sZmFKZTB3b29oSk0rOXhzWjlZKzMrU3ozYUpkL0FS?= =?utf-8?B?ZllENlltSmJ5bGs1ellKdzVnN21GRG81VGhvcW1MQWFZNDhaUjM2SjdoY2FB?= =?utf-8?B?SnBKdDcraUNGWUgwbHkvUjJVN3FnbDBZczAwQS9uZ3IzV0RCYWMrREZLMVdS?= =?utf-8?B?N3VqQmo2OEt5Z0FWbE5tSURVMEROQ01PdDJOa0pyM2ZLcTJBWHRGbEFEM3hk?= =?utf-8?B?MGNCZTFIUnc0QWJOdDUxcjJmNWlUbXNVQ3hXRGw1SUw1RER0S2RCclN6RTVY?= =?utf-8?B?TWZPNkhUZnhpanlxS25peTIrMGhkeExrRVFrNkFvbUh3c1lzazRLOHJ3Wkw4?= =?utf-8?B?dXFKeTRaUytqT1ZLMkp2K01ieC9VY05IQm93REk2RG1YeGdPZUhRVTlNUDVv?= =?utf-8?B?WFZrWmJUeFc5c2QxYXl3QkFja0pOM1VJN0R3VHlROUU3ME5mWFlPVHBJVy9y?= =?utf-8?B?ajJQMU5aT3h2ZkM4T0VwbklaRHZRZUY2Mmo4WVdrS2NVQStBckgrNjJOa1dT?= =?utf-8?B?a2QyMGJYbUdRMW91WnBsc3F3L24wbVh3QUlmSWJlbEJuVEFIZE9MbTJkcEJQ?= =?utf-8?B?OERZOGo1MFpIaDlkRDlabFpjWHpzcjFDV0thSVZqUW1KUGx3dmRxNlBrRm5u?= =?utf-8?B?VFRIVE9RQmZnVlBaUm1vbjArT0UvWks2aUl0dkZYMmtMbllPWXZodDdScm1P?= =?utf-8?B?VVZCczZDalNYaXgzNFlneDZHZ0pidHNjWE1qOVptUllQaUFKRkc2U01QYmJ2?= =?utf-8?B?QXdlb3MxeXBBV3ZwRnZ4aTlYZVprRERWbTUvWW1xMWNrNGJrUFFHejRGb1Ex?= =?utf-8?B?bU0rekdObkZxT1RBWUVEdVhpQWM3VWpLRmJMbzQ2eUFSMUlqb1NDdk1iQmJ2?= =?utf-8?B?RHkvbFpNSldCc0RYc0ZpK2prRHdURUg2czNEaThlL0szaGQ1ZXhTc05kL1pw?= =?utf-8?B?QThDZnRONkxsNkxDV1dwTEc3RUhZM2hrZURHQ3hDTHZlRFNzc0dwWmx5aFNl?= =?utf-8?B?TThoWU1WeksrN2ZEWlM4TnFTY3Q0YUpJS1dMT3BWRTR3WkVRVTA3VzFGMUZT?= =?utf-8?B?bzJCVUc0WUpzRnlWTWZ3TWtlTUcrSUpBTytlYnNzeTg4THBhMHQvalI2cmxT?= =?utf-8?B?cW9kdEJyVEhZWVNjNzROL05ZVHQwcm8rOGFNdzhZMTVtOWJrSFp0dVgzTmY0?= =?utf-8?B?UjFPSUJqUHpEa2hiaUx0S3JubzhYRktjU2lSVFQva3B4cDBzc1AyMHZyRlRD?= =?utf-8?B?MTR2cmgwMUU2MWZndjVuSkJXN1p6ek1lSDgyUVRhSlcyM2d6SWlJWk1uSDdi?= =?utf-8?Q?M1HuE25kfaU0At14DFIVoAbZJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71172e87-b8e7-426a-e83d-08dabe3882be X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 07:45:14.8435 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e4pkCTV4hlTcxDP595ic38rNVW4rC1MLR9gyoLBfMpqxpUxRgiLXz/Umm+hlADqiASqV3f+yJ79Mzx3YC9BhBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9485 On 04.11.2022 04:06, Henry Wang wrote: > 4. Patch: x86 :Enable interrupts around dump_execstate() [5] > - I think your opinion is needed so that the discussion can continue whether this > patch can process or the previous patch needs to be reverted. On the last x86 maintainer meeting the decision was taken to revert. All that needs to happen is for a revert patch to be submitted by one of Andrew or Roger, and it to then be acked by the other of the two. I did clearly indicate that I do not want to put my name under a functionally regressing revert, even if the alternative of addressing the recognized issue with the present approach isn't pretty. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 04 07:48:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 07:48:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437361.691686 (Exim 4.92) (envelope-from ) id 1oqrRc-0008Fp-8X; Fri, 04 Nov 2022 07:48:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437361.691686; Fri, 04 Nov 2022 07:48:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrRc-0008Fi-5q; Fri, 04 Nov 2022 07:48:52 +0000 Received: by outflank-mailman (input) for mailman id 437361; Fri, 04 Nov 2022 07:48:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrRa-0008Fa-Ut for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 07:48:50 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2084.outbound.protection.outlook.com [40.107.20.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e6e27f7-5c15-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 08:48:49 +0100 (CET) Received: from PAXPR04MB8366.eurprd04.prod.outlook.com (2603:10a6:102:1be::12) by DBAPR04MB7224.eurprd04.prod.outlook.com (2603:10a6:10:1a8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Fri, 4 Nov 2022 07:48:47 +0000 Received: from PAXPR04MB8366.eurprd04.prod.outlook.com ([fe80::64e2:acbd:4d56:fcca]) by PAXPR04MB8366.eurprd04.prod.outlook.com ([fe80::64e2:acbd:4d56:fcca%5]) with mapi id 15.20.5769.026; Fri, 4 Nov 2022 07:48:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e6e27f7-5c15-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kYdtXvOmN82JpE381wCcSzuwRcPW88lHeY11I8a2Wg/Nv/UGoSQvPJu1RVdE1kL8BTFpmG3iu/zqZPyjL5k4UJ/kfaXuEVMeaBMO7JN3Gq+gHnxadx3uf2PeZseRlTeguSzLS3SOn1HwRMHvd55JtXfOEd7ckj2+cQ9zs9QN5SO5BrZoyEyfhS4rKNd2hliegNfrGPykiH9GY0cEcelMRqjWGkNu5/dtYH7lWfhpqa782+jooNNskB0TtUsn7hHFegBQMRitiW/IO8nTYHoohlQyDEfcuaT2thASbuie03AIENhC3MSuwdujMojr8cPHBr/VWG4d/3+3xEpwZcQ/Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9k9eFnbUR5Yd7ylvPhnSC2nYUV7wddRB8h4C+qjaxqE=; b=KyqnFn2+giKtKgP8yzKsqraOry1lbgPO7RXxx1y66afDqE9/HrzTcqYubDLRPoEHlusE1xnlvQ7rZqGfbePDrnj3ZsItxnuasCDkO0SOG7vgHE/ajsP84oHndP5wOlfObbcajIIrqJJZU/sj+rYyx+PYG7jVtp4OGSAD4mi5/69sUGn56Z8v/JvE5cHnVzy2BSMulHIbxNXBDgRi6dp7rMqiY7RCOOMipQtioe4ncbcX6RSj3S8t11+uoiOZ0Du7k8QTENZSuXo7sAaWLL23bN5Vz6QIoq9LRkbS2lsKyOmKiai7hF3mgRhrug1iVToJqQrEybTGwbJEOaRjtpShVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9k9eFnbUR5Yd7ylvPhnSC2nYUV7wddRB8h4C+qjaxqE=; b=BK3WKLvtTZajsUUfwKCARnALqDAncVNkJkpEuJgaFS6ynMGTZt3MntHZEyj7ok/xlBVNSETmMFubi/6vv/g/qddy6T+3NVq4dJvn0+QQoA1t2IgLu1zvn7KXd6GLjjvg5A0VWMPkLG7sx6d33dO4OrU9kCXR/U0HUY8pcn1uFoTHzwch33H4JIeUg5zTdKzLnLuHn9otKafcfbZD95CtdT/W4e3amfwuodoDgJgqwPl3F260tgMcy4mPILG8kjfoka28akRf+vfDKQSLog9vZSKspipBxZBvPs1DJDRMyrcLCs+AqoFlL5bgNJXA8buGVIoEuRpW0S19Oj/MNXSA+g== From: Dario Faggioli To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: "Henry.Wang@arm.com" , "marmarek@invisiblethingslab.com" , "george.dunlap@citrix.com" , "mengxu@cis.upenn.edu" Subject: Re: [PATCH-for-4.17 v3] xen/sched: migrate timers to correct cpus after suspend Thread-Topic: [PATCH-for-4.17 v3] xen/sched: migrate timers to correct cpus after suspend Thread-Index: AQHY7svfW5RCRD6BzEauaEQnxR7xn64uZiOA Date: Fri, 4 Nov 2022 07:48:47 +0000 Message-ID: <5321a4ce8c3b450c89938aae90d57d191b3791fa.camel@suse.com> References: <20221102150035.4885-1-jgross@suse.com> In-Reply-To: <20221102150035.4885-1-jgross@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: user-agent: Evolution 3.46.0 (by Flathub.org)) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAXPR04MB8366:EE_|DBAPR04MB7224:EE_ x-ms-office365-filtering-correlation-id: ee654846-48c2-4176-7dfe-08dabe390156 x-ld-processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tHEoX/yBSw0Z1/6poRaeDUnzl80yZ7sgKelxjEJLiO6l4NuWRQbMUZy08EaoMh6zBJZUaMLGfj1tdWGXttQnLzhoBSkniD8KRJRLtJxvJMjVPXp96LGj+eaCVxEowbIUPiHU+MNYR8lDd6OGpCaa08UICBhNc5IdqDpDfc9lOFHmUsjLcOE/h3nXEIQRuga6S5HtNcAi5FqILItCEW/lontlhTEC+9y0eAkUep20v9+Nse+hJ9yCRxiJAW9omaFWIE5tJTWAQjDHLNsUMLvQ4TJEpkHQB4dC0nT1PqU/VYbruSxcJHZ9x83u1I04ErVwOFCtiTEHv0fkFkhHmVnnkS1NANvfsmrVXqRLxF2O+vCdZEduxZA/RspfCDzwcYv0xbM9ExKjJpETaq+GbNKcgmNpaf3/csJZEmzoKdWWyuTTYCPxpPTL1RwQU2izzwOT0lbkN4TZ4nQMmmajjDcYftqkAUG6JfnoGqpMKVq07MoCKWj7N/jo0PkMj3WQLCQDHIUKFVzOiGQeqhxOYnma/sVc2pl2mFDxQJK2Ro5uw+ZP6j/RO0kb7mqe04WgH6MN2JZ8l8tZ+Co4dmY6S2mwkRTLLuYG9oE8dhZHUlwUZTXo9Ke2c1ZEYINd23z4mJSqsiNKKus2Wz1jdAa4U0BW0RPPTQTI3di+gygl+ZZ8zuvScu/N2pt2fp1osktbcFSbyeE2kU2IMs/JCn3iO67Nf/FMAikOwi6iUs2xey8XEydJkUzWP5MVrjx0Y/2oWn/c8yARp9NHEkam97YehNeOTZ+KXtGzsWgdEB8iG8omAVMnaO+Uk7W1dR5PmBl7s4gf66f5c3tKwjJknF5seIHvlg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8366.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(346002)(366004)(136003)(376002)(451199015)(36756003)(478600001)(54906003)(6486002)(966005)(316002)(38070700005)(2906002)(83380400001)(91956017)(66556008)(41300700001)(8936002)(66574015)(64756008)(15650500001)(66946007)(76116006)(66476007)(8676002)(4326008)(110136005)(66446008)(6512007)(71200400001)(26005)(186003)(38100700002)(2616005)(122000001)(6506007)(99936003)(86362001)(5660300002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NWd6MUFDQUZ2S2JZNW9PemFuMWhmRUdWNEFlSjRCQkQ0RFQwSFRadVFtZHRj?= =?utf-8?B?ODMvbC9Tbkw3Rk1CcVpvZGRDV3Fja2x5WlpYbCtOdjJHTFJOZHJKdmxaNjBO?= =?utf-8?B?SUEzZ2t4MUgybldUdEFnSG11eXBYdmVwTTJGdWJRZlRuWExMTGxlRCtGYWgv?= =?utf-8?B?MWNNUFYxRS9vVUJxVmlzSUx6MWhaWHpRNVRkYU1YUFhyRFBxUlhCOGZCOWtV?= =?utf-8?B?RWZjZmNORXNLT0tZVG9yNldUSEw2cVYrMXhISXRZamc1R0hHMjNCWkV3OVFq?= =?utf-8?B?ZmxrVGwralpSZ3RDUG90RklyT0d6RjhyWVZNN0NCUU5aL0QxMXJ6ZEp0REU2?= =?utf-8?B?M1c1NzBzRE13ODVlbmhyNFZKdE5HeHBzZ0RycXdsWnR2ZVdabWZOSWdTUC9E?= =?utf-8?B?Y3ljVG5kbGJIYWF3UU5BMUZyb3g3OG96dGR2TnFicmhsZHhhWHFwK2JaOHVt?= =?utf-8?B?cGFEUzNKSktuOFEwR3FYQmE1REQvUDArNWJaUWV4UUpJREFJSUU1V2lOWktO?= =?utf-8?B?V0d5QVZCaVl5Z1RPK1FmZHZSSWpRLzRWbk1YcnlselBKWlJoalpIZXdibGl5?= =?utf-8?B?VDZ5aXl1cHlaa1NyYTQ4U3MrZjRaNGFoWCt1ZVFkcUljbHFaTmhkWWJKbWlB?= =?utf-8?B?YjBKNlVBNnpNaGVFR1lUZzB5VXN0anUvN1V2cGp2dU5vKy81UFJIcE1vNmpV?= =?utf-8?B?R202b3k2czZlVWtmcHcrb0FxZGxhOUhQeWd3alAyd3NnMzNkRmc3TS8wYjdj?= =?utf-8?B?R0JxTjV2N3Bmd3lZSnRZdXhRb2NnaGh0cG9QT0RuaTk3TmVZelJmYmttTzlr?= =?utf-8?B?OFFwcklaQlE4OHN0ZU82R3FaMjRkM1lkcFlaeElCb3podXY3eEt6MHpKOThZ?= =?utf-8?B?ZXlmanBnczBPMGdKQVo0RzJ2Y1VBdDRuQ2dUd0xUQ3RwOVY2QUxnZ1dBaFAx?= =?utf-8?B?K05XWmFycGNXRDcya2NML0svNEhkbHRwQmlwc2xyZDdmc2xjVU1NN0NOOFh4?= =?utf-8?B?M3dFOTl1cU43bFNLaFJWYkFsRFNQeS9OeFFjUXNJYVMvWlMzQ1pZT29GQXI5?= =?utf-8?B?eVJ3eWdlU2l3UEgzOGdraTdRL1d1UkxseEwrWTRmZExzNWhiNEtVN0w5STZs?= =?utf-8?B?RTQ5b0kwSU0raHhTa1RoamF3VDFuUkJGL2VGWnNPQkJncmYyVU9nb1lMZWxM?= =?utf-8?B?dlRlRjNBY3FoSG1WWU1xZEdwU0M4QlpVbXNKVDdZTUNsWWFSdkdKNDA2NnlU?= =?utf-8?B?OXZ5cTFRbHAxakN3ZDRDRURueFEza1pwamVDMWozWUZjQWl4b0JmQVFwMnda?= =?utf-8?B?MXBaRHFRbHFNaXNLSU93d0tmbDJsbjM4ZlI3Z0E2NTNOMndZVmdPZDdTejVp?= =?utf-8?B?TkhZUVRkOWd0MExQU1NSU2JVck81bUMxT3lkblJuUWx6cmVaV3FlL2x1eGFE?= =?utf-8?B?REFMN2NNNGhrcUJyWTU2ZHpmaFBMRmtWRnpoRW9CUElITk04S2o1Mm1MZllv?= =?utf-8?B?a1VrQnovb1Bid3E2Q0RsTzgvU3YvKzh6bHRnbU5yV3BsVlA4Rm5qTlJlUkZn?= =?utf-8?B?Vnc4NEVjYmpSbCsrY2xnckFkNkp5ajE2T0dtTFFVZEJkTHhyT0tVWm5tb1ZD?= =?utf-8?B?ZkxxVWcxUEpmVzl6N2VCbHB3QVQweUh0SzhiOHd5em9LQ1pXTHZnMTFqcE02?= =?utf-8?B?UmpMTk5hdlpveloxeklnTzhxN1o0ZVpnZ1gvVGI4YkdwRk5PRW5KNzYxMzhi?= =?utf-8?B?RGc3SElzRzlDTzYzZzRETWg4RU1zTXlCVTJobVI5M1NFSVl0cjF5OEdCcm5M?= =?utf-8?B?OHU0NmRuVlQ1SXNDa21ST3hTVFJHYWN2U3U0SjRoMmFnOW1WLzIrQjBjNFVr?= =?utf-8?B?MDNqRHMxOWNIT1Vwam05RXRSeU4vYWNxcyt3VkRkWFp4TlVpbFErZjN2OGJJ?= =?utf-8?B?TGs4UUpUVURnWTQvNWVGWHdoaUhDSWVmaDYySWxtL3IrbkFKNVY2WldsZnRS?= =?utf-8?B?RlVPOGlUZ1N1ektDeHRPUDFtYmVUT0dlWU9oeVN2bUIrMXNJbi9VNzlWRFhq?= =?utf-8?B?aEVKNUtQMzExaWh6ekdqVktpWnRETkVXWXRhM3V3NTIwKzByQnZqdGd2ckky?= =?utf-8?Q?rAJcoDpNikI853NfhkhcfjSWC?= Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-4unEY+IrWDERYSHcahAj" MIME-Version: 1.0 X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8366.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee654846-48c2-4176-7dfe-08dabe390156 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2022 07:48:47.1049 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0lZKhn3QsSFc09+s1u15cRamT2LowEtdK4+ZIjP3VVXAExNsyWlFGZQOmLTWPQe2W7mtVd1wRFq2z0GUMEqqag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7224 --=-4unEY+IrWDERYSHcahAj Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2022-11-02 at 16:00 +0100, Juergen Gross wrote: > Today all timers are migrated to cpu 0 when the system is being > suspended. They are not migrated back after resuming the system > again. >=20 > This results (at least) to visible problems with the credit > scheduler, > as the timer isn't handled on the cpu it was expected to occur, which > will result in an ASSERT() triggering. Other more subtle problems, > like > uninterrupted elongated time slices, are probable. The least effect > will be worse performance on cpu 0 resulting from most scheduling > related timer interrupts happening there after suspend/resume. >=20 > Add migrating the scheduling related timers of a specific cpu from > cpu > 0 back to its original cpu when that cpu has gone up when resuming > the > system. >=20 > Fixes: 0763cd268789 ("xen/sched: don't disable scheduler on cpus > during suspend") > Signed-off-by: Juergen Gross > Tested-by: Marek Marczykowski-G=C3=B3recki > > Acked-by: Dario Faggioli Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-4unEY+IrWDERYSHcahAj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmNkw94ACgkQFkJ4iaW4 c+74xA//RTRmv3e9gmOmMhCn3u9r/N0UfstySd8xkUpn3ECgUYtOH/PPjXCIy81e fGX9Bn1NcIBifIwRDGHu/4JH4N0K+XGz5tPEH+AOenDlbmZlpKt8BSTaHUG525n4 K6HQ1r9W5uilnoXTzO5ks9obS8iGp1SE6+njNCDRjiWuKoNiB2P/cCJF08s69fmx uPivcX8PENxDX7F/Pfsrww8EGqinplWyoGrNnUhhTVGyTeZOdE2o+nuzfDM59QZh QNIQb7sUn40FupEh9YCnZeemPZW7VRkQVHOcUsP4Vf2YJcoIRkxzYM7aj3DiP3Aj 8yhhiD6dRGA1XrqJGQcX23aDHsgtipWPgzslscWbPHLTgmbICuaBj7H38NUNX2ta 2/8EtNwdnTJTaHFzefFcqONgExjy1YXo4wNTmLYOvG2d5nzakpKoZu/MGT+8TSlg jCkaA/rOtQ+LklKPnXVaYeLkQH7nYXRc+yI0OWw1Izu4sN5edUT3Jx+TeWeSvnJE 1YiwD69SmeyKM9Uft4gDsYv+MxdIvd+P3D7Q2v0IM4QqYr4ivxOR5rmL+hFd/ycO Xn/iCaCRbUfJqMyjuXCH+K+f6A0LC6aIKuG9uk31sOur0KE8gXjDhdAG9vHzqBfU nqm8oqR2uJyhuT7ktINRTl+iV/c4N99izjiRdBf+ci+sIqf3IqQ= =1Y+i -----END PGP SIGNATURE----- --=-4unEY+IrWDERYSHcahAj-- From xen-devel-bounces@lists.xenproject.org Fri Nov 04 07:50:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 07:50:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437366.691698 (Exim 4.92) (envelope-from ) id 1oqrTA-0001AL-M4; Fri, 04 Nov 2022 07:50:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437366.691698; Fri, 04 Nov 2022 07:50:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrTA-0001AE-Hm; Fri, 04 Nov 2022 07:50:28 +0000 Received: by outflank-mailman (input) for mailman id 437366; Fri, 04 Nov 2022 07:50:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrT9-0001A8-Lo for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 07:50:27 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70081.outbound.protection.outlook.com [40.107.7.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57cc5878-5c15-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 08:50:25 +0100 (CET) Received: from DB8P191CA0009.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::19) by GV1PR08MB7705.eurprd08.prod.outlook.com (2603:10a6:150:50::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Fri, 4 Nov 2022 07:50:23 +0000 Received: from DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::49) by DB8P191CA0009.outlook.office365.com (2603:10a6:10:130::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 07:50:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT019.mail.protection.outlook.com (100.127.142.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 07:50:22 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Fri, 04 Nov 2022 07:50:22 +0000 Received: from d9fefd09a3a9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 092FC9F6-EDFA-4EDC-A078-C3B88C7FC8DA.1; Fri, 04 Nov 2022 07:50:17 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d9fefd09a3a9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 07:50:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM9PR08MB6195.eurprd08.prod.outlook.com (2603:10a6:20b:284::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Fri, 4 Nov 2022 07:50:14 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5813.008; Fri, 4 Nov 2022 07:50:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57cc5878-5c15-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Zgk2x3/Ube8QIbjF8Xo4QnWHNL1W5gCs5qUyjVTevjdW8TVEKSehzLG/yuIAuFQgcHg92vONS1vXfKcvF0vFNNd8pFzwL240/VMwvZLQqLIkVKd7oOZn2BJGK4EOKembxSeDuncXMxpAQGzEyrZRWG0oItYgWC4wQ7E0PXG0LaAzlRs8L2Nw9cCHEWbVkhCRK+gSgvB+Ue5EdU4fdMJheG4ydRXf4elJDiTEso//jZbfpEky3McFMlcMW70d0t72AEALe32lZ7l1H7hpnf2PIQ1sgMDZ2SCBpCthTCabYFIl6IJC+ZJuL3W3h4LlcBSj7fXywtJMZgRwbzxC7hmsRg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7tr28D0lVckUdVYnULxk2x8HjYGl7wCoR+ujYrNYY4U=; b=jKfBMgMdFzFPrpQHlxl4nuB05xvLQrB42V1q+Z8W+RN2SGdgS0TX0pM+Mge8sO61RsS5kpXpqpgolKV5lY/VcJn2Gh+7j0k56ml5wVymQX3S5LznlrF7NsHwbcL6ew7mgVQOuq93Gx3yS9YlKv8c4QRrwBip/1d7ifrndgfldi/j05E2pRxh71S4YMSO92JXkgoA34k4zWJGRaJZL+OgwObvkaouRszj2z+GFcMf7+ygRXfT0fcE6ICbuTblM/ua0YjrquSx2aRK6kLClrSXHYx4Y1kLoscIWad6JI/zvZEf6MqHgVB1D16jXkOmZfxf0Cv6f/Njy4e+vCAFBo2ihw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7tr28D0lVckUdVYnULxk2x8HjYGl7wCoR+ujYrNYY4U=; b=mBuTn4cwBByz9WNk3Y2NenI/iGaiSvEGOK/D9liZ5iJlp1a0Spn9xoG7lb5Ye4tL1EUHdIiF2geesfLEDCSMWzQ81Jb+1pb6NufJkY38M1L9gXvzGdwIRakjYXLe/g5xomxh4OTCAJwj1WPGjTZhGI2Em8QRUwc02V0LywDXn9E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dr1ioL8xCjjdjAvZDpOm5lKUiK+E8scwAd+4EiB2rVYFSGhSYnccZpsYtG3CCh6+ZPlR/GETWxm6r6VgacjUsFcvgAdK8GpR5u1KsQTywv3DtOnj9IzXGrgiw4Bzmqs4gX72a3iM59BrJ/pPVRlV87s5lQgynzniDDiajvPiOLEUZGLUNSFFMzegQTpaTPhhgnlDNfw1MnGA53hKsATPOx7tD2omuo6krF2spn2KEAGp971deAha8ZRc+aSPkzRYnyId7aO/TxicnCPnfEGoHNIxbfV2DvGyDMMXPmblxCh2qRBrwHJXi/GEScbtm6k/xkqzq+9QuFSfRYM3maJCUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7tr28D0lVckUdVYnULxk2x8HjYGl7wCoR+ujYrNYY4U=; b=dfY9kT0rPLltG1TRE9ARjzRCdIdS6oJU9dwIxtQtbCyhHDCpeJ2kihhib7K4tInxytccoH5+eU6Tmli6AILlddg36FNmgqLFxaKteuD+gMc1RT308OBttg68pxLbuWXYJWia/bM/CoS/jJbgtbfFRFBp4zs6rlr6ZIXG+NfjyDo9mNfl0nTyioPNX2vB9qmGcMCXO0Tom7hSXz1a9WAHpibTh+pclZuv9DfrL9gUu4oHVeESRVbyasQ4RJfob+rbbslgmB+gLdipL0gTot6pg2KgSt7RP/ehJp+GYlDigI8XQkI13kn7MwA/yeTRCV35rJTy2FEymd+m+J/T4H/Pzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7tr28D0lVckUdVYnULxk2x8HjYGl7wCoR+ujYrNYY4U=; b=mBuTn4cwBByz9WNk3Y2NenI/iGaiSvEGOK/D9liZ5iJlp1a0Spn9xoG7lb5Ye4tL1EUHdIiF2geesfLEDCSMWzQ81Jb+1pb6NufJkY38M1L9gXvzGdwIRakjYXLe/g5xomxh4OTCAJwj1WPGjTZhGI2Em8QRUwc02V0LywDXn9E= From: Henry Wang To: Dario Faggioli , Juergen Gross , "xen-devel@lists.xenproject.org" CC: "marmarek@invisiblethingslab.com" , "george.dunlap@citrix.com" , "mengxu@cis.upenn.edu" Subject: RE: [PATCH-for-4.17 v3] xen/sched: migrate timers to correct cpus after suspend Thread-Topic: [PATCH-for-4.17 v3] xen/sched: migrate timers to correct cpus after suspend Thread-Index: AQHY7svnH5/QyAssMEyjfYS0Wh4IB64uZiWAgAAAQXA= Date: Fri, 4 Nov 2022 07:50:14 +0000 Message-ID: References: <20221102150035.4885-1-jgross@suse.com> <5321a4ce8c3b450c89938aae90d57d191b3791fa.camel@suse.com> In-Reply-To: <5321a4ce8c3b450c89938aae90d57d191b3791fa.camel@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 10039125A4E2924C84DDB7598FA734B2.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM9PR08MB6195:EE_|DBAEUR03FT019:EE_|GV1PR08MB7705:EE_ X-MS-Office365-Filtering-Correlation-Id: 4fcc1447-b987-439d-5208-08dabe393a6f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HXZ2Nti0CAsbnw99oc/7njcXZJAWHgM4Oyq2NpIiG9Ng4tkfMo44DL5xE9nHZiPKjmwg39x8JTi9hEZUgL9a//NPYD0iIikGdrhtTXk8zAyH4sNHXYWE+h9tfrUAHWICRU7OoESCDHWabGdSNKDeog6j/EDB9zEbsPhX9R49pow+eSEbASjNsne8q980MH6ILb9ubOL8ApQQgnYU75+G70uEScJXDNilsX59cq1TvXenIpuR90MtCDz1kq6AGi9OPGsGvuMgcULB9wxvSlVsUWqHufiwWYWQUviAcs9ypzw/AxN3n0AAlVPeBJOJ20NXmeZEcekJlP7ErxLGyvHYMtfBttRtAMelHcd1gBJDvBWD5UWYq/hYbulAccTxESvGOxcNa3R0Co69zyFqUAoJuKr+AmwQmG9juNlbRiJJ6bp2LqzccmhCWwh2JW1jga3kpfZcP7eEg2FptB2GeShqRo9LNjZPKuWfegJ7iCPfXE8XOA95a7LqWgXxD2R/Em5V+nKOsGlm4fumvZhkqaLJd/banjAYo1QPUkaNDfExwsNgssuzWytiaDCD0uqKVfnq/ObAteZX0wPs8PmHftwFCVIU/Bw2+Go+5jey2NGhuQevax36htHARzfhmNo0/y7cA0AaFMU/L1xYZyohYf/CJPe/y1BWSED3mYHlya5qLJWXRx0o4HhyEgVNdtVbgzmeDnC625+aV3Q05KiZiEIOPE7H2IENGBmlecn2I/BsZIs7MJ5NS3+f1jf38PwhOTSZKYpC51gDZ46HOAetzYBGDQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(366004)(396003)(376002)(136003)(451199015)(33656002)(38070700005)(66476007)(66446008)(8936002)(64756008)(55016003)(54906003)(66556008)(71200400001)(4326008)(66946007)(76116006)(316002)(8676002)(478600001)(110136005)(52536014)(83380400001)(41300700001)(5660300002)(15650500001)(186003)(7696005)(9686003)(66574015)(26005)(38100700002)(86362001)(122000001)(6506007)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6195 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1fb0ac59-2a0f-47f0-e2ca-08dabe39358c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zUSwh+enMNFACnObGx57d0S7BP04n1NziITMqpbQ3YsnBoQAi8s1rjmKdrhmiE8v1KuBM4WyHgJgkeCsiltMlzG7jXlqJiIBpIkaV+28ci1DL37sUn/PjRbcGrZMwyM/CNY5vPrt2oa7oVmvEh23ygJlWrIQb44eCkW8ksSmt088x120033wsD7RK8XU1p13DbVmgc0jxg5CWOLbmBxTVyqP7TlgCtTnVni5g1WQ8wbP3vP2BmS0hY84VTmxIf9hJZbmLCWpyijT/WWNJ2DFfu/3zd1aRwYyKMouK5ya+0qE6huZnve7oGfNYF6UuRWWoBRXHdDhSJYlyhzRFdS6tYK0dwTXX6LUDkjqCCFS+S/Jian5Yub8zEFmC4QUGkreg+ohiiALi7M24U/6NhcXcXrPmXOnOPXQHWWjh5/MGAb09yYtV95PFcTbT/sc4aOGWazIKhGIMHbjn3FOI7p0rv77szoYpazykwFQ8cHJnY/900v9+y9uhbyVGLbIe1nVtiwfdCz7SBufdKtoyhv7+tV1cvK42u1QvwOxSxcc2sXks2WIzoYXgG9skX4U+xdsh5AIKJxV1eGQIvYNleZZ8boNgd0fn7TVt/1GO8S+9TURfJZryRnaLlo4e97g2W7yoNdFkTO5rUd4BicDcbl3aLxtsTKWSg0K2nB+yOgpKopikVtNJpdbtMVRZ8egvFVzfK3LULK8io9Cq5SNk+p6Mrkjp+uDrS5nzygelOtuJNAqx9jTk+zS17IcgYROdFwKRu1CEuZtjO5quS65YTrM9Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(136003)(396003)(451199015)(46966006)(40470700004)(36840700001)(6506007)(186003)(336012)(2906002)(15650500001)(40460700003)(110136005)(70586007)(82740400003)(107886003)(70206006)(7696005)(4326008)(55016003)(41300700001)(40480700001)(52536014)(8676002)(33656002)(82310400005)(83380400001)(8936002)(54906003)(47076005)(478600001)(66574015)(316002)(26005)(9686003)(86362001)(356005)(36860700001)(81166007)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 07:50:22.8977 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4fcc1447-b987-439d-5208-08dabe393a6f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7705 SGkgSnVlcmdlbiwNCg0KPiBPbiBXZWQsIDIwMjItMTEtMDIgYXQgMTY6MDAgKzAxMDAsIEp1ZXJn ZW4gR3Jvc3Mgd3JvdGU6DQo+ID4gVG9kYXkgYWxsIHRpbWVycyBhcmUgbWlncmF0ZWQgdG8gY3B1 IDAgd2hlbiB0aGUgc3lzdGVtIGlzIGJlaW5nDQo+ID4gc3VzcGVuZGVkLiBUaGV5IGFyZSBub3Qg bWlncmF0ZWQgYmFjayBhZnRlciByZXN1bWluZyB0aGUgc3lzdGVtDQo+ID4gYWdhaW4uDQo+ID4N Cj4gPiBUaGlzIHJlc3VsdHMgKGF0IGxlYXN0KSB0byB2aXNpYmxlIHByb2JsZW1zIHdpdGggdGhl IGNyZWRpdA0KPiA+IHNjaGVkdWxlciwNCj4gPiBhcyB0aGUgdGltZXIgaXNuJ3QgaGFuZGxlZCBv biB0aGUgY3B1IGl0IHdhcyBleHBlY3RlZCB0byBvY2N1ciwgd2hpY2gNCj4gPiB3aWxsIHJlc3Vs dCBpbiBhbiBBU1NFUlQoKSB0cmlnZ2VyaW5nLiBPdGhlciBtb3JlIHN1YnRsZSBwcm9ibGVtcywN Cj4gPiBsaWtlDQo+ID4gdW5pbnRlcnJ1cHRlZCBlbG9uZ2F0ZWQgdGltZSBzbGljZXMsIGFyZSBw cm9iYWJsZS4gVGhlIGxlYXN0IGVmZmVjdA0KPiA+IHdpbGwgYmUgd29yc2UgcGVyZm9ybWFuY2Ug b24gY3B1IDAgcmVzdWx0aW5nIGZyb20gbW9zdCBzY2hlZHVsaW5nDQo+ID4gcmVsYXRlZCB0aW1l ciBpbnRlcnJ1cHRzIGhhcHBlbmluZyB0aGVyZSBhZnRlciBzdXNwZW5kL3Jlc3VtZS4NCj4gPg0K PiA+IEFkZCBtaWdyYXRpbmcgdGhlIHNjaGVkdWxpbmcgcmVsYXRlZCB0aW1lcnMgb2YgYSBzcGVj aWZpYyBjcHUgZnJvbQ0KPiA+IGNwdQ0KPiA+IDAgYmFjayB0byBpdHMgb3JpZ2luYWwgY3B1IHdo ZW4gdGhhdCBjcHUgaGFzIGdvbmUgdXAgd2hlbiByZXN1bWluZw0KPiA+IHRoZQ0KPiA+IHN5c3Rl bS4NCj4gPg0KPiA+IEZpeGVzOiAwNzYzY2QyNjg3ODkgKCJ4ZW4vc2NoZWQ6IGRvbid0IGRpc2Fi bGUgc2NoZWR1bGVyIG9uIGNwdXMNCj4gPiBkdXJpbmcgc3VzcGVuZCIpDQo+ID4gU2lnbmVkLW9m Zi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiA+IFRlc3RlZC1ieTogTWFy ZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpDQo+ID4gPG1hcm1hcmVrQGludmlzaWJsZXRoaW5nc2xh Yi5jb20+DQo+ID4NCj4gQWNrZWQtYnk6IERhcmlvIEZhZ2dpb2xpIDxkZmFnZ2lvbGlAc3VzZS5j b20+DQoNClJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4N Cg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg== From xen-devel-bounces@lists.xenproject.org Fri Nov 04 07:50:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 07:50:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437369.691709 (Exim 4.92) (envelope-from ) id 1oqrTS-0001dh-3o; Fri, 04 Nov 2022 07:50:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437369.691709; Fri, 04 Nov 2022 07:50:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrTS-0001da-1A; Fri, 04 Nov 2022 07:50:46 +0000 Received: by outflank-mailman (input) for mailman id 437369; Fri, 04 Nov 2022 07:50:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrTP-0001A8-US for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 07:50:44 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2057.outbound.protection.outlook.com [40.107.20.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62195924-5c15-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 08:50:43 +0100 (CET) Received: from PAXPR04MB8366.eurprd04.prod.outlook.com (2603:10a6:102:1be::12) by DBAPR04MB7224.eurprd04.prod.outlook.com (2603:10a6:10:1a8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Fri, 4 Nov 2022 07:50:41 +0000 Received: from PAXPR04MB8366.eurprd04.prod.outlook.com ([fe80::64e2:acbd:4d56:fcca]) by PAXPR04MB8366.eurprd04.prod.outlook.com ([fe80::64e2:acbd:4d56:fcca%5]) with mapi id 15.20.5769.026; Fri, 4 Nov 2022 07:50:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62195924-5c15-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IkTKKSzCA/8XG5ZFOxL3NkfLsF5WQhLIbx79mGCZ74yXVfyCdR/AbdnR9z6WHXLaoC/XY9MUwtVfWwXrj838U/uMsGMYsB3mRTYgxAWoKHCK7zHA94ma0Q0MFwhlyKUmi1qq0sCj/Cucrm0oD2c3h03cuqcrMd28M4xDcZKueeYbUPi29REuatXtVF5B1nzhpxP8DAOoh9D9p9cuHHydMNggSkDaH4hEcyBWeyuHpObGLvtu+0N4OCMF4cFtG4r74iOxZszmiVl/Atl0DGdq1F7CDBaSHcs4ySYIzrYX67EC2EyE38YI964hR3Uti7l10kGhyuCAfs6uBAtCpZST5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ExbpruphCWrTep58Tmyi4XZsu3EPIONWCcU3hU+XZ+4=; b=b9UiEMzbNo3UM4eG3Hfej5bn+sF0Q/YNXIuKJw3OAv2X33GI1Fl4KPRHR2qUPnG+FNcc0Wb9Xx99u3RX+Vtp5w9gL1nSBUDXSpYzrMGsxL86jD97YVVhs0huy93TmvDuSixqcsQT65JVagZs2aojXz2f7ihoLCp/cRJhGkzKqBlr+DeYmmKklO57jzh9Jx0fcrsZGWm5DdH7WNEwfS0h0UAjg1ZrCyh9iKrY5/XIlmxOSa4UfGTV+eFWyUY+Mp0cYiqyK/UJTtdy4n69F7WDq+D8GQcd1MtKrfozvObldOuo5//kniCJJ4pKqd/EkjwgO8hG9BI1zOaW08lnCjkqUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ExbpruphCWrTep58Tmyi4XZsu3EPIONWCcU3hU+XZ+4=; b=Hm8Xqegv7IS5Sc+Jn3tJknqOAMjcObQSnw+q4RPZ3Bgq1dIthf+5Sgowf85CU8BVl1YX7xVevemKlpL+4dTPtLLy9THAbanqZ2pjK/yWSPzq4ol7LMvESFY0nrLpyzV4g6hKVwfLB6wse2bNgmB6oCsLbKAsO6+RwsaIWM0KCzIZn5ZcUb9vq4IDhkkgEKPh4MWQZfc4jc1seUQSYJfoJUtVXUgTOHsg2M/XZR5JjhtCp2M3IDiCKRlL2Vh5l3CsMnKCi/amUNdQYKsfcZ8ohE1GmAlXmvKfoFNnrYmCpda+S7cNkKyjwpJiH/weYRGAYoMr4DO1KS9ECAIseOB1rA== From: Dario Faggioli To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: "julien@xen.org" , Jan Beulich , "bertrand.marquis@arm.com" , "wl@xen.org" , "sstabellini@kernel.org" , "Volodymyr_Babchuk@epam.com" , "roger.pau@citrix.com" , "george.dunlap@citrix.com" , "andrew.cooper3@citrix.com" Subject: Re: [PATCH] xen/notifier: simplify using notifier_[to|from]_errno() Thread-Topic: [PATCH] xen/notifier: simplify using notifier_[to|from]_errno() Thread-Index: AQHY6sIwabOtOtASVEmIHsF4LdAC2q4ubr8A Date: Fri, 4 Nov 2022 07:50:41 +0000 Message-ID: References: <20221028114111.8150-1-jgross@suse.com> In-Reply-To: <20221028114111.8150-1-jgross@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: user-agent: Evolution 3.46.0 (by Flathub.org)) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAXPR04MB8366:EE_|DBAPR04MB7224:EE_ x-ms-office365-filtering-correlation-id: baca0ec8-7354-4b15-5d7d-08dabe3945be x-ld-processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rcATAydi2VuHWa45ZUmYTMc5nUSdQ2pSnpqRTGvLOtiCFzKYgs3aaz+Eq2dJmXtq0g5HuS7hgAr9Eg47JHQPxSJTXAik63hh1Ww3RASRKSNH6VAp9PlKJWnzti1my1tgPsI3CqSoPtQPklU20Q6Q8tdl3I13IknD2oSbqEfQd+kpJ6MRA01YyLt71phyq16gnt1YB+36/2BmYZI87EJkM1YknImLd8nwmrqDEpQ0Umwg2BAfmf/HsOxz74Gcy0pWS0r9fAqtC0bqJi9pGn18otwyOfPsnUST1zR4jeBcQ2JVF7X5NFWPDKeFGlg+T3lPH7PC9/6QKlVSHL65W7gPtRLvIldxKIPWMYuLQr/+hfPKsMhNs6MlzM/E+6uz4RfjiIXryPyjpiYnwnOCyYV1AWbUQ3S6fyQ7NmHuNqQ8FhcI55/OfAdlz2GQQ7QKIoiyK31+gJmP5pPhOojdrhpGhqCs6AsJQkxteoaMqF7Vb6AZZdIFLE+IUQHvr7HP/jP9eKN9HfgCktuJmV2X6XQwpBs9S4M32PkKM/8qsUvPxG72DIf3RdIgT7DdNek33b7RpswYGd8Ll8DobpCMKHsXBkzkwVeqjzSneRW+yw8H6uE8OMJIsRakzktuwZJ78ICt6V4YdqFEFUz7glSJARnJ7Zu1ddSzJAKMeA4bjzi2eAWU9aCYcpdehsw8pyx9Xtis9j3bhEwzf+cmkO6HXIqTtYY5xtwjp32C5gGsAMC+f8Ft5+5pGsIWHSDaMIUA6CevFsM2DLJQi/3v8oPaWk1eSt3TbzNkr+NkGU/67Iv4kMWikKkF5jqn4jCT72X76UIjjN7yC2hklYkHZi1S8r1BeA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8366.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(346002)(366004)(136003)(376002)(451199015)(36756003)(478600001)(4744005)(54906003)(6486002)(966005)(316002)(38070700005)(2906002)(91956017)(66556008)(41300700001)(4001150100001)(8936002)(64756008)(66946007)(76116006)(66476007)(8676002)(4326008)(110136005)(66446008)(6512007)(71200400001)(26005)(186003)(38100700002)(2616005)(122000001)(6506007)(99936003)(86362001)(5660300002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WCsyWWNsdnZYWmJYWXRqeWgrVWNyeE1rdzFDTmJFSkc0SmYzKy9KQzJDby9z?= =?utf-8?B?V1dHZ2hJRER2Ump6OHNYaWlrTzhDVlVMdUtSYmp4S1cvVkovOVAvSWgwZ3Ey?= =?utf-8?B?VUVzMlVIa2J2MmVVMU5jcVRtekJxMm5RNHBBUEpLWDExWnBCMlZhRForUlhQ?= =?utf-8?B?YWJ2Y2k0Z3drSzNOY1VkNkdNTGNSaGIzSFdRK1lGODd5TlluSjluclBjOEFN?= =?utf-8?B?RkFJelVhbUZFZ0FxNElzOTBoak5mQlkwemh4UUMzcXllS1ljZjJVRVdPWHJE?= =?utf-8?B?QlE3WW1ONkxRUG12NDllb2oyanJ3TUZWZDZWNjhVRUJvdDBFM3BOTmc3Tk5z?= =?utf-8?B?Yyt1dnRHYU9ldWNWdmpRajBVUEFFb1R6NnlzWnMrS0tzR2RSOWY1Q0RrWExn?= =?utf-8?B?WGJISlpVYjF3NzNTUWZjVlgzSjVCUUllQ0s1L24zY1dsZEE0K3NpdTI5ZlRk?= =?utf-8?B?MjdMYnZmK0NKQmFuZ0J1eE5nYVJGQnJTOU5SVkVXQnA0dFdlK1FuVUd5djQw?= =?utf-8?B?S0hBcGcyRllkMFk2OXVXeEdETm8rcnEzU0xVcTJVN3FJK1puTEx1Z1ZQbGxK?= =?utf-8?B?eE52TnZjV2VOeXlKbFl6emhwck5wM0RhQkt1RTNDcWZ0V1Y1dU1NdUF5M05J?= =?utf-8?B?Y0dpQ1RlN1FTZlZZbzBiMGl1VU9IL1RocStKcXExNnVUZkFTaGhSYVBoT2t3?= =?utf-8?B?alpsb3FLQmc3UmZ0Q1hNc2VGYytvNERudDFFQ1V0Y3lmeDhYN2ROaDU3d2x3?= =?utf-8?B?TERaeHQ0UkZIS3lhV0JMSEIrYUN6OWZrdS9PbTA1UG5uaTAySlpkLzY4YXVy?= =?utf-8?B?UVpsY0R1bTJqcUd4NDRac1NhM3pEbDRJQkNuOUZHdFppUC9PK3U0SzNCc2JQ?= =?utf-8?B?Q0tTYjE4cUZRbHo3M2FXK0dWRVR3VzlwMWNBM2ozT3ZJdDRvb3dFcTRCYldM?= =?utf-8?B?WURzRFAyYjV0UjRFVVFkOUtGME1QdkQxbFFYR2svcGh3cUtOMlNURjF2RHo4?= =?utf-8?B?MHlYVi9INkZnSittVWNyUmFOR0R2T1JNTlBpbmdRRUVVRkxhT3FsMXoxbWRB?= =?utf-8?B?andmbWFTUC84N2d5ZVRLbitkWHZVM2RRNGVSSElGSGVaemN6VlAwY2xSM0ZD?= =?utf-8?B?RGhsbWZzNjNWVURaL05zS1hFQUtmbllJSjZTcytiUzZhSzVsKzEzaHkrd2dm?= =?utf-8?B?OFgyVmluTEhVOU1OakVnSFlIYXBLMTFmOFZBR09BY0Z3TFI5L2pieFNBL3pJ?= =?utf-8?B?WHRLWUFJOEcvcXBYcGdmclYxMCtzRGQ3UlU1T1NHM0dIMkxoWG14TDEza3c0?= =?utf-8?B?bVNzWXZrTVFGemVlZGhmUWlNYld4Znd2MHZSenViY2NBYWNOT2pyS3JkVkg5?= =?utf-8?B?M3QrRVAvSDRDamV6UlhpMGJLRVY1dnJhQ24zcmhYblBFVEVpSkRxSkNsUUZC?= =?utf-8?B?aFdtU0pBRG82VUpPY0VKQk1QNG9QNEF6eExMeGdWb0ZtZ3VlVVdjSWg3WHhT?= =?utf-8?B?d1dWNDhRSXhrbVRycGp5MmhwemcrWVB0UDVuWHVDWEc4dEtTQThhWWJpb3c5?= =?utf-8?B?TCtWZDlLUENwN3BVYWdTS1lBWkVqU0xqVWRoMDJMaDBqamlCUFdRMENGOStj?= =?utf-8?B?Z1FXLzFHNlNJdEltTC9XMUplSXYxRXMrQU5VeE1NQXZrZXU1SzZxU2k3RXRM?= =?utf-8?B?WWpIZ2JzWjBqKzBTdGlQdFJQODZadm5na2RRdW5qeXNhZnFwVCs3aFJSUzEy?= =?utf-8?B?eEwxMHVjQUVqM3VJR2pmTVNEbDNQZnMwSHEzY2ZUU0o0SXRMbHA2a2lYVzk2?= =?utf-8?B?YjQ2eVlHWVJhclp6NlNxTWpMMnRjdFlrYVBORmFzVFJyRjlmL2xIWEw2c0FB?= =?utf-8?B?TG96Sk1sNGdIT0ExUW5YTDlzM2hESk9vTWVObldSRkhHN0ZnZ1hQTTlLdEl3?= =?utf-8?B?ZHI5YVU4MS91ZkpLblpHUWRiMEx1WWlPdlk1a2xTdS9YUk9xVFFTUlhZZzVH?= =?utf-8?B?Mi8xR2JMQUlWUHIvVXE1ZVEweTgvZWNGRmpYK0VXUDZWellqcjd5bnhCNTA2?= =?utf-8?B?NW43TGJyUEowSzMybVdwUHd2MTVXMStyT1pMZEd1U3Y5TlhmOEFIK2xvZXdp?= =?utf-8?Q?PjNpDveRCqHWUwR3jnhNx1bIC?= Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-K1T6jo868eI1BUBuZvot" MIME-Version: 1.0 X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8366.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: baca0ec8-7354-4b15-5d7d-08dabe3945be X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2022 07:50:41.8551 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ozk4YD8OsCZmPh2Hdf+rTkcLhjpeORmamdgy2VDr+mwKTn971cfsLuBPdexLd23m8WCqpqm0AnKE+1BxenpAYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7224 --=-K1T6jo868eI1BUBuZvot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2022-10-28 at 13:41 +0200, Juergen Gross wrote: > Today all users of notifier_from_errno() and notifier_to_errno() are > Handling the success case the same way, by using >=20 > =C2=A0 !rc ? NOTIFY_DONE : notifier_from_errno(rc) >=20 > or >=20 > =C2=A0 (notifier_rc =3D=3D NOTIFY_DONE) ? 0 : notifier_to_errno(notifier_= rc); >=20 > Simplify the use cases by moving the handling of the success case > into > the functions. >=20 > Signed-off-by: Juergen Gross > --- > ... > =C2=A0xen/common/sched/core.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 2 +- > =C2=A0xen/common/sched/cpupool.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 | 2 +- > Reviewed-by: Dario Faggioli Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-K1T6jo868eI1BUBuZvot Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmNkxFAACgkQFkJ4iaW4 c+4eUg/8CcveZeoUHELf7Yn6tQrSSSGpB6ZzoNMQr5tavXt6i926FswlG0wsFOAV wWOGlF4iEXzU51yiTSkuXvhYCDDrXaZVIggId8D+Zp0ORaRGWnuk9sXPRjvm1aKR jPvijAd8kFJtunmJjL1Lw/4JLJ+fdQlcfg8slu7qWf8fGqFRk9EQZo3YIEiXkNUN WaANAMLNbr8NpUJyaaPq1hYc4QxnM8wPdA96LqOi84W4TlOGAEFPhR9ZaA1t94p7 U/P2njRFwV2Zo77Dw+2HQTZP8R9EXGHi5FEyk4vYNutGYDBjSDzx+GjONZvzIK+I Kb8gU3TwVRMMDv1e/gsci3QfzX2saLvZPqRJP1YhZ0PylxJAFcBedj4+IYAXVN55 tTzG2ieoHzZ0TyT+rZ1pd5zhWRqBGj68DtBo24pcRyH7j0JqhTWuj6eyWYsY6S7x nqNrEnWkHyLgnnB0CW1KPlY1d7CcMF9igiDCCcDqPpfL89meVu5jaZ9IzU6oaf2c Qusm1kQ0qO3gXGMaLTnycvN2M2Dpvo95P0rOBkVLY/QzNi/xRM2LnvtvzGhujNfg LAX1ouHGWHz1nz+6+vUK32DzLecEbAD2ofQw3JQ96cSpPNi7IaLnriBDxrWJEioE 4LZ3vBL3636VlQSIM8p4rLzw3sIOajWRAFayBrLr27f+8tfpxhE= =jOaG -----END PGP SIGNATURE----- --=-K1T6jo868eI1BUBuZvot-- From xen-devel-bounces@lists.xenproject.org Fri Nov 04 07:51:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 07:51:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437375.691720 (Exim 4.92) (envelope-from ) id 1oqrUZ-0002MS-De; Fri, 04 Nov 2022 07:51:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437375.691720; Fri, 04 Nov 2022 07:51:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrUZ-0002ML-Ax; Fri, 04 Nov 2022 07:51:55 +0000 Received: by outflank-mailman (input) for mailman id 437375; Fri, 04 Nov 2022 07:51:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrUY-0002MD-91 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 07:51:54 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80044.outbound.protection.outlook.com [40.107.8.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8c251c73-5c15-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 08:51:53 +0100 (CET) Received: from PAXPR04MB8366.eurprd04.prod.outlook.com (2603:10a6:102:1be::12) by VI1PR04MB6848.eurprd04.prod.outlook.com (2603:10a6:803:13c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 07:51:51 +0000 Received: from PAXPR04MB8366.eurprd04.prod.outlook.com ([fe80::64e2:acbd:4d56:fcca]) by PAXPR04MB8366.eurprd04.prod.outlook.com ([fe80::64e2:acbd:4d56:fcca%5]) with mapi id 15.20.5769.026; Fri, 4 Nov 2022 07:51:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c251c73-5c15-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FZB4Hs5mNammhTG6w8IBNqzpCkVZS7N1VyTJZPtf+VSKBH+uhSFO1pjykQHEjPZeSs0qr1aWO96/ieNkoRAGHH/ObsK4W3KZgWPnM/6PQDzmZ+LXMyPDw3ARnxzTNeLnnZ9VKsYBDyWWuYnFIBIVxBV6PKpt3SFMycoKAtuYrzuHJeIir5MilDIsgTAJVd97Dk94xtheMd2PG71uDu2x3tbSPweK+eD9xfdUJaEOGlGa6N/chmWTtEmVu4JaoysL6rspwpysMwseSXWr99PQSEw7VgfwXoVfxeUNC11wuusDKeTGMYSQAkvvu+Cd2TARpWRcajJlJhXpErA6yDvNWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1ftcIp3za+qGZukIz8xF3x6GnwAHmm1H+krAr9CGzxw=; b=K7D4D1FlbDQTqChe0ecghv4Dv11wmQSuefquQViF2f5klWYXocMzh+mj6fH/FijnMeFeo2CxAyqvYtOJmFHXG9hFXF7LpUI9wYGuXL1M1Vflkna9uIFp8mfnX2xM8Fl6XUKjDCrnI1kn5aGxc4sWe0arUhGE+NZz1qANtxJFypdSxW+ard9PjKuTyk1obeLhdz9HA4YNSqpBkVR/Ziv92HHObG4epPfqphzQTLTRoyfZDHVbx5/XE6Q0ECwKV0NRJj8QVjWF/um2OF7KYV12Zu1JtJfpdL3l46TgejYatvFgy64JkmCpVo96+W2r8lMDntYgEjz0LySypMGK6tXrYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1ftcIp3za+qGZukIz8xF3x6GnwAHmm1H+krAr9CGzxw=; b=FgsgECDOT7kPBTgukcNTulDgYSe5Nea5021FGVYZaqyY5HRUH3EZfUIqd9CbxuJ90HiBfYkx7xo+6k2VMOTJMuuXJ5tgCyRtVC1XZRw720nM6kl7b6qRJYqsJLBq6ZmkMr12uZTc1KtwvsyqyVvPYqpldZlgLWwIyqiazE4hNOwfxuTmmfkXuneU3ULez2URa2+enaNQ9CEV+ZEhAw4Ygt0TF8NltNRUEiHVhGqDMEVD29Ai+8dzMre9Nw+Kf2igcvXZxgwQlbdjIiRlDi5tKXWkhMEBu3vPpLP9BcJ5MMkkqDoxdpW9MP41vKskmBlEC7drZEmmFV2TdGChSs/sKQ== From: Dario Faggioli To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: "george.dunlap@citrix.com" , "mengxu@cis.upenn.edu" Subject: Re: [PATCH] xen/sched: try harder to find a runnable unit in rt_schedule() Thread-Topic: [PATCH] xen/sched: try harder to find a runnable unit in rt_schedule() Thread-Index: AQHY5TlxkxrNiKlOzkijH5MHuuXCiq4ueiOA Date: Fri, 4 Nov 2022 07:51:50 +0000 Message-ID: References: <20221021103945.4416-1-jgross@suse.com> In-Reply-To: <20221021103945.4416-1-jgross@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: user-agent: Evolution 3.46.0 (by Flathub.org)) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAXPR04MB8366:EE_|VI1PR04MB6848:EE_ x-ms-office365-filtering-correlation-id: 45f7bddf-cbee-46bb-392c-08dabe396ef0 x-ld-processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F5WyhFxXjP1dh9BkW1HIKU9fKzhMfhckZh/cvTw5xco2zRe984qVI1+2fIhOTpO2XXD5a8SHoMZIr+tp1JDKRjmFi1IFc5aD/d3oDl7upTPnBCIeo58FMPA7MzrIjkLyHi6tKSWNLXb1Mh3KygjVI9p1GNjrkdJOslIodcb7Wz2LS78txwRh5NGFggKDFlh3G1VEjkTID/blTbfwKFLSYQ+bY5uuqqJPeHcl7xHqJVmTlbNIFw9W/z+QcqOGXPUvGx+M6+Mi0Dqk/wssZyvBxwzLqGvUIwKtfCbo7fu3AJPx2zUFMh+4FyCwuqgio1fidmL4CQTEYMOxf1f1bArB4YmdMI748BW4RBou0ZCQruYZnVuR24PbLs55p+GNO9ze6XjLIz0GlnyN6qxixHs+vwggOs8s9cCtdqW5azY0kfblTZdRHQH6jCnmfH3VeVc1qKj6CPdVeFBawSodFUwoHsw6wn8IWmEvVvhEToCe09iGYYLlxBUcOMHjINyCGMmAl4Pc8Ma7vQgpBv56gYQ9gxQJHEljNPDoT8YmlkA6SSW62kxx6ci5UqI1cwaEylNWOMetMHPweOoeeGuSC2+uv54r/jyoYMpfVwvo0tOV8wXa7KEonFHbhxRueXR8l/8GQcjrbJEa6p4wSHZ+JqbuKdcqglPQ9F8OFJ6MJrYyP0hjaJcWpIkbav5B0aNYBl8ic3XM7CWPfchHvXhBddIzBQKzs8QPCK8qF9vnirXb1jHZiEcisBKObfQqJRz1UpyiwZpTwhWd2Vh/LDtz7Fq86XD/FrIhhzFPP340MEoVSwWTBGlpQAE0HE2F7PkIKbiaVv8IsecUFxJRL+PpQ0GZZKdavnZpjVR00g1JzsMKDMEWGTDjc+Bzf1qCcRSAbtZIW/ScjbfWnY8SWHnXiVfv9Tk8Bbew4noZk7bFnhAb/Izz7TJS2Zw4f1aoFQC0O4Fq x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8366.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(39860400002)(136003)(396003)(376002)(451199015)(71200400001)(478600001)(316002)(6486002)(966005)(54906003)(110136005)(8676002)(6512007)(76116006)(66446008)(66476007)(64756008)(66556008)(6506007)(66946007)(91956017)(26005)(36756003)(8936002)(2616005)(5660300002)(4744005)(2906002)(4001150100001)(4326008)(186003)(86362001)(41300700001)(99936003)(38100700002)(122000001)(38070700005)(64163002)(34023003)(37363002)(148693002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SFNyZmZ6MUpRZysxengyVDRXcXYrajNDeTc2N2k4QlV4bzZ5SzIzU2RXQ3dj?= =?utf-8?B?U2lua1NTNTZIUDVQcDkreW1MRWZGaWxCMUx2WHBpamxRV3ZQZExaTXFteE9H?= =?utf-8?B?Ty9YRE80WmkzRnZrZ015MGFuYmIrNCtjTDQvQWZMM0NydURIeE81RXpWTDFG?= =?utf-8?B?WklmZ0xncTZidnljY1c0eWNrVWdCK2xmWUlLWHZrdzNMcjBRc0pHdko4ZktF?= =?utf-8?B?WW1OTlk2RGVUVXBrRlA1STQ3M2h6bTkwTk15ajdaRUVpdC96K3BLV3I5SXI1?= =?utf-8?B?clVEZkpnTkRzU3lId25RV1NqR3hPRDRIblg2ZlBnRVFjSm5sdHZzZ3RjdzNs?= =?utf-8?B?aGJXeFh6VlozVGdMMlZCTDFPZmNOSldEYzhBdGZ2a0ppNEQ5YjJMUFVWKzlF?= =?utf-8?B?NUFRa2xlakpXb1JzZ1ROSnlRUmtTdVFBR0dUMHhPaFdFeVBpb0N4ZGV4b3d5?= =?utf-8?B?cFdIQXJxblRoZWVRQlBKblVNSkVFclR2dDlTQlduemRaUlJiY3RUcHhScGJP?= =?utf-8?B?UXRCUUw5TkNhTEMvM2R0YnRKZmZVdzkwV3NkNk9mNjFqekwyRXRGd2l2ckJT?= =?utf-8?B?NXZ6bU9sWFlSUVcrcHg3MmdvVUhyRWF1MHp2Q3g3YldIT0xFdEF1TGZCbTBU?= =?utf-8?B?VnEwa0ZnRjlzUHozU2VWTThMYnJtbmgwbjhxZzBUVUZvcngyUnR5dTJCWFV6?= =?utf-8?B?bzcybTZidk82OW16Q1FzWklqazM3eDRNKzJlV2hQank0eks0TXQya0o1K2FU?= =?utf-8?B?bzFlV2t1NFUrekRKeElTMlpSK0I0NTR6V01Fd3JmelpXUzhTR1lLcnNsckFB?= =?utf-8?B?MWhUbHlFTkJrVVRvdGQxTzlnT0tHKzgzdFZtMEF0NXBmVDFkRGZRTmROQjJp?= =?utf-8?B?enh1Sm1qTUM0QWlpRHpkc24vOVI5V3hWTEVNSU5SRmFZc2NxT2pYMTFwUllk?= =?utf-8?B?NElJUnRFUkZEdXY5Q0RUUnl6VjlKMTg3SWdnOW1WdUpXa1E4MmU4TFBYbzk1?= =?utf-8?B?UTFnZHg0amdDZGZsZVVqNldPMzJZNlZsMkF1eHd5WUNTalE1OEJqbTZlbjhO?= =?utf-8?B?T3I5R1VhT3loemVzZ3lRaE5lYys5V1FSVG9iUVdpZzhUQXd3SHV1RkpaN1VZ?= =?utf-8?B?K2FGT3hLSjFuVi9iUEZCelQ4cGprcHhRL3dScElsSHZGRlpaeTZzT0c5TXpy?= =?utf-8?B?RE1YTk9vcThsQXBmbDB2cEVwTlNIZHM2dStieDhOS0Jka0l3NmdsdnR0TzU3?= =?utf-8?B?L0c5LytwOXM1M0JBUG00QlZZalptcnloYlZyMlFrbHVianJHdkxTbzUrNkRx?= =?utf-8?B?OEZVQkV1a0NncUFEeUw5dTEzYWYyNCtGWVhLbm5LaExoby9WZmtXeG4zMGN0?= =?utf-8?B?UnZEcFlqZVNVRld3YjJlc2t5b2NxNVpRK2Y0UUFxbUlqakxQYUxVMzVteVBk?= =?utf-8?B?UzNVQ2wrdnR4b1dncTV1L2RPcCs3SUFTa0FacDJhTzRLMHJCZUd4VlpYQ3FC?= =?utf-8?B?NXJONWk3Z3cxbXhGVnZlemttT08yNnpzemF5SFh5QU1xdUJxVU02MWJDTnFM?= =?utf-8?B?VDRiQjAyNkI0TE5vejR5SWk2YTlzOVVIb0NDcDBsS0M0NFI1SUt5eitCSC9k?= =?utf-8?B?UStvWStvcFlkVm5JZ1FCRW9sYjNROFdqaXVCQWUwekpmbkMxdjZ2WUltMjJp?= =?utf-8?B?aWRFUmpaZUhwaHg5WDNwbC9ZQ3FoZ01tekpTMjIvUzVwKzVTUm42bXlBU0JF?= =?utf-8?B?UGpvMjJmajQrb2JacTF3Y2xsdnp6am9BVjhvdkpNT0JKN1Z1UUoxUUhYMThi?= =?utf-8?B?dDRGUTBVUFVkemE0ZUM5RlF5Snd0TUJwSU5MUEwxTVZsOEl5VWNjMGFFekYy?= =?utf-8?B?V1l3eUJQSlBDSHBPdjZwSEtFZVFLRFcrT2txaUh0dVJvZkFhalZlUnQwK3JY?= =?utf-8?B?UUtMakFxL1RxSkdqQzRPcGwzaStiMkwybHQ1Ty9hTWhianliNFZnRy9NQlM1?= =?utf-8?B?bFJDaVgvOUJMUXBDbE05eDNNRVVaRXp5TGZHQjRNTFdid3F1eWVtOWRqNXZi?= =?utf-8?B?dVFQUGt4S0kyZWlncW9WWVlZU1FGT25EeGVsdTJUdEUwZDdLTGFkMFJkYUFM?= =?utf-8?Q?8sa5sOKv51xTh0RM2EViqgm2K?= Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-jXCJzZpyRkqPh1ZcSO+K" MIME-Version: 1.0 X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8366.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45f7bddf-cbee-46bb-392c-08dabe396ef0 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2022 07:51:50.9371 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XbnWTtQBjQ/zaHmaglX0mzv3KfW+BvygfusBksYqZuzLEp2AgXO51QpUnYQ3cO3mLvZSIrTmn7Gjp8HPUXcg9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6848 --=-jXCJzZpyRkqPh1ZcSO+K Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2022-10-21 at 12:39 +0200, Juergen Gross wrote: > Instead of directly falling back to the idle unit in case the top > unit from the run queue happened to be not runnable, consult the run > queue again. >=20 > Suggested-by: Dario Faggioli > Signed-off-by: Juergen Gross > Reviewed-by: Dario Faggioli And thanks for making the patch! :-) Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-jXCJzZpyRkqPh1ZcSO+K Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmNkxJUACgkQFkJ4iaW4 c+4RNw/9H7XYXESiZffRrAgh8czjStHUgcjEY4MkGT2ZHo/VgVew16DpZCa+l++W uLItVulxCxDLohCR6jCioL5/8VWvHecuf3pkwfb70VxXJyeDSkfORXEW3JxLqb+o UdxNK5gMSZdpBYJEqzej4TbqpWdt/V6z3hiokNz8BDlQeF+AIt993QGfPJswhHh7 8CWSZk2VseSxyu6xLVUXH2Da86u/VaZnN4DVICwaqqy4kw5zvB3HSSe3Dtle2AWL GWFikpQzNyzxcnSgY1KDwNaaj1YaFxmtVgSPRLpFU1KF/tWkRCVYPxTTdWFejQ3A 9ruzrlynGcwK8Q2MjqazcoS8y8YfynOabjJYaRX+0KtHgBHv/K+R8oUH7IM55K0z K8x366b1Z1h0+8cZupjhgQagqBUf5x+tgOqT2T67KQ9a11rh/+yvAotTPnwDVhYN 84fgMXQo4BJAKJNtc8d/X2aUwq8mKBe53rteOpceHP1BugXfby82omqTIpueWHJF P95iC+ycZE+vid4un5ZzL/WEihoErFOJMU3jjwM702NiWpD/tpLjaCEX7uXCd/Fs wHbcvezW7YPCZaBpxyDSLozps8tb+X7Wl8dXuOptlC7qVX/FMSe/bY05k1zAFzVX 86nbqp61r2x9GrjLKdVUBqRZjfKtNw0s/a564+r9NhmrCyJ0MXI= =oQwh -----END PGP SIGNATURE----- --=-jXCJzZpyRkqPh1ZcSO+K-- From xen-devel-bounces@lists.xenproject.org Fri Nov 04 08:10:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 08:10:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437386.691731 (Exim 4.92) (envelope-from ) id 1oqrmY-0006Yp-7l; Fri, 04 Nov 2022 08:10:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437386.691731; Fri, 04 Nov 2022 08:10:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrmY-0006Yi-4z; Fri, 04 Nov 2022 08:10:30 +0000 Received: by outflank-mailman (input) for mailman id 437386; Fri, 04 Nov 2022 08:10:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqrmW-0006Yc-Fc for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 08:10:28 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150083.outbound.protection.outlook.com [40.107.15.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 233caab6-5c18-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 09:10:26 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7129.eurprd04.prod.outlook.com (2603:10a6:10:127::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14; Fri, 4 Nov 2022 08:10:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 08:10:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 233caab6-5c18-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T7kJofI5h4Xc8ljf1gfOsuwFTuu0oB4KHYRwRVA7huJQj7Z3uut1cOCalTLbJxuhxvZXny3CspNY/2n7x6XCDZd/zM5cVhp/KyWJ0WbDKaROKNqA1swY8/UbZ1EGNEFNVWVT78GTq+gx9ZFBrVf0kcboy5cs4j2jvxOqiZnheSDx3g+CPsCFad61SyMmzycmn8Rjgv7+ADo1Wv7gCRa4KaBvr0lQmStrMEjuH26+JDXoIBHRgl/gFRzsAL5dyQJRYpHCXSjAxsKYxA/jD87ErD9OPtRJD1N/hdbCZRRJq6XHHZ6hGpVcBv44zWSpXrjkrNWzoLbaBTJUEdJ0pKFizQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2IEdaHYMGuJODnXkwERiUpE0qdQq3pZlyBELl1ZOlCw=; b=BSvFnJ7Q0bsVIo2uzaf+s60nFhh5iyneIUS18CBBHxMRgqiZkZV6APfQmzOaXXUhmOBlwPq8O1H3j7LrkBfAOJzpRomxw2VAALq9yRjHQtdjQJdUWzhiN3OC5eV0HNuf+MP6gLbNNYLR6cP5ViIOjN7LFOzQ2Vr+ecPpdIzucCOinx97UUAJZmdItmv/YLF6tvHrOk0d4DXnOncEcQ3z5fvjAGxEGpI0EZh0s6ZHrhxAhT8L3pCZtfbZaT5FWDZrd6o03h6ZC9XneR60M3YIWuD+GJrFms5Q52PDQ/Qe3S21xPUGGxpjOnNU7pmpXewdE0Ihn82Hz01db/4u7qIsIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2IEdaHYMGuJODnXkwERiUpE0qdQq3pZlyBELl1ZOlCw=; b=LibIC3rSQKAwovEfQdHe4W37uiG+FkLe4yBKIll7663t1JpvY6QmBPZ/vkrH8noFQONeKCc+wR3Y3sGFP12K+JHLNmdXcEjO7R9GdcfZyzeH8BPt8xYfDqsbs/1JePXYj3IqnTsEGOqLwBJT6uWNfDSDs4GZkPsvSJx50m2oYEeQAIwmu1A8f3sYw93HdszQUnBJRLcuDeQ/WdHJp5NQl/NboeNNMRJ6la9rSidS78aaQQEnsRP657IY8XyNWDoh2lRWDi5nC8FF+72r55ZBxyiLpkyWRMD1qzh0YaSyvCHCrLYFsi4YTZ+rS9eJhEj+24Dgg/iAiyNhTwWsBcBRlA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <952950b5-33c9-6872-0cc4-6ebdf1e015ca@suse.com> Date: Fri, 4 Nov 2022 09:10:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 v3 1/2] amd/virt_ssbd: set SSBD at vCPU context switch Content-Language: en-US To: Roger Pau Monne Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20221103170244.29270-1-roger.pau@citrix.com> <20221103170244.29270-2-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20221103170244.29270-2-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0309.eurprd06.prod.outlook.com (2603:10a6:20b:45b::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7129:EE_ X-MS-Office365-Filtering-Correlation-Id: 80df8f39-1908-48b7-7ec5-08dabe3c0632 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nR9Pj5paz7qtNuocAjscl0o3iTjzl6kMkoE/5sbv1RXGbK+7OSlHsz0x2yMeHV7VXV13FbeN2IklTOykliyHjAEmu0cot7UeBY6yjf1LlAyXZXD64ZajuXwAHxyrZPv62k2ySwf8/qdbSFej/kEOyovy3F1TwAeZaFzHjXFVhrXa/HSgiTtPEQ4BrsdAIvxLS3Y5b5dFvj4eXD4rmjpWzqbBxt6dKgcEyahyVtdWRTbr0N4cqlv1R3d0qxpXeTK+HqjA1FIk87nwKdEGzyivh3aj+GD4U2a5mCAPJRN28oqq7KbaCybwut/jlpGHYFgmg3EJKMonmG2QJzDtZ6LKf5V35navTHN2pxcqMpKZ57ZuepPTP2sqrJ15Z8AzmK7EvNAMfk9qY6Gl104XsBXnPb65qf2+bw1gzCKRdX/7Zmy9jX3u1vnH2ZD62oFyToEpqK8gsZ5RZnCLvKIyG+qtHE4HDzLiWm7C+Zp9avXMM/RkkjB2F1e7en7P48KnaC3DOK4xvr6lFLw+gwLlN4demX0qgmMnFmLqytJTBNQpl429nmm1zrN7pC2EJbARbkYNU0do+X4gTaKhMUf3U5xBl37ivXQNDS7J0LxYoHIHuA3lNKWJVUkoef9mpO9d57gEYvpiRL5cmLA2KAGz3SVfJYkTktF0Mx1u6usRa485oErKHtH4Uqg4I2WmTa9uwTz6Y4VXKUIJrssoO47qdC5EX4Mpa36DrEZswDI0fR+7YN9HdBkU9AB2U7idAg/lH3yet9vtVmngoU1/xiYzRq00YnxPLADoBKerS3LVeWWYkBI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(39860400002)(366004)(346002)(136003)(451199015)(478600001)(66476007)(6916009)(54906003)(66946007)(66556008)(86362001)(83380400001)(316002)(38100700002)(2616005)(8676002)(31686004)(31696002)(186003)(36756003)(4326008)(41300700001)(6506007)(8936002)(6486002)(5660300002)(6512007)(53546011)(26005)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXVzZUl1K242aUY0TkxqS0d1TWNDdStiU2RIUTR3YjU5NFFtWjFhcUVqMFZF?= =?utf-8?B?MTlUcjhsRHFwaHN6L0c0dzk5eXRrb0hwcENnTm1oeDJiYllXOU1NNDY0MlRZ?= =?utf-8?B?V1dCKzEyTEhuVThlbCtmb1V2LzZ4bHdLK3N1akozTXpaTnBIM3Yyclg5UkxB?= =?utf-8?B?VnZqZmxwZVAxMWd1cENTM2NzNTVST0JPR1JPOHdNRlVNbndHMFBJUy9mUXhP?= =?utf-8?B?ZUFBNklrSCtXaER5dEQ3dkJpbHNEeG5JZlM3cGxwcjJjM3F5Wlh4SDAwRUFP?= =?utf-8?B?aDBYUXFkU0pnWmw4RUhZT2VGdlpLMXp6T3BLT2RFN1g5S2pkbG8xK3JHYXZG?= =?utf-8?B?VlBJeUF4VERsUjhpdzlKUzRYM0VXcWRzUnc3TkxMNWhCbXMrUmdZcTJtU2hm?= =?utf-8?B?eFhqY1RCRlZwK3ZVZ3Q0Wko2ekdUK3RVSkZPZVorY3piNUZ4V0Z3RlJTdlBI?= =?utf-8?B?aFQ3QisxZnV6V0oyUjd3K0NMT3J1ckZJblFyWWQ5dERqN0VmTmxZMzBtcUNI?= =?utf-8?B?RVR5ZlVnczRURUM1V1BDL0ZQOTlUOENRMGIzWkpiQWpmTGVGUVJ1NGFYdnky?= =?utf-8?B?WksyNXM2dG9pWVhtZHVwL3VqVk50NWhtNC9SdnE3Q2pTRUsxdU1aUVMzaUU0?= =?utf-8?B?dXNpdHp1UExjWnVWaTdPNlhnV2dPYUpqdVovNUxDWnJFSzhtVGNIN1RqdnFT?= =?utf-8?B?b1ZTN2RhRnY4NytuRlZ2bkZvbFc0bkVzOG9YcUtjRjRFejR4L3NkMEl6amtl?= =?utf-8?B?RmdyVWZ3RTVEZVZMTjhEVkhoWDd1L3dqYnVjVjlHRzlpMTRjVm5GYTVKSjZC?= =?utf-8?B?QzNXSHJFOWFabGZBOHVFcWQ0bkpTaHdFQ1VFMTFpUnBnQlVJU2s1QXlDNWpy?= =?utf-8?B?d1V4RU5sSHJUR2JjSTRKcUZFTUVUU3hPM3FlYkhHendpSDZKbXNWQ2Y2bDFH?= =?utf-8?B?M2M0RzU3Rk1YY1dnaWtoUFdSY25KUDJHeUhCWUZKVWRpRC9EazdsRkJkMkxM?= =?utf-8?B?RjA4R3JFTHZGclgrdlNWYVNoQndWM3lOVGpPVDFzK1lKNnFWNEVsTGgwRW5a?= =?utf-8?B?ZTZSbWFEdmtsOXJ0eTkvTGk2akwxeTZhdlYxQlg1NW41VlEvTmFTSUZ1NlZk?= =?utf-8?B?MjlIcDczUWRxcnErWncwS2tqWWQ3RzdzSFNVR1NneTZITGJOdnM3T05MeFFw?= =?utf-8?B?ZXl5YTFVbVE1ZmprMVpyV3VWQjkvRzQyc1pvaDdMQlRqcERMRG1TaEcwSU03?= =?utf-8?B?MXV5ZnJ3aTR6M25JanFTVloxbHZYRWsrMmxvV3V5VHRBYVRyLzlJeWVaeFZm?= =?utf-8?B?RWtqYmQ2QXErdzJUUWtEdGRVQVBVQ1YzSFFQNFc0MEZIMHdZelRzQ0VaV3g4?= =?utf-8?B?QXVrb2RRMHJxYlpQUUJ5ZlBITmFZMlZmMG4yb0pRK0RvYnZhU2crenZQdnBm?= =?utf-8?B?cFB6NXV3T0tiSlM5a2FRTkRSZUM0MVZzSkwzOVAwL0xURzd3cWIrNFJpUkQr?= =?utf-8?B?ejl2SUxUNDZxY2V3WkswVWVaWjVZRVozaldLQlVZNDRZSndzZVlybDdNMGtj?= =?utf-8?B?cWFUQ2p2bzlRM2YybVVDSVl5UFMzMHhKWFBIL1VRT1Z1SSs4eUJURWx5S0tF?= =?utf-8?B?U0dRck1lb3I4WDdnUW14akdUNzZDcmN6NFhXbnlnRnZBbE9qQ1pDcWsrWTda?= =?utf-8?B?bEFOa01UN01Kem5rL3dieXpXdDk3ZGowVmQvOE9OYnFOVmorRFR5K3NoazRr?= =?utf-8?B?Y0dLMDFDeHo5WGJzSVM5T1FCR2Q3WTB5SVZwNXBybXA5REIwNmJGdXVqNkpI?= =?utf-8?B?ZEhrcUVzSlpFQm82NGlUcjI0dHRoUWk1WVVDd1lRbTdWMzd3WWl2MXpHOVpK?= =?utf-8?B?TWVMSTNLL1ZzMFNuQ2l0ZUViVkllVThpTjhEcUJCYkhKNFROZHp5dEx1SnAz?= =?utf-8?B?TEprUmxGODY0MnhsOXhJT29DbHhPTDV0aFdZdWpTenUwbFFBTERUYnVKYlFJ?= =?utf-8?B?NzN0K2ZPa0xSZlB1b243SkgxQ0xSaGJuWTE0clpKSjhVMllCV3R4VUE5dlpa?= =?utf-8?B?cXpNR1RtblFXOTlRbUpIamZXRXErdzVleUZYaDFvMTcwam8zT014c0xheTdI?= =?utf-8?Q?GCOOZdizbYxtZRr0osFH7av90?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80df8f39-1908-48b7-7ec5-08dabe3c0632 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 08:10:23.8884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iJDwBL8cox+Wl0veK3FGllRuzim7ct8F2bNf2upNhKXxt0TnFOUM90/i8aBMaf8msX8WVB9WEV0j6dRHb15aww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7129 On 03.11.2022 18:02, Roger Pau Monne wrote: > The current logic for AMD SSBD context switches it on every > vm{entry,exit} if the Xen and guest selections don't match. This is > expensive when not using SPEC_CTRL, and hence should be avoided as > much as possible. > > When SSBD is not being set from SPEC_CTRL on AMD don't context switch > at vm{entry,exit} and instead only context switch SSBD when switching > vCPUs. This has the side effect of running Xen code with the guest > selection of SSBD, the documentation is updated to note this behavior. > Also note that then when `ssbd` is selected on the command line guest > SSBD selection will not have an effect, and the hypervisor will run > with SSBD unconditionally enabled when not using SPEC_CTRL itself. > > This fixes an issue with running C code in a GIF=0 region, that's > problematic when using UBSAN or other instrumentation techniques. > > As a result of no longer running the code to set SSBD in a GIF=0 > region the locking of amd_set_legacy_ssbd() can be done using normal > spinlocks, and some more checks can be added to assure it works as > intended. > > Finally it's also worth noticing that since the guest SSBD selection > is no longer set on vmentry the VIRT_SPEC_MSR handling needs to > propagate the value to the hardware as part of handling the wrmsr. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich with one further remark: > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -973,6 +973,16 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v) > > /* Resume use of ISTs now that the host TR is reinstated. */ > enable_each_ist(idt_tables[cpu]); > + > + /* > + * Clear previous guest selection of SSBD if set. Note that SPEC_CTRL.SSBD > + * is already cleared by svm_vmexit_spec_ctrl. > + */ > + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) > + { > + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); > + amd_set_ssbd(false); > + } > } Is "cleared" in the comment correct when "spec-ctrl=ssbd"? I think "suitably set" or "cleared/set" or some such would be wanted. This could certainly be adjusted while committing (if you agree), but I will want to give Andrew some time anyway before putting it in, to avoid there again being objections after a change in this area has gone in. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 04 09:28:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 09:28:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437396.691742 (Exim 4.92) (envelope-from ) id 1oqszT-0001qU-VQ; Fri, 04 Nov 2022 09:27:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437396.691742; Fri, 04 Nov 2022 09:27:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqszT-0001qN-Sc; Fri, 04 Nov 2022 09:27:55 +0000 Received: by outflank-mailman (input) for mailman id 437396; Fri, 04 Nov 2022 09:27:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqszR-0001qH-Rg for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 09:27:54 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062.outbound.protection.outlook.com [40.107.244.62]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f1e9747e-5c22-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 10:27:51 +0100 (CET) Received: from DM6PR11CA0017.namprd11.prod.outlook.com (2603:10b6:5:190::30) by SJ0PR12MB8114.namprd12.prod.outlook.com (2603:10b6:a03:4e8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14; Fri, 4 Nov 2022 09:27:44 +0000 Received: from DM6NAM11FT065.eop-nam11.prod.protection.outlook.com (2603:10b6:5:190:cafe::8b) by DM6PR11CA0017.outlook.office365.com (2603:10b6:5:190::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 09:27:44 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT065.mail.protection.outlook.com (10.13.172.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 09:27:43 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 4 Nov 2022 04:27:41 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 4 Nov 2022 04:27:40 -0500 Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 4 Nov 2022 04:27:38 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1e9747e-5c22-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J4QBnsTNVxAvwFbYShAQ1KQSg2N3pjntsdp+W40fqJpK0xJwlpBhTBvgqFzSIPMg22pGf/69DYZkKQKb1mTSgYBFmSnf1fiA+NQ8TXAx3dwKdIsY7I+ev1KT43O0JJJNtfP5x6j8x5L5QpCeeyq4Y5hJ5NHgCLn6fRCXe/22A9iSNrIxi8VEL8aaqBtKB33cXkIK80t5mCtVMurFptVGt1EnrZp7HegpKB2XPJ7W4D11rmNo15v2/95aQ4UjQ8WgMWf3QL8kg0O0vAuoyO1SGQGOnDpaj2pEYZ4Qvt0WIat8kW4HVN3+2gsnSm5ruJMHbymypHNOtz9OUA8vrqW80g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zE7umqfjD05MqPI5GDuN2Nxk9/YoeFlST5Rhs9j8qTQ=; b=SdGEhb9zJojm/bKrc/OnCp+DbzeksEgXK+3FNFAg6FRrJod4wofO/rYOf8rA3C+OF8Xeu286zh7LiK8uucFnYChRFugPK+e/p4zH4dfCeyIVC/n6V7x2vnIGVLOlqHd2M88PLVyY8/ChIdOPGoIjSwYs6+C+pw10vaFyLR2Ed7nVUqhfneEItzR3hiiOPoJIyWs87efeiJFAr7B2lo9Ek82dnG0F2vbKGeoPSZkHLOjbtND0f0DbHOWaRaOlGtS3nQ018ohVVJr/PMCSDOWja+YkSAAPe2j+P00K27dHghZhbkJUIXbbDUaaIXz8k//lKwc0WNwJf7m4IpudagZrlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zE7umqfjD05MqPI5GDuN2Nxk9/YoeFlST5Rhs9j8qTQ=; b=jZOXMOYs1YQpXkvrDFDmJgbGzsy/s4mry0MzJzaJYtqDZsa6joBbWfZp553YzbdL/0M5U0tMRgCmAmQahOQa6nXHcxx0xxdoumTh/FJY43r4Sp1MnqUqVtHI5B46bxc/MNYTR8Lyd+rDSes08m6ujr+6gC3c5vt750+M23tkbpw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Fri, 4 Nov 2022 10:27:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 09/12] xen/Arm: GICv3: Define GIC registers for AArch32 To: Ayan Kumar Halder , CC: , , , , , References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-10-ayankuma@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT065:EE_|SJ0PR12MB8114:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d520936-6875-4ac5-29e0-08dabe46d3c6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZHzXjUw9JUNG4d61G3pwzSGe/I9VnAEryqsrgiYNpuX09IzxKV7jdaIulZQc7ZbPIIwWyLP80Exe2wPp9IfY15RdufwNus70JHFo3nvuAPS4w5A5SQv2BZ74bCfRHkjJDTnMoaubuK/lXCylJyTUcXDNWWaPTCLLMMP2QJUN/Gjmb/tEPXy1tHuLve2ihQHQXTLSBc3uDyeLApB1YGnS6iv0LnZbYnPb04lh6gcT/BHRFlBY5QDUp2ojNSLtoj1XKm878xZ98lsae7P29MYmuB+Vg1DjAIzcRn8sIt5GdZGExrKf9WMLvu3A1dNClNXHwdKWkpfrUhAUZ47YjD5aHhBrk+jhUP0XxOYxCJS1fuNf4wAVoMisHBs/KWGi6tYzdR+kAaEzuCZSwvk0R07Tpha01m3K99vOehiIRfNGQMUj8MS+G+Etf81Xh2GlrDgoduYhQBZqmk44DTZZhlyc78kx3T6XBEwFNsHAQFnYPVFhiz0OFEa19oTvDyQK0e4VcftJr8z8vR5V0+1fGmEP8JpdvfZ1e4MGG3IBcG8rDuEuFKnAfoTrw26Qzo6wQNyk4m7CIl97Oi3qGG7LU2Wj9DUruLp3mdhfoyl0EY9xO+l3vAHEW38F1nzrkFiz+YxNrrdzrcJSTWhOcXyGQX05LJ7D2DQJKC81VyZHyTKjIcSv5vJVNY9fYbZXOqN+8tDH29VFc3VdLKC+3b5DorIzNORbYfb7xgfRsOcJk7hsmXWmpSnOnLbbMutQ8R6uhC80L91kZ7lN+qzUVgLJpCEtmVYQf7sQF08TH7uBldhpFzsLYPDbVq+gB8/TIwQHY/t6ErtCbwP+3B4VgsAQ43u/rg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199015)(46966006)(40470700004)(36840700001)(82740400003)(82310400005)(31686004)(36756003)(44832011)(81166007)(356005)(426003)(40480700001)(83380400001)(336012)(41300700001)(8936002)(8676002)(31696002)(86362001)(2906002)(47076005)(5660300002)(2616005)(4326008)(70206006)(16576012)(110136005)(70586007)(54906003)(36860700001)(40460700003)(186003)(316002)(53546011)(26005)(478600001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 09:27:43.5532 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2d520936-6875-4ac5-29e0-08dabe46d3c6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT065.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB8114 Hi Ayan, On 03/11/2022 21:14, Ayan Kumar Halder wrote: > > On 03/11/2022 15:08, Michal Orzel wrote: >> Hi Ayan, > Hi Michal, >> >> On 31/10/2022 16:13, Ayan Kumar Halder wrote: >> The title is a bit ambiguous given that the previous patches were also defining GIC registers. >> Maybe adding "remaining" would result in a better commit title. >> >>> Refer "Arm IHI 0069H ID020922" >>> 12.5.23 ICC_SGI1R, Interrupt Controller Software Generated Interrupt >>> Group 1 Register >>> 12.5.12 ICC_HSRE, Interrupt Controller Hyp System Register Enable register >>> 12.7.10 ICH_VTR, Interrupt Controller VGIC Type Register >>> 12.7.5 ICH_HCR, Interrupt Controller Hyp Control Register >>> 12.5.20 ICC_PMR, Interrupt Controller Interrupt Priority Mask Register >>> 12.5.24 ICC_SRE, Interrupt Controller System Register Enable register >>> 12.5.7 ICC_DIR, Interrupt Controller Deactivate Interrupt Register >>> 12.5.9 ICC_EOIR1, Interrupt Controller End Of Interrupt Register 1 >>> 12.5.14 ICC_IAR1, Interrupt Controller Interrupt Acknowledge Register 1 >>> 12.5.5 ICC_BPR1, Interrupt Controller Binary Point Register 1 >>> 12.5.6 ICC_CTLR, Interrupt Controller Control Register >>> 12.5.16 ICC_IGRPEN1, Interrupt Controller Interrupt Group 1 Enable register >>> 12.7.9 ICH_VMCR, Interrupt Controller Virtual Machine Control Register >>> >> As said in the previous patches: this may be my personal opinion but sth like this would be easier to read: >> " >> Define missing assembly aliases for GIC registers on arm32, taking the ones >> defined already for arm64 as a base. Aliases are defined according to the >> GIC Architecture Specification ARM IHI 0069H. >> " >>> Signed-off-by: Ayan Kumar Halder >>> --- >>> >>> Changes from :- >>> v1 - 1. Moved coproc regs definition to asm/cpregs.h >>> >>> xen/arch/arm/include/asm/cpregs.h | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h >>> index bfabee0bc3..62b63f4cef 100644 >>> --- a/xen/arch/arm/include/asm/cpregs.h >>> +++ b/xen/arch/arm/include/asm/cpregs.h >>> @@ -415,6 +415,22 @@ >>> #define ICH_AP1R1_EL2 __AP1Rx_EL2(1) >>> #define ICH_AP1R2_EL2 __AP1Rx_EL2(2) >>> #define ICH_AP1R3_EL2 __AP1Rx_EL2(3) >>> + >>> +#define ICC_SGI1R_EL1 p15,0,c12 >>> + >>> +#define ICC_SRE_EL2 p15,4,c12,c9,5 >>> +#define ICH_VTR_EL2 p15,4,c12,c11,1 >>> +#define ICH_HCR_EL2 p15,4,c12,c11,0 >>> + >>> +#define ICC_PMR_EL1 p15,0,c4,c6,0 >>> +#define ICC_SRE_EL1 p15,0,c12,c12,5 >>> +#define ICC_DIR_EL1 p15,0,c12,c11,1 >>> +#define ICC_EOIR1_EL1 p15,0,c12,c12,1 >>> +#define ICC_IAR1_EL1 p15,0,c12,c12,0 >>> +#define ICC_BPR1_EL1 p15,0,c12,c12,3 >>> +#define ICC_CTLR_EL1 p15,0,c12,c12,4 >>> +#define ICC_IGRPEN1_EL1 p15,0,c12,c12,7 >>> +#define ICH_VMCR_EL2 p15,4,c12,c11,7 >> I did not check this in previous patches but in which order are you defining these registers? > My bad, I did not follow any particular order. >> I took a look at arm64/sysregs.h and these regs are placed in assembly aliases name order. >> So for instance ICC_PMR_EL1 would be defined before ICC_SRE_EL2, etc. > This makes sense. I will fix this in v3. >> >> Also, I cannot see some regs like MISR, EISR that are defined for arm64. Did you decide not to define them >> for arm32 because they are not used by Xen? > > Actually these registers are not being used by arm64 as well. A grep for > "ICH_MISR" or "ICH_EISR" did not return any usage of these registers > > ayankuma@xcbayankuma41x:/scratch/ayankuma/upstream_xen/xen$ grep -ri > ICH_MISR * > xen/arch/arm/include/asm/gic.h:#define GICH_MISR       (0x10) > xen/arch/arm/include/asm/gic.h:#define GICH_MISR_EOI     (1 << 0) > xen/arch/arm/include/asm/gic.h:#define GICH_MISR_U       (1 << 1) > xen/arch/arm/include/asm/gic.h:#define GICH_MISR_LRENP   (1 << 2) > xen/arch/arm/include/asm/gic.h:#define GICH_MISR_NP      (1 << 3) > xen/arch/arm/include/asm/gic.h:#define GICH_MISR_VGRP0E  (1 << 4) > xen/arch/arm/include/asm/gic.h:#define GICH_MISR_VGRP0D  (1 << 5) > xen/arch/arm/include/asm/gic.h:#define GICH_MISR_VGRP1E  (1 << 6) > xen/arch/arm/include/asm/gic.h:#define GICH_MISR_VGRP1D  (1 << 7) > xen/arch/arm/include/asm/arm64/sysregs.h:#define > ICH_MISR_EL2              S3_4_C12_C11_2 > > ayankuma@xcbayankuma41x:/scratch/ayankuma/upstream_xen/xen$ grep -ri > ICH_EISR * > xen/arch/arm/include/asm/gic.h:#define GICH_EISR0      (0x20) > xen/arch/arm/include/asm/gic.h:#define GICH_EISR1      (0x24) > xen/arch/arm/include/asm/arm64/sysregs.h:#define > ICH_EISR_EL2              S3_4_C12_C11_3 > > As I see, they seem deadcode for me. Macros are preprocessor constructs whose content is replaced whenever the name is used. I would not call this a deadcode as this is not something that can be executed. If a macro is not used, its content will not appear in the actual code. > > Do you suggest that we should remove them ? If so, I can send a patch > for this. This is a question to maintainers. Bare in mind that we really have a lot of unused macros in Xen codebase. IMO, if we decide to remove them, this should be done in a single series, so no need to add another additional patch in your series, especially if you are not modifying this code directly. > > - Ayan > >> >> ~Michal ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 04 09:46:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 09:46:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437405.691753 (Exim 4.92) (envelope-from ) id 1oqtHV-0005Rf-Gg; Fri, 04 Nov 2022 09:46:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437405.691753; Fri, 04 Nov 2022 09:46:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtHV-0005RY-Du; Fri, 04 Nov 2022 09:46:33 +0000 Received: by outflank-mailman (input) for mailman id 437405; Fri, 04 Nov 2022 09:46:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtHU-0005RS-My for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 09:46:32 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8d186938-5c25-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 10:46:31 +0100 (CET) Received: from mail-dm6nam11lp2171.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Nov 2022 05:46:14 -0400 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by CO3PR03MB6725.namprd03.prod.outlook.com (2603:10b6:303:17c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Fri, 4 Nov 2022 09:46:12 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 09:46:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d186938-5c25-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667555190; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=bglp5dgIt9/XmPJTJXoEN9/YgZ8OpFU/d7ZhbFB6QVY=; b=MnHpW4kl1GGLxNLAFGCHPhKkZ8EWB5mI3CV78A1UEwB7Z3qXmL4DmntN HT7cXUehU4CoZUOXYYsmGd+VF8wEdH0U0Cid93Z8fyZ5cbNNr3+yH21AP dczL+JVHs856MBF6rmBx34gjXMKrSkUM1585ylbU0LNAVp9lbUgoMd+Bd E=; X-IronPort-RemoteIP: 104.47.57.171 X-IronPort-MID: 83767150 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:MqbUnakF81I2xsc5fvW4ZHTo5gy/J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIYWWvQP6uNN2H8L91wYdy+80wD75bXzIM1GQZk/y1mHyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5AOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 btCKxwLckmYvsGnxeO0SvJyoscfJ+C+aevzulk4pd3YJdAPZMmaBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVM3iee0WDbWUoXiqcF9lUaCp 3na/m3/RBUbMtCexhKO8262h/+JliT+MG4XPO3jqaA12QDLroAVIEFKd1uwnd/nsXzkXY5dc GATyAMnl5FnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQK2 1mTjpXWDDpgmLSPTDSW8bL8hT+7JyU9N2IJYi4ACwwf7LHLv4Ubnh/JCNF5H8aIYsbdHDjxx 3WGqXY4jrBK1MoTjfzkpBbAni6moYXPQkgt/ALLU2m57wR/Iom4e4iv7lud5vFFRGqEcmS8U LE/s5D2xIgz4VulxERhnM1l8GmV2su4 IronPort-HdrOrdr: A9a23:IqdWYKE/A0+dFJYIpLqFXpHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5VoMkmsj6KdgLNhd4tKOTOLhILGFvAE0WKP+Vzd8mjFh5ZgPM RbAuVD4b/LfD5HZK/BiWHWferIguP3iZxA7t2urUuFODsaD52ImD0JbzpzfHcXeCB2Qb4CUL aM7MtOoDStPV4NaN6gO3UDV+/f4/XWiZPPe3c9dlEawTjLqQntxK/xEhCe0BtbeShI260e/W /MlBG8zrm/ssu81gTX2wbontprcZrau5p+7f63+4sowwbX+0SVjUNaKvi/VQUO0aGSAZAR4Z 3xSlkbToNOAjjqDxyISFPWqnXdOXAVmjPfIBaj8AXeiN28SzQgB8Vbg4VFNhPf9ko7pdl5lL lGxmSDqvNsfFr9dLSU3am2a/hGrDvCnZMZq59ks1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO 1jFtvV6vpaeU6TKymxhBgl/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+ 7ELqNrnrdTSdJ+V9M0OM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaDKDgDKFC7a gpfGkoxlLaIXieePFm9Kc7gizlUSG6QSnnzN1Y6txwpqD8LYCbQxG+dA== X-IronPort-AV: E=Sophos;i="5.96,137,1665460800"; d="scan'208,217";a="83767150" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hMJL01QZBiTxYVtyQvb22CTMzKVzv6pMUEBUbA8DUIbjZQ3h30+nK2F6xwXjccEYYvDviuNtZ6pPpMZcmcjyoTN9LcE+HzZoszpeHA42PHpIqrGaU2sIC26PyLSbIs0ZEzZz4kWw+WYu6czBrM4fc/JMOiCzg5NMBtFMeFubbLJUdxrzOZiRI35X1y505o0V6Bp+G5bAb5OCPCqqoZQ83ffOs9qDS9f7SEj190F7BFtUwOJ5MwYaZI0wNWjNkpS+oHhlapCuHVGz8FuRAzk9vrAodAxOGcIzhIn2EexU2KBF553oFf2TdKMtTEIbEZ6omp+iFfvG05OowRdCsUSsFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bglp5dgIt9/XmPJTJXoEN9/YgZ8OpFU/d7ZhbFB6QVY=; b=doc/QdJro7ai0wch4yTTKnBDEQh/F280xXE1NmS9mZp9e8PsU/4NzlO8M3F2kv5Q5viVVzYKNHOutV/QTQlBCuQoGRXA7gb5a6IGZoDeJ6BGHHwDe5fvw1ey1pRLIQpDlFYg63p53eqUXD99aiH+gPeCcXUQWgZYu7FEV+JQzgDN9bgaxD8h68KUQjFfDP+UrlOPF+5pwaCKkerk15tH7FKC1xBjEUI56b0GIDYLfTZ5rKjQUcr3mjC0MNW5EscFBCu2+HzB6vRBkiTU6qZp22Rmgh7YepNyuQ2xEdq2tquSmgm50rKR8Mt6SBf+qZcBwG6OcspW+YCwYXC0PiwA1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bglp5dgIt9/XmPJTJXoEN9/YgZ8OpFU/d7ZhbFB6QVY=; b=m3Qo0Hgz54EhwZ+1sPymzi1Z42fAtQD5zlUjBNeVuU6e7FDtBzP5JpAViAbXrrfDjdRTbIidsHNSQJN+x6Ho94yEhSq/0gZw7sheuFC784Ibyfp1Ji5K3EqfSN02+oR/OCuUvJNSJvdWeKtCs84Rbd/n6pbOj6HrqhwqYPhIx0U= From: Christian Lindig To: Edwin Torok CC: Xen-devel , Henry Wang , David Scott , Wei Liu , Anthony Perard Subject: Re: [[PATCH for-4.17 v1]] tools/ocaml/xenstored/store.ml: fix build error Thread-Topic: [[PATCH for-4.17 v1]] tools/ocaml/xenstored/store.ml: fix build error Thread-Index: AQHY77QswELu31uiU0C5DgxD195B0K4uhSKA Date: Fri, 4 Nov 2022 09:46:12 +0000 Message-ID: <891A255A-7083-4495-A9A5-596BBE8842E7@citrix.com> References: <5a453393dad1de8286fe5db16504d3db2906eef8.1667500970.git.edvin.torok@citrix.com> In-Reply-To: <5a453393dad1de8286fe5db16504d3db2906eef8.1667500970.git.edvin.torok@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|CO3PR03MB6725:EE_ x-ms-office365-filtering-correlation-id: ec88c4ee-27f2-4ad9-30ae-08dabe4968ad x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8VOoU5J24ptqM2gOyyW6mfeaadAaFdzdXaYelam0KxAKjbYXNNaMa0soQitEhI6Ic7YNRwUA3JPm57kedQWdQBZuwP82bSZCIx/Ff1K/U/pByr+DJ6kNjtdM2Iwgg9pe9Q4tN/QCkbcCl4GCfvgBYs65LvF04OvoTtron1WMxvw6ie3iPrP/5Ea/NC2n0kBa0ApWe+qMdZW3HYmpFZ2/CoYgY+kbozCcDh33BGm/4CKfxYnzYa8ChNvEcxFs1vgNNX/+HBW75Xl42u/eDzx9i3mK8yT970jR9A8gp5I64i22L17B54lDQiDX2RwW8HeMsmX5yXnkL0tUKCFI/eTQhKijHh3rMhY67QUF2iked/fA6XCQZVDC8fr+kV9dymi0ztTosz8q4XREcJ1ixAP/j/po2PlkdtkgqrPkPOWX78AfcFqTWF0krz9fI1zOFPKolVrHmYq3D+vPXgKrigiDsjkHCKBBzy4FNXHmfhGh+2hM2YrsHughT680qxWTiyugkLvSdPYV5ijRRv81sbekUUQTi8C5sZGSd3EI1mibRbbW3YZUeZqtyIDBurgsISXOWFXoIt4bg71BmX1GRaFPBwT4LciIFpkI/1iUz3ICyNPSRo3Gtnt43ezW1GuJrkiVbDwRGIhHOYAF2lSLjyFDf9XWDEI57/Y6kaXS8g0MKskFZKIcRTVXSy54n9yjlyrC3cxZvh/1rAl62tjbktNMuIl3RxSmligpUGwEzF7UnzzqUB4MSihOdjRcL19M5+Op2g0/5QBeMDOELk3IKrPvDt7HFi/bazGmEx8yro/VUqc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(376002)(396003)(136003)(346002)(451199015)(6862004)(41300700001)(54906003)(316002)(122000001)(44832011)(6636002)(2906002)(8936002)(66556008)(71200400001)(66446008)(64756008)(37006003)(4326008)(5660300002)(66476007)(4744005)(38070700005)(76116006)(53546011)(33656002)(478600001)(6486002)(91956017)(82960400001)(86362001)(107886003)(6512007)(83380400001)(6506007)(2616005)(8676002)(26005)(38100700002)(186003)(66946007)(66574015)(36756003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UlJVdCtjNnNURDFueDhsL0xmdkZxTXRMaTc0U1A0clUrTmRiVE16RFkwcytl?= =?utf-8?B?QWhVK0dySXdaU1o1OWlKTjRwL0RIcjVDTFJFUkhFaUtVaFB4dFk1NzYyU3JZ?= =?utf-8?B?dlhweW1WbWdvQm1FNm5xVGduOExwT3NSV21HMGFHWkpwK0RONkUrdk1GdUlW?= =?utf-8?B?NXE5WVB2SmxoYUxhREQ0ZGJBaStDN0Q2RjVER2dEbkdVdHZtOGdLQWFXdU1V?= =?utf-8?B?aUpXVWpRZWtROGo0OENrRFBSVzhCSFluaXIyZWJtU2ZEc0h2dUpJdEJ6Z2xy?= =?utf-8?B?YVV3cDVOWUYwa25oT2I4VEVLSXlQZXN5QmorcVpnZlVjU0szc08xYXBQeUVO?= =?utf-8?B?K04zd0JiK2FHUUJNdzA2TmluNVZxU1g4VGV3ZnFQNHcvbE5DK3RNM0hBWVlI?= =?utf-8?B?T2ttblcybEhNSHFBdjN2WkNPSjBiQWIrZGl2cm9iYnhqelkyK1hxWlhwcmFu?= =?utf-8?B?QTFnelI0ZVpuaEc0NWhiZy9iS3dra3J4Z25KTTRtUlJvVWlEaC9FejMyMmR2?= =?utf-8?B?OFN5bU1SU25tdzdUd01KZnFSL1Z0NGtacHJGdVhERzZ3WTVtWTlvYWxwaUFS?= =?utf-8?B?ckpOVXhQNU4vVlBld0EyNUVXMHBIVmE0UTFUK09iMk1RTGdnTFVQODJrREpN?= =?utf-8?B?TU84cmdDQ3NoRXE0YUcyN1Rsb2lUb2paUGtlb0FzTUlCUFJGNUgvNlo0VSt4?= =?utf-8?B?L2FrMnFPenBiZHRFVzcxVkN0UG5xcHA3cW01cnJub0c5QmF3djdSbENnWnFK?= =?utf-8?B?Y2ZjeUliNjZldUtLQ1YzbWhMWkdPZ3F5T3Nodi9XbzFxN2ZKUHY1TEdzWGI0?= =?utf-8?B?djVVOGhHcGcybXJoblpqTEdoZGtORVhqMDJiblFtYndpT2VBV094b21iSHpW?= =?utf-8?B?ZWpTaU1rekJITDgzKzhRYW9laTJ6Q1dvSmFMRlBZdCtMc2ZmeU9rMlpsSjhT?= =?utf-8?B?VFVhRVFwRExoT1h0ZEJBd2dtd3lKM3VFcmgxSzF2MUlQdTNjbEs2KzBET1Fi?= =?utf-8?B?aGZRd3NucnR3bTI1K3duNEJONUJ6STRXVEQ4TEkrdUZEN1M3ZzBGT0RBdGtG?= =?utf-8?B?VFNUTmZvbEo5WEhHem1wcnFqM0RBbjZCNGUyK08rK0lHdlVFalZrdGptcnlp?= =?utf-8?B?Z003YjJsSjN0RlIzbEdObFpiVFd1THJ2K3dKSE1BZ3JRVlB1S1lsTG05cGg1?= =?utf-8?B?cGRjRDNwR2hpWTJRWjVPdnowbVJPZFFQZDREV2k4VTRYcTBrQ3R2VFdEOUxT?= =?utf-8?B?bytMNlRmMUtwS2VXYTJLaGQ1MWovU0kxRFhMOUtHOHpZQktZbnI1aUJRUUpl?= =?utf-8?B?VFVoaUtKbnllS1FIbjdNa2daOTZ2OEJ6Yy8vT3FFR0dvOWV5OHJhOG1DRzZB?= =?utf-8?B?NmQrWGlUSnZCYmExN2MzTEZaTzRoblJLaVRTVnFieWFQNEpiNDV3UUUyWW5I?= =?utf-8?B?NjY5NEgwajUyV0J1N1Z1eHJLQm4wUVFCd3FNeVNCNFU0YVFKU1hyZmZhelJi?= =?utf-8?B?WHRnNXlVdnY1bU0yWHhKeEZqcm54NFN6RWFuODlSakJsRjJ4TkYwaXlGTXhJ?= =?utf-8?B?SXM3YW4rL0Y3eW55WHRsL202ZHJoWGtvWVl1UDJpZENBZkxTbERwS1YwRk1B?= =?utf-8?B?bUVTQnFtREVaWnNSZ1R3SEJzRGNRZVlzMXlPeEZXcGR4dERhYTJSYWlsd3I2?= =?utf-8?B?M2hGZXZrai85blE5b3ZVZGVjTmpzTnFvUms5Y0F6OG9RR0k0VS9Cd2V0d0Nx?= =?utf-8?B?MjNrMVVhS3gyeHFKa2FienpLeEd5Rm9scGU0aHJvZy9WOE56UUJZZThQRk04?= =?utf-8?B?TDlHcDNlWWprekJEU01nQW54emMySk5PbW5FWnc3ekEzNGhINTJhWVl1SmhB?= =?utf-8?B?YjlRUU1KM3VxUDJ3TWVOajd1MlZQYU4xSGRLaWlYNEtRSzdhM2UrRjN2aFRT?= =?utf-8?B?SE8zMlVQSCtUNERUL1E5SlpUSlZWc01rdmJtbTB5SmhXMmFuZEt0OS9rVjli?= =?utf-8?B?SEo5TlovRm52eXllcHlMNi9yTXppZ2FPT1dCc1UyWlhzV1loQ2QrYm9DRW9E?= =?utf-8?B?TUNJUnJkc2VNbENiY2k5dFNvZEtiV2x5dlkzb3NSZmp2VGFySEE1ZUtvRmFy?= =?utf-8?B?M2NVQVE0ekladG9sdDdIZWkxSjRSZ0t4YlZDUGZ5SjNYcmJEZGhaRVdvUDZi?= =?utf-8?Q?fw6OV94cLIowoRQWSkC0w/E=3D?= Content-Type: multipart/alternative; boundary="_000_891A255A70834495A9A5596BBE8842E7citrixcom_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec88c4ee-27f2-4ad9-30ae-08dabe4968ad X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2022 09:46:12.4104 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gL/8bEig+ps+MTwjk4IjnZD5tEiu7bwrMyo/txVXK45wOaxykO7Fczb6IaZnmvIF8xUElP/3LlvrRyuEMj/H8Lww33P6OMwRzoF/kd1lOmY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6725 --_000_891A255A70834495A9A5596BBE8842E7citrixcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DQoNCk9uIDMgTm92IDIwMjIsIGF0IDE4OjQyLCBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jva0Bj aXRyaXguY29tPG1haWx0bzplZHZpbi50b3Jva0BjaXRyaXguY29tPj4gd3JvdGU6DQoNCkZpeGVz OiBkYjQ3MTQwOGVkZDQ2ICJ0b29scy9vY2FtbC94ZW5zdG9yZWQ6IEZpeCBxdW90YSBieXBhc3Mg b24gZG9tYWluIHNodXRkb3duIg0KDQpTaWduZWQtb2ZmLWJ5OiBFZHdpbiBUw7Zyw7ZrIDxlZHZp bi50b3Jva0BjaXRyaXguY29tPG1haWx0bzplZHZpbi50b3Jva0BjaXRyaXguY29tPj4NCi0tLQ0K dG9vbHMvb2NhbWwveGVuc3RvcmVkL3N0b3JlLm1sIHwgMiArLQ0KMSBmaWxlIGNoYW5nZWQsIDEg aW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQoNCkFja2VkLWJ5OiBDaHJpc3RpYW4gTGluZGln IDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb208bWFpbHRvOmNocmlzdGlhbi5saW5kaWdAY2l0 cml4LmNvbT4+DQoNCg== --_000_891A255A70834495A9A5596BBE8842E7citrixcom_ Content-Type: text/html; charset="utf-8" Content-ID: <20C5CCE45D0A6245B772F85258712581@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJ3b3JkLXdy YXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZTsgbGluZS1icmVhazogYWZ0 ZXItd2hpdGUtc3BhY2U7IiBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NCjxkaXY+PGJyIGNsYXNz PSIiPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2xhc3M9IiI+DQo8ZGl2IGNsYXNzPSIiPk9u IDMgTm92IDIwMjIsIGF0IDE4OjQyLCBFZHdpbiBUw7Zyw7ZrICZsdDs8YSBocmVmPSJtYWlsdG86 ZWR2aW4udG9yb2tAY2l0cml4LmNvbSIgY2xhc3M9IiI+ZWR2aW4udG9yb2tAY2l0cml4LmNvbTwv YT4mZ3Q7IHdyb3RlOjwvZGl2Pg0KPGJyIGNsYXNzPSJBcHBsZS1pbnRlcmNoYW5nZS1uZXdsaW5l Ij4NCjxkaXYgY2xhc3M9IiI+PHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7 IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6 IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0 dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7 IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6 IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5v bmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPkZp eGVzOg0KIGRiNDcxNDA4ZWRkNDYgJnF1b3Q7dG9vbHMvb2NhbWwveGVuc3RvcmVkOiBGaXggcXVv dGEgYnlwYXNzIG9uIGRvbWFpbiBzaHV0ZG93biZxdW90Ozwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0 LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNp emU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsg Zm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3Rh cnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTog bm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4 OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxiciBzdHlsZT0iY2FyZXQtY29s b3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTog MTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250 LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsg dGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3Jt YWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRl eHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9y OiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDEx cHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13 ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRl eHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFs OyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0 LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFu dDsiIGNsYXNzPSIiPlNpZ25lZC1vZmYtYnk6DQogRWR3aW4gVMO2csO2ayAmbHQ7PC9zcGFuPjxh IGhyZWY9Im1haWx0bzplZHZpbi50b3Jva0BjaXRyaXguY29tIiBzdHlsZT0iZm9udC1mYW1pbHk6 IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250 LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzog bm9ybWFsOyBvcnBoYW5zOiBhdXRvOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBw eDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdpZG93czogYXV0 bzsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zaXplLWFkanVzdDogYXV0bzsgLXdl YmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyIgY2xhc3M9IiI+ZWR2aW4udG9yb2tAY2l0cml4 LmNvbTwvYT48c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1p bHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBm b250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2lu Zzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFu c2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Vi a2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6 IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9IiI+Jmd0Ozwvc3Bhbj48 YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1S ZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50 LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsg dGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25l OyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0 cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFu IHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVn dWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1j YXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRl eHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsg d2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJv a2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxh eTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj4tLS08L3NwYW4+PGJyIHN0eWxlPSJjYXJl dC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1z aXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7 IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0 YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6 IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBw eDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQt Y29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6 ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBm b250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFy dDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBu b3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7 IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1w b3J0YW50OyIgY2xhc3M9IiI+dG9vbHMvb2NhbWwveGVuc3RvcmVkL3N0b3JlLm1sDQogfCAyICst PC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6 IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250 LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzog bm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zv cm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0 LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIi Pg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBN ZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12 YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5v cm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3Jt OiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10 ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25l OyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPjENCiBmaWxlIGNoYW5nZWQs IDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pPC9zcGFuPjwvZGl2Pg0KPC9ibG9ja3F1b3Rl Pg0KPC9kaXY+DQo8YnIgY2xhc3M9IiI+DQo8ZGl2IGNsYXNzPSIiPg0KPGRpdiBzdHlsZT0ibWFy Z2luOiAwcHg7IGZvbnQtc3RyZXRjaDogbm9ybWFsOyBmb250LXNpemU6IDExcHg7IGxpbmUtaGVp Z2h0OiBub3JtYWw7IGZvbnQtZmFtaWx5OiBNZW5sbzsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9 ImZvbnQtdmFyaWFudC1saWdhdHVyZXM6IG5vLWNvbW1vbi1saWdhdHVyZXMiIGNsYXNzPSIiPkFj a2VkLWJ5OiBDaHJpc3RpYW4gTGluZGlnICZsdDs8YSBocmVmPSJtYWlsdG86Y2hyaXN0aWFuLmxp bmRpZ0BjaXRyaXguY29tIiBjbGFzcz0iIj5jaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb208L2E+ Jmd0Ozwvc3Bhbj48L2Rpdj4NCjwvZGl2Pg0KPGRpdiBjbGFzcz0iIj48c3BhbiBzdHlsZT0iZm9u dC12YXJpYW50LWxpZ2F0dXJlczogbm8tY29tbW9uLWxpZ2F0dXJlcyIgY2xhc3M9IiI+PGJyIGNs YXNzPSIiPg0KPC9zcGFuPjwvZGl2Pg0KPC9ib2R5Pg0KPC9odG1sPg0K --_000_891A255A70834495A9A5596BBE8842E7citrixcom_-- From xen-devel-bounces@lists.xenproject.org Fri Nov 04 09:55:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 09:55:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437411.691764 (Exim 4.92) (envelope-from ) id 1oqtQF-0007aL-Ew; Fri, 04 Nov 2022 09:55:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437411.691764; Fri, 04 Nov 2022 09:55:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtQF-0007aE-By; Fri, 04 Nov 2022 09:55:35 +0000 Received: by outflank-mailman (input) for mailman id 437411; Fri, 04 Nov 2022 09:55:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtQE-0007Zp-2X for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 09:55:34 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2083.outbound.protection.outlook.com [40.107.220.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d1a41a31-5c26-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 10:55:32 +0100 (CET) Received: from MW4PR04CA0104.namprd04.prod.outlook.com (2603:10b6:303:83::19) by BL1PR12MB5093.namprd12.prod.outlook.com (2603:10b6:208:309::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 09:55:29 +0000 Received: from CO1NAM11FT030.eop-nam11.prod.protection.outlook.com (2603:10b6:303:83:cafe::e8) by MW4PR04CA0104.outlook.office365.com (2603:10b6:303:83::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 09:55:28 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT030.mail.protection.outlook.com (10.13.174.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 09:55:28 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 4 Nov 2022 04:55:27 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 4 Nov 2022 04:55:27 -0500 Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 4 Nov 2022 04:55:25 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1a41a31-5c26-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GsE0fhk5LJUQ68ziXXwVXbnnXNDOEaDmBaZ/ZtpLGaLHZ1Wbx09t2w7l9vRo5Na76dxewilm/4qkNvkpBIT/DDYvreasz8IuHQhDnZOi+5CSdo9xBviiYRWwQIZ+A/Jl9q6vwRrAmH093jSvU8rFni850SDmvoa4v9keIegC0Lnl6QTJl9mcVseg7WgC0qjMOkNTd1B2mgrYm5jc1dFk73h+rvTkKqeD12Sl61UCpqAa4tBOUn7NLj5eJtszZgSw9bHk8s0UZSzxDi/YiErVjQmC3G+/X2eBx4S+8kP+FmCKK8FyC7pXHFiZsCj3MnRBZnVtfLQ3+rInU3rilTB4Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QMiYgNQoHDDCi76G1G6p2oh/+q8mXH1uYqpKiFOWwqU=; b=TBZJTYRiax+hE3C6IGCcMlJKTddJ9dY9yE62b6rePWMX6JqG1CURz+XEN0aMfGNEwRX230Nmj901FrHJi6wRRl08UQN0yM3tCGHN+v9US94IVbxw2F//wqd8V9UmvIzQW9Ua+qX70+oKg0t6rm7Ky64MA2bHjJRbh6MlVKYrQmxqBEWQUtPSUdR6xabMuxJA7to1ieAq8m5ofONfRJez6ooReL82V/OfZ4owyU5BOMpL4lSFIJSr3LNSDwADXFjWou1pslFPf0guZEzguXXHrSMwXYXv4WW2kI9jB2cI2WI9y4KE++4agBf5oAwdv5NXywQxHY1Ds5xrlge3Kz3g7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QMiYgNQoHDDCi76G1G6p2oh/+q8mXH1uYqpKiFOWwqU=; b=Zpv65bGof7MChKfs1MaMiPCIBbldGqqQBbJ8E5swdDN8vta63EjuPM1h094nx0X3LnDCtYNeh9dbPrqSod++pd938PTDFAw9gY4ylfbnFberL6aV6ipsH3qCDoyAI4IfyRpTs3C9P4XhE3WM+r9Ac0kpDbgUaCKba5RK2KSJyFg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <45df5e11-9697-96ca-3c89-39bdbba48637@amd.com> Date: Fri, 4 Nov 2022 10:55:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 12/12] xen/Arm: GICv3: Enable GICv3 for AArch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-13-ayankuma@amd.com> From: Michal Orzel In-Reply-To: <20221031151326.22634-13-ayankuma@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT030:EE_|BL1PR12MB5093:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a4038c3-d1a0-451e-a838-08dabe4ab3f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WhTAtl+xUHMlFJgIZEAgt7tWT9rUmTKFx9bfrO6MK3Jt1ix1h1pbsSUL35n3gGDXUfYYeFplhrIfS5j6QXf+FM0ImYlZOCyIjBOdtb5L2L8QhESeA8wpL9B6o2ciczjLSl9f9vGFxCoqPAtL+2DXxMz8HZP2J389zScxME5HblcIurXWYAsCOE98cX+tjMoXuPaYbvcFA7SxR1yIQRwnZb0kEY4V1KMU/OP3+hf7pUhEmupY01N43skbIuOw3dbddOdYAvc/DZCmwpheoPFZ8yIG0FZ1SSpUfCr4gpnVzGPo92d1kQfhm6H4Vn5lMmTo/ivJ0ZSi+YGU8PUFljnU/SEkEj7gkXAa2ApZgbA3wKq3VO+XB2WtHsu1/dAFp+8jQim7RPeO3VGOKHAw+X3cZFOT12OzH9Q+gPzkGUZS4Ks7ZmP2pVRS824+gnJAr/2Eh4AiM0LkFFsQEfAVQP0Z8NjrAtu8dv3HYHvYrJWHVq2TWmdUxbhdT+2gKHv3NVI6Ji1S2n59F3vE2MY8SYjOzzZOsnaIiu+Xu31+c0/+8646sNnSo7Hij6Omj1cg5ansTWJUzu/88sxLl+mDBfyblC1Ds1X9N0ckVn1GhoE08oXeci6Fr1mmTaBN+3EFVwk3dMe3n3QjOEdHh7CRsW6MLBaN4/aRI+VZs0/zWQQeKAUJO52XB9W2ThnEIaeuMGNcoly0TJUgV3G2Yd7D7eM6DQYut3UFtHUIHC3NxZolnG7YNxijyD5axu7uCTFM/pZu+sBmRSrTOJeHvxjBcsDJyQ5ee7fuKxJ46BSelWyldvuUC+KE0nDWkL9YDSoTuXIYZZ1/hInf1mccJfKP172o7w== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199015)(46966006)(40470700004)(36840700001)(2906002)(478600001)(70586007)(70206006)(426003)(53546011)(83380400001)(47076005)(4326008)(8676002)(36756003)(40480700001)(36860700001)(316002)(54906003)(86362001)(31696002)(16576012)(110136005)(82310400005)(40460700003)(82740400003)(356005)(81166007)(26005)(41300700001)(2616005)(8936002)(31686004)(5660300002)(186003)(336012)(44832011)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 09:55:28.1124 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a4038c3-d1a0-451e-a838-08dabe4ab3f9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT030.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5093 Hi Ayan, On 31/10/2022 16:13, Ayan Kumar Halder wrote: > > > Refer ARM DDI 0487G.b ID072021, > D13.2.86 - > ID_PFR1_EL1, AArch32 Processor Feature Register 1 > > GIC, bits[31:28] == 0b0001 for GIC3.0 on Aarch32 > > One can now enable GICv3 on AArch32 systems. However, ITS is not supported. > The reason being currently we are trying to validate GICv3 on an AArch32_v8R > system. Refer ARM DDI 0568A.c ID110520, B1.3.1, > "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE must not > implement LPI support." > > Updated SUPPORT.md. > > Signed-off-by: Ayan Kumar Halder > --- > > Changed from :- > v1 - 1. Remove "ARM_64 || ARM_32" as it is always true. > 2. Updated SUPPORT.md. > > SUPPORT.md | 6 ++++++ > xen/arch/arm/Kconfig | 4 ++-- > xen/arch/arm/include/asm/cpufeature.h | 1 + > 3 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/SUPPORT.md b/SUPPORT.md > index cf2ddfacaf..0137855c66 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -82,6 +82,12 @@ Extension to the GICv3 interrupt controller to support MSI. > > Status: Experimental > > +### ARM/GICv3 + AArch32 ARM v8 > + > +GICv3 is supported on AArch32 ARMv8 (besides AArch64) Looking at the CONFIG_GICV3, it can be enabled on arm32, which at the moment supports only ARMv7 (see __lookup_processor_type -> proc-v7.S). What will prevent the user from enabling GICv3 for ARMv7 based CPU? > + > + Status: Supported, not security supported > + > ## Guest Type > > ### x86/PV > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 1fe5faf847..7c3c6eb3bd 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -41,7 +41,7 @@ config ARM_EFI > > config GICV3 > bool "GICv3 driver" > - depends on ARM_64 && !NEW_VGIC > + depends on !NEW_VGIC > default y > ---help--- > > @@ -50,7 +50,7 @@ config GICV3 > > config HAS_ITS > bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED > - depends on GICV3 && !NEW_VGIC > + depends on GICV3 && !NEW_VGIC && !ARM_32 > > config HVM > def_bool y > diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h > index c86a2e7f29..c62cf6293f 100644 > --- a/xen/arch/arm/include/asm/cpufeature.h > +++ b/xen/arch/arm/include/asm/cpufeature.h > @@ -33,6 +33,7 @@ > #define cpu_has_aarch32 (cpu_has_arm || cpu_has_thumb) > > #ifdef CONFIG_ARM_32 > +#define cpu_has_gicv3 (boot_cpu_feature32(gic) >= 1) What is the purpose of defining this macro if it is not used? > #define cpu_has_gentimer (boot_cpu_feature32(gentimer) == 1) > /* > * On Armv7, the value 0 is used to indicate that PMUv2 is not > -- > 2.17.1 > > ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:04:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:04:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437416.691775 (Exim 4.92) (envelope-from ) id 1oqtZ8-0000hi-AD; Fri, 04 Nov 2022 10:04:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437416.691775; Fri, 04 Nov 2022 10:04:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtZ8-0000hb-7J; Fri, 04 Nov 2022 10:04:46 +0000 Received: by outflank-mailman (input) for mailman id 437416; Fri, 04 Nov 2022 10:04:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtZ6-0000hV-O4 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:04:44 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2071.outbound.protection.outlook.com [40.107.92.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1989be0c-5c28-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 11:04:42 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by BL1PR12MB5779.namprd12.prod.outlook.com (2603:10b6:208:392::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 10:04:37 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 10:04:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1989be0c-5c28-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZpjFlv2QeQwOzXckYvWOLq9NMeMjwJzNW85Ots1EuDnxWTlHqAh1IonJE6z4FSga7C5l4MMqVobOAWAkIalMUshZnunLK5Um0/5FTwK1tBr/KdcYEuLJJcR52YHwPrB4NKTpZf4x7DWhkfdeCkLLqM3VRjQLFYo8alMEgnsplZ/HU2LTiZyL3s+ChqRYwg6chIpgvls607b88YSDUJ7mFflUXxhop5fe60PW5PiHdXXV4khO2YE1x3zBbgvz4WClavEUKopBUXZIVLuJxF2G6pythrkLvevB70z2TSrRA5Bu9nT2EmMjst6QxIWtFz5i2tRIt8Am+1dNLDJNZ9LNXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lokOpf9BQHJ/GFLVahv94vXVMyRytFigJ8lzl95c82o=; b=lxTv3a2L/9HCGV2znR+JTuLTjrM8Falg3xJ4VeTDoqQW3mI7yUPlPbxW15S6mJ2s5ANUGUTBCPHoqGx7uKjTj1aApiCWihW7POBrRBBgL8CgZweqb3MctRgmyWCUIrQBW23Vn9QdF7tYFz2XPxSWNWd4J9piCNuTdsZfq17wjdXav0AjgVVGWvEPxoiG8eqYZ4UiAlFb5rBEZcwZ5iZprKZOHHuqdsBEXZqqKENU5ztMn0DPrYo67qRZYWi2XAXBIOPQYdnqrp6KIkb99gX+2ZvCEaWxxlDmJTH+dLLCqvPTG0jywJ/hdD20BxbzI0LcXFLlyi3z39Ml/vKRlxIiJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lokOpf9BQHJ/GFLVahv94vXVMyRytFigJ8lzl95c82o=; b=IocHRY6D4O8fxX7NV+MzU1W5wDwznP0bcZvWhNJwOfjMqjsL0nyJ9ektSHvB+9fXlBa9RCK58L2AMxKYRA/S66iT29bek2vNeZMWq/JtVvmeo5DTMi/VAEOg4B38LJ/YNlvLqcLKbQi6LkfAoY1mwDRSDsSa9kM0J5CnCC7IfCU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <825bf5e3-1d74-3fc1-370d-71a09d0e0ccc@amd.com> Date: Fri, 4 Nov 2022 10:04:28 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 09/12] xen/Arm: GICv3: Define GIC registers for AArch32 To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-10-ayankuma@amd.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0419.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::23) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|BL1PR12MB5779:EE_ X-MS-Office365-Filtering-Correlation-Id: e7b7385e-9c35-4eb7-9dfd-08dabe4bfb07 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JSY4xpCe/B7AQb6MQJVuTBtDLmy09OlvJSxgq4gtQImDZatPV8R7P0jKOoql1hf/hWuj/GtLQAFqISUeeStJLuV6P29hY0GOutBKvLxzsKmQEl1FNNVLL2Tymzl95i8GjBPegJ7+X9SY3WkZX4vjeWdBWcPF7+AkhEbtu72MT0k5nqmPFXKetprDUqEWfJHpIaP4g1iqbb9JzAfEVu2z7JpSSqCg2xeVaS6dwahMe3vfBIqypWT4pXP0A6wmji2QlpO234HrhHP1iG9HIQRnYxL1ZtDAM2Z+IONNOKyeETdpK9jn1mW/xhSiAg9kYQ0ZmNgCn/xwyKrsRiKqSmTcb8quj1mx2H487UCCKdwfXDfvIEBntbBM6ELUezu8CuCTDUHXmHgaefnmmizI0CiE0upcAaEJGZA9Uhk0WAWHQXRr62Rvl8axfTLmA98NYrDVVKuP8/USRb4fkJtFr0m5rjaZC9ANSkAdvUVRXj7eKDnJg8xaPWVLILVgYYk8s2IUAurEuruf5uMVdyJv3VXpViji/Xirn3/ipMR//cH5GiAFM75WbkH1508WBpxfeEOdIZylit9aguRnZu/eiaTVT2yIQ+hdS3D3qzB0xcIl3fJcJbj9bultzEv1yhyEzGS16+uPuH9MhU76hG9vLGud9bY/oD11L9+3t35MhHIh+II5dhWpPY5Wfl87dkVj3jFqrgoFQUcoUDDAx1HUbf1jFwl7vTVbRKbjdkPG4HEUWEsJqx1ZymuJw3DEYIApTminqz+/OAak78QZK6r7ftOosnMkaE1usMxWBTJZNFLYegM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(366004)(396003)(136003)(451199015)(83380400001)(31686004)(186003)(5660300002)(2616005)(41300700001)(31696002)(8936002)(2906002)(66556008)(6512007)(26005)(66476007)(53546011)(38100700002)(6506007)(6486002)(36756003)(316002)(6666004)(8676002)(4326008)(66946007)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHRxd0NWVzl6N3FscVRUUld0SlpZRVpRRW95WHRWRTRmWWhZdjd0WE80OHdP?= =?utf-8?B?enFiVHJDTjlvSUJHQVJhQytROUNrT3ZNWkt2NnVJWVhPdTMxUm5NaGpzZHo4?= =?utf-8?B?cVZiYXhzeTBvSmFMcElGN3JURTRiczFrY0VVNVEwNllVSTB1czR5U3c3RGlq?= =?utf-8?B?b1dub3BoS3MweVNGZnhVTTkzWjQwNDZOU01ZM2g3OTZsUlhkY0FkNFk2Y0s0?= =?utf-8?B?cG5jdi9ieFpNajB6MlZhRHBnRkp6eW9JVnBuK2ZNM1NWTFlaUGs4WkM0VkR6?= =?utf-8?B?U0ZqWjBjS1BWZE1aSzFveUc0WTJNWFEzR3RPMzJ4SzBOOUFIMGd1MDRSRHhT?= =?utf-8?B?RExIamRvY2lKV3B3RktyaGtJcVZwZWxFNVQwUmlXVmRkTklWV0JVTHAyUE9p?= =?utf-8?B?bVcxenE4RlRvb05GQUVuREJDUk9YMVU4dTJxc0NYcEtyVVFROUtnanJhdG1E?= =?utf-8?B?SUN3VXVlUTh3cktKYlhveFJOdE5hN0R1Qk5iVjNUeEk2S1FjZk9STjVmbXov?= =?utf-8?B?MW05cXRsNDhOSDd6ZFkxbTZ6R0VlbjVybHdnNm9WQU5hQlFydDJWOWwzcGFu?= =?utf-8?B?Z0prRy9tVGh3Q1duODFiT3MxSWhnZjQ3SW4vdHpNU2tXdXpZWmJkOGRoTHNW?= =?utf-8?B?VWJ1c2Zrc01QS3FIRks1WDY1VWtkS0VuTXA5T3pPZ3I1TnV0bmQvMnZaNkcr?= =?utf-8?B?YWZFeDgzZGoweGR0REhHSkxMMTdsMGlhN2hhRW9uZUsvUWZVcXNrMVFiV29q?= =?utf-8?B?VXpLc2ZMa0FGc0NkOVNwVVZtRVdhL3JNdHZzaEw1RzN2NjcyT0x5aVZtZlQy?= =?utf-8?B?YktSTXdXazZIakJrOExKeHZSaWo0T3p6b1lBakM2TDJWTmlRMU5YdTJFQVZU?= =?utf-8?B?cnlSRTg5N2I1TWtHaVd5TGNxR0loZ3RLbVI2TWRTUG9ORWxvMmNMSDFUMGtm?= =?utf-8?B?SGc3WWFLdSsxRFN0SWJIQVE3cThFQXl6aVczU3FrSUsvaTc3WHdRUmgwNDdV?= =?utf-8?B?eFVWeTRhRzlUWFRYNENVUGc1MUNrUm0wVVN1bHFvVE1NMHVVbWc1djVSQkxa?= =?utf-8?B?UnJYMFVJV0hyREozK0picnZ6dmQrelhYWEhsUDJJRkVSS2Z1UHhoMXBpaU4z?= =?utf-8?B?RHdLcDF3WkJ6blE2R2xyRnZacEVvLzRKaGh6VG5RckcyblB5dmZFeTlJWTZM?= =?utf-8?B?RGZvdm5sSFZGMnZuZW5YKzc2WDllUFBXMWFGeGY5cUJ4dFR2V3JpVUtQdDZO?= =?utf-8?B?czlvTStwWStuZitGNSt1aHdrNDlaT0hkcWlqUUJTWW1kU3VuNlJUUE5Lb2hj?= =?utf-8?B?bDNrQ3VWMEhtV0c5NUtGVE53cFZleXlkNHhhdzc4OFp0WlFlSHpuTi8rRVMw?= =?utf-8?B?UHNIaGduWnlHMmdDQlpxUG9QcGt0NzEvK2FaZ2tpcjBqbTZiTmtpS0kvdkEr?= =?utf-8?B?T2RFSkp1bXdXamlxRjlUYmZvT3oyTUljY3dIdFhtNkhkbHdoLzFyZzZSVU11?= =?utf-8?B?Q3RmT21CNHlRSm5sbkNRcUExbTA1eVB3MzV6NGpaSTI3RVh2ZW50OWV3ci9i?= =?utf-8?B?RnZndTdtVTVueXFRZnBzeUVyamtGTWdCc2FRUjlnTEQ3aEVFUHJ0ajZDcmFs?= =?utf-8?B?SWIrRE5LQm5NbnpIS1pRRVVTcnJRdTF4VmtTU1loUFRueklSUVpiR0gvV2Rr?= =?utf-8?B?dGV3eUg0Rkw0UXpFN09nTkZFTjNqNkxKMkErUksvTkxmbzFhUUlKeXk5MUh0?= =?utf-8?B?VHlxb0xYWk0ydjdrVGxDUXJZQUx3YldaOWxQVGx6R1UxZDZ0Nk9jMURHTDNU?= =?utf-8?B?U1l3QjE0NllDRElxSy9CR2kxcXBPV1RxZUJXYnlTWDhaTDM0a2NDT1Q2TFlB?= =?utf-8?B?NDRVUHVCWjUwcG0rQy9iZzdZZkN2QUpyR1R2bTlZWTBDR01WWUhERWlsWDhH?= =?utf-8?B?TkxrYTR5RkkwOFFmN0lIQmZyd0tyTFZ1RzFUMVFvaEFZeG9VUEZ4Z2c2S1VX?= =?utf-8?B?MUYvNGdLZWw1bEJ0UTRGcHpVYWZHWFdiQkdKMnowMWs5amcwQkU4bDVnYk9G?= =?utf-8?B?bHhMd2ZmTGd4SWhNR1FGLzRveHF1Y1VmQjF1UzIxeXJzVmgvUXg4TS9kMTVu?= =?utf-8?Q?k/GNs7CMNixeIvEq/6YidbeNk?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7b7385e-9c35-4eb7-9dfd-08dabe4bfb07 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:04:37.1938 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1iY4t2Uz8ub2pLtVlwuPVdspVT9XBR8sqiFwkMQE6qXRvtObEevUgQWwszgSySceM2GXOxlrFTHDUY9AmtVQkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5779 On 04/11/2022 09:27, Michal Orzel wrote: > Hi Ayan, Hi Michal, > > On 03/11/2022 21:14, Ayan Kumar Halder wrote: >> On 03/11/2022 15:08, Michal Orzel wrote: >>> Hi Ayan, >> Hi Michal, >>> On 31/10/2022 16:13, Ayan Kumar Halder wrote: >>> The title is a bit ambiguous given that the previous patches were also defining GIC registers. >>> Maybe adding "remaining" would result in a better commit title. >>> >>>> Refer "Arm IHI 0069H ID020922" >>>> 12.5.23 ICC_SGI1R, Interrupt Controller Software Generated Interrupt >>>> Group 1 Register >>>> 12.5.12 ICC_HSRE, Interrupt Controller Hyp System Register Enable register >>>> 12.7.10 ICH_VTR, Interrupt Controller VGIC Type Register >>>> 12.7.5 ICH_HCR, Interrupt Controller Hyp Control Register >>>> 12.5.20 ICC_PMR, Interrupt Controller Interrupt Priority Mask Register >>>> 12.5.24 ICC_SRE, Interrupt Controller System Register Enable register >>>> 12.5.7 ICC_DIR, Interrupt Controller Deactivate Interrupt Register >>>> 12.5.9 ICC_EOIR1, Interrupt Controller End Of Interrupt Register 1 >>>> 12.5.14 ICC_IAR1, Interrupt Controller Interrupt Acknowledge Register 1 >>>> 12.5.5 ICC_BPR1, Interrupt Controller Binary Point Register 1 >>>> 12.5.6 ICC_CTLR, Interrupt Controller Control Register >>>> 12.5.16 ICC_IGRPEN1, Interrupt Controller Interrupt Group 1 Enable register >>>> 12.7.9 ICH_VMCR, Interrupt Controller Virtual Machine Control Register >>>> >>> As said in the previous patches: this may be my personal opinion but sth like this would be easier to read: >>> " >>> Define missing assembly aliases for GIC registers on arm32, taking the ones >>> defined already for arm64 as a base. Aliases are defined according to the >>> GIC Architecture Specification ARM IHI 0069H. >>> " >>>> Signed-off-by: Ayan Kumar Halder >>>> --- >>>> >>>> Changes from :- >>>> v1 - 1. Moved coproc regs definition to asm/cpregs.h >>>> >>>> xen/arch/arm/include/asm/cpregs.h | 16 ++++++++++++++++ >>>> 1 file changed, 16 insertions(+) >>>> >>>> diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h >>>> index bfabee0bc3..62b63f4cef 100644 >>>> --- a/xen/arch/arm/include/asm/cpregs.h >>>> +++ b/xen/arch/arm/include/asm/cpregs.h >>>> @@ -415,6 +415,22 @@ >>>> #define ICH_AP1R1_EL2 __AP1Rx_EL2(1) >>>> #define ICH_AP1R2_EL2 __AP1Rx_EL2(2) >>>> #define ICH_AP1R3_EL2 __AP1Rx_EL2(3) >>>> + >>>> +#define ICC_SGI1R_EL1 p15,0,c12 >>>> + >>>> +#define ICC_SRE_EL2 p15,4,c12,c9,5 >>>> +#define ICH_VTR_EL2 p15,4,c12,c11,1 >>>> +#define ICH_HCR_EL2 p15,4,c12,c11,0 >>>> + >>>> +#define ICC_PMR_EL1 p15,0,c4,c6,0 >>>> +#define ICC_SRE_EL1 p15,0,c12,c12,5 >>>> +#define ICC_DIR_EL1 p15,0,c12,c11,1 >>>> +#define ICC_EOIR1_EL1 p15,0,c12,c12,1 >>>> +#define ICC_IAR1_EL1 p15,0,c12,c12,0 >>>> +#define ICC_BPR1_EL1 p15,0,c12,c12,3 >>>> +#define ICC_CTLR_EL1 p15,0,c12,c12,4 >>>> +#define ICC_IGRPEN1_EL1 p15,0,c12,c12,7 >>>> +#define ICH_VMCR_EL2 p15,4,c12,c11,7 >>> I did not check this in previous patches but in which order are you defining these registers? >> My bad, I did not follow any particular order. >>> I took a look at arm64/sysregs.h and these regs are placed in assembly aliases name order. >>> So for instance ICC_PMR_EL1 would be defined before ICC_SRE_EL2, etc. >> This makes sense. I will fix this in v3. >>> Also, I cannot see some regs like MISR, EISR that are defined for arm64. Did you decide not to define them >>> for arm32 because they are not used by Xen? >> Actually these registers are not being used by arm64 as well. A grep for >> "ICH_MISR" or "ICH_EISR" did not return any usage of these registers >> >> ayankuma@xcbayankuma41x:/scratch/ayankuma/upstream_xen/xen$ grep -ri >> ICH_MISR * >> xen/arch/arm/include/asm/gic.h:#define GICH_MISR       (0x10) >> xen/arch/arm/include/asm/gic.h:#define GICH_MISR_EOI     (1 << 0) >> xen/arch/arm/include/asm/gic.h:#define GICH_MISR_U       (1 << 1) >> xen/arch/arm/include/asm/gic.h:#define GICH_MISR_LRENP   (1 << 2) >> xen/arch/arm/include/asm/gic.h:#define GICH_MISR_NP      (1 << 3) >> xen/arch/arm/include/asm/gic.h:#define GICH_MISR_VGRP0E  (1 << 4) >> xen/arch/arm/include/asm/gic.h:#define GICH_MISR_VGRP0D  (1 << 5) >> xen/arch/arm/include/asm/gic.h:#define GICH_MISR_VGRP1E  (1 << 6) >> xen/arch/arm/include/asm/gic.h:#define GICH_MISR_VGRP1D  (1 << 7) >> xen/arch/arm/include/asm/arm64/sysregs.h:#define >> ICH_MISR_EL2              S3_4_C12_C11_2 >> >> ayankuma@xcbayankuma41x:/scratch/ayankuma/upstream_xen/xen$ grep -ri >> ICH_EISR * >> xen/arch/arm/include/asm/gic.h:#define GICH_EISR0      (0x20) >> xen/arch/arm/include/asm/gic.h:#define GICH_EISR1      (0x24) >> xen/arch/arm/include/asm/arm64/sysregs.h:#define >> ICH_EISR_EL2              S3_4_C12_C11_3 >> >> As I see, they seem deadcode for me. > Macros are preprocessor constructs whose content is replaced whenever the name is used. > I would not call this a deadcode as this is not something that can be executed. > If a macro is not used, its content will not appear in the actual code. This makes sense. > >> Do you suggest that we should remove them ? If so, I can send a patch >> for this. > This is a question to maintainers. > Bare in mind that we really have a lot of unused macros in Xen codebase. > IMO, if we decide to remove them, this should be done in a single series, > so no need to add another additional patch in your series, especially if you > are not modifying this code directly. Yes, I will keep these macros intact (as it exists). WRT your question "Also, I cannot see some regs like MISR, EISR that are defined for arm64. Did you decide not to define them for arm32 because they are not used by Xen?" These registers are not used by Xen. Should I define these registers for the sake of completeness (to be in parity with AArch64) ? - Ayan > >> - Ayan >> >>> ~Michal > ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:08:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:08:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437420.691785 (Exim 4.92) (envelope-from ) id 1oqtci-0001vs-QP; Fri, 04 Nov 2022 10:08:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437420.691785; Fri, 04 Nov 2022 10:08:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtci-0001vl-Nb; Fri, 04 Nov 2022 10:08:28 +0000 Received: by outflank-mailman (input) for mailman id 437420; Fri, 04 Nov 2022 10:08:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtcg-0001vd-LW for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:08:26 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20076.outbound.protection.outlook.com [40.107.2.76]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9dee8c09-5c28-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 11:08:24 +0100 (CET) Received: from DB6PR07CA0194.eurprd07.prod.outlook.com (2603:10a6:6:42::24) by AS8PR08MB8183.eurprd08.prod.outlook.com (2603:10a6:20b:560::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Fri, 4 Nov 2022 10:08:21 +0000 Received: from DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::96) by DB6PR07CA0194.outlook.office365.com (2603:10a6:6:42::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 10:08:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT057.mail.protection.outlook.com (100.127.142.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:21 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Fri, 04 Nov 2022 10:08:21 +0000 Received: from 8521bc30d397.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2A65E369-9308-411A-B151-660E66C2AC38.1; Fri, 04 Nov 2022 10:08:14 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8521bc30d397.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 10:08:14 +0000 Received: from DUZPR01CA0060.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::18) by DU0PR08MB8710.eurprd08.prod.outlook.com (2603:10a6:10:402::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 10:08:12 +0000 Received: from DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:469:cafe::53) by DUZPR01CA0060.outlook.office365.com (2603:10a6:10:469::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 10:08:12 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT061.mail.protection.outlook.com (100.127.143.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:10 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:08 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 4 Nov 2022 10:08:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9dee8c09-5c28-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Vz/C8dLkKThIRElyaEJBWmdwRjzpTF3tTSI6dSMJgV9MbHMZqIJ72sWv3Ny+6RDri7mNtyjItTds6W8wLpw/vP+bASvytnCkfjMHl8guMgXx/vQ8QKujQV0aggEf7WIAnWh1TAHk5VP1NEl1ZEtxfftP0W1CURgIlaQxIaGef58diraHtWGwZlAimRcTrr3tyV/J+L1WdnqhR1AwY6wbAOVvbYJF3pYTBI0oFqib4o9P3APlgE0WGuPUMqWfPhl2k/IGj5H1xt+o6rlPgfrcgNvTToj70h5a+HsP6v87gy+ZQgWueYh6FXr7LSYADn+PemqM9CwlzTk13t7/vkHfag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f3/EW3sqniXruvG4u4S9qwToDsD3nZPuOvy+sp1yapw=; b=h9A3raMbZ2FdwDRWpOCX4I3r/8oP/umeW/1P8q7SA6rhPUwv+fidKHKf9hWXHJxFe+yVo5HMfQvYDyvnQpoT1ENIg41W+aICJKim6ViwTJK5sMd2iUczJO178RWGtE2bidLBx92hD1oaoXUVW4MgFu/jR5U76dPxlfUHDCCpe8y6AIRAL2IIH8pi3dVuGA8ZSZwkg6bfKav1nRZ/MoMsIvfB355JDZVtkGcEVY4Qb7bqmMFJxiK46iuxA8yogEI+n71K2cDFSE4FzTXnbBcazUEGicQ/zAFDv7fuY/aV10S7hNM6fmy5YfIRFu3QPlyOIs2385tsNhmXwAOT8+l3cg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f3/EW3sqniXruvG4u4S9qwToDsD3nZPuOvy+sp1yapw=; b=QGFy775mw4dtkFIAgXsmMGur0hVtX1weg9wbrPFlx2y7TDNzFpbeofL9/VtQUqzGyqeEBfluLE+bCH7WgvLZciU5Iu+yfzWKET14pPE80QosUIFcf7JA6DZznKeqHpnpIRJjBWNmsJs6KstKG4H2/BJRtf/7xqRSYP/Q9NkBDhs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 37e6e73037129028 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SmQzWu7zKl2yaT1rL+LKWL3AKwM+vyPrrzEGdzRJk3ZuMK41GlFIKtwgUss/tj7f64xC9AD8p1wzjmfUUbEQcbgwHSJLLjRxMUTLLnEGZ0EEJ6V0vwGNhQyglW0UxHQQanLj9PvrDw1mBsRk5pxNFRqvzKR1kpRWGQSVd1vGk/xL3IapOASA08WRIcOlF95cf3a/6wbPBNubgLf9ge+6bIPGKddbNDjNXaQS5o6Y6oWOipXNxZaMqxfDxbfnpjXX7NxTnNSlEBgDn52KomiyFdIfd+VRdTG0v6g+/Qf/WJJsM+baaiwywvffzFGlQTw63n3A2Kf2osWFuRWQtQczKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f3/EW3sqniXruvG4u4S9qwToDsD3nZPuOvy+sp1yapw=; b=GjH84YH4XoZ7DYGu9Qw/8PMiCPiqMVS3oITLzvq3mx1EAlt7geI4oNEA8CkI45E/jjnylL85QNOJcd3IuxH5h7umV1e9cegbs0ecvlL0Ej4u7UyQi2B1lfw23gJ+npd6ErgQh4AEzXd5LhFqkDrKCDa6tEor7XrUNV8smPG05HKZNue5iuxrd+bR6VVoQb03qcbyoCAzbuI08x14X+9mguRqnkKnyE8u4gZ0IvLQjWAAtZa2Fz/ayI9s48/dLmBAzBERbXIfv21m8bc2bo5nUVBNOeJCJgRJ7bwxQpwJsZdhysxsVp8Mfa2wKcV67/4vQeGt1evXBdnjwtinCq8MzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f3/EW3sqniXruvG4u4S9qwToDsD3nZPuOvy+sp1yapw=; b=QGFy775mw4dtkFIAgXsmMGur0hVtX1weg9wbrPFlx2y7TDNzFpbeofL9/VtQUqzGyqeEBfluLE+bCH7WgvLZciU5Iu+yfzWKET14pPE80QosUIFcf7JA6DZznKeqHpnpIRJjBWNmsJs6KstKG4H2/BJRtf/7xqRSYP/Q9NkBDhs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 Date: Fri, 4 Nov 2022 18:07:30 +0800 Message-ID: <20221104100741.2176307-1-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT061:EE_|DU0PR08MB8710:EE_|DBAEUR03FT057:EE_|AS8PR08MB8183:EE_ X-MS-Office365-Filtering-Correlation-Id: cff1c07d-457a-4610-978e-08dabe4c80cd x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fydkYAjasSZ1yDtAksQdwOfLJwch3KrHJUfm3t/O1uGhAurWDa2RHJdwcTnqadBYGCjy9p2P+bu4bkTJ+t2Bov9zm4qnJjjpraBnsDcNTlpXQMRvYblOxDa/7zvh9I1qa2nnerRE1jOS+3vuYx7Hhj3TrddyyXB4pi3aypMzOKkypOX6C3E00wByUCO4gCwsVJ1adeC/1D55fVUBbgrz+OiDqq+GSaa0IrZ35fBAaSkfgkJ7fx6bxC0ir9sW0dgIcAXz5GG7KC+YuPjJIUm6thF/YqCQv8GmUiU9kzrXcyTYvDcDBCLlgJV2YriJfvJ9xuDUjn8v5CurZ3UCgXQv8BqnrgesGRE1x+dSniBLeV6jNkfda82BF/Ncv6pf90f+8RH0fFJ0k+b1CKXSNbr9gvdTc1DM/ycIGYve4H1y5tISgWlMV78MGIgh2U7moP+iPWIhwkAvNFKtbCjs7jmnZpzYAxtOb3BQK30afuD1YaDSK5LCG76xtJ8ooVWSgLNxgff2PN8I5Cb/Lx31fs1yMeQYv+quYBbwn+iAUJciDD3N9YmmQu0BYD1BO4mKQO9itjIHIZ5uFY5aMpyrRTULDet1K0W2JrDg3Kt0kHN0+biWTfqQLpaZgJPsJBWhvv4qcIiG0huy0nrPPy4BnKZYd2uRa99otZFUGc/hsBg2hqt534nyglzT9IvuKf5CB6baLnaEu2FARTI6QW7Hy4vE0a/hX+wH/96Gicc7sUxr6RPVURjm3HcCxf4Akn4UXCErIQUho8AcBTm50/xcm8EAqeQp0LyJHpl+26/2EKjePDPT9+cR3v0fgIInfdu3Hrtx9SOoIl9EAVGcUEVwAxqmJrySn+1TSFuRvgAVjoBPkaL5x6BinXNXWwI8v6FqeEWvGfY5gKxhD4dn0H/QrubsBg== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(136003)(396003)(451199015)(40470700004)(36840700001)(46966006)(83380400001)(5660300002)(8936002)(426003)(47076005)(36860700001)(81166007)(2616005)(40460700003)(44832011)(54906003)(36756003)(41300700001)(186003)(1076003)(336012)(966005)(356005)(316002)(478600001)(7696005)(86362001)(40480700001)(2906002)(82310400005)(6666004)(26005)(70586007)(4326008)(70206006)(8676002)(6916009)(82740400003)(17413003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8710 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5481b931-21c8-405c-9039-08dabe4c7a5f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J2yELDOoWg4ndmHF1ZNcyU1rPxFHUe5LoxFj4Z2eaMEDtSensuMZLvJCWsso/flG9JI+uQ2NmPOgwJA59pzbYuctPqA69sZg6cdmV6nKwMHKky2VL6321U0SgqNSdb0yVzn2HB9KcmSWeHvjN5mfpL6KTVy58MJO1VoKr8Ru3ERfk83I15KDqm7w2yBMVW+fWSQD45Z6sLMEoTvZ2QUGEYZjWjk2su6YABzCliK84CazHtiLrH3pCEyOCzsvJX1NkKv8TgKEdxh4B/meKmtJHzbCg06aKLG8r/MPuG7MzPd/T6XFH/G+E/XMSB0R0gcSBnEOE4kdCf9QasTXDf0UomZAciT5uMv9amuFqSG35X9DVi6UoHPhA1MKO0l53Q8pAmMJO3nnuQyPfMUdS7Y6dF722BoJfDyNdRBLS/v8OCBOtyUVowUVwt+fwNvboLrwQmQ9fKoHx9ceBwNSrvZTXxtGfxlAtUQgHaXvSywImmJtrJlc8AbAIRc3wxziMekiykzh6ENXX3xnN4n9IOYQKHDbuO07IlazMY2Sl6vNj5tJHBpYjnsOX85/RHoIqIAchwlWDV2pMgDj3Oe511isXiD3/iQHnldAN15qpp5jig66sG46FZpcroUU9ynwBT+3wuwW1I+HytwWqPOje36u2TuWI0KKt+yipYYjv4gKjAamfFlittGc/TYHWi47hIqvmOTH+jNzhbLxYOBxpb3SNwk7m/Xq+4BSaol1ctaG9VK8DH00g6cVt9Lz6B9NY6QmpaF5wwTHG4jkhWyasVC7+11T5b2DXZbwgA1wMbLN/q3Tft71dymAtg9vcaRNC2GF72YHYcwAE7gdRYizx1ZXfp73BLRIHQ0U5d9ppdLRt2c= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(39860400002)(396003)(451199015)(46966006)(36840700001)(40470700004)(6916009)(54906003)(316002)(4326008)(36756003)(5660300002)(70206006)(7696005)(70586007)(40460700003)(8936002)(8676002)(41300700001)(44832011)(82310400005)(336012)(47076005)(36860700001)(426003)(81166007)(40480700001)(1076003)(186003)(2616005)(26005)(478600001)(966005)(82740400003)(83380400001)(107886003)(6666004)(86362001)(2906002)(17413003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:08:21.3939 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cff1c07d-457a-4610-978e-08dabe4c80cd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8183 The Armv-R architecture profile was designed to support use cases that have a high sensitivity to deterministic execution. (e.g. Fuel Injection, Brake control, Drive trains, Motor control etc) Arm announced Armv8-R in 2013, it is the latest generation Arm architecture targeted at the Real-time profile. It introduces virtualization at the highest security level while retaining the Protected Memory System Architecture (PMSA) based on a Memory Protection Unit (MPU). In 2020, Arm announced Cortex-R82, which is the first Arm 64-bit Cortex-R processor based on Armv8-R64. The latest Armv8-R64 document can be found [1]. And the features of Armv8-R64 architecture: - An exception model that is compatible with the Armv8-A model - Virtualization with support for guest operating systems - PMSA virtualization using MPUs In EL2. - Adds support for the 64-bit A64 instruction set. - Supports up to 48-bit physical addressing. - Supports three Exception Levels (ELs) - Secure EL2 - The Highest Privilege - Secure EL1 - RichOS (MMU) or RTOS (MPU) - Secure EL0 - Application Workloads - Supports only a single Security state - Secure. - MPU in EL1 & EL2 is configurable, MMU in EL1 is configurable. These patch series are implementing the Armv8-R64 MPU support for Xen, which are based on the discussion of "Proposal for Porting Xen to Armv8-R64 - DraftC" [1]. We will implement the Armv8-R64 and MPU support in three stages: 1. Boot Xen itself to idle thread, do not create any guests on it. 2. Support to boot MPU and MMU domains on Armv8-R64 Xen. 3. SMP and other advanced features of Xen support on Armv8-R64. We will split these patches to several parts, this series is the part#1, the full PoC can be found in [3]. More software for Armv8-R64 can be found in [4]; [1] https://developer.arm.com/documentation/ddi0600/latest [2] https://lists.xenproject.org/archives/html/xen-devel/2022-05/msg00643.html [3] https://gitlab.com/xen-project/people/bmarquis/xen-arm-poc/-/tree/poc/r82-mpu-v2 [4] https://armv8r64-refstack.docs.arm.com/en/v4.0/ Penny Zheng (3): xen/arm64: create boot-time MPU protection regions xen/arm64: introduce helpers for MPU enable/disable xen/arm64: add setup_fixmap and remove_identity_mapping for MPU Wei Chen (8): xen/arm: remove xen_phys_start and xenheap_phys_end from config.h xen/arm: add iounmap after initrd has been loaded in domain_build xen/arm: disable EFI boot services for MPU systems xen/arm: adjust Xen TLB helpers for Armv8-R64 PMSA xen/arm: define Xen start address for FVP BaseR platform xen/arm: split MMU and MPU config files from config.h xen/arm: implement FIXMAP_ADDR for MPU systems xen/arm64: move MMU related code from head.S to head_mmu.S xen/arch/arm/Kconfig | 15 +- xen/arch/arm/arm64/Makefile | 5 + xen/arch/arm/arm64/head.S | 429 ++---------------- xen/arch/arm/arm64/head_mmu.S | 364 +++++++++++++++ xen/arch/arm/arm64/head_mpu.S | 154 +++++++ xen/arch/arm/domain_build.c | 2 + xen/arch/arm/include/asm/arm64/flushtlb.h | 25 + xen/arch/arm/include/asm/arm64/macros.h | 52 ++- xen/arch/arm/include/asm/arm64/mpu.h | 13 + xen/arch/arm/include/asm/arm64/sysregs.h | 89 ++++ xen/arch/arm/include/asm/config.h | 99 +--- xen/arch/arm/include/asm/config_mmu.h | 119 +++++ xen/arch/arm/include/asm/config_mpu.h | 29 ++ xen/arch/arm/include/asm/fixmap.h | 25 + xen/arch/arm/include/asm/flushtlb.h | 22 + .../arm/include/asm/platforms/fvp_baser.h | 18 + xen/arch/arm/platforms/Kconfig | 16 +- 17 files changed, 976 insertions(+), 500 deletions(-) create mode 100644 xen/arch/arm/arm64/head_mmu.S create mode 100644 xen/arch/arm/arm64/head_mpu.S create mode 100644 xen/arch/arm/include/asm/arm64/mpu.h create mode 100644 xen/arch/arm/include/asm/config_mmu.h create mode 100644 xen/arch/arm/include/asm/config_mpu.h create mode 100644 xen/arch/arm/include/asm/platforms/fvp_baser.h -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:08:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:08:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437421.691797 (Exim 4.92) (envelope-from ) id 1oqtck-0002C3-72; Fri, 04 Nov 2022 10:08:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437421.691797; Fri, 04 Nov 2022 10:08:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtck-0002Bw-2b; Fri, 04 Nov 2022 10:08:30 +0000 Received: by outflank-mailman (input) for mailman id 437421; Fri, 04 Nov 2022 10:08:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtcj-0001vd-85 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:08:29 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60084.outbound.protection.outlook.com [40.107.6.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a0a1bbd4-5c28-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 11:08:28 +0100 (CET) Received: from FR0P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::19) by DB9PR08MB9441.eurprd08.prod.outlook.com (2603:10a6:10:457::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 4 Nov 2022 10:08:25 +0000 Received: from VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:97:cafe::88) by FR0P281CA0121.outlook.office365.com (2603:10a6:d10:97::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 10:08:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT021.mail.protection.outlook.com (100.127.144.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:24 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Fri, 04 Nov 2022 10:08:24 +0000 Received: from 07872d1abef2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CBA8DF80-5084-49F2-9505-EF33C838FFA8.1; Fri, 04 Nov 2022 10:08:17 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 07872d1abef2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 10:08:17 +0000 Received: from AS9PR07CA0056.eurprd07.prod.outlook.com (2603:10a6:20b:46b::32) by DB9PR08MB9636.eurprd08.prod.outlook.com (2603:10a6:10:45c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 10:08:16 +0000 Received: from AM7EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46b:cafe::27) by AS9PR07CA0056.outlook.office365.com (2603:10a6:20b:46b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8 via Frontend Transport; Fri, 4 Nov 2022 10:08:15 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT058.mail.protection.outlook.com (100.127.140.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:15 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:14 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:14 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 4 Nov 2022 10:08:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0a1bbd4-5c28-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ocRIxqAe0rTYDLZ7vGYC2mCseq2tMleYk83Sahdkv5Ixj44lpL0Px7bdgazygnt7tGP6eqImPVQNuK5NgxXqcxTmOnzHmBIiedwXME+pYzur9wM+ZS2noYbZORki1j5CXJXMZrWzpjDvuRHzDy4+19mqLTuSuhU0cc3H395sQb//xnfIYOh8mEteP75YaIldsBnAIdteiMhdIsiLQh2bgDTHEylwZjgViJdn/YFnJoG5MAx4q0b11oIOeyMMoN8pKDotQnoWPQBQcAzGHcBtqwH37kr4ZZI8ORCx85wrfTAC0kH6OzVxOs90ZVRRyDE9+mHFtoBH4E6zr9Q3gCCjTw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wnPM1xFo4l+7IWvKEJmJLFxA1jz0PVO8B+lteuoaFGI=; b=U38r1RTUs+fkOCVGUhaqoUHto9ycd7HEdSfNbmKW8bsmKsV2rSlztX2WAnLC3e13GhjZ10llGsWbpXi7l4bBMEN2dDiutKn3dxixN9ejf+/iu5VXq55jr6HNAMg1kSoqp+r5FU0TaEtSAAP72Xc/mStg82HuGOIr+9esT2ai/96+Km9B4BjvI6m5wWlkOglMiZhvygaNgeYDmG7MR1aoRzKwVOnz/m2oyGgowshAYWcfmraRwpYMJIpxpGmQVBdXrMMYluZt4iSyb7IUsdt2xDBscLCkMI/f84xCoMT/1HFmj4HFOcyci+dx+iTi41Is24aWcdJkq3eXaPeA/nUUkA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wnPM1xFo4l+7IWvKEJmJLFxA1jz0PVO8B+lteuoaFGI=; b=4jhgRmhxNKxQgHFQsSHNivGfdYSf2EDi+BG8VHhYwjAd3UGilovWjmCGdpUaB/Y0V4pN1EkjYGyAstXuRGLo1Od5bhyVM5mbJ4NpOTe8JRqf9C+Sy7YJZWuTvyTW2D6VjpddFF7FN9FrR85xdvP6CUwRlpxJ6J6w3+miwiE/6JI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: ee05a032046f179a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NLGVoQKsIoS9nfq+l6xtfc591eudryOlvFdqbdrT0+m/henrC5SqEYonMfPVOIlP3dLT+xhzZU6t8bHo5hu3+QrBh32v/18bI5DI4tgA1mD2VKZ0FGO7RiTpzOnkKDQcdNesvWVFJyoJ0HwOO+eb+xmakTFw9ziIa5mf186TuZ2xTVK0XWEo73YC9w66cap3od91nd9/tmX7udvcvYpfIq3hXDnms7m635zE/84AOjqnQC6pLusvtjb7/SbyRcDvl4VlzwBcBDQ3cmZ3/m9BMywm3aOig37aDvmuAtF9oEHiV+54pf4SMUyVYJdmRbBXrTFZwFYI3jLhMFgKe0Qntg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wnPM1xFo4l+7IWvKEJmJLFxA1jz0PVO8B+lteuoaFGI=; b=d5iDv055lkPfwavtOhaZWMYZd3+7/I6Lw8YEQlOPiyddWUPZd9KmW+JmFVZby1GiR4V3d2Bi/KdntVNqFc8xTXiYTJ1MAV4l+7IuhZPqA4osWMIvnPsPwDFTSXgi6j8RfTcWF2kPQBZwYYxh97buljxHK5bsH5W9BG6KCPgIfSjqFD0GiIXeTe8v1l1YGCZwK88gQcvDt9S21P94TJPmYq/irXtYVCfuMPb/zOajI7oVR+HMh3sZP62fObR2j+DfOC+qb34gI2hugb++80HnkCif7qvv006gceHTJD/8LpaUuDg5mBZwGHsxGJUB/47j30dA9N+PCfp/MR88/bCH4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wnPM1xFo4l+7IWvKEJmJLFxA1jz0PVO8B+lteuoaFGI=; b=4jhgRmhxNKxQgHFQsSHNivGfdYSf2EDi+BG8VHhYwjAd3UGilovWjmCGdpUaB/Y0V4pN1EkjYGyAstXuRGLo1Od5bhyVM5mbJ4NpOTe8JRqf9C+Sy7YJZWuTvyTW2D6VjpddFF7FN9FrR85xdvP6CUwRlpxJ6J6w3+miwiE/6JI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build Date: Fri, 4 Nov 2022 18:07:32 +0800 Message-ID: <20221104100741.2176307-3-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221104100741.2176307-1-wei.chen@arm.com> References: <20221104100741.2176307-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT058:EE_|DB9PR08MB9636:EE_|VI1EUR03FT021:EE_|DB9PR08MB9441:EE_ X-MS-Office365-Filtering-Correlation-Id: 49cba82c-d5a0-4d74-0d69-08dabe4c82c0 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3kkhQZZ9G+0mMV5jEY8nCWSAVJV4xNMb4rtVT0pSxQbHUn0FNr61CKezU628+3sPLdd607ljOLaIE5OoKb8CJLjysDcCfrhwoImwLV9fWVORSF8fflDNQ2+hxFOScLrk8wYEekUWWER4ms8TGAcussUtheL1bA0G1P4UHiTR6IC+DbYtWrNa+jtAaLHZEupv8/mezLBGgwcUzEhoHdNa1F0fkujmoFkNYeFJPjpRRXeL8hDJJXdaqpb+Vb02S3e1DgqWKTnC0BfKfz5W2OMQratBvZuXuTDfChEWY/ldlLo9anFEg7caBXJ832r7WB8j0DHz3luIi31Oo8FU7T++aWQ25Gnwv4c21HI18Qx1QX7gak2XHS5F+on5bcmUvIWkqL4mHr4GmYNfVHDTvjQ9R5x4I7yeivkxugrv83YNojIKPyyvGpgkRUVzwskNVeHyQd34oOFX4XSSWgoilXPttBX1BRovmP2YoAFZVMhpLGCD//IzkYZi+m/W5z2j4yM9HCBa94nGpo+ApINKaXcImuQyhimA5vm4Rc5s6qrFfyGVtiYb1QUppS3lMQ0bJ3pV+CqPsolkrkIFWEvjQ+uxlIfRMmbO0ZVWAznsoDMOamCnzMnA1WCQAKoHphe4phfzPcpg+yWiTF3VyLwqJUk57PCCm+hIHGI/UB8pA1g+hU+s3+tL2vLwAecFXpslSs/vKSpiQLJeuDrqZPMhYAYs7rwVZaRxMwZGL1K+BxyEm70DGF5ZomBUyMVvaVbTejVtOxxraPKPk1M4iHNS9GFwr5wiiliP/WR2vYtXyeLQr8sP9QY37P2xBpdciTm1EpO5 X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(346002)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(82310400005)(4744005)(2906002)(44832011)(36756003)(40480700001)(70206006)(6916009)(81166007)(356005)(4326008)(41300700001)(54906003)(8676002)(8936002)(70586007)(36860700001)(5660300002)(478600001)(47076005)(26005)(426003)(1076003)(336012)(186003)(40460700003)(316002)(2616005)(86362001)(6666004)(7696005)(82740400003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9636 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 22b3b432-17e4-4971-eff0-08dabe4c7d61 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7BF/UgCwIzR89avK+tb6fvqT0AkrrwZq59Xm9oUCBUmyqJM9PuQ5aMbqt1SgcVLEJaGfDxZC9KjnE/fL6TyO8CD6CcHLH0m8leYLYn/RY0In/JNx/s4esQprtB1KhTNO3FqvZuVQUaLvpgaSZKI3IE9t+x/WpDRZOPm9PM9B9hL+BIBmEb2sZe8Ms5HfKlKgr0Xxn1hBBw0XGuyWNmgldynz5lVEVXUcBxeEYOe5KRn2rKOh/jBW3zalT/1iwGsO8tRQwEOP9UWNq+XrBVW5znOFZBJrPDFOFvNbP7y82aU1EHJYaprVD4k5NQ6VfiltyS7eLcR0IC4f7BPZYOlhiStlJnJg4lTfxhkvCPSHN5XJwqIhtHbWXOQjwUC+VOT/Y7mocfqv17lLt1/yP/2SnVUtI+qJs8rdorevBwH9v4r2EmgjZC1KyOMd6Pw/dCvOGhhLbvFqYgvBUFnMlhJBUTl2nGUut0nVy3RgjK4JWDDIqQw5uq40BqEezbKdeOvbX7X9m4w/28UarE0Kc5tHnRY1h2IJOi+yTqUpl2cuwge4iJCg+wQF7hoUoCbXNpRj10gH9FTvlPqQK0HW1ouujZbH21duJOJK4bgekjEfWLmlACk7ED6o4qBdoH0jQT4//9PCxVPzw4dhz+7l6cFpZ4aW0K+V/cc9fM/J1aGCVaIr4xCRmobE/z228yMsVZqM2MAaW7L3XVghPCSSVilBD/PSlAwjQQfVs+Ks+s/46OBHc60Q3zkokLYFHaiUFI2BbwzKR9852E267cAdg3WwXA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199015)(36840700001)(46966006)(40470700004)(54906003)(6916009)(36860700001)(70586007)(41300700001)(4744005)(40460700003)(4326008)(316002)(8676002)(81166007)(40480700001)(70206006)(8936002)(5660300002)(2616005)(26005)(6666004)(107886003)(336012)(1076003)(7696005)(47076005)(86362001)(82740400003)(426003)(478600001)(44832011)(186003)(36756003)(82310400005)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:08:24.5669 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 49cba82c-d5a0-4d74-0d69-08dabe4c82c0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9441 domain_build use ioremap_wc to map a new non-cacheable virtual address for initrd. After Xen copy initrd from this address to guest, this new allocated virtual address has not been unmapped. So in this patch, we add an iounmap to the end of domain_build, after Xen loaded initrd to guest memory. Signed-off-by: Wei Chen --- xen/arch/arm/domain_build.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 4fb5c20b13..bd30d3798c 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3418,6 +3418,8 @@ static void __init initrd_load(struct kernel_info *kinfo) initrd, len); if ( res != 0 ) panic("Unable to copy the initrd in the hwdom memory\n"); + + iounmap(initrd); } /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:08:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:08:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437422.691808 (Exim 4.92) (envelope-from ) id 1oqtcl-0002SP-Fw; Fri, 04 Nov 2022 10:08:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437422.691808; Fri, 04 Nov 2022 10:08:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtcl-0002SG-Cl; Fri, 04 Nov 2022 10:08:31 +0000 Received: by outflank-mailman (input) for mailman id 437422; Fri, 04 Nov 2022 10:08:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtck-0001vd-01 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:08:30 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2072.outbound.protection.outlook.com [40.107.103.72]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a09b4265-5c28-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 11:08:28 +0100 (CET) Received: from AS9PR04CA0082.eurprd04.prod.outlook.com (2603:10a6:20b:48b::6) by AM9PR08MB6228.eurprd08.prod.outlook.com (2603:10a6:20b:281::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 10:08:25 +0000 Received: from VI1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:48b:cafe::a4) by AS9PR04CA0082.outlook.office365.com (2603:10a6:20b:48b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT044.mail.protection.outlook.com (100.127.144.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:25 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Fri, 04 Nov 2022 10:08:24 +0000 Received: from a8366c43495b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E23B5F10-A394-4F13-BA05-81FAF60814B2.1; Fri, 04 Nov 2022 10:08:17 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a8366c43495b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 10:08:17 +0000 Received: from DUZPR01CA0048.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::17) by GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Fri, 4 Nov 2022 10:08:14 +0000 Received: from DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:469:cafe::cf) by DUZPR01CA0048.outlook.office365.com (2603:10a6:10:469::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 10:08:14 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT061.mail.protection.outlook.com (100.127.143.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:14 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:11 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:11 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 4 Nov 2022 10:08:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a09b4265-5c28-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FjX6YFn4xc/Td7GImH03KebydO2lw/Wrig0M+qT+aA9qnSGjTmaawSNv0m0Doeb3jMksV3RCJSueE1ohbJXdCvUW+vKu7EGW4TARM53VK61XSQDsr7Dd1GmKbQkwwZ63L8Q53NzB+Jvid9dVj078+NK6ETZsISd0kDhRnqTd4O8U99NCaB4Rz7My0eWfH2ahudWnJ7Nw3t0rMalxtLYNqpOWEUFzePCCUcv/gkNd3Azep/zcFCGW/NSHYRuCHL7ayUusiT7qg/8dBZECvlpO/Dm6nuXGy4CqQ1jWhRL3LXw7jMyb9eC7Ksj6msJuZgAaeNQ0LPZQDV75baq+0OQBhg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=reeaGX3EiLTIfCDe2q9RPtUHzXscDNeSvv8TUOZS8iM=; b=KKxYlS+KN/ff30NLgqizaUO3WWfXj6/CfwfUJ9NeDNkQtWIkMYWAgCZ035GUJfjTIkHam+X/saCC/dTCLVyPldodP/DmHR1j4p/QgvwVLvBMf+de12QjtEI+Ls3uxAYgMDGZtsPYuCATZ71M4el9AcCvYRnCk1DB8CPC3pLSfpvlS42axfaI7E/hKCKYk8KIWq8/ZMuL7E5oK+rBctXi3rsv/6NPiGBcGfvd7Up6UDP7dEdXYKvioH1rsIjKCIif2/nAmFgV4xecwFQeF7vfxkooIP+wQskuDgF5jUoCmgG+DWofFoXheCR7uxVZ1XjD3qfBtFHNmb+pZCHVi1ld8w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=reeaGX3EiLTIfCDe2q9RPtUHzXscDNeSvv8TUOZS8iM=; b=n4+bIqiG3ev8yXXFutTOt6ETwqAxtszi+UoACwLzQdeZqNOtN7SIyEzqdYl0RRMG3c7T6sUCRyy7li4OvKs4oczwBxkf/Vum9JV97pkzNWEblbRCr4XKaV+5yDFOkt/PpdD1nf0aQLFVkPfwCAALtZYIG+rNL0vm8hXVGf1R+DI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9604aab51f58af20 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QryrmDIHPerhyhj81+cEwRBX00PuMHDxNJRZlPJIJfFLgwxrGuC4OzssXzB5Yvn1j06YY2lNa2zRTYZAtEpYYPOK5CCLFzYVhi+nqO68Xyf9u8vMRQWlUHvYqGvxYFnBHkD1UhiBXB1PnhfnmDl8mCecHs38s72TVfPkLzj2b/gl1l1+edpURBEV0AvDpHA11ilUIB0ZH0D9udpF5hiHCZdYwWnZSEbw3u/6H484eboMI6ZYpaKoyKQq2myVO6V/WJsPdXR4K6iMGwVd86mH4NtwUaN0ThSF8PEvsacInvnFlfpkht1uAza1gnE2On+McjmaNgoVshVu+2DzCGXBhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=reeaGX3EiLTIfCDe2q9RPtUHzXscDNeSvv8TUOZS8iM=; b=RBTN2rQOqqOUo7eH7Skc3laky9AOMjCIPOWA3OBhlgATm5SOko1en7YhCzXywcrzsC26c4yzral8RInv2BD7B94EK6OTtKluMLFpuXIkJEYoh5oFCI94GEctg3LV9BoWC+c9VWiVjLTY6LzK6cCYnJfLxb4B4RPghPdK7HNfnpJS0wTZJmKU5zf+1d+3DT5ZBpNq6upGSk7NTmeGIPCCVrZi8M0EQt6MHXxYlOp6vMfJ5Vss5Hz5G67aATu5sTvieLpbwsu+to/r5iTQMeKn4d70Q6C6mCImvWW/isOCPElM+T843hXaNiSYPrdCDB6J+o5B6tneUh0k1lD756BMgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=reeaGX3EiLTIfCDe2q9RPtUHzXscDNeSvv8TUOZS8iM=; b=n4+bIqiG3ev8yXXFutTOt6ETwqAxtszi+UoACwLzQdeZqNOtN7SIyEzqdYl0RRMG3c7T6sUCRyy7li4OvKs4oczwBxkf/Vum9JV97pkzNWEblbRCr4XKaV+5yDFOkt/PpdD1nf0aQLFVkPfwCAALtZYIG+rNL0vm8hXVGf1R+DI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v6 01/11] xen/arm: remove xen_phys_start and xenheap_phys_end from config.h Date: Fri, 4 Nov 2022 18:07:31 +0800 Message-ID: <20221104100741.2176307-2-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221104100741.2176307-1-wei.chen@arm.com> References: <20221104100741.2176307-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT061:EE_|GV2PR08MB8121:EE_|VI1EUR03FT044:EE_|AM9PR08MB6228:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f472e3f-3336-4640-d16b-08dabe4c831b x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Cn3NFNZE7IuUWzWayiPfjCJucr+1gvi0ZqxZuFZ82eaXOb7N6MCTeEXEHT/2tHVGaoytRVSgottPyI8XFzez3iplRvQm52npF2NkUZXa3SGnB9zhubs6oc18iA7hxBPY5zn5ZTczmQZ+hcJkvkQprPNlkQRCv0UygeTw3vqJ+vPI8sXreh3GePZ9aRFdaZvn7mg4uzCJjWCQFOZqWBqFqZSyFZQYehbdIpqQe29p1vLamf+C0BdXGR8NVF76TQRWX5rDEkUqyDo4e1FbX68BPakFEAF8lKSoVeqEz9rNG3DYrAu1ZsIcnNBNPiohdueaV2qPA4bOLUrEaU5TAxK+3qAZKk/Yqyb0eKDljkTJQqcDIaU4Kf9J0rB45kVdA5foMMhTB9Ehhmx3ikgvgf8N7kdLaYPMtS8z24bgoUAzm/snfQVvOtLjxnIC4g65JxoU4UQFZ7BuLesw7uJyLT7KXWyqtvLJSk58gjEcJMJXI+R0bbJoB0dJIb9cdr/c82kmwSEvgfSmWZ58vR10iH2PSX1mGVnkTpjrG+Z3aCZp2YY2DO+ZpkwudBaZRiBiWsebbBdQaWbUWGrZY3RxnO/vCUIZaUGdpkdfA6XEwZfDUu6+FIDPf7c/2AWxHy0Lvmuw22KZL6WK6aLeB3QAMWQ/NGywNLotpyErn09xvqKHHj4BbxoJftp7lwuvsvk7qXX4Sd7Bp7OoHp5MtpETv5YIWQV73z5FwVtjJRXW3hT/rl7VhmyRTi5CooN9TZoWdGyq7Eff0DPZXgLyj/4+IdQjHsyAj8w95mjidwc1/Yc9joYtVVrWr/ORg673TcTc+sW2 X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(136003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(5660300002)(44832011)(4744005)(36860700001)(8676002)(6666004)(7696005)(2616005)(40480700001)(47076005)(36756003)(26005)(2906002)(86362001)(4326008)(40460700003)(336012)(82740400003)(478600001)(186003)(426003)(83380400001)(1076003)(356005)(316002)(70586007)(70206006)(8936002)(54906003)(41300700001)(82310400005)(6916009)(81166007)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8121 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c91730ec-9a8f-466b-3e98-08dabe4c7ce3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QWRnNANmZNlm7n4CmmgB79XA+2jmMrjfINuwtIlX0JUbpzK3Y3LAeRPo/S+YQDdYy1vnf6roXzNebR1835vno+p/XEz+eTxRPZvJw12BgkQ8S2CNmPIiGrJUMmBVl/AzZfmsH/7CwSoNXGcUozFPH8ABWkBYK8gcmd9OZq5/GPyPqWXDZiHEgeojL+fJzrEfHBWM8+uK8BkOQexTqJgF+A9tefTMRTJBD8faJo9VEFLrUSiGr4j7zO3OgY37zV5oYJ7YR2slEnsupzixXuxJd9vUFhexCS6AcP25bwxcV1Kqw+UI4966RlifnOcwZJLela+MKzuwtf1BeteoCGo1zQUaZ5ZSwmUZssQThJd4eDou+Dp6agQL5YaTGGpuyF8PX7CgtY1fRXrI38bDNRZHg97id4RhMA2xHD+vzUJikICrcEmxsMBrou3OA2G8R5IANYYnP5Sh6qsge78TRjZgO09DUNngXNoArGX0Oepu6z50wIPCxdxKiFZpX+gsxR/umW8mS6AY7Vwns9MyjJ+ssdFcx8OdysvHJLrD0ja4uCyNMM+Mk8za5HQu6QG+9F4/7JX03gTukteBUNbqi0ao2Wu27nUBq7CadvKWnsYZWskyZ4JnCUBIv/ro/l+P6jKBcFX3Z02ERREi3FPoh7iFC0CPLvJryhUZLEoRuMkT9yB3ILSXwYLO9EpuZq+KL4sQyoGz3U4aIgXbqxxogzi+I3rNbYn/JMHdF/w5uSwWF5QY3N6s0lK9qtwwmteyXQ71Q4Xvab9AFch2KmVfqf1U8w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(83380400001)(47076005)(2906002)(426003)(8676002)(86362001)(40480700001)(40460700003)(36756003)(4326008)(70586007)(70206006)(26005)(81166007)(41300700001)(82310400005)(36860700001)(82740400003)(316002)(2616005)(5660300002)(44832011)(186003)(6666004)(8936002)(336012)(1076003)(4744005)(54906003)(107886003)(6916009)(7696005)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:08:25.1839 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f472e3f-3336-4640-d16b-08dabe4c831b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6228 These two variables are stale variables, they only have declarations in config.h, they don't have any definition and no any code is using these two variables. So in this patch, we remove them from config.h. Signed-off-by: Wei Chen --- xen/arch/arm/include/asm/config.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index 0fefed1b8a..25a625ff08 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -172,8 +172,6 @@ #define STACK_SIZE (PAGE_SIZE << STACK_ORDER) #ifndef __ASSEMBLY__ -extern unsigned long xen_phys_start; -extern unsigned long xenheap_phys_end; extern unsigned long frametable_virt_end; #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:08:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:08:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437423.691819 (Exim 4.92) (envelope-from ) id 1oqtcn-0002kS-P1; Fri, 04 Nov 2022 10:08:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437423.691819; Fri, 04 Nov 2022 10:08:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtcn-0002kD-LS; Fri, 04 Nov 2022 10:08:33 +0000 Received: by outflank-mailman (input) for mailman id 437423; Fri, 04 Nov 2022 10:08:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtcm-0002Y7-7S for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:08:32 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2042.outbound.protection.outlook.com [40.107.22.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a2492e6b-5c28-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 11:08:31 +0100 (CET) Received: from DB6PR0501CA0013.eurprd05.prod.outlook.com (2603:10a6:4:8f::23) by AS2PR08MB9716.eurprd08.prod.outlook.com (2603:10a6:20b:604::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Fri, 4 Nov 2022 10:08:29 +0000 Received: from DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:8f:cafe::57) by DB6PR0501CA0013.outlook.office365.com (2603:10a6:4:8f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 10:08:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT032.mail.protection.outlook.com (100.127.142.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:28 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Fri, 04 Nov 2022 10:08:28 +0000 Received: from b7207d4c6724.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0A5F94E7-4458-4B9A-B377-937F2256D352.1; Fri, 04 Nov 2022 10:08:21 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b7207d4c6724.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 10:08:21 +0000 Received: from DUZPR01CA0055.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::19) by AS8PR08MB6437.eurprd08.prod.outlook.com (2603:10a6:20b:33b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 10:08:19 +0000 Received: from DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:469:cafe::ab) by DUZPR01CA0055.outlook.office365.com (2603:10a6:10:469::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 10:08:19 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT061.mail.protection.outlook.com (100.127.143.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:19 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:16 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 4 Nov 2022 10:08:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2492e6b-5c28-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DcuOjZu+sXs8x3P8xHmd8WpIkprp03QJhbKSWHXEPR0aob9Z0fQSQ0Ok32jHQFnrJ1/f5vduviQceNoxk0H6IvSvg44LMSA03S7oZsOeYv7XTnDde/PSQPOpsDdKVN5gVvfWiwyOCz4YQZjp7ZC1KPjkuccJIfBQJC83eGSdemKWPBMRIxPGr0A3Gsks2VTtpwYoCKi36sRVg1qyC3yGkp9QimICWGtwEcs3cIcZdzrrUIDSRraSgJNLex/jHkEy2m/VVJz6gCjpEs949kxRrKKkRqhXDjCz5C/kVC6ZdGPIK+UKxFE/PriSuKWRHK1vkx/U54CG7ouL9JAHIVY+jg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CpCwe/YQuh8dExFgUjQ64iwotcXpfBD1fxeA2Xv10i4=; b=bh4GlclJbGbqS2LcpTMIx6kPQLdJzWvfdM8zme5aX+wQFi3iLgUS4/I5YrxxYqqnOwRGXoin/dpmpKxndpNWcFEqtmNFNWNBEXtV/Sf84rkRMHosd83xExRL7WAVvxnTfIMbcvTEyTjf6+aAzDSjdUkXFYzaqN7lM9Ze/eLfPV8K7t2E6FB98e0bDeR+nFAZ6pYbDGBy/9jPP7hcph42xbNFZtMloYn+tfrXrU/2QCHY/a3sM9Ocg8IFRZX1el4M5NV0e5kgno47PwefmNQgZG7prx2VKAOE9JLbaAt2sepDeSHr4sjcovV+zIgy2/kAALw4UuX1Erjc12Jc4hLs/w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CpCwe/YQuh8dExFgUjQ64iwotcXpfBD1fxeA2Xv10i4=; b=wpca2GX0/iw/Yy6Eg6//mcsB5ChVSPFBawhOfDf24XieeZHIFax6plSAPhEBJQoJG8ITdFE/rfCW0kbEcqdPfoynedZ8/3BMsfpGQitZYW04qESrHRPPH5iOoclFwzjRsryJAPNeRuX/Gi/O2xvYYMRLx4IeZnQWmIjpgPyfSsg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 2f25cda0ec7c1063 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m1zenx/ZRrnl1J615gNg0oEqTCZeEd0rCB1BRGty+DFfOXgFBOQ7powMloU5hhpny4VfWJjJYmrrsAKGO3sCGqoqNfcKQBNfMUroXw4BO+wPpLQk0w4WkRBMB5MG8uTsjZOAsB/eLFeSUIxRO/emQgREoRlDz7GL1Vn0nTTWWVM/E/FzeCrGORbprin02t1LlWi0CXzUz/5x/gYib+Dp0IvPh6wBGV+3kXZneNPJ+YmYMeQviyO0AbA18rQLO/J22uIK4caCByTwnw1DzVESu1VO+3DPBgUEJXixFRvp/YJCFa2C08vdJ94USg585yJjYf934CiSmOYAnMgg0HKtjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CpCwe/YQuh8dExFgUjQ64iwotcXpfBD1fxeA2Xv10i4=; b=VmDVTf2vYWOsmjj+Z3ZOUSoBFOULj7f/SRL0Xq+2CFOQ0PKkMGqoQXyPEiTRKaFKeMht4SW9gwvMyvefwEEAFJWcst4OUiF/AD7NSlYsVeykcgccs9Jr0Zv2vY63rsp/5MiHAXsX7TCAmqOMYww8r8htzKSqZEMOiHHD4wKY3PbWxidxOE86Hzh4gVH4y18+dJfSXlmgQW71YgTug0mFoKcpMSZbsWQMorZ6oJkljx9VWcfWTtutQgjbTiVjpyHZI9/wYBOixuF/mQtx2anpN9UxkLR0av0+YtZhR5aPchgLXcii17fNpoL/oi9N4TPI9V+6ZV+vOf87bD9HRkKeUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CpCwe/YQuh8dExFgUjQ64iwotcXpfBD1fxeA2Xv10i4=; b=wpca2GX0/iw/Yy6Eg6//mcsB5ChVSPFBawhOfDf24XieeZHIFax6plSAPhEBJQoJG8ITdFE/rfCW0kbEcqdPfoynedZ8/3BMsfpGQitZYW04qESrHRPPH5iOoclFwzjRsryJAPNeRuX/Gi/O2xvYYMRLx4IeZnQWmIjpgPyfSsg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v6 03/11] xen/arm: disable EFI boot services for MPU systems Date: Fri, 4 Nov 2022 18:07:33 +0800 Message-ID: <20221104100741.2176307-4-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221104100741.2176307-1-wei.chen@arm.com> References: <20221104100741.2176307-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT061:EE_|AS8PR08MB6437:EE_|DBAEUR03FT032:EE_|AS2PR08MB9716:EE_ X-MS-Office365-Filtering-Correlation-Id: 169d4642-7c36-446c-35ac-08dabe4c8551 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 34qvEV9wGeLGeLvvUPLKo1q+sKqe9UlPIeI1vG2DPmIMyXA4JJqS72wQfZjkFdBZsCinr39sze20ILUMfJAP9Rumec4bdiHGCAz4uMI0U9+uRPpX30HdPo0B+4R3UclS4O7/WnzNjxg3xaxJHGazKri6SRWGqaLJ9ko5SB9Y5o/71OAU1pvfRTiO0iSVrcc6H0rT9ruwiKlqRzaT+OCLvcwOqDCrvXeH/6iE5A8zxyQMOZ+oVlviHj6xUuS++MbezRbhM3xkpnJ54f8bZpgT+xEBYvxwMUghZd5aEPt64+hW+yFcj1rVToQrPtsQtPBiojORHAsBZRjDidSgqdefHQaGzs4SYukBI6K5cpdRQFeKGF13TwmLKmC/KYOH7Zt3V2/S8lvCeaIfaZUl3OPI4I/gWIi2+7UgCNlkE3orohuls7b8k1kr3vqPUS4llpD0XSHVKHbKW3ByfgiP9vlg2O5Kq0N+RF1Pg6Fwg3SuF9p1Heqx6IhbgngYZzagSRPcW1kYn0/1OmkmxkCtD6nKhFzg5CdFLgNCk2pwwpo7xf7KMWj/JBWClrFHP9OlvkpvkDVpG/V/mDU/5geYbb/IAy5CEKfV4NJEGGXNzzb4UCehxSNUEGeqAHkAwHnpU30dbNR6mi6uZqH0+8x13XngEmZOC1ppvc7Zc6tTJ59bGLbNCWhyXuHPPIX29rk4ZKra3WuGBBxxY91Lj2eJmz9esbGoS0SrcRn2RxPGTZvEhXWY/KlPEuo9iM3Ag+fbhDWy/kMb4nv294WkHCr7CuHM15hSS9gnIy86FItCAUO+/1pkgfWXAjasWaE2Z9Dt6Obp X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(136003)(346002)(451199015)(40470700004)(36840700001)(46966006)(356005)(40480700001)(81166007)(36756003)(40460700003)(8676002)(86362001)(82310400005)(41300700001)(26005)(70206006)(4326008)(70586007)(2616005)(186003)(8936002)(5660300002)(44832011)(336012)(478600001)(1076003)(7696005)(54906003)(6666004)(6916009)(36860700001)(316002)(82740400003)(2906002)(426003)(47076005)(83380400001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6437 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2d072631-f53e-4853-8683-08dabe4c7fa2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k20gR+J7k7Y17cHvbRcEt+sWUyet6eaCcgeg2Uf4mJx6CGO4jailjE3E4Ejsz57AFJ0OJq8Iu5Es6s0jTsABVeju8fpqYLUwaWcCTMklYJ+0OV9uhW3IkM+ehjOi2RJCkSOzViECysAn0gmnI64dq1Su4Z15uMIA/x2/GttGZCLyleKgTqCSC4ebbGgfRqchX+zU25EXOxF4uneej+4tEeEbfm/eUBGUpXxFRR6X00LATvvYLCNUNV1E+jBANxgWpFjqAJvn5LObbdO5p0bVQsCWlr5KClUYhfvmDyq3EdWoq4hiIOBM/cfHFM7JRV89Q2KXigc5pJACSpitqGmBBZ/xop4t0LbB4MV6PG3GqWVnKvJh6UNOf9mUzgUXEWfHi156SKHvxi6i4Lu7bXU85pkV4ssp1czU06TP5GtvPwD94vGKGppL29db3/RHjwfEuh8zkSHoM0ro/szgxlL7d8PgEuPt5hbjsFSMqZauqjUj5f92eTq1ctZ6aMo77bUoFFO7dQylb0XKuBu1o7zdAEUHnHZIPqaOfDo7J+k1pgAV5syHwrForsy+49kDDDA0WwEZH5YPePOA0Bvno7OC8KiorsLIhZCPjZzikqnMmZng9rHbedhLepA79tfRYxmErwgwrqMMAwDgnWexk1bj9+WWGDLQF5ZV4fZ9szerifP6NCI+HRaOHfQiItbAH/4mjl+G1G5SursabX0Pmsr8A+Cj87rrYQKr2Ay0xqyVJwz1EuTE91J6D8trw85h+X6sMOBBcvftBu8x79NPSAG+Sg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(346002)(451199015)(40470700004)(36840700001)(46966006)(54906003)(8676002)(70586007)(4326008)(70206006)(8936002)(6916009)(316002)(81166007)(41300700001)(40480700001)(47076005)(44832011)(26005)(107886003)(2616005)(6666004)(40460700003)(7696005)(5660300002)(82310400005)(478600001)(82740400003)(83380400001)(36756003)(426003)(1076003)(186003)(86362001)(2906002)(336012)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:08:28.9674 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 169d4642-7c36-446c-35ac-08dabe4c8551 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9716 Current EFI boot services support of Arm64 could not work well for Armv8-R64 system that only has MPU in EL2. That is because EFI boot services may need some relocation support or partial PIE/PIC support. But these will not be supported in the initial stage of porting Xen to MPU systems. So in this patch, we disable EFI boot services support for Arm MPU systems. Signed-off-by: Wei Chen --- xen/arch/arm/Kconfig | 2 +- xen/arch/arm/arm64/head.S | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 1fe5faf847..ad592367bd 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -7,7 +7,7 @@ config ARM_64 def_bool y depends on !ARM_32 select 64BIT - select ARM_EFI + select ARM_EFI if !HAS_MPU select HAS_FAST_MULTIPLY config ARM diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index ad014716db..ccedf20dc7 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -172,8 +172,10 @@ efi_head: .byte 0x52 .byte 0x4d .byte 0x64 - .long pe_header - efi_head /* Offset to the PE header. */ - +#ifndef CONFIG_ARM_EFI + .long 0 /* 0 means no PE header. */ +#else + .long pe_header - efi_head /* Offset to the PE header. */ /* * Add the PE/COFF header to the file. The address of this header * is at offset 0x3c in the file, and is part of Linux "Image" @@ -279,6 +281,8 @@ section_table: .short 0 /* NumberOfLineNumbers (0 for executables) */ .long 0xe0500020 /* Characteristics (section flags) */ .align 5 +#endif /* CONFIG_ARM_EFI */ + real_start: /* BSS should be zeroed when booting without EFI */ mov x26, #0 /* x26 := skip_zero_bss */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:08:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437424.691830 (Exim 4.92) (envelope-from ) id 1oqtcs-00038Y-AV; Fri, 04 Nov 2022 10:08:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437424.691830; Fri, 04 Nov 2022 10:08:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtcs-00038J-6A; Fri, 04 Nov 2022 10:08:38 +0000 Received: by outflank-mailman (input) for mailman id 437424; Fri, 04 Nov 2022 10:08:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtcq-0001vd-Nv for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:08:36 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2069.outbound.protection.outlook.com [40.107.105.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a507b180-5c28-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 11:08:35 +0100 (CET) Received: from AS9PR07CA0004.eurprd07.prod.outlook.com (2603:10a6:20b:46c::14) by VI1PR08MB5375.eurprd08.prod.outlook.com (2603:10a6:803:130::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 10:08:32 +0000 Received: from AM7EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46c:cafe::44) by AS9PR07CA0004.outlook.office365.com (2603:10a6:20b:46c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8 via Frontend Transport; Fri, 4 Nov 2022 10:08:32 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT029.mail.protection.outlook.com (100.127.140.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:31 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Fri, 04 Nov 2022 10:08:31 +0000 Received: from 7924ad5a5fe0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5BD9A308-DE6C-44FA-B7FE-8633549C9490.1; Fri, 04 Nov 2022 10:08:24 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7924ad5a5fe0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 10:08:24 +0000 Received: from DU2PR04CA0284.eurprd04.prod.outlook.com (2603:10a6:10:28c::19) by AM0PR08MB5522.eurprd08.prod.outlook.com (2603:10a6:208:18c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 10:08:21 +0000 Received: from DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28c:cafe::88) by DU2PR04CA0284.outlook.office365.com (2603:10a6:10:28c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:21 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT052.mail.protection.outlook.com (100.127.142.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:21 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:19 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 4 Nov 2022 10:08:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a507b180-5c28-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TfByFkQGrSdhPJG24VveoaKZgpx0sU9JD+bARs8qaKgPBIY3qQZhIOmlldLqGoYI6+bQEvtob+o07JOs9n1mOBi5joSgPwt3Sarn5d8iFPUGXZxs1UnQ/DBMSzc7k+053tg6Il9l20hEbS1TfCZ4dnidbK9nnMegSC0JKyuD8GJLiFQqiNVbDzeSKQGPz4zEkPt3ac8nw3CvSr/Ne9MqEWj6E4bhtRA/RPGa/3vQsf6Jfs6izPJIpKn7HttlvtgbqxPIsFRPPOfTFe/FTkJRzalt7zIhAr2/QeOg2qfiC/p9f2m0quyUV/86HAtZ1M3+VI3LqqKCHgLGN3FLUfXw+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oCd70HB+Ye/vhd/9W0lE5d6TeJM/wcz47Dx4Zx5CnmE=; b=AdOTaDZb0/rrzdMse5C1z5teK1mlWSvgHipDoGUrPd6QqPLO8PEr56hKi5J/BGNI2sHeQk9gFWpmAIlvMFb4o0SLUpE72GskLLNoZNICM5/idsymfJSiVwWQU+ZDib3HIJVIGbXPK1S/qVvitEYz8E8zZnL15bwljFo/ymXixZxDxmm/Dip2VKGnSpgCFmK6I+a2dzY5/byXMV3UNjpBmINSvy9b/UXLInsIa95oj8reVvhoRvp+ut+eyky/YZ5/DyWLbVjDSKART1VTW3XoUR9L52SPuwQCOvjE5gufMGXfSDq0TC54yqbAcMsDmOw9R6xDH3j67MOfWaTdBLocNw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oCd70HB+Ye/vhd/9W0lE5d6TeJM/wcz47Dx4Zx5CnmE=; b=c7jCFSUVDNU02gs9JkeXhb6tBJmG/FGIz4IFQFpdzr+QCrgbvoR0trvFgn32JsUamtE5b/koZdTQRfJqLiTrFiXSEGv438ikiVP3mBJvRD7duUx70zOkq4+xTgF22Lk0nN5LkwwLclu7D/+gmQuA4C9d+WxMi6LF1klECt73aNk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: dec930ebccc60966 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W8Rztg9IsZ9E3yxJb884z+TenrY4rlNBpNuHeNHncZuF53UmgF3KqDqIeehbLMKmEN25yqfp2aO8P8qHFEGZObP3k+8OvigxGYfBgk+IOq+8nkngcgGXYm1DgfUk06p8O51778NSuf8Gh9TITqVoFL3Qhqc0QAB8kIdZADYPgTm2rA9761PciVSN1kyZMhN/XHJ0ENXFWBv3tuvvV9wLUh1glOFU5aYzeC4fKZpGsZSASYM+GNGbzfuw7ViNEcjgYhmB/oAJG319Xt69PKM08EFsT2HtYy5905hN459WxPYbXv/xPJUAlaCDzhk3dyAX/IgKttaLgr498T58qsKIeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oCd70HB+Ye/vhd/9W0lE5d6TeJM/wcz47Dx4Zx5CnmE=; b=ZIZ3Db7AGfWuzjcQq38Hpk1UYpCkJd/HJh/+HmZjZiQFF2qOWEmzkCCFwhzyo1Ok97M0ou4KmfHGTrAm1CflLicmSWbjl8vvXU6mx7t93RpcsqNRP1aH0viN3bldfusH27XKkJ4POA+GOGPh/fSZjn5czHuHYA40RUZvYlD59Hv4bhcFNdWGfXViUKTfoEBtyjkuntIz6odbp1wG6xgPgN+2z6zUE89COR9/JLFX7jXWUI4BcmQ5eaqQLc/B8eOEdtsH22eoVda4A0Swd7SK0lvmuHxc+1cSv/oqxE43F2m7RpbQFDJ8f6bmAWV1WGHKblEMDyYN4WnJfgNrl8JnPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oCd70HB+Ye/vhd/9W0lE5d6TeJM/wcz47Dx4Zx5CnmE=; b=c7jCFSUVDNU02gs9JkeXhb6tBJmG/FGIz4IFQFpdzr+QCrgbvoR0trvFgn32JsUamtE5b/koZdTQRfJqLiTrFiXSEGv438ikiVP3mBJvRD7duUx70zOkq4+xTgF22Lk0nN5LkwwLclu7D/+gmQuA4C9d+WxMi6LF1klECt73aNk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v6 04/11] xen/arm: adjust Xen TLB helpers for Armv8-R64 PMSA Date: Fri, 4 Nov 2022 18:07:34 +0800 Message-ID: <20221104100741.2176307-5-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221104100741.2176307-1-wei.chen@arm.com> References: <20221104100741.2176307-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT052:EE_|AM0PR08MB5522:EE_|AM7EUR03FT029:EE_|VI1PR08MB5375:EE_ X-MS-Office365-Filtering-Correlation-Id: fa237cae-570c-42c6-d5bb-08dabe4c8714 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 52V1vIbZmYLVBrv5egf7M+GbZZrGJrnIV33m03ena2tSfgVqqqHYcf43koFBeaBHBk6ch10RzRo40eUDYjVvCHYmbGLDzaZgVAz4WX4MNyIf+Yfg2whTa2OrMoII5JlMoqaoqiwR/LI0T+PD/NM2H3+qwL6Y9V1eqRRL7rC4Zr7Vzyxb3alxZt7D3OP7PLTJS6ZtUTuQSiOijs1kKVNCbZgZ7Ksqf9wjj5mmuFzs8ILG2ucumc1PuipHKHIX+ib2e9fQHOaH9Ot3lMJ5cuYK0j29wx89cnUcM11rbqlHEI+9eJevI7sGqFzmQdOGizSGBReoPVDeIFfoyGgZH2s0TZeH/PpBLu5DbooQDHX8KjnOlEJJNFhDG3LmETbc9M6nBPR+kizCmMbGqooQqFZ1EQVSIbzXvcRuUdcf/DkgpBqfdTX77h6uOz1dc4bVqOtQ9EyfUhcW5RLYbx2wSdIXYWEGKYWXuhCqY+n0cHJCSEfHuFGQAepzsRLmWxxauGDpeStJWXolxzgEvYYVEBYa3VL/XrxalaiX1LEqtUusHHgAgj1WlncXZaaXuy9c4ALx5KGg7q47qQrS82Y6A61vOj6FHkd5XV9/vfE0rn7dplkLNf7nbtD7azIYJqxU2/MJHbvWxklq5uShJmqHAtlgO+aUNQDMmdSW2BXjHbon+qcfCaHcMvNH1ywn0lWLMh7lXfQU6K8+7GvSdYLWiIZGktJCaZID1+ZRnlYkv5aTzDv76PExl0RG9hP9zQNmN9D+b8yl8P9t59CPOHh9qYDg48dk1oV2MkZSRV9aBPgG7Sp1+wITUYc0Yrm5y0gnL9aAoUMrXxBg8mTfsY09bdSGEg== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(136003)(396003)(451199015)(40470700004)(36840700001)(46966006)(4326008)(8676002)(26005)(70206006)(70586007)(6916009)(316002)(54906003)(36756003)(6666004)(8936002)(41300700001)(966005)(478600001)(86362001)(7696005)(47076005)(44832011)(5660300002)(1076003)(356005)(81166007)(186003)(82740400003)(82310400005)(83380400001)(426003)(40480700001)(40460700003)(336012)(36860700001)(2616005)(2906002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5522 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9e5de0fb-20be-46dc-a718-08dabe4c80e2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HKg+hDu5UZfwir/UWdIkkonTpDbs61aYS/ZtvJ9bpwC7vWYA6fOAhQuM8jK5f24W/RyjyYTq5HIPRBA2hUMbYUBAr8EklgUTQULEvgoZ2cgqQziE5y1xNeBxkOt71eOLSjiBe8WYSHaxQ9GcvIRddxGLY5p+Zd34rI+DqL7zKwEtR2ftzwKhJnrpJqUdVB/b1BaIY9wG7JsvOTTsBol+M2jrUyfeJ2dGTcy+/Td+P9zLMNiJri1Nr2cgU5gOUcTfC5Yo0/30E7VmBn9Qnp0ag9O2ujadyWn3wMKjjFRSMkPQMoVLnDtd3b71API6qPS+QOCDl5iY/46VNrfXLpxqmOMAaJLWxVgnFRqRberZ0QRvlrZdH3DYnNQHqXhsXFnrc0UwFmIJELbw9OxinJmGr7zmvaMIzSeBbnNbDjUYORM1DZTAJJlkICIpDRW9QkUUiY901ytxDZNQbpr3IX95oHGXxEfoppjf4sja455ARpZvutaxo6pfy8ylrEq9wMG3dwAPJeAogpQA/x3qQS1bUWMgNBj1IEcNMClmZKhnxYEvgCxRRUPgSJuDSOG04JXgUTOCJjNkIHZdmlzYpU79rjUB1uXy9Ys4WI31zB+OAsmOglcA5gNzFQl2TBmoybXEwCzyV9eJV2y5UHmg440Jsu+77hUf6TfgpkTmRAXwpGtizRjzrr4VtT0PZfa7Y23rSaKnMaKiWRfQa9DLffV+XO81j+BbwrLYFnwKLetNcbDEbLJi6LwMSvOzZY/Z5Hwy54n7axJBjROCdLrmhzYux8clW2GGLhkjCISPidkuMpUYe0/vTD7NoY8Fvza8R7sS X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199015)(46966006)(36840700001)(40470700004)(81166007)(82310400005)(40460700003)(36756003)(40480700001)(86362001)(82740400003)(41300700001)(26005)(8676002)(70206006)(70586007)(4326008)(186003)(1076003)(2616005)(44832011)(336012)(8936002)(5660300002)(966005)(7696005)(6916009)(478600001)(107886003)(6666004)(316002)(36860700001)(54906003)(426003)(83380400001)(47076005)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:08:31.7084 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa237cae-570c-42c6-d5bb-08dabe4c8714 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5375 >From Arm ARM Supplement of Armv8-R AArch64 (DDI 0600A) [1], section D1.6.2 TLB maintenance instructions. We know that Armv8-R AArch64 permits an implementation to cache stage 1 VMSAv8-64 and stage 2 PMSAv8-64 attributes as a common entry for the Secure EL1&0 translation regime. But for Xen itself, it's running with stage 1 PMSAv8-64 on Armv8-R AArch64. The EL2 MPU updates for stage1 PMSAv8-64 will not be cached in TLB entries. So we don't need any TLB invalidation for Xen itself in EL2. So in this patch, we use empty macros to stub Xen TLB helpers for MPU system (PMSA), but still keep the Guest TLB helpers. Because when a guest running in EL1 with VMSAv8-64 (MMU), guest TLB invalidation is still needed. But we need some policy to distinguish MPU and MMU guest, this will be done in guest support of Armv8-R64 later. [1] https://developer.arm.com/documentation/ddi0600/ac Signed-off-by: Wei Chen --- xen/arch/arm/include/asm/arm64/flushtlb.h | 25 +++++++++++++++++++++++ xen/arch/arm/include/asm/flushtlb.h | 22 ++++++++++++++++++++ 2 files changed, 47 insertions(+) diff --git a/xen/arch/arm/include/asm/arm64/flushtlb.h b/xen/arch/arm/include/asm/arm64/flushtlb.h index 7c54315187..fe445f6831 100644 --- a/xen/arch/arm/include/asm/arm64/flushtlb.h +++ b/xen/arch/arm/include/asm/arm64/flushtlb.h @@ -51,6 +51,8 @@ TLB_HELPER(flush_all_guests_tlb_local, alle1); /* Flush innershareable TLBs, all VMIDs, non-hypervisor mode */ TLB_HELPER(flush_all_guests_tlb, alle1is); +#ifndef CONFIG_HAS_MPU + /* Flush all hypervisor mappings from the TLB of the local processor. */ TLB_HELPER(flush_xen_tlb_local, alle2); @@ -66,6 +68,29 @@ static inline void __flush_xen_tlb_one(vaddr_t va) asm volatile("tlbi vae2is, %0;" : : "r" (va>>PAGE_SHIFT) : "memory"); } +#else + +/* + * When Xen is running with stage 1 PMSAv8-64 on MPU systems. The EL2 MPU + * updates for stage1 PMSAv8-64 will not be cached in TLB entries. So we + * don't need any TLB invalidation for Xen itself in EL2. See Arm ARM + * Supplement of Armv8-R AArch64 (DDI 0600A), section D1.6.2 TLB maintenance + * instructions for more details. + */ +static inline void flush_xen_tlb_local(void) +{ +} + +static inline void __flush_xen_tlb_one_local(vaddr_t va) +{ +} + +static inline void __flush_xen_tlb_one(vaddr_t va) +{ +} + +#endif /* CONFIG_HAS_MPU */ + #endif /* __ASM_ARM_ARM64_FLUSHTLB_H__ */ /* * Local variables: diff --git a/xen/arch/arm/include/asm/flushtlb.h b/xen/arch/arm/include/asm/flushtlb.h index 125a141975..4b8bf65281 100644 --- a/xen/arch/arm/include/asm/flushtlb.h +++ b/xen/arch/arm/include/asm/flushtlb.h @@ -28,6 +28,7 @@ static inline void page_set_tlbflush_timestamp(struct page_info *page) /* Flush specified CPUs' TLBs */ void arch_flush_tlb_mask(const cpumask_t *mask); +#ifndef CONFIG_HAS_MPU /* * Flush a range of VA's hypervisor mappings from the TLB of the local * processor. @@ -66,6 +67,27 @@ static inline void flush_xen_tlb_range_va(vaddr_t va, isb(); } +#else + +/* + * When Xen is running with stage 1 PMSAv8-64 on MPU systems. The EL2 MPU + * updates for stage1 PMSAv8-64 will not be cached in TLB entries. So we + * don't need any TLB invalidation for Xen itself in EL2. See Arm ARM + * Supplement of Armv8-R AArch64 (DDI 0600A), section D1.6.2 TLB maintenance + * instructions for more details. + */ +static inline void flush_xen_tlb_range_va_local(vaddr_t va, + unsigned long size) +{ +} + +static inline void flush_xen_tlb_range_va(vaddr_t va, + unsigned long size) +{ +} + +#endif /* CONFIG_HAS_MPU */ + #endif /* __ASM_ARM_FLUSHTLB_H__ */ /* * Local variables: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:08:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:08:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437425.691840 (Exim 4.92) (envelope-from ) id 1oqtct-0003QZ-Me; Fri, 04 Nov 2022 10:08:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437425.691840; Fri, 04 Nov 2022 10:08:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtct-0003Pj-J4; Fri, 04 Nov 2022 10:08:39 +0000 Received: by outflank-mailman (input) for mailman id 437425; Fri, 04 Nov 2022 10:08:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtcs-0002Y7-H7 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:08:38 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2078.outbound.protection.outlook.com [40.107.104.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a5ffaa44-5c28-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 11:08:37 +0100 (CET) Received: from AS8PR04CA0009.eurprd04.prod.outlook.com (2603:10a6:20b:310::14) by AM9PR08MB6290.eurprd08.prod.outlook.com (2603:10a6:20b:2d5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 10:08:34 +0000 Received: from AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:310:cafe::8d) by AS8PR04CA0009.outlook.office365.com (2603:10a6:20b:310::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT016.mail.protection.outlook.com (100.127.140.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:34 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Fri, 04 Nov 2022 10:08:34 +0000 Received: from 8f84a1913189.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 60168D8F-1A97-4CB8-89BE-D22AC04BAE0F.1; Fri, 04 Nov 2022 10:08:26 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8f84a1913189.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 10:08:26 +0000 Received: from DU2PR04CA0293.eurprd04.prod.outlook.com (2603:10a6:10:28c::28) by AM8PR08MB6625.eurprd08.prod.outlook.com (2603:10a6:20b:357::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 10:08:25 +0000 Received: from DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28c:cafe::f7) by DU2PR04CA0293.outlook.office365.com (2603:10a6:10:28c::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:25 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT052.mail.protection.outlook.com (100.127.142.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:25 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:22 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 4 Nov 2022 10:08:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5ffaa44-5c28-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mZGKPaCnTQ1vhG7A/dG8/YoQhSII2/mrNKUNrxWEFQDCDtLxWie9vJ5oG0XcSRiLpEyPGWYoUujZmjFUVWF95sXSJcxPxYat+qCpW5f16Puo85DfuuXrsHdE9oicLMeAvgdG0Fy6EgF84KfWcMsDujU+Zw2tN0cpRg/lsUX8fCIylvBMbgRmQrmBuVjKV6coMYLsHjBlmFX1PRTPjgHWauYiT+6pPTKGAja/02rveRoCRyiEaLuo3/A/sxVfMkmxOILvA3VaIbrNrwFX7Inna9rgoknLCFdWdG5Zyh8rI3gQ1HJTVAPt2GZzmrJd/vnNpNyMv/PQODI98oSLHde6Tg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c83sPn5waglt7AsZTsybdIkX6p9bIApiwcHQJUpCiHU=; b=OIQbVMba5Cdi42TdiUIitbOeW2LuH4HdVXuic81y02gdX12se7obqllaHnS3AAAJpbtxRVpybYrWT1oMRX/ToEv4FWaZfs5RhtMsbMlik7TqcdEg3y8TmTVF+fwQ9PK1kje3r20G0iygwGrHrDXxxV0DsiesTWznkMuZZzgiZTqOKrLGwZN9i72vHTBPDq8OZ1jsuUcwEUy8UJ/OF+wVkJtorxKyMchYpPqngPiIQKpJcJl4Ner/bFInXN0vpeZDET9C4GL1KCsG30m1vmQ6jvAd5V6HATdbAQ8h7kY4LZrKMAjkGmPMlzD+dqIYbmSle/ZOWCy9GVSvZBTOYZ2PLA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c83sPn5waglt7AsZTsybdIkX6p9bIApiwcHQJUpCiHU=; b=BOjmomYT5kfex0Zw7CongWBk22a4EYUKvxfDJXPiwsiWNep8wM2NbeWRkqaO30Bh5jRnmukNnHnWFCIir/WV+hPlCGvMFoMnHbC/Mmu1wc+7BSGKftFtcSYtI2U28cPo5ecYJKe+Q/AJh4afVvUNJLA++Z4NpwYV6kPxf0f9srQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f282e67ff45f34cd X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GYJUt2LLR4GT62crYVzvdmvWP2Dt/5qknnC+LjR1PO0V8jPNJR96WTltiNqxHldBsQ3rXV3DQBJR9le0P7kDqCxnpnyEtkYUa8LuPYCfJUuO1AWxMRwGk4TLHczivVXkNw2roTEKdAnvVXj3Q8sG+PWgPvOeSoULM8AWa0htZtI2os/Aj7p9am3XjRRTj8uSkbbV5Qf23ox2E9a+43aBj5FpYBPvUi/yyz7F1Y1AdWpvQkKRzGseEnfr4PIJ0+RtyQ4nCXTfatsFbtOANGXonNBK5ruYZiy7q8HsEc9vqmpq0oTFihcWPfiyksKgb4L6ZWtiBzjxvD8HgAdpRVHsRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c83sPn5waglt7AsZTsybdIkX6p9bIApiwcHQJUpCiHU=; b=JLt9yKjsTeWz62ETNaQBlLHAIwtnbKzytXrn5aYFhzUTj3NsGV47bUuNKBhZaoeHbk8Dy7kbPbeQkXhnwXxn4PlmtQ5yp/1PtOCIiM9rcxpL1K4SNbDOyMu+kICIb3toZDotnBEYY+WhzzsUCUw0XA/fU6xR4RHH9ICIoPm+fyXZ/HMCGWCV6ICUTTQmyimKFA+fvQDYMRKNE9BW/BJf6ixOWdg0vX+cSjTZyF0SRBAErFrcYN/5DFYCo7p7YbYI0Gy6ejdUj5OctgzhckzqcNMuPlDKBkcr+Gmq8gDm5vC+fyQQTfo1vNBwPDPA4O/Ftz2o0IxtmMQWicBpp5O27A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c83sPn5waglt7AsZTsybdIkX6p9bIApiwcHQJUpCiHU=; b=BOjmomYT5kfex0Zw7CongWBk22a4EYUKvxfDJXPiwsiWNep8wM2NbeWRkqaO30Bh5jRnmukNnHnWFCIir/WV+hPlCGvMFoMnHbC/Mmu1wc+7BSGKftFtcSYtI2U28cPo5ecYJKe+Q/AJh4afVvUNJLA++Z4NpwYV6kPxf0f9srQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , "Jiamei . Xie" Subject: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform Date: Fri, 4 Nov 2022 18:07:35 +0800 Message-ID: <20221104100741.2176307-6-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221104100741.2176307-1-wei.chen@arm.com> References: <20221104100741.2176307-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT052:EE_|AM8PR08MB6625:EE_|AM7EUR03FT016:EE_|AM9PR08MB6290:EE_ X-MS-Office365-Filtering-Correlation-Id: e964fb75-088f-4d55-d02d-08dabe4c88a4 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bLT+mUdP00z4e1w4SDyK1mGpcABic/E8OlPFhZTAoLxpxhSlAUqiXmHz88uYzrStFZsu17+ulICo32L5neteH4s5Rajnk9Y1zaBU4GXBgom3YN6R6tlkqqfGXQptu8nTqpUkbIeA79QG/bFA1jaqI9YBP4n5vMcDIfIYrjCaLTgutMBDZDFxqkZCtSM0ZhrhGQlffO+iLI4RwB4jRRDcROJ0fJQkqAIvib9qln1DxwBT40tY2VB+10aHMunXipKcu4rxyHqK6V1dP59TzX08cjjkcwB2JyUzBtgmqem1cAArb7Q5f+a4MaELzvpXMW3KsS6pIg+8t+FKCcbVuK+tzrN/R6l5sXB5xKNvBR6l0EW8vtNjztLBxCWfhsiChJvCuudAeqOasdR/naOpctDuFfF51xrVmo//HuYpBqpQ1blk6mTclWw9RWBxq+8owUF9Ve2fduGf6lbAESLIZ8x+9oekRejM2CbLV0VYPB7c584LMy+P9oufidxzOgCq5SKq31UcR2+FI8BMqE+GM5CWoS7zz7oRgEjEsjt1dpo18d47vA4vJ4spvMHcF8GO38oGWtFJUBMT55wcNwH/MMXusbzwpQAc/ilIKrAOJ8Z8t3cVL/Nk5SOtbDb+qcdaGBceXNemD8Fi1T/EX7/2KeUYUEKhxA6sAgME3vZX/ti6SBAGps0LjlVC2KpoTU/irFnhc2RoA/Bh/lwEkje0uOoD6bRUU6fcjNzXPIsSHcirlRAxq3a/DHS8+K6YW/CKOxKaL+vev/bMRPPqQqKpFEX/gWKNpAbBZeEKhPJ2lMlD5iQ46PrianQ2u416yhZH6db/ X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(376002)(136003)(451199015)(36840700001)(40470700004)(46966006)(426003)(336012)(36860700001)(86362001)(36756003)(356005)(81166007)(82740400003)(83380400001)(47076005)(1076003)(7696005)(26005)(6666004)(478600001)(6916009)(54906003)(70586007)(4326008)(70206006)(41300700001)(8676002)(316002)(44832011)(2906002)(5660300002)(8936002)(186003)(82310400005)(2616005)(40480700001)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6625 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7a229894-52fa-4d08-452f-08dabe4c8334 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gYZ0FhS1PzsfWPBS4Gbgve6nNG/O5e48GX+zgeiVC2JBp3TpeM8DAr5qmxgot+uJF3XUlVp1gMbUFergOgtbE6jTY2tbRRR2mUKLXl5tYeevyCKYoj2SS2kRIxoMUDHH7pUaH0AcP9R6+hWxPuM4qCpc2+eGjLb2ihXhGc6GElZjXG7LShtUJsPW3xErSI2asLlfTBvwpmT1vTYS/gOOWkrC1HrCdqKBmjtDJXyoXJXSQGK/CfeXSQjpx8EHLqnRXFK7T1kFVTXJzdPmuKXs/Q5fed8+Jxz2R5S3+P3OuM69y1wCVBpLDJGTezi0tiG0bFFx+IrlwdWD+p5b5RkgeDDX7+sMJgqnldj9R/V3Wi95wmioIjZB3RE7FTeqrcO94H9/Sc1qbXBJfLpUSp0oz4VW+OLtsPs6Ql5r6AqPt0XYX0nki6kXtyrm71OV6DphDm31oJn1dU2s2muk/Ul1D0DiFyXjqdzsT1JPM7JKiwHJk4LCbz6flAlSeP6a4zjAbvCUIyddwjgSs8c2Eswm3P1IvMr0CXcNY6iVvJhMT+BlyHurvCFz4j/JgZDtJ+EjCbd/iuaKGwPpns0+f9KM/Og7JywUegg2UyYri5uQ9wScA7ybGcvLHGEDjunfg6LVIeSBaOyjy5xqPzeljmttfFxUS+D2qXiABZvLNInN7t6Pnli2L8fAV/G/5YmpyzKt3zrB/xCtNgDMQ602i73GvGWlBOrzwHplKHfBdEKVXq9iMGKjM0oQC5BpUV0Af9BHIBnactqxUykhLeP1fC5wUQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(39860400002)(346002)(451199015)(36840700001)(40470700004)(46966006)(81166007)(82740400003)(478600001)(36860700001)(82310400005)(44832011)(336012)(70586007)(1076003)(5660300002)(70206006)(186003)(40460700003)(4326008)(8676002)(2616005)(54906003)(83380400001)(6916009)(6666004)(7696005)(47076005)(426003)(86362001)(2906002)(36756003)(26005)(8936002)(41300700001)(316002)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:08:34.5016 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e964fb75-088f-4d55-d02d-08dabe4c88a4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6290 On Armv8-A, Xen has a fixed virtual start address (link address too) for all Armv8-A platforms. In an MMU based system, Xen can map its loaded address to this virtual start address. So, on Armv8-A platforms, the Xen start address does not need to be configurable. But on Armv8-R platforms, there is no MMU to map loaded address to a fixed virtual address and different platforms will have very different address space layout. So Xen cannot use a fixed physical address on MPU based system and need to have it configurable. So in this patch, we reuse the existing arm/platforms to store Armv8-R platforms' parameters. And `XEN_START_ADDRESS` is one kind of FVP BaseR platform's parameters. So we define default `XEN_START_ADDRESS` for FVP BaseR in its platform file. We also introduce one Kconfig option for users to override the default Xen start address of selected platform, if they think the default address doesn't suit their scenarios. For this Kconfig option, we use an unaligned address "0xffffffff" as the default value to indicate that users haven't used a customized Xen start address. And as we introduced Armv8-R platforms to Xen, that means the existed Arm64 platforms should not be listed in Armv8-R platform list, so we add !ARM_V8R dependency for these platforms. Signed-off-by: Wei Chen Signed-off-by: Jiamei.Xie --- xen/arch/arm/Kconfig | 11 +++++++++++ xen/arch/arm/include/asm/platforms/fvp_baser.h | 14 ++++++++++++++ xen/arch/arm/platforms/Kconfig | 16 +++++++++++++--- 3 files changed, 38 insertions(+), 3 deletions(-) create mode 100644 xen/arch/arm/include/asm/platforms/fvp_baser.h diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index ad592367bd..ac276307d6 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -138,6 +138,17 @@ config TEE This option enables generic TEE mediators support. It allows guests to access real TEE via one of TEE mediators implemented in XEN. +config XEN_START_ADDRESS + hex "Xen start address: keep default to use platform defined address" + default 0xFFFFFFFF + depends on HAS_MPU + help + This option allows to set the customized address at which Xen will be + linked on MPU systems. This address must be aligned to a page size. + Use 0xFFFFFFFF as the default value to indicate that user hasn't + customized this address, and Xen use use the default value that has + been defined in platform files. + source "arch/arm/tee/Kconfig" config STATIC_SHM diff --git a/xen/arch/arm/include/asm/platforms/fvp_baser.h b/xen/arch/arm/include/asm/platforms/fvp_baser.h new file mode 100644 index 0000000000..9450a411a9 --- /dev/null +++ b/xen/arch/arm/include/asm/platforms/fvp_baser.h @@ -0,0 +1,14 @@ +#ifndef __ASM_ARM_PLATFORMS_FVP_BASER_H__ +#define __ASM_ARM_PLATFORMS_FVP_BASER_H__ + +/* + * 0xFFFFFFFF indicates users haven't customized XEN_START_ADDRESS, + * we will use platform defined default address. + */ +#if CONFIG_XEN_START_ADDRESS == 0xFFFFFFFF +#define XEN_START_ADDRESS 0x200000 +#else +#define XEN_START_ADDRESS CONFIG_XEN_START_ADDRESS +#endif + +#endif /* __ASM_ARM_PLATFORMS_FVP_BASER_H__ */ diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig index c93a6b2756..0904793a0b 100644 --- a/xen/arch/arm/platforms/Kconfig +++ b/xen/arch/arm/platforms/Kconfig @@ -1,6 +1,7 @@ choice prompt "Platform Support" default ALL_PLAT + default FVP_BASER if ARM_V8R ---help--- Choose which hardware platform to enable in Xen. @@ -8,13 +9,14 @@ choice config ALL_PLAT bool "All Platforms" + depends on !ARM_V8R ---help--- Enable support for all available hardware platforms. It doesn't automatically select any of the related drivers. config QEMU bool "QEMU aarch virt machine support" - depends on ARM_64 + depends on ARM_64 && !ARM_V8R select GICV3 select HAS_PL011 ---help--- @@ -23,7 +25,7 @@ config QEMU config RCAR3 bool "Renesas RCar3 support" - depends on ARM_64 + depends on ARM_64 && !ARM_V8R select HAS_SCIF select IPMMU_VMSA ---help--- @@ -31,14 +33,22 @@ config RCAR3 config MPSOC bool "Xilinx Ultrascale+ MPSoC support" - depends on ARM_64 + depends on ARM_64 && !ARM_V8R select HAS_CADENCE_UART select ARM_SMMU ---help--- Enable all the required drivers for Xilinx Ultrascale+ MPSoC +config FVP_BASER + bool "Fixed Virtual Platform BaseR support" + depends on ARM_V8R + help + Enable platform specific configurations for Fixed Virtual + Platform BaseR + config NO_PLAT bool "No Platforms" + depends on !ARM_V8R ---help--- Do not enable specific support for any platform. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:08:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:08:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437429.691852 (Exim 4.92) (envelope-from ) id 1oqtd0-00047s-5F; Fri, 04 Nov 2022 10:08:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437429.691852; Fri, 04 Nov 2022 10:08:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtd0-00047h-1P; Fri, 04 Nov 2022 10:08:46 +0000 Received: by outflank-mailman (input) for mailman id 437429; Fri, 04 Nov 2022 10:08:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtcx-0001vd-Oq for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:08:44 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70058.outbound.protection.outlook.com [40.107.7.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a948a600-5c28-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 11:08:42 +0100 (CET) Received: from AS9PR06CA0663.eurprd06.prod.outlook.com (2603:10a6:20b:49c::8) by GV1PR08MB8179.eurprd08.prod.outlook.com (2603:10a6:150:91::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 10:08:40 +0000 Received: from AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49c:cafe::bc) by AS9PR06CA0663.outlook.office365.com (2603:10a6:20b:49c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 10:08:40 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT042.mail.protection.outlook.com (100.127.140.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:40 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Fri, 04 Nov 2022 10:08:40 +0000 Received: from 185689500ae9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1384B5F8-3F4A-4727-AA43-A3FE11203BCC.1; Fri, 04 Nov 2022 10:08:31 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 185689500ae9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 10:08:31 +0000 Received: from DU2PR04CA0271.eurprd04.prod.outlook.com (2603:10a6:10:28c::6) by PA4PR08MB7434.eurprd08.prod.outlook.com (2603:10a6:102:2a5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 10:08:30 +0000 Received: from DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28c:cafe::80) by DU2PR04CA0271.outlook.office365.com (2603:10a6:10:28c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 10:08:30 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT052.mail.protection.outlook.com (100.127.142.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:30 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:28 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 4 Nov 2022 10:08:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a948a600-5c28-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=E3y7J/HMCf1Ejhg7ofXqqSIpbXddQO5zmV4qsmgwTw1dcrkRwi1vm5XdOS5x4i7VY4YlunNEvu7q11boOgFXX8ChErHJSnZk2RY35I8cE/i2vnQPSFsZ8O7t69Fy0o3BNQ5gEI00Tbxq2DO3+ar42+S4pAImiyLcHcSEjCzhODL/yBuv4/WwAcGqTZqtzPEy+pdMA13sbvZ3bbO9UIsJJT+w3GfgJfgoyyfFty1eTzIpzSpgPR3QsbH5aZq7EB8aOfm/MzCCOmgwnmNKfLAbLvgCJxQAx91b7p6Hh6Y71YGC1/9KagJw225sdgNgdA05/a8tGMnUThEiZ/g7dzFFAw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZBjv5anLZDwEd2jLmxOkcveDVsYBDtYxSedDem5n/0U=; b=Vwi8cv6UKtUujdUwbkBDWI0SpqPG0fNX/HdutasVbWit25VhdKuwcF8rAcNfrRxxKJ1P7QUUidscegz/bJj98ORloy3bmMb+4WacN72G1B2pFQS3B1eIRrb+0Z3S1360s2MYUZs1G6ST5FXiRZnFktGbjLqxL1FtUUdsKhvAilxrLPTK9x/fNsGLBv46BeiT+aUqwe3WD251A2LRcEL2myNtiiPgs9kBplTsmRpIH8Mq5Askbm+k8YmjzhMI39QsgYJW3xW3MxzxcEUu/cwTxD+UcwhqdxubWuvpvf6HhnjTF6GDCD+DKARaaNd9Gpw9aSM9a2VZDOHSIT3QLvrBOA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZBjv5anLZDwEd2jLmxOkcveDVsYBDtYxSedDem5n/0U=; b=VEDHnTdP83AiyGDXT57aUiQD+MvpofIu0Ug62d9P3BDpuuMTVBdkaD/pA0n0y2F7muMxnEtD2b40jUHycQmmcc5QPiwsUjZXgSJfVod7xiwghv+Yb/TYD3LB/WXv1Nm+YO7UVbiMSVpZCN8iE+GwmIpwc3XyyqKwxV0ViCaNmDw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 496f1c33cf175052 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KymGxHlErzk+6DPD5M07tYLbuLxHcP9BnZf8DAQb7wBDVGBI/crpSFHNz6FFHJdf2k+xDv7mQH85Ev37rIkyuy3eTkBsPaGT4lAdk4diLODhGnWedO4kWL6K05mh66exWzxSa0aesIBbxEhcHl1jVGPWkKICOlKF0UB1v43x40JD5e7VrHctDEerqZ5iKjV+9wDlXbtTqtVXSvY9VJfpOuZL/1K9hRmtWjXQSegqklWlpxuM7jWzBi0SgUUj+6YXLE5GhJLL5fngrUqQJlIXDCxVIxKiv8L9k4WAanw0hwNsM/OFcy7WRXq6PJLV521C+tE6cIp/av39hkTXTNZyEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZBjv5anLZDwEd2jLmxOkcveDVsYBDtYxSedDem5n/0U=; b=XsBaiqa8FyEycZ7NNbjt4JVyuuk4nNDrsXPv/B6f9/718sN9/eYO+U79Wdra20A6Q65rbQz/Mgfgtpwux8jr45y5R7bV5oIYSrQdZKAuPmk+P4f65u88w5j6YCHpchqo3uYt57z5rRSI7aZw8/vbpabt5vrbPy12TW2ze1/X0uqvDZ8aQJQ6jZj3IRQV6O5Prn5Du7mUVYpTcjTkWfHtRA3VlmHbQmbSfJTgJOX7ePalohURb2ojGJv1SD0JDflZ5eTS3T3s+DZErY1+TdYrL2SJtOaL3uGMby1M0FaeFhKtv3SyPBk/YhUrck22s5VL66D4HkLWtFPPDXnB1yi3+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZBjv5anLZDwEd2jLmxOkcveDVsYBDtYxSedDem5n/0U=; b=VEDHnTdP83AiyGDXT57aUiQD+MvpofIu0Ug62d9P3BDpuuMTVBdkaD/pA0n0y2F7muMxnEtD2b40jUHycQmmcc5QPiwsUjZXgSJfVod7xiwghv+Yb/TYD3LB/WXv1Nm+YO7UVbiMSVpZCN8iE+GwmIpwc3XyyqKwxV0ViCaNmDw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v6 07/11] xen/arm: implement FIXMAP_ADDR for MPU systems Date: Fri, 4 Nov 2022 18:07:37 +0800 Message-ID: <20221104100741.2176307-8-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221104100741.2176307-1-wei.chen@arm.com> References: <20221104100741.2176307-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT052:EE_|PA4PR08MB7434:EE_|AM7EUR03FT042:EE_|GV1PR08MB8179:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b1f7ead-8183-49c6-8e95-08dabe4c8c09 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SDsgSV5MLhJSMBhVKO/b/g+CH6oIhhIn729JH6MXL6Vphlts7Pqyqe3Gj3hVCaGA2y49170DA0TpEuzdsCkM7YiV8Z4HyFYHQ7QLwuM6qkOA9W/92a7fnM0YMOeku3yYgMOrnlfrQa/EnI3z/1Sc0Kf+LUWLZnySUqkMQCnrNbnOboN30lWeNGKhgUC/D1tzFRHCemzibCdYCdlDP1wQ+iXoBu6YoYBskQD3kjLQfGRsJsA/xXQLLwStZuYwYesc3HO/D9GpkrQUWtcD8veOuGQdCkqP5m32AZNdvXCT0ygaKbE6N718SIxm50d3aH0S2CZaqlXYak8kSKF71n0NNfhe40XWDxHn4jHcQwTGeLDyyVcoQrraK0PxjmmS5Of61v4V/oWwFq7ndd7xH5qqEthq2PuyiKlEuvqVIeqzrS13Zzs6ues0CyjfyS+oPHSlze5dWWDRofqOfd5w1e0NOZch9q9DORBQO2FqjvoNlbTyKL1ouA+Jb488iMxKsT49O31cdTw5ECNSOb8Ot/qejXea/d4ZUwirrKehoXi5AhIMYTh0GC97VPHaIulD7V5O/nn0nAnfO6I6LOWwk4pdjSyrlMyHNNIXubTDhLHuiAqkOlIWPGiSV2ftxON44dTDwbQKESufuS2qJgp5Nuyo/7iTKPg2WHnCp6rrVQOuAnqYYHxivg4nZPj3yBiAly/EmQAq+sW0bDqdlDn7hqW2uhOw9SIU6pBj4bqlQo1P96KACdJE+JwruQ6rn67UWgwWHe9+gJABXm048uOjERa5gwNwZIxAPPziBvYmw8aT2V4BQgXJnAALVJeHq1pGhN0+ X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(39860400002)(396003)(451199015)(40470700004)(36840700001)(46966006)(47076005)(478600001)(426003)(316002)(336012)(44832011)(6666004)(70586007)(1076003)(70206006)(8676002)(40460700003)(2616005)(186003)(5660300002)(4326008)(36860700001)(2906002)(82310400005)(54906003)(6916009)(83380400001)(82740400003)(356005)(36756003)(41300700001)(81166007)(8936002)(7696005)(86362001)(40480700001)(26005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7434 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f5a47cea-336b-440a-247b-08dabe4c864e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g0Y0nXlOqze0vsQNXQSbzs8r0R7alu1FYzYf2C1qNZshUSauyWVeOBhvYBq04vQYId+0rMm5j4a1NT1QkaHuSGJqTog3i23s/NyI2Z5kmp2Gh5NOgNicoI8SKRs1SGgYGEdm8K6F/32VYeJatOV5FggIeiGu8E15FLl7Cya932PhOq86J5UXlE8e6VAimBj/UnsOOiDXTm0KoFJGurSpHGb8TcB49VWoLKi0WaftgV8o/YEAedYsnbN/3p1E1/NuNF3NkzW4dzn4PXP2XhISqZt+8KUdwde0lBOChsDOFJsZz38DBg/QKIfh+ai/jleA2iFNeieMjlmM3cIjzW5JHpgujgEUlAcT5WnCh3cOvl2Wehw2MEyavfwY73cnSPCEkkPSfmk4/xclTXCm3BKLjhjHt290GYb8FJt8bbqZNZCeRD46eaY/DPSKD+g4olPcYH0Wz2RAFlSO4lAvnW4SWsVFHQpKKHh/EcRm58RJHoKtcbfvzVDrIRS7PGOBv63HFwhWNIE8RzDLP0wH85NMMgxTS2Wk8ZCMwyawXJYlxQINWcYG8MmsQ6XxZB36+NPKgSKF92TsZSw492AWfchPrILanhemWYLpqvqGaAAKc4hOMOtc/hWP/40iwD7d30e3d99ljDoTKZEgAFyvfuY4H8gy+5SnQ3nMyfeczFsAHpe2n1sPdv3v5iumOA/ywTZ942wYxz54zOBMmfJXg85izzy2hRIpcnBP2M6PmbEMSfmkuFh9Fgun8PuUyz/C0PVRXk27YUU8zhpabt4CGb30jQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(136003)(346002)(451199015)(36840700001)(40470700004)(46966006)(36860700001)(86362001)(36756003)(81166007)(82740400003)(83380400001)(426003)(1076003)(6916009)(26005)(186003)(7696005)(6666004)(107886003)(478600001)(4326008)(8676002)(70586007)(41300700001)(8936002)(316002)(70206006)(47076005)(54906003)(5660300002)(44832011)(2906002)(40480700001)(336012)(2616005)(82310400005)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:08:40.2106 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b1f7ead-8183-49c6-8e95-08dabe4c8c09 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8179 FIXMAP is a special virtual address section for Xen to map some physical ram or device memory temporarily in initialization for MMU systems. FIXMAP_ADDR will return a virtual address by index for special purpose phys-to-virt mapping usage. For example, FIXMAP_ADDR(FIXMAP_CONSOLE) for early console mapping and FIXMAP_ADDR(FIXMAP_MISC) for copy_from_paddr. But in MPU systems, we can't map physical address to any virtual address. So we want the code that is using FIXMAP_ADDR to return the input physical address in MPU systems. So in MPU version, FIXMAP_ADDR will trim physical address to PAGE alignment. This will return an offset which is similar to MMU version FIXMAP_ADDR. But it's a physical offset got from input physical address, plus to an offset inside page (which is also got from physical address mask with PAGE_MASK). The caller can return the input physical address directly. As pmap depends on FIXAMP, so we disable pmap for Arm with MPU enabled systems. Signed-off-by: Wei Chen --- xen/arch/arm/Kconfig | 2 +- xen/arch/arm/include/asm/config_mpu.h | 2 ++ xen/arch/arm/include/asm/fixmap.h | 25 +++++++++++++++++++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index ac276307d6..1458ffa777 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -16,7 +16,7 @@ config ARM select HAS_DEVICE_TREE select HAS_PASSTHROUGH select HAS_PDX - select HAS_PMAP + select HAS_PMAP if !HAS_MPU select IOMMU_FORCE_PT_SHARE config ARCH_DEFCONFIG diff --git a/xen/arch/arm/include/asm/config_mpu.h b/xen/arch/arm/include/asm/config_mpu.h index 530abb8302..eee60dcffc 100644 --- a/xen/arch/arm/include/asm/config_mpu.h +++ b/xen/arch/arm/include/asm/config_mpu.h @@ -24,4 +24,6 @@ #define HYPERVISOR_VIRT_START XEN_VIRT_START +#define FIXMAP_ADDR(n) (_AT(paddr_t, n) & (PAGE_MASK)) + #endif /* __ARM_CONFIG_MPU_H__ */ diff --git a/xen/arch/arm/include/asm/fixmap.h b/xen/arch/arm/include/asm/fixmap.h index d0c9a52c8c..1e338759e9 100644 --- a/xen/arch/arm/include/asm/fixmap.h +++ b/xen/arch/arm/include/asm/fixmap.h @@ -7,6 +7,8 @@ #include #include +#ifndef CONFIG_HAS_MPU + /* Fixmap slots */ #define FIXMAP_CONSOLE 0 /* The primary UART */ #define FIXMAP_MISC 1 /* Ephemeral mappings of hardware */ @@ -45,4 +47,27 @@ static inline unsigned int virt_to_fix(vaddr_t vaddr) #endif /* __ASSEMBLY__ */ +#else + +/* + * FIXMAP_ADDR will trim physical address to PAGE alignment. + * This will return an offset which is similar to MMU version + * FIXMAP_ADDR. + * For example: + * EARLY_UART_VIRTUAL_ADDRESS is defined by: + * (FIXMAP_ADDR(FIXMAP_CONSOLE) + \ + * (CONFIG_EARLY_UART_BASE_ADDRESS & ~PAGE_MASK)) + * With MPU version FIXMAP_CONSOLE and FIXMAP_ADDR definitions, + * EARLY_UART_VIRTUAL_ADDRESS can be restore to + * CONFIG_EARLY_UART_BASE_ADDRESS. + * In this case, we don't need to use #ifdef MPU in the code + * where are using FIXMAP_ADDR to make them to use physical + * address explicitily. + */ +#ifdef CONFIG_EARLY_UART_BASE_ADDRESS +#define FIXMAP_CONSOLE CONFIG_EARLY_UART_BASE_ADDRESS +#endif + +#endif /* CONFIG_HAS_MPU */ + #endif /* __ASM_FIXMAP_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:08:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:08:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437430.691857 (Exim 4.92) (envelope-from ) id 1oqtd0-0004BH-IS; Fri, 04 Nov 2022 10:08:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437430.691857; Fri, 04 Nov 2022 10:08:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtd0-00049f-Br; Fri, 04 Nov 2022 10:08:46 +0000 Received: by outflank-mailman (input) for mailman id 437430; Fri, 04 Nov 2022 10:08:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtcy-0002Y7-JR for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:08:44 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2051.outbound.protection.outlook.com [40.107.20.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9834fb9-5c28-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 11:08:43 +0100 (CET) Received: from AM6P195CA0090.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::31) by AM7PR08MB5334.eurprd08.prod.outlook.com (2603:10a6:20b:10b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Fri, 4 Nov 2022 10:08:40 +0000 Received: from AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:86:cafe::2c) by AM6P195CA0090.outlook.office365.com (2603:10a6:209:86::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 10:08:40 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT036.mail.protection.outlook.com (100.127.140.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:40 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Fri, 04 Nov 2022 10:08:40 +0000 Received: from bd3c1988a2b2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F6494548-0940-46B1-A021-CBE7B3845746.1; Fri, 04 Nov 2022 10:08:32 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bd3c1988a2b2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 10:08:32 +0000 Received: from AM7PR02CA0014.eurprd02.prod.outlook.com (2603:10a6:20b:100::24) by AS8PR08MB6309.eurprd08.prod.outlook.com (2603:10a6:20b:29f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 10:08:31 +0000 Received: from AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:100:cafe::17) by AM7PR02CA0014.outlook.office365.com (2603:10a6:20b:100::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 10:08:31 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT009.mail.protection.outlook.com (100.127.140.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:31 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:25 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:25 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 4 Nov 2022 10:08:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9834fb9-5c28-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=SmjNVhBrY2a/N0QLeJvOfPZy9boen/jZdQihyW8iXtevQWMaxuBRx/3u9reilcDqn70nLXKFgC8TGDpeV9MF08Yob2y7k8oljRjP0b1TTk3vPE7ly7hos6r1YfBzaKrQPU2EkvWnVwkiKVtIDr8XU0goaTMvFwtWyaUFSyJq8TaaFN0ExXhqCRXQpEbHBiuF6FQF3LZ8asE5XJ0LiwKrMnt27eBoUo26m4NPhhTCie+5kLaAF0hojIxiomZbUmEPFKegXqSXxMPd8II2gjeYU5T1tdfyoEOI6AoHzMJwO+J/Xx1W38dH+uIZJndbnTM5dz2724bPE9lPrSTqkTc3Pg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QEGGe51xBf66cJ8lTCTtNdnFfG5UAX6eLZoV+aKMZdg=; b=i0im5/1eiFpjrX8O6Q6kWzlU/N2nHNgfeDS49PsppCeLv8r7MCggVaC1jHp75yRhhd3XoilHetT/vNCNXQts8gG8PGErbIaBVtPQksJ4G5xpXFAAbi/s8pNR9isEUaALzbVzv4yQCVD8WUvLposQGcE7kG3vpcKJpw51KRXIWLWekntKJOvz5CuDKUesvob14Abx1df7LNqPyd4h6YoPOJPUODGXAys3RulnKeYli/1hK4lj9Tn0UHyHwB7GPXqzGPCZrSxx9qwwyS0+k0bV3haBq4BKat0MYLJf5i5+Xw5sxsd32Lv+uNZ2lOfgDFkJ2IoQHoaJb01RDuIueJlcPQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QEGGe51xBf66cJ8lTCTtNdnFfG5UAX6eLZoV+aKMZdg=; b=Vq/14ZXGpx79NVs+UcDyjqwC1P6tohGTJzwMNaFQ2tYctUc9JTV0xgWxjTVTIY8loN1kx5v5wC8Q+/mRKv9W8pFIesqsTEuPCprNBY03opSzBDU72ntkwFe0oaFjwvAxjwiyatNZVtBFdFxQzDwwTyoGSedyJVUOvzZtF0YoDkU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 322a1d7af70cd862 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CliEriNERFtzP+xi5bu7V7TjxiT+bclBqw0beYqJrKKEiSgpZXY8w1Mr0vaSiPEDLWu0m80PswXpVoYYv6qC+6L/AutfwhCy66RO+Lw0hLOCo/IcWhFR5XA1bv2XwXqQGsc9DVXEvsu2yfdm+9Z0nKTkBmf3Wx3ysS6964wpUoIr4dIJKUpS1ec2ZNVX0f/Jk+kIyfaPcY8XB/s3fbroX58kErFM5T8mk89yF/QAhr6UJ1LjF/YEOHkjjbePG9+acUt5DSBId2mAfQY0hYgRJtwQ7sZtuBCkPyWTiJw34Y2FFCwJ8hGl1/XD1Qc0Y6OemGBj2Z4j4WM+9zDezV/9yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QEGGe51xBf66cJ8lTCTtNdnFfG5UAX6eLZoV+aKMZdg=; b=XjjTY2sBt/whTTjvB+A3dg4A64qnI/QG6FoWL5BsGR0s1FOL1wErH5yJhiC1lueJ2ZDTvbnUYqC7CQduDhd/mHNwMRT4O/niKb6/617JAlDrAXBv53gS1cJDirnK4r9VIo+HdnbEIhBNRmBksNKrcNkU88YrpMK+kJbu4yEMrlxBXzh8L+OxVk8Ieo/oC2ucU3wmYooaJKKmSmO9yW0cq6ueLtW2967oxFHRTIzGTD9ccyvnYSCkg52vOEtMZkaYpW5UehLFBMHa0iWMg6KbyEFzXTbuPDVMhr33qfCd4BS39v+3WFIg3CccAseegbTfe2Op0TC8sqS2sVQm/0/7bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QEGGe51xBf66cJ8lTCTtNdnFfG5UAX6eLZoV+aKMZdg=; b=Vq/14ZXGpx79NVs+UcDyjqwC1P6tohGTJzwMNaFQ2tYctUc9JTV0xgWxjTVTIY8loN1kx5v5wC8Q+/mRKv9W8pFIesqsTEuPCprNBY03opSzBDU72ntkwFe0oaFjwvAxjwiyatNZVtBFdFxQzDwwTyoGSedyJVUOvzZtF0YoDkU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v6 06/11] xen/arm: split MMU and MPU config files from config.h Date: Fri, 4 Nov 2022 18:07:36 +0800 Message-ID: <20221104100741.2176307-7-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221104100741.2176307-1-wei.chen@arm.com> References: <20221104100741.2176307-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT009:EE_|AS8PR08MB6309:EE_|AM7EUR03FT036:EE_|AM7PR08MB5334:EE_ X-MS-Office365-Filtering-Correlation-Id: 04129640-a6d0-4e2e-420a-08dabe4c8c22 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wCE3wNAnJ92tAPDGB3iDN6xPwim6fG/j7ZvTuFeLH7lBZJin8dwb+4Nw0UZjT53PLR7m2eYcSHoeG8zio3U58vWsGpxFkkdq827WI+kqKj3daOL49IWb3j8OwJmdAqxPyfI7oGFjNFb1wxY9p2uWbvpr7YTGizZRDjH9Dqk3nGgHrp/6ssEY00WJx2Ofzj9Oewi5RMw5sbEPeuVifdJfG0L/kmdLNI9ZIzTrEgxqvEK9z1TP+C7CtMHJ3s3Z0TDxZAJ8XRcCwnMaqUGp7ZHDTIPXQXKwkyTgBTSz89di376A2Sg1zJIH3v+zgphRj8cypFUF7TvET+0RSJ57NSUwwTF3xuZ2MfGPUqw34JRU40cKrRgec1UbnJa0dl64WzkRGnK6SgYRzlNiJvL3V4I7VqYewC9gc9yU+pA8q0MBz9pC7kTdJuXcljWG9IhNZDwtIXDh3zJCEsbjy8/vi7sHZQCaj9uI5z77YuM82kL+pE6nS0QHUOAVBrs4cdmR1FUaaJsECZ2xXDIq3YM/aMWtgygXJ+OhLgQk/PQrmsBjQGFD7CM3CNx7HUmTaD/ikzjBYVmKQSvrzDoZjPg1RnvEi+6Naeg1RS9R03v3qyfXjvmbwLc+6eET1NhexDfQM/cSz0ldZyl1zH8wmG9rtaJxE5XmXocnPz6uhW06Dr++XgR2TTBRQJTtlkWWWONUf50McWNyCVf+iKuoCBQE8r2daSyJi3Q4WWuCJLcpXy6eNdoDbrSM/5OwjCtCX42cXHOnynOvTFJOfAxHV1KgNiPUN6zmF8VYZZ60k1fS6ruAWIsft57i3o/380aet88OcAkC X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(136003)(346002)(451199015)(46966006)(40470700004)(36840700001)(83380400001)(81166007)(336012)(8676002)(426003)(47076005)(36860700001)(86362001)(44832011)(2906002)(82740400003)(5660300002)(4326008)(41300700001)(8936002)(6666004)(70206006)(7696005)(40460700003)(26005)(82310400005)(54906003)(316002)(6916009)(2616005)(40480700001)(356005)(478600001)(186003)(70586007)(1076003)(36756003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6309 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 273f993d-2a4e-431d-ac83-08dabe4c86b0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qjiJjwBs3UtWp8u91GRrSKzCm4pvpkUoV4KJrhMvgjLOvAQknSHKu3PWBagqZopY+/EV/KJDCpY3ah2NX5g5OL06x8AyyeDhJxjIZ7SXz5bFx/qvpu4zFVfMmiJPsuCgvY6tvhNMz1l5JIWxzg2E3Age1LFX44T7LUyWb+ue4KzIg2NbEuYBT1LswfgvSaQRN6XQJQhewnoanNc5vuGYmVl/3NoFxwi+vWkQhb1odzB342QB1T2LYnJClgdtBb5XdbWh+spn4gSh1FQMH9R7iGvr9s1bAc/lulfS6fpsm1znaMDx6dm8AudR1tvdvNSfUtf2bdiwyKjRKInIRAUvbJ/9hcau4b9Hiao3SsZ5nVGkFh3lSJt0zX/3QSFf9uMTD892cDHhvxkkUmD+3pt66MGJYwysW/Cv+KYGsMtbUJkJA7Lsy+8vCHrPJDJ9suTMdlIhCxc/MLzgyKYgWygiCe1C7t0suA6LHlYUPXdB2UcTNO1Z/JE9f9fQfm+TbYvcey6c2R8HBaQoi90gvj+/j0TYZbU3CGl/VVs/SG3VeR0mpzalszKZPfeFIprtSiJ8DiLrMMrllOgNbZlZXysBFUo7Vn3Va/kQAdKuJ49b7IlQ96WPJEUmvYp50wcYltJmzifKKsYhiGm77f+9rS5ymLY/z8eV9WtczF9nQ3mTDp0pAVctSLyJT/hWqlxlyttOHGPHJl4TyXrlR1Ol+VnjkUyGdc38UV13j8pJu0asDZXDbx5hvl28jVuTLhcpGKq7XqiyvWUvxq+1vUoZf8TcDw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(39860400002)(136003)(451199015)(46966006)(40470700004)(36840700001)(336012)(40480700001)(186003)(5660300002)(478600001)(2906002)(8936002)(426003)(47076005)(1076003)(6666004)(83380400001)(107886003)(2616005)(7696005)(82310400005)(4326008)(70586007)(82740400003)(70206006)(44832011)(316002)(6916009)(54906003)(8676002)(41300700001)(81166007)(40460700003)(36756003)(86362001)(36860700001)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:08:40.3412 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 04129640-a6d0-4e2e-420a-08dabe4c8c22 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5334 Xen defines some global configuration macros for Arm in config.h. We still want to use it for Armv8-R systems, but there are some address related macros that are defined for MMU systems. These macros will not be used by MPU systems, Adding ifdefery with CONFIG_HAS_MPU to gate these macros will result in a messy and hard to read/maintain code. So we keep some common definitions still in config.h, but move virtual address related definitions to a new file - config_mmu.h. And use a new file config_mpu.h to store definitions for MPU systems. To avoid spreading #ifdef everywhere, we keep the same definition names for MPU systems, like XEN_VIRT_START and HYPERVISOR_VIRT_START, but the definition contents are MPU specific. Signed-off-by: Wei Chen --- xen/arch/arm/include/asm/config.h | 97 +-------------------- xen/arch/arm/include/asm/config_mmu.h | 119 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/config_mpu.h | 27 ++++++ 3 files changed, 150 insertions(+), 93 deletions(-) create mode 100644 xen/arch/arm/include/asm/config_mmu.h create mode 100644 xen/arch/arm/include/asm/config_mpu.h diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index 25a625ff08..189e932605 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -71,99 +71,10 @@ #include #include -/* - * Common ARM32 and ARM64 layout: - * 0 - 2M Unmapped - * 2M - 4M Xen text, data, bss - * 4M - 6M Fixmap: special-purpose 4K mapping slots - * 6M - 10M Early boot mapping of FDT - * 10M - 12M Livepatch vmap (if compiled in) - * - * ARM32 layout: - * 0 - 12M - * - * 32M - 128M Frametable: 24 bytes per page for 16GB of RAM - * 256M - 1G VMAP: ioremap and early_ioremap use this virtual address - * space - * - * 1G - 2G Xenheap: always-mapped memory - * 2G - 4G Domheap: on-demand-mapped - * - * ARM64 layout: - * 0x0000000000000000 - 0x0000007fffffffff (512GB, L0 slot [0]) - * 0 - 12M - * - * 1G - 2G VMAP: ioremap and early_ioremap - * - * 32G - 64G Frametable: 24 bytes per page for 5.3TB of RAM - * - * 0x0000008000000000 - 0x00007fffffffffff (127.5TB, L0 slots [1..255]) - * Unused - * - * 0x0000800000000000 - 0x000084ffffffffff (5TB, L0 slots [256..265]) - * 1:1 mapping of RAM - * - * 0x0000850000000000 - 0x0000ffffffffffff (123TB, L0 slots [266..511]) - * Unused - */ - -#define XEN_VIRT_START _AT(vaddr_t,0x00200000) -#define FIXMAP_ADDR(n) (_AT(vaddr_t,0x00400000) + (n) * PAGE_SIZE) - -#define BOOT_FDT_VIRT_START _AT(vaddr_t,0x00600000) -#define BOOT_FDT_VIRT_SIZE _AT(vaddr_t, MB(4)) - -#ifdef CONFIG_LIVEPATCH -#define LIVEPATCH_VMAP_START _AT(vaddr_t,0x00a00000) -#define LIVEPATCH_VMAP_SIZE _AT(vaddr_t, MB(2)) -#endif - -#define HYPERVISOR_VIRT_START XEN_VIRT_START - -#ifdef CONFIG_ARM_32 - -#define CONFIG_SEPARATE_XENHEAP 1 - -#define FRAMETABLE_VIRT_START _AT(vaddr_t,0x02000000) -#define FRAMETABLE_SIZE MB(128-32) -#define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) -#define FRAMETABLE_VIRT_END (FRAMETABLE_VIRT_START + FRAMETABLE_SIZE - 1) - -#define VMAP_VIRT_START _AT(vaddr_t,0x10000000) -#define VMAP_VIRT_SIZE _AT(vaddr_t, GB(1) - MB(256)) - -#define XENHEAP_VIRT_START _AT(vaddr_t,0x40000000) -#define XENHEAP_VIRT_SIZE _AT(vaddr_t, GB(1)) - -#define DOMHEAP_VIRT_START _AT(vaddr_t,0x80000000) -#define DOMHEAP_VIRT_SIZE _AT(vaddr_t, GB(2)) - -#define DOMHEAP_ENTRIES 1024 /* 1024 2MB mapping slots */ - -/* Number of domheap pagetable pages required at the second level (2MB mappings) */ -#define DOMHEAP_SECOND_PAGES (DOMHEAP_VIRT_SIZE >> FIRST_SHIFT) - -#else /* ARM_64 */ - -#define SLOT0_ENTRY_BITS 39 -#define SLOT0(slot) (_AT(vaddr_t,slot) << SLOT0_ENTRY_BITS) -#define SLOT0_ENTRY_SIZE SLOT0(1) - -#define VMAP_VIRT_START GB(1) -#define VMAP_VIRT_SIZE GB(1) - -#define FRAMETABLE_VIRT_START GB(32) -#define FRAMETABLE_SIZE GB(32) -#define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) - -#define DIRECTMAP_VIRT_START SLOT0(256) -#define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256)) -#define DIRECTMAP_VIRT_END (DIRECTMAP_VIRT_START + DIRECTMAP_SIZE - 1) - -#define XENHEAP_VIRT_START directmap_virt_start - -#define HYPERVISOR_VIRT_END DIRECTMAP_VIRT_END - +#ifdef CONFIG_HAS_MPU +#include +#else +#include #endif #define NR_hypercalls 64 diff --git a/xen/arch/arm/include/asm/config_mmu.h b/xen/arch/arm/include/asm/config_mmu.h new file mode 100644 index 0000000000..444223f4a1 --- /dev/null +++ b/xen/arch/arm/include/asm/config_mmu.h @@ -0,0 +1,119 @@ +/****************************************************************************** + * config_mmu.h + * + * A Linux-style configuration list, only can be included by config.h + */ + +#ifndef __ARM_CONFIG_MMU_H__ +#define __ARM_CONFIG_MMU_H__ + +/* + * Common ARM32 and ARM64 layout: + * 0 - 2M Unmapped + * 2M - 4M Xen text, data, bss + * 4M - 6M Fixmap: special-purpose 4K mapping slots + * 6M - 10M Early boot mapping of FDT + * 10M - 12M Livepatch vmap (if compiled in) + * + * ARM32 layout: + * 0 - 12M + * + * 32M - 128M Frametable: 24 bytes per page for 16GB of RAM + * 256M - 1G VMAP: ioremap and early_ioremap use this virtual address + * space + * + * 1G - 2G Xenheap: always-mapped memory + * 2G - 4G Domheap: on-demand-mapped + * + * ARM64 layout: + * 0x0000000000000000 - 0x0000007fffffffff (512GB, L0 slot [0]) + * 0 - 12M + * + * 1G - 2G VMAP: ioremap and early_ioremap + * + * 32G - 64G Frametable: 24 bytes per page for 5.3TB of RAM + * + * 0x0000008000000000 - 0x00007fffffffffff (127.5TB, L0 slots [1..255]) + * Unused + * + * 0x0000800000000000 - 0x000084ffffffffff (5TB, L0 slots [256..265]) + * 1:1 mapping of RAM + * + * 0x0000850000000000 - 0x0000ffffffffffff (123TB, L0 slots [266..511]) + * Unused + */ + +#define XEN_VIRT_START _AT(vaddr_t,0x00200000) +#define FIXMAP_ADDR(n) (_AT(vaddr_t,0x00400000) + (n) * PAGE_SIZE) + +#define BOOT_FDT_VIRT_START _AT(vaddr_t,0x00600000) +#define BOOT_FDT_VIRT_SIZE _AT(vaddr_t, MB(4)) + +#ifdef CONFIG_LIVEPATCH +#define LIVEPATCH_VMAP_START _AT(vaddr_t,0x00a00000) +#define LIVEPATCH_VMAP_SIZE _AT(vaddr_t, MB(2)) +#endif + +#define HYPERVISOR_VIRT_START XEN_VIRT_START + +#ifdef CONFIG_ARM_32 + +#define CONFIG_SEPARATE_XENHEAP 1 + +#define FRAMETABLE_VIRT_START _AT(vaddr_t,0x02000000) +#define FRAMETABLE_SIZE MB(128-32) +#define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) +#define FRAMETABLE_VIRT_END (FRAMETABLE_VIRT_START + FRAMETABLE_SIZE - 1) + +#define VMAP_VIRT_START _AT(vaddr_t,0x10000000) +#define VMAP_VIRT_SIZE _AT(vaddr_t, GB(1) - MB(256)) + +#define XENHEAP_VIRT_START _AT(vaddr_t,0x40000000) +#define XENHEAP_VIRT_SIZE _AT(vaddr_t, GB(1)) + +#define DOMHEAP_VIRT_START _AT(vaddr_t,0x80000000) +#define DOMHEAP_VIRT_SIZE _AT(vaddr_t, GB(2)) + +#define DOMHEAP_ENTRIES 1024 /* 1024 2MB mapping slots */ + +/* Number of domheap pagetable pages required at the second level (2MB mappings) */ +#define DOMHEAP_SECOND_PAGES (DOMHEAP_VIRT_SIZE >> FIRST_SHIFT) + +#else /* ARM_64 */ + +#define SLOT0_ENTRY_BITS 39 +#define SLOT0(slot) (_AT(vaddr_t,slot) << SLOT0_ENTRY_BITS) +#define SLOT0_ENTRY_SIZE SLOT0(1) + +#define VMAP_VIRT_START GB(1) +#define VMAP_VIRT_SIZE GB(1) + +#define FRAMETABLE_VIRT_START GB(32) +#define FRAMETABLE_SIZE GB(32) +#define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) + +#define DIRECTMAP_VIRT_START SLOT0(256) +#define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256)) +#define DIRECTMAP_VIRT_END (DIRECTMAP_VIRT_START + DIRECTMAP_SIZE - 1) + +#define XENHEAP_VIRT_START directmap_virt_start + +#define HYPERVISOR_VIRT_END DIRECTMAP_VIRT_END + +#endif + +/* Fixmap slots */ +#define FIXMAP_CONSOLE 0 /* The primary UART */ +#define FIXMAP_MISC 1 /* Ephemeral mappings of hardware */ +#define FIXMAP_ACPI_BEGIN 2 /* Start mappings of ACPI tables */ +#define FIXMAP_ACPI_END (FIXMAP_ACPI_BEGIN + NUM_FIXMAP_ACPI_PAGES - 1) /* End mappings of ACPI tables */ + +#endif /* __ARM_CONFIG_MMU_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/include/asm/config_mpu.h b/xen/arch/arm/include/asm/config_mpu.h new file mode 100644 index 0000000000..530abb8302 --- /dev/null +++ b/xen/arch/arm/include/asm/config_mpu.h @@ -0,0 +1,27 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * config_mpu.h: A Linux-style configuration list for Arm MPU systems, + * only can be included by config.h + */ + +#ifndef __ARM_CONFIG_MPU_H__ +#define __ARM_CONFIG_MPU_H__ + +#ifdef CONFIG_FVP_BASER +#include +#endif + +/* + * All MPU platforms need to provide a XEN_START_ADDRESS for linker. This + * address indicates where Xen image will be loaded and run from. This + * address must be aligned to a PAGE_SIZE. + */ +#if (XEN_START_ADDRESS % PAGE_SIZE) != 0 +#error "XEN_START_ADDRESS must be aligned to PAGE_SIZE" +#endif + +#define XEN_VIRT_START _AT(paddr_t, XEN_START_ADDRESS) + +#define HYPERVISOR_VIRT_START XEN_VIRT_START + +#endif /* __ARM_CONFIG_MPU_H__ */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:08:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:08:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437436.691874 (Exim 4.92) (envelope-from ) id 1oqtd6-00055t-72; Fri, 04 Nov 2022 10:08:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437436.691874; Fri, 04 Nov 2022 10:08:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtd6-00054A-0v; Fri, 04 Nov 2022 10:08:52 +0000 Received: by outflank-mailman (input) for mailman id 437436; Fri, 04 Nov 2022 10:08:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtd4-0002Y7-Si for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:08:50 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2041.outbound.protection.outlook.com [40.107.20.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id acb06ebe-5c28-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 11:08:48 +0100 (CET) Received: from DU2P250CA0022.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::27) by VI1PR08MB10148.eurprd08.prod.outlook.com (2603:10a6:800:1bc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 4 Nov 2022 10:08:43 +0000 Received: from DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:231:cafe::72) by DU2P250CA0022.outlook.office365.com (2603:10a6:10:231::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:43 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT053.mail.protection.outlook.com (100.127.142.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:43 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Fri, 04 Nov 2022 10:08:43 +0000 Received: from a42c91438bf7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 031499ED-9F8F-44FF-8D7E-DB1FE3AC410E.1; Fri, 04 Nov 2022 10:08:35 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a42c91438bf7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 10:08:35 +0000 Received: from DB6PR07CA0009.eurprd07.prod.outlook.com (2603:10a6:6:2d::19) by PAXPR08MB6365.eurprd08.prod.outlook.com (2603:10a6:102:156::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 10:08:33 +0000 Received: from DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2d:cafe::28) by DB6PR07CA0009.outlook.office365.com (2603:10a6:6:2d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:33 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT019.mail.protection.outlook.com (100.127.142.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:32 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:31 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:31 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 4 Nov 2022 10:08:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: acb06ebe-5c28-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BwI1AvqIHZV4Vw+TW+hJYYRrAW+xdonC1AEbdYHyyc5fvgdiyo+BaZp7TwaQ9fH0HqzAuUbRxRoxnFLngwVWvLCVemOCviSc3i18+yF/k+PN9n09A46RqD0KvSidKOAvURfdooTGAlN7ej4438Wpj0mkFP0lKc40BbLnLO+jzUKeUxHgRdeMIwuV4r5Kk6BGEHVtGPYjhw1HYdoyssDx9jD1GXkO5N+OTqRB7CfZupTWSd6ticQAYx1P+6//gXo9vYw4/5nIdrZ+BqurcjHosPwW5gpGGmWjKBoNpxvHJ+VyAqX2tRQDD+F4ujT1KtCbNQuW6P4OLvURhsOwjWw5lA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JxFUFRTByzafTsQvGgiHQen1r54AmXHs7AvHgF/hOI8=; b=fv/P3KmUxG0FObaz/aBBI7tVj1oWt0tLKjZUltfFiYeC0RrSm7PPCF5WXHsDwC0w61dIJ/sjfHHNC/F2eR1UFMLMhvZ86Fet9+q3+UgYqCURnt8jL6DU/n+9wzz1aJppjUCTjaXIfmkH4NhWVTAJlhR5hbbXOwPvEfcjyaJTpbh3uooxJK4vKoJpEsDiD9qtQe/bFKFohw5YIj0sny75S/e295+qUtRfagnHtnZMGPCRAQzRS9a38AHCyAWm9+ZFcb1DRMMX42iWW2wvfRvmReG+6np5Rm7tIKBOoXN8KqXp8FbQtrBxJqbyv0uj1C9IPzaqvK8p3e2YqIelzsH0PA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JxFUFRTByzafTsQvGgiHQen1r54AmXHs7AvHgF/hOI8=; b=cC52TnJAaWyIAxUK0geNStHcqnYWTMCzW/VhdXrJfJQhA2IQ6Fh8P2MTr95trxfuX+ftAlbRX9IjejXQ9VVsUQInygitJsh06o4rTBvV8+/VO0Sb3mAxJqPKbeSWfTDxMT641BbodmHlGtYgqx7UGdW4u+6jfrypM81HPsHj8BI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 114410213fcd4c4b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UvcDROOhAJ0TSZz8GH8uDrK68hdrot5zz1BNKCt2K0uVKy/hWR1PvNudue+3TsL8EQ8O7ZNC90OA+U20akTnRUllz5/fIdGga1ZppIOP2YTz6oJfdqOosXBFPG1+Qk1XUIr2AFBg4sO7TVX56Dq/NWS6JFH3UqdGbtjBpXVKJXDsm7HhpyzUnEU+9ePd9mJ588Fk+3oiz1XyV2bWyEUdtwYyZmlMYGTd7hNgdIB+qeHB05X5eXtunlMlDdHBgSTzYc3XHyMz1BppvwWt1F/SF8MrldBNSynCpIZh82uf7f5COXOEmM1n6x4hPxk3Ael/RTYKvcp9yGxW1Xd3Aw7mzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JxFUFRTByzafTsQvGgiHQen1r54AmXHs7AvHgF/hOI8=; b=ocw5XTGgfRI+XySzSaSaMWQYIwh+QIcLM7rUNLHWNKMcbklP93bvNcR2JcZ+uCiXYeuEp8xjByHJSYJbGgDGyw50QS+PmXTlxT7W4U5hWCJtvGSckGNlJ1S9HK4aRbmH3yaXVs4RzPoNI5ogYkyt8b2oPbLgrPjufofKMJFoJ5mqdQfc7LHRy0k7ahoZEnO2iI/QVvdzxeOFw9K8/GuuQsnRcuz5rLAd65kDdZaPjIydYAY9ArYxo5qW23yxAkzMiN43GwMRNkhklexx8I3Llln+gxUJiYR5RX/Nd09lH2E0Jj/GBa2bawmVaXtPhg5Qgcf3e6NegDTcSn1Lzttafg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JxFUFRTByzafTsQvGgiHQen1r54AmXHs7AvHgF/hOI8=; b=cC52TnJAaWyIAxUK0geNStHcqnYWTMCzW/VhdXrJfJQhA2IQ6Fh8P2MTr95trxfuX+ftAlbRX9IjejXQ9VVsUQInygitJsh06o4rTBvV8+/VO0Sb3mAxJqPKbeSWfTDxMT641BbodmHlGtYgqx7UGdW4u+6jfrypM81HPsHj8BI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: [PATCH v6 08/11] xen/arm64: move MMU related code from head.S to head_mmu.S Date: Fri, 4 Nov 2022 18:07:38 +0800 Message-ID: <20221104100741.2176307-9-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221104100741.2176307-1-wei.chen@arm.com> References: <20221104100741.2176307-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT019:EE_|PAXPR08MB6365:EE_|DBAEUR03FT053:EE_|VI1PR08MB10148:EE_ X-MS-Office365-Filtering-Correlation-Id: 8822de9f-8cb4-4ee3-4804-08dabe4c8df9 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GLMKSS+p4VLEq83z1/2enYx4TBZH/nNind0YBFz0jsAFNBDS6pFqcd22cQvcx9mY+H9f2ijYMnC69VFGkr9oSKwm8g/6vgOM2XRvk+QP+myz9pin4lf0R3MC3h2HdcCiTqcneSk7ESEO6XJPXxDJiNeZD/22cy0CvtqQra5SgYC9tIGBRHpvgj+BUfXuTy9vBhJLq/Ks4DMlpQtDK/ebGJ1UZLWjD8H1TxaDCJb6SxMEAEoRtIGI2urrcjCxvXbKMm94ujg5OMa14MvToiM+dgG5/7+NG3ug5uNh2CdrCUY3ax0ZBWpMzG94bnpf7WbW1VYiiyp+wB61IfvGWxEUgVAcNCx4dCWzf3GXi2Wi+yxicHKN64lX9AuNhcIOVXN+7+AJVjVNh+pVxPkP1MuLzQRiocZMchS24P9eL5vlAmaq4AcfXjisn4A7D2yL3MRau723kAPhczKbNtE8WvXt6BhPNFre52hPQCXP+PQmk5KGrkn+Gz1hHmk7LSzpxeeTsOBfUp+pMi6hgbjL02u5MB0TdOH6dNpLmELIR4OrXzuqWfdCRgoe63KzCe7lIilxw/xkUYlmCmtpVmkimzCQkO++Xdgg99foL9asDji9GLBK3ljlGO98VuIAvuMN33NrIHS2j5EEQNLa9cMrTDXO/G8BSTzDqvtsadzQ3QYSpVzrcKDsF/8hymA7dzWVtemDS86n06tORT931AV/q18wP4ujiKPbzy2xQCYgiRIbtS87KZv1CxW/P/JxvsumAPHSVdU2RMbYeMJSNIAEnhjYsRrjhJaj93s1phGyEfT6ohFl/xH31hUKYqhNL7ur8KcC X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199015)(36840700001)(40470700004)(46966006)(81166007)(356005)(478600001)(82310400005)(82740400003)(86362001)(6666004)(36860700001)(186003)(336012)(8936002)(36756003)(4326008)(41300700001)(426003)(8676002)(47076005)(316002)(54906003)(40480700001)(6916009)(7696005)(70586007)(83380400001)(70206006)(1076003)(2906002)(26005)(40460700003)(5660300002)(2616005)(44832011)(30864003)(2004002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6365 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6e00a528-2004-48be-d5b7-08dabe4c8796 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6DZEh0znKrCuZRmcivmYDqm5RYW7LKXFW4X+2RlOCiRC/ZpSuZMOp4ZDfWnZg+e7vCefhtrXrVtZww9ox2QEGxmWMZd7fnbnPTsUz7C+UgWc+877xfurRLUPzHfP2mvu+5xxUOKF3cJ2lS2ODKhMYzCaKteYo+kD/ERHUnyUntglEubcR19WxkAHAuCY0iQYwenpiOi7512B5BgB4ChY5mj1IC1JRsmEIPTwxhX9TSpskNHs65rM4joB4mjxGZcg8Iz+uXnDya3FO22Xm7T5HrCgzqqyYYz5XTfe4oACVtBLB2qWnUHwzyC6E6HmngpI38dL67tbnNwEGe+o2+Nd8eyBGPkGzk8dnaVn4IBtXvnEfnkJ+erPG3JQ5Nlf6eCi/DgqkT9d15tk18FgKuufZr3SbpDHAOa5B2KzmLP2B03iXwqq1O7ZTW3HruROtG0iViCqgQN+kmFj4mDgNsxWUeSpqnQJLtPwXDDgXmPxAgxEg14cmrePooj/5dYvuiX/58w4VDfDGh3X8uvKSTivnKVAUdGhI1Z9NdtyMWbvfWQ6k9PJIFsj9qzVPYGUGmz83nWfuNoCIYTuNX0vyvH7xLa8H4wKiGYvIxjRqJRsJ7DX7pnqn4I5Gfa73N7WOVey1iuDr45a5SQ4v7Xbi+2iF6s8Kc4s1rivL76FtjNYmvHhKR8jMqwvR2O6J0twp4ABqmnTYCz+3aim5U7/zoUR4yfSZDDkLlQdnzT+vetujqE48kRzvQdBX1gRzEpBPsVnx9klCOczI5DYlNwSwcdqquLjd2y5PRX8HtwVogvwowk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199015)(40470700004)(46966006)(36840700001)(1076003)(54906003)(2906002)(86362001)(36756003)(81166007)(82740400003)(40480700001)(5660300002)(7696005)(336012)(26005)(426003)(44832011)(83380400001)(478600001)(36860700001)(82310400005)(6666004)(47076005)(40460700003)(186003)(4326008)(6916009)(316002)(70206006)(2616005)(30864003)(8936002)(70586007)(8676002)(41300700001)(2004002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:08:43.5062 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8822de9f-8cb4-4ee3-4804-08dabe4c8df9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB10148 There are lots of MMU specific code in head.S. This code will not be used in MPU systems. If we use #ifdef to gate them, the code will become messy and hard to maintain. So we move MMU related code to head_mmu.S, and keep common code still in head.S. As we need to access "fail" and "puts" functions out of assembly file, so we have to export them in this patch. And the assembly macros: adr_l and load_paddr will be used by MMU and MPU later, so we move them to macros.h. Signed-off-by: Henry Wang Signed-off-by: Wei Chen --- xen/arch/arm/arm64/Makefile | 3 + xen/arch/arm/arm64/head.S | 407 +----------------------- xen/arch/arm/arm64/head_mmu.S | 364 +++++++++++++++++++++ xen/arch/arm/include/asm/arm64/macros.h | 52 ++- 4 files changed, 432 insertions(+), 394 deletions(-) create mode 100644 xen/arch/arm/arm64/head_mmu.S diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile index 6d507da0d4..22da2f54b5 100644 --- a/xen/arch/arm/arm64/Makefile +++ b/xen/arch/arm/arm64/Makefile @@ -8,6 +8,9 @@ obj-y += domctl.o obj-y += domain.o obj-y += entry.o obj-y += head.o +ifneq ($(CONFIG_HAS_MPU),y) +obj-y += head_mmu.o +endif obj-y += insn.o obj-$(CONFIG_LIVEPATCH) += livepatch.o obj-y += smc.o diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index ccedf20dc7..d9a8da9120 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -25,17 +25,6 @@ #include #include -#define PT_PT 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ -#define PT_MEM 0xf7d /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=0 P=1 */ -#define PT_MEM_L3 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ -#define PT_DEV 0xe71 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=0 P=1 */ -#define PT_DEV_L3 0xe73 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=1 P=1 */ - -/* Convenience defines to get slot used by Xen mapping. */ -#define XEN_ZEROETH_SLOT zeroeth_table_offset(XEN_VIRT_START) -#define XEN_FIRST_SLOT first_table_offset(XEN_VIRT_START) -#define XEN_SECOND_SLOT second_table_offset(XEN_VIRT_START) - #define __HEAD_FLAG_PAGE_SIZE ((PAGE_SHIFT - 10) / 2) #define __HEAD_FLAG_PHYS_BASE 1 @@ -82,73 +71,22 @@ * x30 - lr */ -#ifdef CONFIG_EARLY_PRINTK -/* - * Macro to print a string to the UART, if there is one. - * - * Clobbers x0 - x3 - */ -#define PRINT(_s) \ - mov x3, lr ; \ - adr x0, 98f ; \ - bl puts ; \ - mov lr, x3 ; \ - RODATA_STR(98, _s) +.section .text.header, "ax", %progbits +/*.aarch64*/ /* - * Macro to print the value of register \xb + * Kernel startup entry point. + * --------------------------- * - * Clobbers x0 - x4 - */ -.macro print_reg xb - mov x0, \xb - mov x4, lr - bl putn - mov lr, x4 -.endm - -#else /* CONFIG_EARLY_PRINTK */ -#define PRINT(s) - -.macro print_reg xb -.endm - -#endif /* !CONFIG_EARLY_PRINTK */ - -/* - * Pseudo-op for PC relative adr , where is - * within the range +/- 4GB of the PC. + * The requirements are: + * MMU = off, D-cache = off, I-cache = on or off, + * x0 = physical address to the FDT blob. * - * @dst: destination register (64 bit wide) - * @sym: name of the symbol + * This must be the very first address in the loaded image. + * It should be linked at XEN_VIRT_START, and loaded at any + * 4K-aligned address. All of text+data+bss must fit in 2MB, + * or the initial pagetable code below will need adjustment. */ -.macro adr_l, dst, sym - adrp \dst, \sym - add \dst, \dst, :lo12:\sym -.endm - -/* Load the physical address of a symbol into xb */ -.macro load_paddr xb, sym - ldr \xb, =\sym - add \xb, \xb, x20 -.endm - - .section .text.header, "ax", %progbits - /*.aarch64*/ - - /* - * Kernel startup entry point. - * --------------------------- - * - * The requirements are: - * MMU = off, D-cache = off, I-cache = on or off, - * x0 = physical address to the FDT blob. - * - * This must be the very first address in the loaded image. - * It should be linked at XEN_VIRT_START, and loaded at any - * 4K-aligned address. All of text+data+bss must fit in 2MB, - * or the initial pagetable code below will need adjustment. - */ GLOBAL(start) /* @@ -497,296 +435,6 @@ cpu_init: ret ENDPROC(cpu_init) -/* - * Macro to find the slot number at a given page-table level - * - * slot: slot computed - * virt: virtual address - * lvl: page-table level - */ -.macro get_table_slot, slot, virt, lvl - ubfx \slot, \virt, #XEN_PT_LEVEL_SHIFT(\lvl), #XEN_PT_LPAE_SHIFT -.endm - -/* - * Macro to create a page table entry in \ptbl to \tbl - * - * ptbl: table symbol where the entry will be created - * tbl: table symbol to point to - * virt: virtual address - * lvl: page-table level - * tmp1: scratch register - * tmp2: scratch register - * tmp3: scratch register - * - * Preserves \virt - * Clobbers \tmp1, \tmp2, \tmp3 - * - * Also use x20 for the phys offset. - * - * Note that all parameters using registers should be distinct. - */ -.macro create_table_entry, ptbl, tbl, virt, lvl, tmp1, tmp2, tmp3 - get_table_slot \tmp1, \virt, \lvl /* \tmp1 := slot in \tlb */ - - load_paddr \tmp2, \tbl - mov \tmp3, #PT_PT /* \tmp3 := right for linear PT */ - orr \tmp3, \tmp3, \tmp2 /* + \tlb paddr */ - - adr_l \tmp2, \ptbl - - str \tmp3, [\tmp2, \tmp1, lsl #3] -.endm - -/* - * Macro to create a mapping entry in \tbl to \phys. Only mapping in 3rd - * level table (i.e page granularity) is supported. - * - * ptbl: table symbol where the entry will be created - * virt: virtual address - * phys: physical address (should be page aligned) - * tmp1: scratch register - * tmp2: scratch register - * tmp3: scratch register - * type: mapping type. If not specified it will be normal memory (PT_MEM_L3) - * - * Preserves \virt, \phys - * Clobbers \tmp1, \tmp2, \tmp3 - * - * Note that all parameters using registers should be distinct. - */ -.macro create_mapping_entry, ptbl, virt, phys, tmp1, tmp2, tmp3, type=PT_MEM_L3 - and \tmp3, \phys, #THIRD_MASK /* \tmp3 := PAGE_ALIGNED(phys) */ - - get_table_slot \tmp1, \virt, 3 /* \tmp1 := slot in \tlb */ - - mov \tmp2, #\type /* \tmp2 := right for section PT */ - orr \tmp2, \tmp2, \tmp3 /* + PAGE_ALIGNED(phys) */ - - adr_l \tmp3, \ptbl - - str \tmp2, [\tmp3, \tmp1, lsl #3] -.endm - -/* - * Rebuild the boot pagetable's first-level entries. The structure - * is described in mm.c. - * - * After the CPU enables paging it will add the fixmap mapping - * to these page tables, however this may clash with the 1:1 - * mapping. So each CPU must rebuild the page tables here with - * the 1:1 in place. - * - * Inputs: - * x19: paddr(start) - * x20: phys offset - * - * Clobbers x0 - x4 - */ -create_page_tables: - /* Prepare the page-tables for mapping Xen */ - ldr x0, =XEN_VIRT_START - create_table_entry boot_pgtable, boot_first, x0, 0, x1, x2, x3 - create_table_entry boot_first, boot_second, x0, 1, x1, x2, x3 - create_table_entry boot_second, boot_third, x0, 2, x1, x2, x3 - - /* Map Xen */ - adr_l x4, boot_third - - lsr x2, x19, #THIRD_SHIFT /* Base address for 4K mapping */ - lsl x2, x2, #THIRD_SHIFT - mov x3, #PT_MEM_L3 /* x2 := Section map */ - orr x2, x2, x3 - - /* ... map of vaddr(start) in boot_third */ - mov x1, xzr -1: str x2, [x4, x1] /* Map vaddr(start) */ - add x2, x2, #PAGE_SIZE /* Next page */ - add x1, x1, #8 /* Next slot */ - cmp x1, #(XEN_PT_LPAE_ENTRIES<<3) /* 512 entries per page */ - b.lt 1b - - /* - * If Xen is loaded at exactly XEN_VIRT_START then we don't - * need an additional 1:1 mapping, the virtual mapping will - * suffice. - */ - cmp x19, #XEN_VIRT_START - bne 1f - ret -1: - /* - * Setup the 1:1 mapping so we can turn the MMU on. Note that - * only the first page of Xen will be part of the 1:1 mapping. - */ - - /* - * Find the zeroeth slot used. If the slot is not - * XEN_ZEROETH_SLOT, then the 1:1 mapping will use its own set of - * page-tables from the first level. - */ - get_table_slot x0, x19, 0 /* x0 := zeroeth slot */ - cmp x0, #XEN_ZEROETH_SLOT - beq 1f - create_table_entry boot_pgtable, boot_first_id, x19, 0, x0, x1, x2 - b link_from_first_id - -1: - /* - * Find the first slot used. If the slot is not XEN_FIRST_SLOT, - * then the 1:1 mapping will use its own set of page-tables from - * the second level. - */ - get_table_slot x0, x19, 1 /* x0 := first slot */ - cmp x0, #XEN_FIRST_SLOT - beq 1f - create_table_entry boot_first, boot_second_id, x19, 1, x0, x1, x2 - b link_from_second_id - -1: - /* - * Find the second slot used. If the slot is XEN_SECOND_SLOT, then the - * 1:1 mapping will use its own set of page-tables from the - * third level. For slot XEN_SECOND_SLOT, Xen is not yet able to handle - * it. - */ - get_table_slot x0, x19, 2 /* x0 := second slot */ - cmp x0, #XEN_SECOND_SLOT - beq virtphys_clash - create_table_entry boot_second, boot_third_id, x19, 2, x0, x1, x2 - b link_from_third_id - -link_from_first_id: - create_table_entry boot_first_id, boot_second_id, x19, 1, x0, x1, x2 -link_from_second_id: - create_table_entry boot_second_id, boot_third_id, x19, 2, x0, x1, x2 -link_from_third_id: - create_mapping_entry boot_third_id, x19, x19, x0, x1, x2 - ret - -virtphys_clash: - /* Identity map clashes with boot_third, which we cannot handle yet */ - PRINT("- Unable to build boot page tables - virt and phys addresses clash. -\r\n") - b fail -ENDPROC(create_page_tables) - -/* - * Turn on the Data Cache and the MMU. The function will return on the 1:1 - * mapping. In other word, the caller is responsible to switch to the runtime - * mapping. - * - * Clobbers x0 - x3 - */ -enable_mmu: - PRINT("- Turning on paging -\r\n") - - /* - * The state of the TLBs is unknown before turning on the MMU. - * Flush them to avoid stale one. - */ - tlbi alle2 /* Flush hypervisor TLBs */ - dsb nsh - - /* Write Xen's PT's paddr into TTBR0_EL2 */ - load_paddr x0, boot_pgtable - msr TTBR0_EL2, x0 - isb - - mrs x0, SCTLR_EL2 - orr x0, x0, #SCTLR_Axx_ELx_M /* Enable MMU */ - orr x0, x0, #SCTLR_Axx_ELx_C /* Enable D-cache */ - dsb sy /* Flush PTE writes and finish reads */ - msr SCTLR_EL2, x0 /* now paging is enabled */ - isb /* Now, flush the icache */ - ret -ENDPROC(enable_mmu) - -/* - * Remove the 1:1 map from the page-tables. It is not easy to keep track - * where the 1:1 map was mapped, so we will look for the top-level entry - * exclusive to the 1:1 map and remove it. - * - * Inputs: - * x19: paddr(start) - * - * Clobbers x0 - x1 - */ -remove_identity_mapping: - /* - * Find the zeroeth slot used. Remove the entry from zeroeth - * table if the slot is not XEN_ZEROETH_SLOT. - */ - get_table_slot x1, x19, 0 /* x1 := zeroeth slot */ - cmp x1, #XEN_ZEROETH_SLOT - beq 1f - /* It is not in slot XEN_ZEROETH_SLOT, remove the entry. */ - ldr x0, =boot_pgtable /* x0 := root table */ - str xzr, [x0, x1, lsl #3] - b identity_mapping_removed - -1: - /* - * Find the first slot used. Remove the entry for the first - * table if the slot is not XEN_FIRST_SLOT. - */ - get_table_slot x1, x19, 1 /* x1 := first slot */ - cmp x1, #XEN_FIRST_SLOT - beq 1f - /* It is not in slot XEN_FIRST_SLOT, remove the entry. */ - ldr x0, =boot_first /* x0 := first table */ - str xzr, [x0, x1, lsl #3] - b identity_mapping_removed - -1: - /* - * Find the second slot used. Remove the entry for the first - * table if the slot is not XEN_SECOND_SLOT. - */ - get_table_slot x1, x19, 2 /* x1 := second slot */ - cmp x1, #XEN_SECOND_SLOT - beq identity_mapping_removed - /* It is not in slot 1, remove the entry */ - ldr x0, =boot_second /* x0 := second table */ - str xzr, [x0, x1, lsl #3] - -identity_mapping_removed: - /* See asm/arm64/flushtlb.h for the explanation of the sequence. */ - dsb nshst - tlbi alle2 - dsb nsh - isb - - ret -ENDPROC(remove_identity_mapping) - -/* - * Map the UART in the fixmap (when earlyprintk is used) and hook the - * fixmap table in the page tables. - * - * The fixmap cannot be mapped in create_page_tables because it may - * clash with the 1:1 mapping. - * - * Inputs: - * x20: Physical offset - * x23: Early UART base physical address - * - * Clobbers x0 - x3 - */ -setup_fixmap: -#ifdef CONFIG_EARLY_PRINTK - /* Add UART to the fixmap table */ - ldr x0, =EARLY_UART_VIRTUAL_ADDRESS - create_mapping_entry xen_fixmap, x0, x23, x1, x2, x3, type=PT_DEV_L3 -#endif - /* Map fixmap into boot_second */ - ldr x0, =FIXMAP_ADDR(0) - create_table_entry boot_second, xen_fixmap, x0, 2, x1, x2, x3 - /* Ensure any page table updates made above have occurred. */ - dsb nshst - - ret -ENDPROC(setup_fixmap) - /* * Setup the initial stack and jump to the C world * @@ -810,41 +458,14 @@ launch: ENDPROC(launch) /* Fail-stop */ -fail: PRINT("- Boot failed -\r\n") +ENTRY(fail) + PRINT("- Boot failed -\r\n") 1: wfe b 1b ENDPROC(fail) GLOBAL(_end_boot) -/* - * Switch TTBR - * - * x0 ttbr - * - * TODO: This code does not comply with break-before-make. - */ -ENTRY(switch_ttbr) - dsb sy /* Ensure the flushes happen before - * continuing */ - isb /* Ensure synchronization with previous - * changes to text */ - tlbi alle2 /* Flush hypervisor TLB */ - ic iallu /* Flush I-cache */ - dsb sy /* Ensure completion of TLB flush */ - isb - - msr TTBR0_EL2, x0 - - isb /* Ensure synchronization with previous - * changes to text */ - tlbi alle2 /* Flush hypervisor TLB */ - ic iallu /* Flush I-cache */ - dsb sy /* Ensure completion of TLB flush */ - isb - - ret -ENDPROC(switch_ttbr) #ifdef CONFIG_EARLY_PRINTK /* @@ -868,7 +489,7 @@ ENDPROC(init_uart) * x0: Nul-terminated string to print. * x23: Early UART base address * Clobbers x0-x1 */ -puts: +ENTRY(puts) early_uart_ready x23, 1 ldrb w1, [x0], #1 /* Load next char */ cbz w1, 1f /* Exit on nul */ diff --git a/xen/arch/arm/arm64/head_mmu.S b/xen/arch/arm/arm64/head_mmu.S new file mode 100644 index 0000000000..1a3df81a38 --- /dev/null +++ b/xen/arch/arm/arm64/head_mmu.S @@ -0,0 +1,364 @@ +/* + * xen/arch/arm/head_mmu.S + * + * Start-of-day code for an ARMv8-A. + * + * Ian Campbell + * Copyright (c) 2012 Citrix Systems. + * + * Based on ARMv7-A head.S by + * Tim Deegan + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include +#include + +#define PT_PT 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ +#define PT_MEM 0xf7d /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=0 P=1 */ +#define PT_MEM_L3 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ +#define PT_DEV 0xe71 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=0 P=1 */ +#define PT_DEV_L3 0xe73 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=1 P=1 */ + +/* Convenience defines to get slot used by Xen mapping. */ +#define XEN_ZEROETH_SLOT zeroeth_table_offset(XEN_VIRT_START) +#define XEN_FIRST_SLOT first_table_offset(XEN_VIRT_START) +#define XEN_SECOND_SLOT second_table_offset(XEN_VIRT_START) + +/* + * Macro to find the slot number at a given page-table level + * + * slot: slot computed + * virt: virtual address + * lvl: page-table level + */ +.macro get_table_slot, slot, virt, lvl + ubfx \slot, \virt, #XEN_PT_LEVEL_SHIFT(\lvl), #XEN_PT_LPAE_SHIFT +.endm + +/* + * Macro to create a page table entry in \ptbl to \tbl + * + * ptbl: table symbol where the entry will be created + * tbl: table symbol to point to + * virt: virtual address + * lvl: page-table level + * tmp1: scratch register + * tmp2: scratch register + * tmp3: scratch register + * + * Preserves \virt + * Clobbers \tmp1, \tmp2, \tmp3 + * + * Also use x20 for the phys offset. + * + * Note that all parameters using registers should be distinct. + */ +.macro create_table_entry, ptbl, tbl, virt, lvl, tmp1, tmp2, tmp3 + get_table_slot \tmp1, \virt, \lvl /* \tmp1 := slot in \tlb */ + + load_paddr \tmp2, \tbl + mov \tmp3, #PT_PT /* \tmp3 := right for linear PT */ + orr \tmp3, \tmp3, \tmp2 /* + \tlb paddr */ + + adr_l \tmp2, \ptbl + + str \tmp3, [\tmp2, \tmp1, lsl #3] +.endm + +/* + * Macro to create a mapping entry in \tbl to \phys. Only mapping in 3rd + * level table (i.e page granularity) is supported. + * + * ptbl: table symbol where the entry will be created + * virt: virtual address + * phys: physical address (should be page aligned) + * tmp1: scratch register + * tmp2: scratch register + * tmp3: scratch register + * type: mapping type. If not specified it will be normal memory (PT_MEM_L3) + * + * Preserves \virt, \phys + * Clobbers \tmp1, \tmp2, \tmp3 + * + * Note that all parameters using registers should be distinct. + */ +.macro create_mapping_entry, ptbl, virt, phys, tmp1, tmp2, tmp3, type=PT_MEM_L3 + and \tmp3, \phys, #THIRD_MASK /* \tmp3 := PAGE_ALIGNED(phys) */ + + get_table_slot \tmp1, \virt, 3 /* \tmp1 := slot in \tlb */ + + mov \tmp2, #\type /* \tmp2 := right for section PT */ + orr \tmp2, \tmp2, \tmp3 /* + PAGE_ALIGNED(phys) */ + + adr_l \tmp3, \ptbl + + str \tmp2, [\tmp3, \tmp1, lsl #3] +.endm + +.section .text.header, "ax", %progbits +/*.aarch64*/ + +/* + * Rebuild the boot pagetable's first-level entries. The structure + * is described in mm.c. + * + * After the CPU enables paging it will add the fixmap mapping + * to these page tables, however this may clash with the 1:1 + * mapping. So each CPU must rebuild the page tables here with + * the 1:1 in place. + * + * Inputs: + * x19: paddr(start) + * x20: phys offset + * + * Clobbers x0 - x4 + */ +ENTRY(create_page_tables) + /* Prepare the page-tables for mapping Xen */ + ldr x0, =XEN_VIRT_START + create_table_entry boot_pgtable, boot_first, x0, 0, x1, x2, x3 + create_table_entry boot_first, boot_second, x0, 1, x1, x2, x3 + create_table_entry boot_second, boot_third, x0, 2, x1, x2, x3 + + /* Map Xen */ + adr_l x4, boot_third + + lsr x2, x19, #THIRD_SHIFT /* Base address for 4K mapping */ + lsl x2, x2, #THIRD_SHIFT + mov x3, #PT_MEM_L3 /* x2 := Section map */ + orr x2, x2, x3 + + /* ... map of vaddr(start) in boot_third */ + mov x1, xzr +1: str x2, [x4, x1] /* Map vaddr(start) */ + add x2, x2, #PAGE_SIZE /* Next page */ + add x1, x1, #8 /* Next slot */ + cmp x1, #(XEN_PT_LPAE_ENTRIES<<3) /* 512 entries per page */ + b.lt 1b + + /* + * If Xen is loaded at exactly XEN_VIRT_START then we don't + * need an additional 1:1 mapping, the virtual mapping will + * suffice. + */ + cmp x19, #XEN_VIRT_START + bne 1f + ret +1: + /* + * Setup the 1:1 mapping so we can turn the MMU on. Note that + * only the first page of Xen will be part of the 1:1 mapping. + */ + + /* + * Find the zeroeth slot used. If the slot is not + * XEN_ZEROETH_SLOT, then the 1:1 mapping will use its own set of + * page-tables from the first level. + */ + get_table_slot x0, x19, 0 /* x0 := zeroeth slot */ + cmp x0, #XEN_ZEROETH_SLOT + beq 1f + create_table_entry boot_pgtable, boot_first_id, x19, 0, x0, x1, x2 + b link_from_first_id + +1: + /* + * Find the first slot used. If the slot is not XEN_FIRST_SLOT, + * then the 1:1 mapping will use its own set of page-tables from + * the second level. + */ + get_table_slot x0, x19, 1 /* x0 := first slot */ + cmp x0, #XEN_FIRST_SLOT + beq 1f + create_table_entry boot_first, boot_second_id, x19, 1, x0, x1, x2 + b link_from_second_id + +1: + /* + * Find the second slot used. If the slot is XEN_SECOND_SLOT, then the + * 1:1 mapping will use its own set of page-tables from the + * third level. For slot XEN_SECOND_SLOT, Xen is not yet able to handle + * it. + */ + get_table_slot x0, x19, 2 /* x0 := second slot */ + cmp x0, #XEN_SECOND_SLOT + beq virtphys_clash + create_table_entry boot_second, boot_third_id, x19, 2, x0, x1, x2 + b link_from_third_id + +link_from_first_id: + create_table_entry boot_first_id, boot_second_id, x19, 1, x0, x1, x2 +link_from_second_id: + create_table_entry boot_second_id, boot_third_id, x19, 2, x0, x1, x2 +link_from_third_id: + create_mapping_entry boot_third_id, x19, x19, x0, x1, x2 + ret + +virtphys_clash: + /* Identity map clashes with boot_third, which we cannot handle yet */ + PRINT("- Unable to build boot page tables - virt and phys addresses clash. -\r\n") + b fail +ENDPROC(create_page_tables) + +/* + * Turn on the Data Cache and the MMU. The function will return on the 1:1 + * mapping. In other word, the caller is responsible to switch to the runtime + * mapping. + * + * Clobbers x0 - x3 + */ +ENTRY(enable_mmu) + PRINT("- Turning on paging -\r\n") + + /* + * The state of the TLBs is unknown before turning on the MMU. + * Flush them to avoid stale one. + */ + tlbi alle2 /* Flush hypervisor TLBs */ + dsb nsh + + /* Write Xen's PT's paddr into TTBR0_EL2 */ + load_paddr x0, boot_pgtable + msr TTBR0_EL2, x0 + isb + + mrs x0, SCTLR_EL2 + orr x0, x0, #SCTLR_Axx_ELx_M /* Enable MMU */ + orr x0, x0, #SCTLR_Axx_ELx_C /* Enable D-cache */ + dsb sy /* Flush PTE writes and finish reads */ + msr SCTLR_EL2, x0 /* now paging is enabled */ + isb /* Now, flush the icache */ + ret +ENDPROC(enable_mmu) + +/* + * Remove the 1:1 map from the page-tables. It is not easy to keep track + * where the 1:1 map was mapped, so we will look for the top-level entry + * exclusive to the 1:1 map and remove it. + * + * Inputs: + * x19: paddr(start) + * + * Clobbers x0 - x1 + */ +ENTRY(remove_identity_mapping) + /* + * Find the zeroeth slot used. Remove the entry from zeroeth + * table if the slot is not XEN_ZEROETH_SLOT. + */ + get_table_slot x1, x19, 0 /* x1 := zeroeth slot */ + cmp x1, #XEN_ZEROETH_SLOT + beq 1f + /* It is not in slot XEN_ZEROETH_SLOT, remove the entry. */ + ldr x0, =boot_pgtable /* x0 := root table */ + str xzr, [x0, x1, lsl #3] + b identity_mapping_removed + +1: + /* + * Find the first slot used. Remove the entry for the first + * table if the slot is not XEN_FIRST_SLOT. + */ + get_table_slot x1, x19, 1 /* x1 := first slot */ + cmp x1, #XEN_FIRST_SLOT + beq 1f + /* It is not in slot XEN_FIRST_SLOT, remove the entry. */ + ldr x0, =boot_first /* x0 := first table */ + str xzr, [x0, x1, lsl #3] + b identity_mapping_removed + +1: + /* + * Find the second slot used. Remove the entry for the first + * table if the slot is not XEN_SECOND_SLOT. + */ + get_table_slot x1, x19, 2 /* x1 := second slot */ + cmp x1, #XEN_SECOND_SLOT + beq identity_mapping_removed + /* It is not in slot 1, remove the entry */ + ldr x0, =boot_second /* x0 := second table */ + str xzr, [x0, x1, lsl #3] + +identity_mapping_removed: + /* See asm/arm64/flushtlb.h for the explanation of the sequence. */ + dsb nshst + tlbi alle2 + dsb nsh + isb + + ret +ENDPROC(remove_identity_mapping) + +/* + * Map the UART in the fixmap (when earlyprintk is used) and hook the + * fixmap table in the page tables. + * + * The fixmap cannot be mapped in create_page_tables because it may + * clash with the 1:1 mapping. + * + * Inputs: + * x20: Physical offset + * x23: Early UART base physical address + * + * Clobbers x0 - x3 + */ +ENTRY(setup_fixmap) +#ifdef CONFIG_EARLY_PRINTK + /* Add UART to the fixmap table */ + ldr x0, =EARLY_UART_VIRTUAL_ADDRESS + create_mapping_entry xen_fixmap, x0, x23, x1, x2, x3, type=PT_DEV_L3 +#endif + /* Map fixmap into boot_second */ + ldr x0, =FIXMAP_ADDR(0) + create_table_entry boot_second, xen_fixmap, x0, 2, x1, x2, x3 + /* Ensure any page table updates made above have occurred. */ + dsb nshst + + ret +ENDPROC(setup_fixmap) + +/* + * Switch TTBR + * + * x0 ttbr + * + * TODO: This code does not comply with break-before-make. + */ +ENTRY(switch_ttbr) + dsb sy /* Ensure the flushes happen before + * continuing */ + isb /* Ensure synchronization with previous + * changes to text */ + tlbi alle2 /* Flush hypervisor TLB */ + ic iallu /* Flush I-cache */ + dsb sy /* Ensure completion of TLB flush */ + isb + + msr TTBR0_EL2, x0 + + isb /* Ensure synchronization with previous + * changes to text */ + tlbi alle2 /* Flush hypervisor TLB */ + ic iallu /* Flush I-cache */ + dsb sy /* Ensure completion of TLB flush */ + isb + + ret +ENDPROC(switch_ttbr) + +/* + * Local variables: + * mode: ASM + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/include/asm/arm64/macros.h b/xen/arch/arm/include/asm/arm64/macros.h index 140e223b4c..462dc70335 100644 --- a/xen/arch/arm/include/asm/arm64/macros.h +++ b/xen/arch/arm/include/asm/arm64/macros.h @@ -32,10 +32,60 @@ hint #22 .endm + /* + * Pseudo-op for PC relative adr , where is + * within the range +/- 4GB of the PC. + * + * @dst: destination register (64 bit wide) + * @sym: name of the symbol + */ + .macro adr_l, dst, sym + adrp \dst, \sym + add \dst, \dst, :lo12:\sym + .endm + + /* Load the physical address of a symbol into xb */ + .macro load_paddr xb, sym + ldr \xb, =\sym + add \xb, \xb, x20 + .endm + /* * Register aliases. */ lr .req x30 /* link register */ -#endif /* __ASM_ARM_ARM64_MACROS_H */ +#ifdef CONFIG_EARLY_PRINTK +/* + * Macro to print a string to the UART, if there is one. + * + * Clobbers x0 - x3 + */ +#define PRINT(_s) \ + mov x3, lr ; \ + adr x0, 98f ; \ + bl puts ; \ + mov lr, x3 ; \ + RODATA_STR(98, _s) + /* + * Macro to print the value of register \xb + * + * Clobbers x0 - x4 + */ + .macro print_reg xb + mov x0, \xb + mov x4, lr + bl putn + mov lr, x4 + .endm + +#else /* CONFIG_EARLY_PRINTK */ +#define PRINT(s) + +.macro print_reg xb +.endm + +#endif /* !CONFIG_EARLY_PRINTK */ + +#endif /* __ASM_ARM_ARM64_MACROS_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:15:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:15:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437450.691885 (Exim 4.92) (envelope-from ) id 1oqtj9-0008Bi-3I; Fri, 04 Nov 2022 10:15:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437450.691885; Fri, 04 Nov 2022 10:15:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtj9-0008Bb-09; Fri, 04 Nov 2022 10:15:07 +0000 Received: by outflank-mailman (input) for mailman id 437450; Fri, 04 Nov 2022 10:15:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtdC-0001vd-7m for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:08:58 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80077.outbound.protection.outlook.com [40.107.8.77]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b097bb3e-5c28-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 11:08:55 +0100 (CET) Received: from DB6PR0301CA0057.eurprd03.prod.outlook.com (2603:10a6:4:54::25) by AM7PR08MB5400.eurprd08.prod.outlook.com (2603:10a6:20b:109::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 10:08:52 +0000 Received: from DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:54:cafe::21) by DB6PR0301CA0057.outlook.office365.com (2603:10a6:4:54::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT007.mail.protection.outlook.com (100.127.142.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:51 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Fri, 04 Nov 2022 10:08:51 +0000 Received: from 22eff781080b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9C3E398E-A09B-4389-A9E5-D9739BE5DCC9.1; Fri, 04 Nov 2022 10:08:44 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 22eff781080b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 10:08:44 +0000 Received: from AS8PR04CA0142.eurprd04.prod.outlook.com (2603:10a6:20b:127::27) by VE1PR08MB5823.eurprd08.prod.outlook.com (2603:10a6:800:1a5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 10:08:42 +0000 Received: from AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:127:cafe::da) by AS8PR04CA0142.outlook.office365.com (2603:10a6:20b:127::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:42 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT025.mail.protection.outlook.com (100.127.140.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:42 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:40 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 4 Nov 2022 10:08:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b097bb3e-5c28-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=V3ZI84t8WVOeWA6xyAcbkwF3iBj6VO7/bqg3+QK8MkjPl6MFappBM2YKQ21KaiIRVgx8Vj1E+gMI6kt6olwVyHkZFfbqI+RJsZadCM1+PpwKVXzUqE05xBqq1epSMsVVgR3ofiNXBU76O6Cfc2FeOZr66Hll3ldx3jn7HBte1xfx2S0d1GlywiE4rC00DQZ+iDXZTIOaL9VL9yHTsAL4l41+02yngT2fkSZAsDbA2oMvBfKHw/Vm1LII0gBR0FXQA81isDKeYk4Lb4+aHPvx2C3tqyWtO9pCj24gV4+s0Ez64rQafFpUmU5C+wj11TpehsH2+tuBpFzjeMkRlLA8DQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tU2PchcbobCINE1Reghr/rSLoGA3tFIJcSeA7caa+8c=; b=Ps0q4SG+8dViYEb73/yI63YJLRrXjdFOb4yuMMo6OeQY/ZR+L6rrZHK1yVQWg+JWuthEXO1TCk7Wq1b432uCFkr4rTo4Rzm7WyZR5G8UNyhmoCdvwV/GajP5EpIwGf4MkFAqmZ0cDeApw5Zfod7VAqUnlYi2cYkKwyAHDFt+ljvOymjjPwJtBtzj5LW46CIQi4atoTll41+mtRXZRit4fM5XUQIeHy4Tbptixlep3Try75Oe8daHyrWvJ6r8FY4iAvrXG+OCRswlSTvwnd1Hn5dtSaG/ab6pLzDmf8bB1j3FDDii5kplOqatxjB6S/+PH0xgIgNMxeWs5REIeV+wSA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tU2PchcbobCINE1Reghr/rSLoGA3tFIJcSeA7caa+8c=; b=i6yukU+NJPTYbyx32qnv+H4TIT5NYo6U+gKW81m3eX6CusiM2jY2B1p1LSXxlDXuEufrA9NVRfvQG/0OMPHeXzSqdrrwmOylIXrvFl4KfQoYTwhHq3PPw+Cahvv/zANIIBVIWuw9kVaTitXz0lnXcDBj0kq/SEp9hXjaF0QdoC0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a05c98b201683dfd X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=irLl3wBBEqQ3cPGX7OkB0CW0Cg5rbgnOHYG5Unk8qqy62HOCImcSaV7t1uVF/+hLnxEBFhdREDGk848bKrEb30z9ikMXFNtdSv8UAnZ/XywBNXfBGwZ2k3INemY/DBlVLLViyDV57yu+S+WFhBcnuStOkh3Bhw+K4KTnKb91ZpT4pd3G6P+x/xG3ZXYYkTj7vlye2/wkJi/SFl73KzDZpnnNlUKN6O9/+nSuoa6gw44mh4PfGeOnddIXwHPkLdraWGuMKgfFd45sDCQ9pmZqk59DXhezVmmHYdBS9iSectEkz+qgX8uAAkU0jZM4fz4SP3iZkcjyGGMHcBmZdiri7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tU2PchcbobCINE1Reghr/rSLoGA3tFIJcSeA7caa+8c=; b=T790q2uyZMvlJyYZsZFRmP14GPJvqnUeFp3gpTzz1IJG4LkdpHmX46cq/A3l8FSLeI6J0lgrxtp8DGjj+w/bTsUiYfxxmkK+kNjEdbpp4sAqmbdSkJC3uYh6Itfl6HZsHqtYd7FiIRE/T1lTewPnMpEAscOTW/IgqGEDGdnC1nZDAMe3tI66YsQoPFSQUTyfQHp7yfT0rXKkShV6KNHeIb5iTIljUQ8NE49CZgEh9yiKv9p+RcCRU4cKgJrfvp/4iMtu+iHwrRMrR8nR9BYGpt5+tHJ/Tdb2Af+wZQWwevlSJjQc05eLo1VmheGGkQKzuwVX+eL5tHDxscobIy5L8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tU2PchcbobCINE1Reghr/rSLoGA3tFIJcSeA7caa+8c=; b=i6yukU+NJPTYbyx32qnv+H4TIT5NYo6U+gKW81m3eX6CusiM2jY2B1p1LSXxlDXuEufrA9NVRfvQG/0OMPHeXzSqdrrwmOylIXrvFl4KfQoYTwhHq3PPw+Cahvv/zANIIBVIWuw9kVaTitXz0lnXcDBj0kq/SEp9hXjaF0QdoC0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Wei Chen Subject: [PATCH v6 11/11] xen/arm64: add setup_fixmap and remove_identity_mapping for MPU Date: Fri, 4 Nov 2022 18:07:41 +0800 Message-ID: <20221104100741.2176307-12-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221104100741.2176307-1-wei.chen@arm.com> References: <20221104100741.2176307-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT025:EE_|VE1PR08MB5823:EE_|DBAEUR03FT007:EE_|AM7PR08MB5400:EE_ X-MS-Office365-Filtering-Correlation-Id: ab9ddcbc-d674-4385-ff3c-08dabe4c92c6 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7QkbjbAL+qsXYi457l8M8GrsH5MkOnpQf9GF+wvUmiqISHtmaQifYF5mYNfqOfDUayVn4KRvn2XZU49P3shImUqhMrHqC4kz1gaSUJ6K1+qyeJJCsf0HQ/lXW1mrTw8rgxIoCPim9xpO7MBEDnxqJpBoSrikQK1vvwjoSwhpx8M6NZ4SxsiJfvv1mfBM46EHRnY9cp8tuoMNOUOTSfKzXSFqtyXqZadZTPlNLHehB1WxIfBcB5aQrgIHEzRQB3q3X8xcXa5T22PvXMRZMEj4uvEfunTpGNzfBbpYnuL9woxBNX7z2najXYOd1Yz6W8PNK6pVFUMELP2CAsJIK9hC46tBjXNka07Hybmmaj8dKnyWHXI9xYod5qhDL/TfPXzd0oUTzOGMkS302rHExZolSRnLev9Vppw4249MnVJr9toghbEL420pknkrwBGISN13nxmzUNS89Jy+fiU+qzMN5ym4xmyThKiwzq/gE5CB4gTXRuDrNK+2p6X3zOXkOob506LQ2DAH/S/E5iyb3UKd0rG6DPftXSBfSGR8WksciWe9LUO8zC51zFV9UbYqxyGiYzOvdu0ghvP2PKukUerKQ5MvYTBDKRDyfcCcqjzS/QRiClLxxioZNpWo06tEULuvSx+3OerFWBszn2zJtEIIH9KU8oX8HCoLzPtXAWBi+w0y4jggOSmsL7ukvBMxZINwotlkA4+uXAh5n5PwaDphUuVoV39hCz9nGmeBLWIVkh7kNlaBRBZC2ypu9c5qWiBI2C6qDpyxk/ERrFqJFN/XmOnbkbmJr5TzBFJZZOXu2E47F0HrkvH9md7bY6bMaP8A X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(136003)(396003)(346002)(451199015)(36840700001)(46966006)(40470700004)(36860700001)(70206006)(36756003)(356005)(40480700001)(81166007)(82310400005)(86362001)(40460700003)(82740400003)(316002)(7696005)(70586007)(4326008)(6916009)(6666004)(54906003)(478600001)(44832011)(1076003)(336012)(186003)(2906002)(8676002)(5660300002)(83380400001)(8936002)(426003)(2616005)(47076005)(26005)(41300700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5823 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 94bec33c-1055-47e4-0ec7-08dabe4c8d7e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UkPojLnNEy9Q7T+tbBRWCZR5ekBk2+Tr56cooq1Fz3EhpBEKKW61WAwP84zD05CXk0YRnMd8llhfaxQzuepyIAcTQa5wAe08wfMnvPBzNKZ/9ZpXsf4KcsPXb2Kh9Sip6UoP8GxfThxNYQD3uOp52h0G7DD+885m1GCs8ODYJXO32zhS+/TlzLYL/vADT8Q4A1RMSdSD4WNgnQ7XX4s6oew6P9lHy/vvgv1BS2jioWHaCN+5mN8dkfEnARz1vxwkcsRji/tfn/I1yC43ES8KTaAj7WpxLwc2p7mKuCdV3AwKxkciKeZDDUCqhZedLhD+fvo/S1Ut0M+YeMsxkUnMxmkh2thB/aU+1VkEMQQKrEqfMIPvVcKLXb1vh0OAiXr66AkSeyZxEVlklsoInJR+lUkakVdzQJNrWqBQFCyUqJHsSns0LQ5BOoo0ABCjUm2nkUv42cMUbMn6v3vTSbHyThWAzWMHTVbZQoKGTyxFTAbsxuY21/o9u1t3gGrNN9fAbOXu1xhC1N2mT7X0IyixYr0sUmnAUqwHRh73RQI57XOBXg+vC/MapvtrURAZbq82SLNeLrT8pWDJeJddT8kgz7zlhtEaGnpFq8WHDTzDcEPVHePFlpExJt3+kDSBtn6fUla6xHhMntnZ/dqNA0IWHX22f8ZmsXPE6nE7V9yNpUYCktw28wO0dOiepjInFqAOTzBjB0ghpkn7w8h6yRX/cL+YPCdD00TPd+Ze1tQ6dd3GVDGL7kvIW40vK2lkpr0tWDPhAtEhXEDpLX5ydu/RNA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(39860400002)(346002)(451199015)(40470700004)(46966006)(36840700001)(7696005)(26005)(6666004)(2616005)(44832011)(478600001)(70586007)(336012)(426003)(47076005)(40460700003)(5660300002)(83380400001)(1076003)(186003)(36756003)(8676002)(4326008)(70206006)(82740400003)(316002)(54906003)(82310400005)(81166007)(86362001)(8936002)(6916009)(2906002)(41300700001)(36860700001)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:08:51.5653 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ab9ddcbc-d674-4385-ff3c-08dabe4c92c6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5400 From: Penny Zheng setup_fixmap and remove_identity_mapping are two functions that are used in Xen boot-time code flow. We implement these two functions for MPU system, in this case, the code flow in head.S doesn't need to use #ifdef to gate MPU/MMU code. In MMU system, setup_fixmap is used for Xen to map some essentail data or devices in boot-time. For MPU system, we still have this requirement, we map the early UART to MPU protection region when earlyprintk is enabled. This also means PRINT can't be used after turning on MPU but before setup_fixmap. This restriction is the same as MMU system. For remove_identity_mapping, we just need an empty function to make head.S code flow happy. Signed-off-by: Wei Chen Signed-off-by: Penny Zheng --- xen/arch/arm/arm64/head_mpu.S | 49 +++++++++++++++++++ .../arm/include/asm/platforms/fvp_baser.h | 4 ++ 2 files changed, 53 insertions(+) diff --git a/xen/arch/arm/arm64/head_mpu.S b/xen/arch/arm/arm64/head_mpu.S index 5a1b03e293..336c0a630f 100644 --- a/xen/arch/arm/arm64/head_mpu.S +++ b/xen/arch/arm/arm64/head_mpu.S @@ -20,13 +20,20 @@ /* * In boot stage, we will use 1 MPU region: * Region#0: Normal memory for Xen text + data + bss (2MB) + * Region#1: Device memory for EARLY UART, size is defined + * by platform's EARLY_UART_SIZE */ #define BOOT_NORMAL_REGION_IDX 0x0 +#define BOOT_DEVICE_REGION_IDX 0x1 /* MPU normal memory attributes. */ #define PRBAR_NORMAL_MEM 0x30 /* SH=11 AP=00 XN=00 */ #define PRLAR_NORMAL_MEM 0x0f /* NS=0 ATTR=111 EN=1 */ +/* MPU device memory attributes. */ +#define PRBAR_DEVICE_MEM 0x20 /* SH=10 AP=00 XN=00 */ +#define PRLAR_DEVICE_MEM 0x09 /* NS=0 ATTR=100 EN=1 */ + .macro write_pr, sel, prbar, prlar msr PRSELR_EL2, \sel dsb sy @@ -69,6 +76,48 @@ ENTRY(prepare_early_mappings) ret ENDPROC(prepare_early_mappings) +/* + * In MMU system, setup_fixmap is used for Xen to map some essential data + * or devices in boot-time. In order to be consistent with MMU system, we + * inherit the function name for MPU system. + * setup_fixmap of MPU system will: + * - Map the early UART to MPU protection region when earlyprintk is + * enabled (The PRINT can't be used after turning on MPU but before + * setup_fixmap). + * + * Clobbers x0 - x3 + */ +ENTRY(setup_fixmap) +#ifdef CONFIG_EARLY_PRINTK + /* Map early uart to MPU device region for early printk. */ + mov x0, #BOOT_DEVICE_REGION_IDX + ldr x1, =CONFIG_EARLY_UART_BASE_ADDRESS + and x1, x1, #MPU_REGION_MASK + mov x3, #PRBAR_DEVICE_MEM + orr x1, x1, x3 + + ldr x2, =CONFIG_EARLY_UART_BASE_ADDRESS + ldr x3, =(CONFIG_EARLY_UART_BASE_ADDRESS + EARLY_UART_SIZE - 1) + add x2, x2, x3 + and x2, x2, #MPU_REGION_MASK + mov x3, #PRLAR_DEVICE_MEM + orr x2, x2, x3 + + /* + * Write to MPU protection region: + * x0 for pr_sel, x1 for prbar x2 for prlar + */ + write_pr x0, x1, x2 +#endif + + ret +ENDPROC(setup_fixmap) + +/* Stub of remove_identity_mapping for MPU systems */ +ENTRY(remove_identity_mapping) + ret +ENDPROC(remove_identity_mapping) + /* * Enable EL2 MPU and data cache. Because we will disable cache * with MPU at the same time, in accordance with that, we have diff --git a/xen/arch/arm/include/asm/platforms/fvp_baser.h b/xen/arch/arm/include/asm/platforms/fvp_baser.h index 9450a411a9..acde3541a1 100644 --- a/xen/arch/arm/include/asm/platforms/fvp_baser.h +++ b/xen/arch/arm/include/asm/platforms/fvp_baser.h @@ -11,4 +11,8 @@ #define XEN_START_ADDRESS CONFIG_XEN_START_ADDRESS #endif +#ifdef CONFIG_EARLY_PRINTK +#define EARLY_UART_SIZE 0x1000 +#endif + #endif /* __ASM_ARM_PLATFORMS_FVP_BASER_H__ */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:19:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:19:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437469.691896 (Exim 4.92) (envelope-from ) id 1oqtne-0000bV-Mp; Fri, 04 Nov 2022 10:19:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437469.691896; Fri, 04 Nov 2022 10:19:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtne-0000bO-JT; Fri, 04 Nov 2022 10:19:46 +0000 Received: by outflank-mailman (input) for mailman id 437469; Fri, 04 Nov 2022 10:19:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtdB-0001vd-82 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:08:57 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80054.outbound.protection.outlook.com [40.107.8.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id afe62616-5c28-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 11:08:54 +0100 (CET) Received: from DB3PR08CA0028.eurprd08.prod.outlook.com (2603:10a6:8::41) by AM9PR08MB5921.eurprd08.prod.outlook.com (2603:10a6:20b:2d4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Fri, 4 Nov 2022 10:08:51 +0000 Received: from DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:0:cafe::3a) by DB3PR08CA0028.outlook.office365.com (2603:10a6:8::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 10:08:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT040.mail.protection.outlook.com (100.127.142.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:50 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Fri, 04 Nov 2022 10:08:50 +0000 Received: from cf95ada5a01b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F94D1F2F-5D77-4783-AD72-315D7F3DCBBF.1; Fri, 04 Nov 2022 10:08:44 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cf95ada5a01b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 10:08:44 +0000 Received: from AS8PR04CA0141.eurprd04.prod.outlook.com (2603:10a6:20b:127::26) by GV2PR08MB8344.eurprd08.prod.outlook.com (2603:10a6:150:c0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 10:08:41 +0000 Received: from AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:127:cafe::c8) by AS8PR04CA0141.outlook.office365.com (2603:10a6:20b:127::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.21 via Frontend Transport; Fri, 4 Nov 2022 10:08:41 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT025.mail.protection.outlook.com (100.127.140.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:41 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:37 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:37 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 4 Nov 2022 10:08:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afe62616-5c28-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=eDjEirHGu+btAIGZUxhGQ62kpA+tyYQoJwIWJwei/E8KLoK9NmsYzOM4cXpLw5MAU5Uj1sIEX0vUrkP9SKwRXs7fDC7GjBYjBXfMEatoq8DHcrQFKGF+aI0aXV68xHuA2gaZ4iwGxtQnDrurKmOJOgEf3sf/ynnFiB9nmu/C7jlbjjV9LMiz65Iao8Vp0Z4kkzfA0wkkAGYBDqxCkF9jlioB5ZlG1Z4Jw/qPWdalZynMIi6zNdXaz2paZc9adfpzZ+gv8zSaq6nFUkSVeg0YqmowLGRDISaHnZ2BBce6n6x+3A7FElEOQ6pns0DpU/FF97XIHuwNnPgItLBV+Mi58Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CMfl5+3GdSMw3LrCIRYTsE7TNrypLt4CfBNsRud2G8c=; b=DgU1HGMhsPTUCOpdZTROseHWww2A3MAGcS7fH2EBLD8t+mB8Mdev89CFfpI3P5T4/csNnQbczKjcSCVtPdv80jNP6I0YGX3rCyxk3+al3iPl2sXCZRyvf7gZcLlmGY8C0El3A76gDAVAf0hiousdwZFZ1FvRaogMsQxr6e2LusAsKgkQupo7o7C6R4hp828JquKR48dbnCsZofocIPZgLakWz8uu1Cd0s4Ry+Ah+zD0uqBIbQMIbwp0vlWRZX3XMMonG5ikBoUoVb1ogRWO06cTlzLoLXMB86JRcPp5AOgfRcY+I3utFj61U+IJRq8v+QIMbDU65/AKhXYAEaLfS9w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CMfl5+3GdSMw3LrCIRYTsE7TNrypLt4CfBNsRud2G8c=; b=HoDHy0eJM5az/HUbzTHmEojHtdlO8zcdpirgv/BHfhSjHP6y7SPmXdUChRrlAEbRprOWxWhvgX8QOmilKhxft1tSKVcN/QPDUcVj8cATCNO3tG+aYfYrgiJjsmEK1s+YJoUeN6dbsWhAqw+9LaJ2dR5y7nm1uw8KXo5Ytdw7Odc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: dcda8abdaa1cd753 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VqGjtyfsbyx/rE3GMZVK//3szsOcLNjMnbslH0JniCwHsYgc+EJAdMWQmkxW46CpX9QjjFnkB4LFSr2ZphwIC8lMoTc0OE7AUyhkAPDYFaTBv7qCwa+z6uJcruVIE/rw2+7ibJxW8SjM5+mhBJ5lFeBWJQ8/wrsLTLKPvSEe9c7bw9PfNTGZKuKEC78ZSYYDVVIg/ei7+G/s4uciD7wSXawfgWG2ugMdJDYXMPTnM6b2cAgCkloQlo/7peld0TXDMymdbqTo05jQu2+onuJW55Alic4+oB1OXHVaAkS4P9HOQDTPvz7zHLHVZ+IPpJxveEKZFdDocQw4I+AuwfglIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CMfl5+3GdSMw3LrCIRYTsE7TNrypLt4CfBNsRud2G8c=; b=mB45yfV83gTxveVnhgXIxH/P9WFelYD/YkwuG6cczHpCyuPkbzdc9Icuk2luTbZR5YxBlCL22qjNB3m7P+mevTnIIqeSdbWCf/eE0LyyrOQmCMpBRxU4Aa2YrWV2NczUbpJzqKVj76MsyjDxqxvphtkr4i93l+knfou0MI8f76xvEy8Sid4zeObqnbkJ5xhnFMyZjm3cSEAqUie/ZuxfJIN37t1BujTlRtRY1qdhzEo4bxlmZxjCZXsuGFbZQbxmS0lx6woWlkz+lhSSFs5sMmRI8DDv/ftyWeHrVqDZp17m6GqqyAoiGt4EA/426LLFyzI0qge+NjYgXLlXRhvHiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CMfl5+3GdSMw3LrCIRYTsE7TNrypLt4CfBNsRud2G8c=; b=HoDHy0eJM5az/HUbzTHmEojHtdlO8zcdpirgv/BHfhSjHP6y7SPmXdUChRrlAEbRprOWxWhvgX8QOmilKhxft1tSKVcN/QPDUcVj8cATCNO3tG+aYfYrgiJjsmEK1s+YJoUeN6dbsWhAqw+9LaJ2dR5y7nm1uw8KXo5Ytdw7Odc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Wei Chen Subject: [PATCH v6 10/11] xen/arm64: introduce helpers for MPU enable/disable Date: Fri, 4 Nov 2022 18:07:40 +0800 Message-ID: <20221104100741.2176307-11-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221104100741.2176307-1-wei.chen@arm.com> References: <20221104100741.2176307-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT025:EE_|GV2PR08MB8344:EE_|DBAEUR03FT040:EE_|AM9PR08MB5921:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ff2786d-cd62-4a0d-739a-08dabe4c9258 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 13jkDVDXaYbfsA06061addFV6g/Rg+VOK1MJvJdrmZTetL1RBU/VMMrHfSnDcTW4c2zsRLK08s8+Qf6Phy6XRs2jqv9PEQK2fx4EfQKwrmEWUrQNr3jLfXdpD2amtx33tDqyOMTsPZBMQ0kIUSRpRTsvQWsmeleIzghyc3v7Vg93aQaPXTb/0OOLDzv3CBCTyfEaUrOyuq/Teh+2DmgZeo6y1cpBEgE9gXanivpUg4tRl4dHI3CFZNDJotwtRyWUG9yMEAuhw+ptNL+emjqD6i3Gop3Eq8RchKNKQZE8nBzRKfY5Bh9FY9CdYM+XKErw8vwvN/uVlIlRvOhjHJIeyTXsBZ2aWp9FP69Zw2crlOmA8lSVDZHJ4rcW0Q5ohkSUuYr5vMD8sLan5wYyb31UktgCGbVzRhYM7CPVEjbMAaMlKKx0TWq5kL8KulHSA7+ZxH7CEgmq4zJmmcoXN7k5Aq1GDAtIpZt9Y8GeLoZN+q0YSQc6JsSZDG5YiEJtHQmv6ptX4/PGac63/Mnf4ktJhitRD1EvlNorsAZBlUThwzOsLkj1Mk5ApGID8dl3kHBOzijcxaEdidki7lMSyfgh6Z+o8U0U6ijybxojDA/xxjUCzpDeKSp+Yon82fd8x6XvedpyyJVPgW2WDxMbFIzgcG67TIMJF/t0uCLz6WhDU7gKdbW9V57/2ZCWuutkiTBaOYDqsDFiSDRop0GjSatg0njBzrQVZDdMb+7AWLImP47F4DAZxx9qrlFKE9jjUeOPUXJVlMGGVtzhWpVbhCnorUcftGxHI2eZ0Cbd65pbPV2ghNI0S007WLYGxhYNRW40 X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199015)(40470700004)(46966006)(36840700001)(356005)(2906002)(81166007)(82310400005)(40480700001)(40460700003)(36756003)(86362001)(41300700001)(70586007)(8676002)(70206006)(4326008)(336012)(2616005)(44832011)(7696005)(5660300002)(186003)(8936002)(478600001)(1076003)(6916009)(54906003)(6666004)(82740400003)(316002)(36860700001)(26005)(426003)(47076005)(83380400001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8344 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4729a15c-73ab-47b0-f3db-08dabe4c8cbc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T1tdgX0NflLlczCr1KI2Ky8HCij2Jeq6JLPZHGoAhU52/f0jixs1vvllVN5qlxafr0eP0WQbK7igMVbUWSSud3yzKxNuxIotElJCLpa89yZABzgcCE6bj2RlFQlUuUK1TkRX7meFyjLC60b/Z/uGkaWGHuWDYS8llGffdX+pl4Hh2Vi7ZAPpeKnkC3WW6djLtNHXoN8eRGfsY/1GFMmlT/iobovlTaQH2Oh61hlHZO+L4EsFXIKbwfj2+6wm/MZ/iyLFti7o0rfJT795iiVnjG0HkWz4iXU6wxI7jNqn9zylNMWdKGurJ/EFlzVyb+kiUGiO0E0SAlFfn7fiycCOys00kxw6kwmmg4XgT+gn2INSYHShXsqSSexMEU1yjNrfMX1RH2G2XNL6hvP76BaYLddUumR7jj07UZtSUFzDeTUT5SylFId3/cXusRN5Tr3rphdFLi2Af6/Jpvwmu1MEJYutVsp8Oe4PoPsf7+vZDJ9Gnh51tK3LtgJlS9UnKNiptn8qt+xp7DpIramnMFDEWOM+PCfds7qk0qt71YPnhOIHNz+OvEB4I0UtT2YP85YMJXsYCqOWVvbTSjXRSMM+Wmw6b1fobWTkGANZYiFLI4YSOkZMKf4rLYRJZh1oYc3e5AAMGsx6p7YhoPOu/zRfsY0H5U78e5hOcx4efJI0ZQYXXJpzfpKXdNzwZo5cCKpjtF9axJYBoRXeR9oR3EuP3NmGjJn1prLnMSIz3+GV26+X1tUF6NN67mUSC7eYbd88aksAxNXr9SePfvlFsfG30A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(136003)(376002)(451199015)(36840700001)(46966006)(40470700004)(186003)(336012)(7696005)(2616005)(1076003)(83380400001)(6666004)(426003)(36860700001)(26005)(47076005)(82740400003)(54906003)(44832011)(2906002)(40480700001)(40460700003)(316002)(8676002)(5660300002)(478600001)(8936002)(82310400005)(41300700001)(4326008)(70586007)(70206006)(6916009)(36756003)(81166007)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:08:50.8408 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4ff2786d-cd62-4a0d-739a-08dabe4c9258 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5921 From: Penny Zheng We need some helpers for Xen to enable/disable MPU in boot-time and runtime. For MPU enable helper, we know that it's an essential requirement of MPU system. But for MPU disable, we need to use it for some special situations. For example, in the progress of tranferring from boot-time to runtime, we need to update the MPU protection regions configuration, but we can't modify an MPU protection region if there is some data accessed by Xen. But in boot-time all of Xen text, data and BSS are in one MPU protection region, if Xen want to update this protection region, above restriction will be triggered. So in this situation, we need to disable the whole MPU to update the protection regions. In these helper, enable/disable MPU will also enable/disable the D-cache. There are two reasons for it: 1. Make the function semantic be consistent with enable_mmu. For MMU systems, enable_mmu will turn MMU and D-Cache at the same time. 2. When MPU is disabled, the MPU background attributes will be used. On some platforms, the background will treat all memory as device memory. The access to device memory will bypass the cache, even if the C bit is enabled in SCTLR. To avoid this implicit behavior, we disable cache with MPU explicitly to tell user that when MPU is disabled, the memory access is uncacheable. In this patch, we also introduce a neutral name enable_mm for Xen to enable MMU/MPU. This can help us to keep one code flow in head.S Signed-off-by: Wei Chen Signed-off-by: Penny Zheng --- xen/arch/arm/arm64/head.S | 5 +++-- xen/arch/arm/arm64/head_mmu.S | 4 ++-- xen/arch/arm/arm64/head_mpu.S | 35 +++++++++++++++++++++++++++++++++++ 3 files changed, 40 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 6c1a5f74a1..228f01db69 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -255,7 +255,8 @@ real_start_efi: * and protection regions for MPU systems. */ bl prepare_early_mappings - bl enable_mmu + /* Turn on MMU or MPU */ + bl enable_mm /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ ldr x0, =primary_switched @@ -313,7 +314,7 @@ GLOBAL(init_secondary) bl check_cpu_mode bl cpu_init bl prepare_early_mappings - bl enable_mmu + bl enable_mm /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ ldr x0, =secondary_switched diff --git a/xen/arch/arm/arm64/head_mmu.S b/xen/arch/arm/arm64/head_mmu.S index fc64819a98..b542755bd2 100644 --- a/xen/arch/arm/arm64/head_mmu.S +++ b/xen/arch/arm/arm64/head_mmu.S @@ -217,7 +217,7 @@ ENDPROC(prepare_early_mappings) * * Clobbers x0 - x3 */ -ENTRY(enable_mmu) +ENTRY(enable_mm) PRINT("- Turning on paging -\r\n") /* @@ -239,7 +239,7 @@ ENTRY(enable_mmu) msr SCTLR_EL2, x0 /* now paging is enabled */ isb /* Now, flush the icache */ ret -ENDPROC(enable_mmu) +ENDPROC(enable_mm) /* * Remove the 1:1 map from the page-tables. It is not easy to keep track diff --git a/xen/arch/arm/arm64/head_mpu.S b/xen/arch/arm/arm64/head_mpu.S index f60611b556..5a1b03e293 100644 --- a/xen/arch/arm/arm64/head_mpu.S +++ b/xen/arch/arm/arm64/head_mpu.S @@ -68,3 +68,38 @@ ENTRY(prepare_early_mappings) ret ENDPROC(prepare_early_mappings) + +/* + * Enable EL2 MPU and data cache. Because we will disable cache + * with MPU at the same time, in accordance with that, we have + * to enable cache with MPU at the same time in this function. + * When MPU is disabled, the MPU background attributes will + * be used. On some platform, the background will treat all + * memory as IO memory. The access to IO memory will bypass + * the cache, even you have enabled the C bit in SCTLR. + * To avoid this implicit behavior, we disable cache with MPU + * explicitly to tell user that when MPU is disabled, the memory + * access is uncacheable. + */ +ENTRY(enable_mm) + mrs x0, SCTLR_EL2 + mov x1, #(SCTLR_Axx_ELx_M | SCTLR_Axx_ELx_C) + /* Enable EL2 MPU and D-cache */ + orr x0, x0, x1 + dsb sy + msr SCTLR_EL2, x0 + isb + ret +ENDPROC(enable_mm) + +/* Disable MPU system, including data cache. */ +ENTRY(disable_mm) + mrs x0, SCTLR_EL2 + mov x1, #~(SCTLR_Axx_ELx_M | SCTLR_Axx_ELx_C) + /* Disable EL2 MPU and D-cache */ + and x0, x0, x1 + dsb sy + msr SCTLR_EL2, x0 + isb + ret +ENDPROC(disable_mm) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:20:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:20:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437485.691907 (Exim 4.92) (envelope-from ) id 1oqto2-00025j-1n; Fri, 04 Nov 2022 10:20:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437485.691907; Fri, 04 Nov 2022 10:20:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqto1-00025c-VH; Fri, 04 Nov 2022 10:20:09 +0000 Received: by outflank-mailman (input) for mailman id 437485; Fri, 04 Nov 2022 10:20:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtd5-0001vd-7A for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:08:51 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2086.outbound.protection.outlook.com [40.107.247.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ac9f044e-5c28-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 11:08:48 +0100 (CET) Received: from DU2PR04CA0031.eurprd04.prod.outlook.com (2603:10a6:10:234::6) by DU0PR08MB7461.eurprd08.prod.outlook.com (2603:10a6:10:354::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Fri, 4 Nov 2022 10:08:45 +0000 Received: from DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:234:cafe::c3) by DU2PR04CA0031.outlook.office365.com (2603:10a6:10:234::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT017.mail.protection.outlook.com (100.127.142.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:45 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Fri, 04 Nov 2022 10:08:45 +0000 Received: from ceb771fe5de4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0BFBB272-F530-4515-8EF4-20AFEBC2A0B1.1; Fri, 04 Nov 2022 10:08:37 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ceb771fe5de4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 10:08:37 +0000 Received: from DB6PR07CA0024.eurprd07.prod.outlook.com (2603:10a6:6:2d::34) by GV1PR08MB8378.eurprd08.prod.outlook.com (2603:10a6:150:a7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 4 Nov 2022 10:08:35 +0000 Received: from DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2d:cafe::55) by DB6PR07CA0024.outlook.office365.com (2603:10a6:6:2d::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:35 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT019.mail.protection.outlook.com (100.127.142.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:08:35 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 4 Nov 2022 10:08:34 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 4 Nov 2022 10:08:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac9f044e-5c28-11ed-8fd0-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PLNcyejtY6/WEVJbaGzaKgu0ZHwWza4IQCCPqDTKli072GmB4ZScNjbIzzpvx4zoO241TjAalQMcXaagZcNSkpdnfUmr59r/E42At/WJe85ubyWHL6mxeQbF2+DGUe7MVfYx92yxkB3muGubxxXWnaPkKEwHs8fMu0TsYLmUJBCNUaH63S31GZ6kUlOU7AdCwSUj3UcrWhTA4Du7/lzoAkF6gAPtAp+Y/+4uYqGIa6XyewnuxSL/1EiHSLUYaOaDjE3p9JcciQx1VTlRMDS5mNopM2SCTS877u6rbZiFGEKMyT6tilwV9RJWcADuYLz4xUOdZC7DGXNw1M32AfvKiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uic3PsgqPkXcbmPMgwL4wCno3VZjcf0Iwj5c4HANmuQ=; b=Inp7CSP1fsIZgFAebqFappOa5MIiIdB7xstnBY8qrihe8IC/wWpTPFawvqJnhOXph0mk72r7/Dh6fhMEshGbIPiXxwULAr0bMenNqSGqhSuaEO4pa+NlnkNXLoHm4UjHs6bJ46qmZ2RVVyo+uBz4C2m6b/eGRKlZs1UaDQ+ui/QhKuxMjAFv4bBOS2bqYGyho0v17Al/z7pcEluxtnoBt34ShclGOmV+bk0l4SqkCD85brxphDLtN5D81BHsXfzg3XLh68DaacX5wLM2ZCdNWXj/VDVsc2JmC1ABBqQob7I5YHqFQvVZJDHJ2feykPMD5viTziBBKMPqqvD8JvBtWA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uic3PsgqPkXcbmPMgwL4wCno3VZjcf0Iwj5c4HANmuQ=; b=AfSHcCNNuRFDOFT5j5arSkXDGGWiLWj9dNIRtNRbjUqlUUom2hK0RhYUvqSKqNoh1pNVsJmYWjwqy054tSEASVeGfQgx6kWpXwatMg+DnfCN4rasmhvnIgsOjzmSBz6sUShXmGPBnQrMolN7Exq7v9ln6qe3YmE9kB0rKMN3s9k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: eda649b03a586408 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q+5mwNRWq7GST6dBN5ahyCUCl6FncvMKvyihbadkagTHK7pHnQMnT8pddsNyQLe3Ax3CvsNtZLiIs43fnGUWEjTM1VAP2r4doK334v/SQ1/TOlWWL98gDgRlP5249ZV1MmPJjS6J69Ml+che5Myf8nX9nTuIosgJfGcCmvGqBBTcwRtNQecWaGQhxOjIAW6wD3/7tje1VWseG3In6/31wqpzF5O3TSFxjG4oyK+YmvAehJgM0xmjaJrwbaTDhEHr335Wh45jCqeupUd6OIsXHbhDHDOyJyUw+JdBnatYls7WRHpLmjgJs5cVFyLPPIM1/OVv+JXYZ/LKYgNZBtbJxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uic3PsgqPkXcbmPMgwL4wCno3VZjcf0Iwj5c4HANmuQ=; b=dvqneko4RNYsYPU4dSTzPPPQkBk1UWFUEFcJ9IZQgT7Ga1rdySMBEn9ManIzgBo5gulgtCzuL2Klm6xT34ZnapXwDjpvJeI3tEa9Vva+h5gz1VqdqKOVEfHjtAp1XRdp5hiJ9bL8aSH7Dj1WMFFGVwJnEMIs982yWTOSRbZPhmNTcU5NMP3cZyQf9V768WKueyhrqceev4owzop/Uh/vYZ4KQUtX0YJerCs4DjzqFnBqeQfNKnrwe5uKgwMNgrS/bASC0sOhNYe7KKrluSIolPbx+vszwFu173/6alLZgTH9D7UdXYIb03tYjxp8V48ljihkriOQhmSrESscUoumBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uic3PsgqPkXcbmPMgwL4wCno3VZjcf0Iwj5c4HANmuQ=; b=AfSHcCNNuRFDOFT5j5arSkXDGGWiLWj9dNIRtNRbjUqlUUom2hK0RhYUvqSKqNoh1pNVsJmYWjwqy054tSEASVeGfQgx6kWpXwatMg+DnfCN4rasmhvnIgsOjzmSBz6sUShXmGPBnQrMolN7Exq7v9ln6qe3YmE9kB0rKMN3s9k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Wei Chen Subject: [PATCH v6 09/11] xen/arm64: create boot-time MPU protection regions Date: Fri, 4 Nov 2022 18:07:39 +0800 Message-ID: <20221104100741.2176307-10-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221104100741.2176307-1-wei.chen@arm.com> References: <20221104100741.2176307-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT019:EE_|GV1PR08MB8378:EE_|DBAEUR03FT017:EE_|DU0PR08MB7461:EE_ X-MS-Office365-Filtering-Correlation-Id: 1288136f-ad87-4942-95f1-08dabe4c8f31 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YDz5fIJeSyTX9LXNBuPq6LGLd9xImAfIM7xMZdhKWCL77jFphZz9xhj00s4mq/2l2Qd3JnOnAMc1/tDWYn8I3TgeKtvoiBnOtLGP6xUi+zmzAR7XZiWA/4KHZheGF/N99Hb7yVnD6JiJiEXmVXVr0ZUMN2XBrBwqtb+i0IaBHZicffOBE9kpn4Fzer9evDSElbui0W6UEQlBS7yzqnbSG88vIXU4SgFqK4t5RBjq4cCoqLFcym924uUbzss/ggDQT2A+oE5U6iIN13XxJOB5WfC98qKz1KVNU/BN2OLoK95i5moVB7AgSVgCOshUshyQYLB9eDDwEKhyGkWcf3DYEo6nXRdIvUkluCh/oXhd/VfryVUU20C5hBQYMZHhttA8GH/aRSpOLFAGJgDqRIwerUHnpzITgUviKGOz8M2JM6TBJU/Tw+dgEP1CFu0mnYUcuzjJBtLs0tkqfUB2P7QroPKacwC5lePgOQ3T68GHAXXbi9LytMDamNGTo82xvIz0jlnToous0CHGRjmzQFlFKYPY+ynOPBIhDd1KImWbDqmcp7u4ve5xsRMsau7KSh2a8JfbsqjXWT5dMOxkvm3zXMTXiAPcgVSb8ItxOs7z6pqmeI4uwJJ5Y0fNNOktsbgpbNYF4oGyioT5nvFK4IzbKWAE0NJiZ5Q0EBIxlMRTdv2oXxzJz8uyJZQbtxyE+KFHk220TcN/M+XvrClzw7TgwYVLh49NSuscOwuTXCIlrAk67tAPzK+EXJQw/nZ4MzYvV3gdQTh7fJ0Aj7ZK2+nABn3i85SXph11S8mkZDv6bwrW6x8adaFRikRp81t+wekT X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(376002)(396003)(451199015)(46966006)(40470700004)(36840700001)(36756003)(81166007)(86362001)(356005)(82740400003)(44832011)(1076003)(70586007)(6916009)(40480700001)(5660300002)(336012)(426003)(47076005)(2616005)(36860700001)(478600001)(7696005)(40460700003)(186003)(83380400001)(26005)(8936002)(8676002)(54906003)(70206006)(2906002)(316002)(82310400005)(4326008)(41300700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8378 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 39221e05-c9ed-44e5-cf1c-08dabe4c891d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GyRyp1En9LbocdSwDhaWiKN87O/T3u2+3wMJ/HOpZwLQh7IgGn5QJ+86gQNJRy03CxjA+zivERxauDMGz7x1aSiAAE/XiP2vnP50jEY56ZtRoHbvxE/yXbOTb7MUgGy2dKRtJG+tBKJy1INpGz3Jn5+9fgXTlISv8MqQH1DQlZCjVcBIDL2tCU8VUIynvGQyIJpILlTBhOgTuMp4OIOsxo97VQrlNsy9qh8CArXf6DYgQk9h0MdWkyXdVdNSBC6Q9Rw5FtJ6xcipLCX1LVx+oTWBlCi2S17XaXPdxUYBN9OkgdUDkVGMI43QQxANeBOLg8eqvkF5+cNG41SUrayE3sgA2Z1BYi6hZsK1QxtBJoeuL5aacFUK8vGvTB+PDf/qizbYMAktMqo/V25nV+Lk/aypW7fa5/Z36duOwlBdSkBLBaLLCWxQex/MXMiP/GuiCijLq+8RdFa+Wp/qjGhCP838RIPOWtMwn/w2MW8tadDSPneMsrsUgoY3Ao5yaLFUJMBCrUd46qF1VkqsFA6dDBDRhz6mSiJKwFNT7uxRtDYZ4ADXxwLv6ALudSEs5omfbryc82cuD4RxOEklDEghpuYdE/tJbb8qX/RrSoH+wNpWg1qbQ4WWYZ5YTT+Y2ykzmtuS6OMGbNbdLGtAhWh+LoCS8e8qo61RAgCT/KINwp/0ME3TlFWMN4WVB+9wSjXjJSjarpMwwerwZr8jWJpZX1qyFx3X/exJERrHemou43+F70I+vGXL+/A/rGOrcEgwNZYr6l/OmIPx/wVLGW5QzQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199015)(46966006)(36840700001)(40470700004)(4326008)(86362001)(81166007)(36756003)(82310400005)(8676002)(40460700003)(70206006)(7696005)(40480700001)(70586007)(316002)(83380400001)(336012)(8936002)(478600001)(2906002)(5660300002)(1076003)(44832011)(2616005)(426003)(6916009)(36860700001)(54906003)(41300700001)(82740400003)(26005)(186003)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:08:45.5529 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1288136f-ad87-4942-95f1-08dabe4c8f31 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7461 From: Penny Zheng Like boot-time page table in MMU system, we need a boot-time MPU protection region configuration in MPU system so Xen can fetch code and data from normal memory. This operation need to access Armv8-R MPU system registers, but these system registers are not supported in GCC version < 11. So we have to encode these Armv8-R MPU system registers in header file explicitly. As MMU system and MPU system have different functions to create the boot MMU/MPU data, this will introduce extra #ifdef in code flow, so we introduce a neutral name prepare_early_mappings to replace create_page_tables for MMU and MPU. Signed-off-by: Wei Chen Signed-off-by: Penny Zheng --- xen/arch/arm/arm64/Makefile | 2 + xen/arch/arm/arm64/head.S | 13 ++-- xen/arch/arm/arm64/head_mmu.S | 4 +- xen/arch/arm/arm64/head_mpu.S | 70 +++++++++++++++++++ xen/arch/arm/include/asm/arm64/mpu.h | 13 ++++ xen/arch/arm/include/asm/arm64/sysregs.h | 89 ++++++++++++++++++++++++ 6 files changed, 185 insertions(+), 6 deletions(-) create mode 100644 xen/arch/arm/arm64/head_mpu.S create mode 100644 xen/arch/arm/include/asm/arm64/mpu.h diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile index 22da2f54b5..438c9737ad 100644 --- a/xen/arch/arm/arm64/Makefile +++ b/xen/arch/arm/arm64/Makefile @@ -10,6 +10,8 @@ obj-y += entry.o obj-y += head.o ifneq ($(CONFIG_HAS_MPU),y) obj-y += head_mmu.o +else +obj-y += head_mpu.o endif obj-y += insn.o obj-$(CONFIG_LIVEPATCH) += livepatch.o diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index d9a8da9120..6c1a5f74a1 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -79,12 +79,12 @@ * --------------------------- * * The requirements are: - * MMU = off, D-cache = off, I-cache = on or off, + * MMU/MPU = off, D-cache = off, I-cache = on or off, * x0 = physical address to the FDT blob. * * This must be the very first address in the loaded image. * It should be linked at XEN_VIRT_START, and loaded at any - * 4K-aligned address. All of text+data+bss must fit in 2MB, + * 4K-aligned address. All of text+data+bss must fit in 2MB, * or the initial pagetable code below will need adjustment. */ @@ -249,7 +249,12 @@ real_start_efi: bl check_cpu_mode bl cpu_init - bl create_page_tables + + /* + * Create boot memory management data, pagetable for MMU systems + * and protection regions for MPU systems. + */ + bl prepare_early_mappings bl enable_mmu /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ @@ -307,7 +312,7 @@ GLOBAL(init_secondary) #endif bl check_cpu_mode bl cpu_init - bl create_page_tables + bl prepare_early_mappings bl enable_mmu /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ diff --git a/xen/arch/arm/arm64/head_mmu.S b/xen/arch/arm/arm64/head_mmu.S index 1a3df81a38..fc64819a98 100644 --- a/xen/arch/arm/arm64/head_mmu.S +++ b/xen/arch/arm/arm64/head_mmu.S @@ -123,7 +123,7 @@ * * Clobbers x0 - x4 */ -ENTRY(create_page_tables) +ENTRY(prepare_early_mappings) /* Prepare the page-tables for mapping Xen */ ldr x0, =XEN_VIRT_START create_table_entry boot_pgtable, boot_first, x0, 0, x1, x2, x3 @@ -208,7 +208,7 @@ virtphys_clash: /* Identity map clashes with boot_third, which we cannot handle yet */ PRINT("- Unable to build boot page tables - virt and phys addresses clash. -\r\n") b fail -ENDPROC(create_page_tables) +ENDPROC(prepare_early_mappings) /* * Turn on the Data Cache and the MMU. The function will return on the 1:1 diff --git a/xen/arch/arm/arm64/head_mpu.S b/xen/arch/arm/arm64/head_mpu.S new file mode 100644 index 0000000000..f60611b556 --- /dev/null +++ b/xen/arch/arm/arm64/head_mpu.S @@ -0,0 +1,70 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Start-of-day code for an Armv8-R MPU system. + */ + +#include +#include +#include + +/* + * From the requirements of head.S we know that Xen image should + * be linked at XEN_START_ADDRESS, and all of text + data + bss + * must fit in 2MB. On MPU systems, XEN_START_ADDRESS is also the + * address that Xen image should be loaded at. So for initial MPU + * regions setup, we use 2MB for Xen data memory to setup boot + * region, or the create boot regions code below will need adjustment. + */ +#define XEN_START_MEM_SIZE 0x200000 + +/* + * In boot stage, we will use 1 MPU region: + * Region#0: Normal memory for Xen text + data + bss (2MB) + */ +#define BOOT_NORMAL_REGION_IDX 0x0 + +/* MPU normal memory attributes. */ +#define PRBAR_NORMAL_MEM 0x30 /* SH=11 AP=00 XN=00 */ +#define PRLAR_NORMAL_MEM 0x0f /* NS=0 ATTR=111 EN=1 */ + +.macro write_pr, sel, prbar, prlar + msr PRSELR_EL2, \sel + dsb sy + msr PRBAR_EL2, \prbar + msr PRLAR_EL2, \prlar + dsb sy + isb +.endm + +.section .text.header, "ax", %progbits + +/* + * Static start-of-day EL2 MPU memory layout. + * + * It has a very simple structure, including: + * - 2MB normal memory mappings of xen at XEN_START_ADDRESS, which + * is the address where Xen was loaded by the bootloader. + */ +ENTRY(prepare_early_mappings) + /* Map Xen start memory to a normal memory region. */ + mov x0, #BOOT_NORMAL_REGION_IDX + ldr x1, =XEN_START_ADDRESS + and x1, x1, #MPU_REGION_MASK + mov x3, #PRBAR_NORMAL_MEM + orr x1, x1, x3 + + ldr x2, =XEN_START_ADDRESS + mov x3, #(XEN_START_MEM_SIZE - 1) + add x2, x2, x3 + and x2, x2, #MPU_REGION_MASK + mov x3, #PRLAR_NORMAL_MEM + orr x2, x2, x3 + + /* + * Write to MPU protection region: + * x0 for pr_sel, x1 for prbar x2 for prlar + */ + write_pr x0, x1, x2 + + ret +ENDPROC(prepare_early_mappings) diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h new file mode 100644 index 0000000000..d209eef6db --- /dev/null +++ b/xen/arch/arm/include/asm/arm64/mpu.h @@ -0,0 +1,13 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * mpu.h: Arm Memory Protection Unit definitions. + */ + +#ifndef __ARM64_MPU_H__ +#define __ARM64_MPU_H__ + +#define MPU_REGION_SHIFT 6 +#define MPU_REGION_ALIGN (_AC(1, UL) << MPU_REGION_SHIFT) +#define MPU_REGION_MASK (~(MPU_REGION_ALIGN - 1)) + +#endif /* __ARM64_MPU_H__ */ diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index 54670084c3..a596042d6c 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -458,6 +458,95 @@ #define ZCR_ELx_LEN_SIZE 9 #define ZCR_ELx_LEN_MASK 0x1ff +/* System registers for AArch64 with PMSA */ +#ifdef CONFIG_HAS_MPU + +/* EL1 MPU Protection Region Base Address Register encode */ +#define PRBAR_EL1 S3_0_C6_C8_0 +#define PRBAR1_EL1 S3_0_C6_C8_4 +#define PRBAR2_EL1 S3_0_C6_C9_0 +#define PRBAR3_EL1 S3_0_C6_C9_4 +#define PRBAR4_EL1 S3_0_C6_C10_0 +#define PRBAR5_EL1 S3_0_C6_C10_4 +#define PRBAR6_EL1 S3_0_C6_C11_0 +#define PRBAR7_EL1 S3_0_C6_C11_4 +#define PRBAR8_EL1 S3_0_C6_C12_0 +#define PRBAR9_EL1 S3_0_C6_C12_4 +#define PRBAR10_EL1 S3_0_C6_C13_0 +#define PRBAR11_EL1 S3_0_C6_C13_4 +#define PRBAR12_EL1 S3_0_C6_C14_0 +#define PRBAR13_EL1 S3_0_C6_C14_4 +#define PRBAR14_EL1 S3_0_C6_C15_0 +#define PRBAR15_EL1 S3_0_C6_C15_4 + +/* EL1 MPU Protection Region Limit Address Register encode */ +#define PRLAR_EL1 S3_0_C6_C8_1 +#define PRLAR1_EL1 S3_0_C6_C8_5 +#define PRLAR2_EL1 S3_0_C6_C9_1 +#define PRLAR3_EL1 S3_0_C6_C9_5 +#define PRLAR4_EL1 S3_0_C6_C10_1 +#define PRLAR5_EL1 S3_0_C6_C10_5 +#define PRLAR6_EL1 S3_0_C6_C11_1 +#define PRLAR7_EL1 S3_0_C6_C11_5 +#define PRLAR8_EL1 S3_0_C6_C12_1 +#define PRLAR9_EL1 S3_0_C6_C12_5 +#define PRLAR10_EL1 S3_0_C6_C13_1 +#define PRLAR11_EL1 S3_0_C6_C13_5 +#define PRLAR12_EL1 S3_0_C6_C14_1 +#define PRLAR13_EL1 S3_0_C6_C14_5 +#define PRLAR14_EL1 S3_0_C6_C15_1 +#define PRLAR15_EL1 S3_0_C6_C15_5 + +/* EL2 MPU Protection Region Base Address Register encode */ +#define PRBAR_EL2 S3_4_C6_C8_0 +#define PRBAR1_EL2 S3_4_C6_C8_4 +#define PRBAR2_EL2 S3_4_C6_C9_0 +#define PRBAR3_EL2 S3_4_C6_C9_4 +#define PRBAR4_EL2 S3_4_C6_C10_0 +#define PRBAR5_EL2 S3_4_C6_C10_4 +#define PRBAR6_EL2 S3_4_C6_C11_0 +#define PRBAR7_EL2 S3_4_C6_C11_4 +#define PRBAR8_EL2 S3_4_C6_C12_0 +#define PRBAR9_EL2 S3_4_C6_C12_4 +#define PRBAR10_EL2 S3_4_C6_C13_0 +#define PRBAR11_EL2 S3_4_C6_C13_4 +#define PRBAR12_EL2 S3_4_C6_C14_0 +#define PRBAR13_EL2 S3_4_C6_C14_4 +#define PRBAR14_EL2 S3_4_C6_C15_0 +#define PRBAR15_EL2 S3_4_C6_C15_4 + +/* EL2 MPU Protection Region Limit Address Register encode */ +#define PRLAR_EL2 S3_4_C6_C8_1 +#define PRLAR1_EL2 S3_4_C6_C8_5 +#define PRLAR2_EL2 S3_4_C6_C9_1 +#define PRLAR3_EL2 S3_4_C6_C9_5 +#define PRLAR4_EL2 S3_4_C6_C10_1 +#define PRLAR5_EL2 S3_4_C6_C10_5 +#define PRLAR6_EL2 S3_4_C6_C11_1 +#define PRLAR7_EL2 S3_4_C6_C11_5 +#define PRLAR8_EL2 S3_4_C6_C12_1 +#define PRLAR9_EL2 S3_4_C6_C12_5 +#define PRLAR10_EL2 S3_4_C6_C13_1 +#define PRLAR11_EL2 S3_4_C6_C13_5 +#define PRLAR12_EL2 S3_4_C6_C14_1 +#define PRLAR13_EL2 S3_4_C6_C14_5 +#define PRLAR14_EL2 S3_4_C6_C15_1 +#define PRLAR15_EL2 S3_4_C6_C15_5 + +/* MPU Protection Region Enable Register encode */ +#define PRENR_EL1 S3_0_C6_C1_1 +#define PRENR_EL2 S3_4_C6_C1_1 + +/* MPU Protection Region Selection Register encode */ +#define PRSELR_EL1 S3_0_C6_C2_1 +#define PRSELR_EL2 S3_4_C6_C2_1 + +/* MPU Type registers encode */ +#define MPUIR_EL1 S3_0_C0_C0_4 +#define MPUIR_EL2 S3_4_C0_C0_4 + +#endif + /* Access to system registers */ #define WRITE_SYSREG64(v, name) do { \ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:30:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:30:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437501.691918 (Exim 4.92) (envelope-from ) id 1oqtxk-0004Zr-1I; Fri, 04 Nov 2022 10:30:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437501.691918; Fri, 04 Nov 2022 10:30:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtxj-0004Zk-U1; Fri, 04 Nov 2022 10:30:11 +0000 Received: by outflank-mailman (input) for mailman id 437501; Fri, 04 Nov 2022 10:30:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqtxh-0004Ze-IJ for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:30:09 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20048.outbound.protection.outlook.com [40.107.2.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a68292ec-5c2b-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 11:30:07 +0100 (CET) Received: from AS8PR05CA0022.eurprd05.prod.outlook.com (2603:10a6:20b:311::27) by VE1PR08MB5662.eurprd08.prod.outlook.com (2603:10a6:800:1a9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 10:30:04 +0000 Received: from AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:311:cafe::50) by AS8PR05CA0022.outlook.office365.com (2603:10a6:20b:311::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:30:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT005.mail.protection.outlook.com (100.127.140.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 10:30:03 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Fri, 04 Nov 2022 10:30:03 +0000 Received: from 38e502c9f4b2.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 228A3F18-1179-4988-BE9B-28819182EADA.1; Fri, 04 Nov 2022 10:29:55 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 38e502c9f4b2.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 10:29:55 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by VE1PR08MB5822.eurprd08.prod.outlook.com (2603:10a6:800:1a7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 10:29:50 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5769.016; Fri, 4 Nov 2022 10:29:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a68292ec-5c2b-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hbE9X5IQNjl47ZvUuTxdQAmtUCiEpG78gvjzhsqAzc967HVbcxYY7J/PGyKKX1NdCydtNO2Y41yUfD70uB02Llvj2KCMCvIAGPyys3Y0aAz7pVl6W0VQyCA6zrsxIke/g3WAkRwJhQb5JQcmBZn/UdIcQY5HzrIAdFL8XqEjQU1h1r1RuCkRYyCFWwB0UQQwqVljWvlco/BS/ZyFp3QT4P/TJEiIXivhA3UIcbYkMUlQSr/4W2XhFsK+Yifgb645+v4DqsS2+eTlLoaL2WFuJ1b4R+RR3/HxYc8mfDyG5tmQ6Qx1TdKpXaec8frF2XgDYkd4tzqmGw345cDJy+25MQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W2/1Zk08baYKUnZ4Ze3qeMxNV80jfkU8x0Nla7XtZW0=; b=IY3Z2jT5ZxD3jIKUpopsbXq38FrNFORT1H1vGy3UZ2UOnUrGiQEMpsm/7RtuMkQcUCTMwKvKdvLUiw6dw3PpJUEG1ZOe5QiEcsFMC0mOEkg4nD16CqCoI9xL0U9ZYSM/7mdgbhsLF+yHHtkGJHTS3mQT3hPsjA2OLyYgk9C76PrBXoXRRDEA1CZFGZ+tS03J1OIXwiyTxMf4e4IV9vsWNdABvr6a4fzHD6HNK65Es48pvDBi6gPvHDmnvilcTppAAB/HXjLT55ctznW35MMqq02qxSGM9Lab+ee3Uq3xKWGEfY3jwavDpgpex82i72BIMZg3fJ2miS3ShfhF0sGBbQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W2/1Zk08baYKUnZ4Ze3qeMxNV80jfkU8x0Nla7XtZW0=; b=x/OdtfAtPbItRjkzdM4yEOUwhT9T5I7i0OS+Ca4B8KByD7WpatuLsFMlSliVxuP5lg2VjnEWcEMFjfcWOIVxKkRCtkCs3YeHB3Q+qL6IUj3tlbZQRGjU9WO+hJCL2b7wpHoRyX0k+ChrybOyzJscCFVMGOX8YAtbw2fbqL4Ggp8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dZMNhzB7YbqnpARmna1PFC8nvMoiBbwJZIaTnaEt0cUzHewVQNbQWXFYbxc/dXqy2Qo1ueTQP7iGow3LQQ1irH4Ansy3ZW495Pd/ZIiOgkKtQEItz/AaX4mYUxp/aumfjwNyE+AqxULHtqMtPs5EDCBkpNXhi/iVPvL9suTrGJvea3+Xd8qgS/ex01aVszuKXhR7trMj5+Os1+RMy4ftGSeaxEKpzUgP/CbMbvViTyT1DZ9FKzZX+goRgYrD61ifb3+ktGrzh6GJQ92fbwiUbERhSoq1xyMtVOJKNjgH8wmd29QHZjBC+hZfgtpuJIiuWvgzDv4IBH+5HrKoZk0lCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W2/1Zk08baYKUnZ4Ze3qeMxNV80jfkU8x0Nla7XtZW0=; b=K2HZe+YQp/IRaPIA0WlJFMQr6yg/zzK62g5ai9KPGww65HAG/ByLoNUUOvclPtZL/j/uDEkYjoAwjoZBUEV+hqVafx277Vvp62wvM6tmUqGXaz/OUrJqH6eF+pUE1Wlv3x/F/0Z/ScrfrbucrCs3+i9FuZhjMCH8uLgDENeyMGdu0BCYIYbboW2L/qz97h26HTexS5jFGqtenmydElz5ldqNIKZTO3tRifVKjzaANkF2TUa6hI1kzTYYiWPDQhYPl0Jweo1SpoRatT4NLrOi79qP5mobFe9Qn9SOOkUGg8+EV7svqQ8EIqY5IVsrk3Qble9lJviNzXZzUzTBpeuOag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W2/1Zk08baYKUnZ4Ze3qeMxNV80jfkU8x0Nla7XtZW0=; b=x/OdtfAtPbItRjkzdM4yEOUwhT9T5I7i0OS+Ca4B8KByD7WpatuLsFMlSliVxuP5lg2VjnEWcEMFjfcWOIVxKkRCtkCs3YeHB3Q+qL6IUj3tlbZQRGjU9WO+hJCL2b7wpHoRyX0k+ChrybOyzJscCFVMGOX8YAtbw2fbqL4Ggp8= From: Wei Chen To: Wei Chen , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 Thread-Topic: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 Thread-Index: AQHY8DVcKFNDls96akm0LlhB1cf9B64uj+2A Date: Fri, 4 Nov 2022 10:29:50 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> In-Reply-To: <20221104100741.2176307-1-wei.chen@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 633F9195BBCC7B4185DD3F8634782536.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|VE1PR08MB5822:EE_|AM7EUR03FT005:EE_|VE1PR08MB5662:EE_ X-MS-Office365-Filtering-Correlation-Id: 58fa15cf-8410-4024-df5d-08dabe4f8914 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Mh4adz+jMOs4clkmtybn1Oz4uAL+WL7RFhMMqtmW3YE/KY18UE0qy87MeCO/+wWNoYHB7Ufy9HPTdDoPN9gNRo13Hog4bdsxna6LZoCGvE5Y7hF/CHgH2FaREstuT3CYWIY0QObK8TB/gTWRaaK/m1oJSly/22mmMDdcpk/Pr0BW5vHQKXuh9xqw119Zvel9aH7uhzM+C+Fva1ra9CCePNObMeGSzMEIN1bPnXzvU9oJar6r+B3Pz57AKkqtig8By3MA/rkjnSPFDr8Y95X9Ud8jhb8LldEChCCDD0c5+20cw7F9d7TcNLdqgIvSnwrNOjeSUIfyBjC6sYj2tCpeYVT3zKWlCSpoRuHv1wvhmvrdZJywtnelTG54wJZnZcDBxH15WIsdYI8TeaFGDO2qSuG9lw6/Whh8TItpXcWERFTxNOPJTdA3zva/V0d9oYcIcW9vPkk6CKExzqi7LagEPuW2/mhWmSDB1LSoOkbzXuDJZnkZzkxQx0uG0pBZMYdkdevoVhasOp++t8yGGwvyuXHEjQK2odsah1g1G/JTVKeOuwmly3t5g7Ry2P23vOKP9Hutl5tke5756Q5QjU4notF0gFZiQWcls/JbXBQJnfn6QY7aX+t2PzcKHdbDtAGgzUZP05moNCVHw3CCvsxcdnA0MpAF+HPipfZvrKD1slU6x21RGpQTHgOfWw11PsJZ6hQ116FNC+ifpmd6j4lIKvxTlssZdVVz6ocBsJKiZpQTE1Zc361Ixltb/bg2Sr7L9xU1fR1j87+sUTf4HfeOealP8kdq8XKgri/p0lN0gHUysFb8FOg20IVejO2ba9Lt5p3UC4lSrxPm88XiiID4h42TIgUGc6JQPyDnVHnyQUk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(376002)(346002)(396003)(136003)(451199015)(71200400001)(33656002)(54906003)(38070700005)(8936002)(5660300002)(66556008)(66446008)(66476007)(66946007)(64756008)(52536014)(41300700001)(86362001)(2906002)(110136005)(316002)(4326008)(8676002)(76116006)(9686003)(55016003)(122000001)(966005)(38100700002)(53546011)(6506007)(478600001)(7696005)(83380400001)(186003)(26005)(17413003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5822 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7c69ff0f-f2e7-40e5-40dd-08dabe4f8111 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: avpfb3NaytRnKLXARZBP48q5VPzySaQjE0VBedIo2T0LSPLEfbKbcsTMDWDnFjZoro4civN245CoiF5fm+ILHIvN+ZkefwhkQEjNhg3NAu+Xs9t15T7tnwduPkkJ9Ol4OfASkgd7uXgdfoJETvWrdZDFlALTqc/nnQ/gZdedRLYEMmmyx7xY51nhbnCMhpBvYc66NRCNUhTlDe+vXGRRBJBbG/emkGFezpVBKnpZsqQ3kiJ4bNlW5AMSvdwe7FcNbv/no3UnSsFjw/Qd0lfsoN6tgAF/+UdsnES8H0koPE9jpEmHECaSN6lCSGTsltI09sgeMFzHbIGB3gpqzvVXo+FnsJZ08+ImyWKcGu1QxZccX+lCsju5xbWrk45LnO8HC34tU+Eg4Nh033J8kEf+LRq/XtuJcFjGQc5sRR5UYG4UB1FK+1dCPLN9qnZFzAD/3lLedJjowc2HEuAxbmyFXi9rvnZnH6hAzRNPhUKo/B2jF4H2BmWlNFBF//G8fagiK4FD0O9mAhcbslXu3yoeLmtnUP0LgpiEIJ2zBXm3D2bGPwnIDRB6kq1KkkHzFi4anPlCdFME8fGbM0CmgqJ2wz6XrTCMLJsX3SeUSHsN4T05rhA0zchBRsDZmTyyVD3AHg4u37wXw6ZriEaQep1CN05sSYER6luzmHnLIjs7GtbaplbRWHLHbvJemdl2ffL1b4j06n634ZkYyn3v2CMsPk8TKk51HXwM4oqw+H4jaMZydbhudv0XKlGohdTLLaVnxcdnz8xbKJHos/7SjzuONIlQFuiwgMQEOA60vHY/ubgj9asJqbNAYa/MhIFsmAnhWyh/vxlOYY8w+H86IYJrs8PEupZ7/StnIaraXb369As0zjz2gCGfW/Gh3Y13V98O X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199015)(36840700001)(40470700004)(46966006)(83380400001)(2906002)(47076005)(40460700003)(33656002)(9686003)(26005)(70586007)(70206006)(8676002)(4326008)(41300700001)(40480700001)(356005)(55016003)(82310400005)(81166007)(86362001)(316002)(110136005)(54906003)(82740400003)(107886003)(36860700001)(478600001)(8936002)(5660300002)(52536014)(186003)(336012)(53546011)(7696005)(6506007)(966005)(17413003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:30:03.7105 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58fa15cf-8410-4024-df5d-08dabe4f8914 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5662 U29ycnkgZm9yIHRoZSB3cm9uZyBwYXRjaCB2ZXJzaW9uLiBUaGlzIGlzIHRoZSBmaXJzdCB2ZXJz aW9uIG9mIHRoaXMgc2VyaWVzLg0KDQpDaGVlcnMsDQpXZWkgQ2hlbg0KDQo+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFdlaSBDaGVuIDx3ZWkuY2hlbkBhcm0uY29tPg0KPiBT ZW50OiAyMDIyxOoxMdTCNMjVIDE4OjA4DQo+IFRvOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmcNCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsgV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+ OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBKdWxpZW4g R3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsgQmVydHJhbmQgTWFycXVpcw0KPiA8QmVydHJhbmQuTWFy cXVpc0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsgPFZvbG9keW15cl9CYWJjaHVrQGVwYW0u Y29tPg0KPiBTdWJqZWN0OiBbUEFUQ0ggdjYgMDAvMTFdIHhlbi9hcm06IEFkZCBBcm12OC1SNjQg TVBVIHN1cHBvcnQgdG8gWGVuIC0NCj4gUGFydCMxDQo+IA0KPiBUaGUgQXJtdi1SIGFyY2hpdGVj dHVyZSBwcm9maWxlIHdhcyBkZXNpZ25lZCB0byBzdXBwb3J0IHVzZSBjYXNlcw0KPiB0aGF0IGhh dmUgYSBoaWdoIHNlbnNpdGl2aXR5IHRvIGRldGVybWluaXN0aWMgZXhlY3V0aW9uLiAoZS5nLg0K PiBGdWVsIEluamVjdGlvbiwgQnJha2UgY29udHJvbCwgRHJpdmUgdHJhaW5zLCBNb3RvciBjb250 cm9sIGV0YykNCj4gDQo+IEFybSBhbm5vdW5jZWQgQXJtdjgtUiBpbiAyMDEzLCBpdCBpcyB0aGUg bGF0ZXN0IGdlbmVyYXRpb24gQXJtDQo+IGFyY2hpdGVjdHVyZSB0YXJnZXRlZCBhdCB0aGUgUmVh bC10aW1lIHByb2ZpbGUuIEl0IGludHJvZHVjZXMNCj4gdmlydHVhbGl6YXRpb24gYXQgdGhlIGhp Z2hlc3Qgc2VjdXJpdHkgbGV2ZWwgd2hpbGUgcmV0YWluaW5nIHRoZQ0KPiBQcm90ZWN0ZWQgTWVt b3J5IFN5c3RlbSBBcmNoaXRlY3R1cmUgKFBNU0EpIGJhc2VkIG9uIGEgTWVtb3J5DQo+IFByb3Rl Y3Rpb24gVW5pdCAoTVBVKS4gSW4gMjAyMCwgQXJtIGFubm91bmNlZCBDb3J0ZXgtUjgyLA0KPiB3 aGljaCBpcyB0aGUgZmlyc3QgQXJtIDY0LWJpdCBDb3J0ZXgtUiBwcm9jZXNzb3IgYmFzZWQgb24g QXJtdjgtUjY0Lg0KPiBUaGUgbGF0ZXN0IEFybXY4LVI2NCBkb2N1bWVudCBjYW4gYmUgZm91bmQg WzFdLiBBbmQgdGhlIGZlYXR1cmVzIG9mDQo+IEFybXY4LVI2NCBhcmNoaXRlY3R1cmU6DQo+ICAg LSBBbiBleGNlcHRpb24gbW9kZWwgdGhhdCBpcyBjb21wYXRpYmxlIHdpdGggdGhlIEFybXY4LUEg bW9kZWwNCj4gICAtIFZpcnR1YWxpemF0aW9uIHdpdGggc3VwcG9ydCBmb3IgZ3Vlc3Qgb3BlcmF0 aW5nIHN5c3RlbXMNCj4gICAtIFBNU0EgdmlydHVhbGl6YXRpb24gdXNpbmcgTVBVcyBJbiBFTDIu DQo+ICAgLSBBZGRzIHN1cHBvcnQgZm9yIHRoZSA2NC1iaXQgQTY0IGluc3RydWN0aW9uIHNldC4N Cj4gICAtIFN1cHBvcnRzIHVwIHRvIDQ4LWJpdCBwaHlzaWNhbCBhZGRyZXNzaW5nLg0KPiAgIC0g U3VwcG9ydHMgdGhyZWUgRXhjZXB0aW9uIExldmVscyAoRUxzKQ0KPiAgICAgICAgIC0gU2VjdXJl IEVMMiAtIFRoZSBIaWdoZXN0IFByaXZpbGVnZQ0KPiAgICAgICAgIC0gU2VjdXJlIEVMMSAtIFJp Y2hPUyAoTU1VKSBvciBSVE9TIChNUFUpDQo+ICAgICAgICAgLSBTZWN1cmUgRUwwIC0gQXBwbGlj YXRpb24gV29ya2xvYWRzDQo+ICAtIFN1cHBvcnRzIG9ubHkgYSBzaW5nbGUgU2VjdXJpdHkgc3Rh dGUgLSBTZWN1cmUuDQo+ICAtIE1QVSBpbiBFTDEgJiBFTDIgaXMgY29uZmlndXJhYmxlLCBNTVUg aW4gRUwxIGlzIGNvbmZpZ3VyYWJsZS4NCj4gDQo+IFRoZXNlIHBhdGNoIHNlcmllcyBhcmUgaW1w bGVtZW50aW5nIHRoZSBBcm12OC1SNjQgTVBVIHN1cHBvcnQNCj4gZm9yIFhlbiwgd2hpY2ggYXJl IGJhc2VkIG9uIHRoZSBkaXNjdXNzaW9uIG9mDQo+ICJQcm9wb3NhbCBmb3IgUG9ydGluZyBYZW4g dG8gQXJtdjgtUjY0IC0gRHJhZnRDIiBbMV0uDQo+IA0KPiBXZSB3aWxsIGltcGxlbWVudCB0aGUg QXJtdjgtUjY0IGFuZCBNUFUgc3VwcG9ydCBpbiB0aHJlZSBzdGFnZXM6DQo+IDEuIEJvb3QgWGVu IGl0c2VsZiB0byBpZGxlIHRocmVhZCwgZG8gbm90IGNyZWF0ZSBhbnkgZ3Vlc3RzIG9uIGl0Lg0K PiAyLiBTdXBwb3J0IHRvIGJvb3QgTVBVIGFuZCBNTVUgZG9tYWlucyBvbiBBcm12OC1SNjQgWGVu Lg0KPiAzLiBTTVAgYW5kIG90aGVyIGFkdmFuY2VkIGZlYXR1cmVzIG9mIFhlbiBzdXBwb3J0IG9u IEFybXY4LVI2NC4NCj4gDQo+IFdlIHdpbGwgc3BsaXQgdGhlc2UgcGF0Y2hlcyB0byBzZXZlcmFs IHBhcnRzLCB0aGlzIHNlcmllcyBpcyB0aGUNCj4gcGFydCMxLCB0aGUgZnVsbCBQb0MgY2FuIGJl IGZvdW5kIGluIFszXS4gTW9yZSBzb2Z0d2FyZSBmb3INCj4gQXJtdjgtUjY0IGNhbiBiZSBmb3Vu ZCBpbiBbNF07DQo+IA0KPiBbMV0gaHR0cHM6Ly9kZXZlbG9wZXIuYXJtLmNvbS9kb2N1bWVudGF0 aW9uL2RkaTA2MDAvbGF0ZXN0DQo+IFsyXSBodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL2Fy Y2hpdmVzL2h0bWwveGVuLWRldmVsLzIwMjItDQo+IDA1L21zZzAwNjQzLmh0bWwNCj4gWzNdIGh0 dHBzOi8vZ2l0bGFiLmNvbS94ZW4tcHJvamVjdC9wZW9wbGUvYm1hcnF1aXMveGVuLWFybS1wb2Mv LQ0KPiAvdHJlZS9wb2MvcjgyLW1wdS12Mg0KPiBbNF0gaHR0cHM6Ly9hcm12OHI2NC1yZWZzdGFj ay5kb2NzLmFybS5jb20vZW4vdjQuMC8NCj4gDQo+IFBlbm55IFpoZW5nICgzKToNCj4gICB4ZW4v YXJtNjQ6IGNyZWF0ZSBib290LXRpbWUgTVBVIHByb3RlY3Rpb24gcmVnaW9ucw0KPiAgIHhlbi9h cm02NDogaW50cm9kdWNlIGhlbHBlcnMgZm9yIE1QVSBlbmFibGUvZGlzYWJsZQ0KPiAgIHhlbi9h cm02NDogYWRkIHNldHVwX2ZpeG1hcCBhbmQgcmVtb3ZlX2lkZW50aXR5X21hcHBpbmcgZm9yIE1Q VQ0KPiANCj4gV2VpIENoZW4gKDgpOg0KPiAgIHhlbi9hcm06IHJlbW92ZSB4ZW5fcGh5c19zdGFy dCBhbmQgeGVuaGVhcF9waHlzX2VuZCBmcm9tIGNvbmZpZy5oDQo+ICAgeGVuL2FybTogYWRkIGlv dW5tYXAgYWZ0ZXIgaW5pdHJkIGhhcyBiZWVuIGxvYWRlZCBpbiBkb21haW5fYnVpbGQNCj4gICB4 ZW4vYXJtOiBkaXNhYmxlIEVGSSBib290IHNlcnZpY2VzIGZvciBNUFUgc3lzdGVtcw0KPiAgIHhl bi9hcm06IGFkanVzdCBYZW4gVExCIGhlbHBlcnMgZm9yIEFybXY4LVI2NCBQTVNBDQo+ICAgeGVu L2FybTogZGVmaW5lIFhlbiBzdGFydCBhZGRyZXNzIGZvciBGVlAgQmFzZVIgcGxhdGZvcm0NCj4g ICB4ZW4vYXJtOiBzcGxpdCBNTVUgYW5kIE1QVSBjb25maWcgZmlsZXMgZnJvbSBjb25maWcuaA0K PiAgIHhlbi9hcm06IGltcGxlbWVudCBGSVhNQVBfQUREUiBmb3IgTVBVIHN5c3RlbXMNCj4gICB4 ZW4vYXJtNjQ6IG1vdmUgTU1VIHJlbGF0ZWQgY29kZSBmcm9tIGhlYWQuUyB0byBoZWFkX21tdS5T DQo+IA0KPiAgeGVuL2FyY2gvYXJtL0tjb25maWcgICAgICAgICAgICAgICAgICAgICAgICAgIHwg IDE1ICstDQo+ICB4ZW4vYXJjaC9hcm0vYXJtNjQvTWFrZWZpbGUgICAgICAgICAgICAgICAgICAg fCAgIDUgKw0KPiAgeGVuL2FyY2gvYXJtL2FybTY0L2hlYWQuUyAgICAgICAgICAgICAgICAgICAg IHwgNDI5ICsrLS0tLS0tLS0tLS0tLS0tLQ0KPiAgeGVuL2FyY2gvYXJtL2FybTY0L2hlYWRfbW11 LlMgICAgICAgICAgICAgICAgIHwgMzY0ICsrKysrKysrKysrKysrKw0KPiAgeGVuL2FyY2gvYXJt L2FybTY0L2hlYWRfbXB1LlMgICAgICAgICAgICAgICAgIHwgMTU0ICsrKysrKysNCj4gIHhlbi9h cmNoL2FybS9kb21haW5fYnVpbGQuYyAgICAgICAgICAgICAgICAgICB8ICAgMiArDQo+ICB4ZW4v YXJjaC9hcm0vaW5jbHVkZS9hc20vYXJtNjQvZmx1c2h0bGIuaCAgICAgfCAgMjUgKw0KPiAgeGVu L2FyY2gvYXJtL2luY2x1ZGUvYXNtL2FybTY0L21hY3Jvcy5oICAgICAgIHwgIDUyICsrLQ0KPiAg eGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2FybTY0L21wdS5oICAgICAgICAgIHwgIDEzICsNCj4g IHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9hcm02NC9zeXNyZWdzLmggICAgICB8ICA4OSArKysr DQo+ICB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vY29uZmlnLmggICAgICAgICAgICAgfCAgOTkg Ky0tLQ0KPiAgeGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2NvbmZpZ19tbXUuaCAgICAgICAgIHwg MTE5ICsrKysrDQo+ICB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vY29uZmlnX21wdS5oICAgICAg ICAgfCAgMjkgKysNCj4gIHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9maXhtYXAuaCAgICAgICAg ICAgICB8ICAyNSArDQo+ICB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vZmx1c2h0bGIuaCAgICAg ICAgICAgfCAgMjIgKw0KPiAgLi4uL2FybS9pbmNsdWRlL2FzbS9wbGF0Zm9ybXMvZnZwX2Jhc2Vy LmggICAgIHwgIDE4ICsNCj4gIHhlbi9hcmNoL2FybS9wbGF0Zm9ybXMvS2NvbmZpZyAgICAgICAg ICAgICAgICB8ICAxNiArLQ0KPiAgMTcgZmlsZXMgY2hhbmdlZCwgOTc2IGluc2VydGlvbnMoKyks IDUwMCBkZWxldGlvbnMoLSkNCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vYXJjaC9hcm0vYXJt NjQvaGVhZF9tbXUuUw0KPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS9hcm02NC9o ZWFkX21wdS5TDQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNt L2FybTY0L21wdS5oDQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJtL2luY2x1ZGUv YXNtL2NvbmZpZ19tbXUuaA0KPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS9pbmNs dWRlL2FzbS9jb25maWdfbXB1LmgNCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vYXJjaC9hcm0v aW5jbHVkZS9hc20vcGxhdGZvcm1zL2Z2cF9iYXNlci5oDQo+IA0KPiAtLQ0KPiAyLjI1LjENCg0K From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:37:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:37:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437508.691940 (Exim 4.92) (envelope-from ) id 1oqu4p-0006DH-4d; Fri, 04 Nov 2022 10:37:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437508.691940; Fri, 04 Nov 2022 10:37:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqu4p-0006DA-1k; Fri, 04 Nov 2022 10:37:31 +0000 Received: by outflank-mailman (input) for mailman id 437508; Fri, 04 Nov 2022 10:37:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqu4n-0005xA-KS for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:37:29 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ac2d841a-5c2c-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 11:37:27 +0100 (CET) Received: from mail-dm6nam11lp2173.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Nov 2022 06:37:24 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by CO3PR03MB6789.namprd03.prod.outlook.com (2603:10b6:303:177::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 10:37:22 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 10:37:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac2d841a-5c2c-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667558247; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=6uM5MuBgcSX74kKGlxvVMqzionu1zYXoDgAaMi5MX2w=; b=GAGSl/UbckOnIDV+w8QDS33nHbsEE9miTWstpffpMrUHeNYY3RgnBmyc FxcRHkZQMMycyg1bxN6r2CIPimDCeT4/8qOBIEIvLtRarYj2kvt8w/Gkw QUje185uE5Wd9N1XvFD9v218e8CGETrAyYlK+PUyTL2rMaLUq5Iml5cFl E=; X-IronPort-RemoteIP: 104.47.57.173 X-IronPort-MID: 84185760 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:d/PTvqkzpjAVDI3OU6wMn93o5gxaJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJOXW3QPfaLNjCnedB+PY/loEwAuJ/cnd82TQM4rCAwEiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5AOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 adFBz0uZBOfveS/+5y1dbZ0uPxyc9a+aevzulk4pd3YJdAPZMmaBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVM3iee2WDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnzX+iCN9NSuXQGvhCiRqLm3ZDB0wsdWDi8Nyzply9SdZfA hlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml6qfS+RffOWECQRZIctlgv8gzLRQoy 1uIktXBFTFp9rqPRhq17ayIpDm/PSwUK24qZiIeSwYBpd75r+kbkRbnXttlVqmvgbXdCTz2h jyHsiU6r7ESltIQkbW2+0jdhDChrYSPSRQ6jjg7RUqg5wJ9IYKgOYqh7AGC6e4addnCCF6co HIDhs6SqvgUCo2AnzCMR+NLG6y14/GCM3vXhlsH84QdyglBMkWLJeh4iAyS7m8wWirYUVcFu HPuhD4= IronPort-HdrOrdr: A9a23:nuV3e6Pd89oJ4MBcT1r155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa DskPZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolis2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4REoGqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUMTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+6Z/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUR4S0LpXXt WGMfuspcq/KTihHjDkVyhUsZaRt00Ib1i7qhNogL3X79BU9EoJvXfwivZv3Evoz6hNO6Ws19 60TJiAq4s+P/P+TZgNcNvpEvHHfVDlcFbrDF+4B2jBOeUuB0/twqSHk4ndotvaM6A18A== X-IronPort-AV: E=Sophos;i="5.96,137,1665460800"; d="scan'208";a="84185760" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lSw3YaqHp2ySgxfjGXeOCkknR0efhCLPF0dtMe51sNq52LU/2co5WCodCcq3sGteDTsF/Ur/QY8VclXEX2iQG6ffbVy31TGsWGsmoCOEbzF6WjnXdbuHyf8qhsennHUxzJMCDosi347t3lvNfJMs1vf1CuyGhBav33NpJrFAByowjSOXCbApG1SOLUUVHIJyX4EqA4BPJKhjvj12klXkIBlNAI8P4PJp2SEDN1ryMNVwHugy+iISZlMf/Iz6xv1LomO3QGwkz7Rx2Xntq6Qglbz/rABiOO/AJUDQYC38T+UVcLr4/pg/uLhiWr+FxwEsHLHLy12NP2D3bU5K9Uet2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zL6bfq7sT17nr7T0dMsMrmMaNYnURrVH0GqNGeAZC+w=; b=PO+3gdhIFrV1ezTMELzRMCCMK0BUyau1Ew7sQrn/o45JCT1YFLdnlyL3/edlixpL9fx92r8fHucPc3UUsYXzdiv50O0a6r4rB6MPX1s8D5oEZxOYAPa3pExC/Dwz9gAzPMIQPmtv4QLToC0Zw4H18DZgo0Lmp6UWjuCpl1TxNzimc3a3zZqjp8O5OZgFijM9uk5cuISwGZs/K4lu4SCRPVEekk0cgzF+HtPr79xVJUSb2E22FMoY2Gcrrelg4fsq3X4wSqBVNfJL80eUmkXoctdGMdqvu5kKjCO56cj8UGx4qR5+gSXFbtCruhqpQf1U7Z37PiEWq51ZU0hrlDBmuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zL6bfq7sT17nr7T0dMsMrmMaNYnURrVH0GqNGeAZC+w=; b=ZT/2oYrpw4sTe5sBGG9wPL7HYgeopxhmMJ09cCcAlG+bilRAFDIzXKHnkKDjOCtnJ7GIiHtcMUxjIKyKR6nVFJZstkwAj7PbS0oF8Yx5b3phbYba0k2Ctk9TqDxf5ucXp3/+NgAwpMTPonD1me2lKlVlubV7V06Pxi/rTCa/Mh8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 4 Nov 2022 11:37:16 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.17 v3 1/2] amd/virt_ssbd: set SSBD at vCPU context switch Message-ID: References: <20221103170244.29270-1-roger.pau@citrix.com> <20221103170244.29270-2-roger.pau@citrix.com> <952950b5-33c9-6872-0cc4-6ebdf1e015ca@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <952950b5-33c9-6872-0cc4-6ebdf1e015ca@suse.com> X-ClientProxiedBy: LO4P123CA0004.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::9) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|CO3PR03MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 41fa48b8-d0ed-4245-13f6-08dabe508e6b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H/coEr7Rmha+ftjpYxx6cwmHjkHVi4wG7Sp/S13csuU85aMB9rvq8W1klw3NeXq+lkUhe8qLhyH4eHpsrTDseCwZAY0fn4eSv0NkJG3881eODYRzzjq8jUU7nvO/Imqwy1Hw/4baUTu1dJ/1aN9H/lhiui4cGdMd0KgOIq06+OZMoiHd1bHepjBKOuf9jMFOuRoM+lE3mKuPJJQ9lhDLOOgCotlU1Qeg6FAx7fbjnsPrcqemSvK7nHAtJk3py3xDt7W6paMNjDs94+6tq6CeTNX52Nw7nHrqBnTVCMua436Eu9lhnC/dqjd2zjm6AjAs1KGjPsztITvXNAZDj8DeZa5O+FiSWg+DDLsxaMExsh1EeSSCDaNc1Z2I9wWluV12zEhi5Lj82MXInX/ts/j0aEejMEcjWxaaF2KhOu6t8DTyRur0tjpKh8VBmCiL3KPd25n/gVE4Y25KCzc9v4eKFoOd+k5sGdVR3SmSaM6BiswC3aYkwXEjw62h84Fh2p//YVGA/12hXwU51yR8wgIHSpCjfwUpPWoVBk7ZAb1GKmEna87lR0FsfXZKwDVYZS8JTUb3xkgoncMIrkiKLXfN8VAXvcjx7EJdzrXSAsXlLAJAo0RpC0bxodxGRJVgWcdN5mMg4T2ejpJMvH6x2c7tBOEzg+ntBBxACc1y/XrAEjT5z+f8Kqo/F2ChcxIVvfn2g6+y5aP5MLF9BOiIE4vp4Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(396003)(366004)(346002)(136003)(39860400002)(376002)(451199015)(6486002)(478600001)(33716001)(38100700002)(54906003)(82960400001)(6666004)(6916009)(86362001)(9686003)(83380400001)(8936002)(316002)(6506007)(6512007)(26005)(41300700001)(8676002)(4326008)(186003)(5660300002)(85182001)(66946007)(66476007)(53546011)(66556008)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WCtGMlh5dFNBWFdvWUhqM0hlMml4dDlQZ3dCY3B5aDJIU0t3VFV2TzZpNnZL?= =?utf-8?B?TUxUU244MmZFcGxGVVJXY01lMEtXdUZ1WFZuejlpMlU5R3VWZ3hvL0N0Wkto?= =?utf-8?B?MlRRREFxSm1Wb1Q2TWpMdVBScjRhOTN5c2FJb0xiZGU0Ui8vMk56WWpuYlRi?= =?utf-8?B?WHk5K0NxcUtwLzJoRE5vUzA1KzBGcnlrTXVqZnUvaUtRYnJnYmVlY0JmRk5z?= =?utf-8?B?MGN6Qkh6ZWRQZXI1bWpQelJmSG9HcnAySis4MUI3ejAxM280Y1dnY0xkajZU?= =?utf-8?B?c3pKem1ibmZ0MU4wTkFjVHFRa0hQdDRVT3RTaGNhMEEyYzhaNmJ5K2E1Wmps?= =?utf-8?B?bUU2YUJnUDFNdVlENVF5Vnpiak1qNHZXQ01LUE5SeUlJWk42TEwwN2RyOWVT?= =?utf-8?B?MXJpbWJpK0tlOEc5eUNyazA0cDhCbUpza3U3bkxEK3hPSmhNWWxSNHBEdk95?= =?utf-8?B?ZDVDU0RQanVnV08wNGhQVUN6QUJSS0pLY0ZCMStnZTVocGxvVGJmS1FwLzNl?= =?utf-8?B?RkdUdnB5L29zWVFPNUVlamxSLzR1NXJ4SU1DZjVONlQrQkRLSFQ5ejVVUlJh?= =?utf-8?B?dXpXNEtRNVlraDRaNUgrWTREcllQU0VTamZIMm9OUUwzb25QeVI3MEdvMlVy?= =?utf-8?B?QTBXYmRNTDRMSVo2ZFBoOStjaXRpRC9kVEhJVm84eUo2VlV4UFBjRldHNVlE?= =?utf-8?B?YXFXVzRoRGh2VlIxaHY4bXkvWjRSQzBDV3hGZC9oV1krZDNaVGJFL3NuUDhh?= =?utf-8?B?eGEvOFVuR2U3RE4xRUVqOW82TVhOdE5teEdPRm9FYUpZNmpZNDF2WHRpOHla?= =?utf-8?B?WW5HNlhXTEt0eXNOQXFEbURQVEl6WUdtb0d5aUdJQnJuM01TazcrdVNmZE0w?= =?utf-8?B?SkZReWptV1hMSmhRU0JGS0ovZmRCSENJaFRtNFFJV1kvYWlEdStmYktmV29B?= =?utf-8?B?M2MxdVl6ZElDQ2JFekt5b3ZIUXlXaEpVZnJ6bTIwVko3QTEvY2dwQ0NTTERJ?= =?utf-8?B?b0ZsZWc5SmxjcnZsNWNhdUZFNENyYUZkUzZLaXIvUDE0dWJvdGF1d2czZXdm?= =?utf-8?B?UFYyaXZZSGh1UkducnBsQ2FJNVJYWVhuY2lTYnduakswSjA0NXBFVXArNnNO?= =?utf-8?B?QStMUHQrRHlpRnVPTHFaVHFGdGZOdlJvbVV2ZUpJUERncE1waHAvaUlMNTU3?= =?utf-8?B?Mmp3YXJhNGFYWU51aUcxeEpXNktJMDZRNzltUitlM2pMdnRrTkQzdG5tVTFO?= =?utf-8?B?MGFOZDY2MFF3SmllZTJZbnpyREdhTEdYZTVEUkFrbEZ1OC80RW5FUzFldjVP?= =?utf-8?B?VC9jc2ZFcVdBRTF5QllJK3FQei95TEMrMlZLVWtUdlVPeGIyY1Y4cUxzUlhQ?= =?utf-8?B?MStXdFVIV1NONU5Bd2VPVHVRNGNIWXIxaUV1U3FYYTJ1NitWc1RFNFZCeFRQ?= =?utf-8?B?VWtWTDRGazJUTDJTdEQzbm9UR0NJamtKUDFMaUlQY215ZXlxUTNhbkxOd1Ns?= =?utf-8?B?c0NVYmg4NVlER3hhaXF2SWVIT1JMaWJOSFc5eDVKLzROa0FrRDRRU0F2Z3N5?= =?utf-8?B?bExkZDlRRUtFYTdJMUxqaVJXbTNINnJ3Tk5TaGpCZnUwUkIxcmFGanJzSlZZ?= =?utf-8?B?Y0VzYkFoTHhqcVFGMFNhVkJrVm1VbHJEalZaZ2REcVNGb3VqN2M5b200VVd0?= =?utf-8?B?VlBFZDY2eVkyMkRRemc1UHE4YkZWM2Fldmg5YlVJaFhqUEluQStDZGxxMU9v?= =?utf-8?B?MkZ3K09SWVR3ckRoekhwQllYQXE5eTVqY0lwcGdNdTVrZTYxbW5BSGdXcjVr?= =?utf-8?B?VGdmRmdlckZkSXFGUHRDcXVVaGkzOE1Mc1c1VWVabWVrcWliTjdMeGhkUzZm?= =?utf-8?B?aTRMSHRaeXRwRU45ZE5TRzBKQkUrL1kxSEpJZjFQWmU1R25XczJnZ0lYUGNI?= =?utf-8?B?SHpFMmVNcW51S3lUSWY5SkZPam9HM1FBZ21mMkZzVHFWOW1Na01ZWXJVbUJi?= =?utf-8?B?Zm9aNmlmUHVZdUNPSGRsTkZ3MVdwcDFyRnhBN3FkVS9pbHpDRmlKZWZQRXM0?= =?utf-8?B?eGp1MWd0R1JtUFJ3Wmp3QjFBenFBenBLbFZJdnEwWWJIR1RDWnNGeG02OG9G?= =?utf-8?Q?+llGhxZ4vNG1/hx+xgkgOM52z?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41fa48b8-d0ed-4245-13f6-08dabe508e6b X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 10:37:22.4889 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MS8Vg9MRlqtiByTKuU27OWCT0ZzFougXWNVtwE9xSTDN3KvtNdSpl7YGRQY0ONVMwTfoDiY0JOXvVwMfZ1l6Jg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6789 On Fri, Nov 04, 2022 at 09:10:21AM +0100, Jan Beulich wrote: > On 03.11.2022 18:02, Roger Pau Monne wrote: > > The current logic for AMD SSBD context switches it on every > > vm{entry,exit} if the Xen and guest selections don't match. This is > > expensive when not using SPEC_CTRL, and hence should be avoided as > > much as possible. > > > > When SSBD is not being set from SPEC_CTRL on AMD don't context switch > > at vm{entry,exit} and instead only context switch SSBD when switching > > vCPUs. This has the side effect of running Xen code with the guest > > selection of SSBD, the documentation is updated to note this behavior. > > Also note that then when `ssbd` is selected on the command line guest > > SSBD selection will not have an effect, and the hypervisor will run > > with SSBD unconditionally enabled when not using SPEC_CTRL itself. > > > > This fixes an issue with running C code in a GIF=0 region, that's > > problematic when using UBSAN or other instrumentation techniques. > > > > As a result of no longer running the code to set SSBD in a GIF=0 > > region the locking of amd_set_legacy_ssbd() can be done using normal > > spinlocks, and some more checks can be added to assure it works as > > intended. > > > > Finally it's also worth noticing that since the guest SSBD selection > > is no longer set on vmentry the VIRT_SPEC_MSR handling needs to > > propagate the value to the hardware as part of handling the wrmsr. > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Jan Beulich > with one further remark: > > > --- a/xen/arch/x86/hvm/svm/svm.c > > +++ b/xen/arch/x86/hvm/svm/svm.c > > @@ -973,6 +973,16 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v) > > > > /* Resume use of ISTs now that the host TR is reinstated. */ > > enable_each_ist(idt_tables[cpu]); > > + > > + /* > > + * Clear previous guest selection of SSBD if set. Note that SPEC_CTRL.SSBD > > + * is already cleared by svm_vmexit_spec_ctrl. > > + */ > > + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) > > + { > > + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); > > + amd_set_ssbd(false); > > + } > > } > > Is "cleared" in the comment correct when "spec-ctrl=ssbd"? I think "suitably > set" or "cleared/set" or some such would be wanted. This could certainly be > adjusted while committing (if you agree), but I will want to give Andrew some > time anyway before putting it in, to avoid there again being objections after > a change in this area has gone in. Hm, indeed, maybe "already handled" to avoid getting into the set/clear nomenclature. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:37:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:37:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437507.691928 (Exim 4.92) (envelope-from ) id 1oqu4l-0005xN-Tk; Fri, 04 Nov 2022 10:37:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437507.691928; Fri, 04 Nov 2022 10:37:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqu4l-0005xG-Qy; Fri, 04 Nov 2022 10:37:27 +0000 Received: by outflank-mailman (input) for mailman id 437507; Fri, 04 Nov 2022 10:37:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqu4k-0005xA-Qh for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:37:26 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab63bad3-5c2c-11ed-8fd0-01056ac49cbb; Fri, 04 Nov 2022 11:37:25 +0100 (CET) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-480-Y4JjoI7gMcqJYl9s5CBPfA-1; Fri, 04 Nov 2022 06:37:20 -0400 Received: by mail-wm1-f70.google.com with SMTP id x10-20020a05600c420a00b003cf4dbff2e4so4039438wmh.8 for ; Fri, 04 Nov 2022 03:37:20 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id f15-20020a5d50cf000000b0022e36c1113fsm3031008wrt.13.2022.11.04.03.37.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 03:37:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab63bad3-5c2c-11ed-8fd0-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667558244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FvcSXdbTIY6j0RtoeMW2Oyvbsf0knEKyh2vmjeJsi+Y=; b=ZiLDy8beWgmn3nTWY1Xx6WMNsig0TDt4n1oB2QrVk7rVKaMxzClhm15yK1iylOkqAksF2u k+BheTfuZ3rV7yvrPM6E7Mwz7o0sWHSJiLjzSPDkL8SUS6RcpqxgpVcHwfOnzO9x4VFhOh PICOQGA0FTsxBuipgu/2g7qyEZS7Wu8= X-MC-Unique: Y4JjoI7gMcqJYl9s5CBPfA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FvcSXdbTIY6j0RtoeMW2Oyvbsf0knEKyh2vmjeJsi+Y=; b=vdvg4oMyAga3uEd23839KyumkrU3RMSObs8J9nG9I1K83BmnAtl7FK8ka+zvNKotOu hBwMiV0Uzx+XDpL1k4V590KoSU5c6rwBtXmhYWi2w7mYEDUOsPMit3ICND/DYF0LhabY evwuSYeCv/y8+pHl7qumI0Jwx6S0iYbF0lwkDBLJ2UKvXtWrehaP7D5K0zAxyfx0uKgg 0CC4slTKEKrAd7Uo14/YAOYvkrRwkI6leFs9BrZaR0TD6iq3jaE7P6yXz6/RSlmg2AyE 9/B+AMjkygXDGfDGuc7/XXl6KbN9Et2zqyLaGOk2AUuQv9eDsfBpMTu6WPM2ntF5sZWh GqNQ== X-Gm-Message-State: ACrzQf1Kn4eGTjkBJnCQm381JoUjv9x7AtUr15X1iwvFYwRnhbgUrqlf KCoJpGGSgDfAEiptTlB7lRi6+n//kcDaXoq4Ydc9tTEZHt4XGh0RpKjGXhDAetuT6gJZpgEuJJO KzoB5ghS1CYrhqmM8YdXM++CV2ho= X-Received: by 2002:a05:600c:1e2a:b0:3c3:d770:1756 with SMTP id ay42-20020a05600c1e2a00b003c3d7701756mr23539585wmb.134.1667558239642; Fri, 04 Nov 2022 03:37:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4LKXhwK5qh8ieFEkCSZgi7mblk9sJOfnr0awtpFbS+pIQGNE9IUSRaCOrs9CG3VpGFJY/xjQ== X-Received: by 2002:a05:600c:1e2a:b0:3c3:d770:1756 with SMTP id ay42-20020a05600c1e2a00b003c3d7701756mr23539569wmb.134.1667558239379; Fri, 04 Nov 2022 03:37:19 -0700 (PDT) Message-ID: Date: Fri, 4 Nov 2022 11:37:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 20/23] drm/fb-helper: Set flag in struct drm_fb_helper for leaking physical addresses To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org References: <20221103151446.2638-1-tzimmermann@suse.de> <20221103151446.2638-21-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221103151446.2638-21-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/3/22 16:14, Thomas Zimmermann wrote: > Uncouple the parameter drm_leak_fbdev_smem from the implementation by > setting a flag in struct drm_fb_helper. This will help to move the > generic fbdev emulation into its own source file, while keeping the > parameter in drm_fb_helper.c. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:38:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:38:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437515.691951 (Exim 4.92) (envelope-from ) id 1oqu5a-0006zl-GC; Fri, 04 Nov 2022 10:38:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437515.691951; Fri, 04 Nov 2022 10:38:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqu5a-0006ze-Ck; Fri, 04 Nov 2022 10:38:18 +0000 Received: by outflank-mailman (input) for mailman id 437515; Fri, 04 Nov 2022 10:38:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqu5Z-0006jZ-2U for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 10:38:17 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c982e5ec-5c2c-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 11:38:16 +0100 (CET) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-315-Ie0cZhb6Ooy4gFAy3GdKLQ-1; Fri, 04 Nov 2022 06:38:10 -0400 Received: by mail-wm1-f72.google.com with SMTP id l1-20020a7bc341000000b003bfe1273d6cso1550169wmj.4 for ; Fri, 04 Nov 2022 03:38:10 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id k4-20020a05600c1c8400b003b4cba4ef71sm2534442wms.41.2022.11.04.03.38.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 03:38:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c982e5ec-5c2c-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667558294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M88yz4GfmbUNq4mWECugnsnJkV6z34uCwDqL3DFZ74U=; b=eTGHBg0qiZjnDA9jGtRPkGQWZ/zGHH6xoF57EvSdjwCi7vK/4qyglEn+elwpI4sQ+ELgaq rzP7u4H0yDxEe4uRN3QNkPn6mZWJ2SCldAPvM0M3WPt8HKe5+vQKY4MKFyMpj9HCUUCFt9 0Gl5Y8cqYFqW5AUf2c1K/m0vxfKgim0= X-MC-Unique: Ie0cZhb6Ooy4gFAy3GdKLQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M88yz4GfmbUNq4mWECugnsnJkV6z34uCwDqL3DFZ74U=; b=JXIkl4b+Q0pjd2pha5Ts+7e5VCN2YTauv8Q1d8oH7pcmVTKj3Y9bJ1vSj5YqJGP4OX QklCLRjOjaohqBPpwl28bM+DHQ9UZZygVM3ZE1Wujlc1Wg11+NGbvC1XQ1Jl1P+gYAFU 5LVGWl5xyBmEcJy3Tu6ff51ceNyYOXBg5QZLxICbWbFCydsn/p0vraa2X3yp2y/jaKgj bRyMVsSF90xLjPGtZUjZBSSMP1/y55LY98NI5emvy02YUqxW0wKbrIPdACEzFbeBKauK dPC2LygvS31onV41HmRjGhjicoW7gbvmh+5SvqXoKRyPtyBy86jeg2n+/10e3LdjH8n9 85SA== X-Gm-Message-State: ACrzQf3CT6ATSvm6VEWdN5pqc7LHJIvUyjz6ejxoUKnnJ9BPBNtbbsHL xve/49OyTqvRdn3+2qb0iNwrs6izUpP6Ug1ZoeJVdNBG9ynm006fUhE44V4rDX0t0FOVc22QllZ x23yRHIOexZvJKBRfXvXIA7OZcg0= X-Received: by 2002:adf:bc51:0:b0:236:8fa1:47ea with SMTP id a17-20020adfbc51000000b002368fa147eamr218067wrh.77.1667558289565; Fri, 04 Nov 2022 03:38:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6s9MOXnwXonR8VOapq6d4n3ZU7IGA+EIjACuJbvHHOLIXD7EQUkeJV/V+5P7qnQBQKVLAVkQ== X-Received: by 2002:adf:bc51:0:b0:236:8fa1:47ea with SMTP id a17-20020adfbc51000000b002368fa147eamr218064wrh.77.1667558289372; Fri, 04 Nov 2022 03:38:09 -0700 (PDT) Message-ID: <1f5e6de4-3fe2-7933-f8c0-5f13564595cc@redhat.com> Date: Fri, 4 Nov 2022 11:38:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 23/23] drm/fb-helper: Clarify use of last_close and output_poll_changed To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org References: <20221103151446.2638-1-tzimmermann@suse.de> <20221103151446.2638-24-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221103151446.2638-24-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/3/22 16:14, Thomas Zimmermann wrote: > Clarify documentation in the use of struct drm_driver.last_close and > struct drm_mode_config_funcs.output_poll_changed. Those callbacks should > not be said for fbdev implementations on top of struct drm_client_funcs. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From xen-devel-bounces@lists.xenproject.org Fri Nov 04 10:51:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 10:51:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437522.691962 (Exim 4.92) (envelope-from ) id 1oquIS-0001cs-NV; Fri, 04 Nov 2022 10:51:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437522.691962; Fri, 04 Nov 2022 10:51:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oquIS-0001cl-IQ; Fri, 04 Nov 2022 10:51:36 +0000 Received: by outflank-mailman (input) for mailman id 437522; Fri, 04 Nov 2022 10:51:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oquIR-0001cI-9l; Fri, 04 Nov 2022 10:51:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oquIR-00068O-7y; Fri, 04 Nov 2022 10:51:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oquIQ-0005mR-Sv; Fri, 04 Nov 2022 10:51:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oquIQ-0004iS-QS; Fri, 04 Nov 2022 10:51:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=usZOHmuv4Dvb1WJkAHlLzmyPrlx05f+6RhGQEDmJy44=; b=OZ/KaTbCm4dbOUU/1Mj3TVSVt3 4eVFnVy5pSj/aZPm60p9Vwvkk88OCQL1hJjM0SNonrmfot+p0Q18bQoBopT5uO440PRBQG/I9IY6z m0WGz3kexkLE2OIVDYiENsmA/te2U7OpkkjmDpcorVtpS18jC8mKCCSyxDHCh58RpzM0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174621: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9f3e585ff5ecc606e386057f5cfa66b22fea2b93 X-Osstest-Versions-That: xen=2d9b3699136d20e354a94daefebbeefa9ceec7b6 From: osstest service owner Date: Fri, 04 Nov 2022 10:51:34 +0000 flight 174621 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174621/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9f3e585ff5ecc606e386057f5cfa66b22fea2b93 baseline version: xen 2d9b3699136d20e354a94daefebbeefa9ceec7b6 Last test of basis 174601 2022-11-03 09:00:31 Z 1 days Testing same since 174621 2022-11-04 08:03:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Juergen Gross Marek Marczykowski-Górecki jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2d9b369913..9f3e585ff5 9f3e585ff5ecc606e386057f5cfa66b22fea2b93 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Nov 04 11:09:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 11:09:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437530.691973 (Exim 4.92) (envelope-from ) id 1oquZc-0004Xu-Bi; Fri, 04 Nov 2022 11:09:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437530.691973; Fri, 04 Nov 2022 11:09:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oquZc-0004Xn-7T; Fri, 04 Nov 2022 11:09:20 +0000 Received: by outflank-mailman (input) for mailman id 437530; Fri, 04 Nov 2022 11:09:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oquZb-0004Xh-NL for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 11:09:19 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2052.outbound.protection.outlook.com [40.107.223.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1f22210f-5c31-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 12:09:17 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by DS0PR12MB6485.namprd12.prod.outlook.com (2603:10b6:8:c6::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.18; Fri, 4 Nov 2022 11:09:13 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 11:09:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f22210f-5c31-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/gLQRW4mMqkeKuBiXThpQpYLkdzUp9P2EaW9h2rkGZF/zuE6WwJ2RQxIW96NlXCCWCN5A3tDWzBIqHCbjEjbezBQyGPdLOGE0YEyY7Ju+SqCT+RRSQBdypW+6TCc+VhS9XsmDazCU8jCtLPGQfUXqRdkgvS7uusvn1s7AhB5QftJg43J7WkFxglyCvr5YSMCllZK6hOtA8m54qHi+YaKYTQ6DiuNGvdrftGmNieJwcLgCgwsPgfyrT9JrfTCeg3V9KDhqqduPaDdAq4z7JSWsfGFrKYDzryvvQEYkPlD9zGbVmRrxjlaE0mGKp/C/6/qi1gzjyikU/8pFYnZhm6+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2UnNR+16JQNIpVydsmNY5kPLX/3TQfOIaO4GB6X4sTs=; b=kqw+feSmxjeSGleTMz4HHxYBVV6X5EF/H1DnZniIfTPCXaDmEvmBqzwf5O/UyFYz385XSTc6cMyL7iR+Nm4pjO+YhrXVM5p+dj3UupG3XGWnfDG5vwOqmpho1AoTUtnIwVqOWdwwhA88Dz3xuOgL/Z1m+wfLXcuvhed2Z33w3dpysyOHd3NfJC4WbS+d7E4xcjPBkTspcY7LF2j8R8Uxp5xMHCtWSHU/dw5zfWS/4pG77QOSiJSA7zofseOfmLEqsQPF5yT8jVtfBesPmx9YOwXD+YUIe3uE6a8ofupnshJaNZx9XEFfcCMmi7KYSmZ9/HyCGXihS+PUOR5MbfnY4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2UnNR+16JQNIpVydsmNY5kPLX/3TQfOIaO4GB6X4sTs=; b=l8OIe0ZcKMWpz3gJwrBBlJx54fyo8reTw80Qwrk/sHO8xMhN1u6rjlMyGvwjphVW9hMXPLTArpFUbOHGHMSsOtJjbljh8BTdUWJltT6PZq4O0lwf+vH8yJvUiSLJlFb7A79O84Z5QEMRQyygJif4oUQGnd5K50tsHQejPw3Bto0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <09b11bfe-6b7b-2da7-84ed-ad7c7c89b516@amd.com> Date: Fri, 4 Nov 2022 11:09:07 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 12/12] xen/Arm: GICv3: Enable GICv3 for AArch32 To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-13-ayankuma@amd.com> <45df5e11-9697-96ca-3c89-39bdbba48637@amd.com> From: Ayan Kumar Halder In-Reply-To: <45df5e11-9697-96ca-3c89-39bdbba48637@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0561.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::10) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DS0PR12MB6485:EE_ X-MS-Office365-Filtering-Correlation-Id: da30c83f-e46b-4ea3-2040-08dabe550163 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XbYMYfFnfK0Oxq2P3MqgpqFbP0JeU+3PY5EAblGjynZTXuDH7ZItk+U5TU7+7yu6FXEOpI9p5aDvRAtIM6UzbGuIRnSC4dWDv2RziNIQKtm4cvHdeFps88U2VvCgy4eHwRfSFY10jDRfuetjgWX0IWFqtRUMuHhRcoRkfrEz7zt26Yn/Cw+ozynbFUXmkl5f/loSA/Z84npJb9fMf6LbLWNl+aYjzYKnVCP+c/sRFZbVQ7H5Ol8wlm9dl48Eigm1Dbhdcjp70uzRZkXxYr4Wx/LldaVFnUEn0+h7yA7SW9Qg1eHK1Y69VoOZcblXZP7ZXvymTXFWU3r5ZPr8UGPQttI0JzWSJUX9mizeL6fDaJH7o5BR6fyuE+12UoQrtLpAJ2+SG1BtWJEtzUGN6dQPkwAWkx7gXyGTsMU0gzn6IIYPlcmNQWo+o+qgr+NJZhAqL7vOcecorlVsIu/y40sURLfrVL6q6GLq7B2Ep/rOIaux6Aae2sANqKlFGpwOcrTkuBxBsvY3VKS6N+KuzZ6VJ0D9EwrISraee2IzgDqK7EQg8U8pUBPEnT86VwCsCDq9QWQMNp9vSSIuJ5YZz8mcPex5YyujijaKLDhfE6kdkP5MHfwu9sqX8ewmH58194KyUgjD/l8wOBzlSHKSRibGTtN2WAx4HpWKlNO6wVGjFYIIMCoolRrvuLA9ur7f/uxi5wyeNjNXlAV5EAzABVffEmy8ZzuSVV41nFftrwUArnKpyD+4v6WRC94muqEcsnBf943HcMdv4UXPeqCySEVx1leV/EmkobDbSH0U3ONk8Dc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(346002)(376002)(396003)(136003)(451199015)(4326008)(5660300002)(8676002)(6666004)(31696002)(38100700002)(2906002)(66476007)(478600001)(26005)(66556008)(186003)(66946007)(6486002)(6506007)(316002)(53546011)(2616005)(6512007)(36756003)(41300700001)(31686004)(8936002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUx1ZVpHMnJ3UWtWUURjMEhDa2VSUnppSHJ3dittbG5YbVF2WVgwRlMyeXRi?= =?utf-8?B?Wi9Ud0VpMUtuMDIwdXNuem1tUjNuNE4yWEhTQ1daYTFCWlVndWFyQ1QwbmRu?= =?utf-8?B?SDk5emh2ZFNQMlBObjF2QkJRMmZuQmRyZ2tEcFdlVTFzK2ZMQUNWWFZFTGZY?= =?utf-8?B?Y05Qdnd4WjRzZm5IYlRqazE4aFRsVzkvajU3QnZzYWRiNXl2MnFyaVlhdkZn?= =?utf-8?B?UkZXZjRIRHR1OWZHRi9QU25DOUdWTVNLUWxuUFpQV3Y3c3BxQlFEa0pCb3lR?= =?utf-8?B?eVQ5a1RCRkk1c0VJSzJuREIwMzBHb3JXNXhxNWdCL2ROMm9seUZ5UUJaM05s?= =?utf-8?B?NTRYSjNMb1Z4MWNyT2NqZnQ4RTZPNkJlNE1iakprQVF4aEkyRW92Yi9FSGhF?= =?utf-8?B?UzlCTDNXNkFqZm5QbGJ4TTJTT0NzVk5HcGU4bXZSZXpHRWVZREZ5dHZsK0Qz?= =?utf-8?B?aFJ0eWh6Q29KeFBuamJ2M2tCKzhweHBSM0dHd09RT1AvU004YmkxQXZIODlh?= =?utf-8?B?cnRKL1hZVFF3OEpUV0U3ZXpZV0RVT05IL0pQcFlRSVdqVTJtTVJ1WDlwVkpq?= =?utf-8?B?WTVNT0xwZnFBZjUxRU9sMUNYemJXeDFEZlBRT09HZmY5b0J6UkRGWnh3czBN?= =?utf-8?B?b3J4ZERkSllRQ1dDcFB3U1ZINDI1cVJUQ2NHS0RzNnBPeFFwNkRiNzNLT2JD?= =?utf-8?B?NUY0MzhVOFpGOGtOcUFHR3Z1Qi9jUUtiYlNDUzJ0MVpVV2lCaHgva0dHdGFa?= =?utf-8?B?bTJRbVZKZ283Q3owMC9lQ3pyOGNsdllqUE84L0pMTHNQK2l3SmNBdVdkL1Yw?= =?utf-8?B?RW5GSjBrcTUwU2NKYmlNcUFlWThMQ3pVTVRkWE1idkV1UHBMNFcveTd0UkhW?= =?utf-8?B?T0lYdkw0bnhRZTBndGpkY0xCeDJ5Q242UkxQY3BwWXVjbnoyaVpUZWM3THh0?= =?utf-8?B?bnhobVF3ak43WjRPOGorRU5nM2QraW1RdU1obFc4K0JOVDVyeVJ1R0xmYVNV?= =?utf-8?B?UW5TQmpzWVh1VkdFY0hzUWZjdS9CTW84YmxlOHdVZUpBdkJUM1k0ZEFSRHpk?= =?utf-8?B?dmE0MnFuOURoWEFsN2dqSnZBZ3R0Y05iRXZZUWZEV09KZElMVTlrS0RGY2pH?= =?utf-8?B?djk5ZUR6Vk12RThCQ1FnZ0hLZmhSWW1pcXFXVTRtd3Q0QjMzd2FRV1V3UlVJ?= =?utf-8?B?ZjRIZFVjelpOUmJqMkkwTTRFTGhLdTVPRi9kbWtncjMwREdZb1NTVldjYmRa?= =?utf-8?B?MFFtbVZKL0FYTWlRTGRLSG5ES3dzWmV2b2Y0Vmg4QTVLWnA1M3MwQjFMYzU4?= =?utf-8?B?UlpIT3lZVjJzMkJ0dEVwRU1RdjNGOW9ZSXBqdUhjbjVKQ09JQ0t3OUdFWFE4?= =?utf-8?B?amhGSEFTaTQvWWlpSC9zNW5aZ3ZYV0c3ZWg0THhvbVFTZDA0WGVXSWF3S0M3?= =?utf-8?B?NndBYUlSa0FyYlovNWlwRlBSczdDeGUxSWF0dTlqeW55MGd2MGRDbVN1N2px?= =?utf-8?B?YnZ6LzMxUlZsQUYwU0FrWmNKK3ljZWpEWnFqVlI0MkE1dU5iMFZrZHpjem5x?= =?utf-8?B?alh5bE5kRk5vRm8yM2xjRnc4dUdsL3JIYjhsNElaTmcyWWZwbmx5Z05iUllH?= =?utf-8?B?TVprVk51dldWa3BENTM1L2FhVEcwUVZ2V3AzMVdZQnpqUjVvMjVqeXFZUmwv?= =?utf-8?B?RkdaY0Z2ZlNvM0FxV05FcFRZS21tZWptaTFvWUJXV0k4VjhWekljckZ6OVhv?= =?utf-8?B?UGNMV0lCbUxQai9DcG5CY0ZTMmYvMzgvMTdGKytXamozQ3ZuQ3lGa1NWbGx2?= =?utf-8?B?Mnd0SGFudFhjN3NEc2tBNWJFdk9ycmtNSmtZNFBhSlcwanhPWnB3LzkvT2dL?= =?utf-8?B?MDVrRmVRQTY2RllCS0RTc1dHQzlSb25DWXQ0MmV2dEpLZW5hdis1U1FZTGJK?= =?utf-8?B?NUF1anFKMlhZeFBKckJnSDJ6VURKUENrZWpoWFhnc2R5clNyZU1LRGJDMjc4?= =?utf-8?B?NXE0dXJPRUd6OWJ6a1BQbVN2QXIvNEdCTHdFdGNtdFhBODRLNGtGc2VVKzBG?= =?utf-8?B?YzVCY3RZUzk0SmlyM3FwRUxmdlR5TWF3cWFBcmdudnRLRkRSeTkyd1ZMaWZs?= =?utf-8?Q?ZiR0a/rKeJR6/+rX+IU+ztFmB?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: da30c83f-e46b-4ea3-2040-08dabe550163 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 11:09:13.3304 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qbd99ZjRGkSfsj8s3adKNhjkxc42aoYty+qUBOlKclx1TNyf/YDcrCac9A3TQNjloIdhwP++L8FklxYCymYW2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6485 On 04/11/2022 09:55, Michal Orzel wrote: > Hi Ayan, Hi Michal, > > On 31/10/2022 16:13, Ayan Kumar Halder wrote: >> >> Refer ARM DDI 0487G.b ID072021, >> D13.2.86 - >> ID_PFR1_EL1, AArch32 Processor Feature Register 1 >> >> GIC, bits[31:28] == 0b0001 for GIC3.0 on Aarch32 >> >> One can now enable GICv3 on AArch32 systems. However, ITS is not supported. >> The reason being currently we are trying to validate GICv3 on an AArch32_v8R >> system. Refer ARM DDI 0568A.c ID110520, B1.3.1, >> "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE must not >> implement LPI support." >> >> Updated SUPPORT.md. >> >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changed from :- >> v1 - 1. Remove "ARM_64 || ARM_32" as it is always true. >> 2. Updated SUPPORT.md. >> >> SUPPORT.md | 6 ++++++ >> xen/arch/arm/Kconfig | 4 ++-- >> xen/arch/arm/include/asm/cpufeature.h | 1 + >> 3 files changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/SUPPORT.md b/SUPPORT.md >> index cf2ddfacaf..0137855c66 100644 >> --- a/SUPPORT.md >> +++ b/SUPPORT.md >> @@ -82,6 +82,12 @@ Extension to the GICv3 interrupt controller to support MSI. >> >> Status: Experimental >> >> +### ARM/GICv3 + AArch32 ARM v8 >> + >> +GICv3 is supported on AArch32 ARMv8 (besides AArch64) > Looking at the CONFIG_GICV3, it can be enabled on arm32, which at the moment > supports only ARMv7 (see __lookup_processor_type -> proc-v7.S). > What will prevent the user from enabling GICv3 for ARMv7 based CPU? Yes, this is my mistake. ARMv7 does not support GICv3. I should have introduced a new macro AArch32_v8R so that GICV3 is defined for it.  config GICV3         bool "GICv3 driver" -       depends on ARM_64 && !NEW_VGIC +       depends on ARM_64 || AArch32_v8R !NEW_VGIC         default y         ---help--- > >> + >> + Status: Supported, not security supported >> + >> ## Guest Type >> >> ### x86/PV >> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >> index 1fe5faf847..7c3c6eb3bd 100644 >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -41,7 +41,7 @@ config ARM_EFI >> >> config GICV3 >> bool "GICv3 driver" >> - depends on ARM_64 && !NEW_VGIC >> + depends on !NEW_VGIC >> default y >> ---help--- >> >> @@ -50,7 +50,7 @@ config GICV3 >> >> config HAS_ITS >> bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED >> - depends on GICV3 && !NEW_VGIC >> + depends on GICV3 && !NEW_VGIC && !ARM_32 >> >> config HVM >> def_bool y >> diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h >> index c86a2e7f29..c62cf6293f 100644 >> --- a/xen/arch/arm/include/asm/cpufeature.h >> +++ b/xen/arch/arm/include/asm/cpufeature.h >> @@ -33,6 +33,7 @@ >> #define cpu_has_aarch32 (cpu_has_arm || cpu_has_thumb) >> >> #ifdef CONFIG_ARM_32 >> +#define cpu_has_gicv3 (boot_cpu_feature32(gic) >= 1) > What is the purpose of defining this macro if it is not used? It is used in xen/arch/arm/gic-v3.c, gicv3_init(). - Ayan > >> #define cpu_has_gentimer (boot_cpu_feature32(gentimer) == 1) >> /* >> * On Armv7, the value 0 is used to indicate that PMUv2 is not >> -- >> 2.17.1 >> >> > ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 04 11:31:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 11:31:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437535.691984 (Exim 4.92) (envelope-from ) id 1oquul-0000cw-46; Fri, 04 Nov 2022 11:31:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437535.691984; Fri, 04 Nov 2022 11:31:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oquul-0000cl-0m; Fri, 04 Nov 2022 11:31:11 +0000 Received: by outflank-mailman (input) for mailman id 437535; Fri, 04 Nov 2022 11:31:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oquuk-0000cf-5u for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 11:31:10 +0000 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [2a00:1450:4864:20::234]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c54eb23-5c34-11ed-8fd1-01056ac49cbb; Fri, 04 Nov 2022 12:31:07 +0100 (CET) Received: by mail-lj1-x234.google.com with SMTP id z24so5932001ljn.4 for ; Fri, 04 Nov 2022 04:31:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c54eb23-5c34-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TPf0Soipi+B+XneUdLGpWDaxYvecmd98mchm9m+5YaM=; b=IowpJ9ZOqVUH/Bsh2ItImHNPyrUnAi5GCovN0rcG7OImthLIuI+d7fhVZgqcBF3fXL 6aCC4eGkCmyClBFhCK8KL1E0RcFseD0gJEWqa/z70HpTU3RbyqSTxeNtOnaOja0KDuzZ W1mlddyeHaG8HXO5o2zFybjqrQbHGSiTgtsCFk/adg0W/G9qMyTyK5coZw/L4b/VPJZd FLQUXUOvfx6gTaUT0cTItb0SpRfEw18RGXRKrgqPlY2vKAHc2Aqp6iJneNqR7f4vJaIp QjeElVDe8QgwvAxBJsKKgP5PifQza35ietDO9nIsA6Ren4GaajwLkbPBholEvx7/kmVT ZmHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TPf0Soipi+B+XneUdLGpWDaxYvecmd98mchm9m+5YaM=; b=h9HK6BcPbKmF+x8DJVsuecSXR8UCqX2qhwjbOggX58+2CEOdYjsK5pE/grEptmy8GY z6gTp4HoG9Xr07RZ9CS8yK2Me1FVRDsKl/R+aPeXqf2A2o98OYlyByQE1oGq5//lVU1I vgk9bV8HhhUjjLj/JzzO63hlhDlCoJkgryuAPutx+NsyLA3hGWJdeLLI5b7YmepLp6t2 0wSK7/A0H7GnBAZi3Cv1fwvMrpqGlfPXrVnXVD5psdHdVCgnmZhiJvmNq5R4xENC6Wbo gBxt95zkCcN6yEjuXc3KcfZRBS8FZobP+0P34/Ah0j6fT8xcloNHeb9KlO/et4Mf6K5b d8FA== X-Gm-Message-State: ACrzQf3dXyYVgGlYvY6tiNsaXg5UHPslRhCkvZxor1THvMt/LLSMrFyF nzwa5G3Q//nShM812BBThhTP8TsqQB6z+vaxadw= X-Google-Smtp-Source: AMsMyM6RqE+iQ+XZpO2aK1M09aSbM8pZAzdVOVc+Stz4k1eerMNIz7fevp2zTUA8Ns7rOYGpf5Oi5YZm7xQnF8JQVIU= X-Received: by 2002:a2e:b63a:0:b0:277:40bb:d32b with SMTP id s26-20020a2eb63a000000b0027740bbd32bmr12863946ljn.396.1667561467059; Fri, 04 Nov 2022 04:31:07 -0700 (PDT) MIME-Version: 1.0 References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-13-ayankuma@amd.com> <45df5e11-9697-96ca-3c89-39bdbba48637@amd.com> <09b11bfe-6b7b-2da7-84ed-ad7c7c89b516@amd.com> In-Reply-To: <09b11bfe-6b7b-2da7-84ed-ad7c7c89b516@amd.com> From: Julien Grall Date: Fri, 4 Nov 2022 12:30:55 +0100 Message-ID: Subject: Re: [XEN v2 12/12] xen/Arm: GICv3: Enable GICv3 for AArch32 To: Ayan Kumar Halder Cc: Bertrand.Marquis@arm.com, Michal Orzel , Volodymyr_Babchuk@epam.com, burzalodowa@gmail.com, sstabellini@kernel.org, stefanos@xilinx.com, xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="000000000000e2b47705eca368f4" --000000000000e2b47705eca368f4 Content-Type: text/plain; charset="UTF-8" On Fri, 4 Nov 2022 at 12:09, Ayan Kumar Halder wrote: > > On 04/11/2022 09:55, Michal Orzel wrote: > > Hi Ayan, > Hi Michal, > > > > On 31/10/2022 16:13, Ayan Kumar Halder wrote: > >> > >> Refer ARM DDI 0487G.b ID072021, > >> D13.2.86 - > >> ID_PFR1_EL1, AArch32 Processor Feature Register 1 > >> > >> GIC, bits[31:28] == 0b0001 for GIC3.0 on Aarch32 > >> > >> One can now enable GICv3 on AArch32 systems. However, ITS is not > supported. > >> The reason being currently we are trying to validate GICv3 on an > AArch32_v8R > >> system. Refer ARM DDI 0568A.c ID110520, B1.3.1, > >> "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE > must not > >> implement LPI support." > >> > >> Updated SUPPORT.md. > >> > >> Signed-off-by: Ayan Kumar Halder > >> --- > >> > >> Changed from :- > >> v1 - 1. Remove "ARM_64 || ARM_32" as it is always true. > >> 2. Updated SUPPORT.md. > >> > >> SUPPORT.md | 6 ++++++ > >> xen/arch/arm/Kconfig | 4 ++-- > >> xen/arch/arm/include/asm/cpufeature.h | 1 + > >> 3 files changed, 9 insertions(+), 2 deletions(-) > >> > >> diff --git a/SUPPORT.md b/SUPPORT.md > >> index cf2ddfacaf..0137855c66 100644 > >> --- a/SUPPORT.md > >> +++ b/SUPPORT.md > >> @@ -82,6 +82,12 @@ Extension to the GICv3 interrupt controller to > support MSI. > >> > >> Status: Experimental > >> > >> +### ARM/GICv3 + AArch32 ARM v8 > >> + > >> +GICv3 is supported on AArch32 ARMv8 (besides AArch64) > > Looking at the CONFIG_GICV3, it can be enabled on arm32, which at the > moment > > supports only ARMv7 (see __lookup_processor_type -> proc-v7.S). > > What will prevent the user from enabling GICv3 for ARMv7 based CPU? > Yes, this is my mistake. > > ARMv7 does not support GICv3. The same could be said for Xen on Aarch32 Armv8. This is not officially supported but works with some tweak in the lookup function. > > I should have introduced a new macro AArch32_v8R so that GICV3 is > defined for it. I would rather not have such config. There are no issue to allow someone to build it for 32-bit because Xen is perfectly capable to detect which GIC version is in use. Instead we could simply disable GICv3 by default for arm32. > > config GICV3 > bool "GICv3 driver" > - depends on ARM_64 && !NEW_VGIC > + depends on ARM_64 || AArch32_v8R !NEW_VGIC > default y > ---help--- > > > > >> + > >> + Status: Supported, not security supported > >> + > >> ## Guest Type > >> > >> ### x86/PV > >> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > >> index 1fe5faf847..7c3c6eb3bd 100644 > >> --- a/xen/arch/arm/Kconfig > >> +++ b/xen/arch/arm/Kconfig > >> @@ -41,7 +41,7 @@ config ARM_EFI > >> > >> config GICV3 > >> bool "GICv3 driver" > >> - depends on ARM_64 && !NEW_VGIC > >> + depends on !NEW_VGIC > >> default y > >> ---help--- > >> > >> @@ -50,7 +50,7 @@ config GICV3 > >> > >> config HAS_ITS > >> bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if > UNSUPPORTED > >> - depends on GICV3 && !NEW_VGIC > >> + depends on GICV3 && !NEW_VGIC && !ARM_32 > >> > >> config HVM > >> def_bool y > >> diff --git a/xen/arch/arm/include/asm/cpufeature.h > b/xen/arch/arm/include/asm/cpufeature.h > >> index c86a2e7f29..c62cf6293f 100644 > >> --- a/xen/arch/arm/include/asm/cpufeature.h > >> +++ b/xen/arch/arm/include/asm/cpufeature.h > >> @@ -33,6 +33,7 @@ > >> #define cpu_has_aarch32 (cpu_has_arm || cpu_has_thumb) > >> > >> #ifdef CONFIG_ARM_32 > >> +#define cpu_has_gicv3 (boot_cpu_feature32(gic) >= 1) > > What is the purpose of defining this macro if it is not used? > > It is used in xen/arch/arm/gic-v3.c, gicv3_init(). > > - Ayan > > > > >> #define cpu_has_gentimer (boot_cpu_feature32(gentimer) == 1) > >> /* > >> * On Armv7, the value 0 is used to indicate that PMUv2 is not > >> -- > >> 2.17.1 > >> > >> > > ~Michal > --000000000000e2b47705eca368f4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, 4 Nov 2022 at 12:09, Ayan Kumar Halder <ayankuma@amd.com> wrote:

On 04/11/2022 09:55, Michal Orzel wrote:
> Hi Ayan,
Hi Michal,
>
> On 31/10/2022 16:13, Ayan Kumar Halder wrote:
>>
>> Refer ARM DDI 0487G.b ID072021,
>> D13.2.86 -
>> ID_PFR1_EL1, AArch32 Processor Feature Register 1
>>
>> GIC, bits[31:28] =3D=3D 0b0001 for GIC3.0 on Aarch32
>>
>> One can now enable GICv3 on AArch32 systems. However, ITS is not s= upported.
>> The reason being currently we are trying to validate GICv3 on an A= Arch32_v8R
>> system. Refer ARM DDI 0568A.c ID110520, B1.3.1,
>> "A Generic Interrupt Controller (GIC) implemented with an Arm= v8-R PE must not
>> implement LPI support."
>>
>> Updated SUPPORT.md.
>>
>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>> ---
>>
>> Changed from :-
>> v1 - 1. Remove "ARM_64 || ARM_32" as it is always true.<= br> >> 2. Updated SUPPORT.md.
>>
>>=C2=A0 =C2=A0SUPPORT.md=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 6 ++++++
>>=C2=A0 =C2=A0xen/arch/arm/Kconfig=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 4 ++--
>>=C2=A0 =C2=A0xen/arch/arm/include/asm/cpufeature.h | 1 +
>>=C2=A0 =C2=A03 files changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/SUPPORT.md b/SUPPORT.md
>> index cf2ddfacaf..0137855c66 100644
>> --- a/SUPPORT.md
>> +++ b/SUPPORT.md
>> @@ -82,6 +82,12 @@ Extension to the GICv3 interrupt controller to = support MSI.
>>
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Status: Experimental
>>
>> +### ARM/GICv3 + AArch32 ARM v8
>> +
>> +GICv3 is supported on AArch32 ARMv8 (besides AArch64)
> Looking at the CONFIG_GICV3, it can be enabled on arm32, which at the = moment
> supports only ARMv7 (see __lookup_processor_type -> proc-v7.S).
> What will prevent the user from enabling GICv3 for ARMv7 based CPU?

Yes, this is my mistake.

ARMv7 does not support GICv3.

The same could be said for Xen on Aarch32 Armv8. This is not o= fficially supported but works with some tweak in the lookup function.
=



I should have introduced a new macro AArch32_v8R so that GICV3 is
defined for it.

I would rather not have such conf= ig. There are no issue to allow someone to build it for 32-bit because Xen = is perfectly capable to detect which GIC version is in use.

Instead we could simply disable GICv3= by default for arm32.



=C2=A0=C2=A0config GICV3
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bool "GICv3 driver&qu= ot;
-=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on ARM_64 && !NEW_VGI= C
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on ARM_64 || AArch32_v8R !NEW= _VGIC
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 default y
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ---help---

>
>> +
>> +=C2=A0 =C2=A0 Status: Supported, not security supported
>> +
>>=C2=A0 =C2=A0## Guest Type
>>
>>=C2=A0 =C2=A0### x86/PV
>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
>> index 1fe5faf847..7c3c6eb3bd 100644
>> --- a/xen/arch/arm/Kconfig
>> +++ b/xen/arch/arm/Kconfig
>> @@ -41,7 +41,7 @@ config ARM_EFI
>>
>>=C2=A0 =C2=A0config GICV3
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bool "GICv3 driver" >> -=C2=A0 =C2=A0 =C2=A0 =C2=A0depends on ARM_64 && !NEW_VGIC=
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0depends on !NEW_VGIC
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 default y
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ---help---
>>
>> @@ -50,7 +50,7 @@ config GICV3
>>
>>=C2=A0 =C2=A0config HAS_ITS
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool "GICv3 ITS MSI c= ontroller support (UNSUPPORTED)" if UNSUPPORTED
>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 depends on GICV3 && !NEW_VGIC=
>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 depends on GICV3 && !NEW_VGIC= && !ARM_32
>>
>>=C2=A0 =C2=A0config HVM
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0def_bool y
>> diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/= include/asm/cpufeature.h
>> index c86a2e7f29..c62cf6293f 100644
>> --- a/xen/arch/arm/include/asm/cpufeature.h
>> +++ b/xen/arch/arm/include/asm/cpufeature.h
>> @@ -33,6 +33,7 @@
>>=C2=A0 =C2=A0#define cpu_has_aarch32=C2=A0 =C2=A0(cpu_has_arm || cp= u_has_thumb)
>>
>>=C2=A0 =C2=A0#ifdef CONFIG_ARM_32
>> +#define cpu_has_gicv3=C2=A0 =C2=A0 =C2=A0(boot_cpu_feature32(gic)= >=3D 1)
> What is the purpose of defining this macro if it is not used?

It is used in xen/arch/arm/gic-v3.c, gicv3_init().

- Ayan

>
>>=C2=A0 =C2=A0#define cpu_has_gentimer=C2=A0 (boot_cpu_feature32(gen= timer) =3D=3D 1)
>>=C2=A0 =C2=A0/*
>>=C2=A0 =C2=A0 * On Armv7, the value 0 is used to indicate that PMUv= 2 is not
>> --
>> 2.17.1
>>
>>
> ~Michal
--000000000000e2b47705eca368f4-- From xen-devel-bounces@lists.xenproject.org Fri Nov 04 11:52:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 11:52:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437540.691995 (Exim 4.92) (envelope-from ) id 1oqvF7-0004Ic-NJ; Fri, 04 Nov 2022 11:52:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437540.691995; Fri, 04 Nov 2022 11:52:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqvF7-0004IV-Ka; Fri, 04 Nov 2022 11:52:13 +0000 Received: by outflank-mailman (input) for mailman id 437540; Fri, 04 Nov 2022 11:52:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqvF6-0004IP-1a for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 11:52:12 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2068.outbound.protection.outlook.com [40.107.100.68]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1bc94813-5c37-11ed-8fd1-01056ac49cbb; Fri, 04 Nov 2022 12:52:09 +0100 (CET) Received: from BN0PR04CA0040.namprd04.prod.outlook.com (2603:10b6:408:e8::15) by PH7PR12MB5901.namprd12.prod.outlook.com (2603:10b6:510:1d5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 4 Nov 2022 11:52:06 +0000 Received: from BN8NAM11FT045.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e8:cafe::9b) by BN0PR04CA0040.outlook.office365.com (2603:10b6:408:e8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 11:52:05 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT045.mail.protection.outlook.com (10.13.177.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 11:52:05 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 4 Nov 2022 06:52:05 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 4 Nov 2022 04:52:05 -0700 Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 4 Nov 2022 06:52:03 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1bc94813-5c37-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ik396+UXLMhOuGXPHPzmF0qJqj5oDbMV+D9WkNNUY7HssyhHgPcFHIqQUmjrZSFH1nk6Xm/tZxGREonAjOFP3po/FcW1x8kwjsBQxSE68OGM+1yzr9rq41B+OmN0pW2WHv+ANIu45bJEQHc3cWYIz8e+jEaLOhF1/4S0oz5D9ubh0JC8NCplc64K0Pd326gUfayNQh9FS88oQh5vTSBAy1P6H61Li96eB3MueziE5xZIqOqpqaHdUHDJ084jLc9pTN6DM7N63goenR4XXPpBo2WAyMkKUSa2N7GZEvrZfxqTzEwpN9yXN0E+D1ZlB05GO4qlNVZ8avOAguZ8G/SNVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VFEIUwlv5vt9leYEZ50wsW/8cwkFnoT1YEVs5Imbq5c=; b=Dd/HdGhDk8RjGhHBnyiXSsJPiNBFYK80J32UKop8JWJuT3qxX5DdWE0g9mXGLl1w/7SxDqNxnUYE+kd5e189XjzdLEKhKEzu7GPtME1GM9OLBl92sf2dvdpWw2RxIWgZDdS2owWa6Lwqp/NdEqrjU8jrJsceHjf+PeXpKAuR9y5gWuQZlq5tnTcKpd/KLO8gXzBxJbQCtTs+iyUUblKU1l3iJP+Y7WuVhUWCJ1xGwg+C6WrWkLV+WZcKEl9BFUqE2H8hn8FdBCMo1hx9QjLy3rIphHzNu2esH6DQK6pOD3Js5J3IUASHC9KG9zd7zP0/o9OBoZ+qk2HnCmanntvBsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VFEIUwlv5vt9leYEZ50wsW/8cwkFnoT1YEVs5Imbq5c=; b=LfwRUFz7pLCAUoos7BmP/EvSeGyFfQOUMCCEvzPiddvpMFtZwQUeBeQWJvBN9sHRKB9Eb2sToB/QojfnpffVBWB26x5DW9xzL8tYIl+Fw5BcfG5oXAXllQJHz9f4hiK4mIhES4AlD7YZWjYwj6jxTGhkrc9KkYWLKgB1ns2JoeA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <496f490a-1f87-d36f-7e47-1f4a331699f3@amd.com> Date: Fri, 4 Nov 2022 12:52:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 12/12] xen/Arm: GICv3: Enable GICv3 for AArch32 Content-Language: en-US To: Julien Grall , Ayan Kumar Halder CC: , , , , , References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-13-ayankuma@amd.com> <45df5e11-9697-96ca-3c89-39bdbba48637@amd.com> <09b11bfe-6b7b-2da7-84ed-ad7c7c89b516@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT045:EE_|PH7PR12MB5901:EE_ X-MS-Office365-Filtering-Correlation-Id: 1346fa60-36b9-4b84-9654-08dabe5afed8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 38DdJBC05ubMO1B1fWpub3O/e8RbtQ1nuZCSOESgjBhAhP5aPYJptrpLNZ4xJGBFUta0ZrJRbw7bbT+svkL9c5sZrazf82m0FP9RrSyqVgu9qZF21ocfosNNoNnWLtvtD+LEG7kiGeka5d8pAVOsBB6uT29NcQxvtOkKWHiJYLS1LWS1XBcpQp+KBlCp0+4/Jps7OOAw7zmHhzODdri0vP17sgcWMezLy8f9LIumoILGi1/E9StzFMcMG73/FO2p0rAuj7FcsOd74LWwHXBbZhny+HueVitqvCfuq+LLmO1WahRZNv7kh1KzMyAuEZ01y0qaafvBqeFTBgNvQshvg+luX6v3t6z3nqvF+LaxBlbkoZCrqQfLqmGsOBA9YpfXci1bxenbipITT9m+h9L0pwwrOIvhqesYuZxw9Y6QJTupaTYMTuDtKSrCOHzI/PEvnysbQo6Fj64r2ZIJcnZrAiMphYTWVQW9vGLX7b5ElMKinUSqI1+JcbKw2MJ0CXlwU+qK7BtZFZ0Z5WS72cm80xiQ26McgVp0lbjn28gs1Jq2uFmwTK+k+SUzQ4Jni6HoYo1H3bibtmCR2pKZrd3mN+IOEmvacJ8+N5PDic6JeWZKpBtyxqk4AFa4dHnFJNU0hB3WymzNq/xIxO5Ix/NtTWYzyzEO7VwPESQTF2plxHRpkU3GCb3gZPO88uZP2kI4qrtaf3gGzxYMha3JSsoj1eXJ/kjQuXliYwWhtMO9STNlNZ0o3+NFh6hVS8H564USIwsWDLovrrnrryS3l6bzH4s2WdqPajpVG0Rx9lqe74DO8A5ARnVbyhqx/cvwoBqriI6dQwO4IgwAcqoGDAUKTA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(8676002)(356005)(82740400003)(81166007)(70586007)(70206006)(336012)(36756003)(26005)(6636002)(110136005)(47076005)(316002)(2906002)(41300700001)(4326008)(53546011)(16576012)(54906003)(83380400001)(86362001)(31696002)(44832011)(40460700003)(40480700001)(36860700001)(5660300002)(8936002)(186003)(2616005)(31686004)(82310400005)(478600001)(426003)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 11:52:05.7975 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1346fa60-36b9-4b84-9654-08dabe5afed8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT045.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5901 On 04/11/2022 12:30, Julien Grall wrote: > > > > > > On Fri, 4 Nov 2022 at 12:09, Ayan Kumar Halder > wrote: > > > On 04/11/2022 09:55, Michal Orzel wrote: > > Hi Ayan, > Hi Michal, > > > > On 31/10/2022 16:13, Ayan Kumar Halder wrote: > >> > >> Refer ARM DDI 0487G.b ID072021, > >> D13.2.86 - > >> ID_PFR1_EL1, AArch32 Processor Feature Register 1 > >> > >> GIC, bits[31:28] == 0b0001 for GIC3.0 on Aarch32 > >> > >> One can now enable GICv3 on AArch32 systems. However, ITS is not supported. > >> The reason being currently we are trying to validate GICv3 on an AArch32_v8R > >> system. Refer ARM DDI 0568A.c ID110520, B1.3.1, > >> "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE must not > >> implement LPI support." > >> > >> Updated SUPPORT.md. > >> > >> Signed-off-by: Ayan Kumar Halder > > >> --- > >> > >> Changed from :- > >> v1 - 1. Remove "ARM_64 || ARM_32" as it is always true. > >> 2. Updated SUPPORT.md. > >> > >>   SUPPORT.md                            | 6 ++++++ > >>   xen/arch/arm/Kconfig                  | 4 ++-- > >>   xen/arch/arm/include/asm/cpufeature.h | 1 + > >>   3 files changed, 9 insertions(+), 2 deletions(-) > >> > >> diff --git a/SUPPORT.md b/SUPPORT.md > >> index cf2ddfacaf..0137855c66 100644 > >> --- a/SUPPORT.md > >> +++ b/SUPPORT.md > >> @@ -82,6 +82,12 @@ Extension to the GICv3 interrupt controller to support MSI. > >> > >>       Status: Experimental > >> > >> +### ARM/GICv3 + AArch32 ARM v8 > >> + > >> +GICv3 is supported on AArch32 ARMv8 (besides AArch64) > > Looking at the CONFIG_GICV3, it can be enabled on arm32, which at the moment > > supports only ARMv7 (see __lookup_processor_type -> proc-v7.S). > > What will prevent the user from enabling GICv3 for ARMv7 based CPU? > > > Yes, this is my mistake. > > ARMv7 does not support GICv3. > > > The same could be said for Xen on Aarch32 Armv8. This is not officially supported but works with some tweak in the lookup function. > > > > I should have introduced a new macro AArch32_v8R so that GICV3 is > defined for it. > > > I would rather not have such config. There are no issue to allow someone to build it for 32-bit because Xen is perfectly capable to detect which GIC version is in use. > > Instead we could simply disable GICv3 by default for arm32. +1 ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 04 12:05:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 12:05:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437559.692006 (Exim 4.92) (envelope-from ) id 1oqvS5-0007JG-6w; Fri, 04 Nov 2022 12:05:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437559.692006; Fri, 04 Nov 2022 12:05:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqvS5-0007J9-2r; Fri, 04 Nov 2022 12:05:37 +0000 Received: by outflank-mailman (input) for mailman id 437559; Fri, 04 Nov 2022 12:05:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqvS4-0007Ig-7g; Fri, 04 Nov 2022 12:05:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqvS4-0007gZ-4a; Fri, 04 Nov 2022 12:05:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqvS3-0000o8-LS; Fri, 04 Nov 2022 12:05:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqvS3-0000KO-Kv; Fri, 04 Nov 2022 12:05:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zqaw7TmrjkFVrqvnHkDuTkwC/jpxWykzqbRTak5ye4M=; b=Ck7jfgIyGuxqugJ8EPbmGaA91c 3ryQu9RXhNdjWALlySU5NjSHFI63RGEFjrWLj81rODXZdR0yCK+ScZyXiIGNF9Hoe1zajH+Q3NZWq iup/vsJOFj31lihyk9b8Sjgjzg+PVgHOgTvblhx2pHZtFxJh9LpNH6m4ocbR9+ANEkQg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174620: all pass - PUSHED X-Osstest-Versions-This: ovmf=2695e4921944d12be3d7e38f8e68a5c5ed01b005 X-Osstest-Versions-That: ovmf=ee3da09bb2b7284a8bda6b7d85160cdd63cfb405 From: osstest service owner Date: Fri, 04 Nov 2022 12:05:35 +0000 flight 174620 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174620/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 2695e4921944d12be3d7e38f8e68a5c5ed01b005 baseline version: ovmf ee3da09bb2b7284a8bda6b7d85160cdd63cfb405 Last test of basis 174613 2022-11-04 04:10:28 Z 0 days Testing same since 174620 2022-11-04 06:41:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: VictorX Hsu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git ee3da09bb2..2695e49219 2695e4921944d12be3d7e38f8e68a5c5ed01b005 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Nov 04 13:41:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 13:41:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437574.692017 (Exim 4.92) (envelope-from ) id 1oqww7-0005mS-Ut; Fri, 04 Nov 2022 13:40:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437574.692017; Fri, 04 Nov 2022 13:40:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqww7-0005mL-QM; Fri, 04 Nov 2022 13:40:43 +0000 Received: by outflank-mailman (input) for mailman id 437574; Fri, 04 Nov 2022 13:40:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqww6-0005lP-JG; Fri, 04 Nov 2022 13:40:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqww6-0001FA-Gj; Fri, 04 Nov 2022 13:40:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqww6-0004Pe-09; Fri, 04 Nov 2022 13:40:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqww5-0004nI-Vu; Fri, 04 Nov 2022 13:40:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qiVA82xzCGPYMfsSLeWYMdUdctpseb7IOgmKlqSUeGE=; b=m6WXFPz9I50zuP0XunYcGrMb8w 6TihlSIArF9NkbWHAXj2I+/Nbegu9torIdVuU2O10UgvQD+g6hh513JXzF0F/re+pRG0DsfQUk88x Ad+N08Y+/Bm2K+JO1kE3Sxr5HssI9Wt/dt5ev7kdEstBZyXu0KvjvQ3pq7o9jP9dRdio=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174622: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=37f82facd62f720fdcec104f72f86b8c6c214820 X-Osstest-Versions-That: xen=9f3e585ff5ecc606e386057f5cfa66b22fea2b93 From: osstest service owner Date: Fri, 04 Nov 2022 13:40:41 +0000 flight 174622 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174622/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 37f82facd62f720fdcec104f72f86b8c6c214820 baseline version: xen 9f3e585ff5ecc606e386057f5cfa66b22fea2b93 Last test of basis 174621 2022-11-04 08:03:30 Z 0 days Testing same since 174622 2022-11-04 11:02:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dario Faggioli Juergen Gross Marek Marczykowski-Górecki jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9f3e585ff5..37f82facd6 37f82facd62f720fdcec104f72f86b8c6c214820 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Nov 04 13:54:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 13:54:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437582.692027 (Exim 4.92) (envelope-from ) id 1oqx9N-00085V-2S; Fri, 04 Nov 2022 13:54:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437582.692027; Fri, 04 Nov 2022 13:54:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqx9M-00085O-Vq; Fri, 04 Nov 2022 13:54:24 +0000 Received: by outflank-mailman (input) for mailman id 437582; Fri, 04 Nov 2022 13:54:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqx9L-00085E-FR; Fri, 04 Nov 2022 13:54:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqx9L-0001ah-BO; Fri, 04 Nov 2022 13:54:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqx9K-0004lu-SL; Fri, 04 Nov 2022 13:54:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqx9K-0000fC-Rn; Fri, 04 Nov 2022 13:54:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lCb/Eqp92rr0Xdz0y/xFKW7oc9aLyytEt/QycPGdHcA=; b=saTpjMybFAKe586U6w5eG0NHZZ oZscFYQVyWuTGFR5Eh4zFhfBw+JzZ7oPkb6/wdTu3rvgkbG6v9dm/gUzqQQOq6MMYjYIb7fXevNc3 /PQhCkBZff42Pj1oM0kFFVcPXGg0e8xdrnkJXG5TJOejDOGyDrG5MbHgM40wd41HzDMU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174623: all pass - PUSHED X-Osstest-Versions-This: ovmf=eff44c008d99eca6e3700e864b014821ba88683c X-Osstest-Versions-That: ovmf=2695e4921944d12be3d7e38f8e68a5c5ed01b005 From: osstest service owner Date: Fri, 04 Nov 2022 13:54:22 +0000 flight 174623 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174623/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf eff44c008d99eca6e3700e864b014821ba88683c baseline version: ovmf 2695e4921944d12be3d7e38f8e68a5c5ed01b005 Last test of basis 174620 2022-11-04 06:41:48 Z 0 days Testing same since 174623 2022-11-04 12:13:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Guorui Yu Min M Xu Min Xu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 2695e49219..eff44c008d eff44c008d99eca6e3700e864b014821ba88683c -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Nov 04 14:23:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 14:23:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437604.692050 (Exim 4.92) (envelope-from ) id 1oqxbL-000483-FA; Fri, 04 Nov 2022 14:23:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437604.692050; Fri, 04 Nov 2022 14:23:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqxbL-00047w-Bp; Fri, 04 Nov 2022 14:23:19 +0000 Received: by outflank-mailman (input) for mailman id 437604; Fri, 04 Nov 2022 14:23:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqxbJ-0003sR-Lf for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 14:23:17 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 38bacf90-5c4c-11ed-8fd1-01056ac49cbb; Fri, 04 Nov 2022 15:23:16 +0100 (CET) Received: from mail-mw2nam12lp2045.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Nov 2022 10:23:14 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6515.namprd03.prod.outlook.com (2603:10b6:806:1c6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 14:23:13 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 14:23:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38bacf90-5c4c-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667571795; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=VYL+hzjB7lbIlUEHE09YaODWT83Im/OH6H2agw+itPc=; b=Z97IAN/u8bTNXjzxpvdMvGxyVUBfw08fO7JgxPn6i6piFhatEiekPWoN gqZDbnTHq3en2B5IQfiwFUPrskCzzy1W4rS9zOx0Hih7fblzYROHSAzSp +QIIE0VW1AM7mGP/9tgHvzyTIWZonGjIVp9nAXeox/7pNtu3BTa87XBl1 8=; X-IronPort-RemoteIP: 104.47.66.45 X-IronPort-MID: 84179918 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:HhXwpaBNLes2mBVW/93iw5YqxClBgxIJ4kV8jS/XYbTApDxzhD0Fn WoaCDuDaamDYTT3c9olb4y/80oB75fTzoJrQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpA4gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5LcwLGsW8 rsjFBcJdRyOg7K/na2URbw57igjBJGD0II3nFhFlGucKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTL++xrvgA/zyQouFTpGMDSddGQA91cg26Tp 37c/nS/CRYfXDCa4WrZqy3917af9c/9cLgzH5Pk/aFXuw2WxW8DBDgnBFnh4ubs3yZSXPoac ST44BEGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy65C24eX3h+YdopnMYsQHoh0 Vrht8vgGDhHoLCTD3WH+d+8sjeaKSUTa2gYakcsTwEI/t3iq4EblQ/UQ5BoF6vdpt/oH3f2y jODrik7jp0Si9IG0+Ow+lWvqzGhuJnPCBI07wP/X2S54wc/b4mgD7FE8nDe5PdEaYOGFF+Iu SFen9DEtLxTS5aQiCaKXeMBWqmz4OqIOyHdhlgpGIQ98zOq+DioeoU4DCxCGXqF+/0sIVfBC HI/cysIjHOPFBNGtZNKXr8= IronPort-HdrOrdr: A9a23:F1jHCqyKe3hpUU+USLB1KrPxvuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scu9qBTnhORICOgqTMyftWzd1FdAQ7sSibcKrweBJ8S6zJ8l6U 4CSdkANDSPNykcsS+S2mDRfbcdKZu8gdiVbI/lvgtQpGpRGsRdBmlCe2Wm+hocfng6OXN1Lu vU2iIBzADQCkg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/iosKwC zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6N2H2RIPqp 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCulqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv60vouqhNDqWs3N 60QpiApIs+MPP+UpgNddvpOfHHbFAlYSi8R156cm6XYp0vCjbql6PdxokTyaWDRKEopaFC6q gpFmko/1IPRw== X-IronPort-AV: E=Sophos;i="5.96,137,1665460800"; d="scan'208";a="84179918" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RZW1uNpL2RIz4FzK0P7NXDgXTtzt8F8pYib+/gK7XxV5gb7xvPUEskJtLGypNMgn5XL8/dQ9dq7X/wqllQnofTfR6R/SaC20R4yCAFZVnLfBLK3CGEBAoq1q667bQXooija8i0kMalsykNRa6q2I/vxbdNDdQsnYC40vb0NnlHyPommGw0wg21j28/SHq0glJh5vRz6M15IfPdODoCXBzOKqQFAQYZWbTXPUqmJ2MsgeVxrjlG4sVOj+wfU/mSg1FWE4y2lWELnj4V133jhB8WoIUGZr7NHFOh8XyVcxb40SS/v/hu6eRPZCrKVuhdqxtUtEhwF0N0nC6D6h6KFJjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h0VcqjNzyHIxHH55hlOLAVdp/ZJFXM8586OjJ/vmBCI=; b=nAtH+xQkhuF9f4kMzwqaymzYe3vruj9HdlJsS7PbB+3lZtCRgM2X7nyxtobAjTZfHlzPOS6VliJqChQtGCyXmJAgbpyQiYlnul0pK0X21iktlCAg7fDOUYjTFDl/x35zNsILKotgvogR1ZYtu0DQtnsK7YFdfHEfITMr9LETvF1kbhPgXy7Sg0Xucnb2hW48UzIibCHFWfDzlbtklAEP6yJQPBKFBV6ENy7o8lTDwqbOSCq/nx9qymW4yWcbI0my5uIeYsbnjM+WXvHg2HAoOXVWBE9EKnMCGsxNJQURnd/QsJUfBTLnBKcvkY4tXF9tQcJmxVqLEsNUO8wK2ybAig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h0VcqjNzyHIxHH55hlOLAVdp/ZJFXM8586OjJ/vmBCI=; b=f9+F9yhJ6a4bxLjU2gx+0AAlYFloArILsLYR2kseCVlFORt7EwahOM+bYwuIizojeD9qfZyBc9Vu07sVxlMUpzS5i2/1qkIOE3vV9P924KpbKCyT0mDO07hBXSzLU5CO4pOMwB3FUikRNu0Iib0M6K8Hfk4V54kn4OYg1T4/LuU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Roger Pau Monne , Paul Durrant , Wei Liu , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian Subject: [PATCH for-4.17 2/2] hvm/apic: repurpose the reporting of the APIC assist options Date: Fri, 4 Nov 2022 15:22:35 +0100 Message-Id: <20221104142235.36556-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221104142235.36556-1-roger.pau@citrix.com> References: <20221104142235.36556-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0014.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::26) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6515:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d2831f5-099b-4035-1405-08dabe701b59 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +vcWNFWEx/JM/lHqulE0m2hQegcO5NY7RT68xMDFH4BaDJdSR0L/pDVPA90qYgWlESoVLnXJYgmNpN1XZp9bOtv/I3G3ECV+kW8A8QRzke4ykduAin4hBmeAR7Kvsh3Tq/+4irCht90A7gAgE/F6dbZZOqjWpr07IzqEBQi5Uv+ZaHHAfopuAsFDihlLLHnsrTlxWn2ymssxrKNQxT8fT11miFUJkFSkQbG2ccJLASdiZPl7+1GcVzVHSUX741epSAscY58sJEYRbzBueJYEl140MgcJbI9WbZcCURqoQgUbhCEvC467/acyE/AzZTUhyDYNUPoaGXw0IePBxNrLZ8/CmpJg9upmgwfhlzJrNi/U9t7u5hUEVWnCGG0ihcMf3c9OGbQPq2z3x/JdfygKACgRV0in9DvKoyMzoKbB7Y3au50OdqvQvmRkK3siMNts7JLafqx14YS8il+Be6tQSxjnQEbdHZPhDb5rRXdhrt7FFOust+xClelCBs4KLC4YUZHtDdFkaRA15y+OiEpaEbxdG9Z6okraYli39jLrKS0SDNunXk6u/gxZH1ocm6GJTFFCdeWtX/2ZD181HDNmdv7ranIknJWJwMYMSEF3nOrnjqxVp5211GHlVIUg1VeweIy7/9YAx7fqwHHYXExkZ+kxKeB2pKhvFd+P9PfB0SjzHlFmDCTQqyoAJzA3R+RZrPijFrNl1EGehLvQXyH3Kg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(451199015)(5660300002)(82960400001)(38100700002)(66476007)(66556008)(66946007)(4326008)(316002)(8676002)(8936002)(54906003)(6916009)(41300700001)(36756003)(2906002)(6506007)(26005)(6512007)(6666004)(186003)(478600001)(6486002)(2616005)(83380400001)(1076003)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2lXaDdwOGg2ZVM4dGdNQjBmZm9lWW1JQk1oODg0Q1pnK29YQ3ExaWJlRllY?= =?utf-8?B?dzJaSDVBNVZ0djJUY245c3dwYy83V1hBQnBmOVN6UnRVbDI1cGxXYkgwMG5G?= =?utf-8?B?UWlaU3Exa1M4WXFacFZhSzd5WloyOEhsMTlwblJ1UWswOHdsMzU1aHcxUTZP?= =?utf-8?B?OUlVYXR3MEl6UFI5a1dodkFnZGtXSmdlVnd0T0NJYVpoeUV2TjVabXFYSERW?= =?utf-8?B?UlR3M2lBWjlSRzlPQzZZTy93d2VyWXQ3b0RySWtMOURqZVR4TlgxMTVHYmdJ?= =?utf-8?B?dDl5NGRZb0RhQ1RGV1k2YXBtVFZkTW9rSWtFRjVUaDdhbjV0VHpvQ3E0ZFRz?= =?utf-8?B?Rk5wT1NaSTcwRC81SEcyOTBvZHJSL0FiSk1XNnllTGhaUHBMSjFOeUlVUmYw?= =?utf-8?B?VXU3bXRkRk5UQ0lOREtIV2F0b1BNNVpiL1FrMFA1clJqL2NhUE5obGN6NDVL?= =?utf-8?B?WXQzYlp2WUx3V1Jad0dqTnliWEFlWjNueGE1QWFPcXBSeFk2RWxDRW4xSDN4?= =?utf-8?B?N2c3bmtjaVBxQWN6ZWIwTnd1MnJvMnhiM1Vlc0ZhckpRdGNiaVZ2MWZ3MW5I?= =?utf-8?B?RzFBY1A0U1FpZGkxRkJWMGxTNmtoOVRLM1dwMVBMSnl6L2g5WHp2SW8xaVQv?= =?utf-8?B?Ui83VERubXNoNUI5RnlsaE9hSGNZOEt2dVUyUjJ0SWZYMW1tWG9oZnQwYkt5?= =?utf-8?B?SkhNNkJuR09GeUdhUWFSbTdKd2VuODhTNHU3dmZGRlYydGYxbEFoTENHall5?= =?utf-8?B?Q1piVjlybCtrUThKNlFuQVRFUFo2OU94aUdheDZia0JYLzYySjZaM3BibXI4?= =?utf-8?B?ZEhNdFlUM0xQTldBaXh4Skt6eHQ0SWQzcTFpNXlKRXZlZkVxazA2elF0bDRF?= =?utf-8?B?QUNFZHlDV2pJZFhDRG9VU1p2Ym1KaUdpaW9aTU1YNStKdWpWMjlhWFBKeFAz?= =?utf-8?B?RGt4UUtyY1g4N2h5SnRPK0pReDVCRFRrdDc5bG1oMkZEYmVjbkFNS1IwWGpS?= =?utf-8?B?YzgxZUdmMWNNQ3NReTI5NFBuYXF2QjJzVmtEbkxKZmVXanoxOS96TmhHemtF?= =?utf-8?B?QUNlNERtbWVybXhxZnpYcHVxaDYxNk8yM0hjaHlZbWhZYmZUWHd4SnFyRi9r?= =?utf-8?B?VmxXUDl6RnJ4a0ZIQi9DUHExTXpFVWR2U1cxK0ZYQWV3bHdJUFE4WnMydGdJ?= =?utf-8?B?eWdxSFdRQkpHZ28raDJOK0ovU3lOM2VTY2V3TXZCWnZYbFV4azhkNGQwK2xx?= =?utf-8?B?KzQ0MzQ5dUgrRmoxZ0JEOGJtc3hoQng0cUoyd1hlMm51N1M3bVZWclRQdWNQ?= =?utf-8?B?eTVrNEovUnNCT2U3LzU2b2w1T2h5WUFaNlhNQitjY0VmeWZXU0h5MzduK1c5?= =?utf-8?B?K1lHSEJBcEtGeVV6NkE5NHViaXk0SHRpdmN1MmFpYmFzekJxQjB5cUNTWUdl?= =?utf-8?B?QmJUK0ZrcGdGOEdqMjVrclNZVzBHNHFjeHRaSjd4MTlPemg1MGdGU2x0ZWty?= =?utf-8?B?RDBsTXRmQVhWd3JiaGlxVU1ITE5VRVZyQlYwMnJGVUFTVzFoZWhibXpqT1V3?= =?utf-8?B?Y2pkYUExTWhIZ2VKNVNvRGZKdDNVWmdrM3VVcWVWSkZ3bWtSd0N5TmNKV2I2?= =?utf-8?B?SjlCaVdIYjlXcU1YTHJvdDlKUjRCbHVoU3Bja2hDTFJTZ0R4OXRqUEVxdHBI?= =?utf-8?B?R21uMm5wRnB3VWVoUlZhMDlaYTJuOVRtbzBIUlY5N3VyaUlWS1dMeVhQN09m?= =?utf-8?B?bjBwSEdxRnFIZDZkd2NvNmZScHJwQVJoZk5XcUptTnoxKy9ZVUpsVldGOHVE?= =?utf-8?B?WTRiSFFyNythTDcrQlB0aWx2d2Noa3RYc1dINnZXTmF6TkJxZkFOMlo5dHM5?= =?utf-8?B?aTE5ek9MYWRaN09MM0IzblljbTlnTHdmVksrQzNRengxSFFRUlQ5Z3dJRHBw?= =?utf-8?B?WDFtK0VvZEhDVU9Pa1hFWWVKNXN4cW9iV2ZmZUVXcVB5c2ZwZjJyVmZNNkp3?= =?utf-8?B?MkpNOHNSU1ZnT0ZkVmprUGhuTjU0WTVUdE5PTG9Mc1B4R3Q5NHRmWjI0QzNo?= =?utf-8?B?cXBkUDdJWlVSUVJqNU1YODdzbFVzc3NTeGc2bVlCRnFVS05EYTVTdzBaYXJr?= =?utf-8?Q?K6nUcPJdiqcmxABu0wtB009FL?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d2831f5-099b-4035-1405-08dabe701b59 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 14:23:13.2189 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: btSEP/TdS6ViwvNQzy7T6T3qutnwb4vU2L0tdaJCDrMRqnyaaE5eeh7pkYVPIL5KbxdnN6m1A3N9NQ5a2CTaiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6515 The current reporting of the hardware assisted APIC options is done by checking "virtualize APIC accesses" which is not very helpful, as that feature doesn't avoid a vmexit, instead it does provide some help in order to detect APIC MMIO accesses in vmexit processing. Repurpose the current reporting of xAPIC assistance to instead report such feature as present when there's support for "TPR shadow" and "APIC register virtualization" because in that case some xAPIC MMIO register accesses are handled directly by the hardware, without requiring a vmexit. For symetry also change assisted x2APIC reporting to require "virtualize x2APIC mode" and "APIC register virtualization", dropping the option to also be reported when "virtual interrupt delivery" is available. Presence of the "virtual interrupt delivery" feature will be reported using a different option. Signed-off-by: Roger Pau Monné --- I find the logic in vmx_vlapic_msr_changed() hard to follow, but I don't want to rewrite the function logic at this point. --- xen/arch/x86/hvm/viridian/viridian.c | 2 +- xen/arch/x86/hvm/vmx/vmcs.c | 8 ++++---- xen/arch/x86/hvm/vmx/vmx.c | 25 ++++++++++++++++++------- xen/arch/x86/traps.c | 4 +--- 4 files changed, 24 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c index c4fa0a8b32..bafd8e90de 100644 --- a/xen/arch/x86/hvm/viridian/viridian.c +++ b/xen/arch/x86/hvm/viridian/viridian.c @@ -201,7 +201,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, * Suggest x2APIC mode by default, unless xAPIC registers are hardware * virtualized and x2APIC ones aren't. */ - if ( !cpu_has_vmx_apic_reg_virt || cpu_has_vmx_virtualize_x2apic_mode ) + if ( !has_assisted_xapic(d) || has_assisted_x2apic(d) ) res->a |= CPUID4A_MSR_BASED_APIC; if ( viridian_feature_mask(d) & HVMPV_hcall_ipi ) res->a |= CPUID4A_SYNTHETIC_CLUSTER_IPI; diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index a1aca1ec04..7bb96e1a8e 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1136,7 +1136,7 @@ static int construct_vmcs(struct vcpu *v) if ( !has_assisted_xapic(d) ) v->arch.hvm.vmx.secondary_exec_control &= - ~SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; + ~SECONDARY_EXEC_APIC_REGISTER_VIRT; if ( cpu_has_vmx_secondary_exec_control ) __vmwrite(SECONDARY_VM_EXEC_CONTROL, @@ -2156,10 +2156,10 @@ int __init vmx_vmcs_init(void) if ( !ret ) { /* Check whether hardware supports accelerated xapic and x2apic. */ - assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses; + assisted_xapic_available = cpu_has_vmx_tpr_shadow && + cpu_has_vmx_apic_reg_virt; assisted_x2apic_available = cpu_has_vmx_virtualize_x2apic_mode && - (cpu_has_vmx_apic_reg_virt || - cpu_has_vmx_virtual_intr_delivery); + cpu_has_vmx_apic_reg_virt; register_keyhandler('v', vmcs_dump, "dump VT-x VMCSs", 1); } diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index e624b415c9..bf0fe3355c 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3405,25 +3405,29 @@ static void vmx_install_vlapic_mapping(struct vcpu *v) void vmx_vlapic_msr_changed(struct vcpu *v) { + bool virtualize_x2apic_mode = has_assisted_x2apic(v->domain) || + (cpu_has_vmx_virtualize_x2apic_mode && + cpu_has_vmx_virtual_intr_delivery); struct vlapic *vlapic = vcpu_vlapic(v); unsigned int msr; - if ( !has_assisted_xapic(v->domain) && - !has_assisted_x2apic(v->domain) ) + if ( !cpu_has_vmx_virtualize_apic_accesses && + !virtualize_x2apic_mode ) return; vmx_vmcs_enter(v); v->arch.hvm.vmx.secondary_exec_control &= ~(SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES | - SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE); + SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE | + SECONDARY_EXEC_APIC_REGISTER_VIRT); if ( !vlapic_hw_disabled(vlapic) && (vlapic_base_address(vlapic) == APIC_DEFAULT_PHYS_BASE) ) { - if ( has_assisted_x2apic(v->domain) && vlapic_x2apic_mode(vlapic) ) + if ( virtualize_x2apic_mode && vlapic_x2apic_mode(vlapic) ) { v->arch.hvm.vmx.secondary_exec_control |= SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE; - if ( cpu_has_vmx_apic_reg_virt ) + if ( has_assisted_x2apic(v->domain) ) { for ( msr = MSR_X2APIC_FIRST; msr <= MSR_X2APIC_LAST; msr++ ) @@ -3432,6 +3436,10 @@ void vmx_vlapic_msr_changed(struct vcpu *v) vmx_set_msr_intercept(v, MSR_X2APIC_PPR, VMX_MSR_R); vmx_set_msr_intercept(v, MSR_X2APIC_TMICT, VMX_MSR_R); vmx_set_msr_intercept(v, MSR_X2APIC_TMCCT, VMX_MSR_R); + + v->arch.hvm.vmx.secondary_exec_control |= + SECONDARY_EXEC_APIC_REGISTER_VIRT; + } if ( cpu_has_vmx_virtual_intr_delivery ) { @@ -3440,9 +3448,12 @@ void vmx_vlapic_msr_changed(struct vcpu *v) vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, VMX_MSR_W); } } - else if ( has_assisted_xapic(v->domain) ) + else if ( vlapic_xapic_mode(vlapic) ) v->arch.hvm.vmx.secondary_exec_control |= - SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; + (cpu_has_vmx_virtualize_apic_accesses ? + SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES : 0) | + (has_assisted_xapic(v->domain) ? + SECONDARY_EXEC_APIC_REGISTER_VIRT : 0); } if ( !(v->arch.hvm.vmx.secondary_exec_control & SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE) ) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 7207390118..5c0aabe8a3 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1124,8 +1124,7 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, if ( !is_hvm_domain(d) || subleaf != 0 ) break; - if ( cpu_has_vmx_apic_reg_virt && - has_assisted_xapic(d) ) + if ( has_assisted_xapic(d) ) res->a |= XEN_HVM_CPUID_APIC_ACCESS_VIRT; /* @@ -1135,7 +1134,6 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, * vmx_vlapic_msr_changed()). */ if ( has_assisted_x2apic(d) && - cpu_has_vmx_apic_reg_virt && cpu_has_vmx_virtual_intr_delivery ) res->a |= XEN_HVM_CPUID_X2APIC_VIRT; -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 14:23:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 14:23:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437605.692056 (Exim 4.92) (envelope-from ) id 1oqxbL-0004GM-UE; Fri, 04 Nov 2022 14:23:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437605.692056; Fri, 04 Nov 2022 14:23:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqxbL-0004E9-PG; Fri, 04 Nov 2022 14:23:19 +0000 Received: by outflank-mailman (input) for mailman id 437605; Fri, 04 Nov 2022 14:23:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqxbL-00047l-1Y for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 14:23:19 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 388129ab-5c4c-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 15:23:17 +0100 (CET) Received: from mail-dm6nam11lp2173.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Nov 2022 10:23:08 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6515.namprd03.prod.outlook.com (2603:10b6:806:1c6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 14:23:03 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 14:23:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 388129ab-5c4c-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667571797; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=QGCkcVnG/NI9RAEeRDXnzxwkn0vXfi6vNsr+1YpUetE=; b=DquVKi2JHNPvRGqgGBhUxGizvsV6nR/+qxooL+j5YoQcM3G3rkGhyW7O LbKau8iyCL2ppKUFvGM8baoVpDxx7kZBWS32KmMIcSjiPNiQxi2s9cp+p r9443muN0xYFGwYYJnZoQ4hkpWiaqzGjtMRL1nRX1OHyi1IBl7GhH9Jyr 8=; X-IronPort-RemoteIP: 104.47.57.173 X-IronPort-MID: 83265212 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kyOMC60IqQj3+2mJPvbD5SRwkn2cJEfYwER7XKvMYLTBsI5bpz0Gz GsZUWCFPvvcamWjKosnYI23oEkPvJTXmoJqSwNtpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVmOagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfKGtV9 MAdMGo3fx3TgMa5/raBZMZzv5F2RCXrFNt3VnBI6xj8VK9jbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvC6Kk1cZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r83bWRwHmiAur+EpWy+f9KhFSiz1AzERhISxi54qa+hV6hDoc3x 0s8v3BGQbIJ3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsbjNHcs1gi8YwShQjz FrPlNTsbRR3uaCRYWKQ8PGTtzzaETcRBX8PY2kDVwRty9vprZw3jxnPZs1+C6PzhdrwcRny3 jbMqiE9jrcSiMcj1qOn8FSBiDWpzrDKQxA04EPLX2ujxgJ/eIOhIYev7DDmAe1oKY+YShyNu SYCks3HteQWV8jSz2qKXfkHG6yv67CdKjrAjFVzHp4nsTOw53qkeoMW6zZ7TKt0Dvs5lfbSS Be7kWtsCFV7ZRNGsYcfj1qNNvkX IronPort-HdrOrdr: A9a23:a1/x/6HNxJTIUVk7pLqFDpHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LK90c67MAvhHP9OkPAs1NKZMDUO11HYSL2KgbGD/9SCIVyCygci79 YGT0EWMrSZYzlHZK7BkXOF+r0bsby6Gc6T9ITjJyAHd3AQV0gs1XYPNu7deXcGNTVuNN4cLt 6x98BHrz2vdTA+adm6PGAMW6zmq8fQnJzrTBYaD1p/gTP+xA+A2frfKVy1zx0eWzRAzfML9n XEqRXw4uGGv+ugwhHR+mfP59B9mcfnyPFEGMuQ4/JlXAnEu0KNXsBMSreCtDc6rKWG70srqs DFp1MaM8F6+xrqDxOIiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ8e1U4e Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh57D3xHklX6voIRiKprzOSI JVfYDhDbdtABinhknizyVSKIfGZAVyIv+EKnJyyfB9nQIm30yR9HFouvD3rk1wiK7VdKM0mN gsSp4Y8o2mbvVmGJ6VV91xNfefOyjqfS/mFl60DBDOKJwnUki926Ifpo9FrN2XRA== X-IronPort-AV: E=Sophos;i="5.96,137,1665460800"; d="scan'208";a="83265212" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yu502h4sGqGLqfbxHai5Gw/1v13i6xqSm3NmL8kd3iMN6k2v9fNAK9OaXnrduOoxVVlT2I8A/DHXiUHnf3o0eeujhct2eAK4pw9yV/nsNS57MJ/dlD8Y2sBOhVTdtrao4SUzOZ4/Gvm6mCPqpPPhZAzubl42E9kfeMXBrl5hPR8DuQK1Q2hUKeZgl8it/kAiL9oV/sPY3bXM1ocxrpt+4aFYCQNFSvW+ZVva2DjPrQ5ln+qZ+ghCz0aaI2vp5vvxdTGlxU8+VBA/7IIJg8CIKWkTBIBgkpAv63OEhZRNee7ev7FA9d2LGTR1lkcYRk7VZYtGkA9XmuJyKmESwVLPSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U5FcoykpRdaBEJbDlbJSB5pw20ep6imNx6ZZTjFvKdk=; b=ZIkNlDOUUWd+51Y4kBsFEH5DwbrLFt72tfMJKVrvpV+rSMnpRTunZ/PzYKLln5xF+FrUvCqQ2shCw392zTSALUBopM5xS3SMY9/LNfVXva+nC7VyWLriOwDSZRhjxfpWnxnK9j5mkq2amnCUB8vrgfC1LfbU/lvkgiF2RWNyJgJVpac4bfPmf988t2kceJNlALm81+9uUKvll3eoLbi9ryoSpMkisf9u8eZdew0zkgAk/uNHA3rF3eU5OVYqiBfH+b9EY8TQzoNaqGe2aTZWtpvHKgTH3kJ6aIjflB9d6FS3nTlA775gHMBwAPr6o5u87kw9CbodghzxEfnGTUVWgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U5FcoykpRdaBEJbDlbJSB5pw20ep6imNx6ZZTjFvKdk=; b=nRemdBN3atvG29DPIXoiZ8Pprm+jgEhhC80qDSeuNL2u/bVGgtKrC8udcB69NJ1sSvbYtbMkAH0OH4NlzOhFhSRJYcEQqlPLx6lGRhvMyKL24TVnvPMBCHFGrBBWOLDMk75cKpQMZU4SxPHT6OWv2nY6b5gk2NSvGWDmLGtBQPE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Roger Pau Monne , Paul Durrant , Wei Liu , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian Subject: [PATCH for-4.17 0/2] vapic: followup from assisted APIC series Date: Fri, 4 Nov 2022 15:22:33 +0100 Message-Id: <20221104142235.36556-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0054.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::23) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6515:EE_ X-MS-Office365-Filtering-Correlation-Id: 1bf0201f-d91b-4f29-f2de-08dabe701553 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hCcf+hTx5o0dMIScUYj1mYTvyZ6s5aMqZUjKns+c4eXiZY5uYu8fY59+RJMZoeftWOfYS3+d7aUNpLwy+6zD5Wlj5mnRM0fGJ/6tVU74YiVWIf0BXRX7D7lupfdv2NWnBBiKGpr6oHYnyOUmoU/t0z14ZrUQvKAvSGpCaImKy4YByR6Ae4FCl+TvJujtI5eaCRd4/x8tfuaijq1lHBJybV8aYmpxmTrV1Mah3L74LjpjkbNcVUEcUgTVH1ZaVyXCfEDDhfDZY0qUxl13mzeU5mX8b51PeAdcWylyKldl8s/O7h5k0gC/fVF/P9I406c/jDOlPc7sIxvaGQ53YkG2pEPknFffnf7DMyjMcvfiFcrbysjBiz+vmcs+yw73MMuelLUGw3NQAaUK3ILnLQe8xqE9HU+Z57OlsO9kSSIOxqek2UTP9gNVJzX8oNZDIiM2CiwYhSpMlYhv0Lro5wAHZSzzmqJZ8SvN6RN2v7MQihyxnCqgphQe5FOv3pvOzyy+U/Yo7QWrYEvIaclThGfREt6jDzHYhdkScfTk74Gjr5EtHm6xwzXhgp5qzY9v4WKvdYYUDCnb65qqdZr2t70lh7ammGLpQ5QF0UiGH0WK06SCByb9vx5H2Zj1ohpRTD2GSNdsVyJu53K2Ig6xplrcAPd0kA6eIEW3Oyql4vR+jmEWcfHWbmTkUTvGjMRhK0fU4VR+Ic3Mdh4079LLPUriuQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(451199015)(5660300002)(82960400001)(38100700002)(4744005)(66476007)(66556008)(66946007)(4326008)(316002)(8676002)(8936002)(54906003)(6916009)(41300700001)(36756003)(2906002)(6506007)(26005)(6512007)(6666004)(186003)(478600001)(6486002)(2616005)(83380400001)(1076003)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1V1NG16RmZDYVMrMzNjanBXUm13SVJldWdaYThxWWFvUnRhMEJURlFlRVdu?= =?utf-8?B?L25Gd0VOVkc0NEtrd01hNFBtbG5KNVQxSnZkd2IvL2k1Y0FEb05TZzlmaGdn?= =?utf-8?B?WEw1Qk16NjhncUFoODVyVnBhV0F0ZThyWXZrNlFKbDVvOXlrUXNhMXN3cVRY?= =?utf-8?B?a0lNaXdqYWlxd3JtU25kaytCMTZpdEkvakppVk1HdUR4d2ZEQVA1bWhmUHRQ?= =?utf-8?B?VkhNbGhSSHlDRjJqcEVKM3FUWEszT0h1UmFGTmtUK1N3S1NvdG5GaWtmR0ti?= =?utf-8?B?YXFTOVhmOTQ3Tm1CQzh3TUJweHFiTGw2QUcwd1lyNmFkaGtOWVZBcjF4V1Fm?= =?utf-8?B?OTdYUDlvMzhINFZDN3VIYXF1aTJiRUxUY2lVaEZSZG8vZTlLOXFGV0E3VTVw?= =?utf-8?B?dVFITmhUY0hxSzNqU0JxOVk2QkZoU09nT0xqZWl4YWIxWWN4cGRkdEtleHNp?= =?utf-8?B?bmV5angvOTk3SjRkOUpJR0pwK2R1dHkvVU1wOE96YklDVzhNWHV3TlgxTUNz?= =?utf-8?B?RDZ1S3JjS3FOQmd0RjE2dHpBenh6ekJmcFBlQ3RDVlRySHQ0UDBwSDdUelA3?= =?utf-8?B?aEhrMGRQbFg1eHNlZWY4U0FEdjZ6M1JheTRFU2ZzTW9OeFp1UkprcnBzUXBy?= =?utf-8?B?djIyVTV1THBJaTJSZG9Relk2N2Z0THBLL080NVAvcnV6aHNpNnlqSGlYUUdF?= =?utf-8?B?eHlOUUhzRUg1ZFcwM1RpUjE0bWR3QS9qVFgrRlRkSFh5dnc0NlJvbWpXbUx2?= =?utf-8?B?dUVqMEJmZ25Wc1NPSFprN0E5cmdkSnZLVzBlYThOVENmOVZDcXI1TmdSeXo2?= =?utf-8?B?bVU0U3dFL0lyQnFST2xsV0RrMWppdUcxTnhyb1l2VTZTaStHcTR5RUZqOEVB?= =?utf-8?B?RHNVOFkyUEN1cThuYWJ0dDNDWFVmZmFWcXRJcjJacXkwY0k4S1hBbWtXQ0Qy?= =?utf-8?B?dUFzZHQvRTlSNkNjSXRHdFlZOTlEUnVGRHRKOWdacnVtTFZCSHJPRjFHRXdt?= =?utf-8?B?eTlybnNWUUozM1dqa1k2MU1lVEVsQ1gyb2FjLy96NndiQUxuMXlRTWJmbVVM?= =?utf-8?B?ZFVVa29FUms3cGFocmlWS2NlSklDb0JvbEpJWVNSdHVkK25jYTdCdFpvOHFo?= =?utf-8?B?Zm5icDREZ0llTVhHVXJNd0I1Mkk4TlRveEhnOGlrTGtCMzJ4VXQrQUlDL2JQ?= =?utf-8?B?SXZyQzlXMGpsUlhaaTEyUWwxVjNEaEFPZG4reUlXaTVMV29Ubll4RExxbWhs?= =?utf-8?B?UVF5dUJ1djRMUGVqejhGYTNJN1dyNWdWWXJ5KzBMZUxkYjZiN0k2UGdZQ1E3?= =?utf-8?B?Wlc2WTVWcDM2TmEyTkJhUFVrWHFHZVIyd0Z4V1p4QzB4QS9GYlorS0Mrblhl?= =?utf-8?B?UEQzeTcxa1FRcDJCL3JvUmZtR1ptVFhXN0FiT1NFRFdKWHdXSGRjeXVoTlE0?= =?utf-8?B?ZkJsc2tIMUxESjBSUHZYcGI0aEFZaHZ4cDRKakJOcnRJM0JTeDBsY09lOU5P?= =?utf-8?B?K2dzVm84WXRRWGNkbVBmclpyLzhONXUrWm1ERisvalFKYnZrRlZ4RkFMTDgv?= =?utf-8?B?WlFYeXZ3VFZSMWZ0MDV2aWVYenpTZEJjWTk0YzRkUDM5ZzVNU3NmWWc4S0hL?= =?utf-8?B?b21uVVFJeE81SEJtaDhOOHZqcjBwYjJjN3dtNjNEenFyU0l4MlQ5QUFCRUV5?= =?utf-8?B?bURFZHk4NnBQN3FUSm1GWTlseVhEL1JINmNLaGc5bktxUHkrdlh1aTJ5Ukxi?= =?utf-8?B?RThsY2xIdkZiclVrV3BYbGxFU3BHT0RDdkhsNlhkMUsyem50dGJVUlN3eXha?= =?utf-8?B?dmhRV3hudUZLVzl2UTIyMTBSWDdhbzJIZHFtaVF1RnN5VHBSdlBJdnc0cFYr?= =?utf-8?B?MFBjMW1tamtnaVZEOVdoM0w2czd0a0F5NWtLaUZGeEpQbGp0SWUwemFpcVZW?= =?utf-8?B?Q2hSdlNuYUVBVStZUHFWaVp0RzNFNVM0QmhnWmlnZW5HdHhER3VSNzgxNjA1?= =?utf-8?B?b2tvTlZhMHEvK0c2YjlNa3JTSmMzbEpuRkE4SjF2d3FDM0s5ZDNFZXRGZlFi?= =?utf-8?B?L1g3eEdBek1GMkttUDlCOGlYNU9uWTArZUx5RzRGSzhTVzhyKzA1VlpGTTdI?= =?utf-8?Q?VX5u0mGft9bNRIDSAUyu8VM3X?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bf0201f-d91b-4f29-f2de-08dabe701553 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 14:23:03.4470 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4Tcd05pH80sQZiu7TlwPvUQ6GP3r7SgwH2+Nrkohz1QWPTraIb4F6syEYYKUsUTb+0Si6YWoqVmNPr28DZLVxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6515 Hello, Patch 1 is a plain bugfix for a feature we expose in viridian, which is kind of unrelated to the series but patch 2 in its current form depends on it. Patch 2 is the actual meat and changes which features get reported as part of the x{2,}APIC assist flag. This is an attempt to repurpose the flags so we don't release a version of Xen with a set of flags that we will then either remove or use to report different hardware features. Thanks, Roger. Roger Pau Monne (2): viridian: suggest MSR APIC accesses if MSR accesses are accelerated hvm/apic: repurpose the reporting of the APIC assist options xen/arch/x86/hvm/viridian/viridian.c | 6 +++++- xen/arch/x86/hvm/vmx/vmcs.c | 8 ++++---- xen/arch/x86/hvm/vmx/vmx.c | 25 ++++++++++++++++++------- xen/arch/x86/traps.c | 4 +--- 4 files changed, 28 insertions(+), 15 deletions(-) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 14:23:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 14:23:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437603.692039 (Exim 4.92) (envelope-from ) id 1oqxbJ-0003se-6o; Fri, 04 Nov 2022 14:23:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437603.692039; Fri, 04 Nov 2022 14:23:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqxbJ-0003sX-3g; Fri, 04 Nov 2022 14:23:17 +0000 Received: by outflank-mailman (input) for mailman id 437603; Fri, 04 Nov 2022 14:23:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqxbH-0003sR-MS for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 14:23:15 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 363ca381-5c4c-11ed-8fd1-01056ac49cbb; Fri, 04 Nov 2022 15:23:13 +0100 (CET) Received: from mail-mw2nam12lp2040.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Nov 2022 10:23:10 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6515.namprd03.prod.outlook.com (2603:10b6:806:1c6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 14:23:08 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 14:23:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 363ca381-5c4c-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667571793; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=jm+WktHEAe9juee6Ae1iGK2iCs5BKtmxCfe43jNjjjk=; b=UQcerZNo6WY0+B9bsfwmSybO7QmU84vNPmAeNE+kEJ61n89NneMyHWnw oAwxUkMKVvmTgYUXXcLFdQm4V8FwuNTKLTxJqLddwi0tLu9Gq4YHoRYjf ysTquQIO58K2bOO34Ji5tMHWHwh3F6RmaO/NPN6O4cFLhr/0ICqjKIMh2 I=; X-IronPort-RemoteIP: 104.47.66.40 X-IronPort-MID: 84179917 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:RTebxKqioU2uG/e2fNBGV52O0iVeBmLeZBIvgKrLsJaIsI4StFCzt garIBnVPveNajamf9h3Pdng8kIC7ZfUn9UxSwBkqy83Qy8R9JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzyVNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAC8kPwqZgc64+q+AdtFH1/klK/fAJZxK7xmMzRmBZRonabbqZvyQoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3juarbIK9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAurBNtNRezhqZaGhnW463IjJhY0VmKCjt+h1VP9Vo4BK U09r39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOlMIwXy1s6 VaPkPvgHzkpu7qQIVqF/6qQhSO/P24SN2BqTTAAZRsI5Z/kuo5bphDFQ8tnEaW1psboAjy2y DePxBXSnJ0WhM8PkqCkp1bOhmv2ooCTFlJtoALKQmii8wV1Ipa/YJCl4kTa6vAGK5uFSl6Gv z4PnM32AP0yMKxhXRelGI0ldIxFLd7cWNEAqTaDx6Ucygk= IronPort-HdrOrdr: A9a23:N64WV6+O+fZektSfrZRuk+FDdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwWpVoJkmsj6KdgLNhRotKOTOLhILGFvAH0WKP+V3d8mjFh5dgPM RbAtdD4aPLfD9HZK/BiWHXcurIguP3iJxA7d2us0uFJjsaDp2IgT0JaTpyRSZNNXR77NcCZe yhz/sCgwDlVWUcb8y9CHVAd+/fp+fTnJajRRIdHRYo5CSHkDvtsdfBYlCl9yZbdwkK7aYp8G DDnQC8zqK/s8ujwhuZ82PI9ZxZlPbo19MGLs2Rjco+LCnql2+TFc1ccozHmApwjPCk6V4snt WJixA8P/5r43eURW2xqQuF4XiU7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twri6knqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYdo99RrBmc4a+d RVfYDhDK48SyLbU5mZhBgk/DWUZAV9Iv/cKXJy+fB80FBt7QJEJgUjtY4id0w7heIAoql/lp r525tT5cBzp7ctHMRA7cc6ML+K4z/2MGXxGVPXB2jbP4c6HF+Ig6LLwdwOlZKXkdozvdAPpK g= X-IronPort-AV: E=Sophos;i="5.96,137,1665460800"; d="scan'208";a="84179917" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cv/VklMqqYlPnlXnYlapC0c6Rb29DQltCHqSyCvklvOdd2FCpUgOyg6NrUff4MMBTTjD27O/q9+L9MkXNd5fewFnNKYZWFZ1ICSulA2jlTggSGzTLB1C+1IaPisQDTwam+4VswxThfwff2bbIftIbbdkg3eHx5W4F1RUX2ZsIeX4i+lbTwWiY9EZjDXGQTQXT8bYG/EBmeE8a3W1vsyjMhLzuGCC80fKc6ydPjpQScSIqTjT80keESsBhyWL2rCJDzzx4EO5axcoekKvJz3yI91TRI+vSC+QODVShfoTgk5eNDWQ30hLzBlOcTEVWroF/TEq6pnZupAb/hP4MK1gKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5+aUh139xPDENw+O/ZnONlv8URjchfq7wyKCH+pV9NQ=; b=REZX6Luv5sNr9HiUUvOto8ffkmCCNSOuv15OI+5KSbhjRhVoPeci4UZkMRdxm1qiWyKj2KIv90Cy/JcpXmDZR2qnHxyxoJBXaKbNOYYHCCjjjPZUYWGoVoB3k8YTnhGiNYVwh7g7PlBJOKhtVME+lmu0tU/EQ7BtA0xgX8E3yT1UjwtFrS0fIU9p7lgKzqJOwD2FBeXYn/WDMQDroJFNPUvtDHSneQKsgDk+vV+t98TP7I89uIJk5KdCxQZ4+Hq9R2uKRgYehL+4UZ5fgThgJiDft861FGw+q5WsMSiF0cPk6yC23ZJB3mOquqT0+XWmT/e5qK2pNiZDYZa34Z0CvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5+aUh139xPDENw+O/ZnONlv8URjchfq7wyKCH+pV9NQ=; b=SxAWIWRFBxLHn/hMfwwrifzAueEAhcdhIhlqwgcBpW1BxaiUyCI8Uqe1wYHJ3mxEYYH7RpyenJx0qXboJ5r4N0QHnfGv8y4ilSPuwpgMf/91gaumbpim7jOPsyHdv5fRBaF0ehAc2OmpyUxU9QsF+5u1FiUj1kV9UVed3VZy24Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Roger Pau Monne , Paul Durrant , Wei Liu , Jan Beulich , Andrew Cooper Subject: [PATCH for-4.17 1/2] viridian: suggest MSR APIC accesses if MSR accesses are accelerated Date: Fri, 4 Nov 2022 15:22:34 +0100 Message-Id: <20221104142235.36556-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221104142235.36556-1-roger.pau@citrix.com> References: <20221104142235.36556-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0391.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::19) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6515:EE_ X-MS-Office365-Filtering-Correlation-Id: 1588a87b-915b-4e25-1e52-08dabe70187a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AVy9LN+tpdd7yVe7pwZzWUQzuh/H2ZbpXbgKDJeYkhbnranbLJ2R0fMjkV4yOQu38Z3wZ+iYShlIsQ186vhE91cLXRxCDN2VzgDqCjNnuTARY6FbMK0jE6kiYmU8TK50VdE+Q5ver1zdkn1V550j/069OmeIqUtyCd/1SioV7ZJtjUxifsIcycCHULJ2Jj93MdgR5nKhCw5TZXRqKWasYBCkUD0GVhRfH1/dJ8Yrx77RQssrG9S7MtGPS7a/l5O24krghE3DJmig7hq6oXh2GvfBnxTYqL8tpWFOBzT1MRwgGiHdEm0ztrSP/A+/w0IBgIXWIbBW1fxqPndh3N6EgjG81GhEDoMicZCsFRrZBPHHkNDhEH00ZtJEOs894Z3xjGXzsLeWOKJbeWx2ynef2Mutp8h+Lwe9ZrZOO7N7lFWiBY/cXQgJAxsb6YbsSk3CfXctsOKRbbdkPsQN3++j9+FDdoLJJrFIIhysTwjB723RN9Jh/MH1eG7WCVAoU6IOVGnIxT3v8LyBMdEIDNJjgvCZgk57xaCyxKEKO4r2+fD3strKMTEqOx2wV/NI7zelw4AsiMjOEd2+7AHxlz2FdJKqVOYt5SL+r86/mEK3OiX9wG15LSaggS6UKLS+uYMpHL/fUd6CPXzBFdJi25xXRRGf0aQBDWbcHVtPOMiRfHvP42kObVPOx2gkOfdEnP1gql8CTu3ilX36r4rgZ4kz/g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(451199015)(5660300002)(82960400001)(38100700002)(66476007)(66556008)(66946007)(4326008)(316002)(8676002)(8936002)(54906003)(6916009)(41300700001)(36756003)(2906002)(6506007)(26005)(6512007)(6666004)(186003)(107886003)(478600001)(6486002)(2616005)(83380400001)(1076003)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlJkMjM5OEJ5VnM3S3NmT0QxQkJLcHJVWGVGYTMvZkxhbnE2UnZXL3BFNmJa?= =?utf-8?B?UWJLdWJsSlhlYk9pbks5c2tXRGhEVldNOE95VWcyUlluVDltdVJraGpiQTE5?= =?utf-8?B?bGFpaU1JeXZSdFljeFRMSVR6SkZ4M3ZkT082RFBvOUJnUk5EL2xoSkxSRGNC?= =?utf-8?B?YVdWN2xtaDRGRzZyN3J0SzJtd3JGUklNWldXOTJ0VFJTUXpWYVBENXBZenMy?= =?utf-8?B?Ym0ycUE0dkNRamg1UmVSTlEydEthcUViaDZvYUZDU25iNmxwSGx3K1pLTGgw?= =?utf-8?B?WmUvc3FrTytKZm5IU1pRd1BOcEdDRzdEVGZBVmtHREloNFVzUG5NTEc4ejdr?= =?utf-8?B?N3NiOU1FNnpSeFlSZmo1NnRYelo0SittYmc4VXlIdnBGNVlIOVBYTFBqSytw?= =?utf-8?B?SElBK09JQTdUc3NzUDRveE5UL0VzcWJJYlJOUHlRODBkRlZoSVJwNXE1dXBC?= =?utf-8?B?MXNUa2ZpZ3M5cnhycjdSUGlpdGhyZEtIQVI2eGZiWE93b0RBb2kvYW1Xa2V5?= =?utf-8?B?T0NybnNsaFg0T0ZScWpkbHpxekRMb054TTZVYXduWDhjd0pUenR1Yldrc05s?= =?utf-8?B?QmZuenIrS21YaGRBMGJLcFF3ck8xZEFwbEFrMVlHak5GY1R0WEtJQTdGMkFO?= =?utf-8?B?RnVNZmIyaVhJRkRVYUFRU3pKZWZkTkM1c3FyMlFPQ1VGNldMekJPL2xPUUJP?= =?utf-8?B?a2tUdkJUQWgxZkt5Nm5ZZVJLdkF6L2RRVlVycmx1MnNTN3pzelE0S3M2R0Jo?= =?utf-8?B?bVJpRTg2QlRyL0FkSi9SK2Z2dzZydHZJenRTVmRGL01ZQWVBWktGSTBRNitQ?= =?utf-8?B?OWhyMFhwUTBjVEY0UlZwM2VPNzlqcUVaN28rdkJ3UkZaY0FZdWdaK3BXOXhr?= =?utf-8?B?QzVCMWh4Ti9nYVgzQzVBZEcweGlmQzhwcTBPL2VTQXRaQVZoUmd5RG5XM3pt?= =?utf-8?B?RzVTWUJSZTJlRk5ibVNlVU1KdEFMRHBCK3FJUEcxOXpDVzJKbXJkcnBFQWhx?= =?utf-8?B?NVk1Uk1wR2VLeUJlMkpydEd6RmZLRk5uNk9lTUxRNnpmdFZaWDlmeXZwblha?= =?utf-8?B?RkFaN2ErZjRROWc5akVSRjQ4aTFQZEhoQTBKNWxDdk56a1JueC9DNFoxeThk?= =?utf-8?B?S0xqeHVmNG00S1V1Sk1vNGU4Vmlld0hjNXdBbkdSeDk3cXBId3VDUzFVYlVx?= =?utf-8?B?ZCtOeE5hS0x3ZlcwY09ob3RvcVRpQVQvWW1IVXRsdnBBVytLbm5melYvcmM1?= =?utf-8?B?WjRVOWMvcFdCQTJEVm5MdXQvSmZJTHZiN3JiVVpaSXpkcFRrTTlxWUgzK3Jl?= =?utf-8?B?L1lKekUxSzlBbDRMTjZ4NG5JRmY0a3E1bDBTQWthM1dJSkdlRU56NTNuNkpl?= =?utf-8?B?eEhRK25IckRlbXlTRUhrd2RGKzF1WjZxeTF2bjNFSEhTc0lKUTVUS2VtSjR6?= =?utf-8?B?MHpnZWloRG5kM1R1QXJMckMzUlN2TlorcCswd3BKTHNqN3pEVnBRZ0pyejVP?= =?utf-8?B?MTlPY2tNUTgxLzB3QTJ0cVBhWGRMaFlwaEIwKzZsNkxuU2UwOVJUSEFHRG1D?= =?utf-8?B?TXNCRFpiZEpVL09pUUk1UTBQMWpTMnhLODIzdlVNM1NuSDR1OWM4TzlsSlEy?= =?utf-8?B?NTNBR0FKRXptRjkrT0JIVGtCVVJ2ZXg2N0dESjd6alI4MWptb29INTFmVkxJ?= =?utf-8?B?MFFYVklrWHFDaW9haVZnS2NwRjFsYk9tVGRMbFo2d0N2QTZsRG1aNDEzM0lZ?= =?utf-8?B?ckZTODFZNUg3emRmenpraEZKSnJWTUhPNGE2aDJzY2tueXNFUnFyb1RiKzFZ?= =?utf-8?B?RUZCaFFlSm9WV21aeXJQMGNDSEJTRXlDMXVyMmR5RXRVNHNZUUZONFJGRVNj?= =?utf-8?B?ZmVKTndwejJnZkxFVGVCR3hNQmdacU1tL01GZmdxckxzWVJmaTBwTEh1Tjh5?= =?utf-8?B?VE1ucVdNYysyblZIMXBmVW1BYTUwZ2VMTjFrOXAvamxqTmNNblZQbmpwd1dE?= =?utf-8?B?Q1liUTRSOXBrMExFN1IyMGsybGY5Y2ZhbzlidXlsRFIxaWZFWndJa3lqdEZB?= =?utf-8?B?dUs4M2JYWUdZSUQyN0tLSUx1dmJXRys5T0t6d1UxZEp1dWp4UG5FZ2JuNnQr?= =?utf-8?Q?GfJZ2iOheJljfw1iSU6K9xZMk?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1588a87b-915b-4e25-1e52-08dabe70187a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 14:23:08.5117 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o2VKVCJuZD6aol+imHZt1vcZtKfz/3DPLKPRYuRHN0jrlQCa9U3Ic2AT5ATNlumsIdoKkN372eEr2U01wqcu5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6515 The "APIC register virtualization" Intel hardware feature applies to both MMIO or MSR APIC accesses depending on whether "virtualize x2APIC mode" is also available. As such also suggest MSR APIC accesses if both "APIC register virtualization" and "virtualize x2APIC mode" features are available. Fixes: 7f2e992b82 ('VMX/Viridian: suppress MSR-based APIC suggestion when having APIC-V') Signed-off-by: Roger Pau Monné --- xen/arch/x86/hvm/viridian/viridian.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c index 25dca93e8b..c4fa0a8b32 100644 --- a/xen/arch/x86/hvm/viridian/viridian.c +++ b/xen/arch/x86/hvm/viridian/viridian.c @@ -197,7 +197,11 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, res->a = CPUID4A_RELAX_TIMER_INT; if ( viridian_feature_mask(d) & HVMPV_hcall_remote_tlb_flush ) res->a |= CPUID4A_HCALL_REMOTE_TLB_FLUSH; - if ( !cpu_has_vmx_apic_reg_virt ) + /* + * Suggest x2APIC mode by default, unless xAPIC registers are hardware + * virtualized and x2APIC ones aren't. + */ + if ( !cpu_has_vmx_apic_reg_virt || cpu_has_vmx_virtualize_x2apic_mode ) res->a |= CPUID4A_MSR_BASED_APIC; if ( viridian_feature_mask(d) & HVMPV_hcall_ipi ) res->a |= CPUID4A_SYNTHETIC_CLUSTER_IPI; -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 14:44:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 14:44:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437645.692072 (Exim 4.92) (envelope-from ) id 1oqxvZ-0000ND-N1; Fri, 04 Nov 2022 14:44:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437645.692072; Fri, 04 Nov 2022 14:44:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqxvZ-0000N6-Jw; Fri, 04 Nov 2022 14:44:13 +0000 Received: by outflank-mailman (input) for mailman id 437645; Fri, 04 Nov 2022 14:44:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqxvY-0000N0-Bb for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 14:44:12 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 22bd160f-5c4f-11ed-8fd1-01056ac49cbb; Fri, 04 Nov 2022 15:44:09 +0100 (CET) Received: from mail-mw2nam04lp2174.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Nov 2022 10:43:57 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by PH0PR03MB6575.namprd03.prod.outlook.com (2603:10b6:510:b2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.23; Fri, 4 Nov 2022 14:43:52 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 14:43:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22bd160f-5c4f-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667573049; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=QCR3buhtKy1tgHuvtA2sxL3L+l3cY5M3jgQOD2py88A=; b=E/ipuZkbI9ORR0WUV3tjQuE8wYFinB2BCJspfC360I8kJxZZeyepFtkB ZSMsOw4W0WhIoPvlfxjW/yUb22eFlqLTD71RNoLbHGdXR2M5ZSOOC98Wr 1GVKueyXk/nFjy8JW9t7Jr7n3EOiZ3nXHlmrozaOBO5jsLfYy93bQIDG2 s=; X-IronPort-RemoteIP: 104.47.73.174 X-IronPort-MID: 83786073 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:X/eNJKJ2kcw+PooAFE+Rw5QlxSXFcZb7ZxGr2PjKsXjdYENSgWMEx 2oeXjqOPq6JY2D8fI1wPYnn/UpXvceBytRgTgFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wRiPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4pHEJp+ sYaAgoqcwrTiO3umInqEMxV05FLwMnDZOvzu1lG5BSBUbMDfsqGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VspTGMkGSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iL32b+RxXygMG4UPJG0pqRGgVCD/EwWGTMsfl6+md2yg3frDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAkQzhbeZoZvck5bTUw0 xmCmNaBONB0mLicSHbY86jOqzq3YXQRNTVbOnNCShYZ6d7+po11lgjIUttoDK+yiJvyBC30x DeJ6iM5gt3/kPI26klyxnif6xrEm3QDZlddCtn/No590j5EWQ== IronPort-HdrOrdr: A9a23:tNHUm6G1NBPMqjSkpLqFB5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LK90c67MAvhHP9OkPAs1NKZMDUO11HYSL2KgbGD/9SCIVyCygci79 YGT0EWMrSZYzlHZK7BkXOF+r0bsby6Gc6T9ITjJyAHd3AQV0gs1XYMNi+rVmlNACVWD5swE5 SRouJBujqbYHwSKuC2HGMMUeTvr8DC0MuOW29xOzcXrC21yR+44r/zFBaVmj8YTjN02L8ntU zIiRbw6KmPu+yyjjXcy2jQxZJLn8aJ8Ko1OOW8zuwubhn8gAehY4psH5WEoTAOuemqrG0nld Hdyi1QTPhb2jf0RCWYsBHt0w7v3HIF8Hn502KVhnPlvIjQWC86I9Apv/MSTjLpr24b+P1s2q NC2GyU87BNCwnboSj779/UEzl3i0uPp2Y4m+J7tQ0VbWInUs4ckWUjxjIbLH9ZdxiKprzPUd MeRP003cwmPG9zNBvizyhSKN/FZAVCIv7JeDlDhiWv6UkpoJlI9Tpl+CUhpAZ+yHtEcegj2w 3lCNUbqFgcdL5iUYtNQME8fOCQNkvhBTrxDUP6GyWXKEhAAQOFl6LK X-IronPort-AV: E=Sophos;i="5.96,137,1665460800"; d="scan'208";a="83786073" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ffUwnnoV64AnxV/txTOlINnlSfF/lvs8jv28FhQCW9egzp5w/tMsOrhLU7KRVD05Mo6o34t3y2Ys+qz6ZaB0cJxAwys2MdhI6ShW45x5nlC9Vz2PF+DDrSAWDPwbjL9UDQd18kyNaHcuxHP52BQ7fe4FownhkDVPBqSesNbLJJVV08hhUHxJkr3E7e03+IgRSF2d7ptcGHoA0i+T6MPwwpAgZBD8wEg0+J840Gq3ci6TqA8gY0W3C6TXLqiWP6hI6al7gGsCGxK0O58aXmNLo+xfgJNoEHJ000tpeLgpNLf2m7UDTfSzOnE4L4Hu9u3zNtbl34wqcHE+1ZfAoZBVlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HiTC3iBMMn5XknycOPDU2c+SpR5bWjbLEZclwPJqbxA=; b=WDmDvnAYomSoa/wqq1Ec0/4aCztlZ2qdj6/f4zj7MZ0kB0QLJaCyzTjSpK+Mf7QOg6rrf3oQXNy0dQSuEC/swB+TpTmhCSaNTQO9k6GjRNppXCXqascgzHFV+bQzO8e672/6stlONKjNttp2WPO+zMfXh/ShmA46A44yaaAy9sjx/wEMPc2SPKqKE5Ea8IQ+zyqOJzOMLDCn+bXrhTBofLeyFXy2fIVNY82nkvP2+VtpSVOWUOHMcazHI6OVMMYQ9IMRVdkNieHtwr322TtkNsvDN9PIwx8SWPRx4Nvi1gTmhu1k+jPZ0AgtzZtF4MwLl21Fy1ogwNvYF2qR/CzQMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HiTC3iBMMn5XknycOPDU2c+SpR5bWjbLEZclwPJqbxA=; b=sIaiZDxNHUEkyJiT9vI1zagxSKhOKip3HdrA7WzIwS+h9UbM8CRxchcbDYMMQySBbkeWXvqaWVoUTJExy78FnxdzXJnroooe+stLSYU39eYFvJ9wJ2DJr67PMqYbNaoZ2igZw1ClrpiqoPAHQ4mxCaSZtcpKF81w1AZ81MoFyOI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Roger Pau Monne Subject: [PATCH for-4.17] Revert "x86/HVM: also dump stacks from show_execution_state()" Date: Fri, 4 Nov 2022 15:43:37 +0100 Message-Id: <20221104144337.36844-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0500.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::19) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB6575:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a9b5f4b-a177-48ee-8023-08dabe72fdba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +EWxPaROtgRMlpkwJR0OQLpDjJJWrW9Gv3K1CHhwdawQxPil+cl7aylNkcj1rFA1pXCTw3Vo1cm+HNg5ikvCqfaDMQ7uuzXxjIHyEd0+jaht1H8ko24uMjQbY+y+t+nbhb+4XOkB2pxUxewi9GEebVWtgVJFq4RtyHD5JozP61BO/QCVeMQ+lyHu4AYQxCIl3WsPVy98vacAZntgZO+R/Tz5SBwtP4TXVUNdrAZ0HOkK9ClBWU9IWqEMQ3usAuNlke0A4VSJqZI3k1et5iZPN3c/yDiMJiw1zCpno9DFG4NSD5m7lRkYYYAbwnRKG7XKaUVIwbin+GoUTRPjOq2s/bI353DEDBR0KI9JixT+g+IKqDqvuczx3gL2kag0Ptvug8n8Bq1wYHzKCVA2xEol9lpJy4aQVkRnJ/LkOkS8ZArqxwP00FCFeNShceRlnP6Q9enivd37tfm0TqyQZ+AbqVCNQnBSRA2oLsWDiUv1xoQTzHvxEG2WMNahE5cUUozGJSnOqtxGFSyX+pXT3/Ar05cmJ7hjQgHFZXpexh5rY6NojWw/U79tmxG7CPtSXNvYdF+IaRMczlEiQio04UUKz/9zzl1uS3Hs7fC0iauUpsh+keydC/3zG+o81VrQITjRge5MMge79oKtxQW3WdQI8xkyr9bl5Sezkt3PZRYpRVQJJlrF3BlC94A15VPwq33HvdpZ/K8Ll/P/se+hN3xr5g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(366004)(39860400002)(136003)(451199015)(82960400001)(6506007)(38100700002)(66946007)(86362001)(26005)(6512007)(4326008)(8676002)(66476007)(66556008)(2906002)(83380400001)(8936002)(36756003)(41300700001)(186003)(1076003)(5660300002)(2616005)(478600001)(6666004)(107886003)(6486002)(316002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2R3bG9ES2ZGREZoWmpkczhIQmxlNE1ueHFzSmh3UjVkckdxT2dXR3A3NXht?= =?utf-8?B?bDZKaFlxMWZRKzVBZ1RDSVVkUlpWMEVCaFNVbWtYaEVHTDlYbVBMeDNOa2pl?= =?utf-8?B?VnBXdFkzMmFvakhOQUNrRG1xT1Zpdm9nMUFxamlVT2NpU1lTZ2FIam1yc1Rt?= =?utf-8?B?bXdzajlPMzIzdHQrRDg2ZDhJM29ncnJrU2UydDBQR2xuaGZYK0dSWVVuYjQv?= =?utf-8?B?ZDR1dk5JdzMwakk5d3hGNlVFMXRlbWh6UDhucDluR1JUUU4yVzc2cEF2aldl?= =?utf-8?B?b0FML2tibWFrOXFBTnluZ0M1REJSSXA0UzF6bm8yS2l6Q3NJMElqNzdmazI4?= =?utf-8?B?aWJZZFgvUkpDMTl3aHBSc0R5OGJFTGZjNTdORndkclBKeENzWVFCd2wvOHBU?= =?utf-8?B?amQ5b0dabW9SR3gxT1o3WG9MSnVTREp2WmZpbFpGSS9KK3VlNmxEM2ZqcnEr?= =?utf-8?B?V3ZEb3poTXhZRjk4bkhTTndBaEdzck5yWFUwOVZRRGdTcjl3bUdOdnNJcjlp?= =?utf-8?B?ZHRMOXI4TklqQ0prV01uT3B3TUNaT1owUXZ1Ym5WNm5hd09FOGYyTENYdEtt?= =?utf-8?B?RU9DSWN6TTBNRmFFWnIvbTE3QjJLZ1U0SjZOenlnamRPMGt4Q3o5VjFqbEtX?= =?utf-8?B?eGd6K0pjN3d5R3hkWFBLYXBSZTFWUGtJYXljeG02MEROd2x1bWplR3JxMlRJ?= =?utf-8?B?bjhNQ0pOTEg5b1A4bG9FSTUybkZ4bWVTYjdtbEdkc2xTakN6eDJ6dW5vZW1G?= =?utf-8?B?VUtJbXdqUXFZeDU0b2tkRVp1RmxER2t2VUc1eUFLaXNwNUVNdUZWT2JXWjBs?= =?utf-8?B?YXAzYURhK2c1Y1pHakRpc08wN0dtWlhqbkwvOXVyY3lCa1NRQ2liWmJNU05h?= =?utf-8?B?Q2RGVWcyZFFPTE0rMis1T2pZVVNHdVJaNkZ2ZmxvdHpUakhXOHhwMXFPaC9y?= =?utf-8?B?ZnFJejdrYmc2SHdYeGRYdE9keEQwVG13WndZcGxKS2RCYk5wbVBiSnpEdmYr?= =?utf-8?B?dzlPeW4wOFo5S3JncDZzbEx0a0p5c3NqZnIzUUVENFR1cjlYM1kxbk9IWXZL?= =?utf-8?B?U2V6RDdKWWdDajhFTEQwMFFxY0ozZFZ2bkxZdnNTMGdhc2FUSHJlTHFQcTJn?= =?utf-8?B?L213WWxwcGNrVG1naG4rbEZHbzVEOENadUZ5YnptOFRSaDJYSGNKQWpVdTg0?= =?utf-8?B?MVQ0bWpHdDMyZGpmUjNEd3c0NGhtUndVakJNYVdrdFBzazZ1bnFoVGtJUUtQ?= =?utf-8?B?WU1tV0tYeGNQNkF5WDN2azQ4czBvc29lR1AxVzloUFRGMEF0Q0c5L2daakVl?= =?utf-8?B?dXMrMmpxUzByUWw0TWVqYjV1Z1ZVUlBQczdXaDk3cHNndUhNemJqUy9MbGpy?= =?utf-8?B?OHhoTEp1S25Ec1UwT0I0aU5aV05XbnRRTkVBMUYzMjlySVkwK1A2MEpiemtT?= =?utf-8?B?ZU1vS0FLNXZONW5lQzI2ZDdYL3dkZDJBQ3luTFRBMnY0QVRmTElsWDA0S3gv?= =?utf-8?B?eTZkVFQxLzlqVS9WTlFnY25FUUpTT3V6M1RRL29QMThKd0RJMGZRQzhnQTQz?= =?utf-8?B?VzR0Nm9NemQxSXlacnBqK0lkYjVxbkpkT21OTmNVY0NYN1dBaitob25WaGhI?= =?utf-8?B?VElCQy9qU2xUa0x4TlhKeUJITkNVNlZTVzA3SjRXZDJvMzdMRm1uTXprKzZX?= =?utf-8?B?c0t6ZmdBR1BIbnFidHArdWE4bjZEdS9TQ3F6NUFSTnVQYnRTbGJXV1VGaUJZ?= =?utf-8?B?ODVBL1FZQXhDMG5yalhkZFhMNzRtU0ZPeXk5VktoNnl4YzFKdEZYQ2pXSENO?= =?utf-8?B?Um1OQ3UwNVNYK1dBTnJxdjQxS0JaaCtKSm90SGRKVStySitZclQ4Tkljckwx?= =?utf-8?B?eVVSWEd3Y29hc0c2L0NDbmNtUmJCTUZBY0VJV0d2eVdldkg5TE1iMnRzQXVk?= =?utf-8?B?QldicDBTb1VGSzJVMlBhanZ2T1Q1VDdaUVdkTXpDa2hweS90SXlUT2VPWmNj?= =?utf-8?B?ZWh3eGcycGQxTHIwTDZXQXBPMU9OOEtOanlmV20xM3hPWXdUSm1MKys5RVZD?= =?utf-8?B?MGtKenNOVzhFWWcxaS94dGV5MkFSNUNWTGZIS0NYWm4rS3ZuT0xmT2xaMXgy?= =?utf-8?B?WjhqVUJLMWYrbFFqR1JKWDFNSlpGREU5d2o2Y3FzcWkxZEg0QWVIQXdmUFZP?= =?utf-8?B?b1E9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a9b5f4b-a177-48ee-8023-08dabe72fdba X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 14:43:52.1253 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QZc46r5hqCCDJp24IvtNKDAJ2fjuK0rIkx/u0HCxD7ddT2XwhKY3RtwVbk9ObiNv79SdhBagJrOseE5NPLBa5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6575 This reverts commit adb715db698bc8ec3b88c24eb88b21e9da5b6c07. The dumping of stacks for HVM guests is problematic, since it requires taking the p2m lock in order to walk the guest page tables and the p2m. The suggested solution to the issue is to introduce and use a lockless p2m walker, that relies on being executed with interrupts disabled in order to prevent any p2m pages from being freed while doing the walk. Note that modifications of p2m entries are already done atomically in order to prevent the hardware walker from seeing partially updated values. Signed-off-by: Roger Pau Monné --- xen/arch/x86/include/asm/processor.h | 1 + xen/arch/x86/traps.c | 35 ++++++++-------------------- 2 files changed, 11 insertions(+), 25 deletions(-) diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/asm/processor.h index 8e2816fae9..4cdafe2c4d 100644 --- a/xen/arch/x86/include/asm/processor.h +++ b/xen/arch/x86/include/asm/processor.h @@ -493,6 +493,7 @@ static always_inline void rep_nop(void) #define cpu_relax() rep_nop() void show_code(const struct cpu_user_regs *regs); +void show_stack(const struct cpu_user_regs *regs); void show_stack_overflow(unsigned int cpu, const struct cpu_user_regs *regs); void show_registers(const struct cpu_user_regs *regs); void show_execution_state(const struct cpu_user_regs *regs); diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 5c0aabe8a3..c1e5ef1cc4 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -278,6 +278,10 @@ static void show_guest_stack(struct vcpu *v, const struct cpu_user_regs *regs) unsigned long mask = STACK_SIZE; void *stack_page = NULL; + /* Avoid HVM as we don't know what the stack looks like. */ + if ( is_hvm_vcpu(v) ) + return; + if ( is_pv_32bit_vcpu(v) ) { compat_show_guest_stack(v, regs, debug_stack_lines); @@ -586,11 +590,14 @@ static void show_trace(const struct cpu_user_regs *regs) printk("\n"); } -static void show_stack(const struct cpu_user_regs *regs) +void show_stack(const struct cpu_user_regs *regs) { unsigned long *stack = ESP_BEFORE_EXCEPTION(regs), *stack_bottom, addr; int i; + if ( guest_mode(regs) ) + return show_guest_stack(current, regs); + printk("Xen stack trace from "__OP"sp=%p:\n ", stack); stack_bottom = _p(get_stack_dump_bottom(regs->rsp)); @@ -655,30 +662,8 @@ void show_execution_state(const struct cpu_user_regs *regs) unsigned long flags = console_lock_recursive_irqsave(); show_registers(regs); - - if ( guest_mode(regs) ) - { - struct vcpu *curr = current; - - if ( is_hvm_vcpu(curr) ) - { - /* - * Stop interleaving prevention: The necessary P2M lookups - * involve locking, which has to occur with IRQs enabled. - */ - console_unlock_recursive_irqrestore(flags); - - show_hvm_stack(curr, regs); - return; - } - - show_guest_stack(curr, regs); - } - else - { - show_code(regs); - show_stack(regs); - } + show_code(regs); + show_stack(regs); console_unlock_recursive_irqrestore(flags); } -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 14:52:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 14:52:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437659.692084 (Exim 4.92) (envelope-from ) id 1oqy3R-0003hy-KJ; Fri, 04 Nov 2022 14:52:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437659.692084; Fri, 04 Nov 2022 14:52:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqy3R-0003hr-Ft; Fri, 04 Nov 2022 14:52:21 +0000 Received: by outflank-mailman (input) for mailman id 437659; Fri, 04 Nov 2022 14:52:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqy3Q-0003hh-5J; Fri, 04 Nov 2022 14:52:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqy3Q-0002wG-2q; Fri, 04 Nov 2022 14:52:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqy3P-0006Gc-LE; Fri, 04 Nov 2022 14:52:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oqy3P-0005Q2-KO; Fri, 04 Nov 2022 14:52:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6kMQ7DOo8TnfMM4HBqQ7bYe/hQgmfB70z7gjv/rj3T4=; b=yYpB4NZmX51BsdSB7Y6mXY+Fhc hmWtf7NWdyUFKKqTxEz3llnWiZ+oynBdM7n2k7mOKfa34zeVrQo7FJIHjBCcm8t6I0f7hMSwnafKe 87+Q7F16qkJrGdRBolJ88PTSulxXa2xRzk4AKHmEQFJ5IxiteJHEs7arBhoLXiK+LZCg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174614: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=cca6787b15ed0b5a7ebbdfe0a522cacb1cc02a66 X-Osstest-Versions-That: libvirt=a607baf65a66491d5bcbca1e3fa4e672a9ec8611 From: osstest service owner Date: Fri, 04 Nov 2022 14:52:19 +0000 flight 174614 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174614/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174598 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174598 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174598 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt cca6787b15ed0b5a7ebbdfe0a522cacb1cc02a66 baseline version: libvirt a607baf65a66491d5bcbca1e3fa4e672a9ec8611 Last test of basis 174598 2022-11-03 04:18:49 Z 1 days Testing same since 174614 2022-11-04 04:18:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Peter Krempa 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git a607baf65a..cca6787b15 cca6787b15ed0b5a7ebbdfe0a522cacb1cc02a66 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Nov 04 14:57:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 14:57:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437667.692094 (Exim 4.92) (envelope-from ) id 1oqy7y-0004aY-9q; Fri, 04 Nov 2022 14:57:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437667.692094; Fri, 04 Nov 2022 14:57:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqy7y-0004aR-65; Fri, 04 Nov 2022 14:57:02 +0000 Received: by outflank-mailman (input) for mailman id 437667; Fri, 04 Nov 2022 14:57:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqy7x-0004aL-F7 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 14:57:01 +0000 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ece1d09a-5c50-11ed-8fd1-01056ac49cbb; Fri, 04 Nov 2022 15:56:59 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2022 07:56:55 -0700 Received: from anantsin-mobl2.amr.corp.intel.com (HELO [10.209.97.57]) ([10.209.97.57]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2022 07:56:54 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ece1d09a-5c50-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667573819; x=1699109819; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=hJWKUf4NuPQtRp34Roj2E15yGLAfK5Wxv7G4E7L5eFc=; b=nBHfCsBpS3RrqFFQQx9qUVO3iOn/k9pCkgbsTEP4+CbckfxV0YJqbchD +AWtj22nHzWibwozC0y9D7q8m9c8Iqb7GeLfLdCjanthw30WH7Gq4K1ao G2h9+aPGkWWt2yAxAACxDhaGDb41lqgYg3KMaG891d338PwWt8+RiOeXz X3FnTWaJFi3dnpw4IaqLt/dCHnUmB+c3DLyqm4v0QtqnN31Eu55k74YUN IDK595YNLOlDi6OSiqjevoVrU+oCr3y7mpFLN+5A3TPnIH25JIe8ZC+xs yQNld/8rJOJDwWIVxNLtpfGIos24JPyiawKN43lW5GWnoGmisDykmCSU4 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10521"; a="308695616" X-IronPort-AV: E=Sophos;i="5.96,137,1665471600"; d="scan'208";a="308695616" X-IronPort-AV: E=McAfee;i="6500,9779,10521"; a="704106559" X-IronPort-AV: E=Sophos;i="5.96,137,1665471600"; d="scan'208";a="704106559" Message-ID: <7af3d21c-4313-4892-eff5-be66dacf3b13@intel.com> Date: Fri, 4 Nov 2022 07:56:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 1/5] x86: add X86_FEATURE_XENPV to disabled-features.h Content-Language: en-US To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" References: <20221104072701.20283-1-jgross@suse.com> <20221104072701.20283-2-jgross@suse.com> From: Dave Hansen In-Reply-To: <20221104072701.20283-2-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/4/22 00:26, Juergen Gross wrote: > Add X86_FEATURE_XENPV to the features handled specially in > disabled-features.h. Acked-by: Dave Hansen From xen-devel-bounces@lists.xenproject.org Fri Nov 04 14:58:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 14:58:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437672.692105 (Exim 4.92) (envelope-from ) id 1oqy9F-00058U-KW; Fri, 04 Nov 2022 14:58:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437672.692105; Fri, 04 Nov 2022 14:58:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqy9F-00058N-GX; Fri, 04 Nov 2022 14:58:21 +0000 Received: by outflank-mailman (input) for mailman id 437672; Fri, 04 Nov 2022 14:58:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqy9E-00058H-By for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 14:58:20 +0000 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1c780e8c-5c51-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 15:58:17 +0100 (CET) Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2022 07:58:15 -0700 Received: from anantsin-mobl2.amr.corp.intel.com (HELO [10.209.97.57]) ([10.209.97.57]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2022 07:58:14 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c780e8c-5c51-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667573897; x=1699109897; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=lPsbdi3iEDPlS9ix5hC1hyJYJM01ewfiP0KOIWr82XQ=; b=cNpMmDIhtY9Kjl3imF7RbBRNcFmzR8D8CRBafXG+r7CQrTviu/Sk/puB d88eoLtBVfwSdPMaXbj2xuKyEwLT7aMHkWphIapwNShPnpH4lo2s085j0 cbqS1jb7qA9K4jLQWnMhvNKN7B/5qEFHk8j9q+ZMamcynr1N30Eop2fOK 9Mr+QvkTnpLG5RteNPGYIJEE9/4rY0SqcUmFm45bsU1LkZ+FudKNC7XZm 3PDbS2ia1jMQElSa5i29AEeignLfBYnY5TEXabnZwlBk3fYyyhrqrnWoy iZGbiyN0YC9ATVendemme05c7nrZkPBzWdyaDjMyqopm3vvi7aCLusm2X g==; X-IronPort-AV: E=McAfee;i="6500,9779,10521"; a="289700872" X-IronPort-AV: E=Sophos;i="5.96,137,1665471600"; d="scan'208";a="289700872" X-IronPort-AV: E=McAfee;i="6500,9779,10521"; a="637606501" X-IronPort-AV: E=Sophos;i="5.96,137,1665471600"; d="scan'208";a="637606501" Message-ID: <41808063-94b7-b2bc-a261-23d99ba1c0ba@intel.com> Date: Fri, 4 Nov 2022 07:58:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 2/5] x86: remove unneeded 64-bit dependency in arch_enter_from_user_mode() Content-Language: en-US To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" References: <20221104072701.20283-1-jgross@suse.com> <20221104072701.20283-3-jgross@suse.com> From: Dave Hansen In-Reply-To: <20221104072701.20283-3-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/4/22 00:26, Juergen Gross wrote: > The check for 64-bit mode when testing X86_FEATURE_XENPV isn't needed, > as Xen PV guests are no longer supported in 32-bit mode. Tiniest nit if you revise this: please call out that this "no longer supported" thing is enforced in Kconfig. It's not just some random edict where we pronounced 32-bit PV guests unsupported. Otherwise: Acked-by: Dave Hansen From xen-devel-bounces@lists.xenproject.org Fri Nov 04 14:59:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 14:59:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437676.692116 (Exim 4.92) (envelope-from ) id 1oqy9r-0005ey-TG; Fri, 04 Nov 2022 14:58:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437676.692116; Fri, 04 Nov 2022 14:58:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqy9r-0005er-QP; Fri, 04 Nov 2022 14:58:59 +0000 Received: by outflank-mailman (input) for mailman id 437676; Fri, 04 Nov 2022 14:58:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqy9q-00058H-W1 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 14:58:59 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 349f1b27-5c51-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 15:58:57 +0100 (CET) Received: from mail-co1nam11lp2170.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Nov 2022 10:58:35 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB5848.namprd03.prod.outlook.com (2603:10b6:510:30::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 14:58:33 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5769.026; Fri, 4 Nov 2022 14:58:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 349f1b27-5c51-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667573937; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=+HzJr+tf6eiD9vL5z/PkLCdmhiIDHTr+hlooizxB8xA=; b=QTZtEbfyLpURtaDqjZYmpVXIKWyNKlXK/5lCoALj+vnhbVpg1aqZeXHH 76fpxqYdLkeyr6nVTUC4NZ3HYZTfHfzszxP56MlKLLuaCfx22rGA812Kj ISuQzd8NtSRzwZD+4algPElmR/JmhI0elAhzPNPWyQlm468kRTutGtHbx o=; X-IronPort-RemoteIP: 104.47.56.170 X-IronPort-MID: 84182728 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8ziN+a9x1MIzNUYEQUblDrUDmX+TJUtcMsCJ2f8bNWPcYEJGY0x3z 2RLXG/VbPePZDP3KYhxaN+w8EkCupaAn9M2SAE9+Xo8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKgX5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklQ9 PsyeRFdbSmphvnx2ZeBUuRMlJgseZyD0IM34hmMzBn/JNN/GNXoZPyP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWNilUuiNABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCN5LROfnrK4CbFu742pLT0YGTl2Hh+CSjxewAPRfd k8F5X97xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnO87QyY7k GCAmdzBDCZq9raSTBqgGqy8qDqzPW0eKjYEbCpdFA8duYC8+Mc0kw7FSctlHOitlNrpFDrsw jeM6i8jm7EUis1N3KK+lbzavw+RSlHyZlZdzm3qsqiNsmuVuKbNi1SU1GXm IronPort-HdrOrdr: A9a23:E9fOmakuYDn1YheXKOeeOp8tW6DpDfOPimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza9BOO gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4ZkWUzxjIjLH47JlON1Kk3VO 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEz82IIgMgE2nsQ/pM0TJdJo+ zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBOB1vd75rspLkl7uCjf5IFiJM0hZ TaSVtd8XU/fkr/YPf+qKGjMiq9NVlVcQ6duf22vaIJy4EUbICbQRGrWRQpj9aqpekZD4nSR+ uzUagmccPeEQ== X-IronPort-AV: E=Sophos;i="5.96,137,1665460800"; d="scan'208";a="84182728" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hYdUosvGNGcmWuCr6xbvWvbDX/47H00L/2QbPhScEGDN4MoUUfUP3X2lHSkwiuoX+PEopz2w3xcwKEmkOn2ptR9AVW1UgHFnet0efApiYlC0+FqmQ8Vb8fGqi579pnuZ64u99hPdoi5RF2mHjfGr3TjCIQb7HROsmJrtJPg2gQWS2+k/b63nvlGhBKS1uUlfsL5Szq5A+P5m0GxoU0FautbOBElp9M7jll/pvdjD9NfeUuyl4wImcnlT2SjVOSH4CiCi/eoFe1Z1gJbH4iBFbGuVd17nbauaoXTY59Cj/GRHGO9Ps7+ZVxPC/Gl+cR8A1o3W7BNgp8LB+yZw8IYx5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+HzJr+tf6eiD9vL5z/PkLCdmhiIDHTr+hlooizxB8xA=; b=jyoxKHjvaH1HTXLHIJV7FjdyQ2onwyuLIq87UXTUByafXQ4nOxFBCNYc9FgXdvPRJUoZRjz6eq22FuviTXmSskWt57clXQkBNjpHy64EZImTHr+Nny9tsdaZJqpytbmCWZo67F+tjcJEQCrJOpj949RWFiVTqAYHEFLKjJb2NIyzrxXYdPrTVohffxn/mt5d6iGHXZlnZjBmrlI4MyeA06bZCF43h4S9yd3ur6oCb4vVghGGxVhq7MOx4F+C439LaIhQvC+qQFxmJDdZqNXN4tEOHT+CChMPqBAAjP3xgo3jdihfrnEGnhuZIFK0oE9jAB8vARoagLHqZyGd0cK4cA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+HzJr+tf6eiD9vL5z/PkLCdmhiIDHTr+hlooizxB8xA=; b=UzvHVvQsDj44gYoOk884XYA97xC4cPwMXVXAxSiyQAiq32vWbwtPIEkHU5S8Iaf2n2+XkCBr50VSRu/GYA8sjSB+yfpzviULuEtgIn0dpbaK4AhiuW4qDt8uF/SLgLBLqh8WDtvd4NHleGa0bYyYXXgh5qpRRMDpMOHbH0+jHK0= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: "Henry.Wang@arm.com" Subject: Re: [PATCH for-4.17] Revert "x86/HVM: also dump stacks from show_execution_state()" Thread-Topic: [PATCH for-4.17] Revert "x86/HVM: also dump stacks from show_execution_state()" Thread-Index: AQHY8Fv1+K7IFcVij0qSJnf5kUFrU64u2xiA Date: Fri, 4 Nov 2022 14:58:33 +0000 Message-ID: References: <20221104144337.36844-1-roger.pau@citrix.com> In-Reply-To: <20221104144337.36844-1-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB5848:EE_ x-ms-office365-filtering-correlation-id: 69b33d2a-53fd-4fe4-9cf8-08dabe750b30 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dxFXmuztuUKv3KQ/p19qo5pjmywpTPfvqBXWavgdVBZZSje5oo6qmYPUX0sv+CRVwa4qv6uMWjulv7WOJp5LmJL0ui5JN1GK6Tf1ygoXV9cOl2l5CP4x0tz7Pav8DqkjX5T06K3P3U3+wZ9SX7xbBvXRbfX/tSEqRfBWMKCK/6Dz1vHo9NfQzGdYlqpSTeJeEqfo/z04jqk8d7XkDr1q0PZHv74XN54yzLxHg5WOz2GmGTlbINUXRTlSeIYYHW3p0Kl74B7vmMpUAC3HvnQoKTN/cAbiiO48kJbK6WDtugGIfgH+9rySYDbK9rLvwh6h8hc6gsD1ODNc2mvSgtLHGM18Lbp8kvFPOKV+lWpwXZU9mWQSD4NiLg2kBtpXPzPa/v69IKF+AEda72DrVkqFPhPr5FQoY57tfLWz57z5QSm8W6tkfIX9lK1TBvMLxI0YytfPrCH0KTGELkHh/+w5NHaK1/p1Dz0CMy9NWmCcIEvbDLJZpKw87Lc4E5r2VudvMlkAOei1tB6WQEUhJMULHc8h2gWn0q8DgmGQbaOy50SM3Y65XQBPOc93BVmVGSragraebXxsDF7bAJ/RFVwjks970d7PffRQV9IbNr42/OU2EreCgd/LmIY/8+wX4KPintp2Rn2++bu9/iaaUY7O79GMEYnzga7bS8yP5arlcMbCJLkKWuioMXaNn/oTcyXkxloGUVQC7hKI2FY6I66ekJIZq6H4F++uBtn/6EAafl07xiA5kWhrsvuNUBN+46D7ZpmVPyKLvePWnBvh9mjGXhk33fldnZHy8q40Q6pZ6o72lxkxzAeaYf9QmGtxG2+HcdhcZS2nF4EYrzwgnCJ1OA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(136003)(39860400002)(346002)(376002)(451199015)(71200400001)(83380400001)(31686004)(38100700002)(86362001)(31696002)(36756003)(6486002)(2906002)(4744005)(122000001)(38070700005)(186003)(82960400001)(6512007)(53546011)(26005)(2616005)(6506007)(41300700001)(66946007)(76116006)(478600001)(91956017)(4326008)(66476007)(8936002)(66446008)(316002)(64756008)(5660300002)(66556008)(8676002)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VGdGcGozL2Z3QlQ0LzVEaUNnTDhBbkRrRXlyYnNiZVhQa0tNdG1zVm8zemF4?= =?utf-8?B?MVZnYzJVZndiaHdRekFtT0JjNzcvQk5kMU9wVEJYaVVERCs1Szg0eDBFV3Qw?= =?utf-8?B?STZLa1hQbTRaZi82TGcvcS94UWJBdHB6aDZNeVIxaENsRHQ3aUEya0xUbkxv?= =?utf-8?B?ZWJlbDVHNUNRWS9SbU5DKzQ2NjdBeDVJRGV6eGdhRnRsZlJJUDVobnlEaHZ2?= =?utf-8?B?M1NkTG9udUovalNhdEh4NW1EUHloT1BXVmNGMStKRE5lOExJRE1CcGtWK3lx?= =?utf-8?B?eUpSWHNtQXFaUnMxODNyK1dUY3Z4bW55MXU0MjlYZ1dES3lCY1lzSEZ0ZW1N?= =?utf-8?B?Wi9OMVRYYjFWQ0dhcDR2VFBINi9sVHVRL05idHlYRGh6SGdOamRwQS9MajRT?= =?utf-8?B?UVJPVk12Q0lxejZCSk9xTVN3THlXWFZxaTlzUVpoQTFISktaajREZWNpY29k?= =?utf-8?B?MGI5dVBUdFhtTzJPQk9TZm14UnBDWmZNRVVMR2xScnF4VkF6eHI0RUJaYlBm?= =?utf-8?B?OGlWRkdHQjk4eTNhUGZOaWFkV210Tkh4UW50alFHRjZ5M3FYQnFIcmREakZi?= =?utf-8?B?VzRZMXdST1pHUjN0QkY1QmpsblFObnJWR3BUdEk2NG9mQnJ5Q2xkVG9TdlM3?= =?utf-8?B?Q214Z005Nis5T1pKYSt2QUxhdGQyeVV6WWN2Y0prOUd1UkVGZW14RXZTZ1Rn?= =?utf-8?B?MjdkYVRzTjdZamNWb1BFZW9GcG9sWHJ3OStZcnBLbTJuaU96TGtTZnpPaUlT?= =?utf-8?B?OGhiMmVxVndzeFVFL2ZJNnB5c3hnMWtFRWE2cjRYcmxjVmdDcm5pL0lQeXFQ?= =?utf-8?B?b0VkSXNJNHA2OStNR1dId3lQUHlucmk3TW9qK2xib2krc3RZR2l4VkFPdVZL?= =?utf-8?B?b2dvcXRZREF1NmJEaG9aTUFNbXVWWHNXR3I4aWpNRmNUeUpFU1FZMm9zOGE5?= =?utf-8?B?d2VlbTJjU1ZpR1llZ25YWFRlUmpwNDVHdWF4VEZ1U1FYNkVQWXFxRDNyY2dO?= =?utf-8?B?bjY2eDFPNzZrOHlZWWpwWHB2d3ZHY0lFWnRIeUorTGhNbVd1bmZSUXMxWC8x?= =?utf-8?B?bUMwNWVoUFJwWGFjRGM3RkxCR09oRkFiUHhhSXdQejJHZjFJalRzUFc0c29M?= =?utf-8?B?MDUxaW1uZVg0Ly9iLzdWZ1RzeFVCNDgxTHhJTFI5MnVaQUNqMFVtM3RDL2da?= =?utf-8?B?YW96aEtQYzBwb0pDZjMxVzNNMlBaSjZkK1BjUlZzV1VuVkdOYnVJNGkvVXBt?= =?utf-8?B?TFRoRUw2bE5tUTFaWHd0ZG02SHlDMHdKRlFWdU1uR0VuWFNZcDMralQvaGtB?= =?utf-8?B?UkViaW9oRkd3QkpjQkNEaEV4UHcydkxsTXZWT0ZLUnlzVnhQZ21ZTkNHUEh1?= =?utf-8?B?eWRrb0ExOENlODgrWm84U3lVaTNCOVIyUmx0U2dkaHBBdWkrRWRwdkEyUzc3?= =?utf-8?B?VGNYV0luZU82YU83VUhNalhTZW1oaDdhekpWQ2JRZ2d4MXZuanZqU0dvQWll?= =?utf-8?B?SVJFWlBNak1FK3Avek9Ka3IwMTRzc2NSOGhBU1pTWEE5SHgrUnY4Y3N1VlVa?= =?utf-8?B?dGFDbDhNTW8wS3dhUllmOHZjRU5NUlpKTU00VVJoRHB0NHJjZXZHSGxTcWpH?= =?utf-8?B?RXdxMmR4SElnajJlWC9LdmVJUWFnWGI2NXBUUjJ5bVZva2sxbkxJNm1UU2JV?= =?utf-8?B?ZXJxN3VCbmx4OWxibitqWUpSVHd3U3JNd3QwSnpzT25sZzNJVjl3VHNaaG44?= =?utf-8?B?QmVQUVZ6Z3lBUmVPYUoxc2h2OTVsK2s2ZVZCWmlPSHlPQjVNcjVxNWpmdVNn?= =?utf-8?B?ZlZBdUVLNXBqb0V5WlhFNURIWHQrbVRoRURWblJuR2Frem85YVd0K3RuL05N?= =?utf-8?B?K2UvSmtWZ3E0MWUyZUJMOVFMWjZIZWs5WGZWMkNZb2xremw0OUJwNHpqMkhu?= =?utf-8?B?MFo4T1RlQzdUWTIzWlE4dU1lVDNxeUJFVDFYcW41MnJJbU9jbm5tYmg3NTJ5?= =?utf-8?B?dWhlUWhUTU9adDRYay9kaFZwZituR3FPZDNrNlBlZjloeldNM0pQcTNFYzdn?= =?utf-8?B?L2c3T2xDM1lXdWN4R0ZLQUFJRDFoUW1SL2RKclBnbkx2bHNNWmlTZmtmRjRl?= =?utf-8?Q?tGPLiTI2j9hA4MTkgk4ihpO4w?= Content-Type: text/plain; charset="utf-8" Content-ID: <2C073CE21D809044BC5289DE8C659AFB@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69b33d2a-53fd-4fe4-9cf8-08dabe750b30 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2022 14:58:33.4220 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PA+qiyUAHhTPfVsAtrsSJmRUCMrTS9ShzFbEXJUAVFYP42GYcec3sb4Rv7st0cqIs7SsCCvz5AOqwaHYlzVR7bVDL8L7qIo8DKp77NhSE3U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5848 T24gMDQvMTEvMjAyMiAxNDo0MywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBUaGlzIHJldmVy dHMgY29tbWl0IGFkYjcxNWRiNjk4YmM4ZWMzYjg4YzI0ZWI4OGIyMWU5ZGE1YjZjMDcuDQo+DQo+ IFRoZSBkdW1waW5nIG9mIHN0YWNrcyBmb3IgSFZNIGd1ZXN0cyBpcyBwcm9ibGVtYXRpYywgc2lu Y2UgaXQgcmVxdWlyZXMNCj4gdGFraW5nIHRoZSBwMm0gbG9jayBpbiBvcmRlciB0byB3YWxrIHRo ZSBndWVzdCBwYWdlIHRhYmxlcyBhbmQgdGhlDQo+IHAybS4NCj4NCj4gVGhlIHN1Z2dlc3RlZCBz b2x1dGlvbiB0byB0aGUgaXNzdWUgaXMgdG8gaW50cm9kdWNlIGFuZCB1c2UgYSBsb2NrbGVzcw0K PiBwMm0gd2Fsa2VyLCB0aGF0IHJlbGllcyBvbiBiZWluZyBleGVjdXRlZCB3aXRoIGludGVycnVw dHMgZGlzYWJsZWQgaW4NCj4gb3JkZXIgdG8gcHJldmVudCBhbnkgcDJtIHBhZ2VzIGZyb20gYmVp bmcgZnJlZWQgd2hpbGUgZG9pbmcgdGhlDQo+IHdhbGsuDQo+DQo+IE5vdGUgdGhhdCBtb2RpZmlj YXRpb25zIG9mIHAybSBlbnRyaWVzIGFyZSBhbHJlYWR5IGRvbmUgYXRvbWljYWxseSBpbg0KPiBv cmRlciB0byBwcmV2ZW50IHRoZSBoYXJkd2FyZSB3YWxrZXIgZnJvbSBzZWVpbmcgcGFydGlhbGx5 IHVwZGF0ZWQNCj4gdmFsdWVzLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOp IDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCg0KQWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJl dy5jb29wZXIzQGNpdHJpeC5jb20+LCBhcyBhZ3JlZWQgb24gdGhlDQp4ODYgbWFpbnRhaW5lcnMg Y2FsbC4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Fri Nov 04 15:02:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 15:02:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437682.692127 (Exim 4.92) (envelope-from ) id 1oqyD3-0007cO-CG; Fri, 04 Nov 2022 15:02:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437682.692127; Fri, 04 Nov 2022 15:02:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqyD3-0007cH-8z; Fri, 04 Nov 2022 15:02:17 +0000 Received: by outflank-mailman (input) for mailman id 437682; Fri, 04 Nov 2022 15:02:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqyD1-0007cB-Qo for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 15:02:15 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2066.outbound.protection.outlook.com [40.107.22.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9e759d9-5c51-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 16:02:13 +0100 (CET) Received: from DU2PR04CA0329.eurprd04.prod.outlook.com (2603:10a6:10:2b5::34) by PR3PR08MB5641.eurprd08.prod.outlook.com (2603:10a6:102:91::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 15:02:11 +0000 Received: from DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::a5) by DU2PR04CA0329.outlook.office365.com (2603:10a6:10:2b5::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 15:02:11 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT049.mail.protection.outlook.com (100.127.142.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 15:02:11 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Fri, 04 Nov 2022 15:02:11 +0000 Received: from 41ae998e9f15.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2069500E-4114-4808-9D57-B75DC1220D5C.1; Fri, 04 Nov 2022 15:02:05 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 41ae998e9f15.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 15:02:05 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB6600.eurprd08.prod.outlook.com (2603:10a6:20b:33e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 15:02:03 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5813.008; Fri, 4 Nov 2022 15:02:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9e759d9-5c51-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FOKdxA64ApjICumSqneVN16i8MdvcCpRjUMKFbXGbX1e4I/MfmnP9ce57qqQCnMbIqYzKH35g+PIw2lSYGVVkDzZr91amalxAs+0CXRmh8yHZTZwPLtC5k/ngq2E01cu5XJqIXiHL1/i8BxqT9QKhLCSB+Qt13hmWKodaqRvk2EEMOzPpeZ48hmsDdDJmX0Qn4Rl786DJL3Z1Le07YqABvoxDqEHDDK6Dw/qNo7X0WO5pg4jGa6wa0wd1qhhVqH30o3/K3qV71Uke0Y51vfV7lWiu702vwLHMtUc4Hc+zLkLc7hIH3Ga6ukf5rJnbAsMjcrJTTdwC1sSUEAlnmDGSg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hyjY2hz+EbXzSl4D44BhXe26W7DX48s4evM5fZRhP98=; b=Og1tIplWrqUJtr6CE9VBjeG8JIB+lxaPpL+YDmcl5sEfj0RDCIlsAgLlrpv4zfoOnoh2aSOQQ/iYRH1gkZiUsLaxZ7kb+XDIGn/qcnvQDi50xrklUvXJTDeHoNuobfLnBFoQ0gOR/0OWMhEbwP1OtcRISiWmdrgtCqWL/DF+zPSozV+lYQtvA6Td3lHmYJvEN5yLW08aFCtWMc/ep5cb7s68s8ceNRa6RDVnWmLq8/m5YmkYqUl6BPz4/f7m5trGpWzItPCmADMXw/ga5tTKgTcrPH8RukJ66xFLZIR67V3ZyyH+5pqPFv8GSyvgRLBj0YWobfNObxpfZXfRH/msxg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hyjY2hz+EbXzSl4D44BhXe26W7DX48s4evM5fZRhP98=; b=UGkjrZpcRpCHaeH8cwVbbtZaDPuDn9jwWw7Dag+zciLz24e8cXM5r4nSWPSTdmYcWNJCkm/iPWRm1Mm5H4jKzO4M2ZNv2Nm5MCHZNdOURpbUoMXXSn617bdZGeVdoqt4N0gV+60+Q3q8qdlRnPGUoxTBn9CURk+hf84Jo2z9XL0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DUrBB7bL1zN0CsU8q0AEuWIVxGtw4h/s3HJYOw9wszmEIOBXhrhh8g3sll/j2BNw/ZmNnuKlKJczqR27xkMb6ccRB+Aap/1IL5Bfb4ubKXMIAmC7ozdD1OCRuWkSVWKLEPJ2FAsRvqt7ZMNvUZYqFFkEcms6o2IY6DVuCCTE9A1qw8jjs4L86YXurXdDGyYuSIUI7tzHqXUKqJoGO8AEkpJylmuBQ1zIvG2jYhvutOri4iQBHY7JelSzPw6BL/3lH6Biu9AZMaHb0J6Y9Pmi36k+bZpT3i5B+dYPv61V912NpZXCRuSnRcWPLFcJg78v5Fj5/PRNKFP+gMfPRgeOUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hyjY2hz+EbXzSl4D44BhXe26W7DX48s4evM5fZRhP98=; b=UMBiffAj0QtP4wMnZoUekQIlomosydovqLAt093K1RIHmLD/DAB4m9Hkl/aXlrf+H31+BzlM/SDNMRTghCJbFSkDRfdcXBnHowwnyJqaCm10RRghv2nX7OW3/tj1ztpQJ5D2KbmRY+YC4a7dI0I03xubp1hRzXTLofqav5Oljw+MCMQSO0jAGNb0z2rY4jdaDOKNL4gcxqz3pHs+qC0JuOL212DQY5haBnJGalWDst6wtLVofmQ7sF03XJgY5XNR1d9UP95lshorJELAe9s874V4FnyIdGTAiKIdpVBQ1tAFW+/dXFUSlUqlMHXoVhsI6md9BwouNy/2sb6Ni3/kyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hyjY2hz+EbXzSl4D44BhXe26W7DX48s4evM5fZRhP98=; b=UGkjrZpcRpCHaeH8cwVbbtZaDPuDn9jwWw7Dag+zciLz24e8cXM5r4nSWPSTdmYcWNJCkm/iPWRm1Mm5H4jKzO4M2ZNv2Nm5MCHZNdOURpbUoMXXSn617bdZGeVdoqt4N0gV+60+Q3q8qdlRnPGUoxTBn9CURk+hf84Jo2z9XL0= From: Henry Wang To: Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH for-4.17] Revert "x86/HVM: also dump stacks from show_execution_state()" Thread-Topic: [PATCH for-4.17] Revert "x86/HVM: also dump stacks from show_execution_state()" Thread-Index: AQHY8Fvo92EmCyvfk0qQoQum7MnN2a4u2/HQ Date: Fri, 4 Nov 2022 15:02:03 +0000 Message-ID: References: <20221104144337.36844-1-roger.pau@citrix.com> In-Reply-To: <20221104144337.36844-1-roger.pau@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 15F3AF82BFCA084FA0ACB542AAA6AD3F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB6600:EE_|DBAEUR03FT049:EE_|PR3PR08MB5641:EE_ X-MS-Office365-Filtering-Correlation-Id: 12bbb0e8-18da-4f45-0e6e-08dabe758cfa x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cSlL97y5CKTx0/X9BySpFSUbBkIImj356dqiIRSqaDQryXbTaW5bOIFKgx70lOFF4OwnQPB0OF7U3BcEgYI/o916zt+1FE00szrJH5ilFql9p2nfWDjuC9qBpDeCK4kw6PcDw+azuUobtQ7US/63IqwCaVjkHbdCbFSnfoeiwnfsWY2SL5e1p9yQjPJPK3AoTTPUX4dJ5CFwoh/B0HxiO3GVBKVF1FgyKBUq8tlPIKTVZ9htl1OqlwZnY9oFKI5T50YACWSDWjl660jkDgdDrekaR+1ywIIrpLjftWMkDMM2+NdpTXcJ8GGJ0Y3Arv2c6HQiRmtB2T+iBLwUfCVFHJR6bib+avXgBImp/hwzuOCG0nLpZVBtuGzH+ElTQ/UmaGqMmdtCJ9UO+GhNOdNqwo0iPzI0jQ4T7zQmrFgXPJNTJGyViFPTw//APT7VBD/EybvAN9Aibxs8oCUi00rXaRrdnJo/YIAXPpNCTOqX5S3vCMwtFhaVLSiILqF+m4ikSxK5Z0gRCer0497O+qkYXl7CqbvEoas+EGV6Ilrjwq0P+468p2BlRp9eZ4eM6xWmPcSYMwcsGbxXdsgL7es8T3BF+5TtAu/CfPYN3BNxBOthZqmd51pMY/iYTcDKbhU6/ACrCk7UtqlnAjR9ciUe4Om+M6YkF1eLtN/6+CfCPyMQVIRyIVbjI9xGsfQkjSJ5OXvkGh1TtDjb0+m0dscgSoTsbxzOuOr9iWXlbsPQASVojYQpi3jefizIPY1q4wQZ4BxCyoYLO103MaYTICkz8w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(366004)(346002)(136003)(451199015)(41300700001)(110136005)(83380400001)(186003)(5660300002)(7696005)(2906002)(8676002)(6506007)(66556008)(4744005)(66946007)(66476007)(66446008)(64756008)(76116006)(52536014)(86362001)(316002)(26005)(55016003)(8936002)(9686003)(478600001)(33656002)(122000001)(38070700005)(71200400001)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6600 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bba6a746-44b1-4d5b-a772-08dabe75883b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c3TJ0lVIDDjn1D5ci4PGf3Z2cWeO4siEAnfVQAKdAbYbDwLlceUZF+J8VunHGVz1Qw19281X+zvX1/0ZBPcyPg6TqwnlhgjqN+WvS20XYDT84Zara7Ne7q60bNYtFzxOfF7aY65pEmB5OE5ADtegip3sJ4zUch9+gLoZ++73hx7Pd/KanjORCo2G/R1g5ZvAh1QEM0HHtjjWosy27ns/DWc+FqxU3T/ubccbJFLdM4wvPflkhlmqjUrurpI0GYLVuYi1QRyxRvbQg6Ke08+zSL9qdWvhclJs5NwJzaxpzZCOvOaLhN24ZYTh+P1jj5lsdbRihn6qRQaJS55zpqbZcBQx6V1PKVSiB7Hu/Y4p7sri5JCKyzHNLF0oqCcVs1jIoaj6fyuiG/tfSKC900L3XKxJIc96moeb8fbu0keEUWQ645MuHxk5+Zuv/qM+2fvbKsxpp+H9ujcWq1KGmtLygumcwrdlfPGIFj3isinLt55OQB4XH2eB2CH/L5AKFEbZXSrXiYdSbmxCXY3Pmh4O7qLonL2TzC3xomtTBHTGVR6yCS6HSM1t41vG6MaxOWEEU8LajJGZ1rim/b5BMxJfHfxlSo35ToLYuCcCDANRqjI/iONPg7jXdUv/H6Th2G77FFLVHQnj6trCPOHK4w0EbbYp2ZdHLhMJVybsNrWlH04m9J177LfxMk6K489Ks0NKRqw/1bWtWkKrhzDVC9c+vMW6sZVCJWqg7ur73+/yN/22yBYFH1sHLKRLjbfDAeiVHWuQFSIL3O54XDyv4SkE0w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(46966006)(40470700004)(36840700001)(47076005)(83380400001)(2906002)(86362001)(40480700001)(55016003)(33656002)(40460700003)(8676002)(26005)(70206006)(41300700001)(70586007)(356005)(81166007)(82310400005)(9686003)(36860700001)(316002)(110136005)(82740400003)(4744005)(52536014)(5660300002)(6506007)(7696005)(478600001)(8936002)(186003)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 15:02:11.1839 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 12bbb0e8-18da-4f45-0e6e-08dabe758cfa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5641 SGkgUm9nZXIsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUm9nZXIg UGF1IE1vbm5lIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogW1BBVENIIGZvci00 LjE3XSBSZXZlcnQgIng4Ni9IVk06IGFsc28gZHVtcCBzdGFja3MgZnJvbQ0KPiBzaG93X2V4ZWN1 dGlvbl9zdGF0ZSgpIg0KPiANCj4gVGhpcyByZXZlcnRzIGNvbW1pdCBhZGI3MTVkYjY5OGJjOGVj M2I4OGMyNGViODhiMjFlOWRhNWI2YzA3Lg0KPiANCj4gVGhlIGR1bXBpbmcgb2Ygc3RhY2tzIGZv ciBIVk0gZ3Vlc3RzIGlzIHByb2JsZW1hdGljLCBzaW5jZSBpdCByZXF1aXJlcw0KPiB0YWtpbmcg dGhlIHAybSBsb2NrIGluIG9yZGVyIHRvIHdhbGsgdGhlIGd1ZXN0IHBhZ2UgdGFibGVzIGFuZCB0 aGUNCj4gcDJtLg0KPiANCj4gVGhlIHN1Z2dlc3RlZCBzb2x1dGlvbiB0byB0aGUgaXNzdWUgaXMg dG8gaW50cm9kdWNlIGFuZCB1c2UgYSBsb2NrbGVzcw0KPiBwMm0gd2Fsa2VyLCB0aGF0IHJlbGll cyBvbiBiZWluZyBleGVjdXRlZCB3aXRoIGludGVycnVwdHMgZGlzYWJsZWQgaW4NCj4gb3JkZXIg dG8gcHJldmVudCBhbnkgcDJtIHBhZ2VzIGZyb20gYmVpbmcgZnJlZWQgd2hpbGUgZG9pbmcgdGhl DQo+IHdhbGsuDQo+IA0KPiBOb3RlIHRoYXQgbW9kaWZpY2F0aW9ucyBvZiBwMm0gZW50cmllcyBh cmUgYWxyZWFkeSBkb25lIGF0b21pY2FsbHkgaW4NCj4gb3JkZXIgdG8gcHJldmVudCB0aGUgaGFy ZHdhcmUgd2Fsa2VyIGZyb20gc2VlaW5nIHBhcnRpYWxseSB1cGRhdGVkDQo+IHZhbHVlcy4NCj4g DQo+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29t Pg0KDQpSZWxlYXNlLWFja2VkLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQoN CktpbmQgcmVnYXJkcywNCkhlbnJ5DQo= From xen-devel-bounces@lists.xenproject.org Fri Nov 04 15:04:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 15:04:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437688.692138 (Exim 4.92) (envelope-from ) id 1oqyEs-0008Dn-RA; Fri, 04 Nov 2022 15:04:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437688.692138; Fri, 04 Nov 2022 15:04:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqyEs-0008Dg-Nv; Fri, 04 Nov 2022 15:04:10 +0000 Received: by outflank-mailman (input) for mailman id 437688; Fri, 04 Nov 2022 15:04:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqyEr-0008DZ-6Z for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 15:04:09 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150088.outbound.protection.outlook.com [40.107.15.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id edf6b19c-5c51-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 16:04:07 +0100 (CET) Received: from FR3P281CA0061.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::9) by AS2PR08MB8645.eurprd08.prod.outlook.com (2603:10a6:20b:55c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Fri, 4 Nov 2022 15:03:57 +0000 Received: from VI1EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:4b:cafe::7c) by FR3P281CA0061.outlook.office365.com (2603:10a6:d10:4b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 15:03:56 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT046.mail.protection.outlook.com (100.127.144.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 15:03:55 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Fri, 04 Nov 2022 15:03:55 +0000 Received: from 303b80ec8ec1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 006F00FB-650E-44B3-95BA-77710F91AD3F.1; Fri, 04 Nov 2022 15:03:48 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 303b80ec8ec1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 15:03:48 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAXPR08MB7334.eurprd08.prod.outlook.com (2603:10a6:102:231::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 15:03:46 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5813.008; Fri, 4 Nov 2022 15:03:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: edf6b19c-5c51-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=jEGswKG6DQi+RjJnN0acbzA/TjUJRj3RIsDf+iB++empE/3KbYmhDyfQIkRvIBqr6codbd3bMepnqC0KKrFtXjp9sxoX+6N5m37L6V7uoEDVP0aPWC8pMKuf2mHCiRbFaSO72Vorv4E0bL0PueQ0NNTSCWjA2R2JPjgdN/FJQenKKxPq1S9HkRFQ+j723Z8jhaHUG+N7LIfBzl/XgzweagFfvI8WV0Bxr0xzyNTbIlQSZPpbiI4i39GCk/KS0m9m8OkF9RATpCDjS+6nV3VUX5DMD2n/dlMrRgjpjeezvigIvoxkvYUJ/I4mcozF9C4Hr3PBzWt0gacO2Am1mmlA8w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TFCG13yBuFB1fDz7FFko66VMXeHFo+FXxoqBj7CxRxU=; b=aw1HKkLcrLJvqT5B0wzwYfQ7Yotn1+7LO3+z3o21zu4EqdHV43jc1cI0ojbSKQuku6D1c0FWNloitVHTSJ6hBczDybUGGOGkRvFq+o1M1BBt6d/UyaWKfDefLJZdUP+q5Sjp6SKTlqy/O+GOEr94TdzBJMooYb16j3AARhY6GnDPyZJb693+CIHGhPVSLOALhXlxPx7x94d2HlOQN/JaMVleGKONIQPDXtPqpBcOe6hl2lMFxfQB5Js4ELj3mHjiD8iKxt0wFxghDkUALDrry0Q7oD6AuEbqC3ATlGxMA3aoDV8knvjdosu6NwkpCBSvOlPaCK9wfADQdpLAhwWmqw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TFCG13yBuFB1fDz7FFko66VMXeHFo+FXxoqBj7CxRxU=; b=cSSpPo/ktSG5QlAHgUArLveZOfm0C0RQf1dzLc6p+8lsNYT/3T17uE/pYb0c/PIyjuL0owlzJHAGpS59p94gnkBJzh5y6NAojxdydOdHnygn4rnFPE6s5+hkYjXFVNFdTcpyu9Ssdxy25pwlbjRWHEIshQfpvWKE5bveHSxF6aw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L++kvhYlIRd4ah8Wu+I9p65FYfcB1MK3oP2E7/kzEW9IFQOxI9ESe8NKv6rWyqq+gelq5vAmY4yEflvMUAMAQsfEi9oLlt/JNAwUpUA5q3HThHttVToUmXsnptnQK6D9+aUtK41zHz2p1igy086l0+5sAl2YfpiEEqi/+CEfHrGtNfP8OnTy1zdgrQSMVOh7zY8sghaoez7t51XuakxUNIjeefRMV9fz29nzFvOEH2L6bWhfTFDLuCX4F4yw1Le4c9UiZmUljd/E4ERlvtyByFIOfP3HudwnkIy9SL5PMXuMPsrDtfYq1/uTdGawj2oSZLwmixU2hhNJEtT2yDhSJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TFCG13yBuFB1fDz7FFko66VMXeHFo+FXxoqBj7CxRxU=; b=AL0uH/hSl/qKptoVJ7WbjG+7/XgERcwXXjgxZWojO9S1LAjHKwSqcGWM5CebCNMHn4ae5xjj9ILHHizy0DG98qI0w3Yz9vSkNvH95X1fA85xZZCofgKwFslCROxgDYR0kJfuH29hooSpD0TerxPwuZsV7AdX0HdeLtsJvMX4RE6exQtHY/NRUovaizgzHnhMnkMuZbp/D2xQxLfFpAM9VdmEzFipAfsjT5p9IPHI+t2auXCFh8URV4VwvUClmrq5bqmNnCot1mcBEGsRS1j+p7V8c6Q7+cMxBdyz1nPt8V/U40PnqlqwX5C5LauwCGD5/8bAZfO8PX8i1xaeomf9TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TFCG13yBuFB1fDz7FFko66VMXeHFo+FXxoqBj7CxRxU=; b=cSSpPo/ktSG5QlAHgUArLveZOfm0C0RQf1dzLc6p+8lsNYT/3T17uE/pYb0c/PIyjuL0owlzJHAGpS59p94gnkBJzh5y6NAojxdydOdHnygn4rnFPE6s5+hkYjXFVNFdTcpyu9Ssdxy25pwlbjRWHEIshQfpvWKE5bveHSxF6aw= From: Henry Wang To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Paul Durrant , Wei Liu , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian Subject: RE: [PATCH for-4.17 0/2] vapic: followup from assisted APIC series Thread-Topic: [PATCH for-4.17 0/2] vapic: followup from assisted APIC series Thread-Index: AQHY8Fj9tLGFgwntT0yR/u6/Ci856K4u3FtQ Date: Fri, 4 Nov 2022 15:03:46 +0000 Message-ID: References: <20221104142235.36556-1-roger.pau@citrix.com> In-Reply-To: <20221104142235.36556-1-roger.pau@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: FBDE7B6DEA5B344EA50D1D8BDEE918E2.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAXPR08MB7334:EE_|VI1EUR03FT046:EE_|AS2PR08MB8645:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e01ef8c-ca19-420b-827a-08dabe75cb23 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1iGa4g//88Iq5Gus3ODuEH8GOwFeIeTHWqat3dxB1gYbOowKoXL54guXDzGryaOWrIlArA7xBU8HygQwtlNKM6gFqb034L3O8tbuwJcyWZWWZwns3FH2XOYjh3paFTaDHNosr4JKEBbj++vbf7SEjz+ufcU25SrbZS5dpNNVl2bTb6z6mQ0yqP6uNg1zpzPYkENEyLoDVlAYRijAYfC+dvWIa8A4aNcs0ixIKkrmMUZCACakBKaLuj6C9AYaWUWTbH6VBw9R8ZdSP3oIH4zsbGLdk589C3rcUkJ3WEqB36LEMGfr27iPUGLCayNx/RzQ/ThBCSd/J6wKkZiYWIUjaAKADQhDK2d7pZLNJTHmGlQwGr0WrlVMNGNcxiDkSW8cblzInZTq4KUPXmK5tKxX5fwzUE1JAw4n6iHEEcETf2lf3hBF6B2qO0Lqq24/Y5LhvMkrYzRo00RFFw0QnEX7Xi5yEqdOzBiaPYprPBZb48at3TvSe4eS+hQ/hGRbCqIkp6FeLPfFv0KJ3gpS9mzeuxbsEcB2h2dTPN5MEA3YodNaqZVsAYNU8jNiLpByN6FQ5691iUcEO5OaQjBHqR5GEx+rToVXxYlF6AoxuiNGbwefRMQgiGntsbiXsaJaAHAL2h7pzEIaRG2fGd8Uz2dMhdo1q13t88tPtUe+Lt9fBwdU3MNtkULNj+lD5eLLXvGjIqjoUYOCpLOgQDpLeREz3lpiVTcmnh/YF9uzX71Rr9uAlCpygdzWQ3u0p1ocoQJbNXHCga2hjEfIcLJMKyI25Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(376002)(136003)(366004)(451199015)(38070700005)(26005)(55016003)(33656002)(86362001)(41300700001)(76116006)(8676002)(9686003)(66946007)(66476007)(64756008)(66446008)(66556008)(4326008)(4744005)(186003)(71200400001)(8936002)(5660300002)(7696005)(478600001)(6506007)(316002)(110136005)(54906003)(122000001)(52536014)(38100700002)(2906002)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7334 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 39985229-0a93-48bf-e2c9-08dabe75c5dd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: okVEi5RdLZjh4r/YtbTPcHs1YTOGTuqSfw3ZuDoQKHWqPLTJuxaum/QUS16GQa95jWn3inNIJzSmqipBK6W9ZozNTTGZXQVtXCgP2/H4gbH0MQiQuK4ZEWfZj6RCxRBtXFNwEHV+bN367J7gFjAb82VCwDk3ay7Pq18yk3n0+iVBAy1OWxEDMFb5hY0TwKFfegRZZTloGZrtihCtJh9Xs25xV+EdHbgMyJM33e+8zhilGTMnBND0/NeLZkDOnz/k6qrC2ASeyd8r8L4zjhFsSLxoL7lV0/wEMrIbYlwGMFu3MJtncJ9ed3SSm5YOgLJ5BREmijmgt/EemsTaMUZRIhGzbeDwL9QKJ+aNHvEYLX4QzG1zkhgvXlwnfanUsrz+/iz6eCq1pX9flS/gC9qBn9Rsy1YYKvEu5SC9bgO7t0wXumxQV3p9L4y5hjg02efqYja14AckbpWXTxUh3fEWrOaqc8h1iVGTdqMxV6Mu81JYWgwfF/DVqmmRZh6zT4MMaaWWfhYzglbKI6vhgcOLDq4qjC6IhX/QerG7JS7G3vuBs24e0rE6jFdNV52g+XobD2Eu8WJZcXpNbn4Z0mEvlkCYyYX42wclr2ocDYtqpgEszz2TZJbh5bOVcTTAB0fA5o13IJnLCnv0U7Ni0+fcKo0ABaaU0C8qGPl8DQiVtKb+hocwct3977KH39lxiMglU1tBmRZG2ANMDBseZ6HVoraPj4AMoJNxrWGFD4GhcAek8OUq5YFgWGI87MkQ4D8NjiLtmDoyn/KKw0DLXGeeGg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(39860400002)(346002)(451199015)(36840700001)(40470700004)(46966006)(110136005)(107886003)(316002)(54906003)(82740400003)(6506007)(4326008)(8676002)(7696005)(70586007)(70206006)(478600001)(33656002)(5660300002)(41300700001)(8936002)(40460700003)(52536014)(2906002)(47076005)(336012)(26005)(83380400001)(4744005)(186003)(9686003)(82310400005)(36860700001)(86362001)(356005)(40480700001)(55016003)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 15:03:55.3805 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e01ef8c-ca19-420b-827a-08dabe75cb23 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8645 SGkgUm9nZXIsDQoNClRoYW5rcyBmb3IgdGhlIHBhdGNoZXMsDQoNCj4gU3ViamVjdDogW1BBVENI IGZvci00LjE3IDAvMl0gdmFwaWM6IGZvbGxvd3VwIGZyb20gYXNzaXN0ZWQgQVBJQyBzZXJpZXMN Cj4gDQo+IEhlbGxvLA0KPiANCj4gUGF0Y2ggMSBpcyBhIHBsYWluIGJ1Z2ZpeCBmb3IgYSBmZWF0 dXJlIHdlIGV4cG9zZSBpbiB2aXJpZGlhbiwgd2hpY2ggaXMNCj4ga2luZCBvZiB1bnJlbGF0ZWQg dG8gdGhlIHNlcmllcyBidXQgcGF0Y2ggMiBpbiBpdHMgY3VycmVudCBmb3JtIGRlcGVuZHMNCj4g b24gaXQuDQo+IA0KPiBQYXRjaCAyIGlzIHRoZSBhY3R1YWwgbWVhdCBhbmQgY2hhbmdlcyB3aGlj aCBmZWF0dXJlcyBnZXQgcmVwb3J0ZWQgYXMNCj4gcGFydCBvZiB0aGUgeHsyLH1BUElDIGFzc2lz dCBmbGFnLiAgVGhpcyBpcyBhbiBhdHRlbXB0IHRvIHJlcHVycG9zZSB0aGUNCj4gZmxhZ3Mgc28g d2UgZG9uJ3QgcmVsZWFzZSBhIHZlcnNpb24gb2YgWGVuIHdpdGggYSBzZXQgb2YgZmxhZ3MgdGhh dCB3ZQ0KPiB3aWxsIHRoZW4gZWl0aGVyIHJlbW92ZSBvciB1c2UgdG8gcmVwb3J0IGRpZmZlcmVu dCBoYXJkd2FyZSBmZWF0dXJlcy4NCj4gDQo+IFRoYW5rcywgUm9nZXIuDQo+IA0KPiBSb2dlciBQ YXUgTW9ubmUgKDIpOg0KPiAgIHZpcmlkaWFuOiBzdWdnZXN0IE1TUiBBUElDIGFjY2Vzc2VzIGlm IE1TUiBhY2Nlc3NlcyBhcmUgYWNjZWxlcmF0ZWQNCj4gICBodm0vYXBpYzogcmVwdXJwb3NlIHRo ZSByZXBvcnRpbmcgb2YgdGhlIEFQSUMgYXNzaXN0IG9wdGlvbnMNCg0KRm9yIHRoZSB3aG9sZSBz ZXJpZXM6DQpSZWxlYXNlLWFja2VkLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCg== From xen-devel-bounces@lists.xenproject.org Fri Nov 04 15:04:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 15:04:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437689.692149 (Exim 4.92) (envelope-from ) id 1oqyF5-00005N-3n; Fri, 04 Nov 2022 15:04:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437689.692149; Fri, 04 Nov 2022 15:04:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqyF5-00005G-0R; Fri, 04 Nov 2022 15:04:23 +0000 Received: by outflank-mailman (input) for mailman id 437689; Fri, 04 Nov 2022 15:04:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqyF3-0008WD-UW for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 15:04:21 +0000 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f4876cf2-5c51-11ed-8fd1-01056ac49cbb; Fri, 04 Nov 2022 16:04:20 +0100 (CET) Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2022 08:04:17 -0700 Received: from anantsin-mobl2.amr.corp.intel.com (HELO [10.209.97.57]) ([10.209.97.57]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2022 08:04:16 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4876cf2-5c51-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667574260; x=1699110260; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Jw3Y9otHji7QTX5CGBkw7V4WGp0ZcL6hQNZS7M1jLPk=; b=mjIZuSdqTte5BObNu/vKtSGXcM10v2WcVmjTVr7Ta8O/N2++Y1Hx8JmC 6lsgBorqsAmkaISN9ZUo+Zro7MGys6TXhBGJJRrPpP7bo7ZxMMdOMXtn0 goIAuxSfaI3THfwo4pNtfrsHVtliI0u4bmVGCEIPTlWPzaDEBhhu0xkNK g4L5CgfWJA7i3iooPhOmN5v4ARt0n2+Y8J5NFPIASzcu79+mIbNZ/1efy wCC3h/zmFb6AKvOQWwgnye9Dmo9Y0xI16SGQm42tSRrnQSYt0S8Tr43dR fr/UW/Ael+I+GfZ92V7PSJORuWs7fVEBfxNp3vy+WF28mJ4y8zrBmCyl3 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10521"; a="311726028" X-IronPort-AV: E=Sophos;i="5.96,137,1665471600"; d="scan'208";a="311726028" X-IronPort-AV: E=McAfee;i="6500,9779,10521"; a="698672785" X-IronPort-AV: E=Sophos;i="5.96,137,1665471600"; d="scan'208";a="698672785" Message-ID: <8b5e9d9d-b55b-7af0-7ea7-f7130f6a1886@intel.com> Date: Fri, 4 Nov 2022 08:04:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 3/5] x86: drop 32-bit Xen PV guest code in update_task_stack() Content-Language: en-US To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" References: <20221104072701.20283-1-jgross@suse.com> <20221104072701.20283-4-jgross@suse.com> From: Dave Hansen In-Reply-To: <20221104072701.20283-4-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/4/22 00:26, Juergen Gross wrote: > Testing for Xen PV guest mode in a 32-bit only code section can be > dropped, as Xen PV guests are supported in 64-bit mode only. > > While at it switch from boot_cpu_has() to cpu_feature_enabled() in the > 64-bit part of the code. Acked-by: Dave Hansen From xen-devel-bounces@lists.xenproject.org Fri Nov 04 15:04:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 15:04:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437696.692160 (Exim 4.92) (envelope-from ) id 1oqyFf-0000pK-Cy; Fri, 04 Nov 2022 15:04:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437696.692160; Fri, 04 Nov 2022 15:04:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqyFf-0000pD-AH; Fri, 04 Nov 2022 15:04:59 +0000 Received: by outflank-mailman (input) for mailman id 437696; Fri, 04 Nov 2022 15:04:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqyFe-0008DZ-L6 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 15:04:58 +0000 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0ad3911a-5c52-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 16:04:57 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2022 08:04:55 -0700 Received: from anantsin-mobl2.amr.corp.intel.com (HELO [10.209.97.57]) ([10.209.97.57]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2022 08:04:54 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ad3911a-5c52-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667574297; x=1699110297; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=RaXeA3lCHqq/I4+SahQVZ4hXUivbF7Ar5S6jFlTfNpc=; b=gRUWbSqHDlRm5oITuzJgnH0GsvnevuspJ66nu5+8VKhteC/nyAiusnLb N4mLnxPgLHxs3DC+yD8GgI7qPDa9BXxi9NkmB2pF6GWGmemvcJrwcCFMQ t4CIKN+XMQF4u0I2VkgCPHtqbXDu4wbkCJeKsZjsJIhN0uWuhaYknydgp muPxph29u2Le6V/m+l5lUSrGwpfT5udnGrXURpg4jzgQTtGb8FjgYAwzR ze5hEmGdxQ3c04Id0uBeGZkGjCsgxqyPBc5YcmPJImvn4Isv3nC2HIlGW Yd9r9XWX0Zvpi/q5D3Wao6nYmqFXCRv1dUd3QgX/Y7qJr1DzArzQXXH7x Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10521"; a="307610888" X-IronPort-AV: E=Sophos;i="5.96,137,1665471600"; d="scan'208";a="307610888" X-IronPort-AV: E=McAfee;i="6500,9779,10521"; a="777739712" X-IronPort-AV: E=Sophos;i="5.96,137,1665471600"; d="scan'208";a="777739712" Message-ID: Date: Fri, 4 Nov 2022 08:04:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 4/5] x86: remove X86_FEATURE_XENPV usage in setup_cpu_entry_area() Content-Language: en-US To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" References: <20221104072701.20283-1-jgross@suse.com> <20221104072701.20283-5-jgross@suse.com> From: Dave Hansen In-Reply-To: <20221104072701.20283-5-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/4/22 00:27, Juergen Gross wrote: > Testing of X86_FEATURE_XENPV in setup_cpu_entry_area() can be removed, > as this code path is 32-bit only, and Xen PV guests are not supporting > 32-bit mode. Acked-by: Dave Hansen From xen-devel-bounces@lists.xenproject.org Fri Nov 04 15:50:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 15:50:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437732.692171 (Exim 4.92) (envelope-from ) id 1oqyxv-0000k5-Qz; Fri, 04 Nov 2022 15:50:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437732.692171; Fri, 04 Nov 2022 15:50:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqyxv-0000jy-OA; Fri, 04 Nov 2022 15:50:43 +0000 Received: by outflank-mailman (input) for mailman id 437732; Fri, 04 Nov 2022 15:50:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqyxu-0000iL-AC for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 15:50:42 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6ecdf055-5c58-11ed-8fd1-01056ac49cbb; Fri, 04 Nov 2022 16:50:40 +0100 (CET) Received: by mail-wr1-x429.google.com with SMTP id cl5so7612618wrb.9 for ; Fri, 04 Nov 2022 08:50:40 -0700 (PDT) Received: from [10.85.37.166] (54-240-197-228.amazon.com. [54.240.197.228]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b003b477532e66sm13036117wmq.2.2022.11.04.08.50.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 08:50:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ecdf055-5c58-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=a+sX517KzpQ++DVNKCB8dS7Tc1rlk/IB6W98yNMpu3U=; b=iu6jrbePum2ktWfBAmCCFMHaCV5eKXQZph8MKEjU6IAQN670KvCtMG+bo9766UQr1I BAPWdKCGvkPG8HTHU6npgpeMOom2g0/aXzBYpcJcN1xWZk9tnb7B/tCLVLPGFHncv+H3 yu3gNjR5libQ82GzGXvJCEwTvv6J/1pa4Ig13cauWwxBptavyZoBTbGMlAmti3KAcPSI HyhJ71z1tCrSdbA+YqC0HuRyp9Fnahj/tTj5C9u0Xu06MRZpmeAWcvec+Zx3qjpoOen8 3UptlycN/OHoY5pbecITodUYxb/h8h6KniyCDhUY6iydsFQl16IKpLzCO4DCE8a7hwUp qMvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a+sX517KzpQ++DVNKCB8dS7Tc1rlk/IB6W98yNMpu3U=; b=J2PslVSdJqeIyk6j7rgYeuQa4EYyvfjVLA/Jx+29pl3GhZG9gT1ieMdShwh6IZr7Qz lhXDqNDsqLNFSTbmRUxL8zlmSnILcBPriIm7ZajErtCD1wjVgWsYYg1UPtDbZlMmOVxD dxAdj0MPS+yqu8BLaax4gH49HSOg/sZIgxqYcY06/9qVz3NwMicV3wkjkLbsxj5ZM2nw I8ffniu/nDdB5A+1ZvenTXC2R94KgIuyqNfObG2G44hAaLsgL9SsHCopy4MmJQllF3xq nWK6ySCQBHWazF9nT1sl2p/QgrvBhMfNIi1DIsMcFw0y+0vHZjLFNHmSQ+Gzd8tWmgsx WGxQ== X-Gm-Message-State: ACrzQf1aDCfYuAi/6z6Z/S/C7d0yz/AfNnIFjV1lU1jMk97Mtq45BIEu ePYknrzpXJfE31BP7OdQBjY= X-Google-Smtp-Source: AMsMyM4EZ9+gSF3Yo6FxXNy8Rf/sJE0jCEUjqda7OkzUJ+hzZM8maptFtPsddbm78nEXv3Lli3mU7w== X-Received: by 2002:a05:6000:18aa:b0:238:3cb3:1a1d with SMTP id b10-20020a05600018aa00b002383cb31a1dmr7024830wri.409.1667577040049; Fri, 04 Nov 2022 08:50:40 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <0ad753a4-2876-88a5-c0be-9f917283e61b@xen.org> Date: Fri, 4 Nov 2022 15:50:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 1/2] viridian: suggest MSR APIC accesses if MSR accesses are accelerated To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Wei Liu , Jan Beulich , Andrew Cooper References: <20221104142235.36556-1-roger.pau@citrix.com> <20221104142235.36556-2-roger.pau@citrix.com> Content-Language: en-US Organization: Xen Project In-Reply-To: <20221104142235.36556-2-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 04/11/2022 14:22, Roger Pau Monne wrote: > The "APIC register virtualization" Intel hardware feature applies to > both MMIO or MSR APIC accesses depending on whether "virtualize x2APIC > mode" is also available. > > As such also suggest MSR APIC accesses if both "APIC register > virtualization" and "virtualize x2APIC mode" features are available. > I'm having trouble reconciling that with the logic below... > Fixes: 7f2e992b82 ('VMX/Viridian: suppress MSR-based APIC suggestion when having APIC-V') > Signed-off-by: Roger Pau Monné > --- > xen/arch/x86/hvm/viridian/viridian.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c > index 25dca93e8b..c4fa0a8b32 100644 > --- a/xen/arch/x86/hvm/viridian/viridian.c > +++ b/xen/arch/x86/hvm/viridian/viridian.c > @@ -197,7 +197,11 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, > res->a = CPUID4A_RELAX_TIMER_INT; > if ( viridian_feature_mask(d) & HVMPV_hcall_remote_tlb_flush ) > res->a |= CPUID4A_HCALL_REMOTE_TLB_FLUSH; > - if ( !cpu_has_vmx_apic_reg_virt ) > + /* > + * Suggest x2APIC mode by default, unless xAPIC registers are hardware > + * virtualized and x2APIC ones aren't. > + */ > + if ( !cpu_has_vmx_apic_reg_virt || cpu_has_vmx_virtualize_x2apic_mode ) This means APIC register virt *not* available or virt x2apic *is* available. Is the latter gated on the former? Paul > res->a |= CPUID4A_MSR_BASED_APIC; > if ( viridian_feature_mask(d) & HVMPV_hcall_ipi ) > res->a |= CPUID4A_SYNTHETIC_CLUSTER_IPI; From xen-devel-bounces@lists.xenproject.org Fri Nov 04 15:56:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 15:56:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437736.692181 (Exim 4.92) (envelope-from ) id 1oqz3B-0001yt-EX; Fri, 04 Nov 2022 15:56:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437736.692181; Fri, 04 Nov 2022 15:56:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqz3B-0001ym-Bi; Fri, 04 Nov 2022 15:56:09 +0000 Received: by outflank-mailman (input) for mailman id 437736; Fri, 04 Nov 2022 15:56:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqz3A-0001yg-4g for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 15:56:08 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2b922e14-5c59-11ed-8fd1-01056ac49cbb; Fri, 04 Nov 2022 16:55:57 +0100 (CET) Received: by mail-wm1-x335.google.com with SMTP id p13-20020a05600c468d00b003cf8859ed1bso3454372wmo.1 for ; Fri, 04 Nov 2022 08:55:57 -0700 (PDT) Received: from [10.85.37.166] (54-240-197-228.amazon.com. [54.240.197.228]) by smtp.gmail.com with ESMTPSA id d14-20020adffbce000000b0022cbf4cda62sm4489730wrs.27.2022.11.04.08.55.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 08:55:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b922e14-5c59-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=qZ7caN2ZrMloq+8jcSpHLFrKEnKM6MrLRtzEsAg/5go=; b=clYaVWmcpHa3ahKI1Eeays+S3pOLvwUCujGkwbf6pmY22TlQL7MsuMKMMCAXiVi/5o N5cbSfe1YfzOFOXJC1E4znFHh6TQrlAJ6W+jXk5VqYs4J8xB3GqixnsdKp6VlvfrZAWt NrDhxf1Ls4+cGbDYVwNCFkTp8u63H0EbdJg5QMzo5YP91jiNBTg2+VkLKJoQkE8ct5IG WiO39LB3KjXe6xyN/IDmmIznBL7RGiXe3oMHH3UxYaqeBUP2LCL5K9NIbXDK1mnbggPt gtoF70fDtYeOKp6OovBO+j3T6wChlCGuJ0E5tHvKXuUQFDXeWo+izW9bpYuGeIKFJvdx KQCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qZ7caN2ZrMloq+8jcSpHLFrKEnKM6MrLRtzEsAg/5go=; b=u98XvcNia4IjYFNC6vsDiapYpO/nMcrsSLQoDWV+OFoGGe4/SfldFDqkXgYu+GACik EN5hl9u3HYu7PDm2DPYZzld4a35wwNFJDQKK/UaMYGbOWeUcVFgS6KHEC9ACdqIymOGL AAQFJwrJ3Pocqfb13xOwk6l6VPfdMlh3aD4Zof/qQkdwdgH5QG9osn7qxs8omKnpa5mz yKB362qTkLN1xmraQ2HU/la1wpCVgMkjMJfYSt1WG4oom5W6OyO2lRNWV+uubmKqg4iU VQ9nofsHAG0Zq1uAnnT9OehC71idQH9/yiKQ6Br87AsKhclbB0axjbdkq4CAOZ/WHOIQ w5ow== X-Gm-Message-State: ACrzQf3cQYu4eEZTiC33HqkzxzgWL0r4dJGfhsGr55+s0Oc+cj3gzNLB hxb6RIwsWHyV2lXtJqxe080= X-Google-Smtp-Source: AMsMyM73IQCiLlmfiQdki4N5PDimEKpFXYN6AK/X2nDCnHgjNIM70Wz9iBsvYWC10uNMtxz5yjVTzw== X-Received: by 2002:a1c:f60d:0:b0:3be:708b:c96c with SMTP id w13-20020a1cf60d000000b003be708bc96cmr34895984wmc.168.1667577356765; Fri, 04 Nov 2022 08:55:56 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <2a3c5141-516d-a5e4-392b-e7fe54f3781c@xen.org> Date: Fri, 4 Nov 2022 15:55:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 2/2] hvm/apic: repurpose the reporting of the APIC assist options Content-Language: en-US To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Wei Liu , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian References: <20221104142235.36556-1-roger.pau@citrix.com> <20221104142235.36556-3-roger.pau@citrix.com> Organization: Xen Project In-Reply-To: <20221104142235.36556-3-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 04/11/2022 14:22, Roger Pau Monne wrote: > The current reporting of the hardware assisted APIC options is done by > checking "virtualize APIC accesses" which is not very helpful, as that > feature doesn't avoid a vmexit, instead it does provide some help in > order to detect APIC MMIO accesses in vmexit processing. > > Repurpose the current reporting of xAPIC assistance to instead report > such feature as present when there's support for "TPR shadow" and > "APIC register virtualization" because in that case some xAPIC MMIO > register accesses are handled directly by the hardware, without > requiring a vmexit. > > For symetry also change assisted x2APIC reporting to require > "virtualize x2APIC mode" and "APIC register virtualization", dropping > the option to also be reported when "virtual interrupt delivery" is > available. Presence of the "virtual interrupt delivery" feature will > be reported using a different option. > > Signed-off-by: Roger Pau Monné > --- > I find the logic in vmx_vlapic_msr_changed() hard to follow, but I > don't want to rewrite the function logic at this point. > --- > xen/arch/x86/hvm/viridian/viridian.c | 2 +- > xen/arch/x86/hvm/vmx/vmcs.c | 8 ++++---- > xen/arch/x86/hvm/vmx/vmx.c | 25 ++++++++++++++++++------- > xen/arch/x86/traps.c | 4 +--- > 4 files changed, 24 insertions(+), 15 deletions(-) > > diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c > index c4fa0a8b32..bafd8e90de 100644 > --- a/xen/arch/x86/hvm/viridian/viridian.c > +++ b/xen/arch/x86/hvm/viridian/viridian.c > @@ -201,7 +201,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, > * Suggest x2APIC mode by default, unless xAPIC registers are hardware > * virtualized and x2APIC ones aren't. > */ > - if ( !cpu_has_vmx_apic_reg_virt || cpu_has_vmx_virtualize_x2apic_mode ) > + if ( !has_assisted_xapic(d) || has_assisted_x2apic(d) ) So, not sure why this is separated from patch 1 but stated this way it seems counterintuitive. We only want to use the viridian MSRs if they are going to be more efficient.. which I think is only in the case where we have neither an x2apic not an assisted xapic (hence we would trap for MMIO). Paul > res->a |= CPUID4A_MSR_BASED_APIC; > if ( viridian_feature_mask(d) & HVMPV_hcall_ipi ) > res->a |= CPUID4A_SYNTHETIC_CLUSTER_IPI; From xen-devel-bounces@lists.xenproject.org Fri Nov 04 16:02:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 16:02:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437743.692193 (Exim 4.92) (envelope-from ) id 1oqz96-000408-8O; Fri, 04 Nov 2022 16:02:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437743.692193; Fri, 04 Nov 2022 16:02:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqz96-000401-4M; Fri, 04 Nov 2022 16:02:16 +0000 Received: by outflank-mailman (input) for mailman id 437743; Fri, 04 Nov 2022 16:02:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqz95-0003zv-Nt for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 16:02:15 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0ac31687-5c5a-11ed-8fd1-01056ac49cbb; Fri, 04 Nov 2022 17:02:13 +0100 (CET) Received: from mail-bn1nam07lp2045.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Nov 2022 12:01:53 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM6PR03MB5193.namprd03.prod.outlook.com (2603:10b6:5:241::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 16:01:49 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 16:01:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ac31687-5c5a-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667577733; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=VkbPIL7eqP3CS0NPZl9NVAct9MCdv4M0mLZsnmutxS4=; b=UnjbaN0xhid1+aMmlbeD8ohmBytCxzG7iy6rJVj1VdujAFl9RVMLJ2n+ nGM17jfUvGwB6CUdBnUS51skxDKy0iWHG5Ne19Kg0s5DWlXcddkOIydyJ GVH7C9YkxG8iyJ1tAB1Bv6Z48qi2V9wzlA2x5Y7VaKm7doL3ytlZ/ROF/ E=; X-IronPort-RemoteIP: 104.47.51.45 X-IronPort-MID: 84615033 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:9AUErKm+gBcIEZYoAX/FKdvo5gx9J0RdPkR7XQ2eYbSJt1+Wr1Gzt xJKXmmGP/3bMWamL4tya4uxoUIG7ZaByNRiGgU9qiFgFiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5AOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 fElOisKSy+nu9i/2LilZtVqoNYnK/C+aevzulk4pd3YJdAPZMiZBo/svJpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVU3jOWF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efwX2iBdpJT9VU8NZ2oR7N2VwDSyRPFkmcuOnnqEWPdfN2f hl8Fi0G6PJaGFaQZsn0Uxy9r3iFvTYTXtNRF6sx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9W9aX+b7KbSkjq0NgAcN2pEbigBJSMa5/HzrYd1iQjAJv5hGqOoitz+GRnr3 iuH6iM5gt07j9MNkaOy/lnFgjeljpnPUgMxoA7QWwqN7Q5nZYjje42h73Da6+pNKMCSSVzpg ZQfs82X7eRLB5fUkiWIGLoJBOvxu6vDNyDAi1lyGZVn7y6q53OoYYFX5nd5OVttNcEHPzTuZ Sc/pD9s2XOaB1PyBYcfXm57I517pUQ8PbwJjszpU+c= IronPort-HdrOrdr: A9a23:aqN4F6MTA3Ov38BcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa Dsr/au4FGbCAcqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPwf2F mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0amSwWdvtO OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7tvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K VXm0qEqpt+F3r77WvAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa VT5fnnlbdrmG6hHjDkVjEF+q3uYp1zJGbKfqE6gL3a79AM90oJjXfxx6Qk7wI9HdwGOtx5Dt //Q9RVfYF1P7ErhJ1GdZY8qOuMexvwqEH3QRSvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d 78bG8= X-IronPort-AV: E=Sophos;i="5.96,137,1665460800"; d="scan'208";a="84615033" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NqqPRBp2zxx4MQwVEbh/g4Qq7Vaa1vQOS8XZjCvHPbTWl5xZT0Dbzq+10aMpM+9FdMaT90+ERbzcG5I5OT79q+1R/1ma0+kBDj3bXJ3H4PDQ5RGJHnQ/JdQMGv9NlySWexzzlLO9z96QwOjjDgSo6ZOivAjaTSiswpYe8vGG+lvOx6U0aDeWrapAUTLNy8ch7rd482t/5FkPugBHoxlG6EL7KgK6XG8Tl1861jiAqXBLBgxyf+GO93dAFva+XOapi0ALRUhICXjhedr+pq+5ytcAZa66Sw9x5RcjEO6biEP+WUEmMWrM2uoWVLfRQCEykbmFG6qQpjllJh/zT4H4Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DdADsRAL26iqXpbjPknC6YkRukOhKl7sqTPpsiKisxg=; b=CVu2WNdnLhTIUAWuQAYY48Hp5yHUo49KdW1T2exNaM4Xq+f/yTTyiHTsUlMPbEEga3PdtvEnJDzW+WW9Zt/p7LyyZYuvbBDR5Xl20SWoYy7lrwynw/LlwMW4XwFad61K3Gk6pJk1+vTeQdGKF7V4/5R63q/TAzGUR81lW1IFn87UcYqAlKt5CeW4PTkUTuFIFoTrR99pd0WTv36wMhiKHLJZrU59sofEKRXBOqgeoZ+ZvARKib39p9+UPBGVTUfOOB5VwZLGyujG+TLwuRwKTO6f0Z0uKOuXIeg3kVVBL+6JDUychw0Hu1W3XRwvG74Fp8oxKCsKSFq2yjVwh9zgQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DdADsRAL26iqXpbjPknC6YkRukOhKl7sqTPpsiKisxg=; b=LmDgRW48fco6hF97Umedjy1BGWq0aALigNPqA/bPCQKVpbaFo5a/v8rHeKo4ociiNJEix/cOBrdZIfnOc96DZIRvo7LmdN/q0XGtK6VSELTcGTdHFSvTAUMGjelzBBB3RqfpQqbYasjz6RwWt8NLweAOciw2dxjzEUFPsl8iV2c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 4 Nov 2022 17:01:41 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Paul Durrant Cc: xen-devel@lists.xenproject.org, Henry.Wang@arm.com, Wei Liu , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian Subject: Re: [PATCH for-4.17 2/2] hvm/apic: repurpose the reporting of the APIC assist options Message-ID: References: <20221104142235.36556-1-roger.pau@citrix.com> <20221104142235.36556-3-roger.pau@citrix.com> <2a3c5141-516d-a5e4-392b-e7fe54f3781c@xen.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2a3c5141-516d-a5e4-392b-e7fe54f3781c@xen.org> X-ClientProxiedBy: LO4P265CA0231.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::17) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB5193:EE_ X-MS-Office365-Filtering-Correlation-Id: 76af45c9-0f4f-452c-f105-08dabe7de19a X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 967L2XouYHcjU9bsqvgPGbjWKyo8vRoNLNDWRSvIc6TCt+a/2JDlLblzIDWC6MDKcwdSsFC1pdZE572HVsPafjQgJAmfMPYh3Zh4jbjSFyWfv5WgsaAYDgaN0Sw3FDUiT3x5vkinCMXFtsVFlmw0gKzwkzTXwJXiWRraolL+LI4umGYOh8wkMhcduxNKECZ8njQfN1GphK5mS21ESVBEYdCqcZ1Do2WuPdMuKNHlYfLJQ75jVx47uoVK41g7m/BD+C//3ujA5hEATf7XpOwrxzBKmzo30K8Ko7Otva2bIL2hKsGTjqH31mR4gkxsFi0v966gLgj/WI5kg9PoYTBTiRZYACdWCkWAPrKNCfve1DN287L88PYPrGi09U+J10zFg5hbTHAsOivUmZvlnetF76AiiyICRJge7oNqS7DwxgRNr7uOWyHx2e52wzI0JD1lbQybsplAt2eOTTqcc/JebHsbjcGS9aIGAloekjaGZAQ0br8zb7p4V7jn0jp/2faoHoSajZU9Z2iDV6PbgXuAsJDse4ZMq7SOOuOtuJBsBRu5uEgoI82+xKBfyHCCe9DbwnRZ/QbKVII0C64THOcm60E/K/f+jCi5nzSzYBkPwtwtjqClJms11Owegu8MrGOWwoeU93NjpIYex/ty5U4yfND3n8SaAsctqq44K474sv9VlXyMdKPamr/ErcWVtaqtTm9P2pT8909eJTTKbqT/ZA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(346002)(376002)(39860400002)(396003)(366004)(136003)(451199015)(6506007)(316002)(9686003)(86362001)(8936002)(83380400001)(5660300002)(186003)(85182001)(2906002)(66556008)(66946007)(53546011)(66476007)(8676002)(41300700001)(6512007)(26005)(4326008)(33716001)(478600001)(6486002)(6666004)(38100700002)(6916009)(82960400001)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzBnRk16dlN5Vm9mU3h4U3NieUttYkZpZlJ6QnJuM01HdndPQ0FDRzJLSkhy?= =?utf-8?B?NWtTNUY4eVhFZndwNVNoMzZBaHcwYm1nWFhHeW1BU1Y3S0hWNnlkbXdLYS92?= =?utf-8?B?dVBEV1YxdkdycGNEeTlBcVNLdjRGZGJ1aSszTDRiU0srNGN1SVFpQXUwdHRp?= =?utf-8?B?KzZPanQrYUFnZXlja3ZlK3J2MlR0K1ArYzg3RFc3L0szUkZVVDluT1dya2hx?= =?utf-8?B?L20rNm1JMTBOQlp5NHNxTEE3NXM5UEJhbWJnMTUzcEFTMzVjK3NCVzU1b0ZS?= =?utf-8?B?RFR0WTh3RWV0Lys3MEhuMGdEMGlrM1VvTEFlNWlvZ2tuUXlVSXdRbTliU2lH?= =?utf-8?B?c3FOTDlnbG5qZ0VOV0NlRjlCd0phdkZabWY4SC80L3R4V09NSlowR1JhdU4w?= =?utf-8?B?ejYwQlc5SDJDM3NDNXVPWEhDZ0xCa21vZlE2aGJKMWQ4WEVDOUlPZzJESk5p?= =?utf-8?B?SkY4Tk8rNFhOT3NLR05VYkRtY1VxeUZTZWt3N25uQWExZnRpL01VU3I4R3l3?= =?utf-8?B?QUhsR1VOTVdMYWZtVGpTc014c3J1WUVOdCt6eks5enVUbnJXN3NWamo5SEhG?= =?utf-8?B?WFBXenlvR2hyTWgzYkljWm5pTytPbXlLeUpJdHR2ZDdLS2ZBbUJKQ0RMNC9G?= =?utf-8?B?WkgvQlN6OU0rTG4vdG90MHJ5TjA2YWZwTWlnbkptVUpUYnFnU1padzdnVHls?= =?utf-8?B?cWw0dXAvTmFzS2J2b1FVNVF5TGQyd3FaTXhGZVpQUGsyOWl6RlU1OWd5K2lC?= =?utf-8?B?Q1c2OXVRcU5tRmozSVhicG1sODFQVlp5MHlNTTV2S2s2ZmhNQ0l0Vm1QbW5C?= =?utf-8?B?UFRScXJpRklBRWNEMHA2Z3J1b1hqMEFQQ2M1Wmx6aVdXQVUwVnFDMklEazVv?= =?utf-8?B?elNuWlFoV3ZEZTJsRm03dzJMYkJLSk9STW51WlV5Zm1SUTgzbjRWblFhblY4?= =?utf-8?B?V0paazhIaWxaaVVpaUpJNEpTWWVEZDd3bW1TQW5VejZiMFZJMSt3YWNUMFFY?= =?utf-8?B?SUh4QmNTUThRNjZjc1BsTVFqQml4WTNzVlNoNFRGaXhVNkN4ZHdLT05VYXNU?= =?utf-8?B?dXdSTVZNKytmS0wzQU53U1ZYcjRsWWhvRkJabDdWQ1BuY21EcG5PaEp2VjNa?= =?utf-8?B?ZTlRUXgyMVppWmZoQWtpSUExVXNSUG5oQjRZZ1ZPSVdMODNuQ3YyeTZESXpk?= =?utf-8?B?VWpBVlZnT0plWEJlSDFpRU1iZ0p5YVowYmRDTGRrbllnYlROZE1lZzFQNUtJ?= =?utf-8?B?bnpiem1UM0V2NnNoYS9jZHVVNWFwQVdFdmhkSlgvUzd6bWlybFpTTHVobUFL?= =?utf-8?B?MmdNYjFYZkJTY3lQRSswYWlWNFRLbUNVbUJkS2wxVXd4TFdIb1J1TkNHZHZh?= =?utf-8?B?bGxLM1Q3S1ZYdUZRTEpSRXRST2RCTlpENWpHOU9pS1B5S013R2xQLzlKTVIz?= =?utf-8?B?cDdKTlR4R0RDYlBYanNKbzhRZDFBVDVSTTB6NlVsWkFuZi8vWm16NjVBOGRp?= =?utf-8?B?RHlCWGl5andrSXE5b0RMOWoxRW93bU10UHNuK1FXdjBRZFhDdTJSbHlvR21X?= =?utf-8?B?Skt5WWxYTzRJZlBHRDY2V2xnUlpUT1l5ZmlNRkpUaWMzWWI3bmxIQWVPYXhu?= =?utf-8?B?U1NOTlNXQlY3dkVpaURGRkMxV3N2bUtDMzdLQTFieWc4SGhad1dQcTREbjk5?= =?utf-8?B?ZEVUdmVpNUxtTVV2ajQ5dFlBK2VkeGZXUWRETGtGTm1Hak5yY0t0MmRzMlRM?= =?utf-8?B?bDZId0hqRXNLQzFDQVpJYk8xc293bFFPdVVYdE4yTzQyaGFEbVA4NVNaSk1T?= =?utf-8?B?N0RDRGsxT1JUbk12QUUxSTQ0NVlzWjBNaE1BaGVHVWpxSWpLSzR3N1JyRW11?= =?utf-8?B?eTVHMnBSOTRoN09VbHc2WkhhZVlQcmNPN2o0R1ZhVWpHUmRaeFQzV3QrZUhH?= =?utf-8?B?R1B3akNNL0NFWXJWdUpTenc2eVBJM1hWWDNCY3pvZG1wVFZ2TWtGRVBYMUFW?= =?utf-8?B?RUtHOFZlbGJ0U2hwZjJuUStSMzN4Vy9YdDMrVSs3UktDYjNOcHZWbEdDeEpi?= =?utf-8?B?UVdxa1FsY3lYQS9jY0NacWh0WjJXQjFCTU1lc21NU0ZwSUVnMkZyR2RXWlFl?= =?utf-8?Q?j/n6X3JZYKlXPaijNbO2B7HDK?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76af45c9-0f4f-452c-f105-08dabe7de19a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 16:01:49.4219 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uATGNShFgOivSRXDxCUkaTgedvDlf8Fyt5O3p95FiU5N/sTEuF4z9xuce5Nc2l3icKc6PKGSTy48LQDAPGw10Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5193 On Fri, Nov 04, 2022 at 03:55:54PM +0000, Paul Durrant wrote: > On 04/11/2022 14:22, Roger Pau Monne wrote: > > The current reporting of the hardware assisted APIC options is done by > > checking "virtualize APIC accesses" which is not very helpful, as that > > feature doesn't avoid a vmexit, instead it does provide some help in > > order to detect APIC MMIO accesses in vmexit processing. > > > > Repurpose the current reporting of xAPIC assistance to instead report > > such feature as present when there's support for "TPR shadow" and > > "APIC register virtualization" because in that case some xAPIC MMIO > > register accesses are handled directly by the hardware, without > > requiring a vmexit. > > > > For symetry also change assisted x2APIC reporting to require > > "virtualize x2APIC mode" and "APIC register virtualization", dropping > > the option to also be reported when "virtual interrupt delivery" is > > available. Presence of the "virtual interrupt delivery" feature will > > be reported using a different option. > > > > Signed-off-by: Roger Pau Monné > > --- > > I find the logic in vmx_vlapic_msr_changed() hard to follow, but I > > don't want to rewrite the function logic at this point. > > --- > > xen/arch/x86/hvm/viridian/viridian.c | 2 +- > > xen/arch/x86/hvm/vmx/vmcs.c | 8 ++++---- > > xen/arch/x86/hvm/vmx/vmx.c | 25 ++++++++++++++++++------- > > xen/arch/x86/traps.c | 4 +--- > > 4 files changed, 24 insertions(+), 15 deletions(-) > > > > diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c > > index c4fa0a8b32..bafd8e90de 100644 > > --- a/xen/arch/x86/hvm/viridian/viridian.c > > +++ b/xen/arch/x86/hvm/viridian/viridian.c > > @@ -201,7 +201,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, > > * Suggest x2APIC mode by default, unless xAPIC registers are hardware > > * virtualized and x2APIC ones aren't. > > */ > > - if ( !cpu_has_vmx_apic_reg_virt || cpu_has_vmx_virtualize_x2apic_mode ) > > + if ( !has_assisted_xapic(d) || has_assisted_x2apic(d) ) > > So, not sure why this is separated from patch 1 but stated this way it seems > counterintuitive. We only want to use the viridian MSRs if they are going to > be more efficient.. which I think is only in the case where we have neither > an x2apic not an assisted xapic (hence we would trap for MMIO). I've read the MS HTLFS and I guess I got confused, the section about this CPUID bit states: "Bit 3: Recommend using MSRs for accessing APIC registers EOI, ICR and TPR rather than their memory-mapped" So I've (wrongly) understood that MSRs for accessing APIC registers was meant to be a recommendation to use x2APIC mode in order to access those registers. Didn't realize Viridian had a way to expose certain APIC registers using MSRs when the APIC is in xAPIC mode. I withdraw patch 1 and adjust patch 2 accordingly then. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Nov 04 16:05:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 16:05:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437747.692204 (Exim 4.92) (envelope-from ) id 1oqzBu-0004ah-Lh; Fri, 04 Nov 2022 16:05:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437747.692204; Fri, 04 Nov 2022 16:05:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqzBu-0004aa-Ir; Fri, 04 Nov 2022 16:05:10 +0000 Received: by outflank-mailman (input) for mailman id 437747; Fri, 04 Nov 2022 16:05:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqzBt-0004aS-He for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 16:05:09 +0000 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [2a00:1450:4864:20::42e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 741981ff-5c5a-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 17:05:08 +0100 (CET) Received: by mail-wr1-x42e.google.com with SMTP id g12so7654483wrs.10 for ; Fri, 04 Nov 2022 09:05:08 -0700 (PDT) Received: from [10.85.37.166] (54-240-197-228.amazon.com. [54.240.197.228]) by smtp.gmail.com with ESMTPSA id n14-20020a5d4c4e000000b0023691d62cffsm3718446wrt.70.2022.11.04.09.05.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 09:05:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 741981ff-5c5a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=7YytsVV4aUSxXUuq0yIyu0RGlEmPxzcC2ujSuhbEbUU=; b=i2htBtWoP9sGrr4JbSyXOEBtJKYSwgFByS1l5w3snQ5V4E5Fy93JuMuL1AJB8tiU42 jk6+1SQkkB/52dhGwXZVVsdHTuyLBNffN7H8LK7YjqxZTiGkdxzmgBA9ymkoYBNV2MfJ 83WXVMO4QRTjw/2RQv8fu6KSlPGygl48o8oZyNd2nJ6V0VIuQEhqtXL8B3ODVLnRsX6s 1hKrZXS4gbe9WNKn5/xpfSrz7PjkNW4lJ7g/4PzbnVf7j2cm7vtHUYfhL5ZUhPKG05HF mHq839W6P7yBJKEc2cb7sDYNKpKCZSz/9eZKrPGS3lm6rnVmDwKD5qI2vvDYCkLtsBqa lh6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7YytsVV4aUSxXUuq0yIyu0RGlEmPxzcC2ujSuhbEbUU=; b=vg4q7i2S9oi9st0LEw+B971LBqi3g+KTfy3Z4gv5kaLNn6KwLR7lo9sjiz00g+XsdI K1/wqbVjeVc1fJth1EO5ORkwKZ/UmfwERMHUsMwWVznfLstLEsGL9fnOcm3cUz1eSI8N F+zXfifMKroO33EmgnIxFrBTbydvZugb2TdViiBnO4Cwxmd6Q2SPE2vpa5Yrdl4JFGQp hCCCikm65RfcTL1b+4AfgTjSSwVOuT8EDjJYoKpx3aSfLvH3zXe+5jUPQDTuwJ+R/FTC 4YkWg+bNYscUZanyazBdG+Iju2/a0fejprEk6JqPlMYJbRlCXeXk4zk4sT5Y4w3/jjGt XSCg== X-Gm-Message-State: ACrzQf1SgSvOi6Pir8lTTbFhy7UoC7gPROMWt1ie4rpvf7lroJRJpQuc /bb6l6FZf8Uazf78ZpWlRzM= X-Google-Smtp-Source: AMsMyM4yzn3zm7FTAxEJ/R39XJuDKdRjS7tFKu+7Ho0GclzYJaMZMqUDApuK8Pum7do0zqMl0eUC1g== X-Received: by 2002:adf:e90d:0:b0:236:7129:d7e6 with SMTP id f13-20020adfe90d000000b002367129d7e6mr23561149wrm.398.1667577907943; Fri, 04 Nov 2022 09:05:07 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <9a505567-57be-a7b4-7cab-d1d737172db0@xen.org> Date: Fri, 4 Nov 2022 16:05:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 2/2] hvm/apic: repurpose the reporting of the APIC assist options Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, Henry.Wang@arm.com, Wei Liu , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian References: <20221104142235.36556-1-roger.pau@citrix.com> <20221104142235.36556-3-roger.pau@citrix.com> <2a3c5141-516d-a5e4-392b-e7fe54f3781c@xen.org> Organization: Xen Project In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 04/11/2022 16:01, Roger Pau Monné wrote: > On Fri, Nov 04, 2022 at 03:55:54PM +0000, Paul Durrant wrote: >> On 04/11/2022 14:22, Roger Pau Monne wrote: >>> The current reporting of the hardware assisted APIC options is done by >>> checking "virtualize APIC accesses" which is not very helpful, as that >>> feature doesn't avoid a vmexit, instead it does provide some help in >>> order to detect APIC MMIO accesses in vmexit processing. >>> >>> Repurpose the current reporting of xAPIC assistance to instead report >>> such feature as present when there's support for "TPR shadow" and >>> "APIC register virtualization" because in that case some xAPIC MMIO >>> register accesses are handled directly by the hardware, without >>> requiring a vmexit. >>> >>> For symetry also change assisted x2APIC reporting to require >>> "virtualize x2APIC mode" and "APIC register virtualization", dropping >>> the option to also be reported when "virtual interrupt delivery" is >>> available. Presence of the "virtual interrupt delivery" feature will >>> be reported using a different option. >>> >>> Signed-off-by: Roger Pau Monné >>> --- >>> I find the logic in vmx_vlapic_msr_changed() hard to follow, but I >>> don't want to rewrite the function logic at this point. >>> --- >>> xen/arch/x86/hvm/viridian/viridian.c | 2 +- >>> xen/arch/x86/hvm/vmx/vmcs.c | 8 ++++---- >>> xen/arch/x86/hvm/vmx/vmx.c | 25 ++++++++++++++++++------- >>> xen/arch/x86/traps.c | 4 +--- >>> 4 files changed, 24 insertions(+), 15 deletions(-) >>> >>> diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c >>> index c4fa0a8b32..bafd8e90de 100644 >>> --- a/xen/arch/x86/hvm/viridian/viridian.c >>> +++ b/xen/arch/x86/hvm/viridian/viridian.c >>> @@ -201,7 +201,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, >>> * Suggest x2APIC mode by default, unless xAPIC registers are hardware >>> * virtualized and x2APIC ones aren't. >>> */ >>> - if ( !cpu_has_vmx_apic_reg_virt || cpu_has_vmx_virtualize_x2apic_mode ) >>> + if ( !has_assisted_xapic(d) || has_assisted_x2apic(d) ) >> >> So, not sure why this is separated from patch 1 but stated this way it seems >> counterintuitive. We only want to use the viridian MSRs if they are going to >> be more efficient.. which I think is only in the case where we have neither >> an x2apic not an assisted xapic (hence we would trap for MMIO). > > I've read the MS HTLFS and I guess I got confused, the section about > this CPUID bit states: > > "Bit 3: Recommend using MSRs for accessing APIC registers EOI, ICR and > TPR rather than their memory-mapped" > > So I've (wrongly) understood that MSRs for accessing APIC registers > was meant to be a recommendation to use x2APIC mode in order to access > those registers. Didn't realize Viridian had a way to expose certain > APIC registers using MSRs when the APIC is in xAPIC mode. > Yeah, I think they predate the existence of x2apic. > I withdraw patch 1 and adjust patch 2 accordingly then. > Cool. Thanks, Paul From xen-devel-bounces@lists.xenproject.org Fri Nov 04 16:10:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 16:10:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437755.692215 (Exim 4.92) (envelope-from ) id 1oqzHO-0006dx-9z; Fri, 04 Nov 2022 16:10:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437755.692215; Fri, 04 Nov 2022 16:10:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqzHO-0006dq-6W; Fri, 04 Nov 2022 16:10:50 +0000 Received: by outflank-mailman (input) for mailman id 437755; Fri, 04 Nov 2022 16:10:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqzHM-0006dk-Ac for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 16:10:48 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c672561-5c5b-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 17:10:46 +0100 (CET) Received: from mail-dm6nam04lp2047.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Nov 2022 12:10:33 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BN9PR03MB6155.namprd03.prod.outlook.com (2603:10b6:408:100::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.23; Fri, 4 Nov 2022 16:10:31 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 16:10:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c672561-5c5b-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667578246; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=pzPHuvT+gFToZPLxFRYmd8AHyt5tNy7Nam6SS9PwgXk=; b=AbX4CaO2y+Po39+xIr4agEhGXjXeappTR9jtN8Www1dpIYkv7yjVgUN9 Iz5wWI4tB1E6SJaO/IZyzPB0JOYBVLewdcuUxaM95c441cjAUtdXGxnbF XiVT5f8dB5IPpT0htf7MxQzjAlAywjRTmTjwuXzMNDpHZcj3WLvIQZ8+1 g=; X-IronPort-RemoteIP: 104.47.73.47 X-IronPort-MID: 83273738 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:6LEugqCVc09j4RVW/9Tiw5YqxClBgxIJ4kV8jS/XYbTApDhx3zFVx 2NKD22Bb/3bZGH9Lo0gYYWxpxlSuZ6EyIdnQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpA4gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwq7tvQnhT5 +0jGQsIUEqFpsuk7u3lRbw57igjBJGD0II3nFhFlW2cIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK/uxrvAA/zyQouFTpGMDSddGQA91cg26Tp 37c/nS/CRYfXDCa4WreqC332bSf9c/9cNxPH63p7+w0uVKK6WpUBwIxf1Spj+bs3yZSXPoac ST44BEGvaE+9UmkSNj+dxK9qX+A+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/vJCDp1ofuqQHSS3r6OqHW5Pi19BXAGTT8JS00C+daLiIM5gw/LT91jOLWoldCzEjb1q xiIsS54gbwQhMwK0qyT/FbbjjbqrZ/MJiY26xvWWCS57wp/TI+je4Gsr1Pc6J59wJ2xS1CAu D0InpaY5eVWUZWVznTRH6MKAa2j4OuDPHvEm1lzEpI99jOrvXm+YYRX5zI4L0BsWioZRQLUj IbokVs5zPdu0LGCN8ebv6rZ5xwW8JXd IronPort-HdrOrdr: A9a23:29Aakqp/RkYMZ64xCfE2ft4aV5u5L9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/ Gnl7d6TnebCD0qhoPRPAh3Y8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT GtqX2z2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iFnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMA4SOo5kv8Z0YxHZ400vsJVXy6 RQxV+UsJJREFfpgDn9z8KgbWAkqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv V0Bs203ocbTbqjVQGZgoBT+q3tYpxqdS32AXTq+/blngS+pUoJgXfxn6ck7zU9HJFUcegw2w 2LCNUsqFh0dL5nUUtMPpZ+fSKJMB29ffvtChPkHb21LtBwB1v977jK3Z4S2MaGPLQ18bpaou WybLofjx95R37T X-IronPort-AV: E=Sophos;i="5.96,137,1665460800"; d="scan'208";a="83273738" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q8goVjkEEh/ARnzoHSVswX75anaWS5jpaD8VNLAPGr61UAhT6NepAOHXoa3/fBfaDEXichs5t3ksCc7yroonsNBy6QEePSbCvD8ZnFXQvXcX8Kq1moInCi8nWsZCHp4fHyVsiVBOsmnGg9a1/SSYSKon2b8ZCADt+YXPsMKPyuKrie4bTBFYrOothPeFUeA+752RAzUxuMZjnxNk2PbE31Cn2WzyrgqEguL5jmq0YGFhoh6rPI1kkvzISl/Zh51IpLEMYoVqK9HSgXRrMiMD8j9FAy+/DELG/3CaGGENeow1BZI5fIzsJeu0wT+irmNCCy2okf1cTuIkP8kdKT+Jew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=asJu70y7I/TL9/w7H0BuAYOVE6i616taxm6hGN/k5d0=; b=nZYBysQmum2RbkwAjFcOkImaB5AG3ThwJfLWIxKqpqVJnEnUHZXw4gr5vxw0K49f/djA62WEMx3WU2li3Y/yZvvU2ElO4AEcS3BczYJXRJj3of8x6WB9edYKviN2d2Q3kFLDkTYSRlEoX9qSOn9E9Il8OJivRZpk3jTmkdnpAZmxa9EFHzpFMdkWZ3M/jW4z7K07yZjvYtsB6Hjj7OYHZcWoTiokLZ4w1dSQy00Eru24kOdiUeWj6gCJGSFJ6hC/5q6qcMSpavuxiIkgw3fAcXcJINbimoMh6DwK/eqaqrdAPJi1FZlk9TeEio8hGEcipSCa9ur9aEzuZ50rj9faiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=asJu70y7I/TL9/w7H0BuAYOVE6i616taxm6hGN/k5d0=; b=NBaHs+/vjhTaJ0xiwKiTtX/4p85nzsYyf2iDmKfep3YJd8qSEzaxvLlECykCRQY8rgK8j5mI9FThFEvyvlOTIi8sCDuuPvNbVOLnzIp1OhplFBF1OGRiNqUqrY7czrcl9I/2yZ48BALwBCGMpRmxkMkQGTduYY8DCLfpjJ2YEx4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 4 Nov 2022 17:10:22 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Paul Durrant Cc: xen-devel@lists.xenproject.org, Henry.Wang@arm.com, Wei Liu , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian Subject: Re: [PATCH for-4.17 2/2] hvm/apic: repurpose the reporting of the APIC assist options Message-ID: References: <20221104142235.36556-1-roger.pau@citrix.com> <20221104142235.36556-3-roger.pau@citrix.com> <2a3c5141-516d-a5e4-392b-e7fe54f3781c@xen.org> <9a505567-57be-a7b4-7cab-d1d737172db0@xen.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9a505567-57be-a7b4-7cab-d1d737172db0@xen.org> X-ClientProxiedBy: BN9PR03CA0857.namprd03.prod.outlook.com (2603:10b6:408:13d::22) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6155:EE_ X-MS-Office365-Filtering-Correlation-Id: 94ea3564-5fd5-4123-ae0f-08dabe7f18bb X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: etRd1WAW2u0n7U6Dz9CWoYE/p9iOZKxYXegtjxCt8hLChxn7NaR6twC275cJ+k1b0iePW8YoYkC9+/CeBEG1I3aNqpVgfeb27GMVPVLAE/5zTIr6uGT4kWGvgHuh4C64C9eyNI04qrcm39s2zXy+O7d2dLdn9BgSUpJQ02DZY0ZY4lhOLe5VZbEVKNY4L4GI/XLN84QzIXGPLDMXKX+zw6iG1keuq6v3WG+qecNTHfkkNej/IORCJjV+WdBLxe+IBpAVGthVe+F61FLDQzbxwB7vQMFYtco5iLoNMXqOmd7+5iwwGpcQXqVPXkU6ek/w4LRVMrh/vvWO/erbe79+5i21PiwzUsxM1QUsTmlgSLrN5d282szthZEgQwGkZnKiTLq7W4y4FsospgimAnKYtHugcqlVqSPDKaSd7YWRemLO5T8liGEESPoc/pDvkA/NFoqLcbVwxz19/u7vPQBY0PWhGcAyNGQd0d8U5PYUabaB+D1goEBXVdnhmU3jMeZMg8sQkrrB4qRUV20grFD2ZyTKalxpD8WpH2tP8GaU5TD6GU3j5z7ayOM0YuaCtNvqa8CvGR7lWZ/cVbwy2sBews/cnMR9mT/0XyKJ/Zs6J94JanrwmIrCw44/Nva/H8ZxC7U0sh0bScgfJqFqKW+mDPo7C+T3Toa6CZbRy3P1wLpwj94Lma3nbn6pg6OX94WOwJeBRRNagciMwAvnlZY0rQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(39860400002)(346002)(376002)(366004)(396003)(136003)(451199015)(6486002)(478600001)(33716001)(6916009)(38100700002)(54906003)(6666004)(82960400001)(316002)(83380400001)(8936002)(86362001)(6512007)(26005)(9686003)(41300700001)(8676002)(4326008)(186003)(5660300002)(85182001)(53546011)(66556008)(66946007)(6506007)(66476007)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzJnZGJBVTJsaEFKelhDQjVxQVNWdlQva0Z0cWVDVGU2Z3dJcVExbFZvazFZ?= =?utf-8?B?YXNtVUkvWXlRcC8ra3dBN01jOEtEWFJOcjl1WDV6YWVod1QwWmltdWVmVGVs?= =?utf-8?B?T0tuSDZLMmhhTWFXWCs2WHRkYk1zL0dQYzRmL243Z3pNT1FKYWR4Y2hBdkZ3?= =?utf-8?B?M3NFY3YveTFjSTBjL0pnVkN6R2Y1RVRZWkJmc0YzaDRSNGNjZDdLWEI4Q0JE?= =?utf-8?B?QXF4emkvaTlqZnRTUjFlY2F2b0FKWnBNdHgyQUt0NXRNYS9semZrUi9EKzVZ?= =?utf-8?B?V2dPZ29ac0p6VzRqNE9RaUdMbDBPOUpnS0ZXVE9BUjBHTmpRdFhlTk9LdHV4?= =?utf-8?B?cVBXU0VZUFRqdU94WitvSUZldytNTlFSUitXNWh1R2pUT3JsQ3FWOE5nTDlZ?= =?utf-8?B?Sm81Z2JSQ2lpN0JxRkcvTGVpdHgwb0FGYlhNOU40WnZ5b0FybksrYkc5WTdQ?= =?utf-8?B?Q2MrR3B5MCtjYlJjeE5iQWszc3pIdmd4czNCaGtZSzRVbFdCa1MzaFBCb1lZ?= =?utf-8?B?RC9nTXYzeG9MZ1ByZlowOVczd3VSVlgzdFF3SnVXNDFubkswVWwzSmJBeW44?= =?utf-8?B?UWlBaVJQZ0VyeE1IeXhtT1dtZDVkMy92U0NZalRzak4rVUtzKzdqd1BwMzZ6?= =?utf-8?B?SG5VbU15Y25FZzBZYmtKaUh3bjc1eVFDQkFMd3A1dVZhRDZmNXRqZUY2eVhW?= =?utf-8?B?cDRCNmRpN3UxbDJMVDRjMjdnSWNnWWlsMjFVbUdyMlhYdlVVaVBhbjkrK2Zp?= =?utf-8?B?SGRoREcvRHZXNitWdmFIOFVoRnZmcDVvS3lRU29yTFlBcDdiTnRBRWgwYkxK?= =?utf-8?B?cDlwMUhEVzN3MkNUQWxTV00rSURwd1NNUjkyaHdSTjQrWU91cXJ6ZXM0cUpz?= =?utf-8?B?NWt6TERoeFFyRXoyQlFhV0VVQ2Q4a3BjVmM2VVRkLzFqaFZ4SEJNclNleSt5?= =?utf-8?B?cmJGWnZ0KzZHY2Z4MlVnZmw0aUdTbml0VHRQZ000bzN2R0JDS28vM1FJS09W?= =?utf-8?B?anFFV1lTOEM5bEVGZXlQM21VOVh6NENyK2JJTzZKQVNpZ2NkQVBBMUdERS9p?= =?utf-8?B?aXNaZkN5Y2U3d2l0R1dvNjNDekpBLzgwb1JOWFhuVkFMK2RxbW1EeVVxTXpM?= =?utf-8?B?ek9pbTF0cVZtYlZqOFhxRlp6encyOXVVMlQ2SU5URW1ZbExQMEcrZ3RPbysw?= =?utf-8?B?Qk5QRjh2dytXU2xQTyt2VVplL01oNlgvelNsWXFhOExIRDFkRjR6U0w0RFcx?= =?utf-8?B?OW9ncXNWaFg0R1ZadW1oRGJmdXVYRmhDL3N3WDFHS25uRzZKRXpGSnJYRXdl?= =?utf-8?B?OE5UT3hnRGNFUVhPNE11T0tyZXBLY1JNTlA2ZFdNanlhdlRuandoV3VqQ0VG?= =?utf-8?B?SlZnVzJRbUQvOU1jSHJVNUpyM3pQVCtibmhEMllHb3BUVFp6b3RHNkY0NGx3?= =?utf-8?B?cEpMd2VLMVJFaDNhWUVBN0Fvc1UvbFlNZENHZHlETGVIMnBUMU4vbjZlS0wx?= =?utf-8?B?elRmTURDWlFqWUp5OGhLSHFTamZyODZxc3dDRTBkZ1pjOEFOOTdzVUo0c0Z5?= =?utf-8?B?SkxPc2VrWWx3UlVQRjZ3VmlKU3hIR3BqZGF0ZWNSMDB4TzNWQ29rNFo4ZFA2?= =?utf-8?B?R2VETDZhczBRSGgvTDhMekNsOUR6MVIxZWkyeklwQ3lmVzNtSFpEc1RyR0M1?= =?utf-8?B?RDc1bkloakE0bUk3b1h6dVBja3FRb3E3b1JaR215OStLSDB5R3lDY1JYTmg1?= =?utf-8?B?RVdoQUc2dlZNWTVmcmZrck9jUGF1NWNzeDdHbjFEUlFPVEZ6b1ljcTZJUlpz?= =?utf-8?B?cndCaTNoWEw0SnVlUkI4THd5N0ZsUXIvb3BmeHdqWnpVZTkwS3dlOWM5SUIw?= =?utf-8?B?RkcrRzVTNW0xUnl1Zm5ZYmFSbFllNFUxN3k4M1dUL2ViQUlwZVF1WFd1bWk5?= =?utf-8?B?cGpMdy9VNG8zcEZSTzVtdlRJZ01IK2U0WThRTmg2UkFrWHp4TXBtREdsUTZK?= =?utf-8?B?ZitpR0NXMVQ0VjY2TkNEMFdqODJzOTlYK3htUlkvVnFlZ3B0eDRTODZxTjhl?= =?utf-8?B?a1p4QlNiTVpkdXYxRkNvbm1JZk0rSGpPN0toQXMrdTFTUWRRbG9LVzZDSHdh?= =?utf-8?B?YmFoQ2lLR0FocmYyRlE0RHYwU2E2MTN6elZHVlpBVVRUdzYwbnFjS1RGNFox?= =?utf-8?B?QlE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94ea3564-5fd5-4123-ae0f-08dabe7f18bb X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 16:10:31.3940 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ooBHr9u1a3v7BnsFfMYC++7617Y418IZN+yRJYUHZtTqCdWKmn2ndmBg06+M8asX4+QsXtaXUtixMepK530M4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6155 On Fri, Nov 04, 2022 at 04:05:05PM +0000, Paul Durrant wrote: > On 04/11/2022 16:01, Roger Pau Monné wrote: > > On Fri, Nov 04, 2022 at 03:55:54PM +0000, Paul Durrant wrote: > > > On 04/11/2022 14:22, Roger Pau Monne wrote: > > > > The current reporting of the hardware assisted APIC options is done by > > > > checking "virtualize APIC accesses" which is not very helpful, as that > > > > feature doesn't avoid a vmexit, instead it does provide some help in > > > > order to detect APIC MMIO accesses in vmexit processing. > > > > > > > > Repurpose the current reporting of xAPIC assistance to instead report > > > > such feature as present when there's support for "TPR shadow" and > > > > "APIC register virtualization" because in that case some xAPIC MMIO > > > > register accesses are handled directly by the hardware, without > > > > requiring a vmexit. > > > > > > > > For symetry also change assisted x2APIC reporting to require > > > > "virtualize x2APIC mode" and "APIC register virtualization", dropping > > > > the option to also be reported when "virtual interrupt delivery" is > > > > available. Presence of the "virtual interrupt delivery" feature will > > > > be reported using a different option. > > > > > > > > Signed-off-by: Roger Pau Monné > > > > --- > > > > I find the logic in vmx_vlapic_msr_changed() hard to follow, but I > > > > don't want to rewrite the function logic at this point. > > > > --- > > > > xen/arch/x86/hvm/viridian/viridian.c | 2 +- > > > > xen/arch/x86/hvm/vmx/vmcs.c | 8 ++++---- > > > > xen/arch/x86/hvm/vmx/vmx.c | 25 ++++++++++++++++++------- > > > > xen/arch/x86/traps.c | 4 +--- > > > > 4 files changed, 24 insertions(+), 15 deletions(-) > > > > > > > > diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c > > > > index c4fa0a8b32..bafd8e90de 100644 > > > > --- a/xen/arch/x86/hvm/viridian/viridian.c > > > > +++ b/xen/arch/x86/hvm/viridian/viridian.c > > > > @@ -201,7 +201,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, > > > > * Suggest x2APIC mode by default, unless xAPIC registers are hardware > > > > * virtualized and x2APIC ones aren't. > > > > */ > > > > - if ( !cpu_has_vmx_apic_reg_virt || cpu_has_vmx_virtualize_x2apic_mode ) > > > > + if ( !has_assisted_xapic(d) || has_assisted_x2apic(d) ) > > > > > > So, not sure why this is separated from patch 1 but stated this way it seems > > > counterintuitive. We only want to use the viridian MSRs if they are going to > > > be more efficient.. which I think is only in the case where we have neither > > > an x2apic not an assisted xapic (hence we would trap for MMIO). > > > > I've read the MS HTLFS and I guess I got confused, the section about > > this CPUID bit states: > > > > "Bit 3: Recommend using MSRs for accessing APIC registers EOI, ICR and > > TPR rather than their memory-mapped" > > > > So I've (wrongly) understood that MSRs for accessing APIC registers > > was meant to be a recommendation to use x2APIC mode in order to access > > those registers. Didn't realize Viridian had a way to expose certain > > APIC registers using MSRs when the APIC is in xAPIC mode. > > > > Yeah, I think they predate the existence of x2apic. > > > I withdraw patch 1 and adjust patch 2 accordingly then. > > > Cool. Thanks, How does Windows know whether to use xAPIC or x2APIC? I would assume CPUID4A_MSR_BASED_APIC only makes sense when in xAPIC mode, as otherwise the registers are already accesses using MSRs. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Nov 04 16:18:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 16:18:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437761.692226 (Exim 4.92) (envelope-from ) id 1oqzP2-0007zW-7u; Fri, 04 Nov 2022 16:18:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437761.692226; Fri, 04 Nov 2022 16:18:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqzP2-0007zP-4x; Fri, 04 Nov 2022 16:18:44 +0000 Received: by outflank-mailman (input) for mailman id 437761; Fri, 04 Nov 2022 16:18:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqzP0-0007zJ-4O for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 16:18:42 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56e35880-5c5c-11ed-8fd1-01056ac49cbb; Fri, 04 Nov 2022 17:18:40 +0100 (CET) Received: from mail-bn7nam10lp2108.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Nov 2022 12:18:35 -0400 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6609.namprd03.prod.outlook.com (2603:10b6:806:1c8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 16:18:30 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 16:18:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56e35880-5c5c-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667578720; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=OZIy73XHDNh7huyG+lccw757BxYenNLRo+6EmZBz0Tw=; b=h/boivSYnjOdVVHKJTsqs0QGC77nmaDQKFG3uGB7T4ew5TYDaO6YXy/y 4srMSDZkvjhdqkqgNVLTCUNmkdtQQUWU58jt3nvuSdI37iq1zXfvUMnpa tAQJypfk/jKRdRf3PfDtqeeAMSwocEnaz1Pouqn6wLndAfFtka/1tow2n M=; X-IronPort-RemoteIP: 104.47.70.108 X-IronPort-MID: 83793898 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:hqFpXa4nNpAzPo4hyi5OLwxRtM/GchMFZxGqfqrLsTDasY5as4F+v mcfWziDa/rbMWqneIt/OoXl8hlV78fXytdiSQU6qHo1Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkT4AeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m1 tUVKhMqRDO5xMnt/Z+WELlIn+Q4I5y+VG8fkikIITDxK98DGMiGaYOVoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MlEooiOiF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efxnyqA9JDRNVU8NZhuFK84lwZEycwFnK8ofy3kk/lVNNmf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpSNEgrt5wejUs2 XeAhdavDjtq2JWNQG+Z3qeZq3W1Iyd9BXAGTT8JS00C+daLiIM5gw/LT91jOLWoldCzEjb1q xiIsS54gbwQhMwK0qyT/FbbjjbqrZ/MJiY26xvWWCS57wp/TI+je4Gsr1Pc6J59wJ2xS1CAu D0OnZeY5eVXVZWVznXVEKMKAa2j4OuDPHvEm1lzEpI99jOrvXm+YYRX5zI4L0BsWioZRQLUj IbokVs5zPdu0LGCNMebv6rZ5xwW8JXd IronPort-HdrOrdr: A9a23:KvW7dKyN4CeedYs/Z3fgKrPxyuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scu9qBTnhOZICOgqTM6ftWzd1FdAQ7sSibcKrweBJ8SczJ8h6U 4fSdkYNDSYNzET46fHCWGDYqwdKbK8gcWVbInlvhRQpVYAUdAa0+41MHftLqUwLzM2dKYRJd 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYoYLSIly95FMzQjlPybAt/S zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+c/DqAVcBEYfmvrTo1qOag5BIDl8 TNmQ4pO4BJ53bYbgiO0GnQ8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMnZ 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvtn+9KK1wUx4S1bpXXt WHVKrnlbdrmBKhHjvkV1BUsZCRti9ZJGbHfqAA0vbloAS+0koJjHfw//Zv4EvoxKhNN6Ws2N 60TZiA7Is+KPP+TZgNcdvpEvHHflDlcFbrDF+4B2jBOeUuB0/twqSHkIndotvaMKA18A== X-IronPort-AV: E=Sophos;i="5.96,138,1665460800"; d="scan'208";a="83793898" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=exWmJua65++5Cd6SFkgFrnoG+PYxtJhLH+4ODBTJlSM3AJ/BT2/FmvEs3Yq0d9KyaMfbpxEjvLjg1yrU4yrwtIM3M2nCqMtm1gptHQDs5bWFoNXI87E6JvBoLPwXFOw3xlbIsfSJOHkgz9VXgW/FmCuhaC+KeUVIcLeZM5gcdNQeKUCQGH8ZX3Z0/S4MNG5T2l+okjhhpEK56V1PIDfVYIcNpJzyiQHuf9S4Va64F/ZJkQJWYjjLmRqYYyy9qY93O8MCDIQlyMDG6ElsweCJLRlm1Xcoztav6EizOPQDqpDTgBAPT/lXeLPsn5zICYcEnc5/qv/C/Oz7kQM9wiDppw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fley6Y90v1no9pEdEhWt6kG4s5fyBU09mWCBmGOap2k=; b=MEf5pSdlOESh+IKpi4CHqszLv8u5eeLeBPw5yBFB0XLAnIWilXnkdJne1dWmdcNJzGDWRQMuNu4Vywg3Pd7M5wF4aw8nAtgzH9Mi2JOtQldgYR5iVGY5wCgq+NP3zOLCzMP2hUr9boxBWIrc3aN++K+zI7tYm4lv1rwu5uVGiHusXiIcxwtOq65RFAybN6sFL0JtbtFesQEWKK/Hhpcsh8E8N0S1dem42JqBu48uVCP7GeAbayErORbJ5wL68AdThJkj9ubwdzQ0Zm9Y8S9ETG4BjakxdYuRNOG6NG0XxDyKsTSgHnQ19qNbgV9x68XY/ad17MbFw6zFSK8iswQhQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fley6Y90v1no9pEdEhWt6kG4s5fyBU09mWCBmGOap2k=; b=Fs8RXrb5J+8ZNsI6UPPGKfJeD+hVbWIcwavwhpZ+CNpOzFSyM/OQOBBwjfeLjQk9/Oo5y7LqCMTfsHU9FIT4giLF7NMXoDCgUmn0pp1FL7GyM/uIcNSqMyvHsGPJdclg3YREKjD6dJ7ipeKsKoy6pP6nxkUT4O3owpEjLp+ya2o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Roger Pau Monne , Paul Durrant , Wei Liu , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian Subject: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Date: Fri, 4 Nov 2022 17:18:15 +0100 Message-Id: <20221104161815.38007-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0321.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::20) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6609:EE_ X-MS-Office365-Filtering-Correlation-Id: 9255d589-4c0c-4c5c-d308-08dabe803606 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OUxlaN267uBb+r/ZK1RN9p7IZYzu9bATwkE4ZiCpfkiA5wgQndHtT538Vxhwjls9hA9Fixm4k2S1nosX5JaMYIEbq6bKjHB52fludS5TWlBmrb86nJHv4K0ZGuQ6g4I8xJI82jcr6XMQBddlhl0hhVG9Kqq+VwLCwr0jNe/9n3r5CJLt8pvIu6jNzvbXQdVEM1GikK3WTYvD+504fsVM33FsOXtmsx++neSK7D5BRfHFIOVnY5TFcdcbuPJulu5Om64DjRufjY7plOCokSEeTJy+ryzpbKp+Na12gwJxiQF78MNhv69VWkyvn6hTxsRYwpwO0vEx4N+ZbsFeeckjKmp3WgncB/OFPeJaAyVAiYU6rDfIVdjYW0oopLgg51DPO+Nsa9Avhf0FkMB4RAUjJkl9WFBmE1LlqTgsQ0Pjqx8Onhzrhfa/hZ+yT8BWbD0dzMPhazN7Sdl/RoKkhRwXpfPrswyvRy51fI7WmqtogQMJLNBd853NipzUVZHnt0nWCJJ5PbYaMdGj0qZuXCzTEIsS2+ITJmUaZrvVP9BKPR13d7wgROh/LYFk6OfnVWVmQvcTipT5OionXRvNUolzEwbj1VaPDmrYSda6k14Yj34trNZSV/110g9mlS9zwB3F1MLz67NsNxedaR9zLO5ys1d87t+EpIExMSYFIENwdY5ba+MIk1bP+cp/o70F/uxoQzxxH5kzBwwE32h76mQaIg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(366004)(376002)(346002)(136003)(451199015)(38100700002)(36756003)(86362001)(4326008)(82960400001)(41300700001)(66556008)(5660300002)(66946007)(478600001)(8936002)(54906003)(8676002)(66476007)(316002)(6916009)(186003)(2906002)(2616005)(1076003)(83380400001)(6486002)(26005)(6506007)(6512007)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnZFSXhJbVhxbTZrVDZEeklvUnd4dWp6aEpoS20razFGdzdCSW8rNHJqTjBp?= =?utf-8?B?am5FV1dDWjd6TzEwZ1pBZ1FpMlJKdUYxbTlTclIwMys3eUM2OVRTS1Nwd0RF?= =?utf-8?B?VFJ6bVZ2ZVVtb2xEQzBneEZVQUhxVUowSjlyL0k2VVhyMlZrZmM2cU1ZRVF3?= =?utf-8?B?aEFZYmJuTHc0T0t0OTZ5VDJPTVZyalFqYmE4dXpvRUovRjduaVZBRTNhck13?= =?utf-8?B?Wk8yZC9vNjhjTnl4ZmZ2U3NJWGVhSHd4SmxMMEh1Um5kTFF2ZVZuUDF6MWZS?= =?utf-8?B?N0g1cWdzUTNZR2ZuQUJMSXpNZzcxSzByMS9HRFo3MmphYWN6TTJ1Zjk0VUFy?= =?utf-8?B?NXdDcTRzZUplRUhvRWEyeTNFWTJpaEpTRVh3ZmpyT1pGSHVyRlZQM2dVMWVm?= =?utf-8?B?NnhrS3NHT0F1SWJRWDFJQU0ydUlPQ3VpcFdzMDQyakk4YkIwODVWMkFnMTdj?= =?utf-8?B?TEphUDhsL0xieUlMVVpHdnQrTXlJa0d1WnhBWTdWSDNmOFBianVqNkJ1VWZ0?= =?utf-8?B?ZU04MklONGRkODJXT0tnSE5vaS91RW0xRUdoclZHdWdVUGN5bEY0M0pYbFVz?= =?utf-8?B?Njh6Z1V3U3NSWGxzZGVBZWdHWThLMmxsLzdUclJrWFMwT3dkbVVPdjF3cC90?= =?utf-8?B?WVJJREpDN0R6YkpBbVlvN1diNEJEM29FRkl0MUcxOGUvdnJ3VllORC90T0pG?= =?utf-8?B?NlorN2ZucTlWbU5OU2JrWjNmWFdRK2JDZHhyekM5dUtPdUpqNHhFampwY2Fo?= =?utf-8?B?UGd1d2tENjhqNHQ3Qmx6VFk2azFRTDc3dU5QNzRFckNVQ2dVdldRQ29vVjFR?= =?utf-8?B?SFFNWUNhMjg2OGhPVU1rNVR4WVIzUlR4VE5PWTFsTGNLVDNNbjBmdW5rdklR?= =?utf-8?B?aExza2IyQW5TVmZGQnhJWlBHZnRnSUhyY2orWTRDNDNIS2hwU0ErYkhzMFFD?= =?utf-8?B?VFBMZWxmSjJOeEliS1hLYzdSdm93L3h2eWdjU0lPdTJ1dDZmZXNrc2RaNFdB?= =?utf-8?B?N2dxTGZyWEdmNkVZMVpUY0dDbUlVZ1pUMkZnN0tScThUYUdWOUJVRUFzaVdU?= =?utf-8?B?aHF1QU1nQXJoOWNTd09JM3hsdFBIKzJZZzhQRG1RY3RNdWtZeEE5K1ZGQ05K?= =?utf-8?B?NzEyN0l2NVBaMTAxajlQSnJvRFNGaFJURVRycU43QUUrQi81MnF5RytURXVX?= =?utf-8?B?dkYzak9zT1JIdU42QVdNZnF2dFZNQTAwMFdHUkk3QmtEVFo1RUlzcWpnVkJO?= =?utf-8?B?MFNFWjNvd3FRc094OUl3Y3UxWUFZckFDRHl3NFY3TTdid04raTJDL0hYWW01?= =?utf-8?B?cG8rUDQ3VktUWWlJVEkwYXV2dTBPMHVhYzFJazEzRDk4eHFSK20yQzhwcTVz?= =?utf-8?B?b000U01PNnR2OWRvckRRUGszMjdMODlsQXFva3FLalFsSHpsOWF5OWp1NjV3?= =?utf-8?B?Mjl2OFZQUStNL2VVS09Rb3huZFlHV3pWUGJxMHNkQVB5cncwMGE0dlBIOW5W?= =?utf-8?B?YndCd1RNQ2V4OHJ0dVJoUEJXNzdkWXBBbDd3TXNWbXBSQThTSWpBc3pyZTJP?= =?utf-8?B?YWlvYzF6RnRnTWVGYzBoMUVwVjNieE0zcU0wR0pzZzJNdTZHQ3E2ZEVqbDlO?= =?utf-8?B?djEwc3JjN29vU2pLaW1VVEd3OSs1cjU2MlpERVpuUWFRU0F0TXpTUjgwbi9u?= =?utf-8?B?UVpmeXNPNklLQ0FuaGFTVG4yT2JsNlI5S292QlFGZ0RqMFFwdndyTHNzZzk3?= =?utf-8?B?SE9EWHArM296MVVuU2taOERrekREMTd3TUd2aE15TnRwUEdDdTFSR1c3WlhM?= =?utf-8?B?YnRIU1BlTm9EcEl6SUtPczBkQWZ4T1paV0lHcUhnVnFHUnFDd3RhZUpYNUE3?= =?utf-8?B?Znc5SHNnRk5Pb3lzOXFZdE9ScWY3NHJ2a0pWU2lpT3grSCtIZ2xrVjNIZ3Fu?= =?utf-8?B?eW40MVlXdTBTajNzTmo0YjBDVGM4WG8wSUgvclFsaUptRzd5ZGVEa1UzTlpG?= =?utf-8?B?SmdrSi9tdGpqWTdBNkpuNDdySW5JVkJ0NCtBckZFMWJ2Z2liYjFjN21EYjZV?= =?utf-8?B?ajM5L3lDWmxEbmZaZUI4T2VtdDRRZXhMY3VVclREeXNocU4vVnNtbkc0Vmpm?= =?utf-8?B?aFFUNnE2dGtNVUxGdXpJdGZhbk9MWnVkYTVHRGdhU1ZWRkhKeW5xdU0xV00x?= =?utf-8?B?bVE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9255d589-4c0c-4c5c-d308-08dabe803606 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 16:18:29.9885 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sJLhJzBLc1LdqKKoZR9IAOfNWZOuDSH2E+4w+m7gucqiaaFQRVdiGKc9BZxZDskGuGXLs/gwHRe9+so3OiGTGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6609 The current reporting of the hardware assisted APIC options is done by checking "virtualize APIC accesses" which is not very helpful, as that feature doesn't avoid a vmexit, instead it does provide some help in order to detect APIC MMIO accesses in vmexit processing. Repurpose the current reporting of xAPIC assistance to instead report such feature as present when there's support for "TPR shadow" and "APIC register virtualization" because in that case some xAPIC MMIO register accesses are handled directly by the hardware, without requiring a vmexit. For symetry also change assisted x2APIC reporting to require "virtualize x2APIC mode" and "APIC register virtualization", dropping the option to also be reported when "virtual interrupt delivery" is available. Presence of the "virtual interrupt delivery" feature will be reported using a different option. Fixes: 2ce11ce249 ('x86/HVM: allow per-domain usage of hardware virtualized APIC') Signed-off-by: Roger Pau Monné --- I find the logic in vmx_vlapic_msr_changed() hard to follow, but I don't want to rewrite the function logic at this point. --- Changes since v1: - Fix Viridian MSR tip conditions. --- xen/arch/x86/hvm/viridian/viridian.c | 2 +- xen/arch/x86/hvm/vmx/vmcs.c | 8 ++++---- xen/arch/x86/hvm/vmx/vmx.c | 25 ++++++++++++++++++------- xen/arch/x86/traps.c | 4 +--- 4 files changed, 24 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c index 25dca93e8b..44eb3d0519 100644 --- a/xen/arch/x86/hvm/viridian/viridian.c +++ b/xen/arch/x86/hvm/viridian/viridian.c @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, res->a = CPUID4A_RELAX_TIMER_INT; if ( viridian_feature_mask(d) & HVMPV_hcall_remote_tlb_flush ) res->a |= CPUID4A_HCALL_REMOTE_TLB_FLUSH; - if ( !cpu_has_vmx_apic_reg_virt ) + if ( !has_assisted_xapic(d) ) res->a |= CPUID4A_MSR_BASED_APIC; if ( viridian_feature_mask(d) & HVMPV_hcall_ipi ) res->a |= CPUID4A_SYNTHETIC_CLUSTER_IPI; diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index a1aca1ec04..7bb96e1a8e 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1136,7 +1136,7 @@ static int construct_vmcs(struct vcpu *v) if ( !has_assisted_xapic(d) ) v->arch.hvm.vmx.secondary_exec_control &= - ~SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; + ~SECONDARY_EXEC_APIC_REGISTER_VIRT; if ( cpu_has_vmx_secondary_exec_control ) __vmwrite(SECONDARY_VM_EXEC_CONTROL, @@ -2156,10 +2156,10 @@ int __init vmx_vmcs_init(void) if ( !ret ) { /* Check whether hardware supports accelerated xapic and x2apic. */ - assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses; + assisted_xapic_available = cpu_has_vmx_tpr_shadow && + cpu_has_vmx_apic_reg_virt; assisted_x2apic_available = cpu_has_vmx_virtualize_x2apic_mode && - (cpu_has_vmx_apic_reg_virt || - cpu_has_vmx_virtual_intr_delivery); + cpu_has_vmx_apic_reg_virt; register_keyhandler('v', vmcs_dump, "dump VT-x VMCSs", 1); } diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index e624b415c9..bf0fe3355c 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3405,25 +3405,29 @@ static void vmx_install_vlapic_mapping(struct vcpu *v) void vmx_vlapic_msr_changed(struct vcpu *v) { + bool virtualize_x2apic_mode = has_assisted_x2apic(v->domain) || + (cpu_has_vmx_virtualize_x2apic_mode && + cpu_has_vmx_virtual_intr_delivery); struct vlapic *vlapic = vcpu_vlapic(v); unsigned int msr; - if ( !has_assisted_xapic(v->domain) && - !has_assisted_x2apic(v->domain) ) + if ( !cpu_has_vmx_virtualize_apic_accesses && + !virtualize_x2apic_mode ) return; vmx_vmcs_enter(v); v->arch.hvm.vmx.secondary_exec_control &= ~(SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES | - SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE); + SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE | + SECONDARY_EXEC_APIC_REGISTER_VIRT); if ( !vlapic_hw_disabled(vlapic) && (vlapic_base_address(vlapic) == APIC_DEFAULT_PHYS_BASE) ) { - if ( has_assisted_x2apic(v->domain) && vlapic_x2apic_mode(vlapic) ) + if ( virtualize_x2apic_mode && vlapic_x2apic_mode(vlapic) ) { v->arch.hvm.vmx.secondary_exec_control |= SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE; - if ( cpu_has_vmx_apic_reg_virt ) + if ( has_assisted_x2apic(v->domain) ) { for ( msr = MSR_X2APIC_FIRST; msr <= MSR_X2APIC_LAST; msr++ ) @@ -3432,6 +3436,10 @@ void vmx_vlapic_msr_changed(struct vcpu *v) vmx_set_msr_intercept(v, MSR_X2APIC_PPR, VMX_MSR_R); vmx_set_msr_intercept(v, MSR_X2APIC_TMICT, VMX_MSR_R); vmx_set_msr_intercept(v, MSR_X2APIC_TMCCT, VMX_MSR_R); + + v->arch.hvm.vmx.secondary_exec_control |= + SECONDARY_EXEC_APIC_REGISTER_VIRT; + } if ( cpu_has_vmx_virtual_intr_delivery ) { @@ -3440,9 +3448,12 @@ void vmx_vlapic_msr_changed(struct vcpu *v) vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, VMX_MSR_W); } } - else if ( has_assisted_xapic(v->domain) ) + else if ( vlapic_xapic_mode(vlapic) ) v->arch.hvm.vmx.secondary_exec_control |= - SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; + (cpu_has_vmx_virtualize_apic_accesses ? + SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES : 0) | + (has_assisted_xapic(v->domain) ? + SECONDARY_EXEC_APIC_REGISTER_VIRT : 0); } if ( !(v->arch.hvm.vmx.secondary_exec_control & SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE) ) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 7207390118..5c0aabe8a3 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1124,8 +1124,7 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, if ( !is_hvm_domain(d) || subleaf != 0 ) break; - if ( cpu_has_vmx_apic_reg_virt && - has_assisted_xapic(d) ) + if ( has_assisted_xapic(d) ) res->a |= XEN_HVM_CPUID_APIC_ACCESS_VIRT; /* @@ -1135,7 +1134,6 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, * vmx_vlapic_msr_changed()). */ if ( has_assisted_x2apic(d) && - cpu_has_vmx_apic_reg_virt && cpu_has_vmx_virtual_intr_delivery ) res->a |= XEN_HVM_CPUID_X2APIC_VIRT; -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 16:26:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 16:26:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437766.692236 (Exim 4.92) (envelope-from ) id 1oqzWS-0001Ir-2P; Fri, 04 Nov 2022 16:26:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437766.692236; Fri, 04 Nov 2022 16:26:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqzWR-0001Ik-Vx; Fri, 04 Nov 2022 16:26:23 +0000 Received: by outflank-mailman (input) for mailman id 437766; Fri, 04 Nov 2022 16:24:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqzUE-0000xv-Fo for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 16:24:06 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2077.outbound.protection.outlook.com [40.107.237.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 18c9cd5d-5c5d-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 17:24:04 +0100 (CET) Received: from DS7PR03CA0107.namprd03.prod.outlook.com (2603:10b6:5:3b7::22) by PH8PR12MB6794.namprd12.prod.outlook.com (2603:10b6:510:1c5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Fri, 4 Nov 2022 16:24:01 +0000 Received: from DM6NAM11FT019.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b7:cafe::42) by DS7PR03CA0107.outlook.office365.com (2603:10b6:5:3b7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.23 via Frontend Transport; Fri, 4 Nov 2022 16:24:01 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT019.mail.protection.outlook.com (10.13.172.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 16:24:00 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 4 Nov 2022 11:24:00 -0500 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 4 Nov 2022 11:23:57 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18c9cd5d-5c5d-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JyH9RSrmME2e3c+e+May26dI908uORfNPmqtAu+rR491ZCUZO+Crpkb1vuPFFwSUeXjdq6yNOirBKi4P4zku7gqmW9ew5VlWt1IzGYXO7qcRaVy9sm1IexYEwfBr/+kkBamEl9ToGcTzCD/N35rDVo6CttYz40WO+D3+lOH0a8APpIhby2Vt6PX+TfwdDSaWp4B3UxvN/6Pr58kbm1K2GJ+RKADJRPuKzf3aG00uYiazM2XDN8itdlPMAqmJfW7G543ZGks7AuOWoXC79WOaiNOQRRp2Vfv7GkZeospZn03Sq0O1ihb/l/Prpwhj7d835QudoTqiZ3KJ/KE63J+j6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pEw6Ps8mug7G4A+QhO2oaXYDI+K/H84ed4gbyS14lPo=; b=Iv+ngoxtGI5hcZ23u8GCYdyfq++M/XvRHi8+pZhlr2EDF445nILN+1bCuhzd9op5dIvmWXdyGpzFs7sDHaDoT1c+sfFKE6TviSHPL2ANbqGBSa1ew3q2+CuTxlIdaip3gWL9rfw9aq49SG7rKOLLBvhKgFarmjFWgMZ6aqgMhLFkVHuxRtl0G9lNH8MYNvK0N7Gtuvn0f+Fyn5ANDoLSrJ13euQu8Rp4oAXaidFtdpWYhB564j5co3dadZmgNI3Veng206e6qEPaRupIXs5EWD9LNfg0ft3j1MZOaE1aOLDTvzpEetyQu3im1ShKQ1ahPGOOE0cgLWsMntH51r/F1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pEw6Ps8mug7G4A+QhO2oaXYDI+K/H84ed4gbyS14lPo=; b=eXIUNALkQ3+qUsStejGO1lcYn0GGETuuukQqA3fRxBx/83rwgP5Svfi+pJVCw2er62HtN2UxFGKjYkoKxUbawQJp24kMUoL5b5wpCxz16jNhxbtXZOyGWKbLNSj48dOIJ53fODVZ1Oop1sPCSyREZAbdsWeOH3XXYltSgLZcDl4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , Ayan Kumar Halder , "Ayan Kumar Halder" Subject: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write Date: Fri, 4 Nov 2022 16:23:55 +0000 Message-ID: <20221104162355.23369-1-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT019:EE_|PH8PR12MB6794:EE_ X-MS-Office365-Filtering-Correlation-Id: 51c3d6e3-6efd-4273-6e4d-08dabe80fb63 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5gTDpqqKji4dxVTsbeD7lCZ0zdySfSzgUATC978BVUKlujUmuN3ICTmZ78ZMVmttA0N6q3U/LwTasUeiL439O1qUtlD95P0RT/qL/xSSYoUNlPD6OuW+DYHGDfhJuNiw5O0IHnWyWmfKC5bDKCfQ/UtFikCgjNzE+lhO8bCaOfKiBqeULr1lb/ero1tHSMjxDKN6Y/8jMi70VQFRuBBamTaVoUpufR73fr32oiWLDthJASJQUdHjKMxQ9DdhvDEGqsmgOwPwaeeVKY9mRd43tY+vgTMi2b8QtWBKWRjjwgOawofWEvCWDnzouMlzRlZg6ZUlyTa0YbO+y4iOL5ShhY+gJGpulzk2rymy6RIB3gFkrzRZmVgS/CF0K3WVr+Ke5BqFqoaf72F5VxfPZOyk9se3Pt+P1Wc41A2LsznEVlvwqC+js+KBAIujqBxO0y9NvXE4UyYl4diu8gpWFAmEJrCQzKicfOECdJZUnSjsAtHHEUZGM7Aa0/zrr+MWB7e633yeZ72rdybqX4X5p8Hfs4hD77JU2U8aIQAEZL+2M8csJ9XkyudfoghOG2BcoeOimmb0B88cLYfCliegmprEbmwamJFYQiLDqwWpsiu0CZa3YGB6UWvAq+4kNLS+Uv54d7E0sMTw4rMm5ZN8f5AVVjRs9wIG2dPaN7YokCGwZU8jUZKuUXSm9K4qXxU9xyOJDFiLzW0vg8RPWDkStTiNh7rAvlzNRC8MzBiP3xblZ5OL4I/YNnZpoTDjtcx6lbP/sjWHEphzgyxsUZ5xUIBbs/SC/Bzz+uyuZmGMMfDj1g2H9LdUbdYytIRLrWc+eENf X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(346002)(136003)(451199015)(36840700001)(46966006)(40470700004)(6916009)(2906002)(8936002)(54906003)(478600001)(5660300002)(40460700003)(41300700001)(70206006)(70586007)(186003)(336012)(36860700001)(316002)(86362001)(426003)(83380400001)(1076003)(82310400005)(26005)(47076005)(2616005)(36756003)(356005)(81166007)(8676002)(82740400003)(40480700001)(4326008)(103116003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 16:24:00.8254 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 51c3d6e3-6efd-4273-6e4d-08dabe80fb63 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT019.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6794 From: Ayan Kumar Halder Refer ARM DDI 0487I.a ID081822, B2.2.1 "Requirements for single-copy atomicity - A read that is generated by a load instruction that loads a single general-purpose register and is aligned to the size of the read in the instruction is single-copy atomic. -A write that is generated by a store instruction that stores a single general-purpose register and is aligned to the size of the write in the instruction is single-copy atomic" On AArch32, the alignment check is enabled at boot time by setting HSCTLR.A bit. ("HSCTLR, Hyp System Control Register"). However in AArch64, alignment check is not enabled at boot time. Thus, one needs to check for alignment when performing atomic operations. Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 16:32:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437774.692248 (Exim 4.92) (envelope-from ) id 1oqzcd-000341-OC; Fri, 04 Nov 2022 16:32:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437774.692248; Fri, 04 Nov 2022 16:32:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqzcd-00033u-LH; Fri, 04 Nov 2022 16:32:47 +0000 Received: by outflank-mailman (input) for mailman id 437774; Fri, 04 Nov 2022 16:32:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oqzcc-00033o-5B for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 16:32:46 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20062.outbound.protection.outlook.com [40.107.2.62]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4ee23a7e-5c5e-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 17:32:44 +0100 (CET) Received: from AM6P191CA0058.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::35) by DB5PR08MB10312.eurprd08.prod.outlook.com (2603:10a6:10:3c1::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Fri, 4 Nov 2022 16:32:41 +0000 Received: from VI1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::58) by AM6P191CA0058.outlook.office365.com (2603:10a6:209:7f::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 4 Nov 2022 16:32:41 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT022.mail.protection.outlook.com (100.127.144.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Fri, 4 Nov 2022 16:32:40 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Fri, 04 Nov 2022 16:32:40 +0000 Received: from fefdb8aea9c3.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C63A29B1-2812-42BA-B182-8097DEC3F36A.1; Fri, 04 Nov 2022 16:32:33 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fefdb8aea9c3.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Nov 2022 16:32:33 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PA4PR08MB6142.eurprd08.prod.outlook.com (2603:10a6:102:ee::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Fri, 4 Nov 2022 16:32:30 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 16:32:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ee23a7e-5c5e-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aZVqpJuZ1HYAgA1Y4VKdBE5PBiAx5edNoVkQDgaSbhHxymUyFT3oCXibiD5y1KI6yPHk1wTJUDUGcMTUwod5FBt+L9CA0h1w1j7IUr4bDY8WMybMeyynIzqM1d98dbT9EvceKy4KylWQIEuwLIqtwsluzOL6xwgpLQSDaknyERk0BnunUzoGOofU3sW5orHscmFppeyUsQl6cntRd1UQo3x7NB4n9yvfgB8WlzXYM/Ydad1UFqLh8qTHbYuIoJ+vqoydcLhNMzsClQVFlw++6tbBirRhAkmmP0Opv33A8xEjg+nX+yRatLKx/XfX9lvuFF72lzATWF2B1wvBLP+/hQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=80AthlkCP9ESVYijKAHCQxARwimk0xrGDbtTfMDxJok=; b=LkuZcl66SYRb8ogCkV2OqgjHilB+gtQxx31q4nPTs9Oj+2puC0d5jMCg1T7IY8mizS8YqGyZshfdxE/XRepUSdxruSkSx/Yzemnz36zVNqQQqufFUkxtTQczRSF75DCVkwwcLfsnnAAvwg63xP7KC8pz9+TMJiOjIV4HydtD4katoK+QBv+Ur0gKbHRx0ycie0XYQMNVymi2VNTJ41EoHjpEgIvl+b+IH7TFx9NYCHhV/aAZYIhUnSm5625GifJwbn6nFm2/RRcBj+amJBAmUBVxXVODBmpzFyPsWpuVn+cNiofjSlkA3Nfiq0QzaQY94oXvSFsEjIJNmvclopsuHQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=80AthlkCP9ESVYijKAHCQxARwimk0xrGDbtTfMDxJok=; b=78tU/8JtnmzBQ1CGRoIhpiDq/ElKEjwRU08pggAA7pLsuvo7hXRR7KyxiCcgBB/kQpoCq4e20YQwuzuXXoYwhWpX/+0huws3VfK3Xzd1jUv8rtEVrQgD9dXSSVWyNb+CYuGVMbnlMb9xs6uS95IPPG7bpkwzBOVHxVBmiFKRjeQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0cf7705b7e31f43e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N6kx0H6/1GDouflvF4qBS89iYR/y6dMD7b9TZ/yKvHU8yuCNnHEN+sS3/9REeiWC47nDGX8NFKQFBlUznEZDq8M8KAaTXVIO+PfYuV3TJnygGXp4/cgi9hKch5F8M2LgF5Tw9qNK9PkIjE5dKQa7UGu8M7WaP6zNUh14PV67IMGFwRAERYOaP9fk0i7BVMG8zo7xmIhSJViu8Lg9sZRxKt6Wk6vk9XxCEeZl9PZjfctPUJ0fnN8Xj27r3uFYFj9vqU4hn5Ryq3GRdBfXdq5dg11j2AqXwYlKHorQU3WcdRhFnhVTVk7ltonKEC9FGtkD05HH7PGkZmbWZyXk/uYqhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=80AthlkCP9ESVYijKAHCQxARwimk0xrGDbtTfMDxJok=; b=mI3mK7qj5GQKbILAF+puEUVfDbAcbIKJBIkJCkOjGQqO+J5jrNogulKPndMM5GNMWwdKirM54n/PRbjcKSqK92hoC+P7svWCgObp8/2BQ6XOeJVrF0+1mvIreWtK5zTfzK1CHxArc5HcYXY4ncupPvoQ/lVjb/nbYaf2Daf8wkXiHvo1i9mbIjtfwZAKGbopD2QVWyxoDsgiZnB558t8ATAgFrmncaDyx9iXUsxawI4ufRWZPfPDvFgco84T4WBiuDy4JSgh5PITEE8pY23V56WjJl9E1LL4EG48GwZl8Iv8t+8yL8XhHEF7f4jBWuTpx6XJJC+TuJNeG3cotGC2VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=80AthlkCP9ESVYijKAHCQxARwimk0xrGDbtTfMDxJok=; b=78tU/8JtnmzBQ1CGRoIhpiDq/ElKEjwRU08pggAA7pLsuvo7hXRR7KyxiCcgBB/kQpoCq4e20YQwuzuXXoYwhWpX/+0huws3VfK3Xzd1jUv8rtEVrQgD9dXSSVWyNb+CYuGVMbnlMb9xs6uS95IPPG7bpkwzBOVHxVBmiFKRjeQ= From: Bertrand Marquis To: Ayan Kumar Halder CC: Xen developer discussion , "sstabellini@kernel.org" , "stefanos@xilinx.com" , "julien@xen.org" , "Volodymyr_Babchuk@epam.com" , "michal.orzel@amd.com" , Ayan Kumar Halder Subject: Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write Thread-Topic: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write Thread-Index: AQHY8Gnh8hKxIKIkAUWHK4BT2/fYBK4u9TuA Date: Fri, 4 Nov 2022 16:32:30 +0000 Message-ID: <3169C761-EA1E-40BD-B423-38399A798842@arm.com> References: <20221104162355.23369-1-ayan.kumar.halder@amd.com> In-Reply-To: <20221104162355.23369-1-ayan.kumar.halder@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|PA4PR08MB6142:EE_|VI1EUR03FT022:EE_|DB5PR08MB10312:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d263a71-fb4b-4507-9099-08dabe823156 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JP0NnYLGOkviv7HxRwIAEYsMBadmymE24a4DW0D6IoTaapNDtVQhdoduZ3IZM3DocVr5d+K0hqnlno4EjNgX8clPnvzZZStAZikGNW8uE0B7fb6tmkZwevT77OyPjXUS6vljuTztRA143VdzWzUGeSZ7GRd5LDuN4P8VdWCZrxEKgAclAWakns6p5uxEtceyEHDx8HS15XsSdiUmi9IXEadvgY4yvFCSyy2Ip6jVXQ5bM7oIe3zmnUMY8+L7/N6Eh1ux/mk/6hPeWQPYBB8mSuXn9p3gAx2i/MyIC8SYncqSFotRbtz33kaK095C2mIOj2nY3v1C+PMftfsVB4EgP4iNVha+aXsygrgcV1oyK+RTEEibNMvRKppH6X9cGW7Na+09YXe8UCj7NbU3NfPsEnfIe9stvfbspwqNgDPXTWR51q5QsGjXtAyZxyZq6HLwDU4CHKsAYJwx2YrvtdFWoo96EgUZ3wMACbarY9kVq8dnZdzigSoJNH2OY7gCohKefa5SQYdgFL21RrQEcLxz6cqdcHKi16JHnOvTKt3XXw3m3E6tX5WRljUfaYqBxpb0x9NCWBmDplkdFfw/7Oh/l2aRjx1mw9iUGTmL5a4qA43UUnkOTdQbe+saeIFMJnQESrcd02wUjO1PPt6WhRnq8wtVYfFtzyWzPiPuxQcDZ93ge+RpIFAUoql0enE+VTvOG8h70jR34mTZeGx6ImqVrJCyL7kQdZg/D90Dp+SsQQDNc+NoeDBPpWIWEX3LnNyFZuS5exwX+0EZKcVMLVmGAdpxhbPsuZnDn/NOnaf0/8w= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(366004)(396003)(39860400002)(451199015)(83380400001)(2906002)(36756003)(4326008)(6512007)(8676002)(64756008)(76116006)(26005)(66556008)(33656002)(41300700001)(86362001)(38070700005)(66446008)(66476007)(66946007)(122000001)(316002)(38100700002)(5660300002)(54906003)(8936002)(186003)(91956017)(6506007)(6916009)(53546011)(6486002)(71200400001)(478600001)(2616005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <39CBFC446C96844FA404B94189EDCA4C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6142 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a2048373-f35d-4634-7841-08dabe822af0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /zlvNRe95CC82E7/mYY8oyA0JIfWxHZCU87Mj+qkKk9ALasMDIxxh7AWxsti4NgpNALvNMBxC1Q0IDIsJuLV+7Uss8jEldfMiMB+t2AjaOkEUjPg4AQd67zmFSNfl4TFTi3frq+opuj/Ma5TLtBheNqd+heQu/uEUxwjGA++JIL5LaEHmuEsOBIUHmtV7OmIzzXeEd31Q1xmgQRMeQWEyG84DAgDwAn2/GUb5k223PtgzOsKEnw7/9gi3rDXRzJNRV5dd0dDQO67XSi6nWMCt3gsjn9JpK2Oheumq3bIrC4Fl3SjQb2f2poRLfL5TTId8/8AzkFzuqK85Qic2JZvcB0qFnrrIprXoz3dHt6U1UE/4bTM9Vd1d45i//AvgBjgsi4Du3wKopbSEqvovtTPLkMbEcMGf+MyuzpCf41PoW29zT+gh9l8u1xLOepy6UgBEH+rGM/15FRGrIvHxhqVzzSiUVRBQQAX8pF0ZGq55hb/OaanLDb2O8nGmD9FI9HQJncgqvJxZR2WsSInGcXW3lW++lKwekYsz5xU2MNfjZPRStO7zBhSwlVCUFTp2mSu2kCUYp8BYtvzqLiKBO7w30nl+71X/lUPWQMw/yaZ0QTge0yF6n1HXhLvNQmNyheuNPw5v8NbrrfdW/EMPmppslz09yieuqUxKnxkHsLxps4xAI4Ijk3kc8Vjbbb7AnzEyHGOO1QJUHQ47e1c3Wp/DKG2v4/rP2d1mMXmF043Mdm+9POhWvmEuYsXIwQmi5QDlp9HLkeJo23EgXs7zkSfEQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199015)(46966006)(36840700001)(40470700004)(6506007)(33656002)(5660300002)(6486002)(53546011)(26005)(82310400005)(6512007)(82740400003)(36860700001)(478600001)(86362001)(2906002)(36756003)(2616005)(54906003)(316002)(47076005)(40480700001)(40460700003)(186003)(41300700001)(81166007)(336012)(356005)(4326008)(8676002)(70586007)(8936002)(6862004)(70206006)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 16:32:40.8035 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d263a71-fb4b-4507-9099-08dabe823156 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10312 Hi Ayan, > On 4 Nov 2022, at 16:23, Ayan Kumar Halder wr= ote: >=20 > From: Ayan Kumar Halder >=20 > Refer ARM DDI 0487I.a ID081822, B2.2.1 > "Requirements for single-copy atomicity >=20 > - A read that is generated by a load instruction that loads a single > general-purpose register and is aligned to the size of the read in the > instruction is single-copy atomic. >=20 > -A write that is generated by a store instruction that stores a single > general-purpose register and is aligned to the size of the write in the > instruction is single-copy atomic" >=20 > On AArch32, the alignment check is enabled at boot time by setting HSCTLR= .A bit. > ("HSCTLR, Hyp System Control Register"). > However in AArch64, alignment check is not enabled at boot time. >=20 > Thus, one needs to check for alignment when performing atomic operations. >=20 > Signed-off-by: Ayan Kumar Halder > Reviewed-by: Michal Orzel With that fixed (can be done on commit): Reviewed-by: Bertrand Marquis Cheers Bertrand > --- >=20 > Changes from :- > v1 - 1. Referred to the latest Arm Architecture Reference Manual in the c= ommit > message. >=20 > xen/arch/arm/include/asm/atomic.h | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm= /atomic.h > index 1f60c28b1b..64314d59b3 100644 > --- a/xen/arch/arm/include/asm/atomic.h > +++ b/xen/arch/arm/include/asm/atomic.h > @@ -78,6 +78,7 @@ static always_inline void read_atomic_size(const volati= le void *p, > void *res, > unsigned int size) > { > + ASSERT(IS_ALIGNED((vaddr_t)p, size)); > switch ( size ) > { > case 1: > @@ -102,6 +103,7 @@ static always_inline void write_atomic_size(volatile = void *p, > void *val, > unsigned int size) > { > + ASSERT(IS_ALIGNED((vaddr_t)p, size)); > switch ( size ) > { > case 1: > --=20 > 2.17.1 >=20 From xen-devel-bounces@lists.xenproject.org Fri Nov 04 17:33:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 17:33:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437785.692259 (Exim 4.92) (envelope-from ) id 1or0Yq-0004Vc-8t; Fri, 04 Nov 2022 17:32:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437785.692259; Fri, 04 Nov 2022 17:32:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1or0Yq-0004VV-61; Fri, 04 Nov 2022 17:32:56 +0000 Received: by outflank-mailman (input) for mailman id 437785; Fri, 04 Nov 2022 17:32:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1or0Yo-0004VF-F1 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 17:32:54 +0000 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b38545db-5c66-11ed-8fd1-01056ac49cbb; Fri, 04 Nov 2022 18:32:50 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2022 10:32:33 -0700 Received: from anantsin-mobl2.amr.corp.intel.com (HELO [10.209.97.57]) ([10.209.97.57]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2022 10:32:32 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b38545db-5c66-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667583170; x=1699119170; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=pPOPNM3vYCz/Z1s0LA7RHwJYYh7DKEACrCv7Y9YF86s=; b=JPdy2S90tVikMPKiz6Aa9mtiOkR8DdycrmvJisEC/Z/rW+/CdJKWm5cO 1UeTHeJN5znUmeO6HnGTtguNuYkHQ95eh9/hq+haHvwviEKglMt1Lf5H6 UhzdmSF5yslzJRAwhFUff06zs/+no2kV5oZtH4oLKRxcJ89SkhN2k7nrE BviOOAx/Jk7pPh1SWhcIJbd/pCxmpk6F0frhEVhYIVlDsm7bWDGcTDt6n OvhS5syF0UTgsNF2ugXbThkobE/K0IJjit4TzAP9sa4HsFKVTVze7G8/n si8vQJbg93Xk6+GlF34J3qsTgZKN1JAelg2/NvWM8RAO6kx8wf2t8QoT2 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10521"; a="307648581" X-IronPort-AV: E=Sophos;i="5.96,138,1665471600"; d="scan'208";a="307648581" X-IronPort-AV: E=McAfee;i="6500,9779,10521"; a="635164724" X-IronPort-AV: E=Sophos;i="5.96,138,1665471600"; d="scan'208";a="635164724" Message-ID: <0a04e55c-ccfb-9383-1768-a88f4602fb4e@intel.com> Date: Fri, 4 Nov 2022 10:32:32 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 5/5] x86: switch to cpu_feature_enabled() for X86_FEATURE_XENPV Content-Language: en-US To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Pu Wen References: <20221104072701.20283-1-jgross@suse.com> <20221104072701.20283-6-jgross@suse.com> From: Dave Hansen In-Reply-To: <20221104072701.20283-6-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/4/22 00:27, Juergen Gross wrote: > Convert the remaining cases of static_cpu_has(X86_FEATURE_XENPV) and > boot_cpu_has(X86_FEATURE_XENPV) to use cpu_feature_enabled(), allowing > more efficient code in case the kernel is configured without > CONFIG_XEN_PV. As with the rest: Acked-by: Dave Hansen Seems like a very straightforward, sane set of cleanups. From xen-devel-bounces@lists.xenproject.org Fri Nov 04 17:33:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 17:33:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437786.692266 (Exim 4.92) (envelope-from ) id 1or0Yq-0004Z6-Jx; Fri, 04 Nov 2022 17:32:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437786.692266; Fri, 04 Nov 2022 17:32:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1or0Yq-0004YT-DU; Fri, 04 Nov 2022 17:32:56 +0000 Received: by outflank-mailman (input) for mailman id 437786; Fri, 04 Nov 2022 17:32:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1or0Yp-0004VL-24; Fri, 04 Nov 2022 17:32:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1or0Yo-0006wO-Sw; Fri, 04 Nov 2022 17:32:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1or0Yo-0007SL-Fu; Fri, 04 Nov 2022 17:32:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1or0Yo-0002HQ-EA; Fri, 04 Nov 2022 17:32:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Govh5DjhNNuAOGCbx4GYB+zWmxEdT+rRTat/cBMfbxk=; b=SnJZbCROOE0oYWZLzijqphcOW0 URb4AzF503AK6N4kVon8i/2r0xhbpCwdqFF40/9cf8kNzOUBRNHIdD44NBr540Y3e46Ile8/rW0BR qGKQ9kEqgT0Dll2HcGbK5g7+hqk7WKii7D+18URrVVUQD6fLTTunnJdyh1i2//NC+flE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174616: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-armhf-armhf-examine:host-install:broken:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=2d9b3699136d20e354a94daefebbeefa9ceec7b6 X-Osstest-Versions-That: xen=2d9b3699136d20e354a94daefebbeefa9ceec7b6 From: osstest service owner Date: Fri, 04 Nov 2022 17:32:54 +0000 flight 174616 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174616/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-examine 5 host-install broken pass in 174607 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 174607 pass in 174616 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 174607 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 174607 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174607 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174607 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174607 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174607 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174607 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174607 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174607 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174607 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174607 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174607 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174607 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174607 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 3 hosts-allocate starved n/a version targeted for testing: xen 2d9b3699136d20e354a94daefebbeefa9ceec7b6 baseline version: xen 2d9b3699136d20e354a94daefebbeefa9ceec7b6 Last test of basis 174616 2022-11-04 04:42:55 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-step test-armhf-armhf-examine host-install Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri Nov 04 17:35:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 17:35:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437795.692281 (Exim 4.92) (envelope-from ) id 1or0bJ-0006EG-1T; Fri, 04 Nov 2022 17:35:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437795.692281; Fri, 04 Nov 2022 17:35:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1or0bI-0006E9-Um; Fri, 04 Nov 2022 17:35:28 +0000 Received: by outflank-mailman (input) for mailman id 437795; Fri, 04 Nov 2022 17:35:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1or0bG-0006E3-P5 for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 17:35:26 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 10f976d8-5c67-11ed-8fd1-01056ac49cbb; Fri, 04 Nov 2022 18:35:25 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id fn7-20020a05600c688700b003b4fb113b86so3624647wmb.0 for ; Fri, 04 Nov 2022 10:35:25 -0700 (PDT) Received: from [10.85.37.166] (54-240-197-228.amazon.com. [54.240.197.228]) by smtp.gmail.com with ESMTPSA id f11-20020a05600c4e8b00b003b435c41103sm5125489wmq.0.2022.11.04.10.35.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 10:35:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10f976d8-5c67-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=pHQIylP4BMaKx4/MaFeoDjr/JLtHrpYofumoioa74sw=; b=pPJDTk88r42WOVvSsOetGHQK+mqPoxtCExYlowuSg+a9gnA3gFaTzyrRL4jbJDZJAf np9Ma3LUKIhY4IeDne8YcTQ1S8NX/wR/pzqU5Qr6po5P2GMaggTGg7W9wWNTJbgJ6QZN Qqk+NKCRHoH+5sljCXuKj2f10n+3cyyrd/mL+dpKUq2ryI8RIWwZAAGuUjeJR1FedFh3 tqeaeiGBN0NdY6mr+ALGm5//BI58Vrp+jPF1l6dzcr65tngfs5ZPLzboyv3Jcy52moSN 8sEyIIPRDtLXRMHXdhCErSV74Uc13cINkvP2LbinVtdk4bPQ7wrjoZkkJH07ZqKYbl/t 4mMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pHQIylP4BMaKx4/MaFeoDjr/JLtHrpYofumoioa74sw=; b=hBI8tm0Qr+bZHhQGn7smS0gACYgPhMVVKPKsV4mfIXP4RbjlbOpkbvNjAhb9izO0ku kBe5gmRdVCuX6kAhXVu9JzubQ7bY55eOJrMMd5s70QTx2VMByTldHL8ylQSzvkTz5X4w dTlhYfg+nlP5HzpJSVOrV5FbAIcT4dVWEE6OkFOE1hanHTaPCIuws1CNsrtB6z8BVVY2 GlKluD6Ms8F5x8XLFDwrqeINTTyyN52hHhJZP4onmGQLl9qx0SN0Vs0WJJjNXqE36+lH pkdOscYZjWVGlLOeooIo63lZvfLXYaZ5b8f7MXN4G/84F48BklAXPGsqCWcueLgaGu/3 1EuQ== X-Gm-Message-State: ACrzQf3k5kq6ecLObstqCxFO5yNpQLQZqzYMvrFqIbe76wxn80idOS53 uoTMT2zWOPbY0HalIqvhZ8s= X-Google-Smtp-Source: AMsMyM7xrwRq4s8Rt/boxcuuZl8V5Ezez8Ygw2S19zXCPmVNvupIpmvESuV1uWSxvGyZi5E+kRqbZw== X-Received: by 2002:a1c:c90c:0:b0:3b4:adc7:9766 with SMTP id f12-20020a1cc90c000000b003b4adc79766mr25037057wmb.66.1667583324988; Fri, 04 Nov 2022 10:35:24 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <2c2d8b2b-e607-6d9d-b991-d1c065aac95d@xen.org> Date: Fri, 4 Nov 2022 17:35:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 2/2] hvm/apic: repurpose the reporting of the APIC assist options Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, Henry.Wang@arm.com, Wei Liu , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian References: <20221104142235.36556-1-roger.pau@citrix.com> <20221104142235.36556-3-roger.pau@citrix.com> <2a3c5141-516d-a5e4-392b-e7fe54f3781c@xen.org> <9a505567-57be-a7b4-7cab-d1d737172db0@xen.org> Organization: Xen Project In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 04/11/2022 16:10, Roger Pau Monné wrote: > On Fri, Nov 04, 2022 at 04:05:05PM +0000, Paul Durrant wrote: >> On 04/11/2022 16:01, Roger Pau Monné wrote: >>> On Fri, Nov 04, 2022 at 03:55:54PM +0000, Paul Durrant wrote: >>>> On 04/11/2022 14:22, Roger Pau Monne wrote: >>>>> The current reporting of the hardware assisted APIC options is done by >>>>> checking "virtualize APIC accesses" which is not very helpful, as that >>>>> feature doesn't avoid a vmexit, instead it does provide some help in >>>>> order to detect APIC MMIO accesses in vmexit processing. >>>>> >>>>> Repurpose the current reporting of xAPIC assistance to instead report >>>>> such feature as present when there's support for "TPR shadow" and >>>>> "APIC register virtualization" because in that case some xAPIC MMIO >>>>> register accesses are handled directly by the hardware, without >>>>> requiring a vmexit. >>>>> >>>>> For symetry also change assisted x2APIC reporting to require >>>>> "virtualize x2APIC mode" and "APIC register virtualization", dropping >>>>> the option to also be reported when "virtual interrupt delivery" is >>>>> available. Presence of the "virtual interrupt delivery" feature will >>>>> be reported using a different option. >>>>> >>>>> Signed-off-by: Roger Pau Monné >>>>> --- >>>>> I find the logic in vmx_vlapic_msr_changed() hard to follow, but I >>>>> don't want to rewrite the function logic at this point. >>>>> --- >>>>> xen/arch/x86/hvm/viridian/viridian.c | 2 +- >>>>> xen/arch/x86/hvm/vmx/vmcs.c | 8 ++++---- >>>>> xen/arch/x86/hvm/vmx/vmx.c | 25 ++++++++++++++++++------- >>>>> xen/arch/x86/traps.c | 4 +--- >>>>> 4 files changed, 24 insertions(+), 15 deletions(-) >>>>> >>>>> diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c >>>>> index c4fa0a8b32..bafd8e90de 100644 >>>>> --- a/xen/arch/x86/hvm/viridian/viridian.c >>>>> +++ b/xen/arch/x86/hvm/viridian/viridian.c >>>>> @@ -201,7 +201,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, >>>>> * Suggest x2APIC mode by default, unless xAPIC registers are hardware >>>>> * virtualized and x2APIC ones aren't. >>>>> */ >>>>> - if ( !cpu_has_vmx_apic_reg_virt || cpu_has_vmx_virtualize_x2apic_mode ) >>>>> + if ( !has_assisted_xapic(d) || has_assisted_x2apic(d) ) >>>> >>>> So, not sure why this is separated from patch 1 but stated this way it seems >>>> counterintuitive. We only want to use the viridian MSRs if they are going to >>>> be more efficient.. which I think is only in the case where we have neither >>>> an x2apic not an assisted xapic (hence we would trap for MMIO). >>> >>> I've read the MS HTLFS and I guess I got confused, the section about >>> this CPUID bit states: >>> >>> "Bit 3: Recommend using MSRs for accessing APIC registers EOI, ICR and >>> TPR rather than their memory-mapped" >>> >>> So I've (wrongly) understood that MSRs for accessing APIC registers >>> was meant to be a recommendation to use x2APIC mode in order to access >>> those registers. Didn't realize Viridian had a way to expose certain >>> APIC registers using MSRs when the APIC is in xAPIC mode. >>> >> >> Yeah, I think they predate the existence of x2apic. >> >>> I withdraw patch 1 and adjust patch 2 accordingly then. >>> >> Cool. Thanks, > > How does Windows know whether to use xAPIC or x2APIC? > cpuid? TBH I'm not sure why this recommendation would ever trump x2apic anyway. > I would assume CPUID4A_MSR_BASED_APIC only makes sense when in xAPIC > mode, as otherwise the registers are already accesses using MSRs. > > Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Nov 04 17:38:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 17:38:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437802.692292 (Exim 4.92) (envelope-from ) id 1or0do-0006vy-J2; Fri, 04 Nov 2022 17:38:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437802.692292; Fri, 04 Nov 2022 17:38:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1or0do-0006vr-F0; Fri, 04 Nov 2022 17:38:04 +0000 Received: by outflank-mailman (input) for mailman id 437802; Fri, 04 Nov 2022 17:38:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1or0dn-0006vj-4F for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 17:38:03 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6e2a76ab-5c67-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 18:38:02 +0100 (CET) Received: by mail-wr1-x433.google.com with SMTP id cl5so8013596wrb.9 for ; Fri, 04 Nov 2022 10:38:02 -0700 (PDT) Received: from [10.85.37.166] (54-240-197-228.amazon.com. [54.240.197.228]) by smtp.gmail.com with ESMTPSA id h7-20020a5d4307000000b00236883f2f5csm3823997wrq.94.2022.11.04.10.38.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 10:38:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e2a76ab-5c67-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=vMeDD9OFej7/HtR8QIaN555ulxMS6lA7UV50wOqUVB4=; b=lXtpgEYuW1pdBz8aq6j15drhUo9VObzsGpfBwQfeBl1U6Tm9sL8N7IV1CSoyJGnR37 rB+dz3FRpG9vPMkn/A6N1apBIzsmbOaODzyUVixwGNwIxgscsgVRlswck12I5hYSn9QP B+8JHhWll7XCulfzBY3ne8b42gWyccjevElfC1A201TCQFKvnOBQB8sMJZZJuHclN2Om NHAgNqUZvGvk3qNVGeAj4CGgwmDE+PAwN8EgotouRssiewoIqdbTMqiWJp08UxifWdmP WCkKVeZU/ZxaZO90inbN2zFc0QnEjx7ZKvRyckTmeWSjabTKeC6DJNbjyIAE60GZDxmE Xixg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vMeDD9OFej7/HtR8QIaN555ulxMS6lA7UV50wOqUVB4=; b=IiEfs3kPrsuc9Y1JOh4AoSkp0darX6JjECKaaGFpqTh56yc2rVphAQ99g1xE+/kCOj uQQOyskuFX5G2HvzboiLQryCbiGQO3Zkd7IFc0+bg3CaOxUj/0BSD1TeTD/8OfMIRqSw nLkersXY2bupUPz+OSoaslVXefslS/khHrdGZRh3dBj4fG+2CkwPOPqxl7RZZK7WAklY VM9udpEdtNr10TngwzPyOt/BQlzCbvJCLobNZKyQnb8DMR5eGCtLabSlqsIVz60hFXRq LazKQooLoGdGrMhGwhsrvsIvHN/BtNmhmvZgjos0IfDxl5wQXRkUfYbOO1OO/Pbtock9 VJiQ== X-Gm-Message-State: ACrzQf1cwoEeH5jRrElXDPObNgL2RLyZBsLxcfH2wE3v7Eiw5Q9ARIcQ LvI5QUtWzj2kkmNJkdaVNg0= X-Google-Smtp-Source: AMsMyM5UKQh5a8rsvtrdsTxI43CyztD0sdTIWgUuqB3GUOCyj/YG8GmJ6NIAntjZwjO+UofLN0HK9w== X-Received: by 2002:a05:6000:104:b0:236:a6f4:c67f with SMTP id o4-20020a056000010400b00236a6f4c67fmr23197448wrx.82.1667583481403; Fri, 04 Nov 2022 10:38:01 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: Date: Fri, 4 Nov 2022 17:37:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Content-Language: en-US To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Wei Liu , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian References: <20221104161815.38007-1-roger.pau@citrix.com> Organization: Xen Project In-Reply-To: <20221104161815.38007-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 04/11/2022 16:18, Roger Pau Monne wrote: > The current reporting of the hardware assisted APIC options is done by > checking "virtualize APIC accesses" which is not very helpful, as that > feature doesn't avoid a vmexit, instead it does provide some help in > order to detect APIC MMIO accesses in vmexit processing. > > Repurpose the current reporting of xAPIC assistance to instead report > such feature as present when there's support for "TPR shadow" and > "APIC register virtualization" because in that case some xAPIC MMIO > register accesses are handled directly by the hardware, without > requiring a vmexit. > > For symetry also change assisted x2APIC reporting to require > "virtualize x2APIC mode" and "APIC register virtualization", dropping > the option to also be reported when "virtual interrupt delivery" is > available. Presence of the "virtual interrupt delivery" feature will > be reported using a different option. > > Fixes: 2ce11ce249 ('x86/HVM: allow per-domain usage of hardware virtualized APIC') > Signed-off-by: Roger Pau Monné > --- > I find the logic in vmx_vlapic_msr_changed() hard to follow, but I > don't want to rewrite the function logic at this point. > --- > Changes since v1: > - Fix Viridian MSR tip conditions. Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Nov 04 21:05:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Nov 2022 21:05:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437829.692303 (Exim 4.92) (envelope-from ) id 1or3s9-0005SS-50; Fri, 04 Nov 2022 21:05:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437829.692303; Fri, 04 Nov 2022 21:05:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1or3s9-0005SL-2B; Fri, 04 Nov 2022 21:05:05 +0000 Received: by outflank-mailman (input) for mailman id 437829; Fri, 04 Nov 2022 21:05:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1or3s7-0005SF-Jm for xen-devel@lists.xenproject.org; Fri, 04 Nov 2022 21:05:03 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 574ae4be-5c84-11ed-91b5-6bf2151ebd3b; Fri, 04 Nov 2022 22:05:00 +0100 (CET) Received: from mail-dm3nam02lp2045.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Nov 2022 17:04:57 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by PH0PR03MB6266.namprd03.prod.outlook.com (2603:10b6:510:e2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 21:04:55 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::5d4b:6b1d:efc2:20e5]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::5d4b:6b1d:efc2:20e5%9]) with mapi id 15.20.5791.022; Fri, 4 Nov 2022 21:04:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 574ae4be-5c84-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667595900; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=o22GLfwmw0A7lrA4JSlXduGjCIrmGoI2HUBL5qOumWQ=; b=PIiCBF4C2rMQRk7LZD1u1XIOJZ01f7ZdzpuJxzUXBTGxpOB9a5gU5rh5 4Ihm0kX4ewNk/2bLYH9NMhtXHjyTU0o7k4USi1Bmbug2ApLb9mzsrxnYA 4YJxT9W3QoYdXKwoIJuQIECyhi62gDxzeE9VGmJQ5kqlgS7yQp3ZiWTWX E=; X-IronPort-RemoteIP: 104.47.56.45 X-IronPort-MID: 84205673 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:q9FiPa7TkFizOZRfC2AVsAxRtF/HchMFZxGqfqrLsTDasI4TYg02e lBvGjDRZK7OJyCgZYg1O70CxjpQvMKDz4VgGVNo/3szHnsQ85qdCYnEcEmvZnmbccOaRk464 s9OYNfMfJ8+EiCBrEehOOWw8SZx36iBHLOhAbWZUswdqXeIbQ944f40s7Jp0uaE+OSEPj5hm e8eguWBNgD9gzMoYz5L4vOKpRli7P6i4mMRtFE1PP0U4ASPxyhJAMoTK5/qIiqjSOG4PAIYq 8Xrl+jlozyDr3/BLvv/z94Xp2VTGua60TCm0yYQAO76x0AY/UTe645jXNIEc0Bblj6VqN54z dRJpPSYRBwge6bBg4zxaTEBe81FFfAAqeGvzUSX65TJlRSfKye0mJ2CMWltVWEm0rcvaY1x3 aRwxAAlNnirm++wybSnfehg7uxLwB7DZd53VtlIlFk1PN5+KXzxa/yiCexwhV/csvtmD/fGD /f1XBI0BPj2j7+jDX9MYH42tL/AanAS6FS0onrNzUY8yzC7IACcTNEBmTcaEzCHbZw9o6qWm o7J12PeWz0AE9qN8zjf1nP32f/OgDzRZo1HQdVU9tYy6LGS7ko6LUVMEHee+ry+gEP4XM9DI UsJ/CZotbI16EGgUtj6WVu/vWKAuRkfHdFXFoXW6inUkvaSv1nfWzZCEmMphN8O7afaQRQF2 1iTkN6vKSFptLSNYXmc6q2VvXW5Pi19wWoqNXNeFVZbvIKLTIcbyTjBZI19GqePtMTWHQ2p+ QmBtQEGruBG5SIM/+DhlbzduBquqYLOVRUd/RjMUySu6QYRTJ6oYcmk5EbW6d5ELZ2FVR+Rs X4cgc+c4esSS5aXm0SlQu8AAbWo7PatKyDHjBhkGJxJ3zaw/3+ue6hA7Tc4I11mWu4fYiPga kLXvQJX5bdQMWGsYKsxZJi+Y+w1yYDwGNKjUerbBvJub55rZUm49SdhTUeK2ibml01ErE0kE ZKScMLpAXNBD61ilGCyX71FjeJtwT0iz2TOQ5y91w6gzbeVeH+ST/ECLUeKaec6qqiDpW057 upiCidD8D0HOMWWX8Ud2dd7wYwiRZTjOa3Llg== IronPort-HdrOrdr: A9a23:Tg3cOq7O9OHNYulI7QPXwX6BI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qADnhORICOgqTP2ftWzd1FdAQ7sSircKrweAJ8S6zJ8k6U 4CSdkyNDSTNykdsS+S2mDRfLgdKZu8gdmVbIzlvhVQpHRRGsVdBnBCe2Om+yNNJDVuNN4cLt 6x98BHrz2vdTA8dcKgHEQIWODFupniiI/mSQRuPW9p1CC+yReTrJLqGRmR2RkTFxlVx605zG TDmwvloo2+rvCAzAPG3WO71eUZpDKh8KoDOCW/sLlXFtzesHfrWG2nYczGgNkBmpDu1L/tqq iJn/5vBbU115qbRBDJnfKk4Xid7N9p0Q6v9bbQuwqcneXpAD09EMZPnoRfb1/Q7Fchpsh11O ZR03uerIc/N2KIoMxsj+K4KC2Cu3DE1kbKq9Rj+UB3QM8bcvtcvIYf9ERaHNMJGz/78pkuFK 1rANvH7PhbfFuGZzSB11Mfi+CETzA2BFOLU0ICssua33xfm2141VIRwIgakm0b/JwwRpFY76 DPM7hulrtJUsgKBJgNTNspUI+yECjAUBjMOGWdLRDuE7wGIWvEr9rt7LA89IiRCeg1JVsJ6e H8uX9jxB0PkhjVeLyzNbVwg2DwaXT4WyjxwcdD4JU8sqHgRdPQQF++dGw= X-IronPort-AV: E=Sophos;i="5.96,138,1665460800"; d="asc'?scan'208";a="84205673" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PU7q8TLAAwZ8GqVeNX0VQieGLykl2y27++9pDFXjCo9Oj3SiTE777aNqPRirDjnJIBUADpP8KIEfZgJZA8XzoiYMlenAWiBK1kqJyKPVSoYY3kM6SJ5o0vd6yhGiQOemfPDK2cbOJBcs1ry9GR/uzC0oP7N035QKGH0UshBS9uquNpFstjpbIbDfVbMY9KOudvdNkA54nlHmO4tPhrAde6WaLdoQTFPMYFLWEVUDZtSHaK9JHG1HeiT3FKFX3SnE82/kWvJhVNCy2117gIZ6JQ/OazJZXo5S1E88Gs83GiBdB2nWfDPcKAPWhstT4U074YYYGefiRb55fHxc48mX5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OTAADyTg9FxyWr19S8eITGmI5jD4J9aOHbtGBQR31p0=; b=MKDCmVdirkctUXT9Wd+Cf0KUNY19AJHp0NBPJGRFmh+418qAOgAAtem/gVwlsmi3ua3Ai/6auzt9BB0VZ5QdC9iMSUCZ/M12nNfWigbhrDJxexHNzqIY3LeoZFjpGtHljJhruUDrxB2bqGajzlts1ygspSOBWAa0zzFQxF4sWERrs99S8SVpjjUItB5jGjTOft3xqMS91vqGPeqNktFLeeFRinspOoMW7/QuhflusbEJSD/CYAAnQzmY7JJGfeQD35n4jBF1Ac9oOiJASLdKKFktRERCU4NRyIzaIY3edG6/KG4jW6dBMG8C63TSlrHXdcH84QKSuDg9D35Jq5Qz3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OTAADyTg9FxyWr19S8eITGmI5jD4J9aOHbtGBQR31p0=; b=O9xkJ46ApqWvRoZIH0Njm2/JJBBNDccEy08KfAy+cCwYdemvKGHRgBSPm7I7ywJir9HW75MsAa4aDJkZzS29UR4/07B2dDxSb8tgkLPzZt7jDk34TZWQP7051POyD4cuOZ7Ai6WZHFq6g8GaaTV2sFawLKjVhR8IbkkQqOLEQ74= From: George Dunlap To: Andrew Cooper CC: Juergen Gross , "xen-devel@lists.xenproject.org" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang Subject: Re: Revert of the 4.17 hypercall handler changes Re: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers Thread-Topic: Revert of the 4.17 hypercall handler changes Re: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers Thread-Index: AQHY76JzZdOUSWsV/EuMjC67io5Dyq4uNcAAgAENE4A= Date: Fri, 4 Nov 2022 21:04:55 +0000 Message-ID: <23500966-F3C9-4486-BC57-F079977BC716@citrix.com> References: <20221103163631.13145-1-jgross@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR03MB5669:EE_|PH0PR03MB6266:EE_ x-ms-office365-filtering-correlation-id: 695c2cab-607c-4198-bc41-08dabea83947 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F40jmCb31eOengy4Jvx+K+CpaLwQpGFwrFiX/89QtF7M2HwMsx1V6cwzgs3Np6S7JfBVK1IktAn1FXHVF7Bb/L8FyfLjJhffmgz3w300r73SjW6Q95D/X5oKN3owLr5j3gED+RiCKWZvWgjssBVRjFDK533ElRMGi4kjG+AwOpFXcIHv5mmCsvPck9NhSjVf3mC8R3rIBO7svdw1qvwm5yiq+0soEYgACgDamSeVW0SShNnbU0xjpV3fm4X3lDwIiw6ZfZOsolJygjgnuxiiVHRUVqJRl5LuQfjcWU3WtQ0pFzvvBfxn3IK741S9xF5Hx06DxVV6aW1RpeAcQ/7hdhTFdvJQF7ivej6uhwjQdFjZ5xPPZ8f9YajvviH9c4eT+N8Uc6tCnfQWBU21zSTampWu9uIP6paE1z112VXqRCqeISUg30+cTGPXNpS1zsts/LrtwENe/lgOpU9sqXIkPMf4RKfhrTTNs6Fdz8QsjAZhItDwBRnE93yOLjfAajeOeD5srAYz9CJ8jcycckt8Gn1bbY2M//SCnP4YV4hIP4uvX8WF2XPGWMyYbB+VanDNiktjCGmTrhO5EcRxv8127U/KHPuEyYoWV1wtEYsr5OqnPyaK4uQolKmybWQmGiLFTWaVCI4djQBDEJLoENxwmTdbSVEMbxXltA1whh5FHDeqP487D0pFO9ZzEqnOAw6r792Lg4ncFGjpuKLMnwRdz+4T2c4SNVuw0+YZrDvFmw5PZbs5c7crC1Qck4rEnCFlP7hqTjpPioDX8gLzvHRfztZgrsyGqXRAxdEYeW3qwG3EVtpO0x+P5SxyPinJ5PKK x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(39860400002)(366004)(376002)(451199015)(316002)(54906003)(6636002)(82960400001)(37006003)(71200400001)(41300700001)(99936003)(33656002)(83380400001)(5660300002)(6862004)(8936002)(38100700002)(4326008)(76116006)(8676002)(66446008)(64756008)(66946007)(66556008)(66476007)(91956017)(122000001)(38070700005)(6486002)(53546011)(6506007)(66574015)(2616005)(6512007)(26005)(186003)(86362001)(478600001)(2906002)(36756003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aDFOS1Nwb0xFdWlBOW12bllOSDFtYVFuSnRpYTlLYStiaytLZFQ5RExaVDdr?= =?utf-8?B?OE1OZDVDbmdtNHJDWlhzNkx1VzFlTUVOeldwelhSRkxML2Y3MXRtbFcvU1h2?= =?utf-8?B?S1UxUXlxbzlKd3dsamlFckdVSVhiNlZUYjZyTUI2T1ZEd3pjWnFIc2RDQ2x6?= =?utf-8?B?SENBZ0orOC9wNWdDUjNRVmQ4c2N1VUd6cVQ3c1pKUG5VUDZ5eWx1dDcvN0d1?= =?utf-8?B?L1VyOG1pSWU5eXIxalVWL1Bpa1JidzN5Q1NzTVhEYys3MnF1ejFyUFRTbzcz?= =?utf-8?B?Q2Zrc1FPOVp6WVhzSmVIdUtyejZCeDg4VGVteHQ1ZmxGUFZnckY2OUovY0V3?= =?utf-8?B?Lyt1aUcxeDBMaTY4SDBqVXZvMnVjWTN2RVRxV2djN3hEaXZxTlRWRTFFcVNz?= =?utf-8?B?ZFlOOVJCdVo5aGRwYlV0U0pBRWdxdFY5dm5yK1FHdkZoV3dYLzcxMmxnbE5I?= =?utf-8?B?akt1bzZxQUt5Y2diSEVwOWlqbk1BcmwzaElJOXhWUU9VQ0lBT0FuNExIKy9z?= =?utf-8?B?U0V0cVBWOFBkZmI3QU9Vd2FjODljaFlORU5nRHJYZW1NN0ptdG5sakxiLzZ1?= =?utf-8?B?Q0ZwWFlyanlSODIzODMrUi9XVUNVdFJGM1ZGY2EvSnhMYzFGQmNuMEF6RVhI?= =?utf-8?B?MFBodncvYUdnb1hBZXRaNGJybkY0ODZuekt4WmRBZC82dzJ3czZiY085MEwr?= =?utf-8?B?T3I5UXNzbzB0STNFN2RJaWp0L0l6bW5jTVFUeHA3Q2luMi9zdm95WmgzYmxE?= =?utf-8?B?c0R6dFJRN0xUdVdUbSt0eGdoV2h3eDhVeldaSmhqR1gxSVlaNkw2VkxPdlZK?= =?utf-8?B?Q3hJU2NXQnR6SlE2UWpaNmY2M0E4bU13UlRiNURJRG8zVnFFS2lUOHJEcEZt?= =?utf-8?B?WXo4ZUxDdjhRQ1RpRkZVTDkzWGFlVHM2dEZ5dzJCa2ZCQmY3cUZUMlJhcG9B?= =?utf-8?B?U0FxSDFYbWkvenNQTmdkZG1vVXRZelhKdm5Ua0c0WGVocFoxYzEwTHV0SWZN?= =?utf-8?B?VFJmaUhnWDl4c1V4VWFGMS9RWTlLY2VCNXo1ZytKaHR5L2xVVjllZm9wV0NI?= =?utf-8?B?ZExIbHQ2Q0R0Y0o3TTlGRFVxQUQ0ejY2VGNtRjJ5YnNqRHBidm1pWXFQOFJ0?= =?utf-8?B?UmRMeCtyWW9hdFExd29lVVRxUVYyZ1lFaGwxQnpOWVAveWpEM2hFRklTS0di?= =?utf-8?B?dnFsaU5nblZSdUFTTjZ1eit4Qm83RkhTR08xVXdPYldVaGNxVGxyVUdRM3Fp?= =?utf-8?B?ZEFrclRkS0pvVHJna1ZiNTczUWdJSXpXVTZEbzlRR2FDSmNsMmVBTUJ2djYv?= =?utf-8?B?dTdlcndWb2hOa0FibWtTNUxOUTBtRlU4MzloNjlpM1ZhZ3AvYlgxaEVqSTk1?= =?utf-8?B?MjlNMGsrLzF4eGlzUjBpajYrMEQ2VXczeW16OWpNU2RydkhHbDVqbzlpUU5x?= =?utf-8?B?VnlRa1l1T1dWVDFBdXJrTW9MSHhHWTh5ZjdBaXNSZm9KZ0Z6R3o0eUVKeWJQ?= =?utf-8?B?L1lML3Q0SzRnZGVkUkREWnB2WVNoRUtMTmMxQkN1bEdITEhwNmk0SVdIV0F1?= =?utf-8?B?azVkY1FUcFlrRTdOa1FweW9FZ1o0d0FuenBIWVlPUWErV2dLY1Bkd3FEL0JE?= =?utf-8?B?RG9mcE4rRzkycmFxMkd4RE5jc3lSRmhMbjlUcEk2NERUeVl3enBDZ2Z1d2ds?= =?utf-8?B?SkNVSlNPOHF6czhBZFBvOTNGdy9BLy9XR1I3NmtQV1dCeUJXaXFSRkY1dTlG?= =?utf-8?B?eDNFNktXWlUzQ3FwdzlZU3RSRWZjaVlNMzFVU3JGOTRFRnJ4dmE5TjkrWnBF?= =?utf-8?B?bERYOGxNM3QvWkhpZnRYVTAybDd1b1RHUUVpRGo0cDVyVEJ6SStsRHhwTDRB?= =?utf-8?B?a1ZKVVoraWFob2FzSUFjSnQ2OUY2SUNtKzg0NzVxL1NVaXg4b1ZUay9Pd2Fk?= =?utf-8?B?S3FBNlVzWklDUzA2Z0MvMHNWVTFsWEx3RG9uaXJrdGwxNVBheHp6d3Q4QTZp?= =?utf-8?B?cXJ3VGl2djdxbVIwNi9YaEhRQzhReCtkTVhHdjU1eGJOYldncnJIZnhKNnVX?= =?utf-8?B?Z3BVR2pDUFB1TVhPUnBpM0U2SHlETmpJcFlGYzhVS2NndVcwMlJQMkNkek42?= =?utf-8?B?R01FOS9TdzJkQURDaDI4SzlPMlNFYWtkaUJEV2VCMEwrZnRJZWdLalVOamRX?= =?utf-8?B?NEE9PQ==?= Content-Type: multipart/signed; boundary="Apple-Mail=_99E10F5F-7C3F-4CBC-87A4-578AB09B16DE"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 695c2cab-607c-4198-bc41-08dabea83947 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2022 21:04:55.0819 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BUzTk/r+S06aXsjAIQkgUWhdE5d60q7AT1Oug70jh9tiGeFvXfbtnisIVvU2K8fc/IxFpEPbCslc9jpNOIjX4JBaf1UngaUSAQLlGUNosT4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6266 --Apple-Mail=_99E10F5F-7C3F-4CBC-87A4-578AB09B16DE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 4 Nov 2022, at 05:01, Andrew Cooper = wrote: >=20 > The series claims "This is beneficial to performance and avoids > speculation issues.", c/s 8523851dbc4. >=20 > That half sentence is literally the sum total of justification given = for > this being related to speculation. The cover letter, written on 15 Oct 2021, mentions =E2=80=9Cavoid[ing] = indirect function calls on the hypercall path=E2=80=9D. Internal = security@ discussions from the time show that we were talking about = Spectre-BHB (AKA BHI) and its impact on function pointers, specifically = those in the hypercall and exception dispatch. Given that Spectre-BHB = wasn=E2=80=99t made public until March 2022, it would have been a = violation of the embargo for J=C3=BCrgen to go into more detail at that = time. It appears that your view on whether hypercall function call tables are = a vulnerable surface of attack has changed. But given that you once = believed they needed protecting, it=E2=80=99s not unreasonable for other = people to think that they may need protecting; and given that it=E2=80=99s= reasonable to think that they may need protecting, you should at least = give a *little bit* of a justification for why yo believe they don=E2=80=99= t, rather than simply falling back to, =E2=80=9CThere=E2=80=99s no = evidence=E2=80=9D. -George --Apple-Mail=_99E10F5F-7C3F-4CBC-87A4-578AB09B16DE Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmNlfmUACgkQshXHp8eE G+2Zjgf/V2PqMduiNjBswzS/uJfhqBB6B6+ALDcz23F32dubh+7HWsco2JdcQS/W bRRUI094/OeKcJ7Ez+p9T0hevFiNHYmpElrzcVECOxzT9RCASKoYktMPUhyyvLZy 5T9SPiZvXoVB0MF5cNSc6xGOyIgPHVPaJPwoUXrVxAteC+YBxgRNop4iQHLa42az dMziD9HBLBQ52vDPWvcbgovxrUUzrioOyFumglbtN4TOTBcOvz0ScIhsIXx55uyW kW8NqBFEGbOeEm9lAvB74MwDjIjf1GguEAwnZBDGSN/704yb+HkKN9HRrII6nTfP 9x6h/gcJ9YTXNfaIPqlFFzgpTseOAw== =Y/W2 -----END PGP SIGNATURE----- --Apple-Mail=_99E10F5F-7C3F-4CBC-87A4-578AB09B16DE-- From xen-devel-bounces@lists.xenproject.org Sat Nov 05 01:43:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Nov 2022 01:43:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437977.692368 (Exim 4.92) (envelope-from ) id 1or8Dg-0003cV-HK; Sat, 05 Nov 2022 01:43:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437977.692368; Sat, 05 Nov 2022 01:43:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1or8Dg-0003cN-AL; Sat, 05 Nov 2022 01:43:36 +0000 Received: by outflank-mailman (input) for mailman id 437977; Sat, 05 Nov 2022 01:43:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1or8Df-0003cH-31 for xen-devel@lists.xenproject.org; Sat, 05 Nov 2022 01:43:35 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2087.outbound.protection.outlook.com [40.107.247.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 40646062-5cab-11ed-91b5-6bf2151ebd3b; Sat, 05 Nov 2022 02:43:31 +0100 (CET) Received: from AS9PR06CA0639.eurprd06.prod.outlook.com (2603:10a6:20b:46f::26) by PAXPR08MB7624.eurprd08.prod.outlook.com (2603:10a6:102:242::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Sat, 5 Nov 2022 01:43:22 +0000 Received: from AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46f:cafe::a5) by AS9PR06CA0639.outlook.office365.com (2603:10a6:20b:46f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.24 via Frontend Transport; Sat, 5 Nov 2022 01:43:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT019.mail.protection.outlook.com (100.127.140.245) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Sat, 5 Nov 2022 01:43:22 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Sat, 05 Nov 2022 01:43:21 +0000 Received: from ff877a6dda53.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F9D4C0C1-513B-408F-A0B7-D599C6C21303.1; Sat, 05 Nov 2022 01:43:16 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ff877a6dda53.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 05 Nov 2022 01:43:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB7512.eurprd08.prod.outlook.com (2603:10a6:10:303::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Sat, 5 Nov 2022 01:43:14 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Sat, 5 Nov 2022 01:43:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 40646062-5cab-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ceq4d8y//JP/tj2VicR6XdGKkNCH1gz1/C31VLF++IeqBJQ/BIuT0ER6cLCRc0O72pe59fmfUl7tlWOiAvQM1VSKjjiM2dQlJbNV9ZS4FGcSay0mdm8NBkD4VKYgxpFzf9NOaeod3+HvicWQsNV73w7g5if8NQV2QWDT20+iWyXWfgu7WF18WwoZ5U4Gq3cCMOovNsHMp/+838swf7nXbAbO3aSoSbElamTw1m8LZw6x3lBJIoHSreuXMObvtKHyORwaelWE4FswC4UGG2/RmEMcOkfXnMNt2YzwEFQaJRe0GBP50z/MLolcM8ilzglUlT0/F+WSNFr/Skc4Ymtbvw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WYvllwfOZD9O6T5HTCLx1s4/8S5pf4PPIIacqGUBqeI=; b=FGGcOHa91k21rCHD9LA/CO7DvhqMSGL7+BGG0tLBhFslNGM+0dbODaztSLk1Uld7o7/t31m+6v4K+4BROX6TtQXfgy56YRhjrBkuB+SkoxSw5gVy1rqn0MYqlErvaTV/+3HfNyk6A9ADeMvft1zfaVS82utw6XBiH3+6sVqu0P79QfcydaOJJxKIk3FzhTqptHb/dBU95IkCE3HxCZlOBF4JtjEJ+3FKHMU5eIgUxq8ELEjKidC0d1rURTrCE2+j/HNT0NTuGfcYHWRO4Hf4X336CjW9BXjdrM4VQo9ZJ1BbTctUxfVZBFluq/uKfb+IT1V8te3YkjZPYS6wn9iNvA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WYvllwfOZD9O6T5HTCLx1s4/8S5pf4PPIIacqGUBqeI=; b=HLtHYzHRaWrSYbS2alSNWmcK/LYfOisEqqFTzCw/C8jxautzOMMi0M9+n5wVQ9ouC0BFShn4cI5+i9HolAoDNOyjnPzbpZ/YXYmI9NwrcCO5/R/vimy9KUWXeQH4mDKpes/LR8XIkdl4P5MREXshzInOynENCnfFnmCpPjFEGWg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XYi3GSAuR8mg1+r15PiWOylG8ouHLGV4Z30owjArjKWnUXFGG69NWTQLJbYbNo7xl1QGm7se63b4uPGPuX47pCkMKZJB/3qnQ3YkwdARcRBte4sb0j2ts6y9EyZLPcM4O0T8EjrC31AgBeBo3RDUif2uJd2CUKSP+10t/lMn6F7by8vDODzmofG1sddmiE2ulHB8DqprsaQCesaRKqguFxBOEm+T2p9BRzVcw78V9MysH+5kiaQNj9PIVnLAtyzDzk37pGeJHjHV7Uh/hyQviT7XfCxOULqqT06WbXqkBPyLK3e16r8VcM1F/fb+J6398MVAEhMX99bChQmTEK0S0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WYvllwfOZD9O6T5HTCLx1s4/8S5pf4PPIIacqGUBqeI=; b=Kj07oJuvb/MxGEQvowD/pxPi3o7pU3qRuZv7MPzatnQElgglmyY7BRwxXP4ov1mEHbh+h/pO7qzjVf4KiekNNrMeZ2kx2FC4OJkADfUug+zR2W5ILKMBadMqV/n/y9peMlli0sqWs93lB/ZX2WEMC5kGd58d0UFWFcATR8Gais9UlT0bZVBCJ7e4jolTGLlNO3kfApIn+P7iQNooDfNDWhk1HV4Esa75hSRDuFEDnF88F7S3E1l0ysesjexaNAA6gKpdJLCASLChuX0FDErF50DVuhxTFSpGpbmDjVuXT/5srxJIxMwT9Ir/mM4M18RS2PRK8f3eH/T0C96DYCJArw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WYvllwfOZD9O6T5HTCLx1s4/8S5pf4PPIIacqGUBqeI=; b=HLtHYzHRaWrSYbS2alSNWmcK/LYfOisEqqFTzCw/C8jxautzOMMi0M9+n5wVQ9ouC0BFShn4cI5+i9HolAoDNOyjnPzbpZ/YXYmI9NwrcCO5/R/vimy9KUWXeQH4mDKpes/LR8XIkdl4P5MREXshzInOynENCnfFnmCpPjFEGWg= From: Henry Wang To: Paul Durrant , Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Wei Liu , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian Subject: RE: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Thread-Topic: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Thread-Index: AQHY8GkebAmmr6JZXEeYf3zz1Gj/l64vB4qAgACHc2A= Date: Sat, 5 Nov 2022 01:43:13 +0000 Message-ID: References: <20221104161815.38007-1-roger.pau@citrix.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: CF801592F278FD4983EF47BEC51520FA.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB9PR08MB7512:EE_|AM7EUR03FT019:EE_|PAXPR08MB7624:EE_ X-MS-Office365-Filtering-Correlation-Id: fd1a9fd8-ea44-4819-e995-08dabecf1f7f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Su1ARq/IW1WVnZJ36p1sHg6np+MLwt8ZdQOGDOniaFVV6WIy/2sQuzBPr+0LRaMP2zh3i9ehfKpzs2AWS/hd3SkngcRi7LXOpzgL+bIQu4R4Cv36OvcR3M6w63z3d0GG3SjHkLxJqGMcM4Sjtiz6iC23kAmWyVxXv+zpUNWEU/H1KUCS6pYRaiyDFlmV+ux8k9mGHywYKrcm4gwLQJB/kpIE5XVWx4L9jxg82svydw6cTaevY2QT0APLmiYgqXvCIaudRuzd0vDCXAUc7Syq3LMT04eXgc6g+Agj9ghJlNKWcuOlAWKKZxaqsgtO4rfPLSPA94Fm2g6rnhhueODDsGaIu6F2m3oRZk+theH9lLlKTpDlkeMWZzLhm8FeetVtovDnhY1e8K65TfhMMNFtiejqYb3BIVpRBp4XYMfkdGHh8HomknZwzM2oj2z3/PHFfGPlkX0QtRY9GDB4Sv+Hrtj5RMwaqfKI1a2fQaw3v1raRGT5brv9IWXiyghbZvq/w8D6/4zE5TLPcvaJkoBi9VEAsxNlsF5sgObD0SvSMzCZ2mWcOQdqr6n8jZIc0aP8vIanCosPLWvLlO6Im2dbNrIoB+LDtB8qTZ8HfWKvjGVoxUd3xqnJyl2SZnQXd/yVbEhI56TVvK0nLpdbvmY84RjbuqP9TY8oxMB/+HnQY6lHc78V6HChMfJ+2aJVmI91yqczAzTjE+x095wCRSWn222Y71PrHfCnnE4Bnay5vxYLR3oXz3Y8EvP3fivW5k6sWaIi4fT4WjZKgLnGmZe71Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(451199015)(76116006)(52536014)(8936002)(186003)(83380400001)(66946007)(66556008)(33656002)(4326008)(66476007)(64756008)(9686003)(6506007)(55016003)(53546011)(2906002)(41300700001)(26005)(7696005)(8676002)(5660300002)(38070700005)(54906003)(66446008)(71200400001)(316002)(478600001)(38100700002)(86362001)(110136005)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7512 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9e1d544f-e1d0-4920-863e-08dabecf1a68 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4gAi+PlfjrThqbhWkaKuhNiXqRO8WcGcKwoZ9bOoEQoW0eZgf1cjru+gNR51BaxiKyea+WDF3yNzLTjBvimKDoJn8Jpg802/44BEpQU/rfE2Fo/Y9gOFMTJGdbbxQm9tepJjmaHRkFsKjx4h+9MuhHwW+Idv3Zaqp7Ffz4zQgVsJD2Xy8OZo+yUdKt+A7LEPfXz+w+N2WUg8tUgJl4kA5pPd65V1yo6EQa666eHCwT1UieoOZl3vLpJa47YSzMBqkVMAxHw9p/hEOaKrYfmBumQ3g2MeK3A4sYgTJBMPch+j4B+6sa+kZyUTwRSSV7GVknVffyuXNkB2Q55jy+d60lvyKIDagPpNP+qhP2w5kX2TlYXmUcLBynpRQdLjwLuEubWQrjtYCsurvQA7kS7xi82r6tnEplnHr29/TVvrL1tWzGvD5QZNDCuGze9+MTQKshJIq/vymeBxGzc6rqnKZfpHHaouRU5hAlWDTmHBaV6ui2V2YiiXhdFpnHjbSvgEzrYYvwaIHBqbSN04+1lps0/safBM3wWJ5KchquUJ1wp5JP5+scRHOLKZ7XS4yiUzsGUONxF1gpANMnlShhYyF2DiMenvUAbSjAHskqV6cA7c6y+h84DCSIexXvtnmlN/DFTKFxK2lWtFl+KFtpgZuKlRys93xD5oFlxhkIIAZud0Aoma97xuR3j3BArIIaCCpXZTYjDicO7EuIprgbEhxYEx+JKeLygNWSfTPVxclYYLGcmGxd3b4jxR15C4iBswWb8Gh3cxQsx2/G73njYEvA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199015)(36840700001)(46966006)(40470700004)(33656002)(40460700003)(356005)(41300700001)(81166007)(8676002)(107886003)(9686003)(40480700001)(2906002)(82740400003)(82310400005)(54906003)(52536014)(86362001)(7696005)(5660300002)(6506007)(110136005)(478600001)(186003)(53546011)(70206006)(26005)(4326008)(316002)(8936002)(70586007)(55016003)(36860700001)(83380400001)(336012)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2022 01:43:22.1705 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fd1a9fd8-ea44-4819-e995-08dabecf1f7f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7624 SGkgUm9nZXIsDQoNCj4gU3ViamVjdDogUmU6IFtQQVRDSCBmb3ItNC4xNyB2Ml0gaHZtL2FwaWM6 IHJlcHVycG9zZSB0aGUgcmVwb3J0aW5nIG9mIHRoZQ0KPiBBUElDIGFzc2lzdCBvcHRpb25zDQo+ IA0KPiBPbiAwNC8xMS8yMDIyIDE2OjE4LCBSb2dlciBQYXUgTW9ubmUgd3JvdGU6DQo+ID4gVGhl IGN1cnJlbnQgcmVwb3J0aW5nIG9mIHRoZSBoYXJkd2FyZSBhc3Npc3RlZCBBUElDIG9wdGlvbnMg aXMgZG9uZSBieQ0KPiA+IGNoZWNraW5nICJ2aXJ0dWFsaXplIEFQSUMgYWNjZXNzZXMiIHdoaWNo IGlzIG5vdCB2ZXJ5IGhlbHBmdWwsIGFzIHRoYXQNCj4gPiBmZWF0dXJlIGRvZXNuJ3QgYXZvaWQg YSB2bWV4aXQsIGluc3RlYWQgaXQgZG9lcyBwcm92aWRlIHNvbWUgaGVscCBpbg0KPiA+IG9yZGVy IHRvIGRldGVjdCBBUElDIE1NSU8gYWNjZXNzZXMgaW4gdm1leGl0IHByb2Nlc3NpbmcuDQo+ID4N Cj4gPiBSZXB1cnBvc2UgdGhlIGN1cnJlbnQgcmVwb3J0aW5nIG9mIHhBUElDIGFzc2lzdGFuY2Ug dG8gaW5zdGVhZCByZXBvcnQNCj4gPiBzdWNoIGZlYXR1cmUgYXMgcHJlc2VudCB3aGVuIHRoZXJl J3Mgc3VwcG9ydCBmb3IgIlRQUiBzaGFkb3ciIGFuZA0KPiA+ICJBUElDIHJlZ2lzdGVyIHZpcnR1 YWxpemF0aW9uIiBiZWNhdXNlIGluIHRoYXQgY2FzZSBzb21lIHhBUElDIE1NSU8NCj4gPiByZWdp c3RlciBhY2Nlc3NlcyBhcmUgaGFuZGxlZCBkaXJlY3RseSBieSB0aGUgaGFyZHdhcmUsIHdpdGhv dXQNCj4gPiByZXF1aXJpbmcgYSB2bWV4aXQuDQo+ID4NCj4gPiBGb3Igc3ltZXRyeSBhbHNvIGNo YW5nZSBhc3Npc3RlZCB4MkFQSUMgcmVwb3J0aW5nIHRvIHJlcXVpcmUNCj4gPiAidmlydHVhbGl6 ZSB4MkFQSUMgbW9kZSIgYW5kICJBUElDIHJlZ2lzdGVyIHZpcnR1YWxpemF0aW9uIiwgZHJvcHBp bmcNCj4gPiB0aGUgb3B0aW9uIHRvIGFsc28gYmUgcmVwb3J0ZWQgd2hlbiAidmlydHVhbCBpbnRl cnJ1cHQgZGVsaXZlcnkiIGlzDQo+ID4gYXZhaWxhYmxlLiAgUHJlc2VuY2Ugb2YgdGhlICJ2aXJ0 dWFsIGludGVycnVwdCBkZWxpdmVyeSIgZmVhdHVyZSB3aWxsDQo+ID4gYmUgcmVwb3J0ZWQgdXNp bmcgYSBkaWZmZXJlbnQgb3B0aW9uLg0KPiA+DQo+ID4gRml4ZXM6IDJjZTExY2UyNDkgKCd4ODYv SFZNOiBhbGxvdyBwZXItZG9tYWluIHVzYWdlIG9mIGhhcmR3YXJlDQo+IHZpcnR1YWxpemVkIEFQ SUMnKQ0KPiA+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRy aXguY29tPg0KPiA+IC0tLQ0KPiA+IENoYW5nZXMgc2luY2UgdjE6DQo+ID4gICAtIEZpeCBWaXJp ZGlhbiBNU1IgdGlwIGNvbmRpdGlvbnMuDQo+IA0KPiBSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50 IDxwYXVsQHhlbi5vcmc+DQoNClJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5Lldh bmdAYXJtLmNvbT4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0K From xen-devel-bounces@lists.xenproject.org Sat Nov 05 03:39:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Nov 2022 03:39:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.437983.692379 (Exim 4.92) (envelope-from ) id 1orA1Y-0005Lj-QM; Sat, 05 Nov 2022 03:39:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 437983.692379; Sat, 05 Nov 2022 03:39:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orA1Y-0005Lc-Mz; Sat, 05 Nov 2022 03:39:12 +0000 Received: by outflank-mailman (input) for mailman id 437983; Sat, 05 Nov 2022 03:39:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orA1X-0005LS-0K; Sat, 05 Nov 2022 03:39:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orA1W-0002sz-T6; Sat, 05 Nov 2022 03:39:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orA1W-00087B-DU; Sat, 05 Nov 2022 03:39:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orA1W-0006th-Co; Sat, 05 Nov 2022 03:39:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YBXdQLntDROQ4QT+cS4szK5L2IZITj5oln4PBDyeXLk=; b=sFN97YZhBUMbT4PQvRjrZbXBFG 6CqN5f3GJsIs8snT1HQkv7gDl0XnK/BbE7WmSbShGin403LGZc1Zsxr59ekzOc7ccPhxhoKkj+8rs VbBTthRo4ElEcPRISmTUAHvh7NBpkB/Kzxjji1YKuk941erziQBthK0O21IUCuvIVAnQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174618: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-5.4:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:hosts-allocate:starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:hosts-allocate:starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:hosts-allocate:starved:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=a0d9384967214783a92973c920092b7251c03e57 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Sat, 05 Nov 2022 03:39:10 +0000 flight 174618 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174618/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 174540 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 14 guest-start fail in 174608 pass in 174618 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 174608 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 174608 like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail in 174608 like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 174608 like 174540 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 174608 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 174608 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 174608 never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 174608 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 174608 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 174608 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 174608 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 174608 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 174608 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 174608 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 174608 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 174608 never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail in 174608 never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail in 174608 never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 174608 never pass test-armhf-armhf-libvirt 15 migrate-support-check fail in 174608 never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 174608 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 3 hosts-allocate starved n/a test-armhf-armhf-libvirt-qcow2 3 hosts-allocate starved n/a test-armhf-armhf-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a test-arm64-arm64-xl-seattle 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-armhf-armhf-xl-cubietruck 3 hosts-allocate starved n/a version targeted for testing: linux a0d9384967214783a92973c920092b7251c03e57 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 6 days Failing since 174575 2022-11-01 18:42:39 Z 3 days 5 attempts Testing same since 174608 2022-11-03 19:46:50 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anssi Hannula Arnaldo Carvalho de Melo Biju Das Brian Foster Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Darrick J. Wong Darrick J. Wong Dave Chinner David S. Miller Demi Marie Obenour Dongliang Mu Eric Dumazet Florian Fainelli Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hannu Hartikainen Hans Verkuil Heiko Carstens Helge Deller Hyong Youb Kim Hyunwoo Kim Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jeff Vanhoof Jens Glathe Jimmy Assarsson Johan Hovold Jon Hunter Jon Maloy Jonathan Cameron Josh Poimboeuf Juergen Gross Justin Chen Konrad Jankowski Kuogee Hsieh Leon Romanovsky Linux Kernel Functional Testing Luiz Capitulino M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Michal Jaron Mike Kravetz Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Paolo Abeni Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rik van Riel Saeed Mahameed Sakari Ailus Sasha Levin Shreeya Patel Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Thinh Nguyen Tom Lendacky Tony O'Brien Ulf Hansson Vasily Gorbik Vineet Gupta Vladimir Oltean Wei Yongjun Xin Long Yang Yingliang Yongqin Liu Zhang Changzhong Zhengchao Shao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2244 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 05 08:10:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Nov 2022 08:10:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438007.692399 (Exim 4.92) (envelope-from ) id 1orEFW-0006Gd-WB; Sat, 05 Nov 2022 08:09:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438007.692399; Sat, 05 Nov 2022 08:09:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orEFW-0006GW-T5; Sat, 05 Nov 2022 08:09:54 +0000 Received: by outflank-mailman (input) for mailman id 438007; Sat, 05 Nov 2022 08:09:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orEFV-0006GM-Gb; Sat, 05 Nov 2022 08:09:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orEFV-0001OD-DG; Sat, 05 Nov 2022 08:09:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orEFV-0001UN-24; Sat, 05 Nov 2022 08:09:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orEFV-0000pF-1Y; Sat, 05 Nov 2022 08:09:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZQGTB6CmPRLTEjV+BKBjNaxSF1a+k2DTvlPeE1ThlyM=; b=PXSxTECzA+rn9RLKaAgV4a+S/o uInQszWopB8FtknOTHJBdVBrcmcD8R1BzFKm29/E9unlEKtqbJj2LBil/O8YapLkpmUtFgYtDgm6J j7mcPBNh3erK6HN0kcKeeIW/rwzTtn58jzHOAbIjPR7bQ22OTfaIkQXnliRR9USLWDRo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174611: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=ee6050c8af96bba2f81e8b0793a1fc2f998fcd20 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sat, 05 Nov 2022 08:09:53 +0000 flight 174611 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174611/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux ee6050c8af96bba2f81e8b0793a1fc2f998fcd20 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 28 days Failing since 173470 2022-10-08 06:21:34 Z 28 days 43 attempts Testing same since 174611 2022-11-04 02:32:39 Z 1 days 1 attempts ------------------------------------------------------------ 1557 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 147182 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 05 11:32:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Nov 2022 11:32:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438026.692412 (Exim 4.92) (envelope-from ) id 1orHPQ-0004s3-9R; Sat, 05 Nov 2022 11:32:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438026.692412; Sat, 05 Nov 2022 11:32:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orHPQ-0004rw-6T; Sat, 05 Nov 2022 11:32:20 +0000 Received: by outflank-mailman (input) for mailman id 438026; Sat, 05 Nov 2022 11:32:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orHPP-0004rm-4m; Sat, 05 Nov 2022 11:32:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orHPP-000604-1W; Sat, 05 Nov 2022 11:32:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orHPO-00055m-N3; Sat, 05 Nov 2022 11:32:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orHPO-00019m-Mc; Sat, 05 Nov 2022 11:32:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rayOK04xFM3Oy1Q340i8FnVcJTQUrPH38YlKS/C4td0=; b=Mbll0T3TCr739HRs5XQAsaMTEI qWYkyR3Ck2G/KN01lv/fOoVq1BcDStNGHCf+ltw+HirQjaRkm6/h2YTc1ovF2VLL5j7AGxYmh0/BC 2WD92qD/3nKOzXL+hC0TvrOoFPvbPSGUu6Uj+O7DAwBA+lmpF+Z58jPoE9magyN4Qe70=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174629: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-pvhv2-intel:debian-fixup:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=37f82facd62f720fdcec104f72f86b8c6c214820 X-Osstest-Versions-That: xen=2d9b3699136d20e354a94daefebbeefa9ceec7b6 From: osstest service owner Date: Sat, 05 Nov 2022 11:32:18 +0000 flight 174629 xen-unstable real [real] flight 174635 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174629/ http://logs.test-lab.xenproject.org/osstest/logs/174635/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-pvhv2-intel 13 debian-fixup fail pass in 174635-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174616 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174616 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174616 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174616 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174616 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174616 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174616 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174616 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174616 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174616 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174616 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174616 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 37f82facd62f720fdcec104f72f86b8c6c214820 baseline version: xen 2d9b3699136d20e354a94daefebbeefa9ceec7b6 Last test of basis 174616 2022-11-04 04:42:55 Z 1 days Testing same since 174629 2022-11-04 17:41:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dario Faggioli Jan Beulich Juergen Gross Marek Marczykowski-Górecki jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel fail test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2d9b369913..37f82facd6 37f82facd62f720fdcec104f72f86b8c6c214820 -> master From xen-devel-bounces@lists.xenproject.org Sat Nov 05 14:10:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Nov 2022 14:10:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438211.692436 (Exim 4.92) (envelope-from ) id 1orJrn-0002X9-UO; Sat, 05 Nov 2022 14:09:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438211.692436; Sat, 05 Nov 2022 14:09:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orJrn-0002X2-Py; Sat, 05 Nov 2022 14:09:47 +0000 Received: by outflank-mailman (input) for mailman id 438211; Sat, 05 Nov 2022 14:09:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orJrm-0002Ws-9F; Sat, 05 Nov 2022 14:09:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orJrm-0000vh-5M; Sat, 05 Nov 2022 14:09:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orJrl-0002Fg-JB; Sat, 05 Nov 2022 14:09:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orJrl-0002Mu-IT; Sat, 05 Nov 2022 14:09:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9C3xocXOs5QmLxLJCb0QmXEnyOymBxPGXC99XiEoci4=; b=fKobfGfwSFLSZtIfFVvyRjtKBQ 0T+dr7Tg5CLbPtRQu/4njCST/RjugwSOl3zFbrg6mxP6wIcpcZGdeMU4Y0xN2q63Zm42LlaRYq2hI ac9gfU1ozQOKVSlu8PVp4EUB1/goKtbxShTBy97DIi6QN45TjDyPrv5CPEEKVORX2Oo0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174630: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-xl-xsm:guest-saverestore:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:hosts-allocate:starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:hosts-allocate:starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:hosts-allocate:starved:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=a0d9384967214783a92973c920092b7251c03e57 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Sat, 05 Nov 2022 14:09:45 +0000 flight 174630 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174630/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174618 REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 174618 pass in 174630 test-amd64-i386-xl-shadow 7 xen-install fail in 174618 pass in 174630 test-armhf-armhf-libvirt-raw 13 guest-start fail pass in 174608 test-amd64-i386-xl-xsm 17 guest-saverestore fail pass in 174618 test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 174618 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 174608 like 174540 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 174608 never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 174618 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 174618 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 3 hosts-allocate starved in 174618 n/a test-armhf-armhf-libvirt-qcow2 3 hosts-allocate starved in 174618 n/a test-armhf-armhf-libvirt-raw 3 hosts-allocate starved in 174618 n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved in 174618 n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved in 174618 n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved in 174618 n/a test-arm64-arm64-xl-seattle 3 hosts-allocate starved in 174618 n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved in 174618 n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved in 174618 n/a test-armhf-armhf-xl-cubietruck 3 hosts-allocate starved in 174618 n/a version targeted for testing: linux a0d9384967214783a92973c920092b7251c03e57 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 7 days Failing since 174575 2022-11-01 18:42:39 Z 3 days 6 attempts Testing same since 174608 2022-11-03 19:46:50 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anssi Hannula Arnaldo Carvalho de Melo Biju Das Brian Foster Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Darrick J. Wong Darrick J. Wong Dave Chinner David S. Miller Demi Marie Obenour Dongliang Mu Eric Dumazet Florian Fainelli Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hannu Hartikainen Hans Verkuil Heiko Carstens Helge Deller Hyong Youb Kim Hyunwoo Kim Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jeff Vanhoof Jens Glathe Jimmy Assarsson Johan Hovold Jon Hunter Jon Maloy Jonathan Cameron Josh Poimboeuf Juergen Gross Justin Chen Konrad Jankowski Kuogee Hsieh Leon Romanovsky Linux Kernel Functional Testing Luiz Capitulino M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Michal Jaron Mike Kravetz Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Paolo Abeni Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rik van Riel Saeed Mahameed Sakari Ailus Sasha Levin Shreeya Patel Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Thinh Nguyen Tom Lendacky Tony O'Brien Ulf Hansson Vasily Gorbik Vineet Gupta Vladimir Oltean Wei Yongjun Xin Long Yang Yingliang Yongqin Liu Zhang Changzhong Zhengchao Shao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2244 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 05 14:50:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Nov 2022 14:50:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438222.692447 (Exim 4.92) (envelope-from ) id 1orKUf-0000Jj-02; Sat, 05 Nov 2022 14:49:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438222.692447; Sat, 05 Nov 2022 14:49:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orKUe-0000Jc-Sb; Sat, 05 Nov 2022 14:49:56 +0000 Received: by outflank-mailman (input) for mailman id 438222; Sat, 05 Nov 2022 14:49:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orKUe-0000JS-3D; Sat, 05 Nov 2022 14:49:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orKUe-0001u7-0B; Sat, 05 Nov 2022 14:49:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orKUd-0004yV-Fr; Sat, 05 Nov 2022 14:49:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orKUd-0004zC-FS; Sat, 05 Nov 2022 14:49:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GbNm+T0ObVkwmav7ZQMfJ2ingGT62WXqc3vxDBoMZUo=; b=BF6iOG8AcyI77sXcID5bkGPu/1 laN+2YvHyIvIDrHmt4OASlhv4zpn0GSj/mEbuTSaPqkLEq+4eanVnfNb+ezce+EzpnOfQfUhD9qR4 g1cpWLrVjWH5d7+W0ZXb2hhUu5QHBxNT/Xk9hihu7EW7wRbhWPqJRjhL3i37v+RRzLBg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174632: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=7416d19b8d8253abf74486d2f76ffeae15adecd9 X-Osstest-Versions-That: libvirt=cca6787b15ed0b5a7ebbdfe0a522cacb1cc02a66 From: osstest service owner Date: Sat, 05 Nov 2022 14:49:55 +0000 flight 174632 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174632/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174614 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174614 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174614 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt 7416d19b8d8253abf74486d2f76ffeae15adecd9 baseline version: libvirt cca6787b15ed0b5a7ebbdfe0a522cacb1cc02a66 Last test of basis 174614 2022-11-04 04:18:51 Z 1 days Testing same since 174632 2022-11-05 04:18:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Lin Yang Michal Privoznik Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git cca6787b15..7416d19b8d 7416d19b8d8253abf74486d2f76ffeae15adecd9 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Nov 05 21:47:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Nov 2022 21:47:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438344.692458 (Exim 4.92) (envelope-from ) id 1orR0L-0007jd-1Y; Sat, 05 Nov 2022 21:47:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438344.692458; Sat, 05 Nov 2022 21:47:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orR0K-0007jW-U1; Sat, 05 Nov 2022 21:47:04 +0000 Received: by outflank-mailman (input) for mailman id 438344; Sat, 05 Nov 2022 21:47:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orR0J-0007jM-Am; Sat, 05 Nov 2022 21:47:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orR0J-000366-6k; Sat, 05 Nov 2022 21:47:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orR0I-0004Wj-Jv; Sat, 05 Nov 2022 21:47:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orR0I-0003u0-JI; Sat, 05 Nov 2022 21:47:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=leGdhp6iGTB1WnU52IegvCGcSmP+FWqAieLxU4XyA+M=; b=OmDowp+x6QscB8p5az6uX/sJ4p vHXh2EJrKiugl0GypxiTuwAbTYRuV5n3GidnU5+3Vr+rFUpaTJDkpWEpy4GUzE4qROxNeABWO6Knr yYC4eyeupbGac80AOwYAkJTJhZjmIsoPqU/4JQVpEYdG8vzBKd4EfU9EO03TORyJZgWs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174634: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b208b9fbbcba743fb269d15cb46a4036b01936b1 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sat, 05 Nov 2022 21:47:02 +0000 flight 174634 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174634/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10 fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux b208b9fbbcba743fb269d15cb46a4036b01936b1 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 29 days Failing since 173470 2022-10-08 06:21:34 Z 28 days 44 attempts Testing same since 174634 2022-11-05 08:11:44 Z 0 days 1 attempts ------------------------------------------------------------ 1583 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 150344 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 05 22:29:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Nov 2022 22:29:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438351.692469 (Exim 4.92) (envelope-from ) id 1orRes-0005IG-8H; Sat, 05 Nov 2022 22:28:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438351.692469; Sat, 05 Nov 2022 22:28:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orRes-0005I9-5d; Sat, 05 Nov 2022 22:28:58 +0000 Received: by outflank-mailman (input) for mailman id 438351; Sat, 05 Nov 2022 22:28:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orReq-0005Hz-Ms; Sat, 05 Nov 2022 22:28:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orReq-0003v4-Hm; Sat, 05 Nov 2022 22:28:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orRep-0005fv-Q8; Sat, 05 Nov 2022 22:28:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orRep-0001ak-Pj; Sat, 05 Nov 2022 22:28:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cVD0ikj1niHesk3hT71t6x9Wsu1qxdEOkeYxsiqwvCw=; b=hPsBT9nuRmaFcvDHPpPkMt+jYZ wMZmxTM8l2N3jjKP1oS4wk5YrRY3XViF5vk5kVwxb9zNQ3ETguVYRuL7cRMPQsaCCqxs0eXQm1yf1 no0P3ZSUZ/KngwUVH6SOQtwLP/JM9Fzf35aNhEaWY/3FgJgOPsWZBmqH6QFbErXjeDII=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174636: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-pvhv2-intel:debian-fixup:fail:heisenbug xen-unstable:test-amd64-i386-examine-bios:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=37f82facd62f720fdcec104f72f86b8c6c214820 X-Osstest-Versions-That: xen=37f82facd62f720fdcec104f72f86b8c6c214820 From: osstest service owner Date: Sat, 05 Nov 2022 22:28:55 +0000 flight 174636 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174636/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-pvhv2-intel 13 debian-fixup fail in 174629 pass in 174636 test-amd64-i386-examine-bios 6 xen-install fail pass in 174629 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174629 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174629 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174629 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174629 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174629 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174629 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174629 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174629 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174629 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174629 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174629 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174629 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 37f82facd62f720fdcec104f72f86b8c6c214820 baseline version: xen 37f82facd62f720fdcec104f72f86b8c6c214820 Last test of basis 174636 2022-11-05 11:34:43 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Nov 06 01:20:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 01:20:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438377.692479 (Exim 4.92) (envelope-from ) id 1orUKl-00031r-W0; Sun, 06 Nov 2022 01:20:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438377.692479; Sun, 06 Nov 2022 01:20:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orUKl-00031k-Sw; Sun, 06 Nov 2022 01:20:23 +0000 Received: by outflank-mailman (input) for mailman id 438377; Sun, 06 Nov 2022 01:20:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orUKj-00031a-Vo; Sun, 06 Nov 2022 01:20:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orUKj-0006d6-Sb; Sun, 06 Nov 2022 01:20:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orUKj-0004zp-FT; Sun, 06 Nov 2022 01:20:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orUKj-0001vc-F3; Sun, 06 Nov 2022 01:20:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PtoA4El2K3KxFefQXehgii9dHWBGUZRn8n3fMNaZRJc=; b=P6tTY9dRLRIG/eqFDDGl1+Ayzt 9h9LqTQ0sepBf0aEZDFkMjxBwme/DUViv0wuud5KfURjow+tSocKxBzuNbjRQG6QtNxX6ckNvfnkJ +x99+21w0G43MbBDtzaX1vy3aR1cEfeG/sqMZgtapsPxlJY4RC2Y+79Ji9I5Ytr6dC7o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174637: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=6295a58ad1b73985b9c32d184de7d2ed1fbe1774 X-Osstest-Versions-That: qemuu=ece5f8374d0416a339f0c0a9399faa2c42d4ad6f From: osstest service owner Date: Sun, 06 Nov 2022 01:20:21 +0000 flight 174637 qemu-mainline real [real] flight 174640 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174637/ http://logs.test-lab.xenproject.org/osstest/logs/174640/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 174640-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174609 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174609 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174609 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174609 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174609 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174609 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174609 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174609 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 6295a58ad1b73985b9c32d184de7d2ed1fbe1774 baseline version: qemuu ece5f8374d0416a339f0c0a9399faa2c42d4ad6f Last test of basis 174609 2022-11-03 21:37:39 Z 2 days Testing same since 174637 2022-11-05 12:36:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ake Koomsin Peter Maydell Philippe Mathieu-Daudé Richard Henderson Rui Wang Song Gao Stefan Hajnoczi Timofey Kutergin Xiaojuan Yang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git ece5f8374d..6295a58ad1 6295a58ad1b73985b9c32d184de7d2ed1fbe1774 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Nov 06 02:49:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 02:49:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438386.692491 (Exim 4.92) (envelope-from ) id 1orViO-0006si-Dp; Sun, 06 Nov 2022 02:48:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438386.692491; Sun, 06 Nov 2022 02:48:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orViO-0006sI-7J; Sun, 06 Nov 2022 02:48:52 +0000 Received: by outflank-mailman (input) for mailman id 438386; Sun, 06 Nov 2022 02:48:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orViM-0006s8-3R; Sun, 06 Nov 2022 02:48:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orViL-0000Wf-TM; Sun, 06 Nov 2022 02:48:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orViK-0007LB-VD; Sun, 06 Nov 2022 02:48:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orViK-0001cz-UG; Sun, 06 Nov 2022 02:48:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yDfpYtFar6ENxX+UsRqalpCy1lMoqRQuCymMWicMmDs=; b=D8wxAtfVCUHsm1/na9sDNX1M9u WZtFpv/OCT3QDCgQdJzi1rcO0ox9QZKi/tNtErdrRm+CU+YXQj40V5Zn8kYaNYljFxBxgas+F2pdo Bh5Oqr663gW2ueaChLOE+3F8bwlgg/Du77Be1B8O502Mmt2FuuaFZHZXnqNRjOd6mhwc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174638: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-xsm:guest-saverestore:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-xsm:xen-boot:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a0d9384967214783a92973c920092b7251c03e57 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Sun, 06 Nov 2022 02:48:48 +0000 flight 174638 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174638/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 174540 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 174630 REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-shadow 7 xen-install fail in 174608 pass in 174638 test-amd64-i386-xl-xsm 17 guest-saverestore fail in 174630 pass in 174638 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 174630 pass in 174638 test-armhf-armhf-libvirt-raw 13 guest-start fail pass in 174608 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail pass in 174630 test-amd64-i386-pair 11 xen-install/dst_host fail pass in 174630 test-amd64-i386-libvirt-xsm 8 xen-boot fail pass in 174630 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 174630 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 174630 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 174630 REGR. vs. 174540 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 174608 like 174540 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 174608 never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail in 174630 never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 174630 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 174630 never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail in 174630 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 174630 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 174630 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux a0d9384967214783a92973c920092b7251c03e57 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 7 days Failing since 174575 2022-11-01 18:42:39 Z 4 days 7 attempts Testing same since 174608 2022-11-03 19:46:50 Z 2 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anssi Hannula Arnaldo Carvalho de Melo Biju Das Brian Foster Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Darrick J. Wong Darrick J. Wong Dave Chinner David S. Miller Demi Marie Obenour Dongliang Mu Eric Dumazet Florian Fainelli Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hannu Hartikainen Hans Verkuil Heiko Carstens Helge Deller Hyong Youb Kim Hyunwoo Kim Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jeff Vanhoof Jens Glathe Jimmy Assarsson Johan Hovold Jon Hunter Jon Maloy Jonathan Cameron Josh Poimboeuf Juergen Gross Justin Chen Konrad Jankowski Kuogee Hsieh Leon Romanovsky Linux Kernel Functional Testing Luiz Capitulino M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Michal Jaron Mike Kravetz Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Paolo Abeni Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rik van Riel Saeed Mahameed Sakari Ailus Sasha Levin Shreeya Patel Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Thinh Nguyen Tom Lendacky Tony O'Brien Ulf Hansson Vasily Gorbik Vineet Gupta Vladimir Oltean Wei Yongjun Xin Long Yang Yingliang Yongqin Liu Zhang Changzhong Zhengchao Shao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2244 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 06 06:00:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 06:00:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438403.692502 (Exim 4.92) (envelope-from ) id 1orYhd-0000j1-Tx; Sun, 06 Nov 2022 06:00:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438403.692502; Sun, 06 Nov 2022 06:00:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orYhd-0000is-Np; Sun, 06 Nov 2022 06:00:17 +0000 Received: by outflank-mailman (input) for mailman id 438403; Sun, 06 Nov 2022 06:00:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orYhO-0008H4-D9 for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 06:00:02 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3f597eaa-5d98-11ed-8fd1-01056ac49cbb; Sun, 06 Nov 2022 07:00:00 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5DA1A1F950; Sun, 6 Nov 2022 05:59:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 268D8132E7; Sun, 6 Nov 2022 05:59:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jppJB19NZ2ODJwAAMHmgww (envelope-from ); Sun, 06 Nov 2022 05:59:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f597eaa-5d98-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667714399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8hVb6BAyWvekO938dQSC+RJ8T7govWTrExn1p5zb8JU=; b=nbO5SOj8oSk1Wc6NC1zqUlHYUboewu/rFh7gRlQxz5QNG6n0JrCA1nTPpK98nAWanzV0ak UljRMSzvy6qoaeujTPcpcfsWzvT3ybfV3taCt7SmU52+d02nsrEfbM5XA6tZuw1bXiwGI+ uBjL8FaLKaMNp4sGw4Sn99D8r037Ct4= From: Juergen Gross To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: [GIT PULL] xen: branch for v6.1-rc4 Date: Sun, 6 Nov 2022 06:59:58 +0100 Message-Id: <20221106055958.14139-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.1-rc4-tag xen: branch for v6.1-rc4 It contains only one fix for silencing a smatch warning, and a small cleanup patch. Thanks. Juergen arch/x86/xen/pmu.c | 2 +- arch/x86/xen/setup.c | 23 ++++++----------------- 2 files changed, 7 insertions(+), 18 deletions(-) Juergen Gross (2): x86/xen: silence smatch warning in pmu_msr_chk_emulated() x86/xen: simplify sysenter and syscall setup From xen-devel-bounces@lists.xenproject.org Sun Nov 06 06:15:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 06:15:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438409.692512 (Exim 4.92) (envelope-from ) id 1orYwE-0002s4-3w; Sun, 06 Nov 2022 06:15:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438409.692512; Sun, 06 Nov 2022 06:15:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orYwE-0002rx-1B; Sun, 06 Nov 2022 06:15:22 +0000 Received: by outflank-mailman (input) for mailman id 438409; Sun, 06 Nov 2022 06:15:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orYwD-0002rr-1U for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 06:15:21 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 63a57c01-5d9a-11ed-8fd1-01056ac49cbb; Sun, 06 Nov 2022 07:15:19 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4FD8F21878; Sun, 6 Nov 2022 06:15:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 223B513A67; Sun, 6 Nov 2022 06:15:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Wi3oBvdQZ2P9LQAAMHmgww (envelope-from ); Sun, 06 Nov 2022 06:15:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63a57c01-5d9a-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667715319; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wmx1p/fibZIPAcnrUo8dI+OSOgfucXCIKC2XOFQFE/Y=; b=sMf6gxr6gi+Dh3lATXs2/hYm/c8sCfH56iUSQ4U+7RbXrHQYvdHhK4mxX5YzwTbXehpS7a DmxBla5bj4AHO5ay26YEOIGN6TKRm3OcxMDNfQADjY0Vzg2Xe8Ry1lQZIH4zhLhtlXEfF5 afBn2y+rA/GSEBARca5zEfEFY2D1TTo= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD , Henry Wang Subject: [PATCH-for-4.17] tools/hotplug: fix systemd unit dependencies Date: Sun, 6 Nov 2022 07:15:17 +0100 Message-Id: <20221106061517.15602-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 1283af6465cd ("tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR") removed the systemd file var-lib-xenstored.mount without removing dependencies to this file. Fixes: 1283af6465cd ("tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR") Signed-off-by: Juergen Gross --- tools/hotplug/Linux/systemd/xenstored.service.in | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/hotplug/Linux/systemd/xenstored.service.in b/tools/hotplug/Linux/systemd/xenstored.service.in index 80c1d408a5..261077dc92 100644 --- a/tools/hotplug/Linux/systemd/xenstored.service.in +++ b/tools/hotplug/Linux/systemd/xenstored.service.in @@ -1,7 +1,7 @@ [Unit] Description=The Xen xenstore -Requires=proc-xen.mount var-lib-xenstored.mount -After=proc-xen.mount var-lib-xenstored.mount +Requires=proc-xen.mount +After=proc-xen.mount Before=libvirtd.service libvirt-guests.service RefuseManualStop=true ConditionPathExists=/proc/xen/capabilities @@ -16,4 +16,3 @@ ExecStart=@XEN_SCRIPT_DIR@/launch-xenstore [Install] WantedBy=multi-user.target Also=proc-xen.mount -Also=var-lib-xenstored.mount -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Sun Nov 06 06:18:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 06:18:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438413.692524 (Exim 4.92) (envelope-from ) id 1orYyv-0003gs-HR; Sun, 06 Nov 2022 06:18:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438413.692524; Sun, 06 Nov 2022 06:18:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orYyv-0003gl-Ec; Sun, 06 Nov 2022 06:18:09 +0000 Received: by outflank-mailman (input) for mailman id 438413; Sun, 06 Nov 2022 06:18:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orYyu-0003gf-HF for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 06:18:08 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2079.outbound.protection.outlook.com [40.107.105.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c6979470-5d9a-11ed-8fd1-01056ac49cbb; Sun, 06 Nov 2022 07:18:06 +0100 (CET) Received: from DB7PR03CA0088.eurprd03.prod.outlook.com (2603:10a6:10:72::29) by DU0PR08MB8563.eurprd08.prod.outlook.com (2603:10a6:10:404::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.10; Sun, 6 Nov 2022 06:18:04 +0000 Received: from DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::32) by DB7PR03CA0088.outlook.office365.com (2603:10a6:10:72::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Sun, 6 Nov 2022 06:18:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT048.mail.protection.outlook.com (100.127.142.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Sun, 6 Nov 2022 06:18:03 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Sun, 06 Nov 2022 06:18:03 +0000 Received: from 70d9f59ce48b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3CD0D5B0-3E92-4270-8752-725F63E901A4.1; Sun, 06 Nov 2022 06:17:58 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 70d9f59ce48b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 06 Nov 2022 06:17:58 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAVPR08MB8822.eurprd08.prod.outlook.com (2603:10a6:102:2ff::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Sun, 6 Nov 2022 06:17:55 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Sun, 6 Nov 2022 06:17:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6979470-5d9a-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HzdKoOLb8N4LEqaEnCnLgawbSMjckIki7ZewXj2khCHvjzYlI01G+EDwWTgO/5D3YGJxcJPeVBuibn1k4o6/9+aOgNhfFDhonKwFPLroPG7lMzqsN8jq1z/81fKieq2zxHOH809jULaX2kf4sWt/L3AEa2xU0OU2Q7uEsWetwTA789o0qNnJ3tmWxqkRxMobdeZn1IB4FMbGYuf8FzS5trNiOVScLCO8MsyiZJoh06gVjeddCP5YPa2Kvj8CMvEJXuxvaxvfM+mKt4qfcIEjbtDCC72MeYLCuCpW2xUEcxnp99Z6rCw24lkm19/4TuLRibJFF1svZDfa8enzp1o7bA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bg77E8X52ak0YcAa5w+xIeYYeozSdFDrkf0twqK4xlE=; b=PhcPrbINd54b+8+hspFGw1tSDoGb8yKG6Ux3b8hBdvnssCaP4abpOq3biCYGoNFrkLOrgkbygzuuSINhPT2WXfTCDqfS4P8JoA7YgMUtHoCWo350q4YOo84FN3amUGd2BYjKSy1Zo0kF0+QSUwiZaJHYzLHg5Vf/kxtocCeYB+QtsjrxODJ/BfZ2B9jd5jgRmOb9l1Cl0bbjqGmcfKw+OsG1hFJWEbeEiRZG0LqHd5EX35HlEB/urTEDySGr6Bm/3RnO4etO+k/RJO5Acq+tlqTQz66uHo1xF+UEzLIQoXlqCubMGJapNpm39SZJxZ4Bf/QDT65uafE3eqPPTJbGRg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bg77E8X52ak0YcAa5w+xIeYYeozSdFDrkf0twqK4xlE=; b=m44p6zSWLl0i39CrodI1ARmjXsm9+iEM0sr5nt5SI3OSRz608pkA18pi4wiFtDREpWLqVtvVa6vbnXh6leVbuqcS1OglIJ6ASXKcoEcObAXHVXN9/p7kPdxnJ+mFcd6kAuDPA8T3dggYaSrS0mlxOXlsM8F8+OfG4hwua9icO1U= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=atfJhUG3ZfFWSpaG4b6f3OdxfRXVkumVy40M29uuALblEFE6mnby0cZxv8pkcUuQe5YUkDpjKaU4G5iinVPG3g4cRvc+cGTT8iG3jVM/ctygZh1OQmR8GNu6WgjxukBQWvXruP46Rea7vnSZtkgjRgjTJXHL1fK397vTcyzaj13Y7WDoMPTxu7kiPTzdCh1r845eU2IxplkCsXEk3EdkzMeuMDmi0jUpkicLZ9xqHH2ubip+QTGQXQjJFUYWY98sSvzjopStNqCcApl5/jWfVwg13A87t9dxR7pLIndqryXFO6O3qVvLtCKKXXqMTAfdz7wtf34iunclFYVYdHhTwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bg77E8X52ak0YcAa5w+xIeYYeozSdFDrkf0twqK4xlE=; b=ZZOI6FKcGX2uHltIvLB1r5r91gJDdW+h0VotE0xgzh2FpeVjRIvA0qPghghuEsOVYVLn5QzxR9hshfyFYeDw4tYaOUqT/b5FTRPsbg1qQTHClx29uuNY9DpH9d4+sVpOps6V+TiHh00Ij9GJrHnDXOEgddw7HE3iH4ARaCb0rxZxmKsZ1hzIHUCpGP6PE7p6b3oieiqWNs23gk+f7s/yiYz7MsFtl4qP95FdsLaUTj6GghzdQ0lrkqqswbCH9ul4gIgthEi424iwD0O1dItDhOYoY1n0Ja5/L0373EvBbK/qwmzvIBB42tDZZPYldLrQgBOmY5zI/xzhHUlhfOvBgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bg77E8X52ak0YcAa5w+xIeYYeozSdFDrkf0twqK4xlE=; b=m44p6zSWLl0i39CrodI1ARmjXsm9+iEM0sr5nt5SI3OSRz608pkA18pi4wiFtDREpWLqVtvVa6vbnXh6leVbuqcS1OglIJ6ASXKcoEcObAXHVXN9/p7kPdxnJ+mFcd6kAuDPA8T3dggYaSrS0mlxOXlsM8F8+OfG4hwua9icO1U= From: Henry Wang To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: Wei Liu , Anthony PERARD Subject: RE: [PATCH-for-4.17] tools/hotplug: fix systemd unit dependencies Thread-Topic: [PATCH-for-4.17] tools/hotplug: fix systemd unit dependencies Thread-Index: AQHY8acq/wc9uembvUavxm0oHbdHfK4xa5qQ Date: Sun, 6 Nov 2022 06:17:54 +0000 Message-ID: References: <20221106061517.15602-1-jgross@suse.com> In-Reply-To: <20221106061517.15602-1-jgross@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: DD8CCABDCBA4E941BBBD6D9E6C61DCC1.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAVPR08MB8822:EE_|DBAEUR03FT048:EE_|DU0PR08MB8563:EE_ X-MS-Office365-Filtering-Correlation-Id: 7fbe046e-4851-4830-4b0c-08dabfbea9aa x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: d50kPqxQDNWuGijds5cmTMq0ceBh0So5xAghiUvprhGs77YqLtBgsByLzPSKO9CKPWpU4Injd4pEQ/PTBMfSO4cUBa7OGJanqEJ23YbPub4mYxmHKX/Gu8U++EwURDf1U4J0NaoXrT6KXDy/hbB/6GiBfkF7BNxd4Y75jEDfckyGgIWnFOn3QFvCd5qlgdNzwQ9NoATg5cM/+B428F2uLRcxqY0zrR2BPRly7Uui0J4D4zKmLzguL7DXFg/KKO1VMCKpRPzQ4vz4wADq+67w268KtO69FyoMGNVaXjue8Elkxf+TZrt8ewI5gZjRskPOu/HUd9CTaYjzsMawG6IP9VdtEC0SShfTbKd1HK8YF3444bBsvGhtX8maWyJdRWcQzG/CaG9mXGeBUs0A7O6claqm8gn08RWB5QR0osy77Tf2Sr5GrT5kq8+F3VpRqhhyoWeM9OIZFj2WtnmzVmIOAl5orCHjNBM+qRUQePvOXiH97RZ4Cc0O7YOpX/s7OCLwFFV4jJh1Cnb3SUydbSCSYYrpLu+V9l5Qg/puCrulRQmscaaw00+yaP5FTgEKRZOE9Nz11RPxHb3pc6AqkeykNUif+qfVLkLOwvkL0LsiSBOxrP8Y4nlI0Ga4WtguNHCnD+PULUyfxoMyVa83LxhpC4USX5+Ly1Zbb6l7gufPp/kIkz73BqpmlEWWZrzspmmasMQ5EkL0iU71eOFD/GEbOkWRVA9OLRkkxhUYvtWQZxo9t/YhyL2ZRiF4gOdls8LQ3U7OOH9htW1U6JWRvNF2qA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39850400004)(136003)(346002)(366004)(396003)(376002)(451199015)(8936002)(5660300002)(41300700001)(52536014)(7696005)(4744005)(2906002)(55016003)(71200400001)(66476007)(76116006)(4326008)(66446008)(66946007)(64756008)(66556008)(33656002)(122000001)(38100700002)(8676002)(110136005)(316002)(54906003)(86362001)(478600001)(38070700005)(9686003)(26005)(83380400001)(6506007)(186003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB8822 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0fc229ee-785f-4c9c-5db1-08dabfbea45c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TLAbWEaSG4IRvn8CKaC4mv2X8RbX0PQ0Kd0Bl8b/cB9OkeIhAoAwwQ0POiVPkHx6T0z1SxsLc6oMTOam5k2BBafkwKA/Qp0MDgLc2I27La9n8PbxS16Gj4STljKKkS63cC1bFTOydONJuVVVehHBO+3cfslbWSH9KkiUhA99Sf2YlOW55x5ha01bWEktXCq9TucR6ciSA6BwhgZAqRrSBhPjk5dtI8U1UTXBwgEIWrRjCwikOBErDVDIUE6Axzlv0qyYpHoHMBVl5/1LY37I5kVQsj2e7DvxfQqNTJLad1TsBnH/91vwp8iy07rMkN6Ip2afD9EcCZshR/e+UYC3E3Vt/txKQqbK53jxoA4ZBpoQEO0LP2Lr4y/nzw8iRWifmQcxU/Pg4fmyXhX9Qt5K+XyDsHDtdHRyK08vp6l/39jaLyT8UCXW5HlNmK+2jm/FDl48IddSq+dQtyOGOAfOwkxeBGipXqC9f2oDK48/Hscpxml6dx4qLiK/t/qC6LX7YLjTIeIwIqSewGHM1RQjRcwx0VjyMU+qvUNvTH8p3BjXMTIOhfArrp64dKMDnKd64nV6Kqu5cZiyZpYE5m0UW5eHmw2/V4XUGLT2nM8pP+l8w3owYwlvJ3XPJDpsU7ovxbVTtaX0ook9dRl1V+6WuK4uFV+G48F3zrtua440bxMh2zbjtqozB7wDaUit64xTCANgX6G1RhDwQhYGOayKCEWxYhHPuILkKo1G3yRFwVc= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(39850400004)(396003)(451199015)(46966006)(36840700001)(36860700001)(82310400005)(86362001)(81166007)(82740400003)(356005)(316002)(54906003)(7696005)(52536014)(110136005)(8936002)(70206006)(70586007)(5660300002)(4326008)(2906002)(8676002)(41300700001)(47076005)(83380400001)(186003)(336012)(4744005)(107886003)(478600001)(55016003)(6506007)(9686003)(26005)(40480700001)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2022 06:18:03.7391 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7fbe046e-4851-4830-4b0c-08dabfbea9aa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8563 Hi Juergen, > -----Original Message----- > Subject: [PATCH-for-4.17] tools/hotplug: fix systemd unit dependencies >=20 > Commit 1283af6465cd ("tools/xenstore: remove XEN_LIB_STORED and > XENSTORED_ROOTDIR") removed the systemd file var-lib-xenstored.mount > without removing dependencies to this file. >=20 > Fixes: 1283af6465cd ("tools/xenstore: remove XEN_LIB_STORED and > XENSTORED_ROOTDIR") > Signed-off-by: Juergen Gross Release-acked-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Sun Nov 06 09:57:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 09:57:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438478.692538 (Exim 4.92) (envelope-from ) id 1orcOs-0000Rg-T9; Sun, 06 Nov 2022 09:57:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438478.692538; Sun, 06 Nov 2022 09:57:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orcOs-0000RZ-Pz; Sun, 06 Nov 2022 09:57:10 +0000 Received: by outflank-mailman (input) for mailman id 438478; Sun, 06 Nov 2022 09:57:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orcOr-0000RP-IX; Sun, 06 Nov 2022 09:57:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orcOr-0002KH-Fu; Sun, 06 Nov 2022 09:57:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orcOr-0006Hx-2t; Sun, 06 Nov 2022 09:57:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orcOr-0006Ls-2M; Sun, 06 Nov 2022 09:57:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=e/icbU5LsZjiwlx6UhGwG2v4batdj8uW66KT/zLhygA=; b=XjGeZTgux6oUDOqWR35TQpTc/v kABfAA/ZCRm49LXkXbQyI8wnfCCfa9um+2Bzmt2QYB/dZr2oKCS8ie8ND0IpvQep9vHhuSYsqA/6r LUDjC8Lryhy5uzcpAUPRgvbvjiP8BT+2IW5gEDuTBGbDUANaROUsZo+2VEDFG2WAY310=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174642: regressions - FAIL X-Osstest-Failures: linux-5.4:build-arm64-pvops:kernel-build:fail:regression linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-xsm:guest-saverestore:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-xsm:xen-boot:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a0d9384967214783a92973c920092b7251c03e57 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Sun, 06 Nov 2022 09:57:09 +0000 flight 174642 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174642/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 174540 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 174630 REGR. vs. 174540 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174638 REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-shadow 7 xen-install fail in 174608 pass in 174642 test-amd64-i386-xl-xsm 17 guest-saverestore fail in 174630 pass in 174642 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 174630 pass in 174642 test-amd64-i386-pair 11 xen-install/dst_host fail in 174638 pass in 174642 test-amd64-i386-libvirt-xsm 8 xen-boot fail in 174638 pass in 174642 test-armhf-armhf-xl-rtds 14 guest-start fail in 174638 pass in 174642 test-armhf-armhf-libvirt-raw 13 guest-start fail pass in 174608 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail pass in 174630 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 174630 test-amd64-i386-pair 10 xen-install/src_host fail pass in 174638 test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 174638 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 174638 test-armhf-armhf-libvirt-qcow2 13 guest-start fail pass in 174638 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 174608 like 174540 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 174608 never pass test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 174630 like 174540 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 174630 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 174630 never pass test-arm64-arm64-xl 15 migrate-support-check fail in 174630 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 174630 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 174630 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 174630 never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 174630 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 174630 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 174630 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 174630 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 174630 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 174630 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 174630 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 174630 never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 174630 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 174630 never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail in 174630 never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 174630 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 174630 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 174630 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 174630 never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 174630 never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 174638 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 174638 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux a0d9384967214783a92973c920092b7251c03e57 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 7 days Failing since 174575 2022-11-01 18:42:39 Z 4 days 8 attempts Testing same since 174608 2022-11-03 19:46:50 Z 2 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anssi Hannula Arnaldo Carvalho de Melo Biju Das Brian Foster Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Darrick J. Wong Darrick J. Wong Dave Chinner David S. Miller Demi Marie Obenour Dongliang Mu Eric Dumazet Florian Fainelli Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hannu Hartikainen Hans Verkuil Heiko Carstens Helge Deller Hyong Youb Kim Hyunwoo Kim Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jeff Vanhoof Jens Glathe Jimmy Assarsson Johan Hovold Jon Hunter Jon Maloy Jonathan Cameron Josh Poimboeuf Juergen Gross Justin Chen Konrad Jankowski Kuogee Hsieh Leon Romanovsky Linux Kernel Functional Testing Luiz Capitulino M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Michal Jaron Mike Kravetz Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Paolo Abeni Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rik van Riel Saeed Mahameed Sakari Ailus Sasha Levin Shreeya Patel Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Thinh Nguyen Tom Lendacky Tony O'Brien Ulf Hansson Vasily Gorbik Vineet Gupta Vladimir Oltean Wei Yongjun Xin Long Yang Yingliang Yongqin Liu Zhang Changzhong Zhengchao Shao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2244 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 06 09:59:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 09:59:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438485.692549 (Exim 4.92) (envelope-from ) id 1orcRX-00014A-Fl; Sun, 06 Nov 2022 09:59:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438485.692549; Sun, 06 Nov 2022 09:59:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orcRX-000143-Cg; Sun, 06 Nov 2022 09:59:55 +0000 Received: by outflank-mailman (input) for mailman id 438485; Sun, 06 Nov 2022 09:59:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orcRW-00013t-Mx; Sun, 06 Nov 2022 09:59:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orcRW-0002Np-LD; Sun, 06 Nov 2022 09:59:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orcRW-0006MC-9k; Sun, 06 Nov 2022 09:59:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orcRW-0006oO-9H; Sun, 06 Nov 2022 09:59:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tKVTIQ6NAqbRwFLHdO1l3vrvvqtVKqBpCmddre0ToNs=; b=GFsAE1rURdNHI6r0oehPwsWDVq 36ugg7Q9tN4lSFJVbtMlxuznEclR9vsf6TAntCngu8TMNmEgaqeQe4/ATw6iqppbywDKwLfTVFffq WNWoBYWVnQRTeqG5MxMPzKSGBteeWgbVN1D7relPuQSPDJbgxDnv91mg+KWySsU3s5Ag=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174639: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=2f5065a0bc9d0afb45f2ae284bd525d55ce82c33 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sun, 06 Nov 2022 09:59:54 +0000 flight 174639 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174639/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 2f5065a0bc9d0afb45f2ae284bd525d55ce82c33 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 29 days Failing since 173470 2022-10-08 06:21:34 Z 29 days 45 attempts Testing same since 174639 2022-11-05 22:12:42 Z 0 days 1 attempts ------------------------------------------------------------ 1584 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 150603 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 06 10:18:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 10:18:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438500.692560 (Exim 4.92) (envelope-from ) id 1orcjT-0003qn-34; Sun, 06 Nov 2022 10:18:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438500.692560; Sun, 06 Nov 2022 10:18:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orcjS-0003qg-VI; Sun, 06 Nov 2022 10:18:26 +0000 Received: by outflank-mailman (input) for mailman id 438500; Sun, 06 Nov 2022 10:18:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orcjR-0003ow-Ty for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 10:18:26 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5840248a-5dbc-11ed-91b5-6bf2151ebd3b; Sun, 06 Nov 2022 11:18:23 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2B56E219DF; Sun, 6 Nov 2022 10:18:23 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0BF6D132E7; Sun, 6 Nov 2022 10:18:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aTd5Ae+JZ2PGDQAAMHmgww (envelope-from ); Sun, 06 Nov 2022 10:18:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5840248a-5dbc-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667729903; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kpYE1ZPEFg6d2Pi/Awf8KodC12VFso5OxTO+fOOjftI=; b=siX02A/Ykec8xZK7xytDOtDk8JJiAsgcWjLXdSrYoJSK+SXzkc/bPQ9N4o8TmFADFMpK/6 JkVENw3aanFDskF6omye8v3Pg6/98P01SavrAuguwvaAJLkHIFvb48j2miqRw3Lg7+0iha lb3kDtlEDSCnVrMge2/yM579mPgfL8k= Message-ID: <2de5fc58-3bbd-eea1-7bca-c85189c98cc1@suse.com> Date: Sun, 6 Nov 2022 11:18:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [linux-5.4 test] 174642: regressions - FAIL Content-Language: en-US To: osstest service owner , xen-devel@lists.xenproject.org References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------t2ZTn26W7LsLg8DgkfgR0VaV" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------t2ZTn26W7LsLg8DgkfgR0VaV Content-Type: multipart/mixed; boundary="------------eFIFzKaRVpvxE60l2xzC9bGO"; protected-headers="v1" From: Juergen Gross To: osstest service owner , xen-devel@lists.xenproject.org Message-ID: <2de5fc58-3bbd-eea1-7bca-c85189c98cc1@suse.com> Subject: Re: [linux-5.4 test] 174642: regressions - FAIL References: In-Reply-To: --------------eFIFzKaRVpvxE60l2xzC9bGO Content-Type: multipart/mixed; boundary="------------aOU9Ggh5MVdVEnVpF0pRjYM3" --------------aOU9Ggh5MVdVEnVpF0pRjYM3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMTEuMjIgMTA6NTcsIG9zc3Rlc3Qgc2VydmljZSBvd25lciB3cm90ZToNCj4gZmxp Z2h0IDE3NDY0MiBsaW51eC01LjQgcmVhbCBbcmVhbF0NCj4gaHR0cDovL2xvZ3MudGVzdC1s YWIueGVucHJvamVjdC5vcmcvb3NzdGVzdC9sb2dzLzE3NDY0Mi8NCj4gDQo+IFJlZ3Jlc3Np b25zIDotKA0KPiANCj4gVGVzdHMgd2hpY2ggZGlkIG5vdCBzdWNjZWVkIGFuZCBhcmUgYmxv Y2tpbmcsDQo+IGluY2x1ZGluZyB0ZXN0cyB3aGljaCBjb3VsZCBub3QgYmUgcnVuOg0KPiAg IGJ1aWxkLWFybTY0LXB2b3BzICAgICAgICAgICAgIDYga2VybmVsLWJ1aWxkICAgICAgICAg ICAgIGZhaWwgUkVHUi4gdnMuIDE3NDU0MA0KDQpIb3cgbmljZToNCg0KImdjYzogaW50ZXJu YWwgY29tcGlsZXIgZXJyb3I6IFNlZ21lbnRhdGlvbiBmYXVsdCBzaWduYWwgdGVybWluYXRl ZCBwcm9ncmFtIGNjMSINCg0KDQpKdWVyZ2VuDQoNCj4gICB0ZXN0LWFybWhmLWFybWhmLXhs LWNyZWRpdDIgMTggZ3Vlc3Qtc3RhcnQvZGViaWFuLnJlcGVhdCBmYWlsIGluIDE3NDYzMCBS RUdSLiB2cy4gMTc0NTQwDQo+ICAgdGVzdC1hcm1oZi1hcm1oZi14bC1tdWx0aXZjcHUgMTgg Z3Vlc3Qtc3RhcnQvZGViaWFuLnJlcGVhdCBmYWlsIGluIDE3NDYzOCBSRUdSLiB2cy4gMTc0 NTQwDQo+IA0KPiBUZXN0cyB3aGljaCBhcmUgZmFpbGluZyBpbnRlcm1pdHRlbnRseSAobm90 IGJsb2NraW5nKToNCj4gICB0ZXN0LWFtZDY0LWkzODYteGwtc2hhZG93ICAgICA3IHhlbi1p bnN0YWxsICAgICAgZmFpbCBpbiAxNzQ2MDggcGFzcyBpbiAxNzQ2NDINCj4gICB0ZXN0LWFt ZDY0LWkzODYteGwteHNtICAgICAgMTcgZ3Vlc3Qtc2F2ZXJlc3RvcmUgZmFpbCBpbiAxNzQ2 MzAgcGFzcyBpbiAxNzQ2NDINCj4gICB0ZXN0LWFybWhmLWFybWhmLXhsLXJ0ZHMgMTggZ3Vl c3Qtc3RhcnQvZGViaWFuLnJlcGVhdCBmYWlsIGluIDE3NDYzMCBwYXNzIGluIDE3NDY0Mg0K PiAgIHRlc3QtYW1kNjQtaTM4Ni1wYWlyICAgICAxMSB4ZW4taW5zdGFsbC9kc3RfaG9zdCBm YWlsIGluIDE3NDYzOCBwYXNzIGluIDE3NDY0Mg0KPiAgIHRlc3QtYW1kNjQtaTM4Ni1saWJ2 aXJ0LXhzbSAgIDggeGVuLWJvb3QgICAgICAgICBmYWlsIGluIDE3NDYzOCBwYXNzIGluIDE3 NDY0Mg0KPiAgIHRlc3QtYXJtaGYtYXJtaGYteGwtcnRkcyAgICAgMTQgZ3Vlc3Qtc3RhcnQg ICAgICBmYWlsIGluIDE3NDYzOCBwYXNzIGluIDE3NDY0Mg0KPiAgIHRlc3QtYXJtaGYtYXJt aGYtbGlidmlydC1yYXcgMTMgZ3Vlc3Qtc3RhcnQgICAgICAgICAgICAgICAgZmFpbCBwYXNz IGluIDE3NDYwOA0KPiAgIHRlc3QtYW1kNjQtaTM4Ni1saWJ2aXJ0LXFlbXV1LWRlYmlhbmh2 bS1hbWQ2NC14c20gNyB4ZW4taW5zdGFsbCBmYWlsIHBhc3MgaW4gMTc0NjMwDQo+ICAgdGVz dC1hcm1oZi1hcm1oZi14bC1jcmVkaXQyICAxNCBndWVzdC1zdGFydCAgICAgICAgICAgICAg ICBmYWlsIHBhc3MgaW4gMTc0NjMwDQo+ICAgdGVzdC1hbWQ2NC1pMzg2LXBhaXIgICAgICAg ICAxMCB4ZW4taW5zdGFsbC9zcmNfaG9zdCAgICAgICBmYWlsIHBhc3MgaW4gMTc0NjM4DQo+ ICAgdGVzdC1hcm1oZi1hcm1oZi14bC1tdWx0aXZjcHUgMTQgZ3Vlc3Qtc3RhcnQgICAgICAg ICAgICAgICBmYWlsIHBhc3MgaW4gMTc0NjM4DQo+ICAgdGVzdC1hcm1oZi1hcm1oZi14bC1j cmVkaXQxICAxOCBndWVzdC1zdGFydC9kZWJpYW4ucmVwZWF0ICBmYWlsIHBhc3MgaW4gMTc0 NjM4DQo+ICAgdGVzdC1hcm1oZi1hcm1oZi1saWJ2aXJ0LXFjb3cyIDEzIGd1ZXN0LXN0YXJ0 ICAgICAgICAgICAgICBmYWlsIHBhc3MgaW4gMTc0NjM4DQo+IA0KPiBUZXN0cyB3aGljaCBk aWQgbm90IHN1Y2NlZWQsIGJ1dCBhcmUgbm90IGJsb2NraW5nOg0KPiAgIHRlc3QtYXJtNjQt YXJtNjQtZXhhbWluZSAgICAgIDEgYnVpbGQtY2hlY2soMSkgICAgICAgICAgICAgICBibG9j a2VkICBuL2ENCj4gICB0ZXN0LWFybTY0LWFybTY0LWxpYnZpcnQtcmF3ICAxIGJ1aWxkLWNo ZWNrKDEpICAgICAgICAgICAgICAgYmxvY2tlZCAgbi9hDQo+ICAgdGVzdC1hcm02NC1hcm02 NC1saWJ2aXJ0LXhzbSAgMSBidWlsZC1jaGVjaygxKSAgICAgICAgICAgICAgIGJsb2NrZWQg IG4vYQ0KPiAgIHRlc3QtYXJtNjQtYXJtNjQteGwgICAgICAgICAgIDEgYnVpbGQtY2hlY2so MSkgICAgICAgICAgICAgICBibG9ja2VkICBuL2ENCj4gICB0ZXN0LWFybTY0LWFybTY0LXhs LWNyZWRpdDEgICAxIGJ1aWxkLWNoZWNrKDEpICAgICAgICAgICAgICAgYmxvY2tlZCAgbi9h DQo+ICAgdGVzdC1hcm02NC1hcm02NC14bC1jcmVkaXQyICAgMSBidWlsZC1jaGVjaygxKSAg ICAgICAgICAgICAgIGJsb2NrZWQgIG4vYQ0KPiAgIHRlc3QtYXJtNjQtYXJtNjQteGwtc2Vh dHRsZSAgIDEgYnVpbGQtY2hlY2soMSkgICAgICAgICAgICAgICBibG9ja2VkICBuL2ENCj4g ICB0ZXN0LWFybTY0LWFybTY0LXhsLXRodW5kZXJ4ICAxIGJ1aWxkLWNoZWNrKDEpICAgICAg ICAgICAgICAgYmxvY2tlZCAgbi9hDQo+ICAgdGVzdC1hcm02NC1hcm02NC14bC12aGQgICAg ICAgMSBidWlsZC1jaGVjaygxKSAgICAgICAgICAgICAgIGJsb2NrZWQgIG4vYQ0KPiAgIHRl c3QtYXJtNjQtYXJtNjQteGwteHNtICAgICAgIDEgYnVpbGQtY2hlY2soMSkgICAgICAgICAg ICAgICBibG9ja2VkICBuL2ENCj4gICB0ZXN0LWFybWhmLWFybWhmLWxpYnZpcnQtcmF3IDE1 IHNhdmVyZXN0b3JlLXN1cHBvcnQtY2hlY2sgZmFpbCBpbiAxNzQ2MDggbGlrZSAxNzQ1NDAN Cj4gICB0ZXN0LWFybWhmLWFybWhmLWxpYnZpcnQtcmF3IDE0IG1pZ3JhdGUtc3VwcG9ydC1j aGVjayBmYWlsIGluIDE3NDYwOCBuZXZlciBwYXNzDQo+ICAgdGVzdC1hcm1oZi1hcm1oZi1s aWJ2aXJ0LXFjb3cyIDE1IHNhdmVyZXN0b3JlLXN1cHBvcnQtY2hlY2sgZmFpbCBpbiAxNzQ2 MzAgbGlrZSAxNzQ1NDANCj4gICB0ZXN0LWFybTY0LWFybTY0LXhsLXNlYXR0bGUgMTUgbWln cmF0ZS1zdXBwb3J0LWNoZWNrIGZhaWwgaW4gMTc0NjMwIG5ldmVyIHBhc3MNCj4gICB0ZXN0 LWFybTY0LWFybTY0LXhsLXNlYXR0bGUgMTYgc2F2ZXJlc3RvcmUtc3VwcG9ydC1jaGVjayBm YWlsIGluIDE3NDYzMCBuZXZlciBwYXNzDQo+ICAgdGVzdC1hcm02NC1hcm02NC14bCAgICAg ICAgIDE1IG1pZ3JhdGUtc3VwcG9ydC1jaGVjayBmYWlsIGluIDE3NDYzMCBuZXZlciBwYXNz DQo+ICAgdGVzdC1hcm02NC1hcm02NC14bCAgICAgMTYgc2F2ZXJlc3RvcmUtc3VwcG9ydC1j aGVjayBmYWlsIGluIDE3NDYzMCBuZXZlciBwYXNzDQo+ICAgdGVzdC1hcm02NC1hcm02NC14 bC14c20gICAgIDE1IG1pZ3JhdGUtc3VwcG9ydC1jaGVjayBmYWlsIGluIDE3NDYzMCBuZXZl ciBwYXNzDQo+ICAgdGVzdC1hcm02NC1hcm02NC14bC14c20gMTYgc2F2ZXJlc3RvcmUtc3Vw cG9ydC1jaGVjayBmYWlsIGluIDE3NDYzMCBuZXZlciBwYXNzDQo+ICAgdGVzdC1hcm02NC1h cm02NC1saWJ2aXJ0LXhzbSAxNSBtaWdyYXRlLXN1cHBvcnQtY2hlY2sgZmFpbCBpbiAxNzQ2 MzAgbmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJtNjQtYXJtNjQtbGlidmlydC14c20gMTYgc2F2 ZXJlc3RvcmUtc3VwcG9ydC1jaGVjayBmYWlsIGluIDE3NDYzMCBuZXZlciBwYXNzDQo+ICAg dGVzdC1hcm02NC1hcm02NC14bC1jcmVkaXQyIDE1IG1pZ3JhdGUtc3VwcG9ydC1jaGVjayBm YWlsIGluIDE3NDYzMCBuZXZlciBwYXNzDQo+ICAgdGVzdC1hcm02NC1hcm02NC14bC1jcmVk aXQyIDE2IHNhdmVyZXN0b3JlLXN1cHBvcnQtY2hlY2sgZmFpbCBpbiAxNzQ2MzAgbmV2ZXIg cGFzcw0KPiAgIHRlc3QtYXJtNjQtYXJtNjQteGwtY3JlZGl0MSAxNSBtaWdyYXRlLXN1cHBv cnQtY2hlY2sgZmFpbCBpbiAxNzQ2MzAgbmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJtNjQtYXJt NjQteGwtY3JlZGl0MSAxNiBzYXZlcmVzdG9yZS1zdXBwb3J0LWNoZWNrIGZhaWwgaW4gMTc0 NjMwIG5ldmVyIHBhc3MNCj4gICB0ZXN0LWFybTY0LWFybTY0LXhsLXRodW5kZXJ4IDE1IG1p Z3JhdGUtc3VwcG9ydC1jaGVjayBmYWlsIGluIDE3NDYzMCBuZXZlciBwYXNzDQo+ICAgdGVz dC1hcm02NC1hcm02NC14bC10aHVuZGVyeCAxNiBzYXZlcmVzdG9yZS1zdXBwb3J0LWNoZWNr IGZhaWwgaW4gMTc0NjMwIG5ldmVyIHBhc3MNCj4gICB0ZXN0LWFybWhmLWFybWhmLXhsLWNy ZWRpdDIgMTUgbWlncmF0ZS1zdXBwb3J0LWNoZWNrIGZhaWwgaW4gMTc0NjMwIG5ldmVyIHBh c3MNCj4gICB0ZXN0LWFybWhmLWFybWhmLXhsLWNyZWRpdDIgMTYgc2F2ZXJlc3RvcmUtc3Vw cG9ydC1jaGVjayBmYWlsIGluIDE3NDYzMCBuZXZlciBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1p Mzg2LWxpYnZpcnQtcWVtdXUtZGViaWFuaHZtLWFtZDY0LXhzbSAxMyBtaWdyYXRlLXN1cHBv cnQtY2hlY2sgZmFpbCBpbiAxNzQ2MzAgbmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJtNjQtYXJt NjQtbGlidmlydC1yYXcgMTQgbWlncmF0ZS1zdXBwb3J0LWNoZWNrIGZhaWwgaW4gMTc0NjMw IG5ldmVyIHBhc3MNCj4gICB0ZXN0LWFybTY0LWFybTY0LWxpYnZpcnQtcmF3IDE1IHNhdmVy ZXN0b3JlLXN1cHBvcnQtY2hlY2sgZmFpbCBpbiAxNzQ2MzAgbmV2ZXIgcGFzcw0KPiAgIHRl c3QtYXJtNjQtYXJtNjQteGwtdmhkICAgICAxNCBtaWdyYXRlLXN1cHBvcnQtY2hlY2sgZmFp bCBpbiAxNzQ2MzAgbmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJtNjQtYXJtNjQteGwtdmhkIDE1 IHNhdmVyZXN0b3JlLXN1cHBvcnQtY2hlY2sgZmFpbCBpbiAxNzQ2MzAgbmV2ZXIgcGFzcw0K PiAgIHRlc3QtYXJtaGYtYXJtaGYtbGlidmlydC1xY293MiAxNCBtaWdyYXRlLXN1cHBvcnQt Y2hlY2sgZmFpbCBpbiAxNzQ2MzAgbmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJtaGYtYXJtaGYt eGwtbXVsdGl2Y3B1IDE1IG1pZ3JhdGUtc3VwcG9ydC1jaGVjayBmYWlsIGluIDE3NDYzOCBu ZXZlciBwYXNzDQo+ICAgdGVzdC1hcm1oZi1hcm1oZi14bC1tdWx0aXZjcHUgMTYgc2F2ZXJl c3RvcmUtc3VwcG9ydC1jaGVjayBmYWlsIGluIDE3NDYzOCBuZXZlciBwYXNzDQo+ICAgdGVz dC1hbWQ2NC1hbWQ2NC14bC1xZW11dS13aW43LWFtZDY0IDE5IGd1ZXN0LXN0b3AgICAgICAg ICAgICBmYWlsIGxpa2UgMTc0NTQwDQo+ICAgdGVzdC1hbWQ2NC1pMzg2LXhsLXFlbXV0LXdp bjctYW1kNjQgMTkgZ3Vlc3Qtc3RvcCAgICAgICAgICAgICBmYWlsIGxpa2UgMTc0NTQwDQo+ ICAgdGVzdC1hbWQ2NC1pMzg2LXhsLXFlbXV1LXdpbjctYW1kNjQgMTkgZ3Vlc3Qtc3RvcCAg ICAgICAgICAgICBmYWlsIGxpa2UgMTc0NTQwDQo+ICAgdGVzdC1hbWQ2NC1hbWQ2NC14bC1x ZW11dC13aW43LWFtZDY0IDE5IGd1ZXN0LXN0b3AgICAgICAgICAgICBmYWlsIGxpa2UgMTc0 NTQwDQo+ICAgdGVzdC1hbWQ2NC1hbWQ2NC1xZW11dS1uZXN0ZWQtYW1kIDIwIGRlYmlhbi1o dm0taW5zdGFsbC9sMS9sMiBmYWlsIGxpa2UgMTc0NTQwDQo+ICAgdGVzdC1hbWQ2NC1hbWQ2 NC14bC1xZW11dS13czE2LWFtZDY0IDE5IGd1ZXN0LXN0b3AgICAgICAgICAgICBmYWlsIGxp a2UgMTc0NTQwDQo+ICAgdGVzdC1hbWQ2NC1hbWQ2NC14bC1xZW11dC13czE2LWFtZDY0IDE5 IGd1ZXN0LXN0b3AgICAgICAgICAgICBmYWlsIGxpa2UgMTc0NTQwDQo+ICAgdGVzdC1hbWQ2 NC1pMzg2LXhsLXFlbXV0LXdzMTYtYW1kNjQgMTkgZ3Vlc3Qtc3RvcCAgICAgICAgICAgICBm YWlsIGxpa2UgMTc0NTQwDQo+ICAgdGVzdC1hcm1oZi1hcm1oZi1saWJ2aXJ0ICAgICAxNiBz YXZlcmVzdG9yZS1zdXBwb3J0LWNoZWNrICAgIGZhaWwgIGxpa2UgMTc0NTQwDQo+ICAgdGVz dC1hbWQ2NC1pMzg2LXhsLXFlbXV1LXdzMTYtYW1kNjQgMTkgZ3Vlc3Qtc3RvcCAgICAgICAg ICAgICBmYWlsIGxpa2UgMTc0NTQwDQo+ICAgdGVzdC1hbWQ2NC1pMzg2LXhsLXB2c2hpbSAg ICAxNCBndWVzdC1zdGFydCAgICAgICAgICAgICAgICAgIGZhaWwgICBuZXZlciBwYXNzDQo+ ICAgdGVzdC1hbWQ2NC1hbWQ2NC1saWJ2aXJ0ICAgICAxNSBtaWdyYXRlLXN1cHBvcnQtY2hl Y2sgICAgICAgIGZhaWwgICBuZXZlciBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1hbWQ2NC1saWJ2 aXJ0LXhzbSAxNSBtaWdyYXRlLXN1cHBvcnQtY2hlY2sgICAgICAgIGZhaWwgICBuZXZlciBw YXNzDQo+ICAgdGVzdC1hbWQ2NC1pMzg2LWxpYnZpcnQteHNtICAxNSBtaWdyYXRlLXN1cHBv cnQtY2hlY2sgICAgICAgIGZhaWwgICBuZXZlciBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1pMzg2 LWxpYnZpcnQgICAgICAxNSBtaWdyYXRlLXN1cHBvcnQtY2hlY2sgICAgICAgIGZhaWwgICBu ZXZlciBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1hbWQ2NC1saWJ2aXJ0LXFlbXV1LWRlYmlhbmh2 bS1hbWQ2NC14c20gMTMgbWlncmF0ZS1zdXBwb3J0LWNoZWNrIGZhaWwgbmV2ZXIgcGFzcw0K PiAgIHRlc3QtYW1kNjQtaTM4Ni1saWJ2aXJ0LXJhdyAgMTQgbWlncmF0ZS1zdXBwb3J0LWNo ZWNrICAgICAgICBmYWlsICAgbmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJtaGYtYXJtaGYteGwt cnRkcyAgICAgMTUgbWlncmF0ZS1zdXBwb3J0LWNoZWNrICAgICAgICBmYWlsICAgbmV2ZXIg cGFzcw0KPiAgIHRlc3QtYXJtaGYtYXJtaGYteGwtcnRkcyAgICAgMTYgc2F2ZXJlc3RvcmUt c3VwcG9ydC1jaGVjayAgICBmYWlsICAgbmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJtaGYtYXJt aGYteGwtY3ViaWV0cnVjayAxNSBtaWdyYXRlLXN1cHBvcnQtY2hlY2sgICAgICAgIGZhaWwg bmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJtaGYtYXJtaGYteGwtY3ViaWV0cnVjayAxNiBzYXZl cmVzdG9yZS1zdXBwb3J0LWNoZWNrICAgIGZhaWwgbmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJt aGYtYXJtaGYteGwgICAgICAgICAgMTUgbWlncmF0ZS1zdXBwb3J0LWNoZWNrICAgICAgICBm YWlsICAgbmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJtaGYtYXJtaGYteGwgICAgICAgICAgMTYg c2F2ZXJlc3RvcmUtc3VwcG9ydC1jaGVjayAgICBmYWlsICAgbmV2ZXIgcGFzcw0KPiAgIHRl c3QtYXJtaGYtYXJtaGYteGwtY3JlZGl0MSAgMTUgbWlncmF0ZS1zdXBwb3J0LWNoZWNrICAg ICAgICBmYWlsICAgbmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJtaGYtYXJtaGYteGwtY3JlZGl0 MSAgMTYgc2F2ZXJlc3RvcmUtc3VwcG9ydC1jaGVjayAgICBmYWlsICAgbmV2ZXIgcGFzcw0K PiAgIHRlc3QtYW1kNjQtYW1kNjQtbGlidmlydC12aGQgMTQgbWlncmF0ZS1zdXBwb3J0LWNo ZWNrICAgICAgICBmYWlsICAgbmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJtaGYtYXJtaGYtbGli dmlydCAgICAgMTUgbWlncmF0ZS1zdXBwb3J0LWNoZWNrICAgICAgICBmYWlsICAgbmV2ZXIg cGFzcw0KPiAgIHRlc3QtYXJtaGYtYXJtaGYteGwtYXJuZGFsZSAgMTUgbWlncmF0ZS1zdXBw b3J0LWNoZWNrICAgICAgICBmYWlsICAgbmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJtaGYtYXJt aGYteGwtYXJuZGFsZSAgMTYgc2F2ZXJlc3RvcmUtc3VwcG9ydC1jaGVjayAgICBmYWlsICAg bmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJtaGYtYXJtaGYteGwtdmhkICAgICAgMTQgbWlncmF0 ZS1zdXBwb3J0LWNoZWNrICAgICAgICBmYWlsICAgbmV2ZXIgcGFzcw0KPiAgIHRlc3QtYXJt aGYtYXJtaGYteGwtdmhkICAgICAgMTUgc2F2ZXJlc3RvcmUtc3VwcG9ydC1jaGVjayAgICBm YWlsICAgbmV2ZXIgcGFzcw0KPiANCj4gdmVyc2lvbiB0YXJnZXRlZCBmb3IgdGVzdGluZzoN Cj4gICBsaW51eCAgICAgICAgICAgICAgICBhMGQ5Mzg0OTY3MjE0NzgzYTkyOTczYzkyMDA5 MmI3MjUxYzAzZTU3DQo+IGJhc2VsaW5lIHZlcnNpb246DQo+ICAgbGludXggICAgICAgICAg ICAgICAgYjcwYmZlYjk4NjM1MDQwNTg4ODgzNTAzZDI3NjBlMGY0NjIzMTQ5MQ0KPiANCj4g TGFzdCB0ZXN0IG9mIGJhc2lzICAgMTc0NTQwICAyMDIyLTEwLTI5IDEyOjQxOjU3IFogICAg NyBkYXlzDQo+IEZhaWxpbmcgc2luY2UgICAgICAgIDE3NDU3NSAgMjAyMi0xMS0wMSAxODo0 MjozOSBaICAgIDQgZGF5cyAgICA4IGF0dGVtcHRzDQo+IFRlc3Rpbmcgc2FtZSBzaW5jZSAg IDE3NDYwOCAgMjAyMi0xMS0wMyAxOTo0Njo1MCBaICAgIDIgZGF5cyAgICA1IGF0dGVtcHRz DQo+IA0KPiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0NCj4gUGVvcGxlIHdobyB0b3VjaGVkIHJldmlzaW9ucyB1bmRlciB0 ZXN0Og0KPiAgICAiRGFycmljayBKLiBXb25nIiA8ZGFycmljay53b25nQG9yYWNsZS5jb20+ DQo+ICAgIEFhcm9uIENvbm9sZSA8YWNvbm9sZUByZWRoYXQuY29tPg0KPiAgICBBYmhpbmF2 IEt1bWFyIDxxdWljX2FiaGluYXZrQHF1aWNpbmMuY29tPg0KPiAgICBBZHJpYW4gSHVudGVy IDxhZHJpYW4uaHVudGVyQGludGVsLmNvbT4NCj4gICAgQWxleGFuZGVyIEFyaW5nIDxhYWhy aW5nb0ByZWRoYXQuY29tPg0KPiAgICBBbGV4YW5kZXIgU3RlaW4gPGFsZXhhbmRlci5zdGVp bkBldy50cS1ncm91cC5jb20+DQo+ICAgIEFuZHJldyBNb3J0b24gPGFrcG1AbGludXgtZm91 bmRhdGlvbi5vcmc+DQo+ICAgIEFuc3NpIEhhbm51bGEgPGFuc3NpLmhhbm51bGFAYml0d2lz ZS5maT4NCj4gICAgQXJuYWxkbyBDYXJ2YWxobyBkZSBNZWxvIDxhY21lQHJlZGhhdC5jb20+ DQo+ICAgIEJpanUgRGFzIDxiaWp1LmRhcy5qekBicC5yZW5lc2FzLmNvbT4NCj4gICAgQnJp YW4gRm9zdGVyIDxiZm9zdGVyQHJlZGhhdC5jb20+DQo+ICAgIENoYW5kYW4gQmFidSBSIDxj aGFuZGFuLmJhYnVAb3JhY2xlLmNvbT4NCj4gICAgQ2hlbiBaaG9uZ2ppbiA8Y2hlbnpob25n amluQGh1YXdlaS5jb20+DQo+ICAgIENoZW4gWmhvdSA8Y2hlbnpob3UxMEBodWF3ZWkuY29t Pg0KPiAgICBDaHJpcyBQYWNraGFtIDxjaHJpcy5wYWNraGFtQGFsbGllZHRlbGVzaXMuY28u bno+DQo+ICAgIENocmlzdGlhbiBBLiBFaHJoYXJkdCA8bGtAYy0tZS5kZT4NCj4gICAgRGFy cmljayBKLiBXb25nIDxkYXJyaWNrLndvbmdAb3JhY2xlLmNvbT4NCj4gICAgRGFycmljayBK LiBXb25nIDxkandvbmdAa2VybmVsLm9yZz4NCj4gICAgRGF2ZSBDaGlubmVyIDxkY2hpbm5l ckByZWRoYXQuY29tPg0KPiAgICBEYXZpZCBTLiBNaWxsZXIgPGRhdmVtQGRhdmVtbG9mdC5u ZXQ+DQo+ICAgIERlbWkgTWFyaWUgT2Jlbm91ciA8ZGVtaUBpbnZpc2libGV0aGluZ3NsYWIu Y29tPg0KPiAgICBEb25nbGlhbmcgTXUgPGR6bTkxQGh1c3QuZWR1LmNuPg0KPiAgICBFcmlj IER1bWF6ZXQgPGVkdW1hemV0QGdvb2dsZS5jb20+DQo+ICAgIEZsb3JpYW4gRmFpbmVsbGkg PGYuZmFpbmVsbGlAZ21haWwuY29tPg0KPiAgICBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdr aEBsaW51eGZvdW5kYXRpb24ub3JnPg0KPiAgICBHdWVudGVyIFJvZWNrIDxsaW51eEByb2Vj ay11cy5uZXQ+DQo+ICAgIEd1cnVjaGFyYW4gPGd1cnVjaGFyYW54LmdAaW50ZWwuY29tPiAo QSBDb250aW5nZW50IHdvcmtlciBhdCBJbnRlbCkNCj4gICAgSGFubnUgSGFydGlrYWluZW4g PGhhbm51QGhydGsuaW4+DQo+ICAgIEhhbnMgVmVya3VpbCA8aHZlcmt1aWwtY2lzY29AeHM0 YWxsLm5sPg0KPiAgICBIZWlrbyBDYXJzdGVucyA8aGNhQGxpbnV4LmlibS5jb20+DQo+ICAg IEhlbGdlIERlbGxlciA8ZGVsbGVyQGdteC5kZT4NCj4gICAgSHlvbmcgWW91YiBLaW0gPGh5 b25raW1AY2lzY28uY29tPg0KPiAgICBIeXVud29vIEtpbSA8aW12NGJlbEBnbWFpbC5jb20+ DQo+ICAgIElseWEgTWF4aW1ldHMgPGkubWF4aW1ldHNAb3ZuLm9yZz4NCj4gICAgSmFjb2Ig S2VsbGVyIDxqYWNvYi5lLmtlbGxlckBpbnRlbC5jb20+DQo+ICAgIEpha3ViIEtpY2luc2tp IDxrdWJhQGtlcm5lbC5vcmc+DQo+ICAgIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv bT4NCj4gICAgSmFzb24gQS4gRG9uZW5mZWxkIDxKYXNvbkB6eDJjNC5jb20+DQo+ICAgIEpl ZmYgVmFuaG9vZiA8amR2MTAyOUBnbWFpbC5jb20+DQo+ICAgIEplbnMgR2xhdGhlIDxqZW5z LmdsYXRoZUBvbGRzY2hvb2xzb2x1dGlvbnMuYml6Pg0KPiAgICBKaW1teSBBc3NhcnNzb24g PGV4dGphQGt2YXNlci5jb20+DQo+ICAgIEpvaGFuIEhvdm9sZCA8am9oYW4rbGluYXJvQGtl cm5lbC5vcmc+DQo+ICAgIEpvbiBIdW50ZXIgPGpvbmF0aGFuaEBudmlkaWEuY29tPg0KPiAg ICBKb24gTWFsb3kgPGptYWxveUByZWRoYXQuY29tPg0KPiAgICBKb25hdGhhbiBDYW1lcm9u IDxKb25hdGhhbi5DYW1lcm9uQGh1YXdlaS5jb20+DQo+ICAgIEpvc2ggUG9pbWJvZXVmIDxq cG9pbWJvZUBrZXJuZWwub3JnPg0KPiAgICBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5j b20+DQo+ICAgIEp1c3RpbiBDaGVuIDxqdXN0aW5wb3BvNkBnbWFpbC5jb20+DQo+ICAgIEtv bnJhZCBKYW5rb3dza2kgPGtvbnJhZDAuamFua293c2tpQGludGVsLmNvbT4NCj4gICAgS3Vv Z2VlIEhzaWVoIDxxdWljX2toc2llaEBxdWljaW5jLmNvbT4NCj4gICAgTGVvbiBSb21hbm92 c2t5IDxsZW9ucm9AbnZpZGlhLmNvbT4NCj4gICAgTGludXggS2VybmVsIEZ1bmN0aW9uYWwg VGVzdGluZyA8bGtmdEBsaW5hcm8ub3JnPg0KPiAgICBMdWl6IENhcGl0dWxpbm8gPGx1aXpj YXBAYW1hem9uLmNvbT4NCj4gICAgTS4gVmVmYSBCaWNha2NpIDxtLnYuYkBydW5ib3guY29t Pg0KPiAgICBNYXJjIEtsZWluZS1CdWRkZSA8bWtsQHBlbmd1dHJvbml4LmRlPg0KPiAgICBN YXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kgPG1hcm1hcmVrQGludmlzaWJsZXRoaW5nc2xh Yi5jb20+DQo+ICAgIE1hcmlvIExpbW9uY2llbGxvIDxtYXJpby5saW1vbmNpZWxsb0BhbWQu Y29tPg0KPiAgICBNYXRldXN6IFBhbGN6ZXdza2kgPG1hdGV1c3oucGFsY3pld3NraUBpbnRl bC5jb20+DQo+ICAgIE1hdGhpYXMgTnltYW4gPG1hdGhpYXMubnltYW5AbGludXguaW50ZWwu Y29tPg0KPiAgICBNYXR0aGV3IE1hIDxtYWhvbmd3ZWlAemVrdS5jb20+DQo+ICAgIE1hdHRp IFZhaXR0aW5lbiA8bWF6emllc2FjY291bnRAZ21haWwuY29tPg0KPiAgICBNYXVybyBDYXJ2 YWxobyBDaGVoYWIgPG1jaGVoYWJAa2VybmVsLm9yZz4NCj4gICAgTWljaGFsIEphcm9uIDxt aWNoYWx4Lmphcm9uQGludGVsLmNvbT4NCj4gICAgTWlrZSBLcmF2ZXR6IDxtaWtlLmtyYXZl dHpAb3JhY2xlLmNvbT4NCj4gICAgTWlxdWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290 bGluLmNvbT4NCj4gICAgTmF0aGFuIEh1Y2tsZWJlcnJ5IDxuaHVja0Bnb29nbGUuY29tPg0K PiAgICBOZWFsIENhcmR3ZWxsIDxuY2FyZHdlbGxAZ29vZ2xlLmNvbT4NCj4gICAgTmljb2xh cyBEaWNodGVsIDxuaWNvbGFzLmRpY2h0ZWxANndpbmQuY29tPg0KPiAgICBPbGVrc2lqIFJl bXBlbCA8by5yZW1wZWxAcGVuZ3V0cm9uaXguZGU+DQo+ICAgIFBhb2xvIEFiZW5pIDxwYWJl bmlAcmVkaGF0LmNvbT4NCj4gICAgUGV0ZXIgWmlqbHN0cmEgPHBldGVyekBpbmZyYWRlYWQu b3JnPg0KPiAgICBSYWZhZWwgSi4gV3lzb2NraSA8cmFmYWVsLmoud3lzb2NraUBpbnRlbC5j b20+DQo+ICAgIFJhanUgUmFuZ29qdSA8UmFqdS5SYW5nb2p1QGFtZC5jb20+DQo+ICAgIFJh bmR5IER1bmxhcCA8cmR1bmxhcEBpbmZyYWRlYWQub3JnPg0KPiAgICBSaWsgdmFuIFJpZWwg PHJpZWxAc3VycmllbC5jb20+DQo+ICAgIFNhZWVkIE1haGFtZWVkIDxzYWVlZG1AbnZpZGlh LmNvbT4NCj4gICAgU2FrYXJpIEFpbHVzIDxzYWthcmkuYWlsdXNAbGludXguaW50ZWwuY29t Pg0KPiAgICBTYXNoYSBMZXZpbiA8c2FzaGFsQGtlcm5lbC5vcmc+DQo+ICAgIFNocmVleWEg UGF0ZWwgPHNocmVleWEucGF0ZWxAY29sbGFib3JhLmNvbT4NCj4gICAgU2xhd29taXIgTGFi YSA8c2xhd29taXJ4LmxhYmFAaW50ZWwuY29tPg0KPiAgICBTdGVmYW4gU2NobWlkdCA8c3Rl ZmFuQGRhdGVuZnJlaWhhZmVuLm9yZz4NCj4gICAgU3RldmVuIFJvc3RlZHQgKEdvb2dsZSkg PHJvc3RlZHRAZ29vZG1pcy5vcmc+DQo+ICAgIFN1ZGVlcCBIb2xsYSA8c3VkZWVwLmhvbGxh QGFybS5jb20+DQo+ICAgIFN1ZGlwIE11a2hlcmplZSA8c3VkaXAubXVraGVyamVlQGNvZGV0 aGluay5jby51az4NCj4gICAgU3lsd2VzdGVyIER6aWVkeml1Y2ggPHN5bHdlc3RlcnguZHpp ZWR6aXVjaEBpbnRlbC5jb20+DQo+ICAgIFRha2FzaGkgSXdhaSA8dGl3YWlAc3VzZS5kZT4N Cj4gICAgVGFyaXEgVG91a2FuIDx0YXJpcXRAbnZpZGlhLmNvbT4NCj4gICAgVGVqdW4gSGVv IDx0akBrZXJuZWwub3JnPg0KPiAgICBUaGluaCBOZ3V5ZW4gPFRoaW5oLk5ndXllbkBzeW5v cHN5cy5jb20+DQo+ICAgIFRvbSBMZW5kYWNreSA8dGhvbWFzLmxlbmRhY2t5QGFtZC5jb20+ DQo+ICAgIFRvbnkgTydCcmllbiA8dG9ueS5vYnJpZW5AYWxsaWVkdGVsZXNpcy5jby5uej4N Cj4gICAgVWxmIEhhbnNzb24gPHVsZi5oYW5zc29uQGxpbmFyby5vcmc+DQo+ICAgIFZhc2ls eSBHb3JiaWsgPGdvckBsaW51eC5pYm0uY29tPg0KPiAgICBWaW5lZXQgR3VwdGEgPHZndXB0 YUBrZXJuZWwub3JnPg0KPiAgICBWbGFkaW1pciBPbHRlYW4gPHZsYWRpbWlyLm9sdGVhbkBu eHAuY29tPg0KPiAgICBXZWkgWW9uZ2p1biA8d2VpeW9uZ2p1bjFAaHVhd2VpLmNvbT4NCj4g ICAgWGluIExvbmcgPGx1Y2llbi54aW5AZ21haWwuY29tPg0KPiAgICBZYW5nIFlpbmdsaWFu ZyA8eWFuZ3lpbmdsaWFuZ0BodWF3ZWkuY29tPg0KPiAgICBZb25ncWluIExpdSA8eW9uZ3Fp bi5saXVAbGluYXJvLm9yZz4NCj4gICAgWmhhbmcgQ2hhbmd6aG9uZyA8emhhbmdjaGFuZ3po b25nQGh1YXdlaS5jb20+DQo+ICAgIFpoZW5nY2hhbyBTaGFvIDxzaGFvemhlbmdjaGFvQGh1 YXdlaS5jb20+DQo+IA0KPiBqb2JzOg0KPiAgIGJ1aWxkLWFtZDY0LXhzbSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgYnVpbGQtYXJt NjQteHNtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBh c3MNCj4gICBidWlsZC1pMzg2LXhzbSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcGFzcw0KPiAgIGJ1aWxkLWFtZDY0ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgYnVpbGQtYXJtNjQg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MN Cj4gICBidWlsZC1hcm1oZiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgcGFzcw0KPiAgIGJ1aWxkLWkzODYgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgYnVpbGQtYW1kNjQtbGli dmlydCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4g ICBidWlsZC1hcm02NC1saWJ2aXJ0ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgcGFzcw0KPiAgIGJ1aWxkLWFybWhmLWxpYnZpcnQgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgYnVpbGQtaTM4Ni1saWJ2aXJ0 ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4gICBi dWlsZC1hbWQ2NC1wdm9wcyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcGFzcw0KPiAgIGJ1aWxkLWFybTY0LXB2b3BzICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBmYWlsDQo+ICAgYnVpbGQtYXJtaGYtcHZvcHMgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4gICBidWls ZC1pMzg2LXB2b3BzICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgcGFzcw0KPiAgIHRlc3QtYW1kNjQtYW1kNjQteGwgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1jb3Jlc2NoZWQtYW1k NjQteGwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4gICB0ZXN0LWFy bTY0LWFybTY0LXhsICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg YmxvY2tlZA0KPiAgIHRlc3QtYXJtaGYtYXJtaGYteGwgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1pMzg2LXhsICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4gICB0ZXN0LWFt ZDY0LWNvcmVzY2hlZC1pMzg2LXhsICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cGFzcw0KPiAgIHRlc3QtYW1kNjQtYW1kNjQtbGlidmlydC1xZW11dS1kZWJpYW5odm0tYW1k NjQteHNtICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1pMzg2LWxpYnZpcnQtcWVt dXUtZGViaWFuaHZtLWFtZDY0LXhzbSAgICAgICAgICAgIGZhaWwNCj4gICB0ZXN0LWFtZDY0 LWFtZDY0LXhsLXFlbXV0LXN0dWJkb20tZGViaWFuaHZtLWFtZDY0LXhzbSAgICAgICAgcGFz cw0KPiAgIHRlc3QtYW1kNjQtaTM4Ni14bC1xZW11dC1zdHViZG9tLWRlYmlhbmh2bS1hbWQ2 NC14c20gICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1hbWQ2NC14bC1xZW11dC1kZWJp YW5odm0taTM4Ni14c20gICAgICAgICAgICAgICAgIHBhc3MNCj4gICB0ZXN0LWFtZDY0LWkz ODYteGwtcWVtdXQtZGViaWFuaHZtLWkzODYteHNtICAgICAgICAgICAgICAgICAgcGFzcw0K PiAgIHRlc3QtYW1kNjQtYW1kNjQteGwtcWVtdXUtZGViaWFuaHZtLWkzODYteHNtICAgICAg ICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1pMzg2LXhsLXFlbXV1LWRlYmlhbmh2 bS1pMzg2LXhzbSAgICAgICAgICAgICAgICAgIHBhc3MNCj4gICB0ZXN0LWFtZDY0LWFtZDY0 LWxpYnZpcnQteHNtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFzcw0KPiAg IHRlc3QtYXJtNjQtYXJtNjQtbGlidmlydC14c20gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBibG9ja2VkDQo+ICAgdGVzdC1hbWQ2NC1pMzg2LWxpYnZpcnQteHNtICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4gICB0ZXN0LWFtZDY0LWFtZDY0 LXhsLXhzbSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFzcw0KPiAg IHRlc3QtYXJtNjQtYXJtNjQteGwteHNtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBibG9ja2VkDQo+ICAgdGVzdC1hbWQ2NC1pMzg2LXhsLXhzbSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4gICB0ZXN0LWFtZDY0LWFtZDY0 LXFlbXV1LW5lc3RlZC1hbWQgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmFpbA0KPiAg IHRlc3QtYW1kNjQtYW1kNjQteGwtcHZodjItYW1kICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1pMzg2LXFlbXV0LXJoZWw2aHZtLWFtZCAg ICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4gICB0ZXN0LWFtZDY0LWkzODYtcWVt dXUtcmhlbDZodm0tYW1kICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFzcw0KPiAgIHRl c3QtYW1kNjQtYW1kNjQtZG9tMHB2aC14bC1hbWQgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1hbWQ2NC14bC1xZW11dC1kZWJpYW5odm0tYW1k NjQgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4gICB0ZXN0LWFtZDY0LWkzODYteGwtcWVt dXQtZGViaWFuaHZtLWFtZDY0ICAgICAgICAgICAgICAgICAgICAgcGFzcw0KPiAgIHRlc3Qt YW1kNjQtYW1kNjQteGwtcWVtdXUtZGViaWFuaHZtLWFtZDY0ICAgICAgICAgICAgICAgICAg ICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1pMzg2LXhsLXFlbXV1LWRlYmlhbmh2bS1hbWQ2NCAg ICAgICAgICAgICAgICAgICAgIHBhc3MNCj4gICB0ZXN0LWFtZDY0LWkzODYtZnJlZWJzZDEw LWFtZDY0ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFzcw0KPiAgIHRlc3QtYW1k NjQtYW1kNjQtcWVtdXUtZnJlZWJzZDExLWFtZDY0ICAgICAgICAgICAgICAgICAgICAgICBw YXNzDQo+ICAgdGVzdC1hbWQ2NC1hbWQ2NC1xZW11dS1mcmVlYnNkMTItYW1kNjQgICAgICAg ICAgICAgICAgICAgICAgIHBhc3MNCj4gICB0ZXN0LWFtZDY0LWFtZDY0LXhsLXFlbXV1LW92 bWYtYW1kNjQgICAgICAgICAgICAgICAgICAgICAgICAgcGFzcw0KPiAgIHRlc3QtYW1kNjQt aTM4Ni14bC1xZW11dS1vdm1mLWFtZDY0ICAgICAgICAgICAgICAgICAgICAgICAgICBwYXNz DQo+ICAgdGVzdC1hbWQ2NC1hbWQ2NC14bC1xZW11dC13aW43LWFtZDY0ICAgICAgICAgICAg ICAgICAgICAgICAgIGZhaWwNCj4gICB0ZXN0LWFtZDY0LWkzODYteGwtcWVtdXQtd2luNy1h bWQ2NCAgICAgICAgICAgICAgICAgICAgICAgICAgZmFpbA0KPiAgIHRlc3QtYW1kNjQtYW1k NjQteGwtcWVtdXUtd2luNy1hbWQ2NCAgICAgICAgICAgICAgICAgICAgICAgICBmYWlsDQo+ ICAgdGVzdC1hbWQ2NC1pMzg2LXhsLXFlbXV1LXdpbjctYW1kNjQgICAgICAgICAgICAgICAg ICAgICAgICAgIGZhaWwNCj4gICB0ZXN0LWFtZDY0LWFtZDY0LXhsLXFlbXV0LXdzMTYtYW1k NjQgICAgICAgICAgICAgICAgICAgICAgICAgZmFpbA0KPiAgIHRlc3QtYW1kNjQtaTM4Ni14 bC1xZW11dC13czE2LWFtZDY0ICAgICAgICAgICAgICAgICAgICAgICAgICBmYWlsDQo+ICAg dGVzdC1hbWQ2NC1hbWQ2NC14bC1xZW11dS13czE2LWFtZDY0ICAgICAgICAgICAgICAgICAg ICAgICAgIGZhaWwNCj4gICB0ZXN0LWFtZDY0LWkzODYteGwtcWVtdXUtd3MxNi1hbWQ2NCAg ICAgICAgICAgICAgICAgICAgICAgICAgZmFpbA0KPiAgIHRlc3QtYXJtaGYtYXJtaGYteGwt YXJuZGFsZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVz dC1hbWQ2NC1hbWQ2NC1leGFtaW5lLWJpb3MgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHBhc3MNCj4gICB0ZXN0LWFtZDY0LWkzODYtZXhhbWluZS1iaW9zICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcGFzcw0KPiAgIHRlc3QtYW1kNjQtYW1kNjQteGwtY3Jl ZGl0MSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1h cm02NC1hcm02NC14bC1jcmVkaXQxICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGJsb2NrZWQNCj4gICB0ZXN0LWFybWhmLWFybWhmLXhsLWNyZWRpdDEgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZmFpbA0KPiAgIHRlc3QtYW1kNjQtYW1kNjQteGwtY3Jl ZGl0MiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1h cm02NC1hcm02NC14bC1jcmVkaXQyICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGJsb2NrZWQNCj4gICB0ZXN0LWFybWhmLWFybWhmLXhsLWNyZWRpdDIgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZmFpbA0KPiAgIHRlc3QtYXJtaGYtYXJtaGYteGwtY3Vi aWV0cnVjayAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1h bWQ2NC1hbWQ2NC14bC1xZW11dS1kbXJlc3RyaWN0LWFtZDY0LWRtcmVzdHJpY3QgICAgICAg IHBhc3MNCj4gICB0ZXN0LWFtZDY0LWkzODYteGwtcWVtdXUtZG1yZXN0cmljdC1hbWQ2NC1k bXJlc3RyaWN0ICAgICAgICAgcGFzcw0KPiAgIHRlc3QtYW1kNjQtYW1kNjQtZXhhbWluZSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hcm02 NC1hcm02NC1leGFtaW5lICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJs b2NrZWQNCj4gICB0ZXN0LWFybWhmLWFybWhmLWV4YW1pbmUgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgcGFzcw0KPiAgIHRlc3QtYW1kNjQtaTM4Ni1leGFtaW5lICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2 NC1pMzg2LWZyZWVic2QxMC1pMzg2ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBh c3MNCj4gICB0ZXN0LWFtZDY0LWFtZDY0LXFlbXV1LW5lc3RlZC1pbnRlbCAgICAgICAgICAg ICAgICAgICAgICAgICAgcGFzcw0KPiAgIHRlc3QtYW1kNjQtYW1kNjQteGwtcHZodjItaW50 ZWwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1p Mzg2LXFlbXV0LXJoZWw2aHZtLWludGVsICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MN Cj4gICB0ZXN0LWFtZDY0LWkzODYtcWVtdXUtcmhlbDZodm0taW50ZWwgICAgICAgICAgICAg ICAgICAgICAgICAgcGFzcw0KPiAgIHRlc3QtYW1kNjQtYW1kNjQtZG9tMHB2aC14bC1pbnRl bCAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1hbWQ2 NC1saWJ2aXJ0ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4g ICB0ZXN0LWFybWhmLWFybWhmLWxpYnZpcnQgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgcGFzcw0KPiAgIHRlc3QtYW1kNjQtaTM4Ni1saWJ2aXJ0ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1hbWQ2NC14 bC1tdWx0aXZjcHUgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4gICB0 ZXN0LWFybWhmLWFybWhmLXhsLW11bHRpdmNwdSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgZmFpbA0KPiAgIHRlc3QtYW1kNjQtYW1kNjQtcGFpciAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1pMzg2LXBhaXIg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZhaWwNCj4gICB0ZXN0 LWFtZDY0LWFtZDY0LWxpYnZpcnQtcGFpciAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgcGFzcw0KPiAgIHRlc3QtYW1kNjQtaTM4Ni1saWJ2aXJ0LXBhaXIgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1hbWQ2NC14bC1wdnNo aW0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4gICB0ZXN0LWFt ZDY0LWkzODYteGwtcHZzaGltICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZmFpbA0KPiAgIHRlc3QtYW1kNjQtYW1kNjQtcHlncnViICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hcm1oZi1hcm1oZi1saWJ2aXJ0LXFj b3cyICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZhaWwNCj4gICB0ZXN0LWFtZDY0 LWFtZDY0LXhsLXFjb3cyICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFz cw0KPiAgIHRlc3QtYXJtNjQtYXJtNjQtbGlidmlydC1yYXcgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBibG9ja2VkDQo+ICAgdGVzdC1hcm1oZi1hcm1oZi1saWJ2aXJ0LXJh dyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZhaWwNCj4gICB0ZXN0LWFtZDY0 LWkzODYtbGlidmlydC1yYXcgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFz cw0KPiAgIHRlc3QtYW1kNjQtYW1kNjQteGwtcnRkcyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hcm1oZi1hcm1oZi14bC1ydGRzICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4gICB0ZXN0LWFybTY0LWFy bTY0LXhsLXNlYXR0bGUgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYmxvY2tl ZA0KPiAgIHRlc3QtYW1kNjQtYW1kNjQteGwtcWVtdXUtZGViaWFuaHZtLWFtZDY0LXNoYWRv dyAgICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1pMzg2LXhsLXFlbXV1LWRlYmlh bmh2bS1hbWQ2NC1zaGFkb3cgICAgICAgICAgICAgIHBhc3MNCj4gICB0ZXN0LWFtZDY0LWFt ZDY0LXhsLXNoYWRvdyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFzcw0K PiAgIHRlc3QtYW1kNjQtaTM4Ni14bC1zaGFkb3cgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hcm02NC1hcm02NC14bC10aHVuZGVyeCAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJsb2NrZWQNCj4gICB0ZXN0LWFtZDY0LWFt ZDY0LWV4YW1pbmUtdWVmaSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFzcw0K PiAgIHRlc3QtYW1kNjQtaTM4Ni1leGFtaW5lLXVlZmkgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1hbWQ2NC1saWJ2aXJ0LXZoZCAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4gICB0ZXN0LWFybTY0LWFybTY0 LXhsLXZoZCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYmxvY2tlZA0K PiAgIHRlc3QtYXJtaGYtYXJtaGYteGwtdmhkICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBwYXNzDQo+ICAgdGVzdC1hbWQ2NC1pMzg2LXhsLXZoZCAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhc3MNCj4gDQo+IA0KPiAtLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4g c2ctcmVwb3J0LWZsaWdodCBvbiBvc3N0ZXN0LnRlc3QtbGFiLnhlbnByb2plY3Qub3JnDQo+ IGxvZ3M6IC9ob21lL2xvZ3MvbG9ncw0KPiBpbWFnZXM6IC9ob21lL2xvZ3MvaW1hZ2VzDQo+ IA0KPiBMb2dzLCBjb25maWcgZmlsZXMsIGV0Yy4gYXJlIGF2YWlsYWJsZSBhdA0KPiAgICAg IGh0dHA6Ly9sb2dzLnRlc3QtbGFiLnhlbnByb2plY3Qub3JnL29zc3Rlc3QvbG9ncw0KPiAN Cj4gRXhwbGFuYXRpb24gb2YgdGhlc2UgcmVwb3J0cywgYW5kIG9mIG9zc3Rlc3QgaW4gZ2Vu ZXJhbCwgaXMgYXQNCj4gICAgICBodHRwOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD1v c3N0ZXN0LmdpdDthPWJsb2I7Zj1SRUFETUUuZW1haWw7aGI9bWFzdGVyDQo+ICAgICAgaHR0 cDovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9b3NzdGVzdC5naXQ7YT1ibG9iO2Y9UkVB RE1FO2hiPW1hc3Rlcg0KPiANCj4gVGVzdCBoYXJuZXNzIGNvZGUgY2FuIGJlIGZvdW5kIGF0 DQo+ICAgICAgaHR0cDovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWI/cD1vc3N0ZXN0LmdpdDth PXN1bW1hcnkNCj4gDQo+IA0KPiBOb3QgcHVzaGluZy4NCj4gDQo+IChObyByZXZpc2lvbiBs b2c7IGl0IHdvdWxkIGJlIDIyNDQgbGluZXMgbG9uZy4pDQo+IA0KDQo= --------------aOU9Ggh5MVdVEnVpF0pRjYM3 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------aOU9Ggh5MVdVEnVpF0pRjYM3-- --------------eFIFzKaRVpvxE60l2xzC9bGO-- --------------t2ZTn26W7LsLg8DgkfgR0VaV Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNnie4FAwAAAAAACgkQsN6d1ii/Ey+2 eQf5ATGJdNMMYWArgT/bK2aHBE4Kbnf8dNJyFvqHtiLHEUghbmOv5n/bLoGkYIYkoZggOyD0NaKx NWFFmEhyc6svSESnih8FB1p6wQLJVm8TnZ4jrt/r16q63F9UihMiQ3iMJ9DjiZH9jd8DWqXxoWjc xRvIH777s6uaCSYXsZJJfuu7Xv1n3JR/I9hlexV290DVR37UJq4wDeFEuL+tZH4GsmUbs2wPTlqz kkxzE3FqZ/iGfe9RCHkchZZYahylCxIqb5BquZc5/d1RfE1UV726Sc1siikv4L1yi1eqflslIfBX lsO5YjW4D7qJat9WUUHlIdpFEEz98iMyK01s4Hkutg== =aH/v -----END PGP SIGNATURE----- --------------t2ZTn26W7LsLg8DgkfgR0VaV-- From xen-devel-bounces@lists.xenproject.org Sun Nov 06 10:30:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 10:30:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438511.692570 (Exim 4.92) (envelope-from ) id 1orcvR-00073D-7C; Sun, 06 Nov 2022 10:30:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438511.692570; Sun, 06 Nov 2022 10:30:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orcvR-000736-4S; Sun, 06 Nov 2022 10:30:49 +0000 Received: by outflank-mailman (input) for mailman id 438511; Sun, 06 Nov 2022 10:30:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orcvQ-00072w-77; Sun, 06 Nov 2022 10:30:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orcvQ-0003Ad-45; Sun, 06 Nov 2022 10:30:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orcvP-00076O-Qb; Sun, 06 Nov 2022 10:30:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orcvP-0007HT-Q7; Sun, 06 Nov 2022 10:30:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=r2Ve1R8zRN71MZuJKCg9jFiV8/veyiKb6dUnwy05Eg8=; b=ShktCNfj2VyEa7Ok9c4HEfIEss WIjDkWCwTcOInsvhfDw9CF7TDUM8XPiH0IHejYnDtawqbRbloYgWByjfBidBfENE4lsWe093iY99J s3Qfq2W8rR+seykUbnYpqaKz/2nbfBOk8VMpgb2LkP731fxX6PkH4ZAdPA3CLgXSbo9Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174643: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=7f7a09a2d25a668092be98ed5abfaeec572f5104 X-Osstest-Versions-That: libvirt=7416d19b8d8253abf74486d2f76ffeae15adecd9 From: osstest service owner Date: Sun, 06 Nov 2022 10:30:47 +0000 flight 174643 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174643/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174632 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174632 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174632 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt 7f7a09a2d25a668092be98ed5abfaeec572f5104 baseline version: libvirt 7416d19b8d8253abf74486d2f76ffeae15adecd9 Last test of basis 174632 2022-11-05 04:18:53 Z 1 days Testing same since 174643 2022-11-06 04:22:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Eric Garver jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 7416d19b8d..7f7a09a2d2 7f7a09a2d25a668092be98ed5abfaeec572f5104 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Nov 06 10:39:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 10:39:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438519.692582 (Exim 4.92) (envelope-from ) id 1ord3J-0007kp-UA; Sun, 06 Nov 2022 10:38:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438519.692582; Sun, 06 Nov 2022 10:38:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ord3J-0007ki-RO; Sun, 06 Nov 2022 10:38:57 +0000 Received: by outflank-mailman (input) for mailman id 438519; Sun, 06 Nov 2022 10:38:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ord3I-0007kY-5K; Sun, 06 Nov 2022 10:38:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ord3I-0003Jd-14; Sun, 06 Nov 2022 10:38:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ord3H-0007Fv-Fl; Sun, 06 Nov 2022 10:38:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ord3H-0006Sn-FE; Sun, 06 Nov 2022 10:38:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=V/olIoJfbvB16XFVDWw74VMkS++jvMycUDWYoUcw0Xk=; b=Zy6mdhbiKWXqFgl0GjlQGwMNOg ARaJ0DhuszLNZ1iZSiqBp4tFTa3daV+StVJ6QicdXPBlSaKMvMH1m+L28i1KQYZ5ciEpdVggOCaSW p80T7pfazeFzkp1w0CAHs2TwW7wi4ugVpesKMRL9q++ICeps3QkdC0qBg6aqwOsuewLY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174641: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=37f82facd62f720fdcec104f72f86b8c6c214820 X-Osstest-Versions-That: xen=37f82facd62f720fdcec104f72f86b8c6c214820 From: osstest service owner Date: Sun, 06 Nov 2022 10:38:55 +0000 flight 174641 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174641/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174636 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174636 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174636 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174636 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174636 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174636 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174636 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174636 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174636 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174636 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174636 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174636 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 37f82facd62f720fdcec104f72f86b8c6c214820 baseline version: xen 37f82facd62f720fdcec104f72f86b8c6c214820 Last test of basis 174641 2022-11-06 01:54:37 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Nov 06 17:48:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 17:48:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438590.692593 (Exim 4.92) (envelope-from ) id 1orjkB-0004ur-2C; Sun, 06 Nov 2022 17:47:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438590.692593; Sun, 06 Nov 2022 17:47:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orjkA-0004uk-VJ; Sun, 06 Nov 2022 17:47:38 +0000 Received: by outflank-mailman (input) for mailman id 438590; Sun, 06 Nov 2022 17:47:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orjk9-0004ua-PJ; Sun, 06 Nov 2022 17:47:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orjk9-0004if-KS; Sun, 06 Nov 2022 17:47:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orjk9-0002Dm-2k; Sun, 06 Nov 2022 17:47:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orjk9-0006Ip-2K; Sun, 06 Nov 2022 17:47:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jhJ/aN9eJFAR31J48V6lh8ZEFwaPYd1+K6/GBnxksPg=; b=XYCwIeD6gA8J/IN0ReY/d3xK3r Y6r+NwiwmwBGvx8KyNTZ4MDKEqZeifboKbrWfEE7JE8g+i3p2+02OH6aRinOTWIRPeCBLJJ8LhrBf 5nEmsdnLCgdUyr4B2NSRP3upMqEXdjhx+8AdWI1F8aV0SP2kszR7w5DqovoJRAfkWgJg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174647: all pass - PUSHED X-Osstest-Versions-This: ovmf=cc650a0378f86a4980e7a0d37fef90d46d33afe1 X-Osstest-Versions-That: ovmf=eff44c008d99eca6e3700e864b014821ba88683c From: osstest service owner Date: Sun, 06 Nov 2022 17:47:37 +0000 flight 174647 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174647/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf cc650a0378f86a4980e7a0d37fef90d46d33afe1 baseline version: ovmf eff44c008d99eca6e3700e864b014821ba88683c Last test of basis 174623 2022-11-04 12:13:19 Z 2 days Testing same since 174647 2022-11-06 15:43:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git eff44c008d..cc650a0378 cc650a0378f86a4980e7a0d37fef90d46d33afe1 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Nov 06 17:54:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 17:54:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438596.692604 (Exim 4.92) (envelope-from ) id 1orjr9-0006Up-PY; Sun, 06 Nov 2022 17:54:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438596.692604; Sun, 06 Nov 2022 17:54:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orjr9-0006Ui-Mo; Sun, 06 Nov 2022 17:54:51 +0000 Received: by outflank-mailman (input) for mailman id 438596; Sun, 06 Nov 2022 17:54:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orjr8-0006Uc-NW for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 17:54:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orjr8-0004qb-D9; Sun, 06 Nov 2022 17:54:50 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orjr8-000846-6I; Sun, 06 Nov 2022 17:54:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=JDTBkUhHbiaNuHTbxlfk7VU08JOu58XOJlcklc658ow=; b=P+4ttVEqPiogDrPWdjD8dfqWE/ xff2Ry2zSSp6w6kbZ3IrSJwkgV8Qj7Mk54X1Q4e+Cxwg7lCIyTC9q9UEGXU7bjLstUKg4n/CJeGtP TOQkGn3D8LBmGVdw3DiFLNeS9JWv5ATrr7s3aAr0Fuwj3avkWsODJnIO8og0XvCISDEw=; Message-ID: <062c9507-7744-0742-effb-76d2f1222a27@xen.org> Date: Sun, 6 Nov 2022 17:54:48 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com, Ayan Kumar Halder References: <20221104162355.23369-1-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: <20221104162355.23369-1-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, To me the title and the explaination below suggests... On 04/11/2022 16:23, Ayan Kumar Halder wrote: > From: Ayan Kumar Halder > > Refer ARM DDI 0487I.a ID081822, B2.2.1 > "Requirements for single-copy atomicity > > - A read that is generated by a load instruction that loads a single > general-purpose register and is aligned to the size of the read in the > instruction is single-copy atomic. > > -A write that is generated by a store instruction that stores a single > general-purpose register and is aligned to the size of the write in the > instruction is single-copy atomic" > > On AArch32, the alignment check is enabled at boot time by setting HSCTLR.A bit. > ("HSCTLR, Hyp System Control Register"). > However in AArch64, alignment check is not enabled at boot time. ... you want to enable the alignment check on AArch64 always. However, this is not possible to do because memcpy() is using unaligned access. I think the commit message/title should clarify that the check is *only* done during debug build. IOW, there are no enforcement in producation build. The alternative would be to use a BUG_ON() but that might be too high overhead. Cheers, > > Thus, one needs to check for alignment when performing atomic operations. > > Signed-off-by: Ayan Kumar Halder > Reviewed-by: Michal Orzel --- > > Changes from :- > v1 - 1. Referred to the latest Arm Architecture Reference Manual in the commit > message. > > xen/arch/arm/include/asm/atomic.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h > index 1f60c28b1b..64314d59b3 100644 > --- a/xen/arch/arm/include/asm/atomic.h > +++ b/xen/arch/arm/include/asm/atomic.h > @@ -78,6 +78,7 @@ static always_inline void read_atomic_size(const volatile void *p, > void *res, > unsigned int size) > { > + ASSERT(IS_ALIGNED((vaddr_t)p, size)); > switch ( size ) > { > case 1: > @@ -102,6 +103,7 @@ static always_inline void write_atomic_size(volatile void *p, > void *val, > unsigned int size) > { > + ASSERT(IS_ALIGNED((vaddr_t)p, size)); > switch ( size ) > { > case 1: -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 17:59:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 17:59:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438602.692615 (Exim 4.92) (envelope-from ) id 1orjvR-0007TK-AH; Sun, 06 Nov 2022 17:59:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438602.692615; Sun, 06 Nov 2022 17:59:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orjvR-0007TD-7B; Sun, 06 Nov 2022 17:59:17 +0000 Received: by outflank-mailman (input) for mailman id 438602; Sun, 06 Nov 2022 17:59:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orjvQ-0007T7-3A for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 17:59:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orjvP-0004vm-9N; Sun, 06 Nov 2022 17:59:15 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orjvP-0008Gd-4A; Sun, 06 Nov 2022 17:59:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=tGh41GQgcc9yOm1RfvIM0/hGRxq3kMn+34p7V0eU9SM=; b=bLcAqnZfWX6Qe/k/n3UyuOtXK1 yyiX0ZBaoZK7nYnXiIG29G8BPmTiTKPpiwS/OsF+VJga4NkKQ5zTm3S+CRDQvw75cGDYjBKMXvmsl 9yUrTmwjPQbFhqiobKjBYaku4QTq1aIeQe+b6Mve9TmKZxKqxESte2y84VvMdPUJNF00=; Message-ID: <4aa5f449-a656-8df2-7bdd-c2dcf166c8b2@xen.org> Date: Sun, 6 Nov 2022 17:59:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 02/12] xen/Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32 To: Xenia Ragiadakou , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-3-ayankuma@amd.com> <8e36fec2-6df5-835c-f75a-f530c1a678e3@gmail.com> <9c4ca761-6ef4-d0e9-f496-27e0acaba95c@xen.org> <2cf591c5-df8c-d231-8862-e5c00b9a3698@gmail.com> From: Julien Grall In-Reply-To: <2cf591c5-df8c-d231-8862-e5c00b9a3698@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Xenia, On 02/11/2022 10:36, Xenia Ragiadakou wrote: > Hi Julien, > > On 11/2/22 12:10, Julien Grall wrote: >> Hi Xenia, >> >> On 02/11/2022 09:57, Xenia Ragiadakou wrote: >>> >>> On 11/2/22 10:46, Julien Grall wrote: >>>> Hi, >>>> >>>> Title: The macros you are moving are not GICv3 specific. >>>> >>>> On 31/10/2022 15:13, Ayan Kumar Halder wrote: >>>>> Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm64/ \ >>>>> include/asm/cputype.h#L14 , for the macros specific for arm64. >>>>> >>>>> Refer >>>>> https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm/include/ \ >>>>> asm/cputype.h#L54  , for the macros specific for arm32. >>>>> >>>>> MPIDR_LEVEL_SHIFT() differs between 64 and 32 bit. > For 64 bit :- >>>>> >>>>>   aff_lev3          aff_lev2 aff_lev1 aff_lev0 >>>>> |________|________|________|________|________| >>>>> 40       32       24       16       8        0 >>>>> >>>>> For 32 bit :- >>>>> >>>>>   aff_lev3 aff_lev2 aff_lev1 aff_lev0 >>>>> |________|________|________|________| >>>>> 32       24       16       8        0 >>>> >>>> As discussed with Michal, AFF3 doesn't exist for 32-bit. So it is >>>> not clear to me what we are gaining by moving the macros. >>>> >>> >>> I cannot understand what do you mean by "what we are gaining by >>> moving the macros". >>  > >>> IIUC, when identifying the cpu topology, a mask is applied to the >>> value of MPIDR_EL1 >>> #ifdef CONFIG_ARM_64 >>> #define MPIDR_HWID_MASK     _AC(0xff00ffffff,UL) >>> #else >>> #define MPIDR_HWID_MASK     _AC(0xffffff,U) >>> #endif >>> So, for arm32, the affinity at level 3 is considered to be 0. >>> >>> Do you mean, what we are gaining by defining the MPIDR_LEVEL_SHIFT in >>> a different way for arm32 and for arm64? >> >> Yes. There are nothing justifying the move so far. >> >>> >>> IMO, we need to do so, because the shift, used to retrieve the >>> affinity at each level, cannot be calculated using the same logic i.e >>> (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT) >>> >>> For arm32 the affinity at each level is calculated as follows >>> ((level) << MPIDR_LEVEL_BITS_SHIFT) >> >> I understand they are written differently. But if you look at the >> layout, AFF0, AFF1, AFF2 are in the same position. AFF3 doesn't exist >> for arm32 and, AFAICT, the shift will not matter because the bits >> 40:32 will be zeroed in any case. >> >> So I don't see the problem of using the arm64 version. > > Now I see :) ... IIUC you are proposing to just cast the mpidr in > MPIDR_AFFINITY_LEVEL(mpidr, level) to uint64_t? Not necessarilly. The other approach is to make sure that no arm32 code is calling AFFINITY_MASK() with a level >= 3 (see vpsci.c for instance). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 18:04:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 18:04:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438606.692626 (Exim 4.92) (envelope-from ) id 1ork0F-0000WY-Rb; Sun, 06 Nov 2022 18:04:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438606.692626; Sun, 06 Nov 2022 18:04:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ork0F-0000WR-Of; Sun, 06 Nov 2022 18:04:15 +0000 Received: by outflank-mailman (input) for mailman id 438606; Sun, 06 Nov 2022 18:04:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ork0E-0000WL-DA for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 18:04:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ork0D-00057A-VU; Sun, 06 Nov 2022 18:04:13 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ork0D-00007h-Pb; Sun, 06 Nov 2022 18:04:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ZiValLaWIOsdSp3F3gilONenW9lOAkkl5fbQrp6lERk=; b=w0Jjl/zi5EQ8x8DXzdw0GOio1J n6AKfKgYWGYEVqIJlWHJa2qkLnP+lFr1YT2PWwTPrcgeKodDYyBuGMzlS5WvRig4VuMwyF7gIlPca xvqsi47JEag6dkSKE7yYhN7lzhD4Fv6w0ZilkwNfhximG1EnukJ76B4cek4hqYhnbW9A=; Message-ID: <5d369b95-f412-67b2-5c34-3cd317128ec3@xen.org> Date: Sun, 6 Nov 2022 18:04:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32 To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-5-ayankuma@amd.com> From: Julien Grall In-Reply-To: <20221031151326.22634-5-ayankuma@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, In the title you are using AArch32 but below you are using... On 31/10/2022 15:13, Ayan Kumar Halder wrote: > v->arch.vmpidr is assigned to uint64_t variable. This is to enable left shifts > for Aarch32 so that one can extract affinity bits. ... Aarch32. The naming also seem to be inconsistent across your series. AFAIU, it should be AArch32. So please look at all your commits and make sure you use the same everywhere. > This is then assigned to 'typer' so that the affinity bits form the upper 32 bits. > > Refer Arm IHI 0069H ID020922, > The upper 32 bits of GICR_TYPER represent the affinity > whereas the lower 32 bits represent the other bits (eg processor > number, etc). > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from :- > 1. v1 - Assigned v->arch.vmpidr to "uint64_t vmpdir". Then, we can use > MPIDR_AFFINITY_LEVEL macros to extract the affinity value. > > xen/arch/arm/vgic-v3.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c > index 3f4509dcd3..e5e6f2c573 100644 > --- a/xen/arch/arm/vgic-v3.c > +++ b/xen/arch/arm/vgic-v3.c > @@ -191,13 +191,15 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info, > case VREG64(GICR_TYPER): > { > uint64_t typer, aff; > + uint64_t vmpidr = v->arch.vmpidr; > > if ( !vgic_reg64_check_access(dabt) ) goto bad_width; > - aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 | > - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 | > - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 | > - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32); > + aff = (MPIDR_AFFINITY_LEVEL(vmpidr, 3) << 56 | Shouldn't we #ifdef this level for 32-bit? Or maybe check if the domain is 64-bit so we are using consistently regardless of the hypervisor bitness. > + MPIDR_AFFINITY_LEVEL(vmpidr, 2) << 48 | > + MPIDR_AFFINITY_LEVEL(vmpidr, 1) << 40 | > + MPIDR_AFFINITY_LEVEL(vmpidr, 0) << 32); > typer = aff; > + Spurious change? > /* We use the VCPU ID as the redistributor ID in bits[23:8] */ > typer |= v->vcpu_id << GICR_TYPER_PROC_NUM_SHIFT; > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 18:05:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 18:05:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438611.692636 (Exim 4.92) (envelope-from ) id 1ork1U-0001CX-5x; Sun, 06 Nov 2022 18:05:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438611.692636; Sun, 06 Nov 2022 18:05:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ork1U-0001CQ-3A; Sun, 06 Nov 2022 18:05:32 +0000 Received: by outflank-mailman (input) for mailman id 438611; Sun, 06 Nov 2022 18:05:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ork1T-0001CI-55 for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 18:05:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ork1S-00058L-Qc; Sun, 06 Nov 2022 18:05:30 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ork1S-0000CN-L5; Sun, 06 Nov 2022 18:05:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=FTC3bQg5ClioQf3Sakq8tNKDV2hNC4Z07OOI9dhHZGE=; b=AQi+xSMDLYm8cjcvJg0j10wig/ QgQbPws7/nwq47NxnEopLplyXuV6nCDti4nmEsmAusrRbNJg8G6iG+9h6XtvNLi85tWhOwURLNhCX PgvMuaCL2tcDWjarnSxQM7tEd6/FL6bZst53quBlt8Ht9udVNRz/mC1EtGo/o8oKrlNw=; Message-ID: <939fa481-b415-7b44-c81c-745ffea1a7a5@xen.org> Date: Sun, 6 Nov 2022 18:05:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 05/12] xen/Arm: GICv3: Fix GICR_{PENDBASER, PROPBASER} emulation on 32-bit host To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-6-ayankuma@amd.com> From: Julien Grall In-Reply-To: <20221031151326.22634-6-ayankuma@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 31/10/2022 15:13, Ayan Kumar Halder wrote: > 'unsigned long long' is defined as 64 bit across both aarch32 and aarch64. > So, use 'ULL' for 64 bit word instead of UL which is 32 bits for aarch32. > GICR_PENDBASER and GICR_PROPBASER both are 64 bit registers. > > Signed-off-by: Ayan Kumar Halder With or without Michal's comment addressed: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 18:06:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 18:06:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438615.692647 (Exim 4.92) (envelope-from ) id 1ork2F-0001lL-E3; Sun, 06 Nov 2022 18:06:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438615.692647; Sun, 06 Nov 2022 18:06:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ork2F-0001lE-BG; Sun, 06 Nov 2022 18:06:19 +0000 Received: by outflank-mailman (input) for mailman id 438615; Sun, 06 Nov 2022 18:06:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ork2E-0001l2-0E for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 18:06:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ork2D-00059E-Ll; Sun, 06 Nov 2022 18:06:17 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ork2D-0000F4-Fr; Sun, 06 Nov 2022 18:06:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=lQwMZSmmrAxYBDoi9ykyFwS3TPPWUboE4oCUWzi1Bfc=; b=23cJfuLI3zou4jAowhU5lBS3JO VV8Fh+3vsetNtn8x/mNmL4ph5Dwbhd9HKAICCcJKLaIm/Ym+LmncFCLTzwCjJXt3Lvo0+E5RgvVJz WfiEwVNfw5kSLE4OQShDZ4ztzjX16EGOblO0//VGbXCoqWpDuxnf38kVwkB2WpWdMtjQ=; Message-ID: Date: Sun, 6 Nov 2022 18:06:15 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 06/12] xen/Arm: vGICv3: Fix emulation of ICC_SGI1R on AArch32 To: Michal Orzel , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-7-ayankuma@amd.com> <2cd6324e-71eb-f489-15ac-8c7438e03b0a@amd.com> From: Julien Grall In-Reply-To: <2cd6324e-71eb-f489-15ac-8c7438e03b0a@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/11/2022 10:41, Michal Orzel wrote: > Hi Ayan, > > On 31/10/2022 16:13, Ayan Kumar Halder wrote: >> >> >> Refer Arm IHI 0069H ID020922, 12.5.23, ICC_SGI1R is a 64 bit register on >> Aarch32 systems. Thus, the prototype needs to change to reflect this. > NIT: prototype means function declaration. > vgic_v3_to_sgi is a function that has no prototype. > > Apart from that: > Reviewed-by: Michal Orzel Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 18:14:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 18:14:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438623.692659 (Exim 4.92) (envelope-from ) id 1orkAL-0003Uc-8b; Sun, 06 Nov 2022 18:14:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438623.692659; Sun, 06 Nov 2022 18:14:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkAL-0003UV-5d; Sun, 06 Nov 2022 18:14:41 +0000 Received: by outflank-mailman (input) for mailman id 438623; Sun, 06 Nov 2022 18:14:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkAJ-0003UP-OD for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 18:14:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkAJ-0005IT-AW; Sun, 06 Nov 2022 18:14:39 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orkAJ-0000dm-4G; Sun, 06 Nov 2022 18:14:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=vXB6P//IrY6uAe6oNOdecrWhugkfQCUhKurgJ9wFONw=; b=MoeUs555gueiPKhkEjBkkevWYm hz+x+t8evQjRoy0OGUQ0ubATeRXlGZEgE9mgZhBj8m4veJXzuSWl67yPFKU/pXgstrFIYLYGykOOl Q3Tg/aT+G/BVMso5EO/9/rE6UMukC+C354sD+BWoWQdJ9esMsA22lgYmf6wm8IMlqp0o=; Message-ID: <8fb32543-ba4d-44aa-b99d-759c6834ca3f@xen.org> Date: Sun, 6 Nov 2022 18:14:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 07/12] xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32 To: Michal Orzel , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-8-ayankuma@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 03/11/2022 12:13, Michal Orzel wrote: > Hi Ayan, > > On 31/10/2022 16:13, Ayan Kumar Halder wrote: >> >> >> Refer "Arm IHI 0069H ID020922", 12.4.6, Interrupt Controller List Registers >> >> AArch64 System register ICH_LR_EL2 bits [31:0] are architecturally >> mapped to AArch32 System register ICH_LR[31:0]. >> AArch64 System register ICH_LR_EL2 bits [63:32] are architecturally >> mapped to AArch32 System register ICH_LRC[31:0]. >> >> Defined ICH_LR<0...15>_EL2 and ICH_LRC<0...15>_EL2 for Aarch32. >> For AArch32, the link register is stored as :- >> (((uint64_t) ICH_LRC<0...15>_EL2) << 32) | ICH_LR<0...15>_EL2 >> >> Also, ICR_LR macros need to be modified as ULL is 64 bits for AArch32 and >> AArch64. >> >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changes from :- >> v1 - 1. Moved the coproc register definitions to asm/cpregs.h. >> 2. Use GENMASK(31, 0) to represent 0xFFFFFFFF >> 3. Use READ_CP32()/WRITE_CP32() instead of READ_SYSREG()/WRITE_SYSREG(). >> 4. Multi-line macro definitions should be enclosed within ({ }). >> >> xen/arch/arm/gic-v3.c | 132 +++++++++++------------ >> xen/arch/arm/include/asm/arm32/sysregs.h | 17 +++ >> xen/arch/arm/include/asm/arm64/sysregs.h | 3 + >> xen/arch/arm/include/asm/cpregs.h | 42 ++++++++ >> xen/arch/arm/include/asm/gic_v3_defs.h | 6 +- >> 5 files changed, 131 insertions(+), 69 deletions(-) >> >> diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h >> index 6841d5de43..8a9a014bef 100644 >> --- a/xen/arch/arm/include/asm/arm32/sysregs.h >> +++ b/xen/arch/arm/include/asm/arm32/sysregs.h >> @@ -62,6 +62,23 @@ >> #define READ_SYSREG(R...) READ_SYSREG32(R) >> #define WRITE_SYSREG(V, R...) WRITE_SYSREG32(V, R) >> >> +#define ICH_LR_REG(INDEX) ICH_LR ## INDEX ## _EL2 >> +#define ICH_LRC_REG(INDEX) ICH_LRC ## INDEX ## _EL2 > You could align to WRITE_SYSREG32(V, R). > > Apart from that it would be good to add some comment before the code you added (ICH_LR_REG) > to separate from the code above and its comment about registers coming in 3 types. > Something like: > /* Wrappers for accessing interrupt controller list registers. */ > >> + >> +#define READ_SYSREG_LR(INDEX) ({ \ > Opening ({ should be placed one space after READ_SYSREG_LR(INDEX). It does not need to be aligned. > >> + uint64_t _val; \ > val is not really necessary. You could directly return the ((uint64_t) _lrc << 32) | _lr; > Just something to consider, no need to replace. > >> + uint32_t _lrc = READ_CP32(ICH_LRC_REG(INDEX)); \ >> + uint32_t _lr = READ_CP32(ICH_LR_REG(INDEX)); \ >> + \ >> + _val = ((uint64_t) _lrc << 32) | _lr; \ >> + _val; }) > Here, you did put }) at the same line... > >> + >> +#define WRITE_SYSREG_LR(INDEX, V) ({ \ >> + uint64_t _val = (V); \ >> + WRITE_CP32(_val & GENMASK(31, 0), ICH_LR_REG(INDEX)); \ >> + WRITE_CP32(_val >> 32, ICH_LRC_REG(INDEX)); \ > Please, align \ +1 > >> +}); > ... and here you did not. FAOD, this is the correct approach. That said, the ';' should not be added. > >> + >> /* MVFR2 is not defined on ARMv7 */ >> #define MVFR2_MAYBE_UNDEFINED >> >> diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h >> index 54670084c3..353f0eea29 100644 >> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >> @@ -471,6 +471,9 @@ >> >> #define READ_SYSREG(name) READ_SYSREG64(name) >> #define WRITE_SYSREG(v, name) WRITE_SYSREG64(v, name) > Here, I would separate the below macros by adding the comment similar to the one I showed above. > Or at least add a blank line. > >> +#define ICH_LR_REG(index) ICH_LR ## index ## _EL2 >> +#define WRITE_SYSREG_LR(index, v) WRITE_SYSREG(v, ICH_LR_REG(index)) >> +#define READ_SYSREG_LR(index) READ_SYSREG(ICH_LR_REG(index)) > I find it a bit odd that the macro param 'index' is written in lower case and for arm32 in upper cas FWIW, I would prefer the lower case version. That said, the arm32 code match with the rest of the file. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 18:20:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 18:20:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438632.692670 (Exim 4.92) (envelope-from ) id 1orkFT-0004Xq-0R; Sun, 06 Nov 2022 18:19:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438632.692670; Sun, 06 Nov 2022 18:19:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkFS-0004Xj-Sk; Sun, 06 Nov 2022 18:19:58 +0000 Received: by outflank-mailman (input) for mailman id 438632; Sun, 06 Nov 2022 18:19:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkFR-0004Xd-8C for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 18:19:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkFQ-0005Y9-S4; Sun, 06 Nov 2022 18:19:56 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orkFQ-0000iG-Ld; Sun, 06 Nov 2022 18:19:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=6OHnUGUKM00eLzFajU4H9xE6DmXyE/8beR2b4D1sX5E=; b=tpO8mZif2cyqgQJljyz8J0hFRY PGwsLAmBtdvdG2IYCsDXTTlBJKFsJNN0MmsECAZFX23ScPyr4cisQNMEYP8kXuEhDJw0b/L8CjN4V +7ZB3Dar86hs6VGMrzX7crqzeEUOr06EYaemTmwXRSb58CfHEPfeKc+7ubxZ1iPOBODA=; Message-ID: <4bb65932-c16e-9970-8ab8-a685aef26051@xen.org> Date: Sun, 6 Nov 2022 18:19:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-8-ayankuma@amd.com> From: Julien Grall Subject: Re: [XEN v2 07/12] xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32 In-Reply-To: <20221031151326.22634-8-ayankuma@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 31/10/2022 15:13, Ayan Kumar Halder wrote: > diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h > index 6841d5de43..8a9a014bef 100644 > --- a/xen/arch/arm/include/asm/arm32/sysregs.h > +++ b/xen/arch/arm/include/asm/arm32/sysregs.h > @@ -62,6 +62,23 @@ > #define READ_SYSREG(R...) READ_SYSREG32(R) > #define WRITE_SYSREG(V, R...) WRITE_SYSREG32(V, R) > > +#define ICH_LR_REG(INDEX) ICH_LR ## INDEX ## _EL2 > +#define ICH_LRC_REG(INDEX) ICH_LRC ## INDEX ## _EL2 > + > +#define READ_SYSREG_LR(INDEX) ({ \ > + uint64_t _val; \ > + uint32_t _lrc = READ_CP32(ICH_LRC_REG(INDEX)); \ > + uint32_t _lr = READ_CP32(ICH_LR_REG(INDEX)); \ > + \ > + _val = ((uint64_t) _lrc << 32) | _lr; \ > + _val; }) > + > +#define WRITE_SYSREG_LR(INDEX, V) ({ \ I would prefer if the prototype stays consistent with the other write helpers. I.e. the value is first and the name second. > + uint64_t _val = (V); \ > + WRITE_CP32(_val & GENMASK(31, 0), ICH_LR_REG(INDEX)); \ > + WRITE_CP32(_val >> 32, ICH_LRC_REG(INDEX)); \ > +}); > + > /* MVFR2 is not defined on ARMv7 */ > #define MVFR2_MAYBE_UNDEFINED > > diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h > index 54670084c3..353f0eea29 100644 > --- a/xen/arch/arm/include/asm/arm64/sysregs.h > +++ b/xen/arch/arm/include/asm/arm64/sysregs.h > @@ -471,6 +471,9 @@ > > #define READ_SYSREG(name) READ_SYSREG64(name) > #define WRITE_SYSREG(v, name) WRITE_SYSREG64(v, name) > +#define ICH_LR_REG(index) ICH_LR ## index ## _EL2 > +#define WRITE_SYSREG_LR(index, v) WRITE_SYSREG(v, ICH_LR_REG(index)) > +#define READ_SYSREG_LR(index) READ_SYSREG(ICH_LR_REG(index)) > > #endif /* _ASM_ARM_ARM64_SYSREGS_H */ > > diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h > index 6daf2b1a30..4421dd49ac 100644 > --- a/xen/arch/arm/include/asm/cpregs.h > +++ b/xen/arch/arm/include/asm/cpregs.h > @@ -362,6 +362,48 @@ > #define MVFR0_EL1 MVFR0 > #define MVFR1_EL1 MVFR1 > #define MVFR2_EL1 MVFR2 > + > +#define ___CP32(a,b,c,d,e) a,b,c,d,e Unless there are a reason to do, please use space after each comma. The same goes for the rest of the patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 18:20:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 18:20:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438636.692680 (Exim 4.92) (envelope-from ) id 1orkGN-0005sc-7v; Sun, 06 Nov 2022 18:20:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438636.692680; Sun, 06 Nov 2022 18:20:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkGN-0005sV-5B; Sun, 06 Nov 2022 18:20:55 +0000 Received: by outflank-mailman (input) for mailman id 438636; Sun, 06 Nov 2022 18:20:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkGM-0005sI-3E for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 18:20:54 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkGL-0005Yk-M8; Sun, 06 Nov 2022 18:20:53 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orkGL-0000jw-GH; Sun, 06 Nov 2022 18:20:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=CASCy4BhQ/unKHff5JKokd9r8+b6dFu5u+xsUWnyPes=; b=omsk/BR7VtiUyPOHEWYn+4X9s1 A3mQ69sp3Yvgik2WsktXuWOFKN3DpvZrXcoQSaQnC8LFxbxMbzo8y+FQmiGtkA5EvkEvEcAmT81m3 LPh+PlVUjaW6LrgyIGqojEXblmudDwYjefDYYdzOWpWTvUj8DYxmpc+8vzgDbxRe5ZfI=; Message-ID: <64785048-502f-ac1f-e3c3-cfc133b2e0b6@xen.org> Date: Sun, 6 Nov 2022 18:20:51 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 08/12] xen/Arm: GICv3: Define ICH_AP0R and ICH_AP1R for AArch32 To: Michal Orzel , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-9-ayankuma@amd.com> <64dbd0a2-3629-ff88-0b23-0fc8b087ada2@amd.com> From: Julien Grall In-Reply-To: <64dbd0a2-3629-ff88-0b23-0fc8b087ada2@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/11/2022 12:35, Michal Orzel wrote: > Hi Ayan, > > On 31/10/2022 16:13, Ayan Kumar Halder wrote: >> >> >> Refer "Arm IHI 0069H ID020922", >> 12.7.1 - Interrupt Controller Hyp Active Priorities Group0 Registers 0-3 >> 12.7.2 - Interrupt Controller Hyp Active Priorities Group1 Registers 0-3 >> > Commit msg like this is not really beneficial as it requires someone to have > this spec and only tells that such registers exist on AArch32. It is missing some > information e.g. what is the purpose of defining them. +1 > >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changes from :- >> v1 - 1. Moved coproc register definition to asm/cpregs.h. >> >> xen/arch/arm/include/asm/arm32/sysregs.h | 1 - >> xen/arch/arm/include/asm/cpregs.h | 11 +++++++++++ >> 2 files changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h >> index 8a9a014bef..1b2915a526 100644 >> --- a/xen/arch/arm/include/asm/arm32/sysregs.h >> +++ b/xen/arch/arm/include/asm/arm32/sysregs.h >> @@ -81,7 +81,6 @@ >> >> /* MVFR2 is not defined on ARMv7 */ >> #define MVFR2_MAYBE_UNDEFINED >> - Spurious change. >> #endif /* __ASSEMBLY__ */ >> >> #endif /* __ASM_ARM_ARM32_SYSREGS_H */ >> diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h >> index 4421dd49ac..bfabee0bc3 100644 >> --- a/xen/arch/arm/include/asm/cpregs.h >> +++ b/xen/arch/arm/include/asm/cpregs.h >> @@ -404,6 +404,17 @@ >> #define ICH_LRC14_EL2 __LRC8_EL2(6) >> #define ICH_LRC15_EL2 __LRC8_EL2(7) >> >> +#define __AP0Rx_EL2(x) ___CP32(p15,4,c12,c8,x) >> +#define ICH_AP0R0_EL2 __AP0Rx_EL2(0) >> +#define ICH_AP0R1_EL2 __AP0Rx_EL2(1) >> +#define ICH_AP0R2_EL2 __AP0Rx_EL2(2) >> +#define ICH_AP0R3_EL2 __AP0Rx_EL2(3) >> + >> +#define __AP1Rx_EL2(x) ___CP32(p15,4,c12,c9,x) >> +#define ICH_AP1R0_EL2 __AP1Rx_EL2(0) >> +#define ICH_AP1R1_EL2 __AP1Rx_EL2(1) >> +#define ICH_AP1R2_EL2 __AP1Rx_EL2(2) >> +#define ICH_AP1R3_EL2 __AP1Rx_EL2(3) > This might need to be re-aligned after you fix patch no. 7. > Then, you can add: > Reviewed-by: Michal Orzel Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 18:26:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 18:26:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438642.692692 (Exim 4.92) (envelope-from ) id 1orkLo-0006vV-S4; Sun, 06 Nov 2022 18:26:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438642.692692; Sun, 06 Nov 2022 18:26:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkLo-0006vO-P8; Sun, 06 Nov 2022 18:26:32 +0000 Received: by outflank-mailman (input) for mailman id 438642; Sun, 06 Nov 2022 18:26:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkLn-0006vH-AV for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 18:26:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkLm-0005ez-QB; Sun, 06 Nov 2022 18:26:30 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orkLm-0000xS-Jh; Sun, 06 Nov 2022 18:26:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=vskquFxYEDCKLkfhz08IoYmcVluLR5iK/Wdrn25zm1E=; b=ZDh3q5XTESgM+oajijDaYgLW7A y4FKrvPUmrvgVkyX49KFbQS07a+8+QQ8jjBsKB0YDLAjZ1RlnS1AfmNQJy+YUED13JJmWw1jUPWDM CTzHmdwZWini5HEXllWJvtl59MWHeLAZxzwouwcZhfnSpDIfDiRNGNMjOchZXdK0b6rY=; Message-ID: Date: Sun, 6 Nov 2022 18:26:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 09/12] xen/Arm: GICv3: Define GIC registers for AArch32 To: Michal Orzel , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-10-ayankuma@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/11/2022 15:08, Michal Orzel wrote: > Hi Ayan, > > On 31/10/2022 16:13, Ayan Kumar Halder wrote: >> > The title is a bit ambiguous given that the previous patches were also defining GIC registers. > Maybe adding "remaining" would result in a better commit title. > >> >> Refer "Arm IHI 0069H ID020922" >> 12.5.23 ICC_SGI1R, Interrupt Controller Software Generated Interrupt >> Group 1 Register >> 12.5.12 ICC_HSRE, Interrupt Controller Hyp System Register Enable register >> 12.7.10 ICH_VTR, Interrupt Controller VGIC Type Register >> 12.7.5 ICH_HCR, Interrupt Controller Hyp Control Register >> 12.5.20 ICC_PMR, Interrupt Controller Interrupt Priority Mask Register >> 12.5.24 ICC_SRE, Interrupt Controller System Register Enable register >> 12.5.7 ICC_DIR, Interrupt Controller Deactivate Interrupt Register >> 12.5.9 ICC_EOIR1, Interrupt Controller End Of Interrupt Register 1 >> 12.5.14 ICC_IAR1, Interrupt Controller Interrupt Acknowledge Register 1 >> 12.5.5 ICC_BPR1, Interrupt Controller Binary Point Register 1 >> 12.5.6 ICC_CTLR, Interrupt Controller Control Register >> 12.5.16 ICC_IGRPEN1, Interrupt Controller Interrupt Group 1 Enable register >> 12.7.9 ICH_VMCR, Interrupt Controller Virtual Machine Control Register >> > As said in the previous patches: this may be my personal opinion but sth like this would be easier to read: > " > Define missing assembly aliases for GIC registers on arm32, taking the ones > defined already for arm64 as a base. Aliases are defined according to the > GIC Architecture Specification ARM IHI 0069H. > " +1 with one remark. I think listing the registers added in the commit message (no need for the section) is fine. >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changes from :- >> v1 - 1. Moved coproc regs definition to asm/cpregs.h >> >> xen/arch/arm/include/asm/cpregs.h | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h >> index bfabee0bc3..62b63f4cef 100644 >> --- a/xen/arch/arm/include/asm/cpregs.h >> +++ b/xen/arch/arm/include/asm/cpregs.h >> @@ -415,6 +415,22 @@ >> #define ICH_AP1R1_EL2 __AP1Rx_EL2(1) >> #define ICH_AP1R2_EL2 __AP1Rx_EL2(2) >> #define ICH_AP1R3_EL2 __AP1Rx_EL2(3) >> + >> +#define ICC_SGI1R_EL1 p15,0,c12 >> + >> +#define ICC_SRE_EL2 p15,4,c12,c9,5 >> +#define ICH_VTR_EL2 p15,4,c12,c11,1 >> +#define ICH_HCR_EL2 p15,4,c12,c11,0 >> + >> +#define ICC_PMR_EL1 p15,0,c4,c6,0 >> +#define ICC_SRE_EL1 p15,0,c12,c12,5 >> +#define ICC_DIR_EL1 p15,0,c12,c11,1 >> +#define ICC_EOIR1_EL1 p15,0,c12,c12,1 >> +#define ICC_IAR1_EL1 p15,0,c12,c12,0 >> +#define ICC_BPR1_EL1 p15,0,c12,c12,3 >> +#define ICC_CTLR_EL1 p15,0,c12,c12,4 >> +#define ICC_IGRPEN1_EL1 p15,0,c12,c12,7 >> +#define ICH_VMCR_EL2 p15,4,c12,c11,7 > I did not check this in previous patches but in which order are you defining these registers? > I took a look at arm64/sysregs.h and these regs are placed in assembly aliases name order. > So for instance ICC_PMR_EL1 would be defined before ICC_SRE_EL2, etc. Per the comment in the header, they should be ordered as followed: Coprocessor-> CRn-> Opcode 1-> CRm-> Opcode 2 Also, we first define the arm32 name and *then* define an alias for common code. These remarks applies for the full series. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 18:31:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 18:31:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438647.692703 (Exim 4.92) (envelope-from ) id 1orkQA-0008K1-Dw; Sun, 06 Nov 2022 18:31:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438647.692703; Sun, 06 Nov 2022 18:31:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkQA-0008Ju-AV; Sun, 06 Nov 2022 18:31:02 +0000 Received: by outflank-mailman (input) for mailman id 438647; Sun, 06 Nov 2022 18:31:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkQ9-0008Jk-5H; Sun, 06 Nov 2022 18:31:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkQ9-0005k1-0h; Sun, 06 Nov 2022 18:31:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkQ8-0003A8-9H; Sun, 06 Nov 2022 18:31:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orkQ8-0000Uq-8n; Sun, 06 Nov 2022 18:31:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xVSm3WOqLcVrCl+wxF9JaCu9epyyP0xIqf5DjWIFao0=; b=SyxDTX9BK3d9HoofpjVGWx4rSZ o09dg5A/6klg25xLVNa9+mh+HVuvDQOyIcOU1TdwJzpBJv+dpqQ1Il07O3M85ZFPVrkJTiNFt3WwM w6pCXjz2LrZQB0Mr8dUOkQakqUlHy0+X4t127G0cUWExbxf8jto7eHLbLPSYLEInEisg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174645: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=2f5065a0bc9d0afb45f2ae284bd525d55ce82c33 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sun, 06 Nov 2022 18:31:00 +0000 flight 174645 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174645/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 2f5065a0bc9d0afb45f2ae284bd525d55ce82c33 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 29 days Failing since 173470 2022-10-08 06:21:34 Z 29 days 46 attempts Testing same since 174639 2022-11-05 22:12:42 Z 0 days 2 attempts ------------------------------------------------------------ 1584 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 150603 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 06 18:31:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 18:31:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438654.692713 (Exim 4.92) (envelope-from ) id 1orkQr-0000Tw-Rl; Sun, 06 Nov 2022 18:31:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438654.692713; Sun, 06 Nov 2022 18:31:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkQr-0000Tp-Oy; Sun, 06 Nov 2022 18:31:45 +0000 Received: by outflank-mailman (input) for mailman id 438654; Sun, 06 Nov 2022 18:31:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkQq-0000Tf-QO for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 18:31:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkQq-0005kZ-Dm; Sun, 06 Nov 2022 18:31:44 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orkQq-00012W-6b; Sun, 06 Nov 2022 18:31:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=kjlQIYLPKFvgq01FsQRgFN1JRg4kQpjKU+vDEsPXWik=; b=Y4Izfe7KYpdF/C6LKHr2Xj9i4h lu11Bg0MMo6oeS9avqiDudhwh7Ki1yKvBb2vN3LVgwF7nfr9lmWXmxARaagd42cRiii7f4ekJ2kJG aS6/fp1oCLCLi6nvEEUWNFXNkTbvjMJlKEVqci8Rii9te4XyPAyaDCAccNlEBUNc3odQ=; Message-ID: <1c016830-59d9-0d3c-331f-1874c41bae40@xen.org> Date: Sun, 6 Nov 2022 18:31:42 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 09/12] xen/Arm: GICv3: Define GIC registers for AArch32 To: Ayan Kumar Halder , Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-10-ayankuma@amd.com> <825bf5e3-1d74-3fc1-370d-71a09d0e0ccc@amd.com> From: Julien Grall In-Reply-To: <825bf5e3-1d74-3fc1-370d-71a09d0e0ccc@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 04/11/2022 10:04, Ayan Kumar Halder wrote: > These registers are not used by Xen. > Should I define these registers for the sake of completeness (to be in > parity with AArch64) ? Yes. I would at least expect the MISR might end up to be used if we were supporting some interrupts controlled (e.g. the Apple Interrupt Controller). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 18:39:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 18:39:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438660.692725 (Exim 4.92) (envelope-from ) id 1orkYE-0001Xe-JF; Sun, 06 Nov 2022 18:39:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438660.692725; Sun, 06 Nov 2022 18:39:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkYE-0001XX-Fl; Sun, 06 Nov 2022 18:39:22 +0000 Received: by outflank-mailman (input) for mailman id 438660; Sun, 06 Nov 2022 18:39:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkYC-0001XR-Kp for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 18:39:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkYC-0005th-6B; Sun, 06 Nov 2022 18:39:20 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orkYB-0001bx-Vi; Sun, 06 Nov 2022 18:39:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=0mxbgWIAniKxmsThdt6OWxpJce11XvY+K2v2HJcCBH0=; b=NStZLIikDnFX1bG4NMKwTuPzFK tbD6PSUIGJ3OTY9cwNYCTj25z+e+afAtQX9GsoMEeGJcuqThhExZX+GJbvMZweBIF1/lr4lQ+3GLZ v8jTJ5zikPkTGzwybzEi9EuGdUI65ZNFgrk/ZBXQIhivM9J/oJpbnU1X89DbkFKYh/LI=; Message-ID: <231f67e1-5524-c698-aa53-7c90e0fe0f43@xen.org> Date: Sun, 6 Nov 2022 18:39:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-13-ayankuma@amd.com> From: Julien Grall Subject: Re: [XEN v2 12/12] xen/Arm: GICv3: Enable GICv3 for AArch32 In-Reply-To: <20221031151326.22634-13-ayankuma@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 31/10/2022 15:13, Ayan Kumar Halder wrote: > Refer ARM DDI 0487G.b ID072021, > D13.2.86 - > ID_PFR1_EL1, AArch32 Processor Feature Register 1 > > GIC, bits[31:28] == 0b0001 for GIC3.0 on Aarch32 > > One can now enable GICv3 on AArch32 systems. However, ITS is not supported. s/enable/use/ > The reason being currently we are trying to validate GICv3 on an AArch32_v8R > system. Refer ARM DDI 0568A.c ID110520, B1.3.1, > "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE must not > implement LPI support." > > Updated SUPPORT.md. > > Signed-off-by: Ayan Kumar Halder > --- > > Changed from :- > v1 - 1. Remove "ARM_64 || ARM_32" as it is always true. > 2. Updated SUPPORT.md. > > SUPPORT.md | 6 ++++++ > xen/arch/arm/Kconfig | 4 ++-- > xen/arch/arm/include/asm/cpufeature.h | 1 + > 3 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/SUPPORT.md b/SUPPORT.md > index cf2ddfacaf..0137855c66 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -82,6 +82,12 @@ Extension to the GICv3 interrupt controller to support MSI. > > Status: Experimental > > +### ARM/GICv3 + AArch32 ARM v8 The general apprpoach in SUPPORT.MD is to name the feature and then describe per arch the exact support. For this case it would be: ## ARM/GICv3 GICv3 is an interrupt controller specification designed by Arm. Status, Arm64: Security supported Status, Arm32: Supported, not security supported Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 18:42:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 18:42:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438664.692736 (Exim 4.92) (envelope-from ) id 1orkax-0002xC-Vy; Sun, 06 Nov 2022 18:42:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438664.692736; Sun, 06 Nov 2022 18:42:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkax-0002x5-TH; Sun, 06 Nov 2022 18:42:11 +0000 Received: by outflank-mailman (input) for mailman id 438664; Sun, 06 Nov 2022 18:42:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkav-0002wz-VK for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 18:42:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkav-0005vw-PR; Sun, 06 Nov 2022 18:42:09 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orkav-0001gf-IV; Sun, 06 Nov 2022 18:42:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=2TDacu/wGeiCn2jT+uheqOAXiC/+jh2L4RRjVGgDTfM=; b=2rX2qc/x8RWBiD8H28xaPs+NRW eOWYJiGhN1b/XyHQ+I+FbyCuwVthj3M0HJ6beE6oFzpt/f+Hx6u4fDf8VRY1EJeLu99Qg0sMR9FUh PUKfk3HlzY1NJerpmUYQoAg5rK3TCHwPJUS3PxcMCaH37DfRNvlnV8PzQBxxS+JsiUmo=; Message-ID: <57d54e0d-1ae4-dbd7-483d-07e3e29cfdf2@xen.org> Date: Sun, 6 Nov 2022 18:42:08 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 01/11] xen/arm: remove xen_phys_start and xenheap_phys_end from config.h To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-2-wei.chen@arm.com> From: Julien Grall In-Reply-To: <20221104100741.2176307-2-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 04/11/2022 10:07, Wei Chen wrote: > These two variables are stale variables, they only have declarations AFAICT, this has always been the case. I am guessing this was because the header was mostly likely copied from x86... > in config.h, they don't have any definition and no any code is using > these two variables. So in this patch, we remove them from config.h. > > Signed-off-by: Wei Chen Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 18:50:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 18:50:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438670.692746 (Exim 4.92) (envelope-from ) id 1orkiL-0003yY-PO; Sun, 06 Nov 2022 18:49:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438670.692746; Sun, 06 Nov 2022 18:49:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkiL-0003yR-Me; Sun, 06 Nov 2022 18:49:49 +0000 Received: by outflank-mailman (input) for mailman id 438670; Sun, 06 Nov 2022 18:49:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkiK-0003yL-PL for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 18:49:48 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c828fa98-5e03-11ed-8fd1-01056ac49cbb; Sun, 06 Nov 2022 19:49:46 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 07BA760D57; Sun, 6 Nov 2022 18:49:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 6DF6DC433D7; Sun, 6 Nov 2022 18:49:44 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 4C5F3E270DD; Sun, 6 Nov 2022 18:49:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c828fa98-5e03-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667760584; bh=MfPHo+0mPM8JcO0sg8ivk7lLZLBFpDVM1b+O/kblazs=; h=Subject:From:In-Reply-To:References:Date:To:Cc:From; b=ohp/yTocx7u1uzQa0yyMrpBNC1FK7RCjeYuQmjnbILPxo9+1LRnC1r3EvqbcidyGs 3S7tjxBg+tEt/ei8bpFgA3OHEFemc+Imu5GoP2R7Cj7Ey8MMM6vNSITSLVnl7xDw1h NUZEfTy/iNQP+e/vvMACL7DOkiZUSZpAWJSI5YazkS6VVyab7sjrF3vqBrrT5p7sc8 T4u4txOqg4VhuSm+Hzz/q4W7yIz1PhLft+81HpeyRhKRsrIhcRxTZUDUY9qIWCvE/x 3RnFJ0h+2dza19lTZJrjr/ie3mn/qRvfPeWdJJTp2Sovn3b0lf2JT4qYkCX8aZrwrV tCqQXhqJAe4bQ== Subject: Re: [GIT PULL] xen: branch for v6.1-rc4 From: pr-tracker-bot@kernel.org In-Reply-To: <20221106055958.14139-1-jgross@suse.com> References: <20221106055958.14139-1-jgross@suse.com> X-PR-Tracked-List-Id: X-PR-Tracked-Message-Id: <20221106055958.14139-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.1-rc4-tag X-PR-Tracked-Commit-Id: 4bff677b30156435afa2cc4c3601b542b4ddd439 X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: 6e8c78d32b5c60737bcd71346130f0bf91d6e066 Message-Id: <166776058430.6751.15098264634464095841.pr-tracker-bot@kernel.org> Date: Sun, 06 Nov 2022 18:49:44 +0000 To: Juergen Gross Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org The pull request you sent on Sun, 6 Nov 2022 06:59:58 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.1-rc4-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6e8c78d32b5c60737bcd71346130f0bf91d6e066 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Sun Nov 06 18:55:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 18:55:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438675.692757 (Exim 4.92) (envelope-from ) id 1orknZ-0005l4-CZ; Sun, 06 Nov 2022 18:55:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438675.692757; Sun, 06 Nov 2022 18:55:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orknZ-0005kx-9i; Sun, 06 Nov 2022 18:55:13 +0000 Received: by outflank-mailman (input) for mailman id 438675; Sun, 06 Nov 2022 18:55:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orknX-0005kb-Ng for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 18:55:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orknX-0006Jl-B2; Sun, 06 Nov 2022 18:55:11 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orknX-00027w-4f; Sun, 06 Nov 2022 18:55:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=MpeTcE9GW2bBEQ5mJW3VAHRwMPM8OSVW6IKCRow1rSM=; b=cGq2H1xfFsz92xPEz0d+aF2pHj vKroEn9aHx5lccBb4OSxQzvcHvwXBO8Ol9X85OoubxwOmkbePJrsWGofvv0K51e62Gn+QpVcIAqeS MQf/L8LfWPGc4I/pxuFLZUg4Wc1nNdls7jiQTE5AkPyHNpxXc+nh8oHL2SMLtyzGz3qQ=; Message-ID: Date: Sun, 6 Nov 2022 18:55:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Henry Wang References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-3-wei.chen@arm.com> From: Julien Grall Subject: Re: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build In-Reply-To: <20221104100741.2176307-3-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit (+ Henry) Hi, On 04/11/2022 10:07, Wei Chen wrote: > domain_build use ioremap_wc to map a new non-cacheable virtual s/use/uses/ > address for initrd. After Xen copy initrd from this address to > guest, this new allocated virtual address has not been unmapped. > > So in this patch, we add an iounmap to the end of domain_build, > after Xen loaded initrd to guest memory. > Please a fixes tag. The issue was introduced by commit bb7e6d565d92. > Signed-off-by: Wei Chen > --- > xen/arch/arm/domain_build.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 4fb5c20b13..bd30d3798c 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3418,6 +3418,8 @@ static void __init initrd_load(struct kernel_info *kinfo) > initrd, len); > if ( res != 0 ) > panic("Unable to copy the initrd in the hwdom memory\n"); > + > + iounmap(initrd); This looks good to me. But I am wondering whether using ioremap_wc() is actually correct because we are reading the region. So it seems strang to map it with write-combine. So I would consider to use ioremap_cache(). That said, this would be a separate patch. I think this wants to be in 4.17. This will avoid Xen to have two mappings with different caching attribute (initrd is part of the RAM and therefore directmap). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 19:02:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 19:02:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438680.692769 (Exim 4.92) (envelope-from ) id 1orkuH-0007ED-30; Sun, 06 Nov 2022 19:02:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438680.692769; Sun, 06 Nov 2022 19:02:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkuH-0007E6-0D; Sun, 06 Nov 2022 19:02:09 +0000 Received: by outflank-mailman (input) for mailman id 438680; Sun, 06 Nov 2022 19:02:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkuF-0007E0-8y for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 19:02:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orkuE-0006Si-Vy; Sun, 06 Nov 2022 19:02:06 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orkuE-0002Rn-Ol; Sun, 06 Nov 2022 19:02:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=v1UFhayc9LFvevF+A40nQDQisahupmXqmvzNZjqoq/4=; b=Lhi+7OSf5Aelvzs7XUvkhrNPC8 TyS0N3e2tRdY9ZYCqRm9uPklhJNBLilcp3G1e9sEU6nxWbOvEIx45uhMlwPNE11PabROJ1sblRlFF VDw/k9xTyVIluUxO6BsKN9UNfYfRXV25UlaS3FwZmSjQ3rcm7H7DN0FyzeFHB09n7oXw=; Message-ID: <9c3bfa0c-2c8f-2160-46d1-3be234b5bcaf@xen.org> Date: Sun, 6 Nov 2022 19:02:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> From: Julien Grall In-Reply-To: <20221104100741.2176307-1-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Wei, On 04/11/2022 10:07, Wei Chen wrote: > The Armv-R architecture profile was designed to support use cases > that have a high sensitivity to deterministic execution. (e.g. > Fuel Injection, Brake control, Drive trains, Motor control etc) > > Arm announced Armv8-R in 2013, it is the latest generation Arm > architecture targeted at the Real-time profile. It introduces > virtualization at the highest security level while retaining the > Protected Memory System Architecture (PMSA) based on a Memory > Protection Unit (MPU). In 2020, Arm announced Cortex-R82, > which is the first Arm 64-bit Cortex-R processor based on Armv8-R64. > The latest Armv8-R64 document can be found [1]. And the features of > Armv8-R64 architecture: > - An exception model that is compatible with the Armv8-A model > - Virtualization with support for guest operating systems > - PMSA virtualization using MPUs In EL2. > - Adds support for the 64-bit A64 instruction set. > - Supports up to 48-bit physical addressing. > - Supports three Exception Levels (ELs) > - Secure EL2 - The Highest Privilege > - Secure EL1 - RichOS (MMU) or RTOS (MPU) > - Secure EL0 - Application Workloads > - Supports only a single Security state - Secure. > - MPU in EL1 & EL2 is configurable, MMU in EL1 is configurable. > > These patch series are implementing the Armv8-R64 MPU support > for Xen, which are based on the discussion of > "Proposal for Porting Xen to Armv8-R64 - DraftC" [1]. > > We will implement the Armv8-R64 and MPU support in three stages: > 1. Boot Xen itself to idle thread, do not create any guests on it. I read this as I can build Xen and see it boots (not creating domain). However... HAS_MPU is not defined and I was expecting mm.c to be modified to cater the MPU support. So I am a bit ensure what the series is actually doing. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 19:11:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 19:11:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438685.692780 (Exim 4.92) (envelope-from ) id 1orl3T-0000eG-0X; Sun, 06 Nov 2022 19:11:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438685.692780; Sun, 06 Nov 2022 19:11:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orl3S-0000e9-TD; Sun, 06 Nov 2022 19:11:38 +0000 Received: by outflank-mailman (input) for mailman id 438685; Sun, 06 Nov 2022 19:11:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orl3R-0000dz-BH; Sun, 06 Nov 2022 19:11:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orl3R-0006bx-70; Sun, 06 Nov 2022 19:11:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orl3Q-00044k-PP; Sun, 06 Nov 2022 19:11:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orl3Q-0001nI-Ot; Sun, 06 Nov 2022 19:11:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GqDvvUQsekaMKQEz/R9XAHTBvOCD26JQdxJNDOqqE10=; b=pHqyzsEdWNJO/TcKF765MgDe+g QH8Nj708f8oEumG0XGIefOA0IwHT65XtEEOfsiIM5OAtYSXFhg3i4vJ/0KbxkoiAL3+I9dWgyYi3/ ivyLM14mfvGj74ls2rvsBeQVPzJEAS2bB+qQMLovHxSKQhc3wlN0+55gE1ylDhF8j8NA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174646: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:build-arm64-pvops:kernel-build:fail:regression linux-5.4:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-xsm:xen-boot:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start.2:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:redhat-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a0d9384967214783a92973c920092b7251c03e57 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Sun, 06 Nov 2022 19:11:36 +0000 flight 174646 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174646/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174638 REGR. vs. 174540 build-arm64-pvops 6 kernel-build fail in 174642 REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-amd64-i386-pair 11 xen-install/dst_host fail in 174638 pass in 174646 test-amd64-i386-libvirt-xsm 8 xen-boot fail in 174638 pass in 174646 test-armhf-armhf-xl-rtds 14 guest-start fail in 174638 pass in 174646 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail in 174642 pass in 174646 test-amd64-i386-pair 10 xen-install/src_host fail in 174642 pass in 174646 test-armhf-armhf-xl-credit2 14 guest-start fail in 174642 pass in 174646 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 174642 pass in 174646 test-armhf-armhf-libvirt-raw 13 guest-start fail in 174642 pass in 174646 test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 174638 test-armhf-armhf-libvirt-qcow2 13 guest-start fail pass in 174638 test-armhf-armhf-xl-credit1 19 guest-start.2 fail pass in 174638 test-amd64-i386-qemuu-rhel6hvm-amd 12 redhat-install fail pass in 174642 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 174642 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174642 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 174642 n/a test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 174638 like 174540 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 174638 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 174638 never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 174638 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux a0d9384967214783a92973c920092b7251c03e57 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 8 days Failing since 174575 2022-11-01 18:42:39 Z 5 days 9 attempts Testing same since 174608 2022-11-03 19:46:50 Z 2 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anssi Hannula Arnaldo Carvalho de Melo Biju Das Brian Foster Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Darrick J. Wong Darrick J. Wong Dave Chinner David S. Miller Demi Marie Obenour Dongliang Mu Eric Dumazet Florian Fainelli Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hannu Hartikainen Hans Verkuil Heiko Carstens Helge Deller Hyong Youb Kim Hyunwoo Kim Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jeff Vanhoof Jens Glathe Jimmy Assarsson Johan Hovold Jon Hunter Jon Maloy Jonathan Cameron Josh Poimboeuf Juergen Gross Justin Chen Konrad Jankowski Kuogee Hsieh Leon Romanovsky Linux Kernel Functional Testing Luiz Capitulino M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Michal Jaron Mike Kravetz Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Paolo Abeni Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rik van Riel Saeed Mahameed Sakari Ailus Sasha Levin Shreeya Patel Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Thinh Nguyen Tom Lendacky Tony O'Brien Ulf Hansson Vasily Gorbik Vineet Gupta Vladimir Oltean Wei Yongjun Xin Long Yang Yingliang Yongqin Liu Zhang Changzhong Zhengchao Shao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2244 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 06 19:12:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 19:12:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438691.692791 (Exim 4.92) (envelope-from ) id 1orl4H-0001EN-DZ; Sun, 06 Nov 2022 19:12:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438691.692791; Sun, 06 Nov 2022 19:12:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orl4H-0001EG-Am; Sun, 06 Nov 2022 19:12:29 +0000 Received: by outflank-mailman (input) for mailman id 438691; Sun, 06 Nov 2022 19:12:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orl4F-0001Cy-SO for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 19:12:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orl4F-0006cg-Jg; Sun, 06 Nov 2022 19:12:27 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orl4F-0002vc-Dq; Sun, 06 Nov 2022 19:12:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=taBjr1yUIz3RVTFY6ODxg4z6regOT8VnBXuEwKOvOfI=; b=sLIfe3ZwrsO8KI7Ft+iUjQLSBz /2PZRV5QLhau396xgn6oO06R2FARGRh8YCmfMnPRCEF5SGHO6G/Q/D79OTPp5yb/RMfQrwUSuhCYW uSA3ZCXzQhGaGP/pjDEIcdLVXW/FqrKjl5UB7urKjPX8iF1SPh+pN0BSAjKe1rW5P6xI=; Message-ID: Date: Sun, 6 Nov 2022 19:12:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-4-wei.chen@arm.com> From: Julien Grall Subject: Re: [PATCH v6 03/11] xen/arm: disable EFI boot services for MPU systems In-Reply-To: <20221104100741.2176307-4-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Wei, On 04/11/2022 10:07, Wei Chen wrote: > Current EFI boot services support of Arm64 could not > work well for Armv8-R64 system that only has MPU in > EL2. That is because EFI boot services may need some > relocation support or partial PIE/PIC support. I am a bit confused with argument. We have nothing in Xen today to deal with relocation/partial PIE/PIC support. So what is the exact problem? Is it because UEFI can load Xen anywwhere? > But these will not be supported in the initial stage of > porting Xen to MPU systems. So in this patch, we > disable EFI boot services support for Arm MPU systems. > > Signed-off-by: Wei Chen > --- > xen/arch/arm/Kconfig | 2 +- > xen/arch/arm/arm64/head.S | 8 ++++++-- > 2 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 1fe5faf847..ad592367bd 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -7,7 +7,7 @@ config ARM_64 > def_bool y > depends on !ARM_32 > select 64BIT > - select ARM_EFI > + select ARM_EFI if !HAS_MPU I think it would make sense to allow ARM_EFI to be disabled even without the MPU support. So this would remove nearly 3K lines (just using wc -l *.c in the efi directories) for someone that don't need to boot using EFI. > select HAS_FAST_MULTIPLY > > config ARM > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index ad014716db..ccedf20dc7 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -172,8 +172,10 @@ efi_head: > .byte 0x52 > .byte 0x4d > .byte 0x64 > - .long pe_header - efi_head /* Offset to the PE header. */ > - > +#ifndef CONFIG_ARM_EFI > + .long 0 /* 0 means no PE header. */ > +#else > + .long pe_header - efi_head /* Offset to the PE header. */ > /* > * Add the PE/COFF header to the file. The address of this header > * is at offset 0x3c in the file, and is part of Linux "Image" > @@ -279,6 +281,8 @@ section_table: > .short 0 /* NumberOfLineNumbers (0 for executables) */ > .long 0xe0500020 /* Characteristics (section flags) */ > .align 5 > +#endif /* CONFIG_ARM_EFI */ > + > real_start: > /* BSS should be zeroed when booting without EFI */ > mov x26, #0 /* x26 := skip_zero_bss */ Shouldn't the function efi_xen_start be stubbed as well? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 19:13:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 19:13:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438696.692802 (Exim 4.92) (envelope-from ) id 1orl4y-0001lp-Np; Sun, 06 Nov 2022 19:13:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438696.692802; Sun, 06 Nov 2022 19:13:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orl4y-0001li-JW; Sun, 06 Nov 2022 19:13:12 +0000 Received: by outflank-mailman (input) for mailman id 438696; Sun, 06 Nov 2022 19:13:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orl4x-0001lW-UU for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 19:13:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orl4x-0006dV-Lf; Sun, 06 Nov 2022 19:13:11 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orl4x-0002wj-G0; Sun, 06 Nov 2022 19:13:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=Fq6Gue9wkWSS/0f4RrJHM8xb6PrT2FLoEaVT9UoV27k=; b=dCbg6CtppJVXlgjpMlqAn7/xjQ E8zKiqPEyJDl5YfR8PEDMgwOr63wD6eKKBRJGdVwOEXEzTyJTWn76OGbM7K1huyRZ5T0c5aKBmP7M YQJqmVbCLtcOOaLWsqlQFmzzf2C/YThyeMhvJ2siw0dgvw32zvkCQW8z5PEgC1zalwGo=; Message-ID: <9f753b19-e726-c5eb-06ad-310aab246406@xen.org> Date: Sun, 6 Nov 2022 19:13:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 03/11] xen/arm: disable EFI boot services for MPU systems From: Julien Grall To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-4-wei.chen@arm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 06/11/2022 19:12, Julien Grall wrote: > Hi Wei, > > On 04/11/2022 10:07, Wei Chen wrote: >> Current EFI boot services support of Arm64 could not >> work well for Armv8-R64 system that only has MPU in >> EL2. That is because EFI boot services may need some >> relocation support or partial PIE/PIC support. > > I am a bit confused with argument. We have nothing in Xen today to deal > with relocation/partial PIE/PIC support. So what is the exact problem? > Is it because UEFI can load Xen anywwhere? > >> But these will not be supported in the initial stage of >> porting Xen to MPU systems. So in this patch, we >> disable EFI boot services support for Arm MPU systems. >> >> Signed-off-by: Wei Chen >> --- >>   xen/arch/arm/Kconfig      | 2 +- >>   xen/arch/arm/arm64/head.S | 8 ++++++-- >>   2 files changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >> index 1fe5faf847..ad592367bd 100644 >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -7,7 +7,7 @@ config ARM_64 >>       def_bool y >>       depends on !ARM_32 >>       select 64BIT >> -    select ARM_EFI >> +    select ARM_EFI if !HAS_MPU > > I think it would make sense to allow ARM_EFI to be disabled even without > the MPU support. So this would remove nearly 3K lines (just using wc -l > *.c in the efi directories) for someone that don't need to boot using EFI. > >>       select HAS_FAST_MULTIPLY >>   config ARM >> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S >> index ad014716db..ccedf20dc7 100644 >> --- a/xen/arch/arm/arm64/head.S >> +++ b/xen/arch/arm/arm64/head.S >> @@ -172,8 +172,10 @@ efi_head: >>           .byte   0x52 >>           .byte   0x4d >>           .byte   0x64 >> -        .long   pe_header - efi_head        /* Offset to the PE >> header. */ >> - >> +#ifndef CONFIG_ARM_EFI >> +        .long   0                    /* 0 means no PE header. */ >> +#else >> +        .long   pe_header - efi_head /* Offset to the PE header. */ >>           /* >>            * Add the PE/COFF header to the file.  The address of this >> header >>            * is at offset 0x3c in the file, and is part of Linux "Image" >> @@ -279,6 +281,8 @@ section_table: >>           .short  0                /* NumberOfLineNumbers  (0 for >> executables) */ >>           .long   0xe0500020       /* Characteristics (section flags) */ >>           .align  5 >> +#endif /* CONFIG_ARM_EFI */ >> + >>   real_start: >>           /* BSS should be zeroed when booting without EFI */ >>           mov   x26, #0                /* x26 := skip_zero_bss */ > > Shouldn't the function efi_xen_start be stubbed as well? Sorry, I mean protected rather than stubbed because there will be no user when !CONFIG_ARM_EFI. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 19:19:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 19:19:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438703.692812 (Exim 4.92) (envelope-from ) id 1orlB9-0002sd-B2; Sun, 06 Nov 2022 19:19:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438703.692812; Sun, 06 Nov 2022 19:19:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orlB9-0002sW-8K; Sun, 06 Nov 2022 19:19:35 +0000 Received: by outflank-mailman (input) for mailman id 438703; Sun, 06 Nov 2022 19:19:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orlB8-0002sQ-IP for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 19:19:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orlB8-0006v1-9W; Sun, 06 Nov 2022 19:19:34 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orlB8-00032Q-3j; Sun, 06 Nov 2022 19:19:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=JW38zcUk4Sti1KNTRFmM6TpSD8Mt8H8OAbAdO4O4Qic=; b=4LKXeN4LJWSBqLYFtRiVJg3YwE M2geMhV7USTbboxGLjOYHc7QlfkOEafVVSyYoj88KdKtY6DQmBaGoiSzQgv8IP1ZT/45bQSs6H8Hw GoJNKAzOx76/3AWH2vDsqgoq1LKR9nEhLoFkiBg75qq4bOu5VTzj1o1+dFRSbd6B1EAk=; Message-ID: <0ffe8a4d-7caf-89af-d189-a872b6b4f0fa@xen.org> Date: Sun, 6 Nov 2022 19:19:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , "Jiamei . Xie" References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-6-wei.chen@arm.com> From: Julien Grall Subject: Re: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform In-Reply-To: <20221104100741.2176307-6-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/11/2022 10:07, Wei Chen wrote: > On Armv8-A, Xen has a fixed virtual start address (link address > too) for all Armv8-A platforms. In an MMU based system, Xen can > map its loaded address to this virtual start address. So, on > Armv8-A platforms, the Xen start address does not need to be > configurable. But on Armv8-R platforms, there is no MMU to map > loaded address to a fixed virtual address and different platforms > will have very different address space layout. So Xen cannot use > a fixed physical address on MPU based system and need to have it > configurable. > > So in this patch, we reuse the existing arm/platforms to store > Armv8-R platforms' parameters. And `XEN_START_ADDRESS` is one > kind of FVP BaseR platform's parameters. So we define default > `XEN_START_ADDRESS` for FVP BaseR in its platform file. > > We also introduce one Kconfig option for users to override the > default Xen start address of selected platform, if they think > the default address doesn't suit their scenarios. For this > Kconfig option, we use an unaligned address "0xffffffff" as the > default value to indicate that users haven't used a customized > Xen start address. > > And as we introduced Armv8-R platforms to Xen, that means the > existed Arm64 platforms should not be listed in Armv8-R platform > list, so we add !ARM_V8R dependency for these platforms. > > Signed-off-by: Wei Chen > Signed-off-by: Jiamei.Xie > --- > xen/arch/arm/Kconfig | 11 +++++++++++ > xen/arch/arm/include/asm/platforms/fvp_baser.h | 14 ++++++++++++++ I looked at the content of fvp_baser.h after this series is applied. There are a bit of boiler plate that I expect to be part for other platforms. In particular... > xen/arch/arm/platforms/Kconfig | 16 +++++++++++++--- > 3 files changed, 38 insertions(+), 3 deletions(-) > create mode 100644 xen/arch/arm/include/asm/platforms/fvp_baser.h > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index ad592367bd..ac276307d6 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -138,6 +138,17 @@ config TEE > This option enables generic TEE mediators support. It allows guests > to access real TEE via one of TEE mediators implemented in XEN. > > +config XEN_START_ADDRESS > + hex "Xen start address: keep default to use platform defined address" > + default 0xFFFFFFFF ... this default value will need to be tested everywhere. At least for now, I think you can avoid the per platform header by using the Kconfig to select the proper address (see the config for selecting early printk address). This will also avoids to use an invalid value here. > + depends on HAS_MPU > + help > + This option allows to set the customized address at which Xen will be > + linked on MPU systems. This address must be aligned to a page size. > + Use 0xFFFFFFFF as the default value to indicate that user hasn't > + customized this address, and Xen use use the default value that has > + been defined in platform files. > + > source "arch/arm/tee/Kconfig" > > config STATIC_SHM > diff --git a/xen/arch/arm/include/asm/platforms/fvp_baser.h b/xen/arch/arm/include/asm/platforms/fvp_baser.h > new file mode 100644 > index 0000000000..9450a411a9 > --- /dev/null > +++ b/xen/arch/arm/include/asm/platforms/fvp_baser.h > @@ -0,0 +1,14 @@ > +#ifndef __ASM_ARM_PLATFORMS_FVP_BASER_H__ > +#define __ASM_ARM_PLATFORMS_FVP_BASER_H__ > + > +/* > + * 0xFFFFFFFF indicates users haven't customized XEN_START_ADDRESS, > + * we will use platform defined default address. > + */ > +#if CONFIG_XEN_START_ADDRESS == 0xFFFFFFFF > +#define XEN_START_ADDRESS 0x200000 > +#else > +#define XEN_START_ADDRESS CONFIG_XEN_START_ADDRESS > +#endif > + > +#endif /* __ASM_ARM_PLATFORMS_FVP_BASER_H__ */ > diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig > index c93a6b2756..0904793a0b 100644 > --- a/xen/arch/arm/platforms/Kconfig > +++ b/xen/arch/arm/platforms/Kconfig > @@ -1,6 +1,7 @@ > choice > prompt "Platform Support" > default ALL_PLAT > + default FVP_BASER if ARM_V8R Is there any reason to create a new Kconfig rather than using MPU? > ---help--- > Choose which hardware platform to enable in Xen. > > @@ -8,13 +9,14 @@ choice > > config ALL_PLAT > bool "All Platforms" > + depends on !ARM_V8R > ---help--- > Enable support for all available hardware platforms. It doesn't > automatically select any of the related drivers. > > config QEMU > bool "QEMU aarch virt machine support" > - depends on ARM_64 > + depends on ARM_64 && !ARM_V8R > select GICV3 > select HAS_PL011 > ---help--- > @@ -23,7 +25,7 @@ config QEMU > > config RCAR3 > bool "Renesas RCar3 support" > - depends on ARM_64 > + depends on ARM_64 && !ARM_V8R > select HAS_SCIF > select IPMMU_VMSA > ---help--- > @@ -31,14 +33,22 @@ config RCAR3 > > config MPSOC > bool "Xilinx Ultrascale+ MPSoC support" > - depends on ARM_64 > + depends on ARM_64 && !ARM_V8R > select HAS_CADENCE_UART > select ARM_SMMU > ---help--- > Enable all the required drivers for Xilinx Ultrascale+ MPSoC > > +config FVP_BASER > + bool "Fixed Virtual Platform BaseR support" > + depends on ARM_V8R > + help > + Enable platform specific configurations for Fixed Virtual > + Platform BaseR > + > config NO_PLAT > bool "No Platforms" > + depends on !ARM_V8R > ---help--- > Do not enable specific support for any platform. > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 19:44:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 19:44:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438710.692824 (Exim 4.92) (envelope-from ) id 1orlZR-0006s9-9x; Sun, 06 Nov 2022 19:44:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438710.692824; Sun, 06 Nov 2022 19:44:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orlZR-0006s2-7T; Sun, 06 Nov 2022 19:44:41 +0000 Received: by outflank-mailman (input) for mailman id 438710; Sun, 06 Nov 2022 19:44:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orlZQ-0006rw-7j for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 19:44:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orlZQ-0007Jg-2M; Sun, 06 Nov 2022 19:44:40 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orlZP-00041Y-T0; Sun, 06 Nov 2022 19:44:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=So3NTQ/8VWcpN010o6UVyE1ciHC8qregy3fSqLLY91s=; b=CH0HmzcTS9s3GOUsNJD++hHL2e 6/6s6Bo9g3Vwu36py523rLsrIYl15NdhZ4EMrDvll0liB0vOfb/zbXdGJeUZzy0ZGO3MLG/5XBrID 5qFwasE0x0+06qxJUZbpijwEclHgRyQ4Qlg9APDHX2jWmq2E3YYRxFP9IjpMGQG1D9cQ=; Message-ID: Date: Sun, 6 Nov 2022 19:44:37 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 07/11] xen/arm: implement FIXMAP_ADDR for MPU systems To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-8-wei.chen@arm.com> From: Julien Grall In-Reply-To: <20221104100741.2176307-8-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Wei, On 04/11/2022 10:07, Wei Chen wrote: > FIXMAP is a special virtual address section for Xen to map some > physical ram or device memory temporarily in initialization for > MMU systems. FIXMAP_ADDR will return a virtual address by index > for special purpose phys-to-virt mapping usage. For example, > FIXMAP_ADDR(FIXMAP_CONSOLE) for early console mapping and > FIXMAP_ADDR(FIXMAP_MISC) for copy_from_paddr. To me, we are bending quite a bit the definition of the fixmap. There are not many use of the FIXMAP within the code and I think it would simply be better to abstract the use (or removing it when possible) and avoid defining FIXMAP_ADDR() & co for MPU. > > But in MPU systems, we can't map physical address to any virtual > address. So we want the code that is using FIXMAP_ADDR to return > the input physical address in MPU systems. So in MPU version, > FIXMAP_ADDR will trim physical address to PAGE alignment. This > will return an offset which is similar to MMU version FIXMAP_ADDR. > But it's a physical offset got from input physical address, plus > to an offset inside page (which is also got from physical address > mask with PAGE_MASK). The caller can return the input physical > address directly. > > As pmap depends on FIXAMP, so we disable pmap for Arm with MPU > enabled systems. > > Signed-off-by: Wei Chen > --- > xen/arch/arm/Kconfig | 2 +- > xen/arch/arm/include/asm/config_mpu.h | 2 ++ > xen/arch/arm/include/asm/fixmap.h | 25 +++++++++++++++++++++++++ > 3 files changed, 28 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index ac276307d6..1458ffa777 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -16,7 +16,7 @@ config ARM > select HAS_DEVICE_TREE > select HAS_PASSTHROUGH > select HAS_PDX > - select HAS_PMAP > + select HAS_PMAP if !HAS_MPU I can't find any change of mm.c in this series. So surely this will break the build? > select IOMMU_FORCE_PT_SHARE > > config ARCH_DEFCONFIG > diff --git a/xen/arch/arm/include/asm/config_mpu.h b/xen/arch/arm/include/asm/config_mpu.h > index 530abb8302..eee60dcffc 100644 > --- a/xen/arch/arm/include/asm/config_mpu.h > +++ b/xen/arch/arm/include/asm/config_mpu.h > @@ -24,4 +24,6 @@ > > #define HYPERVISOR_VIRT_START XEN_VIRT_START > > +#define FIXMAP_ADDR(n) (_AT(paddr_t, n) & (PAGE_MASK)) > + > #endif /* __ARM_CONFIG_MPU_H__ */ > diff --git a/xen/arch/arm/include/asm/fixmap.h b/xen/arch/arm/include/asm/fixmap.h > index d0c9a52c8c..1e338759e9 100644 > --- a/xen/arch/arm/include/asm/fixmap.h > +++ b/xen/arch/arm/include/asm/fixmap.h > @@ -7,6 +7,8 @@ > #include > #include > > +#ifndef CONFIG_HAS_MPU > + > /* Fixmap slots */ > #define FIXMAP_CONSOLE 0 /* The primary UART */ > #define FIXMAP_MISC 1 /* Ephemeral mappings of hardware */ > @@ -45,4 +47,27 @@ static inline unsigned int virt_to_fix(vaddr_t vaddr) > > #endif /* __ASSEMBLY__ */ > > +#else > + > +/* > + * FIXMAP_ADDR will trim physical address to PAGE alignment. > + * This will return an offset which is similar to MMU version > + * FIXMAP_ADDR. > + * For example: > + * EARLY_UART_VIRTUAL_ADDRESS is defined by: > + * (FIXMAP_ADDR(FIXMAP_CONSOLE) + \ > + * (CONFIG_EARLY_UART_BASE_ADDRESS & ~PAGE_MASK)) > + * With MPU version FIXMAP_CONSOLE and FIXMAP_ADDR definitions, > + * EARLY_UART_VIRTUAL_ADDRESS can be restore to > + * CONFIG_EARLY_UART_BASE_ADDRESS. > + * In this case, we don't need to use #ifdef MPU in the code > + * where are using FIXMAP_ADDR to make them to use physical > + * address explicitily. > + */ > +#ifdef CONFIG_EARLY_UART_BASE_ADDRESS > +#define FIXMAP_CONSOLE CONFIG_EARLY_UART_BASE_ADDRESS > +#endif > + > +#endif /* CONFIG_HAS_MPU */ > + > #endif /* __ASM_FIXMAP_H */ Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 20:06:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 20:06:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438949.692835 (Exim 4.92) (envelope-from ) id 1orluI-00026D-2B; Sun, 06 Nov 2022 20:06:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438949.692835; Sun, 06 Nov 2022 20:06:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orluH-00025m-Vb; Sun, 06 Nov 2022 20:06:13 +0000 Received: by outflank-mailman (input) for mailman id 438949; Sun, 06 Nov 2022 20:06:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orluG-00025g-0H for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 20:06:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orluF-0007uH-NA; Sun, 06 Nov 2022 20:06:11 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orluF-0004nN-H2; Sun, 06 Nov 2022 20:06:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=wMRI6Gr6jUh/CzIymT6d3sT/rB8KayIMymPojAb8NRY=; b=NyzJLu5aLPdNGkUTMtFZDYwNlL 93ZXsllsOrKrxFqX5dragC6+7SYOYKkWu7s9l8IQLaj4w02woV8MeV+CrqNMzWPUtvTy5KDGGPRs/ K8AgI+eCOHaK3bKKrRogpikbINKveyKfYNPKx9eSEK+rTSdzN/lv641ER7BVxMK6sGAY=; Message-ID: <5b975a59-5e97-c2a8-805c-9ab99b8712aa@xen.org> Date: Sun, 6 Nov 2022 20:06:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Henry Wang References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-9-wei.chen@arm.com> From: Julien Grall Subject: Re: [PATCH v6 08/11] xen/arm64: move MMU related code from head.S to head_mmu.S In-Reply-To: <20221104100741.2176307-9-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Wei, On 04/11/2022 10:07, Wei Chen wrote: > There are lots of MMU specific code in head.S. This code will not > be used in MPU systems. If we use #ifdef to gate them, the code > will become messy and hard to maintain. So we move MMU related > code to head_mmu.S, and keep common code still in head.S. I am afraid that you can't simply move the MMU code out of head.S because this will break Xen when running using the identity map. This is because we only map the first 4KB of Xen with PA == VA. At the moment, we guarantee it by having everything that needs to be used in the identity mapping before _end_boot and checking at link time if this fits in 4KB. Now that you moved the MMU code outside of head.S. We need to find a different way to guarantee it. One way to do it would be to create a section that would be used for everything that needs to be identity mapped. > > As we need to access "fail" and "puts" functions out of assembly > file, so we have to export them in this patch. And the assembly > macros: adr_l and load_paddr will be used by MMU and MPU later, > so we move them to macros.h. > > Signed-off-by: Henry Wang > Signed-off-by: Wei Chen In general, the first signed-off should match the author. So who is who here? > --- > xen/arch/arm/arm64/Makefile | 3 + > xen/arch/arm/arm64/head.S | 407 +----------------------- > xen/arch/arm/arm64/head_mmu.S | 364 +++++++++++++++++++++ > xen/arch/arm/include/asm/arm64/macros.h | 52 ++- > 4 files changed, 432 insertions(+), 394 deletions(-) > create mode 100644 xen/arch/arm/arm64/head_mmu.S > > diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile > index 6d507da0d4..22da2f54b5 100644 > --- a/xen/arch/arm/arm64/Makefile > +++ b/xen/arch/arm/arm64/Makefile > @@ -8,6 +8,9 @@ obj-y += domctl.o > obj-y += domain.o > obj-y += entry.o > obj-y += head.o > +ifneq ($(CONFIG_HAS_MPU),y) > +obj-y += head_mmu.o > +endif > obj-y += insn.o > obj-$(CONFIG_LIVEPATCH) += livepatch.o > obj-y += smc.o > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index ccedf20dc7..d9a8da9120 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -25,17 +25,6 @@ > #include > #include > > -#define PT_PT 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ > -#define PT_MEM 0xf7d /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=0 P=1 */ > -#define PT_MEM_L3 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ > -#define PT_DEV 0xe71 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=0 P=1 */ > -#define PT_DEV_L3 0xe73 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=1 P=1 */ > - > -/* Convenience defines to get slot used by Xen mapping. */ > -#define XEN_ZEROETH_SLOT zeroeth_table_offset(XEN_VIRT_START) > -#define XEN_FIRST_SLOT first_table_offset(XEN_VIRT_START) > -#define XEN_SECOND_SLOT second_table_offset(XEN_VIRT_START) > - > #define __HEAD_FLAG_PAGE_SIZE ((PAGE_SHIFT - 10) / 2) > > #define __HEAD_FLAG_PHYS_BASE 1 > @@ -82,73 +71,22 @@ > * x30 - lr > */ > > -#ifdef CONFIG_EARLY_PRINTK > -/* > - * Macro to print a string to the UART, if there is one. > - * > - * Clobbers x0 - x3 > - */ > -#define PRINT(_s) \ > - mov x3, lr ; \ > - adr x0, 98f ; \ > - bl puts ; \ > - mov lr, x3 ; \ > - RODATA_STR(98, _s) > +.section .text.header, "ax", %progbits > +/*.aarch64*/ The patch is already quite difficult to read. So I would rather prefer if the indentation is changed separately. Furthermore, I think it would be best if the functions moved in the header are done separately to help checking (I would be able to diff the source with the destination more easily). > > /* > - * Macro to print the value of register \xb > + * Kernel startup entry point. > + * --------------------------- Same here about the indentation. I will not comment everywhere where the indentation was changed. So please look at it. [...] > -/* > - * Map the UART in the fixmap (when earlyprintk is used) and hook the > - * fixmap table in the page tables. > - * > - * The fixmap cannot be mapped in create_page_tables because it may > - * clash with the 1:1 mapping. > - * > - * Inputs: > - * x20: Physical offset > - * x23: Early UART base physical address > - * > - * Clobbers x0 - x3 > - */ > -setup_fixmap: > -#ifdef CONFIG_EARLY_PRINTK > - /* Add UART to the fixmap table */ > - ldr x0, =EARLY_UART_VIRTUAL_ADDRESS > - create_mapping_entry xen_fixmap, x0, x23, x1, x2, x3, type=PT_DEV_L3 > -#endif > - /* Map fixmap into boot_second */ > - ldr x0, =FIXMAP_ADDR(0) > - create_table_entry boot_second, xen_fixmap, x0, 2, x1, x2, x3 > - /* Ensure any page table updates made above have occurred. */ > - dsb nshst > - > - ret > -ENDPROC(setup_fixmap) > - > /* > * Setup the initial stack and jump to the C world > * > @@ -810,41 +458,14 @@ launch: > ENDPROC(launch) > > /* Fail-stop */ > -fail: PRINT("- Boot failed -\r\n") > +ENTRY(fail) This name is a bit too generic to be exposed. But it would be better to duplicate it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 20:18:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 20:18:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438956.692846 (Exim 4.92) (envelope-from ) id 1orm6R-0003rS-AN; Sun, 06 Nov 2022 20:18:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438956.692846; Sun, 06 Nov 2022 20:18:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orm6R-0003rL-7g; Sun, 06 Nov 2022 20:18:47 +0000 Received: by outflank-mailman (input) for mailman id 438956; Sun, 06 Nov 2022 20:18:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orm6Q-0003rB-P4; Sun, 06 Nov 2022 20:18:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orm6Q-0008Gv-NH; Sun, 06 Nov 2022 20:18:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orm6Q-0006u5-Ax; Sun, 06 Nov 2022 20:18:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orm6Q-0004Jr-AP; Sun, 06 Nov 2022 20:18:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ec8Rbn8P5z4x3wjuK6grto61wsmTGPrlhOCpRx0bnpY=; b=oCSsFFU7vk0wKzNyc2f9HTGuwm ekWQo2sZS9Q1hVBXKExp90JdjdpbbZA0U/+XYfPZ99R4tctuhBXZ6/Is0U2WKOzdc05Ph98L0ISqI oefKOGh462OZXt3PyZ1O0sqR1uPQl1ojcXzWqMviy5xcHJQU6vUqNPrq85kE7KUs5XEk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174648: all pass - PUSHED X-Osstest-Versions-This: ovmf=b556f2445c251adf405ac966b48c237d20c0d46c X-Osstest-Versions-That: ovmf=cc650a0378f86a4980e7a0d37fef90d46d33afe1 From: osstest service owner Date: Sun, 06 Nov 2022 20:18:46 +0000 flight 174648 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174648/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b556f2445c251adf405ac966b48c237d20c0d46c baseline version: ovmf cc650a0378f86a4980e7a0d37fef90d46d33afe1 Last test of basis 174647 2022-11-06 15:43:37 Z 0 days Testing same since 174648 2022-11-06 18:11:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiewen Yao Leif Lindholm Pierre Gondois Sami Mujawar jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git cc650a0378..b556f2445c b556f2445c251adf405ac966b48c237d20c0d46c -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Nov 06 20:47:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 20:47:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438964.692857 (Exim 4.92) (envelope-from ) id 1ormXk-0007ko-J3; Sun, 06 Nov 2022 20:47:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438964.692857; Sun, 06 Nov 2022 20:47:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormXk-0007kh-GB; Sun, 06 Nov 2022 20:47:00 +0000 Received: by outflank-mailman (input) for mailman id 438964; Sun, 06 Nov 2022 20:47:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormXj-0007kb-US for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 20:46:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormXj-0000Sw-J8; Sun, 06 Nov 2022 20:46:59 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ormXj-0006HC-Db; Sun, 06 Nov 2022 20:46:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=6i5oLzJJB2aP/cTBYp+RXXVVkjdeHWLo6CfCarurGkA=; b=pll1RUk3nogziUnGuhbR+tIu1d tTemqAtUiAcfhkEY+TFr16sicNjiN8rSI2LZ9+4HHSrGSLsQm0d2cR3XSDE3fy7BryD5gBrXFe4Iv rgmrLjohIxI4hJCu6+PfMfZx9qS8oIFr7QBWAXfr2/1BVRn7xaiYbGmQHLzZ8E+OuoLE=; Message-ID: Date: Sun, 6 Nov 2022 20:46:56 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Penny Zheng , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-10-wei.chen@arm.com> From: Julien Grall Subject: Re: [PATCH v6 09/11] xen/arm64: create boot-time MPU protection regions In-Reply-To: <20221104100741.2176307-10-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Wei, On 04/11/2022 10:07, Wei Chen wrote: > From: Penny Zheng > > Like boot-time page table in MMU system, we need a boot-time > MPU protection region configuration in MPU system so Xen can > fetch code and data from normal memory. > > This operation need to access Armv8-R MPU system registers, but > these system registers are not supported in GCC version < 11. > So we have to encode these Armv8-R MPU system registers in header > file explicitly. > > As MMU system and MPU system have different functions to create > the boot MMU/MPU data, this will introduce extra #ifdef in code > flow, so we introduce a neutral name prepare_early_mappings to > replace create_page_tables for MMU and MPU. > > Signed-off-by: Wei Chen > Signed-off-by: Penny Zheng If Penny is the original author, then her signed-off-by should be first. > --- > xen/arch/arm/arm64/Makefile | 2 + > xen/arch/arm/arm64/head.S | 13 ++-- > xen/arch/arm/arm64/head_mmu.S | 4 +- > xen/arch/arm/arm64/head_mpu.S | 70 +++++++++++++++++++ > xen/arch/arm/include/asm/arm64/mpu.h | 13 ++++ > xen/arch/arm/include/asm/arm64/sysregs.h | 89 ++++++++++++++++++++++++ > 6 files changed, 185 insertions(+), 6 deletions(-) > create mode 100644 xen/arch/arm/arm64/head_mpu.S > create mode 100644 xen/arch/arm/include/asm/arm64/mpu.h > > diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile > index 22da2f54b5..438c9737ad 100644 > --- a/xen/arch/arm/arm64/Makefile > +++ b/xen/arch/arm/arm64/Makefile > @@ -10,6 +10,8 @@ obj-y += entry.o > obj-y += head.o > ifneq ($(CONFIG_HAS_MPU),y) > obj-y += head_mmu.o > +else > +obj-y += head_mpu.o > endif > obj-y += insn.o > obj-$(CONFIG_LIVEPATCH) += livepatch.o > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index d9a8da9120..6c1a5f74a1 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -79,12 +79,12 @@ > * --------------------------- > * > * The requirements are: > - * MMU = off, D-cache = off, I-cache = on or off, > + * MMU/MPU = off, D-cache = off, I-cache = on or off, > * x0 = physical address to the FDT blob. > * > * This must be the very first address in the loaded image. > * It should be linked at XEN_VIRT_START, and loaded at any > - * 4K-aligned address. All of text+data+bss must fit in 2MB, > + * 4K-aligned address. All of text+data+bss must fit in 2MB, The double space after the final point was valid. This is fairly common to use it and this is a spurious change. > * or the initial pagetable code below will need adjustment. > */ > > @@ -249,7 +249,12 @@ real_start_efi: > > bl check_cpu_mode > bl cpu_init > - bl create_page_tables > + > + /* > + * Create boot memory management data, pagetable for MMU systems > + * and protection regions for MPU systems. > + */ head.S is now meant to be generic. So I would prefer if we keep comment as generic as possible. IOW, anything after the first comma should be dropped. > + bl prepare_early_mappings > bl enable_mmu > > /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ > @@ -307,7 +312,7 @@ GLOBAL(init_secondary) > #endif > bl check_cpu_mode > bl cpu_init > - bl create_page_tables > + bl prepare_early_mappings > bl enable_mmu > > /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ > diff --git a/xen/arch/arm/arm64/head_mmu.S b/xen/arch/arm/arm64/head_mmu.S > index 1a3df81a38..fc64819a98 100644 > --- a/xen/arch/arm/arm64/head_mmu.S > +++ b/xen/arch/arm/arm64/head_mmu.S > @@ -123,7 +123,7 @@ > * > * Clobbers x0 - x4 > */ > -ENTRY(create_page_tables) > +ENTRY(prepare_early_mappings) > /* Prepare the page-tables for mapping Xen */ > ldr x0, =XEN_VIRT_START > create_table_entry boot_pgtable, boot_first, x0, 0, x1, x2, x3 > @@ -208,7 +208,7 @@ virtphys_clash: > /* Identity map clashes with boot_third, which we cannot handle yet */ > PRINT("- Unable to build boot page tables - virt and phys addresses clash. -\r\n") > b fail > -ENDPROC(create_page_tables) > +ENDPROC(prepare_early_mappings) > > /* > * Turn on the Data Cache and the MMU. The function will return on the 1:1 > diff --git a/xen/arch/arm/arm64/head_mpu.S b/xen/arch/arm/arm64/head_mpu.S > new file mode 100644 > index 0000000000..f60611b556 > --- /dev/null > +++ b/xen/arch/arm/arm64/head_mpu.S > @@ -0,0 +1,70 @@ > +// SPDX-License-Identifier: GPL-2.0-only Coding style: /* SPDX ... */ > +/* > + * Start-of-day code for an Armv8-R MPU system. > + */ > + > +#include > +#include > +#include Headers should be included in alphabetical order. > + > +/* > + * From the requirements of head.S we know that Xen image should > + * be linked at XEN_START_ADDRESS, and all of text + data + bss > + * must fit in 2MB. On MPU systems, XEN_START_ADDRESS is also the > + * address that Xen image should be loaded at. So for initial MPU > + * regions setup, we use 2MB for Xen data memory to setup boot > + * region, or the create boot regions code below will need adjustment. > + */ > +#define XEN_START_MEM_SIZE 0x200000 It sounds like something that should be defined in the header. Also, I think the size should be common between MPU and MMU. In [1], I was going to name it XEN_VIRT_SIZE. I would be OK to remove "VIRT" in the name. > + > +/* > + * In boot stage, we will use 1 MPU region: > + * Region#0: Normal memory for Xen text + data + bss (2MB) > + */ Are we only going to modify the MPU in head.S? If not, then I would define the layout in config_mpu.h so there are a single point where you can read how this works. > +#define BOOT_NORMAL_REGION_IDX 0x0 > + > +/* MPU normal memory attributes. */ > +#define PRBAR_NORMAL_MEM 0x30 /* SH=11 AP=00 XN=00 */ IIUC, this means that Xen will be mapped write-executable. Is this going to be forever? If not, when can't we already mapped Xen properly? > +#define PRLAR_NORMAL_MEM 0x0f /* NS=0 ATTR=111 EN=1 */ To me, it feels like this should be fined outside of head.S because this could be re-used by other part of Xen. > + > +.macro write_pr, sel, prbar, prlar > + msr PRSELR_EL2, \sel > + dsb sy Is it really necessary to use "sy" here? Also, it would be good to explain the logic. I.e. why do you need two dsb but only one isb? In fact, I was expecting an "isb" here than "dsb" to wait for the completion of the instruction. > + msr PRBAR_EL2, \prbar > + msr PRLAR_EL2, \prlar > + dsb sy > + isb > +.endm > + > +.section .text.header, "ax", %progbits > + > +/* > + * Static start-of-day EL2 MPU memory layout. > + * > + * It has a very simple structure, including: > + * - 2MB normal memory mappings of xen at XEN_START_ADDRESS, which > + * is the address where Xen was loaded by the bootloader. Missing details on the clobberred registers. > + */ > +ENTRY(prepare_early_mappings) > + /* Map Xen start memory to a normal memory region. */ > + mov x0, #BOOT_NORMAL_REGION_IDX > + ldr x1, =XEN_START_ADDRESS > + and x1, x1, #MPU_REGION_MASK > + mov x3, #PRBAR_NORMAL_MEM > + orr x1, x1, x3 It looks like to me there are a potential for a macro to compute the register. > + > + ldr x2, =XEN_START_ADDRESS > + mov x3, #(XEN_START_MEM_SIZE - 1) XEN_START_MEM_SIZE is the maximum size of Xen. IOW, Xen may be smaller and you will map memory that may not be part of Xen. Therefore, you likely want to compute the real size to avoid mapping too much. > + add x2, x2, x3 > + and x2, x2, #MPU_REGION_MASK > + mov x3, #PRLAR_NORMAL_MEM > + orr x2, x2, x3 > + > + /* > + * Write to MPU protection region: > + * x0 for pr_sel, x1 for prbar x2 for prlar This is not a very useful comment because this can be inferred from the prototype of write_pr. What would be more interesting is to explain the logic within this function in the same way we do in head.S and head_mmu.S. > + */ > + write_pr x0, x1, x2 > + > + ret > +ENDPROC(prepare_early_mappings) > diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h > new file mode 100644 > index 0000000000..d209eef6db > --- /dev/null > +++ b/xen/arch/arm/include/asm/arm64/mpu.h > @@ -0,0 +1,13 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * mpu.h: Arm Memory Protection Unit definitions. > + */ > + > +#ifndef __ARM64_MPU_H__ > +#define __ARM64_MPU_H__ > + > +#define MPU_REGION_SHIFT 6 > +#define MPU_REGION_ALIGN (_AC(1, UL) << MPU_REGION_SHIFT) > +#define MPU_REGION_MASK (~(MPU_REGION_ALIGN - 1)) > + > +#endif /* __ARM64_MPU_H__ */ > diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h > index 54670084c3..a596042d6c 100644 > --- a/xen/arch/arm/include/asm/arm64/sysregs.h > +++ b/xen/arch/arm/include/asm/arm64/sysregs.h In the context of this patch, it would be better to only define the registers you need. If you want to define all of them, then please define them in a separate patch before this one. > @@ -458,6 +458,95 @@ > #define ZCR_ELx_LEN_SIZE 9 > #define ZCR_ELx_LEN_MASK 0x1ff > > +/* System registers for AArch64 with PMSA */ > +#ifdef CONFIG_HAS_MPU The #ifdef here seems unnecessary. > + > +/* EL1 MPU Protection Region Base Address Register encode */ > +#define PRBAR_EL1 S3_0_C6_C8_0 > +#define PRBAR1_EL1 S3_0_C6_C8_4 > +#define PRBAR2_EL1 S3_0_C6_C9_0 > +#define PRBAR3_EL1 S3_0_C6_C9_4 > +#define PRBAR4_EL1 S3_0_C6_C10_0 > +#define PRBAR5_EL1 S3_0_C6_C10_4 > +#define PRBAR6_EL1 S3_0_C6_C11_0 > +#define PRBAR7_EL1 S3_0_C6_C11_4 > +#define PRBAR8_EL1 S3_0_C6_C12_0 > +#define PRBAR9_EL1 S3_0_C6_C12_4 > +#define PRBAR10_EL1 S3_0_C6_C13_0 > +#define PRBAR11_EL1 S3_0_C6_C13_4 > +#define PRBAR12_EL1 S3_0_C6_C14_0 > +#define PRBAR13_EL1 S3_0_C6_C14_4 > +#define PRBAR14_EL1 S3_0_C6_C15_0 > +#define PRBAR15_EL1 S3_0_C6_C15_4 > + > +/* EL1 MPU Protection Region Limit Address Register encode */ > +#define PRLAR_EL1 S3_0_C6_C8_1 > +#define PRLAR1_EL1 S3_0_C6_C8_5 > +#define PRLAR2_EL1 S3_0_C6_C9_1 > +#define PRLAR3_EL1 S3_0_C6_C9_5 > +#define PRLAR4_EL1 S3_0_C6_C10_1 > +#define PRLAR5_EL1 S3_0_C6_C10_5 > +#define PRLAR6_EL1 S3_0_C6_C11_1 > +#define PRLAR7_EL1 S3_0_C6_C11_5 > +#define PRLAR8_EL1 S3_0_C6_C12_1 > +#define PRLAR9_EL1 S3_0_C6_C12_5 > +#define PRLAR10_EL1 S3_0_C6_C13_1 > +#define PRLAR11_EL1 S3_0_C6_C13_5 > +#define PRLAR12_EL1 S3_0_C6_C14_1 > +#define PRLAR13_EL1 S3_0_C6_C14_5 > +#define PRLAR14_EL1 S3_0_C6_C15_1 > +#define PRLAR15_EL1 S3_0_C6_C15_5 > + > +/* EL2 MPU Protection Region Base Address Register encode */ > +#define PRBAR_EL2 S3_4_C6_C8_0 > +#define PRBAR1_EL2 S3_4_C6_C8_4 > +#define PRBAR2_EL2 S3_4_C6_C9_0 > +#define PRBAR3_EL2 S3_4_C6_C9_4 > +#define PRBAR4_EL2 S3_4_C6_C10_0 > +#define PRBAR5_EL2 S3_4_C6_C10_4 > +#define PRBAR6_EL2 S3_4_C6_C11_0 > +#define PRBAR7_EL2 S3_4_C6_C11_4 > +#define PRBAR8_EL2 S3_4_C6_C12_0 > +#define PRBAR9_EL2 S3_4_C6_C12_4 > +#define PRBAR10_EL2 S3_4_C6_C13_0 > +#define PRBAR11_EL2 S3_4_C6_C13_4 > +#define PRBAR12_EL2 S3_4_C6_C14_0 > +#define PRBAR13_EL2 S3_4_C6_C14_4 > +#define PRBAR14_EL2 S3_4_C6_C15_0 > +#define PRBAR15_EL2 S3_4_C6_C15_4 > + > +/* EL2 MPU Protection Region Limit Address Register encode */ > +#define PRLAR_EL2 S3_4_C6_C8_1 > +#define PRLAR1_EL2 S3_4_C6_C8_5 > +#define PRLAR2_EL2 S3_4_C6_C9_1 > +#define PRLAR3_EL2 S3_4_C6_C9_5 > +#define PRLAR4_EL2 S3_4_C6_C10_1 > +#define PRLAR5_EL2 S3_4_C6_C10_5 > +#define PRLAR6_EL2 S3_4_C6_C11_1 > +#define PRLAR7_EL2 S3_4_C6_C11_5 > +#define PRLAR8_EL2 S3_4_C6_C12_1 > +#define PRLAR9_EL2 S3_4_C6_C12_5 > +#define PRLAR10_EL2 S3_4_C6_C13_1 > +#define PRLAR11_EL2 S3_4_C6_C13_5 > +#define PRLAR12_EL2 S3_4_C6_C14_1 > +#define PRLAR13_EL2 S3_4_C6_C14_5 > +#define PRLAR14_EL2 S3_4_C6_C15_1 > +#define PRLAR15_EL2 S3_4_C6_C15_5 > + > +/* MPU Protection Region Enable Register encode */ > +#define PRENR_EL1 S3_0_C6_C1_1 > +#define PRENR_EL2 S3_4_C6_C1_1 > + > +/* MPU Protection Region Selection Register encode */ > +#define PRSELR_EL1 S3_0_C6_C2_1 > +#define PRSELR_EL2 S3_4_C6_C2_1 > + > +/* MPU Type registers encode */ > +#define MPUIR_EL1 S3_0_C0_C0_4 > +#define MPUIR_EL2 S3_4_C0_C0_4 > + > +#endif > + > /* Access to system registers */ > > #define WRITE_SYSREG64(v, name) do { \ Cheers, [1] https://lore.kernel.org/all/20221022150422.17707-2-julien@xen.org/ -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 20:56:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 20:56:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438970.692868 (Exim 4.92) (envelope-from ) id 1ormgk-0000zc-Eh; Sun, 06 Nov 2022 20:56:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438970.692868; Sun, 06 Nov 2022 20:56:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormgk-0000zV-C5; Sun, 06 Nov 2022 20:56:18 +0000 Received: by outflank-mailman (input) for mailman id 438970; Sun, 06 Nov 2022 20:56:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormgj-0000zP-Bi for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 20:56:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormgi-0000cc-6l; Sun, 06 Nov 2022 20:56:16 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ormgi-0006Z3-0e; Sun, 06 Nov 2022 20:56:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=Ykobt1IReiaxgDo/u6xr7n5pDvpOSSLl0q1tIiQMGxU=; b=RqXXrxlPpCCyLf61MkxjiYioGq 8NPdg36FXhoCiAT7TjsBsPuWXnipH7ckH6YUcGxPpKxcMEXXNYtfdBbdXzShWWGbjxH1HchKfMAmw xq7JvvkyXTIXtmY79OgSPJn7ri4qqL0DlcPJrxMsYKKNQ/e2ae4k3Teef6rvPNyoEyh4=; Message-ID: <54d6e747-c791-c321-3c75-87613393d789@xen.org> Date: Sun, 6 Nov 2022 20:56:14 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Penny Zheng , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-11-wei.chen@arm.com> From: Julien Grall Subject: Re: [PATCH v6 10/11] xen/arm64: introduce helpers for MPU enable/disable In-Reply-To: <20221104100741.2176307-11-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Wei, On 04/11/2022 10:07, Wei Chen wrote: > From: Penny Zheng > > We need some helpers for Xen to enable/disable MPU in boot-time > and runtime. For MPU enable helper, we know that it's an > essential requirement of MPU system. But for MPU disable, > we need to use it for some special situations. For example, > in the progress of tranferring from boot-time to runtime, > we need to update the MPU protection regions configuration, > but we can't modify an MPU protection region if there is some > data accessed by Xen. But in boot-time all of Xen text, data > and BSS are in one MPU protection region, if Xen want to update > this protection region, above restriction will be triggered. This raises the following question: Why can't we create the split regions right now? In particular, disabling the MMU/Cache is fairly risky because you need to ensure that anything in the cache you care about have been written back to the RAM). > So in this situation, we need to disable the whole MPU to update > the protection regions. > > In these helper, enable/disable MPU will also enable/disable > the D-cache. There are two reasons for it: > 1. Make the function semantic be consistent with enable_mmu. > For MMU systems, enable_mmu will turn MMU and D-Cache at > the same time. > 2. When MPU is disabled, the MPU background attributes will > be used. On some platforms, the background will treat all > memory as device memory. The access to device memory will > bypass the cache, even if the C bit is enabled in SCTLR. > To avoid this implicit behavior, we disable cache with MPU > explicitly to tell user that when MPU is disabled, the > memory access is uncacheable. > > In this patch, we also introduce a neutral name enable_mm for > Xen to enable MMU/MPU. This can help us to keep one code flow > in head.S > > Signed-off-by: Wei Chen > Signed-off-by: Penny Zheng > --- > xen/arch/arm/arm64/head.S | 5 +++-- > xen/arch/arm/arm64/head_mmu.S | 4 ++-- > xen/arch/arm/arm64/head_mpu.S | 35 +++++++++++++++++++++++++++++++++++ > 3 files changed, 40 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 6c1a5f74a1..228f01db69 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -255,7 +255,8 @@ real_start_efi: > * and protection regions for MPU systems. > */ > bl prepare_early_mappings > - bl enable_mmu > + /* Turn on MMU or MPU */ > + bl enable_mm > > /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ > ldr x0, =primary_switched > @@ -313,7 +314,7 @@ GLOBAL(init_secondary) > bl check_cpu_mode > bl cpu_init > bl prepare_early_mappings > - bl enable_mmu > + bl enable_mm > > /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ > ldr x0, =secondary_switched > diff --git a/xen/arch/arm/arm64/head_mmu.S b/xen/arch/arm/arm64/head_mmu.S > index fc64819a98..b542755bd2 100644 > --- a/xen/arch/arm/arm64/head_mmu.S > +++ b/xen/arch/arm/arm64/head_mmu.S > @@ -217,7 +217,7 @@ ENDPROC(prepare_early_mappings) > * > * Clobbers x0 - x3 > */ > -ENTRY(enable_mmu) > +ENTRY(enable_mm) > PRINT("- Turning on paging -\r\n") > > /* > @@ -239,7 +239,7 @@ ENTRY(enable_mmu) > msr SCTLR_EL2, x0 /* now paging is enabled */ > isb /* Now, flush the icache */ > ret > -ENDPROC(enable_mmu) > +ENDPROC(enable_mm) > > /* > * Remove the 1:1 map from the page-tables. It is not easy to keep track > diff --git a/xen/arch/arm/arm64/head_mpu.S b/xen/arch/arm/arm64/head_mpu.S > index f60611b556..5a1b03e293 100644 > --- a/xen/arch/arm/arm64/head_mpu.S > +++ b/xen/arch/arm/arm64/head_mpu.S > @@ -68,3 +68,38 @@ ENTRY(prepare_early_mappings) > > ret > ENDPROC(prepare_early_mappings) > + > +/* > + * Enable EL2 MPU and data cache. Because we will disable cache > + * with MPU at the same time, in accordance with that, we have > + * to enable cache with MPU at the same time in this function. > + * When MPU is disabled, the MPU background attributes will > + * be used. On some platform, the background will treat all > + * memory as IO memory. I was under the impression that all access would be treated as Device Memory when the MMU is off. Isn't it the case for the MPU? Also, I think the correct wording is "device memory" rather than "IO memory". > The access to IO memory will bypass Ditto. > + * the cache, even you have enabled the C bit in SCTLR. > + * To avoid this implicit behavior, we disable cache with MPU > + * explicitly to tell user that when MPU is disabled, the memory > + * access is uncacheable. > + */ > +ENTRY(enable_mm) > + mrs x0, SCTLR_EL2 > + mov x1, #(SCTLR_Axx_ELx_M | SCTLR_Axx_ELx_C) > + /* Enable EL2 MPU and D-cache */ > + orr x0, x0, x1 > + dsb sy > + msr SCTLR_EL2, x0 > + isb > + ret > +ENDPROC(enable_mm) > + > +/* Disable MPU system, including data cache. */ > +ENTRY(disable_mm) I would rather not introduce this function until there is a caller. This is because, I believe, there are some assumptions on the state of the cache before we can turn off the MMU. So I would like to see the caller in order to assess whether this function makes sense. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 21:02:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 21:02:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438976.692879 (Exim 4.92) (envelope-from ) id 1ormmh-0002S1-4C; Sun, 06 Nov 2022 21:02:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438976.692879; Sun, 06 Nov 2022 21:02:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormmh-0002Ru-0q; Sun, 06 Nov 2022 21:02:27 +0000 Received: by outflank-mailman (input) for mailman id 438976; Sun, 06 Nov 2022 21:02:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormmg-0002Ro-2n for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 21:02:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormmf-0000kl-Qi; Sun, 06 Nov 2022 21:02:25 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ormmf-0006sa-KZ; Sun, 06 Nov 2022 21:02:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=6ec2LBk54MFmYYjhSdL5pisY844zpu/8f73ync2lh7A=; b=VX2gAqZDYAjI7tE4KVSc0KWu10 o4/DTz4s1Jr3QmxdQCYLbI7QfvjST8vM2Iw0aJLmrtb/pW6RpeqTmif9QKQ1dl5hZo1c+6pqG3uz7 NAOS4ZAbykwScXF+lKhHMnGlLmKq27E4wZndncrZP2IL0QrM9YD/Yh5BoDWgLb89hMgM=; Message-ID: <84e476a5-9365-bb80-a8e2-86dcf09681f0@xen.org> Date: Sun, 6 Nov 2022 21:02:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 11/11] xen/arm64: add setup_fixmap and remove_identity_mapping for MPU To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Penny Zheng , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-12-wei.chen@arm.com> From: Julien Grall In-Reply-To: <20221104100741.2176307-12-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 04/11/2022 10:07, Wei Chen wrote: > From: Penny Zheng > > setup_fixmap and remove_identity_mapping are two functions that > are used in Xen boot-time code flow. We implement these two > functions for MPU system, in this case, the code flow in head.S > doesn't need to use #ifdef to gate MPU/MMU code. > > In MMU system, setup_fixmap is used for Xen to map some essentail > data or devices in boot-time. For MPU system, we still have this > requirement, we map the early UART to MPU protection region when > earlyprintk is enabled. This also means PRINT can't be used after > turning on MPU but before setup_fixmap. This restriction is the > same as MMU system. > > For remove_identity_mapping, we just need an empty function to > make head.S code flow happy. > > Signed-off-by: Wei Chen > Signed-off-by: Penny Zheng > --- > xen/arch/arm/arm64/head_mpu.S | 49 +++++++++++++++++++ > .../arm/include/asm/platforms/fvp_baser.h | 4 ++ > 2 files changed, 53 insertions(+) > > diff --git a/xen/arch/arm/arm64/head_mpu.S b/xen/arch/arm/arm64/head_mpu.S > index 5a1b03e293..336c0a630f 100644 > --- a/xen/arch/arm/arm64/head_mpu.S > +++ b/xen/arch/arm/arm64/head_mpu.S > @@ -20,13 +20,20 @@ > /* > * In boot stage, we will use 1 MPU region: > * Region#0: Normal memory for Xen text + data + bss (2MB) > + * Region#1: Device memory for EARLY UART, size is defined > + * by platform's EARLY_UART_SIZE > */ > #define BOOT_NORMAL_REGION_IDX 0x0 > +#define BOOT_DEVICE_REGION_IDX 0x1 > > /* MPU normal memory attributes. */ > #define PRBAR_NORMAL_MEM 0x30 /* SH=11 AP=00 XN=00 */ > #define PRLAR_NORMAL_MEM 0x0f /* NS=0 ATTR=111 EN=1 */ > > +/* MPU device memory attributes. */ > +#define PRBAR_DEVICE_MEM 0x20 /* SH=10 AP=00 XN=00 */ > +#define PRLAR_DEVICE_MEM 0x09 /* NS=0 ATTR=100 EN=1 */ > + > .macro write_pr, sel, prbar, prlar > msr PRSELR_EL2, \sel > dsb sy > @@ -69,6 +76,48 @@ ENTRY(prepare_early_mappings) > ret > ENDPROC(prepare_early_mappings) > > +/* > + * In MMU system, setup_fixmap is used for Xen to map some essential data > + * or devices in boot-time. In order to be consistent with MMU system, we > + * inherit the function name for MPU system. > + * setup_fixmap of MPU system will: > + * - Map the early UART to MPU protection region when earlyprintk is > + * enabled (The PRINT can't be used after turning on MPU but before > + * setup_fixmap). For the MMU, we have this restriction because the fixmap could clash with the identity mapping. I don't think there are such restrictions for the MPU and therefore it seems strange to pertain the same behavior. In fact, I have plan to get rid of this restriction even for the MMU. So better this restriction is not spread if we can. > + * > + * Clobbers x0 - x3 > + */ > +ENTRY(setup_fixmap) > +#ifdef CONFIG_EARLY_PRINTK > + /* Map early uart to MPU device region for early printk. */ > + mov x0, #BOOT_DEVICE_REGION_IDX > + ldr x1, =CONFIG_EARLY_UART_BASE_ADDRESS > + and x1, x1, #MPU_REGION_MASK > + mov x3, #PRBAR_DEVICE_MEM > + orr x1, x1, x3 > + > + ldr x2, =CONFIG_EARLY_UART_BASE_ADDRESS > + ldr x3, =(CONFIG_EARLY_UART_BASE_ADDRESS + EARLY_UART_SIZE - 1) > + add x2, x2, x3 > + and x2, x2, #MPU_REGION_MASK > + mov x3, #PRLAR_DEVICE_MEM > + orr x2, x2, x3 > + > + /* > + * Write to MPU protection region: > + * x0 for pr_sel, x1 for prbar x2 for prlar > + */ > + write_pr x0, x1, x2 > +#endif > + > + ret > +ENDPROC(setup_fixmap) > + > +/* Stub of remove_identity_mapping for MPU systems */ > +ENTRY(remove_identity_mapping) > + ret > +ENDPROC(remove_identity_mapping) This stub could be avoided if you move the call to remove_identity_mapping in enable_mmu() as I did for arm32. See [1]. [1] https://lore.kernel.org/all/20221022150422.17707-3-julien@xen.org/ Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 21:08:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 21:08:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438984.692890 (Exim 4.92) (envelope-from ) id 1ormsW-0003Ls-SA; Sun, 06 Nov 2022 21:08:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438984.692890; Sun, 06 Nov 2022 21:08:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormsW-0003Ll-Oo; Sun, 06 Nov 2022 21:08:28 +0000 Received: by outflank-mailman (input) for mailman id 438984; Sun, 06 Nov 2022 21:08:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormsU-0003Lf-S8 for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 21:08:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormsU-0000s9-7i; Sun, 06 Nov 2022 21:08:26 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ormsU-00076O-26; Sun, 06 Nov 2022 21:08:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=FsPP+orV3AXD1euv1UytxsnCc1My4/1WAlhd2A++XL0=; b=SHXXb4mlf7C03sBj3dsWzmw/jf Y7hPd2R14rhXfiaGKWA6L5fLvWsd4D+vJA5EOZnqj89DX5FfPYS+8oGA+MtN3DmmxZMZhtwC7sHtl H0c6hyUnKVHpmWwVw+fx5n1nsmO8gCJCnR+P5YXrMCedlwi+IMCgpnfmO+7+twQXuX3k=; Message-ID: Date: Sun, 6 Nov 2022 21:08:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 03/20] tools/xenstore: let talloc_free() preserve errno To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-4-jgross@suse.com> From: Julien Grall In-Reply-To: <20221101152842.4257-4-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: > Today talloc_free() is not guaranteed to preserve errno, especially in > case a custom destructor is being used. > > Change that by renaming talloc_free() to _talloc_free() in talloc.c and > adding a wrapper to talloc.c. > > This allows to remove some errno saving outside of talloc.c. > > Signed-off-by: Juergen Gross > --- > tools/xenstore/talloc.c | 25 ++++++++++++++++++------- > tools/xenstore/xenstored_core.c | 2 -- > 2 files changed, 18 insertions(+), 9 deletions(-) > > diff --git a/tools/xenstore/talloc.c b/tools/xenstore/talloc.c > index d7edcf3a93..5fbefdf091 100644 > --- a/tools/xenstore/talloc.c > +++ b/tools/xenstore/talloc.c > @@ -103,6 +103,8 @@ struct talloc_chunk { > unsigned flags; > }; > > +static int _talloc_free(void *ptr); > + > /* 16 byte alignment seems to keep everyone happy */ > #define TC_HDR_SIZE ((sizeof(struct talloc_chunk)+15)&~15) > #define TC_PTR_FROM_CHUNK(tc) ((void *)(TC_HDR_SIZE + (char*)tc)) > @@ -245,7 +247,7 @@ static int talloc_reference_destructor(void *ptr) > tc1->destructor = NULL; > } > _TLIST_REMOVE(tc2->refs, handle); > - talloc_free(handle); > + _talloc_free(handle); From the commit message, it is not clear to me why we are calling the underscore version here. Same for the others below. > return 0; > } > > @@ -311,7 +313,7 @@ static int talloc_unreference(const void *context, const void *ptr) > > talloc_set_destructor(h, NULL); > _TLIST_REMOVE(tc->refs, h); > - talloc_free(h); > + _talloc_free(h); > return 0; > } > > @@ -349,7 +351,7 @@ int talloc_unlink(const void *context, void *ptr) > tc_p = talloc_chunk_from_ptr(ptr); > > if (tc_p->refs == NULL) { > - return talloc_free(ptr); > + return _talloc_free(ptr); > } > > new_p = talloc_parent_chunk(tc_p->refs); > @@ -521,7 +523,7 @@ static void talloc_free_children(void *ptr) > struct talloc_chunk *p = talloc_parent_chunk(tc->child->refs); > if (p) new_parent = TC_PTR_FROM_CHUNK(p); > } > - if (talloc_free(child) == -1) { > + if (_talloc_free(child) == -1) { > if (new_parent == null_context) { > struct talloc_chunk *p = talloc_parent_chunk(ptr); > if (p) new_parent = TC_PTR_FROM_CHUNK(p); > @@ -539,7 +541,7 @@ static void talloc_free_children(void *ptr) > will not be freed if the ref_count is > 1 or the destructor (if > any) returns non-zero Can you expand this comment to explain the different between _talloc_free() and talloc_free()? I agree the code is probably clear enough, but better to be obvious. > */ > -int talloc_free(void *ptr) > +static int _talloc_free(void *ptr) > { > struct talloc_chunk *tc; > > @@ -597,7 +599,16 @@ int talloc_free(void *ptr) > return 0; > } > > +int talloc_free(void *ptr) > +{ > + int ret; > + int saved_errno = errno; > > + ret = _talloc_free(ptr); > + errno = saved_errno; > + > + return ret; > +} > > /* > A talloc version of realloc. The context argument is only used if > @@ -610,7 +621,7 @@ void *_talloc_realloc(const void *context, void *ptr, size_t size, const char *n > > /* size zero is equivalent to free() */ > if (size == 0) { > - talloc_free(ptr); > + _talloc_free(ptr); > return NULL; > } > > @@ -1243,7 +1254,7 @@ void *talloc_realloc_fn(const void *context, void *ptr, size_t size) > > static void talloc_autofree(void) > { > - talloc_free(cleanup_context); > + _talloc_free(cleanup_context); > cleanup_context = NULL; > } > > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 476d5c6d51..5a174b9881 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -771,9 +771,7 @@ struct node *read_node(struct connection *conn, const void *ctx, > return node; > > error: > - err = errno; > talloc_free(node); > - errno = err; > return NULL; > } > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 21:09:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 21:09:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438989.692900 (Exim 4.92) (envelope-from ) id 1ormth-0003sh-4q; Sun, 06 Nov 2022 21:09:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438989.692900; Sun, 06 Nov 2022 21:09:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormth-0003sa-26; Sun, 06 Nov 2022 21:09:41 +0000 Received: by outflank-mailman (input) for mailman id 438989; Sun, 06 Nov 2022 21:09:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormtg-0003sU-Jf for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 21:09:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormtg-0000sz-0Q; Sun, 06 Nov 2022 21:09:40 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ormtf-00078O-Ra; Sun, 06 Nov 2022 21:09:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=wZXDY8RVFdWMv2moL+3xqUfF89FKyigPP9wRKNl6MUI=; b=HAJ34EkhgAknYn4IWKg52CKXBJ mMJbwLoQUz9ivp5kTUFXjFk4x2nfAcT/MeXoJm/AIMiSI/TT9+OwoL3FBhvw2+AXsI8+Z/AihlElG /Sov4dBy1FqEpnlXCgFbmqheoIG0ziMfA7NZkl+CCauwyhMnZgVjRI5esT6wZ2LwyybA=; Message-ID: Date: Sun, 6 Nov 2022 21:09:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 04/20] tools/xenstore: let tdb_logger() preserve errno To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-5-jgross@suse.com> From: Julien Grall In-Reply-To: <20221101152842.4257-5-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: > tdb_logger() is called by TDB for logging errors. As errno is checked > often after doing the logging, tdb_logger() should preserve errno. > > Signed-off-by: Juergen Gross Reviewed-by: Julien Grall Cheers, > --- > tools/xenstore/xenstored_core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 5a174b9881..d48208ecfe 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -2345,6 +2345,7 @@ static void tdb_logger(TDB_CONTEXT *tdb, int level, const char * fmt, ...) > { > va_list ap; > char *s; > + int saved_errno = errno; > > va_start(ap, fmt); > s = talloc_vasprintf(NULL, fmt, ap); > @@ -2360,6 +2361,8 @@ static void tdb_logger(TDB_CONTEXT *tdb, int level, const char * fmt, ...) > trace("talloc failure during logging\n"); > syslog(LOG_ERR, "talloc failure during logging\n"); > } > + > + errno = saved_errno; > } > > void setup_structure(bool live_update) -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 21:10:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 21:10:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.438994.692911 (Exim 4.92) (envelope-from ) id 1ormub-0005Dp-Dt; Sun, 06 Nov 2022 21:10:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 438994.692911; Sun, 06 Nov 2022 21:10:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormub-0005Di-B8; Sun, 06 Nov 2022 21:10:37 +0000 Received: by outflank-mailman (input) for mailman id 438994; Sun, 06 Nov 2022 21:10:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormua-0005DS-Gx for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 21:10:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ormuZ-0000tv-V7; Sun, 06 Nov 2022 21:10:35 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ormuZ-0007AW-Q6; Sun, 06 Nov 2022 21:10:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=F/nYLIawPo9HgrFZI+/fkr/mbpTyUM6/lTUyDiCLBHE=; b=i4R5NoD1RZOJZgoFA/m2U+uofa 2Kct8ChKhiStlyjVhMdBkaDtP21bL4qfk7hdS0yoosmKS8it7dy4GYGD/qOe4mmncZS0hFSfTFhZ7 w2gv8ZwdKeXcw243xloHfkMZEX2b7chVRS9UgbaOR+w1BYmV6oKR4ICYlzX2tcqJfEKo=; Message-ID: Date: Sun, 6 Nov 2022 21:10:34 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 05/20] tools/xenstore: preserve errno across corrupt() To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-6-jgross@suse.com> From: Julien Grall In-Reply-To: <20221101152842.4257-6-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: > Let corrupt() preserve errno in order to be able to simplify error > handling in future. > > This is rather easy as the errno value when entering corrupt() is > saved already. > > Signed-off-by: Juergen Gross Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 21:18:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 21:18:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439002.692923 (Exim 4.92) (envelope-from ) id 1orn27-0006AS-6U; Sun, 06 Nov 2022 21:18:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439002.692923; Sun, 06 Nov 2022 21:18:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orn27-0006AL-3W; Sun, 06 Nov 2022 21:18:23 +0000 Received: by outflank-mailman (input) for mailman id 439002; Sun, 06 Nov 2022 21:18:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orn25-0006AD-Gd for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 21:18:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orn24-0001B1-Nj; Sun, 06 Nov 2022 21:18:20 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orn24-0007QX-GV; Sun, 06 Nov 2022 21:18:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=TdAMxtQTotYIg+GA11QtQTVjpyM8HXkA7Id0HB8sckU=; b=0hY+NDDC41/r+WvN5wFCmcs4eY iEWvIZEjnPDQ7dSiebTA2emRutIIyOFVpgBAt4PyIHblabeun00FiVVeuooA18U30uU5muAHXdVBq daICmHFuthFzfbtIbAwI3m+3/OyJimkGDpVtC1G+b7vyiesOZHftOT3SNvxl6hcW6S4M=; Message-ID: <67cb3364-d5c1-28d8-4cda-8933de5cb9f7@xen.org> Date: Sun, 6 Nov 2022 21:18:18 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-7-jgross@suse.com> From: Julien Grall Subject: Re: [PATCH 06/20] tools/xenstore: remove all watches when a domain has stopped In-Reply-To: <20221101152842.4257-7-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: > When a domain has been recognized to have stopped, remove all its > registered watches. This avoids sending watch events to the dead domain > when all the nodes related to it are being removed by the Xen tools. From my understanding, shutdown doesn't mean dead. It may be used during migration (or snapshotting), where we don't want to touch the state in case of a cancellation (or resume). For instance, see the command XS_RESUME which will clear domain->shutdown. > > Signed-off-by: Juergen Gross > --- > tools/xenstore/xenstored_domain.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c > index aa86892fed..1516df71d8 100644 > --- a/tools/xenstore/xenstored_domain.c > +++ b/tools/xenstore/xenstored_domain.c > @@ -364,6 +364,12 @@ void check_domains(void) > && !domain->shutdown) { > domain->shutdown = true; > notify = 1; > + /* > + * Avoid triggering watch events when the > + * domain's nodes are being deleted. > + */ > + if (domain->conn) > + conn_delete_all_watches(domain->conn); > } > if (!dominfo.dying) > continue; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 21:38:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 21:38:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439011.692935 (Exim 4.92) (envelope-from ) id 1ornLT-0000Xh-OE; Sun, 06 Nov 2022 21:38:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439011.692935; Sun, 06 Nov 2022 21:38:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ornLT-0000Xa-JH; Sun, 06 Nov 2022 21:38:23 +0000 Received: by outflank-mailman (input) for mailman id 439011; Sun, 06 Nov 2022 21:38:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ornLR-0000XU-Rh for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 21:38:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ornLQ-0001Ub-Uv; Sun, 06 Nov 2022 21:38:20 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ornLQ-00089Q-P8; Sun, 06 Nov 2022 21:38:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=cUvG2Gwtx9Eyre7xUa//OC6RIbbH1cRXj0B3AFObs80=; b=1y2k0alcGywyXWMoI7J3fFQLUK zy7phSrjl3TIiojGeGAPbjzxxDmRLqxujRj3oUFSMGOV8qEWYEZOZ0xOdQaaMtfOPzPgp/CnKPsby GRFf2ZD4fxDZeEKeUg3Xbt1r1+9R0vnr/182HM7BuJg2P2Ha8FfcqpQIzvjJiVXSUyOk=; Message-ID: <4fb428cb-242f-1ee7-2dd7-cf32b190ebd6@xen.org> Date: Sun, 6 Nov 2022 21:38:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-10-jgross@suse.com> From: Julien Grall Subject: Re: [PATCH 09/20] tools/xenstore: introduce dummy nodes for special watch paths In-Reply-To: <20221101152842.4257-10-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: > Instead of special casing the permission handling and watch event > firing for the special watch paths "@introduceDomain" and > "@releaseDomain", use static dummy nodes added to the data base when > starting Xenstore. A few questions I think needs to be answered in the commit message: - Does this means we could write data in "@..." node? - How about creating sub nodes? - What does it mean for the accounting? Before, it was accounted to no-one but now it seems to be accounted to the owner (which may not be dom0). > > This allows to simplify quite some code. The diff is quite nice to have, but I am not entirely convinced this is making the code easier to understand. Is this patch helping you for another goal? > > Note that this requires to rework the calls of fire_watches() for the > special events in order to avoid leaking memory. > > Signed-off-by: Juergen Gross > --- > tools/xenstore/xenstored_control.c | 3 - > tools/xenstore/xenstored_core.c | 67 +++++++----- > tools/xenstore/xenstored_domain.c | 162 ++++------------------------- > tools/xenstore/xenstored_domain.h | 6 -- > tools/xenstore/xenstored_watch.c | 17 +-- > 5 files changed, 63 insertions(+), 192 deletions(-) > > diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c > index d1aaa00bf4..41e6992591 100644 > --- a/tools/xenstore/xenstored_control.c > +++ b/tools/xenstore/xenstored_control.c > @@ -676,9 +676,6 @@ static const char *lu_dump_state(const void *ctx, struct connection *conn) > if (ret) > goto out; > ret = dump_state_connections(fp); > - if (ret) > - goto out; > - ret = dump_state_special_nodes(fp); > if (ret) > goto out; > ret = dump_state_nodes(fp, ctx); > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 1650821922..cadb339486 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -616,7 +616,8 @@ static void get_acc_data(TDB_DATA *key, struct node_account_data *acc) > static unsigned int get_acc_domid(struct connection *conn, TDB_DATA *key, > unsigned int domid) > { > - return (!conn || key->dptr[0] == '/') ? domid : conn->id; > + return (!conn || key->dptr[0] == '/' || key->dptr[0] == '@') The comment above says it is sufficient to check for '/'. But now, you are also checking for '@'. > + ? domid : conn->id; > } > > int do_tdb_write(struct connection *conn, TDB_DATA *key, TDB_DATA *data, > @@ -1780,14 +1781,6 @@ static int do_set_perms(const void *ctx, struct connection *conn, > if (perms.p[0].perms & XS_PERM_IGNORE) > return ENOENT; > > - /* First arg is node name. */ > - if (strstarts(in->buffer, "@")) { > - if (set_perms_special(conn, in->buffer, &perms)) > - return errno; > - send_ack(conn, XS_SET_PERMS); > - return 0; > - } So there are a slight change in behavior here. Before, the permission would be directly set even if we are in a transaction. Now, this will only be set if the transaction has been committed. I am split on whether this would be considered as an ABI breakage. The new behavior seems better, but anyone rely on the (bogus?) previous behavior would have a surprise. At minimum, the change should at least be pointed out in the commit message. [...] > static int domain_tree_remove_sub(const void *ctx, struct connection *conn, > struct node *node, void *arg) > { > @@ -297,8 +273,24 @@ static void domain_tree_remove(struct domain *domain) > "error when looking for orphaned nodes\n"); > } > > - remove_domid_from_perm(&dom_release_perms, domain); > - remove_domid_from_perm(&dom_introduce_perms, domain); > + walk_node_tree(domain, NULL, "@releaseDomain", &walkfuncs, domain); > + walk_node_tree(domain, NULL, "@introduceDomain", &walkfuncs, domain); > +} > + > +static void fire_special_watches(const char *name) > +{ > + void *ctx = talloc_new(NULL); > + struct node *node; I can foresee how one may want to abuse for this function. So I would add an assert(name[0] == '@') to match clear this should only for watches starting with '@'. > + > + if (!ctx) > + return; > + > + node = read_node(NULL, ctx, name); > + > + if (node) > + fire_watches(NULL, ctx, name, node, true, NULL); Shouldn't we throw a message if we can't retrieve @...? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 22:00:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 22:00:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439017.692944 (Exim 4.92) (envelope-from ) id 1ornh6-0004CR-EC; Sun, 06 Nov 2022 22:00:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439017.692944; Sun, 06 Nov 2022 22:00:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ornh6-0004CK-B0; Sun, 06 Nov 2022 22:00:44 +0000 Received: by outflank-mailman (input) for mailman id 439017; Sun, 06 Nov 2022 22:00:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ornh4-0004BS-KX for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 22:00:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ornh3-00022f-OT; Sun, 06 Nov 2022 22:00:41 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ornh3-0000Wd-Gm; Sun, 06 Nov 2022 22:00:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=E0QzY3t0dt9qxIqpwca2JYCbx4h44HyZ9fvYGROHhzw=; b=AguAF7EEnc6wYrGGY11gWelhiB GbS9238xKR+FWo9/JpnFWpl4B0vlNTdpjKyZXkQ7Ko+LWYeSEI+6RVu4F9igwnh7/cHgP+H0G6+D2 Y+eklX55AzEr/C6+3E05AtfNjDdjBzQWzo/z0jbFACk6WZehLrtfa8Of0GV/N7qJ2bb0=; Message-ID: <32f61945-08fa-f095-02c4-9d52b66b6c04@xen.org> Date: Sun, 6 Nov 2022 22:00:39 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-14-jgross@suse.com> From: Julien Grall Subject: Re: [PATCH 13/20] tools/xenstore: don't allow creating too many nodes in a transaction In-Reply-To: <20221101152842.4257-14-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: > The accounting for the number of nodes of a domain in an active > transaction is not working correctly, as it allows to create arbitrary > number of nodes. The transaction will finally fail due to exceeding > the number of nodes quota, but before closing the transaction an > unprivileged guest could cause Xenstore to use a lot of memory. I have already made some of comments on the security ML when this was initially set. The arguments still don't sound right to me. For a first, since XSA-326, we have a cap in place for the memory a domain can consume. So this surely can't be a "lot of memory". Otherwise we are saying that our limit (there are other way to hit it) were wrong... In addition to that, this is quite pointless to check the number of entry a domain currently owned because this can change before the transaction is committed by another "external" command. Therefore, this would add some randomness in the command which could make more difficult to diagnose. Lastly, there are other very easy way to use memory (just create multiple transaction in parallel). So based on the commit message, the change doesn't help at all to make better Xenstored. Note that I don't particularly mind the code change (even though it adds more complexity). I just strongly dislike the current justifications. At the moment, I can't find a justification that would make the change whorthwhile. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 22:02:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 22:02:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439022.692956 (Exim 4.92) (envelope-from ) id 1ornj2-0004lz-PS; Sun, 06 Nov 2022 22:02:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439022.692956; Sun, 06 Nov 2022 22:02:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ornj2-0004ls-ML; Sun, 06 Nov 2022 22:02:44 +0000 Received: by outflank-mailman (input) for mailman id 439022; Sun, 06 Nov 2022 22:02:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ornj1-0004lm-1D for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 22:02:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ornj0-00024d-Eg; Sun, 06 Nov 2022 22:02:42 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ornj0-0000cS-9K; Sun, 06 Nov 2022 22:02:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=gkYEBpWGTb+HPlWDXlqHMHr5VkN4XV/nbqB2cbLfEok=; b=2iYmj9P4E9CQAFiymrT218rG6O q+B+HSlcCKbkeRAOrmcYoQfXagwa8q8fMj6Qh6yUD2faSlgmLJ2w1mErfKcTcWTZBro6nEvN2olrZ BMrxCb0DC/ZRO+Oc6QgjiRTz+cT33IgaODuFLP6qWDSepkN6FkYCyKR7W5BJMuCkmPb8=; Message-ID: Date: Sun, 6 Nov 2022 22:02:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 17/20] tools/xenstore: switch hashtable to use the talloc framework To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-18-jgross@suse.com> From: Julien Grall In-Reply-To: <20221101152842.4257-18-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: > Instead of using malloc() and friends, let the hashtable implementation > use the talloc framework. Can you outline why switching to talloc() is better? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Nov 06 22:18:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Nov 2022 22:18:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439030.692967 (Exim 4.92) (envelope-from ) id 1ornyE-0006pD-4D; Sun, 06 Nov 2022 22:18:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439030.692967; Sun, 06 Nov 2022 22:18:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ornyE-0006p6-1X; Sun, 06 Nov 2022 22:18:26 +0000 Received: by outflank-mailman (input) for mailman id 439030; Sun, 06 Nov 2022 22:18:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ornyD-0006p0-AR for xen-devel@lists.xenproject.org; Sun, 06 Nov 2022 22:18:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ornyD-0002TY-2Q; Sun, 06 Nov 2022 22:18:25 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ornyC-0001AL-Re; Sun, 06 Nov 2022 22:18:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=GdkNH0pYzaFQ7fGvbHxJkefbGqKit1QqFWVdGTWv1q4=; b=QQDdTvH2oNhE0qVY5RHOj8tAhr eKoTdPrA3tT5EXktq/MlY5CfwmoKSY0JgsQOQHZ6X+kHak7X2h5acOURQAso2v+DOZktEoUzt0gba F+TvDysqQUlwFni85a8XlLiGvL3kNTsnyGPu5ZB7lrdt/kEJ2asFZtFUtZJZCgn+JP+U=; Message-ID: <33e9e356-e8d7-2dfc-a71d-ecbf50a00786@xen.org> Date: Sun, 6 Nov 2022 22:18:22 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-20-jgross@suse.com> From: Julien Grall Subject: Re: [PATCH 19/20] tools/xenstore: introduce trace classes In-Reply-To: <20221101152842.4257-20-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, I haven't yet look at the code itself. I wanted to comment on the external interfaces. On 01/11/2022 15:28, Juergen Gross wrote: > Make the xenstored internal trace configurable by adding classes > which can be switched on and off independently from each other. > > Define the following classes: > > - obj: Creation and deletion of interesting "objects" (watch, > transaction, connection) > - io: incoming requests and outgoing responses > - wrl: write limiting > > Per default "obj" and "io" are switched on. > > Entries written via trace() will always be printed (if tracing is on > at all). > > Rename the misnamed xenstore-control commands "logfile" to "tracefile" > and "log" to "trace". While I understand this may be misnamed, this also means that there is an ABI breakage between current Xenstored and the future one. I am not convinced this is justified. Therefore, I think we should at minimum keep the compatibility. > > Add the capability to control the trace settings via the "trace" > command and via a new "--trace-control" command line option. > > Add a missing trace_create() call for creating a transaction. > > Signed-off-by: Juergen Gross > --- > docs/misc/xenstore.txt | 18 +++++++---- > tools/xenstore/xenstored_control.c | 41 +++++++++++++++++++----- > tools/xenstore/xenstored_core.c | 44 +++++++++++++++++++++++--- > tools/xenstore/xenstored_core.h | 6 ++++ > tools/xenstore/xenstored_domain.c | 27 ++++++++-------- > tools/xenstore/xenstored_transaction.c | 1 + > 6 files changed, 105 insertions(+), 32 deletions(-) > > diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt > index 44428ae3a7..9db0385120 100644 > --- a/docs/misc/xenstore.txt > +++ b/docs/misc/xenstore.txt > @@ -409,14 +409,8 @@ CONTROL |[|] > error string in case of failure. -s can return "BUSY" in case > of an active transaction, a retry of -s can be done in that > case. > - log|on > - turn xenstore logging on > - log|off > - turn xenstore logging off > - logfile| > - log to specified file Technically xenstore.txt is meant to describe an interface that is implementation agnostics. Can you outline in the documentation why removing them is fine? > memreport|[] > - print memory statistics to logfile (no > + print memory statistics to tracefile (no > specified) or to specific file > print| > print to syslog (xenstore runs as daemon) or > @@ -432,6 +426,16 @@ CONTROL |[|] > the domain > quota-soft|[set ] > like the "quota" command, but for soft-quota. > + trace|[+|-] The regex here is a bit ambiguous because it technically means either "+" or "-". Furthermore, within this docs, there are case where | is included in between [] to indicate the this is terminated by a \0. So it would be better to define it over 3 lines: trace trace|+ trace|- I think it would be fine if there is only one paragraph of explanation for the 3. > + without parameters: show possible trace switches > + + activates trace entries for , > + - deactivates trace entries for > + trace|on > + turn xenstore tracing on > + trace|off > + turn xenstore tracing off > + tracefile| > + trace to specified file > help > return list of supported commands for CONTROL > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 01:34:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 01:34:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439037.692978 (Exim 4.92) (envelope-from ) id 1orr1U-0003DX-Bd; Mon, 07 Nov 2022 01:34:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439037.692978; Mon, 07 Nov 2022 01:34:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orr1U-0003DP-59; Mon, 07 Nov 2022 01:34:00 +0000 Received: by outflank-mailman (input) for mailman id 439037; Mon, 07 Nov 2022 01:33:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orr1R-0003DI-K2 for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 01:33:57 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80088.outbound.protection.outlook.com [40.107.8.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3cfe7221-5e3c-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 02:33:55 +0100 (CET) Received: from DB9PR02CA0003.eurprd02.prod.outlook.com (2603:10a6:10:1d9::8) by GV2PR08MB8195.eurprd08.prod.outlook.com (2603:10a6:150:7b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 01:33:49 +0000 Received: from DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::68) by DB9PR02CA0003.outlook.office365.com (2603:10a6:10:1d9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 01:33:48 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT017.mail.protection.outlook.com (100.127.142.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 01:33:47 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Mon, 07 Nov 2022 01:33:47 +0000 Received: from 95a19d49c7ba.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3A1A6B39-D1B7-4C2C-BAE6-D6CACEC49360.1; Mon, 07 Nov 2022 01:33:41 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 95a19d49c7ba.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Nov 2022 01:33:41 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB6620.eurprd08.prod.outlook.com (2603:10a6:10:256::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 01:33:39 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Mon, 7 Nov 2022 01:33:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3cfe7221-5e3c-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gnSeE00jtPbDGl2aACwMSf0RCRi2yM+roaN91xrQTGfJS4OQaj3tr5Ytu6Ba4/iHASu38Aure5PF4fapTZHo3le17s4z0yYQcuND+A6kgZYTniosc98o1f126CHLYSO30MoFEkwZAbfeFbMsYfNmF0B/AdOojOvIaITcBFgatWqk9OsE/vqDkJMN2P40dErjVn7RYvtlCmk63G9tc8hPXkPxgZIoVwqOwkklDF2WhQmZ8BpNPiozE06HM4qzxb4ckzGxtkQSc+7vVMNXzGz/YzroewyPWaAxzK5A6Atuo/iDygjn+75G3R8lAPc2lldPxMJEHSA+InFF/kPeFrwI7w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XYg/79oVlrrf7AsOftIZl0Eb70WkWFysZZZN5zVxcj8=; b=TGE169hCRMDKBFOK6bzbNosOQR2XPMKdvhkbclK2zt4OnVXkqUQY5ykvI/GHDi9iU9tlyOYGi4vpUC5NsLYhhopFN87+ZaPmcNOg4bZGFs4d5xkJGBAhZZ1ZGrwuxz9PPbT2zjtdY1JwXwNzxZ9uMkpogEh0NzTc/Fp2RLlNiaT1zdzWj4FgWN+dPoq2bNm1C0cWTs1FvSjqtZtXb3D5BpiK3av2UPWpgcIfLQEcCmjvuR2aLJiVf/DtKWArH9sVbiAhVZ8QKcrtM+hhgAHNpSzhr99hDZ+Q4w/pKdLjzfZdyVAnvsUReCpce8h/f7oumP2y4iuyKuTUvLrO6bCo2A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XYg/79oVlrrf7AsOftIZl0Eb70WkWFysZZZN5zVxcj8=; b=n7RBxXnKaIuUHsrO3pEzNrCe2VUz1ZgFhnF0Nx6M/QWBz8UZpLsKck6bgvdbIV7iL+/PJWUa/BDLDKxUm9Cj7o2b7LYeYSQ0V+AvoqLAMhm99linKlex7kVTIohJGGtK4wPMhwtCJbNhcJoASeqasZnOc1d7LivuM110NaqiQ9Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UtdhWz7LP0lcTRHhFxIcgiXxrSgFDYksRJQQXA+/7OcT+7SSqbz271u5eX8ffaCDag0NFEcy19LzslbmbFtCLb4CCIF608Sj5t/FqcheKgT4Zfkil6hD16FXji38IIzbE2pu81W+W0H5Udz2HSk6/FT1POeyJ6yQOwd6Im7Amxaqo8UU+vupWz/2/y80hQEINOYTFRRw8loeMRjp6usiR1k9PsrmYiwH0L1QTfU9yMYKGsBs+3ZjCiZ8c6eztU7Uvrkn0IZ5HQ4ejZWfkxX+JJ6TqSzYLacXKglKxumT+R/JAyicgRQcRtahddV/vR1GDUdznZ0giza46uE4kVA/lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XYg/79oVlrrf7AsOftIZl0Eb70WkWFysZZZN5zVxcj8=; b=k72UNqZUW/otQ4uPVTZ7E/Tn0z3B/Jh0hMCE1TNgAiUHj+pdhBYyB5XoGnJFE+uCHF8b0rGgYrk+s9p21qkgcWOZuGJoBnhDPqcizlZcs3CkDV0R2eAgtuhkbSRP8v2ZeSsrF+XBh6kuh2h2NXexhWH7yhodkfRjKlKmTg9YtnHVWu2THr8G/KfTZ5dO3uh7yy+BBsrkbd6H0XWKHxOJJs4DxUrwayyPsKdgw3Zd63u29+ah8scD7s89N3dtwxvOLXVUaV+hHyWpEjQ8hlz280nb043AUFonIkiLKgB42fyqQxX+1r/CWoxcLJb/PPL5RcADvEY4CcYIuDGt554p/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XYg/79oVlrrf7AsOftIZl0Eb70WkWFysZZZN5zVxcj8=; b=n7RBxXnKaIuUHsrO3pEzNrCe2VUz1ZgFhnF0Nx6M/QWBz8UZpLsKck6bgvdbIV7iL+/PJWUa/BDLDKxUm9Cj7o2b7LYeYSQ0V+AvoqLAMhm99linKlex7kVTIohJGGtK4wPMhwtCJbNhcJoASeqasZnOc1d7LivuM110NaqiQ9Y= From: Henry Wang To: Julien Grall , Wei Chen , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build Thread-Topic: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build Thread-Index: AQHY8DVtbyg+f3V3FU++xEj+lazfQ64yQiqAgABu86A= Date: Mon, 7 Nov 2022 01:33:38 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-3-wei.chen@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 935DD181C9BA4F478BEE78BB7C0D47C3.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB9PR08MB6620:EE_|DBAEUR03FT017:EE_|GV2PR08MB8195:EE_ X-MS-Office365-Filtering-Correlation-Id: 2767f756-0da9-4ee8-2375-08dac0601e0c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: apj1CtXiDFErOK95c+rS8zK/keM2ibzThT0KxsvUkka9P2B7nT31OFSYd+pYyrc/GFTj6dIfDZOR0pIpwjOOeSrstWixTB2TWXURK0PwvAkZt0y0pjLysqun+QowAujQf6qsugYiVwT6iWJ/5UufTmfrTaEUySo0nz3YII7Z+5CTpgU2yvVfQ/olfJaYIXzuQrdOQNL7IuRUZtvhpTCOb7qQTv4IZoQfKhLJxjNV09sX6hXuI/LaJo18Nk+5GCF2aHb4VyBJ33qgOfVtBOtaYATT2SOBPvPxVRJ5rT5y18ZM3hO6xLRHoUYNFSucvfNE6TTNMDVrys6rJ6RNHvLmjkuR1IPTsIDVZcIXBoiFkQo7irdXF7w7a1cz2NpAOSO9PIBlLZl534aqFwFxoxxIuy8fvV0T1ggmQxoYLnD2twuMTde1jmGzE5/FQbotYYdr9pmNzNUgoym+hWPkGji1Re4wuIJj57IyxELyYpuAaym1B4Y+4o4SlB+3iOmS7JdaTvVJSeW6u6eyKXH5fV9FoOlSdyMDbGvVqhM4CsoTela//PeqLmX5Q5yK9fAz00jLgaPIflTndC3bLJ9vdjlh8HBoH0505qak3ESRCKRqSbo1iV1jnhWkbAEYiKhyqixAqrR8owStXmhVRtkXwZ09NRhzx1aj700WwOxIxLnzyE0VPr8vNnF2wT4QT+NmnjNLQGhivZXAwFFctpQZjVLx9voeBmVih4g9PdGKzq5cntDKW267T9qhFld60DLcxOG0f8J4tj/NTxl38ahZltB2bQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(39850400004)(376002)(366004)(451199015)(33656002)(8936002)(5660300002)(83380400001)(66556008)(316002)(4744005)(41300700001)(2906002)(66946007)(64756008)(66476007)(52536014)(76116006)(478600001)(66446008)(54906003)(8676002)(110136005)(71200400001)(4326008)(186003)(38100700002)(55016003)(38070700005)(26005)(6506007)(7696005)(86362001)(122000001)(9686003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6620 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0ffa36d7-7416-43fb-4edc-08dac06018b9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hN+TvC2FFxOHWtQ6DbAocWK51dvTtCCF7iaoM7l47XjeCOdGMBz/9f+G4/MKdnzddp5NDQhClRPhRqbKkrWgMu6w+Oyc1FgSHA+EPrnQ+naGPtiN6aLLUHap5BzOmd5rdOx/N6dCe5OfbPkyPU/CNdDxMyqeehoY5ncW53x1JuoiPcjWSXn5WITfCg7QgoASvI23bTompX02CllcaYJZk84km31CjyFjKliT0riRpZI9Fg0AxHq+CzO48JpQiAtYnjQI15j+OJSUavGqQdi9XK1Ap+AKdOT4j3ZRLE+9uD+0y52bUY5lZnyXyxfz4UkyaQ4JdaV82MHKxqfhjU6BjJgkgGcIwy0De3lbOhpoYb5/ggYAVLzwC4HyI5kycv0YKxUJ1gGYqxRk+gMGsyn7F/YSA7aTY27jQ00Ro0TaAmLJSYCa0GrTOlpQmwRjFn4GaVQ5mc1AvQrzC1xTSfoBQwSe6b3PStcdr/M3wsexpkMhasq1t3j7A3yzSN4IHcKyL+3eyafKledZzHtOAESpm0dWaytdyiSjSEj957OCoNS7Kq4/XcqUvR+KQKgiBD3jVCMubob9RvOwoLKpQRXcwzTxxCnSX9IoYX6kWMkQrmBazh3hlOQrXwt7ZwMxYR456AIlrKZfHNXMNavvmrVoOx7fKRTtyWaUiTVWdvQO/LOb6/KT2wE+UyKPeeCmv8EC/6jUH3VplBRdVSmj+q1l8J4+FLOrz8yGZ/4MgfWmZ1Hpg5e5Dg2pM8DvXzrOSirU X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39850400004)(136003)(396003)(376002)(451199015)(36840700001)(46966006)(478600001)(2906002)(33656002)(316002)(82740400003)(41300700001)(70586007)(52536014)(8676002)(70206006)(4326008)(5660300002)(4744005)(55016003)(40480700001)(110136005)(54906003)(8936002)(81166007)(83380400001)(356005)(36860700001)(7696005)(6506007)(86362001)(107886003)(47076005)(186003)(336012)(9686003)(26005)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 01:33:47.9851 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2767f756-0da9-4ee8-2375-08dac0601e0c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8195 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFJl OiBbUEFUQ0ggdjYgMDIvMTFdIHhlbi9hcm06IGFkZCBpb3VubWFwIGFmdGVyIGluaXRyZCBoYXMg YmVlbg0KPiBsb2FkZWQgaW4gZG9tYWluX2J1aWxkDQo+IA0KPiAoKyBIZW5yeSkNCj4gSSB0aGlu ayB0aGlzIHdhbnRzIHRvIGJlIGluIDQuMTcuIFRoaXMgd2lsbCBhdm9pZCBYZW4gdG8gaGF2ZSB0 d28NCj4gbWFwcGluZ3Mgd2l0aCBkaWZmZXJlbnQgY2FjaGluZyBhdHRyaWJ1dGUgKGluaXRyZCBp cyBwYXJ0IG9mIHRoZSBSQU0gYW5kDQo+IHRoZXJlZm9yZSBkaXJlY3RtYXApLg0KDQpTb3VuZHMg Z29vZCB0byBtZSwgSSBhbSB3b25kZXJpbmcgaWYgd2UgbmVlZCB0byBpbmNsdWRlIGFsc28gcGF0 Y2ggIzEgdGhvdWdoLg0KDQpJZiB0aGlzIHBhdGNoIHdhbnRzIHRvIGJlIGluIDQuMTc6DQoNClJl bGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4NCg0KS2luZCBy ZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxs DQoNCg== From xen-devel-bounces@lists.xenproject.org Mon Nov 07 03:44:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 03:44:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439048.692989 (Exim 4.92) (envelope-from ) id 1ort3c-0002hd-A6; Mon, 07 Nov 2022 03:44:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439048.692989; Mon, 07 Nov 2022 03:44:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ort3c-0002hU-43; Mon, 07 Nov 2022 03:44:20 +0000 Received: by outflank-mailman (input) for mailman id 439048; Mon, 07 Nov 2022 03:44:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ort3b-0002hL-RO; Mon, 07 Nov 2022 03:44:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ort3b-0001KW-Nf; Mon, 07 Nov 2022 03:44:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ort3b-0005OK-CR; Mon, 07 Nov 2022 03:44:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ort3b-0001wy-8T; Mon, 07 Nov 2022 03:44:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pZPRyTkHMCybhb/NP0w9MYa5OX+iqzzQzoTJsP2q46M=; b=WkTnxuYewfReOHbMt9TCScxw9r Qxf+Qf0e6SSuY+p5RmtqSPD8mvqWRETY77moUgj56/jRGqjB9tds1BghtQbGTm53eOB4iSNyF5Ty1 Hf17XKydWijWhdNUDhSG1aj2S2RnmJ5ylpNpRxtjMpbAQyqw2G9Lf1E0wVQ49EJ7JKCs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174649: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=2f5065a0bc9d0afb45f2ae284bd525d55ce82c33 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Mon, 07 Nov 2022 03:44:19 +0000 flight 174649 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174649/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 2f5065a0bc9d0afb45f2ae284bd525d55ce82c33 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 30 days Failing since 173470 2022-10-08 06:21:34 Z 29 days 47 attempts Testing same since 174639 2022-11-05 22:12:42 Z 1 days 3 attempts ------------------------------------------------------------ 1584 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 150603 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Nov 07 04:25:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 04:25:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439058.693000 (Exim 4.92) (envelope-from ) id 1orthh-0008Kt-Fj; Mon, 07 Nov 2022 04:25:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439058.693000; Mon, 07 Nov 2022 04:25:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orthh-0008Km-Ca; Mon, 07 Nov 2022 04:25:45 +0000 Received: by outflank-mailman (input) for mailman id 439058; Mon, 07 Nov 2022 04:25:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orthg-0008Kc-Oo; Mon, 07 Nov 2022 04:25:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orthg-0002jN-Jd; Mon, 07 Nov 2022 04:25:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orthg-0007j2-5T; Mon, 07 Nov 2022 04:25:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orthg-0005Yr-4w; Mon, 07 Nov 2022 04:25:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VBIqWfnW7n616eTH7jKU7dbntqekeVW9qgzf2/GFf04=; b=I2YJMrUW1a7EQo5AVEb7X+R+L6 l+4FWZFv457k2qQypRuOePi/JOzrLjx8k1WioXWzIxm4O8tSvoq4fGtv7ed/rGoWCEQBJaU71Wg8k N9a/Sqk39cu8uwO4mIkxOmDl3ZiLbY5qgwMC5heiAS/fZ0LIuvyJZej2zPAZn07CW4sw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174650: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm::broken:regression linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:build-arm64-pvops:kernel-build:fail:regression linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-xsm:xen-boot:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start.2:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:redhat-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a0d9384967214783a92973c920092b7251c03e57 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Mon, 07 Nov 2022 04:25:44 +0000 flight 174650 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174650/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm broken test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 build-arm64-pvops 6 kernel-build fail in 174642 REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 5 host-install(5) broken pass in 174646 test-amd64-i386-pair 11 xen-install/dst_host fail in 174638 pass in 174650 test-amd64-i386-libvirt-xsm 8 xen-boot fail in 174638 pass in 174650 test-armhf-armhf-xl-rtds 14 guest-start fail in 174638 pass in 174650 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174638 pass in 174650 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 174642 pass in 174646 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail in 174642 pass in 174650 test-amd64-i386-pair 10 xen-install/src_host fail in 174642 pass in 174650 test-armhf-armhf-xl-credit2 14 guest-start fail in 174642 pass in 174650 test-armhf-armhf-libvirt-raw 13 guest-start fail in 174642 pass in 174650 test-armhf-armhf-xl-credit1 19 guest-start.2 fail in 174646 pass in 174638 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 174646 pass in 174642 test-amd64-i386-qemuu-rhel6hvm-amd 12 redhat-install fail in 174646 pass in 174650 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 174646 pass in 174650 test-armhf-armhf-libvirt-qcow2 13 guest-start fail in 174646 pass in 174650 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 174642 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail pass in 174646 test-armhf-armhf-xl-credit1 14 guest-start fail pass in 174646 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 174642 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 174642 n/a test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 174646 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 174646 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux a0d9384967214783a92973c920092b7251c03e57 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 8 days Failing since 174575 2022-11-01 18:42:39 Z 5 days 10 attempts Testing same since 174608 2022-11-03 19:46:50 Z 3 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anssi Hannula Arnaldo Carvalho de Melo Biju Das Brian Foster Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Darrick J. Wong Darrick J. Wong Dave Chinner David S. Miller Demi Marie Obenour Dongliang Mu Eric Dumazet Florian Fainelli Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hannu Hartikainen Hans Verkuil Heiko Carstens Helge Deller Hyong Youb Kim Hyunwoo Kim Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jeff Vanhoof Jens Glathe Jimmy Assarsson Johan Hovold Jon Hunter Jon Maloy Jonathan Cameron Josh Poimboeuf Juergen Gross Justin Chen Konrad Jankowski Kuogee Hsieh Leon Romanovsky Linux Kernel Functional Testing Luiz Capitulino M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Michal Jaron Mike Kravetz Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Paolo Abeni Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rik van Riel Saeed Mahameed Sakari Ailus Sasha Levin Shreeya Patel Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Thinh Nguyen Tom Lendacky Tony O'Brien Ulf Hansson Vasily Gorbik Vineet Gupta Vladimir Oltean Wei Yongjun Xin Long Yang Yingliang Yongqin Liu Zhang Changzhong Zhengchao Shao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm broken test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm broken broken-step test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm host-install(5) Not pushing. (No revision log; it would be 2244 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Nov 07 06:59:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 06:59:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439067.693011 (Exim 4.92) (envelope-from ) id 1orw6b-00010t-H1; Mon, 07 Nov 2022 06:59:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439067.693011; Mon, 07 Nov 2022 06:59:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orw6b-00010m-Dg; Mon, 07 Nov 2022 06:59:37 +0000 Received: by outflank-mailman (input) for mailman id 439067; Mon, 07 Nov 2022 06:59:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orw6a-00010g-CE for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 06:59:36 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2070.outbound.protection.outlook.com [40.107.22.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bbaf0ebb-5e69-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 07:59:33 +0100 (CET) Received: from DU2PR04CA0071.eurprd04.prod.outlook.com (2603:10a6:10:232::16) by DU0PR08MB8162.eurprd08.prod.outlook.com (2603:10a6:10:3ed::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 06:59:30 +0000 Received: from DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:232:cafe::27) by DU2PR04CA0071.outlook.office365.com (2603:10a6:10:232::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 06:59:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT043.mail.protection.outlook.com (100.127.143.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 06:59:29 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Mon, 07 Nov 2022 06:59:29 +0000 Received: from d306dc427a12.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 340A1E76-0F89-4B82-8D9B-C24C98A58167.1; Mon, 07 Nov 2022 06:59:22 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d306dc427a12.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Nov 2022 06:59:22 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by PAVPR08MB8968.eurprd08.prod.outlook.com (2603:10a6:102:32f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 06:59:20 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::461b:c1cb:368c:707e]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::461b:c1cb:368c:707e%5]) with mapi id 15.20.5813.011; Mon, 7 Nov 2022 06:59:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbaf0ebb-5e69-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=G6z5p37CVG/+wO3SVoxJj6F9NZj8njfrAfIT/P8aFltqhc8Vhr6Xmv7XsykiUE/p/4S1OYA0ozn+900JJwFbhfN7T770+1bqrLu1rCcbfbsCoJdGM92ja/RFyRNYWVMITgqrxhZRcOGBWhbyDr8CAp3sMuyAAVaGd0E5Hqsnvcg7wegJkpFSTRukdogRkTUmGMQVfc80k6nusBNJmHP/FtI7FSIvPsbmBK1435LMAIozZCkzNzhMYSup4SjeoPXgs410l0GpaxFi1Os+EcbkVxtUGf/yGDp7kjLl1205nH0uxF3vCYCiflzI4x0B3geovxT9eg6v9X/GJXOAJeSrTw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vfzh4TmudQq2BGx/noNa/9sVtAL3HEFY2VVixlJQA0Q=; b=Y38OFjh9YhGk3WSrRc/GiwK3fYf0uVOZLJCLgdHMWamrzYQWY5aVK2CZpu5Z20vEl8wo7Ye2saBa5CV9KXvbE8UwBvbpK/YNR1Bm/cyPXoYuwRaNJgOunm+rxbjcqRNvdFHC3R1tLeMYhOLnuOpeY5adzH2L89MlsuMoGnjiK1gz8KWyTbHSrG/sVcc3dCrr6XrOjizIM1YYCAtccifJd96bJrbdriDhjKQFFSrQZAwODAmbDpa6+Iv08jkHrSi83hZTzudGBe87izi80Ikd7Oo22Bw3+Wb5kiZOll63VgZF+I9O5XTslkahiCYpHP8uaJnRxe8LM2VKE86rxaC1YA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vfzh4TmudQq2BGx/noNa/9sVtAL3HEFY2VVixlJQA0Q=; b=t8GJj8wJ5QsNHZdIVJfNEnlwPZd+gMPIjDrGNvi0wpkHYejCLH5mOFCsqacj7C/ybObd8MdrIolfbUNeEpLwgLweuaXXWss1wat9JsPaFQz+oZ+tpCIHywtb2lgolXarynT9j0KKNElHMDdrOJ4v+iczcv4Nhk7PYLZ3OIc2rGg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QdxGlpWLN9u+jQ2TetqiuYzeTVKEwKB0EE6+TzMwCy6AX8FjFVySXCs+fQGNxrq1ejrIepUJ7+nK527/TvtKQWwvRcMkvPjc0ysdGAGvQL08zV+KLK+672DxnZ+EXFhC157rURkU3REoD9jsJ2j+d77qVXKj/XQkBsnWylhA+L+i/i5GbGvgE4gkR6ptL9PEVs9DzVYxWSaLCqKRS3Um+I8MghgTBdqIXJOy+9rg3Dpt3sKiAoJNu5DjXoOsI5AC/jWFKQKHYtCWTJKJioyWJXCR7lv9MellZrwdUXEoL05MkYPC5dO07EoYgK2OpRINjzBefST7dCAaOVk3p3xrSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vfzh4TmudQq2BGx/noNa/9sVtAL3HEFY2VVixlJQA0Q=; b=dS4jzHvWtfFs+ZzGyAtUCEtpWzQp+av2YneopRjtvJ4Y82JS1S+MY3Gd2gDduFaK+zP8KYeZ4sQ9dM1jILdnAy00VMws13mhkFpH1VSOBh9qGZuD/wQzSbLPoj1nAzGZAR51zIIU4mYL/D8PxkQF5Jkuc6J4E0YKWLo63AzsvJu+WZwTkggAyP3jYKGtTdciiMPGuOyvXL90aCyHwXZGAtIgWpT8LZzyxVUKpjVegBm4Hffaxl5WUEXdlOmJ82/swDVazsfEeeYN6sTuyqpTcAy2qxvxQ8ucob0Qda2YFm3brD2cOAlghLPl9e4MHOBvOp4oD9mUlwLAkAobUZA+fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vfzh4TmudQq2BGx/noNa/9sVtAL3HEFY2VVixlJQA0Q=; b=t8GJj8wJ5QsNHZdIVJfNEnlwPZd+gMPIjDrGNvi0wpkHYejCLH5mOFCsqacj7C/ybObd8MdrIolfbUNeEpLwgLweuaXXWss1wat9JsPaFQz+oZ+tpCIHywtb2lgolXarynT9j0KKNElHMDdrOJ4v+iczcv4Nhk7PYLZ3OIc2rGg= From: Penny Zheng To: Julien Grall , Wei Chen , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 09/11] xen/arm64: create boot-time MPU protection regions Thread-Topic: [PATCH v6 09/11] xen/arm64: create boot-time MPU protection regions Thread-Index: AQHY8DVssS7ibAAWlEawRuPWKxX+kq4yYWYAgACZqiA= Date: Mon, 7 Nov 2022 06:59:19 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-10-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 728EFBF6DAB0C64DAEEF705F110212DE.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|PAVPR08MB8968:EE_|DBAEUR03FT043:EE_|DU0PR08MB8162:EE_ X-MS-Office365-Filtering-Correlation-Id: cbdf1dc0-9fc5-4421-eaab-08dac08d9dd5 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JcFCRZedt7AZ2Cp8wUeTQqNf9DXWFFMNErcAMreBjTmOOWlok5Q4mP0iKcgkSPsA+sYlRqgkG86fkGUT14cdZ1WJDttGczJhI1w/JGe+3bpcGEaLDWTH2PyHu+neL+mWKiZlGsIw80+DsKZZ5ZFYMjtZ8cDHNDsdKBtlxbVpFktk2cMHxKKkPgMffto7VQOeZCQi99ysfa/nzwTU16mI0uSmDUY0VsXuxctUNOD66sQUR0NwICl3I6YW3hPtPVPca+Pl3wbqmMN51YXKRyRh5ZYRtebXa6wDUg2YvbFO8WxFSPCQqVkq+E0fnrBq7K0CNI2poJRZVFD4BjdIXv1l0A44Vshzm27vGZL+Hi9u9psTadb1zTZSzoXo0JCk6QozZ9pL5AUVarLQwiHnqk9uBQls3mIDqSUoHN0NL4YZjj/lurdnx9QfT3180FL84xjUKhSNVs+8C6FtvUdLOHCsPEmZaTGuMK5GD41aSxrXEhuTT5DXu6cUyI6kLZLcdUygw2epK+A7wQEtI9IXNkxiUm7eYtb7MyMa9Pu7++GnGd5JPdYUvE52hcMw7P5QZhPTiaMX9n5+15kAYX4smK6GQMIn3r/vAbjMHVso2Fp0GEcVwoqZNBYqPYoc7klj6fYqZnLkdplWwGBktr8zG5AylrKmXdiTKELuV04VB1/9MIUDI2QJG1igSr+Z5awF3iK6Yl4kcuzb/K/oBqdpBATU/8L1ffvRbJy6BZSUuM/zObK9U9BGrqqSlAtefU9JMADstvxMuNJ17L+edq1f9j4bJ/8anhcNn/CB5zybnJxI7dU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(346002)(136003)(376002)(396003)(451199015)(5660300002)(30864003)(41300700001)(8936002)(7696005)(6506007)(966005)(71200400001)(316002)(55016003)(64756008)(66946007)(4326008)(66556008)(66476007)(76116006)(8676002)(66446008)(122000001)(2906002)(38100700002)(110136005)(33656002)(54906003)(83380400001)(38070700005)(86362001)(52536014)(53546011)(26005)(186003)(478600001)(9686003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB8968 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0f51165b-0f63-4143-4992-08dac08d97cf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zgllrrh+PddOcUN50ZyjhsLU65MVJRl4SrOxNDUsUCJrjXGBaXjDpxswfNMAq/MSDL+7a2UWilwi6PmIAgDE69I3gImQ+9mrwdb0kNDGVTG7LgGRumszhManzPeU/82isdibiMTZd7q7U8DqnfDRx4MBi0mgvBJJpyhVfKLUhMyO2/dPumWCpKhdg5cYBuDYKJEsGBk24v31HHt2LPwd7iVIaefOzarHe/kIe5Z5qH4aHyCrVpCpBgKSAZtwplSWdAvzsOOkCEOuLuYOCgRzJbRcElcVWuWEOjgNbMdwnLAFc/oDxpoFQOghj8f/Z3W0QY4bLrxcH3ZAcrhxWCef/iBI+ffDTRP95PI2xLiPVKI/X+hbbHwGw9RkLB+cgVUPiVPk6dn2crvPIE5oWp/BKVzYpgJo+qV0tlwFtGPJAr+w6svThMf2WdEqLtCqj9cS/A+IPMWlmPtGN9dxNyjx1dhpJhBNHNVJHVA7UhaH7xFAuy+Og6ejUQ/M0zbO8gsj33spUpJxSBF+554Kijj8cxpfUlncR8QDC836RZZtw43rHyJwKDhuvo72hCOLRVJLEDLA/t9TXRPJ62YsmOIkxJz1hG5qca0Xr+L3Ew+/Q9wxF+DI8Y6jZV49lm/3vSLhrySexOyr1oPncB1uv/GFfT8d3mqaUvXSV1kbt+L0sAVCeZjdsuL1jzeLSAzLovAi11mjQbfolcrBw8rCTbylKCiVC5enAlbO6lrKdTQG/UErYO3F4eNPUuhdd62/haaF429RP/Q+7F3ZyKDdZNJJI5zk/a5PnX9xoBG33JqfITQOtLQJh0gUhaRSkMXqGzAG X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(40480700001)(33656002)(40460700003)(81166007)(478600001)(966005)(26005)(8936002)(82740400003)(86362001)(36860700001)(82310400005)(41300700001)(55016003)(107886003)(53546011)(30864003)(52536014)(47076005)(186003)(356005)(7696005)(336012)(316002)(70206006)(70586007)(4326008)(6506007)(2906002)(5660300002)(54906003)(8676002)(83380400001)(9686003)(110136005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 06:59:29.7154 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cbdf1dc0-9fc5-4421-eaab-08dac08d9dd5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8162 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogTW9uZGF5LCBOb3ZlbWJlciA3LCAyMDIy IDQ6NDcgQU0NCj4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgeGVuLWRldmVsQGxp c3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBuZCA8bmRAYXJtLmNvbT47IFBlbm55IFpoZW5nIDxQ ZW5ueS5aaGVuZ0Bhcm0uY29tPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBr ZXJuZWwub3JnPjsgQmVydHJhbmQgTWFycXVpcw0KPiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29t PjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPiBT dWJqZWN0OiBSZTogW1BBVENIIHY2IDA5LzExXSB4ZW4vYXJtNjQ6IGNyZWF0ZSBib290LXRpbWUg TVBVIHByb3RlY3Rpb24NCj4gcmVnaW9ucw0KPiANCj4gSGkgV2VpLA0KPiANCj4gT24gMDQvMTEv MjAyMiAxMDowNywgV2VpIENoZW4gd3JvdGU6DQo+ID4gRnJvbTogUGVubnkgWmhlbmcgPHBlbm55 LnpoZW5nQGFybS5jb20+DQo+ID4NCj4gPiBMaWtlIGJvb3QtdGltZSBwYWdlIHRhYmxlIGluIE1N VSBzeXN0ZW0sIHdlIG5lZWQgYSBib290LXRpbWUgTVBVDQo+ID4gcHJvdGVjdGlvbiByZWdpb24g Y29uZmlndXJhdGlvbiBpbiBNUFUgc3lzdGVtIHNvIFhlbiBjYW4gZmV0Y2ggY29kZQ0KPiA+IGFu ZCBkYXRhIGZyb20gbm9ybWFsIG1lbW9yeS4NCj4gPg0KPiA+IFRoaXMgb3BlcmF0aW9uIG5lZWQg dG8gYWNjZXNzIEFybXY4LVIgTVBVIHN5c3RlbSByZWdpc3RlcnMsIGJ1dCB0aGVzZQ0KPiA+IHN5 c3RlbSByZWdpc3RlcnMgYXJlIG5vdCBzdXBwb3J0ZWQgaW4gR0NDIHZlcnNpb24gPCAxMS4NCj4g PiBTbyB3ZSBoYXZlIHRvIGVuY29kZSB0aGVzZSBBcm12OC1SIE1QVSBzeXN0ZW0gcmVnaXN0ZXJz IGluIGhlYWRlciBmaWxlDQo+ID4gZXhwbGljaXRseS4NCj4gPg0KPiA+IEFzIE1NVSBzeXN0ZW0g YW5kIE1QVSBzeXN0ZW0gaGF2ZSBkaWZmZXJlbnQgZnVuY3Rpb25zIHRvIGNyZWF0ZSB0aGUNCj4g PiBib290IE1NVS9NUFUgZGF0YSwgdGhpcyB3aWxsIGludHJvZHVjZSBleHRyYSAjaWZkZWYgaW4g Y29kZSBmbG93LCBzbw0KPiA+IHdlIGludHJvZHVjZSBhIG5ldXRyYWwgbmFtZSBwcmVwYXJlX2Vh cmx5X21hcHBpbmdzIHRvIHJlcGxhY2UNCj4gPiBjcmVhdGVfcGFnZV90YWJsZXMgZm9yIE1NVSBh bmQgTVBVLg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogV2VpIENoZW4gPHdlaS5jaGVuQGFybS5j b20+DQo+ID4gU2lnbmVkLW9mZi1ieTogUGVubnkgWmhlbmcgPHBlbm55LnpoZW5nQGFybS5jb20+ DQo+IA0KPiBJZiBQZW5ueSBpcyB0aGUgb3JpZ2luYWwgYXV0aG9yLCB0aGVuIGhlciBzaWduZWQt b2ZmLWJ5IHNob3VsZCBiZSBmaXJzdC4NCj4gDQo+ID4gLS0tDQo+ID4gICB4ZW4vYXJjaC9hcm0v YXJtNjQvTWFrZWZpbGUgICAgICAgICAgICAgIHwgIDIgKw0KPiA+ICAgeGVuL2FyY2gvYXJtL2Fy bTY0L2hlYWQuUyAgICAgICAgICAgICAgICB8IDEzICsrLS0NCj4gPiAgIHhlbi9hcmNoL2FybS9h cm02NC9oZWFkX21tdS5TICAgICAgICAgICAgfCAgNCArLQ0KPiA+ICAgeGVuL2FyY2gvYXJtL2Fy bTY0L2hlYWRfbXB1LlMgICAgICAgICAgICB8IDcwICsrKysrKysrKysrKysrKysrKysNCj4gPiAg IHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9hcm02NC9tcHUuaCAgICAgfCAxMyArKysrDQo+ID4g ICB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vYXJtNjQvc3lzcmVncy5oIHwgODkNCj4gKysrKysr KysrKysrKysrKysrKysrKysrDQo+ID4gICA2IGZpbGVzIGNoYW5nZWQsIDE4NSBpbnNlcnRpb25z KCspLCA2IGRlbGV0aW9ucygtKQ0KPiA+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2Fy bS9hcm02NC9oZWFkX21wdS5TDQo+ID4gICBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJt L2luY2x1ZGUvYXNtL2FybTY0L21wdS5oDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gv YXJtL2FybTY0L01ha2VmaWxlDQo+IGIveGVuL2FyY2gvYXJtL2FybTY0L01ha2VmaWxlDQo+ID4g aW5kZXggMjJkYTJmNTRiNS4uNDM4Yzk3MzdhZCAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9h cm0vYXJtNjQvTWFrZWZpbGUNCj4gPiArKysgYi94ZW4vYXJjaC9hcm0vYXJtNjQvTWFrZWZpbGUN Cj4gPiBAQCAtMTAsNiArMTAsOCBAQCBvYmoteSArPSBlbnRyeS5vDQo+ID4gICBvYmoteSArPSBo ZWFkLm8NCj4gPiAgIGlmbmVxICgkKENPTkZJR19IQVNfTVBVKSx5KQ0KPiA+ICAgb2JqLXkgKz0g aGVhZF9tbXUubw0KPiA+ICtlbHNlDQo+ID4gK29iai15ICs9IGhlYWRfbXB1Lm8NCj4gPiAgIGVu ZGlmDQo+ID4gICBvYmoteSArPSBpbnNuLm8NCj4gPiAgIG9iai0kKENPTkZJR19MSVZFUEFUQ0gp ICs9IGxpdmVwYXRjaC5vIGRpZmYgLS1naXQNCj4gPiBhL3hlbi9hcmNoL2FybS9hcm02NC9oZWFk LlMgYi94ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZC5TIGluZGV4DQo+ID4gZDlhOGRhOTEyMC4uNmMx YTVmNzRhMSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZC5TDQo+ID4g KysrIGIveGVuL2FyY2gvYXJtL2FybTY0L2hlYWQuUw0KPiA+IEBAIC03OSwxMiArNzksMTIgQEAN Cj4gPiAgICAqIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+ICAgICoNCj4gPiAgICAq IFRoZSByZXF1aXJlbWVudHMgYXJlOg0KPiA+IC0gKiAgIE1NVSA9IG9mZiwgRC1jYWNoZSA9IG9m ZiwgSS1jYWNoZSA9IG9uIG9yIG9mZiwNCj4gPiArICogICBNTVUvTVBVID0gb2ZmLCBELWNhY2hl ID0gb2ZmLCBJLWNhY2hlID0gb24gb3Igb2ZmLA0KPiA+ICAgICogICB4MCA9IHBoeXNpY2FsIGFk ZHJlc3MgdG8gdGhlIEZEVCBibG9iLg0KPiA+ICAgICoNCj4gPiAgICAqIFRoaXMgbXVzdCBiZSB0 aGUgdmVyeSBmaXJzdCBhZGRyZXNzIGluIHRoZSBsb2FkZWQgaW1hZ2UuDQo+ID4gICAgKiBJdCBz aG91bGQgYmUgbGlua2VkIGF0IFhFTl9WSVJUX1NUQVJULCBhbmQgbG9hZGVkIGF0IGFueQ0KPiA+ IC0gKiA0Sy1hbGlnbmVkIGFkZHJlc3MuICBBbGwgb2YgdGV4dCtkYXRhK2JzcyBtdXN0IGZpdCBp biAyTUIsDQo+ID4gKyAqIDRLLWFsaWduZWQgYWRkcmVzcy4gQWxsIG9mIHRleHQrZGF0YStic3Mg bXVzdCBmaXQgaW4gMk1CLA0KPiANCj4gVGhlIGRvdWJsZSBzcGFjZSBhZnRlciB0aGUgZmluYWwg cG9pbnQgd2FzIHZhbGlkLiBUaGlzIGlzIGZhaXJseSBjb21tb24gdG8gdXNlDQo+IGl0IGFuZCB0 aGlzIGlzIGEgc3B1cmlvdXMgY2hhbmdlLg0KPiANCj4gDQo+ID4gICAgKiBvciB0aGUgaW5pdGlh bCBwYWdldGFibGUgY29kZSBiZWxvdyB3aWxsIG5lZWQgYWRqdXN0bWVudC4NCj4gPiAgICAqLw0K PiA+DQo+ID4gQEAgLTI0OSw3ICsyNDksMTIgQEAgcmVhbF9zdGFydF9lZmk6DQo+ID4NCj4gPiAg ICAgICAgICAgYmwgICAgY2hlY2tfY3B1X21vZGUNCj4gPiAgICAgICAgICAgYmwgICAgY3B1X2lu aXQNCj4gPiAtICAgICAgICBibCAgICBjcmVhdGVfcGFnZV90YWJsZXMNCj4gPiArDQo+ID4gKyAg ICAgICAgLyoNCj4gPiArICAgICAgICAgKiBDcmVhdGUgYm9vdCBtZW1vcnkgbWFuYWdlbWVudCBk YXRhLCBwYWdldGFibGUgZm9yIE1NVQ0KPiBzeXN0ZW1zDQo+ID4gKyAgICAgICAgICogYW5kIHBy b3RlY3Rpb24gcmVnaW9ucyBmb3IgTVBVIHN5c3RlbXMuDQo+ID4gKyAgICAgICAgICovDQo+IA0K PiBoZWFkLlMgaXMgbm93IG1lYW50IHRvIGJlIGdlbmVyaWMuIFNvIEkgd291bGQgcHJlZmVyIGlm IHdlIGtlZXAgY29tbWVudA0KPiBhcyBnZW5lcmljIGFzIHBvc3NpYmxlLiBJT1csIGFueXRoaW5n IGFmdGVyIHRoZSBmaXJzdCBjb21tYSBzaG91bGQgYmUNCj4gZHJvcHBlZC4NCj4gDQo+ID4gKyAg ICAgICAgYmwgICAgcHJlcGFyZV9lYXJseV9tYXBwaW5ncw0KPiA+ICAgICAgICAgICBibCAgICBl bmFibGVfbW11DQo+ID4NCj4gPiAgICAgICAgICAgLyogV2UgYXJlIHN0aWxsIGluIHRoZSAxOjEg bWFwcGluZy4gSnVtcCB0byB0aGUgcnVudGltZSBWaXJ0dWFsDQo+IEFkZHJlc3MuICovDQo+ID4g QEAgLTMwNyw3ICszMTIsNyBAQCBHTE9CQUwoaW5pdF9zZWNvbmRhcnkpDQo+ID4gICAjZW5kaWYN Cj4gPiAgICAgICAgICAgYmwgICAgY2hlY2tfY3B1X21vZGUNCj4gPiAgICAgICAgICAgYmwgICAg Y3B1X2luaXQNCj4gPiAtICAgICAgICBibCAgICBjcmVhdGVfcGFnZV90YWJsZXMNCj4gPiArICAg ICAgICBibCAgICBwcmVwYXJlX2Vhcmx5X21hcHBpbmdzDQo+ID4gICAgICAgICAgIGJsICAgIGVu YWJsZV9tbXUNCj4gPg0KPiA+ICAgICAgICAgICAvKiBXZSBhcmUgc3RpbGwgaW4gdGhlIDE6MSBt YXBwaW5nLiBKdW1wIHRvIHRoZSBydW50aW1lIFZpcnR1YWwNCj4gQWRkcmVzcy4gKi8NCj4gPiBk aWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2FybTY0L2hlYWRfbW11LlMNCj4gYi94ZW4vYXJjaC9h cm0vYXJtNjQvaGVhZF9tbXUuUw0KPiA+IGluZGV4IDFhM2RmODFhMzguLmZjNjQ4MTlhOTggMTAw NjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gvYXJtL2FybTY0L2hlYWRfbW11LlMNCj4gPiArKysgYi94 ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZF9tbXUuUw0KPiA+IEBAIC0xMjMsNyArMTIzLDcgQEANCj4g PiAgICAqDQo+ID4gICAgKiBDbG9iYmVycyB4MCAtIHg0DQo+ID4gICAgKi8NCj4gPiAtRU5UUlko Y3JlYXRlX3BhZ2VfdGFibGVzKQ0KPiA+ICtFTlRSWShwcmVwYXJlX2Vhcmx5X21hcHBpbmdzKQ0K PiA+ICAgICAgICAgICAvKiBQcmVwYXJlIHRoZSBwYWdlLXRhYmxlcyBmb3IgbWFwcGluZyBYZW4g Ki8NCj4gPiAgICAgICAgICAgbGRyICAgeDAsID1YRU5fVklSVF9TVEFSVA0KPiA+ICAgICAgICAg ICBjcmVhdGVfdGFibGVfZW50cnkgYm9vdF9wZ3RhYmxlLCBib290X2ZpcnN0LCB4MCwgMCwgeDEs IHgyLCB4Mw0KPiA+IEBAIC0yMDgsNyArMjA4LDcgQEAgdmlydHBoeXNfY2xhc2g6DQo+ID4gICAg ICAgICAgIC8qIElkZW50aXR5IG1hcCBjbGFzaGVzIHdpdGggYm9vdF90aGlyZCwgd2hpY2ggd2Ug Y2Fubm90IGhhbmRsZSB5ZXQNCj4gKi8NCj4gPiAgICAgICAgICAgUFJJTlQoIi0gVW5hYmxlIHRv IGJ1aWxkIGJvb3QgcGFnZSB0YWJsZXMgLSB2aXJ0IGFuZCBwaHlzIGFkZHJlc3Nlcw0KPiBjbGFz aC4gLVxyXG4iKQ0KPiA+ICAgICAgICAgICBiICAgICBmYWlsDQo+ID4gLUVORFBST0MoY3JlYXRl X3BhZ2VfdGFibGVzKQ0KPiA+ICtFTkRQUk9DKHByZXBhcmVfZWFybHlfbWFwcGluZ3MpDQo+ID4N Cj4gPiAgIC8qDQo+ID4gICAgKiBUdXJuIG9uIHRoZSBEYXRhIENhY2hlIGFuZCB0aGUgTU1VLiBU aGUgZnVuY3Rpb24gd2lsbCByZXR1cm4gb24gdGhlDQo+IDE6MQ0KPiA+IGRpZmYgLS1naXQgYS94 ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZF9tcHUuUw0KPiBiL3hlbi9hcmNoL2FybS9hcm02NC9oZWFk X21wdS5TDQo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gPiBpbmRleCAwMDAwMDAwMDAwLi5m NjA2MTFiNTU2DQo+ID4gLS0tIC9kZXYvbnVsbA0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9hcm02 NC9oZWFkX21wdS5TDQo+ID4gQEAgLTAsMCArMSw3MCBAQA0KPiA+ICsvLyBTUERYLUxpY2Vuc2Ut SWRlbnRpZmllcjogR1BMLTIuMC1vbmx5DQo+IA0KPiBDb2Rpbmcgc3R5bGU6DQo+IA0KPiAvKiBT UERYIC4uLiAqLw0KPiANCj4gPiArLyoNCj4gPiArICogU3RhcnQtb2YtZGF5IGNvZGUgZm9yIGFu IEFybXY4LVIgTVBVIHN5c3RlbS4NCj4gPiArICovDQo+ID4gKw0KPiA+ICsjaW5jbHVkZSA8YXNt L2FybTY0L21wdS5oPg0KPiA+ICsjaW5jbHVkZSA8YXNtL3BhZ2UuaD4NCj4gPiArI2luY2x1ZGUg PGFzbS9lYXJseV9wcmludGsuaD4NCj4gDQo+IEhlYWRlcnMgc2hvdWxkIGJlIGluY2x1ZGVkIGlu IGFscGhhYmV0aWNhbCBvcmRlci4NCj4gDQo+ID4gKw0KPiA+ICsvKg0KPiA+ICsgKiBGcm9tIHRo ZSByZXF1aXJlbWVudHMgb2YgaGVhZC5TIHdlIGtub3cgdGhhdCBYZW4gaW1hZ2Ugc2hvdWxkDQo+ ID4gKyAqIGJlIGxpbmtlZCBhdCBYRU5fU1RBUlRfQUREUkVTUywgYW5kIGFsbCBvZiB0ZXh0ICsg ZGF0YSArIGJzcw0KPiA+ICsgKiBtdXN0IGZpdCBpbiAyTUIuIE9uIE1QVSBzeXN0ZW1zLCBYRU5f U1RBUlRfQUREUkVTUyBpcyBhbHNvIHRoZQ0KPiA+ICsgKiBhZGRyZXNzIHRoYXQgWGVuIGltYWdl IHNob3VsZCBiZSBsb2FkZWQgYXQuIFNvIGZvciBpbml0aWFsIE1QVQ0KPiA+ICsgKiByZWdpb25z IHNldHVwLCB3ZSB1c2UgMk1CIGZvciBYZW4gZGF0YSBtZW1vcnkgdG8gc2V0dXAgYm9vdA0KPiA+ ICsgKiByZWdpb24sIG9yIHRoZSBjcmVhdGUgYm9vdCByZWdpb25zIGNvZGUgYmVsb3cgd2lsbCBu ZWVkIGFkanVzdG1lbnQuDQo+ID4gKyAqLw0KPiA+ICsjZGVmaW5lIFhFTl9TVEFSVF9NRU1fU0la RSAgICAgIDB4MjAwMDAwDQo+IA0KPiBJdCBzb3VuZHMgbGlrZSBzb21ldGhpbmcgdGhhdCBzaG91 bGQgYmUgZGVmaW5lZCBpbiB0aGUgaGVhZGVyLiBBbHNvLCBJDQo+IHRoaW5rIHRoZSBzaXplIHNo b3VsZCBiZSBjb21tb24gYmV0d2VlbiBNUFUgYW5kIE1NVS4NCj4gDQo+IEluIFsxXSwgSSB3YXMg Z29pbmcgdG8gbmFtZSBpdCBYRU5fVklSVF9TSVpFLiBJIHdvdWxkIGJlIE9LIHRvIHJlbW92ZQ0K PiAiVklSVCIgaW4gdGhlIG5hbWUuDQo+IA0KDQpUaHggYW5kIHBsZWFzZSwgdGhlbiBJIHdpbGwg cmVwbGFjZSBpdCB3aXRoIFhFTl9TSVpFDQoNCj4gPiArDQo+ID4gKy8qDQo+ID4gKyAqIEluIGJv b3Qgc3RhZ2UsIHdlIHdpbGwgdXNlIDEgTVBVIHJlZ2lvbjoNCj4gPiArICogUmVnaW9uIzA6IE5v cm1hbCBtZW1vcnkgZm9yIFhlbiB0ZXh0ICsgZGF0YSArIGJzcyAoMk1CKQ0KPiA+ICsgKi8NCj4g DQo+IEFyZSB3ZSBvbmx5IGdvaW5nIHRvIG1vZGlmeSB0aGUgTVBVIGluIGhlYWQuUz8gSWYgbm90 LCB0aGVuIEkgd291bGQNCj4gZGVmaW5lIHRoZSBsYXlvdXQgaW4gY29uZmlnX21wdS5oIHNvIHRo ZXJlIGFyZSBhIHNpbmdsZSBwb2ludCB3aGVyZSB5b3UNCj4gY2FuIHJlYWQgaG93IHRoaXMgd29y a3MuDQo+IA0KDQpXZSB3aWxsIHJlbWFwIFhlbiBpbiBDIGNvZGVzIGluIHNldHVwX21tKCkuDQpU aGUgd2hvbGUgc3RyYXRlZ3kgaXMgYWxpZ25lZCB3aXRoIE1NVTogYSB2ZXJ5IHNpbXBsZSBzZXR1 cChtYXAgeGVuDQp3aXRoIHRoZSBtYXhpbXVtIHNpemUsIDJNKSBhdCBzdGFydC1vZi10aGUtZGF5 LCBhbmQgYSBmaXQgbWFwIGluDQpzZXR1cF9tbS4NCg0KQWxsIHRoZSBmb2xsb3dpbmcgdmFyaWFi bGVzIHdpbGwgYmUgb25seSB1c2VkIGF0IGhlYWRfbXB1LlMuDQpJdCBpcyBub3QgdmVyeSBnZW5l cmljLCBsYXRlciwgd2hlbiBpbnRyb2R1Y2luZyBNUFUgbWVtb3J5IHJlZ2lvbg0KbWFuYWdlbWVu dCBpbiBDIGNvZGVzLCB3ZSB3aWxsIGRlZmluZSBkaWZmZXJlbnQgbWFjcm9zIGZvcg0KdmFyaW91 cyBtZW1vcnkgYXR0cmlidXRlcy4NCg0KPiA+ICsjZGVmaW5lIEJPT1RfTk9STUFMX1JFR0lPTl9J RFggIDB4MA0KPiA+ICsNCj4gPiArLyogTVBVIG5vcm1hbCBtZW1vcnkgYXR0cmlidXRlcy4gKi8N Cj4gPiArI2RlZmluZSBQUkJBUl9OT1JNQUxfTUVNICAgICAgICAweDMwICAgIC8qIFNIPTExIEFQ PTAwIFhOPTAwICovDQo+IA0KPiBJSVVDLCB0aGlzIG1lYW5zIHRoYXQgWGVuIHdpbGwgYmUgbWFw cGVkIHdyaXRlLWV4ZWN1dGFibGUuIElzIHRoaXMgZ29pbmcNCj4gdG8gYmUgZm9yZXZlcj8gSWYg bm90LCB3aGVuIGNhbid0IHdlIGFscmVhZHkgbWFwcGVkIFhlbiBwcm9wZXJseT8NCj4gDQoNCk5v LCB0aGlzIHNldHVwIGlzIHRoZSBzdGFydC1vZi1kYXkgc2V0dXAsIGFuZCB3aWxsIG9ubHkgbGFz dCBmb3IgYSB2ZXJ5IHNob3J0IHRpbWUuDQoNClRvIGJlIGFsaWduZWQgd2l0aCBNTVUgc3lzdGVt LCBpbiB3aGljaCBMMyBtZW1vcnkgYXR0cmlidXRlcyBpcyBhcyBmb2xsb3dzOg0KI2RlZmluZSBQ VF9NRU1fTDMgMHhmN2YgLyogbkc9MSBBRj0xIFNIPTExIEFQPTAxIE5TPTEgQVRUUj0xMTEgVD0x IFA9MSAqLw0KWGVuIHNoYWxsIGJlIG1hcHBlZCByZWFkLW9ubHktZXhlY3V0YWJsZSBoZXJlLCBh bmQgSSB3aWxsIGZpeCBpdC4NCg0KPiA+ICsjZGVmaW5lIFBSTEFSX05PUk1BTF9NRU0gICAgICAg IDB4MGYgICAgLyogTlM9MCBBVFRSPTExMSBFTj0xICovDQo+IA0KPiBUbyBtZSwgaXQgZmVlbHMg bGlrZSB0aGlzIHNob3VsZCBiZSBmaW5lZCBvdXRzaWRlIG9mIGhlYWQuUyBiZWNhdXNlIHRoaXMN Cj4gY291bGQgYmUgcmUtdXNlZCBieSBvdGhlciBwYXJ0IG9mIFhlbi4NCj4gDQoNCkl0IGlzIGxp a2UgUFRfTUVNX0wzIGluIGhlYWRfbW11LlMuIEl0IHdpbGwgYmUgb25seSB1c2VkIGluIGNvbXBp bGVyIGNvZGVzLg0KDQpNTVUgaXMgZGVmaW5pbmcgbWFjcm8gbGlrZSBQQUdFX0hZUEVSVklTT1Jf UlcsIGZvciBtZW1vcnkgYXR0cmlidXRlcw0KbWFuYWdlbWVudCBpbiBDIGNvZGVzLCBhbmQgd2Ug aW50ZW5kIHRvIGZvbGxvdyB0aGUgc2FtZSBzdHJhdGVneS4NCg0KPiA+ICsNCj4gPiArLm1hY3Jv IHdyaXRlX3ByLCBzZWwsIHByYmFyLCBwcmxhcg0KPiA+ICsgICAgbXNyICAgUFJTRUxSX0VMMiwg XHNlbA0KPiA+ICsgICAgZHNiICAgc3kNCj4gDQo+IElzIGl0IHJlYWxseSBuZWNlc3NhcnkgdG8g dXNlICJzeSIgIGhlcmU/IEFsc28sIGl0IHdvdWxkIGJlIGdvb2QgdG8NCj4gZXhwbGFpbiB0aGUg bG9naWMuIEkuZS4gd2h5IGRvIHlvdSBuZWVkIHR3byBkc2IgYnV0IG9ubHkgb25lIGlzYj8NCj4g DQo+IEluIGZhY3QsIEkgd2FzIGV4cGVjdGluZyBhbiAiaXNiIiBoZXJlIHRoYW4gImRzYiIgdG8g d2FpdCBmb3IgdGhlDQo+IGNvbXBsZXRpb24gb2YgdGhlIGluc3RydWN0aW9uLg0KPiANCj4gPiAr ICAgIG1zciAgIFBSQkFSX0VMMiwgXHByYmFyDQo+ID4gKyAgICBtc3IgICBQUkxBUl9FTDIsIFxw cmxhcg0KPiA+ICsgICAgZHNiICAgc3kNCj4gPiArICAgIGlzYg0KPiA+ICsuZW5kbQ0KPiA+ICsN Cj4gPiArLnNlY3Rpb24gLnRleHQuaGVhZGVyLCAiYXgiLCAlcHJvZ2JpdHMNCj4gPiArDQo+ID4g Ky8qDQo+ID4gKyAqIFN0YXRpYyBzdGFydC1vZi1kYXkgRUwyIE1QVSBtZW1vcnkgbGF5b3V0Lg0K PiA+ICsgKg0KPiA+ICsgKiBJdCBoYXMgYSB2ZXJ5IHNpbXBsZSBzdHJ1Y3R1cmUsIGluY2x1ZGlu ZzoNCj4gPiArICogIC0gMk1CIG5vcm1hbCBtZW1vcnkgbWFwcGluZ3Mgb2YgeGVuIGF0IFhFTl9T VEFSVF9BRERSRVNTLA0KPiB3aGljaA0KPiA+ICsgKiBpcyB0aGUgYWRkcmVzcyB3aGVyZSBYZW4g d2FzIGxvYWRlZCBieSB0aGUgYm9vdGxvYWRlci4NCj4gDQo+IE1pc3NpbmcgZGV0YWlscyBvbiB0 aGUgY2xvYmJlcnJlZCByZWdpc3RlcnMuDQo+IA0KPiA+ICsgKi8NCj4gPiArRU5UUlkocHJlcGFy ZV9lYXJseV9tYXBwaW5ncykNCj4gPiArICAgIC8qIE1hcCBYZW4gc3RhcnQgbWVtb3J5IHRvIGEg bm9ybWFsIG1lbW9yeSByZWdpb24uICovDQo+ID4gKyAgICBtb3YgeDAsICNCT09UX05PUk1BTF9S RUdJT05fSURYDQo+ID4gKyAgICBsZHIgeDEsID1YRU5fU1RBUlRfQUREUkVTUw0KPiA+ICsgICAg YW5kIHgxLCB4MSwgI01QVV9SRUdJT05fTUFTSw0KPiA+ICsgICAgbW92IHgzLCAjUFJCQVJfTk9S TUFMX01FTQ0KPiA+ICsgICAgb3JyIHgxLCB4MSwgeDMNCj4gDQo+IEl0IGxvb2tzIGxpa2UgdG8g bWUgdGhlcmUgYXJlIGEgcG90ZW50aWFsIGZvciBhIG1hY3JvIHRvIGNvbXB1dGUgdGhlDQo+IHJl Z2lzdGVyLg0KPiANCj4gPiArDQo+ID4gKyAgICBsZHIgeDIsID1YRU5fU1RBUlRfQUREUkVTUw0K PiA+ICsgICAgbW92IHgzLCAjKFhFTl9TVEFSVF9NRU1fU0laRSAtIDEpDQo+IA0KPiBYRU5fU1RB UlRfTUVNX1NJWkUgaXMgdGhlIG1heGltdW0gc2l6ZSBvZiBYZW4uIElPVywgWGVuIG1heSBiZQ0K PiBzbWFsbGVyDQo+IGFuZCB5b3Ugd2lsbCBtYXAgbWVtb3J5IHRoYXQgbWF5IG5vdCBiZSBwYXJ0 IG9mIFhlbi4gVGhlcmVmb3JlLCB5b3UNCj4gbGlrZWx5IHdhbnQgdG8gY29tcHV0ZSB0aGUgcmVh bCBzaXplIHRvIGF2b2lkIG1hcHBpbmcgdG9vIG11Y2guDQo+IA0KDQpMYXRlciwgaW4gc2V0dXBf bW0gd2Ugd2lsbCBtYXAgWEVOIGNvbXBvbmVudHMgYnkgY29tcG9uZW50cywgc3VjaCBhcywNCm9u ZSBNUFUgbWVtb3J5IHJlZ2lvbiBmb3IgcmVhZC1vbmx5LWV4ZWN1dGFibGUgdGV4dCBzZWN0aW9u LCBvbmUNCk1QVSBtZW1vcnkgcmVnaW9uIGZvciByZWFkLW9ubHkgZGF0YSBzZWN0aW9uLCBldGMs IGV0Yy4NClNvIGluIHRoZXJlLCBYRU4gd2lsbCBiZSBtYXBwZWQgZml0bHkuDQoNCklNSE8sIHRo ZSBtYXBwaW5nIGluIGNvbXBpbGVyIHdpdGggbWF4aW11bSBzaXplIG9mIFhlbiBpcyBhbHNvIHdo YXQNCk1NVSBkb2VzLg0KDQo+DQo+ID4gKyAgICBhZGQgeDIsIHgyLCB4DQo+ID4gKyAgICBhbmQg eDIsIHgyLCAjTVBVX1JFR0lPTl9NQVNLDQo+ID4gKyAgICBtb3YgeDMsICNQUkxBUl9OT1JNQUxf TUVNDQo+ID4gKyAgICBvcnIgeDIsIHgyLCB4Mw0KPiA+ICsNCj4gPiArICAgIC8qDQo+ID4gKyAg ICAgKiBXcml0ZSB0byBNUFUgcHJvdGVjdGlvbiByZWdpb246DQo+ID4gKyAgICAgKiB4MCBmb3Ig cHJfc2VsLCB4MSBmb3IgcHJiYXIgeDIgZm9yIHBybGFyDQo+IA0KPiBUaGlzIGlzIG5vdCBhIHZl cnkgdXNlZnVsIGNvbW1lbnQgYmVjYXVzZSB0aGlzIGNhbiBiZSBpbmZlcnJlZCBmcm9tIHRoZQ0K PiBwcm90b3R5cGUgb2Ygd3JpdGVfcHIuIFdoYXQgd291bGQgYmUgbW9yZSBpbnRlcmVzdGluZyBp cyB0byBleHBsYWluIHRoZQ0KPiBsb2dpYyB3aXRoaW4gdGhpcyBmdW5jdGlvbiBpbiB0aGUgc2Ft ZSB3YXkgd2UgZG8gaW4gaGVhZC5TIGFuZCBoZWFkX21tdS5TLg0KPiANCj4gPiArICAgICAqLw0K PiA+ICsgICAgd3JpdGVfcHIgeDAsIHgxLCB4Mg0KPiA+ICsNCj4gPiArICAgIHJldA0KPiA+ICtF TkRQUk9DKHByZXBhcmVfZWFybHlfbWFwcGluZ3MpDQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNo L2FybS9pbmNsdWRlL2FzbS9hcm02NC9tcHUuaA0KPiBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2Fz bS9hcm02NC9tcHUuaA0KPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+ID4gaW5kZXggMDAwMDAw MDAwMC4uZDIwOWVlZjZkYg0KPiA+IC0tLSAvZGV2L251bGwNCj4gPiArKysgYi94ZW4vYXJjaC9h cm0vaW5jbHVkZS9hc20vYXJtNjQvbXB1LmgNCj4gPiBAQCAtMCwwICsxLDEzIEBADQo+ID4gKy8v IFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wLW9ubHkNCj4gPiArLyoNCj4gPiArICog bXB1Lmg6IEFybSBNZW1vcnkgUHJvdGVjdGlvbiBVbml0IGRlZmluaXRpb25zLg0KPiA+ICsgKi8N Cj4gPiArDQo+ID4gKyNpZm5kZWYgX19BUk02NF9NUFVfSF9fDQo+ID4gKyNkZWZpbmUgX19BUk02 NF9NUFVfSF9fDQo+ID4gKw0KPiA+ICsjZGVmaW5lIE1QVV9SRUdJT05fU0hJRlQgIDYNCj4gPiAr I2RlZmluZSBNUFVfUkVHSU9OX0FMSUdOICAoX0FDKDEsIFVMKSA8PCBNUFVfUkVHSU9OX1NISUZU KQ0KPiA+ICsjZGVmaW5lIE1QVV9SRUdJT05fTUFTSyAgICh+KE1QVV9SRUdJT05fQUxJR04gLSAx KSkNCj4gPiArDQo+ID4gKyNlbmRpZiAvKiBfX0FSTTY0X01QVV9IX18gKi8NCj4gPiBkaWZmIC0t Z2l0IGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2FybTY0L3N5c3JlZ3MuaA0KPiBiL3hlbi9h cmNoL2FybS9pbmNsdWRlL2FzbS9hcm02NC9zeXNyZWdzLmgNCj4gPiBpbmRleCA1NDY3MDA4NGMz Li5hNTk2MDQyZDZjIDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9h cm02NC9zeXNyZWdzLmgNCj4gPiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vYXJtNjQv c3lzcmVncy5oDQo+IA0KPiBJbiB0aGUgY29udGV4dCBvZiB0aGlzIHBhdGNoLCBpdCB3b3VsZCBi ZSBiZXR0ZXIgdG8gb25seSBkZWZpbmUgdGhlDQo+IHJlZ2lzdGVycyB5b3UgbmVlZC4gSWYgeW91 IHdhbnQgdG8gZGVmaW5lIGFsbCBvZiB0aGVtLCB0aGVuIHBsZWFzZQ0KPiBkZWZpbmUgdGhlbSBp biBhIHNlcGFyYXRlIHBhdGNoIGJlZm9yZSB0aGlzIG9uZS4NCj4gDQo+ID4gQEAgLTQ1OCw2ICs0 NTgsOTUgQEANCj4gPiAgICNkZWZpbmUgWkNSX0VMeF9MRU5fU0laRSAgICAgICAgICAgICA5DQo+ ID4gICAjZGVmaW5lIFpDUl9FTHhfTEVOX01BU0sgICAgICAgICAgICAgMHgxZmYNCj4gPg0KPiA+ ICsvKiBTeXN0ZW0gcmVnaXN0ZXJzIGZvciBBQXJjaDY0IHdpdGggUE1TQSAqLw0KPiA+ICsjaWZk ZWYgQ09ORklHX0hBU19NUFUNCj4gDQo+IFRoZSAjaWZkZWYgaGVyZSBzZWVtcyB1bm5lY2Vzc2Fy eS4NCj4gDQo+ID4gKw0KPiA+ICsvKiBFTDEgTVBVIFByb3RlY3Rpb24gUmVnaW9uIEJhc2UgQWRk cmVzcyBSZWdpc3RlciBlbmNvZGUgKi8NCj4gPiArI2RlZmluZSBQUkJBUl9FTDEgICBTM18wX0M2 X0M4XzANCj4gPiArI2RlZmluZSBQUkJBUjFfRUwxICBTM18wX0M2X0M4XzQNCj4gPiArI2RlZmlu ZSBQUkJBUjJfRUwxICBTM18wX0M2X0M5XzANCj4gPiArI2RlZmluZSBQUkJBUjNfRUwxICBTM18w X0M2X0M5XzQNCj4gPiArI2RlZmluZSBQUkJBUjRfRUwxICBTM18wX0M2X0MxMF8wDQo+ID4gKyNk ZWZpbmUgUFJCQVI1X0VMMSAgUzNfMF9DNl9DMTBfNA0KPiA+ICsjZGVmaW5lIFBSQkFSNl9FTDEg IFMzXzBfQzZfQzExXzANCj4gPiArI2RlZmluZSBQUkJBUjdfRUwxICBTM18wX0M2X0MxMV80DQo+ ID4gKyNkZWZpbmUgUFJCQVI4X0VMMSAgUzNfMF9DNl9DMTJfMA0KPiA+ICsjZGVmaW5lIFBSQkFS OV9FTDEgIFMzXzBfQzZfQzEyXzQNCj4gPiArI2RlZmluZSBQUkJBUjEwX0VMMSBTM18wX0M2X0Mx M18wDQo+ID4gKyNkZWZpbmUgUFJCQVIxMV9FTDEgUzNfMF9DNl9DMTNfNA0KPiA+ICsjZGVmaW5l IFBSQkFSMTJfRUwxIFMzXzBfQzZfQzE0XzANCj4gPiArI2RlZmluZSBQUkJBUjEzX0VMMSBTM18w X0M2X0MxNF80DQo+ID4gKyNkZWZpbmUgUFJCQVIxNF9FTDEgUzNfMF9DNl9DMTVfMA0KPiA+ICsj ZGVmaW5lIFBSQkFSMTVfRUwxIFMzXzBfQzZfQzE1XzQNCj4gPiArDQo+ID4gKy8qIEVMMSBNUFUg UHJvdGVjdGlvbiBSZWdpb24gTGltaXQgQWRkcmVzcyBSZWdpc3RlciBlbmNvZGUgKi8NCj4gPiAr I2RlZmluZSBQUkxBUl9FTDEgICBTM18wX0M2X0M4XzENCj4gPiArI2RlZmluZSBQUkxBUjFfRUwx ICBTM18wX0M2X0M4XzUNCj4gPiArI2RlZmluZSBQUkxBUjJfRUwxICBTM18wX0M2X0M5XzENCj4g PiArI2RlZmluZSBQUkxBUjNfRUwxICBTM18wX0M2X0M5XzUNCj4gPiArI2RlZmluZSBQUkxBUjRf RUwxICBTM18wX0M2X0MxMF8xDQo+ID4gKyNkZWZpbmUgUFJMQVI1X0VMMSAgUzNfMF9DNl9DMTBf NQ0KPiA+ICsjZGVmaW5lIFBSTEFSNl9FTDEgIFMzXzBfQzZfQzExXzENCj4gPiArI2RlZmluZSBQ UkxBUjdfRUwxICBTM18wX0M2X0MxMV81DQo+ID4gKyNkZWZpbmUgUFJMQVI4X0VMMSAgUzNfMF9D Nl9DMTJfMQ0KPiA+ICsjZGVmaW5lIFBSTEFSOV9FTDEgIFMzXzBfQzZfQzEyXzUNCj4gPiArI2Rl ZmluZSBQUkxBUjEwX0VMMSBTM18wX0M2X0MxM18xDQo+ID4gKyNkZWZpbmUgUFJMQVIxMV9FTDEg UzNfMF9DNl9DMTNfNQ0KPiA+ICsjZGVmaW5lIFBSTEFSMTJfRUwxIFMzXzBfQzZfQzE0XzENCj4g PiArI2RlZmluZSBQUkxBUjEzX0VMMSBTM18wX0M2X0MxNF81DQo+ID4gKyNkZWZpbmUgUFJMQVIx NF9FTDEgUzNfMF9DNl9DMTVfMQ0KPiA+ICsjZGVmaW5lIFBSTEFSMTVfRUwxIFMzXzBfQzZfQzE1 XzUNCj4gPiArDQo+ID4gKy8qIEVMMiBNUFUgUHJvdGVjdGlvbiBSZWdpb24gQmFzZSBBZGRyZXNz IFJlZ2lzdGVyIGVuY29kZSAqLw0KPiA+ICsjZGVmaW5lIFBSQkFSX0VMMiAgIFMzXzRfQzZfQzhf MA0KPiA+ICsjZGVmaW5lIFBSQkFSMV9FTDIgIFMzXzRfQzZfQzhfNA0KPiA+ICsjZGVmaW5lIFBS QkFSMl9FTDIgIFMzXzRfQzZfQzlfMA0KPiA+ICsjZGVmaW5lIFBSQkFSM19FTDIgIFMzXzRfQzZf QzlfNA0KPiA+ICsjZGVmaW5lIFBSQkFSNF9FTDIgIFMzXzRfQzZfQzEwXzANCj4gPiArI2RlZmlu ZSBQUkJBUjVfRUwyICBTM180X0M2X0MxMF80DQo+ID4gKyNkZWZpbmUgUFJCQVI2X0VMMiAgUzNf NF9DNl9DMTFfMA0KPiA+ICsjZGVmaW5lIFBSQkFSN19FTDIgIFMzXzRfQzZfQzExXzQNCj4gPiAr I2RlZmluZSBQUkJBUjhfRUwyICBTM180X0M2X0MxMl8wDQo+ID4gKyNkZWZpbmUgUFJCQVI5X0VM MiAgUzNfNF9DNl9DMTJfNA0KPiA+ICsjZGVmaW5lIFBSQkFSMTBfRUwyIFMzXzRfQzZfQzEzXzAN Cj4gPiArI2RlZmluZSBQUkJBUjExX0VMMiBTM180X0M2X0MxM180DQo+ID4gKyNkZWZpbmUgUFJC QVIxMl9FTDIgUzNfNF9DNl9DMTRfMA0KPiA+ICsjZGVmaW5lIFBSQkFSMTNfRUwyIFMzXzRfQzZf QzE0XzQNCj4gPiArI2RlZmluZSBQUkJBUjE0X0VMMiBTM180X0M2X0MxNV8wDQo+ID4gKyNkZWZp bmUgUFJCQVIxNV9FTDIgUzNfNF9DNl9DMTVfNA0KPiA+ICsNCj4gPiArLyogRUwyIE1QVSBQcm90 ZWN0aW9uIFJlZ2lvbiBMaW1pdCBBZGRyZXNzIFJlZ2lzdGVyIGVuY29kZSAqLw0KPiA+ICsjZGVm aW5lIFBSTEFSX0VMMiAgIFMzXzRfQzZfQzhfMQ0KPiA+ICsjZGVmaW5lIFBSTEFSMV9FTDIgIFMz XzRfQzZfQzhfNQ0KPiA+ICsjZGVmaW5lIFBSTEFSMl9FTDIgIFMzXzRfQzZfQzlfMQ0KPiA+ICsj ZGVmaW5lIFBSTEFSM19FTDIgIFMzXzRfQzZfQzlfNQ0KPiA+ICsjZGVmaW5lIFBSTEFSNF9FTDIg IFMzXzRfQzZfQzEwXzENCj4gPiArI2RlZmluZSBQUkxBUjVfRUwyICBTM180X0M2X0MxMF81DQo+ ID4gKyNkZWZpbmUgUFJMQVI2X0VMMiAgUzNfNF9DNl9DMTFfMQ0KPiA+ICsjZGVmaW5lIFBSTEFS N19FTDIgIFMzXzRfQzZfQzExXzUNCj4gPiArI2RlZmluZSBQUkxBUjhfRUwyICBTM180X0M2X0Mx Ml8xDQo+ID4gKyNkZWZpbmUgUFJMQVI5X0VMMiAgUzNfNF9DNl9DMTJfNQ0KPiA+ICsjZGVmaW5l IFBSTEFSMTBfRUwyIFMzXzRfQzZfQzEzXzENCj4gPiArI2RlZmluZSBQUkxBUjExX0VMMiBTM180 X0M2X0MxM181DQo+ID4gKyNkZWZpbmUgUFJMQVIxMl9FTDIgUzNfNF9DNl9DMTRfMQ0KPiA+ICsj ZGVmaW5lIFBSTEFSMTNfRUwyIFMzXzRfQzZfQzE0XzUNCj4gPiArI2RlZmluZSBQUkxBUjE0X0VM MiBTM180X0M2X0MxNV8xDQo+ID4gKyNkZWZpbmUgUFJMQVIxNV9FTDIgUzNfNF9DNl9DMTVfNQ0K PiA+ICsNCj4gPiArLyogTVBVIFByb3RlY3Rpb24gUmVnaW9uIEVuYWJsZSBSZWdpc3RlciBlbmNv ZGUgKi8NCj4gPiArI2RlZmluZSBQUkVOUl9FTDEgUzNfMF9DNl9DMV8xDQo+ID4gKyNkZWZpbmUg UFJFTlJfRUwyIFMzXzRfQzZfQzFfMQ0KPiA+ICsNCj4gPiArLyogTVBVIFByb3RlY3Rpb24gUmVn aW9uIFNlbGVjdGlvbiBSZWdpc3RlciBlbmNvZGUgKi8NCj4gPiArI2RlZmluZSBQUlNFTFJfRUwx IFMzXzBfQzZfQzJfMQ0KPiA+ICsjZGVmaW5lIFBSU0VMUl9FTDIgUzNfNF9DNl9DMl8xDQo+ID4g Kw0KPiA+ICsvKiBNUFUgVHlwZSByZWdpc3RlcnMgZW5jb2RlICovDQo+ID4gKyNkZWZpbmUgTVBV SVJfRUwxIFMzXzBfQzBfQzBfNA0KPiA+ICsjZGVmaW5lIE1QVUlSX0VMMiBTM180X0MwX0MwXzQN Cj4gPiArDQo+ID4gKyNlbmRpZg0KPiA+ICsNCj4gPiAgIC8qIEFjY2VzcyB0byBzeXN0ZW0gcmVn aXN0ZXJzICovDQo+ID4NCj4gPiAgICNkZWZpbmUgV1JJVEVfU1lTUkVHNjQodiwgbmFtZSkgZG8g eyAgICAgICAgICAgICAgICAgICAgXA0KPiANCj4gQ2hlZXJzLA0KPiANCj4gWzFdIGh0dHBzOi8v bG9yZS5rZXJuZWwub3JnL2FsbC8yMDIyMTAyMjE1MDQyMi4xNzcwNy0yLWp1bGllbkB4ZW4ub3Jn Lw0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQoNCkNoZWVycywNCg0KLS0NClBlbm55IFpoZW5n DQo= From xen-devel-bounces@lists.xenproject.org Mon Nov 07 07:33:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 07:33:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439075.693022 (Exim 4.92) (envelope-from ) id 1orwdA-0005uG-8S; Mon, 07 Nov 2022 07:33:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439075.693022; Mon, 07 Nov 2022 07:33:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orwdA-0005u9-5V; Mon, 07 Nov 2022 07:33:16 +0000 Received: by outflank-mailman (input) for mailman id 439075; Mon, 07 Nov 2022 07:33:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orwd8-0005u3-IO for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 07:33:14 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6f6b1fee-5e6e-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 08:33:13 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5B6631F91C; Mon, 7 Nov 2022 07:33:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 35D5B13AC7; Mon, 7 Nov 2022 07:33:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IoKcC7i0aGNjDAAAMHmgww (envelope-from ); Mon, 07 Nov 2022 07:33:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f6b1fee-5e6e-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667806392; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w57SdNk4+rMF4F1CSL2UorXLTY3nTcZvu9goOvfkLsg=; b=ZTc8eQlt2kydMVxbM+plysapNM5aeIIEDhvYU7WOIF+Ltl0vDBr3y51HLUszqxulttq8Pa JbDTQwTDEdv0Tbc9ydg6FSHm19I9jTcVKKDCWKLgGpMunObuihxnTrYxAseN6VvOTJqf6H /wom1yQoVPfXOPH7SZEvya+7E5UcQg0= Message-ID: Date: Mon, 7 Nov 2022 08:33:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-4-jgross@suse.com> From: Juergen Gross Subject: Re: [PATCH 03/20] tools/xenstore: let talloc_free() preserve errno In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------9TZ0F4cfDjPykCJBU2kTugDU" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------9TZ0F4cfDjPykCJBU2kTugDU Content-Type: multipart/mixed; boundary="------------wgiQcH4M2YMCUDT1aliMVt3Y"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH 03/20] tools/xenstore: let talloc_free() preserve errno References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-4-jgross@suse.com> In-Reply-To: --------------wgiQcH4M2YMCUDT1aliMVt3Y Content-Type: multipart/mixed; boundary="------------Ujmvd03nAcUXwVsjj7xFZZYS" --------------Ujmvd03nAcUXwVsjj7xFZZYS Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMTEuMjIgMjI6MDgsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDAxLzExLzIwMjIgMTU6MjgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBU b2RheSB0YWxsb2NfZnJlZSgpIGlzIG5vdCBndWFyYW50ZWVkIHRvIHByZXNlcnZlIGVycm5v LCBlc3BlY2lhbGx5IGluDQo+PiBjYXNlIGEgY3VzdG9tIGRlc3RydWN0b3IgaXMgYmVpbmcg dXNlZC4NCj4+DQo+PiBDaGFuZ2UgdGhhdCBieSByZW5hbWluZyB0YWxsb2NfZnJlZSgpIHRv IF90YWxsb2NfZnJlZSgpIGluIHRhbGxvYy5jIGFuZA0KPj4gYWRkaW5nIGEgd3JhcHBlciB0 byB0YWxsb2MuYy4NCj4+DQo+PiBUaGlzIGFsbG93cyB0byByZW1vdmUgc29tZSBlcnJubyBz YXZpbmcgb3V0c2lkZSBvZiB0YWxsb2MuYy4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBKdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiAtLS0NCj4+IMKgIHRvb2xzL3hlbnN0 b3JlL3RhbGxvYy5jwqDCoMKgwqDCoMKgwqDCoCB8IDI1ICsrKysrKysrKysrKysrKysrKy0t LS0tLS0NCj4+IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMgfMKgIDIgLS0N Cj4+IMKgIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMo LSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUvdGFsbG9jLmMgYi90b29s cy94ZW5zdG9yZS90YWxsb2MuYw0KPj4gaW5kZXggZDdlZGNmM2E5My4uNWZiZWZkZjA5MSAx MDA2NDQNCj4+IC0tLSBhL3Rvb2xzL3hlbnN0b3JlL3RhbGxvYy5jDQo+PiArKysgYi90b29s cy94ZW5zdG9yZS90YWxsb2MuYw0KPj4gQEAgLTEwMyw2ICsxMDMsOCBAQCBzdHJ1Y3QgdGFs bG9jX2NodW5rIHsNCj4+IMKgwqDCoMKgwqAgdW5zaWduZWQgZmxhZ3M7DQo+PiDCoCB9Ow0K Pj4gK3N0YXRpYyBpbnQgX3RhbGxvY19mcmVlKHZvaWQgKnB0cik7DQo+PiArDQo+PiDCoCAv KiAxNiBieXRlIGFsaWdubWVudCBzZWVtcyB0byBrZWVwIGV2ZXJ5b25lIGhhcHB5ICovDQo+ PiDCoCAjZGVmaW5lIFRDX0hEUl9TSVpFICgoc2l6ZW9mKHN0cnVjdCB0YWxsb2NfY2h1bmsp KzE1KSZ+MTUpDQo+PiDCoCAjZGVmaW5lIFRDX1BUUl9GUk9NX0NIVU5LKHRjKSAoKHZvaWQg KikoVENfSERSX1NJWkUgKyAoY2hhciopdGMpKQ0KPj4gQEAgLTI0NSw3ICsyNDcsNyBAQCBz dGF0aWMgaW50IHRhbGxvY19yZWZlcmVuY2VfZGVzdHJ1Y3Rvcih2b2lkICpwdHIpDQo+PiDC oMKgwqDCoMKgwqDCoMKgwqAgdGMxLT5kZXN0cnVjdG9yID0gTlVMTDsNCj4+IMKgwqDCoMKg wqAgfQ0KPj4gwqDCoMKgwqDCoCBfVExJU1RfUkVNT1ZFKHRjMi0+cmVmcywgaGFuZGxlKTsN Cj4+IC3CoMKgwqAgdGFsbG9jX2ZyZWUoaGFuZGxlKTsNCj4+ICvCoMKgwqAgX3RhbGxvY19m cmVlKGhhbmRsZSk7DQo+IA0KPiAgRnJvbSB0aGUgY29tbWl0IG1lc3NhZ2UsIGl0IGlzIG5v dCBjbGVhciB0byBtZSB3aHkgd2UgYXJlIGNhbGxpbmcgdGhlIA0KPiB1bmRlcnNjb3JlIHZl cnNpb24gaGVyZS4gU2FtZSBmb3IgdGhlIG90aGVycyBiZWxvdy4NCg0KSSB3YXMgdGFyZ2V0 aW5nIG9ubHkgdGFsbG9jX2ZyZWUoKSBjYWxscyBmcm9tIHhlbnN0b3JlZCB0byBwcmVzZXJ2 ZSBlcnJuby4NCg0KSSBjYW4gc2VlIHlvdXIgcG9pbnQgdGhhdCB3ZSBjb3VsZCBqdXN0IGRv IHRoZSBzYW1lIGZvciB0YWxsb2MgaW50ZXJuYWwNCmNhbGxzLCBwcmVzZXJ2aW5nIGVycm5v IGluIG90aGVyIGNhc2VzLCB0b28uDQoNCk9UT0ggdGhlIG9ubHkgcmVsZXZhbnQgY2FzZSB3 b3VsZCBiZSB0aGUgY2FsbCBmcm9tIHRhbGxvY191bmxpbmsoKSB2aWENCnRhbGxvY191bnJl ZmVyZW5jZSgpLCB3aGljaCBpcyBhdCBsZWFzdCBjdXJyZW50bHkgbm8gcHJvYmxlbSByZWdh cmRpbmcNCmVycm5vLg0KDQpEbyB5b3UgaGF2ZSBhbnkgcHJlZmVyZW5jZXM/IEknbSBsZWFu aW5nIHRvd2FyZHMgZHJvcHBpbmcgdGhlIHdyYXBwZXINCmFuZCBkbyB0aGUgZXJybm8gcHJl c2VydmluZyBqdXN0IGluc2lkZSB0YWxsb2NfZnJlZSgpLg0KDQoNCkp1ZXJnZW4NCg== --------------Ujmvd03nAcUXwVsjj7xFZZYS Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Ujmvd03nAcUXwVsjj7xFZZYS-- --------------wgiQcH4M2YMCUDT1aliMVt3Y-- --------------9TZ0F4cfDjPykCJBU2kTugDU Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNotLcFAwAAAAAACgkQsN6d1ii/Ey+M Ywf6AwOHZabytLWyQKM9iTA6ZFmTbZjgaEEhogPBFk5cslHafcY9a8dZKjoyLzwrXSXKS8Gyg/3n LkGD9ozHattxk6XmWIv1CIQ9hreJEUGBUHoLf2Gh10CawnUY8oJ4vm7I8/piRM7RWLtfFqa+Wkvm 2k905utZySvR2n30Zx7TNMl8Vd1zvl4rpbBwwz2t2zhG5si8MjDGUY1xqGaxQRSQze87NJ4DkU4F f1vJpGzKcY4Tzm8eYeQNea8c9OUBH15rGAQOVzKgFWrEF9QYWyLc4Mh6sc4jQQvXTtjk2Ay7uy+6 yuOkUX/EES0GF/J/ZwgUXGOiDW2IdwUSjiUNRzVyHg== =X08d -----END PGP SIGNATURE----- --------------9TZ0F4cfDjPykCJBU2kTugDU-- From xen-devel-bounces@lists.xenproject.org Mon Nov 07 07:47:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 07:47:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439082.693032 (Exim 4.92) (envelope-from ) id 1orwqP-0007sq-DL; Mon, 07 Nov 2022 07:46:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439082.693032; Mon, 07 Nov 2022 07:46:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orwqP-0007sj-Aj; Mon, 07 Nov 2022 07:46:57 +0000 Received: by outflank-mailman (input) for mailman id 439082; Mon, 07 Nov 2022 07:46:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orwqN-0007sZ-5m; Mon, 07 Nov 2022 07:46:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orwqN-0007UI-3K; Mon, 07 Nov 2022 07:46:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orwqM-0005fz-I2; Mon, 07 Nov 2022 07:46:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orwqM-0003Xs-Hh; Mon, 07 Nov 2022 07:46:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cuby1TL8HW6W6kylRdy9c5+SF5xAVmhohJLDvJ/+b3E=; b=stw8JThZsXIO/gOLKm6r4+rU0l DMINioxmtLmC1b9vJhFMlab+3pSKMh2m+J0QquYD9kdln43m1dR7JqXY1+K5vhPiuUZDxJBExFxrR bI0+TWMFBHfq8oadUJbgQql0vj2+X6SXkWqjeFdqH8dGBKix6Lv7N3vCnbXdNc53Wm0c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174653: all pass - PUSHED X-Osstest-Versions-This: ovmf=35043a5ec05db6aa86b1b380416923fd1c3506e6 X-Osstest-Versions-That: ovmf=b556f2445c251adf405ac966b48c237d20c0d46c From: osstest service owner Date: Mon, 07 Nov 2022 07:46:54 +0000 flight 174653 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174653/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 35043a5ec05db6aa86b1b380416923fd1c3506e6 baseline version: ovmf b556f2445c251adf405ac966b48c237d20c0d46c Last test of basis 174648 2022-11-06 18:11:42 Z 0 days Testing same since 174653 2022-11-07 02:12:04 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael D Kinney Pedro Falcato jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b556f2445c..35043a5ec0 35043a5ec05db6aa86b1b380416923fd1c3506e6 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Nov 07 07:50:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 07:50:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439089.693044 (Exim 4.92) (envelope-from ) id 1orwtu-0000pA-TA; Mon, 07 Nov 2022 07:50:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439089.693044; Mon, 07 Nov 2022 07:50:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orwtu-0000p3-Pv; Mon, 07 Nov 2022 07:50:34 +0000 Received: by outflank-mailman (input) for mailman id 439089; Mon, 07 Nov 2022 07:50:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orwts-0000ox-M5 for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 07:50:32 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2077.outbound.protection.outlook.com [40.107.92.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d94610ef-5e70-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 08:50:30 +0100 (CET) Received: from BN8PR15CA0046.namprd15.prod.outlook.com (2603:10b6:408:80::23) by SJ1PR12MB6244.namprd12.prod.outlook.com (2603:10b6:a03:455::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Mon, 7 Nov 2022 07:50:26 +0000 Received: from BN8NAM11FT095.eop-nam11.prod.protection.outlook.com (2603:10b6:408:80:cafe::82) by BN8PR15CA0046.outlook.office365.com (2603:10b6:408:80::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Mon, 7 Nov 2022 07:50:25 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT095.mail.protection.outlook.com (10.13.176.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 07:50:25 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 7 Nov 2022 01:50:24 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 6 Nov 2022 23:50:11 -0800 Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Mon, 7 Nov 2022 01:50:10 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d94610ef-5e70-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nj4SBLMZT/9+IBU8pVjTwmoFywdL60xtvfrcqJjh8KXpgsig+1ixSp9wXXWoOx4KZd0oiOi+Mc1OiNajiLsgmc+GS1oMPee5JTx5DVUyqgm+6uwgtH0UBz+pNLBXcyZ/C/ALGPjbWYGXlWFpYrpQOJmwauF2B08/U3Jc0pZ7WzU96ZRwCgb8VQfXMH1NwAaYdVEDThMH44bc6v/pQygUqdlwNCqUbXWvxOB+hm5YDe9GyLIn4DFiUtzbMrLJXoTYd7jP7V5/FzBMPrDRipc4kAVqSa8vJIE0vg4wUwO/SZo9Dhx9qMkShDUF3XFMB1GvT3uFBz2DKYxKZFq4AzoCuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Htr7QNeo46nvQrz2SPXrmdAFGDd+GXvnXvsr8xa1f1Q=; b=BzkKIXCYGg6S+CKnLNB+TsGFGnvW9XYSbBYOcxqz9wBaMdkEGkx/4Kgk3aqfYxN8k/C2Rv4fWsBFewnVph5wIviClh6REJvYOCDmEiXpZ7AZ5o84lwDhlJZkoBxLX3CPL9zZrowXfY1rerOo3Ffrb+61nnMJITV1Nwv3lXG9NBvnSzMYrfsXTvuPxKomM8CzL7uLSafNr2Z4xLdcUEF4dSlSRz7nujCm+urxywkGa0cqLQdM8WOPAmkc6xGd5DGqwolE+qPSBe+Gkoa+bG9pT4okHe23yS8u8L6xo+dXqEBRw+EhW+HTRVwKUnMPe2SsOO+nmlLdD8Bh+KNnV/Az2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Htr7QNeo46nvQrz2SPXrmdAFGDd+GXvnXvsr8xa1f1Q=; b=Xypby1uEe9K38DrcukKuhTB7hQBw6T8R3FeWIj7P5y1Bb0F98jWKjTuokT7WfuUINJl/9K1iW3SU1KmZ5DQRFQJy/bsuq0QXOmuWtMWlfVEPKdYLu7bqm1ccuAp6lmTOYoTcmGC9Zfmi4rdIgHT+EA3c2dND1k6ksZWmhwJWI0k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <6ee0706b-d1b3-187a-1557-c4b8173c6e37@amd.com> Date: Mon, 7 Nov 2022 08:50:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v3 0/4] Yocto Gitlab CI To: Bertrand Marquis , Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , "Doug Goldstein" References: <1220596a-4fe7-5c08-5437-fa98eb14254c@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT095:EE_|SJ1PR12MB6244:EE_ X-MS-Office365-Filtering-Correlation-Id: db8a8327-8452-449f-dd74-08dac094bb48 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KtqK3DfO4ixp6XvkVNdBrHfs+zKIbKPfxwL7/6qEqSDsLGKGKYk+wD2tKtlALCqiv+Y/vwkuczsCyfzZLZY/FshnkzUBMkbpKrrZPhAq0+e7RpWMoKDb98JR9ViPBgwZZHghy+LbPBILsjAq/Kx8Ne95nRdyPzsY21t0NgkcnkmqEHy6bD/zhmseNgCaDhdbezLtX8fAN/Ljus10H03P32QjCH400mBqf2cSw2kWdOzroj6VokIHaR3ApQYjJvYNMquxiVg/f7bOEPJdRqYzl6U0XgvSprnhpzk3ioGXxo+L3YvHk+yem98wrG0ml+6IZ9VZMBM41pu+Qha9ym/YVYIqB/B7QEMkODCuR64r7w6boLa3z1SSgUP01mdP3ZBcMNB9sspL2tPIjGZGJ2rB4Q7TedDVHjahnb65nHc9uhBEJX6KZbl7U5IF1u0gipJMkrd+wQhI21cGFLYmuovGr6jcuqUB0mjlCGtrGTNNy1J6/GBCewIPHcwjQDcJpKNZgXdFYarDwwKJK+11wbjQVdBRswfwj01/PBJjgGmniVRb5RD8s8JVdUDK8fwIXZ/yNwLmUZoEJDte7P15RN+g+636/RTvTi0ajL7sXUZULh7mghOfynsWO7dcRxV/9VPeDuH9Jg4hYOlchxUobJb45Z/L4rwiHZ8pxiLmMaUAUxk4wktZcOll6eYdUDDv+iTKJnnlBPsc6iQ7VyX4N1ADPffrY/mnTDS3tcReIB8JSaoTaQZ9Ne4NxwOBIhtdSbbKzZBfq/sP+R0FGomZiFPWNM6qlkTr0FtHUBbn7mYGRhUSITr4g9ATfTIEQDgGpMJePmtM698b5ga2k/ntIj4N71eXujrcBriqIL9WMR4nq1KLWDpBDQ0m7upYCcShA0qq X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199015)(46966006)(36840700001)(40470700004)(36756003)(31686004)(31696002)(86362001)(356005)(81166007)(40480700001)(40460700003)(5660300002)(44832011)(2906002)(2616005)(426003)(336012)(82740400003)(47076005)(36860700001)(26005)(53546011)(186003)(70586007)(70206006)(16576012)(110136005)(316002)(966005)(54906003)(478600001)(82310400005)(8676002)(4326008)(8936002)(41300700001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 07:50:25.5841 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db8a8327-8452-449f-dd74-08dac094bb48 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT095.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6244 Hi Bertrand and Stefano, On 31/10/2022 16:00, Bertrand Marquis wrote: > > > Hi Michal, > >> On 31 Oct 2022, at 14:39, Michal Orzel wrote: >> >> Hi Bertrand, >> >> On 31/10/2022 15:00, Bertrand Marquis wrote: >>> >>> >>> This patch series is a first attempt to check if we could use Yocto in >>> gitlab ci to build and run xen on qemu for arm, arm64 and x86. >>> >>> The first patch is creating a container with all elements required to >>> build Yocto, a checkout of the yocto layers required and an helper >>> script to build and run xen on qemu with yocto. >>> >>> The second patch is creating containers with a first build of yocto done >>> so that susbsequent build with those containers would only rebuild what >>> was changed and take the rest from the cache. >>> >>> The third patch is adding a way to easily clean locally created >>> containers. >>> >>> This is is mainly for discussion and sharing as there are still some >>> issues/problem to solve: >>> - building the qemu* containers can take several hours depending on the >>> network bandwith and computing power of the machine where those are >>> created >> This is not really an issue as the build of the containers occurs on the local >> machines before pushing them to registry. Also, building the containers >> will only be required for new Yocto releases. >> >>> - produced containers containing the cache have a size between 8 and >>> 12GB depending on the architecture. We might need to store the build >>> cache somewhere else to reduce the size. If we choose to have one >>> single image, the needed size is around 20GB and we need up to 40GB >>> during the build, which is why I splitted them. >>> - during the build and run, we use a bit more then 20GB of disk which is >>> over the allowed size in gitlab >> As we could see during v2 testing, we do not have any space restrictions >> on the Xen GitLab and I think we already decided to have the Yocto >> integrated into our CI. > > Right, I should have modified this chapter to be coherent with your latest tests. > Sorry for that. > >> >> I will do some testing and get back to you with results + review. I did some testing and here are the results: In the current form this series will fail when running CI because the Yocto containers are based on "From ubuntu:22.04" (there is no platform prefix), which means that the containers are built for the host architecture (in my case and in 99% of the cases of the local build it will be x86). In Gitlab we have 2 runners (arm64 and x86_64). This means that all the test jobs would need to specify x86_64 as a tag when keeping the current behavior. After I built all the containers on my x86 machine, I pushed them to registry and the pipeline was successful: https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/686853939 Here is the diff on patch no. 3 to make the series work (using x86 tag and small improvement to include needs: []): ``` diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 5c620fefce59..52cccec6f904 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -65,6 +65,9 @@ paths: - 'logs/*' when: always + needs: [] + tags: + - x86_64 # Test jobs build-each-commit-gcc: @@ -206,19 +209,13 @@ yocto-qemuarm64: extends: .yocto-test variables: YOCTO_BOARD: qemuarm64 - tags: - - arm64 yocto-qemuarm: extends: .yocto-test variables: YOCTO_BOARD: qemuarm - tags: - - arm32 yocto-qemux86-64: extends: .yocto-test variables: YOCTO_BOARD: qemux86-64 - tags: - - x86_64 ``` Now, the logical way would be to build x86 yocto container for x86, arm64 for arm64 and arm32 on arm64 or x86. I tried building the container qemuarm64 specifying target arm64 on x86. After 15h, only 70% of the Yocto build was completed and there was an error with glibc (the local build of the container for the host arch takes on my machine max 2h). This enormous amount of time is due to the qemu docker emulation that happens behind the scenes (I checked on 2 different machines). So we have 3 solutions: 1) Build and run these containers for/on x86_64: - local users can build the containers on local machines that are almost always x86 based, in short period of time, - "everyone" can build/push the containers once there is a new Yocto release - slightly slower CI build time 2) Build and run these containers for specific architectures: - almost no go for local users using x86 machine (unless using more than 16 threads (which I used) and willing to wait 2 days for the build) - faster CI build time (arm64 runner is faster than x86 one) - someone with arm64 based machine (not that common) would have to build and push the containers 3) Try to use CI to build and push the containers to registry - it could be possible but what about local users Regardless of what we chose, we need to keep in mind that the biggest advantage to the Yocto build/run is that it allows/should allow local users to perform basic testing for all the Xen supported architectures. This is because everything happens in one place with one command. ~Michal From xen-devel-bounces@lists.xenproject.org Mon Nov 07 07:54:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 07:54:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439096.693055 (Exim 4.92) (envelope-from ) id 1orwxh-0001S5-EH; Mon, 07 Nov 2022 07:54:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439096.693055; Mon, 07 Nov 2022 07:54:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orwxh-0001Ry-Ai; Mon, 07 Nov 2022 07:54:29 +0000 Received: by outflank-mailman (input) for mailman id 439096; Mon, 07 Nov 2022 07:54:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orwxg-0001Rp-0v for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 07:54:28 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 66b6dcb2-5e71-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 08:54:26 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 556FA22657; Mon, 7 Nov 2022 07:54:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 30FFD13AC7; Mon, 7 Nov 2022 07:54:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id m7J/CrK5aGO1FgAAMHmgww (envelope-from ); Mon, 07 Nov 2022 07:54:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66b6dcb2-5e71-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667807666; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bdiXlpfw3m4WP/H2SIBGgzTQn84VQTKPGTJyFY8nzPw=; b=i5sGNpgpGSQdo/15SRqUlI4fQxI6BCc/2XvP+X4QHRDASsL1wnkzCmmUV3gOrMezOWcOMk gOROR2Fg6urjpvz2GZf41qSPvDOu06BLNBKmdo/SFreJIUYZvYUpS2KrZe+YIMq79243ez l1lbjbh/he3BA68xShD/M8PXzFWvjXo= Message-ID: <703aa58c-1b7c-abb6-995d-5c5cdfcde878@suse.com> Date: Mon, 7 Nov 2022 08:54:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 06/20] tools/xenstore: remove all watches when a domain has stopped Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-7-jgross@suse.com> <67cb3364-d5c1-28d8-4cda-8933de5cb9f7@xen.org> From: Juergen Gross In-Reply-To: <67cb3364-d5c1-28d8-4cda-8933de5cb9f7@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------WOuuf0XTot4JfyTLyQoDfAx4" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------WOuuf0XTot4JfyTLyQoDfAx4 Content-Type: multipart/mixed; boundary="------------fzYtJkBsGeFOTD0BrodI4bxJ"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <703aa58c-1b7c-abb6-995d-5c5cdfcde878@suse.com> Subject: Re: [PATCH 06/20] tools/xenstore: remove all watches when a domain has stopped References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-7-jgross@suse.com> <67cb3364-d5c1-28d8-4cda-8933de5cb9f7@xen.org> In-Reply-To: <67cb3364-d5c1-28d8-4cda-8933de5cb9f7@xen.org> --------------fzYtJkBsGeFOTD0BrodI4bxJ Content-Type: multipart/mixed; boundary="------------7N81NnY0BDvT9DsnytLmzcJd" --------------7N81NnY0BDvT9DsnytLmzcJd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMTEuMjIgMjI6MTgsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDAxLzExLzIwMjIgMTU6MjgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBX aGVuIGEgZG9tYWluIGhhcyBiZWVuIHJlY29nbml6ZWQgdG8gaGF2ZSBzdG9wcGVkLCByZW1v dmUgYWxsIGl0cw0KPj4gcmVnaXN0ZXJlZCB3YXRjaGVzLiBUaGlzIGF2b2lkcyBzZW5kaW5n IHdhdGNoIGV2ZW50cyB0byB0aGUgZGVhZCBkb21haW4NCj4+IHdoZW4gYWxsIHRoZSBub2Rl cyByZWxhdGVkIHRvIGl0IGFyZSBiZWluZyByZW1vdmVkIGJ5IHRoZSBYZW4gdG9vbHMuDQo+ IA0KPiAgRnJvbSBteSB1bmRlcnN0YW5kaW5nLCBzaHV0ZG93biBkb2Vzbid0IG1lYW4gZGVh ZC4gSXQgbWF5IGJlIHVzZWQgZHVyaW5nIA0KPiBtaWdyYXRpb24gKG9yIHNuYXBzaG90dGlu ZyksIHdoZXJlIHdlIGRvbid0IHdhbnQgdG8gdG91Y2ggdGhlIHN0YXRlIGluIGNhc2Ugb2Yg YSANCj4gY2FuY2VsbGF0aW9uIChvciByZXN1bWUpLg0KPiANCj4gRm9yIGluc3RhbmNlLCBz ZWUgdGhlIGNvbW1hbmQgWFNfUkVTVU1FIHdoaWNoIHdpbGwgY2xlYXIgZG9tYWluLT5zaHV0 ZG93bi4NCg0KT2gsIGdvb2QgY2F0Y2ghDQoNCkkgbmVlZCB0byBhZGRpdGlvbmFsbHkgY2hl Y2sgdGhlICJzaHV0ZG93biByZWFzb24iLiBJIGNhbiByZW1vdmUgdGhlDQp3YXRjaGVzIG9u bHkgaW4gY2FzZSBvZiB0aGUgcmVhc29uIG5vdCBoYXZpbmcgYmVlbiAic3VzcGVuZCIuDQoN Cg0KSnVlcmdlbg0KDQo= --------------7N81NnY0BDvT9DsnytLmzcJd Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------7N81NnY0BDvT9DsnytLmzcJd-- --------------fzYtJkBsGeFOTD0BrodI4bxJ-- --------------WOuuf0XTot4JfyTLyQoDfAx4 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNoubEFAwAAAAAACgkQsN6d1ii/Ey8d 4QgAlq1xIvLiVzOVpQi/zNvOo5yI2RGY/Q5srVGRsSGB+YCMK4e6qso94idmC64XFXFUDLEUklDr VY1O82WYX7/xM8OGspvUj/U+1+oQayKBOj0qKHlAWfrvj64LcKV2WSr/aFhXyT9qqSBSxRe/WIFC aDx9G83W1aHG/4Ukmsf4Luve3mQnOaSSkEU0KahaaK/rOZZsa92f2qfli+XbX4FLvMVYlGq7cDD+ VlvYUmSpXe5xwClNo1sjSuZRdKz/ZIiv6GB7R6qs1BzwX2qRcRIP5F56YFxZrbBMz3+DSx1Elocf 6H8syo+B/izCRq3+Oacbp1A81dWbM8La1oIoOOfEAQ== =/IoK -----END PGP SIGNATURE----- --------------WOuuf0XTot4JfyTLyQoDfAx4-- From xen-devel-bounces@lists.xenproject.org Mon Nov 07 08:14:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 08:14:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439106.693066 (Exim 4.92) (envelope-from ) id 1orxGn-0004tV-Dq; Mon, 07 Nov 2022 08:14:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439106.693066; Mon, 07 Nov 2022 08:14:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orxGn-0004tO-At; Mon, 07 Nov 2022 08:14:13 +0000 Received: by outflank-mailman (input) for mailman id 439106; Mon, 07 Nov 2022 08:14:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orxGl-0004tI-HQ for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 08:14:11 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70055.outbound.protection.outlook.com [40.107.7.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 26802b6e-5e74-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 09:14:07 +0100 (CET) Received: from FR3P281CA0164.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::18) by DU0PR08MB9107.eurprd08.prod.outlook.com (2603:10a6:10:474::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 08:14:05 +0000 Received: from VI1EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a2:cafe::bc) by FR3P281CA0164.outlook.office365.com (2603:10a6:d10:a2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11 via Frontend Transport; Mon, 7 Nov 2022 08:14:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT012.mail.protection.outlook.com (100.127.145.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 08:14:04 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Mon, 07 Nov 2022 08:14:04 +0000 Received: from 4e4af5fd337b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DC86490B-A6A4-4789-B968-7130828E7BDA.1; Mon, 07 Nov 2022 08:13:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4e4af5fd337b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Nov 2022 08:13:55 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by AS1PR08MB7563.eurprd08.prod.outlook.com (2603:10a6:20b:472::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 08:13:52 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::461b:c1cb:368c:707e]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::461b:c1cb:368c:707e%5]) with mapi id 15.20.5813.011; Mon, 7 Nov 2022 08:13:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26802b6e-5e74-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=T+JW2wJFWl7rqZK00VwXfaA7P9RTNLwBnnMguPkeZf4hTlb2SF9poeVlY/bvxjULBZ4vrMnHDcHh5vMYTO+lbwVu4vnLrp21r9AA+cXifLSG3ZN+Gx1zQ2OVS+oqewvBgvXI/v4/ZyB11pDp/jND8SNvczvBZXcIkEyJN24Gz7RV280pEZrprfw+lL0UtK3HA9Oow+evyhuRutgpvItJBiOpjKK5cGWmsXDyNvE6ZsRCQ5BF5TOZsNAni92bj0ANfp7AsbCNxOJs6812A0Bo6E2fVjJ1iHkgbn8scWDSPZXcniCmiOyoBYFHoYWZS9tSZ70EXLchj/36gMFMhpTIrg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lk9NoasUVOTkCBDr/3dLFRuEfRfCohQzAho7KSNL8sc=; b=UL7GGjM8O/cwXPXDnHNIctAncAKiYTwbout6Cz5ZvmvI0VwJlMxE24gFfZMirL3lCvdSruHiHy2K5QbtaBKxis3415E5kCWxs9ScmraKiPTwxExkS28vk1Drt6/3BSaO2yKpRIconSzP+dVNOW+/4gIJ6UvmVsLVARMpfrJ8CvE9+zDnSp8RWc15uHZiHnGZACqPuQrC03tiiXRl4mRzdSUxAtGWtjVqQDvxzI7SBua4e+Fpn+b6RbyBQTRYJbTKM5y1RrgnthEvVRGdVE9cpcZtDh06Xqi/CuNZbZqw/rAOVy0fwoM/jnmVmKxUYieQJj6aYIvj2aqp+xR0CTw44A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lk9NoasUVOTkCBDr/3dLFRuEfRfCohQzAho7KSNL8sc=; b=dscdued/0FTDU8HHEZg3+FK2t4ZB9fYax3vEBI+yTHd8khiOFec8pZs6E8KR+SaVRU8AmqS/3y7FxqmIThPdqqa+kwTBfhwceHB2il4iGnK5+iKEERM5uXiFnTeEZ23SkNN/FYdaacOvOVKfHzYWLNJBMfgTWXI55mggBzbhh0I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AyQX6/Yhd31dVV6e/G4ToNcav8L/91MxdH8dvmXskkvjPH8X5mE2oSn3EKelXuN6ptUIBmhQR0sbINJ1JdnauoRxZhrfpeBD5RGfWW47dYJJAUjifJoVn7VjElxVcjHuzBET8VXJVpgY0Xrnhc8KsXwVsRmO9Z41F1EKkuzOcijxUq0j2XH9q4OMSlklg+SmyAxk07GlBrxMv/mv1ASDqQIm/S2Zzpm0YeZzCucvNf9lxaZc5QAVvzeV7A4509quBGG8XV4KMun8wJ9oJ/9fkXr1ZMAP5JU0XnkWXECxzy1lcVEM3slQVFx0jaXKtWSnRkpoxCui6oEPujUtu10wPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lk9NoasUVOTkCBDr/3dLFRuEfRfCohQzAho7KSNL8sc=; b=Hq4vGZtxkCCAQSxAgzPF7ZiMYuksR5z8uknKdhjNbNXZIar2r8lTDwRy9kTEjp5YqKL6EfKueIWW4u3NDkF33xY2iWT69P/9Sf0Th2yFCarfsolqTVZbxgOFnunsm4QvQLdBghyIYPA6SarLs5Qcof8hwDZNaNqjb8OYDC7XQ+4V8GuIgEHa/Ad6hcEabbcp5GYRTpLuc/XAvcIowwKtFprBRfJYtDc146FE6Iqfv+iYeAsr3cOHYWL0S1Hah8bpPC0R9VhJzh897zMU24RGdY9+z4nsZ8VCuNjv1QEOHof7qQdVDLrPZqWbf9dxZUE4/rhDBQcfSwD11en6Zh2HLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lk9NoasUVOTkCBDr/3dLFRuEfRfCohQzAho7KSNL8sc=; b=dscdued/0FTDU8HHEZg3+FK2t4ZB9fYax3vEBI+yTHd8khiOFec8pZs6E8KR+SaVRU8AmqS/3y7FxqmIThPdqqa+kwTBfhwceHB2il4iGnK5+iKEERM5uXiFnTeEZ23SkNN/FYdaacOvOVKfHzYWLNJBMfgTWXI55mggBzbhh0I= From: Penny Zheng To: Julien Grall , Wei Chen , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 11/11] xen/arm64: add setup_fixmap and remove_identity_mapping for MPU Thread-Topic: [PATCH v6 11/11] xen/arm64: add setup_fixmap and remove_identity_mapping for MPU Thread-Index: AQHY8DVuAVhDJRf6ukC080lsu+G2J64yZbeAgAC01OA= Date: Mon, 7 Nov 2022 08:13:51 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-12-wei.chen@arm.com> <84e476a5-9365-bb80-a8e2-86dcf09681f0@xen.org> In-Reply-To: <84e476a5-9365-bb80-a8e2-86dcf09681f0@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 9711C6EF94D243438F0B097AE4A0E0A4.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|AS1PR08MB7563:EE_|VI1EUR03FT012:EE_|DU0PR08MB9107:EE_ X-MS-Office365-Filtering-Correlation-Id: 323e6fb6-d469-4296-38dd-08dac0980952 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xNUQ478zdUWTV7aE0AInzLoq5LGJsFuKdF23K1bpx26e9jDfiNCjGFVMdwpfL6qAWy7ztJSLWf377W8YoqAbeB4luAk/3DRx54E0NFr2UuVCbBsOleQsiiChr6wk3nuxo8ANTMnfmSv4ooKRO6YGnFM0orOO1c/nRl9EE328ccXpwkuL+HxQ2uQgA2hPNImW6GNq5gZpqm1oDOK+CVBxJakQKBBfWRaxmW9XOHGeaYWnIKrBRWSsGYmDRD5p9Mcvbr1x2Ph3EJb4XiEPtgkU8Xblb3GLEuGImG6vn/EHlmAVvWgFuBYJxc/Nq8uC0m2S4mEo83A52rkVk8IbLMiLIssfX164rkkXhUY6/IaFWpTJXpoXTbJqv3qaDsKoa6cKDwtRy2lWydFxmpxLNbY0elMvB+A+7QeeWsJLcBwOsBgVXw1OzJDxdT5IT8JSElB3BKd/SePk/vVOflNu11nT6xfxv++4KPxIDmZkJE5FpkVApaontdGaLnp4mrJRs/JiVCmiQ3CIWHHBOt/F6HUWkgOpRjkPW4QTRK2fgl4sHqIYutDba23/jQk8PAvZWX9WyfaztvPk89SD0WOdNiiwFcyguBfkB3cvxsGoBzEv2ycw1TUL1TaYtn5zIKzjI+9XGJFFncDEvNrraEpKRjQmg4xF9O/icqwGQn7Rq51u65K7U1rF9ZMjntPgYEG716pIoxEN2bRtl17icJrPmeq/VlYr8omzO519GTYpsBBay/rAQUW8XS7x6ips8Xjqdaa+7UTA5oXnULlipnmFbMgzRmVJQXFMyLlon5jQnzfag+0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(366004)(39860400002)(346002)(451199015)(110136005)(54906003)(316002)(966005)(5660300002)(55016003)(38070700005)(2906002)(83380400001)(478600001)(41300700001)(76116006)(66946007)(66446008)(66556008)(8676002)(4326008)(64756008)(66476007)(71200400001)(52536014)(33656002)(8936002)(9686003)(186003)(26005)(38100700002)(122000001)(53546011)(86362001)(6506007)(7696005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7563 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 34dc3efc-a7f7-4926-6319-08dac098017c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YzA6dWSOrjcwer/XxreKO/b6qJ1iHKqY846JksaNLTyutjUf4MhTn6598gqK5jbwmBoY/aoFnzO3dFn7MySouHdcIvYP6nCRFyPdMdpZm/xxB+KNcWTl9cfR94Q+tp1isJb92YQVHB3ZzmR1EN+7c2ldHZ1k9G3cUZUtTpSOMNz6e6Mq66smzPYcpZS7bsu1+OvjfHg0aJes+hETC/LAzn4QnMxtBUAqVWsSUbe6L/FodhzAqbVf2/wjToQy2A/+7zMIPBdqwwRi3f92UwnCLX3hwLoWFdHrvLDFnqI9ZYZ19J9/ng25Nq+9JH2j6DJFZBeXKEv8MLfIpL6I/YifZwl1mqthEIeEf0DVLeCF7aEleAy6FK3Wa03xs7chTGMCFcNJpLOKEpMD18WBzEifKiLjNetN8vFTwlPT3ScOG60yyVPJROqm8lsuOaPGm4c+9VcFQJGp/KFSghuTHMFm11GcHnwIsxWQ50K4DggUHY6HDxYg/HkDI1hJnoiOWzmn2LRnXia8AFMqNduqfw/0q612dGEGRHnxeuszDPlaJH0cgmFPLZupd0L9ntJ/YAL3vSqSk9A99nAU6lQYM5HbsFistdg9FD6dTcwhG1sDqW2vplBy9/y55PV3aMx73yOF3z8RlVNPnplqnU85MugJ41L2KF4AuyVKYogij3NSX8uOlT9LKstE5ToPYyWufNJzjanUCh8g5+uHv1rckLWq1Y6WZgOIJIHCDJwQW/OEqnpGXrPzch1JlJod/BD8oP3h2OmY6sQcOdw5D5R2kxVp5vcvSbvE2CBS64sT58z0vl+HP3aYaTPX9MBwHZA9j7LN X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(136003)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(82310400005)(55016003)(36860700001)(966005)(33656002)(8936002)(5660300002)(81166007)(83380400001)(356005)(316002)(41300700001)(2906002)(70586007)(52536014)(70206006)(478600001)(4326008)(54906003)(8676002)(110136005)(40480700001)(40460700003)(336012)(186003)(53546011)(26005)(82740400003)(86362001)(6506007)(7696005)(47076005)(107886003)(9686003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 08:14:04.8729 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 323e6fb6-d469-4296-38dd-08dac0980952 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9107 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogTW9uZGF5LCBOb3ZlbWJlciA3LCAyMDIy IDU6MDIgQU0NCj4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgeGVuLWRldmVsQGxp c3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBuZCA8bmRAYXJtLmNvbT47IFBlbm55IFpoZW5nIDxQ ZW5ueS5aaGVuZ0Bhcm0uY29tPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBr ZXJuZWwub3JnPjsgQmVydHJhbmQgTWFycXVpcw0KPiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29t PjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPiBT dWJqZWN0OiBSZTogW1BBVENIIHY2IDExLzExXSB4ZW4vYXJtNjQ6IGFkZCBzZXR1cF9maXhtYXAg YW5kDQo+IHJlbW92ZV9pZGVudGl0eV9tYXBwaW5nIGZvciBNUFUNCj4gDQo+IEhpLA0KPiANCj4g T24gMDQvMTEvMjAyMiAxMDowNywgV2VpIENoZW4gd3JvdGU6DQo+ID4gRnJvbTogUGVubnkgWmhl bmcgPHBlbm55LnpoZW5nQGFybS5jb20+DQo+ID4NCj4gPiBzZXR1cF9maXhtYXAgYW5kIHJlbW92 ZV9pZGVudGl0eV9tYXBwaW5nIGFyZSB0d28gZnVuY3Rpb25zIHRoYXQgYXJlDQo+ID4gdXNlZCBp biBYZW4gYm9vdC10aW1lIGNvZGUgZmxvdy4gV2UgaW1wbGVtZW50IHRoZXNlIHR3byBmdW5jdGlv bnMgZm9yDQo+ID4gTVBVIHN5c3RlbSwgaW4gdGhpcyBjYXNlLCB0aGUgY29kZSBmbG93IGluIGhl YWQuUyBkb2Vzbid0IG5lZWQgdG8gdXNlDQo+ID4gI2lmZGVmIHRvIGdhdGUgTVBVL01NVSBjb2Rl Lg0KPiA+DQo+ID4gSW4gTU1VIHN5c3RlbSwgc2V0dXBfZml4bWFwIGlzIHVzZWQgZm9yIFhlbiB0 byBtYXAgc29tZSBlc3NlbnRhaWwgZGF0YQ0KPiA+IG9yIGRldmljZXMgaW4gYm9vdC10aW1lLiBG b3IgTVBVIHN5c3RlbSwgd2Ugc3RpbGwgaGF2ZSB0aGlzDQo+ID4gcmVxdWlyZW1lbnQsIHdlIG1h cCB0aGUgZWFybHkgVUFSVCB0byBNUFUgcHJvdGVjdGlvbiByZWdpb24gd2hlbg0KPiA+IGVhcmx5 cHJpbnRrIGlzIGVuYWJsZWQuIFRoaXMgYWxzbyBtZWFucyBQUklOVCBjYW4ndCBiZSB1c2VkIGFm dGVyDQo+ID4gdHVybmluZyBvbiBNUFUgYnV0IGJlZm9yZSBzZXR1cF9maXhtYXAuIFRoaXMgcmVz dHJpY3Rpb24gaXMgdGhlIHNhbWUNCj4gPiBhcyBNTVUgc3lzdGVtLg0KPiA+DQo+ID4gRm9yIHJl bW92ZV9pZGVudGl0eV9tYXBwaW5nLCB3ZSBqdXN0IG5lZWQgYW4gZW1wdHkgZnVuY3Rpb24gdG8g bWFrZQ0KPiA+IGhlYWQuUyBjb2RlIGZsb3cgaGFwcHkuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5 OiBXZWkgQ2hlbiA8d2VpLmNoZW5AYXJtLmNvbT4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBQZW5ueSBa aGVuZyA8cGVubnkuemhlbmdAYXJtLmNvbT4NCj4gPiAtLS0NCj4gPiAgIHhlbi9hcmNoL2FybS9h cm02NC9oZWFkX21wdS5TICAgICAgICAgICAgICAgICB8IDQ5ICsrKysrKysrKysrKysrKysrKysN Cj4gPiAgIC4uLi9hcm0vaW5jbHVkZS9hc20vcGxhdGZvcm1zL2Z2cF9iYXNlci5oICAgICB8ICA0 ICsrDQo+ID4gICAyIGZpbGVzIGNoYW5nZWQsIDUzIGluc2VydGlvbnMoKykNCj4gPg0KPiA+IGRp ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZF9tcHUuUw0KPiA+IGIveGVuL2FyY2gv YXJtL2FybTY0L2hlYWRfbXB1LlMgaW5kZXggNWExYjAzZTI5My4uMzM2YzBhNjMwZg0KPiAxMDA2 NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZF9tcHUuUw0KPiA+ICsrKyBiL3hl bi9hcmNoL2FybS9hcm02NC9oZWFkX21wdS5TDQo+ID4gQEAgLTIwLDEzICsyMCwyMCBAQA0KPiA+ ICAgLyoNCj4gPiAgICAqIEluIGJvb3Qgc3RhZ2UsIHdlIHdpbGwgdXNlIDEgTVBVIHJlZ2lvbjoN Cj4gPiAgICAqIFJlZ2lvbiMwOiBOb3JtYWwgbWVtb3J5IGZvciBYZW4gdGV4dCArIGRhdGEgKyBi c3MgKDJNQikNCj4gPiArICogUmVnaW9uIzE6IERldmljZSBtZW1vcnkgZm9yIEVBUkxZIFVBUlQs IHNpemUgaXMgZGVmaW5lZA0KPiA+ICsgKiAgICAgICAgICAgYnkgcGxhdGZvcm0ncyBFQVJMWV9V QVJUX1NJWkUNCj4gPiAgICAqLw0KPiA+ICAgI2RlZmluZSBCT09UX05PUk1BTF9SRUdJT05fSURY ICAweDANCj4gPiArI2RlZmluZSBCT09UX0RFVklDRV9SRUdJT05fSURYICAweDENCj4gPg0KPiA+ ICAgLyogTVBVIG5vcm1hbCBtZW1vcnkgYXR0cmlidXRlcy4gKi8NCj4gPiAgICNkZWZpbmUgUFJC QVJfTk9STUFMX01FTSAgICAgICAgMHgzMCAgICAvKiBTSD0xMSBBUD0wMCBYTj0wMCAqLw0KPiA+ ICAgI2RlZmluZSBQUkxBUl9OT1JNQUxfTUVNICAgICAgICAweDBmICAgIC8qIE5TPTAgQVRUUj0x MTEgRU49MSAqLw0KPiA+DQo+ID4gKy8qIE1QVSBkZXZpY2UgbWVtb3J5IGF0dHJpYnV0ZXMuICov DQo+ID4gKyNkZWZpbmUgUFJCQVJfREVWSUNFX01FTSAgICAgICAgMHgyMCAgICAvKiBTSD0xMCBB UD0wMCBYTj0wMCAqLw0KPiA+ICsjZGVmaW5lIFBSTEFSX0RFVklDRV9NRU0gICAgICAgIDB4MDkg ICAgLyogTlM9MCBBVFRSPTEwMCBFTj0xICovDQo+ID4gKw0KPiA+ICAgLm1hY3JvIHdyaXRlX3By LCBzZWwsIHByYmFyLCBwcmxhcg0KPiA+ICAgICAgIG1zciAgIFBSU0VMUl9FTDIsIFxzZWwNCj4g PiAgICAgICBkc2IgICBzeQ0KPiA+IEBAIC02OSw2ICs3Niw0OCBAQCBFTlRSWShwcmVwYXJlX2Vh cmx5X21hcHBpbmdzKQ0KPiA+ICAgICAgIHJldA0KPiA+ICAgRU5EUFJPQyhwcmVwYXJlX2Vhcmx5 X21hcHBpbmdzKQ0KPiA+DQo+ID4gKy8qDQo+ID4gKyAqIEluIE1NVSBzeXN0ZW0sIHNldHVwX2Zp eG1hcCBpcyB1c2VkIGZvciBYZW4gdG8gbWFwIHNvbWUgZXNzZW50aWFsDQo+ID4gK2RhdGENCj4g PiArICogb3IgZGV2aWNlcyBpbiBib290LXRpbWUuIEluIG9yZGVyIHRvIGJlIGNvbnNpc3RlbnQg d2l0aCBNTVUNCj4gPiArc3lzdGVtLCB3ZQ0KPiA+ICsgKiBpbmhlcml0IHRoZSBmdW5jdGlvbiBu YW1lIGZvciBNUFUgc3lzdGVtLg0KPiA+ICsgKiBzZXR1cF9maXhtYXAgb2YgTVBVIHN5c3RlbSB3 aWxsOg0KPiA+ICsgKiAtIE1hcCB0aGUgZWFybHkgVUFSVCB0byBNUFUgcHJvdGVjdGlvbiByZWdp b24gd2hlbiBlYXJseXByaW50ayBpcw0KPiA+ICsgKiAgIGVuYWJsZWQgKFRoZSBQUklOVCBjYW4n dCBiZSB1c2VkIGFmdGVyIHR1cm5pbmcgb24gTVBVIGJ1dCBiZWZvcmUNCj4gPiArICogICBzZXR1 cF9maXhtYXApLg0KPiANCj4gRm9yIHRoZSBNTVUsIHdlIGhhdmUgdGhpcyByZXN0cmljdGlvbiBi ZWNhdXNlIHRoZSBmaXhtYXAgY291bGQgY2xhc2ggd2l0aA0KPiB0aGUgaWRlbnRpdHkgbWFwcGlu Zy4gSSBkb24ndCB0aGluayB0aGVyZSBhcmUgc3VjaCByZXN0cmljdGlvbnMgZm9yIHRoZSBNUFUN Cj4gYW5kIHRoZXJlZm9yZSBpdCBzZWVtcyBzdHJhbmdlIHRvIHBlcnRhaW4gdGhlIHNhbWUgYmVo YXZpb3IuDQo+IA0KDQpZZXMsIGJvdGggcmVtb3ZpbmcgaWRlbnRpdHkgbWFwcGluZyBhbmQgdXNp bmcgZml4bWFwIHZpcnR1YWwgbWVtb3J5IGxheW91dCBhcmUNCm5vdCBhcHBsaWVkIHRvIHRoZSBN UFUgc3lzdGVtLg0KDQpBbmQgaW4gTU1VIHN5c3RlbSwgdGhlIHNldHVwX2ZpeG1hcCBmdW5jdGlv biBoYXMgYSBiZWhhdmlvciB0byBtYXAgdGhlIFVBUlQNCmZvciBlYXJseSBwcmludGsuIEFuZCB3 ZSBhcmUgb25seSB0cnlpbmcgdG8gcGVydGFpbiB0aGlzIGJlaGF2aW9yIG9uIE1QVSBzeXN0ZW0u IA0KDQo+IEluIGZhY3QsIEkgaGF2ZSBwbGFuIHRvIGdldCByaWQgb2YgdGhpcyByZXN0cmljdGlv biBldmVuIGZvciB0aGUgTU1VLiBTbyBiZXR0ZXINCj4gdGhpcyByZXN0cmljdGlvbiBpcyBub3Qg c3ByZWFkIGlmIHdlIGNhbi4NCg0KSG1tLCBJJ20gYSBiaXQgY29uZnVzZWQgaGVyZS4gV2hpY2gg cmVzdHJpY3Rpb24geW91IGFyZSB0cnlpbmcgdG8gcmVtb3ZlPyBUaGUgd2hvbGUNCmZpeG1hcCB2 aXJ0dWFsIG1lbW9yeSBsYXlvdXQ/DQogDQo+IA0KPiA+ICsgKg0KPiA+ICsgKiBDbG9iYmVycyB4 MCAtIHgzDQo+ID4gKyAqLw0KPiA+ICtFTlRSWShzZXR1cF9maXhtYXApDQo+ID4gKyNpZmRlZiBD T05GSUdfRUFSTFlfUFJJTlRLDQo+ID4gKyAgICAvKiBNYXAgZWFybHkgdWFydCB0byBNUFUgZGV2 aWNlIHJlZ2lvbiBmb3IgZWFybHkgcHJpbnRrLiAqLw0KPiA+ICsgICAgbW92IHgwLCAjQk9PVF9E RVZJQ0VfUkVHSU9OX0lEWA0KPiA+ICsgICAgbGRyIHgxLCA9Q09ORklHX0VBUkxZX1VBUlRfQkFT RV9BRERSRVNTDQo+ID4gKyAgICBhbmQgeDEsIHgxLCAjTVBVX1JFR0lPTl9NQVNLDQo+ID4gKyAg ICBtb3YgeDMsICNQUkJBUl9ERVZJQ0VfTUVNDQo+ID4gKyAgICBvcnIgeDEsIHgxLCB4Mw0KPiA+ ICsNCj4gPiArICAgIGxkciB4MiwgPUNPTkZJR19FQVJMWV9VQVJUX0JBU0VfQUREUkVTUw0KPiA+ ICsgICAgbGRyIHgzLCA9KENPTkZJR19FQVJMWV9VQVJUX0JBU0VfQUREUkVTUyArIEVBUkxZX1VB UlRfU0laRSAtIDEpDQo+ID4gKyAgICBhZGQgeDIsIHgyLCB4Mw0KPiA+ICsgICAgYW5kIHgyLCB4 MiwgI01QVV9SRUdJT05fTUFTSw0KPiA+ICsgICAgbW92IHgzLCAjUFJMQVJfREVWSUNFX01FTQ0K PiA+ICsgICAgb3JyIHgyLCB4MiwgeDMNCj4gPiArDQo+ID4gKyAgICAvKg0KPiA+ICsgICAgICog V3JpdGUgdG8gTVBVIHByb3RlY3Rpb24gcmVnaW9uOg0KPiA+ICsgICAgICogeDAgZm9yIHByX3Nl bCwgeDEgZm9yIHByYmFyIHgyIGZvciBwcmxhcg0KPiA+ICsgICAgICovDQo+ID4gKyAgICB3cml0 ZV9wciB4MCwgeDEsIHgyDQo+ID4gKyNlbmRpZg0KPiA+ICsNCj4gPiArICAgIHJldA0KPiA+ICtF TkRQUk9DKHNldHVwX2ZpeG1hcCkNCj4gPiArDQo+ID4gKy8qIFN0dWIgb2YgcmVtb3ZlX2lkZW50 aXR5X21hcHBpbmcgZm9yIE1QVSBzeXN0ZW1zICovDQo+ID4gK0VOVFJZKHJlbW92ZV9pZGVudGl0 eV9tYXBwaW5nKQ0KPiA+ICsgICAgcmV0DQo+ID4gK0VORFBST0MocmVtb3ZlX2lkZW50aXR5X21h cHBpbmcpDQo+IA0KPiBUaGlzIHN0dWIgY291bGQgYmUgYXZvaWRlZCBpZiB5b3UgbW92ZSB0aGUg Y2FsbCB0byByZW1vdmVfaWRlbnRpdHlfbWFwcGluZw0KPiBpbiBlbmFibGVfbW11KCkgYXMgSSBk aWQgZm9yIGFybTMyLiBTZWUgWzFdLg0KPiANCj4gWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3Jn L2FsbC8yMDIyMTAyMjE1MDQyMi4xNzcwNy0zLWp1bGllbkB4ZW4ub3JnLw0KPiANCg0KVGh4ISBV bmRlcnN0b29kLCBhbmQgSSdsbCB1c2UgdGhlIHNhbWUgbG9naWMgZm9yIGVuYWJsZV9tbXUuDQoN Cj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Mon Nov 07 08:29:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 08:29:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439113.693076 (Exim 4.92) (envelope-from ) id 1orxVT-0006s7-OJ; Mon, 07 Nov 2022 08:29:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439113.693076; Mon, 07 Nov 2022 08:29:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orxVT-0006s0-Lh; Mon, 07 Nov 2022 08:29:23 +0000 Received: by outflank-mailman (input) for mailman id 439113; Mon, 07 Nov 2022 08:29:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orxVS-0006re-0x for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 08:29:22 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46b394fb-5e76-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 09:29:20 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 04298223A1; Mon, 7 Nov 2022 08:29:20 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C303313494; Mon, 7 Nov 2022 08:29:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id VYXcLd/BaGOFKgAAMHmgww (envelope-from ); Mon, 07 Nov 2022 08:29:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46b394fb-5e76-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667809760; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p3Ql0lxrMJTuGFDH/fS7ZqQQpq4iJ92G5JE9oDo+R/E=; b=DaexbtDhP/iJGWRWdyvPE79qm7bGzNacphjd4R8QTSAxR142IT50fRozLTp5F0z1aTfQoV +wgUht52qbGjip3hPwRXDK97NZXVTx02G84czMc3RvKfASi5g9H/wQ5I5Q3pl41yvvMyVe /zUjhYMoSZ3XuWbeMmQ7Y/99AtcqgV0= Message-ID: <367adc31-98e8-bbd5-5d83-02a410b58876@suse.com> Date: Mon, 7 Nov 2022 09:29:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-10-jgross@suse.com> <4fb428cb-242f-1ee7-2dd7-cf32b190ebd6@xen.org> From: Juergen Gross Subject: Re: [PATCH 09/20] tools/xenstore: introduce dummy nodes for special watch paths In-Reply-To: <4fb428cb-242f-1ee7-2dd7-cf32b190ebd6@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------r9XAtbATImkjr0NHJp3RCvRL" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------r9XAtbATImkjr0NHJp3RCvRL Content-Type: multipart/mixed; boundary="------------8mN1V36v0LvGHqq5o0IHrKV0"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <367adc31-98e8-bbd5-5d83-02a410b58876@suse.com> Subject: Re: [PATCH 09/20] tools/xenstore: introduce dummy nodes for special watch paths References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-10-jgross@suse.com> <4fb428cb-242f-1ee7-2dd7-cf32b190ebd6@xen.org> In-Reply-To: <4fb428cb-242f-1ee7-2dd7-cf32b190ebd6@xen.org> --------------8mN1V36v0LvGHqq5o0IHrKV0 Content-Type: multipart/mixed; boundary="------------xl3Wy10wlEjI3wys4bB0rErv" --------------xl3Wy10wlEjI3wys4bB0rErv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMTEuMjIgMjI6MzgsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDAxLzExLzIwMjIgMTU6MjgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBJ bnN0ZWFkIG9mIHNwZWNpYWwgY2FzaW5nIHRoZSBwZXJtaXNzaW9uIGhhbmRsaW5nIGFuZCB3 YXRjaCBldmVudA0KPj4gZmlyaW5nIGZvciB0aGUgc3BlY2lhbCB3YXRjaCBwYXRocyAiQGlu dHJvZHVjZURvbWFpbiIgYW5kDQo+PiAiQHJlbGVhc2VEb21haW4iLCB1c2Ugc3RhdGljIGR1 bW15IG5vZGVzIGFkZGVkIHRvIHRoZSBkYXRhIGJhc2Ugd2hlbg0KPj4gc3RhcnRpbmcgWGVu c3RvcmUuDQo+IA0KPiBBIGZldyBxdWVzdGlvbnMgSSB0aGluayBuZWVkcyB0byBiZSBhbnN3 ZXJlZCBpbiB0aGUgY29tbWl0IG1lc3NhZ2U6DQoNCk9rYXkuIFdpbGwgYWRkLg0KDQo+ICDC oCAtIERvZXMgdGhpcyBtZWFucyB3ZSBjb3VsZCB3cml0ZSBkYXRhIGluICJALi4uIsKgIG5v ZGU/DQo+ICDCoCAtIEhvdyBhYm91dCBjcmVhdGluZyBzdWIgbm9kZXM/DQoNCk5vcm1hbCBY ZW5zdG9yZSBvcGVyYXRpb25zIHdvbid0IHN1Y2NlZWQgZHVlIHRvIHBhdGggbmFtZSBjaGVj a3MuDQoNCkJ1dCBJIGp1c3QgcmVhbGl6ZWQgdGhhdCBhdCBzb21lIHRpbWUgYSBjaHVuayBv ZiB0aGUgcGF0Y2ggbXVzdCBoYXZlIGJlZW4NCmxvc3QsIGFzIEkgb3JpZ2luYWxseSBoYWQg c3BlY2lhbCBjaGVja3MgZm9yIHNldC9nZXQgcGVybWlzc2lvbnMgaW4gcGxhY2UuDQpUaG9z ZSBhcmUgbm8gbG9uZ2VyIHRoZXJlIGFuZCBuZWVkIHRvIGJlIHJlLWFkZGVkLg0KDQo+ICDC oCAtIFdoYXQgZG9lcyBpdCBtZWFuIGZvciB0aGUgYWNjb3VudGluZz8gQmVmb3JlLCBpdCB3 YXMgYWNjb3VudGVkIHRvIG5vLW9uZSANCj4gYnV0IG5vdyBpdCBzZWVtcyB0byBiZSBhY2Nv dW50ZWQgdG8gdGhlIG93bmVyICh3aGljaCBtYXkgbm90IGJlIGRvbTApLg0KDQpZZXMuIEFu ZCB0aGlzIGlzIGhvdyBpdCBzaG91bGQgYmUuDQoNCj4+IFRoaXMgYWxsb3dzIHRvIHNpbXBs aWZ5IHF1aXRlIHNvbWUgY29kZS4NCj4gDQo+IFRoZSBkaWZmIGlzIHF1aXRlIG5pY2UgdG8g aGF2ZSwgYnV0IEkgYW0gbm90IGVudGlyZWx5IGNvbnZpbmNlZCB0aGlzIGlzIG1ha2luZyAN Cj4gdGhlIGNvZGUgZWFzaWVyIHRvIHVuZGVyc3RhbmQuDQo+IA0KPiBJcyB0aGlzIHBhdGNo IGhlbHBpbmcgeW91IGZvciBhbm90aGVyIGdvYWw/DQoNCkl0IHdpbGwgYWxsb3cgdG8gYWRk IG1vcmUgZmluZSBncmFpbmVkIHBlcm1pc3Npb25zIHdoZW4gYWRkaW5nIHRoZSBzdXBwb3J0 DQpmb3IgcmVwb3J0aW5nIHRoZSBkb21pZCBpbiBzcGVjaWFsIGV2ZW50cyAoZS5nLiBhbGxv d2luZyBhIHN0dWJkb20gdG8gd2F0Y2gNCnRoZSBAcmVsZWFzZSBldmVudCBvZiBpdHMgdGFy Z2V0IGRvbWFpbikuDQoNCj4gDQo+Pg0KPj4gTm90ZSB0aGF0IHRoaXMgcmVxdWlyZXMgdG8g cmV3b3JrIHRoZSBjYWxscyBvZiBmaXJlX3dhdGNoZXMoKSBmb3IgdGhlDQo+PiBzcGVjaWFs IGV2ZW50cyBpbiBvcmRlciB0byBhdm9pZCBsZWFraW5nIG1lbW9yeS4NCj4+DQo+PiBTaWdu ZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiAtLS0NCj4+ IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmMgfMKgwqAgMyAtDQo+PiDC oCB0b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jwqDCoMKgIHzCoCA2NyArKysrKysr LS0tLS0NCj4+IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uY8KgIHwgMTYy ICsrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQo+PiDCoCB0b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfZG9tYWluLmjCoCB8wqDCoCA2IC0tDQo+PiDCoCB0b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfd2F0Y2guY8KgwqAgfMKgIDE3ICstLQ0KPj4gwqAgNSBmaWxlcyBjaGFuZ2Vk LCA2MyBpbnNlcnRpb25zKCspLCAxOTIgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdp dCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmMgDQo+PiBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmMNCj4+IGluZGV4IGQxYWFhMDBiZjQuLjQxZTY5 OTI1OTEgMTAwNjQ0DQo+PiAtLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJv bC5jDQo+PiArKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jDQo+PiBA QCAtNjc2LDkgKzY3Niw2IEBAIHN0YXRpYyBjb25zdCBjaGFyICpsdV9kdW1wX3N0YXRlKGNv bnN0IHZvaWQgKmN0eCwgc3RydWN0IA0KPj4gY29ubmVjdGlvbiAqY29ubikNCj4+IMKgwqDC oMKgwqAgaWYgKHJldCkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBnb3RvIG91dDsNCj4+IMKg wqDCoMKgwqAgcmV0ID0gZHVtcF9zdGF0ZV9jb25uZWN0aW9ucyhmcCk7DQo+PiAtwqDCoMKg IGlmIChyZXQpDQo+PiAtwqDCoMKgwqDCoMKgwqAgZ290byBvdXQ7DQo+PiAtwqDCoMKgIHJl dCA9IGR1bXBfc3RhdGVfc3BlY2lhbF9ub2RlcyhmcCk7DQo+PiDCoMKgwqDCoMKgIGlmIChy ZXQpDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgZ290byBvdXQ7DQo+PiDCoMKgwqDCoMKgIHJl dCA9IGR1bXBfc3RhdGVfbm9kZXMoZnAsIGN0eCk7DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmMNCj4+IGluZGV4IDE2NTA4MjE5MjIuLmNhZGIzMzk0ODYgMTAwNjQ0DQo+PiAtLS0g YS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jDQo+PiArKysgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jDQo+PiBAQCAtNjE2LDcgKzYxNiw4IEBAIHN0YXRpYyB2 b2lkIGdldF9hY2NfZGF0YShUREJfREFUQSAqa2V5LCBzdHJ1Y3QgDQo+PiBub2RlX2FjY291 bnRfZGF0YSAqYWNjKQ0KPj4gwqAgc3RhdGljIHVuc2lnbmVkIGludCBnZXRfYWNjX2RvbWlk KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5LA0KPj4gwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IGRvbWlkKQ0KPj4g wqAgew0KPj4gLcKgwqDCoCByZXR1cm4gKCFjb25uIHx8IGtleS0+ZHB0clswXSA9PSAnLycp ID8gZG9taWQgOiBjb25uLT5pZDsNCj4+ICvCoMKgwqAgcmV0dXJuICghY29ubiB8fCBrZXkt PmRwdHJbMF0gPT0gJy8nIHx8IGtleS0+ZHB0clswXSA9PSAnQCcpDQo+IA0KPiBUaGUgY29t bWVudCBhYm92ZSBzYXlzIGl0IGlzIHN1ZmZpY2llbnQgdG8gY2hlY2sgZm9yICcvJy4gQnV0 IG5vdywgeW91IGFyZSBhbHNvIA0KPiBjaGVja2luZyBmb3IgJ0AnLg0KDQpXaWxsIGZpeCB0 aGUgY29tbWVudC4NCg0KPiANCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoCA/IGRvbWlkIDog Y29ubi0+aWQ7DQo+PiDCoCB9DQo+PiDCoCBpbnQgZG9fdGRiX3dyaXRlKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5LCBUREJfREFUQSAqZGF0YSwNCj4+IEBAIC0x NzgwLDE0ICsxNzgxLDYgQEAgc3RhdGljIGludCBkb19zZXRfcGVybXMoY29uc3Qgdm9pZCAq Y3R4LCBzdHJ1Y3QgDQo+PiBjb25uZWN0aW9uICpjb25uLA0KPj4gwqDCoMKgwqDCoCBpZiAo cGVybXMucFswXS5wZXJtcyAmIFhTX1BFUk1fSUdOT1JFKQ0KPj4gwqDCoMKgwqDCoMKgwqDC oMKgIHJldHVybiBFTk9FTlQ7DQo+PiAtwqDCoMKgIC8qIEZpcnN0IGFyZyBpcyBub2RlIG5h bWUuICovDQo+PiAtwqDCoMKgIGlmIChzdHJzdGFydHMoaW4tPmJ1ZmZlciwgIkAiKSkgew0K Pj4gLcKgwqDCoMKgwqDCoMKgIGlmIChzZXRfcGVybXNfc3BlY2lhbChjb25uLCBpbi0+YnVm ZmVyLCAmcGVybXMpKQ0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGVycm5v Ow0KPj4gLcKgwqDCoMKgwqDCoMKgIHNlbmRfYWNrKGNvbm4sIFhTX1NFVF9QRVJNUyk7DQo+ PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDA7DQo+PiAtwqDCoMKgIH0NCj4gDQo+IFNvIHRo ZXJlIGFyZSBhIHNsaWdodCBjaGFuZ2UgaW4gYmVoYXZpb3IgaGVyZS4gQmVmb3JlLCB0aGUg cGVybWlzc2lvbiB3b3VsZCBiZSANCj4gZGlyZWN0bHkgc2V0IGV2ZW4gaWYgd2UgYXJlIGlu IGEgdHJhbnNhY3Rpb24uIE5vdywgdGhpcyB3aWxsIG9ubHkgYmUgc2V0IGlmIHRoZSANCj4g dHJhbnNhY3Rpb24gaGFzIGJlZW4gY29tbWl0dGVkLg0KPiANCj4gSSBhbSBzcGxpdCBvbiB3 aGV0aGVyIHRoaXMgd291bGQgYmUgY29uc2lkZXJlZCBhcyBhbiBBQkkgYnJlYWthZ2UuIFRo ZSBuZXcgDQo+IGJlaGF2aW9yIHNlZW1zIGJldHRlciwgYnV0IGFueW9uZSByZWx5IG9uIHRo ZSAoYm9ndXM/KSBwcmV2aW91cyBiZWhhdmlvciB3b3VsZCANCj4gaGF2ZSBhIHN1cnByaXNl LiBBdCBtaW5pbXVtLCB0aGUgY2hhbmdlIHNob3VsZCBhdCBsZWFzdCBiZSBwb2ludGVkIG91 dCBpbiB0aGUgDQo+IGNvbW1pdCBtZXNzYWdlLg0KDQpJIGRvbid0IHRoaW5rIHRoaXMgd2ls bCBiZSBhIHJlYWwgcHJvYmxlbSwgYXMgdGhlIG9sZCBiZWhhdmlvciB3YXMgbW9yZSBsaWtl DQphIGJ1Zy4gSSdsbCBzcGVsbCBpdCBvdXQgaW4gdGhlIGNvbW1pdCBtZXNzYWdlLg0KDQo+ IA0KPiBbLi4uXQ0KPiANCj4+IMKgIHN0YXRpYyBpbnQgZG9tYWluX3RyZWVfcmVtb3ZlX3N1 Yihjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBjb25uZWN0aW9uICpjb25uLA0KPj4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IG5vZGUgKm5vZGUsIHZv aWQgKmFyZykNCj4+IMKgIHsNCj4+IEBAIC0yOTcsOCArMjczLDI0IEBAIHN0YXRpYyB2b2lk IGRvbWFpbl90cmVlX3JlbW92ZShzdHJ1Y3QgZG9tYWluICpkb21haW4pDQo+PiDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICJlcnJvciB3aGVuIGxvb2tpbmcg Zm9yIG9ycGhhbmVkIG5vZGVzXG4iKTsNCj4+IMKgwqDCoMKgwqAgfQ0KPj4gLcKgwqDCoCBy ZW1vdmVfZG9taWRfZnJvbV9wZXJtKCZkb21fcmVsZWFzZV9wZXJtcywgZG9tYWluKTsNCj4+ IC3CoMKgwqAgcmVtb3ZlX2RvbWlkX2Zyb21fcGVybSgmZG9tX2ludHJvZHVjZV9wZXJtcywg ZG9tYWluKTsNCj4+ICvCoMKgwqAgd2Fsa19ub2RlX3RyZWUoZG9tYWluLCBOVUxMLCAiQHJl bGVhc2VEb21haW4iLCAmd2Fsa2Z1bmNzLCBkb21haW4pOw0KPj4gK8KgwqDCoCB3YWxrX25v ZGVfdHJlZShkb21haW4sIE5VTEwsICJAaW50cm9kdWNlRG9tYWluIiwgJndhbGtmdW5jcywg ZG9tYWluKTsNCj4+ICt9DQo+PiArDQo+PiArc3RhdGljIHZvaWQgZmlyZV9zcGVjaWFsX3dh dGNoZXMoY29uc3QgY2hhciAqbmFtZSkNCj4+ICt7DQo+PiArwqDCoMKgIHZvaWQgKmN0eCA9 IHRhbGxvY19uZXcoTlVMTCk7DQo+PiArwqDCoMKgIHN0cnVjdCBub2RlICpub2RlOw0KPiAN Cj4gSSBjYW4gZm9yZXNlZSBob3cgb25lIG1heSB3YW50IHRvIGFidXNlIGZvciB0aGlzIGZ1 bmN0aW9uLiBTbyBJIHdvdWxkIGFkZCBhbiANCj4gYXNzZXJ0KG5hbWVbMF0gPT0gJ0AnKSB0 byBtYXRjaCBjbGVhciB0aGlzIHNob3VsZCBvbmx5IGZvciB3YXRjaGVzIHN0YXJ0aW5nIHdp dGggDQo+ICdAJy4NCg0KT2theS4NCg0KPiANCj4+ICsNCj4+ICvCoMKgwqAgaWYgKCFjdHgp DQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuOw0KPj4gKw0KPj4gK8KgwqDCoCBub2RlID0g cmVhZF9ub2RlKE5VTEwsIGN0eCwgbmFtZSk7DQo+PiArDQo+PiArwqDCoMKgIGlmIChub2Rl KQ0KPj4gK8KgwqDCoMKgwqDCoMKgIGZpcmVfd2F0Y2hlcyhOVUxMLCBjdHgsIG5hbWUsIG5v ZGUsIHRydWUsIE5VTEwpOw0KPiANCj4gU2hvdWxkbid0IHdlIHRocm93IGEgbWVzc2FnZSBp ZiB3ZSBjYW4ndCByZXRyaWV2ZSBALi4uPw0KDQoNClllcywgSSBjYW4gYWRkIHRoYXQuDQoN Cg0KSnVlcmdlbg0K --------------xl3Wy10wlEjI3wys4bB0rErv Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------xl3Wy10wlEjI3wys4bB0rErv-- --------------8mN1V36v0LvGHqq5o0IHrKV0-- --------------r9XAtbATImkjr0NHJp3RCvRL Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNowd8FAwAAAAAACgkQsN6d1ii/Ey+w BQgAlFIvHkDvlWv0+u8G7cZdqgCYPAyroDKUOYbJz2H1kdZBbMFO2f1pwTWeygMAWbkAkxehLhrU OvbbF0pFYuAlxWqzS2AWXfIEhYpD9IG1lYfCstCauLcR04IfgQ2uSH1OCnMUps6/1L/n3N1i4kxM AN4+vC0R1pvYox3/wD0kN2Wwh4xxUa01BKUZAA76Z4XxbPmolp5YxYwQ/W4+6h+Nu5XSTua64MPF vKjFFqHMGL5LyPcJTVF75L+Vu+Dqdjq5MBzJ87+JwVRzQNltBMmLXYONCAs7Lr+uDFPL3QZFkzJv +Bc0hvANwt4Oj1WG+pt+2tC3sRG0+zI6OBipjXmwEg== =cag1 -----END PGP SIGNATURE----- --------------r9XAtbATImkjr0NHJp3RCvRL-- From xen-devel-bounces@lists.xenproject.org Mon Nov 07 08:30:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 08:30:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439119.693088 (Exim 4.92) (envelope-from ) id 1orxWK-0008Er-6s; Mon, 07 Nov 2022 08:30:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439119.693088; Mon, 07 Nov 2022 08:30:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orxWK-0008Ek-4A; Mon, 07 Nov 2022 08:30:16 +0000 Received: by outflank-mailman (input) for mailman id 439119; Mon, 07 Nov 2022 08:30:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orxWJ-0008Ea-7R; Mon, 07 Nov 2022 08:30:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orxWJ-0000WQ-45; Mon, 07 Nov 2022 08:30:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orxWI-000836-Jl; Mon, 07 Nov 2022 08:30:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orxWI-0006WI-JP; Mon, 07 Nov 2022 08:30:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=shu5uwjJG+mEhWMxu1MIlDZLB5EttjwA0AUl0Aj1l/Y=; b=AV4iAWfn9C6DqBvUYd/4LJS2s1 YRdZLyWHdWv79LqmVLsqUKliIU6QnXdNfjfFMaURDDuPg2hch7DRLMPw09zNs3RmJJxsqmBi0JJ85 fXh1Ji6i5PXjYMsNC/lQaFxkdiR3Qteafy/GwpoOsk0f7M18fYQlAya5YDYG3J0oLLlw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174651: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=466e81ff12013d026e2d0154266fce82bce2ee9b X-Osstest-Versions-That: qemuu=6295a58ad1b73985b9c32d184de7d2ed1fbe1774 From: osstest service owner Date: Mon, 07 Nov 2022 08:30:14 +0000 flight 174651 qemu-mainline real [real] flight 174656 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174651/ http://logs.test-lab.xenproject.org/osstest/logs/174656/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 174656-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174637 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174637 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174637 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 174637 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174637 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174637 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174637 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174637 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174637 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 466e81ff12013d026e2d0154266fce82bce2ee9b baseline version: qemuu 6295a58ad1b73985b9c32d184de7d2ed1fbe1774 Last test of basis 174637 2022-11-05 12:36:57 Z 1 days Testing same since 174651 2022-11-06 23:08:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Williamson Avihai Horon Stefan Hajnoczi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 6295a58ad1..466e81ff12 466e81ff12013d026e2d0154266fce82bce2ee9b -> upstream-tested From xen-devel-bounces@lists.xenproject.org Mon Nov 07 08:34:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 08:34:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439128.693099 (Exim 4.92) (envelope-from ) id 1orxad-0000U2-RH; Mon, 07 Nov 2022 08:34:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439128.693099; Mon, 07 Nov 2022 08:34:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orxad-0000Tv-Ms; Mon, 07 Nov 2022 08:34:43 +0000 Received: by outflank-mailman (input) for mailman id 439128; Mon, 07 Nov 2022 08:34:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orxac-0000Tp-Jd for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 08:34:42 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 05c54c15-5e77-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 09:34:41 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F401322427; Mon, 7 Nov 2022 08:34:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CD75213494; Mon, 7 Nov 2022 08:34:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NOmrMCDDaGMiLgAAMHmgww (envelope-from ); Mon, 07 Nov 2022 08:34:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05c54c15-5e77-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667810081; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VAJ1kO+fnmAEV0aeqESovxRSl7wGOzE6VFgV/ESFKVQ=; b=HqQhkaah43E6NnmTP6X50qB/NNnaAIPTx5cxBVU6gKcMKB69SOfdt13K/IOnsAurk6Qrjt WJqFjEsE94xLNwQarVaoNAGBQvjlH6uTX/d2Q3d8qx3G+E5CSE34R7qYKQ8afo9uGaGyTP Evxvf0zzUSmvWjFI1zUZ470WmFjq0RU= Message-ID: Date: Mon, 7 Nov 2022 09:34:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-14-jgross@suse.com> <32f61945-08fa-f095-02c4-9d52b66b6c04@xen.org> From: Juergen Gross Subject: Re: [PATCH 13/20] tools/xenstore: don't allow creating too many nodes in a transaction In-Reply-To: <32f61945-08fa-f095-02c4-9d52b66b6c04@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------cyTn1bPdAMQvATvJseGesfTm" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------cyTn1bPdAMQvATvJseGesfTm Content-Type: multipart/mixed; boundary="------------Ua0ymXJLDP8Hkftms8yohfFb"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH 13/20] tools/xenstore: don't allow creating too many nodes in a transaction References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-14-jgross@suse.com> <32f61945-08fa-f095-02c4-9d52b66b6c04@xen.org> In-Reply-To: <32f61945-08fa-f095-02c4-9d52b66b6c04@xen.org> --------------Ua0ymXJLDP8Hkftms8yohfFb Content-Type: multipart/mixed; boundary="------------1m3wt6NNR08pSjT8e9FY0OT0" --------------1m3wt6NNR08pSjT8e9FY0OT0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMTEuMjIgMjM6MDAsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDAxLzExLzIwMjIgMTU6MjgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBU aGUgYWNjb3VudGluZyBmb3IgdGhlIG51bWJlciBvZiBub2RlcyBvZiBhIGRvbWFpbiBpbiBh biBhY3RpdmUNCj4+IHRyYW5zYWN0aW9uIGlzIG5vdCB3b3JraW5nIGNvcnJlY3RseSwgYXMg aXQgYWxsb3dzIHRvIGNyZWF0ZSBhcmJpdHJhcnkNCj4+IG51bWJlciBvZiBub2Rlcy4gVGhl IHRyYW5zYWN0aW9uIHdpbGwgZmluYWxseSBmYWlsIGR1ZSB0byBleGNlZWRpbmcNCj4+IHRo ZSBudW1iZXIgb2Ygbm9kZXMgcXVvdGEsIGJ1dCBiZWZvcmUgY2xvc2luZyB0aGUgdHJhbnNh Y3Rpb24gYW4NCj4+IHVucHJpdmlsZWdlZCBndWVzdCBjb3VsZCBjYXVzZSBYZW5zdG9yZSB0 byB1c2UgYSBsb3Qgb2YgbWVtb3J5Lg0KPiANCj4gSSBoYXZlIGFscmVhZHkgbWFkZSBzb21l IG9mIGNvbW1lbnRzIG9uIHRoZSBzZWN1cml0eSBNTCB3aGVuIHRoaXMgd2FzIGluaXRpYWxs eSANCj4gc2V0LiBUaGUgYXJndW1lbnRzIHN0aWxsIGRvbid0IHNvdW5kIHJpZ2h0IHRvIG1l Lg0KPiANCj4gRm9yIGEgZmlyc3QsIHNpbmNlIFhTQS0zMjYsIHdlIGhhdmUgYSBjYXAgaW4g cGxhY2UgZm9yIHRoZSBtZW1vcnkgYSBkb21haW4gY2FuIA0KPiBjb25zdW1lLiBTbyB0aGlz IHN1cmVseSBjYW4ndCBiZSBhICJsb3Qgb2YgbWVtb3J5Ii4gT3RoZXJ3aXNlIHdlIGFyZSBz YXlpbmcgdGhhdCANCj4gb3VyIGxpbWl0ICh0aGVyZSBhcmUgb3RoZXIgd2F5IHRvIGhpdCBp dCkgd2VyZSB3cm9uZy4uLg0KDQpZZWFoLCBtYXliZSBJIHNob3VsZCByZXdvcmsgdGhlIGNv bW1pdCBtZXNzYWdlLg0KDQpUaGUgcmVhc29uIEkgc3RpbGwgd2FudCB0byBrZWVwIHRoZSBw YXRjaCBpcyB0aGF0IGluIGEgdHJhbnNhY3Rpb24gd2l0aG91dCBhbnkNCmNvbmZsaWN0cyBh bmQgd2l0aG91dCBoaXR0aW5nIGFueSB0cmFuc2FjdGlvbiBzcGVjaWZpYyBsaW1pdHMgKG51 bWJlciBvZiBub2Rlcw0KYWNjZXNzZWQpLCB0aGUgZXJyb3JzIHJldHVybmVkIGR1ZSB0byBh IHNpbmdsZSBvcGVyYXRpb24gc2hvdWxkIGJlIHRoZSBzYW1lIGFzDQp3aXRoIHRoZSBzYW1l IG9wZXJhdGlvbiBwZXJmb3JtZWQgb3V0c2lkZSBhIHRyYW5zYWN0aW9uLg0KDQo+IEluIGFk ZGl0aW9uIHRvIHRoYXQsIHRoaXMgaXMgcXVpdGUgcG9pbnRsZXNzIHRvIGNoZWNrIHRoZSBu dW1iZXIgb2YgZW50cnkgYSANCj4gZG9tYWluIGN1cnJlbnRseSBvd25lZCBiZWNhdXNlIHRo aXMgY2FuIGNoYW5nZSBiZWZvcmUgdGhlIHRyYW5zYWN0aW9uIGlzIA0KPiBjb21taXR0ZWQg YnkgYW5vdGhlciAiZXh0ZXJuYWwiIGNvbW1hbmQuIFRoZXJlZm9yZSwgdGhpcyB3b3VsZCBh ZGQgc29tZSANCj4gcmFuZG9tbmVzcyBpbiB0aGUgY29tbWFuZCB3aGljaCBjb3VsZCBtYWtl IG1vcmUgZGlmZmljdWx0IHRvIGRpYWdub3NlLg0KDQpJbiB0aGUgc2NvcGUgb2YgdGhlIHRy YW5zYWN0aW9uIHRoZSB0ZXN0cyBhcmUgY29ycmVjdC4NCg0KPiBMYXN0bHksIHRoZXJlIGFy ZSBvdGhlciB2ZXJ5IGVhc3kgd2F5IHRvIHVzZSBtZW1vcnkgKGp1c3QgY3JlYXRlIG11bHRp cGxlIA0KPiB0cmFuc2FjdGlvbiBpbiBwYXJhbGxlbCkuDQo+IA0KPiBTbyBiYXNlZCBvbiB0 aGUgY29tbWl0IG1lc3NhZ2UsIHRoZSBjaGFuZ2UgZG9lc24ndCBoZWxwIGF0IGFsbCB0byBt YWtlIGJldHRlciANCj4gWGVuc3RvcmVkLg0KPiANCj4gTm90ZSB0aGF0IEkgZG9uJ3QgcGFy dGljdWxhcmx5IG1pbmQgdGhlIGNvZGUgY2hhbmdlIChldmVuIHRob3VnaCBpdCBhZGRzIG1v cmUgDQo+IGNvbXBsZXhpdHkpLiBJIGp1c3Qgc3Ryb25nbHkgZGlzbGlrZSB0aGUgY3VycmVu dCBqdXN0aWZpY2F0aW9ucy4NCj4gDQo+IEF0IHRoZSBtb21lbnQsIEkgY2FuJ3QgZmluZCBh IGp1c3RpZmljYXRpb24gdGhhdCB3b3VsZCBtYWtlIHRoZSBjaGFuZ2Ugd2hvcnRod2hpbGUu DQoNClNlZSBhYm92ZSByZWFzb25pbmcuDQoNCg0KSnVlcmdlbg0KDQo= --------------1m3wt6NNR08pSjT8e9FY0OT0 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------1m3wt6NNR08pSjT8e9FY0OT0-- --------------Ua0ymXJLDP8Hkftms8yohfFb-- --------------cyTn1bPdAMQvATvJseGesfTm Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNowyAFAwAAAAAACgkQsN6d1ii/Ey8T jQgAmZ8iQFQaOJoLEX9g5scOQnb3ufn9fTWwLyTeKv2HrjJvGnYBhN9RhT/jPq+UM2uGVVp+yiU9 TYyIaOv7PYO19LzD7uzTqN58AvglYbNnAT+tZ/5JTZnoVjqn47scistbRWOAIJASweXLDEPaKtnF I9puGQr8hRUFhZXrTofthJ3k0BDgD3RjVeU9st1M0oCrB9FzpTlA0pRz6ATo60pbxyfIkVlvj4d5 UHq83w7WnXg8k73MWo+cVqz7wAgDLah8WdlrAPlm8mKvPyx1SafL8Xa/XbLahxutsZX7L2r/iJqO njW4aSDwQYADWoQr1qrGzNTg28SVDKi3+Q/8sJGOWA== =Yk+J -----END PGP SIGNATURE----- --------------cyTn1bPdAMQvATvJseGesfTm-- From xen-devel-bounces@lists.xenproject.org Mon Nov 07 08:37:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 08:37:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439134.693109 (Exim 4.92) (envelope-from ) id 1orxdD-0001Nr-Bz; Mon, 07 Nov 2022 08:37:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439134.693109; Mon, 07 Nov 2022 08:37:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orxdD-0001Nk-8w; Mon, 07 Nov 2022 08:37:23 +0000 Received: by outflank-mailman (input) for mailman id 439134; Mon, 07 Nov 2022 08:37:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orxdC-0001NO-2T for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 08:37:22 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 651ef6b7-5e77-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 09:37:21 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BDB071F889; Mon, 7 Nov 2022 08:37:20 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 99FF813494; Mon, 7 Nov 2022 08:37:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ymlGJMDDaGOFLwAAMHmgww (envelope-from ); Mon, 07 Nov 2022 08:37:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 651ef6b7-5e77-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667810240; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6YUsFEf/qGWLECBElr0ZiSW2xyh8i4xu80AAPIozFkg=; b=EDS+RoRnOAo0dFu+FqA4NjShTxNiIt39TgR0E/9PiTiOpWsnIpGRMrMZZznvAXmRmaKvFu pXnQeSz4+AySQzUKaJN0oq+HFqUKpzxweTkPSr9ewCSd/NDZ7ZceKq/ukzHzugDsBj2Sxi 7DljwVlu1uK6cz3nJ++cV/NUTU9qwDo= Message-ID: Date: Mon, 7 Nov 2022 09:37:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 17/20] tools/xenstore: switch hashtable to use the talloc framework Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-18-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------PeeJrJUWtagbJZchKH0ULzM3" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------PeeJrJUWtagbJZchKH0ULzM3 Content-Type: multipart/mixed; boundary="------------ue1Lhx1JyFdY70oLFNkackcx"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH 17/20] tools/xenstore: switch hashtable to use the talloc framework References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-18-jgross@suse.com> In-Reply-To: --------------ue1Lhx1JyFdY70oLFNkackcx Content-Type: multipart/mixed; boundary="------------JbvPOoGEwnMTIKWQUv2ZgJPF" --------------JbvPOoGEwnMTIKWQUv2ZgJPF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMTEuMjIgMjM6MDIsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDAxLzExLzIwMjIgMTU6MjgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBJ bnN0ZWFkIG9mIHVzaW5nIG1hbGxvYygpIGFuZCBmcmllbmRzLCBsZXQgdGhlIGhhc2h0YWJs ZSBpbXBsZW1lbnRhdGlvbg0KPj4gdXNlIHRoZSB0YWxsb2MgZnJhbWV3b3JrLg0KPiANCj4g Q2FuIHlvdSBvdXRsaW5lIHdoeSBzd2l0Y2hpbmcgdG8gdGFsbG9jKCkgaXMgYmV0dGVyPw0K DQpJdCBpcyBtb3JlIGNvbnNpc3RlbnQgd2l0aGluIHhlbnN0b3JlZCwgYW5kIGl0IGFsbG93 cyB0byB0cmFjayBtZW1vcnkNCnVzYWdlIGVhc2llciAoc2VlICJ4ZW5zdG9yZS1jb250cm9s IG1lbXJlcG9ydCIgb3V0cHV0KS4NCg0KDQpKdWVyZ2VuDQo= --------------JbvPOoGEwnMTIKWQUv2ZgJPF Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------JbvPOoGEwnMTIKWQUv2ZgJPF-- --------------ue1Lhx1JyFdY70oLFNkackcx-- --------------PeeJrJUWtagbJZchKH0ULzM3 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNow8AFAwAAAAAACgkQsN6d1ii/Ey/F pAf/SVxNlZ70jj4YW7X/3oo/VsiOBPqkDrwktRuuESYc/2SjLjzvyZFsU2nK/a/ToQZ0V54IX657 fSAtu2v1nTlt3y+07GWgN4S1T8XQIsSaqX70RqpMkR3Jk/UXJW9DKEW+5LWKQXzgEEbX04kgz0UK dhqqPjPQSMryG8yC3cRzdTA8BVHMJovF7Yr2CbCCfa9/UoHSucBi0utc1wVIxXw/kf6XG9MxOg1f IubdNCEUIF9Oln84EC7BVFC9gzyITocnTv146mID9rJgrhw/jolRhWzx9A3nkNT68pNR2otlw11h QvoEN5FbTfK5Hw+JMBmkZKb+9b+Ozk7LFUKye3Qk6g== =Jso0 -----END PGP SIGNATURE----- --------------PeeJrJUWtagbJZchKH0ULzM3-- From xen-devel-bounces@lists.xenproject.org Mon Nov 07 08:40:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 08:40:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439140.693120 (Exim 4.92) (envelope-from ) id 1orxg8-0002lD-P2; Mon, 07 Nov 2022 08:40:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439140.693120; Mon, 07 Nov 2022 08:40:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orxg8-0002l6-MP; Mon, 07 Nov 2022 08:40:24 +0000 Received: by outflank-mailman (input) for mailman id 439140; Mon, 07 Nov 2022 08:40:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orxg7-0002kx-7D for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 08:40:23 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d0dc2feb-5e77-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 09:40:21 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A02AB1F889; Mon, 7 Nov 2022 08:40:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5990813494; Mon, 7 Nov 2022 08:40:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6EJ+FHXEaGNnMQAAMHmgww (envelope-from ); Mon, 07 Nov 2022 08:40:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0dc2feb-5e77-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667810421; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gADfYUPeeETCnvisZexZvN1ta8XwRls4wpPuMJJT0Tg=; b=BhOS7WfFV0KhqD96WqwaFZ4SHSxj7PVHEX7g9YOJI08h3ZqA2Wbia2PBpikl1aq9yUrxzp jRFjZVZ9dTkKcLNr9Zej+Vs8Nji0tbqD644Jyxz5AgNuPyYtfM+fEEuPwB1yE79WkzAC3u lt08HtriLyxGqU+eIamdoIIXgUdqDQ4= Message-ID: Date: Mon, 7 Nov 2022 09:40:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 19/20] tools/xenstore: introduce trace classes Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-20-jgross@suse.com> <33e9e356-e8d7-2dfc-a71d-ecbf50a00786@xen.org> From: Juergen Gross In-Reply-To: <33e9e356-e8d7-2dfc-a71d-ecbf50a00786@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------pbDxS0JbVOEUNQiM6zhNs7J1" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------pbDxS0JbVOEUNQiM6zhNs7J1 Content-Type: multipart/mixed; boundary="------------rN6gimbh8h7jppmFNZvwb0bl"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH 19/20] tools/xenstore: introduce trace classes References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-20-jgross@suse.com> <33e9e356-e8d7-2dfc-a71d-ecbf50a00786@xen.org> In-Reply-To: <33e9e356-e8d7-2dfc-a71d-ecbf50a00786@xen.org> --------------rN6gimbh8h7jppmFNZvwb0bl Content-Type: multipart/mixed; boundary="------------cpvG7r54gDdudMUYImV0jAlS" --------------cpvG7r54gDdudMUYImV0jAlS Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMTEuMjIgMjM6MTgsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IEkgaGF2ZW4ndCB5ZXQgbG9vayBhdCB0aGUgY29kZSBpdHNlbGYuIEkgd2FudGVk IHRvIGNvbW1lbnQgb24gdGhlIGV4dGVybmFsIA0KPiBpbnRlcmZhY2VzLg0KPiANCj4gDQo+ IE9uIDAxLzExLzIwMjIgMTU6MjgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBNYWtlIHRo ZSB4ZW5zdG9yZWQgaW50ZXJuYWwgdHJhY2UgY29uZmlndXJhYmxlIGJ5IGFkZGluZyBjbGFz c2VzDQo+PiB3aGljaCBjYW4gYmUgc3dpdGNoZWQgb24gYW5kIG9mZiBpbmRlcGVuZGVudGx5 IGZyb20gZWFjaCBvdGhlci4NCj4+DQo+PiBEZWZpbmUgdGhlIGZvbGxvd2luZyBjbGFzc2Vz Og0KPj4NCj4+IC0gb2JqOiBDcmVhdGlvbiBhbmQgZGVsZXRpb24gb2YgaW50ZXJlc3Rpbmcg Im9iamVjdHMiICh3YXRjaCwNCj4+IMKgwqAgdHJhbnNhY3Rpb24sIGNvbm5lY3Rpb24pDQo+ PiAtIGlvOiBpbmNvbWluZyByZXF1ZXN0cyBhbmQgb3V0Z29pbmcgcmVzcG9uc2VzDQo+PiAt IHdybDogd3JpdGUgbGltaXRpbmcNCj4+DQo+PiBQZXIgZGVmYXVsdCAib2JqIiBhbmQgImlv IiBhcmUgc3dpdGNoZWQgb24uDQo+Pg0KPj4gRW50cmllcyB3cml0dGVuIHZpYSB0cmFjZSgp IHdpbGwgYWx3YXlzIGJlIHByaW50ZWQgKGlmIHRyYWNpbmcgaXMgb24NCj4+IGF0IGFsbCku DQo+Pg0KPj4gUmVuYW1lIHRoZSBtaXNuYW1lZCB4ZW5zdG9yZS1jb250cm9sIGNvbW1hbmRz ICJsb2dmaWxlIiB0byAidHJhY2VmaWxlIg0KPj4gYW5kICJsb2ciIHRvICJ0cmFjZSIuDQo+ IA0KPiBXaGlsZSBJIHVuZGVyc3RhbmQgdGhpcyBtYXkgYmUgbWlzbmFtZWQsIHRoaXMgYWxz byBtZWFucyB0aGF0IHRoZXJlIGlzIGFuIEFCSSANCj4gYnJlYWthZ2UgYmV0d2VlbiBjdXJy ZW50IFhlbnN0b3JlZCBhbmQgdGhlIGZ1dHVyZSBvbmUuDQo+IA0KPiBJIGFtIG5vdCBjb252 aW5jZWQgdGhpcyBpcyBqdXN0aWZpZWQuIFRoZXJlZm9yZSwgSSB0aGluayB3ZSBzaG91bGQg YXQgbWluaW11bSANCj4ga2VlcCB0aGUgY29tcGF0aWJpbGl0eS4NCg0KSG1tLCBJIGNhbiBz ZWUgeW91ciBwb2ludC4gR2l2ZW4gdGhhdCB0aGlzIG1pZ2h0IGJlIG9uZSBvZiB0aGUgbW9z dA0KY29tbW9uIHVzZWQgeGVuc3RvcmUtY29udHJvbCBjb21tYW5kcyBJJ20gbm90IG9wcG9z ZWQgdG8ga2VlcCB0aGUgY3VycmVudA0KbmFtZXMuDQoNCj4gDQo+Pg0KPj4gQWRkIHRoZSBj YXBhYmlsaXR5IHRvIGNvbnRyb2wgdGhlIHRyYWNlIHNldHRpbmdzIHZpYSB0aGUgInRyYWNl Ig0KPj4gY29tbWFuZCBhbmQgdmlhIGEgbmV3ICItLXRyYWNlLWNvbnRyb2wiIGNvbW1hbmQg bGluZSBvcHRpb24uDQo+Pg0KPj4gQWRkIGEgbWlzc2luZyB0cmFjZV9jcmVhdGUoKSBjYWxs IGZvciBjcmVhdGluZyBhIHRyYW5zYWN0aW9uLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEp1 ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+IC0tLQ0KPj4gwqAgZG9jcy9taXNj L3hlbnN0b3JlLnR4dMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwgMTggKysr KysrKy0tLS0NCj4+IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmPCoMKg wqDCoCB8IDQxICsrKysrKysrKysrKysrKysrKystLS0tLQ0KPj4gwqAgdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2NvcmUuY8KgwqDCoMKgwqDCoMKgIHwgNDQgKysrKysrKysrKysrKysr KysrKysrKystLS0NCj4+IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmjCoMKg wqDCoMKgwqDCoCB8wqAgNiArKysrDQo+PiDCoCB0b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmPCoMKgwqDCoMKgIHwgMjcgKysrKysrKystLS0tLS0tLQ0KPj4gwqAgdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMgfMKgIDEgKw0KPj4gwqAgNiBmaWxl cyBjaGFuZ2VkLCAxMDUgaW5zZXJ0aW9ucygrKSwgMzIgZGVsZXRpb25zKC0pDQo+Pg0KPj4g ZGlmZiAtLWdpdCBhL2RvY3MvbWlzYy94ZW5zdG9yZS50eHQgYi9kb2NzL21pc2MveGVuc3Rv cmUudHh0DQo+PiBpbmRleCA0NDQyOGFlM2E3Li45ZGIwMzg1MTIwIDEwMDY0NA0KPj4gLS0t IGEvZG9jcy9taXNjL3hlbnN0b3JlLnR4dA0KPj4gKysrIGIvZG9jcy9taXNjL3hlbnN0b3Jl LnR4dA0KPj4gQEAgLTQwOSwxNCArNDA5LDggQEAgQ09OVFJPTMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgPGNvbW1hbmQ+fFs8cGFyYW1ldGVycz58XQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKg IGVycm9yIHN0cmluZyBpbiBjYXNlIG9mIGZhaWx1cmUuIC1zIGNhbiByZXR1cm4gIkJVU1ki IGluIGNhc2UNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBvZiBhbiBhY3RpdmUgdHJhbnNhY3Rp b24sIGEgcmV0cnkgb2YgLXMgY2FuIGJlIGRvbmUgaW4gdGhhdA0KPj4gwqDCoMKgwqDCoMKg wqDCoMKgIGNhc2UuDQo+PiAtwqDCoMKgIGxvZ3xvbg0KPj4gLcKgwqDCoMKgwqDCoMKgIHR1 cm4geGVuc3RvcmUgbG9nZ2luZyBvbg0KPj4gLcKgwqDCoCBsb2d8b2ZmDQo+PiAtwqDCoMKg wqDCoMKgwqAgdHVybiB4ZW5zdG9yZSBsb2dnaW5nIG9mZg0KPj4gLcKgwqDCoCBsb2dmaWxl fDxmaWxlLW5hbWU+DQo+PiAtwqDCoMKgwqDCoMKgwqAgbG9nIHRvIHNwZWNpZmllZCBmaWxl DQo+IA0KPiBUZWNobmljYWxseSB4ZW5zdG9yZS50eHQgaXMgbWVhbnQgdG8gZGVzY3JpYmUg YW4gaW50ZXJmYWNlIHRoYXQgaXMgDQo+IGltcGxlbWVudGF0aW9uIGFnbm9zdGljcy4gQ2Fu IHlvdSBvdXRsaW5lIGluIHRoZSBkb2N1bWVudGF0aW9uIHdoeSByZW1vdmluZyB0aGVtIA0K PiBpcyBmaW5lPw0KPiANCj4+IMKgwqDCoMKgwqAgbWVtcmVwb3J0fFs8ZmlsZS1uYW1lPl0N Cj4+IC3CoMKgwqDCoMKgwqDCoCBwcmludCBtZW1vcnkgc3RhdGlzdGljcyB0byBsb2dmaWxl IChubyA8ZmlsZS1uYW1lPg0KPj4gK8KgwqDCoMKgwqDCoMKgIHByaW50IG1lbW9yeSBzdGF0 aXN0aWNzIHRvIHRyYWNlZmlsZSAobm8gPGZpbGUtbmFtZT4NCj4+IMKgwqDCoMKgwqDCoMKg wqDCoCBzcGVjaWZpZWQpIG9yIHRvIHNwZWNpZmljIGZpbGUNCj4+IMKgwqDCoMKgwqAgcHJp bnR8PHN0cmluZz4NCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBwcmludCA8c3RyaW5nPiB0byBz eXNsb2cgKHhlbnN0b3JlIHJ1bnMgYXMgZGFlbW9uKSBvcg0KPj4gQEAgLTQzMiw2ICs0MjYs MTYgQEAgQ09OVFJPTMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgPGNvbW1hbmQ+fFs8cGFyYW1l dGVycz58XQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHRoZSBkb21haW4gPGRvbWlkPg0KPj4g wqDCoMKgwqDCoCBxdW90YS1zb2Z0fFtzZXQgPG5hbWU+IDx2YWw+XQ0KPj4gwqDCoMKgwqDC oMKgwqDCoMKgIGxpa2UgdGhlICJxdW90YSIgY29tbWFuZCwgYnV0IGZvciBzb2Z0LXF1b3Rh Lg0KPj4gK8KgwqDCoCB0cmFjZXxbK3wtPHN3aXRjaD5dDQo+IA0KPiBUaGUgcmVnZXggaGVy ZSBpcyBhIGJpdCBhbWJpZ3VvdXMgYmVjYXVzZSBpdCB0ZWNobmljYWxseSBtZWFucyBlaXRo ZXIgIisiIG9yIA0KPiAiLTxzd2l0Y2g+Ii4gRnVydGhlcm1vcmUsIHdpdGhpbiB0aGlzIGRv Y3MsIHRoZXJlIGFyZSBjYXNlIHdoZXJlIHwgaXMgaW5jbHVkZWQgDQo+IGluIGJldHdlZW4g W10gdG8gaW5kaWNhdGUgdGhlIHRoaXMgaXMgdGVybWluYXRlZCBieSBhIFwwLg0KPiANCj4g U28gaXQgd291bGQgYmUgYmV0dGVyIHRvIGRlZmluZSBpdCBvdmVyIDMgbGluZXM6DQo+IA0K PiB0cmFjZQ0KPiB0cmFjZXwrPHN3aXRjaD4NCj4gdHJhY2V8LTxzd2l0Y2g+DQo+IA0KPiBJ IHRoaW5rIGl0IHdvdWxkIGJlIGZpbmUgaWYgdGhlcmUgaXMgb25seSBvbmUgcGFyYWdyYXBo IG9mIGV4cGxhbmF0aW9uIGZvciB0aGUgMy4NCg0KT2theS4NCg0KDQpKdWVyZ2VuDQo= --------------cpvG7r54gDdudMUYImV0jAlS Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------cpvG7r54gDdudMUYImV0jAlS-- --------------rN6gimbh8h7jppmFNZvwb0bl-- --------------pbDxS0JbVOEUNQiM6zhNs7J1 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNoxHUFAwAAAAAACgkQsN6d1ii/Ey/H Ygf+KNJ3VIaM/uHgF/O9t5eOYrVwLbwfrzYIQ8jMkl4nhh7WKVmm4d39nn4Xb0vi3gL6Y1ZRJIaT kcXLVRoPLgXl75Mgejy6BMNylM3bEb/8uxmFbRyctWD6RITpGxeaIE46jS+zArFvFhcAPLoCs097 ZzeVxYnmwHKsOvg2c4oYgiP+Tae7/f/CenRSgw4GJcEcn8A79JwSefOm9sJQXUbljq+r47W1R2A/ 1oudsiqgO5CLzjPli1yNY2rIETdM9nPByQ6FQjO5pxJO0uFAGqjLjsGMpZ/Wgo3vpP3e393i7eP3 zra6Ltfwc592Hq6VDscn1sYkCeX5m1ZqNaycIx2V+A== =LQ73 -----END PGP SIGNATURE----- --------------pbDxS0JbVOEUNQiM6zhNs7J1-- From xen-devel-bounces@lists.xenproject.org Mon Nov 07 09:09:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 09:09:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439150.693132 (Exim 4.92) (envelope-from ) id 1ory8a-0005z2-1z; Mon, 07 Nov 2022 09:09:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439150.693132; Mon, 07 Nov 2022 09:09:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ory8Z-0005yv-VL; Mon, 07 Nov 2022 09:09:47 +0000 Received: by outflank-mailman (input) for mailman id 439150; Mon, 07 Nov 2022 09:09:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ory8Z-0005yp-8b for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 09:09:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ory8Y-0001Nf-C9; Mon, 07 Nov 2022 09:09:46 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ory8Y-0001pX-4Y; Mon, 07 Nov 2022 09:09:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=KYbuF6I8yKepSM7c9qyxAcB4e/ao6uXH366lmrUEvdI=; b=kRahJINS3UGodvyAeiaXF52F1A P/W5AtfavsmRzGlcegf4xCX9B2xkEZEZ4//YHEutkn2FVLN/bPry/fq10YG6TfGXzWmJuf2oS4yNw g4d1kpSrPxRQ9HRZDbclOipUTyUSnInAh3X/dH1d8tehiYK1si+f/w5pJeErLU1VvVOg=; Message-ID: <11459f47-8d9a-9e19-ef1e-b369c7c5e60f@xen.org> Date: Mon, 7 Nov 2022 09:09:41 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build To: Henry Wang , Wei Chen , "xen-devel@lists.xenproject.org" Cc: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-3-wei.chen@arm.com> Content-Language: en-US From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/11/2022 01:33, Henry Wang wrote: > Hi Julien, Hi Henry, > >> -----Original Message----- >> Subject: Re: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been >> loaded in domain_build >> >> (+ Henry) >> I think this wants to be in 4.17. This will avoid Xen to have two >> mappings with different caching attribute (initrd is part of the RAM and >> therefore directmap). > > Sounds good to me, I am wondering if we need to include also patch #1 though. If we were earlier in the release, I would have say yes. But now, it is a no as this just a cleanup (having extra definitions is harmless). > > If this patch wants to be in 4.17: > > Release-acked-by: Henry Wang Thanks! Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 09:11:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 09:11:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439155.693143 (Exim 4.92) (envelope-from ) id 1oryAe-0007Lj-Eh; Mon, 07 Nov 2022 09:11:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439155.693143; Mon, 07 Nov 2022 09:11:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oryAe-0007Lc-Ak; Mon, 07 Nov 2022 09:11:56 +0000 Received: by outflank-mailman (input) for mailman id 439155; Mon, 07 Nov 2022 09:11:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oryAd-0007LW-6M for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 09:11:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2047.outbound.protection.outlook.com [40.107.21.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 378aeb81-5e7c-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 10:11:52 +0100 (CET) Received: from AM5PR0402CA0021.eurprd04.prod.outlook.com (2603:10a6:203:90::31) by DB4PR08MB9334.eurprd08.prod.outlook.com (2603:10a6:10:3f5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 09:11:49 +0000 Received: from VI1EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:90:cafe::91) by AM5PR0402CA0021.outlook.office365.com (2603:10a6:203:90::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 09:11:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT029.mail.protection.outlook.com (100.127.145.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 09:11:48 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Mon, 07 Nov 2022 09:11:48 +0000 Received: from 80438b6f323d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 870B3804-C671-45CC-BC4C-2E852C1E4843.1; Mon, 07 Nov 2022 09:11:42 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 80438b6f323d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Nov 2022 09:11:42 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VI1PR08MB5325.eurprd08.prod.outlook.com (2603:10a6:803:13e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 09:11:40 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Mon, 7 Nov 2022 09:11:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 378aeb81-5e7c-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=crOfXNKqv66+CD8gDo97XbgyoSJtRoAeid+Pa0NISR2+vsTIn5d7ZCpeqziqJzbRN+FlhitDpNPFf/Oj7ZzpdysdWvlId7m4xC37UqMHjC8O1GMOnsfOUj7KJ6+y9IlFLpNKHBHOJCckjk27kAXQSpX7oQNfpSlLbRG0ov5A5xW7DYL21eI9oKRdmfoW70K0CCM4Q6efLQqqt038h+vnoDA6P4OOgY4h803W4d5uhQDNq5mvlk0inYS6bLaZcjzTLN5RVPGewsDbYXLq+DWWN+7Q5ctmBz5mA5Dzgqj6/MHsJIQzVx6nWH1FwEVyRRuczbqSVEPSWDLszhEE6vxLOQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FKXbMp+b50VBowQGYpFZCnf4rjoV+cMblfYMIeEGgrI=; b=mT5x9DZOM+KSlW64kjYKwlOkjRuVe+Fi7csnvvvdywKFRO+VdytUeFpCQ5qo1SLjWjUbYng3cpaUsSyfkgHiCrTF9QnJQ2Ff5FuHPyOqEaI+lULBmIWTeW0QhhGVSPbDbyk1rFCY++z895G1yPl5xRjIhwiEO6tYifCnQCX4XHYTX18nttYUABKXn+SBGapXawBfORVwqTqOOAB3IqbhnN6uD/pklSq3zBu13k5uQqO4YmLK/i1sFNkvEy58Tf8vJoIVFpItECtdQpdC3UK+ucAiXP9Cw+a6gnsfGwnY/33vgk3oSqD+OivKCE9yU212n5RDltEy+C7WgSB/ysF25Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FKXbMp+b50VBowQGYpFZCnf4rjoV+cMblfYMIeEGgrI=; b=4Iqx8O2Z939Nuvf1kYx+198q8ApFnXNBJSHlzItRGRioXLG4DiJG0jcgq5jxzPvPIEODiIUISaWGmkzY1qRMp5YYWXxXLTXCSzrsCIYq+8nxaxOyRLyOf2/cjhDVcb8wnbfvX2/l7hg6xdQVH+YGQVPAmSYJ9bxpWYM7c/iH0o4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YlxnbOpHHo++Rx/LB/vtAqBqwrCN/7c8Yctt7WOfJ0EbKfR9/06e6wcpjFp3BH8iDYAjhRDR+Y5VfrEVbPIakga7s+DadK8ofB6smbYNjEjdBT3rVJXkOGreG74eKUwmSsU0yADkJJ5v5QUlLag8Uk0FnH4x2yo8leD0ToaKjZVm4vEi2DDZJ/fI/ILb2mnDxtcqR8J+54JUdRKE/l3WfYrjFY6o3iFhu75VGPQN9vnKpf5mdvkCnbeTqMVguGsHO4BV83L12fPu77taQeDIdQtLt59G/BgPQBAR0wC1myEzQXkKeNjk6QMWAZqh1qid3ILL5Ie4UOh+gwgWdBdqag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FKXbMp+b50VBowQGYpFZCnf4rjoV+cMblfYMIeEGgrI=; b=MVxswJ7v475WeP9b2X2l3eVz4ozGh57StbvG+LpDvLw8I7q3hmrbfxkU9Cbk/gLQxbZx0m45yUX/oX/8KddNgtC5nnQHVNnly0fswq/gDkwArr6UvX6uOQdOkpqk1Ln1D2kpk/0nrew2n0wIoY0/J/711jxH42KCKwFfsXrhLAkP3QlJpMxJUuzkqfgXCLfj6/ulRvil8j5XhUGd55O9MG/z/LCHRGr62KVFKosZLvJNDfb5jB2xnL6Z5VRzgzVavrZjydRyKvQgVj0QRKbkcCT6tw9/6Wf7eom9/IebSDj6FxUst2Pq0YQc8Rm6lEf6qIWK2qMlInh3PBswVp/f+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FKXbMp+b50VBowQGYpFZCnf4rjoV+cMblfYMIeEGgrI=; b=4Iqx8O2Z939Nuvf1kYx+198q8ApFnXNBJSHlzItRGRioXLG4DiJG0jcgq5jxzPvPIEODiIUISaWGmkzY1qRMp5YYWXxXLTXCSzrsCIYq+8nxaxOyRLyOf2/cjhDVcb8wnbfvX2/l7hg6xdQVH+YGQVPAmSYJ9bxpWYM7c/iH0o4= From: Henry Wang To: Julien Grall , Wei Chen , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build Thread-Topic: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build Thread-Index: AQHY8DVtbyg+f3V3FU++xEj+lazfQ64yQiqAgABu86CAAH/OgIAAAEDA Date: Mon, 7 Nov 2022 09:11:39 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-3-wei.chen@arm.com> <11459f47-8d9a-9e19-ef1e-b369c7c5e60f@xen.org> In-Reply-To: <11459f47-8d9a-9e19-ef1e-b369c7c5e60f@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: AA02046F2FAFD54FB8F47FF8E4CD6A9A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|VI1PR08MB5325:EE_|VI1EUR03FT029:EE_|DB4PR08MB9334:EE_ X-MS-Office365-Filtering-Correlation-Id: c66b7b11-3ca2-4d7f-d150-08dac0a019bb x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KTXMp9NbH6RPF2DEfO6LTnMtJDeUcC7RA80PGkO+Z8CK34QSFODz/ktXqg6lHHFnnXigGP9kr5cvt870J+yyTy2A1IDxkQccSrA7Cr1TPKGLC11a16LZWIM/rgb/1YDcSw8W3PHKJkI+MM4hacubpIbssIaSKuw+BXZ+upvyYgb/pohJY46eH6Fcahs3JaXOeVu6VDDqHAI/SP462CxYXvd7U9o1F6V8W+Y3ubQcm2EGsVpCTfvQYcZwHOFkRbRTskDyLxJB8e6XEvhSXfy++EPOt3coXTJkiMuYlXSEMFdsFHfbJFp0HO0FsXg10Fy6T6QkvLK1IWxzkV5XtPNvtMSoLLLjpPL/DnZaUuFARhJpvycgxuQBOx0zn+GOasHRgwV4cC52oapcFZbacxCqhG381ZjfAbzo9uPWGz81MMohADZ78crX8NDD/nSMnMjzUID2+ffu7kJXK5iZ4637p4wq3PfH5p6lyynl2swIACRHxrY2qLfheTvDiajdJqaYJY4/qsTyMraaBA3mTHHnuHt7DRIL/O1OSKfhOpISnvwBvWppLbSI0chBVxkBF+IaCMZ/rwpoDOflaLNtzuIULJg4zPwhMqFluzzw0LGPnfoIyL7l0lYaMiedtl9PbS6iY2/+VWG0BS83mSUBVIEed59HfyUpPgRJZtRDhZEz012YGXaG3629W4m/ZMrhrE8azG+NDpO72MDfYFgtnCoLE+fKbUQod4t/46DQLxz2cVX0vzRXea0K4N9g2+wTdtJM9NUfhBB5VGYvNjh2k8NM5g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39850400004)(366004)(451199015)(71200400001)(54906003)(110136005)(55016003)(478600001)(316002)(66556008)(8676002)(4326008)(66476007)(66446008)(26005)(64756008)(76116006)(52536014)(41300700001)(186003)(8936002)(4744005)(5660300002)(6506007)(7696005)(9686003)(33656002)(83380400001)(86362001)(2906002)(66946007)(38100700002)(122000001)(38070700005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5325 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d2021e37-7b90-433f-e6b5-08dac0a014a3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +lG+zPYi6kT8HlksONKEa0gUYXIM/qq8Pjqsryz4Xl/Sb7Kr6RyLOG3x7mje6YmwU+umZTmOT6nIOe4RzCBXv1/IT8S3lrTHFrPApzHl5mS3fNZbDm+bg+ELYn6RcLIfrl6H/sqCtBEZCv2YGDmjre7FhykNPfgsKZ7yUalaMk+h6Dgb4MeTb1UyAyCLwNv95LoApTWDlMJMBcjd3d+QI1/SXmE+fijHlJ5jmQWkK+yYrxyC6/Q/5ah0rAAx+Vt9+d2uu0zVmtgcZzKNjD64WCVY/Qmcb/UxX5KlIuKTaZzhetOQx3P7/X3YlCs2jEMVmBozYez85RTQlIIUMxjGGxHxAYKV2kI4bOo15+jZvktBB3/BWSJmqOnNXWl+veaQVZYNF4ruYjJbs5g4XlPyp3gSEHWSc9/kxIs4OLDjA8WtfgPdwgTVbLWdAfrwRcAT4EhACyLTfJHiw+cK0RpqHFaccz9q8DtSJ0P5Tc2/FzpJKb4DXvHm/mP5R7eZ9Qqb/lkS9Vpis1UhPK2rbw7w7DzuEkNp61+0reLNTstzcK6pofT2miBKHxTs4lfgNtXU7q89JTPXYcn+3mTEfomzB4JQsWxIZcIIxSNi+5VRCPiHfYNcftr+4hscvxzj6HsbeDfgXOjY/OcsKDFSP+VT2vCcgbnoKI2u4kGzFRcnA23v3nE8GrjEdPTfiHTJHSYFz5uxqQ1vTzdpLdbRU/fYfcXYxk6VoSN33BfeuoFTMNQ= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39850400004)(451199015)(36840700001)(46966006)(70586007)(55016003)(8676002)(70206006)(4326008)(40480700001)(36860700001)(316002)(54906003)(336012)(110136005)(33656002)(8936002)(5660300002)(41300700001)(6506007)(52536014)(82740400003)(4744005)(7696005)(107886003)(2906002)(83380400001)(186003)(9686003)(47076005)(26005)(478600001)(86362001)(356005)(81166007)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 09:11:48.4292 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c66b7b11-3ca2-4d7f-d150-08dac0a019bb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9334 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFJl OiBbUEFUQ0ggdjYgMDIvMTFdIHhlbi9hcm06IGFkZCBpb3VubWFwIGFmdGVyIGluaXRyZCBoYXMg YmVlbg0KPiBsb2FkZWQgaW4gZG9tYWluX2J1aWxkDQo+ID4+ICgrIEhlbnJ5KQ0KPiA+PiBJIHRo aW5rIHRoaXMgd2FudHMgdG8gYmUgaW4gNC4xNy4gVGhpcyB3aWxsIGF2b2lkIFhlbiB0byBoYXZl IHR3bw0KPiA+PiBtYXBwaW5ncyB3aXRoIGRpZmZlcmVudCBjYWNoaW5nIGF0dHJpYnV0ZSAoaW5p dHJkIGlzIHBhcnQgb2YgdGhlIFJBTSBhbmQNCj4gPj4gdGhlcmVmb3JlIGRpcmVjdG1hcCkuDQo+ ID4NCj4gPiBTb3VuZHMgZ29vZCB0byBtZSwgSSBhbSB3b25kZXJpbmcgaWYgd2UgbmVlZCB0byBp bmNsdWRlIGFsc28gcGF0Y2ggIzENCj4gdGhvdWdoLg0KPiANCj4gSWYgd2Ugd2VyZSBlYXJsaWVy IGluIHRoZSByZWxlYXNlLCBJIHdvdWxkIGhhdmUgc2F5IHllcy4gQnV0IG5vdywgaXQgaXMNCj4g YSBubyBhcyB0aGlzIGp1c3QgYSBjbGVhbnVwIChoYXZpbmcgZXh0cmEgZGVmaW5pdGlvbnMgaXMg aGFybWxlc3MpLg0KDQpUaGFua3MgZm9yIHlvdXIgY29uZmlybWF0aW9uIDopIE5vIHByb2JsZW0u DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCg== From xen-devel-bounces@lists.xenproject.org Mon Nov 07 09:30:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 09:30:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439163.693154 (Exim 4.92) (envelope-from ) id 1oryRy-00010a-0o; Mon, 07 Nov 2022 09:29:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439163.693154; Mon, 07 Nov 2022 09:29:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oryRx-00010T-UP; Mon, 07 Nov 2022 09:29:49 +0000 Received: by outflank-mailman (input) for mailman id 439163; Mon, 07 Nov 2022 09:29:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oryRx-00010N-1d for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 09:29:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oryRw-0001tE-Oj; Mon, 07 Nov 2022 09:29:48 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oryRw-0002Rs-I9; Mon, 07 Nov 2022 09:29:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ZOJWmLcw7kp92I3QuTPAmxq0F/w3g3ZOSqznM6TbQT4=; b=dkIk1/AAej+02hmwO3kwQxsUD2 WbCKfA/QaRqUgP6a+A+G6BJN4M8tuJwrvnTNEYzztm/EkImRnrle7gR8fKKkJszQ1YHsQL7KuXgLD jIs+daSNS1F/bDpRIziRLxl/f0p67Ea0yxboN+FIRaVWrCo1ITRLPYxg6iuljgjuLiig=; Message-ID: Date: Mon, 7 Nov 2022 09:29:46 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 09/11] xen/arm64: create boot-time MPU protection regions Content-Language: en-US To: Penny Zheng , Wei Chen , "xen-devel@lists.xenproject.org" Cc: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-10-wei.chen@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/11/2022 06:59, Penny Zheng wrote: > Hi Julien Hi Penny, >>> + >>> +/* >>> + * In boot stage, we will use 1 MPU region: >>> + * Region#0: Normal memory for Xen text + data + bss (2MB) >>> + */ >> >> Are we only going to modify the MPU in head.S? If not, then I would >> define the layout in config_mpu.h so there are a single point where you >> can read how this works. >> > > We will remap Xen in C codes in setup_mm(). > The whole strategy is aligned with MMU: a very simple setup(map xen > with the maximum size, 2M) at start-of-the-day, and a fit map in > setup_mm. The strategy we are using for the MMU is completely broken (not compliant with the Arm Arm) and unnecessary. My long term goal is to actually remove the switch_ttbr() and most of setup_pagetables() for all setup but cache coloring. This means the concept of boot pages will not exist anymore. For the MPU, we should aim to do better than what was done for the MMU. Right now, I see no argument for switching MPUs table. I am only seen argument against it because you need to disable the cache and is quite fragile. [...] >>> + >>> + ldr x2, =XEN_START_ADDRESS >>> + mov x3, #(XEN_START_MEM_SIZE - 1) >> >> XEN_START_MEM_SIZE is the maximum size of Xen. IOW, Xen may be >> smaller >> and you will map memory that may not be part of Xen. Therefore, you >> likely want to compute the real size to avoid mapping too much. >> > > Later, in setup_mm we will map XEN components by components, such as, > one MPU memory region for read-only-executable text section, one > MPU memory region for read-only data section, etc, etc. > So in there, XEN will be mapped fitly. But what prevents you to do this now? > > IMHO, the mapping in compiler with maximum size of Xen is also what > MMU does. Which is broken because we don't know what located after Xen binary. This could be reserved RAM, device which may requires non-caching attribute. Mapping those regions with caching attributes is going to break. As I hinted above, there are a very long list of issues in the MMU boot code. So don't take that code for granted. Your MPU code should first be compliant with the Arm Arm. If it is close to the MMU code then that's a bonus. But bear in mind that the code may look very different soon (see [1]). Cheers, [1] 20221022150422.17707-1-julien@xen.org -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 09:32:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 09:32:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439168.693165 (Exim 4.92) (envelope-from ) id 1oryUE-0002N8-D6; Mon, 07 Nov 2022 09:32:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439168.693165; Mon, 07 Nov 2022 09:32:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oryUE-0002N1-A0; Mon, 07 Nov 2022 09:32:10 +0000 Received: by outflank-mailman (input) for mailman id 439168; Mon, 07 Nov 2022 09:32:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oryUC-0002Mv-Rd for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 09:32:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oryUC-0001vo-J6; Mon, 07 Nov 2022 09:32:08 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oryUC-0002TU-Cy; Mon, 07 Nov 2022 09:32:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=I9hH1fLXPPrBsQbGhk75XTpGpv5QLz9MKr1927Qf1rA=; b=tPvsNviP7t/51DRRHlgJ8N2fOL 1FfkazmavVEGHGHRD4eDDaJtSiRtW+lXnW5UjJOZCdNh2XiXlJfTlZHVHeCfjQnc2h2+xaOztnaAs YtpehE0L0hlFWhNlGR5fT2Bn9vTP+m5U3rG7E77/80hOPbxZ8j4yLvcLoNkjtsXTkufI=; Message-ID: <19148b2c-7154-b482-ebeb-71692cb6a1f7@xen.org> Date: Mon, 7 Nov 2022 09:32:06 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 11/11] xen/arm64: add setup_fixmap and remove_identity_mapping for MPU Content-Language: en-US To: Penny Zheng , Wei Chen , "xen-devel@lists.xenproject.org" Cc: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-12-wei.chen@arm.com> <84e476a5-9365-bb80-a8e2-86dcf09681f0@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 07/11/2022 08:13, Penny Zheng wrote: >> -----Original Message----- >> From: Julien Grall >> Sent: Monday, November 7, 2022 5:02 AM >> To: Wei Chen ; xen-devel@lists.xenproject.org >> Cc: nd ; Penny Zheng ; Stefano >> Stabellini ; Bertrand Marquis >> ; Volodymyr Babchuk >> >> Subject: Re: [PATCH v6 11/11] xen/arm64: add setup_fixmap and >> remove_identity_mapping for MPU >> >> Hi, >> >> On 04/11/2022 10:07, Wei Chen wrote: >>> From: Penny Zheng >>> >>> setup_fixmap and remove_identity_mapping are two functions that are >>> used in Xen boot-time code flow. We implement these two functions for >>> MPU system, in this case, the code flow in head.S doesn't need to use >>> #ifdef to gate MPU/MMU code. >>> >>> In MMU system, setup_fixmap is used for Xen to map some essentail data >>> or devices in boot-time. For MPU system, we still have this >>> requirement, we map the early UART to MPU protection region when >>> earlyprintk is enabled. This also means PRINT can't be used after >>> turning on MPU but before setup_fixmap. This restriction is the same >>> as MMU system. >>> >>> For remove_identity_mapping, we just need an empty function to make >>> head.S code flow happy. >>> >>> Signed-off-by: Wei Chen >>> Signed-off-by: Penny Zheng >>> --- >>> xen/arch/arm/arm64/head_mpu.S | 49 +++++++++++++++++++ >>> .../arm/include/asm/platforms/fvp_baser.h | 4 ++ >>> 2 files changed, 53 insertions(+) >>> >>> diff --git a/xen/arch/arm/arm64/head_mpu.S >>> b/xen/arch/arm/arm64/head_mpu.S index 5a1b03e293..336c0a630f >> 100644 >>> --- a/xen/arch/arm/arm64/head_mpu.S >>> +++ b/xen/arch/arm/arm64/head_mpu.S >>> @@ -20,13 +20,20 @@ >>> /* >>> * In boot stage, we will use 1 MPU region: >>> * Region#0: Normal memory for Xen text + data + bss (2MB) >>> + * Region#1: Device memory for EARLY UART, size is defined >>> + * by platform's EARLY_UART_SIZE >>> */ >>> #define BOOT_NORMAL_REGION_IDX 0x0 >>> +#define BOOT_DEVICE_REGION_IDX 0x1 >>> >>> /* MPU normal memory attributes. */ >>> #define PRBAR_NORMAL_MEM 0x30 /* SH=11 AP=00 XN=00 */ >>> #define PRLAR_NORMAL_MEM 0x0f /* NS=0 ATTR=111 EN=1 */ >>> >>> +/* MPU device memory attributes. */ >>> +#define PRBAR_DEVICE_MEM 0x20 /* SH=10 AP=00 XN=00 */ >>> +#define PRLAR_DEVICE_MEM 0x09 /* NS=0 ATTR=100 EN=1 */ >>> + >>> .macro write_pr, sel, prbar, prlar >>> msr PRSELR_EL2, \sel >>> dsb sy >>> @@ -69,6 +76,48 @@ ENTRY(prepare_early_mappings) >>> ret >>> ENDPROC(prepare_early_mappings) >>> >>> +/* >>> + * In MMU system, setup_fixmap is used for Xen to map some essential >>> +data >>> + * or devices in boot-time. In order to be consistent with MMU >>> +system, we >>> + * inherit the function name for MPU system. >>> + * setup_fixmap of MPU system will: >>> + * - Map the early UART to MPU protection region when earlyprintk is >>> + * enabled (The PRINT can't be used after turning on MPU but before >>> + * setup_fixmap). >> >> For the MMU, we have this restriction because the fixmap could clash with >> the identity mapping. I don't think there are such restrictions for the MPU >> and therefore it seems strange to pertain the same behavior. >> > > Yes, both removing identity mapping and using fixmap virtual memory layout are > not applied to the MPU system. > > And in MMU system, the setup_fixmap function has a behavior to map the UART > for early printk. And we are only trying to pertain this behavior on MPU system. > >> In fact, I have plan to get rid of this restriction even for the MMU. So better >> this restriction is not spread if we can. > > Hmm, I'm a bit confused here. Which restriction you are trying to remove? The fact that the fixmap entry is not created in create_page_tables() (now prepare_early_mappings()). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 09:34:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 09:34:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439173.693176 (Exim 4.92) (envelope-from ) id 1oryW5-0002xY-ON; Mon, 07 Nov 2022 09:34:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439173.693176; Mon, 07 Nov 2022 09:34:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oryW5-0002xR-LR; Mon, 07 Nov 2022 09:34:05 +0000 Received: by outflank-mailman (input) for mailman id 439173; Mon, 07 Nov 2022 09:34:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oryW3-0002xC-Gy for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 09:34:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oryW3-0001xS-9E; Mon, 07 Nov 2022 09:34:03 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oryW3-0002en-3I; Mon, 07 Nov 2022 09:34:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=fh+/3JjT08V2mpQpJKIyrhxR5RAJjEc00gsvoahjXWA=; b=P4FXrb656+dEAGwIGoWXOVB1df 8E33I+8TiyM8DbD+3O08jnLxtzYfQtljJJr2JROgv/hJOWF59favY7IVlBBMNsXOL3rTJ3YO+tWpJ 46o+2UEdm5tAmPb0oMHtZJ2fZcl2rzDeB407AuKaBnDoeYSyyNEFP3pnrYPK/gWP/QSY=; Message-ID: Date: Mon, 7 Nov 2022 09:34:00 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 08/11] xen/arm64: move MMU related code from head.S to head_mmu.S Content-Language: en-US From: Julien Grall To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Henry Wang References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-9-wei.chen@arm.com> <5b975a59-5e97-c2a8-805c-9ab99b8712aa@xen.org> In-Reply-To: <5b975a59-5e97-c2a8-805c-9ab99b8712aa@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/11/2022 20:06, Julien Grall wrote: > Hi Wei, > > On 04/11/2022 10:07, Wei Chen wrote: >> There are lots of MMU specific code in head.S. This code will not >> be used in MPU systems. If we use #ifdef to gate them, the code >> will become messy and hard to maintain. So we move MMU related >> code to head_mmu.S, and keep common code still in head.S. > > I am afraid that you can't simply move the MMU code out of head.S > because this will break Xen when running using the identity map. > > This is because we only map the first 4KB of Xen with PA == VA. At the > moment, we guarantee it by having everything that needs to be used in > the identity mapping before _end_boot and checking at link time if this > fits in 4KB. > > Now that you moved the MMU code outside of head.S. We need to find a > different way to guarantee it. One way to do it would be to create a > section that would be used for everything that needs to be identity mapped. Looking at the code this morning, I noticed that we already have the section ".text.header". For now, that should do the job. So we just need to check the size of .text.header. Ideally, checking the size should be done in a separate pre-patch so it is easier to review. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 09:53:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 09:53:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439183.693187 (Exim 4.92) (envelope-from ) id 1oryoh-0005pP-Ah; Mon, 07 Nov 2022 09:53:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439183.693187; Mon, 07 Nov 2022 09:53:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oryoh-0005pI-7u; Mon, 07 Nov 2022 09:53:19 +0000 Received: by outflank-mailman (input) for mailman id 439183; Mon, 07 Nov 2022 09:53:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oryog-0005pC-Br for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 09:53:18 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20088.outbound.protection.outlook.com [40.107.2.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ffa909f3-5e81-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 10:53:15 +0100 (CET) Received: from AS9P250CA0013.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::24) by VI1PR08MB5326.eurprd08.prod.outlook.com (2603:10a6:803:12d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 09:53:12 +0000 Received: from AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:532:cafe::59) by AS9P250CA0013.outlook.office365.com (2603:10a6:20b:532::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 09:53:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT046.mail.protection.outlook.com (100.127.140.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 09:53:12 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Mon, 07 Nov 2022 09:53:11 +0000 Received: from 3c64637a45fc.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 02CAC80B-A1DD-4158-A8D9-162AD6AEE340.1; Mon, 07 Nov 2022 09:53:01 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3c64637a45fc.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Nov 2022 09:53:01 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AS8PR08MB8876.eurprd08.prod.outlook.com (2603:10a6:20b:5b6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 09:53:00 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5813.011; Mon, 7 Nov 2022 09:53:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ffa909f3-5e81-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=n6aUsPpy/m8y/R8KEbFuwW+z83TClulDxQXYmtvyzcSScf/HO3aLbb1ls1VPZ3gRH0gepI7687Ytizdod3TChr8kcdvHhYiyHTVox5jY9YKI0LM2Lue07/8Lc9i98X5/aodWWkNx8OOvOJTQVIYfYqJ7dbtk840OQZd2vWTcRaHW5VPEuH1kO/Y/m6iDmLVkTIPzHlpIeCTL1FzVExDjnBJS0PCxqQZ35x+B9vXclDNxtLy7ZGoAxHGMNLGNemThs/ks9Q+p6mcfkFYvyWyWI6Xx+KNR5brZEcxyISgHPkpcGiEEZAz5iL09FfbDGw8gSl8ciSqYCEziEgEQYd0ncQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tPfUGmEQHv5roDDeJy+dBXXqokxm5XWgIUp/LZUDb9k=; b=gXPzBdYJfZ8mTLjsAHUoyoWJlqKuQTo0MgUoslzcqW13sCIBhcMa59AyxAZiU4gyU94VFaBRq6x0tRQF+78obXkLrES0P0lHeGd47zsgIZioEmxKtCQ0YCJYISOvPRx7HSS7qkl4Huy+IswWSkka7fzQrt7F718Ne4Cidi29rTwMGnOJTCx79fvpBA1XYJ3qEOtFMZotkEh1qN+lG0mxX4WwUra8OnsxkDS62GuT6xtLvbrkxsxXcgDOusvWx1fQ3d1K6FL03lfDE4PPSXnasN65KJ0S1JmmiTwT3vPCAisI7KXw6eVyYZJNTDKQuCNaStPLtBq5fE2usfHcoiZCNg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tPfUGmEQHv5roDDeJy+dBXXqokxm5XWgIUp/LZUDb9k=; b=F5phwd7N0VjniMyanKDxqFzx9FCZW4dTbtokWB2MnNKG8seZHPJ+m4nH1bto8aEzFX4hPKcblQiHC0qCi7c9kW4QgH5VWBkuOgJ5HJ7mR5mEpgdhz0deM5gFmaTu/ShMBEQP8TlOg7DVlWFyEVHKiT92MkwYZFZqdK6UlP3Y194= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YNL3dVNdkdVo3W7x4Jin8f+B3dhYn5DLhDtMLQYd/shg3oGB8DCiV1ZrvGbnq/3joroMSpDuiXuPJIAU8d7bJh8oIobaTFuXl0OFsA1w59beJ1obNA1+Rmyye1qRoMvbp/imROviw+cyekdS1D6Bh4C1yE4vcqmfTRZHyXnkqWbsNcjaQyNlIjjNccpKry+FKKYnxC208geV6WmLjSW+WavERWuarpRgCgPqb2DysBiLkvU/jHZTguY82shxth9Mp2lnj1t7dG0KP2ZOxPMthR3lh0DPn+ht0/jlr9VRUY/ziKtZJj2OVuuRUv/sGGwsdl0C+HiGKhk2rWCI2ai20A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tPfUGmEQHv5roDDeJy+dBXXqokxm5XWgIUp/LZUDb9k=; b=A9w5nJqEIJ04VDK90uMDzLfkcow6keS1XKBe7xGn1TXaf49sYrckdSErJt78cx7mAx0MFpX5rCX6n1ne3kGhoPtNbXf2LaL4E5Z2PCP4TcGS7D21iaD186733U4MmkFyk2ttr6ojYpSuRR+KZCoL7TGIjQ2PHzgwYjTr3pGZaJHSX1KKLOQESnZD+eHd/Y1LiglHdhvoqLq0VeQOGwzlL4HoCCfucPSzWKKn9+COdwP/CcLVbaIJzYrvH7iH08tXw7SUx00FjThKHaA/B1saxCg3pacCfhBIScALbIFYgGM8Cns9NNf5vBJiYUjwKY5UOzLrnqYRizK5wFJ/7p/s2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tPfUGmEQHv5roDDeJy+dBXXqokxm5XWgIUp/LZUDb9k=; b=F5phwd7N0VjniMyanKDxqFzx9FCZW4dTbtokWB2MnNKG8seZHPJ+m4nH1bto8aEzFX4hPKcblQiHC0qCi7c9kW4QgH5VWBkuOgJ5HJ7mR5mEpgdhz0deM5gFmaTu/ShMBEQP8TlOg7DVlWFyEVHKiT92MkwYZFZqdK6UlP3Y194= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 Thread-Topic: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 Thread-Index: AQHY8DVcKFNDls96akm0LlhB1cf9B64yRBkAgADyKCA= Date: Mon, 7 Nov 2022 09:52:59 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <9c3bfa0c-2c8f-2160-46d1-3be234b5bcaf@xen.org> In-Reply-To: <9c3bfa0c-2c8f-2160-46d1-3be234b5bcaf@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: AE924A1660C1B445B58870C16871251E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|AS8PR08MB8876:EE_|AM7EUR03FT046:EE_|VI1PR08MB5326:EE_ X-MS-Office365-Filtering-Correlation-Id: 50d36046-5d8d-41d9-ecc3-08dac0a5e213 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GlLaXI6ai48Jf44/aRqXggBZnOttNBh7i/oQXMMe2h4DYmf8hob/qcXz8QHtqrTMjPFi+jfAB5IO5x/nBBhfqEi5Fy59MuF01zPvquItMEh9Bheo/X5kyxkEbrJRwWkuWsW3xUB4bZk1ZdN2KczMpJAjyxvNw4umP7+FKwKa5KRBbSfApow24A8iogHm5+AeVAK+Go8AN0Au9NGpHEa+j6aqYL4+7rGnUn22cqnrsxpSMi8Nj3XOUi+bcNkXPDoaVXV8U0a+SHJVhgwWNT43IeW82S6Ch9teog/ZZmOOBtyPE8Io0xnSCnlp/rtvAh/KUWiGHDB+K26fMDxOvZKg5g9nicClWYhbTMDgqJPmMMNyoqZLS1IOZTtHc9l4lj+IzVuzs/s8nt1H5zenXltxGWdcS/Nd7OHYad1wf7niFpaaKzrOJzbEJWqeQiaYQmVi1I+ESGiA2rZ46LBMfsJB/j8WBRss4BSoA0avGX3CqSa6s0QwrPuqKqh+Uip/fog8GOmi6TFe1bbyR2jtLt3cuViEgY9/gG/NrQpvF6gR00HwOyqoBRkCWKiZ11IdYGBqdqpAzeGjE2y3KOfSB9aSA6dzVJ6bt8HivB+7foaGLt56hBJ+OQ7Kywi0/O8kCT6XDzyU8zbQXO3Dw0fkWZjgBS7Xyl9nHz19MkSLbf5PuD+wrGOJCwU7DFWB1O6uUIC8kfb03lkerbVni+SjC6GUYRjM7UzFpZHL35SHyEMczcgRh42UWQa5OHHyDY6Pssztfm+0dwrfK5cyLpmjy3/u89q8busfVLqQBGJMyZKUTzQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(451199015)(55016003)(8676002)(66446008)(66476007)(76116006)(66556008)(66946007)(4326008)(54906003)(33656002)(316002)(110136005)(122000001)(71200400001)(8936002)(2906002)(41300700001)(38100700002)(52536014)(64756008)(5660300002)(6506007)(7696005)(83380400001)(186003)(26005)(9686003)(478600001)(38070700005)(86362001)(17413003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8876 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ad73168e-cf76-41cf-4b8e-08dac0a5dac9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UZIImxrf6NtthIgxvLreRPzmd3b5m/zHmusVXbKIB1/L3e6K8ZDTZCvyvZPm1oWDvufri9jXgQSLAM7uWOwMVhTFPQ2IoX0o1x9nSdccZAJgsO3WY5/ssoWbxYYPnzk4XzsZMwt4xsQzjjAsNz27l77njlFDXcZASV7LTymo/qXBFvMZIRah1SkEJJJ5XbYYZEyZ0ck959TYMYqWpNT0FosqwsH4JqiGXIdwXFx+/uhA5WGvgJifF0Nha+b3kpDnMicc3lBhtBz+zeuAVId53sqgXFnJoiGQ4H1FZuV4v4xyMfef0soQAmF+GjvsS4I+Pi+DdbAfHrCp9XpOU8x95I6Eo1hU4OrCCHoNhfdCtgIvo+AMeI+KaRHA+YGRY6Z5N67g3y0a9D/Ug5xk8NGalTk2CHiPtDkRuCxi9Z9I/vXJNe8Agnq7yRU5/VupTExfEzYPnrYuhdkSuXDZeDOfMQKK6PCIbkj9/2SDFX80Plvidxa0Q3cT3Iz1jwmf+pH/9oMjqu5l7OuNvGkVL0NWXzcgEw9+kuJq5/nHturoszagSAtok50vuwokgAZTVvD9dKyz+atHWCdnIeDrH8ZSzDPZiGXLe4cC+V6kR+spKQ86nhoRolSVBlrgGqCCpKxJGDizMXuFfvXvgP18lPCXMJuVzi6b8SeQiDE1RIJUaqYlAd36cmIU8618o8zXpwJIPF8lxkh3mDRQdoj8zRdXM1yWnZnHPnOQKToSdS0G124EZbxX0DF9xcpN9KytbCgAg4IpqBTeUCrBQymS4nUcQA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(376002)(39850400004)(451199015)(36840700001)(46966006)(55016003)(40480700001)(8936002)(478600001)(5660300002)(52536014)(2906002)(33656002)(316002)(54906003)(110136005)(70586007)(41300700001)(70206006)(4326008)(8676002)(81166007)(356005)(83380400001)(82740400003)(36860700001)(7696005)(107886003)(6506007)(86362001)(186003)(336012)(47076005)(9686003)(26005)(82310400005)(17413003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 09:53:12.0814 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 50d36046-5d8d-41d9-ecc3-08dac0a5e213 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5326 SGkgSnVsaWVuLA0KDQo+ID4gICAtIFN1cHBvcnRzIG9ubHkgYSBzaW5nbGUgU2VjdXJpdHkgc3Rh dGUgLSBTZWN1cmUuDQo+ID4gICAtIE1QVSBpbiBFTDEgJiBFTDIgaXMgY29uZmlndXJhYmxlLCBN TVUgaW4gRUwxIGlzIGNvbmZpZ3VyYWJsZS4NCj4gPg0KPiA+IFRoZXNlIHBhdGNoIHNlcmllcyBh cmUgaW1wbGVtZW50aW5nIHRoZSBBcm12OC1SNjQgTVBVIHN1cHBvcnQNCj4gPiBmb3IgWGVuLCB3 aGljaCBhcmUgYmFzZWQgb24gdGhlIGRpc2N1c3Npb24gb2YNCj4gPiAiUHJvcG9zYWwgZm9yIFBv cnRpbmcgWGVuIHRvIEFybXY4LVI2NCAtIERyYWZ0QyIgWzFdLg0KPiA+DQo+ID4gV2Ugd2lsbCBp bXBsZW1lbnQgdGhlIEFybXY4LVI2NCBhbmQgTVBVIHN1cHBvcnQgaW4gdGhyZWUgc3RhZ2VzOg0K PiA+IDEuIEJvb3QgWGVuIGl0c2VsZiB0byBpZGxlIHRocmVhZCwgZG8gbm90IGNyZWF0ZSBhbnkg Z3Vlc3RzIG9uIGl0Lg0KPiANCj4gSSByZWFkIHRoaXMgYXMgSSBjYW4gYnVpbGQgWGVuIGFuZCBz ZWUgaXQgYm9vdHMgKG5vdCBjcmVhdGluZyBkb21haW4pLg0KPiBIb3dldmVyLi4uIEhBU19NUFUg aXMgbm90IGRlZmluZWQgYW5kIEkgd2FzIGV4cGVjdGluZyBtbS5jIHRvIGJlDQo+IG1vZGlmaWVk IHRvIGNhdGVyIHRoZSBNUFUgc3VwcG9ydC4gU28gSSBhbSBhIGJpdCBlbnN1cmUgd2hhdCB0aGUg c2VyaWVzDQo+IGlzIGFjdHVhbGx5IGRvaW5nLg0KPiANCg0KVGhlc2UgMTEgcGF0Y2hlcyBhcmUg cGFydCMxIG9mIHN0YWdlIzEsIHRoZSBmdWxsIHN0YWdlIzEgaGFzIGFib3V0IDMwDQpwYXRjaGVz LiBXZSBoYXZlIHNvbWUgY29uY2VybnMgaWYgd2Ugc2VuZCBzbyBtYW55IHBhdGNoZXMgYXQgb25j ZSwgdGhlDQpyZXZpZXcgcHJlc3N1cmUgb2YgbWFpbnRhaW5lcnMgbWF5IGJlIHZlcnkgaGlnaCwg c28gd2Ugb25seSBjaG9vc2UgYWJvdXQNCjEwIHRvIHNlbmQgYXMgcGFydCBvZiBpdC4gQnV0IHRo aXMgYWxzbyBtZWFucyB0aGF0IHdlIGNhbid0IGRvIGEgcmVsYXRpdmVseQ0KY29tcGxldGUgdGhp bmcgaW4gdGhpcyBwYXJ0IzEgc2VyaWVzLg0KDQpXZSB3YW50IHRvIGhlYXIgc29tZSBzdWdnZXN0 aW9ucyBmcm9tIHlvdSB0byBtYWtlIHNvIG1hbnkgcGF0Y2hlcyBjYW4gYmUNClJldmlld2VkIGVm ZmljaWVudGx5LiBDYW4gd2Ugc2VuZCB0aGUgcGF0Y2hlcyBieSBzdGFnZXMsIGV2ZW4gdGhlIHN0 YWdlIzENCndpbGwgaGF2ZSBhYm91dCAzMCBwYXRjaGVzPw0KDQpDaGVlcnMsDQpXZWkgQ2hlbg0K DQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Mon Nov 07 09:57:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 09:57:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439189.693198 (Exim 4.92) (envelope-from ) id 1orysf-0006k7-V4; Mon, 07 Nov 2022 09:57:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439189.693198; Mon, 07 Nov 2022 09:57:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orysf-0006k0-SC; Mon, 07 Nov 2022 09:57:25 +0000 Received: by outflank-mailman (input) for mailman id 439189; Mon, 07 Nov 2022 09:57:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oryse-0006js-0I for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 09:57:24 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2046.outbound.protection.outlook.com [40.107.249.46]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 92c77158-5e82-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 10:57:22 +0100 (CET) Received: from AS9PR06CA0115.eurprd06.prod.outlook.com (2603:10a6:20b:465::24) by PAVPR08MB9858.eurprd08.prod.outlook.com (2603:10a6:102:300::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 09:57:20 +0000 Received: from AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:465:cafe::94) by AS9PR06CA0115.outlook.office365.com (2603:10a6:20b:465::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26 via Frontend Transport; Mon, 7 Nov 2022 09:57:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT015.mail.protection.outlook.com (100.127.140.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 09:57:19 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Mon, 07 Nov 2022 09:57:19 +0000 Received: from e57290c410e6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 06B309A0-DDBD-4468-BD2C-9A50D6E75DE5.1; Mon, 07 Nov 2022 09:57:13 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e57290c410e6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Nov 2022 09:57:13 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by AM9PR08MB6674.eurprd08.prod.outlook.com (2603:10a6:20b:302::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 09:57:10 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::461b:c1cb:368c:707e]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::461b:c1cb:368c:707e%5]) with mapi id 15.20.5813.011; Mon, 7 Nov 2022 09:57:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92c77158-5e82-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GtBYp7dT5I0e/mN5uhXJIaXbZ5mFAyhdvxmtb3lUzle7AQ0+/yKKMhvHFWVkDb8yY6m1xiBdv8+3jPD0w5HTu476795ElVkADRjv+CxTZCR+XIpqurftKzsoEKk8/ArCyHFYZUo7pvvYylUGAPj506J76y4IOCsP6um2X0zTvxTElHq2yY0K1B2xZKTe4/UA5FnsWKLj4reKgRiacET3CdJkN4/MZZ67xTtxrcawcxnQsdXjiePMa48hVsvoYfRzCfe4wdfRWBHjgxIOEh7aJ8RcZvUWMWSI9BmDMFmNnSTrQYd+em96Jrj+ifTO0cLGEUbbsF2u7NrCCGnD/5iPKA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L9T+EFI796AAqudQKihHLLiMjOCFouP3L7bRE4F1nHw=; b=AL0i+TXHs69fwC9dp6Qz1WkZg2O/T/3owHOL0nu+LBptP7QUHxqotncfn+DGKvQRCbaL73o9plvtMqZK4JE+Bq+F/PcdU7hDT97uv1ZOYLM2JzalPkQzHtyah/w1Or7hsR4hcznEKsF9yNyK+Ckydc5AFuzT1wM798ISJZQ58qI6VkcsviCouufULdA2JE3G+xKzCsWzDx7CXkPZ7i13dPlvd7Qdd3egblClA+rTeQoJahh8w12b3pb40ruVl5MGW+/cTloJ9QsykcEI/dVVXjgp1YNWuEf8txVHIF7mhhFBqfzvYepo4xRvDGvLPzEhpQn13iyOQ5pVehEDX6GMCw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L9T+EFI796AAqudQKihHLLiMjOCFouP3L7bRE4F1nHw=; b=3LOOp35p9Mnmuz44EKC/g6AmyM/tZSzITnv1baxG6Mz68AS3RegIN9xZupWrkdArf+jGVDPFucknPl79GrWGe90Hx7SgdSOA/kSd2AIX1QE8fVaiein1LLI+5wuDifkZ1E4J/rQbnt4EWWqGmJj0HIP9/PsmdojDWShNdFw6Zbk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DXoBfgp7TydScR1cVEAlvrNfYxY4H78OmgRleBQEk+FttR/6x1jFdpz2gQh3JX30P1pPhdF1VxEMe6ciS0BE02halEhWTPulyOUmOpdJedZkzEF3ru4kiSM1Nb5+EKaHFYoqjKmD56rTxbhP9+e866A/PqdfbgNQukxWZYW4ITKxw8io0tsvh5TKE83ghQkkwvoWv7i3hNGjGOfW/OTDMrU7ZdDNtnXXzOw3p/fWH+KuZ+GnZXZI5N3wfr59FDQHbAYNUTI5no30FimVCTs/1h4jhUwFGHVsFJyKP/TY6v8puh8+yKvlTZIhUPu73Q1nCeFHx8lYN7JnxBKmqrpSMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L9T+EFI796AAqudQKihHLLiMjOCFouP3L7bRE4F1nHw=; b=fX7u//Tdy/hABvX1SZ2CZHb/wlkzsmhIsy+fb834wS7NHcuDlrzRfIiyBCX/EZkIeAaVkOYZ4Yo/UZ+Fs0jrp40Ud171VZcP3gS1NhteYkP8js8Le4yZ+N7r73NtvvqkQvPjaQQOQaHBMvhywX9WsF4Xl63bAtd5LaeGG2cezAF6yhPyvyal8YrA1TdbLztnMcnIRyF15FjcbeddeiJEwNVto2axvJOLObEH9K9K1O4sJk0bnX+WDl85PyXisAkKBTpD8abt+nVTRarYq4QjtOiwNI5m60PG2ThNydsojwa1oZ9rWx8Ek+wgX2jRZ8ykRoQkXI5gRA2DVd8bv/iR6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L9T+EFI796AAqudQKihHLLiMjOCFouP3L7bRE4F1nHw=; b=3LOOp35p9Mnmuz44EKC/g6AmyM/tZSzITnv1baxG6Mz68AS3RegIN9xZupWrkdArf+jGVDPFucknPl79GrWGe90Hx7SgdSOA/kSd2AIX1QE8fVaiein1LLI+5wuDifkZ1E4J/rQbnt4EWWqGmJj0HIP9/PsmdojDWShNdFw6Zbk= From: Penny Zheng To: Julien Grall , Wei Chen , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 10/11] xen/arm64: introduce helpers for MPU enable/disable Thread-Topic: [PATCH v6 10/11] xen/arm64: introduce helpers for MPU enable/disable Thread-Index: AQHY8DVttaMHoZmFwkey/b3g/gof864yY/8AgADDtcA= Date: Mon, 7 Nov 2022 09:57:10 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-11-wei.chen@arm.com> <54d6e747-c791-c321-3c75-87613393d789@xen.org> In-Reply-To: <54d6e747-c791-c321-3c75-87613393d789@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 938B9A6A29EF6244BA5E2ED366979526.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|AM9PR08MB6674:EE_|AM7EUR03FT015:EE_|PAVPR08MB9858:EE_ X-MS-Office365-Filtering-Correlation-Id: f003e7ff-9ee2-4ef1-c505-08dac0a6757e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WhbNTXghp9s/rRYA822HYO1xwrlI0NzlopqSkEehUQ4CYcCJ457Fxi49pHfuO2vKuj89IOMWR6E4KBCeQA10nrrnG6MO40RPoHnwd4P6FwutdSY79vxiyOc0ynEsZzlNPX+QcjsaVSQw9MAihVI5RYrSxsEj965Nj0PWf7r9CuZXn0YvLqtPtMVxrqSwZhZC0Yjc8GcfEkAKvcGSEoyKXCWlMet+ofjWqtmr+3kP6oiLd/eHDcSIGu1vZIDvtEHlHvVxlj7aML02hERGIyOobvCQCHNs5rbk3h8uzCUYkDo8Yh0HKRivbL6DHyN8pd0DbzTStYRreSfriou5RBcP1zJiRAoHavextd9k7QXcCNp8QKZaRRZ6r3UeaHFtbK6qnmVsEbF1hv7fjYn9/13925393+oPYDak0x1hplxvxLsC9mwqpKgJnNUE1Nu9xuWOPA9RiVRzF0xMn0gxaGsbciSp3+O/yFv5C+ubvGeLMQnuMaV6f7Cr847ekLtU77KwoQmSTOrj1LSHlVDXhOGOTBNe6n3qbDnw71a2cNhzIjLQtWWHJOc2MqxerRoSgN4wJ2qRAYRpUZSDE6JVkjo3w9B1kfWCzS9lFrmKCpm6yJFJBWzkp+HTqwTTWkwhagzmo5JQWEeKbRMo1fpH0nTs3ZQLyjYNt3j+IZxncfCmHUOKgy9B8IDOdY9xddDAdEEFYlzcV4aIjuKbMuODI+lVZqm9qFSiCFt5grdUyYIdpQ08ifnpEvbybyLV38j5tkeiw9ledGDpmicmFZg3u7LLSg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(136003)(376002)(396003)(346002)(451199015)(66556008)(66946007)(66476007)(4326008)(64756008)(66446008)(8676002)(122000001)(71200400001)(110136005)(76116006)(38100700002)(316002)(38070700005)(54906003)(33656002)(86362001)(41300700001)(8936002)(5660300002)(52536014)(2906002)(478600001)(83380400001)(7696005)(55016003)(186003)(26005)(53546011)(9686003)(6506007);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6674 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0e43f5b7-1a16-40ef-a8bc-08dac0a67042 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SLSWnlBqv0xJ+GaERHh+7PoXtd9Rb0jzn58oYNN2VXvfgePJZDH8NZjr4yEzfYix/ySiwxf2CgLQTqDRvadKey2Ryyivo3Ue6dW2j7CWzlrMZRKwWCffEWx9CwmFU/fauS9ZX98TX1TF3QlYfKaFvHpph15jlIx/8KTD+n3mDqfK1S6INHyLZs/yyo4bNH1ZbctgDLRjQq6/cVpC6jp5OhkPYmdcHKSv4abQtRaUC3K0AGQjMKMwa5qAgB/AWj7VeRpG0V5SUqXWGlzbnutx5FeexKfpbd5oAo0CPz5HlRLEhsdalWULu+ZUe4rOJ5XH2x4PyaNUFZwAVhZ+nkVeHAOQttHF30quHpP7w/wf+lN5D+Cn64iWZzN0VSueoS5Lv/hkfMZj0nVjgdWmepv/99/Y1x9vOHDkUyYNZE7FDBxc/lEq1pnPWFJP7TrkpFUDWMZelnBAp+5yw77duBlDxX7oaDUYH6QOI17BSjxArkuiXQrxi/O2ih0o+hBbYer+IBnm2jKR/SSfErYhIS4kRXdtXwpoyxAFKnVBNZMDCb3KfQrDNU9vMiozloRgsnvZui8EqQa4DA7hmb3uIA/8QngyMGG+GvdtviLhcBxGtT117FjcQHsB6tZIL5J8B8tMZrKyk+Y/Ota3FZ/vSbvfc82KATfkgdwPzdJsAcpEjQmMfC/FWbXEiJrvQQSwVW8tF/ZD3oByX4S2ZrdTkKSXuDAPBhw/s/7n3J647MkYoRTa64IbkiIZdd6vjotDnjN17NJ837oYK7eSaTOxgvyZdw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199015)(46966006)(36840700001)(40470700004)(8676002)(316002)(40460700003)(4326008)(47076005)(81166007)(356005)(70206006)(70586007)(82740400003)(54906003)(33656002)(36860700001)(8936002)(478600001)(86362001)(41300700001)(5660300002)(52536014)(40480700001)(110136005)(2906002)(83380400001)(82310400005)(55016003)(107886003)(336012)(186003)(7696005)(9686003)(53546011)(6506007)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 09:57:19.3911 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f003e7ff-9ee2-4ef1-c505-08dac0a6757e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9858 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogWGVuLWRl dmVsIDx4ZW4tZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9m DQo+IEp1bGllbiBHcmFsbA0KPiBTZW50OiBNb25kYXksIE5vdmVtYmVyIDcsIDIwMjIgNDo1NiBB TQ0KPiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVu cHJvamVjdC5vcmcNCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsgUGVubnkgWmhlbmcgPFBlbm55Llpo ZW5nQGFybS5jb20+OyBTdGVmYW5vDQo+IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5v cmc+OyBCZXJ0cmFuZCBNYXJxdWlzDQo+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBWb2xv ZHlteXIgQmFiY2h1aw0KPiA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+DQo+IFN1YmplY3Q6 IFJlOiBbUEFUQ0ggdjYgMTAvMTFdIHhlbi9hcm02NDogaW50cm9kdWNlIGhlbHBlcnMgZm9yIE1Q VQ0KPiBlbmFibGUvZGlzYWJsZQ0KPiANCj4gSGkgV2VpLA0KPiANCj4gT24gMDQvMTEvMjAyMiAx MDowNywgV2VpIENoZW4gd3JvdGU6DQo+ID4gRnJvbTogUGVubnkgWmhlbmcgPHBlbm55LnpoZW5n QGFybS5jb20+DQo+ID4NCj4gPiBXZSBuZWVkIHNvbWUgaGVscGVycyBmb3IgWGVuIHRvIGVuYWJs ZS9kaXNhYmxlIE1QVSBpbiBib290LXRpbWUgYW5kDQo+ID4gcnVudGltZS4gRm9yIE1QVSBlbmFi bGUgaGVscGVyLCB3ZSBrbm93IHRoYXQgaXQncyBhbiBlc3NlbnRpYWwNCj4gPiByZXF1aXJlbWVu dCBvZiBNUFUgc3lzdGVtLiBCdXQgZm9yIE1QVSBkaXNhYmxlLCB3ZSBuZWVkIHRvIHVzZSBpdCBm b3INCj4gPiBzb21lIHNwZWNpYWwgc2l0dWF0aW9ucy4gRm9yIGV4YW1wbGUsIGluIHRoZSBwcm9n cmVzcyBvZiB0cmFuZmVycmluZw0KPiA+IGZyb20gYm9vdC10aW1lIHRvIHJ1bnRpbWUsIHdlIG5l ZWQgdG8gdXBkYXRlIHRoZSBNUFUgcHJvdGVjdGlvbg0KPiA+IHJlZ2lvbnMgY29uZmlndXJhdGlv biwgYnV0IHdlIGNhbid0IG1vZGlmeSBhbiBNUFUgcHJvdGVjdGlvbiByZWdpb24gaWYNCj4gPiB0 aGVyZSBpcyBzb21lIGRhdGEgYWNjZXNzZWQgYnkgWGVuLiBCdXQgaW4gYm9vdC10aW1lIGFsbCBv ZiBYZW4gdGV4dCwNCj4gPiBkYXRhIGFuZCBCU1MgYXJlIGluIG9uZSBNUFUgcHJvdGVjdGlvbiBy ZWdpb24sIGlmIFhlbiB3YW50IHRvIHVwZGF0ZQ0KPiA+IHRoaXMgcHJvdGVjdGlvbiByZWdpb24s IGFib3ZlIHJlc3RyaWN0aW9uIHdpbGwgYmUgdHJpZ2dlcmVkLg0KPiANCj4gVGhpcyByYWlzZXMg dGhlIGZvbGxvd2luZyBxdWVzdGlvbjogV2h5IGNhbid0IHdlIGNyZWF0ZSB0aGUgc3BsaXQgcmVn aW9ucyByaWdodA0KPiBub3c/DQo+IA0KDQpUaGUgcmVhc29uIHdoeSB3ZSBhcmUgbm90IGNyZWF0 aW5nIHRoZSBzcGxpdCByZWdpb25zIHJpZ2h0IG5vdyBpcyB0aGF0IHdlDQphcmUgdHJ5aW5nIHRv IGdvIHRoZSBzYW1lIHBhdGggTU1VIGdvZXMuIFRoZW4gd2UgY291bGQgcmV1c2UgYXMgbXVjaA0K c2FtZSBpbnRlcmZhY2VzIGFzIHdlIGNvdWxkLCBpbiBvcmRlciB0byBub3QgbGVhdmUgI2lmZGVm IENPTkZJR19IQVNfTVBVDQphbGwgb3ZlciB0aGUgcGxhY2UuDQoNCj4gSW4gcGFydGljdWxhciwg ZGlzYWJsaW5nIHRoZSBNTVUvQ2FjaGUgaXMgZmFpcmx5IHJpc2t5IGJlY2F1c2UgeW91IG5lZWQg dG8NCj4gZW5zdXJlIHRoYXQgYW55dGhpbmcgaW4gdGhlIGNhY2hlIHlvdSBjYXJlIGFib3V0IGhh dmUgYmVlbiB3cml0dGVuIGJhY2sgdG8NCj4gdGhlIFJBTSkuDQo+DQoNCkhvcGUgSSBjb3VsZCB1 bmRlcnN0YW5kIHlvdXIgY29uY2VybiB0b3RhbGx5LCB5b3UgYXJlIHdvcnJ5aW5nIGFib3V0IHN0 YWxlIGluZm8gbGVmdCBpbg0KdGhlIGNhY2hlLCBldmVuIGlmIGl0J3MgYWx3YXlzIDE6MSBtYXBw aW5nIG9uIHRoZSBNUFUgc3lzdGVtLCBtZW1vcnkgYXR0cmlidXRlcyBjb3VsZA0KYmUgZGlmZmVy ZW50IGJlZm9yZSBhbmQgYWZ0ZXI/IA0KU28gaXQgaXMgbmV2ZXIgZW5vdWdoIHRoYXQgd2Ugb25s eSBmbHVzaCB0aGUgdmFyaWFibGVzIHdoaWNoIHdlIHdpbGwgdXNlIGR1cmluZyB0aGUgZGlzYWJs aW5nDQp0aW1lLCBpdCBzaG91bGQgYmUgZXZlcnl0aGluZyBpbiB0aGUgY2FjaGUuLi46Lw0KDQpT aW5jZSBpbiBjdXJyZW50IGRlc2lnbiwgdGhlcmUgYXJlIHR3byB0aW1lIHBvaW50cyBpbiBib290 IHRpbWUgd2hlcmUgd2Ugd2lsbCBkaXNhYmxlDQpNUFUvQ2FjaGUgdG8gY29uZmlndXJlIE1QVS4N Cg0KT25lIGlzIGluIHNldHVwX21tLCBoZXJlLCB3ZSB3aWxsIG1hcCBYRU4gY29tcG9uZW50cyBi eSBjb21wb25lbnRzLCBlYWNoIE1QVSBtZW1vcnkNCnJlZ2lvbiBmb3IgYSBkaWZmZXJlbnQgY29t cG9uZW50Lg0KVGhlIG90aGVyIGlzIG5lYXIgdGhlIGVuZCBvZiBib290IHRpbWUsIHdlIHdpbGwg cmVvcmcgdGhlIHdob2xlIE1QVSBtZW1vcnkgcmVnaW9uIGxheW91dA0KYmVmb3JlIGdvaW5nIHJ1 bnRpbWUsIGFuZCB3ZSB3aWxsIGtlZXAgdW5jaGFuZ2luZyByZWdpb25zIGluIHRoZSBmcm9udCBh bmQgZmxleGlibGUgb25lcyBpbiB0aGUgcmVhci4NCk90aGVyd2lzZSBpdCBpcyBoYXJkIGFuZCBj b21wbGV4IHRvIG1haW50YWluIG9uIHJ1bnRpbWUsIGVzcGVjaWFsbHkgZHVyaW5nIGNvbnRleHQg c3dpdGNoLg0KDQpVbmNoYW5naW5nIHJlZ2lvbnMgbGlrZSB4ZW4gdGV4dCB3aWxsIG5vdCBjaGFu Z2UgZHVyaW5nIHZjcHUgY29udGV4dCBzd2l0Y2guIEZsZXhpYmxlIHJlZ2lvbnMsIGxpa2UNCmd1 ZXN0IG1lbW9yeSByZWdpb24sIHdpbGwgZGlzcGxheSBkaWZmZXJlbnQgY29udGVudHMgZHVyaW5n IHZjcHUgY29udGV4dCBzd2l0Y2guDQoNCj4gPiBTbyBpbiB0aGlzIHNpdHVhdGlvbiwgd2UgbmVl ZCB0byBkaXNhYmxlIHRoZSB3aG9sZSBNUFUgdG8gdXBkYXRlIHRoZQ0KPiA+IHByb3RlY3Rpb24g cmVnaW9ucy4NCj4gPg0KPiA+IEluIHRoZXNlIGhlbHBlciwgZW5hYmxlL2Rpc2FibGUgTVBVIHdp bGwgYWxzbyBlbmFibGUvZGlzYWJsZSB0aGUNCj4gPiBELWNhY2hlLiBUaGVyZSBhcmUgdHdvIHJl YXNvbnMgZm9yIGl0Og0KPiA+IDEuIE1ha2UgdGhlIGZ1bmN0aW9uIHNlbWFudGljIGJlIGNvbnNp c3RlbnQgd2l0aCBlbmFibGVfbW11Lg0KPiA+ICAgICBGb3IgTU1VIHN5c3RlbXMsIGVuYWJsZV9t bXUgd2lsbCB0dXJuIE1NVSBhbmQgRC1DYWNoZSBhdA0KPiA+ICAgICB0aGUgc2FtZSB0aW1lLg0K PiA+IDIuIFdoZW4gTVBVIGlzIGRpc2FibGVkLCB0aGUgTVBVIGJhY2tncm91bmQgYXR0cmlidXRl cyB3aWxsDQo+ID4gICAgIGJlIHVzZWQuIE9uIHNvbWUgcGxhdGZvcm1zLCB0aGUgYmFja2dyb3Vu ZCB3aWxsIHRyZWF0IGFsbA0KPiA+ICAgICBtZW1vcnkgYXMgZGV2aWNlIG1lbW9yeS4gVGhlIGFj Y2VzcyB0byBkZXZpY2UgbWVtb3J5IHdpbGwNCj4gPiAgICAgYnlwYXNzIHRoZSBjYWNoZSwgZXZl biBpZiB0aGUgQyBiaXQgaXMgZW5hYmxlZCBpbiBTQ1RMUi4NCj4gPiAgICAgVG8gYXZvaWQgdGhp cyBpbXBsaWNpdCBiZWhhdmlvciwgd2UgZGlzYWJsZSBjYWNoZSB3aXRoIE1QVQ0KPiA+ICAgICBl eHBsaWNpdGx5IHRvIHRlbGwgdXNlciB0aGF0IHdoZW4gTVBVIGlzIGRpc2FibGVkLCB0aGUNCj4g PiAgICAgbWVtb3J5IGFjY2VzcyBpcyB1bmNhY2hlYWJsZS4NCj4gPg0KPiA+IEluIHRoaXMgcGF0 Y2gsIHdlIGFsc28gaW50cm9kdWNlIGEgbmV1dHJhbCBuYW1lIGVuYWJsZV9tbSBmb3IgWGVuIHRv DQo+ID4gZW5hYmxlIE1NVS9NUFUuIFRoaXMgY2FuIGhlbHAgdXMgdG8ga2VlcCBvbmUgY29kZSBm bG93IGluIGhlYWQuUw0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogV2VpIENoZW4gPHdlaS5jaGVu QGFybS5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogUGVubnkgWmhlbmcgPHBlbm55LnpoZW5nQGFy bS5jb20+DQo+ID4gLS0tDQo+ID4gICB4ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZC5TICAgICB8ICA1 ICsrKy0tDQo+ID4gICB4ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZF9tbXUuUyB8ICA0ICsrLS0NCj4g PiAgIHhlbi9hcmNoL2FybS9hcm02NC9oZWFkX21wdS5TIHwgMzUNCj4gKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysNCj4gPiAgIDMgZmlsZXMgY2hhbmdlZCwgNDAgaW5zZXJ0aW9u cygrKSwgNCBkZWxldGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0v YXJtNjQvaGVhZC5TIGIveGVuL2FyY2gvYXJtL2FybTY0L2hlYWQuUw0KPiA+IGluZGV4IDZjMWE1 Zjc0YTEuLjIyOGYwMWRiNjkgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gvYXJtL2FybTY0L2hl YWQuUw0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9hcm02NC9oZWFkLlMNCj4gPiBAQCAtMjU1LDcg KzI1NSw4IEBAIHJlYWxfc3RhcnRfZWZpOg0KPiA+ICAgICAgICAgICAgKiBhbmQgcHJvdGVjdGlv biByZWdpb25zIGZvciBNUFUgc3lzdGVtcy4NCj4gPiAgICAgICAgICAgICovDQo+ID4gICAgICAg ICAgIGJsICAgIHByZXBhcmVfZWFybHlfbWFwcGluZ3MNCj4gPiAtICAgICAgICBibCAgICBlbmFi bGVfbW11DQo+ID4gKyAgICAgICAgLyogVHVybiBvbiBNTVUgb3IgTVBVICovDQo+ID4gKyAgICAg ICAgYmwgICAgZW5hYmxlX21tDQo+ID4NCj4gPiAgICAgICAgICAgLyogV2UgYXJlIHN0aWxsIGlu IHRoZSAxOjEgbWFwcGluZy4gSnVtcCB0byB0aGUgcnVudGltZSBWaXJ0dWFsDQo+IEFkZHJlc3Mu ICovDQo+ID4gICAgICAgICAgIGxkciAgIHgwLCA9cHJpbWFyeV9zd2l0Y2hlZA0KPiA+IEBAIC0z MTMsNyArMzE0LDcgQEAgR0xPQkFMKGluaXRfc2Vjb25kYXJ5KQ0KPiA+ICAgICAgICAgICBibCAg ICBjaGVja19jcHVfbW9kZQ0KPiA+ICAgICAgICAgICBibCAgICBjcHVfaW5pdA0KPiA+ICAgICAg ICAgICBibCAgICBwcmVwYXJlX2Vhcmx5X21hcHBpbmdzDQo+ID4gLSAgICAgICAgYmwgICAgZW5h YmxlX21tdQ0KPiA+ICsgICAgICAgIGJsICAgIGVuYWJsZV9tbQ0KPiA+DQo+ID4gICAgICAgICAg IC8qIFdlIGFyZSBzdGlsbCBpbiB0aGUgMToxIG1hcHBpbmcuIEp1bXAgdG8gdGhlIHJ1bnRpbWUg VmlydHVhbA0KPiBBZGRyZXNzLiAqLw0KPiA+ICAgICAgICAgICBsZHIgICB4MCwgPXNlY29uZGFy eV9zd2l0Y2hlZA0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZF9tbXUu Uw0KPiA+IGIveGVuL2FyY2gvYXJtL2FybTY0L2hlYWRfbW11LlMgaW5kZXggZmM2NDgxOWE5OC4u YjU0Mjc1NWJkMg0KPiAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZF9t bXUuUw0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9hcm02NC9oZWFkX21tdS5TDQo+ID4gQEAgLTIx Nyw3ICsyMTcsNyBAQCBFTkRQUk9DKHByZXBhcmVfZWFybHlfbWFwcGluZ3MpDQo+ID4gICAgKg0K PiA+ICAgICogQ2xvYmJlcnMgeDAgLSB4Mw0KPiA+ICAgICovDQo+ID4gLUVOVFJZKGVuYWJsZV9t bXUpDQo+ID4gK0VOVFJZKGVuYWJsZV9tbSkNCj4gPiAgICAgICAgICAgUFJJTlQoIi0gVHVybmlu ZyBvbiBwYWdpbmcgLVxyXG4iKQ0KPiA+DQo+ID4gICAgICAgICAgIC8qDQo+ID4gQEAgLTIzOSw3 ICsyMzksNyBAQCBFTlRSWShlbmFibGVfbW11KQ0KPiA+ICAgICAgICAgICBtc3IgICBTQ1RMUl9F TDIsIHgwICAgICAgICAgIC8qIG5vdyBwYWdpbmcgaXMgZW5hYmxlZCAqLw0KPiA+ICAgICAgICAg ICBpc2IgICAgICAgICAgICAgICAgICAgICAgICAgIC8qIE5vdywgZmx1c2ggdGhlIGljYWNoZSAq Lw0KPiA+ICAgICAgICAgICByZXQNCj4gPiAtRU5EUFJPQyhlbmFibGVfbW11KQ0KPiA+ICtFTkRQ Uk9DKGVuYWJsZV9tbSkNCj4gPg0KPiA+ICAgLyoNCj4gPiAgICAqIFJlbW92ZSB0aGUgMToxIG1h cCBmcm9tIHRoZSBwYWdlLXRhYmxlcy4gSXQgaXMgbm90IGVhc3kgdG8ga2VlcA0KPiA+IHRyYWNr IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZF9tcHUuUw0KPiA+IGIveGVuL2Fy Y2gvYXJtL2FybTY0L2hlYWRfbXB1LlMgaW5kZXggZjYwNjExYjU1Ni4uNWExYjAzZTI5Mw0KPiAx MDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZF9tcHUuUw0KPiA+ICsrKyBi L3hlbi9hcmNoL2FybS9hcm02NC9oZWFkX21wdS5TDQo+ID4gQEAgLTY4LDMgKzY4LDM4IEBAIEVO VFJZKHByZXBhcmVfZWFybHlfbWFwcGluZ3MpDQo+ID4NCj4gPiAgICAgICByZXQNCj4gPiAgIEVO RFBST0MocHJlcGFyZV9lYXJseV9tYXBwaW5ncykNCj4gPiArDQo+ID4gKy8qDQo+ID4gKyAqIEVu YWJsZSBFTDIgTVBVIGFuZCBkYXRhIGNhY2hlLiBCZWNhdXNlIHdlIHdpbGwgZGlzYWJsZSBjYWNo ZQ0KPiA+ICsgKiB3aXRoIE1QVSBhdCB0aGUgc2FtZSB0aW1lLCBpbiBhY2NvcmRhbmNlIHdpdGgg dGhhdCwgd2UgaGF2ZQ0KPiA+ICsgKiB0byBlbmFibGUgY2FjaGUgd2l0aCBNUFUgYXQgdGhlIHNh bWUgdGltZSBpbiB0aGlzIGZ1bmN0aW9uLg0KPiA+ICsgKiBXaGVuIE1QVSBpcyBkaXNhYmxlZCwg dGhlIE1QVSBiYWNrZ3JvdW5kIGF0dHJpYnV0ZXMgd2lsbA0KPiA+ICsgKiBiZSB1c2VkLiBPbiBz b21lIHBsYXRmb3JtLCB0aGUgYmFja2dyb3VuZCB3aWxsIHRyZWF0IGFsbA0KPiA+ICsgKiBtZW1v cnkgYXMgSU8gbWVtb3J5Lg0KPiANCj4gSSB3YXMgdW5kZXIgdGhlIGltcHJlc3Npb24gdGhhdCBh bGwgYWNjZXNzIHdvdWxkIGJlIHRyZWF0ZWQgYXMgRGV2aWNlDQo+IE1lbW9yeSB3aGVuIHRoZSBN TVUgaXMgb2ZmLiBJc24ndCBpdCB0aGUgY2FzZSBmb3IgdGhlIE1QVT8NCj4gDQoNClllcywgd2l0 aG91dCBiYWNrZ3JvdW5kIHJlZ2lvbi4gUmlnaHQgbm93LCBiYWNrZ3JvdW5kIHJlZ2lvbiBpcyBk aXNhYmxlZA0KaGVyZS4NCkJ1dCBpZiB0aGUgQmFja2dyb3VuZCByZWdpb24gaXMgZW5hYmxlZCwg dGhlbiB0aGUgTVBVIHVzZXMgdGhlIGRlZmF1bHQgbWVtb3J5DQptYXAgYXMgdGhlIEJhY2tncm91 bmQgcmVnaW9uIGZvciBnZW5lcmF0aW5nIHRoZSBtZW1vcnkgYXR0cmlidXRlcyB3aGVuIE1QVSBp cyBkaXNhYmxlZC4NCkFuZCBpdCBpcyBhbHNvIElNUExFTk1FTlRBVElPTiBERUZJTkVEfg0KDQo+ IEFsc28sIEkgdGhpbmsgdGhlIGNvcnJlY3Qgd29yZGluZyBpcyAiZGV2aWNlIG1lbW9yeSIgcmF0 aGVyIHRoYW4gIklPDQo+IG1lbW9yeSIuDQo+IA0KPiA+IFRoZSBhY2Nlc3MgdG8gSU8gbWVtb3J5 IHdpbGwgYnlwYXNzDQo+IA0KPiBEaXR0by4NCj4gDQo+ID4gKyAqIHRoZSBjYWNoZSwgZXZlbiB5 b3UgaGF2ZSBlbmFibGVkIHRoZSBDIGJpdCBpbiBTQ1RMUi4NCj4gPiArICogVG8gYXZvaWQgdGhp cyBpbXBsaWNpdCBiZWhhdmlvciwgd2UgZGlzYWJsZSBjYWNoZSB3aXRoIE1QVQ0KPiA+ICsgKiBl eHBsaWNpdGx5IHRvIHRlbGwgdXNlciB0aGF0IHdoZW4gTVBVIGlzIGRpc2FibGVkLCB0aGUgbWVt b3J5DQo+ID4gKyAqIGFjY2VzcyBpcyB1bmNhY2hlYWJsZS4NCj4gPiArICovDQo+ID4gK0VOVFJZ KGVuYWJsZV9tbSkNCj4gPiArICAgIG1ycyAgIHgwLCBTQ1RMUl9FTDINCj4gPiArICAgIG1vdiAg IHgxLCAjKFNDVExSX0F4eF9FTHhfTSB8IFNDVExSX0F4eF9FTHhfQykNCj4gPiArICAgIC8qIEVu YWJsZSBFTDIgTVBVIGFuZCBELWNhY2hlICovDQo+ID4gKyAgICBvcnIgICB4MCwgeDAsIHgxDQo+ ID4gKyAgICBkc2IgICBzeQ0KPiA+ICsgICAgbXNyICAgU0NUTFJfRUwyLCB4MA0KPiA+ICsgICAg aXNiDQo+ID4gKyAgICByZXQNCj4gPiArRU5EUFJPQyhlbmFibGVfbW0pDQo+ID4gKw0KPiA+ICsv KiBEaXNhYmxlIE1QVSBzeXN0ZW0sIGluY2x1ZGluZyBkYXRhIGNhY2hlLiAqLw0KPiA+ICtFTlRS WShkaXNhYmxlX21tKQ0KPiANCj4gSSB3b3VsZCByYXRoZXIgbm90IGludHJvZHVjZSB0aGlzIGZ1 bmN0aW9uIHVudGlsIHRoZXJlIGlzIGEgY2FsbGVyLiBUaGlzIGlzDQo+IGJlY2F1c2UsIEkgYmVs aWV2ZSwgdGhlcmUgYXJlIHNvbWUgYXNzdW1wdGlvbnMgb24gdGhlIHN0YXRlIG9mIHRoZSBjYWNo ZQ0KPiBiZWZvcmUgd2UgY2FuIHR1cm4gb2ZmIHRoZSBNTVUuIFNvIEkgd291bGQgbGlrZSB0byBz ZWUgdGhlIGNhbGxlciBpbiBvcmRlciB0bw0KPiBhc3Nlc3Mgd2hldGhlciB0aGlzIGZ1bmN0aW9u IG1ha2VzIHNlbnNlLg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQoN Cg== From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:10:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:10:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439208.693209 (Exim 4.92) (envelope-from ) id 1orz4n-00007S-1k; Mon, 07 Nov 2022 10:09:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439208.693209; Mon, 07 Nov 2022 10:09:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orz4m-00007L-V4; Mon, 07 Nov 2022 10:09:56 +0000 Received: by outflank-mailman (input) for mailman id 439208; Mon, 07 Nov 2022 10:09:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orz4l-00007F-HM for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 10:09:55 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60085.outbound.protection.outlook.com [40.107.6.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52888cc5-5e84-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 11:09:53 +0100 (CET) Received: from FR0P281CA0142.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::15) by PA4PR08MB7388.eurprd08.prod.outlook.com (2603:10a6:102:2a3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 10:09:46 +0000 Received: from VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:96:cafe::68) by FR0P281CA0142.outlook.office365.com (2603:10a6:d10:96::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11 via Frontend Transport; Mon, 7 Nov 2022 10:09:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT052.mail.protection.outlook.com (100.127.144.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 10:09:45 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Mon, 07 Nov 2022 10:09:45 +0000 Received: from 944b92fe2d98.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 994304F8-EF50-4BD8-86BD-46582A5873F3.1; Mon, 07 Nov 2022 10:09:39 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 944b92fe2d98.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Nov 2022 10:09:39 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM0PR08MB5444.eurprd08.prod.outlook.com (2603:10a6:208:185::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 10:09:36 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5813.011; Mon, 7 Nov 2022 10:09:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52888cc5-5e84-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nbZI5eNcl05vRuGz6hmB8OuJ+P6pAbKi1bWnpMQn5IrJqapTQkDDsAHdCvvbE8UedydOsIIpKfqv6CbmKOpKLFPT28xZ4ltPY74AS9soIwQF7LdNLx6ajHzvRK5Y9F/TFHwRpT38C8HFHqh2eOCmGbwmViiSW57DOO61BDF0bPyHk87oczDU8eQ86ZEL3R4vOhUsNDkcI9resdCTCB1msvigf5I9H18pVwLBN2a9jXhyAZx1pJap/07DiDaBWRR4bDEldA8yylFgXqgagjHKrxwOrNWmEFr5+GDL3fl2sdkVHmidvVoWLB9qEjbZdQKZy9RtFdkaH+shrJfXHn9mtw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g2D1WVBIkXQWLQXPSwj6jwCDPYZEn9bTpcIizuYfUcw=; b=kbXjVRsiUwI1Sbs1tQFuhcrWSaJ5nL4fJh6fTVzMNya8QyBsXsygs9J8RrQbnVyF+xM221zwmmzNJq815Rki7wGAthadzsKY/sKEaP/UCAEz9lCbwfeixMOCVbTpXnVhMQ9wforpGJk9y0iA5TOLnaEz57ti2CkEa+3HnyFfJ6gBEIH8ma1v91u8z7H6qDFlnH7MwoiqUeecd5vc1t+M+/jT+MO0IdauCiSC257+sj9t6gHHnIiq4PJrlF0tRZFUJB4bizNe4R3JZJ1WkWpT6GTPyofwe+ObMg0vMSlG9rS0iXQ5+BBxt+R5RBBSwrehA9YZFFVzUEMwuEM6GyGujQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g2D1WVBIkXQWLQXPSwj6jwCDPYZEn9bTpcIizuYfUcw=; b=YkIkELxw7xKk9dU+ElmbJN0Pg8P9U6xNjs6uxPAfVp0AP7gouAa/e1kZrTg+ydUa/iopQZw6lAlxHQrt25DVT/shUPzkI8m4r95tn4Fd7b1dDXVP/sl+EoLy8rRIXUZzKVlrPd5yO4XlCZHyqoMeh0VdncPAtVQjfaHblX0Tltg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B6VCzhO9owUydYJKeuLfFZxCMrnDRjJbaULqgpBPguA6nTzOUSpwYz4gptAlUetHOBzglOyAaEfRpEsaMa25jHlU6MMkNiE7gbS9N0wXJUFXOxly81zVIHFVa06rHJ3WFfe3WdJpHVTGqcU+ljbW7bwJxW/TLavTUxtaFzhmXIbSif/IJ+CV35n9T2A1CGc5aLQw0NLSdbmFdetC9T32aS9+jzalAXR0sPc88Mi7jMSvy9gNRkAvrB63lvEDnVqLTZ37eqth0+5cS9pNo0jVXBTOuK6DGN/Rma4QIp6E3cSKere7snBsCb3YmeUadk15azEPIlC+GO8erP4sldhx8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g2D1WVBIkXQWLQXPSwj6jwCDPYZEn9bTpcIizuYfUcw=; b=hFvAAiT9hUpejXNIongaU/NO+vi9ENIDGeynGyeRvleQPEu+48agjVTy7xD4Jewb9e8tLM8OQqhGH3RXc6A1Cb9oOKbRgEH3AJ8fh7vjn5mfvNe3nzHe61KENBnMW8x2UGAMLDsqLhyvbkFnRfXO80QMl8x/1H+hEAe5+3KHw9df2g2ncASiZVkuLEteFpzQRkcdSyHgFTsnudI2J2uP5bXiFbStuxyA4Se8A5wUxrVwHZBr5zTmGCM91bjlk2MjoD7vvGuUrUaY5ZMwKtyaUFmWNesVzlHk9ayzt+rvfYe3tG5sOUZHzYZyhFEFyBTYswP3PnjwoVyl1i8ahBWSPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g2D1WVBIkXQWLQXPSwj6jwCDPYZEn9bTpcIizuYfUcw=; b=YkIkELxw7xKk9dU+ElmbJN0Pg8P9U6xNjs6uxPAfVp0AP7gouAa/e1kZrTg+ydUa/iopQZw6lAlxHQrt25DVT/shUPzkI8m4r95tn4Fd7b1dDXVP/sl+EoLy8rRIXUZzKVlrPd5yO4XlCZHyqoMeh0VdncPAtVQjfaHblX0Tltg= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v7 2/6] xen/x86: move generically usable NUMA code from x86 to common Thread-Topic: [PATCH v7 2/6] xen/x86: move generically usable NUMA code from x86 to common Thread-Index: AQHY5EtNNbUvPHFuhkmLf666GxDtVa4tV7mAgAX/kBA= Date: Mon, 7 Nov 2022 10:09:36 +0000 Message-ID: References: <20221020061445.288839-1-wei.chen@arm.com> <20221020061445.288839-3-wei.chen@arm.com> <78036eeb-2585-97e5-9f80-bb84f297cc08@suse.com> In-Reply-To: <78036eeb-2585-97e5-9f80-bb84f297cc08@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A43C7E7D16765542A32553B3C0B6ED9E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|AM0PR08MB5444:EE_|VI1EUR03FT052:EE_|PA4PR08MB7388:EE_ X-MS-Office365-Filtering-Correlation-Id: 19d63ad8-56f1-4cbb-13ac-08dac0a83268 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4FXS6HlAEuT4Lxqpy8vxBXz6G88cxFZIFeHLm2oWKOUMV8qu80N00Cj2Wxe7mEmJfnmhF39HPs8Sv3QM21S93ip3CB809yHu73AWu375eWgKLXKT4iPgP3b9UzaOn7MLO3tg/qHlmjJ5BMt4PVJtVMGJU2ryG9EkzsLQwi9zn6x5UZYxXnrtkVt57lGkCubgjlPF9s/Ep0W/RTXISl2PhHs10dDdB+BoTx21YUYhlHdq4ud9H5kc9TMVjSSC+R6zLZTgQyDNaYSB1fYo/XRBpI9qwlzT8YKDUpFFMTYgDWC+i0B8VPOKlSF9WfdNSuL9sumo64TUOgGdwpZV9oQZWoCJywahbdyQt5zyTmkGoacJxrWkD78fHmuDARUUMl+P5XBUKojArt2IjQZhvPUsU8em/biW7lm6fY7IbYwk1TFw1p0HxlPr5Z/qC+eM0G987p1e8Vwncpcu83lr1q/z08YJFUzrcW66PuGeICVOOifm0/KhXQb+QuX97Rse48yuJATWZUAio3GckP2IFSWOxgIkTBBminIKgnBHCWOEHgCd5D4/QCTjYvlxFc0ImOz473khQ7PMsSD5/8BV+RxLnBVldr8i4pJ7omF7Zs8ordocVPgH2+E7SvgYoDL4qr2JyOufu+loTcHXxBY9CEzZl2Tb9SRJy3A3E6ETUG+9xPizxQbZpbt0IGBDC178EjtLDVu4oRb+KTSzu2gDX/rifqI+Ur8fHR44BLl/IG46dF65J/f1/1xbo5uftckNg1TEf7KZjp+7ZTZbd13qSKkJ3RJ9avYLTe8YPc1/gpxTxvE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(39860400002)(396003)(376002)(136003)(451199015)(38070700005)(478600001)(71200400001)(38100700002)(122000001)(86362001)(55016003)(5660300002)(53546011)(316002)(52536014)(41300700001)(7696005)(6506007)(186003)(6916009)(54906003)(8936002)(66476007)(9686003)(83380400001)(64756008)(76116006)(66946007)(66556008)(33656002)(8676002)(4326008)(26005)(66446008)(2906002)(21314003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5444 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d62d1267-26e1-4104-f8c9-08dac0a82cab X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OHOwrgZsmTJC1RZhCI1KSQNmaY4BFPrB7cPj5nv0BYmMeK+GX8lMNyu/VqK015Ak37CaVIEnqeBuX1MRIDVGa5Za6w12dVTicLkF0V+BJmrOMmBAVPv8nknsdmf0Pk2QhIg1O/fUO2E92F6kk+HQGwvzNxEsceqS9Qnh6edV8jh8vf3xEIEssgpBY9FzSQCb2RG6+nC2YtTPJfwNNUbFS8TtYZbfBanxjzaqosKesNUS2BqR1NkOwnrMGMthcUR7Btjdihr8uJb/cChd/urojeYQdf13xygu4k4UcbGwGJYMpGG4XzsVzbRJsGUopqTjKLeAxsIRT7j23gp8xOY8iwWrHgel56fFJM/naYAKVK71s3kUWlduzoRV886m2qUEo4hnqf/C8IrsQunEcXV8v+V2Gqxula8Rkm15kdlrcp4zUqC0COgTiMEzqbhjBRdqpqXEhYZmry4R4sY2SQ1xbOnWbe0qR37R1vlXh7gVNoexWGSlU3WhBVTBfq9ylyVbBtblKVXINa/BVpXVloMKPBMWPn2xnO0KIJAMrCmZ6WArT44txaOSNpW7yUEAlSQKwmuuJrXPTiQVQ4aHtWMuolGiIjgZnIdw4XHqzYto74WYQXfcwptueq8pYnmgfwKhXT4474i6r/rMoiOhV1qQVSrZo6TvDlJ2ele5foJ5XwpPjXsjqhY5oeCbSpG6WDJSxtlWiuu0VOaopwKQmB2grgs/kwxh81+R21ZcODiIPjPXa3PdoLghMKfoHngNjyBGVCfzs/VuZPzRYIx2uJqxBC4PXeDDV7tBYgJXQE6r/To= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199015)(46966006)(36840700001)(40470700004)(55016003)(70206006)(70586007)(4326008)(8676002)(40480700001)(316002)(36860700001)(33656002)(5660300002)(336012)(54906003)(2906002)(8936002)(6862004)(82740400003)(41300700001)(6506007)(7696005)(52536014)(186003)(40460700003)(53546011)(26005)(47076005)(9686003)(83380400001)(478600001)(86362001)(356005)(81166007)(82310400005)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 10:09:45.7660 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 19d63ad8-56f1-4cbb-13ac-08dac0a83268 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7388 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDEx5pyIM+aXpSAyMjoyNg0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBHZW9y Z2UgRHVubGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu b3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggdjcgMi82XSB4ZW4veDg2OiBtb3ZlIGdlbmVyaWNhbGx5IHVzYWJsZSBOVU1BIGNvZGUNCj4g ZnJvbSB4ODYgdG8gY29tbW9uDQo+IA0KPiBPbiAyMC4xMC4yMDIyIDA4OjE0LCBXZWkgQ2hlbiB3 cm90ZToNCj4gPiBUaGVyZSBhcmUgc29tZSBjb2RlcyBpbiB4ODYvbnVtYS5jIGNhbiBiZSBzaGFy ZWQgYnkgY29tbW9uDQo+ID4gYXJjaGl0ZWN0dXJlcyB0byBpbXBsZW1lbW50IE5VTUEgc3VwcG9y dC4gSnVzdCBsaWtlIHNvbWUNCj4gPiB2YXJpYWJsZXMgYW5kIGZ1bmN0aW9ucyB0byBjaGVjayBh bmQgc3RvcmUgTlVNQSBtZW1vcnkgbWFwLg0KPiA+IEFuZCBzb21lIHZhcmlhYmxlcyBhbmQgZnVu Y3Rpb25zIHRvIGRvIE5VTUEgaW5pdGlhbGl6YXRpb24uDQo+ID4NCj4gPiBJbiB0aGlzIHBhdGNo LCB3ZSBtb3ZlIHRoZW0gdG8gY29tbW9uL251bWEuYyBhbmQgeGVuL251bWEuaA0KPiA+IGFuZCB1 c2UgdGhlIENPTkZJR19OVU1BIHRvIGdhdGUgdGhlbSBmb3Igbm9uLU5VTUEgc3VwcG9ydGVkDQo+ ID4gYXJjaGl0ZWN0dXJlcy4gQXMgdGhlIHRhcmdldCBoZWFkZXIgZmlsZSBpcyBYZW4tc3R5bGUs IHNvDQo+ID4gd2UgdHJpbSBzb21lIHNwYWNlcyBhbmQgcmVwbGFjZSB0YWJzIGZvciB0aGUgY29k ZXMgdGhhdCBoYXMNCj4gPiBiZWVuIG1vdmVkIHRvIHhlbi9udW1hLmggYXQgdGhlIHNhbWUgdGlt ZS4NCj4gPg0KPiA+IEFzIGFjcGlfc2Nhbl9ub2RlcyBoYXMgYmVlbiB1c2VkIGluIGEgY29tbW9u IGZ1bmN0aW9uLCBpdA0KPiA+IGRvZXNuJ3QgbWFrZSBzZW5zZSB0byB1c2UgYWNwaV94eHggaW4g Y29tbW9uIGNvZGUsIHNvIHdlDQo+ID4gcmVuYW1lIGl0IHRvIG51bWFfcHJvY2Vzc19ub2RlcyBp biB0aGlzIHBhdGNoIHRvby4gQWZ0ZXIgdGhhdA0KPiA+IGlmIHdlIHN0aWxsIHVzZSBDT05GSUdf QUNQSV9OVU1BIGluIHRvIGdhdGUgbnVtYV9wcm9jZXNzX25vZGVzDQo+ID4gaW4gbnVtYV9pbml0 bWVtX2luaXQsIHRoYXQgZG9lc24ndCBtYWtlIHNlbnNlLiBBcyBDT05GSUdfTlVNQQ0KPiA+IHdp bGwgYmUgc2VsZWN0ZWQgYnkgQ09ORklHX0FDUElfTlVNQSBmb3IgeDg2LiBTbywgd2UgcmVwbGFj ZQ0KPiA+IENPTkZJR19BQ1BJX05VTUEgYnkgQ09ORklHX05VTUEgdG8gZ2F0ZSBudW1hX3Byb2Nl c3Nfbm9kZXMuDQo+ID4NCj4gPiBBcyBhcmNoX251bWFfZGlzYWJsZWQgaGFzIGJlZW4gaW1wbGVt ZW1udGVkIGZvciBBQ1BJIE5VTUEsDQo+ID4gd2UgY2FuIHJlbmFtZSBzcmF0X2Rpc2FibGVkIHRv IG51bWFfZGlzYWJsZWQgYW5kIG1vdmUgaXQNCj4gPiB0byBjb21tb24gY29kZSBhcyB3ZWxsLg0K PiA+DQo+ID4gVGhlIG1hY3JvIG5vZGVfdG9fZmlyc3RfY3B1KG5vZGUpIGhhc24ndCBiZWVuIHVz ZWQgYW55d2hlcmUsDQo+ID4gc28gd2UgZHJvcCBpdCBpbiB0aGlzIHBhdGNoIHRvby4NCj4gPg0K PiA+IEJlY2F1c2Ugc29tZSBhcmNoaXRlY3R1cmVzIGFsbG93IHRvIHVzZSBhbGwgNjQgcGh5c2lj YWwgYWRkcmVzcw0KPiA+IGJpdHMsIGJ1dCBzb21lIGFyY2hpdGVjdHVyZXMgYXJlIG5vdCAobGlr ZSBBcm02NCBhbGxvd3MgNTIsIDQ4DQo+ID4gYml0cykuIEluIHRoaXMgY2FzZSwgd2UgdXNlIG1p bihQQUREUl9CSVRTLCBCSVRTX1BFUl9MT05HIC0gMSkNCj4gPiB0byBjYWxjdWxhdGUgdGhlIHNo aWZ0IHdoZW4gb25seSBvbmUgbm9kZSBpcyBpbiB0aGUgc3lzdGVtIGluDQo+ID4gdGhpcyBwYXRj aCB0b28uDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBXZWkgQ2hlbiA8d2VpLmNoZW5AYXJtLmNv bT4NCj4gDQo+IFJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+ IHdpdGggb25lIHNtYWxsIGZ1cnRoZXIgcmVxdWVzdCAoY291bGQgYmUgdGFrZW4gY2FyZSBvZiBh bHNvIHdoaWxlDQo+IGNvbW1pdHRpbmcgaWYgbm8gb3RoZXIgbmVlZCBmb3IgYSB2OCBhcmlzZXMp Og0KPiANCg0KVGhhbmtzLiBUaGlzIHNlcmllcyBpcyBpbiBtZXJnZSBjb25mbGljdCBzdGF0dXMg bm93LCBkbyBJIG5lZWQgdG8NCnNlbmQgYSB2OCB0byBmaXggdGhlIG1lcmdlIGNvbmZsaWN0PyBJ ZiB5ZXMsIEkgd2lsbCBmaXggYWJvdmUgYXMNCndlbGwsIGFmdGVyIFBBVENIIzUgYmUgcmV2aWV3 ZWQuDQoNCj4gPiAtLS0gL2Rldi9udWxsDQo+ID4gKysrIGIveGVuL2NvbW1vbi9udW1hLmMNCj4g PiBAQCAtMCwwICsxLDQ2NCBAQA0KPiA+ICsvKg0KPiA+ICsgKiBHZW5lcmljIFZNIGluaXRpYWxp emF0aW9uIGZvciBOVU1BIHNldHVwcy4NCj4gPiArICogQ29weXJpZ2h0IDIwMDIsMjAwMyBBbmRp IEtsZWVuLCBTdVNFIExhYnMuDQo+ID4gKyAqIEFkYXB0ZWQgZm9yIFhlbjogUnlhbiBIYXJwZXIg PHJ5YW5oQHVzLmlibS5jb20+DQo+ID4gKyAqLw0KPiA+ICsNCj4gPiArI2luY2x1ZGUgPHhlbi9p bml0Lmg+DQo+ID4gKyNpbmNsdWRlIDx4ZW4va2V5aGFuZGxlci5oPg0KPiA+ICsjaW5jbHVkZSA8 eGVuL21tLmg+DQo+ID4gKyNpbmNsdWRlIDx4ZW4vbm9kZW1hc2suaD4NCj4gPiArI2luY2x1ZGUg PHhlbi9udW1hLmg+DQo+ID4gKyNpbmNsdWRlIDx4ZW4vcGFyYW0uaD4NCj4gPiArI2luY2x1ZGUg PHhlbi9zY2hlZC5oPg0KPiA+ICsjaW5jbHVkZSA8eGVuL3NvZnRpcnEuaD4NCj4gPiArDQo+ID4g K3N0cnVjdCBub2RlX2RhdGEgX19yb19hZnRlcl9pbml0IG5vZGVfZGF0YVtNQVhfTlVNTk9ERVNd Ow0KPiA+ICsNCj4gPiArLyogTWFwcGluZyBmcm9tIHBkeCB0byBub2RlIGlkICovDQo+ID4gK3Vu c2lnbmVkIGludCBfX3JvX2FmdGVyX2luaXQgbWVtbm9kZV9zaGlmdDsNCj4gPiArdW5zaWduZWQg bG9uZyBfX3JvX2FmdGVyX2luaXQgbWVtbm9kZW1hcHNpemU7DQo+ID4gK25vZGVpZF90ICpfX3Jv X2FmdGVyX2luaXQgbWVtbm9kZW1hcDsNCj4gPiArc3RhdGljIHR5cGVvZigqbWVtbm9kZW1hcCkg X19yb19hZnRlcl9pbml0IF9tZW1ub2RlbWFwWzY0XTsNCj4gPiArDQo+ID4gK25vZGVpZF90IF9f cmVhZF9tb3N0bHkgY3B1X3RvX25vZGVbTlJfQ1BVU10gPSB7DQo+ID4gKyAgICBbMCAuLi4gTlJf Q1BVUy0xXSA9IE5VTUFfTk9fTk9ERQ0KPiA+ICt9Ow0KPiA+ICsNCj4gPiArY3B1bWFza190IF9f cmVhZF9tb3N0bHkgbm9kZV90b19jcHVtYXNrW01BWF9OVU1OT0RFU107DQo+ID4gKw0KPiA+ICtu b2RlbWFza190IF9fcmVhZF9tb3N0bHkgbm9kZV9vbmxpbmVfbWFwID0geyB7IFswXSA9IDFVTCB9 IH07DQo+ID4gKw0KPiA+ICtib29sIF9fcm9fYWZ0ZXJfaW5pdCBudW1hX29mZjsNCj4gPiArDQo+ ID4gK2Jvb2wgbnVtYV9kaXNhYmxlZCh2b2lkKQ0KPiA+ICt7DQo+ID4gKyAgICByZXR1cm4gbnVt YV9vZmYgfHwgYXJjaF9udW1hX2Rpc2FibGVkKCk7DQo+ID4gK30NCj4gPiArDQo+ID4gKy8qDQo+ ID4gKyAqIEdpdmVuIGEgc2hpZnQgdmFsdWUsIHRyeSB0byBwb3B1bGF0ZSBtZW1ub2RlbWFwW10N Cj4gPiArICogUmV0dXJucyA6DQo+ID4gKyAqIDEgaWYgT0sNCj4gPiArICogMCBpZiBtZW1ub2Rt YXBbXSB0b28gc21hbGwgKG9mIHNoaWZ0IHRvbyBzbWFsbCkNCj4gDQo+IE1heSBJIGFzayB0aGF0 IHlvdSBjb3JyZWN0IHRoaXMgY29tbWVudCBsaW5lOiAib2YiIChhbG9uZSkgbWFrZXMgbm8gc2Vu c2UNCj4gaGVyZS4gRWl0aGVyICJvciIgd2FzIG1lYW50IG9yIGl0IHdvdWxkIHdhbnQgdG8gYmUg ImJlY2F1c2Ugb2YiLiBVbmxlc3MNCj4gdGhpcyBpcyBhIGxhbmd1YWdlIHR3ZWFrIEknbSBlbnRp cmVseSB1bmF3YXJlIG9mIC4uLg0KDQpZZXMsIGlmIHdlIG5lZWQgYSB2OCwgSSB3aWxsIGNvcnJl Y3QgaXQuDQoNCkNoZWVycywNCldlaSBDaGVuDQoNCj4gDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:14:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:14:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439215.693220 (Exim 4.92) (envelope-from ) id 1orz9A-0001cK-N8; Mon, 07 Nov 2022 10:14:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439215.693220; Mon, 07 Nov 2022 10:14:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orz9A-0001cD-KL; Mon, 07 Nov 2022 10:14:28 +0000 Received: by outflank-mailman (input) for mailman id 439215; Mon, 07 Nov 2022 10:14:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orz99-0001c3-GB for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 10:14:27 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2066.outbound.protection.outlook.com [40.107.105.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f4eb5275-5e84-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 11:14:26 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8905.eurprd04.prod.outlook.com (2603:10a6:20b:408::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Mon, 7 Nov 2022 10:14:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 10:14:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4eb5275-5e84-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IQHn86ryhl4Hw+Dx0/3CJEs6MNKozWFvyerb3Z+lbOzcGZtegElW47/X7QFwxy4xSPGqVcMPkFiBlJgbJaxpi6l5a44RpATV9B8tjaq7iO49d4MQ0J2dJ7so1ircaViv+X4+raEqZMbxVwaDsY2yF2rO4Yc00SgxPkUupZm6KGBpWav0jWR1RZAy5FErrxZbWBUNU+aQxCEWKcLQ6MXJq+fBS6sVFe/3fPm1fom5nlJUU4wj9vj3uutsiFi3Q7WFOhFFs1Xw8PfXNL4Ptjsbcqjghc0uyZdSa0ygZrmbPm+fOKarsYpjBYUZ5v1wTc8jA/L0viTb/uQzy5ghpzLWBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QSzASySL2a91ziBxdlEU5QHsVQQ0z3LYXMU8idMlzaI=; b=mahJm0EJOtZEcR22/SFWvOqPN2jezn7qYBpqIr1uktvgkGGbVFpPIy7s1JSeGzJ2NtnFS/XvuUGWn0RkUOU6Dw8iq/3cCvBrL+MvSLqHCzmSaKyfpmSHQld4ApytF/9XB461cJ28XBXL7/PIT6O1PqB5LgToUK50D2zCvMq9fzGfr+5JzSKkGHyZd1rh9CpTv02STSqumtGSpoIKIj2Fi+HAzKULSOO7AJ9WQ4mejjCrBMvk7oxTyGPgq4JUU0TpIwvGlFZ7th7nQGHrUO10piV9388QHxtpYtps6v+xRFDJxHFUs7G7K624DdAIbJJISeGwYLeDwFtfTzJr5n9bZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QSzASySL2a91ziBxdlEU5QHsVQQ0z3LYXMU8idMlzaI=; b=luyYiTHgPkH2s8n31Z6xb2AGF1cdSgJMB6Vn36q9sNs4nvxkqG8i8bBfuZ3Y6p/zRI5YbgG+SpJ2klpSfv5CLCitNYdbFsETC6GmGC3Pb6j3/X4G7O+aytg/Bst7ijFkvgYWa6H+COH78pADSpIjxFXj4MoLOzVlAMOzaXG3/LtkwGFtvtDFCilYngCTPU7xvgM81LE6on/AmecQQkzd8S7F0KdgYgEsuo0beE9kosCE0EMaGk6TAqgEbIqNN7AwynaS/0hNx+cGG21WVrBRTJ+6dz1v1KOzfY1vvdf0G7XelcKujwpFM7dDuqwqV4uzVUnPkjP6yMY5bICPpPPHzQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <14e5a51b-2c22-7bef-fb9a-e10f7f71f25d@suse.com> Date: Mon, 7 Nov 2022 11:14:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v7 2/6] xen/x86: move generically usable NUMA code from x86 to common Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <20221020061445.288839-1-wei.chen@arm.com> <20221020061445.288839-3-wei.chen@arm.com> <78036eeb-2585-97e5-9f80-bb84f297cc08@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8905:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b5226d5-01d1-4946-8512-08dac0a8d82d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gl8gzdAoKtQC/3xCLrQAwW6rnHj2vh6AIeBdci1yo1e9iBGcT1MFaQ1uXAIIlSAWR3JfBt4SW0mPNS83XZDoa5vC2ySvl7e3Y9O4P0k36faMWdlJxe/1LMSYo49toe/3szwfDJW3SgLLV8hUk01+/4rlttgU+Wlb8iMFLzngF/JAAlJXsJoy6Y78R7Tk076EDq/7Drw+Gt9iHajCJ1/yU/emIY3XVqQAlvqFMXmFDawBUbkf9A0qYn9TIzgpLaIx227tfwPcLEcODW8PU/fIjAZdoZbwTWnejp+M3PDn8dLetRV2HW+NUlSZuTRJx+YhmIoY6oSnhAkiml4KzreEDtQw9uoS8GYpYCGad30q4IFp0cXW4uscljv9yTDcuBLYG0JR6LHrn7Smvhs03ULWRkuUJkbXKw9TDLg0he1pvU35UVK5eO5HFNoINNnLkbrbJDQxDy/BjCvNr9p9VYNH1wtw6MORw5ctjKuJei6bhLBysMNtVXONfJZI+9s7W2FeT1Zkb36Yl1SuMrcBi07wga6U2SJvZqsbnHVTCeBoUV6zURpMZnP2Fx8i7qY4DlHMh89p68/MZZEmQQzk7p3HNvKxvyO+2VxvSq+DGYNyAjP5qeLCMUIqhWRPtsWakANAZoNdK49lSFAuY4JA/Vwakx6I4uyjWFY03UnvYvHHdQ+uEDa/NQymni0AXmjoKNzaarUqJOPWhl2M+AfOAQhCsY0ppzYwR1SCyVLJ0zMXs/yWOc11ONls/duMFpm6P/Ta+qH8C+ZjL4C2eqbJZh957PnNQdIekD5S6IL+G21hZAFvoDJHzH+XGEhDgEkVLow8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(396003)(39860400002)(136003)(346002)(451199015)(36756003)(54906003)(8936002)(6486002)(5660300002)(83380400001)(2906002)(478600001)(66946007)(41300700001)(66556008)(4326008)(66476007)(8676002)(316002)(26005)(53546011)(6512007)(2616005)(186003)(6916009)(31686004)(38100700002)(86362001)(31696002)(6506007)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTFXVll0RDJodmV0KzFBTUJ2ZmJuWUJHRnZoaHlqZlkzSmx4cStWY3A2b3J4?= =?utf-8?B?b1FLSGJLcTRLV21jaGdVK3hGeW5zR0VSeGNxMUtNalVBdXJGNWx5OGJyMnhu?= =?utf-8?B?b1RaMjZnMFNGanhoMHZibzFBL1EyYys0K1h5cS92U3d3VkRUUFFwMXZ2Y3Ew?= =?utf-8?B?RFJ2dC9iRzlsNjFyZ3F6WGREdENuYjF0OFVlUTZKRTg4UjMzMWlhVFpQTENz?= =?utf-8?B?b2F5MGRWK2UzZFY1QkpZUmQ4Skh0NmcvV3o5Q0p2dDlrUnB4cndzSWlHazFJ?= =?utf-8?B?d2hkOEFkTGZOYndQcHcveHllbWEyaU0rK3V0K25qQlIvK1NDWXFlMHBqYUky?= =?utf-8?B?UXIzeGlnKzdTajhwRDV6NmRNOE1rUDlpai9leC9BVXNRbXhQd3pXVjdCaUJw?= =?utf-8?B?K1lNelZvRWNQVkc5VWJEMWh5d2w4eVhCUHJZd0dBRjJJTURTcktER2NjZGg4?= =?utf-8?B?QmFPK3hHd01tRWYvam81cWFGMC81NFM2Y1Q0ZGk0NDJCTllZcTZEZ3ozanJR?= =?utf-8?B?M1lKSG52ZzlvZSt5SUprY0pwckJmV2RGVFc4MmxaWG5KRzFLL2QrUWJrTVh5?= =?utf-8?B?VHJkc1NTNTkxbGNMSnZnZEdFa3BjdTNSRjJOcHMxcVc3YVg4ZnpQOThPL25W?= =?utf-8?B?M3pNVTRkVUJia2MzaWNaSVB2bHUrWlJPaW5Ud25yVTZtaHpwMHBZLzcyN0JR?= =?utf-8?B?MVdyaCtUa09TNXlHTU5hYkt3Y01zQkZBVFBDaHR5L2NYWDhtMVorQXNjdUZy?= =?utf-8?B?M2RFblUzWDY0RGhEVkZxMUloVkxDZy9xQ1gyTlZiMTJuUjkwVkxPV2oyUk1Z?= =?utf-8?B?WnBWYVFTRWZyQUtHN3J1MnM0ZWpRRFlxQURjeVdwN3g0elMxVmFZc1pxVjMw?= =?utf-8?B?SjFMK0VGbElWZ3A0bVBDR1Z5RmlBM0pUZjM2d2xVdG9vQmpwWEFna3FEazJQ?= =?utf-8?B?SE1KV2ZTU0ZXZ3RpeWRIL1c1R2NPdVdZTzNsVkNkN2dSa1MwczFvbmdXc1Ix?= =?utf-8?B?dDNHdE5TaDBUYnRmSTRJNHpWWVhwaHBzTTU0SHc0NG1nUnRZZ08xNHVHVjhL?= =?utf-8?B?clNYOFpVMit3U2crOGlJNTdhS0gzOVY3bW1aNkR4dXlKN3Q0MU9CK1ZyRmx5?= =?utf-8?B?b254MjA0Q0hRSlRpVkloT3Jna2hmT01rVmlIRndNWENuWHpKMElWZ25hWm9H?= =?utf-8?B?KzBPVWpnNnpLS3k0SUlYS0FjVENDUFVjOVVXWWxMY1pmaCtva25GYXZrcUE2?= =?utf-8?B?Um9lQS9WSk1yakd1cGJYRG5EQy96S0JCcUhrRFNodm94MjRrTTE2RnNyN3pL?= =?utf-8?B?SGFzU2RIdk5UR05vaXhXMEYvYitEbHp6VXhUOVRlYlVuR0hISXl1MnAwVzUv?= =?utf-8?B?QUdoSHFORjU0MWhzcnhxM0FZU0xCcjYvdmpody9ibkF3akh4cTh0UnQwTi91?= =?utf-8?B?K21meDB6TGNHTGp6akk4aGk2WHdTeGV2SW1QVThnc245T0xsbnh4OFdta0h0?= =?utf-8?B?bGp1bDdpZzRUUCswSkZJYnhwcW5zSEN4ZERBMzdYSE1WOG9oKzBlNXEvSmcx?= =?utf-8?B?UjhQVFNRUFloUDM3elBEWWx5R1BOYmNwb2U4bjZWRUp2akFSQXBCNWNRVlhp?= =?utf-8?B?MzNhU2NJcjk5U3hCL1RybzE3T1VYa2Y0OVpwYjFBWlpocUIzTjJjYlRmOUUv?= =?utf-8?B?N3o5UFdYNU5sd3pVNjBTY2c4K2FxUkQydDZvTmxpTkZZaGdaczlUSmlXUTM5?= =?utf-8?B?M1l6WWE3QkR3VnJ4MUk5RFFVakhpSGZ1NDBFbDRtWnR1a0QwdW5SNm9BS0pt?= =?utf-8?B?MkxLeFVXdFNTNEZKZVZ6U3o2L0ZRcW5YZkxNZ3VyaS9tZlZqMDhGblIxVXVH?= =?utf-8?B?UlNvNTIxTlVSUXdwdmdvOHlKT1ltcmRTRnVDMzIvZVQwZEpDelAvZFUvTk0z?= =?utf-8?B?NEl4S2RPUVc5czY1VWtOZEVjVEQ3NC8zMmtSOVVreXhqaUVyU203UWJjRFFx?= =?utf-8?B?ZWpOMzNyeWNRbmxPeUlhWlRwcnh2NnFqeXJJNnhxYm14ZWg2Y2svZ2FnMjRW?= =?utf-8?B?dkpDZDVwOUhqL2VRVzZMVGg0WEVKRUpEUldMUjhrOFZNUUI5cEcvUUJCbG1Y?= =?utf-8?Q?ryXzf+FByVpSyDKm8LZrkfah+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b5226d5-01d1-4946-8512-08dac0a8d82d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 10:14:24.2278 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AHR+rRlARYaQjotMbDl9sTz/LVoDjdA9W+spElx4XrCUPDdBswMACL66bRbdQTBY9/dx/I6nHX6EbYKDU3vz2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8905 On 07.11.2022 11:09, Wei Chen wrote: > Hi Jan, > >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年11月3日 22:26 >> To: Wei Chen >> Cc: nd ; Andrew Cooper ; Roger Pau >> Monné ; Wei Liu ; George Dunlap >> ; Julien Grall ; Stefano >> Stabellini ; xen-devel@lists.xenproject.org >> Subject: Re: [PATCH v7 2/6] xen/x86: move generically usable NUMA code >> from x86 to common >> >> On 20.10.2022 08:14, Wei Chen wrote: >>> There are some codes in x86/numa.c can be shared by common >>> architectures to implememnt NUMA support. Just like some >>> variables and functions to check and store NUMA memory map. >>> And some variables and functions to do NUMA initialization. >>> >>> In this patch, we move them to common/numa.c and xen/numa.h >>> and use the CONFIG_NUMA to gate them for non-NUMA supported >>> architectures. As the target header file is Xen-style, so >>> we trim some spaces and replace tabs for the codes that has >>> been moved to xen/numa.h at the same time. >>> >>> As acpi_scan_nodes has been used in a common function, it >>> doesn't make sense to use acpi_xxx in common code, so we >>> rename it to numa_process_nodes in this patch too. After that >>> if we still use CONFIG_ACPI_NUMA in to gate numa_process_nodes >>> in numa_initmem_init, that doesn't make sense. As CONFIG_NUMA >>> will be selected by CONFIG_ACPI_NUMA for x86. So, we replace >>> CONFIG_ACPI_NUMA by CONFIG_NUMA to gate numa_process_nodes. >>> >>> As arch_numa_disabled has been implememnted for ACPI NUMA, >>> we can rename srat_disabled to numa_disabled and move it >>> to common code as well. >>> >>> The macro node_to_first_cpu(node) hasn't been used anywhere, >>> so we drop it in this patch too. >>> >>> Because some architectures allow to use all 64 physical address >>> bits, but some architectures are not (like Arm64 allows 52, 48 >>> bits). In this case, we use min(PADDR_BITS, BITS_PER_LONG - 1) >>> to calculate the shift when only one node is in the system in >>> this patch too. >>> >>> Signed-off-by: Wei Chen >> >> Reviewed-by: Jan Beulich >> with one small further request (could be taken care of also while >> committing if no other need for a v8 arises): >> > > Thanks. This series is in merge conflict status now, do I need to > send a v8 to fix the merge conflict? Generally yes. While committers _may_ be willing to fix up conflicts, strictly speaking the committer role ought to be a purely mechanical one, i.e. not touching patches at all. > If yes, I will fix above as well, after PATCH#5 be reviewed. And I've been meaning to get to that one ... Then again this series can't be committed anyway before 4.17 was branched off. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:16:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:16:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439220.693230 (Exim 4.92) (envelope-from ) id 1orzB5-0002SP-2i; Mon, 07 Nov 2022 10:16:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439220.693230; Mon, 07 Nov 2022 10:16:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzB5-0002SI-04; Mon, 07 Nov 2022 10:16:27 +0000 Received: by outflank-mailman (input) for mailman id 439220; Mon, 07 Nov 2022 10:16:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzB3-0002SA-S7 for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 10:16:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzB3-000362-HR; Mon, 07 Nov 2022 10:16:25 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orzB3-0004RH-7P; Mon, 07 Nov 2022 10:16:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=BeG86s7GWDswrJjftMVkYlC0nUB0Ox1aQ3hTzWcJHmE=; b=tPLzqC6fCd6GDsFBkKpyXxEQT+ ntOGBQ3fxLY9Pqd2i4/L2rVLU/8Q31HYfBPNI2W2fjKSqQwt/swhxHq4Y1ijIssF3iHLnNXWAnFSN Mq5UrozbUtDxYknHQBOZuK4yl5v2Q5sqzjZkD7ybtyo2Bi2wjDNswYG3WK7UZi6ndDuM=; Message-ID: <88c909b5-4cad-aab0-2acd-fb3519963128@xen.org> Date: Mon, 7 Nov 2022 10:16:22 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 Content-Language: en-US To: Wei Chen , "xen-devel@lists.xenproject.org" Cc: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <9c3bfa0c-2c8f-2160-46d1-3be234b5bcaf@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/11/2022 09:52, Wei Chen wrote: > Hi Julien, Hi, > >>> - Supports only a single Security state - Secure. >>> - MPU in EL1 & EL2 is configurable, MMU in EL1 is configurable. >>> >>> These patch series are implementing the Armv8-R64 MPU support >>> for Xen, which are based on the discussion of >>> "Proposal for Porting Xen to Armv8-R64 - DraftC" [1]. >>> >>> We will implement the Armv8-R64 and MPU support in three stages: >>> 1. Boot Xen itself to idle thread, do not create any guests on it. >> >> I read this as I can build Xen and see it boots (not creating domain). >> However... HAS_MPU is not defined and I was expecting mm.c to be >> modified to cater the MPU support. So I am a bit ensure what the series >> is actually doing. >> > > These 11 patches are part#1 of stage#1, the full stage#1 has about 30 > patches. We have some concerns if we send so many patches at once, the > review pressure of maintainers may be very high, so we only choose about > 10 to send as part of it. But this also means that we can't do a relatively > complete thing in this part#1 series. > > We want to hear some suggestions from you to make so many patches can be > Reviewed efficiently. Can we send the patches by stages, even the stage#1 > will have about 30 patches? 30 patches in a go is no too bad. I would personally prefer that because at least I have better idea of the shape of the code after stage#1 and also possibly test it (I need to check if I have access for the ARMv8-R model). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:17:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:17:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439225.693242 (Exim 4.92) (envelope-from ) id 1orzBz-000309-CB; Mon, 07 Nov 2022 10:17:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439225.693242; Mon, 07 Nov 2022 10:17:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzBz-000302-9E; Mon, 07 Nov 2022 10:17:23 +0000 Received: by outflank-mailman (input) for mailman id 439225; Mon, 07 Nov 2022 10:17:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzBx-0002zp-PR for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 10:17:21 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062.outbound.protection.outlook.com [40.107.22.62]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d013403-5e85-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 11:17:20 +0100 (CET) Received: from AS8PR04CA0203.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::28) by GVXPR08MB7894.eurprd08.prod.outlook.com (2603:10a6:150::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 10:17:15 +0000 Received: from AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f3:cafe::42) by AS8PR04CA0203.outlook.office365.com (2603:10a6:20b:2f3::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Mon, 7 Nov 2022 10:17:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT046.mail.protection.outlook.com (100.127.140.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 10:17:14 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Mon, 07 Nov 2022 10:17:14 +0000 Received: from 0419c6185c35.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EFDCE1D7-B16C-425E-93EA-FD575ED8E8E4.1; Mon, 07 Nov 2022 10:17:09 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0419c6185c35.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Nov 2022 10:17:09 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by PR3PR08MB5772.eurprd08.prod.outlook.com (2603:10a6:102:8f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 10:17:08 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::461b:c1cb:368c:707e]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::461b:c1cb:368c:707e%5]) with mapi id 15.20.5813.011; Mon, 7 Nov 2022 10:17:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d013403-5e85-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lZvBsns65oPmkgZ+DGzFvLJyx3KhHmsoftJh4Y96o2qPwMlGSYxl+DKzUf439HAMrUFvI0LuL5/T8wLHyoxkXJOjf7NUW93kvgb2FFmpZTw1etk6GHavw80GJ8xV0qS8X4t5WwrVcb+m9Kz76FQQUBJPJAcoaEvPgs5oZoDA2YlgasqV6w3W7zAwKNY9vVKaa8zbhEvhuTT+nvRt4ExaQJDao0oI1lQWn4wp/u8BKm95D8PgWQI0a41eALAIbAbmq33VL127FR5GQUVc2YPbcvP0lpBH2cV4OUi/IPQDepAM6GDHAQGbfTplT+lFEJEGhKgLYkmOG8L9556VH1nqxQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KBv5hnaBTQqHm/aC59NGTBldhIyrn+SCQ++O86EPYy0=; b=Ym6kBoWpqpc7eQympCjucMbhnSsW5PqAsHTrlkoivFVjMh05/97bVhPAsc5+cbLV9Yz+GZI6LHjq+d0R3o9nuDMreL32DiNUUe+ikgWxYKhzbYd1/p2KnyMq50qklxxLvLAqdMeLh3AVORSRG6iGdZwKrSi1WIg1JloICEb3Idpg9j7LtscqE3KkXBp/j0nw5XKpKzA94Mgt27FCiM/8ZBxzDi8P0b0c1AFNDWuGyJEOGRzbySNCwz76991VMY6AaG0Br5j6kE2UfyZ+iG7XsfcKpeXhFvBbE4fAil7Gz1e6evi26spb6EWsao6scyn7h65MTsdtTy18ZwgvakDDIg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KBv5hnaBTQqHm/aC59NGTBldhIyrn+SCQ++O86EPYy0=; b=zmADT947plb0KjkzTXu8bxs575wr6Dm0O8IgMwBLSxwjQjhAN9DsTxBARc7xQ7CqHosCXyzmS4uZmhf75VVIQs+y9t4+/Ejz4AE8MGATQ4W7Y2oVfVUJ1xoNlckxVnIBhioAGDpNmrXDxJ93pu6Pk5/kEv9DQ6ceSR3mpqQDOL8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YNIjrELCjp3AnxcnV1D+LnnLygsEiBeO0DJydsgmkftWar30lWLxjT1wA6KhZ3ASayq9iAizGqhhSQp0SEDbvdpGSzP3DG7ZkM0wGRHsvv5/+HXvBIxz8QG47lV51uU7mlx4aKAHkCyOTH59podhOE3BJFEQ5OduRYJmh8ex2cRzu4m5dXgDmhpKZk9CXsLEGrd972xoHLlPEgspxNGDaxOAWcRzH1w7oTFzlAuTlIuRXyu+eHpxSpCmr8+AMnODgb6ZfPXSs7ciIGpxCuhoTRZ8E2ZclqS8ilFhQHHIz4oUbrL49N1F0fbhLjZs3Zv/19uILQm+tI6lfEuRlw8spQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KBv5hnaBTQqHm/aC59NGTBldhIyrn+SCQ++O86EPYy0=; b=d/ctcfmaR/93XiOefz51Lc23bPbKJNO2cfArU9axs5R7DQs7xkM9JGoNI21eEL0rQgQgF3c8qa57d194MzI8R+VfKmalOjZB6HgJSwqWCnUGgss2V7DTxQ8TTYmDjY1tYsNU/xQOGqNutONvBsw2q50UHqhN2hOARAm/nIepFoQNstoLboI0Li1aGoQRbFmcQ2wCEgAiNbnuS9yBKqVbwmms151DemlZZ7OFNWQ4eQAT4Y3Vvs7y2WRWh1M94P7O8GhbXXPZ3YaSjj6H8lVZL+425kDFTNobUCyuMj1zvp+KsPI5amNaPMd+gTqG1rTAgEn5ykPhF+zuBmJtnpwLOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KBv5hnaBTQqHm/aC59NGTBldhIyrn+SCQ++O86EPYy0=; b=zmADT947plb0KjkzTXu8bxs575wr6Dm0O8IgMwBLSxwjQjhAN9DsTxBARc7xQ7CqHosCXyzmS4uZmhf75VVIQs+y9t4+/Ejz4AE8MGATQ4W7Y2oVfVUJ1xoNlckxVnIBhioAGDpNmrXDxJ93pu6Pk5/kEv9DQ6ceSR3mpqQDOL8= From: Penny Zheng To: Julien Grall , Wei Chen , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 09/11] xen/arm64: create boot-time MPU protection regions Thread-Topic: [PATCH v6 09/11] xen/arm64: create boot-time MPU protection regions Thread-Index: AQHY8DVssS7ibAAWlEawRuPWKxX+kq4yYWYAgACZqiCAADt4AIAACYaw Date: Mon, 7 Nov 2022 10:17:08 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-10-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A40723F14849274DAEE1E6E9B954B0F0.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|PR3PR08MB5772:EE_|AM7EUR03FT046:EE_|GVXPR08MB7894:EE_ X-MS-Office365-Filtering-Correlation-Id: ff6c59f7-9179-4a6a-775c-08dac0a93e17 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ZmJ/qyUAjC4L92b/3bECRv96f5oh7BfnQXx4svXBL+l44+vsbbSHSlPhF0j41xH/jIz4UhasZI+RIvxJncYla5eVfNWPtMqI5obCkrppM4N68OXrE8aUDduSlSCkv+oA5RbKd5QDy3sWokcmAjJeiMXLrKJ3Ow2asLUzoGcyIJT33oVrfQQW7e5mD17qEaOuwYDcXRQYpuSTeCs2PZgMozIsx4f+kPq4TKOsHaECscWHle4kEqoQ7MKIbO1ek45Q0CAh5q7CrRxOtiYAOZFefV/JkSvoLQZjQkXB3vLZm/JF6FgB+j0Ngx2N0WhYp3pyDo/rQkX2mbJFAsX4r4jeAKdxOoaYRX3EPLPCrsdudNDumKYlxmdaYF+/P+EodKIbNLA0Oe7o7CMrO/H68S5eiusW2W93ZQsfSXvmm4IXU/XiS07oBcqmZFKuEKHYYRVlwBJeOEon111IPgfs2AcdfjgRkVaQIhcXC0JvwY0F+JKIXPQvTpebk2cOgKaZJEheWenwGZ0yxxutB9jvHSm28q0xGnVoB9IL1FDpiU8O9M1W4SE7Y7/N9ySMurxjHmKu3NiF8UBzDyAKpF6IF1VOttvmVLRXzP4k56EIyZd1023oj0P4JPOT1u81Ymug4SGjDkTrNclnnfHEZPOXA6IE0TpN36DHAkhMdjBulxS8Hn5wBRg//ehLYlM58fuErneWrTw/qaN+pBLpTcKW9hzYZmlLSDi5TFuEYaWlJuGhFXh4WwjWz3FEJCghdSO3JMsdsDb/Yucxg73H0rkB+C5mWA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(39860400002)(376002)(136003)(451199015)(33656002)(7696005)(86362001)(53546011)(26005)(9686003)(316002)(54906003)(76116006)(186003)(110136005)(2906002)(52536014)(5660300002)(38100700002)(122000001)(66556008)(66476007)(66946007)(8936002)(55016003)(66446008)(64756008)(41300700001)(4326008)(38070700005)(8676002)(83380400001)(6506007)(478600001)(71200400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5772 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: faa4c30e-063a-4d22-60c8-08dac0a939fa X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ncP4ngUd7QBVCvvbiwL/pgn6npCEjdGTVMi6D0T861vyrfueEtmSeR0kZtzNgNp7JQegvK9QqCvP6aTHBAfvMlfY7NW6IdY+8GI2/t4J0GhBZeEvXGFeCNiKgv89kLh+x6NemcmoTh2me/zOnpsSEPl2pzEY4oHnAeJIGTzW2XVaDeb/u2AbxVNTiMqLwGkFbT9clYDwI2BB9u1t6di+v3tjoLxwSxmVdKIvMUr1T50CLW5Ah3/AhDP42Bet9xor5Dpcdwc7N5aYQ0/42K+VydcFECMYUjqonhz8vMwF91oXEJlIYVdH9bRzrvIjKvqlN4k/u89LrHyEGn5mIe9Qm8l2nIW3PWmKSAMFedOA9c4kuBMLpTXGZttN/sAvuSxK3hoURvtOd5RFe2RrF+BfCqIPH90/xJ/K0txM3bjNiyY900ntj/cCvOLsNX6j0j2GmHEumQWjrBLC7I99Kgc+oGE8y3LErQLxD6ejMNvN4zXc6jjMPz26jgUgj/QcTLZLTHfXDLSO0zzpG7+GISbx7cTwzSIR3alcyuipAUwzfzD7OaawEomiEPhK6jY0pRcGqC0bvbGG8M29fB+S4hidXomyXzukOfFEn1ZgOoX9vm7GG/WKsdbUG3NWEMegtnM9oqBaXuXjjcMLMcckRNtirbrGbzmt23aQ/U/IJ4S0M1ijlgUr/EKXUp4gFExb0HNZu7kjBJRiPLjhLYKmCYri9HlaOcb2TromuIUJO+oc5odatlnjrVV6JY2dV8gBGWFdhqh0ml6xT8uzVIgUluiOLg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(376002)(346002)(451199015)(36840700001)(46966006)(40470700004)(52536014)(8936002)(33656002)(5660300002)(40480700001)(41300700001)(40460700003)(86362001)(83380400001)(47076005)(336012)(186003)(82310400005)(7696005)(4326008)(53546011)(6506007)(9686003)(26005)(478600001)(107886003)(81166007)(356005)(82740400003)(55016003)(8676002)(70206006)(70586007)(36860700001)(110136005)(54906003)(316002)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 10:17:14.9296 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ff6c59f7-9179-4a6a-775c-08dac0a93e17 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7894 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogTW9uZGF5LCBOb3ZlbWJlciA3LCAyMDIy IDU6MzAgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgV2VpIENo ZW4NCj4gPFdlaS5DaGVuQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcN Cj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBr ZXJuZWwub3JnPjsgQmVydHJhbmQNCj4gTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29t PjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPiBT dWJqZWN0OiBSZTogW1BBVENIIHY2IDA5LzExXSB4ZW4vYXJtNjQ6IGNyZWF0ZSBib290LXRpbWUg TVBVIHByb3RlY3Rpb24NCj4gcmVnaW9ucw0KPiANCj4gT24gMDcvMTEvMjAyMiAwNjo1OSwgUGVu bnkgWmhlbmcgd3JvdGU6DQo+ID4gSGkgSnVsaWVuDQo+IA0KPiBIaSBQZW5ueSwNCj4gDQo+ID4+ PiArDQo+ID4+PiArLyoNCj4gPj4+ICsgKiBJbiBib290IHN0YWdlLCB3ZSB3aWxsIHVzZSAxIE1Q VSByZWdpb246DQo+ID4+PiArICogUmVnaW9uIzA6IE5vcm1hbCBtZW1vcnkgZm9yIFhlbiB0ZXh0 ICsgZGF0YSArIGJzcyAoMk1CKSAgKi8NCj4gPj4NCj4gPj4gQXJlIHdlIG9ubHkgZ29pbmcgdG8g bW9kaWZ5IHRoZSBNUFUgaW4gaGVhZC5TPyBJZiBub3QsIHRoZW4gSSB3b3VsZA0KPiA+PiBkZWZp bmUgdGhlIGxheW91dCBpbiBjb25maWdfbXB1Lmggc28gdGhlcmUgYXJlIGEgc2luZ2xlIHBvaW50 IHdoZXJlDQo+ID4+IHlvdSBjYW4gcmVhZCBob3cgdGhpcyB3b3Jrcy4NCj4gPj4NCj4gPg0KPiA+ IFdlIHdpbGwgcmVtYXAgWGVuIGluIEMgY29kZXMgaW4gc2V0dXBfbW0oKS4NCj4gPiBUaGUgd2hv bGUgc3RyYXRlZ3kgaXMgYWxpZ25lZCB3aXRoIE1NVTogYSB2ZXJ5IHNpbXBsZSBzZXR1cChtYXAg eGVuDQo+ID4gd2l0aCB0aGUgbWF4aW11bSBzaXplLCAyTSkgYXQgc3RhcnQtb2YtdGhlLWRheSwg YW5kIGEgZml0IG1hcCBpbg0KPiA+IHNldHVwX21tLg0KPiANCj4gVGhlIHN0cmF0ZWd5IHdlIGFy ZSB1c2luZyBmb3IgdGhlIE1NVSBpcyBjb21wbGV0ZWx5IGJyb2tlbiAobm90IGNvbXBsaWFudA0K PiB3aXRoIHRoZSBBcm0gQXJtKSBhbmQgdW5uZWNlc3NhcnkuIE15IGxvbmcgdGVybSBnb2FsIGlz IHRvIGFjdHVhbGx5IHJlbW92ZQ0KPiB0aGUgc3dpdGNoX3R0YnIoKSBhbmQgbW9zdCBvZiBzZXR1 cF9wYWdldGFibGVzKCkgZm9yIGFsbCBzZXR1cCBidXQgY2FjaGUNCj4gY29sb3JpbmcuIFRoaXMg bWVhbnMgdGhlIGNvbmNlcHQgb2YgYm9vdCBwYWdlcyB3aWxsIG5vdCBleGlzdCBhbnltb3JlLg0K PiANCj4gRm9yIHRoZSBNUFUsIHdlIHNob3VsZCBhaW0gdG8gZG8gYmV0dGVyIHRoYW4gd2hhdCB3 YXMgZG9uZSBmb3IgdGhlIE1NVS4NCj4gUmlnaHQgbm93LCBJIHNlZSBubyBhcmd1bWVudCBmb3Ig c3dpdGNoaW5nIE1QVXMgdGFibGUuIEkgYW0gb25seSBzZWVuDQo+IGFyZ3VtZW50IGFnYWluc3Qg aXQgYmVjYXVzZSB5b3UgbmVlZCB0byBkaXNhYmxlIHRoZSBjYWNoZSBhbmQgaXMgcXVpdGUgZnJh Z2lsZS4NCj4gDQoNCj4gWy4uLl0NCj4gDQo+ID4+PiArDQo+ID4+PiArICAgIGxkciB4MiwgPVhF Tl9TVEFSVF9BRERSRVNTDQo+ID4+PiArICAgIG1vdiB4MywgIyhYRU5fU1RBUlRfTUVNX1NJWkUg LSAxKQ0KPiA+Pg0KPiA+PiBYRU5fU1RBUlRfTUVNX1NJWkUgaXMgdGhlIG1heGltdW0gc2l6ZSBv ZiBYZW4uIElPVywgWGVuIG1heSBiZQ0KPiA+PiBzbWFsbGVyIGFuZCB5b3Ugd2lsbCBtYXAgbWVt b3J5IHRoYXQgbWF5IG5vdCBiZSBwYXJ0IG9mIFhlbi4NCj4gPj4gVGhlcmVmb3JlLCB5b3UgbGlr ZWx5IHdhbnQgdG8gY29tcHV0ZSB0aGUgcmVhbCBzaXplIHRvIGF2b2lkIG1hcHBpbmcNCj4gPj4g dG9vIG11Y2guDQo+ID4+DQo+ID4NCj4gPiBMYXRlciwgaW4gc2V0dXBfbW0gd2Ugd2lsbCBtYXAg WEVOIGNvbXBvbmVudHMgYnkgY29tcG9uZW50cywgc3VjaCBhcywNCj4gPiBvbmUgTVBVIG1lbW9y eSByZWdpb24gZm9yIHJlYWQtb25seS1leGVjdXRhYmxlIHRleHQgc2VjdGlvbiwgb25lIE1QVQ0K PiA+IG1lbW9yeSByZWdpb24gZm9yIHJlYWQtb25seSBkYXRhIHNlY3Rpb24sIGV0YywgZXRjLg0K PiA+IFNvIGluIHRoZXJlLCBYRU4gd2lsbCBiZSBtYXBwZWQgZml0bHkuDQo+IA0KPiBCdXQgd2hh dCBwcmV2ZW50cyB5b3UgdG8gZG8gdGhpcyBub3c/DQo+IA0KPiA+DQo+ID4gSU1ITywgdGhlIG1h cHBpbmcgaW4gY29tcGlsZXIgd2l0aCBtYXhpbXVtIHNpemUgb2YgWGVuIGlzIGFsc28gd2hhdA0K PiA+IE1NVSBkb2VzLg0KPiANCj4gV2hpY2ggaXMgYnJva2VuIGJlY2F1c2Ugd2UgZG9uJ3Qga25v dyB3aGF0IGxvY2F0ZWQgYWZ0ZXIgWGVuIGJpbmFyeS4NCj4gVGhpcyBjb3VsZCBiZSByZXNlcnZl ZCBSQU0sIGRldmljZSB3aGljaCBtYXkgcmVxdWlyZXMgbm9uLWNhY2hpbmcNCj4gYXR0cmlidXRl LiBNYXBwaW5nIHRob3NlIHJlZ2lvbnMgd2l0aCBjYWNoaW5nIGF0dHJpYnV0ZXMgaXMgZ29pbmcg dG8gYnJlYWsuDQo+IA0KDQpVbmRlcnN0b29kIQ0KVGhlbiBJIHdpbGwgbWFwIFhlbiBjb21wb25l bnRzIGJ5IGNvbXBvbmVudHMgaW4gdGhlIGNvbXBpbGUgdGltZSwNCnRoZW4gbGF0ZXIgdGhlIGZp cnN0IE1QVS9DYWNoZSBkaXNhYmxlZCB3aWxsIGJlIGVsaW1pbmF0ZWQsIEkgZ3Vlc3MuDQoNCj4g DQo+IENoZWVycywNCj4gDQo+IFsxXSAyMDIyMTAyMjE1MDQyMi4xNzcwNy0xLWp1bGllbkB4ZW4u b3JnDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:27:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:27:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439234.693253 (Exim 4.92) (envelope-from ) id 1orzLh-0004s2-EU; Mon, 07 Nov 2022 10:27:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439234.693253; Mon, 07 Nov 2022 10:27:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzLh-0004rv-BV; Mon, 07 Nov 2022 10:27:25 +0000 Received: by outflank-mailman (input) for mailman id 439234; Mon, 07 Nov 2022 10:27:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzLe-0004rZ-Sw for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 10:27:23 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c2290443-5e86-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 11:27:19 +0100 (CET) Received: by mail-ej1-x62b.google.com with SMTP id k2so28816959ejr.2 for ; Mon, 07 Nov 2022 02:27:19 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2290443-5e86-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bAddvVPDdRyLZnrfKB95HbgXsc3hKMehb9lipqYbdss=; b=bRRJIIcox7PI4Ipb5+zAk7fcHHWWeeBlvaGVhrmQVjJRxmgVm28+NZaiZm91QYkWI0 jzwbSae334AQg1jN08Psok0y9pGS2yu/nchtpocbL0vIlWjAkvA2fDQjv8itpNbNXE+o V2C7PpLNyRvRq9Z3GRf520bM0bFtSfp3QssPwEBBN8xdUMxWwTiPGdd8CF+BGUCH9/Xo 5W2YNCdWRzzipbqNoR/jP7YaAtokW+GcGbZ7aSHAIXYxDP4pehyc+MlG1JhX0xJpnMgk uvUqzc63/xybpQCiJJEcBi5z65yDZasiLVsMUT0HqoBeZl6aY4+T1vYm06SDPzQwSeol La0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bAddvVPDdRyLZnrfKB95HbgXsc3hKMehb9lipqYbdss=; b=f8M1Ojj5kw78BlddP1JPBKH9/5MQnhOsimVIO2UAW9K9/HuJdooJxWu2y13fZE4RC1 tUWFqnQ1cqI+y5pDKkQRy6AgxjDKZno52GOnlISJecWERjJDGxO2U6MACF5tDcmILnbf wBJGn/MaSyorYxzEx+A4n2VX3JRm6jW/TzGDvRFQYNQIgUA/t17Eue6y5GdU3b9pN4tP cs2at3uu3jkvSbTHKAAq81v8WiOyPLDj74d4OililC/9jbSjYliLyzqEDAzyyrUW8HOO 5U0QPzlativyj0o/YZHyx5kuKpP/BfY9rjfppvfKeCGhr3zaQQ3nhZtWAYxseEPAMjn/ T16g== X-Gm-Message-State: ACrzQf0tl3eOyX5m5ejyhdUU6wHq/8XsG1zAHTCnfQd63fbcJGOgFoYS v8/5tAtCzC0BMsAG/tqU3oboOVMcrGAsSla+HaY= X-Google-Smtp-Source: AMsMyM7TLdwzwVQZogsnlbDlmfKdNK40Xbop+8BRpQ18DE93fXo59L+/QakucNeHtC7p7XpyfJtlTYuvb5mcFrn3Jl8= X-Received: by 2002:a17:907:3e01:b0:730:a690:a211 with SMTP id hp1-20020a1709073e0100b00730a690a211mr47031040ejc.596.1667816838718; Mon, 07 Nov 2022 02:27:18 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Vipul Suneja Date: Mon, 7 Nov 2022 15:57:04 +0530 Message-ID: Subject: Re: Porting Xen in raspberry pi4B To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, oleksandr_andrushchenko@epam.com, oleksandr_tyshchenko@epam.com, jgross@suse.com, boris.ostrovsky@oracle.com, Bertrand.Marquis@arm.com Content-Type: multipart/alternative; boundary="00000000000038e94005ecdede34" --00000000000038e94005ecdede34 Content-Type: text/plain; charset="UTF-8" Hi Stefano, Thanks! Any input further on "xenstore-ls" logs? I am trying to run the x0vncserver & x11vnc server manually on guest machine(xen_guest_image_minimal) image but it's failing with the below error. *root@raspberrypi4-64:/usr/bin# x0vncserverx0vncserver: unable to open display ""root@raspberrypi4-64:/usr/bin# root@raspberrypi4-64:/usr/bin# x11vnc################################################################@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@##@ @##@ ** WARNING ** WARNING ** WARNING ** WARNING ** @##@ @##@ YOU ARE RUNNING X11VNC WITHOUT A PASSWORD!! @##@ @##@ This means anyone with network access to this computer @##@ may be able to view and control your desktop. @##@ @##@ >>> If you did not mean to do this Press CTRL-C now!! <<< @##@ @##@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@##@ @##@ You can create an x11vnc password file by running: @##@ @##@ x11vnc -storepasswd password /path/to/passfile @##@ or x11vnc -storepasswd /path/to/passfile @##@ or x11vnc -storepasswd @##@ @##@ (the last one will use ~/.vnc/passwd) @##@ @##@ and then starting x11vnc via: @##@ @##@ x11vnc -rfbauth /path/to/passfile @##@ @##@ an existing ~/.vnc/passwd file from another VNC @##@ application will work fine too. @##@ @##@ You can also use the -passwdfile or -passwd options. @##@ (note -passwd is unsafe if local users are not trusted) @##@ @##@ Make sure any -rfbauth and -passwdfile password files @##@ cannot be read by untrusted users. @##@ @##@ Use x11vnc -usepw to automatically use your @##@ ~/.vnc/passwd or ~/.vnc/passwdfile password files. @##@ (and prompt you to create ~/.vnc/passwd if neither @##@ file exists.) Under -usepw, x11vnc will exit if it @##@ cannot find a password to use. @##@ @##@ @##@ Even with a password, the subsequent VNC traffic is @##@ sent in the clear. Consider tunnelling via ssh(1): @##@ @##@ http://www.karlrunge.com/x11vnc/#tunnelling @##@ @##@ Or using the x11vnc SSL options: -ssl and -stunnel @##@ @##@ Please Read the documentation for more info about @##@ passwords, security, and encryption. @##@ @##@ http://www.karlrunge.com/x11vnc/faq.html#faq-passwd @##@ @##@ To disable this warning use the -nopw option, or put @##@ 'nopw' on a line in your ~/.x11vncrc file. @##@ @##@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@################################################################09/03/2018 12:58:41 x11vnc version: 0.9.16 lastmod: 2019-01-05 pid: 42409/03/2018 12:58:41 XOpenDisplay("") failed.09/03/2018 12:58:41 Trying again with XAUTHLOCALHOSTNAME=localhost ...09/03/2018 12:58:41 09/03/2018 12:58:41 *** XOpenDisplay failed. No -display or DISPLAY.09/03/2018 12:58:41 *** Trying ":0" in 4 seconds. Press Ctrl-C to abort.09/03/2018 12:58:41 *** 1 2 3 4 09/03/2018 12:58:45 XOpenDisplay(":0") failed.09/03/2018 12:58:45 Trying again with XAUTHLOCALHOSTNAME=localhost ...09/03/2018 12:58:45 XOpenDisplay(":0") failed.09/03/2018 12:58:45 Trying again with unset XAUTHLOCALHOSTNAME ...09/03/2018 12:58:45 09/03/2018 12:58:45 ***************************************09/03/2018 12:58:45 *** XOpenDisplay failed (:0)*** x11vnc was unable to open the X DISPLAY: ":0", it cannot continue.*** There may be "Xlib:" error messages above with details about the failure.Some tips and guidelines:** An X server (the one you wish to view) must be running before x11vnc is started: x11vnc does not start the X server. (however, see the -create option if that is what you really want).** You must use -display , -OR- set and export your $DISPLAY environment variable to refer to the display of the desired X server. - Usually the display is simply ":0" (in fact x11vnc uses this if you forget to specify it), but in some multi-user situations it could be ":1", ":2", or even ":137". Ask your administrator or a guru if you are having difficulty determining what your X DISPLAY is.** Next, you need to have sufficient permissions (Xauthority) to connect to the X DISPLAY. Here are some Tips: - Often, you just need to run x11vnc as the user logged into the X session. So make sure to be that user when you type x11vnc. - Being root is usually not enough because the incorrect MIT-MAGIC-COOKIE file may be accessed. The cookie file contains the secret key that allows x11vnc to connect to the desired X DISPLAY. - You can explicitly indicate which MIT-MAGIC-COOKIE file should be used by the -auth option, e.g.: x11vnc -auth /home/someuser/.Xauthority -display :0 x11vnc -auth /tmp/.gdmzndVlR -display :0 you must have read permission for the auth file. See also '-auth guess' and '-findauth' discussed below.** If NO ONE is logged into an X session yet, but there is a greeter login program like "gdm", "kdm", "xdm", or "dtlogin" running, you will need to find and use the raw display manager MIT-MAGIC-COOKIE file. Some examples for various display managers: gdm: -auth /var/gdm/:0.Xauth -auth /var/lib/gdm/:0.Xauth kdm: -auth /var/lib/kdm/A:0-crWk72 -auth /var/run/xauth/A:0-crWk72 xdm: -auth /var/lib/xdm/authdir/authfiles/A:0-XQvaJk dtlogin: -auth /var/dt/A:0-UgaaXa Sometimes the command "ps wwwwaux | grep auth" can reveal the file location. Starting with x11vnc 0.9.9 you can have it try to guess by using: -auth guess (see also the x11vnc -findauth option.) Only root will have read permission for the file, and so x11vnc must be run as root (or copy it). The random characters in the filenames will of course change and the directory the cookie file resides in is system dependent.See also: http://www.karlrunge.com/x11vnc/faq.html * Regards, Vipul Kumar On Thu, Nov 3, 2022 at 10:27 PM Vipul Suneja wrote: > Hi Stefano, > > Thanks! > > I used xen-guest-image-minimal(simple console based image) as a guest with > fbcon & fbdev enabled in kernel configurations but still the same error > can't open the display. > below are the outcome of "xenstore-ls": > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > *root@raspberrypi4-64:~/guest1# xenstore-lstool = "" xenstored = ""local = > "" domain = "" 0 = "" control = "" feature-poweroff = "1" > feature-reboot = "1" domid = "0" name = "Domain-0" device-model = "" > 0 = "" backends = "" console = "" vkbd = "" vfb = "" > qnic = "" state = "running" 1 = "" backends = "" > console = "" vkbd = "" vfb = "" qnic = "" state = > "running" backend = "" vbd = "" 1 = "" 51712 = "" > frontend = "/local/domain/1/device/vbd/51712" params = > "/home/root/guest2/xen-guest-image-minimal-raspberrypi4-64.ext3" > script = "/etc/xen/scripts/block" frontend-id = "1" online = > "1" removable = "0" bootable = "1" state = "4" dev > = "xvda" type = "phy" mode = "w" device-type = "disk" > discard-enable = "1" feature-max-indirect-segments = "256" > multi-queue-max-queues = "4" max-ring-page-order = "4" node = > "/dev/loop0" physical-device = "7:0" physical-device-path = > "/dev/loop0" hotplug-status = "connected" feature-flush-cache = > "1" discard-granularity = "4096" discard-alignment = "0" > discard-secure = "0" feature-discard = "1" feature-barrier = > "1" feature-persistent = "1" sectors = "1794048" info = > "0" sector-size = "512" physical-sector-size = "512" vfb = > "" 1 = "" 0 = "" frontend = "/local/domain/1/device/vfb/0" > frontend-id = "1" online = "1" state = "4" vnc = > "1" vnclisten = "127.0.0.1" vncdisplay = "0" vncunused = > "1" sdl = "0" opengl = "0" feature-resize = "1" > hotplug-status = "connected" request-update = "1" vkbd = "" 1 > = "" 0 = "" frontend = "/local/domain/1/device/vkbd/0" > frontend-id = "1" online = "1" state = "4" > feature-abs-pointer = "1" feature-raw-pointer = "1" > hotplug-status = "connected" console = "" 1 = "" 0 = "" > frontend = "/local/domain/1/console" frontend-id = "1" online > = "1" state = "1" protocol = "vt100" vif = "" 1 = "" > 0 = "" frontend = "/local/domain/1/device/vif/0" frontend-id > = "1" online = "1" state = "4" script = > "/etc/xen/scripts/vif-bridge" mac = "e4:5f:01:cd:7b:dd" bridge > = "xenbr0" handle = "0" type = "vif" hotplug-status = > "connected" feature-sg = "1" feature-gso-tcpv4 = "1" > feature-gso-tcpv6 = "1" feature-ipv6-csum-offload = "1" > feature-rx-copy = "1" feature-xdp-headroom = "1" > feature-rx-flip = "0" feature-multicast-control = "1" > feature-dynamic-multicast-control = "1" feature-split-event-channels > = "1" multi-queue-max-queues = "4" feature-ctrl-ring = "1" 1 = > "" vm = "/vm/d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f" name = "guest2" > cpu = "" 0 = "" availability = "online" 1 = "" availability > = "online" memory = "" static-max = "2097152" target = "2097152" > videoram = "0" device = "" suspend = "" event-channel = "" vbd > = "" 51712 = "" backend = "/local/domain/0/backend/vbd/1/51712" > backend-id = "0" state = "4" virtual-device = "51712" > device-type = "disk" multi-queue-num-queues = "2" queue-0 = "" > ring-ref = "8" event-channel = "4" queue-1 = "" > ring-ref = "9" event-channel = "5" protocol = "arm-abi" > feature-persistent = "1" vfb = "" 0 = "" backend = > "/local/domain/0/backend/vfb/1/0" backend-id = "0" state = "4" > page-ref = "275022" event-channel = "3" protocol = "arm-abi" > feature-update = "1" vkbd = "" 0 = "" backend = > "/local/domain/0/backend/vkbd/1/0" backend-id = "0" state = "4" > request-abs-pointer = "1" page-ref = "275322" page-gref = > "1284" event-channel = "10" vif = "" 0 = "" backend = > "/local/domain/0/backend/vif/1/0" backend-id = "0" state = "4" > handle = "0" mac = "e4:5f:01:cd:7b:dd" mtu = "1500" > xdp-headroom = "0" multi-queue-num-queues = "2" queue-0 = "" > tx-ring-ref = "1280" rx-ring-ref = "1281" event-channel-tx = > "6" event-channel-rx = "7" queue-1 = "" tx-ring-ref = > "1282" rx-ring-ref = "1283" event-channel-tx = "8" > event-channel-rx = "9" request-rx-copy = "1" feature-rx-notify = > "1" feature-sg = "1" feature-gso-tcpv4 = "1" > feature-gso-tcpv6 = "1" feature-ipv6-csum-offload = "1" control = > "" shutdown = "" feature-poweroff = "1" feature-reboot = "1" > feature-suspend = "" sysrq = "" > platform-feature-multiprocessor-suspend = "1" > platform-feature-xs_reset_watches = "1" data = "" drivers = "" > feature = "" attr = "" error = "" domid = "1" store = "" port = > "1" ring-ref = "233473" console = "" backend = > "/local/domain/0/backend/console/1/0" backend-id = "0" limit = > "1048576" type = "xenconsoled" output = "pty" tty = "/dev/pts/1" > port = "2" ring-ref = "233472" vnc-listen = "127.0.0.1" vnc-port > = "5900" image = "" device-model-pid = "788"vm = > "" d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f = "" name = "guest2" uuid = > "d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f" start_time = "1520600274.27"libxl = > "" 1 = "" device = "" vbd = "" 51712 = "" frontend = > "/local/domain/1/device/vbd/51712" backend = > "/local/domain/0/backend/vbd/1/51712" params = > "/home/root/guest2/xen-guest-image-minimal-raspberrypi4-64.ext3" script > = "/etc/xen/scripts/block" frontend-id = "1" online = "1" > removable = "0" bootable = "1" state = "1" dev = "xvda" > type = "phy" mode = "w" device-type = "disk" discard-enable = > "1" vfb = "" 0 = "" frontend = "/local/domain/1/device/vfb/0" > backend = "/local/domain/0/backend/vfb/1/0" frontend-id = "1" > online = "1" state = "1" vnc = "1" vnclisten = "127.0.0.1" > vncdisplay = "0" vncunused = "1" sdl = "0" opengl = "0" vkbd > = "" 0 = "" frontend = "/local/domain/1/device/vkbd/0" backend = > "/local/domain/0/backend/vkbd/1/0" frontend-id = "1" online = "1" > state = "1" console = "" 0 = "" frontend = > "/local/domain/1/console" backend = > "/local/domain/0/backend/console/1/0" frontend-id = "1" online = > "1" state = "1" protocol = "vt100" vif = "" 0 = "" > frontend = "/local/domain/1/device/vif/0" backend = > "/local/domain/0/backend/vif/1/0" frontend-id = "1" online = "1" > state = "1" script = "/etc/xen/scripts/vif-bridge" mac = > "e4:5f:01:cd:7b:dd" bridge = "xenbr0" handle = "0" type = > "vif" hotplug-status = "" type = "pvh" dm-version = > "qemu_xen"root@raspberrypi4-64:~/guest1#* > > Any input as per above? Looking forward to hearing from you. > > Regards, > Vipul Kumar > > On Wed, Oct 26, 2022 at 5:21 AM Stefano Stabellini > wrote: > >> Hi Vipul, >> >> If you look at the QEMU logs, it says: >> >> VNC server running on 127.0.0.1:5900 >> >> That is the VNC server you need to connect to. So in theory: >> >> vncviewer 127.0.0.1:5900 >> >> should work correctly. >> >> >> If you have: >> >> vfb = ["type=vnc"] >> >> in your xl config file and you have "fbdev" in your Linux guest, it >> should work. >> >> If you connect to the VNC server but you get a black screen, it might be >> a guest configuration issue. I would try with a simpler guest, text only >> (no X11, no Wayland) and enable the fbdev console (fbcon). See >> Documentation/fb/fbcon.rst in Linux. You should be able to see a >> graphical console over VNC. >> >> If that works, then you know that the fbdev kernel driver (xen-fbfront) >> works correctly. >> >> If it doesn't work, the output of "xenstore-ls" would be interesting. >> >> Cheers, >> >> Stefano >> >> >> On Wed, 19 Oct 2022, Vipul Suneja wrote: >> > Hi Stefano, >> > >> > Thanks for the response! >> > >> > I am following the same link you shared from the beginning. Tried the >> command "vncviewer localhost:0" in DOM0 but same issue "Can't open >> > display", below are the logs: >> > >> > root@raspberrypi4-64:~# vncviewer localhost:0 >> > >> > TigerVNC Viewer 64-bit v1.11.0 >> > Built on: 2020-09-08 12:16 >> > Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst) >> > See https://www.tigervnc.org for information on TigerVNC. >> > Can't open display: >> > >> > Below are the netstat logs, i couldn't see anything running at port >> 5900 or 5901: >> > >> > root@raspberrypi4-64:~# netstat -tuwx >> > Active Internet connections (w/o servers) >> > Proto Recv-Q Send-Q Local Address Foreign Address >> State >> > tcp 0 164 192.168.1.39:ssh 192.168.1.38:37472 >> ESTABLISHED >> > Active UNIX domain sockets (w/o servers) >> > Proto RefCnt Flags Type State I-Node Path >> > unix 8 [ ] DGRAM CONNECTED 10565 /dev/log >> > unix 3 [ ] STREAM CONNECTED 10891 >> /var/run/xenstored/socket >> > unix 3 [ ] STREAM CONNECTED 13791 >> > unix 3 [ ] STREAM CONNECTED 10843 >> /var/run/xenstored/socket >> > unix 3 [ ] STREAM CONNECTED 10573 >> /var/run/xenstored/socket >> > unix 2 [ ] DGRAM CONNECTED 14510 >> > unix 3 [ ] STREAM CONNECTED 13249 >> > unix 2 [ ] DGRAM CONNECTED 13887 >> > unix 2 [ ] DGRAM CONNECTED 10599 >> > unix 3 [ ] STREAM CONNECTED 14005 >> > unix 3 [ ] STREAM CONNECTED 13258 >> > unix 3 [ ] STREAM CONNECTED 13248 >> > unix 3 [ ] STREAM CONNECTED 14003 >> > unix 3 [ ] STREAM CONNECTED 10572 >> /var/run/xenstored/socket >> > unix 3 [ ] STREAM CONNECTED 10786 >> /var/run/xenstored/socket >> > unix 3 [ ] DGRAM CONNECTED 13186 >> > unix 3 [ ] STREAM CONNECTED 10864 >> /var/run/xenstored/socket >> > unix 3 [ ] STREAM CONNECTED 10812 >> /var/run/xenstored/socket >> > unix 2 [ ] DGRAM CONNECTED 14083 >> > unix 3 [ ] STREAM CONNECTED 10813 >> /var/run/xenstored/socket >> > unix 3 [ ] STREAM CONNECTED 14068 >> > unix 3 [ ] STREAM CONNECTED 13256 >> > unix 3 [ ] STREAM CONNECTED 10571 >> /var/run/xenstored/socket >> > unix 3 [ ] STREAM CONNECTED 10842 >> > unix 3 [ ] STREAM CONNECTED 13985 >> > unix 3 [ ] DGRAM CONNECTED 13185 >> > unix 2 [ ] STREAM CONNECTED 13884 >> > unix 2 [ ] DGRAM CONNECTED 14528 >> > unix 2 [ ] DGRAM CONNECTED 13785 >> > unix 3 [ ] STREAM CONNECTED 14034 >> > >> > Attaching xen log files of /var/log/xen. >> > I didn't get the role of QEMU here because as mentioned earlier, I am >> porting in raspberrypi 4B. >> > >> > Regards, >> > Vipul Kumar >> > >> > On Wed, Oct 19, 2022 at 12:43 AM Stefano Stabellini < >> sstabellini@kernel.org> wrote: >> > It usually works the way it is described in the guide: >> > >> > >> https://www.virtuatopia.com/index.php?title=Configuring_a_VNC_based_Graphical_Console_for_a_Xen_Paravirtualized_domainU_Guest >> > >> > You don't need to install any VNC-related server software because >> it is >> > already provided by Xen (to be precise it is provided by QEMU >> working >> > together with Xen.) >> > >> > You only need the vnc client in dom0 so that you can connect, but >> you >> > could also run the vnc client outside from another host. So >> basically >> > the following should work when executed in Dom0 after creating >> DomU: >> > >> > vncviewer localhost:0 >> > >> > Can you attach the Xen and QEMU logs (/var/log/xen/*)? And also >> use >> > netstat -taunp to check if there is anything running at port 5900 >> or >> > 5901? >> > >> > Cheers, >> > >> > Stefano >> > >> > >> > On Tue, 18 Oct 2022, Vipul Suneja wrote: >> > > Hi Stefano, >> > > >> > > Thanks for the response! >> > > >> > > I could install tigerVNC, x11vnc & libvncserver in Dom0 >> xen-image-minimal but only manage to install libvncserver(couldn't >> > install tigervnc >> > > & x11vnc because of x11 >> > > support missing, it's wayland) in DOMU custom graphical image. >> I tried running vncviewer with IP address & port in dom0 to >> > access the domu >> > > graphical image display as per below commands. >> > > >> > > vncviewer 192.168.1.42:5901 >> > > >> > > But it showing can't open display, below are the logs: >> > > >> > > root@raspberrypi4-64:~/guest1# vncviewer 192.168.1.42:5901 >> > > >> > > TigerVNC Viewer 64-bit v1.11.0 >> > > Built on: 2020-09-08 12:16 >> > > Copyright (C) 1999-2020 TigerVNC Team and many others (see >> README.rst) >> > > See https://www.tigervnc.org for information on TigerVNC. >> > > Can't open display: >> > > root@raspberrypi4-64:~/guest1# >> > > >> > > I am not exactly sure what the issue is but I thought only >> libvncserver in DOMU could work to get access but it did not >> > work. >> > > If TigerVNC is the issue here then is there any other VNC >> source which could be installed for both x11 & wayland supported >> > images? >> > > >> > > Regards, >> > > Vipul Kumar >> > > >> > > On Tue, Oct 18, 2022 at 2:40 AM Stefano Stabellini < >> sstabellini@kernel.org> wrote: >> > > VNC is typically easier to setup, because SDL needs extra >> libraries at >> > > build time and runtime. If QEMU is built without SDL >> support it won't >> > > start when you ask for SDL. >> > > >> > > VNC should work with both x11 and wayland in your domU. >> It doesn't work >> > > at the x11 level, it exposes a special fbdev device in >> your domU that >> > > should work with: >> > > - a graphical console in Linux domU >> > > - x11 >> > > - wayland (but I haven't tested this so I am not 100% >> sure about it) >> > > >> > > When you say "it doesn't work", what do you mean? Do you >> get a black >> > > window? >> > > >> > > You need CONFIG_XEN_FBDEV_FRONTEND in Linux domU >> > > (drivers/video/fbdev/xen-fbfront.c). I would try to get a >> graphical text >> > > console up and running in your domU before attempting >> x11/wayland. >> > > >> > > Cheers, >> > > >> > > Stefano >> > > >> > > On Mon, 17 Oct 2022, Vipul Suneja wrote: >> > > > Hi, >> > > > Thanks! >> > > > >> > > > I have ported xen minimal image as DOM0 & custom >> wayland GUI based image as DOMU in raspberry pi4B. I am trying to >> > make GUI >> > > display up >> > > > for guest machine. I tried using sdl, included below >> line in guest.conf file >> > > > vfb= [ 'sdl=1' ] >> > > > >> > > > But it is throwing below error: >> > > > >> > > > root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg >> > > > Parsing config from guest1.cfg >> > > > libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: >> Domain 3:error on QMP socket: Connection reset by peer >> > > > libxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback: >> Domain 3:Error happened with the QMP connection to QEMU >> > > > libxl: error: >> libxl_dm.c:3351:device_model_postconfig_done: Domain 3:Post DM startup >> configs failed, rc=-26 >> > > > libxl: error: >> libxl_create.c:1867:domcreate_devmodel_started: Domain 3:device model did >> not start: -26 >> > > > libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: >> Device Model already exited >> > > > libxl: error: libxl_domain.c:1183:libxl__destroy_domid: >> Domain 3:Non-existant domain >> > > > libxl: error: >> libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to destroy >> guest >> > > > libxl: error: libxl_domain.c:1064:domain_destroy_cb: >> Domain 3:Destruction of domain failed >> > > > >> > > > Another way is VNC, i could install tigervnc in DOM0 >> but same i couldn't in guest machine because it doesn't support >> > > x11(supports wayland >> > > > only). I am completely blocked here, Need your support >> to enable the display up. >> > > > Any alternative of VNC which could work in both x11 & >> wayland supported images? >> > > > >> > > > Any input on VNC, SDL or any other way to proceed on >> this? Looking forward to hearing from you. >> > > > >> > > > Regards, >> > > > Vipul Kumar >> > > >> > > >> > > >> > >> > >> > > > --00000000000038e94005ecdede34 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Stefano,

Thanks!

Any input further on "xenstore-ls" logs?

I am trying to run the x0vncserver & x11vnc server manually on g= uest machine(xen_guest_image_minimal) image but it's failing with the b= elow error.

root@raspberrypi4-64:/usr/bin# x0vn= cserver
x0vncserver: unable to open display ""
root@raspber= rypi4-64:/usr/bin#
root@raspberrypi4-64:/usr/bin# x11vnc
###########= ####################################################
#@@@@@@@@@@@@@@@@@@= @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@#
#@ =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0** =C2=A0WARNING =C2=A0** = =C2=A0WARNING =C2=A0** =C2=A0WARNING =C2=A0** =C2=A0WARNING =C2=A0** =C2=A0= @#
#@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#@= =C2=A0 =C2=A0 =C2=A0 =C2=A0YOU ARE RUNNING X11VNC WITHOUT A PASSWORD!! =C2= =A0 =C2=A0 =C2=A0 =C2=A0@#
#@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 @#
#@ =C2=A0This means anyone with network access to this = computer =C2=A0 @#
#@ =C2=A0may be able to view and control your desktop= . =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0@#
#@ =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#@ >>> If you did not mea= n to do this Press CTRL-C now!! <<< @#
#@ =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@= @@@@@@@@@@@@@@@@@@@@@@@@@@@@#
#@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 @#
#@ =C2=A0You can create an x11vnc password file by = running: =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0 =C2=A0 =C2=A0 x11vnc -storepasswd pass= word /path/to/passfile =C2=A0 =C2=A0 =C2=A0@#
#@ =C2=A0or =C2=A0 x11vnc = -storepasswd /path/to/passfile =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 @#
#@ =C2=A0or =C2=A0 x11vnc -storepasswd =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 @#
#@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 @#
#@ =C2=A0(the last one will use ~/.vnc/passwd) =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0@#
#@ =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0and then start= ing x11vnc via: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0@#
#@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0 =C2=A0 =C2=A0x11vnc -rfbauth /p= ath/to/passfile =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0@#
#@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @= #
#@ =C2=A0an existing ~/.vnc/passwd file from another VNC =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0@#
#@ =C2=A0application will work fine too. =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0@#
#@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @= #
#@ =C2=A0You can also use the -passwdfile or -passwd options. =C2=A0 = =C2=A0 @#
#@ =C2=A0(note -passwd is unsafe if local users are not truste= d) =C2=A0@#
#@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @= #
#@ =C2=A0Make sure any -rfbauth and -passwdfile password files =C2=A0 = =C2=A0@#
#@ =C2=A0cannot be read by untrusted users. =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0Use x11vnc = -usepw to automatically use your =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0@#
#@ =C2=A0~/.vnc/passwd or ~/.vnc/passwdfile password files. =C2= =A0 =C2=A0 =C2=A0 @#
#@ =C2=A0(and prompt you to create ~/.vnc/passwd if= neither =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0file exists.) =C2=A0Under -use= pw, x11vnc will exit if it =C2=A0 =C2=A0 =C2=A0@#
#@ =C2=A0cannot find a= password to use. =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 @#
#@ =C2=A0Even with a password, the subsequent VNC traff= ic is =C2=A0 =C2=A0 =C2=A0@#
#@ =C2=A0sent in the clear.=C2=A0 Consider = tunnelling via ssh(1): =C2=A0 =C2=A0 =C2=A0@#
#@ =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0 =C2=A0http://www.karlrunge.com/x11vnc/#tunn= elling =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0@#
#@ =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0Or using the x11vn= c SSL options: -ssl and -stunnel =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0Please Read th= e documentation for more info about =C2=A0 =C2=A0 =C2=A0 =C2=A0@#
#@ =C2= =A0passwords, security, and encryption. =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0 =C2=A0http://www.karlrunge.com/x11vnc/faq.htm= l#faq-passwd =C2=A0 =C2=A0@#
#@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 @#
#@ =C2=A0To disable this warning use the -nopw o= ption, or put =C2=A0 =C2=A0 @#
#@ =C2=A0'nopw' on a line in your= ~/.x11vncrc file. =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#= @ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
#@@@@@@@@@@@@= @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@#
#####################= ##########################################
09/03/2018 12:58:41 x11vnc ve= rsion: 0.9.16 lastmod: 2019-01-05 =C2=A0pid: 424
09/03/2018 12:58:41 XOp= enDisplay("") failed.
09/03/2018 12:58:41 Trying again with XA= UTHLOCALHOSTNAME=3Dlocalhost ...
09/03/2018 12:58:41
09/03/2018 12:5= 8:41 *** XOpenDisplay failed. No -display or DISPLAY.
09/03/2018 12:58:4= 1 *** Trying ":0" in 4 seconds.=C2=A0 Press Ctrl-C to abort.
0= 9/03/2018 12:58:41 *** 1 2 3 4
09/03/2018 12:58:45 XOpenDisplay(":= 0") failed.
09/03/2018 12:58:45 Trying again with XAUTHLOCALHOSTNAM= E=3Dlocalhost ...
09/03/2018 12:58:45 XOpenDisplay(":0") faile= d.
09/03/2018 12:58:45 Trying again with unset XAUTHLOCALHOSTNAME ...09/03/2018 12:58:45

09/03/2018 12:58:45 **************************= *************
09/03/2018 12:58:45 *** XOpenDisplay failed (:0)

**= * x11vnc was unable to open the X DISPLAY: ":0", it cannot contin= ue.
*** There may be "Xlib:" error messages above with details= about the failure.

Some tips and guidelines:

** An X server = (the one you wish to view) must be running before x11vnc is
=C2=A0 =C2= =A0started: x11vnc does not start the X server. =C2=A0(however, see the -cr= eate
=C2=A0 =C2=A0option if that is what you really want).

** You= must use -display <disp>, -OR- set and export your $DISPLAY
=C2= =A0 =C2=A0environment variable to refer to the display of the desired X ser= ver.
=C2=A0- Usually the display is simply ":0" (in fact x11vn= c uses this if you forget
=C2=A0 =C2=A0to specify it), but in some multi= -user situations it could be ":1", ":2",
=C2=A0 =C2= =A0or even ":137".=C2=A0 Ask your administrator or a guru if you = are having
=C2=A0 =C2=A0difficulty determining what your X DISPLAY is.
** Next, you need to have sufficient permissions (Xauthority)
=C2= =A0 =C2=A0to connect to the X DISPLAY. =C2=A0 Here are some Tips:

= =C2=A0- Often, you just need to run x11vnc as the user logged into the X se= ssion.
=C2=A0 =C2=A0So make sure to be that user when you type x11vnc.=C2=A0- Being root is usually not enough because the incorrect MIT-MAGIC-= COOKIE
=C2=A0 =C2=A0file may be accessed.=C2=A0 The cookie file contains= the secret key that
=C2=A0 =C2=A0allows x11vnc to connect to the desire= d X DISPLAY.
=C2=A0- You can explicitly indicate which MIT-MAGIC-COOKIE = file should be used
=C2=A0 =C2=A0by the -auth option, e.g.:
=C2=A0 = =C2=A0 =C2=A0 =C2=A0x11vnc -auth /home/someuser/.Xauthority -display :0
= =C2=A0 =C2=A0 =C2=A0 =C2=A0x11vnc -auth /tmp/.gdmzndVlR -display :0
=C2= =A0 =C2=A0you must have read permission for the auth file.
=C2=A0 =C2=A0= See also '-auth guess' and '-findauth' discussed below.
=
** If NO ONE is logged into an X session yet, but there is a greeter lo= gin
=C2=A0 =C2=A0program like "gdm", "kdm", "xd= m", or "dtlogin" running, you will need
=C2=A0 =C2=A0to f= ind and use the raw display manager MIT-MAGIC-COOKIE file.
=C2=A0 =C2=A0= Some examples for various display managers:

=C2=A0 =C2=A0 =C2=A0gdm:= =C2=A0 =C2=A0 -auth /var/gdm/:0.Xauth
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 -auth /var/lib/gdm/:0.Xauth
=C2=A0 =C2=A0 =C2=A0kdm: = =C2=A0 =C2=A0 -auth /var/lib/kdm/A:0-crWk72
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 -auth /var/run/xauth/A:0-crWk72
=C2=A0 =C2=A0 =C2= =A0xdm: =C2=A0 =C2=A0 -auth /var/lib/xdm/authdir/authfiles/A:0-XQvaJk
= =C2=A0 =C2=A0 =C2=A0dtlogin: -auth /var/dt/A:0-UgaaXa

=C2=A0 =C2=A0S= ometimes the command "ps wwwwaux | grep auth" can reveal the file= location.

=C2=A0 =C2=A0Starting with x11vnc 0.9.9 you can have it t= ry to guess by using:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 -auth guess

=C2=A0 =C2=A0(see also the x11vnc -findauth option.)=

=C2=A0 =C2=A0Only root will have read permission for the file, and = so x11vnc must be run
=C2=A0 =C2=A0as root (or copy it).=C2=A0 The rando= m characters in the filenames will of course
=C2=A0 =C2=A0change and the= directory the cookie file resides in is system dependent.

See also:= http://www.karlrunge.= com/x11vnc/faq.html

Regards,
Vipul Kumar

On Thu, Nov 3, 2022 at 10:27 PM Vipul Suneja <vsuneja63@gmail.com> wrote:
Hi Stef= ano,

Thanks!

I used xen-guest-i= mage-minimal(simple console based image) as a guest with fbcon & fbdev = enabled in kernel configurations but still the same error can't open th= e display.
below are the outcome of "xenstore-ls":

root@raspberrypi4-64:~/guest1# xenstore-ls
tool = =3D ""
=C2=A0xenstored =3D ""
local =3D "&qu= ot;
=C2=A0domain =3D ""
=C2=A0 0 =3D ""
=C2=A0= =C2=A0control =3D ""
=C2=A0 =C2=A0 feature-poweroff =3D "= ;1"
=C2=A0 =C2=A0 feature-reboot =3D "1"
=C2=A0 =C2=A0= domid =3D "0"
=C2=A0 =C2=A0name =3D "Domain-0"
= =C2=A0 =C2=A0device-model =3D ""
=C2=A0 =C2=A0 0 =3D "&qu= ot;
=C2=A0 =C2=A0 =C2=A0backends =3D ""
=C2=A0 =C2=A0 =C2= =A0 console =3D ""
=C2=A0 =C2=A0 =C2=A0 vkbd =3D ""<= br>=C2=A0 =C2=A0 =C2=A0 vfb =3D ""
=C2=A0 =C2=A0 =C2=A0 qnic = =3D ""
=C2=A0 =C2=A0 =C2=A0state =3D "running"
= =C2=A0 =C2=A0 1 =3D ""
=C2=A0 =C2=A0 =C2=A0backends =3D "= "
=C2=A0 =C2=A0 =C2=A0 console =3D ""
=C2=A0 =C2=A0 = =C2=A0 vkbd =3D ""
=C2=A0 =C2=A0 =C2=A0 vfb =3D ""=C2=A0 =C2=A0 =C2=A0 qnic =3D ""
=C2=A0 =C2=A0 =C2=A0state = =3D "running"
=C2=A0 =C2=A0backend =3D ""
=C2=A0 = =C2=A0 vbd =3D ""
=C2=A0 =C2=A0 =C2=A01 =3D ""
= =C2=A0 =C2=A0 =C2=A0 51712 =3D ""
=C2=A0 =C2=A0 =C2=A0 =C2=A0f= rontend =3D "/local/domain/1/device/vbd/51712"
=C2=A0 =C2=A0 = =C2=A0 =C2=A0params =3D "/home/root/guest2/xen-guest-image-minimal-ras= pberrypi4-64.ext3"
=C2=A0 =C2=A0 =C2=A0 =C2=A0script =3D "/etc= /xen/scripts/block"
=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-id =3D &quo= t;1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0 = =C2=A0 =C2=A0 =C2=A0removable =3D "0"
=C2=A0 =C2=A0 =C2=A0 =C2= =A0bootable =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0state =3D "= ;4"
=C2=A0 =C2=A0 =C2=A0 =C2=A0dev =3D "xvda"
=C2=A0 = =C2=A0 =C2=A0 =C2=A0type =3D "phy"
=C2=A0 =C2=A0 =C2=A0 =C2=A0= mode =3D "w"
=C2=A0 =C2=A0 =C2=A0 =C2=A0device-type =3D "= disk"
=C2=A0 =C2=A0 =C2=A0 =C2=A0discard-enable =3D "1"=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-max-indirect-segments =3D "256&qu= ot;
=C2=A0 =C2=A0 =C2=A0 =C2=A0multi-queue-max-queues =3D "4"<= br>=C2=A0 =C2=A0 =C2=A0 =C2=A0max-ring-page-order =3D "4"
=C2= =A0 =C2=A0 =C2=A0 =C2=A0node =3D "/dev/loop0"
=C2=A0 =C2=A0 = =C2=A0 =C2=A0physical-device =3D "7:0"
=C2=A0 =C2=A0 =C2=A0 = =C2=A0physical-device-path =3D "/dev/loop0"
=C2=A0 =C2=A0 =C2= =A0 =C2=A0hotplug-status =3D "connected"
=C2=A0 =C2=A0 =C2=A0 = =C2=A0feature-flush-cache =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0d= iscard-granularity =3D "4096"
=C2=A0 =C2=A0 =C2=A0 =C2=A0disca= rd-alignment =3D "0"
=C2=A0 =C2=A0 =C2=A0 =C2=A0discard-secure= =3D "0"
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-discard =3D "= 1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-barrier =3D "1"
= =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-persistent =3D "1"
=C2=A0 = =C2=A0 =C2=A0 =C2=A0sectors =3D "1794048"
=C2=A0 =C2=A0 =C2=A0= =C2=A0info =3D "0"
=C2=A0 =C2=A0 =C2=A0 =C2=A0sector-size =3D= "512"
=C2=A0 =C2=A0 =C2=A0 =C2=A0physical-sector-size =3D &qu= ot;512"
=C2=A0 =C2=A0 vfb =3D ""
=C2=A0 =C2=A0 =C2=A01= =3D ""
=C2=A0 =C2=A0 =C2=A0 0 =3D ""
=C2=A0 =C2= =A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/vfb/0"
= =C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
=C2=A0 =C2=A0 = =C2=A0 =C2=A0online =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0state = =3D "4"
=C2=A0 =C2=A0 =C2=A0 =C2=A0vnc =3D "1"
= =C2=A0 =C2=A0 =C2=A0 =C2=A0vnclisten =3D "127.0.0.1"
=C2=A0 = =C2=A0 =C2=A0 =C2=A0vncdisplay =3D "0"
=C2=A0 =C2=A0 =C2=A0 = =C2=A0vncunused =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0sdl =3D &qu= ot;0"
=C2=A0 =C2=A0 =C2=A0 =C2=A0opengl =3D "0"
=C2=A0= =C2=A0 =C2=A0 =C2=A0feature-resize =3D "1"
=C2=A0 =C2=A0 =C2= =A0 =C2=A0hotplug-status =3D "connected"
=C2=A0 =C2=A0 =C2=A0 = =C2=A0request-update =3D "1"
=C2=A0 =C2=A0 vkbd =3D "&quo= t;
=C2=A0 =C2=A0 =C2=A01 =3D ""
=C2=A0 =C2=A0 =C2=A0 0 =3D = ""
=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain= /1/device/vkbd/0"
=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-id =3D "= 1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0 = =C2=A0 =C2=A0 =C2=A0state =3D "4"
=C2=A0 =C2=A0 =C2=A0 =C2=A0f= eature-abs-pointer =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-= raw-pointer =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0hotplug-status = =3D "connected"
=C2=A0 =C2=A0 console =3D ""
=C2= =A0 =C2=A0 =C2=A01 =3D ""
=C2=A0 =C2=A0 =C2=A0 0 =3D "&qu= ot;
=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/consol= e"
=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
=C2= =A0 =C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0 =C2=A0 =C2=A0 = =C2=A0state =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0protocol =3D &q= uot;vt100"
=C2=A0 =C2=A0 vif =3D ""
=C2=A0 =C2=A0 =C2= =A01 =3D ""
=C2=A0 =C2=A0 =C2=A0 0 =3D ""
=C2=A0 = =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/vif/0"=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
=C2=A0 =C2=A0= =C2=A0 =C2=A0online =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0state = =3D "4"
=C2=A0 =C2=A0 =C2=A0 =C2=A0script =3D "/etc/xen/s= cripts/vif-bridge"
=C2=A0 =C2=A0 =C2=A0 =C2=A0mac =3D "e4:5f:0= 1:cd:7b:dd"
=C2=A0 =C2=A0 =C2=A0 =C2=A0bridge =3D "xenbr0"= ;
=C2=A0 =C2=A0 =C2=A0 =C2=A0handle =3D "0"
=C2=A0 =C2=A0 = =C2=A0 =C2=A0type =3D "vif"
=C2=A0 =C2=A0 =C2=A0 =C2=A0hotplug= -status =3D "connected"
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-sg = =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-gso-tcpv4 =3D "= ;1"
=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-gso-tcpv6 =3D "1"<= br>=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-ipv6-csum-offload =3D "1"=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-rx-copy =3D "1"
=C2=A0 = =C2=A0 =C2=A0 =C2=A0feature-xdp-headroom =3D "1"
=C2=A0 =C2=A0= =C2=A0 =C2=A0feature-rx-flip =3D "0"
=C2=A0 =C2=A0 =C2=A0 =C2= =A0feature-multicast-control =3D "1"
=C2=A0 =C2=A0 =C2=A0 =C2= =A0feature-dynamic-multicast-control =3D "1"
=C2=A0 =C2=A0 =C2= =A0 =C2=A0feature-split-event-channels =3D "1"
=C2=A0 =C2=A0 = =C2=A0 =C2=A0multi-queue-max-queues =3D "4"
=C2=A0 =C2=A0 =C2= =A0 =C2=A0feature-ctrl-ring =3D "1"
=C2=A0 1 =3D ""<= br>=C2=A0 =C2=A0vm =3D "/vm/d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f"=
=C2=A0 =C2=A0name =3D "guest2"
=C2=A0 =C2=A0cpu =3D "= "
=C2=A0 =C2=A0 0 =3D ""
=C2=A0 =C2=A0 =C2=A0availabil= ity =3D "online"
=C2=A0 =C2=A0 1 =3D ""
=C2=A0 = =C2=A0 =C2=A0availability =3D "online"
=C2=A0 =C2=A0memory =3D= ""
=C2=A0 =C2=A0 static-max =3D "2097152"
=C2=A0= =C2=A0 target =3D "2097152"
=C2=A0 =C2=A0 videoram =3D "= 0"
=C2=A0 =C2=A0device =3D ""
=C2=A0 =C2=A0 suspend = =3D ""
=C2=A0 =C2=A0 =C2=A0event-channel =3D ""
= =C2=A0 =C2=A0 vbd =3D ""
=C2=A0 =C2=A0 =C2=A051712 =3D "&= quot;
=C2=A0 =C2=A0 =C2=A0 backend =3D "/local/domain/0/backend/vbd= /1/51712"
=C2=A0 =C2=A0 =C2=A0 backend-id =3D "0"
=C2= =A0 =C2=A0 =C2=A0 state =3D "4"
=C2=A0 =C2=A0 =C2=A0 virtual-d= evice =3D "51712"
=C2=A0 =C2=A0 =C2=A0 device-type =3D "d= isk"
=C2=A0 =C2=A0 =C2=A0 multi-queue-num-queues =3D "2"<= br>=C2=A0 =C2=A0 =C2=A0 queue-0 =3D ""
=C2=A0 =C2=A0 =C2=A0 = =C2=A0ring-ref =3D "8"
=C2=A0 =C2=A0 =C2=A0 =C2=A0event-channe= l =3D "4"
=C2=A0 =C2=A0 =C2=A0 queue-1 =3D ""
=C2= =A0 =C2=A0 =C2=A0 =C2=A0ring-ref =3D "9"
=C2=A0 =C2=A0 =C2=A0 = =C2=A0event-channel =3D "5"
=C2=A0 =C2=A0 =C2=A0 protocol =3D = "arm-abi"
=C2=A0 =C2=A0 =C2=A0 feature-persistent =3D "1&= quot;
=C2=A0 =C2=A0 vfb =3D ""
=C2=A0 =C2=A0 =C2=A00 =3D &q= uot;"
=C2=A0 =C2=A0 =C2=A0 backend =3D "/local/domain/0/backen= d/vfb/1/0"
=C2=A0 =C2=A0 =C2=A0 backend-id =3D "0"
=C2= =A0 =C2=A0 =C2=A0 state =3D "4"
=C2=A0 =C2=A0 =C2=A0 page-ref = =3D "275022"
=C2=A0 =C2=A0 =C2=A0 event-channel =3D "3&qu= ot;
=C2=A0 =C2=A0 =C2=A0 protocol =3D "arm-abi"
=C2=A0 =C2= =A0 =C2=A0 feature-update =3D "1"
=C2=A0 =C2=A0 vkbd =3D "= ;"
=C2=A0 =C2=A0 =C2=A00 =3D ""
=C2=A0 =C2=A0 =C2=A0 b= ackend =3D "/local/domain/0/backend/vkbd/1/0"
=C2=A0 =C2=A0 = =C2=A0 backend-id =3D "0"
=C2=A0 =C2=A0 =C2=A0 state =3D "= ;4"
=C2=A0 =C2=A0 =C2=A0 request-abs-pointer =3D "1"
= =C2=A0 =C2=A0 =C2=A0 page-ref =3D "275322"
=C2=A0 =C2=A0 =C2= =A0 page-gref =3D "1284"
=C2=A0 =C2=A0 =C2=A0 event-channel = =3D "10"
=C2=A0 =C2=A0 vif =3D ""
=C2=A0 =C2=A0 = =C2=A00 =3D ""
=C2=A0 =C2=A0 =C2=A0 backend =3D "/local/d= omain/0/backend/vif/1/0"
=C2=A0 =C2=A0 =C2=A0 backend-id =3D "= 0"
=C2=A0 =C2=A0 =C2=A0 state =3D "4"
=C2=A0 =C2=A0 = =C2=A0 handle =3D "0"
=C2=A0 =C2=A0 =C2=A0 mac =3D "e4:5f= :01:cd:7b:dd"
=C2=A0 =C2=A0 =C2=A0 mtu =3D "1500"
=C2= =A0 =C2=A0 =C2=A0 xdp-headroom =3D "0"
=C2=A0 =C2=A0 =C2=A0 mu= lti-queue-num-queues =3D "2"
=C2=A0 =C2=A0 =C2=A0 queue-0 =3D = ""
=C2=A0 =C2=A0 =C2=A0 =C2=A0tx-ring-ref =3D "1280"=
=C2=A0 =C2=A0 =C2=A0 =C2=A0rx-ring-ref =3D "1281"
=C2=A0 = =C2=A0 =C2=A0 =C2=A0event-channel-tx =3D "6"
=C2=A0 =C2=A0 =C2= =A0 =C2=A0event-channel-rx =3D "7"
=C2=A0 =C2=A0 =C2=A0 queue-= 1 =3D ""
=C2=A0 =C2=A0 =C2=A0 =C2=A0tx-ring-ref =3D "1282= "
=C2=A0 =C2=A0 =C2=A0 =C2=A0rx-ring-ref =3D "1283"
= =C2=A0 =C2=A0 =C2=A0 =C2=A0event-channel-tx =3D "8"
=C2=A0 =C2= =A0 =C2=A0 =C2=A0event-channel-rx =3D "9"
=C2=A0 =C2=A0 =C2=A0= request-rx-copy =3D "1"
=C2=A0 =C2=A0 =C2=A0 feature-rx-notif= y =3D "1"
=C2=A0 =C2=A0 =C2=A0 feature-sg =3D "1"=C2=A0 =C2=A0 =C2=A0 feature-gso-tcpv4 =3D "1"
=C2=A0 =C2=A0 = =C2=A0 feature-gso-tcpv6 =3D "1"
=C2=A0 =C2=A0 =C2=A0 feature-= ipv6-csum-offload =3D "1"
=C2=A0 =C2=A0control =3D ""= ;
=C2=A0 =C2=A0 shutdown =3D ""
=C2=A0 =C2=A0 feature-power= off =3D "1"
=C2=A0 =C2=A0 feature-reboot =3D "1"
= =C2=A0 =C2=A0 feature-suspend =3D ""
=C2=A0 =C2=A0 sysrq =3D &= quot;"
=C2=A0 =C2=A0 platform-feature-multiprocessor-suspend =3D &q= uot;1"
=C2=A0 =C2=A0 platform-feature-xs_reset_watches =3D "1&= quot;
=C2=A0 =C2=A0data =3D ""
=C2=A0 =C2=A0drivers =3D &qu= ot;"
=C2=A0 =C2=A0feature =3D ""
=C2=A0 =C2=A0attr =3D= ""
=C2=A0 =C2=A0error =3D ""
=C2=A0 =C2=A0domid = =3D "1"
=C2=A0 =C2=A0store =3D ""
=C2=A0 =C2=A0 p= ort =3D "1"
=C2=A0 =C2=A0 ring-ref =3D "233473"
= =C2=A0 =C2=A0console =3D ""
=C2=A0 =C2=A0 backend =3D "/l= ocal/domain/0/backend/console/1/0"
=C2=A0 =C2=A0 backend-id =3D &qu= ot;0"
=C2=A0 =C2=A0 limit =3D "1048576"
=C2=A0 =C2=A0 = type =3D "xenconsoled"
=C2=A0 =C2=A0 output =3D "pty"= ;
=C2=A0 =C2=A0 tty =3D "/dev/pts/1"
=C2=A0 =C2=A0 port =3D= "2"
=C2=A0 =C2=A0 ring-ref =3D "233472"
=C2=A0 = =C2=A0 vnc-listen =3D "127.0.0.1"
=C2=A0 =C2=A0 vnc-port =3D &= quot;5900"
=C2=A0 =C2=A0image =3D ""
=C2=A0 =C2=A0 dev= ice-model-pid =3D "788"
vm =3D ""
=C2=A0d81ec5a9-= 5bf9-4f2b-89e8-0f60d6da948f =3D ""
=C2=A0 name =3D "guest= 2"
=C2=A0 uuid =3D "d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f"=
=C2=A0 start_time =3D "1520600274.27"
libxl =3D "&quo= t;
=C2=A01 =3D ""
=C2=A0 device =3D ""
=C2=A0 = =C2=A0vbd =3D ""
=C2=A0 =C2=A0 51712 =3D ""
=C2= =A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/vbd/51712"<= br>=C2=A0 =C2=A0 =C2=A0backend =3D "/local/domain/0/backend/vbd/1/5171= 2"
=C2=A0 =C2=A0 =C2=A0params =3D "/home/root/guest2/xen-guest= -image-minimal-raspberrypi4-64.ext3"
=C2=A0 =C2=A0 =C2=A0script =3D= "/etc/xen/scripts/block"
=C2=A0 =C2=A0 =C2=A0frontend-id =3D = "1"
=C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0 =C2= =A0 =C2=A0removable =3D "0"
=C2=A0 =C2=A0 =C2=A0bootable =3D &= quot;1"
=C2=A0 =C2=A0 =C2=A0state =3D "1"
=C2=A0 =C2= =A0 =C2=A0dev =3D "xvda"
=C2=A0 =C2=A0 =C2=A0type =3D "ph= y"
=C2=A0 =C2=A0 =C2=A0mode =3D "w"
=C2=A0 =C2=A0 =C2= =A0device-type =3D "disk"
=C2=A0 =C2=A0 =C2=A0discard-enable = =3D "1"
=C2=A0 =C2=A0vfb =3D ""
=C2=A0 =C2=A0 0 = =3D ""
=C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/= device/vfb/0"
=C2=A0 =C2=A0 =C2=A0backend =3D "/local/domain/0= /backend/vfb/1/0"
=C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"=
=C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0 =C2=A0 =C2=A0sta= te =3D "1"
=C2=A0 =C2=A0 =C2=A0vnc =3D "1"
=C2=A0= =C2=A0 =C2=A0vnclisten =3D "127.0.0.1"
=C2=A0 =C2=A0 =C2=A0vn= cdisplay =3D "0"
=C2=A0 =C2=A0 =C2=A0vncunused =3D "1&quo= t;
=C2=A0 =C2=A0 =C2=A0sdl =3D "0"
=C2=A0 =C2=A0 =C2=A0open= gl =3D "0"
=C2=A0 =C2=A0vkbd =3D ""
=C2=A0 =C2=A0= 0 =3D ""
=C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain= /1/device/vkbd/0"
=C2=A0 =C2=A0 =C2=A0backend =3D "/local/doma= in/0/backend/vkbd/1/0"
=C2=A0 =C2=A0 =C2=A0frontend-id =3D "1&= quot;
=C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0 =C2=A0 =C2= =A0state =3D "1"
=C2=A0 =C2=A0console =3D ""
=C2= =A0 =C2=A0 0 =3D ""
=C2=A0 =C2=A0 =C2=A0frontend =3D "/lo= cal/domain/1/console"
=C2=A0 =C2=A0 =C2=A0backend =3D "/local/= domain/0/backend/console/1/0"
=C2=A0 =C2=A0 =C2=A0frontend-id =3D &= quot;1"
=C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0 =C2= =A0 =C2=A0state =3D "1"
=C2=A0 =C2=A0 =C2=A0protocol =3D "= ;vt100"
=C2=A0 =C2=A0vif =3D ""
=C2=A0 =C2=A0 0 =3D &q= uot;"
=C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device= /vif/0"
=C2=A0 =C2=A0 =C2=A0backend =3D "/local/domain/0/backe= nd/vif/1/0"
=C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
= =C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0 =C2=A0 =C2=A0state = =3D "1"
=C2=A0 =C2=A0 =C2=A0script =3D "/etc/xen/scripts/= vif-bridge"
=C2=A0 =C2=A0 =C2=A0mac =3D "e4:5f:01:cd:7b:dd&quo= t;
=C2=A0 =C2=A0 =C2=A0bridge =3D "xenbr0"
=C2=A0 =C2=A0 = =C2=A0handle =3D "0"
=C2=A0 =C2=A0 =C2=A0type =3D "vif&qu= ot;
=C2=A0 =C2=A0 =C2=A0hotplug-status =3D ""
=C2=A0 type = =3D "pvh"
=C2=A0 dm-version =3D "qemu_xen"
root@r= aspberrypi4-64:~/guest1#

Any input as per = above? Looking forward to hearing from you.

Regard= s,
Vipul Kumar

On Wed, Oct 26, 2022 at 5:21 AM Stefano Stabe= llini <sstab= ellini@kernel.org> wrote:
Hi Vipul,

If you look at the QEMU logs, it says:

VNC server running on 127.0.0.1:5900

That is the VNC server you need to connect to. So in theory:

=C2=A0 vncviewer 127.0.0.1:5900

should work correctly.


If you have:

=C2=A0 vfb =3D ["type=3Dvnc"]

in your xl config file and you have "fbdev" in your Linux guest, = it
should work.

If you connect to the VNC server but you get a black screen, it might be a guest configuration issue. I would try with a simpler guest, text only (no X11, no Wayland) and enable the fbdev console (fbcon). See
Documentation/fb/fbcon.rst in Linux. You should be able to see a
graphical console over VNC.

If that works, then you know that the fbdev kernel driver (xen-fbfront)
works correctly.

If it doesn't work, the output of "xenstore-ls" would be inte= resting.

Cheers,

Stefano


On Wed, 19 Oct 2022, Vipul Suneja wrote:
> Hi Stefano,
>
> Thanks for the response!
>
> I am following the same link you shared from the beginning. Tried the = command "vncviewer localhost:0" in DOM0 but same issue "Can&= #39;t open
> display", below are the logs:
>
> root@raspberrypi4-64:~# vncviewer localhost:0
>
> TigerVNC Viewer 64-bit v1.11.0
> Built on: 2020-09-08 12:16
> Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst)=
> See https://www.tigervnc.org for information on TigerVNC.
> Can't open display:
>
> Below are the netstat logs, i couldn't see anything running at por= t 5900 or 5901:
>
> root@raspberrypi4-64:~# netstat -tuwx
> Active Internet connections (w/o servers)
> Proto Recv-Q Send-Q Local Address =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 F= oreign Address =C2=A0 =C2=A0 =C2=A0 =C2=A0 State =C2=A0 =C2=A0 =C2=A0
> tcp =C2=A0 =C2=A0 =C2=A0 =C2=A00 =C2=A0 =C2=A0164 192.168.1.39:ssh =C2= =A0 =C2=A0 =C2=A0 =C2=A0192.168.1.38:37472 =C2=A0 =C2=A0 =C2=A0ESTABLIS= HED
> Active UNIX domain sockets (w/o servers)
> Proto RefCnt Flags =C2=A0 =C2=A0 =C2=A0 Type =C2=A0 =C2=A0 =C2=A0 Stat= e =C2=A0 =C2=A0 =C2=A0 =C2=A0 I-Node Path
> unix =C2=A08 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A010565 /dev/log
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010891 /var/run/xenstored/sock= et
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013791
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010843 /var/run/xenstored/sock= et
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010573 /var/run/xenstored/sock= et
> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A014510
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013249
> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A013887
> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A010599
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A014005
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013258
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013248
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A014003
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010572 /var/run/xenstored/sock= et
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010786 /var/run/xenstored/sock= et
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A013186
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010864 /var/run/xenstored/sock= et
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010812 /var/run/xenstored/sock= et
> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A014083
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010813 /var/run/xenstored/sock= et
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A014068
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013256
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010571 /var/run/xenstored/sock= et
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010842
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013985
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A013185
> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013884
> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A014528
> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM= =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A013785
> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREA= M =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A014034
>
> Attaching xen log files of /var/log/xen.
> I didn't get the role of QEMU here because as mentioned earlier, I= am porting in raspberrypi 4B.
>
> Regards,
> Vipul Kumar
>
> On Wed, Oct 19, 2022 at 12:43 AM Stefano Stabellini <sstabellini@kernel.org>= ; wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0It usually works the way it is described in = the guide:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0https://www.virtu= atopia.com/index.php?title=3DConfiguring_a_VNC_based_Graphical_Console_for_= a_Xen_Paravirtualized_domainU_Guest
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0You don't need to install any VNC-relate= d server software because it is
>=C2=A0 =C2=A0 =C2=A0 =C2=A0already provided by Xen (to be precise it is= provided by QEMU working
>=C2=A0 =C2=A0 =C2=A0 =C2=A0together with Xen.)
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0You only need the vnc client in dom0 so that= you can connect, but you
>=C2=A0 =C2=A0 =C2=A0 =C2=A0could also run the vnc client outside from a= nother host. So basically
>=C2=A0 =C2=A0 =C2=A0 =C2=A0the following should work when executed in D= om0 after creating DomU:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 vncviewer localhost:0
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Can you attach the Xen and QEMU logs (/var/l= og/xen/*)? And also use
>=C2=A0 =C2=A0 =C2=A0 =C2=A0netstat -taunp to check if there is anything= running at port 5900 or
>=C2=A0 =C2=A0 =C2=A0 =C2=A05901?
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Cheers,
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Stefano
>
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0On Tue, 18 Oct 2022, Vipul Suneja wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Hi Stefano,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Thanks for the response!
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> I could install tigerVNC, x11vnc & = libvncserver in Dom0 xen-image-minimal but only manage to install libvncser= ver(couldn't
>=C2=A0 =C2=A0 =C2=A0 =C2=A0install tigervnc
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> & x11vnc because of x11
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> support missing, it's wayland) in D= OMU custom graphical image. I tried running vncviewer with IP address &= port in dom0 to
>=C2=A0 =C2=A0 =C2=A0 =C2=A0access the domu
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> graphical image display as per below co= mmands.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0vncviewer 192.168.1.42:5901 >=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0But it showing can't open dis= play, below are the logs:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> root@raspberrypi4-64:~/guest1# vncviewe= r 192.168.1.42:5901
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> TigerVNC Viewer 64-bit v1.11.0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Built on: 2020-09-08 12:16
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Copyright (C) 1999-2020 TigerVNC Team a= nd many others (see README.rst)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> See https://www.tigervnc.org for inf= ormation on TigerVNC.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Can't open display:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> root@raspberrypi4-64:~/guest1#
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> I am not exactly=C2=A0sure what the iss= ue is but I thought only libvncserver in DOMU could work to get access but = it did not
>=C2=A0 =C2=A0 =C2=A0 =C2=A0work.=C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> If TigerVNC is the issue here then is t= here any other VNC source which could be installed for both x11 & wayla= nd supported
>=C2=A0 =C2=A0 =C2=A0 =C2=A0images?
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Regards,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Vipul Kumar
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> On Tue, Oct 18, 2022 at 2:40 AM Stefano= Stabellini <sstabellini@kernel.org> wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0VNC is typica= lly easier to setup, because SDL needs extra libraries at
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0build time an= d runtime. If QEMU is built without SDL support it won't
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0start when yo= u ask for SDL.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0VNC should wo= rk with both x11 and wayland in your domU. It doesn't work
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0at the x11 le= vel, it exposes a special fbdev device in your domU that
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0should work w= ith:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0- a graphical= console in Linux domU
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0- x11
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0- wayland (bu= t I haven't tested this so I am not 100% sure about it)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0When you say = "it doesn't work", what do you mean? Do you get a black
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0window?
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0You need CONF= IG_XEN_FBDEV_FRONTEND in Linux domU
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0(drivers/vide= o/fbdev/xen-fbfront.c). I would try to get a graphical text
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0console up an= d running in your domU before attempting x11/wayland.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0Cheers,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0Stefano
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0On Mon, 17 Oc= t 2022, Vipul Suneja wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Hi,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Thanks!<= br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> I have p= orted xen minimal image as DOM0 & custom wayland GUI based image as DOM= U in raspberry pi4B. I am trying to
>=C2=A0 =C2=A0 =C2=A0 =C2=A0make GUI
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0display up >=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> for=C2= =A0guest machine. I tried using=C2=A0sdl, included below line in guest.conf= file
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> vfb=3D [= 'sdl=3D1' ]
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> But it i= s throwing below error:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> root@ras= pberrypi4-64:~/guest1# xl create -c guest1.cfg
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Parsing = config from guest1.cfg
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain 3:error on QMP socket: Co= nnection reset by peer
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the= QMP connection to QEMU
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_dm.c:3351:device_model_postconfig_done: Domain 3:Post DM startu= p configs failed, rc=3D-26
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_create.c:1867:domcreate_devmodel_started: Domain 3:device model= did not start: -26
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_aoutils.c:646:libxl__kill_xs_path: Device Model already exited<= br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_domain.c:1183:libxl__destroy_domid: Domain 3:Non-existant domai= n
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to destr= oy guest
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> libxl: e= rror: libxl_domain.c:1064:domain_destroy_cb: Domain 3:Destruction of domain= failed
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Another = way is VNC, i could install tigervnc in DOM0 but same i couldn't in gue= st machine because it doesn't support
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0x11(supports = wayland
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> only). I= am completely blocked here, Need your support to enable the display up. >=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Any alte= rnative of VNC which could work in both x11 & wayland supported images?=
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Any inpu= t on VNC, SDL or any other way to proceed on this? Looking forward to heari= ng from you.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Regards,=
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Vipul Ku= mar
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>
>
>
--00000000000038e94005ecdede34-- From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:30:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:30:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439241.693264 (Exim 4.92) (envelope-from ) id 1orzOp-0006HP-1d; Mon, 07 Nov 2022 10:30:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439241.693264; Mon, 07 Nov 2022 10:30:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzOo-0006HI-Uf; Mon, 07 Nov 2022 10:30:38 +0000 Received: by outflank-mailman (input) for mailman id 439241; Mon, 07 Nov 2022 10:30:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzOn-0006HC-CV for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 10:30:37 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130077.outbound.protection.outlook.com [40.107.13.77]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 367f4ca0-5e87-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 11:30:34 +0100 (CET) Received: from AS9PR06CA0249.eurprd06.prod.outlook.com (2603:10a6:20b:45f::22) by AS8PR08MB7815.eurprd08.prod.outlook.com (2603:10a6:20b:529::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 10:30:32 +0000 Received: from AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45f:cafe::a8) by AS9PR06CA0249.outlook.office365.com (2603:10a6:20b:45f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26 via Frontend Transport; Mon, 7 Nov 2022 10:30:32 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT059.mail.protection.outlook.com (100.127.140.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 10:30:32 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Mon, 07 Nov 2022 10:30:31 +0000 Received: from 2ac3d14619d4.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2327B603-4108-4CFA-97A4-84D225BA167C.1; Mon, 07 Nov 2022 10:30:21 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2ac3d14619d4.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Nov 2022 10:30:21 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB8PR08MB5500.eurprd08.prod.outlook.com (2603:10a6:10:11e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 10:30:18 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5813.011; Mon, 7 Nov 2022 10:30:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 367f4ca0-5e87-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=O1OV801M/6SEY9UfaJrrqAdJK7aYwgZKqBvYJB6actfRz0b5U3nT0PgVShmIAFJB8TY4x5od94LB2XcjjfI+D7QGHbh3Rjm7FkwhHlPKHB0fmwGr9MWqXLpaptwjuG7LEPQS8VKRQRrYDSc+QqgkTpYRV5OzrOztXioY1JG6VOxD+l8X1cjG6xqgdxhVa9ZrFOJKRjgkz/9WfD/rB2xPzp7iwy0/1YW9axbgI42y2VLj3iIDRKNn4tvFyL8fW2YWbb+6W710YnI0TeWFYJQdXZROeVeSmsNdXkYJD4GQe0llbzJ9qjDjcOcBJMv8ACaQFB3ucdjawmCOfvd2Ud2tpg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xMXT2ZVQw2wA5iL09XanV5OpL9jUtQZtDIehowkp1dk=; b=DZyPAevuzQwuHpqGi19vV/kNJwiYDXvvv8dM6G68owsJDM/JxPQsLWY1kOV1m5qqWEXNXjIK7MYHImKPtWiWMafm+djR8hooacgyhC5RCSOS9ucLesitAOmTKPCSbxo9INsgJwc0YBbmi6jHvWtcDbgCY9fA0qq4CeexkQhz9b84FxRtX0ySYMChGuXiZHIgqPwn03veTmWx37R5cYlleBW81YL0RfU+ew1f8cdcPHz7lrb4IMAL9tjZjLIrYyG2WcNIS7StYJCHedMtiEKUP1Mcsd7gcbnZJy83jDzMg/5r8PkcaqPapg7oQLF8gHUdOdahOp8/Q9ePuqDwhkWjFA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xMXT2ZVQw2wA5iL09XanV5OpL9jUtQZtDIehowkp1dk=; b=hJbRe4WIvTP5RL14tfEFb8dyAdzhn61enUv9/AD5GIfa59M+BHFKDXuH+0q6QqPnX6qz7fsjrJwfRYvIupVbTgdU2I+e2iqyBXorE7rj217FZ0nppNLs9aSw5bsN7Yb61/5zXAcIaqmipupIs8nC2aC1axNV+bg+/2sfXrPBA+g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ucb9S2QzvMHdOa0nTJovUYf6DpbBfH+U8o+e2z6r1IbStHXg7TRf0QKlgwLwOSAA9/jz8m/wZI+ZCLxU03Ydv6m95KyDV6mukAVfKGq1vWp0gKOt2gYe20AjpKGB3N5vQTWsruFonGFVZxR5oJ//fy3tP0TbTv5i/OhB115r2hCee5pxIfF5NXbpyy+7wli4zEZxdY/dNv8Jk0vyL2PcB/+Q6n+1cRgFJQUJzF1Fwu64TgZbsEp9XCErHP/NwomewbBbFqkYlineKNl0DocNeLQQ0jpbSxvxCcBm8aQLYeEJoio6OgBbP6dzFe+cIii6oFiWZPo2swfqUReKUoYz4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xMXT2ZVQw2wA5iL09XanV5OpL9jUtQZtDIehowkp1dk=; b=DsqU4rBQ4R9oM3hv+0Vmi7FxtD47Aqwqp2s50hhrI/jhCa+pDlIgEtrv9yjYGGfLJ3hxqlfvZX21k6O7+wLlXDUHmpkyJcP46x49GlO1EAsoavpAiUCujg7trjK+UnZrQgkVAZ4ck2B8eHjAssdiQzTfwHFrDiji/uSPZw4WnxbxJpeXiC9S7C/TMCF/YenaoKmUKQ2CSPW5/xYxEDG06wiKTK9i3LjYbRIW6oEfC6DvIUyPITE4dIW9kRgUaP3Z2X+wnNl5hNvV7puzXtCCEjyqQ4EqUAnjl80WrZTyWiuMdkfAAKROBnPVwAkQndw9sLj71ktERv93wdBB3SEGHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xMXT2ZVQw2wA5iL09XanV5OpL9jUtQZtDIehowkp1dk=; b=hJbRe4WIvTP5RL14tfEFb8dyAdzhn61enUv9/AD5GIfa59M+BHFKDXuH+0q6QqPnX6qz7fsjrJwfRYvIupVbTgdU2I+e2iqyBXorE7rj217FZ0nppNLs9aSw5bsN7Yb61/5zXAcIaqmipupIs8nC2aC1axNV+bg+/2sfXrPBA+g= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 Thread-Topic: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 Thread-Index: AQHY8DVcKFNDls96akm0LlhB1cf9B64yRBkAgADyKCCAAA1MAIAAAWqg Date: Mon, 7 Nov 2022 10:30:18 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <9c3bfa0c-2c8f-2160-46d1-3be234b5bcaf@xen.org> <88c909b5-4cad-aab0-2acd-fb3519963128@xen.org> In-Reply-To: <88c909b5-4cad-aab0-2acd-fb3519963128@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 054A1801B4950945805C8E40049A97F0.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|DB8PR08MB5500:EE_|AM7EUR03FT059:EE_|AS8PR08MB7815:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ada50e8-1093-4cf1-c505-08dac0ab1944 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PDdTgAMWQdHAMxfro9mThdjrCSAShp9EJoJZcah+eXUlLowunROY1ZcGyAyI42tE1MzH+kCtXcCp2z9uajiLAt/u1kFOLUsDrDL+FS02WAHjMs0VhH33jPFalPODZUn28uJiHv5Z4RimRrIm4qCiMyydbji98s1MLbeqXNXX+Nq+mA+smbG50ZA+OOaIeJK6qGspDpypIQMI0lQTfA224bFxDY3f6zpRmozqNeE039fIQP/+b8vbBCaNKPj4HEXgNFDko0fRwQ0W70eoV2Py3qUcLJ188Kpp99qH1qV1RtffQUvuIv1N/xTGFVjOll/iW207vBlxeNsJ8sNTPNvdeuAOMD02Se1DOg8nfmqLarvT0ehe81hPYV4M20kBuACkpVlnUAg1G59NW21l5/o2WUp5SZ0EPnmls8AYDhSQP4Ml1WqXm6u0adZeTXQzClTawa3dq3bP8b4odN0Bcl6FfYZ59qo5QHH8LUz06GqsAzZ3IwA70MzojZ2Ort9w9hAxQTHHWVF9hNMhlB3MBalH8b9d+gBFpnS36uShjZxE0uZR0tUUDjWyvOb3fSLFGQ6nZuSTwnlabRBYQPN+BZ0vcW1UTYnyfNqIFAEulVtDjer3McSl9lY10RBevWeBkIjsz7VHJ5wb14DIFet4zzE4CAxia9Yop/HHMbWG8W8whOezMDI/Xz7fUC6oLFv7bfS1JXOEeH6hajWIE2gBsGx+5LVUN2LrQ2EfJEg+O/jthG4AO7LITvBQYPwfeY6uYFXVsHDKnVnPTDL3kfbf8E4xXp1JB9NkdgWJZBYObFUihqFmPWF/gydyni8qJCyxkIku7itNawyP3iik3xEepCNN8Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(39860400002)(366004)(376002)(451199015)(38100700002)(66476007)(41300700001)(4326008)(66556008)(66446008)(8676002)(64756008)(66946007)(54906003)(110136005)(38070700005)(26005)(83380400001)(71200400001)(8936002)(55016003)(966005)(478600001)(316002)(33656002)(2906002)(52536014)(5660300002)(9686003)(186003)(76116006)(122000001)(53546011)(86362001)(7696005)(6506007)(17413003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5500 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 09bd3799-e309-48c0-28d6-08dac0ab10ed X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vtCtP+GVZykxmFR/vzW1YcAsIvYWAja4ofEKy9W2x2SYcYpzB+GyZthVqoV/Ps97Xa6+s43IaZFmFJIzqvT4EqWxbA1FN4Csh4j6q5HDQPxHYBcvN1WnWi0RBmMWFUQ/tvfiVTWeLOt2YbLRWmtfJ4uKzvbRstXzwbySNq3zCgZaWSrSIJwBHeEonCN+GHVP7ytIPTnQu5NAIGgJASVPgJoeLSCekMu5vO0KPpnLcPcjWp38PRBOK2JpHgBLhDrJwzLLqVSQNECuglueBqBV00LfbYvlZL+qcirMipoSPDDam722LewH/syX4nLsAj/xXuFS//54/Htem5DUL2Dxw0YQynK+NIarol3hRHgRbPCPp1VfYTmVOHZ1aPltIZsNYoECNVmUyYgIjzB3y2keAwZZIxAx9mXGrNzT88RKtovPd7oDi1uSn3V0XszM+iZbOjO7FWRIvwSGVebXy/mpzqduNw44tgsntD3/8OTFHRWIdVCPcufiVDfGG2PAAI5/xLjZWJ/m7q043ofH9cQUP26qTIkomWSKb5IwTaIid+i2augORECRrd1REIsQ2NPCQ7Airuy2K6Y4mJknWYaELlSYgas7VqVJJu2O91eeP1azDQXKlrvfOZDoYRYkgzd9059RAW2Bnw8o0KxuI9SfpGIbBZsU1W+6FhpSlbhKv4qADdpF+a5r6LoeVBBwHEbDrY9Uu01qWPJleve5mqgGPyJwj827kQum7ZlJ9dkscJq7Jw99Eq047RSIsISgBmqXr/45vYIvsidgYvdXkz2hoseC3kXuWGUFYLEQklX9tV6GTq8552CGh1BW9FjyVvbzgbPFrZTU8cXKN5oIHRYGag== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(346002)(396003)(451199015)(36840700001)(40470700004)(46966006)(8936002)(36860700001)(5660300002)(52536014)(2906002)(33656002)(55016003)(336012)(40480700001)(70586007)(70206006)(316002)(82310400005)(40460700003)(86362001)(186003)(82740400003)(478600001)(110136005)(966005)(356005)(81166007)(8676002)(41300700001)(4326008)(9686003)(47076005)(83380400001)(26005)(7696005)(6506007)(54906003)(53546011)(107886003)(17413003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 10:30:32.1755 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0ada50e8-1093-4cf1-c505-08dac0ab1944 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7815 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQxMeaciDfml6UgMTg6MTYN Cj4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnDQo+IENjOiBuZCA8bmRAYXJtLmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0 YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRyYW5kDQo+IE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1 aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVrDQo+IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFt LmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2NiAwMC8xMV0geGVuL2FybTogQWRkIEFybXY4 LVI2NCBNUFUgc3VwcG9ydCB0byBYZW4gLQ0KPiBQYXJ0IzENCj4gDQo+IA0KPiANCj4gT24gMDcv MTEvMjAyMiAwOTo1MiwgV2VpIENoZW4gd3JvdGU6DQo+ID4gSGkgSnVsaWVuLA0KPiANCj4gSGks DQo+IA0KPiA+DQo+ID4+PiAgICAtIFN1cHBvcnRzIG9ubHkgYSBzaW5nbGUgU2VjdXJpdHkgc3Rh dGUgLSBTZWN1cmUuDQo+ID4+PiAgICAtIE1QVSBpbiBFTDEgJiBFTDIgaXMgY29uZmlndXJhYmxl LCBNTVUgaW4gRUwxIGlzIGNvbmZpZ3VyYWJsZS4NCj4gPj4+DQo+ID4+PiBUaGVzZSBwYXRjaCBz ZXJpZXMgYXJlIGltcGxlbWVudGluZyB0aGUgQXJtdjgtUjY0IE1QVSBzdXBwb3J0DQo+ID4+PiBm b3IgWGVuLCB3aGljaCBhcmUgYmFzZWQgb24gdGhlIGRpc2N1c3Npb24gb2YNCj4gPj4+ICJQcm9w b3NhbCBmb3IgUG9ydGluZyBYZW4gdG8gQXJtdjgtUjY0IC0gRHJhZnRDIiBbMV0uDQo+ID4+Pg0K PiA+Pj4gV2Ugd2lsbCBpbXBsZW1lbnQgdGhlIEFybXY4LVI2NCBhbmQgTVBVIHN1cHBvcnQgaW4g dGhyZWUgc3RhZ2VzOg0KPiA+Pj4gMS4gQm9vdCBYZW4gaXRzZWxmIHRvIGlkbGUgdGhyZWFkLCBk byBub3QgY3JlYXRlIGFueSBndWVzdHMgb24gaXQuDQo+ID4+DQo+ID4+IEkgcmVhZCB0aGlzIGFz IEkgY2FuIGJ1aWxkIFhlbiBhbmQgc2VlIGl0IGJvb3RzIChub3QgY3JlYXRpbmcgZG9tYWluKS4N Cj4gPj4gSG93ZXZlci4uLiBIQVNfTVBVIGlzIG5vdCBkZWZpbmVkIGFuZCBJIHdhcyBleHBlY3Rp bmcgbW0uYyB0byBiZQ0KPiA+PiBtb2RpZmllZCB0byBjYXRlciB0aGUgTVBVIHN1cHBvcnQuIFNv IEkgYW0gYSBiaXQgZW5zdXJlIHdoYXQgdGhlIHNlcmllcw0KPiA+PiBpcyBhY3R1YWxseSBkb2lu Zy4NCj4gPj4NCj4gPg0KPiA+IFRoZXNlIDExIHBhdGNoZXMgYXJlIHBhcnQjMSBvZiBzdGFnZSMx LCB0aGUgZnVsbCBzdGFnZSMxIGhhcyBhYm91dCAzMA0KPiA+IHBhdGNoZXMuIFdlIGhhdmUgc29t ZSBjb25jZXJucyBpZiB3ZSBzZW5kIHNvIG1hbnkgcGF0Y2hlcyBhdCBvbmNlLCB0aGUNCj4gPiBy ZXZpZXcgcHJlc3N1cmUgb2YgbWFpbnRhaW5lcnMgbWF5IGJlIHZlcnkgaGlnaCwgc28gd2Ugb25s eSBjaG9vc2UgYWJvdXQNCj4gPiAxMCB0byBzZW5kIGFzIHBhcnQgb2YgaXQuIEJ1dCB0aGlzIGFs c28gbWVhbnMgdGhhdCB3ZSBjYW4ndCBkbyBhDQo+IHJlbGF0aXZlbHkNCj4gPiBjb21wbGV0ZSB0 aGluZyBpbiB0aGlzIHBhcnQjMSBzZXJpZXMuDQo+ID4NCj4gPiBXZSB3YW50IHRvIGhlYXIgc29t ZSBzdWdnZXN0aW9ucyBmcm9tIHlvdSB0byBtYWtlIHNvIG1hbnkgcGF0Y2hlcyBjYW4gYmUNCj4g PiBSZXZpZXdlZCBlZmZpY2llbnRseS4gQ2FuIHdlIHNlbmQgdGhlIHBhdGNoZXMgYnkgc3RhZ2Vz LCBldmVuIHRoZQ0KPiBzdGFnZSMxDQo+ID4gd2lsbCBoYXZlIGFib3V0IDMwIHBhdGNoZXM/DQo+ IA0KPiAzMCBwYXRjaGVzIGluIGEgZ28gaXMgbm8gdG9vIGJhZC4gSSB3b3VsZCBwZXJzb25hbGx5 IHByZWZlciB0aGF0IGJlY2F1c2UNCj4gYXQgbGVhc3QgSSBoYXZlIGJldHRlciBpZGVhIG9mIHRo ZSBzaGFwZSBvZiB0aGUgY29kZSBhZnRlciBzdGFnZSMxIGFuZA0KPiBhbHNvIHBvc3NpYmx5IHRl c3QgaXQgKEkgbmVlZCB0byBjaGVjayBpZiBJIGhhdmUgYWNjZXNzIGZvciB0aGUgQVJNdjgtUg0K PiBtb2RlbCkuDQo+IA0KDQpJIGFsc28gcHJlZmVyIHRvIHRoaXMgd2F5LiBBZnRlciB3ZSBoYXZl IGFkZHJlc3NlZCB0aGUgY29tbWVudHMgaW4NCnRoaXMgc2VyaWVzLCB3ZSB3aWxsIHNlbmQgdGhl IGZ1bGwgc3RhZ2UjMSBwYXRjaGVzIHRvZ2V0aGVyIGluIHYyLg0KDQpGb3IgQXJtdjgtUiBtb2Rl bCwgeW91IGNhbiBkb3dubG9hZCBBcm12OC1SIEFFTSBGVlAgbW9kZWwgZnJvbSBsaW5rWzFdLg0K SXQncyBsaWNlbnNlIGZyZWUuDQoNClsxXSBodHRwczovL2RldmVsb3Blci5hcm0uY29tL2Rvd25s b2Fkcy8tL2FybS1lY29zeXN0ZW0tbW9kZWxzDQoNCkNoZWVycywNCldlaSBDaGVuDQoNCj4gQ2hl ZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:36:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:36:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439255.693275 (Exim 4.92) (envelope-from ) id 1orzU7-0007Ca-Le; Mon, 07 Nov 2022 10:36:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439255.693275; Mon, 07 Nov 2022 10:36:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzU7-0007CT-Is; Mon, 07 Nov 2022 10:36:07 +0000 Received: by outflank-mailman (input) for mailman id 439255; Mon, 07 Nov 2022 10:36:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzU6-0007CJ-OZ; Mon, 07 Nov 2022 10:36:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzU6-0003QN-Ir; Mon, 07 Nov 2022 10:36:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzU6-0005jQ-0d; Mon, 07 Nov 2022 10:36:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1orzU6-00039F-0A; Mon, 07 Nov 2022 10:36:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=k8C9KU/FZdCeITFOikAj2uOZESl1qtQPJ0N8NqDYolY=; b=QumF9WSGpOusKySZiQk72AeC9a NWuFX1w+IMu7wrjobUcevM7yZJhY44QhLFGg/HSWn4bJptfJT41z0jzrjjcQO5WjECcRS2gBDAv+Q 7FYULXcx0mRFE27QN1kHxs104+Lvr1prXtuaKyXOZ3ea7oNmj6cC+zfF222PakRkkqEY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174652: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=37f82facd62f720fdcec104f72f86b8c6c214820 X-Osstest-Versions-That: xen=37f82facd62f720fdcec104f72f86b8c6c214820 From: osstest service owner Date: Mon, 07 Nov 2022 10:36:06 +0000 flight 174652 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174652/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174641 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174641 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174641 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174641 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174641 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174641 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174641 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174641 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174641 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174641 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174641 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174641 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 37f82facd62f720fdcec104f72f86b8c6c214820 baseline version: xen 37f82facd62f720fdcec104f72f86b8c6c214820 Last test of basis 174652 2022-11-07 01:53:46 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:36:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:36:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439258.693285 (Exim 4.92) (envelope-from ) id 1orzUH-0007Vm-2w; Mon, 07 Nov 2022 10:36:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439258.693285; Mon, 07 Nov 2022 10:36:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzUG-0007Vf-WE; Mon, 07 Nov 2022 10:36:17 +0000 Received: by outflank-mailman (input) for mailman id 439258; Mon, 07 Nov 2022 10:36:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzUF-0007Uu-5M for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 10:36:15 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2079.outbound.protection.outlook.com [40.107.243.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ffd4b0fc-5e87-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 11:36:13 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by DM6PR12MB4877.namprd12.prod.outlook.com (2603:10b6:5:1bb::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Mon, 7 Nov 2022 10:36:10 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 10:36:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ffd4b0fc-5e87-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WDNiw57FDlOSbw967KL48U28ctmGMaGomqC/ROgI16azWl35t37jWD3+gGhCrfvbui5JDHzDU4EvZrxyriU9lNiXadKpe9k/n4jrligmljTFbo/B5rImTQR4vmadnZiHC+WO8l8C56tllTo3Gi+gWTT9Q5VsU+Q9Bh/xG88EyQK0a1PLa094jXPzpGB0YDSXDT1SikgjmOtET9c4u5agn5oxyLiPIhNFI/n84s/YsYBXbs31ri4CgIgfZcAQLHxqOgeHjwm21/pjpNCcvFumOHslc6tpTPdNFSTfD8y5CPY1//famtfyUUbnDM3PjI/DJYlMKW0KALHM8HPspYr2ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CZ52wnRurqrAFke2eCTYx+Rx14aEnLyyYq0IlZtl2rY=; b=S+heH5FtyyH8MuRQHLdNyZ6vugav6/m5PkTD3RRjwJLAwqHvn55V7qvodJZOvnDjeBHEkuwDPB1NHC35NClZKm/LK0sGN61hf0p10GgJ2iWPVFo8+VXTIzUZlHoJ1L2UG6C6hU/zR57HUnJXS/x9JFCPdghg79QCqlkW+EXveUEM3YaQdQlgyqZOFkTTkjS120PyZ1W5ENrFvSWYjMWiPU1KmbgRt7/lQvRFpJWKYSP0Fbksmrjqde56aPYhFtaUr5VmkoYXEpExqj7jKXX5HxjHh011VAnNMQNbwMS7JvBSubyGYoWRAv/WoB3ZxjRzOep6SJhQSGnp2UEUbwbwJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CZ52wnRurqrAFke2eCTYx+Rx14aEnLyyYq0IlZtl2rY=; b=LiS88zuA9uEPG/Nkk/ZYMHmjOLlQehKqGLxZqfuVHQrEIxYSQWlS6bgU7rxBaoA7IspHq2F2lQe18iFYIIRUOMK0HpRZzlmlBOGiQPv5/jj54tPTLzPlt5YJq3Cmnp8xTDqlF1F7nLJYmDv0aZ6AyNQ+jl1wDq4BttoeH1waCbw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <33a2d125-b7f2-3637-9dab-6b7d616fd4ff@amd.com> Date: Mon, 7 Nov 2022 10:36:03 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com References: <20221104162355.23369-1-ayan.kumar.halder@amd.com> <062c9507-7744-0742-effb-76d2f1222a27@xen.org> From: Ayan Kumar Halder In-Reply-To: <062c9507-7744-0742-effb-76d2f1222a27@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0415.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::19) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM6PR12MB4877:EE_ X-MS-Office365-Filtering-Correlation-Id: a2a347f6-74f9-4f54-10a0-08dac0abe29c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g+DJCnBs5BUjcGNNJjuQCioqUj2AEK4zwFRgYxTOHudAH9PmT5DJ6afrCVXXRgmHI+/O9EZPGubwhnRCQ2YmIlv5ExBjLM6upH4mY2FyIs+Bcf2eXYOD4e92w1XK4guPyPuILnTkUm9DLeC2rvGbEOxxgfDp3Cvib/TG8fAalwsKz5hv+gGibNCzjKFPElMeeH9d5XzgMVnALjED5360UrkzfrcP/AHvgk5JmLvWDbQ4SGPiHYOzPHJ4hubg+NUW61C5Vjpd77OqYz0y3//OLOgIw691niw+CWoRwHkJOinOYn82dHDbB7ukQDLDgCdtj7TFl50+SvCTKBj4lYZAiOoUqbNBWsnWfWCpD1RFCusAiyAnqsWjdVQOJNAc5Rpgn/Z9tIc4/nLT1Smma1zlpHb7we9K2us2zD3+NRyUrqDs2CSo1dJFfhGf1j6/17TEsawGZNaO9B+PpB4A/aQsfITnWKNkO1qSQOPdp8Lv9o3sfemKVXaCvL+zQOz6NmNntdHNBubKdAX536rnsjDywD9vCOE/MvWW2/wMroZqvUJ9g2j/zMnqoaObbO2pvKTdsrSC46USwmR5FPRnTj52TqPzSXfj8RpTI16UasbnsBusj+9E78ok9/bkgOnYvC+3xZ1jT/UmCnGX9MNntJs4sXJnpM+UigCPonfEdFR9QQLqO028GVbN2nmSHYZo07Ihvopb0ROeKqYOB/ZVG659SdhRcVWPI0bXALWCPYRdzI0MaY8duZIUlNn3qRqPLOYuBHbBy6PwTMSGeP4zHqG81plI2Jq44tMQ/Qxu/vJHEmE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(39860400002)(376002)(136003)(451199015)(6512007)(26005)(5660300002)(6506007)(53546011)(478600001)(316002)(110136005)(2906002)(31696002)(6486002)(8936002)(38100700002)(36756003)(6666004)(83380400001)(4326008)(8676002)(66946007)(186003)(2616005)(31686004)(41300700001)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHpMYnlMTGRBSkIyWmVraUFMRmJmMTZmT1M1bk5MdTBJWUZGaFB6S2orSlhP?= =?utf-8?B?SnU4TDBDZVBFZWliejg2emtYWjh6Y3hZem91cUd4bVlWc3FnNzRnbHJJRXFt?= =?utf-8?B?RzRTdHkrSzR5aVFrRy8wa2JzNjQzQVlhVkNwc0tFS0dnckZLbmxzZ01vQUd1?= =?utf-8?B?eFZKZ1UwYUt1YkViVFFKSENWc1FqUHFiUDNqblZ5QVNuUUduK1o3RGFidDJn?= =?utf-8?B?WlFMUm9Na1Z5K0JTbTI3WVo4WXBQZjVVSGV2U1p6Z25na0YvTklQSjY1anhH?= =?utf-8?B?dXlia0FnZFExb0V5dkxpNmc0SklxRkkwdkF3U2UyTzNJRnpMYTZqdHVsUW9k?= =?utf-8?B?cmxWOGFuOStVMmtPL2wrUExMM2F4M1BoZnZBYUxSRWJwZk52TldBT3RqR1BD?= =?utf-8?B?Q0REcXR2akgzK2oyNFFyV20ydjU5VFoxbjJ3cjRlRmY4Tk1oNHdIQUlMemNY?= =?utf-8?B?R0hVdytqb2ZRNUdYc2dwK3pjVUN1dEdtZlJMbW5wdlhuUXNlbzEvRDFWSDNH?= =?utf-8?B?VFFaUm5wTld3eFJtN082SHRNNGhreUk3T2diTWI5c013eVpDOTdHaFdlU3RB?= =?utf-8?B?SVNvUWlwR21hSnBkRlJsZ2hlL1NsSWFiY2kxZGdoQTlXbkh0d3YyZzhzSnRN?= =?utf-8?B?SFlZWUlGNUlCNXc4TFhXSWlNUjFBY3hJdjVHNzlTNFFzUnBoa3Jhbit1RnU1?= =?utf-8?B?NVdDVy85RjQ0SEJWREp2UDVKOUhGUThzZVhjdFdkRTR2eEJLbW5iN2creXhS?= =?utf-8?B?NkF1QlptbmV4ZGdSVVJZNXAxWU16OUM4ak9ORWFSVnVpUUxyVFhmbWc1aGhz?= =?utf-8?B?Q2V0UW10WllURHdRZXZuaGl1SEd5c29aMWdaR0tsSll3c3RRQ3Q3K0VkSlR4?= =?utf-8?B?YnBJMWE3NXM4RTRGZ1oyd1FSNEowY0U5TjdZM3g0Nys1NzF5OXF2UDlNa0dR?= =?utf-8?B?M1MrUEdsRXVGNDRWcG04dkhOZFA1dU84YVllNDlaaXpuTmtmTWw3aUt6bjFJ?= =?utf-8?B?Z0JKV2h3RmQzSnBxeEFMMmh3clJlK1hvcHNJNEdwTVdLbUlJZzU4VkN6dEt0?= =?utf-8?B?c1R6VUdvOHg4UENwem1XUE5mVlNYL0FFdkZrb3B1dkF2Z25BMU04ZVJLRXFD?= =?utf-8?B?OHl4YmpkK0dvZWpsaVR0cjNDSTVoYXFlK2p5dTI1d1l0S1ZhVi84ZTZISjQ5?= =?utf-8?B?WjVwL0xXMVN4K3o1TGRKdnBLZkd6K2k0ZUZMVkxxSjFDazB4KzFnS2ZNMzZY?= =?utf-8?B?VWFtWjRFSGRwQzBNRUl2a1d3clYyN2FRUGNNWVErcitQaklGR2lXQVl6TW9l?= =?utf-8?B?c0lMaC81TmdxbU93NGpPZ2pCT1RMV2pkMFdWVjlYT2VoK3AyQTl0UnpSY1FJ?= =?utf-8?B?MmNZb2x0UGNLWCtaWGl4UVcwcmU2ZDdrK2NXT2RkTmxvZ040cWJ5VGhaRFVN?= =?utf-8?B?TXZkQmJqTnpYd2s1ejVYK3RvV0NzOGdhRmdZVExBcE1abHdMUVdnT1hBVFVT?= =?utf-8?B?ajMwdmpzRk83WFlIb1RGaHVPQXl2ejZkNWh3b1dRdDNBdFIrTkNmYzV4dXV5?= =?utf-8?B?OFpSYlRNdFQvZ2hwRWhvbndpMld1MzhKQ1I5OFQ1SlRpYjBJbTB0L2pxYStO?= =?utf-8?B?ZlZBQ2czL3MvS0paM243MXAzdnluZ1M0ZHZuaWZxRXdpWHFDRGRQSk9uVE94?= =?utf-8?B?eW5xdTZCdGpuRG95b3JKb2ZUSEdLVlhGWXBFeERMOTRpSU93SC9qcHFSa2VM?= =?utf-8?B?OSs3SitHUDI1a1JHVTdDWkFBUC91YXNmZFIva0JocVEyZVI4RXErbk5GR2xQ?= =?utf-8?B?aDZTUTZBTU05dVdicXRoSXg0bE9HL2NiZmR6a0tsRjlpZHZoNVdsNktaTEtp?= =?utf-8?B?dXBXblhtOXViY2FBdzZqQVVRMjAvTkFkT0hjZ1RLMU5NL0ZLeDdTNFVVc2pl?= =?utf-8?B?UmljOHNtM3hIS0lmYkFFRGdhMkJ3ejkxQlhqK3g0VGM4ckMwUjRyZW8yRHFh?= =?utf-8?B?RDEyYzc0REk1Ym9QT2h4MXFYL25UMjB0YlpxdjRVMDB0eVpNcU12VE44S2J2?= =?utf-8?B?Qk1ic1RwNDdMNitOUlAwaVhkbzBIZENjdHQ5TmJsaEI1Y3VMU2tsWUkrdzhL?= =?utf-8?Q?De4OIBPG/P2Bd/IGeDbBcoAa/?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2a347f6-74f9-4f54-10a0-08dac0abe29c X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 10:36:10.2353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +5tmfx428q5+iBkpH0/rIXwmzh6mou7TZZ+9jZzaNICtQktEpp4css5Mc9nlMBNKtqXeIW2HAptlgsFKxsBcjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4877 On 06/11/2022 17:54, Julien Grall wrote: > Hi Ayan, Hi Julien, I need some clarification. > > To me the title and the explaination below suggests... > > On 04/11/2022 16:23, Ayan Kumar Halder wrote: >> From: Ayan Kumar Halder >> >> Refer ARM DDI 0487I.a ID081822, B2.2.1 >> "Requirements for single-copy atomicity >> >> - A read that is generated by a load instruction that loads a single >> general-purpose register and is aligned to the size of the read in the >> instruction is single-copy atomic. >> >> -A write that is generated by a store instruction that stores a single >> general-purpose register and is aligned to the size of the write in the >> instruction is single-copy atomic" >> >> On AArch32, the alignment check is enabled at boot time by setting >> HSCTLR.A bit. >> ("HSCTLR, Hyp System Control Register"). >> However in AArch64, alignment check is not enabled at boot time. > > ... you want to enable the alignment check on AArch64 always. I want to enable alignment check *only* for atomic access. May be I should remove this line --> "However in AArch64, alignment check is not enabled at boot time.". > However, this is not possible to do because memcpy() is using > unaligned access. This is a non atomic access. So the commit does not apply here. > > I think the commit message/title should clarify that the check is > *only* done during debug build. IOW, there are no enforcement in > producation build. AFAICS read_atomic()/write_atomic() is enabled during non debug builds (ie CONFIG_DEBUG=n) as well. For eg :- vgic_v3_distr_mmio_read() --> vgic_fetch_irouter() --> read_atomic() . There is no check for CONFIG_DEBUG. - Ayan > > The alternative would be to use a BUG_ON() but that might be too high > overhead. > > Cheers, > >> >> Thus, one needs to check for alignment when performing atomic >> operations. >> >> Signed-off-by: Ayan Kumar Halder >> Reviewed-by: Michal Orzel > --- >> >> Changes from :- >> v1 - 1. Referred to the latest Arm Architecture Reference Manual in >> the commit >> message. >> >>   xen/arch/arm/include/asm/atomic.h | 2 ++ >>   1 file changed, 2 insertions(+) >> >> diff --git a/xen/arch/arm/include/asm/atomic.h >> b/xen/arch/arm/include/asm/atomic.h >> index 1f60c28b1b..64314d59b3 100644 >> --- a/xen/arch/arm/include/asm/atomic.h >> +++ b/xen/arch/arm/include/asm/atomic.h >> @@ -78,6 +78,7 @@ static always_inline void read_atomic_size(const >> volatile void *p, >>                                              void *res, >>                                              unsigned int size) >>   { >> +    ASSERT(IS_ALIGNED((vaddr_t)p, size)); >>       switch ( size ) >>       { >>       case 1: >> @@ -102,6 +103,7 @@ static always_inline void >> write_atomic_size(volatile void *p, >>                                               void *val, >>                                               unsigned int size) >>   { >> +    ASSERT(IS_ALIGNED((vaddr_t)p, size)); >>       switch ( size ) >>       { >>       case 1: > From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:38:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:38:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439269.693297 (Exim 4.92) (envelope-from ) id 1orzWP-0008Np-Ge; Mon, 07 Nov 2022 10:38:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439269.693297; Mon, 07 Nov 2022 10:38:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzWP-0008Ni-Dp; Mon, 07 Nov 2022 10:38:29 +0000 Received: by outflank-mailman (input) for mailman id 439269; Mon, 07 Nov 2022 10:38:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzWN-0008NY-Dp for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 10:38:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzWN-0003SS-5m; Mon, 07 Nov 2022 10:38:27 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orzWM-0005Ea-VQ; Mon, 07 Nov 2022 10:38:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=CjDHon73BsRSXakSbHTZIDCG7dfaAB2TnKv77f0UnnA=; b=4Y8yhCkx0RPsz3G13bwcFLGYU8 O+PgOpsUlqGTjXWIl5IUqvP7i5TfiD6Aq5ShIvJuRfdkTU6UUL7410cHFeLg76d+h8CAhevbXbpWn iNG/r6fII7+EYEI97VgYXvYZ0RruO1mmvajVvPFtGA2QuMpP+z9qUZGywX/LSU0q6Mhs=; Message-ID: <09e0dfa1-0167-a4b2-63cf-5cf8619fa417@xen.org> Date: Mon, 7 Nov 2022 10:38:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 10/11] xen/arm64: introduce helpers for MPU enable/disable Content-Language: en-US To: Penny Zheng , Wei Chen , "xen-devel@lists.xenproject.org" Cc: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-11-wei.chen@arm.com> <54d6e747-c791-c321-3c75-87613393d789@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/11/2022 09:57, Penny Zheng wrote: > Hi Julien Hi Penny, > >> -----Original Message----- >> From: Xen-devel On Behalf Of >> Julien Grall >> Sent: Monday, November 7, 2022 4:56 AM >> To: Wei Chen ; xen-devel@lists.xenproject.org >> Cc: nd ; Penny Zheng ; Stefano >> Stabellini ; Bertrand Marquis >> ; Volodymyr Babchuk >> >> Subject: Re: [PATCH v6 10/11] xen/arm64: introduce helpers for MPU >> enable/disable >> >> Hi Wei, >> >> On 04/11/2022 10:07, Wei Chen wrote: >>> From: Penny Zheng >>> >>> We need some helpers for Xen to enable/disable MPU in boot-time and >>> runtime. For MPU enable helper, we know that it's an essential >>> requirement of MPU system. But for MPU disable, we need to use it for >>> some special situations. For example, in the progress of tranferring >>> from boot-time to runtime, we need to update the MPU protection >>> regions configuration, but we can't modify an MPU protection region if >>> there is some data accessed by Xen. But in boot-time all of Xen text, >>> data and BSS are in one MPU protection region, if Xen want to update >>> this protection region, above restriction will be triggered. >> >> This raises the following question: Why can't we create the split regions right >> now? >> > > The reason why we are not creating the split regions right now is that we > are trying to go the same path MMU goes. The MMU code is going to change pretty soon (see [1] for some ground work). The runtime page-tables for CPU0 will be created in assembly code and never switched after (aside when using cache coloring). Although, I don't think I will apply the proper permissions in assembly (this is a bit trickier than with the MPU). > Then we could reuse as much > same interfaces as we could, in order to not leave #ifdef CONFIG_HAS_MPU > all over the place. Do you have a list of those interfaces that would require #ifdef? > >> In particular, disabling the MMU/Cache is fairly risky because you need to >> ensure that anything in the cache you care about have been written back to >> the RAM). >> > > Hope I could understand your concern totally, you are worrying about stale info left in > the cache, even if it's always 1:1 mapping on the MPU system, memory attributes could > be different before and after? No. I am more concerned about... > So it is never enough that we only flush the variables which we will use during the disabling > time, it should be everything in the cache...:/ ... this. We don't only need to flush before they are accessed but also after if they are modified. It is possible to do it correctly, but it requires to be very careful. So if we can avoid disabling the cache/MPU then it will be a lot better. > > Since in current design, there are two time points in boot time where we will disable > MPU/Cache to configure MPU. > > One is in setup_mm, here, we will map XEN components by components, each MPU memory > region for a different component. > The other is near the end of boot time, we will reorg the whole MPU memory region layout > before going runtime, and we will keep unchanging regions in the front and flexible ones in the rear. You should not need any reorg if you map the boot-only section towards in the higher slot index (or just after the fixed ones). Cheers, [1] 20221022150422.17707-1-julien@xen.org -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:44:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:44:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439277.693308 (Exim 4.92) (envelope-from ) id 1orzcV-0001P3-4P; Mon, 07 Nov 2022 10:44:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439277.693308; Mon, 07 Nov 2022 10:44:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzcV-0001Ow-1X; Mon, 07 Nov 2022 10:44:47 +0000 Received: by outflank-mailman (input) for mailman id 439277; Mon, 07 Nov 2022 10:44:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzcT-0001Oq-6C for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 10:44:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzcS-0003ag-No; Mon, 07 Nov 2022 10:44:44 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1orzcS-0005UY-GN; Mon, 07 Nov 2022 10:44:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=DSlAdsbIIpXcQ4Va4b6w1JeG0tSAfdhpG/PrKwQnXWY=; b=rDYMqqYUP6w5XNMdqapst3CbYT AHlF7mC9z9iyBZAHmE/zBWqcYCk6rAe1VLyA16UufZqeRgQaNpJTdZXIyVqLPGehPodIBd7oox2ZM 0mA7iVUae7y3lrXfZq2v3SJksS5qDhy68xOZs0S7Ojhtg8dehvDm/V7dZvVCFskvYIVw=; Message-ID: Date: Mon, 7 Nov 2022 10:44:42 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write Content-Language: en-US To: Ayan Kumar Halder , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com References: <20221104162355.23369-1-ayan.kumar.halder@amd.com> <062c9507-7744-0742-effb-76d2f1222a27@xen.org> <33a2d125-b7f2-3637-9dab-6b7d616fd4ff@amd.com> From: Julien Grall In-Reply-To: <33a2d125-b7f2-3637-9dab-6b7d616fd4ff@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 07/11/2022 10:36, Ayan Kumar Halder wrote: > > On 06/11/2022 17:54, Julien Grall wrote: >> Hi Ayan, > > Hi Julien, > > I need some clarification. > >> >> To me the title and the explaination below suggests... >> >> On 04/11/2022 16:23, Ayan Kumar Halder wrote: >>> From: Ayan Kumar Halder >>> >>> Refer ARM DDI 0487I.a ID081822, B2.2.1 >>> "Requirements for single-copy atomicity >>> >>> - A read that is generated by a load instruction that loads a single >>> general-purpose register and is aligned to the size of the read in the >>> instruction is single-copy atomic. >>> >>> -A write that is generated by a store instruction that stores a single >>> general-purpose register and is aligned to the size of the write in the >>> instruction is single-copy atomic" >>> >>> On AArch32, the alignment check is enabled at boot time by setting >>> HSCTLR.A bit. >>> ("HSCTLR, Hyp System Control Register"). >>> However in AArch64, alignment check is not enabled at boot time. >> >> ... you want to enable the alignment check on AArch64 always. > > I want to enable alignment check *only* for atomic access. > > May be I should remove this line --> "However in AArch64, alignment > check is not enabled at boot time.". > >> However, this is not possible to do because memcpy() is using >> unaligned access. > This is a non atomic access. So the commit does not apply here. Right, but your commit message refers to the alignment check on arm32. You wrote too much for someone to wonder but not enough to explain why we can't enable the alignment check on arm64. >> >> I think the commit message/title should clarify that the check is >> *only* done during debug build. IOW, there are no enforcement in >> producation build. > > AFAICS read_atomic()/write_atomic() is enabled during non debug builds > (ie CONFIG_DEBUG=n) as well. My point was that ASSERT() is a NOP in production build. So you effectively the enforcement happens only in debug build. IOW, unless you test exhaustively with a debug build, you may never notice that the access was not atomic. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:47:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:47:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439284.693318 (Exim 4.92) (envelope-from ) id 1orzfT-0002Fe-IG; Mon, 07 Nov 2022 10:47:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439284.693318; Mon, 07 Nov 2022 10:47:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzfT-0002FX-Fc; Mon, 07 Nov 2022 10:47:51 +0000 Received: by outflank-mailman (input) for mailman id 439284; Mon, 07 Nov 2022 10:47:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzfS-0002FR-QH for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 10:47:50 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 9e9af3d0-5e89-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 11:47:49 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 114051FB; Mon, 7 Nov 2022 02:47:54 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AE5773F73D; Mon, 7 Nov 2022 02:47:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e9af3d0-5e89-11ed-91b5-6bf2151ebd3b From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [RFC PATCH 0/4] Static analyser finding deviation Date: Mon, 7 Nov 2022 10:47:35 +0000 Message-Id: <20221107104739.10404-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 This serie introduces a way to suppress a static analyser finding providing a proper justification for it. The process is explained in the docs/misra/documenting-violations.rst document that this serie will provide. The tools currently supported are eclair, coverity and cppcheck, but the design is open to support many other static analysis tool. The changes are split between the first two patches to reduce the review effort, the first patch is introducing the deviation process for the eclair and coverity tools, this is because their analysis system is similar. The second patch is introducing the same deviation process for cppcheck, modifying the current way it is called from the makefile and improving its analysis. The third patch is a fix for a tool used for cppcheck and the fourth patch is an example of how a deviation can be applied for some MISRA findings. Luca Fancellu (4): xen/Makefile: add analysis-coverity and analysis-eclair xen/Makefile: add analysis-cppcheck and analysis-cppcheck-html tools/misra: fix skipped rule numbers xen: Justify linker script defined symbols in include/xen/kernel.h .gitignore | 10 +- docs/misra/cppcheck.txt | 47 +++-- docs/misra/documenting-violations.rst | 173 +++++++++++++++ docs/misra/false-positive-coverity.json | 12 ++ docs/misra/false-positive-cppcheck.json | 12 ++ docs/misra/false-positive-eclair.json | 12 ++ docs/misra/safe.json | 20 ++ xen/Makefile | 181 +++++++++++----- xen/include/hypercall-defs.c | 9 + xen/include/xen/kernel.h | 4 + xen/tools/convert_misra_doc.py | 32 ++- xen/tools/cppcheck-build-suppr-list.sh | 81 +++++++ xen/tools/cppcheck-cc.sh | 223 ++++++++++++++++++++ xen/tools/cppcheck-html-prepare.sh | 110 ++++++++++ xen/tools/cppcheck-plat/arm32-wchar_t4.xml | 17 ++ xen/tools/cppcheck-plat/arm64-wchar_t2.xml | 17 ++ xen/tools/cppcheck-plat/arm64-wchar_t4.xml | 17 ++ xen/tools/cppcheck-plat/x86_64-wchar_t2.xml | 17 ++ xen/tools/cppcheck-plat/x86_64-wchar_t4.xml | 17 ++ xen/tools/cppcheck-txt-prepare.sh | 74 +++++++ xen/tools/xenfusa-gen-tags.py | 81 +++++++ 21 files changed, 1089 insertions(+), 77 deletions(-) create mode 100644 docs/misra/documenting-violations.rst create mode 100644 docs/misra/false-positive-coverity.json create mode 100644 docs/misra/false-positive-cppcheck.json create mode 100644 docs/misra/false-positive-eclair.json create mode 100644 docs/misra/safe.json create mode 100755 xen/tools/cppcheck-build-suppr-list.sh create mode 100755 xen/tools/cppcheck-cc.sh create mode 100755 xen/tools/cppcheck-html-prepare.sh create mode 100644 xen/tools/cppcheck-plat/arm32-wchar_t4.xml create mode 100644 xen/tools/cppcheck-plat/arm64-wchar_t2.xml create mode 100644 xen/tools/cppcheck-plat/arm64-wchar_t4.xml create mode 100644 xen/tools/cppcheck-plat/x86_64-wchar_t2.xml create mode 100644 xen/tools/cppcheck-plat/x86_64-wchar_t4.xml create mode 100755 xen/tools/cppcheck-txt-prepare.sh create mode 100755 xen/tools/xenfusa-gen-tags.py -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:47:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:47:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439285.693330 (Exim 4.92) (envelope-from ) id 1orzfV-0002WG-QE; Mon, 07 Nov 2022 10:47:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439285.693330; Mon, 07 Nov 2022 10:47:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzfV-0002W9-NA; Mon, 07 Nov 2022 10:47:53 +0000 Received: by outflank-mailman (input) for mailman id 439285; Mon, 07 Nov 2022 10:47:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzfU-0002Pj-Gt for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 10:47:52 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9eebd907-5e89-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 11:47:49 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9397823A; Mon, 7 Nov 2022 02:47:55 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 23ED53F73D; Mon, 7 Nov 2022 02:47:48 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9eebd907-5e89-11ed-8fd1-01056ac49cbb From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Date: Mon, 7 Nov 2022 10:47:36 +0000 Message-Id: <20221107104739.10404-2-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221107104739.10404-1-luca.fancellu@arm.com> References: <20221107104739.10404-1-luca.fancellu@arm.com> Add new targets to makefile, analysis-{coverity,eclair} that will: - Create a tag database using a new tool called xenfusa-gen-tags.py - Get every file with the FuSa tag SAF- in-code comment, create a copy of it as .safparse and substituting the tags with proprietary tool syntax in-code comments using the database. - build Xen, coverity and eclair are capable of intercepting the compiler invocation on every build file so the only action from them is to run these new targets, the file they will analyse will automatically contain understandable suppression in-code comment for them. - call analysis-clean to restore original files. In case of any error, the user needs to manually run the target analysis-clean to restore the original files, before that step, any following run of analysis-{coverity,eclair} will stop and won't overwrite the original files. Add in docs/misra/ the files safe.json and false-positive-{coverity,eclair}.json that are JSON files containing the data structures for the justifications, they are used by the xenfusa-gen-tags.py to create the substitution list. Add docs/misra/documenting-violations.rst to explain how to add justifications. Add files to .gitignore and update clean rule content in Makefile. Signed-off-by: Luca Fancellu --- .gitignore | 2 + docs/misra/documenting-violations.rst | 172 ++++++++++++++++++++++++ docs/misra/false-positive-coverity.json | 12 ++ docs/misra/false-positive-eclair.json | 12 ++ docs/misra/safe.json | 11 ++ xen/Makefile | 50 ++++++- xen/tools/xenfusa-gen-tags.py | 81 +++++++++++ 7 files changed, 338 insertions(+), 2 deletions(-) create mode 100644 docs/misra/documenting-violations.rst create mode 100644 docs/misra/false-positive-coverity.json create mode 100644 docs/misra/false-positive-eclair.json create mode 100644 docs/misra/safe.json create mode 100755 xen/tools/xenfusa-gen-tags.py diff --git a/.gitignore b/.gitignore index 418bdfaebf36..b48e1e20c4fc 100644 --- a/.gitignore +++ b/.gitignore @@ -10,6 +10,7 @@ *.c.cppcheck *.opic *.a +*.safparse *.so *.so.[0-9]* *.bin @@ -314,6 +315,7 @@ xen/xsm/flask/policy.* xen/xsm/flask/xenpolicy-* tools/flask/policy/policy.conf tools/flask/policy/xenpolicy-* +xen/*.sed xen/xen xen/xen-cppcheck.xml xen/xen-syms diff --git a/docs/misra/documenting-violations.rst b/docs/misra/documenting-violations.rst new file mode 100644 index 000000000000..3430abfaa177 --- /dev/null +++ b/docs/misra/documenting-violations.rst @@ -0,0 +1,172 @@ +.. SPDX-License-Identifier: CC-BY-4.0 + +Documenting violations +====================== + +Static analysers are used on the Xen codebase for both static analysis and MISRA +compliance. +There might be the need to suppress some findings instead of fixing them and +many tools permit the usage of in-code comments that suppress findings so that +they are not shown in the final report. + +Xen includes a tool capable of translating a specific comment used in its +codebase to the right proprietary in-code comment understandable by the selected +analyser that suppress its finding. + +In the Xen codebase, these tags will be used to document and suppress findings: + + - SAF-X-safe: This tag means that the next line of code contains a finding, but + the non compliance to the checker is analysed and demonstrated to be safe. + - SAF-X-false-positive-: This tag means that the next line of code + contains a finding, but the finding is a bug of the tool. + +SAF stands for Static Analyser Finding, the X is a placeholder for a positive +number that starts from zero, the number after SAF- shall be incremental and +unique, base ten notation and without leading zeros. + +Entries in the database shall never be removed, even if they are not used +anymore in the code (if a patch is removing or modifying the faulty line). +This is to make sure that numbers are not reused which could lead to conflicts +with old branches or misleading justifications. + +An entry can be reused in multiple places in the code to suppress a finding if +and only if the justification holds for the same non-compliance to the coding +standard. + +An orphan entry, that is an entry who was justifying a finding in the code, but +later that code was removed and there is no other use of that entry in the code, +can be reused as long as the justification for the finding holds. This is done +to avoid the allocation of a new entry with exactly the same justification, that +would lead to waste of space and maintenance issues of the database. + +The files where to store all the justifications are in xen/docs/misra/ and are +named as safe.json and false-positive-.json, they have JSON format. + +Here is an example to add a new justification in safe.json:: + +|{ +| "version": "1.0", +| "content": [ +| { +| "id": "SAF-0-safe", +| "analyser": { +| "coverity": "misra_c_2012_rule_20_7_violation", +| "eclair": "MC3R1.R20.7" +| }, +| "name": "R20.7 C macro parameters not used as expression", +| "text": "The macro parameters used in this [...]" +| }, +| { +| "id": "SAF-1-safe", +| "analyser": {}, +| "name": "Sentinel", +| "text": "Next ID to be used" +| } +| ] +|} + +Here is an example to add a new justification in false-positive-.json:: + +|{ +| "version": "1.0", +| "content": [ +| { +| "id": "SAF-0-false-positive-", +| "analyser": { +| "": "" +| }, +| "tool-version": "", +| "name": "R20.7 [...]", +| "text": "[...]" +| }, +| { +| "id": "SAF-1-false-positive-", +| "analyser": {}, +| "tool-version": "", +| "name": "Sentinel", +| "text": "Next ID to be used" +| } +| ] +|} + +To document a finding, just add another block {[...]} before the sentinel block, +using the id contained in the sentinel block and increment by one the number +contained in the id of the sentinel block. + +Here an explanation of the field inside an object of the "content" array: + - id: it is a unique string that is used to refer to the finding, many finding + can be tagged with the same id, if the justification holds for any applied + case. + It tells the tool to substitute a Xen in-code comment having this structure: + /* SAF-0-safe [...] \*/ + - analyser: it is an object containing pair of key-value strings, the key is + the analyser, so it can be coverity or eclair, the value is the proprietary + id corresponding on the finding, for example when coverity is used as + analyser, the tool will translate the Xen in-code coment in this way: + /* SAF-0-safe [...] \*/ -> /* coverity[misra_c_2012_rule_20_7_violation] \*/ + if the object doesn't have a key-value, then the corresponding in-code + comment won't be translated. + - name: a simple name for the finding + - text: a proper justification to turn off the finding. + + +Justification example +--------------------- + +Here an example of the usage of the in-code comment tags to suppress a finding +for the Rule 8.6: + +Eclair reports it in its web report, file xen/include/xen/kernel.h, line 68: + +| MC3R1.R8.6 for program 'xen/xen-syms', variable '_start' has no definition + +Also coverity reports it, here is an extract of the finding: + +| xen/include/xen/kernel.h:68: +| 1. misra_c_2012_rule_8_6_violation: Function "_start" is declared but never + defined. + +The analysers are complaining because we have this in xen/include/xen/kernel.h +at line 68:: + +| extern char _start[], _end[], start[]; + +Those are symbols exported by the linker, hence we will need to have a proper +deviation for this finding. + +We will prepare our entry in the safe.json database:: + +|{ +| "version": "1.0", +| "content": [ +| { +| [...] +| }, +| { +| "id": "SAF-1-safe", +| "analyser": { +| "eclair": "MC3R1.R8.6", +| "coverity": "misra_c_2012_rule_8_6_violation" +| }, +| "name": "Rule 8.6: linker script defined symbols", +| "text": "It is safe to declare this symbol because it is defined in the linker script." +| }, +| { +| "id": "SAF-2-safe", +| "analyser": {}, +| "name": "Sentinel", +| "text": "Next ID to be used" +| } +| ] +|} + +And we will use the proper tag above the violation line:: + +| /* SAF-1-safe R8.6 linker defined symbols */ +| extern char _start[], _end[], start[]; + +This entry will fix also the violation on _end and start, because they are on +the same line and the same "violation ID". + +Also, the same tag can be used on other symbols from the linker that are +declared in the codebase, because the justification holds for them too. diff --git a/docs/misra/false-positive-coverity.json b/docs/misra/false-positive-coverity.json new file mode 100644 index 000000000000..f8e6a014acb5 --- /dev/null +++ b/docs/misra/false-positive-coverity.json @@ -0,0 +1,12 @@ +{ + "version": "1.0", + "content": [ + { + "id": "SAF-0-false-positive-coverity", + "analyser": {}, + "tool-version": "", + "name": "Sentinel", + "text": "Next ID to be used" + } + ] +} diff --git a/docs/misra/false-positive-eclair.json b/docs/misra/false-positive-eclair.json new file mode 100644 index 000000000000..63d00e160f9c --- /dev/null +++ b/docs/misra/false-positive-eclair.json @@ -0,0 +1,12 @@ +{ + "version": "1.0", + "content": [ + { + "id": "SAF-0-false-positive-eclair", + "analyser": {}, + "tool-version": "", + "name": "Sentinel", + "text": "Next ID to be used" + } + ] +} diff --git a/docs/misra/safe.json b/docs/misra/safe.json new file mode 100644 index 000000000000..e079d3038120 --- /dev/null +++ b/docs/misra/safe.json @@ -0,0 +1,11 @@ +{ + "version": "1.0", + "content": [ + { + "id": "SAF-0-safe", + "analyser": {}, + "name": "Sentinel", + "text": "Next ID to be used" + } + ] +} diff --git a/xen/Makefile b/xen/Makefile index 9d0df5e2c543..3b8d1acd1697 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -457,7 +457,8 @@ endif # need-config __all: build -main-targets := build install uninstall clean distclean MAP cppcheck cppcheck-html +main-targets := build install uninstall clean distclean MAP cppcheck \ + cppcheck-html analysis-coverity analysis-eclair .PHONY: $(main-targets) ifneq ($(XEN_TARGET_ARCH),x86_32) $(main-targets): %: _% ; @@ -572,7 +573,7 @@ _clean: rm -f $(TARGET).efi $(TARGET).efi.map $(TARGET).efi.stripped rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h rm -f .banner .allconfig.tmp include/xen/compile.h - rm -f cppcheck-misra.* xen-cppcheck.xml + rm -f cppcheck-misra.* xen-cppcheck.xml *.sed .PHONY: _distclean _distclean: clean @@ -757,6 +758,51 @@ cppcheck-version: $(objtree)/include/generated/compiler-def.h: $(Q)$(CC) -dM -E -o $@ - < /dev/null +JUSTIFICATION_FILES := $(XEN_ROOT)/docs/misra/safe.json \ + $(XEN_ROOT)/docs/misra/false-positive-$$*.json + +# The following command is using grep to find all files that contains a comment +# containing "SAF-" on a single line. +# %.safparse will be the original files saved from the build system, these files +# will be restored at the end of the analysis step +PARSE_FILE_LIST := $(addsuffix .safparse,$(filter-out %.safparse,\ +$(shell grep -ERl '^[[:blank:]]*\/\*[[:space:]]+SAF-.*\*\/$$' $(srctree)))) + +.PRECIOUS: $(PARSE_FILE_LIST) $(objtree)/%.sed + +.SECONDEXPANSION: +$(objtree)/%.sed: $(JUSTIFICATION_FILES) $(srctree)/tools/xenfusa-gen-tags.py + $(PYTHON) $(srctree)/tools/xenfusa-gen-tags.py \ + $(foreach file, $(filter %.json, $^), --input $(file)) --output $@ \ + --tool $* + +%.safparse: % +# Create a copy of the original file (-p preserves also timestamp) + $(Q)if [ -f "$@" ]; then \ + echo "Found $@, please check the integrity of $*"; \ + exit 1; \ + fi + $(Q)cp -p "$*" "$@" + +analysis-parse-tags-%: $(PARSE_FILE_LIST) $(objtree)/%.sed + $(Q)for file in $(patsubst %.safparse,%,$(PARSE_FILE_LIST)); do \ + sed -i -f "$(objtree)/$*.sed" "$${file}"; \ + done + +analysis-build-%: analysis-parse-tags-% + $(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile build + +analysis-clean: +# Reverts the original file (-p preserves also timestamp) + $(Q)find $(srctree) -type f -name "*.safparse" -print | \ + while IFS= read file; do \ + cp -p "$${file}" "$${file%.safparse}"; \ + rm -f "$${file}"; \ + done + +_analysis-%: analysis-build-% + $(Q)$(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile analysis-clean + endif #config-build endif # need-sub-make diff --git a/xen/tools/xenfusa-gen-tags.py b/xen/tools/xenfusa-gen-tags.py new file mode 100755 index 000000000000..4ab8c0f07a52 --- /dev/null +++ b/xen/tools/xenfusa-gen-tags.py @@ -0,0 +1,81 @@ +#!/usr/bin/env python + +import sys, getopt, json + +def help(): + print('Usage: {} [OPTION] ...'.format(sys.argv[0])) + print('') + print('This script converts the justification file to a set of sed rules') + print('that will replace generic tags from Xen codebase in-code comments') + print('to in-code comments having the proprietary syntax for the selected') + print('tool.') + print('') + print('Options:') + print(' -i/--input Json file containing the justifications, can be') + print(' passed multiple times for multiple files') + print(' -o/--output Sed file containing the substitution rules') + print(' -t/--tool Tool that will use the in-code comments') + print('') + +# This is the dictionary for the rules that translates to proprietary comments: +# - cppcheck: /* cppcheck-suppress[id] */ +# - coverity: /* coverity[id] */ +# - eclair: /* -E> hide id 1 "" */ +# Add entries to support more analyzers +tool_syntax = { + "cppcheck":"s,^.*/*[[:space:]]*TAG.*$,/* cppcheck-suppress[VID] */,g", + "coverity":"s,^.*/*[[:space:]]*TAG.*$,/* coverity[VID] */,g", + "eclair":"s,^.*/*[[:space:]]*TAG.*$,/* -E> hide VID 1 \"\" */,g" +} + +def main(argv): + infiles = [] + justifications = [] + outfile = '' + tool = '' + + try: + opts, args = getopt.getopt(argv,"hi:o:t:",["input=","output=","tool="]) + except getopt.GetoptError: + help() + sys.exit(2) + for opt, arg in opts: + if opt == '-h': + help() + sys.exit(0) + elif opt in ("-i", "--input"): + infiles.append(arg) + elif opt in ("-o", "--output"): + outfile = arg + elif opt in ("-t", "--tool"): + tool = arg + + # Open all input files + for file in infiles: + try: + handle = open(file, 'rt') + content = json.load(handle) + justifications = justifications + content['content'] + handle.close() + except json.JSONDecodeError: + print('JSON decoding error in file: ' + file) + except: + print('Error opening ' + file) + sys.exit(1) + + try: + outstr = open(outfile, "w") + except: + print('Error creating ' + outfile) + sys.exit(1) + + for j in justifications: + if tool in j['analyser']: + comment=tool_syntax[tool].replace("TAG",j['id']) + comment=comment.replace("VID",j['analyser'][tool]) + outstr.write('{}\n'.format(comment)) + + outstr.close() + +if __name__ == "__main__": + main(sys.argv[1:]) \ No newline at end of file -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:47:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:47:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439286.693341 (Exim 4.92) (envelope-from ) id 1orzfX-0002nL-8C; Mon, 07 Nov 2022 10:47:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439286.693341; Mon, 07 Nov 2022 10:47:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzfX-0002nC-5S; Mon, 07 Nov 2022 10:47:55 +0000 Received: by outflank-mailman (input) for mailman id 439286; Mon, 07 Nov 2022 10:47:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzfW-0002FR-1m for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 10:47:54 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a168385b-5e89-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 11:47:53 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A62EA113E; Mon, 7 Nov 2022 02:47:58 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 514C43F73D; Mon, 7 Nov 2022 02:47:51 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a168385b-5e89-11ed-91b5-6bf2151ebd3b From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [RFC PATCH 3/4] tools/misra: fix skipped rule numbers Date: Mon, 7 Nov 2022 10:47:38 +0000 Message-Id: <20221107104739.10404-4-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221107104739.10404-1-luca.fancellu@arm.com> References: <20221107104739.10404-1-luca.fancellu@arm.com> Currently the script convert_misra_doc.py is using a loop through range(1,22) to enumerate rules that needs to be skipped, however range function does not include the stop counter in the enumeration ending up into list rules until 21.21 instead of including rule 22. Fix the issue using a dictionary that list the rules in misra c2012. Fixes: 57caa5375321 ("xen: Add MISRA support to cppcheck make rule") Signed-off-by: Luca Fancellu --- xen/tools/convert_misra_doc.py | 32 ++++++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/xen/tools/convert_misra_doc.py b/xen/tools/convert_misra_doc.py index caa4487f645f..13074d8a2e91 100755 --- a/xen/tools/convert_misra_doc.py +++ b/xen/tools/convert_misra_doc.py @@ -14,6 +14,34 @@ Usage: import sys, getopt, re +# MISRA rule are identified by two numbers, e.g. Rule 1.2, the main rule number +# and a sub-number. This dictionary contains the number of the MISRA rule as key +# and the maximum sub-number for that rule as value. +misra_c2012_rules = { + 1:4, + 2:7, + 3:2, + 4:2, + 5:9, + 6:2, + 7:4, + 8:14, + 9:5, + 10:8, + 11:9, + 12:5, + 13:6, + 14:4, + 15:7, + 16:7, + 17:8, + 18:8, + 19:2, + 20:14, + 21:21, + 22:10 +} + def main(argv): infile = '' outfile = '' @@ -142,8 +170,8 @@ def main(argv): skip_list = [] # Search for missing rules and add a dummy text with the rule number - for i in list(range(1,22)): - for j in list(range(1,22)): + for i in misra_c2012_rules: + for j in list(range(1,misra_c2012_rules[i]+1)): if str(i) + '.' + str(j) not in rule_list: outstr.write('Rule ' + str(i) + '.' + str(j) + '\n') outstr.write('No description for rule ' + str(i) + '.' + str(j) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:47:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:47:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439287.693352 (Exim 4.92) (envelope-from ) id 1orzfY-00034T-K6; Mon, 07 Nov 2022 10:47:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439287.693352; Mon, 07 Nov 2022 10:47:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzfY-00034I-FG; Mon, 07 Nov 2022 10:47:56 +0000 Received: by outflank-mailman (input) for mailman id 439287; Mon, 07 Nov 2022 10:47:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzfW-0002Pj-6U for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 10:47:54 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9fe5345c-5e89-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 11:47:50 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E80AED1; Mon, 7 Nov 2022 02:47:57 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A6EC13F73D; Mon, 7 Nov 2022 02:47:49 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fe5345c-5e89-11ed-8fd1-01056ac49cbb From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [RFC PATCH 2/4] xen/Makefile: add analysis-cppcheck and analysis-cppcheck-html Date: Mon, 7 Nov 2022 10:47:37 +0000 Message-Id: <20221107104739.10404-3-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221107104739.10404-1-luca.fancellu@arm.com> References: <20221107104739.10404-1-luca.fancellu@arm.com> Change cppcheck invocation method by substituting the Makefile targets cppcheck{-html} with analysis-cppcheck{-html}. Now cppcheck will build Xen while analysing the source files, and it will produce a text output when called with analysis-cppcheck and an additional html output when called with analysis-cppcheck-html. With this patch cppcheck will benefit of platform configuration files that will help it to understand the target of the compilation and improve the analysis. To do so: - modify cppcheck calls in Makefile and add files to clean and distclean. - add platform configuration files for cppcheck. - add scripts to generate text and html output. - add cppcheck-cc.sh script that is a wrapper for cppcheck and it's used as Xen compiler, it will intercept all flags given from the make build system and it will execute cppcheck on the compiled file together with the file compilation. - add a script that generates a suppression list for cppcheck to overcome a problem where cppcheck is not suppressing findings in the headers using in-code comment. The system uses the headers in-code comment to produce the list, so it's transparent to the developer and both c files and header can benefit from in-code comment suppression. - guarded hypercall-defs.c with CPPCHECK define because cppcheck gets confused as the file does not contain c code. - add false-positive-cppcheck.json file - update documentation. - update .gitignore Signed-off-by: Luca Fancellu --- .gitignore | 8 +- docs/misra/cppcheck.txt | 47 +++-- docs/misra/documenting-violations.rst | 7 +- docs/misra/false-positive-cppcheck.json | 12 ++ xen/Makefile | 143 ++++++++----- xen/include/hypercall-defs.c | 9 + xen/tools/cppcheck-build-suppr-list.sh | 81 +++++++ xen/tools/cppcheck-cc.sh | 223 ++++++++++++++++++++ xen/tools/cppcheck-html-prepare.sh | 110 ++++++++++ xen/tools/cppcheck-plat/arm32-wchar_t4.xml | 17 ++ xen/tools/cppcheck-plat/arm64-wchar_t2.xml | 17 ++ xen/tools/cppcheck-plat/arm64-wchar_t4.xml | 17 ++ xen/tools/cppcheck-plat/x86_64-wchar_t2.xml | 17 ++ xen/tools/cppcheck-plat/x86_64-wchar_t4.xml | 17 ++ xen/tools/cppcheck-txt-prepare.sh | 74 +++++++ 15 files changed, 717 insertions(+), 82 deletions(-) create mode 100644 docs/misra/false-positive-cppcheck.json create mode 100755 xen/tools/cppcheck-build-suppr-list.sh create mode 100755 xen/tools/cppcheck-cc.sh create mode 100755 xen/tools/cppcheck-html-prepare.sh create mode 100644 xen/tools/cppcheck-plat/arm32-wchar_t4.xml create mode 100644 xen/tools/cppcheck-plat/arm64-wchar_t2.xml create mode 100644 xen/tools/cppcheck-plat/arm64-wchar_t4.xml create mode 100644 xen/tools/cppcheck-plat/x86_64-wchar_t2.xml create mode 100644 xen/tools/cppcheck-plat/x86_64-wchar_t4.xml create mode 100755 xen/tools/cppcheck-txt-prepare.sh diff --git a/.gitignore b/.gitignore index b48e1e20c4fc..abe47bfda9d2 100644 --- a/.gitignore +++ b/.gitignore @@ -7,9 +7,11 @@ *.o *.d *.d2 -*.c.cppcheck +*.cppcheck +*.cppcheck.txt *.opic *.a +*.c.json *.safparse *.so *.so.[0-9]* @@ -283,9 +285,11 @@ xen/arch/*/efi/efi.h xen/arch/*/efi/pe.c xen/arch/*/efi/runtime.c xen/arch/*/include/asm/asm-offsets.h +xen/build-dir-cppcheck xen/common/config_data.S xen/common/config.gz xen/cppcheck-htmlreport/ +xen/cppcheck-report/ xen/cppcheck-misra.* xen/include/headers*.chk xen/include/compat/* @@ -317,7 +321,7 @@ tools/flask/policy/policy.conf tools/flask/policy/xenpolicy-* xen/*.sed xen/xen -xen/xen-cppcheck.xml +xen/suppression-list.txt xen/xen-syms xen/xen-syms.map xen/xen.* diff --git a/docs/misra/cppcheck.txt b/docs/misra/cppcheck.txt index 25d8c3050b72..c59ad03dc7e9 100644 --- a/docs/misra/cppcheck.txt +++ b/docs/misra/cppcheck.txt @@ -38,27 +38,32 @@ Dependencies are listed in the readme.md of the project repository. Use cppcheck to analyse Xen =========================== -Using cppcheck integration is very simple, it requires few steps: - - 1) Compile Xen - 2) call the cppcheck make target to generate a report in xml format: - make CPPCHECK_MISRA=y cppcheck - 3) call the cppcheck-html make target to generate a report in xml and html - format: - make CPPCHECK_MISRA=y cppcheck-html - - In case the cppcheck binaries are not in the PATH, CPPCHECK and - CPPCHECK_HTMLREPORT variables can be overridden with the full path to the - binaries: - - make -C xen \ - CPPCHECK=/path/to/cppcheck \ - CPPCHECK_HTMLREPORT=/path/to/cppcheck-htmlreport \ - CPPCHECK_MISRA=y \ - cppcheck-html - -The output is by default in a folder named cppcheck-htmlreport, but the name -can be changed by passing it in the CPPCHECK_HTMLREPORT_OUTDIR variable. +Using cppcheck integration is very simple, it requires one of the following +steps, depending on whether the user wants a text report or also an html report. +The CPPCHECK_MISRA=y variable in the examples instructs cppcheck to analyse for +MISRA compliance, but when not specified, the report will contain just the +static analysis. + + * call the analysis-cppcheck make target to generate a report in text format: + make CPPCHECK_MISRA=y analysis-cppcheck + * call the analysis-cppcheck-html make target to generate a report in text and + html format: + make CPPCHECK_MISRA=y analysis-cppcheck-html + +In case the cppcheck binaries are not in the PATH, CPPCHECK and +CPPCHECK_HTMLREPORT variables can be overridden with the full path to the +binaries: + +make -C xen \ + CPPCHECK=/path/to/cppcheck \ + CPPCHECK_HTMLREPORT=/path/to/cppcheck-htmlreport \ + CPPCHECK_MISRA=y \ + analysis-cppcheck-html + +The text report is by default in a folder named cppcheck-report, but the name +can be changed by passing it in the CPPCHECK_REPORT_OUTDIR variable. +The html report is by default in a folder named cppcheck-htmlreport, but the +name can be changed by passing it in the CPPCHECK_HTMLREPORT_OUTDIR variable. [1] https://sourceforge.net/p/cppcheck/discussion/general/thread/bfc3ab6c41/?limit=25 diff --git a/docs/misra/documenting-violations.rst b/docs/misra/documenting-violations.rst index 3430abfaa177..f4f54a77d2a2 100644 --- a/docs/misra/documenting-violations.rst +++ b/docs/misra/documenting-violations.rst @@ -50,6 +50,7 @@ Here is an example to add a new justification in safe.json:: | { | "id": "SAF-0-safe", | "analyser": { +| "cppcheck": "misra-c2012-20.7", | "coverity": "misra_c_2012_rule_20_7_violation", | "eclair": "MC3R1.R20.7" | }, @@ -100,9 +101,9 @@ Here an explanation of the field inside an object of the "content" array: It tells the tool to substitute a Xen in-code comment having this structure: /* SAF-0-safe [...] \*/ - analyser: it is an object containing pair of key-value strings, the key is - the analyser, so it can be coverity or eclair, the value is the proprietary - id corresponding on the finding, for example when coverity is used as - analyser, the tool will translate the Xen in-code coment in this way: + the analyser, so it can be cppcheck, coverity or eclair, the value is the + proprietary id corresponding on the finding, for example when coverity is + used as analyser, the tool will translate the Xen in-code coment in this way: /* SAF-0-safe [...] \*/ -> /* coverity[misra_c_2012_rule_20_7_violation] \*/ if the object doesn't have a key-value, then the corresponding in-code comment won't be translated. diff --git a/docs/misra/false-positive-cppcheck.json b/docs/misra/false-positive-cppcheck.json new file mode 100644 index 000000000000..0d8a8059d9cd --- /dev/null +++ b/docs/misra/false-positive-cppcheck.json @@ -0,0 +1,12 @@ +{ + "version": "1.0", + "content": [ + { + "id": "SAF-0-false-positive-cppcheck", + "analyser": {}, + "tool-version": "", + "name": "Sentinel", + "text": "Next ID to be used" + } + ] +} diff --git a/xen/Makefile b/xen/Makefile index 3b8d1acd1697..e8a275e6d8a9 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -457,8 +457,8 @@ endif # need-config __all: build -main-targets := build install uninstall clean distclean MAP cppcheck \ - cppcheck-html analysis-coverity analysis-eclair +main-targets := build install uninstall clean distclean MAP analysis-cppcheck \ + analysis-cppcheck-html analysis-coverity analysis-eclair .PHONY: $(main-targets) ifneq ($(XEN_TARGET_ARCH),x86_32) $(main-targets): %: _% ; @@ -567,18 +567,20 @@ _clean: $(Q)$(MAKE) $(clean)=tools/kconfig find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \ -o -name ".*.o.tmp" -o -name "*~" -o -name "core" \ - -o -name '*.lex.c' -o -name '*.tab.[ch]' -o -name '*.c.cppcheck' \ - -o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \; + -o -name '*.lex.c' -o -name '*.tab.[ch]' -o -name '*.cppcheck' \ + -o -name '*.cppcheck.txt' -o -name "*.gcno" -o -name ".*.cmd" \ + -o -name "lib.a" -o -name '*.c.json' \) -exec rm -f {} \; rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET)-syms $(TARGET)-syms.map rm -f $(TARGET).efi $(TARGET).efi.map $(TARGET).efi.stripped rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h rm -f .banner .allconfig.tmp include/xen/compile.h - rm -f cppcheck-misra.* xen-cppcheck.xml *.sed + rm -f cppcheck-misra.* xen-cppcheck.xml suppression-list.txt *.sed + rm -rf $(CPPCHECK_BUILD_DIR) .PHONY: _distclean _distclean: clean rm -f tags TAGS cscope.files cscope.in.out cscope.out cscope.po.out GTAGS GPATH GRTAGS GSYMS .config source - rm -rf $(CPPCHECK_HTMLREPORT_OUTDIR) + rm -rf $(CPPCHECK_HTMLREPORT_OUTDIR) $(CPPCHECK_REPORT_OUTDIR) $(TARGET).gz: $(TARGET) gzip -n -f -9 < $< > $@.new @@ -663,73 +665,50 @@ CPPCHECK ?= cppcheck # On recent distribution, this is available in the standard path. CPPCHECK_HTMLREPORT ?= cppcheck-htmlreport -# By default we generate the report in cppcheck-htmlreport directory in the +# By default we generate the html report in cppcheck-htmlreport directory in the # build directory. This can be changed by giving a directory in this variable. CPPCHECK_HTMLREPORT_OUTDIR ?= cppcheck-htmlreport +# By default we generate the text report in cppcheck-report directory in the +# build directory. This can be changed by giving a directory in this variable. +CPPCHECK_REPORT_OUTDIR ?= cppcheck-report + # By default we do not check misra rules, to enable pass "CPPCHECK_MISRA=y" to # make command line. CPPCHECK_MISRA ?= n +CPPCHECK_BUILD_DIR := $(objtree)/build-dir-cppcheck + # Compile flags to pass to cppcheck: -# - include directories and defines Xen Makefile is passing (from CFLAGS) # - include config.h as this is passed directly to the compiler. -# - define CPPCHECK as we use to disable or enable some specific part of the +# - define CPPCHECK as we use it to disable or enable some specific part of the # code to solve some cppcheck issues. # - explicitely enable some cppcheck checks as we do not want to use "all" # which includes unusedFunction which gives wrong positives as we check file # per file. +# - Explicitly suppress warnings on compiler-def.h because cppcheck throws an +# unmatchedSuppression due to the rule we put in suppression-list.txt to skip +# every finding in the file. # # Compiler defines are in compiler-def.h which is included in config.h # -CPPCHECKFLAGS := -DCPPCHECK --max-ctu-depth=10 \ - --enable=style,information,missingInclude \ - --include=$(srctree)/include/xen/config.h \ - -I $(srctree)/xsm/flask/include \ - -I $(srctree)/include/xen/libfdt \ - $(filter -D% -I%,$(CFLAGS)) - -# We need to find all C files (as we are not checking assembly files) so -# we find all generated .o files which have a .c corresponding file. -CPPCHECKFILES := $(wildcard $(patsubst $(objtree)/%.o,$(srctree)/%.c, \ - $(filter-out $(objtree)/tools/%, \ - $(shell find $(objtree) -name "*.o")))) - -# Headers and files required to run cppcheck on a file -CPPCHECKDEPS := $(objtree)/include/generated/autoconf.h \ - $(objtree)/include/generated/compiler-def.h +CPPCHECK_FLAGS := --cppcheck-build-dir=$(CPPCHECK_BUILD_DIR) \ + --max-ctu-depth=10 \ + --enable=style,information,missingInclude \ + --template='{file}({line},{column}):{id}:{severity}:{message}' \ + --relative-paths=$(srctree) \ + --inline-suppr \ + --suppressions-list=$(objtree)/suppression-list.txt \ + --suppress='unmatchedSuppression:*generated/compiler-def.h' \ + --include=$(srctree)/include/xen/config.h \ + -DCPPCHECK ifeq ($(CPPCHECK_MISRA),y) - CPPCHECKFLAGS += --addon=cppcheck-misra.json - CPPCHECKDEPS += cppcheck-misra.json -endif - -quiet_cmd_cppcheck_xml = CPPCHECK $(patsubst $(srctree)/%,%,$<) -cmd_cppcheck_xml = $(CPPCHECK) -v -q --xml $(CPPCHECKFLAGS) \ - --output-file=$@ $< - -quiet_cmd_merge_cppcheck_reports = CPPCHECK-MERGE $@ -cmd_merge_cppcheck_reports = $(PYTHON) $(srctree)/tools/merge_cppcheck_reports.py $^ $@ - -quiet_cmd_cppcheck_html = CPPCHECK-HTML $< -cmd_cppcheck_html = $(CPPCHECK_HTMLREPORT) --file=$< --source-dir=$(srctree) \ - --report-dir=$(CPPCHECK_HTMLREPORT_OUTDIR) --title=Xen - -PHONY += _cppcheck _cppcheck-html cppcheck-version - -_cppcheck-html: xen-cppcheck.xml - $(call if_changed,cppcheck_html) - -_cppcheck: xen-cppcheck.xml - -xen-cppcheck.xml: $(patsubst $(srctree)/%.c,$(objtree)/%.c.cppcheck,$(CPPCHECKFILES)) -ifeq ($(CPPCHECKFILES),) - $(error Please build Xen before running cppcheck) +CPPCHECK_FLAGS += --addon=cppcheck-misra.json +CPPCHECK_BUILD_EXTRA_DEPS += cppcheck-misra.json endif - $(call if_changed,merge_cppcheck_reports) -$(objtree)/%.c.cppcheck: $(srctree)/%.c $(CPPCHECKDEPS) | cppcheck-version - $(call if_changed,cppcheck_xml) +PHONY += cppcheck-version cppcheck-version: $(Q)if ! which $(CPPCHECK) > /dev/null 2>&1; then \ @@ -761,6 +740,11 @@ $(objtree)/include/generated/compiler-def.h: JUSTIFICATION_FILES := $(XEN_ROOT)/docs/misra/safe.json \ $(XEN_ROOT)/docs/misra/false-positive-$$*.json +CPPCHECK_CC_FLAGS := --compiler=$(CC) \ + --cppcheck-cmd=$(CPPCHECK) $(CPPCHECK_FLAGS) \ + --cppcheck-plat=$(srctree)/tools/cppcheck-plat \ + --ignore-path=tools/ + # The following command is using grep to find all files that contains a comment # containing "SAF-" on a single line. # %.safparse will be the original files saved from the build system, these files @@ -789,8 +773,49 @@ analysis-parse-tags-%: $(PARSE_FILE_LIST) $(objtree)/%.sed sed -i -f "$(objtree)/$*.sed" "$${file}"; \ done -analysis-build-%: analysis-parse-tags-% - $(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile build +.SECONDEXPANSION: +analysis-build-%: $$(ANALYSIS_BUILD_DEPS) + $(MAKE) O=$(abs_objtree) $(ANALYSIS_EXTRA_MAKE) -f $(srctree)/Makefile build + +$(CPPCHECK_BUILD_DIR) $(CPPCHECK_REPORT_OUTDIR) $(CPPCHECK_HTMLREPORT_OUTDIR): + $(Q)mkdir -p $@ + +$(objtree)/suppression-list.txt: analysis-parse-tags-cppcheck + $(Q)$(srctree)/tools/cppcheck-build-suppr-list.sh --out-list=$@ \ + --source-dir=$(abs_srctree) +# Add this rule to skip every finding in the autogenerated header for cppcheck + $(Q)echo "*:*generated/compiler-def.h" >> $@ + +build-cppcheck: ANALYSIS_EXTRA_MAKE += CC="$(srctree)/tools/cppcheck-cc.sh \ + $(CPPCHECK_CC_FLAGS) $(CPPCHECK_CC_EXTRA_FLAGS) --" +build-cppcheck: ANALYSIS_BUILD_DEPS = $(objtree)/suppression-list.txt \ + $(CPPCHECK_BUILD_EXTRA_DEPS) $(CPPCHECK_BUILD_DIR) \ + $(objtree)/include/generated/compiler-def.h + +build-cppcheck: analysis-build-cppcheck | cppcheck-version + +run-cppcheck: build-cppcheck $(CPPCHECK_REPORT_OUTDIR) + $(Q)$(srctree)/tools/cppcheck-txt-prepare.sh --frag-ext=.cppcheck.txt \ + --rel-path=$(abs_srctree)/ \ + --outfile=$(CPPCHECK_REPORT_OUTDIR)/xen-cppcheck.txt + +run-cppcheck-html: CPPCHECK_CC_EXTRA_FLAGS += --cppcheck-html + +run-cppcheck-html: run-cppcheck $(CPPCHECK_HTMLREPORT_OUTDIR) + $(Q)$(srctree)/tools/cppcheck-html-prepare.sh --frag-ext=.cppcheck \ + --merge-tool=$(abs_srctree)/tools/merge_cppcheck_reports.py \ + --source-dir=$(srctree) \ + --outfile=$(CPPCHECK_HTMLREPORT_OUTDIR)/xen-cppcheck.xml + $(CPPCHECK_HTMLREPORT) \ + --file=$(CPPCHECK_HTMLREPORT_OUTDIR)/xen-cppcheck.xml \ + --source-dir=$(srctree) \ + --report-dir=$(CPPCHECK_HTMLREPORT_OUTDIR)/html --title=Xen +# Strip full build path from html report + $(Q)find $(CPPCHECK_HTMLREPORT_OUTDIR)/html -type f -name '*.html' \ + -exec sed -i -re 's|$(abs_objtree)/||g' {} + +# Strip full source path from html report + $(Q)find $(CPPCHECK_HTMLREPORT_OUTDIR)/html -type f -name '*.html' \ + -exec sed -i -re 's|$(abs_srctree)/||g' {} + analysis-clean: # Reverts the original file (-p preserves also timestamp) @@ -800,7 +825,13 @@ analysis-clean: rm -f "$${file}"; \ done -_analysis-%: analysis-build-% +_analysis-coverity: ANALYSIS_BUILD_DEPS = analysis-parse-tags-coverity +_analysis-eclair: ANALYSIS_BUILD_DEPS = analysis-parse-tags-eclair + +_analysis-coverity _analysis-eclair: _analysis-%: analysis-build-% + $(Q)$(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile analysis-clean + +_analysis-cppcheck _analysis-cppcheck-html: _analysis-cppcheck%: run-cppcheck% $(Q)$(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile analysis-clean endif #config-build diff --git a/xen/include/hypercall-defs.c b/xen/include/hypercall-defs.c index 60cbeb18e4da..d9fbcffa9567 100644 --- a/xen/include/hypercall-defs.c +++ b/xen/include/hypercall-defs.c @@ -60,6 +60,13 @@ * are possible. */ +/* + * Cppcheck thinks this file needs to be analysed because it is preprocessed by + * the compiler, but it gets confused because this file does not contains C + * code. Hence protect the code when CPPCHECK is used. + */ +#ifndef CPPCHECK + #ifdef CONFIG_HVM #define PREFIX_hvm hvm #else @@ -283,3 +290,5 @@ mca do do - - - #ifndef CONFIG_PV_SHIM_EXCLUSIVE paging_domctl_cont do do do do - #endif + +#endif /* !CPPCHECK */ diff --git a/xen/tools/cppcheck-build-suppr-list.sh b/xen/tools/cppcheck-build-suppr-list.sh new file mode 100755 index 000000000000..637ec3ce8d70 --- /dev/null +++ b/xen/tools/cppcheck-build-suppr-list.sh @@ -0,0 +1,81 @@ +#!/usr/bin/env bash + +set -e + +function help() { + cat <> "${OUT_LIST}" + +done < <(grep -ERn '^[[:blank:]]*\/\*[[:space:]]+cppcheck-suppress.*\*\/$' \ + "${SOURCE_DIR}" | grep -E '.*\.h') diff --git a/xen/tools/cppcheck-cc.sh b/xen/tools/cppcheck-cc.sh new file mode 100755 index 000000000000..45a9f749f8c7 --- /dev/null +++ b/xen/tools/cppcheck-cc.sh @@ -0,0 +1,223 @@ +#!/usr/bin/env bash + +set -e + +function help() { + cat < + +This script is a wrapper for cppcheck that enables it to analyse the files that +are the target for the build, it is used in place of a selected compiler and the +make process will run it on every file that needs to be built. +All the arguments passed to the original compiler are forwarded to it without +modification, furthermore, they are used to improve the cppcheck analysis. + +Options: + --compiler= Use this compiler for the build + --cppcheck-cmd= Command line for the cppcheck analysis. + --cppcheck-html Prepare for cppcheck HTML output + --cppcheck-plat= Path to the cppcheck platform folder + --ignore-path= This script won't run cppcheck on the files having this + path, the compiler will run anyway on them. This argument + can be specified multiple times. + -h, --help Print this help +EOF +} + +CC_FILE="" +COMPILER="" +CPPCHECK_HTML="n" +CPPCHECK_PLAT_PATH="" +CPPCHECK_TOOL="" +CPPCHECK_TOOL_ARGS="" +FORWARD_FLAGS="" +IGNORE_PATH="n" +IGNORE_PATH_LIST="" +JDB_FILE="" +OBJTREE_PATH="" + +# Variable used for arg parsing +forward_to_cc="n" +sm_tool_args="n" +obj_arg_content="n" + +for OPTION in "$@" +do + if [ "${forward_to_cc}" = "y" ]; then + if [[ ${OPTION} == *.c ]] + then + CC_FILE="${OPTION}" + elif [ "${OPTION}" = "-o" ] + then + # After -o there is the path to the obj file, flag it + obj_arg_content="y" + elif [ "${obj_arg_content}" = "y" ] + then + # This must be the path to the obj file, turn off flag and save path + OBJTREE_PATH="$(dirname "${OPTION}")" + obj_arg_content="n" + fi + # Forward any argument to the compiler + FORWARD_FLAGS="${FORWARD_FLAGS} ${OPTION}" + continue + fi + case ${OPTION} in + -h|--help) + help + exit 0 + ;; + --compiler=*) + COMPILER="$(eval echo "${OPTION#*=}")" + sm_tool_args="n" + ;; + --cppcheck-cmd=*) + CPPCHECK_TOOL="$(eval echo "${OPTION#*=}")" + sm_tool_args="y" + ;; + --cppcheck-html) + CPPCHECK_HTML="y" + sm_tool_args="n" + ;; + --cppcheck-plat=*) + CPPCHECK_PLAT_PATH="$(eval echo "${OPTION#*=}")" + sm_tool_args="n" + ;; + --ignore-path=*) + IGNORE_PATH_LIST="${IGNORE_PATH_LIST} $(eval echo "${OPTION#*=}")" + sm_tool_args="n" + ;; + --) + forward_to_cc="y" + sm_tool_args="n" + ;; + *) + if [ "${sm_tool_args}" = "y" ]; then + CPPCHECK_TOOL_ARGS="${CPPCHECK_TOOL_ARGS} ${OPTION}" + else + echo "Invalid option ${OPTION}" + exit 1 + fi + ;; + esac +done + +if [ "${COMPILER}" = "" ] +then + echo "--compiler arg is mandatory." + exit 1 +fi + +function print_file() { + local text="${1}" + local init_file="${2}" + + if [ "${init_file}" = "y" ] + then + echo -e -n "${text}" > "${JDB_FILE}" + else + echo -e -n "${text}" >> "${JDB_FILE}" + fi +} + +function create_jcd() { + local line="${1}" + local arg_num=0 + local same_line=0 + + print_file "[\n" "y" + print_file " {\n" + print_file " \"arguments\": [\n" + + for arg in ${line}; do + # This code prevents to put comma in the last element of the list or on + # sequential lines that are going to be merged + [ "${arg_num}" -ne 0 ] && [ "${same_line}" -eq 0 ] && print_file ",\n" + if [ "${same_line}" -ne 0 ] + then + print_file "${arg}\"" + same_line=0 + elif [ "${arg}" = "-iquote" ] || [ "${arg}" = "-I" ] + then + # cppcheck doesn't understand -iquote, substitute with -I + print_file " \"-I" + same_line=1 + else + print_file " \"${arg}\"" + fi + arg_num=$(( arg_num + 1 )) + done + print_file "\n" + print_file " ],\n" + print_file " \"directory\": \"$(pwd -P)\",\n" + print_file " \"file\": \"${CC_FILE}\"\n" + print_file " }\n" + print_file "]\n" +} + + +# Execute compiler with forwarded flags +# Shellcheck complains about missing quotes on FORWARD_FLAGS, but they can't be +# used here +# shellcheck disable=SC2086 +${COMPILER} ${FORWARD_FLAGS} + +if [ -n "${CC_FILE}" ]; +then + for path in ${IGNORE_PATH_LIST} + do + if [[ ${CC_FILE} == *${path}* ]] + then + IGNORE_PATH="y" + echo "${0}: ${CC_FILE} ignored by --ignore-path matching *${path}*" + fi + done + if [ "${IGNORE_PATH}" = "n" ] + then + JDB_FILE="${OBJTREE_PATH}/$(basename "${CC_FILE}".json)" + + # Prepare the Json Compilation Database for the file + create_jcd "${COMPILER} ${FORWARD_FLAGS}" + + out_file="${OBJTREE_PATH}/$(basename "${CC_FILE%.c}".cppcheck.txt)" + + # Check wchar size + wchar_plat_suffix="t4" + # sed prints the last occurence of -f(no-)short-wchar which is the one + # applied to the file by the compiler + wchar_option=$(echo "${FORWARD_FLAGS}" | \ + sed -nre 's,.*(-f(no-)?short-wchar).*,\1,p') + if [ "${wchar_option}" = "-fshort-wchar" ] + then + wchar_plat_suffix="t2" + fi + + # Select the right target platform, ARCH is generated from Xen Makefile + platform="${CPPCHECK_PLAT_PATH}/${ARCH}-wchar_${wchar_plat_suffix}.xml" + if [ ! -f "${platform}" ] + then + echo "${platform} not found!" + exit 1 + fi + + # Shellcheck complains about missing quotes on CPPCHECK_TOOL_ARGS, but + # they can't be used here + # shellcheck disable=SC2086 + ${CPPCHECK_TOOL} ${CPPCHECK_TOOL_ARGS} \ + --project="${JDB_FILE}" \ + --output-file="${out_file}" \ + --platform=${platform} + + if [ "${CPPCHECK_HTML}" = "y" ] + then + # Shellcheck complains about missing quotes on CPPCHECK_TOOL_ARGS, + # but they can't be used here + # shellcheck disable=SC2086 + ${CPPCHECK_TOOL} ${CPPCHECK_TOOL_ARGS} \ + --project="${JDB_FILE}" \ + --output-file="${out_file%.txt}" \ + --platform=${platform} \ + -q \ + --xml + fi + fi +fi diff --git a/xen/tools/cppcheck-html-prepare.sh b/xen/tools/cppcheck-html-prepare.sh new file mode 100755 index 000000000000..c889dcc3582c --- /dev/null +++ b/xen/tools/cppcheck-html-prepare.sh @@ -0,0 +1,110 @@ +#!/usr/bin/env bash + +set -e + +function help() { + cat < + + 8 + unsigned + + 2 + 4 + 4 + 8 + 4 + 8 + 8 + 4 + 4 + 4 + + diff --git a/xen/tools/cppcheck-plat/arm64-wchar_t2.xml b/xen/tools/cppcheck-plat/arm64-wchar_t2.xml new file mode 100644 index 000000000000..e345b934a986 --- /dev/null +++ b/xen/tools/cppcheck-plat/arm64-wchar_t2.xml @@ -0,0 +1,17 @@ + + + 8 + unsigned + + 2 + 4 + 8 + 8 + 4 + 8 + 16 + 8 + 4 + 2 + + diff --git a/xen/tools/cppcheck-plat/arm64-wchar_t4.xml b/xen/tools/cppcheck-plat/arm64-wchar_t4.xml new file mode 100644 index 000000000000..952b3640c91d --- /dev/null +++ b/xen/tools/cppcheck-plat/arm64-wchar_t4.xml @@ -0,0 +1,17 @@ + + + 8 + unsigned + + 2 + 4 + 8 + 8 + 4 + 8 + 16 + 8 + 4 + 4 + + diff --git a/xen/tools/cppcheck-plat/x86_64-wchar_t2.xml b/xen/tools/cppcheck-plat/x86_64-wchar_t2.xml new file mode 100644 index 000000000000..b2dc2fb2cc50 --- /dev/null +++ b/xen/tools/cppcheck-plat/x86_64-wchar_t2.xml @@ -0,0 +1,17 @@ + + + 8 + unsigned + + 2 + 4 + 8 + 8 + 4 + 8 + 16 + 8 + 8 + 2 + + diff --git a/xen/tools/cppcheck-plat/x86_64-wchar_t4.xml b/xen/tools/cppcheck-plat/x86_64-wchar_t4.xml new file mode 100644 index 000000000000..21d97b611505 --- /dev/null +++ b/xen/tools/cppcheck-plat/x86_64-wchar_t4.xml @@ -0,0 +1,17 @@ + + + 8 + unsigned + + 2 + 4 + 8 + 8 + 4 + 8 + 16 + 8 + 8 + 4 + + diff --git a/xen/tools/cppcheck-txt-prepare.sh b/xen/tools/cppcheck-txt-prepare.sh new file mode 100755 index 000000000000..a3fbaa150111 --- /dev/null +++ b/xen/tools/cppcheck-txt-prepare.sh @@ -0,0 +1,74 @@ +#!/usr/bin/env bash + +function help() { + cat <> "${OUTFILE}" +done + +# Remove duplicates, some awk implementation doesn't have inplace change mode +mv "${OUTFILE}" "${OUTFILE}_tmp" +awk '/^\s*?$/||!seen[$0]++' "${OUTFILE}_tmp" > "${OUTFILE}" +rm "${OUTFILE}_tmp" + +if [ -n "${RELPATH}" ] +then + # Strip path + sed -i -re "s|${RELPATH}||g" "${OUTFILE}" +fi -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 07 10:47:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 10:47:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439288.693358 (Exim 4.92) (envelope-from ) id 1orzfZ-0003DY-3h; Mon, 07 Nov 2022 10:47:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439288.693358; Mon, 07 Nov 2022 10:47:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzfZ-0003Bx-0N; Mon, 07 Nov 2022 10:47:57 +0000 Received: by outflank-mailman (input) for mailman id 439288; Mon, 07 Nov 2022 10:47:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1orzfX-0002Pj-Dc for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 10:47:55 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a1a1c49e-5e89-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 11:47:53 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1AAC3139F; Mon, 7 Nov 2022 02:48:00 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B9C0F3F73D; Mon, 7 Nov 2022 02:47:52 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1a1c49e-5e89-11ed-8fd1-01056ac49cbb From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h Date: Mon, 7 Nov 2022 10:47:39 +0000 Message-Id: <20221107104739.10404-5-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221107104739.10404-1-luca.fancellu@arm.com> References: <20221107104739.10404-1-luca.fancellu@arm.com> Eclair and Coverity found violation of the MISRA rule 8.6 for the symbols _start, _end, start, _stext, _etext, _srodata, _erodata, _sinittext, _einittext which are declared in xen/include/xen/kernel.h. All those symbols are defined by the liker script so we can deviate from the rule 8.6 for these cases. Signed-off-by: Luca Fancellu --- docs/misra/safe.json | 9 +++++++++ xen/include/xen/kernel.h | 4 ++++ 2 files changed, 13 insertions(+) diff --git a/docs/misra/safe.json b/docs/misra/safe.json index e079d3038120..e3c8a1d8eb36 100644 --- a/docs/misra/safe.json +++ b/docs/misra/safe.json @@ -3,6 +3,15 @@ "content": [ { "id": "SAF-0-safe", + "analyser": { + "eclair": "MC3R1.R8.6", + "coverity": "misra_c_2012_rule_8_6_violation" + }, + "name": "Rule 8.6: linker script defined symbols", + "text": "It is safe to declare this symbol because it is defined in the linker script." + }, + { + "id": "SAF-1-safe", "analyser": {}, "name": "Sentinel", "text": "Next ID to be used" diff --git a/xen/include/xen/kernel.h b/xen/include/xen/kernel.h index 8cd142032d3b..efcd24b355d6 100644 --- a/xen/include/xen/kernel.h +++ b/xen/include/xen/kernel.h @@ -65,24 +65,28 @@ 1; \ }) +/* SAF-0-safe R8.6 linker script defined symbols */ extern char _start[], _end[], start[]; #define is_kernel(p) ({ \ char *__p = (char *)(unsigned long)(p); \ (__p >= _start) && (__p < _end); \ }) +/* SAF-0-safe R8.6 linker script defined symbols */ extern char _stext[], _etext[]; #define is_kernel_text(p) ({ \ char *__p = (char *)(unsigned long)(p); \ (__p >= _stext) && (__p < _etext); \ }) +/* SAF-0-safe R8.6 linker script defined symbols */ extern const char _srodata[], _erodata[]; #define is_kernel_rodata(p) ({ \ const char *__p = (const char *)(unsigned long)(p); \ (__p >= _srodata) && (__p < _erodata); \ }) +/* SAF-0-safe R8.6 linker script defined symbols */ extern char _sinittext[], _einittext[]; #define is_kernel_inittext(p) ({ \ char *__p = (char *)(unsigned long)(p); \ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 07 11:33:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 11:33:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439324.693373 (Exim 4.92) (envelope-from ) id 1os0Nd-0002Ke-Jc; Mon, 07 Nov 2022 11:33:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439324.693373; Mon, 07 Nov 2022 11:33:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os0Nd-0002KX-Gq; Mon, 07 Nov 2022 11:33:29 +0000 Received: by outflank-mailman (input) for mailman id 439324; Mon, 07 Nov 2022 11:33:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os0Nc-0002KR-2x for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 11:33:28 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2078.outbound.protection.outlook.com [40.107.94.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fd4fc237-5e8f-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 12:33:25 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by PH7PR12MB6717.namprd12.prod.outlook.com (2603:10b6:510:1b0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Mon, 7 Nov 2022 11:33:20 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 11:33:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd4fc237-5e8f-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WohRqy3TWCMsecD3e+SS36ObHev+PYCWtYMX2lDC9fs44dB2BkMrgVLzEVtzDckFBN8S0FP0gyA/U6fgxw7Ieg9pYVIbIryZPKoMweoAK/aIx0+o5YBnfaVOeym4s9xmIj/pxuwtk7XIhhiiXzTWpCUgAKMsxJEZUgGZlgToTfqInSRDhcwc87dv3yW1px5/Edm7zq6g6M0m+jMLOWiU6vp3/zn4GdBcnruoUjvFW28L9nfZmHgxVZnYdzsyXSMjupfWLINPciof6ZQghAWYAgvB4WP+60/w/9sJqcnIAYVw6F+vA+UE+vB6sB+FvNZbGyI8nUDlBfkKMXjuVPf/Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2HEMvp3MyZ9J4dHmLMpIh6FR/Xf+YNy3jfWaVMUQg8E=; b=g6jxeqAFxzSvkGiIL7suwYNyp7KHAH/4IXCxEEPMYOYSENwsvfupb/O1IPEIIGIOUVIzqNEgwtIf5R0/r+Tu/Np0OXY+YvOwUihjkKGLyXzohYvzL5HyyUlsjoBdxBZwGTeBgN+3Bnbq1Kb986b8cvNQbMz0xXVJNhFb1DVfLdT0Gkmb9alMFbA9uPWeV3U7I25cD6ouCo7asQP//24ciFsqjZ5/ONMsNk1hPiKrOad+wR5uSBxcQz7oe2/rEB/6cB4B87P6xMlkISYbfcmpD0cwQp6xaPyq2Y5/k1o/yP03W5SPoaHRue1NO+UpeUPptuqzNECWAPoLvQhetF48qQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2HEMvp3MyZ9J4dHmLMpIh6FR/Xf+YNy3jfWaVMUQg8E=; b=uI3cHxrCuA3MlkGYQlg3llPy9KrSG6cWKo4mSYkW9GPYRtAy/IeKMcQY1GBFVfwSXAZhMTAl1MKqcGP6WVEDrj10D1e0pORz6F2hRhXJQ+7W8Mhs1CwXpzle/mf3nfkhXdmVtjBxpSS9rm0GiowTZoyCvGsn1XihYfsEqIkL2i8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Mon, 7 Nov 2022 11:33:15 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32 To: Julien Grall , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-5-ayankuma@amd.com> <5d369b95-f412-67b2-5c34-3cd317128ec3@xen.org> From: Ayan Kumar Halder In-Reply-To: <5d369b95-f412-67b2-5c34-3cd317128ec3@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0206.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::18) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|PH7PR12MB6717:EE_ X-MS-Office365-Filtering-Correlation-Id: b9889e12-97e5-4eca-a5ed-08dac0b3df4b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ia8ZIPymUqbXBQHILMRAQGR3Ea1RFL5wtokpUy9K0gVPCAL9IgPJx5p3gqLX+PwhKGRl+1F40StdxAnYs3mdg9aUtAmZs9zvE47O4cA0Jd8jgJIbQAS+WyrMQaao9Xy1Q3DTs+7kRSiIlqaDTSKvY8kPYj7cJH6CnalEep5a1oZqqOOe9wXKwcrbwj4lLBgztPZ9dZDhg2+Rh0c+1vLPnT3xFTm1NrBGa47XZrfOUP9aKLC+FTs4n8vvrqBBQmJ7A3F9v+mqgPWh+VKl/+vsnVX/6iSOaeKZ7goBmr7Ob39v3aINvIokQiWJbD2wdcw8d59F3qUxvVfCgMsSuoVkUNDa0uZLHOMLPOw78bwwtdhWrmKcvk7xGDPbt3CeYQoncIMWduHHjGXEETpCWmZhHW/E3CjURuS5dwzs+5SsW5uZyxrWMygl6FdysxufvzesDWqt4YXsyY0+wCUTUc2S2IMOIxuKoVOP1k+5iA34e+Fi3ND504GwhufaTiY0nksTb0/9HDYBG78iXGtfHdX4qc81YV8h2XT+W4VPg8sV+UA7YTbVEsmWoJH7Hdy3KjQrB+iGZreUBGHHiQmbo7NRqomum9PUkFb2Xm0tLLKx64CUKUYvcKth3+D1HN90THIs28Pn/IB2wVXteSeqWJ0lULpBrXgha4JlFd5ehfGJUrWRSDXZAyxwVWb3bePcXx1KN0N+jPJC7sfZHd5jllfIw9r9doUQf5pFr4wEOaHys5Qz5VIb8AkR2g3zc14hTEGvaFwZqn7JwjYMQ6MzoC6MbobgIGLnl4nBzrZky/91TeY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199015)(316002)(36756003)(38100700002)(6666004)(8936002)(186003)(31696002)(53546011)(6506007)(83380400001)(66946007)(66556008)(66476007)(8676002)(4326008)(41300700001)(2616005)(2906002)(31686004)(478600001)(6486002)(6512007)(26005)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0xYNjJrdGtlcUZ2N1llNnM4UzBaUTc0RTFXNmowclZGeEpjbWx5WmpwaVNK?= =?utf-8?B?TTRzZkRqTTQzZkVBVFFEaDFXbHN1aUZuY2VvVldxdzh4ZjJtVkNMSHFoRHhX?= =?utf-8?B?Z0R0dFlxZ2hQbHNzT2cwMjdlWUtaa2RzcHZqK29zWG5pNTIrakc4ZGd0a2dW?= =?utf-8?B?SUlqVUUvMWpIcVVVTmY4dHBRYzB4VitlYXZONHBxMXlWTC80N3hQNTNVWFE2?= =?utf-8?B?S05XakhvT01ySmJwTEZXLzVEbENuakdyNHJHbVlxOGxJMnVUZzdGY0o4YUIz?= =?utf-8?B?NEZER3ZQdGV3blVaL3ZzYnZWWllGcnlQWkh3VS92WHA4WkhWM2xWY0NrOE1H?= =?utf-8?B?YWZ1clhidm8yTXlGTXBuLy9PZzJaQ0NkVTFTTzJ5bjgyQ01zZGJFKzlOVUxr?= =?utf-8?B?YmFHcWR4K00yNVlJcEhGY2EybnJVV21uTlpmaGo3UmgrRXVuUjRKOU5yWDBH?= =?utf-8?B?UUJUUVh1bmtHQmYxUFhnL3A2QlFabHRMVDNDckt3NmRwTTNwRGN6QzEwTzFD?= =?utf-8?B?YVlJM2VaZEcrUmx0WFZycjlCajdYRG8rdS9JRDcrVUxtak1SeUw1ZWt4T0ow?= =?utf-8?B?OFNMYTdnNXl5eDlJSTZuTmp2VUlTYU55QW5ISlp0MU95VUlxTndIaGRXNWNp?= =?utf-8?B?V09aTVVUSXVRYlQ1SkUwVmVxYjZzanp4a0Z3cUY4cS83NzgxRGNlRzgxOTZu?= =?utf-8?B?VUxvZ1BBYmtBSkp2VU5TMDlvYWh2UmR2S0xHZWE4ME5OM0ZmS2p6YkZwR0Iw?= =?utf-8?B?K21Jb2dEUEl0ckxBbkd1d3VyeHpDYkZ3eGpiVVdDZWcwaFdKYnAxc2RlbzZ5?= =?utf-8?B?Y2dwQllsaEZOVWVvdER5TUh3dzV0QzdlUC9mcDZuc28vRXM0b0VZY1lwOXZQ?= =?utf-8?B?bGNVUHFvaVROcm1qZ3NqZ01pMG9KMlpaQjhCbHlEQzVaOUVGR29WWjMvTkQw?= =?utf-8?B?SmsyMlBha25vUWo2WW5TU2s1bGhBUytDRXlPd0QrNlVxejdJZE1EUXVmWFc5?= =?utf-8?B?NHl2VEtVSmMveUhxbkpHaTlzY3VvNk1xd3V4RzUySWI1RzV6TU14TXg0bTVK?= =?utf-8?B?NUJoL2VZMXljUFZpNU9BYUgzKzRPS1h4ZUtpamFuVHdMaloxT2VwSTBVRGts?= =?utf-8?B?Q2JTMGdTTDhDT2FmcmprWGlkeURvcmdZZXV3Mkx6Uk9xb0RmR21jSUtMOFRh?= =?utf-8?B?bmxSVi9USUJkVUoybnlSSFhEZHliYkxkN0JLT3BwNkRHT1U4L29YYkJBMEpL?= =?utf-8?B?QVAzcERVYytJNDZCbGUwNTBlbmZmcjFTLzJuL1A0anVzZUhlVTBXRnpGeEFj?= =?utf-8?B?Y3RDRm5MaUxYN0tyb00rK21QdnZHN0pJdFA1OE9XN0k3RGozZkNqTndtanJE?= =?utf-8?B?blZDOFhLSHk5dFIzWlQ1OTlkTjZGZCtaTnZuMlZ5U3ExeExvSjJxczJ5MmJ2?= =?utf-8?B?TU9LNThOemdQVHUxVDFsNEFoYjQ1MFRXNFliVkgxYnRuK1RieEJKY09DQmZT?= =?utf-8?B?cGt5cVBOMVRMeU0zWGJmWmJQUGs4cTFpNk82eVVESFJJZ2o0VDR0VC9Md0ZU?= =?utf-8?B?WGpyazJucmlOSHhvY0JqYzNqTU91eUp5REl6cmZ3V0h5dWxVWjRuRVF3VDEv?= =?utf-8?B?a2ltdW9WQ0N6cXNpZE5UWXJ0dnRSa0JVb3VEVW9LMXlzZWtQYUVXT3Z6cS9j?= =?utf-8?B?VkdaelF1b1ZZcDBsOCt0VVhUTXpwYXJqalc0RStkRGlJNnpPNUh2dUpMRVcw?= =?utf-8?B?UitmM28vL1RXRGh6UFVBYXVCWncwN1VLdjRaTTM4SDU4VFNmakhFN0JUU1Z6?= =?utf-8?B?YVFUOWVoUkE0QzdZOEErZk5EVERxaUhEb0JXRGlDZEpINXpteXhWcjFZZExP?= =?utf-8?B?SUllSDU4ODNWR1gxd3MxVnRmcnUzSGxvb0NHUy9ITjYxNmNheVQ2MU9yU3NN?= =?utf-8?B?UjUyamFtZGlEMHFMVTkzQXJaMjA2QWhiS1A4TTBDQVNnd2tFbEg1Vm9yNWIw?= =?utf-8?B?RXNtWWRtbXl4YjQ4RG05cUJUZ1QrcmtKZXo4bnVkLytSdjhNenZrZFFObzhV?= =?utf-8?B?MGhQeVVzL2tNSDZXU1VqaW5CZFRDMURGYlR4dFNZekdqU095Q1ZINmNhcFlh?= =?utf-8?Q?njWSdqOFnyIn9xJVmNZoL6yWd?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9889e12-97e5-4eca-a5ed-08dac0b3df4b X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 11:33:20.6020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /wsJcHOQSXQ5aTgNwrudsJW50WdrgSGqopD7+pb2tniP9rd2jvMAdesFrVGqFqK0nuTwWB0Z1u+bFaJ5HzzE/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6717 On 06/11/2022 18:04, Julien Grall wrote: > Hi Ayan, Hi Julien, I need a clarification. > > In the title you are using AArch32 but below you are using... > > On 31/10/2022 15:13, Ayan Kumar Halder wrote: >> v->arch.vmpidr is assigned to uint64_t variable. This is to enable >> left shifts >> for Aarch32 so that one can extract affinity bits. > > ... Aarch32. The naming also seem to be inconsistent across your > series. AFAIU, it should be AArch32. So please look at all your > commits and make sure you use the same everywhere. Ack > >> This is then assigned to 'typer' so that the affinity bits form the >> upper 32 bits. >> >> Refer Arm IHI 0069H ID020922, >> The upper 32 bits of GICR_TYPER represent the affinity >> whereas the lower 32 bits represent the other bits (eg processor >> number, etc). >> >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changes from :- >> 1. v1 - Assigned v->arch.vmpidr to "uint64_t vmpdir". Then, we can use >> MPIDR_AFFINITY_LEVEL macros to extract the affinity value. >> >>   xen/arch/arm/vgic-v3.c | 10 ++++++---- >>   1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c >> index 3f4509dcd3..e5e6f2c573 100644 >> --- a/xen/arch/arm/vgic-v3.c >> +++ b/xen/arch/arm/vgic-v3.c >> @@ -191,13 +191,15 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct >> vcpu *v, mmio_info_t *info, >>       case VREG64(GICR_TYPER): >>       { >>           uint64_t typer, aff; >> +        uint64_t vmpidr = v->arch.vmpidr; >>             if ( !vgic_reg64_check_access(dabt) ) goto bad_width; >> -        aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 | >> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 | >> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 | >> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32); >> +        aff = (MPIDR_AFFINITY_LEVEL(vmpidr, 3) << 56 | > > Shouldn't we #ifdef this level for 32-bit? Or maybe check if the > domain is 64-bit so we are using consistently regardless of the > hypervisor bitness. We have typecasted "v->arch.vmpidr" (which is 32bit for AArch32 and 64bit for AArch64)  to vmpidr (uint64_t). So, we don't need to have any #ifdef for AArch32 or AArch64. Please let me know if I am missing something. Also, GICR_TYPER is 64 bit for AArch32 and AArch64. - Ayan > >> + MPIDR_AFFINITY_LEVEL(vmpidr, 2) << 48 | >> +               MPIDR_AFFINITY_LEVEL(vmpidr, 1) << 40 | >> +               MPIDR_AFFINITY_LEVEL(vmpidr, 0) << 32); >>           typer = aff; >> + > > Spurious change? > >>           /* We use the VCPU ID as the redistributor ID in bits[23:8] */ >>           typer |= v->vcpu_id << GICR_TYPER_PROC_NUM_SHIFT; > > Cheers, > From xen-devel-bounces@lists.xenproject.org Mon Nov 07 11:49:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 11:49:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439338.693385 (Exim 4.92) (envelope-from ) id 1os0dF-0004Oz-Vj; Mon, 07 Nov 2022 11:49:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439338.693385; Mon, 07 Nov 2022 11:49:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os0dF-0004Os-Ss; Mon, 07 Nov 2022 11:49:37 +0000 Received: by outflank-mailman (input) for mailman id 439338; Mon, 07 Nov 2022 11:49:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os0dE-0004Om-O2 for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 11:49:36 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2060.outbound.protection.outlook.com [40.107.105.60]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3ff272f3-5e92-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 12:49:35 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7536.eurprd04.prod.outlook.com (2603:10a6:102:e1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Mon, 7 Nov 2022 11:49:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 11:49:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ff272f3-5e92-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mTVDozjndCSY5vvdKAUNpKA0t1PtobWFV/D8ZHLroxtuFx+G9t39ywUWZT/mLgg7TXhqsRLAAc31uYaEpszmQdFq0WyihKrGqDUVhK3JRWVAh8ZPEEZZsd7/d7o9fx1qM1hY62LT/+6czQPDu+bc/06//yFToyNR+kGbDWD0o97ilbK1OXUMXyq7jGCGMFrtLdnfUurxwerxo9jE0ZaWDOk52W7KvSEg0QRR/6rvMKPKcDq3LE0UOEa5gXlPgs/pq52qAKIcvifFL5JUj97QNobAyoA8MYUPb8BoAOhvvizkk36owisfZgxXTT1UnpsMM2iQbF/viPMzHvjd6rLTEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7ef+jwvv2IpWFakg4Eh2FruhFQzZc2SqsHX4LLpA2As=; b=kCjj1zkCkyMJ2Jzw+4UBwmRD3vVVei16XEZVJcVxc7jD5NMMEw8T/h83c8Dm1e1tWCOqMGAahchbUhEbCwV4H7aER2aChSL9+HWyUny9jP7eSgMqjMqqKqSHcTvBwPWTnyyzrxEo5/URxQ3Sk1CPUYz+rCrWpkyTXAOkgmdyMMvxlSDBygzlaPeB7WgnQsZmJ5laGZOy1MqHWjCfrZusui1KSAaU8FPxi0/8Nj/wacemqCTxJSioP2p/P5XyDljJJY2CvLVodKjMgLCcqxJQsEle4hLjyRNRBos3ArNMXamVdoL1sgpNTGK1PI7Gct7wYhM7UaYrN7UcRmKh75U2OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ef+jwvv2IpWFakg4Eh2FruhFQzZc2SqsHX4LLpA2As=; b=BEMGN9EhEV4tZ+09Wgzc41PpVh1Eb9sADfNr13gYTcxO/bgoDQSylmmG5kpTrcm+FSd9LyZ3ULFLO7PzCm8uQJEK9XLV3R+TthGvbhSZ7OEJd9v4Z3Cg5fkddqB+nYD/4+HV1Pck0ozpY/CdJKyAiyMjnM0YLMTVkJSwPRhN+K6FtDvKjwem09dm/uUUQM+caujLhisOD3yVyAvjoQ3qllgkp2N/c0rw6mp8Ymw0DiZxBrrXzlzwxflhCpCziv/DlSpVeXePVJ46S1POX852iiJ12Pfv64OGutuYtBnGnfHTHlACgNuOTGQnsghtewaew4nQOIkk60oyDiTrixrEaw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5caf911d-e96d-39e4-d945-db6537412f60@suse.com> Date: Mon, 7 Nov 2022 12:49:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h Content-Language: en-US To: Luca Fancellu Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-5-luca.fancellu@arm.com> From: Jan Beulich In-Reply-To: <20221107104739.10404-5-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR05CA0050.eurprd05.prod.outlook.com (2603:10a6:20b:489::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7536:EE_ X-MS-Office365-Filtering-Correlation-Id: c0f23fdc-3ec8-49f7-cf99-08dac0b62335 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ra1Y5LJQgZ8XiSegDJrHMmClnrj9Zf3pHS2eU2Z3CsMaOUHbb4ZUTocYkP6G+gMatB+D5q+ZgapKeYU5XzBEZCY6er3/AS9E74AIkoYmAAB3Utn//9iqeyTQCz8Fa/Hxm1a4NXnTuHYqDI21lwC1MHVMMa+9Uv57gsk26n9B4JYZgaYlaDRl+Am7vz0oMOpZdKMhi+we8Q0RugVSlzSJN/P3/15EadO1MryhRtLGh95bGzpP0Ll5iZ1gnyQInvlYYtG/40h5BG1HUOxthtEu7S70S3eK5MXomCLUZ4dwYYmIRpL/04gX/oudGcNuoSJBdBhx/t6F0WNnkbdUNEAPin9zSrVhbHzM4q/jnqj3/IkHK6Bb+ueoSasn0Zx1uFZTvBKrX30I+wHJbQjEyYkP/0DvylKoiLOFNBVSLDgMNWEQWCJABzh8gPF3Z/NINFZSXg2xpSywsrcUrVqgJE0A6gRbl/WI9vsBujApUJAVcSgOffw1e4JmF5YGStP63dHPIy/ILkcXAb6BganYcajTncZ4MUCQJre6LnVwgUoWBYQz5T63jxqPwb7j/ktjwFcLT/EOcb5CT4A2k6m0QgYGgktiCNVufx+GE93FrdWr+YGpXdk1rUFnUgA8UJ5n3878f9p8QHA1n/KpAaxqe8bssTsBB3K+2vK66ObgKUJCdpKVDifwLcA0dBqEf9RRbPJngg5DPgV5h7gF3yWMHikCRrYL3jEE1n8AKoXpcGoZTQgAXLDpa8VOohFPJMdu0F/jD7oSmv49Mf4G0e95Oxms01DYThKGwuTspk2vozU73jA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(396003)(376002)(39860400002)(366004)(451199015)(186003)(66556008)(41300700001)(66476007)(8676002)(4326008)(66946007)(54906003)(6916009)(8936002)(478600001)(6486002)(2906002)(316002)(5660300002)(36756003)(26005)(6512007)(2616005)(53546011)(31686004)(86362001)(31696002)(38100700002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTJVWTBseWRkSjFiNUw2cDExdDkxZ21reEhmTmJ2ZUVZQXhCZkMwdE1BTW04?= =?utf-8?B?eldxWjhtakJIV2FoRkVjVG9NVFU2MTJabHpFcDI2bGZ6cXpQcnErK3NnaG9H?= =?utf-8?B?QjYySzRsSVhtUEJ2ZHdvZlFuTmJ4YTM4QmltYUtUaVNjd2swSTlTZEhEdklG?= =?utf-8?B?b0I5NmFwNXdFbWJzUlc4S1dHWHBUYmJvNnJNblU1Rk9GODEweklEWFVmbHlQ?= =?utf-8?B?bGo0V1EyRmNHVlhCTnU5K095MW9QT0F6ZGJKbFkzeGIxYVZFbU5mR0NWdDM1?= =?utf-8?B?Ky9RS0NPald3eVloN1g5cVVqQ3o5cEdsdkw4YUlrNEVrV2ZxY1d6eGtTMVhN?= =?utf-8?B?aCtpbERTOTBrN2xMWUVIYVJabU1FVFFmNERhOVpuOU83anN1RFJ6QzZrSFh1?= =?utf-8?B?a1BEVDFhRExjTC9BSzVOM3NJcjJsK0I2eXRrYU03SE5FbzJiRllFcm5NcWVO?= =?utf-8?B?b1dITkZYaDdBaW9XWWp1RCtTQmJHSlJaZVF0N1IvaHdnVFo1WS9GZXl5VWpy?= =?utf-8?B?a09ESW9ZeHJqYmx2aW10UVV4ZzBmTXhFWTRJeEZxWU5tUW85TGJBaUxRZjQ3?= =?utf-8?B?ZzYzVytQRG9BQlZUZVZTUWRROWZaK2psOFJCcGZvdnpqR1F5dEhIaERoTEJT?= =?utf-8?B?djQ4djZFd1YvYlZtd2RpSjQ5angrSG9xMlRVbGZTQTlycE5yRUZLTTZJWXVm?= =?utf-8?B?blVYWUVkZms2VUNNNndhSCsyb2E3UmtGK0ZkamNxYTh3UHJwbUlyUkdZeHRR?= =?utf-8?B?QThRY1Y5MzNxemoxRTBpSmY1RmZ3aEtyY280d1hzU2VqUEN1UjZzWHVvdGZ0?= =?utf-8?B?NG05dS90WmlvdnJsMk9IUjZZMVMyTytYQ0xJa3lGV2VhWkJIdTlvU1g3bnph?= =?utf-8?B?RGR6ZTlEaHRTZUoxYWhkbzRxN3poeGdXSjRIR0h1Ukx1Ri9QeHlCeXVlN0ty?= =?utf-8?B?cTJSOHhzb0dCWDBJbmI1QnhRTUZTakNDSUpQYTFqT0xHaGE5SkUzQWR6Zyta?= =?utf-8?B?ME5nZU5najhYalVwc1NXaHdIa2xjclFMQnF6L0xtN09LcTh3QzE0Vm5NQytE?= =?utf-8?B?ci93aHk1MWlhQWVwQTBrRnFNakhiVC9mL2REcllVUEQySEQxWmRXSmZ6ayt5?= =?utf-8?B?UXZ3RzJKcGNSNjMwUjUyUHhmWVFUM3NsSnNzeGhHNW5aV2I4SzlxNmRmQzlk?= =?utf-8?B?dWdrMERIc0N5UkJKcXVkR1ZWNCtLMmpOWUdNbzVubGljKzlTQ21vM25TWVNt?= =?utf-8?B?eXNrd3Arc3JZdlZOdzdZMmRwRTExVENmTVlXU0Z0amJ0VXZITklTTE5mU0FB?= =?utf-8?B?ZHhRWU9qS2s1MG1Rb21IbWp2VkRkcC9rd3dUcnFkTU84QXR0SWVldFREQ2tN?= =?utf-8?B?eER6bFhiYVl6UlQ3UXNRdUlaV2k1UFlQVFpsYmE2SGFTQkpKTG10RmtIVTRs?= =?utf-8?B?NVBxaTY4cTJNalFTNW9hY1lKT2MxbFNDVDRvUFB6bW1WRHRrVXlEelROdGRB?= =?utf-8?B?cnJLbGIxSlFVb3NuQXdSdFZJb2hlWWU0d2lvMktqWk54cHRqY2hBd2UvZ0t1?= =?utf-8?B?Q1dIWHJsYkZRbDZIVEVLU0RXTUF5OWNsaFhzU1o3YTg3RGczRXh2cThXekFX?= =?utf-8?B?bjE2QS85ZjFvQ1BERDNFRjB6bkk4aHQxMVkxNnZ6THNjVkZHZ2JwR1VoVlBY?= =?utf-8?B?MDhXSklvQnBJN3Jtb3FIM1ZiTWVPRkg1OWlYakx5blhQTzUrMFF6NS9LV3k1?= =?utf-8?B?VDJLWkxDNllJa05Dd014b0hGcGx4ZllnTUZaUm4zbE1OZGpIckVkMDdxUzRP?= =?utf-8?B?dXphbnd6THlhaVBFeVNTc3JyaTdwK3UzdUFlNGJYTVJLVWJXSm92M1pJeVk5?= =?utf-8?B?MkJ4TWNKT1VCTlNyUTgrL1RyZWluWXAzUjFKWHZidmV4YWc5YjltVlVjNUpm?= =?utf-8?B?eFJYMGNFd3FsNU9TM3BKRDRwR25ObHh2Z2pzQ0FBKzRuTnBtME1Nc2RFVmF4?= =?utf-8?B?d1dHRzNUVXdoYWkwbTU4NkZlQTZZRmM5SU42RjNmVndjRitDR2xLeXVLbHB1?= =?utf-8?B?eHR5QTA2TWhBMzNPeEluQndWNzZFYkdwOWVjcmdLWktHdVZsNlNyWWF3VG1o?= =?utf-8?Q?5C1HFbErgJzb1WP8aVeqkuu04?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0f23fdc-3ec8-49f7-cf99-08dac0b62335 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 11:49:33.5218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x5X0kBNOuBBC7UiA1Hy28HVMNIQaxQ3CPFqrE2alqegQpCue+Tsx9hcrtgAxeVX2EkizLJ//88TDqxUgBUTuVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7536 On 07.11.2022 11:47, Luca Fancellu wrote: > --- a/xen/include/xen/kernel.h > +++ b/xen/include/xen/kernel.h > @@ -65,24 +65,28 @@ > 1; \ > }) > > +/* SAF-0-safe R8.6 linker script defined symbols */ > extern char _start[], _end[], start[]; > #define is_kernel(p) ({ \ > char *__p = (char *)(unsigned long)(p); \ > (__p >= _start) && (__p < _end); \ > }) > > +/* SAF-0-safe R8.6 linker script defined symbols */ > extern char _stext[], _etext[]; > #define is_kernel_text(p) ({ \ > char *__p = (char *)(unsigned long)(p); \ > (__p >= _stext) && (__p < _etext); \ > }) > > +/* SAF-0-safe R8.6 linker script defined symbols */ > extern const char _srodata[], _erodata[]; > #define is_kernel_rodata(p) ({ \ > const char *__p = (const char *)(unsigned long)(p); \ > (__p >= _srodata) && (__p < _erodata); \ > }) > > +/* SAF-0-safe R8.6 linker script defined symbols */ > extern char _sinittext[], _einittext[]; > #define is_kernel_inittext(p) ({ \ > char *__p = (char *)(unsigned long)(p); \ Why the "R8.6" everywhere here? Didn't we agree that the in-code comments should be tool-agnostic? Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 07 11:53:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 11:53:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439344.693396 (Exim 4.92) (envelope-from ) id 1os0gy-0005nd-F6; Mon, 07 Nov 2022 11:53:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439344.693396; Mon, 07 Nov 2022 11:53:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os0gy-0005nW-CK; Mon, 07 Nov 2022 11:53:28 +0000 Received: by outflank-mailman (input) for mailman id 439344; Mon, 07 Nov 2022 11:53:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os0gx-0005nQ-Gu for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 11:53:27 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062.outbound.protection.outlook.com [40.107.22.62]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c8aa9811-5e92-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 12:53:24 +0100 (CET) Received: from DB6P195CA0012.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::22) by AS2PR08MB8286.eurprd08.prod.outlook.com (2603:10a6:20b:555::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 11:53:22 +0000 Received: from DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::de) by DB6P195CA0012.outlook.office365.com (2603:10a6:4:cb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25 via Frontend Transport; Mon, 7 Nov 2022 11:53:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT022.mail.protection.outlook.com (100.127.142.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 11:53:19 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Mon, 07 Nov 2022 11:53:19 +0000 Received: from 28341e60ad05.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5337AEC4-47EB-4985-B3B6-AB45161F21BF.1; Mon, 07 Nov 2022 11:53:12 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 28341e60ad05.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Nov 2022 11:53:12 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AS8PR08MB9648.eurprd08.prod.outlook.com (2603:10a6:20b:617::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 11:53:10 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893%4]) with mapi id 15.20.5813.011; Mon, 7 Nov 2022 11:53:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8aa9811-5e92-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=eNCSNHWW/oy0QCNfk+EIIvJ3J9U2sodAPJWYU/2ilHotGkEk199GwtuymeiVzatIsarzUuSSIX91QJ+VuMO10/suinPBJiqcFC7v01+MHcY6XzHpMKPxlYS1qdmsZ+Lg0lcWKuo4dkdksLHe0fe+Dz8+ElRthh4sT8GZog3TsRyPUc7TCWaoldr0xNLKVvTk8n3mYT8ieAWACqoCqMEKwpxi/+UEQfhGgRfirIxjKNpPuASMrlbN/2EvvQo8upDktjW0wjc7rflXhW/4Ulvo+4GR8sPFWLFNG7QTTg3wh3XNldo99fsVk0y/lER3WIlPJp264Z2GyU1qbOJh99dcNQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RHjIOY1lQCDI06OJXzFqzGEEUHu6UGB33E623c5gWuA=; b=P8NFSBknvabDudjypyMoX0vexGuw5XSxnkm493S7ki9btIip2CsGAteoRph7MamTseTHZzUy+NEH3MokAfQwHvWRjPik+xYs1z/nZaS7YIR5MQZYhBkukDsJ2LcD32IRDHsQVf+wQzjwBfwRjNiy1UMIE54Ucj4vcxZLKDklhVTVoLSrsalzDtWAPj3tAvKRlniJ4MSvGRoZKwDezkuYa5rbGOO2Y0uMAgPUtP3LfCZjelgBlZn93Jpq6Vxc07fRnrvqEme/pzT0NC/3g4hk6Uj76LbZhzmv2Hxo98PaQOWHogzMv5XluX9XMtfMlJ7WZzfrMe+hspL1+9qtIPoMAg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RHjIOY1lQCDI06OJXzFqzGEEUHu6UGB33E623c5gWuA=; b=QX6IYNZVAajiqzo6A5gLDSzNiY8IVTMW2dSgjPFbypJGgyo1Zd2zp3vfOFxw/RoGAKSCb5pSxtQWIuw6RmSwAjWXasTdLCLS1ilLCVmRfAQRH6N4i7sSl+mSlV+plimspbufmFyPU21hUs4La0edfL9Fxmbbq/YF2n1MOWhXBtk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f9d9122aff0fabae X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l+QB0d6G9qsJNGJRgNO8uDpQHandlJa0I0oJuLBeX7QHWVfgq0y439wY21W8JnEEVPu0qK+c1FGam01EAbf6r4nxUncQEDt6FhlciLD1d+qUl8Q6rIqr9QrBlOZHOyFSfwgdWQGijWjDTbDPPLl5VtY8zbhL3FpN2oCaLZK0HOEUPsRfa5FohXBqjmsCD2bZ7Nb96IlxREE8YG+t+TStMocwCs6S3dDk/kwxer6dZf+apdjbVBMlTA5R+q81l38ZUxklVuPaqgANpddI4+a4KJaJ9uPg2QaO2gJv8+an+ss+Vq2rCNPpWB9Z2RgOo0/ekb3vaxQB9STWrxUaJsElyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RHjIOY1lQCDI06OJXzFqzGEEUHu6UGB33E623c5gWuA=; b=gif6V1WQIyJlZ94W7WjxnjKsmn+lXkU8pRCaATN0Ew9gTfqhx11RGEE/6FzBPpQxwFFEEa3T9ViwDRCgfOHgESnbKDYlcIHmcfCs0qCbkIMXazLSMnjA4hJkv7AaL4XVEvqkOh/h05+EiAZcntO1IVttNs/r+PfTkouJ/K77r3qIlrDQrjLgV7vh+WSgTFPayz/t+7ZStMVb8XTXgGRwaR684XooH49v6WM9t3FGBVNoaZD8KB9YniiEylXOsgXJqLf/hBM8xQn7clzJihi3xO11E3GKvA9xuVVZUKeicrQZxY2aKHALA4u/sVSaB0RZT+uNxm34CK5lQNGYu/xcwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RHjIOY1lQCDI06OJXzFqzGEEUHu6UGB33E623c5gWuA=; b=QX6IYNZVAajiqzo6A5gLDSzNiY8IVTMW2dSgjPFbypJGgyo1Zd2zp3vfOFxw/RoGAKSCb5pSxtQWIuw6RmSwAjWXasTdLCLS1ilLCVmRfAQRH6N4i7sSl+mSlV+plimspbufmFyPU21hUs4La0edfL9Fxmbbq/YF2n1MOWhXBtk= From: Luca Fancellu To: Jan Beulich CC: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h Thread-Topic: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h Thread-Index: AQHY8pZ4QA3C9Pi6Y066NaE9A9ULoK4zWNUAgAABAIA= Date: Mon, 7 Nov 2022 11:53:10 +0000 Message-ID: <3925276F-8B6E-4B19-9EC2-C085FE88A637@arm.com> References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-5-luca.fancellu@arm.com> <5caf911d-e96d-39e4-d945-db6537412f60@suse.com> In-Reply-To: <5caf911d-e96d-39e4-d945-db6537412f60@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|AS8PR08MB9648:EE_|DBAEUR03FT022:EE_|AS2PR08MB8286:EE_ X-MS-Office365-Filtering-Correlation-Id: 529cb98c-8523-43c9-1d28-08dac0b6aa20 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XeKYHDNKXLjceZZAjpNjEBNawUp8KBnoqmmfHKqGjtair8S8Bmh+afJ4ATMv3i2ocJOw7LP4vUABiov+cy5E8Hm1I3nhESVPEaxTZVf/WQClLNkABJfaMtGyKOlAY0i58zM5esksFR2I94EH5SdOR2ZV+AEPJEmg2j87EIHWLshXMe4hxHVeZOYBrj+/YuvHPv99GqCy0q9gm9YcYYY0FxR3jAvYp/I7dlXHDr/6uekftlixwnNpDs8lPq/MSrtahZmtgXqkiaSekmra1mi0bkXQ08BcLqQkZcoNOxlXskIpWj3EkA/79HEwBuiggID4D7LwghQv4vo2N13mmTo4yIsvw9rUHn/kjGlr188DbHwwgoHJJt8TMxlb6EY3EOvT85TddhCYqJVr8FrCoxcyYoBbXQV6DHAjXMS9s0o0+3suVtlKt9DqzfheHveHqUIDwFWBN76oCAPs2X+XUNCwx48Mu5RJOHYGJNBUCqxeBPgy9a/vMyvUV/M3XqOQ3CMbBDahjo3Q3Nv4HqhKlR/zw9qIZIfy4ihwZNBSUO7GlozD3qVUEZ1vNaNNs0XayVMM93E44IxMzBi2KnMgk7yH/NIuFrujSvDlxS+p4nAXUS+BjYT9A5/xoAydyAxjUW2CwS4+ae+dL5yBCJUbeTI6fQUGWcPOAKW5fKbiI9M7K7xKf2ZlP9dR6c6Dvnye5u1s+X4BtJtH3WouohOBlLZMmchK80JQc++6xCGIUyJkierRlw6+Kfy2XkDNqfIUqgg3hb341hhUDZSII7lPcWvTQX50I9ayXZo2Cuo3+XemH6w= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(376002)(39860400002)(366004)(451199015)(186003)(66556008)(41300700001)(66476007)(66446008)(8676002)(4326008)(66946007)(64756008)(54906003)(6916009)(38070700005)(8936002)(478600001)(71200400001)(6486002)(2906002)(33656002)(316002)(5660300002)(36756003)(91956017)(26005)(6512007)(2616005)(122000001)(53546011)(76116006)(86362001)(38100700002)(6506007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <975DE91281A42E4887C8667EA76214BF@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9648 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a89277eb-7de4-46bf-eb1a-08dac0b6a4d3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: upXeqTwcLhi8ByGKHN45yYieefSB4Iqv9vmO9o5MG9/pPDSzT/4rQ8PmDBcM0VQEfngIFr+MxiT+a3VWZT6rPsQ1eMgbGWIFbMUKy8/R7xw/w5VN5O1oPZM4ry2YGTSKVMYGXKj0oiLFQE6hzj7Fv+Lcn1vaLBL3Ak94/rlefFQEBRIZil7qpyYx1fcvJH0sAN3BGtkyh4AtNRPvP180olZbT6FUqSNCZa5ZTzY0mPDWv512n8qa3aVxlBaTrRXciB4bxkXBjPptqEGXQ0WlEH/a9quyg2IJrxajGeG4UYMkAFmy6gUSzFWQVtIo2jZqeZi+SMXODwVdhZQl4lcm1BEr+yfzbN6KAsxAEXFuQLRz18Bv8IqAJzsGlaJcgHv+6AL9mhN7Fgu9CZqlXbAfs+2UUIq/PMo/uju0clqv+6mX8A2Yvq/pdpO7+1GbtR2s0oqXyMYOHRzUdVznxnG4gcPnoPlSZVeb37AO9C5bJPnVsW1S3t32eTr3wykf0gi9+SXje/KQOnpmhA4VgvTNuJ9QEHjtcLc+MSqF7LCI6AkD71cf/GZvWfl8U6FmYAA2Gu2AkWFnI0A08S6f04Of/6tZFOgrDods0nHpObI7RBi+KYq/KsgBG6jWfGgzNWYCrffagUyUfCbrDWCEYBnmLuRZEtUkYBpQiDeSQ1E+d1vFCVpnWh+x9EDgGtzqEb54s673PQ2lF0Ho1suQZK8MUhvVG2xvnrjBT9grmlBBur+2PdZdP0Fq1vJ0iAfhzc55NkRPbow8kbp7laZm39vAEQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(82310400005)(36756003)(8676002)(4326008)(33656002)(54906003)(70206006)(316002)(70586007)(81166007)(356005)(5660300002)(40480700001)(8936002)(41300700001)(6862004)(6486002)(478600001)(2906002)(2616005)(53546011)(47076005)(6512007)(26005)(40460700003)(336012)(186003)(36860700001)(82740400003)(86362001)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 11:53:19.7002 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 529cb98c-8523-43c9-1d28-08dac0b6aa20 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8286 > On 7 Nov 2022, at 11:49, Jan Beulich wrote: >=20 > On 07.11.2022 11:47, Luca Fancellu wrote: >> --- a/xen/include/xen/kernel.h >> +++ b/xen/include/xen/kernel.h >> @@ -65,24 +65,28 @@ >> 1; \ >> }) >>=20 >> +/* SAF-0-safe R8.6 linker script defined symbols */ >> extern char _start[], _end[], start[]; >> #define is_kernel(p) ({ \ >> char *__p =3D (char *)(unsigned long)(p); \ >> (__p >=3D _start) && (__p < _end); \ >> }) >>=20 >> +/* SAF-0-safe R8.6 linker script defined symbols */ >> extern char _stext[], _etext[]; >> #define is_kernel_text(p) ({ \ >> char *__p =3D (char *)(unsigned long)(p); \ >> (__p >=3D _stext) && (__p < _etext); \ >> }) >>=20 >> +/* SAF-0-safe R8.6 linker script defined symbols */ >> extern const char _srodata[], _erodata[]; >> #define is_kernel_rodata(p) ({ \ >> const char *__p =3D (const char *)(unsigned long)(p); \ >> (__p >=3D _srodata) && (__p < _erodata); \ >> }) >>=20 >> +/* SAF-0-safe R8.6 linker script defined symbols */ >> extern char _sinittext[], _einittext[]; >> #define is_kernel_inittext(p) ({ \ >> char *__p =3D (char *)(unsigned long)(p); \ >=20 Hi Jan, > Why the "R8.6" everywhere here? Didn't we agree that the in-code > comments should be tool-agnostic? The R8.6 is not tool specific, it is to give the quick hint that we are dev= iating from MISRA Rule 8.6. >=20 > Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 07 11:54:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 11:54:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439351.693407 (Exim 4.92) (envelope-from ) id 1os0i5-0006PQ-UI; Mon, 07 Nov 2022 11:54:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439351.693407; Mon, 07 Nov 2022 11:54:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os0i5-0006PJ-R0; Mon, 07 Nov 2022 11:54:37 +0000 Received: by outflank-mailman (input) for mailman id 439351; Mon, 07 Nov 2022 11:54:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os0i4-0006P9-D6 for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 11:54:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os0i3-0005Fl-VW; Mon, 07 Nov 2022 11:54:35 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1os0i3-00088b-NP; Mon, 07 Nov 2022 11:54:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=qoXgA//QWzlLMIhbTutfZd8aVjPHlcYkrxUcyHqp0Eg=; b=v62//OU0tgYqSDeAkJukkce9F3 OXyUHqnhR/xUgT1Y9o5qlICPZWm8Fed+IrVcnRuEonSyIl9986AUspAt/RQjtQlk46PXViThzrWQZ emy9OOSM2fQ+awrAs+jRqSv/nBesBHv09wlhSbtdzFVXXyASdvfjDTBITNMIys3rxwb8=; Message-ID: <8bb1c421-2dc5-cdbc-94f7-6ea09f2d64fc@xen.org> Date: Mon, 7 Nov 2022 11:54:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32 Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-5-ayankuma@amd.com> <5d369b95-f412-67b2-5c34-3cd317128ec3@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Ayan, On 07/11/2022 11:33, Ayan Kumar Halder wrote: > > On 06/11/2022 18:04, Julien Grall wrote: >> Hi Ayan, > > Hi Julien, > > I need a clarification. > >> >> In the title you are using AArch32 but below you are using... >> >> On 31/10/2022 15:13, Ayan Kumar Halder wrote: >>> v->arch.vmpidr is assigned to uint64_t variable. This is to enable >>> left shifts >>> for Aarch32 so that one can extract affinity bits. >> >> ... Aarch32. The naming also seem to be inconsistent across your >> series. AFAIU, it should be AArch32. So please look at all your >> commits and make sure you use the same everywhere. > Ack >> >>> This is then assigned to 'typer' so that the affinity bits form the >>> upper 32 bits. >>> >>> Refer Arm IHI 0069H ID020922, >>> The upper 32 bits of GICR_TYPER represent the affinity >>> whereas the lower 32 bits represent the other bits (eg processor >>> number, etc). >>> >>> Signed-off-by: Ayan Kumar Halder >>> --- >>> >>> Changes from :- >>> 1. v1 - Assigned v->arch.vmpidr to "uint64_t vmpdir". Then, we can use >>> MPIDR_AFFINITY_LEVEL macros to extract the affinity value. >>> >>>   xen/arch/arm/vgic-v3.c | 10 ++++++---- >>>   1 file changed, 6 insertions(+), 4 deletions(-) >>> >>> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c >>> index 3f4509dcd3..e5e6f2c573 100644 >>> --- a/xen/arch/arm/vgic-v3.c >>> +++ b/xen/arch/arm/vgic-v3.c >>> @@ -191,13 +191,15 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct >>> vcpu *v, mmio_info_t *info, >>>       case VREG64(GICR_TYPER): >>>       { >>>           uint64_t typer, aff; >>> +        uint64_t vmpidr = v->arch.vmpidr; >>>             if ( !vgic_reg64_check_access(dabt) ) goto bad_width; >>> -        aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 | >>> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 | >>> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 | >>> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32); >>> +        aff = (MPIDR_AFFINITY_LEVEL(vmpidr, 3) << 56 | >> >> Shouldn't we #ifdef this level for 32-bit? Or maybe check if the >> domain is 64-bit so we are using consistently regardless of the >> hypervisor bitness. > > We have typecasted "v->arch.vmpidr" (which is 32bit for AArch32 and > 64bit for AArch64)  to vmpidr (uint64_t). > > So, we don't need to have any #ifdef for AArch32 or AArch64. This is not related to the typecast. This is more that fact that affinity level 3 doesn't exist for 32-bit guest. For instance vpsci.c will protect level 3 with an #ifdef. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 12:49:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 12:49:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439379.693418 (Exim 4.92) (envelope-from ) id 1os1ZN-0004nu-2w; Mon, 07 Nov 2022 12:49:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439379.693418; Mon, 07 Nov 2022 12:49:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os1ZM-0004nn-VS; Mon, 07 Nov 2022 12:49:40 +0000 Received: by outflank-mailman (input) for mailman id 439379; Mon, 07 Nov 2022 12:49:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os1ZL-0004nh-8K for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 12:49:39 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2069.outbound.protection.outlook.com [40.107.102.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a21d80be-5e9a-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 13:49:36 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CY5PR12MB6527.namprd12.prod.outlook.com (2603:10b6:930:30::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Mon, 7 Nov 2022 12:49:32 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 12:49:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a21d80be-5e9a-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VG2JKDT6DIwxYUEHxUD91w0ZaGAmITDo29Hiw09NbIrj07ikA2vbbDufPeWDbs/fhc3NqF5ZWkTE3yX2UuwLHQX4JthxMKwOv4MT9WDwLpRNwlhcM3fF34i2y3kJ6nU6CBGC54v4IQYScPQTrmDECTkO1+WgEYtyKdg8gWeMvOAwqCOuUUoRZiOZ2JUAk9rAGeQ0EDRPC7MNW061WIv9leYjnWZx9FyXgoha0CaxjoWH28ix2qHlhDghJfyL4vlW1+vQzaNWRYR3BMPERHPUA4XoVM2JOJn1Mk4nMEfElNRgbqH0MTpJGL7fw5a8So5vHo9pbGcwCvCEyi72ldMpuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UITH3pPH1dVUoCM8Kj/tElqVfTF+vparNAHDqJ+glHk=; b=i4F4bCcjy1x2/IVOLwgHUgKJgixGMx5E8dWXC8Q3eFGxaClMlas6KCr/Ju3kNDcn8nD+vgY3LZE2xIDHhVHN7UWtX+4mJo22/409NDx21QwZjfwu1/rM7IL9vmDN2Us7wgUOIdW1VpyxAqjPUirwT0hrjXB1dpa2Q+/bwD5bNNpRKVMRvQNnhGd5xWPCmz9waOLKYqpHMdk0u0gR5FHbRPrmNwpqAFZoXpK1SLyda8hwz+Vj67ijW86Ry5FZnUgPtQ0AkpKsHMqH7PEcrdzkPqXHCYhk1OZ/xUCwG4x5J8I3VtQwHatc6CLfD6JNTIxYigKJ3U9NFqdexKGzPyi+lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UITH3pPH1dVUoCM8Kj/tElqVfTF+vparNAHDqJ+glHk=; b=YmSM+Cp3QJEv/sz5wUnYxOlsW3QylvIs+kyY1Lx3P6s4yU+33ut7N4rYQ9sCsqfonZafEepEjwo/tpDc3rpEUW8p2P+6q98GeDSy7OfpHyrWomcI9I+fH+sLYFg+Q8DAlWUSJ6ehlRS/20PrXTOAxtOFyFMy4KIhgQlJM0Vxpzc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <36e84512-9b44-303e-2834-5aafe9c6cc15@amd.com> Date: Mon, 7 Nov 2022 12:49:26 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com References: <20221104162355.23369-1-ayan.kumar.halder@amd.com> <062c9507-7744-0742-effb-76d2f1222a27@xen.org> <33a2d125-b7f2-3637-9dab-6b7d616fd4ff@amd.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0276.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::11) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CY5PR12MB6527:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e77b61d-1dc1-4fec-e87b-08dac0be8440 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p1bF+TqR2ENJr/Uor5OGhk6zSJXRfDMNhBAGUpVQvBDYLum6gQmerUwqMoZFP0xNJxc0g4tCjtMqcwEFQS7x0bgUIseS1GzLGrB+1dpcYKX88gFZTNGY543rwh7XuEKnIl1yLmfkbhT0PplkQCkimBv7R91Fz9Jbzn73X1cRkyEIi1hGiPMDtoK6YhLjQCy4cSRnkI3wPdWawW4zvlZz+cwqi+aZoCBk/XY/xWPJXz/M+VPdSpWTKfz3eVLm6Q/NjNioQOhpPLmarlhgXrj3pnGA9+98Y8CS7A2IHnEdkbLBifwcbW3MQUY7aCrD1Rf3HyPimYFEbRDJ1xJtQ3DXa3QU7hmc2GslAWiOHCHo6D16wlAKV9NY02DM38+Abz1jwji9X0UKCDXQPfxIOP+dF+BGkHvFKs8yfMcTMlnu21rTBch9bV0bi2UwS2ZCDWS++/FpTlvPz3D+9LeGX8lN0dcFO1x00VJ1XI9humAOWNgMrV4dbqTk+70eo4/vUlsZI2X+wRbwdJnt6Vu9kCZiq1/YDqeizTnxKTGDsu0lXOl/Sx6MCyuwlbNp+Xuck+7JSCRkuOKdqXcCYDdol4NH0FLtIIGKbeq3w3RkEbOjVUupUOlWl+pxI7cGd9tILpxquQpHM1f4TEFZfYeh7oYyeCvSF/TXsemwGo1c/3YgZ+fQWAj9E/sbFD8mTT5kl4ASyklrwbGXzceke887TJ7bKTAOqdxdkhORj3VpqpEv+3DL5Fk/tnc9pjSkT9Vym5b7aRIp8StwG1GlDAHF+z2v5yAkHFoE8uxaJS2bhR1m1W8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(451199015)(6506007)(6666004)(53546011)(26005)(6512007)(186003)(2616005)(38100700002)(83380400001)(2906002)(8936002)(110136005)(6486002)(478600001)(316002)(4326008)(41300700001)(8676002)(5660300002)(66476007)(66946007)(66556008)(31696002)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTJ3Z3REVnlQeEp3K0U2NHovUVpIdE9YamhlVmhkelRxR29wR1NkN3dmUTVW?= =?utf-8?B?U0RNckw2VXY0WnB0Z2N0RHpiUUw5Z3oxbzg1OExzR3RsVEpPZS9YMzVzaS9H?= =?utf-8?B?dHhkRGlpOEJhRTc5UXhqTmpDMUI3MGdTTmtwKy80c2E1ME1abThkTW5jL1M4?= =?utf-8?B?SjJ0SG9XbXVSZGJCcis4Ui9PZERpOGJRbm1IeXQ0VVZuUnZuTTJPVnNoZUVB?= =?utf-8?B?MWtrUWh2YUxFQ1pXWGxGakJ6ck5KeFVwbFNPZ21hZVJUMW5CN2NnUE01d05l?= =?utf-8?B?Q2M0Z1plRUM5eUo1VHRkMklmWTk4Z2ZXRDltUG5kNU9GNnJKeXlENlJCcll2?= =?utf-8?B?eXZmbDlSSmNUeEFsWGRzM3ZFSThBMUU3SzNJNWpJODh0Z0RybnFwMFo2S1Bi?= =?utf-8?B?TVVPdEo2WmErMGlPOExvRFZzOG1CVVcvRm1RMmR6ek9XTWpCMzQ4VUtILytL?= =?utf-8?B?KzZ4VDlwenhsS21ZK2lKbWptWmljN0lSd25Ca2d6ajQwb2RjWUlMdDVrMVlr?= =?utf-8?B?bGNia1lXS1Rld2wxM1dxdDZYTkUrd1BLUVpPTlorUHp2eXNjTXpFZjQ5WDg1?= =?utf-8?B?ODlaTXpobDZYRENFT1Bya0VmdHBIbitpQXFzT2RZYlJGQlNEVW1jZXpwZEVN?= =?utf-8?B?MGJmbXN5UGwvR3ByNmtac0FsTUZiU0k2d1hUTjMwVm9Icjc1N25weGk4U295?= =?utf-8?B?ajhuUVhEbHV2VmJMOHhBZE9jVnl6U2l2YUpBazJJVnFXZ3ZYT0NVckVxVHlp?= =?utf-8?B?V001QW1oRlhOL1phaFVkVHpBdHFEd2pyVy9HVGsyYU1qMUpoU094ZGc1NC9h?= =?utf-8?B?em5GNW52UFVMV0tNOXF2aWNCQjAzek1XUTJIUFhKMGMvUTcrdjB6VDg1MVBs?= =?utf-8?B?RVdhdFppMmNCSEdpMHA0aW1EY3dPcSthakd6U1ZOSmUxOU1FRWxVbFhWMFR1?= =?utf-8?B?T29qWkc3cmJYeXl2dmVsUlhuRVZmSit2Y0FrMTRZMSsveVRqWW85cjZiellz?= =?utf-8?B?eXhPYStZSExVVzBFaFlMNTgzTjBQM2JIajNkR1dnTXhwM2lOVHdDZU1iU1Iv?= =?utf-8?B?SGw5bGgvZG1jZGpIb05zRFVZdnc1RTJSclE2bGZEZ2JGSHBBVktRRXpJUytQ?= =?utf-8?B?NXNHc3NOYWoyVDAyZG5xdFhxWGtLSngvM0J5VFk5cWY2L2VaSXVwZ0I1NlVs?= =?utf-8?B?aGF2ZWlRTHZXMFJUcEh3VVBQRVRRYnFkSVdBUWMvSHlsTUJFV3FqK2lZcXpS?= =?utf-8?B?ZmlVUC84MnN3VVZmeG9COGt3Y1YyRUhaSnh1SE9NcWFwd3N1R056YXBDaHpx?= =?utf-8?B?amREd0FSRVBFM3M4OElOYSs2WmVnQU4xcGZLMGM0QnVTNjI2NEpEelpVbXdD?= =?utf-8?B?cTR4Q0F6RTVtVkNkUXdBOThpSUxKQkdKb0xDRnJ6STd0TGJqc1R1SlIyWFFs?= =?utf-8?B?NER1aExhTUpJTnFyL2NLdG55K3N0dDFZL29tMUpXQ2RIMGdoU0lBYitvVUVD?= =?utf-8?B?NEJxNHpxWW92aEl0MUhNdmxnVXdtZkVwRWh6SDZlWUNlalZGRGhlcXlTaGtX?= =?utf-8?B?cDgxY3RMTUJISmxYZC9DNXFudXdHZ0hQeTRsQkN2Wm5uM3FzNVpKWlU5T0ZN?= =?utf-8?B?eC9PL056Mk1SeVhBWVdCY3FqK2tjOGFhVEluOUUxQUxPenUrL2V4Qy94d2p1?= =?utf-8?B?Q1RVdE9kcThVdVhtYy9CalpHbjIxODJ5UVVSU0lISlNrcDMxa3VWYWZhQ2Fh?= =?utf-8?B?WW11LzRkMjRGajh6TFB6WVFPempNUDNidVV4SWdwSmRGams4R3lQMUxQbGdv?= =?utf-8?B?YWFnYVkvdVJWZXZlbzNZU25HZ21oNFgxeElLU2RWY0hudzNVMXk2NHcwR0hF?= =?utf-8?B?UlM4U3B3VGJ5L1RmMzJSZS95cXd2Nk9qZG9sZEg2bHV6QW9Vc1VQU0pKMU1o?= =?utf-8?B?bE5kbkFaZkxQQ1dhSTR6bnc5ZGl3L21DUnJWK1hDQkJFODVkWlRHUE5XZmk5?= =?utf-8?B?NlMwT2xhRVRhQVZxd2NNNVBXdFVCdEJyT3NCMUxGWmFMdDJEQkFsbnhMS0FV?= =?utf-8?B?dzQ3SjJuTk1zdUFFRGhKVUJVeTh0TGZFSlVTVktta1FtcjRUSlN5MEhibVE1?= =?utf-8?Q?HzZYIsM26V+ikBhQc9CE33S9a?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e77b61d-1dc1-4fec-e87b-08dac0be8440 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 12:49:32.3699 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: szSp2wtex63f5Ow3zxb+KgEmf1fDIzEiRb3H3pF0Qxgs7vzj7Tef1Dm/j8DFy/IFpKOd5mkXOL2VPjw2Ug/AOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6527 On 07/11/2022 10:44, Julien Grall wrote: > Hi Ayan, Hi Julien, > > On 07/11/2022 10:36, Ayan Kumar Halder wrote: >> >> On 06/11/2022 17:54, Julien Grall wrote: >>> Hi Ayan, >> >> Hi Julien, >> >> I need some clarification. >> >>> >>> To me the title and the explaination below suggests... >>> >>> On 04/11/2022 16:23, Ayan Kumar Halder wrote: >>>> From: Ayan Kumar Halder >>>> >>>> Refer ARM DDI 0487I.a ID081822, B2.2.1 >>>> "Requirements for single-copy atomicity >>>> >>>> - A read that is generated by a load instruction that loads a single >>>> general-purpose register and is aligned to the size of the read in the >>>> instruction is single-copy atomic. >>>> >>>> -A write that is generated by a store instruction that stores a single >>>> general-purpose register and is aligned to the size of the write in >>>> the >>>> instruction is single-copy atomic" >>>> >>>> On AArch32, the alignment check is enabled at boot time by setting >>>> HSCTLR.A bit. >>>> ("HSCTLR, Hyp System Control Register"). >>>> However in AArch64, alignment check is not enabled at boot time. >>> >>> ... you want to enable the alignment check on AArch64 always. >> >> I want to enable alignment check *only* for atomic access. >> >> May be I should remove this line --> "However in AArch64, alignment >> check is not enabled at boot time.". >> >>> However, this is not possible to do because memcpy() is using >>> unaligned access. >> This is a non atomic access. So the commit does not apply here. > > Right, but your commit message refers to the alignment check on arm32. > You wrote too much for someone to wonder but not enough to explain why > we can't enable the alignment check on arm64. > >>> >>> I think the commit message/title should clarify that the check is >>> *only* done during debug build. IOW, there are no enforcement in >>> producation build. >> >> AFAICS read_atomic()/write_atomic() is enabled during non debug >> builds (ie CONFIG_DEBUG=n) as well. > > My point was that ASSERT() is a NOP in production build. So you > effectively the enforcement happens only in debug build. > > IOW, unless you test exhaustively with a debug build, you may never > notice that the access was not atomic. This makes sense. Does the following commit message look better ? xen/Arm: Enforce alignment check for atomic read/write Refer ARM DDI 0487I.a ID081822, B2.2.1 "Requirements for single-copy atomicity - A read that is generated by a load instruction that loads a single general-purpose register and is aligned to the size of the read in the instruction is single-copy atomic. -A write that is generated by a store instruction that stores a single general-purpose register and is aligned to the size of the write in the instruction is single-copy atomic" Thus, one needs to check for alignment when performing atomic operations. However, as ASSERT() are disabled in production builds, so one needs to run the debug builds to catch any unaligned access during atomic operations. Enforcing alignment checks during production build has quite a high overhead. On AArch32, the alignment check is enabled at boot time by setting HSCTLR.A bit. ("HSCTLR, Hyp System Control Register"). However, on AArch64, memcpy()/memset() may be used on 64bit unaligned addresses. Thus, one does not wish to enable alignment check at boot time. Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel Reviewed-by: Bertrand Marquis I think I can keep R-b as there is no code change ? - Ayan > > Cheers, > From xen-devel-bounces@lists.xenproject.org Mon Nov 07 12:56:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 12:56:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439385.693428 (Exim 4.92) (envelope-from ) id 1os1fl-0006U9-Od; Mon, 07 Nov 2022 12:56:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439385.693428; Mon, 07 Nov 2022 12:56:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os1fl-0006U2-Lt; Mon, 07 Nov 2022 12:56:17 +0000 Received: by outflank-mailman (input) for mailman id 439385; Mon, 07 Nov 2022 12:56:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os1fl-0006Tw-4R for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 12:56:17 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2053.outbound.protection.outlook.com [40.107.104.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f05cb59-5e9b-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 13:56:14 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7423.eurprd04.prod.outlook.com (2603:10a6:800:1a0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.24; Mon, 7 Nov 2022 12:56:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 12:56:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f05cb59-5e9b-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=djUedHVC13KCgvxaSJYyQK/QWBpQmR+IUH4e0U+1TnYjFYttRk81badA2qK6wvTHT2GuBtXVXjntka+tG73EpVU1w7DvUV6T0O+1iPjbaaINHIVicHs9nNI2+3nReP2KvQ02KSr8/qvn3W2a2qg+VdqJQ6O/hYHpFxvQBI0CSDZrhzrMnA268XSVvH21DVtxoUN/OcTf/ta8pIvvjD4vDGvITpt3CBTgX+AA1sX7a+n0ZesWQtUhW6arnn8GYNEW3tYXCbkddR/ufxD2djIwYf/GuhdXfQ4255QMGos3+be+EjRtNik6VA1dD424QItqTlaayjnkP83Z0hSGPDD3jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4gom/usOdYTCjJw1aHXnmajlSa4tRBYFsESzO8uiolg=; b=L72f3yT282UFkjuzNZUePKo9J0od7WlNmiFA7XZlT+EU5Rwi0NSoz0PguEKzqoUm/AKM6/utQ4ieeKN9aIr3b+Ii3ZU/wBX6qH5k2nyyAcfgP4RzpsVQc1PgL1hvdp4oL86ibvk4DM8qQtlaULc4X2ONsBT6uDKSHI4bJI9WuzGB5AhJ8oG2Gso8X9oNjvwQu4ndz+0vL5OeuJJPPZAj7MywXk3ILGKP2simU0I+OGIWPD6lVYshNoGZVLyu77x/AhHac+jEIMrCk3XOorRzSnocWyhl9Jk4BF1ZNjskZ0te0utU4c+dRW73oDr1SHH6s08wJj77xBd5MfkCuGCPGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4gom/usOdYTCjJw1aHXnmajlSa4tRBYFsESzO8uiolg=; b=FWEpZYBVvxyUC5P6lB5g9r9t5RaW4EXhVgIys0pTubgrgUhmRPSsPcA+0V9MKZ/WmC5c38WgInXGi3rrftQmf9uGXsQZqfXjsSHkb02Wu9GOY/zJgPA4iduFYDpuBfOlzBpUHKMKnXXNW3iokExMyz4jSPGCEPpO6HUJis/KP8x1E0YLh3p29VfiVP6KU1qBSEjbHjEyAoziFv5RIfPaOXkSmpndH4lR+vAg0FibrWPcb4EA8vAq/ct/gcLRymRNR8FsvW89CUulRJ3W+Px8d6aBjW2fxZw/iUqSrnEoUduin87Ogx2fWbtA5ZLV4sAa1qvEj1a0xStKVMBZYIjAtQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <933c4227-5839-312e-3996-693a7d8f7706@suse.com> Date: Mon, 7 Nov 2022 13:56:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h Content-Language: en-US To: Luca Fancellu Cc: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-5-luca.fancellu@arm.com> <5caf911d-e96d-39e4-d945-db6537412f60@suse.com> <3925276F-8B6E-4B19-9EC2-C085FE88A637@arm.com> From: Jan Beulich In-Reply-To: <3925276F-8B6E-4B19-9EC2-C085FE88A637@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7423:EE_ X-MS-Office365-Filtering-Correlation-Id: ab617a38-c494-4529-b3df-08dac0bf71ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nk146Z5eOKaeplgeMsCc6/EWvywKGvXZHJ/cdn039jhrHjh82pB+78BsJJb9rKZUR13mKYYqkUVdoNROZoinEZqBlDuPP9jvEVhhWLsxOOTQ4U4vGojnwnQ8o7CuWYWjeY5JKvteNE+2xMhSHsOeFaBT5Fuo8F07SyCR3jjNE/hBbRIsOiU9n4OjsQj2gIyzsW1TGyce49wuQSGSApNybHHeNtmyW2/ZpVGE+V3zF6cxxQztFwue6mDYW0xeFg6xGsImjvSDspdxSdXqKC4tGIj2pZaqlywgnKbTHy7lrTqel2IIIW4xa1FF3IlrwbMReDp+kHKUhl4Sfs+7cE/6y/cHqIp2QYEjtAwm1aqE3IRQP6C65zoZ0yqrKXYDF3b+qbl3PWI+3T/UEnBCX/SntiS71+1RzMq6NBzJmvz3uc9aJICHb+GGPjTUcAS5njZfQYdecExHlMXHRELZqNjGog1Jh1MxFu6hqdkiEqF6v5fm1UZOzdVfhMDrUQYdRgqajeW9r2foaC4eQEtFeyVRhIWSA+nwG6a/AFXECqgz6evE0up9fN49Az3jtzuA/tKHhkqcakXQw5YQid8kKBAMm0e6WnFeQo3iarrloheT3qRccGH3PvHNlSFUPEDJWUi6MYunbKGJHFZYUqv0TogECJpmeg4jEpWjVr+cy8+LiUXIBU4voKsOnOACZ58hp+R4G76VgVP3rKn+uhTXkfOU2/FjKNPQYim+AIPrUtpcyPsc35I+00+xzfER39MEQpo9p++Q0ONiiph8sAsNThDSmE2NYV31YhVtnP8vemXoqhI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(376002)(39850400004)(396003)(346002)(451199015)(186003)(53546011)(26005)(2616005)(6506007)(6512007)(2906002)(6916009)(478600001)(54906003)(41300700001)(6486002)(5660300002)(8676002)(38100700002)(8936002)(4326008)(316002)(66946007)(66476007)(66556008)(36756003)(86362001)(31696002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWpMdm1BSFZxR0pIN2pmWlo1YU5vU1hZRjY3SzRxTVlTRnd3YnhVcnJYUW5h?= =?utf-8?B?ZVREUHN6Wk84RVNUUVRiRU9uYTk0Q2t3WFliUkNZM3ZEMDZQRE5mZnBCWjZw?= =?utf-8?B?bnA3dFpaRlpEbUphWGU3aEFSLzFwcGZsK1ozajJGVXRSQlhPQURCZ0tIZE54?= =?utf-8?B?L3Z3VjJJb1FSdHpYZCt6b090RHBmN2E2N3VJNHdPVHlZOURwcWJONU9Wcmpy?= =?utf-8?B?cEVXMHlJbXgrQUxXOWNRbU0vQ1BMWndidUVHRG0vOWNzRU5JNzkyWWllV3Qy?= =?utf-8?B?RDJmcklFaGRHaVZTdmc1OHphYkNUL1YyQlFMa2FTNzFCeGwrcFBwMVE4KzJC?= =?utf-8?B?cG9rRWFoV2Faeit0T0QvOEg4WVBPOE4xOXdDTDJ3SHZFdVR0Z3ZUTFFtZjdJ?= =?utf-8?B?T3hwWkJhYzh2b0RYWFl5czFXT29aemlqa0tNNmlwUWpHSVhHRklzNlArenlW?= =?utf-8?B?cEN2c04xUmNqR3Nqb3Fod1RGdU9LWG9OK0Y5MnZYQ2VRZGEwcE1sT2hsb3gy?= =?utf-8?B?THpOVUt5VWppc1Y3T3B6R2ppYnc2M3ptQnB1MEd5UXJNQVQzd2RtQk5pcjZT?= =?utf-8?B?TFVjc2l0cGVHV2UxZGlXU3lYa2pHditWVWFDdWpnbnhXSGkzRVZzWnV3N1B0?= =?utf-8?B?Q1VKTkJwbU82S3I0enJpZFdGS2hRNm9SSkpKNnI0VndpaHhXSWV1L1BJcWln?= =?utf-8?B?VitkVkx0eW9ZMGhtMGx4Z0x0WWRXeUNPbUt0cUNwbGJ5SXJaRGVmNjNsTjRj?= =?utf-8?B?SDlMc3RKY05DQXQ3dVlyaFN1NWFBRllJV1M0UTE3empWcVJ6UW9GTXVIazVN?= =?utf-8?B?YmdtUW9pVmtMa1J5Vko3Y2lUM2t1NlNaQndSWmNzbi8vWlo2NWdzQjZXVmZJ?= =?utf-8?B?THExcmIvSTlUZ2ZFZEJHbHBxbklKVkV0RzlremxUNlRDcmowU0dweWJMQ3p0?= =?utf-8?B?QmIvVER4aU8ya0JFSWhmNm9DcGNhZFN6V2Z3clQ3akltR2xuby9IUEVJR0lw?= =?utf-8?B?Uk9wa3Ewc0dCTzViYldVV1VtTWVrN2xIa1dBdGJEZlFBbmt3cmcvZzRhcUlN?= =?utf-8?B?OXBNWU96NmhRQnA2Q1kzWTRvTU92YXl1N0hIcUJId2hpWitwTUV5WnVHRXZj?= =?utf-8?B?UlpVL2s4UGlyR1ZHRFd4T05Nd3pIV0R2MmFCNisxSWxiMHlTTXhpb21TNy90?= =?utf-8?B?dWw4WGdrOVNjK0gra2g0Smp6MENmNTFUVlY5SUFIUTc4RDdTSHVlM2lSVzBJ?= =?utf-8?B?YkRmQ0ZlR0RwbUZqWEsyMFdkckdXb21HZXQ5NitUNkpVTEMycHo4aXBuNWpj?= =?utf-8?B?UTNXUCtrQkZkcnIwQncraWlTZzM5VEh0VjZ5dWQ3bFRRUzZRR1Q1T1lYRzVG?= =?utf-8?B?SG9FbnZjeEJRSk85WkJkZ2ZYMG1ZbU5TMXZZVnlNQjRpRjVSWmt0azBCdHBt?= =?utf-8?B?RjVGZmFNcHN2RnNhWFZ2Q3pWK3Y1QlMyR0ZuTmorekpUMDMvYXg2M05TRWND?= =?utf-8?B?dXhVQk9jbXk3OHE1eUEvRVhxNk5icGkxaG14SEFZQzAvTmVoZ21PK1UyQzFr?= =?utf-8?B?TG9RWDZ0ZzQxaXd6V1VMd2w4UEkweE1uRUNWZ3ZRTmFLZW0wNlhGVFhSSXBs?= =?utf-8?B?OUtIdHNqaytEUDducUhWRHk1SXdkU3NNb1piNEx3Vkp2eWlyc0t6OWRSTWtX?= =?utf-8?B?ZVo2L3NjVVR1N2RweEtwMWlmMitld0Z3TEt5Yk5oOHhpbkhQWDBxMXMvSUNw?= =?utf-8?B?RzJMZktxZzUzUUNUWHNhRWdsQ1VLQ2lRVzNYOXJMVExLOHdNRXcxVEpYNFNN?= =?utf-8?B?UFo2aXhNYzZrcTB4NWV4K3ZITGE1VjZmTzVId0pIR3ZGYjBKS0ZsKzd3a0NP?= =?utf-8?B?TEtVVnhRVGdOZ2h5UWd0U2hIeTduaE1pN3JtREVwMUFyNFNITkVhQlMyWnFX?= =?utf-8?B?MWdSTXVleWxNcGdsTmVIdnZDMHJEYVBOVTVucERnUjBnZ3JBN0F6OXFzYlVU?= =?utf-8?B?YUVxTE43MU5tZDJucnpSTURnbDFGR08xaW1BWTBzY1lzTjVqUnd6MHVUdXlT?= =?utf-8?B?TDN6QXRWSHZTTk9pZ0FBTjlKdGp4cms1WDhNLzVIMjk3UFE0eDRZS0tRYXFG?= =?utf-8?Q?leQQnsEePVZDOz/8qZfks4QGG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab617a38-c494-4529-b3df-08dac0bf71ab X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 12:56:10.8617 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tVry2kVzjo5XeeeQBt2jnS/SSCMzjDKeVq6Y0Qh9ODPFbTHzrrksw7YIE3JzEW40dhffGv2rAffJPB1cdNAhtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7423 On 07.11.2022 12:53, Luca Fancellu wrote: >> On 7 Nov 2022, at 11:49, Jan Beulich wrote: >> On 07.11.2022 11:47, Luca Fancellu wrote: >>> --- a/xen/include/xen/kernel.h >>> +++ b/xen/include/xen/kernel.h >>> @@ -65,24 +65,28 @@ >>> 1; \ >>> }) >>> >>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>> extern char _start[], _end[], start[]; >>> #define is_kernel(p) ({ \ >>> char *__p = (char *)(unsigned long)(p); \ >>> (__p >= _start) && (__p < _end); \ >>> }) >>> >>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>> extern char _stext[], _etext[]; >>> #define is_kernel_text(p) ({ \ >>> char *__p = (char *)(unsigned long)(p); \ >>> (__p >= _stext) && (__p < _etext); \ >>> }) >>> >>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>> extern const char _srodata[], _erodata[]; >>> #define is_kernel_rodata(p) ({ \ >>> const char *__p = (const char *)(unsigned long)(p); \ >>> (__p >= _srodata) && (__p < _erodata); \ >>> }) >>> >>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>> extern char _sinittext[], _einittext[]; >>> #define is_kernel_inittext(p) ({ \ >>> char *__p = (char *)(unsigned long)(p); \ >> >> Why the "R8.6" everywhere here? Didn't we agree that the in-code >> comments should be tool-agnostic? > > The R8.6 is not tool specific, it is to give the quick hint that we are deviating > from MISRA Rule 8.6. Well, yes, "tool" was wrong for me to write. Imo references to a specific spec should equally be avoided in in-code comments, as other specs may turn up. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 07 13:44:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 13:44:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439407.693444 (Exim 4.92) (envelope-from ) id 1os2Qj-0004ZV-DQ; Mon, 07 Nov 2022 13:44:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439407.693444; Mon, 07 Nov 2022 13:44:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os2Qj-0004ZO-Aj; Mon, 07 Nov 2022 13:44:49 +0000 Received: by outflank-mailman (input) for mailman id 439407; Mon, 07 Nov 2022 13:44:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os2Qi-0004ZI-B5 for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 13:44:48 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57bd6610-5ea2-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 14:44:47 +0100 (CET) Received: by mail-ej1-x62c.google.com with SMTP id sc25so30120416ejc.12 for ; Mon, 07 Nov 2022 05:44:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57bd6610-5ea2-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Vwv0/1mAQWe9fwxt6DEh77b+WOf2i7RVlEyUpQbZEmA=; b=As6Mpuy1mN2vrL4BN1Kzopib7iFm/YRqlZ6bfTWiXo5E2LWpDjqZmMZYZzdRllfPe3 VX5ItbrBkFHmMNKiUfbVKYlNJL3+hywY6lLxjlyINlxGMPFOr3q7vBjKv1cDhQLweqV+ lod4eBio1Y2Y9wFv3EOvebZvkFXI86XiuFbvsKe5cPYp+mR1Ye3Cwx14JQvkAPTXICW2 PaaJWLtzLYgzm0NqzrMiuUjbC/P7o13mVDTaRhIZlhTgBCC2pRTEKWHg9LCjP6EaMj36 43qqyJ0u7d59a0piP9bg7uwS1hMEJwMhiTbQN5Y3aCx0GEDOihdTAuonOOIez3XPQZob exvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Vwv0/1mAQWe9fwxt6DEh77b+WOf2i7RVlEyUpQbZEmA=; b=1eFOVdHVBp+MeM8p6Sybp60R/0qaxPFAo83ZTvVM9BgAneyB5jfbyC54SSq82XJcUT P2lOxlxQXisLilW/emWmZvhvA1sbjBN6qlrPb5nkYQfYHQpvqQYarb4/1FOw9+CPWQOc Loyi3/tboarZLYE6uo+gK4mPwxcVDabpwBE7vJaIfAvf47nnTIoJmovc6FLaOnNdN+Eg uvKm1P5Im9zM5oYarXmUqAvFTOKK3LNqTX6dotgawLU654MOePKTwnRoD/BX2Iu83lYF CyKrAG//fXJEXWCwfnjzS/VBqz0JHA+JZCFXO+owGZf738VMINlWLrcFjhFlUkRQZTJd EjpA== X-Gm-Message-State: ACrzQf0HweDvFMfNbw2SgY4axsfkMEqib1EGx2+i90jv3q04smo9JBuh iQk8uEwJD7fy+MkKCJlLXQ385APtiucab2uYpt7vNw== X-Google-Smtp-Source: AMsMyM7VWI0qWR65eVGztOVVEkiiFKnMVFdeF+33eO3HF7Tc5bDEcYNxudZ9Vs283ZJozd7fhtZI202Dr/EtGsBLDs0= X-Received: by 2002:a17:906:a4a:b0:782:686d:a1b6 with SMTP id x10-20020a1709060a4a00b00782686da1b6mr48059116ejf.232.1667828686234; Mon, 07 Nov 2022 05:44:46 -0800 (PST) MIME-Version: 1.0 References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-3-carlo.nonato@minervasys.tech> <308a7afa-a3c9-b500-06c1-3d4cbe8bbf65@xen.org> <9a996e9d-d9ce-f562-122d-1e661d25614c@xen.org> In-Reply-To: <9a996e9d-d9ce-f562-122d-1e661d25614c@xen.org> From: Carlo Nonato Date: Mon, 7 Nov 2022 14:44:33 +0100 Message-ID: Subject: Re: [PATCH 02/12] xen/arm: add cache coloring initialization for domains To: Julien Grall , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri Content-Type: text/plain; charset="UTF-8" Hi Julien, On Tue, Oct 25, 2022 at 1:15 PM Julien Grall wrote: > On 25/10/2022 11:53, Carlo Nonato wrote: > > Hi Julien, > > > > On Fri, Oct 21, 2022 at 8:02 PM Julien Grall wrote: > >> > >> Hi Carlo, > >> > >> On 26/08/2022 13:51, Carlo Nonato wrote: > >>> This commit adds array pointers to domains as well as to the hypercall > >>> and configuration structure employed in domain creation. The latter is used > >>> both by the toolstack and by Xen itself to pass configuration data to the > >>> domain creation function, so the XEN_GUEST_HANDLE macro must be adopted to be > >>> able to access guest memory in the first case. This implies special care for > >>> the copy of the configuration data into the domain data, meaning that a > >>> discrimination variable for the two possible code paths (coming from Xen or > >>> from the toolstack) is needed. > >> > >> So this means that a toolstack could set from_guest. I know the > >> toolstack is trusted... However, we should try to limit when the trust > >> when this is possible. > >> > >> In this case, I would consider to modify the prototype of > >> domain_create() to pass internal information. > > > > Doing as you said isn't a bit too invasive? I should also change all the call > > sites of domain_create() and this means x86 too. > > Yes there will be a few calls to modify. But this is better than hacking > the hypercall interface to cater for internal use. > > > Isn't there an easier way to spot a guest address? Maybe just looking at the > > address value... > > HVM/Arm guest have a separate address space. So it is not possible to > differentiate between guest vs hypervisor address. > > > Or maybe adding an internal flag to the do_domctl() path. > IIUC, this flag would indicate whether the XEN_GUEST_HANDLE() is an > hypervisor or guest address. Is that correct? > > If so, I dislike it. I am not sure what the other maintainers think, but > personally updating domain_create() is my preferred way. Sorry to bother you again on this topic, but I thought of a way to get rid of the "from_guest" field which I hope is simple enough to convince you. I can call copy_from_guest() *only* in domctl.c, overwriting the colors pointer with a new, Xen allocated, array. This lets me simplify the logic in domain_coloring_init() since all the arrays coming to it via the domainconfig struct are allocated in Xen memory only. It's still a bit of a hack since I'm using the XEN_GUEST_HANDLE as a normal Xen pointer, but it's by far less hacky than before and doesn't have the trust problem. > [...] > > >>> void arch_domain_shutdown(struct domain *d) > >>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > >>> index 3fd1186b53..4d4cb692fc 100644 > >>> --- a/xen/arch/arm/domain_build.c > >>> +++ b/xen/arch/arm/domain_build.c > >>> @@ -33,6 +33,12 @@ > >>> #include > >>> #include > >>> > >>> +#ifdef CONFIG_CACHE_COLORING > >>> +#define XEN_DOM0_CREATE_FLAGS CDF_privileged > >>> +#else > >>> +#define XEN_DOM0_CREATE_FLAGS CDF_privileged | CDF_directmap > >>> +#endif > >> > >> I can't remember if I asked it before and it doesn't seem to written > >> everywhere. This check suggest that it is not possible to use the same > >> Xen binary for coloring and non-coloring. > > > > If coloring is enabled, all the domains are colored (even if they use > > zero colors > > because of the default selection). This means that they are going to use > > the colored allocator. Since this all-or-nothing design, if coloring is > > enabled, dom0 is assumed to be colored, which implies removing the directmap > > flag. So if what you mean with "same Xen binary for coloring and non-coloring" > > is to have a way to select at runtime if a domain is colored, or if Xen > > itself is colored, the answer is no, we don't have this right now. > > [...] > > > > >> At the moment, we have been able to have all the features in the same > >> Xen binary. So what are the reasons for this restriction? > > > > Not sure about the first sentence (you mean, until this patch?), > > Yes. > > > but the > > restriction is just because it's simpler. For example if we have to support > > colored and non-colored domains at the same time, > > I am not asking for supporting a mix of colored and non-colored domains. > What I am asking is to have a runtime switch (rather than compile time) > to decide whether the system is colored or not. > > IOW, why can't system-wide coloring be selected at runtime? This is definitely doable. Do you also think the compile time switch is useless? Should we get rid of that? > > we probably need to > > change something in the allocator (at least reserving more memory for the > > buddy). > > This sentence picked my interesting. How do you decide the size of the > buddy today? The user can actually choose it arbitrarily and there is no particular calculation behind the default value (64M): it's just a reasonable sounding value. > [...] > > >>> +#ifdef CONFIG_CACHE_COLORING > >>> + unsigned int *colors; > >>> + unsigned int num_colors; > >>> +#endif > > >>> /* Virtual MMU */ > >>> struct p2m_domain p2m; > >>> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > >>> index c8b6058d3a..adf843a7a1 100644 > >>> --- a/xen/include/public/arch-arm.h > >>> +++ b/xen/include/public/arch-arm.h > >>> @@ -314,6 +314,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); > >>> #define XEN_DOMCTL_CONFIG_TEE_NONE 0 > >>> #define XEN_DOMCTL_CONFIG_TEE_OPTEE 1 > >>> > >>> +__DEFINE_XEN_GUEST_HANDLE(color_t, unsigned int); > >> > >> You don't seem to use "color_t" outside of arch-arm.h and we already > >> define guest handle for "unsigned int". So can they be used? > > > > That's because the guest handle for "unsigned int" is defined later > > (in public/xen.h). > > Hmmm... And I guess we can't define "unsigned int" earlier because they > rely on macro defined in arch-arm.h? Exactly. > > We can also think of moving the coloring fields from this > > struct to the common one (xen_domctl_createdomain) protecting them with > > the proper #ifdef (but we are targeting only arm64...). > > Your code is targeting arm64 but fundamentally this is an arm64 specific > feature. IOW, this could be used in the future on other arch. So I think > it would make sense to define it in common without the #ifdef. > > @x86 maintainers, what do you think? > > > > >>> + > >>> struct xen_arch_domainconfig { > >>> /* IN/OUT */ > >>> uint8_t gic_version; > >>> @@ -335,6 +337,12 @@ struct xen_arch_domainconfig { > >>> * > >>> */ > >>> uint32_t clock_frequency; > >>> + /* IN */ > >>> + uint8_t from_guest; > >> > >> There is an implicit padding here and ... > >>> + /* IN */ > >>> + uint16_t num_colors; > >> > >> ... here. For the ABI, we are trying to have all the padding explicit. > >> So the layout of the structure is clear. > > > > Isn't it true also for other fields like gic_version and tee_type? > > Indeed, there is missing explicit padding after gic_version. There is no > padding necessary after 'tee_type'. > > I am not asking you to fix the existing missing padding, however we > should avoid to introduce new ones. Understood. > Cheers, > > -- > Julien Grall Thanks. - Carlo Nonato From xen-devel-bounces@lists.xenproject.org Mon Nov 07 14:00:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 14:00:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439416.693456 (Exim 4.92) (envelope-from ) id 1os2fr-0007WJ-QF; Mon, 07 Nov 2022 14:00:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439416.693456; Mon, 07 Nov 2022 14:00:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os2fr-0007WC-NI; Mon, 07 Nov 2022 14:00:27 +0000 Received: by outflank-mailman (input) for mailman id 439416; Mon, 07 Nov 2022 14:00:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os2fp-0007Vn-WA for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 14:00:26 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8478f909-5ea4-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 15:00:21 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by MN0PR12MB6317.namprd12.prod.outlook.com (2603:10b6:208:3c2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Mon, 7 Nov 2022 14:00:16 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 14:00:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8478f909-5ea4-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RD6WW09V/yt5DgDXFNmFwpxuNPXgZrHHu6kok/8rH0qboo8QYPUM1UAVGlwMk1Jw42IbrxbaUkxbQHgOyNYzn9OTI/M4R2TDfl7K6ukwqZk9aHW09jJo1+Nl9YdVeCxWcPQcDzO3n4tSB1DDjX5AvhnBDKfGE8ZrX0EhsR8wdX2IzQgKNbp2G+/e78hmv2t4aQpm0i5/i1y+HUTbzOCVhSLNmwWxOQB8bV7+SCJPp5VB7fbH4S+lChHTbWtftxT2QjYRo4YfBTVVZtX18sayw8WG6XRLDW7X3tKBIountx0n6G88juRfM1VbkspSXf58GSt41oxJRXAqcwPJKbPSbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZL8uh4o5OnqxFdIWC5o66OuCu2zVKxRXW7MDG4snNlo=; b=PmXukiQj5A2QDk3lKtV12m3jKn9yIF+nDEicwoCpOJ/aZISUftuzCQE/iXBmR77Mpn01jvemy4+2vAWYdgrJzVwCsQVHFYqMDZ/AD3NwjkgbNBXqy22C6zDNKrSOiv4oz2Eh33QfTNknrujx6J458vvbR2byUEf5OM51XiMYYqe6oFcqTNRoFvCQySRIjePnEMyv6XyVYZdypaLKD3It3HWqICsF4sbCongE8yeNbM1X+6Tt1eLcHRdckqC4E33EzdjJIOVzhozkqFzDXWpnaBJ1tIiYaZuvN9r5r9b/cmElbgPx2Dup5syLWHyBCifolnseMVIEh4iHqtXq4Ah8eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZL8uh4o5OnqxFdIWC5o66OuCu2zVKxRXW7MDG4snNlo=; b=CQAmoyNtGVon7urrY5AlR22YssO41J03Gw+PuYr830QuePL5cbWiOw/4oG60oGQzWomHifv1pZYDBS51yU6Lm5RlIddXp89hUs9PdBS0HVMNn7oj1KB3CbRRtfyLhSMzG6LC3YvYHsE9lG8OnRYcgDaM4qKOVgMjHJg9E7BRKCQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <00e4eb67-2b47-346a-f5cf-98b73c8ba218@amd.com> Date: Mon, 7 Nov 2022 14:00:09 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32 To: Julien Grall , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-5-ayankuma@amd.com> <5d369b95-f412-67b2-5c34-3cd317128ec3@xen.org> <8bb1c421-2dc5-cdbc-94f7-6ea09f2d64fc@xen.org> From: Ayan Kumar Halder In-Reply-To: <8bb1c421-2dc5-cdbc-94f7-6ea09f2d64fc@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0008.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:338::16) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|MN0PR12MB6317:EE_ X-MS-Office365-Filtering-Correlation-Id: 19d8bf5a-92d2-47eb-3912-08dac0c86595 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AxIVX6rARPOOsRrkHsOHkn8DLc4Vj8I1W97ImbYwfkZubzbtuywF9TA96tmAQ7iHwGhFDZ7uTPE3soagTo5bHZhKn5WzEc251aBsNnZutpRM38SvKcfOskiINtTWw2LRUMmPy3+q7P9hhagS4jvNwlhKoMWrlT9MlwAwqKm/0s28yks47/PqugKq8oNww/nXD17RmQ+eD1dsFqB9pTNmS0ea7kIpehWF33u+mArrgX0xS7vzMpcnhTpe0cqm4ovqP5j5hCRHHkeT5Rv26jandREJKGPkgGVYSkZ6/13bPynMf9iQm6RUHR2nYRn7Qlgz1CEwwHGKP7d7G16H/r80/uQIsJWgKOPtH21+5UFjmZnwSjwytyXKm2WZ0RfHk4sTzM5dWo/q7tLbqpIWXn4dRkW26lmBoCqhJgWc4EYYONQRlfP/w09Neejot2ZItHIXw4JRNSK+VDffgrmAR5IpM5VXUJk5PI+GKSJA2Sw0XdNsG8JB+pPLTqCBOu8po+qviAUaVc5R72Cva0qp9AQUOZdtsfWTno+Cm38ZQD06Dg+ak1B7NqC8D1QQ3PdbSPtjlJhUjxhdGSSnB4ayfPvsG84dQSapEpZJ8H9Uxem0uWC9DWMD3O268z6SPy3LaN9vp4H/JZpB4xkoh9mU4ilEiRIkaBpvCMadJuJWTUzvR5XHAHB0O9kB+W2I7boCsi6W/tXu+Rdt696uH+Rj6J1nRTJmq5sAF2IxFGhCxUvQuyYukOTKYxly05EZclWA/E28mP7HtUMIbamSI/6JRejotdA03og7Mgy1LW34FnRO9Kg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(39860400002)(136003)(376002)(346002)(451199015)(2616005)(83380400001)(186003)(38100700002)(2906002)(8936002)(5660300002)(6666004)(478600001)(6486002)(26005)(6512007)(53546011)(6506007)(66476007)(8676002)(66556008)(31696002)(316002)(4326008)(41300700001)(66946007)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTcvbTh0bDJ1RUdObExGRUFJRGZuN2t1NVhHVFh0cDFJMktObGpHbmRGbVA1?= =?utf-8?B?TGRXRkZ4NzFFOURmRU50WU9vOXRlV2FhS3I0WWxXRTVhZWtLd0huK0JPMWVP?= =?utf-8?B?cUh1dndmTXI5MDV5eFd6QWwvR3dySmxQdlRyWFBZRHhITXF1SktVaFo4djNi?= =?utf-8?B?clRhSVhYZVFWTmZOL2tIZi9uK1BIL3grSnVyd2tuSmR4OUpneUZQQiszWUpo?= =?utf-8?B?WHQ1a2pwdFVGSUh4M1ZXc1RYYnd2dzRScXAyTzB5Q1NwVW5LRTZDSy9qOU5W?= =?utf-8?B?NU1ZWDYxTXBKcFgzY3dBdk5KQXVPSXROaEQwRG42VHRCeTZZR0p1dDBsRm90?= =?utf-8?B?WkVrczkwdjFMalRmZmYwTytjcXR1a0NNSUFhTDFnMEdXQ2NSekZiZG4wV3pG?= =?utf-8?B?ZTByOGUyOVR0NXQ2dnVWZy9vNUdhSU9lRVdaQ0JndDdqMThkRDgvOHNGeWgy?= =?utf-8?B?aUhpOVZYdmNnVlRWQkdncVRneHVKV0p0dFBlc2VmaU5KZlNYNFNoNkh4d3ZK?= =?utf-8?B?Nmt6OSszQ0JKOWVvM1cwOFBscEFTKzBFdlVkV3htN204eGdGMTd6NVJxMGZ2?= =?utf-8?B?cW1EMXpCMnlycjZnT0JnTnp0MUh1WlB3VjZVaFdwalVxbHhzKy9pbEhQSHpM?= =?utf-8?B?VWh6U2Y4T0lCSjlXV01rUWU3MnR2QU1PZ05jbStYcEx4K05lbmpCWmx4YVZG?= =?utf-8?B?UHhvZ3NLT1d1cVRkV0dLSnEreXFBc29mQnNIaGJTWUxheE9neFBLSzk1ZUlJ?= =?utf-8?B?SEdUT2xGdUdlUExzTzB3RmZncHVyaEo3RGFoOGhmalp4bmU2ZkhWcU9kQlRy?= =?utf-8?B?R3htRHlTbFhSNXVPUElwQWhNd1FiR2xBVDdpN0VqTXBkWWhtTjQ2MWdTYU9V?= =?utf-8?B?RjZaeUp2Y2lNZU5wamtjVkZtTGJjZFpGUEJTcDY4TEE0NDBLRHhkNmFXTW4v?= =?utf-8?B?UThtckdHZFBYTUtGRUVDUHhnYUlWSG1yMVMvKy9qbGliNnJwZ24yZ2k3Tmc3?= =?utf-8?B?VVBaN0VMNWRRczdQK21WdXRDc3FycEFYRFRjRForSUo1TmRnT0dSQ0xCZVJ2?= =?utf-8?B?RElSVkRLSWx4TDdZN1lGWS9wUTBWTk85bkJlbHF0cW5YRWdxSDBYME5pTEtX?= =?utf-8?B?VHR3VDFEOEJyMlJCTm9HOENUSWxLQk1WTWs3QUp6N3c4TlBQU2hJUW94VXRC?= =?utf-8?B?NldjdHhXUHlkM0ZmWEQ1WXdYaHRFa2RuWXVtUXdkc0pveVpqeGlmMkpOWEM2?= =?utf-8?B?eW16c2pTMlFEbUtBWXB2Z2ZkYjNuUU02UGtFYnNVbEZqWC9YWHo0RWNuVnpp?= =?utf-8?B?emlQMTh1T0lxRmFmSDhOUTA2VFFTRXk2bGw3SGlTSUxRWWl3VW4zMHFnazJq?= =?utf-8?B?bUVCdDRCcFk3VG5xNWcxSHFvdXlyWlA5K28yV3lHd1RDd3RjWFgvZElCVUx6?= =?utf-8?B?Y2htbUpXQTE0VkkvbnhnVUVjZ1ZoT3hDeXpJdzgxc2ZNL2prZW5sZXZiUis5?= =?utf-8?B?VHVyWHhFNWttelV1ZjFQOVdzSmxjc2VuMmxINmJncHJVLzNZVW9UZE5nNG1l?= =?utf-8?B?YjNsWU1NWlIyUTV6ZFdaRERJU21oV1ZmTHNJYkk5czNUT0tGL0Y3WE41UCtT?= =?utf-8?B?aVNiU2dXVmF1VjRvQXVzcVQ0dWU0bnc0dmJlMmF0M2NBNUt3VzR3SHFqVlpr?= =?utf-8?B?RVp1S0J1WGFZdGd5akt0eHpnQXRPK3dWTGpzMkgvSS9McGNHaVR0TUYzd1F5?= =?utf-8?B?Mmd4UHdnSFZYY0xvYTFsWUUvUllhU1JTa0lybXJCK3BhVzlEMVRNbE1iT3o1?= =?utf-8?B?OFpHK0ErTElrWmtmWWRGTm1xc2Z0eVM4NXBJZUxEVWFscm5SaXdjYjFIUklx?= =?utf-8?B?YlpFQWF5dU9uWTBsSGZaaVZGNlhzZGdwc21GRmIzWmZGTWVCMUFWUC82Y2hq?= =?utf-8?B?TmpQcEZsYzlYWWtyMjlJVms2dGkvZTNKS0htdWxFZTZQMFBCL0dBT1dsbm4r?= =?utf-8?B?QzVoUEVSNGpJQWlwRWIyZ0k3LzVFVXhZVzdvSmtQZWtVOTJuemJTRzA0aXUv?= =?utf-8?B?TFQ1VWxqY3B5ZjRmV2ZrWlVqQlUvV0Z0ZytiUllxYi9tUzBTa2pvWXRHQjdL?= =?utf-8?Q?DEShdHgpL+vcz/eoDURKV25f6?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19d8bf5a-92d2-47eb-3912-08dac0c86595 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 14:00:15.8804 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OG6sDXxdAOc9XJW/il0ZavOsr0JZAsvOQSfcjX2jIdbBi6UnX8REwq076P41EwIt06uNp7jehSuR5aMk/ZxNGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6317 On 07/11/2022 11:54, Julien Grall wrote: > Hi Ayan, Hi Julien, I need one clarification. > > On 07/11/2022 11:33, Ayan Kumar Halder wrote: >> >> On 06/11/2022 18:04, Julien Grall wrote: >>> Hi Ayan, >> >> Hi Julien, >> >> I need a clarification. >> >>> >>> In the title you are using AArch32 but below you are using... >>> >>> On 31/10/2022 15:13, Ayan Kumar Halder wrote: >>>> v->arch.vmpidr is assigned to uint64_t variable. This is to enable >>>> left shifts >>>> for Aarch32 so that one can extract affinity bits. >>> >>> ... Aarch32. The naming also seem to be inconsistent across your >>> series. AFAIU, it should be AArch32. So please look at all your >>> commits and make sure you use the same everywhere. >> Ack >>> >>>> This is then assigned to 'typer' so that the affinity bits form the >>>> upper 32 bits. >>>> >>>> Refer Arm IHI 0069H ID020922, >>>> The upper 32 bits of GICR_TYPER represent the affinity >>>> whereas the lower 32 bits represent the other bits (eg processor >>>> number, etc). >>>> >>>> Signed-off-by: Ayan Kumar Halder >>>> --- >>>> >>>> Changes from :- >>>> 1. v1 - Assigned v->arch.vmpidr to "uint64_t vmpdir". Then, we can use >>>> MPIDR_AFFINITY_LEVEL macros to extract the affinity value. >>>> >>>>   xen/arch/arm/vgic-v3.c | 10 ++++++---- >>>>   1 file changed, 6 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c >>>> index 3f4509dcd3..e5e6f2c573 100644 >>>> --- a/xen/arch/arm/vgic-v3.c >>>> +++ b/xen/arch/arm/vgic-v3.c >>>> @@ -191,13 +191,15 @@ static int >>>> __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info, >>>>       case VREG64(GICR_TYPER): >>>>       { >>>>           uint64_t typer, aff; >>>> +        uint64_t vmpidr = v->arch.vmpidr; >>>>             if ( !vgic_reg64_check_access(dabt) ) goto bad_width; >>>> -        aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 | >>>> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 | >>>> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 | >>>> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32); >>>> +        aff = (MPIDR_AFFINITY_LEVEL(vmpidr, 3) << 56 | >>> >>> Shouldn't we #ifdef this level for 32-bit? Or maybe check if the >>> domain is 64-bit so we are using consistently regardless of the >>> hypervisor bitness. >> >> We have typecasted "v->arch.vmpidr" (which is 32bit for AArch32 and >> 64bit for AArch64)  to vmpidr (uint64_t). >> >> So, we don't need to have any #ifdef for AArch32 or AArch64. > > This is not related to the typecast. This is more that fact that > affinity level 3 doesn't exist for 32-bit guest. For instance vpsci.c > will protect level 3 with an #ifdef. Just to make sure, I understand you. You are suggesting this ? --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -191,13 +191,15 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info, case VREG64(GICR_TYPER): { uint64_t typer, aff; + uint64_t vmpidr = v->arch.vmpidr; if ( !vgic_reg64_check_access(dabt) ) goto bad_width; - aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 | - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 | - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 | - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32); + aff = ( +#ifdef CONFIG_ARM_64 + MPIDR_AFFINITY_LEVEL(vmpidr, 3) << 56 | +#endif + MPIDR_AFFINITY_LEVEL(vmpidr, 2) << 48 | + MPIDR_AFFINITY_LEVEL(vmpidr, 1) << 40 | + MPIDR_AFFINITY_LEVEL(vmpidr, 0) << 32); typer = aff; + /* We use the VCPU ID as the redistributor ID in bits[23:8] */ typer |= v->vcpu_id << GICR_TYPER_PROC_NUM_SHIFT; If so, then we can drop the patch "[XEN v2 02/12] xen/Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32" Also, we should do the following change :- ayankuma@xcbayankuma41x:/scratch/ayankuma/r52_xen/xen-pristine$ git diff xen/arch/arm/gic-v3.c diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index d8ce0f46c6..e7d5338152 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -527,7 +527,10 @@ static void gicv3_set_pending_state(struct irq_desc *irqd, bool pending)  static inline uint64_t gicv3_mpidr_to_affinity(int cpu)  {       uint64_t mpidr = cpu_logical_map(cpu); -     return (MPIDR_AFFINITY_LEVEL(mpidr, 3) << 32 | +     return ( +#ifdef CONFIG_ARM_64 +             MPIDR_AFFINITY_LEVEL(mpidr, 3) << 32 | +#endif               MPIDR_AFFINITY_LEVEL(mpidr, 2) << 16 |               MPIDR_AFFINITY_LEVEL(mpidr, 1) << 8  |               MPIDR_AFFINITY_LEVEL(mpidr, 0)); @@ -720,7 +723,10 @@ static int __init gicv3_populate_rdist(void)       * Convert affinity to a 32bit value that can be matched to GICR_TYPER       * bits [63:32]       */ -    aff = (MPIDR_AFFINITY_LEVEL(mpidr, 3) << 24 | +    aff = ( +#ifdef CONFIG_ARM_64 +           MPIDR_AFFINITY_LEVEL(mpidr, 3) << 24 | +#endif             MPIDR_AFFINITY_LEVEL(mpidr, 2) << 16 |             MPIDR_AFFINITY_LEVEL(mpidr, 1) << 8 |             MPIDR_AFFINITY_LEVEL(mpidr, 0)); @@ -972,7 +978,10 @@ static void gicv3_send_sgi_list(enum gic_sgi sgi, const cpumask_t *cpumask)           * Prepare affinity path of the cluster for which SGI is generated           * along with SGI number           */ -        val = (MPIDR_AFFINITY_LEVEL(cluster_id, 3) << 48  | +        val = ( +#ifdef CONFIG_ARM_64 +               MPIDR_AFFINITY_LEVEL(cluster_id, 3) << 48  | +#endif                 MPIDR_AFFINITY_LEVEL(cluster_id, 2) << 32  |                 sgi << 24                                  |                 MPIDR_AFFINITY_LEVEL(cluster_id, 1) << 16  | - Ayan > > Cheers, > From xen-devel-bounces@lists.xenproject.org Mon Nov 07 14:16:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 14:16:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439422.693467 (Exim 4.92) (envelope-from ) id 1os2ux-0000xJ-6q; Mon, 07 Nov 2022 14:16:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439422.693467; Mon, 07 Nov 2022 14:16:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os2ux-0000xC-2W; Mon, 07 Nov 2022 14:16:03 +0000 Received: by outflank-mailman (input) for mailman id 439422; Mon, 07 Nov 2022 14:16:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os2uw-0000x2-L7; Mon, 07 Nov 2022 14:16:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os2uw-0008Qn-JO; Mon, 07 Nov 2022 14:16:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os2uw-0004CG-6Z; Mon, 07 Nov 2022 14:16:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1os2uw-0003rH-64; Mon, 07 Nov 2022 14:16:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xuBdX5Xqni03RgnpYcIqDHhghzI7Zw6+hMUH/M3WCeU=; b=tHp6B1uMPJ+Z4RosFO6uWdcdQ9 ILMSP8rN3jrlOSepyHQApKSm9yCY5ABrrmUixvOr/5xbo+/DC5TbLz+BSbOoxgF17yUC7f0fNt7AZ w7i+zLpFNVPPpQwi6XnReIk3QcCz8NeTOfjYGdGsl5ZL61sQ+SQ4UAyOB2sNbEKdgrac=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174657: all pass - PUSHED X-Osstest-Versions-This: ovmf=82e70d9ac0aabf48a0cbda3c373e94ef22413e49 X-Osstest-Versions-That: ovmf=35043a5ec05db6aa86b1b380416923fd1c3506e6 From: osstest service owner Date: Mon, 07 Nov 2022 14:16:02 +0000 flight 174657 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174657/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 82e70d9ac0aabf48a0cbda3c373e94ef22413e49 baseline version: ovmf 35043a5ec05db6aa86b1b380416923fd1c3506e6 Last test of basis 174653 2022-11-07 02:12:04 Z 0 days Testing same since 174657 2022-11-07 12:12:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiewen Yao Laszlo Ersek jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 35043a5ec0..82e70d9ac0 82e70d9ac0aabf48a0cbda3c373e94ef22413e49 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Nov 07 15:09:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 15:09:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439433.693477 (Exim 4.92) (envelope-from ) id 1os3kV-0007XE-2d; Mon, 07 Nov 2022 15:09:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439433.693477; Mon, 07 Nov 2022 15:09:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os3kU-0007X7-WB; Mon, 07 Nov 2022 15:09:18 +0000 Received: by outflank-mailman (input) for mailman id 439433; Mon, 07 Nov 2022 15:09:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os3kT-0007X1-I6 for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 15:09:17 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20063.outbound.protection.outlook.com [40.107.2.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2404e2da-5eae-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 16:09:14 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9316.eurprd04.prod.outlook.com (2603:10a6:20b:4e7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Mon, 7 Nov 2022 15:09:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 15:09:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2404e2da-5eae-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y9LOfQ9iAiXbyXpsZXX2mI/4yLS3vss3npSMOyCXrrAlTPYLFmRYR0cZab2Ad83o4DTNqy+FXlDbiLaavJ8h4FUGGbxg34TXoEGs6AHXqPahs2tvAIX76y3W9gnOFdxHbI2GP3T7iwoBIl7pW+mh7MpSto02RI7cBpOELvefb7x2s0AH2XW+h/uccfSogb0mQ4i9Pp/ywGy+Ci7DEQN49SKwor0e7X3ya5t2gqvqxFWL7w+LwRI0lnA36u8QBAPt/d/lyzMpmdMQY5ZasA8QSu1AfoTTqV8DwU3O0WexpxrJQorqXTO2dIeLPfj8/uxhP/dwSTwV9ex55v2YhPkP1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=szw5kFsGTSOmjgpURbNvhhMr2iPPJJmIgQjLJijPsLE=; b=djpctp75vnNVXvTrv8wY4/uIYMa+dc/Gv3IfXXY2S2CatEGGtuBHEHt77EFvZSTDP1ICdnMdDu429LKXVxnYQpEzrrQfGLdmKpimoAS9b16PWEVexFpm14GE7cydig9vqmVjNJk1PZ1m4nTgXdaOEgEOvh2g0KXkBsbV9hEoIk3ixtiwvUvbCIFeT8/kDnljC6fsvvkAERyDTDBXHicYC02G3ElBybVIZPsfeYhdEontoJ0AWJ0TwP+LnjQrehIuzLoQTzdjTnHb1pDVz0z/EdgqXCDPZ6FFnrl3TR29NwsTcOtxW8YlluFa6XfymPZYT5C2cIMtLtBa6X/gEA94Vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=szw5kFsGTSOmjgpURbNvhhMr2iPPJJmIgQjLJijPsLE=; b=EDrtJSVTRI8OjlY/XsAz4xXRNX/WKpdLIEDkgWoRnyoVtz1QxkFcJvh6tDra7Ij441Yx//f4PZrWwWE376K+7LlR9V6fD3foOruGs/v17+kyaK3EyREeI6B6kLoGP1imogXQQUnwd/tpcTVXMfZDwm3Co7g0rG6mNRZjMC3K+QsYwJjNb2E0/fLADqNRuOf15AIqTkquNxJYvJhpdOVENeTnMEIKH4qhpBORNr+COvBDgH9uUTswWYLuSWkxfF/Sbk/w9/k7Fro2chy5VaUmtxoaNMjOShtRrGQjbuh46I79KOeAR1JSS+0GN3OpMYe7LcZFnc0ftlDRkWmrzzp/Ig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Nov 2022 16:09:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang From: Jan Beulich Subject: [PATCH][4.17] kexec: restore hypercall 1st arg's type Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0035.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9316:EE_ X-MS-Office365-Filtering-Correlation-Id: 20194bd2-9855-4e77-c911-08dac0d20734 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P/X3+JUzXjQu+2xOxS3ik1H81v6auy0Ci/iBm8me25G137dH6d9K2S92pkfYHUojxr+olYutHQMrgTwrSy2S2f2dkTL/0ILkZPRhmzRP7x+yhSGWcp7MYjKmsFFso2YNOzkcnonrinaYj1jCpxrBRljZtrrMD6wMghmzBL+9fJp1Z3DO+FJRdjgd3EPfalq1fH9no4oSW3GeSBBsM7xgkPPu5HPC0h+lDpiq8zAOwJLcT/Rwm8efpy6IXh3yrepxzY/Wv30EOEADzd2TgiQdr7XxWcwNRlVPf991yLjLq3m37jxeSXs3HN9WXyZn1gVRLHH6Yj1gka4Jhs6/kug+FHddkLGNnYCSe3b2s1rkYmpj/Bd1yA9oIaE5FDqgRihao5ZuJL3AAIVQsdyiGke/etAVvfqubTV+JlkVkVVejKAckZVMXf2p6DL4BVyjOEWNkIDR5d7Jdgp8S28jGmrMsctlZK9BOSqUW1JAdUBEXWfHN4qTPdpvB+oJi1RaDjewG0xzq7MR2gjDivIXVLor+fgMIRaWVLWcLj92VpZpki9qC+Ttav454uUE8GeS8xVjUwlSzoHVWe8l7fzNATIDYb4zO1RH2e2I6vH8KdPbWBCvPAoS+YX/Bl0LXPfOBCEmq3tq13LRGx2ZSwCgPX/nch1BcFNLtC9eQ2j6KXdjpoiDvKvLSgFY51/mufJKBMm4Yy58xQO0vxxhl94tsxXryPhKBAtum+ckxShY8UuFEIfngn4JK/AGE9l1dkDMTV49aVhK9jcRgmvfhXAvPpRqe2EsOGAoyBS4DhYCmt+/Gi1MD+y085xRNfJa6mQEIUb/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(346002)(396003)(376002)(366004)(451199015)(186003)(38100700002)(6506007)(6512007)(26005)(83380400001)(2906002)(316002)(478600001)(2616005)(54906003)(6916009)(6486002)(41300700001)(5660300002)(8936002)(66556008)(66946007)(66476007)(8676002)(4326008)(36756003)(31696002)(86362001)(31686004)(45980500001)(43740500002)(309714004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlZPb1JqdjVVZ0Z5RzY4Yy8xc2t5ODgvMlh6WnJmdlM1Mjd3MFhaMUNERHox?= =?utf-8?B?TmVqY2llN0U3WGJ1S1JKdjF3ZEpRRkIvTk9oTnA2M21laUVETEM5TUhBQlpo?= =?utf-8?B?cHJXV1VJTm1ZRlF4K2JZTTZVcHZPRXRMNG5pWmtNVTQ0S2tqT0lyRmZ4TlIx?= =?utf-8?B?UWhualNiRVhQcFhLMnBEc3ZGY0I0VkpJVSs1Q3NPNURuZWtRSFpXMnNUNVNu?= =?utf-8?B?VDFXaVI5dTNVZGpOSjE3WEIwWC8rTHBLOEhXZTBjeHJheVRhQVNidjRHSVEv?= =?utf-8?B?SUdmVGhSYm82ZXNUZDlKZCs4Y1FZbWVjejMybEZaNG1VaUoyUytreTRaS1cw?= =?utf-8?B?bGxSSTNVUlVKbHdLRjVOOXJmRFNQaUMvOHJ5U3FhdUdlUmtEYmNYVVk1cm1q?= =?utf-8?B?eVl6RUhvMENqUWdpUzdjNTl5R0lJbXBWMm5yN3hTeGl4aVV0NW9oUUV3Y29w?= =?utf-8?B?UzJ2bWZjQTJsNHRPQm9SMHBIVkNIQVY4QUJFdmJIU2t5YVYySHJKY3ZjWEdP?= =?utf-8?B?RHJ4Q3lnT05wS1VqallqQzhtSXBJSm9pRnNhdFVuckVWN0RSeGFRK3ZPSm5o?= =?utf-8?B?RlkwVGd3b0xpRkVLUmsyWnlaZzd4cmVhVzZ6UEo1NllLc2RwUG9LN2JlM0kw?= =?utf-8?B?TUFqV0RGaGRKWm5vVkdkUTF6TGt4c29mVUNZY2FUQkNnbHEzRk4vUzB1Vytv?= =?utf-8?B?SXZJaC85UDJWaDFacDVGR2F3anBCL1dnUE1iV1Q4QjU0OFNySm5sMEo0encx?= =?utf-8?B?c28rS25ISlhLYVV2QUR6T0thbUE2SkZDeUszaitXRENIY3A0TnhiYURUcGcy?= =?utf-8?B?Ym9vS0VUVDZjUlE3TzBSR1NDSkFGTmRzd2RRMG5KQzk1TTVIWmpiMVdNQWhs?= =?utf-8?B?QkVLMzJUb2lhTSs1QkVKQ2pMdlJ2ZDhvMFA2ZXdqeHJYc3h5bGlFNTI0Ny8y?= =?utf-8?B?eVV1VSt0V0pVNjJLaThaM1hmVW5jKzg4bHF3RUl1cE4zMWc5L3dTa1VnVVFB?= =?utf-8?B?dDk1eXhVbDQxUFlzanVmanZLNURXZjdoZjhoNzdmSkZLOUhOV2J6MmJxanZN?= =?utf-8?B?OXpMVVA0OU4zQ1hhcDJnSnRMeDlBUXlCZFpuL25UUFRRY0RJVDFFMVA4Yzdm?= =?utf-8?B?NXpZQll5Z1dPZXZ0TXFNRm8rSE91UmljbUIxc1pSc0daaHZDZ05ZSW9HNHJX?= =?utf-8?B?djh1TlVraE1GYm0xdDNtckpteE5NRzd6eEFUSHMxVGZIYzVFSCtuQWZQais2?= =?utf-8?B?UFp4bCtmdmxBWGNvNnByVGJUaWd4dmdGZStMMWExWGJPWVlZUEo4UU5WZExP?= =?utf-8?B?L1JxdDhnRFZwRUR4SkFaVW0yUk9KZE1QZmQvais2RXVvUWhoWWZ4aGh5OStK?= =?utf-8?B?TWZQR29ISm5qQTBzMjF6bDRmZDk0aDE5MXMxbDEzV0tzVGxjMENFMHByOE1L?= =?utf-8?B?aDAweU9NU2RiK1QzaDRWM1NNeTFrSi9aa25BaDFzTUlwT3JJNWVRNCtxMTUx?= =?utf-8?B?NDcyMjZFd3VSSnZOaVZITmlaN251QWtlczZUOEdJYjNsNEhkbnk4RVppT1BV?= =?utf-8?B?b2xndDFydkd1RzN2bHgwTDJCTTg0WCtPL01adzVydGk4bGQ4UUk4Uk05WHhY?= =?utf-8?B?cjZKSUc4YWpjVGU2U3ZhdFhqblYxYUVYSlBEdnE5eThuTzg3cXJ0RGJ5cStV?= =?utf-8?B?dTZtMU84VjdPNE9aV3lJSjI3MDE5Z1ZWQkdGOUwrY2NYUFUwWlFyTkxHVVNj?= =?utf-8?B?SmtaUFVubG12YjhhU2ROcllnRUlPZmpqbUNZYnBTQlhjSzdIR1VpaTdLOHpk?= =?utf-8?B?ZGNxK1VxalY3V3Mza0V6NDMzdWRRV1JlWXNJZXNTVXhRaVp3a0hnM2FxWjF6?= =?utf-8?B?cDFQVTl3Y2NOamFzalo0Sm81OWcxQUx5T3ordkN5YzUyRTkrUG1adC9hZTVh?= =?utf-8?B?akFlSDI4NDQ3eFc4blMxV2k1L2QvWGtBcDN6dWNRdmIyczJ5NXZsYmp6STQz?= =?utf-8?B?RnBIUXk0eDlVNS9OYWtqbFJzZjFVdUlpUG85alpnc2xXVmN5YWZYaGF4QzNU?= =?utf-8?B?TjRra2doSnFNYWZrR2VlcENXOEZ1d1pvdk1LZkxsU0w0NUYvaE9tM2V5bVZS?= =?utf-8?Q?M7FcZfQd7Woc4ALGs48aErdQD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20194bd2-9855-4e77-c911-08dac0d20734 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 15:09:12.6661 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7mTSHgBx4I3P92GV2NCdfhree2QVxDD2Zt+Y5xoC/FFpiAxsZ9b8ncWXAeF2LNYxpVh+qK/UyMoL8ynLEqj1OQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9316 This reverts a small part of 7e21b25059ed ("xen: harmonize return types of hypercall handlers"). The change from "unsigned long" to "unsigned int" for the native handler function meant that previously invalid values became valid. While perhaps not a significant issue, strictly speaking that's still a change to the ABI. Don't go as far as restoring the compat entry point's type though: That one can't have values passed which don't fit in 32 bits. Note that as a side effect this fixes the invocation of hypercall_create_continuation(), which by mistake wasn't adjusted by the earlier change. Also take the opportunity and correct the respective comment in the public header. (The way it was it really supports that it probably was pointless to use "long", but that's the way the hypercall was introduced.) Requested-by: Andrew Cooper Signed-off-by: Jan Beulich --- a/xen/common/kexec.c +++ b/xen/common/kexec.c @@ -1213,7 +1213,7 @@ static int kexec_status(XEN_GUEST_HANDLE return !!test_bit(bit, &kexec_flags); } -static int do_kexec_op_internal(unsigned int op, +static int do_kexec_op_internal(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg, bool_t compat) { @@ -1265,7 +1265,7 @@ static int do_kexec_op_internal(unsigned return ret; } -long do_kexec_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg) +long do_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg) { return do_kexec_op_internal(op, uarg, 0); } --- a/xen/include/hypercall-defs.c +++ b/xen/include/hypercall-defs.c @@ -117,9 +117,6 @@ callback_op(int cmd, const void *arg) #ifdef CONFIG_ARGO argo_op(unsigned int cmd, void *arg1, void *arg2, unsigned long arg3, unsigned long arg4) #endif -#ifdef CONFIG_KEXEC -kexec_op(unsigned int op, void *uarg) -#endif #ifdef CONFIG_PV iret() nmi_op(unsigned int cmd, void *arg) @@ -149,6 +146,9 @@ update_va_mapping_otherdomain(unsigned i #ifndef CONFIG_PV_SHIM_EXCLUSIVE platform_op(compat_platform_op_t *u_xenpf_op) #endif +#ifdef CONFIG_KEXEC +kexec_op(unsigned int op, void *uarg) +#endif #endif /* CONFIG_COMPAT */ #if defined(CONFIG_PV) || defined(CONFIG_ARM) @@ -181,6 +181,9 @@ update_descriptor(uint64_t gaddr, seg_de update_va_mapping(unsigned long va, uint64_t val64, unsigned long flags) update_va_mapping_otherdomain(unsigned long va, uint64_t val64, unsigned long flags, domid_t domid) #endif +#ifdef CONFIG_KEXEC +kexec_op(unsigned long op, void *uarg) +#endif #ifdef CONFIG_IOREQ_SERVER dm_op(domid_t domid, unsigned int nr_bufs, xen_dm_op_buf_t *bufs) #endif --- a/xen/include/public/kexec.h +++ b/xen/include/public/kexec.h @@ -64,7 +64,7 @@ /* * Prototype for this hypercall is: - * int kexec_op(int cmd, void *args) + * int kexec_op(unsigned long cmd, void *args) * @cmd == KEXEC_CMD_... * KEXEC operation to perform * @args == Operation-specific extra arguments (NULL if none). From xen-devel-bounces@lists.xenproject.org Mon Nov 07 15:58:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 15:58:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439482.693489 (Exim 4.92) (envelope-from ) id 1os4W7-0005TZ-R3; Mon, 07 Nov 2022 15:58:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439482.693489; Mon, 07 Nov 2022 15:58:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os4W7-0005TS-Np; Mon, 07 Nov 2022 15:58:31 +0000 Received: by outflank-mailman (input) for mailman id 439482; Mon, 07 Nov 2022 15:58:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os4W6-0005TM-88 for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 15:58:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os4W1-0002BX-Pq; Mon, 07 Nov 2022 15:58:25 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1os4W1-00012I-IB; Mon, 07 Nov 2022 15:58:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=gawfQ8fum69TFLpKUxVmO2FsjqpivGtcUv2O0y1BViw=; b=qVYITVL8hRJyzIP0lsolelWyXe ePt8UaijlE5slmaYFmMYNkw6wJghKjBitaIvp+9P9kCWdncUYD6GZZTmJm0w8+oAkQJbZXi1KxiKO DbbE+UBPyM0VIL99hufRIIcS/sNGj6h9iVJcfxyOh1Cn+qwPf4yPiNyrcIAW9x37Vtm0=; Message-ID: <51eef76f-5b2e-c558-5caa-f457a9555f44@xen.org> Date: Mon, 7 Nov 2022 15:58:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [linux-linus test] 174539: regressions - FAIL Content-Language: en-US To: Bertrand Marquis , Jan Beulich , Stefano Stabellini Cc: Juergen Gross , osstest service owner , "xen-devel@lists.xenproject.org" References: <3c8a3be2-db65-253d-94ae-1bfcad1b94e2@suse.com> <3BA37602-681E-4A1F-8C01-0DAB8FB9262B@arm.com> From: Julien Grall In-Reply-To: <3BA37602-681E-4A1F-8C01-0DAB8FB9262B@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/11/2022 17:43, Bertrand Marquis wrote: > Hi, Hi Bertrand, > > +Julien and Stefano > >> On 2 Nov 2022, at 09:58, Jan Beulich wrote: >> >> On 01.11.2022 08:56, Juergen Gross wrote: >>> On 29.10.22 23:50, osstest service owner wrote: >>>> flight 174539 linux-linus real [real] >>>> http://logs.test-lab.xenproject.org/osstest/logs/174539/ >>>> >>>> Regressions :-( >>> >>> I'm rather sure this is not kernel related, as the issue is occurring only on >>> Arm and it doesn't seem to be an architecture related issue (the volume group >>> containing the root file system couldn't be found). >>> >>> Could it be an infrastructure problem? >> >> Why would such manifest on only linux-linus? Along the lines of what I >> did say in reply to flight 173480's report I continue to think that >> there's an issue with the loading of a driver, perhaps because of a >> bad / missing dependency just on Arm. Sadly the log doesn't have any >> data in that regard (perhaps because of too low verbosity), so I >> suspect finding out can only be done by someone with actual access to >> one of the affected systems. > > @Julien or Stefano: Can one of you check this ? Sorry I was away part of last week. I will have a look this week. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 16:16:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 16:16:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439488.693500 (Exim 4.92) (envelope-from ) id 1os4nc-0000Pk-Bl; Mon, 07 Nov 2022 16:16:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439488.693500; Mon, 07 Nov 2022 16:16:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os4nc-0000Pd-8M; Mon, 07 Nov 2022 16:16:36 +0000 Received: by outflank-mailman (input) for mailman id 439488; Mon, 07 Nov 2022 16:16:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os4na-0000PX-De for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 16:16:34 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150082.outbound.protection.outlook.com [40.107.15.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b7a8e98-5eb7-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 17:16:33 +0100 (CET) Received: from FR3P281CA0105.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::6) by DBBPR08MB5884.eurprd08.prod.outlook.com (2603:10a6:10:1f6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 16:16:25 +0000 Received: from VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a1:cafe::9b) by FR3P281CA0105.outlook.office365.com (2603:10a6:d10:a1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11 via Frontend Transport; Mon, 7 Nov 2022 16:16:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT052.mail.protection.outlook.com (100.127.144.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 16:16:24 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Mon, 07 Nov 2022 16:16:24 +0000 Received: from 6ebcb3df0c69.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 29F517F6-1E3D-4BAB-8313-E7004DC60343.1; Mon, 07 Nov 2022 16:16:16 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6ebcb3df0c69.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Nov 2022 16:16:16 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DBAPR08MB5654.eurprd08.prod.outlook.com (2603:10a6:10:1a6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 16:16:14 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5813.011; Mon, 7 Nov 2022 16:16:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b7a8e98-5eb7-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BfjdcWcdiFdwiu/KmvwyYBGOvIC3cMIS/O8HhHCOTEBJ78qLEZZPt0kkUv97Q785q1i6PnZpPiIFDVJtiVkyoX2uL98Fr7tu7eeV+1PE0KnWI98KsjHRbQI2BvojNMTRdXsuW+IUTK1cdPSv5fxE+gZ4zsTF4bZzGWKXamrEgji26vCPhPGkSp1M0V83Z+zOJq6HsQp1gq0TsGnl1o6mZsPJa7+m9a1zxuaUJGbAQcsSypR3vSfc5IprxHsviFj2/w0s+itklAfFNOqgaO65Vfzkwy7LQbPizcN6wdbQB9jnCJJ6d+dnqfKDyumwQSyUwQtSStTVPcnD7DlWaq0KCQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VQRdhziFnmVn8OW3rSTa+EhsyrqzDkX3SK1zJ1IgXxU=; b=K/Uy0cEvGzo+8mtbQsqMsGrbCxjhuFcCSujEvmXWkzRmP85X2NLC7pTUVuGfrISuTsQakqJDq/HQj0NBwpwmNwMfnFoqrqCG3av31VTDsaS42bD92xpBG6NFTSFtkz4tsJ6LE0v7rablJaAr0+8yZRb5kN0GDQtrU7jgaw4sTjD6qB3XvmRm3ywrAa1kdfRwTuDJK5vO3Zh4tB/1+wFzQcgyGNgJtYSgzGrz9wnhiIPzeJbz+GcT2ASV1kjE6QbAO4Wco8gi4OoJpL2vg5OUdtX+UMfclD32iYzdrvHTDHwOWqXGfNBnblgA1UVQ8djPfS27iQuYWbOrB5zSbF1KrA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VQRdhziFnmVn8OW3rSTa+EhsyrqzDkX3SK1zJ1IgXxU=; b=CQJVW0B72LRVW7rYI4wHkHhiOpDNZtqAbIGsbRt/Ju282AU7dbBa1bJaCLUogH+H8TCMjpdm/PuCyCEl4Ci/A6XKfSaHLJQj64MbBLvvFt/xHNSH4Kpik0SSwXx4DQnig/9f1iZaE0aOEwb7M9evDhb89NJ2WkMaDO6nROe1J3A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 27b6f2342f10bc34 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N4Z7dge6cZJ1955kvU5YzA+9/5OxgS4tP6Wil2+TG9xDifE8jRSowCj1DGaWVStHEx2rTIEv4D/toat1fHqKwIY6jeic6a4lviQrK3MJswR5nJF8cNULXJRXXPp4cpMPM+ncg3jzt1wS6M59IPp5ewlu1P4a6HOBEaK0C0HWAdyJVG6wpmBIxbs/7FY/dfO8nP5g80infAYmxUoJn6FCs5H50vtLzTxqaxRmgBURYDKX3bgL6gojs8Vgy40pWbU/4TDTgfWhR9nU2SqZyJjbcCXdxk8X+3Qr6yjd2u6aNk8b1+2co5zOfGkrLCXxSN5ETW4Mrygn8MvsPHeSLG5SBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VQRdhziFnmVn8OW3rSTa+EhsyrqzDkX3SK1zJ1IgXxU=; b=QqDDQ5FeE9nBRfDCW2c06AxCdaiCygg5P4NHiRJkwzdRBW2zzJtJsVSdDnqJUeqfWYfOvSCV4LxelW6L+elA9XUulwjoxF9DbeEsvIb4XI4Ik5k7HCQ2S+2o9t5TIGeiUhrncspukw0ROwegdD2woy3DTWqQz0oem/6AbYStihH11IMBlgEbH+96VtXOfuXTq/jBRTEDQq3VkQ982GfgFc80k4/rnv+9/wfnixj1NS1bstyQMqcM3uzS33olLSVPNmjUdvw1qwiRzl6qglUkEymnN8BXebwq6YmJ8tDsDpfAY0hX1E9+6kVeruW9c50NPA4DqwKI0EiL1wehCEUzgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VQRdhziFnmVn8OW3rSTa+EhsyrqzDkX3SK1zJ1IgXxU=; b=CQJVW0B72LRVW7rYI4wHkHhiOpDNZtqAbIGsbRt/Ju282AU7dbBa1bJaCLUogH+H8TCMjpdm/PuCyCEl4Ci/A6XKfSaHLJQj64MbBLvvFt/xHNSH4Kpik0SSwXx4DQnig/9f1iZaE0aOEwb7M9evDhb89NJ2WkMaDO6nROe1J3A= From: Bertrand Marquis To: Julien Grall CC: Jan Beulich , Stefano Stabellini , Juergen Gross , osstest service owner , "xen-devel@lists.xenproject.org" Subject: Re: [linux-linus test] 174539: regressions - FAIL Thread-Topic: [linux-linus test] 174539: regressions - FAIL Thread-Index: AQHY6+CQ4VZAde/T6k6I0fM4JzEhfa4ptwOAgAG0q4CAAhQYgIAGK/+AgAAE+wA= Date: Mon, 7 Nov 2022 16:16:13 +0000 Message-ID: References: <3c8a3be2-db65-253d-94ae-1bfcad1b94e2@suse.com> <3BA37602-681E-4A1F-8C01-0DAB8FB9262B@arm.com> <51eef76f-5b2e-c558-5caa-f457a9555f44@xen.org> In-Reply-To: <51eef76f-5b2e-c558-5caa-f457a9555f44@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DBAPR08MB5654:EE_|VI1EUR03FT052:EE_|DBBPR08MB5884:EE_ X-MS-Office365-Filtering-Correlation-Id: 2982feaf-27a9-412b-eca2-08dac0db6aab x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 56cnEJlMpHWuBfF0tUjgShnOlWOGnmNNUANWw3Y3G7ljSq9w3dlKbiwFKvVcMIBx4JV4DKPYnufmNyiHD24MRmStwje+WquPHTKgLTbYxfwu70bNcxOdNpu7VV4W92haziprGj1jTlPtORJJZmH9QUBGivZ5wmhS/GZXvLz/xFMthtZlam5RIZStVswFwxloGN0KAXL1TuK6u0zvCaHpHG/+iNfw7bDLgzyTfvA8f2Ed4pWhUsNs7+XOMUumjWto7sUZAhwazt9vu+SJO0aAhmWnz2zQH9GAj9DlYDD8fB0Cq7tl5TX6Ewc0MR+G3GTPIbeSTkTsL3gXKixKh6i8+IJUE0LbPk+0BiPrbS+gqvq2ESyLSuo/f8qwXccUUPqL00U7EzWxb2ho97OotWph2NYiSSoDUbWC+yZov/tI4v7cxmUaGjMGWqgaM5N26feZe8qGfLAb6inDdBF3DBmqtUF14nPTBYvf5y+vGHyDiZhGGapzw59WNCsTfNJ1iugSSy4SzMVMG+VG++8EFKzApuXa3qv7VOLhPx7olxYV6m9fSgMz3IG16XDiQDEmjAPN4nbDmNp7yAzmmybh+86kWnXxUPKmiY81tMAUZAtu9oAAkPjqT5JEopi5acXmLHaVQ/JrIZiPDbeDJln+gmmM6vun9nkDH7JXCHdEGIU+3hA2pHJBzQ4lGKFC5bmV13CtBDRygZ1Kjx8zNehPlsC4Lsnf4kpYF4ugUSEpQJfQQeko/B/+h3UM7LkxYXo1L71ZkHjdusDX5ltgmnuVzPeZvmVb9tRIvcqSLZaOaZrQ8/CTHsSOvhIq+vdmI1NZD6aJVnVoMYeoDRurVKbo47Iocg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(346002)(136003)(376002)(451199015)(6486002)(8936002)(5660300002)(33656002)(83380400001)(66556008)(316002)(66946007)(41300700001)(2906002)(36756003)(76116006)(66476007)(64756008)(91956017)(478600001)(6916009)(66446008)(71200400001)(54906003)(4326008)(8676002)(186003)(2616005)(966005)(38100700002)(38070700005)(53546011)(6506007)(86362001)(26005)(122000001)(6512007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5654 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 23168df9-296d-4350-71c9-08dac0db6421 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /i2yeo7Hd7mVUcgTkh/gifNcspYaWUccd3uw+EHNxRA3kxy66PcUs8l/R0Hg4XnNvP2S3hzWpilVi5FhixYAVqT3FMBwvqJ7AXoTfJZ8AntWBX9CDhY3MtlhqZH5Pq4VI2KKUAhPMwoDUgv2KiCrKk6bxPiKExn9IiJV+Ap083H/rVNL6Kki1v89Uq7KV3QXYH7PMcQTKaB/NkicAn/1N0EWybFkxO2GyhidzNuhGcQMEfgPWlpNF4VCt4xYJpJzMDU187tT6S3mFE0itqYesGzHjLwjwj/sb/QDfamVtPDht3hyfofFFB2oIHZps/eb/XV2KBGgknxolNJjR6hkHPsHKIZkK5bac6QzMKXVp2NoabyXoPObjIDHvzz11QyXaqw+UJEh/4yYglafVqYeNBWQF+XDRkuRcjrXBrkw45FadC0M+wUmAhgLm1oDBJd6r0YDXTw/p94obeNDeeyro25X6EiFqg5zdThGjMDP/WNyqXMfBiiM2K3dBoU/rnSTTx1OftlomQdKb+DCF4zs5TKqdhutKXxB7XRmTf1ehtD3jKyXD+4EXN/LKkCCTP289jpTf7oQ6A+99YIo/22REfp50YhSe9jDw7RFxrM5mQ7/fOrAT55h9xqP9PthCquRaIrAeJhcpWlNvlBb6ww0B7sZD9paE41sdehFD14wZfl9+ywNi9M1UyLagHngEI1AOVAv1Re6ZMC4Jlxu0QNDvb+ulkOww0XAzOUySmcU2ey+ld949u+uJtjE50kfpI/Em6QGehg4TqZr/oMB6tjNkinmmwOSBVOEHbWXVkr/GOUoAUiNlIXl3yBqegrw7AVS X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(40480700001)(36756003)(33656002)(81166007)(86362001)(966005)(316002)(6486002)(356005)(54906003)(82310400005)(36860700001)(478600001)(82740400003)(6512007)(26005)(6506007)(53546011)(8936002)(70206006)(8676002)(4326008)(5660300002)(70586007)(40460700003)(336012)(186003)(47076005)(83380400001)(6862004)(2616005)(41300700001)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 16:16:24.5275 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2982feaf-27a9-412b-eca2-08dac0db6aab X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5884 Hi Julien, > On 7 Nov 2022, at 15:58, Julien Grall wrote: >=20 >=20 >=20 > On 03/11/2022 17:43, Bertrand Marquis wrote: >> Hi, >=20 > Hi Bertrand, >=20 >> +Julien and Stefano >>> On 2 Nov 2022, at 09:58, Jan Beulich wrote: >>>=20 >>> On 01.11.2022 08:56, Juergen Gross wrote: >>>> On 29.10.22 23:50, osstest service owner wrote: >>>>> flight 174539 linux-linus real [real] >>>>> http://logs.test-lab.xenproject.org/osstest/logs/174539/ >>>>>=20 >>>>> Regressions :-( >>>>=20 >>>> I'm rather sure this is not kernel related, as the issue is occurring = only on >>>> Arm and it doesn't seem to be an architecture related issue (the volum= e group >>>> containing the root file system couldn't be found). >>>>=20 >>>> Could it be an infrastructure problem? >>>=20 >>> Why would such manifest on only linux-linus? Along the lines of what I >>> did say in reply to flight 173480's report I continue to think that >>> there's an issue with the loading of a driver, perhaps because of a >>> bad / missing dependency just on Arm. Sadly the log doesn't have any >>> data in that regard (perhaps because of too low verbosity), so I >>> suspect finding out can only be done by someone with actual access to >>> one of the affected systems. >> @Julien or Stefano: Can one of you check this ? >=20 > Sorry I was away part of last week. I will have a look this week. Thanks :-) I was not really looking forward into understanding OSSTEST righ= t now ;-) Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 16:28:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 16:28:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439494.693510 (Exim 4.92) (envelope-from ) id 1os4z0-00028F-DM; Mon, 07 Nov 2022 16:28:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439494.693510; Mon, 07 Nov 2022 16:28:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os4z0-000288-AW; Mon, 07 Nov 2022 16:28:22 +0000 Received: by outflank-mailman (input) for mailman id 439494; Mon, 07 Nov 2022 16:28:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os4yz-00027w-3A; Mon, 07 Nov 2022 16:28:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os4yz-0003NM-0Y; Mon, 07 Nov 2022 16:28:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os4yy-00078e-EC; Mon, 07 Nov 2022 16:28:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1os4yy-0000wE-Dm; Mon, 07 Nov 2022 16:28:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MCfcXmYLX8QLUqKFqn1t6/GFhw/wwhZ5c7SCj13l3eo=; b=1i2e9kJbIYmL6Dy0JwF0rnV4+8 QNrE73bjp+K+FZiLkW+qzOkq8/Kl2F1W139NqaowzYbUf75oVTl0HsU/14coU+WlHivNtrWGS4uac O71QjFa74HimiWjzOxPu4oJ/IIWPDKq/1CKn7PDnpET7/c25y/tWLU6sjbb0ydDTqOTY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174654: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt::broken:regression linux-linus:test-armhf-armhf-xl-rtds::broken:regression linux-linus:test-armhf-armhf-libvirt:host-install(5):broken:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:host-install(5):broken:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f0c4d9fc9cc9462659728d168387191387e903cc X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Mon, 07 Nov 2022 16:28:20 +0000 flight 174654 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174654/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-xl-rtds broken test-armhf-armhf-libvirt 5 host-install(5) broken REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 5 host-install(5) broken REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux f0c4d9fc9cc9462659728d168387191387e903cc baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 30 days Failing since 173470 2022-10-08 06:21:34 Z 30 days 48 attempts Testing same since 174654 2022-11-07 03:45:58 Z 0 days 1 attempts ------------------------------------------------------------ 1598 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt broken test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds broken test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt broken broken-job test-armhf-armhf-xl-rtds broken broken-step test-armhf-armhf-xl-rtds host-install(5) broken-step test-armhf-armhf-libvirt host-install(5) Not pushing. (No revision log; it would be 152447 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Nov 07 16:35:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 16:35:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439503.693521 (Exim 4.92) (envelope-from ) id 1os55w-0003rg-8d; Mon, 07 Nov 2022 16:35:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439503.693521; Mon, 07 Nov 2022 16:35:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os55w-0003rZ-5c; Mon, 07 Nov 2022 16:35:32 +0000 Received: by outflank-mailman (input) for mailman id 439503; Mon, 07 Nov 2022 16:35:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os55u-0003rT-Q1 for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 16:35:31 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60083.outbound.protection.outlook.com [40.107.6.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 307f0419-5eba-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 17:35:29 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Mon, 7 Nov 2022 16:35:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 16:35:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 307f0419-5eba-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f2pjlE6aM8gaC6YoO17WqVH/6rt0Zk8yIBMdRp45CoJ5HOSbLJyh7+v6FMj1l9YzO05+YUe21XKO06BmVcvNGoWRSQwpR0Ze/efSamd4jnb91EBpe4WGL1oV+FrBfbi4CJt4U3fh2eaZq9COwef63GxK8RCDo+50X/XRbQdjmpGt7GDjoLQylOsV4rRdkj4RMtkisYz2wAQMODh6PBpR/8/v88Y+bpDoiF0FGm1h78TkPMAqLCL3WasMMGcC8f48w6RQfz6HegZuaXFUOkI54j7tZkNcJw1puGZbk35BDKfka8OR01cgT5hb4Yt1Q5MFyq+C7r14z6sxoZJRa/65Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rkryOQpiG5imWtvlvruFNVJCPJ5uPxQikcqLQVyA+WM=; b=kii3/bJOsUJCfg+uYDZyW95UcvgbxopTji9mvcaaWg3N4JKbS/kV3sysodfDFCLr0b/zbdbhOxA+TwR/8gGwsLnOpFuOIGeDvq9GyM2vocgLgg2GpnwBDQBQd+BLGfX5AVHvgqKd94QqHiYscfuykKR+8pWTvaRHJSdN7RU9DQTdohO/9+9b+m1W+LrwdUVBtlrK6gCnZyCobWWIjWNOpMMuDBa6s7bAyy8D6uaxFQz+WRcrmfGFpvMg3Ds+ICnSTRQ/MMrNabI71ZQaK20OP7+Zq60HkrF2SSacU2lJyTrwftkDoTx7D1Du4SDbigxNqqp9js9ouX+/8azo6vtm5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rkryOQpiG5imWtvlvruFNVJCPJ5uPxQikcqLQVyA+WM=; b=zFp3wV4j+YHqjNv1KrdKpjUevTq+jPvg2QU+WIiTu553utusU4FTTR2DrUawJh+3acsYkoVa4pg2ldOOR/gpebrur+7Kvd4fylFS/WXUEPDOESETNg2kZowQlVOVjksiFx0D24pGbvEaTLiyeaiA6suU5GMiKnAiAmlC2p+JKLBWKCuF5exwIi37uCTHhrZgcIhVsqyC/ib3JDuPBHTv/aPFE4ELL9wH84bjGUzscbo7+nPW375rhQHDGq9RLeoDW3Sa0FAS1KSLpLXhsSQ3VdFkQBg4wZVdJ2NHPeguuMsfSovYaVYe75xmZUN7CZti+xCJledwXmC2zS3l99Bf+Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Nov 2022 17:35:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Content-Language: en-US To: Luca Fancellu Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> From: Jan Beulich In-Reply-To: <20221107104739.10404-2-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9P251CA0003.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:50f::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9067:EE_ X-MS-Office365-Filtering-Correlation-Id: 31ca850f-919e-4889-5a9c-08dac0de130e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GDdJi51jQRFaPKU4OLY1ZnPycMFyv4SzEukISIsGeHvd0lhglevP4qfXJP04yRBpzS9bRXV0k/mVSEnEfSapFd8aYdcjPykKgGrLRaSI9aefhEH182NlZYZKdHpv/70oVTtpxaIyzOCbp9ywlS9oh2M6RrRsftgQmhfy/m4+Y+wX90l6LxMN42041/LhD+W/6GpQnf1DBjZPFHqQu7HfFOIkxLI5FXFV0Yy23onhXQKwVgSi2ltOBAb5VD8KjI4x5jS0p7zw/JpTGjVmVZG67g56O7rdeV5MpHa2dQTCf8PcqpOjrgK3kNVSTKIEZ4scFBzMS939OZHqdEoZYLolwrpOG7PmHz8c88zTuThLZvJhbgpxnZJNeGhFAUXxc0qcr9roPKDB6PftUkwLXfCaPDCpRo0nMurpz4eWWxNCziourqG7NtfOAT971dna1iNsxmPJTSjqxO3tOEwjGQ44yM1UwisTcCRyADcO/n5o4SWGvPOV4Qq3dx7xOZt2sp38WKt99LGiMjhWPwiSGMFKkgDOmwPfZtk9eOBZW7xyy8sFWQkAvj/s8upnJnp4Az6onYoaik5QU3x3N0DwthftxKJgajjO751PjZrBe48p3NpQFKetlhzjbqqtjPknSHdNQU6QhWDn5ZeRtZ7XqTXKYaOxp9BBRWetHLCELhiotpx6yWVPjzM/f1DDKaJ9CCOZLIfR3kIkrc6Kakas8rW7kp10Hiihr/hnm0wnubMlTSKWxG/mr+4aEDbr379YE3OU2ufmrYHHFuk6zjRepnv9IrP7Fp/cqZIf88oksh/YU+0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(396003)(366004)(346002)(376002)(451199015)(66899015)(36756003)(31686004)(86362001)(31696002)(5660300002)(6916009)(2906002)(26005)(6512007)(2616005)(6506007)(53546011)(186003)(83380400001)(38100700002)(54906003)(4326008)(478600001)(8676002)(66946007)(316002)(66556008)(66476007)(8936002)(6486002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q21Rd2E2RnF0MGpVMU9tdCtQMFpyWEg1U3dUVHZFNFNiR09YQ2ZDTVZXREJT?= =?utf-8?B?SVBkYno2VkNEcTVlRzlPeWEvTXU3dmxnWDl1TDAyQ2g4T0cvZ084V3kvTFZW?= =?utf-8?B?NENDYmh3RXA2bVczZ25yUEZHd3BHdXpRUE5RTW5HamxXMTFqc2dJZWVLdkQy?= =?utf-8?B?d09TL2QzZUgrNW9ZclQxSjM5RG13Q0xrbjdaRUVpYWxjdUhEbXN6a2pqMmFz?= =?utf-8?B?UWNGZTVISTV0K00rMHpTOGYyMHpWbHBmY09ncWNwOStPUDlIS1pyQUp5Vit6?= =?utf-8?B?amd5K1NOcElkd2lIdFZJNm96dXRSRUp5UzNmYXU5cTVFTWxBMXVTWEZ3Ny9u?= =?utf-8?B?N0kvcnZoVDV0ell2R0UrRi9CWHd6R056Q3o2Tk1RVkVGYmV1VjVpQlliaDdR?= =?utf-8?B?bGNCTlF6Mis4QmpXZVlrZGk4dWp5djU4VVhVZXg1ZTNCRmFHbnJZZ0hrVm9l?= =?utf-8?B?eFpOcGUwWklWNVorU01QV1pxSFkwS09XR1pUdUcyY09TQlB2NjlyREJpNlR2?= =?utf-8?B?OUZ3d3RINjMzTDdLTEY1TmVKNDFnMy9VSEZ4SE9mSGc3VzBLUE4xd1Mzd2tk?= =?utf-8?B?dDYzOVdVMHYvSXhhc2xzQ0g0T04wYmZrV0U1Z25mc3RjTnFhZ3V1WFB2N1ZM?= =?utf-8?B?YzgyZU1uSnp0dlYrMzBObkdsTWYvWUhMV0tVY21xVk9Ma0d3enozWHlXVHJC?= =?utf-8?B?UjIrRUFoV0h6N1grVHlIMnlVWVBkcnVMbWhiSldBOXFZYlo0c3ZHK1YzUGF2?= =?utf-8?B?U3E2TmZWcFpib3p5bmlYZzlleW5iRGxpL1dzMGthWFIwWUcwRURrTDB0azhL?= =?utf-8?B?OHl1ek5TZUV4bk9JQU9KK2JSSTBDZkhaOTduc0g3a25SSFMrdzdpcWlZQ1Uz?= =?utf-8?B?RTgvdkJyMkJLR1NvSkNQbkVxU0Nna1ZuNCtnYUtHUzVKekxabTlMNXFTMzBp?= =?utf-8?B?MzdTU2x3WWhabVFhQTRMVUd6S2hBR3UyMEdqNzV4RE9lVFJ5N2hhVDBJNUdB?= =?utf-8?B?TDBpSUVHSWFNMllYdVdiWlEyOEVNTkZiK2UzaGkrRFhPSnRjUWtzdlVpVmlj?= =?utf-8?B?djZZaHl5cnp4WUxSMVRQcC9CWm9oWkRNd08rYndvNHVOdzA0dU84OHJ3YXY2?= =?utf-8?B?c3cwVzlMaXhTVnp5VDJ2UnFRRUhrTmlaVHV4MDFwd1BEQnRvellkNitlMnJ5?= =?utf-8?B?YkJvT05ja1NUSER6RzB4b3lQaU91MEZOWm1NU3Fpc2JZYmN0d0pCTG9DM25h?= =?utf-8?B?TVlOUlRVSDhEd2lmZTcyOUxOS1BIWDdYRmJyb0pSdTZJb3VoRHlnTzBxSmhQ?= =?utf-8?B?VUxMTW43L1FISXNBc2RkTE9tU3gzVTVoTUUweWVydGVRcElXVnB5NnY2bDFa?= =?utf-8?B?RGxzMFZtU00zZU5ZaEowVzNSYi9nbkxoRzBtVUxyNWYwdHRpd0NNRjY4VXVG?= =?utf-8?B?UFdycEdlN2hram9xQktZTzNoVTA5MnE3bzgrVlVjbGpNTTY4UWc2dThPcm4r?= =?utf-8?B?WnZYMXptQUFNb2g1K1RsWVI5c3F6Y0YzZVFManJGdmpzak5qL1JaU1krT0Ro?= =?utf-8?B?R1FMellYMldlWUtweWhXUVNKTHVObFUyUFJ0NGxwTy9QRkFuQUZ5YURRaUEv?= =?utf-8?B?em9UcHh1ejhHRlZxcmF6NE02TzFOVTE1WlBiUmYvcFBRTDNyU3ViYlhvNHZu?= =?utf-8?B?U3RZRzE4RGcwREVkTHgxMGhlL0FYbjM5REpSNDBsYUlHQWJSaG1XbkJOZEJS?= =?utf-8?B?NEsrY3hKUkt0VFZab3lwdnZGYnBheHBaNG9weFU0VGUvRHd1OEU5VHlVYUJm?= =?utf-8?B?dEsrN3IrSVN0UCsvR3psQnJyOXdVQllScHVGWm4wb0xNMlNPa0MraitMQlVI?= =?utf-8?B?ZVhxYzZxdFZrY2V2eG4zaHZLYWtMdDAxclA2dnkveHpWZ1hBU2FZZU1leW01?= =?utf-8?B?NzJzYjN4RTdHckltNVJXNmlEUW5uK3pGY2cwSWhXRXRmTDdCNTdONUVnWGhk?= =?utf-8?B?YlVYTlpLa0dYZDhiMW1LcEdHQkpXUmJXOWlHcTdiKzZxT3B4VWE3ajhyYWx5?= =?utf-8?B?WjRMUXpFczA5UXZwTlcwb25wM3lvRFp0aEZoTXl1Si9zQlU3b1lIcFZDZk5t?= =?utf-8?Q?Ph224tfOIQQy6MilctevkUL0+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31ca850f-919e-4889-5a9c-08dac0de130e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 16:35:26.2733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xRYBi4/j49aexGLPKI1oD4NFixsr395ueC5BhmCyqTbmitWMr4+6AvtRt7xHfjnCnVu7WlAS0EBOKLsJFDDPMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9067 On 07.11.2022 11:47, Luca Fancellu wrote: > +Here is an example to add a new justification in false-positive-.json:: With already present in the name, ... > +|{ > +| "version": "1.0", > +| "content": [ > +| { > +| "id": "SAF-0-false-positive-", > +| "analyser": { > +| "": "" ... can we avoid the redundancy here? Perhaps ... > +| }, > +| "tool-version": "", ... it could be "analyser": { "": "" }, ? It's not really clear to me though how a false positive would be correctly recorded which is present over a range of versions. > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -457,7 +457,8 @@ endif # need-config > > __all: build > > -main-targets := build install uninstall clean distclean MAP cppcheck cppcheck-html > +main-targets := build install uninstall clean distclean MAP cppcheck \ > + cppcheck-html analysis-coverity analysis-eclair > .PHONY: $(main-targets) > ifneq ($(XEN_TARGET_ARCH),x86_32) > $(main-targets): %: _% ; > @@ -572,7 +573,7 @@ _clean: > rm -f $(TARGET).efi $(TARGET).efi.map $(TARGET).efi.stripped > rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h > rm -f .banner .allconfig.tmp include/xen/compile.h > - rm -f cppcheck-misra.* xen-cppcheck.xml > + rm -f cppcheck-misra.* xen-cppcheck.xml *.sed Is *.sed perhaps a little too wide? But yes, we can of course deal with that in case any *.sed file appears in the source tree. > @@ -757,6 +758,51 @@ cppcheck-version: > $(objtree)/include/generated/compiler-def.h: > $(Q)$(CC) -dM -E -o $@ - < /dev/null > > +JUSTIFICATION_FILES := $(XEN_ROOT)/docs/misra/safe.json \ > + $(XEN_ROOT)/docs/misra/false-positive-$$*.json > + > +# The following command is using grep to find all files that contains a comment > +# containing "SAF-" on a single line. > +# %.safparse will be the original files saved from the build system, these files > +# will be restored at the end of the analysis step > +PARSE_FILE_LIST := $(addsuffix .safparse,$(filter-out %.safparse,\ > +$(shell grep -ERl '^[[:blank:]]*\/\*[[:space:]]+SAF-.*\*\/$$' $(srctree)))) Please indent such line continuations. And then isn't this going to risk matching non-source files as well? Perhaps you want to restrict this to *.c and *.h? > +.PRECIOUS: $(PARSE_FILE_LIST) $(objtree)/%.sed > + > +.SECONDEXPANSION: I have to admit that I'm a little worried of this living relatively early in the script. > +$(objtree)/%.sed: $(JUSTIFICATION_FILES) $(srctree)/tools/xenfusa-gen-tags.py > + $(PYTHON) $(srctree)/tools/xenfusa-gen-tags.py \ > + $(foreach file, $(filter %.json, $^), --input $(file)) --output $@ \ > + --tool $* To reduce redundancy, how about $(objtree)/%.sed: $(srctree)/tools/xenfusa-gen-tags.py $(JUSTIFICATION_FILES) $(PYTHON) $< --output $@ --tool $* \ $(foreach file, $(filter %.json, $^), --input $(file)) ? > +%.safparse: % For this to not be overly widely matching, maybe better $(PARSE_FILE_LIST): %.safparse: % ? > +# Create a copy of the original file (-p preserves also timestamp) > + $(Q)if [ -f "$@" ]; then \ > + echo "Found $@, please check the integrity of $*"; \ > + exit 1; \ > + fi > + $(Q)cp -p "$*" "$@" While you use the full source name as the stem, I still think $< would be more clear to use here. To limit work done, could this me "mv" instead of "cp -p", and then ... > +analysis-parse-tags-%: $(PARSE_FILE_LIST) $(objtree)/%.sed > + $(Q)for file in $(patsubst %.safparse,%,$(PARSE_FILE_LIST)); do \ > + sed -i -f "$(objtree)/$*.sed" "$${file}"; \ ... with then using sed -f "$(objtree)/$*.sed" "$${file}.safparse" >"$${file}" here? This would then also have source consistent between prereqs and rule. > + done > + > +analysis-build-%: analysis-parse-tags-% > + $(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile build This rule doesn't use the stem, so I'm struggling to understand what this is about. > +analysis-clean: > +# Reverts the original file (-p preserves also timestamp) > + $(Q)find $(srctree) -type f -name "*.safparse" -print | \ > + while IFS= read file; do \ > + cp -p "$${file}" "$${file%.safparse}"; \ > + rm -f "$${file}"; \ Why not "mv"? > + done > + > +_analysis-%: analysis-build-% > + $(Q)$(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile analysis-clean Again no use of the stem, plus here I wonder if this may not lead to people invoking "analysis-clean" without having said anything about cleaning on their command line. > --- /dev/null > +++ b/xen/tools/xenfusa-gen-tags.py > @@ -0,0 +1,81 @@ > +#!/usr/bin/env python > + > +import sys, getopt, json > + > +def help(): > + print('Usage: {} [OPTION] ...'.format(sys.argv[0])) > + print('') > + print('This script converts the justification file to a set of sed rules') > + print('that will replace generic tags from Xen codebase in-code comments') > + print('to in-code comments having the proprietary syntax for the selected') > + print('tool.') > + print('') > + print('Options:') > + print(' -i/--input Json file containing the justifications, can be') > + print(' passed multiple times for multiple files') > + print(' -o/--output Sed file containing the substitution rules') > + print(' -t/--tool Tool that will use the in-code comments') > + print('') > + > +# This is the dictionary for the rules that translates to proprietary comments: > +# - cppcheck: /* cppcheck-suppress[id] */ > +# - coverity: /* coverity[id] */ > +# - eclair: /* -E> hide id 1 "" */ > +# Add entries to support more analyzers > +tool_syntax = { > + "cppcheck":"s,^.*/*[[:space:]]*TAG.*$,/* cppcheck-suppress[VID] */,g", > + "coverity":"s,^.*/*[[:space:]]*TAG.*$,/* coverity[VID] */,g", > + "eclair":"s,^.*/*[[:space:]]*TAG.*$,/* -E> hide VID 1 \"\" */,g" > +} > + > +def main(argv): > + infiles = [] > + justifications = [] > + outfile = '' > + tool = '' > + > + try: > + opts, args = getopt.getopt(argv,"hi:o:t:",["input=","output=","tool="]) > + except getopt.GetoptError: > + help() > + sys.exit(2) > + for opt, arg in opts: > + if opt == '-h': > + help() > + sys.exit(0) > + elif opt in ("-i", "--input"): > + infiles.append(arg) > + elif opt in ("-o", "--output"): > + outfile = arg > + elif opt in ("-t", "--tool"): > + tool = arg > + > + # Open all input files > + for file in infiles: > + try: > + handle = open(file, 'rt') > + content = json.load(handle) > + justifications = justifications + content['content'] > + handle.close() > + except json.JSONDecodeError: > + print('JSON decoding error in file: ' + file) > + except: > + print('Error opening ' + file) > + sys.exit(1) > + > + try: > + outstr = open(outfile, "w") > + except: > + print('Error creating ' + outfile) > + sys.exit(1) > + > + for j in justifications: > + if tool in j['analyser']: > + comment=tool_syntax[tool].replace("TAG",j['id']) > + comment=comment.replace("VID",j['analyser'][tool]) > + outstr.write('{}\n'.format(comment)) > + > + outstr.close() > + > +if __name__ == "__main__": > + main(sys.argv[1:]) > \ No newline at end of file Nit: ^^^ Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 07 16:58:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 16:58:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439518.693532 (Exim 4.92) (envelope-from ) id 1os5Rn-0006o4-Uo; Mon, 07 Nov 2022 16:58:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439518.693532; Mon, 07 Nov 2022 16:58:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os5Rn-0006nx-SA; Mon, 07 Nov 2022 16:58:07 +0000 Received: by outflank-mailman (input) for mailman id 439518; Mon, 07 Nov 2022 16:58:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os5Rm-0006nr-GQ for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 16:58:06 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062.outbound.protection.outlook.com [40.107.22.62]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 58af280d-5ebd-11ed-8fd1-01056ac49cbb; Mon, 07 Nov 2022 17:58:05 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9299.eurprd04.prod.outlook.com (2603:10a6:10:356::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Mon, 7 Nov 2022 16:58:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 16:58:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58af280d-5ebd-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ek8c9VvBWA3N0TSm+1vQxJHsZ5grOfgbwR67pjDAm5gUucu11NkrdvjPVybOtTe55SZmvegJQy+7mj89LGtp+ynaDoe6GjEVu/duXXRul7cb2+/D+TorFZyBzp4fZn/prW/YxWl924iPKW9Uscu2LjQOT6As0mW+ZC4lDgm2eb/BQOXsO09ewV7LZDu+eiRbK1h4BJZQQjXiZs6dGa3JgDvngy+xGMCozleXZ0Lz8rzA8ugzgeZKmig/kKwQj61itySwwMPxkXrMDJWFVscd0cefqoa28X7vfTJ+AGHEmn9xwpHOiePTfR9icybpXvtY7kMRmC+wx4HVTAyqDAGPtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SJfLxzj4Aen0EOaZb5flGHyz7PKsrvFaIHE7OOYdv1o=; b=ADh0pwfUubDLWEPFfBaKyoNHHSx2mSB8ctzZitmsJ3I1UGRuw08Ljg/iUTP0Knn6BhcYt/bMwarbL/HOpRcDz8enXhWJiQlpoTrfg1hjNu1QORffxCQ+Yhc+C98NriQk+tNUgN8SW18YHnsXiLW+1QGC7ujGQAdCm+HHQv8PquaGpD6iFVPufny4ScEjHh1j6TEOiHFu2SIX7/JPAk0dZ23XC7T5qbeO/WFNtfo9K03nLgBlwQsbb9ehBUHoU/FbscNc7ez49vh6J+T3Qr4RAoDgqUOotwSSvaxdZfmL8BkDOXSJWpd8nnZkn7Obs/iM7vGvTcz37uqt1mGPAK/ugQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SJfLxzj4Aen0EOaZb5flGHyz7PKsrvFaIHE7OOYdv1o=; b=gwuVazyX2Chf/48jW3MQIYo814xW/YH9UI+FKyCfXG3Wp+/uvEqflWu83vvCrcCOiMmMXYFwDqz8IvMbPlpelzqifwljRROs0TV6ckNBFCFSlL3GBMnJdtQzaYhvAxEC5h6a3JivSu3Ki8vfUmCGY59xvV1PLIliNedwaPsv4I1fOAGmgedEupo/NU517Vk/AHb3mXPWs/KHEQ3T15HVeD88CYu0y2Gv5RXrBpmiTxRGQIsHhRcCXCAfZ7igE2aOhZd4OnWOSDfpmLFGvveCYqXGXntBXw01KYNmzIQnM2zfXG/SBrKCjBj+3+F7RYTdGncWG7/t8wyXFCIKk/BpYw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4c8d31de-539a-4252-f0a1-617b220eadc2@suse.com> Date: Mon, 7 Nov 2022 17:58:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Content-Language: en-US To: Roger Pau Monne Cc: Henry.Wang@arm.com, Paul Durrant , Wei Liu , Andrew Cooper , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20221104161815.38007-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20221104161815.38007-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0034.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9299:EE_ X-MS-Office365-Filtering-Correlation-Id: ec9e727b-0bda-4911-13eb-08dac0e13bde X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qAPSM/HpVfecvN+ehF9eQOU/wkK5SEKPFahLsy5VjbmtI1tk00kxTt47rPwMJTEyrNgu1xt4/fpIaLK/4sL3F9hLZ29ShTiSAHU9KN9o1Me3DvL7if9Hqh9fE9bTYU9G7sUgvzSYrDihEW1jdPcJtC2SEpIVp+xFHbTyZmQ6jecOIDy16SmnNVppfws5fpkLKeueoshq7jGPGoNeFQp6AN6hJzWTAAga9DukNhQDTqjadsGCCsbiSm8J8PTO/w70nf8k3DjPoB+tE0m5N5SQP+YB/xxvUCfzdqs931+njm8Ak/sygOKnT+a9sW6a2VwH7iKnyq09kwOEXkwPAIoPA8pP/ij5PhvyfKr/5v5d606hvBWl68JjszKHUOK8N8qE4PiA7mzO4OaOMyCtMkSshhsYME/sBot0BscilJWBCWK/bOuWzD7ls26siRbDct7PsRAAUzkZsgDWOfHIpxOos7tWjG56rZPaaNbZtEykLrnh/6c312wE3MJKBOJcTymApdYZLb1TGviZWF52XkuWHG5D/Msqxqu04MeVLGW9UO5Kz5+pEoPDktdo8k3b1qiYXiuc9cHXXjQu1X7RchtDt4ROjB0B68ZcYUP+2eITMjv6/6S5BxFc4QbTS16UwvPvDRzePbgQb/5UoFC7ajgk2d8cYfvjR18CJ9uSyYRw0jvvzbNVSbBUKMQimZ3gYF97itlBo7AyfxJ+Z3JgN9lMOT9vGpPSqHjQwo8pCPEAexSSQ81LlyHQ7wJvIFTo+00HeqMKC8vBt+1rF0oP9mWaEz2yG21HjF14rmkkEVVLAvc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(376002)(136003)(396003)(366004)(451199015)(2616005)(83380400001)(6506007)(186003)(31686004)(53546011)(6512007)(26005)(66476007)(6486002)(4326008)(66946007)(66556008)(478600001)(36756003)(8936002)(38100700002)(8676002)(2906002)(86362001)(31696002)(5660300002)(316002)(41300700001)(6916009)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDc4UmkyL2RFRGttUndqOXk2OTR2M0JXNkRrVnhZazZWUlhhSlkyakg3Qmdu?= =?utf-8?B?bGRwUGoxbnRKbS9VTDdYRUovdVI2ZU5XMHB5SzY5ZEM3NzNYSXlWR0pmNnF2?= =?utf-8?B?WURpOVV0TDRUeFRaODU4Zit0UWJXZVM4MG0rRzhYNGZhSGhxcFROZDRYRHZO?= =?utf-8?B?dmNLNWJrWmx2LzZFNXQ2L0tDSUNDMGF5T05mV08xMmR3aHhNWll3QWFHS0hP?= =?utf-8?B?Zm5nQ2R2VGk1UFQvUVBxNVRjMjB5NERtbjVBRG5yWHkrajQ4NlJHYituS3ZS?= =?utf-8?B?SDQ0czlOY3FvSExQL2JkeGR1RFNycnNYWjRCV212S1BGZFJMeVVTdUpMc3pk?= =?utf-8?B?TzY5MjQrNkVkVlZnK2ZmYkNHbmgwczNiaDJGNEhFZkZ1QjBOZjlHZThBNHpN?= =?utf-8?B?Rm9UeVpaY1V6eExMMk5qaUsycnlobU5ENmVBbTRZeVVNMGd6TnVTQmZBQThX?= =?utf-8?B?RXpxUnFjNHFESUJVZVJ0Vk5ZSEVSR2lvc3lRUHNnc3J0ZmZxVi82MTZEbStT?= =?utf-8?B?dmUxc1d4QjBCYlBOUnJkZEc0RU9zT2tpOEV5Wkh1VXVlNEQrSnUxZ2ZMR2NR?= =?utf-8?B?c29veGhxQW0wTnFha0VjYTJ6ZC95Vk1Eb2cwaitIOEdZU1pZb2xwK3VGSk93?= =?utf-8?B?MTRpQ01uWUwzdlhPbFVTQkxEdksvSlRwY0pFR3hiTTg4RHpoeHR1UnNyNGU0?= =?utf-8?B?d2x0NlUrR0IwYlNoY0FyVmM5aWNtMlpidHk4dUp4WkNxa1QwL0RlY214OEcx?= =?utf-8?B?eWwzdkE3QUNJaWlKelg3MEFRemlKaU9EOUlBZEhEcDU1Yis2OEU2ZFBRNWtJ?= =?utf-8?B?UGdYUndEbkpMa3ZvMGhDNXhvRnNLdURmRDZhcm9ES0lZVVp4QmlJRnBNK3VJ?= =?utf-8?B?Tk1EZndENmxYNVVMZlRTeHptM3h5T2lpam8xMVVwWHhOeTlNOWVVZE9neVNE?= =?utf-8?B?SEJETWF3VnBzSmU2WVMvcnJQdzR4a2tzS1R1cjFYa1VrK3RDL3R0ZE9EeHhS?= =?utf-8?B?UWh3ZmVYOGdmckJhWGRqNzdqdlBTVkwyNXFoVzVtS0hjZGxEa2VpdFd4WFJU?= =?utf-8?B?ME9YUTk5VE8rVmU1L25pYUU1aHZKeWdIcWxJVmF1S3RFZ1BkVG1RblI0S1Uv?= =?utf-8?B?OS9aUzVCb3paWUZKWUNsN3lMejhWYkVUQms0dXZJWk15N0lmb3VmNDVWWVV6?= =?utf-8?B?UTdrUEI2SVM3ZHRINnd5bDR1d0FJbE1WMXZjQUN4QlJFcHBJTzZCaVdqSTB4?= =?utf-8?B?TmZWMEVjcGhKeVpDQm1XeDdsdDJzMmpUejNHb1ZVaTBob0FjbkFydldTSnBH?= =?utf-8?B?aFVLMktGUlpLbmUrd0RKYXNtVHppRXIwbnJlZGFVM0p4WW1ZU0FmUnJHaHN4?= =?utf-8?B?SXFQRDFza2VLRDlPNU5mdHUwSnA5eUlMRG1lcWRLMnEyU0lMQXJmdDBncU5E?= =?utf-8?B?MzVGR05laGhEUEN3TXM4WG9SWE94RnZMS0tBc3JuUDIvMWwzNHlna3MvRzJ1?= =?utf-8?B?TzRyV01hN29vYzZta3RaMG9DU2dhVnJLZW1mMjZIdGdZMGRqNk5lSEpPTjNp?= =?utf-8?B?Y3ZuaUpCZlh2ci9zVjEzcHQvbnZmcHBhRHlSUjB3UzFxZ2wvQXl4eEJpb09y?= =?utf-8?B?QVllanpaeWh3WXJDR1ZtakI5NEQ1Wkw2WFR1cGx1ZGJod3BXVzlkenlwdXRF?= =?utf-8?B?L0w3VDh4OE9iWTU1NnBmeWJyaHVBUC9mcWtFbGw5NVdWZGZQWlFUUU1EZzhC?= =?utf-8?B?QzZOWmFmU1hUVnQ5QnBBTXpzL1dyMnpmdGEyRzRHTE5vZS80MWZPSS9OaUYz?= =?utf-8?B?L2J5a1I4YlZVNFpzYk9QM284Q0t1WmM2ZURLTmpvbmlGVTVkdFQ4dFpHREJN?= =?utf-8?B?UXFuZjR3aDhPd3psSi9RWXdoSmV2cjZUbTRPSUhDM2VpRjdVT2JjRy9uTjFR?= =?utf-8?B?MGh4WFduVDFnYmdKTkpHRGJZeDR6QmhycWFkOU9kSllzODF6eW1RaXRGZ3Rr?= =?utf-8?B?WTlEYXdFemRDQkZmdU0yUmNHeWpqcGRaYjZ0NnEvNklGbGZFNWRBeEdHd3Na?= =?utf-8?B?MEI1SVlMUFo5LzI0dWlCQ1lVaHpnZm5hanZKcTBvSC93TU1QSXNUWUt6dVRX?= =?utf-8?Q?wL9kFT/6FBlyWdNAzRuQ2TSV2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec9e727b-0bda-4911-13eb-08dac0e13bde X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 16:58:03.2962 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pcfYylEcPNYIsZBKlUJ96uKBdbm3gwOAtDd2yvzSbewQeKOoQaj3YJJLME19wg5EhDf3zsH8/PrJmMAqj+7RZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9299 On 04.11.2022 17:18, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/viridian/viridian.c > +++ b/xen/arch/x86/hvm/viridian/viridian.c > @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, > res->a = CPUID4A_RELAX_TIMER_INT; > if ( viridian_feature_mask(d) & HVMPV_hcall_remote_tlb_flush ) > res->a |= CPUID4A_HCALL_REMOTE_TLB_FLUSH; > - if ( !cpu_has_vmx_apic_reg_virt ) > + if ( !has_assisted_xapic(d) ) > res->a |= CPUID4A_MSR_BASED_APIC; Isn't this too restrictive when considering x2APIC? IOW is there anything wrong with leaving this as is? > @@ -3432,6 +3436,10 @@ void vmx_vlapic_msr_changed(struct vcpu *v) > vmx_set_msr_intercept(v, MSR_X2APIC_PPR, VMX_MSR_R); > vmx_set_msr_intercept(v, MSR_X2APIC_TMICT, VMX_MSR_R); > vmx_set_msr_intercept(v, MSR_X2APIC_TMCCT, VMX_MSR_R); > + > + v->arch.hvm.vmx.secondary_exec_control |= > + SECONDARY_EXEC_APIC_REGISTER_VIRT; > + > } Nit: stray trailing blank line inside the block. Everything else looks plausible to me, but from prior discussion I wonder whether the result isn't still going to be too coarse grained for Andrew's taste. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 07 17:09:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 17:09:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439529.693543 (Exim 4.92) (envelope-from ) id 1os5cy-000063-VX; Mon, 07 Nov 2022 17:09:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439529.693543; Mon, 07 Nov 2022 17:09:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os5cy-00005w-Sn; Mon, 07 Nov 2022 17:09:40 +0000 Received: by outflank-mailman (input) for mailman id 439529; Mon, 07 Nov 2022 17:09:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os5cy-00005m-AB; Mon, 07 Nov 2022 17:09:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os5cy-0004Eq-5I; Mon, 07 Nov 2022 17:09:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os5cx-00086Q-Rp; Mon, 07 Nov 2022 17:09:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1os5cx-0000qh-RL; Mon, 07 Nov 2022 17:09:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ciJocILdJYeh+Lm3lIcq5HdwcO31hdj5C/VJiR/ItI4=; b=60SZ7KNzvwvFXO2m+ayrMvo8P7 vh+huLNkZAabk8IS90IXSRHZWAXozacmZHn+ndKvKrMhVc5PfLn6VW2/d7A9o+svH/hvmSqco1UjO APDP3LnQ3DOm7h71BiIX1MDsZimbuafn3fO9N+HsJ9BdLqoUhOp39r0RvZYzp4jlBNBs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174655: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-5.4:test-armhf-armhf-libvirt::broken:regression linux-5.4:test-armhf-armhf-xl-arndale::broken:regression linux-5.4:test-armhf-armhf-xl-credit1::broken:regression linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm::broken:regression linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-xl-arndale:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-libvirt:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-xsm:xen-boot:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start.2:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:redhat-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a0d9384967214783a92973c920092b7251c03e57 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Mon, 07 Nov 2022 17:09:39 +0000 flight 174655 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174655/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-xl-arndale broken test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm broken in 174650 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 5 host-install(5) broken in 174650 pass in 174655 test-armhf-armhf-xl-arndale 5 host-install(5) broken pass in 174650 test-armhf-armhf-xl-credit1 5 host-install(5) broken pass in 174650 test-armhf-armhf-libvirt 5 host-install(5) broken pass in 174650 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail in 174638 pass in 174655 test-amd64-i386-pair 11 xen-install/dst_host fail in 174638 pass in 174655 test-amd64-i386-libvirt-xsm 8 xen-boot fail in 174638 pass in 174655 test-armhf-armhf-xl-credit2 14 guest-start fail in 174638 pass in 174655 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174638 pass in 174655 test-armhf-armhf-xl-rtds 14 guest-start fail in 174638 pass in 174655 test-armhf-armhf-libvirt-raw 13 guest-start fail in 174638 pass in 174655 test-armhf-armhf-xl-credit1 19 guest-start.2 fail in 174646 pass in 174638 test-armhf-armhf-libvirt-qcow2 13 guest-start fail in 174646 pass in 174650 test-amd64-i386-qemuu-rhel6hvm-amd 12 redhat-install fail in 174646 pass in 174655 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 174646 pass in 174655 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 174646 pass in 174655 test-armhf-armhf-xl-credit1 14 guest-start fail in 174650 pass in 174646 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail in 174650 pass in 174655 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 174650 pass in 174655 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail pass in 174650 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 174646 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 174646 never pass test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 174650 like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail in 174650 like 174540 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 174650 never pass test-armhf-armhf-libvirt 15 migrate-support-check fail in 174650 never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 174650 never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 174650 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux a0d9384967214783a92973c920092b7251c03e57 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 9 days Failing since 174575 2022-11-01 18:42:39 Z 5 days 11 attempts Testing same since 174608 2022-11-03 19:46:50 Z 3 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anssi Hannula Arnaldo Carvalho de Melo Biju Das Brian Foster Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Darrick J. Wong Darrick J. Wong Dave Chinner David S. Miller Demi Marie Obenour Dongliang Mu Eric Dumazet Florian Fainelli Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hannu Hartikainen Hans Verkuil Heiko Carstens Helge Deller Hyong Youb Kim Hyunwoo Kim Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jeff Vanhoof Jens Glathe Jimmy Assarsson Johan Hovold Jon Hunter Jon Maloy Jonathan Cameron Josh Poimboeuf Juergen Gross Justin Chen Konrad Jankowski Kuogee Hsieh Leon Romanovsky Linux Kernel Functional Testing Luiz Capitulino M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Michal Jaron Mike Kravetz Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Paolo Abeni Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rik van Riel Saeed Mahameed Sakari Ailus Sasha Levin Shreeya Patel Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Thinh Nguyen Tom Lendacky Tony O'Brien Ulf Hansson Vasily Gorbik Vineet Gupta Vladimir Oltean Wei Yongjun Xin Long Yang Yingliang Yongqin Liu Zhang Changzhong Zhengchao Shao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale broken test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt broken test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt broken broken-job test-armhf-armhf-xl-arndale broken broken-job test-armhf-armhf-xl-credit1 broken broken-step test-armhf-armhf-xl-arndale host-install(5) broken-step test-armhf-armhf-xl-credit1 host-install(5) broken-step test-armhf-armhf-libvirt host-install(5) broken-job test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm broken Not pushing. (No revision log; it would be 2244 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Nov 07 17:25:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 17:25:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439540.693554 (Exim 4.92) (envelope-from ) id 1os5rc-0002iu-D1; Mon, 07 Nov 2022 17:24:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439540.693554; Mon, 07 Nov 2022 17:24:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os5rc-0002in-AR; Mon, 07 Nov 2022 17:24:48 +0000 Received: by outflank-mailman (input) for mailman id 439540; Mon, 07 Nov 2022 17:24:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os5ra-0002ih-Oo for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 17:24:46 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 10b7ea26-5ec1-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 18:24:44 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10b7ea26-5ec1-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667841884; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=16IPYLBbQfIYc3xLH61tqI20N+/WsksmfwDZh78tSvE=; b=dCY2wV1iqlzfPDBXa/UkMIdd3xG9FHWGNvsuGvWMA19LKmT8J2SP+Mvw bzFKA0xzzlrK/rfZc2HqTH9Ysp9vBVQYfURZ/eyqVbt4+qiP/CNkhbClO sWO4Y37UrnbRqR/CDq25xDL11cyt2bYe3wcOIK3b3GFwH0eS5nb0Rod5v 0=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84342471 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:fYMAGaIKoiE4shmLFE+R2JUlxSXFcZb7ZxGr2PjKsXjdYENSgTAHy mRKWTjTM6qJYDajKdhyPdux8UxV7JKAxoBgTwVlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wRhPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c56KHlW1 e4YBgkNdzG+jey44a2ybbJF05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUozWHpkPwhnBz o7A10rkORYACdiC8H2u1GyBtu2Qw3zQeqtHQdVU8dY12QbOlwT/EiY+Sl+TsfS/zEmkVLp3C 0ES4DtokqE0+2SiVNy7VBq9yFaGsQQbQMF4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhqgGqy89G3of3JPdClbOHFCHVBtD8TfTJ8bgzvXVvZxEICMjsTUJDv+z RGVpQ9lruBG5SIU7JmT8VfCijOqg5HGSA8p+wnaNl6YAhNFiJ2NPNLxtwWChRpUBMPAFwTa4 iBY8ySLxLpWZaxhghBhVwnk8FuBw/+eeAPRjld0d3XK32T8oiXzFWy8DdwXGauIDirmUWW4C KMwkVkLjHO2AJdNRf4fXm5JI552pZUM7Py8Ph0UB/IXCnSLSCeJ/Tt1eWmb1H33nU4nnMkXY MnFLpnxXChEVfk6k1JaotvxNpdymEgDKZ77H8inn3xLL5LDDJJqdVv1GATXNb1ohE91iA7U7 8xeJ6O3J+Z3CYXDj+i+2dB7EG3m2lBiX8mo+p0PLL/cSuekcUl4Y8LsLXoaU9QNt8xoei3gp xlRhmcwJILDuED6 IronPort-HdrOrdr: A9a23:ogXfgK/UiyG1VpMcfm5uk+DaI+orL9Y04lQ7vn2YSXRuE/Bws/ re+8jztCWE7Ar5N0tNpTntAsa9qDbnhPhICOoqTNKftWvdyQiVxehZhOOIqVDd8m/Fh4xgPM 9bAtFD4bbLbWSS4/yV3DWF X-IronPort-AV: E=Sophos;i="5.96,145,1665460800"; d="scan'208";a="84342471" Date: Mon, 7 Nov 2022 17:24:37 +0000 From: Anthony PERARD To: Juergen Gross CC: , Wei Liu , Henry Wang Subject: Re: [PATCH-for-4.17] tools/hotplug: fix systemd unit dependencies Message-ID: References: <20221106061517.15602-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221106061517.15602-1-jgross@suse.com> On Sun, Nov 06, 2022 at 07:15:17AM +0100, Juergen Gross wrote: > Commit 1283af6465cd ("tools/xenstore: remove XEN_LIB_STORED and > XENSTORED_ROOTDIR") removed the systemd file var-lib-xenstored.mount > without removing dependencies to this file. > > Fixes: 1283af6465cd ("tools/xenstore: remove XEN_LIB_STORED and XENSTORED_ROOTDIR") > Signed-off-by: Juergen Gross Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Nov 07 17:37:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 17:37:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439546.693566 (Exim 4.92) (envelope-from ) id 1os63i-0004jn-HE; Mon, 07 Nov 2022 17:37:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439546.693566; Mon, 07 Nov 2022 17:37:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os63i-0004jg-D3; Mon, 07 Nov 2022 17:37:18 +0000 Received: by outflank-mailman (input) for mailman id 439546; Mon, 07 Nov 2022 17:37:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os63h-0004ja-6o for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 17:37:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os63g-0004qw-MY; Mon, 07 Nov 2022 17:37:16 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1os63g-0001ek-FP; Mon, 07 Nov 2022 17:37:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=G8z0oZidGxbHPdiNDAYGslHRRuJCC1UyB5cEm7cfpRo=; b=RJ1TAGs5uqgcSAnSKQy75kM8q+ CtGGA77TMSag74HOgI+in7CdwEDOALxMXl0VhUprkihIAgM2FPXGgv4SZMbKScJ19lVdImZLgrr9X LxU8jjq/ymSCD7uKMtrxMV7uMyyGwItqKqJz7YZ/7Iw/3dqraXqUTuHumOCx+4V24fMA=; Message-ID: <5ec85781-bb42-fdd7-22f1-630fa8eb08ce@xen.org> Date: Mon, 7 Nov 2022 17:37:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32 Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, burzalodowa@gmail.com References: <20221031151326.22634-1-ayankuma@amd.com> <20221031151326.22634-5-ayankuma@amd.com> <5d369b95-f412-67b2-5c34-3cd317128ec3@xen.org> <8bb1c421-2dc5-cdbc-94f7-6ea09f2d64fc@xen.org> <00e4eb67-2b47-346a-f5cf-98b73c8ba218@amd.com> From: Julien Grall In-Reply-To: <00e4eb67-2b47-346a-f5cf-98b73c8ba218@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Ayan, On 07/11/2022 14:00, Ayan Kumar Halder wrote: > > On 07/11/2022 11:54, Julien Grall wrote: >> Hi Ayan, > > Hi Julien, > > I need one clarification. > >> >> On 07/11/2022 11:33, Ayan Kumar Halder wrote: >>> >>> On 06/11/2022 18:04, Julien Grall wrote: >>>> Hi Ayan, >>> >>> Hi Julien, >>> >>> I need a clarification. >>> >>>> >>>> In the title you are using AArch32 but below you are using... >>>> >>>> On 31/10/2022 15:13, Ayan Kumar Halder wrote: >>>>> v->arch.vmpidr is assigned to uint64_t variable. This is to enable >>>>> left shifts >>>>> for Aarch32 so that one can extract affinity bits. >>>> >>>> ... Aarch32. The naming also seem to be inconsistent across your >>>> series. AFAIU, it should be AArch32. So please look at all your >>>> commits and make sure you use the same everywhere. >>> Ack >>>> >>>>> This is then assigned to 'typer' so that the affinity bits form the >>>>> upper 32 bits. >>>>> >>>>> Refer Arm IHI 0069H ID020922, >>>>> The upper 32 bits of GICR_TYPER represent the affinity >>>>> whereas the lower 32 bits represent the other bits (eg processor >>>>> number, etc). >>>>> >>>>> Signed-off-by: Ayan Kumar Halder >>>>> --- >>>>> >>>>> Changes from :- >>>>> 1. v1 - Assigned v->arch.vmpidr to "uint64_t vmpdir". Then, we can use >>>>> MPIDR_AFFINITY_LEVEL macros to extract the affinity value. >>>>> >>>>>   xen/arch/arm/vgic-v3.c | 10 ++++++---- >>>>>   1 file changed, 6 insertions(+), 4 deletions(-) >>>>> >>>>> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c >>>>> index 3f4509dcd3..e5e6f2c573 100644 >>>>> --- a/xen/arch/arm/vgic-v3.c >>>>> +++ b/xen/arch/arm/vgic-v3.c >>>>> @@ -191,13 +191,15 @@ static int >>>>> __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info, >>>>>       case VREG64(GICR_TYPER): >>>>>       { >>>>>           uint64_t typer, aff; >>>>> +        uint64_t vmpidr = v->arch.vmpidr; >>>>>             if ( !vgic_reg64_check_access(dabt) ) goto bad_width; >>>>> -        aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 | >>>>> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 | >>>>> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 | >>>>> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32); >>>>> +        aff = (MPIDR_AFFINITY_LEVEL(vmpidr, 3) << 56 | >>>> >>>> Shouldn't we #ifdef this level for 32-bit? Or maybe check if the >>>> domain is 64-bit so we are using consistently regardless of the >>>> hypervisor bitness. >>> >>> We have typecasted "v->arch.vmpidr" (which is 32bit for AArch32 and >>> 64bit for AArch64)  to vmpidr (uint64_t). >>> >>> So, we don't need to have any #ifdef for AArch32 or AArch64. >> >> This is not related to the typecast. This is more that fact that >> affinity level 3 doesn't exist for 32-bit guest. For instance vpsci.c >> will protect level 3 with an #ifdef. > > Just to make sure, I understand you. You are suggesting this ? Yes with... > > --- a/xen/arch/arm/vgic-v3.c > +++ b/xen/arch/arm/vgic-v3.c > @@ -191,13 +191,15 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct > vcpu *v, mmio_info_t *info, >      case VREG64(GICR_TYPER): >      { >          uint64_t typer, aff; > +        uint64_t vmpidr = v->arch.vmpidr; > >          if ( !vgic_reg64_check_access(dabt) ) goto bad_width; > -        aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 | > -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 | > -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 | > -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32); > +        aff = ( > +#ifdef CONFIG_ARM_64 > +               MPIDR_AFFINITY_LEVEL(vmpidr, 3) << 56 | > +#endif > +               MPIDR_AFFINITY_LEVEL(vmpidr, 2) << 48 | > +               MPIDR_AFFINITY_LEVEL(vmpidr, 1) << 40 | > +               MPIDR_AFFINITY_LEVEL(vmpidr, 0) << 32); >          typer = aff; > + ... this spurious change dropped. >          /* We use the VCPU ID as the redistributor ID in bits[23:8] */ >          typer |= v->vcpu_id << GICR_TYPER_PROC_NUM_SHIFT; > > If so, then we can drop the patch "[XEN v2 02/12] xen/Arm: GICv3: Move > the macros to compute the affnity level to arm64/arm32" > > Also, we should do the following change :- Yes but in a separate patch (we should keep vGIC and GIC changes separate). > > ayankuma@xcbayankuma41x:/scratch/ayankuma/r52_xen/xen-pristine$ git diff > xen/arch/arm/gic-v3.c > diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c > index d8ce0f46c6..e7d5338152 100644 > --- a/xen/arch/arm/gic-v3.c > +++ b/xen/arch/arm/gic-v3.c > @@ -527,7 +527,10 @@ static void gicv3_set_pending_state(struct irq_desc > *irqd, bool pending) >  static inline uint64_t gicv3_mpidr_to_affinity(int cpu) >  { >       uint64_t mpidr = cpu_logical_map(cpu); > -     return (MPIDR_AFFINITY_LEVEL(mpidr, 3) << 32 | > +     return ( > +#ifdef CONFIG_ARM_64 > +             MPIDR_AFFINITY_LEVEL(mpidr, 3) << 32 | > +#endif >               MPIDR_AFFINITY_LEVEL(mpidr, 2) << 16 | >               MPIDR_AFFINITY_LEVEL(mpidr, 1) << 8  | >               MPIDR_AFFINITY_LEVEL(mpidr, 0)); > @@ -720,7 +723,10 @@ static int __init gicv3_populate_rdist(void) >       * Convert affinity to a 32bit value that can be matched to > GICR_TYPER >       * bits [63:32] >       */ > -    aff = (MPIDR_AFFINITY_LEVEL(mpidr, 3) << 24 | > +    aff = ( > +#ifdef CONFIG_ARM_64 > +           MPIDR_AFFINITY_LEVEL(mpidr, 3) << 24 | > +#endif >             MPIDR_AFFINITY_LEVEL(mpidr, 2) << 16 | >             MPIDR_AFFINITY_LEVEL(mpidr, 1) << 8 | >             MPIDR_AFFINITY_LEVEL(mpidr, 0)); > @@ -972,7 +978,10 @@ static void gicv3_send_sgi_list(enum gic_sgi sgi, > const cpumask_t *cpumask) >           * Prepare affinity path of the cluster for which SGI is > generated >           * along with SGI number >           */ > -        val = (MPIDR_AFFINITY_LEVEL(cluster_id, 3) << 48  | > +        val = ( > +#ifdef CONFIG_ARM_64 > +               MPIDR_AFFINITY_LEVEL(cluster_id, 3) << 48  | > +#endif >                 MPIDR_AFFINITY_LEVEL(cluster_id, 2) << 32  | >                 sgi << 24                                  | >                 MPIDR_AFFINITY_LEVEL(cluster_id, 1) << 16  | > > - Ayan > >> >> Cheers, >> -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 18:06:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 18:06:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439556.693576 (Exim 4.92) (envelope-from ) id 1os6W2-0000Gg-OG; Mon, 07 Nov 2022 18:06:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439556.693576; Mon, 07 Nov 2022 18:06:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os6W2-0000GZ-Lj; Mon, 07 Nov 2022 18:06:34 +0000 Received: by outflank-mailman (input) for mailman id 439556; Mon, 07 Nov 2022 18:06:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os6W1-0000GT-39 for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 18:06:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os6W1-0005Zk-29 for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 18:06:33 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1os6W0-0002iJ-R0; Mon, 07 Nov 2022 18:06:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=TEFbjhQ7r78CCH9agleS2kBNdvGVrpH1qsQR6QEJJbw=; b=yhE0oCIcShW/J9HR5K7lWh/nFY KOdzhvQ+7Cps/eHsJY+GBHNmUwou5EHe4+nTXZJjG8tm9cXQ+HEFdQrISoLQvdlSl+kD9ecbwTXdE zMa25K1PVWdHhES038s6c5cv5ea9lhKE71b0hhwABUwtk5HYKlhwXTWN428cGN29PCwE=; Message-ID: <74b1c6af-d6de-2728-9d59-2d561a521793@xen.org> Date: Mon, 7 Nov 2022 18:06:30 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write Content-Language: en-US To: Ayan Kumar Halder , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com References: <20221104162355.23369-1-ayan.kumar.halder@amd.com> <062c9507-7744-0742-effb-76d2f1222a27@xen.org> <33a2d125-b7f2-3637-9dab-6b7d616fd4ff@amd.com> <36e84512-9b44-303e-2834-5aafe9c6cc15@amd.com> From: Julien Grall In-Reply-To: <36e84512-9b44-303e-2834-5aafe9c6cc15@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 07/11/2022 12:49, Ayan Kumar Halder wrote: > > On 07/11/2022 10:44, Julien Grall wrote: >> Hi Ayan, > Hi Julien, >> >> On 07/11/2022 10:36, Ayan Kumar Halder wrote: >>> >>> On 06/11/2022 17:54, Julien Grall wrote: >>>> Hi Ayan, >>> >>> Hi Julien, >>> >>> I need some clarification. >>> >>>> >>>> To me the title and the explaination below suggests... >>>> >>>> On 04/11/2022 16:23, Ayan Kumar Halder wrote: >>>>> From: Ayan Kumar Halder >>>>> >>>>> Refer ARM DDI 0487I.a ID081822, B2.2.1 >>>>> "Requirements for single-copy atomicity >>>>> >>>>> - A read that is generated by a load instruction that loads a single >>>>> general-purpose register and is aligned to the size of the read in the >>>>> instruction is single-copy atomic. >>>>> >>>>> -A write that is generated by a store instruction that stores a single >>>>> general-purpose register and is aligned to the size of the write in >>>>> the >>>>> instruction is single-copy atomic" >>>>> >>>>> On AArch32, the alignment check is enabled at boot time by setting >>>>> HSCTLR.A bit. >>>>> ("HSCTLR, Hyp System Control Register"). >>>>> However in AArch64, alignment check is not enabled at boot time. >>>> >>>> ... you want to enable the alignment check on AArch64 always. >>> >>> I want to enable alignment check *only* for atomic access. >>> >>> May be I should remove this line --> "However in AArch64, alignment >>> check is not enabled at boot time.". >>> >>>> However, this is not possible to do because memcpy() is using >>>> unaligned access. >>> This is a non atomic access. So the commit does not apply here. >> >> Right, but your commit message refers to the alignment check on arm32. >> You wrote too much for someone to wonder but not enough to explain why >> we can't enable the alignment check on arm64. >> >>>> >>>> I think the commit message/title should clarify that the check is >>>> *only* done during debug build. IOW, there are no enforcement in >>>> producation build. >>> >>> AFAICS read_atomic()/write_atomic() is enabled during non debug >>> builds (ie CONFIG_DEBUG=n) as well. >> >> My point was that ASSERT() is a NOP in production build. So you >> effectively the enforcement happens only in debug build. >> >> IOW, unless you test exhaustively with a debug build, you may never >> notice that the access was not atomic. > > This makes sense. > > Does the following commit message look better ? > > xen/Arm: Enforce alignment check for atomic read/write title: xen/arm: Enforce alignment check in debug build for {read, write}_atomic > > Refer ARM DDI 0487I.a ID081822, B2.2.1 > "Requirements for single-copy atomicity > > - A read that is generated by a load instruction that loads a single > general-purpose register and is aligned to the size of the read in the > instruction is single-copy atomic. > > -A write that is generated by a store instruction that stores a single > general-purpose register and is aligned to the size of the write in the > instruction is single-copy atomic" > > Thus, one needs to check for alignment when performing atomic operations. > However, as ASSERT() are disabled in production builds, so one needs to This seems to be a bit out of context because you don't really explain that ASSERT() would be used. Also... > run the debug builds to catch any unaligned access during atomic > operations. > Enforcing alignment checks during production build has quite a high > overhead. > > On AArch32, the alignment check is enabled at boot time by setting > HSCTLR.A bit. > ("HSCTLR, Hyp System Control Register"). > However, on AArch64, memcpy()/memset() may be used on 64bit unaligned > addresses. > Thus, one does not wish to enable alignment check at boot time. ... to me this paragraph should be first because this explained why we can't check in production. So how about the following commit message: " xen/arm: Enforce alignment check in debug build for {read, write}_atomic Xen provides helper to atomically read/write memory (see {read, write}_atomic()). Those helpers can only work if the address is aligned to the size of the access (see B2.2.1 ARM DDI 08476I.a). On Arm32, the alignment is already enforced by the processor because HSCTLR.A bit is set (it enforce alignment for every access). For Arm64, this bit is not set because memcpy()/memset() can use unaligned access for performance reason (the implementation is taken from the Cortex library). To avoid any overhead in production build, the alignment will only be checked using an ASSERT. Note that it might be possible to do it in production build using the acquire/exclusive version of load/store. But this is left to a follow-up (if wanted). " While trying to find a justification for the debug version. I was wondering whether we could actually use the acquire or exclusive version. I am not entirely sure about the overhead. > > Signed-off-by: Ayan Kumar Halder > Reviewed-by: Michal Orzel > Reviewed-by: Bertrand Marquis > > I think I can keep R-b as there is no code change ? My signed-off-by will need to be added for the commit message I proposed above. So I would like Bertrand/Michal to confirm they are happy with it (I don't usually add my reviewed-by/acked-by for patch where my signed-off-by is added). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 18:07:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 18:07:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439561.693588 (Exim 4.92) (envelope-from ) id 1os6XA-0000wr-2I; Mon, 07 Nov 2022 18:07:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439561.693588; Mon, 07 Nov 2022 18:07:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os6X9-0000wk-Ut; Mon, 07 Nov 2022 18:07:43 +0000 Received: by outflank-mailman (input) for mailman id 439561; Mon, 07 Nov 2022 18:07:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os6X8-0000wY-PK; Mon, 07 Nov 2022 18:07:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os6X8-0005aj-OY; Mon, 07 Nov 2022 18:07:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os6X8-00017E-9t; Mon, 07 Nov 2022 18:07:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1os6X8-0000bH-9S; Mon, 07 Nov 2022 18:07:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=erAIId0CHOimMxNrC0HqPu2zrBjjFc9Z8rTKvMjdpRo=; b=h4HfZB5/AEul5bKic2YaCUznFT 0QkWOJ/a/qqSDmQwPDrZyRvtWh6kx1wAUxDBA9i/gm72fbotQ/Fw7bgiPpZhatjLxfEE7UT79hLPF XRoF0dyRzmAItANoibeZYNhkesCTP9E+TIn6gDcA7YFU52O3yDwlgrW/3Si1/6OufY3E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174658: all pass - PUSHED X-Osstest-Versions-This: ovmf=239bcf78053f4581cc3468ab961f9d37e859c7d9 X-Osstest-Versions-That: ovmf=82e70d9ac0aabf48a0cbda3c373e94ef22413e49 From: osstest service owner Date: Mon, 07 Nov 2022 18:07:42 +0000 flight 174658 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174658/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 239bcf78053f4581cc3468ab961f9d37e859c7d9 baseline version: ovmf 82e70d9ac0aabf48a0cbda3c373e94ef22413e49 Last test of basis 174657 2022-11-07 12:12:01 Z 0 days Testing same since 174658 2022-11-07 16:11:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 82e70d9ac0..239bcf7805 239bcf78053f4581cc3468ab961f9d37e859c7d9 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Nov 07 18:24:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 18:24:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439570.693599 (Exim 4.92) (envelope-from ) id 1os6n6-0003Xq-DI; Mon, 07 Nov 2022 18:24:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439570.693599; Mon, 07 Nov 2022 18:24:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os6n6-0003Xj-9w; Mon, 07 Nov 2022 18:24:12 +0000 Received: by outflank-mailman (input) for mailman id 439570; Mon, 07 Nov 2022 18:24:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os6n5-0003Xd-Kp for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 18:24:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os6n5-00061X-BV; Mon, 07 Nov 2022 18:24:11 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1os6n5-0003N3-4o; Mon, 07 Nov 2022 18:24:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=GjfLyWq2gROIyyNMG0suSFnhdt3Q6QfuNH1jlqrNBM0=; b=KsJKzhmYjYhorvSv2byFNtR3Cu uSVdjdJqohk+7jfZTxXxvRKfiqmuCOjQdH7Hq+6kK+hB/iHRWJHFvULIhZ0Ryt68hjw2SvHym3N3A BfAhI4jqIh0BhIhndTW2RKoIV5ZK8ZeBGqkRBFskwSu+S8zbXbCVKeGOA8ZWPUbNnww0=; Message-ID: <7cf84a7c-9730-fb0e-a9d7-e92d09ecdd49@xen.org> Date: Mon, 7 Nov 2022 18:24:08 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 02/12] xen/arm: add cache coloring initialization for domains Content-Language: en-US To: Carlo Nonato , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Marco Solieri References: <20220826125111.152261-1-carlo.nonato@minervasys.tech> <20220826125111.152261-3-carlo.nonato@minervasys.tech> <308a7afa-a3c9-b500-06c1-3d4cbe8bbf65@xen.org> <9a996e9d-d9ce-f562-122d-1e661d25614c@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/11/2022 13:44, Carlo Nonato wrote: > Hi Julien, Hi Carlo, > On Tue, Oct 25, 2022 at 1:15 PM Julien Grall wrote: >> On 25/10/2022 11:53, Carlo Nonato wrote: >>> Hi Julien, >>> >>> On Fri, Oct 21, 2022 at 8:02 PM Julien Grall wrote: >>>> >>>> Hi Carlo, >>>> >>>> On 26/08/2022 13:51, Carlo Nonato wrote: >>>>> This commit adds array pointers to domains as well as to the hypercall >>>>> and configuration structure employed in domain creation. The latter is used >>>>> both by the toolstack and by Xen itself to pass configuration data to the >>>>> domain creation function, so the XEN_GUEST_HANDLE macro must be adopted to be >>>>> able to access guest memory in the first case. This implies special care for >>>>> the copy of the configuration data into the domain data, meaning that a >>>>> discrimination variable for the two possible code paths (coming from Xen or >>>>> from the toolstack) is needed. >>>> >>>> So this means that a toolstack could set from_guest. I know the >>>> toolstack is trusted... However, we should try to limit when the trust >>>> when this is possible. >>>> >>>> In this case, I would consider to modify the prototype of >>>> domain_create() to pass internal information. >>> >>> Doing as you said isn't a bit too invasive? I should also change all the call >>> sites of domain_create() and this means x86 too. >> >> Yes there will be a few calls to modify. But this is better than hacking >> the hypercall interface to cater for internal use. >> >>> Isn't there an easier way to spot a guest address? Maybe just looking at the >>> address value... >> >> HVM/Arm guest have a separate address space. So it is not possible to >> differentiate between guest vs hypervisor address. >> >>> Or maybe adding an internal flag to the do_domctl() path. >> IIUC, this flag would indicate whether the XEN_GUEST_HANDLE() is an >> hypervisor or guest address. Is that correct? >> >> If so, I dislike it. I am not sure what the other maintainers think, but >> personally updating domain_create() is my preferred way. > > Sorry to bother you again on this topic, but I thought of a way to get rid of > the "from_guest" field which I hope is simple enough to convince you. > I can call copy_from_guest() *only* in domctl.c, overwriting the colors > pointer with a new, Xen allocated, array. > This lets me simplify the logic in domain_coloring_init() since all the arrays > coming to it via the domainconfig struct are allocated in Xen memory only. > It's still a bit of a hack since I'm using the XEN_GUEST_HANDLE as a normal > Xen pointer, but it's by far less hacky than before and doesn't have the trust > problem. You don't have the trust problem but you are still mixing guest handle and xen pointer. I continue dislike this because this a gross hack that may save you some effort today but will be a nightmare to review/use/maintain (the developer will have to remember whether the field contain a guest address or xen address). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 18:33:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 18:33:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439577.693609 (Exim 4.92) (envelope-from ) id 1os6vl-0005Kt-B5; Mon, 07 Nov 2022 18:33:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439577.693609; Mon, 07 Nov 2022 18:33:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os6vl-0005Km-8S; Mon, 07 Nov 2022 18:33:09 +0000 Received: by outflank-mailman (input) for mailman id 439577; Mon, 07 Nov 2022 18:33:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os6vk-0005Kg-CW for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 18:33:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os6vj-0006Bq-MB; Mon, 07 Nov 2022 18:33:07 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1os6vj-0003et-Fi; Mon, 07 Nov 2022 18:33:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Y96JbSM4Gk15Hb6YVWWY5bxC6V80qkCX+2mMpd9aWiw=; b=a7Kbs0Om37DK9Jx3aTJNt0aaJ1 fH/mQteTLZFoCEdP6slKTRYGTly1ynxGutttEjzfyhKp0EDAkGIU0U24L/ogAXd2Mb/+iS9Nv75rk RqFd+u3nbbhJ/GynHXIjOE/BpUM+8D6xrbp/Hg29lFsSYss1bC/5//E50PDTb8h+dero=; Message-ID: <5fe0a47c-66ca-9e0a-4742-1663c7761256@xen.org> Date: Mon, 7 Nov 2022 18:33:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 06/20] tools/xenstore: remove all watches when a domain has stopped Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-7-jgross@suse.com> <67cb3364-d5c1-28d8-4cda-8933de5cb9f7@xen.org> <703aa58c-1b7c-abb6-995d-5c5cdfcde878@suse.com> From: Julien Grall In-Reply-To: <703aa58c-1b7c-abb6-995d-5c5cdfcde878@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07/11/2022 07:54, Juergen Gross wrote: > On 06.11.22 22:18, Julien Grall wrote: >> Hi Juergen, >> >> On 01/11/2022 15:28, Juergen Gross wrote: >>> When a domain has been recognized to have stopped, remove all its >>> registered watches. This avoids sending watch events to the dead domain >>> when all the nodes related to it are being removed by the Xen tools. >> >>  From my understanding, shutdown doesn't mean dead. It may be used >> during migration (or snapshotting), where we don't want to touch the >> state in case of a cancellation (or resume). >> >> For instance, see the command XS_RESUME which will clear >> domain->shutdown. > > Oh, good catch! > > I need to additionally check the "shutdown reason". I can remove the > watches only in case of the reason not having been "suspend". This is quite fragile because we may add new shutdown code in the future that could resume. I think it would be better to only delete the watches if the domain is effectively dying (I don't think it can come back from that state) Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 18:37:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 18:37:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439583.693621 (Exim 4.92) (envelope-from ) id 1os708-0006Bc-Uj; Mon, 07 Nov 2022 18:37:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439583.693621; Mon, 07 Nov 2022 18:37:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os708-0006BV-Qp; Mon, 07 Nov 2022 18:37:40 +0000 Received: by outflank-mailman (input) for mailman id 439583; Mon, 07 Nov 2022 18:37:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os708-0006BP-1J for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 18:37:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os707-0006Gy-CA; Mon, 07 Nov 2022 18:37:39 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1os707-0003qC-5g; Mon, 07 Nov 2022 18:37:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ZVfn2sssgDLwM/VWvtxzS8lRIIOzLXmJ3h53DFre4wY=; b=Z4qGMeqOQO9RmzUQliUNqyZ5LZ Ml/STwvHg363naLFEXhe/dr0YKe/H0bIT+oW40OptPqYF+vWjPLnmKsqxVbsBypAX2i06sDDosTRy 5yoWytDTrTdNoOVvTrSabKRtZx8LXKgkop7ys22sTVdMZy4BZppkCqswjKPkC/RIfHyg=; Message-ID: Date: Mon, 7 Nov 2022 18:37:37 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 13/20] tools/xenstore: don't allow creating too many nodes in a transaction Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-14-jgross@suse.com> <32f61945-08fa-f095-02c4-9d52b66b6c04@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/11/2022 08:34, Juergen Gross wrote: > On 06.11.22 23:00, Julien Grall wrote: >> Hi Juergen, >> >> On 01/11/2022 15:28, Juergen Gross wrote: >>> The accounting for the number of nodes of a domain in an active >>> transaction is not working correctly, as it allows to create arbitrary >>> number of nodes. The transaction will finally fail due to exceeding >>> the number of nodes quota, but before closing the transaction an >>> unprivileged guest could cause Xenstore to use a lot of memory. >> >> I have already made some of comments on the security ML when this was >> initially set. The arguments still don't sound right to me. >> >> For a first, since XSA-326, we have a cap in place for the memory a >> domain can consume. So this surely can't be a "lot of memory". >> Otherwise we are saying that our limit (there are other way to hit it) >> were wrong... > > Yeah, maybe I should rework the commit message. > > The reason I still want to keep the patch is that in a transaction > without any > conflicts and without hitting any transaction specific limits (number of > nodes > accessed), the errors returned due to a single operation should be the > same as > with the same operation performed outside a transaction. This seems to be a very niche use case. So it is not clear to me why this matter and we want to add extra check for everyone. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 18:54:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 18:54:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439591.693631 (Exim 4.92) (envelope-from ) id 1os7Ga-0000R8-AM; Mon, 07 Nov 2022 18:54:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439591.693631; Mon, 07 Nov 2022 18:54:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os7Ga-0000R1-7l; Mon, 07 Nov 2022 18:54:40 +0000 Received: by outflank-mailman (input) for mailman id 439591; Mon, 07 Nov 2022 18:54:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os7GY-0000Qv-Pq for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 18:54:39 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9f65e2d3-5ecd-11ed-91b5-6bf2151ebd3b; Mon, 07 Nov 2022 19:54:36 +0100 (CET) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2A7HOGV6000820; Mon, 7 Nov 2022 18:54:29 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3kngkfw1cf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 07 Nov 2022 18:54:28 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2A7IXpkX025580; Mon, 7 Nov 2022 18:54:26 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2048.outbound.protection.outlook.com [104.47.66.48]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3kpcqf525k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 07 Nov 2022 18:54:26 +0000 Received: from BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14) by BLAPR10MB5300.namprd10.prod.outlook.com (2603:10b6:208:334::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Mon, 7 Nov 2022 18:54:24 +0000 Received: from BY5PR10MB3793.namprd10.prod.outlook.com ([fe80::72b3:f74a:9e7c:680a]) by BY5PR10MB3793.namprd10.prod.outlook.com ([fe80::72b3:f74a:9e7c:680a%4]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 18:54:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f65e2d3-5ecd-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=BOQHCEKNItzUcaRwQTeD1VqXzU6bOJPafFZLtlCHtGc=; b=pxWKjt3DzH4lZdEQAfsctO94mnMnJsQ74zMrZoFw2ZjnpR3/zr+65Lg/tuzvw+KLNS/Q xYNvkJ2G7Nt4JxhwrH/tQy5FhR9nMHTy2kMm9x6PX3MYAnJy6K5AQKpeVjwK+rHFigWg ob+8Ii7rwYqQQpv+MMFd9ZNSjJflzFIr4Haju472GMZK08yJcJe8pS3wfotkpOpsPccy kfmCaPBqLYAt2VNTPXE5XM5m+ZWJ3UA9mzJbY5MHaUlIFPz6BCSb5imUSYW1nFYIwlh/ uMuLmNwExVCs4tQIJ8hNnhXevlmM6+pmvl3qOV20Wn2UOI4B0YVO3JfK1FGlI9GD/llA rQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ePVDdWHQ9+quPSBXMej/VM4woyxrRhA+sg7nK5D7ttpug7OS4EVMgzzudfqp5IP4Kgnu3J2wxqy41S9qqAgWtfxvWOyRORCesoLFLCJAKD8QwhZAZzumLdsqKc9Qu1u92F7EC5O2UOfAK7H9iiCBLZFxpjWEzpv7B9Wxow67aZAIcZnJWcd9/zM83i98ycDfSpiCV8ncBF3hosKhx3AXj/VY/2R7iLmJlegAmdxN8lBpP7xIWavtC3c/Ai3PCR0qVjeNWehx5qiIq46c6QtSpaEOFK/qbNIliqc3yrbzH2pmtMa4uD67gDgO+OmVOYCzAEQO8+m5wUplPTB0yp1YJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BOQHCEKNItzUcaRwQTeD1VqXzU6bOJPafFZLtlCHtGc=; b=hCHwNTt8WBr9JbRVw2yioDM3jsBtCYyRDFPRlRV5AXVu3p5qcngGHMwstk1xhojQ7dOX5FNzcRfZsKu8STG9l4FWoMzyurH4cNyHYxkEn4qlI+NtAf7CX7OpBpO0xKt/rFzuvUfJPd2tW3imJQ6/Aik1vfGCPnqgVTgSB2ghC/1FBAf+yIvvpYtwgCvqwJUdPQWbNoKQTI5t0O2zXNbdPTULjCgkFxkwZkPNJgACQQjEmmXGUY/5htNQ3+Zt4iVlSdAkc8IApOg24nje+VhAfHIvOMHgpD318uvzkaJ2JJ7PM9MVUkLMbj5UrVz11CEBYTXfDEkrFvajYm8BvU6XhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BOQHCEKNItzUcaRwQTeD1VqXzU6bOJPafFZLtlCHtGc=; b=BAzLuAhQ4Xs4Ki1mTkHUWe4lfIE5sZWvTgV8x7LgF14DYNdyygUEe2EaBZ/DLPB2LPeLztIRVP6Ra/Qjdk2WPydO/ihA84pT8EU/l1R94y3hvWSB3bs6APrnRkdxSuQomI00lJNGCAxmJPmElLQtH2RxgeyOiy2ZhwNuqZdh5Ao= Message-ID: <4cf7aef9-d791-5bca-4a08-d7ecb0d4e96f@oracle.com> Date: Mon, 7 Nov 2022 13:54:19 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: Xen vs Trenchboot: TXT AP bringup Content-Language: en-US To: Jan Beulich , Andrew Cooper Cc: Roger Pau Monne , Krystian Hebel , Daniel Smith , xen-devel , "trenchboot-devel@googlegroups.com" References: <6ccbcaf7-29f4-6477-2f1f-0aa4de64e8c3@citrix.com> <82d4aea8-aa23-fc6a-47ba-deb7d182012d@suse.com> From: Ross Philipson In-Reply-To: <82d4aea8-aa23-fc6a-47ba-deb7d182012d@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BN0PR03CA0025.namprd03.prod.outlook.com (2603:10b6:408:e6::30) To BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB3793:EE_|BLAPR10MB5300:EE_ X-MS-Office365-Filtering-Correlation-Id: b746481a-aef1-42fb-65fe-08dac0f17c08 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zNFj5d/bOJ3LbJNLs7832hpNrL3uxsAsFd3RoSblElYhbnwPesAykzxTlSeGmBITJXb5BJQ9gjZ7+jX5V2pHqYygGcNoeZRVdUSygFi659htxsqaG6ghGZXP+468FN+kKKH1R1UKY8wvJdRjwwIxAdkG4PvERnEMdXkf18x145A4kJprG2iqdLlaooHDZj/P0u/J6OD3WhoKAVDD5Hz7RIv8IQRRy59fpBmT6imUbBzGLEregeKd6To0W8VslvSd0lEu/eF/tZ+SzdjNj9g6YWAP8iK4ICDJsD8sec/BRpkN3alQpjIN3CI5nmVNS9SX/PPEzlE64VL2L6FW1qH5bsro3Gc4+qJRxkU56c7qn865Bu2+MO42JY/z5siWFj3r8D1dAwcP/qbuhF/utRQZdzROCjhUke/AmObdHjOmaLL2uLmcJwIwlYIjDcx1D9nATG1rYU7oAarw4OXtLsr2XjzQO8R/NJbdTOB77YySa2Y0v8NFAFhoqDJZhDH9aDGJiYdM0GVfmNTmXWiw+jYFWBeDHmlHjFvU+PrH46SMWLtk9z5Kco8AZuFQ9886tKPMp7lYeotDJxKGOKNdDozWvDrdQCfBw6cfIKFlIe+fABRh8N0Efwt+5cv+AKvT9lpl6p13lIWGei3P5ekzVait5k2mxiyZTBjST7WJ63IPATFRtuL+4x7gYMbai5RM44BItW3ZhDY/3TST9IExxMTBom1hVQuJifQFelGZE43SSxA9hn6Fdgh9UE3ZsIuIQ+B9ZO1J5AueKL5EmIVnYpEUKZhPL2DioiMtk1eDU9oS2tDzInhEWf5zlmmp4PIDkLIF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB3793.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(39860400002)(396003)(376002)(366004)(451199015)(6666004)(54906003)(6512007)(53546011)(6506007)(110136005)(36756003)(478600001)(6486002)(966005)(38100700002)(2616005)(186003)(86362001)(31696002)(83380400001)(5660300002)(31686004)(8936002)(2906002)(44832011)(316002)(66556008)(66946007)(66476007)(8676002)(4326008)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUxsRHlPT3JPeXNFTEs4TG82NjdCMzV2UDdoaUR5d1V3a0M1akRFdGhxQXo3?= =?utf-8?B?dDBCelNJS3ZPQmhCS2h1SXBCWk5yWWlLRnFKb0ltdG9kTVE3ZGNYVEdrZExS?= =?utf-8?B?RW5WWXQ4WS83NXhuL0xoT0NMYkovMmk5QVRuM3U5MUY5NDcwcTBtTVlUOU5K?= =?utf-8?B?bmhzR05vb1krSFF5bmpGQ0JpOSs1TmNFSjJYN2NGblJDUDl2TkZlRU5rYzYv?= =?utf-8?B?K1o2VWZ1NWdPR3FqT29CQjBTS3c1NUFTbENhWFR6QURFSWlIdWNzVGQxNHJr?= =?utf-8?B?NjJLK28xbUs4akw2L2NLRldBRWxMdEQ2Y3Yrazc0UnpWbkpLRlV6RUdzY2lo?= =?utf-8?B?VVBabWxtT0JDS0VkOW5QckZWUnp0b3hBTjY4Nk5CYTJBQlJyU28zUzNRU1Zx?= =?utf-8?B?RXc4WkgyWnJyblh2NkpPWm1ZTHZuQlo1cFFNL2JTM3h6ckQrTDZxODV0dUxL?= =?utf-8?B?ZUtoK1RYRk56RGkxenZLdWpCNkVRdFFHdW8vek8xOXNxbVZJM3Y5dkdXc2ND?= =?utf-8?B?ZUNjVUZzUXRFTUl0UHBxeFZpSUJyTmZuU3Fpc1EzMnc3QTNYMDVacjVnVitW?= =?utf-8?B?ZDNRZzZ1TmwxZmJRQU04aDU4dEgxRDRDMWcwc2FUU1JqRm1tSkF1NWtCT2Rp?= =?utf-8?B?dUlsTlJMTkFRTUdMTkIwNmlXdEdRTXIxd1huUWVVMnJXa0lQYkhSOGdzTVBm?= =?utf-8?B?a3RiNGFrTUI4YWs1bitMejhyaG9GdHFXUWZmSVZTRCtXS0JWU3lHWEhBajUv?= =?utf-8?B?a0RMWk51cDF6M1hxYjFaU0RFd2pBMG1PSFN2VkZFa0lmdGtEbUZyaURBYjdQ?= =?utf-8?B?UGhZSlVLckpJMTFMb251dWtqUC92N2xOUXBrU3dmaUdMcUYzclVhdjlCTEls?= =?utf-8?B?NjZTRkJNdkNEQ0ZUejZPSDlhaTVNMnV5c01CNFhLVnNuRzR4VTZXUSttbnVE?= =?utf-8?B?Q1p6ZjZTcGFiS28yekE5TUdRemdHTlBuczNZR1pOZkZRTlhFQkhkbXgxQWhO?= =?utf-8?B?Ukg3ZFlMazhFSVJicmpsWm5WZXpBUzIrZmFIUVFGK1BEZnVSSk5MZTNRcjZM?= =?utf-8?B?dFAzRGZCM1NFZS9TV09XVDJ1MnkvY1NoaW1aTEZ2VVJzU2JzSjNnMXZiU0Zu?= =?utf-8?B?MzRWMTFtU3ZrZ2dFRHZrc2tUYzAySXpUYktXTE9Ub05EZlAyNFljSElmNUh0?= =?utf-8?B?MHZKbEJteTh0V0E1bjB2alArdXFzSkxOTXJXR2JOdlBjeGtLSFBjKzN1MGc2?= =?utf-8?B?ZE5xaWk2d1dSMEJmM1RoZks1Ty9zc3VmYzdEOExmckdiWDA2WGlzZXJTVy9m?= =?utf-8?B?eFhVYmcyS3RoTk1vbVg5SXJQazF6a3ZvTS8yZWVCUjhvVVlFb2YxZitySjhM?= =?utf-8?B?N1I0dDhORE94cnMzNEU3SVJwRFhzRDZkd3ovYXR2SktqbmRiNDFwenZZZlpp?= =?utf-8?B?WlhLbGZLY05wMFhPa2hsNnI4VmdQSDd4ckZFc2ttTzJlbTdONTJjNVNYYVIz?= =?utf-8?B?T1Z0UVhKSmtYdVBkNzkyb25XZytaV2xBN3hHMFoxMGowdGhSMEJ4UURXbkRT?= =?utf-8?B?elE5Q21NZTZ6MFcxK1QvMnk4QU1ZS2NROTBWMGRyelpTQmVqNHJVcThLMmRZ?= =?utf-8?B?bXZZeit6MXE4NCt5d2Y5c0VBWmdNV3hsUEoyR3IzSlBvUkdlTy9CbnNUMW02?= =?utf-8?B?Z0ZHOEZXRHpSbno1QWJ0Y0h1MVRCWWptZThwT2pQYUFWTC9ZRUVOVFhwa20x?= =?utf-8?B?ZFQ0M3BOMG1HTnRTRmRpV1ptTmxRTWtManhzRUJkbWFjZWl1ZkZ5dXYvSmhI?= =?utf-8?B?YkRnSThCYWYremZrWDVWY1dQZm9HemdoSGdxb1dON2U5K3BMQ0N2NHROQk9Q?= =?utf-8?B?QTdxa3lvZmJuc29mekpCSmZ1MHZBYU1iSDhKUjZIazZTdkZ1QzRoSHpWaVg3?= =?utf-8?B?SUZydmk5OGRpTjl3K1RZM3FiKzdvT1gxV2RtMG5adlY1VGduUHFYMHF1MUNE?= =?utf-8?B?WlNldWhoUEZTMSt2dlowNThpWFRMQW5GRDRkc2dla2p0Mkp3M1N0Uk1vSVVL?= =?utf-8?B?MTNRR2kwQWhzd0h1TzhkYzVib2pyZTM4K2tUenhiTS8vMGR2clRHSk9JNDZU?= =?utf-8?B?Z25Ua2JyVGhGWnJtdkU0L0FVT0p3L3Q3LzEyVnBYaktDUjcwd2k3NHFURlNW?= =?utf-8?Q?fgwWbe3dSore12UhTu02Sus=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b746481a-aef1-42fb-65fe-08dac0f17c08 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB3793.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 18:54:22.9422 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y5l8FVZ+bGCFn+/AXJbm0885JGY8ONrQXR3g0nAiFVIutbyQh0LddNb3THj6rkEV4w/fYhpyXfeXYXhkTV6IanzcMaAy9QYnuKEpkpKjB78= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5300 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-07_11,2022-11-07_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 mlxscore=0 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211070150 X-Proofpoint-ORIG-GUID: gbnSE7_FwsNkFrsomeGJ8S65D-zIHEsg X-Proofpoint-GUID: gbnSE7_FwsNkFrsomeGJ8S65D-zIHEsg On 11/3/22 05:29, 'Jan Beulich' via trenchboot-devel wrote: > On 27.10.2022 21:37, Andrew Cooper wrote: >> However, we're also very close to supporting parallel boot.  The >> serialising point we currently have is __high_start loading %rsp from >> stack_start, because that's a single pointer adjusted by do_boot_cpu(). >> Everything else, even the processor's idea of Xen's CPU id is derived >> from the stack; specifically in the cpu_info block on the top of the >> stack, which is prepared by the BSP. >> >> All we need to do full parallel boot is an array mapping APIC_ID -> Xen >> CPU index.  The AP boot path doesn't use the trampoline stack at all. >> Given some way of transforming APIC_ID into a Xen CPU index, the APs >> could pull their stack pointer straight out of the stack_bases[] array. >> This would allow us in the general case to boot APs using an >> all-but-self INIT-SIPI-SIPI.  (This is how firmware does AP bringup anyway.) >> >> >> Thoughts?  In particular, is there an obvious option I've missed[1]? > > Well, I don't see other options, but I'm not sure we're as close as you > describe. I'm pretty sure we have assumptions elsewhere that multiple > CPUs won't be starting in parallel. Those places will need finding and > adjusting. Plus the generic CPU infrastructure also assumes things are > done one by one, with (for example) cpu_up() taking a CPU number, not a > CPU mask. > > Jan > For what it is worth, I can explain what I do for the Linux kernel. After SENTER transfers control to the setup kernel (the MLE), I wake all the APs up, restore their state, disable interrupts and park them (hlt) in a safe area that was setup. Later in the SMP boot code I detect that it is a Secure Launch. This code is being called per CPU with the APIC IDs. One at a time I bypass the normal boot path (INIT-SIPI-SIPI or direct 64b) and call our SMP function. This function sends an IPI to the particular APIC in question (NMI in this case) and vectors it to the normal SMP startup code that is in the rmpiggy. From there everything else happens as it normally would and the AP jumps through the unchanged startup trampolines. There is actually not very much Secure Launch specific code in the SMP boot code. This is the one patch (well commit where the patch came from): https://github.com/TrenchBoot/linux/commit/c81d3580bea8f0111e17ad0cdfce15149b46249f And for anyone not familiar with the rmpiggy, it is a blob of machine code that is fixed up at runtime by the kernel proper and placed at an a location < 1M so INIT-SIPI-SIPI can vector to it in real mode. Ross From xen-devel-bounces@lists.xenproject.org Mon Nov 07 19:01:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 19:01:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439598.693642 (Exim 4.92) (envelope-from ) id 1os7Mi-0002Bx-Vl; Mon, 07 Nov 2022 19:01:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439598.693642; Mon, 07 Nov 2022 19:01:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os7Mi-0002Bq-T5; Mon, 07 Nov 2022 19:01:00 +0000 Received: by outflank-mailman (input) for mailman id 439598; Mon, 07 Nov 2022 19:00:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os7Mh-0002Bk-FY for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 19:00:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os7Mh-0006qA-0d; Mon, 07 Nov 2022 19:00:59 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1os7Mg-0004in-Nr; Mon, 07 Nov 2022 19:00:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=b7ir6/IhUCtGyHfS+Nzmm4aXt6Qy9706LzlqhPlFRA4=; b=usupigZLKaVMRJGvq3aopuIohy 6ax6KIdLpSPbbBRSwX3xmKWgU0P6NhE0Hz4Rg4Z8U8zndDA6YSMvy7zkQdPu1/6jAgPXmzVzRZH3m EZLy1PJdR9mTNHTn9qfI4ypuwVARLz/Pg8BVDJrcxyg5ru5SlImhl0QLe3XKfqbt4/ys=; Message-ID: Date: Mon, 7 Nov 2022 19:00:56 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build Content-Language: en-US From: Julien Grall To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Henry Wang References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-3-wei.chen@arm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/11/2022 18:55, Julien Grall wrote: > (+ Henry) > > Hi, > > On 04/11/2022 10:07, Wei Chen wrote: >> domain_build use ioremap_wc to map a new non-cacheable virtual > > s/use/uses/ > >> address for initrd. After Xen copy initrd from this address to >> guest, this new allocated virtual address has not been unmapped. >> >> So in this patch, we add an iounmap to the end of domain_build, >> after Xen loaded initrd to guest memory. >> > > Please a fixes tag. The issue was introduced by commit bb7e6d565d92. Well I forgot to add it on commit :/. I will try to remember to backport it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 19:06:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 19:06:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439607.693654 (Exim 4.92) (envelope-from ) id 1os7S4-00039T-Ij; Mon, 07 Nov 2022 19:06:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439607.693654; Mon, 07 Nov 2022 19:06:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os7S4-00039M-Fp; Mon, 07 Nov 2022 19:06:32 +0000 Received: by outflank-mailman (input) for mailman id 439607; Mon, 07 Nov 2022 19:06:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os7S3-00039G-Fx for xen-devel@lists.xenproject.org; Mon, 07 Nov 2022 19:06:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1os7Rz-0006w9-Js; Mon, 07 Nov 2022 19:06:27 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.25.99]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1os7Rz-0004wg-Cs; Mon, 07 Nov 2022 19:06:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=nfctv1FiSvHosvemxsmOjoFpYx5gCMjsE2bJ1U50OR0=; b=GFNaNoUKO9LuRKK1iU4MztISsF FCJI5mj00SLQHmMMYP/3NBBHduGG1/PpZD+TobG+MoxWNjHjhLh1yQgCK59fsr3cQcgw8rVXfYz68 nP0jETO+oAaJSOyUNHozDKLMr+UuFhVXgoTsZbvwWY4HJCI0Kl0gjgLeibmezOHtxLTA=; Message-ID: Date: Mon, 7 Nov 2022 19:06:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h Content-Language: en-US To: Jan Beulich , Luca Fancellu Cc: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-5-luca.fancellu@arm.com> <5caf911d-e96d-39e4-d945-db6537412f60@suse.com> <3925276F-8B6E-4B19-9EC2-C085FE88A637@arm.com> <933c4227-5839-312e-3996-693a7d8f7706@suse.com> From: Julien Grall In-Reply-To: <933c4227-5839-312e-3996-693a7d8f7706@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/11/2022 12:56, Jan Beulich wrote: > On 07.11.2022 12:53, Luca Fancellu wrote: >>> On 7 Nov 2022, at 11:49, Jan Beulich wrote: >>> On 07.11.2022 11:47, Luca Fancellu wrote: >>>> --- a/xen/include/xen/kernel.h >>>> +++ b/xen/include/xen/kernel.h >>>> @@ -65,24 +65,28 @@ >>>> 1; \ >>>> }) >>>> >>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>> extern char _start[], _end[], start[]; >>>> #define is_kernel(p) ({ \ >>>> char *__p = (char *)(unsigned long)(p); \ >>>> (__p >= _start) && (__p < _end); \ >>>> }) >>>> >>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>> extern char _stext[], _etext[]; >>>> #define is_kernel_text(p) ({ \ >>>> char *__p = (char *)(unsigned long)(p); \ >>>> (__p >= _stext) && (__p < _etext); \ >>>> }) >>>> >>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>> extern const char _srodata[], _erodata[]; >>>> #define is_kernel_rodata(p) ({ \ >>>> const char *__p = (const char *)(unsigned long)(p); \ >>>> (__p >= _srodata) && (__p < _erodata); \ >>>> }) >>>> >>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>> extern char _sinittext[], _einittext[]; >>>> #define is_kernel_inittext(p) ({ \ >>>> char *__p = (char *)(unsigned long)(p); \ >>> >>> Why the "R8.6" everywhere here? Didn't we agree that the in-code >>> comments should be tool-agnostic? >> >> The R8.6 is not tool specific, it is to give the quick hint that we are deviating >> from MISRA Rule 8.6. > > Well, yes, "tool" was wrong for me to write. Imo references to a specific > spec should equally be avoided in in-code comments, as other specs may > turn up. +1. The comment duplication is not great and sometimes even a short explanation it may not fit in 80 characters (AFAICT the justification should be a one line comment). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 07 22:06:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Nov 2022 22:06:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439636.693675 (Exim 4.92) (envelope-from ) id 1osAFt-000099-MU; Mon, 07 Nov 2022 22:06:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439636.693675; Mon, 07 Nov 2022 22:06:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osAFt-000092-J4; Mon, 07 Nov 2022 22:06:09 +0000 Received: by outflank-mailman (input) for mailman id 439636; Mon, 07 Nov 2022 22:06:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osAFs-00008s-LB; Mon, 07 Nov 2022 22:06:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osAFs-0002Sz-K9; Mon, 07 Nov 2022 22:06:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osAFs-0006my-32; Mon, 07 Nov 2022 22:06:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osAFs-0006uz-2d; Mon, 07 Nov 2022 22:06:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=20N9zzvfh2Tfs5csrgcI5q0aKt8KAo2o1Znz4J2nrYI=; b=dekcoUqP8SX8X3JU++9rD4h8J2 1OtEYJd8x6C+d+yABbZggHsmaERqM9/IbO7W06/lj1zkU5hpJ2vMEYal5bcL2mq/3fjcfhryHPw8s 3OgTS7zk/RgA90UwTNYaBvqtiwt+Ru/QKPy+5BIrtODXLUXq2uyoQT3ER3FVFo9gj7pE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174661: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e61a78981364925a43c9cc24dc77b62ff7b93c9f X-Osstest-Versions-That: xen=37f82facd62f720fdcec104f72f86b8c6c214820 From: osstest service owner Date: Mon, 07 Nov 2022 22:06:08 +0000 flight 174661 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174661/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e61a78981364925a43c9cc24dc77b62ff7b93c9f baseline version: xen 37f82facd62f720fdcec104f72f86b8c6c214820 Last test of basis 174622 2022-11-04 11:02:05 Z 3 days Testing same since 174661 2022-11-07 19:00:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Julien Grall Wei Chen jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 37f82facd6..e61a789813 e61a78981364925a43c9cc24dc77b62ff7b93c9f -> smoke From xen-devel-bounces@lists.xenproject.org Tue Nov 08 01:06:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 01:06:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439658.693687 (Exim 4.92) (envelope-from ) id 1osD41-0003L9-KM; Tue, 08 Nov 2022 01:06:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439658.693687; Tue, 08 Nov 2022 01:06:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osD41-0003L2-GR; Tue, 08 Nov 2022 01:06:05 +0000 Received: by outflank-mailman (input) for mailman id 439658; Tue, 08 Nov 2022 01:06:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osD3z-0003Kw-DF for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 01:06:03 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60071.outbound.protection.outlook.com [40.107.6.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 81b30053-5f01-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 02:05:59 +0100 (CET) Received: from AM6P193CA0104.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::45) by DBBPR08MB6122.eurprd08.prod.outlook.com (2603:10a6:10:20d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 01:05:56 +0000 Received: from AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:88:cafe::f4) by AM6P193CA0104.outlook.office365.com (2603:10a6:209:88::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Tue, 8 Nov 2022 01:05:56 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT042.mail.protection.outlook.com (100.127.140.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 01:05:55 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Tue, 08 Nov 2022 01:05:55 +0000 Received: from 881bfb1e62b2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7E893127-E365-4D61-8187-BCCC2FF31054.1; Tue, 08 Nov 2022 01:05:49 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 881bfb1e62b2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Nov 2022 01:05:49 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DBBPR08MB6203.eurprd08.prod.outlook.com (2603:10a6:10:201::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 01:05:47 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Tue, 8 Nov 2022 01:05:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81b30053-5f01-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lvF9Epvz9dxyyoTbNOXJSvEUPvgnumjag0leTRCk1fa5WTBCFSdObw6etSfnCOuUx6Dp+1rIMbvZsfYfPkROCqDJU34zXag0WoRkQv80XDFVFsqQMvoZw2v2a4wBg6xdSlCS01H7E/HGDWzOTFHmiU6yr2f5CSYPgyo9WDb5RvQIYMvimEwvuIAmdWMM9DvXD0wnnd7R4FtEYxkA4lh9jxxZTjlMY1PM5Ks6eFsudPQMasrHwaMm2fuYEQprDXpxlJIEhOuUJBNufTgnAzYRtxwvqWIO1SANQUB6+IWn0YuBUUqMj+DLDf8tucq6cFD6Fa+M8SQZdWxcN2/2N07imw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jqa2RjtQWWG/e0fAb9DGuzRMYmH/1iSHfNHPjH8ugbQ=; b=DbTr41ir91N++DEvRYn8Wl7h4cFn+MJtxB5PjDVVY+4OXMTmqvmN4WBQOxKHIacT5wT4ORzEJR5nrK7cJEp8pNNGfSLQECNNBUNl3fDUfzfNZzjspEw4KbGgKMRRa28rIImWyrz0CK+a0ApqSjUs8YJlwHsQxQ0WNMvrtJF/BjJY7H1/GQ+99nbp45jtQ0S5CbO8hu2/8CSIrz0NRbJS8jr3bHe9CwWuI/JVuPAq2l2EZCk8VcWHUaVNzIXnHqP/HmLK9fqaF6MsC1cD7PmxyT2701JchJICgQwv/a0dIdqpcUt13mhUtvLXIUMU90C0MqL5/P5rC/Y4Hknp0I8elA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jqa2RjtQWWG/e0fAb9DGuzRMYmH/1iSHfNHPjH8ugbQ=; b=Je0j1OJIziOnGbGPR7/ucqxXR1vu30blNlYGzFrG+CzizRzXYiuV7ZkBajUMUwmFNsDZq5x6bUOeZ4nXdD4ZVRHjPD8NQBENzFbDCa9SUiS8TfGnXTrQ8sj8rOJ+zZPZatsLbpT9Bb91RRL65J+aXlFE0f1zys/mTJhOOGN8mXQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OeVjHBswMsT/u3LLLihGGAAG/X/vAVcPiSk5lem8bON+YbHm9uYhA0cGynRbzr9nKqXCU9L1d2ofLsDP0+aZxW410kt6nt+tQJVW0n+4aEOYNe0CKxeAYnf8tRxnVw1ecJXR25+CXxPWyzik5RBwE3NPHiBTvlmtzOW2DVdelu75I2JhawRIIKMhSfh2NlG3gkGpkVoQK14G9EHhDXRuRFF9rN9hSw1jwi6FzuD74mrXwdxGxiywca4RkqqWanUAtpoxlYYprSuKDDhqICNjZDUFXjizv/hhBn7VKxeGZrHVGk4ppM5GHDWjDTr3O5OoP77aP4uu7J6t+pBv2yeeag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jqa2RjtQWWG/e0fAb9DGuzRMYmH/1iSHfNHPjH8ugbQ=; b=Af4+e8pcKaVCDjoTYI+ROh8r+xICcU7UIVgfp8Hpq6ZF5u3jrrt9cwNwX/7wCz2RMjMfbfvEZaPbIybfpsya/CSJbK+v9R+sX6paxE031ZJhKqs6U0LUw7rtnvBUADH7hhuGNnGzPq0TUdilijFdzNFH0e1XTGLxIubyvYv9sgd8USkGLlQFgRYFmJ3dLb2ekeXKVeJBPywXpSgUu3YH0QE7ihzw8ntuUHWhDLCjhpc0gOb0nohDmt6nQcuaW5Z6tu75ptf9PiNqaHgCUeuZlzYnraIuuROdR4TiRMAS07KLoP+HUoHkS/LX7Xr4SnSFIpok9ToZhSvYjSRpJVHGDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jqa2RjtQWWG/e0fAb9DGuzRMYmH/1iSHfNHPjH8ugbQ=; b=Je0j1OJIziOnGbGPR7/ucqxXR1vu30blNlYGzFrG+CzizRzXYiuV7ZkBajUMUwmFNsDZq5x6bUOeZ4nXdD4ZVRHjPD8NQBENzFbDCa9SUiS8TfGnXTrQ8sj8rOJ+zZPZatsLbpT9Bb91RRL65J+aXlFE0f1zys/mTJhOOGN8mXQ= From: Henry Wang To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: RE: [PATCH][4.17] kexec: restore hypercall 1st arg's type Thread-Topic: [PATCH][4.17] kexec: restore hypercall 1st arg's type Thread-Index: AQHY8rrrC5MnTfe7JEO9u4gvJODJ2K40NucQ Date: Tue, 8 Nov 2022 01:05:46 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3E38498ED0CEA24A86B6E8A655358250.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DBBPR08MB6203:EE_|AM7EUR03FT042:EE_|DBBPR08MB6122:EE_ X-MS-Office365-Filtering-Correlation-Id: ea3f1c65-ba75-4ac8-9ba8-08dac1256373 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: juTE0kUeUWeUycQu8daPO3PICW59qge03zvor96iEd4AaE+4VbMZQnkltkyy6YQ39kf09Rfv55O8NyvqSPF6Hkb6wJx+BfRpL8dI734QN7zvyVODhU0vTpyNk1nFoxjBpydcpDkTmalMU/0KqBKMgeTy45OHnU3wP/VHvYuNVzFg4z0LNpgA23qE8c9QcruNbkjL6taX0xyeLTznZjc2yCENqPz40sC8NMZrNIvHqXKNJwWkkIOsBl+mD9hIlqJzrbV4sqfXZCMmK+I0+nHSTKOo6weI9xFFYsCdIfPpLF7aLORQmkp0LcOlgnUnuDKjnim9H5BfsFXgr9e9nZp1RZOF0nITlmjGoRdmDnp1/7w8aF1HmjBPnvVdxDTExjuUFxYPyJm4dy+w66P2QbGsSAo3uggrRpYqC6JaYSJi66wjprZiuD6w0QT/w7luhvkXLoHpJMkzBi9nJPFHaWXvBaGeOazeRJht5d1PJh7URGciUdhprK83f52wogSCLKPM3Q5bmzsNtHwPwxDmWiAYAXu0wEJGtkh5bE8nTozUzY60ZjAelSgNVVvgwXEa2u5n06YhaW3uzmj7JVvuUfeAy56Uq9Q83CLiBNCM0vP7BEo8+NKUCZbbHydIxbp2sRcae1hFHJBNLd7DEqq44m1eorH4YVu2Ee/HhG0kLbjO6y7iziTb9KhHhsUpmPL+OCL+2RFL0TVSQcw6VtlhTPMta+5v/vFQ8s0YeQIMT/QOInh5p2McOQmnAJPe3VX4izW78TapchHZlLDi3y1J0Ocaww== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(376002)(39860400002)(346002)(451199015)(52536014)(7696005)(2906002)(55016003)(66446008)(71200400001)(64756008)(4326008)(66476007)(76116006)(66556008)(66946007)(33656002)(38100700002)(110136005)(8676002)(5660300002)(54906003)(316002)(122000001)(38070700005)(478600001)(86362001)(41300700001)(8936002)(9686003)(83380400001)(186003)(6506007)(26005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6203 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a43baaed-93f7-407b-e23a-08dac1255e68 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AVsMUZOHJHP7PD3wMV7sTjQAUxUnY8lh1FgDXuQprwaK9wF98IEOQah/Bc3SBTKORaDKuwoPebPYBFjq7eJq0Y6Z53X9WglP/41CjgUI05wTShpdf6QISBuwAPhQMCejXUL7xqZoz815WCjr+bOfEqK0A1IjntqqN3povLkWfHheZSDo0zs0MKfYQZhqD0FuqOqLyAYP1/fqQPA2aVku5E4PzXQVm5Gsn1op6Uq3ROZNyPcfaZikGXKLQaIukL7nGucTb7bLpyYXphWiz3o4Nwmtb88ytQjeXfA18jy1jDM/tXiEU5m38jd9ujY0x9dK/mIN4aTOkXAP7UmEXT9u1mtZj0CRlQ5JqF5OWWRsDs5F8RBqgfTodWbKRjQpj1sXbsQll+Qy/Cazh3DRbW/dmUnorEnjY2p9wMv/w8MLBLCVsHTSdmg3OwmlSXQQZnOaHyYGfEC6ib9FWJUYY/ytyaV55PzQHUJCSrEaD9jrTODXgNwewoBgkhqszncXuSm2UEuo5l7mAEWzYQvjxaUnQp/c9PmF5iijU3uiq7ofBfZVnCEHPqF2nXHmarYesl13hCdt1qFfax2VAzYG6LlxVTBP/tKmyARc6thoCH56g34fx6Ev4lH9wFkaTMG8DJtW44g2Yj50SsBNXhw03DSA5t6Yj9a6tNcQMue4lck4AjgYdAGW3DijMR1iL/hYbPxhDHed5MpZkqjooXumMuwreZASrv8MHSY2ZXz8IvCLWyRnVpJ6rbh0XxW0e12M1EXtKU7R4kDgzHJb2RAVawbyag== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199015)(46966006)(36840700001)(40470700004)(478600001)(81166007)(52536014)(33656002)(8936002)(4326008)(70586007)(70206006)(8676002)(55016003)(40480700001)(5660300002)(316002)(54906003)(41300700001)(2906002)(110136005)(356005)(83380400001)(36860700001)(336012)(86362001)(6506007)(7696005)(9686003)(82740400003)(40460700003)(26005)(186003)(82310400005)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 01:05:55.2193 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ea3f1c65-ba75-4ac8-9ba8-08dac1256373 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6122 SGkgSmFuLA0KDQpUaGFua3MgZm9yIHRoZSBwYXRjaC4NCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3Nh Z2UtLS0tLQ0KPiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFN1Ympl Y3Q6IFtQQVRDSF1bNC4xN10ga2V4ZWM6IHJlc3RvcmUgaHlwZXJjYWxsIDFzdCBhcmcncyB0eXBl DQo+IA0KPiBUaGlzIHJldmVydHMgYSBzbWFsbCBwYXJ0IG9mIDdlMjFiMjUwNTllZCAoInhlbjog aGFybW9uaXplIHJldHVybiB0eXBlcw0KPiBvZiBoeXBlcmNhbGwgaGFuZGxlcnMiKS4gVGhlIGNo YW5nZSBmcm9tICJ1bnNpZ25lZCBsb25nIiB0byAidW5zaWduZWQNCj4gaW50IiBmb3IgdGhlIG5h dGl2ZSBoYW5kbGVyIGZ1bmN0aW9uIG1lYW50IHRoYXQgcHJldmlvdXNseSBpbnZhbGlkDQo+IHZh bHVlcyBiZWNhbWUgdmFsaWQuIFdoaWxlIHBlcmhhcHMgbm90IGEgc2lnbmlmaWNhbnQgaXNzdWUs IHN0cmljdGx5DQo+IHNwZWFraW5nIHRoYXQncyBzdGlsbCBhIGNoYW5nZSB0byB0aGUgQUJJLiBE b24ndCBnbyBhcyBmYXIgYXMgcmVzdG9yaW5nDQo+IHRoZSBjb21wYXQgZW50cnkgcG9pbnQncyB0 eXBlIHRob3VnaDogVGhhdCBvbmUgY2FuJ3QgaGF2ZSB2YWx1ZXMgcGFzc2VkDQo+IHdoaWNoIGRv bid0IGZpdCBpbiAzMiBiaXRzLg0KPiANCj4gTm90ZSB0aGF0IGFzIGEgc2lkZSBlZmZlY3QgdGhp cyBmaXhlcyB0aGUgaW52b2NhdGlvbiBvZg0KPiBoeXBlcmNhbGxfY3JlYXRlX2NvbnRpbnVhdGlv bigpLCB3aGljaCBieSBtaXN0YWtlIHdhc24ndCBhZGp1c3RlZCBieSB0aGUNCj4gZWFybGllciBj aGFuZ2UuDQo+IA0KPiBBbHNvIHRha2UgdGhlIG9wcG9ydHVuaXR5IGFuZCBjb3JyZWN0IHRoZSBy ZXNwZWN0aXZlIGNvbW1lbnQgaW4gdGhlDQo+IHB1YmxpYyBoZWFkZXIuIChUaGUgd2F5IGl0IHdh cyBpdCByZWFsbHkgc3VwcG9ydHMgdGhhdCBpdCBwcm9iYWJseSB3YXMNCj4gcG9pbnRsZXNzIHRv IHVzZSAibG9uZyIsIGJ1dCB0aGF0J3MgdGhlIHdheSB0aGUgaHlwZXJjYWxsIHdhcw0KPiBpbnRy b2R1Y2VkLikNCj4gDQo+IFJlcXVlc3RlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3Bl cjNAY2l0cml4LmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1 c2UuY29tPg0KDQpSZWxlYXNlLWFja2VkLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5j b20+DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 08 02:15:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 02:15:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439671.693698 (Exim 4.92) (envelope-from ) id 1osE8Y-0003TS-Mn; Tue, 08 Nov 2022 02:14:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439671.693698; Tue, 08 Nov 2022 02:14:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osE8Y-0003TK-IA; Tue, 08 Nov 2022 02:14:50 +0000 Received: by outflank-mailman (input) for mailman id 439671; Tue, 08 Nov 2022 02:14:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osE8X-0003TE-0A for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 02:14:49 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2069.outbound.protection.outlook.com [40.107.247.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c0aa07a-5f0b-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 03:14:46 +0100 (CET) Received: from AS8PR04CA0113.eurprd04.prod.outlook.com (2603:10a6:20b:31e::28) by PA4PR08MB6174.eurprd08.prod.outlook.com (2603:10a6:102:e6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 02:14:41 +0000 Received: from AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31e:cafe::c5) by AS8PR04CA0113.outlook.office365.com (2603:10a6:20b:31e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 02:14:40 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT036.mail.protection.outlook.com (100.127.140.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 02:14:39 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Tue, 08 Nov 2022 02:14:39 +0000 Received: from 3a7f5fb9f7e8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 09589D5F-13EB-4480-BB09-D3BB4BB884D1.1; Tue, 08 Nov 2022 02:14:29 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3a7f5fb9f7e8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Nov 2022 02:14:29 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by PAXPR08MB6590.eurprd08.prod.outlook.com (2603:10a6:102:152::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 02:14:28 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5813.011; Tue, 8 Nov 2022 02:14:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c0aa07a-5f0b-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=m5aQKG5Q2Uu7r/MCFgtCxoOsLVFC3iNeE7P1+tgzGM0qZ1F1cwB4cgHcjilML6yNwIV1YkUEV//PZwVNO/0Bty0Kl7T54iDRQlcC/lRuqUwa4NsJcgIhvvRuJvycfZeC6fXL2/hpLxJh0jbZRUP6OAMW6uj5qaRqISB/uPbE7x1+YgxOfgawHdR6hzOGiz5Fv86Zz1vBqdD39q3s5wnG4z4SsfWGFtb6Pc9I0d1vX2eMS7Fkh7QFfsItUW3vFx3kLeRFlauiPAeoqrP0TO7d7uI7OACITQB1wzq9XOazIcEemb5dr/HX5oF/V9h45EsBrXptqUPNu7efmJXRdkJElA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SjF17iVkr4reWQKsw0Uv9LswPpcZegPaSK5J0X+Nzrs=; b=fVWk4lKwADXg2udKY/8in2Iziu9XTlUKO/PR4XIULzVvFaWWP9acoYFdMoBEgMFKwcKcxnVrlkZPvp8uz10Yrp5a/+cn+Ylu6Aj8fvcgoXpAiDIu3yVDJ0EhkL3X1vxsVaGvVsYNxzPeq1ZVAPW8SC9G+MoZ1jjeYv3lNbkzHSY9yEy8S8OYBT4R15p82dhMyypberqJ/EjwrNzHcKu2ijY9K52jDE08pLG517UHOcWT5RcvIwSPpqoFjl6VpApX8SqcvRw/alcNDyfnxvZaYtGWi9E3/F6PZhiDVdZyS+580WUIJEPIJcUAaZx1H1EeL6EgyGBwUr25bagRaX0T1A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SjF17iVkr4reWQKsw0Uv9LswPpcZegPaSK5J0X+Nzrs=; b=XuT5xFP0QKF0BovF7G0iaY1gwsz/2hh+7aYhlSyWcbGnPnUlJOK/kO3wmzLctbp8v9QjnkUllpozkQIQZ9TEpRfAoRvKrq/gsVDWM3ELWeS0PFE9vIgAbK8L6EaImVxIzLWuxnQuzGUZh+lQ/bL5x3A7vptIepu+s0elDZofn64= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mBQ6stISBBlsgvhSasEaIcK7l6XQx5qLqHJlYFNw4lcXeHji5CkzJUQ6RUgB1PCdO2XEFAeXd+BscZ7xQ8vVVWq59aycFbMtNdOHrGdUF1GpPJW0xOmfUk9jSV8/FMDAVKRCov3N7X0TrGGMuUNcwKos0reCoySJc5PeWkT5w4DnAJlH1WAs8QBrEKegIsIwxYTcO1F20tZsjCmb7ewiOgriU2zUzao+UKUeffrTi4j0M63WRPMaVy7UWoVc959jncK24aKVMD7FDeV3Jvb3y2w3ohnDYgqyxK7ygctow/0EJGm31KhsA3SHWFdlavsYh31rExdDLB79lXsUJMvDAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SjF17iVkr4reWQKsw0Uv9LswPpcZegPaSK5J0X+Nzrs=; b=WRNIgZA0lp2GDbyFNltdLvPVhXEDeKBzMY8tx1JIz1U/wneTs43l0LUrx5+qyjfe99ddF/otBSgPv5qrpgAJHd5B4psp6d97LbX0CTknV+LOv7vNS00/1N8FMV6//ya47WuVVJ8+BQ/u6Egs8/rU8kjTFM9KPFezQB1TJgqNehM3t6829gu7DcurbXLIguO5vqpgtdviYsSGXXJTun6swxtU6vz5UIFUrAjLLiLh/osSgDNAG3KCJSiavmMHK5JKRJTYFUMPQYmB2EQpnzQkEGuew2pdr6XPaTSJKg66CCIFWh4dlYX7Tuk1p7zOIHLmLmTdHbnVGOY0cFQkm8OuQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SjF17iVkr4reWQKsw0Uv9LswPpcZegPaSK5J0X+Nzrs=; b=XuT5xFP0QKF0BovF7G0iaY1gwsz/2hh+7aYhlSyWcbGnPnUlJOK/kO3wmzLctbp8v9QjnkUllpozkQIQZ9TEpRfAoRvKrq/gsVDWM3ELWeS0PFE9vIgAbK8L6EaImVxIzLWuxnQuzGUZh+lQ/bL5x3A7vptIepu+s0elDZofn64= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: RE: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build Thread-Topic: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build Thread-Index: AQHY8DVmEdLqaRCRCUuW0jNzr25ema4yQiqAgAIMi/A= Date: Tue, 8 Nov 2022 02:14:27 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-3-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C25938EC87CAA643AEDB0E0EC50874BD.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|PAXPR08MB6590:EE_|AM7EUR03FT036:EE_|PA4PR08MB6174:EE_ X-MS-Office365-Filtering-Correlation-Id: 069682a2-e30c-4667-0ab7-08dac12efdff x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GrVoHuz5snUWev+bEhey329ZJq4ywAxqT9qkO4y+XNRDaoRDBvGKSNW11oVPnimNdK0x6KqPlr3r3vylBIQII0vDPguCqXQLN/cEYO73kfjwawU5aN9t1qb4IuUveUDFxU7kkFbaNAoX3BMfO2oL+FlpgtUI9dhP+Qpx/JkTzBD23pX14SS0AVA2//9gxziH5lPQi0clYRqOLhyiz1reoWOiPV8WnjrkHiCvLQKEIn3RJuHs1wcv9ciLysO4PcDT5Zxa8m26L27vBxYymedBzfvHTKtrhHOhjDGXtbAREF6fh67gn6bzlZt17mFxjNFvWBrMesIW242C6G1j1m3cEPtIKXCZkSrY31THdBti37JMgLgxEfrzDSjl2P7RoiXzc27OOMlg09572gNOWnV6AYUV8I2lf2ppnvyhzj4D+rS6HOWw31oHsHINknVUXPRgCbdx++RcWpTZ6F1aZKQIxbD0RlCluvyWCCZRtSI9h+lS+Q9f5dNpZlN12mrWi6DtDHaGGRT4DyBRZ7T+dYH7a9EmIWsR3rwsDju7v/jv7EUPRzXpCAkyy0B/O7yojm0Ql69jCp6i+5dqNxPyqotUVpuVOQncfMRaBlb6JMQEurRp4be26JvTJKumQNiDf9z4CO7x9shUh9fLg7z2u840Yc+BTs/w7eFlfbCwXXdEduQoVwmDJAD+t7OlWY41LMdbKN5z2znWaz5cLVGWggugUlHxQC2+3giy2VGiXckT9WupNbaL55JZTtygMuevHNzG7Rk0eTkDjs3WGc8gIiZOLQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(376002)(396003)(346002)(136003)(451199015)(41300700001)(6506007)(7696005)(52536014)(8936002)(76116006)(71200400001)(316002)(66556008)(55016003)(66446008)(66946007)(4326008)(64756008)(66476007)(8676002)(38100700002)(2906002)(122000001)(33656002)(5660300002)(54906003)(110136005)(38070700005)(86362001)(26005)(186003)(53546011)(478600001)(9686003)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6590 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 309d0817-7639-42d0-abf7-08dac12ef663 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kxDZUf/Gu89ZprmvNujYBJGLenzJ0/QhlnUINjX74ncy56UK5nkCK7O1FoMRBkvsTxtUrMUjDjFDSQ15M0smZE3R4ByeBbEMSVBwoxe0w/ZfNNfB51w6UCeWfSm/JGFKm9kKePax4V+l2acyYgTb/+wvxbzVFwOyn0nuevWYNKcx8c4/caRSKRI0WVBhs9me7BKnNjOIeLSBB2p5maLzlOSE141zOoDJjNFEGBZNB/r51WtEZJl2h+FCN7FTPs2FoziYwSE9kcLOfuFD395RH8UsP1cECL2Q2zYJvaEwjqtRkPtViO/W/2Vfw2m1S7Mp1c23PrZ2k66iTGQf1Nl4bkVPREic0+ICkO8qk0IYoxTNf9MGbYhiQqklH3v7nDk9WIRSgysaiTDlfyE+BrQeX50MNdFBc+al3EDm/lANWeYDUgvmubB8WViz5fohB5EULGqlvg2htH5FARXBkPqXUbeRKVYMOmF1lSUA2IjxR2vdfMEmgM0/qxzMQKZXfLq9PzqxydBuA5V7gdS9oDRcACm6NRwk4Jd42+4Wv/4FiikLHSxP1frXwmRV2xtRAxHWQhMc8SpbAobqqyZqHMGSp9nVQ9wqetgiD8pssw72jrpjZfh12M31u6lsBrBBOO0yCX2ARl333NkMWyhVLkbNKegMrcuwvTLQqMmX511PiAzeEVgu0ak63AIv0X2IDzp14DahtuTN5MQxiQeUz561o/uvarE7PDmtqEOwATaBLvho6zscGpV54EU5vsvP20QlrqUChBgvX7QpmVE3UkqHqg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(36840700001)(46966006)(40470700004)(336012)(47076005)(186003)(40460700003)(316002)(82740400003)(55016003)(478600001)(86362001)(33656002)(40480700001)(356005)(81166007)(82310400005)(6506007)(7696005)(26005)(36860700001)(53546011)(9686003)(110136005)(54906003)(8936002)(2906002)(41300700001)(83380400001)(52536014)(5660300002)(4326008)(70206006)(70586007)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 02:14:39.9884 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 069682a2-e30c-4667-0ab7-08dac12efdff X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6174 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFhlbi1k ZXZlbCA8eGVuLWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFsZiBP Zg0KPiBKdWxpZW4gR3JhbGwNCj4gU2VudDogMjAyMuW5tDEx5pyIN+aXpSAyOjU1DQo+IFRvOiBX ZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9y Zw0KPiBDYzogbmQgPG5kQGFybS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5p QGtlcm5lbC5vcmc+OyBCZXJ0cmFuZA0KPiBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5j b20+OyBWb2xvZHlteXIgQmFiY2h1aw0KPiA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+OyBI ZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjYg MDIvMTFdIHhlbi9hcm06IGFkZCBpb3VubWFwIGFmdGVyIGluaXRyZCBoYXMgYmVlbg0KPiBsb2Fk ZWQgaW4gZG9tYWluX2J1aWxkDQo+IA0KPiAoKyBIZW5yeSkNCj4gDQo+IEhpLA0KPiANCj4gT24g MDQvMTEvMjAyMiAxMDowNywgV2VpIENoZW4gd3JvdGU6DQo+ID4gZG9tYWluX2J1aWxkIHVzZSBp b3JlbWFwX3djIHRvIG1hcCBhIG5ldyBub24tY2FjaGVhYmxlIHZpcnR1YWwNCj4gDQo+IHMvdXNl L3VzZXMvDQo+IA0KPiA+IGFkZHJlc3MgZm9yIGluaXRyZC4gQWZ0ZXIgWGVuIGNvcHkgaW5pdHJk IGZyb20gdGhpcyBhZGRyZXNzIHRvDQo+ID4gZ3Vlc3QsIHRoaXMgbmV3IGFsbG9jYXRlZCB2aXJ0 dWFsIGFkZHJlc3MgaGFzIG5vdCBiZWVuIHVubWFwcGVkLg0KPiA+DQo+ID4gU28gaW4gdGhpcyBw YXRjaCwgd2UgYWRkIGFuIGlvdW5tYXAgdG8gdGhlIGVuZCBvZiBkb21haW5fYnVpbGQsDQo+ID4g YWZ0ZXIgWGVuIGxvYWRlZCBpbml0cmQgdG8gZ3Vlc3QgbWVtb3J5Lg0KPiA+DQo+IA0KPiBQbGVh c2UgYSBmaXhlcyB0YWcuIFRoZSBpc3N1ZSB3YXMgaW50cm9kdWNlZCBieSBjb21taXQgYmI3ZTZk NTY1ZDkyLg0KPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBXZWkgQ2hlbiA8d2VpLmNoZW5AYXJtLmNv bT4NCj4gPiAtLS0NCj4gPiAgIHhlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyB8IDIgKysNCj4g PiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykNCj4gPg0KPiA+IGRpZmYgLS1naXQg YS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxk LmMNCj4gPiBpbmRleCA0ZmI1YzIwYjEzLi5iZDMwZDM3OThjIDEwMDY0NA0KPiA+IC0tLSBhL3hl bi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9kb21haW5f YnVpbGQuYw0KPiA+IEBAIC0zNDE4LDYgKzM0MTgsOCBAQCBzdGF0aWMgdm9pZCBfX2luaXQgaW5p dHJkX2xvYWQoc3RydWN0IGtlcm5lbF9pbmZvDQo+ICpraW5mbykNCj4gPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluaXRyZCwgbGVuKTsNCj4gPiAgICAgICBp ZiAoIHJlcyAhPSAwICkNCj4gPiAgICAgICAgICAgcGFuaWMoIlVuYWJsZSB0byBjb3B5IHRoZSBp bml0cmQgaW4gdGhlIGh3ZG9tIG1lbW9yeVxuIik7DQo+ID4gKw0KPiA+ICsgICAgaW91bm1hcChp bml0cmQpOw0KPiANCj4gVGhpcyBsb29rcyBnb29kIHRvIG1lLiBCdXQgSSBhbSB3b25kZXJpbmcg d2hldGhlciB1c2luZyBpb3JlbWFwX3djKCkgaXMNCj4gYWN0dWFsbHkgY29ycmVjdCBiZWNhdXNl IHdlIGFyZSByZWFkaW5nIHRoZSByZWdpb24uIFNvIGl0IHNlZW1zIHN0cmFuZw0KPiB0byBtYXAg aXQgd2l0aCB3cml0ZS1jb21iaW5lLg0KPiANCj4gU28gSSB3b3VsZCBjb25zaWRlciB0byB1c2Ug aW9yZW1hcF9jYWNoZSgpLiBUaGF0IHNhaWQsIHRoaXMgd291bGQgYmUgYQ0KPiBzZXBhcmF0ZSBw YXRjaC4NCj4NCg0KT2ssIHdlIHdpbGwgdHJ5IHRvIHVzZSBpb3JlbWFwX2NhY2hlIGFuZCB0ZXN0 IGl0LiBJZiBldmVyeXRoaW5nIHdvcmtzDQp3ZWxsIHdlIHdpbGwgaW50cm9kdWNlIGEgc2VwYXJh dGUgcGF0Y2ggaW4gbmV4dCB2ZXJzaW9uLg0KDQpDaGVlcnMsDQpXZWkgQ2hlbg0KDQoNCj4gSSB0 aGluayB0aGlzIHdhbnRzIHRvIGJlIGluIDQuMTcuIFRoaXMgd2lsbCBhdm9pZCBYZW4gdG8gaGF2 ZSB0d28NCj4gbWFwcGluZ3Mgd2l0aCBkaWZmZXJlbnQgY2FjaGluZyBhdHRyaWJ1dGUgKGluaXRy ZCBpcyBwYXJ0IG9mIHRoZSBSQU0gYW5kDQo+IHRoZXJlZm9yZSBkaXJlY3RtYXApLg0KPiANCj4g Q2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Tue Nov 08 02:24:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 02:24:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439678.693709 (Exim 4.92) (envelope-from ) id 1osEI1-0005ER-Mm; Tue, 08 Nov 2022 02:24:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439678.693709; Tue, 08 Nov 2022 02:24:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osEI1-0005EK-JR; Tue, 08 Nov 2022 02:24:37 +0000 Received: by outflank-mailman (input) for mailman id 439678; Tue, 08 Nov 2022 02:24:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osEI0-0005EE-AA for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 02:24:36 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2052.outbound.protection.outlook.com [40.107.105.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7c66d580-5f0c-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 03:24:35 +0100 (CET) Received: from AS8PR04CA0191.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::16) by GV1PR08MB8153.eurprd08.prod.outlook.com (2603:10a6:150:93::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 02:24:32 +0000 Received: from AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f3:cafe::89) by AS8PR04CA0191.outlook.office365.com (2603:10a6:20b:2f3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Tue, 8 Nov 2022 02:24:32 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT026.mail.protection.outlook.com (100.127.140.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 02:24:32 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Tue, 08 Nov 2022 02:24:31 +0000 Received: from dfa80afe70ba.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D4E56138-F90D-4A23-81A1-594F84857D72.1; Tue, 08 Nov 2022 02:24:21 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dfa80afe70ba.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Nov 2022 02:24:21 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by VE1PR08MB5821.eurprd08.prod.outlook.com (2603:10a6:800:1b2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 02:24:19 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5813.011; Tue, 8 Nov 2022 02:24:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c66d580-5f0c-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Klqr6KKGvOuUAavdq8HExJhL36/OX19jNhXPoanKGqDV+0BAaPME6khYNoMiNOFFIrqPxNiJ7uU4IkuFJfB1qkd5WPgtfWQAJTP8ZKDHZH716i4YCDrLxA8Ld6ORng7JCFop4M88U/dV0KPdC5fVKghk+OsgH3sG7pVlqjwcbb0Esn0tqwpN6vKkqneID6L+dmfv1/HaBwaBPM+Rrxm4RKumAlwFT2U6oitWOQ+nyPTMqG4TcYiArX5OpAVXT+5RcEDeVHRYTN5fbZkuwgsW3CaLoVyPhEEMq8PN/CaQxfwPalwbDeXJNqfz0d5h+USbn9a4nbaY34kfytW90l03cA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZICmTGVYE3R2Oh7eZQHC56GR45tyNfodhlp1AkrmuDs=; b=iTRX4CHiLDS9U7BlqVZeXVyFLEQN9J1mTO5rwCMstDV/J1vft6JhzZct91BdcQXlN3bqOiIEPcqkkqb7p1xjJf5FtB0BkPUTKLb9qsk3mSVUnSq//EErwtkFiW74FF+tDI86M2F5AGBMU7ydU24AqFs6r8F11j90QFiCs+7dZ9DDVb4tv4jnZKZEeJ1NVhTHxT0JvncCv6t3V7h7DXb78Xbqp38OriHn2K4aCFZoJm6VVG3qwGgmzbLjXls3vRmPpCOvi5wFq1euxEAk8uiSDfbrpJJH8zn0F29tMs+IR6aMxMfHKAwgHyD42zw+2imnUMuIIrchqlUshj4GrimRlg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZICmTGVYE3R2Oh7eZQHC56GR45tyNfodhlp1AkrmuDs=; b=zTLobEP6sVFaa+fSgVmD5e3Hx3ardTQ54ohyu994OBXXaSZ5WOB3bVJC8PL/GpkP4+GzAGbi7T6TIxn90jM8aS+Xfgqtn6+ZdvB0N9pvASiaPnF34NwOGPunPJlre8DviDRqkYMYa8etsEht7kIJ1laakBZVMZVhubfqytjAW1E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZUcKlkucTl71J1HIxUa7TSW0sFbMyAToGuWV5aNUJ3oTHtXpiCJyYmPIGXwxCmJKkQIF6DZ+I/knmxU4O2UmpKsceaBHY0LTNvYHf61NLdXnH8YGAz4tN+boLX2b0WqAXS6vrWOCXwPcBECIR1QD1VE8irIcpU2COxyAO53ZrOmNV1qimoxkJW73Cm4qjiHIOtcgWbdty426fXbx+42Lc7VjNrTfoBMpL1ETXwi2AS2bnvbJgikhT88NG+G63yoVwYApRbWYhlMFfwPTzL1BfZ+O4vHPfrRKvGI5/aQzchY7xU3IomCn5DRR93rdjV63AFXbdAH2rd9mv8X6+RJfXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZICmTGVYE3R2Oh7eZQHC56GR45tyNfodhlp1AkrmuDs=; b=Ams14O1KBWqcmPX5XHoTdUXm05Dd/S5YRiFhXYuKOmZURvAvGru8agk9b+PHs1uXnUacgbvrMU7hqDsBt9lT8EXOuQ78tgAuLviY+qt1FknLlXNLoSAvAuI4W/K2qsf6C4aQUWwuPWAp883i9FqGZoNCDnKoJIGbM24t2me1TOWHwbIYE9g9idTFZOUPsWDiXbBUAwEOB22i4JjJz7UfowCnUc38gb845bh0M05JvoxH9jbNZFMQQl6CSJB8g+MlYVg6K13vFkejlK1xHYbe0UGTNpGk8pXwHxnpCE1GnLMWPAS72l7r2DsaoCteF86RxB4VWSuRS1JQ6jUBpLOgzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZICmTGVYE3R2Oh7eZQHC56GR45tyNfodhlp1AkrmuDs=; b=zTLobEP6sVFaa+fSgVmD5e3Hx3ardTQ54ohyu994OBXXaSZ5WOB3bVJC8PL/GpkP4+GzAGbi7T6TIxn90jM8aS+Xfgqtn6+ZdvB0N9pvASiaPnF34NwOGPunPJlre8DviDRqkYMYa8etsEht7kIJ1laakBZVMZVhubfqytjAW1E= From: Wei Chen To: Wei Chen , Julien Grall , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: RE: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build Thread-Topic: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build Thread-Index: AQHY8DVmEdLqaRCRCUuW0jNzr25ema4yQiqAgAIMi/CAAALrkA== Date: Tue, 8 Nov 2022 02:24:18 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-3-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B0852FDD17EE5E4CA0FDD3A8311E4C4E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|VE1PR08MB5821:EE_|AM7EUR03FT026:EE_|GV1PR08MB8153:EE_ X-MS-Office365-Filtering-Correlation-Id: b7ca3a50-2cb1-4d76-8b2e-08dac1305ee7 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: O4HaEIiLQt7RY2DIhlvl7oQTyHzRHTcq4lWFTjDukKXj02Pm7esHk/VBZirsYCWNCxCgJ213EgS02EP1fwHjmVr2WyQ0bYwfzKFjwNY/ckWFVypw6GqLdzJ9TTy07hTILV6nK9dN7NHy+9iZP9MVmgEqWsTzKHh+gwp5plQj2BdJMRwXHjp7unpBrALCvc/6jREGGbFCgVlGDaf2yLpQeWrlGwZj7e2g0DMwVbiIaIJ1rIEyaVWg/btE4THNJFI7/9FFMna3yGTt/nPVB4UaXsayoE16T5i3Faxv81WY/411F5lMY+kydevN9hBFZ/yRwGQRikRjhBPt6sKYbcIgcK0p+sUYvoxgG/zv/a/Z5ioSfelujzgjfPLjUrgGx3wmU8ICzrqx6lzjI5p9yB8ofptsaKufnaLmgVwbjw+uDmt+uop8bDyE8yzB9KScam77YWx0Hlcwm0ZidBFyxj3n9pJsj9PNE769mDSX6w1aF4gL57Ayj+2la/bBfNI1SVwALXsRA2k3DFKp52EWn81hpaFDHMRh58tSLnjm1bNutXMoHnEKP+JoJVm/ELgNrF2kCM7AoDmXadOIuYxh+BEw7KjfGB5Up946PoMIpgLfwRY1a0DJc2LbkX+Dn/C31dnd75YZp0aAFPnBvkIgetqzLpxuVRJwz/vydZrWyzwjtkUVbhk3K186vB/dwjcxYH7C3PoushtIt0mVj0w6Zwpa6z3MEbubvVkGQIzc0AFrSvyQgQvrskGz//KoCjjAeWl14FjZE100lL6/EOAGGwviSA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(346002)(376002)(39860400002)(451199015)(52536014)(5660300002)(8936002)(122000001)(6506007)(7696005)(71200400001)(55016003)(64756008)(66476007)(76116006)(66946007)(66446008)(66556008)(4326008)(8676002)(38100700002)(54906003)(316002)(110136005)(33656002)(38070700005)(86362001)(41300700001)(9686003)(2906002)(186003)(26005)(478600001)(2940100002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5821 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8a706e75-5b2c-4c69-6c88-08dac1305701 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rDEoewk6niIfVfMFzlG2LCG0BMYTFlU5pktYUKebPvWjA3OSnyE9ghASPJBbw/nFwBGceI13IkYfIch/iEoicSfI4HeMMqkvuLU1BgdQqYLU+FYJDp5MwKDECqbm2TznRqmKh5XkCSjADqGAc+HfasxX0GGuLrHo3fiI1pCyN77qCfGnUFUD5QMM7ccfw3IlAPHFLi7i6LoBp1s5v9UR0coJ6SssD47XcF9Gw4QpCKTLb1RMYZON/Y5jFiRrlYWh1w3CLc6KfNlZ5i0NJ4f+du3+Z2z8DXzLKoNO1XR1/eFJxvsBOmmjYfxPrUguQIvJL3VLWZbC1afqluRvHy7GqdGrO+KHs7K9MDlsFK1a5/4YqdRRHp0BMIlN/eIUFhR02GEoX6g8fCBNZ6pREAg05UiYdHrxSbC+meJ2UczyPKVL8cJlDh7NqRDaJhbwMi4r6DkVpRlY/7+nflpgo/3MsSDxTO0MoaB4XnKrg9ucUS5r/+cpS4RN/uU3RsUpAU9/HScauLGAdX/Jk6UFhTGiv5UQSduRzvx2h1zhC2fOvyqjyIsHdyWO/+ijtagLjcaf34oHPxNsL1yZBveOkjmWUktSnS5xim+3EiXGcBNWU+g0SitJ3IOHTBxxvoFwzJbfz/K2dAaDctU0tfRThMXG5awFoB7Vggj79GXCGgKFH7LC2qjaGWJKOGPjIIMuJKDi1fdbDt/GqYxSvkbHAlXfr9Mv6nFy8YHcCv2YGNqGOvhY+/WLyE6IHIGshllYs2wnkcnQVll8S0Y3CXhaNSsUOw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(376002)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(47076005)(336012)(26005)(186003)(9686003)(2940100002)(6506007)(36860700001)(7696005)(40460700003)(2906002)(55016003)(40480700001)(82310400005)(8676002)(8936002)(110136005)(54906003)(478600001)(5660300002)(52536014)(41300700001)(316002)(70586007)(70206006)(4326008)(33656002)(82740400003)(356005)(86362001)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 02:24:32.0545 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b7ca3a50-2cb1-4d76-8b2e-08dac1305ee7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8153 PiA+ID4gICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspDQo+ID4gPg0KPiA+ID4gZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyBiL3hlbi9hcmNoL2FybS9kb21h aW5fYnVpbGQuYw0KPiA+ID4gaW5kZXggNGZiNWMyMGIxMy4uYmQzMGQzNzk4YyAxMDA2NDQNCj4g PiA+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+ID4gKysrIGIveGVuL2Fy Y2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ID4gPiBAQCAtMzQxOCw2ICszNDE4LDggQEAgc3RhdGlj IHZvaWQgX19pbml0IGluaXRyZF9sb2FkKHN0cnVjdA0KPiBrZXJuZWxfaW5mbw0KPiA+ICpraW5m bykNCj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW5p dHJkLCBsZW4pOw0KPiA+ID4gICAgICAgaWYgKCByZXMgIT0gMCApDQo+ID4gPiAgICAgICAgICAg cGFuaWMoIlVuYWJsZSB0byBjb3B5IHRoZSBpbml0cmQgaW4gdGhlIGh3ZG9tIG1lbW9yeVxuIik7 DQo+ID4gPiArDQo+ID4gPiArICAgIGlvdW5tYXAoaW5pdHJkKTsNCj4gPg0KPiA+IFRoaXMgbG9v a3MgZ29vZCB0byBtZS4gQnV0IEkgYW0gd29uZGVyaW5nIHdoZXRoZXIgdXNpbmcgaW9yZW1hcF93 YygpIGlzDQo+ID4gYWN0dWFsbHkgY29ycmVjdCBiZWNhdXNlIHdlIGFyZSByZWFkaW5nIHRoZSBy ZWdpb24uIFNvIGl0IHNlZW1zIHN0cmFuZw0KPiA+IHRvIG1hcCBpdCB3aXRoIHdyaXRlLWNvbWJp bmUuDQo+ID4NCj4gPiBTbyBJIHdvdWxkIGNvbnNpZGVyIHRvIHVzZSBpb3JlbWFwX2NhY2hlKCku IFRoYXQgc2FpZCwgdGhpcyB3b3VsZCBiZSBhDQo+ID4gc2VwYXJhdGUgcGF0Y2guDQo+ID4NCj4g DQo+IE9rLCB3ZSB3aWxsIHRyeSB0byB1c2UgaW9yZW1hcF9jYWNoZSBhbmQgdGVzdCBpdC4gSWYg ZXZlcnl0aGluZyB3b3Jrcw0KPiB3ZWxsIHdlIHdpbGwgaW50cm9kdWNlIGEgc2VwYXJhdGUgcGF0 Y2ggaW4gbmV4dCB2ZXJzaW9uLg0KPiANCg0KT3IgaXMgaXQgYmV0dGVyIHRvIHNlbmQgYSBzZXBh cmF0ZSBwYXRjaCBmb3IgdGhpcz8gQmVjYXVzZSBJIHRoaW5rIHdlDQptaWdodCBuZWVkIHNvbWV0 aGluZyB0byBhZGRyZXNzIHRoZSB2MSBjb21tZW50cy4NCg0KQ2hlZXJzLA0KV2VpIENoZW4NCg0K PiBDaGVlcnMsDQo+IFdlaSBDaGVuDQo+IA0KPiANCj4gPiBJIHRoaW5rIHRoaXMgd2FudHMgdG8g YmUgaW4gNC4xNy4gVGhpcyB3aWxsIGF2b2lkIFhlbiB0byBoYXZlIHR3bw0KPiA+IG1hcHBpbmdz IHdpdGggZGlmZmVyZW50IGNhY2hpbmcgYXR0cmlidXRlIChpbml0cmQgaXMgcGFydCBvZiB0aGUg UkFNIGFuZA0KPiA+IHRoZXJlZm9yZSBkaXJlY3RtYXApLg0KPiA+DQo+ID4gQ2hlZXJzLA0KPiA+ DQo+ID4gLS0NCj4gPiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Tue Nov 08 02:36:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 02:36:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439686.693720 (Exim 4.92) (envelope-from ) id 1osETM-0007Bc-Qe; Tue, 08 Nov 2022 02:36:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439686.693720; Tue, 08 Nov 2022 02:36:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osETM-0007BU-Lt; Tue, 08 Nov 2022 02:36:20 +0000 Received: by outflank-mailman (input) for mailman id 439686; Tue, 08 Nov 2022 02:36:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osETK-0007BK-HA; Tue, 08 Nov 2022 02:36:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osETK-0007zE-EM; Tue, 08 Nov 2022 02:36:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osETJ-0008EJ-So; Tue, 08 Nov 2022 02:36:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osETJ-00085e-QY; Tue, 08 Nov 2022 02:36:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5B7lWH78hKTTncvAfYnaryFdG8ck+xbhn8AqeDxTzBk=; b=SN91X+We+8slZUSoOSZAvsngBK w+zyX8gJckjcO1a0zmcpCuZS3AnrmDssaqyyUEn7iQcpcddZfp/nZXHjmPpHqaeXgZZV438b68rr/ OPPs1Wd2CgIseEjghx4cK6p7UhfBy8UgpR2Y2e1elyWdDnqQNM2hfMAT/0ENz21Kvm5w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174659: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f0c4d9fc9cc9462659728d168387191387e903cc X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 08 Nov 2022 02:36:17 +0000 flight 174659 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174659/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux f0c4d9fc9cc9462659728d168387191387e903cc baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 31 days Failing since 173470 2022-10-08 06:21:34 Z 30 days 49 attempts Testing same since 174654 2022-11-07 03:45:58 Z 0 days 2 attempts ------------------------------------------------------------ 1598 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 152447 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Nov 08 03:02:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 03:02:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439696.693731 (Exim 4.92) (envelope-from ) id 1osEsK-0002Sp-Qw; Tue, 08 Nov 2022 03:02:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439696.693731; Tue, 08 Nov 2022 03:02:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osEsK-0002Si-O8; Tue, 08 Nov 2022 03:02:08 +0000 Received: by outflank-mailman (input) for mailman id 439696; Tue, 08 Nov 2022 03:02:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osEsJ-0002Sc-Bn for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 03:02:07 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140078.outbound.protection.outlook.com [40.107.14.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b9d9d2a3-5f11-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 04:02:06 +0100 (CET) Received: from AS8PR04CA0136.eurprd04.prod.outlook.com (2603:10a6:20b:127::21) by DB9PR08MB9610.eurprd08.prod.outlook.com (2603:10a6:10:454::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 03:01:52 +0000 Received: from VI1EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:127:cafe::be) by AS8PR04CA0136.outlook.office365.com (2603:10a6:20b:127::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Tue, 8 Nov 2022 03:01:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT030.mail.protection.outlook.com (100.127.144.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 03:01:51 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Tue, 08 Nov 2022 03:01:51 +0000 Received: from 3578c3333cac.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F9D43F05-68E5-4344-9F67-3447DD530437.1; Tue, 08 Nov 2022 03:01:45 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3578c3333cac.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Nov 2022 03:01:45 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by PAWPR08MB9519.eurprd08.prod.outlook.com (2603:10a6:102:2f1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 03:01:42 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::461b:c1cb:368c:707e]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::461b:c1cb:368c:707e%5]) with mapi id 15.20.5813.011; Tue, 8 Nov 2022 03:01:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9d9d2a3-5f11-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=abvVDdCBzNImLoMZbpH2lfnJdn/w81V7aABMgNg5RatNeX/2qDGndF7p2JUqaPP3tT1ZyiUIdGOtXE7HlgRUuhUPjrgFncdqcbMcGz0rqVs+j1yA+TPmJDrCbNyuPzV9fyf9baNu/Uhsb+y/bJQQCF4YWtXsWTDqiVEHHIcx0HGQI7x2cpk8Ta5pRgYehK+ta0AfgkRu/Vkzg3YPaKHtHgQWSxKR57cFJCOueJdzh5LGA3/jY2CT9jdJCCygVuE1dFMp4JUtTKZaab/FilQSG7FuHNztCYnh71dBtCYoFGbTKbOejk8wdxijDoQzmv6IiRBHLfgwyCSSunGtU/R6bA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7jkLaB4R+FaIlTOUeDTc4Xb+ckoCt2cWhkOFAmxpWyk=; b=h8PNzZS2cALTb2TtazDfIqqCW/8/sjtGfwne/EfsEel4Bf84fSCIjS6HZ603sp0p7PEwXvck/tFKn96QMZX4LoGE+4AiZfD1gGQUAiAadC5F2pl5lr4cGCOeqSgi1/6DzEdO1r3/QHontbmN6Hv1NuEiXfJ/fNxA1dWMmiKnfbxV27n07Rzn2VS+GtusX1pf0jGR55AfovfhX2/u6I+LszYBIQtyd+EIxReExDReaPQ/3zaLkwgDA6VvuA8Wy/vHkMwAvVWoGM0YIMeuYsjMGv6oaCR8VucHGtCktEHXTudaH+Pjcq/UieMLFIx7ISSxVrW1dTa1hla05y8/kqLQoQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7jkLaB4R+FaIlTOUeDTc4Xb+ckoCt2cWhkOFAmxpWyk=; b=mfju1FBxZsXTxPYZfJZS22DtXnJfP43NfsnabXctPiAjBF16fo9/dDtLKAfADrZQKEV3d28tlDKCwEqI2GTW+L0fq2pw93Gx6LEkLjnlYrqMoKmX99nobPZA4f3cXAkDSYsoHVkXueAqrn6BbqLJv0FKOnVtaFert2V/9YFO11o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OLE7a1Q1o8BIu3bkB3S+iy1XULwJOT8VLQx4A4ug1L/1Gu2RczO2+sbnLiEaMBiCRILK1v/rOYD/rsUiiJknWYo0C8qSICB2BI7x84iw0fmVCpBfG3DMIzVfG0EeNW+XZYQ2vrAw46qZyHv9VKZaLqGyusGOqFJRcCM1aEwzPUDydZILTQKUdg0SkMJpBWrofZkPEQmGQbFRuo5BBumIaXkWFPNUF6H4A0NzXBLYg+3Pbzmen3vdnuUspBmz10R7aIl1pMQ2qKU69mAfR0OhevV1rA/zF10HoK5kgo1toIFCLD8u/lCj7EedHWJY0LuXppQDHax14ytO5LJ4NHBIIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7jkLaB4R+FaIlTOUeDTc4Xb+ckoCt2cWhkOFAmxpWyk=; b=QH3M1Gs/eCmmE9XwETB8mLnepwaxHSvqBUssa5UVGNDh3kpXYxoQi6RQossQG8k9bzF/Ecz6nBRvir6v4hpqXCY070EMxBDQ5YT6HMGUkGbyE48WbRffhAjG7QGxSM3s738Hwhq852Ua0g3yrs4a5Pmk2q4PEBSpjPoHeqpN78Z2EofOBS9ooVp1lOCjZ4VmFHuLAl503vsWAziH8Uv1AVvNYHz0fGRJCzUdZ4rp4zvuJakaHK0YF5RdfFIFgUWCB3HfI5QDmpdz6gwy82u3arMkQv9lnMpma97V228xbQIv44HJxfjhSPp9h0NuS+dOLs6yFmob7MMIOxQDZ5rV6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7jkLaB4R+FaIlTOUeDTc4Xb+ckoCt2cWhkOFAmxpWyk=; b=mfju1FBxZsXTxPYZfJZS22DtXnJfP43NfsnabXctPiAjBF16fo9/dDtLKAfADrZQKEV3d28tlDKCwEqI2GTW+L0fq2pw93Gx6LEkLjnlYrqMoKmX99nobPZA4f3cXAkDSYsoHVkXueAqrn6BbqLJv0FKOnVtaFert2V/9YFO11o= From: Penny Zheng To: Julien Grall , Wei Chen , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 10/11] xen/arm64: introduce helpers for MPU enable/disable Thread-Topic: [PATCH v6 10/11] xen/arm64: introduce helpers for MPU enable/disable Thread-Index: AQHY8DVttaMHoZmFwkey/b3g/gof864yY/8AgADDtcCAACIBAIABDoXw Date: Tue, 8 Nov 2022 03:01:42 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-11-wei.chen@arm.com> <54d6e747-c791-c321-3c75-87613393d789@xen.org> <09e0dfa1-0167-a4b2-63cf-5cf8619fa417@xen.org> In-Reply-To: <09e0dfa1-0167-a4b2-63cf-5cf8619fa417@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 38D48341A1657F42BBEE45FAC726F389.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|PAWPR08MB9519:EE_|VI1EUR03FT030:EE_|DB9PR08MB9610:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c730682-be91-49c4-c0d1-08dac13595db x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: y3pQ+7k+hb8VjPka4awcvN5Iuho+EEon+0QiXoI0Pzgp5ze04TSjdnGFSUpdcawCIUPfhVUtONQBV+Eq2D1ZB0EkOs/xI9qwy4lVSA4so6rU4vPvKQUDLMw7zZ/4z8yhT4biHlkFHr12DwxV+K84c1GtGErPZN86BRIBrlrvGFB7f0UvAhPN7KH3xBFhJYSPiKRFWTxyXvcQsOqmFR8LBdasLeoay+KgXaMr/aLBuLUjZTF79tovSgct2/uu/bqqZGxfhmefhcy8jZf7slJcw4c161hb29x+iecKKkN4+8rFfoqa2Q0/e3R2blkdIljeShgr23GRph3kfL95DW28ZmPMiZWcezcGLfqt4hmysJCBEK9JASzr3ErIO8Wj49iJvT2Takb4KlmW05Ld+P/bNJquRG5ngD0p6/Mp1nu9klmCDStTUVS1FfbDqgNgOxRuNFokjQDtN5DBOFcbtyED5imUllKp6QPIkfL6BCujzx8ggOm77SX+3oBiGleFwMODQu84oP1rpm19TYuvVDFz5qcxFImRcob1NOydYjuzqyPMoT5WDP//q8MHxEUTUWcec5JGfS9MCKr6+jyeEtcyn7iY4w6DCO6yPoH5+tm8SAAJTOZOPe9C5aTTm7MCAcZ0xCaKx6zcMBDQuZoNSqtgHH53InJJMAdeCNd1OGj1t2DmEIcjUhLgDUgq+iOTMXvqlC2hA8hnT8/1w2MtgU6S/8nX6fOvqwHRZMkllmj/lGSbsTuUl6qHfwTCcLOULccIkPsVa2tXcBVL425/W/juPg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(346002)(39860400002)(366004)(451199015)(33656002)(86362001)(38070700005)(66476007)(6506007)(55016003)(2906002)(9686003)(186003)(26005)(53546011)(122000001)(83380400001)(7696005)(66446008)(66946007)(66556008)(8676002)(4326008)(54906003)(316002)(64756008)(110136005)(52536014)(478600001)(76116006)(8936002)(71200400001)(41300700001)(38100700002)(5660300002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9519 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 795fb82a-a2d2-46be-d7a4-08dac135905a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RkZzWX3B1frnclZg7d9u8fMdZHbk8+bRPGph/0VTCQctqf8QWZL4liOJIz5KvsNRO5mBIzoUdp9fGaAgEopO3LsRyfpGWgnE7D5Y3ZFHIj7460HeN09fxhdEbjjJDCrgF/iFXoFIwMmvJewc2tZY7+bvWcTT1rtBLR5ZRnG7fvrECQWwHT26uan8lQ5kp6dEyMNHeeZvLfix50Qo4Numykoz8o93mM/+crfoPND7z8ETFt12xUa3WOJxiTy+w2U+aDW6nJ0OBJSjdC20U26e41q31rkxZ2pJ9fCtSv6KXVHiqULC/rTr2ca4aM2BoCvlzy+iHymyFIx/3j3jkm40pM9tVbfZFATRTFgAntEVZ+VJU1VeSm7UWdnxTfWI+lMhf2NmWupdSx+/tkbBubUcLlxW7mtxzEBwrPRfKrMXPklP/bSWIMgRpMVOXqx6sIwfT+zbUPVu/C7WxJKuAZfUI27CAHSGmT1JerrcbGi5O+bwvfFxkcYnGYW+Ky3LplkSSq469m90kgPVMw32BUcSnQnbllJ6/tOtKFMBiuDdNY25DIV5eOu+EwXyBcUcbjhNMpRFeHHGGY5YFd5S3NlvG19DI76cmEr0PzFiXmurXP/QuQhfSvAXZbqXl/YRcYxKj/5TtaueXPtUHXWsGgbrCVSHZTvyEG8wp0ImRFNxxgAHw+jndF/bHpm1l5eHnCnc4s46bZvgR/ikxnYV0sMvAj9/U2FEELQK/bTWzZDilm/+rr9l3129X8gzVjXUgLzRLOwf7xkyN6eXqI5FUWImmg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(376002)(396003)(451199015)(40470700004)(36840700001)(46966006)(110136005)(107886003)(54906003)(6506007)(7696005)(316002)(26005)(70586007)(9686003)(70206006)(8676002)(53546011)(4326008)(478600001)(336012)(2906002)(47076005)(5660300002)(86362001)(33656002)(8936002)(52536014)(41300700001)(83380400001)(82740400003)(36860700001)(81166007)(356005)(40460700003)(186003)(82310400005)(55016003)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 03:01:51.6418 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c730682-be91-49c4-c0d1-08dac13595db X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9610 DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4NCj4gU2VudDogTW9uZGF5LCBOb3ZlbWJlciA3LCAyMDIyIDY6MzggUE0N Cj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgV2VpIENoZW4NCj4gPFdl aS5DaGVuQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gQ2M6IG5k IDxuZEBhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3Jn PjsgQmVydHJhbmQNCj4gTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgVm9sb2R5 bXlyIEJhYmNodWsNCj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPiBTdWJqZWN0OiBS ZTogW1BBVENIIHY2IDEwLzExXSB4ZW4vYXJtNjQ6IGludHJvZHVjZSBoZWxwZXJzIGZvciBNUFUN Cj4gZW5hYmxlL2Rpc2FibGUNCj4gDQo+IA0KPiANCj4gT24gMDcvMTEvMjAyMiAwOTo1NywgUGVu bnkgWmhlbmcgd3JvdGU6DQo+ID4gSGkgSnVsaWVuDQo+IA0KPiBIaSBQZW5ueSwNCg0KSGkgSnVs aWVuDQoNCj4gDQo+ID4NCj4gPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJv bTogWGVuLWRldmVsIDx4ZW4tZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24g QmVoYWxmIE9mDQo+ID4+IEp1bGllbiBHcmFsbA0KPiA+PiBTZW50OiBNb25kYXksIE5vdmVtYmVy IDcsIDIwMjIgNDo1NiBBTQ0KPiA+PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyB4 ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gPj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsg UGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+OyBTdGVmYW5vDQo+ID4+IFN0YWJlbGxp bmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzDQo+ID4+IDxCZXJ0 cmFuZC5NYXJxdWlzQGFybS5jb20+OyBWb2xvZHlteXIgQmFiY2h1aw0KPiA+PiA8Vm9sb2R5bXly X0JhYmNodWtAZXBhbS5jb20+DQo+ID4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjYgMTAvMTFdIHhl bi9hcm02NDogaW50cm9kdWNlIGhlbHBlcnMgZm9yIE1QVQ0KPiA+PiBlbmFibGUvZGlzYWJsZQ0K PiA+Pg0KPiA+PiBIaSBXZWksDQo+ID4+DQo+ID4+IE9uIDA0LzExLzIwMjIgMTA6MDcsIFdlaSBD aGVuIHdyb3RlOg0KPiA+Pj4gRnJvbTogUGVubnkgWmhlbmcgPHBlbm55LnpoZW5nQGFybS5jb20+ DQo+ID4+Pg0KPiA+Pj4gV2UgbmVlZCBzb21lIGhlbHBlcnMgZm9yIFhlbiB0byBlbmFibGUvZGlz YWJsZSBNUFUgaW4gYm9vdC10aW1lIGFuZA0KPiA+Pj4gcnVudGltZS4gRm9yIE1QVSBlbmFibGUg aGVscGVyLCB3ZSBrbm93IHRoYXQgaXQncyBhbiBlc3NlbnRpYWwNCj4gPj4+IHJlcXVpcmVtZW50 IG9mIE1QVSBzeXN0ZW0uIEJ1dCBmb3IgTVBVIGRpc2FibGUsIHdlIG5lZWQgdG8gdXNlIGl0DQo+ ID4+PiBmb3Igc29tZSBzcGVjaWFsIHNpdHVhdGlvbnMuIEZvciBleGFtcGxlLCBpbiB0aGUgcHJv Z3Jlc3Mgb2YNCj4gPj4+IHRyYW5mZXJyaW5nIGZyb20gYm9vdC10aW1lIHRvIHJ1bnRpbWUsIHdl IG5lZWQgdG8gdXBkYXRlIHRoZSBNUFUNCj4gPj4+IHByb3RlY3Rpb24gcmVnaW9ucyBjb25maWd1 cmF0aW9uLCBidXQgd2UgY2FuJ3QgbW9kaWZ5IGFuIE1QVQ0KPiA+Pj4gcHJvdGVjdGlvbiByZWdp b24gaWYgdGhlcmUgaXMgc29tZSBkYXRhIGFjY2Vzc2VkIGJ5IFhlbi4gQnV0IGluDQo+ID4+PiBi b290LXRpbWUgYWxsIG9mIFhlbiB0ZXh0LCBkYXRhIGFuZCBCU1MgYXJlIGluIG9uZSBNUFUgcHJv dGVjdGlvbg0KPiA+Pj4gcmVnaW9uLCBpZiBYZW4gd2FudCB0byB1cGRhdGUgdGhpcyBwcm90ZWN0 aW9uIHJlZ2lvbiwgYWJvdmUgcmVzdHJpY3Rpb24gd2lsbA0KPiBiZSB0cmlnZ2VyZWQuDQo+ID4+ DQo+ID4+IFRoaXMgcmFpc2VzIHRoZSBmb2xsb3dpbmcgcXVlc3Rpb246IFdoeSBjYW4ndCB3ZSBj cmVhdGUgdGhlIHNwbGl0DQo+ID4+IHJlZ2lvbnMgcmlnaHQgbm93Pw0KPiA+Pg0KPiA+DQo+ID4g VGhlIHJlYXNvbiB3aHkgd2UgYXJlIG5vdCBjcmVhdGluZyB0aGUgc3BsaXQgcmVnaW9ucyByaWdo dCBub3cgaXMgdGhhdA0KPiA+IHdlIGFyZSB0cnlpbmcgdG8gZ28gdGhlIHNhbWUgcGF0aCBNTVUg Z29lcy4NCj4gDQo+IFRoZSBNTVUgY29kZSBpcyBnb2luZyB0byBjaGFuZ2UgcHJldHR5IHNvb24g KHNlZSBbMV0gZm9yIHNvbWUgZ3JvdW5kDQo+IHdvcmspLiBUaGUgcnVudGltZSBwYWdlLXRhYmxl cyBmb3IgQ1BVMCB3aWxsIGJlIGNyZWF0ZWQgaW4gYXNzZW1ibHkgY29kZQ0KPiBhbmQgbmV2ZXIg c3dpdGNoZWQgYWZ0ZXIgKGFzaWRlIHdoZW4gdXNpbmcgY2FjaGUgY29sb3JpbmcpLg0KPiANCj4g QWx0aG91Z2gsIEkgZG9uJ3QgdGhpbmsgSSB3aWxsIGFwcGx5IHRoZSBwcm9wZXIgcGVybWlzc2lv bnMgaW4gYXNzZW1ibHkgKHRoaXMgaXMNCj4gYSBiaXQgdHJpY2tpZXIgdGhhbiB3aXRoIHRoZSBN UFUpLg0KPiANCj4gPiBUaGVuIHdlIGNvdWxkIHJldXNlIGFzIG11Y2gNCj4gPiBzYW1lIGludGVy ZmFjZXMgYXMgd2UgY291bGQsIGluIG9yZGVyIHRvIG5vdCBsZWF2ZSAjaWZkZWYNCj4gPiBDT05G SUdfSEFTX01QVSBhbGwgb3ZlciB0aGUgcGxhY2UuDQo+IERvIHlvdSBoYXZlIGEgbGlzdCBvZiB0 aG9zZSBpbnRlcmZhY2VzIHRoYXQgd291bGQgcmVxdWlyZSAjaWZkZWY/DQo+IA0KPiA+DQo+ID4+ IEluIHBhcnRpY3VsYXIsIGRpc2FibGluZyB0aGUgTU1VL0NhY2hlIGlzIGZhaXJseSByaXNreSBi ZWNhdXNlIHlvdQ0KPiA+PiBuZWVkIHRvIGVuc3VyZSB0aGF0IGFueXRoaW5nIGluIHRoZSBjYWNo ZSB5b3UgY2FyZSBhYm91dCBoYXZlIGJlZW4NCj4gPj4gd3JpdHRlbiBiYWNrIHRvIHRoZSBSQU0p Lg0KPiA+Pg0KPiA+DQo+ID4gSG9wZSBJIGNvdWxkIHVuZGVyc3RhbmQgeW91ciBjb25jZXJuIHRv dGFsbHksIHlvdSBhcmUgd29ycnlpbmcgYWJvdXQNCj4gPiBzdGFsZSBpbmZvIGxlZnQgaW4gdGhl IGNhY2hlLCBldmVuIGlmIGl0J3MgYWx3YXlzIDE6MSBtYXBwaW5nIG9uIHRoZQ0KPiA+IE1QVSBz eXN0ZW0sIG1lbW9yeSBhdHRyaWJ1dGVzIGNvdWxkIGJlIGRpZmZlcmVudCBiZWZvcmUgYW5kIGFm dGVyPw0KPiANCj4gTm8uIEkgYW0gbW9yZSBjb25jZXJuZWQgYWJvdXQuLi4NCj4gDQo+ID4gU28g aXQgaXMgbmV2ZXIgZW5vdWdoIHRoYXQgd2Ugb25seSBmbHVzaCB0aGUgdmFyaWFibGVzIHdoaWNo IHdlIHdpbGwNCj4gPiB1c2UgZHVyaW5nIHRoZSBkaXNhYmxpbmcgdGltZSwgaXQgc2hvdWxkIGJl IGV2ZXJ5dGhpbmcgaW4gdGhlDQo+ID4gY2FjaGUuLi46Lw0KPiANCj4gLi4uIHRoaXMuIFdlIGRv bid0IG9ubHkgbmVlZCB0byBmbHVzaCBiZWZvcmUgdGhleSBhcmUgYWNjZXNzZWQgYnV0IGFsc28g YWZ0ZXIgaWYNCj4gdGhleSBhcmUgbW9kaWZpZWQuDQo+IA0KPiBJdCBpcyBwb3NzaWJsZSB0byBk byBpdCBjb3JyZWN0bHksIGJ1dCBpdCByZXF1aXJlcyB0byBiZSB2ZXJ5IGNhcmVmdWwuDQo+IFNv IGlmIHdlIGNhbiBhdm9pZCBkaXNhYmxpbmcgdGhlIGNhY2hlL01QVSB0aGVuIGl0IHdpbGwgYmUg YSBsb3QgYmV0dGVyLg0KPiANCj4gPg0KPiA+IFNpbmNlIGluIGN1cnJlbnQgZGVzaWduLCB0aGVy ZSBhcmUgdHdvIHRpbWUgcG9pbnRzIGluIGJvb3QgdGltZSB3aGVyZQ0KPiA+IHdlIHdpbGwgZGlz YWJsZSBNUFUvQ2FjaGUgdG8gY29uZmlndXJlIE1QVS4NCj4gPg0KPiA+IE9uZSBpcyBpbiBzZXR1 cF9tbSwgaGVyZSwgd2Ugd2lsbCBtYXAgWEVOIGNvbXBvbmVudHMgYnkgY29tcG9uZW50cywNCj4g PiBlYWNoIE1QVSBtZW1vcnkgcmVnaW9uIGZvciBhIGRpZmZlcmVudCBjb21wb25lbnQuDQo+ID4g VGhlIG90aGVyIGlzIG5lYXIgdGhlIGVuZCBvZiBib290IHRpbWUsIHdlIHdpbGwgcmVvcmcgdGhl IHdob2xlIE1QVQ0KPiA+IG1lbW9yeSByZWdpb24gbGF5b3V0IGJlZm9yZSBnb2luZyBydW50aW1l LCBhbmQgd2Ugd2lsbCBrZWVwIHVuY2hhbmdpbmcNCj4gcmVnaW9ucyBpbiB0aGUgZnJvbnQgYW5k IGZsZXhpYmxlIG9uZXMgaW4gdGhlIHJlYXIuDQo+IA0KPiBZb3Ugc2hvdWxkIG5vdCBuZWVkIGFu eSByZW9yZyBpZiB5b3UgbWFwIHRoZSBib290LW9ubHkgc2VjdGlvbiB0b3dhcmRzIGluDQo+IHRo ZSBoaWdoZXIgc2xvdCBpbmRleCAob3IganVzdCBhZnRlciB0aGUgZml4ZWQgb25lcykuDQo+IA0K DQoiaW4gdGhlIGhpZ2hlciBzbG90IGluZGV4IiBpcyByZWFsbHkgc2hpbmluZyBhIGxpZ2h0IGlu IG15IG1pbmQgOykgQW5kIEknbGwgdHJ5IHRvIGVuYWJsZSBpdA0KaW4gdjIuDQoNCj4gQ2hlZXJz LA0KPiANCj4gWzFdIDIwMjIxMDIyMTUwNDIyLjE3NzA3LTEtanVsaWVuQHhlbi5vcmcNCj4gDQo+ IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Tue Nov 08 03:03:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 03:03:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439702.693742 (Exim 4.92) (envelope-from ) id 1osEtT-000331-81; Tue, 08 Nov 2022 03:03:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439702.693742; Tue, 08 Nov 2022 03:03:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osEtT-00032u-5H; Tue, 08 Nov 2022 03:03:19 +0000 Received: by outflank-mailman (input) for mailman id 439702; Tue, 08 Nov 2022 03:03:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osEtS-0002pA-6T for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 03:03:18 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20062.outbound.protection.outlook.com [40.107.2.62]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e41b59d1-5f11-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 04:03:16 +0100 (CET) Received: from FR0P281CA0128.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::10) by PAVPR08MB9436.eurprd08.prod.outlook.com (2603:10a6:102:316::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 03:03:12 +0000 Received: from VI1EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:97:cafe::71) by FR0P281CA0128.outlook.office365.com (2603:10a6:d10:97::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Tue, 8 Nov 2022 03:03:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT005.mail.protection.outlook.com (100.127.144.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 03:03:12 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Tue, 08 Nov 2022 03:03:12 +0000 Received: from c0939d50d670.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B81613AF-A060-4089-9D11-875BD7790A3D.1; Tue, 08 Nov 2022 03:03:01 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c0939d50d670.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Nov 2022 03:03:01 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AS2PR08MB8645.eurprd08.prod.outlook.com (2603:10a6:20b:55c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 03:02:59 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5813.011; Tue, 8 Nov 2022 03:02:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e41b59d1-5f11-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ZRnlx7fKLE+ISrKjV2v5gI7fuee0byriiohCpNoaPgJbh4kpRYlTnFcMvwAqX0jHgkojCtzOsEPLZ+51OgB6YyNQ7fUEINiTEtHbstGtDUffOS0e3fmm79zWzTCag6j0Zv89Qu+y1MdrhStOshs+TQvl4fnj8/8PzNvRN/QKpTP4J48K5bDHpYTkLsQGK8UxuQJ0EYo76C7QziMOPDrperpG8xjXSoqh5fR7+zGIxIhoFsNKHFQXf9pAI3C8Gixamjj4OWyuklOGGcANn9RTG2yzw6wyejpc4l8d51j/jtu9Ivm+UBGUGN6FImSbXVS0yRZPqgyJWGY+ojw75CZW5w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=STeUKApHJS6WR6W/DZRdXQ90R5pmFtOSHxb0g5mnbDA=; b=Iq70/eqtcc/kMtuTldkUH/59cJSY/RMvSA/xglPhQi0G3D8XKEDMvUiw3ORFTt5VakEuv46oAVWk5qvjTokcEqzBHysZKQ/UpKB3tP8+Oxr1xbI0jaDTG2M7UKVaiVnB55Gxs7kVNXOHrfZDm9oY49A+Z6eMgj4HF7cspTjR/DLpflw4nhDKrkh009cW+CFh63BpgJuH91rSq/lYtusvlFYh8K4egr95TXKothOdvT16TJ25ckL1Mi0ZS89O7FETMsUeyFVWJko3ttXjAHZaRJYaWUhg1ccsj1NgARfGO/PpD249AYGV1bK3Ja3zeTJtGfZ1w3BRiTKQI/jMCdfDMQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=STeUKApHJS6WR6W/DZRdXQ90R5pmFtOSHxb0g5mnbDA=; b=VlRnbK6yzlj3V1jz6bl2huwniWg5xTLW/Bt8zS4e3bsxNaBL/WLgnlBc6Z2ico1eRlzotP8CgNdN1v7a4EdFfQ89RRD5XK0tdmqTQEvhGstYKUZWybe4tcIOgQ6dtFBhZ2xPo1jhEATta8sAGVHdmBar1k9gWwLEEAeK0KvMlCA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e9/uACBT/aCt8rZNXyQylrdIZ81ckOhKZmKL86scQFE3ewU2hMg6QtrIPfySX+HvreBhF125PXtYXRdyjiPWvUmF2DF5he92/OZnddzmZ+eUGn30LelazhzzeCri54POGHD0rjGTtf2HkYu+rvh3mwHFUAnrtjaKzrQf4vOqA+3bOVb0IeK0PfFa03RVmuHjDN30TJb//OTYjgDUER8ia0hRV47vufr7xKLsx7vvyTWJ3KKGhqj6TcTJ1sfX/NG/iNAYo+JrolRVBwTPd/5vja6GclAO4nEELvZCOgByHumNZJV9q38akWXh4fiJkGxqs/Z9D9cMxDFAC7ylVT7Kow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=STeUKApHJS6WR6W/DZRdXQ90R5pmFtOSHxb0g5mnbDA=; b=LcQ9QkBP2/LXhq7RT/t0AqihrmimNuB9XY8rUGgconyxRhB7fiMY5vHjWDAki8+eeVtIq0aPNSbgi6P+tsdEqQeqe2jOCKDi6hosnjTeoUfAu9PlA6ann36kbfHWtnoj0yp3gEyBBjpO2EHCKii1PJcWm9e6XVPC59jH2g1BLRCS2LBjKdJ/T6QX0lthMtFe10Mhm+kz0ncXJkZVu/1E2sAN1X1X5/tvlNTmipRzMa5t6e6IFSQdPBli75B9VOT6+Y7KBuKkzSiTlXJE//mwaaepc3CSwWZuUKTTd1PITOvAm7crZWmZYCjB+nn+Ax5SG8dR462vAOX5GpCiTv/RAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=STeUKApHJS6WR6W/DZRdXQ90R5pmFtOSHxb0g5mnbDA=; b=VlRnbK6yzlj3V1jz6bl2huwniWg5xTLW/Bt8zS4e3bsxNaBL/WLgnlBc6Z2ico1eRlzotP8CgNdN1v7a4EdFfQ89RRD5XK0tdmqTQEvhGstYKUZWybe4tcIOgQ6dtFBhZ2xPo1jhEATta8sAGVHdmBar1k9gWwLEEAeK0KvMlCA= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 03/11] xen/arm: disable EFI boot services for MPU systems Thread-Topic: [PATCH v6 03/11] xen/arm: disable EFI boot services for MPU systems Thread-Index: AQHY8DVhHYvazJgosk2Tv3EbzhgfNq4yRv2AgAIMODA= Date: Tue, 8 Nov 2022 03:02:59 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-4-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 81F0F9946AEC4D45B07241E7D410921D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|AS2PR08MB8645:EE_|VI1EUR03FT005:EE_|PAVPR08MB9436:EE_ X-MS-Office365-Filtering-Correlation-Id: d16d2151-5884-4cce-a208-08dac135c605 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gWfSXY/QGeQgYhb+wWDoLR8kiI+MwuWNANCWUfkHSlEmncOvi6hagRj38BKOLaJ98QOg1DoH/r3cjONK7BYlcUBn9p0RXMD7ibLYDtQC3lEvXOue7VYZ1pp5XfXPXN/8wP25JrMQa4XkPa62DPx1SnQr9cbpghVmF/w095VcGFiwZjZWGnhdjKANJt+zD7PInGB1OvM39/+0OGi4ChHRUPiaYZz09M8ULM1BYgGc46UNeiD0mte0K0y0unkuvxXzTijS8ttKQ+LBXKtqHD+NiLQ5odUNbUpVTgtZaEvN/yXH1nSGJvVXmH1G9iKM6TqJacGCTfzy96jeSzr8flOF+F9p2H/goHMIoXtEpy4Kyer7y/iirkWl7yv51nuO32j0PLxYwKPaUpRp03hBwgX0DZztYd8pRssvQhget0k7xazL9cLfuwae49n1Mlx/BpAaegl1cVJIjOtyP10+We+CSURdC4C5xKoc8oGUFRamGbmLSrrv/TVBwoxziYX7xPnz9Z1M1NqnJNPvweqRSMKFzNP/s+xnBErEhypWlKRSmUkX7SJRLDiT1aUawOYUXGDxiQFC4Nr+9oqqVO2sEYVFPzs/gtkIGHYaumX4S8K21zI6QBlrU5Y8kKpLjum76MSoR82T0ctQLmEw7rh8emczqctvTGqSZV/qve1ZmX/b9D+s0THEEWJStB4AzkVMvirqRZ0oaKIGXr4kFeuJhbTx3krZmxkLCaEkvB7es6MXtLUolETqUKUxK7ZDTRJoUOSPsN6a6Vb8uUPwurPI9NQuBg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(366004)(346002)(376002)(136003)(451199015)(38070700005)(54906003)(38100700002)(86362001)(33656002)(2906002)(478600001)(71200400001)(53546011)(4326008)(66556008)(66946007)(316002)(8676002)(66446008)(76116006)(41300700001)(110136005)(52536014)(5660300002)(8936002)(66476007)(55016003)(6506007)(9686003)(122000001)(64756008)(83380400001)(186003)(7696005)(26005)(66899015);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8645 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fddad65b-c6b0-4367-d55f-08dac135be24 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c5QOXk7SHZ5ouENGd7XY3sb5tsrrXwok74wt0tsHgU/3iYyPCQ5v73ElzHwozwGqpLwW8aBpPFsv/ymAxUVODrrCx2VhGuATzcHsW3rtyYFSoPXQae6T63CtPUZBOFYA/UEBQy896wNrf75MmEDNoXIn+mUBwJSNWhla6EQ6AN/Pk1QKk0P4WhwQaNPktEmBK0kU8zmDXVB2P+OsF6XonGxFRvoPCIv4LTm5hNPxyGiN3cmwxDn5jmEC81VkQ4uoJbx+a3+yJoGSI+DuV5POr+XwJweGnrkPqE4wlvqXIH9l25QvTrg1kpsQ7S9lXSyJbVJI9g7rwp5xdh81f2BvqUhIbVJGZ9Z8yeOUW+rD/h/DtlRAfNyEfI7zz6TWPL1oXcoeA4+aM3xuB3TFyROGdWwJdB9aEkA4f42m9SITXfbhKKwQjRugue8a1XigEmzib6f/lYEKEyGrNc2wuaPfIcLE/+hm7wK1H3DLGvzbkrapmpslOU1fK0phRh9mWGTr9xjb6wEjENC1+R0d9loXvr3azca+JXo/pHXgZDieSqoE6eVUiCG096Lmrm9AT+FEq9nky7KC1rLLl+kKjedU9lKaowMady7HojqxTouyYFDFdy1J7IDBDOxX+mRNtbfEOyFMHL74/RE+wx3S24YjxBVWh92C5bYjQ9z+Iu9F3NAmLHbxpGkGXP3cOvst7suRqHB7+EJDs3KCWWa6KomV44f/GGdBHhRDtcKK9PD1aXR1s/K9yblyl4rp/JlzUq1Ui99kLZW72/aak/mrUrRuHw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(396003)(376002)(136003)(451199015)(46966006)(40470700004)(36840700001)(66899015)(33656002)(81166007)(86362001)(82740400003)(356005)(40460700003)(55016003)(40480700001)(2906002)(7696005)(47076005)(26005)(6506007)(107886003)(186003)(53546011)(336012)(83380400001)(36860700001)(70206006)(70586007)(8676002)(316002)(9686003)(478600001)(82310400005)(54906003)(110136005)(4326008)(8936002)(5660300002)(41300700001)(52536014);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 03:03:12.5094 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d16d2151-5884-4cce-a208-08dac135c605 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9436 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQxMeaciDfml6UgMzoxMg0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcNCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3Rh YmVsbGluaUBrZXJuZWwub3JnPjsgQmVydHJhbmQNCj4gTWFycXVpcyA8QmVydHJhbmQuTWFycXVp c0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0u Y29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHY2IDAzLzExXSB4ZW4vYXJtOiBkaXNhYmxlIEVG SSBib290IHNlcnZpY2VzIGZvciBNUFUNCj4gc3lzdGVtcw0KPiANCj4gSGkgV2VpLA0KPiANCj4g T24gMDQvMTEvMjAyMiAxMDowNywgV2VpIENoZW4gd3JvdGU6DQo+ID4gQ3VycmVudCBFRkkgYm9v dCBzZXJ2aWNlcyBzdXBwb3J0IG9mIEFybTY0IGNvdWxkIG5vdA0KPiA+IHdvcmsgd2VsbCBmb3Ig QXJtdjgtUjY0IHN5c3RlbSB0aGF0IG9ubHkgaGFzIE1QVSBpbg0KPiA+IEVMMi4gVGhhdCBpcyBi ZWNhdXNlIEVGSSBib290IHNlcnZpY2VzIG1heSBuZWVkIHNvbWUNCj4gPiByZWxvY2F0aW9uIHN1 cHBvcnQgb3IgcGFydGlhbCBQSUUvUElDIHN1cHBvcnQuDQo+IA0KPiBJIGFtIGEgYml0IGNvbmZ1 c2VkIHdpdGggYXJndW1lbnQuIFdlIGhhdmUgbm90aGluZyBpbiBYZW4gdG9kYXkgdG8gZGVhbA0K PiB3aXRoIHJlbG9jYXRpb24vcGFydGlhbCBQSUUvUElDIHN1cHBvcnQuIFNvIHdoYXQgaXMgdGhl IGV4YWN0IHByb2JsZW0/DQo+IElzIGl0IGJlY2F1c2UgVUVGSSBjYW4gbG9hZCBYZW4gYW55d3do ZXJlPw0KPiANCj4gPiBCdXQgdGhlc2Ugd2lsbCBub3QgYmUgc3VwcG9ydGVkIGluIHRoZSBpbml0 aWFsIHN0YWdlIG9mDQo+ID4gcG9ydGluZyBYZW4gdG8gTVBVIHN5c3RlbXMuIFNvIGluIHRoaXMg cGF0Y2gsIHdlDQo+ID4gZGlzYWJsZSBFRkkgYm9vdCBzZXJ2aWNlcyBzdXBwb3J0IGZvciBBcm0g TVBVIHN5c3RlbXMuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBXZWkgQ2hlbiA8d2VpLmNoZW5A YXJtLmNvbT4NCj4gPiAtLS0NCj4gPiAgIHhlbi9hcmNoL2FybS9LY29uZmlnICAgICAgfCAyICst DQo+ID4gICB4ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZC5TIHwgOCArKysrKystLQ0KPiA+ICAgMiBm aWxlcyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQo+ID4NCj4gPiBk aWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL0tjb25maWcgYi94ZW4vYXJjaC9hcm0vS2NvbmZpZw0K PiA+IGluZGV4IDFmZTVmYWY4NDcuLmFkNTkyMzY3YmQgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2Fy Y2gvYXJtL0tjb25maWcNCj4gPiArKysgYi94ZW4vYXJjaC9hcm0vS2NvbmZpZw0KPiA+IEBAIC03 LDcgKzcsNyBAQCBjb25maWcgQVJNXzY0DQo+ID4gICAJZGVmX2Jvb2wgeQ0KPiA+ICAgCWRlcGVu ZHMgb24gIUFSTV8zMg0KPiA+ICAgCXNlbGVjdCA2NEJJVA0KPiA+IC0Jc2VsZWN0IEFSTV9FRkkN Cj4gPiArCXNlbGVjdCBBUk1fRUZJIGlmICFIQVNfTVBVDQo+IA0KPiBJIHRoaW5rIGl0IHdvdWxk IG1ha2Ugc2Vuc2UgdG8gYWxsb3cgQVJNX0VGSSB0byBiZSBkaXNhYmxlZCBldmVuIHdpdGhvdXQN Cj4gdGhlIE1QVSBzdXBwb3J0LiBTbyB0aGlzIHdvdWxkIHJlbW92ZSBuZWFybHkgM0sgbGluZXMg KGp1c3QgdXNpbmcgd2MgLWwNCj4gKi5jIGluIHRoZSBlZmkgZGlyZWN0b3JpZXMpIGZvciBzb21l b25lIHRoYXQgZG9uJ3QgbmVlZCB0byBib290IHVzaW5nIEVGSS4NCj4gDQoNCk9rLCBob3cgYWJv dXQgYWRkcmVzcyB0aGlzIGNvbW1lbnQgaW4gTlVNQSBwYXRjaCBzZXQjMyAoQXJtIGltcGxlbWVu dGF0aW9uKSwNCmJlY2F1c2UgYWJvdXQgbWFraW5nIEFSTV9FRkkgaW52aXNpYmxlIHRvIHVzZXJz LCB3ZSBoYWQgc29tZSBkaXNjdXNzaW9ucw0KZm9yIE5VTUEgUkZDIGFuZCBWMS4NCg0KPiA+ICAg CXNlbGVjdCBIQVNfRkFTVF9NVUxUSVBMWQ0KPiA+DQo+ID4gICBjb25maWcgQVJNDQo+ID4gZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9hcm02NC9oZWFkLlMgYi94ZW4vYXJjaC9hcm0vYXJtNjQv aGVhZC5TDQo+ID4gaW5kZXggYWQwMTQ3MTZkYi4uY2NlZGYyMGRjNyAxMDA2NDQNCj4gPiAtLS0g YS94ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZC5TDQo+ID4gKysrIGIveGVuL2FyY2gvYXJtL2FybTY0 L2hlYWQuUw0KPiA+IEBAIC0xNzIsOCArMTcyLDEwIEBAIGVmaV9oZWFkOg0KPiA+ICAgICAgICAg ICAuYnl0ZSAgIDB4NTINCj4gPiAgICAgICAgICAgLmJ5dGUgICAweDRkDQo+ID4gICAgICAgICAg IC5ieXRlICAgMHg2NA0KPiA+IC0gICAgICAgIC5sb25nICAgcGVfaGVhZGVyIC0gZWZpX2hlYWQg ICAgICAgIC8qIE9mZnNldCB0byB0aGUgUEUgaGVhZGVyLg0KPiAqLw0KPiA+IC0NCj4gPiArI2lm bmRlZiBDT05GSUdfQVJNX0VGSQ0KPiA+ICsgICAgICAgIC5sb25nICAgMCAgICAgICAgICAgICAg ICAgICAgLyogMCBtZWFucyBubyBQRSBoZWFkZXIuICovDQo+ID4gKyNlbHNlDQo+ID4gKyAgICAg ICAgLmxvbmcgICBwZV9oZWFkZXIgLSBlZmlfaGVhZCAvKiBPZmZzZXQgdG8gdGhlIFBFIGhlYWRl ci4gKi8NCj4gPiAgICAgICAgICAgLyoNCj4gPiAgICAgICAgICAgICogQWRkIHRoZSBQRS9DT0ZG IGhlYWRlciB0byB0aGUgZmlsZS4gIFRoZSBhZGRyZXNzIG9mIHRoaXMNCj4gaGVhZGVyDQo+ID4g ICAgICAgICAgICAqIGlzIGF0IG9mZnNldCAweDNjIGluIHRoZSBmaWxlLCBhbmQgaXMgcGFydCBv ZiBMaW51eCAiSW1hZ2UiDQo+ID4gQEAgLTI3OSw2ICsyODEsOCBAQCBzZWN0aW9uX3RhYmxlOg0K PiA+ICAgICAgICAgICAuc2hvcnQgIDAgICAgICAgICAgICAgICAgLyogTnVtYmVyT2ZMaW5lTnVt YmVycyAgKDAgZm9yDQo+IGV4ZWN1dGFibGVzKSAqLw0KPiA+ICAgICAgICAgICAubG9uZyAgIDB4 ZTA1MDAwMjAgICAgICAgLyogQ2hhcmFjdGVyaXN0aWNzIChzZWN0aW9uIGZsYWdzKSAqLw0KPiA+ ICAgICAgICAgICAuYWxpZ24gIDUNCj4gPiArI2VuZGlmIC8qIENPTkZJR19BUk1fRUZJICovDQo+ ID4gKw0KPiA+ICAgcmVhbF9zdGFydDoNCj4gPiAgICAgICAgICAgLyogQlNTIHNob3VsZCBiZSB6 ZXJvZWQgd2hlbiBib290aW5nIHdpdGhvdXQgRUZJICovDQo+ID4gICAgICAgICAgIG1vdiAgIHgy NiwgIzAgICAgICAgICAgICAgICAgLyogeDI2IDo9IHNraXBfemVyb19ic3MgKi8NCj4gDQo+IFNo b3VsZG4ndCB0aGUgZnVuY3Rpb24gZWZpX3hlbl9zdGFydCBiZSBzdHViYmVkIGFzIHdlbGw/DQo+ IA0KDQpSZXBseSBmb3IgeW91ciBuZXh0IGVtYWlsOg0KWWVzLCB0aGlzIGlzIGEgZ29vZCBwb2lu dCwgZWZpX3hlbl9zdGFydCBzaG91bGQgYmUgcHJvdGVjdGVkLiBJIHdpbGwgZml4IGl0Lg0KDQpD aGVlcnMsDQpXZWkgQ2hlbg0KDQoNCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxs DQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 08 03:17:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 03:17:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439710.693753 (Exim 4.92) (envelope-from ) id 1osF6s-00053d-Do; Tue, 08 Nov 2022 03:17:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439710.693753; Tue, 08 Nov 2022 03:17:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osF6s-00053W-B2; Tue, 08 Nov 2022 03:17:10 +0000 Received: by outflank-mailman (input) for mailman id 439710; Tue, 08 Nov 2022 03:17:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osF6q-00053M-Qh; Tue, 08 Nov 2022 03:17:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osF6q-0000Yz-M8; Tue, 08 Nov 2022 03:17:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osF6q-0001rK-52; Tue, 08 Nov 2022 03:17:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osF6q-0007dw-4d; Tue, 08 Nov 2022 03:17:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qDXiuWS4i3NzwTdZ6+X28WXyh7XtGuAAEWAyiBVzUm4=; b=MZg0+fVaw04LUAUL55OXiQ7oj+ veGFcSDfvBHPEQpo09w5UstOwove0Hmy7JsYB3RVNg91eh2RzrnpvUWcbnghZ2KLm+Xj+VRcuW/rx ihX3Ode44TzxZHjrYeyhuFoNfao08QOUsrSvlJKwVAktmC/MJymj2BaGC7XsrRqpzc3A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174660: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit1::broken:regression linux-5.4:test-armhf-armhf-libvirt::broken:regression linux-5.4:test-armhf-armhf-xl-arndale::broken:regression linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-arndale:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-libvirt:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-xsm:xen-boot:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start.2:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:redhat-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a0d9384967214783a92973c920092b7251c03e57 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Tue, 08 Nov 2022 03:17:08 +0000 flight 174660 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174660/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 broken in 174655 test-armhf-armhf-libvirt broken in 174655 test-armhf-armhf-xl-arndale broken in 174655 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 174655 REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-arndale 5 host-install(5) broken in 174655 pass in 174660 test-armhf-armhf-xl-credit1 5 host-install(5) broken in 174655 pass in 174660 test-armhf-armhf-libvirt 5 host-install(5) broken in 174655 pass in 174660 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail in 174638 pass in 174660 test-amd64-i386-pair 11 xen-install/dst_host fail in 174638 pass in 174660 test-amd64-i386-libvirt-xsm 8 xen-boot fail in 174638 pass in 174660 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174638 pass in 174660 test-armhf-armhf-xl-rtds 14 guest-start fail in 174638 pass in 174660 test-armhf-armhf-libvirt-raw 13 guest-start fail in 174638 pass in 174660 test-armhf-armhf-xl-credit1 19 guest-start.2 fail in 174646 pass in 174638 test-amd64-i386-qemuu-rhel6hvm-amd 12 redhat-install fail in 174646 pass in 174660 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 174646 pass in 174660 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 174646 pass in 174660 test-armhf-armhf-libvirt-qcow2 13 guest-start fail in 174646 pass in 174660 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 174646 pass in 174660 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail in 174655 pass in 174660 test-armhf-armhf-xl-credit1 14 guest-start fail pass in 174646 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 174655 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 174646 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 174646 never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 174655 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 174655 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux a0d9384967214783a92973c920092b7251c03e57 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 9 days Failing since 174575 2022-11-01 18:42:39 Z 6 days 12 attempts Testing same since 174608 2022-11-03 19:46:50 Z 4 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anssi Hannula Arnaldo Carvalho de Melo Biju Das Brian Foster Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Darrick J. Wong Darrick J. Wong Dave Chinner David S. Miller Demi Marie Obenour Dongliang Mu Eric Dumazet Florian Fainelli Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hannu Hartikainen Hans Verkuil Heiko Carstens Helge Deller Hyong Youb Kim Hyunwoo Kim Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jeff Vanhoof Jens Glathe Jimmy Assarsson Johan Hovold Jon Hunter Jon Maloy Jonathan Cameron Josh Poimboeuf Juergen Gross Justin Chen Konrad Jankowski Kuogee Hsieh Leon Romanovsky Linux Kernel Functional Testing Luiz Capitulino M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Michal Jaron Mike Kravetz Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Paolo Abeni Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rik van Riel Saeed Mahameed Sakari Ailus Sasha Levin Shreeya Patel Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Thinh Nguyen Tom Lendacky Tony O'Brien Ulf Hansson Vasily Gorbik Vineet Gupta Vladimir Oltean Wei Yongjun Xin Long Yang Yingliang Yongqin Liu Zhang Changzhong Zhengchao Shao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-libvirt broken broken-job test-armhf-armhf-xl-arndale broken Not pushing. (No revision log; it would be 2244 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Nov 08 05:12:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 05:12:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439722.693764 (Exim 4.92) (envelope-from ) id 1osGuL-0002qo-Ph; Tue, 08 Nov 2022 05:12:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439722.693764; Tue, 08 Nov 2022 05:12:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osGuL-0002qh-L6; Tue, 08 Nov 2022 05:12:21 +0000 Received: by outflank-mailman (input) for mailman id 439722; Tue, 08 Nov 2022 05:12:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osGuJ-0002qX-TU; Tue, 08 Nov 2022 05:12:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osGuJ-0003VO-Q2; Tue, 08 Nov 2022 05:12:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osGuJ-0000aN-BS; Tue, 08 Nov 2022 05:12:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osGuJ-0000tS-Ae; Tue, 08 Nov 2022 05:12:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/9RD7gYxEY6E7NV9vUhSgyGTmxymVt4/LbilALOeoiE=; b=IAJBnzOoWXo2bBttRUe0I87bUY JtR6R2iW0M2VPwgClCePl7tA7xO0Mqf/dcCil6iyF7dp3s+a10oywUAmfd0DYcs5dowso4rGgrPu7 0a3xcL7bWgCJPsYEb2MTkuu+ViS+ryLpJxa/NuLz46z7P2OxQc6oBxfeo7sFMH8XqXiA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174662: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=cd706454c6cd239a477cb227caf3e3dfbb742d1a X-Osstest-Versions-That: qemuu=466e81ff12013d026e2d0154266fce82bce2ee9b From: osstest service owner Date: Tue, 08 Nov 2022 05:12:19 +0000 flight 174662 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174662/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174651 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174651 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174651 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174651 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 174651 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174651 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174651 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174651 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174651 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu cd706454c6cd239a477cb227caf3e3dfbb742d1a baseline version: qemuu 466e81ff12013d026e2d0154266fce82bce2ee9b Last test of basis 174651 2022-11-06 23:08:57 Z 1 days Testing same since 174662 2022-11-07 20:38:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Alex Bennée Bin Meng Chuck Zmudzinski Claudio Fontana Han Han Kevin Wolf Laurent Vivier Matthew Rosato Paolo Bonzini Peter Jin Philippe Mathieu-Daudé Pierre Morel Stefan Hajnoczi Stefan Weil TaiseiIto Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 466e81ff12..cd706454c6 cd706454c6cd239a477cb227caf3e3dfbb742d1a -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Nov 08 06:24:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 06:24:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439733.693774 (Exim 4.92) (envelope-from ) id 1osI1Y-0002zR-19; Tue, 08 Nov 2022 06:23:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439733.693774; Tue, 08 Nov 2022 06:23:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osI1X-0002zK-Uk; Tue, 08 Nov 2022 06:23:51 +0000 Received: by outflank-mailman (input) for mailman id 439733; Tue, 08 Nov 2022 06:23:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osI1W-0002zE-Hz for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 06:23:50 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e753ef95-5f2d-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 07:23:48 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6CBB521B6C; Tue, 8 Nov 2022 06:23:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2E7B8139F1; Tue, 8 Nov 2022 06:23:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sxDmCfP1aWPxEwAAMHmgww (envelope-from ); Tue, 08 Nov 2022 06:23:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e753ef95-5f2d-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667888627; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PEO7DL0zNZ32Tn8RciNsd2P0Lr0cQbcHn0BJiX8qFAM=; b=cnO3vPpizF2vggI2V7NajnKAkjdHTjBBV9W8ZJkVbzxuitawTG0tH6x+nAinQVX3elQXtc fmei5MdhTRpmv8P27rtI+r6ly/hbPjY2+KBL0bJmGjUzKhjcbQF0wGMMERaikx3ya3Jm7K D5qkqoi56XGWt8YagwaGCe1RB1tAZjo= Message-ID: <5ec6a009-d451-cf5c-5ce6-6f36ac3f99b6@suse.com> Date: Tue, 8 Nov 2022 07:23:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH][4.17] kexec: restore hypercall 1st arg's type Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------B2Z0fgTiE53p0j2fBKmgUylX" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------B2Z0fgTiE53p0j2fBKmgUylX Content-Type: multipart/mixed; boundary="------------v9wsCFkPsTNwqU1LFT3TnxgT"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang Message-ID: <5ec6a009-d451-cf5c-5ce6-6f36ac3f99b6@suse.com> Subject: Re: [PATCH][4.17] kexec: restore hypercall 1st arg's type References: In-Reply-To: --------------v9wsCFkPsTNwqU1LFT3TnxgT Content-Type: multipart/mixed; boundary="------------qKE8dmZOy01aRDjq0DcT0sIR" --------------qKE8dmZOy01aRDjq0DcT0sIR Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDcuMTEuMjIgMTY6MDksIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBUaGlzIHJldmVydHMg YSBzbWFsbCBwYXJ0IG9mIDdlMjFiMjUwNTllZCAoInhlbjogaGFybW9uaXplIHJldHVybiB0 eXBlcw0KPiBvZiBoeXBlcmNhbGwgaGFuZGxlcnMiKS4gVGhlIGNoYW5nZSBmcm9tICJ1bnNp Z25lZCBsb25nIiB0byAidW5zaWduZWQNCj4gaW50IiBmb3IgdGhlIG5hdGl2ZSBoYW5kbGVy IGZ1bmN0aW9uIG1lYW50IHRoYXQgcHJldmlvdXNseSBpbnZhbGlkDQo+IHZhbHVlcyBiZWNh bWUgdmFsaWQuIFdoaWxlIHBlcmhhcHMgbm90IGEgc2lnbmlmaWNhbnQgaXNzdWUsIHN0cmlj dGx5DQo+IHNwZWFraW5nIHRoYXQncyBzdGlsbCBhIGNoYW5nZSB0byB0aGUgQUJJLiBEb24n dCBnbyBhcyBmYXIgYXMgcmVzdG9yaW5nDQo+IHRoZSBjb21wYXQgZW50cnkgcG9pbnQncyB0 eXBlIHRob3VnaDogVGhhdCBvbmUgY2FuJ3QgaGF2ZSB2YWx1ZXMgcGFzc2VkDQo+IHdoaWNo IGRvbid0IGZpdCBpbiAzMiBiaXRzLg0KPiANCj4gTm90ZSB0aGF0IGFzIGEgc2lkZSBlZmZl Y3QgdGhpcyBmaXhlcyB0aGUgaW52b2NhdGlvbiBvZg0KPiBoeXBlcmNhbGxfY3JlYXRlX2Nv bnRpbnVhdGlvbigpLCB3aGljaCBieSBtaXN0YWtlIHdhc24ndCBhZGp1c3RlZCBieSB0aGUN Cj4gZWFybGllciBjaGFuZ2UuDQo+IA0KPiBBbHNvIHRha2UgdGhlIG9wcG9ydHVuaXR5IGFu ZCBjb3JyZWN0IHRoZSByZXNwZWN0aXZlIGNvbW1lbnQgaW4gdGhlDQo+IHB1YmxpYyBoZWFk ZXIuIChUaGUgd2F5IGl0IHdhcyBpdCByZWFsbHkgc3VwcG9ydHMgdGhhdCBpdCBwcm9iYWJs eSB3YXMNCj4gcG9pbnRsZXNzIHRvIHVzZSAibG9uZyIsIGJ1dCB0aGF0J3MgdGhlIHdheSB0 aGUgaHlwZXJjYWxsIHdhcw0KPiBpbnRyb2R1Y2VkLikNCj4gDQo+IFJlcXVlc3RlZC1ieTog QW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4gU2lnbmVkLW9m Zi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpSZXZpZXdlZC1ieTog SnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg0K --------------qKE8dmZOy01aRDjq0DcT0sIR Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------qKE8dmZOy01aRDjq0DcT0sIR-- --------------v9wsCFkPsTNwqU1LFT3TnxgT-- --------------B2Z0fgTiE53p0j2fBKmgUylX Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNp9fIFAwAAAAAACgkQsN6d1ii/Ey8V ggf+OgvQbE0V5VxdMrBN43PAjFRdvCGpFfb7Y5Ndlm7wecYF9u9ckiBGdD4veQInMmXCiEd0GAuC yvJ88YeHjADRgZe/DoSPrM0QwMuAiRacBa2YZ31xuuBNtIGIai/AeirRMOnmm1mrx1c5fmxhib4a 0H+Wz/5ZwmhKzdazUndqkAmKFZFOhOe+tR5dbUn9ud5FRzMqZobRkDZzM4b34/Q/LlOaaF7Pnu4M +4Qpnv+v2UMiAiFPDSzg+uhQBfENeDvnea+6I4GrUCVpBsRfDg76LvYrOrxZmMP/Lmk21l1EuhnF f7qD4Dgw2iA70iwBrCVq9WrPjgCgC6fqjyMG8duwzQ== =qL2s -----END PGP SIGNATURE----- --------------B2Z0fgTiE53p0j2fBKmgUylX-- From xen-devel-bounces@lists.xenproject.org Tue Nov 08 06:51:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 06:51:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439739.693787 (Exim 4.92) (envelope-from ) id 1osIS0-0006wa-7j; Tue, 08 Nov 2022 06:51:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439739.693787; Tue, 08 Nov 2022 06:51:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osIS0-0006wT-38; Tue, 08 Nov 2022 06:51:12 +0000 Received: by outflank-mailman (input) for mailman id 439739; Tue, 08 Nov 2022 06:51:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osIRz-0006wJ-9c; Tue, 08 Nov 2022 06:51:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osIRz-0005n7-7b; Tue, 08 Nov 2022 06:51:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osIRy-0005Xy-TC; Tue, 08 Nov 2022 06:51:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osIRy-0004Lk-So; Tue, 08 Nov 2022 06:51:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2u5lGvR9OXb5AbHVrRYm2ItwswDJTJdrCUBzZ49JkxY=; b=oPPGQZPKCrxorLpLAdOvXlUraM KPkU7V+y5xTJWaPadZk644bMFy7tUTC2Le+VuHCwf4OK+hNOfn0DCUigUiBC3CR5Bz0nIi7OI5tsk W0hjTRelx2C/RdjHSi/wWgXaJV+zh6dxhNS/ihjfqEbk9YUO/yP3xHC8O4jbWh3PN1H0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174666: all pass - PUSHED X-Osstest-Versions-This: ovmf=50bee4cc121aacc67f40b6c5ee0c71d3879dcc41 X-Osstest-Versions-That: ovmf=239bcf78053f4581cc3468ab961f9d37e859c7d9 From: osstest service owner Date: Tue, 08 Nov 2022 06:51:10 +0000 flight 174666 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174666/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 50bee4cc121aacc67f40b6c5ee0c71d3879dcc41 baseline version: ovmf 239bcf78053f4581cc3468ab961f9d37e859c7d9 Last test of basis 174658 2022-11-07 16:11:49 Z 0 days Testing same since 174666 2022-11-08 03:42:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jian J Wang Judah Vang Nishant C Mistry jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 239bcf7805..50bee4cc12 50bee4cc121aacc67f40b6c5ee0c71d3879dcc41 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Nov 08 07:26:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 07:26:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439749.693797 (Exim 4.92) (envelope-from ) id 1osJ07-0002uj-WC; Tue, 08 Nov 2022 07:26:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439749.693797; Tue, 08 Nov 2022 07:26:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osJ07-0002uc-Ry; Tue, 08 Nov 2022 07:26:27 +0000 Received: by outflank-mailman (input) for mailman id 439749; Tue, 08 Nov 2022 07:26:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osJ05-0002uW-Sl for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 07:26:26 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2084.outbound.protection.outlook.com [40.107.223.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a37c574c-5f36-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 08:26:20 +0100 (CET) Received: from MW4PR04CA0087.namprd04.prod.outlook.com (2603:10b6:303:6b::32) by IA1PR12MB6602.namprd12.prod.outlook.com (2603:10b6:208:3a2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Tue, 8 Nov 2022 07:26:19 +0000 Received: from CO1NAM11FT059.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6b:cafe::a8) by MW4PR04CA0087.outlook.office365.com (2603:10b6:303:6b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26 via Frontend Transport; Tue, 8 Nov 2022 07:26:18 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT059.mail.protection.outlook.com (10.13.174.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 07:26:17 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 8 Nov 2022 01:26:15 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Tue, 8 Nov 2022 01:26:14 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a37c574c-5f36-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l5Rr0k7uaNUzTc4N0RJx4WU31UmLdNhv+0f8JVY0PvQXS6r5xgRyzTJ442hKeDF/eH4mFw73cP4aoL5ooyVqHAXzuAor+uRd2YiKRP0uHGuTjeiDelUDgY9D08SE60ali+CJJYEwmmUnVCXo7wzstXrLCcbJjYUUrSFeVbfBVSu2LncEtqCbM28yYc3cA3PrE6cvBvUTc8Bo+V2b8eoAkMI57pHeT+EBE8yzbtYET8rMDiiAhUQsPDIgWIBd4ZPxe59fk8V25iqAt4EqRuQWCffRTRqUu1U4jcBng+W7BPDB7C4thNMzJ+3awignxB7NWf1y74/euzCaF8/lejKOYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ig6oVucpi1bLI4BiICYng/j57OErh4ZehuY3cKdoo4=; b=RE7UWcwvrXD/VoFax0q/433QLsHos25jVm4VATL1pAlog7c8dTJhJsgNAvjKxWQLGraR++bzKI5EYkL6TLgGXyhcj123Iz3RGSiB7w1Hml+BdOzITHJts3nGPxQAUlv4D0yjzX8kWLrKngjAGY4xu9m00KI0CUC4Y2UzzZa5e7zP9ex4oe5PfeisiSbiTThhVj+rIc8G57fgHnbVrlyGiPy8ssUPH5mP4fX7DcC8Lr0Jc3ghGxk6zv5eHYK4Q/ZYBPGnTkMM994ADZ5/nlj4a0+Wq20FNyyu4FEliVni8hQKwNqMErC3OUTSXm5TZfhmZ5BTJIyTOaONbcD+qzIK6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ig6oVucpi1bLI4BiICYng/j57OErh4ZehuY3cKdoo4=; b=a15RdkIg7YmdrUiBgm77D7eyuSQlD3qtbu3j5cX87sBK2gu6PA272DPxquzQqMtNxo5HgYIg3Z4RQEctGB+hxZIuxQ8EmChctC2xVPKRe3DgwZl1E25IPrXQu7+ckGpIox9DLU/V43PUNYiDttSLRzc7Ggh41urQh3UXncBkYzQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <3720a691-3303-a673-58b6-95da9a4341d2@amd.com> Date: Tue, 8 Nov 2022 08:26:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write To: Julien Grall , Ayan Kumar Halder , "Ayan Kumar Halder" , CC: , , , References: <20221104162355.23369-1-ayan.kumar.halder@amd.com> <062c9507-7744-0742-effb-76d2f1222a27@xen.org> <33a2d125-b7f2-3637-9dab-6b7d616fd4ff@amd.com> <36e84512-9b44-303e-2834-5aafe9c6cc15@amd.com> <74b1c6af-d6de-2728-9d59-2d561a521793@xen.org> Content-Language: en-US From: Michal Orzel In-Reply-To: <74b1c6af-d6de-2728-9d59-2d561a521793@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT059:EE_|IA1PR12MB6602:EE_ X-MS-Office365-Filtering-Correlation-Id: fe3e7535-a883-4b6a-5491-08dac15a86d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UHVGCOswoHnLYC0a6UqV9dD9Codn86UoXNz0Vb1bF7ybIKWaEY6GXFT+DeXUYFRZsVrLdMEXoJCIYO5pOBLKOKKvgWq30bmJT6V5OGsku/Bu+Cile+xexli0jGZ0zXapEqy4hod1KoAZGvCOKdJYtqI4avQqE41c16Ltozbm14FKovbBpRRW9uDg48iUhHpUHoRjMGsj35XgsTagNZtrRjnlD3rRo08LghoUxlxst65YrXabsRCxzCDXR0dkL2dtmFSOMA8CMEuMbBS2j8NYnbLuOx4XxE6UAN3apt5+cs4RgUsS+N/MDvKs+aA60/MkHXXM0L9+Ih/2p8hQ8mhE8Rg79jUOppUhd/EwUAjQkYEEXUeqoDgo7Jcb27qwXkawRPBwBC8zt3zIpwwaAz69aBDnZMjR63bDDrJsQFiuR3Sik6YPfZ8u8hETESqeSiJePCEApC0k5SGmwTIm6w7H/rmL0lvD3Xo3PrhpXMDhPLx0+YRyc78fD56+WLWl1QRuFU5YWIawsAdta09OPd+32DA/j86DVgFEIbMFQeE2e/v5wCb/SPb8A5kTTjXmyRQswJqK5PnsUSnGwIA5pslKwYFLLe9QM+ECU98Mye4dBneU9gtgsVDdE+k7/oLajtOGVvAGVdBXouS5hwaCkpTUK6EMu2hjQf8QtzirV3QdkmHiCjIYhXcCDHma/wN9YgiaKnlXS0icfuT2/NaFVQ4/fTijc1WruvYeqQHYudSFSJDr7vCt8x5T8cfelfOycL8odYNVuBnSF9ExDwfruC8nQ5Qd8iA189T6SnIMLDpJFV3do2qp6BOrsTBXA7aa1xDq0zolMpuMsrdkd3WkNeDzFA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(396003)(136003)(451199015)(36840700001)(46966006)(40470700004)(40460700003)(4326008)(41300700001)(40480700001)(8676002)(8936002)(5660300002)(478600001)(70206006)(2616005)(54906003)(36860700001)(110136005)(316002)(16576012)(81166007)(356005)(83380400001)(70586007)(82740400003)(86362001)(31696002)(186003)(336012)(426003)(26005)(53546011)(47076005)(31686004)(2906002)(82310400005)(36756003)(44832011)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 07:26:17.7645 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fe3e7535-a883-4b6a-5491-08dac15a86d0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT059.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6602 Hi Julien, On 07/11/2022 19:06, Julien Grall wrote: > > > Hi Ayan, > > On 07/11/2022 12:49, Ayan Kumar Halder wrote: >> >> On 07/11/2022 10:44, Julien Grall wrote: >>> Hi Ayan, >> Hi Julien, >>> >>> On 07/11/2022 10:36, Ayan Kumar Halder wrote: >>>> >>>> On 06/11/2022 17:54, Julien Grall wrote: >>>>> Hi Ayan, >>>> >>>> Hi Julien, >>>> >>>> I need some clarification. >>>> >>>>> >>>>> To me the title and the explaination below suggests... >>>>> >>>>> On 04/11/2022 16:23, Ayan Kumar Halder wrote: >>>>>> From: Ayan Kumar Halder >>>>>> >>>>>> Refer ARM DDI 0487I.a ID081822, B2.2.1 >>>>>> "Requirements for single-copy atomicity >>>>>> >>>>>> - A read that is generated by a load instruction that loads a single >>>>>> general-purpose register and is aligned to the size of the read in the >>>>>> instruction is single-copy atomic. >>>>>> >>>>>> -A write that is generated by a store instruction that stores a single >>>>>> general-purpose register and is aligned to the size of the write in >>>>>> the >>>>>> instruction is single-copy atomic" >>>>>> >>>>>> On AArch32, the alignment check is enabled at boot time by setting >>>>>> HSCTLR.A bit. >>>>>> ("HSCTLR, Hyp System Control Register"). >>>>>> However in AArch64, alignment check is not enabled at boot time. >>>>> >>>>> ... you want to enable the alignment check on AArch64 always. >>>> >>>> I want to enable alignment check *only* for atomic access. >>>> >>>> May be I should remove this line --> "However in AArch64, alignment >>>> check is not enabled at boot time.". >>>> >>>>> However, this is not possible to do because memcpy() is using >>>>> unaligned access. >>>> This is a non atomic access. So the commit does not apply here. >>> >>> Right, but your commit message refers to the alignment check on arm32. >>> You wrote too much for someone to wonder but not enough to explain why >>> we can't enable the alignment check on arm64. >>> >>>>> >>>>> I think the commit message/title should clarify that the check is >>>>> *only* done during debug build. IOW, there are no enforcement in >>>>> producation build. >>>> >>>> AFAICS read_atomic()/write_atomic() is enabled during non debug >>>> builds (ie CONFIG_DEBUG=n) as well. >>> >>> My point was that ASSERT() is a NOP in production build. So you >>> effectively the enforcement happens only in debug build. >>> >>> IOW, unless you test exhaustively with a debug build, you may never >>> notice that the access was not atomic. >> >> This makes sense. >> >> Does the following commit message look better ? >> >> xen/Arm: Enforce alignment check for atomic read/write > > title: > > xen/arm: Enforce alignment check in debug build for {read, write}_atomic > >> >> Refer ARM DDI 0487I.a ID081822, B2.2.1 >> "Requirements for single-copy atomicity >> >> - A read that is generated by a load instruction that loads a single >> general-purpose register and is aligned to the size of the read in the >> instruction is single-copy atomic. >> >> -A write that is generated by a store instruction that stores a single >> general-purpose register and is aligned to the size of the write in the >> instruction is single-copy atomic" >> >> Thus, one needs to check for alignment when performing atomic operations. >> However, as ASSERT() are disabled in production builds, so one needs to > > This seems to be a bit out of context because you don't really explain > that ASSERT() would be used. Also... > >> run the debug builds to catch any unaligned access during atomic >> operations. >> Enforcing alignment checks during production build has quite a high >> overhead. >> >> On AArch32, the alignment check is enabled at boot time by setting >> HSCTLR.A bit. >> ("HSCTLR, Hyp System Control Register"). >> However, on AArch64, memcpy()/memset() may be used on 64bit unaligned >> addresses. >> Thus, one does not wish to enable alignment check at boot time. > > ... to me this paragraph should be first because this explained why we > can't check in production. So how about the following commit message: > > " > xen/arm: Enforce alignment check in debug build for {read, write}_atomic > > Xen provides helper to atomically read/write memory (see {read, > write}_atomic()). Those helpers can only work if the address is aligned > to the size of the access (see B2.2.1 ARM DDI 08476I.a). > > On Arm32, the alignment is already enforced by the processor because > HSCTLR.A bit is set (it enforce alignment for every access). For Arm64, > this bit is not set because memcpy()/memset() can use unaligned access > for performance reason (the implementation is taken from the Cortex > library). > > To avoid any overhead in production build, the alignment will only be > checked using an ASSERT. Note that it might be possible to do it in > production build using the acquire/exclusive version of load/store. But > this is left to a follow-up (if wanted). > " This reads very well. > > While trying to find a justification for the debug version. I was > wondering whether we could actually use the acquire or exclusive > version. I am not entirely sure about the overhead. > >> >> Signed-off-by: Ayan Kumar Halder >> Reviewed-by: Michal Orzel >> Reviewed-by: Bertrand Marquis >> >> I think I can keep R-b as there is no code change ? > > My signed-off-by will need to be added for the commit message I proposed > above. So I would like Bertrand/Michal to confirm they are happy with it > (I don't usually add my reviewed-by/acked-by for patch where my > signed-off-by is added). > You can keep my Rb and Bertrand or Stefano can ack it, so that we can avoid acking a patch by one of the authors. > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Tue Nov 08 07:54:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 07:54:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439763.693807 (Exim 4.92) (envelope-from ) id 1osJR8-000706-42; Tue, 08 Nov 2022 07:54:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439763.693807; Tue, 08 Nov 2022 07:54:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osJR8-0006zz-1U; Tue, 08 Nov 2022 07:54:22 +0000 Received: by outflank-mailman (input) for mailman id 439763; Tue, 08 Nov 2022 07:54:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osJR6-0006zt-Ju for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 07:54:20 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8be1fd9f-5f3a-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 08:54:19 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9412422326; Tue, 8 Nov 2022 07:54:17 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 71DEC13398; Tue, 8 Nov 2022 07:54:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fKaAGikLamNhOAAAMHmgww (envelope-from ); Tue, 08 Nov 2022 07:54:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8be1fd9f-5f3a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667894057; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=68pMislhyP16umI5FjgQvmDG34PnTcUD3qOoda9GIuk=; b=T3B/KZWzlgUECOXO4uDU0DUIEMI03mfwngsrm9R4yvbIlxWT0+p2dK/y5RK7c7RJwbe79a eH9ccYsR/9sx+HC8AyJFy45tjPt+L1ynHNdAKaD87Am/7DGfdkymP5cPohBmMzfFdxgJxY sBJjdQnpWRQKZ+ZaulKMbXlNkW3WQ6w= Message-ID: <90878b0e-c40e-e4cc-e423-c514a72ede7f@suse.com> Date: Tue, 8 Nov 2022 08:54:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-7-jgross@suse.com> <67cb3364-d5c1-28d8-4cda-8933de5cb9f7@xen.org> <703aa58c-1b7c-abb6-995d-5c5cdfcde878@suse.com> <5fe0a47c-66ca-9e0a-4742-1663c7761256@xen.org> From: Juergen Gross Subject: Re: [PATCH 06/20] tools/xenstore: remove all watches when a domain has stopped In-Reply-To: <5fe0a47c-66ca-9e0a-4742-1663c7761256@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------IogQt2NYCUGaoX16DyfJGZyP" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------IogQt2NYCUGaoX16DyfJGZyP Content-Type: multipart/mixed; boundary="------------rn1rs0fJXTVmoo9Q0iurlvBt"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <90878b0e-c40e-e4cc-e423-c514a72ede7f@suse.com> Subject: Re: [PATCH 06/20] tools/xenstore: remove all watches when a domain has stopped References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-7-jgross@suse.com> <67cb3364-d5c1-28d8-4cda-8933de5cb9f7@xen.org> <703aa58c-1b7c-abb6-995d-5c5cdfcde878@suse.com> <5fe0a47c-66ca-9e0a-4742-1663c7761256@xen.org> In-Reply-To: <5fe0a47c-66ca-9e0a-4742-1663c7761256@xen.org> --------------rn1rs0fJXTVmoo9Q0iurlvBt Content-Type: multipart/mixed; boundary="------------vLr1oHpPQC8sctz7lUyLUUco" --------------vLr1oHpPQC8sctz7lUyLUUco Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDcuMTEuMjIgMTk6MzMsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gDQo+IA0KPiBPbiAw Ny8xMS8yMDIyIDA3OjU0LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMDYuMTEuMjIg MjI6MTgsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+PiBIaSBKdWVyZ2VuLA0KPj4+DQo+Pj4g T24gMDEvMTEvMjAyMiAxNToyOCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+Pj4gV2hlbiBh IGRvbWFpbiBoYXMgYmVlbiByZWNvZ25pemVkIHRvIGhhdmUgc3RvcHBlZCwgcmVtb3ZlIGFs bCBpdHMNCj4+Pj4gcmVnaXN0ZXJlZCB3YXRjaGVzLiBUaGlzIGF2b2lkcyBzZW5kaW5nIHdh dGNoIGV2ZW50cyB0byB0aGUgZGVhZCBkb21haW4NCj4+Pj4gd2hlbiBhbGwgdGhlIG5vZGVz IHJlbGF0ZWQgdG8gaXQgYXJlIGJlaW5nIHJlbW92ZWQgYnkgdGhlIFhlbiB0b29scy4NCj4+ Pg0KPj4+IMKgRnJvbSBteSB1bmRlcnN0YW5kaW5nLCBzaHV0ZG93biBkb2Vzbid0IG1lYW4g ZGVhZC4gSXQgbWF5IGJlIHVzZWQgZHVyaW5nIA0KPj4+IG1pZ3JhdGlvbiAob3Igc25hcHNo b3R0aW5nKSwgd2hlcmUgd2UgZG9uJ3Qgd2FudCB0byB0b3VjaCB0aGUgc3RhdGUgaW4gY2Fz ZSANCj4+PiBvZiBhIGNhbmNlbGxhdGlvbiAob3IgcmVzdW1lKS4NCj4+Pg0KPj4+IEZvciBp bnN0YW5jZSwgc2VlIHRoZSBjb21tYW5kIFhTX1JFU1VNRSB3aGljaCB3aWxsIGNsZWFyIGRv bWFpbi0+c2h1dGRvd24uDQo+Pg0KPj4gT2gsIGdvb2QgY2F0Y2ghDQo+Pg0KPj4gSSBuZWVk IHRvIGFkZGl0aW9uYWxseSBjaGVjayB0aGUgInNodXRkb3duIHJlYXNvbiIuIEkgY2FuIHJl bW92ZSB0aGUNCj4+IHdhdGNoZXMgb25seSBpbiBjYXNlIG9mIHRoZSByZWFzb24gbm90IGhh dmluZyBiZWVuICJzdXNwZW5kIi4NCj4gDQo+IFRoaXMgaXMgcXVpdGUgZnJhZ2lsZSBiZWNh dXNlIHdlIG1heSBhZGQgbmV3IHNodXRkb3duIGNvZGUgaW4gdGhlIGZ1dHVyZSB0aGF0IA0K PiBjb3VsZCByZXN1bWUuDQo+IA0KPiBJIHRoaW5rIGl0IHdvdWxkIGJlIGJldHRlciB0byBv bmx5IGRlbGV0ZSB0aGUgd2F0Y2hlcyBpZiB0aGUgZG9tYWluIGlzIA0KPiBlZmZlY3RpdmVs eSBkeWluZyAoSSBkb24ndCB0aGluayBpdCBjYW4gY29tZSBiYWNrIGZyb20gdGhhdCBzdGF0 ZSkNCg0KVGhpcyBpcyBob3cgaXQgaXMgZG9uZSB0b2RheS4NCg0KVGhlIGRvbWFpbidzIFhl bnN0b3JlIGVudHJpZXMgYXJlIHJlbW92ZWQgYmVmb3JlIHRoZSBkb21haW4gaXMgYmVpbmcN CmRlc3Ryb3llZC4NCg0KDQpKdWVyZ2VuDQo= --------------vLr1oHpPQC8sctz7lUyLUUco Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------vLr1oHpPQC8sctz7lUyLUUco-- --------------rn1rs0fJXTVmoo9Q0iurlvBt-- --------------IogQt2NYCUGaoX16DyfJGZyP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNqCykFAwAAAAAACgkQsN6d1ii/Ey+P NAf/XftbEcLqHGs72VepWx+p3tJm5nNINwQ5kBgKzmsEi19jjmwnvPkzCpjDG9Gkm1dwiRVyrMZk LZrgrDceisJA9Y0HmR9VXTqyO+o0Nk+2SvjHYhs48UOvDllev3OnHvkh4FpjSP08CZbc0iXEDNMI h68+mmxRUKOVPLCXENgoN477EoxN0BMMIGrPCzMMJDEtDMGawJFh+gat4cci0M5nFExcGh4vRSfl 6r3HCeXvGhalbuUwEukxJG3FBCBevTTUIS7v8uiF9xgPddc8YNHu3qgl4nmryF6NKBiqKsKSN/PK lW7/5hRaLsusoJU/MsIsAkgHYyGK9JV1wh+PNjHi8w== =8Fgo -----END PGP SIGNATURE----- --------------IogQt2NYCUGaoX16DyfJGZyP-- From xen-devel-bounces@lists.xenproject.org Tue Nov 08 08:09:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 08:09:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439777.693819 (Exim 4.92) (envelope-from ) id 1osJfq-00017d-MA; Tue, 08 Nov 2022 08:09:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439777.693819; Tue, 08 Nov 2022 08:09:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osJfq-00017W-JX; Tue, 08 Nov 2022 08:09:34 +0000 Received: by outflank-mailman (input) for mailman id 439777; Tue, 08 Nov 2022 08:09:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osJfp-00017Q-KD for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 08:09:33 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id acd791fc-5f3c-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 09:09:32 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B7C931F897; Tue, 8 Nov 2022 08:09:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 94C9013398; Tue, 8 Nov 2022 08:09:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id FLQOI7sOamMdQAAAMHmgww (envelope-from ); Tue, 08 Nov 2022 08:09:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: acd791fc-5f3c-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667894971; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VnE69RIgdgJHM+8fSXDgm4w33N9GC5eL7EZqtGOttqM=; b=fuPIBuqpNslspv0DGUwFf+a9VjoMb6ZNTzYWT82Rc65NkN700pEcZHXFzTGhnFx7B8ga5j Bb34h9Rci9xsD0Sy1V03EKmKvEehRzYZITcQ7R7VHJ0dmBS9ERpGGNJAAOv0cjhi58lblA YCYsEdDZ4ryKWf5BgjTbglwgXF1GLwA= Message-ID: Date: Tue, 8 Nov 2022 09:09:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 13/20] tools/xenstore: don't allow creating too many nodes in a transaction Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-14-jgross@suse.com> <32f61945-08fa-f095-02c4-9d52b66b6c04@xen.org> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------GSASEPLasic2yKIarumM0rBX" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------GSASEPLasic2yKIarumM0rBX Content-Type: multipart/mixed; boundary="------------huXD5UNIeO8dDV86X2gJkF4q"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH 13/20] tools/xenstore: don't allow creating too many nodes in a transaction References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-14-jgross@suse.com> <32f61945-08fa-f095-02c4-9d52b66b6c04@xen.org> In-Reply-To: --------------huXD5UNIeO8dDV86X2gJkF4q Content-Type: multipart/mixed; boundary="------------vT4HUou0EdhusR8rM2GCcmUM" --------------vT4HUou0EdhusR8rM2GCcmUM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDcuMTEuMjIgMTk6MzcsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gDQo+IA0KPiBPbiAw Ny8xMS8yMDIyIDA4OjM0LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMDYuMTEuMjIg MjM6MDAsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+PiBIaSBKdWVyZ2VuLA0KPj4+DQo+Pj4g T24gMDEvMTEvMjAyMiAxNToyOCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+Pj4gVGhlIGFj Y291bnRpbmcgZm9yIHRoZSBudW1iZXIgb2Ygbm9kZXMgb2YgYSBkb21haW4gaW4gYW4gYWN0 aXZlDQo+Pj4+IHRyYW5zYWN0aW9uIGlzIG5vdCB3b3JraW5nIGNvcnJlY3RseSwgYXMgaXQg YWxsb3dzIHRvIGNyZWF0ZSBhcmJpdHJhcnkNCj4+Pj4gbnVtYmVyIG9mIG5vZGVzLiBUaGUg dHJhbnNhY3Rpb24gd2lsbCBmaW5hbGx5IGZhaWwgZHVlIHRvIGV4Y2VlZGluZw0KPj4+PiB0 aGUgbnVtYmVyIG9mIG5vZGVzIHF1b3RhLCBidXQgYmVmb3JlIGNsb3NpbmcgdGhlIHRyYW5z YWN0aW9uIGFuDQo+Pj4+IHVucHJpdmlsZWdlZCBndWVzdCBjb3VsZCBjYXVzZSBYZW5zdG9y ZSB0byB1c2UgYSBsb3Qgb2YgbWVtb3J5Lg0KPj4+DQo+Pj4gSSBoYXZlIGFscmVhZHkgbWFk ZSBzb21lIG9mIGNvbW1lbnRzIG9uIHRoZSBzZWN1cml0eSBNTCB3aGVuIHRoaXMgd2FzIA0K Pj4+IGluaXRpYWxseSBzZXQuIFRoZSBhcmd1bWVudHMgc3RpbGwgZG9uJ3Qgc291bmQgcmln aHQgdG8gbWUuDQo+Pj4NCj4+PiBGb3IgYSBmaXJzdCwgc2luY2UgWFNBLTMyNiwgd2UgaGF2 ZSBhIGNhcCBpbiBwbGFjZSBmb3IgdGhlIG1lbW9yeSBhIGRvbWFpbiANCj4+PiBjYW4gY29u c3VtZS4gU28gdGhpcyBzdXJlbHkgY2FuJ3QgYmUgYSAibG90IG9mIG1lbW9yeSIuIE90aGVy d2lzZSB3ZSBhcmUgDQo+Pj4gc2F5aW5nIHRoYXQgb3VyIGxpbWl0ICh0aGVyZSBhcmUgb3Ro ZXIgd2F5IHRvIGhpdCBpdCkgd2VyZSB3cm9uZy4uLg0KPj4NCj4+IFllYWgsIG1heWJlIEkg c2hvdWxkIHJld29yayB0aGUgY29tbWl0IG1lc3NhZ2UuDQo+Pg0KPj4gVGhlIHJlYXNvbiBJ IHN0aWxsIHdhbnQgdG8ga2VlcCB0aGUgcGF0Y2ggaXMgdGhhdCBpbiBhIHRyYW5zYWN0aW9u IHdpdGhvdXQgYW55DQo+PiBjb25mbGljdHMgYW5kIHdpdGhvdXQgaGl0dGluZyBhbnkgdHJh bnNhY3Rpb24gc3BlY2lmaWMgbGltaXRzIChudW1iZXIgb2Ygbm9kZXMNCj4+IGFjY2Vzc2Vk KSwgdGhlIGVycm9ycyByZXR1cm5lZCBkdWUgdG8gYSBzaW5nbGUgb3BlcmF0aW9uIHNob3Vs ZCBiZSB0aGUgc2FtZSBhcw0KPj4gd2l0aCB0aGUgc2FtZSBvcGVyYXRpb24gcGVyZm9ybWVk IG91dHNpZGUgYSB0cmFuc2FjdGlvbi4NCj4gDQo+IFRoaXMgc2VlbXMgdG8gYmUgYSB2ZXJ5 IG5pY2hlIHVzZSBjYXNlLiBTbyBpdCBpcyBub3QgY2xlYXIgdG8gbWUgd2h5IHRoaXMgbWF0 dGVyIA0KPiBhbmQgd2Ugd2FudCB0byBhZGQgZXh0cmEgY2hlY2sgZm9yIGV2ZXJ5b25lLg0K DQpJdCBpcyBhIG1hdHRlciBvZiBjb3JyZWN0bmVzcy4NCg0KQWRkaXRpb25hbGx5LCBhZnRl ciB0aGUgaW50ZXJuYWwgYWNjb3VudGluZyByZXdvcmsgdGhpcyBtYWtlcyBldmVuIG1vcmUN CnNlbnNlLCBhcyB0aGUgbWF4aW11bSB2YWx1ZXMgcGVyIGRvbWFpbiBzZWVuIGFyZSByZWFs bHkgY29ycmVjdCwgZXZlbiB3aGVuDQpxdWVyaWVkIHdoaWxlIHRyYW5zYWN0aW9ucyBhcmUg YWN0aXZlLg0KDQoNCkp1ZXJnZW4NCg== --------------vT4HUou0EdhusR8rM2GCcmUM Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------vT4HUou0EdhusR8rM2GCcmUM-- --------------huXD5UNIeO8dDV86X2gJkF4q-- --------------GSASEPLasic2yKIarumM0rBX Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNqDrsFAwAAAAAACgkQsN6d1ii/Ey/6 dAf/a3ooQ6UjjbWbzrdCfmElZkzwUEuMX57OZhNBmxxyiOgsQRqEmuGPpEeGhdl3p5oPiDSWZwmc x+98mTF3Roa9F/yoSbsiEhCATlfHPGuOptJBYh3hkwTzVhVBEVG87Yn4S0gDt5ixB7+Amqt7qaaF 2PwEhifGARBvX85QZsNzIaQQdxbq2i19piyx7F4Vk9ATGNoIxcz+xkOFho/1YYluzmFR+0xgZ4RG KqP2A/2F+xZPbXMcKqchewYvdo/QgCmjwHhlzrnna5Qw0ydw4LJdzfYiQ/4a64TeMQyyY/ynOVSM jMaeILcAGQ4yLEJkoNOnBQcZZ7oUJ+rQqMEs33TfrA== =F4my -----END PGP SIGNATURE----- --------------GSASEPLasic2yKIarumM0rBX-- From xen-devel-bounces@lists.xenproject.org Tue Nov 08 08:35:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 08:35:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439785.693830 (Exim 4.92) (envelope-from ) id 1osK4K-0004rc-Mk; Tue, 08 Nov 2022 08:34:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439785.693830; Tue, 08 Nov 2022 08:34:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osK4K-0004rV-Jq; Tue, 08 Nov 2022 08:34:52 +0000 Received: by outflank-mailman (input) for mailman id 439785; Tue, 08 Nov 2022 08:34:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osK4I-0004rP-TO for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 08:34:51 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2055.outbound.protection.outlook.com [40.107.249.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34a716c9-5f40-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 09:34:48 +0100 (CET) Received: from DU2PR04CA0085.eurprd04.prod.outlook.com (2603:10a6:10:232::30) by GV2PR08MB8343.eurprd08.prod.outlook.com (2603:10a6:150:bb::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 08:34:40 +0000 Received: from DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:232:cafe::aa) by DU2PR04CA0085.outlook.office365.com (2603:10a6:10:232::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 08:34:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT006.mail.protection.outlook.com (100.127.142.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 08:34:39 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Tue, 08 Nov 2022 08:34:39 +0000 Received: from de6c6cfc7ded.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5BC275EC-9BD6-4C8B-AB0A-E25C038B9DC1.1; Tue, 08 Nov 2022 08:34:32 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id de6c6cfc7ded.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Nov 2022 08:34:32 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PA4PR08MB6127.eurprd08.prod.outlook.com (2603:10a6:102:f3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 08:34:29 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5813.011; Tue, 8 Nov 2022 08:34:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34a716c9-5f40-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=K5F0n2Mjfn5uXuJr1vf2moSf/v1ruI2ChXjKvlpwrkmMbU/ApwvXyldMk0HYUi/je+YMOZ4T9UcZHFv8CI2x4Ku5y7S2mDugHBd8BhqSKKbmPTKq5jfJLIoclN3U378U/btWtgfGfYUAlFL0/B6v2uMia7Vgxx1jPTqz0RLM/MFCDHnJeVROGTjdpQKxOtd2KTFngMYFavaFV3ztprXxXIxJAVRcDEy9+7RPJ9xgMVvv5oV/TDl4UUQV/nVsb8vdKO58ZhQIPCmoIWmNNpwFYFtaUzPxBls7bVeNx0VLIJP8VNMMFbp6PynvQS6PBgzcd9kI4OKSQuZ3H/1HFHUKdw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Edb/qCESl1R4sa/bekmFJaJNEnidd1Ae86NxrarcaeQ=; b=Jh079lqkdA6W/9aMPkNi8nxcp/si6dGLZUcdiwggHxyeVDUdanzBIDby2SJ05WdXIp5tMKmYUz82IdD9C4M70mEc2i1zgvMDTzpdRRJsaHzG3ZjIZzbpfMOb02sB7bpGfLJuq78x5RrmW2s61Em1UuVmN/UFR954bhyvuRj5BJCv/5zaeAA/1ga+hBVKQIrPqO+aL6GWFpBz78sLR0QXF28Hs9rFH65DqG+Si1aeZ5d5cEtg5TBV7at/jox0QCUaPLb4rC+nyRc9xb0KVeMVaZP3kUvQxg/FJ8yn1jt96JnFic/eIAKGaSLiX0EVF1OQUlHmmJF7HbFjQQ4CzaanAg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Edb/qCESl1R4sa/bekmFJaJNEnidd1Ae86NxrarcaeQ=; b=lKsUBoY7NW6d/R3wWHo6+babmPxs0B0T8kaefHOxUvB7+AKCKt0VcN+yL6PS6auarqvWUOn/JnmyHBIvdiffIEBBzxSgu+iU2uTsnIqjg9WCpatwJLxycRcb+FmF9vwOVOETkpdBG0TVjLlQwbuwDwmPkVH6Aj0LshLhBSw2QUc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: cf002ca647b8eb94 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kykkVXG/oQqLcgwrjeta29GIBmOs4Um06Ll87EjZZ552NyjZoI9t7az44F/DD7w4lQugG4QCvrM6+CBfL/BIzPqX9dKJplyUlbgXxzbIR121A/KgKtApgTzF/TcIIezhKLUviIB3VfcsFRCoESs29qFXcgnuEuusx+Ie37aetwhINR+pntqSJW+omHodVDnbsdndJGMUMjyVw3nXq8A+I7Jrdeo7lKwiaZDXj33AiWwYq/k5Ccx3XynlHv+6TBunXHLTs/uhnz2yXNXiEmdwkVcJg4iFdPdkWY/9dUCmjhV86XoNDOdJxOH1lyM6JXzhHS+I/dln44TTgekmXcdsxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Edb/qCESl1R4sa/bekmFJaJNEnidd1Ae86NxrarcaeQ=; b=k5O46xYoTwvqioqjFA4ua3x245CXoqL1vdPQJKhDI/th1oJDkl9o8fYMHAgfehNJm8XexI6yl3jYosf/Tv1l1/QZ+gayOsrS66mPn/QSdQgnjx4o9cSf4/1AuYwX27nFkr28+KxZX2lu+nU83qPKifLZpVJIsAq2nEkGkWjmDFTWOkkj9e/KtaUvwwBrE/mCyJYFCNADlA08QwooBAMmXtwfuzIyr0CjVB7VUaes6+N349Wv7Jxub4cAXgCOGTioRNCdH1ssdHEmLSUJNwfY1TOAkKDmY+ZaKll75UwuLjBSPsgn9XsDSa9FMgBFMVmixe2qcopqmyp0HjSYW4ctPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Edb/qCESl1R4sa/bekmFJaJNEnidd1Ae86NxrarcaeQ=; b=lKsUBoY7NW6d/R3wWHo6+babmPxs0B0T8kaefHOxUvB7+AKCKt0VcN+yL6PS6auarqvWUOn/JnmyHBIvdiffIEBBzxSgu+iU2uTsnIqjg9WCpatwJLxycRcb+FmF9vwOVOETkpdBG0TVjLlQwbuwDwmPkVH6Aj0LshLhBSw2QUc= From: Bertrand Marquis To: Michal Orzel CC: Julien Grall , Ayan Kumar Halder , Ayan Kumar Halder , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" , "stefanos@xilinx.com" , "Volodymyr_Babchuk@epam.com" Subject: Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write Thread-Topic: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write Thread-Index: AQHY8Gnh8hKxIKIkAUWHK4BT2/fYBK4yMOUAgAEXv4CAAAJqAIAAItoAgABYlgCAAN9xgIAAExEA Date: Tue, 8 Nov 2022 08:34:29 +0000 Message-ID: <211D65B7-2CCD-4BDD-A9A3-FF4DF9D562AC@arm.com> References: <20221104162355.23369-1-ayan.kumar.halder@amd.com> <062c9507-7744-0742-effb-76d2f1222a27@xen.org> <33a2d125-b7f2-3637-9dab-6b7d616fd4ff@amd.com> <36e84512-9b44-303e-2834-5aafe9c6cc15@amd.com> <74b1c6af-d6de-2728-9d59-2d561a521793@xen.org> <3720a691-3303-a673-58b6-95da9a4341d2@amd.com> In-Reply-To: <3720a691-3303-a673-58b6-95da9a4341d2@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|PA4PR08MB6127:EE_|DBAEUR03FT006:EE_|GV2PR08MB8343:EE_ X-MS-Office365-Filtering-Correlation-Id: 8abb1e32-3793-4db2-3723-08dac1641384 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3ZyRZtgrbR8S7GQ6wDNDEEOYsBV2NdwTdH0tXudjr/2Md+JqhYAbl0eDEZ3pibARriun+uIlXsjQQiM7Gs8N+XhVfFpDwKze4ELdP6LSIwfiMOn40NVdz54Tjz8Wy7jhgQfwtqMRcXw4GMSxIh5H/9o/JlFQHTt/elFUSb64y1qs8e+k9XS0qnSwJP+lsEgYB+NpxkZfWvEF10/JQAODYzhcQ+R83Laa+0SggcTVOIjZs318NsxsVLVacOdGFfa8u/FmN8VwfmPYDOrFM9AFzoZqga4aG1WeYxeUh1j8ZXZQpNxBw9nG5qjlNAdG5ZtL9m8Spv2eD4updfnQaXsrkYRbXg3bc+gObp36Nq7T9dbcb7wT65r/b3ukOmTKVmg1W5mxfBuIpDsOVl/8TQluedRic/mffr9UPsKFzCkKiX0pH7OyhNMjsB969DLh4g6vyBqNmM9juZYcBcx3xAiOXUjLC8/0yUMnf1WqVO8McYVmIJrU9lIeJ1L5vcT3WsPi9tcAB9l/fG0GhiVaW80NuP6I/q5oU3DmNAxPS6IQJwhec1iI/5gxEBhTkiviyrx2ZX+n4L8aFBbi99HBu2B3yshyPUNBw6eHiBD9n+RUoUHHQjT6hKlLZ5z7amv286tE+UlJ5hUfMQ43KPOsrouJyUTWaCfTpcVnwmhT54caBRFCcOp7ISgMOSrYedG7srKUOd5bPkdjso2/I59kA/Ax7k8Aedk3N3Zm4XmTWb/4E9zpxTpBS0BD27dFpAnCKG2tiPHOjgzGSsQzjolD8Zs2gwmLOt0XbwmagoAhQeWFBJ0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(366004)(376002)(346002)(136003)(451199015)(71200400001)(478600001)(6486002)(316002)(2906002)(8936002)(186003)(2616005)(54906003)(86362001)(53546011)(6916009)(26005)(36756003)(6512007)(33656002)(6506007)(38100700002)(4326008)(41300700001)(38070700005)(8676002)(83380400001)(76116006)(5660300002)(66556008)(66446008)(122000001)(64756008)(91956017)(66946007)(66476007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6127 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 592f962d-182f-4392-7909-08dac1640d79 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fR/n4Ir60+ETZcJptjPBE5lDqRTcoWbmNVqfryEoxosJbPAqQdn41YwssD+Lyst9pxU/bCrAF+qYB5bJw0JQ2bVH8XoZRY4/mBE9TTkUMCPFobEl5uvPXhUuApZSAtRL/XyCvtcMX278lSTar2UZIewvmVhOtE/DJua+NHnKWSHdTpKsULahImpTdrtzZc3GkEJP2UieZa4Z4lPxpwb1ImfdsYp8yvyLiQYG/0AXyQWrRKxLwYZYHebfpwz7XRfrH5Ok9gyW2Xq4ChTVW6cPAp8pFgaYYHeGhcRptbHUZb/stvsWIFkSpQpasZDkPq43YXA2Yxf1MNe7C0JZUKi7GxtJIHfGyk44xgu0xIRjEvY0pnx6YA7kW+h6TOiBlnjyFWmwBtlU4qtkyZGQsn/1KC9b3ip11bmE4lofQ41nj8pp38/nJ/qc94dr6/bx2NHhnQdaDa2zNddMKFHDizMVaqgrZR5A6w+N8WtHiXpsPmTME9d0bXvgyl4HVnEDYcpWfz2RhqRB8p0VpE0Wf6zu7WG/dnU/fgNk6fvtKfcvY7AeIGUdT6DcI/WuonlqtcbXYLYvCmPNSVjLxFDAUXAdx7UfRWLHh66u3qkk/PeRlBK6NC10HNFVLoB7bgNq8JkKhedx4K5XtYMjcBFDhvH0o42ZxfhnM4kHJdrO2t9gS3b+WQlc1l0NjI4+pGuhv1SAgjOL07V5ZiWsutnUmbyHPgBCgEn2KHfBrf0ItV9S7mITjEnkO0jYEzJjDWsXVJKT6mayvXe5kx6p8wy2HJt4wA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199015)(46966006)(36840700001)(40470700004)(40480700001)(478600001)(8936002)(6486002)(36756003)(5660300002)(4326008)(356005)(2906002)(316002)(70206006)(81166007)(8676002)(6862004)(54906003)(83380400001)(33656002)(36860700001)(41300700001)(6506007)(107886003)(86362001)(82740400003)(70586007)(53546011)(186003)(47076005)(336012)(40460700003)(26005)(6512007)(2616005)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 08:34:39.4668 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8abb1e32-3793-4db2-3723-08dac1641384 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8343 Hi, > On 8 Nov 2022, at 07:26, Michal Orzel wrote: >=20 > Hi Julien, >=20 > On 07/11/2022 19:06, Julien Grall wrote: >>=20 >>=20 >> Hi Ayan, >>=20 >> On 07/11/2022 12:49, Ayan Kumar Halder wrote: >>>=20 >>> On 07/11/2022 10:44, Julien Grall wrote: >>>> Hi Ayan, >>> Hi Julien, >>>>=20 >>>> On 07/11/2022 10:36, Ayan Kumar Halder wrote: >>>>>=20 >>>>> On 06/11/2022 17:54, Julien Grall wrote: >>>>>> Hi Ayan, >>>>>=20 >>>>> Hi Julien, >>>>>=20 >>>>> I need some clarification. >>>>>=20 >>>>>>=20 >>>>>> To me the title and the explaination below suggests... >>>>>>=20 >>>>>> On 04/11/2022 16:23, Ayan Kumar Halder wrote: >>>>>>> From: Ayan Kumar Halder >>>>>>>=20 >>>>>>> Refer ARM DDI 0487I.a ID081822, B2.2.1 >>>>>>> "Requirements for single-copy atomicity >>>>>>>=20 >>>>>>> - A read that is generated by a load instruction that loads a singl= e >>>>>>> general-purpose register and is aligned to the size of the read in = the >>>>>>> instruction is single-copy atomic. >>>>>>>=20 >>>>>>> -A write that is generated by a store instruction that stores a sin= gle >>>>>>> general-purpose register and is aligned to the size of the write in >>>>>>> the >>>>>>> instruction is single-copy atomic" >>>>>>>=20 >>>>>>> On AArch32, the alignment check is enabled at boot time by setting >>>>>>> HSCTLR.A bit. >>>>>>> ("HSCTLR, Hyp System Control Register"). >>>>>>> However in AArch64, alignment check is not enabled at boot time. >>>>>>=20 >>>>>> ... you want to enable the alignment check on AArch64 always. >>>>>=20 >>>>> I want to enable alignment check *only* for atomic access. >>>>>=20 >>>>> May be I should remove this line --> "However in AArch64, alignment >>>>> check is not enabled at boot time.". >>>>>=20 >>>>>> However, this is not possible to do because memcpy() is using >>>>>> unaligned access. >>>>> This is a non atomic access. So the commit does not apply here. >>>>=20 >>>> Right, but your commit message refers to the alignment check on arm32. >>>> You wrote too much for someone to wonder but not enough to explain why >>>> we can't enable the alignment check on arm64. >>>>=20 >>>>>>=20 >>>>>> I think the commit message/title should clarify that the check is >>>>>> *only* done during debug build. IOW, there are no enforcement in >>>>>> producation build. >>>>>=20 >>>>> AFAICS read_atomic()/write_atomic() is enabled during non debug >>>>> builds (ie CONFIG_DEBUG=3Dn) as well. >>>>=20 >>>> My point was that ASSERT() is a NOP in production build. So you >>>> effectively the enforcement happens only in debug build. >>>>=20 >>>> IOW, unless you test exhaustively with a debug build, you may never >>>> notice that the access was not atomic. >>>=20 >>> This makes sense. >>>=20 >>> Does the following commit message look better ? >>>=20 >>> xen/Arm: Enforce alignment check for atomic read/write >>=20 >> title: >>=20 >> xen/arm: Enforce alignment check in debug build for {read, write}_atomic >>=20 >>>=20 >>> Refer ARM DDI 0487I.a ID081822, B2.2.1 >>> "Requirements for single-copy atomicity >>>=20 >>> - A read that is generated by a load instruction that loads a single >>> general-purpose register and is aligned to the size of the read in the >>> instruction is single-copy atomic. >>>=20 >>> -A write that is generated by a store instruction that stores a single >>> general-purpose register and is aligned to the size of the write in the >>> instruction is single-copy atomic" >>>=20 >>> Thus, one needs to check for alignment when performing atomic operation= s. >>> However, as ASSERT() are disabled in production builds, so one needs to >>=20 >> This seems to be a bit out of context because you don't really explain >> that ASSERT() would be used. Also... >>=20 >>> run the debug builds to catch any unaligned access during atomic >>> operations. >>> Enforcing alignment checks during production build has quite a high >>> overhead. >>>=20 >>> On AArch32, the alignment check is enabled at boot time by setting >>> HSCTLR.A bit. >>> ("HSCTLR, Hyp System Control Register"). >>> However, on AArch64, memcpy()/memset() may be used on 64bit unaligned >>> addresses. >>> Thus, one does not wish to enable alignment check at boot time. >>=20 >> ... to me this paragraph should be first because this explained why we >> can't check in production. So how about the following commit message: >>=20 >> " >> xen/arm: Enforce alignment check in debug build for {read, write}_atomic >>=20 >> Xen provides helper to atomically read/write memory (see {read, >> write}_atomic()). Those helpers can only work if the address is aligned >> to the size of the access (see B2.2.1 ARM DDI 08476I.a). >>=20 >> On Arm32, the alignment is already enforced by the processor because >> HSCTLR.A bit is set (it enforce alignment for every access). For Arm64, >> this bit is not set because memcpy()/memset() can use unaligned access >> for performance reason (the implementation is taken from the Cortex >> library). >>=20 >> To avoid any overhead in production build, the alignment will only be >> checked using an ASSERT. Note that it might be possible to do it in >> production build using the acquire/exclusive version of load/store. But >> this is left to a follow-up (if wanted). >> " > This reads very well. >=20 >>=20 >> While trying to find a justification for the debug version. I was >> wondering whether we could actually use the acquire or exclusive >> version. I am not entirely sure about the overhead. >>=20 >>>=20 >>> Signed-off-by: Ayan Kumar Halder >>> Reviewed-by: Michal Orzel >>> Reviewed-by: Bertrand Marquis >>>=20 >>> I think I can keep R-b as there is no code change ? >>=20 >> My signed-off-by will need to be added for the commit message I proposed >> above. So I would like Bertrand/Michal to confirm they are happy with it >> (I don't usually add my reviewed-by/acked-by for patch where my >> signed-off-by is added). >>=20 > You can keep my Rb and Bertrand or Stefano can ack it, so that we can avo= id > acking a patch by one of the authors. I will check and ack the v3 once out. Cheers Bertrand >=20 >> Cheers, >>=20 >> -- >> Julien Grall >=20 > ~Michal From xen-devel-bounces@lists.xenproject.org Tue Nov 08 08:42:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 08:42:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439791.693841 (Exim 4.92) (envelope-from ) id 1osKBY-0006XI-Ew; Tue, 08 Nov 2022 08:42:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439791.693841; Tue, 08 Nov 2022 08:42:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osKBY-0006XB-BR; Tue, 08 Nov 2022 08:42:20 +0000 Received: by outflank-mailman (input) for mailman id 439791; Tue, 08 Nov 2022 08:42:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osKBX-0006X5-0r for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 08:42:19 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60072.outbound.protection.outlook.com [40.107.6.72]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4088db3d-5f41-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 09:42:18 +0100 (CET) Received: from FR3P281CA0116.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::20) by PAWPR08MB9006.eurprd08.prod.outlook.com (2603:10a6:102:33f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 08:42:15 +0000 Received: from VI1EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a3:cafe::dc) by FR3P281CA0116.outlook.office365.com (2603:10a6:d10:a3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Tue, 8 Nov 2022 08:42:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT057.mail.protection.outlook.com (100.127.144.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 08:42:15 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Tue, 08 Nov 2022 08:42:14 +0000 Received: from cd498ec1f242.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6F23D40A-F792-4CDF-9175-FD64F57E8016.1; Tue, 08 Nov 2022 08:42:07 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cd498ec1f242.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Nov 2022 08:42:07 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAXPR08MB6413.eurprd08.prod.outlook.com (2603:10a6:102:de::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 08:42:04 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5813.011; Tue, 8 Nov 2022 08:42:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4088db3d-5f41-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=UIevRZjnzGE+7GIdLxhUkDPKOvutXW0r2eRhw0NXcTN/wnPhE/jtm0dykxhncYG4+NVnCdi3XkAEpAP//GK5fd/GX5UumUy+zGxqqBsXNUB/tmMIXDJpH/Q0KzgBCenVhyPGSxqXz0eekNvSqXN2vh+Wln37u5+eFqTXu6IN5Q9zY7lhXPj4SagUnbpvIKdjKJg3PPk05uhEtJLR8q+6IDjRYm1pZasY9vvELFJl+TUle3otW1KLaDE3VqV+Dbb7OaXxGGHBpALfibG83CEcH5U08zbxfJPB0wFxKaTMiQWg1NBLCuSEDFOd6XKXSdtLcYYVKt1UpFPQHKFsJ3XxzQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tTFXpf/o0Bd9v3h4yz6oODoHhqevYb8YgG/KqecYylU=; b=LsRxscsCv8OkDXJdkSzKMMuWnL3RcC83s41oUNg+u5uEieKmMdds3w5OMtHNJYWhrgl0yj4yvh/C0k5OTbsHuDd6y1C8R3AwTsLMEgDuvIdUI4KUDUOj0scOd6JykEpA/9XGu/W5Yao1K4EXOhXDm9Vb5pkrYfIUUmVaC+hCrTTlW/uJK97reUIr8tfcgM9QNBwb0XMJZjtQ1cF6JW1TJg24bI2Jt42LUzqVwVNX9fKOupKqAXyX7FJjDErAnw817sOzmNFtKU/+MFAvbmx+kB3QxBOJ0wtYMqtNzrKzr5TzrErtDZOPTFsVvcvuKbUAnEy6i07H9SFuI55GRrvbWg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tTFXpf/o0Bd9v3h4yz6oODoHhqevYb8YgG/KqecYylU=; b=2GPN9BEqlEhT3lX4jLDgbcxeo5lOz4AdFlfeeKYIQxHP6yLeX+agzv4tA2Jb4Ra8OE7ijUROeVMe4Dkks3h4OzYDJ1Ph3aMR0ZwwMHiiZHko34qX/2bloVABcSJJYMsiFf5U+YG4e2lXz2zE2dZJD1Y7i6WAgoaXQt1vWpACRRg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 7571397ea764579f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m0FNDvs0Cx6/1w1qKIj5xrHXRHfBa765pFD3uaeDkkDxXcaKkwzZ8cPq/8WwBA95tDHPqym+LoVPgKtEWNt/3ZgFSo+WRIpguIqU9ieP/j88MnVy/vPNLiZ/cXlj18Mp9rHcUsAJ9RAinEPjM7MZKgfgTnnXsoHi9trTVuJfQJvBqoVZOnS84sm+r5nXJI80OsVyqN5c0ZP/93gFNGPKXQtA7werM4d3cqCHjlvuod+zPgq8FDRUsltuOtkpesaTcEIYf6D+2G6nsXNOJ3nUEZJtd8t/fu1RyCGcY9PkOxelKWyVUFg1OGjzc6Ia50P6dxMdSjPzukV4dozp+V9qWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tTFXpf/o0Bd9v3h4yz6oODoHhqevYb8YgG/KqecYylU=; b=TC0YCG7ffNzmaH6NT+LGma8aqejB33oJB0aZRkXPTAj9eiGqkPkJATBQEicn8dK4qMAoZPFvDt6yiPc+0eI6DGdGG1TJE9M4KKfOO1HWE1FkFPagN/SyxBeZKzbCyx9kpgZ/aLVAMzu9ebEIdjGUjIcJIbGuAclmgxaKOiFbLMx9kRvC/r2gLG70MXIxK5Wt4XEP3Q1GJeyLHNLXUVDFRKdijeU1ouQwIsnkft3M9VHmRaH49Z2V2NuBMU/hDH2yJAQKcttQj5HSfpoPwiLmNLADxmkeZMPdNX+RknsFbFqWJ277T9/B1WxF7oAyRm6SsRZF45/jOkDhuVtM1bLlhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tTFXpf/o0Bd9v3h4yz6oODoHhqevYb8YgG/KqecYylU=; b=2GPN9BEqlEhT3lX4jLDgbcxeo5lOz4AdFlfeeKYIQxHP6yLeX+agzv4tA2Jb4Ra8OE7ijUROeVMe4Dkks3h4OzYDJ1Ph3aMR0ZwwMHiiZHko34qX/2bloVABcSJJYMsiFf5U+YG4e2lXz2zE2dZJD1Y7i6WAgoaXQt1vWpACRRg= From: Bertrand Marquis To: Michal Orzel CC: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Doug Goldstein Subject: Re: [PATCH v3 0/4] Yocto Gitlab CI Thread-Topic: [PATCH v3 0/4] Yocto Gitlab CI Thread-Index: AQHY7TFh2hDh7VPqHUGkPo4tUdJZza4okuGAgAAFoQCACog5gIABoNWA Date: Tue, 8 Nov 2022 08:42:04 +0000 Message-ID: References: <1220596a-4fe7-5c08-5437-fa98eb14254c@amd.com> <6ee0706b-d1b3-187a-1557-c4b8173c6e37@amd.com> In-Reply-To: <6ee0706b-d1b3-187a-1557-c4b8173c6e37@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|PAXPR08MB6413:EE_|VI1EUR03FT057:EE_|PAWPR08MB9006:EE_ X-MS-Office365-Filtering-Correlation-Id: b6639d57-e698-4065-0a3d-08dac1652327 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /FqUxAvWr/vmnmKXhudWiJ/vrzbGnfttcgzBbIJH+HbXDasJUoTmBZzxscsYWOYl6RZvtxTxglvaloEEMMZhuj9pj40PKG2CN2UXSbHck4L0ExjSenlsS4jz971uG2p3mGy6HLTvCLi/AgNzViBr3t2b5a6F0hQTN4lkpujVsj4LBdJRUuMNB2uJuBiJDnmYtcFJCP7FyWt8ygcWDIeRkzttADwz662E6z3kEQidGqSVimFqcfLgvt2nRwWKJfQmw5HNW15D2lDEJNsoHuIXPBxEZpgyUsxQZZ2ghPm6/2IFR7LFXPu9neG6dIKF0M4F3KNsEyVC95XWy8oVxDPYwUAZlRTJWG7w/O6QDlJ+ckW35S1365njH2qAPL53i/T24NCSNycLkFXUfzirhQr0nzUBtFYX0h6V01G2hmAhFlzjksssOMQ72iU7Iuas/7bhnsqaNj0GgPrEmwir8bJdLHb9A4yKT/9LyTk/Uv4fGh63kuPDlweQ/TilRVwI6oOloBDtXwGXy7LCmugHdiRbP2PQ07k7y+hLNUkr5KcNotVHyYejW5hb1h+3K+H50tKaqtzSTdhr85ZNWqmfo1TNCf+9/Ca5DyZWt4jZiMplNoA49ei2I0DgAYfjLzSdWPATE+bsoz5BTndcWcqrWWgYCJVS7TuX89cGFPaMkrOH0CdOu0quQsU4EBzzYfc8bMjtpUxwhVTclB+764CFNHUA/iInrmxFIIm3cu76VP2wMRQXQnECfz3X923fN7cQdknAN+JatPGNMeG3rkyawhamd8biyoUP+RMbY7ya54UxWVMWoxTNe1udrrcrNHNV4x+XUYEhVp1o1tGWux/BBGko9Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(366004)(376002)(396003)(39860400002)(451199015)(4326008)(478600001)(2906002)(66946007)(66446008)(91956017)(76116006)(33656002)(316002)(66476007)(8676002)(64756008)(66556008)(5660300002)(6486002)(8936002)(966005)(71200400001)(41300700001)(38070700005)(83380400001)(54906003)(122000001)(38100700002)(6506007)(86362001)(2616005)(186003)(26005)(6512007)(53546011)(6916009)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6413 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3bedacc5-2997-4ad2-7b75-08dac1651c94 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OVMWKU9rYIc4TllVRng/xYzGlPq/iizfUzsJXfDpOiLOFR7EycGO9VXzUaSpAuaDMKGpzWsypuB0jA3hroE7WwJDedkVaK+oUwroaOvnqcMnK96CwILG7tw/cOvbscZSwCNtmrY2Bip/ADc9/uIHY0bq+PQxBdx4hrlAUNOrw261m6YCD2TDavxqvNBIG/VIRRejwnjyHByA3Ms4BzSH6Gefq1IwlFgt4GaL4j4GEXtmzCxcBKrmNu7+7xmZXvRzSemhwH6qGoNs9/Qu1UCFtuxNYesIYkS71rxxXL8CD+XufQoJuaYv2fCLr5rOFaM/5jvEv8OfS0/SAx97+Jcp/g+edgPGYXKe78CCtSdr+VqFryZmo+IiYy9qEjTx+gnJ1NY8TYl0SXX/yY9e43JwZDjMRYA7iykV24wr5tUbLaD2hrLKAJ8MK6ip2MXcAhuUbtg4g1I8on8iH5pbvqRnOJNhM9zNR4UGi3iJiIRM9FtqEI6/1yFOuQvTqgLfhIfrqxrF8oJ1Ru0skWpUSwy2f9df1/w9zaEX1rGUblKUX3C3pSO1uWFc1+QHS7QrLAUd00TVUdBnF0mEeKKUpAWcpQTJX7M+4hMBT4lJqyHxgwM6onRrcbnpsyPUKj4vcTSOeD/9+tEtoOVmHVZlz27gX5dpJ2Tg9NayGFZO1TufrySxLtAiJVxrAt3GKmAqn1rQhilg8YHu6yyZcqGCWmCIcdo2mwCQ8yIRFWSLuNfwiQn7394LiQ9yv2JJIirMUaUxrSClhKXV9i0N/WFfZAnJGV4sKxIhN4YDcpzNe5ZDClaG8CFzPjxrn671Fql8CiSc X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(39860400002)(346002)(451199015)(46966006)(36840700001)(40470700004)(478600001)(966005)(6862004)(6486002)(8936002)(5660300002)(2906002)(53546011)(356005)(40480700001)(26005)(36756003)(107886003)(81166007)(70206006)(4326008)(70586007)(36860700001)(8676002)(2616005)(54906003)(186003)(33656002)(82310400005)(6506007)(6512007)(316002)(83380400001)(86362001)(40460700003)(41300700001)(82740400003)(336012)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 08:42:15.0559 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b6639d57-e698-4065-0a3d-08dac1652327 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9006 SGkgTWljaGFsLA0KDQo+IE9uIDcgTm92IDIwMjIsIGF0IDA3OjUwLCBNaWNoYWwgT3J6ZWwgPG1p Y2hhbC5vcnplbEBhbWQuY29tPiB3cm90ZToNCj4gDQo+IEhpIEJlcnRyYW5kIGFuZCBTdGVmYW5v LA0KPiANCj4gT24gMzEvMTAvMjAyMiAxNjowMCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+ IA0KPj4gDQo+PiBIaSBNaWNoYWwsDQo+PiANCj4+PiBPbiAzMSBPY3QgMjAyMiwgYXQgMTQ6Mzks IE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+IHdyb3RlOg0KPj4+IA0KPj4+IEhp IEJlcnRyYW5kLA0KPj4+IA0KPj4+IE9uIDMxLzEwLzIwMjIgMTU6MDAsIEJlcnRyYW5kIE1hcnF1 aXMgd3JvdGU6DQo+Pj4+IA0KPj4+PiANCj4+Pj4gVGhpcyBwYXRjaCBzZXJpZXMgaXMgYSBmaXJz dCBhdHRlbXB0IHRvIGNoZWNrIGlmIHdlIGNvdWxkIHVzZSBZb2N0byBpbg0KPj4+PiBnaXRsYWIg Y2kgdG8gYnVpbGQgYW5kIHJ1biB4ZW4gb24gcWVtdSBmb3IgYXJtLCBhcm02NCBhbmQgeDg2Lg0K Pj4+PiANCj4+Pj4gVGhlIGZpcnN0IHBhdGNoIGlzIGNyZWF0aW5nIGEgY29udGFpbmVyIHdpdGgg YWxsIGVsZW1lbnRzIHJlcXVpcmVkIHRvDQo+Pj4+IGJ1aWxkIFlvY3RvLCBhIGNoZWNrb3V0IG9m IHRoZSB5b2N0byBsYXllcnMgcmVxdWlyZWQgYW5kIGFuIGhlbHBlcg0KPj4+PiBzY3JpcHQgdG8g YnVpbGQgYW5kIHJ1biB4ZW4gb24gcWVtdSB3aXRoIHlvY3RvLg0KPj4+PiANCj4+Pj4gVGhlIHNl Y29uZCBwYXRjaCBpcyBjcmVhdGluZyBjb250YWluZXJzIHdpdGggYSBmaXJzdCBidWlsZCBvZiB5 b2N0byBkb25lDQo+Pj4+IHNvIHRoYXQgc3VzYnNlcXVlbnQgYnVpbGQgd2l0aCB0aG9zZSBjb250 YWluZXJzIHdvdWxkIG9ubHkgcmVidWlsZCB3aGF0DQo+Pj4+IHdhcyBjaGFuZ2VkIGFuZCB0YWtl IHRoZSByZXN0IGZyb20gdGhlIGNhY2hlLg0KPj4+PiANCj4+Pj4gVGhlIHRoaXJkIHBhdGNoIGlz IGFkZGluZyBhIHdheSB0byBlYXNpbHkgY2xlYW4gbG9jYWxseSBjcmVhdGVkDQo+Pj4+IGNvbnRh aW5lcnMuDQo+Pj4+IA0KPj4+PiBUaGlzIGlzIGlzIG1haW5seSBmb3IgZGlzY3Vzc2lvbiBhbmQg c2hhcmluZyBhcyB0aGVyZSBhcmUgc3RpbGwgc29tZQ0KPj4+PiBpc3N1ZXMvcHJvYmxlbSB0byBz b2x2ZToNCj4+Pj4gLSBidWlsZGluZyB0aGUgcWVtdSogY29udGFpbmVycyBjYW4gdGFrZSBzZXZl cmFsIGhvdXJzIGRlcGVuZGluZyBvbiB0aGUNCj4+Pj4gbmV0d29yayBiYW5kd2l0aCBhbmQgY29t cHV0aW5nIHBvd2VyIG9mIHRoZSBtYWNoaW5lIHdoZXJlIHRob3NlIGFyZQ0KPj4+PiBjcmVhdGVk DQo+Pj4gVGhpcyBpcyBub3QgcmVhbGx5IGFuIGlzc3VlIGFzIHRoZSBidWlsZCBvZiB0aGUgY29u dGFpbmVycyBvY2N1cnMgb24gdGhlIGxvY2FsDQo+Pj4gbWFjaGluZXMgYmVmb3JlIHB1c2hpbmcg dGhlbSB0byByZWdpc3RyeS4gQWxzbywgYnVpbGRpbmcgdGhlIGNvbnRhaW5lcnMNCj4+PiB3aWxs IG9ubHkgYmUgcmVxdWlyZWQgZm9yIG5ldyBZb2N0byByZWxlYXNlcy4NCj4+PiANCj4+Pj4gLSBw cm9kdWNlZCBjb250YWluZXJzIGNvbnRhaW5pbmcgdGhlIGNhY2hlIGhhdmUgYSBzaXplIGJldHdl ZW4gOCBhbmQNCj4+Pj4gMTJHQiBkZXBlbmRpbmcgb24gdGhlIGFyY2hpdGVjdHVyZS4gV2UgbWln aHQgbmVlZCB0byBzdG9yZSB0aGUgYnVpbGQNCj4+Pj4gY2FjaGUgc29tZXdoZXJlIGVsc2UgdG8g cmVkdWNlIHRoZSBzaXplLiBJZiB3ZSBjaG9vc2UgdG8gaGF2ZSBvbmUNCj4+Pj4gc2luZ2xlIGlt YWdlLCB0aGUgbmVlZGVkIHNpemUgaXMgYXJvdW5kIDIwR0IgYW5kIHdlIG5lZWQgdXAgdG8gNDBH Qg0KPj4+PiBkdXJpbmcgdGhlIGJ1aWxkLCB3aGljaCBpcyB3aHkgSSBzcGxpdHRlZCB0aGVtLg0K Pj4+PiAtIGR1cmluZyB0aGUgYnVpbGQgYW5kIHJ1biwgd2UgdXNlIGEgYml0IG1vcmUgdGhlbiAy MEdCIG9mIGRpc2sgd2hpY2ggaXMNCj4+Pj4gb3ZlciB0aGUgYWxsb3dlZCBzaXplIGluIGdpdGxh Yg0KPj4+IEFzIHdlIGNvdWxkIHNlZSBkdXJpbmcgdjIgdGVzdGluZywgd2UgZG8gbm90IGhhdmUg YW55IHNwYWNlIHJlc3RyaWN0aW9ucw0KPj4+IG9uIHRoZSBYZW4gR2l0TGFiIGFuZCBJIHRoaW5r IHdlIGFscmVhZHkgZGVjaWRlZCB0byBoYXZlIHRoZSBZb2N0bw0KPj4+IGludGVncmF0ZWQgaW50 byBvdXIgQ0kuDQo+PiANCj4+IFJpZ2h0LCBJIHNob3VsZCBoYXZlIG1vZGlmaWVkIHRoaXMgY2hh cHRlciB0byBiZSBjb2hlcmVudCB3aXRoIHlvdXIgbGF0ZXN0IHRlc3RzLg0KPj4gU29ycnkgZm9y IHRoYXQuDQo+PiANCj4+PiANCj4+PiBJIHdpbGwgZG8gc29tZSB0ZXN0aW5nIGFuZCBnZXQgYmFj ayB0byB5b3Ugd2l0aCByZXN1bHRzICsgcmV2aWV3Lg0KPiBJIGRpZCBzb21lIHRlc3RpbmcgYW5k IGhlcmUgYXJlIHRoZSByZXN1bHRzOg0KPiANCj4gSW4gdGhlIGN1cnJlbnQgZm9ybSB0aGlzIHNl cmllcyB3aWxsIGZhaWwgd2hlbiBydW5uaW5nIENJIGJlY2F1c2UgdGhlIFlvY3RvIGNvbnRhaW5l cnMNCj4gYXJlIGJhc2VkIG9uICJGcm9tIHVidW50dToyMi4wNCIgKHRoZXJlIGlzIG5vIHBsYXRm b3JtIHByZWZpeCksIHdoaWNoIG1lYW5zIHRoYXQgdGhlIGNvbnRhaW5lcnMNCj4gYXJlIGJ1aWx0 IGZvciB0aGUgaG9zdCBhcmNoaXRlY3R1cmUgKGluIG15IGNhc2UgYW5kIGluIDk5JSBvZiB0aGUg Y2FzZXMgb2YgdGhlIGxvY2FsIGJ1aWxkIGl0IHdpbGwNCj4gYmUgeDg2KS4gSW4gR2l0bGFiIHdl IGhhdmUgMiBydW5uZXJzIChhcm02NCBhbmQgeDg2XzY0KS4gVGhpcyBtZWFucyB0aGF0IGFsbCB0 aGUgdGVzdCBqb2JzIHdvdWxkIG5lZWQNCj4gdG8gc3BlY2lmeSB4ODZfNjQgYXMgYSB0YWcgd2hl biBrZWVwaW5nIHRoZSBjdXJyZW50IGJlaGF2aW9yLg0KPiBBZnRlciBJIGJ1aWx0IGFsbCB0aGUg Y29udGFpbmVycyBvbiBteSB4ODYgbWFjaGluZSwgSSBwdXNoZWQgdGhlbSB0byByZWdpc3RyeSBh bmQgdGhlIHBpcGVsaW5lIHdhcyBzdWNjZXNzZnVsOg0KPiBodHRwczovL2dpdGxhYi5jb20veGVu LXByb2plY3QvcGVvcGxlL21vcnplbC94ZW4tb3J6ZWxtaWNoYWwvLS9waXBlbGluZXMvNjg2ODUz OTM5DQo+IA0KPiBIZXJlIGlzIHRoZSBkaWZmIG9uIHBhdGNoIG5vLiAzIHRvIG1ha2UgdGhlIHNl cmllcyB3b3JrICh1c2luZyB4ODYgdGFnIGFuZCBzbWFsbCBpbXByb3ZlbWVudCB0byBpbmNsdWRl IG5lZWRzOiBbXSk6DQo+IGBgYA0KPiBkaWZmIC0tZ2l0IGEvYXV0b21hdGlvbi9naXRsYWItY2kv dGVzdC55YW1sIGIvYXV0b21hdGlvbi9naXRsYWItY2kvdGVzdC55YW1sDQo+IGluZGV4IDVjNjIw ZmVmY2U1OS4uNTJjY2NlYzZmOTA0IDEwMDY0NA0KPiAtLS0gYS9hdXRvbWF0aW9uL2dpdGxhYi1j aS90ZXN0LnlhbWwNCj4gKysrIGIvYXV0b21hdGlvbi9naXRsYWItY2kvdGVzdC55YW1sDQo+IEBA IC02NSw2ICs2NSw5IEBADQo+ICAgICBwYXRoczoNCj4gICAgICAgLSAnbG9ncy8qJw0KPiAgICAg d2hlbjogYWx3YXlzDQo+ICsgIG5lZWRzOiBbXQ0KPiArICB0YWdzOg0KPiArICAgIC0geDg2XzY0 DQo+IA0KPiAjIFRlc3Qgam9icw0KPiBidWlsZC1lYWNoLWNvbW1pdC1nY2M6DQo+IEBAIC0yMDYs MTkgKzIwOSwxMyBAQCB5b2N0by1xZW11YXJtNjQ6DQo+ICAgZXh0ZW5kczogLnlvY3RvLXRlc3QN Cj4gICB2YXJpYWJsZXM6DQo+ICAgICBZT0NUT19CT0FSRDogcWVtdWFybTY0DQo+IC0gIHRhZ3M6 DQo+IC0gICAgLSBhcm02NA0KPiANCj4geW9jdG8tcWVtdWFybToNCj4gICBleHRlbmRzOiAueW9j dG8tdGVzdA0KPiAgIHZhcmlhYmxlczoNCj4gICAgIFlPQ1RPX0JPQVJEOiBxZW11YXJtDQo+IC0g IHRhZ3M6DQo+IC0gICAgLSBhcm0zMg0KPiANCj4geW9jdG8tcWVtdXg4Ni02NDoNCj4gICBleHRl bmRzOiAueW9jdG8tdGVzdA0KPiAgIHZhcmlhYmxlczoNCj4gICAgIFlPQ1RPX0JPQVJEOiBxZW11 eDg2LTY0DQo+IC0gIHRhZ3M6DQo+IC0gICAgLSB4ODZfNjQNCj4gYGBgDQo+IA0KPiBOb3csIHRo ZSBsb2dpY2FsIHdheSB3b3VsZCBiZSB0byBidWlsZCB4ODYgeW9jdG8gY29udGFpbmVyIGZvciB4 ODYsIGFybTY0IGZvciBhcm02NCBhbmQgYXJtMzIgb24gYXJtNjQgb3IgeDg2Lg0KPiBJIHRyaWVk IGJ1aWxkaW5nIHRoZSBjb250YWluZXIgcWVtdWFybTY0IHNwZWNpZnlpbmcgdGFyZ2V0IGFybTY0 IG9uIHg4Ni4gQWZ0ZXIgMTVoLCBvbmx5IDcwJSBvZiB0aGUgWW9jdG8gYnVpbGQNCj4gd2FzIGNv bXBsZXRlZCBhbmQgdGhlcmUgd2FzIGFuIGVycm9yIHdpdGggZ2xpYmMgKHRoZSBsb2NhbCBidWls ZCBvZiB0aGUgY29udGFpbmVyIGZvciB0aGUgaG9zdCBhcmNoIHRha2VzIG9uIG15IG1hY2hpbmUg bWF4IDJoKS4NCj4gVGhpcyBlbm9ybW91cyBhbW91bnQgb2YgdGltZSBpcyBkdWUgdG8gdGhlIHFl bXUgZG9ja2VyIGVtdWxhdGlvbiB0aGF0IGhhcHBlbnMgYmVoaW5kIHRoZSBzY2VuZXMgKEkgY2hl Y2tlZCBvbiAyIGRpZmZlcmVudCBtYWNoaW5lcykuDQo+IA0KPiBTbyB3ZSBoYXZlIDMgc29sdXRp b25zOg0KPiAxKSBCdWlsZCBhbmQgcnVuIHRoZXNlIGNvbnRhaW5lcnMgZm9yL29uIHg4Nl82NDoN Cj4gLSBsb2NhbCB1c2VycyBjYW4gYnVpbGQgdGhlIGNvbnRhaW5lcnMgb24gbG9jYWwgbWFjaGlu ZXMgdGhhdCBhcmUgYWxtb3N0IGFsd2F5cyB4ODYgYmFzZWQsIGluIHNob3J0IHBlcmlvZCBvZiB0 aW1lLA0KPiAtICJldmVyeW9uZSIgY2FuIGJ1aWxkL3B1c2ggdGhlIGNvbnRhaW5lcnMgb25jZSB0 aGVyZSBpcyBhIG5ldyBZb2N0byByZWxlYXNlDQo+IC0gc2xpZ2h0bHkgc2xvd2VyIENJIGJ1aWxk IHRpbWUNCj4gMikgQnVpbGQgYW5kIHJ1biB0aGVzZSBjb250YWluZXJzIGZvciBzcGVjaWZpYyBh cmNoaXRlY3R1cmVzOg0KPiAtIGFsbW9zdCBubyBnbyBmb3IgbG9jYWwgdXNlcnMgdXNpbmcgeDg2 IG1hY2hpbmUgKHVubGVzcyB1c2luZyBtb3JlIHRoYW4gMTYgdGhyZWFkcyAod2hpY2ggSSB1c2Vk KSBhbmQgd2lsbGluZyB0byB3YWl0IDIgZGF5cyBmb3IgdGhlIGJ1aWxkKQ0KPiAtIGZhc3RlciBD SSBidWlsZCB0aW1lIChhcm02NCBydW5uZXIgaXMgZmFzdGVyIHRoYW4geDg2IG9uZSkNCj4gLSBz b21lb25lIHdpdGggYXJtNjQgYmFzZWQgbWFjaGluZSAobm90IHRoYXQgY29tbW9uKSB3b3VsZCBo YXZlIHRvIGJ1aWxkIGFuZCBwdXNoIHRoZSBjb250YWluZXJzDQo+IDMpIFRyeSB0byB1c2UgQ0kg dG8gYnVpbGQgYW5kIHB1c2ggdGhlIGNvbnRhaW5lcnMgdG8gcmVnaXN0cnkNCj4gLSBpdCBjb3Vs ZCBiZSBwb3NzaWJsZSBidXQgd2hhdCBhYm91dCBsb2NhbCB1c2Vycw0KDQpJIG1pZ2h0IGhhdmUg YSBzb2x1dGlvbiA0Lg0KVGhlIGNvbnRhaW5lcnMgd2UgcHVzaGVkIHRvIGdpdGxhYiBhcmUgcHVi bGljbHkgYWNjZXNzaWJsZSA/DQpTaG91bGRu4oCZdCB3ZSBwdXNoIGJvdGggdmVyc2lvbnMgdGhl cmUgYW5kIHRoZW4gZG9jdW1lbnQgaG93IHNvbWVvbmUgY2FuIHJldHJpZXZlIGFuZCB1c2UgdGhv c2UgY29udGFpbmVycyBpbnN0ZWFkIG9mIGJ1aWxkaW5nIHRoZW0gPw0KDQpUaGlzIHdheSB3ZSB3 aWxsIGRvIHRoZSBwdXNoIGJ1dCBhIG5vcm1hbCB1c2VyIHdvdWxkIGp1c3QgcmV0cmlldmUgdGhl IGNvbnRhaW5lcnMgYW5kIHVzZSB0aGVtIHNvIGJ1aWxkaW5nIHRpbWUgd291bGQgaGF2ZSBsZXNz IGltcGFjdCBhbmQgd2UgY291bGQgYnVpbGQgYm90aCBmbGF2b3VycyBvZiB0aGUgY29udGFpbmVy cy4NCg0KPiANCj4gUmVnYXJkbGVzcyBvZiB3aGF0IHdlIGNob3NlLCB3ZSBuZWVkIHRvIGtlZXAg aW4gbWluZCB0aGF0IHRoZSBiaWdnZXN0IGFkdmFudGFnZSB0byB0aGUgWW9jdG8gYnVpbGQvcnVu IGlzIHRoYXQNCj4gaXQgYWxsb3dzL3Nob3VsZCBhbGxvdyBsb2NhbCB1c2VycyB0byBwZXJmb3Jt IGJhc2ljIHRlc3RpbmcgZm9yIGFsbCB0aGUgWGVuIHN1cHBvcnRlZCBhcmNoaXRlY3R1cmVzLiBU aGlzIGlzIGJlY2F1c2UNCj4gZXZlcnl0aGluZyBoYXBwZW5zIGluIG9uZSBwbGFjZSB3aXRoIG9u ZSBjb21tYW5kLg0KDQpBZ3JlZS4NCg0KQmVydHJhbmQNCg0KPiANCj4gfk1pY2hhbA0KDQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 08 09:23:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 09:23:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439800.693860 (Exim 4.92) (envelope-from ) id 1osKpB-0003Le-MK; Tue, 08 Nov 2022 09:23:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439800.693860; Tue, 08 Nov 2022 09:23:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osKpB-0003LX-JR; Tue, 08 Nov 2022 09:23:17 +0000 Received: by outflank-mailman (input) for mailman id 439800; Tue, 08 Nov 2022 09:23:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osKpA-0003LJ-Ai; Tue, 08 Nov 2022 09:23:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osKpA-0001FS-85; Tue, 08 Nov 2022 09:23:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osKp9-000603-RA; Tue, 08 Nov 2022 09:23:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osKp9-0002ED-Me; Tue, 08 Nov 2022 09:23:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=U+bjZ1dMhO7keUTvTO/i5KvPgshOjId6cju7BBV0INQ=; b=kUjwef6q/d9Gi1kLZWFIlc/j+X Ai3mgnLPU30ebtJs3lNseQ7vXNU0116AdMdO2Aah6jWpDqsLmi+T2smv9bGmBzu6PHF889OHSYx4X 3yd0iX0uwOA7mIk+Tokf+fOSwg4J+WoTFJKAUTauhESYh2GUdU0w/pL4EIbviFN57t/o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174663: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-arm64-arm64-libvirt-raw:xen-boot:fail:heisenbug xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e61a78981364925a43c9cc24dc77b62ff7b93c9f X-Osstest-Versions-That: xen=37f82facd62f720fdcec104f72f86b8c6c214820 From: osstest service owner Date: Tue, 08 Nov 2022 09:23:15 +0000 flight 174663 xen-unstable real [real] flight 174669 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174663/ http://logs.test-lab.xenproject.org/osstest/logs/174669/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-raw 8 xen-boot fail pass in 174669-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 174669 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 174669 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174652 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174652 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174652 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174652 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174652 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174652 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174652 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174652 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174652 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174652 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174652 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174652 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen e61a78981364925a43c9cc24dc77b62ff7b93c9f baseline version: xen 37f82facd62f720fdcec104f72f86b8c6c214820 Last test of basis 174652 2022-11-07 01:53:46 Z 1 days Testing same since 174663 2022-11-07 22:08:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Julien Grall Wei Chen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 37f82facd6..e61a789813 e61a78981364925a43c9cc24dc77b62ff7b93c9f -> master From xen-devel-bounces@lists.xenproject.org Tue Nov 08 09:26:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 09:26:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439807.693871 (Exim 4.92) (envelope-from ) id 1osKrz-0004Ae-4k; Tue, 08 Nov 2022 09:26:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439807.693871; Tue, 08 Nov 2022 09:26:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osKrz-0004AX-22; Tue, 08 Nov 2022 09:26:11 +0000 Received: by outflank-mailman (input) for mailman id 439807; Tue, 08 Nov 2022 09:26:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osKrw-0004AR-RM for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 09:26:09 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c645918-5f47-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 10:26:02 +0100 (CET) Received: from MN2PR20CA0050.namprd20.prod.outlook.com (2603:10b6:208:235::19) by DM4PR12MB6208.namprd12.prod.outlook.com (2603:10b6:8:a5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Tue, 8 Nov 2022 09:25:59 +0000 Received: from BL02EPF0000EE3E.namprd05.prod.outlook.com (2603:10b6:208:235:cafe::ec) by MN2PR20CA0050.outlook.office365.com (2603:10b6:208:235::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 09:25:59 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0000EE3E.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.11 via Frontend Transport; Tue, 8 Nov 2022 09:25:57 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 8 Nov 2022 03:25:55 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 8 Nov 2022 01:25:27 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Tue, 8 Nov 2022 03:25:26 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c645918-5f47-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O9k8zOUbsfiDDbV36XqkOguP/9Vv63O7OC0+VML39dqk8De0mMjU4i/LA0/A3g+Q5UClV7uT8Etux0LqbV9IQ8cLpc7Rzp5HA+4aoSPc8vepzCB2rjplorNSlpnoVDEMrz2S/bA3qmFPIYGL5snOZ6ftIXphRo+gVkdsdO2MqGbM0kQwB+EuMAI/SYGrsETk1DnCn3Su0coqy3X2PzBzKE0pzOSb21Xql+Yhza8NKzWKuHyhxpQ5JqqZLsOMYbXJO95um91y9uqV+4T3mR1rd0o6uhQn5wPuGTUo32esPUqJUmrxlou8gYljuKNCA+wg2u14uzlKVD88/u5JeZ8dDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J7Y0MyyARMq5DMZwJqAUPDAMgiVfUtjfsDipZCj8azI=; b=CBsJqb/pTK/WY/KVwDBU68M87eyUaBSTs6VVde/5dVlDRVpQpl8VtFCl8P+8YIoJ+ZFlKoSZq7BeoFlugJGhU9F9lvYUwJVxW118w0sR++UqzpbpfrR1zH7TGGlem7wNeNy1wGQ2FXG+ka2hyc05Yvzb7E8SIN3RnARHT5KtbYum8O+N6dvzcWyC3IwcgvshRZNTXsGacLUmcwAWQF73jtwazfkaAjowTrbuCJxuNTdAX6tLh6bOyLM+Zkt7+p/1UuUxpSHNrY1+q1ILvWSVlRizWLEeIpSYMSX1ibmzS15PUI186loFctPCFcLKT4+D304HqCsIvTX+GOFEMkujeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J7Y0MyyARMq5DMZwJqAUPDAMgiVfUtjfsDipZCj8azI=; b=QMNP9+mOUzpiHRVKb3MGoMFbwnQCK1Y135mEq3PASHwbJWspPFnWD+6Xu2JAaf99o9iUiFMoz3XY7r7vB8wXEqYYzbaSjr0fkefb7AoC1aKOwCtt/U7X/NXO8wQTnsajelvcqijNoRjD3ej4O3QDetZqV4NeluUNCrfvb8Sj8uM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Tue, 8 Nov 2022 10:25:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 0/4] Yocto Gitlab CI Content-Language: en-US To: Bertrand Marquis CC: Stefano Stabellini , "xen-devel@lists.xenproject.org" , "Doug Goldstein" References: <1220596a-4fe7-5c08-5437-fa98eb14254c@amd.com> <6ee0706b-d1b3-187a-1557-c4b8173c6e37@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0000EE3E:EE_|DM4PR12MB6208:EE_ X-MS-Office365-Filtering-Correlation-Id: b591c091-18af-402b-74c5-08dac16b3e57 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ybra6xpC3hC5SPCwhNw24gIsAuqrMEvDDziRvX+KGUR/BHaO3nV/2reiEO0iFxj8YC4NczqidTqKXCwnP5J9YB7u2gJ2Zi3QweVP1Xw7pE+cU50T8nOJmEEaPzRFp0BEZmn9XvqjcPxHlLP5bA6rLkSBQ0/QRbUwfbiBEb7E5FXGWPyu7xMNMcN+M5q2dqxoFIYvFABLjrrkE/okcRlfgcHV/lj6a3cg4/vgfTrvMGtkFDM8xLhRVEJ1O2vKk8eYyla3qJuKKF9JCNw6T9kfxhA812yRE1z/r5az43fT4MV2JYcJhEanlOtxLg2Z2tb99utbqW5XvBLVkxWmr7APzZLZI/ZPzpxqs9VsWH60wzwUTM2zN6ZuJVp7tjS26JcpzTcDPzEZVvy1vI9x2rzNZbB336bn5Y62CoxTInpXF7O+rhFOcDYF1nfPzapn/ECSpq1jWfRvpwJMbt3mch/oxpvG1zwaDoPCcpk49nCogt2cV7fshJ9qAgEpq02VYd9+TdpluTjqonKVj4mA/gXj1DyY8vYNIkKmEw6WtkhqAG/+qdyo33HkDf6yHbIm1GIIPez74S/CkCd5ljxkpRL11kD4QsqGY9V9BMlMUsUzzJpjwKRDs4Vp43YPppIUmnmHMGaQY2XNfQMAOevwIytL3MR6IEs+RImJWUAyPTgY8qdJ+Nd8IIHgfXjRu5R/LH0rMNlLtN3a+HLcBrQdF1yryAtyQyf5Kz1h0/7c8GEKm8VV6TrNejiYi4+vsG3GbW2ijf42BMXL81gAnDsU+yZLh95k3fRsJveJuwsoGGtfcBnnPHIZNFjCrEzR/209i3xPtzu7ek+JgGofEs/IGIYybuy4vil368Kv18YyVMX4OsQ1H9eA/b2xzVgo7hr1YapmaRHLlhwMI5gR1V4okS43Ag== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(376002)(346002)(451199015)(40470700004)(36840700001)(46966006)(70206006)(26005)(40480700001)(70586007)(44832011)(336012)(2616005)(4326008)(36756003)(8676002)(41300700001)(8936002)(186003)(5660300002)(53546011)(426003)(40460700003)(86362001)(31696002)(2906002)(36860700001)(83380400001)(47076005)(82310400005)(316002)(45080400002)(966005)(82740400003)(478600001)(31686004)(81166007)(356005)(54906003)(6916009)(16576012)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 09:25:57.7457 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b591c091-18af-402b-74c5-08dac16b3e57 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0000EE3E.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6208 Hi Bertrand, On 08/11/2022 09:42, Bertrand Marquis wrote: > > > Hi Michal, > >> On 7 Nov 2022, at 07:50, Michal Orzel wrote: >> >> Hi Bertrand and Stefano, >> >> On 31/10/2022 16:00, Bertrand Marquis wrote: >>> >>> >>> Hi Michal, >>> >>>> On 31 Oct 2022, at 14:39, Michal Orzel wrote: >>>> >>>> Hi Bertrand, >>>> >>>> On 31/10/2022 15:00, Bertrand Marquis wrote: >>>>> >>>>> >>>>> This patch series is a first attempt to check if we could use Yocto in >>>>> gitlab ci to build and run xen on qemu for arm, arm64 and x86. >>>>> >>>>> The first patch is creating a container with all elements required to >>>>> build Yocto, a checkout of the yocto layers required and an helper >>>>> script to build and run xen on qemu with yocto. >>>>> >>>>> The second patch is creating containers with a first build of yocto done >>>>> so that susbsequent build with those containers would only rebuild what >>>>> was changed and take the rest from the cache. >>>>> >>>>> The third patch is adding a way to easily clean locally created >>>>> containers. >>>>> >>>>> This is is mainly for discussion and sharing as there are still some >>>>> issues/problem to solve: >>>>> - building the qemu* containers can take several hours depending on the >>>>> network bandwith and computing power of the machine where those are >>>>> created >>>> This is not really an issue as the build of the containers occurs on the local >>>> machines before pushing them to registry. Also, building the containers >>>> will only be required for new Yocto releases. >>>> >>>>> - produced containers containing the cache have a size between 8 and >>>>> 12GB depending on the architecture. We might need to store the build >>>>> cache somewhere else to reduce the size. If we choose to have one >>>>> single image, the needed size is around 20GB and we need up to 40GB >>>>> during the build, which is why I splitted them. >>>>> - during the build and run, we use a bit more then 20GB of disk which is >>>>> over the allowed size in gitlab >>>> As we could see during v2 testing, we do not have any space restrictions >>>> on the Xen GitLab and I think we already decided to have the Yocto >>>> integrated into our CI. >>> >>> Right, I should have modified this chapter to be coherent with your latest tests. >>> Sorry for that. >>> >>>> >>>> I will do some testing and get back to you with results + review. >> I did some testing and here are the results: >> >> In the current form this series will fail when running CI because the Yocto containers >> are based on "From ubuntu:22.04" (there is no platform prefix), which means that the containers >> are built for the host architecture (in my case and in 99% of the cases of the local build it will >> be x86). In Gitlab we have 2 runners (arm64 and x86_64). This means that all the test jobs would need >> to specify x86_64 as a tag when keeping the current behavior. >> After I built all the containers on my x86 machine, I pushed them to registry and the pipeline was successful: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fmorzel%2Fxen-orzelmichal%2F-%2Fpipelines%2F686853939&data=05%7C01%7Cmichal.orzel%40amd.com%7C097e7825c8834c412e8008dac16526bf%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638034937437190896%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MNo1wYRgxehJ0SJOeGxNR6U%2Fd68zERPgYfLbpHya%2B2Y%3D&reserved=0 >> >> Here is the diff on patch no. 3 to make the series work (using x86 tag and small improvement to include needs: []): >> ``` >> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml >> index 5c620fefce59..52cccec6f904 100644 >> --- a/automation/gitlab-ci/test.yaml >> +++ b/automation/gitlab-ci/test.yaml >> @@ -65,6 +65,9 @@ >> paths: >> - 'logs/*' >> when: always >> + needs: [] >> + tags: >> + - x86_64 >> >> # Test jobs >> build-each-commit-gcc: >> @@ -206,19 +209,13 @@ yocto-qemuarm64: >> extends: .yocto-test >> variables: >> YOCTO_BOARD: qemuarm64 >> - tags: >> - - arm64 >> >> yocto-qemuarm: >> extends: .yocto-test >> variables: >> YOCTO_BOARD: qemuarm >> - tags: >> - - arm32 >> >> yocto-qemux86-64: >> extends: .yocto-test >> variables: >> YOCTO_BOARD: qemux86-64 >> - tags: >> - - x86_64 >> ``` >> >> Now, the logical way would be to build x86 yocto container for x86, arm64 for arm64 and arm32 on arm64 or x86. >> I tried building the container qemuarm64 specifying target arm64 on x86. After 15h, only 70% of the Yocto build >> was completed and there was an error with glibc (the local build of the container for the host arch takes on my machine max 2h). >> This enormous amount of time is due to the qemu docker emulation that happens behind the scenes (I checked on 2 different machines). >> >> So we have 3 solutions: >> 1) Build and run these containers for/on x86_64: >> - local users can build the containers on local machines that are almost always x86 based, in short period of time, >> - "everyone" can build/push the containers once there is a new Yocto release >> - slightly slower CI build time >> 2) Build and run these containers for specific architectures: >> - almost no go for local users using x86 machine (unless using more than 16 threads (which I used) and willing to wait 2 days for the build) >> - faster CI build time (arm64 runner is faster than x86 one) >> - someone with arm64 based machine (not that common) would have to build and push the containers >> 3) Try to use CI to build and push the containers to registry >> - it could be possible but what about local users > > I might have a solution 4. > The containers we pushed to gitlab are publicly accessible ? Yes, they are: https://gitlab.com/xen-project/xen/container_registry/3539006 > Shouldn’t we push both versions there and then document how someone can retrieve and use those containers instead of building them ? > WRT retrieving, we already have a section describing it under automation/build/README.md I'm not sure about pushing both versions to registry, due to the following: - occupying twice the same size (instead of 30GB per release we would have 60GB, imagine the size after a few years), - necessity to build twice the same containers for each release (someone would have to have access to both x86 and arm64 machines to do the build), - necessity to introduce different naming for containers (to differentiate the machine) where in fact, CI would always use one subset. We should not worry about the local users, because once the containers are in registry (no matter the platform they were built for), downloading the containers will take less time than building them. We will not benefit anything from having containers for different platforms. The only problem is with building them on x86 for arm64 (other way around is not supported by qemu-user-static). But this is something that may be problematic only for person willing to push to registry, because as you said, the normal users can pull them instead of build them. > This way we will do the push but a normal user would just retrieve the containers and use them so building time would have less impact and we could build both flavours of the containers. > >> >> Regardless of what we chose, we need to keep in mind that the biggest advantage to the Yocto build/run is that >> it allows/should allow local users to perform basic testing for all the Xen supported architectures. This is because >> everything happens in one place with one command. > > Agree. > > Bertrand > >> >> ~Michal > ~Michal From xen-devel-bounces@lists.xenproject.org Tue Nov 08 09:46:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 09:46:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439816.693882 (Exim 4.92) (envelope-from ) id 1osLBC-00076o-Si; Tue, 08 Nov 2022 09:46:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439816.693882; Tue, 08 Nov 2022 09:46:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osLBC-00076h-Ps; Tue, 08 Nov 2022 09:46:02 +0000 Received: by outflank-mailman (input) for mailman id 439816; Tue, 08 Nov 2022 09:46:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osLBB-00076b-Ly for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 09:46:01 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2063.outbound.protection.outlook.com [40.107.244.63]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 25830b8d-5f4a-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 10:45:59 +0100 (CET) Received: from BN6PR17CA0038.namprd17.prod.outlook.com (2603:10b6:405:75::27) by CY5PR12MB6597.namprd12.prod.outlook.com (2603:10b6:930:43::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Tue, 8 Nov 2022 09:45:55 +0000 Received: from BN8NAM11FT028.eop-nam11.prod.protection.outlook.com (2603:10b6:405:75:cafe::82) by BN6PR17CA0038.outlook.office365.com (2603:10b6:405:75::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Tue, 8 Nov 2022 09:45:54 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT028.mail.protection.outlook.com (10.13.176.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 09:45:54 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 8 Nov 2022 03:45:41 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 8 Nov 2022 01:45:07 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Tue, 8 Nov 2022 03:45:06 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25830b8d-5f4a-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KufQWCFB6USxsL32AOx3i0sr2CeCUE6OSe41FkbYy5Rp1h6E/7iDZjS/7L1dIe1mbHk1jTjOw/xOweO9R4WGWliXWfekYUuAVk7KZKewo90XM2TDaV7ix3d6SIKR/Bdtsl5+QSIkOY7Rn0qv82Fja+0FTbnSo81rG0VDqIklghK3sJeXj7nSBWEKoY3ZnG5LmIHoSXyYNcoponWEZUkWrjzQ9iXLgcrnKob8qJPmp3M76McAKtlMhtaJizvFhMef0xm71c9x3ggnBG27rpXAN+vpMVrRMi+FAIl/Yp36vS76Z1/B97xeE40Ez9Xa2OPxcLd1D0GTycqZd99nSDmfBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JjVJB5MYlDRfIruHI/1g6NGUyb/oTyRx5dUFFXbwFbM=; b=jg4Uj+7kGfbT2w2IomyHAtahUHXnYrejEikWmQ+2poOMWtA5NHavBc4q/nwbizcUiU43UtC7N1UI6k0dqSodh9nWiM0r66GjAHcZOi0zRne/x/tgctj0fg5gU01riQA1CBKFciLbmhUqb387LiXDC6wW+1uRgifsQtwyEvDrULrResxUuDNrJpmJaVWD6HSjYRY++mOpDu/BNax3/j4izQDD8IeB/MHGLA6mRplj+EXc5tEG9neK5IEW65UJt88xIkYy0qOfL3f9GJ0MRt4M579DWZN8lnzKvwv0yQpC5oA5TW1hZuY/yz8vmpMtBkK4sDZ4nVd7QxNmdy+aCpp6zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JjVJB5MYlDRfIruHI/1g6NGUyb/oTyRx5dUFFXbwFbM=; b=RaWwo9W7ox7Zuyu1BrtWGPNg1jofZEM0F7p77P2LkuredL8jWIY2t++Vc03oHVihryeb+KnCf3KvKQLHXvNOFpxsv/vmLzSXJKprJHHDm1FYDG0cQROEtmatLC8Stq3lWoTJGrqJ+PWcB0ESKBKpaf3m98dV0CPaRgtHIaFGVTw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , Ayan Kumar Halder , "Ayan Kumar Halder" Subject: [XEN v3] xen/arm: Enforce alignment check in debug build for {read, write}_atomic Date: Tue, 8 Nov 2022 09:45:03 +0000 Message-ID: <20221108094503.40253-1-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT028:EE_|CY5PR12MB6597:EE_ X-MS-Office365-Filtering-Correlation-Id: 94d9b8c3-c6e2-41c0-43dc-08dac16e0794 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DhsWffgQt47YUFWNgZfB0sAfBUKUpxx8J/vMKNw1D+87yYWemMhuN+LGLvCUSKDZ2oQ8aT6XitSietfoMEFgXCea6PBslScEwH0klr8GnAWq8emd+bKmf08P3S4wrVZD6VUcfD7BejaBObtp9fi/YeWV6BH3u9oDb/XAk4HVxvS6cn5z67sWawmA35j6S6lupUrkkumItZhG7oud6A1Q/ZSVf8mgzzU/Y319xxPCKeT+0PnyCJJUHpy7FVHeALI9/ByncerQjOHCHQ5drZlnOPDCRZUuMbCh4lsF0BY91wBDC7PwZ36IRfX3IC6CE6g51PRtYysCKOx2zS8h1M3DxcF0Pe/ed+iUdQijxMPN4dLA4ypDL8njHaR0L9k35K1L5fLezv1ez1P2sSIHXq9vrQSJ8IEuNVTwRbQH+dFkM/2uEdSSc+ZT7Ztzh/VpKeJPCu/EqxCkn+xQ7PqI2dDExRQWhp9NKRe5Zh/PDbtMNmKgyzdCQ4Yvoni5avbEJ1aGvyy1Z+ASEhDtsYd5DCxHoD3pPZ2Kpl/bdB5bjY/3lOAwz9W9oPPuEgUZpRuh2n5ajgudflqSeB/kAhSZZLaU5q89qgPOjG8MVV0A2A5TMKY2feR9/HTSGtcKagMAQ+cBnRMpcLkSNkZF0OX+RccVmFbUN+c6CoBxqRWi2PhMjnfcqS1bIKvjBNqFOBMnuAOp3i+WEfBGXrmOOTsY9FfsRQLJ/Or55F0W0KqkgRZbpdQS80qUFdDS+q+ZO17Wmw/pmMtZtH7ZPRiRJfidWgCeCOSrWqAPkd16yjsw2fsepgk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(136003)(451199015)(46966006)(40470700004)(36840700001)(103116003)(86362001)(36756003)(81166007)(82740400003)(40480700001)(40460700003)(2906002)(8936002)(83380400001)(2616005)(1076003)(6666004)(186003)(336012)(47076005)(26005)(426003)(36860700001)(478600001)(6916009)(70206006)(54906003)(5660300002)(316002)(41300700001)(70586007)(8676002)(356005)(4326008)(82310400005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 09:45:54.2817 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94d9b8c3-c6e2-41c0-43dc-08dac16e0794 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT028.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6597 From: Ayan Kumar Halder Xen provides helper to atomically read/write memory (see {read, write}_atomic()). Those helpers can only work if the address is aligned to the size of the access (see B2.2.1 ARM DDI 08476I.a). On Arm32, the alignment is already enforced by the processor because HSCTLR.A bit is set (it enforce alignment for every access). For Arm64, this bit is not set because memcpy()/memset() can use unaligned access for performance reason (the implementation is taken from the Cortex library). To avoid any overhead in production build, the alignment will only be checked using an ASSERT. Note that it might be possible to do it in production build using the acquire/exclusive version of load/store. But this is left to a follow-up (if wanted). Signed-off-by: Ayan Kumar Halder Signed-off-by: Julien Grall Reviewed-by: Michal Orzel Reviewed-by: Bertrand Marquis --- Changes from :- v1 - 1. Referred to the latest Arm Architecture Reference Manual in the commit message. v2 - 1. Updated commit message to specify the reason for using ASSERT(). 2. Added Julien's SoB. xen/arch/arm/include/asm/atomic.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h index 1f60c28b1b..64314d59b3 100644 --- a/xen/arch/arm/include/asm/atomic.h +++ b/xen/arch/arm/include/asm/atomic.h @@ -78,6 +78,7 @@ static always_inline void read_atomic_size(const volatile void *p, void *res, unsigned int size) { + ASSERT(IS_ALIGNED((vaddr_t)p, size)); switch ( size ) { case 1: @@ -102,6 +103,7 @@ static always_inline void write_atomic_size(volatile void *p, void *val, unsigned int size) { + ASSERT(IS_ALIGNED((vaddr_t)p, size)); switch ( size ) { case 1: -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 09:48:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 09:48:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439821.693893 (Exim 4.92) (envelope-from ) id 1osLDf-0007fT-A7; Tue, 08 Nov 2022 09:48:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439821.693893; Tue, 08 Nov 2022 09:48:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osLDf-0007fM-7H; Tue, 08 Nov 2022 09:48:35 +0000 Received: by outflank-mailman (input) for mailman id 439821; Tue, 08 Nov 2022 09:48:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osLDe-0007fG-7G for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 09:48:34 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2057.outbound.protection.outlook.com [40.107.95.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 810cd03d-5f4a-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 10:48:32 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by MW3PR12MB4556.namprd12.prod.outlook.com (2603:10b6:303:52::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Tue, 8 Nov 2022 09:48:28 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5791.026; Tue, 8 Nov 2022 09:48:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 810cd03d-5f4a-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4WgI+C7toWgZGHeDXO0Yhemqx9kmS75ePyzVrPGzYWSYHZ7osBT4P0s34qJYkY5UQdBQo+wmKUCYz+gKiWbLKwYSU8L0ZNpmukGoxcNDm652NoHcrMng51qLHVA03xBKYh5GzH7VdsxOtLA2g9UhB4qqFMeKjVDlIhIXEqVYY2c7gN7xt0fmU3Th12t0pcC84D5vUXJ1jTqeZ3Yc+WGHTQI5CTNmjW6bHM95LI49V8mq6VbYcMeAZ2bSaLg6pXpJ4GsWNwMjwvVXsO5uR6hyyK8j4DIKJ/7MXQ3UKBEY8Tfv0nYA0JMQ++FOQix5JK0xWfmAJWhm+nRWdWAZdnA/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aZHuaY6YEGRIHh0N1jse2Emh590S4dEyCSej+mYQC6M=; b=jqjDmYjaXMK4VEdTGQnDCAowtUhCbQLQAjujJG3nVKdBjNrq40gkcKMIFUc+ZMfAhDWF60ZzktPmHlnczRHRoqRskAqaNlnfR5aUNamzDnVWEOqhGQvcPgDglDBVCxolVbh3gYk7QshuUeLHf0y1MR5YSJ+KMxh+/SHQXS8pfeZ0y3DEYlbPFfTVUjd7V9vAafNkRaLzewpcfWBfX6UG47klqaeiH3hyB5qAuWT/rEH2b8JLZXAB8laE6xB4Lh7SIbDSwoEXa+vJkRzQAv52yVzv1Fa++QnCFjkWFFoXay9xTdNYWnVk9PRcXsS6DedfxkbesREh6sW7alFiAL6n2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aZHuaY6YEGRIHh0N1jse2Emh590S4dEyCSej+mYQC6M=; b=ylgEIM9WjphiPyzofA+Q55UjrLVbKVQNRc9p586YDEfikhf2/VR3XSO5Mp3Xcmi3xAiYYHk46XLMvcscgX2WL+XFGmyc7ZrgcP38as78lp0oMs4Fen/vzDTgO7qgK0VpPaQO2a7eRpGq0jYmfceKVdPKn3klcNhLbUBFtNk0ms8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <31497aff-5b94-3df8-9c15-7340cf6a46b5@amd.com> Date: Tue, 8 Nov 2022 09:48:21 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write To: Bertrand Marquis , Michal Orzel Cc: Julien Grall , Ayan Kumar Halder , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" , "stefanos@xilinx.com" , "Volodymyr_Babchuk@epam.com" References: <20221104162355.23369-1-ayan.kumar.halder@amd.com> <062c9507-7744-0742-effb-76d2f1222a27@xen.org> <33a2d125-b7f2-3637-9dab-6b7d616fd4ff@amd.com> <36e84512-9b44-303e-2834-5aafe9c6cc15@amd.com> <74b1c6af-d6de-2728-9d59-2d561a521793@xen.org> <3720a691-3303-a673-58b6-95da9a4341d2@amd.com> <211D65B7-2CCD-4BDD-A9A3-FF4DF9D562AC@arm.com> From: Ayan Kumar Halder In-Reply-To: <211D65B7-2CCD-4BDD-A9A3-FF4DF9D562AC@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0273.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::21) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|MW3PR12MB4556:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ceff707-425a-4f96-1b02-08dac16e62cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eDBvQJuxzF1slrimXlzIA0aW4/sFiI1j0K41N4WhJe8C9refoAw2y4/qb0fracVwrp8PBEgQTst0FjzzuK/CVzONtD/UeRADLNTqFjLPsT66nSVY+v5wp56BydALRb6eJXvZMsF7Tt3dxl2/i6KWqkXZA2PixaJJMOz46kfJnQQ73gLkm1ICGFQBN0Q/Vv7QFGKEzqyUo8ZR3xmp7HITRDxQlGebu8bueEdlQALGIB+xHeT9Kod5gn9sPzNzqRb6B4MkUHBPzZ2+dYjdR5rR9OxZQ0AejyKa1R0Uv1FQCqzeUGlZZlLjXZoRlN/PIUc99IQaOlqQxrzKAURzdqDVJZSq78IbQ3xO3E3kjVk8wwHS55rwiwo5E0/v6mYC8DUi6sAox7wM2LENXUHXKZ0gCwSZmYYxTLCZfvIiWZHNeZquxlyOBFmoEKMw/qw44qqJ+I8PWNQLNY6k1dWeZnFFEoG5aJmi3VUdITqd0tNwAZETjb0CX92/Slui++Yr6TFjhbnYROv6JZ/MsH+FlqpSWGf/w2SuPhPhNe20wjo1tH0ug+Nsq+9tyySASUb4iTTu+ZIBijyISu/x7ON57iUEGWzM9LufBVT4MSzObwQI4m+c9mgxnhZgZ41LhIb2SS7cDFqGPF+BBwY3wNSnGZdw8tM9xau1QIJ4OdgiSbTjmpxFAV7odjfxG9JvDu1xbiMCLi/R9uW/BNNY/akfbLl8Ga34+aI63UaavwleSE7CMajO92IXvN87UxPTotlA6RuaPisloLEN9TTcspSMYr3mgNt6VvRC7bXd5Q29BQKjAKA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(39860400002)(376002)(346002)(451199015)(41300700001)(83380400001)(8936002)(6636002)(186003)(316002)(54906003)(110136005)(36756003)(8676002)(66556008)(2616005)(66476007)(38100700002)(66946007)(4326008)(5660300002)(2906002)(31696002)(6506007)(31686004)(6666004)(53546011)(478600001)(6486002)(26005)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Lzg3MFZwM2V5bjA2cjdRNzcxbFYza2ZjaXcvdzRvVXV4dlpMa3F2MzVRMFJD?= =?utf-8?B?cHVCUm11a2lteVZ5QU44ckVPMjZwSG1sR1g0QTA0Mjdud2dIbXNtU2VVN3lu?= =?utf-8?B?eHlDcGdLZUkrUytmNVBKUDV1eWpHUUhjRTJ3Zm52bXhuenBGaFpUbTJmcDNE?= =?utf-8?B?Y0RxU2RWYTB0cU1xR3BPR0FTb1hOMEd1aXM1UjN4clNSeS9pRUE0c3gxbG1n?= =?utf-8?B?WVhPZXBNNkoxOEpMUWJ5c1ZwTUM5U0dIcGlISnlSNWlIM2txSm1qOGQ5Z2NL?= =?utf-8?B?UFJrOFdpL2g0QzMrSmV0b3k3cElKcXpIZEoxdEdOaTZFNmlKY0FqK1A2ZUE0?= =?utf-8?B?Q0t4VUpIUWplT1dNbkx5MUptL3FDNXVKTDhJei80ckZBemt0MU9UVTQ2L0c1?= =?utf-8?B?c3dXRVhYM1ZWc2tXVWpsZjVMOGFhSXRjYThmeVRmUHltNnlJS1JERENTNG90?= =?utf-8?B?MEVVbktGK2NWL0hZUGwvcmpwZllKby96RGhqUEhjVXNneWJIYzJGSWxQeU1k?= =?utf-8?B?MU0yOWJtQnMzaDZjS2U3cUxTYVRYTTg1cEtsZTNVS1V2YnBrWk5qcjJoM3JF?= =?utf-8?B?L1pobU1UUGZ6TGYwMkZBaTY1VGZmUjRNRUEyZ1A4eTFrRTB4R0ZOdm1HaEt3?= =?utf-8?B?TG1NTjJqVURKRUdpVVFCQjI2K2V4OWt3MVkycDNnTWdFL2VoL2ZoaGpuUnFO?= =?utf-8?B?WlBFWWhVeUVRL3JOTjU4bXJRZkNtTXV0M2Z1cUZ6dlA2L21LUnQwd0FFeDJp?= =?utf-8?B?dEFrZWtSeW0zYThKaEZwMnhRN2ZyUjcvZ3RDSm8rTUJrMHpLdFdwSXRKUEFS?= =?utf-8?B?M1MyZnRBNkQrZno1Z1JjUHpKZXY3anVXcURlTVRSVi9XeEt5emwxTEpER3do?= =?utf-8?B?TWszbGVsZEZjTHhWRmJBNW1DdkVPUjdaRi9qUVNIN2c3YVpBUVFlaWZOUDFs?= =?utf-8?B?T0NwYi9tVDlYUG1Ua0RIY0pmNXhGL0FhNzJieWVnMTIxZEpOdi9NaG14VXlP?= =?utf-8?B?Y1JRUDRXZ2pGQXhacVRRWDhMOGdjNms4aEpXUU0xOXJMQlIvSmVJZkl5Z2tx?= =?utf-8?B?MmpQWWxFQktNUldIN2tISXFEVEZmZmlheXE0N0ducmtmWjc2UTNyTlVXQUVm?= =?utf-8?B?dkhrTVgxN083RGJsYUlrVC9GZHBOK21zTVcxbU1zbk41TW5nN3ZlQm1FOXha?= =?utf-8?B?aXlYVWxvNm1NWHVTZ2VHZVFDSDZJeU1aUXR1VXBSQ002VGltUHhhd2lHQ283?= =?utf-8?B?Q1I2a21uclp2NGxTbXJVSjc4YWp2ZmQ0VFpRVjhkMmkzS3p5ZVVCY1lySzFp?= =?utf-8?B?WmVaYm9OSjZvK1FTbEp2bDJUeVIxbWVlOHFWanlaVjBSSnpRWkFQNWJlLzBu?= =?utf-8?B?bW1hYTBpWFFWMVg5ZzBxd0lBRkk3a1JZdFJPbDZsd0IwYkozT040ZDcxNU81?= =?utf-8?B?Q3FkWjYxVU1KZjh1ZkZhT29KcGFuVzh3TGVQQ3hLQ1pNaHYvTHdMNFIyM04w?= =?utf-8?B?NElkN0h2bGJMaVZESDZSOWx4bDR2VURoQmd5Z0ZnS0NvZGhUcGdGUTBUd0x3?= =?utf-8?B?WmtpT2l3R0RlWXB6bWR0UDV4eUZrOXhnV1BQTEJSd04xbEdnNUEzVE03bkdH?= =?utf-8?B?SXl3aXNmWXlicUZJT0liQVRJWDJCai9VTXBET2dsN1BLSkZFdUQ4TjV6Nmw4?= =?utf-8?B?TVBnWURCRkZLRTd4eGhNKzM5R1E3b3JLU0Uzek5wZzdheEhkUVUvclFwOTFO?= =?utf-8?B?eFRsdERUb1gwZGxMTU9CQnVmWlhsbEhIQkkycVFzTlFQUnFJNHd3cHVQSDdC?= =?utf-8?B?MVM4ZXdDRmc2ZVFaaXJpOHpyMVRJZ0ZROHZENURYc1o5QTBtYlBZVVZhSzdD?= =?utf-8?B?eFRSOFhsVTJzeG5BV3R6amgxWjFQTjUvNi9qTFE2T0piUUhKUG80K0psa3dm?= =?utf-8?B?RkdQc1pvdC9jWmVvN1AwMXhtYmlnU1FQWXZOb1JQUTVMZ3U4OHdhZk01YmNW?= =?utf-8?B?c0VNTnpmOUcwTEZvY25CR3UwcGJDcmVaZWdVUkZrRHc3NnBRMDdIaFRlQ1JU?= =?utf-8?B?bmlGNCtuOFJhVHY2bFlQZlJSUWY1RHdsclZpZXpzTVl6WkVKNVNPWThsc0d0?= =?utf-8?Q?OUGYeGacn/DixRJKmWnLeUlGA?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ceff707-425a-4f96-1b02-08dac16e62cf X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 09:48:27.6993 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 893IS4QRqDwUtVVvO9gIndpaeDkAfSXbfhosJarWK6cbjZ4iLSGzhqIjroUqb982K6fbJzYewS4THTRT+FyEIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4556 On 08/11/2022 08:34, Bertrand Marquis wrote: > Hi, Hi Julien/Bertrand/Michal, > >> On 8 Nov 2022, at 07:26, Michal Orzel wrote: >> >> Hi Julien, >> >> On 07/11/2022 19:06, Julien Grall wrote: >>> >>> Hi Ayan, >>> >>> On 07/11/2022 12:49, Ayan Kumar Halder wrote: >>>> On 07/11/2022 10:44, Julien Grall wrote: >>>>> Hi Ayan, >>>> Hi Julien, >>>>> On 07/11/2022 10:36, Ayan Kumar Halder wrote: >>>>>> On 06/11/2022 17:54, Julien Grall wrote: >>>>>>> Hi Ayan, >>>>>> Hi Julien, >>>>>> >>>>>> I need some clarification. >>>>>> >>>>>>> To me the title and the explaination below suggests... >>>>>>> >>>>>>> On 04/11/2022 16:23, Ayan Kumar Halder wrote: >>>>>>>> From: Ayan Kumar Halder >>>>>>>> >>>>>>>> Refer ARM DDI 0487I.a ID081822, B2.2.1 >>>>>>>> "Requirements for single-copy atomicity >>>>>>>> >>>>>>>> - A read that is generated by a load instruction that loads a single >>>>>>>> general-purpose register and is aligned to the size of the read in the >>>>>>>> instruction is single-copy atomic. >>>>>>>> >>>>>>>> -A write that is generated by a store instruction that stores a single >>>>>>>> general-purpose register and is aligned to the size of the write in >>>>>>>> the >>>>>>>> instruction is single-copy atomic" >>>>>>>> >>>>>>>> On AArch32, the alignment check is enabled at boot time by setting >>>>>>>> HSCTLR.A bit. >>>>>>>> ("HSCTLR, Hyp System Control Register"). >>>>>>>> However in AArch64, alignment check is not enabled at boot time. >>>>>>> ... you want to enable the alignment check on AArch64 always. >>>>>> I want to enable alignment check *only* for atomic access. >>>>>> >>>>>> May be I should remove this line --> "However in AArch64, alignment >>>>>> check is not enabled at boot time.". >>>>>> >>>>>>> However, this is not possible to do because memcpy() is using >>>>>>> unaligned access. >>>>>> This is a non atomic access. So the commit does not apply here. >>>>> Right, but your commit message refers to the alignment check on arm32. >>>>> You wrote too much for someone to wonder but not enough to explain why >>>>> we can't enable the alignment check on arm64. >>>>> >>>>>>> I think the commit message/title should clarify that the check is >>>>>>> *only* done during debug build. IOW, there are no enforcement in >>>>>>> producation build. >>>>>> AFAICS read_atomic()/write_atomic() is enabled during non debug >>>>>> builds (ie CONFIG_DEBUG=n) as well. >>>>> My point was that ASSERT() is a NOP in production build. So you >>>>> effectively the enforcement happens only in debug build. >>>>> >>>>> IOW, unless you test exhaustively with a debug build, you may never >>>>> notice that the access was not atomic. >>>> This makes sense. >>>> >>>> Does the following commit message look better ? >>>> >>>> xen/Arm: Enforce alignment check for atomic read/write >>> title: >>> >>> xen/arm: Enforce alignment check in debug build for {read, write}_atomic >>> >>>> Refer ARM DDI 0487I.a ID081822, B2.2.1 >>>> "Requirements for single-copy atomicity >>>> >>>> - A read that is generated by a load instruction that loads a single >>>> general-purpose register and is aligned to the size of the read in the >>>> instruction is single-copy atomic. >>>> >>>> -A write that is generated by a store instruction that stores a single >>>> general-purpose register and is aligned to the size of the write in the >>>> instruction is single-copy atomic" >>>> >>>> Thus, one needs to check for alignment when performing atomic operations. >>>> However, as ASSERT() are disabled in production builds, so one needs to >>> This seems to be a bit out of context because you don't really explain >>> that ASSERT() would be used. Also... >>> >>>> run the debug builds to catch any unaligned access during atomic >>>> operations. >>>> Enforcing alignment checks during production build has quite a high >>>> overhead. >>>> >>>> On AArch32, the alignment check is enabled at boot time by setting >>>> HSCTLR.A bit. >>>> ("HSCTLR, Hyp System Control Register"). >>>> However, on AArch64, memcpy()/memset() may be used on 64bit unaligned >>>> addresses. >>>> Thus, one does not wish to enable alignment check at boot time. >>> ... to me this paragraph should be first because this explained why we >>> can't check in production. So how about the following commit message: >>> >>> " >>> xen/arm: Enforce alignment check in debug build for {read, write}_atomic >>> >>> Xen provides helper to atomically read/write memory (see {read, >>> write}_atomic()). Those helpers can only work if the address is aligned >>> to the size of the access (see B2.2.1 ARM DDI 08476I.a). >>> >>> On Arm32, the alignment is already enforced by the processor because >>> HSCTLR.A bit is set (it enforce alignment for every access). For Arm64, >>> this bit is not set because memcpy()/memset() can use unaligned access >>> for performance reason (the implementation is taken from the Cortex >>> library). >>> >>> To avoid any overhead in production build, the alignment will only be >>> checked using an ASSERT. Note that it might be possible to do it in >>> production build using the acquire/exclusive version of load/store. But >>> this is left to a follow-up (if wanted). >>> " >> This reads very well. >> >>> While trying to find a justification for the debug version. I was >>> wondering whether we could actually use the acquire or exclusive >>> version. I am not entirely sure about the overhead. >>> >>>> Signed-off-by: Ayan Kumar Halder >>>> Reviewed-by: Michal Orzel >>>> Reviewed-by: Bertrand Marquis >>>> >>>> I think I can keep R-b as there is no code change ? >>> My signed-off-by will need to be added for the commit message I proposed >>> above. So I would like Bertrand/Michal to confirm they are happy with it >>> (I don't usually add my reviewed-by/acked-by for patch where my >>> signed-off-by is added). >>> >> You can keep my Rb and Bertrand or Stefano can ack it, so that we can avoid >> acking a patch by one of the authors. > I will check and ack the v3 once out. Many thanks for this. I have sent out "[XEN v3] xen/arm: Enforce alignment check in debug build for {read, write}_atomic" - Ayan > > Cheers > Bertrand > >>> Cheers, >>> >>> -- >>> Julien Grall >> ~Michal From xen-devel-bounces@lists.xenproject.org Tue Nov 08 10:03:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 10:03:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439829.693904 (Exim 4.92) (envelope-from ) id 1osLS1-0001tR-IW; Tue, 08 Nov 2022 10:03:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439829.693904; Tue, 08 Nov 2022 10:03:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osLS1-0001tK-FE; Tue, 08 Nov 2022 10:03:25 +0000 Received: by outflank-mailman (input) for mailman id 439829; Tue, 08 Nov 2022 10:03:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osLRz-0001tE-JU for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 10:03:23 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 91b55eee-5f4c-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 11:03:20 +0100 (CET) Received: from mail-dm6nam10lp2105.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Nov 2022 05:03:17 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by CH2PR03MB5334.namprd03.prod.outlook.com (2603:10b6:610:92::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Tue, 8 Nov 2022 10:03:15 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.025; Tue, 8 Nov 2022 10:03:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91b55eee-5f4c-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667901800; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=UKrkgbvJjhs/s0GTACIj+3gmYp8FnnnYrb+25O5DyoM=; b=GZ57iQTSY4Pd7RNTzal9gQirwiOBS7kD+y/qrLVd9g3fF3KCYKjXjqto OX/Jrx14FLnV2B0fu/X78UUmDdXxYikaHUFTXe1CELXT3MV/clEKO+i9j jIeEW8PMWR3Altx/ga02ZvW+iFePd5BK4drMH2SABPJC76K4VYv+KjIRb o=; X-IronPort-RemoteIP: 104.47.58.105 X-IronPort-MID: 84390988 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xugPeKkYu08au3paY4IG/F7o5gx9J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIZXDqPb6uIZGTze4slOt7j808P7JbVyYIxTAJt/n01FyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5A+GzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 dsSIWgcSy7bvuf18KChbPR1qv55Pta+aevzulk4pd3YJdAPZMmbBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3ieCwWDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnzX+gCdpDRO3QGvhCiQat4UVIVg8sDVKJj8S1rF+4YsMAA hlBksYphe1onKCxdfHtVhG5pXGCvx00VN9ZEul84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YVKQ8K2F6wy7Pyc9JHUHIyQDSGMt/N3LsIw1yBXVQb5LEqS4k9n0EjHY2 C2RoW41gLB7pcwW0eO99FPOgTOpr7DISBI44kPcWWfNxgB0eo+jIZCp4F7z7PBcIYLfRV6E1 EXogOCb5eEKSJ2IyiqERbxVGKnzvq7YdjrBnVRoAp8tsSy3/GKudpxR5zc4I1p1NsEDenniZ 0q7VR5t2aK/9UCCNcdfC79dwex2pUQ8PbwJjszpU+c= IronPort-HdrOrdr: A9a23:pHBTOK5xvIMXMBbGhQPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A37gZJPh8sH7eGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC P4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR4Xue iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqWneXJABYBT+ZRj4NQdRXUr2A6ustn7a 5N12WF87JKEBLphk3Glpf1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI BVfY3hDc5tABKnhk3izylSKITGZAVxIv7GeDlOhiWt6UkZoJgjpHFohvD2nR87hecAotd/lq H5259T5cFzp/8tHNxA7dg6MLqK40z2MGXx2TGpUCLaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd L6IRlliVI= X-IronPort-AV: E=Sophos;i="5.96,147,1665460800"; d="scan'208";a="84390988" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L+pP1F7wfgbgpeZlQ1XMAlFNeWM/5tP0wO9iod/e8LmeqsMfJQFOOdNbg3casEq5wvZpoGcFE3L3Xji70Z89U2ZZvrTaOLR3ddGb84FkWDQcC/L6zUcEYg1WfJBlDi7qkTCOl29bgPtX/TSE/J34+OIctLvrs4I3Ulmy1N0HMVqGAt4tf3FmkOKUIjvmO63fAtSRUnGFBeJ6Acojvrimk/OpDY4mzdR9nKCQ62bxAYm5180kSHphieLfeCB5Kcb3Sv6Yf5UqcG6Htv7A7ElsI5EVSYtnn8e6DfTC0GunofLxQWofMWZpqAJpzIhHbb7Kn/ldKvuTgq+ABvHBUWmS2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aooQ3uriuBZ1XS8ErDJpsLsMEgoeYZYtKG86JL2P+zg=; b=f2KzYAsxffCvgqgQKl9wH6WPu5frI4n5ZRg9XDgX42ZPhmxaZNtxr0LE8MTtdyNNyy37KVXU1ubguDfFOVMrkwYUzJ2M0vpbl0i0/NB96IuHHdjMG4zU1WG25R7RKxsljdoMfOln8g/v/up3ojbTjBJ/6OkKK8/Q4VqEYM7E1EkuLGa4i9S5zt8QaZp743g7cdnTZ7oa542+swnvKXwjtV4GEOIoltMX34nya5jhj1T1lvg9NjfMJUkvZWA2XR4YywWEF/QTSVibURGYcMYgcVgAIFSSvqzlxcnVyO50Rag2hakYIQ2mHBEjQpnTgFE4gcsKJmbFPQB46zxNcerLcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aooQ3uriuBZ1XS8ErDJpsLsMEgoeYZYtKG86JL2P+zg=; b=f39IHup2TXWacsyH2+QNPJS2YXafiTWPeIMk9NldDtTaqGLd8UPpYsXc0pXJB7mkeYTzbuAUZZQNclaBs//XFkSYtthzmyDCo90ACMQIFLXa9Ux+wEYWNNRjGuFwjbvJIIjWIxCljt2QvDIjwut8aNZJ83JBb84eJXpO4d1d738= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 8 Nov 2022 11:03:09 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Paul Durrant Cc: xen-devel@lists.xenproject.org, Henry.Wang@arm.com, Wei Liu , Jan Beulich , Andrew Cooper , Jun Nakajima , Kevin Tian Subject: Re: [PATCH for-4.17 2/2] hvm/apic: repurpose the reporting of the APIC assist options Message-ID: References: <20221104142235.36556-1-roger.pau@citrix.com> <20221104142235.36556-3-roger.pau@citrix.com> <2a3c5141-516d-a5e4-392b-e7fe54f3781c@xen.org> <9a505567-57be-a7b4-7cab-d1d737172db0@xen.org> <2c2d8b2b-e607-6d9d-b991-d1c065aac95d@xen.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2c2d8b2b-e607-6d9d-b991-d1c065aac95d@xen.org> X-ClientProxiedBy: LO4P123CA0295.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::12) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|CH2PR03MB5334:EE_ X-MS-Office365-Filtering-Correlation-Id: c8157972-fe00-428d-80a7-08dac170739d X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ow2GYPpNf1oExl6wZaRL43+771lLIM4OIxQo8qHTaoERG0nV0gU826iUCdUeWqJBuRP+a14fWfO+3kZUD/GEP+sPW+VxaOCDq3v1BKdahfQRc0G01kiNJ09G5Nx9ll9q57KquCD3FG3NN0VEZ/fKT99/Avm3rf8vHEgu8ntGMPhLJJVU56eU3vrPgjMGd5XTbF4CR/W8TQnkarOWxTkC3xzhBdLwfohhDBok4Dg8f7yetI3u6jYj1oDlNQyB0i8BwnKhFYLlz7TSlE/aPlAMM8ba+k5F10xvTo3Fm+ym+DRGp0R5iUwQM9DyTWLyhd7qYvV4B4D7du2mtzIvBbdhNu6yPMZKVcq9bFDmkn1cd79HLcLDRyoXJfKGiHCiKh7utW6JSsAKPFpXCzq/AzL3SRfOUONKUbL/db++STRk0rLs/wBjVhsgQcYeUJkIY91+TGnXroLZNelzsLjTHloLdSUxyS2V7yov+/5+JX088UELtDhpHV8ZGbSldhPZaDM55fK7XFSkV8p94SwQqSTjoC+dk8k3i/PsiTCKyIkJzz+ABgyy7D6sou1A9wsUY5Nn7ySZW3IA45HXhNxUId/T0x0Dyor7QWvrouVEvvOKXTLVWK9XDS4Se1WUChZC20ueQOTAXb78U5Ho5kdnvJBXeAaNR6TrpaHU1/FngZg4fWochiiP/jkW9ad4l1rB6SGvRoPJM7RQmdipn7l6mDre/vYP1uaA5K0RJW0iFcaOljsbwVk14wPu5UBWoO4i+nkv X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199015)(86362001)(85182001)(66556008)(38100700002)(8936002)(5660300002)(2906002)(186003)(26005)(83380400001)(6512007)(82960400001)(9686003)(316002)(4326008)(54906003)(66946007)(8676002)(66476007)(41300700001)(6916009)(6666004)(33716001)(53546011)(478600001)(6486002)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGxVU2lyRDNYOGZ3eWJXVGVQcDhrSHZpeVJmVi9RSVVidTh4ekpkbndOOTEr?= =?utf-8?B?WU5QR1JmL2pYTXJlLzFpR0NzUjhnY0tsR3RPV0NUYXREck5qc29lTit1d0lC?= =?utf-8?B?R29KNmkrQ2tMZjcyRWpoZk1Xb1d6UVc5YzVEY1NsL2RmVm9SazZvelZIMDFy?= =?utf-8?B?TmdRS1FZeDYwMVd3eWNTU0xnSzhibTJnVUFIczhKMGRHbXFxUlJTNUtHd2dp?= =?utf-8?B?MEsycnI2Q29mU0NZMlRBZkVFM0JSZDRiOFhUeFVXTnUzeEpJMk5PNXJjMVVr?= =?utf-8?B?OEpPN1dqYmUxeHhXbHVCeHdIS2R6aVFZbExXR3U0RVBtMkN3ckhhbWhpTStK?= =?utf-8?B?QzJDUUpISjkxbEZSZW9pM0VmQ3NxTXYxMEZuZWxHSW9JNGE4cnk5MlNMZytV?= =?utf-8?B?YTROeWF2cnVTQ0FzNEtOODJoUjhyeW9zaUNQVEV4NDV1a0FxZCtKVWw1Y01G?= =?utf-8?B?VUVmaEhtakl1Yi9tMUVsKzVhK1ZRQ2thZ2lpbitjMlFiRGtFRlk4OUp2YmxT?= =?utf-8?B?MU9vSVQwSzJRQlNnVGh3R1B2VjlzY3g4NHZGVDAySk51U1JLY1AwcGNJYUxP?= =?utf-8?B?TkxLRWV0NzYwTHpwcWhJYVdBaFp5cFBsc1J2b1htc2U2aW5QNFV2UWFuVGJN?= =?utf-8?B?T1VjbzdXbWZTd25IT295dHArc0ZLanU0YzVGVkFpTzJ4WlZ3RDJVN2pFZGE0?= =?utf-8?B?V1hGSTh6V1Nxd2ljVzd2N3hHRHRUTlN1TkJYTjdsM0JQVjhhVXBFM2V1WUNL?= =?utf-8?B?Y0k2aUxiRkQ1OTRQb0crU0xsYk16OG5LelZYbXFsckFYSVNSeExKL3FyVlpw?= =?utf-8?B?VlMwWDBtN3BSd2krV2d1RTJZYnBMVTN6Wm11QWlSUW1weEJLTU5CMTk5T3Rq?= =?utf-8?B?eW5BNlNsL3ZOeWZlc3pVQ1BXTGRJbUhVejltQjdyR3YvNnh2R29XMVhpVDhQ?= =?utf-8?B?YzI5MHVicTNZTk45c1U3ck83RGFZRDZ2WkhEQzNwVkJWd3JkelR1TjRTajZD?= =?utf-8?B?blBEUFR2V1lWOHBDR01UNll5djNuZXhUWTh2TmNjWDM4NndldHBFT1FHK3pH?= =?utf-8?B?NFk3LzJoL2ZpaFQ1N0loUDd0SzhyMmVsQTNKdExKYWtvTjh4MzJtWkljWHd5?= =?utf-8?B?ZFE3M1h1bzRTZzBvQkMzQ0w0dHB6QzJSSmdHcnVKSFhLN1ozM3NzMFY3Z0lZ?= =?utf-8?B?NUZ3a1liTnQyQzE0Vm5PMWd4cC82aHQ5VmRWRW93dWlrWG55dHpQbHBtZHpP?= =?utf-8?B?d0NvbHJKbGUrUGdLVHVyRDNtQ0NoNEdzTmFGcmhyRXFWa1NnRXl4ajdWTmM0?= =?utf-8?B?WDFldkFXTmNzZ3YzdGtuZHFJOVUvc3huRVdYejZFQURHdVFGQlVrUEVMdmpp?= =?utf-8?B?TmROMDFvaWZWK01XRzVhR2hvV0ozalhHaUZWOXZrc3BYWGFNdXZSVWMwNzgv?= =?utf-8?B?MjhjQ2JNZnExRjhoYWlCYlNCMk9ZMW5tR09rMzZVakNTM1NlV05Nb0RDVmxo?= =?utf-8?B?aHNaeTNRbkVVbkFURFh4d3YyZWZqSDJ0S21GZm85QTRvN1JFOTI3WGo4ZUdC?= =?utf-8?B?eUIzd0x4MENZR1Z1aUJna2h1RHd3V083RGE0d0tUV1h5QkgrOHZYWDNrNk5Q?= =?utf-8?B?K1dDZ2ZucVNGREFWTzI5ZUk5NHV4M09LSmlReTRqd1EwOUJaRGY2Y0pJc0tU?= =?utf-8?B?NHhzdUNISHkzZ3duelFHZFlZaDk1V2lucks4eG0raExEQ3NlUXJEUEM1ckcy?= =?utf-8?B?UUszZFNCQWM0OWdGNGxaQUtyRTFZbGZoTnE4SVhRWmNLQVdiTy9rS2FWT3Nm?= =?utf-8?B?SlpMUDkzUGcxUGtVQmtjWENGTkpDVE9NcmpjSkZDSGJTR3RQNjlxeHMzd0Jy?= =?utf-8?B?U09OcEl1UjhqN25kSmJtcC94b0tKVDZFOGhGODRnTE1SRFFTaytLM2NuRUpu?= =?utf-8?B?ZVhDc3pqRjEwS3VLMDFUbnhDWjFLU0lNSHhGU25CZWhRdWgrQW9zOWU5U3FJ?= =?utf-8?B?eFVpWVJXMVEvbndqT2VMVllnd1JET3IwUUZWanRHdXo5WUZ1RU5rWk9qUU1I?= =?utf-8?B?eDN2aFFKSk1IdzRaRUFxYjFUdVd5a2NCdE04bFErTWRnbGUzU0sxaFFNVmRk?= =?utf-8?Q?KtXwVWZSgyoMIcJGV7ptoEATe?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8157972-fe00-428d-80a7-08dac170739d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 10:03:14.9839 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LVyO/6S+90sDq4Onnv8PxbMRkK3LJQHyMHhVVR0LIwMWsQ1MyW9p34yFZm/DYcdPeX7mIjW58K/yq0AOK/5V4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5334 On Fri, Nov 04, 2022 at 05:35:23PM +0000, Paul Durrant wrote: > On 04/11/2022 16:10, Roger Pau Monné wrote: > > On Fri, Nov 04, 2022 at 04:05:05PM +0000, Paul Durrant wrote: > > > On 04/11/2022 16:01, Roger Pau Monné wrote: > > > > On Fri, Nov 04, 2022 at 03:55:54PM +0000, Paul Durrant wrote: > > > > > On 04/11/2022 14:22, Roger Pau Monne wrote: > > > > > > The current reporting of the hardware assisted APIC options is done by > > > > > > checking "virtualize APIC accesses" which is not very helpful, as that > > > > > > feature doesn't avoid a vmexit, instead it does provide some help in > > > > > > order to detect APIC MMIO accesses in vmexit processing. > > > > > > > > > > > > Repurpose the current reporting of xAPIC assistance to instead report > > > > > > such feature as present when there's support for "TPR shadow" and > > > > > > "APIC register virtualization" because in that case some xAPIC MMIO > > > > > > register accesses are handled directly by the hardware, without > > > > > > requiring a vmexit. > > > > > > > > > > > > For symetry also change assisted x2APIC reporting to require > > > > > > "virtualize x2APIC mode" and "APIC register virtualization", dropping > > > > > > the option to also be reported when "virtual interrupt delivery" is > > > > > > available. Presence of the "virtual interrupt delivery" feature will > > > > > > be reported using a different option. > > > > > > > > > > > > Signed-off-by: Roger Pau Monné > > > > > > --- > > > > > > I find the logic in vmx_vlapic_msr_changed() hard to follow, but I > > > > > > don't want to rewrite the function logic at this point. > > > > > > --- > > > > > > xen/arch/x86/hvm/viridian/viridian.c | 2 +- > > > > > > xen/arch/x86/hvm/vmx/vmcs.c | 8 ++++---- > > > > > > xen/arch/x86/hvm/vmx/vmx.c | 25 ++++++++++++++++++------- > > > > > > xen/arch/x86/traps.c | 4 +--- > > > > > > 4 files changed, 24 insertions(+), 15 deletions(-) > > > > > > > > > > > > diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c > > > > > > index c4fa0a8b32..bafd8e90de 100644 > > > > > > --- a/xen/arch/x86/hvm/viridian/viridian.c > > > > > > +++ b/xen/arch/x86/hvm/viridian/viridian.c > > > > > > @@ -201,7 +201,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, > > > > > > * Suggest x2APIC mode by default, unless xAPIC registers are hardware > > > > > > * virtualized and x2APIC ones aren't. > > > > > > */ > > > > > > - if ( !cpu_has_vmx_apic_reg_virt || cpu_has_vmx_virtualize_x2apic_mode ) > > > > > > + if ( !has_assisted_xapic(d) || has_assisted_x2apic(d) ) > > > > > > > > > > So, not sure why this is separated from patch 1 but stated this way it seems > > > > > counterintuitive. We only want to use the viridian MSRs if they are going to > > > > > be more efficient.. which I think is only in the case where we have neither > > > > > an x2apic not an assisted xapic (hence we would trap for MMIO). > > > > > > > > I've read the MS HTLFS and I guess I got confused, the section about > > > > this CPUID bit states: > > > > > > > > "Bit 3: Recommend using MSRs for accessing APIC registers EOI, ICR and > > > > TPR rather than their memory-mapped" > > > > > > > > So I've (wrongly) understood that MSRs for accessing APIC registers > > > > was meant to be a recommendation to use x2APIC mode in order to access > > > > those registers. Didn't realize Viridian had a way to expose certain > > > > APIC registers using MSRs when the APIC is in xAPIC mode. > > > > > > > > > > Yeah, I think they predate the existence of x2apic. > > > > > > > I withdraw patch 1 and adjust patch 2 accordingly then. > > > > > > > Cool. Thanks, > > > > How does Windows know whether to use xAPIC or x2APIC? > > > > cpuid? TBH I'm not sure why this recommendation would ever trump x2apic > anyway. OK, so the recommendation is ignored when running in x2APIC mode, which should be the default since Xen does always expose x2APIC by default to guests. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Nov 08 10:10:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 10:10:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439838.693915 (Exim 4.92) (envelope-from ) id 1osLYW-0003bW-D4; Tue, 08 Nov 2022 10:10:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439838.693915; Tue, 08 Nov 2022 10:10:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osLYW-0003bP-A2; Tue, 08 Nov 2022 10:10:08 +0000 Received: by outflank-mailman (input) for mailman id 439838; Tue, 08 Nov 2022 10:10:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osLYV-0003bJ-6U for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 10:10:07 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 829dbebc-5f4d-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 11:10:04 +0100 (CET) Received: from mail-mw2nam12lp2042.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Nov 2022 05:09:58 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6337.namprd03.prod.outlook.com (2603:10b6:806:1b4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Tue, 8 Nov 2022 10:09:55 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.025; Tue, 8 Nov 2022 10:09:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 829dbebc-5f4d-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667902205; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=AKYgFrdr+0C6OO/Q/bue8XbDqbxQBk2IkrKzkp6BtKY=; b=fOi6V4u8SY1ZY/+f2T7LW4xAMWpFr1smc/DcdJexr/p7gbiuRDMJewBr /uvgSnKqkz2eEOSU8YuUFJsK5P2D528vj5QQglO6vUVd6X4nZvW4irKLV nZs0tf4UyhpEz2lnKxtypWBJeGNNz/pDOM8XfokdVFZ2el9aZ3kL3kXg1 E=; X-IronPort-RemoteIP: 104.47.66.42 X-IronPort-MID: 83454007 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:uiNMSaJi86GhAOSXFE+RJZQlxSXFcZb7ZxGr2PjKsXjdYENS1jdTz DcXXTqPP/mCYWrwft8ja4vkp04E6MKGztM2TABlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wRuPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5FUGFK8 6dfBgoTNBubxMS8/ra4a7BV05FLwMnDZOvzu1lG5BSAV7MDfsqGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/RppTSJpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+toinw27OXxXyTtIQ6Pq3pq8NphlSv9jIWOhQISX+GmqiosxvrMz5YA wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4M+A88hDL9aPS7C6QHG1CRTlEAPQ+vdIybSwn0 BmOhdyBLSNrmK2YTzSa7Lj8hTGvP24TJGwLZy4BRCME5cXupMc4iRenZtVuDq+zyMH0EDfYw jaWoSx4jLIW5eYb2qP+8V3ZjjaEopnSUhVz9gjRRnii7A5yeMiifYPA1LTAxfNJLYLcS0bbu nEBwpKa9LpWUcvLkzGRSuIQGr3v/+yCLDDXnV9oGd8m6iip/HmgO4tX5VmSOXtUDyrNQhexC Ge7hO+bzMY70KeCBUOvX7+MNg== IronPort-HdrOrdr: A9a23:+NObfqFDpMDBOrGVpLqFdJHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHP9OkPAs1NKZMDUO11HJEGgP1/qA/9SkIVyEygc/79 YdT0EdMqyWMbESt6+TjmiF+pQbsb+6GciT9JrjJhxWPGVXgs9bnmVE4lHxKDwNeOAKP+tOKH LajfA31waISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9QwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgrf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQS/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpbzPKN MeQv002cwmMG9zNxvizylSKZ2XLz4O9y69Mwc/Upf/6UkUoJh7p3FotvD30E1wtq7VcKM0lt gsAp4Y642mcfVmE56VJN1xNfdfWVa9Ni7kASa1HWnNMp0hFjbkl6PXiY9Fl91CPqZ4h6cPpA == X-IronPort-AV: E=Sophos;i="5.96,147,1665460800"; d="scan'208";a="83454007" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IE0W3aA+uRYLB1uCPh47PmNCW/zTa3TO8op8em8iFY8wjLGO9FBslq8OJIJUHE151kWDg25Y70mAkK7wI8N+u2UbW1P3jzW73kDoXiYLa6d6AJ98lQKyYvGMQfU2Rkf7eueRcklDk+aZDuIyP+shj9RIIburYSlhY/xIzGPpyommfCNK8n56Gr7hT8kHC4HQKG8+IHBFvFQxyKwm6tjM9CqvN839hEU3RmFfKHnMC5UYhiffgJg4A0oFNGGscUmfUlkhILH003rCH7PU4p8cm+gDXv8MxPSiYP8f8sArsV7iC2AFst/WePsoKDtKZSDnXSpTlGl+p2tqqQGcL+HwOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V8dfr0cQ9lxR1JEPd63sydxGV52vKF8HcJSRQfh3Czw=; b=bvaDEYl/5b2TJG9c1jt7mWrVGMWKYxC7x9ETWWsme2LYMpYqbfUYKuJ4AGUdmBoZp2WwX8vECLcA/9zp6iUh9T8c8AgUseQaNqSfS0+iWAOh0dILYqu19ExnRd52Ncp1s4IFuA2PeAAyi7Ezf5MkvD/wrwEUYokYFafNXOc76KGjkk8TJjsLYr6uBJbgPitHai2655K9yYLil6ABCNelIA9BcWiLm9A41wNNW4VqlW0dIowLwdOdsW66JQPRtQoYwkpIlurJta+3wJhTIF4K97/YQopobGFk9J+mGK5tfIEay2sgR+w6iJq3OKllxajIJ6cP0Lhyo+vLON6IxiGH2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V8dfr0cQ9lxR1JEPd63sydxGV52vKF8HcJSRQfh3Czw=; b=KGOjURwl1B5/lgbbYwy70m6aV1St37qIYNfzX7VE2h/F9BfNQ3/BBWwqKVuE3cwp9ZgfpKMs2rlZ3vbUt/Y6lkeq75XO9lnyzbJlrnSAgDAbJ5t1rv2YVrfNcEgDYhdRsBpY9RBseQ4i1R3k3XzBDPjMqleQCoga2l3J2o5rN0Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 8 Nov 2022 11:09:49 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Henry.Wang@arm.com, Paul Durrant , Wei Liu , Andrew Cooper , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Message-ID: References: <20221104161815.38007-1-roger.pau@citrix.com> <4c8d31de-539a-4252-f0a1-617b220eadc2@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4c8d31de-539a-4252-f0a1-617b220eadc2@suse.com> X-ClientProxiedBy: LO4P265CA0249.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:350::14) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6337:EE_ X-MS-Office365-Filtering-Correlation-Id: f7cb5ace-bdaa-423c-03ef-08dac1716252 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pnFe//+WZ9Oz5oKOFbOO4o0lxGrskkHdB6+8kOksF3u9MGpXNSemQpV23iPc7HArqLjeBZ50cWE418/bYsBQskg7KJMBhmrrwFQlaTCieSU1tqVQX2WEmu8uz/lnpgm6DM0nrMc3LLti0D5Q5OTTapL7Mm/Jxc1XFneEJDeLRiR6jFncJ7A3CQrCyuzhwKxm4n6jJ7wJ14QGsqT2fT4nXcy6E4HxEOX/q8be2W8gScdgamPtYf2wNJ3AgT+868KPaRSN7BYbcPCQCUzzsNYRNTAW66nyNWrjKkubHB0bWUBAIihlFWpWetRBxVT1Z2oNVQyL/92BcSQDq4PMtZjsTUYcmk0QwqoGHEVmK7cgBZzBTDj8P6Zk4L0/AMv03haWmehiID7WGXN81fjkIkVtF5QmLduFU2/cvyYtZnyaq2LM91zhXty62BYlfPByWJSGBHqYsWinHAHCuXeQbFobJNHcKa/3evQcQPSki3ysVzFWOf116cSqiEg1DCHIMvKQg42jpBu2GDOkWBprZOLQk0w2ecGB81zqaKCT/C1fJpqAzZxeqzf4T6gcdfWk+fKnGCA4aFFX2E5XL/6/CgNUvonIrm/eQ67HwwV9J6ew3T0YIs6RkLcdk2kvOr5YbN12S6RMMWymc/P5I9M/++u2lwTEKoGWZtGWG/fViCJlRJahreBj7Hd6BENbbE3G7+WE0p4GqZ+/WO3EvHD/ntm/GA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(376002)(39860400002)(396003)(366004)(346002)(451199015)(86362001)(85182001)(2906002)(186003)(53546011)(26005)(6506007)(6512007)(9686003)(83380400001)(82960400001)(38100700002)(5660300002)(66476007)(66946007)(66556008)(316002)(33716001)(6486002)(6916009)(54906003)(478600001)(8936002)(41300700001)(4326008)(8676002)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzF4ZTdMakZwdnJ3cUpyNkl1ZUVVNE9MTnBDdlVZZkw2VDUwYnpmejQvRUFE?= =?utf-8?B?RThGakVPWWJ5eENROXc1T3dZcWRHclZnU0JXdzRiNHlOTHNWVEJqcUFvSjNK?= =?utf-8?B?M3RacmdmMWM5UFgyNllMQVMxK2U5aTd4YXRzNVRWY0pibGJSR05LTGFORmVt?= =?utf-8?B?MElPYUVQRk4xcHdEV1FTalBSOEF6V2RZQWttT1Q0OHBmL0lqMmwwKzVUTlQw?= =?utf-8?B?MERMYWZ1UHJhbWVYT2RRWDNpNkgxZzIyVU9GZlZnY21BQVgwVUQxbkVkNWRh?= =?utf-8?B?L2JSUGZrZG1wVzJKdk1WQVVMQmtRZTMrRzhmdkhIVlhDTGM2cTJPcW52Q0FS?= =?utf-8?B?RUZUcURNN1VRTFMrbDJKSEg2VkwrOWJ5Vk4wVjhOL0YzVGVaUDVmWTQ1eG1o?= =?utf-8?B?YW5LYU55WExvRHBuZUZZNFFOeVlKZGZtL2VBRjVSQi82ak51Z0llVFBVQ0xS?= =?utf-8?B?dE85Q2R3a0hpdWRZZlFaazBROFkxc202dlhOWkpkK1JlVUhrZm1WVmdwV0VQ?= =?utf-8?B?UFhTVlR6bWJjV0pLakFOTjFLLzg5ZEpDems5SDNDbTQrT09lU2UrN0hEQ3FI?= =?utf-8?B?ekhDZFIwWCtRa3c0MXhDREk5N3RhNlhtb1l6cGdOcVVuaGJzN3UzL3VaQzRl?= =?utf-8?B?ZHhsQXlKY0VncUo1RkZPclpvaktzWm5TTzZpZDhmSXpLbEcreXJFZVdXNE5D?= =?utf-8?B?RXUydzNCeUpXb0Vzcks5ZkJoeSt3TVJIM0RiNVl6MkhLRENTL2RoT1N4WGN0?= =?utf-8?B?QzNQdExXOU9lS2tDSFllZ2NHZW45WWg1SW1rMEZ2VDNteDRxSWRkakpIck9W?= =?utf-8?B?WDNyOS9KdGxPU1BkZVhLc0l4MHZLTkJ1WXFyNUw4WGZDVzcwMXozeXdmSmdk?= =?utf-8?B?bkRZOTRaMDA1Zys0OXVKdlVOQXVrS3lpUDAxSEtHK3BuMktkbm9od21nelBZ?= =?utf-8?B?a2hVMU1pMGVxd1Erd3dGWUlYR2NmVUtKKzhld0VlOE9mRHR5R1h6bUNZWlhx?= =?utf-8?B?MGxLcmNWQnA2YjkzS0VzOFovS1pwRGIvRjZhbTROYXVRVzl5S2pFcERDWGJy?= =?utf-8?B?RWNBWEQ1ZDgrMEhaNnZYazNsaElnN3JrU09PcFNKeVZZL2pNaTlyZ1FIdjJK?= =?utf-8?B?eUE4cTZtNDM3TjF2MGMvOW4yWHZpTW8xMnhNWmZ1UENWOUlmT0JXMWxoZ0Yr?= =?utf-8?B?Ti9NT2k5TWd0d3U0WEZiRGl2WlpsRVc4VlFhZnRmSmNja1RXU3R5RjVyTklR?= =?utf-8?B?dGthemU5amZqZ25qcmJKZFZGV0FFdzJlcjVaeU5kV09EM0kvTlE1bXRvU1Vh?= =?utf-8?B?MDZTL0xDaDJxUlYwSWhLVHZTQzdIUkhFUmhuN3lqVHJmQlJCc1VyVFBRckZP?= =?utf-8?B?a0E1OXhXV3g3R2RLYmhnWlQ4bVQ1M0ZrREE5dHgwN0pObXQxcjQ1ZWNUTjVU?= =?utf-8?B?UlFqN2xCUFRzNUM4aHE2amd6WVFRZXFvZ1UvQ3dBc09oNmlXTUN1WlNOcVFN?= =?utf-8?B?N1ZPVGFTVFBablZxNTRSL3hzUlBhMTdYQ1prWjl4WmdBN1ppcGQ2cVh4bVYr?= =?utf-8?B?NWxxUjJDc3llSStUdG5uQ1AxTWZLMURCQmVOZUVLMk4vbjNTT0FWR0hpMnpm?= =?utf-8?B?VW12Q04zUWRSakIzYkNFYkVhVHhPM1B4bWZDMUt5aGVMRWtoN3hNbnNXSFJC?= =?utf-8?B?NzIySEJScXUzNWFOa05ra0dlWmM4T2pqT3c4QnFvWUIrSGpUUzdvWUp1Mlp4?= =?utf-8?B?VFpuUW5HVDlDd21TTjVFYVNneGgvYmtzR2ZqZGxhMk5Ielg1aUJ5aExIWnJi?= =?utf-8?B?elRIL0JqVjBzeGNoNG9BU0JvdHIyUytqU011VnFYdE5YRjJ3QWV2Y2dmdTNz?= =?utf-8?B?TDMrWlYwTktLUndyZEpKTnpsTFdaa09aMjdKL2Y1c2J6ZHlnbG01NGxYZWI3?= =?utf-8?B?SkZvRkl4SnlwVVFURzJKdkZVRDMyT2FXYUxzaUJsbDZ6dStYVkhJdHVXZjJQ?= =?utf-8?B?aTdQaFBQR0JoRlVSemZQSVA4bDRySEExL3UzK0RyVTNKZ1pMNFl5L2FRVWov?= =?utf-8?B?dnpCdnpjVlpndWZVM1FCSUEzTmNsNE9mY0puZGVLd2N5eGVwYkhLaTVGZFdi?= =?utf-8?Q?tVCq22YUoyLUrEzLOFgkfPJV7?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7cb5ace-bdaa-423c-03ef-08dac1716252 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 10:09:55.4478 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S/mkDQZefiFdUMBj5pmdPahqravA34LW4cO9zmWokD8qtMDQntt418cM8gE37tSovMfmX5m0mxszEfRTHmP+SQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6337 On Mon, Nov 07, 2022 at 05:58:04PM +0100, Jan Beulich wrote: > On 04.11.2022 17:18, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/viridian/viridian.c > > +++ b/xen/arch/x86/hvm/viridian/viridian.c > > @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, > > res->a = CPUID4A_RELAX_TIMER_INT; > > if ( viridian_feature_mask(d) & HVMPV_hcall_remote_tlb_flush ) > > res->a |= CPUID4A_HCALL_REMOTE_TLB_FLUSH; > > - if ( !cpu_has_vmx_apic_reg_virt ) > > + if ( !has_assisted_xapic(d) ) > > res->a |= CPUID4A_MSR_BASED_APIC; > > Isn't this too restrictive when considering x2APIC? IOW is there anything > wrong with leaving this as is? Using cpu_has_vmx_apic_reg_virt won't be correct, as a domain can have it disabled now after this change. When using x2APIC accesses will already be done using MSRs, so the hint is not useful in that mode. > > @@ -3432,6 +3436,10 @@ void vmx_vlapic_msr_changed(struct vcpu *v) > > vmx_set_msr_intercept(v, MSR_X2APIC_PPR, VMX_MSR_R); > > vmx_set_msr_intercept(v, MSR_X2APIC_TMICT, VMX_MSR_R); > > vmx_set_msr_intercept(v, MSR_X2APIC_TMCCT, VMX_MSR_R); > > + > > + v->arch.hvm.vmx.secondary_exec_control |= > > + SECONDARY_EXEC_APIC_REGISTER_VIRT; > > + > > } > > Nit: stray trailing blank line inside the block. Oh, thanks. I will wait for Andrews feedback then, I think the extra blank can likely be removed at commit if we agree this is OK. > Everything else looks plausible to me, but from prior discussion I > wonder whether the result isn't still going to be too coarse grained > for Andrew's taste. Ack, thanks, I think this is the best that we can do given the status of the release, but would likely need to be quick or else it's gonna be too late. Roger. From xen-devel-bounces@lists.xenproject.org Tue Nov 08 10:59:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 10:59:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439910.693958 (Exim 4.92) (envelope-from ) id 1osMKS-0001D3-EG; Tue, 08 Nov 2022 10:59:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439910.693958; Tue, 08 Nov 2022 10:59:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMKS-0001Cw-BM; Tue, 08 Nov 2022 10:59:40 +0000 Received: by outflank-mailman (input) for mailman id 439910; Tue, 08 Nov 2022 10:59:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMKQ-0001CH-RE for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 10:59:39 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2058.outbound.protection.outlook.com [40.107.103.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6eca8176-5f54-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 11:59:36 +0100 (CET) Received: from FR3P281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::21) by DU0PR08MB9440.eurprd08.prod.outlook.com (2603:10a6:10:42c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 10:59:26 +0000 Received: from VI1EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1d:cafe::66) by FR3P281CA0016.outlook.office365.com (2603:10a6:d10:1d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Tue, 8 Nov 2022 10:59:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT009.mail.protection.outlook.com (100.127.144.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 10:59:25 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Tue, 08 Nov 2022 10:59:24 +0000 Received: from 56f04f5d2752.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E4A96747-8808-4F62-8E5E-94D6917F6065.1; Tue, 08 Nov 2022 10:59:13 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 56f04f5d2752.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Nov 2022 10:59:13 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DU0PR08MB7883.eurprd08.prod.outlook.com (2603:10a6:10:3b1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 10:59:07 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893%4]) with mapi id 15.20.5813.011; Tue, 8 Nov 2022 10:59:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6eca8176-5f54-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=IirV/gm5SUJmbU2RdmJBAgxyjsnYAyOiAvKrqvXZw2r0v0wXZWf1RjFSYG9ICE1mVFsYIL2Bgywb/VeXhXgUR3XcCa0E8JXea00gA4VbH5Q5E5gBNQ/LXqaGb1g2dZfXEClD6/DAKIsuFRgjgS1ZoIDtOWH3imhiu2H2GJH6Rs+vrcPXKmaIIX/3+kBROu6HfYGtj1yoQoLgnMvCycPUF192ZVTCkeJAFGWXbWK3NY68otkguwlA8L9FmOcx4ZS0o/mGx4tNNnbwHVy51VD6pvFGUtLZhYujUNT9/3D3tYu0dA1u80XWriu86BKSoanKncuX3mTRUnca0Gkk6mnccQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UvH8NTVnFj0ETGtNDCxJZEb7yA7H68vvL5CXJ9zlHY0=; b=bKM4+6LFSFvHKHdnRtw3Rav1oyS0aO/tNekPFsQ9WpfQRODa98hsimIgqzxi+TN5bbcB0qrgn3duuZaegFHSa+i8cf3IiQiK1Eihnc00rFlF/gfYhQYPHa82wOWhjRmp07p+LOboZfKGYnHCAUqwEStLSkODrU8hmoiBBZeyg6BEBvUxAeDRacsIPThpRr8rwaE0dl9a/gwnfT7Xm5MMv6Mit0psVR6kbsTRnL6QZwqFDv0j3jBb5bhAP8uUgWwXNsVz+6i1fWpd79XvPKJgwIPo05kDA5KgDp1heF0rI0nLYVWoLz5Bgdx7ge3Psx+kl5P6TGfmJhIxZL44TgdzuQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UvH8NTVnFj0ETGtNDCxJZEb7yA7H68vvL5CXJ9zlHY0=; b=qegutkP2nRWaZZ8xxhvoAjST/43hGYFVfEHJhhY6LGzm+4UDOMakRznG/g1yeroamERjptfOyO02CpNcawVyYSoHchA2Ej8B+SAJOFyUYsSbsL47eo4P0yxHNDgWMyAZd6gKq+rh1iHVZ68jR4elrNGtj1mM1YWchZR1MsxGwHY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: ed54ad02f5c8055e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TwPPj8zYLJiDygBN8Jim+OSB/xoo/htjteukxrDuonX4Xu8z2pq347e2W8avD4z/gIifhklRl94L2Ji/6Avlm51yrNv8nxbtAmeUDAzoNaHd30VKRJ3wpQ+XvP7ZpKSP/4cpX+iBF/qGr3yQx0BU/k/el+UD5a+CUWuMMBQ8Z8PMfjfOaZQnoNsmzmRubmU3M8GI6GYo6EqPyMBUEEVXfiMP1QOwluM9oZdD7ry10iKLxsEeGmQ/vtD6fI9oYJ4mTSd6mIJ55tolf1znm2nqGzqqBaL8hh4dLOzTDtbE7+o6me9n6enB+0uY0WRx8kVk1cjVzeuzvzjfmtEc5OUlOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UvH8NTVnFj0ETGtNDCxJZEb7yA7H68vvL5CXJ9zlHY0=; b=gyQr8npj9r7m1b7VSxofM3C6+vUFB7RbX+fHQTbpCaPcoCfYowtlJRL3QNAW6xaJf2Pj64GgpU78H4aoc5X9Dq8WxEj6oCMtD4oHJfSUfZL8XDBX2/SqNV5GHH0rcHtPx+1+wUuXhq4WSfTvasXCoC6W/3f2Y5mskJa7cyJPGD0LMBUaNLwARhNutpxRQvJvrLlfAHvvB+h6pfSsF0qKq/kyG8BMqG1YM0UEjvBbSmK30g9ojx2bmgeEGNTwebkbeJD4w0ALbikBOSWBW/vqTQZZSRp4gcYeQpfXXdQzj0v9F2Ul1Oa4ZGuZuKwU6TxfHUA/bwcICF/7m4e2teFYwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UvH8NTVnFj0ETGtNDCxJZEb7yA7H68vvL5CXJ9zlHY0=; b=qegutkP2nRWaZZ8xxhvoAjST/43hGYFVfEHJhhY6LGzm+4UDOMakRznG/g1yeroamERjptfOyO02CpNcawVyYSoHchA2Ej8B+SAJOFyUYsSbsL47eo4P0yxHNDgWMyAZd6gKq+rh1iHVZ68jR4elrNGtj1mM1YWchZR1MsxGwHY= From: Luca Fancellu To: Jan Beulich CC: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Thread-Topic: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Thread-Index: AQHY8pZ008DS0BACDkyhs+OWN8Oan64zqLWAgAE0WoA= Date: Tue, 8 Nov 2022 10:59:06 +0000 Message-ID: <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|DU0PR08MB7883:EE_|VI1EUR03FT009:EE_|DU0PR08MB9440:EE_ X-MS-Office365-Filtering-Correlation-Id: 37a612d4-9fdf-4c70-621e-08dac1784ca8 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gulsd4KkFFjdBYTk2O08oy90OXRJXmfGs/v8fzIkzrWQlcVOePsRi+HKmMjaEX42ZsPgeVamJemY+rO9e4M+udY/YE8dOzdJFzzXzAgpHg9BNBX7PbxMbyqtIOAxhfsx6Ha8pEjaLtyQ0L+cVh6qk9AvSJkOihwWRVOfMds3IQVjlda9zfNHjuOt/bLnkkpK/tw23gURQW/7Hqi7bXJhg3G3Ed3yUXRAsbDav+J22q2KZ/31626nGtWcVHw9p5z9efhOZZXi98aNimYwQ+6jTaI+nUEdH9RAMaa2jovwjmESoRPsUrlHwjJKzqYmWVqz2Wd/Eb//8XFuN7xkM+Z0rFdF5ppJ0o2qSAoCEaD+8n7X2k9lYuQwrKQbWo5CwUXI3PWhkZWSz+mRWvQ8RBu5I4EEoblGhtHoH9jZOR16lvOvz/ZMGzRDb1LdepB6jN7D0TJNUJGWpsLo0iL3EPLD1keI+uSrq3m6qDXv5+Fx9PgHMAa2cr9gUz2JZpeTOIApkpUYsuOlkmhYo/y/AalhuQSUtiPfutvRyGut0EmQgN92bqofIbSqg9buBv+65RYkBttUTpRhujraYCGrAmr5Yip9Zj8hdKxeroB+7qqfw7ATgM5ReEhw3NqmOVGerWn4r9DEc9iwRCAE2fqdb77HQYUphFByWt58ZdQy2KbYC1tRqTXnatkXmsijrJ7SMq9f8woA5zZ4pRfA4x10U6xIzm71rUw1A/BWigj7oeN+b7AtqgP+53nyMk1d7nSMxFkFrQgbP228w3DQpE9LwyCFKyZ2+8epFLQY+vqFnkxiG6g= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(366004)(451199015)(66899015)(66446008)(91956017)(2906002)(71200400001)(64756008)(4326008)(76116006)(33656002)(66946007)(66556008)(66476007)(38100700002)(5660300002)(8676002)(54906003)(6916009)(316002)(6512007)(122000001)(478600001)(38070700005)(36756003)(86362001)(41300700001)(8936002)(83380400001)(2616005)(6506007)(186003)(53546011)(6486002)(26005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <9E16F514644BA741A042F1F1370F4038@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7883 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f4fe40c6-b9ab-4489-6fd4-08dac17841c9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z+unYIGVgmZwFpA4BdBk02QpnpmzVAm4oPTDrwE0AqKBNouFPvtkTIDxZue0zBKTyVXKypi/IRtMK8OtjAR/1jOrCaf9I7WvJpGUcCXwIm5uB+TEgkySrWu5T3Tc5sDuT+STY3od248RefiX0bY6yqgX8hP5kJb+0LuU2AuHE9gdN9yV3Wmrev6kACEPWEYH/OkP01d32yojpnea0/DgSktDEZ8p9vdG04bl+S1x/u9RrcloQvnQ9HNcYERFWNBk87V49DsO39eBKtMEttpz7vX+GKveh8b3zqLnV1+wvDb3/nrDLR98gHiKXxM49E8cXQbA2CQD2PQd9pi6DwD1BNoYKc4YBVE9tr8F8Iv20WgAJYd9GPN1HbvaA2pBDLiXIBTCygy6XidbnaUVUiid1cgBFOmLn0l/3Us3u5ztzv8s56Hm2IA8C8M1sF0LCfHDJXzvVTpFu7PA3CJ5r7VAYOwBZtLYJIP2rS06KkMyQCQjmK8VXsl18nw/pQ0buwXKAav0ziPfHBhb2nj8Vkkku+QRKt0rqx10OJ5/N3qhQlED1MRLMUVd4cOLH3bfovOUeRmMA8VRsVPxet7p/n8pNB1vKJMXRZWo29CG3BmOJ8ZA7I6nQChvDAofJdWNHhPdBEgWVkCNcwUDr4jQgf07qDa5v4L8tAqjjxKbW5bLSyadvwtka/FeYlhWkJ0jnnIEM346DtwtofVbtaI2VvYIlabJG3FsrsGzwLEwaw481YFMIwNaFCmjT+TLS7IUE8Byr6qQ5DhSkk7oPDSmx4YKWw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(396003)(376002)(136003)(451199015)(40470700004)(36840700001)(46966006)(6486002)(36860700001)(33656002)(6512007)(26005)(478600001)(82310400005)(36756003)(6506007)(47076005)(2906002)(53546011)(316002)(40480700001)(41300700001)(8936002)(6862004)(54906003)(40460700003)(70586007)(4326008)(81166007)(8676002)(82740400003)(70206006)(356005)(86362001)(5660300002)(2616005)(83380400001)(66899015)(336012)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 10:59:25.1280 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 37a612d4-9fdf-4c70-621e-08dac1784ca8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9440 SGkgSmFuDQoNCj4gDQo+IE9uIDA3LjExLjIwMjIgMTE6NDcsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6 DQo+PiArSGVyZSBpcyBhbiBleGFtcGxlIHRvIGFkZCBhIG5ldyBqdXN0aWZpY2F0aW9uIGluIGZh bHNlLXBvc2l0aXZlLTx0b29sPi5qc29uOjoNCj4gDQo+IFdpdGggPHRvb2w+IGFscmVhZHkgcHJl c2VudCBpbiB0aGUgbmFtZSwgLi4uDQo+IA0KPj4gK3x7DQo+PiArfCAgICAidmVyc2lvbiI6ICIx LjAiLA0KPj4gK3wgICAgImNvbnRlbnQiOiBbDQo+PiArfCAgICAgICAgew0KPj4gK3wgICAgICAg ICAgICAiaWQiOiAiU0FGLTAtZmFsc2UtcG9zaXRpdmUtPHRvb2w+IiwNCj4+ICt8ICAgICAgICAg ICAgImFuYWx5c2VyIjogew0KPj4gK3wgICAgICAgICAgICAgICAgIjx0b29sPiI6ICI8cHJvcHJp ZXRhcnktaWQ+Ig0KPiANCj4gLi4uIGNhbiB3ZSBhdm9pZCB0aGUgcmVkdW5kYW5jeSBoZXJlPyBQ ZXJoYXBzIC4uLg0KPiANCj4+ICt8ICAgICAgICAgICAgfSwNCj4+ICt8ICAgICAgICAgICAgInRv b2wtdmVyc2lvbiI6ICI8dmVyc2lvbj4iLA0KPiANCj4gLi4uIGl0IGNvdWxkIGJlDQo+IA0KPiAg ICAgICAgICAgICJhbmFseXNlciI6IHsNCj4gICAgICAgICAgICAgICAgIjx2ZXJzaW9uPiI6ICI8 cHJvcHJpZXRhcnktaWQ+Ig0KPiAgICAgICAgICAgIH0sDQoNClllcyBpdOKAmXMgYSBiaXQgcmVk dW5kYW50IGJ1dCBpdCBoZWxwcyByZS11c2luZyB0aGUgc2FtZSB0b29sIHdlIHVzZSBmb3Igc2Fm ZS5qc29uDQoNCj4gDQo+ID8gSXQncyBub3QgcmVhbGx5IGNsZWFyIHRvIG1lIHRob3VnaCBob3cg YSBmYWxzZSBwb3NpdGl2ZSB3b3VsZCBiZQ0KPiBjb3JyZWN0bHkgcmVjb3JkZWQgd2hpY2ggaXMg cHJlc2VudCBvdmVyIGEgcmFuZ2Ugb2YgdmVyc2lvbnMuDQoNCldlIGNvdWxkIHB1dCBhIHJhbmdl IGluICJ0b29sLXZlcnNpb27igJ06IOKAnDx2ZXJpc2lvbi1vbGQ+IC0gPHZlcnNpb24tbmV3PiIN Cg0KPiANCj4+IC0tLSBhL3hlbi9NYWtlZmlsZQ0KPj4gKysrIGIveGVuL01ha2VmaWxlDQo+PiBA QCAtNDU3LDcgKzQ1Nyw4IEBAIGVuZGlmICMgbmVlZC1jb25maWcNCj4+IA0KPj4gX19hbGw6IGJ1 aWxkDQo+PiANCj4+IC1tYWluLXRhcmdldHMgOj0gYnVpbGQgaW5zdGFsbCB1bmluc3RhbGwgY2xl YW4gZGlzdGNsZWFuIE1BUCBjcHBjaGVjayBjcHBjaGVjay1odG1sDQo+PiArbWFpbi10YXJnZXRz IDo9IGJ1aWxkIGluc3RhbGwgdW5pbnN0YWxsIGNsZWFuIGRpc3RjbGVhbiBNQVAgY3BwY2hlY2sg XA0KPj4gKyAgICBjcHBjaGVjay1odG1sIGFuYWx5c2lzLWNvdmVyaXR5IGFuYWx5c2lzLWVjbGFp cg0KPj4gLlBIT05ZOiAkKG1haW4tdGFyZ2V0cykNCj4+IGlmbmVxICgkKFhFTl9UQVJHRVRfQVJD SCkseDg2XzMyKQ0KPj4gJChtYWluLXRhcmdldHMpOiAlOiBfJSA7DQo+PiBAQCAtNTcyLDcgKzU3 Myw3IEBAIF9jbGVhbjoNCj4+IAlybSAtZiAkKFRBUkdFVCkuZWZpICQoVEFSR0VUKS5lZmkubWFw ICQoVEFSR0VUKS5lZmkuc3RyaXBwZWQNCj4+IAlybSAtZiBhc20tb2Zmc2V0cy5zIGFyY2gvKi9p bmNsdWRlL2FzbS9hc20tb2Zmc2V0cy5oDQo+PiAJcm0gLWYgLmJhbm5lciAuYWxsY29uZmlnLnRt cCBpbmNsdWRlL3hlbi9jb21waWxlLmgNCj4+IC0Jcm0gLWYgY3BwY2hlY2stbWlzcmEuKiB4ZW4t Y3BwY2hlY2sueG1sDQo+PiArCXJtIC1mIGNwcGNoZWNrLW1pc3JhLiogeGVuLWNwcGNoZWNrLnht bCAqLnNlZA0KPiANCj4gSXMgKi5zZWQgcGVyaGFwcyBhIGxpdHRsZSB0b28gd2lkZT8gQnV0IHll cywgd2UgY2FuIG9mIGNvdXJzZSBkZWFsIHdpdGggdGhhdA0KPiBpbiBjYXNlIGFueSAqLnNlZCBm aWxlIGFwcGVhcnMgaW4gdGhlIHNvdXJjZSB0cmVlLg0KPiANCj4+IEBAIC03NTcsNiArNzU4LDUx IEBAIGNwcGNoZWNrLXZlcnNpb246DQo+PiAkKG9ianRyZWUpL2luY2x1ZGUvZ2VuZXJhdGVkL2Nv bXBpbGVyLWRlZi5oOg0KPj4gCSQoUSkkKENDKSAtZE0gLUUgLW8gJEAgLSA8IC9kZXYvbnVsbA0K Pj4gDQo+PiArSlVTVElGSUNBVElPTl9GSUxFUyA6PSAkKFhFTl9ST09UKS9kb2NzL21pc3JhL3Nh ZmUuanNvbiBcDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAkKFhFTl9ST09UKS9kb2NzL21p c3JhL2ZhbHNlLXBvc2l0aXZlLSQkKi5qc29uDQo+PiArDQo+PiArIyBUaGUgZm9sbG93aW5nIGNv bW1hbmQgaXMgdXNpbmcgZ3JlcCB0byBmaW5kIGFsbCBmaWxlcyB0aGF0IGNvbnRhaW5zIGEgY29t bWVudA0KPj4gKyMgY29udGFpbmluZyAiU0FGLTxhbnl0aGluZz4iIG9uIGEgc2luZ2xlIGxpbmUu DQo+PiArIyAlLnNhZnBhcnNlIHdpbGwgYmUgdGhlIG9yaWdpbmFsIGZpbGVzIHNhdmVkIGZyb20g dGhlIGJ1aWxkIHN5c3RlbSwgdGhlc2UgZmlsZXMNCj4+ICsjIHdpbGwgYmUgcmVzdG9yZWQgYXQg dGhlIGVuZCBvZiB0aGUgYW5hbHlzaXMgc3RlcA0KPj4gK1BBUlNFX0ZJTEVfTElTVCA6PSAkKGFk ZHN1ZmZpeCAuc2FmcGFyc2UsJChmaWx0ZXItb3V0ICUuc2FmcGFyc2UsXA0KPj4gKyQoc2hlbGwg Z3JlcCAtRVJsICdeW1s6Ymxhbms6XV0qXC9cKltbOnNwYWNlOl1dK1NBRi0uKlwqXC8kJCcgJChz cmN0cmVlKSkpKQ0KPiANCj4gUGxlYXNlIGluZGVudCBzdWNoIGxpbmUgY29udGludWF0aW9ucy4g QW5kIHRoZW4gaXNuJ3QgdGhpcyBnb2luZyB0byByaXNrDQo+IG1hdGNoaW5nIG5vbi1zb3VyY2Ug ZmlsZXMgYXMgd2VsbD8gUGVyaGFwcyB5b3Ugd2FudCB0byByZXN0cmljdCB0aGlzIHRvDQo+ICou YyBhbmQgKi5oPw0KDQpZZXMsIGhvdyBhYm91dCB0aGlzLCBpdCB3aWxsIGZpbHRlciBvdXQgKi5z YWZwYXJzZSBmaWxlcyB3aGlsZSBrZWVwaW5nIGluIG9ubHkgLmggYW5kIC5jOg0KDQpQQVJTRV9G SUxFX0xJU1QgOj0gJChhZGRzdWZmaXggLnNhZnBhcnNlLCQoZmlsdGVyICUuYyAlLmgsXA0KICAg ICQoc2hlbGwgZ3JlcCAtRVJsICdeW1s6Ymxhbms6XV0qXC9cKltbOnNwYWNlOl1dK1NBRi0uKlwq XC8kJCcgJChzcmN0cmVlKSkpKQ0KDQoNCj4gDQo+PiArLlBSRUNJT1VTOiAkKFBBUlNFX0ZJTEVf TElTVCkgJChvYmp0cmVlKS8lLnNlZA0KPj4gKw0KPj4gKy5TRUNPTkRFWFBBTlNJT046DQo+IA0K PiBJIGhhdmUgdG8gYWRtaXQgdGhhdCBJJ20gYSBsaXR0bGUgd29ycmllZCBvZiB0aGlzIGxpdmlu ZyByZWxhdGl2ZWx5IGVhcmx5IGluDQo+IHRoZSBzY3JpcHQuDQo+IA0KPj4gKyQob2JqdHJlZSkv JS5zZWQ6ICQoSlVTVElGSUNBVElPTl9GSUxFUykgJChzcmN0cmVlKS90b29scy94ZW5mdXNhLWdl bi10YWdzLnB5DQo+PiArCSQoUFlUSE9OKSAkKHNyY3RyZWUpL3Rvb2xzL3hlbmZ1c2EtZ2VuLXRh Z3MucHkgXA0KPj4gKwkJJChmb3JlYWNoIGZpbGUsICQoZmlsdGVyICUuanNvbiwgJF4pLCAtLWlu cHV0ICQoZmlsZSkpIC0tb3V0cHV0ICRAIFwNCj4+ICsJCS0tdG9vbCAkKg0KPiANCj4gVG8gcmVk dWNlIHJlZHVuZGFuY3ksIGhvdyBhYm91dA0KPiANCj4gJChvYmp0cmVlKS8lLnNlZDogJChzcmN0 cmVlKS90b29scy94ZW5mdXNhLWdlbi10YWdzLnB5ICQoSlVTVElGSUNBVElPTl9GSUxFUykNCj4g CSQoUFlUSE9OKSAkPCAtLW91dHB1dCAkQCAtLXRvb2wgJCogXA0KPiAJCSQoZm9yZWFjaCBmaWxl LCAkKGZpbHRlciAlLmpzb24sICReKSwgLS1pbnB1dCAkKGZpbGUpKQ0KPiANCj4gPw0KDQpZZXMg aXQgc291bmRzIGJldHRlcg0KDQo+IA0KPj4gKyUuc2FmcGFyc2U6ICUNCj4gDQo+IEZvciB0aGlz IHRvIG5vdCBiZSBvdmVybHkgd2lkZWx5IG1hdGNoaW5nLCBtYXliZSBiZXR0ZXINCj4gDQo+ICQo UEFSU0VfRklMRV9MSVNUKTogJS5zYWZwYXJzZTogJQ0KPiANCj4gPw0KDQpZZXMgdmVyeSBzZW5z aWJsZQ0KDQo+IA0KPj4gKyMgQ3JlYXRlIGEgY29weSBvZiB0aGUgb3JpZ2luYWwgZmlsZSAoLXAg cHJlc2VydmVzIGFsc28gdGltZXN0YW1wKQ0KPj4gKwkkKFEpaWYgWyAtZiAiJEAiIF07IHRoZW4g XA0KPj4gKwkJZWNobyAiRm91bmQgJEAsIHBsZWFzZSBjaGVjayB0aGUgaW50ZWdyaXR5IG9mICQq IjsgXA0KPj4gKwkJZXhpdCAxOyBcDQo+PiArCWZpDQo+PiArCSQoUSljcCAtcCAiJCoiICIkQCIN Cj4gDQo+IFdoaWxlIHlvdSB1c2UgdGhlIGZ1bGwgc291cmNlIG5hbWUgYXMgdGhlIHN0ZW0sIEkg c3RpbGwgdGhpbmsgJDwgd291bGQgYmUNCj4gbW9yZSBjbGVhciB0byB1c2UgaGVyZS4NCg0KQWdy ZWUNCg0KPiANCj4gVG8gbGltaXQgd29yayBkb25lLCBjb3VsZCB0aGlzIG1lICJtdiIgaW5zdGVh ZCBvZiAiY3AgLXAiLCBhbmQgdGhlbiAuLi4NCj4gDQo+PiArYW5hbHlzaXMtcGFyc2UtdGFncy0l OiAkKFBBUlNFX0ZJTEVfTElTVCkgJChvYmp0cmVlKS8lLnNlZA0KPj4gKwkkKFEpZm9yIGZpbGUg aW4gJChwYXRzdWJzdCAlLnNhZnBhcnNlLCUsJChQQVJTRV9GSUxFX0xJU1QpKTsgZG8gXA0KPj4g KwkJc2VkIC1pIC1mICIkKG9ianRyZWUpLyQqLnNlZCIgIiQke2ZpbGV9IjsgXA0KPiANCj4gLi4u IHdpdGggdGhlbiB1c2luZw0KPiANCj4gCQlzZWQgLWYgIiQob2JqdHJlZSkvJCouc2VkIiAiJCR7 ZmlsZX0uc2FmcGFyc2UiID4iJCR7ZmlsZX0iDQo+IA0KPiBoZXJlPyBUaGlzIHdvdWxkIHRoZW4g YWxzbyBoYXZlIHNvdXJjZSBjb25zaXN0ZW50IGJldHdlZW4gcHJlcmVxcyBhbmQNCj4gcnVsZS4N Cg0KV2Ugc2F3IHRoYXQgbXYgaXMgbm90IHByZXNlcnZpbmcgdGhlIHRpbWVzdGFtcCBvZiB0aGUg ZmlsZSwgaW5zdGVhZCB3ZSB3b3VsZCBsaWtlIHRvIHByZXNlcnZlDQppdCwgZm9yIHRoaXMgcmVh c29uIHdlIHVzZWQgY3AgLXANCg0KPiANCj4+ICsJZG9uZQ0KPj4gKw0KPj4gK2FuYWx5c2lzLWJ1 aWxkLSU6IGFuYWx5c2lzLXBhcnNlLXRhZ3MtJQ0KPj4gKwkkKE1BS0UpIE89JChhYnNfb2JqdHJl ZSkgLWYgJChzcmN0cmVlKS9NYWtlZmlsZSBidWlsZA0KPiANCj4gVGhpcyBydWxlIGRvZXNuJ3Qg dXNlIHRoZSBzdGVtLCBzbyBJJ20gc3RydWdnbGluZyB0byB1bmRlcnN0YW5kIHdoYXQNCj4gdGhp cyBpcyBhYm91dC4NCg0KWWVzLCBoZXJlIG15IGFpbSB3YXMgdG8gY2F0Y2ggYW5hbHlzaXMtYnVp bGQte2VjbGFpcixjb3Zlcml0eX0sIGhlcmUgSSBzZWUgdGhhdCBpZiB0aGUgdXNlciBoYXMgYSB0 eXBvDQp0aGUgcnVsZSB3aWxsIHJ1biBhbnl3YXksIGJ1dCBpdCB3aWxsIGJlIHN0b3BwZWQgYnkg dGhlIGRlcGVuZGVuY3kgY2hhaW4gYmVjYXVzZSBhdCB0aGUgZW5kIHdlIGhhdmU6DQoNCkpVU1RJ RklDQVRJT05fRklMRVMgOj0gJChYRU5fUk9PVCkvZG9jcy9taXNyYS9zYWZlLmpzb24gXA0KICAg ICAgICAgICAgICAgICAgICAgICAkKFhFTl9ST09UKS9kb2NzL21pc3JhL2ZhbHNlLXBvc2l0aXZl LSQkKi5qc29uDQoNClRoYXQgd2lsbCBnaXZlIGFuIGVycm9yIGJlY2F1c2UgJChYRU5fUk9PVCkv ZG9jcy9taXNyYS9mYWxzZS1wb3NpdGl2ZS08dHlwbz4uanNvbiBkb2VzIG5vdCBleGlzdHMuDQoN CklmIHlvdSB0aGluayBpdCBpcyBub3QgZW5vdWdoLCB3aGF0IGlmIEkgcmVkdWNlIHRoZSBzY29w ZSBvZiB0aGUgcnVsZSBsaWtlIHRoaXM/DQoNCl9hbmFseXNpcy1jb3Zlcml0eSBfYW5hbHlzaXMt ZWNsYWlyOiBfYW5hbHlzaXMtJTogYW5hbHlzaXMtYnVpbGQtJQ0KDQpPciwgaWYgeW91IGFyZSBz dGlsbCB3b3JyaWVkIGFib3V0IOKAnGFuYWx5c2lzLWJ1aWxkLSU6IGFuYWx5c2lzLXBhcnNlLXRh Z3MtJeKAnSwgdGhlbiBJIGNhbiBkbyBzb21ldGhpbmcNCmxpa2UgdGhpczogDQoNCmFuYWx5c2lz LXN1cHBvcnRlZC1jb3Zlcml0eSBhbmFseXNpcy1zdXBwb3J0ZWQtZWNsYWlyOg0KICAgIEBlY2hv ID4gL2Rldi9udWxsDQoNCmFuYWx5c2lzLXN1cHBvcnRlZC0lOg0KICAgIEBlcnJvciBVbnN1cHBv cnRlZCBhbmFseXNpcyB0b29sIEAqDQoNCmFuYWx5c2lzLWJ1aWxkLSU6IGFuYWx5c2lzLXBhcnNl LXRhZ3MtJSB8IGFuYWx5c2lzLXN1cHBvcnRlZC0lDQogICAgJChNQUtFKSBPPSQoYWJzX29ianRy ZWUpIC1mICQoc3JjdHJlZSkvTWFrZWZpbGUgYnVpbGQNCg0KW+KApl0NCg0KX2FuYWx5c2lzLSU6 IGFuYWx5c2lzLWJ1aWxkLSUgfCBhbmFseXNpcy1zdXBwb3J0ZWQtJQ0KICAgICQoUSkkKE1BS0Up IE89JChhYnNfb2JqdHJlZSkgLWYgJChzcmN0cmVlKS9NYWtlZmlsZSBhbmFseXNpcy1jbGVhbg0K DQo+IA0KPj4gK2FuYWx5c2lzLWNsZWFuOg0KPj4gKyMgUmV2ZXJ0cyB0aGUgb3JpZ2luYWwgZmls ZSAoLXAgcHJlc2VydmVzIGFsc28gdGltZXN0YW1wKQ0KPj4gKwkkKFEpZmluZCAkKHNyY3RyZWUp IC10eXBlIGYgLW5hbWUgIiouc2FmcGFyc2UiIC1wcmludCB8IFwNCj4+ICsJd2hpbGUgSUZTPSBy ZWFkIGZpbGU7IGRvIFwNCj4+ICsJCWNwIC1wICIkJHtmaWxlfSIgIiQke2ZpbGUlLnNhZnBhcnNl fSI7IFwNCj4+ICsJCXJtIC1mICIkJHtmaWxlfSI7IFwNCj4gDQo+IFdoeSBub3QgIm12Ij8NCj4g DQo+PiArCWRvbmUNCj4+ICsNCj4+ICtfYW5hbHlzaXMtJTogYW5hbHlzaXMtYnVpbGQtJQ0KPj4g KwkkKFEpJChNQUtFKSBPPSQoYWJzX29ianRyZWUpIC1mICQoc3JjdHJlZSkvTWFrZWZpbGUgYW5h bHlzaXMtY2xlYW4NCj4gDQo+IEFnYWluIG5vIHVzZSBvZiB0aGUgc3RlbSwgcGx1cyBoZXJlIEkg d29uZGVyIGlmIHRoaXMgbWF5IG5vdCBsZWFkIHRvDQo+IHBlb3BsZSBpbnZva2luZyAiYW5hbHlz aXMtY2xlYW4iIHdpdGhvdXQgaGF2aW5nIHNhaWQgYW55dGhpbmcgYWJvdXQNCj4gY2xlYW5pbmcg b24gdGhlaXIgY29tbWFuZCBsaW5lLg0KDQpJbiBhbnkgY2FzZSwgdGhlIGNsZWFuaW5nIHByb2Nl c3MgaXMgdmVyeSBzYWZlIGFuZCBkb2VzIG5vdCBjbGVhbiBhbnl0aGluZyB0aGF0IHdhcyBub3Qg ZGlydHkgYmVmb3JlLA0Kc28gaW4gY2FzZSBvZiB0eXBvcywgaXTigJlzIGp1c3QgbGlrZSBhIG5v cC4NCg0KPiANCj4+IC0tLSAvZGV2L251bGwNCj4+ICsrKyBiL3hlbi90b29scy94ZW5mdXNhLWdl bi10YWdzLnB5DQo+PiBAQCAtMCwwICsxLDgxIEBADQo+PiArIyEvdXNyL2Jpbi9lbnYgcHl0aG9u DQo+PiArDQo+PiAraW1wb3J0IHN5cywgZ2V0b3B0LCBqc29uDQo+PiArDQo+PiArZGVmIGhlbHAo KToNCj4+ICsgICAgcHJpbnQoJ1VzYWdlOiB7fSBbT1BUSU9OXSAuLi4nLmZvcm1hdChzeXMuYXJn dlswXSkpDQo+PiArICAgIHByaW50KCcnKQ0KPj4gKyAgICBwcmludCgnVGhpcyBzY3JpcHQgY29u dmVydHMgdGhlIGp1c3RpZmljYXRpb24gZmlsZSB0byBhIHNldCBvZiBzZWQgcnVsZXMnKQ0KPj4g KyAgICBwcmludCgndGhhdCB3aWxsIHJlcGxhY2UgZ2VuZXJpYyB0YWdzIGZyb20gWGVuIGNvZGVi YXNlIGluLWNvZGUgY29tbWVudHMnKQ0KPj4gKyAgICBwcmludCgndG8gaW4tY29kZSBjb21tZW50 cyBoYXZpbmcgdGhlIHByb3ByaWV0YXJ5IHN5bnRheCBmb3IgdGhlIHNlbGVjdGVkJykNCj4+ICsg ICAgcHJpbnQoJ3Rvb2wuJykNCj4+ICsgICAgcHJpbnQoJycpDQo+PiArICAgIHByaW50KCdPcHRp b25zOicpDQo+PiArICAgIHByaW50KCcgIC1pLy0taW5wdXQgICBKc29uIGZpbGUgY29udGFpbmlu ZyB0aGUganVzdGlmaWNhdGlvbnMsIGNhbiBiZScpDQo+PiArICAgIHByaW50KCcgICAgICAgICAg ICAgICBwYXNzZWQgbXVsdGlwbGUgdGltZXMgZm9yIG11bHRpcGxlIGZpbGVzJykNCj4+ICsgICAg cHJpbnQoJyAgLW8vLS1vdXRwdXQgIFNlZCBmaWxlIGNvbnRhaW5pbmcgdGhlIHN1YnN0aXR1dGlv biBydWxlcycpDQo+PiArICAgIHByaW50KCcgIC10Ly0tdG9vbCAgICBUb29sIHRoYXQgd2lsbCB1 c2UgdGhlIGluLWNvZGUgY29tbWVudHMnKQ0KPj4gKyAgICBwcmludCgnJykNCj4+ICsNCj4+ICsj IFRoaXMgaXMgdGhlIGRpY3Rpb25hcnkgZm9yIHRoZSBydWxlcyB0aGF0IHRyYW5zbGF0ZXMgdG8g cHJvcHJpZXRhcnkgY29tbWVudHM6DQo+PiArIyAgLSBjcHBjaGVjazogLyogY3BwY2hlY2stc3Vw cHJlc3NbaWRdICovDQo+PiArIyAgLSBjb3Zlcml0eTogLyogY292ZXJpdHlbaWRdICovDQo+PiAr IyAgLSBlY2xhaXI6ICAgLyogLUU+IGhpZGUgaWQgMSAiIiAqLw0KPj4gKyMgQWRkIGVudHJpZXMg dG8gc3VwcG9ydCBtb3JlIGFuYWx5emVycw0KPj4gK3Rvb2xfc3ludGF4ID0gew0KPj4gKyAgICAi Y3BwY2hlY2siOiJzLF4uKi8qW1s6c3BhY2U6XV0qVEFHLiokLC8qIGNwcGNoZWNrLXN1cHByZXNz W1ZJRF0gKi8sZyIsDQo+PiArICAgICJjb3Zlcml0eSI6InMsXi4qLypbWzpzcGFjZTpdXSpUQUcu KiQsLyogY292ZXJpdHlbVklEXSAqLyxnIiwNCj4+ICsgICAgImVjbGFpciI6InMsXi4qLypbWzpz cGFjZTpdXSpUQUcuKiQsLyogLUU+IGhpZGUgVklEIDEgXCJcIiAqLyxnIg0KPj4gK30NCj4+ICsN Cj4+ICtkZWYgbWFpbihhcmd2KToNCj4+ICsgICAgaW5maWxlcyA9IFtdDQo+PiArICAgIGp1c3Rp ZmljYXRpb25zID0gW10NCj4+ICsgICAgb3V0ZmlsZSA9ICcnDQo+PiArICAgIHRvb2wgPSAnJw0K Pj4gKw0KPj4gKyAgICB0cnk6DQo+PiArICAgICAgICBvcHRzLCBhcmdzID0gZ2V0b3B0LmdldG9w dChhcmd2LCJoaTpvOnQ6IixbImlucHV0PSIsIm91dHB1dD0iLCJ0b29sPSJdKQ0KPj4gKyAgICBl eGNlcHQgZ2V0b3B0LkdldG9wdEVycm9yOg0KPj4gKyAgICAgICAgaGVscCgpDQo+PiArICAgICAg ICBzeXMuZXhpdCgyKQ0KPj4gKyAgICBmb3Igb3B0LCBhcmcgaW4gb3B0czoNCj4+ICsgICAgICAg IGlmIG9wdCA9PSAnLWgnOg0KPj4gKyAgICAgICAgICAgIGhlbHAoKQ0KPj4gKyAgICAgICAgICAg IHN5cy5leGl0KDApDQo+PiArICAgICAgICBlbGlmIG9wdCBpbiAoIi1pIiwgIi0taW5wdXQiKToN Cj4+ICsgICAgICAgICAgICBpbmZpbGVzLmFwcGVuZChhcmcpDQo+PiArICAgICAgICBlbGlmIG9w dCBpbiAoIi1vIiwgIi0tb3V0cHV0Iik6DQo+PiArICAgICAgICAgICAgb3V0ZmlsZSA9IGFyZw0K Pj4gKyAgICAgICAgZWxpZiBvcHQgaW4gKCItdCIsICItLXRvb2wiKToNCj4+ICsgICAgICAgICAg ICB0b29sID0gYXJnDQo+PiArDQo+PiArICAgICMgT3BlbiBhbGwgaW5wdXQgZmlsZXMNCj4+ICsg ICAgZm9yIGZpbGUgaW4gaW5maWxlczoNCj4+ICsgICAgICAgIHRyeToNCj4+ICsgICAgICAgICAg ICBoYW5kbGUgPSBvcGVuKGZpbGUsICdydCcpDQo+PiArICAgICAgICAgICAgY29udGVudCA9IGpz b24ubG9hZChoYW5kbGUpDQo+PiArICAgICAgICAgICAganVzdGlmaWNhdGlvbnMgPSBqdXN0aWZp Y2F0aW9ucyArIGNvbnRlbnRbJ2NvbnRlbnQnXQ0KPj4gKyAgICAgICAgICAgIGhhbmRsZS5jbG9z ZSgpDQo+PiArICAgICAgICBleGNlcHQganNvbi5KU09ORGVjb2RlRXJyb3I6DQo+PiArICAgICAg ICAgICAgcHJpbnQoJ0pTT04gZGVjb2RpbmcgZXJyb3IgaW4gZmlsZTogJyArIGZpbGUpDQo+PiAr ICAgICAgICBleGNlcHQ6DQo+PiArICAgICAgICAgICAgcHJpbnQoJ0Vycm9yIG9wZW5pbmcgJyAr IGZpbGUpDQo+PiArICAgICAgICAgICAgc3lzLmV4aXQoMSkNCj4+ICsNCj4+ICsgICAgdHJ5Og0K Pj4gKyAgICAgICAgb3V0c3RyID0gb3BlbihvdXRmaWxlLCAidyIpDQo+PiArICAgIGV4Y2VwdDoN Cj4+ICsgICAgICAgIHByaW50KCdFcnJvciBjcmVhdGluZyAnICsgb3V0ZmlsZSkNCj4+ICsgICAg ICAgIHN5cy5leGl0KDEpDQo+PiArDQo+PiArICAgIGZvciBqIGluIGp1c3RpZmljYXRpb25zOg0K Pj4gKyAgICAgICAgaWYgdG9vbCBpbiBqWydhbmFseXNlciddOg0KPj4gKyAgICAgICAgICAgIGNv bW1lbnQ9dG9vbF9zeW50YXhbdG9vbF0ucmVwbGFjZSgiVEFHIixqWydpZCddKQ0KPj4gKyAgICAg ICAgICAgIGNvbW1lbnQ9Y29tbWVudC5yZXBsYWNlKCJWSUQiLGpbJ2FuYWx5c2VyJ11bdG9vbF0p DQo+PiArICAgICAgICAgICAgb3V0c3RyLndyaXRlKCd7fVxuJy5mb3JtYXQoY29tbWVudCkpDQo+ PiArDQo+PiArICAgIG91dHN0ci5jbG9zZSgpDQo+PiArDQo+PiAraWYgX19uYW1lX18gPT0gIl9f bWFpbl9fIjoNCj4+ICsgICBtYWluKHN5cy5hcmd2WzE6XSkNCj4+IFwgTm8gbmV3bGluZSBhdCBl bmQgb2YgZmlsZQ0KPiANCj4gTml0OiBeXl4NCg0KV2lsbCBmaXgNCg0KPiANCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Tue Nov 08 11:01:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 11:01:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439930.693977 (Exim 4.92) (envelope-from ) id 1osMLv-0002mB-19; Tue, 08 Nov 2022 11:01:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439930.693977; Tue, 08 Nov 2022 11:01:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMLu-0002m4-UC; Tue, 08 Nov 2022 11:01:10 +0000 Received: by outflank-mailman (input) for mailman id 439930; Tue, 08 Nov 2022 11:01:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMLt-00015v-82 for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 11:01:09 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2044.outbound.protection.outlook.com [40.107.104.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a5ab29be-5f54-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 12:01:08 +0100 (CET) Received: from FR3P281CA0122.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::6) by PAVPR08MB9260.eurprd08.prod.outlook.com (2603:10a6:102:306::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 11:01:02 +0000 Received: from VI1EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:94:cafe::c7) by FR3P281CA0122.outlook.office365.com (2603:10a6:d10:94::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11 via Frontend Transport; Tue, 8 Nov 2022 11:01:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT062.mail.protection.outlook.com (100.127.145.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 11:01:01 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Tue, 08 Nov 2022 11:01:01 +0000 Received: from b71c067ee86c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 651C6947-58E7-4196-AF70-E0AB5ED5C003.1; Tue, 08 Nov 2022 11:00:51 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b71c067ee86c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Nov 2022 11:00:51 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM9PR08MB6658.eurprd08.prod.outlook.com (2603:10a6:20b:303::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 11:00:48 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893%4]) with mapi id 15.20.5813.011; Tue, 8 Nov 2022 11:00:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5ab29be-5f54-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QstSyg877W2uA89u/NU6Cj6imolVLNnnFcYQr2uxJ6OkFXNxSvlEV2HfvBBIzcYYndIEVcQGfjn/rdlrKRt1Yr2RxDqSszozMAoZClYOOHLMjI5RtI1MUN2LLdq+EtB5oz11lAD/4SA0R9i2ZA9Xqu8mMNWPLRGJdyy63JMPqcPsNKYZn5XVqSp7ENpxU9Vxs8dU4W1o9IT8iUK9hS/286iMIJ8dUIdxdwbtvstiJOMtR2pQ8Y3pvPtR7KaWEx0nPyOg8ivBGDVEo1viRd4fQe7lNu0iaDmXNks1iChNriaWjoQI21LYznkQs2gwPn0QN/iUlPa+KjoS7W47c2ausw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ziW/iULUAbBB1IoqvVvfagfEsim2NtZox8AdGitTvIA=; b=D4J12t8zImHd9SHavSzqSA0k2F29SEAEwmSUS1JlcuYvdgYRzvVnAJhsfUyhOZ+X++KKUpvtcdiWYFVYOlpXUlPv1spuuxlcCBP5B81SI9/BgSI/zMrV0PRWewwvVfFeqIZzSuG5h+29LW/xAZNrmU9xLP7NAPmyTss7wa8FQ1SzlAGbwGLmvnj1uy7XzFoBE5VRoyNV6xsAyI9oA6AWMJkriVpW7NFDdhLMYK1wwuEl4X3V055nLcVxDsfGQ7D4c1gJ+QSYoKeLF1zFmTGvlVHZWG7Ng2bGbJixxfIOFA9UbYe4l2b0w74A3hozY4b4HZJR5B5yVEnKTb5YT529Zw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ziW/iULUAbBB1IoqvVvfagfEsim2NtZox8AdGitTvIA=; b=zc32Nc8/Kcls3qxKTRsE0R3XDLd+j7qgn2J4qvXsFGrretqwsUgvcECal1yZPomW3HiYtICrvm0s9V+h4jmKiYea+cmXmzKN+2xai2+ItRsnU5/V0gxdSHhc1XeVZiF8ESfaIu2iyBUJDfMGABdKqUbzGZTdWpC7MYlvtIAG1gQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e0c21e4067a79a0a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kcotjXmZZPQTk0EgHGQwHjOd211YGd80iAj6CQZqnziYvdnzzCVwdM+WIErbkFPGbd5zJe5d/tdoWOM9FCWIKHnaTsK5Ejo/lzWlElg7Fm/bXwDprSZEiZQ9TItUPSgKHazW5R5Y2IwQ2qH+6hIpDD6CSVt9pwgH62oa4ugBgTR6CX7eM8HTX6yS7ocD8HClIYNTi+NfsKIvcCR0QmsLZZ7eCtWeRfMJ872/oM+vR7tYWsJXB1vkyUAxZAzJwh1LqqzjZHCQKB68huEXPLIc/uNA5z4nf3K1y5rBCnH2ukSrWpBKXpj835WGt3wjXu3sZgYGh5mKyq4Iu+u8OhHRMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ziW/iULUAbBB1IoqvVvfagfEsim2NtZox8AdGitTvIA=; b=RiaDkWc+YToM2N7oSOYJ5KHyRgbnCffFpOXSouHPcXhSds5nMG4l1Zb2alxr13hTNf98B1eczdPM1DhugHaAiYkd9RpxALHHBfRBQUBXUabAICBVe6p30ZqAA5niMIBrHemdTxDamzxVf5D0e4TzEr0kzJXniT9F4r2lXgJi6DOteM7Fs6Cr3xFxzPOUGoDgxO8hXLX8iYQuLlkIlMBgxQzn8AW4/ewwtC8n7gFPjNEkpmYMohb0u4+lAKdkzBnuJQ4jc4ZS03txZIaL5ZVx7RepG9SQFG6lBEv5vb0iiEuzlsY/3MMl2QPfxuEI5Kq5UWQ9DLsCJbnfQjmUhRHNQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ziW/iULUAbBB1IoqvVvfagfEsim2NtZox8AdGitTvIA=; b=zc32Nc8/Kcls3qxKTRsE0R3XDLd+j7qgn2J4qvXsFGrretqwsUgvcECal1yZPomW3HiYtICrvm0s9V+h4jmKiYea+cmXmzKN+2xai2+ItRsnU5/V0gxdSHhc1XeVZiF8ESfaIu2iyBUJDfMGABdKqUbzGZTdWpC7MYlvtIAG1gQ= From: Luca Fancellu To: Julien Grall CC: Jan Beulich , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h Thread-Topic: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h Thread-Index: AQHY8pZ4QA3C9Pi6Y066NaE9A9ULoK4zWNUAgAABAICAABGdgIAAZ3AAgAEKpoA= Date: Tue, 8 Nov 2022 11:00:47 +0000 Message-ID: <5B9130CD-BC40-42E3-8D79-DABC321AFF13@arm.com> References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-5-luca.fancellu@arm.com> <5caf911d-e96d-39e4-d945-db6537412f60@suse.com> <3925276F-8B6E-4B19-9EC2-C085FE88A637@arm.com> <933c4227-5839-312e-3996-693a7d8f7706@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|AM9PR08MB6658:EE_|VI1EUR03FT062:EE_|PAVPR08MB9260:EE_ X-MS-Office365-Filtering-Correlation-Id: ecd72bcb-f346-40b0-f7d9-08dac1788621 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 50qavyV9cvEmS29XYDBA7abnWCDjx7vB5QZASd5A94CekvoI/xmEQq7poz5v9jo2rCRJVlIAas878l9TzNNyyISLxmS8Qo4QZENBCsDdiE37Ff276KYO//h8HoGz+KdZCCqPz4Psy+RqG4b7C+OvxCrHU1ULXGcI85YQebmk0dO25nAISkCADiIc7Jbs5traswx7j5Ztrwa6RzEHatiMeU5oE8mwiYTf3VIadytnBedgU1EqBN5jwYxVpoW8zaBcw707rnk5UdNyoBWo82Pyj/A4s0fm2vUZa1/kWQVCKzDuGSazVm3I7t9HFgBmS4QuRLW4AuwTGl/ekjFHlYaaHrf69p+ixrgRjkhsY14v1RxYH0uAhs+FItapLL13pFdOnZRaFliqIB3u4p2Ei42adR69T8FjrOFzX8fPEiO9uxDIXFFV8xPTwYCJBAl5SJwX2xc+MCmWjsVDn5m0IHyLF16JwZiZ5TN8RqpnEdTWVkLsDkZlwu9CGwDcB1d/XwiW+OjLdfUpWmkYKdWOZqOKFpM7JX3LzKYdmEN6uNLLUqBvKHYZ99UhUbsShCtkUXm1RNVcupsAnE7e7t1vP5zFGzvURR4H1ZsBhT4OS/Rldgn+mhvYNmi4Gf0Pd8JJIjbxjkM1y1rxMqRUBDGIuLvrXMuDWUrFgjvKGmMhdB+JFJ0TZmrdM8w5WyOKKTVIMppk0cw3HAgxD9L89rB+vjGs5h1lhkkeE83h1B3NL3tzvNPRiW0v62JYDOMQ+m5gOciTdAcfcvp+LCCtldgeMBayOb2h5sy3g+82FprH+vnLz+o= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(366004)(376002)(451199015)(66476007)(54906003)(186003)(6916009)(8936002)(316002)(6506007)(36756003)(53546011)(5660300002)(41300700001)(76116006)(4326008)(2906002)(66946007)(64756008)(66556008)(33656002)(26005)(66446008)(91956017)(2616005)(6512007)(8676002)(478600001)(6486002)(38070700005)(86362001)(71200400001)(38100700002)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6658 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8d36cb9c-e62e-4117-82b5-08dac1787df9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lsJdAhjdzbTzKdPXSOoFqRFQAfXY1dAKMHaslzh9cxFlh11Xt0XN/507di76ZWfIcOBz7DxxmNbmQCQWkysihaVfTkVunaKEZKZJCiwbppgvaGyDHOMBWIRdTR2vv932Qp3jfeDO3b5DBPJl4jgerDocyuLb8VsG15ZiXnGFqsw6aoIbSORVt+HOBOQbfMkAx7LM3p4M8iaaOZOiRqDB83HsGcGtxe7v5BmUMlOw+JpqUptCucFHyejn084fKLpwk188CjQWhFPCMD+rYhybVnRQTvXVvNIamV8CsDeurmp/jJProupvKxMRwLeQKNmGc9XNsxR5pvO/UO1omBmR2jUa7khwtZOuWCPIVRZToAv35dWIzkKAaW59SvdFV24yfmYoKkC85HC7w7tzr4+FbJOBYnwd8YQcyHt4nC8alMPD5ga/MBDs+wTTdWdgss4Qa3btbCQ6ruI2ZLcnGrPzeA0r/GaahFmMdrP1LgfCfXKWk6TEypfsM4jY11l6VRWKFCY+maBAIR0/3GY/7fVi8o8S7AhIrG+QkcJNl8JS5GHA7H4j8XQ6r9YkTz9fcOH7tST9ef/jP/jzIk8BCIioZ5OiWdqqnYyiRHZW8f7pTgClm6cwAaSegN4n88H9ERYrZj+cQZrfU/VsmK3pssVgt1QlrENMTi1IJw/U6LEhl9tup6L9QsmtV/NgzMRuRXBqQQPZgynYx2o2vQjj1u67CFyEvoxZFGhDI89+PeHXQUbrGH2rAbW0bxOR6AEXpkrDJt81P1smqrh5mp0vbf4RLg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(46966006)(36840700001)(40470700004)(82740400003)(356005)(40460700003)(81166007)(6862004)(36860700001)(70206006)(70586007)(4326008)(8676002)(41300700001)(8936002)(54906003)(316002)(36756003)(82310400005)(2906002)(40480700001)(47076005)(336012)(53546011)(6506007)(6512007)(26005)(6486002)(478600001)(2616005)(186003)(5660300002)(33656002)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 11:01:01.5862 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ecd72bcb-f346-40b0-f7d9-08dac1788621 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9260 > On 7 Nov 2022, at 19:06, Julien Grall wrote: >=20 >=20 >=20 > On 07/11/2022 12:56, Jan Beulich wrote: >> On 07.11.2022 12:53, Luca Fancellu wrote: >>>> On 7 Nov 2022, at 11:49, Jan Beulich wrote: >>>> On 07.11.2022 11:47, Luca Fancellu wrote: >>>>> --- a/xen/include/xen/kernel.h >>>>> +++ b/xen/include/xen/kernel.h >>>>> @@ -65,24 +65,28 @@ >>>>> 1; \ >>>>> }) >>>>>=20 >>>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>>> extern char _start[], _end[], start[]; >>>>> #define is_kernel(p) ({ \ >>>>> char *__p =3D (char *)(unsigned long)(p); \ >>>>> (__p >=3D _start) && (__p < _end); \ >>>>> }) >>>>>=20 >>>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>>> extern char _stext[], _etext[]; >>>>> #define is_kernel_text(p) ({ \ >>>>> char *__p =3D (char *)(unsigned long)(p); \ >>>>> (__p >=3D _stext) && (__p < _etext); \ >>>>> }) >>>>>=20 >>>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>>> extern const char _srodata[], _erodata[]; >>>>> #define is_kernel_rodata(p) ({ \ >>>>> const char *__p =3D (const char *)(unsigned long)(p); \ >>>>> (__p >=3D _srodata) && (__p < _erodata); \ >>>>> }) >>>>>=20 >>>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>>> extern char _sinittext[], _einittext[]; >>>>> #define is_kernel_inittext(p) ({ \ >>>>> char *__p =3D (char *)(unsigned long)(p); \ >>>>=20 >>>> Why the "R8.6" everywhere here? Didn't we agree that the in-code >>>> comments should be tool-agnostic? >>>=20 >>> The R8.6 is not tool specific, it is to give the quick hint that we are= deviating >>> from MISRA Rule 8.6. >> Well, yes, "tool" was wrong for me to write. Imo references to a specifi= c >> spec should equally be avoided in in-code comments, as other specs may >> turn up. >=20 > +1. The comment duplication is not great and sometimes even a short expla= nation it may not fit in 80 characters (AFAICT the justification should be = a one line comment). >=20 Ok we can remove the R8.6 from the comments, is the remaining part ok? > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 08 11:22:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 11:22:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439969.693996 (Exim 4.92) (envelope-from ) id 1osMgs-0005rT-TK; Tue, 08 Nov 2022 11:22:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439969.693996; Tue, 08 Nov 2022 11:22:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMgs-0005rM-QV; Tue, 08 Nov 2022 11:22:50 +0000 Received: by outflank-mailman (input) for mailman id 439969; Tue, 08 Nov 2022 11:22:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMgs-0005rG-8i for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 11:22:50 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2082.outbound.protection.outlook.com [40.107.20.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id acf48838-5f57-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 12:22:49 +0100 (CET) Received: from AM5PR1001CA0009.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::22) by PA4PR08MB6013.eurprd08.prod.outlook.com (2603:10a6:102:eb::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 11:22:43 +0000 Received: from AM7EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:2:cafe::8c) by AM5PR1001CA0009.outlook.office365.com (2603:10a6:206:2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25 via Frontend Transport; Tue, 8 Nov 2022 11:22:43 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT038.mail.protection.outlook.com (100.127.140.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 11:22:42 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Tue, 08 Nov 2022 11:22:42 +0000 Received: from d997d50dcdbb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 39028DED-C46C-4702-8E79-7DA1C3F76738.1; Tue, 08 Nov 2022 11:22:35 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d997d50dcdbb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Nov 2022 11:22:35 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM8PR08MB5812.eurprd08.prod.outlook.com (2603:10a6:20b:1d5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 11:22:34 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5813.011; Tue, 8 Nov 2022 11:22:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: acf48838-5f57-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=m+NPF3pZAWUjPQHkadOmUXe7VkoL9RdBxlfNiJRbiFvqRU2a1VrSKcG+jn+m/nInIZV2A4YFRuWQYvz8H+qQzShaexVsmjltLB7tCwMWzpzGLptyRN0QEkQ3e6IQgDG6FuPCRrDV1n3aD0fPcMVpQAI0QtMsDJzF0v/5D9rf4emVZ0dUVjWVNG3tDEqOFouXkcpvKqtlXFj0qhrskZNP8oXa7/SwTPFOPmus28ExWSSDVlRbqVyzj6W6K98Bi5eDMC4IzDqn5Tu2gxC+l9i790W6P63iJfR0CWO45Kt37WLJK0YvyJOK3u16SfiyViUKblPzMDqZpALcCJkgYsmcpg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ctSarpqe0aWgVPoCD6N3eCH6G/W3lXgybkfIntDyAis=; b=JTFCuRGXOyyMi26pxGhGboFGR86NJi8tLzMoy0Oa1nN8Wx92yw0w75nTY6006EVTpRZ2GwqW7uySFPbJY82HIZWRfhxS5OnwjPjToNDHhFu6h0Xz65rOMmTo5LAUo2qpIffAZiQuVHKpGIvIjrdb3/GVXZA/f3ONkPTQ0mfKpOELOLJnhoOv5QkV1uBNRKHnbl7u+YHZNmInaIHC4dxescvIDQ68HYC082HOtcpRJHiAWLjQzjEgNFccqA/vWh5GDB3hzsXbZcR8CWwGz7Cn19tf0xBkgqG++GdU+gMHJPr+1vh+sd8FzI0JluCWNfjPTJs+DCRcp2QoNd9iqPmsLw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ctSarpqe0aWgVPoCD6N3eCH6G/W3lXgybkfIntDyAis=; b=uQZ4vzsBz5qpuMK1Sc5vcsDvHJrZjtwz4LBt0j5a8f7dyB0ewUTIDJR+alIbaoLiTOwi6YZYm4gHcLo59WWRTMSzdbUrwwRI2gDZva3UyEfwBnpjuLEVyrbXt98U6Rfl7IqAHf6WJLSXhiPqhOYPmnavUt84bsz4oyuH73nmQfQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: dcc1c955151afcb6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dMQ536QVJPiYI5eNZXMhdzhbGNN12v/u1h5Djoo1mQ5ZE5AXnb9nag+591WfJSNPrDyCt8djYiw/9Z7o8RYpjlMHqOs+X29fo1+eJ7RS70WMIHjXxLkpgMtZBBcrB/qGHuC9baYR30UfYRmChnCHCRsgX4M7OX5hv2TK/aOxAYz4bfq9IAvApo5JJMW82gI1nywVQhgRBLqLFAqae7Ao/y2wQ18RgmrU4v7Ym5ZqKNpvaxTWC9nE/ESo6QsSpy15ilPaW0lBddflZZQw/cf72ASgvVzpM3cnlGXNjnBnjMT91e65HfjpYcmItq5Kxpy1fXyZlHHVO3f2mHFEnV2tIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ctSarpqe0aWgVPoCD6N3eCH6G/W3lXgybkfIntDyAis=; b=Aw9J8sEc5GXxpD28+BaCrpTs4oGbpYYXshi/Bv2FRpzSEM4wlwtQK+mQGkpZnEJSzYB2sON2wZ173Q/+laoEIMyVmmZQR5MH/eE+GvJzcyMRdQvlso8kFVaRqOD8g4KeD+bYtaQD0U31K+rp+RN71j/SXSorzTS/kzRGWG9I8L7/+E4E8h6FJjKdp6J9NMqQX35GSODi/xaRQrSAdFVQCk9htRh2ZLeAny+ryQwWhVMMYhTiTo3sPj4PhHuYWXiN/MuCUD37pP0MZqOUWT49LCY57SOVHUL7eu477+oONLnDIpQQ1VhxaNTh2ZTK+s3677XXZ9k6Vf8O/7lRFKdQjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ctSarpqe0aWgVPoCD6N3eCH6G/W3lXgybkfIntDyAis=; b=uQZ4vzsBz5qpuMK1Sc5vcsDvHJrZjtwz4LBt0j5a8f7dyB0ewUTIDJR+alIbaoLiTOwi6YZYm4gHcLo59WWRTMSzdbUrwwRI2gDZva3UyEfwBnpjuLEVyrbXt98U6Rfl7IqAHf6WJLSXhiPqhOYPmnavUt84bsz4oyuH73nmQfQ= From: Bertrand Marquis To: Ayan Kumar Halder CC: Xen developer discussion , "sstabellini@kernel.org" , "stefanos@xilinx.com" , "julien@xen.org" , "Volodymyr_Babchuk@epam.com" , "michal.orzel@amd.com" , Ayan Kumar Halder Subject: Re: [XEN v3] xen/arm: Enforce alignment check in debug build for {read, write}_atomic Thread-Topic: [XEN v3] xen/arm: Enforce alignment check in debug build for {read, write}_atomic Thread-Index: AQHY81buqq5XOHkvVUuD4StMug7I3a404hsA Date: Tue, 8 Nov 2022 11:22:33 +0000 Message-ID: References: <20221108094503.40253-1-ayan.kumar.halder@amd.com> In-Reply-To: <20221108094503.40253-1-ayan.kumar.halder@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AM8PR08MB5812:EE_|AM7EUR03FT038:EE_|PA4PR08MB6013:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f13ca81-3998-452a-9da1-08dac17b8db7 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HRvwRL7DeukP3DtdNzM/qp2QWsJkyXOVhcoWcVYVfYM94wYO0oCyNi2b4xbOJbOYNKh0CcpfikPHHObzfWXSFL96ZyiksVNaLHOI4jJ52liSir99ewk/ArDm3VGF1zTtyLEvs7j/JxLsK8Q2f/mROuhqoZ6Bf3WMRfXMSWb6cwiGTnfqGhQc+g9TRia1g6D/eparGDabIG1o+xb2+vTNBqbgH4aR02yspDDQySxwg0ZpUjZP+XExG/q63YdL8sSlce5uE4TYCjXkx7ZQBB+cMr4lU47orFCLHlq2VVWbB517gtZ7pj3q0xEXiTQwA7WPiDNKY/sHHP1BZcjSlpch6A6DMCJKm9n3z2z8oC0plhfFNVyspo57JMGQkOeQXVjd9eiK5zKqtusMvPB7qIPmvhTAdZNrN3Wa6j0DoEmZ6uwNiq6ukOehznjYzVoN1Ppeh7De/KXL+DX3eB83ledsUda6l+F9iCI2HTSkESDRPsGPorGsHkV1KY3oXqMrxFKaszEK9qYV0GmF5iTHnzx8+3XZWjyyVkZZuJioCMIrH9iLKl3tcRiOud/iNz+N6EZEum5zAg0HxbpjuJsaRjydGnOZ66Fk3LiWkm/0ZWyhkJymQcKOb3oWsK+H/u4Z8PaLOU79AluriC7zXFD0TCtioCQr9WdldYS5OWXtH0DhoWng/8rH6WsSDwo8YX5Q8rUDlWU8/bVLUtiBIrVfDFsrdUpaaVU7aDvqMUBMNT8skhmvtm+qucqMcOkg3TQhKoxWkCjpoee2e8J9qdwLFH37OdE9engqjJVLUjHSB2KYEc4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(39860400002)(346002)(376002)(451199015)(8936002)(2906002)(66946007)(4326008)(66476007)(66446008)(8676002)(64756008)(478600001)(91956017)(76116006)(6486002)(83380400001)(71200400001)(38070700005)(33656002)(316002)(41300700001)(66556008)(5660300002)(122000001)(186003)(6506007)(38100700002)(86362001)(6916009)(6512007)(2616005)(26005)(53546011)(54906003)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <29DDA9CA941DBD4890D18625C28C0172@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5812 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 539eff3e-9142-485b-e580-08dac17b8810 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4KE9IPpK+d7Eyq9w8dmOzmUHqnPzuMscUaYNABSKMEEOjv4iSxDHiql1fzxze9Fa2amwUNwBGXtlq+JRS5VqA2wK6tUqEWXgoDf4G49/ZyLqd/lDd7UXmo90VKmhOwj+1SqfV2hOHeiHcaklxKboIW9cJaV5RDnQffoPsIPfG5jJ/r+gT4UONlVkDX7v4CX/vxYFB2DQBLKt8ztkSc+UGKYlL1H9CbNCPCQfXYUmkTs6GH9FDyY+6vGqOhBaWPf4LXGby5f5PidIj1BIaJu1yAa0zgLZmjJl1qCGqJVTUWvYftsLyVAKLn27Cox5knRonD3OA9Jl2AtYX3o4E0oA5tfIjgDWFcsloEpVfdBwA5GqKPQMSsgPEeqKqSE4AkvW26RMswjQqXw38x4yFf3OqH2xdMw0lNhSclQnxzHONJnyGrmehefj6+JU+TMVoZ3OGgciYNLYlHwDeNu9Ld7rhhBFU3K1B3+S13dKWH3zZwBLd2GUWKNEb0z5vq3owV5nfTu7gYvvYxqCMKrhLgVeKggJE5cddn/TBnH4Zaed9xSTgOF1/RvKsWOP+SUc1DeUwDHZvj0PbDftliuJz+dTd9x3s/k0q7WlclhmPMocF+tY35AiirlLty4Ywv0EVNVJmKyTcuFai4iBiFEKX2uAlk/PuZ09D4fSr2xw/S+r7ZJe65mgHbtdXGAvjHREVpv98xYsOebTO6XioScu4kt8CsOyuZN+xBxe8/8RMM2uley12uwBZmdx4AEwEIdMtvvqlJLe/9+F1kVSa7XocErp4Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199015)(40470700004)(46966006)(36840700001)(478600001)(47076005)(5660300002)(6512007)(36756003)(8936002)(33656002)(26005)(36860700001)(6862004)(6506007)(53546011)(316002)(336012)(86362001)(40480700001)(186003)(4326008)(54906003)(6486002)(8676002)(70586007)(2616005)(40460700003)(70206006)(2906002)(82740400003)(356005)(41300700001)(83380400001)(82310400005)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 11:22:42.8636 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f13ca81-3998-452a-9da1-08dac17b8db7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6013 Hi Ayan,, > On 8 Nov 2022, at 09:45, Ayan Kumar Halder wr= ote: >=20 > From: Ayan Kumar Halder >=20 > Xen provides helper to atomically read/write memory (see {read, > write}_atomic()). Those helpers can only work if the address is aligned > to the size of the access (see B2.2.1 ARM DDI 08476I.a). >=20 > On Arm32, the alignment is already enforced by the processor because > HSCTLR.A bit is set (it enforce alignment for every access). For Arm64, > this bit is not set because memcpy()/memset() can use unaligned access > for performance reason (the implementation is taken from the Cortex > library). >=20 > To avoid any overhead in production build, the alignment will only be > checked using an ASSERT. Note that it might be possible to do it in > production build using the acquire/exclusive version of load/store. But > this is left to a follow-up (if wanted). >=20 > Signed-off-by: Ayan Kumar Halder > Signed-off-by: Julien Grall > Reviewed-by: Michal Orzel > Reviewed-by: Bertrand Marquis I confirm my Reviewed-by. Side note: You should actually have removed it :-) Cheers Bertrand > --- >=20 > Changes from :- > v1 - 1. Referred to the latest Arm Architecture Reference Manual in the c= ommit > message. >=20 > v2 - 1. Updated commit message to specify the reason for using ASSERT(). > 2. Added Julien's SoB. >=20 > xen/arch/arm/include/asm/atomic.h | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm= /atomic.h > index 1f60c28b1b..64314d59b3 100644 > --- a/xen/arch/arm/include/asm/atomic.h > +++ b/xen/arch/arm/include/asm/atomic.h > @@ -78,6 +78,7 @@ static always_inline void read_atomic_size(const volati= le void *p, > void *res, > unsigned int size) > { > + ASSERT(IS_ALIGNED((vaddr_t)p, size)); > switch ( size ) > { > case 1: > @@ -102,6 +103,7 @@ static always_inline void write_atomic_size(volatile = void *p, > void *val, > unsigned int size) > { > + ASSERT(IS_ALIGNED((vaddr_t)p, size)); > switch ( size ) > { > case 1: > --=20 > 2.17.1 >=20 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 11:24:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 11:24:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439974.694007 (Exim 4.92) (envelope-from ) id 1osMiI-0006SE-AG; Tue, 08 Nov 2022 11:24:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439974.694007; Tue, 08 Nov 2022 11:24:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMiI-0006S7-7d; Tue, 08 Nov 2022 11:24:18 +0000 Received: by outflank-mailman (input) for mailman id 439974; Tue, 08 Nov 2022 11:24:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMiH-0006S1-4E for xen-devel@lists.xen.org; Tue, 08 Nov 2022 11:24:17 +0000 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [2607:f8b0:4864:20::1034]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dff0b4e1-5f57-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 12:24:16 +0100 (CET) Received: by mail-pj1-x1034.google.com with SMTP id l6so13535073pjj.0 for ; Tue, 08 Nov 2022 03:24:15 -0800 (PST) Received: from localhost ([122.172.84.80]) by smtp.gmail.com with ESMTPSA id z127-20020a636585000000b004308422060csm5535481pgb.69.2022.11.08.03.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 03:24:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dff0b4e1-5f57-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yOKK+9FPPU0/nPfs+Ew/J1tOJE8GcKPJPaXoeuk6IEI=; b=ImzV8I+sv5cVMkpmIUKtSqqc7g99wKYnVsganYTQb+HWYRMIfiBMr/nQTUWbcUbZ8F 6Sb0fyRx+dH/pirET5BCv2Q0b9kgxXr7wHY3jCkdEIumysCw03+6ydx7/0MBw3nM2NtK ZRo+I8dRFszxe89NuXrvucZaasqwYp0owkxSIw3LiO8ca3nuvGu97bdh08hazrpeo+lN GTXdhMdEyBo9euHncnVpFjpNGJZbDMj1K59D/6d4YzMCJ+UGLrLOC9vDacjMcdVT1j1n 1DTkzbK3zfI1wcBbnxi7wao6GIQu5/rP3kZMzOPeSmU5MCWSJPvu7ebCKYBNucI4JYW4 efQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yOKK+9FPPU0/nPfs+Ew/J1tOJE8GcKPJPaXoeuk6IEI=; b=A5lgsucU73lbC9l2KGS2/t0Xa8AZOERUEPdKv1ewBJqHQgnAPMMV3NJZroiqN1s9Sp 0qJg0nYv82asd3rw/dL1p1chauGeibItN5zCnUHV1LuXsOhq/5fbyIqVflD/cETu3181 2SAYB2BIpibMmg6Bl4eq/EX+zic/KYDX9xDmoZUVuXlwJ/Ie8ihUqv0K17Cidhae+Ccr Cvl8VWFvPUDKjie6y2Jbgf4zN/iGyzr9R7rAPxJ9WJZHKSWj3loZVrqlWPyH9F+opAi/ djAe3XaeUm/FMLQry1XrCRveNqZ2DjggMKdBFh38kEEs8Wc3fogZnnngGdHunzCH58fX sL1A== X-Gm-Message-State: ANoB5pk21jJhyhazMtDj5M0ZI4XmHS6AP6+gjaJwWpAlFZHUTwQ4mvxb /WiTZPEKqb8Qop+l2S246VDkicSX3rMGsw== X-Google-Smtp-Source: AA0mqf7tk6UDS5JBDqKsTz8bX9MQt7VH1u5sRY5bItsEdp9qkYuIXMZr6e+9c/VbfHfGnG6t5KhSwA== X-Received: by 2002:a17:902:744b:b0:188:8e6b:978a with SMTP id e11-20020a170902744b00b001888e6b978amr470348plt.11.1667906653548; Tue, 08 Nov 2022 03:24:13 -0800 (PST) From: Viresh Kumar To: xen-devel@lists.xen.org, Juergen Gross , Julien Grall , Anthony PERARD Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu Subject: [PATCH V6 0/3] Virtio toolstack support for I2C and GPIO on Arm Date: Tue, 8 Nov 2022 16:53:57 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello, This patchset adds toolstack support for I2C and GPIO virtio devices. This is inspired from the work done by Oleksandr for the Disk device. This is developed as part of Linaro's Project Stratos, where we are working towards Hypervisor agnostic Rust based backend [1]. This is based of origin/staging (e61a78981364 xen/arm: add iounmap after initrd has been loaded in domain_build) and the earlier posted cleanup patches [2]. V5->V6: - The cleanup patches are sent separately [2]. - We don't add I2C or GPIO specific device changes anymore, rather we create generic "virtio" devices. The "type" of a virtio devices helps us identify the right device, and create an entry in the DT node. The same can be used for all Virtio devices now. - Update man page xl.cfg. V4->V5: - Fixed indentation at few places. - Removed/added blank lines. - Added few comments. - Added review tags from Oleksandr. - Rebased over latest staging branch. V3->V4: - Update virtio_enabled independently of all devices, so we don't miss setting it to true. - Add iommu handling for i2c/gpio and move it as part of make_virtio_mmio_node_common(), which gets backend_domid parameter as a result. V2->V3: - Rebased over latest tree and made changes according to changes in Oleksandr's patches from sometime back. - Minor cleanups. V1->V2: - Patches 3/6 and 4/6 are new. - Patches 5/6 and 6/6 updated based on the above two patches. - Added link to the bindings for I2C and GPIO. - Rebased over latest master branch. Thanks. -- Viresh [1] https://lore.kernel.org/xen-devel/20220414092358.kepxbmnrtycz7mhe@vireshk-i7/ [2] https://lore.kernel.org/all/cover.1662626550.git.viresh.kumar@linaro.org/ Viresh Kumar (3): libxl: Add support for generic virtio device xl: Add support to parse generic virtio device docs: Add documentation for generic virtio devices docs/man/xl.cfg.5.pod.in | 21 ++++ tools/libs/light/Makefile | 1 + tools/libs/light/libxl_arm.c | 89 +++++++++++++++ tools/libs/light/libxl_create.c | 5 + tools/libs/light/libxl_internal.h | 1 + tools/libs/light/libxl_types.idl | 29 +++++ tools/libs/light/libxl_types_internal.idl | 1 + tools/libs/light/libxl_virtio.c | 127 ++++++++++++++++++++++ tools/ocaml/libs/xl/genwrap.py | 1 + tools/ocaml/libs/xl/xenlight_stubs.c | 1 + tools/xl/xl_parse.c | 84 ++++++++++++++ 11 files changed, 360 insertions(+) create mode 100644 tools/libs/light/libxl_virtio.c -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 11:24:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 11:24:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439975.694018 (Exim 4.92) (envelope-from ) id 1osMiM-0006jO-Gu; Tue, 08 Nov 2022 11:24:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439975.694018; Tue, 08 Nov 2022 11:24:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMiM-0006jH-E3; Tue, 08 Nov 2022 11:24:22 +0000 Received: by outflank-mailman (input) for mailman id 439975; Tue, 08 Nov 2022 11:24:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMiK-0006iF-UF for xen-devel@lists.xen.org; Tue, 08 Nov 2022 11:24:21 +0000 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [2607:f8b0:4864:20::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e2817fa5-5f57-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 12:24:19 +0100 (CET) Received: by mail-pl1-x62e.google.com with SMTP id g24so13914244plq.3 for ; Tue, 08 Nov 2022 03:24:19 -0800 (PST) Received: from localhost ([122.172.84.80]) by smtp.gmail.com with ESMTPSA id k26-20020aa7973a000000b0056da2ad6503sm6189458pfg.39.2022.11.08.03.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 03:24:17 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2817fa5-5f57-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yWwLVsCfFGrMeQAxaHGExsLxmZy4kqtiAA8c8/+74wg=; b=dXWHyLAcc3S4YeQjOK/o9jRLk8+0FaUhy4e1P73qU9oEvps0On1zaJaLiyRhrvzJy+ NEzOSt3ZuUSJjki+Y/kt6VAzAGSy15HTF4WdWvGu2c5WD/GmdiEzBhmng80v3VF0NzJO jVrdopY9He9wQiFGm1yu4N9mjtzPzlMBZ9CmRIGTgRu+E6wTSz1jaAcTs7yHYqFlUm0r kGuLwo+aUcur1xH2GrUvTGVvWC5ZGiuBAtObQEUcV527s1T8dSow5GyRPhWvqDp5+WH6 Eip1xKkLxXOm93eQjniMsW8c9+H+WHCwI1gs9kWy+aVDGgp0XpgU/4PKbjmKmOqGw9ww YqLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yWwLVsCfFGrMeQAxaHGExsLxmZy4kqtiAA8c8/+74wg=; b=uiPQ6Gc/vNI3RCSx3hw1aZ2kyZMTrPAmd0cKVaeQ8sBMUGmrOPE8Os1E9+gVEzVAWs eI4zRggcIHrE24AvvBYsiuFyhKcZ3vE2w+qLcopyLiXpa0bharcKbDiK5ELsrbsAJj4W 14Az5kTxN5oYslrMO9DlvmGNtT8E4jcA/YVt9pNj5Nnj1Eu7BqHGUEQGR+CizKoWngIf J1+emLTk3twi9mLduyb1b+TTQSwrcbgTV1wNUseeYiN9NSdnEc6xTmnULjMOEjpeHCkz IkWwgIRLz0WwimxULytD0oPBGukTkYxPTxTmCXRN5jjCqKXYzUWRtyw/tocv02TwGh97 TmGw== X-Gm-Message-State: ACrzQf3xHLoq4zLaR1Skal5US947ZcEo/rRd9z8SH3R/M8WkzUqYkwS+ 6Ni1PZ2WQ2ljK9mMPD8hWSgnxXOxyuo9rA== X-Google-Smtp-Source: AMsMyM4pOZa7NXejO3RVIXXQdy76dSHf4MToE6NUCw4xUtbvccbhkrfxnzyXZhJEbNmiZ1OrXKfMlA== X-Received: by 2002:a17:90b:38ca:b0:214:2cff:fbb5 with SMTP id nn10-20020a17090b38ca00b002142cfffbb5mr34811900pjb.79.1667906657905; Tue, 08 Nov 2022 03:24:17 -0800 (PST) From: Viresh Kumar To: xen-devel@lists.xen.org, Juergen Gross , Julien Grall , Anthony PERARD Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu Subject: [PATCH V6 1/3] libxl: Add support for generic virtio device Date: Tue, 8 Nov 2022 16:53:58 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch adds basic support for configuring and assisting generic Virtio backend which could run in any domain. An example of domain configuration for mmio based Virtio I2C device is: virtio = ["type=virtio,device22,transport=mmio"] Also to make this work on Arm, allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend. Update guest device-tree as well to create a DT node for the Virtio devices. Signed-off-by: Viresh Kumar --- tools/libs/light/Makefile | 1 + tools/libs/light/libxl_arm.c | 89 +++++++++++++++ tools/libs/light/libxl_create.c | 5 + tools/libs/light/libxl_internal.h | 1 + tools/libs/light/libxl_types.idl | 29 +++++ tools/libs/light/libxl_types_internal.idl | 1 + tools/libs/light/libxl_virtio.c | 127 ++++++++++++++++++++++ 7 files changed, 253 insertions(+) create mode 100644 tools/libs/light/libxl_virtio.c diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 374be1cfab25..4fddcc6f51d7 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -106,6 +106,7 @@ OBJS-y += libxl_vdispl.o OBJS-y += libxl_pvcalls.o OBJS-y += libxl_vsnd.o OBJS-y += libxl_vkb.o +OBJS-y += libxl_virtio.o OBJS-y += libxl_genid.o OBJS-y += _libxl_types.o OBJS-y += libxl_flask.o diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index b4928dbf673c..f33c9b273a4f 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -113,6 +113,19 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, } } + for (i = 0; i < d_config->num_virtios; i++) { + libxl_device_virtio *virtio = &d_config->virtios[i]; + + if (virtio->transport != LIBXL_VIRTIO_TRANSPORT_MMIO) + continue; + + rc = alloc_virtio_mmio_params(gc, &virtio->base, &virtio->irq, + &virtio_mmio_base, &virtio_mmio_irq); + + if (rc) + return rc; + } + /* * Every virtio-mmio device uses one emulated SPI. If Virtio devices are * present, make sure that we allocate enough SPIs for them. @@ -968,6 +981,68 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, uint64_t base, return fdt_end_node(fdt); } +static int make_virtio_mmio_node_i2c(libxl__gc *gc, void *fdt) +{ + int res; + + res = fdt_begin_node(fdt, "i2c"); + if (res) return res; + + res = fdt_property_compat(gc, fdt, 1, "virtio,device22"); + if (res) return res; + + return fdt_end_node(fdt); +} + +static int make_virtio_mmio_node_gpio(libxl__gc *gc, void *fdt) +{ + int res; + + res = fdt_begin_node(fdt, "gpio"); + if (res) return res; + + res = fdt_property_compat(gc, fdt, 1, "virtio,device29"); + if (res) return res; + + res = fdt_property(fdt, "gpio-controller", NULL, 0); + if (res) return res; + + res = fdt_property_cell(fdt, "#gpio-cells", 2); + if (res) return res; + + res = fdt_property(fdt, "interrupt-controller", NULL, 0); + if (res) return res; + + res = fdt_property_cell(fdt, "#interrupt-cells", 2); + if (res) return res; + + return fdt_end_node(fdt); +} + +static int make_virtio_mmio_node_device(libxl__gc *gc, void *fdt, uint64_t base, + uint32_t irq, const char *type, + uint32_t backend_domid) +{ + int res, len = strlen(type); + + res = make_virtio_mmio_node_common(gc, fdt, base, irq, backend_domid); + if (res) return res; + + /* Add device specific nodes */ + if (!strncmp(type, "virtio,device22", len)) { + res = make_virtio_mmio_node_i2c(gc, fdt); + if (res) return res; + } else if (!strncmp(type, "virtio,device29", len)) { + res = make_virtio_mmio_node_gpio(gc, fdt); + if (res) return res; + } else { + LOG(ERROR, "Invalid type for virtio device: %s", type); + return -EINVAL; + } + + return fdt_end_node(fdt); +} + static const struct arch_info *get_arch_info(libxl__gc *gc, const struct xc_dom_image *dom) { @@ -1290,6 +1365,20 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, } } + for (i = 0; i < d_config->num_virtios; i++) { + libxl_device_virtio *virtio = &d_config->virtios[i]; + + if (virtio->transport != LIBXL_VIRTIO_TRANSPORT_MMIO) + continue; + + if (virtio->backend_domid != LIBXL_TOOLSTACK_DOMID) + iommu_needed = true; + + FDT( make_virtio_mmio_node_device(gc, fdt, virtio->base, + virtio->irq, virtio->type, + virtio->backend_domid) ); + } + /* * Note, this should be only called after creating all virtio-mmio * device nodes diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index 612eacfc7fac..15a32c75c045 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -1802,6 +1802,11 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, &d_config->vkbs[i]); } + for (i = 0; i < d_config->num_virtios; i++) { + libxl__device_add(gc, domid, &libxl__virtio_devtype, + &d_config->virtios[i]); + } + if (d_config->b_info.arch_arm.vuart == LIBXL_VUART_TYPE_SBSA_UART) { init_console_info(gc, &vuart, 0); vuart.backend_domid = state->console_domid; diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index cb9e8b3b8b5a..e5716f9bef80 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -4003,6 +4003,7 @@ static inline int *libxl__device_type_get_num( extern const libxl__device_type libxl__vfb_devtype; extern const libxl__device_type libxl__vkb_devtype; +extern const libxl__device_type libxl__virtio_devtype; extern const libxl__device_type libxl__disk_devtype; extern const libxl__device_type libxl__nic_devtype; extern const libxl__device_type libxl__vtpm_devtype; diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index d634f304cda2..d97a0795d312 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -278,6 +278,14 @@ libxl_vkb_backend = Enumeration("vkb_backend", [ (2, "LINUX") ]) +libxl_virtio_backend = Enumeration("virtio_backend", [ + (1, "STANDALONE") + ]) + +libxl_virtio_transport = Enumeration("virtio_transport", [ + (1, "MMIO"), + ]) + libxl_passthrough = Enumeration("passthrough", [ (0, "default"), (1, "disabled"), @@ -705,6 +713,17 @@ libxl_device_vkb = Struct("device_vkb", [ ("multi_touch_num_contacts", uint32) ]) +libxl_device_virtio = Struct("device_virtio", [ + ("backend_domid", libxl_domid), + ("backend_domname", string), + ("backend", libxl_virtio_backend), + ("type", string), + ("transport", libxl_virtio_transport), + ("devid", libxl_devid), + ("irq", uint32), + ("base", uint64) + ]) + libxl_device_disk = Struct("device_disk", [ ("backend_domid", libxl_domid), ("backend_domname", string), @@ -982,6 +1001,7 @@ libxl_domain_config = Struct("domain_config", [ ("dtdevs", Array(libxl_device_dtdev, "num_dtdevs")), ("vfbs", Array(libxl_device_vfb, "num_vfbs")), ("vkbs", Array(libxl_device_vkb, "num_vkbs")), + ("virtios", Array(libxl_device_virtio, "num_virtios")), ("vtpms", Array(libxl_device_vtpm, "num_vtpms")), ("p9s", Array(libxl_device_p9, "num_p9s")), ("pvcallsifs", Array(libxl_device_pvcallsif, "num_pvcallsifs")), @@ -1145,6 +1165,15 @@ libxl_vkbinfo = Struct("vkbinfo", [ ("rref", integer) ], dir=DIR_OUT) +libxl_virtioinfo = Struct("virtioinfo", [ + ("backend", string), + ("backend_id", uint32), + ("frontend", string), + ("frontend_id", uint32), + ("devid", libxl_devid), + ("state", integer), + ], dir=DIR_OUT) + # NUMA node characteristics: size and free are how much memory it has, and how # much of it is free, respectively. dists is an array of distances from this # node to each other node. diff --git a/tools/libs/light/libxl_types_internal.idl b/tools/libs/light/libxl_types_internal.idl index fb0f4f23d7c2..e24288f1a59e 100644 --- a/tools/libs/light/libxl_types_internal.idl +++ b/tools/libs/light/libxl_types_internal.idl @@ -33,6 +33,7 @@ libxl__device_kind = Enumeration("device_kind", [ (15, "VSND"), (16, "VINPUT"), (17, "VIRTIO_DISK"), + (18, "VIRTIO"), ]) libxl__console_backend = Enumeration("console_backend", [ diff --git a/tools/libs/light/libxl_virtio.c b/tools/libs/light/libxl_virtio.c new file mode 100644 index 000000000000..14b0c016a0a2 --- /dev/null +++ b/tools/libs/light/libxl_virtio.c @@ -0,0 +1,127 @@ +/* + * Copyright (C) 2022 Linaro Ltd. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include "libxl_internal.h" + +static int libxl__device_virtio_setdefault(libxl__gc *gc, uint32_t domid, + libxl_device_virtio *virtio, + bool hotplug) +{ + return libxl__resolve_domid(gc, virtio->backend_domname, + &virtio->backend_domid); +} + +static int libxl__device_from_virtio(libxl__gc *gc, uint32_t domid, + libxl_device_virtio *virtio, + libxl__device *device) +{ + device->backend_devid = virtio->devid; + device->backend_domid = virtio->backend_domid; + device->devid = virtio->devid; + device->domid = domid; + + device->backend_kind = LIBXL__DEVICE_KIND_VIRTIO; + device->kind = LIBXL__DEVICE_KIND_VIRTIO; + + return 0; +} + +static int libxl__set_xenstore_virtio(libxl__gc *gc, uint32_t domid, + libxl_device_virtio *virtio, + flexarray_t *back, flexarray_t *front, + flexarray_t *ro_front) +{ + const char *transport = libxl_virtio_transport_to_string(virtio->transport); + + flexarray_append_pair(back, "irq", GCSPRINTF("%u", virtio->irq)); + flexarray_append_pair(back, "base", GCSPRINTF("%lu", virtio->base)); + flexarray_append_pair(back, "type", GCSPRINTF("%s", virtio->type)); + flexarray_append_pair(back, "transport", GCSPRINTF("%s", transport)); + + flexarray_append_pair(front, "irq", GCSPRINTF("%u", virtio->irq)); + flexarray_append_pair(front, "base", GCSPRINTF("%lu", virtio->base)); + flexarray_append_pair(front, "type", GCSPRINTF("%s", virtio->type)); + flexarray_append_pair(front, "transport", GCSPRINTF("%s", transport)); + + return 0; +} + +static int libxl__virtio_from_xenstore(libxl__gc *gc, const char *libxl_path, + libxl_devid devid, + libxl_device_virtio *virtio) +{ + const char *be_path, *fe_path, *tmp; + libxl__device dev; + int rc; + + virtio->devid = devid; + + rc = libxl__xs_read_mandatory(gc, XBT_NULL, + GCSPRINTF("%s/backend", libxl_path), + &be_path); + if (rc) goto out; + + rc = libxl__xs_read_mandatory(gc, XBT_NULL, + GCSPRINTF("%s/frontend", libxl_path), + &fe_path); + if (rc) goto out; + + rc = libxl__backendpath_parse_domid(gc, be_path, &virtio->backend_domid); + if (rc) goto out; + + rc = libxl__parse_backend_path(gc, be_path, &dev); + if (rc) goto out; + + rc = libxl__xs_read_checked(gc, XBT_NULL, + GCSPRINTF("%s/irq", be_path), &tmp); + if (rc) goto out; + + if (tmp) { + virtio->irq = strtoul(tmp, NULL, 0); + } + + rc = libxl__xs_read_checked(gc, XBT_NULL, + GCSPRINTF("%s/base", be_path), &tmp); + if (rc) goto out; + + if (tmp) { + virtio->base = strtoul(tmp, NULL, 0); + } + + rc = 0; + +out: + + return rc; +} + +static LIBXL_DEFINE_UPDATE_DEVID(virtio) + +#define libxl__add_virtios NULL +#define libxl_device_virtio_compare NULL + +DEFINE_DEVICE_TYPE_STRUCT(virtio, VIRTIO, virtios, + .set_xenstore_config = (device_set_xenstore_config_fn_t) + libxl__set_xenstore_virtio, + .from_xenstore = (device_from_xenstore_fn_t)libxl__virtio_from_xenstore, + .skip_attach = 1 +); + +/* + * Local variables: + * mode: C + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 11:24:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 11:24:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439976.694029 (Exim 4.92) (envelope-from ) id 1osMiS-00074Z-Nz; Tue, 08 Nov 2022 11:24:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439976.694029; Tue, 08 Nov 2022 11:24:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMiS-00073j-Kp; Tue, 08 Nov 2022 11:24:28 +0000 Received: by outflank-mailman (input) for mailman id 439976; Tue, 08 Nov 2022 11:24:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMiR-0006S1-Cr for xen-devel@lists.xen.org; Tue, 08 Nov 2022 11:24:27 +0000 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [2607:f8b0:4864:20::1034]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e6a6b81e-5f57-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 12:24:26 +0100 (CET) Received: by mail-pj1-x1034.google.com with SMTP id m14-20020a17090a3f8e00b00212dab39bcdso17645849pjc.0 for ; Tue, 08 Nov 2022 03:24:26 -0800 (PST) Received: from localhost ([122.172.84.80]) by smtp.gmail.com with ESMTPSA id u9-20020a17090a3fc900b00200461cfa99sm7754719pjm.11.2022.11.08.03.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 03:24:20 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6a6b81e-5f57-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=obQ8DZ5BACOYz3wKPJhR8jMno97FAVM9CyAho1QNHtU=; b=nVYHAI3sksJD2yknMbxKHfKQFu00MZDzVrbCEykWA85twFbEAZ1toG3GjsTJvXPA3d VjNpakqVoseWB1FrzcB5Pxza5WQ7w0HRey9z0+jxDJi3Zuu6TCbcnLVl3aWLuwX185nt aNHHIy7eG155pbz1NmU1d8nL2uG8CzsfM3DJ160XMjLY+ugegeEooIYWFcepc2la5rL+ wDGqbouymHRZfMj8Ynb6FtfVUJYl2I2tmUdH1wc+k6xh44BpLxUBP/TSsJrikaLsYlOq rh0+oC4H0iby0Av23Jks+J0Rug2muhVWDhq4uqu6PMubjfriqU0ew94LRrWmwaL+xQZn tIrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=obQ8DZ5BACOYz3wKPJhR8jMno97FAVM9CyAho1QNHtU=; b=GP+dcs9wi/vQLJcSYMix8HZ3BfbNBoywxPx8BIaPdy4DPYHBzVagGtRgE1e7+gLZeT gfzAYhl0kon2IngLKWqSgr4rwZPVrQmOy5PH2FHFJU1+KQu0dHRMemaU++2+UYkuYebf P17X7BKmLZeAL2RJTESMWOYqKC9G1YFZPm5ncqWjano6/p5I5lrq5fNxhHDaEKU4Wk8e ct5l7YqrpOQq5eM64eRgYnYRP1dpdUfJWYQp0zrf9uE+eeLdibzMKnETKbI7e3b8M4lX eSr3GsyMapW5dmTi5UIWLGv6EXsnRuDZVqpWitJgDR4Ni1Oe8dsg4I5VES59DYbHr9In 44RA== X-Gm-Message-State: ACrzQf30wW4VlPeF3BC2NzaZPUQY7DzKO1GxKqmxgpoDs5WNvqlfuYLE 7YFhD3gnoVvoH7O7nwlm3X5k2DmHC9Ccwg== X-Google-Smtp-Source: AMsMyM5S+xvSbtuyQCGITbssl4YxD30xFW0fcg8YeyElkvcQSPzwLPQRwxIPekz5tbxFH9eT2duHBw== X-Received: by 2002:a17:902:e8cd:b0:186:9efc:6790 with SMTP id v13-20020a170902e8cd00b001869efc6790mr55901025plg.91.1667906664869; Tue, 08 Nov 2022 03:24:24 -0800 (PST) From: Viresh Kumar To: xen-devel@lists.xen.org, Juergen Gross , Julien Grall , Anthony PERARD Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu Subject: [PATCH V6 2/3] xl: Add support to parse generic virtio device Date: Tue, 8 Nov 2022 16:53:59 +0530 Message-Id: <73663851c5223b99ed0f23a163a0d44cba0ebe29.1667906228.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch adds basic support for parsing generic Virtio backend. An example of domain configuration for mmio based Virtio I2C device is: virtio = ["type=virtio,device22,transport=mmio"] Signed-off-by: Viresh Kumar --- tools/ocaml/libs/xl/genwrap.py | 1 + tools/ocaml/libs/xl/xenlight_stubs.c | 1 + tools/xl/xl_parse.c | 84 ++++++++++++++++++++++++++++ 3 files changed, 86 insertions(+) diff --git a/tools/ocaml/libs/xl/genwrap.py b/tools/ocaml/libs/xl/genwrap.py index 7bf26bdcd831..b188104299b1 100644 --- a/tools/ocaml/libs/xl/genwrap.py +++ b/tools/ocaml/libs/xl/genwrap.py @@ -36,6 +36,7 @@ DEVICE_LIST = [ ("list", ["ctx", "domid", "t list"]), functions = { # ( name , [type1,type2,....] ) "device_vfb": DEVICE_FUNCTIONS, "device_vkb": DEVICE_FUNCTIONS, + "device_virtio": DEVICE_FUNCTIONS, "device_disk": DEVICE_FUNCTIONS + DEVICE_LIST + [ ("insert", ["ctx", "t", "domid", "?async:'a", "unit", "unit"]), ("of_vdev", ["ctx", "domid", "string", "t"]), diff --git a/tools/ocaml/libs/xl/xenlight_stubs.c b/tools/ocaml/libs/xl/xenlight_stubs.c index 45b8af61c74a..8e54f95da7c7 100644 --- a/tools/ocaml/libs/xl/xenlight_stubs.c +++ b/tools/ocaml/libs/xl/xenlight_stubs.c @@ -707,6 +707,7 @@ DEVICE_ADDREMOVE(disk) DEVICE_ADDREMOVE(nic) DEVICE_ADDREMOVE(vfb) DEVICE_ADDREMOVE(vkb) +DEVICE_ADDREMOVE(virtio) DEVICE_ADDREMOVE(pci) _DEVICE_ADDREMOVE(disk, cdrom, insert) diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 1b5381cef033..c6f35c069d2a 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1208,6 +1208,87 @@ static void parse_vkb_list(const XLU_Config *config, if (rc) exit(EXIT_FAILURE); } +static int parse_virtio_config(libxl_device_virtio *virtio, char *token) +{ + char *oparg; + int rc; + + if (MATCH_OPTION("backend", token, oparg)) { + virtio->backend_domname = strdup(oparg); + } else if (MATCH_OPTION("type", token, oparg)) { + virtio->type = strdup(oparg); + } else if (MATCH_OPTION("transport", token, oparg)) { + rc = libxl_virtio_transport_from_string(oparg, &virtio->transport); + if (rc) return rc; + } else if (MATCH_OPTION("irq", token, oparg)) { + virtio->irq = strtoul(oparg, NULL, 0); + } else if (MATCH_OPTION("base", token, oparg)) { + virtio->base = strtoul(oparg, NULL, 0); + } else { + fprintf(stderr, "Unknown string \"%s\" in virtio spec\n", token); + return -1; + } + + return 0; +} + +static void parse_virtio_list(const XLU_Config *config, + libxl_domain_config *d_config) +{ + XLU_ConfigList *virtios; + const char *item; + char *buf = NULL, *oparg, *str = NULL; + int rc; + + if (!xlu_cfg_get_list (config, "virtio", &virtios, 0, 0)) { + int entry = 0; + while ((item = xlu_cfg_get_listitem(virtios, entry)) != NULL) { + libxl_device_virtio *virtio; + char *p; + + virtio = ARRAY_EXTEND_INIT(d_config->virtios, d_config->num_virtios, + libxl_device_virtio_init); + + buf = strdup(item); + + p = strtok(buf, ","); + while (p != NULL) + { + while (*p == ' ') p++; + + // Type may contain a comma, do special handling. + if (MATCH_OPTION("type", p, oparg)) { + if (!strncmp(oparg, "virtio", strlen("virtio"))) { + char *p2 = strtok(NULL, ","); + str = malloc(strlen(p) + strlen(p2) + 2); + + strcpy(str, p); + strcat(str, ","); + strcat(str, p2); + p = str; + } + } + + rc = parse_virtio_config(virtio, p); + if (rc) goto out; + + free(str); + str = NULL; + p = strtok(NULL, ","); + } + + entry++; + free(buf); + } + } + + return; + +out: + free(buf); + if (rc) exit(EXIT_FAILURE); +} + void parse_config_data(const char *config_source, const char *config_data, int config_len, @@ -2309,8 +2390,10 @@ void parse_config_data(const char *config_source, d_config->num_vfbs = 0; d_config->num_vkbs = 0; + d_config->num_virtios = 0; d_config->vfbs = NULL; d_config->vkbs = NULL; + d_config->virtios = NULL; if (!xlu_cfg_get_list (config, "vfb", &cvfbs, 0, 0)) { while ((buf = xlu_cfg_get_listitem (cvfbs, d_config->num_vfbs)) != NULL) { @@ -2752,6 +2835,7 @@ void parse_config_data(const char *config_source, } parse_vkb_list(config, d_config); + parse_virtio_list(config, d_config); xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat", &c_info->xend_suspend_evtchn_compat, 0); -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 11:24:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 11:24:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.439977.694040 (Exim 4.92) (envelope-from ) id 1osMiV-0007Ns-4z; Tue, 08 Nov 2022 11:24:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 439977.694040; Tue, 08 Nov 2022 11:24:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMiV-0007NZ-12; Tue, 08 Nov 2022 11:24:31 +0000 Received: by outflank-mailman (input) for mailman id 439977; Tue, 08 Nov 2022 11:24:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMiT-0006S1-Lx for xen-devel@lists.xen.org; Tue, 08 Nov 2022 11:24:29 +0000 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [2607:f8b0:4864:20::431]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e824af50-5f57-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 12:24:29 +0100 (CET) Received: by mail-pf1-x431.google.com with SMTP id b185so13531509pfb.9 for ; Tue, 08 Nov 2022 03:24:28 -0800 (PST) Received: from localhost ([122.172.84.80]) by smtp.gmail.com with ESMTPSA id n6-20020a170903110600b001865c298588sm6677765plh.258.2022.11.08.03.24.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 03:24:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e824af50-5f57-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4O5etID8pnJ+mOBEfmxIpjayhQN9TbUVsRBMhrbeh44=; b=NCjoYqLzGCF5lUfugIxT0rR9KaqTtPk0rXEL13eqJQojws8POkXXPr3CRRkY+y4K3D NvIGuyf6Vmk8CWW11agxMhUkscJjnD0m7QvpGJ2zcmBy03sG44IqD8qRKq7MRkNLzIP9 W4qfed7DoWIqs8fZqy7TfceQPQCTz/OLQ67SfG1XpMTebMzG9FstJKbQHAA3SbS3FTLV nsjBwbtZsM7/T+kirM3QtQItPb4B/vwepXaSwjJrU6N1qJUARWP9ca4b/ZaAoQTaeLNf OpKPFcX824Vp8As3cl7Pjlm4dXa1zHJM/04u3w/gm/Fb8v001z/FCSPjqvqm7mmdhaDT BUqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4O5etID8pnJ+mOBEfmxIpjayhQN9TbUVsRBMhrbeh44=; b=QcUQ6ImpxmnCbjZW5WfYD78M+xTJQ+sW99EPUTxpL9+rZU/5bwMpNqp1a+Lkxj8YXw c2y5Oplj/vupckRZrX8Hgi9O2bcpG0PMGAYN/6evyj0p9r6Ew2DlpRUwD/fti9Ut9+qI VIA11KF+kobHYgNwgPv/fJZfyE9ilsSlioA97gYdCIxxCJ2cFvW4Cb+emUy5bvYYrD/z mVcUOff6NJarwwqmPjfgvQtLKNuJHLwYj02SjMBXZC+s1V9v8pbacnc8VcqnB1UQYFtT ymIZ+nXR4qCeD4vrTVmPkmoQpmpJPyr4nepc7/tQUw3Or+rvKJcNddPRPHSigY4yhIiQ 7p/Q== X-Gm-Message-State: ACrzQf0Zr7WXT7o6zMg8QfHq9hFUYs8BtyMhpqXBOMtHtVYHJPbgjzzL WoecKUcyIZLriGPtkCWu7ZpcdXmiwr5hXA== X-Google-Smtp-Source: AMsMyM7OwRKvh4arUDf2IMW8MGEbBtDR2PFf/GJH4pH79GdWyFn2gsPOcsdW7kYp833YO+wkRtyIpg== X-Received: by 2002:a63:4420:0:b0:470:89:8e7c with SMTP id r32-20020a634420000000b0047000898e7cmr31541733pga.150.1667906667403; Tue, 08 Nov 2022 03:24:27 -0800 (PST) From: Viresh Kumar To: xen-devel@lists.xen.org, Juergen Gross , Julien Grall , Anthony PERARD Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu Subject: [PATCH V6 3/3] docs: Add documentation for generic virtio devices Date: Tue, 8 Nov 2022 16:54:00 +0530 Message-Id: <24a0278313ea9a9e6c093880dead835184025734.1667906228.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch updates xl.cfg man page with details of generic Virtio device related information. Signed-off-by: Viresh Kumar --- docs/man/xl.cfg.5.pod.in | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 31e58b73b0c9..1056b03df846 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -1585,6 +1585,27 @@ Set maximum height for pointer device. =back +=item B + +Specifies the Virtio devices to be provided to the guest. + +Each B is a comma-separated list of C +settings from the following list: + +=over 4 + +=item B + +Specifies the compatible string for the specific Virtio device. The same will be +written in the Device Tree compatible property of the Virtio device. For +example, "type=virtio,device22" for the I2C device. + +=item B + +Specifies the transport mechanism for the Virtio device, like "mmio" or "pci". + +=back + =item B B Set TEE type for the guest. TEE is a Trusted Execution -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 11:32:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 11:32:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440000.694051 (Exim 4.92) (envelope-from ) id 1osMq4-0001Vg-VN; Tue, 08 Nov 2022 11:32:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440000.694051; Tue, 08 Nov 2022 11:32:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMq4-0001VZ-Qi; Tue, 08 Nov 2022 11:32:20 +0000 Received: by outflank-mailman (input) for mailman id 440000; Tue, 08 Nov 2022 11:32:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMq4-0001VT-2H for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 11:32:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMpu-00046T-DG; Tue, 08 Nov 2022 11:32:10 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[192.168.3.98]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1osMpu-0002C1-5m; Tue, 08 Nov 2022 11:32:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=AGZy5J90T/G3qtYKMfEanDERIn0ve4m192F7lR1tzWE=; b=TUfcqDrUUC+bLjIOGrkaI38z3d EO6MGx47W7AMJ4Mn1h0HpeaV/UHjWQ5X3Bip7GX044dP3jn+J2pVKFAfTTjHct1Zn5JqNqht98Rpb 1n+tZbMePaaokpyaakHGMzjy4aapZKvbRGXiPU415z4omqRN/3vFE1P276to5L/FExS0=; Message-ID: Date: Tue, 8 Nov 2022 11:32:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h Content-Language: en-US To: Luca Fancellu Cc: Jan Beulich , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-5-luca.fancellu@arm.com> <5caf911d-e96d-39e4-d945-db6537412f60@suse.com> <3925276F-8B6E-4B19-9EC2-C085FE88A637@arm.com> <933c4227-5839-312e-3996-693a7d8f7706@suse.com> <5B9130CD-BC40-42E3-8D79-DABC321AFF13@arm.com> From: Julien Grall In-Reply-To: <5B9130CD-BC40-42E3-8D79-DABC321AFF13@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Luca, On 08/11/2022 11:00, Luca Fancellu wrote: > > >> On 7 Nov 2022, at 19:06, Julien Grall wrote: >> >> >> >> On 07/11/2022 12:56, Jan Beulich wrote: >>> On 07.11.2022 12:53, Luca Fancellu wrote: >>>>> On 7 Nov 2022, at 11:49, Jan Beulich wrote: >>>>> On 07.11.2022 11:47, Luca Fancellu wrote: >>>>>> --- a/xen/include/xen/kernel.h >>>>>> +++ b/xen/include/xen/kernel.h >>>>>> @@ -65,24 +65,28 @@ >>>>>> 1; \ >>>>>> }) >>>>>> >>>>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>>>> extern char _start[], _end[], start[]; >>>>>> #define is_kernel(p) ({ \ >>>>>> char *__p = (char *)(unsigned long)(p); \ >>>>>> (__p >= _start) && (__p < _end); \ >>>>>> }) >>>>>> >>>>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>>>> extern char _stext[], _etext[]; >>>>>> #define is_kernel_text(p) ({ \ >>>>>> char *__p = (char *)(unsigned long)(p); \ >>>>>> (__p >= _stext) && (__p < _etext); \ >>>>>> }) >>>>>> >>>>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>>>> extern const char _srodata[], _erodata[]; >>>>>> #define is_kernel_rodata(p) ({ \ >>>>>> const char *__p = (const char *)(unsigned long)(p); \ >>>>>> (__p >= _srodata) && (__p < _erodata); \ >>>>>> }) >>>>>> >>>>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>>>> extern char _sinittext[], _einittext[]; >>>>>> #define is_kernel_inittext(p) ({ \ >>>>>> char *__p = (char *)(unsigned long)(p); \ >>>>> >>>>> Why the "R8.6" everywhere here? Didn't we agree that the in-code >>>>> comments should be tool-agnostic? >>>> >>>> The R8.6 is not tool specific, it is to give the quick hint that we are deviating >>>> from MISRA Rule 8.6. >>> Well, yes, "tool" was wrong for me to write. Imo references to a specific >>> spec should equally be avoided in in-code comments, as other specs may >>> turn up. >> >> +1. The comment duplication is not great and sometimes even a short explanation it may not fit in 80 characters (AFAICT the justification should be a one line comment). >> > > Ok we can remove the R8.6 from the comments, is the remaining part ok? I am afraid no. The comment should only be /* SAF-0-safe */. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 08 11:39:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 11:39:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440010.694062 (Exim 4.92) (envelope-from ) id 1osMws-0002O7-Lp; Tue, 08 Nov 2022 11:39:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440010.694062; Tue, 08 Nov 2022 11:39:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMws-0002O0-Ij; Tue, 08 Nov 2022 11:39:22 +0000 Received: by outflank-mailman (input) for mailman id 440010; Tue, 08 Nov 2022 11:39:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osMwq-0002Nu-Pw for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 11:39:20 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f9cef45c-5f59-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 12:39:18 +0100 (CET) Received: from mail-bn7nam10lp2107.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Nov 2022 06:39:11 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB6747.namprd03.prod.outlook.com (2603:10b6:a03:40a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Tue, 8 Nov 2022 11:39:09 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.025; Tue, 8 Nov 2022 11:39:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9cef45c-5f59-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667907558; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=58ZD3/jE90zkuiDXhR1Z9QDeDp4KrVJlX2KilyZXQS4=; b=AbobeuOTeogUTgVka2OYYHUXV3qDFQlr4Xdjy2XjgzwcPigwMf8P3ZyX A9GnafLwIKxWNKIy70UJ12IEJj795Q2bmUPO2CL9anaC8W1nW8tcLJUz1 xKXBwM6VGg+YeaUaNrDSAKrKLVwuw+akLLPbfiwjqBHBtDRyIuUZSwmV3 8=; X-IronPort-RemoteIP: 104.47.70.107 X-IronPort-MID: 86915644 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:mYwPoK0+aKOdj4g5sPbD5eBwkn2cJEfYwER7XKvMYLTBsI5bpzRVz jcaUDiOPPaJZDanfdogPYm1/UMAvJ7RnIRiGgM/pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVmNagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfLkQex f8kGjw2bxmu1rO3yuuRWPtIr5F2RCXrFNt3VnBI6xj8VK5ja7acBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouy6KlFMZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r82L6WwH2nBOr+EpWF8PIx0GysyFBPSzMIcAOKi+jmjRWXDoc3x 0s8v3BGQbIJ3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsbjNHcs1gi8YwShQjz FrPlNTsbRRturCITXOW9p+PsCi/fyMSKAcqeissXQYDpd75r+kOYgnnS99iFOu/iILzEDSpm zSS9nFm2PMUkNIB0Li98RbfmTWwq5PVTwkzoALKQmai6QA/b4mgD2C11WXmAT97BN7xZjG8U LIswqByMMhm4UmxqRGw IronPort-HdrOrdr: A9a23:GfCMoKqoMXsWprTyOh/QBJMaV5vEL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwI080kqQFmbX5XI3SJTUO3VHFEGgM1/qH/9SNIU3DH41mpN pdmtZFebrN5DFB5K6VgTVQe+xQuuVvm5rY4Ns2oU0dLj2DPMpbnnxE40ugYzlLbTgDIaB8OI uX58JBqTblUXMLbv6jDn1Ae+TYvdXEmL/vfBZDXnccmX+zpALtzIS/PwmT3x8YXT8K6bA+8V Ldmwi8wqm4qfm0xjLVymeWxZVLn9nKzMdFGaW3+78oAwSprjztSJVqWrWEsjxwiOaz6GwymN 2JmBskN9Qb0QKjQkiF5T/WnyXw2jcn7HHvjXWCh2H4nMD/TDUmT+JcmINwaHLimgAdleA59J gO83OStpJRAx+Ftj/6/cL0WxZjkVfxiWY+kNQUk2dUXeIlGfRsRLQkjQ9o+ao7bW3HANhNKp ghMCic3ocfTbqiVQGVgoE1q+bcH0jaHX+9Mzg/U4KuonhrdUtCvjUlLfwk7ws9Ha0GOuZ5Dp z/Q8JVfZF1P70rhPFGdZI8aPryLFDxajTxF0/XCWjbNcg8SgPwQtjMkfwI2N0= X-IronPort-AV: E=Sophos;i="5.96,147,1665460800"; d="scan'208";a="86915644" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EitHfZOpkcPa7bzv7OKL5Z22f2SIJo/mMQxnNi9FD4SJhCkAhf7Mkq7DxPijq02lNXR9teqc9MfPRSuWnxYKk7lenxsRALnRNWMGaWxtu29wKjF69py3E1axzOZtioEaiNpCRB+Od61JHSp+Ax0jFfz8Wxv2p76vAo8bacP/waONrl2Uab6LWTDjj/wVgTr+hsKIZoG7kLA0ABwnVE5Dx1iq47ZA4Nu+ceW+9AyDDcD2OZAakpCh6xe+13cvxXO9ut6i0fklC8L9X/4/y08rzejojResVIgakz0DKQwEpe+EgML+eEJOnadRpnm+PlNEQE7EGr1IzuQw7TCEzQk2gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PuHguRhkn384S2div7GHC9RgTOUnCSdIgdLDcC0eJSc=; b=bsEVIgIY1KrWz4haKP2DON1DNQsjCgV4lT/zEpO30UD3Vxd61OfBMojtrSsOANxHuMblvSVNbx8xSpwNZzZD++zVME6ysOSWakjQVUuqNTNy9YGdpZ464oQ+qS3qC3E96KzhDnstzLFbJJ8Mqwfux56JWq2igcpmHD286Re9ekbCwnY7LivSVkPdGTp3u4UrJOAJk+TqaRCUJ+0eDQ6eQ44bc2brZ2afZZgGZtAgrDLRKM+GFZeLENplVuncauLeGkVEXfcYfKHz4dpm8Yl0y2pUOXaEVTeIqhM6rM6fzlwPYCBicpFuAwZIqQPl43bDEuc61/2Y2m7GDf2B7z5kqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PuHguRhkn384S2div7GHC9RgTOUnCSdIgdLDcC0eJSc=; b=sHPXz/awwik6X6IS4JRqVshfwlqNun/Hq31vr4CayEAkUehLL/d3iVRSKYWLa17IAgCxCMepw/u+F0kiS0a+5W6RiuPrR1SrOFl3XLYoltSiAUuMwGhAuAwESQMj/ERS5Nla+rDcIMomrAiQ4+caeEq7jAIOgloxger9qcpI1us= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Roger Pau Monne , Jan Beulich , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= Subject: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Date: Tue, 8 Nov 2022 12:38:50 +0100 Message-Id: <20221108113850.61619-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0385.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::13) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6747:EE_ X-MS-Office365-Filtering-Correlation-Id: 46e7e1f7-bf5d-4390-56b0-08dac17dd99e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nd6nyQcHd6brlgUgUFm0ojqXEzvOTmTJJ89qORBoAg1z8ZxjL49U60AwwPgWUq8bxPVbRx/zartRz5+JU7raCn+sHMWu8emQi5UZUVJ0k4sI2oZPGqaIMrXdJqjUNUjPEl5yAWrYSIvsXk2Bu4eG1vpWJ/MXSRKR5VXdO+/44D6hiBUyv5Xt3U/VdRA+w1vaoRD2444DwHwdBdttK2tXxsA5Ejwzth4/FPNkQkrQVK+ueJJdLhBj1TCO7dwsgcKz1blAJ4xvE0dN8e0dgsAGBEYgjEgeYLPgcYoi5MZOedgXDxd1JXi6vSZPv4eYA9EXDykSF5+qYVCd1YwGnt6h5Yxy6c/J3ga2W9e1aZwWVBynaz39ppcyBWknJnO2SWd3FthpXgjpRXzjdmjhmNBiDN19pov8GTwESn5kroo9wcCKNeDat2JBUFsV3oeogvjCjJTb80jlSKKd1g8pHr1Tw4GCjAhDg5RBWTZE1iXymS5Q96HmLOSUMrE1GrvavufYdcqs+ejvIPAS4VlKPdedOwmAROMixbCepwGCXYyUD43VLNnQf8yHrSLgeTwmWoYCBuLd6GDSOFg1mRrfXwx7xs9eAj3YavPp14LH0xKv7BwtPcJcK1lfsnt4wPNWTk/ABBLASEG2mPLvC6qcX+J+Fv/mKtqPQ5nYJw1XJRCP/a7Z4/mJij66WnyAji0prDg3uZM/G9cO5g3kXu+9yl62Fg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(136003)(366004)(39860400002)(451199015)(36756003)(66556008)(86362001)(82960400001)(2906002)(1076003)(26005)(6512007)(5660300002)(83380400001)(38100700002)(186003)(66574015)(6506007)(2616005)(8676002)(4326008)(316002)(66476007)(41300700001)(8936002)(6486002)(66946007)(6916009)(54906003)(107886003)(478600001)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEc3bkNzNzhoczdvVk85bEpPL1hVQVVlWlJTV3BzUXVqZDl6MXJPTzhaNnU3?= =?utf-8?B?dWVwaXp6M3VGMC95NWlEQVdab0YwU1k1R2FVMTd0R2RJdGZHek5QSGRhNFp3?= =?utf-8?B?YTc5ZExMVnhOMXZpVWRKQlkxZ2kxbk5hT1RzL05BOVFJSU5MMHRBUWZ2SVpK?= =?utf-8?B?MTM1S1FqangvOTNDZ0NQc1o2NTVxcjBaLzZHcWlhSnJ5WmROaFBJb2NZa0Fq?= =?utf-8?B?ZlphclcwUWxYQzFsUjA0cjMzcExZSmpnYkFQQUdvTnY4RlIyZW5TNDkrNjFF?= =?utf-8?B?QzlwZHFpOHRSREc4T3dOV1dNUWZUODdJNWVGSWlxSk5SUkFYdGhER0JLbzVX?= =?utf-8?B?YjAzRFpGaHhUblJTZFA5Tjg5enlMU281SGxUc1lCdUlBdjVFNjhaek5ZWmcv?= =?utf-8?B?RzBTa3ZwS2FuMTBRakFaMmlBbTI2Zmp0bWVsY0ljTVYxTW96aFMrQWNHRlB1?= =?utf-8?B?a3MyTXFxUjZYTzFPTXFSRFp5VXZHZkNxZnhQK1RHZE9XMWpERjQ0aXpoM1hH?= =?utf-8?B?SVZqbVZJQkVDcWoxNFhLN0ovUEpJa2w0a0RtY09mblY2dnA1WHYwSk9LdG9J?= =?utf-8?B?NTVKVVpoWldXTi96MC9tUkhHZjZ2UVM2QmxYa3FBemNHYWxvNFFRcTRaYWJv?= =?utf-8?B?WXBJVUtuK2hiZWpCNHNMTHAxSitJSk43cUVLcEY2RW5CSHRNZHRFWHBiUXpi?= =?utf-8?B?TzJaeUFYdWs2cnJRV2NwTkhhU3lxcC90OXQ2Qk92ZHpaT3hHOG9MaVlwazg1?= =?utf-8?B?NGNFTUFzYlNFSVZTMTFwaU1JbWdzUmt3RFB3STEzbmJQUXMrVkw4RGdQSG5G?= =?utf-8?B?endkWmVSUkxkUnZBNnkxMnVQd2tsdmVlazM1NzhzVTZKQnZjR0RrTUplWmpR?= =?utf-8?B?TDVIK0l3SVQ3NmJhT2dhN0s5RVE0L1I3bHptUDVzU2ppWlFzZnpBdzBCVDdp?= =?utf-8?B?c1loNTdhYmRJSGorWHRaa0ZKNFc2eXdtaVhPNi9VbENRZUJPWC9WdTNQejlo?= =?utf-8?B?Sld3Q1NoVDkveC9KRTVrWmxCOERucEdEWjZkODVDdTV4MGZQQ1kwNE5LMGZv?= =?utf-8?B?TzIzaWNkZXl1d1Z3a09ZUWM0d0s0SEJBVUpYdWthRC9pLzhMRXhnaVplK3Vt?= =?utf-8?B?NFpIdHJFZVU5ZXFzVUVQbVo2aUFoaHJtN1hRQ0lqcS9GSlE1czVlaWZ3M2JC?= =?utf-8?B?eU5sbHM1ei9VSWNCVkVsTWg3VG9DYXEwWkJ6ZnkwODNCdnVTS3JBSERuaTRp?= =?utf-8?B?YzNrNmQ3b09NeFQwUlEyMVFSRURsWitWZDVUc1NCTDhQdC8za1JheVZ5US9W?= =?utf-8?B?Q1pPczNXam5jM0lDeTZpclFiV0lLYWJsQmN2YTVuSjNPeTJTcFRlOGN1T291?= =?utf-8?B?TTFKK1V2cEhFYUtXaUtCWjRzVnM3TGxkVVZCbHFnWTVzTFVXT1dYc0YwdCtZ?= =?utf-8?B?WUVEeEp3UUMzWUgrbm90Yld2YjNyd1hTM25QV1Z1UHhyNjdnZ21VM2dSLzVi?= =?utf-8?B?eFRHeFNXZzl4akxNdFRqNFFrMnZjc1ptZUd6RnBsNFJmWGs4aC9XeGM2RFpE?= =?utf-8?B?cExHNlBkelZ4UU5IK1E4dVNiMDBRM2dFNUVGNG5tWTZqaHpoejFodjZEUFA1?= =?utf-8?B?dURLMTVVMWNCQVBTeGR5Q05RNmpGTDRxNlVvODlXaDZGaVVkVlY2dlRpaVhF?= =?utf-8?B?bXJMekwzQzVFK1dydWttZ2VQVjJPMnhWUlIyRE9LNHIvTG5JYmRLbXlTcjhy?= =?utf-8?B?dnc0dlg5dmFxZENqYUVnTzBqb1VmeVpNRDhSV08zaFZEWHhWRnlLVHdlaHNT?= =?utf-8?B?eVVNbkpMVFRDc1RuNm9wRG9VV1F4ait4M2tuaEF2ZmNxaVhTd3FMTlIzcmxn?= =?utf-8?B?NmtTMENSb0pMb1g5alZLbGhTQTdRcmoxd2ZjQUdSbmVoWlVyaXljeTBhOUho?= =?utf-8?B?M2tQQjNTMmNXdjFpa0x0dFhmQTVzQ0JwTmNzWDc2b0hoa1k4SmN3M0I2ejdB?= =?utf-8?B?YlJoWXlDSUU5YkExN3I3RFNXR0dUU0tFMzhuZG1aY1FaZjM4c0hucEE4OXhZ?= =?utf-8?B?dU9KeVhDemlWVGlIdXM2V1NOcDlZUW1pMkpvdGdFS0hjUjJlRFRtYkU1QkdT?= =?utf-8?Q?HBT0zy1mqd1anUiDAiVoFXgo+?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46e7e1f7-bf5d-4390-56b0-08dac17dd99e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 11:39:09.4965 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J8ZFg3FIACuZ2vbZKn6dSf2vZWza+JZxKTC5esCRZr+Mo3pMFz3HSHTswMusETTYpwjx9W2coDsUwFtQOO4rBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6747 Like on the Arm side, return -EINVAL when attempting to do a p2m operation on dying domains. The current logic returns 0 and leaves the domctl parameter uninitialized for any parameter fetching operations (like the GET_ALLOCATION operation), which is not helpful from a toolstack point of view, because there's no indication that the data hasn't been fetched. Reported-by: Edwin Török Signed-off-by: Roger Pau Monné --- I'm adding the for-4.17 tag because I think this is a backport candidate to older Xen versions also. --- xen/arch/x86/mm/paging.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c index 3a355eee9c..3e7be07e86 100644 --- a/xen/arch/x86/mm/paging.c +++ b/xen/arch/x86/mm/paging.c @@ -694,9 +694,10 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, if ( unlikely(d->is_dying) ) { - gdprintk(XENLOG_INFO, "Ignoring paging op on dying domain %u\n", + gdprintk(XENLOG_INFO, + "Tried to do a paging domctl op on dying domain %u\n", d->domain_id); - return 0; + return -EINVAL; } if ( unlikely(d->vcpu == NULL) || unlikely(d->vcpu[0] == NULL) ) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 11:48:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 11:48:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440016.694073 (Exim 4.92) (envelope-from ) id 1osN5x-00045T-IA; Tue, 08 Nov 2022 11:48:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440016.694073; Tue, 08 Nov 2022 11:48:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osN5x-00045M-Em; Tue, 08 Nov 2022 11:48:45 +0000 Received: by outflank-mailman (input) for mailman id 440016; Tue, 08 Nov 2022 11:48:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osN5w-00045G-43 for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 11:48:44 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2075.outbound.protection.outlook.com [40.107.21.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a3d4b04-5f5b-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 12:48:41 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8472.eurprd04.prod.outlook.com (2603:10a6:20b:417::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Tue, 8 Nov 2022 11:48:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Tue, 8 Nov 2022 11:48:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a3d4b04-5f5b-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eZqm1ayY/VIjYwbVO0gRQ9R/9TCyA30ATOFLigITPPEgU8WUpFQYAwEcmF6Kp5iqrsCZOHthsxgcsO+plUUEdqn4JIQo0+0VZmU8vlL2eCLTOnq+3JDvAhp64rCWd3EKrE/jf+XnkIj4yqpEY1Pq/4MPeZdAU+UPasWop+dGXdlDn7a6o+vNDAab/a6+gl7XqnFLi0GwIAOwJIGpLQjfZATsB8eHyPLOMyDmW5GtXIjWMBQAxLtMeYKy9C3gOvrC/pOEPT4J2jE2uYqKMAraPP2zcGTISrd/n6vI6QYKGOQyyqjv1ASQAgtjLoK+iEgQ0OlwfTZafg9K7V3+2ma99g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ARTLt/gvXUcVxEw6Jt/uKKrW1E0ds/Sh9E1t50lsjqo=; b=lROzg9IDxVP6ced3lZNkQhy1a6eYfh6GFwyVtJ2XS5F8GBt1AEqWDA3j8ZoJYhdVvR6XG3h2wdVv8DfIvhKBp6yDwkKKuINgB4N5m2r706xgbRP5zAJEeFtKlQQHHmV7con/npW4FgSwqQZhicYhvEBTkNnxPP2EXGWsVmUxfeAU6/Bc4CungmCZH+faVNJe9dpqzOfSOLX5AaWwfd1YbhOOU7CNuw8nl+s0T6ARUQsz/uAaJr57MFfn8Shvr0G2aXkVWEoxWjcoOJDf75jNblgwIQlEuxsmpFAs6JG8SsrNUnGxVih2lwaMx647x+inBtPAi6X2yxGPehCsWRG+Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ARTLt/gvXUcVxEw6Jt/uKKrW1E0ds/Sh9E1t50lsjqo=; b=WDVGwhdW2PxR5KJ+prwQtPtmsURy5ptkiSZKZzfWTi2Zj6s8/C997deT0ed+RbkRIQmRv9LJi7Ola57hwQ7zA/Pw+SKOZq8KD6QctoVe0eUDI6/hmxvQFbjT0mOfnpoxsqqXPI23fZfK6LwjpMnVY2xy2dmjIKYeYbVMrik575t7Xq1OyvEpX/ba5/Si7NK+4pP7N5UohVV7mwi3Yzm3y82syN7n81JKAWPdV55KKmhDX+KW9cPvhM7/HqQe7YIrmHpujPg0MEN8IbJWaEOcJ9A1OsXxZdomkyADu4+vuQiwOtf1LbRnD+O+k9iTjn+gYoP03qYY6kcGOo3XYqEV/g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Nov 2022 12:48:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Content-Language: en-US To: Luca Fancellu Cc: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> From: Jan Beulich In-Reply-To: <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0041.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8472:EE_ X-MS-Office365-Filtering-Correlation-Id: 63158d59-c35a-45cb-d17b-08dac17f2a87 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wrfZyFt0pqi3IhcCxVPGd4Pcnv2/5XRyJpEYckAPHDfzFKZoMZsuc5ucREDLKtkSqAgi9eJOZf71MtWj05EkT19aHPsa+U9feDOE6fZXSKPIkz3Rz28W2M0WiKO6OAeagxMSmPumWGjW2uygRuXM/KJZ+Yh4UWtoCuEF1dmHqs5h4wYVqnQtkkHiYyukYLPMFQ7vF9xg3Q/JFVgK8l04xFIxD8ehYupQIzfbzuigZ7MOmpQ77/7LJ4lgG7uHJWoFQGmz3gVs5KWSJENJMx6RijY13Goqo/krcUFd/zf7Y63XVVA85tDtr8iE2GS3cntfRMjXbb6NvCfr7+jvOleFHE/r75wqLZt1Kz/8Q6ZizCeXWasqgA9564wJ62Mk1T+Ny0Bz6OWFPeX5PtxdFg2Phvz3CmIqoA8TJvjeLNwS3WbejthYfD49WuWOSGqzbVjbmA/QVvHNnr+2GxHqWFuF3KkQvAAckVBWU2I7LmkMTWIgJx/LqhRVr5Zb9o+YeFM1fbGipJRbawkPs7FCcvsTF28rVMhLwlm0mMHLuuvVe0M5hOPp41c1/Zt6Ni+8+Ult1Sggw9kjtadarnvZB79SK1AZxWRcRkMBX3Qc3Cb8FOB/rh1YjC3OEQbkAwbEnEX8chSXnrD2/PVR4RJBYbZMT2fSaoYU8qe7z2BYdjmrdLS2PXVYQQRx5F+8apvobqsJota/XRSWpCYr+vdTZY3dumcBlWKdj9XiIWeAxhSxXJ35/6GdLKQpOnKhlYVYX66wRA5zPC0G0NU6hFewMXPUevSQhKfI3Dvnwuldbadg4YY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(366004)(376002)(39860400002)(346002)(451199015)(31686004)(186003)(66899015)(2906002)(6486002)(2616005)(83380400001)(5660300002)(8936002)(478600001)(26005)(41300700001)(8676002)(86362001)(31696002)(54906003)(38100700002)(6512007)(66476007)(66946007)(66556008)(53546011)(316002)(36756003)(4326008)(6916009)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1VraUR0OS9HaW9wZmVSY0FWMFRPOXBscUpIWmlBTHMzUGFJL1dIUFllNW9h?= =?utf-8?B?ZC9qS2plOVYvNGlLVzhQSFBSMldacVRXbXJ1UzZ1eGtlVHR2Z2p1OFNDajBG?= =?utf-8?B?Sjh2Z1BhbDRQdy82NkUvajJkOHlHbGJNZUxYSmg5NEdxZFNaaE5yeTZHcXps?= =?utf-8?B?VGI4eE0zWHVmdXRGcFJlempLQ2lLYUVaeTNHUnV5TUJjQjlHZFZ6ZEs1RUxo?= =?utf-8?B?TnBPbXQ2RW1wZ01wZ3B1c1oxaCtnbjdTYTAzeVRVUDVqdUVTd1pZWm80cTBH?= =?utf-8?B?VHN0UEZjM1RwaTZ6TnduSWU1QkI4WFhhZkFTU0F3VnRRaEZkTVcrYWl2V1d2?= =?utf-8?B?YzdLWERvQ3ZhYkErRTI5VSs2cDRYbW44Y08xckFYK3BGWTRXaHVjMkdqZkZm?= =?utf-8?B?dEhYNk9CL01FTkNOdDNNZ1NSRTlNYis1Ukczc3QrZU9ZMDJLMFhNdEYzbzlw?= =?utf-8?B?T3pUenViUTZ4TXNNeDl3SGJ0SkRzYjI5aExqb3MrUlVJRkpZUHdrcDcyRGFh?= =?utf-8?B?RjgrY3dwQlFlM0ZCOW5UMS8weTQ5S1lrenpzYTRFcFVUWDE5aGk3M1RmV0w1?= =?utf-8?B?M29Sc0dBSGlZelZLVkppZHova1VXai93VjJ4VGNFcnZqK3hMV2hNQkMyUGZL?= =?utf-8?B?eHVRLzB1TEpJZGQvS0t5WGdCblJRTmk0bFo4b1ZxWC8xbXlzc3ppRk5ldzUx?= =?utf-8?B?ZVZWQ0MxMENlVGxrSnpkeFFtTDZXWXpva2VhNlNzcTlUdnA0L2VtTnZpczcz?= =?utf-8?B?UmMwNXdvaEtKMTlURDZ2WUxWZlZDWFNWS2tiQk4vQXBzRjI1T3Q1Q3dxckd5?= =?utf-8?B?Qk1LMzVoK25rTU9yMFRUSytyYzlmcDF4VlBlZ3NPL1Bablp5elNaOFhjWGcr?= =?utf-8?B?VXl0cW1XQ3JRWEdIU3Bac2lJNUd4LzZhUnVSRSsxa3JFeHMwQ3Bac2Q3QXJB?= =?utf-8?B?UWZrWisweGhtdkl2VjJBZUk3dEZZQUVHVk81Z2lhNlBpS1haV29NekZ5UW85?= =?utf-8?B?MUIxNXpLZjJRTnV0QnJKNmR3TW9vOVdHVEFNVGxJNGRIWDhLWElIUko4dGZw?= =?utf-8?B?YWlOZDQyMWM1QklYeG1TbWtNUmtRTjIrU25kZG9sTi9BQVhhSHRiOVhXL09O?= =?utf-8?B?TmNVWjB5ZTJMMC8za1lPQUtWR2QrMGZweUZnS0ZIWWRSZklDMW92cmMzcmRZ?= =?utf-8?B?U2F4RkpkWFU0bUN2MnZRdWFidnBxcFlYanJrbThUdW5FVUdDVTFRUFI0dWRp?= =?utf-8?B?aVo2WDcrdElVRXNsZGNBSm1RejNhenpEZW5wVzdDVkQxeE1XZlQ2VkttbkRI?= =?utf-8?B?eTdzRytIWU52cHN1QmdjV2ptMnBVZ2RVb1FCVjk3b3VISUp4RHFsb0hqSFZp?= =?utf-8?B?OEZQL09KQ0JISEVmd1BJalV0cWdXWkRZN3RJM2UzNnV2aElINWtHRTBRTG5H?= =?utf-8?B?bVVIek9ON1NIaXBrZmd4OHFQc2IwMU5oZVhpc3dsVkhLTGlWUDZsa1BUaXRr?= =?utf-8?B?VEJOTUhoLytYR1d5U29uVzFzazJJUmpwTk8yODhkMmFZYlNXckgzZjVleU5p?= =?utf-8?B?SEJqcGVtSHBzVEZXZStnS085RlozTW9vOXNvWGZUYm4yenJ3TVhDZnQrTUxM?= =?utf-8?B?N05SV0ZVblI1aTd2U2dVRUp4eVg4QWF5OCtOeUNkb2ZFcnVkRTZObm91SWlB?= =?utf-8?B?enJpYXNkN2tXUnpBVUlrc0JEZnRHNlkwZDlCUXkwd0FveGNQZUpOOW95WUFu?= =?utf-8?B?bnFPUjFvdzVpNzFTVjQ1UWl1VmVTVi9mRkJ1cm1yNUNvbE55UjFZc3hNdmI4?= =?utf-8?B?dyt5SGI2WW1KWWt5OGtlenRWL1ozdHdUS2J3OWp0Y0tiSEx2OHdmdkRlQmpz?= =?utf-8?B?ZFRJUHZJRzZZdlpyQ1VCUkZFbU9JRmZLNUxDaE94eEN0RTJoUmIrb3IrOXhR?= =?utf-8?B?VWlidGNwT1dwZk4wTTM3dzk0MGRCN3Mxd2NMTmN0ZVduNEhGdTlIUDgzampU?= =?utf-8?B?ZVIyTnFYQ1BRcHlsUElqN3pZQkVWcDhHaFNieFZ4VW1MV3pKWGd0RklxU0FK?= =?utf-8?B?dmpPZklVQVZ6YXNSU056OXlpSi9WTjY3ekt4VHZZZFRIOVlQU2dLK2ZFZS8v?= =?utf-8?Q?atERs86uc6aRxgzJTOkfFJlaA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63158d59-c35a-45cb-d17b-08dac17f2a87 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 11:48:34.6147 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WO/UmK2re/vkKMe4FFcEb0+CPg3zKXm2pSDBYjmfDSUs+fv9N2n6UCQzCrImwNsdkAlLcqAHaVn/1B0DrzAQGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8472 On 08.11.2022 11:59, Luca Fancellu wrote: >> On 07.11.2022 11:47, Luca Fancellu wrote: >>> +Here is an example to add a new justification in false-positive-.json:: >> >> With already present in the name, ... >> >>> +|{ >>> +| "version": "1.0", >>> +| "content": [ >>> +| { >>> +| "id": "SAF-0-false-positive-", >>> +| "analyser": { >>> +| "": "" >> >> ... can we avoid the redundancy here? Perhaps ... >> >>> +| }, >>> +| "tool-version": "", >> >> ... it could be >> >> "analyser": { >> "": "" >> }, > > Yes it’s a bit redundant but it helps re-using the same tool we use for safe.json I guess the tool could also be made cope without much effort. >>> @@ -757,6 +758,51 @@ cppcheck-version: >>> $(objtree)/include/generated/compiler-def.h: >>> $(Q)$(CC) -dM -E -o $@ - < /dev/null >>> >>> +JUSTIFICATION_FILES := $(XEN_ROOT)/docs/misra/safe.json \ >>> + $(XEN_ROOT)/docs/misra/false-positive-$$*.json >>> + >>> +# The following command is using grep to find all files that contains a comment >>> +# containing "SAF-" on a single line. >>> +# %.safparse will be the original files saved from the build system, these files >>> +# will be restored at the end of the analysis step >>> +PARSE_FILE_LIST := $(addsuffix .safparse,$(filter-out %.safparse,\ >>> +$(shell grep -ERl '^[[:blank:]]*\/\*[[:space:]]+SAF-.*\*\/$$' $(srctree)))) >> >> Please indent such line continuations. And then isn't this going to risk >> matching non-source files as well? Perhaps you want to restrict this to >> *.c and *.h? > > Yes, how about this, it will filter out *.safparse files while keeping in only .h and .c: > > PARSE_FILE_LIST := $(addsuffix .safparse,$(filter %.c %.h,\ > $(shell grep -ERl '^[[:blank:]]*\/\*[[:space:]]+SAF-.*\*\/$$' $(srctree)))) That's better, but still means touching all files by grep despite now only a subset really looked for. If I was to use the new goals on a more or less regular basis, I'd expect that this enumeration of files doesn't read _much_ more stuff from disk than is actually necessary. >> To limit work done, could this me "mv" instead of "cp -p", and then ... >> >>> +analysis-parse-tags-%: $(PARSE_FILE_LIST) $(objtree)/%.sed >>> + $(Q)for file in $(patsubst %.safparse,%,$(PARSE_FILE_LIST)); do \ >>> + sed -i -f "$(objtree)/$*.sed" "$${file}"; \ >> >> ... with then using >> >> sed -f "$(objtree)/$*.sed" "$${file}.safparse" >"$${file}" >> >> here? This would then also have source consistent between prereqs and >> rule. > > We saw that mv is not preserving the timestamp of the file, instead we would like to preserve > it, for this reason we used cp -p Buggy mv? It certainly doesn't alter timestamps here, and I don't think the spec allows for it doing so (at least when it doesn't need to resort to copying to deal with cross-volume moves, but those can't happen here). >>> + done >>> + >>> +analysis-build-%: analysis-parse-tags-% >>> + $(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile build >> >> This rule doesn't use the stem, so I'm struggling to understand what >> this is about. > > Yes, here my aim was to catch analysis-build-{eclair,coverity}, here I see that if the user has a typo > the rule will run anyway, but it will be stopped by the dependency chain because at the end we have: > > JUSTIFICATION_FILES := $(XEN_ROOT)/docs/misra/safe.json \ > $(XEN_ROOT)/docs/misra/false-positive-$$*.json > > That will give an error because $(XEN_ROOT)/docs/misra/false-positive-.json does not exists. > > If you think it is not enough, what if I reduce the scope of the rule like this? > > _analysis-coverity _analysis-eclair: _analysis-%: analysis-build-% But then, without using the stem, how does it know whether to do an Eclair or a Coverity run? > Or, if you are still worried about “analysis-build-%: analysis-parse-tags-%”, then I can do something > like this: > > analysis-supported-coverity analysis-supported-eclair: > @echo > /dev/null > > analysis-supported-%: > @error Unsupported analysis tool @* > > analysis-build-%: analysis-parse-tags-% | analysis-supported-% > $(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile build If I'm not mistaken support for | doesn't exist in make 3.80 (the minimum version we require to be used). >>> +analysis-clean: >>> +# Reverts the original file (-p preserves also timestamp) >>> + $(Q)find $(srctree) -type f -name "*.safparse" -print | \ >>> + while IFS= read file; do \ >>> + cp -p "$${file}" "$${file%.safparse}"; \ >>> + rm -f "$${file}"; \ >> >> Why not "mv"? >> >>> + done >>> + >>> +_analysis-%: analysis-build-% >>> + $(Q)$(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile analysis-clean >> >> Again no use of the stem, plus here I wonder if this may not lead to >> people invoking "analysis-clean" without having said anything about >> cleaning on their command line. > > In any case, the cleaning process is very safe and does not clean anything that was not dirty before, > so in case of typos, it’s just like a nop. People may put transient files in their trees. Of course they need to be aware that when they specify a "clean" target their files may be deleted. But without any "clean" target specified nothing should be removed. Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 08 11:56:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 11:56:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440033.694087 (Exim 4.92) (envelope-from ) id 1osNCy-0005vN-Gw; Tue, 08 Nov 2022 11:56:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440033.694087; Tue, 08 Nov 2022 11:56:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osNCy-0005vG-Dw; Tue, 08 Nov 2022 11:56:00 +0000 Received: by outflank-mailman (input) for mailman id 440033; Tue, 08 Nov 2022 11:55:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osNCx-0005vA-9s for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 11:55:59 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2064.outbound.protection.outlook.com [40.107.20.64]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e6d701c-5f5c-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 12:55:58 +0100 (CET) Received: from FR0P281CA0148.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::9) by DB9PR08MB7723.eurprd08.prod.outlook.com (2603:10a6:10:392::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 11:55:51 +0000 Received: from VI1EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:96:cafe::30) by FR0P281CA0148.outlook.office365.com (2603:10a6:d10:96::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Tue, 8 Nov 2022 11:55:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT048.mail.protection.outlook.com (100.127.144.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 11:55:51 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Tue, 08 Nov 2022 11:55:50 +0000 Received: from 0337f39036b3.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0399524E-D462-49A0-B3BE-4C6DD6070416.1; Tue, 08 Nov 2022 11:55:38 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0337f39036b3.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Nov 2022 11:55:38 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by PAVPR08MB8845.eurprd08.prod.outlook.com (2603:10a6:102:2ff::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 11:55:35 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893%4]) with mapi id 15.20.5813.011; Tue, 8 Nov 2022 11:55:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e6d701c-5f5c-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hmfRwb9/9UABLOp70w4jZAoUh1xmGYhFJ8OUnfVloOtrh/cjoUy04mafoMtWSN5qsHCOTPri2BeN3ESF958xEoQ1G3GZ5sxx0pprpxEXpfx5jjDC4uldAAWSDpenyvgsK0rRYewCWemRaOoWBw6FeczHkxjMK9aS3k38ovUkr/bhO7erw4LHOxj0dRAWhUHFY1u1z/f1yemFjwJBO/Hy4SxsAT5b1bNwCb+XODfg/gzWuVsVq+1RBaS7yvyfAwDJ1DW/ucMQj+dMovXTohh+3CZGU8wuBT5PYPCTkTWaWQvP5ayxEtZu6n4iKYmwr5FQBGLA7kl3gXv81AaZ/Vnwfg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pPnmmNcE0q5JSy4R/IM++aACalAYSwaWxYInSHjiE0k=; b=NR8T7fYq5Vc4WVUhM0zdAku+eqrhXNhv2cSv91mF/YeUpF7JFWtRxsRabMJm2fb12qo/priDJZabnjucKOPei905bN8HyM15nRsKSOAn5j/zTkTP75xWrguX6TO+6Y8QdF+/7dshEq/9N1NPCLb9zUFv7pCSNl7mgb+avxWd0/T3/CG2sqwrk/DjaZFrwI2Cle+SlM3lo4AcUGwp9GzB4mPJlN+YVk5mHdInkSbEyMe33dI7rzwdxEZ5uMOGM2AH1XvcFOrZkGU97An/cOOQWGjQvncsamGFcqUxPJY+NlWM33yDBxwKuvp3twY6Oh8KaCImnQSd2jWDxjV2yaVI6Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pPnmmNcE0q5JSy4R/IM++aACalAYSwaWxYInSHjiE0k=; b=crVzMP+mMEEl4ZaWzdpgc9UED1ng+/M0tYAdLla9qTH+hZA4M0Tj8M1FIMeVq8nKZx1n3D1GiKqXwIaJ5Atq7oaAPfJOU6MAPhP9qz8Bw/ASP/Kl2qf9ie/l1MH1FhQHMwNfRGI/wV93kUVFR+2/uaC2Eo7dYKZBh06DKbPBssk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 501408f604d410b4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UnOMFk4Pd+MMNsUOD/ifnm3QJES1yM0C8p8T1XYm3W7mu5GOcRk7JkKx18t52KqG0sCtcsrksq/IB6G2uBXrQxQJvewKJkabYygb+MbkfpUh7Jhtpev9QmoyIG9qQGEmN3FGDfV9ILvilIz0gWJ4vQa9FLtWW1CWHejpxgULxWO/3m6j9YseoesyNFVvODc1pTHPgz8RbGqPId1xMkIUiGriBU7wwFs0f52q5Em44CDCNns4CQKqN6q8BJNrXBXQa/GP84LvPTQ12vMTuIMzTn85cS5PdXs7shcWTzf7uLq9sn4qddorpVXidlGHknJc5qNomT0+Nh4mGIJRLXnAsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pPnmmNcE0q5JSy4R/IM++aACalAYSwaWxYInSHjiE0k=; b=Yt5Pne/b2BIAHl+cbUe4GPf8Yw+mZ2Vbty/zOxx7+JBF1k2Y3ts4xGJ2G96H43NR1XCnEgSr1sk01w4r3XgMPJt1iWPgweK2cbJPJuHlfhDhG/JugDYvF3uW8PhphbjMqkLnvHW3otOYdFybDCl5vAEc+/17zl8wCtp3ypBv5C1f4VLBcw2LWpDZeUZ/0qqbN312NoQUG0ov0rNVDFxeR4EUQhG5zR4mFy2KvnTumpozNhc7f+XttMT6POcCJ8rKNsm6hnToCVVEZ2VHkqJzxjagaffbt7nZCz4X1c0/Zbhdt4bUu0gmIJTLQIEhmMAcHXkJbytfONB64u07z6Qz8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pPnmmNcE0q5JSy4R/IM++aACalAYSwaWxYInSHjiE0k=; b=crVzMP+mMEEl4ZaWzdpgc9UED1ng+/M0tYAdLla9qTH+hZA4M0Tj8M1FIMeVq8nKZx1n3D1GiKqXwIaJ5Atq7oaAPfJOU6MAPhP9qz8Bw/ASP/Kl2qf9ie/l1MH1FhQHMwNfRGI/wV93kUVFR+2/uaC2Eo7dYKZBh06DKbPBssk= From: Luca Fancellu To: Julien Grall CC: Jan Beulich , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h Thread-Topic: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h Thread-Index: AQHY8pZ4QA3C9Pi6Y066NaE9A9ULoK4zWNUAgAABAICAABGdgIAAZ3AAgAEKpoCAAAjCgIAABo0A Date: Tue, 8 Nov 2022 11:55:35 +0000 Message-ID: <6AAE9AFC-E54A-4C24-BCB0-5C4B84967B20@arm.com> References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-5-luca.fancellu@arm.com> <5caf911d-e96d-39e4-d945-db6537412f60@suse.com> <3925276F-8B6E-4B19-9EC2-C085FE88A637@arm.com> <933c4227-5839-312e-3996-693a7d8f7706@suse.com> <5B9130CD-BC40-42E3-8D79-DABC321AFF13@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|PAVPR08MB8845:EE_|VI1EUR03FT048:EE_|DB9PR08MB7723:EE_ X-MS-Office365-Filtering-Correlation-Id: db1bdf9d-272b-474c-d03e-08dac1802ee1 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0UgBztlhlv9aWh+yj+mFYotRUirOuCeLp/p3o7y194IfZMHaZC3aD34T0c9FIjSJxMnvpR4bLzDRHXRhjrczGeSwef7FzhAkev2ljqL91MN6fLtxq70kXaytZddkZ/IWlGOdbMjs1LVu7I5o53TpO9zitGKGqjpJ0BLnznVIehwa8C7Qy0N+rBTCb/1ComGJ4t1QYvVaJVxS6bSSJPUIWsHv0A+/gd/pvDa0GqouUAIbynKfu/0ndiH/T4Uqvn3YiLWgtgO5PL5QR2gSZXxIyYOotE1eq4gm9dEObWnGT3OejtIpSXb8bt7zi8N7syi32V6SfKqP2G5iTuP0CYBzQy9eREPnoGQRl/V3sjhHINT48vhgT6zTQ1WOWCZWjDb6KwM2u23pVgUlTa/J/29e+2rz9FnXRwqjSCUCD22DRYBuebc3rR0sLqN3ao53mbbWPFYjUTuXViKd7iIcA+VPAkYi2yEZAakrWNeHldvnLMgWlanjZLEPPg173pbIxgZvo8Zx7XOoiQlBU/g+OpuGCa/T2GUB+NN5G0erf6LoLFATo3vogb1x2UVt8mFM/n6iD1KN165t1LW6NPLWCfoeHub8U0444CfHMwenpo4I5V3cBWERxL51nfyFFKm+jzH9OGfZz4hUQEUbGivsDZrDYEykKJGNcNy2MuiKiJF9E1B2B3XM6gAVfXQc7UWORJw4iKYw9pinuYXr//ugA2wdEqFm4DIf2dLIQWHvRp6tSyY/083Bv82JegjMzNtu/yTLdI7ponkO7YYPRfDRfL3JjAZrc0EEyoDuHTWGMobkV/8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(366004)(346002)(136003)(396003)(451199015)(53546011)(6512007)(26005)(186003)(6506007)(122000001)(2906002)(2616005)(316002)(54906003)(91956017)(71200400001)(8936002)(76116006)(6486002)(6916009)(5660300002)(38100700002)(41300700001)(478600001)(66446008)(66556008)(64756008)(66946007)(66476007)(8676002)(4326008)(86362001)(33656002)(36756003)(38070700005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB8845 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5b3969dc-9ffb-42bc-31a8-08dac18025a6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D08/fQ8wLOYO7m6C1gq2QTg2aIZcPUE/HMjSO/a3/aux0zxs6pFPbDcM/w6RQ+tNLh8gtti2gVZwD8r2cVuH4tIwQIUGmfGS+x3xyihktcN6ZqF1KlK7DCKYTpiDDP+Jqv2B1By/FVXFMezvnl32VPgYnY3ZKKB5zHqybr1DZXCZDK4ea+MmaOgfXiEoR3OCteCrM5gWCf+wVJL7oF0K4oYUL1x0tUPIcavtbfq+RJNFG5j184QTahQY5rxefjHq5gh9ZTl5F62H4GitX9/yik9kL52gVkqGYBGNO0kkCse7++Hm/KymIoGXgpoRvLB7m9X6LRy1iJaZCKKUZ+jZExH5w4PaikgRyUWQhxX14hCcAFbPbfBrUw15Ml0fXZEp5HjhFLJ78KBQbVDFtyYd9VDsspnLS2qDwirOGinvmQZ9+8BtrG2t2+IDSCKuS/uXHWKY0/ao/INqV2SDHYmAVhjrpmVpeX2LZWMqklzbAvhoXt59VI2pN7RuFHPkhBNUD7tTVnPKYoJ8ucx1nZVGqa12gygFCd40lmBmBqg9mgA+h8ezFeAECjAHAgGH98XOZSdX9c9tAPhlh65vMFvcf1JpnX2y23Me8UQ1PiMUvo72kRBEoGr0v1gxcnrltwmRzBo+Juhvmlrl5BVcwtjl+BLmuBoaWLyVOznpwK0C6OG8oJmlr99bk2pFhXAyJczaGJpLPEKcEjgDfRp8wkbTw4Iq47i1M6unoUzdxH+4NhRGzl/kWnbqLoiq8SCiyFQJFM7WyVr2Ek97/fe1wUrOdg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(136003)(346002)(451199015)(36840700001)(46966006)(40470700004)(36756003)(86362001)(33656002)(36860700001)(356005)(81166007)(8936002)(5660300002)(6862004)(26005)(2906002)(186003)(2616005)(6512007)(336012)(82740400003)(47076005)(316002)(4326008)(70206006)(70586007)(41300700001)(6486002)(8676002)(82310400005)(54906003)(40480700001)(40460700003)(53546011)(6506007)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 11:55:51.1778 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db1bdf9d-272b-474c-d03e-08dac1802ee1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7723 > On 8 Nov 2022, at 11:32, Julien Grall wrote: >=20 > Hi Luca, >=20 > On 08/11/2022 11:00, Luca Fancellu wrote: >>> On 7 Nov 2022, at 19:06, Julien Grall wrote: >>>=20 >>>=20 >>>=20 >>> On 07/11/2022 12:56, Jan Beulich wrote: >>>> On 07.11.2022 12:53, Luca Fancellu wrote: >>>>>> On 7 Nov 2022, at 11:49, Jan Beulich wrote: >>>>>> On 07.11.2022 11:47, Luca Fancellu wrote: >>>>>>> --- a/xen/include/xen/kernel.h >>>>>>> +++ b/xen/include/xen/kernel.h >>>>>>> @@ -65,24 +65,28 @@ >>>>>>> 1; \ >>>>>>> }) >>>>>>>=20 >>>>>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>>>>> extern char _start[], _end[], start[]; >>>>>>> #define is_kernel(p) ({ \ >>>>>>> char *__p =3D (char *)(unsigned long)(p); \ >>>>>>> (__p >=3D _start) && (__p < _end); \ >>>>>>> }) >>>>>>>=20 >>>>>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>>>>> extern char _stext[], _etext[]; >>>>>>> #define is_kernel_text(p) ({ \ >>>>>>> char *__p =3D (char *)(unsigned long)(p); \ >>>>>>> (__p >=3D _stext) && (__p < _etext); \ >>>>>>> }) >>>>>>>=20 >>>>>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>>>>> extern const char _srodata[], _erodata[]; >>>>>>> #define is_kernel_rodata(p) ({ \ >>>>>>> const char *__p =3D (const char *)(unsigned long)(p); \ >>>>>>> (__p >=3D _srodata) && (__p < _erodata); \ >>>>>>> }) >>>>>>>=20 >>>>>>> +/* SAF-0-safe R8.6 linker script defined symbols */ >>>>>>> extern char _sinittext[], _einittext[]; >>>>>>> #define is_kernel_inittext(p) ({ \ >>>>>>> char *__p =3D (char *)(unsigned long)(p); \ >>>>>>=20 >>>>>> Why the "R8.6" everywhere here? Didn't we agree that the in-code >>>>>> comments should be tool-agnostic? >>>>>=20 >>>>> The R8.6 is not tool specific, it is to give the quick hint that we a= re deviating >>>>> from MISRA Rule 8.6. >>>> Well, yes, "tool" was wrong for me to write. Imo references to a speci= fic >>>> spec should equally be avoided in in-code comments, as other specs may >>>> turn up. >>>=20 >>> +1. The comment duplication is not great and sometimes even a short exp= lanation it may not fit in 80 characters (AFAICT the justification should b= e a one line comment). >>>=20 >> Ok we can remove the R8.6 from the comments, is the remaining part ok? >=20 > I am afraid no. The comment should only be /* SAF-0-safe */. Ok I will go for that in the next serie >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 08 13:56:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 13:56:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440057.694102 (Exim 4.92) (envelope-from ) id 1osP4z-0003Vz-I5; Tue, 08 Nov 2022 13:55:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440057.694102; Tue, 08 Nov 2022 13:55:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osP4z-0003Vs-Ey; Tue, 08 Nov 2022 13:55:53 +0000 Received: by outflank-mailman (input) for mailman id 440057; Tue, 08 Nov 2022 13:55:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osP4x-0003Vm-OW for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 13:55:51 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0c691cf5-5f6d-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 14:55:50 +0100 (CET) Received: from mail-mw2nam10lp2103.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Nov 2022 08:55:36 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BL1PR03MB6039.namprd03.prod.outlook.com (2603:10b6:208:31b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Tue, 8 Nov 2022 13:55:34 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.025; Tue, 8 Nov 2022 13:55:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c691cf5-5f6d-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667915750; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=YI8Loby8OEU7HAkxsQgjM8PSU8xTXjmQkw0OKZZyKGc=; b=AiVpbttlaTnV+9GvKL80J7gbUit0RxAlt8GgYa5ZTNVyyxkArWjXKNkx uXbvenBeuMvEyksuYl455eDnlsJy47+B1VoHUo8YjgVttxnwLOEJDO2Pj jgJbDH6owlOI6ZZFNnsRKRQ+TLS2XJ1sHwB0pyJA8s4Ib9nFlSwJLVxmH E=; X-IronPort-RemoteIP: 104.47.55.103 X-IronPort-MID: 86924562 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:+qInK6+Iywbflc63Hh+GDrUDYX+TJUtcMsCJ2f8bNWPcYEJGY0x3m GFNUW7Sb/3cYWr1edp2Od/n90gFu8XQzYBiQQJl/CE8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKgb5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklXr KQWdgEdQyyens+45oC4dsxgiOYseZyD0IM34hmMzBn/JNN/GdXmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUpi9ABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prr+RzHmnBdxIfFG+3v9GkH+v614uMjhMDhy4i+WF0mikcusKf iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZhZdo8pYkJTDol/ laTmpXiAjkHmKecWDSd676Sohu7PCRTJmgHDQctSQYV6t/vrZt1oh/SRdZuCoa8i9GzEjb1q xiIpiUjg7QYjeYQyr62u1vAhlqEuZzhXgMzoALNUQqYAhhRYYekY8mt9gLd5PMZdIKBFADZ5 z4DhtSU6/0IAdeVjiuRTe4RHbavofGYLDnbhl0pFJ4kn9iwx0OekUlryGkWDC9U3gwsI1cFv Ge7Vdtt2aJu IronPort-HdrOrdr: A9a23:FQIpMK550W+5PL1tRwPXwSeBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HjBEDmewKlyXcV2/hpAV7GZmXbUQSTXeVfBOfZowEIeBeOi9K1q5 0QFJSWYeeYZTYasS+T2njDLz9K+qjjzEnHv5a88587JjsaEJ2Ioj0JfjqzIwlTfk1rFJA5HJ 2T6o5uoCehQ20eaoCeCmMeV+bOitXXnNa+CCR2cSIP2U2rt3eF+bT6Gx+X0lM3VC5O+64r9S zgnxbi7quunvmnwlv31nPV7b5RhNz9o+Ezc/Cku4wwEHHBmwyobINuV/mruy00mvim7BIQnN zFs34bTrdOwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpOCfx2g4FhpVRwa hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvGrf2UIUh4bD3wXklX6vpREnBmc4a+a hVfYnhDc9tAB6nhyuzhBgv/DSuNk5DbituDHJy+vB96AIm4kyR/3FouPD3oU1wi67VM6M0gd gsEp4Y5o2mHfVmGJ5VNaMmffadLFDrbFblDF+ySG6XZZ3vfUi94qLK3A== X-IronPort-AV: E=Sophos;i="5.96,147,1665460800"; d="scan'208";a="86924562" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MweVAkJxvCI1HpmtH3Yasg4DSpc91DL8njAgduyLhnXl1aPX7OnbA+JfSpwqGy8+KZsCiigRS9c8JFfdCID5ALUUdlnzR0WJxp0N/uKi/btcLNYLFQaKo3tBX+pFG5SFRlEgrTO0nVb3/WXaVzv+CMF6vEIOJgxlEY1bTaORWLy7DwT3ESVN+jbwvDK6RQFR62xdW81TYtfFdSlKWjETkta3GTfvfG1fvHK9DSIF9Gf4efm74Eaa1ZEVa3KDmLQeWnJIcn3HQlmWRVTvsvBXSX57YawFXfbBCfOjIU+rJejtzjl1Sbom6kgyZLyERfTjLcvQGp4efuGRnHRMYRaSHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DJFdBjT8c7JFwxImwCDSmPg1YX4xF4xhzi5JAtkUwMA=; b=ajqgvZ3DjUdLVZ0xnrlFEcoTOqvxNJioraS8v4pJBy6BEDbDtCcb7LhF8NWDOfENjE813FMSxOIbNYo2kTnz5hgH9IM+A/v/0VOuxB2nMqvmu3mj9gcIjVr4z1FTge9IMi5HGT6oa5vSiNabpc8SqDENF0xbBMqGkY3PVWpPM/c805QaI8Wo3h5L4twgsmJ1aZT9AAvbhQvTMaYZfg9NP7UVq4IKcLAWvIKUKpAFXkakCGAFvcTsAanrpUXjXjLUd/+l2kdoxYZ6AjasriT1fThCoCTBi+Q2rJK3fq043P4ZvT30/qSaIj3reeTpIEEoZIAQZrs/OELlzc0wciZj0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DJFdBjT8c7JFwxImwCDSmPg1YX4xF4xhzi5JAtkUwMA=; b=n8AxMRLoHNK+ozHSKih8nzsXTz8bODa9a4z14aldjFmcsAacrzFF4SVf1Nn8Bmca0yJrbg4MpUdmzRRWZz/AAU9/Gof28h8mvUqEOtqGy6Am5sFYSSsCpxl+uzgyaC4AVgqzAqxi9MeE6uTT50R5ODNwx2pxYWzkq1E+2azcr7g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, ray.huang@amd.com, Alexander.Deucher@amd.com, Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present Date: Tue, 8 Nov 2022 14:55:16 +0100 Message-Id: <20221108135516.62775-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0601.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:295::21) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB6039:EE_ X-MS-Office365-Filtering-Correlation-Id: dac79f0a-5c58-4e79-bd57-08dac190e7a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9q4ccl8BBwxX/tRu0a/InyIQWFpQX5Yjg1HMUJx/Cwy7sRB+5rHjpq8ajWOFgTr+YVznHWAOJAUSsxubUPIV97yp0XsSATLC4i9cGkijob5afHz0ei/vWMjbOB99qCvhqgNk4kniNncVGuZMA4HpCAZHn3aF9X1YWSNJf+P+tbNc7OZRh4TVQyXfYTYeLzfMDmfyfMTzMDpN9ZXAJDaWXn1twkV2V6X+tiH6nTekvFUyKbocW1/LRbzAwuUwbuAgmwgha0oLOsgZT13D8nMT6lIgYbrmEIO8UxE1p5aF24KfLFAjKfDiAWgZ59qBrTPMlMgLz6nVSxrOnBjedcCThUkFAKwt9dAZPsr2/fyzbRDXXUcljYCw6twVFyVdRdQisTjOX7SUMNaG6JM5M0ZjoRoSiv+zFD/3Hv8PEwNXIuJ7Bye9pd6/vHwhSGIKsuhvE3p5RIxV3eoVdRRms/k4l2xN4ovs9JMNXXPYQkSeVP5mQfTeUwQ6yvq+lK3+9egZC6fQv2lkNj1TeRFcsGzReQZYKchpoaaMT8UfKfjBpHvmm5wHBXIqMIlMjlnEeUisswhv2IcKQ21R9D2VQtxxwZFpRMLfBlK24k5Rv91u7M5DWYhtw7rqwZPbJD+HnGccIifoNOofux23SNTb1ffNao5tGOf0hrdXoNVjZE7gf4TXd2FHO6Loo/M5r/yb27on+qQ05O7roNbAsBJcEePN/w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(376002)(396003)(366004)(451199015)(36756003)(82960400001)(478600001)(6486002)(83380400001)(52230400001)(86362001)(1076003)(186003)(6666004)(2906002)(6512007)(6506007)(38100700002)(8936002)(66946007)(6916009)(41300700001)(2616005)(8676002)(26005)(4326008)(66476007)(66556008)(316002)(54906003)(5660300002)(45080400002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Um5vRGg1QS9XNGtRNTJKTmtxT1FoVmF0NitVZkcxYnVleUR5d1UvS3VtNjlN?= =?utf-8?B?L3I2dXdXMFZpT20rdVRIcWVIcmk1MnBUckVLU2N1TjZ5SzJZOTNoc2dXRWRn?= =?utf-8?B?Z1oza0pNTHhzVi84V3lRSkc4dWpUVTNWekZhWE1qK2hQcG5JVXI5MUZCMEZK?= =?utf-8?B?YW80eGViS2pVVlQxSW1Id3pTRVE4cDNWNGJ5eXg5M29rY2w2ZTloR3h0Zldo?= =?utf-8?B?MWlYSjZSQ2NNMDMyRGFpblluczZNYnRkUXRyRks5Z01xN2lrclVURE1yaFlQ?= =?utf-8?B?VU5LK1NEL3dkUFJtWmJLR2pTVmRhSFk1aGVhNUUzbUhBU25hS2VlL3RrSk9u?= =?utf-8?B?WENZclBLWENFMDQ0Vmd1NktQMmZmOUtoa0doYy9Ldm5aalpYdjBucmlFR1NV?= =?utf-8?B?R0k5TkdkS1lpVzlmUjZEdGZ1enBhSnJjQ3NQTlV6QWVYOHd5UkQ4NUpOZTdt?= =?utf-8?B?WTVIbFpUSXlGeWUzYWlwN05BYi8yWU9YenQwZmhGclFydWl3MVQzRFpBK2JF?= =?utf-8?B?MmJpNE9KbWttTGUzWElKZmdwNUJ1MHpTV1VidmRnY3dJMDNmdzI0ZDRJUGQ0?= =?utf-8?B?ZWtmRVlOcms2MWpTUjRCa0lsWlVqaENOUjA1dFRIK0ZBNndxUWtDNWszQXYr?= =?utf-8?B?bDNGc1JjdGxGNzRtL1BwVFdMR0N1Sit1Y2Qrd2dwcDhUeExkV1BlVFBUaW9x?= =?utf-8?B?TFJsNlZCaVRFeXl3bGJXTEZDU3RCQVByV01NcFVXQnpIMUZYcTQwdExqMG1r?= =?utf-8?B?Ui9WYXpBZ1FSOUduRnRyZUZPWUpIcEpQb3ErOFhPMEhFOTBGNER3VCtxY0VJ?= =?utf-8?B?dkxHekZwZGRQajc4SDk5dFZHODRjejVZUWVick80RzhMSHJjR3pwTHFYeGdS?= =?utf-8?B?eXNoK2d4ekR4NGtnZEJJV0dBNEowNnJ1NWtzYTVudHNnLzFHbUo1TyswcjVW?= =?utf-8?B?dlRCYmwwdGtCdWRoalhCQXg4cEJLRlZRV0N0ekVIMXNOMTFCVmJRS0pwSVM3?= =?utf-8?B?cngyUEhSd2JNYzBRUE5KMXpTUngyMHd1N0RDd0FvNG5YcUhiRmtXNlA1eUFi?= =?utf-8?B?NUptUFpzRjhvdTc4akJzUG9GWHJjTXlPK1VFSTJmYXVVZElkSjBjTmdVb2d4?= =?utf-8?B?N3QyZWFYS0tBa05ZdFo0bHB4UUloWFpQRlBSRWl2L0hxWklhUjcvWmEvcjIv?= =?utf-8?B?S1IwNE8vWmRpcFQycGJMR21RRk5DVHhlc3hCaHU5R1hLQ0pybnFrWVBUTTRM?= =?utf-8?B?YURNdWZ4TG9NY05ETkErUGY3NEZLbVJNZ0JmRGpuYkk2WjRwNmluOXZia0xZ?= =?utf-8?B?UjZiL1JONm1ORFBIamVFRTJNQWsvWnBiYXMzcE1YTEFwVGc3UVNXOHZmZ1du?= =?utf-8?B?OTY1MWhVcWE5R1F6Ly9zbEJrSzFmWjJiek9aQ0FkbmxnR1NHYjJZQ0hTNDh5?= =?utf-8?B?V0tVd2krRHpyRWRQMDZtOWVOcndPemx6b2NESm51My9XQlE1dGdYeHJjcUlx?= =?utf-8?B?LzYvdzcxaHBYYVp5WmR0WnBPcW5tVGxteExDUHdxY29MNVhBVnNRakxaSEtp?= =?utf-8?B?VGtRd3d0ZHRSSmpadWlwZ2JiNDQzZ3RjdjBqR3hVTVpSVFpyR3lROVpiajNi?= =?utf-8?B?bFNLZ2xBRFJtN1AvbnA5S3kyeThWVTFkb25zYzJnLzhtQmVFdm5TdmpnYlpl?= =?utf-8?B?NTVJaUtMeXhMMHAxQ2x5SEFkamNLb2lKNGUzMkpYVHVBWmVGWTlGc3VLbzhn?= =?utf-8?B?N3RUMUZZbEhaWFlQYWdBQVR5VEh6WUYrSy9MU1pVVWFFaTdvZklTM3NLVVI0?= =?utf-8?B?RGJ6RXhIY3ZISGpKVy85SUZjZ05xQnNPalYwVUwvN21jMVI1cG02Zjh3ZkFz?= =?utf-8?B?UTJPYnRsTGVIMzZjblNsRTU0YXFvVDI4a2wvMHdhZmVNL0ZPL20xZXNBR0Zv?= =?utf-8?B?dUZLSmZrYWp3Mk84MGE3QlF5MXBGMUtOd2dmTVRISkFjSkNtQ2tWTGEvcUk2?= =?utf-8?B?R092MTRma2FacEJXSlFWZzlSTS9KREd6dElIbGFlT0tlNE5DcS9RTjMwOEgr?= =?utf-8?B?UHc4VC9aQlhmMUhLMDRCNzl4SzlEekJrU1ptaDZuelpVT1hZVEU0R0hoSFpI?= =?utf-8?Q?yBoHBFeSRAnE2c8b342LDbmhC?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: dac79f0a-5c58-4e79-bd57-08dac190e7a5 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 13:55:33.4709 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VctGlTlBK0qw8JYlUldyD4xFza40B79P9KPGswRdjuFWW+e9KM9JxZd5Tq6/KmZMtU9kY3d1IZ0OCYp9drWKvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6039 The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image from the firmware instead of doing it on the PCI ROM on the physical device. As such, this needs to be available for PVH dom0 to access, or else the GPU won't work. Reported-by: Huang Rui Signed-off-by: Roger Pau Monné --- This is a bugfix, but given PVH dom0 is still experimental I'm not sure it would qualify for the release. OTOH being experimental means there are no guarantees it will work, so the change is unlikely to make this any worse. --- xen/arch/x86/hvm/dom0_build.c | 1 + xen/include/acpi/actbl3.h | 1 + 2 files changed, 2 insertions(+) diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index 1864d048a1..307edc6a8c 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -924,6 +924,7 @@ static bool __init pvh_acpi_table_allowed(const char *sig, ACPI_SIG_DSDT, ACPI_SIG_FADT, ACPI_SIG_FACS, ACPI_SIG_PSDT, ACPI_SIG_SSDT, ACPI_SIG_SBST, ACPI_SIG_MCFG, ACPI_SIG_SLIC, ACPI_SIG_MSDM, ACPI_SIG_WDAT, ACPI_SIG_FPDT, ACPI_SIG_S3PT, + ACPI_SIG_VFCT, }; unsigned int i; diff --git a/xen/include/acpi/actbl3.h b/xen/include/acpi/actbl3.h index 0a6778421f..6858d3e60f 100644 --- a/xen/include/acpi/actbl3.h +++ b/xen/include/acpi/actbl3.h @@ -79,6 +79,7 @@ #define ACPI_SIG_MATR "MATR" /* Memory Address Translation Table */ #define ACPI_SIG_MSDM "MSDM" /* Microsoft Data Management Table */ #define ACPI_SIG_WPBT "WPBT" /* Windows Platform Binary Table */ +#define ACPI_SIG_VFCT "VFCT" /* AMD Video BIOS */ /* * All tables must be byte-packed to match the ACPI specification, since -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 14:00:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 14:00:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440062.694114 (Exim 4.92) (envelope-from ) id 1osP9r-00051E-6X; Tue, 08 Nov 2022 14:00:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440062.694114; Tue, 08 Nov 2022 14:00:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osP9r-000517-3K; Tue, 08 Nov 2022 14:00:55 +0000 Received: by outflank-mailman (input) for mailman id 440062; Tue, 08 Nov 2022 14:00:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osP9q-00050y-7Z for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 14:00:54 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2051.outbound.protection.outlook.com [40.107.22.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c1e01831-5f6d-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 15:00:52 +0100 (CET) Received: from AM6PR04CA0045.eurprd04.prod.outlook.com (2603:10a6:20b:f0::22) by AS4PR08MB7925.eurprd08.prod.outlook.com (2603:10a6:20b:574::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 14:00:45 +0000 Received: from AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:f0:cafe::50) by AM6PR04CA0045.outlook.office365.com (2603:10a6:20b:f0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Tue, 8 Nov 2022 14:00:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT014.mail.protection.outlook.com (100.127.140.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 14:00:45 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Tue, 08 Nov 2022 14:00:45 +0000 Received: from acdae347cb23.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2390BDE9-AA57-465D-B5CD-3DB25EA708EF.1; Tue, 08 Nov 2022 14:00:38 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id acdae347cb23.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Nov 2022 14:00:38 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM0PR08MB5476.eurprd08.prod.outlook.com (2603:10a6:208:18d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 14:00:35 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893%4]) with mapi id 15.20.5813.011; Tue, 8 Nov 2022 14:00:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1e01831-5f6d-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=S4RCHAXXpSwM5zDiUM1p77yj37k5+yfms9AeN0yBv6dF/NHbr/QT541gGiLd8+u35WsXUeWpgc9qWXCPo0WUlrbIRCjaIU03LApxfL8c9/aqn4WW3tWpuHWHqnQx3TssOY1lmSrXGNTxlv96nuOgdQSdyJMoBBg6JGKklEyGRTOY0etrgVmzs7E6J6sAz0Oq6Rt6B3xqfOqR5YkXaUftyr/uMovvyifUPOGC+w5eS7VAlbfppTc7i1mHXpHrERsxW/vMHpxEo9gkarCCj2DNvHR86waOIHY6QPvZm4dZPOuyP11um8pC2dwmVIhIke4Yr983sKMmxsX90Nnudzu54A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7c0pFD1+SOhmYB3zIrRf6nhJd/BNXs/pYswEKagG/OU=; b=JRA5+28kDAmmM+v2GXyKjkrZ1BEjgZl7A5FcihZ7JaOCQjN720N4K3Ham5epWlaK/RoV1UQGD+Nq3v5Od0JTX8QDfY58/x+xT1ECAAU0WRS4qwIY5ux90hxsyWSUVReKZ1eHghWl5CdMogFaamO8GrPSlrJXUezrJqffxApCRlsN9MVPqOBtCwaBR0DYp5n2inxpqwJtWz6xSW5hGEz0xpUMJzvKX4cUjLg5HS3VN4B6FPyjEmvtxzI3vUDUdL1e2pM5x+V4FbxyPzSDvOYTdvcIHbIQ6zKEktQeGB+iv4Q60mjmz7pwXWN1iVYZaU5KnpwQJw4E2ral2SJcxIMTcw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7c0pFD1+SOhmYB3zIrRf6nhJd/BNXs/pYswEKagG/OU=; b=jVPW/TQBMsoVYgOufJhoWu+qLEW3lVHX140nTs+rWkLcO281xKkYGDdEc8As4Phv6ZH9LpcpME0gse8ysDPbfgtvCGrFpaGIKB3kxqklemkkw3AJPswhb66Tm7loZeGrrXcx3jE4dTh6j9jmwLEFyltab9YoEhrYEeVK/J7HXx0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9b83efeefe135635 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MxLIGTXkB/I6lBbDJkCx7Mo1KdO8saRBDc11ZQ9cpvdxjbl8o7W8b6ir4HCBpz5WtC7eygVhw70CodRKfUYlimuNiq9rUv1UlDlwKtpQfanDRfpbLsUk5Xc8Mgf1InQv+ziAxdSPb64/fYWLnLfmIm3Ne9e8pMTsXIHqr41MJcPiETp8cVPHnREkDgNlBpFa1QgNDruXIJeQubZkFj0XwtH0NZMcKU/IiwU12/GuI5o1xJ33tsl2/OhRPxog2no8ZhQqvS7SopzddV+37Ggf+DZGzCqAZFdVLPrq1+XxYdbn6cwfjCwCzOay2rnSCP3SgCI9vVVI3R/26Gad7sITjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7c0pFD1+SOhmYB3zIrRf6nhJd/BNXs/pYswEKagG/OU=; b=XZtILcLCIk8COEN0LVvEle6gQuGBEIqiAhuNnLSPbzC1l5OuRNK6mpugdxFzUhE7ZXa4QOitpwlbTr+8++1P0sie2q/5QZaELosY2WOWXDpxXPbClsUpoQ+sA2I5omlOEM+FT4h2O8NgvNgll5Gr7G6So0HmOsN0jQhi3p1Fc0Dr2P1pvF/+YfvsLPYoOKBceSOTUtqZafeZ/1KYS91Ptb6jAiOV0V+8QcXHxZnHzcBd+6RJ84t7gb44Uv0ILqdV6VFJqO06aff53Hrvc6/YbuVFmf2R4kG7+8eVIB5DT5K7cAC2gZ3W/wBaRITdIoFHKmqZVHYVDnIWKjqg2MJ8Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7c0pFD1+SOhmYB3zIrRf6nhJd/BNXs/pYswEKagG/OU=; b=jVPW/TQBMsoVYgOufJhoWu+qLEW3lVHX140nTs+rWkLcO281xKkYGDdEc8As4Phv6ZH9LpcpME0gse8ysDPbfgtvCGrFpaGIKB3kxqklemkkw3AJPswhb66Tm7loZeGrrXcx3jE4dTh6j9jmwLEFyltab9YoEhrYEeVK/J7HXx0= From: Luca Fancellu To: Jan Beulich CC: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Thread-Topic: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Thread-Index: AQHY8pZ008DS0BACDkyhs+OWN8Oan64zqLWAgAE0WoCAAA3SgIAAJOMA Date: Tue, 8 Nov 2022 14:00:35 +0000 Message-ID: References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|AM0PR08MB5476:EE_|AM7EUR03FT014:EE_|AS4PR08MB7925:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ab12502-4417-4afa-024b-08dac191a1e5 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kWGKMTgkk6AzRILP+VeGVMO2iv9gGYtx2/fLjw2Aujy5zj9RXlDGM8gzMArn8kDOSnCo/XxVbNsi7qo+2UWj4LWIPpNnxlPCGXFgdkdYma5PDC674mZtossQofnf2VgRYDlrE08tWT/tpXNMCy5tZeCuilg1Q6bN156pjKTdoJ5uzbywJC+GGd8udeaXfdUKMC7atUe8/JmB9VWdFhQLAFsx0e91APJfKHKBv1KIfEfYcoZDaEYOxy2xwXcYGYCdQIbLXtVnrA4m2OR4/xkz7O4gcZaIelXBdCPsLQuF22s7YwWzmY4BYn2PSUxP2X+sTc9G7vy7XGuYYLYxD9882WKBay3UwmEvvsdn1P0G7ybsQKdbYmcxRZqAzddLZ1QPvOq9gA2cDppjU8T+Klt2qMSrsj2lgQHAg8zFEvqEY9/t+RZrInNgtSFOc/YMWkRQTnrROWk/1tZUGAumAe/VbbkjxziP3W9PZqI1r6m9gebnZ8VSp97RxfUre3Yg0J4fog+3E8KN9eraPU52kQ/cXriMhnhmQVrUJfVALpKPN6+56zFeI/P3bpc6tKq3BRmcdwSGV6lYLaKahuJumQp4DmMdaLlh2odCtA0IQpp2cgJBR1fsFF9Lhs/QEj4lt4k2paCX18rKNeQBGMME7/8Ds47LFU7Oev0LA33tNoPurQtBWqwqGRAS9awY1FyEvP7/WHWKIqnW5uPW0exRru9TNlq+husa4hE9QUZY4z4JqYoQIzO4RLtKJEdVZW1Fdhv2xifVY0fVAQljBERuI+VVl2i6yIDOB/ijT/o1PtmLZWw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(39860400002)(346002)(136003)(376002)(451199015)(66899015)(36756003)(64756008)(41300700001)(8676002)(5660300002)(66446008)(66556008)(6506007)(71200400001)(122000001)(8936002)(91956017)(76116006)(4326008)(6486002)(6916009)(54906003)(66476007)(66946007)(316002)(33656002)(38070700005)(2906002)(53546011)(38100700002)(26005)(83380400001)(478600001)(86362001)(6512007)(2616005)(186003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <266B9909890A804FAE7633277E3C0748@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5476 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d0bc7b6b-9c80-4339-8053-08dac1919b99 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 20ws4JHl0MePqrDNgp1QL9kpGblX213ZZtPGMkf77tEXJ9fVdYwjTpSvwzEyNou8vefAbYs1lGKKybx+8LBNTALcmL4Jzj1HhXmFWjH5tfVEo5H/8/726vO748Ghs7Bo6t5adYu5kzOSFn5kaxO1SajLnUwHoE5hrTrf4YpiimnaL1VMtj09AQZifjwNXkppXgPsRdR1W1F9Kpl4Ap5kfSw+kBS3u9SlLljkqbBFnCXS/OtU/Lzcq9LH3P/T6bEyHJ2oFSKDJ7Fj1Fgk8vRHq4cintL+Y0aExHHUlHILPuiOqzCMSzaMp6bavJEa24OHzjG3AqS05UpJophpgFlH1Jax43z5Gx9vcKv6S+Gzq2sWQxhwibjpdUchIZLNZYNqQv85ck6WTNBvJnVSLU5nxtkStvDkXERFNBf0eA7u71Q0Wn+nkor1AeO8PFmeBI/RFAQwaauSNi5Akuak/jZ/qIrl+mPGHeqBbonIk8jQ9yMGIeBd1Ryjmvja4lkng3Yb/G1n2b2HnRHNQHClcut5MBdoUZftsJEdWZ4ZBWlGe/DgtGM3sOrghS6OoBzo+00uyJEuDEcXch2EvcwOyhANWNJ1Dw0yClHyolPScuKCGW1mdj3CeAOqFLFlK6HL1IY5QzRDV68gcl00aUn+NQmhFK1qvLjZ4Rg7KqtTOMgXR3QKk9HlId4zE/xIZ2lmZgJftyTYo4x+nlXXQ7vpt9iWHCddAiKhd8wst1janSrBeoay5BJolrFdAwz/qPiD+eZm2AE1ANo6VxcuXijtrXwXYw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(136003)(396003)(451199015)(36840700001)(46966006)(40470700004)(2616005)(83380400001)(336012)(82740400003)(47076005)(33656002)(356005)(81166007)(36860700001)(186003)(2906002)(5660300002)(82310400005)(86362001)(40480700001)(478600001)(6486002)(6506007)(6512007)(26005)(40460700003)(70206006)(8676002)(53546011)(8936002)(316002)(6862004)(70586007)(4326008)(54906003)(41300700001)(66899015)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 14:00:45.5499 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4ab12502-4417-4afa-024b-08dac191a1e5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7925 DQoNCj4gT24gOCBOb3YgMjAyMiwgYXQgMTE6NDgsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwOC4xMS4yMDIyIDExOjU5LCBMdWNhIEZhbmNlbGx1IHdy b3RlOg0KPj4+IE9uIDA3LjExLjIwMjIgMTE6NDcsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4+ ICtIZXJlIGlzIGFuIGV4YW1wbGUgdG8gYWRkIGEgbmV3IGp1c3RpZmljYXRpb24gaW4gZmFsc2Ut cG9zaXRpdmUtPHRvb2w+Lmpzb246Og0KPj4+IA0KPj4+IFdpdGggPHRvb2w+IGFscmVhZHkgcHJl c2VudCBpbiB0aGUgbmFtZSwgLi4uDQo+Pj4gDQo+Pj4+ICt8ew0KPj4+PiArfCAgICAidmVyc2lv biI6ICIxLjAiLA0KPj4+PiArfCAgICAiY29udGVudCI6IFsNCj4+Pj4gK3wgICAgICAgIHsNCj4+ Pj4gK3wgICAgICAgICAgICAiaWQiOiAiU0FGLTAtZmFsc2UtcG9zaXRpdmUtPHRvb2w+IiwNCj4+ Pj4gK3wgICAgICAgICAgICAiYW5hbHlzZXIiOiB7DQo+Pj4+ICt8ICAgICAgICAgICAgICAgICI8 dG9vbD4iOiAiPHByb3ByaWV0YXJ5LWlkPiINCj4+PiANCj4+PiAuLi4gY2FuIHdlIGF2b2lkIHRo ZSByZWR1bmRhbmN5IGhlcmU/IFBlcmhhcHMgLi4uDQo+Pj4gDQo+Pj4+ICt8ICAgICAgICAgICAg fSwNCj4+Pj4gK3wgICAgICAgICAgICAidG9vbC12ZXJzaW9uIjogIjx2ZXJzaW9uPiIsDQo+Pj4g DQo+Pj4gLi4uIGl0IGNvdWxkIGJlDQo+Pj4gDQo+Pj4gICAgICAgICAgICJhbmFseXNlciI6IHsN Cj4+PiAgICAgICAgICAgICAgICI8dmVyc2lvbj4iOiAiPHByb3ByaWV0YXJ5LWlkPiINCj4+PiAg ICAgICAgICAgfSwNCj4+IA0KPj4gWWVzIGl04oCZcyBhIGJpdCByZWR1bmRhbnQgYnV0IGl0IGhl bHBzIHJlLXVzaW5nIHRoZSBzYW1lIHRvb2wgd2UgdXNlIGZvciBzYWZlLmpzb24NCj4gDQo+IEkg Z3Vlc3MgdGhlIHRvb2wgY291bGQgYWxzbyBiZSBtYWRlIGNvcGUgd2l0aG91dCBtdWNoIGVmZm9y dC4NCg0KSSBjYW4gbW9kaWZ5IHRoZSBzY3JpcHQgdG8gdGFrZSBhbiBhZGRpdGlvbmFsIHBhcmFt ZXRlciB0byBkaXN0aW5ndWlzaCBiZXR3ZWVuIHNhZmUuanNvbg0KYW5kIGZhbHNlLXBvc2l0aXZl LSouanNvbiwgdGhlbiBjYWxsIHR3aWNlIHRoZSBzY3JpcHQgYW5kIGFwcGVuZCB0aGUgcmVzdWx0 IHRvIHRoZSAuc2VkIGZpbGUuDQoNCj4gDQo+Pj4+IEBAIC03NTcsNiArNzU4LDUxIEBAIGNwcGNo ZWNrLXZlcnNpb246DQo+Pj4+ICQob2JqdHJlZSkvaW5jbHVkZS9nZW5lcmF0ZWQvY29tcGlsZXIt ZGVmLmg6DQo+Pj4+IAkkKFEpJChDQykgLWRNIC1FIC1vICRAIC0gPCAvZGV2L251bGwNCj4+Pj4g DQo+Pj4+ICtKVVNUSUZJQ0FUSU9OX0ZJTEVTIDo9ICQoWEVOX1JPT1QpL2RvY3MvbWlzcmEvc2Fm ZS5qc29uIFwNCj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgJChYRU5fUk9PVCkvZG9jcy9t aXNyYS9mYWxzZS1wb3NpdGl2ZS0kJCouanNvbg0KPj4+PiArDQo+Pj4+ICsjIFRoZSBmb2xsb3dp bmcgY29tbWFuZCBpcyB1c2luZyBncmVwIHRvIGZpbmQgYWxsIGZpbGVzIHRoYXQgY29udGFpbnMg YSBjb21tZW50DQo+Pj4+ICsjIGNvbnRhaW5pbmcgIlNBRi08YW55dGhpbmc+IiBvbiBhIHNpbmds ZSBsaW5lLg0KPj4+PiArIyAlLnNhZnBhcnNlIHdpbGwgYmUgdGhlIG9yaWdpbmFsIGZpbGVzIHNh dmVkIGZyb20gdGhlIGJ1aWxkIHN5c3RlbSwgdGhlc2UgZmlsZXMNCj4+Pj4gKyMgd2lsbCBiZSBy ZXN0b3JlZCBhdCB0aGUgZW5kIG9mIHRoZSBhbmFseXNpcyBzdGVwDQo+Pj4+ICtQQVJTRV9GSUxF X0xJU1QgOj0gJChhZGRzdWZmaXggLnNhZnBhcnNlLCQoZmlsdGVyLW91dCAlLnNhZnBhcnNlLFwN Cj4+Pj4gKyQoc2hlbGwgZ3JlcCAtRVJsICdeW1s6Ymxhbms6XV0qXC9cKltbOnNwYWNlOl1dK1NB Ri0uKlwqXC8kJCcgJChzcmN0cmVlKSkpKQ0KPj4+IA0KPj4+IFBsZWFzZSBpbmRlbnQgc3VjaCBs aW5lIGNvbnRpbnVhdGlvbnMuIEFuZCB0aGVuIGlzbid0IHRoaXMgZ29pbmcgdG8gcmlzaw0KPj4+ IG1hdGNoaW5nIG5vbi1zb3VyY2UgZmlsZXMgYXMgd2VsbD8gUGVyaGFwcyB5b3Ugd2FudCB0byBy ZXN0cmljdCB0aGlzIHRvDQo+Pj4gKi5jIGFuZCAqLmg/DQo+PiANCj4+IFllcywgaG93IGFib3V0 IHRoaXMsIGl0IHdpbGwgZmlsdGVyIG91dCAqLnNhZnBhcnNlIGZpbGVzIHdoaWxlIGtlZXBpbmcg aW4gb25seSAuaCBhbmQgLmM6DQo+PiANCj4+IFBBUlNFX0ZJTEVfTElTVCA6PSAkKGFkZHN1ZmZp eCAuc2FmcGFyc2UsJChmaWx0ZXIgJS5jICUuaCxcDQo+PiAgICAkKHNoZWxsIGdyZXAgLUVSbCAn XltbOmJsYW5rOl1dKlwvXCpbWzpzcGFjZTpdXStTQUYtLipcKlwvJCQnICQoc3JjdHJlZSkpKSkN Cj4gDQo+IFRoYXQncyBiZXR0ZXIsIGJ1dCBzdGlsbCBtZWFucyB0b3VjaGluZyBhbGwgZmlsZXMg YnkgZ3JlcCBkZXNwaXRlIG5vdw0KPiBvbmx5IGEgc3Vic2V0IHJlYWxseSBsb29rZWQgZm9yLiBJ ZiBJIHdhcyB0byB1c2UgdGhlIG5ldyBnb2FscyBvbiBhDQo+IG1vcmUgb3IgbGVzcyByZWd1bGFy IGJhc2lzLCBJJ2QgZXhwZWN0IHRoYXQgdGhpcyBlbnVtZXJhdGlvbiBvZiBmaWxlcw0KPiBkb2Vz bid0IHJlYWQgX211Y2hfIG1vcmUgc3R1ZmYgZnJvbSBkaXNrIHRoYW4gaXMgYWN0dWFsbHkgbmVj ZXNzYXJ5Lg0KDQpPayB3b3VsZCBpdCBiZSBvaz8NCg0KUEFSU0VfRklMRV9MSVNUIDo9ICQoYWRk c3VmZml4IC5zYWZwYXJzZSwkKHNoZWxsIGdyZXAgLUVSbCAtLWluY2x1ZGU9XCouaCBcDQogICAg LS1pbmNsdWRlPVwqLmMgJ15bWzpibGFuazpdXSpcL1wqW1s6c3BhY2U6XV0rU0FGLS4qXCpcLyQk JyAkKHNyY3RyZWUpKSkNCg0KPiANCj4+PiBUbyBsaW1pdCB3b3JrIGRvbmUsIGNvdWxkIHRoaXMg bWUgIm12IiBpbnN0ZWFkIG9mICJjcCAtcCIsIGFuZCB0aGVuIC4uLg0KPj4+IA0KPj4+PiArYW5h bHlzaXMtcGFyc2UtdGFncy0lOiAkKFBBUlNFX0ZJTEVfTElTVCkgJChvYmp0cmVlKS8lLnNlZA0K Pj4+PiArCSQoUSlmb3IgZmlsZSBpbiAkKHBhdHN1YnN0ICUuc2FmcGFyc2UsJSwkKFBBUlNFX0ZJ TEVfTElTVCkpOyBkbyBcDQo+Pj4+ICsJCXNlZCAtaSAtZiAiJChvYmp0cmVlKS8kKi5zZWQiICIk JHtmaWxlfSI7IFwNCj4+PiANCj4+PiAuLi4gd2l0aCB0aGVuIHVzaW5nDQo+Pj4gDQo+Pj4gCQlz ZWQgLWYgIiQob2JqdHJlZSkvJCouc2VkIiAiJCR7ZmlsZX0uc2FmcGFyc2UiID4iJCR7ZmlsZX0i DQo+Pj4gDQo+Pj4gaGVyZT8gVGhpcyB3b3VsZCB0aGVuIGFsc28gaGF2ZSBzb3VyY2UgY29uc2lz dGVudCBiZXR3ZWVuIHByZXJlcXMgYW5kDQo+Pj4gcnVsZS4NCj4+IA0KPj4gV2Ugc2F3IHRoYXQg bXYgaXMgbm90IHByZXNlcnZpbmcgdGhlIHRpbWVzdGFtcCBvZiB0aGUgZmlsZSwgaW5zdGVhZCB3 ZSB3b3VsZCBsaWtlIHRvIHByZXNlcnZlDQo+PiBpdCwgZm9yIHRoaXMgcmVhc29uIHdlIHVzZWQg Y3AgLXANCj4gDQo+IEJ1Z2d5IG12PyBJdCBjZXJ0YWlubHkgZG9lc24ndCBhbHRlciB0aW1lc3Rh bXBzIGhlcmUsIGFuZCBJIGRvbid0IHRoaW5rDQo+IHRoZSBzcGVjIGFsbG93cyBmb3IgaXQgZG9p bmcgc28gKGF0IGxlYXN0IHdoZW4gaXQgZG9lc24ndCBuZWVkIHRvIHJlc29ydA0KPiB0byBjb3B5 aW5nIHRvIGRlYWwgd2l0aCBjcm9zcy12b2x1bWUgbW92ZXMsIGJ1dCB0aG9zZSBjYW4ndCBoYXBw ZW4gaGVyZSkuDQoNClllcyB5b3UgYXJlIHJpZ2h0LCBteSBhc3N1bXB0aW9uIHdhcyB3cm9uZywg SSB3aWxsIGNoYW5nZSB0aGUgY29kZSBhcyB5b3Ugc3VnZ2VzdGVkLg0KDQo+IA0KPj4+PiArCWRv bmUNCj4+Pj4gKw0KPj4+PiArYW5hbHlzaXMtYnVpbGQtJTogYW5hbHlzaXMtcGFyc2UtdGFncy0l DQo+Pj4+ICsJJChNQUtFKSBPPSQoYWJzX29ianRyZWUpIC1mICQoc3JjdHJlZSkvTWFrZWZpbGUg YnVpbGQNCj4+PiANCj4+PiBUaGlzIHJ1bGUgZG9lc24ndCB1c2UgdGhlIHN0ZW0sIHNvIEknbSBz dHJ1Z2dsaW5nIHRvIHVuZGVyc3RhbmQgd2hhdA0KPj4+IHRoaXMgaXMgYWJvdXQuDQo+PiANCj4+ IFllcywgaGVyZSBteSBhaW0gd2FzIHRvIGNhdGNoIGFuYWx5c2lzLWJ1aWxkLXtlY2xhaXIsY292 ZXJpdHl9LCBoZXJlIEkgc2VlIHRoYXQgaWYgdGhlIHVzZXIgaGFzIGEgdHlwbw0KPj4gdGhlIHJ1 bGUgd2lsbCBydW4gYW55d2F5LCBidXQgaXQgd2lsbCBiZSBzdG9wcGVkIGJ5IHRoZSBkZXBlbmRl bmN5IGNoYWluIGJlY2F1c2UgYXQgdGhlIGVuZCB3ZSBoYXZlOg0KPj4gDQo+PiBKVVNUSUZJQ0FU SU9OX0ZJTEVTIDo9ICQoWEVOX1JPT1QpL2RvY3MvbWlzcmEvc2FmZS5qc29uIFwNCj4+ICAgICAg ICAgICAgICAgICAgICAgICAkKFhFTl9ST09UKS9kb2NzL21pc3JhL2ZhbHNlLXBvc2l0aXZlLSQk Ki5qc29uDQo+PiANCj4+IFRoYXQgd2lsbCBnaXZlIGFuIGVycm9yIGJlY2F1c2UgJChYRU5fUk9P VCkvZG9jcy9taXNyYS9mYWxzZS1wb3NpdGl2ZS08dHlwbz4uanNvbiBkb2VzIG5vdCBleGlzdHMu DQo+PiANCj4+IElmIHlvdSB0aGluayBpdCBpcyBub3QgZW5vdWdoLCB3aGF0IGlmIEkgcmVkdWNl IHRoZSBzY29wZSBvZiB0aGUgcnVsZSBsaWtlIHRoaXM/DQo+PiANCj4+IF9hbmFseXNpcy1jb3Zl cml0eSBfYW5hbHlzaXMtZWNsYWlyOiBfYW5hbHlzaXMtJTogYW5hbHlzaXMtYnVpbGQtJQ0KPiAN Cj4gQnV0IHRoZW4sIHdpdGhvdXQgdXNpbmcgdGhlIHN0ZW0sIGhvdyBkb2VzIGl0IGtub3cgd2hl dGhlciB0byBkbyBhbg0KPiBFY2xhaXIgb3IgYSBDb3Zlcml0eSBydW4/DQoNClNvcnJ5IEkgdGhp bmsgSeKAmW0gYSBiaXQgbG9zdCBoZXJlLCB0aGUgbWFrZWZpbGUgaXMgd29ya2luZyBvbiBib3Ro IGFuYWx5c2lzLWNvdmVyaXR5IGFuZCBhbmFseXNpcy1lY2xhaXINCmJlY2F1c2UgdGhlICUgaXMg c29sdmluZyBpbiBjb3Zlcml0eSBvciBlY2xhaXIgZGVwZW5kaW5nIG9uIHdoaWNoIHRoZSBtYWtl ZmlsZSBoYXMgaW4gaW5wdXQsIGl0IGlzIG5vdCBjb21wbGFpbmluZw0Kc28gSSBndWVzcyBpdCB3 b3Jrcy4NCkRvIHlvdSBzZWUgc29tZXRoaW5nIG5vdCB3b3JraW5nPyBJZiBzbywgYXJlIHlvdSBh YmxlIHRvIHByb3ZpZGUgYSBwaWVjZSBvZiBjb2RlIGZvciB0aGF0IHRvIG1ha2UgbWUgdW5kZXJz dGFuZD8NCg0KPiANCj4+IE9yLCBpZiB5b3UgYXJlIHN0aWxsIHdvcnJpZWQgYWJvdXQg4oCcYW5h bHlzaXMtYnVpbGQtJTogYW5hbHlzaXMtcGFyc2UtdGFncy0l4oCdLCB0aGVuIEkgY2FuIGRvIHNv bWV0aGluZw0KPj4gbGlrZSB0aGlzOiANCj4+IA0KPj4gYW5hbHlzaXMtc3VwcG9ydGVkLWNvdmVy aXR5IGFuYWx5c2lzLXN1cHBvcnRlZC1lY2xhaXI6DQo+PiAgICBAZWNobyA+IC9kZXYvbnVsbA0K Pj4gDQo+PiBhbmFseXNpcy1zdXBwb3J0ZWQtJToNCj4+ICAgIEBlcnJvciBVbnN1cHBvcnRlZCBh bmFseXNpcyB0b29sIEAqDQo+PiANCj4+IGFuYWx5c2lzLWJ1aWxkLSU6IGFuYWx5c2lzLXBhcnNl LXRhZ3MtJSB8IGFuYWx5c2lzLXN1cHBvcnRlZC0lDQo+PiAgICAkKE1BS0UpIE89JChhYnNfb2Jq dHJlZSkgLWYgJChzcmN0cmVlKS9NYWtlZmlsZSBidWlsZA0KPiANCj4gSWYgSSdtIG5vdCBtaXN0 YWtlbiBzdXBwb3J0IGZvciB8IGRvZXNuJ3QgZXhpc3QgaW4gbWFrZSAzLjgwICh0aGUNCj4gbWlu aW11bSB2ZXJzaW9uIHdlIHJlcXVpcmUgdG8gYmUgdXNlZCkuDQoNCklESywgd2UgdXNlIG9yZGVy LW9ubHkgcHJlcmVxdWlzaXRlIGFscmVhZHkgaW4gdGhlIE1ha2VmaWxlLg0KDQo+IA0KPj4+PiAr YW5hbHlzaXMtY2xlYW46DQo+Pj4+ICsjIFJldmVydHMgdGhlIG9yaWdpbmFsIGZpbGUgKC1wIHBy ZXNlcnZlcyBhbHNvIHRpbWVzdGFtcCkNCj4+Pj4gKwkkKFEpZmluZCAkKHNyY3RyZWUpIC10eXBl IGYgLW5hbWUgIiouc2FmcGFyc2UiIC1wcmludCB8IFwNCj4+Pj4gKwl3aGlsZSBJRlM9IHJlYWQg ZmlsZTsgZG8gXA0KPj4+PiArCQljcCAtcCAiJCR7ZmlsZX0iICIkJHtmaWxlJS5zYWZwYXJzZX0i OyBcDQo+Pj4+ICsJCXJtIC1mICIkJHtmaWxlfSI7IFwNCj4+PiANCj4+PiBXaHkgbm90ICJtdiI/ DQo+Pj4gDQo+Pj4+ICsJZG9uZQ0KPj4+PiArDQo+Pj4+ICtfYW5hbHlzaXMtJTogYW5hbHlzaXMt YnVpbGQtJQ0KPj4+PiArCSQoUSkkKE1BS0UpIE89JChhYnNfb2JqdHJlZSkgLWYgJChzcmN0cmVl KS9NYWtlZmlsZSBhbmFseXNpcy1jbGVhbg0KPj4+IA0KPj4+IEFnYWluIG5vIHVzZSBvZiB0aGUg c3RlbSwgcGx1cyBoZXJlIEkgd29uZGVyIGlmIHRoaXMgbWF5IG5vdCBsZWFkIHRvDQo+Pj4gcGVv cGxlIGludm9raW5nICJhbmFseXNpcy1jbGVhbiIgd2l0aG91dCBoYXZpbmcgc2FpZCBhbnl0aGlu ZyBhYm91dA0KPj4+IGNsZWFuaW5nIG9uIHRoZWlyIGNvbW1hbmQgbGluZS4NCj4+IA0KPj4gSW4g YW55IGNhc2UsIHRoZSBjbGVhbmluZyBwcm9jZXNzIGlzIHZlcnkgc2FmZSBhbmQgZG9lcyBub3Qg Y2xlYW4gYW55dGhpbmcgdGhhdCB3YXMgbm90IGRpcnR5IGJlZm9yZSwNCj4+IHNvIGluIGNhc2Ug b2YgdHlwb3MsIGl04oCZcyBqdXN0IGxpa2UgYSBub3AuDQo+IA0KPiBQZW9wbGUgbWF5IHB1dCB0 cmFuc2llbnQgZmlsZXMgaW4gdGhlaXIgdHJlZXMuIE9mIGNvdXJzZSB0aGV5IG5lZWQgdG8gYmUN Cj4gYXdhcmUgdGhhdCB3aGVuIHRoZXkgc3BlY2lmeSBhICJjbGVhbiIgdGFyZ2V0IHRoZWlyIGZp bGVzIG1heSBiZSBkZWxldGVkLg0KPiBCdXQgd2l0aG91dCBhbnkgImNsZWFuIiB0YXJnZXQgc3Bl Y2lmaWVkIG5vdGhpbmcgc2hvdWxkIGJlIHJlbW92ZWQuDQoNCiouc2FmcGFyc2UgZmlsZXMgYXJl IG5vdCBzdXBwb3NlZCB0byBiZSB1c2VkIGZyZWVseSBieSB1c2VyIGluIHRoZWlyIHRyZWUsIHRo b3NlDQpmaWxlcyB3aWxsIGJlIHJlbW92ZWQgb25seSBpZiB0aGUgdXNlciBjYWxscyB0aGUg4oCc YW5hbHlzaXMtY2xlYW7igJ0gdGFyZ2V0IG9yIGlmIHRoZQ0KYW5hbHlzaXMtY292ZXJpdHkgb3Ig YW5hbHlzaXMtZWNsYWlyIHJlYWNoZXMgdGhlIGVuZCAoYSBwcm9jZXNzIHRoYXQgY3JlYXRlcyAq LnNhZnBhcnNlKS4NCg0KVGhlcmUgaXMgbm8gb3RoZXIgd2F5IHRvIHRyaWdnZXIgdGhlIOKAnGFu YWx5c2lzLWNsZWFu4oCdIHVuaW50ZW50aW9uYWxseSwgc28gSeKAmW0gbm90IHN1cmUgYWJvdXQN CnRoZSBtb2RpZmljYXRpb24geW91IHdvdWxkIGxpa2UgdG8gc2VlIHRoZXJlLg0KDQo+IA0KPiBK YW4NCg0K From xen-devel-bounces@lists.xenproject.org Tue Nov 08 14:19:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 14:19:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440070.694125 (Exim 4.92) (envelope-from ) id 1osPS8-00076X-RY; Tue, 08 Nov 2022 14:19:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440070.694125; Tue, 08 Nov 2022 14:19:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osPS8-00076Q-Oc; Tue, 08 Nov 2022 14:19:48 +0000 Received: by outflank-mailman (input) for mailman id 440070; Tue, 08 Nov 2022 14:19:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osPS7-00076G-Cm; Tue, 08 Nov 2022 14:19:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osPS7-0007vr-8s; Tue, 08 Nov 2022 14:19:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osPS6-0006y8-CS; Tue, 08 Nov 2022 14:19:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osPS6-0005op-C0; Tue, 08 Nov 2022 14:19:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EjluglZtBX+NDsEJ2Nl6IPgb9OxLDXJS+ienCAd3sO8=; b=VLDRx5jYsDH7noM36vksuFt1Zx 3qh/HACFeZnUfqO85f+CNLhZE/MYr3pM4NsA3EpmgQJyEsv4V1nDYH2s48kj8eZnJv8PU+JxTNsxJ eda58IXU+9uS+MPM3cx19TSdZr+d5ereoetfJ5EADlzESFGkQz1i9ziDR3TUjVeCWx/4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174664: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=59f2f4b8a757412fce372f6d0767bdb55da127a8 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 08 Nov 2022 14:19:46 +0000 flight 174664 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174664/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 59f2f4b8a757412fce372f6d0767bdb55da127a8 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 31 days Failing since 173470 2022-10-08 06:21:34 Z 31 days 50 attempts Testing same since 174664 2022-11-08 02:40:00 Z 0 days 1 attempts ------------------------------------------------------------ 1602 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 152697 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Nov 08 14:42:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 14:42:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440082.694136 (Exim 4.92) (envelope-from ) id 1osPoQ-0002MG-NC; Tue, 08 Nov 2022 14:42:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440082.694136; Tue, 08 Nov 2022 14:42:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osPoQ-0002M9-KM; Tue, 08 Nov 2022 14:42:50 +0000 Received: by outflank-mailman (input) for mailman id 440082; Tue, 08 Nov 2022 14:42:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osPoO-0002M3-Tr for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 14:42:49 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2065.outbound.protection.outlook.com [40.107.96.65]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9bb95432-5f73-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 15:42:46 +0100 (CET) Received: from DM5PR12MB2504.namprd12.prod.outlook.com (2603:10b6:4:b5::19) by CY5PR12MB6369.namprd12.prod.outlook.com (2603:10b6:930:21::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Tue, 8 Nov 2022 14:42:43 +0000 Received: from DM5PR12MB2504.namprd12.prod.outlook.com ([fe80::ec49:f96d:d3f2:79d1]) by DM5PR12MB2504.namprd12.prod.outlook.com ([fe80::ec49:f96d:d3f2:79d1%4]) with mapi id 15.20.5791.020; Tue, 8 Nov 2022 14:42:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bb95432-5f73-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4wat7lqezk2gnsewENtOfr/96sas50U2lLd5HKifP1VaTxQYduTIK63FefKy5dnkzNL4IBx+B8LHydJSRGpPzsMk850HRZ5/KMCdz7FKctCkK6r/Tv2Bbd1QCMQYVZCTmhWCkfXS5glTbJGORwlbbC6HH9GpsyHkCbfkg5Tqc37ZOjVKtR2B7UiXvc8ExtUAA8AGNfTNHpS0BC9VVcdrBHsG6a4LZur9KGzsrBcYn3NT+IO2oCx1CE3veZC+x4+IDEVWln8r1yx7vk0LGvzpuLLh0vn/yEZAcCxHDBdlgW2JgmjPaU/8che4HX5XD1om5imLFGYCJnxbL5DgoONlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k0iC+xgTwyJpa4vtqYp9BNPcs9ycHF7WATSo5vet+Sk=; b=S27ZX+QxQof7EowgHjKnm1hrDV2zJ/n9tYF1pj1Lj2saiUQSKuEdPQm683co1mRKKGWTp5f/w7M5yMCIULvPHVPMD/f73IqPW4Z67BX8a4cIB6hSqPZFiHS9hHq9Nd3cMPBLk/NGWy5wFzO1G6TSKECTSMqrk6U5U0evdcubpARNS5fqClhkyBJkHBpLH0jlSt6Tne7YY0ORcEaAn+3D6lL86fy9CYM08XFUve65NGrdRtyWyPA5nhEsaDX+MllRuBjImD8BGCEmahZRWOQCnF7D6rcH8jQ98Fsg8hZHpULHBvnT6GLzooBdMD6/dXZ9aUJ0pBHyNhrOkin6zbLnQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k0iC+xgTwyJpa4vtqYp9BNPcs9ycHF7WATSo5vet+Sk=; b=ExSspsvMXcsdBEfhM/9qF17hVUiCqlsoiAKCLU7C7xVyNRMysiAmXwJsXjjtADT3UPBGyqEcZmiPu6IbA+tBhLBJCQI6HoplSe53Rr4v37Q6d00yOlhAnNZvRrtLFUk106LuY2rWaB8EVKLHcW01mQibXa7txPKgnY0szfuS1WA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Date: Tue, 8 Nov 2022 22:42:24 +0800 From: Huang Rui To: Roger Pau Monne Cc: "xen-devel@lists.xenproject.org" , "Henry.Wang@arm.com" , "Deucher, Alexander" , Jan Beulich , Andrew Cooper , Wei Liu Subject: Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present Message-ID: References: <20221108135516.62775-1-roger.pau@citrix.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221108135516.62775-1-roger.pau@citrix.com> X-ClientProxiedBy: TY2PR02CA0030.apcprd02.prod.outlook.com (2603:1096:404:a6::18) To DM5PR12MB2504.namprd12.prod.outlook.com (2603:10b6:4:b5::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR12MB2504:EE_|CY5PR12MB6369:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e390c5b-0122-4951-1dcb-08dac1977e71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uIFBPcTCAasF0QusHnxvYJR1iWCreWp9XyGBV1ekNkzxmlhNHUHSRkrkCF4GHztY/Ctrsnfsebbtmlj79/0FHsgPg527wZq15spbeJxDE7GcUU1VQ03BiI3o6W0UXr1oeRLHQqW7sld7U59r4lMlNcUU7AHaIlgjeTeyEiaPHL6tVGAyQgS+hvDbsI9Usn2rQTO5j59PHKiSV5mzuUXeDWuqkDK7D/tX8nLjPJe5mB6XbSrOj6x64Pp2MtwPiIsMVU75JvnxfjOJ1sD7ir7eaEaieWoMFQ4XIOLuS6MwyxtV6HjtRZEtuBXZgMLr0Gc9nlunpGXtqUdCPCmarqLCIkF3y5ceXCwPS7QwViYEmnH+PJHRckgPnRkgOXwkQFByDzbvZfUYehXYCSx94XnDKBYneUhCy70rYY3YYqxiyBbTPtK5+oBLnZsfnC5m9LjSbme7GYcnt3cFILhx8qLTAfT5qSWvamtAinnMeSi1idl8F1fomErYtPMfXa7ONfkA4RwtfUPbrS2PHAoIACloDsupGEtmPRCo3URwQoc36iwPeN7ZcPWzhAZqYp40eLmQJdpuAJXphRpEwPFh1ypI5VnPhRQdGVVOUxKE5XVyp9/2ftCKvvRMnwyLVP+TCdkNzAmT/rhxpQWZFkYk84krFb3ASYlP6frkDiBy7B/FO/MoO7xPyNLgjNC7YU6eoWFn/xty221j58MUM/ijLYTOTw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB2504.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(39860400002)(346002)(366004)(451199015)(36756003)(83380400001)(52230400001)(186003)(6506007)(2616005)(6666004)(6512007)(26005)(38100700002)(2906002)(5660300002)(86362001)(316002)(45080400002)(6916009)(54906003)(478600001)(6486002)(41300700001)(66556008)(8676002)(66476007)(66946007)(8936002)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?3lfHuXCzDClQV75AoR9KoJWVOOuVbcZhmNlcEaBXXNqlj1MbS/2oDL3CqV?= =?iso-8859-1?Q?aOfi1FNNiMWdTgVbOqXbOldTo9DBkxyY5YCSmnb9nAvbM9kasn8ukj2lRE?= =?iso-8859-1?Q?qBnqcYIdCIa2wcfR6gohr/bC4B3LO2SpsQcQ2mnACDUw9CXwVUMFnueJXR?= =?iso-8859-1?Q?IsShWAV8jCyRTKiqIH1E3t7io299IzhhvZ0mRAk6W1ydMqIxi0d0WCVBUs?= =?iso-8859-1?Q?YMJNZ4hEsfvDIXXxVV/cLCI4ZNBUjfNREYJS5QRp5M9QLLMd2CL0RQ/2b8?= =?iso-8859-1?Q?VmM+WeQ/EAqAHWegfvU0ROQZ5fcloYRKZX5G/AlGKuLkLwZ5j1RSa88fSv?= =?iso-8859-1?Q?a1kT2J6peHuH3oatf12p6xZsJcXJop6Ftiz8ezPyO/cQHstyGrVrAgDMeu?= =?iso-8859-1?Q?GCThtgaF82Bu6Uw5DUyMkYPK/NAF8VC4zkVdJDg1VIYiAhT/tu9z7DuWaq?= =?iso-8859-1?Q?D1PC0ww9AYc+HPPFOwiHTdleVO8rW8facwJ+NETV47tmRP7trTQwmvCILS?= =?iso-8859-1?Q?97DmLSkNS4e+tGktIXqsIglhCFyva4AfLrlF6XZOXtNicjY2WD8YfpvFEO?= =?iso-8859-1?Q?f2R7Ahv29W21FdZIbaz4jrA9Rl/ZxVrpTUtZ89eelFKOq9fXBLGZ4FZjhd?= =?iso-8859-1?Q?vNXH1zWug/xGsw4X6MWuNfGnCxLDJalvftwVSjIYZJNy15DkmOcpJJ/eny?= =?iso-8859-1?Q?XlLJ5m171TljHhlCBEilq1ylHcw6JkvLFyRTsJzoYEGJaGQrwxUuwy7L2S?= =?iso-8859-1?Q?7RveVx0BZ/R004KqFMEn1bnCgY6dtUD8S5sQissRrCLn9Xrl0l+QTMu4gZ?= =?iso-8859-1?Q?BiiFWTC3K8HR7imbvKzQgqBwHTQKH7bjUDdiK3YeMKYxJAxTnS9eZPcZ8C?= =?iso-8859-1?Q?A83JWP9roI13EotIRD7mMqjL/TbRrJehuRWAzwvV1tLg78L2geFt9hrUdD?= =?iso-8859-1?Q?edW38b5U1/v8bJlbp5SWc7oxIj5QD3xFTL3P1jgsTGhBL8yWBuFyUqCAq6?= =?iso-8859-1?Q?TBSnytjCSdZ+/bqnaWJpFap1oLQ8W1qZQMZsFGfaclYpuCvvFTFoRaHA8g?= =?iso-8859-1?Q?NvXc3LFgHHce9NyHnzHzWYV0aEGj78NEtkG9OMjBT63l29t0MAIPtLjqiG?= =?iso-8859-1?Q?3a2qXoRyn1EBCU4CWOL9BdPlRSh5uRkiaCKQR6bRtRi/fDC4/deOnLaSfG?= =?iso-8859-1?Q?tfNZ1MHiGU/+DxJRMa+6FlZyIThOFTKZ/zCtO/awpkTG/+MJrnp/GCKfse?= =?iso-8859-1?Q?MMTl9r4oclrLHJJmTLVCEo7NVCIkFHvgGrJynap0FfImj6qXmtOEEy+mO/?= =?iso-8859-1?Q?ISTmfPIcpBG1NtHNX0Zh0KjTx0eUelz7uK5rALG3xxP+CbBqzQoRmq4qj4?= =?iso-8859-1?Q?nZozLBlWjbGRTNNluvqCzG2tRkqKGxet+ihvqdrREhhm1LQC7zOeeJnNq/?= =?iso-8859-1?Q?WmgHpxXUhhqnfLUNL8GCdrPKWmqFZhhXdWpdlJ2qoQeiDrokTwy+XJoAhs?= =?iso-8859-1?Q?1t8LTzJvu0yFvsUrotF9t0kzzLQM1PcFkcKoc/q8JBAMLhtMEG1vmNtt6l?= =?iso-8859-1?Q?L6OpQ+5A05tPjMNWApKWijIii9NlK1TvzkCYG9TSMZbVFXDsQbIOS8LbKk?= =?iso-8859-1?Q?lyZ+fWZCTQXG/W0EsBq+NpmySxIw0nwPqH?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e390c5b-0122-4951-1dcb-08dac1977e71 X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 14:42:43.3630 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sOyUTZ2nIbcguV5HQjnQ0kCVywvBd5K2/ZSEW6csUmkuDv2M0QtFhsyLby3P0hakKEgXnbOyvkkorrl+Zcw4CQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6369 On Tue, Nov 08, 2022 at 09:55:16PM +0800, Roger Pau Monne wrote: > The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image > from the firmware instead of doing it on the PCI ROM on the physical > device. > > As such, this needs to be available for PVH dom0 to access, or else > the GPU won't work. > > Reported-by: Huang Rui > Signed-off-by: Roger Pau Monn > --- > This is a bugfix, but given PVH dom0 is still experimental I'm not > sure it would qualify for the release. OTOH being experimental means > there are no guarantees it will work, so the change is unlikely to > make this any worse. Yes, thanks Roger! AMD GPU needs a Video BIOS which needs to do the initialization for hardware. We use ACPI VFCT table to expose the VBIOS rom image even on the Xen PVH dom0, so we need to add the related signature in Xen as well. Acked-and-Tested-by: Huang Rui > --- > xen/arch/x86/hvm/dom0_build.c | 1 + > xen/include/acpi/actbl3.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c > index 1864d048a1..307edc6a8c 100644 > --- a/xen/arch/x86/hvm/dom0_build.c > +++ b/xen/arch/x86/hvm/dom0_build.c > @@ -924,6 +924,7 @@ static bool __init pvh_acpi_table_allowed(const char *sig, > ACPI_SIG_DSDT, ACPI_SIG_FADT, ACPI_SIG_FACS, ACPI_SIG_PSDT, > ACPI_SIG_SSDT, ACPI_SIG_SBST, ACPI_SIG_MCFG, ACPI_SIG_SLIC, > ACPI_SIG_MSDM, ACPI_SIG_WDAT, ACPI_SIG_FPDT, ACPI_SIG_S3PT, > + ACPI_SIG_VFCT, > }; > unsigned int i; > > diff --git a/xen/include/acpi/actbl3.h b/xen/include/acpi/actbl3.h > index 0a6778421f..6858d3e60f 100644 > --- a/xen/include/acpi/actbl3.h > +++ b/xen/include/acpi/actbl3.h > @@ -79,6 +79,7 @@ > #define ACPI_SIG_MATR "MATR" /* Memory Address Translation Table */ > #define ACPI_SIG_MSDM "MSDM" /* Microsoft Data Management Table */ > #define ACPI_SIG_WPBT "WPBT" /* Windows Platform Binary Table */ > +#define ACPI_SIG_VFCT "VFCT" /* AMD Video BIOS */ > > /* > * All tables must be byte-packed to match the ACPI specification, since > -- > 2.37.3 > From xen-devel-bounces@lists.xenproject.org Tue Nov 08 14:48:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 14:48:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440090.694147 (Exim 4.92) (envelope-from ) id 1osPuD-0003Dx-CO; Tue, 08 Nov 2022 14:48:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440090.694147; Tue, 08 Nov 2022 14:48:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osPuD-0003Dq-8y; Tue, 08 Nov 2022 14:48:49 +0000 Received: by outflank-mailman (input) for mailman id 440090; Tue, 08 Nov 2022 14:48:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osPuC-0003Dg-5W; Tue, 08 Nov 2022 14:48:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osPuC-00007a-2L; Tue, 08 Nov 2022 14:48:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osPuB-0007mx-JV; Tue, 08 Nov 2022 14:48:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osPuB-0007Xh-J3; Tue, 08 Nov 2022 14:48:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pTiHZVFGygWk8aV0oK2k6QVOQXs9ruHSgQijibVcei8=; b=AVWhZbXksgAm9sFvse47P8MDur nqj2ObDowsZezC/SHw/JXsaTtDbYz99sXk4G1VAuKOzIzqvAMhGaK2p2l1ZbyFMxijW/tJ7AlzZel rQcRZoGzD3E9WO6L1X40CZOj3osKxsEs13TFvaekUOm/CxolrO7wQ9rJkj+rlGEaZsmI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174667: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=d649faddb3ec0a360d1e15aa7aaf2452eba3bac8 X-Osstest-Versions-That: libvirt=7f7a09a2d25a668092be98ed5abfaeec572f5104 From: osstest service owner Date: Tue, 08 Nov 2022 14:48:47 +0000 flight 174667 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174667/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174643 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174643 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174643 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt d649faddb3ec0a360d1e15aa7aaf2452eba3bac8 baseline version: libvirt 7f7a09a2d25a668092be98ed5abfaeec572f5104 Last test of basis 174643 2022-11-06 04:22:48 Z 2 days Testing same since 174667 2022-11-08 04:18:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jakub Kuczys Michal Privoznik Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 7f7a09a2d2..d649faddb3 d649faddb3ec0a360d1e15aa7aaf2452eba3bac8 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:00:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:00:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440100.694158 (Exim 4.92) (envelope-from ) id 1osQ5c-0005pK-Jr; Tue, 08 Nov 2022 15:00:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440100.694158; Tue, 08 Nov 2022 15:00:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQ5c-0005pD-Fe; Tue, 08 Nov 2022 15:00:36 +0000 Received: by outflank-mailman (input) for mailman id 440100; Tue, 08 Nov 2022 15:00:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQ5a-0005p3-Gp; Tue, 08 Nov 2022 15:00:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQ5a-0000Lg-A1; Tue, 08 Nov 2022 15:00:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQ5Z-00088d-MZ; Tue, 08 Nov 2022 15:00:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osQ5Z-0004Sf-M8; Tue, 08 Nov 2022 15:00:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3kEJN/Y0ZhNt8hz9MPB5g1kVEdGZVZ9HaFChOxq768E=; b=fFMV1sUhAUXBx1VwB5bdhHxwCZ 639vDLq3tbwZroAqBajIO6opsiMhI5WS1z3I4ab5Id2ypgnr0CpYD+Z7kRYc5uqG29Ia0B2WbwlNT VxgeqpJDPszUpIErCcUy+NALcqZw0o5BTTkgP7l3SKXiaV9U8UoguWeafY2Unco43Cds=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174665: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-xsm:xen-boot:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start.2:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:redhat-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a0d9384967214783a92973c920092b7251c03e57 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Tue, 08 Nov 2022 15:00:33 +0000 flight 174665 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174665/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail in 174638 pass in 174665 test-amd64-i386-pair 11 xen-install/dst_host fail in 174638 pass in 174665 test-amd64-i386-libvirt-xsm 8 xen-boot fail in 174638 pass in 174665 test-armhf-armhf-xl-credit2 14 guest-start fail in 174638 pass in 174665 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174638 pass in 174665 test-armhf-armhf-xl-rtds 14 guest-start fail in 174638 pass in 174665 test-armhf-armhf-libvirt-raw 13 guest-start fail in 174638 pass in 174665 test-armhf-armhf-xl-credit1 19 guest-start.2 fail in 174646 pass in 174638 test-amd64-i386-qemuu-rhel6hvm-amd 12 redhat-install fail in 174646 pass in 174665 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 174646 pass in 174665 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 174646 pass in 174665 test-armhf-armhf-libvirt-qcow2 13 guest-start fail in 174646 pass in 174665 test-armhf-armhf-xl-credit1 14 guest-start fail in 174660 pass in 174665 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 174646 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 174660 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux a0d9384967214783a92973c920092b7251c03e57 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 10 days Failing since 174575 2022-11-01 18:42:39 Z 6 days 13 attempts Testing same since 174608 2022-11-03 19:46:50 Z 4 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anssi Hannula Arnaldo Carvalho de Melo Biju Das Brian Foster Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Darrick J. Wong Darrick J. Wong Dave Chinner David S. Miller Demi Marie Obenour Dongliang Mu Eric Dumazet Florian Fainelli Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hannu Hartikainen Hans Verkuil Heiko Carstens Helge Deller Hyong Youb Kim Hyunwoo Kim Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jeff Vanhoof Jens Glathe Jimmy Assarsson Johan Hovold Jon Hunter Jon Maloy Jonathan Cameron Josh Poimboeuf Juergen Gross Justin Chen Konrad Jankowski Kuogee Hsieh Leon Romanovsky Linux Kernel Functional Testing Luiz Capitulino M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Michal Jaron Mike Kravetz Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Paolo Abeni Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rik van Riel Saeed Mahameed Sakari Ailus Sasha Levin Shreeya Patel Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Thinh Nguyen Tom Lendacky Tony O'Brien Ulf Hansson Vasily Gorbik Vineet Gupta Vladimir Oltean Wei Yongjun Xin Long Yang Yingliang Yongqin Liu Zhang Changzhong Zhengchao Shao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2244 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:34:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:34:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440120.694192 (Exim 4.92) (envelope-from ) id 1osQcd-0001wz-1u; Tue, 08 Nov 2022 15:34:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440120.694192; Tue, 08 Nov 2022 15:34:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcc-0001wo-S4; Tue, 08 Nov 2022 15:34:42 +0000 Received: by outflank-mailman (input) for mailman id 440120; Tue, 08 Nov 2022 15:34:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcb-0001RY-Im for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:34:41 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db8e61fb-5f7a-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:34:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db8e61fb-5f7a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921679; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pDZRvWvsQxrzElkdZ92H76eH11jyJymBHtOb1jyOElc=; b=AwzhyVmwrh+xJ/s558SZMuTamdfqoH3pR+82m5jC4nGvwqjb0eRP6EYy atPRCUxlWLMXmcjMjAkkzOWgK+eYdmMZVkhnSm1G4j2AiA//AkkTmqwuK 3wqFBS+AxK1Kd4B22/LefVuSztHqoNpxUPccLec4z/SRmO09auQkj/ZiP E=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84828530 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:N9NzlqhGNLRZr61w5N2t2kM2X161bBAKZh0ujC45NGQN5FlHY01je htvWTqFMvyOamX3c91yb97j8U8F68XUytFgQAZrqilhQiIb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QeOzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tRDAy8IVQGCwNu147SRV+x2n545d5HkadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglHyfyNZrhSJorAw4EDYzRBr0airO93QEjCPbZUJzhzI+ zmel4j/Khc4LvjDyxeHzlCHhbD2szj6Q6wCLqLto5aGh3XMnzdOWXX6T2CTrfCnh2akVtlYK khS/TAhxYAt8GS7Q9+7WAe3yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebRwn0 EWY2ezgAzNHuaeQD3ma89+pQSiaYHZPazVYPGldEFVDs4KLTJwPYgznFf18FZWkj5rMGhL26 S2PtjFkne5Lgptev0mkxmzvjzWpr5nPawc64ATLQ26ohj9EiJ6Zi5+AsgaCs6sZRGqNZhzY5 SVfxZDChAwbJcvV/BFhVtnhC11ACxytFDTHyWBiEJA6n9hG0y7yJNsAiN2SyaoADyrlRdMLS BWN0e+yzMUJVJdPUUOQS9PZNijS5fK8fekJr9iNBjeOC7AoHON9wAlgZFSLw0fmm1U2nKc0N P+zKJjyUiZGV/0/lGDoF4/xNIPHIQhnmwvuqW3TlUz7gdJymlbJIVv6DLd+Rr9gt/7VyOkk2 91eK9GL231ivB7WO0HqHE96BQ5iEEXX8riv+pEILLXYelo/cIzjYteIqY4cl0Vet/w9vo/1E ruVASe0FHKXaaX7FDi3 IronPort-HdrOrdr: A9a23:hPv71KumwRaMD36XMnDJhnwK7skDTNV00zEX/kB9WHVpmszxra GTdZMgpGfJYVcqKQgdcL+7Scq9qB/nmqKdpLNhWYtKPzOW3ldATrsSj7cKqgeIc0aVm4JgPO VbAs9D4bXLfCNHZK3BgDVQfexP/DD+ytHMudvj X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84828530" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 04/15] tools/ocaml/xenstored/Makefile: use ocamldep -sort for linking order Date: Tue, 8 Nov 2022 15:33:56 +0000 Message-ID: <2acb17a3046dad442ef0e14c84c7aa5930e69e93.1667920496.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit A better solution is being worked on for master, but for now use ocamldep -sort instead of a manually established link order. The manually established link order will be wrong when (security) patches introduce new dependencies between files that would require changing the link order. If dune was used as a build system this wouldn't be a problem, but we can't use Dune yet due to OSSTest, which is stuck on Debian oldstable. No functional change. Signed-off-by: Edwin Török --- Reason for inclusion in 4.17: Avoids having to put this patch as a prerequisite into a security update. Earlier versions of XSA-326 needed this, and although latest version didn't we don't know whether it might be needed again in the future or not. Changes since v2: - new in v3 (was previously emailed to security team though) --- tools/ocaml/xenstored/Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/ocaml/xenstored/Makefile b/tools/ocaml/xenstored/Makefile index 6f7333926e..e8aaecf2e6 100644 --- a/tools/ocaml/xenstored/Makefile +++ b/tools/ocaml/xenstored/Makefile @@ -72,7 +72,11 @@ XENSTOREDLIBS = \ PROGRAMS = oxenstored oxenstored_LIBS = $(XENSTOREDLIBS) -oxenstored_OBJS = $(OBJS) +# use ocamldep to figure out link order, otherwise the Makefile would have +# to be continously adjusted for security patches that introduce new +# dependencies between files +oxenstored_MLSORTED = $(shell $(OCAMLDEP) -sort $(OBJS:=.ml)) +oxenstored_OBJS = $(oxenstored_MLSORTED:.ml=) OCAML_PROGRAM = oxenstored -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:34:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:34:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440121.694202 (Exim 4.92) (envelope-from ) id 1osQce-0002Cs-7C; Tue, 08 Nov 2022 15:34:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440121.694202; Tue, 08 Nov 2022 15:34:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQce-0002Ch-4N; Tue, 08 Nov 2022 15:34:44 +0000 Received: by outflank-mailman (input) for mailman id 440121; Tue, 08 Nov 2022 15:34:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcc-0001RY-J7 for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:34:42 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id daa98f32-5f7a-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:34:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: daa98f32-5f7a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921679; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rQjCOry0zbEmn2oC12Zes+ysVPjXqsmur55tzbE8yXw=; b=YRfbrNHcw+YM8eG8ORyAI8w5qtpFTzyBl5mgX1XZIa0mue6NUQAKTIZ1 OcPfeE247AlKxiDQ/vMms8lCKg7Gh5SLUMj63KbYNfh8qw9kqwT/kWvhb LKrciB92PQOc16SyiTPU8I4M8gSEbh0E57cBGYiwvv0Aux1Vx5B90XiW6 w=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 83996668 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:CHeWQq3HnZYAnLfe4/bD5d9xkn2cJEfYwER7XKvMYLTBsI5bpz1Vy 2JJUWDVOPjZMWDzeNhxaoi+909VvpGDzYI3GVY/pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVmNagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfBFlU3 /BIDDA3RTOSmv3r8pK+Fc8viZF2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKkSbC/FMEg5/5JYWkeu2h3+5bzpCr1G9rqsr+WnDigd21dABNfKFIY3bG5sLzi50o EqZ/Tn5IDsgF+Wc7meO81+ng7HktgT0Ddd6+LqQqacx3Qz7KnYoIBEfS1aTu/SyjU+6HdVFJ CQ85S4GvaU0skuxQbHVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQGucksVHoV3 1mGt9rzAHpkt7j9dJ6G3u7K93XoY3FTdDJcI39fJecY3zX9iIQLlDjDHvJjKoWWn8DqRAPQx m+s7ydr0t3/kvU3/6m8+FnGhRelqZ7IUhM5623rY4610u9qTNX7PtL1sDA3+d4Fdd/EFQfZ4 BDojuDEtIgz4YexeDthqQnnNJWg/L67PTLVmjaD9LFxpm32qxZPkW29iQySxXuF0O5eJ1cFg 2eJ42u9AaO/21P7BZKbm6rrV6wXIVHITLwIlpn8N7KimKRZeg6d5z1JbkWNxW3rm0VEufhhZ 8jLLZj1VS5AV/QPIN+KqwA1iOFD+8zD7TmLGcCTI+qPjdJym0J5uZ9aaQDTP4jVHYuPoRnP8 sY3Cid540w3bQA/CwGJmbMuwacidClmWsqt8JQHL4Zu4GNOQQkcNhMY+pt5E6QNokifvr6gE q2VMqOA9GfCuA== IronPort-HdrOrdr: A9a23:9j1UrKpBo47eN31NWZln3Y0aV5oReYIsimQD101hICG8cqSj9v xG+85rrSMc6QxhIU3I9urwW5VoLUmyyXcx2/h0AV7AZniBhILLFvAB0WKK+VSJcEeSmtK1l5 0QFJSWYOeAdmSS5vyb3ODXKbgdKaG8gcWVuds= X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="83996668" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 01/15] tools/ocaml/libs/eventchn: do not leak event channels and OCaml 5.0 compat Date: Tue, 8 Nov 2022 15:33:53 +0000 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Add a finalizer on the event channel value, so that it calls `xenevtchn_close` when the value would be GCed. In practice oxenstored seems to be the only user of this, and it creates a single global event channel only, but freeing this could still be useful when run with OCAMLRUNPARAM=c The code was previously casting a C pointer to an OCaml value, which should be avoided: OCaml 5.0 won't support it. (all "naked" C pointers must be wrapped inside an OCaml value, either an Abstract tag, or Nativeint, see the manual https://ocaml.org/manual/intfc.html#ss:c-outside-head) Signed-off-by: Edwin Török Acked-by: Christian Lindig --- Reason for inclusion in 4.17: - Fixes a runtime bug with upcoming OCaml 5.0 (already in beta) Changes since v2: - added Acked-by line - add 4.17 reason --- tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 29 +++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c index f889a7a2e4..67af116377 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c +++ b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c @@ -33,7 +33,30 @@ #include #include -#define _H(__h) ((xenevtchn_handle *)(__h)) +/* We want to close the event channel when it is no longer in use, + which can only be done safely with a finalizer. + Event channels are typically long lived, so we don't need tighter control over resource deallocation. + Use a custom block +*/ + +/* Access the xenevtchn_t* part of the OCaml custom block */ +#define _H(__h) (*((xenevtchn_handle**)Data_custom_val(__h))) + +static void stub_evtchn_finalize(value v) +{ + /* docs say to not use any CAMLparam* macros here */ + xenevtchn_close(_H(v)); +} + +static struct custom_operations xenevtchn_ops = { + "xenevtchn", + stub_evtchn_finalize, + custom_compare_default, /* raises Failure, cannot compare */ + custom_hash_default, /* ignored */ + custom_serialize_default, /* raises Failure, can't serialize */ + custom_deserialize_default, /* raises Failure, can't deserialize */ + custom_compare_ext_default /* raises Failure */ +}; CAMLprim value stub_eventchn_init(void) { @@ -48,7 +71,9 @@ CAMLprim value stub_eventchn_init(void) if (xce == NULL) caml_failwith("open failed"); - result = (value)xce; + /* contains file descriptors, trigger full GC at least every 128 allocations */ + result = caml_alloc_custom(&xenevtchn_ops, sizeof(xce), 0, 1); + _H(result) = xce; CAMLreturn(result); } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:34:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:34:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440118.694169 (Exim 4.92) (envelope-from ) id 1osQcb-0001Rq-7w; Tue, 08 Nov 2022 15:34:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440118.694169; Tue, 08 Nov 2022 15:34:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcb-0001Rj-4i; Tue, 08 Nov 2022 15:34:41 +0000 Received: by outflank-mailman (input) for mailman id 440118; Tue, 08 Nov 2022 15:34:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcZ-0001RY-RG for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:34:39 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d97f9394-5f7a-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:34:38 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d97f9394-5f7a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921678; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fcGVjUlcEVSXL3s0Xxex/3prCjVc7v5RHdmr3hXRWPM=; b=X20A+Z8UbcnnlgUnC8rSSi2+HFCrDg/bKckj02rB2ImH+OI1yDy+n4rN ePSr9G5W/DAFu+VYWEkSdJCGhPT2rBwqHorYsv1+3+6In48nnpaMiT2NH xrk8eLpZGT+OBNF4IKB9khC9XjbFV/Dqwy3ibpVs3mXrfQn71bFM99oZ5 c=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84828529 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:LztBQa6viFvAWBW3r8pWsAxRtDTHchMFZxGqfqrLsTDasY5as4F+v jQcW2iFOKyMYGv3L48ibIu19hkC6JWHx4cyQAY+rSwzHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkT7AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mr tcHLQscb1e6hMGw6q++UPA2nJ97I5y+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJU0UUrsUIMtWcOOAi3XhcjsetFWPoqkf6GnP1g1hlrPqNbI5f/TaGZUPzhvC9 woq+Uz2Iy8jDM6YwgC5rCO3q8+fpSj3SLk7QejQGvlC3wTImz175ActfUS/iem0jAi5Qd03A 1wZ/G8ioLY/8GSvT8LhRFuorXicpBkeVtFMVeog52ml6qfS+RffOWECQRZIctlgv8gzLRQm3 0GEt8nkDjtutPuSU331y1uPhWrsY25PdzZEPHJaC1teizX+nG0tpknkUdNYAa/yt97WHxvtx iqT9jJl37pG2KbnyJ6H1VzAhjutoL3AQQg0+hjbUwqZ0+9pWGK2T9f2sAaGtJ6sOK7cFwDc5 yZcx6By+chUVfmweDqxrPLh9V1Dz9KMK3XijFFmBPHNHBz9qif4Lei8DNyTTXqF0/romxezP ic/WisLvve/2UdGiocmC79d8+xwkcDd+S3ND5g5rrNmO/CdjjOv8iB0flK31GvwikUqmqxXE c7FL5n8UShDUfw9kmreqwIhPVgDn35W+I8ubcqjk0TPPUS2OBZ5tovpwHPRN7tkvctoUS3e8 spFNtvi9vmseLSWX8QWmKZNRW03wY8TXMGr9JYMLbbTe2KL2ggJUpfs/F/oQKQ994w9qwsC1 irVtpNwoLYnuUD6FA== IronPort-HdrOrdr: A9a23:0TZpM63zPs9sUgU7U5WuoQqjBIokLtp133Aq2lEZdPRUGvb3qy nIpoVj6faUskd2ZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ uIG5IOcOEYZmIasS+V2maF+q4bsbu6zJw= X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84828529" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 06/15] tools/ocaml/Makefile.rules: hide -include on *clean Date: Tue, 8 Nov 2022 15:33:58 +0000 Message-ID: <2a584406ee8cc1fce5175ad04feee6fdb18b6844.1667920496.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Fixes: 2f2b76d47c5bcd9 ("tools/ocaml: do not run ocamldep during make clean") Signed-off-by: Edwin Török --- Reason for inclusion in 4.17: - addresses review comments received post commit Changes since v2: - add Fixes line - add 4.17 reason --- tools/ocaml/Makefile.rules | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/Makefile.rules b/tools/ocaml/Makefile.rules index e0b9de34e4..39ac260a4d 100644 --- a/tools/ocaml/Makefile.rules +++ b/tools/ocaml/Makefile.rules @@ -44,10 +44,8 @@ META: META.in ALL_OCAML_OBJ_SOURCES=$(addsuffix .ml, $(ALL_OCAML_OBJS)) -ifeq (,$(findstring clean,$(MAKECMDGOALS))) .ocamldep.make: $(ALL_OCAML_OBJ_SOURCES) Makefile $(OCAML_TOPLEVEL)/Makefile.rules $(call quiet-command, $(OCAMLDEP) $(ALL_OCAML_OBJ_SOURCES) *.mli $o,MLDEP,) -endif clean: $(CLEAN_HOOKS) $(Q)rm -f .*.d *.o *.so *.a *.cmo *.cmi *.cma *.cmx *.cmxa *.annot *.spot *.spit $(LIBS) $(PROGRAMS) $(GENERATED_FILES) .ocamldep.make META @@ -94,7 +92,9 @@ define C_PROGRAM_template $(call quiet-command, $(CC) $(LDFLAGS) -o $$@ $$+,BIN,$$@) endef +ifeq (,$(findstring clean,$(MAKECMDGOALS))) -include .ocamldep.make +endif $(foreach lib,$(OCAML_LIBRARY),$(eval $(call OCAML_LIBRARY_template,$(lib)))) $(foreach lib,$(OCAML_NOC_LIBRARY),$(eval $(call OCAML_NOC_LIBRARY_template,$(lib)))) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:34:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:34:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440122.694213 (Exim 4.92) (envelope-from ) id 1osQcg-0002VX-GO; Tue, 08 Nov 2022 15:34:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440122.694213; Tue, 08 Nov 2022 15:34:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcg-0002V0-CC; Tue, 08 Nov 2022 15:34:46 +0000 Received: by outflank-mailman (input) for mailman id 440122; Tue, 08 Nov 2022 15:34:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQce-0001RY-Mn for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:34:44 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ddb18ef8-5f7a-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:34:43 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ddb18ef8-5f7a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921683; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=DOGFJCdrDDATd+X1NcZtCSbYvFjIMcP3itquODoYrYY=; b=FAt7iuunw/9dFQatGT7lDnBV0uqh+tnTIYZouh4k0f1g0invcaZ4f4CK VJexcNNLjcc88oULPo+iuvf0kFCvdstZCm2PQtJpYcxUuXmLkw4cz9QEq YiRE+OwUqu8Wh2t1Ng7Ogdf1mCBZE55ezWeLOamrSWBXRXY9KshH5qGwt A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 83996681 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:YsiNjaoJwYcjGQZpZfOl8OB5F2NeBmIUZRIvgKrLsJaIsI4StFCzt garIBnSaPjYYWP2ctwkPd/n8koF6pbUzIVgSgJt+yA1EyoVopuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzylNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABkrbzSoi/yN+q2cZcpy2sJ+N5DgJIxK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFHU/rSn8/x7pX7WzBUtlOT47Yw+W/Q5AdwzKLsIJzefdniqcB9zh3J9 zyYrz2R7hcyKoa86QHVzEuVhczyjwDxaL8JEv6m36s/6LGU7jNKU0BHPbehmtG1g1Czc8hSI EsV/mwpt6da3FOvZsnwWVu/unHslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC9 lKPhcKvOjVpv5WcU3fb/bCRxQ5eIgBMczVEP3VdC1JYvZ+z++nfky4jUP5KNq+RpdHrIgvv5 B+psnQ42q5KhtYEgvDTEU/8vxqgoZ3ATwgQ7wrRX3644g4RWLNJd7BE+nCAs68ecd/xok2p+ SFdxpPAtLxm4YSlznTlfQkbIF2+Cx9p2hX4iEUnIZQu/i/FF5WLLdEJu2EWyKuE3685ld7Vj K374105CHx7ZiHCgUpLj2WZWqwXIVDIT4iNaxwtRoMmj1gYXFbvENtSTUCRxXvxt0MnjLsyP 5yWGe71UyhFWfg5lWLuHblNuVPO+szZ7TqNLa0XMjz9iebODJJrYett3KSyghARs/rf/VS9H yd3PMqW0RRPONASkQGOmbP+7DkicxAGOHwBg5UGK7HZeVE+SDhJ5j246epJRrGJVp99zo/gl kxRkGcDoLYjrRUr8Tm3V00= IronPort-HdrOrdr: A9a23:xhcxfK0Q5yoo+c3/taXBPwqjBLwkLtp133Aq2lEZdPRUGvb4qy nIpoV86faUskd3ZJhOo6HiBEDtexzhHP1OkO0s1NWZLWvbUQKTRekIh+aP/9SJIVyGygc378 ddmsZFZuEYdWIK6PrH3A== X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="83996681" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 00/15] OCaml fixes for Xen 4.17 Date: Tue, 8 Nov 2022 15:33:52 +0000 Message-ID: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit These are the patches that I have outstanding for Xen 4.17. I have included a reason why I'm requesting them to be included in 4.17 after the --- line in each individual patch, see also a summary below. For convenience the patches are also available in a git repo: ``` git remote add edwintorok https://github.com/edwintorok/xen.git git fetch edwintorok private/edvint/for-4.17 git log -p origin/master..private/edvint/for-4.17 ``` And viewable with a browser too: https://github.com/edwintorok/xen/compare/private/edvint/for-4.17 * 3 patches related to OCaml 5 support https://patchwork.kernel.org/project/xen-devel/list/?series=680975 These have already been posted to the list previously, but not yet committed to master (I probably didn't use the correct subject and CC line for patches meant for 4.17, I think I've fixed that now) * Makefile.rules followup Also part of https://patchwork.kernel.org/project/xen-devel/list/?series=680975 these address some review feedback that I received after patches got committed * oxenstored live update bugfixes Testing of oxenstored live update has revealed some bugs (some of which got discovered on the C side too and fixed during one of the previous XSAs, but unfortunately none of that discussion is public, and we've ended up rediscovering the issue in the OCaml implementation too, which reminded me of the XSA discussions at the time). This brings the OCaml live update handling of event channels closer to the C xenstored version. It also fixes a few more bugs regarding logging and exception handling during live update, and during out of memory situations (theoretical now after XSA-326 fix). * a bugfix for a xenctrl binding Xen returns uninitialized data as part of a paging op domctl when a domain is dying. Workaround in the C stub by always initializing the domctl arguments to detect this. Xen fix in hypervisor side will be done separately, but even then having this is useful defensive coding. This is a 9 year old bug that still happens today, I've encountered it while testing this very series, hence the inclusion here. I expect most of these to be straight forward bugfixes, the only one slightly controversial might be the indentation one: changing tabs to spaces to match Xen coding style. I was unsure whether to include it here, but I think it is best to have it in 4.17 to simplify future (security) backports from master to 4.17, and avoid having to deal with whitespace issues all the time when writing patches. The code here used a style that was different from Xen's, and also different from every other piece of code that I work on, and OCaml indentation tools also only support spaces, not tabs, so there really is no reason to keep the code as is (initially I thought it uses tabs to follow Xen style, but after reading CODING_STYLE I realized that is not true). It is very easy to verify that the patch changes nothing with `git diff -w`, or `git log -p -1`. Edwin Török (15): tools/ocaml/libs/eventchn: do not leak event channels and OCaml 5.0 compat tools/ocaml/libs/xc: OCaml 5.0 compatibility tools/ocaml/libs/{xb, mmap}: use Data_abstract_val wrapper tools/ocaml/xenstored/Makefile: use ocamldep -sort for linking order tools/ocaml/Makefile.rules: do not run ocamldep on distclean tools/ocaml/Makefile.rules: hide -include on *clean CODING_STYLE(tools/ocaml): add 'make format' and remove tabs tools/ocaml/libs/evtchn: add xenevtchn_fdopen bindings tools/ocaml/xenstored/store.ml: fix build error tools/ocaml/xenstored: keep eventchn FD open across live update tools/ocaml/xenstored: do not rebind event channels after live update tools/ocaml/xenstored: log live update issues at warning level tools/ocaml/xenstored: set uncaught exception handler tools/ocaml/xenstored/syslog_stubs.c: avoid potential NULL dereference tools/ocaml/libs/xc: fix use of uninitialized memory in shadow_allocation_get tools/ocaml/Makefile | 5 + tools/ocaml/Makefile.rules | 4 +- tools/ocaml/libs/eventchn/xeneventchn.ml | 11 +- tools/ocaml/libs/eventchn/xeneventchn.mli | 14 +- tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 199 +- tools/ocaml/libs/mmap/mmap_stubs.h | 9 +- tools/ocaml/libs/mmap/xenmmap.ml | 2 +- tools/ocaml/libs/mmap/xenmmap.mli | 4 +- tools/ocaml/libs/mmap/xenmmap_stubs.c | 114 +- tools/ocaml/libs/xb/op.ml | 76 +- tools/ocaml/libs/xb/packet.ml | 30 +- tools/ocaml/libs/xb/partial.ml | 48 +- tools/ocaml/libs/xb/xb.ml | 422 ++-- tools/ocaml/libs/xb/xb.mli | 106 +- tools/ocaml/libs/xb/xenbus_stubs.c | 50 +- tools/ocaml/libs/xb/xs_ring.ml | 28 +- tools/ocaml/libs/xb/xs_ring_stubs.c | 216 +- tools/ocaml/libs/xc/abi-check | 2 +- tools/ocaml/libs/xc/xenctrl.ml | 330 +-- tools/ocaml/libs/xc/xenctrl.mli | 12 +- tools/ocaml/libs/xc/xenctrl_stubs.c | 1428 ++++++------ tools/ocaml/libs/xentoollog/caml_xentoollog.h | 6 +- .../ocaml/libs/xentoollog/xentoollog_stubs.c | 196 +- tools/ocaml/libs/xl/xenlight_stubs.c | 2022 ++++++++--------- tools/ocaml/libs/xs/queueop.ml | 48 +- tools/ocaml/libs/xs/xs.ml | 220 +- tools/ocaml/libs/xs/xs.mli | 46 +- tools/ocaml/libs/xs/xsraw.ml | 300 +-- tools/ocaml/libs/xs/xst.ml | 76 +- tools/ocaml/libs/xs/xst.mli | 20 +- tools/ocaml/test/dmesg.ml | 26 +- tools/ocaml/test/list_domains.ml | 4 +- tools/ocaml/test/raise_exception.ml | 4 +- tools/ocaml/test/xtl.ml | 28 +- tools/ocaml/xenstored/Makefile | 6 +- tools/ocaml/xenstored/config.ml | 156 +- tools/ocaml/xenstored/connection.ml | 594 ++--- tools/ocaml/xenstored/connections.ml | 304 +-- tools/ocaml/xenstored/define.ml | 6 +- tools/ocaml/xenstored/disk.ml | 218 +- tools/ocaml/xenstored/domain.ml | 104 +- tools/ocaml/xenstored/domains.ml | 320 +-- tools/ocaml/xenstored/event.ml | 12 +- tools/ocaml/xenstored/history.ml | 62 +- tools/ocaml/xenstored/logging.ml | 467 ++-- tools/ocaml/xenstored/packet.ml | 20 +- tools/ocaml/xenstored/parse_arg.ml | 106 +- tools/ocaml/xenstored/perms.ml | 216 +- tools/ocaml/xenstored/poll.ml | 68 +- tools/ocaml/xenstored/poll.mli | 4 +- tools/ocaml/xenstored/process.ml | 1212 +++++----- tools/ocaml/xenstored/quota.ml | 74 +- tools/ocaml/xenstored/select_stubs.c | 62 +- tools/ocaml/xenstored/stdext.ml | 190 +- tools/ocaml/xenstored/store.ml | 752 +++--- tools/ocaml/xenstored/symbol.ml | 2 +- tools/ocaml/xenstored/syslog.ml | 48 +- tools/ocaml/xenstored/syslog_stubs.c | 33 +- tools/ocaml/xenstored/systemd_stubs.c | 10 +- tools/ocaml/xenstored/transaction.ml | 352 +-- tools/ocaml/xenstored/trie.ml | 222 +- tools/ocaml/xenstored/trie.mli | 22 +- tools/ocaml/xenstored/utils.ml | 146 +- tools/ocaml/xenstored/xenstored.ml | 1051 ++++----- 64 files changed, 6557 insertions(+), 6388 deletions(-) base-commit: e61a78981364925a43c9cc24dc77b62ff7b93c9f -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:34:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:34:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440119.694175 (Exim 4.92) (envelope-from ) id 1osQcb-0001aL-My; Tue, 08 Nov 2022 15:34:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440119.694175; Tue, 08 Nov 2022 15:34:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcb-0001Zh-J7; Tue, 08 Nov 2022 15:34:41 +0000 Received: by outflank-mailman (input) for mailman id 440119; Tue, 08 Nov 2022 15:34:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQca-0001RY-IV for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:34:40 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id da2c792b-5f7a-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:34:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da2c792b-5f7a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921678; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=g06Eyz8tqCWbarSPvXlT2vv3bAoXEM2vFz5TwhOXiT8=; b=V6rsC8faRbzMWxDU4t08CXyvH+xfOY7TZgrdBaGzP88HjR+SDjBDZm3g GVC3gXjiy96p/coA4+sIIx2YTdk2xfo97jT32lYbgV3X6h4BQYTC8ywc6 ArhZrsgenBrzueWFKFfaBSBw1CtMVbsGBP7/LbH+zV0olfzWVFPgiIvNv 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 83477663 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:MuhKVqrukL7MHgKzhD7rzePyu/NeBmIUZRIvgKrLsJaIsI4StFCzt garIBmAb/uLYjChf4pyYIy+/B4D7cfdmIUxHAE5rig8RS1DpJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzylNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABEcfjatmtOT+rnhcuJh3poZLPbVGYxK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFHU/rSn8/x7pX7WzBUtlOT47Yw+W/Q5AdwzKLsIJzefdniqcB9zh3E+ T2YoT+R7hcyM9C25RjC/lWXxerVsC34fqxCP5vo6as/6LGU7jNKU0BHPbehmtGmjmauVtQZL FYbkgI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8yyaUAHIVCAFIbtMOvdUzAzct0 zehk9r3CBR1vbaSSHbb8a2bxQ5eIgBMczVEP3VdC1JYvZ+z++nfky4jUP5CAb6ToMDEPAv7m QiBoXBgvbUss+sEgvDTEU/8vxqgoZ3ATwgQ7wrRX3644g4RWLNJd7BE+nCAs68ecd/xok2p+ SFdxpPAtLxm4YSlznTlfQkbIF2+Cx9p2hX4iEUnIZQu/i/FF5WLLdEJu2EWyKuE3685ld7Vj K374105CHx7ZiHCgUpLj2WZWqwXIVDIT4iNaxwtRoMmj1gYXFbvENtSTUCRxXvxt0MnjLsyP 5yWGe71UyhFWfg5lWLuHblNuVPO+szZ7TqNLa0XMjz9iebODJJrYett3KSyghARs/rf/VS9H yd3PMqW0RRPONASkQGOmbP+7DkicxAGOHwBg5UGK7HZeVE+SDhJ5j246epJRrGJVp99zo/gl kxRkGcCoLYjrRUr8Tm3V00= IronPort-HdrOrdr: A9a23:D8IkaqhnYTzWd6p5H/GM+qTIpHBQXuIji2hC6mlwRA09TySZ// rBoB19726MtN9xYgBHpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5 0QF5SWYOeAdWSS5vya3ODXKbkdKaG8gcKVuds= X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="83477663" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 03/15] tools/ocaml/libs/{xb, mmap}: use Data_abstract_val wrapper Date: Tue, 8 Nov 2022 15:33:55 +0000 Message-ID: <6d9e337ef6bfd7540ae5a0d6b4b1b73fd5e84b16.1667920496.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This is not strictly necessary since it is essentially a no-op currently: a cast to void* and value*, even in OCaml 5.0. However it does make it clearer that what we have here is not a regular OCaml value, but one allocated with Abstract_tag or Custom_tag, and follows the example from the manual more closely: https://v2.ocaml.org/manual/intfc.html#ss:c-outside-head It also makes it clearer that these modules have been reviewed for compat with OCaml 5.0. No functional change. Signed-off-by: Edwin Török Acked-by: Christian Lindig --- Reason for inclusion in 4.17: - make code follow best practice for upcoming OCaml 5.0 compiler (already in beta) Changes since v2: - add Acked-by line --- tools/ocaml/libs/mmap/xenmmap_stubs.c | 2 +- tools/ocaml/libs/xb/xs_ring_stubs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/libs/mmap/xenmmap_stubs.c b/tools/ocaml/libs/mmap/xenmmap_stubs.c index e2ce088e25..141dedb78c 100644 --- a/tools/ocaml/libs/mmap/xenmmap_stubs.c +++ b/tools/ocaml/libs/mmap/xenmmap_stubs.c @@ -28,7 +28,7 @@ #include #include -#define Intf_val(a) ((struct mmap_interface *) a) +#define Intf_val(a) ((struct mmap_interface *) Data_abstract_val(a)) static int mmap_interface_init(struct mmap_interface *intf, int fd, int pflag, int mflag, diff --git a/tools/ocaml/libs/xb/xs_ring_stubs.c b/tools/ocaml/libs/xb/xs_ring_stubs.c index 7a91fdee75..cc9114029f 100644 --- a/tools/ocaml/libs/xb/xs_ring_stubs.c +++ b/tools/ocaml/libs/xb/xs_ring_stubs.c @@ -35,7 +35,7 @@ #include #include "mmap_stubs.h" -#define GET_C_STRUCT(a) ((struct mmap_interface *) a) +#define GET_C_STRUCT(a) ((struct mmap_interface *) Data_abstract_val(a)) /* * Bytes_val has been introduced by Ocaml 4.06.1. So define our own version -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:34:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:34:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440123.694218 (Exim 4.92) (envelope-from ) id 1osQch-0002ae-2G; Tue, 08 Nov 2022 15:34:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440123.694218; Tue, 08 Nov 2022 15:34:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcg-0002Z6-Pr; Tue, 08 Nov 2022 15:34:46 +0000 Received: by outflank-mailman (input) for mailman id 440123; Tue, 08 Nov 2022 15:34:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcf-0001RY-DW for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:34:45 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id de6dd23c-5f7a-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:34:44 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de6dd23c-5f7a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921684; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=hFwOQ0qz0r8WVELNrCnoJk/t1j0zykfo+WnLiqOMwyw=; b=Klv7V+3Qx1XW93rPVSgJcUaA/Xe61wt0hWQx9Q/r3aX4oYHUle/odHJb pMYtfKjIsXIPtI5niHf5Oiug7UA29hUXm1ilFln2HCMDBUfMJ/F/uePxG qMpSYVT45XWHZcQmpI7MnAxSEKT10WNG1JwcaouU+MdV3WnhjMbSTFYl0 Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84828538 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:6JTXyKJ3uP2D3kF3FE+R3ZUlxSXFcZb7ZxGr2PjKsXjdYENSgTBSz TEdUG+Oa62IM2qgfdglPd++8xsAu5+Dn4BkHQZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wRuPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4qMFpn/ 9YhJQkPVR6c2L+Jmp6cG9Nz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLozkPmpgD/jdCdfq3qepLYt4niVxwt0uFToGIqJKobaGJ4F9qqej iXv03mmLEgcD8KS72a361n1utDKmgquDer+E5Xnr6U30TV/3Fc7Fxk+RVa95/6jhSaWS99Zb kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8Ua5QeX2+zr6gCWLmEeS3hKb9lOnMM/WzECz FKCmNLtQzt1v9WopWm1r+nO62noYG5McDFENXRsoRY5D8fL/bAIpxjld9taEpW7kYKoJmvc5 GGws31r71kMtvIj26K+9FHBpjujoJnVUwI4jjnqsnKZAhBRP9D8OdHxgbTPxbMZddvCEAHd1 JQRs5LGhN3iG61hg8BkrA8lOLiyr8iIPzTH6bKEN8lwrm/9k5JPkG053d2fGKuLGpxaEdMKS BWJ0e+02HO0FCrCUEOPS9jtY/nGNIC5fTklP9iNBja0XrB/dRWc4AZlblOK0mbmnSAEyP9hZ sfHL5/0VSxEWcyLKQZaoM9Ej9cWKt0WnzuPFfgXMTz7uVZhWJJlYehcawbfBgzIxKiFvB/U4 75i2ziikn1ivSyXSne/zLP/2nhTfCVkX8ut85wOHgNBSyI/cFwc5zbq6etJU+RYc259zI8kI lnVtpdk9WfC IronPort-HdrOrdr: A9a23:fp48/6sAKgVmYzN+f0e2iV/A7skDTtV00zEX/kB9WHVpmszxra 6TdZMgpGbJYVcqKRcdcL+7WJVoLUmxyXcx2/h1AV7AZniAhILLFvAA0WKK+VSJcEeSygce79 YFT0EXMqyJMbEQt6fHCWeDfOrIuOP3kpyVuQ== X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84828538" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 05/15] tools/ocaml/Makefile.rules: do not run ocamldep on distclean Date: Tue, 8 Nov 2022 15:33:57 +0000 Message-ID: <62e88f2badd7bb3cfb709254258dc6af40c87a45.1667920496.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Fixes: 2f2b76d47c5bcd9 ("tools/ocaml: do not run ocamldep during make clean") Signed-off-by: Edwin Török --- Reason for inclusion in 4.17: - addresses review comments received post commit Changes since v2: - add Fixes line - add 4.17 reason --- tools/ocaml/Makefile.rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/ocaml/Makefile.rules b/tools/ocaml/Makefile.rules index 0d3c6ac839..e0b9de34e4 100644 --- a/tools/ocaml/Makefile.rules +++ b/tools/ocaml/Makefile.rules @@ -44,7 +44,7 @@ META: META.in ALL_OCAML_OBJ_SOURCES=$(addsuffix .ml, $(ALL_OCAML_OBJS)) -ifneq ($(MAKECMDGOALS),clean) +ifeq (,$(findstring clean,$(MAKECMDGOALS))) .ocamldep.make: $(ALL_OCAML_OBJ_SOURCES) Makefile $(OCAML_TOPLEVEL)/Makefile.rules $(call quiet-command, $(OCAMLDEP) $(ALL_OCAML_OBJ_SOURCES) *.mli $o,MLDEP,) endif -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:34:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:34:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440124.694223 (Exim 4.92) (envelope-from ) id 1osQch-0002hS-EC; Tue, 08 Nov 2022 15:34:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440124.694223; Tue, 08 Nov 2022 15:34:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQch-0002gc-8p; Tue, 08 Nov 2022 15:34:47 +0000 Received: by outflank-mailman (input) for mailman id 440124; Tue, 08 Nov 2022 15:34:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcf-0001RY-UK for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:34:45 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dea3d7d7-5f7a-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:34:44 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dea3d7d7-5f7a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921684; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=15Hgb+sdjhnccr4MqijiUOJ5Qs+Ch7oxO+EvADCJqio=; b=WRHD33tLaxdZpcMyw14p5Y07FIyljOBgqRa+zRGCsf5WGPeYiVR3OxiY J0LxnKadRNLGztmi9VCKkD3djdr2mTQLk1173EALzs2comeZh4y5Gx5wi fq+OhBRpZAvSDVx8fkzJsjvJsNodUG70b9c5qG+0RacwmPYgt9XwUANPZ M=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 83996682 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:mkHlkaMkoFRuu6PvrR2pl8FynXyQoLVcMsEvi/4bfWQNrUoj0mBRz GsXCDuHM/6OYDejc493b4i09h4C7J+BzN5nSAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5gxmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0s9RAEVl+ eIjEi8qQTOd2+Tr2+uwUuY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w/N3wsYDUWUrsTIJ8yguauwGX4aTpbgFmUubA28y7YywkZPL3FYIGEK4LUFZ89ckCwp HDeoG6oEw0mE92t5DuZ9Wy3h9HRtHauMG4VPOLhraM76LGJ/UQMDDUGWF39puO24mauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O8037hucjJXd5QmxD3IBCDVGbbQOuMYoSBQw2 1SOntevAiZg2IB5UlrEqO3S92nrf3FIcylSPkfoUDfp/fHKhoAXpR7Rdex8N4GWkIHzRCqpy CiF+X1Wa6ooseYH0KCy/Fbiij2qp4TUQgNd2jg7Tl5J/SsiOtf7OtXABUzzqK8Zcd3HFgXpU G0swZD20QwYMX2aeMVhqs0pFarh2fuKOSa0bbVHT8h4rGTFF5JOkOltDNBCyKVBaJhsldzBO hW7VeZtCHh7bROXgVdfOd7ZNijT5fGI+BSMfqm8giBySpZwbhSb2ypleFSd2Wvg+GB1z/9ga cvFKJ70VyhKYUiC8NZRb75DuYLHOwhknT+DLXwF50jPPUWiiI69Fu5ebQrmghER56KYugTFm +uzxOPToyiykYTWPEHqzGLkBQlbcCdhXsuu+5U/myzqClMOJVzNwsT5mdsJE7GJVYwO/gsU1 hlRgnNl9Wc= IronPort-HdrOrdr: A9a23:4uIkDaiJIUIvYGmCAsI09W+H7XBQXuIji2hC6mlwRA09TySZ// rBoB19726MtN9xYgBHpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5 0QF5SWYOeAdWSS5vya3ODXKbkdKaG8gcKVuds= X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="83996682" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 02/15] tools/ocaml/libs/xc: OCaml 5.0 compatibility Date: Tue, 8 Nov 2022 15:33:54 +0000 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Follow the manual to avoid naked pointers: https://v2.ocaml.org/manual/intfc.html#ss:c-outside-head No functional change, except on OCaml 5.0 where it is a bugfix. Signed-off-by: Edwin Török Acked-by: Christian Lindig --- Reason for inclusion in 4.17: - bugfix for upcoming OCaml 5.0 compiler (already in beta) Changes since v2: - add Acked-by line --- tools/ocaml/libs/mmap/mmap_stubs.h | 5 +++++ tools/ocaml/libs/xc/xenctrl_stubs.c | 11 ++++++----- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/tools/ocaml/libs/mmap/mmap_stubs.h b/tools/ocaml/libs/mmap/mmap_stubs.h index 65e4239890..5c65cc86fb 100644 --- a/tools/ocaml/libs/mmap/mmap_stubs.h +++ b/tools/ocaml/libs/mmap/mmap_stubs.h @@ -30,4 +30,9 @@ struct mmap_interface int len; }; +/* for compatibility with OCaml 4.02.3 */ +#ifndef Data_abstract_val +#define Data_abstract_val(v) ((void*) Op_val(v)) +#endif + #endif diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index a8789d19be..8cd11060ec 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -37,7 +37,7 @@ #include "mmap_stubs.h" -#define _H(__h) ((xc_interface *)(__h)) +#define _H(__h) *((xc_interface **) Data_abstract_val(__h)) #define _D(__d) ((uint32_t)Int_val(__d)) #ifndef Val_none @@ -70,14 +70,15 @@ static void Noreturn failwith_xc(xc_interface *xch) CAMLprim value stub_xc_interface_open(void) { CAMLparam0(); - xc_interface *xch; + CAMLlocal1(result); + result = caml_alloc(1, Abstract_tag); /* Don't assert XC_OPENFLAG_NON_REENTRANT because these bindings * do not prevent re-entrancy to libxc */ - xch = xc_interface_open(NULL, NULL, 0); - if (xch == NULL) + _H(result) = xc_interface_open(NULL, NULL, 0); + if (_H(result) == NULL) failwith_xc(NULL); - CAMLreturn((value)xch); + CAMLreturn(result); } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:34:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:34:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440125.694246 (Exim 4.92) (envelope-from ) id 1osQcm-0003Tk-UK; Tue, 08 Nov 2022 15:34:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440125.694246; Tue, 08 Nov 2022 15:34:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcm-0003TY-Ql; Tue, 08 Nov 2022 15:34:52 +0000 Received: by outflank-mailman (input) for mailman id 440125; Tue, 08 Nov 2022 15:34:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcl-0003Q1-Gs for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:34:51 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0a8562e-5f7a-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 16:34:49 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0a8562e-5f7a-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921689; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MEdqPuuz28JG9GUY0dslF3e+ZAUQoxJNc/yTLkjgR6E=; b=Rfne7eT985xPq10+c1Qb7a3QG19ihq9dOcXIFChprs6W5jgvv8ljqePs TLAqbi54kvfgxJBQAMew6zVTYLPNVwW95AEWg0rOX4clrrOpg7+DMZ5vV EYBi5zV/3T1voRSwmyumoim4IUrad/bEPV9PybeIPo+0/2PPtju3cVyMs 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84398280 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:vKRODK1dnOG9ENnkuPbD5d9xkn2cJEfYwER7XKvMYLTBsI5bpz0Bz TFMXjyBa/3ZYjP9fY8iOt+woEsHu8XUy9YyHVRvpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVmNagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfWzpM/ uUfCGk3SR252O+3/aCcd/JIr5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKkSbC/FMEg5/5JYWkeu2h3+5bzpCr1G9rqsr+WnDigd21dABNfKFJofbFZ8Fxi50o Erm2nrDBjghEOCTiiOK6lj0q9XWxyP0Ddd6+LqQqacx3Qz7KnYoIBEfS1aTu/SyjU+6HdVFJ CQ85S4GvaU0skuxQbHVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQGucksVHoV3 1mGt9rzAHpkt7j9dJ6G3u7K93XoY3FTdDJcI39fJecY3zX9iNtojBnWSfY6Kom4tIL4GAzi5 A2RiAFr0t3/kvU3/6m8+FnGhRelqZ7IUhM5623rY4610u9qTNX7PtL1sDA3+d4Fdd/EFQfZ4 BDojuDEtIgz4YexeDthqQnnNJWg/L67PTLVmjaD9LFxpm32qxZPkW29iQySxXuF0O5eJ1cFg 2eJ42u9AaO/21P7BZKbm6rrV6wXIVHITLwIlpn8N7KimKRZeg6d5z1JbkWNxW3rm0VEufhhZ 8jLLZj1VS5AV/QPIN+KqwA1iOFD+8zD7TmLGcCTI+qPjdJym0J5uZ9aaQDTP4jVHYuPoRnP8 sY3Cid540w3bQA/CwGJmbMuwacidClmWsqt8JQHL4Zu4GNOQQkcNhMY+pt5E6QNokifvr2gE q2VMqOA9GfCuA== IronPort-HdrOrdr: A9a23:KH2ZaqiFfTwXU2d031bvkwKXM3BQXuIji2hC6mlwRA09TySZ// rBoB19726MtN9xYgBHpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5 0QF5SWYOeAdWSS5vya3ODXKbkdKaG8gcKVuds= X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84398280" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error Date: Tue, 8 Nov 2022 15:34:01 +0000 Message-ID: <09afc07ba0ba65afc02028bd6b4950d8e51af69b.1667920496.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Building with Dune in release mode fails with: ``` File "ocaml/xenstored/store.ml", line 464, characters 13-32: Warning 18: this type-based record disambiguation is not principal. File "ocaml/xenstored/store.ml", line 1: Error: Some fatal warnings were triggered (1 occurrences) ``` This is a warning to help keep the code futureproof, quoting from its documentation: > Check information path during type-checking, to make sure that all types are > derived in a principal way. When using labelled arguments and/or polymorphic > methods, this flag is required to ensure future versions of the compiler will > be able to infer types correctly, even if internal algorithms change. All > programs accepted in -principal mode are also accepted in the default mode with > equivalent types, but different binary signatures, and this may slow down type > checking; yet it is a good idea to use it once before publishing source code. Fixes: db471408edd46 "tools/ocaml/xenstored: Fix quota bypass on domain shutdown" Signed-off-by: Edwin Török --- Reason for inclusion in 4.17: - fixes a build error in a previous commit that is already in master Changes since v2: - new in v3 --- tools/ocaml/xenstored/store.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/ocaml/xenstored/store.ml b/tools/ocaml/xenstored/store.ml index 14ec404988..38a4945372 100644 --- a/tools/ocaml/xenstored/store.ml +++ b/tools/ocaml/xenstored/store.ml @@ -461,7 +461,7 @@ let reset_permissions store domid = | Some perms -> if perms <> node.perms then Logging.debug "store|node" "Changed permissions for node %s" (Node.get_name node); - Some { node with perms } + Some { node with Node.perms } ) store.root type ops = { -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:34:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:34:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440126.694252 (Exim 4.92) (envelope-from ) id 1osQcn-0003Yw-GV; Tue, 08 Nov 2022 15:34:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440126.694252; Tue, 08 Nov 2022 15:34:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcn-0003Xi-8e; Tue, 08 Nov 2022 15:34:53 +0000 Received: by outflank-mailman (input) for mailman id 440126; Tue, 08 Nov 2022 15:34:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcl-0001RY-Gs for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:34:51 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e0ef84aa-5f7a-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:34:49 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0ef84aa-5f7a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921689; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8ZXiX9ItGs2cbrZyrTgiP7zufiQzcqMjhU4Bz6aA7bo=; b=QCdChhoGm43hsmE+1+edlUuHhyNoKL7Rgghp7jpV/rATFoOk4ckvePYu j/unOBHLxXr/ghnpIGfOggmcS4yATolVulgSSn7URVVn+ASJCeZyGs5RR 9X37WRB1dsz6feCU76wItMEcuU247pmf0pU0s2ml7RUIE0ZFB8st28F9O s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84416530 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:QJrAg68xziy/qLbiSl7tDrUDjH6TJUtcMsCJ2f8bNWPcYEJGY0x3y mtKWG6HPa6KajCjeYx0PYq28E5X6pWDytdrS1Nuq388E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKgb5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklRq dkbdBsWfiu8iuSU7p2nUPs1uO08eZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGM0Yn1lQ/UfrSmM+limf+dXtEr0iSpoI84nTJzRw327/oWDbQUozWGZwLwx3Az o7A12vHJD8/bP+89WuMzVaLhM/KpXzxZJ1HQdVU8dY12QbOlwT/EiY+Sl+TsfS/zEmkVLp3O 0ESvyYjs6U23EiqVcXmGQ21pmaeuRwRUMYWFPc1gCmtx6zO8kCmD24LZjdbbZots8pebTAjy FKhhd7iAj1r9rqPRhqgGqy89G3of3JPdClbOHFCHVBtD8TfTJ8bkU7qTYpIC76OsdDzOx/f3 yqY9RYXmOBG5SIU7JmT8VfCijOqg5HGSA8p+wnaNl6YAhNFiJ2NPNLxtwWChRpUBMPAFwTa4 iBY8ySLxLpWZaxhghBhVwnk8FuBw/+eeAPRjld0d3XK32T8oiXzFWy8DdwXGauIDirmUWW3C KMwkVkLjHO2AJdNRf4fXm5JI552pZUM7Py8Ph0UB/IXCnSLSCeJ/Tt1eWmb1H33nU4nnMkXY MnFLpbwUy9CUf45nFJaotvxNpdymEgDKZ77H8inn3xLL5LCDJJqdVv1GATXNb1ohE91iA7U7 8xeJ6O3J+Z3CYXDj+i+2dB7EG3m2lBiVM2p8ZcMLr7aSuekcUl4Y8LsLXoaU9QNt8xoei3gp xlRhmcwJILDuED6 IronPort-HdrOrdr: A9a23:H+TIP6HUiUxyFGElpLqE0MeALOsnbusQ8zAXP0AYc3Jom6uj5r mTdZUgpHnJYVkqOE3I9ertBEDEewK4yXcX2/h3AV7BZniEhILAFugLhuGO/9SjIVybygc079 YZT0EUMrzN5DZB4voSmDPIceod/A== X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84416530" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 08/15] tools/ocaml/libs/evtchn: add xenevtchn_fdopen bindings Date: Tue, 8 Nov 2022 15:34:00 +0000 Message-ID: <3e7f15778ffb5d5d7adde8567c4d50197607f7b2.1667920496.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Signed-off-by: Edwin Török --- Reason for inclusion in 4.17: - needed for a bugfix in a followup commit Changes since v2: - new in v3 --- tools/ocaml/libs/eventchn/xeneventchn.ml | 6 +++- tools/ocaml/libs/eventchn/xeneventchn.mli | 9 +++++- tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 28 +++++++++++++++++-- 3 files changed, 38 insertions(+), 5 deletions(-) diff --git a/tools/ocaml/libs/eventchn/xeneventchn.ml b/tools/ocaml/libs/eventchn/xeneventchn.ml index dd00a1f0ea..34f7391f5e 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn.ml +++ b/tools/ocaml/libs/eventchn/xeneventchn.ml @@ -16,7 +16,11 @@ type handle -external init: unit -> handle = "stub_eventchn_init" +external init_cloexec: bool -> handle = "stub_eventchn_init" + +let init ?(cloexec=true) () = init_cloexec cloexec + +external fdopen: Unix.file_descr -> handle = "stub_eventchn_fdopen" external fd: handle -> Unix.file_descr = "stub_eventchn_fd" type t = int diff --git a/tools/ocaml/libs/eventchn/xeneventchn.mli b/tools/ocaml/libs/eventchn/xeneventchn.mli index 08c7337643..3965b29621 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn.mli +++ b/tools/ocaml/libs/eventchn/xeneventchn.mli @@ -43,7 +43,14 @@ val to_int: t -> int val of_int: int -> t -val init: unit -> handle +val init: ?cloexec:bool -> unit -> handle +(** [init ?cloexec ()] + Return an initialised event channel interface. + The default is to close the underlying file descriptor + on [execve], which can be overriden with [~cloexec:false]. + On error it will throw a Failure exception. *) + +val fdopen: Unix.file_descr -> handle (** Return an initialised event channel interface. On error it will throw a Failure exception. *) diff --git a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c index 2263c4caa1..92092ca31e 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c +++ b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c @@ -58,14 +58,36 @@ static struct custom_operations xenevtchn_ops = { custom_compare_ext_default /* raises Failure */ }; -CAMLprim value stub_eventchn_init(void) +CAMLprim value stub_eventchn_init(value cloexec) { - CAMLparam0(); + CAMLparam1(cloexec); CAMLlocal1(result); xenevtchn_handle *xce; caml_enter_blocking_section(); - xce = xenevtchn_open(NULL, 0); + xce = xenevtchn_open(NULL, Bool_val(cloexec) ? 0 : XENEVTCHN_NO_CLOEXEC); + caml_leave_blocking_section(); + + if ( xce == NULL ) + caml_failwith("open failed"); + + /* contains file descriptors, trigger full GC at least every 128 + * allocations + */ + result = caml_alloc_custom(&xenevtchn_ops, sizeof(xce), 0, 1); + _H(result) = xce; + CAMLreturn(result); +} + +CAMLprim value stub_eventchn_fdopen(value fdval) +{ + CAMLparam1(fdval); + CAMLlocal1(result); + xenevtchn_handle *xce; + + caml_enter_blocking_section(); + /* having any flags here would raise EINVAL */ + xce = xenevtchn_fdopen(NULL, Int_val(fdval), 0); caml_leave_blocking_section(); if (xce == NULL) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:39:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:39:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440161.694268 (Exim 4.92) (envelope-from ) id 1osQhN-0006zR-BE; Tue, 08 Nov 2022 15:39:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440161.694268; Tue, 08 Nov 2022 15:39:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQhN-0006zK-8X; Tue, 08 Nov 2022 15:39:37 +0000 Received: by outflank-mailman (input) for mailman id 440161; Tue, 08 Nov 2022 15:39:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQhM-0006zE-C1 for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:39:36 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8a6a5574-5f7b-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 16:39:34 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a6a5574-5f7b-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921974; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8ePR03hmluMvOGGTEiWLD/HCh/fqyWBWHQzlfAz9mW4=; b=Qlcd397j3Ty8M+5IqATEqYp0rPtYrPoe8MZJdlElZuxS230FIAnLReTo 7gnD4aujZiNUxzGJqFa5hD5B8NOQ5OP/Msg5IZ9sz0K6Mo3Q9N4KCL6qu IDsbV4q1NkwnOvte+7GEdvwT87lZhkznBURNu6M5YlfoVbKuY/sCNMB3d 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84417005 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:9knbNquqGW13lrMKgnEn17uSP+fnVFpeMUV32f8akzHdYApBsoF/q tZmKTvUM/3YNGvwcox3bYq+8UkFsMPTzN5lTwVkqS01FCwT+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaGxyFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwEyoUQQijp8uMmpmhU9lzl50hI/KzI9ZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfAdMYH49tL7Aan3XfjFGqVTTua0t5Gv7xw1tyrn9dtHSf7RmQO0FwhrB+ TqeogwVBDk+LdbAkhSP8UiNxcbQwHnpBIUwLLqBo6sCbFq7mTVIVUx+uUGAiea9ol6zXZRYM UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL8wwufHHlCcTdHZ/QvrspwTjsvv neFls3kLSZiu7qUTTSa7Lj8kN+pEXFLdylYP3ZCFFZbpYm4yG0usv7RZu15CYGtrv3cI2vb2 Sm6szlnhboo1dFegs1X4mv7qz6ro5HISCs86QPWQn+p42tFWWK1W2C7wQOFtKgdde51WnHE5 SFZwJbGsIjiGLnXzESwrPMx8KZFDhpvGBnVmhZREpYo7FxBEFbzLNkLsFmSyKqEW/vomAMFg meJ52u9B7cJZhNGiJObhKrgY/nGNYC6SbzYugn8N7KjovFZLWdrBh1Ga0+KxHzKm0Mxi6w5M przWZ/yUylKVfo+lGLsGbd1PVoXKscWnD27eHwG507/jer2iIC9Fd/pz2dinshmtfjZ8W05A v5UNteQygU3bQENSnC/zGPSRHhURUUG6Wfe8p0KKbTYeVI2QQnMyZb5mNscRmCspIwN/s+gw 513chMwJIbX7ZEfFTi3Vw== IronPort-HdrOrdr: A9a23:wVwiwa5FANW47TynjwPXwPDXdLJyesId70hD6qhwISY6TiX+rb HWoB17726TtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ 0QC5SWY+eQMbEVt6nHCXGDYrQd/OU= X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84417005" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 15/15] tools/ocaml/libs/xc: fix use of uninitialized memory in shadow_allocation_get Date: Tue, 8 Nov 2022 15:34:07 +0000 Message-ID: <94f93ee61a4d0bd2fac3f5a753cb935962be20bb.1667920496.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit It has been noticed in 2013 that shadow allocation sometimes returns the wrong value, which got worked around by adding a limit to the shadow multiplier of 1000 and ignoring the value from Xen in that case to avoid a shadow multiplier causing a VM to request 6PB of memory for example: https://github.com/xapi-project/xen-api/pull/1215/commits/be55a8c30b41d1cd7596fc100ab1cfd3539f74eb However that is just a workaround, and I've just reproduced this by killing a VM mid migration, which resulted in a shadow multiplier of 629.42, rendering the VM unbootable even after a host reboot. The real bug is in Xen: when a VM is dying it will return '0' for paging op domctls and log a message at info level 'Ignoring paging op on dying domain', which leaves the 'mb' parameter uninitialized upon return from the domctl. The binding also doesn't initialize the 'c->mb' parameter (it is meant to be used only when setting, not when querying the allocation), which results in the VM getting a shadow allocation (and thus multiplier) set based on what value happened to be currently on the stack. Explicitly initialize the value passed to the domctl, and detect the uninitialized case (shadow allocation of 0), and raise an exception in that case. The exception will cause xenopsd to skip setting the shadow multiplier. Note that the behaviour of Xen here is inconsistent between x86 and ARM: ARM would return EINVAL when it gets a paging op on a dying domain, and X86-64 would return 0 with possibly uninitialized data. It might be desirable to change the x86 path in the hypervisor to return EINVAL, although that would require more testing in case it breaks somethig. But the bindings should be defensive anyway against bugs like this. Signed-off-by: Edwin Török --- Reason for inclusion in 4.17: - fixes a long-standing (>9y old) bug that is still happening today Changes since v2: - new in v3 --- tools/ocaml/libs/xc/xenctrl_stubs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index e2d897581f..9681a74e40 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -1019,7 +1019,7 @@ CAMLprim value stub_shadow_allocation_get(value xch, value domid) { CAMLparam2(xch, domid); CAMLlocal1(mb); - unsigned int c_mb; + unsigned int c_mb = 0; int ret; caml_enter_blocking_section(); @@ -1029,6 +1029,9 @@ CAMLprim value stub_shadow_allocation_get(value xch, value domid) caml_leave_blocking_section(); if (ret != 0) failwith_xc(_H(xch)); + if ( !c_mb ) + caml_failwith("domctl returned uninitialized data for shadow " + "allocation, dying domain?"); mb = Val_int(c_mb); CAMLreturn(mb); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:39:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:39:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440162.694279 (Exim 4.92) (envelope-from ) id 1osQhR-0007Gu-M6; Tue, 08 Nov 2022 15:39:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440162.694279; Tue, 08 Nov 2022 15:39:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQhR-0007Gn-JC; Tue, 08 Nov 2022 15:39:41 +0000 Received: by outflank-mailman (input) for mailman id 440162; Tue, 08 Nov 2022 15:39:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQhQ-0007Fx-Dg for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:39:40 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8d4e3290-5f7b-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:39:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d4e3290-5f7b-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921978; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=hQno2BG9QzWV381/kBdkjocEF/Hky2yAxo4hwyxhbW8=; b=JiG3Z1Flq52+kfeCl1udaItI2Lijp/awhDhrsN6iQfsZ03wLHs/mvsYi EupEGgSRKMiz/iMr9hCRP9AUFTQtRQPGVgp/ZYMmEYJ1ExLlJN3+HgUd6 LaMY4hw8vVArcV2hipHLPuLMOeTTdqWeGp/kM1nR3v/n5Awb8Ohm1b6sr c=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 83478170 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:sesTT64v/yz9bk3iZOQfzgxRtDTHchMFZxGqfqrLsTDasY5as4F+v mdLUTrQOPyMN2LxKI1+bIiwp0sE6p6Byd8ySQZkpSo8Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkT7AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5my NY0JmA3NBO5nvuRw7eZQcMxhZhkBZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJU0UUrsUIMtWcOOAi3XhcjsetFWPoqkf6GnP1g1hlrPqNbI5f/TaHpkKzh/H/ goq+Uz5KUsVaeetywGl0W3zmebPmwrqd40rQejQGvlC3wTImz175ActfVeyv/SRkEO1XNNbb UsO9UIGsqwa5EGtCN7nUHWQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OcWSDowx xm2ltXmLTV1tfueTnf1y1uPhWrsY25PdzZEPHJaC1teizX+nG0tpi/lYtgzKvS2tMTsPjL14 Tug8StiwJxG2KbnyJ6H1VzAhjutoL3AQQg0+hjbUwqZ0+9pWGK2T9f2sAaGtJ6sOK7cFwDc5 yZcx6By+chUVfmweDqxrPLh9V1Dz9KMK3XijFFmBPHNHBz9qif4Lei8DNyTTXqF0/romxezP ic/WisLvve/2UdGiocmC79d8+xwkcDd+S3ND5g5rrNmO/CdjjOv8iB0flK31GvwikUqmqxXE c7FL5n8UShDUfw9kmreqwIhPVgDn35W+I8ubcqjk0TPPUS2OBZ5tovpwHPRN7tkvctoUS3e8 spFNtvi9vmseLSWX8QWmKZNRW03wY8TXMGr9JYMLbbTe2KL2ggJUpfs/F/oQKQ994w9qwsC1 ijVtpNwoLYnuUD6FA== IronPort-HdrOrdr: A9a23:aepYbK7oWaexfs/5UgPXwPLXdLJyesId70hD6qhwISY1TiX+rb HXoB17726MtN9/YgBCpTntAsa9qDbnhPpICOoqTNGftWvdyQmVxehZhOOIqVCNJ8S9zJ876U 4JSdkENDSaNzhHZKjBjjVQa+xQpeW6zA== X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="83478170" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 13/15] tools/ocaml/xenstored: set uncaught exception handler Date: Tue, 8 Nov 2022 15:34:05 +0000 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Helps debug fatal errors during live update Previously this would've just gone to /dev/null, because: * daemonize reopens stderr as /dev/null * systemd redirects stderr to /dev/null too Previously the only way to debug this was to manually run oxenstored with --no-fork, but when you have a fatal error and oxenstored just disappears you'd want to know why. There has been at least one observed instance of a bug where oxenstored just disappeared inexplicably (it was believed due to an OOM exception). Signed-off-by: Edwin Török --- Reason for inclusion in 4.17: - avoids losing crucial information during a fatal error (e.g. during live update) Changes since v2: - new in v3 --- tools/ocaml/xenstored/logging.ml | 33 ++++++++++++++++++++++++++++++ tools/ocaml/xenstored/xenstored.ml | 3 ++- 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/tools/ocaml/xenstored/logging.ml b/tools/ocaml/xenstored/logging.ml index 021ebc465b..cced038c48 100644 --- a/tools/ocaml/xenstored/logging.ml +++ b/tools/ocaml/xenstored/logging.ml @@ -342,3 +342,36 @@ let xb_answer ~tid ~con ~ty data = let watch_not_fired ~con perms path = let data = Printf.sprintf "EPERM perms=[%s] path=%s" perms path in access_logging ~tid:0 ~con ~data Watch_not_fired ~level:Info + +let print_flush msg = + prerr_endline msg; + flush stderr + +let msg_of exn bt = + Printf.sprintf "Fatal exception: %s\n%s\n" (Printexc.to_string exn) + (Printexc.raw_backtrace_to_string bt) + +let fallback_exception_handler exn bt = + (* stderr goes to /dev/null, so use the logger where possible, + but always print to stderr too, in case everything else fails, + e.g. this can be used to debug with --no-fork + + this function should try not to raise exceptions, but if it does + the ocaml runtime should still print the exception, both the original, + and the one from this function, but to stderr this time + *) + let msg = msg_of exn bt in + print_flush msg; + (* See Printexc.set_uncaught_exception_handler, need to flush, + so has to call stop and flush *) + match !xenstored_logger with + | Some l -> error "xenstored-fallback" "%s" msg; l.stop () + | None -> + (* Too early, no logger set yet. + We normally try to use the configured logger so we don't flood syslog + during development for example, or if the user has a file set + *) + try Syslog.log Syslog.Daemon Syslog.Err msg + with e -> + let bt = Printexc.get_raw_backtrace () in + print_flush @@ msg_of e bt diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml index 78177b116f..6828764f92 100644 --- a/tools/ocaml/xenstored/xenstored.ml +++ b/tools/ocaml/xenstored/xenstored.ml @@ -357,7 +357,8 @@ let tweak_gc () = Gc.set { (Gc.get ()) with Gc.max_overhead = !Define.gc_max_overhead } -let _ = +let () = + Printexc.set_uncaught_exception_handler Logging.fallback_exception_handler; let cf = do_argv in let pidfile = if Sys.file_exists (config_filename cf) then -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:39:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:39:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440163.694290 (Exim 4.92) (envelope-from ) id 1osQhS-0007Xr-VO; Tue, 08 Nov 2022 15:39:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440163.694290; Tue, 08 Nov 2022 15:39:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQhS-0007Xg-Rg; Tue, 08 Nov 2022 15:39:42 +0000 Received: by outflank-mailman (input) for mailman id 440163; Tue, 08 Nov 2022 15:39:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQhR-0007Fx-Kr for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:39:41 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8dd69aaf-5f7b-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:39:40 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8dd69aaf-5f7b-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921980; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MmumC61ho15DndrHDcqanqMqkMI1LHqlie4LwBB5is0=; b=EK2C/i+u0+btJIOV2JQqFc7r35+r3X58Hjvapob6+gGoQd6QkQxKAgJV /oWGOL7/HGt4Pcovpy2fTmj00ykH2Jf55PrF66F2MYAABS90KtAj4+SMf rSWT60/cCXg6C3BIfLlLT3tNcxypl80W7ZMBLXAA/1VfttjPOtYlpgb6i E=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84398664 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:tas1CaIGkPgQGR05FE+R3ZUlxSXFcZb7ZxGr2PjKsXjdYENShmEBy TRMDTrQP/3cZGr3ct5xPd7loB8OsJ+Am9RrTQBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wRuPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c52OWty9 +QELwwBbyvSi7yo75Cie+xj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLozkPmpgD/jdCdfq3qepLYt4niVxwt0uFToGIqJIY3aG5sJ9qqej jyYuHbTXy03DYa01SSq4G2mm92VpCyuDer+E5Xnr6U30TV/3Fc7BBQIWHOhrPK+i0r4XMhQQ 2QL/gI+oK5081akJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQPwrstUnAwMj0 FChlsnsQzdotdWopWm1r+nO62noYG5McDFENXRsoRY5D8fLobk5shDXUtFfHK+O39GrBx7S2 gGPo31r71kMtvIj26K+9FHBpjujoJnVUwI4jjnqsnKZAhBRP9D8OdHxgbTPxbMZddvCEAHd1 JQRs5LGhN3iG61hg8BkrA8lOLiyr8iIPzTH6bKEN8lwrm/9k5JPkG053d2fGKuLGpxaEdMKS BWJ0e+02HO0FCrCUEOPS9jtY/nGNIC5fTklP9iNBja0XrB/dRWc4AZlblOK0mbmnSAEyP9hZ sfHL5/0VSxEWcyLKQZaoM9Ej9cWKt0WnzuPFfgXMTz7uVZhWJJlYehcawbfBgzIxKiFvB/U4 75i2ziikn1ivSyXSne/zLP/2nhTfCVkX8ut85wOHgNBSyI/cFwc5zbq6etJU+RYc259zI8kI lnVtpdk9WfC IronPort-HdrOrdr: A9a23:6bKEcKqAQOq+VSc39qigHrIaV5oReYIsimQD101hICG8cqSj9v xG+85rrSMc6QxhIU3I9urwW5VoLUmyyXcx2/h0AV7AZniBhILLFvAB0WKK+VSJcEeSmtK1l5 0QFJSWYOeAdmSS5vyb3ODXKbgdKaG8gcWVuds= X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84398664" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 11/15] tools/ocaml/xenstored: do not rebind event channels after live update Date: Tue, 8 Nov 2022 15:34:03 +0000 Message-ID: <003537c5db4682b9a5f632d61cb15b332e0778bf.1667920496.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit See explanation in previous commit. This introduces a new field into the live update stream to retain both ports, and handles the missing value in a backward compatible way. Signed-off-by: Edwin Török --- Reason for inclusion 4.17: - fixes a bug in oxenstored live update, needed to make live updates with future 4.17 security fixes possible/more reliable Changes since v2: - new in v3 --- tools/ocaml/libs/eventchn/xeneventchn.ml | 5 +++++ tools/ocaml/libs/eventchn/xeneventchn.mli | 5 +++++ tools/ocaml/xenstored/domain.ml | 6 +++++- tools/ocaml/xenstored/domains.ml | 13 +++++++++---- tools/ocaml/xenstored/event.ml | 1 + tools/ocaml/xenstored/xenstored.ml | 11 +++++++---- 6 files changed, 32 insertions(+), 9 deletions(-) diff --git a/tools/ocaml/libs/eventchn/xeneventchn.ml b/tools/ocaml/libs/eventchn/xeneventchn.ml index 34f7391f5e..7ccf7a99f0 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn.ml +++ b/tools/ocaml/libs/eventchn/xeneventchn.ml @@ -43,6 +43,11 @@ type virq_t = external notify: handle -> int -> unit = "stub_eventchn_notify" external bind_interdomain: handle -> int -> int -> int = "stub_eventchn_bind_interdomain" + +let restore_interdomain handle _domid _remote_port local_port = + notify handle local_port; + local_port + external bind_virq: handle -> virq_t -> int = "stub_eventchn_bind_virq" let bind_dom_exc_virq handle = bind_virq handle Dom_exc external unbind: handle -> int -> unit = "stub_eventchn_unbind" diff --git a/tools/ocaml/libs/eventchn/xeneventchn.mli b/tools/ocaml/libs/eventchn/xeneventchn.mli index 3965b29621..7407031b9e 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn.mli +++ b/tools/ocaml/libs/eventchn/xeneventchn.mli @@ -68,6 +68,11 @@ val bind_interdomain : handle -> int -> int -> t channel connected to domid:remote_port. On error it will throw a Failure exception. *) +val restore_interdomain : handle -> int -> int -> int -> t +(** [restore_interdomain h domid remote_port local_port] returns a local event + channel connected to domid:remote_port. On error it will + throw a Failure exception. *) + val bind_dom_exc_virq : handle -> t (** Binds a local event channel to the VIRQ_DOM_EXC (domain exception VIRQ). On error it will throw a Failure diff --git a/tools/ocaml/xenstored/domain.ml b/tools/ocaml/xenstored/domain.ml index 4e62a48e8e..5dad298614 100644 --- a/tools/ocaml/xenstored/domain.ml +++ b/tools/ocaml/xenstored/domain.ml @@ -61,7 +61,7 @@ let string_of_port = function | Some x -> string_of_int (Xeneventchn.to_int x) let dump d chan = - fprintf chan "dom,%d,%nd,%d\n" d.id d.mfn d.remote_port + fprintf chan "dom,%d,%nd,%d,%s\n" d.id d.mfn d.remote_port (string_of_port d.port) let notify dom = match dom.port with | None -> @@ -77,6 +77,10 @@ let bind_interdomain dom = dom.port <- Some (Event.bind_interdomain dom.eventchn dom.id dom.remote_port); debug "bound domain %d remote port %d to local port %s" dom.id dom.remote_port (string_of_port dom.port) +let restore_interdomain dom localport = + assert (dom.port = None); + dom.port <- Some (Event.restore_interdomain dom.eventchn dom.id dom.remote_port localport); + debug "restored interdomain %d remote port %d to local port %s" dom.id dom.remote_port (string_of_port dom.port) let close dom = debug "domain %d unbound port %s" dom.id (string_of_port dom.port); diff --git a/tools/ocaml/xenstored/domains.ml b/tools/ocaml/xenstored/domains.ml index d5c452d26c..af9fecf2f7 100644 --- a/tools/ocaml/xenstored/domains.ml +++ b/tools/ocaml/xenstored/domains.ml @@ -123,17 +123,22 @@ let cleanup doms = let resume _doms _domid = () -let create doms domid mfn port = +let maybe_bind_interdomain restore_localport dom = + match restore_localport with + | None -> Domain.bind_interdomain dom + | Some p -> Domain.restore_interdomain dom p + +let create doms domid mfn ?restore_localport port = let interface = Xenctrl.map_foreign_range xc domid (Xenmmap.getpagesize()) mfn in let dom = Domain.make domid mfn port interface doms.eventchn in Hashtbl.add doms.table domid dom; - Domain.bind_interdomain dom; + maybe_bind_interdomain restore_localport dom; dom let xenstored_kva = ref "" let xenstored_port = ref "" -let create0 doms = +let create0 ?restore_localport doms = let port, interface = ( let port = Utils.read_file_single_integer !xenstored_port @@ -147,7 +152,7 @@ let create0 doms = in let dom = Domain.make 0 Nativeint.zero port interface doms.eventchn in Hashtbl.add doms.table 0 dom; - Domain.bind_interdomain dom; + maybe_bind_interdomain restore_localport dom; Domain.notify dom; dom diff --git a/tools/ocaml/xenstored/event.ml b/tools/ocaml/xenstored/event.ml index 190ca6fcbf..3debe8731d 100644 --- a/tools/ocaml/xenstored/event.ml +++ b/tools/ocaml/xenstored/event.ml @@ -29,6 +29,7 @@ let init ?fd () = let fd eventchn = Xeneventchn.fd eventchn.handle let bind_dom_exc_virq eventchn = eventchn.virq_port <- Some (Xeneventchn.bind_dom_exc_virq eventchn.handle) let bind_interdomain eventchn domid port = Xeneventchn.bind_interdomain eventchn.handle domid port +let restore_interdomain eventchn domid port local_port = Xeneventchn.restore_interdomain eventchn.handle domid port local_port let unbind eventchn port = Xeneventchn.unbind eventchn.handle port let notify eventchn port = Xeneventchn.notify eventchn.handle port let pending eventchn = Xeneventchn.pending eventchn.handle diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml index cdd5b5ac67..d4ff24b440 100644 --- a/tools/ocaml/xenstored/xenstored.ml +++ b/tools/ocaml/xenstored/xenstored.ml @@ -169,10 +169,13 @@ module DB = struct event_f ~eventfd | "socket" :: fd :: [] -> socket_f ~fd:(int_of_string fd) - | "dom" :: domid :: mfn :: port :: []-> + | "dom" :: domid :: mfn :: port :: rest -> domain_f (int_of_string domid) (Nativeint.of_string mfn) (int_of_string port) + (match rest with + | [] -> None (* backward compat: old version didn't have it *) + | localport :: _ -> Some (int_of_string localport)) | "watch" :: domid :: path :: token :: [] -> watch_f (int_of_string domid) (unhexify path) (unhexify token) @@ -232,13 +235,13 @@ module DB = struct else warn "Ignoring invalid socket FD %d" fd in - let domain_f domid mfn port = + let domain_f domid mfn port restore_localport = let doms = require_doms () in let ndom = if domid > 0 then - Domains.create doms domid mfn port + Domains.create doms domid mfn ?restore_localport port else - Domains.create0 doms + Domains.create0 ?restore_localport doms in Connections.add_domain cons ndom; in -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:39:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:39:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440165.694308 (Exim 4.92) (envelope-from ) id 1osQhZ-00080r-Lt; Tue, 08 Nov 2022 15:39:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440165.694308; Tue, 08 Nov 2022 15:39:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQhZ-000807-DL; Tue, 08 Nov 2022 15:39:49 +0000 Received: by outflank-mailman (input) for mailman id 440165; Tue, 08 Nov 2022 15:39:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQhY-0007Fx-FQ for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:39:48 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 93141a4b-5f7b-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:39:47 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93141a4b-5f7b-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921987; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xndQpxaUgOTkOg9lUcdLHyryykFdZHp3J5lKgw8D8NA=; b=e/dWQRTj0pAPwmOhf9yva6MXLJgkWhiKlrlZDDRxyEI6+KRi3uRI+OoN 0lw1KoBTrzUFdSb1X9A39IiwCgpp29WfvWNcuXhN2+XcUa18/dV2qZuMf H74++M+lEtrpqr7kXwYWsQMzLk3bLQN3dWM3cp5sISxxZ4F67jZODxoRr 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 86935398 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:jPjP+630aAVB3id3FPbD5d9xkn2cJEfYwER7XKvMYLTBsI5bp2AHx zEbXDuHOPzeamf9ftwnaoq0oxgGuZfRx9Q2TQs/pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVmNagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfK0VU5 943LhQ2bVOMqP6s/46dW+YyiZF2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKkSbC/FMEg5/5JYWkeu2h3+5bzpCr1G9rqsr+WnDigd21dABNfKFJI3RGJ4Ezi50o ErAp1/AHxsqL+am9iap6GmLv/bGuRL0Ddd6+LqQqacx3Qz7KnYoIAISfUu2p7++kEHWc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUSyAyL0LuS3A+fCUANVDsHY9sj3Oc6TCIn/ kWElNToAXpoqrL9dJ6G3u7K93XoY3FTdDJcI39fJecY3zX9iKsXlADtYdBHK632gfLpAw7M5 SGF8idr0t3/kvU3/6m8+FnGhRelqZ7IUhM5623rY4610u9qTNX7PtL1sDA3+d4Fdd/EFQfZ4 BDojuDEtIgz4YexeDthqQnnNJWg/L67PTLVmjaD9LFxpm32qxZPkW29iQySxXuF0O5eJ1cFg 2eJ42u9AaO/21P7BZKbm6rrV6wXIVHITLwIlpn8N7KimKRZeg6d5z1JbkWNxW3rm0VEufhhZ 8jLLZj1VS5AV/QPIN+KqwA1iOFD+8zD7TmLGcCTI+qPjdJym0J5uZ9aaQDTP4jVHYuPoRnP8 sY3Cid540w3bQA/CwGJmbMuwacidClmWsqt8JQHL4Zu4GNOQQkcNhMY+pt5E6QNokifvrygE q2VMqOA9GfCuA== IronPort-HdrOrdr: A9a23:r3pXR6C4zmoqEFXlHemU55DYdb4zR+YMi2TC1yhKJyC9Ffbo7v xG/c5rsyMc5wxwZJhNo7y90ey7MBbhHP1OkO4s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpN 9dmsNFaeEYY2IUsS+D2njbL+od X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="86935398" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 14/15] tools/ocaml/xenstored/syslog_stubs.c: avoid potential NULL dereference Date: Tue, 8 Nov 2022 15:34:06 +0000 Message-ID: <5da5b63bd6a0f8d0f6ad0281773eefb32de8164d.1667920496.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit If we are out of memory then strdup may return NULL, and passing NULL to syslog may cause a crash. Avoid this by using `caml_stat_strdup` which will raise an OCaml out of memory exception instead. This then needs to be paired with caml_stat_free. Signed-off-by: Edwin Török --- Reason for inclusion in 4.17: - fixes a bug in out of memory situations Changes since v2: - new in v3 --- tools/ocaml/xenstored/syslog_stubs.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/xenstored/syslog_stubs.c b/tools/ocaml/xenstored/syslog_stubs.c index 4e5e49b557..4ad85c8eb5 100644 --- a/tools/ocaml/xenstored/syslog_stubs.c +++ b/tools/ocaml/xenstored/syslog_stubs.c @@ -14,6 +14,7 @@ #include #include +#include #include #include #include @@ -35,14 +36,16 @@ static int __syslog_facility_table[] = { value stub_syslog(value facility, value level, value msg) { CAMLparam3(facility, level, msg); - const char *c_msg = strdup(String_val(msg)); + char *c_msg = strdup(String_val(msg)); int c_facility = __syslog_facility_table[Int_val(facility)] | __syslog_level_table[Int_val(level)]; + if ( !c_msg ) + caml_raise_out_of_memory(); caml_enter_blocking_section(); syslog(c_facility, "%s", c_msg); caml_leave_blocking_section(); - free((void*)c_msg); + free(c_msg); CAMLreturn(Val_unit); } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:39:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:39:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440164.694301 (Exim 4.92) (envelope-from ) id 1osQhZ-0007xM-7f; Tue, 08 Nov 2022 15:39:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440164.694301; Tue, 08 Nov 2022 15:39:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQhZ-0007x5-4Q; Tue, 08 Nov 2022 15:39:49 +0000 Received: by outflank-mailman (input) for mailman id 440164; Tue, 08 Nov 2022 15:39:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQhX-0007Fx-E5 for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:39:47 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 91702d13-5f7b-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:39:46 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91702d13-5f7b-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921986; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UQCDfSuDGc6oIDdjMFWDCU+FRf1yoH/+ae5j3IlKjWg=; b=cb4uysJXM8hmUWa/EZCf780aMSck0hGU4QeoO8cv1+/62sCKXtLILboG L6IYUWvFW5eWCa4DpClXvG6q/HKdqxesLJFiNGNT8PtdDWPjBFKbnPBOG ib7kPQHvHbGfPLtvjcX+zdnMrOlWdAEASbA8fa3XuC8/MfmDYCEZcfmMu 8=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 86935395 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:34ZUBK2BNTwjMjyOovbD5d9xkn2cJEfYwER7XKvMYLTBsI5bpz0Hz zMdXWqGMqvbamPweYp2bIrn/UpXvsfRzoBiTQtkpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVmNagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfPDpu0 dsbI2g3V1PS16W6n7XiDbFCiZF2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKkSbC/FMEg5/5JYWkeu2h3+5bzpCr1G9rqsr+WnDigd21dABNfKFJI3RGJ4Ewy50o ErIvF7/LR1BOeXYihTY23mM3N7tpDL0Ddd6+LqQqacx3Qz7KnYoIAISfUu2p7++kEHWc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUSyAyL0LuS3A+fCUANVDsHY9sj3Oc6TCIn/ kWElNToAXpoqrL9dJ6G3u7K93XoY3FTdDJcI39fJecY3zX9iLxorjboTd07Kpf2342yFW73m nfSgidr0t3/kvU3/6m8+FnGhRelqZ7IUhM5623rY4610u9qTNX7PtL1sDA3+d4Fdd/EFQfZ4 BDojuDEtIgz4YexeDthqQnnNJWg/L67PTLVmjaD9LFxpm32qxZPkW29iQySxXuF0O5eJ1cFg 2eJ42u9AaO/21P7BZKbm6rrV6wXIVHITLwIlpn8N7KimKRZeg6d5z1JbkWNxW3rm0VEufhhZ 8jLLZj1VS5AV/QPIN+KqwA1iOFD+8zD7TmLGcCTI+qPjdJym0J5uZ9aaQDTP4jVHYuPoRnP8 sY3Cid540w3bQA/CwGJmbMuwacidClmWsqt8JQHL4Zu4GNOQQkcNhMY+pt5E6QNokifvr2gE q2VMqOA9GfCuA== IronPort-HdrOrdr: A9a23:7SkhmKg8emYRfWRr/q9ESkII+nBQXgoji2hC6mlwRA09TyX4rb HMoB1173XJYVoqNU3I+urhBEDjex3hHPdOiOF7AV7FZmXbUQCTTb2KmrGSoQEIdReQysdtkY 99bqlzD8DxB1Bmgcu/3BO1CL8bsb66GGTCv5am85+rJjsaDZ1I3kNBBgiSLEtsRk1mDZ01EZ b03Lsjm9PaQwVyUviG X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="86935395" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 12/15] tools/ocaml/xenstored: log live update issues at warning level Date: Tue, 8 Nov 2022 15:34:04 +0000 Message-ID: <550a0bc27c19a6d64d43cdee1f8cc3230d6ff55e.1667920496.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit During live update oxenstored tries a best effort approach to recover as many domains and information as possible even if it encounters errors restoring some domains. This defensive approach has already proven useful to recover domains after a bug in oxenstored. However the default log level is warning, which means that problems during live update were not logged at all, unless you've changes oxenstored.conf prior to live-update. Signed-off-by: Edwin Török --- Reason for inclusion in 4.17: - makes live update issues debuggable (live update can be used to apply security updates to 4.17) Changes since v2: - new in v3 --- tools/ocaml/xenstored/xenstored.ml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml index d4ff24b440..78177b116f 100644 --- a/tools/ocaml/xenstored/xenstored.ml +++ b/tools/ocaml/xenstored/xenstored.ml @@ -184,9 +184,9 @@ module DB = struct (Perms.Node.of_string (unhexify perms ^ "\000")) (unhexify value) | _ -> - info "restoring: ignoring unknown line: %s" line + warn "restoring: ignoring unknown line: %s" line with exn -> - info "restoring: ignoring unknown line: %s (exception: %s)" + warn "restoring: ignoring unknown line: %s (exception: %s)" line (Printexc.to_string exn); () with End_of_file -> -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:39:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:39:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440166.694323 (Exim 4.92) (envelope-from ) id 1osQhb-000098-V1; Tue, 08 Nov 2022 15:39:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440166.694323; Tue, 08 Nov 2022 15:39:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQhb-00008s-Qs; Tue, 08 Nov 2022 15:39:51 +0000 Received: by outflank-mailman (input) for mailman id 440166; Tue, 08 Nov 2022 15:39:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQhZ-0007Fx-Tg for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:39:50 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 93b83a42-5f7b-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:39:48 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93b83a42-5f7b-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921988; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=buzE9ePYEDLC+F92TEeWnEnqUW11FTaxYumtDUDu/aE=; b=UYS14wTsgvW/RfheV6UQLyr3NozmQ6b2CO/VPrcR6eEoikZaK0nDs13+ cRpGSt5Fcrd6BK9L1jgWSL1oD7nQIVkqo7oOi9t/uSMKmiFntpa/6PZcy BJ3yCFOiF4ljbtN0PxS5/pWR0vROD326FmMPmjfDLJPZIN2givlltQXyl 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 86935397 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:ozS7OKi+0ZyiXbU8r9SIKVtVX161bBAKZh0ujC45NGQN5FlHY01je htvUTiAPKuCY2D3f94gYdmy90wBucfXndMxSFdqqC82Rigb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QeOzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQyDCofTD+Fo9m1g72UVvNTuuIyI5fkadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglHyfyNZrhSJorAw4EDYzRBr0airO93QEjCPbZULzx3F/ TOZl4j/KiEZa/zP+TC9yHm1rPXkvXnGRtMbG7Lto5aGh3XMnzdOWXX6T2CTrfCnh2akVtlYK khS/TAhxYAt8GS7Q9+7WAe3yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebRwn0 EWY2ezgAzNHuaeQD3ma89+pQSiaYHZPazVYPGldEFVDs4KLTJwPYgznZPJ5AoyaiPnOGnL/7 CyQkxQYlrpNgptev0mkxmzvjzWpr5nPawc64ATLQ26ohj9EiJ6Zi5+AsgaCs6sZRGqNZhzY5 SVfxZDChAwbJcvV/BFhVtnhC11ACxytFDTHyWBiEJA6n9hG0y7yJNsAiN2SyaoADyrlRdMLS BWN0e+yzMUJVJdPUUOQS9PZNijS5fK8fekJr9iNBjeOC7AoHON9wAlgZFSLw0fmm1U2nKc0N P+zKJjyUiZGV/0/lGDoF4/xNIPHIQhnmwvuqW3TlUz7gdJymlbJIVv6DLd+Rr9gt/7VyOkk2 91eK9GL231ivB7WO0HqHE96BQ5iEEXX8riv+pEILLXYelo/cIzjYteIqY4cl0Vet/w9vo/1E ruVASe0FHKXaaX7FDi3 IronPort-HdrOrdr: A9a23:LLMWWKp+zp4ZbGFS6aj+SJIaV5oReYIsimQD101hICG8cqSj9v xG+85rrSMc6QxhIU3I9urwW5VoLUmyyXcx2/h0AV7AZniBhILLFvAB0WKK+VSJcEeSmtK1l5 0QFJSWYOeAdmSS5vyb3ODXKbgdKaG8gcWVuds= X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="86935397" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 10/15] tools/ocaml/xenstored: keep eventchn FD open across live update Date: Tue, 8 Nov 2022 15:34:02 +0000 Message-ID: <17575704fceda409bd5bb0056a94664ddc3ac2e1.1667920496.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit It has been discovered that the Windows PV drivers rebind their local port of the xenstore evtchn post migrate, which changes the eventchn port from e.g. the default of 3 (nVCPUs+1) to 1 without oxenstored knowing about it. And oxenstored goes and tries to rebind port 3, which is already in use by something else. The guest also writes to HVMPARAM, however there is a race condition between it resetting the eventchn port and writing to HVMPARAM, thus it is not possible to atomically obtain the guest's eventchn port for xenstore. It is possible to recover such a guest manually from a failed live update by running introduceDomain from Dom0 with the correct port number obtain using 'xen-vmdebug hvmparam'. There is also a small race condition window between closing the evtchn FD and reopening it where guest drivers would get an unbound evtchn port error from Xen when trying to talk to xenstore during live update. Avoid this by trying to keep the eventchn file descriptor open across live updates, using the new xenevtchn_fdopen API, similar to how C xenstored works. However an old enough oxenstored won't have kept the evtchn fd open and won't have saved it in the update stream, so handle that case by reopening the evtchn as a fallback. A followup commit will avoid rebind the guest remote port (we cannot rely on the remote port staying the same, e.g. the windows PV drivers change it) Signed-off-by: Edwin Török --- Reason for inclusion in 4.17: - fixes live update in oxenstored, making future security updates easier if the base code already has this patch Changes since v2: - new in v3 --- tools/ocaml/xenstored/domains.ml | 1 + tools/ocaml/xenstored/event.ml | 7 ++- tools/ocaml/xenstored/xenstored.ml | 71 +++++++++++++++++++++--------- 3 files changed, 56 insertions(+), 23 deletions(-) diff --git a/tools/ocaml/xenstored/domains.ml b/tools/ocaml/xenstored/domains.ml index a36b531663..d5c452d26c 100644 --- a/tools/ocaml/xenstored/domains.ml +++ b/tools/ocaml/xenstored/domains.ml @@ -56,6 +56,7 @@ let exist doms id = Hashtbl.mem doms.table id let find doms id = Hashtbl.find doms.table id let number doms = Hashtbl.length doms.table let iter doms fct = Hashtbl.iter (fun _ b -> fct b) doms.table +let eventchn doms = doms.eventchn let rec is_empty_queue q = Queue.is_empty q || diff --git a/tools/ocaml/xenstored/event.ml b/tools/ocaml/xenstored/event.ml index b10027f004..190ca6fcbf 100644 --- a/tools/ocaml/xenstored/event.ml +++ b/tools/ocaml/xenstored/event.ml @@ -20,7 +20,12 @@ type t = { mutable virq_port: Xeneventchn.t option; } -let init () = { handle = Xeneventchn.init (); virq_port = None; } +let init ?fd () = + let handle = match fd with + | None -> Xeneventchn.init ~cloexec:false () + | Some fd -> Xeneventchn.fdopen fd + in + { handle; virq_port = None } let fd eventchn = Xeneventchn.fd eventchn.handle let bind_dom_exc_virq eventchn = eventchn.virq_port <- Some (Xeneventchn.bind_dom_exc_virq eventchn.handle) let bind_interdomain eventchn domid port = Xeneventchn.bind_interdomain eventchn.handle domid port diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml index 34612814e1..cdd5b5ac67 100644 --- a/tools/ocaml/xenstored/xenstored.ml +++ b/tools/ocaml/xenstored/xenstored.ml @@ -144,7 +144,7 @@ module DB = struct let dump_format_header = "$xenstored-dump-format" - let from_channel_f chan global_f socket_f domain_f watch_f store_f = + let from_channel_f chan global_f event_f socket_f domain_f watch_f store_f = let unhexify s = Utils.unhexify s in let getpath s = let u = Utils.unhexify s in @@ -165,6 +165,8 @@ module DB = struct (* there might be more parameters here, e.g. a RO socket from a previous version: ignore it *) global_f ~rw + | "eventchnfd" :: eventfd :: [] -> + event_f ~eventfd | "socket" :: fd :: [] -> socket_f ~fd:(int_of_string fd) | "dom" :: domid :: mfn :: port :: []-> @@ -189,10 +191,27 @@ module DB = struct done; info "Completed loading xenstore dump" - let from_channel store cons doms chan = + let from_channel store cons createdoms chan = (* don't let the permission get on our way, full perm ! *) let op = Store.get_ops store Perms.Connection.full_rights in let rwro = ref (None) in + let eventchnfd = ref (None) in + let doms = ref (None) in + + let require_doms () = + match !doms with + | None -> + let missing_eventchnfd = !eventchnfd = None in + if missing_eventchnfd then + warn "No event channel file descriptor available in dump!"; + let eventchn = Event.init ?fd:!eventchnfd () in + let domains = createdoms eventchn in + if missing_eventchnfd then + Event.bind_dom_exc_virq eventchn; + doms := Some domains; + domains + | Some d -> d + in let global_f ~rw = let get_listen_sock sockfd = let fd = sockfd |> int_of_string |> Utils.FD.of_int in @@ -201,6 +220,10 @@ module DB = struct in rwro := get_listen_sock rw in + let event_f ~eventfd = + let fd = eventfd |> int_of_string |> Utils.FD.of_int in + eventchnfd := Some fd + in let socket_f ~fd = let ufd = Utils.FD.of_int fd in let is_valid = try (Unix.fstat ufd).Unix.st_kind = Unix.S_SOCK with _ -> false in @@ -210,6 +233,7 @@ module DB = struct warn "Ignoring invalid socket FD %d" fd in let domain_f domid mfn port = + let doms = require_doms () in let ndom = if domid > 0 then Domains.create doms domid mfn port @@ -229,8 +253,8 @@ module DB = struct op.Store.write path value; op.Store.setperms path perms in - from_channel_f chan global_f socket_f domain_f watch_f store_f; - !rwro + from_channel_f chan global_f event_f socket_f domain_f watch_f store_f; + !rwro, require_doms () let from_file store cons doms file = info "Loading xenstore dump from %s" file; @@ -238,7 +262,7 @@ module DB = struct finally (fun () -> from_channel store doms cons channel) (fun () -> close_in channel) - let to_channel store cons rw chan = + let to_channel store cons (rw, eventchn) chan = let hexify s = Utils.hexify s in fprintf chan "%s\n" dump_format_header; @@ -247,6 +271,7 @@ module DB = struct Unix.clear_close_on_exec fd; Utils.FD.to_int fd in fprintf chan "global,%d\n" (fdopt rw); + fprintf chan "eventchnfd,%d\n" (Utils.FD.to_int @@ Event.fd eventchn); (* dump connections related to domains: domid, mfn, eventchn port/ sockets, and watches *) Connections.iter cons (fun con -> Connection.dump con chan); @@ -367,7 +392,6 @@ let _ = | None -> () end; let store = Store.create () in - let eventchn = Event.init () in let next_frequent_ops = ref 0. in let advance_next_frequent_ops () = next_frequent_ops := (Unix.gettimeofday () +. !Define.conflict_max_history_seconds) @@ -375,16 +399,8 @@ let _ = let delay_next_frequent_ops_by duration = next_frequent_ops := !next_frequent_ops +. duration in - let domains = Domains.init eventchn advance_next_frequent_ops in + let domains eventchn = Domains.init eventchn advance_next_frequent_ops in - (* For things that need to be done periodically but more often - * than the periodic_ops function *) - let frequent_ops () = - if Unix.gettimeofday () > !next_frequent_ops then ( - History.trim (); - Domains.incr_conflict_credit domains; - advance_next_frequent_ops () - ) in let cons = Connections.create () in let quit = ref false in @@ -393,15 +409,15 @@ let _ = List.iter (fun path -> Store.write store Perms.Connection.full_rights path "") Store.Path.specials; - let rw_sock = + let rw_sock, domains = if cf.restart && Sys.file_exists Disk.xs_daemon_database then ( - let rwro = DB.from_file store domains cons Disk.xs_daemon_database in + let rw, domains = DB.from_file store domains cons Disk.xs_daemon_database in info "Live reload: database loaded"; - Event.bind_dom_exc_virq eventchn; Process.LiveUpdate.completed (); - rwro + rw, domains ) else ( info "No live reload: regular startup"; + let domains = domains @@ Event.init () in if !Disk.enable then ( info "reading store from disk"; Disk.read store @@ -411,11 +427,21 @@ let _ = if not (Store.path_exists store localpath) then Store.mkdir store (Perms.Connection.create 0) localpath; + let eventchn = Event.init () in if cf.domain_init then ( Connections.add_domain cons (Domains.create0 domains); Event.bind_dom_exc_virq eventchn ); - rw_sock + rw_sock, domains + ) in + + (* For things that need to be done periodically but more often + * than the periodic_ops function *) + let frequent_ops () = + if Unix.gettimeofday () > !next_frequent_ops then ( + History.trim (); + Domains.incr_conflict_credit domains; + advance_next_frequent_ops () ) in (* required for xenstore-control to detect availability of live-update *) @@ -433,10 +459,11 @@ let _ = Sys.set_signal Sys.sigpipe Sys.Signal_ignore; if cf.activate_access_log then begin - let post_rotate () = DB.to_file store cons (None) Disk.xs_daemon_database in + let post_rotate () = DB.to_file store cons (None, Domains.eventchn domains) Disk.xs_daemon_database in Logging.init_access_log post_rotate end; + let eventchn = Domains.eventchn domains in let spec_fds = (match rw_sock with None -> [] | Some x -> [ x ]) @ (if cf.domain_init then [ Event.fd eventchn ] else []) @@ -594,7 +621,7 @@ let _ = live_update := Process.LiveUpdate.should_run cons; if !live_update || !quit then begin (* don't initiate live update if saving state fails *) - DB.to_file store cons (rw_sock) Disk.xs_daemon_database; + DB.to_file store cons (rw_sock, eventchn) Disk.xs_daemon_database; quit := true; end with exc -> -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:41:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:41:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440127.694334 (Exim 4.92) (envelope-from ) id 1osQjH-0002mz-Is; Tue, 08 Nov 2022 15:41:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440127.694334; Tue, 08 Nov 2022 15:41:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQjH-0002ms-Ed; Tue, 08 Nov 2022 15:41:35 +0000 Received: by outflank-mailman (input) for mailman id 440127; Tue, 08 Nov 2022 15:34:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQcq-0001RY-9z for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:34:57 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e3241f77-5f7a-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:34:52 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3241f77-5f7a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667921692; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5uagkohGTNvF5X+pSiDm0Xmh6rsnPEv8DIR0QFQsA7c=; b=QZncjLGzbpaX5BBWaAJhBawMRIm6jG/Q54CMQLT2aXCpr2+/N2Px9b4a R3I8p3JpwspOLXLTeuWtUIRpdYXrnIPV41jlt+62MCL3sHgm6SYRtib6n IeHjb6mvdj9CUzbDddT3sZANfVUgt7FuMTqls7xYgDL38sYGdqW9RC8TA c=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84416538 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:5WvP0qo4pcGI+zz7A9k2q1ELAideBmIUZRIvgKrLsJaIsI4StFCzt garIBnTaf+NNzagfIt/aoXn908G6sDQy4I1SQs9qS89FntB+ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzylNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADERVUqRmfKZ+qmUadVnr/4NNPT5AoxK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFHU/rSn8/x7pX7WzBUtlOT47Yw+W/Q5AdwzKLsIJzefdniqcB9zhrE/ zybpDSR7hcyHcaN5AKrq1uX3+7gkRvhSq43P6+0+as/6LGU7jNKU0BHPbehmtG1g1Czc8hSI EsV/mwpt6da3FOvZsnwWVu/unHslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC9 lKPhcKvOjVpv5WcU3fb/bCRxQ5eIgBMczVEP3VdC1JYvZ+z++nfky4jUP5iDJXvnMPlNgvr7 BO2pwEEqa0un/AEgvDTEU/8vxqgoZ3ATwgQ7wrRX3644g4RWLNJd7BE+nCAs68ecd/xok2p+ SFdxpPAtLxm4YSlznTlfQkbIF2+Cx9p2hX4iEUnIZQu/i/FF5WLLdEJu2EWyKuE3685ld7Vj K374105CHx7ZiHCgUpLj2WZWqwXIVDIT4iNaxwtRoMmj1gYXFbvENtSTUCRxXvxt0MnjLsyP 5yWGe71UyhFWfg5lWLuHblNuVPO+szZ7TqNLa0XMjz9iebODJJrYett3KSyghARs/rf/VS9H yd3PMqW0RRPONASkQGOmbP+7DkicxAGOHwBg5UGK7HZeVE+SDhJ5j246epJRrGJVp99zo/gl kxRkGcBoLYjrRUr8Tm3V00= IronPort-HdrOrdr: A9a23:ko8fdKlkbAAA8ynBoPiw1EbzBFbpDfIU3DAbv31ZSRFFG/Fxl6 iV8sjzsiWE8Qr5OUtQ/+xoV5PhfZqxz/JICMwqTNKftWrdyQyVxeNZnOjfKlTbckWUnINgPO VbAsxD4bXLfCBHZK3BgTVQfexO/DD+ytHLudvj X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84416538" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Date: Tue, 8 Nov 2022 15:33:59 +0000 Message-ID: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit See CODING_STYLE: Xen uses spaces, not tabs. * OCaml code: Using `ocp-indent` for now to just make minimal modifications in tabs vs spaces and get the right indentation. We can introduce `ocamlformat` later. * C stubs: just replace tabs with spaces now, using `indent` or `clang-format` would change code too much for 4.17. This avoids perpetuating a formatting style that is inconsistent with the rest of Xen, and that makes preparing and submitting patches more difficult (OCaml indentation tools usually only support spaces, not tabs). Contains a bugfix for `abi-check` script to handle the change in the amount of whitespace. No functional change. Signed-off-by: Edwin Török -- Reason for inclusion in 4.17: - makes it easier to backport changes from master to 4.17 - avoid perpetuating a different coding style (I thought tabs were mandated by Xen, and was about to fix up my editor config to match when I realized Xen already mandates the use of spaces) - should make submitting patches for OCaml easier (OCaml indentation tools know only about spaces, so I either can't use them, or have to manually adjust indentation every time I submit a patch) - it can be verified that the only change here is the Makefile change for the new rule, 'git log -p -1 -w' should be otherwise empty Changes since v2: - new in v3 --- tools/ocaml/Makefile | 5 + tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 170 +- tools/ocaml/libs/mmap/mmap_stubs.h | 4 +- tools/ocaml/libs/mmap/xenmmap.ml | 2 +- tools/ocaml/libs/mmap/xenmmap.mli | 4 +- tools/ocaml/libs/mmap/xenmmap_stubs.c | 112 +- tools/ocaml/libs/xb/op.ml | 76 +- tools/ocaml/libs/xb/packet.ml | 30 +- tools/ocaml/libs/xb/partial.ml | 48 +- tools/ocaml/libs/xb/xb.ml | 422 ++-- tools/ocaml/libs/xb/xb.mli | 106 +- tools/ocaml/libs/xb/xenbus_stubs.c | 50 +- tools/ocaml/libs/xb/xs_ring.ml | 28 +- tools/ocaml/libs/xb/xs_ring_stubs.c | 214 +- tools/ocaml/libs/xc/abi-check | 2 +- tools/ocaml/libs/xc/xenctrl.ml | 330 +-- tools/ocaml/libs/xc/xenctrl.mli | 12 +- tools/ocaml/libs/xc/xenctrl_stubs.c | 1424 ++++++------ tools/ocaml/libs/xentoollog/caml_xentoollog.h | 6 +- .../ocaml/libs/xentoollog/xentoollog_stubs.c | 196 +- tools/ocaml/libs/xl/xenlight_stubs.c | 2022 ++++++++--------- tools/ocaml/libs/xs/queueop.ml | 48 +- tools/ocaml/libs/xs/xs.ml | 220 +- tools/ocaml/libs/xs/xs.mli | 46 +- tools/ocaml/libs/xs/xsraw.ml | 300 +-- tools/ocaml/libs/xs/xst.ml | 76 +- tools/ocaml/libs/xs/xst.mli | 20 +- tools/ocaml/test/dmesg.ml | 26 +- tools/ocaml/test/list_domains.ml | 4 +- tools/ocaml/test/raise_exception.ml | 4 +- tools/ocaml/test/xtl.ml | 28 +- tools/ocaml/xenstored/config.ml | 156 +- tools/ocaml/xenstored/connection.ml | 594 ++--- tools/ocaml/xenstored/connections.ml | 304 +-- tools/ocaml/xenstored/define.ml | 6 +- tools/ocaml/xenstored/disk.ml | 218 +- tools/ocaml/xenstored/domain.ml | 100 +- tools/ocaml/xenstored/domains.ml | 310 +-- tools/ocaml/xenstored/event.ml | 4 +- tools/ocaml/xenstored/history.ml | 62 +- tools/ocaml/xenstored/logging.ml | 434 ++-- tools/ocaml/xenstored/packet.ml | 20 +- tools/ocaml/xenstored/parse_arg.ml | 106 +- tools/ocaml/xenstored/perms.ml | 216 +- tools/ocaml/xenstored/poll.ml | 68 +- tools/ocaml/xenstored/poll.mli | 4 +- tools/ocaml/xenstored/process.ml | 1212 +++++----- tools/ocaml/xenstored/quota.ml | 74 +- tools/ocaml/xenstored/select_stubs.c | 62 +- tools/ocaml/xenstored/stdext.ml | 190 +- tools/ocaml/xenstored/store.ml | 752 +++--- tools/ocaml/xenstored/symbol.ml | 2 +- tools/ocaml/xenstored/syslog.ml | 48 +- tools/ocaml/xenstored/syslog_stubs.c | 30 +- tools/ocaml/xenstored/systemd_stubs.c | 10 +- tools/ocaml/xenstored/transaction.ml | 352 +-- tools/ocaml/xenstored/trie.ml | 222 +- tools/ocaml/xenstored/trie.mli | 22 +- tools/ocaml/xenstored/utils.ml | 146 +- tools/ocaml/xenstored/xenstored.ml | 1018 ++++----- 60 files changed, 6391 insertions(+), 6386 deletions(-) diff --git a/tools/ocaml/Makefile b/tools/ocaml/Makefile index a7c04b6546..274ba15d75 100644 --- a/tools/ocaml/Makefile +++ b/tools/ocaml/Makefile @@ -34,3 +34,8 @@ build-tools-oxenstored: $(MAKE) -s -C libs/xb $(MAKE) -s -C libs/xc $(MAKE) -C xenstored + +.PHONY: format +format: + git ls-files '*.ml' '*.mli' | xargs -n1 ocp-indent -i + git ls-files '*.c' '*.h' | xargs -n1 sed -ie 's/\t/ /g' diff --git a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c index 67af116377..2263c4caa1 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c +++ b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c @@ -44,149 +44,149 @@ static void stub_evtchn_finalize(value v) { - /* docs say to not use any CAMLparam* macros here */ - xenevtchn_close(_H(v)); + /* docs say to not use any CAMLparam* macros here */ + xenevtchn_close(_H(v)); } static struct custom_operations xenevtchn_ops = { - "xenevtchn", - stub_evtchn_finalize, - custom_compare_default, /* raises Failure, cannot compare */ - custom_hash_default, /* ignored */ - custom_serialize_default, /* raises Failure, can't serialize */ - custom_deserialize_default, /* raises Failure, can't deserialize */ - custom_compare_ext_default /* raises Failure */ + "xenevtchn", + stub_evtchn_finalize, + custom_compare_default, /* raises Failure, cannot compare */ + custom_hash_default, /* ignored */ + custom_serialize_default, /* raises Failure, can't serialize */ + custom_deserialize_default, /* raises Failure, can't deserialize */ + custom_compare_ext_default /* raises Failure */ }; CAMLprim value stub_eventchn_init(void) { - CAMLparam0(); - CAMLlocal1(result); - xenevtchn_handle *xce; + CAMLparam0(); + CAMLlocal1(result); + xenevtchn_handle *xce; - caml_enter_blocking_section(); - xce = xenevtchn_open(NULL, 0); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + xce = xenevtchn_open(NULL, 0); + caml_leave_blocking_section(); - if (xce == NULL) - caml_failwith("open failed"); + if (xce == NULL) + caml_failwith("open failed"); - /* contains file descriptors, trigger full GC at least every 128 allocations */ - result = caml_alloc_custom(&xenevtchn_ops, sizeof(xce), 0, 1); - _H(result) = xce; - CAMLreturn(result); + /* contains file descriptors, trigger full GC at least every 128 allocations */ + result = caml_alloc_custom(&xenevtchn_ops, sizeof(xce), 0, 1); + _H(result) = xce; + CAMLreturn(result); } CAMLprim value stub_eventchn_fd(value xce) { - CAMLparam1(xce); - CAMLlocal1(result); - int fd; + CAMLparam1(xce); + CAMLlocal1(result); + int fd; - fd = xenevtchn_fd(_H(xce)); - if (fd == -1) - caml_failwith("evtchn fd failed"); + fd = xenevtchn_fd(_H(xce)); + if (fd == -1) + caml_failwith("evtchn fd failed"); - result = Val_int(fd); + result = Val_int(fd); - CAMLreturn(result); + CAMLreturn(result); } CAMLprim value stub_eventchn_notify(value xce, value port) { - CAMLparam2(xce, port); - int rc; + CAMLparam2(xce, port); + int rc; - caml_enter_blocking_section(); - rc = xenevtchn_notify(_H(xce), Int_val(port)); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + rc = xenevtchn_notify(_H(xce), Int_val(port)); + caml_leave_blocking_section(); - if (rc == -1) - caml_failwith("evtchn notify failed"); + if (rc == -1) + caml_failwith("evtchn notify failed"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } CAMLprim value stub_eventchn_bind_interdomain(value xce, value domid, value remote_port) { - CAMLparam3(xce, domid, remote_port); - CAMLlocal1(port); - xenevtchn_port_or_error_t rc; + CAMLparam3(xce, domid, remote_port); + CAMLlocal1(port); + xenevtchn_port_or_error_t rc; - caml_enter_blocking_section(); - rc = xenevtchn_bind_interdomain(_H(xce), Int_val(domid), Int_val(remote_port)); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + rc = xenevtchn_bind_interdomain(_H(xce), Int_val(domid), Int_val(remote_port)); + caml_leave_blocking_section(); - if (rc == -1) - caml_failwith("evtchn bind_interdomain failed"); - port = Val_int(rc); + if (rc == -1) + caml_failwith("evtchn bind_interdomain failed"); + port = Val_int(rc); - CAMLreturn(port); + CAMLreturn(port); } CAMLprim value stub_eventchn_bind_virq(value xce, value virq_type) { - CAMLparam2(xce, virq_type); - CAMLlocal1(port); - xenevtchn_port_or_error_t rc; + CAMLparam2(xce, virq_type); + CAMLlocal1(port); + xenevtchn_port_or_error_t rc; - caml_enter_blocking_section(); - rc = xenevtchn_bind_virq(_H(xce), Int_val(virq_type)); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + rc = xenevtchn_bind_virq(_H(xce), Int_val(virq_type)); + caml_leave_blocking_section(); - if (rc == -1) - caml_failwith("evtchn bind_virq failed"); - port = Val_int(rc); + if (rc == -1) + caml_failwith("evtchn bind_virq failed"); + port = Val_int(rc); - CAMLreturn(port); + CAMLreturn(port); } CAMLprim value stub_eventchn_unbind(value xce, value port) { - CAMLparam2(xce, port); - int rc; + CAMLparam2(xce, port); + int rc; - caml_enter_blocking_section(); - rc = xenevtchn_unbind(_H(xce), Int_val(port)); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + rc = xenevtchn_unbind(_H(xce), Int_val(port)); + caml_leave_blocking_section(); - if (rc == -1) - caml_failwith("evtchn unbind failed"); + if (rc == -1) + caml_failwith("evtchn unbind failed"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } CAMLprim value stub_eventchn_pending(value xce) { - CAMLparam1(xce); - CAMLlocal1(result); - xenevtchn_port_or_error_t port; + CAMLparam1(xce); + CAMLlocal1(result); + xenevtchn_port_or_error_t port; - caml_enter_blocking_section(); - port = xenevtchn_pending(_H(xce)); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + port = xenevtchn_pending(_H(xce)); + caml_leave_blocking_section(); - if (port == -1) - caml_failwith("evtchn pending failed"); - result = Val_int(port); + if (port == -1) + caml_failwith("evtchn pending failed"); + result = Val_int(port); - CAMLreturn(result); + CAMLreturn(result); } CAMLprim value stub_eventchn_unmask(value xce, value _port) { - CAMLparam2(xce, _port); - evtchn_port_t port; - int rc; + CAMLparam2(xce, _port); + evtchn_port_t port; + int rc; - port = Int_val(_port); + port = Int_val(_port); - caml_enter_blocking_section(); - rc = xenevtchn_unmask(_H(xce), port); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + rc = xenevtchn_unmask(_H(xce), port); + caml_leave_blocking_section(); - if (rc) - caml_failwith("evtchn unmask failed"); - CAMLreturn(Val_unit); + if (rc) + caml_failwith("evtchn unmask failed"); + CAMLreturn(Val_unit); } diff --git a/tools/ocaml/libs/mmap/mmap_stubs.h b/tools/ocaml/libs/mmap/mmap_stubs.h index 5c65cc86fb..14f0c0a704 100644 --- a/tools/ocaml/libs/mmap/mmap_stubs.h +++ b/tools/ocaml/libs/mmap/mmap_stubs.h @@ -26,8 +26,8 @@ struct mmap_interface { - void *addr; - int len; + void *addr; + int len; }; /* for compatibility with OCaml 4.02.3 */ diff --git a/tools/ocaml/libs/mmap/xenmmap.ml b/tools/ocaml/libs/mmap/xenmmap.ml index 44b67c89d2..fd6735649f 100644 --- a/tools/ocaml/libs/mmap/xenmmap.ml +++ b/tools/ocaml/libs/mmap/xenmmap.ml @@ -21,7 +21,7 @@ type mmap_map_flag = SHARED | PRIVATE (* mmap: fd -> prot_flag -> map_flag -> length -> offset -> interface *) external mmap: Unix.file_descr -> mmap_prot_flag -> mmap_map_flag - -> int -> int -> mmap_interface = "stub_mmap_init" + -> int -> int -> mmap_interface = "stub_mmap_init" external unmap: mmap_interface -> unit = "stub_mmap_final" (* read: interface -> start -> length -> data *) external read: mmap_interface -> int -> int -> string = "stub_mmap_read" diff --git a/tools/ocaml/libs/mmap/xenmmap.mli b/tools/ocaml/libs/mmap/xenmmap.mli index 8f92ed6310..d097b68a8f 100644 --- a/tools/ocaml/libs/mmap/xenmmap.mli +++ b/tools/ocaml/libs/mmap/xenmmap.mli @@ -19,10 +19,10 @@ type mmap_prot_flag = RDONLY | WRONLY | RDWR type mmap_map_flag = SHARED | PRIVATE external mmap : Unix.file_descr -> mmap_prot_flag -> mmap_map_flag -> int -> int - -> mmap_interface = "stub_mmap_init" + -> mmap_interface = "stub_mmap_init" external unmap : mmap_interface -> unit = "stub_mmap_final" external read : mmap_interface -> int -> int -> string = "stub_mmap_read" external write : mmap_interface -> string -> int -> int -> unit - = "stub_mmap_write" + = "stub_mmap_write" external getpagesize : unit -> int = "stub_mmap_getpagesize" diff --git a/tools/ocaml/libs/mmap/xenmmap_stubs.c b/tools/ocaml/libs/mmap/xenmmap_stubs.c index 141dedb78c..bf864a7c32 100644 --- a/tools/ocaml/libs/mmap/xenmmap_stubs.c +++ b/tools/ocaml/libs/mmap/xenmmap_stubs.c @@ -34,97 +34,97 @@ static int mmap_interface_init(struct mmap_interface *intf, int fd, int pflag, int mflag, int len, int offset) { - intf->len = len; - intf->addr = mmap(NULL, len, pflag, mflag, fd, offset); - return (intf->addr == MAP_FAILED) ? errno : 0; + intf->len = len; + intf->addr = mmap(NULL, len, pflag, mflag, fd, offset); + return (intf->addr == MAP_FAILED) ? errno : 0; } CAMLprim value stub_mmap_init(value fd, value pflag, value mflag, value len, value offset) { - CAMLparam5(fd, pflag, mflag, len, offset); - CAMLlocal1(result); - int c_pflag, c_mflag; + CAMLparam5(fd, pflag, mflag, len, offset); + CAMLlocal1(result); + int c_pflag, c_mflag; - switch (Int_val(pflag)) { - case 0: c_pflag = PROT_READ; break; - case 1: c_pflag = PROT_WRITE; break; - case 2: c_pflag = PROT_READ|PROT_WRITE; break; - default: caml_invalid_argument("protectiontype"); - } + switch (Int_val(pflag)) { + case 0: c_pflag = PROT_READ; break; + case 1: c_pflag = PROT_WRITE; break; + case 2: c_pflag = PROT_READ|PROT_WRITE; break; + default: caml_invalid_argument("protectiontype"); + } - switch (Int_val(mflag)) { - case 0: c_mflag = MAP_SHARED; break; - case 1: c_mflag = MAP_PRIVATE; break; - default: caml_invalid_argument("maptype"); - } + switch (Int_val(mflag)) { + case 0: c_mflag = MAP_SHARED; break; + case 1: c_mflag = MAP_PRIVATE; break; + default: caml_invalid_argument("maptype"); + } - result = caml_alloc(sizeof(struct mmap_interface), Abstract_tag); + result = caml_alloc(sizeof(struct mmap_interface), Abstract_tag); - if (mmap_interface_init(Intf_val(result), Int_val(fd), - c_pflag, c_mflag, - Int_val(len), Int_val(offset))) - caml_failwith("mmap"); - CAMLreturn(result); + if (mmap_interface_init(Intf_val(result), Int_val(fd), + c_pflag, c_mflag, + Int_val(len), Int_val(offset))) + caml_failwith("mmap"); + CAMLreturn(result); } CAMLprim value stub_mmap_final(value intf) { - CAMLparam1(intf); + CAMLparam1(intf); - if (Intf_val(intf)->addr != MAP_FAILED) - munmap(Intf_val(intf)->addr, Intf_val(intf)->len); - Intf_val(intf)->addr = MAP_FAILED; + if (Intf_val(intf)->addr != MAP_FAILED) + munmap(Intf_val(intf)->addr, Intf_val(intf)->len); + Intf_val(intf)->addr = MAP_FAILED; - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } CAMLprim value stub_mmap_read(value intf, value start, value len) { - CAMLparam3(intf, start, len); - CAMLlocal1(data); - int c_start; - int c_len; + CAMLparam3(intf, start, len); + CAMLlocal1(data); + int c_start; + int c_len; - c_start = Int_val(start); - c_len = Int_val(len); + c_start = Int_val(start); + c_len = Int_val(len); - if (c_start > Intf_val(intf)->len) - caml_invalid_argument("start invalid"); - if (c_start + c_len > Intf_val(intf)->len) - caml_invalid_argument("len invalid"); + if (c_start > Intf_val(intf)->len) + caml_invalid_argument("start invalid"); + if (c_start + c_len > Intf_val(intf)->len) + caml_invalid_argument("len invalid"); - data = caml_alloc_string(c_len); - memcpy((char *) data, Intf_val(intf)->addr + c_start, c_len); + data = caml_alloc_string(c_len); + memcpy((char *) data, Intf_val(intf)->addr + c_start, c_len); - CAMLreturn(data); + CAMLreturn(data); } CAMLprim value stub_mmap_write(value intf, value data, value start, value len) { - CAMLparam4(intf, data, start, len); - int c_start; - int c_len; + CAMLparam4(intf, data, start, len); + int c_start; + int c_len; - c_start = Int_val(start); - c_len = Int_val(len); + c_start = Int_val(start); + c_len = Int_val(len); - if (c_start > Intf_val(intf)->len) - caml_invalid_argument("start invalid"); - if (c_start + c_len > Intf_val(intf)->len) - caml_invalid_argument("len invalid"); + if (c_start > Intf_val(intf)->len) + caml_invalid_argument("start invalid"); + if (c_start + c_len > Intf_val(intf)->len) + caml_invalid_argument("len invalid"); - memcpy(Intf_val(intf)->addr + c_start, (char *) data, c_len); + memcpy(Intf_val(intf)->addr + c_start, (char *) data, c_len); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } CAMLprim value stub_mmap_getpagesize(value unit) { - CAMLparam1(unit); - CAMLlocal1(data); + CAMLparam1(unit); + CAMLlocal1(data); - data = Val_int(getpagesize()); - CAMLreturn(data); + data = Val_int(getpagesize()); + CAMLreturn(data); } diff --git a/tools/ocaml/libs/xb/op.ml b/tools/ocaml/libs/xb/op.ml index 9bcab0f38c..c94116a8cc 100644 --- a/tools/ocaml/libs/xb/op.ml +++ b/tools/ocaml/libs/xb/op.ml @@ -23,50 +23,50 @@ type operation = Debug | Directory | Read | Getperms | Invalid let operation_c_mapping = - [| Debug; Directory; Read; Getperms; - Watch; Unwatch; Transaction_start; - Transaction_end; Introduce; Release; - Getdomainpath; Write; Mkdir; Rm; - Setperms; Watchevent; Error; Isintroduced; - Resume; Set_target; Invalid; Reset_watches |] + [| Debug; Directory; Read; Getperms; + Watch; Unwatch; Transaction_start; + Transaction_end; Introduce; Release; + Getdomainpath; Write; Mkdir; Rm; + Setperms; Watchevent; Error; Isintroduced; + Resume; Set_target; Invalid; Reset_watches |] let size = Array.length operation_c_mapping let array_search el a = - let len = Array.length a in - let rec search i = - if i > len then raise Not_found; - if a.(i) = el then i else search (i + 1) in - search 0 + let len = Array.length a in + let rec search i = + if i > len then raise Not_found; + if a.(i) = el then i else search (i + 1) in + search 0 let of_cval i = - if i >= 0 && i < size - then operation_c_mapping.(i) - else Invalid + if i >= 0 && i < size + then operation_c_mapping.(i) + else Invalid let to_cval op = - array_search op operation_c_mapping + array_search op operation_c_mapping let to_string ty = - match ty with - | Debug -> "DEBUG" - | Directory -> "DIRECTORY" - | Read -> "READ" - | Getperms -> "GET_PERMS" - | Watch -> "WATCH" - | Unwatch -> "UNWATCH" - | Transaction_start -> "TRANSACTION_START" - | Transaction_end -> "TRANSACTION_END" - | Introduce -> "INTRODUCE" - | Release -> "RELEASE" - | Getdomainpath -> "GET_DOMAIN_PATH" - | Write -> "WRITE" - | Mkdir -> "MKDIR" - | Rm -> "RM" - | Setperms -> "SET_PERMS" - | Watchevent -> "WATCH_EVENT" - | Error -> "ERROR" - | Isintroduced -> "IS_INTRODUCED" - | Resume -> "RESUME" - | Set_target -> "SET_TARGET" - | Reset_watches -> "RESET_WATCHES" - | Invalid -> "INVALID" + match ty with + | Debug -> "DEBUG" + | Directory -> "DIRECTORY" + | Read -> "READ" + | Getperms -> "GET_PERMS" + | Watch -> "WATCH" + | Unwatch -> "UNWATCH" + | Transaction_start -> "TRANSACTION_START" + | Transaction_end -> "TRANSACTION_END" + | Introduce -> "INTRODUCE" + | Release -> "RELEASE" + | Getdomainpath -> "GET_DOMAIN_PATH" + | Write -> "WRITE" + | Mkdir -> "MKDIR" + | Rm -> "RM" + | Setperms -> "SET_PERMS" + | Watchevent -> "WATCH_EVENT" + | Error -> "ERROR" + | Isintroduced -> "IS_INTRODUCED" + | Resume -> "RESUME" + | Set_target -> "SET_TARGET" + | Reset_watches -> "RESET_WATCHES" + | Invalid -> "INVALID" diff --git a/tools/ocaml/libs/xb/packet.ml b/tools/ocaml/libs/xb/packet.ml index 74c04bb7ae..cd169c066b 100644 --- a/tools/ocaml/libs/xb/packet.ml +++ b/tools/ocaml/libs/xb/packet.ml @@ -15,12 +15,12 @@ *) type t = -{ - tid: int; - rid: int; - ty: Op.operation; - data: string; -} + { + tid: int; + rid: int; + ty: Op.operation; + data: string; + } exception Error of string exception DataError of string @@ -30,21 +30,21 @@ external string_of_header: int -> int -> int -> int -> string = "stub_string_of_ let create tid rid ty data = { tid = tid; rid = rid; ty = ty; data = data; } let of_partialpkt ppkt = - create ppkt.Partial.tid ppkt.Partial.rid ppkt.Partial.ty (Buffer.contents ppkt.Partial.buf) + create ppkt.Partial.tid ppkt.Partial.rid ppkt.Partial.ty (Buffer.contents ppkt.Partial.buf) let to_string pkt = - let header = string_of_header pkt.tid pkt.rid (Op.to_cval pkt.ty) (String.length pkt.data) in - header ^ pkt.data + let header = string_of_header pkt.tid pkt.rid (Op.to_cval pkt.ty) (String.length pkt.data) in + header ^ pkt.data let unpack pkt = - pkt.tid, pkt.rid, pkt.ty, pkt.data + pkt.tid, pkt.rid, pkt.ty, pkt.data let get_tid pkt = pkt.tid let get_ty pkt = pkt.ty let get_data pkt = - let l = String.length pkt.data in - if l > 0 && pkt.data.[l - 1] = '\000' then - String.sub pkt.data 0 (l - 1) - else - pkt.data + let l = String.length pkt.data in + if l > 0 && pkt.data.[l - 1] = '\000' then + String.sub pkt.data 0 (l - 1) + else + pkt.data let get_rid pkt = pkt.rid \ No newline at end of file diff --git a/tools/ocaml/libs/xb/partial.ml b/tools/ocaml/libs/xb/partial.ml index 3aa8927eb7..0494c6a9c7 100644 --- a/tools/ocaml/libs/xb/partial.ml +++ b/tools/ocaml/libs/xb/partial.ml @@ -15,39 +15,39 @@ *) type pkt = -{ - tid: int; - rid: int; - ty: Op.operation; - len: int; - buf: Buffer.t; -} + { + tid: int; + rid: int; + ty: Op.operation; + len: int; + buf: Buffer.t; + } external header_size: unit -> int = "stub_header_size" external header_of_string_internal: string -> int * int * int * int - = "stub_header_of_string" + = "stub_header_of_string" let xenstore_payload_max = 4096 (* xen/include/public/io/xs_wire.h *) let xenstore_rel_path_max = 2048 (* xen/include/public/io/xs_wire.h *) let of_string s = - let tid, rid, opint, dlen = header_of_string_internal s in - (* A packet which is bigger than xenstore_payload_max is illegal. - This will leave the guest connection is a bad state and will - be hard to recover from without restarting the connection - (ie rebooting the guest) *) - let dlen = max 0 (min xenstore_payload_max dlen) in - { - tid = tid; - rid = rid; - ty = (Op.of_cval opint); - len = dlen; - buf = Buffer.create dlen; - } + let tid, rid, opint, dlen = header_of_string_internal s in + (* A packet which is bigger than xenstore_payload_max is illegal. + This will leave the guest connection is a bad state and will + be hard to recover from without restarting the connection + (ie rebooting the guest) *) + let dlen = max 0 (min xenstore_payload_max dlen) in + { + tid = tid; + rid = rid; + ty = (Op.of_cval opint); + len = dlen; + buf = Buffer.create dlen; + } let append pkt s sz = - if Buffer.length pkt.buf + sz > xenstore_payload_max then failwith "Buffer.add: cannot grow buffer"; - Buffer.add_substring pkt.buf s 0 sz + if Buffer.length pkt.buf + sz > xenstore_payload_max then failwith "Buffer.add: cannot grow buffer"; + Buffer.add_substring pkt.buf s 0 sz let to_complete pkt = - pkt.len - (Buffer.length pkt.buf) + pkt.len - (Buffer.length pkt.buf) diff --git a/tools/ocaml/libs/xb/xb.ml b/tools/ocaml/libs/xb/xb.ml index b292ed7a87..40d2c9956a 100644 --- a/tools/ocaml/libs/xb/xb.ml +++ b/tools/ocaml/libs/xb/xb.ml @@ -18,94 +18,94 @@ module Op = struct include Op end module Packet = struct include Packet end module BoundedQueue : sig - type ('a, 'b) t + type ('a, 'b) t - (** [create ~capacity ~classify ~limit] creates a queue with maximum [capacity] elements. - This is burst capacity, each element is further classified according to [classify], - and each class can have its own [limit]. - [capacity] is enforced as an overall limit. - The [limit] can be dynamic, and can be smaller than the number of elements already queued of that class, - in which case those elements are considered to use "burst capacity". - *) - val create: capacity:int -> classify:('a -> 'b) -> limit:('b -> int) -> ('a, 'b) t + (** [create ~capacity ~classify ~limit] creates a queue with maximum [capacity] elements. + This is burst capacity, each element is further classified according to [classify], + and each class can have its own [limit]. + [capacity] is enforced as an overall limit. + The [limit] can be dynamic, and can be smaller than the number of elements already queued of that class, + in which case those elements are considered to use "burst capacity". + *) + val create: capacity:int -> classify:('a -> 'b) -> limit:('b -> int) -> ('a, 'b) t - (** [clear q] discards all elements from [q] *) - val clear: ('a, 'b) t -> unit + (** [clear q] discards all elements from [q] *) + val clear: ('a, 'b) t -> unit - (** [can_push q] when [length q < capacity]. *) - val can_push: ('a, 'b) t -> 'b -> bool + (** [can_push q] when [length q < capacity]. *) + val can_push: ('a, 'b) t -> 'b -> bool - (** [push e q] adds [e] at the end of queue [q] if [can_push q], or returns [None]. *) - val push: 'a -> ('a, 'b) t -> unit option + (** [push e q] adds [e] at the end of queue [q] if [can_push q], or returns [None]. *) + val push: 'a -> ('a, 'b) t -> unit option - (** [pop q] removes and returns first element in [q], or raises [Queue.Empty]. *) - val pop: ('a, 'b) t -> 'a + (** [pop q] removes and returns first element in [q], or raises [Queue.Empty]. *) + val pop: ('a, 'b) t -> 'a - (** [peek q] returns the first element in [q], or raises [Queue.Empty]. *) - val peek : ('a, 'b) t -> 'a + (** [peek q] returns the first element in [q], or raises [Queue.Empty]. *) + val peek : ('a, 'b) t -> 'a - (** [length q] returns the current number of elements in [q] *) - val length: ('a, 'b) t -> int + (** [length q] returns the current number of elements in [q] *) + val length: ('a, 'b) t -> int - (** [debug string_of_class q] prints queue usage statistics in an unspecified internal format. *) - val debug: ('b -> string) -> (_, 'b) t -> string + (** [debug string_of_class q] prints queue usage statistics in an unspecified internal format. *) + val debug: ('b -> string) -> (_, 'b) t -> string end = struct - type ('a, 'b) t = - { q: 'a Queue.t - ; capacity: int - ; classify: 'a -> 'b - ; limit: 'b -> int - ; class_count: ('b, int) Hashtbl.t - } + type ('a, 'b) t = + { q: 'a Queue.t + ; capacity: int + ; classify: 'a -> 'b + ; limit: 'b -> int + ; class_count: ('b, int) Hashtbl.t + } - let create ~capacity ~classify ~limit = - { capacity; q = Queue.create (); classify; limit; class_count = Hashtbl.create 3 } + let create ~capacity ~classify ~limit = + { capacity; q = Queue.create (); classify; limit; class_count = Hashtbl.create 3 } - let get_count t classification = try Hashtbl.find t.class_count classification with Not_found -> 0 + let get_count t classification = try Hashtbl.find t.class_count classification with Not_found -> 0 - let can_push_internal t classification class_count = - Queue.length t.q < t.capacity && class_count < t.limit classification + let can_push_internal t classification class_count = + Queue.length t.q < t.capacity && class_count < t.limit classification - let ok = Some () + let ok = Some () - let push e t = - let classification = t.classify e in - let class_count = get_count t classification in - if can_push_internal t classification class_count then begin - Queue.push e t.q; - Hashtbl.replace t.class_count classification (class_count + 1); - ok - end - else - None + let push e t = + let classification = t.classify e in + let class_count = get_count t classification in + if can_push_internal t classification class_count then begin + Queue.push e t.q; + Hashtbl.replace t.class_count classification (class_count + 1); + ok + end + else + None - let can_push t classification = - can_push_internal t classification @@ get_count t classification + let can_push t classification = + can_push_internal t classification @@ get_count t classification - let clear t = - Queue.clear t.q; - Hashtbl.reset t.class_count + let clear t = + Queue.clear t.q; + Hashtbl.reset t.class_count - let pop t = - let e = Queue.pop t.q in - let classification = t.classify e in - let () = match get_count t classification - 1 with - | 0 -> Hashtbl.remove t.class_count classification (* reduces memusage *) - | n -> Hashtbl.replace t.class_count classification n - in - e + let pop t = + let e = Queue.pop t.q in + let classification = t.classify e in + let () = match get_count t classification - 1 with + | 0 -> Hashtbl.remove t.class_count classification (* reduces memusage *) + | n -> Hashtbl.replace t.class_count classification n + in + e - let peek t = Queue.peek t.q - let length t = Queue.length t.q + let peek t = Queue.peek t.q + let length t = Queue.length t.q - let debug string_of_class t = - let b = Buffer.create 128 in - Printf.bprintf b "BoundedQueue capacity: %d, used: {" t.capacity; - Hashtbl.iter (fun packet_class count -> - Printf.bprintf b " %s: %d" (string_of_class packet_class) count - ) t.class_count; - Printf.bprintf b "}"; - Buffer.contents b + let debug string_of_class t = + let b = Buffer.create 128 in + Printf.bprintf b "BoundedQueue capacity: %d, used: {" t.capacity; + Hashtbl.iter (fun packet_class count -> + Printf.bprintf b " %s: %d" (string_of_class packet_class) count + ) t.class_count; + Printf.bprintf b "}"; + Buffer.contents b end @@ -119,129 +119,129 @@ let _ = Callback.register_exception "Xb.Reconnect" Reconnect type backend_mmap = -{ - mmap: Xenmmap.mmap_interface; (* mmaped interface = xs_ring *) - eventchn_notify: unit -> unit; (* function to notify through eventchn *) - mutable work_again: bool; -} + { + mmap: Xenmmap.mmap_interface; (* mmaped interface = xs_ring *) + eventchn_notify: unit -> unit; (* function to notify through eventchn *) + mutable work_again: bool; + } type backend_fd = -{ - fd: Unix.file_descr; -} + { + fd: Unix.file_descr; + } type backend = Fd of backend_fd | Xenmmap of backend_mmap type partial_buf = HaveHdr of Partial.pkt | NoHdr of int * bytes (* - separate capacity reservation for replies and watch events: - this allows a domain to keep working even when under a constant flood of - watch events + separate capacity reservation for replies and watch events: + this allows a domain to keep working even when under a constant flood of + watch events *) type capacity = { maxoutstanding: int; maxwatchevents: int } module Queue = BoundedQueue type packet_class = - | CommandReply - | Watchevent + | CommandReply + | Watchevent let string_of_packet_class = function - | CommandReply -> "command_reply" - | Watchevent -> "watch_event" + | CommandReply -> "command_reply" + | Watchevent -> "watch_event" type t = -{ - backend: backend; - pkt_out: (Packet.t, packet_class) Queue.t; - mutable partial_in: partial_buf; - mutable partial_out: string; - capacity: capacity -} + { + backend: backend; + pkt_out: (Packet.t, packet_class) Queue.t; + mutable partial_in: partial_buf; + mutable partial_out: string; + capacity: capacity + } let to_read con = - match con.partial_in with - | HaveHdr partial_pkt -> Partial.to_complete partial_pkt - | NoHdr (i, _) -> i + match con.partial_in with + | HaveHdr partial_pkt -> Partial.to_complete partial_pkt + | NoHdr (i, _) -> i let debug t = - Printf.sprintf "XenBus state: partial_in: %d needed, partial_out: %d bytes, pkt_out: %d packets, %s" - (to_read t) - (String.length t.partial_out) - (Queue.length t.pkt_out) - (BoundedQueue.debug string_of_packet_class t.pkt_out) + Printf.sprintf "XenBus state: partial_in: %d needed, partial_out: %d bytes, pkt_out: %d packets, %s" + (to_read t) + (String.length t.partial_out) + (Queue.length t.pkt_out) + (BoundedQueue.debug string_of_packet_class t.pkt_out) let init_partial_in () = NoHdr - (Partial.header_size (), Bytes.make (Partial.header_size()) '\000') + (Partial.header_size (), Bytes.make (Partial.header_size()) '\000') let reconnect t = match t.backend with - | Fd _ -> - (* should never happen, so close the connection *) - raise End_of_file - | Xenmmap backend -> - Xs_ring.close backend.mmap; - backend.eventchn_notify (); - (* Clear our old connection state *) - Queue.clear t.pkt_out; - t.partial_in <- init_partial_in (); - t.partial_out <- "" + | Fd _ -> + (* should never happen, so close the connection *) + raise End_of_file + | Xenmmap backend -> + Xs_ring.close backend.mmap; + backend.eventchn_notify (); + (* Clear our old connection state *) + Queue.clear t.pkt_out; + t.partial_in <- init_partial_in (); + t.partial_out <- "" let queue con pkt = Queue.push pkt con.pkt_out let read_fd back _con b len = - let rd = Unix.read back.fd b 0 len in - if rd = 0 then - raise End_of_file; - rd + let rd = Unix.read back.fd b 0 len in + if rd = 0 then + raise End_of_file; + rd let read_mmap back _con b len = - let s = Bytes.make len '\000' in - let rd = Xs_ring.read back.mmap s len in - Bytes.blit s 0 b 0 rd; - back.work_again <- (rd > 0); - if rd > 0 then - back.eventchn_notify (); - rd + let s = Bytes.make len '\000' in + let rd = Xs_ring.read back.mmap s len in + Bytes.blit s 0 b 0 rd; + back.work_again <- (rd > 0); + if rd > 0 then + back.eventchn_notify (); + rd let read con b len = - match con.backend with - | Fd backfd -> read_fd backfd con b len - | Xenmmap backmmap -> read_mmap backmmap con b len + match con.backend with + | Fd backfd -> read_fd backfd con b len + | Xenmmap backmmap -> read_mmap backmmap con b len let write_fd back _con b len = - Unix.write_substring back.fd b 0 len + Unix.write_substring back.fd b 0 len let write_mmap back _con s len = - let ws = Xs_ring.write_substring back.mmap s len in - if ws > 0 then - back.eventchn_notify (); - ws + let ws = Xs_ring.write_substring back.mmap s len in + if ws > 0 then + back.eventchn_notify (); + ws let write con s len = - match con.backend with - | Fd backfd -> write_fd backfd con s len - | Xenmmap backmmap -> write_mmap backmmap con s len + match con.backend with + | Fd backfd -> write_fd backfd con s len + | Xenmmap backmmap -> write_mmap backmmap con s len (* NB: can throw Reconnect *) let output con = - (* get the output string from a string_of(packet) or partial_out *) - let s = if String.length con.partial_out > 0 then - con.partial_out - else if Queue.length con.pkt_out > 0 then - let pkt = Queue.pop con.pkt_out in - Packet.to_string pkt - else - "" in - (* send data from s, and save the unsent data to partial_out *) - if s <> "" then ( - let len = String.length s in - let sz = write con s len in - let left = String.sub s sz (len - sz) in - con.partial_out <- left - ); - (* after sending one packet, partial is empty *) - con.partial_out = "" + (* get the output string from a string_of(packet) or partial_out *) + let s = if String.length con.partial_out > 0 then + con.partial_out + else if Queue.length con.pkt_out > 0 then + let pkt = Queue.pop con.pkt_out in + Packet.to_string pkt + else + "" in + (* send data from s, and save the unsent data to partial_out *) + if s <> "" then ( + let len = String.length s in + let sz = write con s len in + let left = String.sub s sz (len - sz) in + con.partial_out <- left + ); + (* after sending one packet, partial is empty *) + con.partial_out = "" (* we can only process an input packet if we're guaranteed to have room to store the response packet *) @@ -249,71 +249,71 @@ let can_input con = Queue.can_push con.pkt_out CommandReply (* NB: can throw Reconnect *) let input con = - if not (can_input con) then None - else - let to_read = to_read con in + if not (can_input con) then None + else + let to_read = to_read con in - (* try to get more data from input stream *) - let b = Bytes.make to_read '\000' in - let sz = if to_read > 0 then read con b to_read else 0 in + (* try to get more data from input stream *) + let b = Bytes.make to_read '\000' in + let sz = if to_read > 0 then read con b to_read else 0 in - ( - match con.partial_in with - | HaveHdr partial_pkt -> - (* we complete the data *) - if sz > 0 then - Partial.append partial_pkt (Bytes.to_string b) sz; - if Partial.to_complete partial_pkt = 0 then ( - let pkt = Packet.of_partialpkt partial_pkt in - con.partial_in <- init_partial_in (); - Some pkt - ) else None - | NoHdr (i, buf) -> - (* we complete the partial header *) - if sz > 0 then - Bytes.blit b 0 buf (Partial.header_size () - i) sz; - con.partial_in <- if sz = i then - HaveHdr (Partial.of_string (Bytes.to_string buf)) else NoHdr (i - sz, buf); - None - ) + ( + match con.partial_in with + | HaveHdr partial_pkt -> + (* we complete the data *) + if sz > 0 then + Partial.append partial_pkt (Bytes.to_string b) sz; + if Partial.to_complete partial_pkt = 0 then ( + let pkt = Packet.of_partialpkt partial_pkt in + con.partial_in <- init_partial_in (); + Some pkt + ) else None + | NoHdr (i, buf) -> + (* we complete the partial header *) + if sz > 0 then + Bytes.blit b 0 buf (Partial.header_size () - i) sz; + con.partial_in <- if sz = i then + HaveHdr (Partial.of_string (Bytes.to_string buf)) else NoHdr (i - sz, buf); + None + ) let classify t = - match t.Packet.ty with - | Op.Watchevent -> Watchevent - | _ -> CommandReply + match t.Packet.ty with + | Op.Watchevent -> Watchevent + | _ -> CommandReply let newcon ~capacity backend = - let limit = function - | CommandReply -> capacity.maxoutstanding - | Watchevent -> capacity.maxwatchevents - in - { - backend = backend; - pkt_out = Queue.create ~capacity:(capacity.maxoutstanding + capacity.maxwatchevents) ~classify ~limit; - partial_in = init_partial_in (); - partial_out = ""; - capacity = capacity; - } + let limit = function + | CommandReply -> capacity.maxoutstanding + | Watchevent -> capacity.maxwatchevents + in + { + backend = backend; + pkt_out = Queue.create ~capacity:(capacity.maxoutstanding + capacity.maxwatchevents) ~classify ~limit; + partial_in = init_partial_in (); + partial_out = ""; + capacity = capacity; + } let open_fd fd = newcon (Fd { fd = fd; }) let open_mmap mmap notifyfct = - (* Advertise XENSTORE_SERVER_FEATURE_RECONNECTION *) - Xs_ring.set_server_features mmap (Xs_ring.Server_features.singleton Xs_ring.Server_feature.Reconnection); - newcon (Xenmmap { - mmap = mmap; - eventchn_notify = notifyfct; - work_again = false; }) + (* Advertise XENSTORE_SERVER_FEATURE_RECONNECTION *) + Xs_ring.set_server_features mmap (Xs_ring.Server_features.singleton Xs_ring.Server_feature.Reconnection); + newcon (Xenmmap { + mmap = mmap; + eventchn_notify = notifyfct; + work_again = false; }) let close con = - match con.backend with - | Fd backend -> Unix.close backend.fd - | Xenmmap backend -> Xenmmap.unmap backend.mmap + match con.backend with + | Fd backend -> Unix.close backend.fd + | Xenmmap backend -> Xenmmap.unmap backend.mmap let is_fd con = - match con.backend with - | Fd _ -> true - | Xenmmap _ -> false + match con.backend with + | Fd _ -> true + | Xenmmap _ -> false let is_mmap con = not (is_fd con) @@ -326,19 +326,19 @@ let has_output con = has_new_output con || has_old_output con let peek_output con = Queue.peek con.pkt_out let has_partial_input con = match con.partial_in with - | HaveHdr _ -> true - | NoHdr (n, _) -> n < Partial.header_size () + | HaveHdr _ -> true + | NoHdr (n, _) -> n < Partial.header_size () let has_more_input con = - match con.backend with - | Fd _ -> false - | Xenmmap backend -> backend.work_again + match con.backend with + | Fd _ -> false + | Xenmmap backend -> backend.work_again let is_selectable con = - match con.backend with - | Fd _ -> true - | Xenmmap _ -> false + match con.backend with + | Fd _ -> true + | Xenmmap _ -> false let get_fd con = - match con.backend with - | Fd backend -> backend.fd - | Xenmmap _ -> raise (Failure "get_fd") + match con.backend with + | Fd backend -> backend.fd + | Xenmmap _ -> raise (Failure "get_fd") diff --git a/tools/ocaml/libs/xb/xb.mli b/tools/ocaml/libs/xb/xb.mli index 71b2754ca7..e6bb3809dc 100644 --- a/tools/ocaml/libs/xb/xb.mli +++ b/tools/ocaml/libs/xb/xb.mli @@ -1,58 +1,58 @@ module Op : - sig - type operation = - Op.operation = - Debug - | Directory - | Read - | Getperms - | Watch - | Unwatch - | Transaction_start - | Transaction_end - | Introduce - | Release - | Getdomainpath - | Write - | Mkdir - | Rm - | Setperms - | Watchevent - | Error - | Isintroduced - | Resume - | Set_target - | Reset_watches - | Invalid - val operation_c_mapping : operation array - val size : int - val array_search : 'a -> 'a array -> int - val of_cval : int -> operation - val to_cval : operation -> int - val to_string : operation -> string - end +sig + type operation = + Op.operation = + Debug + | Directory + | Read + | Getperms + | Watch + | Unwatch + | Transaction_start + | Transaction_end + | Introduce + | Release + | Getdomainpath + | Write + | Mkdir + | Rm + | Setperms + | Watchevent + | Error + | Isintroduced + | Resume + | Set_target + | Reset_watches + | Invalid + val operation_c_mapping : operation array + val size : int + val array_search : 'a -> 'a array -> int + val of_cval : int -> operation + val to_cval : operation -> int + val to_string : operation -> string +end module Packet : - sig - type t = - Packet.t = { - tid : int; - rid : int; - ty : Op.operation; - data : string; - } - exception Error of string - exception DataError of string - external string_of_header : int -> int -> int -> int -> string - = "stub_string_of_header" - val create : int -> int -> Op.operation -> string -> t - val of_partialpkt : Partial.pkt -> t - val to_string : t -> string - val unpack : t -> int * int * Op.operation * string - val get_tid : t -> int - val get_ty : t -> Op.operation - val get_data : t -> string - val get_rid : t -> int - end +sig + type t = + Packet.t = { + tid : int; + rid : int; + ty : Op.operation; + data : string; + } + exception Error of string + exception DataError of string + external string_of_header : int -> int -> int -> int -> string + = "stub_string_of_header" + val create : int -> int -> Op.operation -> string -> t + val of_partialpkt : Partial.pkt -> t + val to_string : t -> string + val unpack : t -> int * int * Op.operation * string + val get_tid : t -> int + val get_ty : t -> Op.operation + val get_data : t -> string + val get_rid : t -> int +end exception End_of_file exception Eagain exception Noent diff --git a/tools/ocaml/libs/xb/xenbus_stubs.c b/tools/ocaml/libs/xb/xenbus_stubs.c index 3065181a55..e5206f64d4 100644 --- a/tools/ocaml/libs/xb/xenbus_stubs.c +++ b/tools/ocaml/libs/xb/xenbus_stubs.c @@ -32,40 +32,40 @@ CAMLprim value stub_header_size(void) { - CAMLparam0(); - CAMLreturn(Val_int(sizeof(struct xsd_sockmsg))); + CAMLparam0(); + CAMLreturn(Val_int(sizeof(struct xsd_sockmsg))); } CAMLprim value stub_header_of_string(value s) { - CAMLparam1(s); - CAMLlocal1(ret); - const struct xsd_sockmsg *hdr; + CAMLparam1(s); + CAMLlocal1(ret); + const struct xsd_sockmsg *hdr; - if (caml_string_length(s) != sizeof(struct xsd_sockmsg)) - caml_failwith("xb header incomplete"); - ret = caml_alloc_tuple(4); - hdr = (const struct xsd_sockmsg *) String_val(s); - Store_field(ret, 0, Val_int(hdr->tx_id)); - Store_field(ret, 1, Val_int(hdr->req_id)); - Store_field(ret, 2, Val_int(hdr->type)); - Store_field(ret, 3, Val_int(hdr->len)); - CAMLreturn(ret); + if (caml_string_length(s) != sizeof(struct xsd_sockmsg)) + caml_failwith("xb header incomplete"); + ret = caml_alloc_tuple(4); + hdr = (const struct xsd_sockmsg *) String_val(s); + Store_field(ret, 0, Val_int(hdr->tx_id)); + Store_field(ret, 1, Val_int(hdr->req_id)); + Store_field(ret, 2, Val_int(hdr->type)); + Store_field(ret, 3, Val_int(hdr->len)); + CAMLreturn(ret); } CAMLprim value stub_string_of_header(value tid, value rid, value ty, value len) { - CAMLparam4(tid, rid, ty, len); - CAMLlocal1(ret); - struct xsd_sockmsg xsd = { - .type = Int_val(ty), - .tx_id = Int_val(tid), - .req_id = Int_val(rid), - .len = Int_val(len), - }; + CAMLparam4(tid, rid, ty, len); + CAMLlocal1(ret); + struct xsd_sockmsg xsd = { + .type = Int_val(ty), + .tx_id = Int_val(tid), + .req_id = Int_val(rid), + .len = Int_val(len), + }; - ret = caml_alloc_string(sizeof(struct xsd_sockmsg)); - memcpy((char *) String_val(ret), &xsd, sizeof(struct xsd_sockmsg)); + ret = caml_alloc_string(sizeof(struct xsd_sockmsg)); + memcpy((char *) String_val(ret), &xsd, sizeof(struct xsd_sockmsg)); - CAMLreturn(ret); + CAMLreturn(ret); } diff --git a/tools/ocaml/libs/xb/xs_ring.ml b/tools/ocaml/libs/xb/xs_ring.ml index db7f86bd27..2a27aa56c2 100644 --- a/tools/ocaml/libs/xb/xs_ring.ml +++ b/tools/ocaml/libs/xb/xs_ring.ml @@ -15,14 +15,14 @@ *) module Server_feature = struct - type t = - | Reconnection + type t = + | Reconnection end module Server_features = Set.Make(struct - type t = Server_feature.t - let compare = compare -end) + type t = Server_feature.t + let compare = compare + end) external read: Xenmmap.mmap_interface -> bytes -> int -> int = "ml_interface_read" external write: Xenmmap.mmap_interface -> bytes -> int -> int = "ml_interface_write" @@ -31,18 +31,18 @@ external _internal_set_server_features: Xenmmap.mmap_interface -> int -> unit = external _internal_get_server_features: Xenmmap.mmap_interface -> int = "ml_interface_get_server_features" [@@noalloc] let write_substring mmap buff len = - write mmap (Bytes.unsafe_of_string buff) len + write mmap (Bytes.unsafe_of_string buff) len let get_server_features mmap = - (* NB only one feature currently defined above *) - let x = _internal_get_server_features mmap in - if x = 0 - then Server_features.empty - else Server_features.singleton Server_feature.Reconnection + (* NB only one feature currently defined above *) + let x = _internal_get_server_features mmap in + if x = 0 + then Server_features.empty + else Server_features.singleton Server_feature.Reconnection let set_server_features mmap set = - (* NB only one feature currently defined above *) - let x = if set = Server_features.empty then 0 else 1 in - _internal_set_server_features mmap x + (* NB only one feature currently defined above *) + let x = if set = Server_features.empty then 0 else 1 in + _internal_set_server_features mmap x external close: Xenmmap.mmap_interface -> unit = "ml_interface_close" [@@noalloc] diff --git a/tools/ocaml/libs/xb/xs_ring_stubs.c b/tools/ocaml/libs/xb/xs_ring_stubs.c index cc9114029f..1e472d0bbf 100644 --- a/tools/ocaml/libs/xb/xs_ring_stubs.c +++ b/tools/ocaml/libs/xb/xs_ring_stubs.c @@ -49,153 +49,153 @@ CAMLprim value ml_interface_read(value ml_interface, value ml_buffer, value ml_len) { - CAMLparam3(ml_interface, ml_buffer, ml_len); - CAMLlocal1(ml_result); + CAMLparam3(ml_interface, ml_buffer, ml_len); + CAMLlocal1(ml_result); - struct mmap_interface *interface = GET_C_STRUCT(ml_interface); - unsigned char *buffer = Bytes_val(ml_buffer); - int len = Int_val(ml_len); - int result; + struct mmap_interface *interface = GET_C_STRUCT(ml_interface); + unsigned char *buffer = Bytes_val(ml_buffer); + int len = Int_val(ml_len); + int result; - struct xenstore_domain_interface *intf = interface->addr; - XENSTORE_RING_IDX cons, prod; /* offsets only */ - int total_data, data; - uint32_t connection; + struct xenstore_domain_interface *intf = interface->addr; + XENSTORE_RING_IDX cons, prod; /* offsets only */ + int total_data, data; + uint32_t connection; - cons = *(volatile uint32_t*)&intf->req_cons; - prod = *(volatile uint32_t*)&intf->req_prod; - connection = *(volatile uint32_t*)&intf->connection; + cons = *(volatile uint32_t*)&intf->req_cons; + prod = *(volatile uint32_t*)&intf->req_prod; + connection = *(volatile uint32_t*)&intf->connection; - if (connection != XENSTORE_CONNECTED) - caml_raise_constant(*caml_named_value("Xb.Reconnect")); + if (connection != XENSTORE_CONNECTED) + caml_raise_constant(*caml_named_value("Xb.Reconnect")); - xen_mb(); + xen_mb(); - if ((prod - cons) > XENSTORE_RING_SIZE) - caml_failwith("bad connection"); + if ((prod - cons) > XENSTORE_RING_SIZE) + caml_failwith("bad connection"); - /* Check for any pending data at all. */ - total_data = prod - cons; - if (total_data == 0) { - /* No pending data at all. */ - result = 0; - goto exit; - } - else if (total_data < len) - /* Some data - make a partial read. */ - len = total_data; + /* Check for any pending data at all. */ + total_data = prod - cons; + if (total_data == 0) { + /* No pending data at all. */ + result = 0; + goto exit; + } + else if (total_data < len) + /* Some data - make a partial read. */ + len = total_data; - /* Check whether data crosses the end of the ring. */ - data = XENSTORE_RING_SIZE - MASK_XENSTORE_IDX(cons); - if (len < data) - /* Data within the remaining part of the ring. */ - memcpy(buffer, intf->req + MASK_XENSTORE_IDX(cons), len); - else { - /* Data crosses the ring boundary. Read both halves. */ - memcpy(buffer, intf->req + MASK_XENSTORE_IDX(cons), data); - memcpy(buffer + data, intf->req, len - data); - } + /* Check whether data crosses the end of the ring. */ + data = XENSTORE_RING_SIZE - MASK_XENSTORE_IDX(cons); + if (len < data) + /* Data within the remaining part of the ring. */ + memcpy(buffer, intf->req + MASK_XENSTORE_IDX(cons), len); + else { + /* Data crosses the ring boundary. Read both halves. */ + memcpy(buffer, intf->req + MASK_XENSTORE_IDX(cons), data); + memcpy(buffer + data, intf->req, len - data); + } - xen_mb(); - intf->req_cons += len; - result = len; + xen_mb(); + intf->req_cons += len; + result = len; exit: - ml_result = Val_int(result); - CAMLreturn(ml_result); + ml_result = Val_int(result); + CAMLreturn(ml_result); } CAMLprim value ml_interface_write(value ml_interface, value ml_buffer, value ml_len) { - CAMLparam3(ml_interface, ml_buffer, ml_len); - CAMLlocal1(ml_result); + CAMLparam3(ml_interface, ml_buffer, ml_len); + CAMLlocal1(ml_result); - struct mmap_interface *interface = GET_C_STRUCT(ml_interface); - const unsigned char *buffer = Bytes_val(ml_buffer); - int len = Int_val(ml_len); - int result; + struct mmap_interface *interface = GET_C_STRUCT(ml_interface); + const unsigned char *buffer = Bytes_val(ml_buffer); + int len = Int_val(ml_len); + int result; - struct xenstore_domain_interface *intf = interface->addr; - XENSTORE_RING_IDX cons, prod; - int total_space, space; - uint32_t connection; + struct xenstore_domain_interface *intf = interface->addr; + XENSTORE_RING_IDX cons, prod; + int total_space, space; + uint32_t connection; - cons = *(volatile uint32_t*)&intf->rsp_cons; - prod = *(volatile uint32_t*)&intf->rsp_prod; - connection = *(volatile uint32_t*)&intf->connection; + cons = *(volatile uint32_t*)&intf->rsp_cons; + prod = *(volatile uint32_t*)&intf->rsp_prod; + connection = *(volatile uint32_t*)&intf->connection; - if (connection != XENSTORE_CONNECTED) - caml_raise_constant(*caml_named_value("Xb.Reconnect")); + if (connection != XENSTORE_CONNECTED) + caml_raise_constant(*caml_named_value("Xb.Reconnect")); - xen_mb(); + xen_mb(); - if ((prod - cons) > XENSTORE_RING_SIZE) - caml_failwith("bad connection"); + if ((prod - cons) > XENSTORE_RING_SIZE) + caml_failwith("bad connection"); - /* Check for space to write the full message. */ - total_space = XENSTORE_RING_SIZE - (prod - cons); - if (total_space == 0) { - /* No space at all - exit having done nothing. */ - result = 0; - goto exit; - } - else if (total_space < len) - /* Some space - make a partial write. */ - len = total_space; + /* Check for space to write the full message. */ + total_space = XENSTORE_RING_SIZE - (prod - cons); + if (total_space == 0) { + /* No space at all - exit having done nothing. */ + result = 0; + goto exit; + } + else if (total_space < len) + /* Some space - make a partial write. */ + len = total_space; - /* Check for space until the ring wraps. */ - space = XENSTORE_RING_SIZE - MASK_XENSTORE_IDX(prod); - if (len < space) - /* Message fits inside the remaining part of the ring. */ - memcpy(intf->rsp + MASK_XENSTORE_IDX(prod), buffer, len); - else { - /* Message wraps around the end of the ring. Write both halves. */ - memcpy(intf->rsp + MASK_XENSTORE_IDX(prod), buffer, space); - memcpy(intf->rsp, buffer + space, len - space); - } + /* Check for space until the ring wraps. */ + space = XENSTORE_RING_SIZE - MASK_XENSTORE_IDX(prod); + if (len < space) + /* Message fits inside the remaining part of the ring. */ + memcpy(intf->rsp + MASK_XENSTORE_IDX(prod), buffer, len); + else { + /* Message wraps around the end of the ring. Write both halves. */ + memcpy(intf->rsp + MASK_XENSTORE_IDX(prod), buffer, space); + memcpy(intf->rsp, buffer + space, len - space); + } - xen_mb(); - intf->rsp_prod += len; - result = len; + xen_mb(); + intf->rsp_prod += len; + result = len; exit: - ml_result = Val_int(result); - CAMLreturn(ml_result); + ml_result = Val_int(result); + CAMLreturn(ml_result); } CAMLprim value ml_interface_set_server_features(value interface, value v) { - CAMLparam2(interface, v); - struct xenstore_domain_interface *intf = GET_C_STRUCT(interface)->addr; - if (intf == (void*)MAP_FAILED) - caml_failwith("Interface closed"); + CAMLparam2(interface, v); + struct xenstore_domain_interface *intf = GET_C_STRUCT(interface)->addr; + if (intf == (void*)MAP_FAILED) + caml_failwith("Interface closed"); - intf->server_features = Int_val(v); + intf->server_features = Int_val(v); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } CAMLprim value ml_interface_get_server_features(value interface) { - CAMLparam1(interface); - struct xenstore_domain_interface *intf = GET_C_STRUCT(interface)->addr; + CAMLparam1(interface); + struct xenstore_domain_interface *intf = GET_C_STRUCT(interface)->addr; - CAMLreturn(Val_int (intf->server_features)); + CAMLreturn(Val_int (intf->server_features)); } CAMLprim value ml_interface_close(value interface) { - CAMLparam1(interface); - struct xenstore_domain_interface *intf = GET_C_STRUCT(interface)->addr; - int i; + CAMLparam1(interface); + struct xenstore_domain_interface *intf = GET_C_STRUCT(interface)->addr; + int i; - intf->req_cons = intf->req_prod = intf->rsp_cons = intf->rsp_prod = 0; - /* Ensure the unused space is full of invalid xenstore packets. */ - for (i = 0; i < XENSTORE_RING_SIZE; i++) { - intf->req[i] = 0xff; /* XS_INVALID = 0xffff */ - intf->rsp[i] = 0xff; - } - xen_mb (); - intf->connection = XENSTORE_CONNECTED; - CAMLreturn(Val_unit); + intf->req_cons = intf->req_prod = intf->rsp_cons = intf->rsp_prod = 0; + /* Ensure the unused space is full of invalid xenstore packets. */ + for (i = 0; i < XENSTORE_RING_SIZE; i++) { + intf->req[i] = 0xff; /* XS_INVALID = 0xffff */ + intf->rsp[i] = 0xff; + } + xen_mb (); + intf->connection = XENSTORE_CONNECTED; + CAMLreturn(Val_unit); } diff --git a/tools/ocaml/libs/xc/abi-check b/tools/ocaml/libs/xc/abi-check index 3cbdec582f..dc5bfd6cd8 100755 --- a/tools/ocaml/libs/xc/abi-check +++ b/tools/ocaml/libs/xc/abi-check @@ -39,7 +39,7 @@ while () { } } else { $cline++; - m{^\s+/\* \s+ ! \s+ (.*?) \s* \*/\s*$}x or + m{^\s*/\*\s+! \s+ (.*?) \s* \*/\s*$}x or die "at line $cline of annotation, did not expect $_ ?"; my @vals = split /\s+/, $1; if ($cline == 1 && !@vals) { diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 28ed642231..2ad4a671a5 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -20,157 +20,157 @@ type domid = int (* ** xenctrl.h ** *) type vcpuinfo = -{ - online: bool; - blocked: bool; - running: bool; - cputime: int64; - cpumap: int32; -} + { + online: bool; + blocked: bool; + running: bool; + cputime: int64; + cpumap: int32; + } type xen_arm_arch_domainconfig = -{ - gic_version: int; - nr_spis: int; - clock_frequency: int32; -} + { + gic_version: int; + nr_spis: int; + clock_frequency: int32; + } type x86_arch_emulation_flags = - | X86_EMU_LAPIC - | X86_EMU_HPET - | X86_EMU_PM - | X86_EMU_RTC - | X86_EMU_IOAPIC - | X86_EMU_PIC - | X86_EMU_VGA - | X86_EMU_IOMMU - | X86_EMU_PIT - | X86_EMU_USE_PIRQ - | X86_EMU_VPCI + | X86_EMU_LAPIC + | X86_EMU_HPET + | X86_EMU_PM + | X86_EMU_RTC + | X86_EMU_IOAPIC + | X86_EMU_PIC + | X86_EMU_VGA + | X86_EMU_IOMMU + | X86_EMU_PIT + | X86_EMU_USE_PIRQ + | X86_EMU_VPCI type x86_arch_misc_flags = - | X86_MSR_RELAXED - | X86_ASSISTED_XAPIC - | X86_ASSISTED_X2APIC + | X86_MSR_RELAXED + | X86_ASSISTED_XAPIC + | X86_ASSISTED_X2APIC type xen_x86_arch_domainconfig = -{ - emulation_flags: x86_arch_emulation_flags list; - misc_flags: x86_arch_misc_flags list; -} + { + emulation_flags: x86_arch_emulation_flags list; + misc_flags: x86_arch_misc_flags list; + } type arch_domainconfig = - | ARM of xen_arm_arch_domainconfig - | X86 of xen_x86_arch_domainconfig + | ARM of xen_arm_arch_domainconfig + | X86 of xen_x86_arch_domainconfig type domain_create_flag = - | CDF_HVM - | CDF_HAP - | CDF_S3_INTEGRITY - | CDF_OOS_OFF - | CDF_XS_DOMAIN - | CDF_IOMMU - | CDF_NESTED_VIRT - | CDF_VPMU + | CDF_HVM + | CDF_HAP + | CDF_S3_INTEGRITY + | CDF_OOS_OFF + | CDF_XS_DOMAIN + | CDF_IOMMU + | CDF_NESTED_VIRT + | CDF_VPMU type domain_create_iommu_opts = - | IOMMU_NO_SHAREPT + | IOMMU_NO_SHAREPT type domctl_create_config = -{ - ssidref: int32; - handle: string; - flags: domain_create_flag list; - iommu_opts: domain_create_iommu_opts list; - max_vcpus: int; - max_evtchn_port: int; - max_grant_frames: int; - max_maptrack_frames: int; - max_grant_version: int; - cpupool_id: int32; - arch: arch_domainconfig; -} + { + ssidref: int32; + handle: string; + flags: domain_create_flag list; + iommu_opts: domain_create_iommu_opts list; + max_vcpus: int; + max_evtchn_port: int; + max_grant_frames: int; + max_maptrack_frames: int; + max_grant_version: int; + cpupool_id: int32; + arch: arch_domainconfig; + } type domaininfo = -{ - domid : domid; - dying : bool; - shutdown : bool; - paused : bool; - blocked : bool; - running : bool; - hvm_guest : bool; - shutdown_code : int; - total_memory_pages: nativeint; - max_memory_pages : nativeint; - shared_info_frame : int64; - cpu_time : int64; - nr_online_vcpus : int; - max_vcpu_id : int; - ssidref : int32; - handle : int array; - arch_config : arch_domainconfig; -} + { + domid : domid; + dying : bool; + shutdown : bool; + paused : bool; + blocked : bool; + running : bool; + hvm_guest : bool; + shutdown_code : int; + total_memory_pages: nativeint; + max_memory_pages : nativeint; + shared_info_frame : int64; + cpu_time : int64; + nr_online_vcpus : int; + max_vcpu_id : int; + ssidref : int32; + handle : int array; + arch_config : arch_domainconfig; + } type sched_control = -{ - weight : int; - cap : int; -} + { + weight : int; + cap : int; + } type physinfo_cap_flag = - | CAP_HVM - | CAP_PV - | CAP_DirectIO - | CAP_HAP - | CAP_Shadow - | CAP_IOMMU_HAP_PT_SHARE - | CAP_Vmtrace - | CAP_Vpmu - | CAP_Gnttab_v1 - | CAP_Gnttab_v2 + | CAP_HVM + | CAP_PV + | CAP_DirectIO + | CAP_HAP + | CAP_Shadow + | CAP_IOMMU_HAP_PT_SHARE + | CAP_Vmtrace + | CAP_Vpmu + | CAP_Gnttab_v1 + | CAP_Gnttab_v2 type arm_physinfo_cap_flag type x86_physinfo_cap_flag = - | CAP_X86_ASSISTED_XAPIC - | CAP_X86_ASSISTED_X2APIC + | CAP_X86_ASSISTED_XAPIC + | CAP_X86_ASSISTED_X2APIC type arch_physinfo_cap_flags = - | ARM of arm_physinfo_cap_flag list - | X86 of x86_physinfo_cap_flag list + | ARM of arm_physinfo_cap_flag list + | X86 of x86_physinfo_cap_flag list type physinfo = -{ - threads_per_core : int; - cores_per_socket : int; - nr_cpus : int; - max_node_id : int; - cpu_khz : int; - total_pages : nativeint; - free_pages : nativeint; - scrub_pages : nativeint; - (* XXX hw_cap *) - capabilities : physinfo_cap_flag list; - max_nr_cpus : int; - arch_capabilities : arch_physinfo_cap_flags; -} + { + threads_per_core : int; + cores_per_socket : int; + nr_cpus : int; + max_node_id : int; + cpu_khz : int; + total_pages : nativeint; + free_pages : nativeint; + scrub_pages : nativeint; + (* XXX hw_cap *) + capabilities : physinfo_cap_flag list; + max_nr_cpus : int; + arch_capabilities : arch_physinfo_cap_flags; + } type version = -{ - major : int; - minor : int; - extra : string; -} + { + major : int; + minor : int; + extra : string; + } type compile_info = -{ - compiler : string; - compile_by : string; - compile_domain : string; - compile_date : string; -} + { + compiler : string; + compile_by : string; + compile_domain : string; + compile_date : string; + } type shutdown_reason = Poweroff | Reboot | Suspend | Crash | Watchdog | Soft_reset @@ -186,34 +186,34 @@ let handle = ref None let get_handle () = !handle let close_handle () = - match !handle with - | Some h -> handle := None; interface_close h - | None -> () + match !handle with + | Some h -> handle := None; interface_close h + | None -> () let with_intf f = - match !handle with - | Some h -> f h - | None -> - let h = - try interface_open () with - | e -> - let msg = Printexc.to_string e in - failwith ("failed to open xenctrl: "^msg) - in - handle := Some h; - f h + match !handle with + | Some h -> f h + | None -> + let h = + try interface_open () with + | e -> + let msg = Printexc.to_string e in + failwith ("failed to open xenctrl: "^msg) + in + handle := Some h; + f h external domain_create_stub: handle -> domid -> domctl_create_config -> domid - = "stub_xc_domain_create" + = "stub_xc_domain_create" let domain_create handle ?(domid=0) config = - domain_create_stub handle domid config + domain_create_stub handle domid config external domain_sethandle: handle -> domid -> string -> unit - = "stub_xc_domain_sethandle" + = "stub_xc_domain_sethandle" external domain_max_vcpus: handle -> domid -> int -> unit - = "stub_xc_domain_max_vcpus" + = "stub_xc_domain_max_vcpus" external domain_pause: handle -> domid -> unit = "stub_xc_domain_pause" external domain_unpause: handle -> domid -> unit = "stub_xc_domain_unpause" @@ -221,54 +221,54 @@ external domain_resume_fast: handle -> domid -> unit = "stub_xc_domain_resume_fa external domain_destroy: handle -> domid -> unit = "stub_xc_domain_destroy" external domain_shutdown: handle -> domid -> shutdown_reason -> unit - = "stub_xc_domain_shutdown" + = "stub_xc_domain_shutdown" external _domain_getinfolist: handle -> domid -> int -> domaininfo list - = "stub_xc_domain_getinfolist" + = "stub_xc_domain_getinfolist" let domain_getinfolist handle first_domain = - let nb = 2 in - let last_domid l = (List.hd l).domid + 1 in - let rec __getlist from = - let l = _domain_getinfolist handle from nb in - (if List.length l = nb then __getlist (last_domid l) else []) @ l - in - List.rev (__getlist first_domain) + let nb = 2 in + let last_domid l = (List.hd l).domid + 1 in + let rec __getlist from = + let l = _domain_getinfolist handle from nb in + (if List.length l = nb then __getlist (last_domid l) else []) @ l + in + List.rev (__getlist first_domain) external domain_getinfo: handle -> domid -> domaininfo= "stub_xc_domain_getinfo" external domain_get_vcpuinfo: handle -> int -> int -> vcpuinfo - = "stub_xc_vcpu_getinfo" + = "stub_xc_vcpu_getinfo" external domain_ioport_permission: handle -> domid -> int -> int -> bool -> unit - = "stub_xc_domain_ioport_permission" + = "stub_xc_domain_ioport_permission" external domain_iomem_permission: handle -> domid -> nativeint -> nativeint -> bool -> unit - = "stub_xc_domain_iomem_permission" + = "stub_xc_domain_iomem_permission" external domain_irq_permission: handle -> domid -> int -> bool -> unit - = "stub_xc_domain_irq_permission" + = "stub_xc_domain_irq_permission" external vcpu_affinity_set: handle -> domid -> int -> bool array -> unit - = "stub_xc_vcpu_setaffinity" + = "stub_xc_vcpu_setaffinity" external vcpu_affinity_get: handle -> domid -> int -> bool array - = "stub_xc_vcpu_getaffinity" + = "stub_xc_vcpu_getaffinity" external vcpu_context_get: handle -> domid -> int -> string - = "stub_xc_vcpu_context_get" + = "stub_xc_vcpu_context_get" external sched_id: handle -> int = "stub_xc_sched_id" external sched_credit_domain_set: handle -> domid -> sched_control -> unit - = "stub_sched_credit_domain_set" + = "stub_sched_credit_domain_set" external sched_credit_domain_get: handle -> domid -> sched_control - = "stub_sched_credit_domain_get" + = "stub_sched_credit_domain_get" external shadow_allocation_set: handle -> domid -> int -> unit - = "stub_shadow_allocation_set" + = "stub_shadow_allocation_set" external shadow_allocation_get: handle -> domid -> int - = "stub_shadow_allocation_get" + = "stub_shadow_allocation_get" external evtchn_alloc_unbound: handle -> domid -> domid -> int - = "stub_xc_evtchn_alloc_unbound" + = "stub_xc_evtchn_alloc_unbound" external evtchn_reset: handle -> domid -> unit = "stub_xc_evtchn_reset" external readconsolering: handle -> string = "stub_xc_readconsolering" @@ -278,26 +278,26 @@ external physinfo: handle -> physinfo = "stub_xc_physinfo" external pcpu_info: handle -> int -> int64 array = "stub_xc_pcpu_info" external domain_setmaxmem: handle -> domid -> int64 -> unit - = "stub_xc_domain_setmaxmem" + = "stub_xc_domain_setmaxmem" external domain_set_memmap_limit: handle -> domid -> int64 -> unit - = "stub_xc_domain_set_memmap_limit" + = "stub_xc_domain_set_memmap_limit" external domain_memory_increase_reservation: handle -> domid -> int64 -> unit - = "stub_xc_domain_memory_increase_reservation" + = "stub_xc_domain_memory_increase_reservation" external map_foreign_range: handle -> domid -> int - -> nativeint -> Xenmmap.mmap_interface - = "stub_map_foreign_range" + -> nativeint -> Xenmmap.mmap_interface + = "stub_map_foreign_range" external domain_assign_device: handle -> domid -> (int * int * int * int) -> unit - = "stub_xc_domain_assign_device" + = "stub_xc_domain_assign_device" external domain_deassign_device: handle -> domid -> (int * int * int * int) -> unit - = "stub_xc_domain_deassign_device" + = "stub_xc_domain_deassign_device" external domain_test_assign_device: handle -> domid -> (int * int * int * int) -> bool - = "stub_xc_domain_test_assign_device" + = "stub_xc_domain_test_assign_device" external version: handle -> version = "stub_xc_version_version" external version_compile_info: handle -> compile_info - = "stub_xc_version_compile_info" + = "stub_xc_version_compile_info" external version_changeset: handle -> string = "stub_xc_version_changeset" external version_capabilities: handle -> string = "stub_xc_version_capabilities" @@ -312,7 +312,7 @@ external watchdog : handle -> int -> int32 -> int (** Convert the given number of pages to an amount in KiB, rounded up. - *) +*) external pages_to_kib : int64 -> int64 = "stub_pages_to_kib" let pages_to_mib pages = Int64.div (pages_to_kib pages) 1024L diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index c2076d60c9..dd8d0aefcf 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -187,11 +187,11 @@ external domain_getinfo : handle -> domid -> domaininfo external domain_get_vcpuinfo : handle -> int -> int -> vcpuinfo = "stub_xc_vcpu_getinfo" external domain_ioport_permission: handle -> domid -> int -> int -> bool -> unit - = "stub_xc_domain_ioport_permission" + = "stub_xc_domain_ioport_permission" external domain_iomem_permission: handle -> domid -> nativeint -> nativeint -> bool -> unit - = "stub_xc_domain_iomem_permission" + = "stub_xc_domain_iomem_permission" external domain_irq_permission: handle -> domid -> int -> bool -> unit - = "stub_xc_domain_irq_permission" + = "stub_xc_domain_irq_permission" external vcpu_affinity_set : handle -> domid -> int -> bool array -> unit = "stub_xc_vcpu_setaffinity" external vcpu_affinity_get : handle -> domid -> int -> bool array @@ -226,11 +226,11 @@ external map_foreign_range : = "stub_map_foreign_range" external domain_assign_device: handle -> domid -> (int * int * int * int) -> unit - = "stub_xc_domain_assign_device" + = "stub_xc_domain_assign_device" external domain_deassign_device: handle -> domid -> (int * int * int * int) -> unit - = "stub_xc_domain_deassign_device" + = "stub_xc_domain_deassign_device" external domain_test_assign_device: handle -> domid -> (int * int * int * int) -> bool - = "stub_xc_domain_test_assign_device" + = "stub_xc_domain_test_assign_device" external version : handle -> version = "stub_xc_version_version" external version_compile_info : handle -> compile_info diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index 8cd11060ec..e2d897581f 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -45,71 +45,71 @@ #endif #define string_of_option_array(array, index) \ - ((Field(array, index) == Val_none) ? NULL : String_val(Field(Field(array, index), 0))) + ((Field(array, index) == Val_none) ? NULL : String_val(Field(Field(array, index), 0))) static void Noreturn failwith_xc(xc_interface *xch) { - char error_str[XC_MAX_ERROR_MSG_LEN + 6]; - if (xch) { - const xc_error *error = xc_get_last_error(xch); - if (error->code == XC_ERROR_NONE) - snprintf(error_str, sizeof(error_str), - "%d: %s", errno, strerror(errno)); - else - snprintf(error_str, sizeof(error_str), - "%d: %s: %s", error->code, - xc_error_code_to_desc(error->code), - error->message); - } else { - snprintf(error_str, sizeof(error_str), - "Unable to open XC interface"); - } - caml_raise_with_string(*caml_named_value("xc.error"), error_str); + char error_str[XC_MAX_ERROR_MSG_LEN + 6]; + if (xch) { + const xc_error *error = xc_get_last_error(xch); + if (error->code == XC_ERROR_NONE) + snprintf(error_str, sizeof(error_str), + "%d: %s", errno, strerror(errno)); + else + snprintf(error_str, sizeof(error_str), + "%d: %s: %s", error->code, + xc_error_code_to_desc(error->code), + error->message); + } else { + snprintf(error_str, sizeof(error_str), + "Unable to open XC interface"); + } + caml_raise_with_string(*caml_named_value("xc.error"), error_str); } CAMLprim value stub_xc_interface_open(void) { - CAMLparam0(); - CAMLlocal1(result); + CAMLparam0(); + CAMLlocal1(result); - result = caml_alloc(1, Abstract_tag); - /* Don't assert XC_OPENFLAG_NON_REENTRANT because these bindings - * do not prevent re-entrancy to libxc */ - _H(result) = xc_interface_open(NULL, NULL, 0); - if (_H(result) == NULL) - failwith_xc(NULL); - CAMLreturn(result); + result = caml_alloc(1, Abstract_tag); + /* Don't assert XC_OPENFLAG_NON_REENTRANT because these bindings + * do not prevent re-entrancy to libxc */ + _H(result) = xc_interface_open(NULL, NULL, 0); + if (_H(result) == NULL) + failwith_xc(NULL); + CAMLreturn(result); } CAMLprim value stub_xc_interface_close(value xch) { - CAMLparam1(xch); + CAMLparam1(xch); - caml_enter_blocking_section(); - xc_interface_close(_H(xch)); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + xc_interface_close(_H(xch)); + caml_leave_blocking_section(); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } static void domain_handle_of_uuid_string(xen_domain_handle_t h, - const char *uuid) + const char *uuid) { #define X "%02"SCNx8 #define UUID_FMT (X X X X "-" X X "-" X X "-" X X "-" X X X X X X) - if ( sscanf(uuid, UUID_FMT, &h[0], &h[1], &h[2], &h[3], &h[4], - &h[5], &h[6], &h[7], &h[8], &h[9], &h[10], &h[11], - &h[12], &h[13], &h[14], &h[15]) != 16 ) - { - char buf[128]; + if ( sscanf(uuid, UUID_FMT, &h[0], &h[1], &h[2], &h[3], &h[4], + &h[5], &h[6], &h[7], &h[8], &h[9], &h[10], &h[11], + &h[12], &h[13], &h[14], &h[15]) != 16 ) + { + char buf[128]; - snprintf(buf, sizeof(buf), - "Xc.int_array_of_uuid_string: %s", uuid); + snprintf(buf, sizeof(buf), + "Xc.int_array_of_uuid_string: %s", uuid); - caml_invalid_argument(buf); - } + caml_invalid_argument(buf); + } #undef X } @@ -121,13 +121,13 @@ static void domain_handle_of_uuid_string(xen_domain_handle_t h, static value c_bitmap_to_ocaml_list /* ! */ /* - * All calls to this function must be in a form suitable - * for xenctrl_abi_check. The parsing there is ad-hoc. - */ + * All calls to this function must be in a form suitable + * for xenctrl_abi_check. The parsing there is ad-hoc. + */ (unsigned int bitmap) { - CAMLparam0(); - CAMLlocal2(list, tmp); + CAMLparam0(); + CAMLlocal2(list, tmp); #if defined(__i386__) || defined(__x86_64__) /* @@ -144,43 +144,43 @@ static value c_bitmap_to_ocaml_list #include "xenctrl_abi_check.h" #endif - list = tmp = Val_emptylist; + list = tmp = Val_emptylist; - for ( unsigned int i = 0; bitmap; i++, bitmap >>= 1 ) - { - if ( !(bitmap & 1) ) - continue; + for ( unsigned int i = 0; bitmap; i++, bitmap >>= 1 ) + { + if ( !(bitmap & 1) ) + continue; - tmp = caml_alloc_small(2, Tag_cons); - Field(tmp, 0) = Val_int(i); - Field(tmp, 1) = list; - list = tmp; - } + tmp = caml_alloc_small(2, Tag_cons); + Field(tmp, 0) = Val_int(i); + Field(tmp, 1) = list; + list = tmp; + } - CAMLreturn(list); + CAMLreturn(list); } static unsigned int ocaml_list_to_c_bitmap(value l) /* ! */ /* - * All calls to this function must be in a form suitable - * for xenctrl_abi_check. The parsing there is ad-hoc. - */ + * All calls to this function must be in a form suitable + * for xenctrl_abi_check. The parsing there is ad-hoc. + */ { - unsigned int val = 0; + unsigned int val = 0; - for ( ; l != Val_none; l = Field(l, 1) ) - val |= 1u << Int_val(Field(l, 0)); + for ( ; l != Val_none; l = Field(l, 1) ) + val |= 1u << Int_val(Field(l, 0)); - return val; + return val; } CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config) { - CAMLparam3(xch, wanted_domid, config); - CAMLlocal2(l, arch_domconfig); + CAMLparam3(xch, wanted_domid, config); + CAMLlocal2(l, arch_domconfig); - /* Mnemonics for the named fields inside domctl_create_config */ + /* Mnemonics for the named fields inside domctl_create_config */ #define VAL_SSIDREF Field(config, 0) #define VAL_HANDLE Field(config, 1) #define VAL_FLAGS Field(config, 2) @@ -193,69 +193,69 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config #define VAL_CPUPOOL_ID Field(config, 9) #define VAL_ARCH Field(config, 10) - uint32_t domid = Int_val(wanted_domid); - int result; - struct xen_domctl_createdomain cfg = { - .ssidref = Int32_val(VAL_SSIDREF), - .max_vcpus = Int_val(VAL_MAX_VCPUS), - .max_evtchn_port = Int_val(VAL_MAX_EVTCHN_PORT), - .max_grant_frames = Int_val(VAL_MAX_GRANT_FRAMES), - .max_maptrack_frames = Int_val(VAL_MAX_MAPTRACK_FRAMES), - .grant_opts = - XEN_DOMCTL_GRANT_version(Int_val(VAL_MAX_GRANT_VERSION)), - .cpupool_id = Int32_val(VAL_CPUPOOL_ID), - }; + uint32_t domid = Int_val(wanted_domid); + int result; + struct xen_domctl_createdomain cfg = { + .ssidref = Int32_val(VAL_SSIDREF), + .max_vcpus = Int_val(VAL_MAX_VCPUS), + .max_evtchn_port = Int_val(VAL_MAX_EVTCHN_PORT), + .max_grant_frames = Int_val(VAL_MAX_GRANT_FRAMES), + .max_maptrack_frames = Int_val(VAL_MAX_MAPTRACK_FRAMES), + .grant_opts = + XEN_DOMCTL_GRANT_version(Int_val(VAL_MAX_GRANT_VERSION)), + .cpupool_id = Int32_val(VAL_CPUPOOL_ID), + }; - domain_handle_of_uuid_string(cfg.handle, String_val(VAL_HANDLE)); + domain_handle_of_uuid_string(cfg.handle, String_val(VAL_HANDLE)); - cfg.flags = ocaml_list_to_c_bitmap - /* ! domain_create_flag CDF_ lc */ - /* ! XEN_DOMCTL_CDF_ XEN_DOMCTL_CDF_MAX max */ - (VAL_FLAGS); + cfg.flags = ocaml_list_to_c_bitmap + /* ! domain_create_flag CDF_ lc */ + /* ! XEN_DOMCTL_CDF_ XEN_DOMCTL_CDF_MAX max */ + (VAL_FLAGS); - cfg.iommu_opts = ocaml_list_to_c_bitmap - /* ! domain_create_iommu_opts IOMMU_ lc */ - /* ! XEN_DOMCTL_IOMMU_ XEN_DOMCTL_IOMMU_MAX max */ - (VAL_IOMMU_OPTS); + cfg.iommu_opts = ocaml_list_to_c_bitmap + /* ! domain_create_iommu_opts IOMMU_ lc */ + /* ! XEN_DOMCTL_IOMMU_ XEN_DOMCTL_IOMMU_MAX max */ + (VAL_IOMMU_OPTS); - arch_domconfig = Field(VAL_ARCH, 0); - switch ( Tag_val(VAL_ARCH) ) - { - case 0: /* ARM - nothing to do */ - caml_failwith("Unhandled: ARM"); - break; + arch_domconfig = Field(VAL_ARCH, 0); + switch ( Tag_val(VAL_ARCH) ) + { + case 0: /* ARM - nothing to do */ + caml_failwith("Unhandled: ARM"); + break; - case 1: /* X86 - emulation flags in the block */ + case 1: /* X86 - emulation flags in the block */ #if defined(__i386__) || defined(__x86_64__) - /* Quick & dirty check for ABI changes. */ - BUILD_BUG_ON(sizeof(cfg) != 64); + /* Quick & dirty check for ABI changes. */ + BUILD_BUG_ON(sizeof(cfg) != 64); /* Mnemonics for the named fields inside xen_x86_arch_domainconfig */ #define VAL_EMUL_FLAGS Field(arch_domconfig, 0) #define VAL_MISC_FLAGS Field(arch_domconfig, 1) - cfg.arch.emulation_flags = ocaml_list_to_c_bitmap - /* ! x86_arch_emulation_flags X86_EMU_ none */ - /* ! XEN_X86_EMU_ XEN_X86_EMU_ALL all */ - (VAL_EMUL_FLAGS); + cfg.arch.emulation_flags = ocaml_list_to_c_bitmap + /* ! x86_arch_emulation_flags X86_EMU_ none */ + /* ! XEN_X86_EMU_ XEN_X86_EMU_ALL all */ + (VAL_EMUL_FLAGS); - cfg.arch.misc_flags = ocaml_list_to_c_bitmap - /* ! x86_arch_misc_flags X86_ none */ - /* ! XEN_X86_ XEN_X86_MISC_FLAGS_MAX max */ - (VAL_MISC_FLAGS); + cfg.arch.misc_flags = ocaml_list_to_c_bitmap + /* ! x86_arch_misc_flags X86_ none */ + /* ! XEN_X86_ XEN_X86_MISC_FLAGS_MAX max */ + (VAL_MISC_FLAGS); #undef VAL_MISC_FLAGS #undef VAL_EMUL_FLAGS #else - caml_failwith("Unhandled: x86"); + caml_failwith("Unhandled: x86"); #endif - break; + break; - default: - caml_failwith("Unhandled domconfig type"); - } + default: + caml_failwith("Unhandled domconfig type"); + } #undef VAL_ARCH #undef VAL_CPUPOOL_ID @@ -269,875 +269,875 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config #undef VAL_HANDLE #undef VAL_SSIDREF - caml_enter_blocking_section(); - result = xc_domain_create(_H(xch), &domid, &cfg); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + result = xc_domain_create(_H(xch), &domid, &cfg); + caml_leave_blocking_section(); - if (result < 0) - failwith_xc(_H(xch)); + if (result < 0) + failwith_xc(_H(xch)); - CAMLreturn(Val_int(domid)); + CAMLreturn(Val_int(domid)); } CAMLprim value stub_xc_domain_max_vcpus(value xch, value domid, value max_vcpus) { - CAMLparam3(xch, domid, max_vcpus); - int r; + CAMLparam3(xch, domid, max_vcpus); + int r; - r = xc_domain_max_vcpus(_H(xch), _D(domid), Int_val(max_vcpus)); - if (r) - failwith_xc(_H(xch)); + r = xc_domain_max_vcpus(_H(xch), _D(domid), Int_val(max_vcpus)); + if (r) + failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } value stub_xc_domain_sethandle(value xch, value domid, value handle) { - CAMLparam3(xch, domid, handle); - xen_domain_handle_t h; - int i; + CAMLparam3(xch, domid, handle); + xen_domain_handle_t h; + int i; - domain_handle_of_uuid_string(h, String_val(handle)); + domain_handle_of_uuid_string(h, String_val(handle)); - i = xc_domain_sethandle(_H(xch), _D(domid), h); - if (i) - failwith_xc(_H(xch)); + i = xc_domain_sethandle(_H(xch), _D(domid), h); + if (i) + failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } static value dom_op(value xch, value domid, int (*fn)(xc_interface *, uint32_t)) { - CAMLparam2(xch, domid); - int result; + CAMLparam2(xch, domid); + int result; - uint32_t c_domid = _D(domid); + uint32_t c_domid = _D(domid); - caml_enter_blocking_section(); - result = fn(_H(xch), c_domid); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + result = fn(_H(xch), c_domid); + caml_leave_blocking_section(); if (result) - failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + failwith_xc(_H(xch)); + CAMLreturn(Val_unit); } CAMLprim value stub_xc_domain_pause(value xch, value domid) { - return dom_op(xch, domid, xc_domain_pause); + return dom_op(xch, domid, xc_domain_pause); } CAMLprim value stub_xc_domain_unpause(value xch, value domid) { - return dom_op(xch, domid, xc_domain_unpause); + return dom_op(xch, domid, xc_domain_unpause); } CAMLprim value stub_xc_domain_destroy(value xch, value domid) { - return dom_op(xch, domid, xc_domain_destroy); + return dom_op(xch, domid, xc_domain_destroy); } CAMLprim value stub_xc_domain_resume_fast(value xch, value domid) { - CAMLparam2(xch, domid); - int result; + CAMLparam2(xch, domid); + int result; - uint32_t c_domid = _D(domid); + uint32_t c_domid = _D(domid); - caml_enter_blocking_section(); - result = xc_domain_resume(_H(xch), c_domid, 1); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + result = xc_domain_resume(_H(xch), c_domid, 1); + caml_leave_blocking_section(); if (result) - failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + failwith_xc(_H(xch)); + CAMLreturn(Val_unit); } CAMLprim value stub_xc_domain_shutdown(value xch, value domid, value reason) { - CAMLparam3(xch, domid, reason); - int ret; + CAMLparam3(xch, domid, reason); + int ret; - ret = xc_domain_shutdown(_H(xch), _D(domid), Int_val(reason)); - if (ret < 0) - failwith_xc(_H(xch)); + ret = xc_domain_shutdown(_H(xch), _D(domid), Int_val(reason)); + if (ret < 0) + failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } static value alloc_domaininfo(xc_domaininfo_t * info) { - CAMLparam0(); - CAMLlocal5(result, tmp, arch_config, x86_arch_config, emul_list); - int i; + CAMLparam0(); + CAMLlocal5(result, tmp, arch_config, x86_arch_config, emul_list); + int i; - result = caml_alloc_tuple(17); + result = caml_alloc_tuple(17); - Store_field(result, 0, Val_int(info->domain)); - Store_field(result, 1, Val_bool(info->flags & XEN_DOMINF_dying)); - Store_field(result, 2, Val_bool(info->flags & XEN_DOMINF_shutdown)); - Store_field(result, 3, Val_bool(info->flags & XEN_DOMINF_paused)); - Store_field(result, 4, Val_bool(info->flags & XEN_DOMINF_blocked)); - Store_field(result, 5, Val_bool(info->flags & XEN_DOMINF_running)); - Store_field(result, 6, Val_bool(info->flags & XEN_DOMINF_hvm_guest)); - Store_field(result, 7, Val_int((info->flags >> XEN_DOMINF_shutdownshift) - & XEN_DOMINF_shutdownmask)); - Store_field(result, 8, caml_copy_nativeint(info->tot_pages)); - Store_field(result, 9, caml_copy_nativeint(info->max_pages)); - Store_field(result, 10, caml_copy_int64(info->shared_info_frame)); - Store_field(result, 11, caml_copy_int64(info->cpu_time)); - Store_field(result, 12, Val_int(info->nr_online_vcpus)); - Store_field(result, 13, Val_int(info->max_vcpu_id)); - Store_field(result, 14, caml_copy_int32(info->ssidref)); + Store_field(result, 0, Val_int(info->domain)); + Store_field(result, 1, Val_bool(info->flags & XEN_DOMINF_dying)); + Store_field(result, 2, Val_bool(info->flags & XEN_DOMINF_shutdown)); + Store_field(result, 3, Val_bool(info->flags & XEN_DOMINF_paused)); + Store_field(result, 4, Val_bool(info->flags & XEN_DOMINF_blocked)); + Store_field(result, 5, Val_bool(info->flags & XEN_DOMINF_running)); + Store_field(result, 6, Val_bool(info->flags & XEN_DOMINF_hvm_guest)); + Store_field(result, 7, Val_int((info->flags >> XEN_DOMINF_shutdownshift) + & XEN_DOMINF_shutdownmask)); + Store_field(result, 8, caml_copy_nativeint(info->tot_pages)); + Store_field(result, 9, caml_copy_nativeint(info->max_pages)); + Store_field(result, 10, caml_copy_int64(info->shared_info_frame)); + Store_field(result, 11, caml_copy_int64(info->cpu_time)); + Store_field(result, 12, Val_int(info->nr_online_vcpus)); + Store_field(result, 13, Val_int(info->max_vcpu_id)); + Store_field(result, 14, caml_copy_int32(info->ssidref)); tmp = caml_alloc_small(16, 0); - for (i = 0; i < 16; i++) { - Field(tmp, i) = Val_int(info->handle[i]); - } + for (i = 0; i < 16; i++) { + Field(tmp, i) = Val_int(info->handle[i]); + } - Store_field(result, 15, tmp); + Store_field(result, 15, tmp); #if defined(__i386__) || defined(__x86_64__) - /* - * emulation_flags: x86_arch_emulation_flags list; - */ - emul_list = c_bitmap_to_ocaml_list - /* ! x86_arch_emulation_flags */ - (info->arch_config.emulation_flags); + /* + * emulation_flags: x86_arch_emulation_flags list; + */ + emul_list = c_bitmap_to_ocaml_list + /* ! x86_arch_emulation_flags */ + (info->arch_config.emulation_flags); - /* xen_x86_arch_domainconfig */ - x86_arch_config = caml_alloc_tuple(1); - Store_field(x86_arch_config, 0, emul_list); + /* xen_x86_arch_domainconfig */ + x86_arch_config = caml_alloc_tuple(1); + Store_field(x86_arch_config, 0, emul_list); - /* arch_config: arch_domainconfig */ - arch_config = caml_alloc_small(1, 1); + /* arch_config: arch_domainconfig */ + arch_config = caml_alloc_small(1, 1); - Store_field(arch_config, 0, x86_arch_config); + Store_field(arch_config, 0, x86_arch_config); - Store_field(result, 16, arch_config); + Store_field(result, 16, arch_config); #endif - CAMLreturn(result); + CAMLreturn(result); } CAMLprim value stub_xc_domain_getinfolist(value xch, value first_domain, value nb) { - CAMLparam3(xch, first_domain, nb); - CAMLlocal2(result, temp); - xc_domaininfo_t * info; - int i, ret, toalloc, retval; - unsigned int c_max_domains; - uint32_t c_first_domain; + CAMLparam3(xch, first_domain, nb); + CAMLlocal2(result, temp); + xc_domaininfo_t * info; + int i, ret, toalloc, retval; + unsigned int c_max_domains; + uint32_t c_first_domain; - /* get the minimum number of allocate byte we need and bump it up to page boundary */ - toalloc = (sizeof(xc_domaininfo_t) * Int_val(nb)) | 0xfff; - ret = posix_memalign((void **) ((void *) &info), 4096, toalloc); - if (ret) - caml_raise_out_of_memory(); + /* get the minimum number of allocate byte we need and bump it up to page boundary */ + toalloc = (sizeof(xc_domaininfo_t) * Int_val(nb)) | 0xfff; + ret = posix_memalign((void **) ((void *) &info), 4096, toalloc); + if (ret) + caml_raise_out_of_memory(); - result = temp = Val_emptylist; + result = temp = Val_emptylist; - c_first_domain = _D(first_domain); - c_max_domains = Int_val(nb); - caml_enter_blocking_section(); - retval = xc_domain_getinfolist(_H(xch), c_first_domain, - c_max_domains, info); - caml_leave_blocking_section(); + c_first_domain = _D(first_domain); + c_max_domains = Int_val(nb); + caml_enter_blocking_section(); + retval = xc_domain_getinfolist(_H(xch), c_first_domain, + c_max_domains, info); + caml_leave_blocking_section(); - if (retval < 0) { - free(info); - failwith_xc(_H(xch)); - } - for (i = 0; i < retval; i++) { - result = caml_alloc_small(2, Tag_cons); - Field(result, 0) = Val_int(0); - Field(result, 1) = temp; - temp = result; + if (retval < 0) { + free(info); + failwith_xc(_H(xch)); + } + for (i = 0; i < retval; i++) { + result = caml_alloc_small(2, Tag_cons); + Field(result, 0) = Val_int(0); + Field(result, 1) = temp; + temp = result; - Store_field(result, 0, alloc_domaininfo(info + i)); - } + Store_field(result, 0, alloc_domaininfo(info + i)); + } - free(info); - CAMLreturn(result); + free(info); + CAMLreturn(result); } CAMLprim value stub_xc_domain_getinfo(value xch, value domid) { - CAMLparam2(xch, domid); - CAMLlocal1(result); - xc_domaininfo_t info; - int ret; + CAMLparam2(xch, domid); + CAMLlocal1(result); + xc_domaininfo_t info; + int ret; - ret = xc_domain_getinfolist(_H(xch), _D(domid), 1, &info); - if (ret != 1) - failwith_xc(_H(xch)); - if (info.domain != _D(domid)) - failwith_xc(_H(xch)); + ret = xc_domain_getinfolist(_H(xch), _D(domid), 1, &info); + if (ret != 1) + failwith_xc(_H(xch)); + if (info.domain != _D(domid)) + failwith_xc(_H(xch)); - result = alloc_domaininfo(&info); - CAMLreturn(result); + result = alloc_domaininfo(&info); + CAMLreturn(result); } CAMLprim value stub_xc_vcpu_getinfo(value xch, value domid, value vcpu) { - CAMLparam3(xch, domid, vcpu); - CAMLlocal1(result); - xc_vcpuinfo_t info; - int retval; + CAMLparam3(xch, domid, vcpu); + CAMLlocal1(result); + xc_vcpuinfo_t info; + int retval; - uint32_t c_domid = _D(domid); - uint32_t c_vcpu = Int_val(vcpu); - caml_enter_blocking_section(); - retval = xc_vcpu_getinfo(_H(xch), c_domid, - c_vcpu, &info); - caml_leave_blocking_section(); - if (retval < 0) - failwith_xc(_H(xch)); + uint32_t c_domid = _D(domid); + uint32_t c_vcpu = Int_val(vcpu); + caml_enter_blocking_section(); + retval = xc_vcpu_getinfo(_H(xch), c_domid, + c_vcpu, &info); + caml_leave_blocking_section(); + if (retval < 0) + failwith_xc(_H(xch)); - result = caml_alloc_tuple(5); - Store_field(result, 0, Val_bool(info.online)); - Store_field(result, 1, Val_bool(info.blocked)); - Store_field(result, 2, Val_bool(info.running)); - Store_field(result, 3, caml_copy_int64(info.cpu_time)); - Store_field(result, 4, caml_copy_int32(info.cpu)); + result = caml_alloc_tuple(5); + Store_field(result, 0, Val_bool(info.online)); + Store_field(result, 1, Val_bool(info.blocked)); + Store_field(result, 2, Val_bool(info.running)); + Store_field(result, 3, caml_copy_int64(info.cpu_time)); + Store_field(result, 4, caml_copy_int32(info.cpu)); - CAMLreturn(result); + CAMLreturn(result); } CAMLprim value stub_xc_vcpu_context_get(value xch, value domid, value cpu) { - CAMLparam3(xch, domid, cpu); - CAMLlocal1(context); - int ret; - vcpu_guest_context_any_t ctxt; + CAMLparam3(xch, domid, cpu); + CAMLlocal1(context); + int ret; + vcpu_guest_context_any_t ctxt; - ret = xc_vcpu_getcontext(_H(xch), _D(domid), Int_val(cpu), &ctxt); - if ( ret < 0 ) - failwith_xc(_H(xch)); + ret = xc_vcpu_getcontext(_H(xch), _D(domid), Int_val(cpu), &ctxt); + if ( ret < 0 ) + failwith_xc(_H(xch)); - context = caml_alloc_string(sizeof(ctxt)); - memcpy((char *) String_val(context), &ctxt.c, sizeof(ctxt.c)); + context = caml_alloc_string(sizeof(ctxt)); + memcpy((char *) String_val(context), &ctxt.c, sizeof(ctxt.c)); - CAMLreturn(context); + CAMLreturn(context); } static int get_cpumap_len(value xch, value cpumap) { - int ml_len = Wosize_val(cpumap); - int xc_len = xc_get_max_cpus(_H(xch)); + int ml_len = Wosize_val(cpumap); + int xc_len = xc_get_max_cpus(_H(xch)); - if (ml_len < xc_len) - return ml_len; - else - return xc_len; + if (ml_len < xc_len) + return ml_len; + else + return xc_len; } CAMLprim value stub_xc_vcpu_setaffinity(value xch, value domid, value vcpu, value cpumap) { - CAMLparam4(xch, domid, vcpu, cpumap); - int i, len = get_cpumap_len(xch, cpumap); - xc_cpumap_t c_cpumap; - int retval; + CAMLparam4(xch, domid, vcpu, cpumap); + int i, len = get_cpumap_len(xch, cpumap); + xc_cpumap_t c_cpumap; + int retval; - c_cpumap = xc_cpumap_alloc(_H(xch)); - if (c_cpumap == NULL) - failwith_xc(_H(xch)); + c_cpumap = xc_cpumap_alloc(_H(xch)); + if (c_cpumap == NULL) + failwith_xc(_H(xch)); - for (i=0; i= 0) { - size += count - 1; - if (size < count) - break; + while (count == size && ret >= 0) { + size += count - 1; + if (size < count) + break; - ptr = realloc(str, size); - if (!ptr) - break; + ptr = realloc(str, size); + if (!ptr) + break; - str = ptr + count; - count = size - count; + str = ptr + count; + count = size - count; - caml_enter_blocking_section(); - ret = xc_readconsolering(_H(xch), str, &count, 0, 1, &index); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = xc_readconsolering(_H(xch), str, &count, 0, 1, &index); + caml_leave_blocking_section(); - count += str - ptr; - str = ptr; - } + count += str - ptr; + str = ptr; + } - /* - * If we didn't break because of an overflow with size, and we have - * needed to realloc() ourself more space, update our tracking of the - * real console ring size. - */ - if (size > conring_size) - conring_size = size; + /* + * If we didn't break because of an overflow with size, and we have + * needed to realloc() ourself more space, update our tracking of the + * real console ring size. + */ + if (size > conring_size) + conring_size = size; - ring = caml_alloc_string(count); - memcpy((char *) String_val(ring), str, count); - free(str); + ring = caml_alloc_string(count); + memcpy((char *) String_val(ring), str, count); + free(str); - CAMLreturn(ring); + CAMLreturn(ring); } CAMLprim value stub_xc_send_debug_keys(value xch, value keys) { - CAMLparam2(xch, keys); - int r; + CAMLparam2(xch, keys); + int r; - r = xc_send_debug_keys(_H(xch), String_val(keys)); - if (r) - failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + r = xc_send_debug_keys(_H(xch), String_val(keys)); + if (r) + failwith_xc(_H(xch)); + CAMLreturn(Val_unit); } CAMLprim value stub_xc_physinfo(value xch) { - CAMLparam1(xch); - CAMLlocal4(physinfo, cap_list, arch_cap_flags, arch_cap_list); - xc_physinfo_t c_physinfo; - int r, arch_cap_flags_tag; + CAMLparam1(xch); + CAMLlocal4(physinfo, cap_list, arch_cap_flags, arch_cap_list); + xc_physinfo_t c_physinfo; + int r, arch_cap_flags_tag; - caml_enter_blocking_section(); - r = xc_physinfo(_H(xch), &c_physinfo); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + r = xc_physinfo(_H(xch), &c_physinfo); + caml_leave_blocking_section(); - if (r) - failwith_xc(_H(xch)); + if (r) + failwith_xc(_H(xch)); - /* - * capabilities: physinfo_cap_flag list; - */ - cap_list = c_bitmap_to_ocaml_list - /* ! physinfo_cap_flag CAP_ lc */ - /* ! XEN_SYSCTL_PHYSCAP_ XEN_SYSCTL_PHYSCAP_MAX max */ - (c_physinfo.capabilities); + /* + * capabilities: physinfo_cap_flag list; + */ + cap_list = c_bitmap_to_ocaml_list + /* ! physinfo_cap_flag CAP_ lc */ + /* ! XEN_SYSCTL_PHYSCAP_ XEN_SYSCTL_PHYSCAP_MAX max */ + (c_physinfo.capabilities); - physinfo = caml_alloc_tuple(11); - Store_field(physinfo, 0, Val_int(c_physinfo.threads_per_core)); - Store_field(physinfo, 1, Val_int(c_physinfo.cores_per_socket)); - Store_field(physinfo, 2, Val_int(c_physinfo.nr_cpus)); - Store_field(physinfo, 3, Val_int(c_physinfo.max_node_id)); - Store_field(physinfo, 4, Val_int(c_physinfo.cpu_khz)); - Store_field(physinfo, 5, caml_copy_nativeint(c_physinfo.total_pages)); - Store_field(physinfo, 6, caml_copy_nativeint(c_physinfo.free_pages)); - Store_field(physinfo, 7, caml_copy_nativeint(c_physinfo.scrub_pages)); - Store_field(physinfo, 8, cap_list); - Store_field(physinfo, 9, Val_int(c_physinfo.max_cpu_id + 1)); + physinfo = caml_alloc_tuple(11); + Store_field(physinfo, 0, Val_int(c_physinfo.threads_per_core)); + Store_field(physinfo, 1, Val_int(c_physinfo.cores_per_socket)); + Store_field(physinfo, 2, Val_int(c_physinfo.nr_cpus)); + Store_field(physinfo, 3, Val_int(c_physinfo.max_node_id)); + Store_field(physinfo, 4, Val_int(c_physinfo.cpu_khz)); + Store_field(physinfo, 5, caml_copy_nativeint(c_physinfo.total_pages)); + Store_field(physinfo, 6, caml_copy_nativeint(c_physinfo.free_pages)); + Store_field(physinfo, 7, caml_copy_nativeint(c_physinfo.scrub_pages)); + Store_field(physinfo, 8, cap_list); + Store_field(physinfo, 9, Val_int(c_physinfo.max_cpu_id + 1)); #if defined(__i386__) || defined(__x86_64__) - arch_cap_list = c_bitmap_to_ocaml_list - /* ! x86_physinfo_cap_flag CAP_X86_ none */ - /* ! XEN_SYSCTL_PHYSCAP_X86_ XEN_SYSCTL_PHYSCAP_X86_MAX max */ - (c_physinfo.arch_capabilities); + arch_cap_list = c_bitmap_to_ocaml_list + /* ! x86_physinfo_cap_flag CAP_X86_ none */ + /* ! XEN_SYSCTL_PHYSCAP_X86_ XEN_SYSCTL_PHYSCAP_X86_MAX max */ + (c_physinfo.arch_capabilities); - arch_cap_flags_tag = 1; /* tag x86 */ + arch_cap_flags_tag = 1; /* tag x86 */ #else - caml_failwith("Unhandled architecture"); + caml_failwith("Unhandled architecture"); #endif - arch_cap_flags = caml_alloc_small(1, arch_cap_flags_tag); - Store_field(arch_cap_flags, 0, arch_cap_list); - Store_field(physinfo, 10, arch_cap_flags); + arch_cap_flags = caml_alloc_small(1, arch_cap_flags_tag); + Store_field(arch_cap_flags, 0, arch_cap_list); + Store_field(physinfo, 10, arch_cap_flags); - CAMLreturn(physinfo); + CAMLreturn(physinfo); } CAMLprim value stub_xc_pcpu_info(value xch, value nr_cpus) { - CAMLparam2(xch, nr_cpus); - CAMLlocal2(pcpus, v); - xc_cpuinfo_t *info; - int r, size; + CAMLparam2(xch, nr_cpus); + CAMLlocal2(pcpus, v); + xc_cpuinfo_t *info; + int r, size; - if (Int_val(nr_cpus) < 1) - caml_invalid_argument("nr_cpus"); + if (Int_val(nr_cpus) < 1) + caml_invalid_argument("nr_cpus"); - info = calloc(Int_val(nr_cpus) + 1, sizeof(*info)); - if (!info) - caml_raise_out_of_memory(); + info = calloc(Int_val(nr_cpus) + 1, sizeof(*info)); + if (!info) + caml_raise_out_of_memory(); - caml_enter_blocking_section(); - r = xc_getcpuinfo(_H(xch), Int_val(nr_cpus), info, &size); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + r = xc_getcpuinfo(_H(xch), Int_val(nr_cpus), info, &size); + caml_leave_blocking_section(); - if (r) { - free(info); - failwith_xc(_H(xch)); - } + if (r) { + free(info); + failwith_xc(_H(xch)); + } - if (size > 0) { - int i; - pcpus = caml_alloc(size, 0); - for (i = 0; i < size; i++) { - v = caml_copy_int64(info[i].idletime); - caml_modify(&Field(pcpus, i), v); - } - } else - pcpus = Atom(0); - free(info); - CAMLreturn(pcpus); + if (size > 0) { + int i; + pcpus = caml_alloc(size, 0); + for (i = 0; i < size; i++) { + v = caml_copy_int64(info[i].idletime); + caml_modify(&Field(pcpus, i), v); + } + } else + pcpus = Atom(0); + free(info); + CAMLreturn(pcpus); } CAMLprim value stub_xc_domain_setmaxmem(value xch, value domid, value max_memkb) { - CAMLparam3(xch, domid, max_memkb); - int retval; + CAMLparam3(xch, domid, max_memkb); + int retval; - uint32_t c_domid = _D(domid); - unsigned int c_max_memkb = Int64_val(max_memkb); - caml_enter_blocking_section(); - retval = xc_domain_setmaxmem(_H(xch), c_domid, - c_max_memkb); - caml_leave_blocking_section(); - if (retval) - failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + uint32_t c_domid = _D(domid); + unsigned int c_max_memkb = Int64_val(max_memkb); + caml_enter_blocking_section(); + retval = xc_domain_setmaxmem(_H(xch), c_domid, + c_max_memkb); + caml_leave_blocking_section(); + if (retval) + failwith_xc(_H(xch)); + CAMLreturn(Val_unit); } CAMLprim value stub_xc_domain_set_memmap_limit(value xch, value domid, value map_limitkb) { - CAMLparam3(xch, domid, map_limitkb); - unsigned long v; - int retval; + CAMLparam3(xch, domid, map_limitkb); + unsigned long v; + int retval; - v = Int64_val(map_limitkb); - retval = xc_domain_set_memmap_limit(_H(xch), _D(domid), v); - if (retval) - failwith_xc(_H(xch)); + v = Int64_val(map_limitkb); + retval = xc_domain_set_memmap_limit(_H(xch), _D(domid), v); + if (retval) + failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } CAMLprim value stub_xc_domain_memory_increase_reservation(value xch, value domid, value mem_kb) { - CAMLparam3(xch, domid, mem_kb); - int retval; + CAMLparam3(xch, domid, mem_kb); + int retval; - unsigned long nr_extents = ((unsigned long)(Int64_val(mem_kb))) >> (XC_PAGE_SHIFT - 10); + unsigned long nr_extents = ((unsigned long)(Int64_val(mem_kb))) >> (XC_PAGE_SHIFT - 10); - uint32_t c_domid = _D(domid); - caml_enter_blocking_section(); - retval = xc_domain_increase_reservation_exact(_H(xch), c_domid, - nr_extents, 0, 0, NULL); - caml_leave_blocking_section(); + uint32_t c_domid = _D(domid); + caml_enter_blocking_section(); + retval = xc_domain_increase_reservation_exact(_H(xch), c_domid, + nr_extents, 0, 0, NULL); + caml_leave_blocking_section(); - if (retval) - failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + if (retval) + failwith_xc(_H(xch)); + CAMLreturn(Val_unit); } CAMLprim value stub_xc_version_version(value xch) { - CAMLparam1(xch); - CAMLlocal1(result); - xen_extraversion_t extra; - long packed; - int retval; + CAMLparam1(xch); + CAMLlocal1(result); + xen_extraversion_t extra; + long packed; + int retval; - caml_enter_blocking_section(); - packed = xc_version(_H(xch), XENVER_version, NULL); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + packed = xc_version(_H(xch), XENVER_version, NULL); + caml_leave_blocking_section(); - if (packed < 0) - failwith_xc(_H(xch)); + if (packed < 0) + failwith_xc(_H(xch)); - caml_enter_blocking_section(); - retval = xc_version(_H(xch), XENVER_extraversion, &extra); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + retval = xc_version(_H(xch), XENVER_extraversion, &extra); + caml_leave_blocking_section(); - if (retval) - failwith_xc(_H(xch)); + if (retval) + failwith_xc(_H(xch)); - result = caml_alloc_tuple(3); + result = caml_alloc_tuple(3); - Store_field(result, 0, Val_int(packed >> 16)); - Store_field(result, 1, Val_int(packed & 0xffff)); - Store_field(result, 2, caml_copy_string(extra)); + Store_field(result, 0, Val_int(packed >> 16)); + Store_field(result, 1, Val_int(packed & 0xffff)); + Store_field(result, 2, caml_copy_string(extra)); - CAMLreturn(result); + CAMLreturn(result); } CAMLprim value stub_xc_version_compile_info(value xch) { - CAMLparam1(xch); - CAMLlocal1(result); - xen_compile_info_t ci; - int retval; + CAMLparam1(xch); + CAMLlocal1(result); + xen_compile_info_t ci; + int retval; - caml_enter_blocking_section(); - retval = xc_version(_H(xch), XENVER_compile_info, &ci); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + retval = xc_version(_H(xch), XENVER_compile_info, &ci); + caml_leave_blocking_section(); - if (retval) - failwith_xc(_H(xch)); + if (retval) + failwith_xc(_H(xch)); - result = caml_alloc_tuple(4); + result = caml_alloc_tuple(4); - Store_field(result, 0, caml_copy_string(ci.compiler)); - Store_field(result, 1, caml_copy_string(ci.compile_by)); - Store_field(result, 2, caml_copy_string(ci.compile_domain)); - Store_field(result, 3, caml_copy_string(ci.compile_date)); + Store_field(result, 0, caml_copy_string(ci.compiler)); + Store_field(result, 1, caml_copy_string(ci.compile_by)); + Store_field(result, 2, caml_copy_string(ci.compile_domain)); + Store_field(result, 3, caml_copy_string(ci.compile_date)); - CAMLreturn(result); + CAMLreturn(result); } static value xc_version_single_string(value xch, int code, void *info) { - CAMLparam1(xch); - int retval; + CAMLparam1(xch); + int retval; - caml_enter_blocking_section(); - retval = xc_version(_H(xch), code, info); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + retval = xc_version(_H(xch), code, info); + caml_leave_blocking_section(); - if (retval) - failwith_xc(_H(xch)); + if (retval) + failwith_xc(_H(xch)); - CAMLreturn(caml_copy_string((char *)info)); + CAMLreturn(caml_copy_string((char *)info)); } CAMLprim value stub_xc_version_changeset(value xch) { - xen_changeset_info_t ci; + xen_changeset_info_t ci; - return xc_version_single_string(xch, XENVER_changeset, &ci); + return xc_version_single_string(xch, XENVER_changeset, &ci); } CAMLprim value stub_xc_version_capabilities(value xch) { - xen_capabilities_info_t ci; + xen_capabilities_info_t ci; - return xc_version_single_string(xch, XENVER_capabilities, &ci); + return xc_version_single_string(xch, XENVER_capabilities, &ci); } CAMLprim value stub_pages_to_kib(value pages) { - CAMLparam1(pages); + CAMLparam1(pages); - CAMLreturn(caml_copy_int64(Int64_val(pages) << (XC_PAGE_SHIFT - 10))); + CAMLreturn(caml_copy_int64(Int64_val(pages) << (XC_PAGE_SHIFT - 10))); } CAMLprim value stub_map_foreign_range(value xch, value dom, value size, value mfn) { - CAMLparam4(xch, dom, size, mfn); - CAMLlocal1(result); - struct mmap_interface *intf; - uint32_t c_dom; - unsigned long c_mfn; + CAMLparam4(xch, dom, size, mfn); + CAMLlocal1(result); + struct mmap_interface *intf; + uint32_t c_dom; + unsigned long c_mfn; - result = caml_alloc(sizeof(struct mmap_interface), Abstract_tag); - intf = (struct mmap_interface *) result; + result = caml_alloc(sizeof(struct mmap_interface), Abstract_tag); + intf = (struct mmap_interface *) result; - intf->len = Int_val(size); + intf->len = Int_val(size); - c_dom = _D(dom); - c_mfn = Nativeint_val(mfn); - caml_enter_blocking_section(); - intf->addr = xc_map_foreign_range(_H(xch), c_dom, - intf->len, PROT_READ|PROT_WRITE, - c_mfn); - caml_leave_blocking_section(); - if (!intf->addr) - caml_failwith("xc_map_foreign_range error"); - CAMLreturn(result); + c_dom = _D(dom); + c_mfn = Nativeint_val(mfn); + caml_enter_blocking_section(); + intf->addr = xc_map_foreign_range(_H(xch), c_dom, + intf->len, PROT_READ|PROT_WRITE, + c_mfn); + caml_leave_blocking_section(); + if (!intf->addr) + caml_failwith("xc_map_foreign_range error"); + CAMLreturn(result); } CAMLprim value stub_sched_credit_domain_get(value xch, value domid) { - CAMLparam2(xch, domid); - CAMLlocal1(sdom); - struct xen_domctl_sched_credit c_sdom; - int ret; + CAMLparam2(xch, domid); + CAMLlocal1(sdom); + struct xen_domctl_sched_credit c_sdom; + int ret; - caml_enter_blocking_section(); - ret = xc_sched_credit_domain_get(_H(xch), _D(domid), &c_sdom); - caml_leave_blocking_section(); - if (ret != 0) - failwith_xc(_H(xch)); + caml_enter_blocking_section(); + ret = xc_sched_credit_domain_get(_H(xch), _D(domid), &c_sdom); + caml_leave_blocking_section(); + if (ret != 0) + failwith_xc(_H(xch)); - sdom = caml_alloc_tuple(2); - Store_field(sdom, 0, Val_int(c_sdom.weight)); - Store_field(sdom, 1, Val_int(c_sdom.cap)); + sdom = caml_alloc_tuple(2); + Store_field(sdom, 0, Val_int(c_sdom.weight)); + Store_field(sdom, 1, Val_int(c_sdom.cap)); - CAMLreturn(sdom); + CAMLreturn(sdom); } CAMLprim value stub_sched_credit_domain_set(value xch, value domid, value sdom) { - CAMLparam3(xch, domid, sdom); - struct xen_domctl_sched_credit c_sdom; - int ret; + CAMLparam3(xch, domid, sdom); + struct xen_domctl_sched_credit c_sdom; + int ret; - c_sdom.weight = Int_val(Field(sdom, 0)); - c_sdom.cap = Int_val(Field(sdom, 1)); - caml_enter_blocking_section(); - ret = xc_sched_credit_domain_set(_H(xch), _D(domid), &c_sdom); - caml_leave_blocking_section(); - if (ret != 0) - failwith_xc(_H(xch)); + c_sdom.weight = Int_val(Field(sdom, 0)); + c_sdom.cap = Int_val(Field(sdom, 1)); + caml_enter_blocking_section(); + ret = xc_sched_credit_domain_set(_H(xch), _D(domid), &c_sdom); + caml_leave_blocking_section(); + if (ret != 0) + failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } CAMLprim value stub_shadow_allocation_get(value xch, value domid) { - CAMLparam2(xch, domid); - CAMLlocal1(mb); - unsigned int c_mb; - int ret; + CAMLparam2(xch, domid); + CAMLlocal1(mb); + unsigned int c_mb; + int ret; - caml_enter_blocking_section(); - ret = xc_shadow_control(_H(xch), _D(domid), - XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION, - &c_mb, 0); - caml_leave_blocking_section(); - if (ret != 0) - failwith_xc(_H(xch)); + caml_enter_blocking_section(); + ret = xc_shadow_control(_H(xch), _D(domid), + XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION, + &c_mb, 0); + caml_leave_blocking_section(); + if (ret != 0) + failwith_xc(_H(xch)); - mb = Val_int(c_mb); - CAMLreturn(mb); + mb = Val_int(c_mb); + CAMLreturn(mb); } CAMLprim value stub_shadow_allocation_set(value xch, value domid, - value mb) + value mb) { - CAMLparam3(xch, domid, mb); - unsigned int c_mb; - int ret; + CAMLparam3(xch, domid, mb); + unsigned int c_mb; + int ret; - c_mb = Int_val(mb); - caml_enter_blocking_section(); - ret = xc_shadow_control(_H(xch), _D(domid), - XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, - &c_mb, 0); - caml_leave_blocking_section(); - if (ret != 0) - failwith_xc(_H(xch)); + c_mb = Int_val(mb); + caml_enter_blocking_section(); + ret = xc_shadow_control(_H(xch), _D(domid), + XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, + &c_mb, 0); + caml_leave_blocking_section(); + if (ret != 0) + failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } CAMLprim value stub_xc_domain_ioport_permission(value xch, value domid, - value start_port, value nr_ports, - value allow) + value start_port, value nr_ports, + value allow) { - CAMLparam5(xch, domid, start_port, nr_ports, allow); - uint32_t c_start_port, c_nr_ports; - uint8_t c_allow; - int ret; + CAMLparam5(xch, domid, start_port, nr_ports, allow); + uint32_t c_start_port, c_nr_ports; + uint8_t c_allow; + int ret; - c_start_port = Int_val(start_port); - c_nr_ports = Int_val(nr_ports); - c_allow = Bool_val(allow); + c_start_port = Int_val(start_port); + c_nr_ports = Int_val(nr_ports); + c_allow = Bool_val(allow); - ret = xc_domain_ioport_permission(_H(xch), _D(domid), - c_start_port, c_nr_ports, c_allow); - if (ret < 0) - failwith_xc(_H(xch)); + ret = xc_domain_ioport_permission(_H(xch), _D(domid), + c_start_port, c_nr_ports, c_allow); + if (ret < 0) + failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } CAMLprim value stub_xc_domain_iomem_permission(value xch, value domid, - value start_pfn, value nr_pfns, - value allow) + value start_pfn, value nr_pfns, + value allow) { - CAMLparam5(xch, domid, start_pfn, nr_pfns, allow); - unsigned long c_start_pfn, c_nr_pfns; - uint8_t c_allow; - int ret; + CAMLparam5(xch, domid, start_pfn, nr_pfns, allow); + unsigned long c_start_pfn, c_nr_pfns; + uint8_t c_allow; + int ret; - c_start_pfn = Nativeint_val(start_pfn); - c_nr_pfns = Nativeint_val(nr_pfns); - c_allow = Bool_val(allow); + c_start_pfn = Nativeint_val(start_pfn); + c_nr_pfns = Nativeint_val(nr_pfns); + c_allow = Bool_val(allow); - ret = xc_domain_iomem_permission(_H(xch), _D(domid), - c_start_pfn, c_nr_pfns, c_allow); - if (ret < 0) - failwith_xc(_H(xch)); + ret = xc_domain_iomem_permission(_H(xch), _D(domid), + c_start_pfn, c_nr_pfns, c_allow); + if (ret < 0) + failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } CAMLprim value stub_xc_domain_irq_permission(value xch, value domid, - value pirq, value allow) + value pirq, value allow) { - CAMLparam4(xch, domid, pirq, allow); - uint32_t c_pirq; - bool c_allow; - int ret; + CAMLparam4(xch, domid, pirq, allow); + uint32_t c_pirq; + bool c_allow; + int ret; - c_pirq = Int_val(pirq); - c_allow = Bool_val(allow); + c_pirq = Int_val(pirq); + c_allow = Bool_val(allow); - ret = xc_domain_irq_permission(_H(xch), _D(domid), - c_pirq, c_allow); - if (ret < 0) - failwith_xc(_H(xch)); + ret = xc_domain_irq_permission(_H(xch), _D(domid), + c_pirq, c_allow); + if (ret < 0) + failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } static uint32_t encode_sbdf(int domain, int bus, int dev, int func) { - return ((uint32_t)domain & 0xffff) << 16 | - ((uint32_t)bus & 0xff) << 8 | - ((uint32_t)dev & 0x1f) << 3 | - ((uint32_t)func & 0x7); + return ((uint32_t)domain & 0xffff) << 16 | + ((uint32_t)bus & 0xff) << 8 | + ((uint32_t)dev & 0x1f) << 3 | + ((uint32_t)func & 0x7); } CAMLprim value stub_xc_domain_test_assign_device(value xch, value domid, value desc) { - CAMLparam3(xch, domid, desc); - int ret; - int domain, bus, dev, func; - uint32_t sbdf; + CAMLparam3(xch, domid, desc); + int ret; + int domain, bus, dev, func; + uint32_t sbdf; - domain = Int_val(Field(desc, 0)); - bus = Int_val(Field(desc, 1)); - dev = Int_val(Field(desc, 2)); - func = Int_val(Field(desc, 3)); - sbdf = encode_sbdf(domain, bus, dev, func); + domain = Int_val(Field(desc, 0)); + bus = Int_val(Field(desc, 1)); + dev = Int_val(Field(desc, 2)); + func = Int_val(Field(desc, 3)); + sbdf = encode_sbdf(domain, bus, dev, func); - ret = xc_test_assign_device(_H(xch), _D(domid), sbdf); + ret = xc_test_assign_device(_H(xch), _D(domid), sbdf); - CAMLreturn(Val_bool(ret == 0)); + CAMLreturn(Val_bool(ret == 0)); } static int domain_assign_device_rdm_flag_table[] = { @@ -1147,96 +1147,96 @@ static int domain_assign_device_rdm_flag_table[] = { CAMLprim value stub_xc_domain_assign_device(value xch, value domid, value desc, value rflag) { - CAMLparam4(xch, domid, desc, rflag); - int ret; - int domain, bus, dev, func; - uint32_t sbdf, flag; + CAMLparam4(xch, domid, desc, rflag); + int ret; + int domain, bus, dev, func; + uint32_t sbdf, flag; - domain = Int_val(Field(desc, 0)); - bus = Int_val(Field(desc, 1)); - dev = Int_val(Field(desc, 2)); - func = Int_val(Field(desc, 3)); - sbdf = encode_sbdf(domain, bus, dev, func); + domain = Int_val(Field(desc, 0)); + bus = Int_val(Field(desc, 1)); + dev = Int_val(Field(desc, 2)); + func = Int_val(Field(desc, 3)); + sbdf = encode_sbdf(domain, bus, dev, func); - ret = Int_val(Field(rflag, 0)); - flag = domain_assign_device_rdm_flag_table[ret]; + ret = Int_val(Field(rflag, 0)); + flag = domain_assign_device_rdm_flag_table[ret]; - ret = xc_assign_device(_H(xch), _D(domid), sbdf, flag); + ret = xc_assign_device(_H(xch), _D(domid), sbdf, flag); - if (ret < 0) - failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + if (ret < 0) + failwith_xc(_H(xch)); + CAMLreturn(Val_unit); } CAMLprim value stub_xc_domain_deassign_device(value xch, value domid, value desc) { - CAMLparam3(xch, domid, desc); - int ret; - int domain, bus, dev, func; - uint32_t sbdf; + CAMLparam3(xch, domid, desc); + int ret; + int domain, bus, dev, func; + uint32_t sbdf; - domain = Int_val(Field(desc, 0)); - bus = Int_val(Field(desc, 1)); - dev = Int_val(Field(desc, 2)); - func = Int_val(Field(desc, 3)); - sbdf = encode_sbdf(domain, bus, dev, func); + domain = Int_val(Field(desc, 0)); + bus = Int_val(Field(desc, 1)); + dev = Int_val(Field(desc, 2)); + func = Int_val(Field(desc, 3)); + sbdf = encode_sbdf(domain, bus, dev, func); - ret = xc_deassign_device(_H(xch), _D(domid), sbdf); + ret = xc_deassign_device(_H(xch), _D(domid), sbdf); - if (ret < 0) - failwith_xc(_H(xch)); - CAMLreturn(Val_unit); + if (ret < 0) + failwith_xc(_H(xch)); + CAMLreturn(Val_unit); } CAMLprim value stub_xc_get_cpu_featureset(value xch, value idx) { - CAMLparam2(xch, idx); - CAMLlocal1(bitmap_val); + CAMLparam2(xch, idx); + CAMLlocal1(bitmap_val); #if defined(__i386__) || defined(__x86_64__) - /* Safe, because of the global ocaml lock. */ - static uint32_t fs_len; + /* Safe, because of the global ocaml lock. */ + static uint32_t fs_len; - if (fs_len == 0) - { - int ret = xc_get_cpu_featureset(_H(xch), 0, &fs_len, NULL); + if (fs_len == 0) + { + int ret = xc_get_cpu_featureset(_H(xch), 0, &fs_len, NULL); - if (ret || (fs_len == 0)) - failwith_xc(_H(xch)); - } + if (ret || (fs_len == 0)) + failwith_xc(_H(xch)); + } - { - /* To/from hypervisor to retrieve actual featureset */ - uint32_t fs[fs_len], len = fs_len; - unsigned int i; + { + /* To/from hypervisor to retrieve actual featureset */ + uint32_t fs[fs_len], len = fs_len; + unsigned int i; - int ret = xc_get_cpu_featureset(_H(xch), Int_val(idx), &len, fs); + int ret = xc_get_cpu_featureset(_H(xch), Int_val(idx), &len, fs); - if (ret) - failwith_xc(_H(xch)); + if (ret) + failwith_xc(_H(xch)); - bitmap_val = caml_alloc(len, 0); + bitmap_val = caml_alloc(len, 0); - for (i = 0; i < len; ++i) - Store_field(bitmap_val, i, caml_copy_int64(fs[i])); - } + for (i = 0; i < len; ++i) + Store_field(bitmap_val, i, caml_copy_int64(fs[i])); + } #else - caml_failwith("xc_get_cpu_featureset: not implemented"); + caml_failwith("xc_get_cpu_featureset: not implemented"); #endif - CAMLreturn(bitmap_val); + CAMLreturn(bitmap_val); } CAMLprim value stub_xc_watchdog(value xch, value domid, value timeout) { - CAMLparam3(xch, domid, timeout); - int ret; - unsigned int c_timeout = Int32_val(timeout); + CAMLparam3(xch, domid, timeout); + int ret; + unsigned int c_timeout = Int32_val(timeout); - ret = xc_watchdog(_H(xch), _D(domid), c_timeout); - if (ret < 0) - failwith_xc(_H(xch)); + ret = xc_watchdog(_H(xch), _D(domid), c_timeout); + if (ret < 0) + failwith_xc(_H(xch)); - CAMLreturn(Val_int(ret)); + CAMLreturn(Val_int(ret)); } /* diff --git a/tools/ocaml/libs/xentoollog/caml_xentoollog.h b/tools/ocaml/libs/xentoollog/caml_xentoollog.h index 0eb7618512..5ad4a4d5b2 100644 --- a/tools/ocaml/libs/xentoollog/caml_xentoollog.h +++ b/tools/ocaml/libs/xentoollog/caml_xentoollog.h @@ -15,9 +15,9 @@ */ struct caml_xtl { - xentoollog_logger vtable; - char *vmessage_cb; - char *progress_cb; + xentoollog_logger vtable; + char *vmessage_cb; + char *progress_cb; }; #define Xtl_val(x)(*((struct caml_xtl **) Data_custom_val(x))) diff --git a/tools/ocaml/libs/xentoollog/xentoollog_stubs.c b/tools/ocaml/libs/xentoollog/xentoollog_stubs.c index e4306a0c2f..8f1ced1fa0 100644 --- a/tools/ocaml/libs/xentoollog/xentoollog_stubs.c +++ b/tools/ocaml/libs/xentoollog/xentoollog_stubs.c @@ -40,14 +40,14 @@ caml_local_roots = caml__frame; \ static char * dup_String_val(value s) { - int len; - char *c; - len = caml_string_length(s); - c = calloc(len + 1, sizeof(char)); - if (!c) - caml_raise_out_of_memory(); - memcpy(c, String_val(s), len); - return c; + int len; + char *c; + len = caml_string_length(s); + c = calloc(len + 1, sizeof(char)); + if (!c) + caml_raise_out_of_memory(); + memcpy(c, String_val(s), len); + return c; } #include "_xtl_levels.inc" @@ -62,144 +62,144 @@ static char * dup_String_val(value s) static value Val_some(value v) { - CAMLparam1(v); - CAMLlocal1(some); - some = caml_alloc(1, 0); - Store_field(some, 0, v); - CAMLreturn(some); + CAMLparam1(v); + CAMLlocal1(some); + some = caml_alloc(1, 0); + Store_field(some, 0, v); + CAMLreturn(some); } static value Val_errno(int errnoval) { - if (errnoval == -1) - return Val_none; - return Val_some(Val_int(errnoval)); + if (errnoval == -1) + return Val_none; + return Val_some(Val_int(errnoval)); } static value Val_context(const char *context) { - if (context == NULL) - return Val_none; - return Val_some(caml_copy_string(context)); + if (context == NULL) + return Val_none; + return Val_some(caml_copy_string(context)); } static void stub_xtl_ocaml_vmessage(struct xentoollog_logger *logger, - xentoollog_level level, - int errnoval, - const char *context, - const char *format, - va_list al) + xentoollog_level level, + int errnoval, + const char *context, + const char *format, + va_list al) { - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocalN(args, 4); - struct caml_xtl *xtl = (struct caml_xtl*)logger; - const value *func = caml_named_value(xtl->vmessage_cb); - char *msg; + caml_leave_blocking_section(); + CAMLparam0(); + CAMLlocalN(args, 4); + struct caml_xtl *xtl = (struct caml_xtl*)logger; + const value *func = caml_named_value(xtl->vmessage_cb); + char *msg; - if (func == NULL) - caml_raise_sys_error(caml_copy_string("Unable to find callback")); - if (vasprintf(&msg, format, al) < 0) - caml_raise_out_of_memory(); + if (func == NULL) + caml_raise_sys_error(caml_copy_string("Unable to find callback")); + if (vasprintf(&msg, format, al) < 0) + caml_raise_out_of_memory(); - /* vmessage : level -> int option -> string option -> string -> unit; */ - args[0] = Val_level(level); - args[1] = Val_errno(errnoval); - args[2] = Val_context(context); - args[3] = caml_copy_string(msg); + /* vmessage : level -> int option -> string option -> string -> unit; */ + args[0] = Val_level(level); + args[1] = Val_errno(errnoval); + args[2] = Val_context(context); + args[3] = caml_copy_string(msg); - free(msg); + free(msg); - caml_callbackN(*func, 4, args); - CAMLdone; - caml_enter_blocking_section(); + caml_callbackN(*func, 4, args); + CAMLdone; + caml_enter_blocking_section(); } static void stub_xtl_ocaml_progress(struct xentoollog_logger *logger, - const char *context, - const char *doing_what /* no \r,\n */, - int percent, unsigned long done, unsigned long total) + const char *context, + const char *doing_what /* no \r,\n */, + int percent, unsigned long done, unsigned long total) { - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocalN(args, 5); - struct caml_xtl *xtl = (struct caml_xtl*)logger; - const value *func = caml_named_value(xtl->progress_cb); + caml_leave_blocking_section(); + CAMLparam0(); + CAMLlocalN(args, 5); + struct caml_xtl *xtl = (struct caml_xtl*)logger; + const value *func = caml_named_value(xtl->progress_cb); - if (func == NULL) - caml_raise_sys_error(caml_copy_string("Unable to find callback")); + if (func == NULL) + caml_raise_sys_error(caml_copy_string("Unable to find callback")); - /* progress : string option -> string -> int -> int64 -> int64 -> unit; */ - args[0] = Val_context(context); - args[1] = caml_copy_string(doing_what); - args[2] = Val_int(percent); - args[3] = caml_copy_int64(done); - args[4] = caml_copy_int64(total); + /* progress : string option -> string -> int -> int64 -> int64 -> unit; */ + args[0] = Val_context(context); + args[1] = caml_copy_string(doing_what); + args[2] = Val_int(percent); + args[3] = caml_copy_int64(done); + args[4] = caml_copy_int64(total); - caml_callbackN(*func, 5, args); - CAMLdone; - caml_enter_blocking_section(); + caml_callbackN(*func, 5, args); + CAMLdone; + caml_enter_blocking_section(); } static void xtl_destroy(struct xentoollog_logger *logger) { - struct caml_xtl *xtl = (struct caml_xtl*)logger; - free(xtl->vmessage_cb); - free(xtl->progress_cb); - free(xtl); + struct caml_xtl *xtl = (struct caml_xtl*)logger; + free(xtl->vmessage_cb); + free(xtl->progress_cb); + free(xtl); } void xtl_finalize(value handle) { - xtl_destroy(XTL); + xtl_destroy(XTL); } static struct custom_operations xentoollogger_custom_operations = { - "xentoollogger_custom_operations", - xtl_finalize /* custom_finalize_default */, - custom_compare_default, - custom_hash_default, - custom_serialize_default, - custom_deserialize_default + "xentoollogger_custom_operations", + xtl_finalize /* custom_finalize_default */, + custom_compare_default, + custom_hash_default, + custom_serialize_default, + custom_deserialize_default }; /* external _create_logger: (string * string) -> handle = "stub_xtl_create_logger" */ CAMLprim value stub_xtl_create_logger(value cbs) { - CAMLparam1(cbs); - CAMLlocal1(handle); - struct caml_xtl *xtl = malloc(sizeof(*xtl)); - if (xtl == NULL) - caml_raise_out_of_memory(); + CAMLparam1(cbs); + CAMLlocal1(handle); + struct caml_xtl *xtl = malloc(sizeof(*xtl)); + if (xtl == NULL) + caml_raise_out_of_memory(); - memset(xtl, 0, sizeof(*xtl)); + memset(xtl, 0, sizeof(*xtl)); - xtl->vtable.vmessage = &stub_xtl_ocaml_vmessage; - xtl->vtable.progress = &stub_xtl_ocaml_progress; - xtl->vtable.destroy = &xtl_destroy; + xtl->vtable.vmessage = &stub_xtl_ocaml_vmessage; + xtl->vtable.progress = &stub_xtl_ocaml_progress; + xtl->vtable.destroy = &xtl_destroy; - xtl->vmessage_cb = dup_String_val(Field(cbs, 0)); - xtl->progress_cb = dup_String_val(Field(cbs, 1)); + xtl->vmessage_cb = dup_String_val(Field(cbs, 0)); + xtl->progress_cb = dup_String_val(Field(cbs, 1)); - handle = caml_alloc_custom(&xentoollogger_custom_operations, sizeof(xtl), 0, 1); - Xtl_val(handle) = xtl; + handle = caml_alloc_custom(&xentoollogger_custom_operations, sizeof(xtl), 0, 1); + Xtl_val(handle) = xtl; - CAMLreturn(handle); + CAMLreturn(handle); } /* external test: handle -> unit = "stub_xtl_test" */ CAMLprim value stub_xtl_test(value handle) { - unsigned long l; - CAMLparam1(handle); - xtl_log(XTL, XTL_DEBUG, -1, "debug", "%s -- debug", __func__); - xtl_log(XTL, XTL_INFO, -1, "test", "%s -- test 1", __func__); - xtl_log(XTL, XTL_INFO, ENOSYS, "test errno", "%s -- test 2", __func__); - xtl_log(XTL, XTL_CRITICAL, -1, "critical", "%s -- critical", __func__); - for (l = 0UL; l<=100UL; l += 10UL) { - xtl_progress(XTL, "progress", "testing", l, 100UL); - usleep(10000); - } - CAMLreturn(Val_unit); + unsigned long l; + CAMLparam1(handle); + xtl_log(XTL, XTL_DEBUG, -1, "debug", "%s -- debug", __func__); + xtl_log(XTL, XTL_INFO, -1, "test", "%s -- test 1", __func__); + xtl_log(XTL, XTL_INFO, ENOSYS, "test errno", "%s -- test 2", __func__); + xtl_log(XTL, XTL_CRITICAL, -1, "critical", "%s -- critical", __func__); + for (l = 0UL; l<=100UL; l += 10UL) { + xtl_progress(XTL, "progress", "testing", l, 100UL); + usleep(10000); + } + CAMLreturn(Val_unit); } diff --git a/tools/ocaml/libs/xl/xenlight_stubs.c b/tools/ocaml/libs/xl/xenlight_stubs.c index 45b8af61c7..9dbf5e9660 100644 --- a/tools/ocaml/libs/xl/xenlight_stubs.c +++ b/tools/ocaml/libs/xl/xenlight_stubs.c @@ -58,14 +58,14 @@ caml_local_roots = caml__frame; \ static char * dup_String_val(value s) { - int len; - char *c; - len = caml_string_length(s); - c = calloc(len + 1, sizeof(char)); - if (!c) - caml_raise_out_of_memory(); - memcpy(c, String_val(s), len); - return c; + int len; + char *c; + len = caml_string_length(s); + c = calloc(len + 1, sizeof(char)); + if (!c) + caml_raise_out_of_memory(); + memcpy(c, String_val(s), len); + return c; } /* Forward reference: this is defined in the auto-generated include file below. */ @@ -73,157 +73,157 @@ static value Val_error (libxl_error error_c); static void failwith_xl(int error, char *fname) { - CAMLparam0(); - CAMLlocal1(arg); - static const value *exc = NULL; + CAMLparam0(); + CAMLlocal1(arg); + static const value *exc = NULL; - /* First time around, lookup by name */ - if (!exc) - exc = caml_named_value("Xenlight.Error"); + /* First time around, lookup by name */ + if (!exc) + exc = caml_named_value("Xenlight.Error"); - if (!exc) - caml_invalid_argument("Exception Xenlight.Error not initialized, please link xenlight.cma"); + if (!exc) + caml_invalid_argument("Exception Xenlight.Error not initialized, please link xenlight.cma"); - arg = caml_alloc(2, 0); + arg = caml_alloc(2, 0); - Store_field(arg, 0, Val_error(error)); - Store_field(arg, 1, caml_copy_string(fname)); + Store_field(arg, 0, Val_error(error)); + Store_field(arg, 1, caml_copy_string(fname)); - caml_raise_with_arg(*exc, arg); - CAMLreturn0; + caml_raise_with_arg(*exc, arg); + CAMLreturn0; } CAMLprim value stub_raise_exception(value unit) { - CAMLparam1(unit); - failwith_xl(ERROR_FAIL, "test exception"); - CAMLreturn(Val_unit); + CAMLparam1(unit); + failwith_xl(ERROR_FAIL, "test exception"); + CAMLreturn(Val_unit); } void ctx_finalize(value ctx) { - libxl_ctx_free(CTX); + libxl_ctx_free(CTX); } static struct custom_operations libxl_ctx_custom_operations = { - "libxl_ctx_custom_operations", - ctx_finalize /* custom_finalize_default */, - custom_compare_default, - custom_hash_default, - custom_serialize_default, - custom_deserialize_default + "libxl_ctx_custom_operations", + ctx_finalize /* custom_finalize_default */, + custom_compare_default, + custom_hash_default, + custom_serialize_default, + custom_deserialize_default }; CAMLprim value stub_libxl_ctx_alloc(value logger) { - CAMLparam1(logger); - CAMLlocal1(handle); - libxl_ctx *ctx; - int ret; + CAMLparam1(logger); + CAMLlocal1(handle); + libxl_ctx *ctx; + int ret; - ret = libxl_ctx_alloc(&ctx, LIBXL_VERSION, 0, (xentoollog_logger *) Xtl_val(logger)); - if (ret != 0) \ - failwith_xl(ERROR_FAIL, "cannot init context"); + ret = libxl_ctx_alloc(&ctx, LIBXL_VERSION, 0, (xentoollog_logger *) Xtl_val(logger)); + if (ret != 0) \ + failwith_xl(ERROR_FAIL, "cannot init context"); - handle = caml_alloc_custom(&libxl_ctx_custom_operations, sizeof(ctx), 0, 1); - Ctx_val(handle) = ctx; + handle = caml_alloc_custom(&libxl_ctx_custom_operations, sizeof(ctx), 0, 1); + Ctx_val(handle) = ctx; - CAMLreturn(handle); + CAMLreturn(handle); } static int list_len(value v) { - int len = 0; - while ( v != Val_emptylist ) { - len++; - v = Field(v, 1); - } - return len; + int len = 0; + while ( v != Val_emptylist ) { + len++; + v = Field(v, 1); + } + return len; } static int libxl_key_value_list_val(libxl_key_value_list *c_val, - value v) + value v) { - CAMLparam1(v); - CAMLlocal1(elem); - int nr, i; - libxl_key_value_list array; + CAMLparam1(v); + CAMLlocal1(elem); + int nr, i; + libxl_key_value_list array; - nr = list_len(v); + nr = list_len(v); - array = calloc((nr + 1) * 2, sizeof(char *)); - if (!array) - caml_raise_out_of_memory(); + array = calloc((nr + 1) * 2, sizeof(char *)); + if (!array) + caml_raise_out_of_memory(); - for (i=0; v != Val_emptylist; i++, v = Field(v, 1) ) { - elem = Field(v, 0); + for (i=0; v != Val_emptylist; i++, v = Field(v, 1) ) { + elem = Field(v, 0); - array[i * 2] = dup_String_val(Field(elem, 0)); - array[i * 2 + 1] = dup_String_val(Field(elem, 1)); - } + array[i * 2] = dup_String_val(Field(elem, 0)); + array[i * 2 + 1] = dup_String_val(Field(elem, 1)); + } - *c_val = array; - CAMLreturn(0); + *c_val = array; + CAMLreturn(0); } static value Val_key_value_list(libxl_key_value_list *c_val) { - CAMLparam0(); - CAMLlocal5(list, cons, key, val, kv); - int i; + CAMLparam0(); + CAMLlocal5(list, cons, key, val, kv); + int i; - list = Val_emptylist; - for (i = libxl_string_list_length((libxl_string_list *) c_val) - 1; i >= 0; i -= 2) { - val = caml_copy_string((*c_val)[i]); - key = caml_copy_string((*c_val)[i - 1]); - kv = caml_alloc_tuple(2); - Store_field(kv, 0, key); - Store_field(kv, 1, val); + list = Val_emptylist; + for (i = libxl_string_list_length((libxl_string_list *) c_val) - 1; i >= 0; i -= 2) { + val = caml_copy_string((*c_val)[i]); + key = caml_copy_string((*c_val)[i - 1]); + kv = caml_alloc_tuple(2); + Store_field(kv, 0, key); + Store_field(kv, 1, val); - cons = caml_alloc(2, 0); - Store_field(cons, 0, kv); // head - Store_field(cons, 1, list); // tail - list = cons; - } + cons = caml_alloc(2, 0); + Store_field(cons, 0, kv); // head + Store_field(cons, 1, list); // tail + list = cons; + } - CAMLreturn(list); + CAMLreturn(list); } static int libxl_string_list_val(libxl_string_list *c_val, value v) { - CAMLparam1(v); - int nr, i; - libxl_string_list array; + CAMLparam1(v); + int nr, i; + libxl_string_list array; - nr = list_len(v); + nr = list_len(v); - array = calloc(nr + 1, sizeof(char *)); - if (!array) - caml_raise_out_of_memory(); + array = calloc(nr + 1, sizeof(char *)); + if (!array) + caml_raise_out_of_memory(); - for (i=0; v != Val_emptylist; i++, v = Field(v, 1) ) - array[i] = dup_String_val(Field(v, 0)); + for (i=0; v != Val_emptylist; i++, v = Field(v, 1) ) + array[i] = dup_String_val(Field(v, 0)); - *c_val = array; - CAMLreturn(0); + *c_val = array; + CAMLreturn(0); } static value Val_string_list(libxl_string_list *c_val) { - CAMLparam0(); - CAMLlocal3(list, cons, string); - int i; + CAMLparam0(); + CAMLlocal3(list, cons, string); + int i; - list = Val_emptylist; - for (i = libxl_string_list_length(c_val) - 1; i >= 0; i--) { - string = caml_copy_string((*c_val)[i]); - cons = caml_alloc(2, 0); - Store_field(cons, 0, string); // head - Store_field(cons, 1, list); // tail - list = cons; - } + list = Val_emptylist; + for (i = libxl_string_list_length(c_val) - 1; i >= 0; i--) { + string = caml_copy_string((*c_val)[i]); + cons = caml_alloc(2, 0); + Store_field(cons, 0, string); // head + Store_field(cons, 1, list); // tail + list = cons; + } - CAMLreturn(list); + CAMLreturn(list); } /* Option type support as per http://www.linux-nantes.org/~fmonnier/ocaml/ocaml-wrapping-c.php */ @@ -236,472 +236,472 @@ static value Val_string_list(libxl_string_list *c_val) static value Val_some(value v) { - CAMLparam1(v); - CAMLlocal1(some); - some = caml_alloc(1, 0); - Store_field(some, 0, v); - CAMLreturn(some); + CAMLparam1(v); + CAMLlocal1(some); + some = caml_alloc(1, 0); + Store_field(some, 0, v); + CAMLreturn(some); } static value Val_mac (libxl_mac *c_val) { - CAMLparam0(); - CAMLlocal1(v); - int i; + CAMLparam0(); + CAMLlocal1(v); + int i; - v = caml_alloc_tuple(6); + v = caml_alloc_tuple(6); - for(i=0; i<6; i++) - Store_field(v, i, Val_int((*c_val)[i])); + for(i=0; i<6; i++) + Store_field(v, i, Val_int((*c_val)[i])); - CAMLreturn(v); + CAMLreturn(v); } static int Mac_val(libxl_mac *c_val, value v) { - CAMLparam1(v); - int i; + CAMLparam1(v); + int i; - for(i=0; i<6; i++) - (*c_val)[i] = Int_val(Field(v, i)); + for(i=0; i<6; i++) + (*c_val)[i] = Int_val(Field(v, i)); - CAMLreturn(0); + CAMLreturn(0); } static value Val_bitmap (libxl_bitmap *c_val) { - CAMLparam0(); - CAMLlocal1(v); - int i; + CAMLparam0(); + CAMLlocal1(v); + int i; - if (c_val->size == 0) - v = Atom(0); - else { - v = caml_alloc(8 * (c_val->size), 0); - libxl_for_each_bit(i, *c_val) { - if (libxl_bitmap_test(c_val, i)) - Store_field(v, i, Val_true); - else - Store_field(v, i, Val_false); - } - } - CAMLreturn(v); + if (c_val->size == 0) + v = Atom(0); + else { + v = caml_alloc(8 * (c_val->size), 0); + libxl_for_each_bit(i, *c_val) { + if (libxl_bitmap_test(c_val, i)) + Store_field(v, i, Val_true); + else + Store_field(v, i, Val_false); + } + } + CAMLreturn(v); } static int Bitmap_val(libxl_ctx *ctx, libxl_bitmap *c_val, value v) { - CAMLparam1(v); - int i, len = Wosize_val(v); + CAMLparam1(v); + int i, len = Wosize_val(v); - c_val->size = 0; - if (len > 0 && libxl_bitmap_alloc(ctx, c_val, len)) - failwith_xl(ERROR_NOMEM, "cannot allocate bitmap"); - for (i=0; isize = 0; + if (len > 0 && libxl_bitmap_alloc(ctx, c_val, len)) + failwith_xl(ERROR_NOMEM, "cannot allocate bitmap"); + for (i=0; ibytes[i])); + for(i=0; ibytes[i])); - CAMLreturn(v); + CAMLreturn(v); } static int Ms_vm_genid_val(libxl_ms_vm_genid *c_val, value v) { - CAMLparam1(v); - int i; + CAMLparam1(v); + int i; - for(i=0; ibytes[i] = Int_val(Field(v, i)); + for(i=0; ibytes[i] = Int_val(Field(v, i)); - CAMLreturn(0); + CAMLreturn(0); } static value Val_string_option(const char *c_val) { - CAMLparam0(); - CAMLlocal2(tmp1, tmp2); - if (c_val) { - tmp1 = caml_copy_string(c_val); - tmp2 = Val_some(tmp1); - CAMLreturn(tmp2); - } - else - CAMLreturn(Val_none); + CAMLparam0(); + CAMLlocal2(tmp1, tmp2); + if (c_val) { + tmp1 = caml_copy_string(c_val); + tmp2 = Val_some(tmp1); + CAMLreturn(tmp2); + } + else + CAMLreturn(Val_none); } static char *String_option_val(value v) { - CAMLparam1(v); - char *s = NULL; - if (v != Val_none) - s = dup_String_val(Some_val(v)); - CAMLreturnT(char *, s); + CAMLparam1(v); + char *s = NULL; + if (v != Val_none) + s = dup_String_val(Some_val(v)); + CAMLreturnT(char *, s); } #include "_libxl_types.inc" void async_callback(libxl_ctx *ctx, int rc, void *for_callback) { - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocal2(error, tmp); - static const value *func = NULL; - value *p = (value *) for_callback; + caml_leave_blocking_section(); + CAMLparam0(); + CAMLlocal2(error, tmp); + static const value *func = NULL; + value *p = (value *) for_callback; - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_async_callback"); - } + if (func == NULL) { + /* First time around, lookup by name */ + func = caml_named_value("libxl_async_callback"); + } - if (rc == 0) - error = Val_none; - else { - tmp = Val_error(rc); - error = Val_some(tmp); - } + if (rc == 0) + error = Val_none; + else { + tmp = Val_error(rc); + error = Val_some(tmp); + } - /* for_callback is a pointer to a "value" that was malloc'ed and - * registered with the OCaml GC. The value is handed back to OCaml - * in the following callback, after which the pointer is unregistered - * and freed. */ - caml_callback2(*func, error, *p); + /* for_callback is a pointer to a "value" that was malloc'ed and + * registered with the OCaml GC. The value is handed back to OCaml + * in the following callback, after which the pointer is unregistered + * and freed. */ + caml_callback2(*func, error, *p); - caml_remove_global_root(p); - free(p); + caml_remove_global_root(p); + free(p); - CAMLdone; - caml_enter_blocking_section(); + CAMLdone; + caml_enter_blocking_section(); } static libxl_asyncop_how *aohow_val(value async) { - CAMLparam1(async); - libxl_asyncop_how *ao_how = NULL; - value *p; + CAMLparam1(async); + libxl_asyncop_how *ao_how = NULL; + value *p; - if (async != Val_none) { - /* for_callback must be a pointer to a "value" that is malloc'ed and - * registered with the OCaml GC. This ensures that the GC does not remove - * the corresponding OCaml heap blocks, and allows the GC to update the value - * when blocks are moved around, while libxl is free to copy the pointer if - * it needs to. - * The for_callback pointer must always be non-NULL. */ - p = malloc(sizeof(value)); - if (!p) - failwith_xl(ERROR_NOMEM, "cannot allocate value"); - *p = Some_val(async); - caml_register_global_root(p); - ao_how = malloc(sizeof(*ao_how)); - ao_how->callback = async_callback; - ao_how->u.for_callback = (void *) p; - } + if (async != Val_none) { + /* for_callback must be a pointer to a "value" that is malloc'ed and + * registered with the OCaml GC. This ensures that the GC does not remove + * the corresponding OCaml heap blocks, and allows the GC to update the value + * when blocks are moved around, while libxl is free to copy the pointer if + * it needs to. + * The for_callback pointer must always be non-NULL. */ + p = malloc(sizeof(value)); + if (!p) + failwith_xl(ERROR_NOMEM, "cannot allocate value"); + *p = Some_val(async); + caml_register_global_root(p); + ao_how = malloc(sizeof(*ao_how)); + ao_how->callback = async_callback; + ao_how->u.for_callback = (void *) p; + } - CAMLreturnT(libxl_asyncop_how *, ao_how); + CAMLreturnT(libxl_asyncop_how *, ao_how); } value stub_libxl_domain_create_new(value ctx, value domain_config, value async, value unit) { - CAMLparam4(ctx, async, domain_config, unit); - int ret; - libxl_domain_config c_dconfig; - uint32_t c_domid; - libxl_asyncop_how *ao_how; + CAMLparam4(ctx, async, domain_config, unit); + int ret; + libxl_domain_config c_dconfig; + uint32_t c_domid; + libxl_asyncop_how *ao_how; - libxl_domain_config_init(&c_dconfig); - ret = domain_config_val(CTX, &c_dconfig, domain_config); - if (ret != 0) { - libxl_domain_config_dispose(&c_dconfig); - failwith_xl(ret, "domain_create_new"); - } + libxl_domain_config_init(&c_dconfig); + ret = domain_config_val(CTX, &c_dconfig, domain_config); + if (ret != 0) { + libxl_domain_config_dispose(&c_dconfig); + failwith_xl(ret, "domain_create_new"); + } - ao_how = aohow_val(async); + ao_how = aohow_val(async); - caml_enter_blocking_section(); - ret = libxl_domain_create_new(CTX, &c_dconfig, &c_domid, ao_how, NULL); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_domain_create_new(CTX, &c_dconfig, &c_domid, ao_how, NULL); + caml_leave_blocking_section(); - free(ao_how); - libxl_domain_config_dispose(&c_dconfig); + free(ao_how); + libxl_domain_config_dispose(&c_dconfig); - if (ret != 0) - failwith_xl(ret, "domain_create_new"); + if (ret != 0) + failwith_xl(ret, "domain_create_new"); - CAMLreturn(Val_int(c_domid)); + CAMLreturn(Val_int(c_domid)); } value stub_libxl_domain_create_restore(value ctx, value domain_config, value params, - value async, value unit) + value async, value unit) { - CAMLparam5(ctx, domain_config, params, async, unit); - int ret; - libxl_domain_config c_dconfig; - libxl_domain_restore_params c_params; - uint32_t c_domid; - libxl_asyncop_how *ao_how; - int restore_fd; + CAMLparam5(ctx, domain_config, params, async, unit); + int ret; + libxl_domain_config c_dconfig; + libxl_domain_restore_params c_params; + uint32_t c_domid; + libxl_asyncop_how *ao_how; + int restore_fd; - libxl_domain_config_init(&c_dconfig); - ret = domain_config_val(CTX, &c_dconfig, domain_config); - if (ret != 0) { - libxl_domain_config_dispose(&c_dconfig); - failwith_xl(ret, "domain_create_restore"); - } + libxl_domain_config_init(&c_dconfig); + ret = domain_config_val(CTX, &c_dconfig, domain_config); + if (ret != 0) { + libxl_domain_config_dispose(&c_dconfig); + failwith_xl(ret, "domain_create_restore"); + } - libxl_domain_restore_params_init(&c_params); - ret = domain_restore_params_val(CTX, &c_params, Field(params, 1)); - if (ret != 0) { - libxl_domain_restore_params_dispose(&c_params); - failwith_xl(ret, "domain_create_restore"); - } + libxl_domain_restore_params_init(&c_params); + ret = domain_restore_params_val(CTX, &c_params, Field(params, 1)); + if (ret != 0) { + libxl_domain_restore_params_dispose(&c_params); + failwith_xl(ret, "domain_create_restore"); + } - ao_how = aohow_val(async); - restore_fd = Int_val(Field(params, 0)); + ao_how = aohow_val(async); + restore_fd = Int_val(Field(params, 0)); - caml_enter_blocking_section(); - ret = libxl_domain_create_restore(CTX, &c_dconfig, &c_domid, restore_fd, - -1, &c_params, ao_how, NULL); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_domain_create_restore(CTX, &c_dconfig, &c_domid, restore_fd, + -1, &c_params, ao_how, NULL); + caml_leave_blocking_section(); - free(ao_how); - libxl_domain_config_dispose(&c_dconfig); - libxl_domain_restore_params_dispose(&c_params); + free(ao_how); + libxl_domain_config_dispose(&c_dconfig); + libxl_domain_restore_params_dispose(&c_params); - if (ret != 0) - failwith_xl(ret, "domain_create_restore"); + if (ret != 0) + failwith_xl(ret, "domain_create_restore"); - CAMLreturn(Val_int(c_domid)); + CAMLreturn(Val_int(c_domid)); } value stub_libxl_domain_shutdown(value ctx, value domid, value async, value unit) { - CAMLparam4(ctx, domid, async, unit); - int ret; - uint32_t c_domid = Int_val(domid); - libxl_asyncop_how *ao_how = aohow_val(async); + CAMLparam4(ctx, domid, async, unit); + int ret; + uint32_t c_domid = Int_val(domid); + libxl_asyncop_how *ao_how = aohow_val(async); - caml_enter_blocking_section(); - ret = libxl_domain_shutdown(CTX, c_domid, ao_how); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_domain_shutdown(CTX, c_domid, ao_how); + caml_leave_blocking_section(); - free(ao_how); + free(ao_how); - if (ret != 0) - failwith_xl(ret, "domain_shutdown"); + if (ret != 0) + failwith_xl(ret, "domain_shutdown"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } value stub_libxl_domain_reboot(value ctx, value domid, value async, value unit) { - CAMLparam4(ctx, domid, async, unit); - int ret; - uint32_t c_domid = Int_val(domid); - libxl_asyncop_how *ao_how = aohow_val(async); + CAMLparam4(ctx, domid, async, unit); + int ret; + uint32_t c_domid = Int_val(domid); + libxl_asyncop_how *ao_how = aohow_val(async); - caml_enter_blocking_section(); - ret = libxl_domain_reboot(CTX, c_domid, ao_how); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_domain_reboot(CTX, c_domid, ao_how); + caml_leave_blocking_section(); - free(ao_how); + free(ao_how); - if (ret != 0) - failwith_xl(ret, "domain_reboot"); + if (ret != 0) + failwith_xl(ret, "domain_reboot"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } value stub_libxl_domain_destroy(value ctx, value domid, value async, value unit) { - CAMLparam4(ctx, domid, async, unit); - int ret; - uint32_t c_domid = Int_val(domid); - libxl_asyncop_how *ao_how = aohow_val(async); + CAMLparam4(ctx, domid, async, unit); + int ret; + uint32_t c_domid = Int_val(domid); + libxl_asyncop_how *ao_how = aohow_val(async); - caml_enter_blocking_section(); - ret = libxl_domain_destroy(CTX, c_domid, ao_how); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_domain_destroy(CTX, c_domid, ao_how); + caml_leave_blocking_section(); - free(ao_how); + free(ao_how); - if (ret != 0) - failwith_xl(ret, "domain_destroy"); + if (ret != 0) + failwith_xl(ret, "domain_destroy"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } value stub_libxl_domain_suspend(value ctx, value domid, value fd, value async, value unit) { - CAMLparam5(ctx, domid, fd, async, unit); - int ret; - uint32_t c_domid = Int_val(domid); - int c_fd = Int_val(fd); - libxl_asyncop_how *ao_how = aohow_val(async); + CAMLparam5(ctx, domid, fd, async, unit); + int ret; + uint32_t c_domid = Int_val(domid); + int c_fd = Int_val(fd); + libxl_asyncop_how *ao_how = aohow_val(async); - caml_enter_blocking_section(); - ret = libxl_domain_suspend(CTX, c_domid, c_fd, 0, ao_how); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_domain_suspend(CTX, c_domid, c_fd, 0, ao_how); + caml_leave_blocking_section(); - free(ao_how); + free(ao_how); - if (ret != 0) - failwith_xl(ret, "domain_suspend"); + if (ret != 0) + failwith_xl(ret, "domain_suspend"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } value stub_libxl_domain_pause(value ctx, value domid, value async) { - CAMLparam3(ctx, domid, async); - int ret; - uint32_t c_domid = Int_val(domid); - libxl_asyncop_how *ao_how = aohow_val(async); + CAMLparam3(ctx, domid, async); + int ret; + uint32_t c_domid = Int_val(domid); + libxl_asyncop_how *ao_how = aohow_val(async); - caml_enter_blocking_section(); - ret = libxl_domain_pause(CTX, c_domid, ao_how); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_domain_pause(CTX, c_domid, ao_how); + caml_leave_blocking_section(); - free(ao_how); + free(ao_how); - if (ret != 0) - failwith_xl(ret, "domain_pause"); + if (ret != 0) + failwith_xl(ret, "domain_pause"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } value stub_libxl_domain_unpause(value ctx, value domid, value async) { - CAMLparam3(ctx, domid, async); - int ret; - uint32_t c_domid = Int_val(domid); - libxl_asyncop_how *ao_how = aohow_val(async); + CAMLparam3(ctx, domid, async); + int ret; + uint32_t c_domid = Int_val(domid); + libxl_asyncop_how *ao_how = aohow_val(async); - caml_enter_blocking_section(); - ret = libxl_domain_unpause(CTX, c_domid, ao_how); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_domain_unpause(CTX, c_domid, ao_how); + caml_leave_blocking_section(); - free(ao_how); + free(ao_how); - if (ret != 0) - failwith_xl(ret, "domain_unpause"); + if (ret != 0) + failwith_xl(ret, "domain_unpause"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } #define _STRINGIFY(x) #x #define STRINGIFY(x) _STRINGIFY(x) -#define _DEVICE_ADDREMOVE(type,fn,op) \ -value stub_xl_device_##type##_##op(value ctx, value info, value domid, \ - value async, value unit) \ -{ \ - CAMLparam5(ctx, info, domid, async, unit); \ - libxl_device_##type c_info; \ - int ret, marker_var; \ - uint32_t c_domid = Int_val(domid); \ - libxl_asyncop_how *ao_how = aohow_val(async); \ - \ - device_##type##_val(CTX, &c_info, info); \ - \ - caml_enter_blocking_section(); \ - ret = libxl_##fn##_##op(CTX, c_domid, &c_info, ao_how); \ - caml_leave_blocking_section(); \ - \ - free(ao_how); \ - libxl_device_##type##_dispose(&c_info); \ - \ - if (ret != 0) \ - failwith_xl(ret, STRINGIFY(type) "_" STRINGIFY(op)); \ - \ - CAMLreturn(Val_unit); \ +#define _DEVICE_ADDREMOVE(type,fn,op) \ +value stub_xl_device_##type##_##op(value ctx, value info, value domid, \ + value async, value unit) \ +{ \ + CAMLparam5(ctx, info, domid, async, unit); \ + libxl_device_##type c_info; \ + int ret, marker_var; \ + uint32_t c_domid = Int_val(domid); \ + libxl_asyncop_how *ao_how = aohow_val(async); \ + \ + device_##type##_val(CTX, &c_info, info); \ + \ + caml_enter_blocking_section(); \ + ret = libxl_##fn##_##op(CTX, c_domid, &c_info, ao_how); \ + caml_leave_blocking_section(); \ + \ + free(ao_how); \ + libxl_device_##type##_dispose(&c_info); \ + \ + if (ret != 0) \ + failwith_xl(ret, STRINGIFY(type) "_" STRINGIFY(op)); \ + \ + CAMLreturn(Val_unit); \ } #define DEVICE_ADDREMOVE(type) \ - _DEVICE_ADDREMOVE(type, device_##type, add) \ - _DEVICE_ADDREMOVE(type, device_##type, remove) \ - _DEVICE_ADDREMOVE(type, device_##type, destroy) + _DEVICE_ADDREMOVE(type, device_##type, add) \ + _DEVICE_ADDREMOVE(type, device_##type, remove) \ + _DEVICE_ADDREMOVE(type, device_##type, destroy) DEVICE_ADDREMOVE(disk) DEVICE_ADDREMOVE(nic) @@ -712,558 +712,558 @@ _DEVICE_ADDREMOVE(disk, cdrom, insert) value stub_xl_device_nic_of_devid(value ctx, value domid, value devid) { - CAMLparam3(ctx, domid, devid); - CAMLlocal1(nic); - libxl_device_nic c_nic; - uint32_t c_domid = Int_val(domid); - int c_devid = Int_val(devid); + CAMLparam3(ctx, domid, devid); + CAMLlocal1(nic); + libxl_device_nic c_nic; + uint32_t c_domid = Int_val(domid); + int c_devid = Int_val(devid); - caml_enter_blocking_section(); - libxl_devid_to_device_nic(CTX, c_domid, c_devid, &c_nic); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + libxl_devid_to_device_nic(CTX, c_domid, c_devid, &c_nic); + caml_leave_blocking_section(); - nic = Val_device_nic(&c_nic); - libxl_device_nic_dispose(&c_nic); + nic = Val_device_nic(&c_nic); + libxl_device_nic_dispose(&c_nic); - CAMLreturn(nic); + CAMLreturn(nic); } value stub_xl_device_nic_list(value ctx, value domid) { - CAMLparam2(ctx, domid); - CAMLlocal2(list, temp); - libxl_device_nic *c_list; - int i, nb; - uint32_t c_domid = Int_val(domid); + CAMLparam2(ctx, domid); + CAMLlocal2(list, temp); + libxl_device_nic *c_list; + int i, nb; + uint32_t c_domid = Int_val(domid); - caml_enter_blocking_section(); - c_list = libxl_device_nic_list(CTX, c_domid, &nb); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + c_list = libxl_device_nic_list(CTX, c_domid, &nb); + caml_leave_blocking_section(); - if (!c_list) - failwith_xl(ERROR_FAIL, "nic_list"); + if (!c_list) + failwith_xl(ERROR_FAIL, "nic_list"); - list = temp = Val_emptylist; - for (i = 0; i < nb; i++) { - list = caml_alloc_small(2, Tag_cons); - Field(list, 0) = Val_int(0); - Field(list, 1) = temp; - temp = list; - Store_field(list, 0, Val_device_nic(&c_list[i])); - } - libxl_device_nic_list_free(c_list, nb); + list = temp = Val_emptylist; + for (i = 0; i < nb; i++) { + list = caml_alloc_small(2, Tag_cons); + Field(list, 0) = Val_int(0); + Field(list, 1) = temp; + temp = list; + Store_field(list, 0, Val_device_nic(&c_list[i])); + } + libxl_device_nic_list_free(c_list, nb); - CAMLreturn(list); + CAMLreturn(list); } value stub_xl_device_disk_list(value ctx, value domid) { - CAMLparam2(ctx, domid); - CAMLlocal2(list, temp); - libxl_device_disk *c_list; - int i, nb; - uint32_t c_domid = Int_val(domid); + CAMLparam2(ctx, domid); + CAMLlocal2(list, temp); + libxl_device_disk *c_list; + int i, nb; + uint32_t c_domid = Int_val(domid); - caml_enter_blocking_section(); - c_list = libxl_device_disk_list(CTX, c_domid, &nb); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + c_list = libxl_device_disk_list(CTX, c_domid, &nb); + caml_leave_blocking_section(); - if (!c_list) - failwith_xl(ERROR_FAIL, "disk_list"); + if (!c_list) + failwith_xl(ERROR_FAIL, "disk_list"); - list = temp = Val_emptylist; - for (i = 0; i < nb; i++) { - list = caml_alloc_small(2, Tag_cons); - Field(list, 0) = Val_int(0); - Field(list, 1) = temp; - temp = list; - Store_field(list, 0, Val_device_disk(&c_list[i])); - } - libxl_device_disk_list_free(c_list, nb); + list = temp = Val_emptylist; + for (i = 0; i < nb; i++) { + list = caml_alloc_small(2, Tag_cons); + Field(list, 0) = Val_int(0); + Field(list, 1) = temp; + temp = list; + Store_field(list, 0, Val_device_disk(&c_list[i])); + } + libxl_device_disk_list_free(c_list, nb); - CAMLreturn(list); + CAMLreturn(list); } value stub_xl_device_disk_of_vdev(value ctx, value domid, value vdev) { - CAMLparam3(ctx, domid, vdev); - CAMLlocal1(disk); - libxl_device_disk c_disk; - char *c_vdev; - uint32_t c_domid = Int_val(domid); + CAMLparam3(ctx, domid, vdev); + CAMLlocal1(disk); + libxl_device_disk c_disk; + char *c_vdev; + uint32_t c_domid = Int_val(domid); - c_vdev = strdup(String_val(vdev)); + c_vdev = strdup(String_val(vdev)); - caml_enter_blocking_section(); - libxl_vdev_to_device_disk(CTX, c_domid, c_vdev, &c_disk); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + libxl_vdev_to_device_disk(CTX, c_domid, c_vdev, &c_disk); + caml_leave_blocking_section(); - disk = Val_device_disk(&c_disk); - libxl_device_disk_dispose(&c_disk); - free(c_vdev); + disk = Val_device_disk(&c_disk); + libxl_device_disk_dispose(&c_disk); + free(c_vdev); - CAMLreturn(disk); + CAMLreturn(disk); } value stub_xl_device_pci_list(value ctx, value domid) { - CAMLparam2(ctx, domid); - CAMLlocal2(list, temp); - libxl_device_pci *c_list; - int i, nb; - uint32_t c_domid = Int_val(domid); + CAMLparam2(ctx, domid); + CAMLlocal2(list, temp); + libxl_device_pci *c_list; + int i, nb; + uint32_t c_domid = Int_val(domid); - caml_enter_blocking_section(); - c_list = libxl_device_pci_list(CTX, c_domid, &nb); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + c_list = libxl_device_pci_list(CTX, c_domid, &nb); + caml_leave_blocking_section(); - if (!c_list) - failwith_xl(ERROR_FAIL, "pci_list"); + if (!c_list) + failwith_xl(ERROR_FAIL, "pci_list"); - list = temp = Val_emptylist; - for (i = 0; i < nb; i++) { - list = caml_alloc_small(2, Tag_cons); - Field(list, 0) = Val_int(0); - Field(list, 1) = temp; - temp = list; - Store_field(list, 0, Val_device_pci(&c_list[i])); - libxl_device_pci_dispose(&c_list[i]); - } - free(c_list); + list = temp = Val_emptylist; + for (i = 0; i < nb; i++) { + list = caml_alloc_small(2, Tag_cons); + Field(list, 0) = Val_int(0); + Field(list, 1) = temp; + temp = list; + Store_field(list, 0, Val_device_pci(&c_list[i])); + libxl_device_pci_dispose(&c_list[i]); + } + free(c_list); - CAMLreturn(list); + CAMLreturn(list); } value stub_xl_device_pci_assignable_add(value ctx, value info, value rebind) { - CAMLparam3(ctx, info, rebind); - libxl_device_pci c_info; - int ret, marker_var; - int c_rebind = (int) Bool_val(rebind); + CAMLparam3(ctx, info, rebind); + libxl_device_pci c_info; + int ret, marker_var; + int c_rebind = (int) Bool_val(rebind); - device_pci_val(CTX, &c_info, info); + device_pci_val(CTX, &c_info, info); - caml_enter_blocking_section(); - ret = libxl_device_pci_assignable_add(CTX, &c_info, c_rebind); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_device_pci_assignable_add(CTX, &c_info, c_rebind); + caml_leave_blocking_section(); - libxl_device_pci_dispose(&c_info); + libxl_device_pci_dispose(&c_info); - if (ret != 0) - failwith_xl(ret, "pci_assignable_add"); + if (ret != 0) + failwith_xl(ret, "pci_assignable_add"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } value stub_xl_device_pci_assignable_remove(value ctx, value info, value rebind) { - CAMLparam3(ctx, info, rebind); - libxl_device_pci c_info; - int ret, marker_var; - int c_rebind = (int) Bool_val(rebind); + CAMLparam3(ctx, info, rebind); + libxl_device_pci c_info; + int ret, marker_var; + int c_rebind = (int) Bool_val(rebind); - device_pci_val(CTX, &c_info, info); + device_pci_val(CTX, &c_info, info); - caml_enter_blocking_section(); - ret = libxl_device_pci_assignable_remove(CTX, &c_info, c_rebind); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_device_pci_assignable_remove(CTX, &c_info, c_rebind); + caml_leave_blocking_section(); - libxl_device_pci_dispose(&c_info); + libxl_device_pci_dispose(&c_info); - if (ret != 0) - failwith_xl(ret, "pci_assignable_remove"); + if (ret != 0) + failwith_xl(ret, "pci_assignable_remove"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } value stub_xl_device_pci_assignable_list(value ctx) { - CAMLparam1(ctx); - CAMLlocal2(list, temp); - libxl_device_pci *c_list; - int i, nb; - uint32_t c_domid; + CAMLparam1(ctx); + CAMLlocal2(list, temp); + libxl_device_pci *c_list; + int i, nb; + uint32_t c_domid; - caml_enter_blocking_section(); - c_list = libxl_device_pci_assignable_list(CTX, &nb); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + c_list = libxl_device_pci_assignable_list(CTX, &nb); + caml_leave_blocking_section(); - if (!c_list) - failwith_xl(ERROR_FAIL, "pci_assignable_list"); + if (!c_list) + failwith_xl(ERROR_FAIL, "pci_assignable_list"); - list = temp = Val_emptylist; - for (i = 0; i < nb; i++) { - list = caml_alloc_small(2, Tag_cons); - Field(list, 0) = Val_int(0); - Field(list, 1) = temp; - temp = list; - Store_field(list, 0, Val_device_pci(&c_list[i])); - } - libxl_device_pci_assignable_list_free(c_list, nb); + list = temp = Val_emptylist; + for (i = 0; i < nb; i++) { + list = caml_alloc_small(2, Tag_cons); + Field(list, 0) = Val_int(0); + Field(list, 1) = temp; + temp = list; + Store_field(list, 0, Val_device_pci(&c_list[i])); + } + libxl_device_pci_assignable_list_free(c_list, nb); - CAMLreturn(list); + CAMLreturn(list); } value stub_xl_physinfo_get(value ctx) { - CAMLparam1(ctx); - CAMLlocal1(physinfo); - libxl_physinfo c_physinfo; - int ret; + CAMLparam1(ctx); + CAMLlocal1(physinfo); + libxl_physinfo c_physinfo; + int ret; - caml_enter_blocking_section(); - ret = libxl_get_physinfo(CTX, &c_physinfo); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_get_physinfo(CTX, &c_physinfo); + caml_leave_blocking_section(); - if (ret != 0) - failwith_xl(ret, "get_physinfo"); + if (ret != 0) + failwith_xl(ret, "get_physinfo"); - physinfo = Val_physinfo(&c_physinfo); + physinfo = Val_physinfo(&c_physinfo); - libxl_physinfo_dispose(&c_physinfo); + libxl_physinfo_dispose(&c_physinfo); - CAMLreturn(physinfo); + CAMLreturn(physinfo); } value stub_xl_cputopology_get(value ctx) { - CAMLparam1(ctx); - CAMLlocal3(topology, v, v0); - libxl_cputopology *c_topology; - int i, nr; + CAMLparam1(ctx); + CAMLlocal3(topology, v, v0); + libxl_cputopology *c_topology; + int i, nr; - caml_enter_blocking_section(); - c_topology = libxl_get_cpu_topology(CTX, &nr); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + c_topology = libxl_get_cpu_topology(CTX, &nr); + caml_leave_blocking_section(); - if (!c_topology) - failwith_xl(ERROR_FAIL, "get_cpu_topologyinfo"); + if (!c_topology) + failwith_xl(ERROR_FAIL, "get_cpu_topologyinfo"); - topology = caml_alloc_tuple(nr); - for (i = 0; i < nr; i++) { - if (c_topology[i].core != LIBXL_CPUTOPOLOGY_INVALID_ENTRY) { - v0 = Val_cputopology(&c_topology[i]); - v = Val_some(v0); - } - else - v = Val_none; - Store_field(topology, i, v); - } + topology = caml_alloc_tuple(nr); + for (i = 0; i < nr; i++) { + if (c_topology[i].core != LIBXL_CPUTOPOLOGY_INVALID_ENTRY) { + v0 = Val_cputopology(&c_topology[i]); + v = Val_some(v0); + } + else + v = Val_none; + Store_field(topology, i, v); + } - libxl_cputopology_list_free(c_topology, nr); + libxl_cputopology_list_free(c_topology, nr); - CAMLreturn(topology); + CAMLreturn(topology); } value stub_xl_dominfo_list(value ctx) { - CAMLparam1(ctx); - CAMLlocal2(domlist, temp); - libxl_dominfo *c_domlist; - int i, nb; + CAMLparam1(ctx); + CAMLlocal2(domlist, temp); + libxl_dominfo *c_domlist; + int i, nb; - caml_enter_blocking_section(); - c_domlist = libxl_list_domain(CTX, &nb); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + c_domlist = libxl_list_domain(CTX, &nb); + caml_leave_blocking_section(); - if (!c_domlist) - failwith_xl(ERROR_FAIL, "dominfo_list"); + if (!c_domlist) + failwith_xl(ERROR_FAIL, "dominfo_list"); - domlist = temp = Val_emptylist; - for (i = nb - 1; i >= 0; i--) { - domlist = caml_alloc_small(2, Tag_cons); - Field(domlist, 0) = Val_int(0); - Field(domlist, 1) = temp; - temp = domlist; + domlist = temp = Val_emptylist; + for (i = nb - 1; i >= 0; i--) { + domlist = caml_alloc_small(2, Tag_cons); + Field(domlist, 0) = Val_int(0); + Field(domlist, 1) = temp; + temp = domlist; - Store_field(domlist, 0, Val_dominfo(&c_domlist[i])); - } + Store_field(domlist, 0, Val_dominfo(&c_domlist[i])); + } - libxl_dominfo_list_free(c_domlist, nb); + libxl_dominfo_list_free(c_domlist, nb); - CAMLreturn(domlist); + CAMLreturn(domlist); } value stub_xl_dominfo_get(value ctx, value domid) { - CAMLparam2(ctx, domid); - CAMLlocal1(dominfo); - libxl_dominfo c_dominfo; - int ret; - uint32_t c_domid = Int_val(domid); + CAMLparam2(ctx, domid); + CAMLlocal1(dominfo); + libxl_dominfo c_dominfo; + int ret; + uint32_t c_domid = Int_val(domid); - caml_enter_blocking_section(); - ret = libxl_domain_info(CTX, &c_dominfo, c_domid); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_domain_info(CTX, &c_dominfo, c_domid); + caml_leave_blocking_section(); - if (ret != 0) - failwith_xl(ERROR_FAIL, "domain_info"); - dominfo = Val_dominfo(&c_dominfo); + if (ret != 0) + failwith_xl(ERROR_FAIL, "domain_info"); + dominfo = Val_dominfo(&c_dominfo); - CAMLreturn(dominfo); + CAMLreturn(dominfo); } value stub_xl_domain_sched_params_get(value ctx, value domid) { - CAMLparam2(ctx, domid); - CAMLlocal1(scinfo); - libxl_domain_sched_params c_scinfo; - int ret; - uint32_t c_domid = Int_val(domid); + CAMLparam2(ctx, domid); + CAMLlocal1(scinfo); + libxl_domain_sched_params c_scinfo; + int ret; + uint32_t c_domid = Int_val(domid); - caml_enter_blocking_section(); - ret = libxl_domain_sched_params_get(CTX, c_domid, &c_scinfo); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_domain_sched_params_get(CTX, c_domid, &c_scinfo); + caml_leave_blocking_section(); - if (ret != 0) - failwith_xl(ret, "domain_sched_params_get"); + if (ret != 0) + failwith_xl(ret, "domain_sched_params_get"); - scinfo = Val_domain_sched_params(&c_scinfo); + scinfo = Val_domain_sched_params(&c_scinfo); - libxl_domain_sched_params_dispose(&c_scinfo); + libxl_domain_sched_params_dispose(&c_scinfo); - CAMLreturn(scinfo); + CAMLreturn(scinfo); } value stub_xl_domain_sched_params_set(value ctx, value domid, value scinfo) { - CAMLparam3(ctx, domid, scinfo); - libxl_domain_sched_params c_scinfo; - int ret; - uint32_t c_domid = Int_val(domid); + CAMLparam3(ctx, domid, scinfo); + libxl_domain_sched_params c_scinfo; + int ret; + uint32_t c_domid = Int_val(domid); - domain_sched_params_val(CTX, &c_scinfo, scinfo); + domain_sched_params_val(CTX, &c_scinfo, scinfo); - caml_enter_blocking_section(); - ret = libxl_domain_sched_params_set(CTX, c_domid, &c_scinfo); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_domain_sched_params_set(CTX, c_domid, &c_scinfo); + caml_leave_blocking_section(); - libxl_domain_sched_params_dispose(&c_scinfo); + libxl_domain_sched_params_dispose(&c_scinfo); - if (ret != 0) - failwith_xl(ret, "domain_sched_params_set"); + if (ret != 0) + failwith_xl(ret, "domain_sched_params_set"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } value stub_xl_send_trigger(value ctx, value domid, value trigger, value vcpuid, value async) { - CAMLparam5(ctx, domid, trigger, vcpuid, async); - int ret; - uint32_t c_domid = Int_val(domid); - libxl_trigger c_trigger = LIBXL_TRIGGER_UNKNOWN; - int c_vcpuid = Int_val(vcpuid); - libxl_asyncop_how *ao_how = aohow_val(async); + CAMLparam5(ctx, domid, trigger, vcpuid, async); + int ret; + uint32_t c_domid = Int_val(domid); + libxl_trigger c_trigger = LIBXL_TRIGGER_UNKNOWN; + int c_vcpuid = Int_val(vcpuid); + libxl_asyncop_how *ao_how = aohow_val(async); - trigger_val(CTX, &c_trigger, trigger); + trigger_val(CTX, &c_trigger, trigger); - caml_enter_blocking_section(); - ret = libxl_send_trigger(CTX, c_domid, c_trigger, c_vcpuid, ao_how); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_send_trigger(CTX, c_domid, c_trigger, c_vcpuid, ao_how); + caml_leave_blocking_section(); - free(ao_how); + free(ao_how); - if (ret != 0) - failwith_xl(ret, "send_trigger"); + if (ret != 0) + failwith_xl(ret, "send_trigger"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } value stub_xl_send_sysrq(value ctx, value domid, value sysrq) { - CAMLparam3(ctx, domid, sysrq); - int ret; - uint32_t c_domid = Int_val(domid); - int c_sysrq = Int_val(sysrq); + CAMLparam3(ctx, domid, sysrq); + int ret; + uint32_t c_domid = Int_val(domid); + int c_sysrq = Int_val(sysrq); - caml_enter_blocking_section(); - ret = libxl_send_sysrq(CTX, c_domid, c_sysrq); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_send_sysrq(CTX, c_domid, c_sysrq); + caml_leave_blocking_section(); - if (ret != 0) - failwith_xl(ret, "send_sysrq"); + if (ret != 0) + failwith_xl(ret, "send_sysrq"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } value stub_xl_send_debug_keys(value ctx, value keys) { - CAMLparam2(ctx, keys); - int ret; - char *c_keys; + CAMLparam2(ctx, keys); + int ret; + char *c_keys; - c_keys = dup_String_val(keys); + c_keys = dup_String_val(keys); - caml_enter_blocking_section(); - ret = libxl_send_debug_keys(CTX, c_keys); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_send_debug_keys(CTX, c_keys); + caml_leave_blocking_section(); - free(c_keys); + free(c_keys); - if (ret != 0) - failwith_xl(ret, "send_debug_keys"); + if (ret != 0) + failwith_xl(ret, "send_debug_keys"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } static struct custom_operations libxl_console_reader_custom_operations = { - "libxl_console_reader_custom_operations", - custom_finalize_default, - custom_compare_default, - custom_hash_default, - custom_serialize_default, - custom_deserialize_default + "libxl_console_reader_custom_operations", + custom_finalize_default, + custom_compare_default, + custom_hash_default, + custom_serialize_default, + custom_deserialize_default }; #define Console_reader_val(x)(*((libxl_xen_console_reader **) Data_custom_val(x))) value stub_libxl_xen_console_read_start(value ctx, value clear) { - CAMLparam2(ctx, clear); - CAMLlocal1(handle); - int c_clear = Int_val(clear); - libxl_xen_console_reader *cr; + CAMLparam2(ctx, clear); + CAMLlocal1(handle); + int c_clear = Int_val(clear); + libxl_xen_console_reader *cr; - caml_enter_blocking_section(); - cr = libxl_xen_console_read_start(CTX, c_clear); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + cr = libxl_xen_console_read_start(CTX, c_clear); + caml_leave_blocking_section(); - handle = caml_alloc_custom(&libxl_console_reader_custom_operations, sizeof(cr), 0, 1); - Console_reader_val(handle) = cr; + handle = caml_alloc_custom(&libxl_console_reader_custom_operations, sizeof(cr), 0, 1); + Console_reader_val(handle) = cr; - CAMLreturn(handle); + CAMLreturn(handle); } static void raise_eof(void) { - static const value *exc = NULL; + static const value *exc = NULL; - /* First time around, lookup by name */ - if (!exc) - exc = caml_named_value("Xenlight.Host.End_of_file"); + /* First time around, lookup by name */ + if (!exc) + exc = caml_named_value("Xenlight.Host.End_of_file"); - if (!exc) - caml_invalid_argument("Exception Xenlight.Host.End_of_file not initialized, please link xenlight.cma"); + if (!exc) + caml_invalid_argument("Exception Xenlight.Host.End_of_file not initialized, please link xenlight.cma"); - caml_raise_constant(*exc); + caml_raise_constant(*exc); } value stub_libxl_xen_console_read_line(value ctx, value reader) { - CAMLparam2(ctx, reader); - CAMLlocal1(line); - int ret; - char *c_line; - libxl_xen_console_reader *cr = (libxl_xen_console_reader *) Console_reader_val(reader); + CAMLparam2(ctx, reader); + CAMLlocal1(line); + int ret; + char *c_line; + libxl_xen_console_reader *cr = (libxl_xen_console_reader *) Console_reader_val(reader); - caml_enter_blocking_section(); - ret = libxl_xen_console_read_line(CTX, cr, &c_line); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + ret = libxl_xen_console_read_line(CTX, cr, &c_line); + caml_leave_blocking_section(); - if (ret < 0) - failwith_xl(ret, "xen_console_read_line"); - if (ret == 0) - raise_eof(); + if (ret < 0) + failwith_xl(ret, "xen_console_read_line"); + if (ret == 0) + raise_eof(); - line = caml_copy_string(c_line); + line = caml_copy_string(c_line); - CAMLreturn(line); + CAMLreturn(line); } value stub_libxl_xen_console_read_finish(value ctx, value reader) { - CAMLparam2(ctx, reader); - libxl_xen_console_reader *cr = (libxl_xen_console_reader *) Console_reader_val(reader); + CAMLparam2(ctx, reader); + libxl_xen_console_reader *cr = (libxl_xen_console_reader *) Console_reader_val(reader); - caml_enter_blocking_section(); - libxl_xen_console_read_finish(CTX, cr); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + libxl_xen_console_read_finish(CTX, cr); + caml_leave_blocking_section(); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } /* Event handling */ short Poll_val(value event) { - CAMLparam1(event); - short res = -1; + CAMLparam1(event); + short res = -1; - switch (Int_val(event)) { - case 0: res = POLLIN; break; - case 1: res = POLLPRI; break; - case 2: res = POLLOUT; break; - case 3: res = POLLERR; break; - case 4: res = POLLHUP; break; - case 5: res = POLLNVAL; break; - } + switch (Int_val(event)) { + case 0: res = POLLIN; break; + case 1: res = POLLPRI; break; + case 2: res = POLLOUT; break; + case 3: res = POLLERR; break; + case 4: res = POLLHUP; break; + case 5: res = POLLNVAL; break; + } - CAMLreturn(res); + CAMLreturn(res); } short Poll_events_val(value event_list) { - CAMLparam1(event_list); - short events = 0; + CAMLparam1(event_list); + short events = 0; - while (event_list != Val_emptylist) { - events |= Poll_val(Field(event_list, 0)); - event_list = Field(event_list, 1); - } + while (event_list != Val_emptylist) { + events |= Poll_val(Field(event_list, 0)); + event_list = Field(event_list, 1); + } - CAMLreturn(events); + CAMLreturn(events); } value Val_poll(short event) { - CAMLparam0(); - CAMLlocal1(res); + CAMLparam0(); + CAMLlocal1(res); - switch (event) { - case POLLIN: res = Val_int(0); break; - case POLLPRI: res = Val_int(1); break; - case POLLOUT: res = Val_int(2); break; - case POLLERR: res = Val_int(3); break; - case POLLHUP: res = Val_int(4); break; - case POLLNVAL: res = Val_int(5); break; - default: failwith_xl(ERROR_FAIL, "cannot convert poll event value"); break; - } + switch (event) { + case POLLIN: res = Val_int(0); break; + case POLLPRI: res = Val_int(1); break; + case POLLOUT: res = Val_int(2); break; + case POLLERR: res = Val_int(3); break; + case POLLHUP: res = Val_int(4); break; + case POLLNVAL: res = Val_int(5); break; + default: failwith_xl(ERROR_FAIL, "cannot convert poll event value"); break; + } - CAMLreturn(res); + CAMLreturn(res); } value add_event(value event_list, short event) { - CAMLparam1(event_list); - CAMLlocal1(new_list); + CAMLparam1(event_list); + CAMLlocal1(new_list); - new_list = caml_alloc(2, 0); - Store_field(new_list, 0, Val_poll(event)); - Store_field(new_list, 1, event_list); + new_list = caml_alloc(2, 0); + Store_field(new_list, 0, Val_poll(event)); + Store_field(new_list, 1, event_list); - CAMLreturn(new_list); + CAMLreturn(new_list); } value Val_poll_events(short events) { - CAMLparam0(); - CAMLlocal1(event_list); + CAMLparam0(); + CAMLlocal1(event_list); - event_list = Val_emptylist; - if (events & POLLIN) - event_list = add_event(event_list, POLLIN); - if (events & POLLPRI) - event_list = add_event(event_list, POLLPRI); - if (events & POLLOUT) - event_list = add_event(event_list, POLLOUT); - if (events & POLLERR) - event_list = add_event(event_list, POLLERR); - if (events & POLLHUP) - event_list = add_event(event_list, POLLHUP); - if (events & POLLNVAL) - event_list = add_event(event_list, POLLNVAL); + event_list = Val_emptylist; + if (events & POLLIN) + event_list = add_event(event_list, POLLIN); + if (events & POLLPRI) + event_list = add_event(event_list, POLLPRI); + if (events & POLLOUT) + event_list = add_event(event_list, POLLOUT); + if (events & POLLERR) + event_list = add_event(event_list, POLLERR); + if (events & POLLHUP) + event_list = add_event(event_list, POLLHUP); + if (events & POLLNVAL) + event_list = add_event(event_list, POLLNVAL); - CAMLreturn(event_list); + CAMLreturn(event_list); } /* The process for dealing with the for_app_registration_ values in the @@ -1273,385 +1273,385 @@ value Val_poll_events(short events) int fd_register(void *user, int fd, void **for_app_registration_out, short events, void *for_libxl) { - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocalN(args, 4); - int ret = 0; - static const value *func = NULL; - value *p = (value *) user; - value *for_app; + caml_leave_blocking_section(); + CAMLparam0(); + CAMLlocalN(args, 4); + int ret = 0; + static const value *func = NULL; + value *p = (value *) user; + value *for_app; - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_fd_register"); - } + if (func == NULL) { + /* First time around, lookup by name */ + func = caml_named_value("libxl_fd_register"); + } - args[0] = *p; - args[1] = Val_int(fd); - args[2] = Val_poll_events(events); - args[3] = (value) for_libxl; + args[0] = *p; + args[1] = Val_int(fd); + args[2] = Val_poll_events(events); + args[3] = (value) for_libxl; - for_app = malloc(sizeof(value)); - if (!for_app) { - ret = ERROR_OSEVENT_REG_FAIL; - goto err; - } + for_app = malloc(sizeof(value)); + if (!for_app) { + ret = ERROR_OSEVENT_REG_FAIL; + goto err; + } - *for_app = caml_callbackN_exn(*func, 4, args); - if (Is_exception_result(*for_app)) { - ret = ERROR_OSEVENT_REG_FAIL; - free(for_app); - goto err; - } + *for_app = caml_callbackN_exn(*func, 4, args); + if (Is_exception_result(*for_app)) { + ret = ERROR_OSEVENT_REG_FAIL; + free(for_app); + goto err; + } - caml_register_global_root(for_app); - *for_app_registration_out = for_app; + caml_register_global_root(for_app); + *for_app_registration_out = for_app; err: - CAMLdone; - caml_enter_blocking_section(); - return ret; + CAMLdone; + caml_enter_blocking_section(); + return ret; } int fd_modify(void *user, int fd, void **for_app_registration_update, short events) { - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocalN(args, 4); - int ret = 0; - static const value *func = NULL; - value *p = (value *) user; - value *for_app = *for_app_registration_update; + caml_leave_blocking_section(); + CAMLparam0(); + CAMLlocalN(args, 4); + int ret = 0; + static const value *func = NULL; + value *p = (value *) user; + value *for_app = *for_app_registration_update; - /* If for_app == NULL, then something is very wrong */ - assert(for_app); + /* If for_app == NULL, then something is very wrong */ + assert(for_app); - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_fd_modify"); - } + if (func == NULL) { + /* First time around, lookup by name */ + func = caml_named_value("libxl_fd_modify"); + } - args[0] = *p; - args[1] = Val_int(fd); - args[2] = *for_app; - args[3] = Val_poll_events(events); + args[0] = *p; + args[1] = Val_int(fd); + args[2] = *for_app; + args[3] = Val_poll_events(events); - *for_app = caml_callbackN_exn(*func, 4, args); - if (Is_exception_result(*for_app)) { - /* If an exception is caught, *for_app_registration_update is not - * changed. It remains a valid pointer to a value that is registered - * with the GC. */ - ret = ERROR_OSEVENT_REG_FAIL; - goto err; - } + *for_app = caml_callbackN_exn(*func, 4, args); + if (Is_exception_result(*for_app)) { + /* If an exception is caught, *for_app_registration_update is not + * changed. It remains a valid pointer to a value that is registered + * with the GC. */ + ret = ERROR_OSEVENT_REG_FAIL; + goto err; + } - *for_app_registration_update = for_app; + *for_app_registration_update = for_app; err: - CAMLdone; - caml_enter_blocking_section(); - return ret; + CAMLdone; + caml_enter_blocking_section(); + return ret; } void fd_deregister(void *user, int fd, void *for_app_registration) { - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocalN(args, 3); - static const value *func = NULL; - value *p = (value *) user; - value *for_app = for_app_registration; + caml_leave_blocking_section(); + CAMLparam0(); + CAMLlocalN(args, 3); + static const value *func = NULL; + value *p = (value *) user; + value *for_app = for_app_registration; - /* If for_app == NULL, then something is very wrong */ - assert(for_app); + /* If for_app == NULL, then something is very wrong */ + assert(for_app); - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_fd_deregister"); - } + if (func == NULL) { + /* First time around, lookup by name */ + func = caml_named_value("libxl_fd_deregister"); + } - args[0] = *p; - args[1] = Val_int(fd); - args[2] = *for_app; + args[0] = *p; + args[1] = Val_int(fd); + args[2] = *for_app; - caml_callbackN_exn(*func, 3, args); - /* This hook does not return error codes, so the best thing we can do - * to avoid trouble, if we catch an exception from the app, is abort. */ - if (Is_exception_result(*for_app)) - abort(); + caml_callbackN_exn(*func, 3, args); + /* This hook does not return error codes, so the best thing we can do + * to avoid trouble, if we catch an exception from the app, is abort. */ + if (Is_exception_result(*for_app)) + abort(); - caml_remove_global_root(for_app); - free(for_app); + caml_remove_global_root(for_app); + free(for_app); - CAMLdone; - caml_enter_blocking_section(); + CAMLdone; + caml_enter_blocking_section(); } struct timeout_handles { - void *for_libxl; - value for_app; + void *for_libxl; + value for_app; }; int timeout_register(void *user, void **for_app_registration_out, struct timeval abs, void *for_libxl) { - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocal2(sec, usec); - CAMLlocalN(args, 4); - int ret = 0; - static const value *func = NULL; - value *p = (value *) user; - struct timeout_handles *handles; + caml_leave_blocking_section(); + CAMLparam0(); + CAMLlocal2(sec, usec); + CAMLlocalN(args, 4); + int ret = 0; + static const value *func = NULL; + value *p = (value *) user; + struct timeout_handles *handles; - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_timeout_register"); - } + if (func == NULL) { + /* First time around, lookup by name */ + func = caml_named_value("libxl_timeout_register"); + } - sec = caml_copy_int64(abs.tv_sec); - usec = caml_copy_int64(abs.tv_usec); + sec = caml_copy_int64(abs.tv_sec); + usec = caml_copy_int64(abs.tv_usec); - /* This struct of "handles" will contain "for_libxl" as well as "for_app". - * We'll give a pointer to the struct to the app, and get it back in - * occurred_timeout, where we can clean it all up. */ - handles = malloc(sizeof(*handles)); - if (!handles) { - ret = ERROR_OSEVENT_REG_FAIL; - goto err; - } + /* This struct of "handles" will contain "for_libxl" as well as "for_app". + * We'll give a pointer to the struct to the app, and get it back in + * occurred_timeout, where we can clean it all up. */ + handles = malloc(sizeof(*handles)); + if (!handles) { + ret = ERROR_OSEVENT_REG_FAIL; + goto err; + } - handles->for_libxl = for_libxl; + handles->for_libxl = for_libxl; - args[0] = *p; - args[1] = sec; - args[2] = usec; - args[3] = (value) handles; + args[0] = *p; + args[1] = sec; + args[2] = usec; + args[3] = (value) handles; - handles->for_app = caml_callbackN_exn(*func, 4, args); - if (Is_exception_result(handles->for_app)) { - ret = ERROR_OSEVENT_REG_FAIL; - free(handles); - goto err; - } + handles->for_app = caml_callbackN_exn(*func, 4, args); + if (Is_exception_result(handles->for_app)) { + ret = ERROR_OSEVENT_REG_FAIL; + free(handles); + goto err; + } - caml_register_global_root(&handles->for_app); - *for_app_registration_out = handles; + caml_register_global_root(&handles->for_app); + *for_app_registration_out = handles; err: - CAMLdone; - caml_enter_blocking_section(); - return ret; + CAMLdone; + caml_enter_blocking_section(); + return ret; } int timeout_modify(void *user, void **for_app_registration_update, struct timeval abs) { - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocal1(for_app_update); - CAMLlocalN(args, 2); - int ret = 0; - static const value *func = NULL; - value *p = (value *) user; - struct timeout_handles *handles = *for_app_registration_update; + caml_leave_blocking_section(); + CAMLparam0(); + CAMLlocal1(for_app_update); + CAMLlocalN(args, 2); + int ret = 0; + static const value *func = NULL; + value *p = (value *) user; + struct timeout_handles *handles = *for_app_registration_update; - /* If for_app == NULL, then something is very wrong */ - assert(handles->for_app); + /* If for_app == NULL, then something is very wrong */ + assert(handles->for_app); - /* Libxl currently promises that timeout_modify is only ever called with - * abs={0,0}, meaning "right away". We cannot deal with other values. */ - assert(abs.tv_sec == 0 && abs.tv_usec == 0); + /* Libxl currently promises that timeout_modify is only ever called with + * abs={0,0}, meaning "right away". We cannot deal with other values. */ + assert(abs.tv_sec == 0 && abs.tv_usec == 0); - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_timeout_fire_now"); - } + if (func == NULL) { + /* First time around, lookup by name */ + func = caml_named_value("libxl_timeout_fire_now"); + } - args[0] = *p; - args[1] = handles->for_app; + args[0] = *p; + args[1] = handles->for_app; - for_app_update = caml_callbackN_exn(*func, 2, args); - if (Is_exception_result(for_app_update)) { - /* If an exception is caught, *for_app_registration_update is not - * changed. It remains a valid pointer to a value that is registered - * with the GC. */ - ret = ERROR_OSEVENT_REG_FAIL; - goto err; - } + for_app_update = caml_callbackN_exn(*func, 2, args); + if (Is_exception_result(for_app_update)) { + /* If an exception is caught, *for_app_registration_update is not + * changed. It remains a valid pointer to a value that is registered + * with the GC. */ + ret = ERROR_OSEVENT_REG_FAIL; + goto err; + } - handles->for_app = for_app_update; + handles->for_app = for_app_update; err: - CAMLdone; - caml_enter_blocking_section(); - return ret; + CAMLdone; + caml_enter_blocking_section(); + return ret; } void timeout_deregister(void *user, void *for_app_registration) { - /* This hook will never be called by libxl. */ - abort(); + /* This hook will never be called by libxl. */ + abort(); } value stub_libxl_osevent_register_hooks(value ctx, value user) { - CAMLparam2(ctx, user); - CAMLlocal1(result); - libxl_osevent_hooks *hooks; - value *p; + CAMLparam2(ctx, user); + CAMLlocal1(result); + libxl_osevent_hooks *hooks; + value *p; - hooks = malloc(sizeof(*hooks)); - if (!hooks) - failwith_xl(ERROR_NOMEM, "cannot allocate osevent hooks"); - hooks->fd_register = fd_register; - hooks->fd_modify = fd_modify; - hooks->fd_deregister = fd_deregister; - hooks->timeout_register = timeout_register; - hooks->timeout_modify = timeout_modify; - hooks->timeout_deregister = timeout_deregister; + hooks = malloc(sizeof(*hooks)); + if (!hooks) + failwith_xl(ERROR_NOMEM, "cannot allocate osevent hooks"); + hooks->fd_register = fd_register; + hooks->fd_modify = fd_modify; + hooks->fd_deregister = fd_deregister; + hooks->timeout_register = timeout_register; + hooks->timeout_modify = timeout_modify; + hooks->timeout_deregister = timeout_deregister; - p = malloc(sizeof(value)); - if (!p) - failwith_xl(ERROR_NOMEM, "cannot allocate value"); - *p = user; - caml_register_global_root(p); + p = malloc(sizeof(value)); + if (!p) + failwith_xl(ERROR_NOMEM, "cannot allocate value"); + *p = user; + caml_register_global_root(p); - caml_enter_blocking_section(); - libxl_osevent_register_hooks(CTX, hooks, (void *) p); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + libxl_osevent_register_hooks(CTX, hooks, (void *) p); + caml_leave_blocking_section(); - result = caml_alloc(1, Abstract_tag); - *((libxl_osevent_hooks **) result) = hooks; + result = caml_alloc(1, Abstract_tag); + *((libxl_osevent_hooks **) result) = hooks; - CAMLreturn(result); + CAMLreturn(result); } value stub_libxl_osevent_occurred_fd(value ctx, value for_libxl, value fd, - value events, value revents) + value events, value revents) { - CAMLparam5(ctx, for_libxl, fd, events, revents); - int c_fd = Int_val(fd); - short c_events = Poll_events_val(events); - short c_revents = Poll_events_val(revents); + CAMLparam5(ctx, for_libxl, fd, events, revents); + int c_fd = Int_val(fd); + short c_events = Poll_events_val(events); + short c_revents = Poll_events_val(revents); - caml_enter_blocking_section(); - libxl_osevent_occurred_fd(CTX, (void *) for_libxl, c_fd, c_events, c_revents); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + libxl_osevent_occurred_fd(CTX, (void *) for_libxl, c_fd, c_events, c_revents); + caml_leave_blocking_section(); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } value stub_libxl_osevent_occurred_timeout(value ctx, value handles) { - CAMLparam1(ctx); - struct timeout_handles *c_handles = (struct timeout_handles *) handles; + CAMLparam1(ctx); + struct timeout_handles *c_handles = (struct timeout_handles *) handles; - caml_enter_blocking_section(); - libxl_osevent_occurred_timeout(CTX, (void *) c_handles->for_libxl); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + libxl_osevent_occurred_timeout(CTX, (void *) c_handles->for_libxl); + caml_leave_blocking_section(); - caml_remove_global_root(&c_handles->for_app); - free(c_handles); + caml_remove_global_root(&c_handles->for_app); + free(c_handles); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } struct user_with_ctx { - libxl_ctx *ctx; - value user; + libxl_ctx *ctx; + value user; }; void event_occurs(void *user, libxl_event *event) { - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocalN(args, 2); - struct user_with_ctx *c_user = (struct user_with_ctx *) user; - static const value *func = NULL; + caml_leave_blocking_section(); + CAMLparam0(); + CAMLlocalN(args, 2); + struct user_with_ctx *c_user = (struct user_with_ctx *) user; + static const value *func = NULL; - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_event_occurs_callback"); - } + if (func == NULL) { + /* First time around, lookup by name */ + func = caml_named_value("libxl_event_occurs_callback"); + } - args[0] = c_user->user; - args[1] = Val_event(event); - libxl_event_free(c_user->ctx, event); + args[0] = c_user->user; + args[1] = Val_event(event); + libxl_event_free(c_user->ctx, event); - caml_callbackN(*func, 2, args); - CAMLdone; - caml_enter_blocking_section(); + caml_callbackN(*func, 2, args); + CAMLdone; + caml_enter_blocking_section(); } void disaster(void *user, libxl_event_type type, const char *msg, int errnoval) { - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocalN(args, 4); - struct user_with_ctx *c_user = (struct user_with_ctx *) user; - static const value *func = NULL; + caml_leave_blocking_section(); + CAMLparam0(); + CAMLlocalN(args, 4); + struct user_with_ctx *c_user = (struct user_with_ctx *) user; + static const value *func = NULL; - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_event_disaster_callback"); - } + if (func == NULL) { + /* First time around, lookup by name */ + func = caml_named_value("libxl_event_disaster_callback"); + } - args[0] = c_user->user; - args[1] = Val_event_type(type); - args[2] = caml_copy_string(msg); - args[3] = Val_int(errnoval); + args[0] = c_user->user; + args[1] = Val_event_type(type); + args[2] = caml_copy_string(msg); + args[3] = Val_int(errnoval); - caml_callbackN(*func, 4, args); - CAMLdone; - caml_enter_blocking_section(); + caml_callbackN(*func, 4, args); + CAMLdone; + caml_enter_blocking_section(); } value stub_libxl_event_register_callbacks(value ctx, value user) { - CAMLparam2(ctx, user); - CAMLlocal1(result); - struct user_with_ctx *c_user = NULL; - libxl_event_hooks *hooks; + CAMLparam2(ctx, user); + CAMLlocal1(result); + struct user_with_ctx *c_user = NULL; + libxl_event_hooks *hooks; - c_user = malloc(sizeof(*c_user)); - if (!c_user) - failwith_xl(ERROR_NOMEM, "cannot allocate user value"); - c_user->user = user; - c_user->ctx = CTX; - caml_register_global_root(&c_user->user); + c_user = malloc(sizeof(*c_user)); + if (!c_user) + failwith_xl(ERROR_NOMEM, "cannot allocate user value"); + c_user->user = user; + c_user->ctx = CTX; + caml_register_global_root(&c_user->user); - hooks = malloc(sizeof(*hooks)); - if (!hooks) - failwith_xl(ERROR_NOMEM, "cannot allocate event hooks"); - hooks->event_occurs_mask = LIBXL_EVENTMASK_ALL; - hooks->event_occurs = event_occurs; - hooks->disaster = disaster; + hooks = malloc(sizeof(*hooks)); + if (!hooks) + failwith_xl(ERROR_NOMEM, "cannot allocate event hooks"); + hooks->event_occurs_mask = LIBXL_EVENTMASK_ALL; + hooks->event_occurs = event_occurs; + hooks->disaster = disaster; - caml_enter_blocking_section(); - libxl_event_register_callbacks(CTX, hooks, (void *) c_user); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + libxl_event_register_callbacks(CTX, hooks, (void *) c_user); + caml_leave_blocking_section(); - result = caml_alloc(1, Abstract_tag); - *((libxl_event_hooks **) result) = hooks; + result = caml_alloc(1, Abstract_tag); + *((libxl_event_hooks **) result) = hooks; - CAMLreturn(result); + CAMLreturn(result); } value stub_libxl_evenable_domain_death(value ctx, value domid, value user) { - CAMLparam3(ctx, domid, user); - uint32_t c_domid = Int_val(domid); - int c_user = Int_val(user); - libxl_evgen_domain_death *evgen_out; + CAMLparam3(ctx, domid, user); + uint32_t c_domid = Int_val(domid); + int c_user = Int_val(user); + libxl_evgen_domain_death *evgen_out; - caml_enter_blocking_section(); - libxl_evenable_domain_death(CTX, c_domid, c_user, &evgen_out); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + libxl_evenable_domain_death(CTX, c_domid, c_user, &evgen_out); + caml_leave_blocking_section(); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } /* diff --git a/tools/ocaml/libs/xs/queueop.ml b/tools/ocaml/libs/xs/queueop.ml index 4e532cdaea..e069ab7a9c 100644 --- a/tools/ocaml/libs/xs/queueop.ml +++ b/tools/ocaml/libs/xs/queueop.ml @@ -18,8 +18,8 @@ open Xenbus let data_concat ls = (String.concat "\000" ls) ^ "\000" let queue con pkt = let r = Xb.queue con pkt in assert (r <> None) let queue_path ty (tid: int) (path: string) con = - let data = data_concat [ path; ] in - queue con (Xb.Packet.create tid 0 ty data) + let data = data_concat [ path; ] in + queue con (Xb.Packet.create tid 0 ty data) (* operations *) let directory tid path con = queue_path Xb.Op.Directory tid path con @@ -28,48 +28,48 @@ let read tid path con = queue_path Xb.Op.Read tid path con let getperms tid path con = queue_path Xb.Op.Getperms tid path con let debug commands con = - queue con (Xb.Packet.create 0 0 Xb.Op.Debug (data_concat commands)) + queue con (Xb.Packet.create 0 0 Xb.Op.Debug (data_concat commands)) let watch path data con = - let data = data_concat [ path; data; ] in - queue con (Xb.Packet.create 0 0 Xb.Op.Watch data) + let data = data_concat [ path; data; ] in + queue con (Xb.Packet.create 0 0 Xb.Op.Watch data) let unwatch path data con = - let data = data_concat [ path; data; ] in - queue con (Xb.Packet.create 0 0 Xb.Op.Unwatch data) + let data = data_concat [ path; data; ] in + queue con (Xb.Packet.create 0 0 Xb.Op.Unwatch data) let transaction_start con = - queue con (Xb.Packet.create 0 0 Xb.Op.Transaction_start (data_concat [])) + queue con (Xb.Packet.create 0 0 Xb.Op.Transaction_start (data_concat [])) let transaction_end tid commit con = - let data = data_concat [ (if commit then "T" else "F"); ] in - queue con (Xb.Packet.create tid 0 Xb.Op.Transaction_end data) + let data = data_concat [ (if commit then "T" else "F"); ] in + queue con (Xb.Packet.create tid 0 Xb.Op.Transaction_end data) let introduce domid mfn port con = - let data = data_concat [ Printf.sprintf "%u" domid; - Printf.sprintf "%nu" mfn; - string_of_int port; ] in - queue con (Xb.Packet.create 0 0 Xb.Op.Introduce data) + let data = data_concat [ Printf.sprintf "%u" domid; + Printf.sprintf "%nu" mfn; + string_of_int port; ] in + queue con (Xb.Packet.create 0 0 Xb.Op.Introduce data) let release domid con = - let data = data_concat [ Printf.sprintf "%u" domid; ] in - queue con (Xb.Packet.create 0 0 Xb.Op.Release data) + let data = data_concat [ Printf.sprintf "%u" domid; ] in + queue con (Xb.Packet.create 0 0 Xb.Op.Release data) let resume domid con = - let data = data_concat [ Printf.sprintf "%u" domid; ] in - queue con (Xb.Packet.create 0 0 Xb.Op.Resume data) + let data = data_concat [ Printf.sprintf "%u" domid; ] in + queue con (Xb.Packet.create 0 0 Xb.Op.Resume data) let getdomainpath domid con = - let data = data_concat [ Printf.sprintf "%u" domid; ] in - queue con (Xb.Packet.create 0 0 Xb.Op.Getdomainpath data) + let data = data_concat [ Printf.sprintf "%u" domid; ] in + queue con (Xb.Packet.create 0 0 Xb.Op.Getdomainpath data) let write tid path value con = - let data = path ^ "\000" ^ value (* no NULL at the end *) in - queue con (Xb.Packet.create tid 0 Xb.Op.Write data) + let data = path ^ "\000" ^ value (* no NULL at the end *) in + queue con (Xb.Packet.create tid 0 Xb.Op.Write data) let mkdir tid path con = queue_path Xb.Op.Mkdir tid path con let rm tid path con = queue_path Xb.Op.Rm tid path con let setperms tid path perms con = - let data = data_concat [ path; perms ] in - queue con (Xb.Packet.create tid 0 Xb.Op.Setperms data) + let data = data_concat [ path; perms ] in + queue con (Xb.Packet.create tid 0 Xb.Op.Setperms data) diff --git a/tools/ocaml/libs/xs/xs.ml b/tools/ocaml/libs/xs/xs.ml index 90bd68d73d..55d4f010b6 100644 --- a/tools/ocaml/libs/xs/xs.ml +++ b/tools/ocaml/libs/xs/xs.ml @@ -19,46 +19,46 @@ type con = Xsraw.con type domid = int type xsh = -{ - con: con; - debug: string list -> string; - directory: string -> string list; - read: string -> string; - readv: string -> string list -> string list; - write: string -> string -> unit; - writev: string -> (string * string) list -> unit; - mkdir: string -> unit; - rm: string -> unit; - getperms: string -> perms; - setperms: string -> perms -> unit; - setpermsv: string -> string list -> perms -> unit; - introduce: domid -> nativeint -> int -> unit; - release: domid -> unit; - resume: domid -> unit; - getdomainpath: domid -> string; - watch: string -> string -> unit; - unwatch: string -> string -> unit; -} + { + con: con; + debug: string list -> string; + directory: string -> string list; + read: string -> string; + readv: string -> string list -> string list; + write: string -> string -> unit; + writev: string -> (string * string) list -> unit; + mkdir: string -> unit; + rm: string -> unit; + getperms: string -> perms; + setperms: string -> perms -> unit; + setpermsv: string -> string list -> perms -> unit; + introduce: domid -> nativeint -> int -> unit; + release: domid -> unit; + resume: domid -> unit; + getdomainpath: domid -> string; + watch: string -> string -> unit; + unwatch: string -> string -> unit; + } let get_operations con = { - con = con; - debug = (fun commands -> Xsraw.debug commands con); - directory = (fun path -> Xsraw.directory 0 path con); - read = (fun path -> Xsraw.read 0 path con); - readv = (fun dir vec -> Xsraw.readv 0 dir vec con); - write = (fun path value -> Xsraw.write 0 path value con); - writev = (fun dir vec -> Xsraw.writev 0 dir vec con); - mkdir = (fun path -> Xsraw.mkdir 0 path con); - rm = (fun path -> Xsraw.rm 0 path con); - getperms = (fun path -> Xsraw.getperms 0 path con); - setperms = (fun path perms -> Xsraw.setperms 0 path perms con); - setpermsv = (fun dir vec perms -> Xsraw.setpermsv 0 dir vec perms con); - introduce = (fun id mfn port -> Xsraw.introduce id mfn port con); - release = (fun id -> Xsraw.release id con); - resume = (fun id -> Xsraw.resume id con); - getdomainpath = (fun id -> Xsraw.getdomainpath id con); - watch = (fun path data -> Xsraw.watch path data con); - unwatch = (fun path data -> Xsraw.unwatch path data con); + con = con; + debug = (fun commands -> Xsraw.debug commands con); + directory = (fun path -> Xsraw.directory 0 path con); + read = (fun path -> Xsraw.read 0 path con); + readv = (fun dir vec -> Xsraw.readv 0 dir vec con); + write = (fun path value -> Xsraw.write 0 path value con); + writev = (fun dir vec -> Xsraw.writev 0 dir vec con); + mkdir = (fun path -> Xsraw.mkdir 0 path con); + rm = (fun path -> Xsraw.rm 0 path con); + getperms = (fun path -> Xsraw.getperms 0 path con); + setperms = (fun path perms -> Xsraw.setperms 0 path perms con); + setpermsv = (fun dir vec perms -> Xsraw.setpermsv 0 dir vec perms con); + introduce = (fun id mfn port -> Xsraw.introduce id mfn port con); + release = (fun id -> Xsraw.release id con); + resume = (fun id -> Xsraw.resume id con); + getdomainpath = (fun id -> Xsraw.getdomainpath id con); + watch = (fun path data -> Xsraw.watch path data con); + unwatch = (fun path data -> Xsraw.unwatch path data con); } let transaction xsh = Xst.transaction xsh.con @@ -81,71 +81,71 @@ exception Timeout_with_nonempty_queue let max_blocking_time = 5. (* seconds *) let read_watchevent_timeout xsh timeout callback = - let start_time = Unix.gettimeofday () in - let end_time = start_time +. timeout in + let start_time = Unix.gettimeofday () in + let end_time = start_time +. timeout in - let left = ref timeout in + let left = ref timeout in - (* Returns true if a watch event in the queue satisfied us *) - let process_queued_events () = - let success = ref false in - while Xsraw.has_watchevents xsh.con && not(!success) - do - success := callback (Xsraw.get_watchevent xsh.con) - done; - !success in - (* Returns true if a watch event read from the socket satisfied us *) - let process_incoming_event () = - let fd = get_fd xsh in - let r, _, _ = Unix.select [ fd ] [] [] (min max_blocking_time !left) in + (* Returns true if a watch event in the queue satisfied us *) + let process_queued_events () = + let success = ref false in + while Xsraw.has_watchevents xsh.con && not(!success) + do + success := callback (Xsraw.get_watchevent xsh.con) + done; + !success in + (* Returns true if a watch event read from the socket satisfied us *) + let process_incoming_event () = + let fd = get_fd xsh in + let r, _, _ = Unix.select [ fd ] [] [] (min max_blocking_time !left) in - (* If data is available for reading then read it *) - if r = [] - then false (* timeout, either a max_blocking_time or global *) - else callback (Xsraw.read_watchevent xsh.con) in + (* If data is available for reading then read it *) + if r = [] + then false (* timeout, either a max_blocking_time or global *) + else callback (Xsraw.read_watchevent xsh.con) in - let success = ref false in - while !left > 0. && not(!success) - do - (* NB the 'callback' might call back into Xs functions - and as a side-effect, watches might be queued. Hence - we must process the queue on every loop iteration *) + let success = ref false in + while !left > 0. && not(!success) + do + (* NB the 'callback' might call back into Xs functions + and as a side-effect, watches might be queued. Hence + we must process the queue on every loop iteration *) - (* First process all queued watch events *) - if not(!success) - then success := process_queued_events (); - (* Then block for one more watch event *) - if not(!success) - then success := process_incoming_event (); - (* Just in case our callback caused events to be queued - and this is our last time round the loop: this prevents - us throwing the Timeout_with_nonempty_queue spuriously *) - if not(!success) - then success := process_queued_events (); + (* First process all queued watch events *) + if not(!success) + then success := process_queued_events (); + (* Then block for one more watch event *) + if not(!success) + then success := process_incoming_event (); + (* Just in case our callback caused events to be queued + and this is our last time round the loop: this prevents + us throwing the Timeout_with_nonempty_queue spuriously *) + if not(!success) + then success := process_queued_events (); - (* Update the time left *) - let current_time = Unix.gettimeofday () in - left := end_time -. current_time - done; - if not(!success) then begin - (* Sanity check: it should be impossible for any - events to be queued here *) - if Xsraw.has_watchevents xsh.con - then raise Timeout_with_nonempty_queue - else raise Timeout - end + (* Update the time left *) + let current_time = Unix.gettimeofday () in + left := end_time -. current_time + done; + if not(!success) then begin + (* Sanity check: it should be impossible for any + events to be queued here *) + if Xsraw.has_watchevents xsh.con + then raise Timeout_with_nonempty_queue + else raise Timeout + end let monitor_paths xsh l time callback = - let unwatch () = - List.iter (fun (w,v) -> try xsh.unwatch w v with _ -> ()) l in - List.iter (fun (w,v) -> xsh.watch w v) l; - begin try - read_watchevent_timeout xsh time callback; - with - exn -> unwatch (); raise exn; - end; - unwatch () + let unwatch () = + List.iter (fun (w,v) -> try xsh.unwatch w v with _ -> ()) l in + List.iter (fun (w,v) -> xsh.watch w v) l; + begin try + read_watchevent_timeout xsh time callback; + with + exn -> unwatch (); raise exn; + end; + unwatch () let daemon_socket = Paths.xen_run_stored ^ "/socket" @@ -153,24 +153,24 @@ let daemon_socket = Paths.xen_run_stored ^ "/socket" exception Failed_to_connect let daemon_open () = - try - let sockaddr = Unix.ADDR_UNIX(daemon_socket) in - let sock = Unix.socket Unix.PF_UNIX Unix.SOCK_STREAM 0 in - Unix.connect sock sockaddr; - Unix.set_close_on_exec sock; - make sock - with _ -> raise Failed_to_connect + try + let sockaddr = Unix.ADDR_UNIX(daemon_socket) in + let sock = Unix.socket Unix.PF_UNIX Unix.SOCK_STREAM 0 in + Unix.connect sock sockaddr; + Unix.set_close_on_exec sock; + make sock + with _ -> raise Failed_to_connect let domain_open () = - let path = try - let devpath = "/dev/xen/xenbus" in - Unix.access devpath [ Unix.F_OK ]; - devpath - with Unix.Unix_error(_, _, _) -> - "/proc/xen/xenbus" in + let path = try + let devpath = "/dev/xen/xenbus" in + Unix.access devpath [ Unix.F_OK ]; + devpath + with Unix.Unix_error(_, _, _) -> + "/proc/xen/xenbus" in - let fd = Unix.openfile path [ Unix.O_RDWR ] 0o550 in - Unix.set_close_on_exec fd; - make fd + let fd = Unix.openfile path [ Unix.O_RDWR ] 0o550 in + Unix.set_close_on_exec fd; + make fd let close xsh = Xsraw.close xsh.con diff --git a/tools/ocaml/libs/xs/xs.mli b/tools/ocaml/libs/xs/xs.mli index ce505b659b..cf8855c7d8 100644 --- a/tools/ocaml/libs/xs/xs.mli +++ b/tools/ocaml/libs/xs/xs.mli @@ -23,31 +23,31 @@ exception Failed_to_connect - owner domid. - other perm: applied to domain that is not owner or in ACL. - ACL: list of per-domain permission - *) +*) type perms = Xsraw.perms type domid = int type con type xsh = { - con : con; - debug: string list -> string; - directory : string -> string list; - read : string -> string; - readv : string -> string list -> string list; - write : string -> string -> unit; - writev : string -> (string * string) list -> unit; - mkdir : string -> unit; - rm : string -> unit; - getperms : string -> perms; - setperms : string -> perms -> unit; - setpermsv : string -> string list -> perms -> unit; - introduce : domid -> nativeint -> int -> unit; - release : domid -> unit; - resume : domid -> unit; - getdomainpath : domid -> string; - watch : string -> string -> unit; - unwatch : string -> string -> unit; + con : con; + debug: string list -> string; + directory : string -> string list; + read : string -> string; + readv : string -> string list -> string list; + write : string -> string -> unit; + writev : string -> (string * string) list -> unit; + mkdir : string -> unit; + rm : string -> unit; + getperms : string -> perms; + setperms : string -> perms -> unit; + setpermsv : string -> string list -> perms -> unit; + introduce : domid -> nativeint -> int -> unit; + release : domid -> unit; + resume : domid -> unit; + getdomainpath : domid -> string; + watch : string -> string -> unit; + unwatch : string -> string -> unit; } (** get operations provide a vector of xenstore function that apply to one @@ -75,10 +75,10 @@ val read_watchevent_timeout : xsh -> float -> (string * string -> bool) -> unit (** register a set of watches, then wait for watchevent. remove all watches previously set before giving back the hand. *) val monitor_paths : xsh - -> (string * string) list - -> float - -> (string * string -> bool) - -> unit + -> (string * string) list + -> float + -> (string * string -> bool) + -> unit (** open a socket-based xenstored connection *) val daemon_open : unit -> xsh diff --git a/tools/ocaml/libs/xs/xsraw.ml b/tools/ocaml/libs/xs/xsraw.ml index cbd1728060..d51e40eed3 100644 --- a/tools/ocaml/libs/xs/xsraw.ml +++ b/tools/ocaml/libs/xs/xsraw.ml @@ -23,239 +23,239 @@ exception Unexpected_packet of string exception Invalid_path of string let unexpected_packet expected received = - let s = Printf.sprintf "expecting %s received %s" - (Xb.Op.to_string expected) - (Xb.Op.to_string received) in - raise (Unexpected_packet s) + let s = Printf.sprintf "expecting %s received %s" + (Xb.Op.to_string expected) + (Xb.Op.to_string received) in + raise (Unexpected_packet s) type con = { - xb: Xenbus.Xb.t; - watchevents: (string * string) Queue.t; + xb: Xenbus.Xb.t; + watchevents: (string * string) Queue.t; } let close con = - Xb.close con.xb + Xb.close con.xb let capacity = { Xb.maxoutstanding = 1; maxwatchevents = 0; } let open_fd fd = { - xb = Xb.open_fd ~capacity fd; - watchevents = Queue.create (); + xb = Xb.open_fd ~capacity fd; + watchevents = Queue.create (); } let rec split_string ?limit:(limit=(-1)) c s = - let i = try String.index s c with Not_found -> -1 in - let nlimit = if limit = -1 || limit = 0 then limit else limit - 1 in - if i = -1 || nlimit = 0 then - [ s ] - else - let a = String.sub s 0 i - and b = String.sub s (i + 1) (String.length s - i - 1) in - a :: (split_string ~limit: nlimit c b) + let i = try String.index s c with Not_found -> -1 in + let nlimit = if limit = -1 || limit = 0 then limit else limit - 1 in + if i = -1 || nlimit = 0 then + [ s ] + else + let a = String.sub s 0 i + and b = String.sub s (i + 1) (String.length s - i - 1) in + a :: (split_string ~limit: nlimit c b) type perm = PERM_NONE | PERM_READ | PERM_WRITE | PERM_RDWR type perms = int * perm * (int * perm) list let string_of_perms perms = - let owner, other, acl = perms in - let char_of_perm perm = - match perm with PERM_NONE -> 'n' | PERM_READ -> 'r' - | PERM_WRITE -> 'w' | PERM_RDWR -> 'b' in - let string_of_perm (id, perm) = Printf.sprintf "%c%u" (char_of_perm perm) id in - String.concat "\000" (List.map string_of_perm ((owner,other) :: acl)) + let owner, other, acl = perms in + let char_of_perm perm = + match perm with PERM_NONE -> 'n' | PERM_READ -> 'r' + | PERM_WRITE -> 'w' | PERM_RDWR -> 'b' in + let string_of_perm (id, perm) = Printf.sprintf "%c%u" (char_of_perm perm) id in + String.concat "\000" (List.map string_of_perm ((owner,other) :: acl)) let perms_of_string s = - let perm_of_char c = - match c with 'n' -> PERM_NONE | 'r' -> PERM_READ - | 'w' -> PERM_WRITE | 'b' -> PERM_RDWR - | c -> invalid_arg (Printf.sprintf "unknown permission type: %c" c) in - let perm_of_string s = - if String.length s < 2 - then invalid_arg (Printf.sprintf "perm of string: length = %d; contents=\"%s\"" (String.length s) s) - else - begin - int_of_string (String.sub s 1 (String.length s - 1)), - perm_of_char s.[0] - end in - let rec split s = - try let i = String.index s '\000' in - String.sub s 0 i :: split (String.sub s (i + 1) (String.length s - 1 - i)) - with Not_found -> if s = "" then [] else [ s ] in - let l = List.map perm_of_string (split s) in - match l with h :: l -> (fst h, snd h, l) | [] -> (0, PERM_NONE, []) + let perm_of_char c = + match c with 'n' -> PERM_NONE | 'r' -> PERM_READ + | 'w' -> PERM_WRITE | 'b' -> PERM_RDWR + | c -> invalid_arg (Printf.sprintf "unknown permission type: %c" c) in + let perm_of_string s = + if String.length s < 2 + then invalid_arg (Printf.sprintf "perm of string: length = %d; contents=\"%s\"" (String.length s) s) + else + begin + int_of_string (String.sub s 1 (String.length s - 1)), + perm_of_char s.[0] + end in + let rec split s = + try let i = String.index s '\000' in + String.sub s 0 i :: split (String.sub s (i + 1) (String.length s - 1 - i)) + with Not_found -> if s = "" then [] else [ s ] in + let l = List.map perm_of_string (split s) in + match l with h :: l -> (fst h, snd h, l) | [] -> (0, PERM_NONE, []) (* send one packet - can sleep *) let pkt_send con = - if Xb.has_old_output con.xb then - raise Partial_not_empty; - let workdone = ref false in - while not !workdone - do - workdone := Xb.output con.xb - done + if Xb.has_old_output con.xb then + raise Partial_not_empty; + let workdone = ref false in + while not !workdone + do + workdone := Xb.output con.xb + done (* receive one packet - can sleep *) let rec pkt_recv con = - match Xb.input con.xb with - | Some packet -> packet - | None -> pkt_recv con + match Xb.input con.xb with + | Some packet -> packet + | None -> pkt_recv con let pkt_recv_timeout con timeout = - let fd = Xb.get_fd con.xb in - let r, _, _ = Unix.select [ fd ] [] [] timeout in - if r = [] then - true, None - else - false, Xb.input con.xb + let fd = Xb.get_fd con.xb in + let r, _, _ = Unix.select [ fd ] [] [] timeout in + if r = [] then + true, None + else + false, Xb.input con.xb let queue_watchevent con data = - let ls = split_string ~limit:2 '\000' data in - if List.length ls != 2 then - raise (Xb.Packet.DataError "arguments number mismatch"); - let event = List.nth ls 0 - and event_data = List.nth ls 1 in - Queue.push (event, event_data) con.watchevents + let ls = split_string ~limit:2 '\000' data in + if List.length ls != 2 then + raise (Xb.Packet.DataError "arguments number mismatch"); + let event = List.nth ls 0 + and event_data = List.nth ls 1 in + Queue.push (event, event_data) con.watchevents let has_watchevents con = Queue.length con.watchevents > 0 let get_watchevent con = Queue.pop con.watchevents let read_watchevent con = - let pkt = pkt_recv con in - match Xb.Packet.get_ty pkt with - | Xb.Op.Watchevent -> - queue_watchevent con (Xb.Packet.get_data pkt); - Queue.pop con.watchevents - | ty -> unexpected_packet Xb.Op.Watchevent ty + let pkt = pkt_recv con in + match Xb.Packet.get_ty pkt with + | Xb.Op.Watchevent -> + queue_watchevent con (Xb.Packet.get_data pkt); + Queue.pop con.watchevents + | ty -> unexpected_packet Xb.Op.Watchevent ty (* send one packet in the queue, and wait for reply *) let rec sync_recv ty con = - let pkt = pkt_recv con in - match Xb.Packet.get_ty pkt with - | Xb.Op.Error -> ( - match Xb.Packet.get_data pkt with - | "ENOENT" -> raise Xb.Noent - | "EAGAIN" -> raise Xb.Eagain - | "EINVAL" -> raise Xb.Invalid - | s -> raise (Xb.Packet.Error s)) - | Xb.Op.Watchevent -> - queue_watchevent con (Xb.Packet.get_data pkt); - sync_recv ty con - | rty when rty = ty -> Xb.Packet.get_data pkt - | rty -> unexpected_packet ty rty + let pkt = pkt_recv con in + match Xb.Packet.get_ty pkt with + | Xb.Op.Error -> ( + match Xb.Packet.get_data pkt with + | "ENOENT" -> raise Xb.Noent + | "EAGAIN" -> raise Xb.Eagain + | "EINVAL" -> raise Xb.Invalid + | s -> raise (Xb.Packet.Error s)) + | Xb.Op.Watchevent -> + queue_watchevent con (Xb.Packet.get_data pkt); + sync_recv ty con + | rty when rty = ty -> Xb.Packet.get_data pkt + | rty -> unexpected_packet ty rty let sync f con = - (* queue a query using function f *) - f con.xb; - if Xb.output_len con.xb = 0 then - Printf.printf "output len = 0\n%!"; - let ty = Xb.Packet.get_ty (Xb.peek_output con.xb) in - pkt_send con; - sync_recv ty con + (* queue a query using function f *) + f con.xb; + if Xb.output_len con.xb = 0 then + Printf.printf "output len = 0\n%!"; + let ty = Xb.Packet.get_ty (Xb.peek_output con.xb) in + pkt_send con; + sync_recv ty con let ack s = - if s = "OK" then () else raise (Xb.Packet.DataError s) + if s = "OK" then () else raise (Xb.Packet.DataError s) (** Check paths are suitable for read/write/mkdir/rm/directory etc (NOT watches) *) let validate_path path = - (* Paths shouldn't have a "//" in the middle *) - let bad = "//" in - for offset = 0 to String.length path - (String.length bad) do - if String.sub path offset (String.length bad) = bad then - raise (Invalid_path path) - done; - (* Paths shouldn't have a "/" at the end, except for the root *) - if path <> "/" && path <> "" && path.[String.length path - 1] = '/' then - raise (Invalid_path path) + (* Paths shouldn't have a "//" in the middle *) + let bad = "//" in + for offset = 0 to String.length path - (String.length bad) do + if String.sub path offset (String.length bad) = bad then + raise (Invalid_path path) + done; + (* Paths shouldn't have a "/" at the end, except for the root *) + if path <> "/" && path <> "" && path.[String.length path - 1] = '/' then + raise (Invalid_path path) (** Check to see if a path is suitable for watches *) let validate_watch_path path = - (* Check for stuff like @releaseDomain etc first *) - if path <> "" && path.[0] = '@' then () - else validate_path path + (* Check for stuff like @releaseDomain etc first *) + if path <> "" && path.[0] = '@' then () + else validate_path path let debug command con = - sync (Queueop.debug command) con + sync (Queueop.debug command) con let directory tid path con = - validate_path path; - let data = sync (Queueop.directory tid path) con in - split_string '\000' data + validate_path path; + let data = sync (Queueop.directory tid path) con in + split_string '\000' data let read tid path con = - validate_path path; - sync (Queueop.read tid path) con + validate_path path; + sync (Queueop.read tid path) con let readv tid dir vec con = - List.map (fun path -> validate_path path; read tid path con) - (if dir <> "" then - (List.map (fun v -> dir ^ "/" ^ v) vec) else vec) + List.map (fun path -> validate_path path; read tid path con) + (if dir <> "" then + (List.map (fun v -> dir ^ "/" ^ v) vec) else vec) let getperms tid path con = - validate_path path; - perms_of_string (sync (Queueop.getperms tid path) con) + validate_path path; + perms_of_string (sync (Queueop.getperms tid path) con) let watch path data con = - validate_watch_path path; - ack (sync (Queueop.watch path data) con) + validate_watch_path path; + ack (sync (Queueop.watch path data) con) let unwatch path data con = - validate_watch_path path; - ack (sync (Queueop.unwatch path data) con) + validate_watch_path path; + ack (sync (Queueop.unwatch path data) con) let transaction_start con = - let data = sync (Queueop.transaction_start) con in - try - int_of_string data - with - _ -> raise (Packet.DataError (Printf.sprintf "int expected; got '%s'" data)) + let data = sync (Queueop.transaction_start) con in + try + int_of_string data + with + _ -> raise (Packet.DataError (Printf.sprintf "int expected; got '%s'" data)) let transaction_end tid commit con = - try - ack (sync (Queueop.transaction_end tid commit) con); - true - with - Xb.Eagain -> false + try + ack (sync (Queueop.transaction_end tid commit) con); + true + with + Xb.Eagain -> false let introduce domid mfn port con = - ack (sync (Queueop.introduce domid mfn port) con) + ack (sync (Queueop.introduce domid mfn port) con) let release domid con = - ack (sync (Queueop.release domid) con) + ack (sync (Queueop.release domid) con) let resume domid con = - ack (sync (Queueop.resume domid) con) + ack (sync (Queueop.resume domid) con) let getdomainpath domid con = - sync (Queueop.getdomainpath domid) con + sync (Queueop.getdomainpath domid) con let write tid path value con = - validate_path path; - ack (sync (Queueop.write tid path value) con) + validate_path path; + ack (sync (Queueop.write tid path value) con) let writev tid dir vec con = - List.iter (fun (entry, value) -> - let path = (if dir <> "" then dir ^ "/" ^ entry else entry) in - validate_path path; - write tid path value con) vec + List.iter (fun (entry, value) -> + let path = (if dir <> "" then dir ^ "/" ^ entry else entry) in + validate_path path; + write tid path value con) vec let mkdir tid path con = - validate_path path; - ack (sync (Queueop.mkdir tid path) con) + validate_path path; + ack (sync (Queueop.mkdir tid path) con) let rm tid path con = - validate_path path; - try - ack (sync (Queueop.rm tid path) con) - with - Xb.Noent -> () + validate_path path; + try + ack (sync (Queueop.rm tid path) con) + with + Xb.Noent -> () let setperms tid path perms con = - validate_path path; - ack (sync (Queueop.setperms tid path (string_of_perms perms)) con) + validate_path path; + ack (sync (Queueop.setperms tid path (string_of_perms perms)) con) let setpermsv tid dir vec perms con = - List.iter (fun entry -> - let path = (if dir <> "" then dir ^ "/" ^ entry else entry) in - validate_path path; - setperms tid path perms con) vec + List.iter (fun entry -> + let path = (if dir <> "" then dir ^ "/" ^ entry else entry) in + validate_path path; + setperms tid path perms con) vec diff --git a/tools/ocaml/libs/xs/xst.ml b/tools/ocaml/libs/xs/xst.ml index 16affd2e07..50a980b915 100644 --- a/tools/ocaml/libs/xs/xst.ml +++ b/tools/ocaml/libs/xs/xst.ml @@ -15,47 +15,47 @@ *) type ops = -{ - directory: string -> string list; - read: string -> string; - readv: string -> string list -> string list; - write: string -> string -> unit; - writev: string -> (string * string) list -> unit; - mkdir: string -> unit; - rm: string -> unit; - getperms: string -> Xsraw.perms; - setperms: string -> Xsraw.perms -> unit; - setpermsv: string -> string list -> Xsraw.perms -> unit; -} + { + directory: string -> string list; + read: string -> string; + readv: string -> string list -> string list; + write: string -> string -> unit; + writev: string -> (string * string) list -> unit; + mkdir: string -> unit; + rm: string -> unit; + getperms: string -> Xsraw.perms; + setperms: string -> Xsraw.perms -> unit; + setpermsv: string -> string list -> Xsraw.perms -> unit; + } let get_operations tid xsh = { - directory = (fun path -> Xsraw.directory tid path xsh); - read = (fun path -> Xsraw.read tid path xsh); - readv = (fun dir vec -> Xsraw.readv tid dir vec xsh); - write = (fun path value -> Xsraw.write tid path value xsh); - writev = (fun dir vec -> Xsraw.writev tid dir vec xsh); - mkdir = (fun path -> Xsraw.mkdir tid path xsh); - rm = (fun path -> Xsraw.rm tid path xsh); - getperms = (fun path -> Xsraw.getperms tid path xsh); - setperms = (fun path perms -> Xsraw.setperms tid path perms xsh); - setpermsv = (fun dir vec perms -> Xsraw.setpermsv tid dir vec perms xsh); + directory = (fun path -> Xsraw.directory tid path xsh); + read = (fun path -> Xsraw.read tid path xsh); + readv = (fun dir vec -> Xsraw.readv tid dir vec xsh); + write = (fun path value -> Xsraw.write tid path value xsh); + writev = (fun dir vec -> Xsraw.writev tid dir vec xsh); + mkdir = (fun path -> Xsraw.mkdir tid path xsh); + rm = (fun path -> Xsraw.rm tid path xsh); + getperms = (fun path -> Xsraw.getperms tid path xsh); + setperms = (fun path perms -> Xsraw.setperms tid path perms xsh); + setpermsv = (fun dir vec perms -> Xsraw.setpermsv tid dir vec perms xsh); } let transaction xsh (f: ops -> 'a) : 'a = - let commited = ref false and result = ref None in - while not !commited - do - let tid = Xsraw.transaction_start xsh in - let t = get_operations tid xsh in + let commited = ref false and result = ref None in + while not !commited + do + let tid = Xsraw.transaction_start xsh in + let t = get_operations tid xsh in - begin try - result := Some (f t) - with exn -> - ignore (Xsraw.transaction_end tid false xsh); - raise exn - end; - commited := Xsraw.transaction_end tid true xsh - done; - match !result with - | None -> failwith "internal error in transaction" - | Some result -> result + begin try + result := Some (f t) + with exn -> + ignore (Xsraw.transaction_end tid false xsh); + raise exn + end; + commited := Xsraw.transaction_end tid true xsh + done; + match !result with + | None -> failwith "internal error in transaction" + | Some result -> result diff --git a/tools/ocaml/libs/xs/xst.mli b/tools/ocaml/libs/xs/xst.mli index 5ae560424c..08d737bc36 100644 --- a/tools/ocaml/libs/xs/xst.mli +++ b/tools/ocaml/libs/xs/xst.mli @@ -14,16 +14,16 @@ * GNU Lesser General Public License for more details. *) type ops = { - directory : string -> string list; - read : string -> string; - readv : string -> string list -> string list; - write : string -> string -> unit; - writev : string -> (string * string) list -> unit; - mkdir : string -> unit; - rm : string -> unit; - getperms : string -> Xsraw.perms; - setperms : string -> Xsraw.perms -> unit; - setpermsv : string -> string list -> Xsraw.perms -> unit; + directory : string -> string list; + read : string -> string; + readv : string -> string list -> string list; + write : string -> string -> unit; + writev : string -> (string * string) list -> unit; + mkdir : string -> unit; + rm : string -> unit; + getperms : string -> Xsraw.perms; + setperms : string -> Xsraw.perms -> unit; + setpermsv : string -> string list -> Xsraw.perms -> unit; } val get_operations : int -> Xsraw.con -> ops diff --git a/tools/ocaml/test/dmesg.ml b/tools/ocaml/test/dmesg.ml index c868024c52..f9efe5dc30 100644 --- a/tools/ocaml/test/dmesg.ml +++ b/tools/ocaml/test/dmesg.ml @@ -1,17 +1,17 @@ let _ = - Xenlight.register_exceptions (); - let logger = Xtl.create_stdio_logger ~level:Xentoollog.Debug () in - let ctx = Xenlight.ctx_alloc logger in + Xenlight.register_exceptions (); + let logger = Xtl.create_stdio_logger ~level:Xentoollog.Debug () in + let ctx = Xenlight.ctx_alloc logger in - let open Xenlight.Host in - let reader = xen_console_read_start ctx 0 in - (try - while true do - let line = xen_console_read_line ctx reader in - print_string line - done - with End_of_file -> ()); - let _ = xen_console_read_finish ctx reader in - () + let open Xenlight.Host in + let reader = xen_console_read_start ctx 0 in + (try + while true do + let line = xen_console_read_line ctx reader in + print_string line + done + with End_of_file -> ()); + let _ = xen_console_read_finish ctx reader in + () diff --git a/tools/ocaml/test/list_domains.ml b/tools/ocaml/test/list_domains.ml index c8974957fd..94f1cec050 100644 --- a/tools/ocaml/test/list_domains.ml +++ b/tools/ocaml/test/list_domains.ml @@ -20,7 +20,7 @@ let _ = let domains = Xenlight.Dominfo.list ctx in List.iter (fun d -> print_dominfo d) domains with Xenlight.Error(err, fn) -> begin - printf "Caught Exception: %s: %s\n" (Xenlight.string_of_error err) fn; - end + printf "Caught Exception: %s: %s\n" (Xenlight.string_of_error err) fn; + end diff --git a/tools/ocaml/test/raise_exception.ml b/tools/ocaml/test/raise_exception.ml index 5ef7fc0f13..8c24c3555b 100644 --- a/tools/ocaml/test/raise_exception.ml +++ b/tools/ocaml/test/raise_exception.ml @@ -4,6 +4,6 @@ let _ = try Xenlight.test_raise_exception () with Xenlight.Error(err, fn) -> begin - printf "Caught Exception: %s: %s\n" (Xenlight.string_of_error err) fn; - end + printf "Caught Exception: %s: %s\n" (Xenlight.string_of_error err) fn; + end diff --git a/tools/ocaml/test/xtl.ml b/tools/ocaml/test/xtl.ml index 5f94a76a82..458b11bbaa 100644 --- a/tools/ocaml/test/xtl.ml +++ b/tools/ocaml/test/xtl.ml @@ -2,24 +2,24 @@ open Printf open Xentoollog let stdio_vmessage min_level level errno ctx msg = - let level_str = level_to_string level - and errno_str = match errno with None -> "" | Some s -> sprintf ": errno=%d" s - and ctx_str = match ctx with None -> "" | Some s -> sprintf ": %s" s in - if compare min_level level <= 0 then begin - printf "%s%s%s: %s\n" level_str ctx_str errno_str msg; - flush stdout; - end + let level_str = level_to_string level + and errno_str = match errno with None -> "" | Some s -> sprintf ": errno=%d" s + and ctx_str = match ctx with None -> "" | Some s -> sprintf ": %s" s in + if compare min_level level <= 0 then begin + printf "%s%s%s: %s\n" level_str ctx_str errno_str msg; + flush stdout; + end let stdio_progress _ctx what percent dne total = - let nl = if dne = total then "\n" else "" in - printf "\rProgress %s %d%% (%Ld/%Ld)%s" what percent dne total nl; - flush stdout + let nl = if dne = total then "\n" else "" in + printf "\rProgress %s %d%% (%Ld/%Ld)%s" what percent dne total nl; + flush stdout let create_stdio_logger ?(level=Info) () = - let cbs = { - vmessage = stdio_vmessage level; - progress = stdio_progress; } in - create "Xentoollog.stdio_logger" cbs + let cbs = { + vmessage = stdio_vmessage level; + progress = stdio_progress; } in + create "Xentoollog.stdio_logger" cbs let do_test level = let lgr = create_stdio_logger ~level:level () in diff --git a/tools/ocaml/xenstored/config.ml b/tools/ocaml/xenstored/config.ml index 0ee7bc32ff..95ef745a54 100644 --- a/tools/ocaml/xenstored/config.ml +++ b/tools/ocaml/xenstored/config.ml @@ -15,98 +15,98 @@ *) type ty = - | Set_bool of bool ref - | Set_int of int ref - | Set_string of string ref - | Set_float of float ref - | Unit of (unit -> unit) - | Bool of (bool -> unit) - | Int of (int -> unit) - | String of (string -> unit) - | Float of (float -> unit) + | Set_bool of bool ref + | Set_int of int ref + | Set_string of string ref + | Set_float of float ref + | Unit of (unit -> unit) + | Bool of (bool -> unit) + | Int of (int -> unit) + | String of (string -> unit) + | Float of (float -> unit) exception Error of (string * string) list let trim_start lc s = - let len = String.length s and i = ref 0 in - while !i < len && (List.mem s.[!i] lc) - do - incr i - done; - if !i < len then String.sub s !i (len - !i) else "" + let len = String.length s and i = ref 0 in + while !i < len && (List.mem s.[!i] lc) + do + incr i + done; + if !i < len then String.sub s !i (len - !i) else "" let trim_end lc s = - let i = ref (String.length s - 1) in - while !i > 0 && (List.mem s.[!i] lc) - do - decr i - done; - if !i >= 0 then String.sub s 0 (!i + 1) else "" + let i = ref (String.length s - 1) in + while !i > 0 && (List.mem s.[!i] lc) + do + decr i + done; + if !i >= 0 then String.sub s 0 (!i + 1) else "" let rec split ?limit:(limit=(-1)) c s = - let i = try String.index s c with Not_found -> -1 in - let nlimit = if limit = -1 || limit = 0 then limit else limit - 1 in - if i = -1 || nlimit = 0 then - [ s ] - else - let a = String.sub s 0 i - and b = String.sub s (i + 1) (String.length s - i - 1) in - a :: (split ~limit: nlimit c b) + let i = try String.index s c with Not_found -> -1 in + let nlimit = if limit = -1 || limit = 0 then limit else limit - 1 in + if i = -1 || nlimit = 0 then + [ s ] + else + let a = String.sub s 0 i + and b = String.sub s (i + 1) (String.length s - i - 1) in + a :: (split ~limit: nlimit c b) let parse_line stream = - let lc = [ ' '; '\t' ] in - let trim_spaces s = trim_end lc (trim_start lc s) in - let to_config s = - match split ~limit:2 '=' s with - | k :: v :: [] -> Some (trim_end lc k, trim_start lc v) - | _ -> None in - let rec read_filter_line () = - try - let line = trim_spaces (input_line stream) in - if String.length line > 0 && line.[0] <> '#' then - match to_config line with - | None -> read_filter_line () - | Some x -> x :: read_filter_line () - else - read_filter_line () - with - End_of_file -> [] in - read_filter_line () + let lc = [ ' '; '\t' ] in + let trim_spaces s = trim_end lc (trim_start lc s) in + let to_config s = + match split ~limit:2 '=' s with + | k :: v :: [] -> Some (trim_end lc k, trim_start lc v) + | _ -> None in + let rec read_filter_line () = + try + let line = trim_spaces (input_line stream) in + if String.length line > 0 && line.[0] <> '#' then + match to_config line with + | None -> read_filter_line () + | Some x -> x :: read_filter_line () + else + read_filter_line () + with + End_of_file -> [] in + read_filter_line () let parse filename = - let stream = open_in filename in - let cf = parse_line stream in - close_in stream; - cf + let stream = open_in filename in + let cf = parse_line stream in + close_in stream; + cf let validate cf expected other = - let err = ref [] in - let append x = err := x :: !err in - List.iter (fun (k, v) -> - try - if not (List.mem_assoc k expected) then - other k v - else let ty = List.assoc k expected in - match ty with - | Unit f -> f () - | Bool f -> f (bool_of_string v) - | String f -> f v - | Int f -> f (int_of_string v) - | Float f -> f (float_of_string v) - | Set_bool r -> r := (bool_of_string v) - | Set_string r -> r := v - | Set_int r -> r := int_of_string v - | Set_float r -> r := (float_of_string v) - with - | Not_found -> append (k, "unknown key") - | Failure "int_of_string" -> append (k, "expect int arg") - | Failure "bool_of_string" -> append (k, "expect bool arg") - | Failure "float_of_string" -> append (k, "expect float arg") - | exn -> append (k, Printexc.to_string exn) - ) cf; - if !err != [] then raise (Error !err) + let err = ref [] in + let append x = err := x :: !err in + List.iter (fun (k, v) -> + try + if not (List.mem_assoc k expected) then + other k v + else let ty = List.assoc k expected in + match ty with + | Unit f -> f () + | Bool f -> f (bool_of_string v) + | String f -> f v + | Int f -> f (int_of_string v) + | Float f -> f (float_of_string v) + | Set_bool r -> r := (bool_of_string v) + | Set_string r -> r := v + | Set_int r -> r := int_of_string v + | Set_float r -> r := (float_of_string v) + with + | Not_found -> append (k, "unknown key") + | Failure "int_of_string" -> append (k, "expect int arg") + | Failure "bool_of_string" -> append (k, "expect bool arg") + | Failure "float_of_string" -> append (k, "expect float arg") + | exn -> append (k, Printexc.to_string exn) + ) cf; + if !err != [] then raise (Error !err) (** read a filename, parse and validate, and return the errors if any *) let read filename expected other = - let cf = parse filename in - validate cf expected other + let cf = parse filename in + validate cf expected other diff --git a/tools/ocaml/xenstored/connection.ml b/tools/ocaml/xenstored/connection.ml index 54f7f76516..fcff0f332e 100644 --- a/tools/ocaml/xenstored/connection.ml +++ b/tools/ocaml/xenstored/connection.ml @@ -24,281 +24,281 @@ type 'a bounded_sender = 'a -> unit option (** a bounded sender accepts an ['a] item and returns: None - if there is no room to accept the item Some () - if it has successfully accepted/sent the item - *) +*) module BoundedPipe : sig - type 'a t + type 'a t - (** [create ~capacity ~destination] creates a bounded pipe with a - local buffer holding at most [capacity] items. Once the buffer is - full it will not accept further items. items from the pipe are - flushed into [destination] as long as it accepts items. The - destination could be another pipe. - *) - val create: capacity:int -> destination:'a bounded_sender -> 'a t + (** [create ~capacity ~destination] creates a bounded pipe with a + local buffer holding at most [capacity] items. Once the buffer is + full it will not accept further items. items from the pipe are + flushed into [destination] as long as it accepts items. The + destination could be another pipe. + *) + val create: capacity:int -> destination:'a bounded_sender -> 'a t - (** [is_empty t] returns whether the local buffer of [t] is empty. *) - val is_empty : _ t -> bool + (** [is_empty t] returns whether the local buffer of [t] is empty. *) + val is_empty : _ t -> bool - (** [length t] the number of items in the internal buffer *) - val length: _ t -> int + (** [length t] the number of items in the internal buffer *) + val length: _ t -> int - (** [flush_pipe t] sends as many items from the local buffer as possible, - which could be none. *) - val flush_pipe: _ t -> unit + (** [flush_pipe t] sends as many items from the local buffer as possible, + which could be none. *) + val flush_pipe: _ t -> unit - (** [push t item] tries to [flush_pipe] and then push [item] - into the pipe if its [capacity] allows. - Returns [None] if there is no more room - *) - val push : 'a t -> 'a bounded_sender + (** [push t item] tries to [flush_pipe] and then push [item] + into the pipe if its [capacity] allows. + Returns [None] if there is no more room + *) + val push : 'a t -> 'a bounded_sender end = struct - (* items are enqueued in [q], and then flushed to [connect_to] *) - type 'a t = - { q: 'a Queue.t - ; destination: 'a bounded_sender - ; capacity: int - } + (* items are enqueued in [q], and then flushed to [connect_to] *) + type 'a t = + { q: 'a Queue.t + ; destination: 'a bounded_sender + ; capacity: int + } - let create ~capacity ~destination = - { q = Queue.create (); capacity; destination } + let create ~capacity ~destination = + { q = Queue.create (); capacity; destination } - let rec flush_pipe t = - if not Queue.(is_empty t.q) then - let item = Queue.peek t.q in - match t.destination item with - | None -> () (* no room *) - | Some () -> - (* successfully sent item to next stage *) - let _ = Queue.pop t.q in - (* continue trying to send more items *) - flush_pipe t + let rec flush_pipe t = + if not Queue.(is_empty t.q) then + let item = Queue.peek t.q in + match t.destination item with + | None -> () (* no room *) + | Some () -> + (* successfully sent item to next stage *) + let _ = Queue.pop t.q in + (* continue trying to send more items *) + flush_pipe t - let push t item = - (* first try to flush as many items from this pipe as possible to make room, - it is important to do this first to preserve the order of the items - *) - flush_pipe t; - if Queue.length t.q < t.capacity then begin - (* enqueue, instead of sending directly. - this ensures that [out] sees the items in the same order as we receive them - *) - Queue.push item t.q; - Some (flush_pipe t) - end else None + let push t item = + (* first try to flush as many items from this pipe as possible to make room, + it is important to do this first to preserve the order of the items + *) + flush_pipe t; + if Queue.length t.q < t.capacity then begin + (* enqueue, instead of sending directly. + this ensures that [out] sees the items in the same order as we receive them + *) + Queue.push item t.q; + Some (flush_pipe t) + end else None - let is_empty t = Queue.is_empty t.q - let length t = Queue.length t.q + let is_empty t = Queue.is_empty t.q + let length t = Queue.length t.q end type watch = { - con: t; - token: string; - path: string; - base: string; - is_relative: bool; - pending_watchevents: Xenbus.Xb.Packet.t BoundedPipe.t; + con: t; + token: string; + path: string; + base: string; + is_relative: bool; + pending_watchevents: Xenbus.Xb.Packet.t BoundedPipe.t; } and t = { - xb: Xenbus.Xb.t; - dom: Domain.t option; - transactions: (int, Transaction.t) Hashtbl.t; - mutable next_tid: int; - watches: (string, watch list) Hashtbl.t; - mutable nb_watches: int; - anonid: int; - mutable stat_nb_ops: int; - mutable perm: Perms.Connection.t; - pending_source_watchevents: (watch * Xenbus.Xb.Packet.t) BoundedPipe.t + xb: Xenbus.Xb.t; + dom: Domain.t option; + transactions: (int, Transaction.t) Hashtbl.t; + mutable next_tid: int; + watches: (string, watch list) Hashtbl.t; + mutable nb_watches: int; + anonid: int; + mutable stat_nb_ops: int; + mutable perm: Perms.Connection.t; + pending_source_watchevents: (watch * Xenbus.Xb.Packet.t) BoundedPipe.t } module Watch = struct - module T = struct - type t = watch + module T = struct + type t = watch - let compare w1 w2 = - (* cannot compare watches from different connections *) - assert (w1.con == w2.con); - match String.compare w1.token w2.token with - | 0 -> String.compare w1.path w2.path - | n -> n - end - module Set = Set.Make(T) + let compare w1 w2 = + (* cannot compare watches from different connections *) + assert (w1.con == w2.con); + match String.compare w1.token w2.token with + | 0 -> String.compare w1.path w2.path + | n -> n + end + module Set = Set.Make(T) - let flush_events t = - BoundedPipe.flush_pipe t.pending_watchevents; - not (BoundedPipe.is_empty t.pending_watchevents) + let flush_events t = + BoundedPipe.flush_pipe t.pending_watchevents; + not (BoundedPipe.is_empty t.pending_watchevents) - let pending_watchevents t = - BoundedPipe.length t.pending_watchevents + let pending_watchevents t = + BoundedPipe.length t.pending_watchevents end let source_flush_watchevents t = - BoundedPipe.flush_pipe t.pending_source_watchevents + BoundedPipe.flush_pipe t.pending_source_watchevents let source_pending_watchevents t = - BoundedPipe.length t.pending_source_watchevents + BoundedPipe.length t.pending_source_watchevents let mark_as_bad con = - match con.dom with - |None -> () - | Some domain -> Domain.mark_as_bad domain + match con.dom with + |None -> () + | Some domain -> Domain.mark_as_bad domain let initial_next_tid = 1 let do_reconnect con = - Xenbus.Xb.reconnect con.xb; - (* dom is the same *) - Hashtbl.clear con.transactions; - con.next_tid <- initial_next_tid; - Hashtbl.clear con.watches; - (* anonid is the same *) - con.nb_watches <- 0; - con.stat_nb_ops <- 0; - (* perm is the same *) - () + Xenbus.Xb.reconnect con.xb; + (* dom is the same *) + Hashtbl.clear con.transactions; + con.next_tid <- initial_next_tid; + Hashtbl.clear con.watches; + (* anonid is the same *) + con.nb_watches <- 0; + con.stat_nb_ops <- 0; + (* perm is the same *) + () let get_path con = -Printf.sprintf "/local/domain/%i/" (match con.dom with None -> 0 | Some d -> Domain.get_id d) + Printf.sprintf "/local/domain/%i/" (match con.dom with None -> 0 | Some d -> Domain.get_id d) let watch_create ~con ~path ~token = { - con = con; - token = token; - path = path; - base = get_path con; - is_relative = path.[0] <> '/' && path.[0] <> '@'; - pending_watchevents = BoundedPipe.create ~capacity:!Define.maxwatchevents ~destination:(Xenbus.Xb.queue con.xb) + con = con; + token = token; + path = path; + base = get_path con; + is_relative = path.[0] <> '/' && path.[0] <> '@'; + pending_watchevents = BoundedPipe.create ~capacity:!Define.maxwatchevents ~destination:(Xenbus.Xb.queue con.xb) } let get_con w = w.con let number_of_transactions con = - Hashtbl.length con.transactions + Hashtbl.length con.transactions let get_domain con = con.dom let anon_id_next = ref 1 let get_domstr con = - match con.dom with - | None -> "A" ^ (string_of_int con.anonid) - | Some dom -> "D" ^ (string_of_int (Domain.get_id dom)) + match con.dom with + | None -> "A" ^ (string_of_int con.anonid) + | Some dom -> "D" ^ (string_of_int (Domain.get_id dom)) let make_perm dom = - let domid = - match dom with - | None -> 0 - | Some d -> Domain.get_id d - in - Perms.Connection.create ~perms:[Perms.READ; Perms.WRITE] domid + let domid = + match dom with + | None -> 0 + | Some d -> Domain.get_id d + in + Perms.Connection.create ~perms:[Perms.READ; Perms.WRITE] domid let create xbcon dom = - let destination (watch, pkt) = - BoundedPipe.push watch.pending_watchevents pkt - in - let id = - match dom with - | None -> let old = !anon_id_next in incr anon_id_next; old - | Some _ -> 0 - in - let con = - { - xb = xbcon; - dom = dom; - transactions = Hashtbl.create 5; - next_tid = initial_next_tid; - watches = Hashtbl.create 8; - nb_watches = 0; - anonid = id; - stat_nb_ops = 0; - perm = make_perm dom; + let destination (watch, pkt) = + BoundedPipe.push watch.pending_watchevents pkt + in + let id = + match dom with + | None -> let old = !anon_id_next in incr anon_id_next; old + | Some _ -> 0 + in + let con = + { + xb = xbcon; + dom = dom; + transactions = Hashtbl.create 5; + next_tid = initial_next_tid; + watches = Hashtbl.create 8; + nb_watches = 0; + anonid = id; + stat_nb_ops = 0; + perm = make_perm dom; - (* the actual capacity will be lower, this is used as an overflow - buffer: anything that doesn't fit elsewhere gets put here, only - limited by the amount of watches that you can generate with a - single xenstore command (which is finite, although possibly very - large in theory for Dom0). Once the pipe here has any contents the - domain is blocked from sending more commands until it is empty - again though. - *) - pending_source_watchevents = BoundedPipe.create ~capacity:Sys.max_array_length ~destination - } - in - Logging.new_connection ~tid:Transaction.none ~con:(get_domstr con); - con + (* the actual capacity will be lower, this is used as an overflow + buffer: anything that doesn't fit elsewhere gets put here, only + limited by the amount of watches that you can generate with a + single xenstore command (which is finite, although possibly very + large in theory for Dom0). Once the pipe here has any contents the + domain is blocked from sending more commands until it is empty + again though. + *) + pending_source_watchevents = BoundedPipe.create ~capacity:Sys.max_array_length ~destination + } + in + Logging.new_connection ~tid:Transaction.none ~con:(get_domstr con); + con let get_fd con = Xenbus.Xb.get_fd con.xb let close con = - Logging.end_connection ~tid:Transaction.none ~con:(get_domstr con); - Xenbus.Xb.close con.xb + Logging.end_connection ~tid:Transaction.none ~con:(get_domstr con); + Xenbus.Xb.close con.xb let get_perm con = - con.perm + con.perm let set_target con target_domid = - con.perm <- Perms.Connection.set_target (get_perm con) ~perms:[Perms.READ; Perms.WRITE] target_domid + con.perm <- Perms.Connection.set_target (get_perm con) ~perms:[Perms.READ; Perms.WRITE] target_domid let is_backend_mmap con = Xenbus.Xb.is_mmap con.xb let packet_of con tid rid ty data = - if (String.length data) > xenstore_payload_max && (is_backend_mmap con) then - Xenbus.Xb.Packet.create tid rid Xenbus.Xb.Op.Error "E2BIG\000" - else - Xenbus.Xb.Packet.create tid rid ty data + if (String.length data) > xenstore_payload_max && (is_backend_mmap con) then + Xenbus.Xb.Packet.create tid rid Xenbus.Xb.Op.Error "E2BIG\000" + else + Xenbus.Xb.Packet.create tid rid ty data let send_reply con tid rid ty data = - let result = Xenbus.Xb.queue con.xb (packet_of con tid rid ty data) in - (* should never happen: we only process an input packet when there is room for an output packet *) - (* and the limit for replies is different from the limit for watch events *) - assert (result <> None) + let result = Xenbus.Xb.queue con.xb (packet_of con tid rid ty data) in + (* should never happen: we only process an input packet when there is room for an output packet *) + (* and the limit for replies is different from the limit for watch events *) + assert (result <> None) let send_error con tid rid err = send_reply con tid rid Xenbus.Xb.Op.Error (err ^ "\000") let send_ack con tid rid ty = send_reply con tid rid ty "OK\000" let get_watch_path con path = - if path.[0] = '@' || path.[0] = '/' then - path - else - let rpath = get_path con in - rpath ^ path + if path.[0] = '@' || path.[0] = '/' then + path + else + let rpath = get_path con in + rpath ^ path let get_watches (con: t) path = - if Hashtbl.mem con.watches path - then Hashtbl.find con.watches path - else [] + if Hashtbl.mem con.watches path + then Hashtbl.find con.watches path + else [] let get_children_watches con path = - let path = path ^ "/" in - List.concat (Hashtbl.fold (fun p w l -> - if String.startswith path p then w :: l else l) con.watches []) + let path = path ^ "/" in + List.concat (Hashtbl.fold (fun p w l -> + if String.startswith path p then w :: l else l) con.watches []) let is_dom0 con = - Perms.Connection.is_dom0 (get_perm con) + Perms.Connection.is_dom0 (get_perm con) let add_watch con (path, apath) token = - if !Quota.activate && !Define.maxwatch > 0 && - not (is_dom0 con) && con.nb_watches > !Define.maxwatch then - raise Quota.Limit_reached; - let l = get_watches con apath in - if List.exists (fun w -> w.token = token) l then - raise Define.Already_exist; - let watch = watch_create ~con ~token ~path in - Hashtbl.replace con.watches apath (watch :: l); - con.nb_watches <- con.nb_watches + 1; - watch + if !Quota.activate && !Define.maxwatch > 0 && + not (is_dom0 con) && con.nb_watches > !Define.maxwatch then + raise Quota.Limit_reached; + let l = get_watches con apath in + if List.exists (fun w -> w.token = token) l then + raise Define.Already_exist; + let watch = watch_create ~con ~token ~path in + Hashtbl.replace con.watches apath (watch :: l); + con.nb_watches <- con.nb_watches + 1; + watch let del_watch con path token = - let apath = get_watch_path con path in - let ws = Hashtbl.find con.watches apath in - let w = List.find (fun w -> w.token = token) ws in - let filtered = Utils.list_remove w ws in - if List.length filtered > 0 then - Hashtbl.replace con.watches apath filtered - else - Hashtbl.remove con.watches apath; - con.nb_watches <- con.nb_watches - 1; - apath, w + let apath = get_watch_path con path in + let ws = Hashtbl.find con.watches apath in + let w = List.find (fun w -> w.token = token) ws in + let filtered = Utils.list_remove w ws in + if List.length filtered > 0 then + Hashtbl.replace con.watches apath filtered + else + Hashtbl.remove con.watches apath; + con.nb_watches <- con.nb_watches - 1; + apath, w let del_watches con = Hashtbl.reset con.watches; @@ -308,101 +308,101 @@ let del_transactions con = Hashtbl.reset con.transactions let list_watches con = - let ll = Hashtbl.fold - (fun _ watches acc -> List.map (fun watch -> watch.path, watch.token) watches :: acc) - con.watches [] in - List.concat ll + let ll = Hashtbl.fold + (fun _ watches acc -> List.map (fun watch -> watch.path, watch.token) watches :: acc) + con.watches [] in + List.concat ll let dbg fmt = Logging.debug "connection" fmt let info fmt = Logging.info "connection" fmt let lookup_watch_perm path = function -| None -> [] -| Some root -> - try Store.Path.apply root path @@ fun parent name -> - Store.Node.get_perms parent :: - try [Store.Node.get_perms (Store.Node.find parent name)] - with Not_found -> [] - with Define.Invalid_path | Not_found -> [] + | None -> [] + | Some root -> + try Store.Path.apply root path @@ fun parent name -> + Store.Node.get_perms parent :: + try [Store.Node.get_perms (Store.Node.find parent name)] + with Not_found -> [] + with Define.Invalid_path | Not_found -> [] let lookup_watch_perms oldroot root path = - lookup_watch_perm path oldroot @ lookup_watch_perm path (Some root) + lookup_watch_perm path oldroot @ lookup_watch_perm path (Some root) let fire_single_watch_unchecked source watch = - let data = Utils.join_by_null [watch.path; watch.token; ""] in - let pkt = packet_of watch.con Transaction.none 0 Xenbus.Xb.Op.Watchevent data in + let data = Utils.join_by_null [watch.path; watch.token; ""] in + let pkt = packet_of watch.con Transaction.none 0 Xenbus.Xb.Op.Watchevent data in - match BoundedPipe.push source.pending_source_watchevents (watch, pkt) with - | Some () -> () (* packet queued *) - | None -> - (* a well behaved Dom0 shouldn't be able to trigger this, - if it happens it is likely a Dom0 bug causing runaway memory usage - *) - failwith "watch event overflow, cannot happen" + match BoundedPipe.push source.pending_source_watchevents (watch, pkt) with + | Some () -> () (* packet queued *) + | None -> + (* a well behaved Dom0 shouldn't be able to trigger this, + if it happens it is likely a Dom0 bug causing runaway memory usage + *) + failwith "watch event overflow, cannot happen" let fire_single_watch source (oldroot, root) watch = - let abspath = get_watch_path watch.con watch.path |> Store.Path.of_string in - let perms = lookup_watch_perms oldroot root abspath in - if Perms.can_fire_watch watch.con.perm perms then - fire_single_watch_unchecked source watch - else - let perms = perms |> List.map (Perms.Node.to_string ~sep:" ") |> String.concat ", " in - let con = get_domstr watch.con in - Logging.watch_not_fired ~con perms (Store.Path.to_string abspath) + let abspath = get_watch_path watch.con watch.path |> Store.Path.of_string in + let perms = lookup_watch_perms oldroot root abspath in + if Perms.can_fire_watch watch.con.perm perms then + fire_single_watch_unchecked source watch + else + let perms = perms |> List.map (Perms.Node.to_string ~sep:" ") |> String.concat ", " in + let con = get_domstr watch.con in + Logging.watch_not_fired ~con perms (Store.Path.to_string abspath) let fire_watch source roots watch path = - let new_path = - if watch.is_relative && path.[0] = '/' - then begin - let n = String.length watch.base - and m = String.length path in - String.sub path n (m - n) - end else - path - in - fire_single_watch source roots { watch with path = new_path } + let new_path = + if watch.is_relative && path.[0] = '/' + then begin + let n = String.length watch.base + and m = String.length path in + String.sub path n (m - n) + end else + path + in + fire_single_watch source roots { watch with path = new_path } (* Search for a valid unused transaction id. *) let rec valid_transaction_id con proposed_id = - (* - * Clip proposed_id to the range [1, 0x3ffffffe] - * - * The chosen id must not trucate when written into the uint32_t tx_id - * field, and needs to fit within the positive range of a 31 bit ocaml - * integer to function when compiled as 32bit. - * - * Oxenstored therefore supports only 1 billion open transactions. - *) - let id = if proposed_id <= 0 || proposed_id >= 0x3fffffff then 1 else proposed_id in + (* + * Clip proposed_id to the range [1, 0x3ffffffe] + * + * The chosen id must not trucate when written into the uint32_t tx_id + * field, and needs to fit within the positive range of a 31 bit ocaml + * integer to function when compiled as 32bit. + * + * Oxenstored therefore supports only 1 billion open transactions. + *) + let id = if proposed_id <= 0 || proposed_id >= 0x3fffffff then 1 else proposed_id in - if Hashtbl.mem con.transactions id then ( - (* Outstanding transaction with this id. Try the next. *) - valid_transaction_id con (id + 1) - ) else - id + if Hashtbl.mem con.transactions id then ( + (* Outstanding transaction with this id. Try the next. *) + valid_transaction_id con (id + 1) + ) else + id let start_transaction con store = - if !Define.maxtransaction > 0 && not (is_dom0 con) - && Hashtbl.length con.transactions > !Define.maxtransaction then - raise Quota.Transaction_opened; - let id = valid_transaction_id con con.next_tid in - con.next_tid <- id + 1; - let ntrans = Transaction.make id store in - Hashtbl.add con.transactions id ntrans; - Logging.start_transaction ~tid:id ~con:(get_domstr con); - id + if !Define.maxtransaction > 0 && not (is_dom0 con) + && Hashtbl.length con.transactions > !Define.maxtransaction then + raise Quota.Transaction_opened; + let id = valid_transaction_id con con.next_tid in + con.next_tid <- id + 1; + let ntrans = Transaction.make id store in + Hashtbl.add con.transactions id ntrans; + Logging.start_transaction ~tid:id ~con:(get_domstr con); + id let end_transaction con tid commit = - let trans = Hashtbl.find con.transactions tid in - Hashtbl.remove con.transactions tid; - Logging.end_transaction ~tid ~con:(get_domstr con); - match commit with - | None -> true - | Some transaction_replay_f -> - Transaction.commit ~con:(get_domstr con) trans || transaction_replay_f con trans + let trans = Hashtbl.find con.transactions tid in + Hashtbl.remove con.transactions tid; + Logging.end_transaction ~tid ~con:(get_domstr con); + match commit with + | None -> true + | Some transaction_replay_f -> + Transaction.commit ~con:(get_domstr con) trans || transaction_replay_f con trans let get_transaction con tid = - Hashtbl.find con.transactions tid + Hashtbl.find con.transactions tid let do_input con = Xenbus.Xb.input con.xb let has_partial_input con = Xenbus.Xb.has_partial_input con.xb @@ -434,53 +434,53 @@ let is_bad con = match con.dom with None -> false | Some dom -> Domain.is_bad_do Restrictions below can be relaxed once xenstored learns to dump more of its live state in a safe way *) let has_extra_connection_data con = - let has_in = has_partial_input con in - let has_out = has_output con in - let has_nondefault_perms = make_perm con.dom <> con.perm in - has_in || has_out - (* TODO: what about SIGTERM, should use systemd to store FDS - || has_socket (* dom0 sockets not * dumped yet *) *) - || has_nondefault_perms (* set_target not dumped yet *) + let has_in = has_partial_input con in + let has_out = has_output con in + let has_nondefault_perms = make_perm con.dom <> con.perm in + has_in || has_out + (* TODO: what about SIGTERM, should use systemd to store FDS + || has_socket (* dom0 sockets not * dumped yet *) *) + || has_nondefault_perms (* set_target not dumped yet *) let has_transaction_data con = - let n = number_of_transactions con in - dbg "%s: number of transactions = %d" (get_domstr con) n; - n > 0 + let n = number_of_transactions con in + dbg "%s: number of transactions = %d" (get_domstr con) n; + n > 0 let prevents_live_update con = not (is_bad con) - && (has_extra_connection_data con || has_transaction_data con) + && (has_extra_connection_data con || has_transaction_data con) let has_more_work con = - (has_more_input con && can_input con) || not (has_old_output con) && has_new_output con + (has_more_input con && can_input con) || not (has_old_output con) && has_new_output con let incr_ops con = con.stat_nb_ops <- con.stat_nb_ops + 1 let stats con = - Hashtbl.length con.watches, con.stat_nb_ops + Hashtbl.length con.watches, con.stat_nb_ops let dump con chan = - let id = match con.dom with - | Some dom -> - let domid = Domain.get_id dom in - (* dump domain *) - Domain.dump dom chan; - domid - | None -> - let fd = con |> get_fd |> Utils.FD.to_int in - Printf.fprintf chan "socket,%d\n" fd; - -fd - in - (* dump watches *) - List.iter (fun (path, token) -> - Printf.fprintf chan "watch,%d,%s,%s\n" id (Utils.hexify path) (Utils.hexify token) - ) (list_watches con) + let id = match con.dom with + | Some dom -> + let domid = Domain.get_id dom in + (* dump domain *) + Domain.dump dom chan; + domid + | None -> + let fd = con |> get_fd |> Utils.FD.to_int in + Printf.fprintf chan "socket,%d\n" fd; + -fd + in + (* dump watches *) + List.iter (fun (path, token) -> + Printf.fprintf chan "watch,%d,%s,%s\n" id (Utils.hexify path) (Utils.hexify token) + ) (list_watches con) let debug con = - let domid = get_domstr con in - let watches = List.map (fun (path, token) -> Printf.sprintf "watch %s: %s %s\n" domid path token) (list_watches con) in - String.concat "" watches + let domid = get_domstr con in + let watches = List.map (fun (path, token) -> Printf.sprintf "watch %s: %s %s\n" domid path token) (list_watches con) in + String.concat "" watches let decr_conflict_credit doms con = - match con.dom with - | None -> () (* It's a socket connection. We don't know which domain we're in, so treat it as if it's free to conflict *) - | Some dom -> Domains.decr_conflict_credit doms dom + match con.dom with + | None -> () (* It's a socket connection. We don't know which domain we're in, so treat it as if it's free to conflict *) + | Some dom -> Domains.decr_conflict_credit doms dom diff --git a/tools/ocaml/xenstored/connections.ml b/tools/ocaml/xenstored/connections.ml index 7d68c583b4..682e1b493c 100644 --- a/tools/ocaml/xenstored/connections.ml +++ b/tools/ocaml/xenstored/connections.ml @@ -18,218 +18,218 @@ let debug fmt = Logging.debug "connections" fmt type t = { - anonymous: (Unix.file_descr, Connection.t) Hashtbl.t; - domains: (int, Connection.t) Hashtbl.t; - ports: (Xeneventchn.t, Connection.t) Hashtbl.t; - mutable watches: Connection.watch list Trie.t; - mutable has_pending_watchevents: Connection.Watch.Set.t + anonymous: (Unix.file_descr, Connection.t) Hashtbl.t; + domains: (int, Connection.t) Hashtbl.t; + ports: (Xeneventchn.t, Connection.t) Hashtbl.t; + mutable watches: Connection.watch list Trie.t; + mutable has_pending_watchevents: Connection.Watch.Set.t } let create () = { - anonymous = Hashtbl.create 37; - domains = Hashtbl.create 37; - ports = Hashtbl.create 37; - watches = Trie.create (); - has_pending_watchevents = Connection.Watch.Set.empty; + anonymous = Hashtbl.create 37; + domains = Hashtbl.create 37; + ports = Hashtbl.create 37; + watches = Trie.create (); + has_pending_watchevents = Connection.Watch.Set.empty; } let get_capacity () = - (* not multiplied by maxwatch on purpose: 2nd queue in watch itself! *) - { Xenbus.Xb.maxoutstanding = !Define.maxoutstanding; maxwatchevents = !Define.maxwatchevents } + (* not multiplied by maxwatch on purpose: 2nd queue in watch itself! *) + { Xenbus.Xb.maxoutstanding = !Define.maxoutstanding; maxwatchevents = !Define.maxwatchevents } let add_anonymous cons fd = - let capacity = get_capacity () in - let xbcon = Xenbus.Xb.open_fd fd ~capacity in - let con = Connection.create xbcon None in - Hashtbl.add cons.anonymous (Xenbus.Xb.get_fd xbcon) con + let capacity = get_capacity () in + let xbcon = Xenbus.Xb.open_fd fd ~capacity in + let con = Connection.create xbcon None in + Hashtbl.add cons.anonymous (Xenbus.Xb.get_fd xbcon) con let add_domain cons dom = - let capacity = get_capacity () in - let xbcon = Xenbus.Xb.open_mmap ~capacity (Domain.get_interface dom) (fun () -> Domain.notify dom) in - let con = Connection.create xbcon (Some dom) in - Hashtbl.add cons.domains (Domain.get_id dom) con; - match Domain.get_port dom with - | Some p -> Hashtbl.add cons.ports p con; - | None -> () + let capacity = get_capacity () in + let xbcon = Xenbus.Xb.open_mmap ~capacity (Domain.get_interface dom) (fun () -> Domain.notify dom) in + let con = Connection.create xbcon (Some dom) in + Hashtbl.add cons.domains (Domain.get_id dom) con; + match Domain.get_port dom with + | Some p -> Hashtbl.add cons.ports p con; + | None -> () let select ?(only_if = (fun _ -> true)) cons = - Hashtbl.fold (fun _ con (ins, outs) -> - if (only_if con) then ( - let fd = Connection.get_fd con in - let in_fds = if Connection.can_input con then fd :: ins else ins in - let out_fds = if Connection.has_output con then fd :: outs else outs in - in_fds, out_fds - ) else (ins, outs) - ) - cons.anonymous ([], []) + Hashtbl.fold (fun _ con (ins, outs) -> + if (only_if con) then ( + let fd = Connection.get_fd con in + let in_fds = if Connection.can_input con then fd :: ins else ins in + let out_fds = if Connection.has_output con then fd :: outs else outs in + in_fds, out_fds + ) else (ins, outs) + ) + cons.anonymous ([], []) let find cons = - Hashtbl.find cons.anonymous + Hashtbl.find cons.anonymous let find_domain cons = - Hashtbl.find cons.domains + Hashtbl.find cons.domains let find_domain_by_port cons port = - Hashtbl.find cons.ports port + Hashtbl.find cons.ports port let del_watches_of_con con watches = - match List.filter (fun w -> Connection.get_con w != con) watches with - | [] -> None - | ws -> Some ws + match List.filter (fun w -> Connection.get_con w != con) watches with + | [] -> None + | ws -> Some ws let del_watches cons con = - Connection.del_watches con; - cons.watches <- Trie.map (del_watches_of_con con) cons.watches; - cons.has_pending_watchevents <- - cons.has_pending_watchevents |> Connection.Watch.Set.filter @@ fun w -> - Connection.get_con w != con + Connection.del_watches con; + cons.watches <- Trie.map (del_watches_of_con con) cons.watches; + cons.has_pending_watchevents <- + cons.has_pending_watchevents |> Connection.Watch.Set.filter @@ fun w -> + Connection.get_con w != con let del_anonymous cons con = - try - Hashtbl.remove cons.anonymous (Connection.get_fd con); - del_watches cons con; - Connection.close con - with exn -> - debug "del anonymous %s" (Printexc.to_string exn) + try + Hashtbl.remove cons.anonymous (Connection.get_fd con); + del_watches cons con; + Connection.close con + with exn -> + debug "del anonymous %s" (Printexc.to_string exn) let del_domain cons id = - try - let con = find_domain cons id in - Hashtbl.remove cons.domains id; - (match Connection.get_domain con with - | Some d -> - (match Domain.get_port d with - | Some p -> Hashtbl.remove cons.ports p - | None -> ()) - | None -> ()); - del_watches cons con; - Connection.close con - with exn -> - debug "del domain %u: %s" id (Printexc.to_string exn) + try + let con = find_domain cons id in + Hashtbl.remove cons.domains id; + (match Connection.get_domain con with + | Some d -> + (match Domain.get_port d with + | Some p -> Hashtbl.remove cons.ports p + | None -> ()) + | None -> ()); + del_watches cons con; + Connection.close con + with exn -> + debug "del domain %u: %s" id (Printexc.to_string exn) let iter_domains cons fct = - Hashtbl.iter (fun _ c -> fct c) cons.domains + Hashtbl.iter (fun _ c -> fct c) cons.domains let iter_anonymous cons fct = - Hashtbl.iter (fun _ c -> fct c) cons.anonymous + Hashtbl.iter (fun _ c -> fct c) cons.anonymous let iter cons fct = - iter_domains cons fct; iter_anonymous cons fct + iter_domains cons fct; iter_anonymous cons fct let has_more_work cons = - Hashtbl.fold - (fun _id con acc -> - if Connection.has_more_work con then con :: acc else acc) - cons.domains [] + Hashtbl.fold + (fun _id con acc -> + if Connection.has_more_work con then con :: acc else acc) + cons.domains [] let key_of_str path = - if path.[0] = '@' - then [path] - else "" :: Store.Path.to_string_list (Store.Path.of_string path) + if path.[0] = '@' + then [path] + else "" :: Store.Path.to_string_list (Store.Path.of_string path) let key_of_path path = - "" :: Store.Path.to_string_list path + "" :: Store.Path.to_string_list path let add_watch cons con path token = - let apath = Connection.get_watch_path con path in - (* fail on invalid paths early by calling key_of_str before adding watch *) - let key = key_of_str apath in - let watch = Connection.add_watch con (path, apath) token in - let watches = - if Trie.mem cons.watches key - then Trie.find cons.watches key - else [] - in - cons.watches <- Trie.set cons.watches key (watch :: watches); - watch + let apath = Connection.get_watch_path con path in + (* fail on invalid paths early by calling key_of_str before adding watch *) + let key = key_of_str apath in + let watch = Connection.add_watch con (path, apath) token in + let watches = + if Trie.mem cons.watches key + then Trie.find cons.watches key + else [] + in + cons.watches <- Trie.set cons.watches key (watch :: watches); + watch let del_watch cons con path token = - let apath, watch = Connection.del_watch con path token in - let key = key_of_str apath in - let watches = Utils.list_remove watch (Trie.find cons.watches key) in - if watches = [] then - cons.watches <- Trie.unset cons.watches key - else - cons.watches <- Trie.set cons.watches key watches; - watch + let apath, watch = Connection.del_watch con path token in + let key = key_of_str apath in + let watches = Utils.list_remove watch (Trie.find cons.watches key) in + if watches = [] then + cons.watches <- Trie.unset cons.watches key + else + cons.watches <- Trie.set cons.watches key watches; + watch (* path is absolute *) let fire_watches ?oldroot source root cons path recurse = - let key = key_of_path path in - let path = Store.Path.to_string path in - let roots = oldroot, root in - let fire_watch _ = function - | None -> () - | Some watches -> List.iter (fun w -> Connection.fire_watch source roots w path) watches - in - let fire_rec _x = function - | None -> () - | Some watches -> - List.iter (Connection.fire_single_watch source roots) watches - in - Trie.iter_path fire_watch cons.watches key; - if recurse then - Trie.iter fire_rec (Trie.sub cons.watches key) + let key = key_of_path path in + let path = Store.Path.to_string path in + let roots = oldroot, root in + let fire_watch _ = function + | None -> () + | Some watches -> List.iter (fun w -> Connection.fire_watch source roots w path) watches + in + let fire_rec _x = function + | None -> () + | Some watches -> + List.iter (Connection.fire_single_watch source roots) watches + in + Trie.iter_path fire_watch cons.watches key; + if recurse then + Trie.iter fire_rec (Trie.sub cons.watches key) let send_watchevents cons con = - cons.has_pending_watchevents <- - cons.has_pending_watchevents |> Connection.Watch.Set.filter Connection.Watch.flush_events; - Connection.source_flush_watchevents con + cons.has_pending_watchevents <- + cons.has_pending_watchevents |> Connection.Watch.Set.filter Connection.Watch.flush_events; + Connection.source_flush_watchevents con let fire_spec_watches root cons specpath = - let source = find_domain cons 0 in - iter cons (fun con -> - List.iter (Connection.fire_single_watch source (None, root)) (Connection.get_watches con specpath)) + let source = find_domain cons 0 in + iter cons (fun con -> + List.iter (Connection.fire_single_watch source (None, root)) (Connection.get_watches con specpath)) let set_target cons domain target_domain = - let con = find_domain cons domain in - Connection.set_target con target_domain + let con = find_domain cons domain in + Connection.set_target con target_domain let number_of_transactions cons = - let res = ref 0 in - let aux con = - res := Connection.number_of_transactions con + !res - in - iter cons aux; - !res + let res = ref 0 in + let aux con = + res := Connection.number_of_transactions con + !res + in + iter cons aux; + !res let stats cons = - let nb_ops_anon = ref 0 - and nb_watchs_anon = ref 0 - and nb_ops_dom = ref 0 - and nb_watchs_dom = ref 0 in - iter_anonymous cons (fun con -> - let con_watchs, con_ops = Connection.stats con in - nb_ops_anon := !nb_ops_anon + con_ops; - nb_watchs_anon := !nb_watchs_anon + con_watchs; - ); - iter_domains cons (fun con -> - let con_watchs, con_ops = Connection.stats con in - nb_ops_dom := !nb_ops_dom + con_ops; - nb_watchs_dom := !nb_watchs_dom + con_watchs; - ); - (Hashtbl.length cons.anonymous, !nb_ops_anon, !nb_watchs_anon, - Hashtbl.length cons.domains, !nb_ops_dom, !nb_watchs_dom) + let nb_ops_anon = ref 0 + and nb_watchs_anon = ref 0 + and nb_ops_dom = ref 0 + and nb_watchs_dom = ref 0 in + iter_anonymous cons (fun con -> + let con_watchs, con_ops = Connection.stats con in + nb_ops_anon := !nb_ops_anon + con_ops; + nb_watchs_anon := !nb_watchs_anon + con_watchs; + ); + iter_domains cons (fun con -> + let con_watchs, con_ops = Connection.stats con in + nb_ops_dom := !nb_ops_dom + con_ops; + nb_watchs_dom := !nb_watchs_dom + con_watchs; + ); + (Hashtbl.length cons.anonymous, !nb_ops_anon, !nb_watchs_anon, + Hashtbl.length cons.domains, !nb_ops_dom, !nb_watchs_dom) let debug cons = - let anonymous = Hashtbl.fold (fun _ con accu -> Connection.debug con :: accu) cons.anonymous [] in - let domains = Hashtbl.fold (fun _ con accu -> Connection.debug con :: accu) cons.domains [] in - String.concat "" (domains @ anonymous) + let anonymous = Hashtbl.fold (fun _ con accu -> Connection.debug con :: accu) cons.anonymous [] in + let domains = Hashtbl.fold (fun _ con accu -> Connection.debug con :: accu) cons.domains [] in + String.concat "" (domains @ anonymous) let debug_watchevents cons con = - (* == (physical equality) - has to be used here because w.con.xb.backend might contain a [unit->unit] value causing regular - comparison to fail due to having a 'functional value' which cannot be compared. - *) - let s = cons.has_pending_watchevents |> Connection.Watch.Set.filter (fun w -> w.con == con) in - let pending = s |> Connection.Watch.Set.elements - |> List.map (fun w -> Connection.Watch.pending_watchevents w) |> List.fold_left (+) 0 in - Printf.sprintf "Watches with pending events: %d, pending events total: %d" (Connection.Watch.Set.cardinal s) pending + (* == (physical equality) + has to be used here because w.con.xb.backend might contain a [unit->unit] value causing regular + comparison to fail due to having a 'functional value' which cannot be compared. + *) + let s = cons.has_pending_watchevents |> Connection.Watch.Set.filter (fun w -> w.con == con) in + let pending = s |> Connection.Watch.Set.elements + |> List.map (fun w -> Connection.Watch.pending_watchevents w) |> List.fold_left (+) 0 in + Printf.sprintf "Watches with pending events: %d, pending events total: %d" (Connection.Watch.Set.cardinal s) pending let filter ~f cons = - let fold _ v acc = if f v then v :: acc else acc in - [] - |> Hashtbl.fold fold cons.anonymous - |> Hashtbl.fold fold cons.domains + let fold _ v acc = if f v then v :: acc else acc in + [] + |> Hashtbl.fold fold cons.anonymous + |> Hashtbl.fold fold cons.domains let prevents_quit cons = filter ~f:Connection.prevents_live_update cons diff --git a/tools/ocaml/xenstored/define.ml b/tools/ocaml/xenstored/define.ml index 327b6d795e..f4f5295930 100644 --- a/tools/ocaml/xenstored/define.ml +++ b/tools/ocaml/xenstored/define.ml @@ -27,9 +27,9 @@ let maxrequests = ref (1024) (* maximum requests per transaction *) let maxoutstanding = ref (1024) (* maximum outstanding requests, i.e. in-flight requests / domain *) let maxwatchevents = ref (1024) (* - maximum outstanding watch events per watch, - recommended >= maxoutstanding to avoid blocking backend transactions due to - malicious frontends + maximum outstanding watch events per watch, + recommended >= maxoutstanding to avoid blocking backend transactions due to + malicious frontends *) let gc_max_overhead = ref 120 (* 120% see comment in xenstored.ml *) diff --git a/tools/ocaml/xenstored/disk.ml b/tools/ocaml/xenstored/disk.ml index 4739967b61..91f945f2bd 100644 --- a/tools/ocaml/xenstored/disk.ml +++ b/tools/ocaml/xenstored/disk.ml @@ -25,133 +25,133 @@ exception Bad_escape let is_digit c = match c with '0' .. '9' -> true | _ -> false let undec c = - match c with - | '0' .. '9' -> (Char.code c) - (Char.code '0') - | _ -> raise (Failure "undecify") + match c with + | '0' .. '9' -> (Char.code c) - (Char.code '0') + | _ -> raise (Failure "undecify") let unhex c = - let c = Char.lowercase c in - match c with - | '0' .. '9' -> (Char.code c) - (Char.code '0') - | 'a' .. 'f' -> (Char.code c) - (Char.code 'a') + 10 - | _ -> raise (Failure "unhexify") + let c = Char.lowercase c in + match c with + | '0' .. '9' -> (Char.code c) - (Char.code '0') + | 'a' .. 'f' -> (Char.code c) - (Char.code 'a') + 10 + | _ -> raise (Failure "unhexify") let string_unescaped s = - let len = String.length s - and i = ref 0 in - let d = Buffer.create len in + let len = String.length s + and i = ref 0 in + let d = Buffer.create len in - let read_escape () = - incr i; - match s.[!i] with - | 'n' -> '\n' - | 'r' -> '\r' - | '\\' -> '\\' - | '\'' -> '\'' - | '"' -> '"' - | 't' -> '\t' - | 'b' -> '\b' - | 'x' -> - let v = (unhex s.[!i + 1] * 16) + unhex s.[!i + 2] in - i := !i + 2; - Char.chr v - | c -> - if is_digit c then ( - let v = (undec s.[!i]) * 100 + - (undec s.[!i + 1]) * 10 + - (undec s.[!i + 2]) in - i := !i + 2; - Char.chr v - ) else - raise Bad_escape - in + let read_escape () = + incr i; + match s.[!i] with + | 'n' -> '\n' + | 'r' -> '\r' + | '\\' -> '\\' + | '\'' -> '\'' + | '"' -> '"' + | 't' -> '\t' + | 'b' -> '\b' + | 'x' -> + let v = (unhex s.[!i + 1] * 16) + unhex s.[!i + 2] in + i := !i + 2; + Char.chr v + | c -> + if is_digit c then ( + let v = (undec s.[!i]) * 100 + + (undec s.[!i + 1]) * 10 + + (undec s.[!i + 2]) in + i := !i + 2; + Char.chr v + ) else + raise Bad_escape + in - while !i < len - do - let c = match s.[!i] with - | '\\' -> read_escape () - | c -> c in - Buffer.add_char d c; - incr i - done; - Buffer.contents d + while !i < len + do + let c = match s.[!i] with + | '\\' -> read_escape () + | c -> c in + Buffer.add_char d c; + incr i + done; + Buffer.contents d (* file -> lines_of_file *) let file_readlines file = - let channel = open_in file in - let rec input_line_list channel = - let line = try input_line channel with End_of_file -> "" in - if String.length line > 0 then - line :: input_line_list channel - else ( - close_in channel; - [] - ) in - input_line_list channel + let channel = open_in file in + let rec input_line_list channel = + let line = try input_line channel with End_of_file -> "" in + if String.length line > 0 then + line :: input_line_list channel + else ( + close_in channel; + [] + ) in + input_line_list channel let rec map_string_list_range l s = - match l with - | [] -> [] - | (a,b) :: l -> String.sub s a (b - a) :: map_string_list_range l s + match l with + | [] -> [] + | (a,b) :: l -> String.sub s a (b - a) :: map_string_list_range l s let is_digit c = - try ignore (int_of_char c); true with _ -> false + try ignore (int_of_char c); true with _ -> false let rec parse_perm s = - let len = String.length s in - if len = 0 then - [] - else - let i = ref 1 in - while !i < len && is_digit s.[!i] do incr i done; - let x = String.sub s 0 !i - and lx = String.sub s !i len in - x :: parse_perm lx + let len = String.length s in + if len = 0 then + [] + else + let i = ref 1 in + while !i < len && is_digit s.[!i] do incr i done; + let x = String.sub s 0 !i + and lx = String.sub s !i len in + x :: parse_perm lx let read store = - (* don't let the permission get on our way, full perm ! *) - let v = Store.get_ops store Perms.Connection.full_rights in + (* don't let the permission get on our way, full perm ! *) + let v = Store.get_ops store Perms.Connection.full_rights in - (* a line is : path{perm} or path{perm} = value *) - let parse_line s = - let path, perm, value = - let len = String.length s in - let si = if String.contains s '=' then - String.index s '=' - else - len - 1 in - let pi = String.rindex_from s si '{' in - let epi = String.index_from s pi '}' in + (* a line is : path{perm} or path{perm} = value *) + let parse_line s = + let path, perm, value = + let len = String.length s in + let si = if String.contains s '=' then + String.index s '=' + else + len - 1 in + let pi = String.rindex_from s si '{' in + let epi = String.index_from s pi '}' in - if String.contains s '=' then - let ss = map_string_list_range [ (0, pi); - (pi + 1, epi); - (si + 2, len); ] s in - (List.nth ss 0, List.nth ss 1, List.nth ss 2) - else - let ss = map_string_list_range [ (0, pi); - (pi + 1, epi); - ] s in - (List.nth ss 0, List.nth ss 1, "") - in - let path = Store.Path.of_string path in - v.Store.write path (string_unescaped value); - v.Store.setperms path (Perms.Node.of_strings (parse_perm perm)) in - try - let lines = file_readlines xs_daemon_database in - List.iter (fun s -> parse_line s) lines - with exc -> - error "caught exn %s" (Printexc.to_string exc) + if String.contains s '=' then + let ss = map_string_list_range [ (0, pi); + (pi + 1, epi); + (si + 2, len); ] s in + (List.nth ss 0, List.nth ss 1, List.nth ss 2) + else + let ss = map_string_list_range [ (0, pi); + (pi + 1, epi); + ] s in + (List.nth ss 0, List.nth ss 1, "") + in + let path = Store.Path.of_string path in + v.Store.write path (string_unescaped value); + v.Store.setperms path (Perms.Node.of_strings (parse_perm perm)) in + try + let lines = file_readlines xs_daemon_database in + List.iter (fun s -> parse_line s) lines + with exc -> + error "caught exn %s" (Printexc.to_string exc) let write store = - if !enable then - try - let tfile = Printf.sprintf "%s#" xs_daemon_database in - let channel = open_out_gen [ Open_wronly; Open_creat; Open_trunc; ] - 0o600 tfile in - Store.dump store channel; - flush channel; - close_out channel; - Unix.rename tfile xs_daemon_database - with exc -> - error "caught exn %s" (Printexc.to_string exc) + if !enable then + try + let tfile = Printf.sprintf "%s#" xs_daemon_database in + let channel = open_out_gen [ Open_wronly; Open_creat; Open_trunc; ] + 0o600 tfile in + Store.dump store channel; + flush channel; + close_out channel; + Unix.rename tfile xs_daemon_database + with exc -> + error "caught exn %s" (Printexc.to_string exc) diff --git a/tools/ocaml/xenstored/domain.ml b/tools/ocaml/xenstored/domain.ml index 81cb59b8f1..4e62a48e8e 100644 --- a/tools/ocaml/xenstored/domain.ml +++ b/tools/ocaml/xenstored/domain.ml @@ -20,22 +20,22 @@ let debug fmt = Logging.debug "domain" fmt let warn fmt = Logging.warn "domain" fmt type t = -{ - id: Xenctrl.domid; - mfn: nativeint; - interface: Xenmmap.mmap_interface; - eventchn: Event.t; - mutable remote_port: int; - mutable port: Xeneventchn.t option; - mutable bad_client: bool; - mutable io_credit: int; (* the rounds of ring process left to do, default is 0, - usually set to 1 when there is work detected, could - also set to n to give "lazy" clients extra credit *) - mutable conflict_credit: float; (* Must be positive to perform writes; a commit - that later causes conflict with another - domain's transaction costs credit. *) - mutable caused_conflicts: int64; -} + { + id: Xenctrl.domid; + mfn: nativeint; + interface: Xenmmap.mmap_interface; + eventchn: Event.t; + mutable remote_port: int; + mutable port: Xeneventchn.t option; + mutable bad_client: bool; + mutable io_credit: int; (* the rounds of ring process left to do, default is 0, + usually set to 1 when there is work detected, could + also set to n to give "lazy" clients extra credit *) + mutable conflict_credit: float; (* Must be positive to perform writes; a commit + that later causes conflict with another + domain's transaction costs credit. *) + mutable caused_conflicts: int64; + } let is_dom0 d = d.id = 0 let get_id domain = domain.id @@ -57,51 +57,51 @@ let is_paused_for_conflict dom = dom.conflict_credit <= 0.0 let is_free_to_conflict = is_dom0 let string_of_port = function -| None -> "None" -| Some x -> string_of_int (Xeneventchn.to_int x) + | None -> "None" + | Some x -> string_of_int (Xeneventchn.to_int x) let dump d chan = - fprintf chan "dom,%d,%nd,%d\n" d.id d.mfn d.remote_port + fprintf chan "dom,%d,%nd,%d\n" d.id d.mfn d.remote_port let notify dom = match dom.port with -| None -> - warn "domain %d: attempt to notify on unknown port" dom.id -| Some port -> - Event.notify dom.eventchn port + | None -> + warn "domain %d: attempt to notify on unknown port" dom.id + | Some port -> + Event.notify dom.eventchn port let bind_interdomain dom = - begin match dom.port with - | None -> () - | Some port -> Event.unbind dom.eventchn port - end; - dom.port <- Some (Event.bind_interdomain dom.eventchn dom.id dom.remote_port); - debug "bound domain %d remote port %d to local port %s" dom.id dom.remote_port (string_of_port dom.port) + begin match dom.port with + | None -> () + | Some port -> Event.unbind dom.eventchn port + end; + dom.port <- Some (Event.bind_interdomain dom.eventchn dom.id dom.remote_port); + debug "bound domain %d remote port %d to local port %s" dom.id dom.remote_port (string_of_port dom.port) let close dom = - debug "domain %d unbound port %s" dom.id (string_of_port dom.port); - begin match dom.port with - | None -> () - | Some port -> Event.unbind dom.eventchn port - end; - Xenmmap.unmap dom.interface; - () + debug "domain %d unbound port %s" dom.id (string_of_port dom.port); + begin match dom.port with + | None -> () + | Some port -> Event.unbind dom.eventchn port + end; + Xenmmap.unmap dom.interface; + () let make id mfn remote_port interface eventchn = { - id = id; - mfn = mfn; - remote_port = remote_port; - interface = interface; - eventchn = eventchn; - port = None; - bad_client = false; - io_credit = 0; - conflict_credit = !Define.conflict_burst_limit; - caused_conflicts = 0L; + id = id; + mfn = mfn; + remote_port = remote_port; + interface = interface; + eventchn = eventchn; + port = None; + bad_client = false; + io_credit = 0; + conflict_credit = !Define.conflict_burst_limit; + caused_conflicts = 0L; } let log_and_reset_conflict_stats logfn dom = - if dom.caused_conflicts > 0L then ( - logfn dom.id dom.caused_conflicts; - dom.caused_conflicts <- 0L - ) + if dom.caused_conflicts > 0L then ( + logfn dom.id dom.caused_conflicts; + dom.caused_conflicts <- 0L + ) diff --git a/tools/ocaml/xenstored/domains.ml b/tools/ocaml/xenstored/domains.ml index 17fe2fa257..a36b531663 100644 --- a/tools/ocaml/xenstored/domains.ml +++ b/tools/ocaml/xenstored/domains.ml @@ -21,35 +21,35 @@ let warn fmt = Logging.warn "domains" fmt let xc = Xenctrl.interface_open () type domains = { - eventchn: Event.t; - table: (Xenctrl.domid, Domain.t) Hashtbl.t; + eventchn: Event.t; + table: (Xenctrl.domid, Domain.t) Hashtbl.t; - (* N.B. the Queue module is not thread-safe but oxenstored is single-threaded. *) - (* Domains queue up to regain conflict-credit; we have a queue for - domains that are carrying some penalty and so are below the - maximum credit, and another queue for domains that have run out of - credit and so have had their access paused. *) - doms_conflict_paused: (Domain.t option ref) Queue.t; - doms_with_conflict_penalty: (Domain.t option ref) Queue.t; + (* N.B. the Queue module is not thread-safe but oxenstored is single-threaded. *) + (* Domains queue up to regain conflict-credit; we have a queue for + domains that are carrying some penalty and so are below the + maximum credit, and another queue for domains that have run out of + credit and so have had their access paused. *) + doms_conflict_paused: (Domain.t option ref) Queue.t; + doms_with_conflict_penalty: (Domain.t option ref) Queue.t; - (* A callback function to be called when we go from zero to one paused domain. - This will be to reset the countdown until the next unit of credit is issued. *) - on_first_conflict_pause: unit -> unit; + (* A callback function to be called when we go from zero to one paused domain. + This will be to reset the countdown until the next unit of credit is issued. *) + on_first_conflict_pause: unit -> unit; - (* If config is set to use individual instead of aggregate conflict-rate-limiting, - we use these counts instead of the queues. The second one includes the first. *) - mutable n_paused: int; (* Number of domains with zero or negative credit *) - mutable n_penalised: int; (* Number of domains with less than maximum credit *) + (* If config is set to use individual instead of aggregate conflict-rate-limiting, + we use these counts instead of the queues. The second one includes the first. *) + mutable n_paused: int; (* Number of domains with zero or negative credit *) + mutable n_penalised: int; (* Number of domains with less than maximum credit *) } let init eventchn on_first_conflict_pause = { - eventchn = eventchn; - table = Hashtbl.create 10; - doms_conflict_paused = Queue.create (); - doms_with_conflict_penalty = Queue.create (); - on_first_conflict_pause = on_first_conflict_pause; - n_paused = 0; - n_penalised = 0; + eventchn = eventchn; + table = Hashtbl.create 10; + doms_conflict_paused = Queue.create (); + doms_with_conflict_penalty = Queue.create (); + on_first_conflict_pause = on_first_conflict_pause; + n_paused = 0; + n_penalised = 0; } let del doms id = Hashtbl.remove doms.table id let exist doms id = Hashtbl.mem doms.table id @@ -58,165 +58,165 @@ let number doms = Hashtbl.length doms.table let iter doms fct = Hashtbl.iter (fun _ b -> fct b) doms.table let rec is_empty_queue q = - Queue.is_empty q || - if !(Queue.peek q) = None - then ( - ignore (Queue.pop q); - is_empty_queue q - ) else false + Queue.is_empty q || + if !(Queue.peek q) = None + then ( + ignore (Queue.pop q); + is_empty_queue q + ) else false let all_at_max_credit doms = - if !Define.conflict_rate_limit_is_aggregate - then - (* Check both becuase if burst limit is 1.0 then a domain can go straight - * from max-credit to paused without getting into the penalty queue. *) - is_empty_queue doms.doms_with_conflict_penalty - && is_empty_queue doms.doms_conflict_paused - else doms.n_penalised = 0 + if !Define.conflict_rate_limit_is_aggregate + then + (* Check both becuase if burst limit is 1.0 then a domain can go straight + * from max-credit to paused without getting into the penalty queue. *) + is_empty_queue doms.doms_with_conflict_penalty + && is_empty_queue doms.doms_conflict_paused + else doms.n_penalised = 0 (* Functions to handle queues of domains given that the domain might be deleted while in a queue. *) let push dom queue = - Queue.push (ref (Some dom)) queue + Queue.push (ref (Some dom)) queue let rec pop queue = - match !(Queue.pop queue) with - | None -> pop queue - | Some x -> x + match !(Queue.pop queue) with + | None -> pop queue + | Some x -> x let remove_from_queue dom queue = - Queue.iter (fun d -> match !d with - | None -> () - | Some x -> if x=dom then d := None) queue + Queue.iter (fun d -> match !d with + | None -> () + | Some x -> if x=dom then d := None) queue let cleanup doms = - let notify = ref false in - let dead_dom = ref [] in + let notify = ref false in + let dead_dom = ref [] in - Hashtbl.iter (fun id _ -> if id <> 0 then - try - let info = Xenctrl.domain_getinfo xc id in - if info.Xenctrl.shutdown || info.Xenctrl.dying then ( - debug "Domain %u died (dying=%b, shutdown %b -- code %d)" - id info.Xenctrl.dying info.Xenctrl.shutdown info.Xenctrl.shutdown_code; - if info.Xenctrl.dying then - dead_dom := id :: !dead_dom - else - notify := true; - ) - with Xenctrl.Error _ -> - debug "Domain %u died -- no domain info" id; - dead_dom := id :: !dead_dom; - ) doms.table; - List.iter (fun id -> - let dom = Hashtbl.find doms.table id in - Domain.close dom; - Hashtbl.remove doms.table id; - if dom.Domain.conflict_credit <= !Define.conflict_burst_limit - then ( - remove_from_queue dom doms.doms_with_conflict_penalty; - if (dom.Domain.conflict_credit <= 0.) then remove_from_queue dom doms.doms_conflict_paused - ) - ) !dead_dom; - !notify, !dead_dom + Hashtbl.iter (fun id _ -> if id <> 0 then + try + let info = Xenctrl.domain_getinfo xc id in + if info.Xenctrl.shutdown || info.Xenctrl.dying then ( + debug "Domain %u died (dying=%b, shutdown %b -- code %d)" + id info.Xenctrl.dying info.Xenctrl.shutdown info.Xenctrl.shutdown_code; + if info.Xenctrl.dying then + dead_dom := id :: !dead_dom + else + notify := true; + ) + with Xenctrl.Error _ -> + debug "Domain %u died -- no domain info" id; + dead_dom := id :: !dead_dom; + ) doms.table; + List.iter (fun id -> + let dom = Hashtbl.find doms.table id in + Domain.close dom; + Hashtbl.remove doms.table id; + if dom.Domain.conflict_credit <= !Define.conflict_burst_limit + then ( + remove_from_queue dom doms.doms_with_conflict_penalty; + if (dom.Domain.conflict_credit <= 0.) then remove_from_queue dom doms.doms_conflict_paused + ) + ) !dead_dom; + !notify, !dead_dom let resume _doms _domid = - () + () let create doms domid mfn port = - let interface = Xenctrl.map_foreign_range xc domid (Xenmmap.getpagesize()) mfn in - let dom = Domain.make domid mfn port interface doms.eventchn in - Hashtbl.add doms.table domid dom; - Domain.bind_interdomain dom; - dom + let interface = Xenctrl.map_foreign_range xc domid (Xenmmap.getpagesize()) mfn in + let dom = Domain.make domid mfn port interface doms.eventchn in + Hashtbl.add doms.table domid dom; + Domain.bind_interdomain dom; + dom let xenstored_kva = ref "" let xenstored_port = ref "" let create0 doms = - let port, interface = - ( - let port = Utils.read_file_single_integer !xenstored_port - and fd = Unix.openfile !xenstored_kva - [ Unix.O_RDWR ] 0o600 in - let interface = Xenmmap.mmap fd Xenmmap.RDWR Xenmmap.SHARED - (Xenmmap.getpagesize()) 0 in - Unix.close fd; - port, interface - ) - in - let dom = Domain.make 0 Nativeint.zero port interface doms.eventchn in - Hashtbl.add doms.table 0 dom; - Domain.bind_interdomain dom; - Domain.notify dom; - dom + let port, interface = + ( + let port = Utils.read_file_single_integer !xenstored_port + and fd = Unix.openfile !xenstored_kva + [ Unix.O_RDWR ] 0o600 in + let interface = Xenmmap.mmap fd Xenmmap.RDWR Xenmmap.SHARED + (Xenmmap.getpagesize()) 0 in + Unix.close fd; + port, interface + ) + in + let dom = Domain.make 0 Nativeint.zero port interface doms.eventchn in + Hashtbl.add doms.table 0 dom; + Domain.bind_interdomain dom; + Domain.notify dom; + dom let decr_conflict_credit doms dom = - dom.Domain.caused_conflicts <- Int64.add 1L dom.Domain.caused_conflicts; - let before = dom.Domain.conflict_credit in - let after = max (-1.0) (before -. 1.0) in - debug "decr_conflict_credit dom%d %F -> %F" (Domain.get_id dom) before after; - dom.Domain.conflict_credit <- after; - let newly_penalised = - before >= !Define.conflict_burst_limit - && after < !Define.conflict_burst_limit in - let newly_paused = before > 0.0 && after <= 0.0 in - if !Define.conflict_rate_limit_is_aggregate then ( - if newly_penalised - && after > 0.0 - then ( - push dom doms.doms_with_conflict_penalty - ) else if newly_paused - then ( - let first_pause = Queue.is_empty doms.doms_conflict_paused in - push dom doms.doms_conflict_paused; - if first_pause then doms.on_first_conflict_pause () - ) else ( - (* The queues are correct already: no further action needed. *) - ) - ) else ( - if newly_penalised then doms.n_penalised <- doms.n_penalised + 1; - if newly_paused then ( - doms.n_paused <- doms.n_paused + 1; - if doms.n_paused = 1 then doms.on_first_conflict_pause () - ) - ) + dom.Domain.caused_conflicts <- Int64.add 1L dom.Domain.caused_conflicts; + let before = dom.Domain.conflict_credit in + let after = max (-1.0) (before -. 1.0) in + debug "decr_conflict_credit dom%d %F -> %F" (Domain.get_id dom) before after; + dom.Domain.conflict_credit <- after; + let newly_penalised = + before >= !Define.conflict_burst_limit + && after < !Define.conflict_burst_limit in + let newly_paused = before > 0.0 && after <= 0.0 in + if !Define.conflict_rate_limit_is_aggregate then ( + if newly_penalised + && after > 0.0 + then ( + push dom doms.doms_with_conflict_penalty + ) else if newly_paused + then ( + let first_pause = Queue.is_empty doms.doms_conflict_paused in + push dom doms.doms_conflict_paused; + if first_pause then doms.on_first_conflict_pause () + ) else ( + (* The queues are correct already: no further action needed. *) + ) + ) else ( + if newly_penalised then doms.n_penalised <- doms.n_penalised + 1; + if newly_paused then ( + doms.n_paused <- doms.n_paused + 1; + if doms.n_paused = 1 then doms.on_first_conflict_pause () + ) + ) (* Give one point of credit to one domain, and update the queues appropriately. *) let incr_conflict_credit_from_queue doms = - let process_queue q requeue_test = - let d = pop q in - let before = d.Domain.conflict_credit in (* just for debug-logging *) - d.Domain.conflict_credit <- min (d.Domain.conflict_credit +. 1.0) !Define.conflict_burst_limit; - debug "incr_conflict_credit_from_queue: dom%d: %F -> %F" (Domain.get_id d) before d.Domain.conflict_credit; - if requeue_test d.Domain.conflict_credit then ( - push d q (* Make it queue up again for its next point of credit. *) - ) - in - let paused_queue_test cred = cred <= 0.0 in - let penalty_queue_test cred = cred < !Define.conflict_burst_limit in - try process_queue doms.doms_conflict_paused paused_queue_test - with Queue.Empty -> ( - try process_queue doms.doms_with_conflict_penalty penalty_queue_test - with Queue.Empty -> () (* Both queues are empty: nothing to do here. *) - ) + let process_queue q requeue_test = + let d = pop q in + let before = d.Domain.conflict_credit in (* just for debug-logging *) + d.Domain.conflict_credit <- min (d.Domain.conflict_credit +. 1.0) !Define.conflict_burst_limit; + debug "incr_conflict_credit_from_queue: dom%d: %F -> %F" (Domain.get_id d) before d.Domain.conflict_credit; + if requeue_test d.Domain.conflict_credit then ( + push d q (* Make it queue up again for its next point of credit. *) + ) + in + let paused_queue_test cred = cred <= 0.0 in + let penalty_queue_test cred = cred < !Define.conflict_burst_limit in + try process_queue doms.doms_conflict_paused paused_queue_test + with Queue.Empty -> ( + try process_queue doms.doms_with_conflict_penalty penalty_queue_test + with Queue.Empty -> () (* Both queues are empty: nothing to do here. *) + ) let incr_conflict_credit doms = - if !Define.conflict_rate_limit_is_aggregate - then incr_conflict_credit_from_queue doms - else ( - (* Give a point of credit to every domain, subject only to the cap. *) - let inc dom = - let before = dom.Domain.conflict_credit in - let after = min (before +. 1.0) !Define.conflict_burst_limit in - dom.Domain.conflict_credit <- after; - debug "incr_conflict_credit dom%d: %F -> %F" (Domain.get_id dom) before after; + if !Define.conflict_rate_limit_is_aggregate + then incr_conflict_credit_from_queue doms + else ( + (* Give a point of credit to every domain, subject only to the cap. *) + let inc dom = + let before = dom.Domain.conflict_credit in + let after = min (before +. 1.0) !Define.conflict_burst_limit in + dom.Domain.conflict_credit <- after; + debug "incr_conflict_credit dom%d: %F -> %F" (Domain.get_id dom) before after; - if before <= 0.0 && after > 0.0 - then doms.n_paused <- doms.n_paused - 1; + if before <= 0.0 && after > 0.0 + then doms.n_paused <- doms.n_paused - 1; - if before < !Define.conflict_burst_limit - && after >= !Define.conflict_burst_limit - then doms.n_penalised <- doms.n_penalised - 1 - in - if doms.n_penalised > 0 then iter doms inc - ) + if before < !Define.conflict_burst_limit + && after >= !Define.conflict_burst_limit + then doms.n_penalised <- doms.n_penalised - 1 + in + if doms.n_penalised > 0 then iter doms inc + ) diff --git a/tools/ocaml/xenstored/event.ml b/tools/ocaml/xenstored/event.ml index ccca90b6fc..b10027f004 100644 --- a/tools/ocaml/xenstored/event.ml +++ b/tools/ocaml/xenstored/event.ml @@ -16,8 +16,8 @@ (**************** high level binding ****************) type t = { - handle: Xeneventchn.handle; - mutable virq_port: Xeneventchn.t option; + handle: Xeneventchn.handle; + mutable virq_port: Xeneventchn.t option; } let init () = { handle = Xeneventchn.init (); virq_port = None; } diff --git a/tools/ocaml/xenstored/history.ml b/tools/ocaml/xenstored/history.ml index ba5c9cb571..f03fb18329 100644 --- a/tools/ocaml/xenstored/history.ml +++ b/tools/ocaml/xenstored/history.ml @@ -13,11 +13,11 @@ *) type history_record = { - con: Connection.t; (* connection that made a change *) - tid: int; (* transaction id of the change (may be Transaction.none) *) - before: Store.t; (* the store before the change *) - after: Store.t; (* the store after the change *) - finish_count: int64; (* the commit-count at which the transaction finished *) + con: Connection.t; (* connection that made a change *) + tid: int; (* transaction id of the change (may be Transaction.none) *) + before: Store.t; (* the store before the change *) + after: Store.t; (* the store after the change *) + finish_count: int64; (* the commit-count at which the transaction finished *) } let history : history_record list ref = ref [] @@ -26,38 +26,38 @@ let history : history_record list ref = ref [] (* There is scope for optimisation here, replacing List.filter with something more efficient, * probably on a different list-like structure. *) let trim ?txn () = - Transaction.trim_short_running_transactions txn; - history := match Transaction.oldest_short_running_transaction () with - | None -> [] (* We have no open transaction, so no history is needed *) - | Some (_, txn) -> ( - (* keep records with finish_count recent enough to be relevant *) - List.filter (fun r -> r.finish_count > txn.Transaction.start_count) !history - ) + Transaction.trim_short_running_transactions txn; + history := match Transaction.oldest_short_running_transaction () with + | None -> [] (* We have no open transaction, so no history is needed *) + | Some (_, txn) -> ( + (* keep records with finish_count recent enough to be relevant *) + List.filter (fun r -> r.finish_count > txn.Transaction.start_count) !history + ) let end_transaction txn con tid commit = - let success = Connection.end_transaction con tid commit in - trim ~txn (); - success + let success = Connection.end_transaction con tid commit in + trim ~txn (); + success let reconnect con = - trim (); - Connection.do_reconnect con + trim (); + Connection.do_reconnect con let push (x: history_record) = - let dom = x.con.Connection.dom in - match dom with - | None -> () (* treat socket connections as always free to conflict *) - | Some d -> if not (Domain.is_free_to_conflict d) then history := x :: !history + let dom = x.con.Connection.dom in + match dom with + | None -> () (* treat socket connections as always free to conflict *) + | Some d -> if not (Domain.is_free_to_conflict d) then history := x :: !history (* Find the connections from records since commit-count [since] for which [f record] returns [true] *) let filter_connections ~ignore ~since ~f = - (* The "mem" call is an optimisation, to avoid calling f if we have picked con already. *) - (* Using a hash table rather than a list is to optimise the "mem" call. *) - List.fold_left (fun acc hist_rec -> - if hist_rec.finish_count > since - && not (hist_rec.con == ignore) - && not (Hashtbl.mem acc hist_rec.con) - && f hist_rec - then Hashtbl.replace acc hist_rec.con (); - acc - ) (Hashtbl.create 1023) !history + (* The "mem" call is an optimisation, to avoid calling f if we have picked con already. *) + (* Using a hash table rather than a list is to optimise the "mem" call. *) + List.fold_left (fun acc hist_rec -> + if hist_rec.finish_count > since + && not (hist_rec.con == ignore) + && not (Hashtbl.mem acc hist_rec.con) + && f hist_rec + then Hashtbl.replace acc hist_rec.con (); + acc + ) (Hashtbl.create 1023) !history diff --git a/tools/ocaml/xenstored/logging.ml b/tools/ocaml/xenstored/logging.ml index 39c3036155..021ebc465b 100644 --- a/tools/ocaml/xenstored/logging.ml +++ b/tools/ocaml/xenstored/logging.ml @@ -21,138 +21,138 @@ open Printf (* Logger common *) type log_destination = - | File of string - | Syslog of Syslog.facility + | File of string + | Syslog of Syslog.facility let log_destination_of_string s = - let prefix = "syslog:" in - let len_prefix = String.length prefix in - let len = String.length s in - if String.startswith prefix s - then Syslog(Syslog.facility_of_string (String.sub s len_prefix (len - len_prefix))) - else File s + let prefix = "syslog:" in + let len_prefix = String.length prefix in + let len = String.length s in + if String.startswith prefix s + then Syslog(Syslog.facility_of_string (String.sub s len_prefix (len - len_prefix))) + else File s (* The prefix of a log line depends on the log destination *) let prefix log_destination ?level ?key date = match log_destination with - | File _ -> - let level = match level with - | Some x -> Printf.sprintf "|%5s" x - | None -> "" in - let key = match key with - | Some x -> "|" ^ x - | None -> "" in - Printf.sprintf "[%s%s%s] " date level key - | Syslog _ -> - let key = match key with - | Some x -> "[" ^ x ^ "] " - | None -> "" in - (* Syslog handles the date and level internally *) - key + | File _ -> + let level = match level with + | Some x -> Printf.sprintf "|%5s" x + | None -> "" in + let key = match key with + | Some x -> "|" ^ x + | None -> "" in + Printf.sprintf "[%s%s%s] " date level key + | Syslog _ -> + let key = match key with + | Some x -> "[" ^ x ^ "] " + | None -> "" in + (* Syslog handles the date and level internally *) + key type level = Debug | Info | Warn | Error | Null type logger = - { stop: unit -> unit; - restart: unit -> unit; - rotate: unit -> unit; - write: ?level:level -> string -> unit } + { stop: unit -> unit; + restart: unit -> unit; + rotate: unit -> unit; + write: ?level:level -> string -> unit } let truncate_line nb_chars line = - if String.length line > nb_chars - 1 then - let len = max (nb_chars - 1) 2 in - let dst_line = Bytes.create len in - Bytes.blit_string line 0 dst_line 0 (len - 2); - Bytes.set dst_line (len-2) '.'; - Bytes.set dst_line (len-1) '.'; - Bytes.unsafe_to_string dst_line - else line + if String.length line > nb_chars - 1 then + let len = max (nb_chars - 1) 2 in + let dst_line = Bytes.create len in + Bytes.blit_string line 0 dst_line 0 (len - 2); + Bytes.set dst_line (len-2) '.'; + Bytes.set dst_line (len-1) '.'; + Bytes.unsafe_to_string dst_line + else line let log_rotate ref_ch log_file log_nb_files = - let file n = sprintf "%s.%i" log_file n in - let log_files = - let rec aux accu n = - if n >= log_nb_files then accu - else - if n = 1 && Sys.file_exists log_file - then aux [log_file,1] 2 - else - let file = file (n-1) in - if Sys.file_exists file then - aux ((file, n) :: accu) (n+1) - else accu in - aux [] 1 in - List.iter (fun (f, n) -> Unix.rename f (file n)) log_files; - close_out !ref_ch; - ref_ch := open_out log_file + let file n = sprintf "%s.%i" log_file n in + let log_files = + let rec aux accu n = + if n >= log_nb_files then accu + else + if n = 1 && Sys.file_exists log_file + then aux [log_file,1] 2 + else + let file = file (n-1) in + if Sys.file_exists file then + aux ((file, n) :: accu) (n+1) + else accu in + aux [] 1 in + List.iter (fun (f, n) -> Unix.rename f (file n)) log_files; + close_out !ref_ch; + ref_ch := open_out log_file let make_file_logger log_file log_nb_files log_nb_lines log_nb_chars post_rotate = - let channel = ref (open_out_gen [Open_append; Open_creat] 0o644 log_file) in - let counter = ref 0 in - let stop() = - try flush !channel; close_out !channel - with _ -> () in - let restart() = - stop(); - channel := open_out_gen [Open_append; Open_creat] 0o644 log_file in - let rotate() = - log_rotate channel log_file log_nb_files; - (post_rotate (): unit); - counter := 0 in - let write ?level:_ s = - let s = if log_nb_chars > 0 then truncate_line log_nb_chars s else s in - let s = s ^ "\n" in - output_string !channel s; - flush !channel; - incr counter; - if !counter > log_nb_lines then rotate() in - { stop=stop; restart=restart; rotate=rotate; write=write } + let channel = ref (open_out_gen [Open_append; Open_creat] 0o644 log_file) in + let counter = ref 0 in + let stop() = + try flush !channel; close_out !channel + with _ -> () in + let restart() = + stop(); + channel := open_out_gen [Open_append; Open_creat] 0o644 log_file in + let rotate() = + log_rotate channel log_file log_nb_files; + (post_rotate (): unit); + counter := 0 in + let write ?level:_ s = + let s = if log_nb_chars > 0 then truncate_line log_nb_chars s else s in + let s = s ^ "\n" in + output_string !channel s; + flush !channel; + incr counter; + if !counter > log_nb_lines then rotate() in + { stop=stop; restart=restart; rotate=rotate; write=write } exception Unknown_level of string let int_of_level = function - | Debug -> 0 | Info -> 1 | Warn -> 2 - | Error -> 3 | Null -> max_int + | Debug -> 0 | Info -> 1 | Warn -> 2 + | Error -> 3 | Null -> max_int let string_of_level = function - | Debug -> "debug" | Info -> "info" | Warn -> "warn" - | Error -> "error" | Null -> "null" + | Debug -> "debug" | Info -> "info" | Warn -> "warn" + | Error -> "error" | Null -> "null" let level_of_string = function - | "debug" -> Debug | "info" -> Info | "warn" -> Warn - | "error" -> Error | "null" -> Null | s -> raise (Unknown_level s) + | "debug" -> Debug | "info" -> Info | "warn" -> Warn + | "error" -> Error | "null" -> Null | s -> raise (Unknown_level s) let string_of_date () = - let time = Unix.gettimeofday () in - let tm = Unix.gmtime time in - let msec = time -. (floor time) in - sprintf "%d%.2d%.2dT%.2d:%.2d:%.2d.%.3dZ" - (1900 + tm.Unix.tm_year) (tm.Unix.tm_mon + 1) tm.Unix.tm_mday - tm.Unix.tm_hour tm.Unix.tm_min tm.Unix.tm_sec - (int_of_float (1000.0 *. msec)) + let time = Unix.gettimeofday () in + let tm = Unix.gmtime time in + let msec = time -. (floor time) in + sprintf "%d%.2d%.2dT%.2d:%.2d:%.2d.%.3dZ" + (1900 + tm.Unix.tm_year) (tm.Unix.tm_mon + 1) tm.Unix.tm_mday + tm.Unix.tm_hour tm.Unix.tm_min tm.Unix.tm_sec + (int_of_float (1000.0 *. msec)) (* We can defer to syslog for log management *) let make_syslog_logger facility = - (* When TZ is unset in the environment, each syslog call will stat the - /etc/localtime file at least three times during the process. We'd like to - avoid this cost given that we are not a mobile environment and we log - almost every xenstore entry update/watch. *) - let () = - let tz_is_set = - try String.length (Unix.getenv "TZ") > 0 - with Not_found -> false in - if not tz_is_set then Unix.putenv "TZ" "/etc/localtime" in - let nothing () = () in - let write ?level s = - let level = match level with - | Some Error -> Syslog.Err - | Some Warn -> Syslog.Warning - | Some Info -> Syslog.Info - | Some Debug -> Syslog.Debug - | Some Null -> Syslog.Debug - | None -> Syslog.Debug in - (* Syslog handles the date and level internally *) - Syslog.log facility level s in - { stop = nothing; restart = nothing; rotate = nothing; write=write } + (* When TZ is unset in the environment, each syslog call will stat the + /etc/localtime file at least three times during the process. We'd like to + avoid this cost given that we are not a mobile environment and we log + almost every xenstore entry update/watch. *) + let () = + let tz_is_set = + try String.length (Unix.getenv "TZ") > 0 + with Not_found -> false in + if not tz_is_set then Unix.putenv "TZ" "/etc/localtime" in + let nothing () = () in + let write ?level s = + let level = match level with + | Some Error -> Syslog.Err + | Some Warn -> Syslog.Warning + | Some Info -> Syslog.Info + | Some Debug -> Syslog.Debug + | Some Null -> Syslog.Debug + | None -> Syslog.Debug in + (* Syslog handles the date and level internally *) + Syslog.log facility level s in + { stop = nothing; restart = nothing; rotate = nothing; write=write } let xenstored_log_destination = ref (File (Paths.xen_log_dir ^ "/xenstored.log")) let xenstored_log_level = ref Warn @@ -164,34 +164,34 @@ let xenstored_logger = ref (None: logger option) let debug_enabled () = !xenstored_log_level = Debug let set_xenstored_log_destination s = - xenstored_log_destination := log_destination_of_string s + xenstored_log_destination := log_destination_of_string s let set_xenstored_logger logger = - xenstored_logger := Some logger; - logger.write ~level:Info (Printf.sprintf "Xen Storage Daemon, version %d.%d" - Define.xenstored_major Define.xenstored_minor) + xenstored_logger := Some logger; + logger.write ~level:Info (Printf.sprintf "Xen Storage Daemon, version %d.%d" + Define.xenstored_major Define.xenstored_minor) let init_xenstored_log () = match !xenstored_log_destination with - | File file -> - if !xenstored_log_level <> Null && !xenstored_log_nb_files > 0 then - let logger = - make_file_logger - file !xenstored_log_nb_files !xenstored_log_nb_lines - !xenstored_log_nb_chars ignore in - set_xenstored_logger logger - | Syslog facility -> - set_xenstored_logger (make_syslog_logger facility) + | File file -> + if !xenstored_log_level <> Null && !xenstored_log_nb_files > 0 then + let logger = + make_file_logger + file !xenstored_log_nb_files !xenstored_log_nb_lines + !xenstored_log_nb_chars ignore in + set_xenstored_logger logger + | Syslog facility -> + set_xenstored_logger (make_syslog_logger facility) let xenstored_logging level key (fmt: (_,_,_,_) format4) = - match !xenstored_logger with - | Some logger when int_of_level level >= int_of_level !xenstored_log_level -> - let date = string_of_date() in - let level' = string_of_level level in - let prefix = prefix !xenstored_log_destination ~level:level' ~key date in - Printf.ksprintf (fun s -> logger.write ~level (prefix ^ s)) fmt - | _ -> Printf.ksprintf ignore fmt + match !xenstored_logger with + | Some logger when int_of_level level >= int_of_level !xenstored_log_level -> + let date = string_of_date() in + let level' = string_of_level level in + let prefix = prefix !xenstored_log_destination ~level:level' ~key date in + Printf.ksprintf (fun s -> logger.write ~level (prefix ^ s)) fmt + | _ -> Printf.ksprintf ignore fmt let debug key = xenstored_logging Debug key let info key = xenstored_logging Info key @@ -201,66 +201,66 @@ let error key = xenstored_logging Error key (* Access logger *) type access_type = - | Coalesce - | Conflict - | Commit - | Newconn - | Endconn - | Watch_not_fired - | XbOp of Xenbus.Xb.Op.operation + | Coalesce + | Conflict + | Commit + | Newconn + | Endconn + | Watch_not_fired + | XbOp of Xenbus.Xb.Op.operation let string_of_tid ~con tid = - if tid = 0 - then sprintf "%-12s" con - else sprintf "%-12s" (sprintf "%s.%i" con tid) + if tid = 0 + then sprintf "%-12s" con + else sprintf "%-12s" (sprintf "%s.%i" con tid) let string_of_access_type = function - | Coalesce -> "coalesce " - | Conflict -> "conflict " - | Commit -> "commit " - | Newconn -> "newconn " - | Endconn -> "endconn " - | Watch_not_fired -> "w notfired" + | Coalesce -> "coalesce " + | Conflict -> "conflict " + | Commit -> "commit " + | Newconn -> "newconn " + | Endconn -> "endconn " + | Watch_not_fired -> "w notfired" - | XbOp op -> match op with - | Xenbus.Xb.Op.Debug -> "debug " + | XbOp op -> match op with + | Xenbus.Xb.Op.Debug -> "debug " - | Xenbus.Xb.Op.Directory -> "directory" - | Xenbus.Xb.Op.Read -> "read " - | Xenbus.Xb.Op.Getperms -> "getperms " + | Xenbus.Xb.Op.Directory -> "directory" + | Xenbus.Xb.Op.Read -> "read " + | Xenbus.Xb.Op.Getperms -> "getperms " - | Xenbus.Xb.Op.Watch -> "watch " - | Xenbus.Xb.Op.Unwatch -> "unwatch " + | Xenbus.Xb.Op.Watch -> "watch " + | Xenbus.Xb.Op.Unwatch -> "unwatch " - | Xenbus.Xb.Op.Transaction_start -> "t start " - | Xenbus.Xb.Op.Transaction_end -> "t end " + | Xenbus.Xb.Op.Transaction_start -> "t start " + | Xenbus.Xb.Op.Transaction_end -> "t end " - | Xenbus.Xb.Op.Introduce -> "introduce" - | Xenbus.Xb.Op.Release -> "release " - | Xenbus.Xb.Op.Getdomainpath -> "getdomain" - | Xenbus.Xb.Op.Isintroduced -> "is introduced" - | Xenbus.Xb.Op.Resume -> "resume " + | Xenbus.Xb.Op.Introduce -> "introduce" + | Xenbus.Xb.Op.Release -> "release " + | Xenbus.Xb.Op.Getdomainpath -> "getdomain" + | Xenbus.Xb.Op.Isintroduced -> "is introduced" + | Xenbus.Xb.Op.Resume -> "resume " - | Xenbus.Xb.Op.Write -> "write " - | Xenbus.Xb.Op.Mkdir -> "mkdir " - | Xenbus.Xb.Op.Rm -> "rm " - | Xenbus.Xb.Op.Setperms -> "setperms " - | Xenbus.Xb.Op.Reset_watches -> "reset watches" - | Xenbus.Xb.Op.Set_target -> "settarget" + | Xenbus.Xb.Op.Write -> "write " + | Xenbus.Xb.Op.Mkdir -> "mkdir " + | Xenbus.Xb.Op.Rm -> "rm " + | Xenbus.Xb.Op.Setperms -> "setperms " + | Xenbus.Xb.Op.Reset_watches -> "reset watches" + | Xenbus.Xb.Op.Set_target -> "settarget" - | Xenbus.Xb.Op.Error -> "error " - | Xenbus.Xb.Op.Watchevent -> "w event " - | Xenbus.Xb.Op.Invalid -> "invalid " - (* - | x -> Xenbus.Xb.Op.to_string x - *) + | Xenbus.Xb.Op.Error -> "error " + | Xenbus.Xb.Op.Watchevent -> "w event " + | Xenbus.Xb.Op.Invalid -> "invalid " + (* + | x -> Xenbus.Xb.Op.to_string x + *) let sanitize_data data = - let data = String.init - (String.length data) - (fun i -> let c = data.[i] in if c = '\000' then ' ' else c) - in - String.escaped data + let data = String.init + (String.length data) + (fun i -> let c = data.[i] in if c = '\000' then ' ' else c) + in + String.escaped data let activate_access_log = ref true let access_log_destination = ref (File (Paths.xen_log_dir ^ "/xenstored-access.log")) @@ -273,72 +273,72 @@ let access_log_special_ops = ref false let access_logger = ref None let set_access_log_destination s = - access_log_destination := log_destination_of_string s + access_log_destination := log_destination_of_string s let init_access_log post_rotate = match !access_log_destination with - | File file -> - if !access_log_nb_files > 0 then - let logger = - make_file_logger - file !access_log_nb_files !access_log_nb_lines - !access_log_nb_chars post_rotate in - access_logger := Some logger - | Syslog facility -> - access_logger := Some (make_syslog_logger facility) + | File file -> + if !access_log_nb_files > 0 then + let logger = + make_file_logger + file !access_log_nb_files !access_log_nb_lines + !access_log_nb_chars post_rotate in + access_logger := Some logger + | Syslog facility -> + access_logger := Some (make_syslog_logger facility) let access_logging ~con ~tid ?(data="") ~level access_type = - try - maybe - (fun logger -> - let date = string_of_date() in - let tid = string_of_tid ~con tid in - let access_type = string_of_access_type access_type in - let data = sanitize_data data in - let prefix = prefix !access_log_destination date in - let msg = Printf.sprintf "%s %s %s %s" prefix tid access_type data in - logger.write ~level msg) - !access_logger - with _ -> () + try + maybe + (fun logger -> + let date = string_of_date() in + let tid = string_of_tid ~con tid in + let access_type = string_of_access_type access_type in + let data = sanitize_data data in + let prefix = prefix !access_log_destination date in + let msg = Printf.sprintf "%s %s %s %s" prefix tid access_type data in + logger.write ~level msg) + !access_logger + with _ -> () let new_connection = access_logging ~level:Debug Newconn let end_connection = access_logging ~level:Debug Endconn let read_coalesce ~tid ~con data = - if !access_log_read_ops - then access_logging Coalesce ~tid ~con ~data:("read "^data) ~level:Debug + if !access_log_read_ops + then access_logging Coalesce ~tid ~con ~data:("read "^data) ~level:Debug let write_coalesce data = access_logging Coalesce ~data:("write "^data) ~level:Debug let conflict = access_logging Conflict ~level:Debug let commit = access_logging Commit ~level:Debug let xb_op ~tid ~con ~ty data = - let print = match ty with - | Xenbus.Xb.Op.Read | Xenbus.Xb.Op.Directory | Xenbus.Xb.Op.Getperms -> !access_log_read_ops - | Xenbus.Xb.Op.Transaction_start | Xenbus.Xb.Op.Transaction_end -> - false (* transactions are managed below *) - | Xenbus.Xb.Op.Introduce | Xenbus.Xb.Op.Release | Xenbus.Xb.Op.Getdomainpath | Xenbus.Xb.Op.Isintroduced | Xenbus.Xb.Op.Resume -> - !access_log_special_ops - | _ -> true in - if print then access_logging ~tid ~con ~data (XbOp ty) ~level:Info + let print = match ty with + | Xenbus.Xb.Op.Read | Xenbus.Xb.Op.Directory | Xenbus.Xb.Op.Getperms -> !access_log_read_ops + | Xenbus.Xb.Op.Transaction_start | Xenbus.Xb.Op.Transaction_end -> + false (* transactions are managed below *) + | Xenbus.Xb.Op.Introduce | Xenbus.Xb.Op.Release | Xenbus.Xb.Op.Getdomainpath | Xenbus.Xb.Op.Isintroduced | Xenbus.Xb.Op.Resume -> + !access_log_special_ops + | _ -> true in + if print then access_logging ~tid ~con ~data (XbOp ty) ~level:Info let start_transaction ~tid ~con = - if !access_log_transaction_ops && tid <> 0 - then access_logging ~tid ~con (XbOp Xenbus.Xb.Op.Transaction_start) ~level:Debug + if !access_log_transaction_ops && tid <> 0 + then access_logging ~tid ~con (XbOp Xenbus.Xb.Op.Transaction_start) ~level:Debug let end_transaction ~tid ~con = - if !access_log_transaction_ops && tid <> 0 - then access_logging ~tid ~con (XbOp Xenbus.Xb.Op.Transaction_end) ~level:Debug + if !access_log_transaction_ops && tid <> 0 + then access_logging ~tid ~con (XbOp Xenbus.Xb.Op.Transaction_end) ~level:Debug let live_update () = - xb_op ~tid:0 ~con:"" ~ty:Xenbus.Xb.Op.Debug "Live update begin" + xb_op ~tid:0 ~con:"" ~ty:Xenbus.Xb.Op.Debug "Live update begin" let xb_answer ~tid ~con ~ty data = - let print, level = match ty with - | Xenbus.Xb.Op.Error when String.startswith "ENOENT" data -> !access_log_read_ops , Warn - | Xenbus.Xb.Op.Error -> true , Warn - | Xenbus.Xb.Op.Watchevent -> true , Info - | _ -> false, Debug - in - if print then access_logging ~tid ~con ~data (XbOp ty) ~level + let print, level = match ty with + | Xenbus.Xb.Op.Error when String.startswith "ENOENT" data -> !access_log_read_ops , Warn + | Xenbus.Xb.Op.Error -> true , Warn + | Xenbus.Xb.Op.Watchevent -> true , Info + | _ -> false, Debug + in + if print then access_logging ~tid ~con ~data (XbOp ty) ~level let watch_not_fired ~con perms path = - let data = Printf.sprintf "EPERM perms=[%s] path=%s" perms path in - access_logging ~tid:0 ~con ~data Watch_not_fired ~level:Info + let data = Printf.sprintf "EPERM perms=[%s] path=%s" perms path in + access_logging ~tid:0 ~con ~data Watch_not_fired ~level:Info diff --git a/tools/ocaml/xenstored/packet.ml b/tools/ocaml/xenstored/packet.ml index aeae0a4f57..7c25117937 100644 --- a/tools/ocaml/xenstored/packet.ml +++ b/tools/ocaml/xenstored/packet.ml @@ -1,16 +1,16 @@ type request = { - tid: int; - rid: int; - ty: Xenbus.Xb.Op.operation; - data: string; + tid: int; + rid: int; + ty: Xenbus.Xb.Op.operation; + data: string; } type response = - | Ack of (unit -> unit) (* function is the action to execute after sending the ack *) - | Reply of string - | Error of string + | Ack of (unit -> unit) (* function is the action to execute after sending the ack *) + | Reply of string + | Error of string let response_equal a b = - match (a, b) with - | (Ack _, Ack _) -> true (* just consider the response, not the post-response action *) - | (x, y) -> x = y + match (a, b) with + | (Ack _, Ack _) -> true (* just consider the response, not the post-response action *) + | (x, y) -> x = y diff --git a/tools/ocaml/xenstored/parse_arg.ml b/tools/ocaml/xenstored/parse_arg.ml index 7c0478e76a..1a85b14ef5 100644 --- a/tools/ocaml/xenstored/parse_arg.ml +++ b/tools/ocaml/xenstored/parse_arg.ml @@ -15,59 +15,59 @@ *) type config = -{ - domain_init: bool; - activate_access_log: bool; - daemonize: bool; - reraise_top_level: bool; - config_file: string option; - pidfile: string option; (* old xenstored compatibility *) - tracefile: string option; (* old xenstored compatibility *) - restart: bool; - live_reload: bool; - disable_socket: bool; -} + { + domain_init: bool; + activate_access_log: bool; + daemonize: bool; + reraise_top_level: bool; + config_file: string option; + pidfile: string option; (* old xenstored compatibility *) + tracefile: string option; (* old xenstored compatibility *) + restart: bool; + live_reload: bool; + disable_socket: bool; + } let do_argv = - let pidfile = ref "" and tracefile = ref "" (* old xenstored compatibility *) - and domain_init = ref true - and activate_access_log = ref true - and daemonize = ref true - and reraise_top_level = ref false - and config_file = ref "" - and restart = ref false - and live_reload = ref false - and disable_socket = ref false - in + let pidfile = ref "" and tracefile = ref "" (* old xenstored compatibility *) + and domain_init = ref true + and activate_access_log = ref true + and daemonize = ref true + and reraise_top_level = ref false + and config_file = ref "" + and restart = ref false + and live_reload = ref false + and disable_socket = ref false + in - let speclist = - [ ("--no-domain-init", Arg.Unit (fun () -> domain_init := false), - "to state that xenstored should not initialise dom0"); - ("--config-file", Arg.Set_string config_file, - "set an alternative location for the configuration file"); - ("--no-fork", Arg.Unit (fun () -> daemonize := false), - "to request that the daemon does not fork"); - ("--reraise-top-level", Arg.Unit (fun () -> reraise_top_level := true), - "reraise exceptions caught at the top level"); - ("--no-access-log", Arg.Unit (fun () -> activate_access_log := false), - "do not create a xenstore-access.log file"); - ("--pid-file", Arg.Set_string pidfile, ""); (* for compatibility *) - ("-T", Arg.Set_string tracefile, ""); (* for compatibility *) - ("--restart", Arg.Set restart, "Read database on starting"); - ("--live", Arg.Set live_reload, "Read live dump on startup"); - ("--disable-socket", Arg.Unit (fun () -> disable_socket := true), "Disable socket"); - ] in - let usage_msg = "usage : xenstored [--config-file ] [--no-domain-init] [--help] [--no-fork] [--reraise-top-level] [--restart] [--disable-socket]" in - Arg.parse speclist (fun _ -> ()) usage_msg; - { - domain_init = !domain_init; - activate_access_log = !activate_access_log; - daemonize = !daemonize; - reraise_top_level = !reraise_top_level; - config_file = if !config_file <> "" then Some !config_file else None; - pidfile = if !pidfile <> "" then Some !pidfile else None; - tracefile = if !tracefile <> "" then Some !tracefile else None; - restart = !restart; - live_reload = !live_reload; - disable_socket = !disable_socket; - } + let speclist = + [ ("--no-domain-init", Arg.Unit (fun () -> domain_init := false), + "to state that xenstored should not initialise dom0"); + ("--config-file", Arg.Set_string config_file, + "set an alternative location for the configuration file"); + ("--no-fork", Arg.Unit (fun () -> daemonize := false), + "to request that the daemon does not fork"); + ("--reraise-top-level", Arg.Unit (fun () -> reraise_top_level := true), + "reraise exceptions caught at the top level"); + ("--no-access-log", Arg.Unit (fun () -> activate_access_log := false), + "do not create a xenstore-access.log file"); + ("--pid-file", Arg.Set_string pidfile, ""); (* for compatibility *) + ("-T", Arg.Set_string tracefile, ""); (* for compatibility *) + ("--restart", Arg.Set restart, "Read database on starting"); + ("--live", Arg.Set live_reload, "Read live dump on startup"); + ("--disable-socket", Arg.Unit (fun () -> disable_socket := true), "Disable socket"); + ] in + let usage_msg = "usage : xenstored [--config-file ] [--no-domain-init] [--help] [--no-fork] [--reraise-top-level] [--restart] [--disable-socket]" in + Arg.parse speclist (fun _ -> ()) usage_msg; + { + domain_init = !domain_init; + activate_access_log = !activate_access_log; + daemonize = !daemonize; + reraise_top_level = !reraise_top_level; + config_file = if !config_file <> "" then Some !config_file else None; + pidfile = if !pidfile <> "" then Some !pidfile else None; + tracefile = if !tracefile <> "" then Some !tracefile else None; + restart = !restart; + live_reload = !live_reload; + disable_socket = !disable_socket; + } diff --git a/tools/ocaml/xenstored/perms.ml b/tools/ocaml/xenstored/perms.ml index 84f2503e8e..14f8e334fe 100644 --- a/tools/ocaml/xenstored/perms.ml +++ b/tools/ocaml/xenstored/perms.ml @@ -25,72 +25,72 @@ let watch_activate = ref true type permty = READ | WRITE | RDWR | NONE let char_of_permty perm = - match perm with - | READ -> 'r' - | WRITE -> 'w' - | RDWR -> 'b' - | NONE -> 'n' + match perm with + | READ -> 'r' + | WRITE -> 'w' + | RDWR -> 'b' + | NONE -> 'n' let permty_of_char c = - match c with - | 'r' -> READ - | 'w' -> WRITE - | 'b' -> RDWR - | 'n' -> NONE - | _ -> invalid_arg "unknown permission type" + match c with + | 'r' -> READ + | 'w' -> WRITE + | 'b' -> RDWR + | 'n' -> NONE + | _ -> invalid_arg "unknown permission type" (* node permissions *) module Node = struct -type t = -{ - owner: Xenctrl.domid; - other: permty; - acl: (Xenctrl.domid * permty) list; -} + type t = + { + owner: Xenctrl.domid; + other: permty; + acl: (Xenctrl.domid * permty) list; + } -let create owner other acl = - { owner = owner; other = other; acl = acl } + let create owner other acl = + { owner = owner; other = other; acl = acl } -let get_other perms = perms.other -let get_acl perms = perms.acl -let get_owner perm = perm.owner + let get_other perms = perms.other + let get_acl perms = perms.acl + let get_owner perm = perm.owner -(** [remote_domid ~domid perm] removes all ACLs for [domid] from perm. -* If [domid] was the owner then it is changed to Dom0. -* This is used for cleaning up after dead domains. -* *) -let remove_domid ~domid perm = - let acl = List.filter (fun (acl_domid, _) -> acl_domid <> domid) perm.acl in - if perm.owner = domid then None else Some { perm with acl; owner = perm.owner } + (** [remote_domid ~domid perm] removes all ACLs for [domid] from perm. + * If [domid] was the owner then it is changed to Dom0. + * This is used for cleaning up after dead domains. + * *) + let remove_domid ~domid perm = + let acl = List.filter (fun (acl_domid, _) -> acl_domid <> domid) perm.acl in + if perm.owner = domid then None else Some { perm with acl; owner = perm.owner } -let default0 = create 0 NONE [] + let default0 = create 0 NONE [] -let perm_of_string s = - let ty = permty_of_char s.[0] - and id = int_of_string (String.sub s 1 (String.length s - 1)) in - (id, ty) + let perm_of_string s = + let ty = permty_of_char s.[0] + and id = int_of_string (String.sub s 1 (String.length s - 1)) in + (id, ty) -let of_strings ls = - let vect = List.map (perm_of_string) ls in - match vect with - | [] -> invalid_arg "permvec empty" - | h :: l -> create (fst h) (snd h) l + let of_strings ls = + let vect = List.map (perm_of_string) ls in + match vect with + | [] -> invalid_arg "permvec empty" + | h :: l -> create (fst h) (snd h) l -(* [s] must end with '\000' *) -let of_string s = - let ls = String.split '\000' s in - let ls = if ls = [] then ls else List.rev (List.tl (List.rev ls)) in - of_strings ls + (* [s] must end with '\000' *) + let of_string s = + let ls = String.split '\000' s in + let ls = if ls = [] then ls else List.rev (List.tl (List.rev ls)) in + of_strings ls -let string_of_perm perm = - Printf.sprintf "%c%u" (char_of_permty (snd perm)) (fst perm) + let string_of_perm perm = + Printf.sprintf "%c%u" (char_of_permty (snd perm)) (fst perm) -let to_string ?(sep="\000") permvec = - let l = ((permvec.owner, permvec.other) :: permvec.acl) in - String.concat sep (List.map string_of_perm l) + let to_string ?(sep="\000") permvec = + let l = ((permvec.owner, permvec.other) :: permvec.acl) in + String.concat sep (List.map string_of_perm l) end @@ -99,87 +99,87 @@ end module Connection = struct -type elt = Xenctrl.domid * (permty list) -type t = - { main: elt; - target: elt option; } + type elt = Xenctrl.domid * (permty list) + type t = + { main: elt; + target: elt option; } -let full_rights : t = - { main = 0, [READ; WRITE]; - target = None } + let full_rights : t = + { main = 0, [READ; WRITE]; + target = None } -let create ?(perms=[NONE]) domid : t = - { main = (domid, perms); - target = None } + let create ?(perms=[NONE]) domid : t = + { main = (domid, perms); + target = None } -let set_target (connection:t) ?(perms=[NONE]) domid = - { connection with target = Some (domid, perms) } + let set_target (connection:t) ?(perms=[NONE]) domid = + { connection with target = Some (domid, perms) } -let get_owners (connection:t) = - match connection.main, connection.target with - | c1, Some c2 -> [ fst c1; fst c2 ] - | c1, None -> [ fst c1 ] + let get_owners (connection:t) = + match connection.main, connection.target with + | c1, Some c2 -> [ fst c1; fst c2 ] + | c1, None -> [ fst c1 ] -let is_owner (connection:t) id = - match connection.target with - | Some target -> fst connection.main = id || fst target = id - | None -> fst connection.main = id + let is_owner (connection:t) id = + match connection.target with + | Some target -> fst connection.main = id || fst target = id + | None -> fst connection.main = id -let is_dom0 (connection:t) = - is_owner connection 0 + let is_dom0 (connection:t) = + is_owner connection 0 -let elt_to_string (i,p) = - Printf.sprintf "%i%S" i (String.concat "" (List.map String.of_char (List.map char_of_permty p))) + let elt_to_string (i,p) = + Printf.sprintf "%i%S" i (String.concat "" (List.map String.of_char (List.map char_of_permty p))) -let to_string connection = - Printf.sprintf "%s%s" (elt_to_string connection.main) (default "" (may elt_to_string connection.target)) + let to_string connection = + Printf.sprintf "%s%s" (elt_to_string connection.main) (default "" (may elt_to_string connection.target)) end (* check if owner of the current connection and of the current node are the same *) let check_owner (connection:Connection.t) (node:Node.t) = - if !activate && not (Connection.is_dom0 connection) - then Connection.is_owner connection (Node.get_owner node) - else true + if !activate && not (Connection.is_dom0 connection) + then Connection.is_owner connection (Node.get_owner node) + else true (* check if the current connection lacks the requested perm on the current node *) let lacks (connection:Connection.t) request (node:Node.t) = - let check_acl domainid = - let perm = - if List.mem_assoc domainid (Node.get_acl node) - then List.assoc domainid (Node.get_acl node) - else Node.get_other node - in - match perm, request with - | NONE, _ -> - info "Permission denied: Domain %d has no permission" domainid; - false - | RDWR, _ -> true - | READ, READ -> true - | WRITE, WRITE -> true - | READ, _ -> - info "Permission denied: Domain %d has read only access" domainid; - false - | WRITE, _ -> - info "Permission denied: Domain %d has write only access" domainid; - false - in - !activate - && not (Connection.is_dom0 connection) - && not (check_owner connection node) - && not (List.exists check_acl (Connection.get_owners connection)) + let check_acl domainid = + let perm = + if List.mem_assoc domainid (Node.get_acl node) + then List.assoc domainid (Node.get_acl node) + else Node.get_other node + in + match perm, request with + | NONE, _ -> + info "Permission denied: Domain %d has no permission" domainid; + false + | RDWR, _ -> true + | READ, READ -> true + | WRITE, WRITE -> true + | READ, _ -> + info "Permission denied: Domain %d has read only access" domainid; + false + | WRITE, _ -> + info "Permission denied: Domain %d has write only access" domainid; + false + in + !activate + && not (Connection.is_dom0 connection) + && not (check_owner connection node) + && not (List.exists check_acl (Connection.get_owners connection)) (* check if the current connection has the requested perm on the current node. -* Raises an exception if it doesn't. *) + * Raises an exception if it doesn't. *) let check connection request node = - if lacks connection request node - then raise Define.Permission_denied + if lacks connection request node + then raise Define.Permission_denied (* check if the current connection has the requested perm on the current node *) let has connection request node = not (lacks connection request node) let can_fire_watch connection perms = - not !watch_activate - || List.exists (has connection READ) perms + not !watch_activate + || List.exists (has connection READ) perms let equiv perm1 perm2 = - (Node.to_string perm1) = (Node.to_string perm2) + (Node.to_string perm1) = (Node.to_string perm2) diff --git a/tools/ocaml/xenstored/poll.ml b/tools/ocaml/xenstored/poll.ml index 26f8620dfc..80951c7d36 100644 --- a/tools/ocaml/xenstored/poll.ml +++ b/tools/ocaml/xenstored/poll.ml @@ -17,9 +17,9 @@ subscription flags used by poll, which have a correspondence to the readfds, writefds, exceptfds concept as in select. *) type event = { - mutable read: bool; - mutable write: bool; - mutable except: bool; + mutable read: bool; + mutable write: bool; + mutable except: bool; } external select_on_poll: (Unix.file_descr * event) array -> int -> int = "stub_select_on_poll" @@ -28,40 +28,40 @@ external set_fd_limit: int -> unit = "stub_set_fd_limit" (* The rlim_max given to setrlimit must not go above the system level nr_open, which we can read from /proc/sys. *) let get_sys_fs_nr_open () = - try - let ch = open_in "/proc/sys/fs/nr_open" in - let v = int_of_string (input_line ch) in - close_in_noerr ch; v - with _ -> 1024 * 1024 + try + let ch = open_in "/proc/sys/fs/nr_open" in + let v = int_of_string (input_line ch) in + close_in_noerr ch; v + with _ -> 1024 * 1024 let init_event () = {read = false; write = false; except = false} let poll_select in_fds out_fds exc_fds timeout = - let h = Hashtbl.create 57 in - let add_event event_set fd = - let e = - try Hashtbl.find h fd - with Not_found -> - let e = init_event () in - Hashtbl.add h fd e; e in - event_set e in - List.iter (add_event (fun x -> x.read <- true)) in_fds; - List.iter (add_event (fun x -> x.write <- true)) out_fds; - List.iter (add_event (fun x -> x.except <- true)) exc_fds; - (* Unix.stdin and init_event are dummy input as stubs, which will - always be overwritten later on. *) - let a = Array.make (Hashtbl.length h) (Unix.stdin, init_event ()) in - let i = ref (-1) in - Hashtbl.iter (fun fd event -> incr i; Array.set a !i (fd, event)) h; - let n = select_on_poll a (int_of_float (timeout *. 1000.)) in - let r = [], [], [] in - if n = 0 then r else - Array.fold_right - (fun (fd, event) (r, w, x) -> - (if event.read then fd :: r else r), - (if event.write then fd :: w else w), - (if event.except then fd :: x else x)) - a r + let h = Hashtbl.create 57 in + let add_event event_set fd = + let e = + try Hashtbl.find h fd + with Not_found -> + let e = init_event () in + Hashtbl.add h fd e; e in + event_set e in + List.iter (add_event (fun x -> x.read <- true)) in_fds; + List.iter (add_event (fun x -> x.write <- true)) out_fds; + List.iter (add_event (fun x -> x.except <- true)) exc_fds; + (* Unix.stdin and init_event are dummy input as stubs, which will + always be overwritten later on. *) + let a = Array.make (Hashtbl.length h) (Unix.stdin, init_event ()) in + let i = ref (-1) in + Hashtbl.iter (fun fd event -> incr i; Array.set a !i (fd, event)) h; + let n = select_on_poll a (int_of_float (timeout *. 1000.)) in + let r = [], [], [] in + if n = 0 then r else + Array.fold_right + (fun (fd, event) (r, w, x) -> + (if event.read then fd :: r else r), + (if event.write then fd :: w else w), + (if event.except then fd :: x else x)) + a r let () = - set_fd_limit (get_sys_fs_nr_open ()) + set_fd_limit (get_sys_fs_nr_open ()) diff --git a/tools/ocaml/xenstored/poll.mli b/tools/ocaml/xenstored/poll.mli index f73465b99f..e759608b1a 100644 --- a/tools/ocaml/xenstored/poll.mli +++ b/tools/ocaml/xenstored/poll.mli @@ -15,5 +15,5 @@ (** Same interface and semantics as [Unix.select], implemented using poll(3). *) val poll_select: - Unix.file_descr list -> Unix.file_descr list -> Unix.file_descr list -> float - -> Unix.file_descr list * Unix.file_descr list * Unix.file_descr list + Unix.file_descr list -> Unix.file_descr list -> Unix.file_descr list -> float + -> Unix.file_descr list * Unix.file_descr list * Unix.file_descr list diff --git a/tools/ocaml/xenstored/process.ml b/tools/ocaml/xenstored/process.ml index 72a79e9328..30e62377ce 100644 --- a/tools/ocaml/xenstored/process.ml +++ b/tools/ocaml/xenstored/process.ml @@ -31,302 +31,302 @@ exception Invalid_Cmd_Args let allow_debug = ref false let c_int_of_string s = - let v = ref 0 in - let is_digit c = c >= '0' && c <= '9' in - let len = String.length s in - let i = ref 0 in - while !i < len && not (is_digit s.[!i]) do incr i done; - while !i < len && is_digit s.[!i] - do - let x = (Char.code s.[!i]) - (Char.code '0') in - v := !v * 10 + x; - incr i - done; - !v + let v = ref 0 in + let is_digit c = c >= '0' && c <= '9' in + let len = String.length s in + let i = ref 0 in + while !i < len && not (is_digit s.[!i]) do incr i done; + while !i < len && is_digit s.[!i] + do + let x = (Char.code s.[!i]) - (Char.code '0') in + v := !v * 10 + x; + incr i + done; + !v (* when we don't want a limit, apply a max limit of 8 arguments. no arguments take more than 3 currently, which is pointless to split more than needed. *) let split limit c s = - let limit = match limit with None -> 8 | Some x -> x in - String.split ~limit c s + let limit = match limit with None -> 8 | Some x -> x in + String.split ~limit c s let split_one_path data con = - let args = split (Some 2) '\000' data in - match args with - | path :: "" :: [] -> Store.Path.create path (Connection.get_path con) - | _ -> raise Invalid_Cmd_Args + let args = split (Some 2) '\000' data in + match args with + | path :: "" :: [] -> Store.Path.create path (Connection.get_path con) + | _ -> raise Invalid_Cmd_Args let process_watch source t cons = - let oldroot = t.Transaction.oldroot in - let newroot = Store.get_root t.Transaction.store in - let ops = Transaction.get_paths t |> List.rev in - let do_op_watch op cons = - let recurse, oldroot, root = match (fst op) with - | Xenbus.Xb.Op.Write|Xenbus.Xb.Op.Mkdir -> false, None, newroot - | Xenbus.Xb.Op.Rm -> true, None, oldroot - | Xenbus.Xb.Op.Setperms -> false, Some oldroot, newroot - | _ -> raise (Failure "huh ?") in - Connections.fire_watches ?oldroot source root cons (snd op) recurse in - List.iter (fun op -> do_op_watch op cons) ops; - Connections.send_watchevents cons source + let oldroot = t.Transaction.oldroot in + let newroot = Store.get_root t.Transaction.store in + let ops = Transaction.get_paths t |> List.rev in + let do_op_watch op cons = + let recurse, oldroot, root = match (fst op) with + | Xenbus.Xb.Op.Write|Xenbus.Xb.Op.Mkdir -> false, None, newroot + | Xenbus.Xb.Op.Rm -> true, None, oldroot + | Xenbus.Xb.Op.Setperms -> false, Some oldroot, newroot + | _ -> raise (Failure "huh ?") in + Connections.fire_watches ?oldroot source root cons (snd op) recurse in + List.iter (fun op -> do_op_watch op cons) ops; + Connections.send_watchevents cons source let create_implicit_path t perm path = - let dirname = Store.Path.get_parent path in - if not (Transaction.path_exists t dirname) then ( - let rec check_path p = - match p with - | [] -> [] - | h :: l -> - if Transaction.path_exists t h then - check_path l - else - p in - let ret = check_path (List.tl (Store.Path.get_hierarchy dirname)) in - List.iter (fun s -> Transaction.mkdir ~with_watch:false t perm s) ret - ) + let dirname = Store.Path.get_parent path in + if not (Transaction.path_exists t dirname) then ( + let rec check_path p = + match p with + | [] -> [] + | h :: l -> + if Transaction.path_exists t h then + check_path l + else + p in + let ret = check_path (List.tl (Store.Path.get_hierarchy dirname)) in + List.iter (fun s -> Transaction.mkdir ~with_watch:false t perm s) ret + ) module LiveUpdate = struct -type t = - { binary: string - ; cmdline: string list - ; deadline: float - ; force: bool - ; result: string list - ; pending: bool } + type t = + { binary: string + ; cmdline: string list + ; deadline: float + ; force: bool + ; result: string list + ; pending: bool } -let state = ref - { binary= Sys.executable_name - ; cmdline= (Sys.argv |> Array.to_list |> List.tl) - ; deadline= 0. - ; force= false - ; result = [] - ; pending= false } + let state = ref + { binary= Sys.executable_name + ; cmdline= (Sys.argv |> Array.to_list |> List.tl) + ; deadline= 0. + ; force= false + ; result = [] + ; pending= false } -let debug = Printf.eprintf + let debug = Printf.eprintf -let forced_args = ["--live"; "--restart"] -let args_of_t t = - let filtered = List.filter (fun x -> not @@ List.mem x forced_args) t.cmdline in - (t.binary, forced_args @ filtered) + let forced_args = ["--live"; "--restart"] + let args_of_t t = + let filtered = List.filter (fun x -> not @@ List.mem x forced_args) t.cmdline in + (t.binary, forced_args @ filtered) -let string_of_t t = - let executable, rest = args_of_t t in - Filename.quote_command executable rest + let string_of_t t = + let executable, rest = args_of_t t in + Filename.quote_command executable rest -let launch_exn t = - let executable, rest = args_of_t t in - let args = Array.of_list (executable :: rest) in - info "Launching %s, args: %s" executable (String.concat " " rest); - Unix.execv args.(0) args + let launch_exn t = + let executable, rest = args_of_t t in + let args = Array.of_list (executable :: rest) in + info "Launching %s, args: %s" executable (String.concat " " rest); + Unix.execv args.(0) args -let validate_exn t = - (* --help must be last to check validity of earlier arguments *) - let t' = {t with cmdline= t.cmdline @ ["--help"]} in - let cmd = string_of_t t' in - debug "Executing %s" cmd ; - match Unix.fork () with - | 0 -> ( try launch_exn t' with _ -> exit 2 ) - | pid -> ( - match Unix.waitpid [] pid with - | _, Unix.WEXITED 0 -> - debug "Live update validated cmdline %s" cmd; - t - | _, Unix.WEXITED n -> - invalid_arg (Printf.sprintf "Command %s exited with code %d" cmd n) - | _, Unix.WSIGNALED n -> - invalid_arg (Printf.sprintf "Command %s killed by ocaml signal number %d" cmd n) - | _, Unix.WSTOPPED n -> - invalid_arg (Printf.sprintf "Command %s stopped by ocaml signal number %d" cmd n) - ) + let validate_exn t = + (* --help must be last to check validity of earlier arguments *) + let t' = {t with cmdline= t.cmdline @ ["--help"]} in + let cmd = string_of_t t' in + debug "Executing %s" cmd ; + match Unix.fork () with + | 0 -> ( try launch_exn t' with _ -> exit 2 ) + | pid -> ( + match Unix.waitpid [] pid with + | _, Unix.WEXITED 0 -> + debug "Live update validated cmdline %s" cmd; + t + | _, Unix.WEXITED n -> + invalid_arg (Printf.sprintf "Command %s exited with code %d" cmd n) + | _, Unix.WSIGNALED n -> + invalid_arg (Printf.sprintf "Command %s killed by ocaml signal number %d" cmd n) + | _, Unix.WSTOPPED n -> + invalid_arg (Printf.sprintf "Command %s stopped by ocaml signal number %d" cmd n) + ) -let parse_live_update args = - try - (state := - match args with - | ["-f"; file] -> - validate_exn {!state with binary= file} - | ["-a"] -> - debug "Live update aborted" ; - {!state with pending= false; result = []} - | "-c" :: cmdline -> - validate_exn {!state with cmdline = !state.cmdline @ cmdline} - | "-s" :: _ -> - (match !state.pending, !state.result with - | true, _ -> !state (* no change to state, avoid resetting timeout *) - | false, _ :: _ -> !state (* we got a pending result to deliver *) - | false, [] -> - let timeout = ref 60 in - let force = ref false in - Arg.parse_argv ~current:(ref 0) (Array.of_list args) - [ ( "-t" - , Arg.Set_int timeout - , "timeout in seconds to wait for active transactions to finish" - ) - ; ( "-F" - , Arg.Set force - , "force live update to happen even with running transactions after timeout elapsed" - ) - ] - (fun x -> raise (Arg.Bad x)) - "live-update -s" ; - debug "Live update process queued" ; - {!state with deadline = Unix.gettimeofday () +. float !timeout - ; force= !force; pending= true}) - | _ -> - invalid_arg ("Unknown arguments: " ^ String.concat "," args)) ; - match !state.pending, !state.result with - | true, _ -> Some "BUSY" - | false, (_ :: _ as result) -> - (* xenstore-control has read the result, clear it *) - state := { !state with result = [] }; - Some (String.concat "\n" result) - | false, [] -> None - with - | Arg.Bad s | Arg.Help s | Invalid_argument s -> - Some s - | Unix.Unix_error (e, fn, args) -> - Some (Printf.sprintf "%s(%s): %s" fn args (Unix.error_message e)) + let parse_live_update args = + try + (state := + match args with + | ["-f"; file] -> + validate_exn {!state with binary= file} + | ["-a"] -> + debug "Live update aborted" ; + {!state with pending= false; result = []} + | "-c" :: cmdline -> + validate_exn {!state with cmdline = !state.cmdline @ cmdline} + | "-s" :: _ -> + (match !state.pending, !state.result with + | true, _ -> !state (* no change to state, avoid resetting timeout *) + | false, _ :: _ -> !state (* we got a pending result to deliver *) + | false, [] -> + let timeout = ref 60 in + let force = ref false in + Arg.parse_argv ~current:(ref 0) (Array.of_list args) + [ ( "-t" + , Arg.Set_int timeout + , "timeout in seconds to wait for active transactions to finish" + ) + ; ( "-F" + , Arg.Set force + , "force live update to happen even with running transactions after timeout elapsed" + ) + ] + (fun x -> raise (Arg.Bad x)) + "live-update -s" ; + debug "Live update process queued" ; + {!state with deadline = Unix.gettimeofday () +. float !timeout + ; force= !force; pending= true}) + | _ -> + invalid_arg ("Unknown arguments: " ^ String.concat "," args)) ; + match !state.pending, !state.result with + | true, _ -> Some "BUSY" + | false, (_ :: _ as result) -> + (* xenstore-control has read the result, clear it *) + state := { !state with result = [] }; + Some (String.concat "\n" result) + | false, [] -> None + with + | Arg.Bad s | Arg.Help s | Invalid_argument s -> + Some s + | Unix.Unix_error (e, fn, args) -> + Some (Printf.sprintf "%s(%s): %s" fn args (Unix.error_message e)) - let should_run cons = - let t = !state in - if t.pending then begin - match Connections.prevents_quit cons with - | [] -> true - | _ when Unix.gettimeofday () < t.deadline -> false - | l -> - warn "timeout reached: have to wait, migrate or shutdown %d domains:" (List.length l); - let msgs = List.rev_map (fun con -> Printf.sprintf "%s: %d tx, out: %b, perm: %s" - (Connection.get_domstr con) - (Connection.number_of_transactions con) - (Connection.has_output con) - (Connection.get_perm con |> Perms.Connection.to_string) - ) l in - List.iter (warn "Live-update: %s") msgs; - if t.force then begin - warn "Live update forced, some domain connections may break!"; - true - end else begin - warn "Live update aborted (see above for domains preventing it)"; - state := { t with pending = false; result = msgs}; - false - end - end else false + let should_run cons = + let t = !state in + if t.pending then begin + match Connections.prevents_quit cons with + | [] -> true + | _ when Unix.gettimeofday () < t.deadline -> false + | l -> + warn "timeout reached: have to wait, migrate or shutdown %d domains:" (List.length l); + let msgs = List.rev_map (fun con -> Printf.sprintf "%s: %d tx, out: %b, perm: %s" + (Connection.get_domstr con) + (Connection.number_of_transactions con) + (Connection.has_output con) + (Connection.get_perm con |> Perms.Connection.to_string) + ) l in + List.iter (warn "Live-update: %s") msgs; + if t.force then begin + warn "Live update forced, some domain connections may break!"; + true + end else begin + warn "Live update aborted (see above for domains preventing it)"; + state := { t with pending = false; result = msgs}; + false + end + end else false - let completed () = - state := { !state with result = ["OK"] } + let completed () = + state := { !state with result = ["OK"] } end (* packets *) let do_debug con t _domains cons data = - if not (Connection.is_dom0 con) && not !allow_debug - then None - else try match split None '\000' data with - | "live-update" :: params -> - let dropped_trailing_nul = params |> List.rev |> List.tl |> List.rev in - LiveUpdate.parse_live_update dropped_trailing_nul - | "print" :: msg :: _ -> - Logging.xb_op ~tid:0 ~ty:Xenbus.Xb.Op.Debug ~con:"=======>" msg; - None - | "quota" :: domid :: _ -> - let domid = int_of_string domid in - let quota = (Store.get_quota t.Transaction.store) in - Some (Quota.to_string quota domid ^ "\000") - | "watches" :: _ -> - let watches = Connections.debug cons in - Some (watches ^ "\000") - | "xenbus" :: domid :: _ -> - let domid = int_of_string domid in - let con = Connections.find_domain cons domid in - let s = Printf.sprintf "xenbus: %s; overflow queue length: %d, can_input: %b, has_more_input: %b, has_old_output: %b, has_new_output: %b, has_more_work: %b. pending: %s" - (Xenbus.Xb.debug con.xb) - (Connection.source_pending_watchevents con) - (Connection.can_input con) - (Connection.has_more_input con) - (Connection.has_old_output con) - (Connection.has_new_output con) - (Connection.has_more_work con) - (Connections.debug_watchevents cons con) - in - Some s - | "mfn" :: domid :: _ -> - let domid = int_of_string domid in - let con = Connections.find_domain cons domid in - may (fun dom -> Printf.sprintf "%nd\000" (Domain.get_mfn dom)) (Connection.get_domain con) - | _ -> None - with _ -> None + if not (Connection.is_dom0 con) && not !allow_debug + then None + else try match split None '\000' data with + | "live-update" :: params -> + let dropped_trailing_nul = params |> List.rev |> List.tl |> List.rev in + LiveUpdate.parse_live_update dropped_trailing_nul + | "print" :: msg :: _ -> + Logging.xb_op ~tid:0 ~ty:Xenbus.Xb.Op.Debug ~con:"=======>" msg; + None + | "quota" :: domid :: _ -> + let domid = int_of_string domid in + let quota = (Store.get_quota t.Transaction.store) in + Some (Quota.to_string quota domid ^ "\000") + | "watches" :: _ -> + let watches = Connections.debug cons in + Some (watches ^ "\000") + | "xenbus" :: domid :: _ -> + let domid = int_of_string domid in + let con = Connections.find_domain cons domid in + let s = Printf.sprintf "xenbus: %s; overflow queue length: %d, can_input: %b, has_more_input: %b, has_old_output: %b, has_new_output: %b, has_more_work: %b. pending: %s" + (Xenbus.Xb.debug con.xb) + (Connection.source_pending_watchevents con) + (Connection.can_input con) + (Connection.has_more_input con) + (Connection.has_old_output con) + (Connection.has_new_output con) + (Connection.has_more_work con) + (Connections.debug_watchevents cons con) + in + Some s + | "mfn" :: domid :: _ -> + let domid = int_of_string domid in + let con = Connections.find_domain cons domid in + may (fun dom -> Printf.sprintf "%nd\000" (Domain.get_mfn dom)) (Connection.get_domain con) + | _ -> None + with _ -> None let do_directory con t _domains _cons data = - let path = split_one_path data con in - let entries = Transaction.ls t (Connection.get_perm con) path in - if List.length entries > 0 then - (Utils.join_by_null entries) ^ "\000" - else - "" + let path = split_one_path data con in + let entries = Transaction.ls t (Connection.get_perm con) path in + if List.length entries > 0 then + (Utils.join_by_null entries) ^ "\000" + else + "" let do_read con t _domains _cons data = - let path = split_one_path data con in - Transaction.read t (Connection.get_perm con) path + let path = split_one_path data con in + Transaction.read t (Connection.get_perm con) path let do_getperms con t _domains _cons data = - let path = split_one_path data con in - let perms = Transaction.getperms t (Connection.get_perm con) path in - Perms.Node.to_string perms ^ "\000" + let path = split_one_path data con in + let perms = Transaction.getperms t (Connection.get_perm con) path in + Perms.Node.to_string perms ^ "\000" let do_getdomainpath _con _t _domains _cons data = - let domid = - match (split None '\000' data) with - | domid :: "" :: [] -> c_int_of_string domid - | _ -> raise Invalid_Cmd_Args - in - sprintf "/local/domain/%u\000" domid + let domid = + match (split None '\000' data) with + | domid :: "" :: [] -> c_int_of_string domid + | _ -> raise Invalid_Cmd_Args + in + sprintf "/local/domain/%u\000" domid let do_write con t _domains _cons data = - let path, value = - match (split (Some 2) '\000' data) with - | path :: value :: [] -> Store.Path.create path (Connection.get_path con), value - | _ -> raise Invalid_Cmd_Args - in - create_implicit_path t (Connection.get_perm con) path; - Transaction.write t (Connection.get_perm con) path value + let path, value = + match (split (Some 2) '\000' data) with + | path :: value :: [] -> Store.Path.create path (Connection.get_path con), value + | _ -> raise Invalid_Cmd_Args + in + create_implicit_path t (Connection.get_perm con) path; + Transaction.write t (Connection.get_perm con) path value let do_mkdir con t _domains _cons data = - let path = split_one_path data con in - create_implicit_path t (Connection.get_perm con) path; - try - Transaction.mkdir t (Connection.get_perm con) path - with - Define.Already_exist -> () + let path = split_one_path data con in + create_implicit_path t (Connection.get_perm con) path; + try + Transaction.mkdir t (Connection.get_perm con) path + with + Define.Already_exist -> () let do_rm con t _domains _cons data = - let path = split_one_path data con in - try - Transaction.rm t (Connection.get_perm con) path - with - Define.Doesnt_exist -> () + let path = split_one_path data con in + try + Transaction.rm t (Connection.get_perm con) path + with + Define.Doesnt_exist -> () let do_setperms con t _domains _cons data = - let path, perms = - match (split (Some 2) '\000' data) with - | path :: perms :: _ -> - Store.Path.create path (Connection.get_path con), - (Perms.Node.of_string perms) - | _ -> raise Invalid_Cmd_Args - in - Transaction.setperms t (Connection.get_perm con) path perms + let path, perms = + match (split (Some 2) '\000' data) with + | path :: perms :: _ -> + Store.Path.create path (Connection.get_path con), + (Perms.Node.of_string perms) + | _ -> raise Invalid_Cmd_Args + in + Transaction.setperms t (Connection.get_perm con) path perms let do_error _con _t _domains _cons _data = - raise Define.Unknown_operation + raise Define.Unknown_operation let do_isintroduced con _t domains _cons data = - if not (Connection.is_dom0 con) - then raise Define.Permission_denied; - let domid = - match (split None '\000' data) with - | domid :: _ -> int_of_string domid - | _ -> raise Invalid_Cmd_Args - in - if domid = Define.domid_self || Domains.exist domains domid then "T\000" else "F\000" + if not (Connection.is_dom0 con) + then raise Define.Permission_denied; + let domid = + match (split None '\000' data) with + | domid :: _ -> int_of_string domid + | _ -> raise Invalid_Cmd_Args + in + if domid = Define.domid_self || Domains.exist domains domid then "T\000" else "F\000" (* only in xen >= 4.2 *) let do_reset_watches con _t _domains cons _data = @@ -335,432 +335,432 @@ let do_reset_watches con _t _domains cons _data = (* only in >= xen3.3 *) let do_set_target con _t _domains cons data = - if not (Connection.is_dom0 con) - then raise Define.Permission_denied; - match split None '\000' data with - | [ domid; target_domid; "" ] -> Connections.set_target cons (c_int_of_string domid) (c_int_of_string target_domid) - | _ -> raise Invalid_Cmd_Args + if not (Connection.is_dom0 con) + then raise Define.Permission_denied; + match split None '\000' data with + | [ domid; target_domid; "" ] -> Connections.set_target cons (c_int_of_string domid) (c_int_of_string target_domid) + | _ -> raise Invalid_Cmd_Args (*------------- Generic handling of ty ------------------*) let send_response ty con t rid response = - match response with - | Packet.Ack f -> - Connection.send_ack con (Transaction.get_id t) rid ty; - (* Now do any necessary follow-up actions *) - f () - | Packet.Reply ret -> - Connection.send_reply con (Transaction.get_id t) rid ty ret - | Packet.Error e -> - Connection.send_error con (Transaction.get_id t) rid e + match response with + | Packet.Ack f -> + Connection.send_ack con (Transaction.get_id t) rid ty; + (* Now do any necessary follow-up actions *) + f () + | Packet.Reply ret -> + Connection.send_reply con (Transaction.get_id t) rid ty ret + | Packet.Error e -> + Connection.send_error con (Transaction.get_id t) rid e let reply_ack fct con t doms cons data = - fct con t doms cons data; - Packet.Ack (fun () -> - if Transaction.get_id t = Transaction.none then - process_watch con t cons - ) + fct con t doms cons data; + Packet.Ack (fun () -> + if Transaction.get_id t = Transaction.none then + process_watch con t cons + ) let reply_data fct con t doms cons data = - let ret = fct con t doms cons data in - Packet.Reply ret + let ret = fct con t doms cons data in + Packet.Reply ret let reply_data_or_ack fct con t doms cons data = - match fct con t doms cons data with - | Some ret -> Packet.Reply ret - | None -> Packet.Ack (fun () -> ()) + match fct con t doms cons data with + | Some ret -> Packet.Reply ret + | None -> Packet.Ack (fun () -> ()) let reply_none fct con t doms cons data = - (* let the function reply *) - fct con t doms cons data + (* let the function reply *) + fct con t doms cons data (* Functions for 'simple' operations that cannot be part of a transaction *) let function_of_type_simple_op ty = - match ty with - | Xenbus.Xb.Op.Debug - | Xenbus.Xb.Op.Watch - | Xenbus.Xb.Op.Unwatch - | Xenbus.Xb.Op.Transaction_start - | Xenbus.Xb.Op.Transaction_end - | Xenbus.Xb.Op.Introduce - | Xenbus.Xb.Op.Release - | Xenbus.Xb.Op.Isintroduced - | Xenbus.Xb.Op.Resume - | Xenbus.Xb.Op.Set_target - | Xenbus.Xb.Op.Reset_watches - | Xenbus.Xb.Op.Invalid -> error "called function_of_type_simple_op on operation %s" (Xenbus.Xb.Op.to_string ty); - raise (Invalid_argument (Xenbus.Xb.Op.to_string ty)) - | Xenbus.Xb.Op.Directory -> reply_data do_directory - | Xenbus.Xb.Op.Read -> reply_data do_read - | Xenbus.Xb.Op.Getperms -> reply_data do_getperms - | Xenbus.Xb.Op.Getdomainpath -> reply_data do_getdomainpath - | Xenbus.Xb.Op.Write -> reply_ack do_write - | Xenbus.Xb.Op.Mkdir -> reply_ack do_mkdir - | Xenbus.Xb.Op.Rm -> reply_ack do_rm - | Xenbus.Xb.Op.Setperms -> reply_ack do_setperms - | _ -> reply_ack do_error + match ty with + | Xenbus.Xb.Op.Debug + | Xenbus.Xb.Op.Watch + | Xenbus.Xb.Op.Unwatch + | Xenbus.Xb.Op.Transaction_start + | Xenbus.Xb.Op.Transaction_end + | Xenbus.Xb.Op.Introduce + | Xenbus.Xb.Op.Release + | Xenbus.Xb.Op.Isintroduced + | Xenbus.Xb.Op.Resume + | Xenbus.Xb.Op.Set_target + | Xenbus.Xb.Op.Reset_watches + | Xenbus.Xb.Op.Invalid -> error "called function_of_type_simple_op on operation %s" (Xenbus.Xb.Op.to_string ty); + raise (Invalid_argument (Xenbus.Xb.Op.to_string ty)) + | Xenbus.Xb.Op.Directory -> reply_data do_directory + | Xenbus.Xb.Op.Read -> reply_data do_read + | Xenbus.Xb.Op.Getperms -> reply_data do_getperms + | Xenbus.Xb.Op.Getdomainpath -> reply_data do_getdomainpath + | Xenbus.Xb.Op.Write -> reply_ack do_write + | Xenbus.Xb.Op.Mkdir -> reply_ack do_mkdir + | Xenbus.Xb.Op.Rm -> reply_ack do_rm + | Xenbus.Xb.Op.Setperms -> reply_ack do_setperms + | _ -> reply_ack do_error let input_handle_error ~cons ~doms ~fct ~con ~t ~req = - let reply_error e = - Packet.Error e in - try - Transaction.check_quota_exn ~perm:(Connection.get_perm con) t; - fct con t doms cons req.Packet.data - with - | Define.Invalid_path -> reply_error "EINVAL" - | Define.Already_exist -> reply_error "EEXIST" - | Define.Doesnt_exist -> reply_error "ENOENT" - | Define.Lookup_Doesnt_exist _ -> reply_error "ENOENT" - | Define.Permission_denied -> reply_error "EACCES" - | Not_found -> reply_error "ENOENT" - | Invalid_Cmd_Args -> reply_error "EINVAL" - | Invalid_argument _ -> reply_error "EINVAL" - | Transaction_again -> reply_error "EAGAIN" - | Transaction_nested -> reply_error "EBUSY" - | Domain_not_match -> reply_error "EINVAL" - | Quota.Limit_reached -> reply_error "EQUOTA" - | Quota.Data_too_big -> reply_error "E2BIG" - | Quota.Transaction_opened -> reply_error "EQUOTA" - | (Failure "int_of_string") -> reply_error "EINVAL" - | Define.Unknown_operation -> reply_error "ENOSYS" + let reply_error e = + Packet.Error e in + try + Transaction.check_quota_exn ~perm:(Connection.get_perm con) t; + fct con t doms cons req.Packet.data + with + | Define.Invalid_path -> reply_error "EINVAL" + | Define.Already_exist -> reply_error "EEXIST" + | Define.Doesnt_exist -> reply_error "ENOENT" + | Define.Lookup_Doesnt_exist _ -> reply_error "ENOENT" + | Define.Permission_denied -> reply_error "EACCES" + | Not_found -> reply_error "ENOENT" + | Invalid_Cmd_Args -> reply_error "EINVAL" + | Invalid_argument _ -> reply_error "EINVAL" + | Transaction_again -> reply_error "EAGAIN" + | Transaction_nested -> reply_error "EBUSY" + | Domain_not_match -> reply_error "EINVAL" + | Quota.Limit_reached -> reply_error "EQUOTA" + | Quota.Data_too_big -> reply_error "E2BIG" + | Quota.Transaction_opened -> reply_error "EQUOTA" + | (Failure "int_of_string") -> reply_error "EINVAL" + | Define.Unknown_operation -> reply_error "ENOSYS" let write_access_log ~ty ~tid ~con ~data = - Logging.xb_op ~ty ~tid ~con data + Logging.xb_op ~ty ~tid ~con data let write_answer_log ~ty ~tid ~con ~data = - Logging.xb_answer ~ty ~tid ~con data + Logging.xb_answer ~ty ~tid ~con data let write_response_log ~ty ~tid ~con ~response = - match response with - | Packet.Ack _ -> write_answer_log ~ty ~tid ~con ~data:"" - | Packet.Reply x -> write_answer_log ~ty ~tid ~con ~data:x - | Packet.Error e -> write_answer_log ~ty:(Xenbus.Xb.Op.Error) ~tid ~con ~data:e + match response with + | Packet.Ack _ -> write_answer_log ~ty ~tid ~con ~data:"" + | Packet.Reply x -> write_answer_log ~ty ~tid ~con ~data:x + | Packet.Error e -> write_answer_log ~ty:(Xenbus.Xb.Op.Error) ~tid ~con ~data:e let record_commit ~con ~tid ~before ~after = - let inc r = r := Int64.add 1L !r in - let finish_count = inc Transaction.counter; !Transaction.counter in - History.push {History.con=con; tid=tid; before=before; after=after; finish_count=finish_count} + let inc r = r := Int64.add 1L !r in + let finish_count = inc Transaction.counter; !Transaction.counter in + History.push {History.con=con; tid=tid; before=before; after=after; finish_count=finish_count} (* Replay a stored transaction against a fresh store, check the responses are all equivalent: if so, commit the transaction. Otherwise send the abort to the client. *) let transaction_replay c t doms cons = - match t.Transaction.ty with - | Transaction.No -> - error "attempted to replay a non-full transaction"; - false - | Transaction.Full(id, _oldstore, cstore) -> - let tid = Connection.start_transaction c cstore in - let replay_t = Transaction.make ~internal:true tid cstore in - let con = sprintf "r(%d):%s" id (Connection.get_domstr c) in + match t.Transaction.ty with + | Transaction.No -> + error "attempted to replay a non-full transaction"; + false + | Transaction.Full(id, _oldstore, cstore) -> + let tid = Connection.start_transaction c cstore in + let replay_t = Transaction.make ~internal:true tid cstore in + let con = sprintf "r(%d):%s" id (Connection.get_domstr c) in - let perform_exn ~wlog txn (request, response) = - if wlog then write_access_log ~ty:request.Packet.ty ~tid ~con ~data:request.Packet.data; - let fct = function_of_type_simple_op request.Packet.ty in - let response' = input_handle_error ~cons ~doms ~fct ~con:c ~t:txn ~req:request in - if wlog then write_response_log ~ty:request.Packet.ty ~tid ~con ~response:response'; - if not(Packet.response_equal response response') then raise Transaction_again - in - finally - (fun () -> - try - Logging.start_transaction ~con ~tid; - List.iter (perform_exn ~wlog:true replay_t) (Transaction.get_operations t); (* May throw EAGAIN *) + let perform_exn ~wlog txn (request, response) = + if wlog then write_access_log ~ty:request.Packet.ty ~tid ~con ~data:request.Packet.data; + let fct = function_of_type_simple_op request.Packet.ty in + let response' = input_handle_error ~cons ~doms ~fct ~con:c ~t:txn ~req:request in + if wlog then write_response_log ~ty:request.Packet.ty ~tid ~con ~response:response'; + if not(Packet.response_equal response response') then raise Transaction_again + in + finally + (fun () -> + try + Logging.start_transaction ~con ~tid; + List.iter (perform_exn ~wlog:true replay_t) (Transaction.get_operations t); (* May throw EAGAIN *) - Logging.end_transaction ~con ~tid; - Transaction.commit ~con replay_t - with - | Transaction_again -> ( - Transaction.failed_commits := Int64.add !Transaction.failed_commits 1L; - let victim_domstr = Connection.get_domstr c in - debug "Apportioning blame for EAGAIN in txn %d, domain=%s" id victim_domstr; - let punish guilty_con = - debug "Blaming domain %s for conflict with domain %s txn %d" - (Connection.get_domstr guilty_con) victim_domstr id; - Connection.decr_conflict_credit doms guilty_con - in - let judge_and_sentence hist_rec = ( - let can_apply_on store = ( - let store = Store.copy store in - let trial_t = Transaction.make ~internal:true Transaction.none store in - try List.iter (perform_exn ~wlog:false trial_t) (Transaction.get_operations t); - true - with Transaction_again -> false - ) in - if can_apply_on hist_rec.History.before - && not (can_apply_on hist_rec.History.after) - then (punish hist_rec.History.con; true) - else false - ) in - let guilty_cons = History.filter_connections ~ignore:c ~since:t.Transaction.start_count ~f:judge_and_sentence in - if Hashtbl.length guilty_cons = 0 then ( - debug "Found no culprit for conflict in %s: must be self or not in history." con; - Transaction.failed_commits_no_culprit := Int64.add !Transaction.failed_commits_no_culprit 1L - ); - false - ) - | e -> - info "transaction_replay %d caught: %s" tid (Printexc.to_string e); - false - ) - (fun () -> - ignore @@ Connection.end_transaction c tid None - ) + Logging.end_transaction ~con ~tid; + Transaction.commit ~con replay_t + with + | Transaction_again -> ( + Transaction.failed_commits := Int64.add !Transaction.failed_commits 1L; + let victim_domstr = Connection.get_domstr c in + debug "Apportioning blame for EAGAIN in txn %d, domain=%s" id victim_domstr; + let punish guilty_con = + debug "Blaming domain %s for conflict with domain %s txn %d" + (Connection.get_domstr guilty_con) victim_domstr id; + Connection.decr_conflict_credit doms guilty_con + in + let judge_and_sentence hist_rec = ( + let can_apply_on store = ( + let store = Store.copy store in + let trial_t = Transaction.make ~internal:true Transaction.none store in + try List.iter (perform_exn ~wlog:false trial_t) (Transaction.get_operations t); + true + with Transaction_again -> false + ) in + if can_apply_on hist_rec.History.before + && not (can_apply_on hist_rec.History.after) + then (punish hist_rec.History.con; true) + else false + ) in + let guilty_cons = History.filter_connections ~ignore:c ~since:t.Transaction.start_count ~f:judge_and_sentence in + if Hashtbl.length guilty_cons = 0 then ( + debug "Found no culprit for conflict in %s: must be self or not in history." con; + Transaction.failed_commits_no_culprit := Int64.add !Transaction.failed_commits_no_culprit 1L + ); + false + ) + | e -> + info "transaction_replay %d caught: %s" tid (Printexc.to_string e); + false + ) + (fun () -> + ignore @@ Connection.end_transaction c tid None + ) let do_watch con _t _domains cons data = - let (node, token) = - match (split None '\000' data) with - | [node; token; ""] -> node, token - | _ -> raise Invalid_Cmd_Args - in - let watch = Connections.add_watch cons con node token in - Packet.Ack (fun () -> - (* xenstore.txt says this watch is fired immediately, - implying even if path doesn't exist or is unreadable *) - Connection.fire_single_watch_unchecked con watch) + let (node, token) = + match (split None '\000' data) with + | [node; token; ""] -> node, token + | _ -> raise Invalid_Cmd_Args + in + let watch = Connections.add_watch cons con node token in + Packet.Ack (fun () -> + (* xenstore.txt says this watch is fired immediately, + implying even if path doesn't exist or is unreadable *) + Connection.fire_single_watch_unchecked con watch) let do_unwatch con _t _domains cons data = - let (node, token) = - match (split None '\000' data) with - | [node; token; ""] -> node, token - | _ -> raise Invalid_Cmd_Args - in - ignore @@ Connections.del_watch cons con node token + let (node, token) = + match (split None '\000' data) with + | [node; token; ""] -> node, token + | _ -> raise Invalid_Cmd_Args + in + ignore @@ Connections.del_watch cons con node token let do_transaction_start con t _domains _cons _data = - if Transaction.get_id t <> Transaction.none then - raise Transaction_nested; - let store = Transaction.get_store t in - string_of_int (Connection.start_transaction con store) ^ "\000" + if Transaction.get_id t <> Transaction.none then + raise Transaction_nested; + let store = Transaction.get_store t in + string_of_int (Connection.start_transaction con store) ^ "\000" let do_transaction_end con t domains cons data = - let commit = - match (split None '\000' data) with - | "T" :: _ -> true - | "F" :: _ -> false - | x :: _ -> raise (Invalid_argument x) - | _ -> raise Invalid_Cmd_Args - in - let commit = commit && not (Transaction.is_read_only t) in - let success = - let commit = if commit then Some (fun con trans -> transaction_replay con trans domains cons) else None in - History.end_transaction t con (Transaction.get_id t) commit in - if not success then - raise Transaction_again; - if commit then begin - process_watch con t cons; - match t.Transaction.ty with - | Transaction.No -> - () (* no need to record anything *) - | Transaction.Full(id, oldstore, cstore) -> - record_commit ~con ~tid:id ~before:oldstore ~after:cstore - end + let commit = + match (split None '\000' data) with + | "T" :: _ -> true + | "F" :: _ -> false + | x :: _ -> raise (Invalid_argument x) + | _ -> raise Invalid_Cmd_Args + in + let commit = commit && not (Transaction.is_read_only t) in + let success = + let commit = if commit then Some (fun con trans -> transaction_replay con trans domains cons) else None in + History.end_transaction t con (Transaction.get_id t) commit in + if not success then + raise Transaction_again; + if commit then begin + process_watch con t cons; + match t.Transaction.ty with + | Transaction.No -> + () (* no need to record anything *) + | Transaction.Full(id, oldstore, cstore) -> + record_commit ~con ~tid:id ~before:oldstore ~after:cstore + end let do_introduce con t domains cons data = - if not (Connection.is_dom0 con) - then raise Define.Permission_denied; - let (domid, mfn, port) = - match (split None '\000' data) with - | domid :: mfn :: port :: _ -> - int_of_string domid, Nativeint.of_string mfn, int_of_string port - | _ -> raise Invalid_Cmd_Args; - in - let dom = - if Domains.exist domains domid then - let edom = Domains.find domains domid in - if (Domain.get_mfn edom) = mfn && (Connections.find_domain cons domid) != con then begin - (* Use XS_INTRODUCE for recreating the xenbus event-channel. *) - edom.remote_port <- port; - Domain.bind_interdomain edom; - end; - edom - else try - let ndom = Domains.create domains domid mfn port in - Connections.add_domain cons ndom; - Connections.fire_spec_watches (Transaction.get_root t) cons Store.Path.introduce_domain; - ndom - with _ -> raise Invalid_Cmd_Args - in - if (Domain.get_remote_port dom) <> port || (Domain.get_mfn dom) <> mfn then - raise Domain_not_match + if not (Connection.is_dom0 con) + then raise Define.Permission_denied; + let (domid, mfn, port) = + match (split None '\000' data) with + | domid :: mfn :: port :: _ -> + int_of_string domid, Nativeint.of_string mfn, int_of_string port + | _ -> raise Invalid_Cmd_Args; + in + let dom = + if Domains.exist domains domid then + let edom = Domains.find domains domid in + if (Domain.get_mfn edom) = mfn && (Connections.find_domain cons domid) != con then begin + (* Use XS_INTRODUCE for recreating the xenbus event-channel. *) + edom.remote_port <- port; + Domain.bind_interdomain edom; + end; + edom + else try + let ndom = Domains.create domains domid mfn port in + Connections.add_domain cons ndom; + Connections.fire_spec_watches (Transaction.get_root t) cons Store.Path.introduce_domain; + ndom + with _ -> raise Invalid_Cmd_Args + in + if (Domain.get_remote_port dom) <> port || (Domain.get_mfn dom) <> mfn then + raise Domain_not_match let do_release con t domains cons data = - if not (Connection.is_dom0 con) - then raise Define.Permission_denied; - let domid = - match (split None '\000' data) with - | [domid;""] -> int_of_string domid - | _ -> raise Invalid_Cmd_Args - in - let fire_spec_watches = Domains.exist domains domid in - Domains.del domains domid; - Connections.del_domain cons domid; - Store.reset_permissions (Transaction.get_store t) domid; - if fire_spec_watches - then Connections.fire_spec_watches (Transaction.get_root t) cons Store.Path.release_domain - else raise Invalid_Cmd_Args + if not (Connection.is_dom0 con) + then raise Define.Permission_denied; + let domid = + match (split None '\000' data) with + | [domid;""] -> int_of_string domid + | _ -> raise Invalid_Cmd_Args + in + let fire_spec_watches = Domains.exist domains domid in + Domains.del domains domid; + Connections.del_domain cons domid; + Store.reset_permissions (Transaction.get_store t) domid; + if fire_spec_watches + then Connections.fire_spec_watches (Transaction.get_root t) cons Store.Path.release_domain + else raise Invalid_Cmd_Args let do_resume con _t domains _cons data = - if not (Connection.is_dom0 con) - then raise Define.Permission_denied; - let domid = - match (split None '\000' data) with - | domid :: _ -> int_of_string domid - | _ -> raise Invalid_Cmd_Args - in - if Domains.exist domains domid - then Domains.resume domains domid - else raise Invalid_Cmd_Args + if not (Connection.is_dom0 con) + then raise Define.Permission_denied; + let domid = + match (split None '\000' data) with + | domid :: _ -> int_of_string domid + | _ -> raise Invalid_Cmd_Args + in + if Domains.exist domains domid + then Domains.resume domains domid + else raise Invalid_Cmd_Args let function_of_type ty = - match ty with - | Xenbus.Xb.Op.Debug -> reply_data_or_ack do_debug - | Xenbus.Xb.Op.Watch -> reply_none do_watch - | Xenbus.Xb.Op.Unwatch -> reply_ack do_unwatch - | Xenbus.Xb.Op.Transaction_start -> reply_data do_transaction_start - | Xenbus.Xb.Op.Transaction_end -> reply_ack do_transaction_end - | Xenbus.Xb.Op.Introduce -> reply_ack do_introduce - | Xenbus.Xb.Op.Release -> reply_ack do_release - | Xenbus.Xb.Op.Isintroduced -> reply_data do_isintroduced - | Xenbus.Xb.Op.Resume -> reply_ack do_resume - | Xenbus.Xb.Op.Set_target -> reply_ack do_set_target - | Xenbus.Xb.Op.Reset_watches -> reply_ack do_reset_watches - | Xenbus.Xb.Op.Invalid -> reply_ack do_error - | _ -> function_of_type_simple_op ty + match ty with + | Xenbus.Xb.Op.Debug -> reply_data_or_ack do_debug + | Xenbus.Xb.Op.Watch -> reply_none do_watch + | Xenbus.Xb.Op.Unwatch -> reply_ack do_unwatch + | Xenbus.Xb.Op.Transaction_start -> reply_data do_transaction_start + | Xenbus.Xb.Op.Transaction_end -> reply_ack do_transaction_end + | Xenbus.Xb.Op.Introduce -> reply_ack do_introduce + | Xenbus.Xb.Op.Release -> reply_ack do_release + | Xenbus.Xb.Op.Isintroduced -> reply_data do_isintroduced + | Xenbus.Xb.Op.Resume -> reply_ack do_resume + | Xenbus.Xb.Op.Set_target -> reply_ack do_set_target + | Xenbus.Xb.Op.Reset_watches -> reply_ack do_reset_watches + | Xenbus.Xb.Op.Invalid -> reply_ack do_error + | _ -> function_of_type_simple_op ty (** * Determines which individual (non-transactional) operations we want to retain. * We only want to retain operations that have side-effects in the store since * these can be the cause of transactions failing. - *) +*) let retain_op_in_history ty = - match ty with - | Xenbus.Xb.Op.Write - | Xenbus.Xb.Op.Mkdir - | Xenbus.Xb.Op.Rm - | Xenbus.Xb.Op.Setperms -> true - | Xenbus.Xb.Op.Debug - | Xenbus.Xb.Op.Directory - | Xenbus.Xb.Op.Read - | Xenbus.Xb.Op.Getperms - | Xenbus.Xb.Op.Watch - | Xenbus.Xb.Op.Unwatch - | Xenbus.Xb.Op.Transaction_start - | Xenbus.Xb.Op.Transaction_end - | Xenbus.Xb.Op.Introduce - | Xenbus.Xb.Op.Release - | Xenbus.Xb.Op.Getdomainpath - | Xenbus.Xb.Op.Watchevent - | Xenbus.Xb.Op.Error - | Xenbus.Xb.Op.Isintroduced - | Xenbus.Xb.Op.Resume - | Xenbus.Xb.Op.Set_target - | Xenbus.Xb.Op.Reset_watches - | Xenbus.Xb.Op.Invalid -> false + match ty with + | Xenbus.Xb.Op.Write + | Xenbus.Xb.Op.Mkdir + | Xenbus.Xb.Op.Rm + | Xenbus.Xb.Op.Setperms -> true + | Xenbus.Xb.Op.Debug + | Xenbus.Xb.Op.Directory + | Xenbus.Xb.Op.Read + | Xenbus.Xb.Op.Getperms + | Xenbus.Xb.Op.Watch + | Xenbus.Xb.Op.Unwatch + | Xenbus.Xb.Op.Transaction_start + | Xenbus.Xb.Op.Transaction_end + | Xenbus.Xb.Op.Introduce + | Xenbus.Xb.Op.Release + | Xenbus.Xb.Op.Getdomainpath + | Xenbus.Xb.Op.Watchevent + | Xenbus.Xb.Op.Error + | Xenbus.Xb.Op.Isintroduced + | Xenbus.Xb.Op.Resume + | Xenbus.Xb.Op.Set_target + | Xenbus.Xb.Op.Reset_watches + | Xenbus.Xb.Op.Invalid -> false let maybe_ignore_transaction = function - | Xenbus.Xb.Op.Watch | Xenbus.Xb.Op.Unwatch -> fun tid -> - if tid <> Transaction.none then - debug "Ignoring transaction ID %d for watch/unwatch" tid; - Transaction.none - | _ -> fun x -> x + | Xenbus.Xb.Op.Watch | Xenbus.Xb.Op.Unwatch -> fun tid -> + if tid <> Transaction.none then + debug "Ignoring transaction ID %d for watch/unwatch" tid; + Transaction.none + | _ -> fun x -> x let () = Printexc.record_backtrace true (** * Nothrow guarantee. - *) +*) let process_packet ~store ~cons ~doms ~con ~req = - let ty = req.Packet.ty in - let tid = maybe_ignore_transaction ty req.Packet.tid in - let rid = req.Packet.rid in - try - let fct = function_of_type ty in - let t = - if tid = Transaction.none then - Transaction.make tid store - else - Connection.get_transaction con tid - in + let ty = req.Packet.ty in + let tid = maybe_ignore_transaction ty req.Packet.tid in + let rid = req.Packet.rid in + try + let fct = function_of_type ty in + let t = + if tid = Transaction.none then + Transaction.make tid store + else + Connection.get_transaction con tid + in - let execute () = input_handle_error ~cons ~doms ~fct ~con ~t ~req in + let execute () = input_handle_error ~cons ~doms ~fct ~con ~t ~req in - let response = - (* Note that transactions are recorded in history separately. *) - if tid = Transaction.none && retain_op_in_history ty then begin - let before = Store.copy store in - let response = execute () in - let after = Store.copy store in - record_commit ~con ~tid ~before ~after; - response - end else execute () - in + let response = + (* Note that transactions are recorded in history separately. *) + if tid = Transaction.none && retain_op_in_history ty then begin + let before = Store.copy store in + let response = execute () in + let after = Store.copy store in + record_commit ~con ~tid ~before ~after; + response + end else execute () + in - let response = try - Transaction.check_quota_exn ~perm:(Connection.get_perm con) t; - if tid <> Transaction.none then - (* Remember the request and response for this operation in case we need to replay the transaction *) - Transaction.add_operation t req response; - response - with Quota.Limit_reached -> - Packet.Error "EQUOTA" - in + let response = try + Transaction.check_quota_exn ~perm:(Connection.get_perm con) t; + if tid <> Transaction.none then + (* Remember the request and response for this operation in case we need to replay the transaction *) + Transaction.add_operation t req response; + response + with Quota.Limit_reached -> + Packet.Error "EQUOTA" + in - (* Put the response on the wire *) - send_response ty con t rid response - with exn -> - let bt = Printexc.get_backtrace () in - error "process packet: %s. %s" (Printexc.to_string exn) bt; - Connection.send_error con tid rid "EIO" + (* Put the response on the wire *) + send_response ty con t rid response + with exn -> + let bt = Printexc.get_backtrace () in + error "process packet: %s. %s" (Printexc.to_string exn) bt; + Connection.send_error con tid rid "EIO" let do_input store cons doms con = - let newpacket = - try - if Connection.can_input con then Connection.do_input con - else None - with Xenbus.Xb.Reconnect -> - info "%s requests a reconnect" (Connection.get_domstr con); - History.reconnect con; - info "%s reconnection complete" (Connection.get_domstr con); - None - | Invalid_argument exp | Failure exp -> - error "caught exception %s" exp; - error "got a bad client %s" (sprintf "%-8s" (Connection.get_domstr con)); - Connection.mark_as_bad con; - None - in + let newpacket = + try + if Connection.can_input con then Connection.do_input con + else None + with Xenbus.Xb.Reconnect -> + info "%s requests a reconnect" (Connection.get_domstr con); + History.reconnect con; + info "%s reconnection complete" (Connection.get_domstr con); + None + | Invalid_argument exp | Failure exp -> + error "caught exception %s" exp; + error "got a bad client %s" (sprintf "%-8s" (Connection.get_domstr con)); + Connection.mark_as_bad con; + None + in - match newpacket with - | None -> () - | Some packet -> - let tid, rid, ty, data = Xenbus.Xb.Packet.unpack packet in - let req = {Packet.tid=tid; Packet.rid=rid; Packet.ty=ty; Packet.data=data} in + match newpacket with + | None -> () + | Some packet -> + let tid, rid, ty, data = Xenbus.Xb.Packet.unpack packet in + let req = {Packet.tid=tid; Packet.rid=rid; Packet.ty=ty; Packet.data=data} in - (* As we don't log IO, do not call an unnecessary sanitize_data - info "[%s] -> [%d] %s \"%s\"" - (Connection.get_domstr con) tid - (Xenbus.Xb.Op.to_string ty) (sanitize_data data); *) - process_packet ~store ~cons ~doms ~con ~req; - write_access_log ~ty ~tid ~con:(Connection.get_domstr con) ~data; - Connection.incr_ops con + (* As we don't log IO, do not call an unnecessary sanitize_data + info "[%s] -> [%d] %s \"%s\"" + (Connection.get_domstr con) tid + (Xenbus.Xb.Op.to_string ty) (sanitize_data data); *) + process_packet ~store ~cons ~doms ~con ~req; + write_access_log ~ty ~tid ~con:(Connection.get_domstr con) ~data; + Connection.incr_ops con let do_output _store _cons _doms con = - Connection.source_flush_watchevents con; - if Connection.has_output con then ( - if Connection.has_new_output con then ( - let packet = Connection.peek_output con in - let tid, _rid, ty, data = Xenbus.Xb.Packet.unpack packet in - (* As we don't log IO, do not call an unnecessary sanitize_data - info "[%s] <- %s \"%s\"" - (Connection.get_domstr con) - (Xenbus.Xb.Op.to_string ty) (sanitize_data data);*) - write_answer_log ~ty ~tid ~con:(Connection.get_domstr con) ~data; - ); - try - ignore (Connection.do_output con) - with Xenbus.Xb.Reconnect -> - info "%s requests a reconnect" (Connection.get_domstr con); - History.reconnect con; - info "%s reconnection complete" (Connection.get_domstr con) - ) + Connection.source_flush_watchevents con; + if Connection.has_output con then ( + if Connection.has_new_output con then ( + let packet = Connection.peek_output con in + let tid, _rid, ty, data = Xenbus.Xb.Packet.unpack packet in + (* As we don't log IO, do not call an unnecessary sanitize_data + info "[%s] <- %s \"%s\"" + (Connection.get_domstr con) + (Xenbus.Xb.Op.to_string ty) (sanitize_data data);*) + write_answer_log ~ty ~tid ~con:(Connection.get_domstr con) ~data; + ); + try + ignore (Connection.do_output con) + with Xenbus.Xb.Reconnect -> + info "%s requests a reconnect" (Connection.get_domstr con); + History.reconnect con; + info "%s reconnection complete" (Connection.get_domstr con) + ) diff --git a/tools/ocaml/xenstored/quota.ml b/tools/ocaml/xenstored/quota.ml index 6e3d6401ae..300d78a50b 100644 --- a/tools/ocaml/xenstored/quota.ml +++ b/tools/ocaml/xenstored/quota.ml @@ -24,65 +24,65 @@ let maxent = ref (1000) let maxsize = ref (2048) type t = { - maxent: int; (* max entities per domU *) - maxsize: int; (* max size of data store in one node *) - cur: (Xenctrl.domid, int) Hashtbl.t; (* current domains quota *) + maxent: int; (* max entities per domU *) + maxsize: int; (* max size of data store in one node *) + cur: (Xenctrl.domid, int) Hashtbl.t; (* current domains quota *) } let to_string quota domid = - if Hashtbl.mem quota.cur domid - then Printf.sprintf "dom%i quota: %i/%i" domid (Hashtbl.find quota.cur domid) quota.maxent - else Printf.sprintf "dom%i quota: not set" domid + if Hashtbl.mem quota.cur domid + then Printf.sprintf "dom%i quota: %i/%i" domid (Hashtbl.find quota.cur domid) quota.maxent + else Printf.sprintf "dom%i quota: not set" domid let create () = - { maxent = !maxent; maxsize = !maxsize; cur = Hashtbl.create 100; } + { maxent = !maxent; maxsize = !maxsize; cur = Hashtbl.create 100; } let copy quota = { quota with cur = (Hashtbl.copy quota.cur) } let del quota id = Hashtbl.remove quota.cur id let _check quota id size = - if size > quota.maxsize then ( - warn "domain %u err create entry: data too big %d" id size; - raise Data_too_big - ); - if id > 0 && Hashtbl.mem quota.cur id then - let entry = Hashtbl.find quota.cur id in - if entry >= quota.maxent then ( - warn "domain %u cannot create entry: quota reached" id; - raise Limit_reached - ) + if size > quota.maxsize then ( + warn "domain %u err create entry: data too big %d" id size; + raise Data_too_big + ); + if id > 0 && Hashtbl.mem quota.cur id then + let entry = Hashtbl.find quota.cur id in + if entry >= quota.maxent then ( + warn "domain %u cannot create entry: quota reached" id; + raise Limit_reached + ) let check quota id size = - if !activate then - _check quota id size + if !activate then + _check quota id size let get_entry quota id = Hashtbl.find quota.cur id let set_entry quota id nb = - if nb = 0 - then Hashtbl.remove quota.cur id - else begin - if Hashtbl.mem quota.cur id then - Hashtbl.replace quota.cur id nb - else - Hashtbl.add quota.cur id nb - end + if nb = 0 + then Hashtbl.remove quota.cur id + else begin + if Hashtbl.mem quota.cur id then + Hashtbl.replace quota.cur id nb + else + Hashtbl.add quota.cur id nb + end let del_entry quota id = - try - let nb = get_entry quota id in - set_entry quota id (nb - 1) - with Not_found -> () + try + let nb = get_entry quota id in + set_entry quota id (nb - 1) + with Not_found -> () let add_entry quota id = - let nb = try get_entry quota id with Not_found -> 0 in - set_entry quota id (nb + 1) + let nb = try get_entry quota id with Not_found -> 0 in + set_entry quota id (nb + 1) let add quota diff = - Hashtbl.iter (fun id nb -> set_entry quota id (get_entry quota id + nb)) diff.cur + Hashtbl.iter (fun id nb -> set_entry quota id (get_entry quota id + nb)) diff.cur let merge orig_quota mod_quota dest_quota = - Hashtbl.iter (fun id nb -> let diff = nb - (try get_entry orig_quota id with Not_found -> 0) in - if diff <> 0 then - set_entry dest_quota id ((try get_entry dest_quota id with Not_found -> 0) + diff)) mod_quota.cur + Hashtbl.iter (fun id nb -> let diff = nb - (try get_entry orig_quota id with Not_found -> 0) in + if diff <> 0 then + set_entry dest_quota id ((try get_entry dest_quota id with Not_found -> 0) + diff)) mod_quota.cur diff --git a/tools/ocaml/xenstored/select_stubs.c b/tools/ocaml/xenstored/select_stubs.c index af72b84fa2..f2ef1ec3de 100644 --- a/tools/ocaml/xenstored/select_stubs.c +++ b/tools/ocaml/xenstored/select_stubs.c @@ -25,56 +25,56 @@ CAMLprim value stub_select_on_poll(value fd_events, value timeo) { - CAMLparam2(fd_events, timeo); - CAMLlocal1(events); - int i, rc, c_len = Wosize_val(fd_events), c_timeo = Int_val(timeo); - struct pollfd c_fds[c_len]; + CAMLparam2(fd_events, timeo); + CAMLlocal1(events); + int i, rc, c_len = Wosize_val(fd_events), c_timeo = Int_val(timeo); + struct pollfd c_fds[c_len]; - for (i = 0; i < c_len; i++) { + for (i = 0; i < c_len; i++) { - events = Field(Field(fd_events, i), 1); + events = Field(Field(fd_events, i), 1); - c_fds[i].fd = Int_val(Field(Field(fd_events, i), 0)); - c_fds[i].events = c_fds[i].revents = 0; - c_fds[i].events |= Bool_val(Field(events, 0)) ? POLLIN : 0; - c_fds[i].events |= Bool_val(Field(events, 1)) ? POLLOUT: 0; - c_fds[i].events |= Bool_val(Field(events, 2)) ? POLLPRI: 0; + c_fds[i].fd = Int_val(Field(Field(fd_events, i), 0)); + c_fds[i].events = c_fds[i].revents = 0; + c_fds[i].events |= Bool_val(Field(events, 0)) ? POLLIN : 0; + c_fds[i].events |= Bool_val(Field(events, 1)) ? POLLOUT: 0; + c_fds[i].events |= Bool_val(Field(events, 2)) ? POLLPRI: 0; - }; + }; - caml_enter_blocking_section(); - rc = poll(c_fds, c_len, c_timeo); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + rc = poll(c_fds, c_len, c_timeo); + caml_leave_blocking_section(); - if (rc < 0) uerror("poll", Nothing); + if (rc < 0) uerror("poll", Nothing); - if (rc > 0) { + if (rc > 0) { - for (i = 0; i < c_len; i++) { + for (i = 0; i < c_len; i++) { - events = Field(Field(fd_events, i), 1); + events = Field(Field(fd_events, i), 1); - if (c_fds[i].revents & POLLNVAL) unix_error(EBADF, "select", Nothing); - Field(events, 0) = Val_bool(c_fds[i].events & POLLIN && c_fds[i].revents & (POLLIN |POLLHUP|POLLERR)); - Field(events, 1) = Val_bool(c_fds[i].events & POLLOUT && c_fds[i].revents & (POLLOUT|POLLHUP|POLLERR)); - Field(events, 2) = Val_bool(c_fds[i].revents & POLLPRI); + if (c_fds[i].revents & POLLNVAL) unix_error(EBADF, "select", Nothing); + Field(events, 0) = Val_bool(c_fds[i].events & POLLIN && c_fds[i].revents & (POLLIN |POLLHUP|POLLERR)); + Field(events, 1) = Val_bool(c_fds[i].events & POLLOUT && c_fds[i].revents & (POLLOUT|POLLHUP|POLLERR)); + Field(events, 2) = Val_bool(c_fds[i].revents & POLLPRI); - } + } - } + } - CAMLreturn(Val_int(rc)); + CAMLreturn(Val_int(rc)); } CAMLprim value stub_set_fd_limit(value limit) { - CAMLparam1(limit); - struct rlimit rl; + CAMLparam1(limit); + struct rlimit rl; - rl.rlim_cur = rl.rlim_max = Int_val(limit); - if (setrlimit(RLIMIT_NOFILE, &rl) != 0) uerror("setrlimit", Nothing); - CAMLreturn(Val_unit); + rl.rlim_cur = rl.rlim_max = Int_val(limit); + if (setrlimit(RLIMIT_NOFILE, &rl) != 0) uerror("setrlimit", Nothing); + CAMLreturn(Val_unit); } diff --git a/tools/ocaml/xenstored/stdext.ml b/tools/ocaml/xenstored/stdext.ml index 116920917a..0ee4a5ab9c 100644 --- a/tools/ocaml/xenstored/stdext.ml +++ b/tools/ocaml/xenstored/stdext.ml @@ -19,137 +19,137 @@ type ('a, 'b) either = Right of 'a | Left of 'b (** apply the clean_f function after fct function has been called. * Even if fct raises an exception, clean_f is applied - *) +*) let exnhook = ref None let finally fct clean_f = - let result = try - fct (); - with - exn -> - (match !exnhook with None -> () | Some f -> f exn); - clean_f (); raise exn in - clean_f (); - result + let result = try + fct (); + with + exn -> + (match !exnhook with None -> () | Some f -> f exn); + clean_f (); raise exn in + clean_f (); + result (** if v is not none, apply f on it and return some value else return none. *) let may f v = - match v with Some x -> Some (f x) | None -> None + match v with Some x -> Some (f x) | None -> None (** default value to d if v is none. *) let default d v = - match v with Some x -> x | None -> d + match v with Some x -> x | None -> d (** apply f on v if not none *) let maybe f v = - match v with None -> () | Some x -> f x + match v with None -> () | Some x -> f x module Filename = struct - include Filename - let quote_command cmd args = - cmd :: args |> List.map quote |> String.concat " " + include Filename + let quote_command cmd args = + cmd :: args |> List.map quote |> String.concat " " end module Map = struct - module Make(Ord: Map.OrderedType) = struct + module Make(Ord: Map.OrderedType) = struct - include Map.Make(Ord) + include Map.Make(Ord) - let find_opt k t = try Some (find k t) with Not_found -> None + let find_opt k t = try Some (find k t) with Not_found -> None - let update k f t = - let r = find_opt k t in - let r' = f r in - match r, r' with - | None, None -> t - | Some _, None -> remove k t - | Some r, Some r' when r == r' -> t - | _, Some r' -> add k r' t + let update k f t = + let r = find_opt k t in + let r' = f r in + match r, r' with + | None, None -> t + | Some _, None -> remove k t + | Some r, Some r' when r == r' -> t + | _, Some r' -> add k r' t - end + end end module String = struct include String -let of_char c = String.make 1 c + let of_char c = String.make 1 c -let rec split ?limit:(limit=(-1)) c s = - let i = try String.index s c with Not_found -> -1 in - let nlimit = if limit = -1 || limit = 0 then limit else limit - 1 in - if i = -1 || nlimit = 0 then - [ s ] - else - let a = String.sub s 0 i - and b = String.sub s (i + 1) (String.length s - i - 1) in - a :: (split ~limit: nlimit c b) + let rec split ?limit:(limit=(-1)) c s = + let i = try String.index s c with Not_found -> -1 in + let nlimit = if limit = -1 || limit = 0 then limit else limit - 1 in + if i = -1 || nlimit = 0 then + [ s ] + else + let a = String.sub s 0 i + and b = String.sub s (i + 1) (String.length s - i - 1) in + a :: (split ~limit: nlimit c b) -let fold_left f accu string = - let accu = ref accu in - for i = 0 to length string - 1 do - accu := f !accu string.[i] - done; - !accu + let fold_left f accu string = + let accu = ref accu in + for i = 0 to length string - 1 do + accu := f !accu string.[i] + done; + !accu -(** True if string 'x' starts with prefix 'prefix' *) -let startswith prefix x = - let x_l = String.length x and prefix_l = String.length prefix in - prefix_l <= x_l && String.sub x 0 prefix_l = prefix + (** True if string 'x' starts with prefix 'prefix' *) + let startswith prefix x = + let x_l = String.length x and prefix_l = String.length prefix in + prefix_l <= x_l && String.sub x 0 prefix_l = prefix end module Unixext = struct -(** remove a file, but doesn't raise an exception if the file is already removed *) -let unlink_safe file = - try Unix.unlink file with (* Unix.Unix_error (Unix.ENOENT, _ , _)*) _ -> () + (** remove a file, but doesn't raise an exception if the file is already removed *) + let unlink_safe file = + try Unix.unlink file with (* Unix.Unix_error (Unix.ENOENT, _ , _)*) _ -> () -(** create a directory but doesn't raise an exception if the directory already exist *) -let mkdir_safe dir perm = - try Unix.mkdir dir perm with Unix.Unix_error (Unix.EEXIST, _, _) -> () + (** create a directory but doesn't raise an exception if the directory already exist *) + let mkdir_safe dir perm = + try Unix.mkdir dir perm with Unix.Unix_error (Unix.EEXIST, _, _) -> () -(** create a directory, and create parent if doesn't exist *) -let mkdir_rec dir perm = - let rec p_mkdir dir = - let p_name = Filename.dirname dir in - if p_name <> "/" && p_name <> "." - then p_mkdir p_name; - mkdir_safe dir perm in - p_mkdir dir + (** create a directory, and create parent if doesn't exist *) + let mkdir_rec dir perm = + let rec p_mkdir dir = + let p_name = Filename.dirname dir in + if p_name <> "/" && p_name <> "." + then p_mkdir p_name; + mkdir_safe dir perm in + p_mkdir dir -(** daemonize a process *) -(* !! Must call this before spawning any threads !! *) -let daemonize () = - match Unix.fork () with - | 0 -> - if Unix.setsid () == -1 then - failwith "Unix.setsid failed"; + (** daemonize a process *) + (* !! Must call this before spawning any threads !! *) + let daemonize () = + match Unix.fork () with + | 0 -> + if Unix.setsid () == -1 then + failwith "Unix.setsid failed"; - begin match Unix.fork () with - | 0 -> - let nullfd = Unix.openfile "/dev/null" [ Unix.O_RDWR ] 0 in - begin try - Unix.dup2 nullfd Unix.stdin; - Unix.dup2 nullfd Unix.stdout; - Unix.dup2 nullfd Unix.stderr; - with exn -> Unix.close nullfd; raise exn - end; - Unix.close nullfd - | _ -> exit 0 - end - | _ -> exit 0 + begin match Unix.fork () with + | 0 -> + let nullfd = Unix.openfile "/dev/null" [ Unix.O_RDWR ] 0 in + begin try + Unix.dup2 nullfd Unix.stdin; + Unix.dup2 nullfd Unix.stdout; + Unix.dup2 nullfd Unix.stderr; + with exn -> Unix.close nullfd; raise exn + end; + Unix.close nullfd + | _ -> exit 0 + end + | _ -> exit 0 -(** write a pidfile file *) -let pidfile_write filename = - let fd = Unix.openfile filename - [ Unix.O_WRONLY; Unix.O_CREAT; Unix.O_TRUNC; ] - 0o640 in - finally - (fun () -> - let pid = Unix.getpid () in - let buf = string_of_int pid ^ "\n" in - let len = String.length buf in - if Unix.write_substring fd buf 0 len <> len - then failwith "pidfile_write failed"; - ) - (fun () -> Unix.close fd) + (** write a pidfile file *) + let pidfile_write filename = + let fd = Unix.openfile filename + [ Unix.O_WRONLY; Unix.O_CREAT; Unix.O_TRUNC; ] + 0o640 in + finally + (fun () -> + let pid = Unix.getpid () in + let buf = string_of_int pid ^ "\n" in + let len = String.length buf in + if Unix.write_substring fd buf 0 len <> len + then failwith "pidfile_write failed"; + ) + (fun () -> Unix.close fd) end diff --git a/tools/ocaml/xenstored/store.ml b/tools/ocaml/xenstored/store.ml index 70f0c83de4..14ec404988 100644 --- a/tools/ocaml/xenstored/store.ml +++ b/tools/ocaml/xenstored/store.ml @@ -20,231 +20,231 @@ module SymbolMap = Map.Make(Symbol) module Node = struct -type t = { - name: Symbol.t; - perms: Perms.Node.t; - value: string; - children: t SymbolMap.t; -} + type t = { + name: Symbol.t; + perms: Perms.Node.t; + value: string; + children: t SymbolMap.t; + } -let create _name _perms _value = - { name = Symbol.of_string _name; perms = _perms; value = _value; children = SymbolMap.empty; } + let create _name _perms _value = + { name = Symbol.of_string _name; perms = _perms; value = _value; children = SymbolMap.empty; } -let get_owner node = Perms.Node.get_owner node.perms -let get_children node = node.children -let get_value node = node.value -let get_perms node = node.perms -let get_name node = Symbol.to_string node.name + let get_owner node = Perms.Node.get_owner node.perms + let get_children node = node.children + let get_value node = node.value + let get_perms node = node.perms + let get_name node = Symbol.to_string node.name -let set_value node nvalue = - if node.value = nvalue - then node - else { node with value = nvalue } + let set_value node nvalue = + if node.value = nvalue + then node + else { node with value = nvalue } -let set_perms node nperms = { node with perms = nperms } + let set_perms node nperms = { node with perms = nperms } -let add_child node child = - let children = SymbolMap.add child.name child node.children in - { node with children } + let add_child node child = + let children = SymbolMap.add child.name child node.children in + { node with children } -let exists node childname = - let childname = Symbol.of_string childname in - SymbolMap.mem childname node.children + let exists node childname = + let childname = Symbol.of_string childname in + SymbolMap.mem childname node.children -let find node childname = - let childname = Symbol.of_string childname in - SymbolMap.find childname node.children + let find node childname = + let childname = Symbol.of_string childname in + SymbolMap.find childname node.children -let replace_child node child nchild = - { node with - children = SymbolMap.update child.name - (function None -> None | Some _ -> Some nchild) - node.children - } + let replace_child node child nchild = + { node with + children = SymbolMap.update child.name + (function None -> None | Some _ -> Some nchild) + node.children + } -let del_childname node childname = - let sym = Symbol.of_string childname in - { node with children = - SymbolMap.update sym - (function None -> raise Not_found | Some _ -> None) - node.children - } + let del_childname node childname = + let sym = Symbol.of_string childname in + { node with children = + SymbolMap.update sym + (function None -> raise Not_found | Some _ -> None) + node.children + } -let del_all_children node = - { node with children = SymbolMap.empty } + let del_all_children node = + { node with children = SymbolMap.empty } -(* check if the current node can be accessed by the current connection with rperm permissions *) -let check_perm node connection request = - Perms.check connection request node.perms + (* check if the current node can be accessed by the current connection with rperm permissions *) + let check_perm node connection request = + Perms.check connection request node.perms -(* check if the current node is owned by the current connection *) -let check_owner node connection = - if not (Perms.check_owner connection node.perms) - then begin - Logging.info "store|node" "Permission denied: Domain %d not owner" (get_owner node); - raise Define.Permission_denied; - end + (* check if the current node is owned by the current connection *) + let check_owner node connection = + if not (Perms.check_owner connection node.perms) + then begin + Logging.info "store|node" "Permission denied: Domain %d not owner" (get_owner node); + raise Define.Permission_denied; + end -let rec recurse fct node = fct node; SymbolMap.iter (fun _ -> recurse fct) node.children + let rec recurse fct node = fct node; SymbolMap.iter (fun _ -> recurse fct) node.children -(** [recurse_filter_map f tree] applies [f] on each node in the tree recursively, - possibly removing some nodes. - Note that the nodes removed this way won't generate watch events. -*) -let recurse_filter_map f = - let invalid = -1 in - let is_valid _ node = node.perms.owner <> invalid in - let rec walk node = - (* Map.filter_map is Ocaml 4.11+ only *) - let node = - { node with children = - SymbolMap.map walk node.children |> SymbolMap.filter is_valid } in - match f node with - | Some keep -> keep - | None -> { node with perms = {node.perms with owner = invalid } } - in - walk + (** [recurse_filter_map f tree] applies [f] on each node in the tree recursively, + possibly removing some nodes. + Note that the nodes removed this way won't generate watch events. + *) + let recurse_filter_map f = + let invalid = -1 in + let is_valid _ node = node.perms.owner <> invalid in + let rec walk node = + (* Map.filter_map is Ocaml 4.11+ only *) + let node = + { node with children = + SymbolMap.map walk node.children |> SymbolMap.filter is_valid } in + match f node with + | Some keep -> keep + | None -> { node with perms = {node.perms with owner = invalid } } + in + walk -let unpack node = (Symbol.to_string node.name, node.perms, node.value) + let unpack node = (Symbol.to_string node.name, node.perms, node.value) end module Path = struct -(* represent a path in a store. - * [] -> "/" - * [ "local"; "domain"; "1" ] -> "/local/domain/1" - *) -type t = string list + (* represent a path in a store. + * [] -> "/" + * [ "local"; "domain"; "1" ] -> "/local/domain/1" + *) + type t = string list -let char_is_valid c = - (c >= 'a' && c <= 'z') || - (c >= 'A' && c <= 'Z') || - (c >= '0' && c <= '9') || - c = '_' || c = '-' || c = '@' + let char_is_valid c = + (c >= 'a' && c <= 'z') || + (c >= 'A' && c <= 'Z') || + (c >= '0' && c <= '9') || + c = '_' || c = '-' || c = '@' -let name_is_valid name = - name <> "" && String.fold_left (fun accu c -> accu && char_is_valid c) true name + let name_is_valid name = + name <> "" && String.fold_left (fun accu c -> accu && char_is_valid c) true name -let is_valid path = - List.for_all name_is_valid path + let is_valid path = + List.for_all name_is_valid path -let of_string s = - if s.[0] = '@' - then [s] - else if s = "/" - then [] - else match String.split '/' s with - | "" :: path when is_valid path -> path - | _ -> raise Define.Invalid_path + let of_string s = + if s.[0] = '@' + then [s] + else if s = "/" + then [] + else match String.split '/' s with + | "" :: path when is_valid path -> path + | _ -> raise Define.Invalid_path -let of_path_and_name path name = - match path, name with - | [], "" -> [] - | _ -> path @ [name] + let of_path_and_name path name = + match path, name with + | [], "" -> [] + | _ -> path @ [name] -let create path connection_path = - of_string (Utils.path_validate path connection_path) + let create path connection_path = + of_string (Utils.path_validate path connection_path) -let to_string t = - "/" ^ (String.concat "/" t) + let to_string t = + "/" ^ (String.concat "/" t) -let to_string_list x = x + let to_string_list x = x -let get_parent t = - if t = [] then [] else List.rev (List.tl (List.rev t)) + let get_parent t = + if t = [] then [] else List.rev (List.tl (List.rev t)) -let get_hierarchy path = - Utils.get_hierarchy path + let get_hierarchy path = + Utils.get_hierarchy path -let get_common_prefix p1 p2 = - let rec compare l1 l2 = - match l1, l2 with - | h1 :: tl1, h2 :: tl2 -> - if h1 = h2 then h1 :: (compare tl1 tl2) else [] - | _, [] | [], _ -> - (* if l1 or l2 is empty, we found the equal part already *) - [] - in - compare p1 p2 + let get_common_prefix p1 p2 = + let rec compare l1 l2 = + match l1, l2 with + | h1 :: tl1, h2 :: tl2 -> + if h1 = h2 then h1 :: (compare tl1 tl2) else [] + | _, [] | [], _ -> + (* if l1 or l2 is empty, we found the equal part already *) + [] + in + compare p1 p2 -let rec lookup_modify node path fct = - match path with - | [] -> raise (Define.Invalid_path) - | h :: [] -> fct node h - | h :: l -> - let (n, c) = - if not (Node.exists node h) then - raise (Define.Lookup_Doesnt_exist h) - else - (node, Node.find node h) in - let nc = lookup_modify c l fct in - Node.replace_child n c nc + let rec lookup_modify node path fct = + match path with + | [] -> raise (Define.Invalid_path) + | h :: [] -> fct node h + | h :: l -> + let (n, c) = + if not (Node.exists node h) then + raise (Define.Lookup_Doesnt_exist h) + else + (node, Node.find node h) in + let nc = lookup_modify c l fct in + Node.replace_child n c nc -let apply_modify rnode path fct = - lookup_modify rnode path fct + let apply_modify rnode path fct = + lookup_modify rnode path fct -let rec lookup_get node path = - match path with - | [] -> raise (Define.Invalid_path) - | h :: [] -> - (try - Node.find node h - with Not_found -> - raise Define.Doesnt_exist) - | h :: l -> let cnode = Node.find node h in lookup_get cnode l + let rec lookup_get node path = + match path with + | [] -> raise (Define.Invalid_path) + | h :: [] -> + (try + Node.find node h + with Not_found -> + raise Define.Doesnt_exist) + | h :: l -> let cnode = Node.find node h in lookup_get cnode l -let get_node rnode path = - if path = [] then - Some rnode - else ( - try Some (lookup_get rnode path) with Define.Doesnt_exist -> None - ) + let get_node rnode path = + if path = [] then + Some rnode + else ( + try Some (lookup_get rnode path) with Define.Doesnt_exist -> None + ) -(* get the deepest existing node for this path, return the node and a flag on the existence of the full path *) -let rec get_deepest_existing_node node = function - | [] -> node, true - | h :: t -> - try get_deepest_existing_node (Node.find node h) t - with Not_found -> node, false + (* get the deepest existing node for this path, return the node and a flag on the existence of the full path *) + let rec get_deepest_existing_node node = function + | [] -> node, true + | h :: t -> + try get_deepest_existing_node (Node.find node h) t + with Not_found -> node, false -let set_node rnode path nnode = - if path = [] then - nnode - else - let set_node node name = - try - let ent = Node.find node name in - Node.replace_child node ent nnode - with Not_found -> - Node.add_child node nnode - in - apply_modify rnode path set_node + let set_node rnode path nnode = + if path = [] then + nnode + else + let set_node node name = + try + let ent = Node.find node name in + Node.replace_child node ent nnode + with Not_found -> + Node.add_child node nnode + in + apply_modify rnode path set_node -(* read | ls | getperms use this *) -let rec lookup node path fct = - match path with - | [] -> raise (Define.Invalid_path) - | h :: [] -> fct node h - | h :: l -> let cnode = Node.find node h in lookup cnode l fct + (* read | ls | getperms use this *) + let rec lookup node path fct = + match path with + | [] -> raise (Define.Invalid_path) + | h :: [] -> fct node h + | h :: l -> let cnode = Node.find node h in lookup cnode l fct -let apply rnode path fct = - lookup rnode path fct + let apply rnode path fct = + lookup rnode path fct -let introduce_domain = "@introduceDomain" -let release_domain = "@releaseDomain" -let specials = List.map of_string [ introduce_domain; release_domain ] + let introduce_domain = "@introduceDomain" + let release_domain = "@releaseDomain" + let specials = List.map of_string [ introduce_domain; release_domain ] end (* The Store.t type *) type t = -{ - mutable stat_transaction_coalesce: int; - mutable stat_transaction_abort: int; - mutable root: Node.t; - mutable quota: Quota.t; -} + { + mutable stat_transaction_coalesce: int; + mutable stat_transaction_abort: int; + mutable root: Node.t; + mutable quota: Quota.t; + } let get_root store = store.root let set_root store root = store.root <- root @@ -254,149 +254,149 @@ let set_quota store quota = store.quota <- quota (* modifying functions *) let path_mkdir store perm path = - let do_mkdir node name = - try - let ent = Node.find node name in - Node.check_perm ent perm Perms.WRITE; - raise Define.Already_exist - with Not_found -> - Node.check_perm node perm Perms.WRITE; - Node.add_child node (Node.create name node.Node.perms "") in - if path = [] then - store.root - else - Path.apply_modify store.root path do_mkdir + let do_mkdir node name = + try + let ent = Node.find node name in + Node.check_perm ent perm Perms.WRITE; + raise Define.Already_exist + with Not_found -> + Node.check_perm node perm Perms.WRITE; + Node.add_child node (Node.create name node.Node.perms "") in + if path = [] then + store.root + else + Path.apply_modify store.root path do_mkdir let path_write store perm path value = - let node_created = ref false in - let do_write node name = - try - let ent = Node.find node name in - Node.check_perm ent perm Perms.WRITE; - let nent = Node.set_value ent value in - Node.replace_child node ent nent - with Not_found -> - node_created := true; - Node.check_perm node perm Perms.WRITE; - Node.add_child node (Node.create name node.Node.perms value) in - if path = [] then ( - Node.check_perm store.root perm Perms.WRITE; - Node.set_value store.root value, false - ) else - let root = Path.apply_modify store.root path do_write in - root, !node_created + let node_created = ref false in + let do_write node name = + try + let ent = Node.find node name in + Node.check_perm ent perm Perms.WRITE; + let nent = Node.set_value ent value in + Node.replace_child node ent nent + with Not_found -> + node_created := true; + Node.check_perm node perm Perms.WRITE; + Node.add_child node (Node.create name node.Node.perms value) in + if path = [] then ( + Node.check_perm store.root perm Perms.WRITE; + Node.set_value store.root value, false + ) else + let root = Path.apply_modify store.root path do_write in + root, !node_created let path_rm store perm path = - let do_rm node name = - try - let ent = Node.find node name in - Node.check_perm ent perm Perms.WRITE; - Node.del_childname node name - with Not_found -> - raise Define.Doesnt_exist in - if path = [] then ( - Node.check_perm store.root perm Perms.WRITE; - Node.del_all_children store.root - ) else - Path.apply_modify store.root path do_rm + let do_rm node name = + try + let ent = Node.find node name in + Node.check_perm ent perm Perms.WRITE; + Node.del_childname node name + with Not_found -> + raise Define.Doesnt_exist in + if path = [] then ( + Node.check_perm store.root perm Perms.WRITE; + Node.del_all_children store.root + ) else + Path.apply_modify store.root path do_rm let path_setperms store perm path perms = - if path = [] then ( - Node.check_perm store.root perm Perms.WRITE; - Node.set_perms store.root perms - ) else - let do_setperms node name = - let c = Node.find node name in - Node.check_owner c perm; - Node.check_perm c perm Perms.WRITE; - let nc = Node.set_perms c perms in - Node.replace_child node c nc - in - Path.apply_modify store.root path do_setperms + if path = [] then ( + Node.check_perm store.root perm Perms.WRITE; + Node.set_perms store.root perms + ) else + let do_setperms node name = + let c = Node.find node name in + Node.check_owner c perm; + Node.check_perm c perm Perms.WRITE; + let nc = Node.set_perms c perms in + Node.replace_child node c nc + in + Path.apply_modify store.root path do_setperms (* accessing functions *) let get_node store path = - Path.get_node store.root path + Path.get_node store.root path let get_deepest_existing_node store path = - Path.get_deepest_existing_node store.root path + Path.get_deepest_existing_node store.root path let read store perm path = - let do_read node name = - let ent = Node.find node name in - Node.check_perm ent perm Perms.READ; - ent.Node.value - in - if path = [] then ( - let ent = store.root in - Node.check_perm ent perm Perms.READ; - ent.Node.value - ) else - Path.apply store.root path do_read + let do_read node name = + let ent = Node.find node name in + Node.check_perm ent perm Perms.READ; + ent.Node.value + in + if path = [] then ( + let ent = store.root in + Node.check_perm ent perm Perms.READ; + ent.Node.value + ) else + Path.apply store.root path do_read let ls store perm path = - let children = - if path = [] then ( - Node.check_perm store.root perm Perms.READ; - Node.get_children store.root - ) else - let do_ls node name = - let cnode = Node.find node name in - Node.check_perm cnode perm Perms.READ; - cnode.Node.children in - Path.apply store.root path do_ls in - SymbolMap.fold (fun k _ accu -> Symbol.to_string k :: accu) children [] + let children = + if path = [] then ( + Node.check_perm store.root perm Perms.READ; + Node.get_children store.root + ) else + let do_ls node name = + let cnode = Node.find node name in + Node.check_perm cnode perm Perms.READ; + cnode.Node.children in + Path.apply store.root path do_ls in + SymbolMap.fold (fun k _ accu -> Symbol.to_string k :: accu) children [] let getperms store perm path = - if path = [] then ( - Node.check_perm store.root perm Perms.READ; - Node.get_perms store.root - ) else - let fct n name = - let c = Node.find n name in - Node.check_perm c perm Perms.READ; - c.Node.perms in - Path.apply store.root path fct + if path = [] then ( + Node.check_perm store.root perm Perms.READ; + Node.get_perms store.root + ) else + let fct n name = + let c = Node.find n name in + Node.check_perm c perm Perms.READ; + c.Node.perms in + Path.apply store.root path fct let path_exists store path = - if path = [] then - true - else - try - let check_exist node name = - ignore(Node.find node name); - true in - Path.apply store.root path check_exist - with Not_found -> false + if path = [] then + true + else + try + let check_exist node name = + ignore(Node.find node name); + true in + Path.apply store.root path check_exist + with Not_found -> false (* others utils *) let traversal root_node f = - let rec _traversal path node = - f path node; - let node_path = Path.of_path_and_name path (Symbol.to_string node.Node.name) in - SymbolMap.iter (fun _ -> _traversal node_path) node.Node.children - in - _traversal [] root_node + let rec _traversal path node = + f path node; + let node_path = Path.of_path_and_name path (Symbol.to_string node.Node.name) in + SymbolMap.iter (fun _ -> _traversal node_path) node.Node.children + in + _traversal [] root_node let dump_store_buf root_node = - let buf = Buffer.create 8192 in - let dump_node path node = - let pathstr = String.concat "/" path in - Printf.bprintf buf "%s/%s{%s}" pathstr (Symbol.to_string node.Node.name) - (String.escaped (Perms.Node.to_string (Node.get_perms node))); - if String.length node.Node.value > 0 then - Printf.bprintf buf " = %s\n" (String.escaped node.Node.value) - else - Printf.bprintf buf "\n"; - in - traversal root_node dump_node; - buf + let buf = Buffer.create 8192 in + let dump_node path node = + let pathstr = String.concat "/" path in + Printf.bprintf buf "%s/%s{%s}" pathstr (Symbol.to_string node.Node.name) + (String.escaped (Perms.Node.to_string (Node.get_perms node))); + if String.length node.Node.value > 0 then + Printf.bprintf buf " = %s\n" (String.escaped node.Node.value) + else + Printf.bprintf buf "\n"; + in + traversal root_node dump_node; + buf let dump_store chan root_node = - let buf = dump_store_buf root_node in - output_string chan (Buffer.contents buf); - Buffer.reset buf + let buf = dump_store_buf root_node in + output_string chan (Buffer.contents buf); + Buffer.reset buf let dump_fct store f = traversal store.root f let dump store out_chan = dump_store out_chan store.root @@ -406,109 +406,109 @@ let dump_buffer store = dump_store_buf store.root (* modifying functions with quota udpate *) let set_node store path node orig_quota mod_quota = - let root = Path.set_node store.root path node in - store.root <- root; - Quota.merge orig_quota mod_quota store.quota + let root = Path.set_node store.root path node in + store.root <- root; + Quota.merge orig_quota mod_quota store.quota let write store perm path value = - let node, existing = get_deepest_existing_node store path in - let owner = Node.get_owner node in - if existing || (Perms.Connection.is_dom0 perm) then - (* Only check the string length limit *) - Quota.check store.quota (-1) (String.length value) - else - (* Check the domain entries limit too *) - Quota.check store.quota owner (String.length value); - let root, node_created = path_write store perm path value in - store.root <- root; - if node_created - then Quota.add_entry store.quota owner + let node, existing = get_deepest_existing_node store path in + let owner = Node.get_owner node in + if existing || (Perms.Connection.is_dom0 perm) then + (* Only check the string length limit *) + Quota.check store.quota (-1) (String.length value) + else + (* Check the domain entries limit too *) + Quota.check store.quota owner (String.length value); + let root, node_created = path_write store perm path value in + store.root <- root; + if node_created + then Quota.add_entry store.quota owner let mkdir store perm path = - let node, existing = get_deepest_existing_node store path in - let owner = Node.get_owner node in - (* It's upt to the mkdir logic to decide what to do with existing path *) - if not (existing || (Perms.Connection.is_dom0 perm)) then Quota.check store.quota owner 0; - store.root <- path_mkdir store perm path; - if not existing then - Quota.add_entry store.quota owner + let node, existing = get_deepest_existing_node store path in + let owner = Node.get_owner node in + (* It's upt to the mkdir logic to decide what to do with existing path *) + if not (existing || (Perms.Connection.is_dom0 perm)) then Quota.check store.quota owner 0; + store.root <- path_mkdir store perm path; + if not existing then + Quota.add_entry store.quota owner let rm store perm path = - let rmed_node = Path.get_node store.root path in - match rmed_node with - | None -> raise Define.Doesnt_exist - | Some rmed_node -> - store.root <- path_rm store perm path; - Node.recurse (fun node -> Quota.del_entry store.quota (Node.get_owner node)) rmed_node + let rmed_node = Path.get_node store.root path in + match rmed_node with + | None -> raise Define.Doesnt_exist + | Some rmed_node -> + store.root <- path_rm store perm path; + Node.recurse (fun node -> Quota.del_entry store.quota (Node.get_owner node)) rmed_node let setperms store perm path nperms = - match Path.get_node store.root path with - | None -> raise Define.Doesnt_exist - | Some node -> - let old_owner = Node.get_owner node in - let new_owner = Perms.Node.get_owner nperms in - if not ((old_owner = new_owner) || (Perms.Connection.is_dom0 perm)) then - raise Define.Permission_denied; - store.root <- path_setperms store perm path nperms; - Quota.del_entry store.quota old_owner; - Quota.add_entry store.quota new_owner + match Path.get_node store.root path with + | None -> raise Define.Doesnt_exist + | Some node -> + let old_owner = Node.get_owner node in + let new_owner = Perms.Node.get_owner nperms in + if not ((old_owner = new_owner) || (Perms.Connection.is_dom0 perm)) then + raise Define.Permission_denied; + store.root <- path_setperms store perm path nperms; + Quota.del_entry store.quota old_owner; + Quota.add_entry store.quota new_owner let reset_permissions store domid = - Logging.info "store|node" "Cleaning up xenstore ACLs for domid %d" domid; - store.root <- Node.recurse_filter_map (fun node -> - match Perms.Node.remove_domid ~domid node.perms with - | None -> None - | Some perms -> - if perms <> node.perms then - Logging.debug "store|node" "Changed permissions for node %s" (Node.get_name node); - Some { node with perms } - ) store.root + Logging.info "store|node" "Cleaning up xenstore ACLs for domid %d" domid; + store.root <- Node.recurse_filter_map (fun node -> + match Perms.Node.remove_domid ~domid node.perms with + | None -> None + | Some perms -> + if perms <> node.perms then + Logging.debug "store|node" "Changed permissions for node %s" (Node.get_name node); + Some { node with perms } + ) store.root type ops = { - store: t; - write: Path.t -> string -> unit; - mkdir: Path.t -> unit; - rm: Path.t -> unit; - setperms: Path.t -> Perms.Node.t -> unit; - ls: Path.t -> string list; - read: Path.t -> string; - getperms: Path.t -> Perms.Node.t; - path_exists: Path.t -> bool; + store: t; + write: Path.t -> string -> unit; + mkdir: Path.t -> unit; + rm: Path.t -> unit; + setperms: Path.t -> Perms.Node.t -> unit; + ls: Path.t -> string list; + read: Path.t -> string; + getperms: Path.t -> Perms.Node.t; + path_exists: Path.t -> bool; } let get_ops store perms = { - store = store; - write = write store perms; - mkdir = mkdir store perms; - rm = rm store perms; - setperms = setperms store perms; - ls = ls store perms; - read = read store perms; - getperms = getperms store perms; - path_exists = path_exists store; + store = store; + write = write store perms; + mkdir = mkdir store perms; + rm = rm store perms; + setperms = setperms store perms; + ls = ls store perms; + read = read store perms; + getperms = getperms store perms; + path_exists = path_exists store; } let create () = { - stat_transaction_coalesce = 0; - stat_transaction_abort = 0; - root = Node.create "" Perms.Node.default0 ""; - quota = Quota.create (); + stat_transaction_coalesce = 0; + stat_transaction_abort = 0; + root = Node.create "" Perms.Node.default0 ""; + quota = Quota.create (); } let copy store = { - stat_transaction_coalesce = store.stat_transaction_coalesce; - stat_transaction_abort = store.stat_transaction_abort; - root = store.root; - quota = Quota.copy store.quota; + stat_transaction_coalesce = store.stat_transaction_coalesce; + stat_transaction_abort = store.stat_transaction_abort; + root = store.root; + quota = Quota.copy store.quota; } let incr_transaction_coalesce store = - store.stat_transaction_coalesce <- store.stat_transaction_coalesce + 1 + store.stat_transaction_coalesce <- store.stat_transaction_coalesce + 1 let incr_transaction_abort store = - store.stat_transaction_abort <- store.stat_transaction_abort + 1 + store.stat_transaction_abort <- store.stat_transaction_abort + 1 let stats store = - let nb_nodes = ref 0 in - traversal store.root (fun _path _node -> - incr nb_nodes - ); - !nb_nodes, store.stat_transaction_abort, store.stat_transaction_coalesce + let nb_nodes = ref 0 in + traversal store.root (fun _path _node -> + incr nb_nodes + ); + !nb_nodes, store.stat_transaction_abort, store.stat_transaction_coalesce diff --git a/tools/ocaml/xenstored/symbol.ml b/tools/ocaml/xenstored/symbol.ml index 72a84ebf80..02298a04ca 100644 --- a/tools/ocaml/xenstored/symbol.ml +++ b/tools/ocaml/xenstored/symbol.ml @@ -18,7 +18,7 @@ module WeakTable = Weak.Make(struct type t = string let equal (x:string) (y:string) = (x = y) let hash = Hashtbl.hash -end) + end) type t = string diff --git a/tools/ocaml/xenstored/syslog.ml b/tools/ocaml/xenstored/syslog.ml index a95da2fd7b..cc5816a868 100644 --- a/tools/ocaml/xenstored/syslog.ml +++ b/tools/ocaml/xenstored/syslog.ml @@ -15,32 +15,32 @@ type level = Emerg | Alert | Crit | Err | Warning | Notice | Info | Debug type facility = Auth | Authpriv | Cron | Daemon | Ftp | Kern | Local0 | Local1 | Local2 | Local3 - | Local4 | Local5 | Local6 | Local7 - | Lpr | Mail | News | Syslog | User | Uucp + | Local4 | Local5 | Local6 | Local7 + | Lpr | Mail | News | Syslog | User | Uucp external log : facility -> level -> string -> unit = "stub_syslog" exception Unknown_facility of string let facility_of_string s = - match s with - |"auth"->Auth - |"authpriv"->Authpriv - |"cron"->Cron - |"daemon"->Daemon - |"ftp"->Ftp - |"kern"->Kern - |"local0"->Local0 - |"local1"->Local1 - |"local2"->Local2 - |"local3"->Local3 - |"local4"->Local4 - |"local5"->Local5 - |"local6"->Local6 - |"local7"->Local7 - |"lpr"->Lpr - |"mail"->Mail - |"news"->News - |"syslog"->Syslog - |"user"->User - |"uucp"->Uucp - |_-> raise (Unknown_facility s) + match s with + |"auth"->Auth + |"authpriv"->Authpriv + |"cron"->Cron + |"daemon"->Daemon + |"ftp"->Ftp + |"kern"->Kern + |"local0"->Local0 + |"local1"->Local1 + |"local2"->Local2 + |"local3"->Local3 + |"local4"->Local4 + |"local5"->Local5 + |"local6"->Local6 + |"local7"->Local7 + |"lpr"->Lpr + |"mail"->Mail + |"news"->News + |"syslog"->Syslog + |"user"->User + |"uucp"->Uucp + |_-> raise (Unknown_facility s) diff --git a/tools/ocaml/xenstored/syslog_stubs.c b/tools/ocaml/xenstored/syslog_stubs.c index 875d48ad57..4e5e49b557 100644 --- a/tools/ocaml/xenstored/syslog_stubs.c +++ b/tools/ocaml/xenstored/syslog_stubs.c @@ -21,28 +21,28 @@ #include static int __syslog_level_table[] = { - LOG_EMERG, LOG_ALERT, LOG_CRIT, LOG_ERR, LOG_WARNING, - LOG_NOTICE, LOG_INFO, LOG_DEBUG + LOG_EMERG, LOG_ALERT, LOG_CRIT, LOG_ERR, LOG_WARNING, + LOG_NOTICE, LOG_INFO, LOG_DEBUG }; static int __syslog_facility_table[] = { - LOG_AUTH, LOG_AUTHPRIV, LOG_CRON, LOG_DAEMON, LOG_FTP, LOG_KERN, - LOG_LOCAL0, LOG_LOCAL1, LOG_LOCAL2, LOG_LOCAL3, - LOG_LOCAL4, LOG_LOCAL5, LOG_LOCAL6, LOG_LOCAL7, - LOG_LPR | LOG_MAIL | LOG_NEWS | LOG_SYSLOG | LOG_USER | LOG_UUCP + LOG_AUTH, LOG_AUTHPRIV, LOG_CRON, LOG_DAEMON, LOG_FTP, LOG_KERN, + LOG_LOCAL0, LOG_LOCAL1, LOG_LOCAL2, LOG_LOCAL3, + LOG_LOCAL4, LOG_LOCAL5, LOG_LOCAL6, LOG_LOCAL7, + LOG_LPR | LOG_MAIL | LOG_NEWS | LOG_SYSLOG | LOG_USER | LOG_UUCP }; value stub_syslog(value facility, value level, value msg) { - CAMLparam3(facility, level, msg); - const char *c_msg = strdup(String_val(msg)); - int c_facility = __syslog_facility_table[Int_val(facility)] - | __syslog_level_table[Int_val(level)]; + CAMLparam3(facility, level, msg); + const char *c_msg = strdup(String_val(msg)); + int c_facility = __syslog_facility_table[Int_val(facility)] + | __syslog_level_table[Int_val(level)]; - caml_enter_blocking_section(); - syslog(c_facility, "%s", c_msg); - caml_leave_blocking_section(); + caml_enter_blocking_section(); + syslog(c_facility, "%s", c_msg); + caml_leave_blocking_section(); - free((void*)c_msg); - CAMLreturn(Val_unit); + free((void*)c_msg); + CAMLreturn(Val_unit); } diff --git a/tools/ocaml/xenstored/systemd_stubs.c b/tools/ocaml/xenstored/systemd_stubs.c index f4c875075a..f36f7300cf 100644 --- a/tools/ocaml/xenstored/systemd_stubs.c +++ b/tools/ocaml/xenstored/systemd_stubs.c @@ -29,19 +29,19 @@ CAMLprim value ocaml_sd_notify_ready(value ignore) { - CAMLparam1(ignore); + CAMLparam1(ignore); - sd_notify(1, "READY=1"); + sd_notify(1, "READY=1"); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } #else CAMLprim value ocaml_sd_notify_ready(value ignore) { - CAMLparam1(ignore); + CAMLparam1(ignore); - CAMLreturn(Val_unit); + CAMLreturn(Val_unit); } #endif diff --git a/tools/ocaml/xenstored/transaction.ml b/tools/ocaml/xenstored/transaction.ml index 294143e233..9ce0e61e03 100644 --- a/tools/ocaml/xenstored/transaction.ml +++ b/tools/ocaml/xenstored/transaction.ml @@ -23,71 +23,71 @@ let test_eagain = ref false let do_coalesce = ref true let check_parents_perms_identical root1 root2 path = - let hierarch = Store.Path.get_hierarchy path in - let permdiff = List.fold_left (fun acc path -> - let n1 = Store.Path.get_node root1 path - and n2 = Store.Path.get_node root2 path in - match n1, n2 with - | Some n1, Some n2 -> - not (Perms.equiv (Store.Node.get_perms n1) (Store.Node.get_perms n2)) || acc - | _ -> - true || acc - ) false hierarch in - (not permdiff) + let hierarch = Store.Path.get_hierarchy path in + let permdiff = List.fold_left (fun acc path -> + let n1 = Store.Path.get_node root1 path + and n2 = Store.Path.get_node root2 path in + match n1, n2 with + | Some n1, Some n2 -> + not (Perms.equiv (Store.Node.get_perms n1) (Store.Node.get_perms n2)) || acc + | _ -> + true || acc + ) false hierarch in + (not permdiff) let get_lowest path1 path2 = - match path2 with - | None -> Some path1 - | Some path2 -> Some (Store.Path.get_common_prefix path1 path2) + match path2 with + | None -> Some path1 + | Some path2 -> Some (Store.Path.get_common_prefix path1 path2) let test_coalesce oldroot currentroot optpath = - match optpath with - | None -> true - | Some path -> - let oldnode = Store.Path.get_node oldroot path - and currentnode = Store.Path.get_node currentroot path in + match optpath with + | None -> true + | Some path -> + let oldnode = Store.Path.get_node oldroot path + and currentnode = Store.Path.get_node currentroot path in - match oldnode, currentnode with - | (Some oldnode), (Some currentnode) -> - if oldnode == currentnode then ( - check_parents_perms_identical oldroot currentroot path - ) else ( - false - ) - | None, None -> ( - (* ok then it doesn't exists in the old version and the current version, - just sneak it in as a child of the parent node if it exists, or else fail *) - let pnode = Store.Path.get_node currentroot (Store.Path.get_parent path) in - match pnode with - | None -> false (* ok it doesn't exists, just bail out. *) - | Some _ -> true - ) - | _ -> - false + match oldnode, currentnode with + | (Some oldnode), (Some currentnode) -> + if oldnode == currentnode then ( + check_parents_perms_identical oldroot currentroot path + ) else ( + false + ) + | None, None -> ( + (* ok then it doesn't exists in the old version and the current version, + just sneak it in as a child of the parent node if it exists, or else fail *) + let pnode = Store.Path.get_node currentroot (Store.Path.get_parent path) in + match pnode with + | None -> false (* ok it doesn't exists, just bail out. *) + | Some _ -> true + ) + | _ -> + false let can_coalesce oldroot currentroot path = - if !do_coalesce then - try test_coalesce oldroot currentroot path with _ -> false - else - false + if !do_coalesce then + try test_coalesce oldroot currentroot path with _ -> false + else + false type ty = No | Full of ( - int * (* Transaction id *) - Store.t * (* Original store *) - Store.t (* A pointer to the canonical store: its root changes on each transaction-commit *) -) + int * (* Transaction id *) + Store.t * (* Original store *) + Store.t (* A pointer to the canonical store: its root changes on each transaction-commit *) + ) type t = { - ty: ty; - start_count: int64; - store: Store.t; (* This is the store that we change in write operations. *) - quota: Quota.t; - oldroot: Store.Node.t; - mutable paths: (Xenbus.Xb.Op.operation * Store.Path.t) list; - mutable operations: (Packet.request * Packet.response) list; - mutable quota_reached: bool; - mutable read_lowpath: Store.Path.t option; - mutable write_lowpath: Store.Path.t option; + ty: ty; + start_count: int64; + store: Store.t; (* This is the store that we change in write operations. *) + quota: Quota.t; + oldroot: Store.Node.t; + mutable paths: (Xenbus.Xb.Op.operation * Store.Path.t) list; + mutable operations: (Packet.request * Packet.response) list; + mutable quota_reached: bool; + mutable read_lowpath: Store.Path.t option; + mutable write_lowpath: Store.Path.t option; } let get_id t = match t.ty with No -> none | Full (id, _, _) -> id @@ -95,48 +95,48 @@ let counter = ref 0L let failed_commits = ref 0L let failed_commits_no_culprit = ref 0L let reset_conflict_stats () = - failed_commits := 0L; - failed_commits_no_culprit := 0L + failed_commits := 0L; + failed_commits_no_culprit := 0L (* Scope for optimisation: different data-structure and functions to search/filter it *) let short_running_txns = ref [] let oldest_short_running_transaction () = - let rec last = function - | [] -> None - | [x] -> Some x - | _ :: xs -> last xs - in last !short_running_txns + let rec last = function + | [] -> None + | [x] -> Some x + | _ :: xs -> last xs + in last !short_running_txns let trim_short_running_transactions txn = - let cutoff = Unix.gettimeofday () -. !Define.conflict_max_history_seconds in - let keep = match txn with - | None -> (function (start_time, _) -> start_time >= cutoff) - | Some t -> (function (start_time, tx) -> start_time >= cutoff && tx != t) - in - short_running_txns := List.filter - keep - !short_running_txns + let cutoff = Unix.gettimeofday () -. !Define.conflict_max_history_seconds in + let keep = match txn with + | None -> (function (start_time, _) -> start_time >= cutoff) + | Some t -> (function (start_time, tx) -> start_time >= cutoff && tx != t) + in + short_running_txns := List.filter + keep + !short_running_txns let make ?(internal=false) id store = - let ty = if id = none then No else Full(id, Store.copy store, store) in - let txn = { - ty = ty; - start_count = !counter; - store = if id = none then store else Store.copy store; - quota = Quota.copy store.Store.quota; - oldroot = Store.get_root store; - paths = []; - operations = []; - quota_reached = false; - read_lowpath = None; - write_lowpath = None; - } in - if id <> none && not internal then ( - let now = Unix.gettimeofday () in - short_running_txns := (now, txn) :: !short_running_txns - ); - txn + let ty = if id = none then No else Full(id, Store.copy store, store) in + let txn = { + ty = ty; + start_count = !counter; + store = if id = none then store else Store.copy store; + quota = Quota.copy store.Store.quota; + oldroot = Store.get_root store; + paths = []; + operations = []; + quota_reached = false; + read_lowpath = None; + write_lowpath = None; + } in + if id <> none && not internal then ( + let now = Unix.gettimeofday () in + short_running_txns := (now, txn) :: !short_running_txns + ); + txn let get_store t = t.store let get_paths t = t.paths @@ -148,115 +148,115 @@ let add_wop t ty path = t.paths <- (ty, path) :: t.paths let get_operations t = List.rev t.operations let check_quota_exn ~perm t = - if !Define.maxrequests >= 0 - && not (Perms.Connection.is_dom0 perm) - && (t.quota_reached || List.length t.operations >= !Define.maxrequests) - then begin - t.quota_reached <- true; - raise Quota.Limit_reached; - end + if !Define.maxrequests >= 0 + && not (Perms.Connection.is_dom0 perm) + && (t.quota_reached || List.length t.operations >= !Define.maxrequests) + then begin + t.quota_reached <- true; + raise Quota.Limit_reached; + end let add_operation t request response = - t.operations <- (request, response) :: t.operations + t.operations <- (request, response) :: t.operations let set_read_lowpath t path = t.read_lowpath <- get_lowest path t.read_lowpath let set_write_lowpath t path = t.write_lowpath <- get_lowest path t.write_lowpath let path_exists t path = Store.path_exists t.store path let write t perm path value = - let path_exists = path_exists t path in - Store.write t.store perm path value; - if path_exists - then set_write_lowpath t path - else set_write_lowpath t (Store.Path.get_parent path); - add_wop t Xenbus.Xb.Op.Write path + let path_exists = path_exists t path in + Store.write t.store perm path value; + if path_exists + then set_write_lowpath t path + else set_write_lowpath t (Store.Path.get_parent path); + add_wop t Xenbus.Xb.Op.Write path let mkdir ?(with_watch=true) t perm path = - Store.mkdir t.store perm path; - set_write_lowpath t (Store.Path.get_parent path); - if with_watch then - add_wop t Xenbus.Xb.Op.Mkdir path + Store.mkdir t.store perm path; + set_write_lowpath t (Store.Path.get_parent path); + if with_watch then + add_wop t Xenbus.Xb.Op.Mkdir path let setperms t perm path perms = - Store.setperms t.store perm path perms; - set_write_lowpath t path; - add_wop t Xenbus.Xb.Op.Setperms path + Store.setperms t.store perm path perms; + set_write_lowpath t path; + add_wop t Xenbus.Xb.Op.Setperms path let rm t perm path = - Store.rm t.store perm path; - set_write_lowpath t (Store.Path.get_parent path); - add_wop t Xenbus.Xb.Op.Rm path + Store.rm t.store perm path; + set_write_lowpath t (Store.Path.get_parent path); + add_wop t Xenbus.Xb.Op.Rm path let ls t perm path = - let r = Store.ls t.store perm path in - set_read_lowpath t path; - r + let r = Store.ls t.store perm path in + set_read_lowpath t path; + r let read t perm path = - let r = Store.read t.store perm path in - set_read_lowpath t path; - r + let r = Store.read t.store perm path in + set_read_lowpath t path; + r let getperms t perm path = - let r = Store.getperms t.store perm path in - set_read_lowpath t path; - r + let r = Store.getperms t.store perm path in + set_read_lowpath t path; + r let commit ~con t = - let has_write_ops = List.length t.paths > 0 in - let has_coalesced = ref false in - let has_commited = - match t.ty with - | No -> true - | Full (_id, oldstore, cstore) -> (* "cstore" meaning current canonical store *) - let commit_partial oldroot cstore store = - (* get the lowest path of the query and verify that it hasn't - been modified by others transactions. *) - if can_coalesce oldroot (Store.get_root cstore) t.read_lowpath - && can_coalesce oldroot (Store.get_root cstore) t.write_lowpath then ( - maybe (fun p -> - let n = Store.get_node store p in + let has_write_ops = List.length t.paths > 0 in + let has_coalesced = ref false in + let has_commited = + match t.ty with + | No -> true + | Full (_id, oldstore, cstore) -> (* "cstore" meaning current canonical store *) + let commit_partial oldroot cstore store = + (* get the lowest path of the query and verify that it hasn't + been modified by others transactions. *) + if can_coalesce oldroot (Store.get_root cstore) t.read_lowpath + && can_coalesce oldroot (Store.get_root cstore) t.write_lowpath then ( + maybe (fun p -> + let n = Store.get_node store p in - (* it has to be in the store, otherwise it means bugs - in the lowpath registration. we don't need to handle none. *) - maybe (fun n -> Store.set_node cstore p n t.quota store.Store.quota) n; - Logging.write_coalesce ~tid:(get_id t) ~con (Store.Path.to_string p); - ) t.write_lowpath; - maybe (fun p -> - Logging.read_coalesce ~tid:(get_id t) ~con (Store.Path.to_string p) - ) t.read_lowpath; - has_coalesced := true; - Store.incr_transaction_coalesce cstore; - true - ) else ( - (* cannot do anything simple, just discard the queries, - and the client need to redo it later *) - Store.incr_transaction_abort cstore; - false - ) - in - let try_commit oldroot cstore store = - if oldroot == Store.get_root cstore then ( - (* move the new root to the current store, if the oldroot - has not been modified *) - if has_write_ops then ( - Store.set_root cstore (Store.get_root store); - Store.set_quota cstore (Store.get_quota store) - ); - true - ) else - (* we try a partial commit if possible *) - commit_partial oldroot cstore store - in - if !test_eagain && Random.int 3 = 0 then - false - else - try_commit (Store.get_root oldstore) cstore t.store - in - if has_commited && has_write_ops then - Disk.write t.store; - if not has_commited - then Logging.conflict ~tid:(get_id t) ~con - else if not !has_coalesced - then Logging.commit ~tid:(get_id t) ~con; - has_commited + (* it has to be in the store, otherwise it means bugs + in the lowpath registration. we don't need to handle none. *) + maybe (fun n -> Store.set_node cstore p n t.quota store.Store.quota) n; + Logging.write_coalesce ~tid:(get_id t) ~con (Store.Path.to_string p); + ) t.write_lowpath; + maybe (fun p -> + Logging.read_coalesce ~tid:(get_id t) ~con (Store.Path.to_string p) + ) t.read_lowpath; + has_coalesced := true; + Store.incr_transaction_coalesce cstore; + true + ) else ( + (* cannot do anything simple, just discard the queries, + and the client need to redo it later *) + Store.incr_transaction_abort cstore; + false + ) + in + let try_commit oldroot cstore store = + if oldroot == Store.get_root cstore then ( + (* move the new root to the current store, if the oldroot + has not been modified *) + if has_write_ops then ( + Store.set_root cstore (Store.get_root store); + Store.set_quota cstore (Store.get_quota store) + ); + true + ) else + (* we try a partial commit if possible *) + commit_partial oldroot cstore store + in + if !test_eagain && Random.int 3 = 0 then + false + else + try_commit (Store.get_root oldstore) cstore t.store + in + if has_commited && has_write_ops then + Disk.write t.store; + if not has_commited + then Logging.conflict ~tid:(get_id t) ~con + else if not !has_coalesced + then Logging.commit ~tid:(get_id t) ~con; + has_commited diff --git a/tools/ocaml/xenstored/trie.ml b/tools/ocaml/xenstored/trie.ml index ca38b26632..bef97cdbdb 100644 --- a/tools/ocaml/xenstored/trie.ml +++ b/tools/ocaml/xenstored/trie.ml @@ -19,159 +19,159 @@ module StringMap = Map.Make(String) module Node = struct - type 'a t = { - key: string; - value: 'a option; - children: 'a t StringMap.t; - } + type 'a t = { + key: string; + value: 'a option; + children: 'a t StringMap.t; + } - let _create key value = { - key = key; - value = Some value; - children = StringMap.empty; - } + let _create key value = { + key = key; + value = Some value; + children = StringMap.empty; + } - let empty key = { - key = key; - value = None; - children = StringMap.empty; - } + let empty key = { + key = key; + value = None; + children = StringMap.empty; + } - let _get_key node = node.key - let get_value node = - match node.value with - | None -> raise Not_found - | Some value -> value + let _get_key node = node.key + let get_value node = + match node.value with + | None -> raise Not_found + | Some value -> value - let _get_children node = node.children + let _get_children node = node.children - let set_value node value = - { node with value = Some value } - let set_children node children = - { node with children = children } + let set_value node value = + { node with value = Some value } + let set_children node children = + { node with children = children } - let _add_child node child = - { node with children = StringMap.add child.key child node.children } + let _add_child node child = + { node with children = StringMap.add child.key child node.children } end type 'a t = 'a Node.t StringMap.t let mem_node nodes key = - StringMap.mem key nodes + StringMap.mem key nodes let find_node nodes key = - StringMap.find key nodes + StringMap.find key nodes let replace_node nodes key node = - StringMap.update key (function None -> None | Some _ -> Some node) nodes + StringMap.update key (function None -> None | Some _ -> Some node) nodes let remove_node nodes key = - StringMap.update key (function None -> raise Not_found | Some _ -> None) nodes + StringMap.update key (function None -> raise Not_found | Some _ -> None) nodes let create () = StringMap.empty let rec iter f tree = - let aux key node = - f key node.Node.value; - iter f node.Node.children - in - StringMap.iter aux tree + let aux key node = + f key node.Node.value; + iter f node.Node.children + in + StringMap.iter aux tree let rec map f tree = - let aux node = - let value = - match node.Node.value with - | None -> None - | Some value -> f value - in - { node with Node.value = value; Node.children = map f node.Node.children } - in - tree |> StringMap.map aux - |> StringMap.filter (fun _ n -> n.Node.value <> None || not (StringMap.is_empty n.Node.children)) + let aux node = + let value = + match node.Node.value with + | None -> None + | Some value -> f value + in + { node with Node.value = value; Node.children = map f node.Node.children } + in + tree |> StringMap.map aux + |> StringMap.filter (fun _ n -> n.Node.value <> None || not (StringMap.is_empty n.Node.children)) let rec fold f tree acc = - let aux key node accu = - fold f node.Node.children (f key node.Node.value accu) - in - StringMap.fold aux tree acc + let aux key node accu = + fold f node.Node.children (f key node.Node.value accu) + in + StringMap.fold aux tree acc (* return a sub-trie *) let rec sub_node tree = function - | [] -> raise Not_found - | h::t -> - if mem_node tree h - then begin - let node = find_node tree h in - if t = [] - then node - else sub_node node.Node.children t - end else - raise Not_found + | [] -> raise Not_found + | h::t -> + if mem_node tree h + then begin + let node = find_node tree h in + if t = [] + then node + else sub_node node.Node.children t + end else + raise Not_found let sub tree path = - try (sub_node tree path).Node.children - with Not_found -> StringMap.empty + try (sub_node tree path).Node.children + with Not_found -> StringMap.empty let find tree path = - Node.get_value (sub_node tree path) + Node.get_value (sub_node tree path) (* return false if the node doesn't exists or if it is not associated to any value *) let rec mem tree = function - | [] -> false - | h::t -> - mem_node tree h - && (let node = find_node tree h in - if t = [] - then node.Node.value <> None - else mem node.Node.children t) + | [] -> false + | h::t -> + mem_node tree h + && (let node = find_node tree h in + if t = [] + then node.Node.value <> None + else mem node.Node.children t) (* Iterate over the longest valid prefix *) let rec iter_path f tree = function - | [] -> () - | h::l -> - if mem_node tree h - then begin - let node = find_node tree h in - f node.Node.key node.Node.value; - iter_path f node.Node.children l - end + | [] -> () + | h::l -> + if mem_node tree h + then begin + let node = find_node tree h in + f node.Node.key node.Node.value; + iter_path f node.Node.children l + end let rec set_node node path value = - if path = [] - then Node.set_value node value - else begin - let children = set node.Node.children path value in - Node.set_children node children - end + if path = [] + then Node.set_value node value + else begin + let children = set node.Node.children path value in + Node.set_children node children + end and set tree path value = - match path with - | [] -> raise Not_found - | h::t -> - if mem_node tree h - then begin - let node = find_node tree h in - replace_node tree h (set_node node t value) - end else begin - let node = Node.empty h in - StringMap.add node.Node.key (set_node node t value) tree - end + match path with + | [] -> raise Not_found + | h::t -> + if mem_node tree h + then begin + let node = find_node tree h in + replace_node tree h (set_node node t value) + end else begin + let node = Node.empty h in + StringMap.add node.Node.key (set_node node t value) tree + end let rec unset tree = function - | [] -> tree - | h::t -> - if mem_node tree h - then begin - let node = find_node tree h in - let children = unset node.Node.children t in - let new_node = - if t = [] - then Node.set_children (Node.empty h) children - else Node.set_children node children - in - if StringMap.is_empty children && new_node.Node.value = None - then remove_node tree h - else replace_node tree h new_node - end else - raise Not_found + | [] -> tree + | h::t -> + if mem_node tree h + then begin + let node = find_node tree h in + let children = unset node.Node.children t in + let new_node = + if t = [] + then Node.set_children (Node.empty h) children + else Node.set_children node children + in + if StringMap.is_empty children && new_node.Node.value = None + then remove_node tree h + else replace_node tree h new_node + end else + raise Not_found diff --git a/tools/ocaml/xenstored/trie.mli b/tools/ocaml/xenstored/trie.mli index 27785154f5..9e7afff788 100644 --- a/tools/ocaml/xenstored/trie.mli +++ b/tools/ocaml/xenstored/trie.mli @@ -17,44 +17,44 @@ type 'a t (** The type of tries. ['a] the type of values. - Internally, a trie is represented as a labeled tree, where node contains values - of type [string * 'a option]. *) + Internally, a trie is represented as a labeled tree, where node contains values + of type [string * 'a option]. *) val create : unit -> 'a t (** Creates an empty trie. *) val mem : 'a t -> string list -> bool (** [mem t k] returns true if a value is associated with the key [k] in the trie [t]. - Otherwise, it returns false. *) + Otherwise, it returns false. *) val find : 'a t -> string list -> 'a (** [find t k] returns the value associated with the key [k] in the trie [t]. - Returns [Not_found] if no values are associated with [k] in [t]. *) + Returns [Not_found] if no values are associated with [k] in [t]. *) val set : 'a t -> string list -> 'a -> 'a t (** [set t k v] associates the value [v] with the key [k] in the trie [t]. *) val unset : 'a t -> string list -> 'a t (** [unset k v] removes the association of value [v] with the key [k] in the trie [t]. - Moreover, it automatically clean the trie, ie. it removes recursively - every nodes of [t] containing no values and having no chil. *) + Moreover, it automatically clean the trie, ie. it removes recursively + every nodes of [t] containing no values and having no chil. *) val iter : (string -> 'a option -> unit) -> 'a t -> unit (** [iter f t] applies the function [f] to every node of the trie [t]. - As nodes of the trie [t] do not necessary contains a value, the second argument of - [f] is an option type. *) + As nodes of the trie [t] do not necessary contains a value, the second argument of + [f] is an option type. *) val iter_path : (string -> 'a option -> unit) -> 'a t -> string list -> unit (** [iter_path f t p] iterates [f] over nodes associated with the path [p] in the trie [t]. - If [p] is not a valid path of [t], it iterates on the longest valid prefix of [p]. *) + If [p] is not a valid path of [t], it iterates on the longest valid prefix of [p]. *) val fold : (string -> 'a option -> 'c -> 'c) -> 'a t -> 'c -> 'c (** [fold f t x] fold [f] over every nodes of [t], with [x] as initial value. *) val map : ('a -> 'b option) -> 'a t -> 'b t (** [map f t] maps [f] over every values stored in [t]. The return value of [f] is of type 'c option - as one may wants to remove value associated to a key. This function is not tail-recursive. *) + as one may wants to remove value associated to a key. This function is not tail-recursive. *) val sub : 'a t -> string list -> 'a t (** [sub t p] returns the sub-trie associated with the path [p] in the trie [t]. - If [p] is not a valid path of [t], it returns an empty trie. *) + If [p] is not a valid path of [t], it returns an empty trie. *) diff --git a/tools/ocaml/xenstored/utils.ml b/tools/ocaml/xenstored/utils.ml index dd03b2b5bc..eac56ec5d6 100644 --- a/tools/ocaml/xenstored/utils.ml +++ b/tools/ocaml/xenstored/utils.ml @@ -19,111 +19,111 @@ open Stdext (* lists utils *) let filter_out filter l = - List.filter (fun x -> not (List.mem x filter)) l + List.filter (fun x -> not (List.mem x filter)) l let filter_in filter l = - List.filter (fun x -> List.mem x filter) l + List.filter (fun x -> List.mem x filter) l let list_remove element l = - List.filter (fun e -> e != element) l + List.filter (fun e -> e != element) l let list_tl_multi n l = - let rec do_tl i x = - if i = 0 then x else do_tl (i - 1) (List.tl x) - in - do_tl n l + let rec do_tl i x = + if i = 0 then x else do_tl (i - 1) (List.tl x) + in + do_tl n l (* string utils *) let get_hierarchy path = - let l = List.length path in - let revpath = List.rev path in - let rec sub i = - let x = List.rev (list_tl_multi (l - i) revpath) in - if i = l then [ x ] else x :: sub (i + 1) - in - sub 0 + let l = List.length path in + let revpath = List.rev path in + let rec sub i = + let x = List.rev (list_tl_multi (l - i) revpath) in + if i = l then [ x ] else x :: sub (i + 1) + in + sub 0 let hexify s = - let hexseq_of_char c = sprintf "%02x" (Char.code c) in - let hs = Bytes.create (String.length s * 2) in - String.iteri (fun i c -> - let seq = hexseq_of_char c in - Bytes.set hs (i * 2) seq.[0]; - Bytes.set hs (i * 2 + 1) seq.[1]; - ) s; - Bytes.unsafe_to_string hs + let hexseq_of_char c = sprintf "%02x" (Char.code c) in + let hs = Bytes.create (String.length s * 2) in + String.iteri (fun i c -> + let seq = hexseq_of_char c in + Bytes.set hs (i * 2) seq.[0]; + Bytes.set hs (i * 2 + 1) seq.[1]; + ) s; + Bytes.unsafe_to_string hs let unhexify hs = - let char_of_hexseq seq0 seq1 = Char.chr (int_of_string (sprintf "0x%c%c" seq0 seq1)) in - let b = Bytes.create (String.length hs / 2) in - for i = 0 to Bytes.length b - 1 - do - Bytes.set b i (char_of_hexseq hs.[i * 2] hs.[i * 2 + 1]) - done; - Bytes.unsafe_to_string b + let char_of_hexseq seq0 seq1 = Char.chr (int_of_string (sprintf "0x%c%c" seq0 seq1)) in + let b = Bytes.create (String.length hs / 2) in + for i = 0 to Bytes.length b - 1 + do + Bytes.set b i (char_of_hexseq hs.[i * 2] hs.[i * 2 + 1]) + done; + Bytes.unsafe_to_string b let trim_path path = - try - let rindex = String.rindex path '/' in - String.sub path 0 rindex - with - Not_found -> "" + try + let rindex = String.rindex path '/' in + String.sub path 0 rindex + with + Not_found -> "" let join_by_null ls = String.concat "\000" ls (* unix utils *) let create_unix_socket name = - Unixext.unlink_safe name; - Unixext.mkdir_rec (Filename.dirname name) 0o700; - let sockaddr = Unix.ADDR_UNIX(name) in - let sock = Unix.socket Unix.PF_UNIX Unix.SOCK_STREAM 0 in - Unix.bind sock sockaddr; - Unix.listen sock 1; - sock + Unixext.unlink_safe name; + Unixext.mkdir_rec (Filename.dirname name) 0o700; + let sockaddr = Unix.ADDR_UNIX(name) in + let sock = Unix.socket Unix.PF_UNIX Unix.SOCK_STREAM 0 in + Unix.bind sock sockaddr; + Unix.listen sock 1; + sock let read_file_single_integer filename = - let fd = Unix.openfile filename [ Unix.O_RDONLY ] 0o640 in - let buf = Bytes.make 20 '\000' in - let sz = Unix.read fd buf 0 20 in - Unix.close fd; - int_of_string (Bytes.sub_string buf 0 sz) + let fd = Unix.openfile filename [ Unix.O_RDONLY ] 0o640 in + let buf = Bytes.make 20 '\000' in + let sz = Unix.read fd buf 0 20 in + Unix.close fd; + int_of_string (Bytes.sub_string buf 0 sz) (* @path may be guest data and needs its length validating. @connection_path * is generated locally in xenstored and always of the form "/local/domain/$N/" *) let path_validate path connection_path = - let len = String.length path in + let len = String.length path in - if len = 0 then raise Define.Invalid_path; + if len = 0 then raise Define.Invalid_path; - let abs_path = - match String.get path 0 with - | '/' | '@' -> path - | _ -> connection_path ^ path - in + let abs_path = + match String.get path 0 with + | '/' | '@' -> path + | _ -> connection_path ^ path + in - (* Regardless whether client specified absolute or relative path, - canonicalize it (above) and, for domain-relative paths, check the - length of the relative part. + (* Regardless whether client specified absolute or relative path, + canonicalize it (above) and, for domain-relative paths, check the + length of the relative part. - This prevents paths becoming invalid across migrate when the length - of the domid changes in @param connection_path. - *) - let len = String.length abs_path in - let on_absolute _ _ = len in - let on_relative _ offset = len - offset in - let len = Scanf.ksscanf abs_path on_absolute "/local/domain/%d/%n" on_relative in - if len > !Define.path_max then raise Define.Invalid_path; + This prevents paths becoming invalid across migrate when the length + of the domid changes in @param connection_path. + *) + let len = String.length abs_path in + let on_absolute _ _ = len in + let on_relative _ offset = len - offset in + let len = Scanf.ksscanf abs_path on_absolute "/local/domain/%d/%n" on_relative in + if len > !Define.path_max then raise Define.Invalid_path; - abs_path + abs_path module FD : sig - type t = Unix.file_descr - val of_int: int -> t - val to_int : t -> int + type t = Unix.file_descr + val of_int: int -> t + val to_int : t -> int end = struct - type t = Unix.file_descr - (* This is like Obj.magic but just for these types, - and relies on Unix.file_descr = int *) - external to_int : t -> int = "%identity" - external of_int : int -> t = "%identity" + type t = Unix.file_descr + (* This is like Obj.magic but just for these types, + and relies on Unix.file_descr = int *) + external to_int : t -> int = "%identity" + external of_int : int -> t = "%identity" end diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml index ffd43a4eee..34612814e1 100644 --- a/tools/ocaml/xenstored/xenstored.ml +++ b/tools/ocaml/xenstored/xenstored.ml @@ -26,589 +26,589 @@ let info fmt = Logging.info "xenstored" fmt (*------------ event klass processors --------------*) let process_connection_fds store cons domains rset wset = - let try_fct fct c = - try - fct store cons domains c - with - | Unix.Unix_error(err, "write", _) -> - Connections.del_anonymous cons c; - error "closing socket connection: write error: %s" - (Unix.error_message err) - | Unix.Unix_error(err, "read", _) -> - Connections.del_anonymous cons c; - if err <> Unix.ECONNRESET then - error "closing socket connection: read error: %s" - (Unix.error_message err) - | Xenbus.Xb.End_of_file -> - Connections.del_anonymous cons c; - debug "closing socket connection" - in - let process_fdset_with fds fct = - List.iter - (fun fd -> - try try_fct fct (Connections.find cons fd) - with Not_found -> () - ) fds in - process_fdset_with rset Process.do_input; - process_fdset_with wset Process.do_output + let try_fct fct c = + try + fct store cons domains c + with + | Unix.Unix_error(err, "write", _) -> + Connections.del_anonymous cons c; + error "closing socket connection: write error: %s" + (Unix.error_message err) + | Unix.Unix_error(err, "read", _) -> + Connections.del_anonymous cons c; + if err <> Unix.ECONNRESET then + error "closing socket connection: read error: %s" + (Unix.error_message err) + | Xenbus.Xb.End_of_file -> + Connections.del_anonymous cons c; + debug "closing socket connection" + in + let process_fdset_with fds fct = + List.iter + (fun fd -> + try try_fct fct (Connections.find cons fd) + with Not_found -> () + ) fds in + process_fdset_with rset Process.do_input; + process_fdset_with wset Process.do_output let process_domains store cons domains = - let do_io_domain domain = - if Domain.is_bad_domain domain - || Domain.get_io_credit domain <= 0 - || Domain.is_paused_for_conflict domain - then () (* nothing to do *) - else ( - let con = Connections.find_domain cons (Domain.get_id domain) in - Process.do_input store cons domains con; - Process.do_output store cons domains con; - Domain.decr_io_credit domain - ) in - Domains.iter domains do_io_domain + let do_io_domain domain = + if Domain.is_bad_domain domain + || Domain.get_io_credit domain <= 0 + || Domain.is_paused_for_conflict domain + then () (* nothing to do *) + else ( + let con = Connections.find_domain cons (Domain.get_id domain) in + Process.do_input store cons domains con; + Process.do_output store cons domains con; + Domain.decr_io_credit domain + ) in + Domains.iter domains do_io_domain let sigusr1_handler store = - try - let channel = open_out_gen [ Open_wronly; Open_creat; Open_trunc; ] - 0o600 (Paths.xen_run_stored ^ "/db.debug") in - finally (fun () -> Store.dump store channel) - (fun () -> close_out channel) - with _ -> - () + try + let channel = open_out_gen [ Open_wronly; Open_creat; Open_trunc; ] + 0o600 (Paths.xen_run_stored ^ "/db.debug") in + finally (fun () -> Store.dump store channel) + (fun () -> close_out channel) + with _ -> + () let sighup_handler _ = - maybe (fun logger -> logger.Logging.restart()) !Logging.xenstored_logger; - maybe (fun logger -> logger.Logging.restart()) !Logging.access_logger + maybe (fun logger -> logger.Logging.restart()) !Logging.xenstored_logger; + maybe (fun logger -> logger.Logging.restart()) !Logging.access_logger let config_filename cf = - match cf.config_file with - | Some name -> name - | None -> Define.default_config_dir ^ "/oxenstored.conf" + match cf.config_file with + | Some name -> name + | None -> Define.default_config_dir ^ "/oxenstored.conf" let default_pidfile = Paths.xen_run_dir ^ "/xenstored.pid" let ring_scan_interval = ref 20 let parse_config filename = - let pidfile = ref default_pidfile in - let options = [ - ("merge-activate", Config.Set_bool Transaction.do_coalesce); - ("conflict-burst-limit", Config.Set_float Define.conflict_burst_limit); - ("conflict-max-history-seconds", Config.Set_float Define.conflict_max_history_seconds); - ("conflict-rate-limit-is-aggregate", Config.Set_bool Define.conflict_rate_limit_is_aggregate); - ("perms-activate", Config.Set_bool Perms.activate); - ("perms-watch-activate", Config.Set_bool Perms.watch_activate); - ("quota-activate", Config.Set_bool Quota.activate); - ("quota-maxwatch", Config.Set_int Define.maxwatch); - ("quota-transaction", Config.Set_int Define.maxtransaction); - ("quota-maxentity", Config.Set_int Quota.maxent); - ("quota-maxsize", Config.Set_int Quota.maxsize); - ("quota-maxrequests", Config.Set_int Define.maxrequests); - ("quota-maxoutstanding", Config.Set_int Define.maxoutstanding); - ("quota-maxwatchevents", Config.Set_int Define.maxwatchevents); - ("quota-path-max", Config.Set_int Define.path_max); - ("gc-max-overhead", Config.Set_int Define.gc_max_overhead); - ("test-eagain", Config.Set_bool Transaction.test_eagain); - ("persistent", Config.Set_bool Disk.enable); - ("xenstored-log-file", Config.String Logging.set_xenstored_log_destination); - ("xenstored-log-level", Config.String - (fun s -> Logging.xenstored_log_level := Logging.level_of_string s)); - ("xenstored-log-nb-files", Config.Set_int Logging.xenstored_log_nb_files); - ("xenstored-log-nb-lines", Config.Set_int Logging.xenstored_log_nb_lines); - ("xenstored-log-nb-chars", Config.Set_int Logging.xenstored_log_nb_chars); - ("access-log-file", Config.String Logging.set_access_log_destination); - ("access-log-nb-files", Config.Set_int Logging.access_log_nb_files); - ("access-log-nb-lines", Config.Set_int Logging.access_log_nb_lines); - ("access-log-nb-chars", Config.Set_int Logging.access_log_nb_chars); - ("access-log-read-ops", Config.Set_bool Logging.access_log_read_ops); - ("access-log-transactions-ops", Config.Set_bool Logging.access_log_transaction_ops); - ("access-log-special-ops", Config.Set_bool Logging.access_log_special_ops); - ("allow-debug", Config.Set_bool Process.allow_debug); - ("ring-scan-interval", Config.Set_int ring_scan_interval); - ("pid-file", Config.Set_string pidfile); - ("xenstored-kva", Config.Set_string Domains.xenstored_kva); - ("xenstored-port", Config.Set_string Domains.xenstored_port); ] in - begin try Config.read filename options (fun _ _ -> raise Not_found) - with - | Config.Error err -> List.iter (fun (k, e) -> - match e with - | "unknown key" -> eprintf "config: unknown key %s\n" k - | _ -> eprintf "config: %s: %s\n" k e - ) err; - | Sys_error m -> eprintf "error: config: %s\n" m; - end; - !pidfile + let pidfile = ref default_pidfile in + let options = [ + ("merge-activate", Config.Set_bool Transaction.do_coalesce); + ("conflict-burst-limit", Config.Set_float Define.conflict_burst_limit); + ("conflict-max-history-seconds", Config.Set_float Define.conflict_max_history_seconds); + ("conflict-rate-limit-is-aggregate", Config.Set_bool Define.conflict_rate_limit_is_aggregate); + ("perms-activate", Config.Set_bool Perms.activate); + ("perms-watch-activate", Config.Set_bool Perms.watch_activate); + ("quota-activate", Config.Set_bool Quota.activate); + ("quota-maxwatch", Config.Set_int Define.maxwatch); + ("quota-transaction", Config.Set_int Define.maxtransaction); + ("quota-maxentity", Config.Set_int Quota.maxent); + ("quota-maxsize", Config.Set_int Quota.maxsize); + ("quota-maxrequests", Config.Set_int Define.maxrequests); + ("quota-maxoutstanding", Config.Set_int Define.maxoutstanding); + ("quota-maxwatchevents", Config.Set_int Define.maxwatchevents); + ("quota-path-max", Config.Set_int Define.path_max); + ("gc-max-overhead", Config.Set_int Define.gc_max_overhead); + ("test-eagain", Config.Set_bool Transaction.test_eagain); + ("persistent", Config.Set_bool Disk.enable); + ("xenstored-log-file", Config.String Logging.set_xenstored_log_destination); + ("xenstored-log-level", Config.String + (fun s -> Logging.xenstored_log_level := Logging.level_of_string s)); + ("xenstored-log-nb-files", Config.Set_int Logging.xenstored_log_nb_files); + ("xenstored-log-nb-lines", Config.Set_int Logging.xenstored_log_nb_lines); + ("xenstored-log-nb-chars", Config.Set_int Logging.xenstored_log_nb_chars); + ("access-log-file", Config.String Logging.set_access_log_destination); + ("access-log-nb-files", Config.Set_int Logging.access_log_nb_files); + ("access-log-nb-lines", Config.Set_int Logging.access_log_nb_lines); + ("access-log-nb-chars", Config.Set_int Logging.access_log_nb_chars); + ("access-log-read-ops", Config.Set_bool Logging.access_log_read_ops); + ("access-log-transactions-ops", Config.Set_bool Logging.access_log_transaction_ops); + ("access-log-special-ops", Config.Set_bool Logging.access_log_special_ops); + ("allow-debug", Config.Set_bool Process.allow_debug); + ("ring-scan-interval", Config.Set_int ring_scan_interval); + ("pid-file", Config.Set_string pidfile); + ("xenstored-kva", Config.Set_string Domains.xenstored_kva); + ("xenstored-port", Config.Set_string Domains.xenstored_port); ] in + begin try Config.read filename options (fun _ _ -> raise Not_found) + with + | Config.Error err -> List.iter (fun (k, e) -> + match e with + | "unknown key" -> eprintf "config: unknown key %s\n" k + | _ -> eprintf "config: %s: %s\n" k e + ) err; + | Sys_error m -> eprintf "error: config: %s\n" m; + end; + !pidfile module DB = struct -exception Bad_format of string + exception Bad_format of string -let dump_format_header = "$xenstored-dump-format" + let dump_format_header = "$xenstored-dump-format" -let from_channel_f chan global_f socket_f domain_f watch_f store_f = - let unhexify s = Utils.unhexify s in - let getpath s = - let u = Utils.unhexify s in - debug "Path: %s" u; - Store.Path.of_string u in - let header = input_line chan in - if header <> dump_format_header then - raise (Bad_format "header"); - let quit = ref false in - while not !quit - do - try - let line = input_line chan in - let l = String.split ',' line in - try - match l with - | "global" :: rw :: _ -> - (* there might be more parameters here, - e.g. a RO socket from a previous version: ignore it *) - global_f ~rw - | "socket" :: fd :: [] -> - socket_f ~fd:(int_of_string fd) - | "dom" :: domid :: mfn :: port :: []-> - domain_f (int_of_string domid) - (Nativeint.of_string mfn) - (int_of_string port) - | "watch" :: domid :: path :: token :: [] -> - watch_f (int_of_string domid) - (unhexify path) (unhexify token) - | "store" :: path :: perms :: value :: [] -> - store_f (getpath path) - (Perms.Node.of_string (unhexify perms ^ "\000")) - (unhexify value) - | _ -> - info "restoring: ignoring unknown line: %s" line - with exn -> - info "restoring: ignoring unknown line: %s (exception: %s)" - line (Printexc.to_string exn); - () - with End_of_file -> - quit := true - done; - info "Completed loading xenstore dump" + let from_channel_f chan global_f socket_f domain_f watch_f store_f = + let unhexify s = Utils.unhexify s in + let getpath s = + let u = Utils.unhexify s in + debug "Path: %s" u; + Store.Path.of_string u in + let header = input_line chan in + if header <> dump_format_header then + raise (Bad_format "header"); + let quit = ref false in + while not !quit + do + try + let line = input_line chan in + let l = String.split ',' line in + try + match l with + | "global" :: rw :: _ -> + (* there might be more parameters here, + e.g. a RO socket from a previous version: ignore it *) + global_f ~rw + | "socket" :: fd :: [] -> + socket_f ~fd:(int_of_string fd) + | "dom" :: domid :: mfn :: port :: []-> + domain_f (int_of_string domid) + (Nativeint.of_string mfn) + (int_of_string port) + | "watch" :: domid :: path :: token :: [] -> + watch_f (int_of_string domid) + (unhexify path) (unhexify token) + | "store" :: path :: perms :: value :: [] -> + store_f (getpath path) + (Perms.Node.of_string (unhexify perms ^ "\000")) + (unhexify value) + | _ -> + info "restoring: ignoring unknown line: %s" line + with exn -> + info "restoring: ignoring unknown line: %s (exception: %s)" + line (Printexc.to_string exn); + () + with End_of_file -> + quit := true + done; + info "Completed loading xenstore dump" -let from_channel store cons doms chan = - (* don't let the permission get on our way, full perm ! *) - let op = Store.get_ops store Perms.Connection.full_rights in - let rwro = ref (None) in - let global_f ~rw = - let get_listen_sock sockfd = - let fd = sockfd |> int_of_string |> Utils.FD.of_int in - Unix.listen fd 1; - Some fd - in - rwro := get_listen_sock rw - in - let socket_f ~fd = - let ufd = Utils.FD.of_int fd in - let is_valid = try (Unix.fstat ufd).Unix.st_kind = Unix.S_SOCK with _ -> false in - if is_valid then - Connections.add_anonymous cons ufd - else - warn "Ignoring invalid socket FD %d" fd - in - let domain_f domid mfn port = - let ndom = - if domid > 0 then - Domains.create doms domid mfn port - else - Domains.create0 doms - in - Connections.add_domain cons ndom; - in - let get_con id = - if id < 0 then Connections.find cons (Utils.FD.of_int (-id)) - else Connections.find_domain cons id - in - let watch_f id path token = - ignore (Connections.add_watch cons (get_con id) path token) - in - let store_f path perms value = - op.Store.write path value; - op.Store.setperms path perms - in - from_channel_f chan global_f socket_f domain_f watch_f store_f; - !rwro + let from_channel store cons doms chan = + (* don't let the permission get on our way, full perm ! *) + let op = Store.get_ops store Perms.Connection.full_rights in + let rwro = ref (None) in + let global_f ~rw = + let get_listen_sock sockfd = + let fd = sockfd |> int_of_string |> Utils.FD.of_int in + Unix.listen fd 1; + Some fd + in + rwro := get_listen_sock rw + in + let socket_f ~fd = + let ufd = Utils.FD.of_int fd in + let is_valid = try (Unix.fstat ufd).Unix.st_kind = Unix.S_SOCK with _ -> false in + if is_valid then + Connections.add_anonymous cons ufd + else + warn "Ignoring invalid socket FD %d" fd + in + let domain_f domid mfn port = + let ndom = + if domid > 0 then + Domains.create doms domid mfn port + else + Domains.create0 doms + in + Connections.add_domain cons ndom; + in + let get_con id = + if id < 0 then Connections.find cons (Utils.FD.of_int (-id)) + else Connections.find_domain cons id + in + let watch_f id path token = + ignore (Connections.add_watch cons (get_con id) path token) + in + let store_f path perms value = + op.Store.write path value; + op.Store.setperms path perms + in + from_channel_f chan global_f socket_f domain_f watch_f store_f; + !rwro -let from_file store cons doms file = - info "Loading xenstore dump from %s" file; - let channel = open_in file in - finally (fun () -> from_channel store doms cons channel) - (fun () -> close_in channel) + let from_file store cons doms file = + info "Loading xenstore dump from %s" file; + let channel = open_in file in + finally (fun () -> from_channel store doms cons channel) + (fun () -> close_in channel) -let to_channel store cons rw chan = - let hexify s = Utils.hexify s in + let to_channel store cons rw chan = + let hexify s = Utils.hexify s in - fprintf chan "%s\n" dump_format_header; - let fdopt = function None -> -1 | Some fd -> - (* systemd and utils.ml sets it close on exec *) - Unix.clear_close_on_exec fd; - Utils.FD.to_int fd in - fprintf chan "global,%d\n" (fdopt rw); + fprintf chan "%s\n" dump_format_header; + let fdopt = function None -> -1 | Some fd -> + (* systemd and utils.ml sets it close on exec *) + Unix.clear_close_on_exec fd; + Utils.FD.to_int fd in + fprintf chan "global,%d\n" (fdopt rw); - (* dump connections related to domains: domid, mfn, eventchn port/ sockets, and watches *) - Connections.iter cons (fun con -> Connection.dump con chan); + (* dump connections related to domains: domid, mfn, eventchn port/ sockets, and watches *) + Connections.iter cons (fun con -> Connection.dump con chan); - (* dump the store *) - Store.dump_fct store (fun path node -> - let name, perms, value = Store.Node.unpack node in - let fullpath = Store.Path.to_string (Store.Path.of_path_and_name path name) in - let permstr = Perms.Node.to_string perms in - fprintf chan "store,%s,%s,%s\n" (hexify fullpath) (hexify permstr) (hexify value) - ); - flush chan; - () + (* dump the store *) + Store.dump_fct store (fun path node -> + let name, perms, value = Store.Node.unpack node in + let fullpath = Store.Path.to_string (Store.Path.of_path_and_name path name) in + let permstr = Perms.Node.to_string perms in + fprintf chan "store,%s,%s,%s\n" (hexify fullpath) (hexify permstr) (hexify value) + ); + flush chan; + () -let to_file store cons fds file = - let channel = open_out_gen [ Open_wronly; Open_creat; Open_trunc; ] 0o600 file in - finally (fun () -> to_channel store cons fds channel) - (fun () -> close_out channel) + let to_file store cons fds file = + let channel = open_out_gen [ Open_wronly; Open_creat; Open_trunc; ] 0o600 file in + finally (fun () -> to_channel store cons fds channel) + (fun () -> close_out channel) end (* - By default OCaml's GC only returns memory to the OS when it exceeds a - configurable 'max overhead' setting. - The default is 500%, that is 5/6th of the OCaml heap needs to be free - and only 1/6th live for a compaction to be triggerred that would - release memory back to the OS. - If the limit is not hit then the OCaml process can reuse that memory - for its own purposes, but other processes won't be able to use it. + By default OCaml's GC only returns memory to the OS when it exceeds a + configurable 'max overhead' setting. + The default is 500%, that is 5/6th of the OCaml heap needs to be free + and only 1/6th live for a compaction to be triggerred that would + release memory back to the OS. + If the limit is not hit then the OCaml process can reuse that memory + for its own purposes, but other processes won't be able to use it. - There is also a 'space overhead' setting that controls how much work - each major GC slice does, and by default aims at having no more than - 80% or 120% (depending on version) garbage values compared to live - values. - This doesn't have as much relevance to memory returned to the OS as - long as space_overhead <= max_overhead, because compaction is only - triggerred at the end of major GC cycles. + There is also a 'space overhead' setting that controls how much work + each major GC slice does, and by default aims at having no more than + 80% or 120% (depending on version) garbage values compared to live + values. + This doesn't have as much relevance to memory returned to the OS as + long as space_overhead <= max_overhead, because compaction is only + triggerred at the end of major GC cycles. - The defaults are too large once the program starts using ~100MiB of - memory, at which point ~500MiB would be unavailable to other processes - (which would be fine if this was the main process in this VM, but it is - not). + The defaults are too large once the program starts using ~100MiB of + memory, at which point ~500MiB would be unavailable to other processes + (which would be fine if this was the main process in this VM, but it is + not). - Max overhead can also be set to 0, however this is for testing purposes - only (setting it lower than 'space overhead' wouldn't help because the - major GC wouldn't run fast enough, and compaction does have a - performance cost: we can only compact contiguous regions, so memory has - to be moved around). + Max overhead can also be set to 0, however this is for testing purposes + only (setting it lower than 'space overhead' wouldn't help because the + major GC wouldn't run fast enough, and compaction does have a + performance cost: we can only compact contiguous regions, so memory has + to be moved around). - Max overhead controls how often the heap is compacted, which is useful - if there are burst of activity followed by long periods of idle state, - or if a domain quits, etc. Compaction returns memory to the OS. + Max overhead controls how often the heap is compacted, which is useful + if there are burst of activity followed by long periods of idle state, + or if a domain quits, etc. Compaction returns memory to the OS. - wasted = live * space_overhead / 100 + wasted = live * space_overhead / 100 - For globally overriding the GC settings one can use OCAMLRUNPARAM, - however we provide a config file override to be consistent with other - oxenstored settings. + For globally overriding the GC settings one can use OCAMLRUNPARAM, + however we provide a config file override to be consistent with other + oxenstored settings. - One might want to dynamically adjust the overhead setting based on used - memory, i.e. to use a fixed upper bound in bytes, not percentage. However - measurements show that such adjustments increase GC overhead massively, - while still not guaranteeing that memory is returned any more quickly - than with a percentage based setting. + One might want to dynamically adjust the overhead setting based on used + memory, i.e. to use a fixed upper bound in bytes, not percentage. However + measurements show that such adjustments increase GC overhead massively, + while still not guaranteeing that memory is returned any more quickly + than with a percentage based setting. - The allocation policy could also be tweaked, e.g. first fit would reduce - fragmentation and thus memory usage, but the documentation warns that it - can be sensibly slower, and indeed one of our own testcases can trigger - such a corner case where it is multiple times slower, so it is best to keep - the default allocation policy (next-fit/best-fit depending on version). + The allocation policy could also be tweaked, e.g. first fit would reduce + fragmentation and thus memory usage, but the documentation warns that it + can be sensibly slower, and indeed one of our own testcases can trigger + such a corner case where it is multiple times slower, so it is best to keep + the default allocation policy (next-fit/best-fit depending on version). - There are other tweaks that can be attempted in the future, e.g. setting - 'ulimit -v' to 75% of RAM, however getting the kernel to actually return - NULL from allocations is difficult even with that setting, and without a - NULL the emergency GC won't be triggerred. - Perhaps cgroup limits could help, but for now tweak the safest only. + There are other tweaks that can be attempted in the future, e.g. setting + 'ulimit -v' to 75% of RAM, however getting the kernel to actually return + NULL from allocations is difficult even with that setting, and without a + NULL the emergency GC won't be triggerred. + Perhaps cgroup limits could help, but for now tweak the safest only. *) let tweak_gc () = - Gc.set { (Gc.get ()) with Gc.max_overhead = !Define.gc_max_overhead } + Gc.set { (Gc.get ()) with Gc.max_overhead = !Define.gc_max_overhead } let _ = - let cf = do_argv in - let pidfile = - if Sys.file_exists (config_filename cf) then - parse_config (config_filename cf) - else - default_pidfile - in + let cf = do_argv in + let pidfile = + if Sys.file_exists (config_filename cf) then + parse_config (config_filename cf) + else + default_pidfile + in - tweak_gc (); + tweak_gc (); - (try - Unixext.mkdir_rec (Filename.dirname pidfile) 0o755 - with _ -> - () - ); + (try + Unixext.mkdir_rec (Filename.dirname pidfile) 0o755 + with _ -> + () + ); - let rw_sock = - if cf.disable_socket || cf.live_reload then - None - else - Some (Unix.handle_unix_error Utils.create_unix_socket Define.xs_daemon_socket) - in + let rw_sock = + if cf.disable_socket || cf.live_reload then + None + else + Some (Unix.handle_unix_error Utils.create_unix_socket Define.xs_daemon_socket) + in - if cf.daemonize && not cf.live_reload then - Unixext.daemonize () - else - printf "Xen Storage Daemon, version %d.%d\n%!" - Define.xenstored_major Define.xenstored_minor; + if cf.daemonize && not cf.live_reload then + Unixext.daemonize () + else + printf "Xen Storage Daemon, version %d.%d\n%!" + Define.xenstored_major Define.xenstored_minor; - (try Unixext.pidfile_write pidfile with _ -> ()); + (try Unixext.pidfile_write pidfile with _ -> ()); - (* for compatilibity with old xenstored *) - begin match cf.pidfile with - | Some pidfile -> Unixext.pidfile_write pidfile - | None -> () end; + (* for compatilibity with old xenstored *) + begin match cf.pidfile with + | Some pidfile -> Unixext.pidfile_write pidfile + | None -> () end; - let store = Store.create () in - let eventchn = Event.init () in - let next_frequent_ops = ref 0. in - let advance_next_frequent_ops () = - next_frequent_ops := (Unix.gettimeofday () +. !Define.conflict_max_history_seconds) - in - let delay_next_frequent_ops_by duration = - next_frequent_ops := !next_frequent_ops +. duration - in - let domains = Domains.init eventchn advance_next_frequent_ops in + let store = Store.create () in + let eventchn = Event.init () in + let next_frequent_ops = ref 0. in + let advance_next_frequent_ops () = + next_frequent_ops := (Unix.gettimeofday () +. !Define.conflict_max_history_seconds) + in + let delay_next_frequent_ops_by duration = + next_frequent_ops := !next_frequent_ops +. duration + in + let domains = Domains.init eventchn advance_next_frequent_ops in - (* For things that need to be done periodically but more often - * than the periodic_ops function *) - let frequent_ops () = - if Unix.gettimeofday () > !next_frequent_ops then ( - History.trim (); - Domains.incr_conflict_credit domains; - advance_next_frequent_ops () - ) in - let cons = Connections.create () in + (* For things that need to be done periodically but more often + * than the periodic_ops function *) + let frequent_ops () = + if Unix.gettimeofday () > !next_frequent_ops then ( + History.trim (); + Domains.incr_conflict_credit domains; + advance_next_frequent_ops () + ) in + let cons = Connections.create () in - let quit = ref false in + let quit = ref false in - Logging.init_xenstored_log(); - List.iter (fun path -> - Store.write store Perms.Connection.full_rights path "") Store.Path.specials; + Logging.init_xenstored_log(); + List.iter (fun path -> + Store.write store Perms.Connection.full_rights path "") Store.Path.specials; - let rw_sock = - if cf.restart && Sys.file_exists Disk.xs_daemon_database then ( - let rwro = DB.from_file store domains cons Disk.xs_daemon_database in - info "Live reload: database loaded"; - Event.bind_dom_exc_virq eventchn; - Process.LiveUpdate.completed (); - rwro - ) else ( - info "No live reload: regular startup"; - if !Disk.enable then ( - info "reading store from disk"; - Disk.read store - ); + let rw_sock = + if cf.restart && Sys.file_exists Disk.xs_daemon_database then ( + let rwro = DB.from_file store domains cons Disk.xs_daemon_database in + info "Live reload: database loaded"; + Event.bind_dom_exc_virq eventchn; + Process.LiveUpdate.completed (); + rwro + ) else ( + info "No live reload: regular startup"; + if !Disk.enable then ( + info "reading store from disk"; + Disk.read store + ); - let localpath = Store.Path.of_string "/local" in - if not (Store.path_exists store localpath) then - Store.mkdir store (Perms.Connection.create 0) localpath; + let localpath = Store.Path.of_string "/local" in + if not (Store.path_exists store localpath) then + Store.mkdir store (Perms.Connection.create 0) localpath; - if cf.domain_init then ( - Connections.add_domain cons (Domains.create0 domains); - Event.bind_dom_exc_virq eventchn - ); - rw_sock - ) in + if cf.domain_init then ( + Connections.add_domain cons (Domains.create0 domains); + Event.bind_dom_exc_virq eventchn + ); + rw_sock + ) in - (* required for xenstore-control to detect availability of live-update *) - let tool_path = Store.Path.of_string "/tool" in - if not (Store.path_exists store tool_path) then - Store.mkdir store Perms.Connection.full_rights tool_path; - Store.write store Perms.Connection.full_rights - (Store.Path.of_string "/tool/xenstored") Sys.executable_name; + (* required for xenstore-control to detect availability of live-update *) + let tool_path = Store.Path.of_string "/tool" in + if not (Store.path_exists store tool_path) then + Store.mkdir store Perms.Connection.full_rights tool_path; + Store.write store Perms.Connection.full_rights + (Store.Path.of_string "/tool/xenstored") Sys.executable_name; - Sys.set_signal Sys.sighup (Sys.Signal_handle sighup_handler); - Sys.set_signal Sys.sigterm (Sys.Signal_handle (fun _ -> - info "Received SIGTERM"; - quit := true)); - Sys.set_signal Sys.sigusr1 (Sys.Signal_handle (fun _ -> sigusr1_handler store)); - Sys.set_signal Sys.sigpipe Sys.Signal_ignore; + Sys.set_signal Sys.sighup (Sys.Signal_handle sighup_handler); + Sys.set_signal Sys.sigterm (Sys.Signal_handle (fun _ -> + info "Received SIGTERM"; + quit := true)); + Sys.set_signal Sys.sigusr1 (Sys.Signal_handle (fun _ -> sigusr1_handler store)); + Sys.set_signal Sys.sigpipe Sys.Signal_ignore; - if cf.activate_access_log then begin - let post_rotate () = DB.to_file store cons (None) Disk.xs_daemon_database in - Logging.init_access_log post_rotate - end; + if cf.activate_access_log then begin + let post_rotate () = DB.to_file store cons (None) Disk.xs_daemon_database in + Logging.init_access_log post_rotate + end; - let spec_fds = - (match rw_sock with None -> [] | Some x -> [ x ]) @ - (if cf.domain_init then [ Event.fd eventchn ] else []) - in + let spec_fds = + (match rw_sock with None -> [] | Some x -> [ x ]) @ + (if cf.domain_init then [ Event.fd eventchn ] else []) + in - let process_special_fds rset = - let accept_connection fd = - let (cfd, _addr) = Unix.accept fd in - debug "new connection through socket"; - Connections.add_anonymous cons cfd - and handle_eventchn _fd = - let port = Event.pending eventchn in - debug "pending port %d" (Xeneventchn.to_int port); - finally (fun () -> - if Some port = eventchn.Event.virq_port then ( - let (notify, deaddom) = Domains.cleanup domains in - List.iter (Store.reset_permissions store) deaddom; - List.iter (Connections.del_domain cons) deaddom; - if deaddom <> [] || notify then - Connections.fire_spec_watches - (Store.get_root store) - cons Store.Path.release_domain - ) - else - let c = Connections.find_domain_by_port cons port in - match Connection.get_domain c with - | Some dom -> Domain.incr_io_credit dom | None -> () - ) (fun () -> Event.unmask eventchn port) - and do_if_set fd set fct = - if List.mem fd set then - fct fd in + let process_special_fds rset = + let accept_connection fd = + let (cfd, _addr) = Unix.accept fd in + debug "new connection through socket"; + Connections.add_anonymous cons cfd + and handle_eventchn _fd = + let port = Event.pending eventchn in + debug "pending port %d" (Xeneventchn.to_int port); + finally (fun () -> + if Some port = eventchn.Event.virq_port then ( + let (notify, deaddom) = Domains.cleanup domains in + List.iter (Store.reset_permissions store) deaddom; + List.iter (Connections.del_domain cons) deaddom; + if deaddom <> [] || notify then + Connections.fire_spec_watches + (Store.get_root store) + cons Store.Path.release_domain + ) + else + let c = Connections.find_domain_by_port cons port in + match Connection.get_domain c with + | Some dom -> Domain.incr_io_credit dom | None -> () + ) (fun () -> Event.unmask eventchn port) + and do_if_set fd set fct = + if List.mem fd set then + fct fd in - maybe (fun fd -> do_if_set fd rset accept_connection) rw_sock; - do_if_set (Event.fd eventchn) rset (handle_eventchn) - in + maybe (fun fd -> do_if_set fd rset accept_connection) rw_sock; + do_if_set (Event.fd eventchn) rset (handle_eventchn) + in - let ring_scan_checker dom = - (* no need to scan domains already marked as for processing *) - if not (Domain.get_io_credit dom > 0) then - debug "Looking up domid %d" (Domain.get_id dom); - let con = Connections.find_domain cons (Domain.get_id dom) in - if not (Connection.has_more_work con) then ( - Process.do_output store cons domains con; - Process.do_input store cons domains con; - if Connection.has_more_work con then - (* Previously thought as no work, but detect some after scan (as - processing a new message involves multiple steps.) It's very - likely to be a "lazy" client, bump its credit. It could be false - positive though (due to time window), but it's no harm to give a - domain extra credit. *) - let n = 32 + 2 * (Domains.number domains) in - info "found lazy domain %d, credit %d" (Domain.get_id dom) n; - Domain.set_io_credit ~n dom - ) in + let ring_scan_checker dom = + (* no need to scan domains already marked as for processing *) + if not (Domain.get_io_credit dom > 0) then + debug "Looking up domid %d" (Domain.get_id dom); + let con = Connections.find_domain cons (Domain.get_id dom) in + if not (Connection.has_more_work con) then ( + Process.do_output store cons domains con; + Process.do_input store cons domains con; + if Connection.has_more_work con then + (* Previously thought as no work, but detect some after scan (as + processing a new message involves multiple steps.) It's very + likely to be a "lazy" client, bump its credit. It could be false + positive though (due to time window), but it's no harm to give a + domain extra credit. *) + let n = 32 + 2 * (Domains.number domains) in + info "found lazy domain %d, credit %d" (Domain.get_id dom) n; + Domain.set_io_credit ~n dom + ) in - let last_stat_time = ref 0. in - let last_scan_time = ref 0. in + let last_stat_time = ref 0. in + let last_scan_time = ref 0. in - let periodic_ops now = - debug "periodic_ops starting"; + let periodic_ops now = + debug "periodic_ops starting"; - (* scan all the xs rings as a safenet for ill-behaved clients *) - if !ring_scan_interval >= 0 && now > (!last_scan_time +. float !ring_scan_interval) then - (last_scan_time := now; Domains.iter domains ring_scan_checker); + (* scan all the xs rings as a safenet for ill-behaved clients *) + if !ring_scan_interval >= 0 && now > (!last_scan_time +. float !ring_scan_interval) then + (last_scan_time := now; Domains.iter domains ring_scan_checker); - (* make sure we don't print general stats faster than 2 min *) - if now > (!last_stat_time +. 120.) then ( - info "Transaction conflict statistics for last %F seconds:" (now -. !last_stat_time); - last_stat_time := now; - Domains.iter domains (Domain.log_and_reset_conflict_stats (info "Dom%d caused %Ld conflicts")); - info "%Ld failed transactions; of these no culprit was found for %Ld" !Transaction.failed_commits !Transaction.failed_commits_no_culprit; - Transaction.reset_conflict_stats (); + (* make sure we don't print general stats faster than 2 min *) + if now > (!last_stat_time +. 120.) then ( + info "Transaction conflict statistics for last %F seconds:" (now -. !last_stat_time); + last_stat_time := now; + Domains.iter domains (Domain.log_and_reset_conflict_stats (info "Dom%d caused %Ld conflicts")); + info "%Ld failed transactions; of these no culprit was found for %Ld" !Transaction.failed_commits !Transaction.failed_commits_no_culprit; + Transaction.reset_conflict_stats (); - let gc = Gc.stat () in - let (lanon, lanon_ops, lanon_watchs, - ldom, ldom_ops, ldom_watchs) = Connections.stats cons in - let store_nodes, store_abort, store_coalesce = Store.stats store in - let symtbl_len, symtbl_entries = Symbol.stats () in + let gc = Gc.stat () in + let (lanon, lanon_ops, lanon_watchs, + ldom, ldom_ops, ldom_watchs) = Connections.stats cons in + let store_nodes, store_abort, store_coalesce = Store.stats store in + let symtbl_len, symtbl_entries = Symbol.stats () in - info "store stat: nodes(%d) t-abort(%d) t-coalesce(%d)" - store_nodes store_abort store_coalesce; - info "sytbl stat: length(%d) entries(%d)" symtbl_len symtbl_entries; - info " con stat: anonymous(%d, %d o, %d w) domains(%d, %d o, %d w)" - lanon lanon_ops lanon_watchs ldom ldom_ops ldom_watchs; - info " mem stat: minor(%.0f) promoted(%.0f) major(%.0f) heap(%d w, %d c) live(%d w, %d b) free(%d w, %d b)" - gc.Gc.minor_words gc.Gc.promoted_words gc.Gc.major_words - gc.Gc.heap_words gc.Gc.heap_chunks - gc.Gc.live_words gc.Gc.live_blocks - gc.Gc.free_words gc.Gc.free_blocks - ); - let elapsed = Unix.gettimeofday () -. now in - debug "periodic_ops took %F seconds." elapsed; - if !quit then ( - match Connections.prevents_quit cons with - | [] -> () - | domains -> List.iter (fun con -> warn "%s prevents live update" - (Connection.get_domstr con)) domains - ); - delay_next_frequent_ops_by elapsed - in + info "store stat: nodes(%d) t-abort(%d) t-coalesce(%d)" + store_nodes store_abort store_coalesce; + info "sytbl stat: length(%d) entries(%d)" symtbl_len symtbl_entries; + info " con stat: anonymous(%d, %d o, %d w) domains(%d, %d o, %d w)" + lanon lanon_ops lanon_watchs ldom ldom_ops ldom_watchs; + info " mem stat: minor(%.0f) promoted(%.0f) major(%.0f) heap(%d w, %d c) live(%d w, %d b) free(%d w, %d b)" + gc.Gc.minor_words gc.Gc.promoted_words gc.Gc.major_words + gc.Gc.heap_words gc.Gc.heap_chunks + gc.Gc.live_words gc.Gc.live_blocks + gc.Gc.free_words gc.Gc.free_blocks + ); + let elapsed = Unix.gettimeofday () -. now in + debug "periodic_ops took %F seconds." elapsed; + if !quit then ( + match Connections.prevents_quit cons with + | [] -> () + | domains -> List.iter (fun con -> warn "%s prevents live update" + (Connection.get_domstr con)) domains + ); + delay_next_frequent_ops_by elapsed + in - let period_ops_interval = 15. in - let period_start = ref 0. in + let period_ops_interval = 15. in + let period_start = ref 0. in - let main_loop () = - let is_peaceful c = - match Connection.get_domain c with - | None -> true (* Treat socket-connections as exempt, and free to conflict. *) - | Some dom -> not (Domain.is_paused_for_conflict dom) - in - frequent_ops (); - let mw = Connections.has_more_work cons in - let peaceful_mw = List.filter is_peaceful mw in - List.iter - (fun c -> - match Connection.get_domain c with - | None -> () | Some d -> Domain.incr_io_credit d) - peaceful_mw; - let start_time = Unix.gettimeofday () in - let timeout = - let until_next_activity = - if Domains.all_at_max_credit domains - then period_ops_interval - else min (max 0. (!next_frequent_ops -. start_time)) period_ops_interval in - if peaceful_mw <> [] then 0. else until_next_activity - in - let inset, outset = Connections.select ~only_if:is_peaceful cons in - let rset, wset, _ = - try - Poll.poll_select (spec_fds @ inset) outset [] timeout - with Unix.Unix_error(Unix.EINTR, _, _) -> - [], [], [] in - let sfds, cfds = - List.partition (fun fd -> List.mem fd spec_fds) rset in - if List.length sfds > 0 then - process_special_fds sfds; + let main_loop () = + let is_peaceful c = + match Connection.get_domain c with + | None -> true (* Treat socket-connections as exempt, and free to conflict. *) + | Some dom -> not (Domain.is_paused_for_conflict dom) + in + frequent_ops (); + let mw = Connections.has_more_work cons in + let peaceful_mw = List.filter is_peaceful mw in + List.iter + (fun c -> + match Connection.get_domain c with + | None -> () | Some d -> Domain.incr_io_credit d) + peaceful_mw; + let start_time = Unix.gettimeofday () in + let timeout = + let until_next_activity = + if Domains.all_at_max_credit domains + then period_ops_interval + else min (max 0. (!next_frequent_ops -. start_time)) period_ops_interval in + if peaceful_mw <> [] then 0. else until_next_activity + in + let inset, outset = Connections.select ~only_if:is_peaceful cons in + let rset, wset, _ = + try + Poll.poll_select (spec_fds @ inset) outset [] timeout + with Unix.Unix_error(Unix.EINTR, _, _) -> + [], [], [] in + let sfds, cfds = + List.partition (fun fd -> List.mem fd spec_fds) rset in + if List.length sfds > 0 then + process_special_fds sfds; - if List.length cfds > 0 || List.length wset > 0 then - process_connection_fds store cons domains cfds wset; - if timeout <> 0. then ( - let now = Unix.gettimeofday () in - if now > !period_start +. period_ops_interval then - (period_start := now; periodic_ops now) - ); + if List.length cfds > 0 || List.length wset > 0 then + process_connection_fds store cons domains cfds wset; + if timeout <> 0. then ( + let now = Unix.gettimeofday () in + if now > !period_start +. period_ops_interval then + (period_start := now; periodic_ops now) + ); - process_domains store cons domains - in + process_domains store cons domains + in - Systemd.sd_notify_ready (); - let live_update = ref false in - while not (!quit && Connections.prevents_quit cons = []) - do - try - main_loop (); - live_update := Process.LiveUpdate.should_run cons; - if !live_update || !quit then begin - (* don't initiate live update if saving state fails *) - DB.to_file store cons (rw_sock) Disk.xs_daemon_database; - quit := true; - end - with exc -> - let bt = Printexc.get_backtrace () in - error "caught exception %s: %s" (Printexc.to_string exc) bt; - if cf.reraise_top_level then - raise exc - done; - info "stopping xenstored"; - (* unlink pidfile so that launch-xenstore works again *) - Unixext.unlink_safe pidfile; - (match cf.pidfile with Some pidfile -> Unixext.unlink_safe pidfile | None -> ()); + Systemd.sd_notify_ready (); + let live_update = ref false in + while not (!quit && Connections.prevents_quit cons = []) + do + try + main_loop (); + live_update := Process.LiveUpdate.should_run cons; + if !live_update || !quit then begin + (* don't initiate live update if saving state fails *) + DB.to_file store cons (rw_sock) Disk.xs_daemon_database; + quit := true; + end + with exc -> + let bt = Printexc.get_backtrace () in + error "caught exception %s: %s" (Printexc.to_string exc) bt; + if cf.reraise_top_level then + raise exc + done; + info "stopping xenstored"; + (* unlink pidfile so that launch-xenstore works again *) + Unixext.unlink_safe pidfile; + (match cf.pidfile with Some pidfile -> Unixext.unlink_safe pidfile | None -> ()); - if !live_update then begin - Logging.live_update (); - Process.LiveUpdate.launch_exn !Process.LiveUpdate.state - end + if !live_update then begin + Logging.live_update (); + Process.LiveUpdate.launch_exn !Process.LiveUpdate.state + end -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:49:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:49:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440220.694345 (Exim 4.92) (envelope-from ) id 1osQqi-0003zK-Ou; Tue, 08 Nov 2022 15:49:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440220.694345; Tue, 08 Nov 2022 15:49:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQqi-0003zD-Lk; Tue, 08 Nov 2022 15:49:16 +0000 Received: by outflank-mailman (input) for mailman id 440220; Tue, 08 Nov 2022 15:49:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQqh-0003z7-4h for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:49:15 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2068.outbound.protection.outlook.com [40.107.104.68]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e417693b-5f7c-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:49:12 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8139.eurprd04.prod.outlook.com (2603:10a6:10:248::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Tue, 8 Nov 2022 15:49:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Tue, 8 Nov 2022 15:49:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e417693b-5f7c-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DY46gz8DX2mMIRJNyrKaS899kjP3Q3ARRXqn8dUMmVop6xVAaEG7ZCVhEx5ALEk8tDpXGWJKZnTgAAJodgdTJe06baAh71bdCvRnlO6Sy0tShGhXBJjT1AIvVJlTrj56q1RvqzBbpCgoXXYzzOGGzSSSC/uw2lzCafARIDAnHUTkb/pUFf3FBcEyWY3CnkM3LbnvJZwITyLFpqZx+1Vj9wyiXc2ijqMGQPwWD4wPM0enktyefjjpM8XPq3cXZ9cDO0Xo4C8s2D8dpuXhQZVp9Z2jU9A8i1uLcbmmqNtkxo3fyNvBATgeizSb4H0JMc5th6YfZbD+pUjN8mxC9xWp6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BhpuosmhRGZWg6BeeYRe5UPWdws1fMxY02VhIW/DjzQ=; b=M50VnKTf8Ft+sBk2xjh8lhysJ5DUBqo4tfDYN3zH4Bsj/WPPmLFfAEu5SZodaKYmrufW5f50O7pBBTQigXvFE/2sCHmlLGANupYQ0i4u2O45tGh9uKHsyDtHv3kxvIptziyuI8YRvQ8JGa4T6BLkEXN6pTWdqZ8NXI67lF/CYY3Jet6trkoyeAAQ1y4TyCYCX/6qqgQ4xFDtiJ8mWtjgRwYcLy8MLH6zWohXbohcmOxiLGJn4FsGG53I2QWWn1eSHhP/KRe8vAdpdQaU1+byYgQAa5RGSYHyfxDeQ0S+St6u30W+cY6fKlSBMTQHjfYRduH+esr5Z2Gi17N5032PYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BhpuosmhRGZWg6BeeYRe5UPWdws1fMxY02VhIW/DjzQ=; b=OYWKMWr8dAo6l9A3ZGN15svwCijeUKENWpGXqivRCNk/95flajmI3h0kf9yWln0w5Ohb6z14Ekyzb84kpwXNzJR3O+49MCz0SKx2+jIwQeqQ6iBC0jbygdRtNWjkjeUUuqxxTvLI7iSiPE7awTckH2dxzfNv3Sn+vkn80/Vn+rriobrcG/XNH/jNs3/6zdor+R2QusehS/BjotucyCF5ir+76YDFbDRBDrisyG/lMbFIrbMciohAllycz8Pv0PWH0/38G0UJuFv1xkrbiPSW7IWwybAzSdRcwrX02cR72svvaGdP0gTPePkRbLbzePhk4ftNmgr495z8w6D0CKzqJw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7d56c33d-4b03-9aa1-6abc-45a8ad41caca@suse.com> Date: Tue, 8 Nov 2022 16:49:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Content-Language: en-US To: Luca Fancellu Cc: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0106.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8139:EE_ X-MS-Office365-Filtering-Correlation-Id: 810fba36-be3b-4977-61c3-08dac1a0c6c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +Nw+hXgAi/033kNDwlm4g5Wk8lhFGnPrZ6CmIx0Iqgiw2GNBRWNqcDy1afdgeFzl5i/JPHtAPOTpIih8ZFFgYbh1KkkTM0vCWa7fG0L23H4wROoUwyzHzQ/MmVQEjNf07UkTKjB9Hh/Lx9yTBjIdDjmjUJLJcNv1wQv6tnatgfoGrp9gerQHiCJy4DhaFfBKJMBPc4XDwg5n6BNETaoXkRBB0InS599xYsICRDZqEguui86LVjIr8mErYlofoJRDYztBdVEoE6XEHr11h+366MfH7eaAmWHUsYwiA1j6QteykrhGdvH5eDvzVMpnfEH2yg7gB3aeQzj77RWE8JxhHFTghMLRY+7LxIaHmpg5lRUqhfhRGSO18ljK5K4lt4j2gEnznR4W0kfsz35FWS16BykkuH3h1YRjsPbJgBR8lRYvbqO+MI2v09MS/hI8UGpjG7fzlIdbCfASM9wJgiYuNNEkobWZPovV9rJ+ppvwOeoJXR9at9BbYUJ4uiMhYuFm3upKBH+0oFv7lIS3p7p2sL/srqLRkBCasclLusNyQDYAcBHR95oQnZZENK+VirBfk34wqxgve37UPRjk2qukjbg0usvk8qvxVcT1fnRmHvVep4ne7Yz9EszJWbykLKVzVXTnFuAPPTQ9DY5FbZOIguuGL0+3o2dGxgqqce/qzCkjxbLQm51GGf8eWuZpfqyeOqmwRvdjkju79tD+9fW900evWNMyJwPA+eUneqr9QSoo5NjMYQzdDGDZtfo8HI9YVVbe4PzB2/znHm7NQixUQlbPKABajT8e8somzbood8Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(39860400002)(136003)(366004)(451199015)(86362001)(31696002)(36756003)(2906002)(186003)(26005)(2616005)(53546011)(6506007)(6512007)(83380400001)(38100700002)(5660300002)(31686004)(66476007)(66946007)(316002)(66556008)(6486002)(6916009)(54906003)(8676002)(41300700001)(8936002)(478600001)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3hsdmYrOXVHZmE5R0R4WnFVMG5BWmlZRUMzRnA0d0UxaEFrZFVrN1B2aGMx?= =?utf-8?B?R21HOUt6MGE2NTFrSSsvTUFycjdPaE55dGRkMGJid0lCTFRTNHFTdEpQVWlm?= =?utf-8?B?RmxNcXhYa2g0aUgwV2ZveUhkTXlJcXR4dkNvWDIxQ0FnV2ZFT2RNVGU2MWhW?= =?utf-8?B?NitZV0J1aWk5bzJud09ORFk4OXI4aG5YalBmaVdwOFZQYXhaUFNXbGtpNHl2?= =?utf-8?B?RWY5SGFRM0hMWERDTEdJVlA5WUt3WXlQaVNsdHRnK2FXLzBOV3Y0YWRNK25M?= =?utf-8?B?UE1hUURDckJ0Z2x3OGJkUlJsMlc3dzE4Q2JEMWZ0M21JVW1BbUFvbEowL01k?= =?utf-8?B?MSt4WStaVVY4Z1RXKzYraDVNcE1Uek02NE5POHJ2ZmVzT01JWCtUR2p0ZEg3?= =?utf-8?B?dVNDN1d6MkVLcjRBMk1Db3NaYWhDTDV5OVhBRms4aXhiejc4Z0tJcDNLYnZs?= =?utf-8?B?UVdGSEp0NFhFQ24yYXBOdUZDbHh6Sk14K2RhNnNRVEFQQTF4L3lkUDNxYjJR?= =?utf-8?B?VHBXTUVKNUh4dFp5bTZRT3prSG0xbXhsMDAzRlEzNWhKSk5VczhOelBWaVR1?= =?utf-8?B?YS8vTUZ3RU1RUHp1ZjhwVjZta2ZwRVpzbUdOZUNXOEdGWEN2bERRVVg0RmxL?= =?utf-8?B?TnhwNTcrRW0zQXVGQmJQYWVHSjFSMEcyOXh2YkZDNlluNVM5OEFtQ3dPV0cy?= =?utf-8?B?WFJQODh5Qmp6aUhhdjE4dk9wYTRKWmNtNkpNRW1FNjZ2bi9naGl6dnYwSURR?= =?utf-8?B?WUFoQml0K1pmNG1jZ3JrSWVwaEprb2xlcHZZQmd4RWR6VStZampqS2dyQzVD?= =?utf-8?B?MHNsRlZBRUZiWDNQem9Ec1dGaHVrVXdwc3pKSkp3ZU5BaXkwckpNYUZIOWVQ?= =?utf-8?B?QXRSMURRQjNqTHRVMFhVUEQ5NFprUmVGRjVGbnF6b2xUTUlRSHVrbmdGS0hQ?= =?utf-8?B?UGp1a0FaNnpZYkFYd1FwUVFkUFUyeStJcWd2Rm5IRmVSZWM1bHhoOWwxWGd0?= =?utf-8?B?dDNYOWR5OUhnNEU4bmZUM2VKdzdxWlZOMWI4elNzQXkwL25IcU54bEgybTRM?= =?utf-8?B?R1Y2ODF1SE5IdU8xYW4zOU9aQjhwYUxRd28zU1lOUjdwL1ZGRW8xNkk3eHl2?= =?utf-8?B?aFMyZmM2Z0VVdGFjQ25GRk1LMmlINDFHNkFzTWRLVW5TWkRyeHFKbjVUMHhT?= =?utf-8?B?UDNxOW5ud3NpcStXVjE2YWdJdFJ1RERvYVdBUXZGeGN5RFErS1dSTTczQlpL?= =?utf-8?B?cmR1L0xxNXN1L2JKeEdTQU1IZ3NwV0NDV2pDbFl0eCtsNnVkVXlXaWRyd2pl?= =?utf-8?B?R3VTQUJGR2tWeHczRlhUc0ZmbzJ3aW5XSWpkZW1FLy9jc3FxR21VWXdPdmRU?= =?utf-8?B?V2ZuVFdZUVJWNERoWEtjaG1qVVAwYjY4b3lCK2ZsY29VOGIxamVySTh3WDhS?= =?utf-8?B?ZWh2WFpvVFpHMlYxdmR1V2EvN0pZaWkrQVlYUG93RDV1NWpkZXMzSVMzRitu?= =?utf-8?B?TFUvZVIzL2VPNkFaYkkyVzMyamY0T29nY3RGZGlqeWUyNUpZSWFRMjA2cEtl?= =?utf-8?B?bXVBY0lCZUZ2NG9aSXpCYkZDa0Q4UUZ1Z004MGlUbUdINU5vRjV6VE1sWjJB?= =?utf-8?B?eFR3T0ZtUk1CV2xiR3BKK1l4dTd1K1huRTdhTHZhbWg0L3MzN25CeWVHc1M1?= =?utf-8?B?ejU4RkVBeEFCSEFzY2pjcG0yNko1dThlSm5DeU5TVmRsMXd0VkxTWWdMRGFU?= =?utf-8?B?WlBrbFdqYzJ0c09BWlZwL1RpYWZWME16elFWTnZhS3BSWDVDYXdOYU5TdzU3?= =?utf-8?B?RmdQMkE4TS91dGpYV0Q5Y3h0T3BuenYzYkZDeWcycE9SS2hYTU1MQkpZQzZn?= =?utf-8?B?d00zMG5FdDFyQW1CaERwei9Ucys0WE9HQ2ZIWDVBRDAzL1BQT3NmRFBIRXF2?= =?utf-8?B?K2hteXI1cUJwUERwTWR4Ti9tOS9aTkluQ01yQndFbjdXQy9hNmpyU005aUtk?= =?utf-8?B?am9CYktnUEpnTU1EdXJUNWtsR01UTGMzem1Va210UVVzN1lxcEpCOGxHdDNK?= =?utf-8?B?TWQwaS8wVEsxMkdweUpjN25oMWhPL1VnUlhIVUhaZUdsaVQvZVI0SDc4bm9k?= =?utf-8?Q?UPFvNEpg8empe4h3yoG7ELH2u?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 810fba36-be3b-4977-61c3-08dac1a0c6c8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 15:49:10.1389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jqip2UJWWNMc7InESr4c2gClL2R9tdxlhtC+zAS1XwJbUb5Ku5ebLtJjyUaJjmWXGAn+7x18MMInU1GUcd9qwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8139 On 08.11.2022 15:00, Luca Fancellu wrote: >> On 8 Nov 2022, at 11:48, Jan Beulich wrote: >> On 08.11.2022 11:59, Luca Fancellu wrote: >>>> On 07.11.2022 11:47, Luca Fancellu wrote: >>>>> @@ -757,6 +758,51 @@ cppcheck-version: >>>>> $(objtree)/include/generated/compiler-def.h: >>>>> $(Q)$(CC) -dM -E -o $@ - < /dev/null >>>>> >>>>> +JUSTIFICATION_FILES := $(XEN_ROOT)/docs/misra/safe.json \ >>>>> + $(XEN_ROOT)/docs/misra/false-positive-$$*.json >>>>> + >>>>> +# The following command is using grep to find all files that contains a comment >>>>> +# containing "SAF-" on a single line. >>>>> +# %.safparse will be the original files saved from the build system, these files >>>>> +# will be restored at the end of the analysis step >>>>> +PARSE_FILE_LIST := $(addsuffix .safparse,$(filter-out %.safparse,\ >>>>> +$(shell grep -ERl '^[[:blank:]]*\/\*[[:space:]]+SAF-.*\*\/$$' $(srctree)))) >>>> >>>> Please indent such line continuations. And then isn't this going to risk >>>> matching non-source files as well? Perhaps you want to restrict this to >>>> *.c and *.h? >>> >>> Yes, how about this, it will filter out *.safparse files while keeping in only .h and .c: >>> >>> PARSE_FILE_LIST := $(addsuffix .safparse,$(filter %.c %.h,\ >>> $(shell grep -ERl '^[[:blank:]]*\/\*[[:space:]]+SAF-.*\*\/$$' $(srctree)))) >> >> That's better, but still means touching all files by grep despite now >> only a subset really looked for. If I was to use the new goals on a >> more or less regular basis, I'd expect that this enumeration of files >> doesn't read _much_ more stuff from disk than is actually necessary. > > Ok would it be ok? > > PARSE_FILE_LIST := $(addsuffix .safparse,$(shell grep -ERl --include=\*.h \ > --include=\*.c '^[[:blank:]]*\/\*[[:space:]]+SAF-.*\*\/$$' $(srctree))) Hmm, not sure: --include isn't a standard option to grep, and we generally try to be portable. Actually -R (or -r) isn't either. It may still be okay that way if properly documented where the involved goals will work and where not. And then - why do you escape slashes in the ERE? Talking of escaping - personally I find backslash escapes harder to read / grok than quotation, so I'd like to recommend using quotes around each of the two --include (if they remain in the first place) instead of the \* construct. >>>>> + done >>>>> + >>>>> +analysis-build-%: analysis-parse-tags-% >>>>> + $(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile build >>>> >>>> This rule doesn't use the stem, so I'm struggling to understand what >>>> this is about. >>> >>> Yes, here my aim was to catch analysis-build-{eclair,coverity}, here I see that if the user has a typo >>> the rule will run anyway, but it will be stopped by the dependency chain because at the end we have: >>> >>> JUSTIFICATION_FILES := $(XEN_ROOT)/docs/misra/safe.json \ >>> $(XEN_ROOT)/docs/misra/false-positive-$$*.json >>> >>> That will give an error because $(XEN_ROOT)/docs/misra/false-positive-.json does not exists. >>> >>> If you think it is not enough, what if I reduce the scope of the rule like this? >>> >>> _analysis-coverity _analysis-eclair: _analysis-%: analysis-build-% >> >> But then, without using the stem, how does it know whether to do an >> Eclair or a Coverity run? > > Sorry I think I’m a bit lost here, the makefile is working on both analysis-coverity and analysis-eclair > because the % is solving in coverity or eclair depending on which the makefile has in input, it is not complaining > so I guess it works. > Do you see something not working? If so, are you able to provide a piece of code for that to make me understand? Well, my problem is that I don't see how the distinction is conveyed without the stem being used. With what you say I understand I'm overlooking something, so I'd appreciate some explanation or at least a pointer. >>> Or, if you are still worried about “analysis-build-%: analysis-parse-tags-%”, then I can do something >>> like this: >>> >>> analysis-supported-coverity analysis-supported-eclair: >>> @echo > /dev/null >>> >>> analysis-supported-%: >>> @error Unsupported analysis tool @* >>> >>> analysis-build-%: analysis-parse-tags-% | analysis-supported-% >>> $(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile build >> >> If I'm not mistaken support for | doesn't exist in make 3.80 (the >> minimum version we require to be used). > > IDK, we use order-only prerequisite already in the Makefile. Hmm, yes, for $(objtree)/%.c.cppcheck: . Question is whether this was simply overlooked before. As said above such may be okay for these special goals, but this needs properly documenting then. >>>>> +analysis-clean: >>>>> +# Reverts the original file (-p preserves also timestamp) >>>>> + $(Q)find $(srctree) -type f -name "*.safparse" -print | \ >>>>> + while IFS= read file; do \ >>>>> + cp -p "$${file}" "$${file%.safparse}"; \ >>>>> + rm -f "$${file}"; \ >>>> >>>> Why not "mv"? >>>> >>>>> + done >>>>> + >>>>> +_analysis-%: analysis-build-% >>>>> + $(Q)$(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile analysis-clean >>>> >>>> Again no use of the stem, plus here I wonder if this may not lead to >>>> people invoking "analysis-clean" without having said anything about >>>> cleaning on their command line. >>> >>> In any case, the cleaning process is very safe and does not clean anything that was not dirty before, >>> so in case of typos, it’s just like a nop. >> >> People may put transient files in their trees. Of course they need to be >> aware that when they specify a "clean" target their files may be deleted. >> But without any "clean" target specified nothing should be removed. > > *.safparse files are not supposed to be used freely by user in their tree, those > files will be removed only if the user calls the “analysis-clean” target or if the > analysis-coverity or analysis-eclair reaches the end (a process that creates *.safparse). > > There is no other way to trigger the “analysis-clean” unintentionally, so I’m not sure about > the modification you would like to see there. I guess I don't understand: You have _analysis-% as the target, which I'd assume will handle _analysis-clean just as much as _analysis-abc. This may be connected to my lack of understanding as expressed further up. Or maybe I'm simply not understanding what the _analysis-% target is about in the first place, because with the analysis-build-% dependency I don't see how _analysis-clean would actually work (with the scope restriction you suggested earlier a rule for analysis-build-clean would not be found afaict). Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 08 15:56:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 15:56:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440226.694356 (Exim 4.92) (envelope-from ) id 1osQxc-0005Tk-EG; Tue, 08 Nov 2022 15:56:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440226.694356; Tue, 08 Nov 2022 15:56:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQxc-0005Td-Ah; Tue, 08 Nov 2022 15:56:24 +0000 Received: by outflank-mailman (input) for mailman id 440226; Tue, 08 Nov 2022 15:56:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osQxa-0005TT-E8 for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 15:56:22 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2062.outbound.protection.outlook.com [40.107.103.62]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e34b1017-5f7d-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 16:56:21 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8390.eurprd04.prod.outlook.com (2603:10a6:102:1c2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Tue, 8 Nov 2022 15:56:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Tue, 8 Nov 2022 15:56:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e34b1017-5f7d-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=egHCckw/QYQj3tKMNbkcx1XqxHeMz24R2p5t5DBCkCH6KziXjZBDFzuP76Qu30CRzHhpBzMkR4W9MyS6xSulq9LjxJSVA5R9orbEma3i+vm/JJFhOZMk4sBD9BTmjl1EIJjMY1YBSMdJwNGvtkHT5VWFaImV3TZuB7vHa2iHrMaPrui9+Vr2e+lYQTo5nQufDU1pOMJHZ7dtbSvr5xbS28KiVd7nQlItQEAO6/2JbMpryjwRzF8wSN6DUkP4LwELxccjRVnp8yYa/zOPEue9VWQ9WivLsq04W0Ehfpzr1TNEvhPpqDJKmZfj1wtVYs/LCkITAWpe6oX+PFi6GCwlew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5VRjwtrJlSzhbCBzA6nF4Y5j6DTAKcPRKpNr0mhveYY=; b=IT0/2gKevDbrritWf2C/i6kepsicZE1lhUtQc5TiDE2c5zdgc+gGHHy7bSzgCEsl+lxbpGHKcitechfA40PlSuRbk7tdkb4pcqfDgI2Sa/bPbVnKNQdenVHhA3Al0+2lQglSn9AESwN2d6zSSEyJCikksoBX6lTX+16BfRKoKP8yfN1flS0hd9B6yXnaWnJooOINbG+N2u9WWtFyvewuzKfpEUo0Ug1NptaIeZhF/023C3Gz3ySkg3Qq++PHV2Qfedao1ynQNtVLdXdaWrWc+MZp5qSocRCULGNUlIylgASXrVIQbnO6u+LGAcDapkbRS+Bl9Ht8I5rXLujGfySzQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5VRjwtrJlSzhbCBzA6nF4Y5j6DTAKcPRKpNr0mhveYY=; b=sbOfEnoJYud9K0pE4VVwkBIo7KDd+i544GGyyHvMK/kADd2INW0WT4lj44Pw4qdlcTp+swaMd34qJkMRzvhNv1SrU/JfPJV+E1SQJWjCJwM11YA2/6HnCM/7qusYCEAY+z5BHkqq4KnFS0sEyqnsAkNLd3pxDrdIc7MGlKW0PPI22eeACa3Nftm0wyJIkqHxIQKymfQtoA2zQhzojvW3p5EDKDSlXOGtYzeclpM6H4hnmTKnv/E9RooOBg6UC9rhuMWtR7ae5uc4mLhP1O+n7wHGAXP/ogUWjtkICNhR0wXUCQHjzGjoXPNnm4bWQVYIHyTIrKIjcyaU47Gx7UTPTQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9b785cc6-2de1-a522-9e57-62c0421c6a21@suse.com> Date: Tue, 8 Nov 2022 16:56:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present Content-Language: en-US To: Roger Pau Monne Cc: Henry.Wang@arm.com, ray.huang@amd.com, Alexander.Deucher@amd.com, Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20221108135516.62775-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20221108135516.62775-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P192CA0043.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8390:EE_ X-MS-Office365-Filtering-Correlation-Id: edf64e00-3d92-4130-fe5d-08dac1a1c624 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: goYNe0YWYXYrkhwLcwwpio6pamQVzPbw5wMrtoWpSugh08Ms9sIzBoNHgXMAqun72fx/HRccbZEMBRKSX5LZqK/cyInwOusfd09OqqWp2vZT53kS+VTUjerpu52N3n7F3nE43GPPgNoDI1/YGa6aQoFfGHXGv25rvF/P9dCzK85h8R1lQWw8+LqQFcuz90jVPWzvWWmMWToO6cGpnd0tZ5f6pGa/MH93PAA7HLJfKgBDuzucGSR/tb2xWEs2j/lr5MudxN6YUS1jwkaCgYkDs0t3ZwkIYNTy1JybiJ1kuEJ1oSZXpsLlEKKCffmlBOjC482jER+8/DYncQ62UPpQ0GVfkAwa38wDEkrRQcqCpgTMu3n+uVv6k6g+cR18SSwDnEygZsUe6lfVjTD2upMjMZr9bAZfEO/e9pDJMBRfva5OcwIL2rW2Ij1qzp/+VQrBzOAt0teWasLXm+sc9+Zr8GiGK3wBmHqt/7lWXorJ+vhkQhooC4ptTc0LvmYGY7CYf9JxBjSxep7TvbMEYC1/VOFYKwaAxCX/3Be8SX16SEIYZNr2wrsENIxyAoBpLewHhIUMo79BJSHslxQogso7Zz+eHtfhLcHhjbv7YUwXajNFsmboBp7iR34gaIfnjrYHgyoNXc4/Bo7asz3RSGg3gOTjpOLFUM9KBSPMsIYbCZ/duo7GF9c9bdcdvN0MskmwnBcR9evCLCFoswlbJHEqns3t1kWp+ZJt3aNqlfK8GNgExjdFDKKOHxU6tTUt9bBOJcCcSnpXXs//3cqEmHyvJfFwpsrxpnSBzVT3QHviEjk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(136003)(366004)(346002)(39860400002)(451199015)(31686004)(36756003)(8936002)(66556008)(38100700002)(52230400001)(83380400001)(86362001)(31696002)(54906003)(6916009)(2616005)(45080400002)(186003)(6486002)(41300700001)(478600001)(8676002)(2906002)(316002)(66946007)(4326008)(53546011)(66476007)(6512007)(6506007)(26005)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHpRdkNtdUd1TU95cW8reXBONlhjb3VtQmN6YmhnVVJwVXlRUU5DdTRya0NR?= =?utf-8?B?ZytsQ21HQjVyUHdFWFpsWFI5UjA2ZnZ6b2U0Y3B5STBNSzFraDdZWjViOW9E?= =?utf-8?B?MkRxbHg3aFhwZVVhQlljSE41TDNTeTlHZWc2eGNFcGE0d1p3TTkzOGJoamgv?= =?utf-8?B?cjFCMk16OXBORy94aDFTTXduc3NnK0JTT0h0cEwzTlRUUUMrRTRnY0FvaW9V?= =?utf-8?B?VTdXRzVYMGZUcGxwb01ld29XUVNIbjAwRWlRZmx2Yk1FanovaFRuMDZmU2Yz?= =?utf-8?B?Nzg3RmVwSldpb3ZmeW9tdVNRcGIzQUpVYVZtRXVZRjVMVVRTbkZtclN0T1l0?= =?utf-8?B?Nmp1Z2l1dGJoRFJ4YmJyaTd3QnJuM2tGcEVrYzB5RTVKaHZZOXZnZFBydTBs?= =?utf-8?B?YTZJeE1NVlhhYkJJMkE2Tk9VSVI3T2N1cTVFREdyZGpNeHN1VzFhelhtVm9M?= =?utf-8?B?Y3dRMGZtcldJeENGVjhaRGM5QnR4Yy9JSmRMMks0VGZNc2IyS29QREpucnlh?= =?utf-8?B?bjVuT1Q1SlM2TlpIdGYrVGorWkthZnFBdjlqUjBpcDRMTWhhT0M2c0VBRVh4?= =?utf-8?B?bkk5ZnZBTGRXSEc2dmJocWFkRmxVNnVwSWhnc21IRnZtQW82b0lVU0RzYVU4?= =?utf-8?B?aDROSlg3WDBnaGpISEp4ZGVhRE9sUTB6NWl5bnVuelIxVllLZWV5ZVJBcVZU?= =?utf-8?B?bTlzMUtkUjkxaGUvSFYydzZ2OGRyY2Z3ckdoS3RvNjRidlFpbjgxWkVhOEdM?= =?utf-8?B?amwzMVNrQlUxblJRcXhXeU45NVo4TUVlN1BIRHpJaDQ2TjR2dWRJM0U5a0Nq?= =?utf-8?B?WWZWSnIyUTJDNzlvR1I4Y2EwemdxRGh3cG9IYkFkTG05UGJOODIyZW02RW5l?= =?utf-8?B?VkxkZHRuY1BJRDFSaHZTSDFoN2dpelc0eDRqSkM5dDhQZEtsOVBkcXp5ZTZG?= =?utf-8?B?MTBXQTcvOFBSaExjMm9QcURkWUFoSnNZYVNKZ0FRRHIydm1MbHhWUWFQalho?= =?utf-8?B?bS9NN0N4TEl0NUg1c1JWOEhBZXhobDAySm9FSHZhbVhyVWZZRG1ERmpReC9r?= =?utf-8?B?WnNrMHRBUHE1Q2h2UmdDbkxIcWxzVmFWSjFadFY3d0dhOUJoa1hTUmVpR1l4?= =?utf-8?B?VE5ka2FUaklQTUhNODUrZE82U3RiRzc3RFlBbWtVNDQ5ajB0cGttb2pYZlE3?= =?utf-8?B?clR3V09Jb2huYzVDblBNSHl2YTRhSytzcnRwRHJmbllSVzZsMVJLL2RER3B5?= =?utf-8?B?NWhGS3ZTYlB6cnovZ2ZDMmd6OVZlMzdGRTVOUzNnQWg4WXRITmpUVUpkOXVR?= =?utf-8?B?TmlEd3lJU21yVVl6NG5wVUJFWEpiWHd5S1oyTDhsL0hrM2dnNFJ4bmdxdVdq?= =?utf-8?B?NU16N28va0QzamJhSSt2d0RRdXlqVVFxRkJPRVhNcytIaEoxYXc5Z0g0MjZD?= =?utf-8?B?WkZMMDE1aGRsNjBNWkNHNVRiN1JjZm9VdFQ4RTdubmFVMkZmWG9BQ3NBZmNQ?= =?utf-8?B?dEtTVHZvMGh5UjhmelZJYWtmODJGdzVNYWZvL1YreERrODlENWVFZWpjVGQy?= =?utf-8?B?Wk0yQWx4QloyU0ltOWQvL1BHdGsxR1BpeXNOcjBRSGt6dFR1ZVdqNW83cWV4?= =?utf-8?B?UWRnaTAvT0R6WUtmbGJocmFxNW04SXFIcmpQWFBhQmpyVmRWaDRMVUxrOVEv?= =?utf-8?B?V1M4MlR0bFRsQmRkVXVrMzZwNlZaUWVVcEpPZUxDM0dlTFpHQTRuTW11R3Bj?= =?utf-8?B?b1o0U0RINDVQemgya29wV29sOWtVdFkzYk5DRVZPdVp3Y0lucjYvenpVT016?= =?utf-8?B?VXltKzdPdmtEQmlyR25MY2E4T3YrUGFzMCtJRHZaNFZlYzRneFduejh6SGl4?= =?utf-8?B?TldQbjYwMzJZL28vUEVUYWg5TVRieXpHblEyRmI2ZDVob1E0K1gyS2dSSDZn?= =?utf-8?B?Y09Fd2g1UzM4Y2U3NVQxd1NPVnFBOFJ4S3JybG02TU9vQ2dOZ3Z5Qjc3ZCs4?= =?utf-8?B?ZnpvanJqWEpUYTA2K21rQjhqQmJvNFAwVzRXaGhzdzgra1J2T21PUkp6OWZR?= =?utf-8?B?ZzBxTCtqaVFIdmJWYkhpS1RkVlFxSkpEMlZQOWh1b3gwYVZMZnptTkl1dXBp?= =?utf-8?Q?tx9a3uuyaHDFTaUJ4Oq47nARj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: edf64e00-3d92-4130-fe5d-08dac1a1c624 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 15:56:18.5961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X65ENRt87dKDksIAGMFZHR7ucowfdpLzfp7T9mc/Zh+vgTdKNR7dkajip1fQEMo3TE7iuM9xb35vCVrzvNaUjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8390 On 08.11.2022 14:55, Roger Pau Monne wrote: > The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image > from the firmware instead of doing it on the PCI ROM on the physical > device. I can't find any mention of VFCT in the ACPI 6.3 spec, nor anywhere under Linux'es include/acpi/. I don't mind the addition that you're doing, but there needs to be a pointer to a sufficiently "official" spec. Jan > As such, this needs to be available for PVH dom0 to access, or else > the GPU won't work. > > Reported-by: Huang Rui > Signed-off-by: Roger Pau Monné > --- > This is a bugfix, but given PVH dom0 is still experimental I'm not > sure it would qualify for the release. OTOH being experimental means > there are no guarantees it will work, so the change is unlikely to > make this any worse. > --- > xen/arch/x86/hvm/dom0_build.c | 1 + > xen/include/acpi/actbl3.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c > index 1864d048a1..307edc6a8c 100644 > --- a/xen/arch/x86/hvm/dom0_build.c > +++ b/xen/arch/x86/hvm/dom0_build.c > @@ -924,6 +924,7 @@ static bool __init pvh_acpi_table_allowed(const char *sig, > ACPI_SIG_DSDT, ACPI_SIG_FADT, ACPI_SIG_FACS, ACPI_SIG_PSDT, > ACPI_SIG_SSDT, ACPI_SIG_SBST, ACPI_SIG_MCFG, ACPI_SIG_SLIC, > ACPI_SIG_MSDM, ACPI_SIG_WDAT, ACPI_SIG_FPDT, ACPI_SIG_S3PT, > + ACPI_SIG_VFCT, > }; > unsigned int i; > > diff --git a/xen/include/acpi/actbl3.h b/xen/include/acpi/actbl3.h > index 0a6778421f..6858d3e60f 100644 > --- a/xen/include/acpi/actbl3.h > +++ b/xen/include/acpi/actbl3.h > @@ -79,6 +79,7 @@ > #define ACPI_SIG_MATR "MATR" /* Memory Address Translation Table */ > #define ACPI_SIG_MSDM "MSDM" /* Microsoft Data Management Table */ > #define ACPI_SIG_WPBT "WPBT" /* Windows Platform Binary Table */ > +#define ACPI_SIG_VFCT "VFCT" /* AMD Video BIOS */ > > /* > * All tables must be byte-packed to match the ACPI specification, since From xen-devel-bounces@lists.xenproject.org Tue Nov 08 16:04:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 16:04:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440249.694366 (Exim 4.92) (envelope-from ) id 1osR4m-0007jq-4f; Tue, 08 Nov 2022 16:03:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440249.694366; Tue, 08 Nov 2022 16:03:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osR4m-0007jj-21; Tue, 08 Nov 2022 16:03:48 +0000 Received: by outflank-mailman (input) for mailman id 440249; Tue, 08 Nov 2022 16:03:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osR4k-0007jd-RI for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 16:03:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osR4j-0002Ml-Pw; Tue, 08 Nov 2022 16:03:45 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.3.98]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1osR4j-0004Ep-3p; Tue, 08 Nov 2022 16:03:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=P2tQQCRvFEdY5Q/mLZhIiLMSq4xMhalYoAwQJ/gB4yc=; b=gbFzR8WRF6jSIDrSDY2kGXKI2y GUkKwDQ4G0GfNdjksgv3LNMHkzeKSGLXKc3QD5n8Z2ZY1pX8/C3ro9BJQ6rj5F0XPNTzajbUopvjz LX+RVMng6582HPJ37LBP8IOikNj/NAfgSpIPdarGtsL715Z8X752CFo3+OgbhHgD0RD0=; Message-ID: <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> Date: Tue, 8 Nov 2022 16:03:42 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs To: =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , xen-devel@lists.xenproject.org Cc: Henry Wang , Christian Lindig , David Scott , Wei Liu , Anthony PERARD References: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> Content-Language: en-US From: Julien Grall In-Reply-To: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 08/11/2022 15:33, Edwin Török wrote: > See CODING_STYLE: Xen uses spaces, not tabs. > > * OCaml code: > > Using `ocp-indent` for now to just make minimal modifications in > tabs vs spaces and get the right indentation. > We can introduce `ocamlformat` later. > > * C stubs: > > just replace tabs with spaces now, using `indent` or `clang-format` > would change code too much for 4.17. > > This avoids perpetuating a formatting style that is inconsistent with > the rest of Xen, and that makes preparing and submitting patches more > difficult (OCaml indentation tools usually only support spaces, not tabs). > > Contains a bugfix for `abi-check` script to handle the change in the > amount of whitespace. > > No functional change. > > Signed-off-by: Edwin Török > > -- > Reason for inclusion in 4.17: > - makes it easier to backport changes from master to 4.17 Right, but you will have the problem when backporting to 4.16 and older. So the overhead will always be there for a couple of years. > - avoid perpetuating a different coding style (I thought tabs were > mandated by Xen, and was about to fix up my editor config to match > when I realized Xen already mandates the use of spaces) > - should make submitting patches for OCaml easier (OCaml indentation > tools know only about spaces, so I either can't use them, or have to > manually adjust indentation every time I submit a patch) > - it can be verified that the only change here is the Makefile change > for the new rule, 'git log -p -1 -w' should be otherwise empty While I understand the goal and support, this seems to be a bit too late to do it in Xen 4.17 (we are only a couple of weeks away). At this stage of the release we should only do bug fix. This is clearly only a comesmetic change and there I would argue this should be deferred to 4.18. That said the last call is from the RM. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 08 16:07:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 16:07:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440255.694378 (Exim 4.92) (envelope-from ) id 1osR8G-0000DJ-Nh; Tue, 08 Nov 2022 16:07:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440255.694378; Tue, 08 Nov 2022 16:07:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osR8G-0000DC-Jd; Tue, 08 Nov 2022 16:07:24 +0000 Received: by outflank-mailman (input) for mailman id 440255; Tue, 08 Nov 2022 16:07:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osR8G-0000D4-3l for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 16:07:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osR8F-0002RR-O1; Tue, 08 Nov 2022 16:07:23 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[192.168.3.98]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1osR8F-0004Pp-I3; Tue, 08 Nov 2022 16:07:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=5/eUMaevbdYhF2iIvp2LG8veE6Q8veDEd/P6ju2tuAQ=; b=AHNkCLEm7hAC/+gPxLzk+ozd3z tZuiDWu0/RW9ysYvq0pKWJO5WBnuklxNuOps/f+IZAf3P36iMYd6pxx5GMaq1AL9kVnY4MFabqGMt kK4rt4P9+FZgnytEJIZmuaqzX4D4vTVkfIAQB4cx57NVxSro03Rvqyf2FIfJTwDPm5/I=; Message-ID: <658b1dba-d0e8-286b-837e-a49f791f6ebf@xen.org> Date: Tue, 8 Nov 2022 16:07:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 v3 14/15] tools/ocaml/xenstored/syslog_stubs.c: avoid potential NULL dereference Content-Language: en-US To: =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , xen-devel@lists.xenproject.org Cc: Henry Wang , Christian Lindig , David Scott , Wei Liu , Anthony PERARD References: <5da5b63bd6a0f8d0f6ad0281773eefb32de8164d.1667920496.git.edvin.torok@citrix.com> From: Julien Grall In-Reply-To: <5da5b63bd6a0f8d0f6ad0281773eefb32de8164d.1667920496.git.edvin.torok@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 08/11/2022 15:34, Edwin Török wrote: > If we are out of memory then strdup may return NULL, and passing NULL to > syslog may cause a crash. > > Avoid this by using `caml_stat_strdup` which will raise an OCaml out of > memory exception instead. > This then needs to be paired with caml_stat_free. > > Signed-off-by: Edwin Török > --- > Reason for inclusion in 4.17: > - fixes a bug in out of memory situations > > Changes since v2: > - new in v3 > --- > tools/ocaml/xenstored/syslog_stubs.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tools/ocaml/xenstored/syslog_stubs.c b/tools/ocaml/xenstored/syslog_stubs.c > index 4e5e49b557..4ad85c8eb5 100644 > --- a/tools/ocaml/xenstored/syslog_stubs.c > +++ b/tools/ocaml/xenstored/syslog_stubs.c > @@ -14,6 +14,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -35,14 +36,16 @@ static int __syslog_facility_table[] = { > value stub_syslog(value facility, value level, value msg) > { > CAMLparam3(facility, level, msg); > - const char *c_msg = strdup(String_val(msg)); > + char *c_msg = strdup(String_val(msg)); This change seems to be unrelated with the goal of the commit. IMHO, this should be done in a separate patch. The minimum would be to mention in the commit message. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 08 16:14:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 16:14:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440262.694388 (Exim 4.92) (envelope-from ) id 1osRFP-0001eg-FQ; Tue, 08 Nov 2022 16:14:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440262.694388; Tue, 08 Nov 2022 16:14:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRFP-0001eZ-Ci; Tue, 08 Nov 2022 16:14:47 +0000 Received: by outflank-mailman (input) for mailman id 440262; Tue, 08 Nov 2022 16:14:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRFO-0001eT-Kp for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 16:14:46 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2080.outbound.protection.outlook.com [40.107.247.80]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 751414b1-5f80-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 17:14:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8858.eurprd04.prod.outlook.com (2603:10a6:20b:409::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Tue, 8 Nov 2022 16:14:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Tue, 8 Nov 2022 16:14:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 751414b1-5f80-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7Qk+FLWdixCM5dhOOTsqBPuaLtB6LubCsWMVFWVZ7k4jfTZDA9kA0wMDniCiQNAfD/xFIAJnXTyvegW9ft8mL2NZ6W4zJPJENHIGGQToADH3157HoCX1jBlX1dzQy6c3JbuArRD+O39oW6bRSPEQkUDVKXBv4ELjUs81sJR2gl7cH5RmHUWTZ9WXfW7jaaXfaLR0GCeuCkQh3q28ujNLBjqoxZS3ArEmuDg5FDCPjCNKuoYWr5ksJDd4CkWQlqQou5ofx0aKCpc25FjswHqPpSsDGeurWkMQry35WYj1pWBiD2M1iSw0WH160nsodZKhS+m/Eu4+V4Szl6u3R6tmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kALdrl24ZbbLJDvnjcTuyysnkpdzbU7BO/GCV74y25o=; b=ZBY8anCl8tGBt5FITB+/9LeyS+vptUgiXbPoH5NI1ZAUeLbx5uiG8i5smDa74+UKM2otg3sKQJaOvViu77WT7FastYfSJ1uWSpM0JMWWYpO51NKW8F8sTRzL7kqNbcgH/ZnfgJZkE3VzW73iFsHus63+j3kPro4/Y6Jg0vDysSB3jgu0M+aIPtPtVkL3XI6vbANaBkCPCv0UUDnV9gtDb9E3bq0KgI+nDprBYuj+J2ovQC4GdhXUhWoWn3AFRy2FCjXi0U7gVTEJdLwSnmmoX+ITRM+pXHQ2TwO06hklOfpAZjwpYnnVIEVcdNUoFykmnpr8bUTtNncwwlTrzYs/aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kALdrl24ZbbLJDvnjcTuyysnkpdzbU7BO/GCV74y25o=; b=JbVcThniIKv6qEr/d1GBQpAT3QnO4jYpGEmrkBdws51R9AJdtGYJb1fHN7efGH5Igah+1QUQBBzIeIas/NtQ6gb2SR26kRM7gufeTQSz2UPRWgcwgNyWSENm+roTqd5yzlcpfVRLXmCVtxcQC61+1LGt6oP9wFMhUcsLsEC0oVz6mMIns3XkBSPq1Zx6MFHCoMTwnd1zcwrgRJc78d4/ZDrDS7iolh+1cPJkyVQB91s1sTwfMQXluXjdnaH7cUDC09z9FVq9MY+z1KjdPFEJ8F+hhW5DYYtctYxD0ePcDcDe+gZVK9NC2BgzCvb8TN9nVwJXu/VRQhh4mShBXOzaNQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Nov 2022 17:14:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Content-Language: en-US To: Roger Pau Monne Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , xen-devel@lists.xenproject.org References: <20221108113850.61619-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20221108113850.61619-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0100.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8858:EE_ X-MS-Office365-Filtering-Correlation-Id: 56fbfc0d-d8b2-4147-ef2d-08dac1a457c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Rn7VllR6jKpKGGYF0vlCSQVTde47tBZE6XGPyPtjB7x1FCh6ZJmXvvUfdp6wgc5+eDWA3qHYm6OT1reiUhRqYpZ2y1aGc+riOjCeYiaqj9nM2xeOM/H1qB6LFojUP42Z5bK3OVD+fB31MEh1bGXA1w2vIxeGjWiP+UjtlfpbVUKJbac+1xIFmFlDVoPynpNPBFBTN8NhDKHxSP6sAkTryH3dBHHB6tVknDw0S2OxKRq4b7TibWyzf0E+Tqm0xSLa2QrQIv6sJeoLf0fKv74n0yjEWDB6SfIbc97CjU0fbjzGQ541I3R9iXBsS+7EHH4guHGRhexlKVMZ+7aH/Sxr+c9to6DzdmG2DXpjiFPExuyFX5g8GGi3wNMFc7/Yc39n1LXmE5gzvZMojnyImli1AsDxi+HoreSU/wo23fozRko0iPGCZxFgkXkYwHg48f8NwVHIJL8g0KIhzVlR2cTMwoRf4OrUMxelfHxnsN1MgK5lrJLryLX6AoBXck0SRGPN9FBOtL+sLOb2ViOV2m+lLRQOocV525igo2cbZRoPyctJZfYScwTeOMkgo+aaNF5ZhQuYuApVGyLfjh1eRdC1Ga+SkjXt6OouKc/JZkEcRgdNb8LeiOFsuguJFm0c8g4olU+cZiI5LaljlrvOIJ4wd5HgoPczPg+HJvpGSjto8tINnuXltoO8hl1L5Tp4AVHyHymuu9UH4Qtap/tN3HzR5V6DWM/KMFmG2AIrw0xyVLGSUQavh8TUMC+mMuZZKdggYD8AlobMW+yZfKBsk6ddOqwwICKNQ+WofTT9PVirO4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(366004)(39860400002)(346002)(136003)(451199015)(31686004)(5660300002)(2906002)(41300700001)(8936002)(8676002)(66946007)(316002)(66556008)(4326008)(66476007)(54906003)(36756003)(478600001)(6486002)(86362001)(6506007)(53546011)(26005)(6512007)(31696002)(83380400001)(6916009)(186003)(2616005)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dU9SYmk0RFhMS0licS9weTZ6ckJRUmZjbm12bGlhMHB3OEV2Ly83VEh6eDIr?= =?utf-8?B?NmlwVHJmaU9aV2x4ZWhFVitySE0wbjJ1c1dnYVJ5ZnBiUEFYZ0NFdDJLN0xo?= =?utf-8?B?NEEvTEtoUjJwMUZJRmZiNTlmUVBFMVVLa1FRZGVSc01yK2hFd1JuQzkyMkdH?= =?utf-8?B?S0RsUStEWVJpNnhVaDN2b3JvRS94THdiRk8vS1kyQ0pReDAzbmhzTVM1T1ZE?= =?utf-8?B?alc5UWw1ZnZsajQ4bUo5TGJKMGZYWHhsSkFpeFQzRzFKQTU0ZytCcW1wNkdw?= =?utf-8?B?bnZSWnVacFMzOGVxRGxwUEd0emR6amQ0OUlRSG02QStLWStTbllLVE14VjFj?= =?utf-8?B?SXo5SmRDUnVyRkYwaHcxb0gxbGVreDkvQWFZWXVUN3VDMDVVb3NYQ0ZONlRO?= =?utf-8?B?a3V2blpZUE1aTHgrTC8xSEdDeHdIRVBsVmt3bnJvZlJMblpMMEdkcWdJRnMv?= =?utf-8?B?a3YrTzZ5RmxkSzdVU2FBcEs3MThvMngyem1qZ3p2N1VlTVBJRXB5eGZGaTdr?= =?utf-8?B?U0RMb1BxREYrMnROdEpnZUF5cnBjUHhQRGxhNmRRUUJCNDYxaHoyMHJUcWhh?= =?utf-8?B?a0tpcWNzbURnWXVnVHZTRDNHMXpERG1YTUZ2TkhOYzJLVmFLNjlobnBCbk1V?= =?utf-8?B?UEVvMCtNSGk1Rkt3TlZUR0JMOWJRTjd0NGZQMjE4YlVicGFJVlJqcEdJaWhW?= =?utf-8?B?QUNLcmk4dWNsWEI2VzBFNTdVU3BzZ3kyODVOakZ1ZkROWVVOVVhqT2dlOWt0?= =?utf-8?B?OHRsVnJCVnJNUXpBd2liVm5TRGlSbmlSbS93bnUrdlhNQUh3a3lyM2lBK3pz?= =?utf-8?B?VU1OTjI5czN5K285QU5wdDAxaW90VmRXdUthUGwwOG5RRjlCZ2xJcGhGVk5n?= =?utf-8?B?cmkwM05OR2RBR2xEaFFuWUhkZU9rN2hkblBWMEg3dU9JTnZnNTlvWWRTZ1dk?= =?utf-8?B?cmJnaS9CMzJ3WjE1OWNrK2ljYysycHQ0S1NXejZEWVU3OCthNjNIRzhMeXg0?= =?utf-8?B?K2FqbmNzNXQxSmw1QzdTTGY0SWYwb0IrR0RSTWZodVZuK0RXaytPY1ZqWnlZ?= =?utf-8?B?Nk9HU3dqVFM0QjMyNmVtTEYxU1oxc25rK1NRc2lqRFhrUkxxQWRQWlhNWnUw?= =?utf-8?B?Q2FQcE5xbTVKN2lSQy9vMWZwcGZsTXQraVhFL1Z5aUdMNVNuaWR1aDlPRkNV?= =?utf-8?B?c0dNOFhOdlBTSlNzSmIyVS9sZTRHd1kxTGtBVjhEUllyY3cxSlNKd1k0NXhv?= =?utf-8?B?NkZVRTBZZ2crS0xtTDJMWGVTWE5Mci9ZK0NJWjV5YXFxR3htcGpvVEl0UGVC?= =?utf-8?B?ZG9UcmRlVzd1cWhMTy9jaUZjUXU5K3JLMlJYcDF4eDl1WURvUWRoak5OV0RT?= =?utf-8?B?WUpxeFpUaDZEaWppenQxcmt4dzh0N2F4SnMwc0tDVGtBT1kzeEtXRFhPd2wv?= =?utf-8?B?blkwM3hFOG90am1wL2RxVVQzYmFENklCdlQrU3VjRU5LVEZ3a1BUeVlaTjJm?= =?utf-8?B?bXVZdlFIWkJ5RVp4cUFTT0V1ZWYyQkVHZzdXQXU4bmllcnlCRTNMZW84WWpR?= =?utf-8?B?VkhYOExGd0drVnpsaEZUa3I1aVNRY1dUd3QvNW5YeWVvdW9TUktneVp4U0Z0?= =?utf-8?B?UDJMdU40Ynl0SUxpRFFJRmdWeUNQM1dydkFJanRrTEcrRFNrUWFBQkVRMmZS?= =?utf-8?B?TEw4QmdGVUI1ekFsZ1M1eVFhMlRScFNsT2N1OCtXbllMZ3phRnFHZmhqNnNt?= =?utf-8?B?bm5HL1FjWWYxalVKVlgxS2g2cXBzTDBIdlhWcmw2ME9CNkl1ZFFjWGZUdm5r?= =?utf-8?B?SzFxR2hnb1lnYVhGbWpXK0FtTFJtaXhabWtMTzlGdmxmMEJYWW9jaUlOdGN4?= =?utf-8?B?OGZlWUdYUHVNRjFNVzBDWWNQbHBrS29rOGE2am0zUW9KaFFsUC9uV3dNRVBq?= =?utf-8?B?Mno0REVDTlhHZkY2UDk4UnNUby95OThLT0hza2RFZzBCSXhtalNzOWllNzJP?= =?utf-8?B?N0prSmZqYlNnbWdaR01IeG91Wnh5UzQ1c3A3ajQyYVFkcFNiUytoVE00dTRY?= =?utf-8?B?NFZUVzZXQ2phRjZXeDRSQmhUT3djWHN2VDlRR0N6eCtuZWRsbTNXbEw0MEJX?= =?utf-8?Q?cLcf6IJzncbYZiv+6eXwewwYK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56fbfc0d-d8b2-4147-ef2d-08dac1a457c3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 16:14:41.8383 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZrNqzppsrmBzzSKnZZxOH8ul5hxfIfPdulP74/w5EhH9+G9cO16+9aU6HhmmP0Mhh8xOAl2Wwh3LaGB+T6tP6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8858 On 08.11.2022 12:38, Roger Pau Monne wrote: > Like on the Arm side, return -EINVAL when attempting to do a p2m > operation on dying domains. > > The current logic returns 0 and leaves the domctl parameter > uninitialized for any parameter fetching operations (like the > GET_ALLOCATION operation), which is not helpful from a toolstack point > of view, because there's no indication that the data hasn't been > fetched. While I can see how the present behavior is problematic when it comes to consuming supposedly returned data, ... > --- a/xen/arch/x86/mm/paging.c > +++ b/xen/arch/x86/mm/paging.c > @@ -694,9 +694,10 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, > > if ( unlikely(d->is_dying) ) > { > - gdprintk(XENLOG_INFO, "Ignoring paging op on dying domain %u\n", > + gdprintk(XENLOG_INFO, > + "Tried to do a paging domctl op on dying domain %u\n", > d->domain_id); > - return 0; > + return -EINVAL; > } ... going from "success" to "failure" here has a meaningful risk of regressing callers. It is my understanding that it was deliberate to mimic success in this case (without meaning to assign "good" or "bad" to that decision). Can you instead fill the data to be returned in some simple enough way? I assume a mere memset() isn't going to be good enough, though (albeit public/domctl.h doesn't explicitly name any input-only fields, so it may not be necessary to preserve anything). Maybe zeroing ->mb and ->stats would do? As a minor remark: _If_ you're changing the printk(), then please also switch to using %pd. Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 08 16:16:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 16:16:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440269.694399 (Exim 4.92) (envelope-from ) id 1osRHW-0002V2-Rs; Tue, 08 Nov 2022 16:16:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440269.694399; Tue, 08 Nov 2022 16:16:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRHW-0002Uv-PC; Tue, 08 Nov 2022 16:16:58 +0000 Received: by outflank-mailman (input) for mailman id 440269; Tue, 08 Nov 2022 16:16:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRHV-0002Up-Ed for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 16:16:57 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c228da3c-5f80-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 17:16:54 +0100 (CET) Received: from DM5PR12MB2504.namprd12.prod.outlook.com (2603:10b6:4:b5::19) by CO6PR12MB5427.namprd12.prod.outlook.com (2603:10b6:5:358::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Tue, 8 Nov 2022 16:16:52 +0000 Received: from DM5PR12MB2504.namprd12.prod.outlook.com ([fe80::ec49:f96d:d3f2:79d1]) by DM5PR12MB2504.namprd12.prod.outlook.com ([fe80::ec49:f96d:d3f2:79d1%4]) with mapi id 15.20.5791.020; Tue, 8 Nov 2022 16:16:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c228da3c-5f80-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4dahvRZzffCIs2zRTYKUauC2D5ftLPfDd1na2/OkKyspqHiq5w1zyh7hVDwZ5gCC3JUXLnNb5jriZW8KQKw03jOlMQc9WCovl/6AIlHDitsxEqN/HRZctb1N8rizP8xyrwwaLefis0NTim1H6ZZL4+KaT/b1M0s7Lk5DRL3Nsvvq/HTjiBpymiZmNDWWjqLPBBiqgLArNLUP0XP/QbglUZ1YT/lqTsvVbtDopOXqhM2ZMNEe+ETq9Qkh0UiYg9t8hUcYj0ziiuJShxNlSDIg6oy0NsNXSMgvADTrYHUSAH9ejrLha9KpMfRHpOxuQrlnnh/DeutBuBx3Y8K2SaD7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DipKu9PihlKsrzJFJk2ibqYsugR4ikhWtCKE4PjQcTk=; b=PFXQh4kOXdi0bbQswjWjMPfkhKg/S8kr7Ma0adM85f0Ao62XXHa168GqGn0TmFVEklFy0mWbtBJcbc5qre3mUhPQ3rnLIKQUbZ6k03I8J80+0VALHuql+YSE9L+ZG9TgxiSRilpUVcu1ndLkjq13L0ecl1d1YuPcTc+0SYwCm9YJl7XPOSp/awyeEvr4xfT0ZBQqKM9xD9tn47d12VdpYwx1kwJ+RT0F73yxp3F9FmRai3wgFCFqq9n/7GybdB3CQ00ZD9eTUavW1ZkaAxH92shn63LV566NVT0T/7whcGL4uxejyHI2+6rEiTQlt31vQqOtm86g+aWCPAxZ07nsdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DipKu9PihlKsrzJFJk2ibqYsugR4ikhWtCKE4PjQcTk=; b=FDmNTra1uvyPp8Y3eedtrXH1j52vNcjtT8Q1bhPnxn4ZU7XNtsQ8FydOtH6gUrNnZTQzsioV5e562B16Ggm3miqu7KlKOF5Us3fLrx5wUkw3dd3kVHIw9KuYTn/bmaPPTI8b+MEXV2rztMehSso6GDUT80EJYaOXJEgp1x5RH9Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Date: Wed, 9 Nov 2022 00:16:30 +0800 From: Huang Rui To: Jan Beulich Cc: Roger Pau Monne , "Henry.Wang@arm.com" , "Deucher, Alexander" , Andrew Cooper , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present Message-ID: References: <20221108135516.62775-1-roger.pau@citrix.com> <9b785cc6-2de1-a522-9e57-62c0421c6a21@suse.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9b785cc6-2de1-a522-9e57-62c0421c6a21@suse.com> X-ClientProxiedBy: TYAPR01CA0212.jpnprd01.prod.outlook.com (2603:1096:404:29::32) To DM5PR12MB2504.namprd12.prod.outlook.com (2603:10b6:4:b5::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR12MB2504:EE_|CO6PR12MB5427:EE_ X-MS-Office365-Filtering-Correlation-Id: ffe2a025-666c-4882-059a-08dac1a4a4b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lfi9lqVl3+yXisIAue9Hok+6vKZIsQ0pBYugKIxpfDaQK6zF9T0ZT3t6McwIBcWiXs8/naiXFQPAkg0BQ3umOqIHUFdd327PYHnWlEd2P2cihYXIaxXAncIqC+5VwkASUhWpzI2x5uKkkRwjd8MjVNMiMok9cFKYfHsYBZrxdccoguFXMXjukoPve+geIZkLDR2McxVPHkZ6miezHUVG6gHgsH4zFvhJ/DWun2vsm+ZPADWmCY1aMM+wCioAZwg7jqliWc5NW1YlsHkghQQiHqCyuDy21ML17xdl5wjVN6BxqchddCoxWrEeLTkGDbf4Nqu60Do7Amv9dD8rfYZ5pjGUe9QBnIlVbFF0eC9EKhimzJRnzxGlxbC4ZsbqE/GgxOl7UfhxqFJJLCv1Q9hLVQkoDCkmtNg8dlbnBYDbHijUSt9Xp3T3KbLeKC7MkWrKuokWcnbtRP+KgpwuZQUIq4hScOYLj7JUrqTrZZ0q4Y0IXvmthzoKs8hn3FxP4NHJneM/jLP1DkxKifkoF5L9/M2dr0DYX5J+3LT3UE4rVHp9vusMIKlTlyOay7F+w7xRwtw9EQ0QzpfhQPJ+Z/3k4NCl/ZTvvl77cifv/fg5SmCmqPvkwFBXeSNIYm7UUVxirxfFnwDblvBCgqR1WXjQaQQXuZm/32+pPDJaeevgUn4SJ7bX0vA6ju20hvFnRUK29wCa58iIZty4GIW6QcIjeobMWxOg2ozVsdTcqFxvaQwlRTVS8pASJ2JCboeRMymF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB2504.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(366004)(451199015)(36756003)(6486002)(86362001)(2906002)(6666004)(6512007)(53546011)(186003)(83380400001)(2616005)(26005)(52230400001)(6506007)(66476007)(66556008)(66946007)(4326008)(8676002)(45080400002)(478600001)(6916009)(54906003)(316002)(5660300002)(8936002)(41300700001)(966005)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?lFTrcNa+StBDw7ue1pNURHvZEeO9ZmQIp7jOiLngmHQsSPRGYaImlmgJRo?= =?iso-8859-1?Q?VW/Hyzw0xjRnPNua4zfwF/wwombRgmEQusHpQQhnOxaB06nCh+JqCexylW?= =?iso-8859-1?Q?+5jhMRKzQYUdNDQpWwHM5kkvrbJmZD3xXIVXQE8Yww06j6OFHCWfWjZASE?= =?iso-8859-1?Q?8qYFIXvZPD0nA648pw2osyy3igCN9qpu3Mj1AQDaS3mknUrdhvDZqhaH6+?= =?iso-8859-1?Q?npSUiuPgh+hMzBeD7CK6HlXxth9krmqVAtS9BqWJcNTrY835ByaPjdGqju?= =?iso-8859-1?Q?Y3lgx+PUx2WTR1CNTj+z6a9ceBiNvte+zlZUPDXLvuHQn6Em8lFXvQqhGG?= =?iso-8859-1?Q?bn9XgefhGBNaYnR2sCgYb6oXvbWuajIjXxqrE0ip7BqdjdwGe7dZ8i6gBy?= =?iso-8859-1?Q?CT2gQLJUeV53fAPGDxILMREAQl+F2KfoRDr1lY4GTszs/lnVbynjFzbOCC?= =?iso-8859-1?Q?N20GJBBIKwDaVIsxVBK6d40+P5w3DNw/EYPVide3cCZ37aKZhZy4HfVEMs?= =?iso-8859-1?Q?sjs7unqVBkgslXJJSqYXJHHjVEN1pZXw7sZH1trmvXyq3PR1WRv+5uQRQT?= =?iso-8859-1?Q?WsVqMxBkZeVVbtzKlBixK0QTjuXBGVMzMEhw+Q76Wl+RQp9nEhhduce6uR?= =?iso-8859-1?Q?VzTE9i9+GIWR2Ca/+zCoKuomp0nP2eBB28+NF0bW99IuvsjSR2sSUFtC5G?= =?iso-8859-1?Q?PnO6Z8CnbOrBif1d2COegjo+iQwB1UDXf0Y/jYXFT1nNVzgikIFP9envTL?= =?iso-8859-1?Q?Ifw69mOrb5g5Z8tPxU5Vp8Ace0RUlTIDOf9NFhWAes8QYgzvoCwaSwthSi?= =?iso-8859-1?Q?qAJvgCaRAFerenEyEnVI0nFv6hJKh32WnfkLXcJjB/wHDtafe+7EgaUY+2?= =?iso-8859-1?Q?AgSVOupcrf7FkTPKpuyAcb28bZlNT+Uw+i8nbjqNNfw8J5fBO2j8UWPcvf?= =?iso-8859-1?Q?ssxgF/NdBTKtS8hlSE0rPysGs1ofUq56qA87Relhg/Oi7dXlUQh2U8W3jw?= =?iso-8859-1?Q?fNqqQ13mvwR4d2jKaW+Sk/yGV5oHpR7Pqni1L9t6jGOkXbmDpNEJ/lDjoD?= =?iso-8859-1?Q?vBvt6ATPKu+XKvk8Ag/2FohnuygFoT0rAfbZSKYT/y6QlMxtsYEmpB5Utb?= =?iso-8859-1?Q?cNbx19CwJk82MmV5xNLz4EE9kH4w20/vUZk9fS09sA8TK3WFn509BrmVg7?= =?iso-8859-1?Q?TqkvmMnt4QTS78Nbc02pJz8PsgoAjIqVUDiVejAju7qe7ySnWLsNpzhkxr?= =?iso-8859-1?Q?obQPUSPNZQA55jet47yGDZItjeo75wEcJJql7YC/ZBXkplbCj1/cTi8mwL?= =?iso-8859-1?Q?FAGk5qZPWdX+w5ZclDCqbyvaJW/yOIHT9s5S3MjTZ/5kXceTomvjufFtDL?= =?iso-8859-1?Q?uQxAXXPJVGPNuaV312KnGa8qYh70eNOyhtfuTXf58c2DJYsr1bGn2UcDsb?= =?iso-8859-1?Q?fRm7yvHdLym5cwHzKDBIihcQoR7nsWiPg8k17aiRWIQMsdrjfhmg7ahLfh?= =?iso-8859-1?Q?LGPop5gfhV73otQFeSw28Ykp5u0PYFkUlR/ounZGCfTHeIH2t7VKwPHciL?= =?iso-8859-1?Q?JaC9FKEHM+vhTWv8UvKchKFYtoDjacIxi0NkAxM48MdYSQqn5bhJSV8u1k?= =?iso-8859-1?Q?Qdrxpnefg/plxb+f4KtwwpwGKNCyob3x9K?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffe2a025-666c-4882-059a-08dac1a4a4b8 X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 16:16:51.0698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QBx2dM/dZApUNeZQYLK6cstmYDmpSD0yOafkxnh+/qqADOW5MLLqcnoKQAbMhDnB0K8hPeDBl438hOv9O/26Fw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5427 On Tue, Nov 08, 2022 at 11:56:17PM +0800, Jan Beulich wrote: > On 08.11.2022 14:55, Roger Pau Monne wrote: > > The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image > > from the firmware instead of doing it on the PCI ROM on the physical > > device. > > I can't find any mention of VFCT in the ACPI 6.3 spec, nor anywhere > under Linux'es include/acpi/. I don't mind the addition that you're > doing, but there needs to be a pointer to a sufficiently "official" > spec. Thanks! In fact, this is defined by AMD atombios (VBIOS), we have up streamed this in the Linux kenrel. You can see more details here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/amd/include/atombios.h Thanks, Ray > > Jan > > > As such, this needs to be available for PVH dom0 to access, or else > > the GPU won't work. > > > > Reported-by: Huang Rui > > Signed-off-by: Roger Pau Monn > > --- > > This is a bugfix, but given PVH dom0 is still experimental I'm not > > sure it would qualify for the release. OTOH being experimental means > > there are no guarantees it will work, so the change is unlikely to > > make this any worse. > > --- > > xen/arch/x86/hvm/dom0_build.c | 1 + > > xen/include/acpi/actbl3.h | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c > > index 1864d048a1..307edc6a8c 100644 > > --- a/xen/arch/x86/hvm/dom0_build.c > > +++ b/xen/arch/x86/hvm/dom0_build.c > > @@ -924,6 +924,7 @@ static bool __init pvh_acpi_table_allowed(const char *sig, > > ACPI_SIG_DSDT, ACPI_SIG_FADT, ACPI_SIG_FACS, ACPI_SIG_PSDT, > > ACPI_SIG_SSDT, ACPI_SIG_SBST, ACPI_SIG_MCFG, ACPI_SIG_SLIC, > > ACPI_SIG_MSDM, ACPI_SIG_WDAT, ACPI_SIG_FPDT, ACPI_SIG_S3PT, > > + ACPI_SIG_VFCT, > > }; > > unsigned int i; > > > > diff --git a/xen/include/acpi/actbl3.h b/xen/include/acpi/actbl3.h > > index 0a6778421f..6858d3e60f 100644 > > --- a/xen/include/acpi/actbl3.h > > +++ b/xen/include/acpi/actbl3.h > > @@ -79,6 +79,7 @@ > > #define ACPI_SIG_MATR "MATR" /* Memory Address Translation Table */ > > #define ACPI_SIG_MSDM "MSDM" /* Microsoft Data Management Table */ > > #define ACPI_SIG_WPBT "WPBT" /* Windows Platform Binary Table */ > > +#define ACPI_SIG_VFCT "VFCT" /* AMD Video BIOS */ > > > > /* > > * All tables must be byte-packed to match the ACPI specification, since > From xen-devel-bounces@lists.xenproject.org Tue Nov 08 16:26:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 16:26:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440279.694411 (Exim 4.92) (envelope-from ) id 1osRR8-0004FB-Q5; Tue, 08 Nov 2022 16:26:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440279.694411; Tue, 08 Nov 2022 16:26:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRR8-0004F4-ND; Tue, 08 Nov 2022 16:26:54 +0000 Received: by outflank-mailman (input) for mailman id 440279; Tue, 08 Nov 2022 16:26:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRR7-0004Ey-6V for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 16:26:53 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2079.outbound.protection.outlook.com [40.107.104.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 268a307a-5f82-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 17:26:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB8042.eurprd04.prod.outlook.com (2603:10a6:10:1e3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Tue, 8 Nov 2022 16:26:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Tue, 8 Nov 2022 16:26:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 268a307a-5f82-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ItiLh/5psAZMOH05DdHITWuIMLdm+mKtg0NQAMzBq4p7HET/9cw9lzGdEKzW2EKxYUwlm+wUaPLTnPM+3OMO75K8KphTZW0i+AAH83SkDkLnZHbUbvTgzwvEzrK+FR6hKxB6FnwOjOnSc3N857Zp1FSTMgxT93XXu663gaPtsQQoFPLDsHHbHbwYnAqxDl94svP5tmy/1BuZ528cFV+2dTZW9NFgRU3g1c+sLSB7hR5pP3eNAufDAcfGQ4bdTfLw+4YpmwZGeOjnJmPzpfyyS3dDK1+TLPYRhj+ng9AYXx9zM4WEF/e6GnxbgaTqEDbZdhpMmlK5m9BR5c35FgIFhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uAXhsaK+O3tLaR3xyXOR3ZgFF+JyPfWygz4BOPrUTyI=; b=GtbCdtdg7eLMF9Mh60OLg6yo1TF8YcOB6Kk0+jgEYGvSr/X9qknOMIKapmLrvdaUsFj6yra5TiRcKE3vLlWjrI3+nuGfbhIEz1RVcSgJBlvv6J27slASQ9wtGsToPYVlKornkLqFPJD+hfObmXpwGhJAp8JpsGIZRPDyQJMcGWgYPZEnsySeu//jD+fPvQABI984WUWr7E4W32bCNRI2UypFOHmEnmIIto8SXEHtU6d7o7rJzHv26J3d5nElPi4YbLNOC5J9H5KZ6G/jFnAYiDkzLvC3tuss5d8thaXW5VXP8KcWQWnw4XAPzDDIRXKcnv32+oesx3OcKbxTWC2/ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uAXhsaK+O3tLaR3xyXOR3ZgFF+JyPfWygz4BOPrUTyI=; b=pZlKYBlIGxVHxY2Nh+pBy1S2Xcl/ic7AU/MLBMUpq+3K31vdv3BrinCM2tHcDcnSRSzqO5LJT0XOjs4ibAw4wlv2NN5lQ9Wn421fD4DROvey+MXrZmphNt6xfv66+QDwXTIHA8ePUzFGqTGOTBKzFa7kibKVDsuur1d8IabgXoEQpYhjkj13WH8LE6zYgYtTVZnlXueCGyZ0S4RGyPJgY7rFzxAZHhhgJ8dYNNqPA3K2+KqkXgSsWvsxYn9/FSwkdHKIZ5zU+bqv0FWTYNFQdwj+M0YajLuv3BIg9NpzpqomEoWdO23ovH2Nmjh6Pi+dqFYdYMp4g1sGbvOfNLmJQA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9ab99257-844b-de15-cd20-7cda61295186@suse.com> Date: Tue, 8 Nov 2022 17:26:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v4] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Content-Language: en-US From: Jan Beulich To: Juergen Gross , Stefano Stabellini Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Oleksandr Tyshchenko , Maximilian Heyne , xen-devel@lists.xenproject.org, LKML References: <20220729070416.23306-1-jane.malalane@citrix.com> <1918c63f-0065-b468-3691-de6e314f4374@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0144.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB8042:EE_ X-MS-Office365-Filtering-Correlation-Id: 30945652-f8ac-4649-07b3-08dac1a60934 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eyPiagfpf2Ap/vTo7UcoggFEy8UuyfZi57UGQCSzmTsjVfdZSZfMNmOkJkKDxeCukmlNG2xAwSDW9cGW26Ast6HJGknj8MciE4TGPBdFzRdlFnqd5Dv4dSLC90jL5wS2/bLvQGV2iCc6biI3O7aELUWs9MQ84Q7He32q1vp6oPiE20Z0u7bIpU23GGnNQYuGzkEpTnumPc6TrTH8AeDiYzwilk9eF7l+7SHGuPHngEm91/r73LFeb1IgkEwn5aSaZKlu7knQVQUAHGz4G1OkZcbS9TmMKHr8Jt6k7Bng1W2GXhQ5+vxUiN3yrUg4AC82083i8Adr24eIB5haTBGgWMEd7J2HWkfvA79erHqwlKCV7oQzAP63B4mgyt7TcPo00xEeqbyT6LsQLgHTI+NL7NQt0fymRKa+z57r0Kb+wJnLcD8SbHceyrBjXwRiRXxhQytCheHWbHOs/gbGLSI58Wz20d0WsDo5zsNk6+aFcAD4DfgHQQo8yLWPxowUMkH/iCaOxiZmeo4YaaCvubcYSwSTmaOn3B+M5VN4KVxYPQnqn3rn2emPSgyxT8zG4BcTC5yzyW60oeOrImxYH8iQE2HFCxEDoj2U+cgqMgBZzz5AvelDBEiOFAJSm0JxReEHt/TjyOQXu67dkbVJJXPV9nA+nCz+B+kcRoPtPSna5VjP+E/+Fq/SkNIuKiVMoPFYDju43qP5ICodO0Kz3KlxG2FZjEI8pHw+W2GMYHXPZrZxkf/8pXo8LEUaEJkiJIqLdxS7MvGYxv/cQ1FUh49L4MWVCcrE2+giaewJ64IcFLLEjow8LJXzyl8VdW8lVpk/flu/9wj4VirRJnvKYo3e7w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(346002)(366004)(39860400002)(136003)(451199015)(83380400001)(26005)(6506007)(6512007)(53546011)(2616005)(186003)(38100700002)(5660300002)(4326008)(2906002)(7416002)(54906003)(966005)(6486002)(478600001)(8936002)(8676002)(41300700001)(110136005)(66556008)(66946007)(316002)(31686004)(66476007)(66899015)(36756003)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEl3YksydDM4bk1ZckRUL3Y1b2NjWlo4ckRnZERIWmJjUTRGc2k1WkZuRjdF?= =?utf-8?B?ZjAwVDgrTEMrUXNqSVpCa2RZeXY5UVpVMFNlaDF5M3c0UlI2OGpIcTNxaUJF?= =?utf-8?B?anpCRGprbnhubTNxNVpSZFF5ejIyTjJReWd2aUlONjFtMnkvUUVaNzBUNFZx?= =?utf-8?B?SitYSVFVRnRoNXJrR09qaUl1VHU3Q2FyRlRPY0s5Ykcza0w3TUJoeGZNTWU2?= =?utf-8?B?RzNGL1d5VFVJbFhoUjVHRjJYTytmMktoVWdzSDJLQnBLMDdvcVhkWWk2ZXJh?= =?utf-8?B?MEZ2WmdrUURtOUR0c1NDWDU3UW9kTExWbWpNSFhZNWU3SjBOWU5RYTA5d29X?= =?utf-8?B?Sm56OGovRmFZVFY1eUwybHBibjF0OUpKVlhuWGsvUnRUWjRLNlVoV3dlU2FJ?= =?utf-8?B?dURkNkk4a0ZFUGk0WEEwZ25haEQrMjBQOGg2VXRxL3ZoWGhEY2Z3Rlkyb1ds?= =?utf-8?B?QjB4bmVRU3BMYzhHMnE2cWZUT1ZKSC9WUjNZT0xmamROZ3hHNUlPdlhndjdF?= =?utf-8?B?Q2FJYjR4Rktjdm9IU0I3aFEySHpiTmVqaEFqT1BsTXJnUEd5QnBrbnlqc045?= =?utf-8?B?RG5KLzZ1aUVKcFBBZWVzUldtK2YzR3lIWVNXVmNjN3VSc3drT25QdEtNWXU3?= =?utf-8?B?Vng3MEZVdWZHbUtYVm5ZNXdFTDBhelNlMVlEdlpQQ2FWOG12Vm9ZT2pwWWdO?= =?utf-8?B?MjZNT0ZiMUs3Yko2TFAxWU9zWDJhSjNMUDc1QnR0bDhmdnZTb0k0a3RvbVor?= =?utf-8?B?YWgzcGlLWUp4MFRCcTRzUFF4ZE1NVFVxT3pEOFVScHNlM3ZSTTB0bEw1REhT?= =?utf-8?B?dlJIMnR2YmZoQnoxWUpJYVNzbUI4Um80c3lHUjB5L2p6YXYzRUgxK1RWSTVz?= =?utf-8?B?Nmc1YUt0ZU9qYmovMnpXbG4vL2E1VU5nK2p1WHZhZlh5czhESDhRNDhUUXY0?= =?utf-8?B?T2pjNDhoMS9pU2lwQTdVMktMdWVMTHpJSXlFTlVIUEhmQUhHUCtud3JjdEhn?= =?utf-8?B?bWRKZFlmL0IyWFU5MDliYm1aeERvbXkxSm1nS05VSm51clV2aEtaNlN6ck5q?= =?utf-8?B?ZU9wTGUvM3dxdEtlOVd0NE5kclpwZVdVbXJUejhwZ2FyZFh3UkRjS2ltNTA3?= =?utf-8?B?NkNNMkdpdGREZkJ4VWE5anpreXpMSmZEemRDZVYxc2pkdEVoUld5RWJqRzE1?= =?utf-8?B?d1VYU0NicWwzZzM5N0VudHhQQ0lNQWFPcGs5Zng3a1hVU0tZcDREZzRZV0xx?= =?utf-8?B?Ui9XV25mKy92Q0pwK1dTZHorUkk0L3Z1RXVRa2M5NEM5YlFlNWRHQWhvRUxV?= =?utf-8?B?TWlITkkvWGo4WUVLdUhyYnRleE5OUG5wNlBraHA3cDhwaStKd3d3OURMSk9J?= =?utf-8?B?TEhBWGQ0VjI1SFJkL0pYVFdmL3VVODBETGlKT0VQSy8wUXFKWVpBVUx2S2xs?= =?utf-8?B?T2Izb0VGN3RjcGdvR05aQ0ZtZlp6Y1h1TkF4eWZCMjkzdEVnZ3YrOXZWL1NF?= =?utf-8?B?S3FlY0pRWEtwVU1XeGFkUmwwejVIUnJEU0wrSjVxU0h4UFhabENrcmx4dC9U?= =?utf-8?B?Z3Bad2xYRURwMldWQk5oeTlEK0lzNDNKTmlBNlVwRmZFZ0t4TU9Ka3MvSkcy?= =?utf-8?B?c0dlVEdUSDgzOFNaTll3UHpTZlppQnhSUkR4L2QyVXROWnFtUFFVSGd1Mkdj?= =?utf-8?B?MTFxNlp6Q1FrYUJHTFgvYzkwLzYvaGpQZVEvOHNFUlB0OVB4WmxmZkhlcGhl?= =?utf-8?B?T0NvQXgvVzBxU0orQ2R6ckZ0L0hmaXFLM2pSVlZoZXNGcVd2eUtUdlJYZVBz?= =?utf-8?B?d01ZZ0VhTXJRb2ZhRWtiTEhSZmpranMrbmVUMkx2RzdzVU93UjJ5Z0RKM1RH?= =?utf-8?B?ekZQZitLRCtKQUZaSy9xUXNReSsydERML0NrWk1Vb1JzKzZvNnJLZi93UVha?= =?utf-8?B?a0lkdUNGY3M0L0tBY294Rzk4Vnk4OVlva3RPbGhqR2dJM0FOQ0o4WjNKSzFY?= =?utf-8?B?bUZtdFJYUy8vdmNoVVJaVGlRbEZka2NKakpXQmFESWo0VzJyMXRxR3YrVWdi?= =?utf-8?B?OGdBRlBZSFRnMzlDTjZkekZMN2x1NFdzeWVTQ1BlSm5ySEhJcVlTVHdUVlVL?= =?utf-8?Q?PQdmzKOIHbyMgMEDbvkwNLHO3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30945652-f8ac-4649-07b3-08dac1a60934 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 16:26:49.0889 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vyuiw8/TNV/DaGFR1538DPSaSCgxpaUw6cte0x2qQIzUZGFgnXRQtMox6zxMCZFErHcmA5Tn2B6H4LFGVSVreQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8042 On 03.11.2022 16:41, Jan Beulich wrote: > On 03.11.2022 14:38, Jan Beulich wrote: >> On 29.07.2022 09:04, Jane Malalane wrote: >>> @@ -125,6 +130,9 @@ DEFINE_IDTENTRY_SYSVEC(sysvec_xen_hvm_callback) >>> { >>> struct pt_regs *old_regs = set_irq_regs(regs); >>> >>> + if (xen_percpu_upcall) >>> + ack_APIC_irq(); >>> + >>> inc_irq_stat(irq_hv_callback_count); >>> >>> xen_hvm_evtchn_do_upcall(); >>> @@ -168,6 +176,15 @@ static int xen_cpu_up_prepare_hvm(unsigned int cpu) >>> if (!xen_have_vector_callback) >>> return 0; >>> >>> + if (xen_percpu_upcall) { >>> + rc = xen_set_upcall_vector(cpu); >> >> From all I can tell at least for APs this happens before setup_local_apic(). >> With there being APIC interaction in this operation mode, as seen e.g. in >> the earlier hunk above, I think this is logically wrong. And it leads to >> apic_pending_intr_clear() issuing its warning: The vector registration, as >> an intentional side effect, marks the vector as pending. Unless IRQs were >> enabled at any point between the registration and the check, there's >> simply no way for the corresponding IRR bit to be dealt with (by >> propagating to ISR when the interrupt is delivered, and then being cleared >> from ISR by EOI). > > With Roger's help I now have a pointer to osstest also exposing the issue: > > http://logs.test-lab.xenproject.org/osstest/logs/174592/test-amd64-amd64-xl-pvhv2-intel/huxelrebe0---var-log-xen-console-guest-debian.guest.osstest.log.gz I've noticed only now that my mail to Jane bounced, and I'm now told she's no longer in her role at Citrix. Since I don't expect to have time to investigate an appropriate solution here, may I ask whether one of the two of you could look into this, being the maintainers of this code? Thanks, Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 08 16:31:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 16:31:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440286.694422 (Exim 4.92) (envelope-from ) id 1osRVP-0005iV-IT; Tue, 08 Nov 2022 16:31:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440286.694422; Tue, 08 Nov 2022 16:31:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRVP-0005iO-Ey; Tue, 08 Nov 2022 16:31:19 +0000 Received: by outflank-mailman (input) for mailman id 440286; Tue, 08 Nov 2022 16:31:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRVO-0005iI-RB for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 16:31:18 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c41bde6c-5f82-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 17:31:17 +0100 (CET) Received: from mail-dm6nam11lp2177.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Nov 2022 11:31:11 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM4PR03MB7016.namprd03.prod.outlook.com (2603:10b6:8:43::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Tue, 8 Nov 2022 16:31:06 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.025; Tue, 8 Nov 2022 16:31:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c41bde6c-5f82-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667925077; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=UR7nYv4wkV+moA5NLyGn+XW0mAT8ssHH92M59HG9MDQ=; b=dcHiaROMR4j+fkFAz+9wkuIMVINWeavAMAS/074B3nKa1UwIePcFD9HQ keW2lwTkZFqfjQI8DPc5BGBwF9zTdw0tAJGfwZZdQyugk8bvf9cEmAB6o fEDu2HVLa04NECI3yOiKdLYD+1+ZXPimjcQ1wwGY5ToBvy0RUeLuP8Rqj 0=; X-IronPort-RemoteIP: 104.47.57.177 X-IronPort-MID: 86941226 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:eGBJb6umyvbpC4QXNhBzqBZTpufnVLdfMUV32f8akzHdYApBsoF/q tZmKWuOaayJMDHzeIx3YI6//EIHusSBmNJhGlBv+H0xEisa+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaGxyFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwJRIQMQ+drtiNxJmiY+19je8hIO20BdZK0p1g5Wmx4fcOZ7nmGvyPyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osj/60b4W9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAurBtNOTefiqJaGhnXN63ExATI8eGCeqNTphw2XGO1+O 1Utr39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooL07gCDFy47RzhOQNU8sYk9QjlC/ kWAjpXpGDVpv5WcTH7b/bCRxRubPSUFJGkOaDVCYQYY6Nnuuqk6ix6JRdFmeIaqivXlFDe2x CqFxAAuirNWgcMV2qGT+VHcnynqtpXPVhQy5AjcQiSi9AwRWWK+T4mh6Fye4fMeKo+cFwCFp CJdxJfY6/0SB5aQkiDLWP8KALyi+/eCNnvbnEJrGJ4isT+q/hZPYLxt3d23H28xWu5sRNMjS Ba7Vd95jHOLAEaXUA== IronPort-HdrOrdr: A9a23:DKrbR6l70rZJJQ0uOGvVLGfu5VPpDfPJimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtND4b7LfCRHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaFp2IhD0JbjpzfHcGJjWvUvECZe ChD4d81k2dUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInpy6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zUYIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6R9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfF79tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmcoa+d FVfY7hDcttAB2nhyizhBgv/DXsZAV5Iv6+eDlPhiTPuAIm3EyQzCMjtb8idzk7hdEAoqJ/lp X525RT5c5zp/AtHNxA7cc6ML6K4z/2MGbxGVPXB2jbP4c6HF+Ig6LLwdwOlZGXkdozvdMPpK g= X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="86941226" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b3NKTVMp1OPGkjbRed4J8s06fio1dPPg0F0DiixGw1js2jiCVNj06KU9TJqCmJu1TOVHvwkMB2IYxLT4nMbsvw6oHU+yK6/gGL+QoOL75KWzo7N7SewPhbcKzrl4Kt3Go0YyqlzI7CiiGLIciDZ4q4EaOnWs0tUMIRMS0OevWBQln0+SWKxt6Hc0u8NfNMwIItuOBICPwfhtfhhluPGQxDrPZeyUiszfo6k+7esT6OZ+THvdQAnRkcEWChFjszcrve8nSeDrxDq8/AU3F+r8iABaodrLSrKyIoXIUCBqMt3kZcUHt3ADU7y0IB5Z1UW4ykKhIP0p1LRq8dsJcUk8hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MCr1oadcfWGK45oMv4NUb/v6MJ1I2YBBEM82sMNZl2s=; b=CcAQWmtogQQ4ANqruhPFtL6vBqtTc4fbdoQpubktPiKsoP5tSKMM3dxW8BAGfAjxjDja0Bvr81jB2hnvFD2vvO1unLoaR1BjoGWlQsby5JOQBnqnmNn0MZSnxbj6Ey5vPVF32BZbhq/FsgdKb2Vx97f3AfFc/3/DNSmkjnT/YlGN0RYG5hO2K2IsK8dvUb9Lw4BqXCFD0O6K7sbeNkWRfySVOwn17QrMB6zyOWdY9oQYNZxfHMoUlESK0/scZUHVGxTFj2SCw58cYiZi4lzPTig6FfS9m7li6y3hY7PzwxB0bm0AGKoGlQ9bH9OPzwBQC4wOmnqvDzWCL3b/tvk3Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MCr1oadcfWGK45oMv4NUb/v6MJ1I2YBBEM82sMNZl2s=; b=muxOysh+HuJ37b0sFiQUEsZBgoo4hYQ7l2r3DiutPpQW62beQP5PhD1gbh0sQGYv/3pjAYXfxNM5oakKtjhR/rd2Vh66w1RtULgpptRPgQdXU3GnmcAkxE0ApZnZs4UdwXmF4myqhbUb/BtDfUcxP2SGB1O0eHp7vh6XjbJ681U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 8 Nov 2022 17:31:01 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Henry.Wang@arm.com, ray.huang@amd.com, Alexander.Deucher@amd.com, Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present Message-ID: References: <20221108135516.62775-1-roger.pau@citrix.com> <9b785cc6-2de1-a522-9e57-62c0421c6a21@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9b785cc6-2de1-a522-9e57-62c0421c6a21@suse.com> X-ClientProxiedBy: LO4P123CA0471.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::8) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM4PR03MB7016:EE_ X-MS-Office365-Filtering-Correlation-Id: c3a52f6e-cc16-423b-f0a6-08dac1a6a29a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ht5Kl0UPxxj1bNGyApa4Xx4lSONBcXx7gswsmF0d6odZC9tfEsIVzQP0Gn8TNrhSXKH5KErt1A/SOuozTaZMUFNLfdvku3hTD0AHJlRfVe4IrMpJeFqI/uCHvJTGYMsW9NqXT1Xf6hpdg3YRzXoRx+IVANGxhWk/CtzN98vC9+9GaS33AIub+NEPbLcgw6MM+QypR6YMsXtyJNNLofNBLveJVETrlgmdw7aYmsTfeQGSPaqgE6YN4rTVYBF9WKpQVdnVkOxTs3/YUECjCnJbo8IsuioL3Hz3vLfi6wAitWKUMLITK3FrMA5/d5wMvjJB/qsTovmn0Qf7AYMD3bpKDPOBRiXkYRypkjuqWhvewzgqzxe1YWuK2JhMdxJk2QegbjsDT1jgILrJqT+oBGPkfkvjzSMRDGUWR1qbI79etLlv7Ijmwcurz7jRMSVsbtoKzhFDCavw8+70G812wj6OS99TbBxfvdtN2uSPxaF78OQqOUPzVe28b7rM4JB0hseJhIjbRKbwzzv1Fc8PWL/utgrMGGurnpSqfOEneW7FUqz92K/5p/xusos2duIRxH0QdpDB8U+H1HspnttIWXN50rGw+nRWt4+pZSUxgQ34RtshRgoyl+CPQvzVb0rJv8mcXZSD09zW2srZrpBoMuoFUn9EssEEtXz9r0lolv38lPy6i66V+if0Cf0pj5s956INmJ07ypBI+BqyK/VaSZ7jVUtaET95ZTWUsfTI5SbLjRY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(376002)(136003)(396003)(346002)(366004)(39860400002)(451199015)(186003)(6916009)(54906003)(6666004)(316002)(85182001)(86362001)(38100700002)(82960400001)(8936002)(6506007)(26005)(33716001)(6512007)(53546011)(9686003)(66476007)(5660300002)(41300700001)(4744005)(4326008)(66556008)(478600001)(66946007)(2906002)(8676002)(6486002)(966005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y295Z25mTVBXNTU3RWZGekUrb1RnbTdhUkExbDFQVFBoazdHemdjaE8ra2sz?= =?utf-8?B?ZmtrS2xjUDIrVGp1bEFOZnE3UUtWbHJreFZpOVpWd0FkdUxpelRieEtHM3V2?= =?utf-8?B?Vk1Ib0hOMHNPSnRkWGkvZ3R3MHF1NDc4aFB0SjVzY2ttL2xvOWVxUUNISWt2?= =?utf-8?B?Wis1dEdkRm1DNmJtYytFL3A0b2l2Z01IaU5LYitDb0pxT1NNMGhiQTJxZE1O?= =?utf-8?B?Q1BHVUxYTWVNMWRrbUhSazhuODJJUGxYeXcyZG1YcUhWQmJsYnhBbTMvdkNP?= =?utf-8?B?WmtRRWhUWGVUQTZReUs0OXdBdXdiR3h1ZXJkYmFDaVVEc1FsaWYyV2k5QWNW?= =?utf-8?B?UXJwYXRXUXFWRzFadTAyQ3paOTQ3V0x2Q290Tmx6a0J4cGVNN3lIekZMQS9P?= =?utf-8?B?Tit3MTVtWldjV0t3ajAwSzVTb0phMkw1MHNQRUJoMUVBd2M2Mkt0dlpZOFlk?= =?utf-8?B?Q0ZjdUNIODFkYW1iRU5PTUQrSGRpRnlyY0E2R3Z4ZWllcjJIb2hVa2p3S3ZK?= =?utf-8?B?SjBES2hYTkVkUlg2dGEzOUZZWlJmOHFjTWk0d0xWdGQ3WTNkcDlLTHU2dWRV?= =?utf-8?B?UWd0TFBXTTJLcyt2Mk41VW9GUzI3dVZiR3E2TTZsOHBDdnIwYm5rS0RmRUZI?= =?utf-8?B?ZWpscVNpeHBTRC9GejRzMDRvT292bGJiWEtyZHYvVE1uQ3pjZEFpZ0krS3BZ?= =?utf-8?B?VjlOTGp5YlA4MmFjQThLSnhMVGhDUDVkQmJMREVMWFVKWDErdkdFdExDcU9i?= =?utf-8?B?bmVUbk93TGNTRmo2SExjaWRtZEM4WjN5M0wrRDg3RzBRTkZPWFU0cENTaHda?= =?utf-8?B?Lzg2anBpSFhxZnV3R0dzS1Erc3U0OVhHd0FDbGcyVzJTMkJtWERVR1I0cVVM?= =?utf-8?B?SWtNa0FHWG5TMDkzb3U5d0tjZFdTSG1zQkM4SDQwZVlNRWVYTEhLeU0yZUFt?= =?utf-8?B?VThMNnZCZjdPd0JtRWFnMW9kYlU2WUZJUUNEMm5aM2JCb21Cc0lWSCt4Q1dP?= =?utf-8?B?YTJYWjR4Y0R2RDdiV2lvRWIxRGh6OGRscjNzYTVMcmhkV3pGWFd2K3loc2RT?= =?utf-8?B?Q0hTT3ZZQjNHMG41a0ZBalF4Nm8vdDNtZGRvZ09ZbllGbjM4WGNmcE9xbTNa?= =?utf-8?B?UUxnekExd2V3YXY5cWhOWktZdEhRS0tBeUExdEVZcEZ1R3ZvNjl1aGpheDZK?= =?utf-8?B?R0RNTmtWMmtlWVZaU0RwVVh0Y3QxU0p6WHdyYmhsaW9WWHNrR2pTMURMbU9Y?= =?utf-8?B?V2hYQ1YrMVh2S2VaKzlWM2kvV3NYOWJBYXJzdnY2NXdhd2tlUG5palpxcWlu?= =?utf-8?B?NkpTQ3A4d0Mwbnh5VHpWWmFKT0N0UzRhUUVoL1BMY0ZGVE4wNVVtSHJBcEho?= =?utf-8?B?c3VTeHZ6cVZWbWJNcDM5SktRODlscXFxdmo1K21PVXFSMnFaeDNIeGwrTG8z?= =?utf-8?B?WHM0RmwwUGd0bFJ2LzBwTUt2WGNvS3pNNkhqOGdqMGN2YVBDbXVWTDN4bkN3?= =?utf-8?B?ZEZvUTRHUCt6TVNQRm9Ic3dlL0ozTjgzMHcvVlU4dUxqQ2tSaHIydEU1OU40?= =?utf-8?B?dG5RZldhcE03VDZoZDZjTHhaOHdOVUt0Vno3Vmk3SnFzcDFUNitKK1dPejBZ?= =?utf-8?B?amtYM1doZFkyS1Iwcm1LWmt1ZzFlL0htOUVtMWhIL0ZVTFdqcGNtZHRwdXNC?= =?utf-8?B?WTgzdEdQVWxXZjRsYTBKNFdjRytvKy8zcXVjbGF6OW1SdmcyeFJySi9YTWRJ?= =?utf-8?B?MThxOUN0Zjh5WGZaNzVoRlVGNDRIUW1mNHlDa0xjRlZ1czQvbDU1d09PeXVp?= =?utf-8?B?ano0ZUMvS2pHZ2QzZVlULzYvbVVQRHArNGp0WEo4YnF2dytiQy9SUys0Vml4?= =?utf-8?B?OTFnbUpib3Rha1hTNCs2UFd1NE1QK0w0NENkWkZ4L0QyRmRxUjFPQlRlbWIx?= =?utf-8?B?dnZXeVpqN2d3a2FBUnBZc1Q5SkhZTCthS3NYczVHRkc5eC82SmlDSU9LdTE0?= =?utf-8?B?cFpmWTZkYVp2aGRDVW9GMXVaWXZ0UGVURGZsdEpONzJGbnpJWFMzdVdDSGhy?= =?utf-8?B?VUlyVHBnYUNIQVFWUkNmeWZNcFAwUjlHYVE3empsRzUwWngrbzd3WUgreVgy?= =?utf-8?B?enBnYm5TaWlVWU9XZjJmTm1iNlo3RVhQWTkzOFpYSlVpclplZFQ0eVlOQmtS?= =?utf-8?B?K1E9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3a52f6e-cc16-423b-f0a6-08dac1a6a29a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 16:31:06.4391 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SgmvgCa2y2WNPIJSumGq2Nd33G/HgMd6S/qF3wBJIWJC7QcGwQfCMIl2dNshRlA70+todGhnXsgSK/a/QHeCKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB7016 On Tue, Nov 08, 2022 at 04:56:17PM +0100, Jan Beulich wrote: > On 08.11.2022 14:55, Roger Pau Monne wrote: > > The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image > > from the firmware instead of doing it on the PCI ROM on the physical > > device. > > I can't find any mention of VFCT in the ACPI 6.3 spec, nor anywhere > under Linux'es include/acpi/. I don't mind the addition that you're > doing, but there needs to be a pointer to a sufficiently "official" > spec. I've also asked for some kind of official spec, as I would assume it should be in: https://uefi.org/acpi With the rest of tables not in the spec itself, but there's none. I could add a link to the Linux header, but that's suboptimal IMO. Are you fine with this as-is, or would you like me to elaborate about the lack of an official spec in the commit description? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Nov 08 16:33:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 16:33:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440291.694433 (Exim 4.92) (envelope-from ) id 1osRXP-0006Gz-Vf; Tue, 08 Nov 2022 16:33:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440291.694433; Tue, 08 Nov 2022 16:33:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRXP-0006Gs-RT; Tue, 08 Nov 2022 16:33:23 +0000 Received: by outflank-mailman (input) for mailman id 440291; Tue, 08 Nov 2022 16:33:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRXO-0006Gm-TJ for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 16:33:22 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2068.outbound.protection.outlook.com [40.107.249.68]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0ef86fc9-5f83-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 17:33:21 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8640.eurprd04.prod.outlook.com (2603:10a6:102:21f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Tue, 8 Nov 2022 16:33:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Tue, 8 Nov 2022 16:33:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ef86fc9-5f83-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wa78eJADXs9E0JlYqSvj9znkRNEkkyO+Rqidoojind+knER4GPUHUM+oOKzkVcwWXqQVLTrlEKWhD8z6Oboz/eN+0xhSgNloQKfxWrVdap+HE/VsvuXCFQP9zNMSfyn4EzdC7c8qBtz4tBgw8Wg2Ql9FRosYYI0eOJ5CAucsCw9H5Q2r/26ynmZEygWWxhDJ5j+3Hv9OaYfharW8khnJmIyKPLT64fMEE8tnkhgZScChQ9EgjZqkOK70apZDXJ2imacZIF6scf8VsYbM0U96AKxEnb/kA7DtEhT8lFTGGjTjpTRz7gEgRbWlSw+bKUEbvN3yPycFZKhbnZPpCFMiZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/yXhiocv9/KQB7pT6PT/yrGtCj+DEwJvZc10DZj/Sc8=; b=kYnStpP3H5c3yFijd38ctoNEI2sheZMzcX1GEjYKRNhd3sE9jab/LlVnmI46Yikintf4g3Dm3sYnquu+EPeqMLHMok2Y5uGXN6Z6jTqcjKIDweXun/eoHJ8QaLLZXFxhW17XwWiR5eMQLezg8GnHsoYum/vwTcH2XSKNehLxHeGL6kFgvoQ4SxxbHbdoZyxxl0nd5BadljhlG7UqJOl1DbE/R32XFwXLsgNu8VVIN4eqDoHOT8yK9kn7JFzIfI+hEM2TIN/JAFHHO9XAeC6chW27xclGY7c4q2TiLjS+KhNZwgjcgEjuv3uoAAhSu2jq3AunvdagMHfssEhhe0+lyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/yXhiocv9/KQB7pT6PT/yrGtCj+DEwJvZc10DZj/Sc8=; b=RiY5ue8CpyUvlzTBwQcb8rlho+ef0OwBTo8cJgHFQqlRopHY6RAQWBbbVazG7GLeJeeQutz1o3nqlwk8eJyw7gwVKBKzM/iqbhmRNnKVPEDYv0natyZsIroXI7PniA1+tsTtunkFsmdiYu2+piIUIuLqXHPahfPaz1n9hnm3PQKSalOZWrNSfZYAL8qSCCp1QXjWgprVuqG2ibydPCAnVMDA55ZKgJjUGvI42if9TYVxp943AThIlU82ia4djN4LqfOgGmp/4JcsI0Xz+3wIusKDxibUFyawqQZzwQvyQk83o+yy6HpBXjleQRHqVc+3SlsV+57joxNV98BDxanD2Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2a9e8fd9-fae0-643e-7754-ade395576695@suse.com> Date: Tue, 8 Nov 2022 17:33:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present Content-Language: en-US To: Huang Rui Cc: Roger Pau Monne , "Henry.Wang@arm.com" , "Deucher, Alexander" , Andrew Cooper , Wei Liu , "xen-devel@lists.xenproject.org" References: <20221108135516.62775-1-roger.pau@citrix.com> <9b785cc6-2de1-a522-9e57-62c0421c6a21@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P193CA0041.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8640:EE_ X-MS-Office365-Filtering-Correlation-Id: ba370869-3420-49df-534f-08dac1a6f277 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0N+AaeEOR8uXv4e1EUMRPW9QKxVOyWySjVaf0sWiqYaGUfxoYBq/4Cgdn5myVCcoOVFDlogVc3hwf/MAEPRS9BiXc8ph77uO69IgvYnY5RQ5XTfl066fczg85vpCZ96m1Ts0exPUoynauB0Czbgpm88+UTF9ZiYQDmpUUfCGQF1sKjNz6Bvm3XPjBox4uOXC10SGVCoEzdn2oKI+szKH0dFeh5ADaxgcVJrLOblAreZEGT0cDeqRzAHDZaY9YhzIdrpl7qPL7LCUFlSjcYx7Ra5nR6yIDw5W5Wra+sfA3YmLmrYxmSuzH2IV2wQJAiMZRLoQyuNmMvSX/qstNd+ls4BlGod7euri8KVtq1WDv67MQ2sq8hxcaE9MycLM2m6ZNFLOdGfxvK9uBd3xjP07pjc1gyyrX1a9Jwn+zoNCX/cwhdvZ7lpqqQDcTDRDfatLZT1f8EobljtyvLneVfcAfZ+2FOvFT3P3y/WySwhhvA8PIAIDqPdcUa6hPPPEfD3rbD+dBVatt7lpiOIcw6Aja1VmpYqQRE2GFea+iTW+ZvwB98D9Fz3oFt5k4qM5tSWETaTKwEkuscQyT2T//mS6rPIIReIACm8FqzOLMhYS5TOqjJFrQuJed8qp3/fX8+5ta815rN9qWQmnfKo9fA/Y6M6efbTJGOcKuDRhOFpSkU8MTCjzlVSkhr27gDYAFwj5uZqNBxXQDErjIWzOPbI5mIxH1uyxubjdyzwDqaPIisdE3tdDsdYYKIjsHcnPhUH0Adva2Sw4oV+EHiYeEIEiFOCpIF1BxCGSOyLLX3eflgXpeqxIjCu7VYYlH8gJFMdXI6d+fQUwYHk5nJcVJxoAzw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(39860400002)(366004)(136003)(346002)(451199015)(8676002)(4326008)(316002)(2906002)(86362001)(31696002)(6506007)(38100700002)(53546011)(36756003)(66556008)(66476007)(66946007)(31686004)(966005)(6486002)(54906003)(6512007)(2616005)(8936002)(41300700001)(478600001)(186003)(6916009)(26005)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnRKUy8rN0M4ZzhiNUhHSkEwOUZobHo2VENIOFRZSG9LNVBNeXdJTVd4TnRT?= =?utf-8?B?ZlRlUjUwNjV0cm0xZjJ2ZmZvK0wza2xhTmR4bDhNOGovTjArenFzVkI0cDFK?= =?utf-8?B?RDk3SkFIckRzbmVVYzFKYXcyTkpvV2lWNkpoK1NCMkxuVGoydHVWaXBkanFs?= =?utf-8?B?VjRtQUViNjhDOGJQbkV2U1k2ODU2U2J5RlNReWpkWmhjcnlMZ0dDS2p2dlUr?= =?utf-8?B?QnphV3Nab0d3djdVWnloQTB5cHJRYmFMQmFtbEFiTVdMN1MvVHhORDZxQ0FK?= =?utf-8?B?Qk5RY0FmRHpmRm5TdlhVcnlzK3p1WC96Tm8vOEROZlQybUZzQnZTdm1oc0NJ?= =?utf-8?B?Y1h6eG9RckhLUUFhbnQzcm1rRTBvUG8veDR5SVpPbUMxdUZZbGkzZ0FxRnBB?= =?utf-8?B?NUVBYXpNNXdUQjgyL3o2ZExkTm1FS2FjaFdNSzB1MTd2VmtJMXVGUHFzUmxZ?= =?utf-8?B?U2dVN2V5VlI0NVFOQ0FXTXQyRWJKQmtad2U3TXY0dTFLK1RDWDVGUHFxOWJm?= =?utf-8?B?L0NzcnRmOTNlVmlMdWdxRTg5OXhUejRRSWxSRzZDWjMwZG5NZDhEeFZrV1hz?= =?utf-8?B?NDBxSVJNVTh4ZEoxOHpmdmVTTUZuS013Y2JGS1ZEUkdibnNqcTErTjNjYUZ5?= =?utf-8?B?cm9oa3UySFI4amcvWS9wMzcxTlYrM2dwakFueEorNjNZOUlEbjMvbU5YWTJJ?= =?utf-8?B?WkxEUWk2dkdyUFJ4Y2hHZ0FOdFBWRnBvNTFDRUJtSVN4THpLOTRzc2oveDJ6?= =?utf-8?B?bG1JWk5rSWVoRkptemEwMzZRNEpBQTQ1UGlQbzdZZVd5bHdnWXkybWg5N1Qy?= =?utf-8?B?akxHQ24xWXkxQVlzcG5RYmlETC9SWTFRc096UTgvcEp5QWVKZTVXandXZlhV?= =?utf-8?B?Yko3dWlLbkpWcGgxUk5udzZkYm1UcFRkbmdlcXF2WENLU0Q1anE0TzY1ZGpU?= =?utf-8?B?WXk1MkNsdS9DSEJYbG0zeFVsT01VM3dDZXJvVmhucUNOZGlJanJoZ3M5WFpa?= =?utf-8?B?UVo0aWExNkRmbEpvSEJQNDd5ZnVQaVdON0haaVZKYzFVQ01mamQ0VzNvWG5U?= =?utf-8?B?VlVRaTdIL3RaeE1Wb3MrbTZyRWp0TG04SkVjc2x6Qm1CZHRBNmJPUFE5Y2s1?= =?utf-8?B?ZldFNUQ0ODNTaUE1bVdWWkRpRi9JNUUzSlBRQ2ZXNlkzUC9lc3dSUmRKam11?= =?utf-8?B?bkdTT2RDaHZpOGlIUk5ObElKWExnL0hrbjNqbmtTRTdYNkcySHA3RnU4Uytp?= =?utf-8?B?UU1vMVc0T2hZNENHRmZhQnYrSkRBZmdtWUpvYktGSmN4cVBocjVTNnc4Y1lr?= =?utf-8?B?aTJSMkdwck5hVSsrcDBNekU4RXpoVXpqRFA0enQ0dWx6d0NVYWZoS3VtSEYr?= =?utf-8?B?UDA1anlOVGxyVWlHcjA5OGVES3VXVmhCTGZUMTRrcVFMQ2tWSmVYSnVjalB5?= =?utf-8?B?RS9DMUMyczBOQm9GNzV3MGl4cEROcTZMbHFKNkhwYjB0SDU5cjBMRlZPYWdH?= =?utf-8?B?K2thWi9jRmNBeTVZNU5NOTRpVTBUY2hpdkVaazBJTXFZWTdaaDA0Zys4OEl6?= =?utf-8?B?QWZjRFNVOFRVWE51TFljcXVselVYa3BORnliZDNpUE55WWNGMDFrZ1Q2OUxj?= =?utf-8?B?M3VuZHovajBZTDB2dW53MzNGd0hQRUpKV012b2VBZDQ2OU95ekI0RzlqOXJl?= =?utf-8?B?L1lwT0NZdWEwTE9WUzM4bmYweU9OalhsNGVGVHVuUDlaMmpDQytNb2pmcndR?= =?utf-8?B?QVpZV2RsSjBrWUY3ajA4WHBhVDZ3cEQ3QjU3QkdOZ0FRaFViZm9DOEEycldX?= =?utf-8?B?QlBjM2JZdGdBT0VOblZBUFlneFFTVGVUN201NUdlQkxvKy9pbDNHNlppRXBK?= =?utf-8?B?WlZOcDlISUZ4UnBUTk9WdmJ5ZjR1My9hSSt0R0VjVmN5ZlZxR0hnN2x3STlh?= =?utf-8?B?ZTdNL2ZSTlZ6NUxZdWJOZDMxeTZ1amF5S3pzaE1XZzE1M0haWFp0dGVKYnBl?= =?utf-8?B?eHpIZWVQclVEa0FYVDlIcnlEZ3EyNUhwdk85YmtlQjlPTDJNZFJKWUpiaXl1?= =?utf-8?B?UlRuUnZ3REJNTDVuRGMwNzV5NC9LbTJPem1PZXZ0VHVqaGZIbzVGSXVFR0Jt?= =?utf-8?Q?6BfUjNSb946x946fXzDKBm4cO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba370869-3420-49df-534f-08dac1a6f277 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 16:33:20.3922 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2Fl4u4Tv8MhmSyfYJ/tY4TJrWL9JKkGsNtEN+7N8WRS7jDpkqCh1inH8QshDrOmd51mHgqSohHGvbTAnTvx5qA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8640 On 08.11.2022 17:16, Huang Rui wrote: > On Tue, Nov 08, 2022 at 11:56:17PM +0800, Jan Beulich wrote: >> On 08.11.2022 14:55, Roger Pau Monne wrote: >>> The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image >>> from the firmware instead of doing it on the PCI ROM on the physical >>> device. >> >> I can't find any mention of VFCT in the ACPI 6.3 spec, nor anywhere >> under Linux'es include/acpi/. I don't mind the addition that you're >> doing, but there needs to be a pointer to a sufficiently "official" >> spec. > > Thanks! In fact, this is defined by AMD atombios (VBIOS), we have up > streamed this in the Linux kenrel. You can see more details here: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/amd/include/atombios.h I can see about two dozen lines at the bottom of that file, with effectively no helpful comments at all. I'm afraid I don't view this as "more details", let alone something replacing a spec. There at least needs to be enough to be sure that "VFCT" is really firmly reserved for this and only this purpose within the overall ACPI table name space. Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 08 16:35:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 16:35:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440296.694444 (Exim 4.92) (envelope-from ) id 1osRZ8-0006zz-9I; Tue, 08 Nov 2022 16:35:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440296.694444; Tue, 08 Nov 2022 16:35:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRZ8-0006zs-6R; Tue, 08 Nov 2022 16:35:10 +0000 Received: by outflank-mailman (input) for mailman id 440296; Tue, 08 Nov 2022 16:35:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRZ6-0006zm-MB for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 16:35:08 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2085.outbound.protection.outlook.com [40.107.22.85]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e191f72-5f83-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 17:35:07 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8389.eurprd04.prod.outlook.com (2603:10a6:102:1bf::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.24; Tue, 8 Nov 2022 16:35:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Tue, 8 Nov 2022 16:35:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e191f72-5f83-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IKvMYRnztCvAET9KoQIMpNRioeYRYhoM8QmryUQHby6Epi7lxKkRncrsa63t2Ul5tC5fpaLtgtl7MS3d3tmuTNweON88AcAKhE7j0Ksj0Do66tM6Z4Iu6DF2TdgDDW9OLkX8xkagUimobWoyEwWZplnuKrUEb9zw7Y220aP5cxl2pxhW9oC6CiyZOMkIRKPwvZUCPzrrG8W0NkqBIftp8qlAjlsIzeW6Mu5KQFx5WQp62aA5y15E5FthOcQG4N9OoaMH32+yqpvfybNARfu0q1mXktTMSXcSt4APIrMc0/qZHdLIQlXSXw2+Ele60R4QtF2s8ujwmrBcCARmen2FWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X81JENs+ZcCQ4hybFqC+u7Rl4nKRoAKqwk0u2mU7gNo=; b=jnbiI6o1+1fPXBor85Q8s+HN/2TCGu4QUtu6zx9qs9oUCWXJ3GNR/SRgTrvK/qIsqsrEynm5Qiv6fAekhMXiBghA0/6lqzb3usaWfHF9HwTRBxGt9gjrXs/BZuMjW8dwMVdN8tunksiXR9bZzfUeW8YYMoFvPdWPQqIC7bP9AvPICCnHTfMFyMxQ85TvlaVhymzGIlbpWJHV4gpC/B8BETa84AiEVzqgfJHAOaFPazNpqlbKNT+d1yzyJQR2RYzLhRjDSxl1gyLAXvnpOr3WgIaiqESMEnfTAMps2OXtus1Qu/Qm5uanzry/nITzUtBQjHAMGNrLK0Im+sAF7/LgXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X81JENs+ZcCQ4hybFqC+u7Rl4nKRoAKqwk0u2mU7gNo=; b=QAobF46TtDr8TYDlHW8Q0QgVUXIcNIuYqdj19tUeG0nBV6IErZSKqrGqEvIRH4jBAUjU1aeCU1kSkfFeGsAKynj3ECGnj+zXpKiqhm8A5/MxV7PhrxgIWwKfOUiwv2qJLyuJJaCvb34pnQLxSAGHQXydeNtDGuoB5HNxJOv9jK74aEy6D1wgSLls9fTSceuzdhxxAXo0LvJktPDl06lF1/KChNotPWglTUvbNV/kEKvSPnqNhs4ttmFqXstKNiXleIdASOSx53vpYrQqo3M2pMTNenvXxN7QPtyVW8PmsiGwI+BZeyncjVGOuMRxmuk7JoBQEXce7TyLuNHKCBdHiQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Nov 2022 17:35:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Henry.Wang@arm.com, ray.huang@amd.com, Alexander.Deucher@amd.com, Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20221108135516.62775-1-roger.pau@citrix.com> <9b785cc6-2de1-a522-9e57-62c0421c6a21@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P193CA0136.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::41) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8389:EE_ X-MS-Office365-Filtering-Correlation-Id: ae1472b7-aa7c-4235-19c4-08dac1a7313e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 15E/ZOnPcyDRRpH5pRGvmDIZqRBQuVpSnQ+wbkz882XQ2yK3bNzydsHRVEkDKEQ5opNGySB1u8kHmCMSr/lduQip1qkL/1QvsBNAiD3qXti17+NlgQBbhAH4BY+PSsRLKpkt28Yz4EXLdcA1fyh8NXgNwjsnOBk7Wd3hoQWUDR0Q+Iensezn5VVoxjQerUR58wUBODb2+06PwpR9YDJzDrXZfhVBtJ0GNjtIlTHPs17370WHiwePmoRO+fIjUIw0le/5JCKL53CvIsm26gUQeexMBHS4v03/0FFKQs7g502XCPBfCKp7nrIxUVxgbppUOV9nyNXJ4iLAvKLXAa1r1JoaFiNOZ+ItAWob8S1AuLgdA8wNY6/ActoTV0FhrNcmGOHjRfrP0+iM4NPtXsjYGc3lzTFF8ucOxE7ZmQWH6bQoEh+03qj748CUfkn3mv+czmvZVbJ/YfI5zXmUEqKkelG/K8PetL3GRyOPMjucQqt5C+pBcWztRWYwFfGBYgws7NYgkzDggHV9caTxULzecODLEurdM9UrO8I+5j2lIkxHGJS6WjjoL1Slodynw3fytZACGmUyJ0Mbh1xNA8KSuPMGjinA0jExKw2soI4Mf8vGeHnsU2fd0MHLOwzpRw3z15HXwlGHhJR0fEgBwyggCyd1NfgRIhPm5ikWh4n0wMsaJ0DiHYNxFgO6a6yHuRmnCuksj68/3jenkynJoTvPcifpiIh9VrhDEAjVJirw9fuI9Hjga7rwL2dpBkHBYRAZA31XA5YODWXpmfDE3LgCCZvx2OjfbGxPdEAzCNqqym2Onrn4aP/xGUGCZu6cEZrs1x64fpwqUefCzocr6qPwZA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(136003)(376002)(396003)(451199015)(86362001)(31696002)(66556008)(38100700002)(316002)(66946007)(4326008)(53546011)(66476007)(2906002)(8676002)(5660300002)(6506007)(6512007)(26005)(478600001)(6916009)(2616005)(186003)(6486002)(41300700001)(966005)(54906003)(8936002)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFI1c05TYU8rTVBkUFhSVFJJbGppQ3ZSUnFVTGtWdHdDdFpTR1U5bTRJVys0?= =?utf-8?B?d1lNaEdmb2JtYzVodEhuRXg5Z3RJc3l6ZnlFamZ3VnNOVWRFN3NKSG56VmZD?= =?utf-8?B?cGVXa0p5amVRWUZ5UnNpeElUM0NUbE9LM0J5bmRwS04rU0pQSE9pbkR6REFL?= =?utf-8?B?VVc0WWtub3VRM3FOVEVPMFVheExlbnV4WlZjaHN2NFJqQW1hejkxdjFLU0Nn?= =?utf-8?B?TktCM00vZ2xXTFFIQ2RuNzBOVCtnWlF2UGhKVjN2N1NxOGlHVEM2S1pFSUVC?= =?utf-8?B?Rm9CTjBiSGZiQzd3WHNYbUN4TGwvL2pMWkZ0blh3cUVZMkFhMmVFTm8yb1dh?= =?utf-8?B?dVhQcGVtUktWOUxWbTN5dkNteFlKTHVGT2k5azBDUWVncmNrNldRREFiU1h6?= =?utf-8?B?a3IybXhQRWcvN1g3NEhBaG9JbmVMKzR5bVpkZWM2SHBKSVZ6SWNLdHZBYktB?= =?utf-8?B?Smx2dEx3dy84NG1iN3ZiOEVSa095b1U0VE5HemxNOUlqVCtYUXhXaUREREpK?= =?utf-8?B?MXFtVG9CTWVjK002YjdGUUlZaHlOOHNGOU1kck9yeEFJZjFSOFUvcitrcm01?= =?utf-8?B?VkNiK084bklpVm5wR0pVQXB5S0lua3R0RUZCSklCVEV4d1pSY0I3LzVTblFj?= =?utf-8?B?QnNURjhyQnNNVHhWWFl5cVZ6Vlc4bEFrMFQ3c0JmVDB6ZXBHV3dnTyt6QXdS?= =?utf-8?B?dkVFM3VmUDhSTm44Z2o2OXljT3NJdnBGM2Fqd3dpWG9EaVAwWmc1cE42VnlJ?= =?utf-8?B?dTlqL0N6SHBFMVFpMnRXRHd2dTRub1doRG9zaENUdW1tQVllVnQzbXpiLzJR?= =?utf-8?B?UE0yUjZmL3o0OUpCWFlmbFNyTFFiTmZxM0djNFh4bGJ6STlPam1uaVBEQnVq?= =?utf-8?B?OGRzNXIwem1KRkdUNjNYM0NmWDlHL0VVOE9QQUFHaXZ6K3VGeTY3ckZ6bVl5?= =?utf-8?B?dzR2SU9FWDRjdWJXRk1kai8wYWhoWUpEVkpLdGlvcUYxYm8rbWJmajMxQkMw?= =?utf-8?B?cW9JM0Z0MFdaZEpVZVBaeHJnMW12b2Q0UWI3TDBHamlzZTJlU29sb0VtZVFT?= =?utf-8?B?L3k3d3BBa1F6TFVldmNZeDExdGx3c0k4ZGVwQm5XZmp6K0NQOTk0bThjb05P?= =?utf-8?B?azRJV3hpRDJ1d2h3TzQ0VG0rRjFSV1FWRDE2RE5jOTZ2MjVhSmZNK1hNWjZp?= =?utf-8?B?N2NuUFBkVDFiUWZmS0craFZaVGVFT3BqMkhYdDRQZk9aTE9GUlZPeU5IZmRu?= =?utf-8?B?cndzQWRzekVuaEkxUDBZRjQzRlBCSWoxL0JmTzRzTW9sQ241aEl3ZmhVUUdD?= =?utf-8?B?TUpUMnJmZ0V6OUZWOStEbC9NY1JtZ2srUjlnV21HN2NFMW9IWWM2bkc5UHJs?= =?utf-8?B?UzMvdjRodC9SdlVQbWl5S01Gd2ROa21aRVFvaGpsNWUwY3hPSlRObEpTMmNN?= =?utf-8?B?MkRFb29Pa0lyVmVVRXI2dUpwRDNxSUJLT1l6L0dXK2NOVmpyR01tRnpCaCtC?= =?utf-8?B?aGhqa3pwOC8zNUxBY2pMS1ZrcTljcWlzZXVWN1J4cmRUWWYvV2VNbUV2RDFz?= =?utf-8?B?NkY3bENzQkxBWGpTeFZIY2RKSWlvTU9iR3VOT0w1VHNvNzUrTkpPdjFqTXNH?= =?utf-8?B?OXRDUnhJQy9kU1pETnhFc3NmVXI1cDFOTjRnZXRpdEhXMnhXWWRIaEd3YlRS?= =?utf-8?B?aUViU3RQOUYxRElJWkR4V3VwQTJEd1pnWTdCYXJyV21lc29vc2tvNFlYOXQv?= =?utf-8?B?aWpxU0tPeEtCQkpUY1U4VmhSb2xhLy9kQ0dhVWRGeDhpZnVSRTYrK21XNE5X?= =?utf-8?B?allIQXZGOWJ1QjNTZlg5bE1pei8rL29GMERLNEhpV3A5RWhXTnp2YnY2ZG10?= =?utf-8?B?WDdnR3hRV3JpRnBmNkFPOTVZVnU2OXVzb3dIN0VjQlJoWHo3dVFFWHZVQ3Yz?= =?utf-8?B?Mm5kSWx6RStyQ3AvclUzdGM3TlhWNFpIcVRhQlVQVW0zQXU5U2QwSmlSQjlN?= =?utf-8?B?NjFoei9EbHQ1b296SzlML3dtWTRyUzZqTlpCcFhObEd1V2NwQlNITzkzMzhN?= =?utf-8?B?Y1Zib3RhVFh4NGRmQTVKL0pSeVJVSDFhUitJaVBzRTBGWHRkSStrc2JiZ1cx?= =?utf-8?Q?kYVCaLEqaHEbE8AbO4LBXjmi1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae1472b7-aa7c-4235-19c4-08dac1a7313e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 16:35:05.7136 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a5FjzbOlkJ8THjw/xKEEaGZMlz0/HKddRI2iAzfMolXhKaD8L19U0RIcH+PXJ/K0Sa9iLWbXmxiqRgu3jcYWFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8389 On 08.11.2022 17:31, Roger Pau Monné wrote: > On Tue, Nov 08, 2022 at 04:56:17PM +0100, Jan Beulich wrote: >> On 08.11.2022 14:55, Roger Pau Monne wrote: >>> The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image >>> from the firmware instead of doing it on the PCI ROM on the physical >>> device. >> >> I can't find any mention of VFCT in the ACPI 6.3 spec, nor anywhere >> under Linux'es include/acpi/. I don't mind the addition that you're >> doing, but there needs to be a pointer to a sufficiently "official" >> spec. > > I've also asked for some kind of official spec, as I would assume it > should be in: > > https://uefi.org/acpi > > With the rest of tables not in the spec itself, but there's none. > > I could add a link to the Linux header, but that's suboptimal IMO. > > Are you fine with this as-is, or would you like me to elaborate about > the lack of an official spec in the commit description? A pointer to the Linux bits is better than nothing, but as just said in reply to Ray there needs to be sufficient guarantee that "VFCT" really isn't going to be used for something else down the road. Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 08 16:43:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 16:43:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440307.694455 (Exim 4.92) (envelope-from ) id 1osRhY-0000DO-AX; Tue, 08 Nov 2022 16:43:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440307.694455; Tue, 08 Nov 2022 16:43:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRhY-0000DH-6E; Tue, 08 Nov 2022 16:43:52 +0000 Received: by outflank-mailman (input) for mailman id 440307; Tue, 08 Nov 2022 16:43:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRhW-0000DB-2X for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 16:43:50 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 832c8b94-5f84-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 17:43:48 +0100 (CET) Received: from mail-dm6nam10lp2100.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Nov 2022 11:43:44 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB5549.namprd03.prod.outlook.com (2603:10b6:a03:281::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Tue, 8 Nov 2022 16:43:42 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.025; Tue, 8 Nov 2022 16:43:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 832c8b94-5f84-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667925828; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=uhIIdiQjcfRxGPj1gCZKs9BzSuEE2h3wWGssEhDisEM=; b=edSh1B4au7PMGdTx/5BCe4B56NwcSH0c1C2Cd4FBKVSIjzpAyuOwVkAi Fjxf9X0hmaDcAH7+sIUne7f0PpqTRXlGvbyU9bWInBd+rhXssFTJZLJzU 55yDI0SaSyjW+wClOcXnX7BRkLZR4wdWHoymZbBF2Uh8hD2CGjaeN8e5S g=; X-IronPort-RemoteIP: 104.47.58.100 X-IronPort-MID: 84405869 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:oCy70a0/gZks4HKiLfbD5eBwkn2cJEfYwER7XKvMYLTBsI5bpzZVn 2AeWjjXPayLMWD1LdAnOYjn9R5S68CExtFqSABqpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVmNagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfJGRe+ cAmDRs2NEqO3+KY7K2kDdVNr5F2RCXrFNt3VnBI6xj8VK5jbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6KlFQZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r82rOXwHOlCer+EpXn2LlQnVmIyFA+BTkJDgq8qN/oyUGxDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Ua5QeX2+zr6gCWLmEeS3hKb9lOnNAybSwn0 BmOhdyBLSxitviZRGyQ8p+QrCiuIm4FIGkafygGQAAZpd75r+kOYgnnS99iFOu5i4PzEDSpm zSS9nFm3/MUkNIB0Li98RbfmTWwq5PVTwkzoALKQmai6QA/b4mgD2C11WXmAT97BN7xZjG8U LIswaByMMhm4UmxqRGw IronPort-HdrOrdr: A9a23:r81St668wtPebfaBKgPXwS2BI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcV2/hpAV7GZmXbUQSTTL2KgbGSoAEIXheOjdK1tp 0QD5SWaueAamSS5PySiGfYLz9j+qjgzEnBv5ai854Hd3APV0gP1XYaNu7NeXcGPjWuSKBJY6 a0145inX6NaH4XZsO0Cj0sWPXCncTCkNbDbQQdDxAqxQGShXfwgYSKWiSw71M7aXdi0L0i+W /Kn0jQ4biiieiyzlv523XI55pbtdP9wp9oBdCKiOISNjLw4zzYErhJavmnhnQYseuv4FElnJ 3lpAohBd167zfrcmS8sXLWqnvd+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ g7kl6xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklWqvoJBiKp7zPLd MeQv01vJ1tABKnhjHizyJSKeWXLzgO9kzseDlDhiSXuwIm70yRgXFoh/D3pU1wha7Ve6M0mN gsDZ4Y6o2mbvVmGJ6VV91xNfefOyjqfS/mFl60DBDOKJwnUki926Ifpo9FrN2XRA== X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84405869" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DkHB0k4AfccOIjp3/R4cOfRsXr6kyNVugl/4fFUJ6PBSsmWEuLhIq3GsFE8nYgglsX4h/h3tjlJHaPxA7CeZX2Bd453PCgBjAZl8HA1NkMn4kEy3nWkmAitRwXO7eXimQpx2ZiXxe2WHSmh92HEdPx/5SdfCB5AfhWBdRiluM/yJLzfJCuGltLEWgjxYyfOV2W+QW7s9WpO9yHu+MpzbtcmrOhOi8I2tNaAsO6aUEMigVK9lzHsqhdXeF5cMNF075qnJFaL6ttLoBT9YbH+Dr3+3jNO5Pxt3MsYL2etpA9j/33ngbYArRDJ+e/aRghVB248OuiuJdqqwH2l4fgDo8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EAOnpEUk1S6xyXv4yVWt+017AJFu5D88A2OWknZHIkU=; b=JVEEiGY8yA2WHKhOSUkJpYGdgvsMxAORnluwi9wFiBtxXQHzbfyNQynYacCeg2kmK+ylNKMGmUfhI5PRmyQ1BKSW4DjeQmkOnogp9m3R7iaWo6jtbMWk9vcqT8F6/19OI6lSIWqGUeTP6q/oNIO1mVy2mIBplavuRg9yYXGE3F/9QFNUau8fds7HN2odVHb2noaANUFIPOz91PXzFUDQ5BwGYXn8oiqzXavm661cVUzuRYpeFWCZ7u+yxRAaduwX/VfB3al4EdA8FSgXIcOp69cmhdx7E2mapSog4w4iK9DanDcX//bBHADh6Uq1JplGRtOt6w6e7H+bO19E1irivw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EAOnpEUk1S6xyXv4yVWt+017AJFu5D88A2OWknZHIkU=; b=iBTZTwmtipFY1mLKcioOI4anUjUEnbeEsFkxprk3wlBb2B2TI19uT6HnjcgUO1c3ztxH9/SdqcGYw4s+mmIC6lMwd4pRDjC5NLHe5vRr1++NmkJ+70TEwgSPZwj5w32Xx8apZ20r4TysYqh9pvtFhn4QZJ2xhYheefiWfoOTuAQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 8 Nov 2022 17:43:37 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Wei Liu , Edwin =?utf-8?B?VMO2csO2aw==?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Message-ID: References: <20221108113850.61619-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0369.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::21) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5549:EE_ X-MS-Office365-Filtering-Correlation-Id: f0a307e4-48ed-4fe9-21d0-08dac1a8651a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LqIf5pSAekzT1B286RYZt5u6Z9vCefztKr9T3SdiiklKlcY76WoCm9Xe/YK+o1j6wjHb6WixFWyf/tlIgTloq526PHqrQCsSVezM7ENz5PoqhFkErB+HTII8dUqokiJjKkpIHZpQvymmqic/GJ3gTpx6HeYDnhu16G28LjQAe38W1a6OQeqwXm4hhTPi5zN74r8FWSVNJ9965Oc6G0KvffeQPNihrFT/vbDSEjKG0T0/Y3L1U4zBorNdXoJYfntUvorTRBJCuVz5+b67BROXJGmMHhT1MnlGQ5cVupYv63khYACbYrFHMnkXIrWSexj7jJd0HgmxW6NBKqyqo5cBFagMUCiQDiGMRksbwXcKbKOTf9bBqq//qYyEBCRbvNMJ/Vo/oc0TmERsWKiPPd8NfgVrDp7ztj3FOCSqiq7uvUtVas5E8kURhoZ8Rh9ETXUlTGHG2hEKsOFaSlTVH3JqZADV3BelExplZ+kXdVX7NNhW4MkNMj2MK9J75UzGTQlLuoq0PMw+ldm9EMVM4tq7xrM9hrLZEenHSdjgHB+zj+xLfjwgMU1ZwnBbLwWKNa2YbeEjqQINzBEGBzRXdiQ+I5T6Ezf4IUqO+zz7GsT+Uv7XkX2qmUulkMroTVYSaJ5ISmfn4bMG4SpL2Vf91mgyhcB2oDSEYuH2Sr0HHevzcXZnvDckBPxzlMwvTVOwiDhj/+zPfZ0TNfCMuUarl9ol0Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(366004)(39860400002)(136003)(376002)(346002)(396003)(451199015)(6486002)(478600001)(86362001)(83380400001)(6666004)(66476007)(8936002)(5660300002)(33716001)(2906002)(66946007)(66556008)(53546011)(38100700002)(6506007)(186003)(4326008)(8676002)(6512007)(85182001)(26005)(9686003)(82960400001)(41300700001)(54906003)(6916009)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QTJyTFJHT3l3dUdEblFPM0lYc2dJbG9qV3h5dXpJdnVXQTcyYUpRVGtYaWNz?= =?utf-8?B?OGw2YzZ4UFhqbHIzS3pRcDB6R1lhNzE2Wk9wVEhIaDJlVzUvQ3U2anNteVJB?= =?utf-8?B?MlVJSWsvSlpBR1FIVUVYRUs3K0xaWThWcHgyZmhadXFQd0IrOUdkYndKSXVm?= =?utf-8?B?U3lxdmUvZ28raUg4OVNrdTZ1TnNpVEJrMHNjYlkybDVRenB4NXRMR1RONldH?= =?utf-8?B?UHlTZFpVRE5XUG5XY0NmQ2xOMkoyV093WnlScFk0aXJFSVFMVmp2TWJqbHNF?= =?utf-8?B?TFEyQ3NYeDBwaGJLZEJGMnFSdjZoWU9VaHhEYytGT2JQc1J0QXRqdTRaQTVJ?= =?utf-8?B?SEg1QjBVQ2c4UlB4L3E0WllESXRCazFOS1FadVZocU5oanBhRUYyb0R5ekdN?= =?utf-8?B?aGdxcXQ0Q2xGNThNeHdJK0pQRE85VlZUSUg4NDh6dlNUTFE1SU5wVjI2OXIy?= =?utf-8?B?WUZtTmFCRHNZanJoUHM5VThKbHRJdWdQTUxKRjNUTHM4aFZjKzlUQ3FBSHJK?= =?utf-8?B?eVdWV1BKMGtTa3dyRnJPNXVBVnM1Q0V5RnRmcmdrSXdRdHZsbWZHcEZ4elFD?= =?utf-8?B?RmtWWWVONFpOT083Z2hxVGlneTRHYm5UZDVFRXZGdFR0VDhiQitKOEx6a2Nm?= =?utf-8?B?ZWh5Wmw2cXJ3Lyt6dFQvaVVjbEk2QnMvbFpiNTRsaU1LdWJ4NzhvUkVXc2NY?= =?utf-8?B?Z3UwbXlMem5SV3psT1JNNmNMTUkwODlFWnI4R1dlbGVBbWJONW52a1pWVGxo?= =?utf-8?B?THFobng5SDNkeU1Nc1JCQ3czellHVXZaVSt5SXJhSWs1cmhWeUtkd3o1RytF?= =?utf-8?B?bkNoQ1JYWjJ1N0NQVXI2TWZUcDlZckxTUzdocjI5bVQ1Q0lhVDhaNytpRndI?= =?utf-8?B?WEhzaFVtNFFtb2h0Y3pHamhGWW81bUIveUc0R2dCaU5Dd3Y0cHNYQW5ZSDcw?= =?utf-8?B?Rzc0b241ekpzN1g5NnRRU216Nkw1L3Z6NDJmaEd2Nmt5dHBVU3pFTzJJcXk4?= =?utf-8?B?WXdUK2RTUHR0LytSV0ExZGFRRHQ0NzhxUGJDbEJ3OWxZajFMb2tnZ3dTR3VN?= =?utf-8?B?dXJ3QUo0Si8yOVFmQ09GMm13YUIrRlhyS003bjZYTWhyUHhSM2lzQlhEMVVK?= =?utf-8?B?UlhqRFI1L2huS0MyWlJTdUU5MHZsN0lNM2hzOFhNRVZDOFBnb3IzOVZvdmQ1?= =?utf-8?B?KzhnNE1zVDEvby9yUm5QR0RHSGJaTi9pRjhYK05wemYrMXI0QWNCbFNuY2g0?= =?utf-8?B?ZFlFVWxBY25GRDF3cENTMGppWUhibFNFYnhCR2xKUytSbkdtL3ovWUpZWFFY?= =?utf-8?B?VDBCTFRrWTNoOThQazlXUlFVYXltWGtTVlpRT1V0UjJIQmIrUU1RdjBFYVlw?= =?utf-8?B?UkJzeVlES1BjVXhSUmFqNGJaWjNxMFF6VGxiQWQyR0JYd3YzTkdNRTJ5d21m?= =?utf-8?B?cENEWHdFTmJPNHVYbFFOUm5Cc05KdC81N3VlcENiWjAwT1JLbTlDRzNvNEJT?= =?utf-8?B?NTRRVk1BYVBYejZUREk4eGpCYTNCTGhYVHJaRUZXNmtjNys1MXQ5amtDUndn?= =?utf-8?B?TmlyenB6QitrZlhjUzRiQmI1SUhjdU1PUWlJZnZESCs5YnhuQmFEdW5jZDNC?= =?utf-8?B?bFIxeUpKeTBHSjBLL2h2VTZGdVVGWnlUL3h1RlRCQjVuU3FsK2F0dWhkTlY4?= =?utf-8?B?MWhlbzhnZ2hYM05GWCtxRDJYRkNLQzJaaGNxbmlDZW8yS29jNDdqblZCRThM?= =?utf-8?B?d2JxNHMwRDZTM0x2aWdGWXJPNGk0Y0M3VU13TTBwallaNHo4N2lPeG5vNkRU?= =?utf-8?B?NXZkYkhQTEdGTnBIRVBlMThOdGtNcjBZQlBrQlJ3dVErdW5DckF5TGt4MkRu?= =?utf-8?B?YWh0Q3BJQjFaR0tPakZDMktZLzVKek95SzVPR3hOL2FtMm94VEQyWEdHVm5s?= =?utf-8?B?NE54eDRPeldMRTBxbXhHVENobWFKekhhS1N5eTRmWjhaUHVHdzdaa3JETVVl?= =?utf-8?B?U0ZtNnE1OGt1NmtZZHVBQ3lwekM1QUtsalZhcktMeThqcmVYL1NNRVowRWhW?= =?utf-8?B?aVBoRE56cWhFQXlSdEtQMVhINlJVQ3JQTm9XazhtNzYxZm9TaHRzNWU5Z3NK?= =?utf-8?B?M2xHK0RmNTRQbUFZL2RWVjV2SFh0QUJsOUF6dlN0eG1EaW45Y1Qwd2M3WlZw?= =?utf-8?B?dUE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0a307e4-48ed-4fe9-21d0-08dac1a8651a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 16:43:42.2474 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L7iaNpK4USVveHlRPf7UcDm6ocxCSpoigXf9ybxU/1LI6yTJF2gmUgLAMp3yCSobNGQrHvvpwQ9pMnqd0wz52w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5549 On Tue, Nov 08, 2022 at 05:14:40PM +0100, Jan Beulich wrote: > On 08.11.2022 12:38, Roger Pau Monne wrote: > > Like on the Arm side, return -EINVAL when attempting to do a p2m > > operation on dying domains. > > > > The current logic returns 0 and leaves the domctl parameter > > uninitialized for any parameter fetching operations (like the > > GET_ALLOCATION operation), which is not helpful from a toolstack point > > of view, because there's no indication that the data hasn't been > > fetched. > > While I can see how the present behavior is problematic when it comes > to consuming supposedly returned data, ... > > > --- a/xen/arch/x86/mm/paging.c > > +++ b/xen/arch/x86/mm/paging.c > > @@ -694,9 +694,10 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, > > > > if ( unlikely(d->is_dying) ) > > { > > - gdprintk(XENLOG_INFO, "Ignoring paging op on dying domain %u\n", > > + gdprintk(XENLOG_INFO, > > + "Tried to do a paging domctl op on dying domain %u\n", > > d->domain_id); > > - return 0; > > + return -EINVAL; > > } > > ... going from "success" to "failure" here has a meaningful risk of > regressing callers. It is my understanding that it was deliberate to > mimic success in this case (without meaning to assign "good" or "bad" > to that decision). I would assume that was the original intention, yes, albeit the commit message doesn't go into details about why mimicking success is required, it's very well possible the code relying on this was xend. > Can you instead fill the data to be returned in > some simple enough way? I assume a mere memset() isn't going to be > good enough, though (albeit public/domctl.h doesn't explicitly name > any input-only fields, so it may not be necessary to preserve > anything). Maybe zeroing ->mb and ->stats would do? Hm, it still feels kind of wrong. We do return errors elsewhere for operations attempted against dying domains, and that seems all fine, not sure why paging operations need to be different in this regard. Arm does also return -EINVAL in that case. So what about postponing this change to 4.18 in order to avoid surprises, but then taking it in its current form at the start of the development window, as to have time to detect any issues? > As a minor remark: _If_ you're changing the printk(), then please > also switch to using %pd. I've considered this, but then printing: "Tried to do a paging domctl op on dying domain dX" felt kind of repetitive to me because of the usage of domain and dX in the same sentence. Anyway, will adjust. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Nov 08 16:49:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 16:49:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440313.694465 (Exim 4.92) (envelope-from ) id 1osRmw-00016H-Tc; Tue, 08 Nov 2022 16:49:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440313.694465; Tue, 08 Nov 2022 16:49:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRmw-00016A-R3; Tue, 08 Nov 2022 16:49:26 +0000 Received: by outflank-mailman (input) for mailman id 440313; Tue, 08 Nov 2022 16:49:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRmv-000164-GK for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 16:49:25 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a48b82a-5f85-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 17:49:23 +0100 (CET) Received: from mail-bn8nam12lp2169.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Nov 2022 11:49:14 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BN8PR03MB5057.namprd03.prod.outlook.com (2603:10b6:408:da::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Tue, 8 Nov 2022 16:49:11 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.025; Tue, 8 Nov 2022 16:49:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a48b82a-5f85-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667926163; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=7uHVE6tvVidYXgPFWupiMcDyQ+5Yp2OHDfBdcUaudbg=; b=CxbiaYJwtwmPb5KUALlnH2DWpLEEfYKOh4ddshZABAH3Ms75VDbR+csJ RuePimOZA/Szllh90XUGOkWc7ya8ag1BkARjqU6aZZy/wQChySxVisQNI 4JjIEh6G72I0ejNN8QtEromzu7MQo5rOVeCOIorL+A1h/1jR7b53XiKrU c=; X-IronPort-RemoteIP: 104.47.55.169 X-IronPort-MID: 84406476 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:r2b//amb44orKRhFpMJxjoDo5gxhJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIfCzqGbq7YYzT8f9FxYY/g90wP6sSHmNJlTQs9+X81RiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5A+GzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 cQaCA8GUTnTvaGznJe9R+RCpes6L/C+aevzulk4pd3YJdAPZMmZBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3iea8WDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnzX+nANxOS+PQGvhCoFm143IIEDsvVgGSi/qZqHK3X4tdA hlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml6qfS+RffOWECQRZIctlgv8gzLRQw3 07Pn87gAzNHubiZD3ma89+8hDe/KSETIWIYIwMJUAAF7sPLqYQ/yBnIS75LD6qdntDzXzbqz FiivCU4wrkek8MP/6G65kzcxSKhoIDTSQw47RmRWXiqhj6Vf6agbo2srFLdvfBJKd/DSkHb5 SZV3c+D8OoJEJeB0jSXR/kAF62o4PDDNyDAhVloHN8q8DHFF2OfQL28KQpWfC9BWvvosxezO Cc/ZSs5CEdvAUaX IronPort-HdrOrdr: A9a23:uj5Wua6E4WMcnitJawPXwVOBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A30QaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9QwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgrf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQS/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpbzPKN MeQv002cwmMG9zNxvizylSKZ2XLz4O9y69Mwc/Upf/6UkUoJh7p3FotvD30E1wtq7VcKM0l9 gsAp4Y6o2mcfVmHJ6VJN1xNfdfWVa9Ni7kASa1HWnNMp0hFjbkl6PXiY9Fl91CPqZ4h6cPpA == X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84406476" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gc2w7x0y+SDZETtZ8JtzxyaTQX2UNMhC/6n8eoFAMZSkkbIsM6vQWz9xuxQIXzlvRPVQqDH1NbdBB65HUTdVLVVoveG6UhfNFrdxbANmL1PqIAWslLJF3geNXWlKQRLcbkIGr+bp6hWds0nuvObKlVSh0A30HP3XQNbGl4DsBdphV5KSWBrXyAJ+dkpfnt0/5k+Edn6SlKqtYzwi7vJ2Bk0grcV4cSXQ2x3ivLdHwrltuONPaqWkz8dzLOdTUcSi8+af0fuQf/DU95h17qLdOdaM6ykZjTKhIXX6HYxx0oCEibzluMHprnbrvbfG7gDwfGByOsoJcE5I6HjObku5ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wkpIb/z8eiIlRllcG96IJyMPPG0asRaSYB/J7lUyigk=; b=euhPSyzkZDfSB6HQyBCp2wUbl/wSU5hVYdwubl1cNuun1gmWJabkmdL3wRVQTnkEHYnzTw/ywCoZ3gqWVQRzC/yc01ZFp9QjIV/lTiwEC+A5uOeYQGL9Mo6LG9I+OHVE+gQlV6eGcW0XN4bZmBkECMIJ76KSa9COLtoDpnGaIQSNdOEQN7UpcIHb8I+AS8eYnZH70nfZownZw2uicpmvGPRJd0wzE3cq/opKPWQ+F2jmtzHCTZKpH1ALn237DUCKIVuPHlHtbjkQHMzi8cCCJUQSXaQ+HEWT0OkLHbzIW+kLxmOhqOJ2GlOBtjBchscodDtT7xi4KZ4h2qe6Bnwi9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wkpIb/z8eiIlRllcG96IJyMPPG0asRaSYB/J7lUyigk=; b=U03t2EReHonjcqSUXCaUNpTxTi2rNMd6PeaH+k4hGG2QV1L1jCtfiuZAUlW66+h5HsFi2kKb2Er2VQ/ei2YS6KlrxE9kuyHzsqE4ONOZEbip+kMo0TCyvYE6mDZsf0kE68t7viIgSsj4kc7Gsir4pLIx2G03wBVo6t00ZiAL8SE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 8 Nov 2022 17:49:06 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Henry.Wang@arm.com, ray.huang@amd.com, Alexander.Deucher@amd.com, Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present Message-ID: References: <20221108135516.62775-1-roger.pau@citrix.com> <9b785cc6-2de1-a522-9e57-62c0421c6a21@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0109.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::25) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN8PR03MB5057:EE_ X-MS-Office365-Filtering-Correlation-Id: b4f29643-0a2e-4551-62e5-08dac1a92961 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UiViT08FhntS1SJRbcEPFcvNkN9qeAZAYfFB0BySlHiqORqdUDBPeFnl3hwL3m2jnYLV5EVrlcaNbWpmQBVMRUfcvzXxTm33mHpPzNcPqAV1PKUluSEEUpTYVg0cDWrlZFMEfgbxYVBBZAhU+QchXGMfT7NaF9j+2iF/xxwgJvNCZc39jNCrDdYyOBON32Bs2a45otyxaOI+gZOs3Md1ugqC/altFdAVd1QOze5hxP1l5oVcPPjL+jguq1qoAgNC3Ppg1dhoyC1bEAtYjkVDc/ZOdj1oyvir+DZdgUyZwZGAkciNP0jtocpQQN3JvM8gOMA4ZTmyvMUpCKlp0yabRAlMG1a/6V/nUOcHC91TxunyKgYmBDT5u4T336X4tfAGPjsMKcU4A9I38JcdBqPyMYGkXJIBsYS13Syb+xnu66AmaUvDkhE5Q8Cb3CGgLkqAnVYaXzVRdwxXSVIti5cIXA+NDE7PX2kwRnNJ79WZ0p3o+u+biaZNLbsFfH2mmUIq/bLkYpXRhgBER7zfS8B0qmUIt9itAhh1aYYKb2vBKkmSCEexDG23pf8jc+vh/3HHW9e1Go/DqgxEeCs6TUFHLcoIJ3pQqCmTKo1bDnRPkNIe1K67a0P9c5Iy8+kej2RgWMr0K0UkbxhLBZZBHxt2sml8PzXEpM/h/VJGpRTRGf9kchi1Yr1DslYRbuFph3t3zsTZHtzjBdO/+h3I/os/quUduejwQbQUNARhMcJ4vTc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(346002)(376002)(39860400002)(136003)(396003)(366004)(451199015)(86362001)(85182001)(5660300002)(2906002)(53546011)(6506007)(9686003)(6512007)(26005)(38100700002)(82960400001)(186003)(66946007)(66556008)(66476007)(316002)(6916009)(54906003)(966005)(8676002)(41300700001)(8936002)(4326008)(478600001)(6486002)(33716001)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFRqL0lhdUovd1lpMXhnTC80YXdxS1lUOFU0MDB5a0U1c2w2U2syZFFXMzda?= =?utf-8?B?dTB4QzNrRXBJTnhFRi9HYkFZZ25HR2IwZnB1YzR0a0RtS0t3OVhrZSs1dzF2?= =?utf-8?B?OEppeWdrWGRvbUdlOTZPMERYeGgzdFpBbmJFWVlnalBvWEEyZzFrcW9WY3Zy?= =?utf-8?B?ZGpCZ1FEYmwvZi9GSVVkejZGd0F5ZU92eGZHSCtoSUw3N0JRNDZJZEdBcGd0?= =?utf-8?B?V2xWNms4UWNLdmhiMXZLUlNZY2UxeHpjRTZobzViLzl1UUNHdUZIWHZzY2hG?= =?utf-8?B?ZCtaaWxndkZnVm9VMElSVU1vdWtVY1Bxc2h0YnJydzJDY0pVL0tFcTFKcDRr?= =?utf-8?B?TjM5UjJad2ZkWHlobGtaYkgwSzVzZlozcEwxMERLRHVqcTMzSWJXUjZSTGp4?= =?utf-8?B?dlBDeDhxNmlRWmxwM3ZmR29ObjY1OWZFL3pVODFKZ2JvY0VpREsxcGZNOUl6?= =?utf-8?B?bDN2a2IwWm1oZTczcG9McGNmZDBsY284TWNqYjgwcVl1MCtpVGtheEMzdkh4?= =?utf-8?B?cktXK2FlbjRCVlE3NEVOcHB2ZUxSZ05VRno2SUxmMXRzQUtBeHk0NlRuaUU3?= =?utf-8?B?S1liUG9JajROa2Fjd0tFdXRidzdXWkNIWTJvSGJ5MnBuQnRhWkpPVlI3V21i?= =?utf-8?B?QmxlSmkyZXU5SVEzdjNaM1lyS0ZxaFNwYjVZSXhNNUFNVmo5akdRb3FoOWEr?= =?utf-8?B?dHFNUEg0aVFLbjRqK2gvemt3bHA2STAvUEphR2hSYzJnZVFnOGdhY1M4ZS9I?= =?utf-8?B?QUNpVjNjaHV2VytQemN0SmM5a3ZWTTU3b0t0b01YYnBLWGRtelFYNUZiOXZG?= =?utf-8?B?bTg5TGlNeC9OYjF2c1F3dXRhcERQdjRHbzJWWm9UaWx2bi9RT2F3WVdoVzht?= =?utf-8?B?QVEzNlFCRGJ6bDJmbTk1dkMweFh3T1JUQTVSSFo2VUU3dlM5WTJ3REpSUTd6?= =?utf-8?B?dk5ndXJObTR3c1hVdTVGNTRkZWhvaEplazJRdGNHdFNkcmgxUjBIeUtxUXdz?= =?utf-8?B?aytlRzhLL1VTbWhqZnMva3ptaTlmS1Zad1lIYURzZ1BiaXgrZnlXT3B2VFpP?= =?utf-8?B?bjJYeENsckRtK1FCT05IR2hZa3ZSWHd1Y1Q4MDNmVDVrckExVjB4YW5YTTl3?= =?utf-8?B?TmlOaUJWdjFYSWNkc1JxYUo1VTBvbHJKcWZmckZsVDRjQXJlYTV3QmVuSU1J?= =?utf-8?B?UUplMk9CNFFKa0l4VmtmWm51UDNmdWNrVzhCWXZUZ1Nvc3g1T09jeHJqMFRR?= =?utf-8?B?YVdRSDEyci84eEdFMWVVdWlNbnZlcVJmaUt1c243ak1yb0xRRDZKMFFrcHBj?= =?utf-8?B?TUo5YjY3NERWcFMzN1NFeXo1cHArZEQ1Ykx1KzQ2aGI2TjV1bmlvMVpmUU1Q?= =?utf-8?B?WFZwNFUwQUdPbEh1Y1RPMG16enlQNkVPdTJyRWUwUEwycTBMc25vM3B4Tlh1?= =?utf-8?B?Nzk0bVlJR2FHKzRlVGNGVEZKTG5zcU00QlhjbWZPVkFUZGxSRWFRZzRTTmR5?= =?utf-8?B?VXFjU2dobGljaGg4Vmk2ZWgzK212bzZrZTF0RjJ0N0UybDJ3UzVNQzgvclVQ?= =?utf-8?B?QngxOU8xOS9maEZyaGcrMHVtUTFFWnJLbVdtemxPVjhZbXdzeThNZWNZNjQ5?= =?utf-8?B?alJKOERQUHVrcWhtZ2VzdjdLT1MwTU40MmhCU2xWWE80bGpwMjQ4RWJPck56?= =?utf-8?B?V3ZEcVAzNGN6aDlOVHg2eDRORGN1YjJ2dWlvMVFEUnNIdTFuMWptWE90cjdp?= =?utf-8?B?aGxYOUJteUY4RjNmU3dBcWlMcHlGS3RYTVZOcHZxVUhDQ2wyRnMzdDc3ZXlp?= =?utf-8?B?T1o0TjdkQW1VZ2hnRDB6WklHTHpZK0w2RzZtM1NXLy9WZUZYRVFYb1VtQUx6?= =?utf-8?B?SlRFSXNVTENOTllrS0UrM1hJSmE3emJ1NXpyZ3JHMS91MTg0cHNrSGFLV3l6?= =?utf-8?B?aXpCaTNJdTV1NFlTZ2xoUEtrdkVMRHJaaUdNVXBJRjVLaEhGMEdMZGZ3ZnI3?= =?utf-8?B?TzA2b3lVUExPSW8wQlFtZE5TdDVkdmVHenF4VGZqanI2RUpzbzI1YVF5RTRp?= =?utf-8?B?VU1DaElPbHMvVlFDMGdZbHpDbUF0dDFCaUx6cWo3TXRrNi9PcjNJZDJMWXQ0?= =?utf-8?B?eTQ1V1lTeG9NTVZjQjMzMVBIdU5JWHcyWTNZUjBaWW5Mb2cyNklvc1BTSVFK?= =?utf-8?B?cUE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4f29643-0a2e-4551-62e5-08dac1a92961 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 16:49:11.7040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MbQIM1Q4SBjrnem7RUUUZyFk2k0keJXDExVdf7mNqnvAIwnvjYILWdC/Rj0z2mbdKZh0yiRnnboGULBLWGAn5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5057 On Tue, Nov 08, 2022 at 05:35:04PM +0100, Jan Beulich wrote: > On 08.11.2022 17:31, Roger Pau Monné wrote: > > On Tue, Nov 08, 2022 at 04:56:17PM +0100, Jan Beulich wrote: > >> On 08.11.2022 14:55, Roger Pau Monne wrote: > >>> The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image > >>> from the firmware instead of doing it on the PCI ROM on the physical > >>> device. > >> > >> I can't find any mention of VFCT in the ACPI 6.3 spec, nor anywhere > >> under Linux'es include/acpi/. I don't mind the addition that you're > >> doing, but there needs to be a pointer to a sufficiently "official" > >> spec. > > > > I've also asked for some kind of official spec, as I would assume it > > should be in: > > > > https://uefi.org/acpi > > > > With the rest of tables not in the spec itself, but there's none. > > > > I could add a link to the Linux header, but that's suboptimal IMO. > > > > Are you fine with this as-is, or would you like me to elaborate about > > the lack of an official spec in the commit description? > > A pointer to the Linux bits is better than nothing, but as just said > in reply to Ray there needs to be sufficient guarantee that "VFCT" > really isn't going to be used for something else down the road. I will leave this for the AMD folks to clarify. I would assume AMD has not picked a random table signature and started using it without having it reserved with the ACPI folks. Having that said I don't see the signature in the table of reserved ones in the ACPI 6.5 spec from August. Regards, Roger. From xen-devel-bounces@lists.xenproject.org Tue Nov 08 16:55:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 16:55:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440319.694477 (Exim 4.92) (envelope-from ) id 1osRsk-0002n6-JB; Tue, 08 Nov 2022 16:55:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440319.694477; Tue, 08 Nov 2022 16:55:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRsk-0002mz-GI; Tue, 08 Nov 2022 16:55:26 +0000 Received: by outflank-mailman (input) for mailman id 440319; Tue, 08 Nov 2022 16:55:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRsj-0002mt-ES for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 16:55:25 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061.outbound.protection.outlook.com [40.107.22.61]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 22d84962-5f86-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 17:55:23 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8355.eurprd04.prod.outlook.com (2603:10a6:20b:3b7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.23; Tue, 8 Nov 2022 16:55:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Tue, 8 Nov 2022 16:55:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22d84962-5f86-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V9B2yDepZDhca9iJkCKWTXXdc8jY2TYsZLvfbDsfjvviM1go6srjJM4zNucu6pqELdQHjN+kO2eKNqPnNP+2fIHJXDsGsb2Z6Xx5ACDsah++flDSofBs96AhwyQgwtECy4PUtYDK8XFMmrXoG4AdtTLdTmy/hoY02KQKBrixZ7hYhdZBHjZriE/IqIrgeR+Z1cG93ddJT++uNCKLn3DMvNWbK6gluP2V5SblncxjiLKy5rnUOROhQObdIBvJtg0Y75/GrfLRRpjtIH+Tyx6Dzhhu1LHiGDgF1WhAvF3IAVla3v5fXqITewy/zNggAKiJW5XJJ73jMXIJH3sWHlcbLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aX+6pI3IRzT1XJTvy2bh2DydG0lgzUV0zHMxdp9yMdM=; b=YJoqTUjeUaRMMxlO+qHChSqu+7JB1gUqGfHVJF69oHjdSLboFGfBAYykU2SepX2whfV3K2rHvG4VVvAG2jiK3mGIGUF4akJSJr/FsdvcNzzykZASfDyHi56JQiM7qrrTBP5GbdDLSLXxfEnzC5bX2pptSJajDIbEBZelo2hxluH7ZQUeiHuH9ZtwP35o6S6XSKPALu7O0GtEkP1S8BXz5AOMi/WBH610ahJdxHVC/st9S5WAryLHWor3XAEJqk/TduXgjQPl4beuOauchCU1/jmOiJ1B5XLKoWWguiB90FfQQ6bblFhXj9BgGDP3dk7YRj5fhIgYonbQFgNur1IWjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aX+6pI3IRzT1XJTvy2bh2DydG0lgzUV0zHMxdp9yMdM=; b=J2PjgFC5yE0F1N5ZPyek3IwbiMgT9zWTAJiR6LYbSVQKUnH/i3TFOQ+KRqHjoPG2xZ2R3RE6kAIM0FPpkKMY2nIz6hj8r0pCQ1zhUdTpvttMQ0kvcupLZ+L+Y6tqLX1Z58nS72L93fiFWhKzqMho9L/hDBoBDNBHhz++/UKY+TUBzEyS/HWbpPxQkoWfAdPsIegBpXrdd4cRkhthFXmwfqry2eDOZ3YwP5NAfMmyKsjNKoJq8SRJ6MGsXeqw0ZGVbnLaqlgnTNs2v3GNsGvBPqIyovIvhoVsNl66hkt3OBO3QsCRviZcqyBoMP03QZOue075VljWEDyrLnNUbkJb3A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Nov 2022 17:55:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v7 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20221020061445.288839-1-wei.chen@arm.com> <20221020061445.288839-6-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20221020061445.288839-6-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8355:EE_ X-MS-Office365-Filtering-Correlation-Id: f119a301-b0b7-463d-c0ee-08dac1aa0619 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2ZOZ6xmA2NNnKY1uV2+vjFS33r3L2CqpXGLw8xax21I+AiwwniAdGs7L1fhjDucqT7O22AZA1vLms+Z7P8J67Cw4+2o1LlpztJeMvXkgit4ZqbsOhEC0eQZKc6bwG717eB6FErWFk+sxjJIdBknS7rZp5Fk8NHwLsWAi3Te9hgoezHtATVckza0X84fHSXZElZaRrETnTjfQB6RY4yua3mLRi2w4KKZk1//IoChGVwTwDefitj28ttG9EvT//cCuXix5uqHbaKsU5SiZnfu4BXELdVRT7syBgDNtY0OYU8kpblonxvEKfMQITo5Q/WRl8wawLKrOwr+1w90qHXvDtoGPs3+M/y+wFcNE+fyTTfGw1jIMGsniGXqVuVC1KkfSUmr8zLieRuW8Jxj+UKqnWjx5XkxHOUjCy/Ck9Oqa+KdGGLrsovBzUEyNSOc1gDurYTZ5vDY7bH5A35zpqQnh74g0zdXrtKS/Fp1DDi0k1pebkjlVvWNAJGGk4fdQp/P0H7tjMb/hm/NIfPas6SLW4Nv8t0S2WkfuaOu+yhIMrU4bMNvwNg58puBSmsZ7Clz2QxFklDEKdYa2BiwlWkKdlXLSlQdx5+edxz2A6B31ccW4w5hw0yTB3BvKjpgPgQ0YZAD6hTVWeQ1R8FeHO3c36j8MLDWYwEYHqvj2uhlYdJX+MCkQ4lCR+mqw5ZN42U6vnwNCo+j4wXdGMY/S5FQoOvZabYIFWRRcOc5XxGaWxMdBFMDGnMa06fLkmaGTk2QQymeB3ed4Jo3lkDu9+Ry3YXkU+e3d8nMZjyqe1hx+jqo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(136003)(396003)(376002)(39860400002)(451199015)(36756003)(186003)(83380400001)(38100700002)(2616005)(66476007)(86362001)(8936002)(31696002)(8676002)(41300700001)(4326008)(5660300002)(2906002)(6486002)(316002)(6512007)(6506007)(478600001)(26005)(31686004)(54906003)(6916009)(53546011)(66946007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGV2NXo2ZkxQbTVMaWZGQmlxenlHbXpNTEVMcXFFdTFTMGExejduU3FLeWpH?= =?utf-8?B?bGJUL2tsS3NWV0t3YmZMaVFqc0crVkdYb3o0aDNxbW5rQ3B0ZXJZcjI5SDJr?= =?utf-8?B?WEp6N1BRQnNKRWdvdEprV0pxbkNhWkhZRWx4citRVDJycDRETW1XWld3c2pm?= =?utf-8?B?clRpV3RmM3FLeXVwekNaSFFic1dpOUE3WFl1cW4xcEQwVERieklNaEs0Tm5o?= =?utf-8?B?cDMvY0cybkxGY2h4RmsreGk0eTdtdXVmRlB2S1J4SHlIMWlXNzNtdkRISWhC?= =?utf-8?B?TE1paHZ6Qm9SRG1ma1lZNk9OVGVsYnFIUm82T1RsZk9GVk1YTzZvTEpyU1ZF?= =?utf-8?B?cnRHRWk1M3J4U1VtQ01BK2hCMGdNNVZnYVl6dmRhYTBQNitSWHNWNXAyZTlS?= =?utf-8?B?eG5UZXpvNlZWY3k2QlhiUlplcTNRU1p3RmNjZzdabmFia1NnUzZrLytzamE3?= =?utf-8?B?cGRPVFVYdDdwYXFnQlR3c0l3Q25ENm1WQlB5eGlWVFBqYlNZSHluMURCR2Rh?= =?utf-8?B?eGMrVmRsN0M5alh6RHZiOTFaQkRXMDJGK01PTmVjWG16UEdVMWYxa1p6ZG5E?= =?utf-8?B?ZEJ6VlNMWGREZVhHejlpVFVPV3lwaDYxaWlHUk1lQWxKZTRHYjhOdE5SNlR4?= =?utf-8?B?MW1na0hNY3BUSmpoUDRGdFp3WGRRaXAzUnBXK2FJVWFDMC9JcjVJeXRLUFFW?= =?utf-8?B?cUFXWnJrYmd5ZlZjRUlCZlZhUytBT0FUR0NOT3BlelRHRUloNUR4cFl2cTJF?= =?utf-8?B?RmZyVmlCZFdxeitIblVHOGYreCtrVFpkZngwNUNLcUxGS2xjZkgvRHhZMEh0?= =?utf-8?B?YW4wTWhBUUdhRGM0YW50bFFBZy9sMXBqcXM3bXROYmF3VzJ2OFN2YjV3Z3cw?= =?utf-8?B?b1ljOHZFbXJQeHhkZVcySGVYVDYwOWFJRlJ3b3BkcUt4NW53V1VQdURPVlhG?= =?utf-8?B?OVJhb1pDS1RCVE5pdXZySmZiSUY4UGNMSzZYMERFeEJybi9TMzdVcUV1d3NZ?= =?utf-8?B?d2dkeThRVzRDTXlLYnpHYWVMbVRNb3VRb0lXWlpvSVFDM0hlR0NiVEhpbTlJ?= =?utf-8?B?ajJoKzFnWFZYcW1YY093YnRxazdIOGcwaml2TWNDUjVLRWZCcGtneXdlK0hu?= =?utf-8?B?M0lQRlVFeVlFZEx2WjFISWo4MHFXZmtCUnJUdXpmL3BMbCtEY1BIS0tGSEd4?= =?utf-8?B?WW82YXpZR01tMzdzNURDd2Z5TXVYL0dyeVdWTzNTTXBMeDdTaFUzaW5aNndD?= =?utf-8?B?R0gzdmtFUzJPMnVVYU55L3l5VVpCMG1yRXUydldDcUhGQVNaUThUUlBGZjJ2?= =?utf-8?B?aEN6QkJ6MVR0YmNOMWVOaWI2MVYzVkIvcFFPRWFxU0RMTmpXL1Z3VFJjZnhk?= =?utf-8?B?VHFlWkFXNjFMd2FYOU4vakRtdWlGVCt2anZLZ25BYWZnYnJ0Q1lPK21TbE1H?= =?utf-8?B?ZWF0Um4rYTk4SnlpenhkWFpod3QzOWpQZjhiL1ZjOXl6K2xGbWR0Z0o4Nk1P?= =?utf-8?B?cndFMXVhYVhjcmo2dFF1aVdJSWtGZjk4YUJYVHRrR3JHQkNMeDdYdU03bW10?= =?utf-8?B?VkV3STZYbFFRWnZGZlk4bFYwUzBOTGdnaTZJNm8xa2h1OTVteGkrT2VOTmVo?= =?utf-8?B?NmpFcE0yRGFoTXVmUUlFTkQ4eXJ4eFlNdmR6Vkd6bWRzY3Y2d2MwcGhwMjZr?= =?utf-8?B?SkJIY3FCUkordjU1NnJacXNQaXE5NUt4akY2Zy9CdjVqYTJJYlpaVzZXOHkv?= =?utf-8?B?MVlaL1NLSHc5S2tVdGlSK3VZMnl5R2ZwaU82aFFDUDhodVJqSHZ1N2dEVDVE?= =?utf-8?B?bFBUUHdkSGc1VjFTZnE5R2RaMkliU1dXbk9HWE1uNGljTzJWd084a2tnRjVN?= =?utf-8?B?cHAvRkQ3N29FQmhVMmtUQ2dsdEpBM05QcEFIdWtuMWRZK3dtTjhWUVdWQUti?= =?utf-8?B?M3RLRnpCOEQxcWJRMGl0Y0xFUkJmbWt3TWhVUjU3eXVSWXJuS2QrU1NyYVBU?= =?utf-8?B?a2t1VUNOSVJ4YVBTb2ZlSGtkNXYyclYvbm9JeFBEZlEvU0dUNXNoRmxWRXJP?= =?utf-8?B?a294TlE2Sm1FckpkSGtTeXd5UVdjV1ZZS1FSV3MrV3pIM2dZa1lLMldYK0FX?= =?utf-8?Q?W6LAGXsLOdEIz7Bu8bDPa2F+I?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f119a301-b0b7-463d-c0ee-08dac1aa0619 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 16:55:21.9329 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T9q0Zyjh3gAkoyT6Gmk42RaMYTKze+vBe8FjM8FqsYNyBLqZdik4gKxbGY5UYnNUwdGNrOER8DSEK2h7ZYgs1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8355 On 20.10.2022 08:14, Wei Chen wrote: > x86 has implemented a set of codes to process NUMA nodes. These > codes will parse NUMA memory and processor information from > ACPI SRAT table. But except some ACPI specific codes, most > of the process code like memory blocks validation, node memory > range updates and some sanity check can be reused by other > NUMA implementation. > > So in this patch, we move some variables and related functions > for NUMA memory and processor to common as library. At the > same time, numa_set_processor_nodes_parsed has been introduced > for ACPI specific code to update processor parsing results. > With this helper, we can reuse most of NUMA memory affinity init > code from ACPI. As bad_srat and node_to_pxm functions have been > used in common code to do architectural fallback and node to > architectural node info translation. But it doesn't make sense > to reuse the functions names in common code, we have rename them > to neutral names as well. > > PXM is an ACPI specific item, we can't use it in common code > directly. As an alternative, we extend the parameters of > numa_update_node_memblks. The caller can pass the PXM as print > messages' prefix or as architectural node id. And we introduced > an numa_fw_nid_name for each NUMA implementation to set their > specific firmware NUMA node name. In this case, we do not need > to retain a lot of per-arch code but still can print architectural > log messages for different NUMA implementations. A default value > "???" will be set to indicate an unset numa_fw_nid_name. > > mem_hotplug is accessed by common code if memory hotplug is > activated. Even if this is only supported by x86, export the > variable so that other architectures could support it in the future. > > As asm/acpi.h has been removed from common/numa.c, we have to > move NR_NODE_MEMBLKS from asm/acpi.h to xen/numa.h in this patch > as well. > > Signed-off-by: Wei Chen There's just one remaining concern I have: I continue to consider ... > @@ -341,159 +247,14 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) > pxm &= 0xff; > node = setup_node(pxm); > if (node == NUMA_NO_NODE) { > - bad_srat(); > + numa_fw_bad(); > return; > } > > - /* > - * For the node that already has some memory blocks, we will > - * expand the node memory range temporarily to check memory > - * interleaves with other nodes. We will not use this node > - * temp memory range to check overlaps, because it will mask > - * the overlaps in same node. > - * > - * Node with 0 bytes memory doesn't need this expandsion. > - */ > - nd_start = start; > - nd_end = end; > - nd = &nodes[node]; > - if (nd->start != nd->end) { > - if (nd_start > nd->start) > - nd_start = nd->start; > - > - if (nd_end < nd->end) > - nd_end = nd->end; > - } > - > - /* It is fine to add this area to the nodes data it will be used later*/ > - switch (conflicting_memblks(node, start, end, nd_start, nd_end, &i)) { > - case OVERLAP: > - if (memblk_nodeid[i] == node) { > - bool mismatch = !(ma->flags & > - ACPI_SRAT_MEM_HOT_PLUGGABLE) != > - !test_bit(i, memblk_hotplug); > - > - printk("%sSRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n", > - mismatch ? KERN_ERR : KERN_WARNING, pxm, start, > - end - 1, node_memblk_range[i].start, > - node_memblk_range[i].end - 1); > - if (mismatch) { > - bad_srat(); > - return; > - } > - break; > - } > - > - printk(KERN_ERR > - "SRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with PXM %u [%"PRIpaddr", %"PRIpaddr"]\n", > - pxm, start, end - 1, node_to_pxm(memblk_nodeid[i]), > - node_memblk_range[i].start, > - node_memblk_range[i].end - 1); > - bad_srat(); > - return; > - > - case INTERLEAVE: > - printk(KERN_ERR > - "SRAT： PXM %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with PXM %u memblk [%"PRIpaddr", %"PRIpaddr"]\n", > - pxm, nd_start, nd_end - 1, node_to_pxm(memblk_nodeid[i]), > - node_memblk_range[i].start, node_memblk_range[i].end - 1); > - bad_srat(); > - return; > - > - case NO_CONFLICT: > - break; > - } > - > - if (!(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) { > - node_set(node, memory_nodes_parsed); > - nd->start = nd_start; > - nd->end = nd_end; > - } > - > - printk(KERN_INFO "SRAT: Node %u PXM %u [%"PRIpaddr", %"PRIpaddr"]%s\n", > - node, pxm, start, end - 1, > - ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); > - > - /* Keep node_memblk_range[] sorted by address. */ > - for (i = 0; i < num_node_memblks; ++i) > - if (node_memblk_range[i].start > start || > - (node_memblk_range[i].start == start && > - node_memblk_range[i].end > end)) > - break; > - > - memmove(&node_memblk_range[i + 1], &node_memblk_range[i], > - (num_node_memblks - i) * sizeof(*node_memblk_range)); > - node_memblk_range[i].start = start; > - node_memblk_range[i].end = end; > - > - memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i], > - (num_node_memblks - i) * sizeof(*memblk_nodeid)); > - memblk_nodeid[i] = node; > - > - if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) { > - next = true; > - if (end > mem_hotplug) > - mem_hotplug = end; > - } > - for (; i <= num_node_memblks; ++i) { > - bool prev = next; > - > - next = test_bit(i, memblk_hotplug); > - if (prev) > - __set_bit(i, memblk_hotplug); > - else > - __clear_bit(i, memblk_hotplug); > - } > - > - num_node_memblks++; > -} > - > -/* Sanity check to catch more bad SRATs (they are amazingly common). > - Make sure the PXMs cover all memory. */ > -static int __init nodes_cover_memory(void) > -{ > - unsigned int i; > - > - for (i = 0; ; i++) { > - int err; > - unsigned int j; > - bool found; > - paddr_t start, end; > - > - /* Try to loop memory map from index 0 to end to get RAM ranges. */ > - err = arch_get_ram_range(i, &start, &end); > - > - /* Reached the end of the memory map? */ > - if (err == -ENOENT) > - break; > - > - /* Skip non-RAM entries. */ > - if (err) > - continue; > - > - do { > - found = false; > - for_each_node_mask(j, memory_nodes_parsed) > - if (start < nodes[j].end > - && end > nodes[j].start) { > - if (start >= nodes[j].start) { > - start = nodes[j].end; > - found = true; > - } > - if (end <= nodes[j].end) { > - end = nodes[j].start; > - found = true; > - } > - } > - } while (found && start < end); > - > - if (start < end) { > - printk(KERN_ERR "NUMA: No NODE for RAM range: " > - "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); > - return 0; > - } > - } > - return 1; > + numa_fw_nid_name = "PXM"; ... this to be happening too late. Not because I can see a way for current code to use the variable earlier, but because of the risk of future code potentially doing so. Afaics srat_parse_regions() is called quite a bit earlier, so perhaps the field should (also?) be set there, presumably after acpi_table_parse() has succeeded. I've included "(also?)" because I think to be on the safe side the setting here may want keeping, albeit perhaps moving up in the function. Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 08 17:02:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 17:02:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440326.694488 (Exim 4.92) (envelope-from ) id 1osRzq-0004Kl-Ef; Tue, 08 Nov 2022 17:02:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440326.694488; Tue, 08 Nov 2022 17:02:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRzq-0004Ke-AL; Tue, 08 Nov 2022 17:02:46 +0000 Received: by outflank-mailman (input) for mailman id 440326; Tue, 08 Nov 2022 17:02:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osRzo-0004KY-Cd for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 17:02:44 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 27a29b00-5f87-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 18:02:42 +0100 (CET) Received: from mail-bn8nam04lp2048.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Nov 2022 12:02:39 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by DS7PR03MB5655.namprd03.prod.outlook.com (2603:10b6:5:2c6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Tue, 8 Nov 2022 17:02:36 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%4]) with mapi id 15.20.5791.026; Tue, 8 Nov 2022 17:02:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27a29b00-5f87-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667926962; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=jI8XVAPImvBtlvH0QDbvE7jiKZreGu3vGjC8uVGCc0Q=; b=RKR0bfxO/O8FqtPugi3PYUdDppYu/s1gK6KODY03J18OAcCw92TsXRAW R6K8SCYTz0DbNHu0HRUP4rFBicRupaPjK03NubkdDitMD5jG2Qy00Bkew GOGAxmD8lO8nnU8kcF3T8GatqAd5W5sASYxTWTCBFIlL/w9IS1E/cd0Od 8=; X-IronPort-RemoteIP: 104.47.74.48 X-IronPort-MID: 84837486 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:LYuBfqJjZepd5IxiFE+REZQlxSXFcZb7ZxGr2PjKsXjdYENS1mRSz DcbXTjUaavZYTH3KY8iPYm38EsP65PRy4BqHQplqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wRuPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5bEW9V1 vtJFQwHTU2DrM+k2oPqG/FV05FLwMnDZOvzu1lG5BSBUbMMZ8CGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VrpTSDpOBy+OGF3N79d9CURMMTgkGCo WHu9GXlGBAKcteYzFJp91r82r+Uwn+rBur+EpW29c9XqU+B/lVNDQZNbwCrpeLjshWhDoc3x 0s8v3BGQbIJ3E62StjwWTWorXjCuQQTM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz FDht/PkAyZ+9oKcT321/62R6zi1PEA9IWYcaAceQAAC4t2lp5s85jrQSv5zHajzicf6cQwc2 BiPpSk6wr8V3cgC0v3n+Uid22784J/UUgQy+wPbGHq/6R90b5KkYIru7kXH6fFHL8CSSVzpU GU4pvVyJdsmVfml/BFhis1UdF11z55p6AHhvGM= IronPort-HdrOrdr: A9a23:bwZuq6HLpPHT5q51pLqFS5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTjLJr0Unp91yy6 RNwiaQsIdWFwrJmGDn68HPTAwCrDv8nZKz+dRj8EC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBoPkoLVeLizNbFwg2PwqT+GLEXQI+llluhEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8 o= X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84837486" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lg7N7g9WAyY+45d9Gwqjub6g/IAPsQpT+fyJTbdfk6a+AtU0sL+JOrgn/jZKKiqUkZ+B90nfgn6CNkgmx4a1BjmU6eg3MoIRUpK9wX3phqYzUvGavlEfxSQLSGR/TyPySs/XimX2RR0tJ+2hOR9JsS+97SH3+JCyqIeADmp01FCd/sbxV/8bS5M5QY9tOrbZAHVwC42YArx4DKFPTCQyO6MIH10pURIwjsVxR3Fjl3dOV8xwWUWTuQuMAmWbV1fEi4KkarpecWvAKkexTc2w4IVm2ofOckhXdVPgrcEqCS0DXHG64lz6xODghoukR65RIwE/5wFmMNC8FFGwD6XJvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jI8XVAPImvBtlvH0QDbvE7jiKZreGu3vGjC8uVGCc0Q=; b=ffNlGUsyX1F6sy9T0ECrc67PzgUOJTV9HWOWng021iWundEdJZU9S9oyFmx2rjpKItg2eGAr+fa3KqZrneKFNJJOyILH2bncncST4nvEdyG+YeqHjdJjLytt9zcS3uw/48CsPi8iRTQpk+FKW7BOoEQr9DB/xHJBbE8+d+/N1i4cP44E5vceLpKk47fTG0idijuTu9fswiXX/f/8Tm+OJbnJ2swlWE3L7+t+xYwjrjQgJFirUF0pMRpO+/hK41mDS4ORH4wAxZ6Ub1ZgNpNmDSKfCKbiSKMCLcc1iVDYk2p8CURWvq/5AYGZoNOJRVHzmM1JCgde7Ii3omoaGo41JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jI8XVAPImvBtlvH0QDbvE7jiKZreGu3vGjC8uVGCc0Q=; b=G4fh1A1L2kPUIpNnrvDZleduKzI9fUx/d9MXTi0Zw0w46T0MFBk1zphAUPkMaBfM+Om0xOFvUcWd2k8z7jVK1aaeNKoPinFS3gyr8CnLFKDPA592nniI9wSomtXwBOUrqpE84awndLHK8g1V8MejkJvRnAYqm6RseoZjDKPl+XY= From: Edwin Torok To: Julien Grall CC: Xen-devel , Henry Wang , Christian Lindig , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Index: AQHY84fA+Ym2JRve3kKJcIO1APAKeK41MEgAgAAQaIA= Date: Tue, 8 Nov 2022 17:02:36 +0000 Message-ID: References: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> In-Reply-To: <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|DS7PR03MB5655:EE_ x-ms-office365-filtering-correlation-id: 96d7add2-16c0-458d-6cd4-08dac1ab090f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lOEU/FxOqs3TcDl+aSNhzMMHjk+RZKoSz2sHsREs4Cz5DkHsZ9Qv25Nk4NobNZm2+LZoSEE91sLbOABm+UifGQIVy0KjSmVkOIJ0R9Skh54ozuFH3ifw1W52iKuQ50sU1Cj6GtWfQuwWI6poL2KIVD/TjAr8znDfN8bYmTopaKm/OIWtR4AEpUuAnrHo4BjWLVqHUt3sqJ90RR4n4U3XEyk+EbbBSl08e1fQnPXqadicKzE3mEtaMm4I2+80s/3fVdO/U2PXlDMUxpcqBQHq8w3iFDxCw931ebYWimM6vJZhjOf4wmdauQYqagN6UUPCWwOhcYXT943t/NLVPG4ZdF3DqTWL5xYNptfYvnVfw10U6p/x3GqV6xFsfEJLumyvqc7oDugPpReErYAFwi1du8Q4MgfsvwDsfortaQhdyfyfiYcEa0QxrR/Vz+7LeVnb/bkBmbxTh3ieRJYjrGvAAQGFa87vd0FxoRlUzQiLB9rLOz0LnXR/z1Oqg0UV6ejA7l6WmNroNZ6gS9l9PdFQRMa2TuWIenZ3v4xpkCtijJToVAasd1LGVJrBSgF6kstNJ3dkqJO43RqAi7mNlZoyjnGjqz9W6135BoI68TibycNJk3uSv3XNoEgxyxkaM2Y7egBiyJex1wtzrG0GyA3eSRW+wDALlJzmpmcPr/20OZF8v1F96g3Uz/jjLdJ2bTsrqJPlHRTijuwB7l4MLzkTJodJPdDrTYtUQ7est0QJIPXkWjNReLwT1LQOcEI4v4Sm1GKZuM7YV/4AnJh//6h5OAzT7LI3+7N0XhKfrJ0wAU8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(366004)(39860400002)(376002)(396003)(451199015)(36756003)(122000001)(38100700002)(82960400001)(33656002)(478600001)(38070700005)(83380400001)(86362001)(2906002)(107886003)(186003)(6512007)(66574015)(53546011)(6506007)(26005)(66476007)(91956017)(71200400001)(6486002)(5660300002)(8936002)(316002)(66446008)(2616005)(6916009)(64756008)(8676002)(54906003)(66556008)(66946007)(41300700001)(76116006)(4326008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dXRwV1ovbEtqQkxHdWhGSVBPbTBjcTREVWJiYVpNT0hRWGdKcXc2dlBxSW84?= =?utf-8?B?SnFIV3o4UC94ZE5GcjNNTmZ0U2lPRVBTVU5OazFSM0lUSHlyRnJKRmVGV1Qy?= =?utf-8?B?VzBPamRueVd4eTBWY0I4bmlIQndMYXhxV3Y4OERpbnRIdzROdW84aEtmUnRY?= =?utf-8?B?ZFdGOFhtZGlGR3JEck1kakdhbm1QZlI2ZFZGN2xFQWhCRWd6NXpMUHl3blFv?= =?utf-8?B?UkVvM3d1RHFENWtTSTNLZ0NYckdaMWx3T0VBV2tzaFBxZDMzTHR3NDYrTWZL?= =?utf-8?B?UzhvSUF3dDdIcy83VTlmWUxqWFMxVVlvTUlUejEweDQyR09WdHdGNDZPL0M2?= =?utf-8?B?THRGdVpwMmY2SUZPaGZFYTBUTTBFVG5GckZURmlCbVh4VmV1b1hJNElSSUxE?= =?utf-8?B?RWdkRnpuKy9GcFhEWWpDS3dYT0l5enpDRnRFT1NNZC9Na2wycThFVS9mWDdF?= =?utf-8?B?d3NsY081ZExFZ2dZZ2ZVZ1VNRzJMazFxWmFZTFU1YWVTWEtBVXhJVHg1SmQ1?= =?utf-8?B?cU5tMHNQK3AyZ09LdFFvNVpGNDV4OWcrNzVPelN0bS9IeGV6ckZrV1YrZUti?= =?utf-8?B?TW52SGZDNHBkQ2ZBSkpzTzZaZGUySHZsMzdPcWdZbGpyY2tKNk9qbEdrSHJE?= =?utf-8?B?c09SN2tqWWwyUFpDQ29mVWFnd0xTRGVqMHRZaVVvcC9wNmdtSlBDYStNNndE?= =?utf-8?B?T3VveUtWRnlVRTlaeFZGOWNMdmJ2RGRVL3VmaU52UjIwZU05OUZWemZIUmx2?= =?utf-8?B?OHBZNys2aWJzUkp0S2FmcHpreDZnOXFid2pNN05SYmRrYVkwaUJOak5Tdm4v?= =?utf-8?B?YlB0V2g3T1pkSWxmUmF6YWhzT29EckVYQjhDMi9RSVVoNFd2NGdwYVNTbS8v?= =?utf-8?B?QVo4YUk5azFkb2w1ZWYzUVpTd1dJQkhpWWdKaG5NOURtV2VaMDBQek05anM3?= =?utf-8?B?dm40WUFnNTNTQVlVNjN5c1FHWlJRenN2WjJQaytXT0hYSllLaEd6aVpUNXhF?= =?utf-8?B?MkY0NHF1bTZpSW5RVUtmTzBWeVVsMVRnbWM1b1I1dlpIU3dkTnlsbWZDVDcy?= =?utf-8?B?M0kvMFNVbzFGbFFUNTVUakZ2OG1TbGNOdXBRL01sbStEUFlJZzR4SENRWTlX?= =?utf-8?B?RE11dGVndmZPbk1vUnFodXhIcG95VElVcjdVWG52Q3VIQW9EZzZhNlZXbTcz?= =?utf-8?B?bzNrWko5V3ZKQmg3d2IrQmlvbnZPd3E5UkV1U2YxRDhDSUJIb2dueGd2QWg1?= =?utf-8?B?blF5TTkwN3pwRnkwNCtISnBqVEloaGVNYkNSSmlrYlJxZVVFUEdZWHhFcEpz?= =?utf-8?B?Qng5V1MxTzMyL1BvdTNsRHJmMEV4eTVDR0VCbC9DU2JsUEZZY1IwbXJ3VEdY?= =?utf-8?B?bWsyc2ZzWWhpQlBCK0huYlo2ZFVlSDRaa2FLZHpiakwrNVB6V2JqOEJCQUlp?= =?utf-8?B?eTZJNkhnSkhndjQyRWdGclRyRVFHK3hEQ0Rpa3VPM3I1ZTBWcjQ3V2QwVVJZ?= =?utf-8?B?UGRjZmdlYThFUnJBazlCc0RSenErOEpLWlNnQUEvblRaYXpyYmQ3MW45SzV4?= =?utf-8?B?aXhTRWY3YjF1Y2JZbTduWWx5NDZ2QzV5QVJSLzZmTGF1V2FuZklKREJmSENP?= =?utf-8?B?QUNpcm1BSCticWtPczRKaTdxbEFjbnJzdW9iRmlWalVQTklzUDZxaUx6a1RM?= =?utf-8?B?RUIvSExURnJwRjdqN1huY3pSZlpySC9Mcm5xcm5uOElJajZJd3ZhZFpMU01K?= =?utf-8?B?Y2VycDVKWjFpamhvcm1oY3NhOTBIdnVmK2tpK29vQ1BDeHk0NEIvcFFINzZm?= =?utf-8?B?QktwbU5ndWZoS1FNQzhwSVBjVEhENndhL3VPTXllRDh4RmVLc25mTnJScUta?= =?utf-8?B?T1JXM241ekZ3eEo2VVB5MUxzSi9NV0sxdENCN2d0Yi9uQ0daOGtORk00SlNT?= =?utf-8?B?YTBmQjRYaEUrOTRtNi94bi9keEVuN21oWENJVE0yOG5SY1RZMnBWYUx5OTNV?= =?utf-8?B?K1dVY2NyeUR3MGRvRTdXMUkzWTBOaURDVHpQUFRCcmI5a2EzOU55azViMyt2?= =?utf-8?B?NTE5c3JqbUU2NXBYMHpNWFVnL0lTbTJ0eFh2OHV1Rmd6Q0RBQUVKQlViV08w?= =?utf-8?B?bFNINW4rcDZxZ3BzdUY1RnRZdGs1Z3ZsTStEOHQ3Wm1UR0ZRYnNKanRpSG9s?= =?utf-8?B?VHc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <58C53D70DD80C04EB6DF0BC7BED0EB49@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96d7add2-16c0-458d-6cd4-08dac1ab090f X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2022 17:02:36.1764 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D6y0T9aR9I5/cEcXC5FomMwZnNst/UA3pARVjwI2PpAEtxBm8ak4ZBwo4Tz5ls2xYpqDDcOBEk02JKpvybVJ9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5655 DQoNCj4gT24gOCBOb3YgMjAyMiwgYXQgMTY6MDMsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5v cmc+IHdyb3RlOg0KPiANCj4gSGksDQo+IA0KPiBPbiAwOC8xMS8yMDIyIDE1OjMzLCBFZHdpbiBU w7Zyw7ZrIHdyb3RlOg0KPj4gU2VlIENPRElOR19TVFlMRTogWGVuIHVzZXMgc3BhY2VzLCBub3Qg dGFicy4NCj4+ICogT0NhbWwgY29kZToNCj4+IFVzaW5nIGBvY3AtaW5kZW50YCBmb3Igbm93IHRv IGp1c3QgbWFrZSBtaW5pbWFsIG1vZGlmaWNhdGlvbnMgaW4NCj4+IHRhYnMgdnMgc3BhY2VzIGFu ZCBnZXQgdGhlIHJpZ2h0IGluZGVudGF0aW9uLg0KPj4gV2UgY2FuIGludHJvZHVjZSBgb2NhbWxm b3JtYXRgIGxhdGVyLg0KPj4gKiBDIHN0dWJzOg0KPj4ganVzdCByZXBsYWNlIHRhYnMgd2l0aCBz cGFjZXMgbm93LCB1c2luZyBgaW5kZW50YCBvciBgY2xhbmctZm9ybWF0YA0KPj4gd291bGQgY2hh bmdlIGNvZGUgdG9vIG11Y2ggZm9yIDQuMTcuDQo+PiBUaGlzIGF2b2lkcyBwZXJwZXR1YXRpbmcg YSBmb3JtYXR0aW5nIHN0eWxlIHRoYXQgaXMgaW5jb25zaXN0ZW50IHdpdGgNCj4+IHRoZSByZXN0 IG9mIFhlbiwgYW5kIHRoYXQgbWFrZXMgcHJlcGFyaW5nIGFuZCBzdWJtaXR0aW5nIHBhdGNoZXMg bW9yZQ0KPj4gZGlmZmljdWx0IChPQ2FtbCBpbmRlbnRhdGlvbiB0b29scyB1c3VhbGx5IG9ubHkg c3VwcG9ydCBzcGFjZXMsIG5vdCB0YWJzKS4NCj4+IENvbnRhaW5zIGEgYnVnZml4IGZvciBgYWJp LWNoZWNrYCBzY3JpcHQgdG8gaGFuZGxlIHRoZSBjaGFuZ2UgaW4gdGhlDQo+PiBhbW91bnQgb2Yg d2hpdGVzcGFjZS4NCj4+IE5vIGZ1bmN0aW9uYWwgY2hhbmdlLg0KPj4gU2lnbmVkLW9mZi1ieTog RWR3aW4gVMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4NCj4+IC0tDQo+PiBSZWFzb24g Zm9yIGluY2x1c2lvbiBpbiA0LjE3Og0KPj4gLSBtYWtlcyBpdCBlYXNpZXIgdG8gYmFja3BvcnQg Y2hhbmdlcyBmcm9tIG1hc3RlciB0byA0LjE3DQo+IA0KPiBSaWdodCwgYnV0IHlvdSB3aWxsIGhh dmUgdGhlIHByb2JsZW0gd2hlbiBiYWNrcG9ydGluZyB0byA0LjE2IGFuZCBvbGRlci4gU28gdGhl IG92ZXJoZWFkIHdpbGwgYWx3YXlzIGJlIHRoZXJlIGZvciBhIGNvdXBsZSBvZiB5ZWFycy4NCg0K DQpUaGVyZSB3aWxsIGFsd2F5cyBiZSBtb3JlIHRoYW4gb25lIFhlbiByZWxlYXNlIGluIHN1cHBv cnQsIHdoaWNoIG1lYW5zIHdlJ2QgbmV2ZXIgYmUgYWJsZSB0byBmaXggdGhpcy4NCkF0IHNvbWUg cG9pbnQgd2UgbmVlZCB0byBkZWNpZGUgdG8gZ28gYWhlYWQgYW5kIGp1c3QgZG8gaXQgKHdoaWNo IG1heSBvciBtYXkgbm90IGJlIDQuMTcpDQoNClRoZSB3aGl0ZXNwYWNlIGZpeHVwIG5lZWRzIHRv IGhhcHBlbiBzb21ld2hlcmUgYW55d2F5LCB0aGVyZSBhcmUgYSBjb3VwbGUgb2Ygb3B0aW9uczoN CiogdXNlIGdpdCByZWJhc2UvY2hlcnJ5LXBpY2sgLVhpZ25vcmUtc3BhY2UtY2hhbmdlIHRvIGF2 b2lkIGJhY2twb3J0IGZhaWxpbmcgdG8gYXBwbHkNCiogZG8gYSByZWZvcm1hdCBvbiA0LjE2IGJy YW5jaCB0b28gKGJhY2twb3J0IHRoZSBjb3VwbGUgb2YgbGluZXMgb2YgTWFrZWZpbGUgY2hhbmdl IGFuZCBydW4gJ21ha2UgZm9ybWF0JyBhbmQgY29tbWl0IHRoZSByZXN1bHQpDQoqIGluY2x1ZGUg dGhlIHJlZm9ybWF0IGFzIGEgcHJlcmVxdWlzaXRlIG9mIHRoZSBuZXh0IHNlY3VyaXR5IHBhdGNo IChJJ2QgcHJlZmVyIG5vdCB0bywgaGVuY2UgaW5jbHVkaW5nIGl0IGluIDQuMTcpDQoqIGRvIHRo ZSB3aGl0ZXNwYWNlIGZpeHVwIHByaW9yIHRvIHN1Ym1pc3Npb24sIHR1cm5pbmcgYSBjb3JyZWN0 bHkgZm9ybWF0dGVkIHBhdGNoIHdpdGggc3BhY2VzIGludG8gYW4gaW5jb3JyZWN0bHkgZm9ybWF0 dGVkIG9uZSB3aXRoIHRhYnMuIEkgd291bGRuJ3QgaGF2ZSBtaW5kZWQgZG9pbmcgdGhpcyBpZiB0 aGUgY29kaW5nIHN0eWxlIHNhaWQgdGFicywNCkkgY291bGQndmUgcnVuIG15IHJlZm9ybWF0IHRv b2wgbG9jYWxseSBhbmQgZml4IGl0IHVwIHdpdGggJ3NlZCcgcHJpb3IgdG8gc3VibWlzc2lvbi4g SG93ZXZlciB0aGlzIHNlZW1zIHVubmVjZXNzYXJ5IG92ZXJoZWFkIGlmIGRvaW5nIHRoaXMgd29y a3MgYWN0aXZlbHkgYWdhaW5zdCB0aGUgZXhpc3RpbmcgY29kaW5nIHN0eWxlLg0KDQpIb3dldmVy IGlmIHdlIHB1dCB0aGlzIGludG8gNC4xNyBhbmQgdGhlcmUgYXJlIG5vIG5ldyBzZWN1cml0eSBp c3N1ZXMgZGlzY292ZXJlZCBiZWZvcmUgNC4xNiBnb2VzIG91dCBvZiBzdXBwb3J0IHRoZW4gd2Un bGwgYmUgaW4gYSBtdWNoIGJldHRlciBwb3NpdGlvbiBmb3IgNC4xOCBvbndhcmQuDQpUaGVyZSBp cyBzdGlsbCBxdWl0ZSBhIGxvdCBvZiB3b3JrIG91dHN0YW5kaW5nIGluIHRlc3Rpbmcgb2Ygb3hl bnN0b3JlZCAodXBkYXRpbmcgbXkgZnV6emVyIGZvciBvbmUpLCBzbyBJIGNhbid0IHJlYWxseSBw cmVkaWN0IGF0IHRoaXMgcG9pbnQgd2hldGhlciB0aGVyZSBhcmUgbW9yZSBzZWN1cml0eSBidWdz IGluIG94ZW5zdG9yZWQgb3Igbm90LA0Kc28gbWF5YmUgd2UgbmVlZCB0byB0YWtlIHRoaXMgZGVj aXNpb24gYXQgNC4xOCB0aW1lPyBOb3Qgc3VyZS4NCg0KPiANCj4+IC0gYXZvaWQgcGVycGV0dWF0 aW5nIGEgZGlmZmVyZW50IGNvZGluZyBzdHlsZSAoSSB0aG91Z2h0IHRhYnMgd2VyZQ0KPj4gICBt YW5kYXRlZCBieSBYZW4sIGFuZCB3YXMgYWJvdXQgdG8gZml4IHVwIG15IGVkaXRvciBjb25maWcg dG8gbWF0Y2gNCj4+ICAgd2hlbiBJIHJlYWxpemVkIFhlbiBhbHJlYWR5IG1hbmRhdGVzIHRoZSB1 c2Ugb2Ygc3BhY2VzKQ0KPj4gLSBzaG91bGQgbWFrZSBzdWJtaXR0aW5nIHBhdGNoZXMgZm9yIE9D YW1sIGVhc2llciAoT0NhbWwgaW5kZW50YXRpb24NCj4+ICAgdG9vbHMga25vdyBvbmx5IGFib3V0 IHNwYWNlcywgc28gSSBlaXRoZXIgY2FuJ3QgdXNlIHRoZW0sIG9yIGhhdmUgdG8NCj4+ICAgbWFu dWFsbHkgYWRqdXN0IGluZGVudGF0aW9uIGV2ZXJ5IHRpbWUgSSBzdWJtaXQgYSBwYXRjaCkNCj4+ IC0gaXQgY2FuIGJlIHZlcmlmaWVkIHRoYXQgdGhlIG9ubHkgY2hhbmdlIGhlcmUgaXMgdGhlIE1h a2VmaWxlIGNoYW5nZQ0KPj4gICBmb3IgdGhlIG5ldyBydWxlLCAnZ2l0IGxvZyAtcCAtMSAtdycg c2hvdWxkIGJlIG90aGVyd2lzZSBlbXB0eQ0KPiANCj4gV2hpbGUgSSB1bmRlcnN0YW5kIHRoZSBn b2FsIGFuZCBzdXBwb3J0LCB0aGlzIHNlZW1zIHRvIGJlIGEgYml0IHRvbyBsYXRlIHRvIGRvIGl0 IGluIFhlbiA0LjE3ICh3ZSBhcmUgb25seSBhIGNvdXBsZSBvZiB3ZWVrcyBhd2F5KS4gQXQgdGhp cyBzdGFnZSBvZiB0aGUgcmVsZWFzZSB3ZSBzaG91bGQgb25seSBkbyBidWcgZml4Lg0KDQpJIHRo aW5rIGl0IGNhbiBiZSBmYWlybHkgZWFzaWx5IHByb3ZlbiB0aGF0IHRoZXJlIGlzIG5vIGZ1bmN0 aW9uYWwgY2hhbmdlIGJ5IHJlcnVubmluZyB0aGUgbWFrZSBmb3JtYXQgY29tbWFuZCBtYW51YWxs eSwgYW5kIGJ5IGxvb2tpbmcgYXQgdGhlIGRpZmYgd2l0aCBpZ25vcmUgd2hpdGVzcGFjZSBhcyBz dWdnZXN0ZWQgYWJvdmUuDQpJIHVuZGVyc3RhbmQgdGhlIHJlbHVjdGFuY2UgaW4gaW5jbHVkaW5n IGl0ICh3aGljaCBpcyB3aHkgSSB3YXMgbm90IHN1cmUgd2hldGhlciB0byBwb3N0IGl0IGluIHRo ZSBmaXJzdCBwbGFjZSksIGJ1dCBJIHRoaW5rIGl0IG1pZ2h0IGJlIGJlbmVmaWNpYWwgdG8gZG8g aXQuDQpUaGVyZSBpcyBhIGxhcmdlIGJhY2tsb2cgb2Ygd29yayBpbiBveGVuc3RvcmVkIHRoYXQg Z290IHBpbGVkIHVwIGR1cmluZyB0aGUgcGFzdCBjb3VwbGUgb2YgeWVhcnMgb2YgWFNBIHdvcmss IGFuZCBpdCdkIGJlIGEgbG90IGVhc2llciB0byB1cGRhdGUgYW5kIHVwc3RyZWFtIHRob3NlIGlm IHdlIHdvdWxkbid0IGhhdmUgdG8gd29ycnkNCmFib3V0IGluZGVudGF0aW9uIGF0IGFsbC4NCg0K VXN1YWxseSBwYXRjaGVzIG9uIExDTSBhbmQgc2VjdXJpdHkgYnJhbmNoZXMgYXJlIGF2b2lkZWQg dG8gcmVkdWNlIHRoZSByaXNrIG9mIGJyZWFraW5nIGFueXRoaW5nLCBidXQgYSByZWluZGVudGF0 aW9uIHBhdGNoIHNob3VsZCBub3QgcmVhbGx5IGJyZWFrIGFueXRoaW5nICh3ZWxsIG90aGVyIHRo YW4gdGhlIGFiaS1jaGVjayBzY3JpcHQgaW4gdGhlIGJ1aWxkLCBidXQgSSBmaXhlZCB0aGF0IHRv IGFjY2VwdCBib3RoIHdheXMpLg0KDQpPbmUgYWx0ZXJuYXRpdmUgd291bGQgYmUgdGhhdCBJIGFk ZCBhbm90aGVyIHN0ZXAgYWZ0ZXIgcmVmb3JtYXQgdGhhdCBydW5zIHNlZCBhbmQgdHVybnMgc3Bh Y2VzIGJhY2sgaW50byB0YWJzIGZvciBub3csIGFuZCB0aGF0IHdheSBJIGNhbiBzdGlsbCBydW4g J21ha2UgZm9ybWF0JyBhdCBlYWNoIHN0ZXAgd2hpbGUgcHJlcGFyaW5nIHBhdGNoZXMgZm9yIG1h c3Rlciwgb3IgNC4xNyBvciBzZWN1cml0eSBwYXRjaGVzIGFuZCBnZXQgc29tZXRoaW5nIGNvbnNp c3RlbnQsIGFuZCB0aGF0IG1pbmltaXplcyBvdGhlciB3aGl0ZXNwYWNlIGNoYW5nZXMsIGJ1dCBp dCB3b3VsZG4ndCBjb21wbGV0ZWx5IGVsaW1pbmF0ZSB0aGVtIChlLmcuIHRoZXJlIGFyZSBwaWVj ZXMgb2YgY29kZSB0aGF0IGFyZSBqdXN0IHdyb25nbHkgaW5kZW50ZWQsIHNvIHRoZXJlJ2QgYmUg YXQgbGVhc3QgYSBkaWZmIHRvIGZpeCBhbGwgdGhhdCkuDQoNCj4gDQo+IFRoaXMgaXMgY2xlYXJs eSBvbmx5IGEgY29tZXNtZXRpYyBjaGFuZ2UgYW5kIHRoZXJlIEkgd291bGQgYXJndWUgdGhpcyBz aG91bGQgYmUgZGVmZXJyZWQgdG8gNC4xOC4gVGhhdCBzYWlkIHRoZSBsYXN0IGNhbGwgaXMgZnJv bSB0aGUgUk0uDQoNCg0KQmVzdCByZWdhcmRzLA0KLS1FZHdpbg0KDQo+IA0KPiBDaGVlcnMsDQoN Cg0KPiANCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Tue Nov 08 17:03:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 17:03:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440329.694499 (Exim 4.92) (envelope-from ) id 1osS0Z-0004pF-OI; Tue, 08 Nov 2022 17:03:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440329.694499; Tue, 08 Nov 2022 17:03:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osS0Z-0004p8-Kt; Tue, 08 Nov 2022 17:03:31 +0000 Received: by outflank-mailman (input) for mailman id 440329; Tue, 08 Nov 2022 17:03:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osS0X-0004ie-Sg for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 17:03:29 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 42ac570a-5f87-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 18:03:28 +0100 (CET) Received: from mail-mw2nam12lp2045.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Nov 2022 12:03:18 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by BY5PR03MB5268.namprd03.prod.outlook.com (2603:10b6:a03:219::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Tue, 8 Nov 2022 17:03:16 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%4]) with mapi id 15.20.5791.026; Tue, 8 Nov 2022 17:03:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42ac570a-5f87-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667927008; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=4lI8yLzbzBtd5q3LdiqCldbuthJ0tZu3BbFa2WJb5NA=; b=SwHS7t8S03Lfa7Wc+JhjSnLx11aUxGpQH3wBvYa+aNJGTf057YrQrwcG fJ9hX8w6zG/04HMwNXP4nf4NdBCGkbcb67Qj1s7Wc5v+mfJtM21VOM+e9 r5UnyIyKf8mJDyXNCybo7OP0SZujNy9rCK8avEtB5Q2l4G3XcvRGSS0l1 A=; X-IronPort-RemoteIP: 104.47.66.45 X-IronPort-MID: 84005473 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:djOnfK/BqeT1QrJZoDH0DrUDQH+TJUtcMsCJ2f8bNWPcYEJGY0x3m 2cbWDqBO/mDZDajKIx+O4njpElVuZTTzNAwS1A9rC48E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKgb5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkJy eAlBzooTiuMgtrmy/GeT9FFq+caeZyD0IM34hmMzBn/JNN/G9XmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTaNilAsuFTuGIO9ltiiSMlLn0Deu mXc+GfRCRAGLt2PjzGC9xpAg8efwXujBd5NT9VU8NY1hmSdzzxULicHC3eqjuuDpUO8VNBQf hl8Fi0G6PJaGFaQZtvgWxy1plaUsxhaXMBfe8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBLRxitqeED02U8Li8pCm3fyMSKAcqaSYaQCMf7tLkoYV1iQjAJv58FIalg9uzHiv/q w1mtwA7jrQXyMsUjaOy+Amdhyr2/sSUCAko+g/QQ2SpqBtjY5KobJCp7l6d6utcKIGeTR+Ku 31sd9Wi0d3ixKqlzESlKNjh1pnwjxpZGFUwWWJSIqQ= IronPort-HdrOrdr: A9a23:ba/cLqspn1JVU9MYL7gVnt4Q7skC1YMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIP/Z4StU z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfpWG0hYczAgNkGmpDr1L8Yqq iJn/7mBbU115rlRBD2nfIq4Xin7N9h0Q669bbSuwqfnSWwfkNHNyMGv/MWTvKR0TtfgPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5TOObFuF4O5gLZvi3+9Kq1wah7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm10xR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XXJ0vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLmzNV1wg2XwqUmGLEfQI5tllulEU5XHNcrWGDzGTkwymM29pPhaCtHHWp +ISeBrP8M= X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84005473" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dIfQvIy52shSpMKjBbay1BXTkZxkZVVdPBJerj9LS8zxugkLFzAzZi77nS6rQLxZACvLK2oprdgRty0liW2kdiuPApx7ugoNhcHxauOkSCJGwEY0bFiiyzbgpDgUC5PoHgWxUyVroWK8hMvr2iAEL+CRLEOsIqIkCUU227xEJAVb0iBIQGkNyjlFl7fqI3VP5ZAnFLtgAcz0VtW/zcTIGJlwLUARt+qz5+oe80AMAGVsX62DQGjVq73gIkV9D35bEsx4nPohZWnE10UfCFqn2YMDg9J79yMrlfbVEYxL9HytiXYdQNqztmKFRSXTBjdesQ9yn5rBLPeQW6YI8CVTAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4lI8yLzbzBtd5q3LdiqCldbuthJ0tZu3BbFa2WJb5NA=; b=c9Rx8MlCPYBvsivXp8wyJ5HiyLozMyHr4qV9t1Tah4tIlZycezLPbggi14Tq/YiqqD2S38rOpAEaO9hpTPIA9nf7rHCqgzbdePPhs1NKGy+bpge/lLflmp98yKAISsxU97Gq3OhBrTippBvAvamOeg65p+MXWF6GUMPaZ4+vaO5VoNhUqqGcZWbT3qdtaa1GE4fDKRwINcaFEKEhIYNr/9Vj/8qewTxfAhP4O6Ek64KhyB96l0k4em950vHB/J4NxsmYc7e5tKfKPuzehgj6mYNRJhgl6wFvjPlB9qHAEUW88+op2n6PplsMJkTORWJrhcywaHvDY62MQv6GATugNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4lI8yLzbzBtd5q3LdiqCldbuthJ0tZu3BbFa2WJb5NA=; b=dX+xMAoAb//hj/scMbQsIrfw2uuMpUSz/qsyPJb3frjMvKc5M2WMZgN742sh8HTEnDCdqzTDrC6ZYkTwQTYUllWe219AS700dX0TVECfmUVXE4saXa+XNLbFdNw43TAOqncN0XhMZN2bIAchZNAqQABBd92K72P7yOkf98PBa+s= From: Edwin Torok To: Julien Grall CC: Xen-devel , Henry Wang , Christian Lindig , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 14/15] tools/ocaml/xenstored/syslog_stubs.c: avoid potential NULL dereference Thread-Topic: [PATCH for-4.17 v3 14/15] tools/ocaml/xenstored/syslog_stubs.c: avoid potential NULL dereference Thread-Index: AQHY84hVR008RTfgG0S7ZZaDJ+Tj1641MUyAgAAPkoA= Date: Tue, 8 Nov 2022 17:03:16 +0000 Message-ID: <4F656868-47D4-4D96-BB5C-6CA22C7020CC@citrix.com> References: <5da5b63bd6a0f8d0f6ad0281773eefb32de8164d.1667920496.git.edvin.torok@citrix.com> <658b1dba-d0e8-286b-837e-a49f791f6ebf@xen.org> In-Reply-To: <658b1dba-d0e8-286b-837e-a49f791f6ebf@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|BY5PR03MB5268:EE_ x-ms-office365-filtering-correlation-id: ba10af33-ff0b-4f75-356f-08dac1ab20ee x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0or6viyO3Y1SkPQ8LXlkxENfS2Rx1BV0r0qgbJezwzS3AQ9zwUrmNPVwZKNdXrfJFMlzfcpNIolxeNwG0/3S+MhdPyTYvl/6Pm+2w9hazpDEiOHGJfvxxMoY3nrQc2WBVmtcjqE1uOG58U26I2qUNAlI47jQ3quMIKZ/Aqv0MSVo2UyGu7oEoRao6fF2Babi7uvaSQIiy+d2Fi6SlPKljSmnpA/AU/miCuUHMA3bdV5vj5gmIJER79+tJCeVXdtrHfarnf/pJVqvLL2JziKPJ3jnQUdmRHXo4Rv8gOi2X61XnFbQhUe9ORKVIwsr42zaYSDXss9P0NXeW2JBvul6RunAy/KdvrNJQTo9aLykdeJqSp+my5ej9acRKDigvhCT57LgYEUVLDY3rmap/yozrM7/v56ZzHocSENljG381ETIbch9yhEUiPRTIrvDMAJHATnNQBZ6tsn+aff0cuLbRFu94tgmFtNh5gTH6I9uD+xrtNswBQfDHgUORNYv7LSRH9e5AzF9vYfylmoqKk2VC9nYe0VrPKyyifZuXnjMpZyynB3dYOp4jzcKbetod/6nG/jUNSQEDx+VHnbn6OxrKCzJccxkaCVfqcGBpxtNx9IqbnGy+8t/vKKHe/JozieRufJWvCkiVMr4LpIIbmtEabg3ph8KuanHu8eYZ/gOsqIEt15p5rTnrNDRASXyDhrkfluElw+5I3N6B/ZoT5DkgOAMQ0vaX2x6XxvesyMwNbpdXSTUjGcs14iJZ3OlHM4V0sZ9TDWOgqbGRjAjIskf7FO8IX76S03P8xJxH6Z1QWU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(366004)(346002)(396003)(376002)(451199015)(2906002)(66476007)(4326008)(66446008)(64756008)(76116006)(36756003)(8676002)(91956017)(41300700001)(2616005)(8936002)(6486002)(33656002)(6916009)(5660300002)(71200400001)(316002)(54906003)(66556008)(83380400001)(86362001)(478600001)(107886003)(186003)(26005)(6512007)(66946007)(122000001)(6506007)(53546011)(82960400001)(38100700002)(38070700005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aGxWTHNhb1kxVzNjSlhzaEFJSWNYWXlCMEpYNWl1Ukc1Ym9DUWp4V2lnWXdB?= =?utf-8?B?UkIvY0dEZXQxYlJQYmlGaXdxMGZLMkZWQ005QkZlMWp5dngyeDUvdTVXQWxC?= =?utf-8?B?T3BFWVR6c1dlQjVtemFIYzZQNG1Hbm5QUnVFazRUYXlWS2NubmRnUEFZcE9t?= =?utf-8?B?Mjh0djBTeU56YXVZSzZ6VUNwNUhha0RmUzZwdVJyM2lxVXlzdSt6b3JaOVdH?= =?utf-8?B?TGk1S0RJNE1Ia1MxckV2SUFuTThuSFkzc29LQjNNK1ZuS2d6aTIyc01SRFh4?= =?utf-8?B?WXV3L2kwTllqZDFTMDZsVVI4ZWF2ZTVxalZXUnpjaHhWejBaM3NMZ1d2cFdK?= =?utf-8?B?dDRtQkhDRzBxRnRneEN2Ykp4TlFGUitLajZMWFBaZ3E4M1p3NHZLYkJhWURj?= =?utf-8?B?N1ZWYkpoY1BJR1o2UXhaY2tRb1ZwMjhQMmhFMjhxQ3N2bnRZNTJEOHVRdklt?= =?utf-8?B?NUM3VEpVUzY1MVkvb25VRkpWeXh3SUZxVUxGWUs3VnQ4clNZbzF6MEZSK1Qy?= =?utf-8?B?R1NYbC9MNlBQcFVKUjJzUytNbnd6UUVaUk9PZ0hNU295UXJvUWlLNVlBbkdE?= =?utf-8?B?aUd2TjgxM2lqSm9hbVFMekZoOXJmN2NmdENiWTV5aDBsMHlRUEhQaEY1cHpj?= =?utf-8?B?ZWRCLzNQMkEvSWpTOGNRcFp5ekEwM0l4YTM0N09wV0lKcUdON01lcndCM2k1?= =?utf-8?B?SUZiOHNwUDd1MFAxN093TEl5Z2luY2pxc0xiaGxPZTJpdG5ubkgxYmt2Y2c1?= =?utf-8?B?SFNtMWhXUkdCU2JaQ2pUYnRBSVVNTlJ1RWxBWCtBL0wxaEMyUWRkZFF0WkJT?= =?utf-8?B?clUyWXFaR2FFVitTS3U3WmlITndkWFg0NzBGazMwdEZlN0xnOXg5U1JjNDRl?= =?utf-8?B?d2pVYTlPdmFQNm5lbjNRRWNoQXIzMzNXNFZiQTdvQzFEVVVGdW9LWW1aV2Ry?= =?utf-8?B?MnBnblhPdU5zSHBIT1I0Q1JQMnNDRHhpVVVSUFptczBIRWJIYUZWSnhta25D?= =?utf-8?B?d3dOaE1XZ1RZMWhJVkpTWE1kaU1hRmJpbE5EcGtBRkVhVWN5bUVUc25STlh5?= =?utf-8?B?bENhUk1GZHlWVXlSSWpGWUh0N3ZFb2FoMGxpaFZKYUtzSDZYeVpXUU9kSVFL?= =?utf-8?B?clhVc0RNRzJ1VzlSK1NnMFhXUFUyYkl4TFVMaHVwWWF6VWpPVWlJRFhoaVNw?= =?utf-8?B?RVJWM2s0eHZhR2JKNTQxWGU0WXRVd2x2ZGZDUkJWMk5HOWVxTU44cWN3anpO?= =?utf-8?B?WGNMTVhKR2luNWZRb1EyMnIxS0ZJR1lzcFhaR3c5VkNUMmxndnhyc3RlTnlC?= =?utf-8?B?TFJZaFQzcmhyaDdjZEtwZGVYUVRSN3llbGF6RllQWElZS2hjR0ZWeFVFRE5h?= =?utf-8?B?RTlLdG0vS05ZVHRKdzZ5SXgxanFMbHNnMSt2QVY0MUdGM2wxSklhK3VidTdh?= =?utf-8?B?U1M4QUswYlcxQkdRSjZ0d3RDdkgxRndOVVo4ZWxoMFdFb3U4L2d5eE1CNXo0?= =?utf-8?B?dXdoekZZWjRYUGdkY0Y4cGUwQnpieFZaZ0VKRklSTjZLMnY2aUNQbVVaR1g5?= =?utf-8?B?cmoyMXJiMEZTU1A3RzBBaWNPN2ZGUDQ1dStiRmNwUStEZ2UySWRmRGU2TDVz?= =?utf-8?B?b2NmbjMvVHRyQjRweG80SDBaVXZKYUdLaSt5dGlaZzk0QjFhTzJoaWNUMkRH?= =?utf-8?B?ZnJDNXFka3BUN2prQUIrMkR5a2xxOFh6VXJvRElRUDhUVEJBblpEekJpV3dJ?= =?utf-8?B?UkVqeUhuVURyRFJuTUlxbTl6LzJ2eDd0aldRWTkwaFBSYjRRUHJOYVc0WXRK?= =?utf-8?B?KzBCa0ZFOWhWM3lweEVuWjJTUVEybEpJTC92Q0pRNDE3MjFpV1dJY2JtWmFL?= =?utf-8?B?c045cVFQUFlwRWdGNjFMb2xDSUxUWjFQSjZ1TDB4RGgvWnlrVWV0RGxGWnho?= =?utf-8?B?RW44TEUyQ0xvbXNNTnFyVFl4OFJZRFBsVUFGbWxySFlwOHhpTzdvVUdFNU1p?= =?utf-8?B?TEM2Y1NBN3I3VEtweTVOdXVNSzY2K3N1R0h5VmZiSVg3WURDVWMvUzhxYnhu?= =?utf-8?B?ZS9LOVgycFdOVmJQazdTTHlDL2JsemxCY0RrOFNXRzd3aHk2SFE0d3M0d210?= =?utf-8?B?dER1SmNlUzFpRC9SckhxNTBzV1NxeXMxbC84Tm9JazcxbmtQeHFkQ1ZMVlJm?= =?utf-8?B?MlE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <4CCAB830AE900D4CA7432DFC934906A4@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba10af33-ff0b-4f75-356f-08dac1ab20ee X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2022 17:03:16.2240 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y2KCJFJL+13eZgW4p2jtBcCKpMSmsRabT2FleEwkeJESoOVQhhLRuxWzjPqfddg6Wh455oNjLEC0v/EwcfqjPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5268 DQoNCj4gT24gOCBOb3YgMjAyMiwgYXQgMTY6MDcsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5v cmc+IHdyb3RlOg0KPiANCj4gDQo+IA0KPiBPbiAwOC8xMS8yMDIyIDE1OjM0LCBFZHdpbiBUw7Zy w7ZrIHdyb3RlOg0KPj4gSWYgd2UgYXJlIG91dCBvZiBtZW1vcnkgdGhlbiBzdHJkdXAgbWF5IHJl dHVybiBOVUxMLCBhbmQgcGFzc2luZyBOVUxMIHRvDQo+PiBzeXNsb2cgbWF5IGNhdXNlIGEgY3Jh c2guDQo+PiBBdm9pZCB0aGlzIGJ5IHVzaW5nIGBjYW1sX3N0YXRfc3RyZHVwYCB3aGljaCB3aWxs IHJhaXNlIGFuIE9DYW1sIG91dCBvZg0KPj4gbWVtb3J5IGV4Y2VwdGlvbiBpbnN0ZWFkLg0KPj4g VGhpcyB0aGVuIG5lZWRzIHRvIGJlIHBhaXJlZCB3aXRoIGNhbWxfc3RhdF9mcmVlLg0KPj4gU2ln bmVkLW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4NCj4+IC0t LQ0KPj4gUmVhc29uIGZvciBpbmNsdXNpb24gaW4gNC4xNzoNCj4+IC0gZml4ZXMgYSBidWcgaW4g b3V0IG9mIG1lbW9yeSBzaXR1YXRpb25zDQo+PiBDaGFuZ2VzIHNpbmNlIHYyOg0KPj4gLSBuZXcg aW4gdjMNCj4+IC0tLQ0KPj4gIHRvb2xzL29jYW1sL3hlbnN0b3JlZC9zeXNsb2dfc3R1YnMuYyB8 IDcgKysrKystLQ0KPj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pDQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3N5c2xvZ19zdHVi cy5jIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3N5c2xvZ19zdHVicy5jDQo+PiBpbmRleCA0ZTVl NDliNTU3Li40YWQ4NWM4ZWI1IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMvb2NhbWwveGVuc3RvcmVk L3N5c2xvZ19zdHVicy5jDQo+PiArKysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvc3lzbG9nX3N0 dWJzLmMNCj4+IEBAIC0xNCw2ICsxNCw3IEBADQo+PiAgICAjaW5jbHVkZSA8c3lzbG9nLmg+DQo+ PiAgI2luY2x1ZGUgPHN0cmluZy5oPg0KPj4gKyNpbmNsdWRlIDxjYW1sL2ZhaWwuaD4NCj4+ICAj aW5jbHVkZSA8Y2FtbC9tbHZhbHVlcy5oPg0KPj4gICNpbmNsdWRlIDxjYW1sL21lbW9yeS5oPg0K Pj4gICNpbmNsdWRlIDxjYW1sL2FsbG9jLmg+DQo+PiBAQCAtMzUsMTQgKzM2LDE2IEBAIHN0YXRp YyBpbnQgX19zeXNsb2dfZmFjaWxpdHlfdGFibGVbXSA9IHsNCj4+ICB2YWx1ZSBzdHViX3N5c2xv Zyh2YWx1ZSBmYWNpbGl0eSwgdmFsdWUgbGV2ZWwsIHZhbHVlIG1zZykNCj4+ICB7DQo+PiAgICAg IENBTUxwYXJhbTMoZmFjaWxpdHksIGxldmVsLCBtc2cpOw0KPj4gLSAgICBjb25zdCBjaGFyICpj X21zZyA9IHN0cmR1cChTdHJpbmdfdmFsKG1zZykpOw0KPj4gKyAgICBjaGFyICpjX21zZyA9IHN0 cmR1cChTdHJpbmdfdmFsKG1zZykpOw0KPiANCj4gVGhpcyBjaGFuZ2Ugc2VlbXMgdG8gYmUgdW5y ZWxhdGVkIHdpdGggdGhlIGdvYWwgb2YgdGhlIGNvbW1pdC4gSU1ITywgdGhpcyBzaG91bGQgYmUg ZG9uZSBpbiBhIHNlcGFyYXRlIHBhdGNoLg0KPiANCj4gVGhlIG1pbmltdW0gd291bGQgYmUgdG8g bWVudGlvbiBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuDQoNClRoYXQgaXMgdG8gYXZvaWQgZnJlZWlu ZyAnY29uc3QgY2hhcionICh0aGVyZSBpcyBhIHR5cGVjYXN0IGJlbG93KS4NCkknbGwgbWVudGlv biBpdC4NCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0gDQo+IEp1bGllbiBHcmFsbA0KDQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 08 17:04:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 17:04:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440335.694510 (Exim 4.92) (envelope-from ) id 1osS13-0005MH-7w; Tue, 08 Nov 2022 17:04:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440335.694510; Tue, 08 Nov 2022 17:04:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osS13-0005MA-4P; Tue, 08 Nov 2022 17:04:01 +0000 Received: by outflank-mailman (input) for mailman id 440335; Tue, 08 Nov 2022 17:04:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osS12-0004ie-BC for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 17:04:00 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130052.outbound.protection.outlook.com [40.107.13.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 56082b79-5f87-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 18:03:59 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9210.eurprd04.prod.outlook.com (2603:10a6:10:2f9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Tue, 8 Nov 2022 17:03:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Tue, 8 Nov 2022 17:03:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56082b79-5f87-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NhjLirYx8UoAZC4CW/S8M21/trTezCwc03cGWGcp9wHPPSiesUwtS7yI1xZFg7YrbKa51rhhKZdkAkl8+YTkgMTc4Im93YtGiM/qBCzTKxdHTLlfyKNJHUyRq7DHxtpJO1fMOG9wb6ueW2+9RyhbovgWJxWOhV3M8iB19kmWfiL5r/zBUXKcyqAfp6YAsI7m57E77OzZcfGwg0X7UnvjfbJd2eB6G2Ht8AuVfKdk4m+YPuJ9JWLwu3mqzUp+rhNbHpqOj9qJ3Gc9eIG5GObDWvsu7ypm4xRbe9iSEs5HdvQGowCsOM+jyX2xKKo3GBM6uim8aToUxFkuN+TPIx+gRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mIwhKR6A6y6PoKtR5lrUX/3UkdxxKbE4L4T14bNkSGc=; b=PebWJZGtbA6BAO9j4uQt2cBprYozPC15eBQU6lEyLcOqFrEHz//uFfdlrQlCryEPJFddUltWXWQKWjFCQsZdfPSXORP2J+QfU3GUtGgbY28Vq4iOziqz/tJnKxVZ1p1I+HQ8+rVgm8YhVv0HnhnPTGEHY/FHj8zUmA6D/ZwyjwSwmTyuRoh7gJsVocRzjNiCMtfY+Nus78yPadvXQn74UWj9faWC6g5cgNAF9hVjv09kJqvwFV1IpkfDP32w8sELP6xIhVZrR1xuiJtqDuxhUIFdsv0SgJW24TbcjHnrj9U8x8NlPUMg40Nc68rlbDR+YjB3QiwXxFPtapNcoM+AoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mIwhKR6A6y6PoKtR5lrUX/3UkdxxKbE4L4T14bNkSGc=; b=ajPiDef4JTBRoDVwBBQu3AS71euX2vF8fc7K0L/jCu9QSbr6xaqQd0/dL/GufCLWb98lMYA4LVLiPt66zr0Byieseqt6T0I9Y4OaMKrUy81oppmmeomS+9GgICbTF7CGJqgVHvqALIwKEZeiMnCEDMHoz+k6zpQH/EMjkVxjStclwwiJxf4FRqbx1FSdJXzjShzxzdW1vjf1JBJN/y6o7P+TAwWzkYNcJvogIRAHMtns3bdTudnnv2fhej4HV2BAFiEkZsABxuWjUKePiM7GwNjlJEag+TONKL2BWHPRu/dy6sb1FhblyZTx6I9aGAydRrCGG9OpIvXd+B6nPqjG3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <58d5e890-e052-47df-42bb-6cc84aedd4a9@suse.com> Date: Tue, 8 Nov 2022 18:03:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , xen-devel@lists.xenproject.org References: <20221108113850.61619-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0288.eurprd06.prod.outlook.com (2603:10a6:20b:45a::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9210:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fae40c1-eed0-41cb-2901-08dac1ab38ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YEqag4xuMcAZVLIvtzsMwSB6qYKk88QoAnKITGWCLKPwJ6HBxRMvrnBZQJ5DQGLTfuET4OJdzWKGQd5/fhvTBOHIhqfZCMuZqZImgVxu66gNYPT5kHPE0WZCUwfEgKeTYPkllMlvaGEmxbqgmNiHrQdXhfEvJ8Z2l0wic2h+8mmD3FxXMlOznWa9EtC5zY5YMFjPcdv0Sm/H3/++M+xOHsTe56qSZzZeTXA0EBgqA+auTc4G0nb/hieTpnlR6KNEosFSh1XrW3NqO3cDPHYMmlhoqJZENlTwn65gwI//IYouDXgQlNJVJt39uLdtgAN7hNr/2NGnhuSaUqFZ/LEddKplETQ40mZRhNqhGfko3OCIAF3iKvM5mVpSPyc2PscmYIUAIGTbngmRs5gldV76w23tmyFQNA0sas/aURbPxLyCiyZb19Ydrksvp1u/5Xfiqt/fr0mKOr7j94Rr/ciqrXWvpkGBjyBm9AdIjCreigHuA3f/oYlJY0pLDk/EGBlFtQoGocTl9m0jevEi5S7RXqDYs3HX8w06er4zEqSIQigKcPYVMpcZdJtSQwjIHSCTCN7YiEXCFoPcGjk7fTrWUcOrVi+RLriFgm0oHGJ57bazQn/wRRW5Uia8EvgQH+rBdgueZre6t64wa6Apf83IcbEX8DHekoZNcnKVqZT800DBz2WBFim7mtIq8jndfJErZUsiBD3O7Y81yEdWBsHvnq4NwnIGHJtP9iqSWuqYXSK3PTw6ppEd14ZKJjNtJI8AIPnnoZLch5IInOcbBTlvLvbJ6vzEz+1ofXtrtIMM0iI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(376002)(346002)(396003)(366004)(451199015)(316002)(31686004)(6916009)(54906003)(8676002)(36756003)(66946007)(66556008)(66476007)(4326008)(6486002)(38100700002)(83380400001)(478600001)(41300700001)(186003)(5660300002)(2906002)(26005)(6512007)(8936002)(2616005)(31696002)(6506007)(86362001)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2RrditCYlpRNXVqMmNZQXR4alo5NDBTK2hSWVlrUXptL2p4L0EzdEp5TDM5?= =?utf-8?B?clgxM3hld3lyRnJTa2RqenFPaDFUWENhUGthaEtKMnZ4MTMyWkMxSTN0SDVE?= =?utf-8?B?Mk5JUFRudk5rV1NyTzEzWXVRMFY5bkNialJkZzJYVW1IVVNuMEpCdGd4VUh0?= =?utf-8?B?ajN1OW5qY1hpYlQ4cXB5YWEvV1E2Mm5ZWjZQdXRDcGd3UVhPU1cwdzJjUCtG?= =?utf-8?B?ejJ4aDE3QkhjS1hqL3JpSi80VHFSMzFqeXFPQWhvamd6dkxjSVlQNlVmNzE1?= =?utf-8?B?R2FFOTJhM29CYThMd3BCTnFkV3NEeDRWLy9ZTW5peWU2ZnhQcHJuUWRscHFS?= =?utf-8?B?ZlJjZ3JESG5NdXdzNjYzTTJXaG90NDdTSFlqUmwrSGVJZHo3MzM5b3VZdWNG?= =?utf-8?B?ZGtGTDkzN0ZhVzJ3OFZLMnM4Q0UrUWozK2toeHRlSkVkb2luNm1zdEZHY3dj?= =?utf-8?B?elJ2aDNSd0V2d0JpN2E0YTVaMmlBOEp6N0o3SjJmM2liekZsYjZWYzFoQnAv?= =?utf-8?B?b3ZiRlY3aFp0RWJ2ODAyTFF6ZU9oczl3R0lGNWRoZUt3cDJKa2F5aFRVWDZV?= =?utf-8?B?VitQQ2psY2RmandETFBOQk9SOG8wdWVnUlh4YS9BaDV0cEFBSW4yV3FTTVVB?= =?utf-8?B?a1A1QzRJWXBXK1NvSC9sVWUxc3NRdy9ZVXVxUE5rM2UwKzlpZkhHTlNPbW51?= =?utf-8?B?RUJlZTRPUWhkZmtQYVJtTTVDNlYrUWR5KzRhMzF3bDN4ZHVGekJKdDYxMVdH?= =?utf-8?B?WlBRREZTa1hieWxqSjJrNG50L2Q5UXNZRzVCcTRkU2JpWnFOdHBvYndyeWpk?= =?utf-8?B?RjB4SDFCUUJ0YXhsTGQ4aWtGU0lBQk9NayttVHhOcWVENzM0bThuL1FpS3Rl?= =?utf-8?B?ajdrWjRuRWRjVUpIbnBHbVppU2lTbzlYeTBBZ2hVcFdkNzRXaTRtRWsycUFa?= =?utf-8?B?UHYyQmQ5OHQyczFRZTI3MytjcXpnc3JDSlJVano5QUJRdlNBa0xiS0lUQW4z?= =?utf-8?B?RVk3M1c2OFBKekpjYUhFNUZJcTZBcmlVWHhOWmxHUU5Xd3E5Tms0dnNvS0hP?= =?utf-8?B?cmp1czF1ekR2V2ExeFl2SDErZnV3Q2pWZng3dXpnellhTDk0clJ0SDRQbCtZ?= =?utf-8?B?VjRXanE3Vnd6WHNGUGIxeDVOVUpjdW1DUFo1Vy8vWG56bFFwbFFzNnM1a3pS?= =?utf-8?B?bnM0NnFlaS8vVEovUUsrTTcrUTZxU0tVTllhazNMaTR5ZXpKaUVkd2Roamp1?= =?utf-8?B?S0RCQjZwRU5BLzBaZk9XY0kvMEhUSHZJc3dUd0d2YjczTGM2N1MrSGJjQTdU?= =?utf-8?B?dUpFYkpCMjlRNC9XOEpVcmZid3hOTi9qMHhmYVZGQUsxQlAxYVdFWTdzQnEv?= =?utf-8?B?UVlyUVE4SFJBaGNvdUlMNWJkLzdEaDdlc1BGWnZTSE9qVlR0dDR1L2VNWEkz?= =?utf-8?B?Nm03U3NOcHhnYUtQTFgxY29xK1ZnMTBub2lLT1E1NUUvT1FSVUVWRy9rTW1q?= =?utf-8?B?MkU1UkQ0b2dTTDRBUjZGQlVEbTRyeHUxK0dvazUyWUZaVEpNZ3cxV3VReEhm?= =?utf-8?B?aDQ3TWgwbjlmRm9kSmlqMUhXcjA1VWQ2YzFxZDJpcGhqQlhhSnRZZXMyNlVT?= =?utf-8?B?YW83ZGNFWnFWVVpMTXRVVklDWUZyd2VhYmdrVVY4WXdGRk00ZXBzZWR2MUVz?= =?utf-8?B?bWxTM3dMbGpGZU1rbzFoc3JySkIyTGo0ZjJWMUZNZ29NUkxnSkNEdnZYRHFy?= =?utf-8?B?dWl0MmpVVzNvQVhjY2RxM05yZGxRRWUrUDEzbVJ2bmQ3cjJrcEFZcE96RlRi?= =?utf-8?B?NGhBVTh4RGtwb1hiMlhrK1FkSWJsSEJ2Yms3cWFOREloUFRERmJvYU16YlJq?= =?utf-8?B?RVRJWEVRTm5Fc3R1SnRxczlYZjFkeURVcllZcGRxenlUNEVWYUFRMloya0Iv?= =?utf-8?B?MEE1dStFQVl3bCtiUzBabzNxbFBOQmVqU3BiRkxIbFI4VTRvMi9hb0R1Ykhy?= =?utf-8?B?c0JGY0dXcE85d2F0K3lFcmNyL1pacWthaklEdlF0cHRxelVpVlZSaTJCQmZ6?= =?utf-8?B?cHBhVHYzWjlrOTV6Rit0ajlLeW9HVkpSZWxiMjkyQW9MTDJiSTFjRC9wT2U2?= =?utf-8?Q?m5Jfdnpt6eIpO49XoTIxCZ4qU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fae40c1-eed0-41cb-2901-08dac1ab38ac X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 17:03:56.1815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bYHZ7yxAkPBiNdtUxYoFp5cQklSZ4tyEZxI6l8T1s02INlDd/9OdLRI2wNmaMHZmsnQiFNdxnds3j5sbF/p2NA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9210 On 08.11.2022 17:43, Roger Pau Monné wrote: > On Tue, Nov 08, 2022 at 05:14:40PM +0100, Jan Beulich wrote: >> On 08.11.2022 12:38, Roger Pau Monne wrote: >>> Like on the Arm side, return -EINVAL when attempting to do a p2m >>> operation on dying domains. >>> >>> The current logic returns 0 and leaves the domctl parameter >>> uninitialized for any parameter fetching operations (like the >>> GET_ALLOCATION operation), which is not helpful from a toolstack point >>> of view, because there's no indication that the data hasn't been >>> fetched. >> >> While I can see how the present behavior is problematic when it comes >> to consuming supposedly returned data, ... >> >>> --- a/xen/arch/x86/mm/paging.c >>> +++ b/xen/arch/x86/mm/paging.c >>> @@ -694,9 +694,10 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, >>> >>> if ( unlikely(d->is_dying) ) >>> { >>> - gdprintk(XENLOG_INFO, "Ignoring paging op on dying domain %u\n", >>> + gdprintk(XENLOG_INFO, >>> + "Tried to do a paging domctl op on dying domain %u\n", >>> d->domain_id); >>> - return 0; >>> + return -EINVAL; >>> } >> >> ... going from "success" to "failure" here has a meaningful risk of >> regressing callers. It is my understanding that it was deliberate to >> mimic success in this case (without meaning to assign "good" or "bad" >> to that decision). > > I would assume that was the original intention, yes, albeit the commit > message doesn't go into details about why mimicking success is > required, it's very well possible the code relying on this was xend. Quite possible, but you never know who else has cloned code from there. >> Can you instead fill the data to be returned in >> some simple enough way? I assume a mere memset() isn't going to be >> good enough, though (albeit public/domctl.h doesn't explicitly name >> any input-only fields, so it may not be necessary to preserve >> anything). Maybe zeroing ->mb and ->stats would do? > > Hm, it still feels kind of wrong. We do return errors elsewhere for > operations attempted against dying domains, and that seems all fine, > not sure why paging operations need to be different in this regard. > Arm does also return -EINVAL in that case. > > So what about postponing this change to 4.18 in order to avoid > surprises, but then taking it in its current form at the start of the > development window, as to have time to detect any issues? Maybe, but to be honest I'm not convinced. Arm can't really be taken for comparison, since the op is pretty new there iirc. >> As a minor remark: _If_ you're changing the printk(), then please >> also switch to using %pd. > > I've considered this, but then printing: "Tried to do a paging domctl > op on dying domain dX" felt kind of repetitive to me because of the > usage of domain and dX in the same sentence. Anyway, will adjust. Simply drop the word "domain", as we've done elsewhere when switching to %pd? Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 08 17:13:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 17:13:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440345.694521 (Exim 4.92) (envelope-from ) id 1osSAP-0007Ha-4F; Tue, 08 Nov 2022 17:13:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440345.694521; Tue, 08 Nov 2022 17:13:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSAP-0007HT-1V; Tue, 08 Nov 2022 17:13:41 +0000 Received: by outflank-mailman (input) for mailman id 440345; Tue, 08 Nov 2022 17:13:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSAN-0007HN-3o for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 17:13:39 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70075.outbound.protection.outlook.com [40.107.7.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ae623ca9-5f88-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 18:13:36 +0100 (CET) Received: from DB6PR0501CA0041.eurprd05.prod.outlook.com (2603:10a6:4:67::27) by GV1PR08MB8617.eurprd08.prod.outlook.com (2603:10a6:150:81::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 17:13:33 +0000 Received: from DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:67:cafe::a6) by DB6PR0501CA0041.outlook.office365.com (2603:10a6:4:67::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Tue, 8 Nov 2022 17:13:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT014.mail.protection.outlook.com (100.127.143.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Tue, 8 Nov 2022 17:13:32 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Tue, 08 Nov 2022 17:13:32 +0000 Received: from b0d8b58b26ab.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BE5FDA99-02C9-474C-ABF4-26797C31D2C2.1; Tue, 08 Nov 2022 17:13:22 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b0d8b58b26ab.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Nov 2022 17:13:22 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by VI1PR08MB5471.eurprd08.prod.outlook.com (2603:10a6:803:137::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Tue, 8 Nov 2022 17:13:18 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893%4]) with mapi id 15.20.5813.011; Tue, 8 Nov 2022 17:13:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae623ca9-5f88-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lG1VBJAc0Zn/yJYZh+Br+TipofoikY6XKinnrv5t3C1ZUlnTGjm7f4GqlEejvUsQsdp7mVSkHgn7Uc58TCpNTQAmDZX/FzwwF+1z89tiSFa+DfTruypY7iub/LU4Us/fM0Oe1wPqd/NlS6fTsxj+nE0F30KxkJsCVmXatFjL/ebK9Ah7LfmqOlMIohpTCuZCNRsS6sXZes+VVbYM22UN5S3ZS/B4OA9q/AmW6g6LvAbQkaCGw3Rs/1zcXBrC+PYLxWWIKeR0gxL/qc2diA84Gu6a6ZNd40+urKAGzbsiqUDHitZhms8RGa31Mji0TD+QNRW5F+JumLxouVyCXViK3g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Syc7erBJ6qFi9Tki8fuctpu3DB3inDj/IYd1NNpFGKk=; b=ndw3tp5SS5ypVR+xGmevIn/3pxJwHEVE6JX/x3Hc9a11Qi7OePdBfBGWmT3nNiXtsPj0nKGNVUjfZh4/xD1bGlHZ8YX4fMx+SW9gkWV15EPMz1Av/e/jJqJlHOOzpVcXk/bT+boEV9a0sp8fmhz3Fv64S7cStNeYvvcSPPP0IcBDhUfbHDUBOnrxAz04EgKnYpPWFmsggEUv5OKW13Ezvb0Lv3Vy01CzrEJm25AtixI9CKbqPrW2fJEPvnCUGuAFgBp5Z8JIypMIy9v3tM51bwgDQCCa/gWMbcpx7U1Hmnl/Ar1IQ6mjnEvf378od3dXf56MgPxR/ZmtbZ/pwC0YzA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Syc7erBJ6qFi9Tki8fuctpu3DB3inDj/IYd1NNpFGKk=; b=DBpBCT/ywNzGGswdq+Iwn98sya6kwQR2wQVXfY9K4sV66BuW0u6rAWoK7x75j9fiyCar7N6gB1WiD9IrQWkB9o6Faw8jcaQIZ4hYFuVRhU56jmSeiyYTJo95CcjxMX6FT67KcP9e2LXFZ9vji8fk34As9r2kuTWuSc4HE9iEw+o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 1c8181f757736892 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mEy/+zeYJ9EtMuuNrL9kLgfXxlwkCDzZBLiN+bdYFcOQw/T79wMp93RxzooC5dy1M0l6ArDd+U3QosEI9ZUEfUYTZTZJ51PJraCr/1VfdVY7t41we2CSQKq02H3JPf3J0+JWxa2QiZoIUtunI3vMObiSaQ4U+eGgwC5aljb6NoJC9hud7S7jVPjYruDETvwjFGwBOedfBSxCHWuIYkMXruHPkzH8m/tfomN4FX3iL13TUMC6d6KXEbxrtwFjMS9k5huKe2mouGNG/8kjOhVG/ho/4fDZDQuPjcuxXkNmZW9LSoxR9+g7iH8mx01o/2C0MTPYnV/fsrKfRkttf9yaNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Syc7erBJ6qFi9Tki8fuctpu3DB3inDj/IYd1NNpFGKk=; b=jN1ehq3q9EPeCeqxsGIsCeoz/bKviBLLVU7hM+mWrebxIzpAkT4kb17o2ZpSkI4vJUlNtznkG2EVt9tolBCQ1hy+L++SlL34F3/axhWmBH9UaoreKw/YKHp4rHlS8XiBZIpshLFyY5nOYF6+wnCoyrx0JkeMW/MpTecdLPruGNbxVx+bq63ooGxPfMhIZAkVoMFxdWsDSgvykd6ANrdQGaRUBcUex/G9QV1GvTihYPWv4A3qwUEEshhF3IVWcohFD99sOJpYIGmZETb7bvrHLr345Gnot0jYfakI3u4TDkeIyIGDBmQ6TWBvkLTJj+jB84koJTQntPjlHTHDRgeUcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Syc7erBJ6qFi9Tki8fuctpu3DB3inDj/IYd1NNpFGKk=; b=DBpBCT/ywNzGGswdq+Iwn98sya6kwQR2wQVXfY9K4sV66BuW0u6rAWoK7x75j9fiyCar7N6gB1WiD9IrQWkB9o6Faw8jcaQIZ4hYFuVRhU56jmSeiyYTJo95CcjxMX6FT67KcP9e2LXFZ9vji8fk34As9r2kuTWuSc4HE9iEw+o= From: Luca Fancellu To: Jan Beulich CC: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Thread-Topic: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Thread-Index: AQHY8pZ008DS0BACDkyhs+OWN8Oan64zqLWAgAE0WoCAAA3SgIAAJOMAgAAeVoCAABeCgA== Date: Tue, 8 Nov 2022 17:13:18 +0000 Message-ID: <2E0BFEFC-5BEE-4F8B-BD9E-94CB9A5B2BC9@arm.com> References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> <7d56c33d-4b03-9aa1-6abc-45a8ad41caca@suse.com> In-Reply-To: <7d56c33d-4b03-9aa1-6abc-45a8ad41caca@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|VI1PR08MB5471:EE_|DBAEUR03FT014:EE_|GV1PR08MB8617:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ccec003-67b8-4c68-b87c-08dac1ac9083 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: egqJNEI/SuQyaGL8sHiIeTp4xk23hfPP39XbRlRoRYIoZmI21Ilt0hXYgNagUD77L5ZXESutVRmdSeM0hoOVB7YrmejN//mNCBhiV+Jfm8gQ7HGTwK1uVGvlMGpC3Ssc5hXmZQgU+wvEuSgGJ+fmeV2zMSwpyFoTgbnUXR2K9GEPKtKKgnSo0VJFCnZsOtN45kb3LatwBHBJ6QKpT0pPwqNQPJLGBiZWqHdYhuoagMr+EX0rN5KlpUTYd/jSbspm1Xi9dXtki1xzZ8TruxSj9xI8m0aM9XVraOT+jBeBU3inJA2ubDQZ07NoHy1oHElhOc/l7z5ojin5CpkmuRBQknLuC7HY7l44d3kA4eAA6SO+HQae9jUPMKVa+9u7VHrD3gxzpcPZS0dgteiNHXBMA2JfQQgMzCenurwGZGfsLDgV00z9W0aFUODIs/mqUYwbT+tD5JtTWMyjcRHQKHcfQQb89ry7ecWDHl8/t3PSHCxHsb361Eqcm2XMDmTefbsjm/eZToRhDWmF0otPh4yEKj7qCDjrZJ0X77TtLe0ryufg8kLhNlPQTHV1ucI8DhBpHA8/BkovnA9tCAw2YUJUWRMJzxd6oE9WBPrlj9n+o576Zi//CbvcrBf7Q9v65+KPbaKwKAJbFmq237AbVlrj5LvWSq1zYreYOQZAzdkCQAs8NSmwAAcuQMtF1XHRDGEKkhTAKZgZdmXd4KjSZaWfasg1M6rXhApeDHEmZSS3yMp7YTX/OBcGe2J3qUIVOklhbSL/VjwlgiJE2KiFrPffkhkB+iYaRtbQd7SpZgp8i7I= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(136003)(376002)(346002)(396003)(451199015)(33656002)(8676002)(2616005)(26005)(6512007)(54906003)(316002)(6916009)(36756003)(38070700005)(6486002)(2906002)(71200400001)(38100700002)(122000001)(8936002)(66556008)(64756008)(66476007)(41300700001)(186003)(66946007)(4326008)(66446008)(91956017)(30864003)(76116006)(86362001)(83380400001)(5660300002)(6506007)(53546011)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <00FC34095D10B54C9B21E8A89C897F41@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5471 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3db1dc8c-fe72-4fff-50b0-08dac1ac87bb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mF+spplsWTd0bztD8hmhicyIostaaC8LAoKySs3aoKOE9yRMl817kkARmJ6ssXzc1dqTtcQd/CMzymoOUv7npJ23T0Ogf7unUyjeLjp4UkvbwJnho7Q4TP8kjVvlLUimgjmsE4FFp4h0JICnJxYnBbQ1AdV7QTKv80iNKuI+lamoqbTRXQ85Jk0kgyM8hk/cJEvFt5/tM9XkIRXM23BVaJlVIptlGYBFPFPnwv38Fq/1v579HWs+8MR7hTj7XSVK/ZRG4lj1wckCgO9efxU6rrKK5Qv7sxrjmjzL8ZJ2Ge9hTeFLJxoE2gJePAQixI3eVktuPHbz6ni4jnbY1IvKIDvGWb1SVrA97ei9GJvvAnRvvIF4vtSp442QYDE5uD0I2CQozd6Q/rGF8x4TfZ5YpGQQoPqiyPLjhAr/S6QtsjfLktoMiq/Oz61HNKaewSBRgPUgfeKd21/kT/GZ75U6bCH50tOq82CQq9oyGwahAVthadxVTP0+RKCaXNCKSGFd36Gg2Q5J2rYXJIoWtmAUJPXJDX3exsRk/9f+dovwrD94X/iXu30gqOYaAYB6HIsw/mPsFfrRfqygBnmnbN2VmNpzTe7ETtkhY/IsVDywbjXyJRoE8Mo8g+dLyzPxgTtq32WzdCeb56JJxBdMlZn0P5kGgWx0/USZp5gERIKIHvRrC8MMPixAKOAppt+CjunTHZmP3JTAWuQ2iV6hylUBeTlw4ITv2lKE5qbqXGNUebw/sOGEpCD3abBTlVGY4Jv9SblqNMTIXpk93kcWzxx3vQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(376002)(136003)(451199015)(46966006)(36840700001)(40470700004)(30864003)(5660300002)(86362001)(8936002)(70206006)(36756003)(41300700001)(2906002)(6862004)(478600001)(82310400005)(316002)(4326008)(8676002)(53546011)(26005)(6512007)(70586007)(33656002)(6506007)(54906003)(6486002)(40480700001)(336012)(186003)(36860700001)(2616005)(83380400001)(356005)(81166007)(47076005)(82740400003)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 17:13:32.9433 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ccec003-67b8-4c68-b87c-08dac1ac9083 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8617 DQoNCj4gT24gOCBOb3YgMjAyMiwgYXQgMTU6NDksIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwOC4xMS4yMDIyIDE1OjAwLCBMdWNhIEZhbmNlbGx1IHdy b3RlOg0KPj4+IE9uIDggTm92IDIwMjIsIGF0IDExOjQ4LCBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+IHdyb3RlOg0KPj4+IE9uIDA4LjExLjIwMjIgMTE6NTksIEx1Y2EgRmFuY2VsbHUg d3JvdGU6DQo+Pj4+PiBPbiAwNy4xMS4yMDIyIDExOjQ3LCBMdWNhIEZhbmNlbGx1IHdyb3RlOg0K Pj4+Pj4+IEBAIC03NTcsNiArNzU4LDUxIEBAIGNwcGNoZWNrLXZlcnNpb246DQo+Pj4+Pj4gJChv Ymp0cmVlKS9pbmNsdWRlL2dlbmVyYXRlZC9jb21waWxlci1kZWYuaDoNCj4+Pj4+PiAJJChRKSQo Q0MpIC1kTSAtRSAtbyAkQCAtIDwgL2Rldi9udWxsDQo+Pj4+Pj4gDQo+Pj4+Pj4gK0pVU1RJRklD QVRJT05fRklMRVMgOj0gJChYRU5fUk9PVCkvZG9jcy9taXNyYS9zYWZlLmpzb24gXA0KPj4+Pj4+ ICsgICAgICAgICAgICAgICAgICAgICAgICQoWEVOX1JPT1QpL2RvY3MvbWlzcmEvZmFsc2UtcG9z aXRpdmUtJCQqLmpzb24NCj4+Pj4+PiArDQo+Pj4+Pj4gKyMgVGhlIGZvbGxvd2luZyBjb21tYW5k IGlzIHVzaW5nIGdyZXAgdG8gZmluZCBhbGwgZmlsZXMgdGhhdCBjb250YWlucyBhIGNvbW1lbnQN Cj4+Pj4+PiArIyBjb250YWluaW5nICJTQUYtPGFueXRoaW5nPiIgb24gYSBzaW5nbGUgbGluZS4N Cj4+Pj4+PiArIyAlLnNhZnBhcnNlIHdpbGwgYmUgdGhlIG9yaWdpbmFsIGZpbGVzIHNhdmVkIGZy b20gdGhlIGJ1aWxkIHN5c3RlbSwgdGhlc2UgZmlsZXMNCj4+Pj4+PiArIyB3aWxsIGJlIHJlc3Rv cmVkIGF0IHRoZSBlbmQgb2YgdGhlIGFuYWx5c2lzIHN0ZXANCj4+Pj4+PiArUEFSU0VfRklMRV9M SVNUIDo9ICQoYWRkc3VmZml4IC5zYWZwYXJzZSwkKGZpbHRlci1vdXQgJS5zYWZwYXJzZSxcDQo+ Pj4+Pj4gKyQoc2hlbGwgZ3JlcCAtRVJsICdeW1s6Ymxhbms6XV0qXC9cKltbOnNwYWNlOl1dK1NB Ri0uKlwqXC8kJCcgJChzcmN0cmVlKSkpKQ0KPj4+Pj4gDQo+Pj4+PiBQbGVhc2UgaW5kZW50IHN1 Y2ggbGluZSBjb250aW51YXRpb25zLiBBbmQgdGhlbiBpc24ndCB0aGlzIGdvaW5nIHRvIHJpc2sN Cj4+Pj4+IG1hdGNoaW5nIG5vbi1zb3VyY2UgZmlsZXMgYXMgd2VsbD8gUGVyaGFwcyB5b3Ugd2Fu dCB0byByZXN0cmljdCB0aGlzIHRvDQo+Pj4+PiAqLmMgYW5kICouaD8NCj4+Pj4gDQo+Pj4+IFll cywgaG93IGFib3V0IHRoaXMsIGl0IHdpbGwgZmlsdGVyIG91dCAqLnNhZnBhcnNlIGZpbGVzIHdo aWxlIGtlZXBpbmcgaW4gb25seSAuaCBhbmQgLmM6DQo+Pj4+IA0KPj4+PiBQQVJTRV9GSUxFX0xJ U1QgOj0gJChhZGRzdWZmaXggLnNhZnBhcnNlLCQoZmlsdGVyICUuYyAlLmgsXA0KPj4+PiAgICQo c2hlbGwgZ3JlcCAtRVJsICdeW1s6Ymxhbms6XV0qXC9cKltbOnNwYWNlOl1dK1NBRi0uKlwqXC8k JCcgJChzcmN0cmVlKSkpKQ0KPj4+IA0KPj4+IFRoYXQncyBiZXR0ZXIsIGJ1dCBzdGlsbCBtZWFu cyB0b3VjaGluZyBhbGwgZmlsZXMgYnkgZ3JlcCBkZXNwaXRlIG5vdw0KPj4+IG9ubHkgYSBzdWJz ZXQgcmVhbGx5IGxvb2tlZCBmb3IuIElmIEkgd2FzIHRvIHVzZSB0aGUgbmV3IGdvYWxzIG9uIGEN Cj4+PiBtb3JlIG9yIGxlc3MgcmVndWxhciBiYXNpcywgSSdkIGV4cGVjdCB0aGF0IHRoaXMgZW51 bWVyYXRpb24gb2YgZmlsZXMNCj4+PiBkb2Vzbid0IHJlYWQgX211Y2hfIG1vcmUgc3R1ZmYgZnJv bSBkaXNrIHRoYW4gaXMgYWN0dWFsbHkgbmVjZXNzYXJ5Lg0KPj4gDQo+PiBPayB3b3VsZCBpdCBi ZSBvaz8NCj4+IA0KPj4gUEFSU0VfRklMRV9MSVNUIDo9ICQoYWRkc3VmZml4IC5zYWZwYXJzZSwk KHNoZWxsIGdyZXAgLUVSbCAtLWluY2x1ZGU9XCouaCBcDQo+PiAgICAtLWluY2x1ZGU9XCouYyAn XltbOmJsYW5rOl1dKlwvXCpbWzpzcGFjZTpdXStTQUYtLipcKlwvJCQnICQoc3JjdHJlZSkpKQ0K PiANCj4gSG1tLCBub3Qgc3VyZTogLS1pbmNsdWRlIGlzbid0IGEgc3RhbmRhcmQgb3B0aW9uIHRv IGdyZXAsIGFuZCB3ZQ0KPiBnZW5lcmFsbHkgdHJ5IHRvIGJlIHBvcnRhYmxlLiBBY3R1YWxseSAt UiAob3IgLXIpIGlzbid0IGVpdGhlci4gSXQNCj4gbWF5IHN0aWxsIGJlIG9rYXkgdGhhdCB3YXkg aWYgcHJvcGVybHkgZG9jdW1lbnRlZCB3aGVyZSB0aGUgaW52b2x2ZWQNCj4gZ29hbHMgd2lsbCB3 b3JrIGFuZCB3aGVyZSBub3QuDQoNCklzIGEgY29tbWVudCBiZWZvcmUgdGhlIGxpbmUgb2sgYXMg ZG9jdW1lbnRhdGlvbj8gVG8gc3RhdGUgdGhhdCDigJRpbmNsdWRlIGFuZA0KLVIgYXJlIG5vdCBz dGFuZGFyZCBvcHRpb25zIHNvIGFuYWx5c2lzLXtjb3Zlcml0eSxlY2xhaXJ9IHdpbGwgbm90IHdv cmsgd2l0aG91dCBhDQpncmVwIHRoYXQgdGFrZXMgdGhvc2UgcGFyYW1ldGVycz8NCg0KPiANCj4g QW5kIHRoZW4gLSB3aHkgZG8geW91IGVzY2FwZSBzbGFzaGVzIGluIHRoZSBFUkU/DQo+IA0KPiBU YWxraW5nIG9mIGVzY2FwaW5nIC0gcGVyc29uYWxseSBJIGZpbmQgYmFja3NsYXNoIGVzY2FwZXMg aGFyZGVyIHRvDQo+IHJlYWQgLyBncm9rIHRoYW4gcXVvdGF0aW9uLCBzbyBJJ2QgbGlrZSB0byBy ZWNvbW1lbmQgdXNpbmcgcXVvdGVzDQo+IGFyb3VuZCBlYWNoIG9mIHRoZSB0d28gLS1pbmNsdWRl IChpZiB0aGV5IHJlbWFpbiBpbiB0aGUgZmlyc3QgcGxhY2UpDQo+IGluc3RlYWQgb2YgdGhlIFwq IGNvbnN0cnVjdC4NCg0KT2sgSeKAmXZlIHJlbW92ZWQgdGhlIGVzY2FwZSBmcm9tIHRoZSAqIGFu ZCBhbHNvIGZyb20gc2xhc2hlczoNCg0KUEFSU0VfRklMRV9MSVNUIDo9ICQoYWRkc3VmZml4IC5z YWZwYXJzZSwkKHNoZWxsIGdyZXAgLUVSbCAtLWluY2x1ZGU9JyouaCcgXA0KICAgIC0taW5jbHVk ZT0nKi5jJyAnXltbOmJsYW5rOl1dKi9cKltbOnNwYWNlOl1dK1NBRi0uKlwqLyQkJyAkKHNyY3Ry ZWUpKSkNCg0KPiANCj4+Pj4+PiArCWRvbmUNCj4+Pj4+PiArDQo+Pj4+Pj4gK2FuYWx5c2lzLWJ1 aWxkLSU6IGFuYWx5c2lzLXBhcnNlLXRhZ3MtJQ0KPj4+Pj4+ICsJJChNQUtFKSBPPSQoYWJzX29i anRyZWUpIC1mICQoc3JjdHJlZSkvTWFrZWZpbGUgYnVpbGQNCj4+Pj4+IA0KPj4+Pj4gVGhpcyBy dWxlIGRvZXNuJ3QgdXNlIHRoZSBzdGVtLCBzbyBJJ20gc3RydWdnbGluZyB0byB1bmRlcnN0YW5k IHdoYXQNCj4+Pj4+IHRoaXMgaXMgYWJvdXQuDQo+Pj4+IA0KPj4+PiBZZXMsIGhlcmUgbXkgYWlt IHdhcyB0byBjYXRjaCBhbmFseXNpcy1idWlsZC17ZWNsYWlyLGNvdmVyaXR5fSwgaGVyZSBJIHNl ZSB0aGF0IGlmIHRoZSB1c2VyIGhhcyBhIHR5cG8NCj4+Pj4gdGhlIHJ1bGUgd2lsbCBydW4gYW55 d2F5LCBidXQgaXQgd2lsbCBiZSBzdG9wcGVkIGJ5IHRoZSBkZXBlbmRlbmN5IGNoYWluIGJlY2F1 c2UgYXQgdGhlIGVuZCB3ZSBoYXZlOg0KPj4+PiANCj4+Pj4gSlVTVElGSUNBVElPTl9GSUxFUyA6 PSAkKFhFTl9ST09UKS9kb2NzL21pc3JhL3NhZmUuanNvbiBcDQo+Pj4+ICAgICAgICAgICAgICAg ICAgICAgICQoWEVOX1JPT1QpL2RvY3MvbWlzcmEvZmFsc2UtcG9zaXRpdmUtJCQqLmpzb24NCj4+ Pj4gDQo+Pj4+IFRoYXQgd2lsbCBnaXZlIGFuIGVycm9yIGJlY2F1c2UgJChYRU5fUk9PVCkvZG9j cy9taXNyYS9mYWxzZS1wb3NpdGl2ZS08dHlwbz4uanNvbiBkb2VzIG5vdCBleGlzdHMuDQo+Pj4+ IA0KPj4+PiBJZiB5b3UgdGhpbmsgaXQgaXMgbm90IGVub3VnaCwgd2hhdCBpZiBJIHJlZHVjZSB0 aGUgc2NvcGUgb2YgdGhlIHJ1bGUgbGlrZSB0aGlzPw0KPj4+PiANCj4+Pj4gX2FuYWx5c2lzLWNv dmVyaXR5IF9hbmFseXNpcy1lY2xhaXI6IF9hbmFseXNpcy0lOiBhbmFseXNpcy1idWlsZC0lDQo+ Pj4gDQo+Pj4gQnV0IHRoZW4sIHdpdGhvdXQgdXNpbmcgdGhlIHN0ZW0sIGhvdyBkb2VzIGl0IGtu b3cgd2hldGhlciB0byBkbyBhbg0KPj4+IEVjbGFpciBvciBhIENvdmVyaXR5IHJ1bj8NCj4+IA0K Pj4gU29ycnkgSSB0aGluayBJ4oCZbSBhIGJpdCBsb3N0IGhlcmUsIHRoZSBtYWtlZmlsZSBpcyB3 b3JraW5nIG9uIGJvdGggYW5hbHlzaXMtY292ZXJpdHkgYW5kIGFuYWx5c2lzLWVjbGFpcg0KPj4g YmVjYXVzZSB0aGUgJSBpcyBzb2x2aW5nIGluIGNvdmVyaXR5IG9yIGVjbGFpciBkZXBlbmRpbmcg b24gd2hpY2ggdGhlIG1ha2VmaWxlIGhhcyBpbiBpbnB1dCwgaXQgaXMgbm90IGNvbXBsYWluaW5n DQo+PiBzbyBJIGd1ZXNzIGl0IHdvcmtzLg0KPj4gRG8geW91IHNlZSBzb21ldGhpbmcgbm90IHdv cmtpbmc/IElmIHNvLCBhcmUgeW91IGFibGUgdG8gcHJvdmlkZSBhIHBpZWNlIG9mIGNvZGUgZm9y IHRoYXQgdG8gbWFrZSBtZSB1bmRlcnN0YW5kPw0KPiANCj4gV2VsbCwgbXkgcHJvYmxlbSBpcyB0 aGF0IEkgZG9uJ3Qgc2VlIGhvdyB0aGUgZGlzdGluY3Rpb24gaXMgY29udmV5ZWQNCj4gd2l0aG91 dCB0aGUgc3RlbSBiZWluZyB1c2VkLiBXaXRoIHdoYXQgeW91IHNheSBJIHVuZGVyc3RhbmQgSSdt DQo+IG92ZXJsb29raW5nIHNvbWV0aGluZywgc28gSSdkIGFwcHJlY2lhdGUgc29tZSBleHBsYW5h dGlvbiBvciBhdCBsZWFzdA0KPiBhIHBvaW50ZXIuDQoNCk9rLCBJIGhhdmUgdGhhdCBlY2xhaXIg YW5kIGNvdmVyaXR5IHNoYXJlcyB0aGUgc2FtZSBjb21tYW5kcyB0byBiZSBleGVjdXRlZCBieSB0 aGUgYnVpbGQgc3lzdGVtLA0Kc28gaW5zdGVhZCBvZiBkdXBsaWNhdGluZyB0aGUgdGFyZ2V0cyBm b3IgY292ZXJpdHkgYW5kIGVjbGFpciBhbmQgdGhlaXIgcmVjaXBlLCBJ4oCZdmUgdXNlZCB0aGUg cGF0dGVybiBydWxlDQp0byBoYXZlIHRoYXQgdGhlc2UgcnVsZXM6DQoNCkpVU1RJRklDQVRJT05f RklMRVMgOj0gJChYRU5fUk9PVCkvZG9jcy9taXNyYS9zYWZlLmpzb24gXA0KICAgICAgICAgICAg ICAgICAgICAgICAkKFhFTl9ST09UKS9kb2NzL21pc3JhL2ZhbHNlLXBvc2l0aXZlLSQkKi5qc29u DQoNClvigKZdDQoNCi5TRUNPTkRFWFBBTlNJT046DQokKG9ianRyZWUpLyUuc2VkOiAkKHNyY3Ry ZWUpL3Rvb2xzL3hlbmZ1c2EtZ2VuLXRhZ3MucHkgJChKVVNUSUZJQ0FUSU9OX0ZJTEVTKQ0KICAg IFvigKZdDQoNClvigKZdDQoNCmFuYWx5c2lzLXBhcnNlLXRhZ3MtJTogJChQQVJTRV9GSUxFX0xJ U1QpICQob2JqdHJlZSkvJS5zZWQNCiAgICBb4oCmXQ0KDQphbmFseXNpcy1idWlsZC0lOiBhbmFs eXNpcy1wYXJzZS10YWdzLSUNCiAgICAkKE1BS0UpIE89JChhYnNfb2JqdHJlZSkgLWYgJChzcmN0 cmVlKS9NYWtlZmlsZSBidWlsZA0KDQphbmFseXNpcy1jbGVhbjoNCiAgIFvigKZdDQoNCl9hbmFs eXNpcy0lOiBhbmFseXNpcy1idWlsZC0lDQogICAgJChRKSQoTUFLRSkgTz0kKGFic19vYmp0cmVl KSAtZiAkKHNyY3RyZWUpL01ha2VmaWxlIGFuYWx5c2lzLWNsZWFuDQoNCk1hdGNoZXMgdGhlIGNh c2Ugd2hlcmUgJ21ha2UgYW5hbHlzaXMtY292ZXJpdHnigJkgb3Ig4oCYbWFrZSBhbmFseXNpcy1l Y2xhaXLigJkgaXMgY2FsbGVkLg0KDQpOb3csIHBsZWFzZSBjb3JyZWN0IG1lIGlmIG15IGFzc3Vt cHRpb24gb24gdGhlIHdheSBtYWtlIHdvcmtzIGFyZSB3cm9uZywgaGVyZSBteSBhc3N1bXB0aW9u czoNCg0KRm9yIGV4YW1wbGUgd2hlbiDigJhtYWtlIGFuYWx5c2lzLWNvdmVyaXR54oCZIGlzIGNh bGxlZCB3ZSBoYXZlIHRoYXQgdGhpcyBydWxlIGlzIHRoZSBiZXN0IG1hdGNoIGZvciB0aGUNCmNh bGxlZCB0YXJnZXQ6DQoNCl9hbmFseXNpcy0lOg0KDQpTbyBhbnl0aGluZyBhZnRlciBfYW5hbHlz aXMtIHdpbGwgYmUgY2FwdHVyZWQgd2l0aCAlIGFuZCB0aGlzIHdpbGwgYmUgdHJhbnNmZXJyZWQg dG8gdGhlIGRlcGVuZGVuY3kNCm9mIHRoZSB0YXJnZXQgdGhhdCBpcyBhbmFseXNpcy1idWlsZC0l IC0+IGFuYWx5c2lzLWJ1aWxkLWNvdmVyaXR5DQoNCk5vdyBhbmFseXNpcy1idWlsZC1jb3Zlcml0 eSB3aWxsIGJlIGNhbGxlZCwgdGhlIGJlc3QgbWF0Y2ggaXMgYW5hbHlzaXMtYnVpbGQtJSwgc28g YWdhaW4gdGhlIGRlcGVuZGVuY3kNCndoaWNoIGlzIGFuYWx5c2lzLXBhcnNlLXRhZ3MtJSwgd2ls bCBiZSB0cmFuc2xhdGVkIHRvIGFuYWx5c2lzLXBhcnNlLXRhZ3MtY292ZXJpdHkuDQoNCk5vdyBh bmFseXNpcy1wYXJzZS10YWdzLWNvdmVyaXR5IHdpbGwgYmUgY2FsbGVkLCB0aGUgYmVzdCBtYXRj aCBpcyBhbmFseXNpcy1wYXJzZS10YWdzLSUsIHNvIHRoZSAlIHdpbGwNCkhhdmUgdGhlIOKAmGNv dmVyaXR54oCZIHZhbHVlIGFuZCBpbiB0aGUgZGVwZW5kZW5jeSB3ZSB3aWxsIGhhdmUgJChvYmp0 cmVlKS8lLnNlZCAtPiAkKG9ianRyZWUpL2NvdmVyaXR5LnNlZC4NCg0KTG9va2luZyBmb3IgJChv Ymp0cmVlKS9jb3Zlcml0eS5zZWQgdGhlIGJlc3QgbWF0Y2ggaXMgJChvYmp0cmVlKS8lLnNlZCwg d2hpY2ggd2lsbCBoYXZlICQoSlVTVElGSUNBVElPTl9GSUxFUykNCmFuZCB0aGUgcHl0aG9uIHNj cmlwdCBpbiB0aGUgZGVwZW5kZW5jeSwgaGVyZSB3ZSB3aWxsIHVzZSB0aGUgc2Vjb25kIGV4cGFu c2lvbiB0byBzb2x2ZQ0KJChYRU5fUk9PVCkvZG9jcy9taXNyYS9mYWxzZS1wb3NpdGl2ZS0kJCou anNvbiBpbiAkKFhFTl9ST09UKS9kb2NzL21pc3JhL2ZhbHNlLXBvc2l0aXZlLWNvdmVyaXR5Lmpz b24NCg0KU28gbm93IGFmdGVyIGFuYWx5c2lzLXBhcnNlLXRhZ3MtY292ZXJpdHkgaGFzIGVuZGVk IGl0cyBkZXBlbmRlbmN5IGl0IHdpbGwgc3RhcnQgd2l0aCBpdHMgcmVjaXBlLCBhZnRlciBpdCBm aW5pc2hlcywNCnRoZSByZWNpcGUgb2YgYW5hbHlzaXMtYnVpbGQtY292ZXJpdHkgd2lsbCBzdGFy dCBhbmQgaXQgd2lsbCBjYWxsIG1ha2UgdG8gYWN0dWFsbHkgYnVpbGQgWGVuLg0KDQpBZnRlciB0 aGUgYnVpbGQgZmluaXNoZXMsIGlmIHRoZSBzdGF0dXMgaXMgZ29vZCwgdGhlIGFuYWx5c2lzLWJ1 aWxkLWNvdmVyaXR5IGhhcyBmaW5pc2hlZCBhbmQgdGhlIF9hbmFseXNpcy1jb3Zlcml0eQ0KcmVj aXBlIGNhbiBub3cgcnVuLCBpdCB3aWxsIGNhbGwgbWFrZSB3aXRoIHRoZSBhbmFseXNpcy1jbGVh biB0YXJnZXQsIHJlc3RvcmluZyBhbnkgPGZpbGU+LntjLGh9LnNhZnBhcnNlIHRvIDxmaWxlPi57 YyxofS4NCg0KV2Ugd2lsbCBoYXZlIHRoZSBzYW1lIHdpdGgg4oCYbWFrZSBhbmFseXNpcy1lY2xh aXLigJksIGlmIHdlIGRvIGEgbWlzdGFrZSB0eXBpbmcsIGxpa2Ug4oCYbWFrZSBhbmFseXNpcy1j b3ZlcmnigJksIHdlIHdpbGwNCmhhdmU6DQoNCm1ha2U6IEVudGVyaW5nIGRpcmVjdG9yeSDigJgv cGF0aC90by94ZW4veGVuJw0KbWFrZTogKioqIE5vIHJ1bGUgdG8gbWFrZSB0YXJnZXQgJ2FuYWx5 c2lzLWNvdmVyaScuICBTdG9wLg0KbWFrZTogTGVhdmluZyBkaXJlY3RvcnkgJy9wYXRoL3RvL3hl bi94ZW4nDQoNCg0KDQo+IA0KPj4+PiBPciwgaWYgeW91IGFyZSBzdGlsbCB3b3JyaWVkIGFib3V0 IOKAnGFuYWx5c2lzLWJ1aWxkLSU6IGFuYWx5c2lzLXBhcnNlLXRhZ3MtJeKAnSwgdGhlbiBJIGNh biBkbyBzb21ldGhpbmcNCj4+Pj4gbGlrZSB0aGlzOiANCj4+Pj4gDQo+Pj4+IGFuYWx5c2lzLXN1 cHBvcnRlZC1jb3Zlcml0eSBhbmFseXNpcy1zdXBwb3J0ZWQtZWNsYWlyOg0KPj4+PiAgIEBlY2hv ID4gL2Rldi9udWxsDQo+Pj4+IA0KPj4+PiBhbmFseXNpcy1zdXBwb3J0ZWQtJToNCj4+Pj4gICBA ZXJyb3IgVW5zdXBwb3J0ZWQgYW5hbHlzaXMgdG9vbCBAKg0KPj4+PiANCj4+Pj4gYW5hbHlzaXMt YnVpbGQtJTogYW5hbHlzaXMtcGFyc2UtdGFncy0lIHwgYW5hbHlzaXMtc3VwcG9ydGVkLSUNCj4+ Pj4gICAkKE1BS0UpIE89JChhYnNfb2JqdHJlZSkgLWYgJChzcmN0cmVlKS9NYWtlZmlsZSBidWls ZA0KPj4+IA0KPj4+IElmIEknbSBub3QgbWlzdGFrZW4gc3VwcG9ydCBmb3IgfCBkb2Vzbid0IGV4 aXN0IGluIG1ha2UgMy44MCAodGhlDQo+Pj4gbWluaW11bSB2ZXJzaW9uIHdlIHJlcXVpcmUgdG8g YmUgdXNlZCkuDQo+PiANCj4+IElESywgd2UgdXNlIG9yZGVyLW9ubHkgcHJlcmVxdWlzaXRlIGFs cmVhZHkgaW4gdGhlIE1ha2VmaWxlLg0KPiANCj4gSG1tLCB5ZXMsIGZvciAkKG9ianRyZWUpLyUu Yy5jcHBjaGVjazogLiBRdWVzdGlvbiBpcyB3aGV0aGVyIHRoaXMgd2FzDQo+IHNpbXBseSBvdmVy bG9va2VkIGJlZm9yZS4gQXMgc2FpZCBhYm92ZSBzdWNoIG1heSBiZSBva2F5IGZvciB0aGVzZQ0K PiBzcGVjaWFsIGdvYWxzLCBidXQgdGhpcyBuZWVkcyBwcm9wZXJseSBkb2N1bWVudGluZyB0aGVu Lg0KPiANCj4+Pj4+PiArYW5hbHlzaXMtY2xlYW46DQo+Pj4+Pj4gKyMgUmV2ZXJ0cyB0aGUgb3Jp Z2luYWwgZmlsZSAoLXAgcHJlc2VydmVzIGFsc28gdGltZXN0YW1wKQ0KPj4+Pj4+ICsJJChRKWZp bmQgJChzcmN0cmVlKSAtdHlwZSBmIC1uYW1lICIqLnNhZnBhcnNlIiAtcHJpbnQgfCBcDQo+Pj4+ Pj4gKwl3aGlsZSBJRlM9IHJlYWQgZmlsZTsgZG8gXA0KPj4+Pj4+ICsJCWNwIC1wICIkJHtmaWxl fSIgIiQke2ZpbGUlLnNhZnBhcnNlfSI7IFwNCj4+Pj4+PiArCQlybSAtZiAiJCR7ZmlsZX0iOyBc DQo+Pj4+PiANCj4+Pj4+IFdoeSBub3QgIm12Ij8NCj4+Pj4+IA0KPj4+Pj4+ICsJZG9uZQ0KPj4+ Pj4+ICsNCj4+Pj4+PiArX2FuYWx5c2lzLSU6IGFuYWx5c2lzLWJ1aWxkLSUNCj4+Pj4+PiArCSQo USkkKE1BS0UpIE89JChhYnNfb2JqdHJlZSkgLWYgJChzcmN0cmVlKS9NYWtlZmlsZSBhbmFseXNp cy1jbGVhbg0KPj4+Pj4gDQo+Pj4+PiBBZ2FpbiBubyB1c2Ugb2YgdGhlIHN0ZW0sIHBsdXMgaGVy ZSBJIHdvbmRlciBpZiB0aGlzIG1heSBub3QgbGVhZCB0bw0KPj4+Pj4gcGVvcGxlIGludm9raW5n ICJhbmFseXNpcy1jbGVhbiIgd2l0aG91dCBoYXZpbmcgc2FpZCBhbnl0aGluZyBhYm91dA0KPj4+ Pj4gY2xlYW5pbmcgb24gdGhlaXIgY29tbWFuZCBsaW5lLg0KPj4+PiANCj4+Pj4gSW4gYW55IGNh c2UsIHRoZSBjbGVhbmluZyBwcm9jZXNzIGlzIHZlcnkgc2FmZSBhbmQgZG9lcyBub3QgY2xlYW4g YW55dGhpbmcgdGhhdCB3YXMgbm90IGRpcnR5IGJlZm9yZSwNCj4+Pj4gc28gaW4gY2FzZSBvZiB0 eXBvcywgaXTigJlzIGp1c3QgbGlrZSBhIG5vcC4NCj4+PiANCj4+PiBQZW9wbGUgbWF5IHB1dCB0 cmFuc2llbnQgZmlsZXMgaW4gdGhlaXIgdHJlZXMuIE9mIGNvdXJzZSB0aGV5IG5lZWQgdG8gYmUN Cj4+PiBhd2FyZSB0aGF0IHdoZW4gdGhleSBzcGVjaWZ5IGEgImNsZWFuIiB0YXJnZXQgdGhlaXIg ZmlsZXMgbWF5IGJlIGRlbGV0ZWQuDQo+Pj4gQnV0IHdpdGhvdXQgYW55ICJjbGVhbiIgdGFyZ2V0 IHNwZWNpZmllZCBub3RoaW5nIHNob3VsZCBiZSByZW1vdmVkLg0KPj4gDQo+PiAqLnNhZnBhcnNl IGZpbGVzIGFyZSBub3Qgc3VwcG9zZWQgdG8gYmUgdXNlZCBmcmVlbHkgYnkgdXNlciBpbiB0aGVp ciB0cmVlLCB0aG9zZQ0KPj4gZmlsZXMgd2lsbCBiZSByZW1vdmVkIG9ubHkgaWYgdGhlIHVzZXIg Y2FsbHMgdGhlIOKAnGFuYWx5c2lzLWNsZWFu4oCdIHRhcmdldCBvciBpZiB0aGUNCj4+IGFuYWx5 c2lzLWNvdmVyaXR5IG9yIGFuYWx5c2lzLWVjbGFpciByZWFjaGVzIHRoZSBlbmQgKGEgcHJvY2Vz cyB0aGF0IGNyZWF0ZXMgKi5zYWZwYXJzZSkuDQo+PiANCj4+IFRoZXJlIGlzIG5vIG90aGVyIHdh eSB0byB0cmlnZ2VyIHRoZSDigJxhbmFseXNpcy1jbGVhbuKAnSB1bmludGVudGlvbmFsbHksIHNv IEnigJltIG5vdCBzdXJlIGFib3V0DQo+PiB0aGUgbW9kaWZpY2F0aW9uIHlvdSB3b3VsZCBsaWtl IHRvIHNlZSB0aGVyZS4NCj4gDQo+IEkgZ3Vlc3MgSSBkb24ndCB1bmRlcnN0YW5kOiBZb3UgaGF2 ZSBfYW5hbHlzaXMtJSBhcyB0aGUgdGFyZ2V0LCB3aGljaCBJJ2QNCj4gYXNzdW1lIHdpbGwgaGFu ZGxlIF9hbmFseXNpcy1jbGVhbiBqdXN0IGFzIG11Y2ggYXMgX2FuYWx5c2lzLWFiYy4gVGhpcyBt YXkNCj4gYmUgY29ubmVjdGVkIHRvIG15IGxhY2sgb2YgdW5kZXJzdGFuZGluZyBhcyBleHByZXNz ZWQgZnVydGhlciB1cC4gT3IgbWF5YmUNCj4gSSdtIHNpbXBseSBub3QgdW5kZXJzdGFuZGluZyB3 aGF0IHRoZSBfYW5hbHlzaXMtJSB0YXJnZXQgaXMgYWJvdXQgaW4gdGhlDQo+IGZpcnN0IHBsYWNl LCBiZWNhdXNlIHdpdGggdGhlIGFuYWx5c2lzLWJ1aWxkLSUgZGVwZW5kZW5jeSBJIGRvbid0IHNl ZSBob3cNCj4gX2FuYWx5c2lzLWNsZWFuIHdvdWxkIGFjdHVhbGx5IHdvcmsgKHdpdGggdGhlIHNj b3BlIHJlc3RyaWN0aW9uIHlvdQ0KPiBzdWdnZXN0ZWQgZWFybGllciBhIHJ1bGUgZm9yIGFuYWx5 c2lzLWJ1aWxkLWNsZWFuIHdvdWxkIG5vdCBiZSBmb3VuZA0KPiBhZmFpY3QpLg0KDQpfYW5hbHlz aXMtY2xlYW4gd2lsbCBub3Qgd29yaywgbmVpdGhlciBfYW5hbHlzaXMtYWJjLCBiZWNhdXNlIG9m IHdoYXQgSSB3cm90ZSBhYm92ZS4NCmFuYWx5c2lzLWNsZWFuIGluc3RlYWQgaXMgY2FsbGVkIGZy b20gdGhlIHJlY2lwZSBvZiBfYW5hbHlzaXMtJSBpZiBhbGwgaXRzIGRlcGVuZGVuY3kgYXJlDQpi dWlsdCBjb3JyZWN0bHksIG90aGVyd2lzZSBpdOKAmXMgdGhlIHVzZXIgdGhhdCBuZWVkcyB0byBj YWxsIGl0IGRpcmVjdGx5IGJ5IGRvaW5nIOKAnG1ha2UgYW5hbHlzaXMtY2xlYW7igJ0uDQoNCg0K DQo+IA0KPiBKYW4NCg0K From xen-devel-bounces@lists.xenproject.org Tue Nov 08 17:15:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 17:15:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440351.694532 (Exim 4.92) (envelope-from ) id 1osSCT-0008Bn-L5; Tue, 08 Nov 2022 17:15:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440351.694532; Tue, 08 Nov 2022 17:15:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSCT-0008Bg-IM; Tue, 08 Nov 2022 17:15:49 +0000 Received: by outflank-mailman (input) for mailman id 440351; Tue, 08 Nov 2022 17:15:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSCR-0008Ba-Gb for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 17:15:47 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa91e17a-5f88-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 18:15:45 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Nov 2022 12:15:42 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by CH0PR03MB6051.namprd03.prod.outlook.com (2603:10b6:610:be::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Tue, 8 Nov 2022 17:15:40 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.025; Tue, 8 Nov 2022 17:15:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa91e17a-5f88-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667927745; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=h//GSKAi45ckFybYQCp2StpEkuIRauJw1nlDC+qmLuw=; b=DzVzC+hvu09/C+WIl0/LxN1NhLcKTsZR9UG9VWT6bLrxnm4fpXjIf+Th jIhynv/EGRy25NUPP309TthXVbyffAR8ZCY58ZV0VVXaXuH/EdtcmYDce 2GcYYiKKJlRE8jEnqE7RJmiytQ+dcwKiKj1RMi+HnOhk7MunW8owqlAMT c=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 84409542 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:JJBLkK9Gm4fr+PYBM3wiDrUDs3+TJUtcMsCJ2f8bNWPcYEJGY0x3z TAbUT3SO6qOMDTwe9p3a9ni9k4GsZ7cyYdmGlA5/Ck8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKgb5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkVx 6QTFSBONiq8vO6wxuu1ZftwhukaeZyD0IM34hmMzBn/JNN/GNXpZfWP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUvgdABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prr+TwXuqBd5IfFG+3tI2n33IzTIfMQQXUFzqoMKmpX67UOsKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwCGAzLDFpTmQAGcsRyRELtchsaceWjgCx lKP2dTzClRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85i8jVf5mGa+xy9fzSTf5x mnTqDBk3utCy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg= IronPort-HdrOrdr: A9a23:dMEqgKp19zvNEFerlKGzFAUaV5rReYIsimQD101hICG9Evb0qy lhppQmPH7P+VIssRQb8+xoV5PufZqxz/BICOoqTNKftWvdyQiVxehZhOOP/9SJIUbDH4VmpM VdmsZFaeEZDTJB/LvHCAvTKadd/DFQmprY+ts3zB1WPH9Xg7kL1XYfNu4CeHcGPzWvA/ACZf yhz/sCnRWMU1INYP+2A3EUNtKz3eEixPrdEGc77wdM0nj3sQ+V X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84409542" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fdUWhzwYFLbf94YHHSwHkbAhauXOZkx4NNRI2NGx96mBKHodicdRODuVLx1XXnqb0dH4kvZz5cmgoXPxEoYqlr0r2PBMeoH08lMucXXiVu6IS+S5IS7YhIdRGfZXzJH1aUorHfI3UiGm3FokO3reQRrzgngrAU0mqUv0xfOh4WciwClh3NSds8+8kSiWTNW2AvmE1fOqRN3xc3XCTwD3HAYlTX0rXdJi/Gqszfy084MBiI7Dqam7VoxkL19iQTe93rZkFICr06Ja4bLmcxkwA+eUQStvQYs0LF8uBnwcPvXZkGJxlFUmuO9KAlcASq2oc/THCXbw5n7c102kF0K6pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V9+hvvG2mqZMLMmDMzXi42EbSUyCbjQSm+0O55VfEdk=; b=E6UQxgloCfJlBZh+xJcjufDRbE7UDPF3fqBc72lMYseMSpoT0KgrjAsjTeHKt2SHY81IWijxaH2XBi1D9byEfc4VBHInxKhAk1Xs7VhyfjfcOQfVusigN32mQklQPWc1XCuy4rlUNQIhcuPvyarYPNY19e4ncPPLGnDElSg8sQsc+uzqW5E0PaT6MRfI/DqRbfGgE+zT8KRa/S0THabDqgkmHzRlgqquIVIfF+hsvN58HokmaCa8WzrqyL59YFNGUN4MPsVB9nEYyD/84MHm68Iu+KAKrj80rq0sg509FDn6vwwPzxaBpverZ1zSAvRjC1QOC4FFRDfKBbSMTsjSGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V9+hvvG2mqZMLMmDMzXi42EbSUyCbjQSm+0O55VfEdk=; b=v0W/tyE8lYd8Boy116ZWCwaCjzSvnAEnqkT2UJwwk2nJgiVOoT1bZiLaRQn+ENoDGaSkhiFqL1J/u/K8emHLPPVj4aJMWfhYapG3PUK4yHvyUkDRi3XrKEvuM30NsKQxQwqQUSg0v2N/GEAQcPw2sR6m4ibjq+hYnoBL1YR8XFw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 8 Nov 2022 18:15:33 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Wei Liu , Edwin =?utf-8?B?VMO2csO2aw==?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Message-ID: References: <20221108113850.61619-1-roger.pau@citrix.com> <58d5e890-e052-47df-42bb-6cc84aedd4a9@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <58d5e890-e052-47df-42bb-6cc84aedd4a9@suse.com> X-ClientProxiedBy: LNXP265CA0033.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::21) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|CH0PR03MB6051:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a7b2aba-f3de-4c77-e571-08dac1acdbfa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yhu978zGOsyp+t1q89AyvlMpFB3PQLHu0vuZdvz9qWTrK4YAS+vh1uCPcgv1tgjv/eKiwZve9cjdKwVrkolSb85uVve4meTPhvT74kjxKdeGvdv6xvfFnek3PuAKGmASub6sSV0ByMIbg2Z6F+zZU966qmKHpQAfFZtOulW1s5W4k+ym9kcEDUFPri5uGR31RJD1AnaDCnMVZbPVolY+jUZarej1WwpU+Z7VDLLAt4S4WFrgugaWDY63PzRsUL/qzL8v08xixsEHjqLVG94WWwuz+L7nxY76NO28B4DNghgmcEHHf0DoyA2bPkhsuhXfM8fnDnzDg2DDvuHWUECdkAYN8ZNJf9j8cJ+XVVCCvoJCtDq9RevQUv0NrlzNRoyQoNnF/ZGjDOwHBEtsj46m9vk8unld2NZm7WrtwysCAcoS6wwcSZICxkBixVEn9JFeFOsEBb7rohy1iP0LsX3P6g8OY2MtY8GhV2OaDxW3H8mKbZrfUrZsXqasoO+KZr0ik4TUlgk/tAa25gljgRFpP2uVMbTeH7Omi+PEravQLlkbimNvk42YdoDI0xxBighIIDyhyIa2ZM9HXFU3ddMBm1dd8aCuvhlFRYWkIXjLYCbAii+8gulsWjxOJrsI2I0cQB+4PbEksfda20UapBorHZyRYapjMpa/1gVHXaKpb8GCfu6bID7/Tk0v36oNfnsiaULoiSfPKNfwUQxLDjGB/g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199015)(4326008)(8676002)(6666004)(83380400001)(316002)(2906002)(85182001)(86362001)(38100700002)(6506007)(33716001)(82960400001)(53546011)(66946007)(66476007)(66556008)(9686003)(8936002)(6512007)(54906003)(6486002)(41300700001)(478600001)(186003)(26005)(5660300002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dm9CNHExc3BpelBHbUI4MGk2V09xNnFLYWkvVUFPY2M2ZnNKS0k2K0RzV0Fm?= =?utf-8?B?ZC9yM2xRSEhlRHp2QlcyU2dyY2VZcFh4Y2IwTWVRQnZqbVdlT1g1YTlCY2xB?= =?utf-8?B?djRZdDZ1eXM1bTJiWVk0VVBCc012WUxqQWllVTlPeDRTdS9nRWpjcXVyb2hW?= =?utf-8?B?MmNUMTVFUDV1M2M5dlFEOUdqRGhzZllUL0F3QXl6QVFwWC9rVWxXOEdyV0RR?= =?utf-8?B?OXdRTE10akFQMGN0U21iNWJXU2l3K2ljL1dSSlNyUGZub1BERThkcVdXTnVD?= =?utf-8?B?b2xydTZkdWNSck1yQXNOR0xzTythWit3bUFqVGZCU2hEazhlOENmV2Z0MVBO?= =?utf-8?B?MEVvMWM1ODlNRkNMbFlaVkxZc2VJb29TOWtQYzlrTmVVVGZESHJGeC9HL1NN?= =?utf-8?B?Q0tGdjZacyswSmIwQmgwWis1VVhQZk4vd3hkWU9kOXR0SFZlRmhnWWZ1M3kr?= =?utf-8?B?Y0pyVDJhQzZnaFdDdDdnREZLdGE5NHhyS2VMTGJqTHIwOGloNkg4VnFHSjlG?= =?utf-8?B?T0tBZWd1UVRwbXNjNGdRMXBaRkZkQWJPdkZvdm9BdU50dTRXTzJMU0s3ZFJW?= =?utf-8?B?cy9SM1EzQmhBaWtTV1pQTEJrdkJDVHp0bE01SGQycWpkd1ZiQUNCcmhHR2ND?= =?utf-8?B?QUZmaDhtd3VueFF4K1MwSTZXRklFeXo1aDUyZFg2eTJ5UDRRbGlEN3BDT0Q2?= =?utf-8?B?Y1BJeFVPWXltQTltaHVhRE9uYXdjZzFUMWVUay91T2psY0FvZTBYRWEvOUNJ?= =?utf-8?B?dHVnbklQK0FyVEc5aWJkREYzdzFubWRUdzErRzc4Njd6TXVTcTIyc1J2aGZs?= =?utf-8?B?S3JGL3FUU2U1bXBTdHFTZzhSVURhRXp1UU50NC96bk1CN0lRdmlxTW1FS0VD?= =?utf-8?B?YXZnR3RoajNheDQ1K29DcUFhbW9zNDVGRmNNeFB6WnB2STY4Y2F1elcyVlFs?= =?utf-8?B?cjBYTjhmbGpiY1piYnpwcXJLR2k1T3p2K0NtUUpNWXdOVlBTM0JpTGFwZEcr?= =?utf-8?B?MW5Lai90WENRMTdsVWZlbFZQclhlRU1WSnl4ZWlmTkdTVDdrWmt1UUVlSkU0?= =?utf-8?B?dnVlLzVVZ1Zoa1FUVlNyK1ZMWGRaMlZDa1c5a3d4cHBJSXlRMjRrQUhrQVNP?= =?utf-8?B?VTNmcW93QUpwNlptSUd4MStUSWp5R1RNN1lkRk53b0V4eEhzOUpSMXdPc0pC?= =?utf-8?B?WU44cUw4MTBSdXYrMWpJMEFKblh3ZDhhaGVRU1FtbVJzTnlUY3hSTTdiTitn?= =?utf-8?B?QXBuYjF5WUtZUFM1QnFNK3I3YjNwMDkyQlFuVTNBWjVSSGNRUkV6aVp4TWZW?= =?utf-8?B?OTJGNzJrS2FLbGxqd0NjRlhDa3JDUk9aYk1wRUtCdlkvVTk1SjhTMkh2S28z?= =?utf-8?B?aTB1ZWMydWZLVUNJaGJkMmhLYUdpSzFDcWZkUlZ3UFVTNFduOCtFdXlnSDFZ?= =?utf-8?B?dlE5NVNONkxlRE5Ta0didlA5NWYvZXBsckRDODlLU250ejlPSlU1bVBqb3VH?= =?utf-8?B?UlFOYUV6Z0pxdHM5TktiRlF6VlJWWHFQL25ya21qZmpkK2Q4aGNOL0ozcHo2?= =?utf-8?B?cnBRV1JZeTJXM3AwN1RYNFgyaTZBZkk1L1VRZzh0d2NVMjdTOVFxMXUxR3Vm?= =?utf-8?B?NjN2MklTNzhRWGVPaDBvOEVSbWNRdFpUMkFhbWJVZzNMdHRya0o3K0I3clIr?= =?utf-8?B?VHhrZ3lUMXo5c1ZnSmhsaG9vYTVCRDJicHlGRWEwWEkrajRuT3lNa2kyWUp1?= =?utf-8?B?TmJrcm40UlBHTzJOMm45RFJhOGJjeWFCNzlLOXMxOWFpY0xsSmVYaXpKcXlo?= =?utf-8?B?QjlpbnB6Zm9uMnYweFptN3F0VE5oR0lTZWdYZmNPTWFYOXNEK056dGVEa0xi?= =?utf-8?B?dEVHNG5wdEpTNnJHUlFKcFB2RGZwV0xFWHJ0VGRyU2JycVk2M1JkOERmTUt6?= =?utf-8?B?dEdsZXJIdGdzY1M2QTlxZDlSN0svaG40Ny9FUGQxSXU2SkFFSlNYUllIamls?= =?utf-8?B?RkpBMGVURFNCN1BnMXhuRHFWbTdzZllwK29vRXY5MEowemcyemhQYnNxWmtX?= =?utf-8?B?bUFUSE9CMFZxakwzNm40dVRlV1JWY0NqR0V2b0FrcEU0T29OY25aWG1JdDJY?= =?utf-8?B?ekJYRWpybjB6WW1HNFZqWENMWG5HN05TZkk3L3FjT3N3YVlzaTZDdTI0NnJ2?= =?utf-8?B?THc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a7b2aba-f3de-4c77-e571-08dac1acdbfa X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 17:15:39.7878 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NeEszOGYCupYvpKCW/p2V7WXVQCP96YB87B+0ZvJxoNpqQz6wmCZdvefGbHGUtOEE6gdS2YTEvmCp2pmFYDX8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6051 On Tue, Nov 08, 2022 at 06:03:54PM +0100, Jan Beulich wrote: > On 08.11.2022 17:43, Roger Pau Monné wrote: > > On Tue, Nov 08, 2022 at 05:14:40PM +0100, Jan Beulich wrote: > >> On 08.11.2022 12:38, Roger Pau Monne wrote: > >>> Like on the Arm side, return -EINVAL when attempting to do a p2m > >>> operation on dying domains. > >>> > >>> The current logic returns 0 and leaves the domctl parameter > >>> uninitialized for any parameter fetching operations (like the > >>> GET_ALLOCATION operation), which is not helpful from a toolstack point > >>> of view, because there's no indication that the data hasn't been > >>> fetched. > >> > >> While I can see how the present behavior is problematic when it comes > >> to consuming supposedly returned data, ... > >> > >>> --- a/xen/arch/x86/mm/paging.c > >>> +++ b/xen/arch/x86/mm/paging.c > >>> @@ -694,9 +694,10 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, > >>> > >>> if ( unlikely(d->is_dying) ) > >>> { > >>> - gdprintk(XENLOG_INFO, "Ignoring paging op on dying domain %u\n", > >>> + gdprintk(XENLOG_INFO, > >>> + "Tried to do a paging domctl op on dying domain %u\n", > >>> d->domain_id); > >>> - return 0; > >>> + return -EINVAL; > >>> } > >> > >> ... going from "success" to "failure" here has a meaningful risk of > >> regressing callers. It is my understanding that it was deliberate to > >> mimic success in this case (without meaning to assign "good" or "bad" > >> to that decision). > > > > I would assume that was the original intention, yes, albeit the commit > > message doesn't go into details about why mimicking success is > > required, it's very well possible the code relying on this was xend. > > Quite possible, but you never know who else has cloned code from there. > > >> Can you instead fill the data to be returned in > >> some simple enough way? I assume a mere memset() isn't going to be > >> good enough, though (albeit public/domctl.h doesn't explicitly name > >> any input-only fields, so it may not be necessary to preserve > >> anything). Maybe zeroing ->mb and ->stats would do? > > > > Hm, it still feels kind of wrong. We do return errors elsewhere for > > operations attempted against dying domains, and that seems all fine, > > not sure why paging operations need to be different in this regard. > > Arm does also return -EINVAL in that case. > > > > So what about postponing this change to 4.18 in order to avoid > > surprises, but then taking it in its current form at the start of the > > development window, as to have time to detect any issues? > > Maybe, but to be honest I'm not convinced. Arm can't really be taken > for comparison, since the op is pretty new there iirc. Indeed, but the tools code paths are likely shared between x86 and Arm, as the hypercalls are the same. This is a domctl interface, so we are fine to do such changes. I understand that we want to avoid such interface changes as much as possible, but I think we need to fix the hypercall to return error codes rather than implementing workarounds to try to cope with a wrong interface behavior in the first place. Or else we could be accumulation workarounds here in order to fool caller into thinking the hypercall has somehow succeed, and provide kind of suitable looking data for the output parameters. > >> As a minor remark: _If_ you're changing the printk(), then please > >> also switch to using %pd. > > > > I've considered this, but then printing: "Tried to do a paging domctl > > op on dying domain dX" felt kind of repetitive to me because of the > > usage of domain and dX in the same sentence. Anyway, will adjust. > > Simply drop the word "domain", as we've done elsewhere when switching > to %pd? OK. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Nov 08 17:21:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 17:21:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440358.694543 (Exim 4.92) (envelope-from ) id 1osSIA-0001CN-7q; Tue, 08 Nov 2022 17:21:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440358.694543; Tue, 08 Nov 2022 17:21:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSIA-0001CF-4Y; Tue, 08 Nov 2022 17:21:42 +0000 Received: by outflank-mailman (input) for mailman id 440358; Tue, 08 Nov 2022 17:21:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSI7-0001C5-VA; Tue, 08 Nov 2022 17:21:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSI7-0004Fo-SP; Tue, 08 Nov 2022 17:21:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSI7-0007N2-BD; Tue, 08 Nov 2022 17:21:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osSI7-0008OE-Ae; Tue, 08 Nov 2022 17:21:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HWXi4ndfdkWBBakTf7xqapPtdfzhFBbGx12QhLTAiUM=; b=QVg7VIMQt6zNrvA1xet3CpkIQ7 hpC6yG+uSr4J2yAKbJ1RjNaA2UGuhqiVRh+yN4u1M0sRsF3akUsGmVaDARKnGOc4JHzwbNKWoaYk6 L+C1UJHXsxxWp8aV+zivm0baieVoPuHbk9dIWpZfecXVjJ2+U/UugAZjHPriM1eOb6kw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174668: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start.2:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=524fc737431d240f9d9f10aaf381003092868bac X-Osstest-Versions-That: qemuu=cd706454c6cd239a477cb227caf3e3dfbb742d1a From: osstest service owner Date: Tue, 08 Nov 2022 17:21:39 +0000 flight 174668 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174668/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-vhd 20 guest-start.2 fail blocked in 174662 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174662 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174662 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174662 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174662 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174662 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174662 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174662 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174662 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 524fc737431d240f9d9f10aaf381003092868bac baseline version: qemuu cd706454c6cd239a477cb227caf3e3dfbb742d1a Last test of basis 174662 2022-11-07 20:38:46 Z 0 days Testing same since 174668 2022-11-08 05:15:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Greg Kurz Rui Wang Song Gao Stefan Hajnoczi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git cd706454c6..524fc73743 524fc737431d240f9d9f10aaf381003092868bac -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Nov 08 17:26:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 17:26:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440378.694554 (Exim 4.92) (envelope-from ) id 1osSMk-0002AI-V7; Tue, 08 Nov 2022 17:26:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440378.694554; Tue, 08 Nov 2022 17:26:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSMk-0002AB-SW; Tue, 08 Nov 2022 17:26:26 +0000 Received: by outflank-mailman (input) for mailman id 440378; Tue, 08 Nov 2022 17:26:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSMk-0002A5-CL for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 17:26:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSMj-0004Ky-RS; Tue, 08 Nov 2022 17:26:25 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.3.98]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1osSMj-0003gN-L0; Tue, 08 Nov 2022 17:26:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=pq+aovixWz5f+jUh/zfTLKQel4PuNHX91XIkvFXAIKw=; b=0VSossTVJiFzWPalVjJH1DH/iC AeWOdyuSKpUrTGIwfxaAtznffpJw9dEOQUyq/7ZraozENmngHqYVJxlH8pgQqNPO+57oFqoa8K/2n sJhNR8XYQN6WswWurnIqaGRZ9tIlv0Q9T/M/Pp/YQGVleUTLmgRs0lN8tL4pDG7rCtww=; Message-ID: <1f8c90cd-8037-84eb-d6f7-c639f8a87585@xen.org> Date: Tue, 8 Nov 2022 17:26:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Content-Language: en-US To: Edwin Torok Cc: Xen-devel , Henry Wang , Christian Lindig , David Scott , Wei Liu , Anthony Perard References: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 08/11/2022 17:02, Edwin Torok wrote: > > >> On 8 Nov 2022, at 16:03, Julien Grall wrote: >> >> Hi, >> >> On 08/11/2022 15:33, Edwin Török wrote: >>> See CODING_STYLE: Xen uses spaces, not tabs. >>> * OCaml code: >>> Using `ocp-indent` for now to just make minimal modifications in >>> tabs vs spaces and get the right indentation. >>> We can introduce `ocamlformat` later. >>> * C stubs: >>> just replace tabs with spaces now, using `indent` or `clang-format` >>> would change code too much for 4.17. >>> This avoids perpetuating a formatting style that is inconsistent with >>> the rest of Xen, and that makes preparing and submitting patches more >>> difficult (OCaml indentation tools usually only support spaces, not tabs). >>> Contains a bugfix for `abi-check` script to handle the change in the >>> amount of whitespace. >>> No functional change. >>> Signed-off-by: Edwin Török >>> -- >>> Reason for inclusion in 4.17: >>> - makes it easier to backport changes from master to 4.17 >> >> Right, but you will have the problem when backporting to 4.16 and older. So the overhead will always be there for a couple of years. > > > There will always be more than one Xen release in support, which means we'd never be able to fix this. Note that I haven't said this should never be done. This just need to be correctly timed. Doing it in the middle of a deep freeze doesn't look right to me. [...] >>> - avoid perpetuating a different coding style (I thought tabs were >>> mandated by Xen, and was about to fix up my editor config to match >>> when I realized Xen already mandates the use of spaces) >>> - should make submitting patches for OCaml easier (OCaml indentation >>> tools know only about spaces, so I either can't use them, or have to >>> manually adjust indentation every time I submit a patch) >>> - it can be verified that the only change here is the Makefile change >>> for the new rule, 'git log -p -1 -w' should be otherwise empty >> >> While I understand the goal and support, this seems to be a bit too late to do it in Xen 4.17 (we are only a couple of weeks away). At this stage of the release we should only do bug fix. > > I think it can be fairly easily proven that there is no functional change by rerunning the make format command manually, and by looking at the diff with ignore whitespace as suggested above. That's not really the point here. The point is that if we start to allow large coding style change (whether automatic or manual) very late in the release then it will be hard to reject it in the future. In fact we already have guidelines for that. If you look at [1], only bug fixes should be done past the code freeze (23rd September). As I wrote before, this patch only seem to be a cosmetic/quality improvement. IOW this is not a bug fix and would not qualify for 4.17. > I understand the reluctance in including it (which is why I was not sure whether to post it in the first place), but I think it might be beneficial to do it. > There is a large backlog of work in oxenstored that got piled up during the past couple of years of XSA work, and it'd be a lot easier to update and upstream those if we wouldn't have to worry > about indentation at all. This is an argument for including this patch in Xen 4.18. As I wrote above, I am not against that. > > Usually patches on LCM and security branches are avoided to reduce the risk of breaking anything, but a reindentation patch should not really break anything (well other than the abi-check script in the build, but I fixed that to accept both ways). What does LCM stands for? > > One alternative would be that I add another step after reformat that runs sed and turns spaces back into tabs for now, and that way I can still run 'make format' at each step while preparing patches for master, or 4.17 or security patches and get something consistent, and that minimizes other whitespace changes, but it wouldn't completely eliminate them (e.g. there are pieces of code that are just wrongly indented, so there'd be at least a diff to fix all that). I would view this as a feature. Which again doesn't qualify for Xen 4.17 release. This doesn't mean the patch couldn't be backported afterwards. Cheers, [1] AS8PR08MB7991145C8063D6939AFFED8F92829@AS8PR08MB7991.eurprd08.prod.outlook.com > > > Best regards, > --Edwin > >> >> Cheers, > > >> >> >> -- >> Julien Grall > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 08 17:31:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 17:31:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440384.694565 (Exim 4.92) (envelope-from ) id 1osSRK-0003b1-H8; Tue, 08 Nov 2022 17:31:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440384.694565; Tue, 08 Nov 2022 17:31:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSRK-0003au-Di; Tue, 08 Nov 2022 17:31:10 +0000 Received: by outflank-mailman (input) for mailman id 440384; Tue, 08 Nov 2022 17:31:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSRJ-0003ao-Ib for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 17:31:09 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1c0cfcc0-5f8b-11ed-91b5-6bf2151ebd3b; Tue, 08 Nov 2022 18:31:00 +0100 (CET) Received: from mail-mw2nam12lp2045.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Nov 2022 12:30:58 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by BN9PR03MB6041.namprd03.prod.outlook.com (2603:10b6:408:136::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Tue, 8 Nov 2022 17:30:52 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%4]) with mapi id 15.20.5791.026; Tue, 8 Nov 2022 17:30:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c0cfcc0-5f8b-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667928661; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=4Z4ewcNnrsVNE0uBBmtvInNERM/uCrR5M6+4HiHK/Ig=; b=Ub/nb6O7YO6IgJL3W5ufANtpYNaVWQmchgzBJdb8xtzVb3S7bzryzMwT vcUgzSAa8nmMHjpaSI/uP3O3RRYiSgUik8XZKV8QdXL9bLU8iCKR6A4QR Z0H1CRC6J3X4m+Dinb2tvDqSI4mtN9oNZK6ZgyX5Jgcjnc4NRrIMmQwHk s=; X-IronPort-RemoteIP: 104.47.66.45 X-IronPort-MID: 84840093 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Bxmvxao8yGqhvALwbLGucWL4tYVeBmIqZBIvgKrLsJaIsI4StFCzt garIBnUOKrbZjOgfNEiYd+0p0kB65ODyIUyHgFv+yw2EHkW95uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzylNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABALRRGdpPu6/LemZrlyvfQ5LeLWNpxK7xmMzRmBZRonabbqZvyQoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3juarbIe9lt+iHK25mm6Vq nzH+SLlBQsdN/SUyCaf82LqjejK9c/+cNJOROHgrq8x6LGV7ksaGhgZcxyEmKm8sW6kQ+hzD W4M4TV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yyaUAHIVCAFIbtMOvdUzAzct0 zehgNfBFTFp9rqPRhq15rqS6D+/JyURBWsDfjMfCxsI5cH5p4M+hQ6JScxseJNZlfXwEDD0h jWV9i43guxJidZRj/nmu1fanziru57FCBYv4RnaVX6k6QU/Y5O5Y4uv6h7Q6vMowJulc2Rtd UMsw6C2hN3ix7nW/MBRaI3hxI2U2ss= IronPort-HdrOrdr: A9a23:C2VOj6m7pw3tJu6LZhHSvrZNN3TpDfOPimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza9B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuRt3Us4vkWUzxjIjLH47JlON1Kk3VO 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEz82IIgMgE2nsQ/pM0TJdJo+ zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBOB1vd75rspLkl7uCjf5IFiJM0hZ TaSVtd8XU/fkr/YPf+qKGjMiq9NVlVcQ6duf22vaIJy4EUbICbQRGrWRQpj9aqpekZD4nSR+ uzUagmccPeEQ== X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84840093" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g06cO74C9k9XEkrKkepfHlG0m8nq/pZ0p64hb4qooSiHF9j+XfyjTuAPOz3kaJhS+6mY/vrOdfEr0Hw/Lb3N0WYos3KSbmNTobqJmeojJ61xErTnLUFCrV6/hKGOXONU77fhIIpWjhbd23fcmQJPNQKtYiFJbAJQOZ9qHUC8PPo29SzX7y/fXtu9MQH0tgcdnmLAydI6phvr4UPanM14COkqeOG7h+I0TpF+VzVVONyr9XOp/kYkUmNh0ZrdwEnlpUjbD9qsKd44yI0vM/XcPO/9yJ934jiC9HGvGQWTGbRcupKkWyujkcrEm8EVeqnHPM+e8ToSdRNyrfRBkWZz6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zxAQ4QUhzyfeN2nctawIFuF2BRi3JbLtPJDQWxUPQzA=; b=ZcI3WL0aotarJ1/07M0FEiFdrv2XR2P5AWnOMnbqnobUUgkm3Q3GU6NFBsrEgmdJwg5J9CNuSQ4AQ0ou/BY6jwIQH0HhNktvUs1PusaMybf7YJ/iONOrQQwBa+JcDLMvWiPdRahmwZsCUVmQIwE8PAtPUeb9VtZzJa6UVZu1qmW+Z375SIhxicD3yGnOzfEpJ02sjAUMjGlaq1kvIiKOAKz6aSix6xP8ALCKAWytXB1bPMRXnsyJnc+1rf0WvDnOaL6yZWyzYg49bejttoHQZb8Eqnw04fBM8YsYbOEiY8x8EanXCDOoOfrU2iRlQCpP+Keiz6/A+C9F6HhQAAC/8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zxAQ4QUhzyfeN2nctawIFuF2BRi3JbLtPJDQWxUPQzA=; b=dVhSxFoYebgU9X0SKTHIGps9Sd6vgx6DFy77TMLlTasge9mtPeVkYsZnMp662JSX5zvDc+3c0XLTOZVfhL7KqNN4qJrAZzKlKT6SAfhKAsLzlzJ8XDSFAWUGC+cMLxJ6xULNIa+qyaCzHbvnxW1ubcgttFckk1CuaGUkE45Q+Bs= From: Edwin Torok To: Roger Pau Monne CC: Jan Beulich , "Henry.Wang@arm.com" , Andrew Cooper , George Dunlap , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Thread-Topic: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Thread-Index: AQHY82a4odYEEDJCoUOUarTvbCvSoq41M5sAgAAIFoCAAA0ngA== Date: Tue, 8 Nov 2022 17:30:51 +0000 Message-ID: <6D1888A8-2A0B-45A5-BA3E-2F02B0950F3C@citrix.com> References: <20221108113850.61619-1-roger.pau@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|BN9PR03MB6041:EE_ x-ms-office365-filtering-correlation-id: a1c8d6ac-c6d8-4ac7-8817-08dac1aefbd9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /fj0eHr3mXt6Wmkc+nGlXmJVdMpwMlCrDqtgPzRqee17EI6wk9RuRty5Ehrtr1N0b6+qK5DL3QCZPpncj7NuwLwmAXqsBu7VaaVZyr+P8zBGokFZqwPCsVEXwCs/v1Oi3IiK4EQgLDaZt9oMJZg+zugrRzDcI1W+o81KprnxhTGE/ojYVS550wWlg4jJKFva1wttB4qOwFMZYbG2h/tbiuY0r+mr1PbUyKkpoAL+MDs7CO6uuSfT9TpVeXri11COtxxYZmvVrOarT7OLqwrrFuCCmrOCr85AyeDGFkZHPUlRIZv6A/5RNORL641ngbnjCpfyQzOacZLwei68H+qShjDbixcrGDP/Htyyv9OzXHg1+FjD33NJ8mp0tRcA5ZwhDgL0e8qASOZWe8R5WSeKykUP85UZybFzY0XbwqPANvQBBJQpifa+uMQDQchqSq4O3omNIZQ+xrGJLPWEKFjrVTv2cOXP1EsMRsXgiyxzJO1/EuwRZCbXoYG4SVBFOGE1CiZuXStywnu2b9JlxlRcJeANdosJHexe6NTTZE4RYrfVivOQHkLUdZZx64TaieLYzI9aiU2pNJTta6dVLxQ2D5tyS0TMq41kmSJ1f3nprHXsEhuFYUciWE1Zypbh62ZSTmiH0QtgsRlvAgpVVIu5WjfDgjM8UTbCvYXq9QU3CU/z6vVhtuW2JJBvnKUcxm0oE1pG+2pD5O1KZkLIqlpCd1Zr8DaL8VXzxaG3CMG81pGxfGoRI30EwW0Z+l13pNUw7/I0oQm1kzT7Niq2SEYb7ZaHnPlxG8XMSOllf36YzgvWEJ0RNaSAzAfykK8M4WIDVlRy1iG+7srVlcmeVs0DzA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(346002)(39860400002)(366004)(451199015)(36756003)(38100700002)(122000001)(86362001)(33656002)(966005)(6486002)(478600001)(82960400001)(38070700005)(83380400001)(2906002)(186003)(26005)(6512007)(6506007)(66946007)(71200400001)(6862004)(76116006)(66556008)(5660300002)(8676002)(66446008)(8936002)(64756008)(66476007)(53546011)(91956017)(2616005)(4326008)(37006003)(41300700001)(316002)(54906003)(6636002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Eqk2kazHRPbIFHmV4/7TChwJvt/05g1W6k8WMliMCeDJbg920TsxGe5MCOFF?= =?us-ascii?Q?AT/7872hTnb2s636qAQFLLSHwN/Kdk/3c5ugU7oM5cgT4sAQ1zvGf9kB/4Dv?= =?us-ascii?Q?OoZoVxNdV+01NNGTkofcGlJp9GPrStmnYylZ6OcJ/Ni6s40bo+OEZ4HjxO1A?= =?us-ascii?Q?HIoqcNmKYh99lDGObFJLlqqq9ck6ZLa1flvE9Fa5ZKnwGtfTY877Hj1UjBHb?= =?us-ascii?Q?DBcwqA9nRYVUwLIhrfMXZ1kOH76Rn58PWXQeiMVOKZuvB2/jUqZlbfGNc5gT?= =?us-ascii?Q?Sefd4kLj6mxpfjnP+n0l+KYR+LcF1FyFq6ZI39t1ifsflc8dxcLVvaV/nsOp?= =?us-ascii?Q?sRlidLBtq6L7guicDOnBzoJYt9Us4RRzOc5609WFZpf0tA0tLrCNYCb++k+1?= =?us-ascii?Q?hQwuUfFkpbKFFfYlqVy/RO4Wkr2Y1vdS+ot1zBykhaE8SxlpNsbW8+B5OlRj?= =?us-ascii?Q?XlmplahSdbs5F9ENqckg+NSC4+sCS0zrVpqx8APtM6NxFM/SRfHm6LOsFb3K?= =?us-ascii?Q?l2+BUeakQUkmKytf+qPUWma3WXqP9YMYQexRFWvuP23gY33pZCRzpz60IZhZ?= =?us-ascii?Q?yxlXYOaG+0VWZPj1mgsoX4PUV9aK8pBwzbyupaIEuIGLvmXgB3y/e59c6v+H?= =?us-ascii?Q?qSPW8TVFQYKT+1pwSHYKJpicyNd+l9Se3I15huHY99Jya3tfZMKw4kGg2Q6/?= =?us-ascii?Q?t78s7wD9ETuezXb4HwSYaFpVoAhn+xik2JLxBZacSSwcMuL636rLV1tdhd+1?= =?us-ascii?Q?1yC0lfcSB0OTlHOuh0BZv7JyH+5B9X2s546xQMCgaIeNHhnrOk7q0potHJDf?= =?us-ascii?Q?T9rNHUfbVhnpgeEGfrHvwU4yNQhc+tEWx8QA0FqcfpUsNo1LsXIVEKHuObLi?= =?us-ascii?Q?hxm4m9disrmOP4WQyTYknH+in+L46/i8ZVj4+pGoFB6jcMK9Joglc5Dq0xeL?= =?us-ascii?Q?yBxTsKuach44ykqEWDvVp30jR+WaSpNCHFerAGRuCUpTJaJA1ojeJ/jQUI4R?= =?us-ascii?Q?SMOs7PrF7YWTFyRntMdEGt19V/jfRtUDR7gJzoXZ//9B2SkDlRLUx91NKtqu?= =?us-ascii?Q?Kgx4LkVz1BC2uSEN8ed5WvrjBbl65QwhFPD6UjVDD6UXSYSic4bdLHUGif6d?= =?us-ascii?Q?0doIZbQVbM35ueBWfxgqiJErO0MMyPndSJyfZcL/CMz2GV8faEMlSHmhx8gJ?= =?us-ascii?Q?Y1ahU5Y6Bwc8T3AKvVzGlFAzDIKVw/bZvUwE3+imaD/USY7eESRHZn1u9bKD?= =?us-ascii?Q?eEKym+rScUZy3JcauXAJUgxWIX1mW5/TPZ+UAdeoTb1e8hcMAH3ico2xm4K3?= =?us-ascii?Q?kuIXH6R4Si4YT6Nv2hmU7K7lxr8XjrHUESXEcq/7OJY4gjmkK1M4wtwM9ctt?= =?us-ascii?Q?Pa0JxGoyUcH+mFGO6lblBO9gYm0aQN0U9gYjxBI14QecMcbNQEwQmbAYEfuq?= =?us-ascii?Q?UGQ1zwBn6vK0j6nQjIK49kEoLuQB0sprx7w1LRPVC4IDjQd3ZjZSSDTl5lrm?= =?us-ascii?Q?hxk5F53XSalXcjHibDQnCFBrurb5V0QuLe6r2Is297D5U/fBcNrvF8qdT6Gl?= =?us-ascii?Q?sXQlrVnPgq1nGJ0c3ilgtNY+dJHCiCcmrL7MGaWcC+Zwz2moOVXxlDCEXpAU?= =?us-ascii?Q?jA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <569583CEFAA95A489FE41DD80D5D11AB@namprd03.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1c8d6ac-c6d8-4ac7-8817-08dac1aefbd9 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2022 17:30:51.9841 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B/amTq8/yMOS3eDmU1irax28BqC2FyfV+W3yEKV/QAU6ARJ2xqV1etuyrhgV2HyB+kzaDaot/eX665VRsihoGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6041 > On 8 Nov 2022, at 16:43, Roger Pau Monne wrote: >=20 > On Tue, Nov 08, 2022 at 05:14:40PM +0100, Jan Beulich wrote: >> On 08.11.2022 12:38, Roger Pau Monne wrote: >>> Like on the Arm side, return -EINVAL when attempting to do a p2m >>> operation on dying domains. >>>=20 >>> The current logic returns 0 and leaves the domctl parameter >>> uninitialized for any parameter fetching operations (like the >>> GET_ALLOCATION operation), which is not helpful from a toolstack point >>> of view, because there's no indication that the data hasn't been >>> fetched. >>=20 >> While I can see how the present behavior is problematic when it comes >> to consuming supposedly returned data, ... >>=20 >>> --- a/xen/arch/x86/mm/paging.c >>> +++ b/xen/arch/x86/mm/paging.c >>> @@ -694,9 +694,10 @@ int paging_domctl(struct domain *d, struct xen_dom= ctl_shadow_op *sc, >>>=20 >>> if ( unlikely(d->is_dying) ) >>> { >>> - gdprintk(XENLOG_INFO, "Ignoring paging op on dying domain %u\n= ", >>> + gdprintk(XENLOG_INFO, >>> + "Tried to do a paging domctl op on dying domain %u\n"= , >>> d->domain_id); >>> - return 0; >>> + return -EINVAL; >>> } >>=20 >> ... going from "success" to "failure" here has a meaningful risk of >> regressing callers. It is my understanding that it was deliberate to >> mimic success in this case (without meaning to assign "good" or "bad" >> to that decision). >=20 > I would assume that was the original intention, yes, albeit the commit > message doesn't go into details about why mimicking success is > required, it's very well possible the code relying on this was xend. >=20 >> Can you instead fill the data to be returned in >> some simple enough way? I assume a mere memset() isn't going to be >> good enough, though (albeit public/domctl.h doesn't explicitly name >> any input-only fields, so it may not be necessary to preserve >> anything). Maybe zeroing ->mb and ->stats would do? >=20 > Hm, it still feels kind of wrong. Without the fix in the bindings (and any fixup in other toolstacks as neede= d, I haven't checked): https://lore.kernel.org/xen-devel/94f93ee61a4d0bd2fa= c3f5a753cb935962be20bb.1667920496.git.edvin.torok@citrix.com/T/#u a value of 0 here might still cause things to go subtly wrong, i.e. cause t= he HVM shadow multiplier of a VM to decrease, although I think there are sa= feguards against it going below 1.0. However a ->mb value of all zeroes is much easier to debug (and detect!) th= an a completely uninitialised value. I'd prefer if the return value of domctls could be trusted to mean that 0 = =3D all values are initialized on output, and to be potentially uninitialis= ed only on failure. There are a lot of other calls with similar pattern (particularly around vc= pu, which will go down a different path) in the xenctrl bindings, and I hav= en't checked them all yet, but it'd be a good rule of thumb if the behaviou= r was consistent with other hypercalls/domctls. > We do return errors elsewhere for > operations attempted against dying domains, and that seems all fine, > not sure why paging operations need to be different in this regard. > Arm does also return -EINVAL in that case. How about we return EINVAL *and* in DEBUG builds fill the struct with an ea= sily recognizable poison value? >=20 > So what about postponing this change to 4.18 in order to avoid > surprises, but then taking it in its current form at the start of the > development window, as to have time to detect any issues? >=20 >> As a minor remark: _If_ you're changing the printk(), then please >> also switch to using %pd. >=20 > I've considered this, but then printing: "Tried to do a paging domctl > op on dying domain dX" felt kind of repetitive to me because of the > usage of domain and dX in the same sentence. Anyway, will adjust. >=20 > Thanks, Roger. Thanks, --Edwin From xen-devel-bounces@lists.xenproject.org Tue Nov 08 17:37:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 17:37:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440392.694576 (Exim 4.92) (envelope-from ) id 1osSXb-0004Uf-6I; Tue, 08 Nov 2022 17:37:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440392.694576; Tue, 08 Nov 2022 17:37:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSXb-0004UY-35; Tue, 08 Nov 2022 17:37:39 +0000 Received: by outflank-mailman (input) for mailman id 440392; Tue, 08 Nov 2022 17:37:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osSXZ-0004US-AV for xen-devel@lists.xenproject.org; Tue, 08 Nov 2022 17:37:37 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 072e0c74-5f8c-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 18:37:35 +0100 (CET) Received: from mail-dm6nam11lp2173.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Nov 2022 12:37:32 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by SA0PR03MB5626.namprd03.prod.outlook.com (2603:10b6:806:ba::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Tue, 8 Nov 2022 17:37:30 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%4]) with mapi id 15.20.5791.026; Tue, 8 Nov 2022 17:37:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 072e0c74-5f8c-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667929055; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=D/tqUZ8DclLQY6J1jbsoyCI+16ygZTKBiDCAKLhdM2k=; b=GtKk/mN8EtVGQj5cw5gjnDrMIl0nlGX4CP1/G+idHsIsOYNQvE+lJivZ 7MeqP+EOMzKO1neNiw/CVTcXcv3QfGf6ysmP9/65bFIFPbIkljxZ1iG02 PYsmgIcBVe/cHPrcqy1QoKqHoyRLX4tOXpaDBQQPf2Ojy9zqsFGPAXhgJ A=; X-IronPort-RemoteIP: 104.47.57.173 X-IronPort-MID: 84411567 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:6SwgW6Ig5ZkAczm6FE+REpQlxSXFcZb7ZxGr2PjKsXjdYENS12ZVy mZJWG6PbPvfNDChLYokO9i//E5VuJKAy9VnHVFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wRuPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5QBTFXx fkmcwonLRaHu+O14eqaSshV05FLwMnDZOvzu1lG5BSAVLMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dopTGMl2Sd05C0WDbRUtGGW8RT2Fqfv GXF12/4HgsbJJqUzj/tHneE1rOTxHqmBt16+LuQ9/9IhnyKxTMpEzYzBHawhuOJlH+yVIcKQ 6AT0m90xUQoz2SpU938UhuQsHOC+BkGVLJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/vJCDp1ofuqQHSS3r6OqHW5Pi19BWMLeyIsVwYO5Njn5oYpgXrnUdJLAKOzyNrvFlnNL yuiqSE/g/AfiJAN3qDipFTf2Wvz/d7OUxI/4RjRUiS99ARlaYW5Zouur1/G8fJHK4XfRV6E1 JQZp/WjACk1JcnlvESwrC8lQNlFO97t3OXgvGNS IronPort-HdrOrdr: A9a23:4x/5K60HI+1yV9UApkAOnwqjBJckLtp133Aq2lEZdPUMSL3+qy iv9M516faGskd2ZJhGo6H7BEDgewKmyXcb2/hzAV7PZmTbUS6TXeVfBOjZskDd8k/Fh4xgPM 5bGsAUYuEYT2IK6PoSizPXLz9U+rm6GdeT5Ns2oU0Acem3A5sQkzuRQTzra3GeDDM2faYEKA == X-IronPort-AV: E=Sophos;i="5.96,148,1665460800"; d="scan'208";a="84411567" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R34EZeByEbuM7DVp+ehwM5QIQ2ArqsEmhGgbDAmH8nb9T2drNwAmxx0sxmtYNoe+PPMMmKboFxutGl/TFo/HG9vXUUuOa6MvtX1EYGWzEiRvGkFz7E6h8ynpOEHIEqomd2jC2fgMHNtSSyPoHu38QPb7M4iFBZTWqBUJ3PkiPKfEx0+kWOVUJYS5MZBT2uyMRhAKWrLpRzw2EePxn7uBP8DWQzurSPZTc18cqSBQnT3/4OM9K4QJeYHmqGlBh0suiVIzPXCYtBfpTALZe/sf7+SQVrThMYLMWJCz3ohrS+Vzd7U5Yqv75BeR2Lu4lhjhkTPCKuvN93mdjV4j4rrHiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D/tqUZ8DclLQY6J1jbsoyCI+16ygZTKBiDCAKLhdM2k=; b=h1WRpYhcOFgSnfsBsx+5LxwXSwd1H4SszrN0aSfcfQKDsYjQaNwaLrf/5xT7GjF56JejPeI2E4W9BNAvw/oKPEx/JgxhM61maESlivIgB1UojqtcNqzewKJLQSFyjqe/uk7zic+0Gxwx8vuHUJ7btxB9PqChpoCreZiB9xv++RiTIWb3vky+x1SehQci6w7zLhXAFc2yQRJBRiD00ga9BGaJX41qbaDao2f2nHLWfqHn3veWltejoYn18Uxodi+NQcugaLdYLqxtn/ogmkDON18vnPX34AojtrCBVNvP+aE7RDKng8lobQTKxDW7sjLhAxde4ow+WGTanXW2IqP7Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D/tqUZ8DclLQY6J1jbsoyCI+16ygZTKBiDCAKLhdM2k=; b=pYmI5kLfocx6iMZzQHQYvSS27b0fS2HZzKiLiu2pkrZ39i3UCaUW9jT3tQtIcO7MwbF5Z78BzRRQq8n5p+JmWbkUE9Kmt0kgsIZKb4nLGInZgcKfsm7VAWLgyaBWLdEm6erluU+vJFHrQ6FHuWtuW5sQUY6ftnrSu9B06CI8HNo= From: Edwin Torok To: Julien Grall CC: Xen-devel , Henry Wang , Christian Lindig , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Index: AQHY84fA+Ym2JRve3kKJcIO1APAKeK41MEgAgAAQaICAAAaygIAAAw6A Date: Tue, 8 Nov 2022 17:37:29 +0000 Message-ID: <7BD7C0AF-0D72-4125-BE97-8AD5FC15CA93@citrix.com> References: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> <1f8c90cd-8037-84eb-d6f7-c639f8a87585@xen.org> In-Reply-To: <1f8c90cd-8037-84eb-d6f7-c639f8a87585@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|SA0PR03MB5626:EE_ x-ms-office365-filtering-correlation-id: f68bb6ce-d2c1-4091-0d85-08dac1afe90e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8oUddBTNNcwIwmeQq/aVfJ8jhe340sRW9pznsZQ5T9q7c8BMOlnFokl9MzNyoHf1QVLxzsL5xJE4P5zjQf2nfbn6rUMjtboIqNSjkDNLaOSJqrOG/QwCyJxC2G4EKBdHfrBtnqMBjIxvXUH2r4uhcmxtoxH1EpkX+h+4uY0Y3N/ovvYgB3PCukaKZNsAvUfZn/+gdYiYRKUpemPQyfZ6t6/upWOACge1akbAb5kCJEhkWKO4uzFURHYO7opcpW3t0nx9SRSR6youXuRs3UK11kch5IE5KS6/jXkY3qMqfuo3iNpSoHuwkIIpeObbshnezDJjODG0glz8aW7gLiGd14Wcy47q4ve+k6zDsY6x+avGF+KOoUZwwa+iDU20SXbAwe9zLmGN4EWzzOQOUvGO2qZ/bQm3MqLLBT8wjnm54gukA8ImMW01ecQiFzmMeytM54Csad5puCOGFf0hmzB6gYPZKhcwg7grGCTMic8SrLbURls6MpahPIB4n+A5IfOk0Vpgx+QiMXedX0At37SvXuvQn+PwN+O5IrBe4tfo+E7/yEicjEdqLrsikbqKbR3GUA+6t2BYKOSLk6njy7a3DPiuy2fAfZX5QzqqaNIFYU/g6gvIsGY7u51mkXiNbD8jcgB++2x7mAwvTDlFw0LESkybcHrcRI/cB0REDBeM4/XI94Dnn9eK445T9hHRl88GNdlvmq8wLLtsuQsMF802pWqB8Yje7WzEsLxGE1p3CiCucBEFxxeySn+cXJ352i/EqBiukdoRsSpuWUKllBj6rALtOmiVchoMKeR6xr8kwDI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(366004)(346002)(39860400002)(451199015)(2616005)(83380400001)(26005)(66574015)(122000001)(107886003)(6916009)(38100700002)(186003)(6512007)(2906002)(53546011)(6506007)(8936002)(66446008)(41300700001)(5660300002)(64756008)(478600001)(54906003)(8676002)(4326008)(66556008)(76116006)(6486002)(66476007)(316002)(66946007)(71200400001)(91956017)(45080400002)(38070700005)(36756003)(82960400001)(86362001)(33656002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?V3VQdHZxRTJNUW9HT1dmbUwyemVGcWVEMzkwL3kvRWxtRW1kQnhxRWFlcFM5?= =?utf-8?B?L0grMlk3ZmFJRDZ3b0lOTEVFcnFtYUp3eGpJWStVK2plZE16ZTk0R2FUZjEv?= =?utf-8?B?eGR4WVFnSitvOUczZ0JBdm5BdmJNekh5WDlHUnpSWGFlWG9zeEdjZlVndkNv?= =?utf-8?B?ZUNyb1lOUVB6M2F3RzFqdEcwL0dUZVFxNDZ4ZnZvUUhJc0prbE9XZUFNQTFX?= =?utf-8?B?UC9nUnhBT0Vrd3RabTR2VU9aUHBYSUxRcDE3RTBlOHFGTm5xbmVXT1Q4bVNZ?= =?utf-8?B?US9QTE0xZWlkOEpRc2FHYWZJNGNxTXVQcWVDd053WEczNWk4VmQzK0ljTkph?= =?utf-8?B?Z1VZVUlwLzRoMVRDZ0Q1V0cxMXhQbWZsMHNPM013NXJFZUJ1OUhWeThEZkVV?= =?utf-8?B?QUlaOXlOQ3lmeG1xbWY2eE9jOG5LSmRSU1Vid1BsTElOTDBKVTZSMVhmZXpw?= =?utf-8?B?T0xyT3Nsbnd6TjltVDhkQ3N2azhQVzRmUFZnbGUybk04MTRnRmR1cVB3U0oz?= =?utf-8?B?MDcvUWZlTUExa29jd0xwUHRrU2toWi8vRWlHSTAzTEF0VytNN3VkYm5MZnFh?= =?utf-8?B?eWlKVS9iTmV1SlhoVU5ldGI1NldqOHJKaGZpT0pWaFhVZDRFbU50QlhpZzl4?= =?utf-8?B?MDR4cCtOMjRkckZaeHhkSXMvNHRHRSs1TXljS1FvOFNtOVlmaFJHTDUxT1Ro?= =?utf-8?B?UDlWTjlRR3ZsUlNhb1lrMjEvZEdGcWZhNmVaUzB4akp3b2hjNUVkcUIrSWxy?= =?utf-8?B?WllJd01UaVdLVHpQR3Rvb0JXTmw0WngzblZXZEdPM1E1aGNkd2FDSWtBZkxw?= =?utf-8?B?KzZtZ1lTZ1ZVd0JTV3FYc0tINEd0ZzZiYUxjL25QTStKS3ZPY0NDdUs4Lyth?= =?utf-8?B?SHJCSjJ5ZkpsYUpoazJvNjd3aTl1enczeDRZUlJaT2F6bUlsZ1FqaDMyNytJ?= =?utf-8?B?K2tCOEFTd09jdVFFMmJYakUzOGlPdlMxM0pjOFhOVmZjTkJybEdLb3Y4ODYr?= =?utf-8?B?cnVmcS9abG9HTkhQeXNzY012cGdTcGQ1UWVaeFFmeVZhUm1VV1lxU0ppbU5Q?= =?utf-8?B?T0x6ZHl4SEVvbVBPaEtwdWl5eXZ6ZVpZSTUyYWdyTEFvZGZ2dVBkNFd4N0VI?= =?utf-8?B?YXhlOXNob1lnMW1BTCtYNEhROTR4ZkNlVG1yZmkwdVlqTUZrelplTWdxTUUx?= =?utf-8?B?UFlBc3BVSmlyZlg5N2laSDZPLzNJNTJDNGtiRG5qeFYzY2VIUE4wUFNiZnhQ?= =?utf-8?B?MkZZbnU4aElnbk9QSGFQS3l1TytKaytnUnBrVmhHNnVuWVB0eUNSYjRrQ0Vl?= =?utf-8?B?ZFZYVnVhSzZBMVlReHZGZHJ4NnVHdnM0U2lDVDNIdGVtQUZJWUU0T0tuc3Ew?= =?utf-8?B?TGsrWkhySGNSN0c0MXlTQjRrQUNzNnRvcWc3Q2R2QU5uUjdFV0J0K3NjaFNW?= =?utf-8?B?S252ODdFclpwV0N1Nm50bk9aTTU0VHhENmFvUDZ0cnBIaHlyS2o3ZWlLYUVQ?= =?utf-8?B?MzVIdFhacGhIc0hOOTZtbkVkMmhYWDdCbHY4Skw4WnBhc0YwUnFvUnZ6V0NO?= =?utf-8?B?dEt3SnltNzVuZ255bHFjd3dRaE1DUzVpajQ1UU40WUlGQVVyWk5uOHpWc2JU?= =?utf-8?B?YXFLZUVPL1JjNnFqRTBmMFEyM2FkRnJSdkpxWHRad1grR09zK2VKL3dBdVVE?= =?utf-8?B?UjRmMyt4MGx0TUE2dE9DWkRtNnpQZCtBVUtmaUQ3NHE2Q1B1RGU5RDgwbldj?= =?utf-8?B?L0RqakxwNkNtRkpBeGRmejlMZ0dVNndFNGJEWnBWa3JYajZyL3ZhNGVsL2VT?= =?utf-8?B?K2doaC84bXJsUkVHQkphLzBkT3lDbEU2bEtydGkvaVlLVUM2MHNhOXZmLzlK?= =?utf-8?B?REkwUEIrVkwvQ3liWTJCSnhEbmZGcjZYdm9xKzJyaGFtY1RGRjAyRjBhY0I0?= =?utf-8?B?MGQ2Wnp6aEVJWDRRYWxuTXBzcnpka1JnTUdzWlMvWmdQaVpGSkNWUWt4ZHdu?= =?utf-8?B?Y3pvZ25memhuNTJZekpGd05qYURHVTdTMy9ZUmxvTUNpRk5JY0VpOHU2YzBT?= =?utf-8?B?Z1lPTURFaStmKzRzWXBPVzlQUlJhUDBaS2REeDdWczA0Y2wrMlgydnB0RlhW?= =?utf-8?B?UE9pL1ZFVGVtUWFXR25VYStaV1RtYTBFOCtoRGpsb3JmemI1aE15RnBycHpP?= =?utf-8?B?cUE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f68bb6ce-d2c1-4091-0d85-08dac1afe90e X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2022 17:37:29.9483 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NiVakPaODMgOPy9CG2CtEWIyyGPE2ohPvjJurEJHmNfwo56/sW7ZhZ7jJy6FGMKWKqFy3a9mbWUrPE7Zepfmmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5626 DQoNCj4gT24gOCBOb3YgMjAyMiwgYXQgMTc6MjYsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5v cmc+IHdyb3RlOg0KPiANCj4gDQo+IA0KPiBPbiAwOC8xMS8yMDIyIDE3OjAyLCBFZHdpbiBUb3Jv ayB3cm90ZToNCj4+PiBPbiA4IE5vdiAyMDIyLCBhdCAxNjowMywgSnVsaWVuIEdyYWxsIDxqdWxp ZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4gDQo+Pj4gSGksDQo+Pj4gDQo+Pj4gT24gMDgvMTEvMjAy MiAxNTozMywgRWR3aW4gVMO2csO2ayB3cm90ZToNCj4+Pj4gU2VlIENPRElOR19TVFlMRTogWGVu IHVzZXMgc3BhY2VzLCBub3QgdGFicy4NCj4+Pj4gKiBPQ2FtbCBjb2RlOg0KPj4+PiBVc2luZyBg b2NwLWluZGVudGAgZm9yIG5vdyB0byBqdXN0IG1ha2UgbWluaW1hbCBtb2RpZmljYXRpb25zIGlu DQo+Pj4+IHRhYnMgdnMgc3BhY2VzIGFuZCBnZXQgdGhlIHJpZ2h0IGluZGVudGF0aW9uLg0KPj4+ PiBXZSBjYW4gaW50cm9kdWNlIGBvY2FtbGZvcm1hdGAgbGF0ZXIuDQo+Pj4+ICogQyBzdHViczoN Cj4+Pj4ganVzdCByZXBsYWNlIHRhYnMgd2l0aCBzcGFjZXMgbm93LCB1c2luZyBgaW5kZW50YCBv ciBgY2xhbmctZm9ybWF0YA0KPj4+PiB3b3VsZCBjaGFuZ2UgY29kZSB0b28gbXVjaCBmb3IgNC4x Ny4NCj4+Pj4gVGhpcyBhdm9pZHMgcGVycGV0dWF0aW5nIGEgZm9ybWF0dGluZyBzdHlsZSB0aGF0 IGlzIGluY29uc2lzdGVudCB3aXRoDQo+Pj4+IHRoZSByZXN0IG9mIFhlbiwgYW5kIHRoYXQgbWFr ZXMgcHJlcGFyaW5nIGFuZCBzdWJtaXR0aW5nIHBhdGNoZXMgbW9yZQ0KPj4+PiBkaWZmaWN1bHQg KE9DYW1sIGluZGVudGF0aW9uIHRvb2xzIHVzdWFsbHkgb25seSBzdXBwb3J0IHNwYWNlcywgbm90 IHRhYnMpLg0KPj4+PiBDb250YWlucyBhIGJ1Z2ZpeCBmb3IgYGFiaS1jaGVja2Agc2NyaXB0IHRv IGhhbmRsZSB0aGUgY2hhbmdlIGluIHRoZQ0KPj4+PiBhbW91bnQgb2Ygd2hpdGVzcGFjZS4NCj4+ Pj4gTm8gZnVuY3Rpb25hbCBjaGFuZ2UuDQo+Pj4+IFNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLD tmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+DQo+Pj4+IC0tDQo+Pj4+IFJlYXNvbiBmb3IgaW5j bHVzaW9uIGluIDQuMTc6DQo+Pj4+IC0gbWFrZXMgaXQgZWFzaWVyIHRvIGJhY2twb3J0IGNoYW5n ZXMgZnJvbSBtYXN0ZXIgdG8gNC4xNw0KPj4+IA0KPj4+IFJpZ2h0LCBidXQgeW91IHdpbGwgaGF2 ZSB0aGUgcHJvYmxlbSB3aGVuIGJhY2twb3J0aW5nIHRvIDQuMTYgYW5kIG9sZGVyLiBTbyB0aGUg b3ZlcmhlYWQgd2lsbCBhbHdheXMgYmUgdGhlcmUgZm9yIGEgY291cGxlIG9mIHllYXJzLg0KPj4g VGhlcmUgd2lsbCBhbHdheXMgYmUgbW9yZSB0aGFuIG9uZSBYZW4gcmVsZWFzZSBpbiBzdXBwb3J0 LCB3aGljaCBtZWFucyB3ZSdkIG5ldmVyIGJlIGFibGUgdG8gZml4IHRoaXMuDQo+IA0KPiBOb3Rl IHRoYXQgSSBoYXZlbid0IHNhaWQgdGhpcyBzaG91bGQgbmV2ZXIgYmUgZG9uZS4gVGhpcyBqdXN0 IG5lZWQgdG8gYmUgY29ycmVjdGx5IHRpbWVkLiBEb2luZyBpdCBpbiB0aGUgbWlkZGxlIG9mIGEg ZGVlcCBmcmVlemUgZG9lc24ndCBsb29rIHJpZ2h0IHRvIG1lLg0KPiANCj4gWy4uLl0NCj4gDQo+ Pj4+IC0gYXZvaWQgcGVycGV0dWF0aW5nIGEgZGlmZmVyZW50IGNvZGluZyBzdHlsZSAoSSB0aG91 Z2h0IHRhYnMgd2VyZQ0KPj4+PiAgIG1hbmRhdGVkIGJ5IFhlbiwgYW5kIHdhcyBhYm91dCB0byBm aXggdXAgbXkgZWRpdG9yIGNvbmZpZyB0byBtYXRjaA0KPj4+PiAgIHdoZW4gSSByZWFsaXplZCBY ZW4gYWxyZWFkeSBtYW5kYXRlcyB0aGUgdXNlIG9mIHNwYWNlcykNCj4+Pj4gLSBzaG91bGQgbWFr ZSBzdWJtaXR0aW5nIHBhdGNoZXMgZm9yIE9DYW1sIGVhc2llciAoT0NhbWwgaW5kZW50YXRpb24N Cj4+Pj4gICB0b29scyBrbm93IG9ubHkgYWJvdXQgc3BhY2VzLCBzbyBJIGVpdGhlciBjYW4ndCB1 c2UgdGhlbSwgb3IgaGF2ZSB0bw0KPj4+PiAgIG1hbnVhbGx5IGFkanVzdCBpbmRlbnRhdGlvbiBl dmVyeSB0aW1lIEkgc3VibWl0IGEgcGF0Y2gpDQo+Pj4+IC0gaXQgY2FuIGJlIHZlcmlmaWVkIHRo YXQgdGhlIG9ubHkgY2hhbmdlIGhlcmUgaXMgdGhlIE1ha2VmaWxlIGNoYW5nZQ0KPj4+PiAgIGZv ciB0aGUgbmV3IHJ1bGUsICdnaXQgbG9nIC1wIC0xIC13JyBzaG91bGQgYmUgb3RoZXJ3aXNlIGVt cHR5DQo+Pj4gDQo+Pj4gV2hpbGUgSSB1bmRlcnN0YW5kIHRoZSBnb2FsIGFuZCBzdXBwb3J0LCB0 aGlzIHNlZW1zIHRvIGJlIGEgYml0IHRvbyBsYXRlIHRvIGRvIGl0IGluIFhlbiA0LjE3ICh3ZSBh cmUgb25seSBhIGNvdXBsZSBvZiB3ZWVrcyBhd2F5KS4gQXQgdGhpcyBzdGFnZSBvZiB0aGUgcmVs ZWFzZSB3ZSBzaG91bGQgb25seSBkbyBidWcgZml4Lg0KPj4gSSB0aGluayBpdCBjYW4gYmUgZmFp cmx5IGVhc2lseSBwcm92ZW4gdGhhdCB0aGVyZSBpcyBubyBmdW5jdGlvbmFsIGNoYW5nZSBieSBy ZXJ1bm5pbmcgdGhlIG1ha2UgZm9ybWF0IGNvbW1hbmQgbWFudWFsbHksIGFuZCBieSBsb29raW5n IGF0IHRoZSBkaWZmIHdpdGggaWdub3JlIHdoaXRlc3BhY2UgYXMgc3VnZ2VzdGVkIGFib3ZlLg0K PiANCj4gVGhhdCdzIG5vdCByZWFsbHkgdGhlIHBvaW50IGhlcmUuIFRoZSBwb2ludCBpcyB0aGF0 IGlmIHdlIHN0YXJ0IHRvIGFsbG93IGxhcmdlIGNvZGluZyBzdHlsZSBjaGFuZ2UgKHdoZXRoZXIg YXV0b21hdGljIG9yIG1hbnVhbCkgdmVyeSBsYXRlIGluIHRoZSByZWxlYXNlIHRoZW4gaXQgd2ls bCBiZSBoYXJkIHRvIHJlamVjdCBpdCBpbiB0aGUgZnV0dXJlLg0KPiANCj4gSW4gZmFjdCB3ZSBh bHJlYWR5IGhhdmUgZ3VpZGVsaW5lcyBmb3IgdGhhdC4gSWYgeW91IGxvb2sgYXQgWzFdLCBvbmx5 IGJ1ZyBmaXhlcyBzaG91bGQgYmUgZG9uZSBwYXN0IHRoZSBjb2RlIGZyZWV6ZSAoMjNyZCBTZXB0 ZW1iZXIpLg0KPiANCj4gQXMgSSB3cm90ZSBiZWZvcmUsIHRoaXMgcGF0Y2ggb25seSBzZWVtIHRv IGJlIGEgY29zbWV0aWMvcXVhbGl0eSBpbXByb3ZlbWVudC4gSU9XIHRoaXMgaXMgbm90IGEgYnVn IGZpeCBhbmQgd291bGQgbm90IHF1YWxpZnkgZm9yIDQuMTcuDQo+IA0KPj4gSSB1bmRlcnN0YW5k IHRoZSByZWx1Y3RhbmNlIGluIGluY2x1ZGluZyBpdCAod2hpY2ggaXMgd2h5IEkgd2FzIG5vdCBz dXJlIHdoZXRoZXIgdG8gcG9zdCBpdCBpbiB0aGUgZmlyc3QgcGxhY2UpLCBidXQgSSB0aGluayBp dCBtaWdodCBiZSBiZW5lZmljaWFsIHRvIGRvIGl0Lg0KPj4gVGhlcmUgaXMgYSBsYXJnZSBiYWNr bG9nIG9mIHdvcmsgaW4gb3hlbnN0b3JlZCB0aGF0IGdvdCBwaWxlZCB1cCBkdXJpbmcgdGhlIHBh c3QgY291cGxlIG9mIHllYXJzIG9mIFhTQSB3b3JrLCBhbmQgaXQnZCBiZSBhIGxvdCBlYXNpZXIg dG8gdXBkYXRlIGFuZCB1cHN0cmVhbSB0aG9zZSBpZiB3ZSB3b3VsZG4ndCBoYXZlIHRvIHdvcnJ5 DQo+PiBhYm91dCBpbmRlbnRhdGlvbiBhdCBhbGwuDQo+IA0KPiBUaGlzIGlzIGFuIGFyZ3VtZW50 IGZvciBpbmNsdWRpbmcgdGhpcyBwYXRjaCBpbiBYZW4gNC4xOC4gQXMgSSB3cm90ZSBhYm92ZSwg SSBhbSBub3QgYWdhaW5zdCB0aGF0Lg0KPiANCj4+IFVzdWFsbHkgcGF0Y2hlcyBvbiBMQ00gYW5k IHNlY3VyaXR5IGJyYW5jaGVzIGFyZSBhdm9pZGVkIHRvIHJlZHVjZSB0aGUgcmlzayBvZiBicmVh a2luZyBhbnl0aGluZywgYnV0IGEgcmVpbmRlbnRhdGlvbiBwYXRjaCBzaG91bGQgbm90IHJlYWxs eSBicmVhayBhbnl0aGluZyAod2VsbCBvdGhlciB0aGFuIHRoZSBhYmktY2hlY2sgc2NyaXB0IGlu IHRoZSBidWlsZCwgYnV0IEkgZml4ZWQgdGhhdCB0byBhY2NlcHQgYm90aCB3YXlzKS4NCj4gDQo+ IFdoYXQgZG9lcyBMQ00gc3RhbmRzIGZvcj8NCg0KTENNIGlzIHdoYXQgd2UgaW50ZXJuYWxseSBj YWxsIHRoZSBsb25nIHRlcm0gcmVsZWFzZSBicmFuY2ggd2hlcmUgd2UgYmFja3BvcnQgZml4ZXMg KGkuZS4gNC4xNiBpcyBhbiBMQ00gYnJhbmNoIGFmdGVyIGl0IGlzIHJlbGVhc2VkKS4gSSB0aGlu ayBpdCdkIGJlIGVxdWl2YWxlbnQgdG8gdGhlIHN0YWJsZSBicmFuY2ggb2YgWGVuL0xpbnV4LCBJ IHNob3VsZCd2ZSB1c2VkIHRoYXQgdGVybWlub2xvZ3kuIChJIHRoaW5rIGl0IGlzIGFuIGFiYnJl dmlhdGlvbiBvZiBzb2Z0d2FyZSBsaWZlY3ljbGUgbWFuYWdlbWVudCkNCg0KPiANCj4+IE9uZSBh bHRlcm5hdGl2ZSB3b3VsZCBiZSB0aGF0IEkgYWRkIGFub3RoZXIgc3RlcCBhZnRlciByZWZvcm1h dCB0aGF0IHJ1bnMgc2VkIGFuZCB0dXJucyBzcGFjZXMgYmFjayBpbnRvIHRhYnMgZm9yIG5vdywg YW5kIHRoYXQgd2F5IEkgY2FuIHN0aWxsIHJ1biAnbWFrZSBmb3JtYXQnIGF0IGVhY2ggc3RlcCB3 aGlsZSBwcmVwYXJpbmcgcGF0Y2hlcyBmb3IgbWFzdGVyLCBvciA0LjE3IG9yIHNlY3VyaXR5IHBh dGNoZXMgYW5kIGdldCBzb21ldGhpbmcgY29uc2lzdGVudCwgYW5kIHRoYXQgbWluaW1pemVzIG90 aGVyIHdoaXRlc3BhY2UgY2hhbmdlcywgYnV0IGl0IHdvdWxkbid0IGNvbXBsZXRlbHkgZWxpbWlu YXRlIHRoZW0gKGUuZy4gdGhlcmUgYXJlIHBpZWNlcyBvZiBjb2RlIHRoYXQgYXJlIGp1c3Qgd3Jv bmdseSBpbmRlbnRlZCwgc28gdGhlcmUnZCBiZSBhdCBsZWFzdCBhIGRpZmYgdG8gZml4IGFsbCB0 aGF0KS4NCj4gDQo+IEkgd291bGQgdmlldyB0aGlzIGFzIGEgZmVhdHVyZS4gV2hpY2ggYWdhaW4g ZG9lc24ndCBxdWFsaWZ5IGZvciBYZW4gNC4xNyByZWxlYXNlLiBUaGlzIGRvZXNuJ3QgbWVhbiB0 aGUgcGF0Y2ggY291bGRuJ3QgYmUgYmFja3BvcnRlZCBhZnRlcndhcmRzLg0KDQoNCkFoIG9rLCBp ZiB0aGlzIGNhbiBiZSBiYWNrcG9ydGVkIHRvIDQuMTcuMSwgb3IgYXBwbGllZCBmb3IgNC4xOCB0 aGF0IG1pZ2h0IHdvcmsgdG9vLiAoSSBqdXN0IHRob3VnaHQgdGhlIHJ1bGVzIGFyb3VuZCBiYWNr cG9ydCB3b3VsZCBiZSBldmVuIHN0cmljdGVyIHRoYW4gd2hhdCBjYW4gZ28gaW50byBhIHJlbGVh c2UpDQpJJ2xsIHRyeSB0byBmaW5kIGEgc2hvcnQgdGVybSB3b3JrYXJvdW5kIGZvciB0aGUgc3Bh Y2VzIHZzIHRhYnMgaXNzdWVzIG1lYW53aGlsZS4NCg0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiBb MV0gQVM4UFIwOE1CNzk5MTE0NUM4MDYzRDY5MzlBRkZFRDhGOTI4MjlAQVM4UFIwOE1CNzk5MS5l dXJwcmQwOC5wcm9kLm91dGxvb2suY29tDQoNCg0KSG1tIEkgdGhvdWdodCB0aGF0IGlzIG15IE91 dGxvb2sgcmV3cml0aW5nIHRoZSBsaW5rLCBidXQgdGhlIGFyY2hpdmUgYXQgbG9yZS5rZXJuZWwu b3JnIHNlZW1zIHRvIGhhdmUgdGhpcyBtYW5nbGVkIFVSTCBhcyB3ZWxsIHdoaWNoIEkgY2Fubm90 IG9wZW4uDQpDb3VsZCB5b3Ugc2VuZCBpdCBpbiBzdWNoIGEgd2F5IHRoYXQgaXQgaXMgbm90IGVu Y29kZWQgd2hlbiBiZWluZyBzZW50IChlLmcuIGJhc2U2NCBlbmNvZGUgaXQuLi4pDQoNCj4gDQo+ PiBCZXN0IHJlZ2FyZHMsDQo+PiAtLUVkd2luDQo+Pj4gDQo+Pj4gQ2hlZXJzLA0KPj4+IA0KPj4+ IA0KPj4+IC0tIA0KPj4+IEp1bGllbiBHcmFsbA0KPiANCj4gLS0gDQo+IEp1bGllbiBHcmFsbA0K DQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 08 18:00:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 18:00:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440404.694622 (Exim 4.92) (envelope-from ) id 1osSto-0000fO-2y; Tue, 08 Nov 2022 18:00:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440404.694622; Tue, 08 Nov 2022 18:00:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osStn-0000e1-UA; Tue, 08 Nov 2022 18:00:35 +0000 Received: by outflank-mailman (input) for mailman id 440404; Tue, 08 Nov 2022 18:00:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osStm-0008L0-1S for xen-devel@lists.xen.org; Tue, 08 Nov 2022 18:00:34 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 39fbc1cb-5f8f-11ed-8fd1-01056ac49cbb; Tue, 08 Nov 2022 19:00:29 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osStV-00057l-0n; Tue, 08 Nov 2022 18:00:17 +0000 Received: from andrewcoop by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osStU-0004zo-V8; Tue, 08 Nov 2022 18:00:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39fbc1cb-5f8f-11ed-8fd1-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=iD091UYDNKS0gg7JR4FQKqsfkBNjPGh3Ei2jkq1O8J0=; b=jMH8QoCKqI2g0xuQaAKuBuaj2j RqIUE5xpbkeUze0ZNceM9+/1OYQMebdWzWlT+6epvojQ3hZcS8CclSSdemnBueWC6Yx+anLbVjZDm lXjVIogkdWC1e5irorItN0NZ+VyjMXX3ykmprJWMm71rY9FoCcqH6aydtRCIl1bZ2iSM=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 422 v1 (CVE-2022-23824) - x86: Multiple speculative security issues Message-Id: Date: Tue, 08 Nov 2022 18:00:16 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-23824 / XSA-422 x86: Multiple speculative security issues ISSUE DESCRIPTION ================= 1) Researchers have discovered that on some AMD CPUs, the implementation of IBPB (Indirect Branch Prediction Barrier) does not behave according to the specification. Specifically, IBPB fails to properly flush the RAS (Return Address Stack, also RSB - Return Stack Buffer - in Intel terminology; one of the hardware prediction structures), allowing attacker controlled values to survive across a deliberate attempt to purge said values. AMD have allocated CVE-2022-23824. For more details, see: https://www.amd.com/en/corporate/product-security/bulletin/amd-sb-1040 2) AMD have discovered that under some circumstances, the previous reported information about Branch Type Confusion (XSA-407 / CVE-2022-23825) was inaccurate. Specifically, it was previously reported that the small speculation window was not long enough to contain two dependent loads. It has turned out not to be true, and in some circumstances, the speculation window is long enough to contain two dependent loads. AMD have not allocated a new CVE for this issue. For more details, see: https://www.amd.com/en/corporate/product-security/bulletin/amd-sb-1044 IMPACT ====== An attacker might be able to infer the contents of memory belonging to other guests. Due to the interaction of this issue with previous speculation fixes in their default configuration, an attacker cannot leverage this vulnerability to infer the content of memory that belongs to Xen itself. VULNERABLE SYSTEMS ================== Systems running all versions of Xen are affected. Only AMD CPUs are potentially vulnerable. CPUs from other hardware vendors are not impacted. Whether a CPU is potentially vulnerable depends on its microarchitecture. Consult your hardware vendor. The fix for XSA-407 / CVE-2022-23825 elected, out of an abundance of caution, to use IBPB-on-entry as a Branch Type Confusion mitigation. It is believed that this mitigation is still sufficient, in light of the new discoveries. Therefore, no changes are being provided at this time. For CVE-2022-23824, patches are being provided on all releases as the bug pertains to a specific speculation control not working as documented, but there are a number circumstances where safety is provided as a side effect of other speculative mitigations. * The issue is that IBPB doesn't flush the RAS (Return Address Stack). Also called the RSB (Return Stack Buffer) in Intel terminology. Xen tends to follow Intel's terminology. * By default, Xen uses IBPB on a context switch from one vCPU to another vCPU to prevent guest to guest attacks. This action is not about protecting Xen from a malicious guest; such protections are elsewhere. * By default, Xen flushes the RAS/RSB on VMExit from HVM/PVH vCPUs, in order to protect itself from a malicious vCPU. Therefore, a malicious HVM/PVH guest cannot mount an attack using this vulnerability. * Whether Xen flushes the RAS/RSB by default on exit from PV vCPUs (again, to protect itself) is more complicated. There is an optimisation commonly used by native OSes when the SMEP (Supervisor Mode Execution Prevention) feature is active, which Xen can make use in some cases. - Xen 4.15 and older flush the RAS/RSB by default. - Xen 4.16 introduced an optimisation to skip flushing the RAS/RSB when safe. For CPUs impacted by CVE-2022-23824, this comes down to whether 32-bit PV guest support is enabled or not; *irrespective* of whether any 32-bit PV guests are actively running. If Xen is built with CONFIG_PV32=n, or Xen is booted with `pv=no-32`, or 32-bit PV guests are disabled as a side effect of CET being active (requires a capable toolchain, CONFIG_XEN_SHSTK=y or CONFIG_XEN_IBT=y, and capable hardware), then Xen will by default use the performance optimisation. In this case, a malicious 64-bit PV guest can mount an attack using this issue. Note: This analysis is only applicable for systems which are fully up to date with previous speculation-related XSAs, and have not used `spec-ctrl=` on the Xen command line to tune the speculative mitigations. MITIGATION ========== If there are untrusted 64-bit PV guests on the system on a Xen 4.16 or later system, specifying `spec-ctrl=rsb` on Xen's command line and rebooting will mitigate the vulnerability. RESOLUTION ========== Applying the appropriate set of patches resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa422/xsa422-?.patch xen-unstable xsa422/xsa422-4.16-?.patch Xen 4.16.x xsa422/xsa422-4.15-?.patch Xen 4.15.x xsa422/xsa422-4.14-?.patch Xen 4.14.x xsa422/xsa422-4.13-?.patch Xen 4.13.x $ sha256sum xsa422* xsa422*/* f8722655564736c69b708a24b524fec5d351aff4ea6cc5c87dff3629561945f2 xsa422.meta c6317d66e60ec8d3c5610646bf0f12f281f000706621804f3c6072d0772fa0bd xsa422/xsa422-1.patch aeec164f676ddef2e7736d733a43a239a4cd0005e82c763b0468259891691be9 xsa422/xsa422-2.patch 0e7603b0538914b675c891c4f1a8b4de19c9ae5b03d29c314d4484338a51e780 xsa422/xsa422-4.13-1.patch 5eefa1ce66b80bfb3ac4e14c99c39c73922f5508aad798aeeecdb9e0f25c3054 xsa422/xsa422-4.13-2.patch 2051142f1131452b5ca2166736866ddc1bf06910f063cdbc3997c89f31db2760 xsa422/xsa422-4.14-1.patch 821764468805547650ce3699ee37fd14083ea70958908d31905adf5ca32302ed xsa422/xsa422-4.14-2.patch 148ec57f7c4970c2d33891a8080ef643d76d1eafa9ca77ac45a1fc1416002cf8 xsa422/xsa422-4.15-1.patch 96e5d7243438bb16aa5b3528136c06f09f18e6ac4a52230d20f9db49a85922a0 xsa422/xsa422-4.15-2.patch f02b62f32d4910ecbe3946722a5f46d65db080e2007823c5bfa5c365d243e45f xsa422/xsa422-4.16-1.patch ba3547df8576433da0b5978e3def70d9804d2ed0847ad58914b78715868657c5 xsa422/xsa422-4.16-2.patch $ -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNqkxcMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZWTwIALjqWqJVggjnYtu7Kt/6xecsSZSyOu5HCMhGR2KL icyfYzVditOvjkXVXHfaWePbd/Xwos0c0rxzW1DrOih7UNPva7CFhXqrtwhuirJg Mu/mFv11R/T9+at8zQV6mR1WQXRsw9T/UrtMBQs4QJhbf81p/bbJX0rOxSZ/xxXR nyY6ASAcVJboGX9rs+ao0CB3PGZZ98hrhEXM2jTH+DH2xaUp1xSJQAARl8FRJRP6 sP1+x+PrPP314DkbFXdniPi76kOigTxEYFtQLOEEdamW1wtZRm8AKUzN76HRKNLt muYUcrXUD9EQpy/MoHwOGoE3IS9kXoVLzGq6BXWuor6PK7k= =y2fy -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa422.meta" Content-Disposition: attachment; filename="xsa422.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MjIsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICI0 ZDc1M2NjZjlkZGYxMjMzMjQzNWY1MGQ4OGU4Y2YwMTYxZTdhNWIzIiwKICAg ICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsK ICAgICAgICAgICAgInhzYTQyMi94c2E0MjItNC4xMy0/LnBhdGNoIgogICAg ICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE0Ijog ewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAg ICAgIlN0YWJsZVJlZiI6ICI2MjIyYmI4YmQ3NmEwZjIxMDQ4Yzg1MmFjZDI1 NDJmYTI0OTRhOTA3IiwKICAgICAgICAgICJQcmVyZXFzIjogW10sCiAgICAg ICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQyMi94c2E0MjIt NC4xNC0/LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQog ICAgfSwKICAgICI0LjE1IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAg ICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICJlODE4ZjRmMGRh YmY4M2E2MTM4Y2Q3N2Q3NDY0NDk1ZmFiN2JmYzE2IiwKICAgICAgICAgICJQ cmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAg ICAgInhzYTQyMi94c2E0MjItNC4xNS0/LnBhdGNoIgogICAgICAgICAgXQog ICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE2IjogewogICAgICAi UmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJs ZVJlZiI6ICIxYmRkN2M0MzhiMzk5ZTJlY2NlOWUzYzcyYmQ3YzFhZTU2ZGY2 MGY4IiwKICAgICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0 Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQyMi94c2E0MjItNC4xNi0/LnBh dGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAg ICJtYXN0ZXIiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4i OiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogImU2MWE3ODk4MTM2NDkyNWE0 M2M5Y2MyNGRjNzdiNjJmZjdiOTNjOWYiLAogICAgICAgICAgIlByZXJlcXMi OiBbXSwKICAgICAgICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNh NDIyL3hzYTQyMi0/LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAg ICAgfQogICAgfQogIH0KfQ== --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-1.patch" Content-Disposition: attachment; filename="xsa422/xsa422-1.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW51bWVyYXRpb24gZm9yIElC UEJfUkVUCgpUaGUgSUJQQl9SRVQgYml0IGluZGljYXRlcyB0aGF0IHRoZSBD UFUncyBpbXBsZW1lbnRhdGlvbiBvZiBNU1JfUFJFRF9DTUQuSUJQQgpkb2Vz IGZsdXNoIHRoZSBSU0IvUkFTIHRvby4KClRoaXMgaXMgcGFydCBvZiBYU0Et NDIyIC8gQ1ZFLTIwMjItMjM4MjQuCgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcg Q29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpBY2tlZC1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBh L3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYyBiL3Rvb2xzL2xpYnMv bGlnaHQvbGlieGxfY3B1aWQuYwppbmRleCBkNWE5YjM1Nzc0NmMuLjJhYTIz MjI1ZjQyYyAxMDA2NDQKLS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9j cHVpZC5jCisrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYwpA QCAtMjkxLDYgKzI5MSw3IEBAIGludCBsaWJ4bF9jcHVpZF9wYXJzZV9jb25m aWcobGlieGxfY3B1aWRfcG9saWN5X2xpc3QgKmNwdWlkLCBjb25zdCBjaGFy KiBzdHIpCiAgICAgICAgIHsic3NiLW5vIiwgICAgICAgMHg4MDAwMDAwOCwg TkEsIENQVUlEX1JFR19FQlgsIDI2LCAgMX0sCiAgICAgICAgIHsicHNmZCIs ICAgICAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDI4LCAg MX0sCiAgICAgICAgIHsiYnRjLW5vIiwgICAgICAgMHg4MDAwMDAwOCwgTkEs IENQVUlEX1JFR19FQlgsIDI5LCAgMX0sCisgICAgICAgIHsiaWJwYi1yZXQi LCAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDMwLCAgMX0s CiAKICAgICAgICAgeyJuYyIsICAgICAgICAgICAweDgwMDAwMDA4LCBOQSwg Q1BVSURfUkVHX0VDWCwgIDAsICA4fSwKICAgICAgICAgeyJhcGljaWRzaXpl IiwgICAweDgwMDAwMDA4LCBOQSwgQ1BVSURfUkVHX0VDWCwgMTIsICA0fSwK ZGlmZiAtLWdpdCBhL3Rvb2xzL21pc2MveGVuLWNwdWlkLmMgYi90b29scy9t aXNjL3hlbi1jcHVpZC5jCmluZGV4IDM5MGFjMWRhZmVkMi4uZDU4MzNlOWNl ODc5IDEwMDY0NAotLS0gYS90b29scy9taXNjL3hlbi1jcHVpZC5jCisrKyBi L3Rvb2xzL21pc2MveGVuLWNwdWlkLmMKQEAgLTE2MSw2ICsxNjEsNyBAQCBz dGF0aWMgY29uc3QgY2hhciAqY29uc3Qgc3RyX2U4YlszMl0gPQogICAgIFsy NF0gPSAiYW1kLXNzYmQiLCAgICAgICAgIFsyNV0gPSAidmlydC1zc2JkIiwK ICAgICBbMjZdID0gInNzYi1ubyIsCiAgICAgWzI4XSA9ICJwc2ZkIiwgICAg ICAgICAgICAgWzI5XSA9ICJidGMtbm8iLAorICAgIFszMF0gPSAiaWJwYi1y ZXQiLAogfTsKIAogc3RhdGljIGNvbnN0IGNoYXIgKmNvbnN0IHN0cl83ZDBb MzJdID0KZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBi L3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwppbmRleCA0ZTUzMDU2NjI0YTgu LjBjMzUwM2M5Y2RmZSAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3NwZWNf Y3RybC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwpAQCAtNDIw LDcgKzQyMCw3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwcmludF9kZXRhaWxz KGVudW0gaW5kX3RodW5rIHRodW5rLCB1aW50NjRfdCBjYXBzKQogICAgICAq IEhhcmR3YXJlIHJlYWQtb25seSBpbmZvcm1hdGlvbiwgc3RhdGluZyBpbW11 bml0eSB0byBjZXJ0YWluIGlzc3Vlcywgb3IKICAgICAgKiBzdWdnZXN0aW9u cyBvZiB3aGljaCBtaXRpZ2F0aW9uIHRvIHVzZS4KICAgICAgKi8KLSAgICBw cmludGsoIiAgSGFyZHdhcmUgaGludHM6JXMlcyVzJXMlcyVzJXMlcyVzJXMl cyVzJXMlcyVzJXNcbiIsCisgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGhpbnRz OiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXNcbiIsCiAgICAg ICAgICAgIChjYXBzICYgQVJDSF9DQVBTX1JEQ0xfTk8pICAgICAgICAgICAg ICAgICAgICAgICAgPyAiIFJEQ0xfTk8iICAgICAgICA6ICIiLAogICAgICAg ICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19JQlJTX0FMTCkgICAgICAgICAgICAg ICAgICAgICAgID8gIiBJQlJTX0FMTCIgICAgICAgOiAiIiwKICAgICAgICAg ICAgKGNhcHMgJiBBUkNIX0NBUFNfUlNCQSkgICAgICAgICAgICAgICAgICAg ICAgICAgICA/ICIgUlNCQSIgICAgICAgICAgIDogIiIsCkBAIC00MzcsNyAr NDM3LDggQEAgc3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMoZW51 bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICAgICAg IChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX1NUSUJQX0FMV0FZ UykpICAgPyAiIFNUSUJQX0FMV0FZUyIgICA6ICIiLAogICAgICAgICAgICAo ZThiICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9JQlJTX0ZBU1QpKSAg ICAgID8gIiBJQlJTX0ZBU1QiICAgICAgOiAiIiwKICAgICAgICAgICAgKGU4 YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfSUJSU19TQU1FX01PREUp KSA/ICIgSUJSU19TQU1FX01PREUiIDogIiIsCi0gICAgICAgICAgIChlOGIg ICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0JUQ19OTykpICAgICAgICAg PyAiIEJUQ19OTyIgICAgICAgICA6ICIiKTsKKyAgICAgICAgICAgKGU4YiAg JiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfQlRDX05PKSkgICAgICAgICA/ ICIgQlRDX05PIiAgICAgICAgIDogIiIsCisgICAgICAgICAgIChlOGIgICYg Y3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0lCUEJfUkVUKSkgICAgICAgPyAi IElCUEJfUkVUIiAgICAgICA6ICIiKTsKIAogICAgIC8qIEhhcmR3YXJlIGZl YXR1cmVzIHdoaWNoIG5lZWQgZHJpdmluZyB0byBtaXRpZ2F0ZSBpc3N1ZXMu ICovCiAgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGZlYXR1cmVzOiVzJXMlcyVz JXMlcyVzJXMlcyVzJXMlc1xuIiwKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRl L3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmggYi94ZW4vaW5jbHVk ZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCmluZGV4IDQyZjQ4 YThhZTIyYy4uMDI2NzVlOWM3NTRkIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVk ZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCisrKyBiL3hlbi9p bmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmgKQEAgLTI2 OSw2ICsyNjksNyBAQCBYRU5fQ1BVRkVBVFVSRShWSVJUX1NTQkQsICAgICA4 KjMyKzI1KSAvKiEgIE1TUl9WSVJUX1NQRUNfQ1RSTC5TU0JEICovCiBYRU5f Q1BVRkVBVFVSRShTU0JfTk8sICAgICAgICA4KjMyKzI2KSAvKkEgIEhhcmR3 YXJlIG5vdCB2dWxuZXJhYmxlIHRvIFNTQiAqLwogWEVOX0NQVUZFQVRVUkUo UFNGRCwgICAgICAgICAgOCozMisyOCkgLypTICBNU1JfU1BFQ19DVFJMLlBT RkQgKi8KIFhFTl9DUFVGRUFUVVJFKEJUQ19OTywgICAgICAgIDgqMzIrMjkp IC8qQSAgSGFyZHdhcmUgbm90IHZ1bG5lcmFibGUgdG8gQnJhbmNoIFR5cGUg Q29uZnVzaW9uICovCitYRU5fQ1BVRkVBVFVSRShJQlBCX1JFVCwgICAgICA4 KjMyKzMwKSAvKkEgIElCUEIgY2xlYXJzIFJTQi9SQVMgdG9vLiAqLwogCiAv KiBJbnRlbC1kZWZpbmVkIENQVSBmZWF0dXJlcywgQ1BVSUQgbGV2ZWwgMHgw MDAwMDAwNzowLmVkeCwgd29yZCA5ICovCiBYRU5fQ1BVRkVBVFVSRShBVlg1 MTJfNFZOTklXLCA5KjMyKyAyKSAvKkEgIEFWWDUxMiBOZXVyYWwgTmV0d29y ayBJbnN0cnVjdGlvbnMgKi8K --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-2.patch" Content-Disposition: attachment; filename="xsa422/xsa422-2.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgSUJQQiBub3Qg Zmx1c2hpbmcgdGhlIFJTQi9SQVMKCkludHJvZHVjZSBzcGVjX2N0cmxfbmV3 X2d1ZXN0X2NvbnRleHQoKSB0byBlbmNhcHN1bGF0ZSBhbGwgbG9naWMgcGVy dGFpbmluZyB0bwp1c2luZyBNU1JfUFJFRF9DTUQgZm9yIGEgbmV3IGd1ZXN0 IGNvbnRleHQsIGV2ZW4gaWYgaXQgb25seSBoYXMgb25lIHVzZXIKcHJlc2Vu dGx5LgoKSW50cm9kdWNlIFg4Nl9CVUdfSUJQQl9OT19SRVQsIGFuZCB1c2Ug aXQgZXh0ZW5kIHNwZWNfY3RybF9uZXdfZ3Vlc3RfY29udGV4dCgpCndpdGgg YSBtYW51YWwgZml4dXAgZm9yIGhhcmR3YXJlIHdoaWNoIG1pcy1pbXBsZW1l bnRzIElCUEIuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQyMiAvIENWRS0yMDIy LTIzODI0LgoKU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEphbiBCZXVsaWNoIDxq YmV1bGljaEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv YXNtLW1hY3Jvcy5jIGIveGVuL2FyY2gveDg2L2FzbS1tYWNyb3MuYwppbmRl eCA3ZTUzNmIwZDgyZjUuLjg5MWQ4NmM3NjU1YyAxMDA2NDQKLS0tIGEveGVu L2FyY2gveDg2L2FzbS1tYWNyb3MuYworKysgYi94ZW4vYXJjaC94ODYvYXNt LW1hY3Jvcy5jCkBAIC0xLDIgKzEsMyBAQAogI2luY2x1ZGUgPGFzbS9hc20t ZGVmbnMuaD4KICNpbmNsdWRlIDxhc20vYWx0ZXJuYXRpdmUtYXNtLmg+Cisj aW5jbHVkZSA8YXNtL3NwZWNfY3RybF9hc20uaD4KZGlmZiAtLWdpdCBhL3hl bi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNoL3g4Ni9kb21haW4uYwpp bmRleCBjZTgyYzUwMmJiNWYuLjc5MTA3ZGFjNjkyMiAxMDA2NDQKLS0tIGEv eGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hlbi9hcmNoL3g4Ni9kb21h aW4uYwpAQCAtMjExNyw3ICsyMTE3LDcgQEAgdm9pZCBjb250ZXh0X3N3aXRj aChzdHJ1Y3QgdmNwdSAqcHJldiwgc3RydWN0IHZjcHUgKm5leHQpCiAgICAg ICAgICAgICAgKi8KICAgICAgICAgICAgIGlmICggKmxhc3RfaWQgIT0gbmV4 dF9pZCApCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgd3Jtc3Js KE1TUl9QUkVEX0NNRCwgUFJFRF9DTURfSUJQQik7CisgICAgICAgICAgICAg ICAgc3BlY19jdHJsX25ld19ndWVzdF9jb250ZXh0KCk7CiAgICAgICAgICAg ICAgICAgKmxhc3RfaWQgPSBuZXh0X2lkOwogICAgICAgICAgICAgfQogICAg ICAgICB9CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20v Y3B1ZmVhdHVyZXMuaCBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9jcHVm ZWF0dXJlcy5oCmluZGV4IDM4OTVkZTRmYWY4Zi4uYzY4Y2VkMWI4MjQ3IDEw MDY0NAotLS0gYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVhdHVy ZXMuaAorKysgYi94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVhdHVy ZXMuaApAQCAtNDksNiArNDksNyBAQCBYRU5fQ1BVRkVBVFVSRShJQlBCX0VO VFJZX0hWTSwgICAgWDg2X1NZTlRIKDI5KSkgLyogTVNSX1BSRURfQ01EIHVz ZWQgYnkgWGVuIGZvcgogI2RlZmluZSBYODZfQlVHX0ZQVV9QVFJTICAgICAg ICAgIFg4Nl9CVUcoIDApIC8qIChGKVh7U0FWRSxSU1RPUn0gZG9lc24ndCBz YXZlL3Jlc3RvcmUgRk9QL0ZJUC9GRFAuICovCiAjZGVmaW5lIFg4Nl9CVUdf TlVMTF9TRUcgICAgICAgICAgWDg2X0JVRyggMSkgLyogTlVMTC1pbmcgYSBz ZWxlY3RvciBwcmVzZXJ2ZXMgdGhlIGJhc2UgYW5kIGxpbWl0LiAqLwogI2Rl ZmluZSBYODZfQlVHX0NMRkxVU0hfTUZFTkNFICAgIFg4Nl9CVUcoIDIpIC8q IE1GRU5DRSBuZWVkZWQgdG8gc2VyaWFsaXNlIENMRkxVU0ggKi8KKyNkZWZp bmUgWDg2X0JVR19JQlBCX05PX1JFVCAgICAgICBYODZfQlVHKCAzKSAvKiBJ QlBCIGRvZXNuJ3QgZmx1c2ggdGhlIFJTQi9SQVMgKi8KIAogLyogVG90YWwg bnVtYmVyIG9mIGNhcGFiaWxpdHkgd29yZHMsIGluYyBzeW50aCBhbmQgYnVn IHdvcmRzLiAqLwogI2RlZmluZSBOQ0FQSU5UUyAoRlNDQVBJTlRTICsgWDg2 X05SX1NZTlRIICsgWDg2X05SX0JVRykgLyogTiAzMi1iaXQgd29yZHMgd29y dGggb2YgaW5mbyAqLwpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2luY2x1 ZGUvYXNtL3NwZWNfY3RybC5oIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNt L3NwZWNfY3RybC5oCmluZGV4IDk0MDNiODFkYzdhZi4uNmE3N2MzOTM3ODQ0 IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vc3BlY19j dHJsLmgKKysrIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL3NwZWNfY3Ry bC5oCkBAIC02NSw2ICs2NSwyOCBAQAogdm9pZCBpbml0X3NwZWN1bGF0aW9u X21pdGlnYXRpb25zKHZvaWQpOwogdm9pZCBzcGVjX2N0cmxfaW5pdF9kb21h aW4oc3RydWN0IGRvbWFpbiAqZCk7CiAKKy8qCisgKiBTd2l0Y2ggdG8gYSBu ZXcgZ3Vlc3QgcHJlZGljdGlvbiBjb250ZXh0LgorICoKKyAqIFRoaXMgZmx1 c2hlcyBhbGwgaW5kaXJlY3QgYnJhbmNoIHByZWRpY3RvcnMgKEJUQiwgUlNC L1JBUyksIHNvIGd1ZXN0IGNvZGUKKyAqIHdoaWNoIGhhcyBwcmV2aW91c2x5 IHJ1biBvbiB0aGlzIENQVSBjYW4ndCBhdHRhY2sgc3Vic2VxdWVudCBndWVz dCBjb2RlLgorICoKKyAqIEFzIHRoaXMgZmx1c2hlcyB0aGUgUlNCL1JBUywg aXQgZGVzdHJveXMgdGhlIHByZWRpY3Rpb25zIG9mIHRoZSBjYWxsaW5nCisg KiBjb250ZXh0LiAgRm9yIGJlc3QgcGVyZm9ybWFjZSwgYXJyYW5nZSBmb3Ig dGhpcyB0byBiZSB1c2VkIHdoZW4gd2UncmUgZ29pbmcKKyAqIHRvIGp1bXAg b3V0IG9mIHRoZSBjdXJyZW50IGNvbnRleHQsIGUuZy4gd2l0aCByZXNldF9z dGFja19hbmRfanVtcCgpLgorICoKKyAqIEZvciBoYXJkd2FyZSB3aGljaCBt aXMtaW1wbGVtZW50cyBJQlBCLCBmaXggdXAgYnkgZmx1c2hpbmcgdGhlIFJT Qi9SQVMKKyAqIG1hbnVhbGx5LgorICovCitzdGF0aWMgYWx3YXlzX2lubGlu ZSB2b2lkIHNwZWNfY3RybF9uZXdfZ3Vlc3RfY29udGV4dCh2b2lkKQorewor ICAgIHdybXNybChNU1JfUFJFRF9DTUQsIFBSRURfQ01EX0lCUEIpOworCisg ICAgLyogKGFiKXVzZSBhbHRlcm5hdGl2ZV9pbnB1dCgpIHRvIHNwZWNpZnkg Y2xvYmJlcnMuICovCisgICAgYWx0ZXJuYXRpdmVfaW5wdXQoIiIsICJET19P VkVSV1JJVEVfUlNCIiwgWDg2X0JVR19JQlBCX05PX1JFVCwKKyAgICAgICAg ICAgICAgICAgICAgICA6ICJyYXgiLCAicmN4Iik7Cit9CisKIGV4dGVybiBp bnQ4X3Qgb3B0X2licGJfY3R4dF9zd2l0Y2g7CiBleHRlcm4gYm9vbCBvcHRf c3NiZDsKIGV4dGVybiBpbnQ4X3Qgb3B0X2VhZ2VyX2ZwdTsKZGlmZiAtLWdp dCBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBiL3hlbi9hcmNoL3g4Ni9z cGVjX2N0cmwuYwppbmRleCAwYzM1MDNjOWNkZmUuLmEwODM1MTQzZTM3YyAx MDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCisrKyBiL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwpAQCAtODExLDYgKzgxMSwxNCBAQCBz dGF0aWMgdm9pZCBfX2luaXQgaWJwYl9jYWxjdWxhdGlvbnModm9pZCkKICAg ICB9CiAKICAgICAvKgorICAgICAqIEFNRC9IeWdvbiBDUFVzIHRvIGRhdGUg KEp1bmUgMjAyMikgZG9uJ3QgZmx1c2ggdGhlIHRoZSBSQVMuICBGdXR1cmUK KyAgICAgKiBDUFVzIGFyZSBleHBlY3RlZCB0byBlbnVtZXJhdGUgSUJQQl9S RVQgd2hlbiB0aGlzIGhhcyBiZWVuIGZpeGVkLgorICAgICAqIFVudGlsIHRo ZW4sIGNvdmVyIHRoZSBkaWZmZXJlbmNlIHdpdGggdGhlIHNvZnR3YXJlIHNl cXVlbmNlLgorICAgICAqLworICAgIGlmICggYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX0lCUEIpICYmICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJQ Ql9SRVQpICkKKyAgICAgICAgc2V0dXBfZm9yY2VfY3B1X2NhcChYODZfQlVH X0lCUEJfTk9fUkVUKTsKKworICAgIC8qCiAgICAgICogSUJQQi1vbi1lbnRy eSBtaXRpZ2F0aW9ucyBmb3IgQnJhbmNoIFR5cGUgQ29uZnVzaW9uLgogICAg ICAqCiAgICAgICogSUJQQiAmJiAhQlRDX05PIHNlbGVjdHMgYWxsIEFNRC9I eWdvbiBoYXJkd2FyZSwgbm90IGtub3duIHRvIGJlIHNhZmUsCg== --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.13-1.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.13-1.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW51bWVyYXRpb24gZm9yIElC UEJfUkVUCgpUaGUgSUJQQl9SRVQgYml0IGluZGljYXRlcyB0aGF0IHRoZSBD UFUncyBpbXBsZW1lbnRhdGlvbiBvZiBNU1JfUFJFRF9DTUQuSUJQQgpkb2Vz IGZsdXNoIHRoZSBSU0IvUkFTIHRvby4KClRoaXMgaXMgcGFydCBvZiBYU0Et NDIyIC8gQ1ZFLTIwMjItMjM4MjQuCgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcg Q29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpBY2tlZC1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBh L3Rvb2xzL2xpYnhsL2xpYnhsX2NwdWlkLmMgYi90b29scy9saWJ4bC9saWJ4 bF9jcHVpZC5jCmluZGV4IDExYjQzODA3ZTk2NS4uNjk0ZTU1NGM5Njk2IDEw MDY0NAotLS0gYS90b29scy9saWJ4bC9saWJ4bF9jcHVpZC5jCisrKyBiL3Rv b2xzL2xpYnhsL2xpYnhsX2NwdWlkLmMKQEAgLTI3NSw2ICsyNzUsNyBAQCBp bnQgbGlieGxfY3B1aWRfcGFyc2VfY29uZmlnKGxpYnhsX2NwdWlkX3BvbGlj eV9saXN0ICpjcHVpZCwgY29uc3QgY2hhciogc3RyKQogICAgICAgICB7InNz Yi1ubyIsICAgICAgIDB4ODAwMDAwMDgsIE5BLCBDUFVJRF9SRUdfRUJYLCAy NiwgIDF9LAogICAgICAgICB7InBzZmQiLCAgICAgICAgIDB4ODAwMDAwMDgs IE5BLCBDUFVJRF9SRUdfRUJYLCAyOCwgIDF9LAogICAgICAgICB7ImJ0Yy1u byIsICAgICAgIDB4ODAwMDAwMDgsIE5BLCBDUFVJRF9SRUdfRUJYLCAyOSwg IDF9LAorICAgICAgICB7ImlicGItcmV0IiwgICAgIDB4ODAwMDAwMDgsIE5B LCBDUFVJRF9SRUdfRUJYLCAzMCwgIDF9LAogCiAgICAgICAgIHsibmMiLCAg ICAgICAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQ1gsICAwLCAg OH0sCiAgICAgICAgIHsiYXBpY2lkc2l6ZSIsICAgMHg4MDAwMDAwOCwgTkEs IENQVUlEX1JFR19FQ1gsIDEyLCAgNH0sCmRpZmYgLS1naXQgYS90b29scy9t aXNjL3hlbi1jcHVpZC5jIGIvdG9vbHMvbWlzYy94ZW4tY3B1aWQuYwppbmRl eCA1MmY1MDU5ZDhmN2MuLmQyYWRkNzVmNDNiYyAxMDA2NDQKLS0tIGEvdG9v bHMvbWlzYy94ZW4tY3B1aWQuYworKysgYi90b29scy9taXNjL3hlbi1jcHVp ZC5jCkBAIC0xNTcsNiArMTU3LDcgQEAgc3RhdGljIGNvbnN0IGNoYXIgKmNv bnN0IHN0cl9lOGJbMzJdID0KICAgICBbMjRdID0gImFtZC1zc2JkIiwgICAg ICAgICBbMjVdID0gInZpcnQtc3NiZCIsCiAgICAgWzI2XSA9ICJzc2Itbm8i LAogICAgIFsyOF0gPSAicHNmZCIsICAgICAgICAgICAgIFsyOV0gPSAiYnRj LW5vIiwKKyAgICBbMzBdID0gImlicGItcmV0IiwKIH07CiAKIHN0YXRpYyBj b25zdCBjaGFyICpjb25zdCBzdHJfN2QwWzMyXSA9CmRpZmYgLS1naXQgYS94 ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19j dHJsLmMKaW5kZXggYmZhNWQyN2UwMGY1Li4yM2JjODcwZDNjZmUgMTAwNjQ0 Ci0tLSBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJj aC94ODYvc3BlY19jdHJsLmMKQEAgLTQxOCw3ICs0MTgsNyBAQCBzdGF0aWMg dm9pZCBfX2luaXQgcHJpbnRfZGV0YWlscyhlbnVtIGluZF90aHVuayB0aHVu aywgdWludDY0X3QgY2FwcykKICAgICAgKiBIYXJkd2FyZSByZWFkLW9ubHkg aW5mb3JtYXRpb24sIHN0YXRpbmcgaW1tdW5pdHkgdG8gY2VydGFpbiBpc3N1 ZXMsIG9yCiAgICAgICogc3VnZ2VzdGlvbnMgb2Ygd2hpY2ggbWl0aWdhdGlv biB0byB1c2UuCiAgICAgICovCi0gICAgcHJpbnRrKCIgIEhhcmR3YXJlIGhp bnRzOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlc1xuIiwKKyAgICBw cmludGsoIiAgSGFyZHdhcmUgaGludHM6JXMlcyVzJXMlcyVzJXMlcyVzJXMl cyVzJXMlcyVzJXNcbiIsCiAgICAgICAgICAgIChjYXBzICYgQVJDSF9DQVBT X1JEQ0xfTk8pICAgICAgICAgICAgICAgICAgICAgICAgPyAiIFJEQ0xfTk8i ICAgICAgICA6ICIiLAogICAgICAgICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19J QlJTX0FMTCkgICAgICAgICAgICAgICAgICAgICAgID8gIiBJQlJTX0FMTCIg ICAgICAgOiAiIiwKICAgICAgICAgICAgKGNhcHMgJiBBUkNIX0NBUFNfUlNC QSkgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIgUlNCQSIgICAgICAg ICAgIDogIiIsCkBAIC00MzQsNyArNDM0LDggQEAgc3RhdGljIHZvaWQgX19p bml0IHByaW50X2RldGFpbHMoZW51bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2 NF90IGNhcHMpCiAgICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4 Nl9GRUFUVVJFX1NUSUJQX0FMV0FZUykpICAgPyAiIFNUSUJQX0FMV0FZUyIg ICA6ICIiLAogICAgICAgICAgICAoZThiICAmIGNwdWZlYXRfbWFzayhYODZf RkVBVFVSRV9JQlJTX0ZBU1QpKSAgICAgID8gIiBJQlJTX0ZBU1QiICAgICAg OiAiIiwKICAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZF QVRVUkVfSUJSU19TQU1FX01PREUpKSA/ICIgSUJSU19TQU1FX01PREUiIDog IiIsCi0gICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFU VVJFX0JUQ19OTykpICAgICAgICAgPyAiIEJUQ19OTyIgICAgICAgICA6ICIi KTsKKyAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRV UkVfQlRDX05PKSkgICAgICAgICA/ICIgQlRDX05PIiAgICAgICAgIDogIiIs CisgICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJF X0lCUEJfUkVUKSkgICAgICAgPyAiIElCUEJfUkVUIiAgICAgICA6ICIiKTsK IAogICAgIC8qIEhhcmR3YXJlIGZlYXR1cmVzIHdoaWNoIG5lZWQgZHJpdmlu ZyB0byBtaXRpZ2F0ZSBpc3N1ZXMuICovCiAgICAgcHJpbnRrKCIgIEhhcmR3 YXJlIGZlYXR1cmVzOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlc1xuIiwKZGlm ZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0 dXJlc2V0LmggYi94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVh dHVyZXNldC5oCmluZGV4IDQ0YjNiYTMzMWZiNy4uZGRjZmE1ZTgwNzQ0IDEw MDY0NAotLS0gYS94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVh dHVyZXNldC5oCisrKyBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9j cHVmZWF0dXJlc2V0LmgKQEAgLTI1OSw2ICsyNTksNyBAQCBYRU5fQ1BVRkVB VFVSRShWSVJUX1NTQkQsICAgICA4KjMyKzI1KSAvKiAgIE1TUl9WSVJUX1NQ RUNfQ1RSTC5TU0JEICovCiBYRU5fQ1BVRkVBVFVSRShTU0JfTk8sICAgICAg ICA4KjMyKzI2KSAvKiAgIEhhcmR3YXJlIG5vdCB2dWxuZXJhYmxlIHRvIFNT QiAqLwogWEVOX0NQVUZFQVRVUkUoUFNGRCwgICAgICAgICAgOCozMisyOCkg LyogICBNU1JfU1BFQ19DVFJMLlBTRkQgKi8KIFhFTl9DUFVGRUFUVVJFKEJU Q19OTywgICAgICAgIDgqMzIrMjkpIC8qQSAgSGFyZHdhcmUgbm90IHZ1bG5l cmFibGUgdG8gQnJhbmNoIFR5cGUgQ29uZnVzaW9uICovCitYRU5fQ1BVRkVB VFVSRShJQlBCX1JFVCwgICAgICA4KjMyKzMwKSAvKkEgIElCUEIgY2xlYXJz IFJTQi9SQVMgdG9vLiAqLwogCiAvKiBJbnRlbC1kZWZpbmVkIENQVSBmZWF0 dXJlcywgQ1BVSUQgbGV2ZWwgMHgwMDAwMDAwNzowLmVkeCwgd29yZCA5ICov CiBYRU5fQ1BVRkVBVFVSRShBVlg1MTJfNFZOTklXLCA5KjMyKyAyKSAvKkEg IEFWWDUxMiBOZXVyYWwgTmV0d29yayBJbnN0cnVjdGlvbnMgKi8K --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.13-2.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.13-2.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgSUJQQiBub3Qg Zmx1c2hpbmcgdGhlIFJTQi9SQVMKCkludHJvZHVjZSBzcGVjX2N0cmxfbmV3 X2d1ZXN0X2NvbnRleHQoKSB0byBlbmNhcHN1bGF0ZSBhbGwgbG9naWMgcGVy dGFpbmluZyB0bwp1c2luZyBNU1JfUFJFRF9DTUQgZm9yIGEgbmV3IGd1ZXN0 IGNvbnRleHQsIGV2ZW4gaWYgaXQgb25seSBoYXMgb25lIHVzZXIKcHJlc2Vu dGx5LgoKSW50cm9kdWNlIFg4Nl9CVUdfSUJQQl9OT19SRVQsIGFuZCB1c2Ug aXQgZXh0ZW5kIHNwZWNfY3RybF9uZXdfZ3Vlc3RfY29udGV4dCgpCndpdGgg YSBtYW51YWwgZml4dXAgZm9yIGhhcmR3YXJlIHdoaWNoIG1pcy1pbXBsZW1l bnRzIElCUEIuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQyMiAvIENWRS0yMDIy LTIzODI0LgoKU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEphbiBCZXVsaWNoIDxq YmV1bGljaEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv YXNtLW1hY3Jvcy5jIGIveGVuL2FyY2gveDg2L2FzbS1tYWNyb3MuYwppbmRl eCBiOTYzZDU2YTU2NjMuLjhjNTg1Njk3YjlmNiAxMDA2NDQKLS0tIGEveGVu L2FyY2gveDg2L2FzbS1tYWNyb3MuYworKysgYi94ZW4vYXJjaC94ODYvYXNt LW1hY3Jvcy5jCkBAIC0xICsxLDIgQEAKICNpbmNsdWRlIDxhc20vYWx0ZXJu YXRpdmUtYXNtLmg+CisjaW5jbHVkZSA8YXNtL3NwZWNfY3RybF9hc20uaD4K ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNo L3g4Ni9kb21haW4uYwppbmRleCA2OTk2YzZiMDZhYzIuLmMxNGNjNzI0ZmEx MyAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hl bi9hcmNoL3g4Ni9kb21haW4uYwpAQCAtMTgxNCw3ICsxODE0LDcgQEAgdm9p ZCBjb250ZXh0X3N3aXRjaChzdHJ1Y3QgdmNwdSAqcHJldiwgc3RydWN0IHZj cHUgKm5leHQpCiAgICAgICAgICAgICAgKi8KICAgICAgICAgICAgIGlmICgg Kmxhc3RfaWQgIT0gbmV4dF9pZCApCiAgICAgICAgICAgICB7Ci0gICAgICAg ICAgICAgICAgd3Jtc3JsKE1TUl9QUkVEX0NNRCwgUFJFRF9DTURfSUJQQik7 CisgICAgICAgICAgICAgICAgc3BlY19jdHJsX25ld19ndWVzdF9jb250ZXh0 KCk7CiAgICAgICAgICAgICAgICAgKmxhc3RfaWQgPSBuZXh0X2lkOwogICAg ICAgICAgICAgfQogICAgICAgICB9CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94 ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5k ZXggMjNiYzg3MGQzY2ZlLi4wZGJiN2Q1Zjg3MjIgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3Bl Y19jdHJsLmMKQEAgLTc3NCw2ICs3NzQsMTQgQEAgc3RhdGljIHZvaWQgX19p bml0IGlicGJfY2FsY3VsYXRpb25zKHZvaWQpCiAgICAgfQogCiAgICAgLyoK KyAgICAgKiBBTUQvSHlnb24gQ1BVcyB0byBkYXRlIChKdW5lIDIwMjIpIGRv bid0IGZsdXNoIHRoZSB0aGUgUkFTLiAgRnV0dXJlCisgICAgICogQ1BVcyBh cmUgZXhwZWN0ZWQgdG8gZW51bWVyYXRlIElCUEJfUkVUIHdoZW4gdGhpcyBo YXMgYmVlbiBmaXhlZC4KKyAgICAgKiBVbnRpbCB0aGVuLCBjb3ZlciB0aGUg ZGlmZmVyZW5jZSB3aXRoIHRoZSBzb2Z0d2FyZSBzZXF1ZW5jZS4KKyAgICAg Ki8KKyAgICBpZiAoIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSAm JiAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lCUEJfUkVUKSApCisgICAg ICAgIHNldHVwX2ZvcmNlX2NwdV9jYXAoWDg2X0JVR19JQlBCX05PX1JFVCk7 CisKKyAgICAvKgogICAgICAqIElCUEItb24tZW50cnkgbWl0aWdhdGlvbnMg Zm9yIEJyYW5jaCBUeXBlIENvbmZ1c2lvbi4KICAgICAgKgogICAgICAqIElC UEIgJiYgIUJUQ19OTyBzZWxlY3RzIGFsbCBBTUQvSHlnb24gaGFyZHdhcmUs IG5vdCBrbm93biB0byBiZSBzYWZlLApkaWZmIC0tZ2l0IGEveGVuL2luY2x1 ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5oIGIveGVuL2luY2x1ZGUvYXNtLXg4 Ni9jcHVmZWF0dXJlcy5oCmluZGV4IGM2MTM2Y2E0YTAzMS4uNzMwZWFjNGIy ZjcwIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2NwdWZlYXR1 cmVzLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5o CkBAIC00Niw2ICs0Niw3IEBAIFhFTl9DUFVGRUFUVVJFKElCUEJfRU5UUllf SFZNLCAgICBYODZfU1lOVEgoMjcpKSAvKiBNU1JfUFJFRF9DTUQgdXNlZCBi eSBYZW4gZm9yCiAKICNkZWZpbmUgWDg2X0JVR19GUFVfUFRSUyAgICAgICAg ICBYODZfQlVHKCAwKSAvKiAoRilYe1NBVkUsUlNUT1J9IGRvZXNuJ3Qgc2F2 ZS9yZXN0b3JlIEZPUC9GSVAvRkRQLiAqLwogI2RlZmluZSBYODZfQlVHX0NM RkxVU0hfTUZFTkNFICAgIFg4Nl9CVUcoIDIpIC8qIE1GRU5DRSBuZWVkZWQg dG8gc2VyaWFsaXNlIENMRkxVU0ggKi8KKyNkZWZpbmUgWDg2X0JVR19JQlBC X05PX1JFVCAgICAgICBYODZfQlVHKCAzKSAvKiBJQlBCIGRvZXNuJ3QgZmx1 c2ggdGhlIFJTQi9SQVMgKi8KIAogLyogVG90YWwgbnVtYmVyIG9mIGNhcGFi aWxpdHkgd29yZHMsIGluYyBzeW50aCBhbmQgYnVnIHdvcmRzLiAqLwogI2Rl ZmluZSBOQ0FQSU5UUyAoRlNDQVBJTlRTICsgWDg2X05SX1NZTlRIICsgWDg2 X05SX0JVRykgLyogTiAzMi1iaXQgd29yZHMgd29ydGggb2YgaW5mbyAqLwpk aWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaCBi L3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmgKaW5kZXggMmYxNWFl OTgxNDk1Li5mY2FlZjQ5NjI5ZDUgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRl L2FzbS14ODYvc3BlY19jdHJsLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4 Ni9zcGVjX2N0cmwuaApAQCAtNjUsNiArNjUsMjggQEAKIHZvaWQgaW5pdF9z cGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKTsKIHZvaWQgc3BlY19jdHJs X2luaXRfZG9tYWluKHN0cnVjdCBkb21haW4gKmQpOwogCisvKgorICogU3dp dGNoIHRvIGEgbmV3IGd1ZXN0IHByZWRpY3Rpb24gY29udGV4dC4KKyAqCisg KiBUaGlzIGZsdXNoZXMgYWxsIGluZGlyZWN0IGJyYW5jaCBwcmVkaWN0b3Jz IChCVEIsIFJTQi9SQVMpLCBzbyBndWVzdCBjb2RlCisgKiB3aGljaCBoYXMg cHJldmlvdXNseSBydW4gb24gdGhpcyBDUFUgY2FuJ3QgYXR0YWNrIHN1YnNl cXVlbnQgZ3Vlc3QgY29kZS4KKyAqCisgKiBBcyB0aGlzIGZsdXNoZXMgdGhl IFJTQi9SQVMsIGl0IGRlc3Ryb3lzIHRoZSBwcmVkaWN0aW9ucyBvZiB0aGUg Y2FsbGluZworICogY29udGV4dC4gIEZvciBiZXN0IHBlcmZvcm1hY2UsIGFy cmFuZ2UgZm9yIHRoaXMgdG8gYmUgdXNlZCB3aGVuIHdlJ3JlIGdvaW5nCisg KiB0byBqdW1wIG91dCBvZiB0aGUgY3VycmVudCBjb250ZXh0LCBlLmcuIHdp dGggcmVzZXRfc3RhY2tfYW5kX2p1bXAoKS4KKyAqCisgKiBGb3IgaGFyZHdh cmUgd2hpY2ggbWlzLWltcGxlbWVudHMgSUJQQiwgZml4IHVwIGJ5IGZsdXNo aW5nIHRoZSBSU0IvUkFTCisgKiBtYW51YWxseS4KKyAqLworc3RhdGljIGFs d2F5c19pbmxpbmUgdm9pZCBzcGVjX2N0cmxfbmV3X2d1ZXN0X2NvbnRleHQo dm9pZCkKK3sKKyAgICB3cm1zcmwoTVNSX1BSRURfQ01ELCBQUkVEX0NNRF9J QlBCKTsKKworICAgIC8qIChhYil1c2UgYWx0ZXJuYXRpdmVfaW5wdXQoKSB0 byBzcGVjaWZ5IGNsb2JiZXJzLiAqLworICAgIGFsdGVybmF0aXZlX2lucHV0 KCIiLCAiRE9fT1ZFUldSSVRFX1JTQiIsIFg4Nl9CVUdfSUJQQl9OT19SRVQs CisgICAgICAgICAgICAgICAgICAgICAgOiAicmF4IiwgInJjeCIpOworfQor CiBleHRlcm4gaW50OF90IG9wdF9pYnBiX2N0eHRfc3dpdGNoOwogZXh0ZXJu IGJvb2wgb3B0X3NzYmQ7CiBleHRlcm4gaW50OF90IG9wdF9lYWdlcl9mcHU7 Cg== --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.14-1.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.14-1.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW51bWVyYXRpb24gZm9yIElC UEJfUkVUCgpUaGUgSUJQQl9SRVQgYml0IGluZGljYXRlcyB0aGF0IHRoZSBD UFUncyBpbXBsZW1lbnRhdGlvbiBvZiBNU1JfUFJFRF9DTUQuSUJQQgpkb2Vz IGZsdXNoIHRoZSBSU0IvUkFTIHRvby4KClRoaXMgaXMgcGFydCBvZiBYU0Et NDIyIC8gQ1ZFLTIwMjItMjM4MjQuCgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcg Q29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpBY2tlZC1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBh L3Rvb2xzL2xpYnhsL2xpYnhsX2NwdWlkLmMgYi90b29scy9saWJ4bC9saWJ4 bF9jcHVpZC5jCmluZGV4IDI1NTc2YjRkOTkyZC4uMWI3NjI2ZjdkNDFjIDEw MDY0NAotLS0gYS90b29scy9saWJ4bC9saWJ4bF9jcHVpZC5jCisrKyBiL3Rv b2xzL2xpYnhsL2xpYnhsX2NwdWlkLmMKQEAgLTI4MSw2ICsyODEsNyBAQCBp bnQgbGlieGxfY3B1aWRfcGFyc2VfY29uZmlnKGxpYnhsX2NwdWlkX3BvbGlj eV9saXN0ICpjcHVpZCwgY29uc3QgY2hhciogc3RyKQogICAgICAgICB7InNz Yi1ubyIsICAgICAgIDB4ODAwMDAwMDgsIE5BLCBDUFVJRF9SRUdfRUJYLCAy NiwgIDF9LAogICAgICAgICB7InBzZmQiLCAgICAgICAgIDB4ODAwMDAwMDgs IE5BLCBDUFVJRF9SRUdfRUJYLCAyOCwgIDF9LAogICAgICAgICB7ImJ0Yy1u byIsICAgICAgIDB4ODAwMDAwMDgsIE5BLCBDUFVJRF9SRUdfRUJYLCAyOSwg IDF9LAorICAgICAgICB7ImlicGItcmV0IiwgICAgIDB4ODAwMDAwMDgsIE5B LCBDUFVJRF9SRUdfRUJYLCAzMCwgIDF9LAogCiAgICAgICAgIHsibmMiLCAg ICAgICAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQ1gsICAwLCAg OH0sCiAgICAgICAgIHsiYXBpY2lkc2l6ZSIsICAgMHg4MDAwMDAwOCwgTkEs IENQVUlEX1JFR19FQ1gsIDEyLCAgNH0sCmRpZmYgLS1naXQgYS90b29scy9t aXNjL3hlbi1jcHVpZC5jIGIvdG9vbHMvbWlzYy94ZW4tY3B1aWQuYwppbmRl eCBlNTIwOGNmYTQ1MzguLjc3NzFkYTQ5NTMyZiAxMDA2NDQKLS0tIGEvdG9v bHMvbWlzYy94ZW4tY3B1aWQuYworKysgYi90b29scy9taXNjL3hlbi1jcHVp ZC5jCkBAIC0xNTgsNiArMTU4LDcgQEAgc3RhdGljIGNvbnN0IGNoYXIgKmNv bnN0IHN0cl9lOGJbMzJdID0KICAgICBbMjRdID0gImFtZC1zc2JkIiwgICAg ICAgICBbMjVdID0gInZpcnQtc3NiZCIsCiAgICAgWzI2XSA9ICJzc2Itbm8i LAogICAgIFsyOF0gPSAicHNmZCIsICAgICAgICAgICAgIFsyOV0gPSAiYnRj LW5vIiwKKyAgICBbMzBdID0gImlicGItcmV0IiwKIH07CiAKIHN0YXRpYyBj b25zdCBjaGFyICpjb25zdCBzdHJfN2QwWzMyXSA9CmRpZmYgLS1naXQgYS94 ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19j dHJsLmMKaW5kZXggNTYzNTE5Y2UwZTMxLi42NzlmYmFjNTdlYzcgMTAwNjQ0 Ci0tLSBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJj aC94ODYvc3BlY19jdHJsLmMKQEAgLTQxOSw3ICs0MTksNyBAQCBzdGF0aWMg dm9pZCBfX2luaXQgcHJpbnRfZGV0YWlscyhlbnVtIGluZF90aHVuayB0aHVu aywgdWludDY0X3QgY2FwcykKICAgICAgKiBIYXJkd2FyZSByZWFkLW9ubHkg aW5mb3JtYXRpb24sIHN0YXRpbmcgaW1tdW5pdHkgdG8gY2VydGFpbiBpc3N1 ZXMsIG9yCiAgICAgICogc3VnZ2VzdGlvbnMgb2Ygd2hpY2ggbWl0aWdhdGlv biB0byB1c2UuCiAgICAgICovCi0gICAgcHJpbnRrKCIgIEhhcmR3YXJlIGhp bnRzOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlc1xuIiwKKyAgICBw cmludGsoIiAgSGFyZHdhcmUgaGludHM6JXMlcyVzJXMlcyVzJXMlcyVzJXMl cyVzJXMlcyVzJXNcbiIsCiAgICAgICAgICAgIChjYXBzICYgQVJDSF9DQVBT X1JEQ0xfTk8pICAgICAgICAgICAgICAgICAgICAgICAgPyAiIFJEQ0xfTk8i ICAgICAgICA6ICIiLAogICAgICAgICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19J QlJTX0FMTCkgICAgICAgICAgICAgICAgICAgICAgID8gIiBJQlJTX0FMTCIg ICAgICAgOiAiIiwKICAgICAgICAgICAgKGNhcHMgJiBBUkNIX0NBUFNfUlNC QSkgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIgUlNCQSIgICAgICAg ICAgIDogIiIsCkBAIC00MzUsNyArNDM1LDggQEAgc3RhdGljIHZvaWQgX19p bml0IHByaW50X2RldGFpbHMoZW51bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2 NF90IGNhcHMpCiAgICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4 Nl9GRUFUVVJFX1NUSUJQX0FMV0FZUykpICAgPyAiIFNUSUJQX0FMV0FZUyIg ICA6ICIiLAogICAgICAgICAgICAoZThiICAmIGNwdWZlYXRfbWFzayhYODZf RkVBVFVSRV9JQlJTX0ZBU1QpKSAgICAgID8gIiBJQlJTX0ZBU1QiICAgICAg OiAiIiwKICAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZF QVRVUkVfSUJSU19TQU1FX01PREUpKSA/ICIgSUJSU19TQU1FX01PREUiIDog IiIsCi0gICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFU VVJFX0JUQ19OTykpICAgICAgICAgPyAiIEJUQ19OTyIgICAgICAgICA6ICIi KTsKKyAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRV UkVfQlRDX05PKSkgICAgICAgICA/ICIgQlRDX05PIiAgICAgICAgIDogIiIs CisgICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJF X0lCUEJfUkVUKSkgICAgICAgPyAiIElCUEJfUkVUIiAgICAgICA6ICIiKTsK IAogICAgIC8qIEhhcmR3YXJlIGZlYXR1cmVzIHdoaWNoIG5lZWQgZHJpdmlu ZyB0byBtaXRpZ2F0ZSBpc3N1ZXMuICovCiAgICAgcHJpbnRrKCIgIEhhcmR3 YXJlIGZlYXR1cmVzOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlc1xuIiwKZGlm ZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0 dXJlc2V0LmggYi94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVh dHVyZXNldC5oCmluZGV4IDc0NmE3NTIwMGFiOC4uZTUzNmFiNDJiMzFkIDEw MDY0NAotLS0gYS94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVh dHVyZXNldC5oCisrKyBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9j cHVmZWF0dXJlc2V0LmgKQEAgLTI2NSw2ICsyNjUsNyBAQCBYRU5fQ1BVRkVB VFVSRShWSVJUX1NTQkQsICAgICA4KjMyKzI1KSAvKiAgIE1TUl9WSVJUX1NQ RUNfQ1RSTC5TU0JEICovCiBYRU5fQ1BVRkVBVFVSRShTU0JfTk8sICAgICAg ICA4KjMyKzI2KSAvKkEgIEhhcmR3YXJlIG5vdCB2dWxuZXJhYmxlIHRvIFNT QiAqLwogWEVOX0NQVUZFQVRVUkUoUFNGRCwgICAgICAgICAgOCozMisyOCkg LypTICBNU1JfU1BFQ19DVFJMLlBTRkQgKi8KIFhFTl9DUFVGRUFUVVJFKEJU Q19OTywgICAgICAgIDgqMzIrMjkpIC8qQSAgSGFyZHdhcmUgbm90IHZ1bG5l cmFibGUgdG8gQnJhbmNoIFR5cGUgQ29uZnVzaW9uICovCitYRU5fQ1BVRkVB VFVSRShJQlBCX1JFVCwgICAgICA4KjMyKzMwKSAvKkEgIElCUEIgY2xlYXJz IFJTQi9SQVMgdG9vLiAqLwogCiAvKiBJbnRlbC1kZWZpbmVkIENQVSBmZWF0 dXJlcywgQ1BVSUQgbGV2ZWwgMHgwMDAwMDAwNzowLmVkeCwgd29yZCA5ICov CiBYRU5fQ1BVRkVBVFVSRShBVlg1MTJfNFZOTklXLCA5KjMyKyAyKSAvKkEg IEFWWDUxMiBOZXVyYWwgTmV0d29yayBJbnN0cnVjdGlvbnMgKi8K --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.14-2.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.14-2.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgSUJQQiBub3Qg Zmx1c2hpbmcgdGhlIFJTQi9SQVMKCkludHJvZHVjZSBzcGVjX2N0cmxfbmV3 X2d1ZXN0X2NvbnRleHQoKSB0byBlbmNhcHN1bGF0ZSBhbGwgbG9naWMgcGVy dGFpbmluZyB0bwp1c2luZyBNU1JfUFJFRF9DTUQgZm9yIGEgbmV3IGd1ZXN0 IGNvbnRleHQsIGV2ZW4gaWYgaXQgb25seSBoYXMgb25lIHVzZXIKcHJlc2Vu dGx5LgoKSW50cm9kdWNlIFg4Nl9CVUdfSUJQQl9OT19SRVQsIGFuZCB1c2Ug aXQgZXh0ZW5kIHNwZWNfY3RybF9uZXdfZ3Vlc3RfY29udGV4dCgpCndpdGgg YSBtYW51YWwgZml4dXAgZm9yIGhhcmR3YXJlIHdoaWNoIG1pcy1pbXBsZW1l bnRzIElCUEIuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQyMiAvIENWRS0yMDIy LTIzODI0LgoKU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEphbiBCZXVsaWNoIDxq YmV1bGljaEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv YXNtLW1hY3Jvcy5jIGIveGVuL2FyY2gveDg2L2FzbS1tYWNyb3MuYwppbmRl eCBiOTYzZDU2YTU2NjMuLjhjNTg1Njk3YjlmNiAxMDA2NDQKLS0tIGEveGVu L2FyY2gveDg2L2FzbS1tYWNyb3MuYworKysgYi94ZW4vYXJjaC94ODYvYXNt LW1hY3Jvcy5jCkBAIC0xICsxLDIgQEAKICNpbmNsdWRlIDxhc20vYWx0ZXJu YXRpdmUtYXNtLmg+CisjaW5jbHVkZSA8YXNtL3NwZWNfY3RybF9hc20uaD4K ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNo L3g4Ni9kb21haW4uYwppbmRleCA0ZmI3OGQzOGU3MTkuLmIzNzc0YWYxYTVm NiAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hl bi9hcmNoL3g4Ni9kb21haW4uYwpAQCAtMTgzMiw3ICsxODMyLDcgQEAgdm9p ZCBjb250ZXh0X3N3aXRjaChzdHJ1Y3QgdmNwdSAqcHJldiwgc3RydWN0IHZj cHUgKm5leHQpCiAgICAgICAgICAgICAgKi8KICAgICAgICAgICAgIGlmICgg Kmxhc3RfaWQgIT0gbmV4dF9pZCApCiAgICAgICAgICAgICB7Ci0gICAgICAg ICAgICAgICAgd3Jtc3JsKE1TUl9QUkVEX0NNRCwgUFJFRF9DTURfSUJQQik7 CisgICAgICAgICAgICAgICAgc3BlY19jdHJsX25ld19ndWVzdF9jb250ZXh0 KCk7CiAgICAgICAgICAgICAgICAgKmxhc3RfaWQgPSBuZXh0X2lkOwogICAg ICAgICAgICAgfQogICAgICAgICB9CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94 ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5k ZXggNjc5ZmJhYzU3ZWM3Li5jNjUwZTA3YjA2MjkgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3Bl Y19jdHJsLmMKQEAgLTc3Nyw2ICs3NzcsMTQgQEAgc3RhdGljIHZvaWQgX19p bml0IGlicGJfY2FsY3VsYXRpb25zKHZvaWQpCiAgICAgfQogCiAgICAgLyoK KyAgICAgKiBBTUQvSHlnb24gQ1BVcyB0byBkYXRlIChKdW5lIDIwMjIpIGRv bid0IGZsdXNoIHRoZSB0aGUgUkFTLiAgRnV0dXJlCisgICAgICogQ1BVcyBh cmUgZXhwZWN0ZWQgdG8gZW51bWVyYXRlIElCUEJfUkVUIHdoZW4gdGhpcyBo YXMgYmVlbiBmaXhlZC4KKyAgICAgKiBVbnRpbCB0aGVuLCBjb3ZlciB0aGUg ZGlmZmVyZW5jZSB3aXRoIHRoZSBzb2Z0d2FyZSBzZXF1ZW5jZS4KKyAgICAg Ki8KKyAgICBpZiAoIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSAm JiAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lCUEJfUkVUKSApCisgICAg ICAgIHNldHVwX2ZvcmNlX2NwdV9jYXAoWDg2X0JVR19JQlBCX05PX1JFVCk7 CisKKyAgICAvKgogICAgICAqIElCUEItb24tZW50cnkgbWl0aWdhdGlvbnMg Zm9yIEJyYW5jaCBUeXBlIENvbmZ1c2lvbi4KICAgICAgKgogICAgICAqIElC UEIgJiYgIUJUQ19OTyBzZWxlY3RzIGFsbCBBTUQvSHlnb24gaGFyZHdhcmUs IG5vdCBrbm93biB0byBiZSBzYWZlLApkaWZmIC0tZ2l0IGEveGVuL2luY2x1 ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5oIGIveGVuL2luY2x1ZGUvYXNtLXg4 Ni9jcHVmZWF0dXJlcy5oCmluZGV4IGIyMzNlNTgzNWZiNS4uYmRiMTE5YTM0 YzVkIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2NwdWZlYXR1 cmVzLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5o CkBAIC00OCw2ICs0OCw3IEBAIFhFTl9DUFVGRUFUVVJFKElCUEJfRU5UUllf SFZNLCAgICBYODZfU1lOVEgoMjkpKSAvKiBNU1JfUFJFRF9DTUQgdXNlZCBi eSBYZW4gZm9yCiAKICNkZWZpbmUgWDg2X0JVR19GUFVfUFRSUyAgICAgICAg ICBYODZfQlVHKCAwKSAvKiAoRilYe1NBVkUsUlNUT1J9IGRvZXNuJ3Qgc2F2 ZS9yZXN0b3JlIEZPUC9GSVAvRkRQLiAqLwogI2RlZmluZSBYODZfQlVHX0NM RkxVU0hfTUZFTkNFICAgIFg4Nl9CVUcoIDIpIC8qIE1GRU5DRSBuZWVkZWQg dG8gc2VyaWFsaXNlIENMRkxVU0ggKi8KKyNkZWZpbmUgWDg2X0JVR19JQlBC X05PX1JFVCAgICAgICBYODZfQlVHKCAzKSAvKiBJQlBCIGRvZXNuJ3QgZmx1 c2ggdGhlIFJTQi9SQVMgKi8KIAogLyogVG90YWwgbnVtYmVyIG9mIGNhcGFi aWxpdHkgd29yZHMsIGluYyBzeW50aCBhbmQgYnVnIHdvcmRzLiAqLwogI2Rl ZmluZSBOQ0FQSU5UUyAoRlNDQVBJTlRTICsgWDg2X05SX1NZTlRIICsgWDg2 X05SX0JVRykgLyogTiAzMi1iaXQgd29yZHMgd29ydGggb2YgaW5mbyAqLwpk aWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaCBi L3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmgKaW5kZXggMzNlODQ1 OTkxYjBhLi5lNDAwZmYyMjczOTEgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRl L2FzbS14ODYvc3BlY19jdHJsLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4 Ni9zcGVjX2N0cmwuaApAQCAtNjUsNiArNjUsMjggQEAKIHZvaWQgaW5pdF9z cGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKTsKIHZvaWQgc3BlY19jdHJs X2luaXRfZG9tYWluKHN0cnVjdCBkb21haW4gKmQpOwogCisvKgorICogU3dp dGNoIHRvIGEgbmV3IGd1ZXN0IHByZWRpY3Rpb24gY29udGV4dC4KKyAqCisg KiBUaGlzIGZsdXNoZXMgYWxsIGluZGlyZWN0IGJyYW5jaCBwcmVkaWN0b3Jz IChCVEIsIFJTQi9SQVMpLCBzbyBndWVzdCBjb2RlCisgKiB3aGljaCBoYXMg cHJldmlvdXNseSBydW4gb24gdGhpcyBDUFUgY2FuJ3QgYXR0YWNrIHN1YnNl cXVlbnQgZ3Vlc3QgY29kZS4KKyAqCisgKiBBcyB0aGlzIGZsdXNoZXMgdGhl IFJTQi9SQVMsIGl0IGRlc3Ryb3lzIHRoZSBwcmVkaWN0aW9ucyBvZiB0aGUg Y2FsbGluZworICogY29udGV4dC4gIEZvciBiZXN0IHBlcmZvcm1hY2UsIGFy cmFuZ2UgZm9yIHRoaXMgdG8gYmUgdXNlZCB3aGVuIHdlJ3JlIGdvaW5nCisg KiB0byBqdW1wIG91dCBvZiB0aGUgY3VycmVudCBjb250ZXh0LCBlLmcuIHdp dGggcmVzZXRfc3RhY2tfYW5kX2p1bXAoKS4KKyAqCisgKiBGb3IgaGFyZHdh cmUgd2hpY2ggbWlzLWltcGxlbWVudHMgSUJQQiwgZml4IHVwIGJ5IGZsdXNo aW5nIHRoZSBSU0IvUkFTCisgKiBtYW51YWxseS4KKyAqLworc3RhdGljIGFs d2F5c19pbmxpbmUgdm9pZCBzcGVjX2N0cmxfbmV3X2d1ZXN0X2NvbnRleHQo dm9pZCkKK3sKKyAgICB3cm1zcmwoTVNSX1BSRURfQ01ELCBQUkVEX0NNRF9J QlBCKTsKKworICAgIC8qIChhYil1c2UgYWx0ZXJuYXRpdmVfaW5wdXQoKSB0 byBzcGVjaWZ5IGNsb2JiZXJzLiAqLworICAgIGFsdGVybmF0aXZlX2lucHV0 KCIiLCAiRE9fT1ZFUldSSVRFX1JTQiIsIFg4Nl9CVUdfSUJQQl9OT19SRVQs CisgICAgICAgICAgICAgICAgICAgICAgOiAicmF4IiwgInJjeCIpOworfQor CiBleHRlcm4gaW50OF90IG9wdF9pYnBiX2N0eHRfc3dpdGNoOwogZXh0ZXJu IGJvb2wgb3B0X3NzYmQ7CiBleHRlcm4gaW50OF90IG9wdF9lYWdlcl9mcHU7 Cg== --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.15-1.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.15-1.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW51bWVyYXRpb24gZm9yIElC UEJfUkVUCgpUaGUgSUJQQl9SRVQgYml0IGluZGljYXRlcyB0aGF0IHRoZSBD UFUncyBpbXBsZW1lbnRhdGlvbiBvZiBNU1JfUFJFRF9DTUQuSUJQQgpkb2Vz IGZsdXNoIHRoZSBSU0IvUkFTIHRvby4KClRoaXMgaXMgcGFydCBvZiBYU0Et NDIyIC8gQ1ZFLTIwMjItMjM4MjQuCgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcg Q29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpBY2tlZC1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBh L3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYyBiL3Rvb2xzL2xpYnMv bGlnaHQvbGlieGxfY3B1aWQuYwppbmRleCAyNjMyZWZjNmFkYjAuLjRjYzJm MjExYjg3OCAxMDA2NDQKLS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9j cHVpZC5jCisrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYwpA QCAtMjg0LDYgKzI4NCw3IEBAIGludCBsaWJ4bF9jcHVpZF9wYXJzZV9jb25m aWcobGlieGxfY3B1aWRfcG9saWN5X2xpc3QgKmNwdWlkLCBjb25zdCBjaGFy KiBzdHIpCiAgICAgICAgIHsic3NiLW5vIiwgICAgICAgMHg4MDAwMDAwOCwg TkEsIENQVUlEX1JFR19FQlgsIDI2LCAgMX0sCiAgICAgICAgIHsicHNmZCIs ICAgICAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDI4LCAg MX0sCiAgICAgICAgIHsiYnRjLW5vIiwgICAgICAgMHg4MDAwMDAwOCwgTkEs IENQVUlEX1JFR19FQlgsIDI5LCAgMX0sCisgICAgICAgIHsiaWJwYi1yZXQi LCAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDMwLCAgMX0s CiAKICAgICAgICAgeyJuYyIsICAgICAgICAgICAweDgwMDAwMDA4LCBOQSwg Q1BVSURfUkVHX0VDWCwgIDAsICA4fSwKICAgICAgICAgeyJhcGljaWRzaXpl IiwgICAweDgwMDAwMDA4LCBOQSwgQ1BVSURfUkVHX0VDWCwgMTIsICA0fSwK ZGlmZiAtLWdpdCBhL3Rvb2xzL21pc2MveGVuLWNwdWlkLmMgYi90b29scy9t aXNjL3hlbi1jcHVpZC5jCmluZGV4IGU4M2JjNDc5M2Q2ZS4uNWM5NDRjMjRm ZTM2IDEwMDY0NAotLS0gYS90b29scy9taXNjL3hlbi1jcHVpZC5jCisrKyBi L3Rvb2xzL21pc2MveGVuLWNwdWlkLmMKQEAgLTE1OCw2ICsxNTgsNyBAQCBz dGF0aWMgY29uc3QgY2hhciAqY29uc3Qgc3RyX2U4YlszMl0gPQogICAgIFsy NF0gPSAiYW1kLXNzYmQiLCAgICAgICAgIFsyNV0gPSAidmlydC1zc2JkIiwK ICAgICBbMjZdID0gInNzYi1ubyIsCiAgICAgWzI4XSA9ICJwc2ZkIiwgICAg ICAgICAgICAgWzI5XSA9ICJidGMtbm8iLAorICAgIFszMF0gPSAiaWJwYi1y ZXQiLAogfTsKIAogc3RhdGljIGNvbnN0IGNoYXIgKmNvbnN0IHN0cl83ZDBb MzJdID0KZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBi L3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwppbmRleCAzZmY2MDJiZDAyODEu LjQ1OWM2NGQxMzliNiAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3NwZWNf Y3RybC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwpAQCAtNDE5 LDcgKzQxOSw3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwcmludF9kZXRhaWxz KGVudW0gaW5kX3RodW5rIHRodW5rLCB1aW50NjRfdCBjYXBzKQogICAgICAq IEhhcmR3YXJlIHJlYWQtb25seSBpbmZvcm1hdGlvbiwgc3RhdGluZyBpbW11 bml0eSB0byBjZXJ0YWluIGlzc3Vlcywgb3IKICAgICAgKiBzdWdnZXN0aW9u cyBvZiB3aGljaCBtaXRpZ2F0aW9uIHRvIHVzZS4KICAgICAgKi8KLSAgICBw cmludGsoIiAgSGFyZHdhcmUgaGludHM6JXMlcyVzJXMlcyVzJXMlcyVzJXMl cyVzJXMlcyVzJXNcbiIsCisgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGhpbnRz OiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXNcbiIsCiAgICAg ICAgICAgIChjYXBzICYgQVJDSF9DQVBTX1JEQ0xfTk8pICAgICAgICAgICAg ICAgICAgICAgICAgPyAiIFJEQ0xfTk8iICAgICAgICA6ICIiLAogICAgICAg ICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19JQlJTX0FMTCkgICAgICAgICAgICAg ICAgICAgICAgID8gIiBJQlJTX0FMTCIgICAgICAgOiAiIiwKICAgICAgICAg ICAgKGNhcHMgJiBBUkNIX0NBUFNfUlNCQSkgICAgICAgICAgICAgICAgICAg ICAgICAgICA/ICIgUlNCQSIgICAgICAgICAgIDogIiIsCkBAIC00MzYsNyAr NDM2LDggQEAgc3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMoZW51 bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICAgICAg IChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX1NUSUJQX0FMV0FZ UykpICAgPyAiIFNUSUJQX0FMV0FZUyIgICA6ICIiLAogICAgICAgICAgICAo ZThiICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9JQlJTX0ZBU1QpKSAg ICAgID8gIiBJQlJTX0ZBU1QiICAgICAgOiAiIiwKICAgICAgICAgICAgKGU4 YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfSUJSU19TQU1FX01PREUp KSA/ICIgSUJSU19TQU1FX01PREUiIDogIiIsCi0gICAgICAgICAgIChlOGIg ICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0JUQ19OTykpICAgICAgICAg PyAiIEJUQ19OTyIgICAgICAgICA6ICIiKTsKKyAgICAgICAgICAgKGU4YiAg JiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfQlRDX05PKSkgICAgICAgICA/ ICIgQlRDX05PIiAgICAgICAgIDogIiIsCisgICAgICAgICAgIChlOGIgICYg Y3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0lCUEJfUkVUKSkgICAgICAgPyAi IElCUEJfUkVUIiAgICAgICA6ICIiKTsKIAogICAgIC8qIEhhcmR3YXJlIGZl YXR1cmVzIHdoaWNoIG5lZWQgZHJpdmluZyB0byBtaXRpZ2F0ZSBpc3N1ZXMu ICovCiAgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGZlYXR1cmVzOiVzJXMlcyVz JXMlcyVzJXMlcyVzJXMlc1xuIiwKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRl L3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmggYi94ZW4vaW5jbHVk ZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCmluZGV4IDFiYmM3 ZGE0YjUzYy4uNDFhMzU4ZDU3NWQzIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVk ZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCisrKyBiL3hlbi9p bmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmgKQEAgLTI2 Niw2ICsyNjYsNyBAQCBYRU5fQ1BVRkVBVFVSRShWSVJUX1NTQkQsICAgICA4 KjMyKzI1KSAvKiAgIE1TUl9WSVJUX1NQRUNfQ1RSTC5TU0JEICovCiBYRU5f Q1BVRkVBVFVSRShTU0JfTk8sICAgICAgICA4KjMyKzI2KSAvKkEgIEhhcmR3 YXJlIG5vdCB2dWxuZXJhYmxlIHRvIFNTQiAqLwogWEVOX0NQVUZFQVRVUkUo UFNGRCwgICAgICAgICAgOCozMisyOCkgLypTICBNU1JfU1BFQ19DVFJMLlBT RkQgKi8KIFhFTl9DUFVGRUFUVVJFKEJUQ19OTywgICAgICAgIDgqMzIrMjkp IC8qQSAgSGFyZHdhcmUgbm90IHZ1bG5lcmFibGUgdG8gQnJhbmNoIFR5cGUg Q29uZnVzaW9uICovCitYRU5fQ1BVRkVBVFVSRShJQlBCX1JFVCwgICAgICA4 KjMyKzMwKSAvKkEgIElCUEIgY2xlYXJzIFJTQi9SQVMgdG9vLiAqLwogCiAv KiBJbnRlbC1kZWZpbmVkIENQVSBmZWF0dXJlcywgQ1BVSUQgbGV2ZWwgMHgw MDAwMDAwNzowLmVkeCwgd29yZCA5ICovCiBYRU5fQ1BVRkVBVFVSRShBVlg1 MTJfNFZOTklXLCA5KjMyKyAyKSAvKkEgIEFWWDUxMiBOZXVyYWwgTmV0d29y ayBJbnN0cnVjdGlvbnMgKi8K --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.15-2.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.15-2.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgSUJQQiBub3Qg Zmx1c2hpbmcgdGhlIFJTQi9SQVMKCkludHJvZHVjZSBzcGVjX2N0cmxfbmV3 X2d1ZXN0X2NvbnRleHQoKSB0byBlbmNhcHN1bGF0ZSBhbGwgbG9naWMgcGVy dGFpbmluZyB0bwp1c2luZyBNU1JfUFJFRF9DTUQgZm9yIGEgbmV3IGd1ZXN0 IGNvbnRleHQsIGV2ZW4gaWYgaXQgb25seSBoYXMgb25lIHVzZXIKcHJlc2Vu dGx5LgoKSW50cm9kdWNlIFg4Nl9CVUdfSUJQQl9OT19SRVQsIGFuZCB1c2Ug aXQgZXh0ZW5kIHNwZWNfY3RybF9uZXdfZ3Vlc3RfY29udGV4dCgpCndpdGgg YSBtYW51YWwgZml4dXAgZm9yIGhhcmR3YXJlIHdoaWNoIG1pcy1pbXBsZW1l bnRzIElCUEIuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQyMiAvIENWRS0yMDIy LTIzODI0LgoKU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEphbiBCZXVsaWNoIDxq YmV1bGljaEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv YXNtLW1hY3Jvcy5jIGIveGVuL2FyY2gveDg2L2FzbS1tYWNyb3MuYwppbmRl eCA3ZTUzNmIwZDgyZjUuLjg5MWQ4NmM3NjU1YyAxMDA2NDQKLS0tIGEveGVu L2FyY2gveDg2L2FzbS1tYWNyb3MuYworKysgYi94ZW4vYXJjaC94ODYvYXNt LW1hY3Jvcy5jCkBAIC0xLDIgKzEsMyBAQAogI2luY2x1ZGUgPGFzbS9hc20t ZGVmbnMuaD4KICNpbmNsdWRlIDxhc20vYWx0ZXJuYXRpdmUtYXNtLmg+Cisj aW5jbHVkZSA8YXNtL3NwZWNfY3RybF9hc20uaD4KZGlmZiAtLWdpdCBhL3hl bi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNoL3g4Ni9kb21haW4uYwpp bmRleCBlOWI4ZWQ0Yzk2YzIuLmI4MmUxOGRkNjJkOCAxMDA2NDQKLS0tIGEv eGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hlbi9hcmNoL3g4Ni9kb21h aW4uYwpAQCAtMjA2OSw3ICsyMDY5LDcgQEAgdm9pZCBjb250ZXh0X3N3aXRj aChzdHJ1Y3QgdmNwdSAqcHJldiwgc3RydWN0IHZjcHUgKm5leHQpCiAgICAg ICAgICAgICAgKi8KICAgICAgICAgICAgIGlmICggKmxhc3RfaWQgIT0gbmV4 dF9pZCApCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgd3Jtc3Js KE1TUl9QUkVEX0NNRCwgUFJFRF9DTURfSUJQQik7CisgICAgICAgICAgICAg ICAgc3BlY19jdHJsX25ld19ndWVzdF9jb250ZXh0KCk7CiAgICAgICAgICAg ICAgICAgKmxhc3RfaWQgPSBuZXh0X2lkOwogICAgICAgICAgICAgfQogICAg ICAgICB9CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMg Yi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5kZXggNDU5YzY0ZDEzOWI2 Li41NjM2ODUzYWFlNmIgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9zcGVj X2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKQEAgLTc3 Niw2ICs3NzYsMTQgQEAgc3RhdGljIHZvaWQgX19pbml0IGlicGJfY2FsY3Vs YXRpb25zKHZvaWQpCiAgICAgfQogCiAgICAgLyoKKyAgICAgKiBBTUQvSHln b24gQ1BVcyB0byBkYXRlIChKdW5lIDIwMjIpIGRvbid0IGZsdXNoIHRoZSB0 aGUgUkFTLiAgRnV0dXJlCisgICAgICogQ1BVcyBhcmUgZXhwZWN0ZWQgdG8g ZW51bWVyYXRlIElCUEJfUkVUIHdoZW4gdGhpcyBoYXMgYmVlbiBmaXhlZC4K KyAgICAgKiBVbnRpbCB0aGVuLCBjb3ZlciB0aGUgZGlmZmVyZW5jZSB3aXRo IHRoZSBzb2Z0d2FyZSBzZXF1ZW5jZS4KKyAgICAgKi8KKyAgICBpZiAoIGJv b3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSAmJiAhYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX0lCUEJfUkVUKSApCisgICAgICAgIHNldHVwX2ZvcmNl X2NwdV9jYXAoWDg2X0JVR19JQlBCX05PX1JFVCk7CisKKyAgICAvKgogICAg ICAqIElCUEItb24tZW50cnkgbWl0aWdhdGlvbnMgZm9yIEJyYW5jaCBUeXBl IENvbmZ1c2lvbi4KICAgICAgKgogICAgICAqIElCUEIgJiYgIUJUQ19OTyBz ZWxlY3RzIGFsbCBBTUQvSHlnb24gaGFyZHdhcmUsIG5vdCBrbm93biB0byBi ZSBzYWZlLApkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVm ZWF0dXJlcy5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5o CmluZGV4IGIyMzNlNTgzNWZiNS4uYmRiMTE5YTM0YzVkIDEwMDY0NAotLS0g YS94ZW4vaW5jbHVkZS9hc20teDg2L2NwdWZlYXR1cmVzLmgKKysrIGIveGVu L2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5oCkBAIC00OCw2ICs0OCw3 IEBAIFhFTl9DUFVGRUFUVVJFKElCUEJfRU5UUllfSFZNLCAgICBYODZfU1lO VEgoMjkpKSAvKiBNU1JfUFJFRF9DTUQgdXNlZCBieSBYZW4gZm9yCiAKICNk ZWZpbmUgWDg2X0JVR19GUFVfUFRSUyAgICAgICAgICBYODZfQlVHKCAwKSAv KiAoRilYe1NBVkUsUlNUT1J9IGRvZXNuJ3Qgc2F2ZS9yZXN0b3JlIEZPUC9G SVAvRkRQLiAqLwogI2RlZmluZSBYODZfQlVHX0NMRkxVU0hfTUZFTkNFICAg IFg4Nl9CVUcoIDIpIC8qIE1GRU5DRSBuZWVkZWQgdG8gc2VyaWFsaXNlIENM RkxVU0ggKi8KKyNkZWZpbmUgWDg2X0JVR19JQlBCX05PX1JFVCAgICAgICBY ODZfQlVHKCAzKSAvKiBJQlBCIGRvZXNuJ3QgZmx1c2ggdGhlIFJTQi9SQVMg Ki8KIAogLyogVG90YWwgbnVtYmVyIG9mIGNhcGFiaWxpdHkgd29yZHMsIGlu YyBzeW50aCBhbmQgYnVnIHdvcmRzLiAqLwogI2RlZmluZSBOQ0FQSU5UUyAo RlNDQVBJTlRTICsgWDg2X05SX1NZTlRIICsgWDg2X05SX0JVRykgLyogTiAz Mi1iaXQgd29yZHMgd29ydGggb2YgaW5mbyAqLwpkaWZmIC0tZ2l0IGEveGVu L2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaCBiL3hlbi9pbmNsdWRlL2Fz bS14ODYvc3BlY19jdHJsLmgKaW5kZXggMzNlODQ1OTkxYjBhLi5lNDAwZmYy MjczOTEgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19j dHJsLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaApA QCAtNjUsNiArNjUsMjggQEAKIHZvaWQgaW5pdF9zcGVjdWxhdGlvbl9taXRp Z2F0aW9ucyh2b2lkKTsKIHZvaWQgc3BlY19jdHJsX2luaXRfZG9tYWluKHN0 cnVjdCBkb21haW4gKmQpOwogCisvKgorICogU3dpdGNoIHRvIGEgbmV3IGd1 ZXN0IHByZWRpY3Rpb24gY29udGV4dC4KKyAqCisgKiBUaGlzIGZsdXNoZXMg YWxsIGluZGlyZWN0IGJyYW5jaCBwcmVkaWN0b3JzIChCVEIsIFJTQi9SQVMp LCBzbyBndWVzdCBjb2RlCisgKiB3aGljaCBoYXMgcHJldmlvdXNseSBydW4g b24gdGhpcyBDUFUgY2FuJ3QgYXR0YWNrIHN1YnNlcXVlbnQgZ3Vlc3QgY29k ZS4KKyAqCisgKiBBcyB0aGlzIGZsdXNoZXMgdGhlIFJTQi9SQVMsIGl0IGRl c3Ryb3lzIHRoZSBwcmVkaWN0aW9ucyBvZiB0aGUgY2FsbGluZworICogY29u dGV4dC4gIEZvciBiZXN0IHBlcmZvcm1hY2UsIGFycmFuZ2UgZm9yIHRoaXMg dG8gYmUgdXNlZCB3aGVuIHdlJ3JlIGdvaW5nCisgKiB0byBqdW1wIG91dCBv ZiB0aGUgY3VycmVudCBjb250ZXh0LCBlLmcuIHdpdGggcmVzZXRfc3RhY2tf YW5kX2p1bXAoKS4KKyAqCisgKiBGb3IgaGFyZHdhcmUgd2hpY2ggbWlzLWlt cGxlbWVudHMgSUJQQiwgZml4IHVwIGJ5IGZsdXNoaW5nIHRoZSBSU0IvUkFT CisgKiBtYW51YWxseS4KKyAqLworc3RhdGljIGFsd2F5c19pbmxpbmUgdm9p ZCBzcGVjX2N0cmxfbmV3X2d1ZXN0X2NvbnRleHQodm9pZCkKK3sKKyAgICB3 cm1zcmwoTVNSX1BSRURfQ01ELCBQUkVEX0NNRF9JQlBCKTsKKworICAgIC8q IChhYil1c2UgYWx0ZXJuYXRpdmVfaW5wdXQoKSB0byBzcGVjaWZ5IGNsb2Ji ZXJzLiAqLworICAgIGFsdGVybmF0aXZlX2lucHV0KCIiLCAiRE9fT1ZFUldS SVRFX1JTQiIsIFg4Nl9CVUdfSUJQQl9OT19SRVQsCisgICAgICAgICAgICAg ICAgICAgICAgOiAicmF4IiwgInJjeCIpOworfQorCiBleHRlcm4gaW50OF90 IG9wdF9pYnBiX2N0eHRfc3dpdGNoOwogZXh0ZXJuIGJvb2wgb3B0X3NzYmQ7 CiBleHRlcm4gaW50OF90IG9wdF9lYWdlcl9mcHU7Cg== --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.16-1.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.16-1.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW51bWVyYXRpb24gZm9yIElC UEJfUkVUCgpUaGUgSUJQQl9SRVQgYml0IGluZGljYXRlcyB0aGF0IHRoZSBD UFUncyBpbXBsZW1lbnRhdGlvbiBvZiBNU1JfUFJFRF9DTUQuSUJQQgpkb2Vz IGZsdXNoIHRoZSBSU0IvUkFTIHRvby4KClRoaXMgaXMgcGFydCBvZiBYU0Et NDIyIC8gQ1ZFLTIwMjItMjM4MjQuCgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcg Q29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpBY2tlZC1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBh L3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYyBiL3Rvb2xzL2xpYnMv bGlnaHQvbGlieGxfY3B1aWQuYwppbmRleCBiZjZmZGVlMzYwYTkuLjY5MWQ1 YzZiMmE2OCAxMDA2NDQKLS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9j cHVpZC5jCisrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYwpA QCAtMjg5LDYgKzI4OSw3IEBAIGludCBsaWJ4bF9jcHVpZF9wYXJzZV9jb25m aWcobGlieGxfY3B1aWRfcG9saWN5X2xpc3QgKmNwdWlkLCBjb25zdCBjaGFy KiBzdHIpCiAgICAgICAgIHsic3NiLW5vIiwgICAgICAgMHg4MDAwMDAwOCwg TkEsIENQVUlEX1JFR19FQlgsIDI2LCAgMX0sCiAgICAgICAgIHsicHNmZCIs ICAgICAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDI4LCAg MX0sCiAgICAgICAgIHsiYnRjLW5vIiwgICAgICAgMHg4MDAwMDAwOCwgTkEs IENQVUlEX1JFR19FQlgsIDI5LCAgMX0sCisgICAgICAgIHsiaWJwYi1yZXQi LCAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDMwLCAgMX0s CiAKICAgICAgICAgeyJuYyIsICAgICAgICAgICAweDgwMDAwMDA4LCBOQSwg Q1BVSURfUkVHX0VDWCwgIDAsICA4fSwKICAgICAgICAgeyJhcGljaWRzaXpl IiwgICAweDgwMDAwMDA4LCBOQSwgQ1BVSURfUkVHX0VDWCwgMTIsICA0fSwK ZGlmZiAtLWdpdCBhL3Rvb2xzL21pc2MveGVuLWNwdWlkLmMgYi90b29scy9t aXNjL3hlbi1jcHVpZC5jCmluZGV4IGZlMjJmNWY1YjY4Yi4uY2QwOTQ0Mjdk ZDRjIDEwMDY0NAotLS0gYS90b29scy9taXNjL3hlbi1jcHVpZC5jCisrKyBi L3Rvb2xzL21pc2MveGVuLWNwdWlkLmMKQEAgLTE1OSw2ICsxNTksNyBAQCBz dGF0aWMgY29uc3QgY2hhciAqY29uc3Qgc3RyX2U4YlszMl0gPQogICAgIFsy NF0gPSAiYW1kLXNzYmQiLCAgICAgICAgIFsyNV0gPSAidmlydC1zc2JkIiwK ICAgICBbMjZdID0gInNzYi1ubyIsCiAgICAgWzI4XSA9ICJwc2ZkIiwgICAg ICAgICAgICAgWzI5XSA9ICJidGMtbm8iLAorICAgIFszMF0gPSAiaWJwYi1y ZXQiLAogfTsKIAogc3RhdGljIGNvbnN0IGNoYXIgKmNvbnN0IHN0cl83ZDBb MzJdID0KZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBi L3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwppbmRleCAwZjRiYWQzZDNhYmIu LjE2YTU2MmQzYTE3MiAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3NwZWNf Y3RybC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwpAQCAtNDE5 LDcgKzQxOSw3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwcmludF9kZXRhaWxz KGVudW0gaW5kX3RodW5rIHRodW5rLCB1aW50NjRfdCBjYXBzKQogICAgICAq IEhhcmR3YXJlIHJlYWQtb25seSBpbmZvcm1hdGlvbiwgc3RhdGluZyBpbW11 bml0eSB0byBjZXJ0YWluIGlzc3Vlcywgb3IKICAgICAgKiBzdWdnZXN0aW9u cyBvZiB3aGljaCBtaXRpZ2F0aW9uIHRvIHVzZS4KICAgICAgKi8KLSAgICBw cmludGsoIiAgSGFyZHdhcmUgaGludHM6JXMlcyVzJXMlcyVzJXMlcyVzJXMl cyVzJXMlcyVzJXNcbiIsCisgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGhpbnRz OiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXNcbiIsCiAgICAg ICAgICAgIChjYXBzICYgQVJDSF9DQVBTX1JEQ0xfTk8pICAgICAgICAgICAg ICAgICAgICAgICAgPyAiIFJEQ0xfTk8iICAgICAgICA6ICIiLAogICAgICAg ICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19JQlJTX0FMTCkgICAgICAgICAgICAg ICAgICAgICAgID8gIiBJQlJTX0FMTCIgICAgICAgOiAiIiwKICAgICAgICAg ICAgKGNhcHMgJiBBUkNIX0NBUFNfUlNCQSkgICAgICAgICAgICAgICAgICAg ICAgICAgICA/ICIgUlNCQSIgICAgICAgICAgIDogIiIsCkBAIC00MzYsNyAr NDM2LDggQEAgc3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMoZW51 bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICAgICAg IChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX1NUSUJQX0FMV0FZ UykpICAgPyAiIFNUSUJQX0FMV0FZUyIgICA6ICIiLAogICAgICAgICAgICAo ZThiICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9JQlJTX0ZBU1QpKSAg ICAgID8gIiBJQlJTX0ZBU1QiICAgICAgOiAiIiwKICAgICAgICAgICAgKGU4 YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfSUJSU19TQU1FX01PREUp KSA/ICIgSUJSU19TQU1FX01PREUiIDogIiIsCi0gICAgICAgICAgIChlOGIg ICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0JUQ19OTykpICAgICAgICAg PyAiIEJUQ19OTyIgICAgICAgICA6ICIiKTsKKyAgICAgICAgICAgKGU4YiAg JiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfQlRDX05PKSkgICAgICAgICA/ ICIgQlRDX05PIiAgICAgICAgIDogIiIsCisgICAgICAgICAgIChlOGIgICYg Y3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0lCUEJfUkVUKSkgICAgICAgPyAi IElCUEJfUkVUIiAgICAgICA6ICIiKTsKIAogICAgIC8qIEhhcmR3YXJlIGZl YXR1cmVzIHdoaWNoIG5lZWQgZHJpdmluZyB0byBtaXRpZ2F0ZSBpc3N1ZXMu ICovCiAgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGZlYXR1cmVzOiVzJXMlcyVz JXMlcyVzJXMlcyVzJXMlc1xuIiwKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRl L3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmggYi94ZW4vaW5jbHVk ZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCmluZGV4IGU3Yjgx Njc4MDBhMi4uZTA3MzEyMjE0MDRjIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVk ZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCisrKyBiL3hlbi9p bmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmgKQEAgLTI2 Nyw2ICsyNjcsNyBAQCBYRU5fQ1BVRkVBVFVSRShWSVJUX1NTQkQsICAgICA4 KjMyKzI1KSAvKiAgIE1TUl9WSVJUX1NQRUNfQ1RSTC5TU0JEICovCiBYRU5f Q1BVRkVBVFVSRShTU0JfTk8sICAgICAgICA4KjMyKzI2KSAvKkEgIEhhcmR3 YXJlIG5vdCB2dWxuZXJhYmxlIHRvIFNTQiAqLwogWEVOX0NQVUZFQVRVUkUo UFNGRCwgICAgICAgICAgOCozMisyOCkgLypTICBNU1JfU1BFQ19DVFJMLlBT RkQgKi8KIFhFTl9DUFVGRUFUVVJFKEJUQ19OTywgICAgICAgIDgqMzIrMjkp IC8qQSAgSGFyZHdhcmUgbm90IHZ1bG5lcmFibGUgdG8gQnJhbmNoIFR5cGUg Q29uZnVzaW9uICovCitYRU5fQ1BVRkVBVFVSRShJQlBCX1JFVCwgICAgICA4 KjMyKzMwKSAvKkEgIElCUEIgY2xlYXJzIFJTQi9SQVMgdG9vLiAqLwogCiAv KiBJbnRlbC1kZWZpbmVkIENQVSBmZWF0dXJlcywgQ1BVSUQgbGV2ZWwgMHgw MDAwMDAwNzowLmVkeCwgd29yZCA5ICovCiBYRU5fQ1BVRkVBVFVSRShBVlg1 MTJfNFZOTklXLCA5KjMyKyAyKSAvKkEgIEFWWDUxMiBOZXVyYWwgTmV0d29y ayBJbnN0cnVjdGlvbnMgKi8K --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.16-2.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.16-2.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgSUJQQiBub3Qg Zmx1c2hpbmcgdGhlIFJTQi9SQVMKCkludHJvZHVjZSBzcGVjX2N0cmxfbmV3 X2d1ZXN0X2NvbnRleHQoKSB0byBlbmNhcHN1bGF0ZSBhbGwgbG9naWMgcGVy dGFpbmluZyB0bwp1c2luZyBNU1JfUFJFRF9DTUQgZm9yIGEgbmV3IGd1ZXN0 IGNvbnRleHQsIGV2ZW4gaWYgaXQgb25seSBoYXMgb25lIHVzZXIKcHJlc2Vu dGx5LgoKSW50cm9kdWNlIFg4Nl9CVUdfSUJQQl9OT19SRVQsIGFuZCB1c2Ug aXQgZXh0ZW5kIHNwZWNfY3RybF9uZXdfZ3Vlc3RfY29udGV4dCgpCndpdGgg YSBtYW51YWwgZml4dXAgZm9yIGhhcmR3YXJlIHdoaWNoIG1pcy1pbXBsZW1l bnRzIElCUEIuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQyMiAvIENWRS0yMDIy LTIzODI0LgoKU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEphbiBCZXVsaWNoIDxq YmV1bGljaEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv YXNtLW1hY3Jvcy5jIGIveGVuL2FyY2gveDg2L2FzbS1tYWNyb3MuYwppbmRl eCA3ZTUzNmIwZDgyZjUuLjg5MWQ4NmM3NjU1YyAxMDA2NDQKLS0tIGEveGVu L2FyY2gveDg2L2FzbS1tYWNyb3MuYworKysgYi94ZW4vYXJjaC94ODYvYXNt LW1hY3Jvcy5jCkBAIC0xLDIgKzEsMyBAQAogI2luY2x1ZGUgPGFzbS9hc20t ZGVmbnMuaD4KICNpbmNsdWRlIDxhc20vYWx0ZXJuYXRpdmUtYXNtLmg+Cisj aW5jbHVkZSA8YXNtL3NwZWNfY3RybF9hc20uaD4KZGlmZiAtLWdpdCBhL3hl bi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNoL3g4Ni9kb21haW4uYwpp bmRleCAzZmFiMjM2NGJlOGQuLjMwODBjZGU2MmI1YiAxMDA2NDQKLS0tIGEv eGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hlbi9hcmNoL3g4Ni9kb21h aW4uYwpAQCAtMjA5Miw3ICsyMDkyLDcgQEAgdm9pZCBjb250ZXh0X3N3aXRj aChzdHJ1Y3QgdmNwdSAqcHJldiwgc3RydWN0IHZjcHUgKm5leHQpCiAgICAg ICAgICAgICAgKi8KICAgICAgICAgICAgIGlmICggKmxhc3RfaWQgIT0gbmV4 dF9pZCApCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgd3Jtc3Js KE1TUl9QUkVEX0NNRCwgUFJFRF9DTURfSUJQQik7CisgICAgICAgICAgICAg ICAgc3BlY19jdHJsX25ld19ndWVzdF9jb250ZXh0KCk7CiAgICAgICAgICAg ICAgICAgKmxhc3RfaWQgPSBuZXh0X2lkOwogICAgICAgICAgICAgfQogICAg ICAgICB9CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMg Yi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5kZXggMTZhNTYyZDNhMTcy Li45MGQ4NmZlNWNiNDcgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9zcGVj X2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKQEAgLTgw NSw2ICs4MDUsMTQgQEAgc3RhdGljIHZvaWQgX19pbml0IGlicGJfY2FsY3Vs YXRpb25zKHZvaWQpCiAgICAgfQogCiAgICAgLyoKKyAgICAgKiBBTUQvSHln b24gQ1BVcyB0byBkYXRlIChKdW5lIDIwMjIpIGRvbid0IGZsdXNoIHRoZSB0 aGUgUkFTLiAgRnV0dXJlCisgICAgICogQ1BVcyBhcmUgZXhwZWN0ZWQgdG8g ZW51bWVyYXRlIElCUEJfUkVUIHdoZW4gdGhpcyBoYXMgYmVlbiBmaXhlZC4K KyAgICAgKiBVbnRpbCB0aGVuLCBjb3ZlciB0aGUgZGlmZmVyZW5jZSB3aXRo IHRoZSBzb2Z0d2FyZSBzZXF1ZW5jZS4KKyAgICAgKi8KKyAgICBpZiAoIGJv b3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSAmJiAhYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX0lCUEJfUkVUKSApCisgICAgICAgIHNldHVwX2ZvcmNl X2NwdV9jYXAoWDg2X0JVR19JQlBCX05PX1JFVCk7CisKKyAgICAvKgogICAg ICAqIElCUEItb24tZW50cnkgbWl0aWdhdGlvbnMgZm9yIEJyYW5jaCBUeXBl IENvbmZ1c2lvbi4KICAgICAgKgogICAgICAqIElCUEIgJiYgIUJUQ19OTyBz ZWxlY3RzIGFsbCBBTUQvSHlnb24gaGFyZHdhcmUsIG5vdCBrbm93biB0byBi ZSBzYWZlLApkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVm ZWF0dXJlcy5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5o CmluZGV4IDY3MmM5ZWUyMmJhMi4uZWNjMWJiMDk1MDVhIDEwMDY0NAotLS0g YS94ZW4vaW5jbHVkZS9hc20teDg2L2NwdWZlYXR1cmVzLmgKKysrIGIveGVu L2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5oCkBAIC00OSw2ICs0OSw3 IEBAIFhFTl9DUFVGRUFUVVJFKElCUEJfRU5UUllfSFZNLCAgICBYODZfU1lO VEgoMjkpKSAvKiBNU1JfUFJFRF9DTUQgdXNlZCBieSBYZW4gZm9yCiAjZGVm aW5lIFg4Nl9CVUdfRlBVX1BUUlMgICAgICAgICAgWDg2X0JVRyggMCkgLyog KEYpWHtTQVZFLFJTVE9SfSBkb2Vzbid0IHNhdmUvcmVzdG9yZSBGT1AvRklQ L0ZEUC4gKi8KICNkZWZpbmUgWDg2X0JVR19OVUxMX1NFRyAgICAgICAgICBY ODZfQlVHKCAxKSAvKiBOVUxMLWluZyBhIHNlbGVjdG9yIHByZXNlcnZlcyB0 aGUgYmFzZSBhbmQgbGltaXQuICovCiAjZGVmaW5lIFg4Nl9CVUdfQ0xGTFVT SF9NRkVOQ0UgICAgWDg2X0JVRyggMikgLyogTUZFTkNFIG5lZWRlZCB0byBz ZXJpYWxpc2UgQ0xGTFVTSCAqLworI2RlZmluZSBYODZfQlVHX0lCUEJfTk9f UkVUICAgICAgIFg4Nl9CVUcoIDMpIC8qIElCUEIgZG9lc24ndCBmbHVzaCB0 aGUgUlNCL1JBUyAqLwogCiAvKiBUb3RhbCBudW1iZXIgb2YgY2FwYWJpbGl0 eSB3b3JkcywgaW5jIHN5bnRoIGFuZCBidWcgd29yZHMuICovCiAjZGVmaW5l IE5DQVBJTlRTIChGU0NBUElOVFMgKyBYODZfTlJfU1lOVEggKyBYODZfTlJf QlVHKSAvKiBOIDMyLWJpdCB3b3JkcyB3b3J0aCBvZiBpbmZvICovCmRpZmYg LS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybC5oIGIveGVu L2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaAppbmRleCA5NDAzYjgxZGM3 YWYuLjZhNzdjMzkzNzg0NCAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvYXNt LXg4Ni9zcGVjX2N0cmwuaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3Nw ZWNfY3RybC5oCkBAIC02NSw2ICs2NSwyOCBAQAogdm9pZCBpbml0X3NwZWN1 bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpOwogdm9pZCBzcGVjX2N0cmxfaW5p dF9kb21haW4oc3RydWN0IGRvbWFpbiAqZCk7CiAKKy8qCisgKiBTd2l0Y2gg dG8gYSBuZXcgZ3Vlc3QgcHJlZGljdGlvbiBjb250ZXh0LgorICoKKyAqIFRo aXMgZmx1c2hlcyBhbGwgaW5kaXJlY3QgYnJhbmNoIHByZWRpY3RvcnMgKEJU QiwgUlNCL1JBUyksIHNvIGd1ZXN0IGNvZGUKKyAqIHdoaWNoIGhhcyBwcmV2 aW91c2x5IHJ1biBvbiB0aGlzIENQVSBjYW4ndCBhdHRhY2sgc3Vic2VxdWVu dCBndWVzdCBjb2RlLgorICoKKyAqIEFzIHRoaXMgZmx1c2hlcyB0aGUgUlNC L1JBUywgaXQgZGVzdHJveXMgdGhlIHByZWRpY3Rpb25zIG9mIHRoZSBjYWxs aW5nCisgKiBjb250ZXh0LiAgRm9yIGJlc3QgcGVyZm9ybWFjZSwgYXJyYW5n ZSBmb3IgdGhpcyB0byBiZSB1c2VkIHdoZW4gd2UncmUgZ29pbmcKKyAqIHRv IGp1bXAgb3V0IG9mIHRoZSBjdXJyZW50IGNvbnRleHQsIGUuZy4gd2l0aCBy ZXNldF9zdGFja19hbmRfanVtcCgpLgorICoKKyAqIEZvciBoYXJkd2FyZSB3 aGljaCBtaXMtaW1wbGVtZW50cyBJQlBCLCBmaXggdXAgYnkgZmx1c2hpbmcg dGhlIFJTQi9SQVMKKyAqIG1hbnVhbGx5LgorICovCitzdGF0aWMgYWx3YXlz X2lubGluZSB2b2lkIHNwZWNfY3RybF9uZXdfZ3Vlc3RfY29udGV4dCh2b2lk KQoreworICAgIHdybXNybChNU1JfUFJFRF9DTUQsIFBSRURfQ01EX0lCUEIp OworCisgICAgLyogKGFiKXVzZSBhbHRlcm5hdGl2ZV9pbnB1dCgpIHRvIHNw ZWNpZnkgY2xvYmJlcnMuICovCisgICAgYWx0ZXJuYXRpdmVfaW5wdXQoIiIs ICJET19PVkVSV1JJVEVfUlNCIiwgWDg2X0JVR19JQlBCX05PX1JFVCwKKyAg ICAgICAgICAgICAgICAgICAgICA6ICJyYXgiLCAicmN4Iik7Cit9CisKIGV4 dGVybiBpbnQ4X3Qgb3B0X2licGJfY3R4dF9zd2l0Y2g7CiBleHRlcm4gYm9v bCBvcHRfc3NiZDsKIGV4dGVybiBpbnQ4X3Qgb3B0X2VhZ2VyX2ZwdTsK --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Nov 08 20:07:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 20:07:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440546.694633 (Exim 4.92) (envelope-from ) id 1osUro-0000SE-MM; Tue, 08 Nov 2022 20:06:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440546.694633; Tue, 08 Nov 2022 20:06:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osUro-0000S7-JR; Tue, 08 Nov 2022 20:06:40 +0000 Received: by outflank-mailman (input) for mailman id 440546; Tue, 08 Nov 2022 20:06:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osUrn-0000Rx-Qe; Tue, 08 Nov 2022 20:06:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osUrn-0007uK-Nn; Tue, 08 Nov 2022 20:06:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osUrn-0008R1-8x; Tue, 08 Nov 2022 20:06:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osUrn-0001CJ-6w; Tue, 08 Nov 2022 20:06:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EavCFJ1JsUGISIGVL7XMRt+xL7Ju6VoJZPoq2kkRTyc=; b=2aAb3fRPuf33wAxKetkrFC5PZ8 +ikXsw1BJNyL3JkVhSu8rK1YnhegIyNjWyDs64fn7EIXcBYucULoAcwgc0lwto4ohVmoddpuUv33H 11z37Bjopbv9rYLyLR3Lz7bneeQY6FSzVZkwlqzGB4XyQyT8sALMF/QlMq0OEIlPs7uU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174670: regressions - FAIL X-Osstest-Failures: xen-unstable:build-arm64-pvops:kernel-build:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:xen-boot:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e61a78981364925a43c9cc24dc77b62ff7b93c9f X-Osstest-Versions-That: xen=e61a78981364925a43c9cc24dc77b62ff7b93c9f From: osstest service owner Date: Tue, 08 Nov 2022 20:06:39 +0000 flight 174670 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174670/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 174663 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174663 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 8 xen-boot fail in 174663 blocked in 174670 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 174663 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 174663 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 174663 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 174663 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 174663 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 174663 never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 174663 never pass test-arm64-arm64-xl 15 migrate-support-check fail in 174663 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 174663 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 174663 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 174663 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 174663 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 174663 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 174663 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 174663 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 174663 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174663 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174663 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174663 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174663 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174663 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174663 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174663 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174663 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174663 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174663 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174663 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174663 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen e61a78981364925a43c9cc24dc77b62ff7b93c9f baseline version: xen e61a78981364925a43c9cc24dc77b62ff7b93c9f Last test of basis 174670 2022-11-08 09:26:56 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Nov 08 20:37:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 20:37:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440556.694647 (Exim 4.92) (envelope-from ) id 1osVL3-0004am-6W; Tue, 08 Nov 2022 20:36:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440556.694647; Tue, 08 Nov 2022 20:36:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osVL3-0004af-3X; Tue, 08 Nov 2022 20:36:53 +0000 Received: by outflank-mailman (input) for mailman id 440556; Tue, 08 Nov 2022 20:36:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osVL2-0004aV-1n; Tue, 08 Nov 2022 20:36:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osVL2-00008M-06; Tue, 08 Nov 2022 20:36:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osVL1-0001wv-J6; Tue, 08 Nov 2022 20:36:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osVL1-0008CE-IX; Tue, 08 Nov 2022 20:36:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Jhk0BqfbPJeWspAUxiZ3/fY7GJEPtRlHWDsdkCGXK/U=; b=EzqP6DeqB2Q6cd+HWPFErrklT4 F9RbDftwMJvwaEVFRUsTLw4Mc6x8vTqmFtoMMUyRzwWiIFYcQVY+jB+duUcX4ZeD8sovqikf55rGI VHj84YinSPww4JftDRV562lCl98XJ9sd8X0NwNY43FJ/IoaknVMEl3gLlthw5bfwK9dk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174673: all pass - PUSHED X-Osstest-Versions-This: ovmf=6c1a4a376e97800c555dab9ca9d9651a5676d231 X-Osstest-Versions-That: ovmf=50bee4cc121aacc67f40b6c5ee0c71d3879dcc41 From: osstest service owner Date: Tue, 08 Nov 2022 20:36:51 +0000 flight 174673 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174673/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6c1a4a376e97800c555dab9ca9d9651a5676d231 baseline version: ovmf 50bee4cc121aacc67f40b6c5ee0c71d3879dcc41 Last test of basis 174666 2022-11-08 03:42:06 Z 0 days Testing same since 174673 2022-11-08 15:40:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 50bee4cc12..6c1a4a376e 6c1a4a376e97800c555dab9ca9d9651a5676d231 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Nov 08 22:54:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Nov 2022 22:54:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440568.694657 (Exim 4.92) (envelope-from ) id 1osXUN-0004XQ-2v; Tue, 08 Nov 2022 22:54:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440568.694657; Tue, 08 Nov 2022 22:54:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osXUN-0004XJ-0H; Tue, 08 Nov 2022 22:54:39 +0000 Received: by outflank-mailman (input) for mailman id 440568; Tue, 08 Nov 2022 22:54:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osXUL-0004X9-0Y; Tue, 08 Nov 2022 22:54:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osXUK-000378-Ud; Tue, 08 Nov 2022 22:54:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osXUK-0000wI-K6; Tue, 08 Nov 2022 22:54:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osXUK-00073b-JR; Tue, 08 Nov 2022 22:54:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9WplA5p+gMw4wbm2/MZAD97ENmfyFlyoiNgwJE81zvs=; b=QDgjdkZTp/x0uwq/+DpsgbXbd/ imuv7zXKPiv5YA1IBu3WHmehpDdb0jxe145cjLvLo7jQfQS+Vy9B8OjLRBGsrvCGbU/d0sfT2CD4N gUWW6Gbjh9v6ugAvp4ZK219+ulivMqVnXJeGKLHiO1XQqG1FRuL/oaucLeDOqCMq+keQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174679: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2b27967fb89d7904a1571a2fb963b1c9cac548db X-Osstest-Versions-That: xen=e61a78981364925a43c9cc24dc77b62ff7b93c9f From: osstest service owner Date: Tue, 08 Nov 2022 22:54:36 +0000 flight 174679 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174679/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 2b27967fb89d7904a1571a2fb963b1c9cac548db baseline version: xen e61a78981364925a43c9cc24dc77b62ff7b93c9f Last test of basis 174661 2022-11-07 19:00:39 Z 1 days Testing same since 174679 2022-11-08 19:02:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e61a789813..2b27967fb8 2b27967fb89d7904a1571a2fb963b1c9cac548db -> smoke From xen-devel-bounces@lists.xenproject.org Wed Nov 09 02:13:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 02:13:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440603.694669 (Exim 4.92) (envelope-from ) id 1osaa2-0002oJ-Nr; Wed, 09 Nov 2022 02:12:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440603.694669; Wed, 09 Nov 2022 02:12:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osaa2-0002nt-IY; Wed, 09 Nov 2022 02:12:42 +0000 Received: by outflank-mailman (input) for mailman id 440603; Wed, 09 Nov 2022 02:12:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osaa1-0002nj-5a; Wed, 09 Nov 2022 02:12:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osaa0-0006hU-SR; Wed, 09 Nov 2022 02:12:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osaa0-0005Bh-CR; Wed, 09 Nov 2022 02:12:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osaa0-0004pw-AE; Wed, 09 Nov 2022 02:12:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GWyGf4u31g1h2ruNmeQuQ27IwccRqcxQ8cxaDHIZnsc=; b=NAGUhT/efQOWVBylrdPIfmgeZd 6Sz3kUXaIftEntyvMYMcjU1YX/+Ov8MgJZ1nhIAsm5m6RiPITVQmrKRJu4PlVPEq/UJ9JnEQ/1pPd ogUUnnkuTRL1WWfqnDb4/W3JRLZidqEbVnEcb46pXDRqp7sZNB93iBullTb/0dcS4CAE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174671: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=59f2f4b8a757412fce372f6d0767bdb55da127a8 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 09 Nov 2022 02:12:40 +0000 flight 174671 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174671/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 59f2f4b8a757412fce372f6d0767bdb55da127a8 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 32 days Failing since 173470 2022-10-08 06:21:34 Z 31 days 51 attempts Testing same since 174664 2022-11-08 02:40:00 Z 0 days 2 attempts ------------------------------------------------------------ 1602 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 152697 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Nov 09 02:36:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 02:36:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440611.694679 (Exim 4.92) (envelope-from ) id 1osawT-00064b-FS; Wed, 09 Nov 2022 02:35:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440611.694679; Wed, 09 Nov 2022 02:35:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osawT-00064U-Cm; Wed, 09 Nov 2022 02:35:53 +0000 Received: by outflank-mailman (input) for mailman id 440611; Wed, 09 Nov 2022 02:35:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osawS-00064O-P8 for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 02:35:52 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2045.outbound.protection.outlook.com [40.107.103.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 388d945d-5fd7-11ed-8fd1-01056ac49cbb; Wed, 09 Nov 2022 03:35:50 +0100 (CET) Received: from DBBPR09CA0033.eurprd09.prod.outlook.com (2603:10a6:10:d4::21) by DB8PR08MB5449.eurprd08.prod.outlook.com (2603:10a6:10:119::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 02:35:46 +0000 Received: from DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:d4:cafe::fa) by DBBPR09CA0033.outlook.office365.com (2603:10a6:10:d4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 02:35:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT034.mail.protection.outlook.com (100.127.142.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 02:35:45 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Wed, 09 Nov 2022 02:35:45 +0000 Received: from e1080965f20a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 657A226F-01EE-4F2D-9205-DA193847025C.1; Wed, 09 Nov 2022 02:35:39 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e1080965f20a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 02:35:38 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAXPR08MB7492.eurprd08.prod.outlook.com (2603:10a6:102:2b5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 02:35:35 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Wed, 9 Nov 2022 02:35:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 388d945d-5fd7-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DFrpZ7X+7ei3k43EZdSxzjWTozzt4eYHq7tkG/P11uQw51dmkxIvzwkqS0TF4BzZ0FSp3q9qXgJ5tFnhdlLe7gA2V8vq9ZSzJiqyLOYgVNjfLyFSnPV8ZE6vDG4SxFYxaTEX4tqvLIzdohjtxk6VlNNZmzVVBeZ01gGPGmxNH0kzi/J6phr3Odv3HrjOZTh2ShaxVqWVhFbLOnWZr/+t5bfYBOgDNVp9r9hKFnquYm8cMV15vBfbCo4AIBlrDuw2eSBBvGA/86RGwyr0xgMg7P+5A1+iUNiyzsmG4J1kyYpMDeLiQTqo8Dyz1Tah4qHkDkobjZzYngFZLJKGOzDqjw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B3PC/o3TYLsJajZKfUkhte9Cid8AxmWRBmAkZviQDOM=; b=dzm+Oq1Bd0HleQmQ73WmrhOVKh4yDO9qqMOavpWMKvDT7FQd6zEGA/eUvVGFWnbdg3lg9IBFQAyT3epM/0yKN/k9/l8AA9aONHmh/Wx03g7BGff76gz9h+nuFeBwF8YXI7F0xo8AyszTJXwoFr6za/JxEE409HpK/TCBSLUArTQ4tggQAPM2ZmRD9S2Cifp8JiRash3d7G57U14KmWfi2ZoOhXhFMSsqG6kpVnbpPc2CXyq7aBql6QEH7PuaCY/rtgxh/Cv1No5bnlftzvqibPq322XJ65T7ST0O47GPwwJFoeQzoj7nvHHcZXqrCU9t7FTSO5J3GDwDyeOmXW2RVQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B3PC/o3TYLsJajZKfUkhte9Cid8AxmWRBmAkZviQDOM=; b=5k4CxVL4TCA86ugm6Yb8kLhwZI/hnlgtG/Dklg0QV7HtCbXYah/Th3n+eM+xjoSFbt68ICsOJ46+8Cr4lhltt1JlEmOtBEZMN8f5+vDJrncdDQ/BlpicxnKVFqH+J+dEC4O+w6i2+zpNwovafhFQqbQ9nU7fgFqIElN0RzeQSc8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F0EaeH9WSV0kfVZhYpwlDZyzQqRCTvSc4N50As6qg30JP6RErxHAcjqBxPDuCDEKwOSb6wCeK+BEm/idEm3er5kW8fb6tKWomPs54fpAnYAXQ196HcvUf9FFoGAPD6CSSETnMQIb8TSNeBXZGUYk21osPOs4eTU6AMDyvsrZ/byG+jVd4YXvrZFw49sE9xvCziDCIz5Rh1xigl0xT1AFN5pmpBXjzua3eAzeJP1ch1aNn21Ie3TAS6bbOg8/cXcXtBTnu4MBhADemN2/ZmHpzdeWnCcTIgUY7lNCl02rRwgK0VgWJ3pVordOZ9pN7XaKKElntVdomIxy+MwFrqoEUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B3PC/o3TYLsJajZKfUkhte9Cid8AxmWRBmAkZviQDOM=; b=C02QUTcBYi+/SDd/mreSh551czKUY9Am0oXXp1z7HMuRfxWmkMqkqNiLYjPI/QzwcYcm6RwKtvTPvNG5/pCfg8BRJI2E2ApN7wDzr6qOe/9B4TasYmMUd3TvLYF07g/btNVM6n0rUAS9GPnFUjUH8Q8lWtlsTQqTpAj0H9nhA8kyMLIrtfAYVIJleGLgb2XjqA4I2u/geKH0ugw1FWCMbty0mHXmx2/H2t5vbQq0IASEdElwQiIlwicybWxJXgT7Qd+k3mBp08mIPW1eaiCR+RFLgm3Oo2I/pd0kMttPXaZWQrpQEyNmqYflE/gS36kMCSHOxewkaI6lIGUxUVPtQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B3PC/o3TYLsJajZKfUkhte9Cid8AxmWRBmAkZviQDOM=; b=5k4CxVL4TCA86ugm6Yb8kLhwZI/hnlgtG/Dklg0QV7HtCbXYah/Th3n+eM+xjoSFbt68ICsOJ46+8Cr4lhltt1JlEmOtBEZMN8f5+vDJrncdDQ/BlpicxnKVFqH+J+dEC4O+w6i2+zpNwovafhFQqbQ9nU7fgFqIElN0RzeQSc8= From: Henry Wang To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: "ray.huang@amd.com" , "Alexander.Deucher@amd.com" , Jan Beulich , Andrew Cooper , Wei Liu Subject: RE: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present Thread-Topic: [PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present Thread-Index: AQHY83nT6azBcos0i0+auAh9IXa2Rq413yzQ Date: Wed, 9 Nov 2022 02:35:35 +0000 Message-ID: References: <20221108135516.62775-1-roger.pau@citrix.com> In-Reply-To: <20221108135516.62775-1-roger.pau@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F03A06513AD16B40A072888DE2B235A8.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAXPR08MB7492:EE_|DBAEUR03FT034:EE_|DB8PR08MB5449:EE_ X-MS-Office365-Filtering-Correlation-Id: bf8f1234-16f4-4f3f-3b07-08dac1fb1ae1 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NPW7iXePIuq8Hy9Kbdv78GgXDyz8q/YRdwKR1Oor/RTKvu+oqRW/pv436IzdRv/aCYqGZ3gJAtgeR5ZCP+Tgia/0GJxDak50e5H7h+FAJWJKcI/cplxWjSkGchh4xf2yogr/JjHBC8sYhv2mNk6nsiV3UZnbB24ygRqa0dmOHdRleRbEoKAZo/JML7/txG76I9C8BVbe+HKjOP1LdnF10rQ9OyUOWnHyQ17ShCuPgNmlQPpZM9aM19/ybvtAGrCq9DSgmxKhUm7z8RrPOsj0zXtJZgO7m9rfGrtaDrXJn6Ol18La3G0PIxWx2KxGddxSrUwd/N2KPvEQ1qUUceQm/KQwcHfuRZnS7a07D88fFTMwDZs2LNnAUUrCIEE3cy+kNLcY4SQqFpT8zyDKVkJno9u6fEm5yGgX/vOumoRE91Xofp0ljZJJDESW6JP3MLSoBciWxTOnJ7FwG+W8Og774LZD1oufHjo1ibioxx8SRqzyr/BuqWVllG6XDlnsoFr5gDwRRc7esNsCMUiGJE4RlHP6opyMTMFtAOOtEqpw6OiwrWGYhaZtaBAR3UeZjgX3Nzeq2JLutpvccRlffhFM+2lHaAy0vz08RKk+tS+hDSUQb4UevlOpMlosP+eDFIIt1vOIgPLKIyr/1GS+0hwkejDt6g96pmN4wXaTex6uWASYlaqKKu2dkBHLa50iFbDZd9bNXQq8F4xeB4JygundidHaQCpCu1X41Qu1GP2B6SUD0ifTntoQcaNyUxwJLiH4UJHEYlvav0RECqyLMI4XmA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(451199015)(6506007)(7696005)(9686003)(26005)(54906003)(110136005)(38070700005)(478600001)(71200400001)(86362001)(55016003)(38100700002)(33656002)(122000001)(186003)(2906002)(83380400001)(316002)(52536014)(8936002)(5660300002)(76116006)(4326008)(8676002)(64756008)(66946007)(66446008)(66476007)(66556008)(41300700001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7492 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4d6ee5ad-2fa6-40ed-22a9-08dac1fb14a7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dobK+CkhHDaUzlX1jgg0mSO689w1K+TDSIkjNScBjpGtae7tkAWvZUgzq/h6eCQCoKtTd18k72uFfQ/Y2BVQKRKtsgYPS5HnwJ2BseatvJ0irooP1tn97fGcPeQLA1wNV1fu3/uebYKeqaUgSrwPy5upBja7NB1LML7NOQGKzHKkR/cnEzmj6ADf4LBymLMJQm+2IvoZYUeepk2WtWe0JqVWLREGhvICD963fOAaPjb3RTfoYXvUoJh0RI2pEXnFwIamj6EJrd3Dnw1c/tzBR99iTw9YnZjc7dYu6uDFIy3tu+/IjS0mOvMvykhN6qMxXpf9MFvua65lb/89UBxp1l6z3bfLcgUoTV4NBUHtNihbhhYZWeG13TTMKACmqrNe0V/bXmkryZiYpIVicsEIbfqLIWZHj5tdlXkobwuWbcuTIMaaTdi3h6DeiOO3Of+Korg4p3JDKPwQnFS79y250AuJifIcc5I3w7ejWunw/9Tbc8L6WwOEPEcDiE/IhUf7uAlrrLsb1O10qhWhNQO7sL8n5uGDMht1feuCzwoE0A8u0zkooHSz4P4dn4rxUaX3gDRgjZWGTLan91X28hj490jJ5fBw0fMgbO5fHV5Ckx71SjMmUPZf+MYiua1P3TaTtFhEAvLEWiQutcF4hCrX6u09qqA4e2keElLHoxoJ89ELFFlPxjsSLRX/P7ulP/Ri/R9zDt++Mc7LW8xFchpOmJ3+x+9TOzcERPkA8aiQWG5nocxzgdVDrC89vPXTa8nzYw5+H5RMVimuTHjsPMsW2A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199015)(40470700004)(46966006)(36840700001)(82740400003)(33656002)(55016003)(81166007)(478600001)(356005)(82310400005)(83380400001)(36860700001)(86362001)(40460700003)(2906002)(186003)(336012)(47076005)(6506007)(7696005)(9686003)(8936002)(40480700001)(70206006)(52536014)(5660300002)(316002)(26005)(54906003)(41300700001)(8676002)(4326008)(70586007)(110136005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 02:35:45.8110 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bf8f1234-16f4-4f3f-3b07-08dac1fb1ae1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5449 SGkgUm9nZXIsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gU3ViamVjdDogW1BB VENIIGZvci00LjE3P10geDg2L3B2aDogcmVwb3J0IEFDUEkgVkZDVCB0YWJsZSB0byBkb20wIGlm DQo+IHByZXNlbnQNCj4gDQo+IFRoZSBWRkNUIEFDUEkgdGFibGUgaXMgdXNlZCBieSBBTUQgR1BV cyB0byBleHBvc2UgdGhlIHZiaW9zIFJPTSBpbWFnZQ0KPiBmcm9tIHRoZSBmaXJtd2FyZSBpbnN0 ZWFkIG9mIGRvaW5nIGl0IG9uIHRoZSBQQ0kgUk9NIG9uIHRoZSBwaHlzaWNhbA0KPiBkZXZpY2Uu DQo+IA0KPiBBcyBzdWNoLCB0aGlzIG5lZWRzIHRvIGJlIGF2YWlsYWJsZSBmb3IgUFZIIGRvbTAg dG8gYWNjZXNzLCBvciBlbHNlDQo+IHRoZSBHUFUgd29uJ3Qgd29yay4NCj4gDQo+IFJlcG9ydGVk LWJ5OiBIdWFuZyBSdWkgPHJheS5odWFuZ0BhbWQuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBSb2dl ciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gLS0tDQo+IFRoaXMgaXMgYSBi dWdmaXgsIGJ1dCBnaXZlbiBQVkggZG9tMCBpcyBzdGlsbCBleHBlcmltZW50YWwgSSdtIG5vdA0K PiBzdXJlIGl0IHdvdWxkIHF1YWxpZnkgZm9yIHRoZSByZWxlYXNlLiAgT1RPSCBiZWluZyBleHBl cmltZW50YWwgbWVhbnMNCj4gdGhlcmUgYXJlIG5vIGd1YXJhbnRlZXMgaXQgd2lsbCB3b3JrLCBz byB0aGUgY2hhbmdlIGlzIHVubGlrZWx5IHRvDQo+IG1ha2UgdGhpcyBhbnkgd29yc2UuDQoNCkZv bGxvd2luZyB0aGUgZGlzY3Vzc2lvbiBpbiB0aGlzIHRocmVhZCwgSSB0aGluayB0aGlzIGlzIGEg c2ltcGxlIGVub3VnaA0KcGF0Y2ggd2l0aCBiaWcgZW5vdWdoIGJlbmVmaXQgZ2l2ZW4gUmF5IGhh cyBhbHJlYWR5IHRlc3RlZCB0aGUgcGF0Y2guDQpJIHdvdWxkbid0IGJsb2NrIHRoaXMgcGF0Y2gg Zm9yIDQuMTcgcmVsZWFzZSwgYnV0IHdlIG5lZWQgdG8gbWFrZSBzdXJlDQpKYW4gKHRoZSBBQ1BJ IG1haW50YWluZXIpIGlzIGhhcHB5IHdpdGggdGhlIFZGQ1QgdGFibGUgaW5mb3JtYXRpb24gaW4N CmNvbW1pdCBtZXNzYWdlLiBUaGVuIGZlZWwgZnJlZSB0byBhZGQgbXk6DQoNClJlbGVhc2UtYWNr ZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4NCg0KS2luZCByZWdhcmRzLA0K SGVucnkNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 09 02:40:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 02:40:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440617.694691 (Exim 4.92) (envelope-from ) id 1osb12-0007Rx-1k; Wed, 09 Nov 2022 02:40:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440617.694691; Wed, 09 Nov 2022 02:40:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osb11-0007Rq-Us; Wed, 09 Nov 2022 02:40:35 +0000 Received: by outflank-mailman (input) for mailman id 440617; Wed, 09 Nov 2022 02:40:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osb11-0007Rk-2D for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 02:40:35 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140075.outbound.protection.outlook.com [40.107.14.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e22d79b4-5fd7-11ed-8fd1-01056ac49cbb; Wed, 09 Nov 2022 03:40:34 +0100 (CET) Received: from AM5PR0101CA0020.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::33) by DB9PR08MB7795.eurprd08.prod.outlook.com (2603:10a6:10:39a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 02:40:27 +0000 Received: from AM7EUR03FT065.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:16:cafe::8c) by AM5PR0101CA0020.outlook.office365.com (2603:10a6:206:16::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend Transport; Wed, 9 Nov 2022 02:40:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT065.mail.protection.outlook.com (100.127.140.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 02:40:26 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Wed, 09 Nov 2022 02:40:26 +0000 Received: from 016564294f8e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1930152C-5CC7-42F7-9049-ED83C1A3C542.1; Wed, 09 Nov 2022 02:40:20 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 016564294f8e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 02:40:20 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM8PR08MB6548.eurprd08.prod.outlook.com (2603:10a6:20b:314::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 02:40:18 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Wed, 9 Nov 2022 02:40:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e22d79b4-5fd7-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CKD31KUqimQmyA0Nt2ggGzAFw8oGtnhJXhkjhQlW33IaBRc49yh88Et6hKDu9nNESV4DHZChSE0jqL8Drf9I1RPES5mvKFE+URmSuYLmRArNLECK28qlcwVp/HzVJzOhpBWxWNRjlwSxp7ShOXwTfG2eDIYmN8Jl/NkGn7IDtlvJKXmIJu8wC6sm+WUuwdFPrtPhUdByRWCgJihDFnPBCkRxPZH+IJ6zhtItKYAkX3fy6RX8unbiuxESWNf+FIylagR/oz3LG8nKwcjH8IkofoOWsAurMr2LfUFq23DyKrHm47ANyT/+Cz4uFd5/euBb974lLd811ntIJXaKj8Q1pg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rJI9kTwRBOa/c1sY7fIKdF6hTs3hnFzn34HhwC6tq5Y=; b=mDtBzsEKOPoQP0v9uMEBqjzjoTrPnCGot7xNza639gRv9PGBSAPWMuD3r5el+iZR0tW/24XZrAPwoWT1+GroQ9YHgWOzyidTnB3cEA+RlIBfzqCzy5Wr1c+KdLfRzknAK+FyJsMcUBDosavLpwPoUz7uEIk2WIC0Gjx4wk6ANk8kJ1WyFZChgDxtSeY3QbUG0Zb9h4IyJ3LFJ+sDp6gdUzGMPWVsKObw+NqUqZrxmJ+H3E/evC8aY7fAmsAgeWv+6yMsmv3TdbEjr07QXSBlK0z3EV7puTX6dIxE2VuBO6QYdLMV0xuZQJblYWuK4DTwtl58CLf9RpplCaU5aLhCDQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rJI9kTwRBOa/c1sY7fIKdF6hTs3hnFzn34HhwC6tq5Y=; b=q5fo54DI+1dXMFkhvRuWzzYQCbuBJuDo4yqv8omb+2D4Ry931MR7OpMI04qT0JbtHdu7wVEY7YDuEpA0f0taQNf5UCRt148xEcZ5VEULRwNqwlkYcsypEfYeRivlZD4XmWrTPQz8Qe+XbLKURw7GcXlRCC4tLB/WAssFlR1Fp6M= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NJ4n6I370mGS7LjR7McsApYWYI3mMcPdnYqTnIZXR8jCgTSOuqGYNmIbB0WNcH3ozVXQdBuWjr50xtX7BXMYCYyMXpKRwWwmkqCb7fawCJMrID0wqnPyQv0R5krHXyFhziN/tWRk9QKoMx6c5m981pXdXxMz5os4rS7Bv1gptyrN0QLP1zcH5OG3kVFcOHu/1vf6FXt0gsEtjzelDGJD9aOicP2OWC/4W/QhrN1C5lczu1xraeOGLwZL9tAxvQBlCyOqPOOZ8wHEEGE+L8+nIjFmBprXo8rzzHTQJ8uPensi5SD9RJUf9NMg9WTsxLuP2sJavPSeQsAlfsmzSwAe3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rJI9kTwRBOa/c1sY7fIKdF6hTs3hnFzn34HhwC6tq5Y=; b=Me5gMhsLBdN6Dz9oI4jU9noY8VhiHAPW5hSTNxITZFBq0nhtO0irBhsnWK1SQkX0o++Z17Hpipp6hVh+S9r1qYyQvExg2zQKCX+S9JPjhdAjdfX7ZZ/U12tc/OnHdjIqg/Yh0yFaBbdfusY7JIE0bKQvuKdLlgDMzpxU7ur55XPJN9sjcZXSFOOZ0hdM5u4/znZ//4/s+bPFlXDn4Wch+GKhzl7Dirn0QwhYcOSD3FvCkKmwDRzAjMVWP++dDj7lW11K4SpjCkQhXfuqb7NFHHwA9ZT2q+EWvwBaW+q3J24l/TrgkAwGDq/ppv8K858gVuf/4QpfGqBGQ/3jaLEp7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rJI9kTwRBOa/c1sY7fIKdF6hTs3hnFzn34HhwC6tq5Y=; b=q5fo54DI+1dXMFkhvRuWzzYQCbuBJuDo4yqv8omb+2D4Ry931MR7OpMI04qT0JbtHdu7wVEY7YDuEpA0f0taQNf5UCRt148xEcZ5VEULRwNqwlkYcsypEfYeRivlZD4XmWrTPQz8Qe+XbLKURw7GcXlRCC4tLB/WAssFlR1Fp6M= From: Henry Wang To: Julien Grall , =?utf-8?B?RWR3aW4gVMO2csO2aw==?= , "xen-devel@lists.xenproject.org" CC: Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: RE: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Index: AQHY84e5FV9zwZ/cMEqESsIC5Hbn0K41MEgAgACxXpA= Date: Wed, 9 Nov 2022 02:40:17 +0000 Message-ID: References: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> In-Reply-To: <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: FABCEC546D4CED489194825FA131F47A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM8PR08MB6548:EE_|AM7EUR03FT065:EE_|DB9PR08MB7795:EE_ X-MS-Office365-Filtering-Correlation-Id: d56acc4f-2ac2-4343-1ef0-08dac1fbc273 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kQUwOWfPRv3D4vJ+jJlRxHzEE7HLczTlswDfwXXrGoaFSU2pXHPQjvBXzqt00PLETApZg7EKEJyxRBOscfLQ9vwq9eslfQuqdFMYmPNXsopjXbFpVX92yYeChiwuB0ElFgZnxSMeJ+26aKgRWlWxOIVLFqovsM23CATAquaroPnlz/3phBkVIcw0DNZYK8XiLia+YwPj79rLD3MDNbR7JbOI2J0xLgBGTfTE0frrUTpDdcopg9Bi3YmN1DgSs3lJ6a9IULWmHTfo2y0s5am/Nj6qgnLw+CmJsYzmbyQgRI/9yTiHgGN8U2xXX2BwLGya3X9MoILGUeoiGTGyKCdPkV+N7wojiqDUK/MDl+I5N0HmwBUThCuCys24fvj2I6CBUVH6nV09ugNZqAGhjVd0iho4ZGJ23Pv5wRIsWBsGLYsyYPcs9IN3bH4x06aASsTS0xeZUpv1kI8W2pxuTzFYVYG7hCyol1Gf+cbkjQTlcBK5Gt0l+XcThxdySA6l3m304aq0UIzxajSOyr145eoxHIHByJsvnWUKzpV2aGtYuHImxn+vtAky7wlIBZtR941J2k3y15DGAWwQLq8WoMksEemOh8p+DBxeqOTvqphs3y6oXw6QxJ0HuEaHCKAjGMnmc5hwWZ34MjRGYNbpsBsEOqttMJkFuS2nne7iNyJ8o9P3A0wBBg5tNINcSJhr/hK8bASX+V10DCZix70B2c7nwwUIndQ3TnRnafWL85uSKpumWgdJkY2Wlf9DoSZrXUh6CbugX33NTHiCdS14BwNWkA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(39860400002)(136003)(366004)(451199015)(66446008)(64756008)(2906002)(8676002)(4326008)(66946007)(66476007)(66556008)(83380400001)(76116006)(6506007)(7696005)(55016003)(478600001)(86362001)(71200400001)(186003)(9686003)(26005)(33656002)(316002)(38070700005)(110136005)(54906003)(5660300002)(8936002)(38100700002)(122000001)(4744005)(52536014)(41300700001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6548 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b74bfc64-8d03-438f-ddad-08dac1fbbcef X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: endbpIX433XYtyxxEaVjKAkSqD+A/rGfJmPwOE+2OrBRPpoVzsHhu0eHAabs3vYt4zYMUFYFXBtwE+XEQZl/7Ew+NRqcUtn8QzdHOQ/B7Oeu7iroFCOhVIV2o7CN9vsm7UfkhISrnzHdfUzax9lDN0lg+GmtifAGwY7Yx8wVKxgjqG9uTIjIjIbWMYqJevsHnuAz/ut83p2Q6wJZx3oMLrOxMFQ4z0F0kkn4wSXBJRMHgBpaDpma2kPY3/lv/J+9ipIKLTa7Is1/OAvWzFquaBsi1fpV9dIG0SnfcKogse8l5NrTske6rTc4y0NfMCQB1ifeNQDqUjHl6CNmmDZC+cAiOfvOupugiDxsrojj4lbAl0j57N6VeAL7jRl1tSaP7wsuJcfHH78iwVWYG6gJSdydHpOggaOzOqVMsB2dOlKrERYHqsg2tJ4Zcaym59Rx8dAvEy5mH2EzPhLanNYTxBSBhp2WQwRdYZYhy1VpAoRK6n0ZStryUaZmQ/fLONIZirPblTu54xoFzhrIqK9n4aKOK4KBGZTZdOnbSfCc1vVooz/D/slEllVlihm3qu6qdQg8Z29PNQvU5zj0u7DLS3K0gprMeLgaVUqL3XoZLJhU8cGFv/bFY9V67HZvacyRenWHO1f2lD6YZuJMFlfW3AhvswRP13tUK7m7fIS4RiCeY4Bw06/UX/tFgL0WHft0JNlN0cOl7QEc+8pkbWfFXEMV3Q4DXGk0UafAZFbuE1m4kxn2fedODuUvSc5S4mSvl+Nn01q/Hw3EQVVkvFxsWw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(136003)(346002)(396003)(451199015)(46966006)(40470700004)(36840700001)(86362001)(54906003)(186003)(82740400003)(6506007)(107886003)(110136005)(9686003)(33656002)(26005)(47076005)(336012)(316002)(7696005)(8936002)(2906002)(40460700003)(356005)(81166007)(41300700001)(5660300002)(70206006)(70586007)(4744005)(36860700001)(52536014)(55016003)(83380400001)(8676002)(4326008)(40480700001)(82310400005)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 02:40:26.8998 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d56acc4f-2ac2-4343-1ef0-08dac1fbc273 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7795 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggZm9yLTQuMTcg djMgMDcvMTVdIENPRElOR19TVFlMRSh0b29scy9vY2FtbCk6IGFkZA0KPiAnbWFrZSBmb3JtYXQn IGFuZCByZW1vdmUgdGFicw0KPiBXaGlsZSBJIHVuZGVyc3RhbmQgdGhlIGdvYWwgYW5kIHN1cHBv cnQsIHRoaXMgc2VlbXMgdG8gYmUgYSBiaXQgdG9vIGxhdGUNCj4gdG8gZG8gaXQgaW4gWGVuIDQu MTcgKHdlIGFyZSBvbmx5IGEgY291cGxlIG9mIHdlZWtzIGF3YXkpLiBBdCB0aGlzIHN0YWdlDQo+ IG9mIHRoZSByZWxlYXNlIHdlIHNob3VsZCBvbmx5IGRvIGJ1ZyBmaXguDQo+IA0KPiBUaGlzIGlz IGNsZWFybHkgb25seSBhIGNvbWVzbWV0aWMgY2hhbmdlIGFuZCB0aGVyZSBJIHdvdWxkIGFyZ3Vl IHRoaXMNCj4gc2hvdWxkIGJlIGRlZmVycmVkIHRvIDQuMTguIFRoYXQgc2FpZCB0aGUgbGFzdCBj YWxsIGlzIGZyb20gdGhlIFJNLg0KDQpJIGFncmVlIHdpdGggeW91ciBwb2ludC4gSSB0aGluayBt YXliZSBkZWZlciB0aGUgcGF0Y2ggdG8gNC4xOCBpcyBiZXR0ZXIsDQpnaXZlbiB0aGUgZGVlcCBm cmVlemUgc3RhdGUgd2UgYXJlIGN1cnJlbnRseSBpbi4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkN Cg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 09 02:48:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 02:48:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440624.694702 (Exim 4.92) (envelope-from ) id 1osb8M-0008Rq-VN; Wed, 09 Nov 2022 02:48:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440624.694702; Wed, 09 Nov 2022 02:48:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osb8M-0008Rj-RS; Wed, 09 Nov 2022 02:48:10 +0000 Received: by outflank-mailman (input) for mailman id 440624; Wed, 09 Nov 2022 02:48:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osb8L-0008Rd-JB for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 02:48:09 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2069.outbound.protection.outlook.com [40.107.247.69]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f0d4f66f-5fd8-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 03:48:08 +0100 (CET) Received: from AS9PR01CA0018.eurprd01.prod.exchangelabs.com (2603:10a6:20b:540::20) by AS8PR08MB6551.eurprd08.prod.outlook.com (2603:10a6:20b:319::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 02:48:03 +0000 Received: from AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:540:cafe::d3) by AS9PR01CA0018.outlook.office365.com (2603:10a6:20b:540::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 02:48:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT020.mail.protection.outlook.com (100.127.140.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 02:48:02 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Wed, 09 Nov 2022 02:48:02 +0000 Received: from f68b50a4306a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 49AA2766-425D-48E4-8EC0-2FD9473C0E4E.1; Wed, 09 Nov 2022 02:47:56 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f68b50a4306a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 02:47:56 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB6085.eurprd08.prod.outlook.com (2603:10a6:20b:294::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 02:47:54 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Wed, 9 Nov 2022 02:47:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0d4f66f-5fd8-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LETvaTxB1qkAI2QcEB7RhW41jNKP0pTp7h0jMSqzfX/RUHn3PpLMl8NQXuPIzZye7TBwXHV0JAMm6ahfti+ClfylbuGT5+iBnOJBKVyE6igK3Ed5khGJUKi/nWejD5I2v21Q65k+Vudg51DyaGcMMuenXZKykic05qr/PI9yHnAWQLOOFbMHAfB7Vw0okO/TdIc3iScFZA2v3+Fh2PIwoUNivaPv5U2sg1Zs41LeRljmLoJlI3pcsKGVNkvlTX2dPsG9TR8anVI0lbU61U2HBph7MJnElmtho5Xy/7iTg1/t+mmgSNfLGyfJpoPeWaL7CZ9lc73+sTuThnKYWCexug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9qlAgcfp8B8U8Fub1fPIWg/kuXk9QLyoBXzikwze/P0=; b=bXFrS2dEH9AP/0jd++2y4bM8Mvwtc6ua8yv50y2PmCML9ls5AUoKLEspY//dNWDxIvql35eCsck6LFdqUedtOHU59arHJUizMJ11pwMlstSm502Q+V710+rNB6URcaZwfsZ5fS1FOjW6nBhmoxBCIzJUdbV579NnOEvSKr+o9Qh1h5qsz1e8UfzVosU8zPHxypu+LuROgF4zeQ3o5YKu3w078EnC3qzC1EtmK2G82VaBj0BZrBhY1BrYVv8ijw3jcDbqwg30DEDZFtp4JIVL33e2CvqVhTFjA92JN1n6C/UJPzW/ZpTiqqvVrktVi55zjnsAH2hqPjzy3QBjgTOtSw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9qlAgcfp8B8U8Fub1fPIWg/kuXk9QLyoBXzikwze/P0=; b=NOJi+VReJ5p7INMlqQd2W//x0fsII1lHEdhDiQTEofsW4skDQ5Rm1W3BJRsMf5xnPXjqr0zm/QXt7rTXUDQpf8UZUbVYo0hNaf3t3k4k01m8xijxy7/E8nokVRatUHeLgkxfJrKQA/O1XhWVEVPv7XKK7QZ73aerzmbHZECfyxE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oFdHTDwqnEy0aI0O033SajQBIV3X2+YlsDOIEuuTuHbMnLcP5v35ducZMHj0mQIzvoxqJD0jJMc6aZkeA9jtEhSMSe1f+dBKj7zLMoRAMFQHWk5ZyRVa4KXriJeWG4h+yDk7GQ5bjd4gVgczlMQwE16Gc0vIkk1hVikU5IPSrKVIZh3W1ZD0K2TKjGaq1FsBqF1VSsNZgIa8h3kVCqNoPiDx/BwvRINOEytVlX2NKWuZ/fGexplh+gGNDIdfZb7tWBOhjK4vPpuUP3BLACUIVXl5E29Y/iPqisvZTliJIDa54ZPFIEjYP+DwB99F56grWeHlJOcU4jTbsTmEez7nGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9qlAgcfp8B8U8Fub1fPIWg/kuXk9QLyoBXzikwze/P0=; b=KCKOHxFyPOSeldSM9QIIaV759GtYYhpDb85jG2VTTqDPUhrNT0SE6i+ZK02uafH2q5qzDfGv83RtLkVLd+aA15zbnxRCXr/t7AIwcmK/H4hsPZM4/QUI/l4Bm+P/VzjfPSsolqIIjfw0iumNgPT5h8X38W8VT/YvTn6H0FiRg45CIoD1qlkg9nYKDjN0eV+9O2f3C7ITB0QBD20xtN3TH+g3zcfPtB9vBMpr+ZtylEdQ8kfYi2ZI+SPEN6fgmuKbGsbrW7NDjRk0/vJw2GhobkI0oL5+r75JODTvFu+gdB2RZyRdlkum65nxTi9PXEBjfoawWU20Z2BTYyV5rsIgGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9qlAgcfp8B8U8Fub1fPIWg/kuXk9QLyoBXzikwze/P0=; b=NOJi+VReJ5p7INMlqQd2W//x0fsII1lHEdhDiQTEofsW4skDQ5Rm1W3BJRsMf5xnPXjqr0zm/QXt7rTXUDQpf8UZUbVYo0hNaf3t3k4k01m8xijxy7/E8nokVRatUHeLgkxfJrKQA/O1XhWVEVPv7XKK7QZ73aerzmbHZECfyxE= From: Henry Wang To: =?utf-8?B?RWR3aW4gVMO2csO2aw==?= , "xen-devel@lists.xenproject.org" CC: Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: RE: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error Thread-Topic: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error Thread-Index: AQHY84eqgKyNiLgv0UCPJRPewn86Na414+ag Date: Wed, 9 Nov 2022 02:47:54 +0000 Message-ID: References: <09afc07ba0ba65afc02028bd6b4950d8e51af69b.1667920496.git.edvin.torok@citrix.com> In-Reply-To: <09afc07ba0ba65afc02028bd6b4950d8e51af69b.1667920496.git.edvin.torok@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6EF3B8317FD7084BACCE02E7EAF41CEC.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB6085:EE_|AM7EUR03FT020:EE_|AS8PR08MB6551:EE_ X-MS-Office365-Filtering-Correlation-Id: 533de615-1b07-4fdc-32d1-08dac1fcd223 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MsJ71F8lqWa76bhZGvM/ZgTRPSw58y50ZXtoKNtpbgdvswkkCVIYpLjS2Nshxom9e9iPxspXpYaQrIQoOPE/8MTe9nd5O5l2+toGuEUFBcneBayegwtpNh7Ei1cPCl9OBrZp4+dwfjwIhpyA9p4XdLmhahssCEG7QFu2njovNYiRftvON4AYH9zgOGsT6V59oULoQd7czEpvu1VnuTnKZal3+YmWyQ6oC92QodTs+CuJigQZ/y+2zEIra+lTKjXEAMFJg0OgwKn905YCzs+JJ9WrbUkNz+I51bBiyi23ccJUKLbfoRmu3BD4k2fmq55TNEBAF379nMMvEKPIYNt1PdPeTnF6hLNuy8GiEnb9l0tlzb8D9YHENcy1StpVScCmrnpvTm7YoWo61GMQQ0hbDCIW026PJKwfdvfJ8FLFgImOfc0sMspo1wnLZxfB250e4rRPd0olK9X2sF2AkRh3F3Rvni71NH7ORZwworirjy8ssN5R2MHFN7MlbVcT/gSNkW9fyVTwSfwibxiPQuNiLF3Fq31AWbcD+/cyZaJyNVPFwfu9HZV8kqRmo7grHrj/8W8qSx++ldCIvxVHwn9Uyci7ZQsELq35ckLcjnGfHbv0/vF01fl0JDeMXPrkXYAl0ekphxis1T2kC+aIZ8JhGW13erlpAliLNyRSgo8HJmKwdNl3wN6f5Ap7w1upajuA18aCvI2TkNADtBTVD6yBSh4fJVEz9rJg4Bq8tDwCGL1spSR9yPQ7SVOJKGlOT1W8dBmNkJAy3JDiV6cYqq5rVw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(366004)(346002)(451199015)(38100700002)(38070700005)(33656002)(55016003)(86362001)(71200400001)(478600001)(2906002)(6506007)(7696005)(4326008)(66446008)(76116006)(64756008)(8676002)(66556008)(66946007)(52536014)(316002)(5660300002)(110136005)(54906003)(41300700001)(8936002)(26005)(122000001)(66476007)(186003)(9686003)(83380400001)(66574015);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6085 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2ce955a6-a133-4420-1bcc-08dac1fccd76 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SKfsVG15NoF2StPYymx14PshUp/xlvzbDSC20+2d5a2XZjFTTtWAEhMHsl5cOXn3PvawWYyTGxxX8dKDfB4yX0Q87bET3EGGDhaegq4LGl8nV4DUy6hVdvmHIK5tCNbVqaQfUzVAl+D+woMj+OxNNLuzMi03AR7hGe+dP0aLFbfeMEBd5CYhc/RM8QWnSwHQs/KBEozN7ZVVgHRlnyugkg+pclpV1PYTjxpSvR9mXNVicYCUBv9NFFjdvdqMTtLt7qDVPLZRjZgjxL9Tn6s3Jy3U3sAca2TDQ7OHf5IlYIJI6rMKPd4ZefiDY/UTpcSJzhxRcrUtYx/Kap2SfQvG46loWIbRr/hgIwaWg192Dg7+h3y+y6eqqUbw7ldShtyRwquR8ckiywk6Qk65J3rBioJ9E5co1Q8EFUyMt22urTsmSUAU9OpStwVgnHlkG1bfu+Qh9FbE5KpfOwBZxzQNerTXiFsN/oPe1VE6YcmAd4GjJ0nsfoDZgWfqv3W7LjGbDJb+ljdwAHFnukypA0ywfCt0fpjj5MuPHk6ghqMhyfYw8lH/CPYTXimpI4QoB4hwEkaW03iL2FEhaYgRx1IUCJZXqng4ogZMhwjyZjmVRQDr6GXgjpAF1l5KEK9uzfCKCwGTLebdPqIKnSulUY7fVohsisBahGBHU0jO+XSfmt7af0Zy3WswS7Nr/DEpqFroR0jbGhU2MTOLoDdsdVxZRi0NImJwwMDWjJj5S74abOVS+ZryWoEL9KuDYs9cC7u711AD0gs0IQTcWuZPYsUSIw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199015)(46966006)(36840700001)(40470700004)(81166007)(82310400005)(4326008)(70206006)(54906003)(110136005)(8676002)(356005)(40480700001)(55016003)(83380400001)(2906002)(316002)(9686003)(8936002)(33656002)(5660300002)(52536014)(478600001)(26005)(36860700001)(41300700001)(47076005)(336012)(40460700003)(66574015)(186003)(70586007)(86362001)(82740400003)(107886003)(6506007)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 02:48:02.7163 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 533de615-1b07-4fdc-32d1-08dac1fcd223 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6551 SGkgRWR3aW4sDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogRWR3aW4g VMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogW1BBVENIIGZvci00 LjE3IHYzIDA5LzE1XSB0b29scy9vY2FtbC94ZW5zdG9yZWQvc3RvcmUubWw6IGZpeCBidWlsZA0K PiBlcnJvcg0KPiANCj4gQnVpbGRpbmcgd2l0aCBEdW5lIGluIHJlbGVhc2UgbW9kZSBmYWlscyB3 aXRoOg0KPiBgYGANCj4gRmlsZSAib2NhbWwveGVuc3RvcmVkL3N0b3JlLm1sIiwgbGluZSA0NjQs IGNoYXJhY3RlcnMgMTMtMzI6DQo+IFdhcm5pbmcgMTg6IHRoaXMgdHlwZS1iYXNlZCByZWNvcmQg ZGlzYW1iaWd1YXRpb24gaXMgbm90IHByaW5jaXBhbC4NCj4gRmlsZSAib2NhbWwveGVuc3RvcmVk L3N0b3JlLm1sIiwgbGluZSAxOg0KPiBFcnJvcjogU29tZSBmYXRhbCB3YXJuaW5ncyB3ZXJlIHRy aWdnZXJlZCAoMSBvY2N1cnJlbmNlcykNCj4gYGBgDQo+IA0KPiBUaGlzIGlzIGEgd2FybmluZyB0 byBoZWxwIGtlZXAgdGhlIGNvZGUgZnV0dXJlcHJvb2YsIHF1b3RpbmcgZnJvbSBpdHMNCj4gZG9j dW1lbnRhdGlvbjoNCj4gPiBDaGVjayBpbmZvcm1hdGlvbiBwYXRoIGR1cmluZyB0eXBlLWNoZWNr aW5nLCB0byBtYWtlIHN1cmUgdGhhdCBhbGwgdHlwZXMNCj4gYXJlDQo+ID4gZGVyaXZlZCBpbiBh IHByaW5jaXBhbCB3YXkuIFdoZW4gdXNpbmcgbGFiZWxsZWQgYXJndW1lbnRzIGFuZC9vcg0KPiBw b2x5bW9ycGhpYw0KPiA+IG1ldGhvZHMsIHRoaXMgZmxhZyBpcyByZXF1aXJlZCB0byBlbnN1cmUg ZnV0dXJlIHZlcnNpb25zIG9mIHRoZSBjb21waWxlciB3aWxsDQo+ID4gYmUgYWJsZSB0byBpbmZl ciB0eXBlcyBjb3JyZWN0bHksIGV2ZW4gaWYgaW50ZXJuYWwgYWxnb3JpdGhtcyBjaGFuZ2UuIEFs bA0KPiA+IHByb2dyYW1zIGFjY2VwdGVkIGluIC1wcmluY2lwYWwgbW9kZSBhcmUgYWxzbyBhY2Nl cHRlZCBpbiB0aGUgZGVmYXVsdA0KPiBtb2RlIHdpdGgNCj4gPiBlcXVpdmFsZW50IHR5cGVzLCBi dXQgZGlmZmVyZW50IGJpbmFyeSBzaWduYXR1cmVzLCBhbmQgdGhpcyBtYXkgc2xvdyBkb3duDQo+ IHR5cGUNCj4gPiBjaGVja2luZzsgeWV0IGl0IGlzIGEgZ29vZCBpZGVhIHRvIHVzZSBpdCBvbmNl IGJlZm9yZSBwdWJsaXNoaW5nIHNvdXJjZSBjb2RlLg0KPiANCj4gRml4ZXM6IGRiNDcxNDA4ZWRk NDYgInRvb2xzL29jYW1sL3hlbnN0b3JlZDogRml4IHF1b3RhIGJ5cGFzcyBvbiBkb21haW4NCj4g c2h1dGRvd24iDQoNCk5pdDogVGhlIGZvcm1hdCBvZiB0aGlzICJGaXhlczoiIHRhZyBtaWdodCBu ZWVkIHRvIGJlIGZpeGVkPw0KDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBFZHdpbiBUw7Zyw7ZrIDxl ZHZpbi50b3Jva0BjaXRyaXguY29tPg0KPiAtLS0NCj4gUmVhc29uIGZvciBpbmNsdXNpb24gaW4g NC4xNzoNCj4gLSBmaXhlcyBhIGJ1aWxkIGVycm9yIGluIGEgcHJldmlvdXMgY29tbWl0IHRoYXQg aXMgYWxyZWFkeSBpbiBtYXN0ZXINCg0KWWVzLCBnaXZlbiB0aGlzIGlzIGEgc2ltcGxlIGVub3Vn aCBwYXRjaDoNCg0KUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0u Y29tPg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0K From xen-devel-bounces@lists.xenproject.org Wed Nov 09 03:19:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 03:19:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440630.694713 (Exim 4.92) (envelope-from ) id 1osbcV-00047W-9f; Wed, 09 Nov 2022 03:19:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440630.694713; Wed, 09 Nov 2022 03:19:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osbcV-00047P-6r; Wed, 09 Nov 2022 03:19:19 +0000 Received: by outflank-mailman (input) for mailman id 440630; Wed, 09 Nov 2022 03:19:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osbcT-00047J-RC for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 03:19:18 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2050.outbound.protection.outlook.com [40.107.103.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a4da114-5fdd-11ed-8fd1-01056ac49cbb; Wed, 09 Nov 2022 04:19:16 +0100 (CET) Received: from FR3P281CA0097.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::15) by GV1PR08MB8618.eurprd08.prod.outlook.com (2603:10a6:150:82::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 03:19:12 +0000 Received: from VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a1:cafe::7e) by FR3P281CA0097.outlook.office365.com (2603:10a6:d10:a1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 03:19:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT021.mail.protection.outlook.com (100.127.144.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 03:19:11 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Wed, 09 Nov 2022 03:19:11 +0000 Received: from 4a19afbc7b5b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4386F3DC-8A56-47A3-8CFA-CE7BAFEEFBE4.1; Wed, 09 Nov 2022 03:19:05 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4a19afbc7b5b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 03:19:05 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DBBPR08MB6266.eurprd08.prod.outlook.com (2603:10a6:10:203::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 03:19:03 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Wed, 9 Nov 2022 03:19:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a4da114-5fdd-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hNmkW58+00ZjeD7Px7WYxhXcnxt54RwOcNY8mXaqj4IovFqfLtV2FyjDhlHohShMz1TIzhgnFrw38SCPZzULwwxNxvlRnhXbiPuqF9Z9v94JHibHZ6CyA9Xv9wiWkLt8ssWwyMycnldj4cxet7N9Ezz3QiWsRVZqzNVx8HHVrC7CuzgDGWnFAIu7Jhy4/K1IUbDmvZNq8Mq9+v9tHlxmUOavfYDfRFdZjVHHnNslMk90rtikeb9h19nmWen0XjsKY4u9LTJsZS84DoG7HWCabv1aKdOqRvAURdt9TjWQlub9MCDi8SEo3F3ACFiI+2ckPCD3/jI6pF87rWYwmVfmCw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JKxBkUyreiTI5w9ayhGliLrGUyPKPJgkzwQ/m7GJIFU=; b=n2QylM3sQ9nv5v6P1b8nnJHNPRpQJb1T9O10yUxUDiiX2d3fV9GmPugUjp2AkCDGwAwvqS9wAopVIggQkcvvGORVQhew1vpJT8rUrLO+Xh7JFB33McZF433kKMExfU49JlfPeQjhFMcomAwHN26LnGKLfOONfCEjeruNVz3iw+WPMldrsn2pIn0qFzyZoOQb3KfQycUaMPW9wVicoMW+e3rcC94/PSOU0zPgo0bAYSelclx3zQAZ3eRoUxaXcpGUROj5e5le4iqZUurr4TP1U3BmH5CEDp0Le+NqSOhaaeI8JqzHTvnPcPrjF2jeYMgXUG+T+gCSpss8G2f2XtN8mQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JKxBkUyreiTI5w9ayhGliLrGUyPKPJgkzwQ/m7GJIFU=; b=sb8XcwZH87iywwwkO7UQ3iYnVIoEN/ypc9xkuVXco3LvLGiJ8wK7NuGjpLAOajaKfV56sxQySi518yb1soFWYvz+Q4XHL6FO4GiHZ1iuL+hkx5tUgBwNXKyarAgLxp+QoLoE7RRdIAcl8M/D1249HoFgrww3+hX/GzainmwcVSs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DwCJ+LJH/meMr4EDjh+kz2iNZylFiUFCsC8bXTSkw7KkCcm1TYbWg+yIX8z61XG/FzAYlnlZ+nVoelMC/VLEhI+6g533soN0nZwn/IOWL7L/Mb5u8nMgGfRrBbo3DtvfShYG7wIBPN+Kj85Ih8aD2YKWX6duBvR5J1vh6CgekVlUC+aof6qjoAWGFfZVJd/jWy+EdyxGgbncZbQKuMS8D7V16JVuiuAgBVb4ks9+25LGnVztvQLS9vXaralzdB62T17btDMrLVXtQyEzGn05d9veIOWkV5a+e/FCFOXy5y9e0GD0EUflmGkxXEcIc6RXNTY6FpLsQQQvuFGnA3kjsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JKxBkUyreiTI5w9ayhGliLrGUyPKPJgkzwQ/m7GJIFU=; b=cn5HBIGyPL5oK/azNBZLJ0/OL2UWZ0qXeSmaHRCnlQ3NSRnzuZ6omWLqMtNcqcPLzlgHukc9Q8xv0VNznJ/4OkwrLHWbz3bVWnm0MKjvgq3T6WicgC6cFHY5Pux+SW+dI46HgAc2nZ6u0Vh0PMGqlDxzcYw5dQI7WxEyMgAWhIcf2+9SCmCV3mkeJg/GOlsyQZkb/EGTpCh63NRm8uOr7mJGmQ7ofXvJrpGSBR9ksp/GI45u90gma+OLHasKnRBsmjhb2ZaCcCwBn9F0B+B+MjrgkoIy9c8/n0BRnBKdwPB4FPkU9uOgTMRAVJTRu0cvh4ic30muhA8jBgZJb5hnfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JKxBkUyreiTI5w9ayhGliLrGUyPKPJgkzwQ/m7GJIFU=; b=sb8XcwZH87iywwwkO7UQ3iYnVIoEN/ypc9xkuVXco3LvLGiJ8wK7NuGjpLAOajaKfV56sxQySi518yb1soFWYvz+Q4XHL6FO4GiHZ1iuL+hkx5tUgBwNXKyarAgLxp+QoLoE7RRdIAcl8M/D1249HoFgrww3+hX/GzainmwcVSs= From: Henry Wang To: Edwin Torok , Julien Grall CC: Xen-devel , Christian Lindig , David Scott , Wei Liu , Anthony Perard Subject: RE: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Index: AQHY84e5FV9zwZ/cMEqESsIC5Hbn0K41MEgAgAAQdQCAAAalgIAAAxqAgACiFIA= Date: Wed, 9 Nov 2022 03:19:03 +0000 Message-ID: References: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> <1f8c90cd-8037-84eb-d6f7-c639f8a87585@xen.org> <7BD7C0AF-0D72-4125-BE97-8AD5FC15CA93@citrix.com> In-Reply-To: <7BD7C0AF-0D72-4125-BE97-8AD5FC15CA93@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4EF26FCC675C664BA25B3344FF4F4D78.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DBBPR08MB6266:EE_|VI1EUR03FT021:EE_|GV1PR08MB8618:EE_ X-MS-Office365-Filtering-Correlation-Id: 86d00b96-a1a3-415a-5b1b-08dac2012c32 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RJBnjbctX5hFXdypLqqCXgiWXiZhLjV+1qVbJPcBNBtqk1PtobHvPIA+O2fa+pYviaWdx+Gejz3N7c1epHJ3sOYCpjE2YAPBApPvw/4Vmto8Km2ajjfW6IKnYbncR5YG/rFuk98l6VqgAxT15nkukBoEfukvTZFaqjOG/ttEo5ybjlkBIBLm41lyCkQhD7O5qX3Vi6uPVy/4l6AJps87RhjHcq5HGfQNSGUE4gUfxeXo2gSZrbOH95OjwuhwHWzTdF9BO2SoJVECaTfu2m9QBkD0/fe+MxdqxyGi4Y1yv7prTY6sd4IcvCcBC0r3VSvETZqYzgS5NmE6MRcO+EVQJ8V8trb1zN3dBTZfZqExtoLaXQy9LQrL4n0p7NGIrdxEz2Wn8KudABAVMp2Cyq4e8TbqQRFYRGQUyiLLIz6L/XGek7waLdelbdleTrLvu9N/N21v245y5aL0t99aNt+raH8VYYg4+rjmZEoEuuNjzK48fSuOPJtNnvQuMl7gyyGqTZmoTZd3JeUZNHhqUqDrSuInoeHoNmAnDiia4Zy47HkCygcTV9hyhamHgvw371+klBE+XBoO4dZvqps2MBuC95+frStt9ILQZ4S5861SvJJo2je/pXyfJTbA5oFFNggkA2YpAikX6td8L1sscyR5Kdjn3E5FxrrWFmupI508z3kqpfHPcTvObL1FyrwJqTzC1cxjHhvEpTjzM5YPVwNSuDfLK7G3NPa2g4iFut6PBHLHl7gTIL4PBMWfr2EcTBrs3WUPI6I8DYQbVCfUjFNqbx6V0Dio7jiM3y2hlUsNL94= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(136003)(39860400002)(396003)(346002)(451199015)(83380400001)(86362001)(33656002)(38100700002)(122000001)(38070700005)(55016003)(478600001)(8936002)(71200400001)(5660300002)(52536014)(76116006)(4326008)(8676002)(66556008)(45080400002)(110136005)(66946007)(66446008)(66476007)(41300700001)(64756008)(26005)(316002)(54906003)(186003)(9686003)(4744005)(2906002)(6506007)(7696005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6266 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d6b03eae-4347-4af9-e36d-08dac2012778 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nOFJsKx/YXtWu+1775nPbfhESG2OGtFEa5KqXquZ0075Q6ROp26231pWxM5fSY++ZE/Piat4Z0DuP5OaUsD1pXz2xmGXpPLo8UhU7WeAaX4wKtNnkARnKeZt/VXdOA+XeJ3d9d/bHRCOSPFMQJ9E328dr7ollH6BJ2h4gPpKZHhJZDv8gj5Yr5FQCiL881knjUk58nJdHjUu0QNFuUhKl0rf20AKzBcH1qeWrMvOuQjRUk/sV3iMX6Lvzv9PD14y37k09UiQz/ycBTn47plM1ct/W0TZ8G8b3SrJ3tIVv5dSGynen2y6pTVkD2A2zFL+m3Oy5HUUXKQJKTz3N9+1vjmV4ESRmN1n5Fa0rDUHMzm3xH/rg+4n/HA/nYZNdZQATD72EKZD47LqDz1q/o517UoyBdcOUBdOPG0X9pEHajCLE6wo1rImXK7l+X8kB7wWjcFODsttSacENK7N6Z4K4HV769UrmkVcj7kUJh+3FNebEPYY3RVBAHdL85Vsy4VtNm9GoazF3bTgRD9wanbfN03cnA6OPbJQP1CEg639+2AwkY/FsqWsuHDMfXFXdYVsFawvkp8d4Vw9QOPyQsG9pdQ2lVGBwj3BTLYPakIb/0Q7R/15aOpbZabkGGklEI+o8VsNBt/+TxRSp1MNJ/YjxgIJrVGVPVMIDYOphKIWfEp2BpVElfyufGdW0u91vL1n8Duy+rQ68z3P2sJEJGeWh0w6uly/JPX717VfTnVjQ+2qPaLljlxsrGGyGbRAj4cGSB9pdhPOvDHhOVI82DshCQLtGoOW/oom5ug5XQKsYq8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(396003)(376002)(451199015)(36840700001)(46966006)(40470700004)(186003)(82310400005)(82740400003)(336012)(36860700001)(8936002)(83380400001)(86362001)(5660300002)(8676002)(41300700001)(4744005)(52536014)(40480700001)(2906002)(33656002)(4326008)(55016003)(316002)(81166007)(478600001)(356005)(9686003)(26005)(6506007)(47076005)(54906003)(110136005)(107886003)(45080400002)(70586007)(40460700003)(7696005)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 03:19:11.7662 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86d00b96-a1a3-415a-5b1b-08dac2012c32 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8618 SGkgRWR3aW4sDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiBbMV0NCj4gQVM4 UFIwOE1CNzk5MTE0NUM4MDYzRDY5MzlBRkZFRDhGOTI4MjlAQVM4UFIwOE1CNzk5MS5ldXJwcmQw OA0KPiAucHJvZC5vdXRsb29rLmNvbQ0KPiANCj4gDQo+IEhtbSBJIHRob3VnaHQgdGhhdCBpcyBt eSBPdXRsb29rIHJld3JpdGluZyB0aGUgbGluaywgYnV0IHRoZSBhcmNoaXZlIGF0DQo+IGxvcmUu a2VybmVsLm9yZyBzZWVtcyB0byBoYXZlIHRoaXMgbWFuZ2xlZCBVUkwgYXMgd2VsbCB3aGljaCBJ IGNhbm5vdCBvcGVuLg0KPiBDb3VsZCB5b3Ugc2VuZCBpdCBpbiBzdWNoIGEgd2F5IHRoYXQgaXQg aXMgbm90IGVuY29kZWQgd2hlbiBiZWluZyBzZW50IChlLmcuDQo+IGJhc2U2NCBlbmNvZGUgaXQu Li4pDQoNCkFwcGVuZGluZyAiaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLyIgYmVm b3JlIHRoZSBsaW5rIGZyb20gSnVsaWVuDQp3b3JrcyBmb3IgbWUuIEJ1dCBJIHRoaW5rIHRoZSBs aW5rIGlzIGp1c3QgdGhlIHJlbGVhc2Ugc2NoZWR1bGUgOikNCg0KS2luZCByZWdhcmRzLA0KSGVu cnkNCg0K From xen-devel-bounces@lists.xenproject.org Wed Nov 09 04:17:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 04:17:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440637.694724 (Exim 4.92) (envelope-from ) id 1oscWe-0003dw-Jx; Wed, 09 Nov 2022 04:17:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440637.694724; Wed, 09 Nov 2022 04:17:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oscWe-0003dp-HA; Wed, 09 Nov 2022 04:17:20 +0000 Received: by outflank-mailman (input) for mailman id 440637; Wed, 09 Nov 2022 04:17:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oscWd-0003df-4J; Wed, 09 Nov 2022 04:17:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oscWc-0001Ej-Tw; Wed, 09 Nov 2022 04:17:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oscWc-0006Nu-C9; Wed, 09 Nov 2022 04:17:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oscWc-0006Pq-B8; Wed, 09 Nov 2022 04:17:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3FUxXbZbBHuSWTu3IEM2PwWWW7GZfaVRT1+PY6inXPA=; b=S3MxkKDRZFkMh5GhT+lx2TTRZM 7YZe+wKGNsQQ9PjHKXZD3r8Eedg3xXDvYsC5dDI+X4CyquL0+JuO1cN7J4A2HXiwSLN0opHKCiDHf Dgz9a17nqnXAnOaXRdrz5gSGMvqBrN1fqS6MGdyRljKATy4qsYnpVoOC+HweQScpdt0c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174672: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-xsm:xen-boot:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start.2:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:redhat-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a0d9384967214783a92973c920092b7251c03e57 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Wed, 09 Nov 2022 04:17:18 +0000 flight 174672 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174672/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 174665 REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail in 174638 pass in 174672 test-amd64-i386-pair 11 xen-install/dst_host fail in 174638 pass in 174672 test-amd64-i386-libvirt-xsm 8 xen-boot fail in 174638 pass in 174672 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174638 pass in 174672 test-armhf-armhf-xl-rtds 14 guest-start fail in 174638 pass in 174672 test-armhf-armhf-libvirt-raw 13 guest-start fail in 174638 pass in 174672 test-armhf-armhf-xl-credit1 19 guest-start.2 fail in 174646 pass in 174638 test-amd64-i386-qemuu-rhel6hvm-amd 12 redhat-install fail in 174646 pass in 174665 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 174646 pass in 174672 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 174646 pass in 174672 test-armhf-armhf-libvirt-qcow2 13 guest-start fail in 174646 pass in 174672 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 174665 pass in 174672 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 174646 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 174665 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 174665 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 174665 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 174665 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux a0d9384967214783a92973c920092b7251c03e57 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 10 days Failing since 174575 2022-11-01 18:42:39 Z 7 days 14 attempts Testing same since 174608 2022-11-03 19:46:50 Z 5 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anssi Hannula Arnaldo Carvalho de Melo Biju Das Brian Foster Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Darrick J. Wong Darrick J. Wong Dave Chinner David S. Miller Demi Marie Obenour Dongliang Mu Eric Dumazet Florian Fainelli Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hannu Hartikainen Hans Verkuil Heiko Carstens Helge Deller Hyong Youb Kim Hyunwoo Kim Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jeff Vanhoof Jens Glathe Jimmy Assarsson Johan Hovold Jon Hunter Jon Maloy Jonathan Cameron Josh Poimboeuf Juergen Gross Justin Chen Konrad Jankowski Kuogee Hsieh Leon Romanovsky Linux Kernel Functional Testing Luiz Capitulino M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Michal Jaron Mike Kravetz Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Paolo Abeni Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rik van Riel Saeed Mahameed Sakari Ailus Sasha Levin Shreeya Patel Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Thinh Nguyen Tom Lendacky Tony O'Brien Ulf Hansson Vasily Gorbik Vineet Gupta Vladimir Oltean Wei Yongjun Xin Long Yang Yingliang Yongqin Liu Zhang Changzhong Zhengchao Shao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2244 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Nov 09 04:55:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 04:55:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440646.694734 (Exim 4.92) (envelope-from ) id 1osd7b-0000lU-Mk; Wed, 09 Nov 2022 04:55:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440646.694734; Wed, 09 Nov 2022 04:55:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osd7b-0000lN-K6; Wed, 09 Nov 2022 04:55:31 +0000 Received: by outflank-mailman (input) for mailman id 440646; Wed, 09 Nov 2022 04:55:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osd7Z-0000lH-Tc for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 04:55:30 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2040.outbound.protection.outlook.com [40.107.103.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b9dcab9a-5fea-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 05:55:26 +0100 (CET) Received: from AM6P192CA0084.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::25) by VI1PR08MB5504.eurprd08.prod.outlook.com (2603:10a6:803:13b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 04:55:23 +0000 Received: from AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8d:cafe::56) by AM6P192CA0084.outlook.office365.com (2603:10a6:209:8d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 04:55:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT036.mail.protection.outlook.com (100.127.140.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 04:55:23 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Wed, 09 Nov 2022 04:55:22 +0000 Received: from 9ea446a89243.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 12E8AE89-C58A-4D45-89F3-52DB9DFF5F9C.1; Wed, 09 Nov 2022 04:55:17 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9ea446a89243.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 04:55:17 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DU2PR08MB7311.eurprd08.prod.outlook.com (2603:10a6:10:2e6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 04:55:14 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%6]) with mapi id 15.20.5813.012; Wed, 9 Nov 2022 04:55:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9dcab9a-5fea-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=d1uuSTdO2PpRSqAuOzH/vVmj7YvR14yl5w8FhF3sH3zPVinpAmKtgbTkKL8d6iYLinotSpz0D5R1KVvLpnCXC221V8blhFG6qcNZkB65DN4xkOH5m4fxDAlQPYr3zhELa3GFFCfMUgo1UIbvRkbn3D+Yg6h9LLWIWz5peRocFkmdAuZSI6Wd2mvejraKU0VEwTmKcbzKTDLMB7EA8TX9pXdVTUIH+/kbUVXTpul5rBypKT8wtVTqimx1gsFrioBBeYGpnlPfSlQ37fI+IJd19CnM+Tj+rwb8CG/53FFKtfScu/3sumwRFhZtJuf0foTFijyVvpNl07h0FbspnAWytA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Iz5yqyLrmnaXqBdmTtVVuLYmAYGZd+VxBCMqJrW6A0Y=; b=bQlZMdIWSd37pQ6cNM794seM1LP2GZEBH3oFfkqGoHuppZw3/CmSfF+ttVTFKjUloIjyV8N/eC2akmpTMGUVwmelCSFnSpe09kva2IB4NdlOPGrk67XujJMw8m29kQ5ObreRQY2B8q5YPWou1Cs5qyhWXzO1rH7V/PU1KaPIPPgSizL/n+jd4IYhkE1+vUa2hsNZRq6fnafJ9EyJC6tL/FUQGN3D9NernubcOV6faItfD/APzM5TxL+SEVojatM0Th2wtL/ypReIU3DVGBYnoSNTsCyrus5uvq/LsselZy4fTUoX7BWl9R5BfNoZZucsCBCAGKw6ZZ370W3SkbJHBQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Iz5yqyLrmnaXqBdmTtVVuLYmAYGZd+VxBCMqJrW6A0Y=; b=KzJmBTC5Pw+T8B9ms/gfHuqxI7SuybOXDXTCJK2im+gmguIb2Hnt0IN/TnzAmZUeRRHwswl0iO/ERbgzpSclXCe05pbhadRv/RpZ9Ra7KjKofcJ1VU6bZYS2SdSatIk/Htu1edQA7B382r20JN5lHcVe4vyIM/ycELWZRYku7Dc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BfwSD5+TajM7oRqfg7p5ijfzUG+JV/jYO4OSEnh8842UGMMQTyXX/YYuW00yJxnQxUX6O/RBqRFnypg8YhxWAsN3M49HLjy6v3U1Ysz+UIpBAV3xLO07v2KbJLSDDA0LjV2BHPAT2GiNbjzaqFM60CwwnB2EW+oXCPJG9NqX/6qdeTF6MSNREi0p8XldUyaZUlf3cW17vUmtledspFlDMLf7o4qUD1lc0iEWJ3dlFKNoAu6Q6SgTJAuuQciSyGb8HCTYwUrSngVKYaeB0OGTFBs03hntj46VrTT56YDb3dMYUMZ5q55BJFENAkxEBPvJLUkX1x+1HldpD2FLzEhwvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Iz5yqyLrmnaXqBdmTtVVuLYmAYGZd+VxBCMqJrW6A0Y=; b=LWzye2YEC7DxVL1JerKo2tx32Sz1YoGpbv692/GHmenhxaiYQFVE80aT06pHeQR7Xa/vRlXXLENJKSQYtOIUx18L1pjGPXsPqY2rU7axurZR77F4TOhTf9Yv+RCWlVpQvuxyjLwfUUxdnzWyCJzF50xCN/wWCzLsKF0mO4G5Ih0zwlMZZu3YYGr/GbL5cOP9dNe40MNN05iuKcS6/NdQrRAjCQNDRUiiuVFp/ywoCoyE+bXklAxCY+yds/Jq6QN8HmzCWuU829FUSCoYELwV8ql7+w0zYf9ch8339xtonuQTJUPjOEHjq6E80WhA+CvaWG5Hj70ls5NsyP8pkPasQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Iz5yqyLrmnaXqBdmTtVVuLYmAYGZd+VxBCMqJrW6A0Y=; b=KzJmBTC5Pw+T8B9ms/gfHuqxI7SuybOXDXTCJK2im+gmguIb2Hnt0IN/TnzAmZUeRRHwswl0iO/ERbgzpSclXCe05pbhadRv/RpZ9Ra7KjKofcJ1VU6bZYS2SdSatIk/Htu1edQA7B382r20JN5lHcVe4vyIM/ycELWZRYku7Dc= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Jiamei Xie Subject: RE: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform Thread-Topic: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform Thread-Index: AQHY8DVkWYjGQuvcKkq0uEcag43TF64ySPmAgAO1+zA= Date: Wed, 9 Nov 2022 04:55:14 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-6-wei.chen@arm.com> <0ffe8a4d-7caf-89af-d189-a872b6b4f0fa@xen.org> In-Reply-To: <0ffe8a4d-7caf-89af-d189-a872b6b4f0fa@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E550ED8990B21341A17760949E3E147C.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|DU2PR08MB7311:EE_|AM7EUR03FT036:EE_|VI1PR08MB5504:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b42c0f0-9ca6-4262-1a72-08dac20e9c29 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: plHdRiXfps8BqUcGCPyeCJG5O6Is9NGj0Wg79aWQHpcqsso7akOw7Yx1dpLsnh6zjdFle55Pg8i1a+R94rotOCr3c973QVvWr9IznUy9xEFQz7WxX50DWRsnAF27nMkyO45TbVmwU/WJO0UhktoTKp8rasqkVPJW4uxcji4819tXyINdloQO0/CJuoMUkPAAX4Zloz3bEBPSSK9VKxUNtSqCKwlI3CkPjSkVJ4T4Hk+cbxZLZAhX3rQqZQ7Pbi7y23smu6wayH6Hn1vZbWabMev9EEQDO5R9fA7YfTYBzipX4OV4bT5jgKd7GQF3K6T28etuNRJ+91Lusb2eGguvcxo5AncD2vncsOcqjq6BzbGOdtaFG1fr+Q6AcGBdVJqsImDqAoaJsl49sb2m2CXYSfVpN/EmQp6lYWj66287eJyEozBmfUgXqWWoZMGN42JIqKqSS6QbeAjm9Dk6PPLRGxv0FKxtkLCg3MiEyVTx7eRkhhb6j6qavtlh5LJptyQ6/uLBuOy8Z9GNd9vAcOp73x/q6D3KskVxrxhQ4ppWOoechiUhxHJneVh3MYix2a8Q+tMg28HKePsacKOHhremt7VUS79SIe19os8cIEttJo8L5NbO16qI8lpXOVAnxfW18fXwJ045UhMK3SBMmvL+qznL+7tnWHgSmM9N/3ZsGlSwqh6/H03AOPhkXe8IM7eRxbbP/6m0evDDbcJOqhIxi1F3xV6JPjExW/YXlbo7S0PoXjjUHv2dOtVrJZCxoW4PnoT5AUV+O1kPC9gjUth+Wvwrb9J3ZCPnABfMhTz9KPACm9sklU3uUUrsK4oQR0r55ozjOctNSLI1zQS6mmpy9w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199015)(33656002)(122000001)(86362001)(54906003)(38100700002)(316002)(966005)(478600001)(55016003)(71200400001)(66476007)(6506007)(7696005)(110136005)(9686003)(53546011)(38070700005)(66446008)(2906002)(52536014)(186003)(66946007)(8936002)(5660300002)(26005)(76116006)(8676002)(83380400001)(4326008)(41300700001)(64756008)(66556008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7311 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d05c692f-ce6a-4de6-6c5e-08dac20e9714 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ElCPYmn2ZD8stgL6ghIScRbbG1ixd/3+wQ6p3UjPwZZXS0E8kaWr20UN2eHixzcb3TkO8P7P8KvnSrSbHtKZwSsPIzWeK9vVPeuJPw+LSBNJWTyh5RUBaRIzD7nYgOaxZBjoZyhj5R50IQMb9uuIThK9UiIzK4/29o3cudo24+wWZ0ExJCwlVrMNo8/BWNztgTlClwq8RP5xY2IJe9LClYB1hTr22fmwbfXw8mGs5Rx2zggTUWguGK3kaC2gQsicElZePXhkuIdHEzpgvxHvVXWWYclWezLIZojIq+CiZsa8jRNIlM9va6kB0z7JjNDUQQCyDWF3iXym7AGWPrTITZXMrgmr8vaRVXcT9bbtdbAMKMz+lAVIK/LuRn12e+wJPm+d49H3GnwJxE79CFEKOO9UA5rcHTRsAAvllW+SGCv8YGz7va4rC0KXL1KLGixqJdyLVMKqbSipx2YCeAUDeRY28ZNKKXhwixW+4Ro9IqzAC0wSA/RelGUfAhgqKY+bzskKw8Tpie1vqiX/B3YIHItKxZEeSS9+d4wgHOfif9iDzK5jXyLuEid32UR9ge8a03Opa3xSye+mj22RIGabzibOs0qyzfCdLTR79XqF0E9m1eakNqt6ENIJpfBzWBITGV+/Oi3kpkuAiQxIRCQEJyMXPfWfCMrtWLUW7yDaCJUUT9UN9Z+JChSHKPqZJmjKHRBJg9CBnIrSZ0noaOPbX969ue+g3/hm4LWrxqbdznTznffCYETO8uZhuUmyIce8CT1FEinjLl6trdjvN6LbkbviS6BCBhUXwxJ0joLSAtAsjAHzzbmEadcpl+Ek9tWN+Ewqg/a3H3CQELB5iNYFxQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(346002)(451199015)(40470700004)(36840700001)(46966006)(55016003)(86362001)(41300700001)(52536014)(2906002)(8936002)(82310400005)(4326008)(33656002)(70586007)(5660300002)(26005)(70206006)(9686003)(8676002)(54906003)(53546011)(6506007)(966005)(110136005)(316002)(478600001)(7696005)(336012)(186003)(36860700001)(81166007)(83380400001)(47076005)(356005)(40480700001)(40460700003)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 04:55:23.0679 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b42c0f0-9ca6-4262-1a72-08dac20e9c29 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5504 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQxMeaciDfml6UgMzoyMA0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcNCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3Rh YmVsbGluaUBrZXJuZWwub3JnPjsgQmVydHJhbmQNCj4gTWFycXVpcyA8QmVydHJhbmQuTWFycXVp c0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0u Y29tPjsgSmlhbWVpIFhpZSA8SmlhbWVpLlhpZUBhcm0uY29tPg0KPiBTdWJqZWN0OiBSZTogW1BB VENIIHY2IDA1LzExXSB4ZW4vYXJtOiBkZWZpbmUgWGVuIHN0YXJ0IGFkZHJlc3MgZm9yIEZWUA0K PiBCYXNlUiBwbGF0Zm9ybQ0KPiANCj4gDQo+IA0KPiBPbiAwNC8xMS8yMDIyIDEwOjA3LCBXZWkg Q2hlbiB3cm90ZToNCj4gPiBPbiBBcm12OC1BLCBYZW4gaGFzIGEgZml4ZWQgdmlydHVhbCBzdGFy dCBhZGRyZXNzIChsaW5rIGFkZHJlc3MNCj4gPiB0b28pIGZvciBhbGwgQXJtdjgtQSBwbGF0Zm9y bXMuIEluIGFuIE1NVSBiYXNlZCBzeXN0ZW0sIFhlbiBjYW4NCj4gPiBtYXAgaXRzIGxvYWRlZCBh ZGRyZXNzIHRvIHRoaXMgdmlydHVhbCBzdGFydCBhZGRyZXNzLiBTbywgb24NCj4gPiBBcm12OC1B IHBsYXRmb3JtcywgdGhlIFhlbiBzdGFydCBhZGRyZXNzIGRvZXMgbm90IG5lZWQgdG8gYmUNCj4g PiBjb25maWd1cmFibGUuIEJ1dCBvbiBBcm12OC1SIHBsYXRmb3JtcywgdGhlcmUgaXMgbm8gTU1V IHRvIG1hcA0KPiA+IGxvYWRlZCBhZGRyZXNzIHRvIGEgZml4ZWQgdmlydHVhbCBhZGRyZXNzIGFu ZCBkaWZmZXJlbnQgcGxhdGZvcm1zDQo+ID4gd2lsbCBoYXZlIHZlcnkgZGlmZmVyZW50IGFkZHJl c3Mgc3BhY2UgbGF5b3V0LiBTbyBYZW4gY2Fubm90IHVzZQ0KPiA+IGEgZml4ZWQgcGh5c2ljYWwg YWRkcmVzcyBvbiBNUFUgYmFzZWQgc3lzdGVtIGFuZCBuZWVkIHRvIGhhdmUgaXQNCj4gPiBjb25m aWd1cmFibGUuDQo+ID4NCj4gPiBTbyBpbiB0aGlzIHBhdGNoLCB3ZSByZXVzZSB0aGUgZXhpc3Rp bmcgYXJtL3BsYXRmb3JtcyB0byBzdG9yZQ0KPiA+IEFybXY4LVIgcGxhdGZvcm1zJyBwYXJhbWV0 ZXJzLiBBbmQgYFhFTl9TVEFSVF9BRERSRVNTYCBpcyBvbmUNCj4gPiBraW5kIG9mIEZWUCBCYXNl UiBwbGF0Zm9ybSdzIHBhcmFtZXRlcnMuIFNvIHdlIGRlZmluZSBkZWZhdWx0DQo+ID4gYFhFTl9T VEFSVF9BRERSRVNTYCBmb3IgRlZQIEJhc2VSIGluIGl0cyBwbGF0Zm9ybSBmaWxlLg0KPiA+DQo+ ID4gV2UgYWxzbyBpbnRyb2R1Y2Ugb25lIEtjb25maWcgb3B0aW9uIGZvciB1c2VycyB0byBvdmVy cmlkZSB0aGUNCj4gPiBkZWZhdWx0IFhlbiBzdGFydCBhZGRyZXNzIG9mIHNlbGVjdGVkIHBsYXRm b3JtLCBpZiB0aGV5IHRoaW5rDQo+ID4gdGhlIGRlZmF1bHQgYWRkcmVzcyBkb2Vzbid0IHN1aXQg dGhlaXIgc2NlbmFyaW9zLiBGb3IgdGhpcw0KPiA+IEtjb25maWcgb3B0aW9uLCB3ZSB1c2UgYW4g dW5hbGlnbmVkIGFkZHJlc3MgIjB4ZmZmZmZmZmYiIGFzIHRoZQ0KPiA+IGRlZmF1bHQgdmFsdWUg dG8gaW5kaWNhdGUgdGhhdCB1c2VycyBoYXZlbid0IHVzZWQgYSBjdXN0b21pemVkDQo+ID4gWGVu IHN0YXJ0IGFkZHJlc3MuDQo+ID4NCj4gPiBBbmQgYXMgd2UgaW50cm9kdWNlZCBBcm12OC1SIHBs YXRmb3JtcyB0byBYZW4sIHRoYXQgbWVhbnMgdGhlDQo+ID4gZXhpc3RlZCBBcm02NCBwbGF0Zm9y bXMgc2hvdWxkIG5vdCBiZSBsaXN0ZWQgaW4gQXJtdjgtUiBwbGF0Zm9ybQ0KPiA+IGxpc3QsIHNv IHdlIGFkZCAhQVJNX1Y4UiBkZXBlbmRlbmN5IGZvciB0aGVzZSBwbGF0Zm9ybXMuDQo+ID4NCj4g PiBTaWduZWQtb2ZmLWJ5OiBXZWkgQ2hlbiA8d2VpLmNoZW5AYXJtLmNvbT4NCj4gPiBTaWduZWQt b2ZmLWJ5OiBKaWFtZWkuWGllIDxqaWFtZWkueGllQGFybS5jb20+DQo+ID4gLS0tDQo+ID4gICB4 ZW4vYXJjaC9hcm0vS2NvbmZpZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTEgKysrKysr KysrKysNCj4gPiAgIHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9wbGF0Zm9ybXMvZnZwX2Jhc2Vy LmggfCAxNCArKysrKysrKysrKysrKw0KPiANCj4gSSBsb29rZWQgYXQgdGhlIGNvbnRlbnQgb2Yg ZnZwX2Jhc2VyLmggYWZ0ZXIgdGhpcyBzZXJpZXMgaXMgYXBwbGllZC4NCj4gVGhlcmUgYXJlIGEg Yml0IG9mIGJvaWxlciBwbGF0ZSB0aGF0IEkgZXhwZWN0IHRvIGJlIHBhcnQgZm9yIG90aGVyDQo+ IHBsYXRmb3Jtcy4gSW4gcGFydGljdWxhci4uLg0KPiANCj4gPiAgIHhlbi9hcmNoL2FybS9wbGF0 Zm9ybXMvS2NvbmZpZyAgICAgICAgICAgICAgICAgfCAxNiArKysrKysrKysrKysrLS0tDQo+ID4g ICAzIGZpbGVzIGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQo+ID4g ICBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3BsYXRmb3Jtcy9m dnBfYmFzZXIuaA0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9LY29uZmlnIGIv eGVuL2FyY2gvYXJtL0tjb25maWcNCj4gPiBpbmRleCBhZDU5MjM2N2JkLi5hYzI3NjMwN2Q2IDEw MDY0NA0KPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+ID4gKysrIGIveGVuL2FyY2gv YXJtL0tjb25maWcNCj4gPiBAQCAtMTM4LDYgKzEzOCwxNyBAQCBjb25maWcgVEVFDQo+ID4gICAJ ICBUaGlzIG9wdGlvbiBlbmFibGVzIGdlbmVyaWMgVEVFIG1lZGlhdG9ycyBzdXBwb3J0LiBJdCBh bGxvd3MNCj4gZ3Vlc3RzDQo+ID4gICAJICB0byBhY2Nlc3MgcmVhbCBURUUgdmlhIG9uZSBvZiBU RUUgbWVkaWF0b3JzIGltcGxlbWVudGVkIGluIFhFTi4NCj4gPg0KPiA+ICtjb25maWcgWEVOX1NU QVJUX0FERFJFU1MNCj4gPiArCWhleCAiWGVuIHN0YXJ0IGFkZHJlc3M6IGtlZXAgZGVmYXVsdCB0 byB1c2UgcGxhdGZvcm0gZGVmaW5lZA0KPiBhZGRyZXNzIg0KPiA+ICsJZGVmYXVsdCAweEZGRkZG RkZGDQo+IA0KPiAuLi4gdGhpcyBkZWZhdWx0IHZhbHVlIHdpbGwgbmVlZCB0byBiZSB0ZXN0ZWQg ZXZlcnl3aGVyZS4gQXQgbGVhc3QgZm9yDQo+IG5vdywgSSB0aGluayB5b3UgY2FuIGF2b2lkIHRo ZSBwZXIgcGxhdGZvcm0gaGVhZGVyIGJ5IHVzaW5nIHRoZSBLY29uZmlnDQo+IHRvIHNlbGVjdCB0 aGUgcHJvcGVyIGFkZHJlc3MgKHNlZSB0aGUgY29uZmlnIGZvciBzZWxlY3RpbmcgZWFybHkgcHJp bnRrDQo+IGFkZHJlc3MpLg0KPiANCj4gVGhpcyB3aWxsIGFsc28gYXZvaWRzIHRvIHVzZSBhbiBp bnZhbGlkIHZhbHVlIGhlcmUuDQo+IA0KDQpXZSBoYWQgY29uc2lkZXJlZCB0byB1c2UgS2NvbmZp ZyB0byBkZWZpbmUgdGhlIHN0YXJ0IGFkZHJlc3NlcyBvZiB2OFI2NA0KcGxhdGZvcm1zIChwcm9t cHQgdXNlcnMgdG8gaW5wdXQgdGhlIGFkZHJlc3MpLiBCdXQgd2UgYWxzbyB3YW50IHRvIHByb3Zp ZGUNCmEgZGVmYXVsdCBzdGFydCBhZGRyZXNzIGZvciBlYWNoIHBsYXRmb3JtIChEaXNjdXNzZWQg aW4gWzFdLCBoZWFkZXIgZm9yDQpkZWZhdWx0IHZhbHVlLCBLY29uZmlnIG9wdGlvbiBmb3IgY3Vz dG9taXplZCBhZGRyZXNzKS4NCg0KV2UgYWxzbyBoYWQgdGhvdWdodCB0byB1c2UgS2NvbmZpZyB0 byBkZWZpbmUgYSBkZWZhdWx0IHN0YXJ0IGFkZHJlc3MNCmZvciBlYWNoIHBsYXRmb3JtIGxpa2Ug d2hhdCB3ZSBoYWQgZG9uZSBmb3IgZWFybHkgcHJpbnRrIGluIFJGQ1syXS4NCkJ1dCB0aGlzIG1l dGhvZCBoYXMgYmVlbiBkZXByZWNhdGVkLg0KDQpTbyBpZiB3ZSBkb27igJl0IHVzZSBoZWFkZXIg ZmlsZXMsIGp1c3QgdXNlIHRoZSBLY29uZmlnLCB3ZSBjYW4ndA0KcHJvdmlkZSBhIGRlZmF1bHQg c3RhcnQgYWRkcmVzcyBmb3IgcGxhdGZvcm1zLCBhbmQgaGF2ZSB0byBmb3JjZSB1c2Vycw0KdG8g ZW50ZXIgdGhlIHN0YXJ0IGFkZHJlc3MuDQoNClsxXSBodHRwczovL2xpc3RzLnhlbnByb2plY3Qu b3JnL2FyY2hpdmVzL2h0bWwveGVuLWRldmVsLzIwMjItMDUvbXNnMDA2NDMuaHRtbA0KWzJdIGh0 dHBzOi8vZ2l0bGFiLmNvbS94ZW4tcHJvamVjdC9mdXNhL3hlbi1pbnRlZ3JhdGlvbi8tL2Jsb2Iv aW50ZWdyYXRpb24vbXB1L3hlbi9hcmNoL2FybS9LY29uZmlnLmRlYnVnDQoNCj4gPiArCWRlcGVu ZHMgb24gSEFTX01QVQ0KPiA+ICsJaGVscA0KPiA+ICsJICBUaGlzIG9wdGlvbiBhbGxvd3MgdG8g c2V0IHRoZSBjdXN0b21pemVkIGFkZHJlc3MgYXQgd2hpY2ggWGVuIHdpbGwNCj4gYmUNCj4gPiAr CSAgbGlua2VkIG9uIE1QVSBzeXN0ZW1zLiBUaGlzIGFkZHJlc3MgbXVzdCBiZSBhbGlnbmVkIHRv IGEgcGFnZSBzaXplLg0KPiA+ICsJICBVc2UgMHhGRkZGRkZGRiBhcyB0aGUgZGVmYXVsdCB2YWx1 ZSB0byBpbmRpY2F0ZSB0aGF0IHVzZXIgaGFzbid0DQo+ID4gKwkgIGN1c3RvbWl6ZWQgdGhpcyBh ZGRyZXNzLCBhbmQgWGVuIHVzZSB1c2UgdGhlIGRlZmF1bHQgdmFsdWUgdGhhdA0KPiBoYXMNCj4g PiArCSAgYmVlbiBkZWZpbmVkIGluIHBsYXRmb3JtIGZpbGVzLg0KPiA+ICsNCj4gPiAgIHNvdXJj ZSAiYXJjaC9hcm0vdGVlL0tjb25maWciDQo+ID4NCj4gPiAgIGNvbmZpZyBTVEFUSUNfU0hNDQo+ ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9wbGF0Zm9ybXMvZnZwX2Jh c2VyLmgNCj4gYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vcGxhdGZvcm1zL2Z2cF9iYXNlci5o DQo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gPiBpbmRleCAwMDAwMDAwMDAwLi45NDUwYTQx MWE5DQo+ID4gLS0tIC9kZXYvbnVsbA0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2Fz bS9wbGF0Zm9ybXMvZnZwX2Jhc2VyLmgNCj4gPiBAQCAtMCwwICsxLDE0IEBADQo+ID4gKyNpZm5k ZWYgX19BU01fQVJNX1BMQVRGT1JNU19GVlBfQkFTRVJfSF9fDQo+ID4gKyNkZWZpbmUgX19BU01f QVJNX1BMQVRGT1JNU19GVlBfQkFTRVJfSF9fDQo+ID4gKw0KPiA+ICsvKg0KPiA+ICsgKiAweEZG RkZGRkZGIGluZGljYXRlcyB1c2VycyBoYXZlbid0IGN1c3RvbWl6ZWQgWEVOX1NUQVJUX0FERFJF U1MsDQo+ID4gKyAqIHdlIHdpbGwgdXNlIHBsYXRmb3JtIGRlZmluZWQgZGVmYXVsdCBhZGRyZXNz Lg0KPiA+ICsgKi8NCj4gPiArI2lmIENPTkZJR19YRU5fU1RBUlRfQUREUkVTUyA9PSAweEZGRkZG RkZGDQo+ID4gKyNkZWZpbmUgWEVOX1NUQVJUX0FERFJFU1MgMHgyMDAwMDANCj4gPiArI2Vsc2UN Cj4gPiArI2RlZmluZSBYRU5fU1RBUlRfQUREUkVTUyBDT05GSUdfWEVOX1NUQVJUX0FERFJFU1MN Cj4gPiArI2VuZGlmDQo+ID4gKw0KPiA+ICsjZW5kaWYgLyogX19BU01fQVJNX1BMQVRGT1JNU19G VlBfQkFTRVJfSF9fICovDQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9wbGF0Zm9ybXMv S2NvbmZpZw0KPiBiL3hlbi9hcmNoL2FybS9wbGF0Zm9ybXMvS2NvbmZpZw0KPiA+IGluZGV4IGM5 M2E2YjI3NTYuLjA5MDQ3OTNhMGIgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gvYXJtL3BsYXRm b3Jtcy9LY29uZmlnDQo+ID4gKysrIGIveGVuL2FyY2gvYXJtL3BsYXRmb3Jtcy9LY29uZmlnDQo+ ID4gQEAgLTEsNiArMSw3IEBADQo+ID4gICBjaG9pY2UNCj4gPiAgIAlwcm9tcHQgIlBsYXRmb3Jt IFN1cHBvcnQiDQo+ID4gICAJZGVmYXVsdCBBTExfUExBVA0KPiA+ICsJZGVmYXVsdCBGVlBfQkFT RVIgaWYgQVJNX1Y4Ug0KPiANCj4gSXMgdGhlcmUgYW55IHJlYXNvbiB0byBjcmVhdGUgYSBuZXcg S2NvbmZpZyByYXRoZXIgdGhhbiB1c2luZyBNUFU/DQo+IA0KDQpEaWQgeW91IG1lYW4gRlZQX0JB U0VSPyBJZiB5ZXMsIHdlIHdhbnQgdG8gZ2l2ZSBlYWNoIGJvYXJkIGEgTUFDUk8NCnRvIGluZGlj YXRlIGl0cyBzcGVjaWZpYyBjb25maWd1cmF0aW9ucy4gSW4gY3VycmVudCBzZXJpZXMsIHRoaXMg TUFDUk8NCm9ubHkgYmUgdXNlZCBmb3IgYm9hcmQgc3BlY2lmaWMgc3RhcnQgYWRkcmVzcy4NCg0K SWYgeW91IG1lYW50IEFybXY4UiwgdGhhdCdzIGJlY2F1c2UgQXJtdjhSIGRvZXMgbm90IGVxdWFs IHRvIE1QVS4NCldlIG9ubHkgYWxsb3cgQXJtdjhSIGNvZGUgdG8gZGV0ZWN0IE1QVSBmZWF0dXJl cy4gTVBVIGlzIGNvbmZpZ3VyYWJsZQ0KSW4gRUwyLg0KDQpDaGVlcnMsDQpXZWkgQ2hlbg0KDQo+ ID4gICAJLS0taGVscC0tLQ0KPiA+ICAgCUNob29zZSB3aGljaCBoYXJkd2FyZSBwbGF0Zm9ybSB0 byBlbmFibGUgaW4gWGVuLg0KPiA+DQo+ID4gQEAgLTgsMTMgKzksMTQgQEAgY2hvaWNlDQo+ID4N Cj4gPiAgIGNvbmZpZyBBTExfUExBVA0KPiA+ICAgCWJvb2wgIkFsbCBQbGF0Zm9ybXMiDQo+ID4g KwlkZXBlbmRzIG9uICFBUk1fVjhSDQo+ID4gICAJLS0taGVscC0tLQ0KPiA+ICAgCUVuYWJsZSBz dXBwb3J0IGZvciBhbGwgYXZhaWxhYmxlIGhhcmR3YXJlIHBsYXRmb3Jtcy4gSXQgZG9lc24ndA0K PiA+ICAgCWF1dG9tYXRpY2FsbHkgc2VsZWN0IGFueSBvZiB0aGUgcmVsYXRlZCBkcml2ZXJzLg0K PiA+DQo+ID4gICBjb25maWcgUUVNVQ0KPiA+ICAgCWJvb2wgIlFFTVUgYWFyY2ggdmlydCBtYWNo aW5lIHN1cHBvcnQiDQo+ID4gLQlkZXBlbmRzIG9uIEFSTV82NA0KPiA+ICsJZGVwZW5kcyBvbiBB Uk1fNjQgJiYgIUFSTV9WOFINCj4gPiAgIAlzZWxlY3QgR0lDVjMNCj4gPiAgIAlzZWxlY3QgSEFT X1BMMDExDQo+ID4gICAJLS0taGVscC0tLQ0KPiA+IEBAIC0yMyw3ICsyNSw3IEBAIGNvbmZpZyBR RU1VDQo+ID4NCj4gPiAgIGNvbmZpZyBSQ0FSMw0KPiA+ICAgCWJvb2wgIlJlbmVzYXMgUkNhcjMg c3VwcG9ydCINCj4gPiAtCWRlcGVuZHMgb24gQVJNXzY0DQo+ID4gKwlkZXBlbmRzIG9uIEFSTV82 NCAmJiAhQVJNX1Y4Ug0KPiA+ICAgCXNlbGVjdCBIQVNfU0NJRg0KPiA+ICAgCXNlbGVjdCBJUE1N VV9WTVNBDQo+ID4gICAJLS0taGVscC0tLQ0KPiA+IEBAIC0zMSwxNCArMzMsMjIgQEAgY29uZmln IFJDQVIzDQo+ID4NCj4gPiAgIGNvbmZpZyBNUFNPQw0KPiA+ICAgCWJvb2wgIlhpbGlueCBVbHRy YXNjYWxlKyBNUFNvQyBzdXBwb3J0Ig0KPiA+IC0JZGVwZW5kcyBvbiBBUk1fNjQNCj4gPiArCWRl cGVuZHMgb24gQVJNXzY0ICYmICFBUk1fVjhSDQo+ID4gICAJc2VsZWN0IEhBU19DQURFTkNFX1VB UlQNCj4gPiAgIAlzZWxlY3QgQVJNX1NNTVUNCj4gPiAgIAktLS1oZWxwLS0tDQo+ID4gICAJRW5h YmxlIGFsbCB0aGUgcmVxdWlyZWQgZHJpdmVycyBmb3IgWGlsaW54IFVsdHJhc2NhbGUrIE1QU29D DQo+ID4NCj4gPiArY29uZmlnIEZWUF9CQVNFUg0KPiA+ICsJYm9vbCAiRml4ZWQgVmlydHVhbCBQ bGF0Zm9ybSBCYXNlUiBzdXBwb3J0Ig0KPiA+ICsJZGVwZW5kcyBvbiBBUk1fVjhSDQo+ID4gKwlo ZWxwDQo+ID4gKwkgIEVuYWJsZSBwbGF0Zm9ybSBzcGVjaWZpYyBjb25maWd1cmF0aW9ucyBmb3Ig Rml4ZWQgVmlydHVhbA0KPiA+ICsJICBQbGF0Zm9ybSBCYXNlUg0KPiA+ICsNCj4gPiAgIGNvbmZp ZyBOT19QTEFUDQo+ID4gICAJYm9vbCAiTm8gUGxhdGZvcm1zIg0KPiA+ICsJZGVwZW5kcyBvbiAh QVJNX1Y4Ug0KPiA+ICAgCS0tLWhlbHAtLS0NCj4gPiAgIAlEbyBub3QgZW5hYmxlIHNwZWNpZmlj IHN1cHBvcnQgZm9yIGFueSBwbGF0Zm9ybS4NCj4gPg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0N Cj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 09 06:47:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 06:47:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440652.694746 (Exim 4.92) (envelope-from ) id 1oseri-0006QF-Ot; Wed, 09 Nov 2022 06:47:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440652.694746; Wed, 09 Nov 2022 06:47:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oseri-0006Q8-LC; Wed, 09 Nov 2022 06:47:14 +0000 Received: by outflank-mailman (input) for mailman id 440652; Wed, 09 Nov 2022 06:47:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oserg-0006Q2-Ut for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 06:47:13 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60085.outbound.protection.outlook.com [40.107.6.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 55881921-5ffa-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 07:47:10 +0100 (CET) Received: from AM6P195CA0014.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::27) by PAXPR08MB7597.eurprd08.prod.outlook.com (2603:10a6:102:23c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 06:47:07 +0000 Received: from VI1EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:81:cafe::60) by AM6P195CA0014.outlook.office365.com (2603:10a6:209:81::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 06:47:07 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT058.mail.protection.outlook.com (100.127.144.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 06:47:06 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Wed, 09 Nov 2022 06:47:06 +0000 Received: from f4319a4e95cc.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BA1EBDF5-63A2-4139-971A-B76146F76F5E.1; Wed, 09 Nov 2022 06:47:00 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f4319a4e95cc.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 06:47:00 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB8PR08MB5308.eurprd08.prod.outlook.com (2603:10a6:10:f9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 06:46:59 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%6]) with mapi id 15.20.5813.012; Wed, 9 Nov 2022 06:46:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55881921-5ffa-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Yuo6Wp/dpTShKuLKPcUHaFWCglsH64b3ZFGuRWvYBUHmtoy81nBTwpGH9zivi2NBsjytUahzhYBI/1U2uigjqHeJzdiTNL/PXRZY2VXbveyIsRVJ0EN9x0QDxPnjPnDN59MOUj+CQkwPS36yH38JSPlYLnoR8l97InLTibrRoz7maMqSIQSAZnPvN7Gmg8MybB30XWTThkeVrNw6r3tHeht3a+kD+2aO4p+GeOxn0ZYFPDeq1PmHenpnyvL5ja0SZDsAitB6y5M48om20KHnaiVSlOJyaVYG/gxne0RsVV5BKy91GNklzX+96yu/z/j8x6T6Yy+ffUTnVahdQ3VU9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7x/UmCsr55BDJBfCWaiNONnWpVNM5XpYkxIp9xvm7jA=; b=TDBhK0hrN+dqV5SvgdFGbp8M/KFysfoDqPBaKn/0N8MBoesGHvZuY4tLZt2TnAR6nNNwgu7jl/XzuKe1V3N9Wb9ZF/0E2ZkBJMt3gM1Q/cWk1iLBgQUcOnC1xKQhk8QJDz8IIAzKHvIx4jXumHJ+DXJWQrMX6LmmSKsCikE7PxHhShaS8QwsI/YAoNeIp7MrEJz+u6Nor3XRSozdAu/A4tw6F25GTEnVN6H+NW6mdKDcHD3egUMxPe2HzCNqLCUr5lNsAgSuonOOnQ5KAVi1FSI/MaAnKRD/kjuP+/Zk2hj+daYrOjMyB5nX9s9/Vhf/nUO3jufWIaHDMRtcCOpqag== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7x/UmCsr55BDJBfCWaiNONnWpVNM5XpYkxIp9xvm7jA=; b=NuxlZ/sQMF13St6mAfD7v8IGpoJuj+n47FYJAe9Gd5ZefmTSDvlbnNQo4MbE5xkbd6dB33jaYsHYWRBa45//PEmiib8YNJKgL/4ZvfA9N0j1pFe/DSOQr866J7TUQ9EMM6ky/shgaWeEaSJC1bNGpIhRYXR/R3z1xUTHzi8Gfrw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ODITASiIU9i0ghGswYBKJfwhwZQc0S4DAzp665L57o1UhpwWLUMYErJqa7kBpbjv4rB0Zt52jpXjwlnJPXTwAPvKD1ZSL9t7FCnYIHksFFdlic7h1AtZFGnxwkKMPPCdZBn1wNFe2IcyeKalNekC7n7IZ6NUTDG3fj3R6HZmqGdPPpFaaLp2P1r2WA/n/mZT1SOSKbDzXIHGnizok2INs2R+2vxDfpBxuZokUtsNdzDoTk2BcvxfqZktClfUB+DhITC4G8FUVkMCoghqZdC1XmP6c5cZYY2ObQX6l82W4g81x21b24fXpy9uqGLyePaCw6qw5PozqIaQOA8m/Zy0ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7x/UmCsr55BDJBfCWaiNONnWpVNM5XpYkxIp9xvm7jA=; b=dpMaszCxqhGqv5nZQRV2lnHxE2c2xwTA8s+RVNTFIvQ7tIj1C93cOJiWMusjvChc9jsv471JX29kz0CUMaQHWimKT8YwnWHsdJAAHB2ThgubO17Qiox2kPzxCu+O0pcJISWw2SrgW3AIj85YkkcNtD+lzDN9GA7z2BYAJkRrF/k0OYDL95NkqEWG7njE9zpq9ZsVWU5YJkFoTPhS3ukHKLG+xW9q2qq06oqzR3mHMdwEKSdXl2hygLQMGzqY03XL57+OiuFL3HDr+OLEMwOARis4j8yA04XQkvf7jF1QOA2qKu/Zs+LSHoR/iaoxknuqxH7ZpdpYV5o8PyeSlOsurg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7x/UmCsr55BDJBfCWaiNONnWpVNM5XpYkxIp9xvm7jA=; b=NuxlZ/sQMF13St6mAfD7v8IGpoJuj+n47FYJAe9Gd5ZefmTSDvlbnNQo4MbE5xkbd6dB33jaYsHYWRBa45//PEmiib8YNJKgL/4ZvfA9N0j1pFe/DSOQr866J7TUQ9EMM6ky/shgaWeEaSJC1bNGpIhRYXR/R3z1xUTHzi8Gfrw= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 07/11] xen/arm: implement FIXMAP_ADDR for MPU systems Thread-Topic: [PATCH v6 07/11] xen/arm: implement FIXMAP_ADDR for MPU systems Thread-Index: AQHY8DVneLUTj6n4XEmKaYaqtg988K4yT/yAgAPcKRA= Date: Wed, 9 Nov 2022 06:46:57 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-8-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 965A78688B6484488DC5B11EA91F1EE5.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|DB8PR08MB5308:EE_|VI1EUR03FT058:EE_|PAXPR08MB7597:EE_ X-MS-Office365-Filtering-Correlation-Id: c9f58ea1-a551-4f20-f5b8-08dac21e37f0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Vi4+UTaJz6kA5OC6d8vhssCL2dJbEKusWr0oKX4T9poilAsMehGHMx/FhpAF8877Sq07eobr5wSplv8zJCY+vKkW2ccUN31U26FK5sNsFSwtfiIACEcgn0Ec/Pgz+T0MGd+4HCaLAHcOHnMZHLOY7R36FCBLd8mqEs0snphArgmfJMLbfw5HlhFt/aBVKXa968g2sO5u3tMxilM4z5p+90p0mn87yFTCY/eK8A86ke7VB2/JKKpvYW8xsqXnFZKjRtN+GuPIvQnvykhrC5SaJFy+5Qt8IRxR2xHJ+UUKW7aFrkLja+KfuKj6uWbBeWDW60m9cK6Uzmmc+2U5hi039yUkWj7EKdjR/lfa+tvdx0sXrE61zsGvxB9cFTw0CVnJ8y5IOATHWnF5zSp7hgPsJsmqODlJpbt631/wZZSY2JVudCfA2psRO2yUdr5bvclhz8VX6EDQi1s8fOmDZuIpTwpFIDG5FY110xwb7pct6P1ntrSpVQ9lYJ6QOSUHjsD5ExwQA7M2/idsBqziMIy36sL3niTLLbnLhUyeItteE9sc3NcRfx3Iir8xqdCGwuthE4ILx92kkJfcHHPYjO5pP7sTlI0BzTbeyp1DDkHsx509tdAZJ9zJdRrBIDEfNeQhQvNJvq/KYT3VKBUf5WfuvJYoDgh+L/Q/kPtfT9cKc0WKIkmmR58++WE45op2pnH+rgS0ePvJp9OhFus3SFpqL9r9bQUwqn4FUZbYUsQ3DnfaeVJ+lpn2Apu2p/iJaWMHP+WdEQPtPKnGKuooXO4R6Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(366004)(346002)(39860400002)(451199015)(66446008)(64756008)(66476007)(8676002)(4326008)(33656002)(66556008)(53546011)(66946007)(76116006)(316002)(6506007)(7696005)(55016003)(83380400001)(2906002)(41300700001)(9686003)(86362001)(26005)(122000001)(38100700002)(5660300002)(186003)(8936002)(52536014)(71200400001)(478600001)(110136005)(54906003)(38070700005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5308 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: eb0026fc-32e8-435a-75e4-08dac21e3285 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wRABiPyPDWaCRQlL/lrAh+UqWsQmbGbn14sXOTPCysE29azY4Lw3bH4f71YD1pRVs+/2LSaulLHFa/u6u5SfKW9xdk/Y5bXcejZ9iZoNpD6Con3FHVZ2SXGiPgMcHXUbsr2EapDBhevaAYYT/iq0tSm04trdlaISDU+O+dQfdbdJOWCo2E04XXnSm0c5G/EV+Pl4VNQIAuv06sWlKYfRyRIuLkxpqhY+sroBgD/e1XyAsuZYIhpUrXqeI8WZ0BjL7htb7Zx9JGerVFDIgUEyY2/vbQ6bqsco53xbutBH0g9Nb3cp+i7XARt8ypKZb2s6XQcpgMpV68bi22aoqfZ8cMun2y+4PWzWoJXsZX1ck6iQuIs/pU+iVVkaIZxJanw6N7OpUXv3HVz+GciCNXRjF2uIUuU2ZSsSa2nj3/VxZxTiJaKUw8+xI08ZKTaTVTV8oZTJbT6Xhd7qU2R2kc4xaseojqi1GClNH1GD+winc9vlCjukdUdn21mrvQu76MoSaYxbnpdB2zRWs6vG7HRn1tLMKwzqQVaeWA/IFllpcm4WzHYcsmUDCbk3ugA6QmAdGSgeCeaY+kRQrmIM7cLQIYvAgK1rVA3yDC+9A6Wmc9dos3PilMpEno6/R7bI7HevCEnL0t5wP+FtuBVtGY9qztDpT4bfYHQ0dYCAo6NpE3SKFkfRb0lCoa7HO71/ANRJ9kGSaRN2vhv1e+zT0R2CnzYYNo3Blox7U8TH4aalPtiLYEqMtZX6buzTAd5F7Ql25LIoyp8HwQBNTumd8g7xwg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(186003)(47076005)(107886003)(2906002)(336012)(7696005)(53546011)(478600001)(9686003)(40460700003)(110136005)(26005)(82740400003)(356005)(83380400001)(86362001)(54906003)(81166007)(55016003)(33656002)(70586007)(36860700001)(6506007)(70206006)(40480700001)(82310400005)(8676002)(4326008)(41300700001)(316002)(5660300002)(8936002)(52536014);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 06:47:06.8442 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9f58ea1-a551-4f20-f5b8-08dac21e37f0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7597 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQxMeaciDfml6UgMzo0NQ0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcNCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3Rh YmVsbGluaUBrZXJuZWwub3JnPjsgQmVydHJhbmQNCj4gTWFycXVpcyA8QmVydHJhbmQuTWFycXVp c0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0u Y29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHY2IDA3LzExXSB4ZW4vYXJtOiBpbXBsZW1lbnQg RklYTUFQX0FERFIgZm9yIE1QVQ0KPiBzeXN0ZW1zDQo+IA0KPiBIaSBXZWksDQo+IA0KPiBPbiAw NC8xMS8yMDIyIDEwOjA3LCBXZWkgQ2hlbiB3cm90ZToNCj4gPiBGSVhNQVAgaXMgYSBzcGVjaWFs IHZpcnR1YWwgYWRkcmVzcyBzZWN0aW9uIGZvciBYZW4gdG8gbWFwIHNvbWUNCj4gPiBwaHlzaWNh bCByYW0gb3IgZGV2aWNlIG1lbW9yeSB0ZW1wb3JhcmlseSBpbiBpbml0aWFsaXphdGlvbiBmb3IN Cj4gPiBNTVUgc3lzdGVtcy4gRklYTUFQX0FERFIgd2lsbCByZXR1cm4gYSB2aXJ0dWFsIGFkZHJl c3MgYnkgaW5kZXgNCj4gPiBmb3Igc3BlY2lhbCBwdXJwb3NlIHBoeXMtdG8tdmlydCBtYXBwaW5n IHVzYWdlLiBGb3IgZXhhbXBsZSwNCj4gPiBGSVhNQVBfQUREUihGSVhNQVBfQ09OU09MRSkgZm9y IGVhcmx5IGNvbnNvbGUgbWFwcGluZyBhbmQNCj4gPiBGSVhNQVBfQUREUihGSVhNQVBfTUlTQykg Zm9yIGNvcHlfZnJvbV9wYWRkci4NCj4gDQo+IFRvIG1lLCB3ZSBhcmUgYmVuZGluZyBxdWl0ZSBh IGJpdCB0aGUgZGVmaW5pdGlvbiBvZiB0aGUgZml4bWFwLiBUaGVyZQ0KPiBhcmUgbm90IG1hbnkg dXNlIG9mIHRoZSBGSVhNQVAgd2l0aGluIHRoZSBjb2RlIGFuZCBJIHRoaW5rIGl0IHdvdWxkDQo+ IHNpbXBseSBiZSBiZXR0ZXIgdG8gYWJzdHJhY3QgdGhlIHVzZSAob3IgcmVtb3ZpbmcgaXQgd2hl biBwb3NzaWJsZSkgYW5kDQo+IGF2b2lkIGRlZmluaW5nIEZJWE1BUF9BRERSKCkgJiBjbyBmb3Ig TVBVLg0KPiANCg0KSSBhZ3JlZSwgaWYgd2UgZG9uJ3QgbWluZCB0byBhZGQgc29tZSBDT05GSUdf SEFTX01QVSBpbiBzb21lIGdlbmVyaWMgY29kZS4gDQpJIGFsc28gcHJlZmVyIHRoaXMgd2F5LiBG cmFua2x5LCBJIHJlYWxseSB0aGluayBGSVhNQVAgaXMgYXdrd2FyZCBpbiBNUFUNClN5c3RlbS4N Cg0KPiA+DQo+ID4gQnV0IGluIE1QVSBzeXN0ZW1zLCB3ZSBjYW4ndCBtYXAgcGh5c2ljYWwgYWRk cmVzcyB0byBhbnkgdmlydHVhbA0KPiA+IGFkZHJlc3MuIFNvIHdlIHdhbnQgdGhlIGNvZGUgdGhh dCBpcyB1c2luZyBGSVhNQVBfQUREUiB0byByZXR1cm4NCj4gPiB0aGUgaW5wdXQgcGh5c2ljYWwg YWRkcmVzcyBpbiBNUFUgc3lzdGVtcy4gU28gaW4gTVBVIHZlcnNpb24sDQo+ID4gRklYTUFQX0FE RFIgd2lsbCB0cmltIHBoeXNpY2FsIGFkZHJlc3MgdG8gUEFHRSBhbGlnbm1lbnQuIFRoaXMNCj4g PiB3aWxsIHJldHVybiBhbiBvZmZzZXQgd2hpY2ggaXMgc2ltaWxhciB0byBNTVUgdmVyc2lvbiBG SVhNQVBfQUREUi4NCj4gPiBCdXQgaXQncyBhIHBoeXNpY2FsIG9mZnNldCBnb3QgZnJvbSBpbnB1 dCBwaHlzaWNhbCBhZGRyZXNzLCBwbHVzDQo+ID4gdG8gYW4gb2Zmc2V0IGluc2lkZSBwYWdlICh3 aGljaCBpcyBhbHNvIGdvdCBmcm9tIHBoeXNpY2FsIGFkZHJlc3MNCj4gPiBtYXNrIHdpdGggUEFH RV9NQVNLKS4gVGhlIGNhbGxlciBjYW4gcmV0dXJuIHRoZSBpbnB1dCBwaHlzaWNhbA0KPiA+IGFk ZHJlc3MgZGlyZWN0bHkuDQo+ID4NCj4gPiBBcyBwbWFwIGRlcGVuZHMgb24gRklYQU1QLCBzbyB3 ZSBkaXNhYmxlIHBtYXAgZm9yIEFybSB3aXRoIE1QVQ0KPiA+IGVuYWJsZWQgc3lzdGVtcy4NCj4g Pg0KPiA+IFNpZ25lZC1vZmYtYnk6IFdlaSBDaGVuIDx3ZWkuY2hlbkBhcm0uY29tPg0KPiA+IC0t LQ0KPiA+ICAgeGVuL2FyY2gvYXJtL0tjb25maWcgICAgICAgICAgICAgICAgICB8ICAyICstDQo+ ID4gICB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vY29uZmlnX21wdS5oIHwgIDIgKysNCj4gPiAg IHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9maXhtYXAuaCAgICAgfCAyNSArKysrKysrKysrKysr KysrKysrKysrKysrDQo+ID4gICAzIGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb24oLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vS2NvbmZpZyBi L3hlbi9hcmNoL2FybS9LY29uZmlnDQo+ID4gaW5kZXggYWMyNzYzMDdkNi4uMTQ1OGZmYTc3NyAx MDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vS2NvbmZpZw0KPiA+ICsrKyBiL3hlbi9hcmNo L2FybS9LY29uZmlnDQo+ID4gQEAgLTE2LDcgKzE2LDcgQEAgY29uZmlnIEFSTQ0KPiA+ICAgCXNl bGVjdCBIQVNfREVWSUNFX1RSRUUNCj4gPiAgIAlzZWxlY3QgSEFTX1BBU1NUSFJPVUdIDQo+ID4g ICAJc2VsZWN0IEhBU19QRFgNCj4gPiAtCXNlbGVjdCBIQVNfUE1BUA0KPiA+ICsJc2VsZWN0IEhB U19QTUFQIGlmICFIQVNfTVBVDQo+IA0KPiBJIGNhbid0IGZpbmQgYW55IGNoYW5nZSBvZiBtbS5j IGluIHRoaXMgc2VyaWVzLiBTbyBzdXJlbHkgdGhpcyB3aWxsDQo+IGJyZWFrIHRoZSBidWlsZD8N Cg0KWWVzLCBpbiBvdXIgaW50ZXJuYWwgdGVzdGluZywgb3BlbiBQTUFQIGZvciBNUFUgd2lsbCBj YXVzZSBidWlsZGluZw0KZmFpbGVkLCBleGNlcHQgd2UgYWRkIHNvbWUgbmV3IHN0dWJzIGZvciBN UFUgc3lzdGVtLg0KDQo+IA0KPiA+ICAgCXNlbGVjdCBJT01NVV9GT1JDRV9QVF9TSEFSRQ0KPiA+ DQo+ID4gICBjb25maWcgQVJDSF9ERUZDT05GSUcNCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gv YXJtL2luY2x1ZGUvYXNtL2NvbmZpZ19tcHUuaA0KPiBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2Fz bS9jb25maWdfbXB1LmgNCj4gPiBpbmRleCA1MzBhYmI4MzAyLi5lZWU2MGRjZmZjIDEwMDY0NA0K PiA+IC0tLSBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9jb25maWdfbXB1LmgNCj4gPiArKysg Yi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vY29uZmlnX21wdS5oDQo+ID4gQEAgLTI0LDQgKzI0 LDYgQEANCj4gPg0KPiA+ICAgI2RlZmluZSBIWVBFUlZJU09SX1ZJUlRfU1RBUlQgIFhFTl9WSVJU X1NUQVJUDQo+ID4NCj4gPiArI2RlZmluZSBGSVhNQVBfQUREUihuKSAgICAgICAgIChfQVQocGFk ZHJfdCwgbikgJiAoUEFHRV9NQVNLKSkNCj4gPiArDQo+ID4gICAjZW5kaWYgLyogX19BUk1fQ09O RklHX01QVV9IX18gKi8NCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNt L2ZpeG1hcC5oDQo+IGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2ZpeG1hcC5oDQo+ID4gaW5k ZXggZDBjOWE1MmM4Yy4uMWUzMzg3NTllOSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0v aW5jbHVkZS9hc20vZml4bWFwLmgNCj4gPiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20v Zml4bWFwLmgNCj4gPiBAQCAtNyw2ICs3LDggQEANCj4gPiAgICNpbmNsdWRlIDx4ZW4vYWNwaS5o Pg0KPiA+ICAgI2luY2x1ZGUgPHhlbi9wbWFwLmg+DQo+ID4NCj4gPiArI2lmbmRlZiBDT05GSUdf SEFTX01QVQ0KPiA+ICsNCj4gPiAgIC8qIEZpeG1hcCBzbG90cyAqLw0KPiA+ICAgI2RlZmluZSBG SVhNQVBfQ09OU09MRSAgMCAgLyogVGhlIHByaW1hcnkgVUFSVCAqLw0KPiA+ICAgI2RlZmluZSBG SVhNQVBfTUlTQyAgICAgMSAgLyogRXBoZW1lcmFsIG1hcHBpbmdzIG9mIGhhcmR3YXJlICovDQo+ ID4gQEAgLTQ1LDQgKzQ3LDI3IEBAIHN0YXRpYyBpbmxpbmUgdW5zaWduZWQgaW50IHZpcnRfdG9f Zml4KHZhZGRyX3QgdmFkZHIpDQo+ID4NCj4gPiAgICNlbmRpZiAvKiBfX0FTU0VNQkxZX18gKi8N Cj4gPg0KPiA+ICsjZWxzZQ0KPiA+ICsNCj4gPiArLyoNCj4gPiArICogRklYTUFQX0FERFIgd2ls bCB0cmltIHBoeXNpY2FsIGFkZHJlc3MgdG8gUEFHRSBhbGlnbm1lbnQuDQo+ID4gKyAqIFRoaXMg d2lsbCByZXR1cm4gYW4gb2Zmc2V0IHdoaWNoIGlzIHNpbWlsYXIgdG8gTU1VIHZlcnNpb24NCj4g PiArICogRklYTUFQX0FERFIuDQo+ID4gKyAqIEZvciBleGFtcGxlOg0KPiA+ICsgKiBFQVJMWV9V QVJUX1ZJUlRVQUxfQUREUkVTUyBpcyBkZWZpbmVkIGJ5Og0KPiA+ICsgKiAgICAgKEZJWE1BUF9B RERSKEZJWE1BUF9DT05TT0xFKSArIFwNCj4gPiArICogICAgIChDT05GSUdfRUFSTFlfVUFSVF9C QVNFX0FERFJFU1MgJiB+UEFHRV9NQVNLKSkNCj4gPiArICogV2l0aCBNUFUgdmVyc2lvbiBGSVhN QVBfQ09OU09MRSBhbmQgRklYTUFQX0FERFIgZGVmaW5pdGlvbnMsDQo+ID4gKyAqIEVBUkxZX1VB UlRfVklSVFVBTF9BRERSRVNTIGNhbiBiZSByZXN0b3JlIHRvDQo+ID4gKyAqIENPTkZJR19FQVJM WV9VQVJUX0JBU0VfQUREUkVTUy4NCj4gPiArICogSW4gdGhpcyBjYXNlLCB3ZSBkb24ndCBuZWVk IHRvIHVzZSAjaWZkZWYgTVBVIGluIHRoZSBjb2RlDQo+ID4gKyAqIHdoZXJlIGFyZSB1c2luZyBG SVhNQVBfQUREUiB0byBtYWtlIHRoZW0gdG8gdXNlIHBoeXNpY2FsDQo+ID4gKyAqIGFkZHJlc3Mg ZXhwbGljaXRpbHkuDQo+ID4gKyAqLw0KPiA+ICsjaWZkZWYgQ09ORklHX0VBUkxZX1VBUlRfQkFT RV9BRERSRVNTDQo+ID4gKyNkZWZpbmUgRklYTUFQX0NPTlNPTEUgICAgICAgICBDT05GSUdfRUFS TFlfVUFSVF9CQVNFX0FERFJFU1MNCj4gPiArI2VuZGlmDQo+ID4gKw0KPiA+ICsjZW5kaWYgLyog Q09ORklHX0hBU19NUFUgKi8NCj4gPiArDQo+ID4gICAjZW5kaWYgLyogX19BU01fRklYTUFQX0gg Ki8NCj4gDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Wed Nov 09 07:10:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 07:10:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440659.694757 (Exim 4.92) (envelope-from ) id 1osfEY-0001rB-N3; Wed, 09 Nov 2022 07:10:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440659.694757; Wed, 09 Nov 2022 07:10:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfEY-0001r4-KC; Wed, 09 Nov 2022 07:10:50 +0000 Received: by outflank-mailman (input) for mailman id 440659; Wed, 09 Nov 2022 07:10:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfEX-0001qy-8N for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 07:10:49 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2088.outbound.protection.outlook.com [40.107.20.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a2960634-5ffd-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 08:10:47 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8522.eurprd04.prod.outlook.com (2603:10a6:20b:431::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Wed, 9 Nov 2022 07:10:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 07:10:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2960634-5ffd-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XoigmJBFTxyyyTtE1evjan6VQoA8NZkDbKKeLXS50FFKXUgBEjmWR2ju5uNEu+/nzvwmKESuAJUX2kNIgFxgsH/cWqrlvTkK4VDon/iaBb5Jy4XgVLj0fIE/R/XYuZmMPdkg1nV0V3vgI5mGzIkDJ80pqC7zyVMvDONhMRr5LvJaNTBQ3XzJoc2DoLRQoE+x9NJFkgLpM0CZrWYqEUmqf4RQnVeQAqc4/EHURkDuVJHKHhday/EUtk+awZdDhEGrLNJ+ftIV2xOgVeeaIE3rcDEwVxuLw66mvUcTeZwT50+obXCXfd4dOLvQqfmsqL/ASCIAXkjjSwYPSHzed8JOBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZyHoDLJn8DwgQm0hKK5XgbxE9dkcOm5pVw+9QOr2wf4=; b=UEGXVprfvfW92XaGy43P6FkSAR7wm15fuKpoerys0XALzTbPhnc7Zsyrhuc/U1LlsZbHrXIWeKriqg1Q3MCYE8CRts+KMW3OH0MDJeuOnx1ohHd0zIXR2d4iFLSjva3rdJIW7M7j+RZQ6PCTpBah0pUNiwaRUF4qYNevIhv4kykL8UBhLPcfgAG921CBZ0oVtdYdnqdLPMqgFYRi19A3QE2pLhVM7qJ6lgvwkbOLtWEIfUEORwnVV5a37VIfBrP8DM4CTUsXu/Vd8/SMaTqRfi3xancmNz4HfCUWpSxgENrqIRdFZBb2ERqOoZFDRKzfsHRSsMIawKnqeu5wp95ELQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZyHoDLJn8DwgQm0hKK5XgbxE9dkcOm5pVw+9QOr2wf4=; b=NPUsE/1CZcAc/3LOQqNDv2ROJE/nqs0A8acM6wF8k5ZBqON9d1G7Vnu8KA9GySuEf3ia32wU8fZRhN/p9wQ8G2IOKGk/829unY7/AvJiHz8UiOgObcVqBu+IZEyqJHH0GuzDaWwAyBQMHQiJL682MJw7de935bMfs1GjLsbEJo5KJbKExgpmmsGXHIb/Kx6FX8r6DTxsTYRABQx0Ywgn7HZ8xtbQhFP4wTZsagVtmlgc+mq+dydnWkSnxMUnOAQ4sD81NXxrFYAebS88yW2XOsAsaSnfctVoXyiF56KM1DwBqgR1kEfDhTEpSQtW1u/lEA1oF71iGVK1XkXfOvV0XQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1e994604-7a3f-ef5f-63f4-d03e4abe4124@suse.com> Date: Wed, 9 Nov 2022 08:10:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error Content-Language: en-US To: Henry Wang , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= Cc: Christian Lindig , David Scott , Wei Liu , Anthony PERARD , "xen-devel@lists.xenproject.org" References: <09afc07ba0ba65afc02028bd6b4950d8e51af69b.1667920496.git.edvin.torok@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8522:EE_ X-MS-Office365-Filtering-Correlation-Id: e6cc306f-3c3e-4ceb-5462-08dac22184fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p1T8qaeYzSs19WAsyfuGK6Z45hfvbHg99KgkGKnaEQLWoxOv+143Se45IwqFihUiyk8+FljIL+Dxc93p4GLCb/hm3KsGUlenFAcDssT0YrPQqmU8kuCdcvMYR3eJ488dkteKs6BEXq+anP/DBxIQzrLy2NLyaNbX3UclBELbJI9MF2qqcGYaIoFmo+H5kBLrzlFTJgB8ah3/2mfLhwp97zO1vI+kYsWempoQtZeRv2ibX8dhyo6U1l7bz6G/76zcGAt+P718bvASWJQbY/hSU+ZSEgCJ/cLDmJx7Kb+k21yPrxaHFLZpc5NNWkOuNmnZi2IoCeHGkHaotW96zDAP61mdxcWYQ8UdgcZeXr4LmzvWXfkc6krgnHtBSh47HL40SgsHA0bteK92aNQOm5OyrmmuP0tQ/wjaWVstTy+dg8p0ze/KF7pjhwzMyWNmKm/MrtOCsTIo2LCgVb/4hgpgLfrS/vuo8+uEXSF7/j604aTrkhP2pY6uLEXCWwRZu6tf3kmxdbp9Oq35zL4XSvoOv0tx1l9Rf0F8tkMIGfjS4ssQloibmDJj91UM0j34fiUHpyJe0MIRN6euQl1LLBzKQ6gTc94/+NzmCsleDLlVTzo6QiFZNfDtF3HEDAad4Z3fB0wZD3yCpb7JEb5TICwOqk5BoC0VC5UVONHWwO3n0fTqWMHyeiGsARfGlxcjPQ+YrOnA97jfwwRBVaQP135PdnQm/EU1oSqR+CiQqmsh7PpBxKMLhcEqiR6B3kUrtZkRPwdFtzC4FLQ6mqABh49eXSreoNLCCA6JoD5ogSPI9j8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(136003)(366004)(396003)(39860400002)(451199015)(6512007)(6506007)(83380400001)(2616005)(26005)(5660300002)(66574015)(186003)(53546011)(2906002)(4326008)(8936002)(41300700001)(6486002)(316002)(8676002)(110136005)(66556008)(66946007)(66476007)(478600001)(54906003)(36756003)(31696002)(38100700002)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3YydldqVDR3SW5JUCtGZVUwNGg2V2llYWF4bFduTkJVYTAraUhuQmdJL2Fs?= =?utf-8?B?OUlSNVhodDZvZ0ovSm1YRGJxbFFvWEh6WVh2dmxHTWdSR2l1TFNoeUI1RVdy?= =?utf-8?B?ZDlyVWJmUFhYZjJVVHdqNnByT2lnRVRlaUV5OENqVjBpZ0o5VHk1bXVtZmxR?= =?utf-8?B?Vy93N1hVZUZvTmRvTGhSMGxNdFlzUVlxN0RwUGk3clNpSk1MM25OdDVrQm14?= =?utf-8?B?NjVhZVo5ZXNCMmIyb1pYOUxMMm5vRFZldnIvd1NWQVBROVR2aG1QaGcwZHNo?= =?utf-8?B?KzlsM0JCekhzb2crOWNOeUNLQzYvV05KRlJmcE8vUzVZV1VZN3RaaWUzR21h?= =?utf-8?B?dTM1RVNGYnZzeFE5dEhJSkN1QjFhVXNUY29SeDlFakpuTVgrd1JtZWtpMkJu?= =?utf-8?B?N2dvdGsyQ3N3citHcFk1a2lMM1hzczZnMHFvTlBSUHVRTjU5OWlmWExjamRo?= =?utf-8?B?WUlhdUxXNUdvb0gwRmphRVFtK2dTQ0RjQ281WVlZNXNFSEJORzk0dGdhdC9C?= =?utf-8?B?T0NTQlN0R2VLektRajVsZ3EyVkhFQ2M4bVVUTGhxK1BXMmNZcTQ0UmxDZ280?= =?utf-8?B?MUV3UkdPMGNZU3RuQjJTeEtzRGJoNmRvZWI4eTRDNTkxMXd5Wks4dkZkQ1Rt?= =?utf-8?B?eUk0eTVOc2h0WlVvWkdtUWZJU1o3UytId2RlWDUzU0NPaHpXVS9weVVYOFFF?= =?utf-8?B?cS9XSUVKQVdxVmY3TDl6bW93S3RKMk80bTIwYllXaVR6ZTh0eE5lZ2dBQ3FN?= =?utf-8?B?cGRQdG9IK1JnT1FYcW9meVl0SlU2azhUWWZpMXZUOXY1c2hQeDRZeVNBbmN4?= =?utf-8?B?dS96VDJPVm9yOVh2dnBDNHc2MUhxaWNsOXRkZHovcStmcXRGbUszTEd3cnpL?= =?utf-8?B?cXFOS2RBU09BTlNXbkVhbTNkdUxYcjBRSis2Ylczb1ZUSm41aFREREFiMkpD?= =?utf-8?B?ZkJ0QmRZT1VGMnFZZlBOWjJjWEdReWRsUWJSTWVoUytyZm44aVlmY1NwTWtz?= =?utf-8?B?eWJsbFVNL0VHN09aOGxjSzBoY094TWtLN1k3NzR5amVoQlVtaitoT1E5dy9T?= =?utf-8?B?cXFrQVl5ZzlWcUExVWVydlZaTEIyME43NjdKc0s2RDJuNU5FTWZibXk3a2ND?= =?utf-8?B?M0NpcFhUSi90THV1OVpIeGhhdG1FS09RREFWcmJMVVpMQUlXdjVXS3JLZWhp?= =?utf-8?B?R1JjTkhXT3Vnc2xlUGFmbGZIQU1zZG5IMTlvNExEcHVrcUUrTVJ6MlYzcnpI?= =?utf-8?B?SVlqbUR1Nzlya2Z3L1VBUHd1aW5CcUtBOVBrYmJEOFByTVo5c2ZmOEJ3NHVr?= =?utf-8?B?TWVUWmxSWldXWEhNMSs2b1pRYWtjQlVXV2dwU0NMNnArMTZMeDI1SzVCaVE2?= =?utf-8?B?L0FqaWp2ZCsrNUNsV0Q4ZkxabGZRYzBXMHpxZm9xcmwyTWkvM2w1cmtyaTV0?= =?utf-8?B?QUF6RmhoK1Q3ZnpIUzNmR01IeWRydEdGUUgxdUZKR2NKM2o0OEN5SlFMandR?= =?utf-8?B?Vi9HTkRPTE1rMEVsWnV4VDlUdFdtNHpwWGVMVWVUbW5FdGNpZ3k3Q0pHdnJo?= =?utf-8?B?dS9zREsxYmQrN2duaCtUWit3bXNMcFg1RXpka3krUTlWK0FDS3hIM2ZNWTdo?= =?utf-8?B?ZWJvaWF3OHplV1ZYVDkzS3VqT1hpN1hTVGYyQXlqcm9rdko2Rkw0TEdPK3lx?= =?utf-8?B?cGdNNTVJdXFVU0tuTTdmRFVJMEdOSXRFWDl2NDFHUGdJN2tFKzZKYkhPNjBG?= =?utf-8?B?OEhIdGdpdUx5L3Q2ZE5SenRDaldiZFZ1TTlaaFVCd1N5dXI0N3JrckRlUERt?= =?utf-8?B?NWFuMk5XR0haM3hUYzM2Rjd3UHRjSWFjUWYxUUxPdHRGMTYrQVRtSnBqVm1R?= =?utf-8?B?aXZsRlZnZjJnNnAra2ExSU03QzFHMXRDVmRIZDNSZ2NacENEZVd6N1VNZnIw?= =?utf-8?B?Y0hmbmV2UjA3TTV4UzIvcWNVWVh5RTdXSzlaV2FBWmtWWE9aaHR5LzhyamZD?= =?utf-8?B?OVBCZWZwVTJZV3BVdkRsSzNYdTRKSGV5U1F5RTV1V2pLZ2VyUnZwbzd4TVVm?= =?utf-8?B?L0loRDV5MWUyU2R3UXd2Tlh2RXJsYnBuaDAxMVV5bnI1OElKZUNQM2lScldq?= =?utf-8?Q?WoKlkeNDDFOCFDr381suEPCMq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6cc306f-3c3e-4ceb-5462-08dac22184fc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 07:10:44.9059 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SuSV49Sjfnbukdz7APwzj16kN4O+bt8oiJ7wx0oLysB7J5vQV6pEEjd+U0wwN1EZx51VcZTk7oK81OTQfh5zMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8522 On 09.11.2022 03:47, Henry Wang wrote: >> -----Original Message----- >> From: Edwin Török >> Subject: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build >> error >> >> Building with Dune in release mode fails with: >> ``` >> File "ocaml/xenstored/store.ml", line 464, characters 13-32: >> Warning 18: this type-based record disambiguation is not principal. >> File "ocaml/xenstored/store.ml", line 1: >> Error: Some fatal warnings were triggered (1 occurrences) >> ``` >> >> This is a warning to help keep the code futureproof, quoting from its >> documentation: >>> Check information path during type-checking, to make sure that all types >> are >>> derived in a principal way. When using labelled arguments and/or >> polymorphic >>> methods, this flag is required to ensure future versions of the compiler will >>> be able to infer types correctly, even if internal algorithms change. All >>> programs accepted in -principal mode are also accepted in the default >> mode with >>> equivalent types, but different binary signatures, and this may slow down >> type >>> checking; yet it is a good idea to use it once before publishing source code. >> >> Fixes: db471408edd46 "tools/ocaml/xenstored: Fix quota bypass on domain >> shutdown" > > Nit: The format of this "Fixes:" tag might need to be fixed? > >> >> Signed-off-by: Edwin Török >> --- >> Reason for inclusion in 4.17: >> - fixes a build error in a previous commit that is already in master > > Yes, given this is a simple enough patch: > > Release-acked-by: Henry Wang Afaics this patch was previously posted in isolation, and it was already release-acked. What's lacking there is a 2nd maintainer's ack or a proper R-b. When it now is patch 9 in a series, it isn't really obvious whether this could also be committed in isolation (it looks like it does, but a clear statement to this effect would have been beneficial). Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 09 07:15:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 07:15:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440665.694768 (Exim 4.92) (envelope-from ) id 1osfIo-0002UY-7V; Wed, 09 Nov 2022 07:15:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440665.694768; Wed, 09 Nov 2022 07:15:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfIo-0002UR-4S; Wed, 09 Nov 2022 07:15:14 +0000 Received: by outflank-mailman (input) for mailman id 440665; Wed, 09 Nov 2022 07:15:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfIn-0002UL-R3 for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 07:15:13 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2066.outbound.protection.outlook.com [40.107.249.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 405ce739-5ffe-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 08:15:12 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7282.eurprd04.prod.outlook.com (2603:10a6:20b:1d9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Wed, 9 Nov 2022 07:15:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 07:15:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 405ce739-5ffe-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UJcI0zPs/70UDdAGhOWrPd4NM2GBLrJsn9SWsrJWLUuUxa7sYG0/bXC9Pmls5IxboasUWVgKTer/rb9bOT/jBkMZ3RzbX7LFBFOZxS9FioTCJ070F0FP3w+9OrCm25hyP8RY3fU8WPMK08e2TCr5onhG88ZywOJcPIJVEgfz5aXnjrtiXuhuwMxnEPX9c7KoSPa3kSuT3Q8nHFqmKY3ZGVa3QsblvgELo3iL8j3sKwlRUAW3lyoEshJWvD79L5WqEIRLsithMyjUBNGYMJQ1shOcOZIrPzo2lJk9VP2ujMpM9PhwLOKSQUw/WqxBWlpYrwJ18Hh2hnl/HM96vzW7GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GaiVJYAu2WMdel7mQhZ8O1dh7wuW2l3yW323stwewvU=; b=ZLiqP3797SJh9H0g5lXcmGpYUKeun1zjRCnUJsCC+bjNUZ7CRLbnJalinPK30ELXqQK2T/Zw7Ut+gL3r1ynN4Uk6eDKU2TjeZzaMzMCqFspoxbBFj+a8mgTWOFtl1yXoaOg8zks1DDQpXuQxCV9sC7v/eTeWlXlIuoWQe3gYqQbhmt5Y/80g5J39vTAsIlxC0jltlFjcLj1Xj57xUEtleFXhbMxfWsHTj2clBWkxx4cPWZXTJbd4DSYBsb5KRvY3aj5NPUQmJx2PFGpDy7cbkQ6BQZHL9yUZGcpI3JVH3je1KyVk5TKjJMZdMm73GU3rZxLh7jzMS4KSyISnbCINig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GaiVJYAu2WMdel7mQhZ8O1dh7wuW2l3yW323stwewvU=; b=GJ8l9mLcn4/ATeNwxIu8NBYdcbzwvah9C7R+dcZYtGdHiJDWMzvFIRz7Ixd1VfLGwBM5eN3/n9ElMw5JRh7Kd64gtkLsbXSt+K8xnxMvtVHSyUh4L52C4COKivr2gVM8WxTK0rmfpBbijVy/ue/TPQ94Vzjazm9Wi0xuH/NacV6SnZlLdpTd0+bIXj+CKxqwYph5bJ8cKpQniQM2SqGTkr6Wt+bhxuYmecwL22B0mUghbUjEUQyBCg9REeaamtO1qY6NNdhPT5XuX6afP8L5vCdM4hBFTeu+REOYCsNezYYZ2D3/T12OPWXdckYPBecnGQVq/OQWb6NSnp9AaxG10g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8b1a60f3-ea32-b24e-ed20-9f342a82799b@suse.com> Date: Wed, 9 Nov 2022 08:15:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [xen-unstable test] 174670: regressions - FAIL Content-Language: en-US To: osstest service owner References: Cc: xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR0301CA0051.eurprd03.prod.outlook.com (2603:10a6:20b:469::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7282:EE_ X-MS-Office365-Filtering-Correlation-Id: 171490d8-a5aa-48a9-9402-08dac22223ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fgp3qnyXjem82T5REzAyt6xmLMj+I88GXRxqsQ4lhgpBPBaLVO0KqzrIMChlaoYM0STuTxb/GkSkbtH+5X/SDYdn7ULIaOzzsYpNK4Kq+fphBsThWsHDjiwz8VrIK1CJMXV7wLhQFl2/MqjNagd5ldbKK8U7jOsPMD+DyVEcVTrJYjcRW+gPfBgMyu1A6LSLjlr7pjNp9uQCXUyq11zrn4+Moyc/wJ5DLvFidTjLpujjpD2Upp757iEwvTgSNKSpKrmSe1hag96OBEmG9iYrpHRzP+tl4c5oaAlMK73wLx1bAd9ct7J8Hj3Ahs2WhHZ+YtezW8CMJw96BcrqRazlwe7Fhg/gpbmNkj9rwd8W79uSt4En6sk9CIQI/vX+ReRAF6q2e1g2/b+tUpOZ6pWr/s9i62jG7i7aXu/zADhd8jH8rM9/HiLKPrjb1NAJyvQGkTvRXoMGUbKU5zGDGph8GE6UHnXLgzAabL5BqXgEPqiTrpFhse0gTHViwAjB74K3PRhv+qa0DYTKLuPKFLZOFp1rhgyZ2NhvrJiPLyxXh7df4KX4CglMz6+nW9/iSLrvy0N5wwW7J/jev4qGB5tFqTLtqAyNxtW52+Vnwfd0C728fnf+nkX2sf+lRBLH90Ejd3ToAYZnVqXCA9ZDTqa5i/LjNyl0gECYYiYMLO2yaQ1oFKCn9im+v3mfSBVjvrpPLQZUiHe7JiIlZa6N1Yv85JRxmRxWY903N/+ZqpkisFKODlEnGnB6W0In052EQOAzg0ckrO9sB1mdiJOERvr5SyILEm/oTjmZ99wswGPB6LUkAJO1SCB59+ZN62XzdeWIpobjIVw8HLyzRWwKzTQDmA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(366004)(39860400002)(136003)(346002)(451199015)(6506007)(26005)(83380400001)(6512007)(53546011)(186003)(38100700002)(2616005)(5660300002)(4744005)(2906002)(6916009)(478600001)(4326008)(6486002)(8936002)(41300700001)(8676002)(66476007)(66556008)(316002)(66946007)(31686004)(966005)(36756003)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUhqeWhGVnZNczNTSE5uQWt6YmtKOUp6eVJDOEMzVHMyMmtMVjEweEFabTlV?= =?utf-8?B?OXpUbFJCRzdOV3d6VjAyY0tZMHNya0Jha0JESC9lQ2MrN3l3Wkw1Zk9yOWF3?= =?utf-8?B?VWs5ZkNnUnh1bkxNaEdTMFI2N3hWRXAxVEhabkREaE9WLzUxbDZCMCttbWgw?= =?utf-8?B?aE9nbXdXQW1jNmxFbDV3NnVKTXRWMmVjMjZnWk1LdTlVZkw1TmhyT25HeFJq?= =?utf-8?B?enAwUEpFUU5VVGVkeDRWaHY4aXBabmhMQkg0dGdWVWs1ZUZoL0NoOWJSdVVi?= =?utf-8?B?L0Y3NFJRcTltUWwyMEJBbndhNThXRkNwWkFGK3dvNGliNEJoVjEvU0todGtC?= =?utf-8?B?UlBjanFQRDUxVFdCRXBJYzdSVTQ3SE1PdVlkUHdZRjNuNGd4YmVxZHVaaXE4?= =?utf-8?B?dkFSZGY2eStCc0FqYjhFSjBpWWJ3YUZVVHZJY1hUSDVIWHRTTDFPRzZhSnh2?= =?utf-8?B?ckhKS09xUzVjNnZnc3ZzSk9kOHF6aW1iNDhXQ3MxLzVaTWpyVXloYzdsOVN0?= =?utf-8?B?Q0IwaDlRQUduWnRyYU1YSDEyWW8vL2JNNm8zWDVOSEN3SXBna3B6MjFIVjZO?= =?utf-8?B?VGp4bDZmSDB3MDJ4c01JMFdaUHhDcGc4S21lTXlSczIrSjM1d2JiOVJGQm1s?= =?utf-8?B?bm5Wd3pLTCtaVUE4UDc1blNTNzBrYVhYcXFLa2pOL1pkR3REZHZVKzhDQ1FQ?= =?utf-8?B?ZEUybkhBZHN1QU9MV1dMK2dJK1dWNnhBa1cwNTVBUWwySWZ6Z3VQT0dNTFJj?= =?utf-8?B?Qkx1a2M3bVRLaDhWbHFIN0ZialdPTFE4cjc0dHlMOG1tTm9kcG9VSmxPdHRp?= =?utf-8?B?Sm1ialZBUE9hKzJYSzZ6dVRKN0JzMnZUYkE3R1I2K2NzZ05tb0dGbDljdHNW?= =?utf-8?B?S2VzOWZOSlMrYkw0R3I4ME5LMVVoTCtaYmFwWkZJY2NwanZxWDJQKzdLL1BQ?= =?utf-8?B?aVY4b0l0SVZXVTJ0anJ4TS9aYVM3RWNtaUdWNE42V2tyT0ZwZmtNTCs3eDJr?= =?utf-8?B?S3FZTGdpbEZaVVlxaUtUZ2pPU3gyLzduNm1jMWpzUlVQMmJjMkMyYWtzQmsw?= =?utf-8?B?TnNXWHBhMnNFY0NPL2tyeE1Ob0U3cXdRSGRvVUdZSnBHL2N0R1kxVm1FKzJU?= =?utf-8?B?MFBPUjBKb3A4aGhtdngvTWhhdXhjTlMrQ2ZSaFgycUp5WGlyQ1FvaW1MM2ZR?= =?utf-8?B?UHUvdWZYOURhY2dqZElIbDk0OTEzVHRkMkVmYVNITFBMOThMTHM0bzJiOEZ4?= =?utf-8?B?b0xtZEdLNURqT09Td1d1cFl5bGRkcjZhOHU2YzV3SXF5UzNjdEp2Q0NYRE1M?= =?utf-8?B?YmNUSzBmaWRxQy8ra3R5ZGRLNitJclZaaHBkNG9EODFMOWxLS28yeTQxZ1JQ?= =?utf-8?B?cWdCSGJIL1dxZnhHa2FWcXBjQUVadUhjYTJkUG00UnNabkRCREVkOU1iQ1R0?= =?utf-8?B?Q0Y1bzJnVzNzbFZQMkl0Tmk1VkFNY3NMa3BVcVJtRmwxL1lFcEZVSXByM2xw?= =?utf-8?B?UG83Z3VTdElTTU00NHdlbTNmd1dySUQvRkJ0NVpoZjBrajZkeVlRZWorYlND?= =?utf-8?B?RmVsQXYyd0lOTEpnYnlmWGs4ZWVFZm55Q3E2QTFDVFJiaS9nWUxKRHEySUlm?= =?utf-8?B?K2dIOUpjbkVicUVrQkUzVllIODBrN2RVQUdiYkk2Mkd6dEthWXV5bGlPWXNY?= =?utf-8?B?bWtQZU1YK3FrQm8yNTNpZ1F1UTdackZUeFhnMmhYcWJsaFdpN01zeDlGS2ll?= =?utf-8?B?NFcycGIzSkk2d3VJcVR0MzlWWTJjV2QwQ2FYQkt5Mk1JRXRkdDNCSHR0N1B1?= =?utf-8?B?VVFSc0dLVStkT2JiYnpQbVM5Z2ZkbkQxNUtrODFFSGhvQUg1U0NPeEVQTG9o?= =?utf-8?B?UEVWTGJ1Wmx5QWlKaDlBOGQrSEYzemw2Q0dmMVdNUHd4cEJlcGRwUS9DekVD?= =?utf-8?B?OW5ac2VlbGNrR0s3UlNOOWJuVEd3cUwrUWVYem1ucG85WUpHS3dzdjFuQ2xJ?= =?utf-8?B?anZRZXliTmdxcGZnNHBTemQ0LzNrcmF6YmV1Rm1EbjJMWjRtQ3ZaUW1hbGpj?= =?utf-8?B?MEsyS3lIMno4cTdzSDFpYWtDblJJNjFycWRoYS9nL0w2aGU1SnZkNDVNbVZn?= =?utf-8?Q?zOKNX/lcgxXtyw5mPRw9/BiJ0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 171490d8-a5aa-48a9-9402-08dac22223ba X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 07:15:11.2328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: enDZMh+cenHJ3KVtmKyimbk146sHwunuS8gZNqZEC8DstrQUKe7dUh/pLr9goWWyZ6sPuK5yzaXWMLz626Fb7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7282 On 08.11.2022 21:06, osstest service owner wrote: > flight 174670 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/174670/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-arm64-pvops 6 kernel-build fail REGR. vs. 174663 This is gcc: internal compiler error: Segmentation fault signal terminated program cc1 again. Seeing this context: make[2]: *** [scripts/Makefile.build:266: arch/arm64/kvm/../../../virt/kvm/arm/vgic/vgic-v3.o] Error 4 make[1]: *** [scripts/Makefile.build:509: arch/arm64/kvm] Error 2 I wonder whether KVM really needs building in the kernels we test. Of course I don't know whether the ICE may happen randomly on about any other file as well, so another question is whether there perhaps is a fixed compiler available somewhere. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 09 07:20:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 07:20:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440672.694778 (Exim 4.92) (envelope-from ) id 1osfNl-00048G-S5; Wed, 09 Nov 2022 07:20:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440672.694778; Wed, 09 Nov 2022 07:20:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfNl-000489-P1; Wed, 09 Nov 2022 07:20:21 +0000 Received: by outflank-mailman (input) for mailman id 440672; Wed, 09 Nov 2022 07:20:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfNk-000483-MU for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 07:20:20 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2083.outbound.protection.outlook.com [40.107.103.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f698dd79-5ffe-11ed-8fd1-01056ac49cbb; Wed, 09 Nov 2022 08:20:18 +0100 (CET) Received: from AM6PR08CA0027.eurprd08.prod.outlook.com (2603:10a6:20b:c0::15) by DBBPR08MB6106.eurprd08.prod.outlook.com (2603:10a6:10:202::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 07:20:15 +0000 Received: from VI1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:c0:cafe::7c) by AM6PR08CA0027.outlook.office365.com (2603:10a6:20b:c0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 07:20:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT049.mail.protection.outlook.com (100.127.144.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 07:20:15 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Wed, 09 Nov 2022 07:20:14 +0000 Received: from cb8831f6ac18.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EF8E1FC5-6025-4713-9A56-8BCF75E2CBF8.1; Wed, 09 Nov 2022 07:20:04 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cb8831f6ac18.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 07:20:04 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11) by VE1PR08MB5581.eurprd08.prod.outlook.com (2603:10a6:800:1a0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 07:20:01 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f]) by AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f%3]) with mapi id 15.20.5813.012; Wed, 9 Nov 2022 07:20:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f698dd79-5ffe-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=daEl58Gh7ruzImDboiIUI5plqlgPoFVH4ezMxHNLcViM6691Is8gKYSEujU8a8xRX+i8S7oj2jOEzlpK08ZCokZ8OHtpyxRwirDQDjXd7iz8ukdbp1sXiDv6XzHYXf3swzh0NoF+asap6CDGBxIFYRYLgWzI10CFMHZ7Eg1TNU+0tm4bUwZqIvyEbgX9cSAMxO6LnXqZR1lnLmFKG7Dui/0A4PQkh4pFyejtXf2LdrN7pQU0RvN+P+KgRsYhoJqNnYI7XohlafKuDAyJ3wXaRipHvDFId2kzxc0x0tbbONC4jUufYZLx0Q6RSVqwYBPWylN5VcRvv82/WL+Dk6GvQw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gG+eAfoMX89UgH13kRKbv2U1hpK/zgkSDnWE7oJPfBU=; b=LHR5XTvCukMv/pU/OX4mcOuJLiI2mV8bPnMO5FXo7RO1iXZYqyQF+QkVQcGJ+g6ZsO89vLgR14KzoelBgnz0RSF3FZDtvEyDy3jFqyd7WWC4nbimQfbAi/aF1RiOELw3LvIigE0aJF9AdJFBnkUB3e1Sw0r4+TQhUqhb6GKFDyfGt+P7GucXlN7HMEjkf7BFe6fE9SW9gSi3zFlxsy+7H2rf/yykVyO3xoLgsNJupf4CN9KjCGhzMnq10CRC9rdsW6u66bIdCxczkb5qvJhNI70/EuA3Ctz5kPH3MQOVkNfwJca0yju/O9Mw1JB3hmSqSW+c+29f3iddFQnwJOH3Eg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gG+eAfoMX89UgH13kRKbv2U1hpK/zgkSDnWE7oJPfBU=; b=dlNVdSPnshhYi2jSxs8kAO/qxYxqn6zZvdRlcvQis3aIggxSnc+TCiijLIaqtHJF63FGnY72B4BA9ujjSgvZmZINpOPmnC6yLuKMtCjXKwjsgQei21916Pimla7kMu+w+ISmwGMcDISLRDnrAvltQEtKMiTYkLLbv2oVH9DV/LM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=afb6/mAP5WS+Ai9z+ebAU1SyxBPUlESekfOAQfJY30XkOWsbvx3w7+9RFsTlZ4gXWhwvfiOTj6YyX8E6IrWrjD0lj2XxXvGMmHKqZGvmRcZWkGL0qGVop6FAogy8kS7mr4hrebE3cG5a63O6r9zZrgj0Z4UxVTzOWr8nUcw6Cqk2NSepdTXnLHAKbM8fz2+qD+xWZ4dJNQeH8r8ECJGv2BuxiBgE2vuwWy/uNAkKvZv2uyHfAyQ1WTj2y+g8+0ag3jxt9fXMp75KVLz0XhkjZ/HnAfVrRwkbfM50zIEVCvrmgVPRAk0wv1oPDVjV0F7vh7mF8oEMtA/2MvV+9t3CxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gG+eAfoMX89UgH13kRKbv2U1hpK/zgkSDnWE7oJPfBU=; b=RhlzzTHWpE9qkgqptSfATnbpgWagoU0zN+CeQwelEN2h6OLuVwhXemXsX6t1+5lXbOn/wkANtGJil4SptTWEyvkXgUVUJiIrWwgp9LU6SOQI1LLe8tqPq08Z0RaJulgPGKrvTWFIk890+lPbToEvFqKttWKHuwGrtx2YwsBHCVBm4aNAP5smzV+e0TXbX7Jxdh1IBqNYo6qCxnC51j341eLpA1FZ7Vp08g7Fslf0IAQlIeMBY+Bc1lcRcrnG5Gg2tJ0VOONf9uVXETJC7DzTr6Ww6aqflvsxkNev6OkYOzm8ZSz0tf8EzWCKwUmJVRPJn/ptka6dq7qRMQgTOfzwDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gG+eAfoMX89UgH13kRKbv2U1hpK/zgkSDnWE7oJPfBU=; b=dlNVdSPnshhYi2jSxs8kAO/qxYxqn6zZvdRlcvQis3aIggxSnc+TCiijLIaqtHJF63FGnY72B4BA9ujjSgvZmZINpOPmnC6yLuKMtCjXKwjsgQei21916Pimla7kMu+w+ISmwGMcDISLRDnrAvltQEtKMiTYkLLbv2oVH9DV/LM= From: Jiamei Xie To: "xen-devel@lists.xenproject.org" CC: Wei Chen , Bertrand Marquis , "julien@xen.org" , "sstabellini@kernel.org" Subject: Xen Arm vpl011 UART will cause segmentation fault in Linux guest Thread-Topic: Xen Arm vpl011 UART will cause segmentation fault in Linux guest Thread-Index: Adj0C3U97KqJOGXWTaWwFEv08mPlLw== Date: Wed, 9 Nov 2022 07:20:01 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 722B2FE40F27AC4DAE7755EEC2C99440.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7696:EE_|VE1PR08MB5581:EE_|VI1EUR03FT049:EE_|DBBPR08MB6106:EE_ X-MS-Office365-Filtering-Correlation-Id: 9454fd2c-1e65-41a8-f25d-08dac222d90f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: rfV01Ow82LyIKAPiz8iXI9i+r5Sd3XYlRu5fn6ycn/4FXPfOkgBdNVmSAztnxilNPSfv0AqPRGNB71Wl8KAHooyR0LEKB9u0sp2wOBXxh7ffF5Zk0LLlDoH8edOpqd5sFGr8QEGsJrboAocutdc9TFjtNCryiPjozp4ZuYycpp68AGvdOXej7/FcezK/kx0Z2sP8uKqLbCeqiu51VYiIQg/hybx3uWp5BWRnUCLk/jCQgzkvLJVUZdsz5SKGelVXry1RsQObqBpyqDRf6X5fYt46LFUiAF9iToX6YXg/6g9+/FDCjxKk2R7I/P80XCPYqLcSsXJcaQ+4RGwIuZhZ+NgYlC5fEf4+8nq5LQe6AWioYNO2OUZEx8szfQxPZZCmArEak12qCRkZmJHS9Ax73J5e8LbwT4xhCNLhps2aUJ8KKH8WPughKXguEYkQcSWKpylSD+BgwTeu/SiLDOF+FePRD3w34N66hmnJ0UFImUqvGpyZTmQmHhWVgrSUi6k5Mf83ItKfCAqsW/NctqH7DdywFTRQ06sJkFf7Cg+nFidlmdDQRIrAchB4molQmaUBPSSyLSnX5bXnsRyS7S0sJ663pak4inM+I0BO4clX8PiWhenvziSTvhloluibX/FnB5LLXCjB/wNxS93+oiPYkQNm2BSdPoH1cKI1Jto0lzrprOcwJ/fqwGQzzBwnkVugYlT3w2joXtTpVfWZYmhOZTS9ce5lnYvc8tOU5JQMBFEdcg3TksPjIz6n5iMlLmvnYG3z62dcL0ILbQ/438ovcA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(39860400002)(346002)(136003)(376002)(451199015)(316002)(6506007)(7696005)(33656002)(5660300002)(186003)(83380400001)(55016003)(2906002)(122000001)(64756008)(8676002)(4326008)(66446008)(66476007)(76116006)(66946007)(66556008)(9686003)(38100700002)(86362001)(26005)(41300700001)(8936002)(52536014)(66899015)(71200400001)(478600001)(6916009)(54906003)(38070700005)(45080400002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5581 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4b87b011-4ef8-44a0-b453-08dac222d09d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZYHygS71hcRayYehTWLYW0v9YP8CKsArhz00fs4HPLfRFsrMNi2r98KdPbgBpysbul3EPDiaM6j3sUzdmStMQ9yTM5fvFBbq1KmrBokJ+cIdD0kCGytHxSJe+VA5RzKyU/Z366ffFEzNTVphvlDIMNd3h+3CCkLEVZxcUApcJE3O7Kptyxz2VSHuWs27+2UeAhcasfAdpecgRdCu1qj+67BZiTYaZj7vcj025aph5UolODNbJm6v1zyLxgI0G5LVmnRl3e4WCjDj1tnjjHp0DHsIf9myL2bKZqnIiaPYmFAccsiMwCtdWPgfiWe6DyWxFDMCEYozNuu09qRUTWH/yAiYZqeb3mWw/lWERN1b22ka2/1UQmm0HDnw2NVSgj6YRVuAM4uaZ5THhtXY1Bax6jiNtOCIBg4Azec9gcuXzQWgozCrgKH1v02oPlciIc86SZbOiBgRqTCeAuxqjTelPF8pRu3YKimz+aAwytMIKD6/qtk8Kjb5Z3Mu682xxLZIpJ3ueS4/Ki2/tHPn0Uajwmqfz1aH7JZy0JlY9YnFhKvwVfM6XvYT3+MiQBeUpRXGcjtbdI5hZZ08FfRBgxkd5R3lDKKApsjBaXJzB9O9k/Lu2/mH9JAITM33RwJ8K39Tuje2PDZogntgOxMXfmlhh0a8wFyoJJRolDfM+k59SDQpAVqYOD2oFVJVcB69HT2eVbW4EmIuOnIHMJapIdXkOMJKwFv0sa0CBptVEgwQxhuPslTxNZ+lP2KA5qedFyUN+jT3FoltpWDkEogDWvozeg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199015)(36840700001)(40470700004)(46966006)(82310400005)(47076005)(6506007)(83380400001)(336012)(186003)(26005)(7696005)(9686003)(86362001)(40460700003)(33656002)(36860700001)(356005)(81166007)(55016003)(82740400003)(40480700001)(70206006)(70586007)(5660300002)(66899015)(41300700001)(8676002)(2906002)(4326008)(478600001)(8936002)(52536014)(107886003)(54906003)(6916009)(316002)(45080400002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 07:20:15.1630 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9454fd2c-1e65-41a8-f25d-08dac222d90f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6106 Hi all, When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=3Dy", Linu= x AMBA PL011 driver will access PL011 DMACR register. But this register hav= e not been supported by vpl011 of Xen. Xen will inject a data abort into gu= est, this will cause segmentation fault of guest with the below message: Unhandled fault at 0xffffffc00944d048 Mem abort info: ESR =3D 0x96000000 EC =3D 0x25: DABT (current EL), IL =3D 32 bits SET =3D 0, FnV =3D 0 EA =3D 0, S1PTW =3D 0 FSC =3D 0x00: ttbr address size fault Data abort info: ISV =3D 0, ISS =3D 0x00000000 CM =3D 0, WnR =3D 0 swapper pgtable: 4k pages, 39-bit VAs, pgdp=3D0000000020e2e000 [ffffffc00944d048] pgd=3D100000003ffff803, p4d=3D100000003ffff803, pud=3D10= 0000003ffff803, pmd=3D100000003fffa803, pte=3D006800009c090f13 Internal error: ttbr address size fault: 96000000 [#1] PREEMPT SMP Modules linked in: CPU: 0 PID: 132 Comm: bootlogd Not tainted 5.15.44-yocto-standard #1 pstate: 604000c5 (nZCv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=3D--) pc : pl011_stop_rx+0x70/0x80 lr : uart_tty_port_shutdown+0x44/0x110 sp : ffffffc00999bba0 x29: ffffffc00999bba0 x28: ffffff80234ac380 x27: ffffff8022f5d000 x26: 0000000000000000 x25: 0000000045585401 x24: 0000000000000000 x23: ffffff8021ba4660 x22: 0000000000000001 x21: ffffff8021a0e2a0 x20: ffffff802198f880 x19: ffffff8021a0e1a0 x18: 0000000000000000 x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 x11: 0000000000000000 x10: 0000000000000000 x9 : ffffffc00871ba14 x8 : ffffffc0099de260 x7 : ffffff8021a0e318 x6 : 0000000000000003 x5 : ffffffc009315f20 x4 : ffffffc00944d038 x3 : 0000000000000000 x2 : ffffffc00944d048 x1 : 0000000000000000 x0 : 0000000000000048 Call trace: pl011_stop_rx+0x70/0x80 tty_port_shutdown+0x7c/0xb4 tty_port_close+0x60/0xcc uart_close+0x34/0x8c tty_release+0x144/0x4c0 __fput+0x78/0x220 ____fput+0x1c/0x30 task_work_run+0x88/0xc0 do_notify_resume+0x8d0/0x123c el0_svc+0xa8/0xc0 el0t_64_sync_handler+0xa4/0x130 el0t_64_sync+0x1a0/0x1a4 Code: b9000083 b901f001 794038a0 8b000042 (b9000041) ---[ end trace 83dd93df15c3216f ]--- note: bootlogd[132] exited with preempt_count 1 /etc/rcS.d/S07bootlogd: line 47: 132 Segmentation fault start-stop-daemon In Xen, vpl011_mmio_write doesn't handle DMACR . And kernel doesn't check i= f pl011_write executes sucessfully in pl011_dma_rx_stop . So such segmentat= ion fault occurs. static inline void pl011_dma_rx_stop(struct uart_amba_port *uap) { /* FIXME. Just disable the DMA enable */ uap->dmacr &=3D ~UART011_RXDMAE; pl011_write(uap->dmacr, uap, REG_DMACR); } I think we should prevent such segmentation fault. We have checked the PL01= 1 spec, it seems there is not any register bit can indicate DMA support sta= tus of PL011. We might have two options: 1. Option#1 is to add DMA support for vpl011, but this is not trivial. 2. Option#2 is to ignore the write to DMACR, and return 0 for DMACR read in= vpl011. But this option need co-work with kernel, because current Linux PL= 011 driver assume the write operation will never be failed, and will not fa= llback to no-DMA mode, when Xen return 0 for DMA enabled bit in DMACR. How do you think about it? Any suggestion about it is welcome. Thanks. Best wishes Jiamei Xie From xen-devel-bounces@lists.xenproject.org Wed Nov 09 07:37:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 07:37:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440679.694790 (Exim 4.92) (envelope-from ) id 1osfdz-0006Mj-Cr; Wed, 09 Nov 2022 07:37:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440679.694790; Wed, 09 Nov 2022 07:37:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfdz-0006Mc-A1; Wed, 09 Nov 2022 07:37:07 +0000 Received: by outflank-mailman (input) for mailman id 440679; Wed, 09 Nov 2022 07:37:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfdy-0006MV-1I for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 07:37:06 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130057.outbound.protection.outlook.com [40.107.13.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e5e08ca-6001-11ed-8fd1-01056ac49cbb; Wed, 09 Nov 2022 08:37:04 +0100 (CET) Received: from DB6PR1001CA0016.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::26) by VE1PR08MB5648.eurprd08.prod.outlook.com (2603:10a6:800:1af::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 07:37:01 +0000 Received: from DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b7:cafe::9a) by DB6PR1001CA0016.outlook.office365.com (2603:10a6:4:b7::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 07:37:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT049.mail.protection.outlook.com (100.127.142.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 07:37:01 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Wed, 09 Nov 2022 07:37:00 +0000 Received: from 26798a4ec1a8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 59340BB6-F2F5-4E91-AC9F-4E3D67F76701.1; Wed, 09 Nov 2022 07:36:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 26798a4ec1a8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 07:36:55 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DU0PR08MB9704.eurprd08.prod.outlook.com (2603:10a6:10:444::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 07:36:52 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%6]) with mapi id 15.20.5813.012; Wed, 9 Nov 2022 07:36:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e5e08ca-6001-11ed-8fd1-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lTA99b4+97FEyTmCKYJ9SgBmILl0BMLruj8gOGtoyulqcR10P6eMRiFcf9BTKMFS/7XvHlnyjSqPTBsPb0qxFNipnl9cEiljp1l82p2u9gyNgbV6OYCq7iH3HVMTVqzTNNCv3gDf/mD0hj/2PZtLzow4+5PquVClJe5Cnnt65me/ORzjZ2XT3lkdwf+qoJMJauhl+7M/azrnfxZ/FbNAyxK6jRJPWNmsWjFOGjjPOaRkBChPGM+faRMVTfFl8gez3XkNfE+ffT0OmN+cpc8LYj+/6s3V4UL32pCXEoUiHTStgF2T/TPw8QPU5v1YTVioER5IE8TRxIPJBz9vGYNTQA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5vns+0iou+lENK/ivLgNbjkfAx/dahjp+GaEwI/zT/E=; b=RvlOdw4dgE2FQcoT0raeXvzzkqX8N0IvbUhiRgHfWfbaBuodO4fvXqPcq8T7Slp3p820ugn3T/nXzfO2nhJegsWAY3gb6Q/9IAQl5rD85z1LfI9Bft8URaukAHkWMQT2J71L/1/MWj7efUcrJ3JUiH+lh3Y1u9S50kFRYRZZqUR72KltmwBdBSzsk0Npnututiwx4XopknPciNnzkrus09k+NXGyi4LL6J0qsd8EQ3lFOVF0dMMPgnTJKcllzRJ+TNn1AyWpMFMdUjhPN8ijpjGR/cZQCHvUYbYlTZilqoA/iMaBli6bHLzwwNTLx6U1XGdI+0jfSIteIFEPGXpu8A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5vns+0iou+lENK/ivLgNbjkfAx/dahjp+GaEwI/zT/E=; b=wgj4bd5LaXYULl4P0zVyw6ZeZ4UWJ9xGwZrAu0FqG6OrG6RI4ZW/YQAcY5/WV55s/9NfUb/Z+lIs60dve6UTzz3vqWlj90Gy5sJxCV39agSh7RVSz+D3Am9AgLO2SxcsxY5/xxvl1NpUBUglcKV+iQZw8msbCKXuI1JGxg854Ac= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ej6HDqxTr113oeCqTWhp63LFrXeUuJivh//85EqLIZrkl4JhTvqQzEbovEE+HdMurkSAAtjfhx+CK2kD8WxPePlIV4fE1byAm3SSol2Sq06EbGIVBUERDefwsLjfBmNYwvEbMGc3jaWcF00HnGrfGXgqFmknWFeObjAPO3UcHvunIbfIcoYDiGtkZzCpyYaOH27DIn1vFfd/O7bsGiE00z6zJe+/y8Rewh1wcCYIZ+FC8SLiXc0fQhVDlavX+xQoDy05VSR/FM9Lw8wf4G9R4IeKTUB84/MY3hZimE5TE/GrMBYV4qyqkIJamoGLljaI9stGgOCRTrnJ55J+LGG/bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5vns+0iou+lENK/ivLgNbjkfAx/dahjp+GaEwI/zT/E=; b=FZfEJiuUxXOPOVqul4tTk48AaHLFHjNA03kS0du2tWvURE41qcgvjMrwYUwKk+zSIh3KK71EhBLlvOZ9EzzVjDLJxCuyHSv5NMU1BVwZHIhhQ3Z+FGXCE2SFV4bRjyPsESNGZjOf4VLMrnXUBKWos+JF7mlOlWlEMNquPU1r0/dehR/E+jQUYrDsVJsf5HDCFTVOGw7aUduXS/Byn6xLPJGWUiwKs5PQNnraE8jtK/RVj3VqUmBLduMpBbfNhSVuRvLFhbXpext5uEChsWeE7DLx9RxCGXEpGQ8eQ1OnYSig7lz85swy8BCuRfeG2FYgOW5J9NH+V31NiJpbtF0ZNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5vns+0iou+lENK/ivLgNbjkfAx/dahjp+GaEwI/zT/E=; b=wgj4bd5LaXYULl4P0zVyw6ZeZ4UWJ9xGwZrAu0FqG6OrG6RI4ZW/YQAcY5/WV55s/9NfUb/Z+lIs60dve6UTzz3vqWlj90Gy5sJxCV39agSh7RVSz+D3Am9AgLO2SxcsxY5/xxvl1NpUBUglcKV+iQZw8msbCKXuI1JGxg854Ac= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: RE: [PATCH v6 08/11] xen/arm64: move MMU related code from head.S to head_mmu.S Thread-Topic: [PATCH v6 08/11] xen/arm64: move MMU related code from head.S to head_mmu.S Thread-Index: AQHY8DVrMB29cZJCrk+wAkCu80OmKq4yVgCAgAPeDBA= Date: Wed, 9 Nov 2022 07:36:51 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-9-wei.chen@arm.com> <5b975a59-5e97-c2a8-805c-9ab99b8712aa@xen.org> In-Reply-To: <5b975a59-5e97-c2a8-805c-9ab99b8712aa@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 61B006AB516CED4087C067F3B9318C18.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|DU0PR08MB9704:EE_|DBAEUR03FT049:EE_|VE1PR08MB5648:EE_ X-MS-Office365-Filtering-Correlation-Id: b8218745-ed58-4534-8714-08dac2253090 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1q6DLx26Xt86ovXFsA3tAtJUs/q5Y5NdEDkP/n9vU/gzr0fyOuf3gvjzLxVSUY0vI64eDfb7Med2BWu0quBiyjwEHvKqi4h5jBXok3cwZSsrRA22tAgDAAkaLjJAzkmWpvqNXvN0WmL0wXy6LebvKhZ0t71tVpQo295kZ+7NO1aEhD3TbQrvq2tkXE/V9zeea2WFOeN1nSBlR8bJFu+dpV3C7SPgXT0Zsbn6Tmi3ZYulB6T60l9XEZMWyNkt8ibsbUiP7Rm7pf6es6cFprmF3eqPza+VBJAqy60Y9IExdhMe+95E/WpXab2fT/lFFwCVREK6EZJFeMf/wxtKtXKmLgH1ts4XqA06iyriKsXN9NYHU7ohugNQehufVnSPOOV8QRQV6CJPNLwDs8NyeiNA/UPJCOmJB1qi84h5uOnxrqkriBNWmfAzKUquHle7zV0Bxm0tfeK3+R4JKFnapvOynVKVFbTEKk+dlHbOTLorbQuOw/Mm6iOqd7FXpPIGWC2ROfgU4bG7rBhyxQyODomCKQsd/HBetqNr5ZLZnO9Pl38CGj2/YxbGaaZpQYlYErHOGs4J+/rAtJEBKRB1E5EFOlhPegcndYZUgRxTxd4p9rXFNrUzVLlRpkX0cxhU2aPYmfLP5l0ET++qLwu+BQz5VTHQVcgN3gL2L9KMdiBFXDoJbJkzgErlwTWgAgkAPe8HPGoVG6NpVdX5Zurq11L+kENn5B+KPpW+kEHPq1nRqnayOQrUeTUHEiZxyWgM2WlUQgiSFqfSegMKTLQDhxvXu25QpsCqZ8TCiW13n+OAdrU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(396003)(366004)(136003)(451199015)(66556008)(71200400001)(8936002)(8676002)(41300700001)(4326008)(76116006)(33656002)(52536014)(2906002)(66946007)(122000001)(64756008)(66446008)(66476007)(5660300002)(316002)(54906003)(55016003)(38070700005)(83380400001)(478600001)(7696005)(38100700002)(86362001)(6506007)(26005)(53546011)(186003)(9686003)(110136005)(66899015)(60764002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9704 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 652a8be0-8069-4ce2-6bfc-08dac2252b10 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7LkqSOwCJaklUy/P+yypJKVCklZQYmSqq3srZrd1lb0OMXydiwbEQ/RC5MCYn9Ws+TTb4PV8FKMD+MNDGDnqOpYT1QvjNCLVuTphwHxr8BVZCt5ZbKYofTGOCjmd8g/P686kr+jURz5xO8eCBAS267ZsR745f4Rzb1qFkOAfLayyzl4Z90VQP/vvKtVowZ9yHSZAPA+B4aYVQh78SSlu5UD4a07PvFLt6TR2ZBV4EFou4ozdCtbF6qnYE+3IWNEHx1EZ94LlHkCMpfATg/VQ7BgJPI2Ym10BTqAKFK+pZBNesFD+Lh3Pk+dm3wzPxkVg5U8T0JfwdxTV3tBAqjSr0QYOpI4Q+1CYHAqLcdjtSEwyRvm5mfsiTIPvIMYfnotvOd6pfMSp7ZephUiGrCWq5wwDATJukEdYhxspjYf28fvWQMITGl7ZPs8SuE1DAftAI+T35BWJHNok71E6kAaaz16HPInAeP8VamEeOj4C/DW9vd1SHPFefgk86hXWAF5sgDRYLLRN26Z0O2k5sqGTKgKvpCgF3/gAbre7+5xFSmOeiNh4cVqdpGoU9mW84lhjqS/xYtn2b6JLDWW/wXz5cFfXrYGg65omr0mZhNM1mL95Q9p3H+j7vn+SG5Q6PqV+dx+zkTfwJ+0FsWkTKlDXk23DlvEZji3YbAvJVzxBK+RYI4+ALlm5r/t7+8xX7Mib6FlkQ5935YwU9XiCLurL+OxeU2F8tC2FDDhQjmvLJkbaURFSd70EUDB6ECC0VFrJi+OTFWT4z9RyH6hGeqCv2iJ0iFi+3fFvho+OjG6KaL4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(136003)(396003)(451199015)(46966006)(36840700001)(40470700004)(70206006)(4326008)(40480700001)(55016003)(70586007)(110136005)(316002)(54906003)(82740400003)(52536014)(5660300002)(8676002)(36860700001)(33656002)(2906002)(7696005)(6506007)(47076005)(40460700003)(186003)(26005)(83380400001)(336012)(8936002)(53546011)(9686003)(478600001)(86362001)(81166007)(356005)(41300700001)(66899015)(82310400005)(60764002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 07:37:01.0546 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b8218745-ed58-4534-8714-08dac2253090 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5648 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQxMeaciDfml6UgNDowNg0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcNCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3Rh YmVsbGluaUBrZXJuZWwub3JnPjsgQmVydHJhbmQNCj4gTWFycXVpcyA8QmVydHJhbmQuTWFycXVp c0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0u Y29tPjsgSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KPiBTdWJqZWN0OiBSZTogW1BB VENIIHY2IDA4LzExXSB4ZW4vYXJtNjQ6IG1vdmUgTU1VIHJlbGF0ZWQgY29kZSBmcm9tIGhlYWQu Uw0KPiB0byBoZWFkX21tdS5TDQo+IA0KPiBIaSBXZWksDQo+IA0KPiBPbiAwNC8xMS8yMDIyIDEw OjA3LCBXZWkgQ2hlbiB3cm90ZToNCj4gPiBUaGVyZSBhcmUgbG90cyBvZiBNTVUgc3BlY2lmaWMg Y29kZSBpbiBoZWFkLlMuIFRoaXMgY29kZSB3aWxsIG5vdA0KPiA+IGJlIHVzZWQgaW4gTVBVIHN5 c3RlbXMuIElmIHdlIHVzZSAjaWZkZWYgdG8gZ2F0ZSB0aGVtLCB0aGUgY29kZQ0KPiA+IHdpbGwg YmVjb21lIG1lc3N5IGFuZCBoYXJkIHRvIG1haW50YWluLiBTbyB3ZSBtb3ZlIE1NVSByZWxhdGVk DQo+ID4gY29kZSB0byBoZWFkX21tdS5TLCBhbmQga2VlcCBjb21tb24gY29kZSBzdGlsbCBpbiBo ZWFkLlMuDQo+IA0KPiBJIGFtIGFmcmFpZCB0aGF0IHlvdSBjYW4ndCBzaW1wbHkgbW92ZSB0aGUg TU1VIGNvZGUgb3V0IG9mIGhlYWQuUw0KPiBiZWNhdXNlIHRoaXMgd2lsbCBicmVhayBYZW4gd2hl biBydW5uaW5nIHVzaW5nIHRoZSBpZGVudGl0eSBtYXAuDQo+IA0KPiBUaGlzIGlzIGJlY2F1c2Ug d2Ugb25seSBtYXAgdGhlIGZpcnN0IDRLQiBvZiBYZW4gd2l0aCBQQSA9PSBWQS4gQXQgdGhlDQo+ IG1vbWVudCwgd2UgZ3VhcmFudGVlIGl0IGJ5IGhhdmluZyBldmVyeXRoaW5nIHRoYXQgbmVlZHMg dG8gYmUgdXNlZCBpbg0KPiB0aGUgaWRlbnRpdHkgbWFwcGluZyBiZWZvcmUgX2VuZF9ib290IGFu ZCBjaGVja2luZyBhdCBsaW5rIHRpbWUgaWYgdGhpcw0KPiBmaXRzIGluIDRLQi4NCj4gDQo+IE5v dyB0aGF0IHlvdSBtb3ZlZCB0aGUgTU1VIGNvZGUgb3V0c2lkZSBvZiBoZWFkLlMuIFdlIG5lZWQg dG8gZmluZCBhDQo+IGRpZmZlcmVudCB3YXkgdG8gZ3VhcmFudGVlIGl0LiBPbmUgd2F5IHRvIGRv IGl0IHdvdWxkIGJlIHRvIGNyZWF0ZSBhDQo+IHNlY3Rpb24gdGhhdCB3b3VsZCBiZSB1c2VkIGZv ciBldmVyeXRoaW5nIHRoYXQgbmVlZHMgdG8gYmUgaWRlbnRpdHkgbWFwcGVkLg0KPiANCg0KUXVv dGUgZnJvbSBuZXh0IGVtYWlsDQoiDQpMb29raW5nIGF0IHRoZSBjb2RlIHRoaXMgbW9ybmluZywg SSBub3RpY2VkIHRoYXQgd2UgYWxyZWFkeSBoYXZlIHRoZSANCnNlY3Rpb24gIi50ZXh0LmhlYWRl ciIuIEZvciBub3csIHRoYXQgc2hvdWxkIGRvIHRoZSBqb2IuIFNvIHdlIGp1c3QgbmVlZA0KdG8g Y2hlY2sgdGhlIHNpemUgb2YgLnRleHQuaGVhZGVyLg0KDQpJZGVhbGx5LCBjaGVja2luZyB0aGUg c2l6ZSBzaG91bGQgYmUgZG9uZSBpbiBhIHNlcGFyYXRlIHByZS1wYXRjaCBzbyBpdCANCmlzIGVh c2llciB0byByZXZpZXcuDQoiDQoNCk9LLiBXZSB3aWxsIGNyZWF0ZSBhIHBhdGNoIHRvIGNoZWNr IHRoZSBzaXplLCBhbmQgcGxhY2UgaXQgaW4gdGhlDQpoZWFkIG9mIHRoZSBzZXJpZXMuDQoNCj4g Pg0KPiA+IEFzIHdlIG5lZWQgdG8gYWNjZXNzICJmYWlsIiBhbmQgInB1dHMiIGZ1bmN0aW9ucyBv dXQgb2YgYXNzZW1ibHkNCj4gPiBmaWxlLCBzbyB3ZSBoYXZlIHRvIGV4cG9ydCB0aGVtIGluIHRo aXMgcGF0Y2guIEFuZCB0aGUgYXNzZW1ibHkNCj4gPiBtYWNyb3M6IGFkcl9sIGFuZCBsb2FkX3Bh ZGRyIHdpbGwgYmUgdXNlZCBieSBNTVUgYW5kIE1QVSBsYXRlciwNCj4gPiBzbyB3ZSBtb3ZlIHRo ZW0gdG8gbWFjcm9zLmguDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBIZW5yeSBXYW5nIDxIZW5y eS5XYW5nQGFybS5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogV2VpIENoZW4gPHdlaS5jaGVuQGFy bS5jb20+DQo+IA0KPiBJbiBnZW5lcmFsLCB0aGUgZmlyc3Qgc2lnbmVkLW9mZiBzaG91bGQgbWF0 Y2ggdGhlIGF1dGhvci4gU28gd2hvIGlzIHdobw0KPiBoZXJlPw0KPiANCg0KSSB3aWxsIGFkanVz dCB0aGlzIG9yZGVyLg0KDQo+ID4gLS0tDQo+ID4gICB4ZW4vYXJjaC9hcm0vYXJtNjQvTWFrZWZp bGUgICAgICAgICAgICAgfCAgIDMgKw0KPiA+ICAgeGVuL2FyY2gvYXJtL2FybTY0L2hlYWQuUyAg ICAgICAgICAgICAgIHwgNDA3ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+ICAgeGVuL2Fy Y2gvYXJtL2FybTY0L2hlYWRfbW11LlMgICAgICAgICAgIHwgMzY0ICsrKysrKysrKysrKysrKysr KysrKw0KPiA+ICAgeGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2FybTY0L21hY3Jvcy5oIHwgIDUy ICsrLQ0KPiA+ICAgNCBmaWxlcyBjaGFuZ2VkLCA0MzIgaW5zZXJ0aW9ucygrKSwgMzk0IGRlbGV0 aW9ucygtKQ0KPiA+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS9hcm02NC9oZWFk X21tdS5TDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2FybTY0L01ha2VmaWxl IGIveGVuL2FyY2gvYXJtL2FybTY0L01ha2VmaWxlDQo+ID4gaW5kZXggNmQ1MDdkYTBkNC4uMjJk YTJmNTRiNSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vYXJtNjQvTWFrZWZpbGUNCj4g PiArKysgYi94ZW4vYXJjaC9hcm0vYXJtNjQvTWFrZWZpbGUNCj4gPiBAQCAtOCw2ICs4LDkgQEAg b2JqLXkgKz0gZG9tY3RsLm8NCj4gPiAgIG9iai15ICs9IGRvbWFpbi5vDQo+ID4gICBvYmoteSAr PSBlbnRyeS5vDQo+ID4gICBvYmoteSArPSBoZWFkLm8NCj4gPiAraWZuZXEgKCQoQ09ORklHX0hB U19NUFUpLHkpID4gK29iai15ICs9IGhlYWRfbW11Lm8NCj4gPiArZW5kaWYNCj4gPiAgIG9iai15 ICs9IGluc24ubw0KPiA+ICAgb2JqLSQoQ09ORklHX0xJVkVQQVRDSCkgKz0gbGl2ZXBhdGNoLm8N Cj4gPiAgIG9iai15ICs9IHNtYy5vDQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9hcm02 NC9oZWFkLlMgYi94ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZC5TDQo+ID4gaW5kZXggY2NlZGYyMGRj Ny4uZDlhOGRhOTEyMCAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZC5T DQo+ID4gKysrIGIveGVuL2FyY2gvYXJtL2FybTY0L2hlYWQuUw0KPiA+IEBAIC0yNSwxNyArMjUs NiBAQA0KPiA+ICAgI2luY2x1ZGUgPGVmaS9lZmllcnIuaD4NCj4gPiAgICNpbmNsdWRlIDxhc20v YXJtNjQvZWZpYmluZC5oPg0KPiA+DQo+ID4gLSNkZWZpbmUgUFRfUFQgICAgIDB4ZjdmIC8qIG5H PTEgQUY9MSBTSD0xMSBBUD0wMSBOUz0xIEFUVFI9MTExIFQ9MSBQPTENCj4gKi8NCj4gPiAtI2Rl ZmluZSBQVF9NRU0gICAgMHhmN2QgLyogbkc9MSBBRj0xIFNIPTExIEFQPTAxIE5TPTEgQVRUUj0x MTEgVD0wIFA9MQ0KPiAqLw0KPiA+IC0jZGVmaW5lIFBUX01FTV9MMyAweGY3ZiAvKiBuRz0xIEFG PTEgU0g9MTEgQVA9MDEgTlM9MSBBVFRSPTExMSBUPTEgUD0xDQo+ICovDQo+ID4gLSNkZWZpbmUg UFRfREVWICAgIDB4ZTcxIC8qIG5HPTEgQUY9MSBTSD0xMCBBUD0wMSBOUz0xIEFUVFI9MTAwIFQ9 MCBQPTENCj4gKi8NCj4gPiAtI2RlZmluZSBQVF9ERVZfTDMgMHhlNzMgLyogbkc9MSBBRj0xIFNI PTEwIEFQPTAxIE5TPTEgQVRUUj0xMDAgVD0xIFA9MQ0KPiAqLw0KPiA+IC0NCj4gPiAtLyogQ29u dmVuaWVuY2UgZGVmaW5lcyB0byBnZXQgc2xvdCB1c2VkIGJ5IFhlbiBtYXBwaW5nLiAqLw0KPiA+ IC0jZGVmaW5lIFhFTl9aRVJPRVRIX1NMT1QgICAgemVyb2V0aF90YWJsZV9vZmZzZXQoWEVOX1ZJ UlRfU1RBUlQpDQo+ID4gLSNkZWZpbmUgWEVOX0ZJUlNUX1NMT1QgICAgICBmaXJzdF90YWJsZV9v ZmZzZXQoWEVOX1ZJUlRfU1RBUlQpDQo+ID4gLSNkZWZpbmUgWEVOX1NFQ09ORF9TTE9UICAgICBz ZWNvbmRfdGFibGVfb2Zmc2V0KFhFTl9WSVJUX1NUQVJUKQ0KPiA+IC0NCj4gPiAgICNkZWZpbmUg X19IRUFEX0ZMQUdfUEFHRV9TSVpFICAgKChQQUdFX1NISUZUIC0gMTApIC8gMikNCj4gPg0KPiA+ ICAgI2RlZmluZSBfX0hFQURfRkxBR19QSFlTX0JBU0UgICAxDQo+ID4gQEAgLTgyLDczICs3MSwy MiBAQA0KPiA+ICAgICogIHgzMCAtIGxyDQo+ID4gICAgKi8NCj4gPg0KPiA+IC0jaWZkZWYgQ09O RklHX0VBUkxZX1BSSU5USw0KPiA+IC0vKg0KPiA+IC0gKiBNYWNybyB0byBwcmludCBhIHN0cmlu ZyB0byB0aGUgVUFSVCwgaWYgdGhlcmUgaXMgb25lLg0KPiA+IC0gKg0KPiA+IC0gKiBDbG9iYmVy cyB4MCAtIHgzDQo+ID4gLSAqLw0KPiA+IC0jZGVmaW5lIFBSSU5UKF9zKSAgICAgICAgICBcDQo+ ID4gLSAgICAgICAgbW92ICAgeDMsIGxyIDsgICAgIFwNCj4gPiAtICAgICAgICBhZHIgICB4MCwg OThmIDsgICAgXA0KPiA+IC0gICAgICAgIGJsICAgIHB1dHMgICAgOyAgICBcDQo+ID4gLSAgICAg ICAgbW92ICAgbHIsIHgzIDsgICAgIFwNCj4gPiAtICAgICAgICBST0RBVEFfU1RSKDk4LCBfcykN Cj4gPiArLnNlY3Rpb24gLnRleHQuaGVhZGVyLCAiYXgiLCAlcHJvZ2JpdHMNCj4gPiArLyouYWFy Y2g2NCovDQo+IA0KPiBUaGUgcGF0Y2ggaXMgYWxyZWFkeSBxdWl0ZSBkaWZmaWN1bHQgdG8gcmVh ZC4gU28gSSB3b3VsZCByYXRoZXIgcHJlZmVyDQo+IGlmIHRoZSBpbmRlbnRhdGlvbiBpcyBjaGFu Z2VkIHNlcGFyYXRlbHkuDQo+IA0KDQpPay4NCg0KPiBGdXJ0aGVybW9yZSwgSSB0aGluayBpdCB3 b3VsZCBiZSBiZXN0IGlmIHRoZSBmdW5jdGlvbnMgbW92ZWQgaW4gdGhlDQo+IGhlYWRlciBhcmUg ZG9uZSBzZXBhcmF0ZWx5IHRvIGhlbHAgY2hlY2tpbmcgKEkgd291bGQgYmUgYWJsZSB0byBkaWZm IHRoZQ0KPiBzb3VyY2Ugd2l0aCB0aGUgZGVzdGluYXRpb24gbW9yZSBlYXNpbHkpLg0KPiANCg0K RGlkIHlvdSBtZWFuIHRvIGNyZWF0ZSBhIHNlcGFyYXRlIHBhdGNoIGZvciBtb3ZpbmcgdGhlIGZ1 bmN0aW9ucyBpbiBtYWNyby5oPw0KT3IgaW4gaGVhZGVyIHNlY3Rpb24/DQoNCj4gPg0KPiA+ICAg LyoNCj4gPiAtICogTWFjcm8gdG8gcHJpbnQgdGhlIHZhbHVlIG9mIHJlZ2lzdGVyIFx4Yg0KPiA+ ICsgKiBLZXJuZWwgc3RhcnR1cCBlbnRyeSBwb2ludC4NCj4gPiArICogLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tDQo+IA0KPiBTYW1lIGhlcmUgYWJvdXQgdGhlIGluZGVudGF0aW9uLiBJIHdp bGwgbm90IGNvbW1lbnQgZXZlcnl3aGVyZSB3aGVyZSB0aGUNCj4gaW5kZW50YXRpb24gd2FzIGNo YW5nZWQuIFNvIHBsZWFzZSBsb29rIGF0IGl0Lg0KPiANCg0KT0suIHdlIHdpbGwgdXNlIGEgc2Vw YXJhdGUgcGF0Y2ggdG8gY2xlYW4gdGhlbS4NCg0KPiBbLi4uXQ0KPiANCj4gPiAtLyoNCj4gPiAt ICogTWFwIHRoZSBVQVJUIGluIHRoZSBmaXhtYXAgKHdoZW4gZWFybHlwcmludGsgaXMgdXNlZCkg YW5kIGhvb2sgdGhlDQo+ID4gLSAqIGZpeG1hcCB0YWJsZSBpbiB0aGUgcGFnZSB0YWJsZXMuDQo+ ID4gLSAqDQo+ID4gLSAqIFRoZSBmaXhtYXAgY2Fubm90IGJlIG1hcHBlZCBpbiBjcmVhdGVfcGFn ZV90YWJsZXMgYmVjYXVzZSBpdCBtYXkNCj4gPiAtICogY2xhc2ggd2l0aCB0aGUgMToxIG1hcHBp bmcuDQo+ID4gLSAqDQo+ID4gLSAqIElucHV0czoNCj4gPiAtICogICB4MjA6IFBoeXNpY2FsIG9m ZnNldA0KPiA+IC0gKiAgIHgyMzogRWFybHkgVUFSVCBiYXNlIHBoeXNpY2FsIGFkZHJlc3MNCj4g PiAtICoNCj4gPiAtICogQ2xvYmJlcnMgeDAgLSB4Mw0KPiA+IC0gKi8NCj4gPiAtc2V0dXBfZml4 bWFwOg0KPiA+IC0jaWZkZWYgQ09ORklHX0VBUkxZX1BSSU5USw0KPiA+IC0gICAgICAgIC8qIEFk ZCBVQVJUIHRvIHRoZSBmaXhtYXAgdGFibGUgKi8NCj4gPiAtICAgICAgICBsZHIgICB4MCwgPUVB UkxZX1VBUlRfVklSVFVBTF9BRERSRVNTDQo+ID4gLSAgICAgICAgY3JlYXRlX21hcHBpbmdfZW50 cnkgeGVuX2ZpeG1hcCwgeDAsIHgyMywgeDEsIHgyLCB4MywNCj4gdHlwZT1QVF9ERVZfTDMNCj4g PiAtI2VuZGlmDQo+ID4gLSAgICAgICAgLyogTWFwIGZpeG1hcCBpbnRvIGJvb3Rfc2Vjb25kICov DQo+ID4gLSAgICAgICAgbGRyICAgeDAsID1GSVhNQVBfQUREUigwKQ0KPiA+IC0gICAgICAgIGNy ZWF0ZV90YWJsZV9lbnRyeSBib290X3NlY29uZCwgeGVuX2ZpeG1hcCwgeDAsIDIsIHgxLCB4Miwg eDMNCj4gPiAtICAgICAgICAvKiBFbnN1cmUgYW55IHBhZ2UgdGFibGUgdXBkYXRlcyBtYWRlIGFi b3ZlIGhhdmUgb2NjdXJyZWQuICovDQo+ID4gLSAgICAgICAgZHNiICAgbnNoc3QNCj4gPiAtDQo+ ID4gLSAgICAgICAgcmV0DQo+ID4gLUVORFBST0Moc2V0dXBfZml4bWFwKQ0KPiA+IC0NCj4gPiAg IC8qDQo+ID4gICAgKiBTZXR1cCB0aGUgaW5pdGlhbCBzdGFjayBhbmQganVtcCB0byB0aGUgQyB3 b3JsZA0KPiA+ICAgICoNCj4gPiBAQCAtODEwLDQxICs0NTgsMTQgQEAgbGF1bmNoOg0KPiA+ICAg RU5EUFJPQyhsYXVuY2gpDQo+ID4NCj4gPiAgIC8qIEZhaWwtc3RvcCAqLw0KPiA+IC1mYWlsOiAg IFBSSU5UKCItIEJvb3QgZmFpbGVkIC1cclxuIikNCj4gPiArRU5UUlkoZmFpbCkNCj4gDQo+IFRo aXMgbmFtZSBpcyBhIGJpdCB0b28gZ2VuZXJpYyB0byBiZSBleHBvc2VkLiBCdXQgaXQgd291bGQg YmUgYmV0dGVyIHRvDQo+IGR1cGxpY2F0ZSBpdC4NCg0KWWVzLCBkdXBsaWNhdGUgaXQgbWlnaHQg YmUgYmV0dGVyLiBXZSB3aWxsIGRvIGl0IGluIG5leHQgdmVyc2lvbi4NCg0KQ2hlZXJzLA0KV2Vp IENoZW4NCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 09 07:39:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 07:39:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440684.694801 (Exim 4.92) (envelope-from ) id 1osfgg-0006x2-S7; Wed, 09 Nov 2022 07:39:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440684.694801; Wed, 09 Nov 2022 07:39:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfgg-0006wv-Ny; Wed, 09 Nov 2022 07:39:54 +0000 Received: by outflank-mailman (input) for mailman id 440684; Wed, 09 Nov 2022 07:39:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfge-0006wT-UR for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 07:39:53 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2072.outbound.protection.outlook.com [40.107.220.72]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b0e2ef83-6001-11ed-8fd1-01056ac49cbb; Wed, 09 Nov 2022 08:39:51 +0100 (CET) Received: from BN0PR02CA0014.namprd02.prod.outlook.com (2603:10b6:408:e4::19) by BY5PR12MB4274.namprd12.prod.outlook.com (2603:10b6:a03:206::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Wed, 9 Nov 2022 07:39:47 +0000 Received: from BN8NAM11FT107.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e4:cafe::57) by BN0PR02CA0014.outlook.office365.com (2603:10b6:408:e4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 07:39:47 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT107.mail.protection.outlook.com (10.13.176.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 07:39:47 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 01:39:47 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 8 Nov 2022 23:39:46 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Wed, 9 Nov 2022 01:39:45 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0e2ef83-6001-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sk95a+d+CpsoQEzANfrPYdO8mLJjANRvBxdrOFb0aVWy+E+J/DQmBuGnHPL4Mt6gIHSDv6ibJQ74WF6I+2nKpCF02EYBIUf+mCCayqkmOfRoik9G9896Vu4YkhI5CPHvSUe8BqzZwwvOA1WRi+pDxtbSRJ7nApIhfSBS15esIyRv0c9BDb8Kz9pwL91nt5GO8T7/jTYs47OaWo4PgpJf6LPWWK54sc/ZfuyQO3V3eBUGPLmY6jXr0VpVbFhKrn5PWXbq6w0UyDqGosCqMNyQSVFdtzHyEzIyFbWRQE06GU5GeXOY62hVeaBeuHGrlHdQxYlcttEtzE5X2z8nG9SphQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/dQMi26gSvPrEZIdgRLM3IVcrVDaYptKP3TpGSL2Nzg=; b=bAaIDsy44mbIoOqy7Txc9dLcaHDNEw6NiL1qsTt56NhGyw6Jb9AszLyQ/MehzMl+0kCJCPfPoYGWTb7eKFs9230ajCgK6Okikf8K0pK1EkqwsaH+f1+Z+GjNDWqF9tV4Nu5ZB+JBEtzrgfBM9wWH10G/Oh61a9Evuzg+VglvRjUYOEUOp5oHd7LYFMt+yhe3VYZegGgJR6hpYYwkXoNPal+WYiJUdQRpDbcREaz+pNTar7z+280Wa5Egk3fTd1AUarpAsOHMPazXTLrBGVFWig9y3gRGLdYFixsxLbf0+pLLIguFkVVV8C3A32wf5C2Fttwrp6xVnhEbhR2k8vWHXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/dQMi26gSvPrEZIdgRLM3IVcrVDaYptKP3TpGSL2Nzg=; b=un2UQM3qQKm7KvrN45XMHk2woy5RFDDSUl0hNn6lIKTJdmXqDQP93JsyjyvZsjipIswjOFGmCDW8BeafQw6ErvJtCKjt5uSIJrv8aIbwwLuKJIiQ9xE5eTi4oyVyMeJBZ1hUapQ1xrHv3aQ960jOhCzK0u6vwEvJE2NrT+/Zn6g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <00764fe2-f78a-e5db-cb16-903ad1a5ec03@amd.com> Date: Wed, 9 Nov 2022 08:39:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Xen Arm vpl011 UART will cause segmentation fault in Linux guest To: Jiamei Xie , "xen-devel@lists.xenproject.org" CC: Wei Chen , Bertrand Marquis , "julien@xen.org" , "sstabellini@kernel.org" References: Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT107:EE_|BY5PR12MB4274:EE_ X-MS-Office365-Filtering-Correlation-Id: dc54258c-9b0c-428b-b21d-08dac22593af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: barWOInO+niBwA9SFQfPXDvUGbk1pkyecS88TkGA/H6j18dcXZlwR4ZmickGnN0c9/APG8/ENraZpAiGPxpYt96d/ASa7UH7pfKX1zaHHJuNHRMJkMwAA6huJoppcvvqXFMJqI5UAKf4Ukhakp3oJ1DqSi6q3bXFN3QGY57W2NXIHxxH4k6KrwIFVH4kvsjSwMkPbmJCsa8RJgy5IYN2Me8nFX3+8GOSfA1jQuzMuVIoAolRVjTjzTETuf1iiKqt7X1PL5sawQjWBa+q6C7syZ0ubm7jAngqwhcsFmPpoRgrE4Sq8kui1MweD+CntAw5UMy/Pe/QuqWHldH683ARi4Gsxr0Kf2R5QxYaQlAOx4ccqDGBgqag13HTDpalkgrY/dY4j6QmrUALICiQJRILXcYYVBdojxGfvXT728W2HAFmffgynzV/lu5sp5VXjyG4dKtH+w62xjEIV84/liddrjMnwEQ/hWBRQ+ypSyQ/u6vFzaywj4Gx9b4yOA2jR5qR2JKs2NxA6y4I3hUbDdyzb3/U3d0wYVEmedh7Yuz/muvUsweJouuyoWytV1gmpe6B0wnlZFHn0YArWJRNWut2nv2Q52rAmW7UXRUQZE2EZ4BOQhTkVaMC8SXvJG6h2GY5ANYFl+xEvd48by/PDPlOcL7kVmdW0xx00IxFkZfKz4bShlqJMYvlS3PQ3cauJ1CZauUyhpoXul/wruoBFbfxqQV3BPb72ILIrDBKVnJ5CXwHk8AoYX80UZCBAdboAp8iMaPhZDFZE/i6osbtVNuJ/NMyF+5aG8YLTjcMdro3+XSK9FN60OLcpnWQEich2CMyHJAd8Bi497FjMf6uXz09dA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199015)(36840700001)(46966006)(40470700004)(40480700001)(47076005)(41300700001)(186003)(8936002)(44832011)(2616005)(5660300002)(36756003)(4326008)(26005)(8676002)(70206006)(70586007)(53546011)(336012)(2906002)(426003)(81166007)(31696002)(86362001)(82740400003)(82310400005)(83380400001)(356005)(40460700003)(31686004)(110136005)(36860700001)(54906003)(45080400002)(6666004)(478600001)(316002)(16576012)(66899015)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 07:39:47.3221 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc54258c-9b0c-428b-b21d-08dac22593af X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT107.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4274 Hi Jiamei, On 09/11/2022 08:20, Jiamei Xie wrote: > > > Hi all, > > When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", Linux AMBA PL011 driver will access PL011 DMACR register. But this register have not been supported by vpl011 of Xen. Xen will inject a data abort into guest, this will cause segmentation fault of guest with the below message: I am quite confused. VPL011 implements SBSA UART which only implements some subset of PL011 operations (SBSA UART is not PL011). According to spec (SBSA ver. 6.0), the SBSA_UART does not support DMA features so Xen code is fine. When Xen exposes vpl011 device to a guest, this device has "arm,sbsa-uart" compatible and not "uart-pl011". Linux driver "amba-pl011.c" should see this compatible and assign proper operations (sbsa_uart_pops instead of amba_pl011_pops) that do not enable DMA. Maybe the issue is with your configuration? ~Michal > Unhandled fault at 0xffffffc00944d048 > Mem abort info: > ESR = 0x96000000 > EC = 0x25: DABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > FSC = 0x00: ttbr address size fault > Data abort info: > ISV = 0, ISS = 0x00000000 > CM = 0, WnR = 0 > swapper pgtable: 4k pages, 39-bit VAs, pgdp=0000000020e2e000 > [ffffffc00944d048] pgd=100000003ffff803, p4d=100000003ffff803, pud=100000003ffff803, pmd=100000003fffa803, pte=006800009c090f13 > Internal error: ttbr address size fault: 96000000 [#1] PREEMPT SMP > Modules linked in: > CPU: 0 PID: 132 Comm: bootlogd Not tainted 5.15.44-yocto-standard #1 > pstate: 604000c5 (nZCv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : pl011_stop_rx+0x70/0x80 > lr : uart_tty_port_shutdown+0x44/0x110 > sp : ffffffc00999bba0 > x29: ffffffc00999bba0 x28: ffffff80234ac380 x27: ffffff8022f5d000 > x26: 0000000000000000 x25: 0000000045585401 x24: 0000000000000000 > x23: ffffff8021ba4660 x22: 0000000000000001 x21: ffffff8021a0e2a0 > x20: ffffff802198f880 x19: ffffff8021a0e1a0 x18: 0000000000000000 > x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 > x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 > x11: 0000000000000000 x10: 0000000000000000 x9 : ffffffc00871ba14 > x8 : ffffffc0099de260 x7 : ffffff8021a0e318 x6 : 0000000000000003 > x5 : ffffffc009315f20 x4 : ffffffc00944d038 x3 : 0000000000000000 > x2 : ffffffc00944d048 x1 : 0000000000000000 x0 : 0000000000000048 > Call trace: > pl011_stop_rx+0x70/0x80 > tty_port_shutdown+0x7c/0xb4 > tty_port_close+0x60/0xcc > uart_close+0x34/0x8c > tty_release+0x144/0x4c0 > __fput+0x78/0x220 > ____fput+0x1c/0x30 > task_work_run+0x88/0xc0 > do_notify_resume+0x8d0/0x123c > el0_svc+0xa8/0xc0 > el0t_64_sync_handler+0xa4/0x130 > el0t_64_sync+0x1a0/0x1a4 > Code: b9000083 b901f001 794038a0 8b000042 (b9000041) > ---[ end trace 83dd93df15c3216f ]--- > note: bootlogd[132] exited with preempt_count 1 > /etc/rcS.d/S07bootlogd: line 47: 132 Segmentation fault start-stop-daemon > In Xen, vpl011_mmio_write doesn't handle DMACR . And kernel doesn't check if pl011_write executes sucessfully in pl011_dma_rx_stop . So such segmentation fault occurs. > static inline void pl011_dma_rx_stop(struct uart_amba_port *uap) > { > /* FIXME. Just disable the DMA enable */ > uap->dmacr &= ~UART011_RXDMAE; > pl011_write(uap->dmacr, uap, REG_DMACR); > } > > I think we should prevent such segmentation fault. We have checked the PL011 spec, it seems there is not any register bit can indicate DMA support status of PL011. We might have two options: > 1. Option#1 is to add DMA support for vpl011, but this is not trivial. > 2. Option#2 is to ignore the write to DMACR, and return 0 for DMACR read in vpl011. But this option need co-work with kernel, because current Linux PL011 driver assume the write operation will never be failed, and will not fallback to no-DMA mode, when Xen return 0 for DMA enabled bit in DMACR. > > How do you think about it? Any suggestion about it is welcome. Thanks. > > Best wishes > Jiamei Xie > From xen-devel-bounces@lists.xenproject.org Wed Nov 09 07:45:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 07:45:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440692.694812 (Exim 4.92) (envelope-from ) id 1osfmU-0000KH-Jc; Wed, 09 Nov 2022 07:45:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440692.694812; Wed, 09 Nov 2022 07:45:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfmU-0000KA-Gr; Wed, 09 Nov 2022 07:45:54 +0000 Received: by outflank-mailman (input) for mailman id 440692; Wed, 09 Nov 2022 07:45:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfmT-0000Jk-2i; Wed, 09 Nov 2022 07:45:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfmS-0006Ej-Uz; Wed, 09 Nov 2022 07:45:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfmS-0004E2-Ff; Wed, 09 Nov 2022 07:45:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osfmS-0005j1-FH; Wed, 09 Nov 2022 07:45:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=85goOKv+5wPqF1+elnOWpf9m/3o0Y8tjfzLJC9tlyxM=; b=X644Jd8ZgttLBkRhR76AheDBIZ 68I7p+gvg9vYYkh8VkGIbxPAG6TnCDeLCZytMHTcKXp5cOXhcdZv34Fnql25JCapT/DVaXrRR1q39 FkJoI9XdfhcgQ3yt8jWnbcWPJepoXbunI6GIExdbAHXEjOMW6mE19UJe/xy1wbS1/zT4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174674: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=f21f1cfeb94b94ce044726856c291bed9391e3a4 X-Osstest-Versions-That: qemuu=524fc737431d240f9d9f10aaf381003092868bac From: osstest service owner Date: Wed, 09 Nov 2022 07:45:52 +0000 flight 174674 qemu-mainline real [real] flight 174686 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174674/ http://logs.test-lab.xenproject.org/osstest/logs/174686/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 174668 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 174686-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174668 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174668 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174668 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174668 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174668 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174668 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174668 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174668 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu f21f1cfeb94b94ce044726856c291bed9391e3a4 baseline version: qemuu 524fc737431d240f9d9f10aaf381003092868bac Last test of basis 174668 2022-11-08 05:15:02 Z 1 days Testing same since 174674 2022-11-08 17:38:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki <akihiko.odaki@daynix.com>
Akihiko Odaki Akihiko Odaki Alex Bennée Alex Williamson Alexander Bulekov Ani Sinha Bernhard Beschow Brice Goglin Chris Browy Christian A. Ehrhardt Cindy Lu David Daney Eric Auger Gerd Hoffmann Gregory Price Gregory Price Hesham Almatary Huai-Cheng Kuo Igor Mammedov Jason Wang Jean-Philippe Brucker Jonathan Cameron Julia Suvorova Kangjie Xu lei he Markus Armbruster Michael S. Tsirkin Miguel Luis Parav Pandit Philippe Mathieu-Daudé Robert Hoo Stefan Hajnoczi Xiang Chen Xuan Zhuo Yajun Wu Yicong Yang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2858 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Nov 09 07:49:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 07:49:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440699.694823 (Exim 4.92) (envelope-from ) id 1osfpQ-0000uB-3O; Wed, 09 Nov 2022 07:48:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440699.694823; Wed, 09 Nov 2022 07:48:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfpQ-0000u4-03; Wed, 09 Nov 2022 07:48:56 +0000 Received: by outflank-mailman (input) for mailman id 440699; Wed, 09 Nov 2022 07:48:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osfpO-0000tu-8R for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 07:48:54 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2068.outbound.protection.outlook.com [40.107.20.68]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f443a077-6002-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 08:48:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8090.eurprd04.prod.outlook.com (2603:10a6:10:240::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.24; Wed, 9 Nov 2022 07:48:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 07:48:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f443a077-6002-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eVlHck2UVaESfLjYARVDzZdYNnrWF3cOs4viRac9yMHi2/xYIDzC9GhGZ0pXNn/GRUL6aSLnzC5Dj9KVtLtlP5n2Mg+2nIeXA2HR5qdrrwazvI+JhNBpNj4VfKV3zL0prC4QTIQGxBiwb3wl/I9ztZnxHmCXRrfA6E9TJiTBrJn37E663wqkrzM9Ustei844rsPMZUYEtCjcFBvHQhfRzyeq14DDirf6y5cOlGvV/N3cInrj4iPnYeGs7KxyljTAmAgr0fVGnMbyk0NWkNxxjOg90GyvY9VTIkqYRc9Xys00N2LafS7TBx+ebMVCAy4LvQRIe/YT7/VUlqH1HkSDtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QKH4JaUgRKCwicJiM/krBpGdA1YlWxuELBpvJnmru8c=; b=N6e6vN+8GF4Dsq+/sYzERjmyJfOXiSAZqxEf+yiLyGbsw4waohirFbD9eXn+NLgXM88DUrYRxyUeuSQRWs0MKpdiwUobM26XYlrMeZK7HYSUoaW9COOAd5wG8T74nDlHQe+4+4Ig3CBYIpWy3LtDicAz9PjuYShB7oIU6F+VjaGbJ9uiG21m+Yhxm9n76dAEeJbgFvXBW0ESsXT8GvQ0qpVZblMx/aaTILZM0HjUPGuU8IzvO+gfo+Sv/3mnkaPY4l9Sm7o3E+ufSJ4ejdW4HfSzDlfueo1aBKtHboC0f9m03K65B1caq+JJzRRynKFw5WDkwdNRN85PcXmia/flCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QKH4JaUgRKCwicJiM/krBpGdA1YlWxuELBpvJnmru8c=; b=JlgMKQdKau78Vh+STLTb45C67r5ZstJCdP5F01nlSr9iR4D0eKmow8qMCRORwQwN/opWdgA4ZyuqhBTybs0lsy6uHkQcunWsMbe9/jv0YrGM/+KXdCKG9SzANeQVUIt+DJHozvxkdaiAP8O81Hbg+jEQUpqAn9+dJ+Mal9YHhGoM3IMySFfzj2Eb/JD2jspI/KdIrAC9NBRk0hL5oE6bV/jjbiyomRppk2bV2Jtj97Zo1dcSLoS8BHq4CltKFSXSCmcB18ijjAV2p4y/5LZAgKLFNxYxlZ8H5bTy9c1qW09ZADeQr0+32d/KEj6pmHWcZoWKoffYuzCnZI/KK6K9JA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <76cde159-088a-3351-56e2-0cf14e9c8116@suse.com> Date: Wed, 9 Nov 2022 08:48:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , xen-devel@lists.xenproject.org References: <20221108113850.61619-1-roger.pau@citrix.com> <58d5e890-e052-47df-42bb-6cc84aedd4a9@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0044.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8090:EE_ X-MS-Office365-Filtering-Correlation-Id: 033537fb-c29b-401c-d9d9-08dac226d754 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KtTnKtRocHajTQ5nuIAXq4KR3iJA5bcX6EtBT4zLpgbyrdVXNoscpbpD3lk63nfnGuudwUvC1LSQzU5Js8CaaNQMXdnLJC4JoSefD5XvZbJRVFlwoyQ/8VovHR6YxdkH01z29YHu7CRCCJgoJq/iU/rBA8MaAIOJQhVijETN1CmoyaSH+6lgU+22OwHkQ6k01fofCHAaCSAFUqgDuEIOi7UueGw/VlPSfR1oMAT40u7l8lUjdhaAZXnLXQWFw0xq4YY7SOW0X/BXCm4HAGa549hdlaUaT7f4O7D1EdrQvgJkXkfIRnTfVk6LgLXLCb97syDmaX7VpV4xwAXToYOUbo2hTts/sgC44/lp2pccP5fyYbkvqdP5g+hVTv+VzB9K6BZqJL357IT1oJCIfB5SF8e8FyohVPeQGtHFXzL6RXZAWqw8/082wzW4RWdur9dF+Eog0EBr1oSW/Nf9Nh706WB/zGjI671ZLIxsBdzB5eYgi3B5ohKGDpnVy/6PYGyvefjFypLUABYQ9SK5UaK3ToTqytRG7lSFrs25G6bpl85FNzLAXOdElH1pWeQxTNCoiTW4aRo5uuv34O3J6yVlSbJIK2LzJgglhVlKVVY2Fy8znGORivfuZG8xAlGyK0xVUScaM/l8gVSikr5mthhX/5eAy2bynXXfNCehx5Axcu6URKMGhBaDaioNtQBd/vTf3hoqp44NW824yP6YaIXjrL2xj+Dw0qSLjG8vFcXqw0DWawWFNG/0XWcbgIVkfCZrCpqZDY+9oO6inmjLUSGLeNNOKdHmbcgGVd/qtvNyL74= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(136003)(39860400002)(376002)(346002)(451199015)(36756003)(31686004)(31696002)(86362001)(66556008)(2906002)(26005)(5660300002)(38100700002)(83380400001)(186003)(6512007)(2616005)(6506007)(53546011)(8676002)(41300700001)(66476007)(4326008)(316002)(6486002)(8936002)(66946007)(6916009)(54906003)(478600001)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTFHYVU1d3EvcXVaWGpnNjVqZmgwNGdHNzlFZ1ZSN2puZ00rSi9LbTNORlV0?= =?utf-8?B?d1VvOWk0WkxNMDJBTVJXOElGZlNKUGpXOWlhUGNXam50QWJqTG5NdENoWmVS?= =?utf-8?B?YTNTLzBacjQ1Q3V0TkY2RUQxN1RFVC9iMmNKQUM2NkFjV3ZJc2s0U2ZycnEv?= =?utf-8?B?djNVQTdVcTJPRkU3ZFd4R1lRbTRKTTRFWVV3L00wQ0huTWx0YUZRS2pOcXNR?= =?utf-8?B?TDVXSGN5ay9PcG1hYUFTZUdKOEFvV2lwbjRCTWJRRXVuQ0hUYzFxQkZUcWF0?= =?utf-8?B?S2trU2NUWWVFRVJrcTN1bTB2QWU2M0xkUGFxQnVvWTNVcUhjSEF2K3NkUWJ6?= =?utf-8?B?TFB0WTJBZjBFVGw2c3BuWGlwYzltVFkxMzZzQUZkbExyMnZvUWJIMm9Lcyt5?= =?utf-8?B?emZnSVhHUDhPNnp5RjNRUWwvWStCeGFpaThsNjBzSDdHVXN5WmRMWCszRXNT?= =?utf-8?B?a3B3VDZwVUI4T3FBRzJOUFAvT1V0OFlvRmpZVEFrNjdhYkxBamZwbVBvVzh5?= =?utf-8?B?cytMRVNRS2s2aUNTVjd2QjN0ZEZOSWZQbVcwOTdnTXV5U3U2V1diS3lYWi9W?= =?utf-8?B?Yjd1amt5UGxIUDhZMGpiUXZOZHZabWNjVkVRN3NvK2drOTMyZDJ4Z01yMEk4?= =?utf-8?B?ZytaYXBXaFBBb2RpemJEYU1XOEJIWmR5OEpnVHJhMHhGMUwwSU52aXVJUXBT?= =?utf-8?B?Z1FRcks3UHE0RXhKeWVoQVV3UHJmR2VJWVB2T3ArclhrYmxrQ2FlWkxvS0pQ?= =?utf-8?B?SUlISHVQTjVWa0FNV1pkWnhYMWsxdGk1OVZ1MFpLNGxxTXRMOCt3TVBaOVFS?= =?utf-8?B?dmEyOEVmNVNkT1RoSjE4Q0dZM2QzbTlLMUUrSUxXWitHcmhKYWVWQmk2SDdI?= =?utf-8?B?UWR5eWN2Nno0N1h4SjYwSENrZ0YzVFV6SmY5Q1k4RGEvaGNGbWxidjZUVmpX?= =?utf-8?B?cmpxKzQ0Vy9xQTNYUGlCTkR6eWg1enBMWTM4cW9FS3hlaHZVRlhwNDBMSVZa?= =?utf-8?B?bFc4b3NMTllmak9tNkNLUTVIbzVtT0RzQ1N6ZnQzeGliNVBld0lvK0xXMTI5?= =?utf-8?B?SE8vQ0RUUCtvOG1kaEtlbndwUEhjMGx2S2tsM1dyc2FRRndldEhvTGhjNFNZ?= =?utf-8?B?M3ZRd0JMUlIrVVRzei9SaStYT1pXRzdnU3NoZzA0V0U3aW16VmcyQno5VEVi?= =?utf-8?B?SkZnQmhyS1kvTllGWnIrQTU4V3RlbW15RVV5LzdJb2dtKzJScVVDZCtrWENz?= =?utf-8?B?NTMzVEpJRmxnODErSnVtZGdOTElPbkJUS29OSHVvS3BBd3RqQmd5N25Xbmhr?= =?utf-8?B?Vk0xOGE5WDhGSm13WC9PbHNxSlhlUU1zeXF0L1VvbVcvQnpSd0V0RzAvdjY3?= =?utf-8?B?dlRObkIxVHUrSXZqVllGcjlCdThHd1RSbE1RdVVvakRtNEpEVmVrR0ZXYVhU?= =?utf-8?B?c1cwU0w0SEYxUG9heVVjZitqRjlic1phejE4YmFpVjlQNk9ZaENHOC9uN1kv?= =?utf-8?B?MXhDc2RKd2tOaHhPYWpObkg0VzFqVDVRREJWalJsZytSb3R5Uis3dVN0UVV2?= =?utf-8?B?cVdnUGVtWUx3b1cvRTlPN1hNdDhOZEZPbFQyT2NPakY1UEhkNFppZ1B4Zjln?= =?utf-8?B?aHQxblJzU0wwamJmS0Uwa05BOFo2NzJBK3h2Ynk5ZjRlTG1KSlR3a3pNSGo3?= =?utf-8?B?QkExUS9oT3lUQUNpeTdpdFY5bHdoL3dFOFduUDRKUkJkVkdXeGh3aDd6Ymhv?= =?utf-8?B?aHErbFlxYy9oOHpEaUc1UG5WNitZbFA3UkZzSmFheEZnRWJpK2MvV3UrTEJW?= =?utf-8?B?WnY2WWNtZnpxTmxQOXZrR0JEUnVXMUtZN2hNQ2htdVlZQlhXVXJsUERoL2lO?= =?utf-8?B?K1h0UG9HbXVxS3V5UUxvRklSRUpSY0xPdExNRTZUWjJMRzc1T1ljaGtlQ1Jt?= =?utf-8?B?bkNZTVBrdFNDTlErYWRDc01CMDFVcER2NkdOZjdkT016dEpYRWQ0VEwrb1lx?= =?utf-8?B?dVo3dVRKWlRBcjFVbmd0bUkyTUpyb2pBa0V0Sjg0TVRuWWh4N0drYjNuS2tv?= =?utf-8?B?RlUwZThSbGl5SURRTkQzOE1meUFSS1Q5UThMdDJaOEkyTWJkM1NQSTJwQ0dG?= =?utf-8?Q?1O9Zmmevi9fmsNou2GRLHUV2+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 033537fb-c29b-401c-d9d9-08dac226d754 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 07:48:50.4960 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HCuWVH2L0DXyRQny6/apiSeNdzmJRWoYG9OoHZXZt+dkGdnWSY7v7TTYjIyolVvlWWUGliScWWcBJvr7sg/KWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8090 On 08.11.2022 18:15, Roger Pau Monné wrote: > On Tue, Nov 08, 2022 at 06:03:54PM +0100, Jan Beulich wrote: >> On 08.11.2022 17:43, Roger Pau Monné wrote: >>> On Tue, Nov 08, 2022 at 05:14:40PM +0100, Jan Beulich wrote: >>>> On 08.11.2022 12:38, Roger Pau Monne wrote: >>>>> Like on the Arm side, return -EINVAL when attempting to do a p2m >>>>> operation on dying domains. >>>>> >>>>> The current logic returns 0 and leaves the domctl parameter >>>>> uninitialized for any parameter fetching operations (like the >>>>> GET_ALLOCATION operation), which is not helpful from a toolstack point >>>>> of view, because there's no indication that the data hasn't been >>>>> fetched. >>>> >>>> While I can see how the present behavior is problematic when it comes >>>> to consuming supposedly returned data, ... >>>> >>>>> --- a/xen/arch/x86/mm/paging.c >>>>> +++ b/xen/arch/x86/mm/paging.c >>>>> @@ -694,9 +694,10 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, >>>>> >>>>> if ( unlikely(d->is_dying) ) >>>>> { >>>>> - gdprintk(XENLOG_INFO, "Ignoring paging op on dying domain %u\n", >>>>> + gdprintk(XENLOG_INFO, >>>>> + "Tried to do a paging domctl op on dying domain %u\n", >>>>> d->domain_id); >>>>> - return 0; >>>>> + return -EINVAL; >>>>> } >>>> >>>> ... going from "success" to "failure" here has a meaningful risk of >>>> regressing callers. It is my understanding that it was deliberate to >>>> mimic success in this case (without meaning to assign "good" or "bad" >>>> to that decision). >>> >>> I would assume that was the original intention, yes, albeit the commit >>> message doesn't go into details about why mimicking success is >>> required, it's very well possible the code relying on this was xend. >> >> Quite possible, but you never know who else has cloned code from there. >> >>>> Can you instead fill the data to be returned in >>>> some simple enough way? I assume a mere memset() isn't going to be >>>> good enough, though (albeit public/domctl.h doesn't explicitly name >>>> any input-only fields, so it may not be necessary to preserve >>>> anything). Maybe zeroing ->mb and ->stats would do? >>> >>> Hm, it still feels kind of wrong. We do return errors elsewhere for >>> operations attempted against dying domains, and that seems all fine, >>> not sure why paging operations need to be different in this regard. >>> Arm does also return -EINVAL in that case. >>> >>> So what about postponing this change to 4.18 in order to avoid >>> surprises, but then taking it in its current form at the start of the >>> development window, as to have time to detect any issues? >> >> Maybe, but to be honest I'm not convinced. Arm can't really be taken >> for comparison, since the op is pretty new there iirc. > > Indeed, but the tools code paths are likely shared between x86 and > Arm, as the hypercalls are the same. On x86 we have both xc_shadow_control() and (functional) xc_logdirty_control(); on Arm only the former is used, while the latter would also be impacted by your change. Plus you're not accounting for external tool stacks (like xend would be if anyone had cared to forward port it, when - as you said earlier - the suspicion is that the original change was made to "please" xend). > This is a domctl interface, so we are fine to do such changes. We're fine to make changes to domctl which are either binary compatible with earlier versions or which are associated with a bump of the interface version. The latter wouldn't help in this case, while the former is simply not true here. For Andrew's proposed new paging pool interface the behavior suggested here would of course be fully appropriate, demanding that tool stack either don't issue such requests against dying domains or that they be prepared to get back errors. Thinking about it again I'm also not convinced EINVAL is an appropriate error code to use here. The operation isn't necessarily invalid; we only prefer to not carry out any such anymore. EOPNOTSUPP, EPERM, or EACCES would all seem more appropriate. Or, for ease of recognition, a rarely used one, e.g. ENODATA, EILSEQ, or EROFS. Finally I'm not convinced of the usefulness of this dying check in the first place: is_dying may become set immediately after the check was done. Jan > I > understand that we want to avoid such interface changes as much as > possible, but I think we need to fix the hypercall to return error > codes rather than implementing workarounds to try to cope with a wrong > interface behavior in the first place. Or else we could be > accumulation workarounds here in order to fool caller into thinking > the hypercall has somehow succeed, and provide kind of suitable > looking data for the output parameters. From xen-devel-bounces@lists.xenproject.org Wed Nov 09 08:08:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 08:08:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440711.694836 (Exim 4.92) (envelope-from ) id 1osg8g-0004Se-5i; Wed, 09 Nov 2022 08:08:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440711.694836; Wed, 09 Nov 2022 08:08:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osg8g-0004SX-2o; Wed, 09 Nov 2022 08:08:50 +0000 Received: by outflank-mailman (input) for mailman id 440711; Wed, 09 Nov 2022 08:08:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osg8e-0004SN-Sv; Wed, 09 Nov 2022 08:08:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osg8e-0007K8-Lc; Wed, 09 Nov 2022 08:08:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osg8e-0006Ib-2X; Wed, 09 Nov 2022 08:08:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osg8e-0003kD-27; Wed, 09 Nov 2022 08:08:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=E2lUz3cz32Pv1qgxl021IqcoT0/hGguAZX84qrtnAIM=; b=RH4einXY3ibk+AIWm00Mm082n/ XCX532nvuM28G76ckg+eOJwuzy0uOPgD5sEr3LI2fktkUYYoHJTo/qmzAJ3Txs7ih8ExjfoeOjLea 7sGH1MK7HZRmLRX4oV03Qr6NfvTlLNpKFgZmLaUYJCiIndqg4zVPojcc4UlfmwHFsBjA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.13-testing test] 174675: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=1151d260d7a0186978b80b708fcb712eb1470f49 X-Osstest-Versions-That: xen=4d753ccf9ddf12332435f50d88e8cf0161e7a5b3 From: osstest service owner Date: Wed, 09 Nov 2022 08:08:48 +0000 flight 174675 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174675/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174583 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174583 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174583 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174583 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174583 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174583 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174583 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174583 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174583 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174583 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174583 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174583 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 1151d260d7a0186978b80b708fcb712eb1470f49 baseline version: xen 4d753ccf9ddf12332435f50d88e8cf0161e7a5b3 Last test of basis 174583 2022-11-02 11:38:07 Z 6 days Testing same since 174675 2022-11-08 18:06:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4d753ccf9d..1151d260d7 1151d260d7a0186978b80b708fcb712eb1470f49 -> stable-4.13 From xen-devel-bounces@lists.xenproject.org Wed Nov 09 08:25:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 08:25:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440722.694856 (Exim 4.92) (envelope-from ) id 1osgOn-0007Tn-Nm; Wed, 09 Nov 2022 08:25:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440722.694856; Wed, 09 Nov 2022 08:25:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osgOn-0007Tg-K2; Wed, 09 Nov 2022 08:25:29 +0000 Received: by outflank-mailman (input) for mailman id 440722; Wed, 09 Nov 2022 08:25:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osgOm-0007Ta-FT for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 08:25:28 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2041.outbound.protection.outlook.com [40.107.20.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0e797d04-6008-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 09:25:26 +0100 (CET) Received: from DB6PR0301CA0077.eurprd03.prod.outlook.com (2603:10a6:6:30::24) by PAWPR08MB10117.eurprd08.prod.outlook.com (2603:10a6:102:361::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Wed, 9 Nov 2022 08:25:15 +0000 Received: from DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::4) by DB6PR0301CA0077.outlook.office365.com (2603:10a6:6:30::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14 via Frontend Transport; Wed, 9 Nov 2022 08:25:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT040.mail.protection.outlook.com (100.127.142.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 08:25:15 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Wed, 09 Nov 2022 08:25:15 +0000 Received: from 81fd5d764b4d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BD0BC32D-5391-4015-906C-6B590716FBB2.1; Wed, 09 Nov 2022 08:25:04 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 81fd5d764b4d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 08:25:04 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11) by AS8PR08MB6374.eurprd08.prod.outlook.com (2603:10a6:20b:338::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 08:25:02 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f]) by AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f%3]) with mapi id 15.20.5813.012; Wed, 9 Nov 2022 08:25:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e797d04-6008-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mQ+bMpUWwr9g4Ii8E8QP8hnB2etDho+gsiwTVQZoRTarXufo9BvrAfXF0n9eEuE+V4DfqLBdwpPLdb6+dZY11xqxNZpihXUXlF5Au2s/TqI+0ZJAoD3lQIbS3ilGGbieKeO1kUMyvZ4pwggrf08wk0Cv4RaDFE2Zx/cci4i3RRTfH7mm2SnDlllQTWv1DQI++V7iGr6OdWatZssr7jca0GFWn21MoQzXVrgUO2Pcczjelfdszsiw0TBwE4xg/iqKS6q3DpRqVzOTfBexzTC368VSGH4BWi3R14zKfGlqRs6Si8EIWswfhrH+GfPeNdDALvUMnh7JMyuUOvCnexBPzg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FBZKwRlsIv8VcIZGXvt5p4gypDcXXucJmvXtwmN67hs=; b=ambyAMYACh7HBlhwEnaVugTYU4WgOEc/ov06ycI3HDaH1aRBFqgl53MUPgud+2q/8lB3nIgeCuQFL/q5BxfChyX4frs0VfieuneqMFHvFX3rEblmFcIfWl5mhXegWrqDR4IBcFOgrqE1E1PgAhWbZh7+jHimljTkQQYy0UGu0qmQnRUf9ZbjNQBY62exNSIxx4Lrg3kUhZ0OK9ckman2CSD7hw6txpiLi80yI5/NhyhEXRs5Anmhw/eU6fbGMP9W6sYftZkHhrubZvEr2ne4rMLSufjD1YusD0QSlPj/8x9IViZKwSpohxaCF+Rxyu+izayI9OsOJSNX9IAbHei+YQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FBZKwRlsIv8VcIZGXvt5p4gypDcXXucJmvXtwmN67hs=; b=dQTHKKvvy0zVA6ManzN6aMCGpHe6Sk4PHyj6/iX0vMaEuFldCGZG+OKeURF9YBtQnXOEXIF27dk6X42uJ0PqxCcN5JCAbGMsLEbIKO/7ousDqNx8qivge1pFw+zYCt9hTAIAvIrbf1ethwH5+CbhlAvkWY5bDB1WON6PGUep7hM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RHdCQNqwnYsX6c6v5t11vUhk8kt5AcrwdPy65dJ8ziNPsShg6MHsX33qS4WUDpHCeMm005n2E0HrOQ04LgtNaX4+CEb6MPgdcZ9Iqqmc0vAHV4LX9e5UZ3cF2iEK4RebeAksCJuqZdXajDJgov4J0PWqp15Y6zBQPMPBZc5FfGahv+2tUHmvjScmwfyWzMZHBDlBhH1LMcACKhlhIPmznBLjJSavqeRMldMVpRwMECRRsxcFp8XC+RnEWYpN9vUhC3GzIfGITb8N99A8ajbjsI9VjyrDg8jcPhWYfbg17+yJ8mgbXhbzubn7ayRlJAmnzF7nxJVPTVMaSjD6Jy3YHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FBZKwRlsIv8VcIZGXvt5p4gypDcXXucJmvXtwmN67hs=; b=KgVoqM+/HMUXDUo+zgzNY2sZ8qFKvwF7vfjHKIDLRM+68eDfSv+Co12Cu8vEtaZCX98DN1gIRKkQpNODYaLi+Y8QFUCNSMNJQA1xkUnLb6qboa2+PlP3z48JMpF3wUCIEXxdq/Lqab22fg36lQH1jI+StPBo55NyZJ4I17pDXM/YxxhdcgSvj3y/MhisNVbqwyRcPB2A9NaFK+F/MLIgxXjKelnopi9DchqCzhgKmziWyZCcXkDz6nLvp1QRfm/UQ21Bg/MdxkaxUqQHhOGk5KF9BqYZKRZrptm5gxS+ZhL5SUKyel33i72yGUiNgkirgnmRv1mrXTo3DdtMfNeKKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FBZKwRlsIv8VcIZGXvt5p4gypDcXXucJmvXtwmN67hs=; b=dQTHKKvvy0zVA6ManzN6aMCGpHe6Sk4PHyj6/iX0vMaEuFldCGZG+OKeURF9YBtQnXOEXIF27dk6X42uJ0PqxCcN5JCAbGMsLEbIKO/7ousDqNx8qivge1pFw+zYCt9hTAIAvIrbf1ethwH5+CbhlAvkWY5bDB1WON6PGUep7hM= From: Jiamei Xie To: Michal Orzel , "xen-devel@lists.xenproject.org" CC: Wei Chen , Bertrand Marquis , "julien@xen.org" , "sstabellini@kernel.org" Subject: RE: Xen Arm vpl011 UART will cause segmentation fault in Linux guest Thread-Topic: Xen Arm vpl011 UART will cause segmentation fault in Linux guest Thread-Index: Adj0C3U97KqJOGXWTaWwFEv08mPlLwAAvb+AAAFgduA= Date: Wed, 9 Nov 2022 08:25:02 +0000 Message-ID: References: <00764fe2-f78a-e5db-cb16-903ad1a5ec03@amd.com> In-Reply-To: <00764fe2-f78a-e5db-cb16-903ad1a5ec03@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D2358222C976E74188107F13D9B0636A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7696:EE_|AS8PR08MB6374:EE_|DBAEUR03FT040:EE_|PAWPR08MB10117:EE_ X-MS-Office365-Filtering-Correlation-Id: 7574c5d1-8b09-4b77-a58a-08dac22bedb2 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MSf79pwXpQEqxVTxNjSogcEzpcW4AeGSurfpxnuBJuweovLudvHWRJotcd/wtIOoCg21OZqG4fuoXG8GdOg0SOKYBvSG1MNFoU/I7MO/FVb0JM4Dn3B1WWtlKWDtVy9t/hKx+U9SHK5L1+gCf/1bgwJtfmAU7kB3URcPvrBs7DaT0uKYTHVtHkOucJpq31PNKVW1ZN9B+geSof/koFvPdWww1i72hzBdSGEbM+jzIuhxlOM6Kn7NIuf/ijzRROtFEG62Vu3GpvrORVLQ2litoL8t4hpqhOOfHfvWPtjOd78XGU7H2ennUISyP8OVuk0HJ7CynGmrp/xiKR0G0SCnT9M09BU8yeYh1ShAq/ug/jC4achTmUgJHuI8hTNk/Y3GnwffDABZvO2QCUhKrgZGoGymLsMs6QHvv1mP6IXCh9byVbdSGiIg8EbykFbE14BgK1HekVXz88Ls1BEZqRD+0tj/YqfqzrdnugGl6/3Xx9h4LJBhkJIdZGBCnLMEVHV61PFcOFZaa4/qCjteqr+3GnUeWjEKna3jrggJ/lrM+Jok0VR8v4VgqkAlIqUaJpy9T7QL9xq1BFcWQy7gzOfZYdQ8oPGwgpxhhLqgZKfmFOtBIJIwCkE5MrsGi4j5GQmZd18WZcsBavBU66lT9a0kZBkcJd9Z8/pZUqFjfAScb+xzMQlwcYchoufBgSXBCgu7PglVyhsGGdL+Au3wXcJW6ivpo2vyBq0EA+VSTK+8cMCeC2DNukC612nLMwDhyWAIestHolzUl3jNVZqmB8ZKMw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(376002)(136003)(346002)(396003)(451199015)(71200400001)(55016003)(478600001)(66946007)(66476007)(8936002)(52536014)(186003)(4326008)(8676002)(41300700001)(64756008)(38070700005)(110136005)(76116006)(316002)(45080400002)(83380400001)(6506007)(66446008)(53546011)(122000001)(33656002)(66556008)(54906003)(38100700002)(86362001)(7696005)(9686003)(26005)(66899015)(5660300002)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6374 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fb5f07eb-e9f0-4f57-c7fd-08dac22be609 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zrF4Xh7Nn/p7Tyh2CYdWa2wF16XGQpzGj5/ktlxdG0ebKFZyIpoBIybJW6rfiu8dRJNn+VGG77dJQfyG2FPKNXoTPfqLc4HZstl0yBp6G8GTd00Kt8HALo7QZaPDz/b/ghKfytnNhczwGTvc3sDpSoDnutNxNQc+a6UHJ0mp1kelE1mnVw4svwNqgb/7i7BddTmkKfRyZQUeRdxJ//IcVa//d1uHfx/em4FqYKZsO1SWg9Wi//EAfcqt2IxyCiHZw2btRoNsR7F9oPUO6cohCZgVxEMk3A34clRqzkR0SFi46/NPVULO1D30OGAdenY76aE5Cm3+cDDE07QGThCVaJsKxAIf2baWPsFT1VkhQU/sAkOkYbtUEZjYZK1h+6XVkZQiSTNPwWx/F+OsFH0ZYxEcXhEcpWbIKMgUji4Rbbvttg/OKXw2L4+15dR/LDEbs6a43BczSjgkPFLCmpg2AxJx74X/w6Zu/HAA3Y756N996ZD/Y54uaDdikFJbrrnTuerRsA3NeCTXAU1KZdezLGCEiQPI0J1FAN+VzGTIuXOokB2ArbCbLWDNuy1UW8JHtXE1LiodHd3pSXkIynehscSc5mn+Yr+avNO/Dh+YKzcvV1YGHgkQJn69NKrz2wufGalfW237oZSUAHPBK6U581HROeGkwjnaUY/2V98rV3pbnAcF0G7mjTz7wbVs1sZifwTZoEwdhO5uk9oHe/hN7efYksGLh0T/HAydD9fbApW9lnt4/rjWp6qh9ylSNiZb76AxQ/uyLdurP22XM9aVIw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(39860400002)(396003)(451199015)(40470700004)(46966006)(36840700001)(36860700001)(33656002)(66899015)(86362001)(356005)(81166007)(82740400003)(7696005)(47076005)(40480700001)(4326008)(9686003)(55016003)(107886003)(478600001)(40460700003)(26005)(53546011)(83380400001)(2906002)(82310400005)(186003)(8936002)(110136005)(45080400002)(336012)(54906003)(5660300002)(70586007)(8676002)(316002)(41300700001)(6506007)(70206006)(52536014);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 08:25:15.3636 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7574c5d1-8b09-4b77-a58a-08dac22bedb2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10117 SGkgTWljaGFs77yMDQoNCkJlbG93IGxvZyBjYW4gYmUgZ290IHdoZW4gc3RhdGluZyB0aGUgbGlu dXggZ3Vlc3QuIEl0IHNheXMgOWMwOSBpcyBzYnNhLiBBbmQgOWMwOSBpcyBhbHNvIG91dHB1dA0K IGluIGJvb3Rsb2dkIGVycm9yIG1lc3NhZ2U6IA0KU2VyaWFsOiBBTUJBIFBMMDExIFVBUlQgZHJp dmVyDQo5YzBiMDAwMC51YXJ0OiB0dHlBTUEwIGF0IE1NSU8gMHg5YzBiMDAwMCAoaXJxID0gMTIs IGJhc2VfYmF1ZCA9IDApIGlzIGEgUEwwMTEgcmV2Mg0KcHJpbnRrOiBjb25zb2xlIFt0dHlBTUEw XSBlbmFibGVkDQo5YzA5MDAwMC5zYnNhLXVhcnQ6IHR0eUFNQTEgYXQgTU1JTyAweDljMDkwMDAw IChpcnEgPSAxNSwgYmFzZV9iYXVkID0gMCkgaXMgYSBTQlNBDQoNCkJlc3Qgd2lzaGVzDQpKaWFt ZWkgWGllDQoNCg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE1pY2hh bCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+IFNlbnQ6IFdlZG5lc2RheSwgTm92ZW1i ZXIgOSwgMjAyMiAzOjQwIFBNDQo+IFRvOiBKaWFtZWkgWGllIDxKaWFtZWkuWGllQGFybS5jb20+ OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gQ2M6IFdlaSBDaGVuIDxXZWkuQ2hl bkBhcm0uY29tPjsgQmVydHJhbmQgTWFycXVpcw0KPiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29t PjsganVsaWVuQHhlbi5vcmc7IHNzdGFiZWxsaW5pQGtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6 IFhlbiBBcm0gdnBsMDExIFVBUlQgd2lsbCBjYXVzZSBzZWdtZW50YXRpb24gZmF1bHQgaW4gTGlu dXgNCj4gZ3Vlc3QNCj4gDQo+IEhpIEppYW1laSwNCj4gDQo+IE9uIDA5LzExLzIwMjIgMDg6MjAs IEppYW1laSBYaWUgd3JvdGU6DQo+ID4NCj4gPg0KPiA+IEhpIGFsbCwNCj4gPg0KPiA+IFdoZW4g dGhlIGd1ZXN0IGtlcm5lbCBlbmFibGVzIERNQSBlbmdpbmUgd2l0aA0KPiAiQ09ORklHX0RNQV9F TkdJTkU9eSIsIExpbnV4IEFNQkEgUEwwMTEgZHJpdmVyIHdpbGwgYWNjZXNzIFBMMDExDQo+IERN QUNSIHJlZ2lzdGVyLiBCdXQgdGhpcyByZWdpc3RlciBoYXZlIG5vdCBiZWVuIHN1cHBvcnRlZCBi eSB2cGwwMTEgb2YgWGVuLg0KPiBYZW4gd2lsbCBpbmplY3QgYSBkYXRhIGFib3J0IGludG8gZ3Vl c3QsIHRoaXMgd2lsbCBjYXVzZSBzZWdtZW50YXRpb24gZmF1bHQgb2YNCj4gZ3Vlc3Qgd2l0aCB0 aGUgYmVsb3cgbWVzc2FnZToNCj4gSSBhbSBxdWl0ZSBjb25mdXNlZC4NCj4gVlBMMDExIGltcGxl bWVudHMgU0JTQSBVQVJUIHdoaWNoIG9ubHkgaW1wbGVtZW50cyBzb21lIHN1YnNldCBvZiBQTDAx MQ0KPiBvcGVyYXRpb25zIChTQlNBIFVBUlQgaXMgbm90IFBMMDExKS4NCj4gQWNjb3JkaW5nIHRv IHNwZWMgKFNCU0EgdmVyLiA2LjApLCB0aGUgU0JTQV9VQVJUIGRvZXMgbm90IHN1cHBvcnQgRE1B DQo+IGZlYXR1cmVzIHNvIFhlbiBjb2RlIGlzIGZpbmUuDQo+IFdoZW4gWGVuIGV4cG9zZXMgdnBs MDExIGRldmljZSB0byBhIGd1ZXN0LCB0aGlzIGRldmljZSBoYXMgImFybSxzYnNhLXVhcnQiDQo+ IGNvbXBhdGlibGUgYW5kIG5vdCAidWFydC1wbDAxMSIuDQo+IExpbnV4IGRyaXZlciAiYW1iYS1w bDAxMS5jIiBzaG91bGQgc2VlIHRoaXMgY29tcGF0aWJsZSBhbmQgYXNzaWduIHByb3Blcg0KPiBv cGVyYXRpb25zIChzYnNhX3VhcnRfcG9wcyBpbnN0ZWFkIG9mIGFtYmFfcGwwMTFfcG9wcykgdGhh dCBkbyBub3QgZW5hYmxlDQo+IERNQS4NCj4gTWF5YmUgdGhlIGlzc3VlIGlzIHdpdGggeW91ciBj b25maWd1cmF0aW9uPw0KPiANCj4gfk1pY2hhbA0KPiANCj4gPiBVbmhhbmRsZWQgZmF1bHQgYXQg MHhmZmZmZmZjMDA5NDRkMDQ4DQo+ID4gTWVtIGFib3J0IGluZm86DQo+ID4gRVNSID0gMHg5NjAw MDAwMA0KPiA+IEVDID0gMHgyNTogREFCVCAoY3VycmVudCBFTCksIElMID0gMzIgYml0cw0KPiA+ IFNFVCA9IDAsIEZuViA9IDANCj4gPiBFQSA9IDAsIFMxUFRXID0gMA0KPiA+IEZTQyA9IDB4MDA6 IHR0YnIgYWRkcmVzcyBzaXplIGZhdWx0DQo+ID4gRGF0YSBhYm9ydCBpbmZvOg0KPiA+IElTViA9 IDAsIElTUyA9IDB4MDAwMDAwMDANCj4gPiBDTSA9IDAsIFduUiA9IDANCj4gPiBzd2FwcGVyIHBn dGFibGU6IDRrIHBhZ2VzLCAzOS1iaXQgVkFzLCBwZ2RwPTAwMDAwMDAwMjBlMmUwMDANCj4gPiBb ZmZmZmZmYzAwOTQ0ZDA0OF0gcGdkPTEwMDAwMDAwM2ZmZmY4MDMsIHA0ZD0xMDAwMDAwMDNmZmZm ODAzLA0KPiBwdWQ9MTAwMDAwMDAzZmZmZjgwMywgcG1kPTEwMDAwMDAwM2ZmZmE4MDMsIHB0ZT0w MDY4MDAwMDljMDkwZjEzDQo+ID4gSW50ZXJuYWwgZXJyb3I6IHR0YnIgYWRkcmVzcyBzaXplIGZh dWx0OiA5NjAwMDAwMCBbIzFdIFBSRUVNUFQgU01QDQo+ID4gTW9kdWxlcyBsaW5rZWQgaW46DQo+ ID4gQ1BVOiAwIFBJRDogMTMyIENvbW06IGJvb3Rsb2dkIE5vdCB0YWludGVkIDUuMTUuNDQteW9j dG8tc3RhbmRhcmQgIzENCj4gPiBwc3RhdGU6IDYwNDAwMGM1IChuWkN2IGRhSUYgK1BBTiAtVUFP IC1UQ08gLURJVCAtU1NCUyBCVFlQRT0tLSkNCj4gPiBwYyA6IHBsMDExX3N0b3BfcngrMHg3MC8w eDgwDQo+ID4gbHIgOiB1YXJ0X3R0eV9wb3J0X3NodXRkb3duKzB4NDQvMHgxMTANCj4gPiBzcCA6 IGZmZmZmZmMwMDk5OWJiYTANCj4gPiB4Mjk6IGZmZmZmZmMwMDk5OWJiYTAgeDI4OiBmZmZmZmY4 MDIzNGFjMzgwIHgyNzogZmZmZmZmODAyMmY1ZDAwMA0KPiA+IHgyNjogMDAwMDAwMDAwMDAwMDAw MCB4MjU6IDAwMDAwMDAwNDU1ODU0MDEgeDI0OiAwMDAwMDAwMDAwMDAwMDAwDQo+ID4geDIzOiBm ZmZmZmY4MDIxYmE0NjYwIHgyMjogMDAwMDAwMDAwMDAwMDAwMSB4MjE6IGZmZmZmZjgwMjFhMGUy YTANCj4gPiB4MjA6IGZmZmZmZjgwMjE5OGY4ODAgeDE5OiBmZmZmZmY4MDIxYTBlMWEwIHgxODog MDAwMDAwMDAwMDAwMDAwMA0KPiA+IHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAw MDAwMDAwMDAgeDE1OiAwMDAwMDAwMDAwMDAwMDAwDQo+ID4geDE0OiAwMDAwMDAwMDAwMDAwMDAw IHgxMzogMDAwMDAwMDAwMDAwMDAwMCB4MTI6IDAwMDAwMDAwMDAwMDAwMDANCj4gPiB4MTE6IDAw MDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAwMDAwMDAwMDAwMDAwIHg5IDogZmZmZmZmYzAwODcxYmEx NA0KPiA+IHg4IDogZmZmZmZmYzAwOTlkZTI2MCB4NyA6IGZmZmZmZjgwMjFhMGUzMTggeDYgOiAw MDAwMDAwMDAwMDAwMDAzDQo+ID4geDUgOiBmZmZmZmZjMDA5MzE1ZjIwIHg0IDogZmZmZmZmYzAw OTQ0ZDAzOCB4MyA6IDAwMDAwMDAwMDAwMDAwMDANCj4gPiB4MiA6IGZmZmZmZmMwMDk0NGQwNDgg eDEgOiAwMDAwMDAwMDAwMDAwMDAwIHgwIDogMDAwMDAwMDAwMDAwMDA0OA0KPiA+IENhbGwgdHJh Y2U6DQo+ID4gcGwwMTFfc3RvcF9yeCsweDcwLzB4ODANCj4gPiB0dHlfcG9ydF9zaHV0ZG93bisw eDdjLzB4YjQNCj4gPiB0dHlfcG9ydF9jbG9zZSsweDYwLzB4Y2MNCj4gPiB1YXJ0X2Nsb3NlKzB4 MzQvMHg4Yw0KPiA+IHR0eV9yZWxlYXNlKzB4MTQ0LzB4NGMwDQo+ID4gX19mcHV0KzB4NzgvMHgy MjANCj4gPiBfX19fZnB1dCsweDFjLzB4MzANCj4gPiB0YXNrX3dvcmtfcnVuKzB4ODgvMHhjMA0K PiA+IGRvX25vdGlmeV9yZXN1bWUrMHg4ZDAvMHgxMjNjDQo+ID4gZWwwX3N2YysweGE4LzB4YzAN Cj4gPiBlbDB0XzY0X3N5bmNfaGFuZGxlcisweGE0LzB4MTMwDQo+ID4gZWwwdF82NF9zeW5jKzB4 MWEwLzB4MWE0DQo+ID4gQ29kZTogYjkwMDAwODMgYjkwMWYwMDEgNzk0MDM4YTAgOGIwMDAwNDIg KGI5MDAwMDQxKQ0KPiA+IC0tLVsgZW5kIHRyYWNlIDgzZGQ5M2RmMTVjMzIxNmYgXS0tLQ0KPiA+ IG5vdGU6IGJvb3Rsb2dkWzEzMl0gZXhpdGVkIHdpdGggcHJlZW1wdF9jb3VudCAxDQo+ID4gL2V0 Yy9yY1MuZC9TMDdib290bG9nZDogbGluZSA0NzogMTMyIFNlZ21lbnRhdGlvbiBmYXVsdCBzdGFy dC1zdG9wLQ0KPiBkYWVtb24NCj4gPiBJbiBYZW4sIHZwbDAxMV9tbWlvX3dyaXRlIGRvZXNuJ3Qg aGFuZGxlIERNQUNSIC4gQW5kIGtlcm5lbCBkb2Vzbid0DQo+IGNoZWNrIGlmIHBsMDExX3dyaXRl IGV4ZWN1dGVzIHN1Y2Vzc2Z1bGx5IGluIHBsMDExX2RtYV9yeF9zdG9wIC4gU28gc3VjaA0KPiBz ZWdtZW50YXRpb24gZmF1bHQgb2NjdXJzLg0KPiA+IHN0YXRpYyBpbmxpbmUgdm9pZCBwbDAxMV9k bWFfcnhfc3RvcChzdHJ1Y3QgdWFydF9hbWJhX3BvcnQgKnVhcCkNCj4gPiB7DQo+ID4gICAgICAg ICAvKiBGSVhNRS4gIEp1c3QgZGlzYWJsZSB0aGUgRE1BIGVuYWJsZSAqLw0KPiA+ICAgICAgICAg dWFwLT5kbWFjciAmPSB+VUFSVDAxMV9SWERNQUU7DQo+ID4gICAgICAgICBwbDAxMV93cml0ZSh1 YXAtPmRtYWNyLCB1YXAsIFJFR19ETUFDUik7DQo+ID4gfQ0KPiA+DQo+ID4gSSB0aGluayB3ZSBz aG91bGQgcHJldmVudCBzdWNoIHNlZ21lbnRhdGlvbiBmYXVsdC4gV2UgaGF2ZSBjaGVja2VkIHRo ZQ0KPiBQTDAxMSBzcGVjLCBpdCBzZWVtcyB0aGVyZSBpcyBub3QgYW55IHJlZ2lzdGVyIGJpdCBj YW4gaW5kaWNhdGUgRE1BIHN1cHBvcnQNCj4gc3RhdHVzIG9mIFBMMDExLiBXZSBtaWdodCBoYXZl IHR3byBvcHRpb25zOg0KPiA+IDEuIE9wdGlvbiMxIGlzIHRvIGFkZCBETUEgc3VwcG9ydCBmb3Ig dnBsMDExLCBidXQgdGhpcyBpcyBub3QgdHJpdmlhbC4NCj4gPiAyLiBPcHRpb24jMiBpcyB0byBp Z25vcmUgdGhlIHdyaXRlIHRvIERNQUNSLCBhbmQgcmV0dXJuIDAgZm9yIERNQUNSIHJlYWQNCj4g aW4gdnBsMDExLiBCdXQgdGhpcyBvcHRpb24gbmVlZCBjby13b3JrIHdpdGgga2VybmVsLCBiZWNh dXNlIGN1cnJlbnQgTGludXgNCj4gUEwwMTEgZHJpdmVyIGFzc3VtZSB0aGUgd3JpdGUgb3BlcmF0 aW9uIHdpbGwgbmV2ZXIgYmUgZmFpbGVkLCBhbmQgd2lsbCBub3QNCj4gZmFsbGJhY2sgdG8gbm8t RE1BIG1vZGUsIHdoZW4gWGVuIHJldHVybiAwIGZvciBETUEgZW5hYmxlZCBiaXQgaW4gRE1BQ1Iu DQo+ID4NCj4gPiBIb3cgZG8geW91IHRoaW5rIGFib3V0IGl0PyAgQW55IHN1Z2dlc3Rpb24gYWJv dXQgaXQgaXMgd2VsY29tZS4gVGhhbmtzLg0KPiA+DQo+ID4gQmVzdCB3aXNoZXMNCj4gPiBKaWFt ZWkgWGllDQo+ID4NCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 09 08:31:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 08:31:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440728.694867 (Exim 4.92) (envelope-from ) id 1osgUU-0000Y5-G6; Wed, 09 Nov 2022 08:31:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440728.694867; Wed, 09 Nov 2022 08:31:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osgUU-0000Xy-DL; Wed, 09 Nov 2022 08:31:22 +0000 Received: by outflank-mailman (input) for mailman id 440728; Wed, 09 Nov 2022 08:31:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osgUT-0000Xs-4O for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 08:31:21 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60058.outbound.protection.outlook.com [40.107.6.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e26608de-6008-11ed-8fd1-01056ac49cbb; Wed, 09 Nov 2022 09:31:19 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8192.eurprd04.prod.outlook.com (2603:10a6:102:1cd::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 9 Nov 2022 08:31:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 08:31:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e26608de-6008-11ed-8fd1-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PD/kGhs1xQJpwa15E1DIR54T0dEOiAk9wgfZv36ZSyCPu8ATwS6X66OJ4K2oleGdh3XcpFRF2mn/lLD5op0Eh9HvtEtgpBfXJNGQ0nuOHaTOGYO0IraVGx1ytT3TnIAWZyiXETYDdeLexfJLtfIVFlX6swkMhrP3tNWX6wMUMKprFOpMW1Wlj5lrbnex5XLbcMt4vRmcMYPoHX+OpvwL5GrpOFGhnl2cwBUvRSTyg75O2JO3mp4E36ZLWcmQbOYXQ2KJOZf1i2ognUWrontNonsUhNtB05EG63PWW1hJI5MMbmm4/x4oowMw44qo9mCp+zshVGZ9aV4QJuclOILIVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aF2wgd2j5PFcPu2SLhKzUP207Hw36puxEx9XzYmuV8M=; b=LAk2c67CKAX/JFqgOTcomMYqjFF+7EzuMtHdbF1MMX62rYWLhPYetSG1xyCTMyuA/eOU++iEqsU72hgEYOIfjokd+4drQNJ5hCVIdckDVfgqIKYu5XzAMG97bymQQQ/NjgRcC8yEgpyQf8RJoP8PO532s00Nn/9L6eNViv5psQnZmzJojwJfTQlDaIrUa7nCGNO1Vk0ndWd5HJDKReZlk0FMekKbTXo4PorSFdieusCBMALdJlvULigti95uxWA+Y+a41XM1I9XSGqKm5pV+aXmMpCMa20vNCMnI7RwPFHm85hFdSzqI3Qv42hSf6AmEjgymAchfsmYibN4YRHIv9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aF2wgd2j5PFcPu2SLhKzUP207Hw36puxEx9XzYmuV8M=; b=y95hvGILWkI7dj8NsgjcHFjy0/QrkrrMMKVfSKX+SiPr22zrBf2chiDjWR5GRJ4qPPSMWLYrt/cjz9s9jVDvU9bZ49AIgNy4+JQi46TwL5qfC1XNMklYe9gLVoBPj9fjOVxLRhjjeC5EHjgb5ZwMK8FUaIH5w/9N96sJzMdMQeoNfDt068i5LeTBL0tAJWMCcauP7rZDyysVdu8XOrM1pbXTP5abIJ9+mJkvmHKsYD+NEX+3OpX2HFf2OzWUv0lIRH2Nu2888H0SwrHp074/yXgAJtia0Fd1V0uKKudVSARLEvwvCqn0+1V/TDBojt5o7i/t40cIgvSfwmWMsg8pfQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 9 Nov 2022 09:31:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Content-Language: en-US To: Luca Fancellu Cc: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> <7d56c33d-4b03-9aa1-6abc-45a8ad41caca@suse.com> <2E0BFEFC-5BEE-4F8B-BD9E-94CB9A5B2BC9@arm.com> From: Jan Beulich In-Reply-To: <2E0BFEFC-5BEE-4F8B-BD9E-94CB9A5B2BC9@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0193.eurprd06.prod.outlook.com (2603:10a6:20b:45d::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8192:EE_ X-MS-Office365-Filtering-Correlation-Id: 90f69a44-8059-48e8-5b4f-08dac22cc4d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LAtsuHNZNPIOgdGTcWpEEpn9DGPgnyJx5p26G24Js28jjuPSFixK+9m08bhNtNbzRCbzlVXvBnp6p4vOGuSFFDn9MjrBJWHLHJ4gMd1OyMObrjvIspbasQ/88z7bgn55HzjrtXRghVLtw+m1YY0iyquFa1DsxlssydLgJQP3kCLVEohHVBp0yLPTq8jXqkpaMTAH7XXrsvFMMxD5j/tnw9uk0hXNK8F2t/nGxBK02zu0R+2C4+swNaawoXMhy5ZA+/zxaW23c/aYd02kS3WJeSP69Wd48wmgKp92yNevshE0GYumvOKR8TTpeRegiv986qB5yQebyQDCEdZN9pI47cx/F1tJ8yuUNK4ae4fn+EBks37ILw9JMPMEY4tQgYuTI+Ct3t4YStxUPya+jmOxy7P2UYdcikSEFcPIYnRqQ65YHjv8cxe4LXtL1G56uzuD4o8GZckqECm1/dIaIZLK1ZSZek8GTVDzSDFr3DgtdwCMHbZr/+tjjBB0O5kNnwuevzKrjhvuhBI/4+rlj8cQmn7RT/8J++14mJpLsjOnP46dWRhxlT2C/4N3l/wY7EcSIXdmSVbFDJE+vyOcjc4htDuN6MJjkpCAV6Z43/uHTotqf0INY1bnMgArRIjhfARDzoctzuUOm2WIH+E+cwaTdgcD6vLtjm0iJrM1gQOnQJ/XWqoNFXpl35qZ0ReVFqWcFnhvSVrDoYR7vKjEWhniCFAx6W7XMw1Vx22iKdG5DKJ/tKRQbUlp7M8AkE1fh6mZN8BSznsSJN3QO8TjzoINVn/HBrQw7brbL1BlLr6gfIY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(366004)(396003)(136003)(346002)(451199015)(66556008)(38100700002)(8676002)(66946007)(4326008)(66476007)(41300700001)(8936002)(54906003)(316002)(6916009)(36756003)(2906002)(83380400001)(6512007)(2616005)(6486002)(478600001)(26005)(6506007)(186003)(53546011)(31696002)(86362001)(31686004)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q3JTemlDVkl3MTBqTEJ3Ymc2RGhjV1BGTGNOZlJGS2xXdW1lcy92UC9vd013?= =?utf-8?B?NDI2SnR0bFBiMHRtMUpHRGRXdmhMeXZaY1dOMzFqQWlRQUZZdGMxTW9rNDVW?= =?utf-8?B?VHliSVBpcHBQekFuNXhSRFNvQTdrSDZQL296NDZ2ZFZWVjd1UmNnSjZQdFdF?= =?utf-8?B?dkttUnBIdWNMdC83NVpwbjhNRmRlT3pqSXZqYmt6d29JeGJEaUExL3Z6SVcw?= =?utf-8?B?cUROb1pJTURVMDM0d1RtbjJ6TEhFNFU2SmpzNFFxNmJUVnVUd0o4TVBMbmwx?= =?utf-8?B?VUR6RVlaUGtreEkvVFZYVnRLUEMwNVlDQ3NZZklCUWhvNUVHd01jVlJsU0FG?= =?utf-8?B?V0J0YmxCN1RrN3V4N1NUOC9STGtIcVJUOFZwREdlMFNLb3IvS01hZGtML082?= =?utf-8?B?cy9uUlBJWHc2Nm0rMEpMU3RHR2FOeEZrRzRZQ1hOZVB2RE5yRjZVWVV6M21R?= =?utf-8?B?NzJLVU4rdC9USFZiYWVUZkRpNzRDRUxvcTV4dFhwTTlOaUlhQ0JGbGtTYmRM?= =?utf-8?B?VVYzNFpPY3JpcW9MNFk5cWZvVDFGMFlGYzdXWlNVVmY2R2l5T0tvYXl2cElY?= =?utf-8?B?TVhjWVBQTk9XRFNlVlFZUnozdTBMTERpRDlXSHV4YkxTZW05THFOSjE1SCtC?= =?utf-8?B?RHdZN2JybVloTEFrc05tUEUrV0tBU0YyNjF6RFUrVGdjUkdZOTdxRVBkMEl1?= =?utf-8?B?bGZBRzlwMTFDekk4dE1WT3A1ZGNwdkpMd0RKWnlUelZ1alUxR2RWYVovQkN2?= =?utf-8?B?aGRLY0hFZWpGRHhrSkpwSHlxbUJlbFBLV0hObDVxT0RZbWRNZDhFQ1dVbG05?= =?utf-8?B?Rk1HK3RuQ0ZFSWdaN0FWSDBTN09pYk4yS3Y1MmM3bjZYN3RuUXN3cEVBYU1S?= =?utf-8?B?YW40M0JwQU9ZaXBIczE4ZTdybVZaWVVSSHo1Q0xVTlljcitNVFIzaldPSUdm?= =?utf-8?B?bllkZ2c3U3paZWpNZG5ZdTAzRERqVVdlVlExWGhKdlppdENWRFhOQ0Q1S0xS?= =?utf-8?B?QW40UTNoWFl1THF3eUxkcEZsbXBkMUFHRkpFWDJSM2o0MmlSSWJ4KzFWdEth?= =?utf-8?B?bjUwUHVTYWVkZGx3TC9EUW5vRllVNGRqNkt0WWJ2cHBJc3B6Z0FDdmgxaFFL?= =?utf-8?B?NXZsSTJ5TGRrOXltOWJZcjhweWFzZ1NielU1SThwODdvYWpVRGM0c1lDRE1U?= =?utf-8?B?YjJYTlNlUkVRZy9MeDg1aURvczUvNnlXRG1mQmREbFBVTFpGZFgwci8yVkc4?= =?utf-8?B?VGlqa2kxWHNtS1B6cmFRZGgzSVM1WjN5YXF3TlhkcERhL2p2QUdsZUR2WGxN?= =?utf-8?B?L25Sb3NXdkpQVTNOc21MazRaR3F2UE5KbkVSNTRnTDVoNUNrbU01VzltbEJk?= =?utf-8?B?SnJscWNCNEcwWFZvQkozaXc0UkI4UnJkYnBrdTd6Yk9sb29RRGxDMHdrQ0NT?= =?utf-8?B?LzQrVnlNSGxTcGxFWjMzRzNEekRtcDdCcFV3c20xeFVYSG5GZUpPeXJOV2sy?= =?utf-8?B?Wm1hNEcwYVBRZUt5RGtvNjJGMHNXcmZwak5XWEpQbTRUbzhtZ0VDQmhBeDNE?= =?utf-8?B?ZE5lQ2VLRUdhSUdoQUJkZXg5WkNOd2RmWHVBaVJLL25leUF6R3ZEbXVuY08r?= =?utf-8?B?ZmZTZDBqWlk1UVk0ajRWNkNMNDB3WWNOaUU1M055TmRQNnVCMWtJMjNYWVh1?= =?utf-8?B?OTJJcVRJTFByRHNWYitPdlhOdlh5UEQxUGpEayt5aWNuaU40SW5SVUJaR2cy?= =?utf-8?B?Y3VZVVJGSmZSQWZFK3B3WDlheDl4K2Rvbk5obExyVXNZdnExc3hscEVDTzlm?= =?utf-8?B?bWtjdkVRd001YmJKd1UreDdQK2lzNEpwTzllbmNHSGpIZzllTXMzTE1wdFhD?= =?utf-8?B?RkZQWW9OTzBnUE95UXlQeHRiRmg2QlFzUzNVekZZRzl4UUNwbUs0ZTV4MXc0?= =?utf-8?B?QlMrdDRLeE0xeEgvN0pwT3J1S1JFbmQvNG5iUURGMlZqUmgyVDM4VnlVTEpU?= =?utf-8?B?Nm9MaTBvL0dybGIwRUhablNTRngvRkpWMHRnVlFBMEt4akhlOGRuMXBOdGF4?= =?utf-8?B?c3p0a0RpRzBMT0VGT2dQMUJScjVnTTVoZHFDUkc1dFd3Q2M3RVFjbHlvdXRL?= =?utf-8?Q?sWWFcIGEC4jNqrOjgjacZlJ7p?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90f69a44-8059-48e8-5b4f-08dac22cc4d5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 08:31:16.4419 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VdOmA6pZj/UVIu5OPrN6THHiTqCIm1dMMZRI2fUMAE3VUqscNHvvk9zBhsd6rOJTgnW2+eBQGcO6iVzDPetMCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8192 On 08.11.2022 18:13, Luca Fancellu wrote: >> On 8 Nov 2022, at 15:49, Jan Beulich wrote: >> On 08.11.2022 15:00, Luca Fancellu wrote: >>>> On 8 Nov 2022, at 11:48, Jan Beulich wrote: >>>> On 08.11.2022 11:59, Luca Fancellu wrote: >>>>>> On 07.11.2022 11:47, Luca Fancellu wrote: >>>>>>> @@ -757,6 +758,51 @@ cppcheck-version: >>>>>>> $(objtree)/include/generated/compiler-def.h: >>>>>>> $(Q)$(CC) -dM -E -o $@ - < /dev/null >>>>>>> >>>>>>> +JUSTIFICATION_FILES := $(XEN_ROOT)/docs/misra/safe.json \ >>>>>>> + $(XEN_ROOT)/docs/misra/false-positive-$$*.json >>>>>>> + >>>>>>> +# The following command is using grep to find all files that contains a comment >>>>>>> +# containing "SAF-" on a single line. >>>>>>> +# %.safparse will be the original files saved from the build system, these files >>>>>>> +# will be restored at the end of the analysis step >>>>>>> +PARSE_FILE_LIST := $(addsuffix .safparse,$(filter-out %.safparse,\ >>>>>>> +$(shell grep -ERl '^[[:blank:]]*\/\*[[:space:]]+SAF-.*\*\/$$' $(srctree)))) >>>>>> >>>>>> Please indent such line continuations. And then isn't this going to risk >>>>>> matching non-source files as well? Perhaps you want to restrict this to >>>>>> *.c and *.h? >>>>> >>>>> Yes, how about this, it will filter out *.safparse files while keeping in only .h and .c: >>>>> >>>>> PARSE_FILE_LIST := $(addsuffix .safparse,$(filter %.c %.h,\ >>>>> $(shell grep -ERl '^[[:blank:]]*\/\*[[:space:]]+SAF-.*\*\/$$' $(srctree)))) >>>> >>>> That's better, but still means touching all files by grep despite now >>>> only a subset really looked for. If I was to use the new goals on a >>>> more or less regular basis, I'd expect that this enumeration of files >>>> doesn't read _much_ more stuff from disk than is actually necessary. >>> >>> Ok would it be ok? >>> >>> PARSE_FILE_LIST := $(addsuffix .safparse,$(shell grep -ERl --include=\*.h \ >>> --include=\*.c '^[[:blank:]]*\/\*[[:space:]]+SAF-.*\*\/$$' $(srctree))) >> >> Hmm, not sure: --include isn't a standard option to grep, and we >> generally try to be portable. Actually -R (or -r) isn't either. It >> may still be okay that way if properly documented where the involved >> goals will work and where not. > > Is a comment before the line ok as documentation? To state that —include and > -R are not standard options so analysis-{coverity,eclair} will not work without a > grep that takes those parameters? A comment _might_ be okay. Is there no other documentation on how these goals are to be used? The main question here is how impacting this might be to the various environments we allow Xen to be built in: Would at least modern versions of all Linux distros we care about allow using these rules? What about non-Linux? And could you at least bail when PARSE_FILE_LIST ends up empty, with a clear error message augmenting the one grep would have issued? >> And then - why do you escape slashes in the ERE? >> >> Talking of escaping - personally I find backslash escapes harder to >> read / grok than quotation, so I'd like to recommend using quotes >> around each of the two --include (if they remain in the first place) >> instead of the \* construct. > > Ok I’ve removed the escape from the * and also from slashes: > > PARSE_FILE_LIST := $(addsuffix .safparse,$(shell grep -ERl --include='*.h' \ > --include='*.c' '^[[:blank:]]*/\*[[:space:]]+SAF-.*\*/$$' $(srctree))) Good - seeing things more clearly now my next question is: Isn't matching just "/* SAF-...*/" a little too lax? And is there really a need to permit leading blanks? >>>>>>> + done >>>>>>> + >>>>>>> +analysis-build-%: analysis-parse-tags-% >>>>>>> + $(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile build >>>>>> >>>>>> This rule doesn't use the stem, so I'm struggling to understand what >>>>>> this is about. >>>>> >>>>> Yes, here my aim was to catch analysis-build-{eclair,coverity}, here I see that if the user has a typo >>>>> the rule will run anyway, but it will be stopped by the dependency chain because at the end we have: >>>>> >>>>> JUSTIFICATION_FILES := $(XEN_ROOT)/docs/misra/safe.json \ >>>>> $(XEN_ROOT)/docs/misra/false-positive-$$*.json >>>>> >>>>> That will give an error because $(XEN_ROOT)/docs/misra/false-positive-.json does not exists. >>>>> >>>>> If you think it is not enough, what if I reduce the scope of the rule like this? >>>>> >>>>> _analysis-coverity _analysis-eclair: _analysis-%: analysis-build-% >>>> >>>> But then, without using the stem, how does it know whether to do an >>>> Eclair or a Coverity run? >>> >>> Sorry I think I’m a bit lost here, the makefile is working on both analysis-coverity and analysis-eclair >>> because the % is solving in coverity or eclair depending on which the makefile has in input, it is not complaining >>> so I guess it works. >>> Do you see something not working? If so, are you able to provide a piece of code for that to make me understand? >> >> Well, my problem is that I don't see how the distinction is conveyed >> without the stem being used. With what you say I understand I'm >> overlooking something, so I'd appreciate some explanation or at least >> a pointer. > > Ok, I have that eclair and coverity shares the same commands to be executed by the build system, > so instead of duplicating the targets for coverity and eclair and their recipe, I’ve used the pattern rule > to have that these rules: > > JUSTIFICATION_FILES := $(XEN_ROOT)/docs/misra/safe.json \ > $(XEN_ROOT)/docs/misra/false-positive-$$*.json > > […] > > .SECONDEXPANSION: > $(objtree)/%.sed: $(srctree)/tools/xenfusa-gen-tags.py $(JUSTIFICATION_FILES) > […] > > […] > > analysis-parse-tags-%: $(PARSE_FILE_LIST) $(objtree)/%.sed > […] > > analysis-build-%: analysis-parse-tags-% > $(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile build > > analysis-clean: > […] > > _analysis-%: analysis-build-% > $(Q)$(MAKE) O=$(abs_objtree) -f $(srctree)/Makefile analysis-clean > > Matches the case where 'make analysis-coverity’ or ‘make analysis-eclair’ is called. > > Now, please correct me if my assumption on the way make works are wrong, here my assumptions: > > For example when ‘make analysis-coverity’ is called we have that this rule is the best match for the > called target: > > _analysis-%: So my main oversight was your addition to main-targets, which makes the connection with this underscore-prefixed goal. As to you saying "best match" - I didn't think make had such a concept when it comes to considering pattern rules. Aiui it is "first match", in the order that rules were parsed from all involved makefiles. > So anything after _analysis- will be captured with % and this will be transferred to the dependency > of the target that is analysis-build-% -> analysis-build-coverity > > Now analysis-build-coverity will be called, the best match is analysis-build-%, so again the dependency > which is analysis-parse-tags-%, will be translated to analysis-parse-tags-coverity. > > Now analysis-parse-tags-coverity will be called, the best match is analysis-parse-tags-%, so the % will > Have the ‘coverity’ value and in the dependency we will have $(objtree)/%.sed -> $(objtree)/coverity.sed. > > Looking for $(objtree)/coverity.sed the best match is $(objtree)/%.sed, which will have $(JUSTIFICATION_FILES) > and the python script in the dependency, here we will use the second expansion to solve > $(XEN_ROOT)/docs/misra/false-positive-$$*.json in $(XEN_ROOT)/docs/misra/false-positive-coverity.json > > So now after analysis-parse-tags-coverity has ended its dependency it will start with its recipe, after it finishes, > the recipe of analysis-build-coverity will start and it will call make to actually build Xen. Okay, I see now - this building of Xen really _is_ independent of the checker chosen. I'm not sure though whether it is a good idea to integrate all this, including ... > After the build finishes, if the status is good, the analysis-build-coverity has finished and the _analysis-coverity > recipe can now run, it will call make with the analysis-clean target, restoring any .{c,h}.safparse to .{c,h}. ... the subsequent cleaning. The state of the _source_ tree after a build failure would be different from that after a successful build. Personally I consider this at best surprising. I wonder whether instead there could be a shell(?) script driving a sequence of make invocations, leaving the new make goals all be self- contained. Such a script could revert the source tree to its original state even upon build failure by default, with an option allowing to suppress this behavior. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 09 08:52:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 08:52:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440735.694878 (Exim 4.92) (envelope-from ) id 1osgoj-0003Uj-6t; Wed, 09 Nov 2022 08:52:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440735.694878; Wed, 09 Nov 2022 08:52:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osgoj-0003Uc-3e; Wed, 09 Nov 2022 08:52:17 +0000 Received: by outflank-mailman (input) for mailman id 440735; Wed, 09 Nov 2022 08:52:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osgoh-0003UW-N2 for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 08:52:15 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20070.outbound.protection.outlook.com [40.107.2.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ce05eec1-600b-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 09:52:14 +0100 (CET) Received: from AS9PR06CA0487.eurprd06.prod.outlook.com (2603:10a6:20b:49b::12) by DB9PR08MB7400.eurprd08.prod.outlook.com (2603:10a6:10:370::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 08:52:09 +0000 Received: from AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49b:cafe::b8) by AS9PR06CA0487.outlook.office365.com (2603:10a6:20b:49b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 08:52:09 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT022.mail.protection.outlook.com (100.127.140.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 08:52:08 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Wed, 09 Nov 2022 08:52:08 +0000 Received: from 273ea141b46c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EAD57D85-61BD-47D9-8AA7-1E9EA37297DD.1; Wed, 09 Nov 2022 08:52:02 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 273ea141b46c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 08:52:02 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB9PR08MB6522.eurprd08.prod.outlook.com (2603:10a6:10:250::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 08:51:59 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%6]) with mapi id 15.20.5813.012; Wed, 9 Nov 2022 08:51:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce05eec1-600b-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=f4TQs4uSNA5/tAKZVPhdRDqgytAjimSrxE3D5nRx4D4FkTZ1EGugo/gvI2YZ7R9zQ5VVjBBydzFTETNMELJXWjKeWJfHHdSXm+LFhyEHA+37ulgDQ2C2dHrhYHaSUFQOab5LzclUejZ+lTowT14lfdjm3OadMDKhBMKfV607vHcj5Jnk5XYAXMyTATd6FesW18Bd/evQQ3qrG8yQ1cqH9ugpzwMp9nazTh8Ng9uN3CG1+cV0fT9BpTVnTUZgWsmlml017iokJYsxN9fc+g/uEPt/Y7AtQn8WccIlh7qwsRpxdiBKwQJBqBzRNxyT8yoojVRb2ZU1rGsk454AsIGong== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N6hCrj/BCkI13OSrtI5sCVOlvwOyCwZt6T3Umr7LA9A=; b=dAAryuNcUevs7yRu1cGFby9WuTU06otqirXzWy2VaGwScZPeLGtYEIZN5uVVHm3zWAmbDMdAetJ02zywEJb77td0NWcNDBUkOhtp1FZNdIXjXLQEhmYJ/NCHA/e7EWpnvx2nxW+q5XQAPfqBuoRWRVUZqv70ncyuN8LHBPi2WWUwu91gfjPdtcZWNvRnlUzUviWohmz5oNruw7IknuH8453udk16H6OiEbMwiVed/8l6wi8hf30MA9EjGayuHsi1ABcr84llM+D1HCJKfETChqDQYgef2PFlfpIszPjrHvD6DySHut71cwlPX3HFv831K9zU1kxb9a3lKXdb+6OzkA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N6hCrj/BCkI13OSrtI5sCVOlvwOyCwZt6T3Umr7LA9A=; b=Nih91N0xLFFa0T1Elw7w40i8KGWj4N1iOd2Rz7nkuy9iJTgwHdVnYvS2TwvSCJl/mIg+Tiv1P/6a1EaBASAkwCN5RKO7SscRXJjIw1hvb2MgRDaSqPMSEWjwZkKFOzOEqd7td7y2ZvDUWtl+7iISBIFgbdBU9a0b/ORy63CJvkw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QpFlAFSAShetcajjgSqGYO4+LSbDuNEmTUZCq3hpucRUY9jS8iIFomSWCZTt9WQ23q/izyCvj0FETE6riarcc89hUpBtQgzeThmOHOS/pgHYljpXMkqyaFbcV4B5Z3inINYyFssLLDGz3oqNUb5nqAUjtFnffKmxFcGP0nM2FGx5Y/wof7IeWeUDdTOUUkqM2lZrwu1F03+0qZEp1V+EdgZl1dxUiD0qyDa6e0Bg6fF/W6LPsZYcFGrvkMyUrz0rar0fhiWsM76XkeRRSwD5By9ChIB0osgh27vuMTFOcMBya0G7vZ+rmfXHDJ8hD7efAwlBnQs/drLbtun4ll/H/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N6hCrj/BCkI13OSrtI5sCVOlvwOyCwZt6T3Umr7LA9A=; b=aP/YnsO61fzWbo6h1GcHMafMjU2Slhiv8cCdyYWKkAT+RhR38y7dRr9IDzkLx47bqeota6oLRDYYHT4L80MbtnHrVSJzcX0Q0ohqGpZNwLlpeAsOSdfqFJVTvsAdr/OBK4dfeLEb+3FRJ6P8WKK+Befm6oE01O7EZ6c5+VAV8v/QP7LpqwVOruSR5xjzvefCvXngphzJNCEbT7XJjVzHoPfPcf96qVOOrDcKWiSUvWKEasqvy8jGz8CeTm/PuineO8SU9lwyWVQ7F3YzTL/+ndMja3VC7AHiJ08xg471gvgXVJ3+NotZLw9XQZGON+pzpCLJcHLQXH/BISygO1Biag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N6hCrj/BCkI13OSrtI5sCVOlvwOyCwZt6T3Umr7LA9A=; b=Nih91N0xLFFa0T1Elw7w40i8KGWj4N1iOd2Rz7nkuy9iJTgwHdVnYvS2TwvSCJl/mIg+Tiv1P/6a1EaBASAkwCN5RKO7SscRXJjIw1hvb2MgRDaSqPMSEWjwZkKFOzOEqd7td7y2ZvDUWtl+7iISBIFgbdBU9a0b/ORy63CJvkw= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v7 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common Thread-Topic: [PATCH v7 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common Thread-Index: AQHY5EtSdgmFSeaU8UGG/Ef8aqU5eq41XS4AgAEIj3A= Date: Wed, 9 Nov 2022 08:51:58 +0000 Message-ID: References: <20221020061445.288839-1-wei.chen@arm.com> <20221020061445.288839-6-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 51E3D4A62DF7E64F96D4B5EED1F4B302.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|DB9PR08MB6522:EE_|AM7EUR03FT022:EE_|DB9PR08MB7400:EE_ X-MS-Office365-Filtering-Correlation-Id: f520df7b-f3ac-4064-cf88-08dac22faf33 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: N0OkwOLtAFqlubBiiw0O7c3kTCIkhgFWOK6rpVNOeq92T5DExdy2/y9eyIzGrsm92iz7WbwfO/sDa4/13D5LtWUnvmC34DGk8qhrj/yDnCzkGYa81YJuQwNUNyXHLogAID8QwwTiLagfCzRgELCPBo+X09Ce2OAFCGhMHv77ta2Pk3nGMFufJobNNx2uV8Xz0Fn2K2IqU1mUgynCGDXNg42Qw4QS13tOIs+zbQCqLsTGMN4WCxdu/0RRCzkAlpYPgYdGQxZrgyHnDXaCzGo/aH+KR0+BZkBhZShV1lReGVN16WQG1Ll0YWBtRo3M1/obJIIU+t/ub2bN/IVKdOGno2sSglAF7oodp4J7S9k3p/bXBWq8fB0uZzP1fTlysGuXY9KUWjLY+7QARWcPD+U5KQmuuuQbc9Zdk77AP3gpF3TdnHk+mec4CifRU8IezPADIV/bXJkS9BGmhEJt0d7xmy7fEttSWMwTwxD1gxmFelHNeyfTw/qlIgvuUbLK0KqRNP2j8ZxW6TIYCLHj50D2Ye+0UV3KF2GdRq7TRaSBZTNtAww6nxBlHHQOUXciBglD5iAsMmY26XM4VMI46Kgum/PbpooYCpsr78F/mnDhShPqOVa5pBmcV4MDG+lLznC0V0CV0V3q/SRqJE5T4WAvQxNqFwOWRMg8BD1xbRNUdFFQNfleGqbq8UdsxRPBpcIgiwku4pQSHSkcRmFJoHiZcPd7WM711FSfvBobqLzYccWoNTa6AMk24dod3//KB3g3A01WwX1uBnYP2Of/bgc1qg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(346002)(39860400002)(376002)(451199015)(66556008)(66946007)(66446008)(6916009)(83380400001)(33656002)(54906003)(38070700005)(8936002)(9686003)(4326008)(2906002)(55016003)(71200400001)(478600001)(8676002)(5660300002)(316002)(52536014)(64756008)(41300700001)(66476007)(186003)(53546011)(26005)(76116006)(38100700002)(7696005)(122000001)(86362001)(6506007);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6522 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cbaa4f91-2ed0-4918-d674-08dac22fa994 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nmni2HZFTXPCE+GtzTo7Y27YFLS8xQkXcP9NRvkPcwBfLhmmpNuWJQJ/Z8BXh9ilF978ekSE2k1PX9higj4gBDyH23aCR2IUOocUIavADi+VLaihnzTJ9cUBFpK0MwMdHuWXKSlrM3X2lVoWYtoglw0o1H2znjif7sjBpbqyxotBnvE4akENlP3YklClVNzvX7HjMx9NJAdcfhyt/sRKPEbvA5OIC4UUw3L4n3HEqrvr/vDkmhfbze8jbChoBnzPiXmPAPPAvczYweGB/Blw3Nc6El/Dx2ThgShEwZED6j1fz01Ltx+YztsrDKmRqrQK68/K0M/eF6Xz2dCkXlQfuBEUUvTVyHUGLWmQYWrI4H+oe/bP7cJ7+nIyfH6/UqPO1x2MZ14eBfuaOAjj0T9NbSP18Nuwqsy1HCgV0GMYa9ews7yPABblKyzOGh7zuyIZOu69R+n/I2X01IMjg+PRSo0tW5jyAy816bK78/Z4aeGsBdm71kCY+OltrEo/LK4mpW7AKuOMSOaWz2EI9xGZJgoDMVIL4HJuFeldR5akBuBzVRk6F0rpkeeFOCMub+0p3/6vuJxwC4V0s8RboND1j/LqAlrPuOZ+aMLQf+73kc7SjIchgLoz9VFatFlHp2GN0TKWONrw5D2TmwbsM97OcUV9cdk/07jRL80XTntModYmG8tP2DrpG6+QOUrolS8GZqxt3ejaKrQvZdbJDiWbiccAfqzG65erJQrfy/Qdc+O0BnK8DUR/i44ZKJiJz37YQDpg3AfulaCCCQHhyf5AzA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(396003)(451199015)(46966006)(36840700001)(40470700004)(83380400001)(186003)(336012)(7696005)(316002)(54906003)(6862004)(41300700001)(8936002)(2906002)(36860700001)(9686003)(47076005)(53546011)(6506007)(478600001)(33656002)(26005)(40480700001)(82310400005)(52536014)(55016003)(86362001)(5660300002)(8676002)(81166007)(70586007)(40460700003)(4326008)(356005)(70206006)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 08:52:08.4381 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f520df7b-f3ac-4064-cf88-08dac22faf33 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7400 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDEx5pyIOeaXpSAwOjU1DQo+ IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsg QW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT47IFJvZ2VyIFBhdQ0KPiBN b25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPjsgV2VpIExpdSA8d2xAeGVuLm9yZz47IEdlb3Jn ZSBEdW5sYXANCj4gPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT47IEp1bGllbiBHcmFsbCA8anVs aWVuQHhlbi5vcmc+OyBTdGVmYW5vDQo+IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5v cmc+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRD SCB2NyA1LzZdIHhlbi94ODY6IG1vdmUgTlVNQSBwcm9jZXNzIG5vZGVzIG5vZGVzIGNvZGUNCj4g ZnJvbSB4ODYgdG8gY29tbW9uDQo+IA0KPiA+IG1lbV9ob3RwbHVnIGlzIGFjY2Vzc2VkIGJ5IGNv bW1vbiBjb2RlIGlmIG1lbW9yeSBob3RwbHVnIGlzDQo+ID4gYWN0aXZhdGVkLiBFdmVuIGlmIHRo aXMgaXMgb25seSBzdXBwb3J0ZWQgYnkgeDg2LCBleHBvcnQgdGhlDQo+ID4gdmFyaWFibGUgc28g dGhhdCBvdGhlciBhcmNoaXRlY3R1cmVzIGNvdWxkIHN1cHBvcnQgaXQgaW4gdGhlIGZ1dHVyZS4N Cj4gPg0KPiA+IEFzIGFzbS9hY3BpLmggaGFzIGJlZW4gcmVtb3ZlZCBmcm9tIGNvbW1vbi9udW1h LmMsIHdlIGhhdmUgdG8NCj4gPiBtb3ZlIE5SX05PREVfTUVNQkxLUyBmcm9tIGFzbS9hY3BpLmgg dG8geGVuL251bWEuaCBpbiB0aGlzIHBhdGNoDQo+ID4gYXMgd2VsbC4NCj4gPg0KPiA+IFNpZ25l ZC1vZmYtYnk6IFdlaSBDaGVuIDx3ZWkuY2hlbkBhcm0uY29tPg0KPiANCj4gVGhlcmUncyBqdXN0 IG9uZSByZW1haW5pbmcgY29uY2VybiBJIGhhdmU6IEkgY29udGludWUgdG8gY29uc2lkZXIgLi4u DQo+IA0KPiA+IEBAIC0zNDEsMTU5ICsyNDcsMTQgQEAgYWNwaV9udW1hX21lbW9yeV9hZmZpbml0 eV9pbml0KGNvbnN0IHN0cnVjdA0KPiBhY3BpX3NyYXRfbWVtX2FmZmluaXR5ICptYSkNCj4gPiAg CQlweG0gJj0gMHhmZjsNCj4gPiAgCW5vZGUgPSBzZXR1cF9ub2RlKHB4bSk7DQo+ID4gIAlpZiAo bm9kZSA9PSBOVU1BX05PX05PREUpIHsNCj4gPiAtCQliYWRfc3JhdCgpOw0KPiA+ICsJCW51bWFf ZndfYmFkKCk7DQo+ID4gIAkJcmV0dXJuOw0KPiA+IC0JCQkJfQ0KPiA+IC0JCX0gd2hpbGUgKGZv dW5kICYmIHN0YXJ0IDwgZW5kKTsNCj4gPiAtDQo+ID4gLQkJaWYgKHN0YXJ0IDwgZW5kKSB7DQo+ ID4gLQkJCXByaW50ayhLRVJOX0VSUiAiTlVNQTogTm8gTk9ERSBmb3IgUkFNIHJhbmdlOiAiDQo+ ID4gLQkJCQkiWyUiUFJJcGFkZHIiLCAlIlBSSXBhZGRyIl1cbiIsIHN0YXJ0LCBlbmQgLSAxKTsN Cj4gPiAtCQkJcmV0dXJuIDA7DQo+ID4gLQkJfQ0KPiA+IC0JfQ0KPiA+IC0JcmV0dXJuIDE7DQo+ ID4gKwludW1hX2Z3X25pZF9uYW1lID0gIlBYTSI7DQo+IA0KPiAuLi4gdGhpcyB0byBiZSBoYXBw ZW5pbmcgdG9vIGxhdGUuIE5vdCBiZWNhdXNlIEkgY2FuIHNlZSBhIHdheSBmb3IgY3VycmVudA0K PiBjb2RlIHRvIHVzZSB0aGUgdmFyaWFibGUgZWFybGllciwgYnV0IGJlY2F1c2Ugb2YgdGhlIHJp c2sgb2YgZnV0dXJlIGNvZGUNCj4gcG90ZW50aWFsbHkgZG9pbmcgc28uIEFmYWljcyBzcmF0X3Bh cnNlX3JlZ2lvbnMoKSBpcyBjYWxsZWQgcXVpdGUgYSBiaXQNCj4gZWFybGllciwgc28gcGVyaGFw cyB0aGUgZmllbGQgc2hvdWxkIChhbHNvPykgYmUgc2V0IHRoZXJlLCBwcmVzdW1hYmx5DQo+IGFm dGVyIGFjcGlfdGFibGVfcGFyc2UoKSBoYXMgc3VjY2VlZGVkLiBJJ3ZlIGluY2x1ZGVkICIoYWxz bz8pIiBiZWNhdXNlIEkNCj4gdGhpbmsgdG8gYmUgb24gdGhlIHNhZmUgc2lkZSB0aGUgc2V0dGlu ZyBoZXJlIG1heSB3YW50IGtlZXBpbmcsIGFsYmVpdA0KPiBwZXJoYXBzIG1vdmluZyB1cCBpbiB0 aGUgZnVuY3Rpb24uDQo+IA0KDQpXaGVuIEkgd2FzIGNvbXBvc2luZyB0aGlzIHBhdGNoLCBJIGFs c28gdGhvdWdodCBjdXJyZW50IHBsYWNlIHRvIGNhbGwgdGhpcw0KIlBYTSIgc2V0dGluZyB3b3Vs ZCBiZSBhIGxpdHRsZSBsYXRlLiBCdXQgc2luY2UgdGhlcmUgaXMgb25seSBvbmUgZnVuY3Rpb24N CnRoYXQgdXNlcyB0aGlzIHByZWZpeCByaWdodCBub3csIEkgdGhvdWdodCBpdCB3YXMgYWNjZXB0 YWJsZSBhdCB0aGUgdGltZS4NCkJ1dCBvYnZpb3VzbHkgeW91ciBjb25jZXJucyBtYWtlIHNlbnNl LCBJIHdpbGwgbW92ZSB0aGlzIGNhbGwgdG8NCnNyYXRfcGFyc2VfcmVnaW9ucyBhZnRlciBhY3Bp X3RhYmxlX3BhcnNlIGhhcyBiZWVuIGRvbmUgc3VjY2Vzc2Z1bGx5Lg0KDQpDaGVlcnMsDQpXZWkg Q2hlbg0KDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Wed Nov 09 09:22:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 09:22:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440742.694889 (Exim 4.92) (envelope-from ) id 1oshHi-0007kQ-KU; Wed, 09 Nov 2022 09:22:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440742.694889; Wed, 09 Nov 2022 09:22:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshHi-0007kJ-Hn; Wed, 09 Nov 2022 09:22:14 +0000 Received: by outflank-mailman (input) for mailman id 440742; Wed, 09 Nov 2022 09:22:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshHg-0007kD-BI for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 09:22:12 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fbdb6dca-600f-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 10:22:10 +0100 (CET) Received: from mail-dm6nam10lp2108.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 04:21:59 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by BY5PR03MB5063.namprd03.prod.outlook.com (2603:10b6:a03:1e4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 09:21:57 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 09:21:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fbdb6dca-600f-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667985730; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=DLJsNvHDALY0jAq0emL9Sxhp8HyNQccgjSFLDh8mNBo=; b=bzYSDJSoSsy3XUGn7SK0xT6aBNLcmCvH0u1hFtexqINuUe0uAilFuj8L GlJbtHatBYbZHIbf+ZssXzkjdAv4Jmaazg11opNIetN5ln5yTM2oIIl8S N5ELG/bsoevKIo0a39NpFW+zW84ypgWlYZyhPDWzLraIMVNSVFi5mMmR8 E=; X-IronPort-RemoteIP: 104.47.58.108 X-IronPort-MID: 84053412 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:7Tay4a6O+IznVXAQ+l2MJgxRtPTGchMFZxGqfqrLsTDasY5as4F+v mcWDWyAOKvbZmTwe9l+b4S080gEuMWBmIRnGwNqpCg9Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkT7QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m5 a1HBTVSaj65rMWrza63VeNUvfg9I5y+VG8fkikIITDxK98DGMiGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnEooiOiF3Nn9I7RmQe1YkliZo CTa+H7+ATkRNcCFyCrD+XWp7gPKtXOnAN9JSOTinhJsqGGQmmk5FhwWb3aU/d2z1x66fNZ7a HVBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4orZ5RyIQFcNSDFpYcYj8sQxQFQC2 laXkvvzCDdosbnTTmiSnp+LqRuiNC5TKnUNDQcUQA1A79T9rYUbihPUUs0lAKOzlsfyGzz73 3aNtidWulkIpcsC1qH+8VWZhTup/8DNVlRsvlWRWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGS0bYJHd3X5ywmQxg== IronPort-HdrOrdr: A9a23:CbcWf6Brb9v1THDlHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkWwqc5Ew6sN5m1q VXm2qfqppMFBvF2D/w/t7SSnhR5wOJSepLq59ts5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7gSwlGl/NLAgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vcPHmZw == X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208";a="84053412" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cgg7mjHFh66e25hGpy4zDhJGQtfzCH46Z/4Zd18jOgsfELA2xpv+0LtqSyQKrsgp2hvkNqYwxByuS3Chh3Ajs/4GVVFC8FSKzNBshMdrSgA/Fm0eel22mGiykCqvdZVRjc8WUz+jeyiNlbLWXOKO4mZHlfNncpXEwU9xJPHapEXAiIgIAeOSHP3UsMBf8O/XPQaRVt7s9kjeXaoHLy7mzevXmv0X4tnXM22lc35IqUPuNCkrc+pvzege+jqoAp26Wqw2AMsUsy9penswszq4ZVecCRmRr+dVw2oZBYyutIJVaU8DUcvr6ms9vk4u3vuVAyCGY2Aa8e8BnTtUh60tEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DLJsNvHDALY0jAq0emL9Sxhp8HyNQccgjSFLDh8mNBo=; b=RCqUmpZ/GzJbm1So/3ub7ew4JolEFoK1U+uF43kxAtSAP/m3hFD7bSPiJD9Xia6BSmRrYRu682d6D3cVzqoS97uUzd1LtMTJ6UKtLWD8p54HgzpaqjAH0kxJXUwLo7Mkzkqfeo5P++E/RF5VnjWlYnRh72Nk+BNGYYGYI+VAsf57sh2x5SqBdicu0KXU3EG80efpz6kn5Xe04dmAIHeLCpfqDMYC6S33p9KWLVJDF/2t4lxCHH5MNjAjnPHQ3HrGUNH8dhst4AqNdPQJYb2yLXiGz75iv+PBHMaYu6+IOh8Jzc3oFc85ehAGBhaBx37EDbJvwezRolhcS5CCxp8uOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DLJsNvHDALY0jAq0emL9Sxhp8HyNQccgjSFLDh8mNBo=; b=py+ZQ3W4s5W4GyJzUHFoF2WWzo8cNg9wjGSmFSTmKsSHLqIdXjKTGZTzD3t40Y+8uUJJMxqzfE0mnPDemraI9MWJI9PZPbV4JqBWDWiHT7Pgxh/UL06hg/74f5mHdNP6TINc6qSl70jOjANKUhxFmUbOibLu6XcXtocj/x22uFE= From: Edwin Torok To: Jan Beulich CC: Henry Wang , Christian Lindig , David Scott , Wei Liu , Anthony Perard , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error Thread-Topic: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error Thread-Index: AQHY84enx+9R1HXBN0OC3OTqctPuu6415EUAgABJboCAACSeAA== Date: Wed, 9 Nov 2022 09:21:57 +0000 Message-ID: References: <09afc07ba0ba65afc02028bd6b4950d8e51af69b.1667920496.git.edvin.torok@citrix.com> <1e994604-7a3f-ef5f-63f4-d03e4abe4124@suse.com> In-Reply-To: <1e994604-7a3f-ef5f-63f4-d03e4abe4124@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|BY5PR03MB5063:EE_ x-ms-office365-filtering-correlation-id: 9b9c6aa9-e93d-4ecf-68cb-08dac233d945 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nGR645d4hdD/wk1geKRtpX9lwBAWjvLAzh//kDLoyMonAYQm8EQNX1o6vp7GCEODUlv+qmZxOUx1yrTewE1XnOaMGeqKw92h7l1caWuF3t6UqnBQZJCfP4R2Mq20VKEr0lPfQDdbulpWoRq2hvVZ1DRASk0YkRpVgtxuTEnUrzv8sH3V7kRKeOEhZczTuKdkh7g164wWIqZo3sbDew92++Dl8dFcy3keE52upjTsDfYuVzhXXJRXvjH7lwZdQ+FNPTg2DinpwMwSXEp7lAEomZEyyv/t6Y/G6wD5ur6fi21sUKPBH4gaEimVvORL8IDiqEZQwfI4sz0ImElqLZi/NXWCrIrD4XvHl0Sk/7e0ZgW89O7rukVMsVsVBDZ2wCsj+ee1OCN8Po9XGUl3+GbAsqKnqfVO5vt3cWM0x8ZcEfJUuH7Fax5HSDXRXfZKpfDJpbgnISV2D/4dkeRXI04bu+Zz0JzN7gCxzELR9P9EZ6YtZ3RbP68s+nSyHZxB+EhW3u3oL0WUWZb8/9YYkt3yDoq5rwpKFg7UrSzXvrSch0dqZzQoDj1N3+oCo/qu/gBE08fzx+mu6dcdSqWblyyk5snpHe+xav55M6n9uszJ3wUWTARCUdZ2nTRMFjSbQUV8aRRfTZCndo8vQ8Zq5xUBS/dQeD3kSLnEPPGYRqoJK6BgacfocNW3d543O2G00ExL+vJUrbTh9beRhejSY78oAodQVsDf2j1FWjCX34VZT9E79MQwAnBqfVpn+ATUwaza8CbczQ5vQ05BBqGteqCXkLOOYaGPU+ZPesBflCzZ76Csj+aQXxsp202SHXvh4zQjsVyaJh60AU51+4nbGqKZHg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(136003)(39860400002)(346002)(376002)(451199015)(122000001)(38070700005)(38100700002)(82960400001)(86362001)(54906003)(36756003)(6916009)(316002)(966005)(71200400001)(8936002)(6486002)(478600001)(41300700001)(33656002)(66446008)(76116006)(5660300002)(4326008)(66476007)(64756008)(66556008)(8676002)(91956017)(2906002)(66946007)(6512007)(53546011)(26005)(6506007)(83380400001)(66574015)(2616005)(186003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RXpwbkQvYWhrc0hybWhtdmp0WTM1VC8wSFI4Vmxrdi9uZjJ2RW9nNzV0Q1Bl?= =?utf-8?B?WjYxRitZSEQyQllqY3RpYWRpZ1lPNGZvU0tjM1IzY201WXFpYnlSanBSM3Zm?= =?utf-8?B?aWpodnp6YllTZy9IVmVTWlg1dVJDRE5yMGUrV0krRnFQUUhPalZDcmZZQzJu?= =?utf-8?B?d1kzV21JN0ZlWkMreUZjZG51bWZqdDZSdVFNa0tRNnY4WURzUFNMaER6MlVJ?= =?utf-8?B?QVZNNFc3SDJadThxckpDTTBpbzdJN3JHRXlLR2F2TGVLd2FMZHE2ZlYwSDVu?= =?utf-8?B?dXlzVlpPSlhGM2xBQkNISjdDeUFsaWRRR1R0KzJOeUJHUklyaXZCTW1iY2tW?= =?utf-8?B?RExRZ2xzRXEvWGVwZDk5NkR2MitPV3Z1MzRUNnFIaGZGdGczbGgwNWU0Q09u?= =?utf-8?B?clhSR1RRcjBVMUxpZ0R5dlVSZllkbUs2bWVyZ2hvbFVXZDRSSnFsaWpyekJD?= =?utf-8?B?K09PSG9QVlFPZkNsR3N0aktrZ29keWxxSXVqMmNTa1JhN0p1eEZoUHpWdkF1?= =?utf-8?B?WnI1eVhtTnpick5xSGl0bEVBeTgwRlJ0L21sdVVSQnFpM28wQnpvOU9XRHBj?= =?utf-8?B?UkN3Z1UwTXJMV3FIQXI0T0hQKzdaRUZzZzhCSTl5aGxyTVlMNUNpMWtIcWpV?= =?utf-8?B?S3pBa1pTZS9lRzJTcXJtL0lQQ1pkVWZUdFhacGxoeWZKdTB1NDBKR3VMdTQ0?= =?utf-8?B?UE9hZDRpaC9VejdBZk54SGxWRVJnN1ZDeTNHTDhoaVlROVRXNlZnYndjbGR4?= =?utf-8?B?TXBlNHZSNmZKZHBzYys2TjhPTFRib1Bkd0pDQXpjRVAvTEx2OGVkaVN0YWEw?= =?utf-8?B?T2Mzb3NzZ0oxM3BzZzB0RDF1UmNrV1NYUHhJN3lYSG8yNE94U2RGczNqWkFp?= =?utf-8?B?cDllNk9EeVpXRFZwbmw3TFB1aG9pK2FOWllDakZMeDZvTkNZNVBRTEpYY2lH?= =?utf-8?B?SjBvUkI2aDcyZDN1c1dVamE5ODRTcHM2VU54eDkxdGwrMXRyYzhwblJMMHg4?= =?utf-8?B?UmNKMDAxZzNQaytqYWJhSzNoLzRKbDNsd0I2cktLbmFvNjZJQlEzRk41SUtj?= =?utf-8?B?cTNFTjdCc3VrL2RQaGNBeGZpN0o4L1FrdGo0ejVOQUxkYUpLQkZYOTJ6V1RZ?= =?utf-8?B?aHkzNnVaOG01RXlReDlRVGlQL0FKR1VPYTVtbTgyOVdmbWlucHY0VWcxOHow?= =?utf-8?B?bmFKSkwvTUdqZm1pbGc2U1RpM0crOWd4amdIUTczTG9mU2hsak8zSDZOSExD?= =?utf-8?B?c3dTbVBvUFQyc214ak56cHQwengrT0RZUW1lTlBEeThQWk1laGhRNEVwQjY3?= =?utf-8?B?c2NLL2YxaGZPVFJXbHllTU9SZVJQV05TMlBYQjBRNzZHb21JTE0rdU53ZXJk?= =?utf-8?B?TURmTTRhenQ3MTRlaUQzRVpjQkpLTkFoZmtsVjcwY0lTNWwzaWdNZXN3T3d2?= =?utf-8?B?WFJHUm0vV3U3T01CYUNKVFpCL3NkS2hIQjRPeXJETkhYZFhxTWxRUEdEM0ZP?= =?utf-8?B?QUV2ajN5ZkZZSzF5YWRIaDZQa3pqcGYzSmcxVnlGUERKOFpWMDMxdHRlTFA3?= =?utf-8?B?NzZtc2I0alpLdzlJdFF3UEtyWVV1WDVueGRRQTVCMnVrdGdLRlNEMmpqNUJs?= =?utf-8?B?d2E5L0hPWWI1WGg2RWxUQTNRZStsNFZyVnJMWDFSTnBnU0lEcElKdjRHeUZj?= =?utf-8?B?RGVuQmVmdnAwa213YmVLdElaYmhNY3EzTjJoVUxyMm50NjhUMWhUK1IwOU5X?= =?utf-8?B?QXp4TmRQRzl2OFlYTWprZE9ZQzZjbFYvNmVab0laUFpXTHg3bUEwKzk5ZXI2?= =?utf-8?B?Wi9UNzNiZjh2bmJ3K05Fa0JpZEdROUlkQzJ0dnpCbWF3cDBRV1JBZ1RQREY4?= =?utf-8?B?L0RqMnhTM0xVYTlIT2Vwb1dRTU04WW03bmZyd2FxTURhSDNUcVhadFpHQTcy?= =?utf-8?B?MVlDZnZSblZ1bzBKNXdMeS9iZmVKTCtIYTUySUQ2Y2dWeE5hb1NjT0h6TXRv?= =?utf-8?B?OWE4V2hHM0RGSy9mUm8rQ2RMWk5oS0hCSWl6ZnhXejJmbDA4N1Z3Wm4xZFF0?= =?utf-8?B?QlpLZEpwS0psRSs4aHRmcnBka0tmQW0zcVR0MG1jOHpDZjVnb2tmNDFpQU9i?= =?utf-8?B?UUo4N0I1NlBlM1dCb2J0cmtkeVVrUlZtd0FXSGc1bGtCKzd3VTkxR1ArQlV0?= =?utf-8?B?R1E9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <31CF3861C39A994DB38501F4F667C123@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b9c6aa9-e93d-4ecf-68cb-08dac233d945 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 09:21:57.0515 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5PN3HdHBpIMI6rECgw7hc50SzrTeLzsA7FDlC7DXSael8oFrfw+zdjWV+86O1MwekaMQepwYWjbOfhhlo+LL6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5063 DQoNCj4gT24gOSBOb3YgMjAyMiwgYXQgMDc6MTAsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwOS4xMS4yMDIyIDAzOjQ3LCBIZW5yeSBXYW5nIHdyb3Rl Og0KPj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+Pj4gRnJvbTogRWR3aW4gVMO2csO2 ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4NCj4+PiBTdWJqZWN0OiBbUEFUQ0ggZm9yLTQuMTcg djMgMDkvMTVdIHRvb2xzL29jYW1sL3hlbnN0b3JlZC9zdG9yZS5tbDogZml4IGJ1aWxkDQo+Pj4g ZXJyb3INCj4+PiANCj4+PiBCdWlsZGluZyB3aXRoIER1bmUgaW4gcmVsZWFzZSBtb2RlIGZhaWxz IHdpdGg6DQo+Pj4gYGBgDQo+Pj4gRmlsZSAib2NhbWwveGVuc3RvcmVkL3N0b3JlLm1sIiwgbGlu ZSA0NjQsIGNoYXJhY3RlcnMgMTMtMzI6DQo+Pj4gV2FybmluZyAxODogdGhpcyB0eXBlLWJhc2Vk IHJlY29yZCBkaXNhbWJpZ3VhdGlvbiBpcyBub3QgcHJpbmNpcGFsLg0KPj4+IEZpbGUgIm9jYW1s L3hlbnN0b3JlZC9zdG9yZS5tbCIsIGxpbmUgMToNCj4+PiBFcnJvcjogU29tZSBmYXRhbCB3YXJu aW5ncyB3ZXJlIHRyaWdnZXJlZCAoMSBvY2N1cnJlbmNlcykNCj4+PiBgYGANCj4+PiANCj4+PiBU aGlzIGlzIGEgd2FybmluZyB0byBoZWxwIGtlZXAgdGhlIGNvZGUgZnV0dXJlcHJvb2YsIHF1b3Rp bmcgZnJvbSBpdHMNCj4+PiBkb2N1bWVudGF0aW9uOg0KPj4+PiBDaGVjayBpbmZvcm1hdGlvbiBw YXRoIGR1cmluZyB0eXBlLWNoZWNraW5nLCB0byBtYWtlIHN1cmUgdGhhdCBhbGwgdHlwZXMNCj4+ PiBhcmUNCj4+Pj4gZGVyaXZlZCBpbiBhIHByaW5jaXBhbCB3YXkuIFdoZW4gdXNpbmcgbGFiZWxs ZWQgYXJndW1lbnRzIGFuZC9vcg0KPj4+IHBvbHltb3JwaGljDQo+Pj4+IG1ldGhvZHMsIHRoaXMg ZmxhZyBpcyByZXF1aXJlZCB0byBlbnN1cmUgZnV0dXJlIHZlcnNpb25zIG9mIHRoZSBjb21waWxl ciB3aWxsDQo+Pj4+IGJlIGFibGUgdG8gaW5mZXIgdHlwZXMgY29ycmVjdGx5LCBldmVuIGlmIGlu dGVybmFsIGFsZ29yaXRobXMgY2hhbmdlLiBBbGwNCj4+Pj4gcHJvZ3JhbXMgYWNjZXB0ZWQgaW4g LXByaW5jaXBhbCBtb2RlIGFyZSBhbHNvIGFjY2VwdGVkIGluIHRoZSBkZWZhdWx0DQo+Pj4gbW9k ZSB3aXRoDQo+Pj4+IGVxdWl2YWxlbnQgdHlwZXMsIGJ1dCBkaWZmZXJlbnQgYmluYXJ5IHNpZ25h dHVyZXMsIGFuZCB0aGlzIG1heSBzbG93IGRvd24NCj4+PiB0eXBlDQo+Pj4+IGNoZWNraW5nOyB5 ZXQgaXQgaXMgYSBnb29kIGlkZWEgdG8gdXNlIGl0IG9uY2UgYmVmb3JlIHB1Ymxpc2hpbmcgc291 cmNlIGNvZGUuDQo+Pj4gDQo+Pj4gRml4ZXM6IGRiNDcxNDA4ZWRkNDYgInRvb2xzL29jYW1sL3hl bnN0b3JlZDogRml4IHF1b3RhIGJ5cGFzcyBvbiBkb21haW4NCj4+PiBzaHV0ZG93biINCj4+IA0K Pj4gTml0OiBUaGUgZm9ybWF0IG9mIHRoaXMgIkZpeGVzOiIgdGFnIG1pZ2h0IG5lZWQgdG8gYmUg Zml4ZWQ/DQo+PiANCj4+PiANCj4+PiBTaWduZWQtb2ZmLWJ5OiBFZHdpbiBUw7Zyw7ZrIDxlZHZp bi50b3Jva0BjaXRyaXguY29tPg0KPj4+IC0tLQ0KPj4+IFJlYXNvbiBmb3IgaW5jbHVzaW9uIGlu IDQuMTc6DQo+Pj4gLSBmaXhlcyBhIGJ1aWxkIGVycm9yIGluIGEgcHJldmlvdXMgY29tbWl0IHRo YXQgaXMgYWxyZWFkeSBpbiBtYXN0ZXINCj4+IA0KPj4gWWVzLCBnaXZlbiB0aGlzIGlzIGEgc2lt cGxlIGVub3VnaCBwYXRjaDoNCj4+IA0KPj4gUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8 SGVucnkuV2FuZ0Bhcm0uY29tPg0KPiANCj4gQWZhaWNzIHRoaXMgcGF0Y2ggd2FzIHByZXZpb3Vz bHkgcG9zdGVkIGluIGlzb2xhdGlvbiwgYW5kIGl0IHdhcw0KPiBhbHJlYWR5IHJlbGVhc2UtYWNr ZWQuIFdoYXQncyBsYWNraW5nIHRoZXJlIGlzIGEgMm5kIG1haW50YWluZXIncw0KPiBhY2sgb3Ig YSBwcm9wZXIgUi1iLiBXaGVuIGl0IG5vdyBpcyBwYXRjaCA5IGluIGEgc2VyaWVzLCBpdCBpc24n dA0KPiByZWFsbHkgb2J2aW91cyB3aGV0aGVyIHRoaXMgY291bGQgYWxzbyBiZSBjb21taXR0ZWQg aW4gaXNvbGF0aW9uDQo+IChpdCBsb29rcyBsaWtlIGl0IGRvZXMsIGJ1dCBhIGNsZWFyIHN0YXRl bWVudCB0byB0aGlzIGVmZmVjdA0KPiB3b3VsZCBoYXZlIGJlZW4gYmVuZWZpY2lhbCkuDQo+IA0K DQoNCllvdSdyZSByaWdodCBpdCBhbHJlYWR5IGhhcyBib3RoIGFja3MsIGl0IGp1c3QgaGFzbid0 IGJlZW4gY29tbWl0ZWQgeWV0OiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3Qv eGVuLWRldmVsL3BhdGNoLzVhNDUzMzkzZGFkMWRlODI4NmZlNWRiMTY1MDRkM2RiMjkwNmVlZjgu MTY2NzUwMDk3MC5naXQuZWR2aW4udG9yb2tAY2l0cml4LmNvbS8NCkkndmUgYWRkZWQgdGhlIGFj a3Mgbm93IHRvIG15IGdpdGh1YiBicmFuY2gsIHNvIG5leHQgdGltZSBJIHJlc2VuZCB0aGUgc2Vy aWVzIGl0IHNob3VsZCBiZSB0aGVyZS4NCkl0IGNhbiBiZSBhcHBsaWVkIGluZGVwZW5kZW50bHks IEkndmUgcmViYXNlZCBhbmQgbW92ZWQgaXQgYXQgdGhlIGJlZ2lubmluZyBvZiB0aGUgc2VyaWVz ICh0aGVyZSB3YXMganVzdCBzb21lIHdoaXRlc3BhY2UgdG8gZml4IHVwKQ0KDQpJZiBpdCBoZWxw cyBoZXJlIGlzIHRoZSBjb21taXQgaW4gaXNvbGF0aW9uIHRoYXQgY291bGQgYmUgY2hlcnJ5LXBp Y2tlZCBvbnRvIG1hc3RlcjoNCmh0dHBzOi8vZ2l0aHViLmNvbS9lZHdpbnRvcm9rL3hlbi9jb21t aXQvZGE4OGI0MzhlMDNkYTM2MjEyZDA3ZDI0ZDY3YWIxNTFhZTI4N2Y0ZQ0KDQpCZXN0IHJlZ2Fy ZHMsDQotLUVkd2lu From xen-devel-bounces@lists.xenproject.org Wed Nov 09 09:26:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 09:26:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440747.694900 (Exim 4.92) (envelope-from ) id 1oshLV-0000Cy-4v; Wed, 09 Nov 2022 09:26:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440747.694900; Wed, 09 Nov 2022 09:26:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshLV-0000Cr-1o; Wed, 09 Nov 2022 09:26:09 +0000 Received: by outflank-mailman (input) for mailman id 440747; Wed, 09 Nov 2022 09:26:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshLT-0000Cl-Mf for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 09:26:07 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2075.outbound.protection.outlook.com [40.107.102.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 884bc925-6010-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 10:26:05 +0100 (CET) Received: from DM6PR11CA0012.namprd11.prod.outlook.com (2603:10b6:5:190::25) by SA0PR12MB4447.namprd12.prod.outlook.com (2603:10b6:806:9b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Wed, 9 Nov 2022 09:26:00 +0000 Received: from DM6NAM11FT030.eop-nam11.prod.protection.outlook.com (2603:10b6:5:190:cafe::1c) by DM6PR11CA0012.outlook.office365.com (2603:10b6:5:190::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26 via Frontend Transport; Wed, 9 Nov 2022 09:26:00 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT030.mail.protection.outlook.com (10.13.172.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 09:26:00 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 03:25:57 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Wed, 9 Nov 2022 03:25:56 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 884bc925-6010-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=edvRUrg3/jwmFrtYbZI7h327JwsO9ClXCpMa2aI/hPWLENkTp6bv9HiWmWD9fw6PvFwnOzo89yHAWgZrRCShnPbY5vxNfLVEp3eDs1Rti5vxBkGYgOX08jmR57t5icJaiYKk2wQHJOLz7QXZAXDEIEU4NISmmKoUWevVLy4dNM6A7vN4m492LaO1B9JZZHjXLOlPaAVeK7AZtOqUXV2pNHqSYTRdyo5pbZDGQ1/1kX70GDtmOnEMpaF154oQutQTjh/GHPNLEQmLsw2WeYpHCkWIWDL7jHRWiYNZylQelGyk3HCQQGOegI/E7vO55K+qqM9fGL+yPdAVBmy7VeGR4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1IgZXZ8vzh/ylSC0DwcCkflG0dKrWJQYwSG0rIHDXiQ=; b=hOhHIbpL88E+173NyazgAqYdntkRgi2arwtPsXSx++Yx8QqJHL2nMRKAQUjvKmpfgTLMBPOZ4M09lf77yGv2IRZC6WBNN3UB33ewcgiOeBDbq106JRTjDXlpAJXmlVsnprEg0VqxQtrR+zonIJ6whhVzxZ50uV2APqQJytT18Ye+EzyTFGjU+S3lCsycFwXnrYeXTZcJp9Uxri5J3bcHPjOy2g6kMaPwl8udwZgZq5aD2qmWIyMW4PezdjJ31Tu9oBSvnq93vYFdrRtUnxocTbsbXhbjFMqz4A/k3nGXlmsvMaUAkExcKCup2zFbw/sET/6IQq96Iyxk31tler9bbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1IgZXZ8vzh/ylSC0DwcCkflG0dKrWJQYwSG0rIHDXiQ=; b=YWBvDv2oJgSzX+j7qKLWpEimIeAyARzdTYIX6aByipOiG0O99EL9fUKTnCVHwIT7dAPlgk7st8wUmJr313k4r0+hghLTiMQjnAkmZFNcfNHY/WcPUfyzLG3xpvEwOT5JgI+Qj3BYWSnqUN6FCL9GJ7OCjUGurjZUPIq5dbl4ymA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Wed, 9 Nov 2022 10:25:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Xen Arm vpl011 UART will cause segmentation fault in Linux guest Content-Language: en-US To: Jiamei Xie , "xen-devel@lists.xenproject.org" CC: Wei Chen , Bertrand Marquis , "julien@xen.org" , "sstabellini@kernel.org" References: <00764fe2-f78a-e5db-cb16-903ad1a5ec03@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT030:EE_|SA0PR12MB4447:EE_ X-MS-Office365-Filtering-Correlation-Id: b85539f4-f079-472c-1b9a-08dac2346a5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DmZfD9v1v9wdDZKKqh8/mlmDd3DK3O1NeEL406+xvFLyHuzosDdjiXmmcEsLBZhAxc4iTDzzFdH0O+U5PHwpvNz5YqRE8hYzgV4ruWgGpsZVGijbuLBMyC3rK+s2V3gLNTdpOCX2sziSaFZQwR77zThaNxzVa7JveVss9Z8hiMrm7uAWMNYjwgZfwoSo/uF31+/SFK8UxGZj/JxcNFQuPK8G07XG8MjSD56OPv0z6cShK2qOwOQB9tV4emk4HgKGjni+GJQFpvtPrLAl1nIFDcZHya+Nyuj3dmBHoj2VnMa8g2gIIy2u7YO4n00ku/pCq7bwSUmwe59EHL2WCb5sCjs4wOUM9K3/NjBu4SGcZNV0OGYhFY/nFgHxD3PK6N1VzM53rrueOuNOHG+89TGe/MKdKFs0ZMx8t70R8necGjBcK5UjbxItn0FnVavx/kB+/U/oHs8oHqw6uRGxbQb/gQTnTR19eLTbRT8IjiTXIv+f9TQ3Z+nsRLu15RBI1nj6TqpcZTq3Vc4AwFAOba8EWeHfuFxagQQiyS62K7NCNrFHIl/Huui+Cn9Qgon2l+zBLfZCfuTsIPm4D4JOXA0L9YjIvgpEP9EOQlpC6PXb+endnu2i5T8HpNZQnZ3Vt9FdGGATIAAbGqBtetqolFYJjI+VKaiX++2qX158a/N37EX1z7QtvRm+VTXeWZD0i8lJGE9oc8fZ6wysqb7Qt82OfJFWbzGn4T2GmtpeubUV6uMjJLfFzApEsw9oLGPBMNHUD3McYRmPPyCE+Yr/noPqMfULCZJQZf7bshAZ8ebubTGrWKnXl44YKD1cD+M0A2EVFyGfZLXtCNXp5h2WTN0LaA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(346002)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(47076005)(83380400001)(2616005)(426003)(26005)(356005)(36860700001)(186003)(53546011)(336012)(8936002)(40460700003)(2906002)(40480700001)(82310400005)(41300700001)(16576012)(5660300002)(478600001)(54906003)(4326008)(8676002)(44832011)(70206006)(70586007)(316002)(110136005)(45080400002)(66899015)(36756003)(81166007)(31696002)(82740400003)(86362001)(31686004)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 09:26:00.4205 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b85539f4-f079-472c-1b9a-08dac2346a5e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT030.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4447 Hi Jiamei, On 09/11/2022 09:25, Jiamei Xie wrote: > > > Hi Michal， > > Below log can be got when stating the linux guest. It says 9c09 is sbsa. And 9c09 is also output > in bootlogd error message: > Serial: AMBA PL011 UART driver > 9c0b0000.uart: ttyAMA0 at MMIO 0x9c0b0000 (irq = 12, base_baud = 0) is a PL011 rev2 > printk: console [ttyAMA0] enabled > 9c090000.sbsa-uart: ttyAMA1 at MMIO 0x9c090000 (irq = 15, base_baud = 0) is a SBSA > Xen behavior is correct and this would be Linux fault to try to write to DMACR for SBSA UART device. DMACR is just an example. If you try to program e.g. the baudrate (through LCR) for VPL011 it will also result in injecting abort into the guest. Should Xen support it? No. The reason why is that it is not spec compliant operation. SBSA specification directly specifies what registers are exposed. If Linux tries to write to some of the none-spec compliant registers - it is its fault. > Best wishes > Jiamei Xie > ~Michal > > >> -----Original Message----- >> From: Michal Orzel >> Sent: Wednesday, November 9, 2022 3:40 PM >> To: Jiamei Xie ; xen-devel@lists.xenproject.org >> Cc: Wei Chen ; Bertrand Marquis >> ; julien@xen.org; sstabellini@kernel.org >> Subject: Re: Xen Arm vpl011 UART will cause segmentation fault in Linux >> guest >> >> Hi Jiamei, >> >> On 09/11/2022 08:20, Jiamei Xie wrote: >>> >>> >>> Hi all, >>> >>> When the guest kernel enables DMA engine with >> "CONFIG_DMA_ENGINE=y", Linux AMBA PL011 driver will access PL011 >> DMACR register. But this register have not been supported by vpl011 of Xen. >> Xen will inject a data abort into guest, this will cause segmentation fault of >> guest with the below message: >> I am quite confused. >> VPL011 implements SBSA UART which only implements some subset of PL011 >> operations (SBSA UART is not PL011). >> According to spec (SBSA ver. 6.0), the SBSA_UART does not support DMA >> features so Xen code is fine. >> When Xen exposes vpl011 device to a guest, this device has "arm,sbsa-uart" >> compatible and not "uart-pl011". >> Linux driver "amba-pl011.c" should see this compatible and assign proper >> operations (sbsa_uart_pops instead of amba_pl011_pops) that do not enable >> DMA. >> Maybe the issue is with your configuration? >> >> ~Michal >> >>> Unhandled fault at 0xffffffc00944d048 >>> Mem abort info: >>> ESR = 0x96000000 >>> EC = 0x25: DABT (current EL), IL = 32 bits >>> SET = 0, FnV = 0 >>> EA = 0, S1PTW = 0 >>> FSC = 0x00: ttbr address size fault >>> Data abort info: >>> ISV = 0, ISS = 0x00000000 >>> CM = 0, WnR = 0 >>> swapper pgtable: 4k pages, 39-bit VAs, pgdp=0000000020e2e000 >>> [ffffffc00944d048] pgd=100000003ffff803, p4d=100000003ffff803, >> pud=100000003ffff803, pmd=100000003fffa803, pte=006800009c090f13 >>> Internal error: ttbr address size fault: 96000000 [#1] PREEMPT SMP >>> Modules linked in: >>> CPU: 0 PID: 132 Comm: bootlogd Not tainted 5.15.44-yocto-standard #1 >>> pstate: 604000c5 (nZCv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=--) >>> pc : pl011_stop_rx+0x70/0x80 >>> lr : uart_tty_port_shutdown+0x44/0x110 >>> sp : ffffffc00999bba0 >>> x29: ffffffc00999bba0 x28: ffffff80234ac380 x27: ffffff8022f5d000 >>> x26: 0000000000000000 x25: 0000000045585401 x24: 0000000000000000 >>> x23: ffffff8021ba4660 x22: 0000000000000001 x21: ffffff8021a0e2a0 >>> x20: ffffff802198f880 x19: ffffff8021a0e1a0 x18: 0000000000000000 >>> x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 >>> x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 >>> x11: 0000000000000000 x10: 0000000000000000 x9 : ffffffc00871ba14 >>> x8 : ffffffc0099de260 x7 : ffffff8021a0e318 x6 : 0000000000000003 >>> x5 : ffffffc009315f20 x4 : ffffffc00944d038 x3 : 0000000000000000 >>> x2 : ffffffc00944d048 x1 : 0000000000000000 x0 : 0000000000000048 >>> Call trace: >>> pl011_stop_rx+0x70/0x80 >>> tty_port_shutdown+0x7c/0xb4 >>> tty_port_close+0x60/0xcc >>> uart_close+0x34/0x8c >>> tty_release+0x144/0x4c0 >>> __fput+0x78/0x220 >>> ____fput+0x1c/0x30 >>> task_work_run+0x88/0xc0 >>> do_notify_resume+0x8d0/0x123c >>> el0_svc+0xa8/0xc0 >>> el0t_64_sync_handler+0xa4/0x130 >>> el0t_64_sync+0x1a0/0x1a4 >>> Code: b9000083 b901f001 794038a0 8b000042 (b9000041) >>> ---[ end trace 83dd93df15c3216f ]--- >>> note: bootlogd[132] exited with preempt_count 1 >>> /etc/rcS.d/S07bootlogd: line 47: 132 Segmentation fault start-stop- >> daemon >>> In Xen, vpl011_mmio_write doesn't handle DMACR . And kernel doesn't >> check if pl011_write executes sucessfully in pl011_dma_rx_stop . So such >> segmentation fault occurs. >>> static inline void pl011_dma_rx_stop(struct uart_amba_port *uap) >>> { >>> /* FIXME. Just disable the DMA enable */ >>> uap->dmacr &= ~UART011_RXDMAE; >>> pl011_write(uap->dmacr, uap, REG_DMACR); >>> } >>> >>> I think we should prevent such segmentation fault. We have checked the >> PL011 spec, it seems there is not any register bit can indicate DMA support >> status of PL011. We might have two options: >>> 1. Option#1 is to add DMA support for vpl011, but this is not trivial. >>> 2. Option#2 is to ignore the write to DMACR, and return 0 for DMACR read >> in vpl011. But this option need co-work with kernel, because current Linux >> PL011 driver assume the write operation will never be failed, and will not >> fallback to no-DMA mode, when Xen return 0 for DMA enabled bit in DMACR. >>> >>> How do you think about it? Any suggestion about it is welcome. Thanks. >>> >>> Best wishes >>> Jiamei Xie >>> From xen-devel-bounces@lists.xenproject.org Wed Nov 09 09:30:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 09:30:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440754.694911 (Exim 4.92) (envelope-from ) id 1oshPQ-0001bw-ML; Wed, 09 Nov 2022 09:30:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440754.694911; Wed, 09 Nov 2022 09:30:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshPQ-0001bp-J1; Wed, 09 Nov 2022 09:30:12 +0000 Received: by outflank-mailman (input) for mailman id 440754; Wed, 09 Nov 2022 09:30:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshPP-0001bj-8p for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 09:30:11 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2054.outbound.protection.outlook.com [40.107.20.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1aaa3901-6011-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 10:30:10 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7575.eurprd04.prod.outlook.com (2603:10a6:20b:29c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Wed, 9 Nov 2022 09:30:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 09:30:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1aaa3901-6011-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MYJ74Xc1xw/W0ypMmaZeOwZtiEwuQVMO0DU5j7F1ItItCAtD39v7MOsCu4fqNXzXWedTaiu7f3B8lJ/S9uqtljpM0YIDWpW3DV+tkBqFRSHScCSOKixZJNxNixLW3jbfgfMEkDNYVpEZiZwGykY3E4tKHRWR2mJtJ+0tHvBEBNumajGkTOCHYbU35S/PmGh4TxCgxD59yI7hjeLWN9khoSkLws+qJoV4iQ5W//7Lxg/H8D8cGdygcpjAIY66SxlpTBRtS8Hhabw9d0w+Z+0WcBxhNZErcU0eBG6o2tfxvNiv+0lvjs/QbM3oE7W70saFOh6IbpisvZJ7JQY+OxUqNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2kZE7U7NQ7GZIwC5g9fFzLHfPsijZCo0hDfLuoH5oOM=; b=YtEyhhAMPxC9Kv/2vKYs/yCIXYBunk9wHRnuBlZQKDDPThdYYQBh72B+egBTltPKeT9lSor9X1mu9lYswnWfQ4l6LbL7PWCMonlCSuHSPTOlPRBgu+/KA6VlNZnP/f2f/Ml8pBXzXAmDICBys14BhG++uFIlh73wL7lBHC2PV+zQHfmjJuhs7Gh3N5ZJ0JoUI+070NmGwJwfn7fGA9zm9LJiRpgyfBkvrsybyrCEvTPKVjwWpYKMp27Qu3lS53LEZ1qE0OhJ48/lEKrRAEkG4ZFVr36jyfEwK5j0aDD9MAOvQOrC1DGM/ok1I+DgA+zNaGOtwBbElIYyiO8+n3e9tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2kZE7U7NQ7GZIwC5g9fFzLHfPsijZCo0hDfLuoH5oOM=; b=ODxHN1duUVAdMEtCOeB9h6COsaiP2LTohx01EEXhz+PslITSkUJTD5UtO9DQn8SKIOxsTJncrLRjdKKwbWfcod71YuTcn6WSSS6oDm/wuD4yeWoOEUmpxupQ0WPvyeYHpLbksZza9EAmOOaOdCfN8GKJVRDu1F0L58oRAnVlZzurYyF3echI01pwtZzoCfQDFrdNMh6VJd/57EGpwsBpxLyJr7DbrFZGHR/doJ2Q3agYGbdw2uDFhS3jtOykIl5YiezTFV5NvOoK9DxkGT5WilRKrHd5KkUaP4vlQ97jLS2KE6/th3ErvEXR3AHCiSTQFsh/Sn6OrwdaPfSNfkzpaQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <64dfe9e6-8d92-8be9-c987-28d507ac617f@suse.com> Date: Wed, 9 Nov 2022 10:30:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v7 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <20221020061445.288839-1-wei.chen@arm.com> <20221020061445.288839-6-wei.chen@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7575:EE_ X-MS-Office365-Filtering-Correlation-Id: 44c22643-1ff4-4d4e-e87a-08dac234fe04 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TX1LkgD2+TjNX3DgJJD/1E/FYVTx0MujpLIV1ihnRxLRxwqCyhVC3VrDFiu/KJmgj8s5wT9lcGuU1lch4PRNbsz6x8IeqwgJQf35FxIw2d+h9HV1HIPG+Vy5UqiDK+9CeIs8dB9LJZpCKsmJisdKYmLcFqEKR7o4lIxEIHWdGMnXQ9qD6JWrjDkTwxi1Zluc9GQiCZK46W9HRvlF4efZj8fRkjZNgxtZe5Gan2VSKmBiH6QF5pAUQkBQUJDOBIVj2D9P/ZTaf13fkX4KjQ4PedA1+U9udJgH8aUB7AudwsIARCZ7JGwc9b8Z72p5VCghxpNJL/db75aL2RIQAFA0kDx11FcKBAWq8DpYvp011udSmXKPmbtYY1SRAPbaHA8QefNFBwTuDO7XplgGO3mleJ2b9rjq2jMQ+ABesBqRV+oyYy3PvujzN+W0DwCGFAOL2DwwNw33aatAKiKrJsTjkGAVJ45OrtP6tYLDEIHFOnNcXDWQjQHLILEbpfLOmVpB8qTADYrDwEq+jNWoPX97sfyRo2KQF6Sfu3+QzwQorw53YW+xGthemHfcjiyGlvL7RMlXproh9XjsllYQv8E9LPTTreqPEMRCQ1wYHL26gUxlSk3aMbRdx4k9HGYjUFlcWnrYGIkQEow2NfuzIX3kBxN5mZpV9vNbBKUAUwKWWpiHThyyzI0dvC8wTnYDsvNWIlEMkZbj/C0UK7MSrbq0Dv/MgMH5dmLqTGOtncpd5V8vJy8dfGVBn81EMD6Z8fk9Yi3aGg1kpa/AGQIr6L//JGA3KkeabR2P0ModR1AYQPY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(396003)(346002)(366004)(376002)(451199015)(36756003)(31686004)(38100700002)(31696002)(86362001)(5660300002)(2906002)(53546011)(186003)(6506007)(83380400001)(6512007)(2616005)(26005)(478600001)(66476007)(66946007)(66556008)(54906003)(4326008)(6916009)(6486002)(316002)(8676002)(41300700001)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekwxN3NWV1ByYTc2dmp2bkJoWXdXWHJqN2Z0WFoyU3BxL1pLTXJHTlJDVHp6?= =?utf-8?B?dUZRTzZ0dyt1bGdPdXJTRURLd1ZuMGR4cWFabXNQT3FmVTExZkFXbmpHdmdQ?= =?utf-8?B?MUN4REEyTFNOdXN5RmtPZUtWY3FwdGV3NkxoS003WWx4SXMwOUFlSk5iUFVv?= =?utf-8?B?amgyenVTNEt2a0ZJZEdka2NEelA5M2ZNMUYxOFZrVnk3ZlorTkNxcXV6Wlhk?= =?utf-8?B?d1dPZlBCRUxUcjdqM1NPZlVQZUJtbzJhUWNRMVY3ZnJ6Wko3bUVSazhOKytP?= =?utf-8?B?azMwRDhVL2RHS2xTeVBHWnlYN0V4cDAyZWhyd2RRcXZENkl3NytnOUtMeml5?= =?utf-8?B?SEdseXI1T1cvemV0TjJ0ZnhVc3lvMTg5R0YyR2p6Z3BBQ203ODVBbXhqVG5X?= =?utf-8?B?WjUyUnJ1SUljUzA0MWxRc0xiYWhrckZkMm5Hd1FDRjBGRFZZRDNKM0NtUWYx?= =?utf-8?B?QUUyS3dPdGh3T2lkQzJDaWdBSmNya1d6TTNxOEV0ZTJmTDhNTGd6ZzN4SzJF?= =?utf-8?B?aU9iend5NFdYN3Y1aUVmdDVyVVRoTHNwUGUwTDZVUS9KOU11aGpxQzBpa29G?= =?utf-8?B?SWdrc0R1T296c1NyM3hldEs1ZVNyUTRISjYyN0VXaWl0Z1VKNVkxKy9XQkpD?= =?utf-8?B?dFd3TUwva0IyTG4yaU9DZkRrS0Mvc1R1TlVCMHR1MDFMZy9nQS9oeXBCOVd2?= =?utf-8?B?SmpMOEZDMklic3h4akVybmFZclltUUtac05yWkRJOUpaVDlRdjE4emxRTDJ0?= =?utf-8?B?Z0Y4ams4d3gwWVJuY2lBdElNbXdzblBQSW1hYldYV0psK0xTMExKdDFZQkQw?= =?utf-8?B?Q3RYdmpneFV6SWJJajY5OHpDcllUVExoWTByQVlHckN3Y283OGZkdGhlNm5r?= =?utf-8?B?ZGNvYkJkeDFVV3VCRTBkYldCNE5mNUhGd1dSWWtiT0RVTG1sR0QrQ3U4a1lt?= =?utf-8?B?MzdFbUE1Y2p3UU1lQXRpOERUM3BEMFpIOExEQnFFWDVVZmF4cmduR0YzbnVn?= =?utf-8?B?NkJxekN1eG83OWlkZjhFNURFejQzTTZoZUxtZ1VwcnBhZUViOWVyYlU5Rmhy?= =?utf-8?B?UnhaalNRUHdzWGpicitJTUs3bjB4YzJLd3BoWk03Q214aERlSnBJd2R1Nzdj?= =?utf-8?B?VGQzYlJSSmNrTGxsQVpEQnZwTjI0VGhyNzRreEl6M29KK2xsM1J1WjRxT3FW?= =?utf-8?B?S3FNaXFKUWxwbTZDcFg3UTZZckN2ZXpmWUZNcjRJYlBGR2ZZY3d0TkJsUXJ4?= =?utf-8?B?WG5kWUZSM1ROMUxWcnR6SGhOMm9QMno0WmhPbjArTzBzMm40WlBOazVDS3ND?= =?utf-8?B?Z0s1SjNINUpXaUpyV0N5NnhUd20zSlZXZVpSa1o3WTBUSzNTQkJHVlJzK2RM?= =?utf-8?B?QWtOUnV5YjZDU1BOTzA1S0xTWVpROGdKMnNxcVBUZllveThjbEg1WDlqamJj?= =?utf-8?B?SWo3a1FMMHkzMTBWWTJVYklIcmhNZDNZKzVXaEVQS2ZQN3ppbndkZUk5QUNp?= =?utf-8?B?WUwyMVI3bDBkT1FOYlVnS2cvUEp1TXlqZGJNVHVKbWNkOEVTaVZIVjlDVUpP?= =?utf-8?B?TkZ3ZDZ1SU42RnV4dVUzaGJWbkNGZW1sNW5OUVkvZ3VDdVF4MCtGN3o3U1Nw?= =?utf-8?B?QmlTOE1MUG9FemM4WUNyQTBRVkN0UVM0am42RHdNQmlIajZuV2I4TWNpaW5h?= =?utf-8?B?WVFrREtXWG1QSVNBeHlCSytnQjRsZTVWYUdlMTBGUFdaSXQybkhVTTMvWUM0?= =?utf-8?B?TTFIa053OXlQZDFNV3NmS3E3VWVkdVpRUktvSGhYenBDakdwbHh1Zm41bXUv?= =?utf-8?B?ek1rWVIrT0Z0STVqUVR1QXFZZ0JMd05xTHJ1b1RWS0hCdE84YkU1bC9MRDlZ?= =?utf-8?B?SklIWE1HNzBhSmFDWTZseFFQL1dibUlCaTNHMHRlSFp5a3pQdmxiVUJZMXFM?= =?utf-8?B?aU9CV09Cek12QW5Hb1BMSGNOb3lETXdXcmFxSnhXbThub2hsaWlXNmRTby9K?= =?utf-8?B?Q1o2Q1lBVDRUdzgzZUR5enA5YU1leXk3eDJNMjcvcVhoN3lQdG1HRWRGNHFU?= =?utf-8?B?M1l5SDVSK2h1Smg1S2VLNC84Q3ExT1RNdVFabWhnZlE2a0lBMjVaYXkydkhF?= =?utf-8?Q?dpgWYMMxW7gc1BMcnNtOakn9g?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44c22643-1ff4-4d4e-e87a-08dac234fe04 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 09:30:08.3887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gppEU/i347IjqLFGUu0iHVthJmvZqIclu29Obz1yDD0SUAo+wSP0ACaFn2c7y66v0I4BCyT5vEFIKo/9hgXNwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7575 On 09.11.2022 09:51, Wei Chen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年11月9日 0:55 >> >>> @@ -341,159 +247,14 @@ acpi_numa_memory_affinity_init(const struct >> acpi_srat_mem_affinity *ma) >>> pxm &= 0xff; >>> node = setup_node(pxm); >>> if (node == NUMA_NO_NODE) { >>> - bad_srat(); >>> + numa_fw_bad(); >>> return; >>> - } >>> - } while (found && start < end); >>> - >>> - if (start < end) { >>> - printk(KERN_ERR "NUMA: No NODE for RAM range: " >>> - "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); >>> - return 0; >>> - } >>> - } >>> - return 1; >>> + numa_fw_nid_name = "PXM"; >> >> ... this to be happening too late. Not because I can see a way for current >> code to use the variable earlier, but because of the risk of future code >> potentially doing so. Afaics srat_parse_regions() is called quite a bit >> earlier, so perhaps the field should (also?) be set there, presumably >> after acpi_table_parse() has succeeded. I've included "(also?)" because I >> think to be on the safe side the setting here may want keeping, albeit >> perhaps moving up in the function. >> > > When I was composing this patch, I also thought current place to call this > "PXM" setting would be a little late. But since there is only one function > that uses this prefix right now, I thought it was acceptable at the time. > But obviously your concerns make sense, I will move this call to > srat_parse_regions after acpi_table_parse has been done successfully. As said - perhaps not move, but copy. There is an (extremely unlikely) case where srat_parse_regions() would not be called at all. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 09 09:36:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 09:36:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440761.694921 (Exim 4.92) (envelope-from ) id 1oshVB-0002cT-FB; Wed, 09 Nov 2022 09:36:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440761.694921; Wed, 09 Nov 2022 09:36:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshVB-0002cM-CS; Wed, 09 Nov 2022 09:36:09 +0000 Received: by outflank-mailman (input) for mailman id 440761; Wed, 09 Nov 2022 09:36:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshV9-0002cG-8n for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 09:36:07 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60068.outbound.protection.outlook.com [40.107.6.68]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eed2bba4-6011-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 10:36:06 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8855.eurprd04.prod.outlook.com (2603:10a6:10:2e2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 09:36:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 09:36:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eed2bba4-6011-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gIrPmG9l2vjh9DoT/zjg8KnruYAtawKZfYc6OjvGFFo9mfYaEIsUrsJJLA1BkooT5f4d5s+CxNQ/hHOPSGC0yKJ/Nlt4wbRkWtmoA/vnShsAdBmpDL7yaWtdwA5NMxwjcaU96r8qGdgt3S81r5GMjDDkebPrXPun89liq+/AKW52dNsTeNHaVCCOXvii45R+46s/jp+BC8IdX5ZJ4bS+ZcRHfIWuHSjfLCBHAGsuZuhmPF7VshWapOp9BaRv5JbTmiuGJ3YoC/WJjAx5JIfqDgJ40psZLaZ8KKoVEh5rEJhngqqQ8nUFTJM2FLzo3z0nnw7M30uiYQA/H2tRxdaKuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bnwUd/DEPED5YzUt5/L9h9bOYRYFgQe9FRik+hFhalk=; b=gWciLTnol/0+baAIG2kvRT+FqupFwfFZLuVNu5DOhzXfuKlnuJUE0UDGYGppsKHB8CCM1IllE1wJKQz1S5RIlhmwjGTQ16JvJqaLzSWW76qETs1s2m34D/xPdv+bU3N7Wlzn7N4NxCjMjeNx63RilcTv+DodZyiVaLqcT/GxaP9xjEACW7KGOm8uMEbudvzj68aFGRf8nEIkKiMoK/FhYTEI1eVxXguwwd0zAxB0XdJqlVR5PwnWKceCquZU8dqDF8/PwxP6dcSquVQmhOGDHmMTELhdC77ay/JKWMLBpghsLVCm8IYXR59mVRl6M6l8ZA1po1/GEgInQLZbTxXdPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bnwUd/DEPED5YzUt5/L9h9bOYRYFgQe9FRik+hFhalk=; b=sBIu+VP62LQzyeaqSjSpzR3okT85kDVd/3TnHQbl9xdBWMRPMILxQOe0FyjL+Z6Pd8GHe2bZ1b2VR8YYdATJfu0rK0KOMfgoSyQj7m5UG/fd1kKbhs1N0M+gv3vsOrfvFEx1gGXgMdxHDZkY+KEGfMxbyPuebgAyVI5zTq3/iroxkJF2Zk4dosqk3tPMhvrbqBBWA1yhIQ1dlD2VPJcai+UKV+YCkEJrG/tX6wrWEv4E0z0sZEmw4ys+9Hl6ERB9qJGdGoBSWaljqYJ2YQtF66PmBKPBdoLrQjqMNh+PvdgkslMXk0EUZ88+CSTKUg3z4mqi2UhEwdm2qtL5BLh3KQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <09c03186-bdfc-d931-33bb-e589b074726e@suse.com> Date: Wed, 9 Nov 2022 10:36:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error Content-Language: en-US To: Edwin Torok Cc: Henry Wang , Christian Lindig , David Scott , Wei Liu , Anthony Perard , "xen-devel@lists.xenproject.org" References: <09afc07ba0ba65afc02028bd6b4950d8e51af69b.1667920496.git.edvin.torok@citrix.com> <1e994604-7a3f-ef5f-63f4-d03e4abe4124@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8855:EE_ X-MS-Office365-Filtering-Correlation-Id: fb43b384-ffa6-4ae1-03a9-08dac235d193 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1QClMRhjKwYoxMFxFXgPMiKeKug5abx2cOCzyLgdMIw3YdoicXrlU0BdUjQ/CEGjnHtOPH0SoCH+nItopvIpQxtHPYJTmOpmE3yZJgKPqvwQ2XV2/B4nIzm0x0nX7jjeFgEESj/8t1LjzDTOK3kqSHOijOWG9aJUhWKTC9t32zKhj/gLC074dpKKaJtxnPxTg0wQ0rnTAAdizuq8tQsP3mnBCzah6iUwmYayoWp6xaFDo1O3QhM1MIefp5Cdqj3f5MZ3qYlKbeavmO9Hn8tHN7JPhc15qiR6ETICyv5E1kvHV4VD1PFG4Kd3hjVb0kuqL4velzvnszuBM/iAawBEzE0qvlI2BktPi0f16vrPebwMAiB+i8ni66ffRWJxbIRtqUmyxKsozb1rNvn2+evRYcUz637+1UxsR7xThttTxjSbehQVAtNsTBIEpD27sh1XZC5sv24KMK3oTBV/KmEgEi1GXgHEWKdzS6IH5rHBqL75cz58BcovfCyih/hjnu6QVlzUVRkL1ccCdH41dkR/Yh1Q7zMG8Hb0ET+gL2fJ69uyIY2+ac8miYgMqChTk+ocnGFRSIp5JJpCxSHkohEPlsq7H2w+Jb3Sl7bMYrd1urQIicp9AnU5vfpsMdKGZmUxoziQcVPrmnu7a7xnd+uWFXMoNUXgxGf2ylgtbmKX69z3r3CZLhXXp/8NqyJEQq9Lncjmy0E1h18uzFad31ZXfu90O/9j3sG4c6gCdeKGbS+D2NvvB+4GJJrlLkzxeDCBk1XgkP8tDMqcjGIQzHRi9ALzIqJ1ZFgVmbOcrnPJF6c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(376002)(366004)(39860400002)(396003)(451199015)(36756003)(31686004)(38100700002)(83380400001)(66574015)(86362001)(31696002)(6512007)(2616005)(53546011)(186003)(6486002)(478600001)(54906003)(316002)(66556008)(66476007)(6916009)(66946007)(8936002)(5660300002)(41300700001)(4326008)(26005)(6506007)(8676002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHE3QjlFaVNWZzhKMjI4c0xadEhXVXRaUVhlUzZSdVVqRFlWa2hOdEV0cjR1?= =?utf-8?B?UHZjcVdhSkZ4OTVlNnpZRzFPUW1NTGRzK0hRRDJ1bWlUV3hCSXpuZHIxU1Z1?= =?utf-8?B?NVlVTlllYm9Cbmt0anFxeFBqWTZDSUo1N1pSQVllZ0tHWDRXYytzMDAxMjcy?= =?utf-8?B?bm5ENjdUejNXVXhuVnhMNXZJSGtHQis4cDcvSnNZR2RzSStrVjdNd3E3N1ZH?= =?utf-8?B?R2NKT012bmU0WkNGbWcxL0NFMTgxY2E5QUwxVjEyVzhtWjRGY1g4S09SZDIy?= =?utf-8?B?VmhzNjFJSE9jMGpMTDRWak9tL3pTZzhiZVpaOFJISlJkYzFiUjhacGFNcTNI?= =?utf-8?B?MTZQR1lXTk5GSnhGbHc2RThmT2drU3BUMXJtUVEwME8wZHNnYitvT1lzVzJu?= =?utf-8?B?SEZNN0pnRXRYbUx1ZVNmakZJSnZ3bm1OTTVSditQTDhSc09RVGVTN2ZGSHBY?= =?utf-8?B?ai9uUDlwR0lZWlhOTzdCQ3BFMFFjOHVlT0crQ3B6bDlTbzRZSUVkZ0tETDNx?= =?utf-8?B?cDJrRVRZUk5lZW4xeTlDWHA4SnRqK2RBL2IxcHR2Z2NwRVU5WGVhUlE0QXN2?= =?utf-8?B?bkwxV0gwWlMvUkhSMkpjMjVoV1I0ZmwvdUVWdlhYK2h3R3FNb3NqaklJbEMw?= =?utf-8?B?Q3E4WEkyRmE2NUNoSXlLdVFIMHhhM0JOeDRiWFJucnB4Q1FmbEdSbUEzOHhQ?= =?utf-8?B?RDBHejVXRjdUb2JvSjVXb29Wc1pLUEFrN3lYMkxydHYwRUZueXJlVWpDb3Uv?= =?utf-8?B?enZUMmIrWkppY3JTL2JWUEkzWTRFZlNlOFB2dmsvV0EyZzhBdHpqam80Rm5K?= =?utf-8?B?aDRKSUdBckRrcysyYlBCOXJDckZRSE1wbG1aRVJkYTIrMlRvdiswbHMwenQx?= =?utf-8?B?aE5SVmFiWXdIUTY4MTg4WXg2RUNOd0d1RkZQVVpaYWJ2RThuWHpldU5PU2F5?= =?utf-8?B?M0VUajVhKzJRZ2JnSDczeFhIZWJrejNKWHZsNTBEcGU4V2Z2MWdzMGpNNGNJ?= =?utf-8?B?UURadXF0V1liUFNwb2x1YnJJd0drcWVjOURKN2RIVThYdVlTTkRGSndwUita?= =?utf-8?B?Q2x4WldvMkRrZUwxaEhTZWtURlBPSVVGNG5BV1gwb0daZUpXRmFhc0k0Wmpu?= =?utf-8?B?SzYzZ2NDVlpJQVF5bG1TTlEyWllIS05Qc0ZqRnhzcDJNNjhXMFFwbklsdDd2?= =?utf-8?B?N3FYRHVSYzNQdHBTZXAwcHhqZXY5LzQwQ2tmNFpzcEp1RFhsVlM3TEhnZ0pJ?= =?utf-8?B?NHRRckovYUZhSGE0UUxBZlZRSnllbEl2VEdzcGx3eWYwamZnL2dBb2FWenl5?= =?utf-8?B?U0F4R1RJRmxXcmZTRUROWWVRbEJFVThhWHpQelZQZFdQd0xlQzd5dmwraVVt?= =?utf-8?B?QnR1dmhnQmhjaUJpM2ZTeDJQenVVekErWjM0TTA0QTBpZW1QMWNEN2tmcXhm?= =?utf-8?B?aHlRemVFT2xSNEVHVGthMSswbVBybWFvN1FxTTlZS1NCYnZFdWFOU0czd29p?= =?utf-8?B?MzB1OS9uMUQwdC9KdklzdkVyczJiRFhwNGxWdFc2NS9KZUhsa2xEcnlVa1RI?= =?utf-8?B?TjdFTjVrWUdBZm8zditNNUkrakhXUU9IS2ZpTU1hSHQzOG1NNU4vMnZDcXJ6?= =?utf-8?B?Smo3Qm5NR2ZySlFFbkI1dUZrMmlNQktaWXdjRWJOZmVVdk1UOXd5akZHMnFN?= =?utf-8?B?a0hLV0twckZRZFFBSXdGd040TXFHM0V0VzVQOUJrckdsVi9NMUI2aEtUTGt6?= =?utf-8?B?dHBIYjBiSS9LRXdDQitkemtPdHRDdWo2bk93eXczS2FQcWNVWElySUtLL3d1?= =?utf-8?B?SCt4Q21CbG50OEdISEE0MVpOMlJGaHRqbDdBZU40dmYrMk1UTi9hNWJuVUR3?= =?utf-8?B?SzFqaGd4WlN2c2tCTVdwT2tEVm1zTjlzY2VRTmVoL0ZNb0xzV1hKY3VqVEhD?= =?utf-8?B?bzVyMWlqekZjVmc0NUx5SGNNN0ZEdEh4Lzd5Q0RlUGNmaG5uc09HaUoxanF5?= =?utf-8?B?K3pLdEtMZnhHNzc0SWhkZS9SR3ZyNzNOdm9KWVVRYzRrRVJkcE1SM0ZUajJO?= =?utf-8?B?a2xiaFlCZVhmcUgrcTdWbW8zSS8xNDZ4T282OU5USEZxU0xPb0tTL2pHRkRX?= =?utf-8?Q?swa8WNaQxwtAGk3wzqUvV5EfD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb43b384-ffa6-4ae1-03a9-08dac235d193 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 09:36:03.2724 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PCN0s+xjVUF5MnAqZyNYw6cci0iK5KYDckYU9PJkmT0SE+XCC2PPe5qlOEdeTdf/HhRDaxuNfLIi0JjXqW5mjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8855 On 09.11.2022 10:21, Edwin Torok wrote: > > >> On 9 Nov 2022, at 07:10, Jan Beulich wrote: >> >> On 09.11.2022 03:47, Henry Wang wrote: >>>> -----Original Message----- >>>> From: Edwin Török >>>> Subject: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build >>>> error >>>> >>>> Building with Dune in release mode fails with: >>>> ``` >>>> File "ocaml/xenstored/store.ml", line 464, characters 13-32: >>>> Warning 18: this type-based record disambiguation is not principal. >>>> File "ocaml/xenstored/store.ml", line 1: >>>> Error: Some fatal warnings were triggered (1 occurrences) >>>> ``` >>>> >>>> This is a warning to help keep the code futureproof, quoting from its >>>> documentation: >>>>> Check information path during type-checking, to make sure that all types >>>> are >>>>> derived in a principal way. When using labelled arguments and/or >>>> polymorphic >>>>> methods, this flag is required to ensure future versions of the compiler will >>>>> be able to infer types correctly, even if internal algorithms change. All >>>>> programs accepted in -principal mode are also accepted in the default >>>> mode with >>>>> equivalent types, but different binary signatures, and this may slow down >>>> type >>>>> checking; yet it is a good idea to use it once before publishing source code. >>>> >>>> Fixes: db471408edd46 "tools/ocaml/xenstored: Fix quota bypass on domain >>>> shutdown" >>> >>> Nit: The format of this "Fixes:" tag might need to be fixed? >>> >>>> >>>> Signed-off-by: Edwin Török >>>> --- >>>> Reason for inclusion in 4.17: >>>> - fixes a build error in a previous commit that is already in master >>> >>> Yes, given this is a simple enough patch: >>> >>> Release-acked-by: Henry Wang >> >> Afaics this patch was previously posted in isolation, and it was >> already release-acked. What's lacking there is a 2nd maintainer's >> ack or a proper R-b. When it now is patch 9 in a series, it isn't >> really obvious whether this could also be committed in isolation >> (it looks like it does, but a clear statement to this effect >> would have been beneficial). >> > > > You're right it already has both acks, it just hasn't been commited yet: Oh, that's only because I overlooked Christian's ack. Will commit this now. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 09 09:45:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 09:45:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440768.694933 (Exim 4.92) (envelope-from ) id 1osheU-0004Mz-CG; Wed, 09 Nov 2022 09:45:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440768.694933; Wed, 09 Nov 2022 09:45:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osheU-0004Ms-9U; Wed, 09 Nov 2022 09:45:46 +0000 Received: by outflank-mailman (input) for mailman id 440768; Wed, 09 Nov 2022 09:45:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osheS-0004Mm-KM for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 09:45:44 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 45e0c006-6013-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 10:45:42 +0100 (CET) Received: from mail-co1nam11lp2173.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 04:45:39 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by DM4PR03MB6096.namprd03.prod.outlook.com (2603:10b6:5:397::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 09:45:36 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 09:45:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45e0c006-6013-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667987142; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=uxuk2aMjE1vhe8d9094QAw9rM5DpkWAwyl3vhl/gFVc=; b=OokqMDJjIq1nfluta+wnfgWRBesq0aCjII5GvStcYbnH5Tbr9xQJctwp PHuQdyaGuKXvccxkZKBvTUT1j62LZqvrG69lkKCiyCQMsBj+zET0g+uRm mGDIkCAiDgHM/wHjRM7B1HvzDbGYayUrK0ZLCipnHiaOVXWtPQ9UFy2MF s=; X-IronPort-RemoteIP: 104.47.56.173 X-IronPort-MID: 84054601 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:0qv/KqvqWp1g/Wh/5vkgyOoia+fnVGtfMUV32f8akzHdYApBsoF/q tZmKW7UO6uLNDCjKdp/PN/g/U8BupDTmNJjGlNs+ys9RCsU+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaGxiFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwcg83fCrZp/mNzrP4Q8lPt8k7dOblM9ZK0p1g5Wmx4fcOZ7nmGvyPzvgBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjv60b4G9lt+iHK25mm6Vq nzH+SLlBQsdN/SUyCaf82LqjejK9c/+cNJOTODkqKYz6LGV7mstVwUVTGeWncaaulTvUthRL 2Ix0BN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yyaUAHIVCAFIbtMOvdUzAzct0 zehgNfBFTFp9rqPRhq15rqS6D+/JyURBWsDfjMfCxsI5cH5p4M+hQ6JScxseJNZlfXwEDD0h juN9S43guxKidZRjvrgu1fanziru57FCBYv4RnaVX6k6QU/Y5O5Y4uv6h7Q6vMowJulc2Rtd UMsw6C2hN3ix7nX/MBRaI3hxI2U2ss= IronPort-HdrOrdr: A9a23:rLqHV6tB73rNEauzEn0BJNCO7skC1YMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIP/Z4StU z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfpWG0hYczAgNkGmpDr1L8Yqq iJn/7mBbU115rlRBD2nfIq4Xin7N9h0Q669bbSuwqfnSWwfkNHNyMGv/MWTvKR0TtfgPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5TOObFuF4O5gLZvi3+9Kq1wah7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm10xR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XXJ0vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLmzNV1wg2XwqUmGLEfQI5tllulEU5XHNcrWGDzGTkwymM29pPhaCtHHWp +ISeBrP8M= X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208";a="84054601" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kcsEP4MXi9bJOk1owLMpefX9LXOHNXh83HQsVxAt3JZDurJ2ISAgrVMFBQdHuJE2FoIj9r05qayW2zMoEBt/ukpxXnBy1AJ/euqgMMU+gl4LEmBEQdF5MtjPcuFx3vsC0PgsT2ekbfNdWdDCK5BGGE2E3AlxchDNbokAtf/HfRCWvUWGzuDpsAtwXbAyX7sUtdd9w4YbcJG24Cy9RbvN0+p9POZ5c4D6310S0G8EcQdi8vWdPPrSiw6kIq6mXQp+bR05h63qKaQslOSstnxb361KZ3ohKb8zq9aEHoHiUJ1/7bIOp20sjs/HXZu2HS/3Vu3tVw+gRHyLgVPz7slnlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uxuk2aMjE1vhe8d9094QAw9rM5DpkWAwyl3vhl/gFVc=; b=ZbnEsfke8gf3xhwFwOeMJ73wgO2P1YOA+EKiRTC7KA2k0m7MG1c2iqmhgxgpjFHcikvdA38rwsMq5emXxgU+4BVqRCgIrJlcBBMqIK1UNdmgaW5o7w/kZ53pR/XX0V7FmcAo/EYbXUf/+lASdFZ6Z2XQbtDoBQ/rko9FyJd82jusU9yQ02PnLL1klElCPKN+n1eQzMpGFYplqSkwlABBJINTtYefftEPJf9EaAG1FXNIs55iRjyvAMZJU+xRcAJRXNpgg7JthX5UYYg2q/MJQFJ0M409k2qyYTOitO3rBfzmSrg/NGzEQ6NR7kHPpNIh8acUOsTWmcfW6NXewhOK8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uxuk2aMjE1vhe8d9094QAw9rM5DpkWAwyl3vhl/gFVc=; b=sohPVksVmavCCQKcdS1sMmwsohxy2lgn9Xp86Xk4aSqEvx24XZiN3qmyck5ydB9LJMDv6shkb8sZqSLEWbhW4JODIPyFfpyVg8A1kWyLTFoKYA4AO62mKJvvyunkGz2cJ3h91ZB2CrPa3bV3wWq6ztJOX6sylpqoaZTBEE0U1V4= From: Edwin Torok To: Jan Beulich CC: Roger Pau Monne , "Henry.Wang@arm.com" , Andrew Cooper , George Dunlap , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Thread-Topic: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Thread-Index: AQHY82a4odYEEDJCoUOUarTvbCvSoq41M5sAgAAIFoCAAAWrAIAAA0GAgADz+gCAACCXgA== Date: Wed, 9 Nov 2022 09:45:35 +0000 Message-ID: <66BC7155-FDCC-4095-9F4B-278ECF2DE7CF@citrix.com> References: <20221108113850.61619-1-roger.pau@citrix.com> <58d5e890-e052-47df-42bb-6cc84aedd4a9@suse.com> <76cde159-088a-3351-56e2-0cf14e9c8116@suse.com> In-Reply-To: <76cde159-088a-3351-56e2-0cf14e9c8116@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|DM4PR03MB6096:EE_ x-ms-office365-filtering-correlation-id: bd0f747e-4533-43be-d1dd-08dac23726f4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z1VShXrFumsZZdVroSzrptfXgm0TkFvql/2SkblKxGe1vCy/xrSj9X/GhlhATlvirdkoEXLmz8KuQlSjtF90JF0I04UcV7JTr7yct3Vd/cypWz0P4bSlJRp6sBKO7PUb52sRsZ9ZWH2VWXB/GoyH9XrJqrB3eYKlJMGBPFTSVCM5wRLPCo05OZQDSEr2XCTuTx3zM7CfsqCp4y8lr+3pWJwLTEpn4bmoidHWQtqjwBzm4Kecg/vYNZqGMAy1rliWPG6e+MeVhn9LDJVD6h3JqwI5O+yins/aYNwzT5z/pMZhG3ChnzLQKAHD49K51soA+UA/NzuScoR8/ttlrMXeOpeZngqZBVIBegHQdJ4jrxDVMq8ll/OgRe4vN7lTU3EMAouvEBVL5YUhJO31XjEFHr7LO88H8XyMo2bAWWMQzb02FN3gassmWIic5/jF5SB4waORfjgrSPqvt4w9D+rbogPgrw/AXsW1nAU1Ly7juICWqm5wL88YQ2/L2K/QKLzs6ST2vP0kTFyB9JLxG9Brx4JBejqOIsiC0FCXcPuYdxdaNH8UZp/3igeOmMLQFmhx7qIpbvRZqGKFoDvl2SlxaKwm8+NPljNHnDQ0PHhwgD4W5T2gf+T4x34NtbViLbAbG1wLxk3bzEoYfMCUVbKs9OmtlE4ZlRPlyQtQ0bR1ZAurM7/ijzzjSPfGx67ecrr7lEM0bA6IYcO4bXnQYmDzrZQiemH25SWQFiUnnw/XrLbbh0UCjYMJwocCWhEnhyDQ0mwtVoUVxJNZXfVQLbwokHZLrq1XRGzhxTVymwI05oU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(346002)(396003)(136003)(376002)(451199015)(64756008)(8676002)(33656002)(186003)(6506007)(5660300002)(66556008)(76116006)(4326008)(66946007)(26005)(36756003)(91956017)(6512007)(6916009)(2616005)(316002)(53546011)(8936002)(66476007)(41300700001)(54906003)(66446008)(122000001)(83380400001)(38100700002)(38070700005)(82960400001)(2906002)(86362001)(478600001)(71200400001)(6486002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SFJKa040TDNxakhQT2d2aWFneVE3MFlKL3FROFRJUy8vV2Z0eDNpdXBsYnBk?= =?utf-8?B?VjRJaUdpc1BueHg5MDBud0xiYk1acDdpanJ5bEpDT216QnlYZENZQlBpZVlv?= =?utf-8?B?UFJBSVozVjZNTjN5VVBXUnl0M1hkMGdPeUJucmxlQ2QwM2kvZ21RbHB0ckwx?= =?utf-8?B?Z2Y3WkM4cjJwZjZ4MnQzOHBjSVBHRk5QcTFlamdkTmFQRklrQjhTRUpTSjZO?= =?utf-8?B?Tm51TXBCaDM1cnFoNDg2QUxHM1FSL2UrVGpLSDJMcVYzVnNQUFJVT2dKNEhi?= =?utf-8?B?ZFZmU0JpZmU2Zkx1NDNzeEZMdkk0VVNUN05mWU16UmpDZ3Jld2hocmZDeEM3?= =?utf-8?B?c1hTUVR3N1poVHJRd0ZjVlpOQUROQUh5NUVQWVh6MUxEYVNWSTRhaFB6NGRa?= =?utf-8?B?WEJWMzllbnRkd3pIZjRQWG9HSW5hU3pKcjBjdkM1aTVmR2NEMlliZFdyS1o1?= =?utf-8?B?emdhN1N5QnNObzNvUGpyMnozMTNMU0cxckJwQnVWaElBOE0wcGJWT1hVU054?= =?utf-8?B?QnNzeExzYXdjejAyUzdBYndia09USmVjYlVyb2NhNmQwUGlsY2V4QXI4cDYr?= =?utf-8?B?aTdvRTFFd1E4eHpvSFZBVVhrdmxkS0R4U09XL0ZUSGlUbW1KTkNzeDVYVHND?= =?utf-8?B?WnZiUFhiT3lSSkpkb0d4K2pDN3M5SnNDb0xtOC8zWlJOMHZjR2lhb2F6MmlC?= =?utf-8?B?M3ZENnNieUFXVGRNa2JnNWU1bDVXdWVXZ1lvMWJFTnovUWYrWWVmelJ4YWJG?= =?utf-8?B?QjNjYWNFRDBZZzVpaGttbWZXdzlUVUE1NnkwZnc3cnZYMEczaERsZkYzajBQ?= =?utf-8?B?SkVQQXo1c2dGVDhubTBrQ0h0VlBuMklwenVldElKOEorM3lOR1dsQ0NvKzhM?= =?utf-8?B?dmo3UUptNlcreVo4aFFrNlFrZ1Y3bHh2NjRRV3NvL3FyZ000a1dpZ2I3RDJ2?= =?utf-8?B?MWVEVlpWMWhWOUN3V0VXQUI2c21SK1ZRdFlydmtTUGNjS1hXS2tkb2NMNkxt?= =?utf-8?B?YkFWWXlUS3JidG5GWmswUFg0ZS9yQUpUNHZkQUUwc0t3TjJqN3BIU2dnek5Z?= =?utf-8?B?Q0NHQTNHekM1YlNvbTBiNmV6WTRaVWs0UHVuc1FEZzVCMC8vZW9sTEt1QWNl?= =?utf-8?B?UUhTNnpnamZxK21jMFJGQS9DbXVDTitoSzJMbkQvVStiWnVNckcrVDVxVXRV?= =?utf-8?B?a010UnA0WmlPV21aWUc5bWNwMTBsc2NzdlpNbU9WNXNaOUF0eitIRktQbnRj?= =?utf-8?B?Tm54bnpmWlUxTGJCdUUzVmU5MWlaaVVqRk1JM2JubC9hY2loanF6K3FkMWR1?= =?utf-8?B?cXpyMFdPZXAzbUxETjhZQ1BtVkVTWTJ0cHhWNXoyMlh3RlVyQWZEOEFhUzRH?= =?utf-8?B?YjNnY3hXL0x2U3pQZmZOTFpCM1EyS0dJa1AxRWp6VTcvS2RPZTYrVmFWYlNC?= =?utf-8?B?V0N5OHhFRVloZ3MzeXUzZk15ZFhCYmJhcGV4UXgvYUxVTHdHV1QxT0VTNUlO?= =?utf-8?B?dkhtRTZ1K0RGRWlwUmVQVHBVd1BjdHFLQlJUYTBaTnRYdHUvTEQ5SEFXSFFZ?= =?utf-8?B?eVdTbEpYTlVhdFU0aURhTG0xbGlBYkRib0NML3dLTjY3THVKZE1aSDlxWm5B?= =?utf-8?B?ZllTZk1zcnRWNUxwUTcwaGhnYVJ3MklXWkxxZTNBSXhDYzh1UGlDMVhEeDRa?= =?utf-8?B?QmRjbWZubExWS2R3eEJPNlpIeWtFTUpRNlZ0VnVMTXlkK2p5QzdHb204eHdX?= =?utf-8?B?Q2kvVmtrWEptUUxNNjZmQThxK1NNU0svR1JMQm11L1lzdU91dE52Q29wSEFI?= =?utf-8?B?eFZYRTZ3bWdkeExia1REY1dkSG43VVJLVEtyWUZ2L1JBSGZSSFRPbG1saUo2?= =?utf-8?B?ZXNHOXh3eExqVGp4VXdwTzg4MXI5TElxN1ZnSVZYVlVNM203YzIyY2xzd3Zk?= =?utf-8?B?dXVTYjRYMENncFlyUW5zWHpET0d3V013NTAyaWgrbGVVSFlOY3NlZytmQzYr?= =?utf-8?B?dGNKTUZRc1VFTFl1eEhMVFA5TXBsRFh1cUNqT1pnb3Q2N2JjcHAxdEZ1L2JZ?= =?utf-8?B?UG9RaU1DaGtKUDZkL0VvL3d1Qi8wQW8yTWxLc3JBSFVWbkhkMjhCelYrVzhi?= =?utf-8?B?UjdvV2FoSmxjazJmdUc3aFBwNDZCTFEzV2hxZm5iZ050VTJqTlgyeFd1K3NF?= =?utf-8?B?TWc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd0f747e-4533-43be-d1dd-08dac23726f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 09:45:35.8447 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pp17KVbwmomMYCVip/pZnHdjt0AkvVdT6wLVi3zA49Z/L2vVFDJgYnCzttZaoDDJlDOH5/djRjNfkTnEirL3jw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6096 DQoNCj4gT24gOSBOb3YgMjAyMiwgYXQgMDc6NDgsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwOC4xMS4yMDIyIDE4OjE1LCBSb2dlciBQYXUgTW9ubsOp IHdyb3RlOg0KPj4gT24gVHVlLCBOb3YgMDgsIDIwMjIgYXQgMDY6MDM6NTRQTSArMDEwMCwgSmFu IEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDguMTEuMjAyMiAxNzo0MywgUm9nZXIgUGF1IE1vbm7D qSB3cm90ZToNCj4+Pj4gT24gVHVlLCBOb3YgMDgsIDIwMjIgYXQgMDU6MTQ6NDBQTSArMDEwMCwg SmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+PiBPbiAwOC4xMS4yMDIyIDEyOjM4LCBSb2dlciBQYXUg TW9ubmUgd3JvdGU6DQo+Pj4+Pj4gTGlrZSBvbiB0aGUgQXJtIHNpZGUsIHJldHVybiAtRUlOVkFM IHdoZW4gYXR0ZW1wdGluZyB0byBkbyBhIHAybQ0KPj4+Pj4+IG9wZXJhdGlvbiBvbiBkeWluZyBk b21haW5zLg0KPj4+Pj4+IA0KPj4+Pj4+IFRoZSBjdXJyZW50IGxvZ2ljIHJldHVybnMgMCBhbmQg bGVhdmVzIHRoZSBkb21jdGwgcGFyYW1ldGVyDQo+Pj4+Pj4gdW5pbml0aWFsaXplZCBmb3IgYW55 IHBhcmFtZXRlciBmZXRjaGluZyBvcGVyYXRpb25zIChsaWtlIHRoZQ0KPj4+Pj4+IEdFVF9BTExP Q0FUSU9OIG9wZXJhdGlvbiksIHdoaWNoIGlzIG5vdCBoZWxwZnVsIGZyb20gYSB0b29sc3RhY2sg cG9pbnQNCj4+Pj4+PiBvZiB2aWV3LCBiZWNhdXNlIHRoZXJlJ3Mgbm8gaW5kaWNhdGlvbiB0aGF0 IHRoZSBkYXRhIGhhc24ndCBiZWVuDQo+Pj4+Pj4gZmV0Y2hlZC4NCj4+Pj4+IA0KPj4+Pj4gV2hp bGUgSSBjYW4gc2VlIGhvdyB0aGUgcHJlc2VudCBiZWhhdmlvciBpcyBwcm9ibGVtYXRpYyB3aGVu IGl0IGNvbWVzDQo+Pj4+PiB0byBjb25zdW1pbmcgc3VwcG9zZWRseSByZXR1cm5lZCBkYXRhLCAu Li4NCj4+Pj4+IA0KPj4+Pj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9wYWdpbmcuYw0KPj4+Pj4+ ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wYWdpbmcuYw0KPj4+Pj4+IEBAIC02OTQsOSArNjk0LDEw IEBAIGludCBwYWdpbmdfZG9tY3RsKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCB4ZW5fZG9tY3Rs X3NoYWRvd19vcCAqc2MsDQo+Pj4+Pj4gDQo+Pj4+Pj4gICAgIGlmICggdW5saWtlbHkoZC0+aXNf ZHlpbmcpICkNCj4+Pj4+PiAgICAgew0KPj4+Pj4+IC0gICAgICAgIGdkcHJpbnRrKFhFTkxPR19J TkZPLCAiSWdub3JpbmcgcGFnaW5nIG9wIG9uIGR5aW5nIGRvbWFpbiAldVxuIiwNCj4+Pj4+PiAr ICAgICAgICBnZHByaW50ayhYRU5MT0dfSU5GTywNCj4+Pj4+PiArICAgICAgICAgICAgICAgICAi VHJpZWQgdG8gZG8gYSBwYWdpbmcgZG9tY3RsIG9wIG9uIGR5aW5nIGRvbWFpbiAldVxuIiwNCj4+ Pj4+PiAgICAgICAgICAgICAgICAgIGQtPmRvbWFpbl9pZCk7DQo+Pj4+Pj4gLSAgICAgICAgcmV0 dXJuIDA7DQo+Pj4+Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+Pj4+Pj4gICAgIH0NCj4+ Pj4+IA0KPj4+Pj4gLi4uIGdvaW5nIGZyb20gInN1Y2Nlc3MiIHRvICJmYWlsdXJlIiBoZXJlIGhh cyBhIG1lYW5pbmdmdWwgcmlzayBvZg0KPj4+Pj4gcmVncmVzc2luZyBjYWxsZXJzLiBJdCBpcyBt eSB1bmRlcnN0YW5kaW5nIHRoYXQgaXQgd2FzIGRlbGliZXJhdGUgdG8NCj4+Pj4+IG1pbWljIHN1 Y2Nlc3MgaW4gdGhpcyBjYXNlICh3aXRob3V0IG1lYW5pbmcgdG8gYXNzaWduICJnb29kIiBvciAi YmFkIg0KPj4+Pj4gdG8gdGhhdCBkZWNpc2lvbikuDQo+Pj4+IA0KPj4+PiBJIHdvdWxkIGFzc3Vt ZSB0aGF0IHdhcyB0aGUgb3JpZ2luYWwgaW50ZW50aW9uLCB5ZXMsIGFsYmVpdCB0aGUgY29tbWl0 DQo+Pj4+IG1lc3NhZ2UgZG9lc24ndCBnbyBpbnRvIGRldGFpbHMgYWJvdXQgd2h5IG1pbWlja2lu ZyBzdWNjZXNzIGlzDQo+Pj4+IHJlcXVpcmVkLCBpdCdzIHZlcnkgd2VsbCBwb3NzaWJsZSB0aGUg Y29kZSByZWx5aW5nIG9uIHRoaXMgd2FzIHhlbmQuDQo+Pj4gDQo+Pj4gUXVpdGUgcG9zc2libGUs IGJ1dCB5b3UgbmV2ZXIga25vdyB3aG8gZWxzZSBoYXMgY2xvbmVkIGNvZGUgZnJvbSB0aGVyZS4N Cj4+PiANCj4+Pj4+IENhbiB5b3UgaW5zdGVhZCBmaWxsIHRoZSBkYXRhIHRvIGJlIHJldHVybmVk IGluDQo+Pj4+PiBzb21lIHNpbXBsZSBlbm91Z2ggd2F5PyBJIGFzc3VtZSBhIG1lcmUgbWVtc2V0 KCkgaXNuJ3QgZ29pbmcgdG8gYmUNCj4+Pj4+IGdvb2QgZW5vdWdoLCB0aG91Z2ggKGFsYmVpdCBw dWJsaWMvZG9tY3RsLmggZG9lc24ndCBleHBsaWNpdGx5IG5hbWUNCj4+Pj4+IGFueSBpbnB1dC1v bmx5IGZpZWxkcywgc28gaXQgbWF5IG5vdCBiZSBuZWNlc3NhcnkgdG8gcHJlc2VydmUNCj4+Pj4+ IGFueXRoaW5nKS4gTWF5YmUgemVyb2luZyAtPm1iIGFuZCAtPnN0YXRzIHdvdWxkIGRvPw0KPj4+ PiANCj4+Pj4gSG0sIGl0IHN0aWxsIGZlZWxzIGtpbmQgb2Ygd3JvbmcuICBXZSBkbyByZXR1cm4g ZXJyb3JzIGVsc2V3aGVyZSBmb3INCj4+Pj4gb3BlcmF0aW9ucyBhdHRlbXB0ZWQgYWdhaW5zdCBk eWluZyBkb21haW5zLCBhbmQgdGhhdCBzZWVtcyBhbGwgZmluZSwNCj4+Pj4gbm90IHN1cmUgd2h5 IHBhZ2luZyBvcGVyYXRpb25zIG5lZWQgdG8gYmUgZGlmZmVyZW50IGluIHRoaXMgcmVnYXJkLg0K Pj4+PiBBcm0gZG9lcyBhbHNvIHJldHVybiAtRUlOVkFMIGluIHRoYXQgY2FzZS4NCj4+Pj4gDQo+ Pj4+IFNvIHdoYXQgYWJvdXQgcG9zdHBvbmluZyB0aGlzIGNoYW5nZSB0byA0LjE4IGluIG9yZGVy IHRvIGF2b2lkDQo+Pj4+IHN1cnByaXNlcywgYnV0IHRoZW4gdGFraW5nIGl0IGluIGl0cyBjdXJy ZW50IGZvcm0gYXQgdGhlIHN0YXJ0IG9mIHRoZQ0KPj4+PiBkZXZlbG9wbWVudCB3aW5kb3csIGFz IHRvIGhhdmUgdGltZSB0byBkZXRlY3QgYW55IGlzc3Vlcz8NCj4+PiANCj4+PiBNYXliZSwgYnV0 IHRvIGJlIGhvbmVzdCBJJ20gbm90IGNvbnZpbmNlZC4gQXJtIGNhbid0IHJlYWxseSBiZSB0YWtl bg0KPj4+IGZvciBjb21wYXJpc29uLCBzaW5jZSB0aGUgb3AgaXMgcHJldHR5IG5ldyB0aGVyZSBp aXJjLg0KPj4gDQo+PiBJbmRlZWQsIGJ1dCB0aGUgdG9vbHMgY29kZSBwYXRocyBhcmUgbGlrZWx5 IHNoYXJlZCBiZXR3ZWVuIHg4NiBhbmQNCj4+IEFybSwgYXMgdGhlIGh5cGVyY2FsbHMgYXJlIHRo ZSBzYW1lLg0KPiANCj4gT24geDg2IHdlIGhhdmUgYm90aCB4Y19zaGFkb3dfY29udHJvbCgpIGFu ZCAoZnVuY3Rpb25hbCkNCj4geGNfbG9nZGlydHlfY29udHJvbCgpOyBvbiBBcm0gb25seSB0aGUg Zm9ybWVyIGlzIHVzZWQsIHdoaWxlIHRoZSBsYXR0ZXINCj4gd291bGQgYWxzbyBiZSBpbXBhY3Rl ZCBieSB5b3VyIGNoYW5nZS4gUGx1cyB5b3UncmUgbm90IGFjY291bnRpbmcgZm9yDQo+IGV4dGVy bmFsIHRvb2wgc3RhY2tzIChsaWtlIHhlbmQgd291bGQgYmUgaWYgYW55b25lIGhhZCBjYXJlZCB0 byBmb3J3YXJkDQo+IHBvcnQgaXQsIHdoZW4gLSBhcyB5b3Ugc2FpZCBlYXJsaWVyIC0gdGhlIHN1 c3BpY2lvbiBpcyB0aGF0IHRoZSBvcmlnaW5hbA0KPiBjaGFuZ2Ugd2FzIG1hZGUgdG8gInBsZWFz ZSIgeGVuZCkuDQoNCkkgZG9uJ3Qgc2VlIGhvdyByZXR1cm5pbmcgcmFuZG9tIHVuaW5pdGlhbGlz ZWQgZGF0YSAoY3VycmVudCBiZWhhdmlvdXIpIG9yIHdyb25nIGRhdGEgKGFsbCB6ZXJvZXMpIGlz IGJldHRlciB0aGFuIHJldHVybmluZyBhbiBleHBsaWNpdCBlcnJvciBjb2RlLg0KDQpUb29sc3Rh Y2tzIChlLmcuIFhBUEkpIG9ubHkgc2VlbWluZ2x5ICJ3b3JrIiB3aXRoIHRoZSBjdXJyZW50IGJl aGF2aW91ciwgaW4gdGhhdCBpdCBpcyB0cnlpbmcgdG8gZGV0ZWN0IGludmFsaWQgZGF0YSBiZWlu ZyByZXR1cm5lZCwNCmFuZCB0aGUgY2hhbmNlcyBvZiB0aGUgaW52YWxpZCBkYXRhIGJlaW5nID4x MDAwIGlzIG1vcmUgbGlrZWx5IHRoYW4gaXQgYmVpbmcgPDEwMDAsIHNvICJtb3N0IG9mIHRoZSB0 aW1lIiB0aGUgdG9vbHN0YWNrIGhhcHBlbnMgdG8gd29yay4NCg0KVGhlcmUgd2FzIGEgY29tbWVu dCBpbiB0aGUgY29kZSB0aGF0IHRoZSBidWcgbWlnaHQgYmUgaW4gdGhlIGJpbmRpbmcsIGJ1dCB0 aGUgYmluZGluZyBpdHNlbGYgc2VlbXMgZmluZSAod2VsbCB0aGF0IG9uZSBhdCBsZWFzdCwgdGhl cmUgbWlnaHQgYmUgbWVtb3J5IGNvcnJ1cHRpb24gaW4gb3RoZXIgYmluZGluZ3MNCndoaWNoIGlz IHByb2JhYmx5IHdoYXQgdGhlIGNvbW1lbnQgd2FzIGhpbnRpbmcgYXQuLi4pLCB3aGljaCBpcyBw cm9iYWJseSB3aHkgdGhlIG9yaWdpbmFsIGludmVzdGlnYXRpb24gb2YgdGhpcyBidWcgc3RvcHBl ZCBhbmQgd29ya2VkIGFyb3VuZCB0aGUgcHJvYmxlbSB0b29sc3RhY2sNCnNpZGUgaW5zdGVhZCBv ZiBkaWdnaW5nIGludG8gdGhlIGh5cGVydmlzb3IgdG8gZmluZCB0aGUgcmVhbCBidWcsIGl0IHBy b2JhYmx5IHRydXN0ZWQgdGhlIGh5cGVydmlzb3IgYmVpbmcgY29ycmVjdCB0b28gbXVjaC4NCg0K RXhjZXB0IHdoZW4gdGhlIHJhbmRvbSBkYXRhIGlzIGJldHdlZW4gMSBhbmQgMTAwMCwgaW4gd2hp Y2ggY2FzZSBpdCBhY2NlcHRzIHRoYXQgdmFsdWUgYXMgcGxhdXNpYmxlIGFuZCB0aGluZ3MgYnJl YWssIA0KYnV0IG5vdCBpbiBhIHdheSBpbiB3aGljaCB5b3UgY2FuIHJlcHJvZHVjZSAoeW91IG5l ZWQgdG8gcmVydW4gbWFueSB0aW1lcyB1bnRpbCB0aGUgdmFsdWUgb24gdGhlIHN0YWNrIGhhcHBl bnMgdG8gYmUgaW4gdGhpcyByYW5nZSkuDQoNCkFuZCBmb3IgdGhlIGxhdHRlciB0aGUgdG9vbHN0 YWNrIG5lZWRzIHRvIGJlIGNoYW5nZWQgYW55d2F5IHRvIGRldGVjdCAwIGFzIGEgYmFkIHZhbHVl IChpLmUuIHNhbWUgYXMgYW4gZXhjZXB0aW9uKSwgYW5kIGl0IGFscmVhZHkgaGFzIGNvZGUNCnRv IGRldGVjdCBleGNlcHRpb25zIGZyb20gdGhlc2UgZG9tY3Rscy4NCg0KRXZlbiBpZiBzdWNoIGEg Y2hhbmdlIHdhcyBtYWRlIHRvICJwbGVhc2UgeGVuZCIgaXQgaXMgdmVyeSBsaWtlbHkganVzdCBo aWRpbmcgdGhlIGJhZC91bmluaXRpYWxpemVkIGJlaGF2aW91ciB0aGUgc2FtZSB3YXkgWEFQSSBk b2VzLA0KaXQgZG9lc24ndCBuZWNlc3NhcmlseSBtZWFuIGl0IHdvcmtlZCByZWxpYWJseS4NCg0K QW5kIGV2ZW4gdGhpcyBjaGFuZ2UgaGFwcGVucyB0byBicmVhayBzb21lIGNvZGUsIGl0J2QgZG8g c28gd2l0aCBhIGNsZWFyIGVycm9yIGNvZGUgYW5kIGluIGEgcmVwcm9kdWNpYmxlIHdheSwgYW5k IHRoZW4gc3VjaCBicmVha2FnZSBjYW4gYmUgZWFzaWx5IGZpeGVkIGluIHRoZSBhZmZlY3RlZCBw aWVjZSBvZiBjb2RlDQooZS5nLiBhIHRvb2xzdGFjayBvdGhlciB0aGFuIFhBUEkgd2hpY2ggd2Fz IG5vdCBsb29raW5nIGZvciBlcnJvcnMgZnJvbSB0aGlzIGRvbWN0bCBjYWxsKQ0KVXNpbmcgYW4g ZXJyb3IgY29kZSBvdGhlciB0aGFuIEVJTlZBTCBhcyB5b3Ugc3VnZ2VzdCBtaWdodCBldmVuIG1h a2UgZmluZGluZyB0aG9zZSBwcm9ibGVtcyBtb3JlIG9idmlvdXMuDQoNCkFGQUlDVCBYRU5fRE9N Q1RMX1NIQURPV19PUF9HRVRfQUxMT0NBVElPTiBpcyBvbmx5IHVzZWQgaW4gdGhlIE9DYW1sIEMg c3R1YnMgKGkuZS4gdXNlZCBYQVBJL3hlbm9wc2QpIHdoaWNoIGFsd2F5cyBjaGVja3MgcmV0dXJu IHZhbHVlDQphbmQgcmFpc2VzIE9DYW1sIGV4Y2VwdGlvbiBhbmQgaW4gcHl0aG9uIGxvd2xldmVs IGxpYnMsIHdoaWNoIGNoZWNrcyByZXR1cm4gdmFsdWUgYW5kIHJhaXNlcyBweXRob24gZXhjZXB0 aW9uLg0KDQo+IA0KPj4gVGhpcyBpcyBhIGRvbWN0bCBpbnRlcmZhY2UsIHNvIHdlIGFyZSBmaW5l IHRvIGRvIHN1Y2ggY2hhbmdlcy4NCj4gDQo+IFdlJ3JlIGZpbmUgdG8gbWFrZSBjaGFuZ2VzIHRv IGRvbWN0bCB3aGljaCBhcmUgZWl0aGVyIGJpbmFyeSBjb21wYXRpYmxlDQo+IHdpdGggZWFybGll ciB2ZXJzaW9ucyBvciB3aGljaCBhcmUgYXNzb2NpYXRlZCB3aXRoIGEgYnVtcCBvZiB0aGUNCj4g aW50ZXJmYWNlIHZlcnNpb24uIFRoZSBsYXR0ZXIgd291bGRuJ3QgaGVscCBpbiB0aGlzIGNhc2Us IHdoaWxlIHRoZQ0KPiBmb3JtZXIgaXMgc2ltcGx5IG5vdCB0cnVlIGhlcmUuIEZvciBBbmRyZXcn cyBwcm9wb3NlZCBuZXcgcGFnaW5nIHBvb2wNCj4gaW50ZXJmYWNlIHRoZSBiZWhhdmlvciBzdWdn ZXN0ZWQgaGVyZSB3b3VsZCBvZiBjb3Vyc2UgYmUgZnVsbHkNCj4gYXBwcm9wcmlhdGUsIGRlbWFu ZGluZyB0aGF0IHRvb2wgc3RhY2sgZWl0aGVyIGRvbid0IGlzc3VlIHN1Y2ggcmVxdWVzdHMNCj4g YWdhaW5zdCBkeWluZyBkb21haW5zIG9yIHRoYXQgdGhleSBiZSBwcmVwYXJlZCB0byBnZXQgYmFj ayBlcnJvcnMuDQo+IA0KPiBUaGlua2luZyBhYm91dCBpdCBhZ2FpbiBJJ20gYWxzbyBub3QgY29u dmluY2VkIEVJTlZBTCBpcyBhbiBhcHByb3ByaWF0ZQ0KPiBlcnJvciBjb2RlIHRvIHVzZSBoZXJl LiBUaGUgb3BlcmF0aW9uIGlzbid0IG5lY2Vzc2FyaWx5IGludmFsaWQ7IHdlDQo+IG9ubHkgcHJl ZmVyIHRvIG5vdCBjYXJyeSBvdXQgYW55IHN1Y2ggYW55bW9yZS4gRU9QTk9UU1VQUCwgRVBFUk0s IG9yDQo+IEVBQ0NFUyB3b3VsZCBhbGwgc2VlbSBtb3JlIGFwcHJvcHJpYXRlLiBPciwgZm9yIGVh c2Ugb2YgcmVjb2duaXRpb24sIGENCj4gcmFyZWx5IHVzZWQgb25lLCBlLmcuIEVOT0RBVEEsIEVJ TFNFUSwgb3IgRVJPRlMuDQoNCkVST0ZTIG9uIGEgcmVhZC1vbmx5IHF1ZXJ5IChPUF9HRVRfQUxM T0NBVElPTikgd291bGQgc2VlbSB3cm9uZy4NClNpbWlsYXJseSBFUEVSTS9FQUNDRVMgd2hlbiB5 b3UncmUgRG9tMCB3b3VsZCBtYWtlIHNvbWVvbmUgdHJ5aW5nIHRvIGRpZyBpbiB0aGUgd3Jvbmcg cGxhY2UuDQoNCk90aGVyIHBsYWNlcyBpbiB0aGUgY29kZSBhbHNvIG1heSByZXR1cm4gRUlOVkFM LEVTUkNILCBFQlVTWSwgYnV0IG5vdCBzdXJlIGhvdyBtYW55IG9mIHRob3NlIG1heSByZWFjaCB1 c2Vyc3BhY2UsDQpFU1JDSCB3b3VsZCBzZWVtIGFwcHJvcHJpYXRlLg0KRU9QTk9UU1VQLEVOT0RB VEEgbWlnaHQgYmUgb2sgdG9vLg0KDQo+IA0KPiBGaW5hbGx5IEknbSBub3QgY29udmluY2VkIG9m IHRoZSB1c2VmdWxuZXNzIG9mIHRoaXMgZHlpbmcgY2hlY2sgaW4gdGhlDQo+IGZpcnN0IHBsYWNl OiBpc19keWluZyBtYXkgYmVjb21lIHNldCBpbW1lZGlhdGVseSBhZnRlciB0aGUgY2hlY2sgd2Fz DQo+IGRvbmUuDQoNCg0KSW5kZWVkLCB0aGVyZSBpcyBhbiBpbmhlcmVudCByYWNlIGNvbmRpdGlv biBoZXJlICh3aGljaCBpcyB3aHkgdGhlIHRvb2xzdGFjayBjYW4ndCBtYWtlIHRoaXMgY2hlY2sg cHJpb3IgdG8gY2FsbGluZyB0aGUgZG9tY3RsKQ0KVGhlcmUgYXJlIG90aGVyIHBsYWNlcyBpbiB0 aGUgY29kZSB3aGVyZSB0aGVyZSBpcyBhIEJVR19PTiBvbiAhaXNfZHlpbmcsIGFyZSB0aGV5IHBy b3RlY3RlZCBieSBsb2NrcywNCm9yIGRvIHRoZXkgaGF2ZSBhIHJhY2UgY29uZGl0aW9uIHdoZXJl IGEgZHlpbmcgZG9tYWluIGNhbiB0cmlnZ2VyIGl0Pw0KDQpCZXN0IHJlZ2FyZHMsDQotLUVkd2lu DQoNCj4gDQo+IEphbg0KPiANCj4+IEkNCj4+IHVuZGVyc3RhbmQgdGhhdCB3ZSB3YW50IHRvIGF2 b2lkIHN1Y2ggaW50ZXJmYWNlIGNoYW5nZXMgYXMgbXVjaCBhcw0KPj4gcG9zc2libGUsIGJ1dCBJ IHRoaW5rIHdlIG5lZWQgdG8gZml4IHRoZSBoeXBlcmNhbGwgdG8gcmV0dXJuIGVycm9yDQo+PiBj b2RlcyByYXRoZXIgdGhhbiBpbXBsZW1lbnRpbmcgd29ya2Fyb3VuZHMgdG8gdHJ5IHRvIGNvcGUg d2l0aCBhIHdyb25nDQo+PiBpbnRlcmZhY2UgYmVoYXZpb3IgaW4gdGhlIGZpcnN0IHBsYWNlLiAg T3IgZWxzZSB3ZSBjb3VsZCBiZQ0KPj4gYWNjdW11bGF0aW9uIHdvcmthcm91bmRzIGhlcmUgaW4g b3JkZXIgdG8gZm9vbCBjYWxsZXIgaW50byB0aGlua2luZw0KPj4gdGhlIGh5cGVyY2FsbCBoYXMg c29tZWhvdyBzdWNjZWVkLCBhbmQgcHJvdmlkZSBraW5kIG9mIHN1aXRhYmxlDQo+PiBsb29raW5n IGRhdGEgZm9yIHRoZSBvdXRwdXQgcGFyYW1ldGVycy4NCj4gDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 09 09:49:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 09:49:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440774.694944 (Exim 4.92) (envelope-from ) id 1oshhj-00050m-1Q; Wed, 09 Nov 2022 09:49:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440774.694944; Wed, 09 Nov 2022 09:49:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshhi-00050f-Su; Wed, 09 Nov 2022 09:49:06 +0000 Received: by outflank-mailman (input) for mailman id 440774; Wed, 09 Nov 2022 09:49:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshhi-00050X-Bd for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 09:49:06 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be1c11bd-6013-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 10:49:04 +0100 (CET) Received: from mail-mw2nam04lp2174.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 04:48:50 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by CO1PR03MB5842.namprd03.prod.outlook.com (2603:10b6:303:91::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 09:48:48 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 09:48:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be1c11bd-6013-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667987344; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=bOxXToXWwbp92YVZPk3fKz3PonQxvuiq2f6LNxKjvF4=; b=DNcMgiwp7zWZ5lCDJOpCic8oaisOQBRsGnxFib1ZmjsRoKDq6V6JTpig Xgzed9Uaw/2fWEVjR7Ijdh4QgmWnDd3nY5Yt9/wk7m+GM5FDANaZUNHxJ NFjYYaYQuFoAWNafkVqb5EtPJxEQxGzAmm69tFbmbrlEEDnfkY1cCfnQv E=; X-IronPort-RemoteIP: 104.47.73.174 X-IronPort-MID: 84477279 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jVstfqwoaxXgEEYJfZR6t+f0xyrEfRIJ4+MujC+fZmUNrF6WrkUOz 2EeWGuBbqyKazSgeNF2Pork/ENTv5+AydVrTwU9/CAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPaET5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWVE0 uExNwInUiKCqb2x+LGrTO58pMt2eaEHPKtH0p1h5RfwKK56BLX8GeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDOVlVMtuFTuGIO9ltiiSMlLn0Deu mXc+GfRCRAGLt2PjzGC9xpAg8efwX+kB9hNRdVU8NYxgkGtzGYsJScbUEqdh/y3yR6uC9Bmf hl8Fi0G6PJaGFaQZvnwWQep5kGNuBE0UsBVVeY97WmlyLfQ4gufLngJSHhGctNOnN87Q3km2 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgcqaSYaQCMf7tLkoYV1iQjAJv58FIalg9uzHiv/q w1mtwA7jrQXyMsUjaOy+Aibhyr2/8eVCAko+g/QQ2SpqBtjY5KobJCp7l6d6utcKIGeTR+Ku 31sd9Wi0d3ixKqlzESlKNjh1pn3jxpZGFUwWWJSIqQ= IronPort-HdrOrdr: A9a23:LDMrw6o4S9avBJ4U0dRtZzEaV5uIL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcItKLzOWwldAS7sSobcKogeQUREWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZa6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInJy6IZn1V KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0aVjcVaKv6/VQIO0aSSAWUR4Z 3xStAbToNOAkbqDyOISN3Wqk/dOXgVmibfIBSj8AbeSITCNU4H4ox69Mxkm1LimjQdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZ+w2a/pgVFZ9l/1pwKpuKuZ3IAvqrIQ8VO V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkcoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWuKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFEhVsGYjEnieffFmHKc7hywlbF/NLggFkPsulqSRkoeMNIbDIGmEVE0kldemrrEWHtDbMs zDSq5rPw== X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208";a="84477279" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GPAkXIeini8EQ7xBBj/tVQrL/70x+afWcl9o0o6JebHMl9dWDc9fCBzLwlIbn7SnY7nIfKwdyc+8AbCI0ckI5Tv+ydAZ30zhAh4J58jSMCOxwJfYKty8mnj+moMxJ1POUCwjvsagyR0o93LGxs+28XVjXSwwTr0nnmiLGCl+NHXHo91+PKarGpPwAuR3++fu2vcy7dBCMRbwAw6E7n9B6LN4SpmcJFwuFmMEHS5iPmH10vJEMnNGj+XP9/lYh1e2IgUJoz9iVvPqfJ9zgxXI3zI/FRd40U72ysl+dy0HQopGK2M++pAX/iYAaFj5MHakw9o1KAmXUMJfxBwv7B5vIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bOxXToXWwbp92YVZPk3fKz3PonQxvuiq2f6LNxKjvF4=; b=IY6plBxGDqDqd4Ke9TcL8k8/p8O8A8I102XaYJi4J3TTGnsqZynS5hzlDwStA4cVrs1zi3MDDMizy+1qSRDg9ohM4hIWpTAsvg5v43GFNIWS5JkfXgZxmM8PWEV8GDkGOXf2e3iTOo3ZYWcYHSSkZ5GzGJL+lpGKKtXr0fqREpirEo6VFWoYbFKfc2hhyNHRABbYEtUqL75VIOWSiOTh5Q3O9NaM/j2tTtVwRM5A3fTSyukdtE4KtLsO9jUz0WzQpbXykrPZWTCyy04DkDCrOVuEx/f/aZPkfz2BsES2pdQrYCcRX153ZF/Zivgn5Gt8Fkl0fX4gXM29lvmQ3QCMrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bOxXToXWwbp92YVZPk3fKz3PonQxvuiq2f6LNxKjvF4=; b=e9ak1bpybhgXnPXvDrx7FCNr8tp6sNHYE2b/Jmx88KMizuf8KQB5fe6WI2Olwe/AbUQ1CbiHqRanRet7u9LAkYG0qiL1rwiPpqe7ZYpHH5bO80jK+5ghz0uKUyyix3mpstlXLeRT+BIwkYDp15cMJQ5dtkP0sIyp9xlu7z/kzfE= From: Edwin Torok To: Henry Wang CC: Julien Grall , Xen-devel , Christian Lindig , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Index: AQHY84fA+Ym2JRve3kKJcIO1APAKeK41MEgAgAAQaICAAAaygIAAAw6AgACiiYCAAGzVgA== Date: Wed, 9 Nov 2022 09:48:48 +0000 Message-ID: <8C5A0430-A754-4D1A-9E82-DBC751849478@citrix.com> References: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> <1f8c90cd-8037-84eb-d6f7-c639f8a87585@xen.org> <7BD7C0AF-0D72-4125-BE97-8AD5FC15CA93@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|CO1PR03MB5842:EE_ x-ms-office365-filtering-correlation-id: 9008e39e-9c3b-4c8c-e8bf-08dac23799b9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6g5r0WbPSivFqeFUS55BVyRUyQp+mmgC7Hty5cZ9uhKKQRpL/HMy0ayAH9kQ7FvWKRpWuVhh080rk1EfzOq+lVO2jCDZN5vSgYAqBAmy4mnd/RToKyOkEGZDDAPwGMytaNJLQyPae1mG77DFacs9/lZauv8+C0yR+9k8ZynaQYWX9sclG7zegRzk0VM7jOoq3Q4U2SIvFGjHBELlm2jaIkpJxMAWNcbF+nn3ME5vGweSbMVOcOlCSBvFw/J38OWNDsHraoSRQ0et938YDK34bz1T7KtFN//iBv+PekENtBw5++1FxfnNM+71ZZ/6oQ4XVZNx+7hCz17G4+tO/O01lf7Gk012RfhFlo6WOZ4lRfkebGNQim8I65w4pHIyf9EDzY+2bfXJpSptV/TNnr2MUXpkX5SPF3G0I/P4v7pNwS7FuayFV7EBNVRyFYw+ggdR9ifXYQ470B16XGDRJ29ALP7ksfpUBSnFnUIrXZburi8S2KpD+gYXiPilYMPU57k/DIJ6LOEAyFvRMkzDKTNWSkOR2QJg3bz/CFbATdCbxna/TfIBr5B6VZsP0WOKOmTPvVRU/y1H3lb3dpaKLUg6sDZHaD78fOEFwqHFW4LTN6pvSPiesdx0XHMTObHUb56XIcTwo4QUNcnsT8VGL5jBX7b3xhZfZniVShmGR62BQFoyH8DlRR/fZMerWQim5aJcrNTyUISUA+QmdISiomSVG2C9PXBhv8u3KjpN2PnNxuDUfrG3x6zAAK+HlL4KB66FU7tB46Ga1UkbVUMaPwkXF4sxqqV58dwIyacn35D7OVu4DJgv59pyAqAC/qsBX/Wss8nMPYm9lqSwLO33HqTP5FosUGlXWY22BLqzpoUVAL5f7reDfaNED4oJDuupQoPn x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199015)(966005)(6486002)(71200400001)(478600001)(6916009)(38070700005)(45080400002)(54906003)(107886003)(6506007)(316002)(4326008)(8676002)(33656002)(66446008)(66476007)(64756008)(82960400001)(66946007)(53546011)(91956017)(66556008)(76116006)(26005)(122000001)(38100700002)(6512007)(86362001)(8936002)(2616005)(186003)(36756003)(5660300002)(83380400001)(41300700001)(2906002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BY5JYbtlx2M+obLCjzslGa0xbnjIWiOQYPxpEiORi3yHavIB3hZ6+MIsQ1E1?= =?us-ascii?Q?Aixf6iwd6T5ECySV3ZSvAC9aLEXjdKYOGB5ougsidfhN1HN5T2yOem32G0aX?= =?us-ascii?Q?NRn9UiuxDa7SQpNpya3n6peFu8S4BXSuZoOMfTbnuh1I0CPSWkgU9XiDOvPQ?= =?us-ascii?Q?SHR57jDzt7xFCiYOF05Qe5qaHHzu+ecyBflNign+qk7zYjxLBjE+NWxp/bcq?= =?us-ascii?Q?QyMjmlpMZ9TDwhFMW7qKN2x8TuLLkrD0BWTVsHsr+t7g5yxmSWdP3KAa6tKA?= =?us-ascii?Q?WhT66EduixfYBvGTmtRoPkdXS521JUVIgRv+54AsZDN8ZxTIx8KiYtAiN4sa?= =?us-ascii?Q?khunbIbjL9Js3f1AqnVbLeCA+gChcyIScskSy/m+nYYHNtSXv9WDIOdL2drV?= =?us-ascii?Q?prWEtFWvsPUtjuDggQuLiV/I7nahakv+0UWAISTAldBRzUfQUe2gd9a8viY2?= =?us-ascii?Q?BUiLf5WMET6yZL955LWHPdjl3TCzpPBBh+648vIWQgP/XHvd/l8QCg4vLgmr?= =?us-ascii?Q?i8ql/AOco7s9qOPCLobDpKTLG35TQ46UCiCfDbhUG+hXEeA4ArHmRkCG5jBU?= =?us-ascii?Q?hf+bkckae3btcnt2QqDxX2vjczOj/bc7PBJ5tynYMourARZiiLoZk53sK4II?= =?us-ascii?Q?OF7QpkJlPUc8HOH1oAFXrJ5XSsLVdc5Vsh1o9NnsNqBLSZ5IpZmS0vHpUlC0?= =?us-ascii?Q?2TdM+eL2J7i8BwMRripSQtKVF9BnjVGIBK7gwXPuGFGVDYbWOmaSmcbDAhGm?= =?us-ascii?Q?zA8OmfpzbqRNLvMlfGflw2+i5KbVRdQRLHt/9GLmV/uOOIEYN5y5LD4LCboG?= =?us-ascii?Q?3SVnM0YoPiE9OAlAN5/jRliGDoSt03V3Rl5DCv4UQxCxFC6VURI0IswdoXLx?= =?us-ascii?Q?vGFZhbKgZIEHqK646R+hqm5KgjvHx3eCCTHhMxWiebbeFlux2rUm5rZVLNLo?= =?us-ascii?Q?cfXrkpBMWFxfvNnFIRAX5xSlHegAyWEYlzbGDpGK2Qnepb6iZUyRHg5jkKzf?= =?us-ascii?Q?/r1nul6y4M3A0wE8z+eCcUEDM7Y2p4xuZEVtXKtIgwqIngXxeMjGJFUBM9VD?= =?us-ascii?Q?WteaKUvVkuKIRW11DrA/IiSIJ1jyujXHRl/7zVj2UYDWC6MCOMion67MJGXj?= =?us-ascii?Q?lHd8kZgFnkB3nKwEB4zHTNV8bDSwDzR8IsyAvCKdNYeUv01vEnvCg/Bnzgb6?= =?us-ascii?Q?CzmRyJiPnNU87Xx8UlL8to2vezFhdxdAL0g5M5VKXabc8nSzLZlClrtL5G+E?= =?us-ascii?Q?sYpS99LLsQn5+hxiFS69YJlVnh5uuU2ZpRTAYn6E9R+3bhEE8gvnpj9VaS99?= =?us-ascii?Q?YO1vM6KEtFwOcaukhktEc8LkaYc2qQATlR7Mb6sHP6HaHR2oVuOEltPZ38sJ?= =?us-ascii?Q?8zmLeE9t+vz3Ai8hZWvooyXXk1dVP1UeqlXD3WbMp4HN4ZkqqhbwYxHFVe5H?= =?us-ascii?Q?uIiPm/4a7P++CCWSZAl6QraAIf2uF4a2fMyoRrq9+9ruX5CRwSy3LGVamza6?= =?us-ascii?Q?mUDO/suQr1fewj4VWHbdL1mNpXs/qeXTw8vUJdwS+J6EIeeE/zfNYYhoT4/C?= =?us-ascii?Q?9SFskO22Wzus+yLPfdWsa+vLvSjaWnogPMOdUjZy+5UbUUj4QxxBLZ6S3w/6?= =?us-ascii?Q?LQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9008e39e-9c3b-4c8c-e8bf-08dac23799b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 09:48:48.3809 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ku8PG079QUffxVHcnaMQHMjQGM3htAP08wjeQ4IhpnYLl2l0gUIw+D+8Aa1C+666uDyOFoZyc28nEeAu+onvJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5842 > On 9 Nov 2022, at 03:19, Henry Wang wrote: >=20 > Hi Edwin, >=20 >> -----Original Message----- >>> [1] >> AS8PR08MB7991145C8063D6939AFFED8F92829@AS8PR08MB7991.eurprd08 >> .prod.outlook.com >>=20 >>=20 >> Hmm I thought that is my Outlook rewriting the link, but the archive at >> lore.kernel.org seems to have this mangled URL as well which I cannot op= en. >> Could you send it in such a way that it is not encoded when being sent (= e.g. >> base64 encode it...) >=20 > Appending "https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A= %2F%2Flore.kernel.org%2Fxen-devel%2F&data=3D05%7C01%7Cedvin.torok%40cit= rix.com%7C1c7455639df84f970eab08dac2012fce%7C335836de42ef43a2b145348c2ee9ca= 5b%7C0%7C0%7C638035607613905983%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDA= iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata= =3Dl0oQ0815ndwWt4buGasPYYmVV3FdnrC%2F4wKrIoLqki8%3D&reserved=3D0" befor= e the link from Julien > works for me. But I think the link is just the release schedule :) Thanks, this link works indeed (it is an Outlook message ID after all, not = one of Outlook's link rewrites): https://lore.kernel.org/xen-devel/AS8PR08MB7991145C8063D6939AFFED8F92829@AS= 8PR08MB7991.eurprd08.prod.outlook.com/ Best regards, --Edwin= From xen-devel-bounces@lists.xenproject.org Wed Nov 09 09:53:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 09:53:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440780.694955 (Exim 4.92) (envelope-from ) id 1oshlI-0006QR-FK; Wed, 09 Nov 2022 09:52:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440780.694955; Wed, 09 Nov 2022 09:52:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshlI-0006QK-CR; Wed, 09 Nov 2022 09:52:48 +0000 Received: by outflank-mailman (input) for mailman id 440780; Wed, 09 Nov 2022 09:52:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshlG-0006QC-PR for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 09:52:46 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2059.outbound.protection.outlook.com [40.107.21.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4267830e-6014-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 10:52:45 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9118.eurprd04.prod.outlook.com (2603:10a6:150:25::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Wed, 9 Nov 2022 09:52:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 09:52:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4267830e-6014-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mIIamHjsUkeoi4K4u9Q3ihUbxwYER6L6IEGIi+ML2QJw1mqN4GB/DGqU6Qf6D36ncPDN+CYO3K7UlSx7AFBwJY+2+zIee2QQ9z4NPoiKfaFnS1HmDiUI6Ri57gzxz3WQSB5F25DbtY6C8T9zfuSO+4Je7R7+dm5eSgq9K3H52dHg7nCR/Wf+Wnikeu8o/7kuDc8WAHlbXV7HHpFBFLrIlci7sumrkRrBmuFmu2+wbMowv4rfnteAzI4QQkNWJ254D2PFRCJ4ulMjEDO0V4ZF6q6CPBIEt23DhhUWnEjbFoTwf4Bcbx3i+1iBB/2/ylRlQkojdZg2Ma+mK5kuSthdYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dygYo2ft2YbfUZF/MLaTeCHoCxPkX1HxZtZsxFYVt88=; b=R30zbTRgoz5H57yz4kjNFQ9AEE5WwZy4vWaY1r2iGEAM+K41kQq9zTpp9pQU9aQhA0Vr3XhFzB6R0PxV1s5jn2F88MYhgjJ+51Tu/p8Am9/Gy5X04aRqVX5TzkkTeD+TfGWqVu755WolzjBkRDsOhqvwCSeugjUpKcmhE9sPETeY64+vZvDV0cmMnrLK0jjvAZ7Yr1VkpalavxlBp7JHqmZlQBms5cy9coKAI+5aJCBtntuz/1vAjSkYTHy+Dtd7exo7OyNGGL7Da+UnULmfApgNXFrV7ozWM4V6PoUgpWEEZtf89FeebtB6GKMRMX9NJR6iE0Rl8lF6+zb10AymfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dygYo2ft2YbfUZF/MLaTeCHoCxPkX1HxZtZsxFYVt88=; b=knb82Yj71TX8dsy9WglLYiAfCtwi3j3F4MqyYecu1CY4GsdIDzuQMr9/wi/SFtVw9b3MQeJUYE1lsWJxLApNEAioHYDde1wUVM+s26uBNP8QiJ85IUF/M3Yt5446DhsT63YJQ9MrMq2P44kNogXeBrxMeodXTH++AEq7I/J+57FwNthwwBq7+po55pk7FI7QgDJI2pHg/Tj0xEBjAtBivD6KJbkHOmVtEKllp27O/9JajZLvh1UB840baFtA2DpueEnXCCYbGADHPALdHkYBVU27DasMXdMN/9hGPLSQGHaWxyshcUfXEtKgDdK/Yxq11tIGkCxAPNsAIhlY6zgKpA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2d734f9a-0b50-8164-3fce-3efaca6d7b61@suse.com> Date: Wed, 9 Nov 2022 10:52:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error Content-Language: en-US From: Jan Beulich To: Edwin Torok Cc: Henry Wang , Christian Lindig , David Scott , Wei Liu , Anthony Perard , "xen-devel@lists.xenproject.org" References: <09afc07ba0ba65afc02028bd6b4950d8e51af69b.1667920496.git.edvin.torok@citrix.com> <1e994604-7a3f-ef5f-63f4-d03e4abe4124@suse.com> <09c03186-bdfc-d931-33bb-e589b074726e@suse.com> In-Reply-To: <09c03186-bdfc-d931-33bb-e589b074726e@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0123.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9118:EE_ X-MS-Office365-Filtering-Correlation-Id: e2d9fcb1-b706-4d99-9262-08dac238248c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fKgo9DSbXc06ziwgqk9kwHMrhCgP3Obn6G6VfRndMDRedfuxtOFnPoe9+tAU4l3xKSJLiI6rM5C99jlQFnFK5MHmOHyJKMnUNlZJPD9LLBqJYjMfyFWyDz19W+JIyWdb8eR4bwBXhsD+b6pOIsAYAOW6hqbB3MH6Ge3JwX93m8/bf5j+5LUQRYjvus4QUw7d6OwYkqmX4Nga1Iw2OuUJs4GZo2Yq8UOHUWWRcG49PrYJ7taEtuBcYxpeTDiOVkw958i4M2IfdZbX6ogUb2oBBdmU7LvPtYRmrUoRGjiI3d9H2gUQpZC259ILBOxfQWWTaijgZ46Z8o4JwlzPf0rayfAYl/e/xIUlNncGYYGtGZVfTxrd26uL5m/8+MrpHiyuYAO9dyaIQJY8TJtWMxBip84uGOCgNat2rpW/45K18MYl/E25JFeB9hXYiXMSxKHqgpbPrqTtpl5QezJj+Dzb/o/jngJpLFzQxfFj8158NlHLx5PVuaKk8wMflpyLuUIsOww7REyMfn6T3NEVFiJduvBs2/SAQpkK1mhzQtlsAIWiZRF59wcaBRZjkUnhOEAlHL27rSldwprGPY4l5nQDDTTB0ttbF8YezAgALsoQtxOnvpk+nOJikE4w7oaOXDUdk8KiKxotN+mjKcxFaFqRuOFIArdma32vppLQNa+KcptAsDSZL4uXEUiUPW7OcdwCATbyAJyAWBH7qa+HPEl+mVbLsDTHoYwWWkRLYeKKDsd2QLzEFpU+UVx4rbBO7VU0a+pqkGKDMDroGd2JdsrLuREYhpVaBADBMZ/tt6EyUQo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(39860400002)(366004)(346002)(396003)(451199015)(86362001)(31696002)(36756003)(38100700002)(5660300002)(6486002)(83380400001)(2906002)(53546011)(6506007)(66574015)(6512007)(26005)(186003)(2616005)(31686004)(66476007)(316002)(66946007)(8936002)(8676002)(54906003)(478600001)(66556008)(4326008)(6916009)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3lwZGhtMkJsZkt0M2tMQko4Z0NtUGpucVNOMmxoRTY2N0lkMUNpdFh6SmNp?= =?utf-8?B?SUU2SXEyVzczWXpVK2xNM05LU0pTNlFzKzVKUS9uQk9vaWtGb0FtaTVCV1BO?= =?utf-8?B?NExFMm5oYmRDZXd3TnpaZ2w2ZXNSMEhVbjFkSzlhMG15UDdwWG5YR2hEd3ZY?= =?utf-8?B?VzdESXUwUlR6UjU2Q1l0UExiVGxQWC9zMkd1YVE4dDBrY3hxeU5neUdPaWky?= =?utf-8?B?eHpNQkhuY3ZJdnBiOU0xOUpsSUNzUlZhTXNpdDNXdE9CUi9SOFlIS0FQalA5?= =?utf-8?B?QUlnekxTOTVpQkxCQTc3OXM3V2F4UFFaM2xGLzN0cnBuMkl3WXRtaVdOTmdm?= =?utf-8?B?OXowRXlabUJpMm9KWXErR0hWWkVOcXdEbUkrVWtETVUyTDJrblNQYmJpWTFN?= =?utf-8?B?aE9yOUF6cDNPN01PTkdVaVFpazJDQnBkbzN0Rmt4Q0syUlFiZUUwbkdTWURy?= =?utf-8?B?WTlyRkw0c3liZStLdjNmL0RQWTYyLzE3M2VIWk10cm9XaDYwdDdzRTUzRVNp?= =?utf-8?B?UFRIZXhYc1FTZ095TDR6WUFQa2lTOVdOb2lpUER2cjgrY1JtKzZzb1gyRVM1?= =?utf-8?B?ZEJNV1lFRE11MU5UL091V2dBTW5UTXFtM2RvZXpUNEpIZExEUng1WEpzNWNL?= =?utf-8?B?VTIxZ29uMUxFdHI3VWdNNy93THVLYk9nLzVDZ2pCU2RpQjhTQTBZekNHVjVp?= =?utf-8?B?TkV0R2JjakxCcnF0cUc1Q3JVTVl3VnQxZWFlK29FajRaQnN6OGpSdXl0dXA2?= =?utf-8?B?V01DalBHVUdUWGdLS2JvbnBoVUFPZFNlUzJZRHp3OGtqRUlURWhqejdmOEpM?= =?utf-8?B?bFh5V1NNYW81Vk1PRjE4VjhhWUQ2N3hka3B0Y05FeGZzQ25TS3h2UFNGa2Ux?= =?utf-8?B?MXJiYkkzU0N1RDNBSUtvNlhZUG5vVkdDcDVqL3dRdVlkZVVCK1NDNWdkSUlj?= =?utf-8?B?ekE0UExSZ0dVUmN6ZHVaTlQrSyswQ1k4R3dmd2xRb2h2OFcvTHUxNk5QU3Rs?= =?utf-8?B?dmM5dHIrUkluTkJvU3RQVlB4MlhudExnSjI2ei9lOG9Jbm82NU4rV2x5eS9a?= =?utf-8?B?WGYwRWNwY3FodkFyc2l6UE1aNDA3UW9ZeWMrcTFrdmdaNS9WWGtsTUgxUS9o?= =?utf-8?B?K0FIKzRuVjBkUWNiRTFlM2RrV2JGdWxOMFloSitZUXRaZmJrMW5SdFhFVThW?= =?utf-8?B?SHlDV1RFVkhsODg1bk4weXo1ZnFFSWFSbVVmNW5QNGdMZkJVMDVrbkhhSXoy?= =?utf-8?B?S2pBdGR6WkNaZkNMOHE3S1NjSXFONFQ1T2RVbFpaUEUyUkVNRURERE9veU1m?= =?utf-8?B?dUpueHRoaG1nSEpucXFFN3p5SkpMcTlFUW5DTFUxS09DL1VIdXhzTlE3VnRH?= =?utf-8?B?SERFRTg2Tm1PYjRJQXluUlYvSVV4OHV5NnBRMVNOTE9nYjlMSzd0Z2poNmZs?= =?utf-8?B?am8xaTlGMWNQQnpRblhURXpmd1ZFNUxvWGg3V1RoRXcxa2lZNm1GV0xlVVlU?= =?utf-8?B?cFQ0LzNTSjlHZ1piS3dzclVjSGkyYjRjcXJ3Yk5mOExGWGxiWmowVzFIdXdO?= =?utf-8?B?NzAzbDBxaU1Yb2c2bHFRWkt5SldqZ2hLQWxjUW9xS2p6cWtPMHd3Yks3dVRR?= =?utf-8?B?bk9OTzBlU3ZwWmtlSWFBV1dkUjEzeUpUcDRxSHZ3UFJTL1BVNXI3U05zcUEr?= =?utf-8?B?dUptY3FpTUZLOXJyZXROLyswblkzVy9XeFcwSEE4ZnlDR3A0TTJraDh6Vk00?= =?utf-8?B?N3pIWGc1ODBrbmhoemIrL0VrRStINExkLzJ4bDRIaFM0b0xyM2UzeEl5T3RD?= =?utf-8?B?bGM0L2xvVSs5bzBvZGdzZnRzTDVEV0llcFg3UlduMExIZ2taa3JVdXRKOXlq?= =?utf-8?B?WTBPeHpEMTBrdkI0L2NtdXVQQjk0VS8xa0JRV2dxYWE2UTUyUy9sazNXcEQz?= =?utf-8?B?Y0VJZVdmR2hnN25MUWpFZFFTVzNZeDd2WnlHcjdLTW9WZUxURGthdUdFZXFr?= =?utf-8?B?a2x4ME1iVlNBVXppM3ZBTXlwa3pyQW5TeGp3di9tSUp3RkVpeUMwZFFPK1k2?= =?utf-8?B?VWJ5d1hKN1FpVVNqTzRzemg2cXRrZXRoVUZZRG9oYUJOQkdGMjM4cVBHU1FG?= =?utf-8?Q?mhxM5izpSfb+6EcAkas5x2YKg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2d9fcb1-b706-4d99-9262-08dac238248c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 09:52:41.5058 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qdf5Mq5JXQps5irMYpDTgYundSBmyq7YZVIU8nfd8CzqOxI12c6QvAT3SxC/Jo2rvGudL5RnAHOAMWJrQ9yh1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9118 On 09.11.2022 10:36, Jan Beulich wrote: > On 09.11.2022 10:21, Edwin Torok wrote: >> >> >>> On 9 Nov 2022, at 07:10, Jan Beulich wrote: >>> >>> On 09.11.2022 03:47, Henry Wang wrote: >>>>> -----Original Message----- >>>>> From: Edwin Török >>>>> Subject: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build >>>>> error >>>>> >>>>> Building with Dune in release mode fails with: >>>>> ``` >>>>> File "ocaml/xenstored/store.ml", line 464, characters 13-32: >>>>> Warning 18: this type-based record disambiguation is not principal. >>>>> File "ocaml/xenstored/store.ml", line 1: >>>>> Error: Some fatal warnings were triggered (1 occurrences) >>>>> ``` >>>>> >>>>> This is a warning to help keep the code futureproof, quoting from its >>>>> documentation: >>>>>> Check information path during type-checking, to make sure that all types >>>>> are >>>>>> derived in a principal way. When using labelled arguments and/or >>>>> polymorphic >>>>>> methods, this flag is required to ensure future versions of the compiler will >>>>>> be able to infer types correctly, even if internal algorithms change. All >>>>>> programs accepted in -principal mode are also accepted in the default >>>>> mode with >>>>>> equivalent types, but different binary signatures, and this may slow down >>>>> type >>>>>> checking; yet it is a good idea to use it once before publishing source code. >>>>> >>>>> Fixes: db471408edd46 "tools/ocaml/xenstored: Fix quota bypass on domain >>>>> shutdown" >>>> >>>> Nit: The format of this "Fixes:" tag might need to be fixed? >>>> >>>>> >>>>> Signed-off-by: Edwin Török >>>>> --- >>>>> Reason for inclusion in 4.17: >>>>> - fixes a build error in a previous commit that is already in master >>>> >>>> Yes, given this is a simple enough patch: >>>> >>>> Release-acked-by: Henry Wang >>> >>> Afaics this patch was previously posted in isolation, and it was >>> already release-acked. What's lacking there is a 2nd maintainer's >>> ack or a proper R-b. When it now is patch 9 in a series, it isn't >>> really obvious whether this could also be committed in isolation >>> (it looks like it does, but a clear statement to this effect >>> would have been beneficial). >>> >> >> >> You're right it already has both acks, it just hasn't been commited yet: > > Oh, that's only because I overlooked Christian's ack. Will commit this now. But, sigh, I had to fix up the patch: Even the one submitted standalone used space indentation when the file in the tree uses hard tabs. And even if I had wanted to pull from your github tree I would have had to fix up at least the Fixes: tag. So I ended up hand-editing indentation ... Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 09 09:58:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 09:58:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440787.694966 (Exim 4.92) (envelope-from ) id 1oshqa-0007M4-4h; Wed, 09 Nov 2022 09:58:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440787.694966; Wed, 09 Nov 2022 09:58:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshqa-0007Lx-1B; Wed, 09 Nov 2022 09:58:16 +0000 Received: by outflank-mailman (input) for mailman id 440787; Wed, 09 Nov 2022 09:58:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshqY-0007Lq-Jq for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 09:58:14 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2070.outbound.protection.outlook.com [40.107.20.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e41db74a-6014-11ed-8fd2-01056ac49cbb; Wed, 09 Nov 2022 10:57:16 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7650.eurprd04.prod.outlook.com (2603:10a6:20b:281::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 9 Nov 2022 09:58:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 09:58:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e41db74a-6014-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fLfYGIdTNKwgRpN6o1fEyYCIRrN3McCYqbAvUlE/cz7X3ZjRwvT3s2XHBseKtfpgMMdBKQ+K4zAl3bneSEo8wawd3ijhiiUUOzNFscfgDKzw6lNcP8gmOWYp2ut7otpRHt1GYbqi2n+OJYihRwSHtSifnulaV//+XMTgjXLgmc7IsqEAhnlVeFh/oUWoZI/TbDN633Z8SWznWq7VwN6gHRfNomJRjsYwyNREe5Z/pKNipBpWA7XdqQ93mQWecrmOoFZTuyIeT5yy81mhS/MOrb+/BiEveN+rIMyZnRdanCagJlx2ISWr+FpFnsiCjOlZndV/WoYs4SgCxiaENGyNjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yzCST69uBHrwmMjnwqRwykHt4WvodA0N+auO43+NDAg=; b=k8gbVXEnigynhGz7LFUPLecJNoEX6F+5VszUErLXJu5aIwYrH5Zg6qSLzTPIkCp7MGb4rPVSQgd2CaLnwFu13w/KWs1nrtlfIcbeHB21NKZcOeK6k69LPhW2BlR8RuBoxWJeOerZWsiHaBdJrM8eF9hWofnZq2g/TaKsJLHW9gh7KvVCkovVsJd89JItTjFoOyKyqwVLOOJNr92TuxoQ/2rEj5DCsZRvZR2l1FI1bol78IKzbH0rn6Xwebot4qtfkbMHIdRxN6kf6g5ZQjUvz6D4w9Bj7UZ6zQa6GuPdrIsm3xbyk02pkPN5k2PRKNqF1XtjxCDdC9YvZdG2FJcq+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yzCST69uBHrwmMjnwqRwykHt4WvodA0N+auO43+NDAg=; b=Y/gbFKFB/KtTDwDJgwJkJxZTc1q2HKS9jSfa/DqDH5aAkJYybHM1TjIeaTgRnzRkfkKigCDymBLm5aQl0aboyynaU0yRYFfalMbnX0cqox+QpxFBMCnW25LuBQxXAp5S4Q+qa6s5ZB40823agaLOeaU632AMX8qEeHOTVe/uRGSuiB+ZKjd8Bf8IYfxLrTF5wNs4Pr/7u+gDEppLEnH4qxKME9gV8EXkE+P7GAKfjXveXvPMVrejr6f0ceJ6/MPWehFfdt1uzKl/OsQyGVwMhgMvky+mkr2kUmE8bNkGtyFUPY7PGt/1OxytrHbU+eXQ1hmf7BZoYWgFjquJdgn/MQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7c99778b-d1c4-d714-de61-dc6b7bea27f3@suse.com> Date: Wed, 9 Nov 2022 10:58:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Content-Language: en-US To: Edwin Torok Cc: Roger Pau Monne , "Henry.Wang@arm.com" , Andrew Cooper , George Dunlap , Wei Liu , "xen-devel@lists.xenproject.org" References: <20221108113850.61619-1-roger.pau@citrix.com> <58d5e890-e052-47df-42bb-6cc84aedd4a9@suse.com> <76cde159-088a-3351-56e2-0cf14e9c8116@suse.com> <66BC7155-FDCC-4095-9F4B-278ECF2DE7CF@citrix.com> From: Jan Beulich In-Reply-To: <66BC7155-FDCC-4095-9F4B-278ECF2DE7CF@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0137.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7650:EE_ X-MS-Office365-Filtering-Correlation-Id: bb5deba1-a3b6-45e6-f96e-08dac238e8fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: txxLyvVJL+bxqGM5P6tL2f/C2qhqKn3TQnwKkbt3Ywp8p48FXNk3VRWO5UZHM9UXcu/vtrhY19X1/eJQUKRw6meZhjVCmVYi2zcp2gFFrZ0ZgJpnBNY0AD3hf9uOy8VW/s5onUEj72CG7xmXZ7Q+K3LJTSrhYxPGKcoYGR7Qzvjdh/BwbV0sB7uHlpTz+cGgtG6IkCnFECQwp33MQb2Ktwo59auUlBfde7CGA3xbPgUo7DP+t30xRjrqeBf5JZnrwIodMSfWVnsLVFLsSNqX2agauJ0SxQmqlU7/3u523pKjHF9LjUbvwagNRahqNFLGSF2QuM1zRFGThnzPwquJmcbBhDunCdu8DC0IN5oh1nDGdBcHI4Nj8iW//CPeM2KtHOSbIBMLXAKm7aKmtlBwTCI45Fzm9+1hXCJrvApUwc5GTQueTeArd06ZZHGF2R/L2N21DC2FVCsQhDlEIXS7ym3yd8nyTEwZ2NwCXKa/r1TNyvzMjz4DQNc/ztqp/DuPvatGANYxBGpIOsefuJ1xZES9o01qkqCta9U03TVGcphx/HhPrxD5/b2jiS2hO0sV8GYoMGnrRq29j0tgbWG9S6R2wk3VUBbOVFLt9ZBDJ1z2lkB9CGkAVWzaqMj1GQj2PJEMC/vBy/bQ8dHj8DlYRWp0I4BD/5+NwqEB3LxhrSP7DQG+fEl0zW0P1Tpf+2kDR4OVcJckJuPqMtVy6nFJNcDA84zpsqPgTcz0qGRMm8xWEGfg5tNK3+Z9M6DHvjzp2IK+6WWFNPiWphtVQelrf/2p0pmvsvTorA7R2OPUQsw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(366004)(346002)(396003)(136003)(451199015)(31686004)(86362001)(26005)(41300700001)(6512007)(478600001)(38100700002)(6506007)(2906002)(36756003)(2616005)(186003)(8936002)(8676002)(5660300002)(4326008)(31696002)(54906003)(66476007)(6486002)(6916009)(316002)(66556008)(83380400001)(53546011)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXJiMDJpQXJDbjZucmhJcTNaWTNpWWY2Mm5lZllTSDl2NDJiV1hNNkE3STNx?= =?utf-8?B?cElsNm85OE1pT2tYQTFDNEMyVXUvTC9vZjgyaWpuVmtMWGV3MkNaT3Vub0NX?= =?utf-8?B?OEdlVW9FR1UvRkhCUnFDRFdYRjVDVG91bXRvVlQ3cnBkSVo5MnYrUG9DNlVG?= =?utf-8?B?V09XWVErRHl3MW1wYmJQeGdmR2l1OXFvdk51d2c5emRUV1RyV2ZhMCt2bFFn?= =?utf-8?B?Ylg3TXJBVlJtazJaNEtLeDk2KzZ5S29sc2hJRHZwcFRXMFQ2ZkxpZEdMdm9j?= =?utf-8?B?bU5EMFp5ejRDODJFNEFCRDNTcDVVemo4aWF1QTBhUkdEN2IvbVhYWnBxRHQz?= =?utf-8?B?K3ptVVovSzFabzNkRGJzSllQUmp4ZHNhWkpDdGRkb094WGZoRG9Belc4bjZz?= =?utf-8?B?YmRLOWx4U241ZGNsREtBemhkMGxwS3VITUFYZDNWM3BHMXZzSG1FMHowZ0JR?= =?utf-8?B?Y0NHQndGTVc1UjNZZjIxZG5uRVpLRzgyZXVhSG92ZkVGK24wQmorM0dGT01W?= =?utf-8?B?QWY0elQ5QUpoT29HUUtFWmU4THVMNFBuYmFqZGNJZ0xsdGhZUjhjc0NrbEpY?= =?utf-8?B?TEE3dHdWRTIrOGZaY05IWkI5Q1o3SmFBNnpOY2NzT0JxMVZJcGs2Z1BJelJD?= =?utf-8?B?UTJ2UnQ0dHozOW40c01MekkwK3pYbXlod0lTc28xMFF0UTlvSDFrY0xuZG5v?= =?utf-8?B?TzlMWldjOXNLK2dPeEFkQ3FUYVZwZ0VlWVlmYXgzOVA5QksySDgwSkxwM0U5?= =?utf-8?B?YTBwcHVaMk1kK0tOdG9KY0YvTk83WEYvbTVvdlFPL1VtWWxhMEx2Vis0S1JL?= =?utf-8?B?bytrNkJTbzNLR1lWenVKR3NqSUdLVlZZTERaakhyMkkrVExHUUhnNWlmN3pV?= =?utf-8?B?RG1sYUNOQlptUllmWUxWYmRsVGZOUmovNHUwcnFicDAzeEsyRHJBK21LeDU2?= =?utf-8?B?Qm9PWmJ0MDhDbXpQb0NuOHkrTnlYNmdIQXErRitISk90ZzNGQ1FZc0NNVW13?= =?utf-8?B?MU9wRUxNY1pWaTdOTnZEZXlGbG9YeG5TVFNHTnJtTm1Id3h5elQ0NVUvQkVQ?= =?utf-8?B?d3NGZDlKUjhTVlZkb0VxM1V5ajZrbkloUzc4cmkyS3NxWDVEZGErWFl1UmtD?= =?utf-8?B?dk9UVWo5V2I1UTNoNnJzUEphbVBmYnd4WXNyT3pKRjUySm9yUnFEcjJuSkZx?= =?utf-8?B?bDVRUHNOaExBaFk5WWQyMHZkSm1GbDBkdzlqSEV1QkZLY3oxWUFQeERHRkFU?= =?utf-8?B?Z2lialFMR0lEd2tueGRGZGlVeW81RGxNYUZxNDYxcE9JQisvQU9QemQySjZs?= =?utf-8?B?bDFrQTZvM3VDUURabjJweThpUU9Zb1M5Q3RpMUZqQ3hIRHo5c0VzbzNCWEs2?= =?utf-8?B?b0Y1eExId3Z0Q2RCM0Y2RVlibmNrRXF1R0JEQkR6WmpYTjJSVWVWZE9rNStw?= =?utf-8?B?SXBCYmFWaTZ2azVQL0NkeUk2UW5ONzRDT2pTSmVRTzR5R3VBR1hDVkFLdDNH?= =?utf-8?B?MXVLUGVjYXhoam1sZVpsc3hseDdIWGZxRUQvNk53QTd2T2pJM09DVFF2SHpm?= =?utf-8?B?R24xNCt5cVlIRjdRdjlPZHNhYzVXR1Nobm1iSW0zQlBUa3F2VVdCQktnaDFZ?= =?utf-8?B?citIL0RiNmRVUHZDMjUrMUV6ZnNrNnJPZ3p6Q0FmNVAzU2FSNlJuVkFqTU1I?= =?utf-8?B?c2NtcEphTzloQ2MxZFRCZGZrT3dxRGxhZksvejNaT3FoWUtrenl3emhDVGs4?= =?utf-8?B?c1JjU3k1VzhEZUM0STB2bDFZNzhReUU5MW9GZkcwTzd2VnMwbzYwTE1GNWZD?= =?utf-8?B?U1ZCbWlId3lRb2RGRlRLcWUwcHJPbjc3VGhlblVaSXJ6OFVDSUFpbXpBd082?= =?utf-8?B?SGVPWWl4UWVpS1ZsOVpjdTBQR2hJNXlNOTNxem9vMzd0MGtKMlNjblExVXZw?= =?utf-8?B?S0JqUlBRTTNsSmlwRDNCTEUvWjAzcndLa1ZSQ0x5cVR4MHpiemNvWkhjNGJ3?= =?utf-8?B?TUZORmV5M0trKzZSWFd1c1lPSno1bmV2RTJlVEZtOGJUVS9DWUpBNUZyVHI1?= =?utf-8?B?Mys2dzRJQWRlNUx1dVlGWEkyRWlWR3F3aGF6LzZoVlB2eDAzZFVVdDhDVDUw?= =?utf-8?Q?acxsnSVYI3k56qIuTJd3mCf11?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb5deba1-a3b6-45e6-f96e-08dac238e8fa X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 09:58:11.1252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cBWw4ttQohoLbvW1QqY1mG6zV4xVnkbubwNC67iri24ur2hX0K67HbV5wwEosTfcEQYuM2DEOUDiYxDZcWEVmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7650 On 09.11.2022 10:45, Edwin Torok wrote: >> On 9 Nov 2022, at 07:48, Jan Beulich wrote: >> On 08.11.2022 18:15, Roger Pau Monné wrote: >>> On Tue, Nov 08, 2022 at 06:03:54PM +0100, Jan Beulich wrote: >>>> On 08.11.2022 17:43, Roger Pau Monné wrote: >>>>> On Tue, Nov 08, 2022 at 05:14:40PM +0100, Jan Beulich wrote: >>>>>> On 08.11.2022 12:38, Roger Pau Monne wrote: >>>>>>> Like on the Arm side, return -EINVAL when attempting to do a p2m >>>>>>> operation on dying domains. >>>>>>> >>>>>>> The current logic returns 0 and leaves the domctl parameter >>>>>>> uninitialized for any parameter fetching operations (like the >>>>>>> GET_ALLOCATION operation), which is not helpful from a toolstack point >>>>>>> of view, because there's no indication that the data hasn't been >>>>>>> fetched. >>>>>> >>>>>> While I can see how the present behavior is problematic when it comes >>>>>> to consuming supposedly returned data, ... >>>>>> >>>>>>> --- a/xen/arch/x86/mm/paging.c >>>>>>> +++ b/xen/arch/x86/mm/paging.c >>>>>>> @@ -694,9 +694,10 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, >>>>>>> >>>>>>> if ( unlikely(d->is_dying) ) >>>>>>> { >>>>>>> - gdprintk(XENLOG_INFO, "Ignoring paging op on dying domain %u\n", >>>>>>> + gdprintk(XENLOG_INFO, >>>>>>> + "Tried to do a paging domctl op on dying domain %u\n", >>>>>>> d->domain_id); >>>>>>> - return 0; >>>>>>> + return -EINVAL; >>>>>>> } >>>>>> >>>>>> ... going from "success" to "failure" here has a meaningful risk of >>>>>> regressing callers. It is my understanding that it was deliberate to >>>>>> mimic success in this case (without meaning to assign "good" or "bad" >>>>>> to that decision). >>>>> >>>>> I would assume that was the original intention, yes, albeit the commit >>>>> message doesn't go into details about why mimicking success is >>>>> required, it's very well possible the code relying on this was xend. >>>> >>>> Quite possible, but you never know who else has cloned code from there. >>>> >>>>>> Can you instead fill the data to be returned in >>>>>> some simple enough way? I assume a mere memset() isn't going to be >>>>>> good enough, though (albeit public/domctl.h doesn't explicitly name >>>>>> any input-only fields, so it may not be necessary to preserve >>>>>> anything). Maybe zeroing ->mb and ->stats would do? >>>>> >>>>> Hm, it still feels kind of wrong. We do return errors elsewhere for >>>>> operations attempted against dying domains, and that seems all fine, >>>>> not sure why paging operations need to be different in this regard. >>>>> Arm does also return -EINVAL in that case. >>>>> >>>>> So what about postponing this change to 4.18 in order to avoid >>>>> surprises, but then taking it in its current form at the start of the >>>>> development window, as to have time to detect any issues? >>>> >>>> Maybe, but to be honest I'm not convinced. Arm can't really be taken >>>> for comparison, since the op is pretty new there iirc. >>> >>> Indeed, but the tools code paths are likely shared between x86 and >>> Arm, as the hypercalls are the same. >> >> On x86 we have both xc_shadow_control() and (functional) >> xc_logdirty_control(); on Arm only the former is used, while the latter >> would also be impacted by your change. Plus you're not accounting for >> external tool stacks (like xend would be if anyone had cared to forward >> port it, when - as you said earlier - the suspicion is that the original >> change was made to "please" xend). > > I don't see how returning random uninitialised data (current behaviour) or wrong data (all zeroes) is better than returning an explicit error code. I didn't say anything like that. What I did say is that we cannot lightly move from "success" to "failure". > And even this change happens to break some code, it'd do so with a clear error code and in a reproducible way, and then such breakage can be easily fixed in the affected piece of code > (e.g. a toolstack other than XAPI which was not looking for errors from this domctl call) My experience with error messages (including the conveying of error codes) by the tool stack is rather poor. I also dare to question the "reproducible" aspect: The main risk I see here is with a multi-threaded tool stack where one thread hasn't become / been made properly aware of another one being in the process of cleaning up after a domain. Its racy issuing of further domctl-s may very well not be nicely reproducible. > AFAICT XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION is only used in the OCaml C stubs (i.e. used XAPI/xenopsd) which always checks return value > and raises OCaml exception and in python lowlevel libs, which checks return value and raises python exception. But XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION isn't the only sub-op affected here, is it? Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 09 10:04:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 10:04:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440794.694977 (Exim 4.92) (envelope-from ) id 1oshwu-0000Tp-UA; Wed, 09 Nov 2022 10:04:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440794.694977; Wed, 09 Nov 2022 10:04:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshwu-0000Ti-RG; Wed, 09 Nov 2022 10:04:48 +0000 Received: by outflank-mailman (input) for mailman id 440794; Wed, 09 Nov 2022 10:04:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oshwt-0000Tc-N6 for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 10:04:47 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ef71172f-6015-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 11:04:46 +0100 (CET) Received: from mail-mw2nam04lp2170.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 05:04:43 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by BLAPR03MB5588.namprd03.prod.outlook.com (2603:10b6:208:290::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 10:04:37 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 10:04:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef71172f-6015-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667988286; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=6DebaxirIgDCvrQKuDmkUTLD+QtR7JOvGp+PbmaJoeg=; b=HLa0FmRFPNsbE/73ozjg26QqoIA7IaT4Fto4MlYtbg/IW4SBk9j625cl 25zAiFzXO4LAnlKtbPzwbafA/fgmIAIHCFb5eAVTfBSPeTXAhnqzD7uj4 xjGFfn/4SkuEY/eYtAKsL6nymS6/8QksKf6Kdr9ur4owpbXlFLRp0Rn4K 8=; X-IronPort-RemoteIP: 104.47.73.170 X-IronPort-MID: 84478402 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:aKMNTak5CI1tQhkl98IBxc/o5gxNJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIaDT3Saa2LN2H1ft1/O46+8R8Dv5CGyNBnS1Y//Co3QSMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5A6GzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 aAJcgw/bzCAvPuNw++lR/FCiYc8B/C+aevzulk4pd3YJdAPZMifBoD1v5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVk1c3iee1WDbWUoXiqcF9k0qGp 2SA42PjBRIyP92D0zuVtHmrg4cjmAurBN5NROHgrJaGhnW5+FdUMzQ9DWLghuKEiUWaW45AE FEbr39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooL07gCDFy47RzhOQNU8sYk9QjlC/ lOAgd7BHzFkt7yRD3WH+d+8sjeaKSUTa2gYakcsXQYDptXuvow3phbOVcp4Vr64iMXvHjP9y CzMqzIx74j/luYO3qS/uFXY2TSlo8CVShZvv1qPGGW48gl+eYipIZSy7kTW5upBK4DfSUSdu H8DmI6V6+Vm4YyxqRFhid4lRNmBj8tp+hWF6bKzN/HNLwiQxkM= IronPort-HdrOrdr: A9a23:OVYXhqzCzX/JEiJEu/T+KrPxj+skLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqm12Mw+N57y6 5FxGSfqt5eCg7Bhj3045zSWwhtjVfcmwtqrQaC50YvLrf2RYUh2rD3xnklZqsoDWb/8sQqAe NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN DbXFZRpQcJCjbT4A21reh2Gzz2MRaAtG7Wu7BjDrBCy83BbauuNzGfQ1YzlMblq+kDA6TgKo SOBK4= X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208";a="84478402" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XC9h763AKqSPNvuiYboJDF/PkPLjA8IVjy+o0u2hRwL6F2BJpGv3Qm9RHrHUbWSFRXnuXp5F6RLl4sihn+xxSMG/cfWwlKUXiss+TKBgUTi8AC28KnN6bP4ax1R1PuDyZJCY+2oOWLgPQJNX0ecEOud97oCGP5JIZTRAOPHwQcW2VF3veh9ZmlQ8DcWdyaj9ian/F6nx/huS5ZA7aL3LH2/zNoroEA0UsyOsntQNR2erBH9JPq9nVaBujOXxqqA0f4p5so0TcJpnHgpTzFK4zUvjcGBVaJivNzK+YnNsELww0ZO3FuxZBffVTrv4lD2IjNjvSp6y9S7OR2cP5JBPyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6DebaxirIgDCvrQKuDmkUTLD+QtR7JOvGp+PbmaJoeg=; b=U067ovhw0uCTjoEnjb2dN2NpqtngDepWnN/QEsucyFF1Qjm/M312QW+mBHZJjyAuVc1jyrNDDunP3enaD7CDlv1jjxI5YOmSD/zIq2Xng/ksi2Hh/IT4fltbZJbioeIsXVZXXUTc1Pc4JQClyqu5gcVQaHR7AU0aHeot5t4OLG2WHNpyTy9Q7y9skdSZEoVlK9hOeoTo5oTdTy1yNj3foR4KdMrap2oPt+u4YN02sSrAdMLW+C5JYB0YVI0a0v0ivW9BpMWaOTcZGB5moOCX8ViP2WKHZ4/hcqJNX19R1AfoxXuoKGldGv1prAh3am309rmUByJ/7VLEHvO36be3DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6DebaxirIgDCvrQKuDmkUTLD+QtR7JOvGp+PbmaJoeg=; b=HPbGS2QKZ4sFX6RQrmU7sP9a6/F7laqb6c9lF9mQj6CSkbQFf0cnvEZXrwgd9PhDVUx+/oucjtFg4h0ciI8F6a5Q25U7YQbyStAbXb7yuiWKph5XmzvuTDuAFUKhXpXqfkGJjFUwgADpS5FsaXQLNab1mfbxwcjjIRUKMjCXn7E= From: Edwin Torok To: Jan Beulich CC: Henry Wang , Christian Lindig , David Scott , Wei Liu , Anthony Perard , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error Thread-Topic: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error Thread-Index: AQHY84enx+9R1HXBN0OC3OTqctPuu6415EUAgABJboCAACSeAIAAA/uAgAAEpwCAAANGgA== Date: Wed, 9 Nov 2022 10:04:36 +0000 Message-ID: <736E7341-587C-458A-B041-F5CC18E85CAB@citrix.com> References: <09afc07ba0ba65afc02028bd6b4950d8e51af69b.1667920496.git.edvin.torok@citrix.com> <1e994604-7a3f-ef5f-63f4-d03e4abe4124@suse.com> <09c03186-bdfc-d931-33bb-e589b074726e@suse.com> <2d734f9a-0b50-8164-3fce-3efaca6d7b61@suse.com> In-Reply-To: <2d734f9a-0b50-8164-3fce-3efaca6d7b61@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|BLAPR03MB5588:EE_ x-ms-office365-filtering-correlation-id: 5ffd985d-1e6f-4308-ba4d-08dac239ce9b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Fh2ez9rxqYJZz1+F8gGJTFRz9tGn+4X9Q+IbZCQHrhdyiPLV5uj20/1oA0F2BOWlHxhqTkRnwQqFG5g/LZfsGIJNDgVWQW/Ok4ccZv68rsZ95vIa459XXIVM4Add9bvoO/po3x9cyinI5b/5TgLXtUFbtIyfTU6ElwrcSMv+qDx1n5bK6MkHOeBVAJFGHjBqORGe4blkpDBjUiFmfFWj1F/q02CKLO4dGhRTurl9mBllTyCCG++qiLhbdZkNeuF6O6Z6KxsikHtA2CQrl21it5hrTcZClUkDOLzAbFuQEWRs5La8hVQSE6+QManSu4hcItymu3RQlwM6hcx1Od0ZzQUSAXq5Akwyc1Ou+ZmnXK/Bx9/+jImUb8cid5NHDDP3agbpVdEAH3+EwtlBcmWR3lZQ0EEeX+K3ycOImTri8V0DUClZFNUFvHgBGWSj8mYDZonNxIheHOxMZINQUXHbabJgYfKWSmxa2N5fE8+2PWKinA2zN9NpePgeBbo6e0UCIzyStHT2AX7UkcvpqbIU78zYTbNyAjtA2Hz2z4XyXh/ZD/8trwUsqjQucnDBbKc/8EjZEb81jtv8jLHBevSlkeXLcuxZR87362YWl9IPAMWKGjsFLlrIPPylmGUS/iMPA+3BARLe2vHwlgIM2mmeSdTAM8U40eFKzUG29d1ycIQReKdVXE+tsPkAIj+xAtE1BGEziJPR4CacdjHLgl6a6nS3EpmXjSyfriDnLjb+xsn+fg8gFLLds5FLRkOXlp6myQ70lgSRjDbYd11BxOjfya2UKOOPxQ8ojQ+Uhkeie1yFD/frgy9MD8rdMqqD6aGO3lYQUVATaCKk7sQStOvo3w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(366004)(346002)(451199015)(66574015)(66556008)(83380400001)(186003)(54906003)(122000001)(82960400001)(6512007)(38070700005)(38100700002)(26005)(2906002)(2616005)(5660300002)(8936002)(6486002)(91956017)(478600001)(966005)(53546011)(6506007)(64756008)(41300700001)(66446008)(76116006)(66946007)(66476007)(6916009)(71200400001)(8676002)(4326008)(316002)(86362001)(33656002)(36756003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?V0lXR2ZpQ1NBMTVQTXlzZ2trMGRhM05GNlJMekE4Q2RUNFVYY2JFY3VJejNN?= =?utf-8?B?djRXMXpSWE5JQW1YSlpzVUZXNmt6bXZ2NjREZVlvQU1Qc1RzRkJEVTVNa256?= =?utf-8?B?b0NXV1o2NHZSUEJKdTY2UEUvMllKY2Y3cW5rYnhxVWlwRWtxN1hjYzVleUph?= =?utf-8?B?ek5tazM3aXBhY0w1SnRMZmFyNm9QUTJxWmNMRDVLR3FKOVJKSXZIVVkvSHhF?= =?utf-8?B?R1FFWUdDbjNxbi93bWFXQS8yalljRzFYdGZJK29DRlA0eXNDM3ljOTlLU0xB?= =?utf-8?B?M2FnNjh4WG5HMi9HbFNQeXBuTVo3QU5oZHA2MDZPNGlpdHV2MnlBMm1HUVNs?= =?utf-8?B?TndEQ1I5eDQzY2VPdFFDOExSRVhtSll6N0Y2SkRLUFVqOG5LdndJNEN5ZHBR?= =?utf-8?B?OGFlWW50dGgvV2s3bTZSbVd2RHRsWTgyekcvVENXdXh4eG4zNmJhendDNStk?= =?utf-8?B?Zm9SVWR2Y01CY0FFV2g2bWdIRXIrdWdvRzBLOXhXN1ZmN0FUcFJhWVVTMGlu?= =?utf-8?B?WEhkOHhVbWxKU0pHNXVBN2ozUVF3R0JoYXp6OCtNNTJlM0xGMjVTOTBlQjNs?= =?utf-8?B?MW1jcGdBUTI5VC9ieWUveFV4MS9rakZaeTA5SHFDcGRQZGxZbXVGYU16ZW1W?= =?utf-8?B?Tk1KVU5wdlg1STNCUUhvRlA0cWFlNTVWUGFvenlEK2ZwbVZ2bzBoUzRNdmZs?= =?utf-8?B?OE9DY3k0ekdySUJ5UjlHekpINWVwcEU2RXVWRUNxVlU5NEJ3TS83WFdiYW1W?= =?utf-8?B?Si9idmVlYm8zYU5GUHV2ejJFbUJuMHhTUkhHZWd1eWFKWitvUWw4bkZSZG56?= =?utf-8?B?azlhNlJ3ZDd6UVJ3SHpubzJwZlN1c2cxNmxSZXBXVU9xMGlmL1ZXRXhLOFZN?= =?utf-8?B?b05pT2xMSEtmK0hHblZrVDQ5OGo2WG9UeVQ1RTN4TWRRNnpYc25wQ0kwVTV3?= =?utf-8?B?RWZHbEJyMDdQRnRVMWd5MlBDU2pQaUoxeW1TUFFHbjF5UHBueFRYZlFlL3dZ?= =?utf-8?B?OUEwTVJLbkIvc0p1bDZjNUp6TGhWd3JRdnpqck41WUI3Si9YcDAxK29uSnNw?= =?utf-8?B?UFZRbUVXQnU0MGY1SVNWdXo4L0U0Y1A0QlRpOWErMmcrUFgyS3orU2JvWHd2?= =?utf-8?B?dTYxbk5CY05hQkJCMUV4U1FGS3RBdko2d0gwek92VHFKeUdEWUcxWXdpeVlu?= =?utf-8?B?blYwb3BCK0tHUGUwY29UUGVYdE9xNlFvRjZRc3hKS0lVREY2VmZUbklpOFMv?= =?utf-8?B?SXZSZjRwLytmMEViY0dGdlNJb2FmQzAybGlaRGpvcUVVOEs0bGFzbERkQjN4?= =?utf-8?B?QnFGb0lUTGJUNjJ2WS9SYlN4ak1xLzR0OHJPa2ptMWszVTh4Z2lPZnZiWExM?= =?utf-8?B?OEFKWElDV1gvYjBqa3hqbjJrMWNxKzVpc3JiZmIvWitsSXhBRjdGOVZXNUU4?= =?utf-8?B?Vll0UldUWEViY0I5cW5HMnJKNmJ1OWdpODY5MlRhWEM0aS9hM0k2dHVhejJ1?= =?utf-8?B?MGNHZ3poaDRzWDYzaTBRb2Y5cXR0SS9FaVRwc2xZQXJlRW9qNnQra3FYbDVk?= =?utf-8?B?a1VDVmsyV2Z3QnArRStTSkl3aUdRZkt1N2hzU1B4K0g2S3NlcDNDL3FuR1Nt?= =?utf-8?B?MXBSK0RVM042L2xrdmVWeDZGWTEzaFk2cEhXZGVnUy8xM2QydktpWmxVbVk0?= =?utf-8?B?Kyt0SktwNHN3SDlIR0ZhTmFZT1RtTWlBS0hhM2EyalNxbExobW5ldzh0RWp4?= =?utf-8?B?OFFYYU42UFB5MThaellmOGZUdkd1cVBzUDlGeG9rYkxNbWkvbVIwM0RUTmE0?= =?utf-8?B?TVg3dE9KcEdGaGowVEVwb3N1cDdhRndhWEd6SW1mODBmdmFGajJ3K0U2NFph?= =?utf-8?B?OEVXSzFNZlM2WjZWRzhJeHphOXNDaEZodUxtNUV5TThGN21oOEJGalBWMVZR?= =?utf-8?B?b2JsNkc4YTFWWHVOTmlBUlFmMUs4STJWbE9nc25LZytiWFFvSUg4QkgzTzRY?= =?utf-8?B?QmRicDhQMlNTY3Q1c0FQR3k0STAvNno0b2d4ZXRROURFbm9ZVzNiakM4eVoy?= =?utf-8?B?UHBHS1JMMUtRTWdUcFhPc3FZbEFWOFFuNWM2RW5WaGl3SSsrN0hZMWpydzg1?= =?utf-8?B?MWdxV0wxUm1aMnNMYjRxSFN3NmgzczQwT0Yxd0J1OU5QQTVkdSt2bjNVdUln?= =?utf-8?B?U1E9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ffd985d-1e6f-4308-ba4d-08dac239ce9b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 10:04:36.0958 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6blXLLUfYEaL9mCP/5T5TYkqQG+X1kreHfiFFIwphi6xVh6Cpm+G2XrBwkKa0CQuU7KbXtgCuBgXiXh1HZxQkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5588 DQoNCj4gT24gOSBOb3YgMjAyMiwgYXQgMDk6NTIsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwOS4xMS4yMDIyIDEwOjM2LCBKYW4gQmV1bGljaCB3cm90 ZToNCj4+IE9uIDA5LjExLjIwMjIgMTA6MjEsIEVkd2luIFRvcm9rIHdyb3RlOg0KPj4+IA0KPj4+ IA0KPj4+PiBPbiA5IE5vdiAyMDIyLCBhdCAwNzoxMCwgSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1 c2UuY29tPiB3cm90ZToNCj4+Pj4gDQo+Pj4+IE9uIDA5LjExLjIwMjIgMDM6NDcsIEhlbnJ5IFdh bmcgd3JvdGU6DQo+Pj4+Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4+Pj4+PiBGcm9t OiBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jva0BjaXRyaXguY29tPg0KPj4+Pj4+IFN1YmplY3Q6 IFtQQVRDSCBmb3ItNC4xNyB2MyAwOS8xNV0gdG9vbHMvb2NhbWwveGVuc3RvcmVkL3N0b3JlLm1s OiBmaXggYnVpbGQNCj4+Pj4+PiBlcnJvcg0KPj4+Pj4+IA0KPj4+Pj4+IEJ1aWxkaW5nIHdpdGgg RHVuZSBpbiByZWxlYXNlIG1vZGUgZmFpbHMgd2l0aDoNCj4+Pj4+PiBgYGANCj4+Pj4+PiBGaWxl ICJvY2FtbC94ZW5zdG9yZWQvc3RvcmUubWwiLCBsaW5lIDQ2NCwgY2hhcmFjdGVycyAxMy0zMjoN Cj4+Pj4+PiBXYXJuaW5nIDE4OiB0aGlzIHR5cGUtYmFzZWQgcmVjb3JkIGRpc2FtYmlndWF0aW9u IGlzIG5vdCBwcmluY2lwYWwuDQo+Pj4+Pj4gRmlsZSAib2NhbWwveGVuc3RvcmVkL3N0b3JlLm1s IiwgbGluZSAxOg0KPj4+Pj4+IEVycm9yOiBTb21lIGZhdGFsIHdhcm5pbmdzIHdlcmUgdHJpZ2dl cmVkICgxIG9jY3VycmVuY2VzKQ0KPj4+Pj4+IGBgYA0KPj4+Pj4+IA0KPj4+Pj4+IFRoaXMgaXMg YSB3YXJuaW5nIHRvIGhlbHAga2VlcCB0aGUgY29kZSBmdXR1cmVwcm9vZiwgcXVvdGluZyBmcm9t IGl0cw0KPj4+Pj4+IGRvY3VtZW50YXRpb246DQo+Pj4+Pj4+IENoZWNrIGluZm9ybWF0aW9uIHBh dGggZHVyaW5nIHR5cGUtY2hlY2tpbmcsIHRvIG1ha2Ugc3VyZSB0aGF0IGFsbCB0eXBlcw0KPj4+ Pj4+IGFyZQ0KPj4+Pj4+PiBkZXJpdmVkIGluIGEgcHJpbmNpcGFsIHdheS4gV2hlbiB1c2luZyBs YWJlbGxlZCBhcmd1bWVudHMgYW5kL29yDQo+Pj4+Pj4gcG9seW1vcnBoaWMNCj4+Pj4+Pj4gbWV0 aG9kcywgdGhpcyBmbGFnIGlzIHJlcXVpcmVkIHRvIGVuc3VyZSBmdXR1cmUgdmVyc2lvbnMgb2Yg dGhlIGNvbXBpbGVyIHdpbGwNCj4+Pj4+Pj4gYmUgYWJsZSB0byBpbmZlciB0eXBlcyBjb3JyZWN0 bHksIGV2ZW4gaWYgaW50ZXJuYWwgYWxnb3JpdGhtcyBjaGFuZ2UuIEFsbA0KPj4+Pj4+PiBwcm9n cmFtcyBhY2NlcHRlZCBpbiAtcHJpbmNpcGFsIG1vZGUgYXJlIGFsc28gYWNjZXB0ZWQgaW4gdGhl IGRlZmF1bHQNCj4+Pj4+PiBtb2RlIHdpdGgNCj4+Pj4+Pj4gZXF1aXZhbGVudCB0eXBlcywgYnV0 IGRpZmZlcmVudCBiaW5hcnkgc2lnbmF0dXJlcywgYW5kIHRoaXMgbWF5IHNsb3cgZG93bg0KPj4+ Pj4+IHR5cGUNCj4+Pj4+Pj4gY2hlY2tpbmc7IHlldCBpdCBpcyBhIGdvb2QgaWRlYSB0byB1c2Ug aXQgb25jZSBiZWZvcmUgcHVibGlzaGluZyBzb3VyY2UgY29kZS4NCj4+Pj4+PiANCj4+Pj4+PiBG aXhlczogZGI0NzE0MDhlZGQ0NiAidG9vbHMvb2NhbWwveGVuc3RvcmVkOiBGaXggcXVvdGEgYnlw YXNzIG9uIGRvbWFpbg0KPj4+Pj4+IHNodXRkb3duIg0KPj4+Pj4gDQo+Pj4+PiBOaXQ6IFRoZSBm b3JtYXQgb2YgdGhpcyAiRml4ZXM6IiB0YWcgbWlnaHQgbmVlZCB0byBiZSBmaXhlZD8NCj4+Pj4+ IA0KPj4+Pj4+IA0KPj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLDtmsgPGVkdmluLnRv cm9rQGNpdHJpeC5jb20+DQo+Pj4+Pj4gLS0tDQo+Pj4+Pj4gUmVhc29uIGZvciBpbmNsdXNpb24g aW4gNC4xNzoNCj4+Pj4+PiAtIGZpeGVzIGEgYnVpbGQgZXJyb3IgaW4gYSBwcmV2aW91cyBjb21t aXQgdGhhdCBpcyBhbHJlYWR5IGluIG1hc3Rlcg0KPj4+Pj4gDQo+Pj4+PiBZZXMsIGdpdmVuIHRo aXMgaXMgYSBzaW1wbGUgZW5vdWdoIHBhdGNoOg0KPj4+Pj4gDQo+Pj4+PiBSZWxlYXNlLWFja2Vk LWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+Pj4+IA0KPj4+PiBBZmFpY3Mg dGhpcyBwYXRjaCB3YXMgcHJldmlvdXNseSBwb3N0ZWQgaW4gaXNvbGF0aW9uLCBhbmQgaXQgd2Fz DQo+Pj4+IGFscmVhZHkgcmVsZWFzZS1hY2tlZC4gV2hhdCdzIGxhY2tpbmcgdGhlcmUgaXMgYSAy bmQgbWFpbnRhaW5lcidzDQo+Pj4+IGFjayBvciBhIHByb3BlciBSLWIuIFdoZW4gaXQgbm93IGlz IHBhdGNoIDkgaW4gYSBzZXJpZXMsIGl0IGlzbid0DQo+Pj4+IHJlYWxseSBvYnZpb3VzIHdoZXRo ZXIgdGhpcyBjb3VsZCBhbHNvIGJlIGNvbW1pdHRlZCBpbiBpc29sYXRpb24NCj4+Pj4gKGl0IGxv b2tzIGxpa2UgaXQgZG9lcywgYnV0IGEgY2xlYXIgc3RhdGVtZW50IHRvIHRoaXMgZWZmZWN0DQo+ Pj4+IHdvdWxkIGhhdmUgYmVlbiBiZW5lZmljaWFsKS4NCj4+Pj4gDQo+Pj4gDQo+Pj4gDQo+Pj4g WW91J3JlIHJpZ2h0IGl0IGFscmVhZHkgaGFzIGJvdGggYWNrcywgaXQganVzdCBoYXNuJ3QgYmVl biBjb21taXRlZCB5ZXQ6IA0KPj4gDQo+PiBPaCwgdGhhdCdzIG9ubHkgYmVjYXVzZSBJIG92ZXJs b29rZWQgQ2hyaXN0aWFuJ3MgYWNrLiBXaWxsIGNvbW1pdCB0aGlzIG5vdy4NCj4gDQo+IEJ1dCwg c2lnaCwgSSBoYWQgdG8gZml4IHVwIHRoZSBwYXRjaDogRXZlbiB0aGUgb25lIHN1Ym1pdHRlZCBz dGFuZGFsb25lDQo+IHVzZWQgc3BhY2UgaW5kZW50YXRpb24gd2hlbiB0aGUgZmlsZSBpbiB0aGUg dHJlZSB1c2VzIGhhcmQgdGFicy4gQW5kDQo+IGV2ZW4gaWYgSSBoYWQgd2FudGVkIHRvIHB1bGwg ZnJvbSB5b3VyIGdpdGh1YiB0cmVlIEkgd291bGQgaGF2ZSBoYWQgdG8NCj4gZml4IHVwIGF0IGxl YXN0IHRoZSBGaXhlczogdGFnLg0KDQoNCkkgdGhvdWdodCBJIGZpeGVkIGl0ICh0aGUgbWlzc2lu ZyAnKCcpLCBidXQgdGhlIGZvcm1hdCBvZiB0aGUgRml4ZXM6IGxpbmUgd2FzIG5vdCBkb2N1bWVu dGVkIGluIA0KaHR0cHM6Ly93aWtpLnhlbnByb2plY3Qub3JnL3dpa2kvU3VibWl0dGluZ19YZW5f UHJvamVjdF9QYXRjaGVzICh3aGljaCBpcyB0aGUgY2Fub25pY2FsIHJlc291cmNlIEkgdXNlIHdo ZW4gc2VuZGluZyBwYXRjaGVzKQ0KYW5kIEkganVzdCB0cmllZCB0byBndWVzcyB0aGUgZm9ybWF0 IGJhc2VkIG9uIHRoZSBGaXhlczogZW50cmllcyBJIGZvdW5kIGluIG1hc3RlciAoc29tZSBvZiB3 aGljaCBoYXZlIG9yIGxlc3MgY2hhcmFjdGVycyBpbiB0aGUgZ2l0IGhhc2gpDQoNCkkgc2VlIHRo ZXJlIGlzIGEgaHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZG9jcy91bnN0YWJsZS9wcm9jZXNzL3Nl bmRpbmctcGF0Y2hlcy5odG1sIHdoaWNoIGhhcyBzb21lIG1vcmUgdXNlZnVsIGRldGFpbHMsDQpp bmNsdWRpbmcgYSB3YXkgdG8gYXV0b21hdGljYWxseSBnZW5lcmF0ZSB0aGUgRml4ZXM6IGxpbmUg dXNpbmcgYSBnaXQgY29uZmlnLCB3aGljaCBpcyB2ZXJ5IHVzZWZ1bCBhbmQgSSdsbCB1c2UgdGhh dCBpbiB0aGUgZnV0dXJlIGluc3RlYWQgb2YgY3JhZnRpbmcgaXQgYnkgaGFuZA0KKHdoaWNoIGlz IHdoYXQgSSd2ZSBiZWVuIGRvaW5nIHNvIGZhcikuDQpJJ3ZlIGVkaXRlZCB0aGUgd2lraSB0byBp bmNsdWRlIHRoaXMgaW5mb3JtYXRpb24gbm93Lg0KDQo+ICBTbyBJIGVuZGVkIHVwIGhhbmQtZWRp dGluZyBpbmRlbnRhdGlvbg0KDQoNCg0KVGhhbmtzLA0KLS1FZHdpbg== From xen-devel-bounces@lists.xenproject.org Wed Nov 09 10:09:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 10:09:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440799.694987 (Exim 4.92) (envelope-from ) id 1osi17-0001P6-FB; Wed, 09 Nov 2022 10:09:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440799.694987; Wed, 09 Nov 2022 10:09:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osi17-0001Oz-CP; Wed, 09 Nov 2022 10:09:09 +0000 Received: by outflank-mailman (input) for mailman id 440799; Wed, 09 Nov 2022 10:09:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osi16-0001Os-2h for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 10:09:08 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80080.outbound.protection.outlook.com [40.107.8.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b5e8afe-6016-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 11:09:06 +0100 (CET) Received: from AM6PR04CA0054.eurprd04.prod.outlook.com (2603:10a6:20b:f0::31) by DB9PR08MB8460.eurprd08.prod.outlook.com (2603:10a6:10:3d4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 10:08:57 +0000 Received: from AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:f0:cafe::b) by AM6PR04CA0054.outlook.office365.com (2603:10a6:20b:f0::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Wed, 9 Nov 2022 10:08:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT022.mail.protection.outlook.com (100.127.140.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 10:08:56 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Wed, 09 Nov 2022 10:08:56 +0000 Received: from 86d561f4a109.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5BADF063-7F6F-4EB1-8583-F0EAE7BC24D7.1; Wed, 09 Nov 2022 10:08:46 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 86d561f4a109.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 10:08:46 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by VI1PR08MB5358.eurprd08.prod.outlook.com (2603:10a6:803:13c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 10:08:41 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893%4]) with mapi id 15.20.5813.011; Wed, 9 Nov 2022 10:08:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b5e8afe-6016-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QUAH8PBiUL/VhcDHlibd2YVzZsRQFheVfRLnM30xrpbW8m3Yv4jtDTOwY27nCTXJnc7UlbIHevQmbTfedEcEMhXWgTjdkj2TVwFRcp5RbuVDeDtG6MA8Np+uwsD1KFWpFAPLFzkxKMc2rax0aA68iHS/iuCt+pSl9As0Kja6lrNegPLd1JdO644ECYNDFBrMgjZxhaM6bn5boXCdRVSwP+XAMIN3qqs96gcBFdCr4466dXU3Tr4BvoilCFQ42M0UHbtkBd8qHoCZdV2//ee0CddiVeJTRzu1aJtgDNk49cvS61G/hWG9gwifNchTNLsyGSjZ95EioO72ACYM6Igs9w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PFgrpnWSFpfvRhlcpXkoJqz4ZjsqYqDXmVuWeM49ugg=; b=Hjd6FWvmgV7tlEE6o4E/10+MHRix3D00HpCAdRHnFM2CZqbBPPppijB9hSAT6OV33xZTeQfAdrRh4MkrgHIDs0POkhthVdWbnnJjYESEzRlRFtjj4SMxmKl/BW9ErakZYNZLvHm9ENUTZ1GI6JVQOyARPFzQjRkD57lu3uinhOap4eeKlzKpzt9B+7RomJhLAlJKKK74qjl9kO973fKnZM6Lxq6kkO7IPMVWtn2+DmY7LrLl3+DamBUdswxnODaAnDqmbk7ed4YrdmHPH95nsJQe99YMygLpgSsD/SQDyRpwA/xOIMgBhq3GLGqHXF3fOhVfZWSvhyTZCr78kefvRQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PFgrpnWSFpfvRhlcpXkoJqz4ZjsqYqDXmVuWeM49ugg=; b=YfmGW5zsclxhFTwTWS6Ifv00VFsbW/uDs/7PUCtRUdBCjaFzInXDpooX7qhj5xew0lroIHkA4zF/dA+i+2FCqXF0tubxxttIiU7O6gMnehkUetzK5EZHLaFXda4BdQD7f5kc8E67F+quEo6qwvHn1jOpM2V9aTA+lyHU6ZwCcRs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0585b7a80be635f9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eLqxrXhPaTDklMlrQeKrq06ZhnblxDFV/m+t2LQHhZS4k9mIzG5xTCH4NpLtBVlwDMf9DxQpE2hyt393IwzSI4myxx6fdw2/YsQ5c7FJtf40NBIYXjqbkATIFkGeIpPrF1sPdIn1RDo0pRR4+2GAOjz5IVPgG+QLOTE22uPflD9KoQTq9GLgQ20h3liyOOpBZPr4xjD8ncNKZgip2+7QGM7o6PRLsfDm7WJmta8nNFqxsVZH9i7h8sddbu+3gHht2Jpic/7cbhrpUQwYW7Sbj9gXEohwrNeH5iuMQhAezJn0VdU2YozLBI6rSX1Len/EY3rvlYpfKbo3u95qbh0L5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PFgrpnWSFpfvRhlcpXkoJqz4ZjsqYqDXmVuWeM49ugg=; b=IVvf+HikqifRrytUI4syO4v7jDuz/N9wSHPvXYS2x5XF5tILVVznzhWH1oa/GUR0MchZxaos6vdjBF8KgytLFqs74p+Zvaik0pYmiMYagxaREDjvp7A+hUIXDuBux3L8D3kjT9XrT1h59UF3FGjRkKF61xVFQdEsbT2T6RXagS6a7/r6v349lp5eiM+pTkjuVugESIRX9EhkXfuH9QPXi9uofw+rlqyN6Omh2vFSke3/oOKC/2ICO3/LxsfmoSneIMQv5WcgYvM1faZUGTKGdpec921iFwLJRgBzSIuogLUIxYTrD2JKgG6qM0u4XteJvUKdpr0a90llXbiaFay++Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PFgrpnWSFpfvRhlcpXkoJqz4ZjsqYqDXmVuWeM49ugg=; b=YfmGW5zsclxhFTwTWS6Ifv00VFsbW/uDs/7PUCtRUdBCjaFzInXDpooX7qhj5xew0lroIHkA4zF/dA+i+2FCqXF0tubxxttIiU7O6gMnehkUetzK5EZHLaFXda4BdQD7f5kc8E67F+quEo6qwvHn1jOpM2V9aTA+lyHU6ZwCcRs= From: Luca Fancellu To: Jan Beulich CC: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Thread-Topic: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Thread-Index: AQHY8pZ008DS0BACDkyhs+OWN8Oan64zqLWAgAE0WoCAAA3SgIAAJOMAgAAeVoCAABeCgIABAHkAgAAbOoA= Date: Wed, 9 Nov 2022 10:08:41 +0000 Message-ID: <9CE2A214-2D64-4BEC-A78B-393BF7AEDD9D@arm.com> References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> <7d56c33d-4b03-9aa1-6abc-45a8ad41caca@suse.com> <2E0BFEFC-5BEE-4F8B-BD9E-94CB9A5B2BC9@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|VI1PR08MB5358:EE_|AM7EUR03FT022:EE_|DB9PR08MB8460:EE_ X-MS-Office365-Filtering-Correlation-Id: d85e6e11-9278-461a-0a78-08dac23a6a1b x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: x9uyh6csUE9ACp3NLivzy7qdp9vlz8nH+VMwRQS+7hAS1LkKbp5pWMF0K9s8uwM4266t2smjWnoPjGb64ezEx26ODUo9i8uLhUKJwiJlw0Mp1XGBpkbqs71Ksa3MoTWUC9C98leM8o/fKphAQhodrHpG2i2ZNpTtTl0rjmxKOCzrTZHk8sYNux0Tg4X1m8sCbHyze9rHaVQLil2/tZ+YYEj6BYjACqgRYIzQpp8bsxOndsL4p2Om+iGoj5QGp5wGPyS83W3Lr8y+9CkT2LeXoU0fkY4pcG+XDaTxpTJ98jncc6FJrnYXCaqZSGnxpCxoRtQT+sA6avoNN0eFAM9kLjMvdiAPrIxtTtu3E+ETpi1V4EhXyte84SQ9Eas4y4cbR4oGcJ2+b3IwKiSXew3ZaGNRqjApacDTLHraq6c+VWubTnlZ+ZVK3wfBXiKqW1sujoNcBoIiwy03kefpPtyx6enE1XGK+7wrBi2n//sFndmoBiefmxVv6m6BSaQZg3z7mqGc/ZNP2u6JYsOcTi+h+XQl7jvQXnm9zMQzrJa5k3BjFPcbS0SePJt5OrOeGcn1SI0QEybHMRGBdaAuabGuOn74+HF5y5IXkSrvK5l/9ZHQJxTVSwnoEcyxWBOPAz8kfGbKqTgFPxIzdAdSeU5JwEaawEajHP6AwaIdppXCNaNVr3PT6SvTgzx4nu2UmXCtArHKB7cvImpmaUssz9ETjt86FSFatmxEWROT1BV+RDxyO8ZqT/FaZYNCOBfSCTXbRGiuzrzrTT9J9WA9X/H/EavTg/7Nb6FIM6ow6UAZC+Q= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(451199015)(5660300002)(30864003)(186003)(2616005)(8936002)(41300700001)(2906002)(38070700005)(33656002)(86362001)(36756003)(83380400001)(122000001)(38100700002)(54906003)(6916009)(71200400001)(316002)(6486002)(76116006)(66946007)(91956017)(66556008)(26005)(478600001)(6512007)(4326008)(66476007)(64756008)(66446008)(8676002)(6506007)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5358 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a24a19dc-7373-4c94-ae1d-08dac23a60ed X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AwkOwUtz5AbaF1QC175yxG9NBeCTGpjbpiEoPPS3fus1HqydXyVuLa8UCuSVcf1lsheQhB7IKGJU1QfZLEenxWRX+g4lj2yGjBOOjkrRMr68UPAGb9qdNsT1NdYwNxpN1kRSHqdjiR78qjzPIwn6sKXkOHhCN5Pxzc+92SWugXEQuwN4oqVj77DsFttvDlENgn3wiQrc1Sl8F5QwFPLullyZb205WYUiQICb5CfYrTLTTSxzAs+Ay+QoOg66sSp/ajFitTGQQRI6jMO84zw3kyigPtUKlMJazcqzS4DBK3hg5cvc/FGBtM9ql0ruamM3vgIj+AOW9m+cWgRJJ+0gjyyY2RGh2wGjkqsymJrB+Og5NND92CGiGiTpIxrLFOKscc/WzwgUKDIqBh3bhzItPlNKGVmzq3LHAjem52gArsVQ27It+DEIAPrq48OPLMYR/ezx6fYauykbWgYpm0Uia/64ToBrXFHs42/CpSOq88u9EAqfLus7Dnyz0gJ6+92m6qmMWcaVfq4qAH3+QT8HTVCAMgMB9aRe2RlPYLk1FR+ne1SnNvkJURiMl5ZmWN/GS2oYUdVO9HYX+JEYYCwJeU9At0rAK11qK2ika63GYsUuApTU9P40ye0Joe7yunjhulIS9FHb2TFcq2sMZ1k94lS/KDhMGRlL4kvQOrGVtwDPak46/lTSzZGYI/PGalJQ8gXVe5XZlYE/sy3L9fBWVSTySLMTvjhGB2Lk2bBvwA3jHIUxEfoVOgystG4WKpXCBgWeCjVQVe438beRI7JyzQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(82740400003)(82310400005)(36756003)(6486002)(41300700001)(8676002)(30864003)(5660300002)(6506007)(8936002)(6862004)(70206006)(4326008)(356005)(40480700001)(54906003)(33656002)(70586007)(316002)(53546011)(81166007)(47076005)(2906002)(26005)(336012)(478600001)(83380400001)(40460700003)(36860700001)(86362001)(6512007)(186003)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 10:08:56.9614 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d85e6e11-9278-461a-0a78-08dac23a6a1b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8460 DQo+PiANCj4+IE9uIDA3LjExLjIwMjIgMTE6NDcsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4g K0hlcmUgaXMgYW4gZXhhbXBsZSB0byBhZGQgYSBuZXcganVzdGlmaWNhdGlvbiBpbiBmYWxzZS1w b3NpdGl2ZS08dG9vbD4uanNvbjo6DQo+PiANCj4+IFdpdGggPHRvb2w+IGFscmVhZHkgcHJlc2Vu dCBpbiB0aGUgbmFtZSwgLi4uDQo+PiANCj4+PiArfHsNCj4+PiArfCAgICAidmVyc2lvbiI6ICIx LjAiLA0KPj4+ICt8ICAgICJjb250ZW50IjogWw0KPj4+ICt8ICAgICAgICB7DQo+Pj4gK3wgICAg ICAgICAgICAiaWQiOiAiU0FGLTAtZmFsc2UtcG9zaXRpdmUtPHRvb2w+IiwNCj4+PiArfCAgICAg ICAgICAgICJhbmFseXNlciI6IHsNCj4+PiArfCAgICAgICAgICAgICAgICAiPHRvb2w+IjogIjxw cm9wcmlldGFyeS1pZD4iDQo+PiANCj4+IC4uLiBjYW4gd2UgYXZvaWQgdGhlIHJlZHVuZGFuY3kg aGVyZT8gUGVyaGFwcyAuLi4NCj4+IA0KPj4+ICt8ICAgICAgICAgICAgfSwNCj4+PiArfCAgICAg ICAgICAgICJ0b29sLXZlcnNpb24iOiAiPHZlcnNpb24+IiwNCj4+IA0KPj4gLi4uIGl0IGNvdWxk IGJlDQo+PiANCj4+ICAgICAgICAgICAiYW5hbHlzZXIiOiB7DQo+PiAgICAgICAgICAgICAgICI8 dmVyc2lvbj4iOiAiPHByb3ByaWV0YXJ5LWlkPiINCj4+ICAgICAgICAgICB9LA0KDQpBYm91dCB0 aGlzLCBJ4oCZdmUgaW52ZXN0aWdhdGVkIGEgYml0IGFuZCBJIGRvbuKAmXQgdGhpbmsgdGhpcyBp cyB0aGUgcmlnaHQgc29sdXRpb24sIGl0IHdvdWxkbid0IG1ha2UNCm11Y2ggc2Vuc2UgdG8gaGF2 ZSBhIHNjaGVtYSB3aGVyZSBpbiBvbmUgZmlsZSB0aGUgYW5hbHlzZXIgZGljdGlvbmFyeSBrZXkg aXMgdGhlIHRvb2wgbmFtZQ0KYW5kIGluIGFub3RoZXIgaXQgaXMgYSB2ZXJzaW9uIChvciByYW5n ZSBvZiB2ZXJzaW9ucykuDQoNCkhvd2V2ZXIgSSBjYW4gcmVtb3ZlIHRoZSBhbmFseXNlciBkaWN0 aW9uYXJ5IGFuZCB1c2UgdGhpcyBzY2hlbWEgZm9yIHRoZSBmYWxzZS1wb3NpdGl2ZSwgd2hpY2gg aXMNCm1vcmUgY29tcGFjdDoNCg0KfHsNCnwgICAgInZlcnNpb24iOiAiMS4wIiwNCnwgICAgImNv bnRlbnQiOiBbDQp8ICAgICAgICB7DQp8ICAgICAgICAgICAgImlkIjogIlNBRi0wLWZhbHNlLXBv c2l0aXZlLTx0b29sPiIsDQp8ICAgICAgICAgICAg4oCcdG9vbC1wcm9wcmlldGFyeS1pZOKAnTog Ijxwcm9wcmlldGFyeS1pZD7igJ0sDQp8ICAgICAgICAgICAgInRvb2wtdmVyc2lvbiI6ICI8dmVy c2lvbj4iLA0KfCAgICAgICAgICAgICJuYW1lIjogIlIyMC43IFsuLi5dIiwNCnwgICAgICAgICAg ICAidGV4dCI6ICJbLi4uXSINCnwgICAgICAgIH0sDQp8ICAgICAgICB7DQp8ICAgICAgICAgICAg ImlkIjogIlNBRi0xLWZhbHNlLXBvc2l0aXZlLTx0b29sPiIsDQp8ICAgICAgICAgICAg4oCcdG9v bC1wcm9wcmlldGFyeS1pZOKAnTogIiIsDQp8ICAgICAgICAgICAgInRvb2wtdmVyc2lvbiI6ICIi LA0KfCAgICAgICAgICAgICJuYW1lIjogIlNlbnRpbmVsIiwNCnwgICAgICAgICAgICAidGV4dCI6 ICJOZXh0IElEIHRvIGJlIHVzZWQiDQp8ICAgICAgICB9DQp8ICAgIF0NCnx9DQoNClRoaXMgbmVl ZHMgaG93ZXZlciBhIGNoYW5nZSBpbiB0aGUgaW5pdGlhbCBkZXNpZ24gYW5kIG1vcmUgZG9jdW1l bnRhdGlvbiBvbiB0aGUgZGlmZmVyZW50IGhhbmRsaW5ncw0Kb2YgdGhlIHNhZmUuanNvbiBzY2hl bWEgYW5kIHRoZSBmYWxzZS1wb3NpdGl2ZS08dG9vbD4uanNvbiBzY2hlbWEuIElzIGl0IHdvcnRo Pw0KDQo+IE9uIDkgTm92IDIwMjIsIGF0IDA4OjMxLCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMDguMTEuMjAyMiAxODoxMywgTHVjYSBGYW5jZWxsdSB3 cm90ZToNCj4+PiBPbiA4IE5vdiAyMDIyLCBhdCAxNTo0OSwgSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPiB3cm90ZToNCj4+PiBPbiAwOC4xMS4yMDIyIDE1OjAwLCBMdWNhIEZhbmNlbGx1 IHdyb3RlOg0KPj4+Pj4gT24gOCBOb3YgMjAyMiwgYXQgMTE6NDgsIEphbiBCZXVsaWNoIDxqYmV1 bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+Pj4+PiBPbiAwOC4xMS4yMDIyIDExOjU5LCBMdWNhIEZh bmNlbGx1IHdyb3RlOg0KPj4+Pj4+PiBPbiAwNy4xMS4yMDIyIDExOjQ3LCBMdWNhIEZhbmNlbGx1 IHdyb3RlOg0KPj4+Pj4+Pj4gQEAgLTc1Nyw2ICs3NTgsNTEgQEAgY3BwY2hlY2stdmVyc2lvbjoN Cj4+Pj4+Pj4+ICQob2JqdHJlZSkvaW5jbHVkZS9nZW5lcmF0ZWQvY29tcGlsZXItZGVmLmg6DQo+ Pj4+Pj4+PiAJJChRKSQoQ0MpIC1kTSAtRSAtbyAkQCAtIDwgL2Rldi9udWxsDQo+Pj4+Pj4+PiAN Cj4+Pj4+Pj4+ICtKVVNUSUZJQ0FUSU9OX0ZJTEVTIDo9ICQoWEVOX1JPT1QpL2RvY3MvbWlzcmEv c2FmZS5qc29uIFwNCj4+Pj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICQoWEVOX1JPT1Qp L2RvY3MvbWlzcmEvZmFsc2UtcG9zaXRpdmUtJCQqLmpzb24NCj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+ ICsjIFRoZSBmb2xsb3dpbmcgY29tbWFuZCBpcyB1c2luZyBncmVwIHRvIGZpbmQgYWxsIGZpbGVz IHRoYXQgY29udGFpbnMgYSBjb21tZW50DQo+Pj4+Pj4+PiArIyBjb250YWluaW5nICJTQUYtPGFu eXRoaW5nPiIgb24gYSBzaW5nbGUgbGluZS4NCj4+Pj4+Pj4+ICsjICUuc2FmcGFyc2Ugd2lsbCBi ZSB0aGUgb3JpZ2luYWwgZmlsZXMgc2F2ZWQgZnJvbSB0aGUgYnVpbGQgc3lzdGVtLCB0aGVzZSBm aWxlcw0KPj4+Pj4+Pj4gKyMgd2lsbCBiZSByZXN0b3JlZCBhdCB0aGUgZW5kIG9mIHRoZSBhbmFs eXNpcyBzdGVwDQo+Pj4+Pj4+PiArUEFSU0VfRklMRV9MSVNUIDo9ICQoYWRkc3VmZml4IC5zYWZw YXJzZSwkKGZpbHRlci1vdXQgJS5zYWZwYXJzZSxcDQo+Pj4+Pj4+PiArJChzaGVsbCBncmVwIC1F UmwgJ15bWzpibGFuazpdXSpcL1wqW1s6c3BhY2U6XV0rU0FGLS4qXCpcLyQkJyAkKHNyY3RyZWUp KSkpDQo+Pj4+Pj4+IA0KPj4+Pj4+PiBQbGVhc2UgaW5kZW50IHN1Y2ggbGluZSBjb250aW51YXRp b25zLiBBbmQgdGhlbiBpc24ndCB0aGlzIGdvaW5nIHRvIHJpc2sNCj4+Pj4+Pj4gbWF0Y2hpbmcg bm9uLXNvdXJjZSBmaWxlcyBhcyB3ZWxsPyBQZXJoYXBzIHlvdSB3YW50IHRvIHJlc3RyaWN0IHRo aXMgdG8NCj4+Pj4+Pj4gKi5jIGFuZCAqLmg/DQo+Pj4+Pj4gDQo+Pj4+Pj4gWWVzLCBob3cgYWJv dXQgdGhpcywgaXQgd2lsbCBmaWx0ZXIgb3V0ICouc2FmcGFyc2UgZmlsZXMgd2hpbGUga2VlcGlu ZyBpbiBvbmx5IC5oIGFuZCAuYzoNCj4+Pj4+PiANCj4+Pj4+PiBQQVJTRV9GSUxFX0xJU1QgOj0g JChhZGRzdWZmaXggLnNhZnBhcnNlLCQoZmlsdGVyICUuYyAlLmgsXA0KPj4+Pj4+ICAkKHNoZWxs IGdyZXAgLUVSbCAnXltbOmJsYW5rOl1dKlwvXCpbWzpzcGFjZTpdXStTQUYtLipcKlwvJCQnICQo c3JjdHJlZSkpKSkNCj4+Pj4+IA0KPj4+Pj4gVGhhdCdzIGJldHRlciwgYnV0IHN0aWxsIG1lYW5z IHRvdWNoaW5nIGFsbCBmaWxlcyBieSBncmVwIGRlc3BpdGUgbm93DQo+Pj4+PiBvbmx5IGEgc3Vi c2V0IHJlYWxseSBsb29rZWQgZm9yLiBJZiBJIHdhcyB0byB1c2UgdGhlIG5ldyBnb2FscyBvbiBh DQo+Pj4+PiBtb3JlIG9yIGxlc3MgcmVndWxhciBiYXNpcywgSSdkIGV4cGVjdCB0aGF0IHRoaXMg ZW51bWVyYXRpb24gb2YgZmlsZXMNCj4+Pj4+IGRvZXNuJ3QgcmVhZCBfbXVjaF8gbW9yZSBzdHVm ZiBmcm9tIGRpc2sgdGhhbiBpcyBhY3R1YWxseSBuZWNlc3NhcnkuDQo+Pj4+IA0KPj4+PiBPayB3 b3VsZCBpdCBiZSBvaz8NCj4+Pj4gDQo+Pj4+IFBBUlNFX0ZJTEVfTElTVCA6PSAkKGFkZHN1ZmZp eCAuc2FmcGFyc2UsJChzaGVsbCBncmVwIC1FUmwgLS1pbmNsdWRlPVwqLmggXA0KPj4+PiAgIC0t aW5jbHVkZT1cKi5jICdeW1s6Ymxhbms6XV0qXC9cKltbOnNwYWNlOl1dK1NBRi0uKlwqXC8kJCcg JChzcmN0cmVlKSkpDQo+Pj4gDQo+Pj4gSG1tLCBub3Qgc3VyZTogLS1pbmNsdWRlIGlzbid0IGEg c3RhbmRhcmQgb3B0aW9uIHRvIGdyZXAsIGFuZCB3ZQ0KPj4+IGdlbmVyYWxseSB0cnkgdG8gYmUg cG9ydGFibGUuIEFjdHVhbGx5IC1SIChvciAtcikgaXNuJ3QgZWl0aGVyLiBJdA0KPj4+IG1heSBz dGlsbCBiZSBva2F5IHRoYXQgd2F5IGlmIHByb3Blcmx5IGRvY3VtZW50ZWQgd2hlcmUgdGhlIGlu dm9sdmVkDQo+Pj4gZ29hbHMgd2lsbCB3b3JrIGFuZCB3aGVyZSBub3QuDQo+PiANCj4+IElzIGEg Y29tbWVudCBiZWZvcmUgdGhlIGxpbmUgb2sgYXMgZG9jdW1lbnRhdGlvbj8gVG8gc3RhdGUgdGhh dCDigJRpbmNsdWRlIGFuZA0KPj4gLVIgYXJlIG5vdCBzdGFuZGFyZCBvcHRpb25zIHNvIGFuYWx5 c2lzLXtjb3Zlcml0eSxlY2xhaXJ9IHdpbGwgbm90IHdvcmsgd2l0aG91dCBhDQo+PiBncmVwIHRo YXQgdGFrZXMgdGhvc2UgcGFyYW1ldGVycz8NCj4gDQo+IEEgY29tbWVudCBfbWlnaHRfIGJlIG9r YXkuIElzIHRoZXJlIG5vIG90aGVyIGRvY3VtZW50YXRpb24gb24gaG93IHRoZXNlDQo+IGdvYWxz IGFyZSB0byBiZSB1c2VkPyBUaGUgbWFpbiBxdWVzdGlvbiBoZXJlIGlzIGhvdyBpbXBhY3Rpbmcg dGhpcyBtaWdodA0KPiBiZSB0byB0aGUgdmFyaW91cyBlbnZpcm9ubWVudHMgd2UgYWxsb3cgWGVu IHRvIGJlIGJ1aWx0IGluOiBXb3VsZCBhdA0KPiBsZWFzdCBtb2Rlcm4gdmVyc2lvbnMgb2YgYWxs IExpbnV4IGRpc3Ryb3Mgd2UgY2FyZSBhYm91dCBhbGxvdyB1c2luZw0KPiB0aGVzZSBydWxlcz8g V2hhdCBhYm91dCBub24tTGludXg/DQo+IA0KPiBBbmQgY291bGQgeW91IGF0IGxlYXN0IGJhaWwg d2hlbiBQQVJTRV9GSUxFX0xJU1QgZW5kcyB1cCBlbXB0eSwgd2l0aCBhDQo+IGNsZWFyIGVycm9y IG1lc3NhZ2UgYXVnbWVudGluZyB0aGUgb25lIGdyZXAgd291bGQgaGF2ZSBpc3N1ZWQ/DQoNCkFu IGVtcHR5IFBBUlNFX0ZJTEVfTElTVCBzaG91bGQgbm90IGdlbmVyYXRlIGFuIGVycm9yLCBpdCBq dXN0IG1lYW5zIHRoZXJlIGFyZSBubw0KanVzdGlmaWNhdGlvbnMsIGJ1dCBJIHNlZSBpdCBjYW4g YmUgcHJvYmxlbWF0aWMgaW4gY2FzZSBncmVwIGRvZXMgbm90IHdvcmsuDQoNCldoYXQgYWJvdXQg dGhpcz8gVGhleSBzaG91bGQgYmUgc3RhbmRhcmQgb3B0aW9ucyByaWdodD8NCg0KUEFSU0VfRklM RV9MSVNUIDo9ICQoYWRkc3VmZml4IC5zYWZwYXJzZSwkKHNoZWxsIGZpbmQgJChzcmN0cmVlKSAt dHlwZSBmIFwNCiAgICAtbmFtZSAnKi5jJyAtbyAtbmFtZSAnKi5oJyAtZXhlYyBcDQogICAgZ3Jl cCAtRWwgJ15bWzpibGFuazpdXSpcL1wqW1s6c3BhY2U6XV0rU0FGLS4qXCpcLyQkJyB7fSArICkp DQoNCj4gDQo+Pj4gQW5kIHRoZW4gLSB3aHkgZG8geW91IGVzY2FwZSBzbGFzaGVzIGluIHRoZSBF UkU/DQo+Pj4gDQo+Pj4gVGFsa2luZyBvZiBlc2NhcGluZyAtIHBlcnNvbmFsbHkgSSBmaW5kIGJh Y2tzbGFzaCBlc2NhcGVzIGhhcmRlciB0bw0KPj4+IHJlYWQgLyBncm9rIHRoYW4gcXVvdGF0aW9u LCBzbyBJJ2QgbGlrZSB0byByZWNvbW1lbmQgdXNpbmcgcXVvdGVzDQo+Pj4gYXJvdW5kIGVhY2gg b2YgdGhlIHR3byAtLWluY2x1ZGUgKGlmIHRoZXkgcmVtYWluIGluIHRoZSBmaXJzdCBwbGFjZSkN Cj4+PiBpbnN0ZWFkIG9mIHRoZSBcKiBjb25zdHJ1Y3QuDQo+PiANCj4+IE9rIEnigJl2ZSByZW1v dmVkIHRoZSBlc2NhcGUgZnJvbSB0aGUgKiBhbmQgYWxzbyBmcm9tIHNsYXNoZXM6DQo+PiANCj4+ IFBBUlNFX0ZJTEVfTElTVCA6PSAkKGFkZHN1ZmZpeCAuc2FmcGFyc2UsJChzaGVsbCBncmVwIC1F UmwgLS1pbmNsdWRlPScqLmgnIFwNCj4+ICAgIC0taW5jbHVkZT0nKi5jJyAnXltbOmJsYW5rOl1d Ki9cKltbOnNwYWNlOl1dK1NBRi0uKlwqLyQkJyAkKHNyY3RyZWUpKSkNCj4gDQo+IEdvb2QgLSBz ZWVpbmcgdGhpbmdzIG1vcmUgY2xlYXJseSBub3cgbXkgbmV4dCBxdWVzdGlvbiBpczogSXNuJ3QN Cj4gbWF0Y2hpbmcganVzdCAiLyogU0FGLS4uLiovIiBhIGxpdHRsZSB0b28gbGF4PyBBbmQgaXMg dGhlcmUgcmVhbGx5IGENCj4gbmVlZCB0byBwZXJtaXQgbGVhZGluZyBibGFua3M/DQoNCknigJlt IHBlcm1pdHRpbmcgYmxhbmtzIHRvIGFsbG93IHNwYWNlcyBvciB0YWJzLCB6ZXJvIG9yIG1vcmUg dGltZXMgYmVmb3JlIHRoZSBzdGFydCBvZg0KdGhlIGNvbW1lbnQsIEkgdGhpbmsgaXQgc2hhbGwg YmUgbGlrZSB0aGF0Lg0KQWJvdXQgbWF0Y2hpbmcsIG1heWJlIEkgY2FuIG1hdGNoIGFsc28gdGhl IG51bWJlciBhZnRlciBTQUYtLCB0aGlzIHNob3VsZCBiZSBlbm91Z2gsDQoNClvigKZdIGdyZXAg LUVsICdeW1s6Ymxhbms6XV0qXC9cKltbOnNwYWNlOl1dK1NBRi1bMC05XSsuKlwqXC8kJOKAmSBb 4oCmXQ0KDQo+IA0KPj4+Pj4+Pj4gKwlkb25lDQo+Pj4+Pj4+PiArDQo+Pj4+Pj4+PiArYW5hbHlz aXMtYnVpbGQtJTogYW5hbHlzaXMtcGFyc2UtdGFncy0lDQo+Pj4+Pj4+PiArCSQoTUFLRSkgTz0k KGFic19vYmp0cmVlKSAtZiAkKHNyY3RyZWUpL01ha2VmaWxlIGJ1aWxkDQo+Pj4+Pj4+IA0KPj4+ Pj4+PiBUaGlzIHJ1bGUgZG9lc24ndCB1c2UgdGhlIHN0ZW0sIHNvIEknbSBzdHJ1Z2dsaW5nIHRv IHVuZGVyc3RhbmQgd2hhdA0KPj4+Pj4+PiB0aGlzIGlzIGFib3V0Lg0KPj4+Pj4+IA0KPj4+Pj4+ IFllcywgaGVyZSBteSBhaW0gd2FzIHRvIGNhdGNoIGFuYWx5c2lzLWJ1aWxkLXtlY2xhaXIsY292 ZXJpdHl9LCBoZXJlIEkgc2VlIHRoYXQgaWYgdGhlIHVzZXIgaGFzIGEgdHlwbw0KPj4+Pj4+IHRo ZSBydWxlIHdpbGwgcnVuIGFueXdheSwgYnV0IGl0IHdpbGwgYmUgc3RvcHBlZCBieSB0aGUgZGVw ZW5kZW5jeSBjaGFpbiBiZWNhdXNlIGF0IHRoZSBlbmQgd2UgaGF2ZToNCj4+Pj4+PiANCj4+Pj4+ PiBKVVNUSUZJQ0FUSU9OX0ZJTEVTIDo9ICQoWEVOX1JPT1QpL2RvY3MvbWlzcmEvc2FmZS5qc29u IFwNCj4+Pj4+PiAgICAgICAgICAgICAgICAgICAgICQoWEVOX1JPT1QpL2RvY3MvbWlzcmEvZmFs c2UtcG9zaXRpdmUtJCQqLmpzb24NCj4+Pj4+PiANCj4+Pj4+PiBUaGF0IHdpbGwgZ2l2ZSBhbiBl cnJvciBiZWNhdXNlICQoWEVOX1JPT1QpL2RvY3MvbWlzcmEvZmFsc2UtcG9zaXRpdmUtPHR5cG8+ Lmpzb24gZG9lcyBub3QgZXhpc3RzLg0KPj4+Pj4+IA0KPj4+Pj4+IElmIHlvdSB0aGluayBpdCBp cyBub3QgZW5vdWdoLCB3aGF0IGlmIEkgcmVkdWNlIHRoZSBzY29wZSBvZiB0aGUgcnVsZSBsaWtl IHRoaXM/DQo+Pj4+Pj4gDQo+Pj4+Pj4gX2FuYWx5c2lzLWNvdmVyaXR5IF9hbmFseXNpcy1lY2xh aXI6IF9hbmFseXNpcy0lOiBhbmFseXNpcy1idWlsZC0lDQo+Pj4+PiANCj4+Pj4+IEJ1dCB0aGVu LCB3aXRob3V0IHVzaW5nIHRoZSBzdGVtLCBob3cgZG9lcyBpdCBrbm93IHdoZXRoZXIgdG8gZG8g YW4NCj4+Pj4+IEVjbGFpciBvciBhIENvdmVyaXR5IHJ1bj8NCj4+Pj4gDQo+Pj4+IFNvcnJ5IEkg dGhpbmsgSeKAmW0gYSBiaXQgbG9zdCBoZXJlLCB0aGUgbWFrZWZpbGUgaXMgd29ya2luZyBvbiBi b3RoIGFuYWx5c2lzLWNvdmVyaXR5IGFuZCBhbmFseXNpcy1lY2xhaXINCj4+Pj4gYmVjYXVzZSB0 aGUgJSBpcyBzb2x2aW5nIGluIGNvdmVyaXR5IG9yIGVjbGFpciBkZXBlbmRpbmcgb24gd2hpY2gg dGhlIG1ha2VmaWxlIGhhcyBpbiBpbnB1dCwgaXQgaXMgbm90IGNvbXBsYWluaW5nDQo+Pj4+IHNv IEkgZ3Vlc3MgaXQgd29ya3MuDQo+Pj4+IERvIHlvdSBzZWUgc29tZXRoaW5nIG5vdCB3b3JraW5n PyBJZiBzbywgYXJlIHlvdSBhYmxlIHRvIHByb3ZpZGUgYSBwaWVjZSBvZiBjb2RlIGZvciB0aGF0 IHRvIG1ha2UgbWUgdW5kZXJzdGFuZD8NCj4+PiANCj4+PiBXZWxsLCBteSBwcm9ibGVtIGlzIHRo YXQgSSBkb24ndCBzZWUgaG93IHRoZSBkaXN0aW5jdGlvbiBpcyBjb252ZXllZA0KPj4+IHdpdGhv dXQgdGhlIHN0ZW0gYmVpbmcgdXNlZC4gV2l0aCB3aGF0IHlvdSBzYXkgSSB1bmRlcnN0YW5kIEkn bQ0KPj4+IG92ZXJsb29raW5nIHNvbWV0aGluZywgc28gSSdkIGFwcHJlY2lhdGUgc29tZSBleHBs YW5hdGlvbiBvciBhdCBsZWFzdA0KPj4+IGEgcG9pbnRlci4NCj4+IA0KPj4gT2ssIEkgaGF2ZSB0 aGF0IGVjbGFpciBhbmQgY292ZXJpdHkgc2hhcmVzIHRoZSBzYW1lIGNvbW1hbmRzIHRvIGJlIGV4 ZWN1dGVkIGJ5IHRoZSBidWlsZCBzeXN0ZW0sDQo+PiBzbyBpbnN0ZWFkIG9mIGR1cGxpY2F0aW5n IHRoZSB0YXJnZXRzIGZvciBjb3Zlcml0eSBhbmQgZWNsYWlyIGFuZCB0aGVpciByZWNpcGUsIEni gJl2ZSB1c2VkIHRoZSBwYXR0ZXJuIHJ1bGUNCj4+IHRvIGhhdmUgdGhhdCB0aGVzZSBydWxlczoN Cj4+IA0KPj4gSlVTVElGSUNBVElPTl9GSUxFUyA6PSAkKFhFTl9ST09UKS9kb2NzL21pc3JhL3Nh ZmUuanNvbiBcDQo+PiAgICAgICAgICAgICAgICAgICAgICAgJChYRU5fUk9PVCkvZG9jcy9taXNy YS9mYWxzZS1wb3NpdGl2ZS0kJCouanNvbg0KPj4gDQo+PiBb4oCmXQ0KPj4gDQo+PiAuU0VDT05E RVhQQU5TSU9OOg0KPj4gJChvYmp0cmVlKS8lLnNlZDogJChzcmN0cmVlKS90b29scy94ZW5mdXNh LWdlbi10YWdzLnB5ICQoSlVTVElGSUNBVElPTl9GSUxFUykNCj4+ICAgIFvigKZdDQo+PiANCj4+ IFvigKZdDQo+PiANCj4+IGFuYWx5c2lzLXBhcnNlLXRhZ3MtJTogJChQQVJTRV9GSUxFX0xJU1Qp ICQob2JqdHJlZSkvJS5zZWQNCj4+ICAgIFvigKZdDQo+PiANCj4+IGFuYWx5c2lzLWJ1aWxkLSU6 IGFuYWx5c2lzLXBhcnNlLXRhZ3MtJQ0KPj4gICAgJChNQUtFKSBPPSQoYWJzX29ianRyZWUpIC1m ICQoc3JjdHJlZSkvTWFrZWZpbGUgYnVpbGQNCj4+IA0KPj4gYW5hbHlzaXMtY2xlYW46DQo+PiAg IFvigKZdDQo+PiANCj4+IF9hbmFseXNpcy0lOiBhbmFseXNpcy1idWlsZC0lDQo+PiAgICAkKFEp JChNQUtFKSBPPSQoYWJzX29ianRyZWUpIC1mICQoc3JjdHJlZSkvTWFrZWZpbGUgYW5hbHlzaXMt Y2xlYW4NCj4+IA0KPj4gTWF0Y2hlcyB0aGUgY2FzZSB3aGVyZSAnbWFrZSBhbmFseXNpcy1jb3Zl cml0eeKAmSBvciDigJhtYWtlIGFuYWx5c2lzLWVjbGFpcuKAmSBpcyBjYWxsZWQuDQo+PiANCj4+ IE5vdywgcGxlYXNlIGNvcnJlY3QgbWUgaWYgbXkgYXNzdW1wdGlvbiBvbiB0aGUgd2F5IG1ha2Ug d29ya3MgYXJlIHdyb25nLCBoZXJlIG15IGFzc3VtcHRpb25zOg0KPj4gDQo+PiBGb3IgZXhhbXBs ZSB3aGVuIOKAmG1ha2UgYW5hbHlzaXMtY292ZXJpdHnigJkgaXMgY2FsbGVkIHdlIGhhdmUgdGhh dCB0aGlzIHJ1bGUgaXMgdGhlIGJlc3QgbWF0Y2ggZm9yIHRoZQ0KPj4gY2FsbGVkIHRhcmdldDoN Cj4+IA0KPj4gX2FuYWx5c2lzLSU6DQo+IA0KPiBTbyBteSBtYWluIG92ZXJzaWdodCB3YXMgeW91 ciBhZGRpdGlvbiB0byBtYWluLXRhcmdldHMsIHdoaWNoIG1ha2VzIHRoZQ0KPiBjb25uZWN0aW9u IHdpdGggdGhpcyB1bmRlcnNjb3JlLXByZWZpeGVkIGdvYWwuDQo+IA0KPiBBcyB0byB5b3Ugc2F5 aW5nICJiZXN0IG1hdGNoIiAtIEkgZGlkbid0IHRoaW5rIG1ha2UgaGFkIHN1Y2ggYSBjb25jZXB0 DQo+IHdoZW4gaXQgY29tZXMgdG8gY29uc2lkZXJpbmcgcGF0dGVybiBydWxlcy4gQWl1aSBpdCBp cyAiZmlyc3QgbWF0Y2giLCBpbg0KPiB0aGUgb3JkZXIgdGhhdCBydWxlcyB3ZXJlIHBhcnNlZCBm cm9tIGFsbCBpbnZvbHZlZCBtYWtlZmlsZXMuDQoNClllcyBmaXJzdCBtYXRjaCBpcyB0aGUgcmln aHQgdGVybS4NCg0KPiANCj4+IFNvIGFueXRoaW5nIGFmdGVyIF9hbmFseXNpcy0gd2lsbCBiZSBj YXB0dXJlZCB3aXRoICUgYW5kIHRoaXMgd2lsbCBiZSB0cmFuc2ZlcnJlZCB0byB0aGUgZGVwZW5k ZW5jeQ0KPj4gb2YgdGhlIHRhcmdldCB0aGF0IGlzIGFuYWx5c2lzLWJ1aWxkLSUgLT4gYW5hbHlz aXMtYnVpbGQtY292ZXJpdHkNCj4+IA0KPj4gTm93IGFuYWx5c2lzLWJ1aWxkLWNvdmVyaXR5IHdp bGwgYmUgY2FsbGVkLCB0aGUgYmVzdCBtYXRjaCBpcyBhbmFseXNpcy1idWlsZC0lLCBzbyBhZ2Fp biB0aGUgZGVwZW5kZW5jeQ0KPj4gd2hpY2ggaXMgYW5hbHlzaXMtcGFyc2UtdGFncy0lLCB3aWxs IGJlIHRyYW5zbGF0ZWQgdG8gYW5hbHlzaXMtcGFyc2UtdGFncy1jb3Zlcml0eS4NCj4+IA0KPj4g Tm93IGFuYWx5c2lzLXBhcnNlLXRhZ3MtY292ZXJpdHkgd2lsbCBiZSBjYWxsZWQsIHRoZSBiZXN0 IG1hdGNoIGlzIGFuYWx5c2lzLXBhcnNlLXRhZ3MtJSwgc28gdGhlICUgd2lsbA0KPj4gSGF2ZSB0 aGUg4oCYY292ZXJpdHnigJkgdmFsdWUgYW5kIGluIHRoZSBkZXBlbmRlbmN5IHdlIHdpbGwgaGF2 ZSAkKG9ianRyZWUpLyUuc2VkIC0+ICQob2JqdHJlZSkvY292ZXJpdHkuc2VkLg0KPj4gDQo+PiBM b29raW5nIGZvciAkKG9ianRyZWUpL2NvdmVyaXR5LnNlZCB0aGUgYmVzdCBtYXRjaCBpcyAkKG9i anRyZWUpLyUuc2VkLCB3aGljaCB3aWxsIGhhdmUgJChKVVNUSUZJQ0FUSU9OX0ZJTEVTKQ0KPj4g YW5kIHRoZSBweXRob24gc2NyaXB0IGluIHRoZSBkZXBlbmRlbmN5LCBoZXJlIHdlIHdpbGwgdXNl IHRoZSBzZWNvbmQgZXhwYW5zaW9uIHRvIHNvbHZlDQo+PiAkKFhFTl9ST09UKS9kb2NzL21pc3Jh L2ZhbHNlLXBvc2l0aXZlLSQkKi5qc29uIGluICQoWEVOX1JPT1QpL2RvY3MvbWlzcmEvZmFsc2Ut cG9zaXRpdmUtY292ZXJpdHkuanNvbg0KPj4gDQo+PiBTbyBub3cgYWZ0ZXIgYW5hbHlzaXMtcGFy c2UtdGFncy1jb3Zlcml0eSBoYXMgZW5kZWQgaXRzIGRlcGVuZGVuY3kgaXQgd2lsbCBzdGFydCB3 aXRoIGl0cyByZWNpcGUsIGFmdGVyIGl0IGZpbmlzaGVzLA0KPj4gdGhlIHJlY2lwZSBvZiBhbmFs eXNpcy1idWlsZC1jb3Zlcml0eSB3aWxsIHN0YXJ0IGFuZCBpdCB3aWxsIGNhbGwgbWFrZSB0byBh Y3R1YWxseSBidWlsZCBYZW4uDQo+IA0KPiBPa2F5LCBJIHNlZSBub3cgLSB0aGlzIGJ1aWxkaW5n IG9mIFhlbiByZWFsbHkgX2lzXyBpbmRlcGVuZGVudCBvZiB0aGUNCj4gY2hlY2tlciBjaG9zZW4u IEknbSBub3Qgc3VyZSB0aG91Z2ggd2hldGhlciBpdCBpcyBhIGdvb2QgaWRlYSB0bw0KPiBpbnRl Z3JhdGUgYWxsIHRoaXMsIGluY2x1ZGluZyAuLi4NCj4gDQo+PiBBZnRlciB0aGUgYnVpbGQgZmlu aXNoZXMsIGlmIHRoZSBzdGF0dXMgaXMgZ29vZCwgdGhlIGFuYWx5c2lzLWJ1aWxkLWNvdmVyaXR5 IGhhcyBmaW5pc2hlZCBhbmQgdGhlIF9hbmFseXNpcy1jb3Zlcml0eQ0KPj4gcmVjaXBlIGNhbiBu b3cgcnVuLCBpdCB3aWxsIGNhbGwgbWFrZSB3aXRoIHRoZSBhbmFseXNpcy1jbGVhbiB0YXJnZXQs IHJlc3RvcmluZyBhbnkgPGZpbGU+LntjLGh9LnNhZnBhcnNlIHRvIDxmaWxlPi57YyxofS4NCj4g DQo+IC4uLiB0aGUgc3Vic2VxdWVudCBjbGVhbmluZy4gVGhlIHN0YXRlIG9mIHRoZSBfc291cmNl XyB0cmVlIGFmdGVyIGENCj4gYnVpbGQgZmFpbHVyZSB3b3VsZCBiZSBkaWZmZXJlbnQgZnJvbSB0 aGF0IGFmdGVyIGEgc3VjY2Vzc2Z1bCBidWlsZC4NCj4gUGVyc29uYWxseSBJIGNvbnNpZGVyIHRo aXMgYXQgYmVzdCBzdXJwcmlzaW5nLg0KPiANCj4gSSB3b25kZXIgd2hldGhlciBpbnN0ZWFkIHRo ZXJlIGNvdWxkIGJlIGEgc2hlbGwoPykgc2NyaXB0IGRyaXZpbmcgYQ0KPiBzZXF1ZW5jZSBvZiBt YWtlIGludm9jYXRpb25zLCBsZWF2aW5nIHRoZSBuZXcgbWFrZSBnb2FscyBhbGwgYmUgc2VsZi0N Cj4gY29udGFpbmVkLiBTdWNoIGEgc2NyaXB0IGNvdWxkIHJldmVydCB0aGUgc291cmNlIHRyZWUg dG8gaXRzIG9yaWdpbmFsDQo+IHN0YXRlIGV2ZW4gdXBvbiBidWlsZCBmYWlsdXJlIGJ5IGRlZmF1 bHQsIHdpdGggYW4gb3B0aW9uIGFsbG93aW5nIHRvDQo+IHN1cHByZXNzIHRoaXMgYmVoYXZpb3Iu DQoNCkluc3RlYWQgb2YgYWRkaW5nIGFub3RoZXIgdG9vbCwgc28gYW5vdGhlciBsYXllciB0byB0 aGUgb3ZlcmFsbCBzeXN0ZW0sIEkgd291bGQgYmUgbW9yZSB3aWxsaW5nIHRvIGFkZCBkb2N1bWVu dGF0aW9uDQphYm91dCB0aGlzIHByb2Nlc3MsIGV4cGxhaW5pbmcgaG93IHRvIHVzZSB0aGUgYW5h bHlzaXMtKiBidWlsZCB0YXJnZXRzLCB3aGF0IHRvIGV4cGVjdCBhZnRlciBhIHN1Y2Nlc3NmdWwg cnVuIGFuZCB3aGF0DQp0byBleHBlY3QgYWZ0ZXIgYSBmYWlsdXJlLg0KDQpXaGF0IGRvIHlvdSB0 aGluaz8NCg0KQ2hlZXJzLA0KTHVjYQ0KDQo+IA0KPiBKYW4NCg0K From xen-devel-bounces@lists.xenproject.org Wed Nov 09 10:10:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 10:10:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440806.694999 (Exim 4.92) (envelope-from ) id 1osi2K-0002mL-Uk; Wed, 09 Nov 2022 10:10:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440806.694999; Wed, 09 Nov 2022 10:10:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osi2K-0002mE-Ra; Wed, 09 Nov 2022 10:10:24 +0000 Received: by outflank-mailman (input) for mailman id 440806; Wed, 09 Nov 2022 10:10:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osi2J-0002m8-Sz for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 10:10:24 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60054.outbound.protection.outlook.com [40.107.6.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b8d2034c-6016-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 11:10:22 +0100 (CET) Received: from AS8PR07CA0056.eurprd07.prod.outlook.com (2603:10a6:20b:459::25) by PAVPR08MB9747.eurprd08.prod.outlook.com (2603:10a6:102:31e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8; Wed, 9 Nov 2022 10:10:19 +0000 Received: from AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:459:cafe::aa) by AS8PR07CA0056.outlook.office365.com (2603:10a6:20b:459::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 10:10:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT023.mail.protection.outlook.com (100.127.140.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 10:10:19 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Wed, 09 Nov 2022 10:10:19 +0000 Received: from f52282481c89.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F4651B1A-EF6D-4FDF-888E-8D086F2EC046.1; Wed, 09 Nov 2022 10:10:13 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f52282481c89.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 10:10:13 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by VI1PR08MB9959.eurprd08.prod.outlook.com (2603:10a6:800:1c1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 10:10:10 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%6]) with mapi id 15.20.5813.012; Wed, 9 Nov 2022 10:10:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8d2034c-6016-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=kg8IFAVEfNfFCBG/bEU+zjizMh3chWlbwB24dhLh8ynufMIy1XJHoJLAoIumtwaTStr2omVwz5bV/NKMrTDn4Wh6y4l4MULyOKQJrB8efD+9ZA5D6G8tVc3ZpUxqRQ6I2sE6usYX1hcr4u54MTE7p2S8208M0x5kEcESsnelBuONfDpFt6UAC9hBIoboy9OBrtQ5kbKsSm6gLJwWTv6easJILbnbGEUxe/1345lMUVcmlJExAGxtcGaA0dO2DKTQ987I2FbuqlQBYXM4rQS3m49VtSTY720+cgpYOKZcIBUnLRE+B6ZI+XmESPHajUJ8iyhtjNoMaSi/9VH4wUzVjQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m7KOwHGezCjhItd6i0Hy/vun2FBA+HxEjTeZbTd+yUc=; b=Or2pRFfRnrLWGaIXla+tOouVOBQNfXu8JCBGg/RK5UrrsjvfocN0d09sD76sGZbROq+I0GIKInl3bvYQzbT8+XRnsIiX5PKTB3/LfW5wPLyjafueRNiZ3VXezvRviSYiD8azp4lDvsFAQ0c8o9r4wbNgMljQEgMvBU6fIpCMqbejrzSiUOJNKFsFM8QWV2ZBXBYSYYW2I6cRhjS0x6EKN6u2aYDSEeHm4y9W9lnXTZJwtB9TCAeRRDgLk5d2kX69Ddd90renFTYnkMjyHIgloxl4xo8oIJo9gF/IcT/WkRbn3TKSzhlebUiy0OxDt4a0h19FCBvjK66FEcUJryxZ6w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m7KOwHGezCjhItd6i0Hy/vun2FBA+HxEjTeZbTd+yUc=; b=YZfdI0bapwlMNk0bmUyYkk2+C80fSIY63efEAYsC9CpWFwZvP3PyegqM+0MEC+J0Utvk1lwPzCqB9PLN/s0qs8EjKDvxzs+2jg9Opjas8q38QOpAvSEbYz5m0ydCkQeS7x4ZvwNUvy2UbokqUVR3vQCzemUx2CIep5FXJ/myQ90= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gk1Ds5nUbpWQ5yiI417DXoHIiVaANzjZ2/ll0yB6ahlieemNPyNKODW6gE7Q+rWU6YDQ0GbeVGFg9RK845KltKYyO+t/DIVtJ49voRs+SyQ0HmCMk4IYZB6/qGq6j2Rm9xTkvQL9PhYkode/+tS9ZRqUzfp4snzFAOrwTo17jJ/3AAGerR/U/txJaP1Zciy7CfTzcSyZBL9p5N/yImJMNO8HC14314Gi9wku/4ysaCgxsUkpKtkBYEBq5MH0pfQBRoj5ueymmp8p0VPWUkjxjdEOB92oIZWrIuo44utar39Y1+QpRRO7zND9TpyxoWbxRMI2irFKOcNOYGo7hSEB/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m7KOwHGezCjhItd6i0Hy/vun2FBA+HxEjTeZbTd+yUc=; b=dHkF6Aie8b9aAPZqEwsLZ/Ot5tXR6M/zEb0s5zWnY3lDjcftCboGLi0oS1u+tLQok55Du11BV5aM1jg/iXz/v5C8WbVzJavQyhXg88BF4MQHzaTuSMsz3EzjSC/V2yDJL6ZWf9tni09tP1081/dUygk8k4WB8xCYhlk+Juw3IGJnaVswP5dJSkNLKs7SoTmHLWNNzXNx6ahUsnqaVtCsYeJ8cUyWbI6s4fffAARoD4ge9QAsItitwXlr38X3cecRi2gTnr1KWfTk3+WITUFMcIT4YN9BVQrrjrZYuHT6PpL+HlRt9oMFtQSfQ1hSnfeaF1NVB4xmoaI+Nl8qKd8hyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m7KOwHGezCjhItd6i0Hy/vun2FBA+HxEjTeZbTd+yUc=; b=YZfdI0bapwlMNk0bmUyYkk2+C80fSIY63efEAYsC9CpWFwZvP3PyegqM+0MEC+J0Utvk1lwPzCqB9PLN/s0qs8EjKDvxzs+2jg9Opjas8q38QOpAvSEbYz5m0ydCkQeS7x4ZvwNUvy2UbokqUVR3vQCzemUx2CIep5FXJ/myQ90= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v7 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common Thread-Topic: [PATCH v7 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common Thread-Index: AQHY5EtSdgmFSeaU8UGG/Ef8aqU5eq41XS4AgAEIj3CAAA1igIAACvYA Date: Wed, 9 Nov 2022 10:10:10 +0000 Message-ID: References: <20221020061445.288839-1-wei.chen@arm.com> <20221020061445.288839-6-wei.chen@arm.com> <64dfe9e6-8d92-8be9-c987-28d507ac617f@suse.com> In-Reply-To: <64dfe9e6-8d92-8be9-c987-28d507ac617f@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F892AB311CF3BB47855219407928B622.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|VI1PR08MB9959:EE_|AM7EUR03FT023:EE_|PAVPR08MB9747:EE_ X-MS-Office365-Filtering-Correlation-Id: f3e16487-6f58-4704-36a2-08dac23a9b29 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8xyATiqu6U9tR044CTcrDe6swQxXUsvED4k+iM+711eK0NQEjY6TDdbf6TbQghvKSnN0bGKbTSTiHDin5tVteicsaI9eJAJNMPef4OmNlD5Y2JZShYte08Vd2If+Ug0qAHhd8NhIL0718/wcWokNY7wH1VzE4GDtGZCWgzg0tMsFrLJURfxgZ7iWJLRx0Xd+qKReCHCItnfplewnjTWwWdk7kO1d0kaUfonANsPZAgFZ/pJ0gtFZbH1ojhkJrZBCkHVnqsX0u6vD2K/y8UUgrdxZNZw9/xQYhREruya3Plk17t2t25wOx9wxJbHcIitdC7SjG/qLi6Ghyhb+BrIYnDa18mtmASaeRQJXpnENKV9k7mh+KMs/oO1kyzZH/pqClM1feV9fT3JiI691rpw6pD1itaJ1FQv+YH2SOtpDPFNM0JHptR91Ogr1agdbX9WTuXWMTCwp8cRHGSfe6/JGYHVhMd3YvSG2ESGqcW4nvMvNNKC+IlaiBVsy+H8QBP1GnuZE/lw5AfsoIk99HQLEZLJgAM9tXuO73J8oI7wff5S8CX0OsiBaGmLFeyb0NHh1MaaoMzoFHRF/FktueujLtRXMqcDqQZFy1HDyH3CTngKnZUlZRGlfWH6FSYMcFi4fEXqqcLX38RSjtSobY6vbDuexw6aKe5XC4cdryFy0zivu6JhRsDlVld1FeoS1pcgrr2KQujvoQ/lVJ9Cc5yLTJ8M7ZhuCnPb/ZuetdYpCwJuppxEUfMDKRTgUnZ5Dws5u/ErQhdOCgL6zZVvW/qV2wQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(376002)(136003)(396003)(39860400002)(451199015)(38100700002)(66946007)(8676002)(33656002)(122000001)(86362001)(478600001)(41300700001)(38070700005)(83380400001)(66476007)(186003)(26005)(7696005)(66556008)(9686003)(52536014)(6506007)(4326008)(76116006)(316002)(5660300002)(66446008)(6916009)(2906002)(54906003)(53546011)(64756008)(55016003)(71200400001)(8936002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB9959 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 85ca0c80-36d7-47ef-6af0-08dac23a95c2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TUnnBMaxpasvpqkbSAb1BAGJ0pEkwqZthT5ABJj+/dIU9A+1PsoY+mRq5gqRSSZnTNhuwhSECWgfzrzpXZDR3ayB2bPb+rTuOYuYJtcpce9/jEwG1FPfgnWOgT5oFuCNcQrecYHfaO0csurpS0qmeImQqcVuSsuSoCUoLWH6RfxbZjp7YXEFYu6YpR8tmf05s6N8Cl3A5rN96I6NQBxMfLqWERYkyN0feScXHG8mYVwDdaYunCd3FYU/Kt7iPd8gxosvhHMoqRiVWTq88wbEeL9oGgbR3aUP15+ng3HkCVngZ6MrZvusLAjZdYL1rzX+j/R7D2CrzbVJ/dq6ADeQovavDUflMhC4SJ/4NSSyf9bcNjVvc7iJg2Mk62/R3M60NbzIHoangHN5Bb7A9GxxVYnP++Vt7E1qtkX5wvhXO7BkzrWRBm4l5sEgmhPmKEVpw2USN5nj6BOgqMiKbj0v4ehj50h36o/b1uvL3hp0qq4WYUFK5rdjKkkoA+dW8lnOAC6yLs2L8Ifp/nFA7EdjI2pb4CypcMzAZptERU5pnpPWigO9yNW6K2Y5/PDdDtvcoI14BZRP7kyDDjDD3pXWiUMpOG1iE0tp6C7b78WMWvK0q0iGBI38EAmQqfDgmmN3vm4GNlOXqT8j1deZO1W7er+ZY3nWZv4hdI+oovOpmrEqKzXa34oBv72LBJWfEwc/jiyDMcqUI1QPtOU2QWbnVclRc8B7hlbYbZeNCPjh98k9RjZRxymHtxsSLgM9PhHUCZlu/lDnNjglvG4MRwSzaA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199015)(36840700001)(46966006)(40470700004)(2906002)(478600001)(36860700001)(8936002)(6506007)(7696005)(356005)(81166007)(82740400003)(83380400001)(47076005)(54906003)(316002)(82310400005)(26005)(4326008)(55016003)(5660300002)(8676002)(40460700003)(86362001)(6862004)(9686003)(336012)(52536014)(53546011)(70586007)(186003)(41300700001)(70206006)(40480700001)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 10:10:19.2938 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3e16487-6f58-4704-36a2-08dac23a9b29 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9747 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDEx5pyIOeaXpSAxNzozMA0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBHZW9y Z2UgRHVubGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu b3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggdjcgNS82XSB4ZW4veDg2OiBtb3ZlIE5VTUEgcHJvY2VzcyBub2RlcyBub2RlcyBjb2RlDQo+ IGZyb20geDg2IHRvIGNvbW1vbg0KPiANCj4gT24gMDkuMTEuMjAyMiAwOTo1MSwgV2VpIENoZW4g d3JvdGU6DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206IEphbiBC ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPj4gU2VudDogMjAyMuW5tDEx5pyIOeaXpSAw OjU1DQo+ID4+DQo+ID4+PiBAQCAtMzQxLDE1OSArMjQ3LDE0IEBAIGFjcGlfbnVtYV9tZW1vcnlf YWZmaW5pdHlfaW5pdChjb25zdCBzdHJ1Y3QNCj4gPj4gYWNwaV9zcmF0X21lbV9hZmZpbml0eSAq bWEpDQo+ID4+PiAgCQlweG0gJj0gMHhmZjsNCj4gPj4+ICAJbm9kZSA9IHNldHVwX25vZGUocHht KTsNCj4gPj4+ICAJaWYgKG5vZGUgPT0gTlVNQV9OT19OT0RFKSB7DQo+ID4+PiAtCQliYWRfc3Jh dCgpOw0KPiA+Pj4gKwkJbnVtYV9md19iYWQoKTsNCj4gPj4+ICAJCXJldHVybjsNCj4gPj4+IC0J CQkJfQ0KPiA+Pj4gLQkJfSB3aGlsZSAoZm91bmQgJiYgc3RhcnQgPCBlbmQpOw0KPiA+Pj4gLQ0K PiA+Pj4gLQkJaWYgKHN0YXJ0IDwgZW5kKSB7DQo+ID4+PiAtCQkJcHJpbnRrKEtFUk5fRVJSICJO VU1BOiBObyBOT0RFIGZvciBSQU0gcmFuZ2U6ICINCj4gPj4+IC0JCQkJIlslIlBSSXBhZGRyIiwg JSJQUklwYWRkciJdXG4iLCBzdGFydCwgZW5kIC0gMSk7DQo+ID4+PiAtCQkJcmV0dXJuIDA7DQo+ ID4+PiAtCQl9DQo+ID4+PiAtCX0NCj4gPj4+IC0JcmV0dXJuIDE7DQo+ID4+PiArCW51bWFfZndf bmlkX25hbWUgPSAiUFhNIjsNCj4gPj4NCj4gPj4gLi4uIHRoaXMgdG8gYmUgaGFwcGVuaW5nIHRv byBsYXRlLiBOb3QgYmVjYXVzZSBJIGNhbiBzZWUgYSB3YXkgZm9yDQo+IGN1cnJlbnQNCj4gPj4g Y29kZSB0byB1c2UgdGhlIHZhcmlhYmxlIGVhcmxpZXIsIGJ1dCBiZWNhdXNlIG9mIHRoZSByaXNr IG9mIGZ1dHVyZQ0KPiBjb2RlDQo+ID4+IHBvdGVudGlhbGx5IGRvaW5nIHNvLiBBZmFpY3Mgc3Jh dF9wYXJzZV9yZWdpb25zKCkgaXMgY2FsbGVkIHF1aXRlIGEgYml0DQo+ID4+IGVhcmxpZXIsIHNv IHBlcmhhcHMgdGhlIGZpZWxkIHNob3VsZCAoYWxzbz8pIGJlIHNldCB0aGVyZSwgcHJlc3VtYWJs eQ0KPiA+PiBhZnRlciBhY3BpX3RhYmxlX3BhcnNlKCkgaGFzIHN1Y2NlZWRlZC4gSSd2ZSBpbmNs dWRlZCAiKGFsc28/KSIgYmVjYXVzZQ0KPiBJDQo+ID4+IHRoaW5rIHRvIGJlIG9uIHRoZSBzYWZl IHNpZGUgdGhlIHNldHRpbmcgaGVyZSBtYXkgd2FudCBrZWVwaW5nLCBhbGJlaXQNCj4gPj4gcGVy aGFwcyBtb3ZpbmcgdXAgaW4gdGhlIGZ1bmN0aW9uLg0KPiA+Pg0KPiA+DQo+ID4gV2hlbiBJIHdh cyBjb21wb3NpbmcgdGhpcyBwYXRjaCwgSSBhbHNvIHRob3VnaHQgY3VycmVudCBwbGFjZSB0byBj YWxsDQo+IHRoaXMNCj4gPiAiUFhNIiBzZXR0aW5nIHdvdWxkIGJlIGEgbGl0dGxlIGxhdGUuIEJ1 dCBzaW5jZSB0aGVyZSBpcyBvbmx5IG9uZQ0KPiBmdW5jdGlvbg0KPiA+IHRoYXQgdXNlcyB0aGlz IHByZWZpeCByaWdodCBub3csIEkgdGhvdWdodCBpdCB3YXMgYWNjZXB0YWJsZSBhdCB0aGUgdGlt ZS4NCj4gPiBCdXQgb2J2aW91c2x5IHlvdXIgY29uY2VybnMgbWFrZSBzZW5zZSwgSSB3aWxsIG1v dmUgdGhpcyBjYWxsIHRvDQo+ID4gc3JhdF9wYXJzZV9yZWdpb25zIGFmdGVyIGFjcGlfdGFibGVf cGFyc2UgaGFzIGJlZW4gZG9uZSBzdWNjZXNzZnVsbHkuDQo+IA0KPiBBcyBzYWlkIC0gcGVyaGFw cyBub3QgbW92ZSwgYnV0IGNvcHkuIFRoZXJlIGlzIGFuIChleHRyZW1lbHkgdW5saWtlbHkpDQo+ IGNhc2UNCj4gd2hlcmUgc3JhdF9wYXJzZV9yZWdpb25zKCkgd291bGQgbm90IGJlIGNhbGxlZCBh dCBhbGwuDQo+IA0KDQpHb3QgaXQsIHVuZGVyc3RhbmQgbm93Lg0KDQpDaGVlcnMsDQpXZWkgQ2hl bg0KDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Wed Nov 09 10:11:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 10:11:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440811.695009 (Exim 4.92) (envelope-from ) id 1osi3d-0003Mz-9Q; Wed, 09 Nov 2022 10:11:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440811.695009; Wed, 09 Nov 2022 10:11:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osi3d-0003Ms-6u; Wed, 09 Nov 2022 10:11:45 +0000 Received: by outflank-mailman (input) for mailman id 440811; Wed, 09 Nov 2022 10:11:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osi3c-0003Mj-2J for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 10:11:44 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c5cc7891-6016-11ed-8fd2-01056ac49cbb; Wed, 09 Nov 2022 11:10:45 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5cc7891-6016-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667988702; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=3MZ1/1SwF++hAOysPOIQibF28l1BFKEwuznY42N84NU=; b=El/tO3p1/vUHW7Lfz1cDcgC2V0tzRC5fDxHut6E0WYEOJJhow/bID02W FspG0+nCX2csSzfe/uySGupftLiHJlP/gbJ7un4nx8ArhwD4ieevIlmKT 6r87IDEWs4hegHvyJV1VQyvrJ1UPZKw1xOKl6MEMJnfRbBiASrS4BPgjt 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84459890 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:N2li56KJt9msVDFsFE+Ry5UlxSXFcZb7ZxGr2PjKsXjdYENS3j0Gy GAXDG2Fb6qLajbyfYokPNi/8UgA6JTTn98yTwFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wRvPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4tHG1Rz +MaCAkuRTPa2+G23oDiTNlz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLozkPmpgD/jdCdfq3qepLYt4niVxwt0uFToGIqJJoHbFZQN9qqej kLYz33eDBhECOKG8wCg8X6Go/HCnCyuDer+E5Xnr6U30TV/3Fc7CgASVFa9iem0jAi5Qd03A 1MQ0jojq+417kPDZsLmQxSyrXqAvxgdc9ldCes37EeK0KW8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq19L2ZsDezMig9NnIZaGkPSg5t3jX4iNht1FSVFI8lSfPryI2ucd3t/ 9yUhHIji6opkswr7oaQ3gmbgDKylMHPfhFgs207QVmZxg9+YYekYamh5l7a8etMIe6lc7WRg JQXs5PAtb5TVPlhgATIGbxQR+/xu55pJRWG2TZS848dGyNBEpJJVaRZ+3lAKUhgKa7okhe5M RaI6Wu9CHK+VUZGjJObgarrVazGLoC6T7wJs8w4ifIfCqWdjCfdoElTibe4hggAUCEEyMnTw 6uzf8e2Fmo9Aq961jewTOp1+eZ1mH9vnjmOHcGik0zPPV+iiJm9EOltDbdzRrphsPPsTPv9r 76zyPdmOz0ACbajM0E7AKYYLEwQLGhTOHwFg5U/SwNCSyI4cFwc5wj5m+x8KtI+xPkMyo8lP BiVAydl9bY2vlWfQS3iV5ypQOqHsUpXxZ7jARERAA== IronPort-HdrOrdr: A9a23:kCvC9aiTNVT7lMhxvd7eR8eryXBQXtQji2hC6mlwRA09TySZ// rOoB19726TtN9xYgBGpTnuAtjifZqxz/FICOoqTNOftWvdyQmVxehZhOOIqVCNJ8SXzJ8l6U 4KSchD4bPLY2SS9fyKhTWFLw== X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208";a="84459890" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Andrew Cooper" , George Dunlap , Jan Beulich , Julien Grall , "Stefano Stabellini" , Wei Liu Subject: [PATCH] docs/process/sending-patches.pandoc: add a tip about using --trailer to collect Acked-by tags Date: Wed, 9 Nov 2022 10:11:14 +0000 Message-ID: <44a0555f37251e57f0943ed4416013f047da40fb.1667988674.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This can be useful when preparing a series for resend and want to collect any Acked-by/etc. tags from the mailing list. It avoids duplicate entries, and puts the tag in the correct place (even if the commit has a --- line), and you get to see the result before committing (unless you use --no-edit). Signed-off-by: Edwin Török --- docs/process/sending-patches.pandoc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/process/sending-patches.pandoc b/docs/process/sending-patches.pandoc index 2e74c3b57e..90ac7b6cf1 100644 --- a/docs/process/sending-patches.pandoc +++ b/docs/process/sending-patches.pandoc @@ -72,6 +72,12 @@ after the patch was written. Do not split a tag across multiple lines, tags are exempt from the "wrap at 75 columns" rule in order to simplify parsing scripts. +Tags can be added on the command-line in the appropriate place by using +the `--trailer` flag (on a recent enough version of git), e.g.: +``` +git commit --amend --trailer 'Acked-by: Maintainer ' +``` + ### Origin: Xen has inherited some source files from other open source projects. In case -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 09 10:12:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 10:12:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440816.695022 (Exim 4.92) (envelope-from ) id 1osi45-0003rf-Jw; Wed, 09 Nov 2022 10:12:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440816.695022; Wed, 09 Nov 2022 10:12:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osi45-0003rY-Es; Wed, 09 Nov 2022 10:12:13 +0000 Received: by outflank-mailman (input) for mailman id 440816; Wed, 09 Nov 2022 10:12:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osi42-0003pU-VY for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 10:12:11 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f78e8f68-6016-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 11:12:09 +0100 (CET) Received: from mail-bn8nam12lp2175.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 05:12:06 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by PH0PR03MB6590.namprd03.prod.outlook.com (2603:10b6:510:bd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 10:12:04 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.025; Wed, 9 Nov 2022 10:12:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f78e8f68-6016-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667988729; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=9qSZl66V94H6iz3QC7K2DszNOKcn2TiAJeOzW0Ika1o=; b=Skz6H6nlDbTTrSKb/gHIHSFAGOIpbB8r8kw0wRLlzWr4Ap3vqk2GGYD2 doqr0lXlDFd+kymz2RpclPSuvfOlcDDySbDvn89ALoLpQ4k48P7Uiy2aD PEKXRoRrZ7Yro3/Odk9Pw+EN+QQIl45g3onApOwFptVCT3X3uqD/mu8Of c=; X-IronPort-RemoteIP: 104.47.55.175 X-IronPort-MID: 84459900 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kqzW06+K6LXIWVQymqidDrUDs3+TJUtcMsCJ2f8bNWPcYEJGY0x3x zZNCmCHPa7cN2byc9ojPdvlphkOuZTcy4c3GlQ5pS48E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKga5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklf0 acEBmgDSyqy2cbp3Zu4VdNOudkaeZyD0IM34hmMzBn/JNN/G9XpZfWP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUujdABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prr+TwX6qCdpKfFG+3sZpoUeilkAvMTc1S2OauN21jW6xY80Kf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwCGAzLDFpTmQAGcsRyRELtchsaceWjgCx lKP2dTzClRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85i8jVf5mGa+xy9fzSTf5x mnQqDBk3upOy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg= IronPort-HdrOrdr: A9a23:NiVrT6tSFxzIkVTvRQKWPq2t7skDeNV00zEX/kB9WHVpmszxra GTdZMgpHnJYVcqKRYdcL+7Scq9qB/nmqKdgrNhWYtKPjOW2ldARbsKheCJrlHd8kXFh5dgPM xbE5SWZuefMbEDt7ee3DWF X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208";a="84459900" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qxk0SBGx/Ld0DzCGzOLgKD0yPdKx/vxbWSThlZg5fUtG0toZeovZvpcvaBXvyaxp4qyIZivI0Pyt+/0Sh3ld35pgQbMN3D9WzFFno5Eb7X9rblJBxX/uIxTT570mEM/Lisax+NEUhHokP8/fnbP6tCtpsuB6L1WJDS7aE6L86fEVGGQ3+oAPfCZ+d/RIlrLDfpL0vpOEO1tJQ5fq1eTv4L5fbzBF6CcyU32rs6kZz6KRMHvw7WF+JHwXzM/2jOyZ6+qB7P6zihsGzWBPH+AOHl9o+XePB8NgohNZzOM/sXf4KcPoS1Jkgs+uH5TPyLqTMopqcH1ANZL0aibsaE1ZUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZvHwybfxsS/d38r0gvYyenMA2OtvdTDhqZl9pHKjHbI=; b=jTYyYOM9Sbn/98HhuV6e/nI0RW5WKP/Z+BYOgtXaBJFc3Bw++dFCNqy7qPqbZrbg7KdkzjpPZB5zcoiUO8ivoFoLhDYRxolin8N7Qtr5+nLN7eDdB0V213KXuR73wz4VDS1UoZMQrrJIfbiJGed2N4y9SscJuTreX2p6XIgyCFJ6zh2qNCHXTZoD1U74FC73gci0LuShzwcYuQeHL7km1Ol7Vnx8gDeNEXZhqe/Hn/9GjpuBJnYDlsnIarXSeWCMOmjMk0b5GZY/53EqOLoZ53CdEuobI19DWRiKOFooRjKyxm0r7Yl7K8VwM3mj2dbUbpz4TXbd+4b26uoxhW8Kjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZvHwybfxsS/d38r0gvYyenMA2OtvdTDhqZl9pHKjHbI=; b=kTnzztyasct9lqsBt2IMkGGIRdlJvDCJPHgBumbTDXsvNEK3DXGVD8llnr1Lw30sB76fqjj64TagXQiQoSyhm4BCuqXYGYGVHA3UJZC83XSEWdq86WOBruZmgKZnDMsl3JKcyPqBC70p5ryhtv/Yv9b1YCoIPUGHU1v0oj8DBrA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 9 Nov 2022 11:11:57 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Wei Liu , Edwin =?utf-8?B?VMO2csO2aw==?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Message-ID: References: <20221108113850.61619-1-roger.pau@citrix.com> <58d5e890-e052-47df-42bb-6cc84aedd4a9@suse.com> <76cde159-088a-3351-56e2-0cf14e9c8116@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <76cde159-088a-3351-56e2-0cf14e9c8116@suse.com> X-ClientProxiedBy: LO4P265CA0193.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::7) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB6590:EE_ X-MS-Office365-Filtering-Correlation-Id: ec051c42-b86b-41b3-bfc2-08dac23ad950 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 97WlfndpUmv5a+yKtnrSvASqXTziFrck0qyOo6pWIyUJz/a81dXSzzrvyd33+5Z4fvRihIXCesqBX/bGucsgtTvNXfb4p8oYurM+NsdTw7+KsyEiLj5yD52hr56me/LqQkRCANOD4UACfZly6sQMBKw2lCddhAHAFFPRHIO2E/nBuoE/kRvxiNDwwWpOsgY2qGHoL3XRB8X2CJ/iLHFpukfXDGYMfijkWIlam0zymVMwy1aT3E03a31TRoCazjjcUFjhcCB9LvNPDJ8SCT9ae0NoO+jp7q63mG+oK2eHiL+jbbaFvcjVDojcP4TcqET+AzqpN7mx1Mbag8HPxDX+Vd+P70v4kRfisL8vuGHXXYd2IxWQPHC+e2+tzPYGVrSb9y7FYfh1xqqDAimEecR+KqPtjOlKSNuLrJ8nw/B7pmHKfSOtn0Hso/9D9SoRuSBN/yXz9dqri+WtNCugBjieKbgwJLMKaSMU8pNLwmXd5SXFTJtaVIRmpYrXT2EM0hbItP0r68mM03VnRPpPFEefReQoov8/D9QwQz1m6jAGjGdA6WsuZk/393ZxXAM3Mbt19sUY8lkJ/P/xS8Np6W6EkJO/Jcz0d7maKwWruRhIlmthmjpylKRFLIUbU7G1JzTcoN2lZHAPIbkwFW3NgbQLrx7kDOquzJWm/zwuwrOm+RdZlf6quY/uWayt7Et4lqdtfh1lCVTgHKfhQeG9AwfOCg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(366004)(376002)(136003)(346002)(39860400002)(396003)(451199015)(66476007)(82960400001)(8676002)(4326008)(66556008)(53546011)(66946007)(316002)(85182001)(83380400001)(2906002)(41300700001)(9686003)(6512007)(86362001)(26005)(38100700002)(186003)(5660300002)(8936002)(6506007)(6486002)(478600001)(6666004)(54906003)(6916009)(33716001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1d6bTNwN3IxRGptR2taYkJBUVA0T1ZtMTBLQitpL1dFMVBIaFF1Tk05NlpZ?= =?utf-8?B?eHNhR0pMMVd0L3o3TDlRSy9xUFUzaDVrN3I3cW1vL3JrL1lDQkh6dm13N3ZS?= =?utf-8?B?dnZmVEVUNVdLNEZGZ2tnQWo3VDJJVzNwdE5iL2F0dk5ab3l0K1VKRlA4L0xl?= =?utf-8?B?c1VLU1BYOERpczNTR3VFNkx6dUFwNzJIMFh5dkt5TnNSbm1QMkxJa3R4U1R4?= =?utf-8?B?Ri9RNlloU0pyY2VibnpaZVNyTi9EL1ZsZ29aNlRrb1Z1LytZM01QYWtZc3Ux?= =?utf-8?B?VXlVZlAwOXI2QW9SU1dWcVpISllDZlp4M2RGbDBoVlU2VVhITGdEY1RHekdy?= =?utf-8?B?c25ZTGtrNGg4WHlRR1VQaUZiVmFCcmJBVWE5SE9PTmo5UEZXVS9NRm4xTkV5?= =?utf-8?B?akZNbDlNajJ2QmpOMDhEamRtMmdEZ1JzUU51WGY3Sk5TbTJyZ3BZQkVxMFJy?= =?utf-8?B?TWpDN25sVFR3UGdnemJEUEpUQkJzb3Q4VnNBblJKKytoanlQRlNDUWtwclV2?= =?utf-8?B?VkY4WG9aRExyS244TVZlZ3M3OWI1WW81OUMxMFk1cHB5R25pV3ZUYmp6NnBD?= =?utf-8?B?clFRZmNMYUNmbEM1ZHVrQTFEdGNxRUtYZGhiVTNHaDY0YVJKUW9JUHZiYmJs?= =?utf-8?B?TFFOYjdQR1lOR0JFdVNiTDNsVGV6M2JHS2ZIaUJpOE1lc01MbmZUWHNFZmtx?= =?utf-8?B?ZHJaWGR3dVkrSlpQblRqZlN5WjUrMVBxekJsQ1dJZ01ZQkJ6TVk1anZVOEh6?= =?utf-8?B?b2M3aW1GbUxzVUJCMGtUUEdVMytKeHdXUFNHV0dESEZOaStZdlVjQ05nNGVF?= =?utf-8?B?Zk9NbDQxM2ZTbGFFeHh6L1EzU2tNNE5yaWdPeGEyai9kbk1nSy84ZlFkUGs1?= =?utf-8?B?ZG5UdVhuOGxBWDIvZDViaGJGUlRJdk1wUUN3cE9pVGJnaDFHWG14dm4yTURq?= =?utf-8?B?Q2JxclQzaUtkMXJHdzhLQlpPYk5ZTnNKelB6bFpyN0wrcURVdHdNQThJeVM2?= =?utf-8?B?cU1JbGthNitpOER1WGdNZVNiZjF4eHk4eEdqSUF5Qzlqczh4S0pEN3ZaR3dv?= =?utf-8?B?S2ZqZU42VjFDanA2cWYyK0wyQ2hsdGo1TlBjakduWDFDVjB3cUIyeDNJZ2dh?= =?utf-8?B?MkVoTjl3K1NjdFc2S3p2Y3E1UzFtbXNtMnM4WVN0TWl5dEtuZGJ0TUNXZTln?= =?utf-8?B?YzNoMmRoMVI5T0VhMUQ2YWRGT1JSZVhiQ3Q1WWFQQ2N4cDk5czVtbGdvVWhO?= =?utf-8?B?bXQxTnNrcGFBN0RWNDlXbXRMbXk5dFY3WTA2U0JtU3lQZEs3NnY4eStlcWV5?= =?utf-8?B?cUlNQ1VtQ08ybktGbmY0L0NwQlpyTnFodFArUktHU0t2SnpLNERrY2tuOGp0?= =?utf-8?B?aFpKSHB2THFxblVMc3BZVlJxSXJ2UXloK290QTBBbTV5cmRtZW40TFRtNlht?= =?utf-8?B?eGdSWFd4Z1VnbEQzNzhobkJWTjM1TmxkVEN6cTFXK2tMUHpCUm9CUm1NSlYw?= =?utf-8?B?dnNyaENleDVjTFRZR3JRbXhrbFIzSTljb0JwTzIydlNrSjduWnpzSFJqOFEw?= =?utf-8?B?UjlES2FhR2piRTQ2VDdoV2ZYNHdpY2QrKzdxc1FjNUFidUFxa1h2SFF2c3By?= =?utf-8?B?cUNuZStiWHVwR0EyRHVBdjB0Z21oR0ZFQ0kyYzJYSDFnNktqa2xjRnFJV2dp?= =?utf-8?B?M2t2eWRiQjNGZHBLQlJONXQxRm93aHh0dC9Denp6VE1vc1l0MjRHWjAydGdS?= =?utf-8?B?M0ZxblhKWTlJazczMEtIeXY0OENYYVRSSUZpM2IxRW15dTltOHlMQTN3Szdw?= =?utf-8?B?b0I2QjhXbGtEZm1pQmhjSHFSNXNQOW9pclFSVndWYndhdVczcDBKZnZxUHpv?= =?utf-8?B?NllFN211VHAwSCt0WEVxbHA3OXdMMk4vZ0FjMXZUdnorUzJ2Z2pYaHBLTHYr?= =?utf-8?B?M1JRT3g2bWY4eEN6Mm9BVFdtamRmSDRYWGptMkZqaWtkdmxEWFQ3TUtqdFNP?= =?utf-8?B?bWorTEpSK2NTQTFnbjZEbVRncVhRaHFGeUc2b0Nhd2lnK2t1bk5vNjkwVk0v?= =?utf-8?B?bGhNZEtnSzNYY2J5bjd4Z3crblpGeTExdXdKNEMvNUljc3orUTRVQ1VrUG1M?= =?utf-8?Q?cpuyBRdlSGbVlu8OfwKzi+J48?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec051c42-b86b-41b3-bfc2-08dac23ad950 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 10:12:03.8362 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /aCbq7Js52JlRv4mXZDdSZb+6D2CUFOZ4gX0TeDv9X8GIKtVZ+C7lUlvu/EfWSxF3Mk6w3hyl2Wf88LMfvFSPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6590 On Wed, Nov 09, 2022 at 08:48:46AM +0100, Jan Beulich wrote: > On 08.11.2022 18:15, Roger Pau Monné wrote: > > On Tue, Nov 08, 2022 at 06:03:54PM +0100, Jan Beulich wrote: > >> On 08.11.2022 17:43, Roger Pau Monné wrote: > >>> On Tue, Nov 08, 2022 at 05:14:40PM +0100, Jan Beulich wrote: > >>>> On 08.11.2022 12:38, Roger Pau Monne wrote: > >>>>> Like on the Arm side, return -EINVAL when attempting to do a p2m > >>>>> operation on dying domains. > >>>>> > >>>>> The current logic returns 0 and leaves the domctl parameter > >>>>> uninitialized for any parameter fetching operations (like the > >>>>> GET_ALLOCATION operation), which is not helpful from a toolstack point > >>>>> of view, because there's no indication that the data hasn't been > >>>>> fetched. > >>>> > >>>> While I can see how the present behavior is problematic when it comes > >>>> to consuming supposedly returned data, ... > >>>> > >>>>> --- a/xen/arch/x86/mm/paging.c > >>>>> +++ b/xen/arch/x86/mm/paging.c > >>>>> @@ -694,9 +694,10 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, > >>>>> > >>>>> if ( unlikely(d->is_dying) ) > >>>>> { > >>>>> - gdprintk(XENLOG_INFO, "Ignoring paging op on dying domain %u\n", > >>>>> + gdprintk(XENLOG_INFO, > >>>>> + "Tried to do a paging domctl op on dying domain %u\n", > >>>>> d->domain_id); > >>>>> - return 0; > >>>>> + return -EINVAL; > >>>>> } > >>>> > >>>> ... going from "success" to "failure" here has a meaningful risk of > >>>> regressing callers. It is my understanding that it was deliberate to > >>>> mimic success in this case (without meaning to assign "good" or "bad" > >>>> to that decision). > >>> > >>> I would assume that was the original intention, yes, albeit the commit > >>> message doesn't go into details about why mimicking success is > >>> required, it's very well possible the code relying on this was xend. > >> > >> Quite possible, but you never know who else has cloned code from there. > >> > >>>> Can you instead fill the data to be returned in > >>>> some simple enough way? I assume a mere memset() isn't going to be > >>>> good enough, though (albeit public/domctl.h doesn't explicitly name > >>>> any input-only fields, so it may not be necessary to preserve > >>>> anything). Maybe zeroing ->mb and ->stats would do? > >>> > >>> Hm, it still feels kind of wrong. We do return errors elsewhere for > >>> operations attempted against dying domains, and that seems all fine, > >>> not sure why paging operations need to be different in this regard. > >>> Arm does also return -EINVAL in that case. > >>> > >>> So what about postponing this change to 4.18 in order to avoid > >>> surprises, but then taking it in its current form at the start of the > >>> development window, as to have time to detect any issues? > >> > >> Maybe, but to be honest I'm not convinced. Arm can't really be taken > >> for comparison, since the op is pretty new there iirc. > > > > Indeed, but the tools code paths are likely shared between x86 and > > Arm, as the hypercalls are the same. > > On x86 we have both xc_shadow_control() and (functional) > xc_logdirty_control(); on Arm only the former is used, while the latter > would also be impacted by your change. Plus you're not accounting for > external tool stacks (like xend would be if anyone had cared to forward > port it, when - as you said earlier - the suspicion is that the original > change was made to "please" xend). AFAICT XEN_DOMCTL_SHADOW_OP_{CLEAN,PEEK} are equally broken if no error is returned when the domain is dying. A caller might think the bitmap has been fetched correctly when that's not the case, as the bitmap buffer would be left untouched. > > This is a domctl interface, so we are fine to do such changes. > > We're fine to make changes to domctl which are either binary compatible > with earlier versions or which are associated with a bump of the > interface version. The latter wouldn't help in this case, while the > former is simply not true here. For Andrew's proposed new paging pool > interface the behavior suggested here would of course be fully > appropriate, demanding that tool stack either don't issue such requests > against dying domains or that they be prepared to get back errors. I still think we need to fix this bug in Xen, and then fix any toolstacks that rely on such bogus behavior. Propagating such broken interface is just going to cause more issues down the road. > Thinking about it again I'm also not convinced EINVAL is an appropriate > error code to use here. The operation isn't necessarily invalid; we > only prefer to not carry out any such anymore. EOPNOTSUPP, EPERM, or > EACCES would all seem more appropriate. Or, for ease of recognition, a > rarely used one, e.g. ENODATA, EILSEQ, or EROFS. I was about to use ESRCH, as that also used by track_dirty_vram() and seems sensible. > Finally I'm not convinced of the usefulness of this dying check in the > first place: is_dying may become set immediately after the check was > done. While strictly true, this code is executed with the domain lock held, so while is_dying might change, domain_kill() won't make progress because of the barrier on the domain lock just after setting is_dying. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Nov 09 10:23:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 10:23:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440826.695032 (Exim 4.92) (envelope-from ) id 1osiEe-0005qX-Ls; Wed, 09 Nov 2022 10:23:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440826.695032; Wed, 09 Nov 2022 10:23:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osiEe-0005qQ-Is; Wed, 09 Nov 2022 10:23:08 +0000 Received: by outflank-mailman (input) for mailman id 440826; Wed, 09 Nov 2022 10:23:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osiEd-0005qK-0k for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 10:23:07 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20045.outbound.protection.outlook.com [40.107.2.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d134d20-6018-11ed-8fd2-01056ac49cbb; Wed, 09 Nov 2022 11:22:08 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8235.eurprd04.prod.outlook.com (2603:10a6:10:243::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 9 Nov 2022 10:23:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 10:23:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d134d20-6018-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fxy+AFpiaOYJen5ptxwOCCrnqSx2m/qZ2ZJpqgBTYRCsiu0O+OX9ajPqJ40c/JB+1wVMdqokfHItPcg7y6Wx2Ry8IUTGqkzemXxXCMBeo5uDAsMRKmqcDFtlCZEb+SYhZZui7zmTWAj+RH2aRti3G+LXcPgkBxuv39kZlH094MIYFK4bqrdzzML1bWpMFMfOaSPdzaDTMsb2nhEpYOvD9FsukCScNR64oGK6kqMr8zv230WSzL2F3nTJQLYyjIvoYZPZjgdHKU9+qIbDKxHZNHdkS1uglePU8eoCG916jR9+OI2pK9vH5b/Zr7GlcRM0PMTqbkPS5ybyFUpJcF6Ruw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jRECr6tP4wvvHgzeKlxFk/LOVO7VZVdSy/dOcaq8ppA=; b=BdIJPvtN1yTMZyhn8fQJMOOkL1np8iSzczhtZ6/QvUEWRSLc0wR2bWaMBGSfZ+9ocz9cY16HYR5SiZmeq74exyGxM2QV8lZ7XQDJ5GZwpcYAxjNwP7AUAf44XRoXZsHywMIl5zsmtT75PBEZEfJc2Ru7hhgzI+CaCIzJoaeQZDSTDgH4A+lBTlteXHLJ95ZL2OlwztZ1yBFaLADQlchH+XgHc0B11eUTp4psjWuDtwz4W7JPbuWBQSG5JWUgIv49LZxN+B/BLn2bGzHtv6j/Ro1JVpNC+9RpJ5aZtDW2ccmoqMM1MJ3PmIgbycZXOLYLIF8rjtedcHNbWVwcafNogw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jRECr6tP4wvvHgzeKlxFk/LOVO7VZVdSy/dOcaq8ppA=; b=ERySILirB4/KMJOFHFrn1yd/TAT25V6GYF2d3SFlIdc8SvIjEXn1oZGwxwMhBClzHO+mYIr6PlXbrfAPATS7NfgEkbegpNP4oVFhJ8NZ7FWRAm/GvKuAmGgfO6COfjGNAXOpe3puZpnS/2zrF7AmD20Hb069xKfs9UNnXHn1t0iw2YgGN3H2VOSa84pJVnCx2RjraAWtOoYmupqEC+Ddv5lsWlrFpZT/sAUqbLGideXxzdY8p2sik6+9Ee2oiLbbmcXWDplIkHobJTSOzAAbSMOvLYlcaP+tWkM+3qhhgeyewFlhHhnOkmpXLck/AAyElcZ7QZ443DaTglQzvB/ukA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 9 Nov 2022 11:23:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , xen-devel@lists.xenproject.org References: <20221108113850.61619-1-roger.pau@citrix.com> <58d5e890-e052-47df-42bb-6cc84aedd4a9@suse.com> <76cde159-088a-3351-56e2-0cf14e9c8116@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8235:EE_ X-MS-Office365-Filtering-Correlation-Id: c68cca7f-d6e0-448c-8438-08dac23c6207 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 51F8b+6HOBau0DVQg9lugnD2fya2W0dQvjk1NBnI6dhoKf7i60J+cBT6fSNSXM1n995a1xBdmpM7/vhr2qG8FOgAdLBnDxLggguB7lOWV/49FFjbljvZ/1j4Lz79hazYLyUbRTUXIIlPCc2Ke9IXclR4a4sEajNWb3YG1yBRs8HYCfTCfOKYnPhemMtyavwkeGfe8O+MBi3nIpAxktIRZ4LxHLWo9HGHADUN5GJ8CcOjy3iYRBsDa7hOZ0jbwoErLMcmyNRKMLbA3RAEOH/DERptJgqYHC25G3aHf3msW5/wapW45pDEivHsk70Cwbb02HUTyIPKgvyg5AJ9LcmUBz+DVOlaww6fWzijIgQcZhJA2kofkuJEV+TlEuOtbOB8HKiPiUPIEm5w61VUzc7NlB1WNKmtxDttkuFKGPk/PDtYDzR0bms0uQMelhGsNF5DDrUJ0zAHU1UNqnf2gtbrkLOHVNHMs7139U7nhD6MmrskzoxxiGCTfzwA73yneVK/15SuNpBazY5DaA7+OTBmGjWLV/vOc2exscQlZIkmaCNzz3hvnSO6KCay0qH9zD3aEF+m9qlqIzLvT1C8S7a8gWdobanDdOcefohSRrPKtMpU41Mhj3Sy8uqmc7bTg98vEFn40boWNuzu1elAtbptKL/Kc48c3auI8EUUlu6K9ZpX7lMwOevya7oTQDH/SQ0EHpbtphmW/uNTT+J+y1v8c4WV94bH78YjMsTE3zQu/nSozeSX2d0IXJB0PFYDVSCJW7069rUChv4GiNB8YEatcy7XqIA6P8L26i408fnfC2I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(366004)(346002)(396003)(136003)(451199015)(31686004)(86362001)(26005)(41300700001)(6512007)(478600001)(38100700002)(6506007)(2906002)(36756003)(2616005)(186003)(8936002)(8676002)(5660300002)(4326008)(31696002)(54906003)(66476007)(6486002)(6916009)(316002)(66556008)(83380400001)(53546011)(66946007)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkNUc1V5NWVpaE5IOW5aN2pCK3pwNkJxZ1V0WWc0M3BHczZSK1BSMDNzQVJZ?= =?utf-8?B?Q2drR2d1QzBXd1ZxZUkzR3p3SEZURmlnQWZkbEVIUmVCQ0xQRy92eHU5SHZO?= =?utf-8?B?RmFEOXozTE9HMGVLWStwUUpYeHZBRE1Cd0hyaXhUMzlFb3FxbU9aM2MraWtV?= =?utf-8?B?Wk4yU3J1R2xRa2Fua2ZvTFloZVZIZXgvN1QyTUNPazk1KzBnOVNrZ3ZwaC84?= =?utf-8?B?Wm1xUkhxbUZEVDkraWhlcU93Nm1XcUIrRmRLeFgxNEJqQmxTTHdUMHkrbFZJ?= =?utf-8?B?SFpsVm1HQmlQUTZFT294ZzNuVnkzOWlBMjhvOEhqUUViRTcrWHNSaWc0NUNS?= =?utf-8?B?WC9yOUxsVExHT2t0a2FLcko0TkxVWit2UkFxL3BYVFlrckhjalBvcjRLUm04?= =?utf-8?B?Z1Q4SWhQeTBTcVQzbGtDazNqeC9NL3IwTDJ2OG1ESHp2dXlkR04xcDQxa252?= =?utf-8?B?bXJONXFwOVN0L0o5a0xsODBhZ1loZ1hzZWxGOTI0VVZVT0JJSmlmeHpiejdl?= =?utf-8?B?MXV1M3ZyRk9haXpiUkZmR0p4ODFFaTdnSnNLcHdYSmNYWDdKK25wdUlFWkFQ?= =?utf-8?B?RGQxZDMrQUtDK3UvVWVoaUFvR2NTbVB3ZnJnWlV4OVNISTlPcGYyOTN6VStT?= =?utf-8?B?WXY5bDByQUtzck4rYno0MG1UWXQ1a3E5TmJkVUlBWXQxak1uN2duNE5kVlpH?= =?utf-8?B?Y0pOWXhBbllIN3RqeWJud21kUWd4WnY0U3dnRTVrSWN4R2RqUllZUXVtOHBO?= =?utf-8?B?Y1gwNTA2QUJ1VHBGaUpWbGdqV1MxV2NWMVVzcHU0eU16R3NGZEEwT1hxYzk1?= =?utf-8?B?UVc0VERsOGVpbWFSRUFGOS9ZdytSN3hHL2FuVUhJVXM0OGdhVCtXMDNCbFlx?= =?utf-8?B?aSsvd3FiSUdPZHRjeHhsNjN0ZjZVK1ZXRG1iMHVqOXY1dkVpOGh4SlJJVUln?= =?utf-8?B?Vi9QK3dyaVViUWlnaU5PWnNwV01aa21vTlJQdlVldVFNYmdnVXgzRWF6NVpN?= =?utf-8?B?ZnFYNjdCMVRxT09XNkxqUll2M3NNSlNMc3Q0QU13b1lhL2U5b3Y0RThZaHBa?= =?utf-8?B?Q3JSMFluaXFtYVI2VmRuazFlVjVvbmpKR3NKdDZWMndzNTZWb1I5dFBLNk83?= =?utf-8?B?RGY2Y3l1R0FValIxUVIzT3RHSnY2U0JpQlY0Nm9mdnFlakE1bStxczljVFo3?= =?utf-8?B?MUFxd1cwSUI0bTlXWWtTY3ZXM3p3RXhxM1lrZWwxVk80VTRIMk5yLzN1OXJi?= =?utf-8?B?NVFNSHhzUDB3RUllK1VrOTUxa2g2VHZBbERRY0JzZDVDSXlJeHljZ1NzYXh1?= =?utf-8?B?VVcvbTJNYiswLzdrMi9ud2p1VXJiVkk3SzRyS25LUXFKQ1RvZS9aWGMvbVpK?= =?utf-8?B?YTFkb3NDSG8yN0pZRWgwWk5kYmtKRVhwQkRPUEtZY1VzaVU2eDkvUFhEYmE3?= =?utf-8?B?clk2YUwxZDVTWWM2YlNkRVh2V1g2Y2Y1WWhNRzJzcjZFOGJyUHk2THdSbisw?= =?utf-8?B?MG1nTk5Ca1NTcVpCUndMNkNwSFdwL0pwVVlvMllBRjdNaGk5RVpDRzlOZVRE?= =?utf-8?B?RDBtbjQvTUdLSnNGMWk3LzhUMlRkcWVQc0lrNlZDVjMvQkdnRnhCMnhmeFBv?= =?utf-8?B?UDNLVUV3UFdMMDhpYWNXaitEakx3Yng1UmlRMGRBeGFmaEt2L3ZTbEJTSDFO?= =?utf-8?B?am01TmJkeXBuQjV1akJ5RlB4YW5yeC91Y0xFM09mSCtmTVRPbmM0aVVXSmdn?= =?utf-8?B?LzNESHVOQTlTaFAvZitMRklqa1RaVm9oVVF0Uzgyb0lScEE5VTF3enZZL2I0?= =?utf-8?B?aG5GSklUSjd1bjdSY0JiaE5xK3E3bU4wcFJCMzFSb21GbnBPbVJtLzA5cTU2?= =?utf-8?B?b3VpZWVVK2w2elZweFdYK1U4c3hFNTBiaFRIWGt1dW1EYXM4cFdDRngrZk1w?= =?utf-8?B?SkRwak55ajRVNTE1QUgxWXo3OG02Y1VDVng5R3ZWRldzWHg0aWdma3d5N1Yz?= =?utf-8?B?SEFvZmdzb2tQaURuQmUzZEl2WnhrbzVFT3BIdXo0ZWdObUhZeU5JV2FKRU1p?= =?utf-8?B?T0ZUT1didWVwRW9uVVcyd3dSaDhUVldQQW1jOXpxOThmMVpaQTRZOXVFd05a?= =?utf-8?Q?8fmEMNj8jwsk+9KbekC8ut2t7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c68cca7f-d6e0-448c-8438-08dac23c6207 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 10:23:02.7644 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sFWuIj/cM0cvF/hp2bRp61ZN3dW8JN7N87bRxwBGnL1pjHoRVnkY/L6JTKS/ScUk1oDzcRG+aHgond6d4e8IZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8235 On 09.11.2022 11:11, Roger Pau Monné wrote: > On Wed, Nov 09, 2022 at 08:48:46AM +0100, Jan Beulich wrote: >> Finally I'm not convinced of the usefulness of this dying check in the >> first place: is_dying may become set immediately after the check was >> done. > > While strictly true, this code is executed with the domain lock held, > so while is_dying might change, domain_kill() won't make progress > because of the barrier on the domain lock just after setting is_dying. I guess I'm confused now: This code is called with the domctl lock held, which - as said before - is a questionable thing, for serializing things more than necessary as well as for holding this lock for excessive periods of time. IOW I consider it wrong to depend on that in paging_domctl() to synchronize against domain_kill(). Yet indeed that should eliminate races at present. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 09 10:35:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 10:35:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440832.695043 (Exim 4.92) (envelope-from ) id 1osiQv-0007xZ-Qy; Wed, 09 Nov 2022 10:35:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440832.695043; Wed, 09 Nov 2022 10:35:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osiQv-0007xS-Mh; Wed, 09 Nov 2022 10:35:49 +0000 Received: by outflank-mailman (input) for mailman id 440832; Wed, 09 Nov 2022 10:35:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osiQu-0007xI-B1; Wed, 09 Nov 2022 10:35:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osiQu-0002Fu-4u; Wed, 09 Nov 2022 10:35:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osiQt-0006Si-SU; Wed, 09 Nov 2022 10:35:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osiQt-0002Va-Rz; Wed, 09 Nov 2022 10:35:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kS236WWseesSL8pX4gmdFREFGDdPJf9+/SlXL6u3CIw=; b=iMeE1aufsbS+3epYIxn2+v3P4z jIIYepSHNNnvbSS3TKkcVkNDyxKEZYzRXyoH2Pgw2QY+wG65OrLbvuKm+HcxNp/8n6S/TBVYp6aKZ Fj4Nh4XT4sxbIpqXxr2wl06C0twQV0U3+1r1940sKczVgLkxOM+0OUFYHteH/DwNZ9eE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174681: all pass - PUSHED X-Osstest-Versions-This: ovmf=0be81a4d83810cdb018d293bc264f489e7664043 X-Osstest-Versions-That: ovmf=6c1a4a376e97800c555dab9ca9d9651a5676d231 From: osstest service owner Date: Wed, 09 Nov 2022 10:35:47 +0000 flight 174681 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174681/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0be81a4d83810cdb018d293bc264f489e7664043 baseline version: ovmf 6c1a4a376e97800c555dab9ca9d9651a5676d231 Last test of basis 174673 2022-11-08 15:40:34 Z 0 days Testing same since 174681 2022-11-08 20:43:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael D Kinney Wei6 Xu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 6c1a4a376e..0be81a4d83 0be81a4d83810cdb018d293bc264f489e7664043 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Nov 09 10:36:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 10:36:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440839.695053 (Exim 4.92) (envelope-from ) id 1osiS3-0008VN-4X; Wed, 09 Nov 2022 10:36:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440839.695053; Wed, 09 Nov 2022 10:36:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osiS3-0008VG-1k; Wed, 09 Nov 2022 10:36:59 +0000 Received: by outflank-mailman (input) for mailman id 440839; Wed, 09 Nov 2022 10:36:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osiS1-0008V8-Lf for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 10:36:57 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60043.outbound.protection.outlook.com [40.107.6.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c866452-601a-11ed-8fd2-01056ac49cbb; Wed, 09 Nov 2022 11:35:59 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6796.eurprd04.prod.outlook.com (2603:10a6:10:11e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Wed, 9 Nov 2022 10:36:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 10:36:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c866452-601a-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Scww013+5jR8FY/qM1WH70RA6J8D9J7We/yIkggbJOGysLDSim+zkMsXd2apwM+HAISG3eAhyOooRAWMeAjc6iK/Oi1mBNroT/gu6FNeJdpyQNToUcNbWkupQHKe9niVJ9VmcRUASvG4N3ItG3B6XJu6erh0mJJWyIh914Qdy/eR5TYhUJphxIqiUnxaM0ZsmptgUCuBaSamU1VLh5VkZpLXdAeL6PHZ6BvrEO04R+ybDaLgv3HwC8hk6MOVeS7fXQL34UK78wRzm3TXCGHuUVJg5i+45IcURThDC2n+D7bJe7Ps1IDnLJu+Vq43rcPfJRvLbhloYuEYbGELGr7TQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k3CciVVFxvhaE4JiL1O/jcQmnq5eVGuRo4g7hgbIJoM=; b=CARrygpLgXOd00ckXkqZaeYgJjhMY/spP/GafGEwqxVZ3v/OlIYaFpAG+V3v08kBA3fsRslOHLSDe6fGNCBFfolYJ9hwfw0syzuTii0NKcHs3Xee11elA7Fpcd1XTR7vQk14DZtrQIRj6a9yJBs58JRPrT+Bzd1joBH16fN9N1nYKRdWwXsA2ApRo8O2nxWxfaDYj3YeJE7+UHBhsxuOLF3gSg8Qn0e+PENFWJ6/SG9NPkM4zszg36bT3uNh2LkkKMLKoNgdud1X7PzI2hX8lGyAF4lATJquHhak6HFtDBjotR1VAFqlBeBBZFqUtpu9ucIOwe0DJUT17An8doWzxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k3CciVVFxvhaE4JiL1O/jcQmnq5eVGuRo4g7hgbIJoM=; b=Q6/bWO5/EyQt9tfXNBPULevukaSc3/FituOz860+BKa7l5yG3/rBv0/GTfxlAoWIMTK8HXai0NPM2DELjsFgVQMG+r6js6w3G6Z4Q4Tr3oyO2ZfnHBeJ2ML0jbp20YXydA0uA9hrXZHShjFTz1wrgQZbwxLMJ1w1U1hKecbVzn9P7GTYjks9VuIUDQeP0j7ajJsgHXEzPLIsFHQw753CxFSL1Knxt8XyOaP8ua7bEyh2pdJ5+07RGkCjEU4/wQp48sCLclAi1NX8OIbL2E5vn5UWVadxm36GSkaC7Bds7B7v4qVcpI46rUxdbRBw10R3c43fke6mr07u7CSCrEobAQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 9 Nov 2022 11:36:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Content-Language: en-US To: Luca Fancellu Cc: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> <7d56c33d-4b03-9aa1-6abc-45a8ad41caca@suse.com> <2E0BFEFC-5BEE-4F8B-BD9E-94CB9A5B2BC9@arm.com> <9CE2A214-2D64-4BEC-A78B-393BF7AEDD9D@arm.com> From: Jan Beulich In-Reply-To: <9CE2A214-2D64-4BEC-A78B-393BF7AEDD9D@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0155.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6796:EE_ X-MS-Office365-Filtering-Correlation-Id: 0db5a978-348a-4450-5490-08dac23e5190 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: blgLiwlpBb+6PAx45RVMHZUaYK63j5n+KPcWFhef9usUP6TSdTfsrsnR8gL2jM+e9fZduu4cP6bGLSa8rSaBf5WC96OABYrh9MleG8fy/vlC6RtUF7dQvu/Wsi5e9FlBjqUsi9h05hrrD3KECS4jxQbRJa8PlZLngp3LFpRSpYDqCmRzLAjkd39gqp4WGEQWYomOUFXC8SwE7R+cap7Bd1NQtsjjgchVsvpRLpuvhgYYobXpGGTeS1+rIORKzqgRnQN6CZaifLgvVipC765jBQY85tpTIT4KkPQe4H/gZvVeB0LYJR2MqcXrMo7Y/EXPnjiNKPsl/wssi/z/xqg4VzKrRDP0sIEVlAR5ouSHRuAZSI3907huqnIP9m20ZGZoXxvb2V4s62A95HJFypvAByf7NvzvOeREmx6kppLN0wOEifcjAMvxgdp0ttFO8hzwMuOzqyzc9JWcBHr04WCJn5cfYYhL4UwI+4stjf6ptR/rZN/2mUmqJpx+xKGQHrcJbWARHXfKadCqsKMElA7+QaCtmS9YKhVAeJE9pmOXOlLmfxi0d5e7rcReM3XBzgDaD7EZEIMnrpJUlvR/9KSrWVb88SoLVWd3bg+VOknYKK2Ahkh/ZeQnWMMKaFMPD167EYVYJfSCNUHU//Fzgb0LcdTLLHM05Zhwtz2h1xeNL2tMFlj/CoobjHBo/nJaYZgEIdGDyIgHE1CmXSU+PxJ9BxhI4hANQK4Jeh/GB4rylNpVkn7ziVB/4Dxg77nh8X/797leoFYk0iHS7eUVX8EoxQrDP3Idbru7v4fFkIO6tD0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(396003)(346002)(366004)(376002)(451199015)(36756003)(31686004)(38100700002)(31696002)(86362001)(5660300002)(2906002)(53546011)(186003)(6506007)(83380400001)(6512007)(2616005)(26005)(478600001)(66476007)(66946007)(66556008)(54906003)(4326008)(6916009)(6486002)(316002)(8676002)(41300700001)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3cvdDlra0N6R3UycUtZMjlFOGNjK2F1RXhOS1h0R3M0QlgvTXc2ays1V1gv?= =?utf-8?B?bkxPdS9OcFIwbmlpQXFwMER6MDVmVnVKVXJMOUh4SFJXcFhESE9CanlwMUJI?= =?utf-8?B?cnoxNyt3cUtVWE9hMXE2WDc2VGlGT2VpN1YwU3BjdnlWMEpBWUxEeHdYMU1w?= =?utf-8?B?RE1oRXo0eDdXMXA3NDRCUWdJbnFLZHBkbmMxa21sQ1UrZ2tzRE9xSS9lc0ZQ?= =?utf-8?B?MVR0ZFFOQnl1UUZEMUo2MzdVTVNibW1lWkQ2VkJwU2twV2sxUjd5OVYzVzQy?= =?utf-8?B?d2xYVmxVM2VkVFJFZFFUY0FZY3JYT291YVdMdWRoT2o4YUNFd0J6TUx5UGhi?= =?utf-8?B?bGQyVzAwcW5Qd3c4WUwrTzJnNk4zMHRma015Y0x4NGNhMExkU2hvamN3aVNr?= =?utf-8?B?Q2lZMlVUQW4wNVFML3JNbzN5aVBGaUpObEdIbDk4cnNyU1ZzRUZSTTV3SjZB?= =?utf-8?B?LzVhYW51dlhnT1lmNFc0anI4MW5DQjdvY2FRK3VaK0NPenE5c29lWWd4clVt?= =?utf-8?B?R3pUZmwrL2lJYVlDQ3BmM2VGUGkveEhpMk04Nmh3ZC9lUTlubnZWU3Uvblkv?= =?utf-8?B?d2pFT2lqbG0zaEVYV1JmNG9rVk1Lc09jQ3VLSDMvN0N4U1c3c00yaGN4dGJ5?= =?utf-8?B?ZUI4YksvdW9YT285dEREakVZOUtiTzB4ampzOUUvOWFOcys5MFUwT0RONXBS?= =?utf-8?B?aHJoL0NZRDNQbWQ1Y1Fib3dMT0NUSVRqblA0RW1CcDQ1V1NWTEp3dmdCV0lW?= =?utf-8?B?cjArWUNiWktCWDdNMElVTUZOWmEzMjFIZVA4ZnNpVTJkak9XbEVNYjVFWW5T?= =?utf-8?B?TlVoUkVobDN5TFFUTXo4UWdkTlJRdlVmM1p6NUdtbTNnaVlodWdaTlpPUHBu?= =?utf-8?B?VXJtZ3NybmhSOHRPYk5qMTFvODVjWmo1d1FNN1FobEVjODVJVXY4SUE2RVZs?= =?utf-8?B?UEhSaitTd2p3VUhJWVBCZFkvOTRIOWo2KytsWC80ZDdzYVFueWxOdnBKTTlZ?= =?utf-8?B?U3c4OU93RzAzVURnRldEUHoxVng3cnk1YlFod05HWFc2eVI0NXR1VG5SQUg0?= =?utf-8?B?UmprcVB6WGxRaDdsVFV2Y2JPZkJQV0VVWEVNYlF0U1JOSEZDUGVUY2ZlRnFv?= =?utf-8?B?Zm4zanUyODJ1S0FVRms2QkI2NStmeE5lUURwc0VnZ2VVaGtSaWg3ZitSelZt?= =?utf-8?B?Q0hEaDA2RmtSbzk1QzEzazNLbWxyMzFpRTVnZ3lPeEpWUmJ5SUh0aUIyUUJz?= =?utf-8?B?a0k4eUtHdmhPM1VuTCt6aHhrc2cxbFZPWWs2RXVHL0kySk9JUHNBeFNueFR2?= =?utf-8?B?MXR2eEdCaWwyT0RTcnI0TmVJYUdmQjNWZHdWZTVnYnhsdnM0QzI1NnpscERi?= =?utf-8?B?TzlDVFRiSWp0VVRyQXVRUUFlT1hSRlZvalFtQVlFbWx6azdTVXlMRlhXbzNF?= =?utf-8?B?RXlYNDVVcHM1WVNmTFJ1cG12T0hTQlRaZEdyaTgzeTVIWkFJOWQ5MmFlR2N5?= =?utf-8?B?ZXNVRFhQS0JsRDhCaWo0eHRwNVJOWVh2M0hENjQwQkNoSXVnVGJCT3FpeDR5?= =?utf-8?B?c2YzdGp3eXNzQVpvUllFWGhqQStabk5sa3RFQ0dsU2U1bytjV0tES0taUkd5?= =?utf-8?B?RXcxMkpvZmZJeEpQMVdiQnAzYWVGb2xVeUJFdUZ1Vm9lVGpKMVczc1Y3RmNY?= =?utf-8?B?QldrUnVlVHVjV3FUaVhwbGlYZnJ2UGE4cEJzby9oaVhwVURabStXM01GSVox?= =?utf-8?B?OVp2YnBiQi9jWHN3czIwM2pLK3lnUWdlbDJEY3pnSUpwN3prdzRRQjlUaWxr?= =?utf-8?B?UTZLbGJuVnZUblExeWtJRXhDZlozWkk0ZEh2MDVETlFCbXN4bTlib2pvanlw?= =?utf-8?B?WlU2YWFwNnZ3Sm5abXpNM3kxbzYyVHRQcWNYVnFzWWtmZWswcmNrTUZpOW1q?= =?utf-8?B?NjVGQll2TGFyeG16eUJnbUdBaHppV1l4cHNpczFrRkhVSG0rUEdvNTU1TnFX?= =?utf-8?B?TG9OYmNaTGJpZmJndW1hYTVVS2kwakxoZDFXVW1GK2F2Y1ZrdDRkSEhwdWJ5?= =?utf-8?B?STB1QjFtYjlIME0ySWU2TmJoQzByVTBnSEc0R0M0NElEWXBIc1JudXZJcHd4?= =?utf-8?Q?04Nq4ra4OnmGP0BV17cory1t+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0db5a978-348a-4450-5490-08dac23e5190 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 10:36:54.0083 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qAGqDkJ1TyUwt/B2yiHzUlQhtBFJutW3IVekEss733gQMYJ5TAL+o01QJrxvx8cWT7k3HxfkGSKM1rDpSRDG0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6796 On 09.11.2022 11:08, Luca Fancellu wrote: >>> On 07.11.2022 11:47, Luca Fancellu wrote: >>>> +Here is an example to add a new justification in false-positive-.json:: >>> >>> With already present in the name, ... >>> >>>> +|{ >>>> +| "version": "1.0", >>>> +| "content": [ >>>> +| { >>>> +| "id": "SAF-0-false-positive-", >>>> +| "analyser": { >>>> +| "": "" >>> >>> ... can we avoid the redundancy here? Perhaps ... >>> >>>> +| }, >>>> +| "tool-version": "", >>> >>> ... it could be >>> >>> "analyser": { >>> "": "" >>> }, > > About this, I’ve investigated a bit and I don’t think this is the right solution, it wouldn't make > much sense to have a schema where in one file the analyser dictionary key is the tool name > and in another it is a version (or range of versions). > > However I can remove the analyser dictionary and use this schema for the false-positive, which is > more compact: > > |{ > | "version": "1.0", > | "content": [ > | { > | "id": "SAF-0-false-positive-", > | “tool-proprietary-id”: "”, > | "tool-version": "", > | "name": "R20.7 [...]", > | "text": "[...]" > | }, > | { > | "id": "SAF-1-false-positive-", > | “tool-proprietary-id”: "", > | "tool-version": "", > | "name": "Sentinel", > | "text": "Next ID to be used" > | } > | ] > |} > > This needs however a change in the initial design and more documentation on the different handlings > of the safe.json schema and the false-positive-.json schema. Is it worth? I think it is, but of others disagree, so be it. >> On 9 Nov 2022, at 08:31, Jan Beulich wrote: >> >> On 08.11.2022 18:13, Luca Fancellu wrote: >>>> On 8 Nov 2022, at 15:49, Jan Beulich wrote: >>>> On 08.11.2022 15:00, Luca Fancellu wrote: >>>>>> On 8 Nov 2022, at 11:48, Jan Beulich wrote: >>>>>> On 08.11.2022 11:59, Luca Fancellu wrote: >>>>>>>> On 07.11.2022 11:47, Luca Fancellu wrote: >>>>>>>>> @@ -757,6 +758,51 @@ cppcheck-version: >>>>>>>>> $(objtree)/include/generated/compiler-def.h: >>>>>>>>> $(Q)$(CC) -dM -E -o $@ - < /dev/null >>>>>>>>> >>>>>>>>> +JUSTIFICATION_FILES := $(XEN_ROOT)/docs/misra/safe.json \ >>>>>>>>> + $(XEN_ROOT)/docs/misra/false-positive-$$*.json >>>>>>>>> + >>>>>>>>> +# The following command is using grep to find all files that contains a comment >>>>>>>>> +# containing "SAF-" on a single line. >>>>>>>>> +# %.safparse will be the original files saved from the build system, these files >>>>>>>>> +# will be restored at the end of the analysis step >>>>>>>>> +PARSE_FILE_LIST := $(addsuffix .safparse,$(filter-out %.safparse,\ >>>>>>>>> +$(shell grep -ERl '^[[:blank:]]*\/\*[[:space:]]+SAF-.*\*\/$$' $(srctree)))) >>>>>>>> >>>>>>>> Please indent such line continuations. And then isn't this going to risk >>>>>>>> matching non-source files as well? Perhaps you want to restrict this to >>>>>>>> *.c and *.h? >>>>>>> >>>>>>> Yes, how about this, it will filter out *.safparse files while keeping in only .h and .c: >>>>>>> >>>>>>> PARSE_FILE_LIST := $(addsuffix .safparse,$(filter %.c %.h,\ >>>>>>> $(shell grep -ERl '^[[:blank:]]*\/\*[[:space:]]+SAF-.*\*\/$$' $(srctree)))) >>>>>> >>>>>> That's better, but still means touching all files by grep despite now >>>>>> only a subset really looked for. If I was to use the new goals on a >>>>>> more or less regular basis, I'd expect that this enumeration of files >>>>>> doesn't read _much_ more stuff from disk than is actually necessary. >>>>> >>>>> Ok would it be ok? >>>>> >>>>> PARSE_FILE_LIST := $(addsuffix .safparse,$(shell grep -ERl --include=\*.h \ >>>>> --include=\*.c '^[[:blank:]]*\/\*[[:space:]]+SAF-.*\*\/$$' $(srctree))) >>>> >>>> Hmm, not sure: --include isn't a standard option to grep, and we >>>> generally try to be portable. Actually -R (or -r) isn't either. It >>>> may still be okay that way if properly documented where the involved >>>> goals will work and where not. >>> >>> Is a comment before the line ok as documentation? To state that —include and >>> -R are not standard options so analysis-{coverity,eclair} will not work without a >>> grep that takes those parameters? >> >> A comment _might_ be okay. Is there no other documentation on how these >> goals are to be used? The main question here is how impacting this might >> be to the various environments we allow Xen to be built in: Would at >> least modern versions of all Linux distros we care about allow using >> these rules? What about non-Linux? >> >> And could you at least bail when PARSE_FILE_LIST ends up empty, with a >> clear error message augmenting the one grep would have issued? > > An empty PARSE_FILE_LIST should not generate an error, it just means there are no > justifications, but I see it can be problematic in case grep does not work. > > What about this? They should be standard options right? > > PARSE_FILE_LIST := $(addsuffix .safparse,$(shell find $(srctree) -type f \ > -name '*.c' -o -name '*.h' -exec \ > grep -El '^[[:blank:]]*\/\*[[:space:]]+SAF-.*\*\/$$' {} + )) Coming closer to being generally usable. You now have the problem of potentially exceeding command line limits (iirc there were issues in find and/or kernels), but I agree it looks standard-conforming now. >>>> And then - why do you escape slashes in the ERE? >>>> >>>> Talking of escaping - personally I find backslash escapes harder to >>>> read / grok than quotation, so I'd like to recommend using quotes >>>> around each of the two --include (if they remain in the first place) >>>> instead of the \* construct. >>> >>> Ok I’ve removed the escape from the * and also from slashes: >>> >>> PARSE_FILE_LIST := $(addsuffix .safparse,$(shell grep -ERl --include='*.h' \ >>> --include='*.c' '^[[:blank:]]*/\*[[:space:]]+SAF-.*\*/$$' $(srctree))) >> >> Good - seeing things more clearly now my next question is: Isn't >> matching just "/* SAF-...*/" a little too lax? And is there really a >> need to permit leading blanks? > > I’m permitting blanks to allow spaces or tabs, zero or more times before the start of > the comment, I think it shall be like that. Hmm, I withdraw my question realizing that you want these comments indented the same as the line they relate to. > About matching, maybe I can match also the number after SAF-, this should be enough, > > […] grep -El '^[[:blank:]]*\/\*[[:space:]]+SAF-[0-9]+.*\*\/$$’ […] I'd like to suggest to go one tiny step further (and once again to drop the escaping of slashes): '^[[:blank:]]*/\*[[:space:]]+SAF-[0-9]+-.*\*/$$' >>> Now analysis-build-coverity will be called, the best match is analysis-build-%, so again the dependency >>> which is analysis-parse-tags-%, will be translated to analysis-parse-tags-coverity. >>> >>> Now analysis-parse-tags-coverity will be called, the best match is analysis-parse-tags-%, so the % will >>> Have the ‘coverity’ value and in the dependency we will have $(objtree)/%.sed -> $(objtree)/coverity.sed. >>> >>> Looking for $(objtree)/coverity.sed the best match is $(objtree)/%.sed, which will have $(JUSTIFICATION_FILES) >>> and the python script in the dependency, here we will use the second expansion to solve >>> $(XEN_ROOT)/docs/misra/false-positive-$$*.json in $(XEN_ROOT)/docs/misra/false-positive-coverity.json >>> >>> So now after analysis-parse-tags-coverity has ended its dependency it will start with its recipe, after it finishes, >>> the recipe of analysis-build-coverity will start and it will call make to actually build Xen. >> >> Okay, I see now - this building of Xen really _is_ independent of the >> checker chosen. I'm not sure though whether it is a good idea to >> integrate all this, including ... >> >>> After the build finishes, if the status is good, the analysis-build-coverity has finished and the _analysis-coverity >>> recipe can now run, it will call make with the analysis-clean target, restoring any .{c,h}.safparse to .{c,h}. >> >> ... the subsequent cleaning. The state of the _source_ tree after a >> build failure would be different from that after a successful build. >> Personally I consider this at best surprising. >> >> I wonder whether instead there could be a shell(?) script driving a >> sequence of make invocations, leaving the new make goals all be self- >> contained. Such a script could revert the source tree to its original >> state even upon build failure by default, with an option allowing to >> suppress this behavior. > > Instead of adding another tool, so another layer to the overall system, I would be more willing to add documentation > about this process, explaining how to use the analysis-* build targets, what to expect after a successful run and what > to expect after a failure. > > What do you think? Personally I'd prefer make goals to behave as such, with no surprises. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 09 10:47:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 10:47:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440847.695065 (Exim 4.92) (envelope-from ) id 1osibj-0001wj-5Z; Wed, 09 Nov 2022 10:46:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440847.695065; Wed, 09 Nov 2022 10:46:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osibj-0001wc-2D; Wed, 09 Nov 2022 10:46:59 +0000 Received: by outflank-mailman (input) for mailman id 440847; Wed, 09 Nov 2022 10:46:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osibh-0001wW-Hg for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 10:46:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osibg-0002ag-Mq; Wed, 09 Nov 2022 10:46:56 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.30.147]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1osibg-0004rz-Fj; Wed, 09 Nov 2022 10:46:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=zYl8ZBhqmdBhzZINfxX2qs1SGsEN98BDu/mYqyRJTsA=; b=iyxKp8APuL4LNSI+IlUmBqstsx HfSEow6nw5evZNlPHRSqU/9V/AX+4GZ6vPdDK4O/kCdkCOkseOBNWmhXHCinmaHARsMCvuOE/2d76 +l+rspBuLgHkU+VUwsux66C40ESJ6Gj/pvMois7A6JKA/0EWUyhsb2r5Qty8wWpShkm8=; Message-ID: <10204661-e985-ef5e-b7a7-820e2dbba021@xen.org> Date: Wed, 9 Nov 2022 10:46:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 06/20] tools/xenstore: remove all watches when a domain has stopped Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-7-jgross@suse.com> <67cb3364-d5c1-28d8-4cda-8933de5cb9f7@xen.org> <703aa58c-1b7c-abb6-995d-5c5cdfcde878@suse.com> <5fe0a47c-66ca-9e0a-4742-1663c7761256@xen.org> <90878b0e-c40e-e4cc-e423-c514a72ede7f@suse.com> From: Julien Grall In-Reply-To: <90878b0e-c40e-e4cc-e423-c514a72ede7f@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Juergen, On 08/11/2022 07:54, Juergen Gross wrote: > On 07.11.22 19:33, Julien Grall wrote: >> >> >> On 07/11/2022 07:54, Juergen Gross wrote: >>> On 06.11.22 22:18, Julien Grall wrote: >>>> Hi Juergen, >>>> >>>> On 01/11/2022 15:28, Juergen Gross wrote: >>>>> When a domain has been recognized to have stopped, remove all its >>>>> registered watches. This avoids sending watch events to the dead >>>>> domain >>>>> when all the nodes related to it are being removed by the Xen tools. >>>> >>>>  From my understanding, shutdown doesn't mean dead. It may be used >>>> during migration (or snapshotting), where we don't want to touch the >>>> state in case of a cancellation (or resume). >>>> >>>> For instance, see the command XS_RESUME which will clear >>>> domain->shutdown. >>> >>> Oh, good catch! >>> >>> I need to additionally check the "shutdown reason". I can remove the >>> watches only in case of the reason not having been "suspend". >> >> This is quite fragile because we may add new shutdown code in the >> future that could resume. >> >> I think it would be better to only delete the watches if the domain is >> effectively dying (I don't think it can come back from that state) > > This is how it is done today. Not really. dominfo.dying is only set if the domain is dead (i.e. DOMDYING_dead). This is happening *after* everything has been relinquished. So this is quite late compare to what you seem to want. > > The domain's Xenstore entries are removed before the domain is being > destroyed. Do you mean before domain_kill() is called? If so, maybe we should call domain_kill() before hand. The other alternative, would be to notify the Xenstored that domain is never going to come back. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 09 10:57:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 10:57:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440853.695076 (Exim 4.92) (envelope-from ) id 1osilR-0003kM-4R; Wed, 09 Nov 2022 10:57:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440853.695076; Wed, 09 Nov 2022 10:57:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osilR-0003kF-0L; Wed, 09 Nov 2022 10:57:01 +0000 Received: by outflank-mailman (input) for mailman id 440853; Wed, 09 Nov 2022 10:57:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osilQ-0003k9-Cs for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 10:57:00 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60076.outbound.protection.outlook.com [40.107.6.76]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3b22f178-601d-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 11:56:58 +0100 (CET) Received: from AS9PR06CA0350.eurprd06.prod.outlook.com (2603:10a6:20b:466::10) by DB8PR08MB5306.eurprd08.prod.outlook.com (2603:10a6:10:117::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 10:56:56 +0000 Received: from VI1EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:466:cafe::35) by AS9PR06CA0350.outlook.office365.com (2603:10a6:20b:466::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 10:56:56 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT040.mail.protection.outlook.com (100.127.145.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 10:56:55 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Wed, 09 Nov 2022 10:56:55 +0000 Received: from e6557a4a4960.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CA3A37F3-7D22-40A7-8417-A64E999A8A20.1; Wed, 09 Nov 2022 10:56:49 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e6557a4a4960.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 10:56:49 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB7941.eurprd08.prod.outlook.com (2603:10a6:20b:539::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 10:56:47 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Wed, 9 Nov 2022 10:56:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b22f178-601d-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gi9XkfkFTgsWbO2tKnd2V+tU98+LxfMrWYPAHKfbAXI/BRfN1nSo1mApVif90lTmDlR4gNjLlOBPAc2mnEWVTz2XK5sxXtKmgCB6Ndiy7EcsKEE9NF8+hJfrEIHsWPhVW23pHP/t1stc5QDoQFFzqgvsn3oLvIQESNES75xxY2Y3cZZCbspUuVq+LO9avqkhOABQUY36eRrN6CcpCVXlUO/KzJf/lENWtfsf3oMIzYa77lUHMcnmOrqEd7fuaW2py7UhlXk6OlN/84RkuC4UM13oxQ6ji2Pr57wWQ0UCna8LfAi4E4EB3QmqQsyxM8wZmYJQdEYYKBiA1wQ4aAyAfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GjzQ7RvglG5pfmMXHkG+pwMUwZ5FqKf4opNhriAfMng=; b=SDOmQamxnXPs9tQvyPP1S9LefcBN3c7ffb1VvUbAXInNfPh6IH3rHDZuGTtwsw0u1DDqAmJYAOb6+TzrINhc2yRrxPP4BrNZWLbaizYL5NrKv6BUA/l4Otim8ReAQq9el2S50EFIGTS2zG8iQ0azvGAjPO16jHThWQNrfhVoj1wxRovuIut3nfJVZpMIt8+X2y6+MpoMncQDQR7hkAaTcshnJxb8J8ZScTvrnjsJ6F1Jx2a8LPLaMeYAw7pV1CH1X0AsxRvGb+FaBZdRm0Zj0SH8Y5BTvpHNvPnbJpGzey/92AzsCjLxoIhQVxStYc0sZWQPBTBdA83BXN6uZZgjeQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GjzQ7RvglG5pfmMXHkG+pwMUwZ5FqKf4opNhriAfMng=; b=tDJyZnWWohQ0dEFqb/sSBWQdxQDvtjzWL8MumH0lHr4LXhi0ahPldpvgXL2jfhgvETXMmjronJsrNSVW/8nDOQaxbA4FUky7TKK1oIlxG3zUFUryNIpXT6Wssu9DXuHHN2EzRvmIBDitsgHWKNTWGP4rieFp5hZKRjqpu5Lwurs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CLfUA2l6EERI7O7F45I9BFhJQttMD1J/CjDqtcTkT3EqoBMn37gXB37jEDrY1hOrGJ5YH2WPO7zavANF6EwtfnAwQ9T696ycKeT6P3/Ktl6TSOBYiPB0cMuKcT6ISXP/2eODez4l2Egwnt6vydbPLvTxj0yu3pYBOeXcpSnKMeEbZlxKyAmZL1c4xIboOYPs3sTaXOU8u2Gfr/xme4FTsMTASKgepXfuBMqT6xipjLLwyQ3SEyvxX8zcWAVXlSazqNJkaZxgjTQNg+WY8F1LAePLgK86UIefIHSpvUkG5qRtvfoHuAQozGwGHn1t8bqK0xDarDLInlhq39VDTAaoPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GjzQ7RvglG5pfmMXHkG+pwMUwZ5FqKf4opNhriAfMng=; b=M91dpsBAXypz44KfZvE/JszjoHPKmURvak6+ACWjccwBUlJ6G5jDxNiC9z7b+km2jCtKIuSYPhjcR1plv3bVQy43kJVlYZwwgaMbtQPny4Qo90DEAlO1LxA7D2KDDbF4tKQz4Mo2V1c1Ro9/eey1fG6o1mzAcTuKKsZHfHACdkDp351RL1tWrxVi6mwgPZOxydQJ9E+btXieH1wwdxlVDubt990FsjyWMVjDW8Pj599hz2C7hYOQzBqZmNZYkbUSU8MzFyXCGvu8E1Av4WdXwuXbLyuTMtMFGy5NlHfd5Q58lrOr6igJwbEmHEOO3i+d6o+r31V1sI8iLrIWL9H9Ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GjzQ7RvglG5pfmMXHkG+pwMUwZ5FqKf4opNhriAfMng=; b=tDJyZnWWohQ0dEFqb/sSBWQdxQDvtjzWL8MumH0lHr4LXhi0ahPldpvgXL2jfhgvETXMmjronJsrNSVW/8nDOQaxbA4FUky7TKK1oIlxG3zUFUryNIpXT6Wssu9DXuHHN2EzRvmIBDitsgHWKNTWGP4rieFp5hZKRjqpu5Lwurs= From: Henry Wang To: Jan Beulich , Roger Pau Monne , Andrew Cooper CC: Paul Durrant , Wei Liu , Jun Nakajima , Kevin Tian , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Thread-Topic: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Thread-Index: AQHY8GkebAmmr6JZXEeYf3zz1Gj/l64zs2EAgAK/RgA= Date: Wed, 9 Nov 2022 10:56:46 +0000 Message-ID: References: <20221104161815.38007-1-roger.pau@citrix.com> <4c8d31de-539a-4252-f0a1-617b220eadc2@suse.com> In-Reply-To: <4c8d31de-539a-4252-f0a1-617b220eadc2@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6E9F281EE0937345938CE18B17326DE9.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB7941:EE_|VI1EUR03FT040:EE_|DB8PR08MB5306:EE_ X-MS-Office365-Filtering-Correlation-Id: 16efc7bf-54ff-43d4-1d44-08dac2411dd7 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SmkjHk6g2JlsemROO4FTGXKbJgwknE44/P6UF2G5ms2jfaQ5c5of9V9Io0VKbI7LNwAnMGpjsckMY8G9wkZmOuL03hgSEvgEnY4oYqJ9oh0JBWVnDSZJ97M0jfGnj0GgGgOfnRkNUuYEr7liqkCI5XY6yAQsqSxZ0we0r5kEwTKIid0CdU1HgZDhJFOen9lDr54sCEFxODA9Zgp56YVpB/j8+AwHXyEU7KV5Jqb8lIfaHHD/kObz8MEe3kj/NUAH+Pm5OJci95rs0iqQHmLk338EVWaN+kRD3rRwyELwRL1V/yq6OZeprX/1UCZ9Suy9TWI6OMxQ4NhpWqD8hnR9FOliBAPYOfrYSVzBbOS0x5T4rHkr3Y2gvUwwRuyqktGJeBjzvUNA9ov8FX+Jao2S1VNjlzq5MGoAhsKYTy0FCsY1Fw0jU1tLMrgdZfyrSoirjKhMAdia/9SxTkfyc2RWmFr9Oyk1qpz+GJtS7C6PAv7gQiYXCkVCltSjTYVBKNgsO2qtehlrE0K4c3iFRflbJrLZSTQk2qDGCmbFeNvN83/YugIUfzzD9K7d1Hw9b88CBwtHoQmEbg1V7NTEqBq1mxRG26iNaKtt1RKWSy69pFvHiBE2Ufw1oV/Wum8gp+v3zgnM3aZzFjySG5f0vxmEUgnlZXVaiFjvpi2c5keiBKzVXKY4vqIFaR5Vu9msR6cfWeoSbN7gSl4tampWQCwtGGI20q0RdMQHzKyuqQDJ2NGWK4WEZsXxuL/o6UvhfWRri8FVonFnyunAhA86Ag9b7Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(136003)(396003)(376002)(39860400002)(451199015)(83380400001)(86362001)(122000001)(33656002)(38100700002)(76116006)(38070700005)(478600001)(55016003)(71200400001)(66476007)(66556008)(52536014)(5660300002)(8936002)(66946007)(8676002)(4326008)(64756008)(54906003)(66446008)(316002)(110136005)(41300700001)(26005)(186003)(2906002)(4744005)(7696005)(9686003)(6506007);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7941 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 069d6937-54aa-4ee4-7351-08dac2411858 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rA7CnHfXnufF7dIfobFxgaLcPva8aBbfLwO3mZuahtVEyL6nd2sM8t2Jkpv2KmC4HVnWgrnnjlUd4lNfblQbXFbYhtm70PWCRCNZAmt9RePT6bAlaNQSNw8KDO7ltJrVD4K+EUpR7O8lk+8Ec/HvpFmMwYsSb+T+tZzM4kTfywxIncbhMh8a52Vv7e9zeNOrC5ozV0CsC1XGrvHimBm2nZbKFLOcE2XEqnYJ84+Pp+9vdDv0JnK4MsjvCj3Tscvk21N5jeN331/Jm/FtEBcv/uy3M2EO1ZCAq4YFx8Fz8A7Nu39ixNgGNWjTfh5KP21YKZ5kJdt3d+7ClgQ3PY7EQ+hC4QYzQpSfVwYJKSBdu9I6YMQp76tWWHTrNUX6OHvB8npNY1YAMOaXRAVW6PQ8UzVjcynzJBuXHA5i98cx7JZDWZLlUs612w2LhILAP2DHvRf0aXwaWdiKnXMMYQKW3rlkiGX7NQS/KptILI+sOhSKpZnlcMUZRJcD+KwCkrfqoIzkcmGuxfn68Q8rFwZctG8o3U7IV0754C6ah4z+JcBVFHTUJ0OxCyl6jIXT9s3IDmuvXwM67ZfBDojN9KPve4XlNunglMg9/jvUW5lPwuSwRJekwtntS6dILr2t8Cgo7MjeUCE2i+2rEUCohpllMdrnCn9g33wawldJhJkM5oQ6bAtkO4bXxAHMDZBwHoPFzZJCw8776KmioTv12XIQKSSZy1V4+rmvOU2U5R12wr1Dz9TtAUa9gmzkBsNgvPPXagYbyR90WvLlcM1jc70W2Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(39860400002)(396003)(451199015)(46966006)(40470700004)(36840700001)(8676002)(82740400003)(4326008)(33656002)(70586007)(70206006)(316002)(7696005)(55016003)(40480700001)(4744005)(40460700003)(83380400001)(336012)(2906002)(47076005)(41300700001)(9686003)(86362001)(26005)(36860700001)(186003)(5660300002)(8936002)(52536014)(6506007)(82310400005)(478600001)(110136005)(356005)(54906003)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 10:56:55.4552 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16efc7bf-54ff-43d4-1d44-08dac2411dd7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5306 SGkgQW5kcmV3LA0KDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggZm9yLTQuMTcgdjJdIGh2bS9hcGlj OiByZXB1cnBvc2UgdGhlIHJlcG9ydGluZyBvZiB0aGUNCj4gQVBJQyBhc3Npc3Qgb3B0aW9ucw0K PiANCj4gDQo+IEV2ZXJ5dGhpbmcgZWxzZSBsb29rcyBwbGF1c2libGUgdG8gbWUsIGJ1dCBmcm9t IHByaW9yIGRpc2N1c3Npb24gSQ0KPiB3b25kZXIgd2hldGhlciB0aGUgcmVzdWx0IGlzbid0IHN0 aWxsIGdvaW5nIHRvIGJlIHRvbyBjb2Fyc2UgZ3JhaW5lZA0KPiBmb3IgQW5kcmV3J3MgdGFzdGUu DQoNCklmIHlvdSBoYXZlIHRpbWUsIHdvdWxkIHlvdSBtaW5kIHByb3ZpZGluZyBhbnkgZmVlZGJh Y2sgb24gdGhpcyBwYXRjaCBzbw0Kd2UgY2FuIHByb2NlZWQgYmFzZWQgb24geW91ciBmZWVkYmFj az8gVGhhbmtzIHZlcnkgbXVjaCENCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gSmFu DQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 09 11:00:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 11:00:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440858.695087 (Exim 4.92) (envelope-from ) id 1osioh-00057N-JH; Wed, 09 Nov 2022 11:00:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440858.695087; Wed, 09 Nov 2022 11:00:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osioh-00057G-GM; Wed, 09 Nov 2022 11:00:23 +0000 Received: by outflank-mailman (input) for mailman id 440858; Wed, 09 Nov 2022 11:00:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osiog-00057A-PV for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 11:00:22 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70085.outbound.protection.outlook.com [40.107.7.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b45c803e-601d-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 12:00:21 +0100 (CET) Received: from DB3PR06CA0019.eurprd06.prod.outlook.com (2603:10a6:8:1::32) by AS8PR08MB9929.eurprd08.prod.outlook.com (2603:10a6:20b:564::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 11:00:12 +0000 Received: from DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:1:cafe::ca) by DB3PR06CA0019.outlook.office365.com (2603:10a6:8:1::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.21 via Frontend Transport; Wed, 9 Nov 2022 11:00:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT037.mail.protection.outlook.com (100.127.142.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 11:00:12 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Wed, 09 Nov 2022 11:00:11 +0000 Received: from 84db76e3015c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0ABBFAD5-997F-4278-A175-E5E75AB11145.1; Wed, 09 Nov 2022 11:00:05 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 84db76e3015c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 11:00:05 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM7PR08MB5461.eurprd08.prod.outlook.com (2603:10a6:20b:10e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 11:00:01 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Wed, 9 Nov 2022 11:00:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b45c803e-601d-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=kbDgt+2ZRsoEr55EkT3i4t7FvvH2GPtOOSFSvLKDRclwvmumzXz5jKFSZXpjA74G/s8XYv79PYeL3NdjDodrz5aevHNDasD4F/wZTD7ytyFCIelmljgb+rCi5sQmfNYGE1pHs6NBjn/gAZ7gLjEJjBDsmSqi5BcWlzEon76uFzzd2CmlGiB0B45aJcVfkOznszOvpl+KitlRFHF+sEDCbHUogdjmfT96FDlFhMa+ykZ+n15yHGnO2XmIw3/oCyeBSJc0G+qOz7U1zBdaqZQI0hRTbUiurWzpVahXMwxMvFt+M9YnrPDte9By40/HS2lZdc3Lr0iQO4Ho5F2U+uF9XQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Tnucfl3+Furx4fxgjuyQjuQOVOPuXWdtJAyO5kEwB8=; b=Vqd54iR2Ikc2+d0Jd3B1w36hMEQ2nbfIEr3G1pGG530CklGrwMGWl7xyAzowqVgO+OzeIACzmVPwYo/Dq+pU0XxbgYK75uuQtNcQgcRb4alVOcAoM9LaN39rQE73MNgPlGICePaK1XUNsBrkf9XfHd91d8rR6D3WmAN0fZXp2RuQEN4nMwFVSMjSG9fj5Wos/48yBuPz8Fk+L38KPpEAjd063c9VYznkSMKb4BVhkausUSNl5dhJCtLWpNJb/e+JjviVbrxU3/9OtLrTsCEjgKjKxRzKsN/wEedgISKgWiFKBNsaoUV3uB9WHy2SvBxGaSE4bYKfZdXLdrmRr4bycw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Tnucfl3+Furx4fxgjuyQjuQOVOPuXWdtJAyO5kEwB8=; b=3BLvdZZaRgWoAD6QFWEwAPi2CkeRpSnYQ8V5CEAwmQujmK4IOh/TbVB8o+S/rKPOBZSgjijRpJiJx7IVMBQ1ea6nT/z1SwwR3LtSQ4qsVEEbCp8h7TG1Om6v3AHtaajW+yVQrR76rzC7tnQU9qAKHydHMmssfDwjlbXaiW7p0jg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=by52rsXF+yKj7SbyCWrNZjtcYGpA/5FlwzRAzs/odQ+F/7d89Xusdudyw+Dt7Etd0IiwBmEvqFpXjiWOrpdLKXkIAeiK7NcEqlqoFfJkTbDyenacY0qfWa6oi+qcS7jL4rM37yE5dK39bjI3GhrLwJ3l3u0DstOAYie2LfE88ZPpE6kG9f5e3qnFMz8bCEnLDgyIy4nG7W9mCupB4f9AMbpOmC8O46ioWz9CAhNvFJfIy5hf31Y9jAavne2dvbtqODNfsf8yleA2TNuihoWadZ5HWflm7nPABA0xmkk+9ysCXeiRZJ96jBZJKLGPjw3jp7tJZTRHjc6qkOXka7bPGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Tnucfl3+Furx4fxgjuyQjuQOVOPuXWdtJAyO5kEwB8=; b=GQ+BVDl6K13IHM2VbPDqrBBJr72ZUI6y1bUEfJDfW5ukGJ/g2HZxkkIyqZLJuDabBGAreSjmsBr7PdhYFSLW+CzqpQR+UpYdjFoUGOGtszhARR7Xjoo1oRFZDAfWJiHwth+GSAFID18XjseU+ZKO2FWntAMlZkuXT1dXlD4h9IZcjP05N6c0QBG4Z/NTfsfILiNIC8vnj4VQPMoBn+I9B9zrY9qJIn0D99DbGdQWfj1qvxnGv10sEBy1gUoVZMsrJ88hQlJqDkqPuwRleHG4yFJPg4xEGNThiv3snat2K1kikMTuiEGrWu5dD3T47qTwL69GTMehy6Z7jULyrp6cxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Tnucfl3+Furx4fxgjuyQjuQOVOPuXWdtJAyO5kEwB8=; b=3BLvdZZaRgWoAD6QFWEwAPi2CkeRpSnYQ8V5CEAwmQujmK4IOh/TbVB8o+S/rKPOBZSgjijRpJiJx7IVMBQ1ea6nT/z1SwwR3LtSQ4qsVEEbCp8h7TG1Om6v3AHtaajW+yVQrR76rzC7tnQU9qAKHydHMmssfDwjlbXaiW7p0jg= From: Henry Wang To: Jan Beulich , Roger Pau Monne , Andrew Cooper CC: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH for-4.17 v3 1/2] amd/virt_ssbd: set SSBD at vCPU context switch Thread-Topic: [PATCH for-4.17 v3 1/2] amd/virt_ssbd: set SSBD at vCPU context switch Thread-Index: AQHY76ZET1O4McAMZk+SDG8R2oR8564uaneAgAgKxzA= Date: Wed, 9 Nov 2022 11:00:01 +0000 Message-ID: References: <20221103170244.29270-1-roger.pau@citrix.com> <20221103170244.29270-2-roger.pau@citrix.com> <952950b5-33c9-6872-0cc4-6ebdf1e015ca@suse.com> In-Reply-To: <952950b5-33c9-6872-0cc4-6ebdf1e015ca@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E5291037BE84824C9DDB3EC18800E6C3.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM7PR08MB5461:EE_|DBAEUR03FT037:EE_|AS8PR08MB9929:EE_ X-MS-Office365-Filtering-Correlation-Id: fe204b68-c7ad-4ff5-0e1e-08dac24192f2 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: aWY6KEsndTC8VuX5RF2+41S14Fx7RBQ+6Kvc8VekTv7n4ohpdRoQo+uTUIQG+g6wuShUu2bgJ5u63BYayy71cjTkoMgr0wQRq5VTlgoF7K1+BifjTOdn/CIxbLIWFniP5YLFqS+Dj3CSQqvIvfTh1s2Wg2HGBpIQQtmlxzxXP7bsyh/vFRZt75Nv9RPtsu0IfoNGxh2/32LShslejp3MA9G4gvIN5h2OCIEYX9+hRIYpTKx3epyLSyqF+eRk13ylRQ7juZHuhQYpvokuub5ncqF1ao99OakxRIy+CJkJaa3XEJh4j+4LCLWlPOvZaqJa+LV84z8HvthhmXuHF0aUJq5qgF44synsFieuS0mx9riIFVEpFVn51BH6QFAZTI0D4KHMAusxkF9snLSQXDOHEHuxQN0uGYVKUeHZLFbUiVQ+3FgSQcLJjnRvM09sBNNf+KK/lproKdotE2sOLj9+faARhXExsuCUXKwwNS2uL9Fpy6cf85TcMWOqlMHCd0iHIh9DwS+mKHDVYmuSkupaMU7xBDnJZfi2XS4isTUBeZPJIATbh2BJ/JN1W6eLLfJ5LeJhkhVjuubyyjmZelr49CG6KeWY/W1rX5yPff7pEQ1b1OzX6HYGjYZkHM1QiSkyUQTi5ndmu6jX03R5HqIPuV/oukoYgoUuSBauKfQf39FKOf1FYqQoD+Zs7D9IJ3ja/3pHP6wBfJjBu/4KAkGwkOex4DNz8cGTmNH8AZz0yXsNb911VrqdGU8VYfF8+QBwJCsliD/zW3AU0CHjcpkF7Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(366004)(39860400002)(346002)(136003)(451199015)(52536014)(41300700001)(4744005)(8936002)(5660300002)(54906003)(316002)(110136005)(71200400001)(478600001)(86362001)(186003)(2906002)(7696005)(6506007)(9686003)(26005)(64756008)(66446008)(4326008)(55016003)(66476007)(66946007)(38100700002)(76116006)(8676002)(66556008)(33656002)(38070700005)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5461 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ff85e717-677e-480c-6e59-08dac2418c6e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YTLvDftdB3rR6TPCUDI3EIXq5JDbhk3evIrferRsZdV8mtelpYvhTGX+LbByPgmFep4mZCPUWA4y8aseye4BvhWbNLd3a4+oiFdgkYZnmPO9Kd+z1D3F1HT0Evhohx0gdPZECa+SPAZ2phjsJcCeRWBOYfyXGR4oJJZSXEeQ17FzEp29w/c4IorbsUMJYf502jqZy1jrWAo5CK7pbvoCTJ2e7WU21cWyMX+n3dDBTfEFBPzHT4+gS2otJ6xnrbfX/8lyGGmAb3FaKwBetYRDeLd805H/iMcDmt2FdbjOdhbqauBDKsHqw+VuEiUaoH9AHj60sP8ySKW3G0kB3TVwiObrB5Y5/R3uT/5p2bDHB49rvxxVtZ/o9SsxUcBJh/PvWhQo+gcWK2r/UV1d+ymiGFXbvXTrdZKNm8ACDd/8j5z4JzRIp6/z1uY00HakuPd8ljpfMXSxoOknbjKTJnlJ8MqEUDthpmoGNxoEcYy37CTQA+j+7Z+d3n7ZDc2jGnWNJR6Obwlk79LB/bWPKpMtUfeBpD83S4XllPXgF/HW//oqjjFz1ymWvvVXdbh0PdKO661EuTslXl7CskI9dy8VZvMRxfm26DjCmVdvXfu9fZwyAOXAtoKzmaHhzqvo8wANWfPPUM68Ey3Z5gl02CYrKSeyK+Oi3Ei/jz+qROF0BnXjg08IhEMcC0hE0MsbfRiruqiSAzgU+c3C4zzjfoALuMvyQ5Z4dtEGzmKy96N5rVa4SfBY81645sL8xU3mT1VQ9IHjjISFmWWtG6iy3xO4Pw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(39860400002)(396003)(451199015)(46966006)(40470700004)(36840700001)(8676002)(82740400003)(4326008)(33656002)(70586007)(70206006)(316002)(7696005)(55016003)(40480700001)(4744005)(40460700003)(336012)(2906002)(47076005)(41300700001)(9686003)(86362001)(26005)(36860700001)(186003)(5660300002)(8936002)(52536014)(6506007)(82310400005)(478600001)(110136005)(356005)(54906003)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 11:00:12.0189 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fe204b68-c7ad-4ff5-0e1e-08dac24192f2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9929 SGkgQW5kcmV3LA0KDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggZm9yLTQuMTcgdjMgMS8yXSBhbWQv dmlydF9zc2JkOiBzZXQgU1NCRCBhdCB2Q1BVIGNvbnRleHQNCj4gc3dpdGNoDQo+ID4gU2lnbmVk LW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+IA0KPiBS ZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiB3aXRoIG9uZSBm dXJ0aGVyIHJlbWFyazoNCj4gDQo+IElzICJjbGVhcmVkIiBpbiB0aGUgY29tbWVudCBjb3JyZWN0 IHdoZW4gInNwZWMtY3RybD1zc2JkIj8gSSB0aGluayAic3VpdGFibHkNCj4gc2V0IiBvciAiY2xl YXJlZC9zZXQiIG9yIHNvbWUgc3VjaCB3b3VsZCBiZSB3YW50ZWQuIFRoaXMgY291bGQgY2VydGFp bmx5IGJlDQo+IGFkanVzdGVkIHdoaWxlIGNvbW1pdHRpbmcgKGlmIHlvdSBhZ3JlZSksIGJ1dCBJ IHdpbGwgd2FudCB0byBnaXZlIEFuZHJldyBzb21lDQo+IHRpbWUgYW55d2F5IGJlZm9yZSBwdXR0 aW5nIGl0IGluLCB0byBhdm9pZCB0aGVyZSBhZ2FpbiBiZWluZyBvYmplY3Rpb25zIGFmdGVyDQo+ IGEgY2hhbmdlIGluIHRoaXMgYXJlYSBoYXMgZ29uZSBpbi4NCg0KQWxzbyB0aGlzIG9uZSBwbGVh c2UgOikgQW55IGZlZWRiYWNrIHdvdWxkIGJlIGFwcHJlY2lhdGVkLg0KDQpLaW5kIHJlZ2FyZHMs DQpIZW5yeQ0KDQo+IA0KPiBKYW4NCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 09 11:37:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 11:37:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440867.695098 (Exim 4.92) (envelope-from ) id 1osjO4-0001RX-Ik; Wed, 09 Nov 2022 11:36:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440867.695098; Wed, 09 Nov 2022 11:36:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osjO4-0001RQ-F1; Wed, 09 Nov 2022 11:36:56 +0000 Received: by outflank-mailman (input) for mailman id 440867; Wed, 09 Nov 2022 11:36:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osjO2-0001R1-Up for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 11:36:54 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd359552-6022-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 12:36:52 +0100 (CET) Received: from mail-dm6nam11lp2169.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 06:36:45 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by PH0PR03MB6511.namprd03.prod.outlook.com (2603:10b6:510:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 11:36:43 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.025; Wed, 9 Nov 2022 11:36:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd359552-6022-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1667993812; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=22+WF+03jPMOsvy6F2jFsJNfScoE6APDhnp9gn+qjXo=; b=N7XsXlfVa9e9mujXMYTf69ASE25KolCI5OeyzrQuYnXnMnEujIbUN5ue hlTMEiUbrLTFdELoR7odDJ6IjYcgLPbUh2AQCWaYW+H/HLnkxISTBga/b S4NEaLpnFgCA1SiJDaigE0rUaSSZ4hzCYaVnajC4wm+FS1tGSDWJqHxJl 8=; X-IronPort-RemoteIP: 104.47.57.169 X-IronPort-MID: 87000645 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:hmRZIq8qu/zZZj6jyG6GDrUDs3+TJUtcMsCJ2f8bNWPcYEJGY0x3x zdKX2zTbvaNazGheo0kbovi905TscDRztMxHQs6+388E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKga5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklU7 PMBCiAJcim/nuPqx7+HZ9dQvs48eZyD0IM34hmMzBn/JNN/GNXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWMilUvgdABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prr+QxXujBt5PfFG+3sRHh1Kt5TIeM0IfeBiHuOaIu0ruQM0Kf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwCGAzLDFpTmQAGcsRyRELtchsaceWjgCx lKP2dTzClRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85i8jVf5mGa+xy9HwRzf5x mnTqDBk3utCy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg= IronPort-HdrOrdr: A9a23:YyeiA6ByzsvNuF3lHekp55DYdb4zR+YMi2TDt3oadfU1SL37qy nAppgmPHPP5wr5O0tQ+uxoWpPgfZq0z/ccjLX5VY3IYOCMgguVxe9Zg7cLw1fbalXDHuw279 YaT0CpYueAd2STjqzBkXSF+85L+qjjzImYwd3w4l0odg1xdrph5RoRMHfmLqVxLjM2YaYRJd 6nyedsgSGvQngTZtTTPAh9Y8Hz4+flubjcbRsPFzYr5RLmt0LW1JfKVyK28z0kXzZG0Y4l6n WtqX2G2oyT98uV5zXg8lW71eUmpDOwouEzY/Blk6IuW1PRtjo= X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208";a="87000645" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HXOxOON1YBMz9+7nRqmKIg0bcvYaYp8CVK2vO6mOgVOjSAfnVPxXGZHoPMswO9aWOiIAirLqcBNK27qfFWRqAKGl5WRM58XgHej3n4ZZVra3zrFCuMXWcnnWeM8cpT+JCIOoWAlApzYVRRQD6Rp3eSrRVsuSrcFQZgkpWW3qDjEi4E4KAuK3eAiWnnIFNKPtfxEKUcKTXysO7blmSBW9GlZOFamzrbYTUbpbiNjC6XYS2905wQQWuUaWUg8BxYbPiWwYGgKHksoeh15oflrHsspdKtNmke6oT6uyHzSA/EEaN6uVCxycE8g7fzwbtsTz9MIYg82waunUsDTzjYUhSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QERGUx8m5H+C4Omw+Dd2zraCUltqFgWBQDjjoKeUHEw=; b=J0b+UBpM6bG3mmom2IMQxKpcz/2ylwPTs85BhMcemMhgWZtk68lU7b8RrDKMoRO/akS5o034wXv314UfbUFhzVYJAnMtS2wJeWMVSDiVFEEG5iDSxtv4nasqaagyazfn4WMRzcYbnY8h7auK2NuooBlTkqVExOZrejMrIVOaAxSUE/LQwMJIA48lVt0mxQx/30O4wee+q4ku0AYdeHtuQjcoN45f4Nck5rOojEve2BanVIMPwZWxcePV6cSy48FsPnhdZAIRgHhtOqC8ZFdNPPKQRmPFd4VCvUIPVJqq8zyz5jwdBsH8z3/wNxIe/E7Ea9jm3aulh0YtYkhN5MgMZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QERGUx8m5H+C4Omw+Dd2zraCUltqFgWBQDjjoKeUHEw=; b=Sa45vSY0t4oW8+8bUDD4txChcfSLXG2decKCsYzh057KD50R3dowJDomBVSOqxv5BwzOnYhmWS/eKJW5MlobdOzrY6N0ChNYl980to5YYzQQJ4UtwGVzDRqQIk0lLMzYo9/rYXKlWN0vslNC94WQBdan87b9Bq2Q8MotH4tejFs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 9 Nov 2022 12:36:38 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Wei Liu , Edwin =?utf-8?B?VMO2csO2aw==?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Message-ID: References: <20221108113850.61619-1-roger.pau@citrix.com> <58d5e890-e052-47df-42bb-6cc84aedd4a9@suse.com> <76cde159-088a-3351-56e2-0cf14e9c8116@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0655.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:316::9) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB6511:EE_ X-MS-Office365-Filtering-Correlation-Id: 713d7754-2f0f-4dd8-46f8-08dac246ad0c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7c9ajieYlfonepzJqjywiYZUjMuj5yPy3pqpM/BlqI7YJPRKtSV8OcaQG1HmTU42+jRdsAE550vfkks1oCfwcsSFlhqLc75DgGA3wXqn4cUkMAv5QH6OTND6V6n2JglKEQZ2YhXiR5lTYuFJVX54rxgkjojXszv+sEEX4idVqmNU845MhSMr09Pitk1kCRHaAXtHB2XQPlYGGf2HUwD6HtqMaRbwi8TzDFvlok71q6kPhMcTqPsQeHAXr62pctqroygyzTerf9rerK+0WarqpvYAO6ldgmgwR+uA8CDAiS0Jf1aaCFqg/SBLFs2u08jmsEGQiENGn2wLJBtf8aPrX0UIAUcBik7aeP7nm4C8L64QIcpc+kt5g0XXKgWUr/flVRssMADVrimq5cTrrkKJyPOLstPHmrZbRQHrMklzxYFFN8iinReEl66GwK5kSbjIQBEFYtYOezJeUQKmrezAT3B3WNFdzIPmE8Y/wWiKG1onJALbFplJSaAWEwapJjTM9c4S/XKUNLYomNi0Nsetk6Y7fcgsm3dYVX8TAZfqTyMYk+TtBsmFMn7wzPZmUqXS9ux+91zwGrSfmAdnIUAllCT2QZTe2r6++2YjvEtMkRhWUqhRZKW6Hvq92cnZYPBT1z3BLr07txjdrht+KcojZhK8t8WNxMEPfVgGCATtba6AEm9mOCgA3P+i7qFVfXOBrbX74cGP836Q2HpMzHntnf85cPOLlOf8TmLcVIpgOFYjyGg3/CND/RCxqMohJ94Njf0z3YzRXqv6FZbrJZIumg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(366004)(39860400002)(346002)(376002)(396003)(136003)(451199015)(6506007)(9686003)(26005)(83380400001)(6512007)(53546011)(6916009)(38100700002)(82960400001)(186003)(5660300002)(2906002)(54906003)(33716001)(6666004)(8936002)(4326008)(41300700001)(6486002)(478600001)(8676002)(66556008)(66476007)(316002)(66946007)(85182001)(86362001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0luaW4wU1VGUTFPUktvS2tYMzZwRFpZN3h6dHlWa3dMMXhNZEdpRWJaSVRN?= =?utf-8?B?bEwvb01tcGx4dVprNGtnY0dJS3ZHZ3NKb0ZpRmgyR1c1Vmo4RkhKNW9rYWdY?= =?utf-8?B?anNxYjV6ZXpDcllnTmxHbWpIZCsxVkhCS21yWE96YzZPUTNMM2p0S1pvNHFD?= =?utf-8?B?V25BT3J4OWNkK1BiYTQ3T0lycCszNy9kVlVHNUZJTVNPQ2daVGRpUmk4T1JF?= =?utf-8?B?cWtWbHI1OW5lRTk0cUhFajVrck9PU3RBRjZVYldFcjFvNzlZbkhVSG5JNTZz?= =?utf-8?B?TmozYThLRmdnVE5UYXI4dUduZnJvUnhhWGlIeU9PNWxoZmFySFJQZjJ5Ri9y?= =?utf-8?B?YlJVY2ZzanVSd1RiTjU5ZVEzOU1sZ3dPemJxVmxaamtKRWM4QWJDMUx1eTNj?= =?utf-8?B?MEM5UXViL0xuckVCQ2pvZE52eXlnR3FYbnZPTFlMbS9xdm5lL3J4MG1yVE5r?= =?utf-8?B?eU9WSy9COWdCNVJQZTdUQ25yYzFTVy8vdVJ3ejh3VkN6d2tncjlDRFFLWnlU?= =?utf-8?B?Y1R6bG9LdXhTWUhjcktnR21LOHh4T1dZenN6SHkvS1hENTFPS2hwMFRJVkkw?= =?utf-8?B?NU1SeU1tVytqOGtRQTEwOXBUMkFYMUdPbFJNY2N6MmpYcWk3d2J2dWxPTFBr?= =?utf-8?B?VnBodFl3dEtlRm9RUzdmd284MTFOdEgzbFFCWkNoVEhEUzhJbDYybVpTcmQx?= =?utf-8?B?Z2lEVDRFZitIUDNoTEJQNCswcG5IWUhUUlhWZ2UvNFNQYmNwUW5EdjNybXhs?= =?utf-8?B?YjlVQ0s4U08rVmNBajJMZWJReU01RGpLK1VCbE1PTDc2R0JzQXJvaHN5WU93?= =?utf-8?B?TU9yNW8vb0NINE5JeWlPM3NtSWVTV29WR1psYXVpODI4YjZ1a00yeDBuaTBv?= =?utf-8?B?RVBaUU1QZkZlc2piTU1wSlIwM2Y2aElpMkxveGdSYzV3dHY3YlovaUMzZzc0?= =?utf-8?B?bWtsZ2RNREpzaUdxZnd0ZnYvdk0vQnpUQnBLSHlHaDdaL1pmUThoa2ZEelFZ?= =?utf-8?B?UDlmNGlhWWhyWlp0MURWQWFuL3VxWEpDMzNRcFRRQmc0OVFyekZua2xieFEz?= =?utf-8?B?WHAwS3cyS0o0eEFDcWdjV3VTM09GaitKa0JBWVNDeEZUdFZlOHdKWUhXTmo0?= =?utf-8?B?NS9rOUxwQThaTStqYmFBSVAraWtqRGdRYTdtWjVUZ0pKaVJKWHBIMWJxZzA1?= =?utf-8?B?RzRjc3d6OWppUGJxNjZYZjIzTVNNUFUrREVtZEdJVWl1b29OTzZJUUpLTldF?= =?utf-8?B?d2JnYm8zK20yMW9nUXd4ZnhhYmxZd016Y0p6dHNpczNIYW55Qm1ldlE2UGxl?= =?utf-8?B?RzZXbDBPdGxNMlMyNlMvb0E2OXFjbEJwczZZYjFWa1JWQ3dkOUtPbzJLTGhv?= =?utf-8?B?aVFqWVpBM3JXc3F0YXIrc1BsSEE3YkhqcjVaNXN2T0UxS0llTHMrT2ErdmU5?= =?utf-8?B?VWJ2ZmNXM2NkTlh5eDFyN3VOQ1VvQmZGVzdYQmdPYVRjNXZDZGxPRkZOTUtH?= =?utf-8?B?S3Zhd3BpRElWNVhRck50OFQyU2FkZUNoc01jZkd1S1FPM0F2SUhxTVRCV0JR?= =?utf-8?B?RFVMczBHekowMENWUWZKbVMwQXBWRm9QWDg4YWtXdnpZVjdPQTQ0N1IzeUZM?= =?utf-8?B?T3RydFIwcm1WQmw3YmpzZmxuTEtwMnhVYnArR1BTSmd6TVJ2aW11SGx5cWhi?= =?utf-8?B?MzYxelIzSTk1eS82Z2xGWnFSZ1ZEdGYzTy8reVlIZHY1T2NiQU1xTGczcjdP?= =?utf-8?B?cFpEcEptVHF2eUtxMlpGUUswNHJwNlk1RVJTMEVyMW9VUThxSUJQUmFIZ3Nk?= =?utf-8?B?UFBzYWJ2RVg3bGVackQzR3NwT2I1NWVpajB1SUwwR0NRNVFucHJvV0pXQmU5?= =?utf-8?B?WjZDZGtpeHhrcUdnYWFRb3h5TmlHY3pTN1NOUkNCMnRyUDBxRkt0UUlQYnFX?= =?utf-8?B?Wjk2VVdZZ3RZZ0JvZFlpTlFBYjA2NVYrUmFWV1hwSXQ3YnZvQkNYUTBseC9v?= =?utf-8?B?TFpaZURNMDhncjBsd3ZKOGp6Y2ppTzZDNzBTTVUxTXBteWtOcUoyQ2prK1lM?= =?utf-8?B?Mlk3V0V6S09pM255Wlg2dE5xdXB3eis4SkFmZjN4TXRXNEpSV00xeVFUQk5R?= =?utf-8?B?ZkdmUHl6Q1Y2eFBBU3pFc010dXV6U0JtWTJncWhWOU9Tai9ycmZPb3NtRTF3?= =?utf-8?B?OWc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 713d7754-2f0f-4dd8-46f8-08dac246ad0c X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 11:36:43.5452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nr7HfpDnBF9WIccPKd53mNCR7ZpGVWYCwG07RvGZg8UILOT9GjAedSAHGjbJfVVJCALgiTRIyxvxQnv7Qse3jA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6511 On Wed, Nov 09, 2022 at 11:23:01AM +0100, Jan Beulich wrote: > On 09.11.2022 11:11, Roger Pau Monné wrote: > > On Wed, Nov 09, 2022 at 08:48:46AM +0100, Jan Beulich wrote: > >> Finally I'm not convinced of the usefulness of this dying check in the > >> first place: is_dying may become set immediately after the check was > >> done. > > > > While strictly true, this code is executed with the domain lock held, > > so while is_dying might change, domain_kill() won't make progress > > because of the barrier on the domain lock just after setting is_dying. > > I guess I'm confused now: This code is called with the domctl lock > held, which - as said before - is a questionable thing, for serializing > things more than necessary as well as for holding this lock for > excessive periods of time. IOW I consider it wrong to depend on that > in paging_domctl() to synchronize against domain_kill(). Yet indeed that > should eliminate races at present. Right, both are domctls. There are other places where is_dying get set as part of failures in the domain create paths, but then the paging domctl failing would be natural, as the domain is being destroyed as part of a failed domain create. Since I don't see replies to my other comments, do you agree on returning an error then? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Nov 09 11:43:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 11:43:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440873.695109 (Exim 4.92) (envelope-from ) id 1osjUo-0002r8-98; Wed, 09 Nov 2022 11:43:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440873.695109; Wed, 09 Nov 2022 11:43:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osjUo-0002r1-5e; Wed, 09 Nov 2022 11:43:54 +0000 Received: by outflank-mailman (input) for mailman id 440873; Wed, 09 Nov 2022 11:43:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osjUm-0002qr-1H; Wed, 09 Nov 2022 11:43:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osjUl-0003h1-Sa; Wed, 09 Nov 2022 11:43:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osjUl-0002Vb-C3; Wed, 09 Nov 2022 11:43:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osjUl-0007oN-BY; Wed, 09 Nov 2022 11:43:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Zhr3FozaS90BXZBnyDSW8BTffg+0+GWTZuljTXyn/zM=; b=CMj7R1LMh9OT5xR2naFwO33/M6 KW538yH643wg+yU9mqxAB/xIOLRbxVYrqSXCwYQvmYSwz5An4+Cx4wFG1ZH8g9Amb6BKYwmm2OqH3 KBFL6Bf2bTQsgUQLBOrYJgLThx7glOqzDmDmtBAsYVlxeo9FBQaRXh9M9nxGtB8giG1k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 174676: trouble: broken/fail/pass X-Osstest-Failures: xen-4.15-testing:test-xtf-amd64-amd64-4::broken:regression xen-4.15-testing:test-xtf-amd64-amd64-4:host-install(5):broken:regression xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=32445f23fea6a533fc1d7ade5871246d75210bf1 X-Osstest-Versions-That: xen=e818f4f0dabf83a6138cd77d7464495fab7bfc16 From: osstest service owner Date: Wed, 09 Nov 2022 11:43:51 +0000 flight 174676 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174676/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-4 broken test-xtf-amd64-amd64-4 5 host-install(5) broken REGR. vs. 174572 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174572 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174572 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174572 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174572 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174572 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174572 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174572 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174572 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174572 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174572 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174572 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174572 test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 32445f23fea6a533fc1d7ade5871246d75210bf1 baseline version: xen e818f4f0dabf83a6138cd77d7464495fab7bfc16 Last test of basis 174572 2022-11-01 15:38:00 Z 7 days Testing same since 174676 2022-11-08 18:06:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 broken test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-xtf-amd64-amd64-4 broken broken-step test-xtf-amd64-amd64-4 host-install(5) Not pushing. ------------------------------------------------------------ commit 32445f23fea6a533fc1d7ade5871246d75210bf1 Author: Andrew Cooper Date: Tue Jun 14 16:18:36 2022 +0100 x86/spec-ctrl: Mitigate IBPB not flushing the RSB/RAS Introduce spec_ctrl_new_guest_context() to encapsulate all logic pertaining to using MSR_PRED_CMD for a new guest context, even if it only has one user presently. Introduce X86_BUG_IBPB_NO_RET, and use it extend spec_ctrl_new_guest_context() with a manual fixup for hardware which mis-implements IBPB. This is part of XSA-422 / CVE-2022-23824. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich (cherry picked from commit 2b27967fb89d7904a1571a2fb963b1c9cac548db) commit 07be0fe497349ed423c5201bdc410b6281ebf04f Author: Andrew Cooper Date: Tue Jun 14 16:18:36 2022 +0100 x86/spec-ctrl: Enumeration for IBPB_RET The IBPB_RET bit indicates that the CPU's implementation of MSR_PRED_CMD.IBPB does flush the RSB/RAS too. This is part of XSA-422 / CVE-2022-23824. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich (cherry picked from commit 24496558e650535bdbd22cc04731e82276cd1b3f) (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Nov 09 12:02:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 12:02:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440890.695119 (Exim 4.92) (envelope-from ) id 1osjmt-00069i-7y; Wed, 09 Nov 2022 12:02:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440890.695119; Wed, 09 Nov 2022 12:02:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osjmt-00069b-55; Wed, 09 Nov 2022 12:02:35 +0000 Received: by outflank-mailman (input) for mailman id 440890; Wed, 09 Nov 2022 12:02:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osjmr-00069T-U8 for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 12:02:34 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80051.outbound.protection.outlook.com [40.107.8.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 63d1b9dd-6026-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 13:02:32 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8820.eurprd04.prod.outlook.com (2603:10a6:20b:42f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 9 Nov 2022 12:02:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 12:02:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63d1b9dd-6026-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YfZgdrVM4ozJQHO4h3WIoYQWbgEqLujmumztq8zHtw/31sNGTjZ/Dg2i/u3GLWMUgninCnWEQK6ZbrfA3wIslnfOl/lTqG6pa5r1kEVmn+3MPGyEv7mPupPes6mq16TsoBGrSnccpCEqMHZ5F7mu5kovpAg/RWbpWqRLQz79/W36Mty4S6oqaVCCv3OLhDSq3TRK9nzIHHwmjRV8DPq06PADu2ScmT36jQlC19KBt5XE01QicTsU0Aar1ZuJdssa7Nhk07yAW942eSa63AAyZhFP0Oi5B9Ipw3jlyY4yLRrPpjN8s4LmppBvmXN61dKYq9c0HUzGn+xHcyMQrX8acg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2YRWvhob7PLo/+0qHjSG6O0AeCXuOALRAFw2aOYy5c4=; b=JPEbm5o5t6Xpb6LGDs6eFhZKpPihRh803L79gRUxLditQfqIhRtf2fS3eo7OleoO8bUI76zRsygtB6s6jNxZrVfUBTBGU25lXDlrkwPtqDKX7OOznnvrVtfxhp5eTaZzhqdZAB8CNR3YOm/Kyg6nWhrbI+yUTiPEW3UaeJEVjPPQSpPJcKebbEnFZYQdYxQhpG8QBRjGe+Qw2X58CqfbdBEEh1PxySVrVula/U7EsXCaykSzDfBExI61dIl2XSwskR5Eo1Ost5FmPKBttAyhdA8YDQwekYsE8Yxf+RNuWDZSkpUu/buDI/ygi7g3/fSAvAPrQiZZCUaQeZ5Di6h3Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2YRWvhob7PLo/+0qHjSG6O0AeCXuOALRAFw2aOYy5c4=; b=CRIljZ68J6bdbZodV3wgF6fBjJ055lSkxqN/ub4RO6H22cv0sB0jZ9zwgc7npynAusnHtJ7RYfQOgH0Kl50/FgxQsx5WrrJbe9eCupb9WpLnA5DTwBa7CXl2TWbE2JU+awlyL+/RnrsUSc35ymZlBzPSbFTUaiW4GW/yCyfSy1DIVKtOrTMXqqRheX7JDlM4KukkXiRv9XpC0kDlvu1RUO8ytr6cJIAgmA9fJcUnGdHbff9XT0639NW95JbIQLj1l+eW+LAucHruGItBbxuhZEUTJ0tLg0Fx0bhiIRJUfTiGXZ85DTiegp57DqMODytcBbtoUfomHifvwi8azz8tbA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <31f048fc-f2e5-a421-0e60-98d1bed47ca1@suse.com> Date: Wed, 9 Nov 2022 13:02:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , xen-devel@lists.xenproject.org References: <20221108113850.61619-1-roger.pau@citrix.com> <58d5e890-e052-47df-42bb-6cc84aedd4a9@suse.com> <76cde159-088a-3351-56e2-0cf14e9c8116@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0166.eurprd06.prod.outlook.com (2603:10a6:20b:45c::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8820:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c998c50-f4e6-401f-0751-08dac24a46b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZY0vC2sV0m5O6Rv874IMf8kdoFDA0yNG9EenbtXyqKIFrP7/i0+hOIBiGLBbRIhgQAvA6Hc6pi3alexL6UNnuPZJ6L1jPDd8IqHGGcLGA1SJA80hDg6TfWpOQRfivmaR/zFMHsejwaAkllU4EcDaNWWOuhXMefhom8jbbv4PqU3L06dU59S9WKRBLeULisXJ/YjTcGZsIDKlsF4FKhMiCXIdTf7rHXSyGSd7mEj6JiJa6Tgg9XYfaT8i4YDGrxOsnjvTiKtoTmv6ILujNPmswAYoPBaKbiAq3XEJKvVcL40zKbqTLNqR9iGd714AnurF279C/lvi0+WhZ8vPbI6a2JBaZMDH+jBrqp1QwNWB94OWf5cNud8t+3ShkPYpNhSpvOTGj2480Q4o7c/ixdRuYbYZmxzqKNmsa0Cc0MeSvTB/PDu6k4lvjzi3TQxh/H8sdm9ZkceNVpwekL7vo7qRChZZO91vPv4ex7EFup4IINV1JnHiXVIq/ApZpJWQZb+P3ceunpwFTgEivks8lli60uU8KRyTFMXd348z8hCBJtEBDX76dzTNH933nwcRpocpNVbu4qiZ3r3AotoXUYzQ9o/PpbMhcrmjjN0cW6sBHrshRYSFs9E/ibWrolzATzE2sMbfy/iNt9LsAP9cJGocaMX/DDKjeJ5tAIs9FjXbcZeuyvA5CbcOBN5WFg1sd76iNdAgGOQv1xJyC2eWUAvCVViigv8x6jFYlO7TURg1s6EFORgQV3Bb/Ifie9fygj5LYSTtKnqWGbXrc+IBEQA0MBVYXwaZReKd3j5jZ9W4kJo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(396003)(136003)(366004)(346002)(451199015)(41300700001)(4326008)(8676002)(8936002)(4744005)(2906002)(86362001)(5660300002)(2616005)(66476007)(83380400001)(38100700002)(31696002)(6486002)(6512007)(54906003)(6916009)(316002)(66556008)(66946007)(53546011)(26005)(478600001)(6506007)(31686004)(186003)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzl1b0NRa0kybHZsRnVaM1ZCTWhrWHdzWjRjekNic1FJRmh3NHFhYWw0Q0gv?= =?utf-8?B?Rm9PNmlDbG13TlpsVndvUDJMT2YzNlMxVlFDY3VqbEE2VlgvaGVJZXcyQS9I?= =?utf-8?B?V082M3pvalBWaHhnNGY2aTVGSUVibnFScGtHbnlDUzhKSzlkd3VEZ2ZsazV3?= =?utf-8?B?SEQrVmZMSUxlLytGS3pZUTJ6L0oxYldWQWkvVVkyNEV3UXpWY0NnekRkbkdN?= =?utf-8?B?eERQS1ArMk1nTWlZeGIwcmttdTQ5V1VYTFpNajFqNWZadWl1SXRNN3ozeEVs?= =?utf-8?B?OGZndWxhejVHL1owa1RNN3UveGFVWnROWTlOdytaSk85Z2NzTnVUTWM5ZU9B?= =?utf-8?B?WGFXTVYyOGYvM2J1bW1OWENuTlNNakZLNGhRcEhLTUFSa25DSGVzR1BOOGdo?= =?utf-8?B?R0U1d2drVWVTd3Z0UnZ4WWFmZWNoYmlJZW04ZG5ISkdocGpoNkY5ZU15Wmha?= =?utf-8?B?UE9nY1kyeE9rc3BlQXN3c0xYeTJvUC9pNEM3VERvWnI4K21lbFRBR0pZaUtK?= =?utf-8?B?Q3MzQlVURW5nNUVoOWQ2ZkdHM3g5T1l5bllINVcwT2o3ZUk1YndQdC8yeXJt?= =?utf-8?B?ZmlKZ213c0toeTNZUThTVmU5a3A5Mm5PUDZhU3ZPdEhWa1RjNGRJMDI3ZDN1?= =?utf-8?B?Y1hKNWs5NzRiQ212TVU2UHZWSkRBN2pZYit4dHRjc3F4Vjg1QnZoL2c4RlA5?= =?utf-8?B?VDcxTDRSSG5RR1Y2MWFmazhXOUZjYTZzK1lGTDdaRUhWbS85MFVORjlpNHNs?= =?utf-8?B?M3VIMWlUa1FpUlZ5WStTcDdJRHQyQmt6V0FWTzdQaFdSeDEzNThqbjJmVEtm?= =?utf-8?B?T25SU25ldzNJdFZ2VS85aWRySTg5aWQrTzJFcC9IcHcvN2pKRmRZaks1aWpt?= =?utf-8?B?UEp3Q0VEb2VtazBINkdTTkFtbEdpcWJIYmRyVTNLdWsxeDNsdzZaUUZBZDF3?= =?utf-8?B?V1hUSVpPT016Rkk1VDZnekU0VTZ2WjNBMSs4M0ppUlhOT0ZDdWZIcFNMNE1J?= =?utf-8?B?cGZIQnA0b0lDQ3hvR0FWdFUrY3FhbzZDVWNlaksvckl3RU1RWi9YV05VT2Rk?= =?utf-8?B?UDh1ZHJuUWMrYVI5VWtob29sa0NsS0s5NkpEcE85dmVRM2U2ZGRYVjBJYVhq?= =?utf-8?B?ZDhSWDR6cDkvdys0eFAwUGsyNUNmNE1RVkpoTUJYOW9UMFo1VlFiTXhnMmov?= =?utf-8?B?Q2IxY0NxY2NTbkx6eUgvaHgrS29BS01uZnhKY01PM3M2MGZkUjJuNHNWMWtn?= =?utf-8?B?N0RUajdZZHdHVGR5R04xZ3BMcHpka2xUUUcrOFgvT28zRHE0bEdnSEFjL0Fh?= =?utf-8?B?TkhGS1MydnJmYmR2c2grUHRRQkRrWExGOHdiZmFXa1FoKzRIS3RCZTJsdUJj?= =?utf-8?B?R1pscDFjb0dncFpudlF0YXFMejRKZENoSUZyQ29jTmlnc0M1ZjI5V2RoYUVl?= =?utf-8?B?YTlNOFZmZEp4ZEtjUjBObEZpQ2JFaUxHZEtUQ2RPYTU0dURnL3I0dS9pTlZr?= =?utf-8?B?REtpSk54OXFYRXhJS1doa25VN0NmR3BQcTE3b1RFTVRNS2svQ0ltM2RQWmtW?= =?utf-8?B?UFo1eStSUFVDMktaUlJHTVhVbnBMcklJYjR1QStDWHUycy94ODg5UGE3Skth?= =?utf-8?B?NmlNc3Q2WEozY2VoYnpMKzBZRHJGNTZmcU5pY1pvWDV6T0ZjcEFId0JBNGtI?= =?utf-8?B?N2RkUGRRSkV0RTVybUhJemZ6MnBIVDlER2hFRmY5Y01NZkRRTGR6SFVzQU5Z?= =?utf-8?B?NERSdTRybkY2OWs3NkI1cU16K2w4cGNlc2sxWkpQQW1lb0p2Ri81SFNleXJB?= =?utf-8?B?TkxkN1REZHZMMnZIK3NnL2JyTlVLQUJROVBkdXRmeVkxaUhzUnU3aGFuQnNK?= =?utf-8?B?RE1yK1hVcS9oSzhpbnJHUDVTODVESnhqM0haUXhvb29GOGY0NGVCUWhvMko5?= =?utf-8?B?QnBZa0lSQzN4MThnejlCNjRwVGxwbTVUVGUzU2JET2thZE5RT3pxVVZRTXFF?= =?utf-8?B?alM4VWhqN2pSWHZQWEZVTGN3NUV5bUF6bkNZSi84SURWN2ZBejdlVzM4ekp2?= =?utf-8?B?TXlNemwyL2dMNEZaTWNyc2FOeFV4SVFkUzJudTRtSTJmUzhwRnJWa0V0bTFk?= =?utf-8?Q?mFuLsMSKtUTEccm4OAOiRZiH7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c998c50-f4e6-401f-0751-08dac24a46b1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 12:02:29.6815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fi0n2bAAu9BSAu3+kCDkLISI8pg8MJv+u5ComemY8bogQ35brmc52R+JW/UY0GvP5IFUXYmAXD079nCaUQfMew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8820 On 09.11.2022 12:36, Roger Pau Monné wrote: > Since I don't see replies to my other comments, do you agree on > returning an error then? No, my view there hasn't changed. I wouldn't block a change to go in early for 4.18, but I also wouldn't ack such. Perhaps just one remark on your other earlier comments: While you're right about XEN_DOMCTL_SHADOW_OP_{CLEAN,PEEK}, (effectively) random data in the bitmap may cause a caller to do extra work, but wouldn't look to be otherwise harmful: Considering pages dirty which aren't is never a functional problem, while considering pages clean which aren't is (imo) not a problem for a dying domain. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 09 12:18:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 12:18:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440898.695131 (Exim 4.92) (envelope-from ) id 1osk1o-0008Q9-IV; Wed, 09 Nov 2022 12:18:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440898.695131; Wed, 09 Nov 2022 12:18:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osk1o-0008Q2-F3; Wed, 09 Nov 2022 12:18:00 +0000 Received: by outflank-mailman (input) for mailman id 440898; Wed, 09 Nov 2022 12:17:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osk1n-0008Pu-7s for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 12:17:59 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b96e0d2-6028-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 13:17:57 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 34CBC226C8; Wed, 9 Nov 2022 12:17:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0EAC5139F1; Wed, 9 Nov 2022 12:17:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id F8HsAXWaa2NaWQAAMHmgww (envelope-from ); Wed, 09 Nov 2022 12:17:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b96e0d2-6028-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1667996277; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yr3VsMNK5AD4K8VNOVgIQzk0vM9N6EBiDw24ioIQ4cE=; b=mHumIm353eqkj+YZZTMIbjRWenfSlhS1Hpiq93oEIi+758EThomB1as/EDcwWvtQ6VZVg9 eQjP1L1BYGH8i0WsZVU5AmX1Hmc0tr+O8B4aQOmphBcaeUwxTFI6GrSSU5FLr/H8lkgukS hCUKXFltCu1btaoStRCz9apFPq/S6HU= Message-ID: <53c894ea-f073-7f82-69dc-99b74f501ccd@suse.com> Date: Wed, 9 Nov 2022 13:17:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-7-jgross@suse.com> <67cb3364-d5c1-28d8-4cda-8933de5cb9f7@xen.org> <703aa58c-1b7c-abb6-995d-5c5cdfcde878@suse.com> <5fe0a47c-66ca-9e0a-4742-1663c7761256@xen.org> <90878b0e-c40e-e4cc-e423-c514a72ede7f@suse.com> <10204661-e985-ef5e-b7a7-820e2dbba021@xen.org> From: Juergen Gross Subject: Re: [PATCH 06/20] tools/xenstore: remove all watches when a domain has stopped In-Reply-To: <10204661-e985-ef5e-b7a7-820e2dbba021@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------LRnbvbbvCuOzubQR5dFJs0Bo" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------LRnbvbbvCuOzubQR5dFJs0Bo Content-Type: multipart/mixed; boundary="------------SS9qB0wkPQNshs40rb83nA0E"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <53c894ea-f073-7f82-69dc-99b74f501ccd@suse.com> Subject: Re: [PATCH 06/20] tools/xenstore: remove all watches when a domain has stopped References: <20221101152842.4257-1-jgross@suse.com> <20221101152842.4257-7-jgross@suse.com> <67cb3364-d5c1-28d8-4cda-8933de5cb9f7@xen.org> <703aa58c-1b7c-abb6-995d-5c5cdfcde878@suse.com> <5fe0a47c-66ca-9e0a-4742-1663c7761256@xen.org> <90878b0e-c40e-e4cc-e423-c514a72ede7f@suse.com> <10204661-e985-ef5e-b7a7-820e2dbba021@xen.org> In-Reply-To: <10204661-e985-ef5e-b7a7-820e2dbba021@xen.org> --------------SS9qB0wkPQNshs40rb83nA0E Content-Type: multipart/mixed; boundary="------------B7xbmxkMqaNmMZUEqBGFezxm" --------------B7xbmxkMqaNmMZUEqBGFezxm Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDkuMTEuMjIgMTE6NDYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDA4LzExLzIwMjIgMDc6NTQsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP biAwNy4xMS4yMiAxOTozMywgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+DQo+Pj4NCj4+PiBP biAwNy8xMS8yMDIyIDA3OjU0LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+PiBPbiAwNi4x MS4yMiAyMjoxOCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+Pj4gSGkgSnVlcmdlbiwNCj4+ Pj4+DQo+Pj4+PiBPbiAwMS8xMS8yMDIyIDE1OjI4LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K Pj4+Pj4+IFdoZW4gYSBkb21haW4gaGFzIGJlZW4gcmVjb2duaXplZCB0byBoYXZlIHN0b3Bw ZWQsIHJlbW92ZSBhbGwgaXRzDQo+Pj4+Pj4gcmVnaXN0ZXJlZCB3YXRjaGVzLiBUaGlzIGF2 b2lkcyBzZW5kaW5nIHdhdGNoIGV2ZW50cyB0byB0aGUgZGVhZCBkb21haW4NCj4+Pj4+PiB3 aGVuIGFsbCB0aGUgbm9kZXMgcmVsYXRlZCB0byBpdCBhcmUgYmVpbmcgcmVtb3ZlZCBieSB0 aGUgWGVuIHRvb2xzLg0KPj4+Pj4NCj4+Pj4+IMKgRnJvbSBteSB1bmRlcnN0YW5kaW5nLCBz aHV0ZG93biBkb2Vzbid0IG1lYW4gZGVhZC4gSXQgbWF5IGJlIHVzZWQgZHVyaW5nIA0KPj4+ Pj4gbWlncmF0aW9uIChvciBzbmFwc2hvdHRpbmcpLCB3aGVyZSB3ZSBkb24ndCB3YW50IHRv IHRvdWNoIHRoZSBzdGF0ZSBpbiBjYXNlIA0KPj4+Pj4gb2YgYSBjYW5jZWxsYXRpb24gKG9y IHJlc3VtZSkuDQo+Pj4+Pg0KPj4+Pj4gRm9yIGluc3RhbmNlLCBzZWUgdGhlIGNvbW1hbmQg WFNfUkVTVU1FIHdoaWNoIHdpbGwgY2xlYXIgZG9tYWluLT5zaHV0ZG93bi4NCj4+Pj4NCj4+ Pj4gT2gsIGdvb2QgY2F0Y2ghDQo+Pj4+DQo+Pj4+IEkgbmVlZCB0byBhZGRpdGlvbmFsbHkg Y2hlY2sgdGhlICJzaHV0ZG93biByZWFzb24iLiBJIGNhbiByZW1vdmUgdGhlDQo+Pj4+IHdh dGNoZXMgb25seSBpbiBjYXNlIG9mIHRoZSByZWFzb24gbm90IGhhdmluZyBiZWVuICJzdXNw ZW5kIi4NCj4+Pg0KPj4+IFRoaXMgaXMgcXVpdGUgZnJhZ2lsZSBiZWNhdXNlIHdlIG1heSBh ZGQgbmV3IHNodXRkb3duIGNvZGUgaW4gdGhlIGZ1dHVyZSB0aGF0IA0KPj4+IGNvdWxkIHJl c3VtZS4NCj4+Pg0KPj4+IEkgdGhpbmsgaXQgd291bGQgYmUgYmV0dGVyIHRvIG9ubHkgZGVs ZXRlIHRoZSB3YXRjaGVzIGlmIHRoZSBkb21haW4gaXMgDQo+Pj4gZWZmZWN0aXZlbHkgZHlp bmcgKEkgZG9uJ3QgdGhpbmsgaXQgY2FuIGNvbWUgYmFjayBmcm9tIHRoYXQgc3RhdGUpDQo+ Pg0KPj4gVGhpcyBpcyBob3cgaXQgaXMgZG9uZSB0b2RheS4NCj4gDQo+IE5vdCByZWFsbHku IGRvbWluZm8uZHlpbmcgaXMgb25seSBzZXQgaWYgdGhlIGRvbWFpbiBpcyBkZWFkIChpLmUu IA0KPiBET01EWUlOR19kZWFkKS4gVGhpcyBpcyBoYXBwZW5pbmcgKmFmdGVyKiBldmVyeXRo aW5nIGhhcyBiZWVuIHJlbGlucXVpc2hlZC4gU28gDQo+IHRoaXMgaXMgcXVpdGUgbGF0ZSBj b21wYXJlIHRvIHdoYXQgeW91IHNlZW0gdG8gd2FudC4NCg0KSSBtZWFudCB0aGF0IHRoZSB3 YXRjaGVzIGFyZSByZW1vdmVkIHRvZGF5IHdoZW4gdGhlIGRvbWFpbiBoYXMgYmVlbg0KZGV0 ZWN0ZWQgdG8gYnkgZHlpbmcgKHNvIHdoZW4gcmVtb3ZpbmcgdGhlIHN0cnVjdCBkb21haW4g aW4geGVuc3RvcmVkKS4NCg0KPj4gVGhlIGRvbWFpbidzIFhlbnN0b3JlIGVudHJpZXMgYXJl IHJlbW92ZWQgYmVmb3JlIHRoZSBkb21haW4gaXMgYmVpbmcNCj4+IGRlc3Ryb3llZC4NCj4g RG8geW91IG1lYW4gYmVmb3JlIGRvbWFpbl9raWxsKCkgaXMgY2FsbGVkPyBJZiBzbywgbWF5 YmUgd2Ugc2hvdWxkIGNhbGwgDQo+IGRvbWFpbl9raWxsKCkgYmVmb3JlIGhhbmQuDQoNClRo aXMgd291bGQgcHJvYmFibHkgaW50cm9kdWNlIGEgcmFjZTogdGhlIGRvbWlkIHdvdWxkIG5v IGxvbmdlciBiZSByZXNlcnZlZA0KaW4gdGhlIGh5cGVydmlzb3IsIHNvIGEgbmV3IGRvbWFp biB3aXRoIHRoZSBzYW1lIGRvbWlkIGNvdWxkIHNob3cgdXAgYW5kDQpyZW1vdmFsIG9mIHRo ZSBvbGQgZG9tYWluIGRhdGEgYW5kIGludHJvZHVjdGlvbiBvZiB0aGUgbmV3IGRvbWFpbiBk YXRhIGNvdWxkDQppbnRlcmZlcmUuDQoNCj4gVGhlIG90aGVyIGFsdGVybmF0aXZlLCB3b3Vs ZCBiZSB0byBub3RpZnkgdGhlIFhlbnN0b3JlZCB0aGF0IGRvbWFpbiBpcyBuZXZlciANCj4g Z29pbmcgdG8gY29tZSBiYWNrLg0KDQpZZXMsIHRoaXMgc2hvdWxkIHJlYWxseSB3b3JrLg0K DQp4c19yZWxlYXNlX2RvbWFpbigpIHNob3VsZCBwcm9iYWJseSBkbyB0aGUgam9iLg0KDQoN Ckp1ZXJnZW4NCg== --------------B7xbmxkMqaNmMZUEqBGFezxm Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------B7xbmxkMqaNmMZUEqBGFezxm-- --------------SS9qB0wkPQNshs40rb83nA0E-- --------------LRnbvbbvCuOzubQR5dFJs0Bo Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNrmnQFAwAAAAAACgkQsN6d1ii/Ey+t mAf/VjEQwRfxojTfnsZnK3K6nDzaXdqMqBEw5UnbN1oM8XE7/oiwewUB1kh8FIFEB1fWAO9orprR 7d2BEGtAGDS8jIk53S1l3Zo/czbmK6HoryG3HXzbwYERkffcl96ww9OOBntyeocCVtuGoQ3HQOho Yelki+AwQIp/jVqS1eesecSQkPMi/gdCUViEnyBHkGs9euP2Ce3DF5fBcesIWDtnN+IjltK1FXyj Vue1qpkzlYOPApkmyiXr69e/awF4UopQw6GNtAf5Yg/OnZQS790rbHjdcsaL487qg9lUv0lIiPGa UTcohVnvZ9itVZNDj0hWCPP79WiWSuZH03uKJdz+mA== =+jsd -----END PGP SIGNATURE----- --------------LRnbvbbvCuOzubQR5dFJs0Bo-- From xen-devel-bounces@lists.xenproject.org Wed Nov 09 13:23:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 13:23:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440918.695141 (Exim 4.92) (envelope-from ) id 1osl2a-0000hP-Da; Wed, 09 Nov 2022 13:22:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440918.695141; Wed, 09 Nov 2022 13:22:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osl2a-0000hI-Au; Wed, 09 Nov 2022 13:22:52 +0000 Received: by outflank-mailman (input) for mailman id 440918; Wed, 09 Nov 2022 13:22:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osl2Z-0000hC-6d for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 13:22:51 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 99ec5dea-6031-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 14:22:48 +0100 (CET) Received: from mail-mw2nam12lp2049.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 08:22:35 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by CO1PR03MB5793.namprd03.prod.outlook.com (2603:10b6:303:98::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 13:22:32 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.025; Wed, 9 Nov 2022 13:22:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99ec5dea-6031-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668000168; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=hjcADLPT+zVGnCTXdSQiHI8alI0n3E4uezLp/ZU+IH0=; b=PY4LXzNB8MgI94ITsEBMY66C5bfhluapEOvH8ovM8edcfYsi8IbEHk5o QSmeOkkDbKb+j//kzD661bB1oqBcttBi7I4iw8dqO9nLIKhinvJSvY/M0 6CECsKJDmBnzScMhUf9SKci8RKZjHxBVOT3ZhJzJhz5ENzBAtIGMq6+Dv c=; X-IronPort-RemoteIP: 104.47.66.49 X-IronPort-MID: 83547295 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:46WYlq+PsbmvR3GNprsvDrUDsH+TJUtcMsCJ2f8bNWPcYEJGY0x3y TAdW2HSb/qMNDbxc9gnPYy28E5Sup/Syt5kT1Zo+Sk8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKga5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkV8 uM/CTcmfiuchvyv8JCARqpU2pkKeZyD0IM34hmMzBn/JNN/G9XmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTaNilAguFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE1rSSwXyhCd96+LuQ9t80p2a25FEvKgAKfgHg/MWYqWSzVIcKQ 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUSyAyL0LuS3A+fCUANVDsHY9sj3OcpQRQ62 1nPmMnmbRR/vbvQRX+D+7O8qTKpJTNTPWIEfTUDTwYO/5/kuo5bs/7UZtNqEarwi8KvHzj1m mqOtHJm2+RVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5H2ADwmZX1VqBGwfQ== IronPort-HdrOrdr: A9a23:RtpJJ6oT+RIUoG6wgP73m2kaV5uwL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/ Gnl7d6TnebCAIqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sP8f2F mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aiSwWdvtO OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7svVLT5ejCAB4qActIgoxUNjHD7VA7gd162K VXm0qEqpt+F3r77WjAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa RT5fnnlbhrmG6hHjHkVjEF+q3tYp1zJGbNfqE6gL3b79AM90oJjHfxx6Qk7wU9HdwGOtt5Dt //Q9RVfYF1P7ErhJ1GdZY8qOuMexjwqEH3QRWvCGWiMp07EFTwjLOyyIkJxYiRCe81Jd0J6d /8bG8= X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208";a="83547295" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hBm9VcRqsaqJzQTqW6NSxKkI9ZCTgEy/fCPxMHf2u5yuIbLxtRwED8l9DVqbqxlw8iM01Zr6zFdBGjkt32VF1V3l9MQn9IX0S8ctmDuxN/+QTrUPxECs5CrFmIEc7uAKGxQFYherPyu/UcesosZgaID7TrxxHCBZW36Wdh0W1xXeYn+MHSd+LaTP+tbXl1+7Q9TwIh8/qN0zDR3maKZfv3J2To7+jw4xjhf6YSCLbCELEL24BUXO6hIktvCYpykPeiVrkBcI0mQKh0+A6BiyzZgkqScAh7adGcnHMTdhsFyh7U3bTnjsl4VL6xgBJvJ400WS/pli3JmD3A6s9B8y7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dnkrBU9otFoxnR1euvBHtCseCIwUb3BaZS4J81TjYdI=; b=ARIPJZ2X3Cr8LLHJi4j0HLeoykmcWtZUOvjKg7r+hpf0VTTHgYys/Jie5FVoqq26kVfwo+kHjiEEkt5pSrPlr9zPCRO3umigCeLj2Aqmzhy7CxLEWEvB5RGnOzN3325O33/5tj0cx/C/tRnKTVzcCbbkFeufDjsPIUuwmCrgniDmkZ38kVtXnvOWZPdmO+MhG3tyu378RrSArebOT6AQ6dwW9SxIy89rz8meQYpWTk8oybQKcdlGdACgineMcOgcNTZLj/cj0jSJ8XUxmRXImY1DC82sOYaH4/Ql6sdDgrRcnmUVuLlYa9BnGU3XR/I4sHvfnhlk2QNvu2zu6LP58Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dnkrBU9otFoxnR1euvBHtCseCIwUb3BaZS4J81TjYdI=; b=Su9L2CjbhfGBMnCOtmap3er0bQ0YIgSboO6ptXmFCrlZ08/VWEu+Hkikb4CIXhCphjabxH456m7pJMJioFbPk1pSdH8L33gtQ8p0e9PuvrHiqEQL6gOOvvM0qsK1iWP1t05irjgLSlUa+e7A9L9LYLCg1BeXUXG2tzbE6tMFRuU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 9 Nov 2022 14:22:26 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Wei Liu , Edwin =?utf-8?B?VMO2csO2aw==?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Message-ID: References: <20221108113850.61619-1-roger.pau@citrix.com> <58d5e890-e052-47df-42bb-6cc84aedd4a9@suse.com> <76cde159-088a-3351-56e2-0cf14e9c8116@suse.com> <31f048fc-f2e5-a421-0e60-98d1bed47ca1@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <31f048fc-f2e5-a421-0e60-98d1bed47ca1@suse.com> X-ClientProxiedBy: LO4P123CA0484.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::21) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|CO1PR03MB5793:EE_ X-MS-Office365-Filtering-Correlation-Id: 75adcf18-ea8e-4042-ea41-08dac2557547 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2K/Slp3woZWt3RNHUYIiWcKBytKC/Fr1jmjMoTMzpLZoM12XRCYnWNmgecpngbl1jtKfEV4njqmfJmEEZ8yNMHSEbGsWM/dsVV2WPOFJUG95Wzor4t7U/I8UXr7sMhZGlHa7A7VfGEL/Exeh3cdhRtpSdPVhqIdUHBMyYFEz0dHbSJhEzN2AEUMLJLTLBkXJQfzKpIIQQpy9Zt6MtoYNfX7kngJaVhQTTQp+oJuRD/jr7qrC4j/lo6lLzsO3/V1F7ZOkzavIBB+hSPiIG6dJPXz3NSs6jPBL96u4kH86viB4n0hASrXe/NynB2qpw3RsT9mdb3CCaN/mYQI6iAp1JZmUYdN51rRBl19STvFYs1JPInYjxN32R7A1Hxdq+hFQ3vdBZPsxnI7lhFtgU/F/2ZQZ6Zq8ko/MdrLfXXF9zPcPZEh7gg7iK9TGC0IOD3nl3u9ou0Q2BAsI8GYUa6Jb5eveHm1bCBwqK4Ei12e4VgqCdXjLhv8dGkYm0zZKwVPWd/+aCAsAzT0FWDf7gHAqU9x6iQ0JxifH2uA8Pw37RRxlcFHEReknLra8DawQqO8sKy0yDkTad0TlHTZvmD9akPsXBOIkKT61vQwIfH5GneSFhooBiYFfBlvXIkWixqfIz6b25E/ngoqqukaFrooCTvNOtt8hYy064vL1P/q2rJH9usT5s6dQuaeQ1wHm7PADpGENfPujBCMB5raMc8SkRg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(376002)(396003)(366004)(39860400002)(346002)(136003)(451199015)(85182001)(38100700002)(41300700001)(83380400001)(316002)(66946007)(66556008)(66476007)(54906003)(6916009)(5660300002)(8936002)(8676002)(4326008)(82960400001)(86362001)(478600001)(53546011)(6506007)(6666004)(6486002)(9686003)(6512007)(26005)(33716001)(186003)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUxxR0hrN09pK3UzQUtWMG9oSEFQeTh3aWNHMCtGMHM5aEthWngwdE8vbWh6?= =?utf-8?B?ck5yeGVGczlUVGUwbUg5d0Q3bWx5REMxQ096MG1FaGtsdy9NQ1NMR1RDZzFU?= =?utf-8?B?dk9ieElRT2JPcmo5d1graGdwVXFNSGRVTzE4VXNqYUdUOUJPSmN6N1lJK0JW?= =?utf-8?B?bncwRFBmZUxOZWRvVmRQSWtzZzFSTG1BUE81SnVSZG4zNU1pbGREcFltV28y?= =?utf-8?B?Nldhd2NSODZLd0JXUWE0YUROM0lnU2l4RG9BaFMrL2hseVVQQlhoQzhVY0o0?= =?utf-8?B?aGkrOEsyeWd5aytWdFFBRnBhYTBuTzNkanRqUXdRcTkyNHVwSFMrRnNPa25n?= =?utf-8?B?TDFwa3I1S0pBYkNUU0FJbERzajllSW5RSEVKU3puaFhTTXVvd1NxNWRQZW1R?= =?utf-8?B?WTl4Vk81dnRLOElRa3oxbjFLN3pORlczeXdzaS9lVmxkRFlOMXFtZUhPZ2t3?= =?utf-8?B?L2E4K0ZaTnV4MWwyaGJvTlF6NWhEZVZ4L2tPOG1NNStvek5kUGJiNEZ3OVp5?= =?utf-8?B?dEJ2cGU4U3hwYzJjK1FuSFFQRDhkTmo3a2ZYbjhDQ0V5bHpFYWlDb2dPeTNp?= =?utf-8?B?L2hJMHF2ek5qNUdadlVDVjRlQjNkaWU2SnNUQmFPaFpwcHd6cU1HT2FzcGhQ?= =?utf-8?B?TGdUR3RPQ3Jab1NUdDBWWkZXNmZYNWpWL0tEWUszS09NaGE5dUhQR3NGTjI3?= =?utf-8?B?WDhIb21zS1I4NW84d25CZkNFa0ZBWmpOMDI1aHAxUVphZnJFeFA0VU1tKzFm?= =?utf-8?B?Wk9FajVKdi8rVHJMVnJxL1FlMlQxSkNxRWtkc25mYnZuV21BQjdBaVRuYWcx?= =?utf-8?B?bk5PTTJNdW9JNURTblZoN3F0M25LR1Z1VG44ZFhXWlhOOEpCMDZYV2NBS3RH?= =?utf-8?B?VmFvVzZVMS9TODVUOGNLa2E3MW9nL1FOM0VyOUM5Tk9uZkhadG9hLzdoU3ZN?= =?utf-8?B?SkExVWlQL3p5L1N3Z2VPWlpuMGl2Ly9va2NlUzB5WFhLMlNKdEVBQ0ZLai90?= =?utf-8?B?eGUzS09yME1OSm5RY1piMC9jVkdORlhzOVh6TkUzT2ZPaG43N0xXb1FUaFg0?= =?utf-8?B?dGRiZW1PWElxS1BqYWlNanUyZkVZRjZoMWpUZGE0TitUV0c4VnIzOW1WeGk2?= =?utf-8?B?RTZZaVgxY1ZPNVBudjVlK21OZnV0NXNBRlgwNmpKb2VoQXVyS0E3NktvM0VI?= =?utf-8?B?c0ZNVHhRNkgrYUt3QWV6YmtOUWg4b0dRdFJXKzdmM0N2VU5GbVdOUTkzQW9p?= =?utf-8?B?ZTkrWXFSdklQZlcvVkl2WDVzYWg3Z3g3REYwUHIwdHJ5U2JxSVpmanl6ZW1j?= =?utf-8?B?ZHVJTkt1T1A4OTZrOHRwL2ppanNXOGhDTXEvbnJPbDJmMnIzZmtyNUVtYWlD?= =?utf-8?B?WjhBK1BObG92Z211ZktGNEYrZEhzNTErZmZGb24wamxsOFYyMWZzQWJyQ21a?= =?utf-8?B?ckkrYWhUaForaHBWbDFWM2VpUGhWL00zYzZYNXdONXRJejNxZVZTTHhwR3l5?= =?utf-8?B?U3V2Y0NVenZrSHZSNVlmRTdCcHJWVnM2VW56SnkvczR6ZmtDZDBsMFd4SEc4?= =?utf-8?B?bWlza2RFSmJ4UGM5OWdyaXo3ODdKSHVSZGN3OEE3TkRTaFNIWnhQbkRxT0E3?= =?utf-8?B?bzIxeWg0UTdYcU5VMG92ZXRoZXZ0TzJlU0dyREprOVRHQWNFQURkbU1rYmN5?= =?utf-8?B?cnRsQmVmYnF4SWhQSXRiY1Y4MU9lNCszSkF3V2FKbmc5emZJbWhRNE1RWGcx?= =?utf-8?B?enRsL2pFSjlyWWVLd2JsbWtOKzNYNkVkWFRrS0Q0UHlaK3RmVUtGZ1RIWHpw?= =?utf-8?B?K1NyeWNVOGQ1ajZiZ1kzVkxOemN1QXQ0NFpqc1JKTjlLY2psVmhIc0ZVcUM2?= =?utf-8?B?bWlIMzhhaUZDYUNHV1hJQzZveUNjUlRrSTVPUURncVVoTnl2ai9vcFczajAv?= =?utf-8?B?OGRHeUJXOUMvcEhjMmxKNG10cDdWVStSU1BtTDY1WitaYW5RaXpZWGplTzZS?= =?utf-8?B?Vm1DYlB1YkFMSTlOK1dwOXIxbFVQbUhVanlhU1BnOTZBR2FWNWZRSHZMNG1n?= =?utf-8?B?bk1sNnZtaWViZS82cHBWcUFRWXhJMFNwelJFYjIzRUZia2lYdSt0dkpiZ29l?= =?utf-8?Q?P2vXf8saBTQ5BX5kePPNXNhi6?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75adcf18-ea8e-4042-ea41-08dac2557547 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 13:22:32.4346 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZMayW1QPNnQgUCv1KwWx9BFEC3o3nx9tTQoLo5y5PMTknmX40k7fV8O8YDXagT2NmhjWc4VL3XYwRiekODxHug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5793 On Wed, Nov 09, 2022 at 01:02:28PM +0100, Jan Beulich wrote: > On 09.11.2022 12:36, Roger Pau Monné wrote: > > Since I don't see replies to my other comments, do you agree on > > returning an error then? > > No, my view there hasn't changed. I wouldn't block a change to go in > early for 4.18, but I also wouldn't ack such. > > Perhaps just one remark on your other earlier comments: While you're > right about XEN_DOMCTL_SHADOW_OP_{CLEAN,PEEK}, (effectively) random > data in the bitmap may cause a caller to do extra work, but wouldn't > look to be otherwise harmful: Considering pages dirty which aren't > is never a functional problem, while considering pages clean which > aren't is (imo) not a problem for a dying domain. Can't that lead to failures elsewhere when attempts to fetch those pages find they might have been removed from the p2m? We are exchanging one failure path for another, but it would make more sense to return an error here instead of uninitialized data, so that the tools don't attempt to perform actions based on such invalid bitmaps. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Nov 09 13:30:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 13:30:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440925.695152 (Exim 4.92) (envelope-from ) id 1osl9b-0002VT-8b; Wed, 09 Nov 2022 13:30:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440925.695152; Wed, 09 Nov 2022 13:30:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osl9b-0002VM-5c; Wed, 09 Nov 2022 13:30:07 +0000 Received: by outflank-mailman (input) for mailman id 440925; Wed, 09 Nov 2022 13:30:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osl9a-0002Qe-CK; Wed, 09 Nov 2022 13:30:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osl9a-00064t-AY; Wed, 09 Nov 2022 13:30:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osl9Z-0001aj-Sb; Wed, 09 Nov 2022 13:30:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osl9Z-000647-SD; Wed, 09 Nov 2022 13:30:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nXOLNXjHRTJAI7L9Sp7sUAUClWEFwQ0PDLNYEK3WCRI=; b=M+KtKt6iJ/4pI6QtUMfqJ+lL/k dvXixWt0Yh5pMPMdEOfsR9k3xziWyvxMxa9jsVtFabWWI4aeGNndft4ezx8i0qHNnPCCacMms7gux ky97g4dgsjnbIKifnPXTISnjFRxBJEfcCuOX26mhgc7KVVdrKfInce2VWxkuCssKMCjM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174689: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=aa1bf3858551b7cd1facfb116fe35830aceac497 X-Osstest-Versions-That: xen=2b27967fb89d7904a1571a2fb963b1c9cac548db From: osstest service owner Date: Wed, 09 Nov 2022 13:30:05 +0000 flight 174689 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174689/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen aa1bf3858551b7cd1facfb116fe35830aceac497 baseline version: xen 2b27967fb89d7904a1571a2fb963b1c9cac548db Last test of basis 174679 2022-11-08 19:02:19 Z 0 days Testing same since 174689 2022-11-09 10:03:35 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Lindig Edwin Török Juergen Gross jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2b27967fb8..aa1bf38585 aa1bf3858551b7cd1facfb116fe35830aceac497 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Nov 09 13:45:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 13:45:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440933.695164 (Exim 4.92) (envelope-from ) id 1oslOB-0004RF-JK; Wed, 09 Nov 2022 13:45:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440933.695164; Wed, 09 Nov 2022 13:45:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslOB-0004R8-G8; Wed, 09 Nov 2022 13:45:11 +0000 Received: by outflank-mailman (input) for mailman id 440933; Wed, 09 Nov 2022 13:45:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslOA-0004R2-2t for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 13:45:10 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b812bc50-6034-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 14:45:07 +0100 (CET) Received: from mail-mw2nam12lp2046.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 08:45:01 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by BN8PR03MB5091.namprd03.prod.outlook.com (2603:10b6:408:d8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 13:44:59 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 13:44:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b812bc50-6034-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668001508; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=qXD1RxX7vqdw4JgR/bVNDIO4Shxu73cXxJbUFzFSm/A=; b=OSeA/5rcBbzvkjszH6tEYS2aUOLvCIH5kxMfM82J/fxVqBUfmW/pgOUE s4mFlQEST6ZBBXUF7kJU0V+88T7MxtM4YomTEhE+B8Nx25Qr0bY2YQjOS RxVL5reg9SlDFpvaYSke8kK/tdVXMqX4OeO593j3O8BN0XIcLIldDIwOx U=; X-IronPort-RemoteIP: 104.47.66.46 X-IronPort-MID: 87009260 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8xQmJ6DhHImmQBVW/xbiw5YqxClBgxIJ4kV8jS/XYbTApGgihDICx mcbUTzXOPeCNzTye9F+YIq18xtTucXUn9RlQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpA7wRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5cB5BWduz t8kcA8cNU+p1/D17b6eRbw57igjBJGD0II3nFhFlGucKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTL++xrvQA/zyQouFTpGNHVYN2RWcRcmACcp 2TK/mvRCRAGLt2PjzGC9xpAg8efwnujCdhMTNVU8NZWn3q6/00wNCQRFnyDkMi7jH7gWu9Qf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpSNEgrt5wejUs2 XeAhdavDjtq2JWZQGyQ3q2ZpjSzPW4SN2BqTTAAZRsI5Z/kuo5bs/7UZtNqEarwi8KvHzj1m mqOtHJm2+tVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5H2ADwmZX1VqBGwfQ== IronPort-HdrOrdr: A9a23:Kcqscq/uIOagoSVfxp5uk+Fudb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZquz+8O3WBxB8bpYOCCggeVxe5ZnOzfKlHbehEWs9QtrZ uIEJIOReEYb2IK6/oSiTPQe7lP/DDEytHQuQ609QYOcegeUdAF0+4PMHf/LqQZfml7LKt8MK DZyttMpjKmd3hSRN+8HGM5U+/KoMCOvI76YDYdbiRXpzWmvHeN0vrXAhKY1hARX3dk2rE561 XIlAT/++GKr+y78BnBzGXehq4m1ucJi+EzRfBkuPJlaQkEuTzYJriJnIfy+QzdldvfqGrCVu O85yvIcf4DrE85NVvF3CcFkzOQrArGrUWShWNwyEGT3/DRVXY0DdFMipledQac4008vMtk2K YOxG6BsYFLZCmw1RgUd7DzJm5Xf2eP0A0feNQo/gpieJpbbKUUoZ0U/UtTHptFFCXm6Jo/GO 0rCM3H/v5ZfV6Tcnic5wBUsZeRd2V2Gg3DTlkJu8ST3TQTlHdlz1EAzMhamnsb7poyR5RN+u yBOKV1k7NFSNMQcMtGda88aNryDnaITQPHMWqUL1iiHKYbO2jVo5qy+7kx7PHCQu198HLzou W1bLp1jx9AR6u1M7z+4HRiyGG8fEytGTLw18pZ+591/rXhWbuDC1zwdGwT X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208,217";a="87009260" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UzBMxRBsY83oz8IaQTJ4S3BF4REz0+vKpyFQ2d24aVm6n/8o3gjDlN1kKtUySwOs6eicw3GIHvjbpgpcjYnn8aGMUS++N19wg+9Wre5koWOVaxEiRO+2mYUSyuE4S5J9ewWPGTagSdr2jshrS3FNh8I2tqHuDSekSUiPIrha80baaCaCXdoFW8hjsJrOWli0lsK7icXkdj+7/gt05YrpgK+Exl6w2jFvilDBvXE2f3U4gBqTX4uXDbQOLbx3TALLMJjdmFE+9tJewP8la2oFJSkTugtpDYSJ7/bI/kPdpRgsmS6fEffkPD7EnBhd1wk82W0R19mLZVMANzLQoBzgNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qXD1RxX7vqdw4JgR/bVNDIO4Shxu73cXxJbUFzFSm/A=; b=RXAnUBvVv7/6Mw+rtVoO+BNPlRDB08cJoK2R683EktRskC8YYwi7YGUDNoGcYHYb9tJ2UUoaWavOMSGTbCAgKuXU4dm17Xx/qdnM0ysP3Nj9ye1n6kD613t3UBfZUUGPHaMWb2+b92grzCM8v6b9RXrlB2CpwGFRqjBg1k9AvASPcqwYug8ZWG+jVG5IB5qGNd7WWFCUrsYa9g+aEo6jdYHpPwW0ec8x5QCPHLyXfYxjXmcH/EPz2k9h0f0AAQ9ga7cPFu2kQMHfAhCK6i3FobmaQjtiuvH/m1NzCKxgjnO9f866hQiC3LsPjSoXvwZAs+nmyc+qR6BmNA/+gq45XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qXD1RxX7vqdw4JgR/bVNDIO4Shxu73cXxJbUFzFSm/A=; b=TgTfe3xCQNi8GqDjpCUGw1bup9Xy967hvCBlK8xBQyH2H7wU3saP3/IGTewjdFEjC7/vuS3Kffkpir8npCeVG4sLpI9Muf30Q29DEZI27dIPU+NvRBVMCc9oLIjZ3Fkw73OIbRNAP4v7CZAjGM2sgJ8aLnzsERWge1Zz3TOkb0U= From: Christian Lindig To: Edwin Torok CC: Xen-devel , Henry Wang , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 04/15] tools/ocaml/xenstored/Makefile: use ocamldep -sort for linking order Thread-Topic: [PATCH for-4.17 v3 04/15] tools/ocaml/xenstored/Makefile: use ocamldep -sort for linking order Thread-Index: AQHY84eenq2hHhUnbkWZgEyFUAHf2K42m9eA Date: Wed, 9 Nov 2022 13:44:59 +0000 Message-ID: <1D39E366-149F-4478-89A4-E31C4E05BDA6@citrix.com> References: <2acb17a3046dad442ef0e14c84c7aa5930e69e93.1667920496.git.edvin.torok@citrix.com> In-Reply-To: <2acb17a3046dad442ef0e14c84c7aa5930e69e93.1667920496.git.edvin.torok@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|BN8PR03MB5091:EE_ x-ms-office365-filtering-correlation-id: b0d80a95-3eb6-4e96-0818-08dac258981d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MLasqbFxvfyC1ds6DqblTDIheYgHF96T4ZdH6aw4VK1Updna6VT/Ii9OgqwiMQVHJVLW96BF8LV6kE6WzW5PEeSADzvQXGOsIvrAh++zXu0H3RASDHc2ZxmmIJ+yzNsv/lojX+HLWOMBnhfb2gWG2jmTKDGShcL/6S0VGlkokUIKuPZh9seXeOhnJUYh7s5wHgfgOcywCTuLz8Ay8e3FpNXMSrawUwHNCCnv/mMpkelwtiW4HffEjB+UwLS9zMNkCOaT3S9Nxjqpd6fLo+8lBnXd71rk/KN59kVut0+QYdm9WOoev87xTz5r5XzpmLmhxJsZ2Q/+02gBwLRZ+hAi7aap7aQ6LeTwtx2wcPCX2+LL7v8cETuSON/MNfs/maMT1nrAE2JfBll00ZjZzAC7vCeHJBZwuo4bSk3nzvyqd3VkEMqHC/T6iJhX90xGkhNj3jGfc2XwMu6O33+JrGocmcO/JCpsNrAfg6crL6/p9Gl3r4DjREBZjsHfEVeHfg/f3C7K2Dv/UZwDAUuyjgVC3mN95Ejs/drrS5fx7XHnXMmbSClIO/Czf/68gzfAgsHtEH8RhejqWdkfjp121lL62NmvdLlvYLi4e0+eQU15Jn0Ac+PXPgixzATLpuL2ejdEmBtmhRKbIpeiNJDW1TRmKF3bUaUtl6DgAiHaDPEvwnepoW75E1JZExS5EQrVw6u5dgLG4Frtxz++LVcE6sSpSleqILvmo6IHYKttMMB12qNYXLtaziyqu8zeAORGCWFnG/chMw09Oro6t0ZlNFepkd3FFKMbc70MJ67MYnt9/tM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(366004)(39860400002)(451199015)(36756003)(6506007)(33656002)(86362001)(82960400001)(38070700005)(38100700002)(122000001)(2616005)(83380400001)(54906003)(37006003)(6636002)(186003)(2906002)(6512007)(53546011)(26005)(66574015)(44832011)(5660300002)(107886003)(8936002)(478600001)(71200400001)(6486002)(66476007)(66446008)(64756008)(8676002)(66556008)(316002)(41300700001)(66946007)(6862004)(91956017)(76116006)(4326008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UnpNdTZyRTVPdGZTVXBDQURXK0JrNVQ1WW1ibGdKYW0yOEZ3OVpZRVZCMytI?= =?utf-8?B?TTBORmp1QjZDczhyeVYrTjNBN0tTU2IweXVsVjdmQXJxNkI1Y1RpTDFpVzlZ?= =?utf-8?B?b0dLUmQrNGgxN0xsMGxoWUxOczlXKzZFSFNQQVBrYjhEa2FyU1VRak1pb2lW?= =?utf-8?B?NW01UEhVLyt2eFl2TW4vYS9Nc1ZBNy9aSXJhQW9Od3dlQVBKek5VVDJPNjJW?= =?utf-8?B?NlJ2TnNXNXJNZWdKanFwNUwxLzJrUVVqbkdBVVRmanI5NzhJUkZsOUpuc3h4?= =?utf-8?B?L2tRSGhoVGlQWThEMVhIc1UzeVdnb1NOZHhrU1ltWE42UnhYNHJ3UFl4RnFT?= =?utf-8?B?UlhXVWM5TmVsYVFMdUtCR0pXYU96bGVXYndSbHVmL2s3TnREa1RSU2REZGdm?= =?utf-8?B?SW1TdDFtYVJKYTJCd2pCMVM2cUxtdGYzemxnRmNILzJ0MEo5UU9RSVBuV3ZN?= =?utf-8?B?MGxrVWVWQ0FwU3dsYkQ2SVI1REVuMVFGYys2elgrMTVYN05meTVzNDROeVJO?= =?utf-8?B?SGEyZlZnYXpCK3lXeFRUUi9qYUdla25YRm9NbG5GK0lMYnMra2F6Z0pCQ3di?= =?utf-8?B?M0dhU1JzaHZkNWFUNDhLa1krRG1talFhK3BUeGtoMHBSSHF3RVlBTW1wVE5h?= =?utf-8?B?dEdQektQckFKWjN6U3NEMTNvTnZ1WlZialhzVTdBOFZOclk2c3ZGQStHNWxn?= =?utf-8?B?aEF1ZnBVcE5vbzQ4RmZPNCtnSzZGYlgzbXpRa2xmOFdFajNkZVdLbzBXcWFu?= =?utf-8?B?UkNJR0RuWUVuVmplSE9ZR1BpRFk2NytzL05GMlFpTGtXbDZpSzZkekQvOTla?= =?utf-8?B?aUZNQUFQRkorbVVxNjBqY3NXZ2RHQWRPRjkzMG5ZTVEvanFETXR2ZExuUzdi?= =?utf-8?B?djJYRU1HUmV2TUtRYlN5Vk1YTDNpSHJzQmFwUHRCS2xHMkIrT0RuQmxNNHFp?= =?utf-8?B?eGpybjhvSEs4MUZUU0QySC9oMmI0ZG9RVU5xRDlEVitITndrTW9uYWhCdzVJ?= =?utf-8?B?MzIyL3JhcnZ4SU5SOE9VV0NUN2ZFS0ZxaUFDTi8yTE9icnp5QXdMamxDZVRx?= =?utf-8?B?Z1gyYXk5V3lKNkt6WnhCQWNQY0NCV0F0ODhid3g5Z3hvY0cwNGQvbVBqbWkx?= =?utf-8?B?ZVU0M2x4VVRCU0JzTjVBRStjR1ZYYi9lVDhjanM3OUZ3bGhHS3FkN0ZBSVNV?= =?utf-8?B?QmY5cXN1azAzSHlzck00d3J4dUxRWGtHYzdzK2tKVFd3bEh0SzJrMHdtaG5r?= =?utf-8?B?UFhaRWJqY3IwYS9XOWJXWFNybXdONXFlcmV0Vm00T3kybUpNMm5Ia2hyOFcy?= =?utf-8?B?SjJRQzFMYzQxZnp3ald4QTBqSktKSGhCYmtHbytONE0vaHdnUEZWRitQUExQ?= =?utf-8?B?U0ZIVUhQOCtjQlV2cjB2WWtHTEp2ZWk5S1N6dnA3bGZJS2d1Y0tQUzd4cU80?= =?utf-8?B?aHZaeWowTFpNa2ZMQmY2SWt2eDE5OEUzYlVkZDliUk54ekJ2QUdCK1NKVUQx?= =?utf-8?B?Z2ZEc1dIWFgyQllXdk1EL2xEM0pnVVVPR2pRcjBmSDcyWTdlQ08xcTdEaDBz?= =?utf-8?B?cDhLTU9vRGVjNXlXNG9ZNThPRzUyRDlJdHV1L1g4dTAvWXhnaXE3VkYySTNo?= =?utf-8?B?VTAwSkZKanJtcUt4MHVzc0FMOTU4NEpjK244NCtKRUladmlFL2NyT1VYNjFi?= =?utf-8?B?Y0xxR3J5WEo0V0xSNE9WdDNkL295akFUTktENkJGVzJnUHlyS1UwSWVEYVg2?= =?utf-8?B?a1FVMG5DcmZEeEZVUDN2YUxYd1lxNEN1Y3dpZjQ4K2hlN3hvT1pjNjFUNTRL?= =?utf-8?B?Q1dKTGRLNjdEUFlOTW1CUGM2Si9OazVNUXNuSHVxNWZ2cmQ3d0NBaXppVTE3?= =?utf-8?B?V1VrSlJXUEhGTFlwd1ltWjVXZXFBOWxnUnN5UFM4WVcydWpoQ29EODZ0cE53?= =?utf-8?B?SmR0U1A4NkJFbnM1QWdLckdKM0ZwdUdSN0k5VHNaL0RuMVZZci9vQnIxWWVR?= =?utf-8?B?WVpqOWNMSm5zRktJYWgrMG0xTmJ5Y09wRHdQZk5vTFdmbk5xajB6MHJyY1pj?= =?utf-8?B?MGZhZXBVaEpCb1dKbXhWZmZicDRqdktPbnBoblRjTkVlMFA2dys0NUpldWxZ?= =?utf-8?B?d1FQZHB5M1dYNVBRSHhtVVZtbS9VZC9oV2t0MFpWTFBYcllxSFNxbStZejhj?= =?utf-8?Q?6Q8xRym+Ag9maxFbr75oFTc=3D?= Content-Type: multipart/alternative; boundary="_000_1D39E366149F447889A4E31C4E05BDA6citrixcom_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0d80a95-3eb6-4e96-0818-08dac258981d X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 13:44:59.1140 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: np2N0vr81QVlF4zUlhrUUbgxmN0TEyL/YGajAj3e/xdWo3br1LHbv9HurMt3rwZuBtAC+ALvgTE/RFbkwNRZZEJMYyWdkI2LrEddal8EZQA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5091 --_000_1D39E366149F447889A4E31C4E05BDA6citrixcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DQoNCk9uIDggTm92IDIwMjIsIGF0IDE1OjMzLCBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jva0Bj aXRyaXguY29tPG1haWx0bzplZHZpbi50b3Jva0BjaXRyaXguY29tPj4gd3JvdGU6DQoNCkEgYmV0 dGVyIHNvbHV0aW9uIGlzIGJlaW5nIHdvcmtlZCBvbiBmb3IgbWFzdGVyLA0KYnV0IGZvciBub3cg dXNlIG9jYW1sZGVwIC1zb3J0IGluc3RlYWQgb2YgYSBtYW51YWxseSBlc3RhYmxpc2hlZCBsaW5r DQpvcmRlci4NClRoZSBtYW51YWxseSBlc3RhYmxpc2hlZCBsaW5rIG9yZGVyIHdpbGwgYmUgd3Jv bmcgd2hlbiAoc2VjdXJpdHkpDQpwYXRjaGVzIGludHJvZHVjZSBuZXcgZGVwZW5kZW5jaWVzIGJl dHdlZW4gZmlsZXMgdGhhdCB3b3VsZCByZXF1aXJlDQpjaGFuZ2luZyB0aGUgbGluayBvcmRlci4N Cg0KSWYgZHVuZSB3YXMgdXNlZCBhcyBhIGJ1aWxkIHN5c3RlbSB0aGlzIHdvdWxkbid0IGJlIGEg cHJvYmxlbSwgYnV0IHdlDQpjYW4ndCB1c2UgRHVuZSB5ZXQgZHVlIHRvIE9TU1Rlc3QsIHdoaWNo IGlzIHN0dWNrIG9uIERlYmlhbiBvbGRzdGFibGUuDQoNCk5vIGZ1bmN0aW9uYWwgY2hhbmdlLg0K DQpTaWduZWQtb2ZmLWJ5OiBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jva0BjaXRyaXguY29tPG1h aWx0bzplZHZpbi50b3Jva0BjaXRyaXguY29tPj4NCi0tLQ0KUmVhc29uIGZvciBpbmNsdXNpb24g aW4gNC4xNzoNCg0KQXZvaWRzIGhhdmluZyB0byBwdXQgdGhpcyBwYXRjaCBhcyBhIHByZXJlcXVp c2l0ZSBpbnRvIGEgc2VjdXJpdHkgdXBkYXRlLg0KRWFybGllciB2ZXJzaW9ucyBvZiBYU0EtMzI2 IG5lZWRlZCB0aGlzLCBhbmQgYWx0aG91Z2ggbGF0ZXN0IHZlcnNpb24NCmRpZG4ndCB3ZSBkb24n dCBrbm93IHdoZXRoZXIgaXQgbWlnaHQgYmUgbmVlZGVkIGFnYWluIGluIHRoZSBmdXR1cmUgb3Ig bm90Lg0KDQpDaGFuZ2VzIHNpbmNlIHYyOg0KLSBuZXcgaW4gdjMgKHdhcyBwcmV2aW91c2x5IGVt YWlsZWQgdG8gc2VjdXJpdHkgdGVhbSB0aG91Z2gpDQotLS0NCnRvb2xzL29jYW1sL3hlbnN0b3Jl ZC9NYWtlZmlsZSB8IDYgKysrKystDQoxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAx IGRlbGV0aW9uKC0pDQoNCkFja2VkLWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGlu ZGlnQGNpdHJpeC5jb208bWFpbHRvOmNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4+DQoNCg== --_000_1D39E366149F447889A4E31C4E05BDA6citrixcom_ Content-Type: text/html; charset="utf-8" Content-ID: <0CBBE93AAF09FA4DAEA69CD08EAC3BBA@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJ3b3JkLXdy YXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZTsgbGluZS1icmVhazogYWZ0 ZXItd2hpdGUtc3BhY2U7IiBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NCjxkaXY+PGJyIGNsYXNz PSIiPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2xhc3M9IiI+DQo8ZGl2IGNsYXNzPSIiPk9u IDggTm92IDIwMjIsIGF0IDE1OjMzLCBFZHdpbiBUw7Zyw7ZrICZsdDs8YSBocmVmPSJtYWlsdG86 ZWR2aW4udG9yb2tAY2l0cml4LmNvbSIgY2xhc3M9IiI+ZWR2aW4udG9yb2tAY2l0cml4LmNvbTwv YT4mZ3Q7IHdyb3RlOjwvZGl2Pg0KPGJyIGNsYXNzPSJBcHBsZS1pbnRlcmNoYW5nZS1uZXdsaW5l Ij4NCjxkaXYgY2xhc3M9IiI+PHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7 IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6 IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0 dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7 IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6 IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5v bmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPkEN CiBiZXR0ZXIgc29sdXRpb24gaXMgYmVpbmcgd29ya2VkIG9uIGZvciBtYXN0ZXIsPC9zcGFuPjxi ciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJl Z3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQt Y2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0 ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7 IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ry b2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4g c3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1 bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNh cHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4 dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3 aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9r ZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5 OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPmJ1dA0KIGZvciBub3cgdXNlIG9jYW1sZGVw IC1zb3J0IGluc3RlYWQgb2YgYSBtYW51YWxseSBlc3RhYmxpc2hlZCBsaW5rPC9zcGFuPjxiciBz dHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3Vs YXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fw czogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0 LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdo aXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tl LXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5 bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFy OyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6 IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1h bGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0 ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13 aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBp bmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPm9yZGVyLjwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0 LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNp emU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsg Zm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3Rh cnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTog bm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4 OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1j b2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXpl OiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZv bnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0 OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5v cm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsg dGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBv cnRhbnQ7IiBjbGFzcz0iIj5UaGUNCiBtYW51YWxseSBlc3RhYmxpc2hlZCBsaW5rIG9yZGVyIHdp bGwgYmUgd3Jvbmcgd2hlbiAoc2VjdXJpdHkpPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6 IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFw eDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdl aWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4 dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7 IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQt ZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiBy Z2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7 IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWln aHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQt aW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3 b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRl Y29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsi IGNsYXNzPSIiPnBhdGNoZXMNCiBpbnRyb2R1Y2UgbmV3IGRlcGVuZGVuY2llcyBiZXR3ZWVuIGZp bGVzIHRoYXQgd291bGQgcmVxdWlyZTwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2Io MCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZv bnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6 IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5k ZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3Jk LXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29y YXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAs IDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250 LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0 MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVu dDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1z cGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0 aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFz cz0iIj5jaGFuZ2luZw0KIHRoZSBsaW5rIG9yZGVyLjwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNv bG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6 IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9u dC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7 IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9y bWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0 ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxiciBzdHlsZT0iY2FyZXQtY29sb3I6 IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFw eDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdl aWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4 dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7 IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQt ZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiBy Z2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7 IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWln aHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQt aW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3 b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRl Y29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsi IGNsYXNzPSIiPklmDQogZHVuZSB3YXMgdXNlZCBhcyBhIGJ1aWxkIHN5c3RlbSB0aGlzIHdvdWxk bid0IGJlIGEgcHJvYmxlbSwgYnV0IHdlPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJn YigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsg Zm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdo dDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1p bmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdv cmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVj b3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2Io MCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZv bnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6 IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5k ZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3Jk LXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29y YXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNs YXNzPSIiPmNhbid0DQogdXNlIER1bmUgeWV0IGR1ZSB0byBPU1NUZXN0LCB3aGljaCBpcyBzdHVj ayBvbiBEZWJpYW4gb2xkc3RhYmxlLjwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2Io MCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZv bnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6 IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5k ZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3Jk LXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29y YXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAw LCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1z dHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAw OyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6 IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3Bh Y2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlv bjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwg MCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5 bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsg bGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAw cHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNp bmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246 IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIi Pk5vDQogZnVuY3Rpb25hbCBjaGFuZ2UuPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJn YigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsg Zm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdo dDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1p bmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdv cmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVj b3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAs IDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250 LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0 MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVu dDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1z cGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0 aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAw LCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1z dHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAw OyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6 IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3Bh Y2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlv bjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9 IiI+U2lnbmVkLW9mZi1ieToNCiBFZHdpbiBUw7Zyw7ZrICZsdDs8L3NwYW4+PGEgaHJlZj0ibWFp bHRvOmVkdmluLnRvcm9rQGNpdHJpeC5jb20iIHN0eWxlPSJmb250LWZhbWlseTogTWVubG8tUmVn dWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1j YXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IG9y cGhhbnM6IGF1dG87IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRy YW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd2lkb3dzOiBhdXRvOyB3b3JkLXNw YWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXNpemUtYWRqdXN0OiBhdXRvOyAtd2Via2l0LXRleHQt c3Ryb2tlLXdpZHRoOiAwcHg7IiBjbGFzcz0iIj5lZHZpbi50b3Jva0BjaXRyaXguY29tPC9hPjxz cGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8t UmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFu dC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7 IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9u ZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1z dHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlz cGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj4mZ3Q7PC9zcGFuPjxiciBzdHlsZT0i Y2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZv bnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9y bWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWdu OiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNw YWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRo OiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNh cmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250 LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1h bDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjog c3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFj ZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDog MHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUg IWltcG9ydGFudDsiIGNsYXNzPSIiPi0tLTwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiBy Z2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7 IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWln aHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQt aW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3 b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRl Y29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdi KDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBm b250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0 OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWlu ZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29y ZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNv cmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBj bGFzcz0iIj5SZWFzb24NCiBmb3IgaW5jbHVzaW9uIGluIDQuMTc6PC9zcGFuPjxiciBzdHlsZT0i Y2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZv bnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9y bWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWdu OiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNw YWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRo OiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPGJyIHN0eWxlPSJjYXJl dC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1z aXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7 IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0 YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6 IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBw eDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQt Y29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6 ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBm b250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFy dDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBu b3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7 IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1w b3J0YW50OyIgY2xhc3M9IiI+QXZvaWRzDQogaGF2aW5nIHRvIHB1dCB0aGlzIHBhdGNoIGFzIGEg cHJlcmVxdWlzaXRlIGludG8gYSBzZWN1cml0eSB1cGRhdGUuPC9zcGFuPjxiciBzdHlsZT0iY2Fy ZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQt c2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFs OyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBz dGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNl OiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAw cHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0 LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNp emU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsg Zm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3Rh cnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTog bm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4 OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWlt cG9ydGFudDsiIGNsYXNzPSIiPkVhcmxpZXINCiB2ZXJzaW9ucyBvZiBYU0EtMzI2IG5lZWRlZCB0 aGlzLCBhbmQgYWx0aG91Z2ggbGF0ZXN0IHZlcnNpb248L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1j b2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXpl OiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZv bnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0 OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5v cm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsg dGV4dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29s b3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTog MTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250 LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsg dGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3Jt YWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRl eHQtZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0 YW50OyIgY2xhc3M9IiI+ZGlkbid0DQogd2UgZG9uJ3Qga25vdyB3aGV0aGVyIGl0IG1pZ2h0IGJl IG5lZWRlZCBhZ2FpbiBpbiB0aGUgZnV0dXJlIG9yIG5vdC48L3NwYW4+PGJyIHN0eWxlPSJjYXJl dC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1z aXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7 IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0 YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6 IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBw eDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8YnIgc3R5bGU9ImNhcmV0LWNv bG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6 IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9u dC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7 IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9y bWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0 ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xv cjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAx MXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQt d2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0 ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1h bDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4 dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRh bnQ7IiBjbGFzcz0iIj5DaGFuZ2VzDQogc2luY2UgdjI6PC9zcGFuPjxiciBzdHlsZT0iY2FyZXQt Y29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6 ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBm b250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFy dDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBu b3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7 IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNv bG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6 IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9u dC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7 IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9y bWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0 ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9y dGFudDsiIGNsYXNzPSIiPi0NCiBuZXcgaW4gdjMgKHdhcyBwcmV2aW91c2x5IGVtYWlsZWQgdG8g c2VjdXJpdHkgdGVhbSB0aG91Z2gpPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigw LCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9u dC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDog NDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRl bnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQt c3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3Jh dGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwg MCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQt c3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQw MDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50 OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNw YWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRp b246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNz PSIiPi0tLTwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQt ZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1h bDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNw YWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQt dHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsg LXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBj bGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZh bWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7 IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFj aW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRy YW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13 ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9h dDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj50b29scy9vY2Ft bC94ZW5zdG9yZWQvTWFrZWZpbGUNCiB8IDYgKysrKystPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQt Y29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6 ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBm b250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFy dDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBu b3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7 IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNv bG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6 IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9u dC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7 IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9y bWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0 ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9y dGFudDsiIGNsYXNzPSIiPjENCiBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbigtKTwvc3Bhbj48L2Rpdj4NCjwvYmxvY2txdW90ZT4NCjwvZGl2Pg0KPGJyIGNsYXNzPSIi Pg0KPGRpdiBjbGFzcz0iIj4NCjxkaXYgc3R5bGU9Im1hcmdpbjogMHB4OyBmb250LXN0cmV0Y2g6 IG5vcm1hbDsgZm9udC1zaXplOiAxMXB4OyBsaW5lLWhlaWdodDogbm9ybWFsOyBmb250LWZhbWls eTogTWVubG87IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJmb250LXZhcmlhbnQtbGlnYXR1cmVz OiBuby1jb21tb24tbGlnYXR1cmVzIiBjbGFzcz0iIj5BY2tlZC1ieTogQ2hyaXN0aWFuIExpbmRp ZyAmbHQ7PGEgaHJlZj0ibWFpbHRvOmNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbSIgY2xhc3M9 IiI+Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPC9hPiZndDs8L3NwYW4+PC9kaXY+DQo8L2Rp dj4NCjxkaXYgY2xhc3M9IiI+PHNwYW4gc3R5bGU9ImZvbnQtdmFyaWFudC1saWdhdHVyZXM6IG5v LWNvbW1vbi1saWdhdHVyZXMiIGNsYXNzPSIiPjxiciBjbGFzcz0iIj4NCjwvc3Bhbj48L2Rpdj4N CjwvYm9keT4NCjwvaHRtbD4NCg== --_000_1D39E366149F447889A4E31C4E05BDA6citrixcom_-- From xen-devel-bounces@lists.xenproject.org Wed Nov 09 13:45:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 13:45:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440936.695175 (Exim 4.92) (envelope-from ) id 1oslOl-0005Ag-18; Wed, 09 Nov 2022 13:45:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440936.695175; Wed, 09 Nov 2022 13:45:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslOk-0005AZ-Ua; Wed, 09 Nov 2022 13:45:46 +0000 Received: by outflank-mailman (input) for mailman id 440936; Wed, 09 Nov 2022 13:45:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslOj-0004mS-G8 for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 13:45:45 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cd19f284-6034-11ed-8fd2-01056ac49cbb; Wed, 09 Nov 2022 14:45:43 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 08:45:40 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by BN8PR03MB5091.namprd03.prod.outlook.com (2603:10b6:408:d8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 13:45:38 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 13:45:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd19f284-6034-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668001543; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=HF0P9vqaKpD/FTVavSte2LSRi4ofWrEYIf1qyn26ov4=; b=SnE/XPPy+AM0XX0CWIhb5tSa+h6BVpRL4DMuGGD9MxnkSVkw/KL601VZ oGGitCAYjKPgpJ1ghe9xe/dp9bOJep/znqAhmZo8qKCljsaffZSqEPjJC RTiBk/RRkehhK6d/p20hVWNUHTXX/KvCBbS0JCE5oeHOAArOP60zDurRS A=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 83549086 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:sZZHyqu7ADTPkh18zsQvDh6dEefnVGhfMUV32f8akzHdYApBsoF/q tZmKW2COq6CNjD2Kd5+btyxpksAvMOBzN4wSFRoqCo9F39H+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaGxiFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwDm1VSU+uuN+K+LvqeLF2pOcFFJnCI9ZK0p1g5Wmx4fcOZ7nmGvyPz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgP60boq9lt+iHK25mm6Tp njH5Hj4CxdcMN2ZxTuK2nmtmvXOjWXwX4d6+LiQpqU33AzLljJ75Bs+SnjhqPe6s1aFfsMBN UwzyhBx8IU06xn+JjX6d1jiyJKehTYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/ n+Emcn4QwNmtrK9QGiYsLyTqFuaNSELIEcYaCQDTA9D5MPsyKksijrfQ9AlF7S65uAZAhn1y jGO6SI417MaiJdS073hpA6XxTWxupLOUwg5oB3NWX6o5R94Y4jjYJG07V/c7rBLK4PxokS9g UXoUvO2tIgmZaxhXgTXKAnRNNlFP8q4DQA= IronPort-HdrOrdr: A9a23:/+KHiaxHPC4RuE9yE2elKrPxmuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk80hqQFm7X5XI3SFjUO3VHFEGgM1/qE/9SNIUzDH6tmpN 9dmstFeZDN5DpB/KDHCWCDer5OruVvsprY/Ns2pE0dLz2CHpsQizuRfTzrd3GeKjMnObMJUL 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUazpALtzIS/PwmT3x8YXT8K66wl63 L5nwvw4bjmm+2nyyXby3TY4/1t6ZXcI5p4dY2xY/ouW3bRYzWTFcZcsnq5zXUISdSUmRYXeR /30lMd1opImjTslyqO0GbQMkHboUoTAjnZuBOlaDLY0LLEbSN/BMxbiY1DdBzFr0ImodFnya pOm3mUrpxNEHr77W3AD0ihbWAUqqOYmwtUrQcotQ0obaIOLLtK6YAP9kJcF5kNWCr89YA8Ce FrSMXR/uxff1+WZ23Q+jAH+q3mYl0jWhOdBkQSsM2c1DZb2Hh/0ksD3cQa2nMN7og0RZVI7/ nNdq5oiLZNRMkLar8VPpZIfeKnTmjWBR7cOmObJlrqUKkBJnLWspbypK444em7EaZ4uKfaWK 6xJW+wmVRCCH4GU/f+raGj2iq9MFmVTHDq1txU4YR/t/n1WKfrWBfzOmwTrw== X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208,217";a="83549086" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SLqXLB2FCMCCzFKaMIW6L4qBlcmPHnG8QvvEOhROziLHS338qinIhOf4sS+EMJBcDz9Hl5sRD1BFAIDeVBH+PARhUg7XVyvSXCi3r+gpqonLM56Rx1SduvN7BXFoGLMkztfVc0Jl8Z5zfKiWmfDe+uKsGbUZtO3yrNMejLwFaIfylGoXIfXIluM59xmauxhOBbWFeqanNH6i6B/mYFef99643PoM9bJWL83PEoQGn0vCXCA/XrHLd/+IEq8sxfLh8mF6DAtI0fcz7HRY1kvE2uN+zJbeAKnz0shx6uR1NzPOYGMCh/AiNI28DjKKoAZvXPj0q0bmXl9Krw4yudmKlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HF0P9vqaKpD/FTVavSte2LSRi4ofWrEYIf1qyn26ov4=; b=OSiym9xXg1cUMutz0VUi6u3ShYJJuxhuA4fZtiL3LnDkDoFULyv7PKWLCPKwpPNfjo+/onZFYTK+4ZP1rj8+vnEynQBps+8zlJC6WbCi30GDX1RSOFW0HfxJ4N7TEW9g6CR295eJPC5MrHSN/RK4+JwcLK6O34BkFxlyKSCe+fqO0wYarfV/VerH531kTZLxYWp4ZJQjtyjG86iYr7r0uUULCewXovj3lcpotdDHALfhcgwtRNEng1O9c1VQNN7FmWCNd/k7g5BtYccoFCoksWp6gzudvo5n/3BP7DXPmEXjkjmXxqNMBajEQIzvMjv1Bx+fWWFndiK4991eM7gUQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HF0P9vqaKpD/FTVavSte2LSRi4ofWrEYIf1qyn26ov4=; b=pELuIx5TpWOF4BDB8kIfldL61/GFFQ/qTwPxk/jtxFq3Lr65C1QHTts/Td7nxHbMXTCIrrlAWBviGqTG4mauMsbNTkG2pSOku8NB+fhADs6esFZ+NsCfVxShkdQ2oQRP1W+HL5rtTcJsW7NTWWurqMi2w5jBCMZUEzBUWziWKwQ= From: Christian Lindig To: Edwin Torok CC: Xen-devel , Henry Wang , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 05/15] tools/ocaml/Makefile.rules: do not run ocamldep on distclean Thread-Topic: [PATCH for-4.17 v3 05/15] tools/ocaml/Makefile.rules: do not run ocamldep on distclean Thread-Index: AQHY84ejWSXxO+ZaA0e7Bcm1DYF0ca42nAaA Date: Wed, 9 Nov 2022 13:45:38 +0000 Message-ID: <8FE08DB8-BFCB-490D-8A97-4E713B82B1F0@citrix.com> References: <62e88f2badd7bb3cfb709254258dc6af40c87a45.1667920496.git.edvin.torok@citrix.com> In-Reply-To: <62e88f2badd7bb3cfb709254258dc6af40c87a45.1667920496.git.edvin.torok@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|BN8PR03MB5091:EE_ x-ms-office365-filtering-correlation-id: 02be2b63-df71-4ec7-1d00-08dac258af65 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eIaUhPnTesfdRWhfbU267/pONCV88wl9PdHt8ptyhcq+Bsp4fhfwipZ9w0IVNdmLxub/Kpiqs3Oo1X+2oPdLGLMn8x+BceB6PFDTYDeeXGnf+bok2IyMEidRdB56IoEaoSN+bCP2HGHdCgxJzM6ShgKyDnoVtaFdNdYo+bbMg6srAyWHwWg4QWT4R7c3TtIh0foKgBPjQs9+2FguCw6w09DBEqkce2jkfKvNroW/Si7Nsq7Rfrehr0Mk+gQofMztkkGLsURO3h6RBIW2xAfnxks56HJTXyIBKD0L03hAByB/8iYEUPaswAvPfFaP9rclvJDoIzfmrsJ82kANvTvOSeuD1nqee+V+aylBCDcKfQYqYPeIKvdEfC0yshcryunFPcUNJ9LjOxS1PlYkDhWkkRl1SQnYAvtKBnHCIYvnFg4Gm7Hvu5EPh/4SpINDlYn705kAUUQsPuaNRc1/NuWOZYWaStScmSp6Igwv+qazKSwO8bSXVqkRLlPWw2WldAGy+Zb5v7C+cr9BkLj7AdUfPVECb9cjhnqom9iU0mUKdYGGhwzNU3uEHNM3B9VtZRI1/RSE8B6wqxtfLr+Qb4m/N+haglRskp2QJY3DXKIUmWwxS4dRVXIn48RB1S7Bb2e/hcKJyIHUrgdVdL5xesTdxg8xAtqLE50gwGvaEVP3L7hewSeUG2+IdWcNDGfjHQVwyw+cEsm1LTeJI0fz2QZX1uWvdSSeMmSpu4/IEEFCnj8BMOKnZJulgdjXdRxJ2iAVxTQlN6LA5uZe1ugo412Y9DSZ+5lNyIRd8YjL55C24xs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(366004)(39860400002)(451199015)(36756003)(6506007)(33656002)(86362001)(82960400001)(38070700005)(38100700002)(122000001)(2616005)(83380400001)(54906003)(37006003)(6636002)(186003)(2906002)(6512007)(53546011)(26005)(66574015)(44832011)(4744005)(5660300002)(107886003)(8936002)(478600001)(71200400001)(6486002)(66476007)(66446008)(64756008)(8676002)(66556008)(316002)(41300700001)(66946007)(6862004)(91956017)(76116006)(4326008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bjUxckJYeDdRdVgvaVpmOEpleWlHc0RjaDAvNUFNMmk3eWlheTZrQUE4aU1T?= =?utf-8?B?QlNRaEo2RFZUclA1M2UzRkJJQ1dkUENNOVJTbWp3NGJaWlRZN1JVY01sYURX?= =?utf-8?B?NXlZNDJ6TFF6NlkrMmxJTXZEN1JHbXgzMkgwTXNreUFoZ2ZQalJ4MUJoM3hl?= =?utf-8?B?am1mZ3RSUnlwZ01jWDdqRk9rcHZNc095L04xQnRlVnZrY2k0bmFpTFZ6UjVR?= =?utf-8?B?TkpUdHg0UzFweUMwbk0wZ2FyRWNHVzBTNDBPYXlJUjZlRFE3MWs3aWZZK2Zq?= =?utf-8?B?dHRGV25wTFB1UTloL0JhZEtQZTN0UWQwTncvKzlOZlp0blhSZWtHMkNoTW1o?= =?utf-8?B?UU5jRERzSi9rcFVkc0VyS2xWQytqVkVhVzB0eW5sUTh0TlQyNmpyb21zNHJv?= =?utf-8?B?Y012eVRLeCt5b3lWRFRYYXQ5eXM2RGJnd0V1RkJhak1ZQjROOE0zSCt5SmRk?= =?utf-8?B?VldIbWNNRldwSkhVbmlJMzhuU091bGtZYzN5bG1mQTBsRURzMXJ0a2dXanJq?= =?utf-8?B?cENLSUgxa1RVSWprb2xmSkI0R0xpbFNMUVdUY2FNWjVTcXZSUU9VUnJBMXYv?= =?utf-8?B?WG9MR1dRcWhVL3lFS1RsOFhYZ011NjM4NEE4TDhnR3IxeGRTaHBtYUFmNm5U?= =?utf-8?B?bStrdVJWNHdWMkVvMG5pV3I5UjMvK3dKT0ZYRHJkY0ltWVoyNTdzMk10VW9Z?= =?utf-8?B?QnMwMFVEU3FLS1BHVHpnZTVxOS9xckxtWE92MDBURURrYyt3dzVIZTFlMGV3?= =?utf-8?B?TGVzeTF1cG9KMWpJblRLNjUvdW1DaHIrNU9VMWh3c2Vxcm12b3VnRXA4SmNy?= =?utf-8?B?MFhwYXZUN3pCOU9XdXdMcnJHRHF6cjEzK3RMNUcvR2toaWt3TzZNQzNiTGtp?= =?utf-8?B?UUc2NXZIYlhaZEFOUGROdDNGdFh1M1NpUWNhVFdKOHpncXI4cUM3eC9sZ0FY?= =?utf-8?B?SU5Vbkc5NDJieTVxWGxDZVNUZ2x0RU9LaFJ3MmZKbkpscmZHUVdJY29qSWFa?= =?utf-8?B?endVYS9xNE1SYXBDMHo2WGxDYWhyczFtaUVJeTZyY2M0cjNTMm9KVTg1TDY4?= =?utf-8?B?cElSQWFQaDhLVkJoZmliNE1EWmtoeTdzU0N4OGFsbkZFemxDb0trYzNlcWh2?= =?utf-8?B?aVBGTUlxZDhmN3FvNG1uQjBlWERXSXFtaHY2d2g4VG1HZEZhaFlOdTYrc2hK?= =?utf-8?B?Ykc3Mk96OG5LWEhsVFV0VkdYSG1PbDZ2Mko5MDVPenBFV1VHMi9JSlIzcXVP?= =?utf-8?B?MHM1OWJ2UlhlaVQzRlhTL1lhenEwUUpBN2gzeEY2bis0Nm1EMlFFQmF5TWRJ?= =?utf-8?B?M09laFJ3Sk1xY25INmtxUVh0RXhza3NPbDNBRjZOVFZMK2EwY1p1WTVYanh4?= =?utf-8?B?QVNhQTkxNVlBUVBKTEZUMHk0bm9TUmNwVWdJWGVWYnVESTNCZ2FvRU9HYWxF?= =?utf-8?B?SmpwVE45ZVprMVVZcGliY0xtZUNKZXlaZFJsbXF6SU5JRkt0b3RjcEhya1F3?= =?utf-8?B?REwxTGp4aWNKQjRrU2tJTmVJdUxMRzgzb1VuWkpRTkgyZUhVelVuSVltdnlW?= =?utf-8?B?OVo4d1NiOFdvUjFwNmFLd3h2Tm5BczFjV3RiNjF5emFGRXR3aXZmOUw2dnBn?= =?utf-8?B?bXgzcE94bkIrc2JsNTF0YjE5L0s0WUNmeldlc3F0M1ljTG9KSzUyRzlZWmVR?= =?utf-8?B?VDVjaUhidDE5S3EyUWRvdktlSStOdVVSODJZNitKTUpMclN0TnFiU3BBcWVK?= =?utf-8?B?clVCTDlWUWFjay9pUUIzSEtVVFJrb3NIQzdwdlVvOWJ6Tm1WYzlXOUFyYlFP?= =?utf-8?B?Y2QwWEl3blc3dEtRL0pneTl0SmpXOS9McGd2L2JHOHNqWW81ZzZQM3FjeEtX?= =?utf-8?B?RHBHSHZ0SGZudHNiSUR4QndaNzZ0azdWQ0RnWkhyYkcwVXUzNnpXNW1Eam82?= =?utf-8?B?cGtweTFBUWs2cC9RTU1PYUVYQU1SMW83c2JUSkNKWmkvN2FlZC9LT2Y3ei9p?= =?utf-8?B?RzVBR2ZzQnBVdC9uV0MzMnVaeGJEN1ZraEVRaFhaN0Rray9PMnVrUDgrSW5O?= =?utf-8?B?UnRYT29QQWo0Z2wwWXV2T3J6MUREc2lIb1VLRDQxdDdhQzR0eHlVVlR2V3Zh?= =?utf-8?B?U3BXeElVcXRvYkhjTU9lQWxIR1pnU2NYTEd4cnE0MW5aNlBKNklqRzd0QUZU?= =?utf-8?Q?7SeDuLBzoVe+kGjJveZcZw4=3D?= Content-Type: multipart/alternative; boundary="_000_8FE08DB8BFCB490D8A974E713B82B1F0citrixcom_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02be2b63-df71-4ec7-1d00-08dac258af65 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 13:45:38.1740 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: czVrIQUA07u7m2gxgz8ABTizl/Arc9PHc0g51FDFJgXM0JCrbTm6aOTEWUgjuwx8J0kp54JL6t8lzNmw/60xnkE/DZfGnPQlxLLRoG/uEdg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5091 --_000_8FE08DB8BFCB490D8A974E713B82B1F0citrixcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DQoNCk9uIDggTm92IDIwMjIsIGF0IDE1OjMzLCBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jva0Bj aXRyaXguY29tPG1haWx0bzplZHZpbi50b3Jva0BjaXRyaXguY29tPj4gd3JvdGU6DQoNCkZpeGVz OiAyZjJiNzZkNDdjNWJjZDkgKCJ0b29scy9vY2FtbDogZG8gbm90IHJ1biBvY2FtbGRlcCBkdXJp bmcgbWFrZSBjbGVhbiIpDQoNClNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLDtmsgPGVkdmluLnRv cm9rQGNpdHJpeC5jb208bWFpbHRvOmVkdmluLnRvcm9rQGNpdHJpeC5jb20+Pg0KLS0tDQpSZWFz b24gZm9yIGluY2x1c2lvbiBpbiA0LjE3Og0KLSBhZGRyZXNzZXMgcmV2aWV3IGNvbW1lbnRzIHJl Y2VpdmVkIHBvc3QgY29tbWl0DQoNCkNoYW5nZXMgc2luY2UgdjI6DQotIGFkZCBGaXhlcyBsaW5l DQotIGFkZCA0LjE3IHJlYXNvbg0KLS0tDQp0b29scy9vY2FtbC9NYWtlZmlsZS5ydWxlcyB8IDIg Ky0NCjEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KDQpBY2tl ZC1ieTogQ2hyaXN0aWFuIExpbmRpZyA8Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPG1haWx0 bzpjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+Pg0KDQo= --_000_8FE08DB8BFCB490D8A974E713B82B1F0citrixcom_ Content-Type: text/html; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJ3b3JkLXdy YXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZTsgbGluZS1icmVhazogYWZ0 ZXItd2hpdGUtc3BhY2U7IiBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NCjxkaXY+PGJyIGNsYXNz PSIiPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2xhc3M9IiI+DQo8ZGl2IGNsYXNzPSIiPk9u IDggTm92IDIwMjIsIGF0IDE1OjMzLCBFZHdpbiBUw7Zyw7ZrICZsdDs8YSBocmVmPSJtYWlsdG86 ZWR2aW4udG9yb2tAY2l0cml4LmNvbSIgY2xhc3M9IiI+ZWR2aW4udG9yb2tAY2l0cml4LmNvbTwv YT4mZ3Q7IHdyb3RlOjwvZGl2Pg0KPGJyIGNsYXNzPSJBcHBsZS1pbnRlcmNoYW5nZS1uZXdsaW5l Ij4NCjxkaXYgY2xhc3M9IiI+PHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7 IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6 IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0 dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7 IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6 IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5v bmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPkZp eGVzOg0KIDJmMmI3NmQ0N2M1YmNkOSAoJnF1b3Q7dG9vbHMvb2NhbWw6IGRvIG5vdCBydW4gb2Nh bWxkZXAgZHVyaW5nIG1ha2UgY2xlYW4mcXVvdDspPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29s b3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTog MTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250 LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsg dGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3Jt YWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRl eHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPGJyIHN0eWxlPSJjYXJldC1jb2xvcjog cmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4 OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2Vp Z2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0 LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsg d29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1k ZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJn YigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsg Zm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdo dDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1p bmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdv cmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVj b3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIg Y2xhc3M9IiI+U2lnbmVkLW9mZi1ieToNCiBFZHdpbiBUw7Zyw7ZrICZsdDs8L3NwYW4+PGEgaHJl Zj0ibWFpbHRvOmVkdmluLnRvcm9rQGNpdHJpeC5jb20iIHN0eWxlPSJmb250LWZhbWlseTogTWVu bG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFy aWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3Jt YWw7IG9ycGhhbnM6IGF1dG87IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0 ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd2lkb3dzOiBhdXRvOyB3 b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXNpemUtYWRqdXN0OiBhdXRvOyAtd2Via2l0 LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IiBjbGFzcz0iIj5lZHZpbi50b3Jva0BjaXRyaXguY29t PC9hPjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTog TWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQt dmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBu b3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9y bTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQt dGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9u ZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj4mZ3Q7PC9zcGFuPjxiciBz dHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3Vs YXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fw czogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0 LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdo aXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tl LXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5 bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFy OyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6 IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1h bGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0 ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13 aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBp bmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPi0tLTwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNv bG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6 IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9u dC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7 IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9y bWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0 ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xv cjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAx MXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQt d2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0 ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1h bDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4 dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRh bnQ7IiBjbGFzcz0iIj5SZWFzb24NCiBmb3IgaW5jbHVzaW9uIGluIDQuMTc6PC9zcGFuPjxiciBz dHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3Vs YXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fw czogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0 LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdo aXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tl LXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5 bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFy OyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6 IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1h bGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0 ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13 aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBp bmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPi0NCiBhZGRyZXNzZXMgcmV2aWV3IGNvbW1lbnRz IHJlY2VpdmVkIHBvc3QgY29tbWl0PC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigw LCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9u dC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDog NDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRl bnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQt c3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3Jh dGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAs IDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0 eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7 IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDog MHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFj aW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9u OiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAw KTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHls ZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBs ZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBw eDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2lu ZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjog bm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9IiI+ Q2hhbmdlcw0KIHNpbmNlIHYyOjwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwg MCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQt c3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQw MDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50 OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNw YWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRp b246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAs IDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0 eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7 IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDog MHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFj aW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9u OiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0i Ij4tDQogYWRkIEZpeGVzIGxpbmU8L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAs IDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250 LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0 MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVu dDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1z cGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0 aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAw LCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1z dHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAw OyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6 IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3Bh Y2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlv bjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9 IiI+LQ0KIGFkZCA0LjE3IHJlYXNvbjwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2Io MCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZv bnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6 IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5k ZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3Jk LXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29y YXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAs IDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250 LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0 MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVu dDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1z cGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0 aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFz cz0iIj4tLS08L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250 LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3Jt YWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1z cGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0 LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7 IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIg Y2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1m YW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFs OyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3Bh Y2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10 cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAt d2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxv YXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9IiI+dG9vbHMvb2Nh bWwvTWFrZWZpbGUucnVsZXMNCiB8IDIgKy08L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjog cmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4 OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2Vp Z2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0 LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsg d29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1k ZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJn YigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsg Zm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdo dDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1p bmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdv cmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVj b3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIg Y2xhc3M9IiI+MQ0KIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSk8 L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTog TWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQt dmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBu b3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9y bTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQt dGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+ DQo8L2Rpdj4NCjwvYmxvY2txdW90ZT4NCjwvZGl2Pg0KPGJyIGNsYXNzPSIiPg0KPGRpdiBjbGFz cz0iIj4NCjxkaXYgc3R5bGU9Im1hcmdpbjogMHB4OyBmb250LXN0cmV0Y2g6IG5vcm1hbDsgZm9u dC1zaXplOiAxMXB4OyBsaW5lLWhlaWdodDogbm9ybWFsOyBmb250LWZhbWlseTogTWVubG87IiBj bGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJmb250LXZhcmlhbnQtbGlnYXR1cmVzOiBuby1jb21tb24t bGlnYXR1cmVzIiBjbGFzcz0iIj5BY2tlZC1ieTogQ2hyaXN0aWFuIExpbmRpZyAmbHQ7PGEgaHJl Zj0ibWFpbHRvOmNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbSIgY2xhc3M9IiI+Y2hyaXN0aWFu LmxpbmRpZ0BjaXRyaXguY29tPC9hPiZndDs8L3NwYW4+PC9kaXY+DQo8L2Rpdj4NCjxkaXYgY2xh c3M9IiI+PHNwYW4gc3R5bGU9ImZvbnQtdmFyaWFudC1saWdhdHVyZXM6IG5vLWNvbW1vbi1saWdh dHVyZXMiIGNsYXNzPSIiPjxiciBjbGFzcz0iIj4NCjwvc3Bhbj48L2Rpdj4NCjwvYm9keT4NCjwv aHRtbD4NCg== --_000_8FE08DB8BFCB490D8A974E713B82B1F0citrixcom_-- From xen-devel-bounces@lists.xenproject.org Wed Nov 09 13:46:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 13:46:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440944.695185 (Exim 4.92) (envelope-from ) id 1oslPZ-0005qN-DC; Wed, 09 Nov 2022 13:46:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440944.695185; Wed, 09 Nov 2022 13:46:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslPZ-0005qG-9k; Wed, 09 Nov 2022 13:46:37 +0000 Received: by outflank-mailman (input) for mailman id 440944; Wed, 09 Nov 2022 13:46:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslPX-0005SK-RH for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 13:46:36 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ebdabb73-6034-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 14:46:34 +0100 (CET) Received: from mail-mw2nam12lp2048.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 08:46:31 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by BN8PR03MB5091.namprd03.prod.outlook.com (2603:10b6:408:d8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 13:46:28 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 13:46:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebdabb73-6034-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668001594; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=6ExMJ6Bcxyp7lBROnucTsS7m0RjURorrugpcaA9NmP4=; b=HU3iz+vnAngNwLBT7K3NzMaMbC/lTYjIODSb/WPlPJ63LmkZ4ctTdg0/ t3wmuZp/SnNHzXnGrwqYeCHNz5sOXAU9Fy0f9/jbG6ONWi+0LOqgqnItJ 4tq4NX5tdBm/4S04osT28C+rc2HApzCoabBro4qxOFa4KvgRtslI1PYeQ I=; X-IronPort-RemoteIP: 104.47.66.48 X-IronPort-MID: 87009401 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:/ITS66ylqYw/bb5ntON6t+cIxyrEfRIJ4+MujC+fZmUNrF6WrkUFz GJKUDvSM/7ZYGH9f4olPIXn8hgDv8XRnNRgHlFu+SAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPaET5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KW9S+ e4hJG5SV0+ord+4/bemE8dDvf12eaEHPKtH0p1h5RfwKK98BLX8GeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvTaVkFwZPLvFabI5fvSBRd9UhVqZr 2SA+2X/DhAVHNee1SCE4jSngeqncSbTCN1KTOzkrqcCbFu79FM/VQcSTHSBrfiiyXKmSYwCE VME0397xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnO87QyY7k GCAmdzBDCZq9raSTBq1+r6KoBuoNCMSLGtEYjULJSMa5/HzrYd1iQjAJuuPC4awh9zxXDTvm TaDqXFkg61J1ZJbkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5 BAs8/VyJshXZX1RvERhmNkwIYw= IronPort-HdrOrdr: A9a23:a6XhTaGaSVN6vVV/pLqFXpHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5VoMkmsj6KdgLNhd4tKOTOLhILGFvAE0WKP+Vzd8mjFh5ZgPM RbAuVD4b/LfD5HZK/BiWHWferIguP3iZxA7t2urUuFODsaD52ImD0JbzpzfHcXeCB2Qb4CUL aM7MtOoDStPV4NaN6gO3UDV+/f4/XWiZPPe3c9dlEawTjLqQntxK/xEhCe0BtbeShI260e/W /MlBG8zrm/ssu81gTX2wbontprcZrau5p+7f63+4sowwbX+0SVjUNaKvi/VQUO0aGSAZAR4Z 3xSlkbToNOAjjqDxyISFPWqnXdOXAVmjPfIBaj8AXeiN28SzQgB8Vbg4VFNhPf9ko7pdl5lL lGxmSDqvNsfFr9dLSU3am2a/hGrDvCnZMZq59ks1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO 1jFtvV6vpaeU6TKymxhBgl/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+ 7ELqNrnrdTSdJ+V9M0OM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaDKDgDKFC7a gpfGkoxlLaIXieePFm9Kc7gizlUSG6QSnnzN1Y6txwpqD8LYCbQxG+dA== X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208,217";a="87009401" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oA9clM7dYJZphSigS6Bl5q40MsdaYYrlbiVWombi8JVR7BeGLvUm7VXIP9t+8Yb5i40KMNNlsh9warTpnB9GNeziFp+mUf54WAqE0U0cdjCB4+/hIr6XfyZSGz7FhvS4oJGf7HxuitzSgsfxz2BUap6CkP+PiAnI0GiGVSgcVZPOEM7R2dBNbXtQdCfSAbUYUEcVkTl+TE8BDtuwNN2rz5mQ6RxBDpnQnrhJ/bkabYbKVcb2lFf70+gGNRAZ/jwuf9mBjQudmIAYA+V/ySkhu7sa8KpdSWZG8zJHEnO04pLQ1mg1jykTU2VS3J8UbvIUqM10bcA2NhSOeFYg8Jd8YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6ExMJ6Bcxyp7lBROnucTsS7m0RjURorrugpcaA9NmP4=; b=EJdbvetDKHxPzcryJyZrHPxyo7s9d62uVfz1LcWX4f92LZok4thi/4R0QcgDqt6JruwD0YMpAvCAdS2fSkpzB5qqE2honkAyM469DXgDMYild165OVR8vfAZAB5n4yCKhT9G/zBdQpohNLXvRxSBmW/GjGdQZRuZpH+D3hnSgFfFb+qTV/CV8zSUYlxnZE6rWlRsqBG60AaQG1hU4UTkS3wvbwzAakruV8YthujMcPPQeMPk7qqPbF3rFImS1+56A3oBFd7t4pgcSkmVn8GZ5QI+BuE+e/NjtEAO6cCz4a4YJvJXJ698vDka9cJLn4QZuxuEpwUxEqPBny5h/MI1IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6ExMJ6Bcxyp7lBROnucTsS7m0RjURorrugpcaA9NmP4=; b=P3L77jPVdO9r5fhoycxABliu7A8iHquOSAY+b8Uspuk9FoDtqH3VZq7Akr4olJFgMJMiY4yHk0QqvolInjYLwF7GmW9JS2xyva/0tpk157cgBg99D8j/x5/cVSUVQV2AP+ykF+Dvm+UtKhl+vtUC7f3ZTAJt8+K3VEYjPDAYggE= From: Christian Lindig To: Edwin Torok CC: Xen-devel , Henry Wang , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 06/15] tools/ocaml/Makefile.rules: hide -include on *clean Thread-Topic: [PATCH for-4.17 v3 06/15] tools/ocaml/Makefile.rules: hide -include on *clean Thread-Index: AQHY84egv97Aid+RO0WEqxNULoHifa42nEMA Date: Wed, 9 Nov 2022 13:46:28 +0000 Message-ID: <24D29D42-7458-407B-870B-43CE32B4E13C@citrix.com> References: <2a584406ee8cc1fce5175ad04feee6fdb18b6844.1667920496.git.edvin.torok@citrix.com> In-Reply-To: <2a584406ee8cc1fce5175ad04feee6fdb18b6844.1667920496.git.edvin.torok@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|BN8PR03MB5091:EE_ x-ms-office365-filtering-correlation-id: 0acd23d3-666f-4b7a-bbba-08dac258cd80 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ogktAEFLpE9+PFYVT+0MBH972X3aK7kv+wUz07kQD9baBG/FS+UqG3M7sNTnFaejExbtcWxRktIeMYlyx4KYrFdO1JMCmCPhkXfB+54lHFNcaJhb/AgqxHvTuAKG+nKTIdFiI3OOpxcibQIl3/V8TykYLBF7VhfAhPfXObnNNfRd4WJK6ioP50eNKNYQ1yKZLtOo1tLvVz4EzHrDlH7oRZ3s+9tHyMmAU7PN9NTcbqbWghAqXVh/uBip90JkDnU6zuDkWPQILRjzuCO/BW1icTB0b+YuwVx6NEgJGNOiIlroiu+0YNqCvSzGwYIdJAURAU8Fk+GoiGmJA5nQqvDY8n4WLpQ4wwWMSw58D24THWNepxUmA63+EIH/9TFZ9eODv8t4cGofMimJz63S/7X6yWeFEy0B4maTGqi5dnoyTTwrVbk5ddBmSScuE6l1xxU3WB0z/OaPiy1L3KRTYNFhDhXXEstdocwS6vi8Fbdzj3nKAhmBOxqMMKaNw8wXRCICz+UrKyxTGwQMuyseW88lBr74IHu6IIwBF0DZInrrJrBcNuuTp4bjG1cqaE9jfe/CM8KRDZVECLOMwVWuXBSXropgEENSF+PvF3SKv5+iSCC2T2jQ/nGoJzR/6becwhLp9lTmH3fj9bTaz0kCONjlAZqx7AbhdSgVk7tjji/df6sdeCZFF2C1jCQBO3qBYr8RW+/znAlVm/OO8zsXRalioe5KXyM2bNmP5nop4EyebtALXm8TJGyJlUwovQ9xLoj967AmfT+QGv4FDnZw+lk+MqMLdk2HS4o7qC0y0TkedZk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(366004)(39860400002)(451199015)(36756003)(6506007)(33656002)(86362001)(82960400001)(38070700005)(38100700002)(122000001)(2616005)(83380400001)(54906003)(37006003)(6636002)(186003)(2906002)(6512007)(53546011)(26005)(44832011)(4744005)(5660300002)(107886003)(8936002)(478600001)(71200400001)(6486002)(66476007)(66446008)(64756008)(8676002)(66556008)(316002)(41300700001)(66946007)(6862004)(91956017)(76116006)(4326008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dVlrMkdyY0YxYWxjSDZKMFluMHVYVWhCa2dUYWQ2STlwanpHakJ0UDBXRThF?= =?utf-8?B?VGJjSkVHd0RSYmlVdFJBNUgvaFdZZHJHRTl4eitCTGxRbENyVFZLSGZ5OTBN?= =?utf-8?B?dTErUE5mUGZGY3NXMlVHWFRhc0VMV1BrTjFuTW5VL0Z3OGRqbzV3UHNpYnJ6?= =?utf-8?B?WFZ1L1JxTFJCUDlHVHNxSnNpeTRqVndyd2htR3o1YU82SEdCY2l3THdNRyty?= =?utf-8?B?QmZkMVo2L0kweDZLRnRiTk9GNjZTVzRSc3lPZ3N4bzNHakNIbmVyTzNuVW9W?= =?utf-8?B?QjRpVVFGYmNKMXUwY0xZbUw1TEJsVXlZUjA3elE0RW53Q05mUU9yMEVDSFRs?= =?utf-8?B?eUpaV3ZmYjNTKzBwTjFWWkNWcmxpK2Y5cHdBQU5Xd0xHalJvZTliYWRiSi81?= =?utf-8?B?aG5QY2R4R05ZS24xZEZHM3dOS2trWHZycFhpZVQ1a1ZlSUNuU0RFM0NzWURJ?= =?utf-8?B?bHRHMzZwSkZSc3dFK2s0b3FOU3RLRy9CUkdjLzRtdlErZmdxMDRtcmNOY3FE?= =?utf-8?B?anZ4bU9seVhldTVHUWs1K2M3Yk1YUmY3ZDAzRTNmRm5OWWwyUWhUanJ3QklJ?= =?utf-8?B?RzZQV2ZIOXNBNXhBWUNTN1N3R09oNlJwM3Y3OU9qMzdPMXNxVkpWeUlDTGQ2?= =?utf-8?B?RFlHNmZIYkJVWm8rNkhyeFRncldvckxXME5PUHk0TEM2MHcwNXdYbVlFZFMz?= =?utf-8?B?Yk1FN0RGd0xQVThGK0gxeUI2dU1MZGlWNHhqQk5PRnM1R2UyUXhGSGJTQk5S?= =?utf-8?B?OUlmY1hGT2dqQXlRQ2hnMWQvTTNGOERIV25raDcxbG5BVk0ya0E0VGZHaGQ1?= =?utf-8?B?K3JLMWowa0sxQUJFM3gxT2lsQTVicmdYdWdaYWtzUmQ4YWp1RURLbWV3N1dt?= =?utf-8?B?TG1XamEvL1I1eURpbE5FaHpzQ3hFYXFJWVQ4ZGdVOTlzSnN1TEh5R21mUm1h?= =?utf-8?B?NkIwdmVOSlBFUWozYzN2ZTJEWG90azR6V1JyRTJYMjZQVkVPcGN1QS9oWWxQ?= =?utf-8?B?L3lFRy9tYmh1UzY3WGFvbkRWLzYzY2ZtZmFOcEU0YzlrcWFLWE9taXkrc3NF?= =?utf-8?B?N2RycUNPb1oxS3RlTHBmczZYN1o1Rm82RU9rbkRjTFRNWkFqbzhQRm5DWjlp?= =?utf-8?B?WE9ZNW9ZMVhhdkYxOE1xZnlxbCtIZTRxQklmY2R5WmVvRXNYbk84aHZDeTFM?= =?utf-8?B?TTB5WjhXUDdtY0JXSkxCNjVkUS9GZ3owYkoybEFuVnltaUg0MkxmM09QSmJN?= =?utf-8?B?QmpoK0VuNWFKcnl5M1BHU3EyN2xrY255U3BSOWRWb080NklGUzh6Lzh6Rmtx?= =?utf-8?B?MVFzWUV0cW0xaUNiYlErY29LY1pwcFJ3U09KYWtrUkFJKzFlRFBLbkZjeFVi?= =?utf-8?B?Y3VldXFHT0RWRmlFQU5zeFptUGFKYWQ2ZTJFaHlHREcwdXJna2F5WUxXbnNX?= =?utf-8?B?djU2eEorZWJyYU5RZXhYQm5KLzZscVdaMmVWa0psU1ppZExUczdRRmZTZEcx?= =?utf-8?B?Rk1KZDUyZDJXdnhBSmFaVWlhcC9Za1ZHZEk4anZ5YVArRTFISnRXMWo1WThQ?= =?utf-8?B?cFNSTGVWNFB5TVFaY21SQ0NqcDM2S1VuWk92YVREeExDbE5YNSt0MXlMa0ZE?= =?utf-8?B?VWtYMFRPaXBpczU5R0g4VHpKbUtkaVQwcnNXeGcwUmhSZENCdHVUMU5CUmp4?= =?utf-8?B?ZWV6ZmVFcXNyTUxNK2ZHN1JiT0RtQzJFOG9tSHl1TU8wWmpBVE84N3pEaU1w?= =?utf-8?B?OXFKMnJ2cmlWYnlGNldUUy9rdkRGNThLQjJ1V2hRWktaRTcvNS9yOE1QblVn?= =?utf-8?B?emVVU0JhMmVuYVZaaWVMMEQ5ZFJyWURuejFMNmlsN1JJWjUyblYzN1o0T1Qw?= =?utf-8?B?V1hkcEhEWWZEVkRVOEl2eXpOMVBhUFAvdnU4U01UZXNpNDA2SGQ2cGxDZkE3?= =?utf-8?B?RlREaFNQTG5Gcm4raEtJVk9tUGpTVG12bEFuaURrbVRwZWlpWDVMcXBHajRq?= =?utf-8?B?UXR4cmgrSVI4dnBXSmNPaHFZRmo1aHBZUEZVQnJBV2VJTzA4M2F6SG5QODYx?= =?utf-8?B?YnFKSlYrYnhUMTZxTFNvNm4zTGpWZmZEYXJlTC96d05ZSUxqeVlEdnUrdGw0?= =?utf-8?B?YkpsOHh2d2NzZG9wNVJ4WEkyem9xMW1uU0Z0VjFQWFFtaUlPckZZcEdrKzQ1?= =?utf-8?Q?2FBxRLulWXN6U1o13G+rag8=3D?= Content-Type: multipart/alternative; boundary="_000_24D29D427458407B870B43CE32B4E13Ccitrixcom_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0acd23d3-666f-4b7a-bbba-08dac258cd80 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 13:46:28.6398 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h3Qc3AJVh7RgpHrGtXXvIpsXUi9I2mLnZY7SXBF9qbTMdkfLk5whG0wsfwu0cD8zLvHLK9tsCXQPphLOby8ZshCa73CghnXINgJ6caU7Hn4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5091 --_000_24D29D427458407B870B43CE32B4E13Ccitrixcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DQoNCk9uIDggTm92IDIwMjIsIGF0IDE1OjMzLCBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jva0Bj aXRyaXguY29tPG1haWx0bzplZHZpbi50b3Jva0BjaXRyaXguY29tPj4gd3JvdGU6DQoNCkZpeGVz OiAyZjJiNzZkNDdjNWJjZDkgKCJ0b29scy9vY2FtbDogZG8gbm90IHJ1biBvY2FtbGRlcCBkdXJp bmcgbWFrZSBjbGVhbiIpDQoNClNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLDtmsgPGVkdmluLnRv cm9rQGNpdHJpeC5jb208bWFpbHRvOmVkdmluLnRvcm9rQGNpdHJpeC5jb20+Pg0KLS0tDQpSZWFz b24gZm9yIGluY2x1c2lvbiBpbiA0LjE3Og0KLSBhZGRyZXNzZXMgcmV2aWV3IGNvbW1lbnRzIHJl Y2VpdmVkIHBvc3QgY29tbWl0DQoNCkNoYW5nZXMgc2luY2UgdjI6DQotIGFkZCBGaXhlcyBsaW5l DQotIGFkZCA0LjE3IHJlYXNvbg0KLS0tDQp0b29scy9vY2FtbC9NYWtlZmlsZS5ydWxlcyB8IDQg KystLQ0KMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCg0K QWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbTxt YWlsdG86Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPj4NCg0K --_000_24D29D427458407B870B43CE32B4E13Ccitrixcom_ Content-Type: text/html; charset="utf-8" Content-ID: <3317710E02F9AC479A0D0EE6FE5289C6@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJ3b3JkLXdy YXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZTsgbGluZS1icmVhazogYWZ0 ZXItd2hpdGUtc3BhY2U7IiBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NCjxkaXY+PGJyIGNsYXNz PSIiPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2xhc3M9IiI+DQo8ZGl2IGNsYXNzPSIiPk9u IDggTm92IDIwMjIsIGF0IDE1OjMzLCBFZHdpbiBUw7Zyw7ZrICZsdDs8YSBocmVmPSJtYWlsdG86 ZWR2aW4udG9yb2tAY2l0cml4LmNvbSIgY2xhc3M9IiI+ZWR2aW4udG9yb2tAY2l0cml4LmNvbTwv YT4mZ3Q7IHdyb3RlOjwvZGl2Pg0KPGJyIGNsYXNzPSJBcHBsZS1pbnRlcmNoYW5nZS1uZXdsaW5l Ij4NCjxkaXYgY2xhc3M9IiI+PHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7 IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6 IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0 dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7 IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6 IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5v bmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPkZp eGVzOg0KIDJmMmI3NmQ0N2M1YmNkOSAoJnF1b3Q7dG9vbHMvb2NhbWw6IGRvIG5vdCBydW4gb2Nh bWxkZXAgZHVyaW5nIG1ha2UgY2xlYW4mcXVvdDspPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29s b3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTog MTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250 LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsg dGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3Jt YWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRl eHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPGJyIHN0eWxlPSJjYXJldC1jb2xvcjog cmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4 OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2Vp Z2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0 LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsg d29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1k ZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJn YigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsg Zm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdo dDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1p bmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdv cmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVj b3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIg Y2xhc3M9IiI+U2lnbmVkLW9mZi1ieToNCiBFZHdpbiBUw7Zyw7ZrICZsdDs8L3NwYW4+PGEgaHJl Zj0ibWFpbHRvOmVkdmluLnRvcm9rQGNpdHJpeC5jb20iIHN0eWxlPSJmb250LWZhbWlseTogTWVu bG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFy aWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3Jt YWw7IG9ycGhhbnM6IGF1dG87IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0 ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd2lkb3dzOiBhdXRvOyB3 b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXNpemUtYWRqdXN0OiBhdXRvOyAtd2Via2l0 LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IiBjbGFzcz0iIj5lZHZpbi50b3Jva0BjaXRyaXguY29t PC9hPjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTog TWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQt dmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBu b3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9y bTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQt dGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9u ZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj4mZ3Q7PC9zcGFuPjxiciBz dHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3Vs YXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fw czogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0 LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdo aXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tl LXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5 bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFy OyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6 IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1h bGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0 ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13 aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBp bmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPi0tLTwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNv bG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6 IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9u dC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7 IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9y bWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0 ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xv cjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAx MXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQt d2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0 ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1h bDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4 dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRh bnQ7IiBjbGFzcz0iIj5SZWFzb24NCiBmb3IgaW5jbHVzaW9uIGluIDQuMTc6PC9zcGFuPjxiciBz dHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3Vs YXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fw czogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0 LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdo aXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tl LXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5 bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFy OyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6 IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1h bGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0 ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13 aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBp bmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPi0NCiBhZGRyZXNzZXMgcmV2aWV3IGNvbW1lbnRz IHJlY2VpdmVkIHBvc3QgY29tbWl0PC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigw LCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9u dC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDog NDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRl bnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQt c3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3Jh dGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAs IDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0 eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7 IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDog MHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFj aW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9u OiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAw KTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHls ZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBs ZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBw eDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2lu ZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjog bm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9IiI+ Q2hhbmdlcw0KIHNpbmNlIHYyOjwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwg MCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQt c3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQw MDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50 OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNw YWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRp b246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAs IDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0 eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7 IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDog MHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFj aW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9u OiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0i Ij4tDQogYWRkIEZpeGVzIGxpbmU8L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAs IDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250 LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0 MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVu dDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1z cGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0 aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAw LCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1z dHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAw OyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6 IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3Bh Y2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlv bjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9 IiI+LQ0KIGFkZCA0LjE3IHJlYXNvbjwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2Io MCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZv bnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6 IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5k ZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3Jk LXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29y YXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAs IDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250 LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0 MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVu dDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1z cGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0 aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFz cz0iIj4tLS08L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250 LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3Jt YWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1z cGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0 LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7 IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIg Y2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1m YW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFs OyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3Bh Y2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10 cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAt d2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxv YXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9IiI+dG9vbHMvb2Nh bWwvTWFrZWZpbGUucnVsZXMNCiB8IDQgKystLTwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9y OiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDEx cHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13 ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRl eHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFs OyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0 LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjog cmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4 OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2Vp Z2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0 LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsg d29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1k ZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7 IiBjbGFzcz0iIj4xDQogZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pPC9zcGFuPjwvZGl2Pg0KPC9ibG9ja3F1b3RlPg0KPC9kaXY+DQo8YnIgY2xhc3M9IiI+DQo8 ZGl2IGNsYXNzPSIiPg0KPGRpdiBzdHlsZT0ibWFyZ2luOiAwcHg7IGZvbnQtc3RyZXRjaDogbm9y bWFsOyBmb250LXNpemU6IDExcHg7IGxpbmUtaGVpZ2h0OiBub3JtYWw7IGZvbnQtZmFtaWx5OiBN ZW5sbzsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImZvbnQtdmFyaWFudC1saWdhdHVyZXM6IG5v LWNvbW1vbi1saWdhdHVyZXMiIGNsYXNzPSIiPkFja2VkLWJ5OiBDaHJpc3RpYW4gTGluZGlnICZs dDs8YSBocmVmPSJtYWlsdG86Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tIiBjbGFzcz0iIj5j aHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb208L2E+Jmd0Ozwvc3Bhbj48L2Rpdj4NCjwvZGl2Pg0K PGRpdiBjbGFzcz0iIj48c3BhbiBzdHlsZT0iZm9udC12YXJpYW50LWxpZ2F0dXJlczogbm8tY29t bW9uLWxpZ2F0dXJlcyIgY2xhc3M9IiI+PGJyIGNsYXNzPSIiPg0KPC9zcGFuPjwvZGl2Pg0KPC9i b2R5Pg0KPC9odG1sPg0K --_000_24D29D427458407B870B43CE32B4E13Ccitrixcom_-- From xen-devel-bounces@lists.xenproject.org Wed Nov 09 13:49:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 13:49:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440950.695196 (Exim 4.92) (envelope-from ) id 1oslS2-0006a6-UO; Wed, 09 Nov 2022 13:49:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440950.695196; Wed, 09 Nov 2022 13:49:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslS2-0006Zz-RH; Wed, 09 Nov 2022 13:49:10 +0000 Received: by outflank-mailman (input) for mailman id 440950; Wed, 09 Nov 2022 13:49:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslS1-0006Zk-AH for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 13:49:09 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46f6db08-6035-11ed-8fd2-01056ac49cbb; Wed, 09 Nov 2022 14:49:07 +0100 (CET) Received: from mail-bn8nam04lp2041.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 08:49:04 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by CH2PR03MB5206.namprd03.prod.outlook.com (2603:10b6:610:a3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 13:49:02 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 13:49:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46f6db08-6035-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668001747; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=cd68enhDlQuQmJlm9/KwMpAdPlHplKWVrX/j1ant2RY=; b=Sly0cmWqmaCpP/CIS42KexfYdnqzBSXDI82jASBX9NiVyCKeLuN1NmOr aJeF52QDlbtctKBnp9rXxOj6sDPC2CWzsJCwG7QD6D4g3QrGNT9WhHVn+ axln4n/dhEjorExm9XRoulpLmCDjHx8glNKe0YuaH9zjeEBJTfMNuLIQ+ k=; X-IronPort-RemoteIP: 104.47.74.41 X-IronPort-MID: 87009617 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:3OUQ/qCEb+OI0xVW/xbiw5YqxClBgxIJ4kV8jS/XYbTApDtz1GQFn DAfDWrTP6rbZjD0f9ElOduwpEsAsMXQnN5rQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpA7wRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwpb55M0se2 fwiEHNXdC2B2Nydzb+0Rbw57igjBJGD0II3nFhFlW2cJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK+exrugA/zyQouFTpGNHVYN2RWcRcmACcp 2TK/mvRCRAGLt2PjzGC9xpAg8efwnujCdxLS9VU8NZph2SrmXMQWSEtanbjh7roiU/na9NAf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpSNEgrt5wejUs2 XeAhdavDjtq2JWZQGyQ3q2ZpjSzPW4SN2BqTTAAZRsI5Z/kuo5bs/7UZtNqEarwhNulHzj1m 2yOtHJm2+xVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5L2ADwmZX1VqBGwfQ== IronPort-HdrOrdr: A9a23:fRAyHqNZDU9Ep8BcT3f155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90dq7MAnhHP9OkMMs1NKZMDUO11HYS72KgbGC/9SkIVyHygc/79 YsT0EdMqyXMbESt6+Tj2eF+pQbsaC6GcuT9IXjJgJWPGVXgtZbnmJE42igcnFedU1jP94UBZ Cc7s1Iq36LYnIMdPm2AXEDQqzqu8DLvIiOW29IOzcXrC21yR+44r/zFBaVmj0EVSlU/Lsk+W /Z1yTk+6SYte2hwBO07R6c030Woqqh9jJwPr3OtiEnEESvtu9uXvUlZ1S2hkF0nAho0idvrD CDmWZmAy050QKtQoj8m2qQ5+Cn6kdj15aq8y7nvVLz5cP+Xz40EMxHmMZQdQbY8VMpuJVm3L tMxH/xjesfMftR9B6NmOQgeisa4XZcm0BS59I7njhaS88TebVRpYsQ8AdcF4oBBjvz7MQiHP N1BM/R6f5KeRfCBkqp9VVH0ZipRDA+Dx2GSk8Ntoic1CVXhmlwyw8dyNYElnkN+ZohQ91P5v jCMK5viLZSJ/VmJZ5VFaMEW4+6G2bNSRXDPCabJknmDrgOPzbXp5v+8NwOlZWXkVwzve4Pcb j6ISBlXDQJCjPT4OW1re122wGIRnmhVjLwzcwb74Rlu9THNcjWDRE= X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208,217";a="87009617" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SfpIHtRoPoiIAJXXBlkDXdkMX0ZTxX5iNbaLOVsKeg7KalI28MGyvudjTTKeGA2ooMuBbEWZK78AWh26+DsXDrigYu25ew8tE3dhNxWVKV9QI6xbhyLuagy8/4zqoyYilzpjDS1AXAWhBCDDlS9AUWW6N3viUxf8Cw7sM3swOzLmmNIbB7GcoRfIDhzcXKopZ+Sr8ZmfkZXjdN57py41pdrvaMCLhb3SvQ1ZorJF0Frs4piXm3NFVmMtRF7XOiFIlp0d6IPh+s/xYEVfxpOuCSp/nCjOoPE0mqdTHNvFSPwOMR8JE1c9Ygv9Rx3aVk98p4Omr0XTlKwFrlJ9//bifg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cd68enhDlQuQmJlm9/KwMpAdPlHplKWVrX/j1ant2RY=; b=kTfmZUerDQB+4vclLU0C+CAzT5StnqovUXNVVVzR8cqQYTM3SuUZrpM5hVuJUueY6RoXPLOpuLAIMYzLHhDtnTShmSMYcSDcWINPgTq2eyD7NcmE0ULQEYh5SRd6c6MCQ+5HfsyOSYaeCh9l1Yig8QgrpT503LGfTJiJlnSoL1GrYOk88xQgMK+AnICdVfiwvXyrq3qYaFJU7HutZyIewh6QE7LGlCMT4VxQ6+BuEsu7+689cc3k29uSdJ2yPpFvwSfxU5k8K9Qm7Kat6qr+ZM8M8egE4t7LtnIncXFqmkAUUQCzfZS/OzZCPYd6dEE4qP5taPfATrT5LY1TX1Za/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cd68enhDlQuQmJlm9/KwMpAdPlHplKWVrX/j1ant2RY=; b=XrhdrM05/DLbvmvoYYTaWP6MyOuNvIT09lRfCGbAXpHjOLiFnak1Y0grcZz0GqzbHakDUjVXE9posPgeE0+BDh25RC35w/nqj+dE+Q9IXbcdjdnUhK86KTu5ge7uYTS6MrrpXRbfP3Ds+pyPhk5Io3M/i16SCxcNbaijQVkzjzg= From: Christian Lindig To: Edwin Torok CC: Xen-devel , Henry Wang , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 08/15] tools/ocaml/libs/evtchn: add xenevtchn_fdopen bindings Thread-Topic: [PATCH for-4.17 v3 08/15] tools/ocaml/libs/evtchn: add xenevtchn_fdopen bindings Thread-Index: AQHY84elM4n1qbDMAkqjKMjNMKE8la42nPmA Date: Wed, 9 Nov 2022 13:49:02 +0000 Message-ID: <4381983C-C336-4812-890A-8756E7F2AF0F@citrix.com> References: <3e7f15778ffb5d5d7adde8567c4d50197607f7b2.1667920496.git.edvin.torok@citrix.com> In-Reply-To: <3e7f15778ffb5d5d7adde8567c4d50197607f7b2.1667920496.git.edvin.torok@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|CH2PR03MB5206:EE_ x-ms-office365-filtering-correlation-id: 6eb766c4-861c-4a3c-3208-08dac2592939 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8QNnJC+N7qHHJY+eIS7xgU6fR70zRDrcVSBRts6+iV0J1og1ljuRbRgCzmVLmG0XHhqz+PhGD9YL4B56/9Hu8jhsbVFVDCkgks74EU/wR4lbYJkxJAI0UsgvXwJRY5i5Qou+N5PHYZk/RAxKGou2u6zHXE7F6nFdqxc6k6GolErY3vhWUM1km1WnrtR9o2EIpJTVHDZyT3jM0/g4m/oxecqUZvO3cClK+uKnvgJ9UG+jG9Wign8VTwSXq8OurVlpmswvJgqwnDdRaDj+g6LnPBwYHMDxmpqdGEHxHa/z+0M2Z8V8Hut1lcU3kY59s3T7OfGcoR+YcVYmH+i+MFojnqswcvzq3e7BWRwyN7CuY41qslrgt4qKfZVL6HFY41aldjZAWaqs5IRu/XlulACEKNjrm7YV7wKKliG8VZfXrZEZHG1SJrLvQeVIsk6F94hmTgt3c/9/Ktgao0QKTlVxTK5SxieJkgZLPPRIuCi6aokO0XQA8tyJu5JWn6AR1XRq/TU2bxqcecp1wufu/WoOo5L72vBUwe6MXAk40/OHSOWgRj3lF0YoOGv66ajwd7bMkStI3HXPv1MnacCAnyNgtroSQYn9GSiDobikcaEPBRjUkcFEkq8RXE8jKPL1qqZL8ckKpWoDs1hlW7tRYAmPuxmalNijYo2wh0l1HLQhrTs0v8/zug+75zjdMmItNRxt2+Vj7Fk5RTe6TIrr7biv/vM4ZlwSffVe0kChwf00DQzsDWnrUgDVrLK8eGoDtTyA3frFWPufOPYOf7y75U7eZa3WATAvLOGRyLPz004asVk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(451199015)(53546011)(6512007)(186003)(6506007)(2616005)(26005)(38100700002)(36756003)(82960400001)(33656002)(83380400001)(38070700005)(86362001)(66476007)(122000001)(66446008)(8676002)(64756008)(66556008)(4326008)(91956017)(76116006)(2906002)(66946007)(5660300002)(6862004)(8936002)(4744005)(41300700001)(44832011)(107886003)(478600001)(71200400001)(6486002)(37006003)(6636002)(54906003)(316002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eC96TkNZdDJCMitRUmZRREIvdHZzd3h5VWdhd3E0ckhOT0VSakJmM1FBZm1T?= =?utf-8?B?YnovRGZYKzZNT3dHOXhuOWNHaG1HSEpJUkRTUUxWOEMwWHJVcEYrQkNGY2dh?= =?utf-8?B?b0dqWkd3MkJNeWdUUHp1eERoRm0zd1EzUy9tZUJJaWZpT2NKc3pYOWpjcVRQ?= =?utf-8?B?WXlGQVhmMW05RjYyKys5TkVqaThHNzFnSktRSEdpN3NhMlJ0cTdOMEx0RnE5?= =?utf-8?B?dXVobGtqMkZrb3pSdzYxYm1jR1NVWjZuSEhtWEtWa1l2UkdaVFBLeENrbGR1?= =?utf-8?B?ZFJrMGJwbDkrZmtzSnNkZU1oWTlhays0R29OSk9BMWJubUdjL3p1UVY1RG1s?= =?utf-8?B?QUkxVFJPem9XK2lYSnpWRkpKQVNMcTNwTE1kdUZJK1ZyQW4ya2IrWG9UZUVH?= =?utf-8?B?ZlMrUEViT3RQNXgxUE05NVN2SGYweWlOTkx4ZEdxcUZuQUt3UkpaVmVHbVJT?= =?utf-8?B?T1FkOTlFcDgvLy81aEh3R1ZsM0ZRRHlMN0NtTE5uSHlqeHNXeitVcFB5L3Zy?= =?utf-8?B?TXRuSDdKRm5pQzVXZW5JZkZMVm9EOHRwZjFocllqaUR4RUI0cUxXY0hrZXlj?= =?utf-8?B?RmMveWZLU2VWVkZXckhLR05mUEhUenJzR3Z6ZlFqNGoxRGpKOW9XcFZGa0xn?= =?utf-8?B?MG5TVndiMENENGxPY0ZYSHZseHgvV0Z3T1ltbmNjU0FYaVlucjlaZEgxTGtn?= =?utf-8?B?UkxlcDBMYzI1OUJFaTlxV21MMHdEM3J1cjZQSU1JdjcwSWMxTExMSEI5cDMw?= =?utf-8?B?elVxR2JyeU9EVnJ2c3NITFpvRlIzSkszMHEwRHFIcWl6OFI3SktCS25Ha2Vz?= =?utf-8?B?T0xLOTJLd0hpN1lSZzZQbkswaU94NnVQQnFXazBhbjZXSXU3Vjd3VzVocTdT?= =?utf-8?B?eUhwWng5Nk1VVVZYajhJTVlzcHRuTVgvM2ptSFg1d011dUtGRnRxb1VuNVVM?= =?utf-8?B?TTFsQWc1a01NbytTL09zSjkycHYvN2VqdjFnZEEyY29tWWZCN3lJMHhQSFlB?= =?utf-8?B?cUNXZUM0dElzdTh4WXZmMEsyc2FTZFJRRmVvcklLTWIxSmhqV0VKb1NPaVN4?= =?utf-8?B?ZkxGTVU4Z2xxd2F3OTJiZEFwK1FmVjQza0ZaeEhqTjRORFF3d1BIZ2REOXpD?= =?utf-8?B?c0cvOXcrL1NKbGpWQlN3OUFoTDJWRUg4Wit5aVZQemExS1diZ0VkSG1HdTZs?= =?utf-8?B?TGJ3UEZxdHdWcUZQTXlieXpKM1hMa2tHSTFDRFZaSTBDdXpOQmtkVkRnS1Bo?= =?utf-8?B?eTdLS2VyeC9XejJRQU9LNWJuTzRUVEZtMnNvWDQ4c3FyWXVZRWxqR3EyQWpG?= =?utf-8?B?VW85Z1VOSGdNT1pDSDg1ZEFObGY0N0FKNnpieFpDWW1mYSsvdXR6NVNUUFRa?= =?utf-8?B?alNxclFPdUk5NFJueG04UHBvSFhRcitsUUM5REJLWExnQWVZTkVjRCsyZnBz?= =?utf-8?B?aG9CWXpHNFk5eFdualJ6Rno0YmZEWTVLQXBDSkUxSyt3elBIdS9OSDhVOWtk?= =?utf-8?B?QVY0cjJOejNjZmdGM2libStkd2NRZjdPZ3R1eEZ5c0QwSVVROU81VjBWR2ZF?= =?utf-8?B?dFNseStRemxkWCtUZ2NFMHRGQm1BN0pBQ2xKNW5iVHU3Q3pjSUM3ek1NeVM3?= =?utf-8?B?OU0vTzVXQ29mMkFxandiMVRma1VOOFp3cmhSSDdORWV3UGprTjRNeFhUNVF1?= =?utf-8?B?Zlk0RWNScnNDT0lZY0JqUHBtUktRRWdLRENLdmhpcXZuZHE0UUlwazI3WUFu?= =?utf-8?B?Y3hZSVVyNEdsZmtOdkQySVlZUDNvOEJON2Z2YmdreDY0ZWN6M25PcFNXUmdk?= =?utf-8?B?bEl1bkR6S2lNL1Bvd0VvVXE1bXFIOGV1ZktOZ1F6WStySlpWcEpIWVZMM01X?= =?utf-8?B?Z0RwTmNueWZZTlhOajF1NmkwY244RFRzR2U1ejNMYWlnWVFrYVdJQXU5L2JE?= =?utf-8?B?S2dIWitCUmExY2xPL1N4bHZ1WmtKbEhaUGlFNHJjRXVLbEJlSWJHQkMybHBX?= =?utf-8?B?Q3QvcTltWGNqNHhSWDVjampnK0swVnFOc2xOV3RtdzNZS3pZSjdqM2Jwb0s3?= =?utf-8?B?Uy9TQzZhMlErdnd5NkhZZ3l4NnlmK1VDeUJpR09QRU1sZURQNXByUUVDSG5y?= =?utf-8?B?djZzYnlnS3VhYnI3R2tzd0dBLy9DRytkNWNPWkVZNzBweEcwWHZtZnZWNmlO?= =?utf-8?Q?YecEFXFPTwOdcZU+rSz9+TQ=3D?= Content-Type: multipart/alternative; boundary="_000_4381983CC3364812890A8756E7F2AF0Fcitrixcom_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6eb766c4-861c-4a3c-3208-08dac2592939 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 13:49:02.5526 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SbwzMeIZxKur7Ug7OgGKb6pdrCROuLnk3mOgcfFxrMC2RGjqIueGBBr2pHh8SATACb8Pz6fv6pw0sAzXe5nJtc52bHeJdJ824tA6zvXFUKE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5206 --_000_4381983CC3364812890A8756E7F2AF0Fcitrixcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DQoNCk9uIDggTm92IDIwMjIsIGF0IDE1OjM0LCBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jva0Bj aXRyaXguY29tPG1haWx0bzplZHZpbi50b3Jva0BjaXRyaXguY29tPj4gd3JvdGU6DQoNClNpZ25l ZC1vZmYtYnk6IEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb208bWFpbHRvOmVk dmluLnRvcm9rQGNpdHJpeC5jb20+Pg0KLS0tDQpSZWFzb24gZm9yIGluY2x1c2lvbiBpbiA0LjE3 Og0KLSBuZWVkZWQgZm9yIGEgYnVnZml4IGluIGEgZm9sbG93dXAgY29tbWl0DQoNCkNoYW5nZXMg c2luY2UgdjI6DQotIG5ldyBpbiB2Mw0KLS0tDQp0b29scy9vY2FtbC9saWJzL2V2ZW50Y2huL3hl bmV2ZW50Y2huLm1sICAgICAgfCAgNiArKystDQp0b29scy9vY2FtbC9saWJzL2V2ZW50Y2huL3hl bmV2ZW50Y2huLm1saSAgICAgfCAgOSArKysrKy0NCnRvb2xzL29jYW1sL2xpYnMvZXZlbnRjaG4v eGVuZXZlbnRjaG5fc3R1YnMuYyB8IDI4ICsrKysrKysrKysrKysrKysrLS0NCjMgZmlsZXMgY2hh bmdlZCwgMzggaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkNCg0KDQpBY2tlZC1ieTogQ2hy aXN0aWFuIExpbmRpZyA8Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPG1haWx0bzpjaHJpc3Rp YW4ubGluZGlnQGNpdHJpeC5jb20+Pg0KDQo= --_000_4381983CC3364812890A8756E7F2AF0Fcitrixcom_ Content-Type: text/html; charset="utf-8" Content-ID: <4FD7F534776C6D4FA40C94EFF7844C31@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJ3b3JkLXdy YXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZTsgbGluZS1icmVhazogYWZ0 ZXItd2hpdGUtc3BhY2U7IiBjbGFzcz0iIj4NCjxkaXYgY2xhc3M9IiI+PGJyIGNsYXNzPSIiPg0K PC9kaXY+DQo8ZGl2PjxiciBjbGFzcz0iIj4NCjxibG9ja3F1b3RlIHR5cGU9ImNpdGUiIGNsYXNz PSIiPg0KPGRpdiBjbGFzcz0iIj5PbiA4IE5vdiAyMDIyLCBhdCAxNTozNCwgRWR3aW4gVMO2csO2 ayAmbHQ7PGEgaHJlZj0ibWFpbHRvOmVkdmluLnRvcm9rQGNpdHJpeC5jb20iIGNsYXNzPSIiPmVk dmluLnRvcm9rQGNpdHJpeC5jb208L2E+Jmd0OyB3cm90ZTo8L2Rpdj4NCjxiciBjbGFzcz0iQXBw bGUtaW50ZXJjaGFuZ2UtbmV3bGluZSI+DQo8ZGl2IGNsYXNzPSIiPjxzcGFuIHN0eWxlPSJjYXJl dC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1z aXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7 IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0 YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6 IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBw eDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFp bXBvcnRhbnQ7IiBjbGFzcz0iIj5TaWduZWQtb2ZmLWJ5Og0KIEVkd2luIFTDtnLDtmsgJmx0Ozwv c3Bhbj48YSBocmVmPSJtYWlsdG86ZWR2aW4udG9yb2tAY2l0cml4LmNvbSIgc3R5bGU9ImZvbnQt ZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1h bDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNw YWNpbmc6IG5vcm1hbDsgb3JwaGFuczogYXV0bzsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5k ZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3aWRv d3M6IGF1dG87IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc2l6ZS1hZGp1c3Q6IGF1 dG87IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsiIGNsYXNzPSIiPmVkdmluLnRvcm9r QGNpdHJpeC5jb208L2E+PHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZv bnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5v cm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVy LXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRl eHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBw eDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7 IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPiZndDs8 L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTog TWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQt dmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBu b3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9y bTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQt dGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+ DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1l bmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZh cmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9y bWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06 IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRl eHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7 IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9IiI+LS0tPC9zcGFuPjxiciBzdHls ZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7 IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczog bm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFs aWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRl LXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdp ZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9 ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBm b250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5v cm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGln bjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1z cGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0 aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxp bmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPlJlYXNvbg0KIGZvciBpbmNsdXNpb24gaW4gNC4xNzo8 L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTog TWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQt dmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBu b3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9y bTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQt dGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+ DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1l bmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZh cmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9y bWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06 IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRl eHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7 IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9IiI+LQ0KIG5lZWRlZCBmb3IgYSBi dWdmaXggaW4gYSBmb2xsb3d1cCBjb21taXQ8L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjog cmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4 OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2Vp Z2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0 LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsg d29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1k ZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2Io MCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZv bnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6 IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5k ZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3Jk LXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29y YXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAs IDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250 LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0 MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVu dDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1z cGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0 aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFz cz0iIj5DaGFuZ2VzDQogc2luY2UgdjI6PC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJn YigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsg Zm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdo dDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1p bmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdv cmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVj b3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2Io MCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZv bnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6 IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5k ZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3Jk LXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29y YXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNs YXNzPSIiPi0NCiBuZXcgaW4gdjM8L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAs IDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250 LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0 MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVu dDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1z cGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0 aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAw LCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1z dHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAw OyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6 IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3Bh Y2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlv bjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9 IiI+LS0tPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1m YW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFs OyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3Bh Y2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10 cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAt d2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNs YXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFt aWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsg Zm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNp bmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJh bnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdl YmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0 OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPnRvb2xzL29jYW1s L2xpYnMvZXZlbnRjaG4veGVuZXZlbnRjaG4ubWwNCiAmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm bmJzcDt8ICZuYnNwOzYgKysrLTwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwg MCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQt c3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQw MDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50 OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNw YWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRp b246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAs IDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0 eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7 IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDog MHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFj aW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9u OiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0i Ij50b29scy9vY2FtbC9saWJzL2V2ZW50Y2huL3hlbmV2ZW50Y2huLm1saQ0KICZuYnNwOyZuYnNw OyZuYnNwOyZuYnNwO3wgJm5ic3A7OSArKysrKy08L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xv cjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAx MXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQt d2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0 ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1h bDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4 dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6 IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFw eDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdl aWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4 dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7 IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQt ZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50 OyIgY2xhc3M9IiI+dG9vbHMvb2NhbWwvbGlicy9ldmVudGNobi94ZW5ldmVudGNobl9zdHVicy5j DQogfCAyOCArKysrKysrKysrKysrKysrKy0tPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6 IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFw eDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdl aWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4 dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7 IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQt ZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiBy Z2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7 IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWln aHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQt aW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3 b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRl Y29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsi IGNsYXNzPSIiPjMNCiBmaWxlcyBjaGFuZ2VkLCAzOCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9u cygtKTwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFt aWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsg Zm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNp bmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJh bnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdl YmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFz cz0iIj4NCjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6 IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250 LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzog bm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zv cm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0 LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIi Pg0KPC9kaXY+DQo8L2Jsb2NrcXVvdGU+DQo8L2Rpdj4NCjxiciBjbGFzcz0iIj4NCjxkaXYgY2xh c3M9IiI+DQo8ZGl2IHN0eWxlPSJtYXJnaW46IDBweDsgZm9udC1zdHJldGNoOiBub3JtYWw7IGZv bnQtc2l6ZTogMTFweDsgbGluZS1oZWlnaHQ6IG5vcm1hbDsgZm9udC1mYW1pbHk6IE1lbmxvOyIg Y2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iZm9udC12YXJpYW50LWxpZ2F0dXJlczogbm8tY29tbW9u LWxpZ2F0dXJlcyIgY2xhc3M9IiI+QWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgJmx0OzxhIGhy ZWY9Im1haWx0bzpjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20iIGNsYXNzPSIiPmNocmlzdGlh bi5saW5kaWdAY2l0cml4LmNvbTwvYT4mZ3Q7PC9zcGFuPjwvZGl2Pg0KPC9kaXY+DQo8ZGl2IGNs YXNzPSIiPjxzcGFuIHN0eWxlPSJmb250LXZhcmlhbnQtbGlnYXR1cmVzOiBuby1jb21tb24tbGln YXR1cmVzIiBjbGFzcz0iIj48YnIgY2xhc3M9IiI+DQo8L3NwYW4+PC9kaXY+DQo8L2JvZHk+DQo8 L2h0bWw+DQo= --_000_4381983CC3364812890A8756E7F2AF0Fcitrixcom_-- From xen-devel-bounces@lists.xenproject.org Wed Nov 09 13:50:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 13:50:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440957.695208 (Exim 4.92) (envelope-from ) id 1oslTG-0007vb-85; Wed, 09 Nov 2022 13:50:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440957.695208; Wed, 09 Nov 2022 13:50:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslTG-0007vU-4t; Wed, 09 Nov 2022 13:50:26 +0000 Received: by outflank-mailman (input) for mailman id 440957; Wed, 09 Nov 2022 13:50:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslTE-0007vD-Kw for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 13:50:24 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 738634e3-6035-11ed-8fd2-01056ac49cbb; Wed, 09 Nov 2022 14:50:22 +0100 (CET) Received: from mail-mw2nam12lp2043.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 08:50:19 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by CH2PR03MB5206.namprd03.prod.outlook.com (2603:10b6:610:a3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 13:50:17 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 13:50:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 738634e3-6035-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668001822; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=MAT6oJKM4Vhge+KjIDp8bK+2CIxuuCWbsVcoSvOAKts=; b=OmX9h0WZdMh8KF+MyIgDTAknqio4cy7gdozHEdDN8/FCg3alOJNHQv8E 9+JdxLTwQ+7dIpq2xiFyksZ7IUdj0LFkpcyJZQhLd5IQGItJuTEXgI5nm hassXZqzDQuwUqbBYGm6o9U3HsDTW3dxN59Q7DnlVaBkXSk8qq7AmAVMr I=; X-IronPort-RemoteIP: 104.47.66.43 X-IronPort-MID: 84493131 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:F8JHJa1o05ABlvlN8/bD5exwkn2cJEfYwER7XKvMYLTBsI5bp2FVz DAYXWzUM6mIMTenL4gjPYznp05Uvp+AxoQwSgttpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVmNKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfH0BS6 Pc4NAw2TTupueKG2qy7Rutiv5F2RCXrFNt3VnBI6xj8VKxjZK+ZBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxpvS6Pl2Sd05C0WDbRUteKX8ROgkeRo CTC/mL1Ax4yP92D0zuVtHmrg4cjmAurBN5DT+Tjr5aGhnWJxTIvBRAXCWDg/9i5kVOiY/NGM 3ALr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOlMIwXy1s6 VaPkPvgHzkpu7qQIVqR/6mZhSm/Mi8UKSkFfyBsZRQBy8nupsc0lB2nczp4OKu8j9mwHC6qx TmP9XI6n+9L0ZVN0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLlm4U2l/MBVfNgwIQ== IronPort-HdrOrdr: A9a23:U6MaSKppJtOJsTsgUBiP4cAaV5udL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXcH2/hqAV7CZnithILMFu1fBOTZslrd8kHFl9K1kJ 0QC5SWa+eAQGSS7/yKhjVQeuxIqLbozEnrv5am854Hd3AJV0gU1XYcNu/tKDwSeOApP/oEPa vZwvACiyureHwRYMj+LGICRfL/q9rCk4+jSQIaBjY8gTP+wg+A2frfKVy1zx0eWzRAzfMJ6m 7eiTH04a2lrrWS1gLc7WnO9J5b8eGRhOerRfb8y/T9GA+cyTpAV74RGYFqewpF5d1H3Wxa0O UkZS1Qe/ibpUmhOV1d6iGdpjUImAxel0MKj2XozUcL6PaJOg4SGo5Pg5lUfQDe7FdltNZg0L hT12bcrJZPCwjc9R6NruQhx3lR5zWJSFcZ4JkuZkZkIP0jQa4UqZZa8FJeEZ8GEi6/4Ic7EP N2BMWZ4PpNa1uVY33Qo2EqmbWXLz8ONwbDRlJHtt2e0jBQknw8x0wExNYHlnNF8J4mUZFL6+ nNL6wtnrBTSc0da757GY46MIOKI32IRQiJPHOZIFzhGq1CM3XRq4Tv6LFw/+2ucIxg9upHpH 0AaiIsiYcfQTOcNSTV5uw7zvnkehTMYR39jsdD+pN+prrwALL2LCzrciFdr/ed X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208,217";a="84493131" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VONodtDGNnG7/+CbQw6jhZMnV9YXli9UbS2y4Hqda8P9QbnDZj42QMPKMguljZ5yb4pNytF2mgUcuR5fl1lvhIcWJ14Ukeic1VLFWu28yScsB7ZGgrohJkL+4kosFlr0SaUZHC9+/gp+ztaxTYiHlw2btSot1N0u83Mnzm5Q/kIXtI+BreA3z+ilYUprqqJG7n0q/MRm4ycQYHRvVKVOYwvbMfYukqO3qCp8fDWW6IkunZ5Mjx3STccxXPURBkKQzvpNr7R8ORyDRbE5EbCOw64ZDuJVmOVDVxol/9MZXT/Q3Z7xHu5Cr6+Ac4+7MMx+3qyZpZlEdiKnEq1pK1m1iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MAT6oJKM4Vhge+KjIDp8bK+2CIxuuCWbsVcoSvOAKts=; b=bKMKt3aoxRVv7k2UKysP9pXBC/DXwlN/v6DjFU/SnF39eUgnY80h2oPkYljmSxGqmpx72QfbDJgX7R8cWYWW/H5//Fl7ddyJmsIUkAGmKEg475YabMGa8cYCe3KISsW4vCa0DKjW5eF+vtvCLc5F82Acs2JwpS+DZ39M74WZi8Gt3nR8FKSDWEjsNPefWk1jeSvEOsI1NvGzCScqNpiXiG7XLgstWFJWwRQ9KJi25LO0sr29JB9qms+7nzrsTijnltN9hk3+0sOeYyhgv02BvITj2jJYZJw6PV5oJKzPLhdzolLnWniEJP7Zq9nJz4R/4cdhRabLsqdoJuA61H0LpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MAT6oJKM4Vhge+KjIDp8bK+2CIxuuCWbsVcoSvOAKts=; b=IVfkyQiUXg+Mtlpqcmv8sFvfm7CzdIiIMimJXk4s02cdOd3MqPUfGVlHluZzA3e/M6Lm9f08sqsszF1FWIS7s6usabJE7lC5Gn4DD9d5Bn6ZRgzQ6+8XaKclQGbYwKTjX0uKqwTZBzYqSgexzoA3HGCnpeiW0gDwl3UJ44a2z74= From: Christian Lindig To: Edwin Torok CC: Xen-devel , Henry Wang , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error Thread-Topic: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error Thread-Index: AQHY84entqxHr8vmGEKYGJ5naAn9nq42nVMA Date: Wed, 9 Nov 2022 13:50:17 +0000 Message-ID: References: <09afc07ba0ba65afc02028bd6b4950d8e51af69b.1667920496.git.edvin.torok@citrix.com> In-Reply-To: <09afc07ba0ba65afc02028bd6b4950d8e51af69b.1667920496.git.edvin.torok@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|CH2PR03MB5206:EE_ x-ms-office365-filtering-correlation-id: 01b0a1bb-f0ab-4461-c1e4-08dac25955b5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hr0ive1TrdTSp8BKWKjK+D31i8yIYfGXdEET5gicHbvLjnJQTeyiClos+K0W95xPMQRuD9dJSfAM9C2NtNyARcHc/EGLBMybA3X25lWaZk+r05fFlQfeQQgUKszzA3pjBwc9mbq2Jo1ExfELWyHWUMQqroBvYMtiw76uhDNX/85LDGaNAq83jKFjxzJN8Yyp/oB42m056G/TSFIdkpZUsWjFcYGM5YeX4UNydQzry5kyMfTvNpkSeLyyRUXZKx1J+fIh9/RxGOKQDQg1Mnol7WAEfUQLOAgJB9L2wrwCGRJiFPQWSqlzWp8j8avwtC+DtPaK/7a1SpUZVuUcsGScqSChPnMGA65f/ePGBnSSZmhuHpeipau99iawe7v20rZNTQ552PNlvwgzOTLit743bpUL4stJSRsKIJ8LZ1vgPJLk1Gv9RU2HdRoIpXzVoRcbbKyhYcQqiIiTgsBvDwDFt9fLofywr+LoDoLUAr+L4jfiuPNtboc9sPQAqembD1xFeT4GtWJLHRfFYQVBHSZaCA5pSb6ToTPXmG8Q2YVmvDee2JEJ18m2SBgBkTSNzEziX9XdvYtoVXUuYohsahDP5RweSoBb9WcvxQxmJX8nDOxnSErD3cG2vCXU94WA3Jjs7PhjS4LNSm3nJdUQa88WT7lMt6i5cGBLQBhIQyA9HPIfVyjALx0eXZzVqAZWfU28nhOACqjxNWtehLToEeouk2Q76lvJZ9hb2IGWxK+S26N2uz3Bi/4aQkBKN6qtwXXuJyzfE66dXh7z9+XuvrcUIRqoR3khFLshikmbM5Ll8tY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(451199015)(53546011)(6512007)(186003)(6506007)(2616005)(26005)(38100700002)(36756003)(82960400001)(33656002)(83380400001)(38070700005)(86362001)(66476007)(66574015)(122000001)(66446008)(8676002)(64756008)(66556008)(4326008)(91956017)(76116006)(2906002)(66946007)(5660300002)(6862004)(8936002)(41300700001)(44832011)(107886003)(478600001)(71200400001)(6486002)(37006003)(6636002)(54906003)(316002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UEhIaXNGQUpTZkVSU3RqMDdPYzNPRXM5M015SCtYdno3elN3WGdUWC9DdDJh?= =?utf-8?B?TjBYVnE2cG56UFBXR0xUWG5ZQVkzdEY1NVlncFRLQThlUXhZWjdYejcxOGRz?= =?utf-8?B?SFVvZ3Q5NXpCQTNiWnRQSDlPTEg1R2lGK1BsQnp1alhIbFlTSmo2eDNMRmta?= =?utf-8?B?SmVJOW9BdC94QVVzL1ZlSnhsWWViRTN1RmtyZ2JIclhFelhSNDJBOVVJZHN0?= =?utf-8?B?Y0NFVXB2Z3dFb3pRbHptREpTU3JTNWJlSFdnK3A3MEp6YTkzakV5WkdWOHZT?= =?utf-8?B?bUJTU0cwSVJtOTQyaXpMMlRHNG84bk95QUhoUjN3ellMTmVuemFVR25GV0ZJ?= =?utf-8?B?eExJSFpiQ3MwSmtUbzh4NmVtdjhIVWpkUFR5ZWp3Y2NNSGF5dVNLWHBXcDUz?= =?utf-8?B?Rkl2cGhmL2FQR1g4NFp0ZEhSTy91ZTErTTFBejM3MmQxdFlRN2psZHhlUFBI?= =?utf-8?B?NEk1YUkzUloxZ043RmpOV0hkUzEzeGdqck5NQmFBRmh2NjNMZUZ4NUx5YmJk?= =?utf-8?B?c214NldwVHArck9hZGliT2svbkRGaC9pbnhKSnVYRkhMOXFLQVJyRVA4UlVq?= =?utf-8?B?Zk9yb0t2VGI1Mk9sSjlJMjJGQjd6eVYzQjNDYnpXdTJwcnRJSGZUWU5GUlo2?= =?utf-8?B?MWVZN3ZtY3FuTlcxb3h5b0EvQUhIbGZsdzVzS09EZmFzSm4vQjFRTmdCRkF0?= =?utf-8?B?UXFram5aV0ZLNDdrL25sUzJBZ3p0dWp2TnV4VDhxSjRET3M3ckdJWENma3dw?= =?utf-8?B?d1JoYStoYlp4a3JlZGgrdEFJaGh6VGN2T09GZnpLTTlCYnZRQU42alFDaHBZ?= =?utf-8?B?cHZEY2thaE4vSDRoZExoemxBS1hhN0Y1cis1cjB4UUhWSzdiNHZ1MWpuRmhG?= =?utf-8?B?V3lHemkzRjFZM3B1alZMVnBuWFFuaCtYRFFyY250RmdvL2pBR1pWSnFjYmQ0?= =?utf-8?B?Q1B6U1VGaVcvbitrSmI0blczQm5KTEtZVE4wbytNOERGMmFVRWNDOUtQdFlj?= =?utf-8?B?MWRONWZJMFc1Vyt0ZEYrazJqMCs5M21GUlVjeFZtWDdjN2xXbDFqeURyRjVJ?= =?utf-8?B?WnUxR3NvMzJkeGhLdW1xeUhIYWlZZnVzOEdiR3hVVmczemtpQUlPdnRMdnhu?= =?utf-8?B?NWFja0tENlZKeVpBbEduQ1d0c0tTeTVWYXFYUmw5aEk1MFNqVk05eG1EQ1FP?= =?utf-8?B?MVlSOHBWaXBqcFo4Z2F4RUV5U2xyZmJJSU91SG13cmdGaUJubWU3dWlCVFBu?= =?utf-8?B?bWtHWmFVZlpjNEhPaGh1UEUvMnF0eSs5blFjVEN1M1lUQjZmRVpuL3NWOHN3?= =?utf-8?B?VFFWVEx3K05KWVllTFpoTEl0b1lNSTN6dFJ1MnBJRGRqUVdWTVEwTk1tTFdj?= =?utf-8?B?S3M4V2czRlBvS3c0UEJwaXJYRFp2QVdobUpkd2lkbEdlZndVMGpaRmJDVGN5?= =?utf-8?B?ZkFaOUU4T3RXa0hmdmwwVVU1NzhrMGxKQ3RpamFheXUxUjFxbW5EanZFNmh0?= =?utf-8?B?L2x4UUloUDRkakg4K253T3huY3E1cDRmUHJsaFYySTFHQWdBaVIrejVaRTZs?= =?utf-8?B?MTQyUXFUc0lCbldWVXVBMFpvT0lrSlgxaERmVXoxMHRFY1RwWjFDY1lmbnpJ?= =?utf-8?B?S2ZsdFpuZXNuNHQyd1BVNUh4ZU5PdmppU2pkazIzVXQ0L0FRVU4wVHZOWGRX?= =?utf-8?B?WHExWGg0Y3drU1R4UEd6a2ZjVGRDcVlWSjlNWGVnSXA0M0ZUcmNNVTgvQzF1?= =?utf-8?B?VWxQcXhqZlBac2QyVUVzQ1hlYVNUa2FHMDB2ZUpKZXZXVzRFQ2NrR0thWGhq?= =?utf-8?B?dWdyK2Vzdk1ZZ0c3ak96WkIreUs3bjNiK1JvWWlXaHRVY2JYV0szMGY2Rjkr?= =?utf-8?B?V2RXYVBxMjAzRlFHR0VWTXIwU0traDZzZkovdHZFSWNwSWZid3JGK2JwaTZk?= =?utf-8?B?eGMwMm1uTTJxT082QkQ1ME42ck1rbjFSSDNVbmt1REhxTlNhSE1YUVRNREpt?= =?utf-8?B?UytmTmJPUTNHb3BuRGdvZmJTM0htTG1hZDdVRksrY2NqU1VyeTdIckJoK20v?= =?utf-8?B?RUZyRUxyQzFtSjBoSko0cTAzdmJNbzNBN0VvT0hQNWlld1I3Qk1aNlFWZkt3?= =?utf-8?B?MHo4dGpuTVV5bCtnT3FZd0p3NldxVG9MSGpaV0RzenpxY200L1hqYVYxNVVR?= =?utf-8?Q?WFJ3qgXSlkGWGRPdnTvvnjw=3D?= Content-Type: multipart/alternative; boundary="_000_FAE0E9E3A5964055A8D5E9AD65DB60A1citrixcom_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01b0a1bb-f0ab-4461-c1e4-08dac25955b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 13:50:17.1730 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xlyUp/DUSoSMvaIITo1/47vG6oK1lgfSICJAUhH8r4htCyZ3wLif6VOLTis0eTeezvPhiSkBwC42InjMDHSuvqRq2dTJPQ/FD8kWRz6o5Og= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5206 --_000_FAE0E9E3A5964055A8D5E9AD65DB60A1citrixcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DQoNCk9uIDggTm92IDIwMjIsIGF0IDE1OjM0LCBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jva0Bj aXRyaXguY29tPG1haWx0bzplZHZpbi50b3Jva0BjaXRyaXguY29tPj4gd3JvdGU6DQoNCkJ1aWxk aW5nIHdpdGggRHVuZSBpbiByZWxlYXNlIG1vZGUgZmFpbHMgd2l0aDoNCmBgYA0KRmlsZSAib2Nh bWwveGVuc3RvcmVkL3N0b3JlLm1sIiwgbGluZSA0NjQsIGNoYXJhY3RlcnMgMTMtMzI6DQpXYXJu aW5nIDE4OiB0aGlzIHR5cGUtYmFzZWQgcmVjb3JkIGRpc2FtYmlndWF0aW9uIGlzIG5vdCBwcmlu Y2lwYWwuDQpGaWxlICJvY2FtbC94ZW5zdG9yZWQvc3RvcmUubWwiLCBsaW5lIDE6DQpFcnJvcjog U29tZSBmYXRhbCB3YXJuaW5ncyB3ZXJlIHRyaWdnZXJlZCAoMSBvY2N1cnJlbmNlcykNCmBgYA0K DQpUaGlzIGlzIGEgd2FybmluZyB0byBoZWxwIGtlZXAgdGhlIGNvZGUgZnV0dXJlcHJvb2YsIHF1 b3RpbmcgZnJvbSBpdHMNCmRvY3VtZW50YXRpb246DQpDaGVjayBpbmZvcm1hdGlvbiBwYXRoIGR1 cmluZyB0eXBlLWNoZWNraW5nLCB0byBtYWtlIHN1cmUgdGhhdCBhbGwgdHlwZXMgYXJlDQpkZXJp dmVkIGluIGEgcHJpbmNpcGFsIHdheS4gV2hlbiB1c2luZyBsYWJlbGxlZCBhcmd1bWVudHMgYW5k L29yIHBvbHltb3JwaGljDQptZXRob2RzLCB0aGlzIGZsYWcgaXMgcmVxdWlyZWQgdG8gZW5zdXJl IGZ1dHVyZSB2ZXJzaW9ucyBvZiB0aGUgY29tcGlsZXIgd2lsbA0KYmUgYWJsZSB0byBpbmZlciB0 eXBlcyBjb3JyZWN0bHksIGV2ZW4gaWYgaW50ZXJuYWwgYWxnb3JpdGhtcyBjaGFuZ2UuIEFsbA0K cHJvZ3JhbXMgYWNjZXB0ZWQgaW4gLXByaW5jaXBhbCBtb2RlIGFyZSBhbHNvIGFjY2VwdGVkIGlu IHRoZSBkZWZhdWx0IG1vZGUgd2l0aA0KZXF1aXZhbGVudCB0eXBlcywgYnV0IGRpZmZlcmVudCBi aW5hcnkgc2lnbmF0dXJlcywgYW5kIHRoaXMgbWF5IHNsb3cgZG93biB0eXBlDQpjaGVja2luZzsg eWV0IGl0IGlzIGEgZ29vZCBpZGVhIHRvIHVzZSBpdCBvbmNlIGJlZm9yZSBwdWJsaXNoaW5nIHNv dXJjZSBjb2RlLg0KDQpGaXhlczogZGI0NzE0MDhlZGQ0NiAidG9vbHMvb2NhbWwveGVuc3RvcmVk OiBGaXggcXVvdGEgYnlwYXNzIG9uIGRvbWFpbiBzaHV0ZG93biINCg0KU2lnbmVkLW9mZi1ieTog RWR3aW4gVMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbTxtYWlsdG86ZWR2aW4udG9yb2tA Y2l0cml4LmNvbT4+DQotLS0NClJlYXNvbiBmb3IgaW5jbHVzaW9uIGluIDQuMTc6DQotIGZpeGVz IGEgYnVpbGQgZXJyb3IgaW4gYSBwcmV2aW91cyBjb21taXQgdGhhdCBpcyBhbHJlYWR5IGluIG1h c3Rlcg0KDQpDaGFuZ2VzIHNpbmNlIHYyOg0KLSBuZXcgaW4gdjMNCi0tLQ0KdG9vbHMvb2NhbWwv eGVuc3RvcmVkL3N0b3JlLm1sIHwgMiArLQ0KMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCsp LCAxIGRlbGV0aW9uKC0pDQoNCkFja2VkLWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4u bGluZGlnQGNpdHJpeC5jb208bWFpbHRvOmNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4+DQoN Cg== --_000_FAE0E9E3A5964055A8D5E9AD65DB60A1citrixcom_ Content-Type: text/html; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJ3b3JkLXdy YXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZTsgbGluZS1icmVhazogYWZ0 ZXItd2hpdGUtc3BhY2U7IiBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NCjxkaXY+PGJyIGNsYXNz PSIiPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2xhc3M9IiI+DQo8ZGl2IGNsYXNzPSIiPk9u IDggTm92IDIwMjIsIGF0IDE1OjM0LCBFZHdpbiBUw7Zyw7ZrICZsdDs8YSBocmVmPSJtYWlsdG86 ZWR2aW4udG9yb2tAY2l0cml4LmNvbSIgY2xhc3M9IiI+ZWR2aW4udG9yb2tAY2l0cml4LmNvbTwv YT4mZ3Q7IHdyb3RlOjwvZGl2Pg0KPGJyIGNsYXNzPSJBcHBsZS1pbnRlcmNoYW5nZS1uZXdsaW5l Ij4NCjxkaXYgY2xhc3M9IiI+PHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7 IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6 IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0 dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7 IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6 IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5v bmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPkJ1 aWxkaW5nDQogd2l0aCBEdW5lIGluIHJlbGVhc2UgbW9kZSBmYWlscyB3aXRoOjwvc3Bhbj48YnIg c3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1 bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNh cHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4 dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3 aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9r ZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0 eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxh cjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBz OiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQt YWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hp dGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Ut d2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTog aW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj5gYGA8L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1j b2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXpl OiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZv bnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0 OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5v cm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsg dGV4dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29s b3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTog MTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250 LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsg dGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3Jt YWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRl eHQtZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0 YW50OyIgY2xhc3M9IiI+RmlsZQ0KICZxdW90O29jYW1sL3hlbnN0b3JlZC9zdG9yZS5tbCZxdW90 OywgbGluZSA0NjQsIGNoYXJhY3RlcnMgMTMtMzI6PC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29s b3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTog MTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250 LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsg dGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3Jt YWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRl eHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9y OiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDEx cHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13 ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRl eHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFs OyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0 LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFu dDsiIGNsYXNzPSIiPldhcm5pbmcNCiAxODogdGhpcyB0eXBlLWJhc2VkIHJlY29yZCBkaXNhbWJp Z3VhdGlvbiBpcyBub3QgcHJpbmNpcGFsLjwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiBy Z2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7 IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWln aHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQt aW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3 b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRl Y29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdi KDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBm b250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0 OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWlu ZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29y ZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNv cmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBj bGFzcz0iIj5GaWxlDQogJnF1b3Q7b2NhbWwveGVuc3RvcmVkL3N0b3JlLm1sJnF1b3Q7LCBsaW5l IDE6PC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1p bHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBm b250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2lu Zzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFu c2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Vi a2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNz PSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5 OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9u dC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6 IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNm b3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtp dC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBu b25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPkVycm9yOg0KIFNvbWUg ZmF0YWwgd2FybmluZ3Mgd2VyZSB0cmlnZ2VyZWQgKDEgb2NjdXJyZW5jZXMpPC9zcGFuPjxiciBz dHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3Vs YXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fw czogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0 LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdo aXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tl LXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5 bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFy OyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6 IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1h bGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0 ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13 aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBp bmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPmBgYDwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNv bG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6 IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9u dC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7 IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9y bWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0 ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxiciBzdHlsZT0iY2FyZXQtY29sb3I6 IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFw eDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdl aWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4 dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7 IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQt ZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiBy Z2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7 IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWln aHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQt aW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3 b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRl Y29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsi IGNsYXNzPSIiPlRoaXMNCiBpcyBhIHdhcm5pbmcgdG8gaGVscCBrZWVwIHRoZSBjb2RlIGZ1dHVy ZXByb29mLCBxdW90aW5nIGZyb20gaXRzPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJn YigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsg Zm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdo dDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1p bmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdv cmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVj b3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2Io MCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZv bnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6 IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5k ZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3Jk LXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29y YXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNs YXNzPSIiPmRvY3VtZW50YXRpb246PC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigw LCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9u dC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDog NDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRl bnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQt c3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3Jh dGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgc3R5bGU9ImZv bnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5v cm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVy LXNwYWNpbmc6IG5vcm1hbDsgb3JwaGFuczogYXV0bzsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQt aW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3 aWRvd3M6IGF1dG87IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc2l6ZS1hZGp1c3Q6 IGF1dG87IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBu b25lOyIgY2xhc3M9IiI+DQpDaGVjayBpbmZvcm1hdGlvbiBwYXRoIGR1cmluZyB0eXBlLWNoZWNr aW5nLCB0byBtYWtlIHN1cmUgdGhhdCBhbGwgdHlwZXMgYXJlPGJyIGNsYXNzPSIiPg0KZGVyaXZl ZCBpbiBhIHByaW5jaXBhbCB3YXkuIFdoZW4gdXNpbmcgbGFiZWxsZWQgYXJndW1lbnRzIGFuZC9v ciBwb2x5bW9ycGhpYzxiciBjbGFzcz0iIj4NCm1ldGhvZHMsIHRoaXMgZmxhZyBpcyByZXF1aXJl ZCB0byBlbnN1cmUgZnV0dXJlIHZlcnNpb25zIG9mIHRoZSBjb21waWxlciB3aWxsPGJyIGNsYXNz PSIiPg0KYmUgYWJsZSB0byBpbmZlciB0eXBlcyBjb3JyZWN0bHksIGV2ZW4gaWYgaW50ZXJuYWwg YWxnb3JpdGhtcyBjaGFuZ2UuIEFsbDxiciBjbGFzcz0iIj4NCnByb2dyYW1zIGFjY2VwdGVkIGlu IC1wcmluY2lwYWwgbW9kZSBhcmUgYWxzbyBhY2NlcHRlZCBpbiB0aGUgZGVmYXVsdCBtb2RlIHdp dGg8YnIgY2xhc3M9IiI+DQplcXVpdmFsZW50IHR5cGVzLCBidXQgZGlmZmVyZW50IGJpbmFyeSBz aWduYXR1cmVzLCBhbmQgdGhpcyBtYXkgc2xvdyBkb3duIHR5cGU8YnIgY2xhc3M9IiI+DQpjaGVj a2luZzsgeWV0IGl0IGlzIGEgZ29vZCBpZGVhIHRvIHVzZSBpdCBvbmNlIGJlZm9yZSBwdWJsaXNo aW5nIHNvdXJjZSBjb2RlLjxiciBjbGFzcz0iIj4NCjwvYmxvY2txdW90ZT4NCjxiciBzdHlsZT0i Y2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZv bnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9y bWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWdu OiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNw YWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRo OiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNh cmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250 LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1h bDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjog c3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFj ZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDog MHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUg IWltcG9ydGFudDsiIGNsYXNzPSIiPkZpeGVzOg0KIGRiNDcxNDA4ZWRkNDYgJnF1b3Q7dG9vbHMv b2NhbWwveGVuc3RvcmVkOiBGaXggcXVvdGEgYnlwYXNzIG9uIGRvbWFpbiBzaHV0ZG93biZxdW90 Ozwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5 OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9u dC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6 IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNm b3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtp dC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0i Ij4NCjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1l bmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZh cmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9y bWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06 IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRl eHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0K PHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5s by1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJp YW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1h bDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBu b25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0 LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBk aXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPlNpZ25lZC1vZmYtYnk6DQogRWR3 aW4gVMO2csO2ayAmbHQ7PC9zcGFuPjxhIGhyZWY9Im1haWx0bzplZHZpbi50b3Jva0BjaXRyaXgu Y29tIiBzdHlsZT0iZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsg Zm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdo dDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyBvcnBoYW5zOiBhdXRvOyB0ZXh0LWFsaWdu OiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNw YWNlOiBub3JtYWw7IHdpZG93czogYXV0bzsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4 dC1zaXplLWFkanVzdDogYXV0bzsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyIgY2xh c3M9IiI+ZWR2aW4udG9yb2tAY2l0cml4LmNvbTwvYT48c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6 IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFw eDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdl aWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4 dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7 IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQt ZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50 OyIgY2xhc3M9IiI+Jmd0Ozwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwg MCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5 bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsg bGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAw cHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNp bmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246 IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDAp OyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxl OiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxl dHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4 OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5n OiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBu b25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj4t LS08L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWls eTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZv bnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5n OiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5z Zm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJr aXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9 IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6 IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250 LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzog bm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zv cm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0 LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5v bmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9IiI+UmVhc29uDQogZm9yIGlu Y2x1c2lvbiBpbiA0LjE3Ojwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwg MCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5 bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsg bGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAw cHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNp bmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246 IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDAp OyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxl OiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxl dHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4 OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5n OiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBu b25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj4t DQogZml4ZXMgYSBidWlsZCBlcnJvciBpbiBhIHByZXZpb3VzIGNvbW1pdCB0aGF0IGlzIGFscmVh ZHkgaW4gbWFzdGVyPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsg Zm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTog bm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0 ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsg dGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzog MHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9u ZTsiIGNsYXNzPSIiPg0KPGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250 LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3Jt YWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1z cGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0 LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7 IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIg Y2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1m YW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFs OyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3Bh Y2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10 cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAt d2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxv YXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9IiI+Q2hhbmdlcw0K IHNpbmNlIHYyOjwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZv bnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5v cm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVy LXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRl eHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBw eDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7 IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250 LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3Jt YWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1z cGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0 LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7 IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBm bG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj4tDQogbmV3 IGluIHYzPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1m YW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFs OyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3Bh Y2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10 cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAt d2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNs YXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFt aWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsg Zm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNp bmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJh bnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdl YmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0 OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPi0tLTwvc3Bhbj48 YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1S ZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50 LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsg dGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25l OyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0 cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFu IHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVn dWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1j YXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRl eHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsg d2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJv a2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxh eTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj50b29scy9vY2FtbC94ZW5zdG9yZWQvc3Rv cmUubWwNCiB8IDIgKy08L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDAp OyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxl OiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxl dHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4 OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5n OiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBu b25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsg Zm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTog bm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0 ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsg dGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzog MHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9u ZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9IiI+MQ0K IGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSk8L3NwYW4+PC9kaXY+ DQo8L2Jsb2NrcXVvdGU+DQo8L2Rpdj4NCjxiciBjbGFzcz0iIj4NCjxkaXYgY2xhc3M9IiI+DQo8 ZGl2IHN0eWxlPSJtYXJnaW46IDBweDsgZm9udC1zdHJldGNoOiBub3JtYWw7IGZvbnQtc2l6ZTog MTFweDsgbGluZS1oZWlnaHQ6IG5vcm1hbDsgZm9udC1mYW1pbHk6IE1lbmxvOyIgY2xhc3M9IiI+ DQo8c3BhbiBzdHlsZT0iZm9udC12YXJpYW50LWxpZ2F0dXJlczogbm8tY29tbW9uLWxpZ2F0dXJl cyIgY2xhc3M9IiI+QWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgJmx0OzxhIGhyZWY9Im1haWx0 bzpjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20iIGNsYXNzPSIiPmNocmlzdGlhbi5saW5kaWdA Y2l0cml4LmNvbTwvYT4mZ3Q7PC9zcGFuPjwvZGl2Pg0KPC9kaXY+DQo8ZGl2IGNsYXNzPSIiPjxz cGFuIHN0eWxlPSJmb250LXZhcmlhbnQtbGlnYXR1cmVzOiBuby1jb21tb24tbGlnYXR1cmVzIiBj bGFzcz0iIj48YnIgY2xhc3M9IiI+DQo8L3NwYW4+PC9kaXY+DQo8L2JvZHk+DQo8L2h0bWw+DQo= --_000_FAE0E9E3A5964055A8D5E9AD65DB60A1citrixcom_-- From xen-devel-bounces@lists.xenproject.org Wed Nov 09 13:52:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 13:52:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.440965.695219 (Exim 4.92) (envelope-from ) id 1oslVf-0000BN-Q3; Wed, 09 Nov 2022 13:52:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 440965.695219; Wed, 09 Nov 2022 13:52:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslVf-0000BG-NJ; Wed, 09 Nov 2022 13:52:55 +0000 Received: by outflank-mailman (input) for mailman id 440965; Wed, 09 Nov 2022 13:52:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslVe-0000B0-2Z for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 13:52:54 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ccbdc9d6-6035-11ed-8fd2-01056ac49cbb; Wed, 09 Nov 2022 14:52:52 +0100 (CET) Received: from mail-bn7nam10lp2104.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 08:52:43 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by CH0PR03MB6194.namprd03.prod.outlook.com (2603:10b6:610:d1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 13:52:41 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 13:52:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ccbdc9d6-6035-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668001972; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=AshlGvsUEL8E+f1ma1eeySPM/TeTkUHP3JiBRTHltU0=; b=bpWJyX61rsgha3S0yfh1Gy3C9f+lqArULDq16rEuvBAdG4oOTMmElo42 NfqVLSpA2I80qOd8vMLd9Ja0Rrld2UXmCOZwdUMHnW283yXPhWOtnvTuE k7e3HQ13hfFgxpWkb1hpuRj+PY3yUgpD72SOCFwu0QpBF5G+uzlMixxye Y=; X-IronPort-RemoteIP: 104.47.70.104 X-IronPort-MID: 84069401 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Wk40cao4cvR9cH7aI3PXAkDcM/VeBmIrZBIvgKrLsJaIsI4StFCzt garIBmAa6mMYGGmco0jYIvioE4GvMSByd5lSwturik0En8R85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzyhNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAGFcUk2xre6T+pWQU/ZsnZQmCM/UI6pK7xmMzRmBZRonabbqZvySoPV+g3I3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+CraYKJEjCJbZw9ckKwq 27Y/mK/HhYAM9+3wjuZ6HO8wOTImEsXXapCSOXmp6Iy2TV/wEQJDyIRaWmyqMWIh1eHQuwYL mY7uS0x+P1aGEuDC4OVsweDiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceZTEsz E7PoNrvChRmqrjTQnWYnp+YpC2/ETIYJmgDYWkDVwRty8bniJE+iFTIVNkLLUKuptj8GDW1y TbVqiE73u0XlZRSj/n9+k3biTWxoJSPVhQy+gjcQmOi6EV+eZKhYIurr1Pc6J6sMbqkc7VIh 1Bc8+D20QzEJcvlePClKAnVIIyU2g== IronPort-HdrOrdr: A9a23:CVO186Gz8hHJ8/q8pLqFS5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTjLJr0Unp91yy6 RNwiaQsIdWFwrJmGDn68HPTAwCrDv8nZKz+dRj8EC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBoPkoLVeLizNbFwg2PwqT+GLEXQI+llluhEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8 o= X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208";a="84069401" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cUo8lHUqKRmbMIXAUJA5fnNDhyTUh1ISxdhbcYaeeGQCBlmYbSMOs8lNKQ/m+CDZBI8a1/YlAJDfQsZdSr3fYDn8IBq2cxW51cCpx1NhU9OTw/+hLOVIWOj0DmdEyZxgc7ih38pfdSoq6cBCZb9/nSTHn6swYe6JwK7fCyqWR8l5vmYEGlUlV10mB3ci93NLQohFDDQH06F74q+deAjwJU3o4Kx4/4EEwriDeCDwfp6vNVy7qZwLeih/hFog112ag19sdTD6n9uzWueB89EtO0HgKEgFQUW2WHNRDEBbB5ZMY4rSOGdwqSevml204tLhujjp0zcLQZxw0R9/o8r7LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AshlGvsUEL8E+f1ma1eeySPM/TeTkUHP3JiBRTHltU0=; b=h3WiiyS7F8+MskQIRgrV4E2Fq3IcZh3daUQW2Jvh3tEmCmByqk6q2+Vsg+l1RmWZOypO50ypqRZrJylFndpeY6AfR4Nh7spUq8MtpyNjbZRz5dE6Fk4BCXJ50rCo2tXfFrc6P9J0IMdZCFyghyjTNmP7BcETaoQO4/W+Zf0qjkCStt3iukdOAjTZvcY5uPqOHs2vTaC3GuhTYyG4HX2IgyYd1EHO4uJdTgDeGbxWuZiwZGnEo5GIX7j2lYHXWxbJrZaydDU0rZWpvXs/KncfWYhbvtchn+phycleX8WGBjPnxL4n0ZsU3qsxGFAew1zkXfCVBDdCrYkVQX+9qzLDOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AshlGvsUEL8E+f1ma1eeySPM/TeTkUHP3JiBRTHltU0=; b=V5zT56OQsHr8BHYrwrnNxygtCsOwY8dQeUTxPsjIvseq6bcztpL3xXrO+77VgLZph4vSk2F01vavMpjpsnYCLF8o9XPleH9XIIZ7YpGxO+OFq49RtYLlb3/Gq11vvU1sh4oM5B1McN0XSeRzo3x7xfBRzB36npQCJ/2wMM6xlu8= From: Edwin Torok To: "xen-devel@lists.xenproject.org" CC: Henry Wang , Christian Lindig , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 15/15] tools/ocaml/libs/xc: fix use of uninitialized memory in shadow_allocation_get Thread-Topic: [PATCH for-4.17 v3 15/15] tools/ocaml/libs/xc: fix use of uninitialized memory in shadow_allocation_get Thread-Index: AQHY84hP/JHefKuHJEOBKR0Y52MvLq42nfQA Date: Wed, 9 Nov 2022 13:52:41 +0000 Message-ID: <567AAD55-5FD3-42B9-88EB-661A808822EB@citrix.com> References: <94f93ee61a4d0bd2fac3f5a753cb935962be20bb.1667920496.git.edvin.torok@citrix.com> In-Reply-To: <94f93ee61a4d0bd2fac3f5a753cb935962be20bb.1667920496.git.edvin.torok@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|CH0PR03MB6194:EE_ x-ms-office365-filtering-correlation-id: 3b0d35e0-8b4d-47b7-8cf8-08dac259abb8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WhdWCZPlaIReYmHdo0X29j35WRc7wpic65tY1oN0lLSWR+12D5L3nhKq/J/gVcsP02xJENImRnHurd4tFklSLnlodXuF88GH9dA2XmS54r40x8oxs6oRDy2XKw4DzFc9p1yWPetBKMg1pfuu1bBnhCMeDmhMgQvYgDVLL+yCHlzbnmMEwlMcHCHDsItBTVb/2IF2HISRKyXgUoouDGkLiNgvJ3NVxLRFh7ITohVCpU5pY4oCppCBM4hXGzuyyllGN/6uwTfiaruTU0qClF9otzYjNFV1RO2msl1cThjSY+YzFUNs+LF/43bN7WPzFf6rgNnGvhWkA0YmFR3XJqTxocAn+bi9U2IIY0TBR6TnqCMzZzYytG6GhB4rYD4au99WzM7VynsDRcSJe/0TrJmvr/QHWE3wdxvrXOC+/wdA4f3LVBXlaKzocb0UmkZ1HKTEvlQd3QZmfW3s6ZkVcuE/lZKVdq3c0ESRFKXdQYCtZSHgv66zRW5dw4iOkIlLuCufU3dUF0HgR86tNIQN9nqPh/9Y1XSTMgquZ2wocbQ6a+2iCHHaRcnlfHBQwWElM+xa2LaA6UZ729O7Wxu2/pVhAcjyem4md6NMMRZLtMNeAuyHoCSV+cU4eEjOLbsLgspwT14OQm3DGXLNrzErVmkT4FH3SvHsXM+Ro5DVZQeX5JYAfIqI8kzn/M6HbgHfdzL+V/jY8uZloKoaPCq+s4+VOarY21ZhSAWVrjb9Vtfd/sbF+5O/tHPLV0R2EK/LnKNz5mYvFno3FLqjmu9vExmKZU12mDJAafEeqQhkP552RErKwDoTgkydv7tH/1dg5ydPwu73S5dL4cxw4EK/NEe4elDC0HyZ0tj5s+9w0mRGOLAK4wQ7Y6ZYfBXbC9bXGIR4 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(136003)(396003)(346002)(39860400002)(451199015)(86362001)(76116006)(66446008)(66556008)(64756008)(66476007)(316002)(66946007)(91956017)(5660300002)(41300700001)(54906003)(6916009)(45080400002)(8936002)(33656002)(8676002)(71200400001)(2616005)(186003)(2906002)(478600001)(6486002)(6512007)(122000001)(26005)(6506007)(4326008)(36756003)(38070700005)(38100700002)(53546011)(66574015)(966005)(83380400001)(82960400001)(107886003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NUZZRFNNeTZ1MkpCViswbmNKMXV2bld2dWppN1R0VFlLLzQyMG93S0w3N1Na?= =?utf-8?B?cWx0cU9KTCtpUmFGSURtbFdaclhZc1k0UVpIV3dodm5wcWY3eHVnZ21wcnZr?= =?utf-8?B?a3BFY3lzajNra2ZHK2JoYTIvUDVHMCtUaWJsUHdqL2hVZlp3VEJPRDJwR3h1?= =?utf-8?B?VHZMbWh5Q3RBVCtVUDUzNUN0d0hyNHEzZTRFWUZmNzRreFJSMlhDN1lVbjZC?= =?utf-8?B?Y0NnaWRJZC9yT0M0dXQ3aUpJQyt3OXZteHA3RVQ5RFNLTFVJVlYrZmpzVERL?= =?utf-8?B?SHhUSUZ3WDBRcDN4YTlGM3Y3dG5vZGdxNFdDbzRXVG1XSWh3Ykk0UHNsZ1JI?= =?utf-8?B?OHh3ck9XMXhTZU8yYWk3ZWo1V0tzeGYrc3JMMFpUWGhJc1dYcDdUOStyUS92?= =?utf-8?B?Vm1TY1dqYWhrRnhhM0hjTllCOXpyeHZEbjdnVDdCV2dVMkdsSENRSDF5UmR5?= =?utf-8?B?TndMdTIyQ0dHc0dtcUoraG02RElJWWRhUTNEN1BWT3owT25oK0VTZW4ydmZ0?= =?utf-8?B?cmxzRW40V29SalhVTVp2cXYwUFB2YXAxZC9PQnJUTE5LT3I5QlNDV0pjR2dn?= =?utf-8?B?YWJMZkJkaHVpSzlEejJXcHpNeVdVRU5hL2FwbkM3SEJMZXpaVGoyZ2d3M2tK?= =?utf-8?B?eWFyU21UbXRGTmFXS1E2dTdDMXM4VG05UnJFbSswZFlSYmk1MzQvcjFpdWdG?= =?utf-8?B?ZUJxd0dFQ3Ficm1Xbkd0VUU3ck5QYTQxQXJXUU5CK0N3RTRyaEttWkgzYjVQ?= =?utf-8?B?N0ZMU3g5eFF4RDVoZ2JoT1VaOEVnOGR6V0x1TVhENitTRzVjUDVXazRkZXRZ?= =?utf-8?B?YXl2NERCcnpTSE5kKzFjbTh3RktWQ1ZVOEozWEVXamNRbkFzaStoWCs1dit6?= =?utf-8?B?WFhLOWNZUnVPLzl0RlY3WkdBVTZmZjdqS28vOXVja1BKZUdFT05zanpoMWxT?= =?utf-8?B?MlBCTXEvN1VLeGtWUDJmM3g3YzIyZVVMVkxXSEZiVlJtdDhJTFBlM21qMU1z?= =?utf-8?B?NTR3TnE3VWVjMnZ3VXBTWUtqL1VZWllzU0pkWTQrK2l0NEtTY0N6S0ZzcERO?= =?utf-8?B?UnhBSk51dFJpQjdHQThtNGJldDZDUmI4eHh0eWxxWWdBN3IvaW45eUZhVjJM?= =?utf-8?B?SXIwUVloRklFbUkydCtiQ3RHNkpqSjBDak9tdUhVOHR0TXF2eXNGRzhyTXRF?= =?utf-8?B?MzZ3TU50UzZBUGdYTzA4TkR1MGFHWjg4NUlkNWoxUmFrbGdFcE1LMDdZa0NU?= =?utf-8?B?cHIrblljVmN0VU5NWHkrUVZiSW1scmpBZlRZZzl0RjliRGk0b1piUXowbzE4?= =?utf-8?B?QlpmejJRSmxVdXZFbHA2VjZNalMxZXhqbGt0T3RRYjh3TFNUU05TTlUvRTZQ?= =?utf-8?B?eGpSQy9WcENPNFhJM0ltcFdPbHVoNHE4ZlozLzZFenRtWGd1V3JpdHU4cTJ5?= =?utf-8?B?cFJBOTZhMHp0QnExU3d1Q0xYRjFLc1IvRTBxbWVsZnRmZFpUNU1RWWZtWnBk?= =?utf-8?B?QWhQK0Y1SU1vZ2JpcGhNUGRNaTN6OVRVaUpKbVdidkgzZ1FoVisyU1crbjZI?= =?utf-8?B?blpwWUxGUzF6RnpVK3BCSVc5WituamZSTWZ1ZkpGaVAybWxadHd5ZlNvc3hw?= =?utf-8?B?aDRydmpkUnJ6ZUpkUllaejdMWFVoanZaVGtSUk1ReHdNNzhCdHFQbjRFNi9D?= =?utf-8?B?NW02L3VMbFM4MGdPeGwrWHk2U251Sms5VTVRM3AzZjNlTGR0b1lDOGNvQ0xY?= =?utf-8?B?VitRNWFJb2JpeC82ZllyemNpNFQ4NjVIcVRQbldvWi9ON1ZtZ3ZjYU1TaENm?= =?utf-8?B?YjFOTTlNTjZ3bUNXN09EekdvUDFab2F0RUxiRzBWRUJQNDErL3ZEZDBSU2ph?= =?utf-8?B?MHVXN251b21EeHcyclFUbEZwbmtjZmU0bUVDSXo3dnA0dXoyV0QvajVCNHhC?= =?utf-8?B?dE94WHJPaWpsaVY0RksxT1daTnhGOUZQL3FrdFRZYVBQNURPc0s3Q01KdzZu?= =?utf-8?B?U0RGQlY0bjhRcE1lK2Fqd2xBTmJ3bHdpNWZBUURhUEZ4djVYOEIrSTltZS90?= =?utf-8?B?ZWZLZXJEQUszMmJjdVhWS2Y1N2c5dFUzZCtDQ0U4Y1IrRW1GQjRub0JnSFVD?= =?utf-8?B?K0h5djA5cUlEZFlTejB2ZUF3YUVZRHRCbGVnYzJIekc0WmxEZ3NZemlHcHZS?= =?utf-8?B?dHc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <6D3E6E3FD5AB27498A6DFF049018AA81@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b0d35e0-8b4d-47b7-8cf8-08dac259abb8 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 13:52:41.5066 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gQ/83QQz1wduqsz3V/KGJwt/YdY1KOmjC5qYeWlyD1Kd9Bt4q4i58tNPhe8T3TBE52DQQ+yrd3m7m0mTFnOTMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6194 T24gOCBOb3YgMjAyMiwgYXQgMTU6MzQsIEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9rQGNpdHJp eC5jb20+IHdyb3RlOg0KPiANCj4gSXQgaGFzIGJlZW4gbm90aWNlZCBpbiAyMDEzIHRoYXQgc2hh ZG93IGFsbG9jYXRpb24gc29tZXRpbWVzIHJldHVybnMgdGhlDQo+IHdyb25nIHZhbHVlLCB3aGlj aCBnb3Qgd29ya2VkIGFyb3VuZCBieSBhZGRpbmcgYSBsaW1pdCB0byB0aGUgc2hhZG93DQo+IG11 bHRpcGxpZXIgb2YgMTAwMCBhbmQgaWdub3JpbmcgdGhlIHZhbHVlIGZyb20gWGVuIGluIHRoYXQg Y2FzZQ0KPiB0byBhdm9pZCBhIHNoYWRvdyBtdWx0aXBsaWVyIGNhdXNpbmcgYSBWTSB0byByZXF1 ZXN0IDZQQiBvZiBtZW1vcnkgZm9yDQo+IGV4YW1wbGU6DQo+IGh0dHBzOi8vbmFtMDQuc2FmZWxp bmtzLnByb3RlY3Rpb24ub3V0bG9vay5jb20vP3VybD1odHRwcyUzQSUyRiUyRmdpdGh1Yi5jb20l MkZ4YXBpLXByb2plY3QlMkZ4ZW4tYXBpJTJGcHVsbCUyRjEyMTUlMkZjb21taXRzJTJGYmU1NWE4 YzMwYjQxZDFjZDc1OTZmYzEwMGFiMWNmZDM1MzlmNzRlYiZhbXA7ZGF0YT0wNSU3QzAxJTdDZWR2 aW4udG9yb2slNDBjaXRyaXguY29tJTdDNTRmYTE5OTA1NTY3NDczNzUzNmYwOGRhYzE5ZjcwMjYl N0MzMzU4MzZkZTQyZWY0M2EyYjE0NTM0OGMyZWU5Y2E1YiU3QzAlN0MwJTdDNjM4MDM1MTg3Nzgx ODcwMDY2JTdDVW5rbm93biU3Q1RXRnBiR1pzYjNkOGV5SldJam9pTUM0d0xqQXdNREFpTENKUUlq b2lWMmx1TXpJaUxDSkJUaUk2SWsxaGFXd2lMQ0pYVkNJNk1uMCUzRCU3QzMwMDAlN0MlN0MlN0Mm YW1wO3NkYXRhPWwzJTJCU0RRaW5vcVo5Q1p2V3NBY1hnRmw1dkViSmY3aGpWekJQTEtvVllwNCUz RCZhbXA7cmVzZXJ2ZWQ9MA0KPiANCj4gSG93ZXZlciB0aGF0IGlzIGp1c3QgYSB3b3JrYXJvdW5k LCBhbmQgSSd2ZSBqdXN0IHJlcHJvZHVjZWQgdGhpcyBieQ0KPiBraWxsaW5nIGEgVk0gbWlkIG1p Z3JhdGlvbiwgd2hpY2ggcmVzdWx0ZWQgaW4gYSBzaGFkb3cgbXVsdGlwbGllciBvZg0KPiA2Mjku NDIsIHJlbmRlcmluZyB0aGUgVk0gdW5ib290YWJsZSBldmVuIGFmdGVyIGEgaG9zdCByZWJvb3Qu DQoNCg0KQWZ0ZXIgc29tZSBtb3JlIGRpc2N1c3Npb24gaXQgbG9va3MgbGlrZSB0aGlzIGlzIGdl dHRpbmcgZml4ZWQgaW4gdGhlIGh5cGVydmlzb3IsIHNvIHRoaXMgd29ya2Fyb3VuZCB3b3VsZG4n dCBiZSBuZWVkZWQsDQptaWdodCB3YW50IHRvIGhvbGQgb2ZmIG9uIHRoaXMgcGF0Y2ggdW50aWwg dGhlIGRvbWN0bCBkaXNjdXNzaW9uIGlzIHNldHRsZWQgYXQ6DQpodHRwczovL2xvcmUua2VybmVs Lm9yZy94ZW4tZGV2ZWwvMjAyMjExMDgxMTM4NTAuNjE2MTktMS1yb2dlci5wYXVAY2l0cml4LmNv bS8NCg0KDQpCZXN0IHJlZ2FyZHMsDQotLUVkd2luDQoNCj4gDQo+IFRoZSByZWFsIGJ1ZyBpcyBp biBYZW46IHdoZW4gYSBWTSBpcyBkeWluZyBpdCB3aWxsIHJldHVybiAnMCcgZm9yIHBhZ2luZw0K PiBvcCBkb21jdGxzIGFuZCBsb2cgYSBtZXNzYWdlIGF0IGluZm8gbGV2ZWwNCj4gJ0lnbm9yaW5n IHBhZ2luZyBvcCBvbiBkeWluZyBkb21haW4nLCB3aGljaCBsZWF2ZXMgdGhlICdtYicgcGFyYW1l dGVyDQo+IHVuaW5pdGlhbGl6ZWQgdXBvbiByZXR1cm4gZnJvbSB0aGUgZG9tY3RsLg0KPiANCj4g VGhlIGJpbmRpbmcgYWxzbyBkb2Vzbid0IGluaXRpYWxpemUgdGhlICdjLT5tYicgcGFyYW1ldGVy IChpdCBpcyBtZWFudA0KPiB0byBiZSB1c2VkIG9ubHkgd2hlbiBzZXR0aW5nLCBub3Qgd2hlbiBx dWVyeWluZyB0aGUgYWxsb2NhdGlvbiksDQo+IHdoaWNoIHJlc3VsdHMgaW4gdGhlIFZNIGdldHRp bmcgYSBzaGFkb3cgYWxsb2NhdGlvbiAoYW5kIHRodXMgbXVsdGlwbGllcikNCj4gc2V0IGJhc2Vk IG9uIHdoYXQgdmFsdWUgaGFwcGVuZWQgdG8gYmUgY3VycmVudGx5IG9uIHRoZSBzdGFjay4NCj4g DQo+IEV4cGxpY2l0bHkgaW5pdGlhbGl6ZSB0aGUgdmFsdWUgcGFzc2VkIHRvIHRoZSBkb21jdGws IGFuZCBkZXRlY3QgdGhlIHVuaW5pdGlhbGl6ZWQNCj4gY2FzZSAoc2hhZG93IGFsbG9jYXRpb24g b2YgMCksIGFuZCByYWlzZSBhbiBleGNlcHRpb24gaW4gdGhhdCBjYXNlLg0KPiBUaGUgZXhjZXB0 aW9uIHdpbGwgY2F1c2UgeGVub3BzZCB0byBza2lwIHNldHRpbmcgdGhlIHNoYWRvdyBtdWx0aXBs aWVyLg0KPiANCj4gTm90ZSB0aGF0IHRoZSBiZWhhdmlvdXIgb2YgWGVuIGhlcmUgaXMgaW5jb25z aXN0ZW50IGJldHdlZW4geDg2IGFuZCBBUk06DQo+IEFSTSB3b3VsZCByZXR1cm4gRUlOVkFMIHdo ZW4gaXQgZ2V0cyBhIHBhZ2luZyBvcCBvbiBhIGR5aW5nIGRvbWFpbiwNCj4gYW5kIFg4Ni02NCB3 b3VsZCByZXR1cm4gMCB3aXRoIHBvc3NpYmx5IHVuaW5pdGlhbGl6ZWQgZGF0YS4NCj4gDQo+IEl0 IG1pZ2h0IGJlIGRlc2lyYWJsZSB0byBjaGFuZ2UgdGhlIHg4NiBwYXRoIGluIHRoZSBoeXBlcnZp c29yIHRvIHJldHVybg0KPiBFSU5WQUwsIGFsdGhvdWdoIHRoYXQgd291bGQgcmVxdWlyZSBtb3Jl IHRlc3RpbmcgaW4gY2FzZSBpdCBicmVha3MNCj4gc29tZXRoaWcuDQo+IEJ1dCB0aGUgYmluZGlu Z3Mgc2hvdWxkIGJlIGRlZmVuc2l2ZSBhbnl3YXkgYWdhaW5zdCBidWdzIGxpa2UgdGhpcy4NCj4g DQo+IFNpZ25lZC1vZmYtYnk6IEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+ DQo+IC0tLQ0KPiBSZWFzb24gZm9yIGluY2x1c2lvbiBpbiA0LjE3Og0KPiAtIGZpeGVzIGEgbG9u Zy1zdGFuZGluZyAoPjl5IG9sZCkgYnVnIHRoYXQgaXMgc3RpbGwgaGFwcGVuaW5nIHRvZGF5DQo+ IA0KPiBDaGFuZ2VzIHNpbmNlIHYyOg0KPiAtIG5ldyBpbiB2Mw0KPiAtLS0NCj4gdG9vbHMvb2Nh bWwvbGlicy94Yy94ZW5jdHJsX3N0dWJzLmMgfCA1ICsrKystDQo+IDEgZmlsZSBjaGFuZ2VkLCA0 IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYgLS1naXQgYS90b29scy9v Y2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYyBiL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3Ry bF9zdHVicy5jDQo+IGluZGV4IGUyZDg5NzU4MWYuLjk2ODFhNzRlNDAgMTAwNjQ0DQo+IC0tLSBh L3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybF9zdHVicy5jDQo+ICsrKyBiL3Rvb2xzL29jYW1s L2xpYnMveGMveGVuY3RybF9zdHVicy5jDQo+IEBAIC0xMDE5LDcgKzEwMTksNyBAQCBDQU1McHJp bSB2YWx1ZSBzdHViX3NoYWRvd19hbGxvY2F0aW9uX2dldCh2YWx1ZSB4Y2gsIHZhbHVlIGRvbWlk KQ0KPiB7DQo+ICAgICBDQU1McGFyYW0yKHhjaCwgZG9taWQpOw0KPiAgICAgQ0FNTGxvY2FsMSht Yik7DQo+IC0gICAgdW5zaWduZWQgaW50IGNfbWI7DQo+ICsgICAgdW5zaWduZWQgaW50IGNfbWIg PSAwOw0KPiAgICAgaW50IHJldDsNCj4gDQo+ICAgICBjYW1sX2VudGVyX2Jsb2NraW5nX3NlY3Rp b24oKTsNCj4gQEAgLTEwMjksNiArMTAyOSw5IEBAIENBTUxwcmltIHZhbHVlIHN0dWJfc2hhZG93 X2FsbG9jYXRpb25fZ2V0KHZhbHVlIHhjaCwgdmFsdWUgZG9taWQpDQo+ICAgICBjYW1sX2xlYXZl X2Jsb2NraW5nX3NlY3Rpb24oKTsNCj4gICAgIGlmIChyZXQgIT0gMCkNCj4gICAgICAgICBmYWls d2l0aF94YyhfSCh4Y2gpKTsNCj4gKyAgICBpZiAoICFjX21iICkNCj4gKyAgICAgICAgY2FtbF9m YWlsd2l0aCgiZG9tY3RsIHJldHVybmVkIHVuaW5pdGlhbGl6ZWQgZGF0YSBmb3Igc2hhZG93ICIN Cj4gKyAgICAgICAgICAgICAgICAgICAgICAiYWxsb2NhdGlvbiwgZHlpbmcgZG9tYWluPyIpOw0K PiANCj4gICAgIG1iID0gVmFsX2ludChjX21iKTsNCj4gICAgIENBTUxyZXR1cm4obWIpOw0KPiAt LSANCj4gMi4zNC4xDQo+IA0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 09 13:59:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 13:59:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441012.695248 (Exim 4.92) (envelope-from ) id 1oslc8-0002Eo-U4; Wed, 09 Nov 2022 13:59:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441012.695248; Wed, 09 Nov 2022 13:59:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslc8-0002Eh-QX; Wed, 09 Nov 2022 13:59:36 +0000 Received: by outflank-mailman (input) for mailman id 441012; Wed, 09 Nov 2022 13:59:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslc7-0002Eb-K2 for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 13:59:35 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bc1b78e0-6036-11ed-8fd2-01056ac49cbb; Wed, 09 Nov 2022 14:59:33 +0100 (CET) Received: from mail-bn8nam12lp2174.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 08:59:30 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by DM6PR03MB5020.namprd03.prod.outlook.com (2603:10b6:5:1e8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Wed, 9 Nov 2022 13:59:28 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 13:59:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc1b78e0-6036-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668002373; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=53lqmJ+nw6CoBPDdxqm7IMGChyE06LlyF8vVrF6SPLA=; b=E3B6EHi1miWNfP6pomhBO40hPYrHRY5Wu015L74t3/aewqVhdLVFRhIf Onf3+rAAhDi2BUquU5uYb0dF6CSkv28UY/94C14oCod82lb0HSy3u9gA+ djb6r20zkITg9ArVIoZ0gUpHpNAByqj7W+lNicqI1a0jz82d9rSbAnmFe U=; X-IronPort-RemoteIP: 104.47.55.174 X-IronPort-MID: 84473854 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:EjqnjK5JiUV4NKHT+yXUkwxRtAbGchMFZxGqfqrLsTDasY5as4F+v jQdUWnVafrcZWSgf9ElPtyx8kgEvJbcxoBiGgE9/n9mHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkT7QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mz O00MykDRRm/q+/v8pipZep8lN0PBZy+VG8fkikIITDxK98DGMqGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooj+SF3Nn9I7RmQe1enlyZv X7H9mK/BhAcON2Q4TGE7mitlqnEmiaTtIc6ROHkqaU63QH7Kmo7Nl4kSHSRvPCCpw2vdI5YE 2cY3Hcjov1nnKCsZpynN/Gim1aUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebRwn0 EWY2ezgAzNHuaeQD3ma89+8oTqsNAAPIGQFZCtCShEKi/H8pKkjgxSJScxseJNZlfXwEDD0h jqM/C43guxJidZRjvrnu1fanziru57FCBYv4RnaVX6k6QU/Y5O5Y4uv6h7Q6vMowJulc2Rtd UMsw6C2hN3ix7nU/MBRaI3hxI2U2ss= IronPort-HdrOrdr: A9a23:sqW4G6yq5KTjtBUHij3tKrPxj+skLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqm12Mw+N57y6 5FxGSfqt5eCg7Bhj3045zSWwhtjVfcmwtqrQaC50YvLrf2RYUh2rD3xnklZqsoDWb/8sQqAe NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN DbXFZRpQcJCjbT4A21reh2Gzz2MRaAtG7Wu7BjDrBCy83BbauuNzGfQ1YzlMblq+kDA6TgKo SOBK4= X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208";a="84473854" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PoBDlx6F1D17chfBxBCH27sWDYiLmJ9HGROl0q5wGHbw7qOhqwkvIAXvOTpNYEjiV+3eOIIF7zJMQa5Feu4aSEvHMKU8Q+e9Ceu7E1PB8FDL8kDmQw+UlI+p3Xu6n5LPaO+6SBDhqQ9tO81L+RklF2hDX9FNwfYTCd0K25Kl9GKxxz2YDnttdk3iFmnYc3plA+mEqxM8iMBIhL7jO5YhxpdQxzgMvh3gUn82oWxQ6Ad3ivHZuoNtShRGO7qYEJi/YklDsI2XaX9rlbTZ4TDfYAk83lSf6c8uaGmLmP26blgOfQnZdhR8k5/ymOmxyHg3oVd/qoHfm+HIWe9zYdmiBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=53lqmJ+nw6CoBPDdxqm7IMGChyE06LlyF8vVrF6SPLA=; b=bVvfgrh1jenrJj2NVog3vEH5RbZweDA5RKTEruZiXEFoxQMCFLx+eToiHGqgYfpFSHvvgkQ1nVdQYH84bTrqtdQJruHz8qmSOf1jPVA0dGkSmYm+AIERJIgR7m971cj7QPYjRlB4esvsdyg+ZWhbBj9lk4Ik2Jm6VF7YjutUwyBWkS6zdYWDj3AVfL5Iatl3+EKBXWCcbU8pp+X6Jy0Z8m3725oVr+8kY8eK/kWVhJJ1rIHwMH47i7eBtyDN6HSnsbV+10n5+VDl9QBnvBPUVyP+sgC5zZm9rUOnzAabQnJXd1J2pxFNxpcgwZ/ald1+d0P7hG1ZckrLygDm2u0BGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=53lqmJ+nw6CoBPDdxqm7IMGChyE06LlyF8vVrF6SPLA=; b=Q2fQ7BAtt1UsQIwvoWf54Q6NQhiEqmnp2EaIp4ywaFOEfYG07Y/n7jrKinZPgjnLdU9WB1ptCYwraJ3qf8952KLZWIfZlMv7CMFsmlffu4B24AO3lnuyI7JXhkp69ypsB6h6LTw7nn2+fF7Rdp4e1XInGSMG9lm9+00GvQJPkiY= From: Christian Lindig To: Edwin Torok CC: Xen-devel , Henry Wang , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 10/15] tools/ocaml/xenstored: keep eventchn FD open across live update Thread-Topic: [PATCH for-4.17 v3 10/15] tools/ocaml/xenstored: keep eventchn FD open across live update Thread-Index: AQHY84hU2UIFubhrZESPqs29nIiL/a42n+KA Date: Wed, 9 Nov 2022 13:59:28 +0000 Message-ID: <83FE853D-4BB1-437F-AF66-D342F41023B1@citrix.com> References: <17575704fceda409bd5bb0056a94664ddc3ac2e1.1667920496.git.edvin.torok@citrix.com> In-Reply-To: <17575704fceda409bd5bb0056a94664ddc3ac2e1.1667920496.git.edvin.torok@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|DM6PR03MB5020:EE_ x-ms-office365-filtering-correlation-id: 7c0a728e-59b4-4849-74ad-08dac25a9e10 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 57B9BNWk+Q2QELongMfPWsgJh6jYuMSUY96tGOBU0R+FmhjsrMV10RAS1+83/7S2JoxoIVUtev444ZxcjWQP0bTBWrt6Bb3U0v6uJszZY3le++5yW4ZrC/Sva+B+jqCFOumRtskVU/lh+0GM8N+mLT0DRwnWaTAA0pLrnvdncz1x71Pn00tMNbzVMum9uccolmEBC2xx+EPCqKNMOtp9TmInp3BM7tg5f0HWRrMvlCos1kCT+lZRWxEJX+VWWu3PLmBncgMeZRKp8Ylx4FGUZ9aCj/nD2w5YCuF23e7l+p3u5dZpqHFs3zZNQFocbC3jOVal4aR3xRsHE7HH7DArK96ALMv9pmYxk6oedjWq08mgBBYy57oDhaZb92a8U8QGR5XyiLpXIbPSaSn4OZ5/U/iN5hk6mbfn+FXmkNvb755V2WH8733OeajAxMeG4ByTk/mt2qtAxqkEnkr4Rgly3SYHePmT3AFUDZvmYUcaeBw2NQQfli3qYrcXH10dM5BU/TZpf7YGaI4oQLSQEv3gheTdEgijXVItGKjjpXKe20HoCnt++mcmxYrDqWZ+u8isoD5uQcAojtudr+E2XENlkSya10jj0LeB+DaStY9Ws5JEoMk5F+R4ah4j0f0cwuamMs7lf7ldEdszOCwg1HwGmOlVCOoYyZiwZ7iWLWuByB4oExvNn6xmLKvDIxxR5eFVnkU/A7P7uCCct9mV7+22+1OAUUglpKjb5V7u6OmN05FYDsK7PUhvfMeTcZrie/MBKUXl8oAm2P6RqiWmrKcrONng2TEbDdxtP7QqvS4O7qw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(366004)(346002)(396003)(451199015)(8676002)(76116006)(91956017)(66446008)(64756008)(33656002)(4326008)(122000001)(66946007)(316002)(44832011)(66574015)(66476007)(6636002)(54906003)(15650500001)(38070700005)(5660300002)(37006003)(6486002)(82960400001)(66556008)(6862004)(8936002)(107886003)(38100700002)(2906002)(6506007)(83380400001)(53546011)(86362001)(6512007)(26005)(478600001)(71200400001)(2616005)(186003)(41300700001)(36756003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SWtaOVBRMlhBcmxzRklYUlBGVW9pZkxwaWNrM1RBa2lDc1c4ME1pekNRNktM?= =?utf-8?B?blRnc1dCK1RBWjhSSjdnNkh5cTI4RWh1dkwvcTJIbzNWd1JXM1hYZkZIR2ZN?= =?utf-8?B?dUFEWVVNa3U0OUdWUkluejNoOFIwd1JPcWd3N0E3N1R5STZIdFNHYkVIcU9x?= =?utf-8?B?Slpjano2ZERVQUFla1ozQWpBVnR3VElyRHJ6SVJoRHJOUG0yb241RlNvZDFt?= =?utf-8?B?SVg0VUJqUWVnTlE2WnI2OTVORGVkL1RnSGdEMm1vUC8wZldvWko0TjNhMkRp?= =?utf-8?B?ZUdzVldxbENUNVZjenI3TFJFQ0d1TjFkdFNYNXpPWklTZ0NtSWMxM2gyRUh1?= =?utf-8?B?SmZRUk1BRUMxTGt2Mis0Uk1yYk9LMStISzJ6VjYra2Zwbis2SGl0ZGFaZmlu?= =?utf-8?B?bnF6czZJQ1BabmR1V2xYU0JvMFJUUHNOU2FVQzZFWlNvekxOeStLM20xemtQ?= =?utf-8?B?bEJEWXdwVmhtcGlsNHlqbjNpVjQwN3RQVXBFZ0pZMlcrYU5KT3pnblpqQUk0?= =?utf-8?B?akxoVjJyaHFBTUROdVl1WjArb1pVU3k3WkdjV1RMSnoySEF1UUxpS0t6RGRX?= =?utf-8?B?d0ZtYzRKSkN3NklWM0tsRFYyRzFBVGlQRmpjcW5nNFhpZnF5OEhKM3MwbmhQ?= =?utf-8?B?RERFVE9GZEJKVE5DTGJ2Z1Z6bVRmWTNtVVloNGQrMWk5WG1OMnUyeWFKeTJZ?= =?utf-8?B?RVlydmNoRDBNNlpHcW9hWjBnUnRkdk03NlY1dE5oZ3hDM21qS1dTZ21LY0sz?= =?utf-8?B?YVFXeUkyS3I3K3NyMkd5Wk9RWWZmbDR0Z01JYVpJY2tOSVNkK3BwSENhcm5G?= =?utf-8?B?NTVTVFREVGF1L2NiOUNZei9zRFpGR0RmOVBRZ01jakxuN0JpZWtCS1QrZ2sy?= =?utf-8?B?Y0RDaXU3c0JmUjY1VDBnd0RoNjJ1R3pwMy9mZnZ2R3hmamloYTNFQ000S2ty?= =?utf-8?B?SG9DSVpKT3l2TmNNSzcxVW1WcTBreklTVmF1eUY5VERXMWhhMTVLeTlZWXhI?= =?utf-8?B?MktsSTZaS1BRMlFFQWZBQ1hOblhDY0FXTm9wOEVYSmtIY1ZEY2pBRFFDU3Fz?= =?utf-8?B?N2RqSVB2SmdUYzdtazNtNFJVRnh1MTlRak9vRDl0bFBNQUtMYU0vdk5BcWdJ?= =?utf-8?B?OG4zejdWM3c5MlNPeWtKbm9YZE43S3RBRkdielBlL05pN2VWNHcyY1ZLdjdr?= =?utf-8?B?ODVHcmFld2l4SDdZL040TWRCU0JsaXZnR25ZWUExOWZsYk40cG8xRUsvcHlj?= =?utf-8?B?WFhpYVFtYjdlY1dqTng3TlIxK2dpdVk4bHRScVNabFZYaTRvOHAvSDFHWk1x?= =?utf-8?B?V0drRDBUVGVabW8vL0l5cXV2ZFhIaEhOUFI5VzMyNHVpdGpLYzRjVmd2anQv?= =?utf-8?B?WWM3TGlJNVBJL294QjRGeVE5NS93MDYwVW1EejhxTEVVRThZZEwyYkFQZ3Bt?= =?utf-8?B?UU9nKy9YZHpvM0ZYNWc0c1RLY1g2TUZCOXYybkZqTHY5WEYrMkNXYm9FS3dy?= =?utf-8?B?ckZrTWljd0wrQldKMUtISmJDejVDVENZZGduViszUkpmMFlSQnRYWjN4U21B?= =?utf-8?B?eWgzN2xkdFgycmJidDVQUlFVT2NXYmMwZXp4MUZxQXJOQ1Rack9UUnNQM1Jz?= =?utf-8?B?Tlo0L2JBeGNqSjNtaWNwZW8zY2wzWk5VYksrMS9nRkJvdmdPNm9yeXU4VFFx?= =?utf-8?B?c0FLcEVYZTNSdEV5cmlkTGNqKzZjK2s4dlZ5a0xJVEtkS2NtN3ppMHgzc1lE?= =?utf-8?B?YTVDZG9qV2c4NkVKMThPVG9lQWw5WXBtM2hlZ2dRR2plaTkxMUJVRzQzZXRR?= =?utf-8?B?eE1GSkplcmQ5UmRCKzI3RUdUMllLdnBpTUx5OGtMNFNpbGJ3a3o1MnBFL3My?= =?utf-8?B?U1I5RHhkRktvUHV6TU9oSTkycWRRbXNsSWdnek5JeFNZU2Fzcmk0eTE5MDhC?= =?utf-8?B?d1FBRkZsK0hmVTExTzlkcGpWRGtoOVhnMTdpMXY0dDlpcDdhOXd0Nlg2Wmsy?= =?utf-8?B?d1NPQ0trdDdybUU0RzcvQkNSZjRHUUlGSG96QlAxT0svY2d3SS84S20vMDdw?= =?utf-8?B?NmFoTlRLSndpa21XWVFrZmZ0eW9ieXArSXJoYnYvZ0pwVUdWeVNQWjBUVC9U?= =?utf-8?B?Y1ErcHZwS2JRVTBYR0ZEQ0ttaVI2Ni92dnJydENGQ0lFNlk5VWRxMHZKaU0w?= =?utf-8?Q?qnBbATFkZ/hZuma7vv5+qCA=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <10373BB03753144BA9040EFC11F79EFC@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c0a728e-59b4-4849-74ad-08dac25a9e10 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 13:59:28.0757 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wNvqSq+jGUlVpXWSOa/kwZD+BA7ejGYFTKY+4A0iiovgNCyvqmww0b7IUTaEcoWsB7eZDvXMdKhAgVwONAGrDgw2yH8NSucsHlc0ot0LvyU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5020 DQoNCj4gT24gOCBOb3YgMjAyMiwgYXQgMTU6MzQsIEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9r QGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gQXZvaWQgdGhpcyBieSB0cnlpbmcgdG8ga2VlcCB0 aGUgZXZlbnRjaG4gZmlsZSBkZXNjcmlwdG9yIG9wZW4gYWNyb3NzDQo+IGxpdmUgdXBkYXRlcywg dXNpbmcgdGhlIG5ldyB4ZW5ldnRjaG5fZmRvcGVuIEFQSSwgc2ltaWxhciB0byBob3cgQw0KPiB4 ZW5zdG9yZWQgd29ya3MuDQo+IA0KPiBIb3dldmVyIGFuIG9sZCBlbm91Z2ggb3hlbnN0b3JlZCB3 b24ndCBoYXZlIGtlcHQgdGhlIGV2dGNobiBmZCBvcGVuIGFuZA0KPiB3b24ndCBoYXZlIHNhdmVk IGl0IGluIHRoZSB1cGRhdGUgc3RyZWFtLCBzbyBoYW5kbGUgdGhhdCBjYXNlIGJ5DQo+IHJlb3Bl bmluZyB0aGUgZXZ0Y2huIGFzIGEgZmFsbGJhY2suDQo+IA0KPiBBIGZvbGxvd3VwIGNvbW1pdCB3 aWxsIGF2b2lkIHJlYmluZCB0aGUgZ3Vlc3QgcmVtb3RlIHBvcnQgKHdlIGNhbm5vdA0KPiByZWx5 IG9uIHRoZSByZW1vdGUgcG9ydCBzdGF5aW5nIHRoZSBzYW1lLCBlLmcuIHRoZSB3aW5kb3dzIFBW IGRyaXZlcnMNCj4gY2hhbmdlIGl0KQ0KPiANCj4gU2lnbmVkLW9mZi1ieTogRWR3aW4gVMO2csO2 ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4NCj4gLS0tDQo+IFJlYXNvbiBmb3IgaW5jbHVzaW9u IGluIDQuMTc6DQo+IC0gZml4ZXMgbGl2ZSB1cGRhdGUgaW4gb3hlbnN0b3JlZCwgbWFraW5nIGZ1 dHVyZSBzZWN1cml0eSB1cGRhdGVzIGVhc2llcg0KPiAgaWYgdGhlIGJhc2UgY29kZSBhbHJlYWR5 IGhhcyB0aGlzIHBhdGNoDQo+IA0KPiBDaGFuZ2VzIHNpbmNlIHYyOg0KPiAtIG5ldyBpbiB2Mw0K PiAtLS0NCj4gdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RvbWFpbnMubWwgICB8ICAxICsNCj4gdG9v bHMvb2NhbWwveGVuc3RvcmVkL2V2ZW50Lm1sICAgICB8ICA3ICsrLQ0KPiB0b29scy9vY2FtbC94 ZW5zdG9yZWQveGVuc3RvcmVkLm1sIHwgNzEgKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t DQo+IDMgZmlsZXMgY2hhbmdlZCwgNTYgaW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pDQoN CkFja2VkLWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+ DQoNCg0KPiArICAgIGxldCByZXF1aXJlX2RvbXMgKCkgPQ0KPiArICAgICAgbWF0Y2ggIWRvbXMg d2l0aA0KPiArICAgICAgfCBOb25lIC0+DQo+ICsgICAgICAgIGxldCBtaXNzaW5nX2V2ZW50Y2hu ZmQgPSAhZXZlbnRjaG5mZCA9IE5vbmUgaW4NCj4gKyAgICAgICAgaWYgbWlzc2luZ19ldmVudGNo bmZkIHRoZW4NCj4gKyAgICAgICAgICB3YXJuICJObyBldmVudCBjaGFubmVsIGZpbGUgZGVzY3Jp cHRvciBhdmFpbGFibGUgaW4gZHVtcCEiOw0KPiArICAgICAgICBsZXQgZXZlbnRjaG4gPSBFdmVu dC5pbml0ID9mZDohZXZlbnRjaG5mZCAoKSBpbg0KPiArICAgICAgICBsZXQgZG9tYWlucyA9IGNy ZWF0ZWRvbXMgZXZlbnRjaG4gaW4NCj4gKyAgICAgICAgaWYgbWlzc2luZ19ldmVudGNobmZkIHRo ZW4NCj4gKyAgICAgICAgICBFdmVudC5iaW5kX2RvbV9leGNfdmlycSBldmVudGNobjsNCj4gKyAg ICAgICAgZG9tcyA6PSBTb21lIGRvbWFpbnM7DQo+ICsgICAgICAgIGRvbWFpbnMNCj4gKyAgICAg IHwgU29tZSBkIC0+IGQNCg0KSSBsaWtlIHRvIHVzZSB0aGUg4oCcd2hlbuKAnSBjbGF1c2UgaW4g dGhlc2Ugc2l0dWF0aW9ucyBpbiBvcmRlciB0byBrZWVwIHRoZSBtYXRjaCBjYXNlcyBmbGF0IGV2 ZW4gYXQgdGhlIGNvc3Qgb2YgYSBzbGlnaHQgY29kZSBkdXBsaWNhdGlvbi4gQnV0IGl04oCZcyBh IG1hdHRlciBvZiB0YXN0ZS4NCg0KfCBOb25lIHdoZW4gIWV2ZW50Y2huZmQgPSBOb25lIC0+DQoN Ck9yIA0KDQptYXRjaCAhZG9tcywgIWV2ZW50Y2huZmQgd2l0aCANCnwgTm9uZSwgTm9uZSAtPg0K fCA= From xen-devel-bounces@lists.xenproject.org Wed Nov 09 14:04:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 14:04:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441020.695258 (Exim 4.92) (envelope-from ) id 1oslgu-0003oL-Jq; Wed, 09 Nov 2022 14:04:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441020.695258; Wed, 09 Nov 2022 14:04:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslgu-0003oE-HE; Wed, 09 Nov 2022 14:04:32 +0000 Received: by outflank-mailman (input) for mailman id 441020; Wed, 09 Nov 2022 14:04:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslgt-0003o8-E4 for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 14:04:31 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6d4f0fa9-6037-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 15:04:29 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EEE4B1FB; Wed, 9 Nov 2022 06:04:34 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C6A5A3F73D; Wed, 9 Nov 2022 06:04:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d4f0fa9-6037-11ed-91b5-6bf2151ebd3b From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, henry.wang@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH for 4.17] arm: fix Kconfig symbol dependency on arm features Date: Wed, 9 Nov 2022 14:04:20 +0000 Message-Id: <20221109140420.31007-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 The commit 3c2a14ea81c7 is introducing some unsupported arm features that by default are disabled and are used for the cpufeature.c code. As they are disabled by default, a typo in the Kconfig symbol they depend on has landed in the codebase unnoticed, instead of depending on ARM64 which does not exist, fix the code to depend on ARM_64 that is the intended symbol. Fixes: 3c2a14ea81c7 ("arm: Define kconfig symbols used by arm64 cpufeatures") Signed-off-by: Luca Fancellu --- xen/arch/arm/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 1fe5faf847b8..52a05f704da5 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -105,28 +105,28 @@ config HARDEN_BRANCH_PREDICTOR config ARM64_PTR_AUTH def_bool n - depends on ARM64 + depends on ARM_64 help Pointer authentication support. This feature is not supported in Xen. config ARM64_SVE def_bool n - depends on ARM64 + depends on ARM_64 help Scalar Vector Extension support. This feature is not supported in Xen. config ARM64_MTE def_bool n - depends on ARM64 + depends on ARM_64 help Memory Tagging Extension support. This feature is not supported in Xen. config ARM64_BTI def_bool n - depends on ARM64 + depends on ARM_64 help Branch Target Identification support. This feature is not supported in Xen. -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 09 14:05:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 14:05:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441023.695270 (Exim 4.92) (envelope-from ) id 1oslhK-0004Db-T5; Wed, 09 Nov 2022 14:04:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441023.695270; Wed, 09 Nov 2022 14:04:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslhK-0004DU-Ou; Wed, 09 Nov 2022 14:04:58 +0000 Received: by outflank-mailman (input) for mailman id 441023; Wed, 09 Nov 2022 14:04:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslhI-00046W-Vx for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 14:04:57 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7c3e6470-6037-11ed-8fd2-01056ac49cbb; Wed, 09 Nov 2022 15:04:55 +0100 (CET) Received: from mail-dm6nam12lp2174.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 09:04:53 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by DM4PR03MB5999.namprd03.prod.outlook.com (2603:10b6:5:38a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 14:04:48 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 14:04:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c3e6470-6037-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668002695; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=tR91cFwYb4r8FzPL+qz+EAfVT7dAALpyC8kBy6rNUsc=; b=Vsq1XRf0sLURFmfkKFBRQhut1bS6I51Mhs1Bmv3MZ41ZoxUImUSnNLjv FN2hu7I4TSfboLTjbf3MqtjiUaKbZAyrsWz9lkc1G6op6BvqjsI4kCmGI JKLfAjwdElvA+UKsZmMYpPqX+W1ISXPHeTQHe95eGoiMNLieNtzMIsfBS Q=; X-IronPort-RemoteIP: 104.47.59.174 X-IronPort-MID: 84494672 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:x7+vkqiJ0zPbSrPjIhdSNOmLX161XhEKZh0ujC45NGQN5FlHY01je htvC22DPfrZM2Lyftx/a43k/EIO65WDy9dhGQc5+yw3FC0b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QePzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ6cmwnNhqSgtur77yCE/JX2cU+JeDSadZ3VnFIlVk1DN4AaLWaGeDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEgluGybLI5efTTLSlRtk2Yv GPd42XwBFceNdqTyDWt+XOwnO7f2yj8Xer+EZXoqqI73APMnAT/DjUdcF+dhciJlHWfStBlN R0WwxYTiqILoRnDot7VGkfQTGS/lg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC9 lKPhcKvOjVpv5WcU3fb/bCRxRu+MDYYBXUPbigFSU0C+daLiJ43pgLCSJBkCqHdszHuMTT5w jTPoC1ggbwW1JQPz//iogyBhC+wrJ/USAJz/h/QQm+u8gJ+YsiiepCs7l/Yq/1HKe51U2W8g ZTNoODGhMhmMH1HvHblrDkldF1x28u4DQ== IronPort-HdrOrdr: A9a23:WimcAqMUP2MdHMBcT3f155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90dq7MAnhHP9OkMMs1NKZMDUO11HYS72KgbGC/9SkIVyHygc/79 YsT0EdMqyXMbESt6+Tj2eF+pQbsaC6GcuT9IXjJgJWPGVXgtZbnmJE42igcnFedU1jP94UBZ Cc7s1Iq36LYnIMdPm2AXEDQqzqu8DLvIiOW29IOzcXrC21yR+44r/zFBaVmj0EVSlU/Lsk+W /Z1yTk+6SYte2hwBO07R6c030Woqqh9jJwPr3OtiEnEESvtu9uXvUlZ1S2hkF0nAho0idvrD CDmWZmAy050QKtQoj8m2qQ5+Cn6kdj15aq8y7nvVLz5cP+Xz40EMxHmMZQdQbY8VMpuJVm3L tMxH/xjesfMftR9B6NmOQgeisa4XZcm0BS59I7njhaS88TebVRpYsQ8AdcF4oBBjvz7MQiHP N1BM/R6f5KeRfCBkqp9VVH0ZipRDA+Dx2GSk8Ntoic1CVXhmlwyw8dyNYElnkN+ZohQ91P5v jCMK5viLZSJ/VmJZ5VFaMEW4+6G2bNSRXDPCabJknmDrgOPzbXp5v+8NwOlZWXkVwzve4Pcb j6ISBlXDQJCjPT4OW1re122wGIRnmhVjLwzcwb74Rlu9THNcjWDRE= X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208,217";a="84494672" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RkM1wHPXs9bUYVfR6AKQBT0VE+KBku70IVaF7+bRnTF7cr6o2z2wwx/2nnhzf0rpICTxselnrwQHIPkh/llM1P2SAWziDya4QSL60wA34R6cvzBvzRS7q0ai8JoF3CRb+2EvNlku1levh8sqdtP+zWnoWA7eawZCwm61gx47ClQpH20SSMmaILoh8RJxGK3B4Nv2buPchgRS+QEy+QxduK/ya4KCQqFhqv214sHAnj6oCRT/Lc5lplaT3wTY2ikRUsM3qdDiZN6xOtx1Wv65L1QA1f/GRLud31S7sTcnulMd/Nxs3nCj+LJwTPnGQyDRr/5jma48UdN8cl4M3Ai2oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tR91cFwYb4r8FzPL+qz+EAfVT7dAALpyC8kBy6rNUsc=; b=WcUsCETVZ42o2saNRKdzksSRWlxYMy2c1Gqpscb4ciG/aMvK/qqAFO68os4auZvMOYQ106dBDwzVdG5iW7wMUk629qFk9bDAZTcbDB/XNpmXOF1C1vLe4EEnXx+XOCxNNYtiOMljcmXCHU8iCyCKtpetC1tYKPfPoDX8zyVU84RHVDzzD74ZQUzJ3FcvZpg5jQ2YqsCHDxMF38dkZnJnDDXkHvuleQljGEZr1PG5vM07mhG3RcsvXSQ4hvEMEMnBCBlJQEzWDNCMnXBChwT0uXfO5OcZeygHfIKJQD84nkIqiD2I2eV6S9yqFYcfOQO0pyKJOpYSGUGxfJdPC20i3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tR91cFwYb4r8FzPL+qz+EAfVT7dAALpyC8kBy6rNUsc=; b=WEX//v5VROTZyymN+dWDUniBevm7u2wtkGGGEId4DOxF2xJ/zxw9H9iQnNzwpRfhimo53pKJOWQ0JBggJAeX4DUze9vJJgPticTiYYvvqBgzPrO/cK4X1/C8JX/NHOw/v2D96qwvJxpW5nzbhLREiCJwkNPfYwJWDL1bHjM4zXM= From: Christian Lindig To: Edwin Torok CC: Xen-devel , Henry Wang , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 12/15] tools/ocaml/xenstored: log live update issues at warning level Thread-Topic: [PATCH for-4.17 v3 12/15] tools/ocaml/xenstored: log live update issues at warning level Thread-Index: AQHY84hUD0+rjg+Im0aFZKq6Srf93642oVwA Date: Wed, 9 Nov 2022 14:04:47 +0000 Message-ID: References: <550a0bc27c19a6d64d43cdee1f8cc3230d6ff55e.1667920496.git.edvin.torok@citrix.com> In-Reply-To: <550a0bc27c19a6d64d43cdee1f8cc3230d6ff55e.1667920496.git.edvin.torok@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|DM4PR03MB5999:EE_ x-ms-office365-filtering-correlation-id: 13a89fa8-2ad3-4cfb-4d65-08dac25b5c5e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OwIsdmfvr7isSJraRt8mo5vVf0Vtm5Y1LjdjxxSXjmpvIiTUb9YFXts2aOWb6ISoMMEbaG4eZcUgjYc2jUAxNKynbEbHmEej02+HGnvSjUcfut2LGYEmRLY+6232U3/Tyq9cMUrh/MeXSMYCRbq+RHZuwnq7bwkMo9CAFfpi1csDgP7ruFederJi30ml9ivP3e4J69pABCj6to5r3P7uMXV5Q0j+oh1EnVQDdOfFxbSitovYivMfJKbvMc4G2l4dvSWQAH9sxuqMv8u32/MYRQvmZHscezaa355+ne1IJKq6KYNlAxmnwc1O5AihkqCGXaQTw9hoZaZKS4n+CVNlpV+NLSk5RevrO/GSwdM7T5j8BvqzzRLg9KuATjKLOAEPwBXjEtE2938yXUYRq56rfP2aTSlNBCLooYTY8vX0XNFdnZAV7q0b/xFSNhO7fVCQmnz3Ou3EozyxDEjACCSaov/P0HVvX7e+qYn4RvVseN5nl+cLdncU50/LFA9gX1qTPavbz/L3UN+Nhj4vzsjOiuiJQHSPB0cztbVayrYv+D4IwBD7zF19+Q8Hg7U7m5dXehV7rviEsJTcL+JmRE46Jriivl3x7fdE3+aK7YFF8GTDuMNPY8ZFS1y8DurePIHQ2krHLaBrPK/oo8f3/JnDt3HG9B5H4vUU54Xqfa4NRC6dAPa1SD0kIwwUsk9+72UN64wSNOUg3wzvp0pmBdMj8x3hXe9mE4YV1i/5XzOAbh/Ez3wBG71dzkc4oHt2EfngvbQFIBFpQ9hHVxwUy+zQOEA0xQ2qFkKLAQuxgp2soow= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(39860400002)(136003)(346002)(376002)(451199015)(66574015)(83380400001)(86362001)(82960400001)(122000001)(38100700002)(38070700005)(15650500001)(44832011)(4744005)(41300700001)(4326008)(8936002)(6862004)(5660300002)(2906002)(8676002)(6506007)(26005)(53546011)(107886003)(186003)(2616005)(6512007)(76116006)(6636002)(316002)(66476007)(66446008)(64756008)(66556008)(66946007)(91956017)(71200400001)(6486002)(478600001)(37006003)(54906003)(36756003)(33656002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?K2FoZnhEUHlSMlFKNGtEVHYxaFpDUGNFR2h1TnJQMlJid3VXdzIvcGt6R01s?= =?utf-8?B?OHJwOHZDTFdKbk82dlIrVGhxZ0J2QTlHc1Urc0pRL0pmVU53NTFqTzhIdkE3?= =?utf-8?B?am51dkVLU2FXRGt1S0djVHZqMTVBWVFoVWJOZGN0SlkrTkxlRDZqaTE0dHpw?= =?utf-8?B?Z1hyemhMRVZQNjNDTE9TKzhyQkY1ZzZjSnh2YzhySitDcDdVN3l6LzJndFd3?= =?utf-8?B?T051bHlrU3QvNWNDRm82bW40RXJlRUpnQkhQeG5nekdKUUdHQUV0N3NXUDBr?= =?utf-8?B?c1RSbjFUM1VhL1ZTdW9mUWFxSmdmbnVpSGVFTVZlZXRCMkpSVkJvdlR4MVNx?= =?utf-8?B?TFVOSmtXcS9tcTBHd0xsWVp5czk4R29abFlKS2lOTENqdVd4ZFZ6LzBaK2xw?= =?utf-8?B?bmNxQ0pEaFRRNGc5U0hZOHBlNVRKdlI3SnZ2b3l4TG0vazRNanVBdzVzcnRa?= =?utf-8?B?TXpobGVRbitVNXZYeFhlR0tVb1d1ZzJhMURPQllta0Z0VE5FYURzZWMxLy9i?= =?utf-8?B?UTVEZVdJNS9ZQ2U3eWtoQU5pQTZiSW8zY3lpWitsTDVYMW5nVDhqYU95dld0?= =?utf-8?B?Yy9hK21LNVFzUzFmWU9INitxTXBqcVkwWkoxdURMNGJmbXlhbWpOdVhXNEda?= =?utf-8?B?N3lDSXM2UjV2V2NHQ3B6bW1WZGRQNFA3WjQ4Ylh0dHRCN2J3djVPZFcxOXg5?= =?utf-8?B?Uk8xR2d5VlNSZ0pNL0xTODRMT1UyZUh6bjJhcGJ1TVJmWjR4clBFSjl2Smlj?= =?utf-8?B?TXdJWWhTc0RoaDQ1MHA5MTNYcFd0b1hTRFBrUldSeDJNdVJSdDd5UHdzZnBJ?= =?utf-8?B?QTBGVGFuM2JzT3VHdk04VVFPa1NTemFjSy9PL29zaFViODNaVm9MclpxcWRJ?= =?utf-8?B?ODBIejhNMFowQThPbzllQmkxUFRWeVRsM1llNmd2UVp0OUtpRkVNTksycU4v?= =?utf-8?B?UE9HNXBSck9DcUVBUk5LU05BZDN6UUhHelFpb3lBeVVRejlrY0c1UXJOcnpY?= =?utf-8?B?ZkVVa2dHUkF2SzZsSTB3ZzArZ1ZocnNSN25neHpsTnRZYTJ2cWkwRUJRU1ds?= =?utf-8?B?bFYwTC9mZ2NzREhkS0haeURUajNEYjZRZVc2L1ovQjZkTGdvTGRSMEF6akxL?= =?utf-8?B?RE4rNDNnY0VXNU1JOTYwNEE2dWhkZHFyQXB3L01wNXo3RHphRjNyR1NHNnkz?= =?utf-8?B?RzNzVGZ4VU9tZHRzSk80alVjbWRqY0Fjb3p5M1JEWllmbTJOb3kwN01Sclh0?= =?utf-8?B?YnRZejVoT2tDWFJka0FSbnlOcVZlbXVNL2wyUEJyWjF6STdmcXpucU5RNjEv?= =?utf-8?B?bmZTS0NScExMQWUrYkRaQy9SeG1DQmpKYTFwblRGOWI4cWFwVVB2Qk40dWZE?= =?utf-8?B?d2cyWCtVRThBaVRBUHRrcXVWcFBYNHBZQTRUOTBtK0Zic2NLZjV6NFJPTVE2?= =?utf-8?B?L0RqMmI4TUxZRnNRNXh2SkNIcU8xZFZGbGxXc0puNm5udk4rWFV4cmFhc25i?= =?utf-8?B?YVczZnlhUS9iZWtUNzY4eFhCMVc2STJ2WkpUZVcyZ0R2dEZBTVA0Y0MrUjUv?= =?utf-8?B?NTkybG52TEJDSEo3OWNrVThtS1VaamRUSXcxMit3ckVIVmRSeTgwNHh6TXJT?= =?utf-8?B?eWplK0FIQmRjODlLY3ptOWdQSkJFczRQOXpoV2ZLMWJRcFlodEI4b0N3THhj?= =?utf-8?B?ZFdqZ1diU1FqbFlxZWdHWmdqeXVpSzNSYXh2WnJGb0xCbU42b2NQWmVJaWUw?= =?utf-8?B?U2lsV1BveWIyYW1YbXVwSzZrV3RHZU1nanluR0tmTDkzNG1uZWQrVWFjQVB4?= =?utf-8?B?WmVHLzd3amZEQjZvUVgzVGtua1pjcHRxc0VQNG0reWVzdTI1THcyZ1U5c0x4?= =?utf-8?B?K056Y2pqT3pmOHU5dEI5UFdIb1ZCcUgzdHJvNXRkZytXWTArY2s1TFAxR1Vl?= =?utf-8?B?NXJNaHVxRHJ0a2NlL1Q0Vkc4K0FHV1lFZjIwUkw4MFcvcjNoSmpIQzZmckZa?= =?utf-8?B?YU5zWVhqV2J5SGxENnBUMnUwTi94TEtqeEJPb2pRdEhGczF1N29QZ1lpRGo1?= =?utf-8?B?NkFsZFZScXVOLzN3M1VkYmt4L20zYXVabUlnVXpsUWVvR0RJeXlwWE85Q3dm?= =?utf-8?B?dWRZTlpsczJZVUY1MHNyVG8xdzdRbnNvQzlyckFObW9jQ21QZDVFeVlGMThv?= =?utf-8?Q?GsyYbq8H4KhKKXxqOPWJUFo=3D?= Content-Type: multipart/alternative; boundary="_000_C6DBE745FEB94A6C8AAB8C32D0B21E27citrixcom_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13a89fa8-2ad3-4cfb-4d65-08dac25b5c5e X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 14:04:47.3530 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q5vJDufm50AiES1naKyuhjl4ap+R0c6Mn34YMh235Ka3g3iZr/AAmMh+Amd87nl2OJiVSDmLg+dRmCJNvvxsUvgGVVNYrNBmBC9F4KX1P4I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5999 --_000_C6DBE745FEB94A6C8AAB8C32D0B21E27citrixcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DQoNCk9uIDggTm92IDIwMjIsIGF0IDE1OjM0LCBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jva0Bj aXRyaXguY29tPG1haWx0bzplZHZpbi50b3Jva0BjaXRyaXguY29tPj4gd3JvdGU6DQoNCkhvd2V2 ZXIgdGhlIGRlZmF1bHQgbG9nIGxldmVsIGlzIHdhcm5pbmcsIHdoaWNoIG1lYW5zIHRoYXQgcHJv YmxlbXMgZHVyaW5nIGxpdmUNCnVwZGF0ZSB3ZXJlIG5vdCBsb2dnZWQgYXQgYWxsLCB1bmxlc3Mg eW91J3ZlIGNoYW5nZXMgb3hlbnN0b3JlZC5jb25mDQpwcmlvciB0byBsaXZlLXVwZGF0ZS4NCg0K U2lnbmVkLW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbTxtYWls dG86ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4+DQotLS0NClJlYXNvbiBmb3IgaW5jbHVzaW9uIGlu IDQuMTc6DQotIG1ha2VzIGxpdmUgdXBkYXRlIGlzc3VlcyBkZWJ1Z2dhYmxlIChsaXZlIHVwZGF0 ZSBjYW4gYmUgdXNlZCB0byBhcHBseQ0KIHNlY3VyaXR5IHVwZGF0ZXMgdG8gNC4xNykNCg0KQ2hh bmdlcyBzaW5jZSB2MjoNCi0gbmV3IGluIHYzDQotLS0NCnRvb2xzL29jYW1sL3hlbnN0b3JlZC94 ZW5zdG9yZWQubWwgfCA0ICsrLS0NCjEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pDQoNCkFja2VkLWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGlu ZGlnQGNpdHJpeC5jb208bWFpbHRvOmNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4+DQoNCg0K --_000_C6DBE745FEB94A6C8AAB8C32D0B21E27citrixcom_ Content-Type: text/html; charset="utf-8" Content-ID: <49C0FE23AF705540987A1649D34F0D56@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJ3b3JkLXdy YXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZTsgbGluZS1icmVhazogYWZ0 ZXItd2hpdGUtc3BhY2U7IiBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NCjxkaXY+PGJyIGNsYXNz PSIiPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2xhc3M9IiI+DQo8ZGl2IGNsYXNzPSIiPk9u IDggTm92IDIwMjIsIGF0IDE1OjM0LCBFZHdpbiBUw7Zyw7ZrICZsdDs8YSBocmVmPSJtYWlsdG86 ZWR2aW4udG9yb2tAY2l0cml4LmNvbSIgY2xhc3M9IiI+ZWR2aW4udG9yb2tAY2l0cml4LmNvbTwv YT4mZ3Q7IHdyb3RlOjwvZGl2Pg0KPGJyIGNsYXNzPSJBcHBsZS1pbnRlcmNoYW5nZS1uZXdsaW5l Ij4NCjxkaXYgY2xhc3M9IiI+PHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7 IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6 IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0 dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7 IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6 IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5v bmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPkhv d2V2ZXINCiB0aGUgZGVmYXVsdCBsb2cgbGV2ZWwgaXMgd2FybmluZywgd2hpY2ggbWVhbnMgdGhh dCBwcm9ibGVtcyBkdXJpbmcgbGl2ZTwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2Io MCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZv bnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6 IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5k ZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3Jk LXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29y YXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAs IDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250 LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0 MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVu dDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1z cGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0 aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFz cz0iIj51cGRhdGUNCiB3ZXJlIG5vdCBsb2dnZWQgYXQgYWxsLCB1bmxlc3MgeW91J3ZlIGNoYW5n ZXMgb3hlbnN0b3JlZC5jb25mPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAw LCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1z dHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAw OyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6 IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3Bh Y2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlv bjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwg MCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5 bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsg bGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAw cHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNp bmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246 IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIi PnByaW9yDQogdG8gbGl2ZS11cGRhdGUuPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJn YigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsg Zm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdo dDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1p bmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdv cmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVj b3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAs IDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250 LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0 MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVu dDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1z cGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0 aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAw LCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1z dHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAw OyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6 IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3Bh Y2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlv bjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9 IiI+U2lnbmVkLW9mZi1ieToNCiBFZHdpbiBUw7Zyw7ZrICZsdDs8L3NwYW4+PGEgaHJlZj0ibWFp bHRvOmVkdmluLnRvcm9rQGNpdHJpeC5jb20iIHN0eWxlPSJmb250LWZhbWlseTogTWVubG8tUmVn dWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1j YXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IG9y cGhhbnM6IGF1dG87IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRy YW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd2lkb3dzOiBhdXRvOyB3b3JkLXNw YWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXNpemUtYWRqdXN0OiBhdXRvOyAtd2Via2l0LXRleHQt c3Ryb2tlLXdpZHRoOiAwcHg7IiBjbGFzcz0iIj5lZHZpbi50b3Jva0BjaXRyaXguY29tPC9hPjxz cGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8t UmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFu dC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7 IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9u ZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1z dHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlz cGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj4mZ3Q7PC9zcGFuPjxiciBzdHlsZT0i Y2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZv bnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9y bWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWdu OiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNw YWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRo OiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNh cmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250 LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1h bDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjog c3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFj ZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDog MHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUg IWltcG9ydGFudDsiIGNsYXNzPSIiPi0tLTwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiBy Z2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7 IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWln aHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQt aW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3 b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRl Y29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdi KDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBm b250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0 OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWlu ZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29y ZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNv cmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBj bGFzcz0iIj5SZWFzb24NCiBmb3IgaW5jbHVzaW9uIGluIDQuMTc6PC9zcGFuPjxiciBzdHlsZT0i Y2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZv bnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9y bWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWdu OiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNw YWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRo OiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNh cmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250 LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1h bDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjog c3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFj ZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDog MHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUg IWltcG9ydGFudDsiIGNsYXNzPSIiPi0NCiBtYWtlcyBsaXZlIHVwZGF0ZSBpc3N1ZXMgZGVidWdn YWJsZSAobGl2ZSB1cGRhdGUgY2FuIGJlIHVzZWQgdG8gYXBwbHk8L3NwYW4+PGJyIHN0eWxlPSJj YXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9u dC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3Jt YWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246 IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3Bh Y2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6 IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2Fy ZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQt c2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFs OyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBz dGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNl OiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAw cHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAh aW1wb3J0YW50OyIgY2xhc3M9IiI+Jm5ic3A7c2VjdXJpdHkNCiB1cGRhdGVzIHRvIDQuMTcpPC9z cGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1l bmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZh cmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9y bWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06 IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRl eHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0K PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8t UmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFu dC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7 IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9u ZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1z dHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3Bh biBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJl Z3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQt Y2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0 ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7 IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ry b2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3Bs YXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9IiI+Q2hhbmdlcw0KIHNpbmNlIHYyOjwvc3Bh bj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5s by1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJp YW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1h bDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBu b25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0 LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxz cGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8t UmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFu dC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7 IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9u ZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1z dHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlz cGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj4tDQogbmV3IGluIHYzPC9zcGFuPjxi ciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJl Z3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQt Y2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0 ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7 IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ry b2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4g c3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1 bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNh cHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4 dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3 aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9r ZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5 OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPi0tLTwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0 LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNp emU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsg Zm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3Rh cnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTog bm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4 OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1j b2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXpl OiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZv bnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0 OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5v cm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsg dGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBv cnRhbnQ7IiBjbGFzcz0iIj50b29scy9vY2FtbC94ZW5zdG9yZWQveGVuc3RvcmVkLm1sDQogfCA0 ICsrLS08L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZh bWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7 IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFj aW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRy YW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13 ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIgY2xh c3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1p bHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBm b250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2lu Zzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFu c2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Vi a2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6 IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9IiI+MQ0KIGZpbGUgY2hh bmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKTwvc3Bhbj48YnIgc3R5bGU9ImNh cmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250 LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1h bDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjog c3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFj ZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDog MHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjwvZGl2Pg0KPC9ibG9ja3F1 b3RlPg0KPGJyIGNsYXNzPSIiPg0KPC9kaXY+DQo8ZGl2Pg0KPGRpdiBzdHlsZT0ibWFyZ2luOiAw cHg7IGZvbnQtc3RyZXRjaDogbm9ybWFsOyBmb250LXNpemU6IDExcHg7IGxpbmUtaGVpZ2h0OiBu b3JtYWw7IGZvbnQtZmFtaWx5OiBNZW5sbzsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImZvbnQt dmFyaWFudC1saWdhdHVyZXM6IG5vLWNvbW1vbi1saWdhdHVyZXMiIGNsYXNzPSIiPkFja2VkLWJ5 OiBDaHJpc3RpYW4gTGluZGlnICZsdDs8YSBocmVmPSJtYWlsdG86Y2hyaXN0aWFuLmxpbmRpZ0Bj aXRyaXguY29tIiBjbGFzcz0iIj5jaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb208L2E+Jmd0Ozwv c3Bhbj48L2Rpdj4NCjxkaXYgY2xhc3M9IiI+PHNwYW4gc3R5bGU9ImZvbnQtdmFyaWFudC1saWdh dHVyZXM6IG5vLWNvbW1vbi1saWdhdHVyZXMiIGNsYXNzPSIiPjxiciBjbGFzcz0iIj4NCjwvc3Bh bj48L2Rpdj4NCjwvZGl2Pg0KPGJyIGNsYXNzPSIiPg0KPC9ib2R5Pg0KPC9odG1sPg0K --_000_C6DBE745FEB94A6C8AAB8C32D0B21E27citrixcom_-- From xen-devel-bounces@lists.xenproject.org Wed Nov 09 14:07:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 14:07:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441036.695281 (Exim 4.92) (envelope-from ) id 1oslkA-0005OR-Ee; Wed, 09 Nov 2022 14:07:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441036.695281; Wed, 09 Nov 2022 14:07:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslkA-0005OK-Ba; Wed, 09 Nov 2022 14:07:54 +0000 Received: by outflank-mailman (input) for mailman id 441036; Wed, 09 Nov 2022 14:07:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oslk9-0005OE-GO for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 14:07:53 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e563645e-6037-11ed-8fd2-01056ac49cbb; Wed, 09 Nov 2022 15:07:52 +0100 (CET) Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 09:07:49 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by SJ0PR03MB6342.namprd03.prod.outlook.com (2603:10b6:a03:390::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 14:07:45 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 14:07:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e563645e-6037-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668002872; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=1h8lzpwMN164Fb52sttFjOrxYgGV3lzyi40IB7HY0HE=; b=bm28ALAtnSiKsMU1GhBZnODWm9tcFWL9Sk1O+YjG+D75k2vdZbBHJBBr TBi8YMUVaXBDTr9HSjEkPt0jVkjQiMIV6c54QjCwQWwAz6YJMzvQ0fnvk J1QL20AJ6/9adsD+jEMbKqqGMxdoAayqOnkgiHBNwxzBoDWdioupkqTWj U=; X-IronPort-RemoteIP: 104.47.59.175 X-IronPort-MID: 84494976 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:bNzzLqxUOCzfIwzV0zd6t+cJxyrEfRIJ4+MujC+fZmUNrF6WrkVUx mVKC2CHMvuLYmDwfownbom390JX7cCBzIUwGQFqpCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPaET5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KV1O2 aJFEzlcVzzZjcaSx4+0UuU9t8t2eaEHPKtH0p1h5RfwKK98BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjmVlVMsuFTuGIO9ltiiTsVPn12Ep 2vAuWD4BB0bO/SUyCaf82LqjejK9c/+cNJOSOzkp6E06LGV7jIUCxYmRQakneGopRKVAN5YI FAxoiV7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OcWSDowx xm2ltXmLTV1tfueTnf13rudsz6aIyUeKm4GIygeQmMt/N3LsIw1yBXVQb5e/LWdi9T0HXT8x m6MpS1n3bEL15dUiuO84EzNhC+qqt7RVAkp6w7LX2WjqARkeIqiYI/u4l/ehRpdELukopC6l CBss6CjAComVPlhSATlrD0xIYyU IronPort-HdrOrdr: A9a23:Ams2baGk9xcxOdj8pLqFS5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTjLJr0Unp91yy6 RNwiaQsIdWFwrJmGDn68HPTAwCrDv8nZKz+dRj8EC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBoPkoLVeLizNbFwg2PwqT+GLEXQI+llluhEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8 o= X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208";a="84494976" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MRuTPzbmZ9jy0tuAH5J01kpqE+pRGIRNeFaQSYSKrKPTIHKQsOAGob2cqyqpkJ3LohyweiZajiUPnJ5ZJRzes+7unS+l3YvHfBZpdXZdFZVtNkZOcTTb3ngLJJoDbcxF3BCSkcyOlPrDGYr0RE4RytB3+u/e4PaU6BgGHapaJ0JWbzeHZr2ZFMsi8HOQ7Y8hElV1fiL5Z7wjj6gfbGYLN1yNSBzglCbKWm9XFl9p1/uTo+cDop1NBkqaCCE6DBUCa1whPhS2DRmTd8WkEonbPbtzzP7o5mihqtJMui8c1zjkHIlQ6wCSc11ECdUnuj5WFDZXtZGTTL2uGYeLXrdHnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1h8lzpwMN164Fb52sttFjOrxYgGV3lzyi40IB7HY0HE=; b=GG49UXklXpWb44ddqVAQvDZeH/xwAnEUtQOV+h2lqkkv3YPjoMsaGO5r3SKmKmC/PXtHhYH5BJrZsaxfbgOwcDFwn02Wrxr5rR2v9EUtjOSZBw1yiihK8I4/jcEDCtYmb1q4UyrUjsK00DVsxmfUIEXxf0oUK9buBXnFetsQDaRqo8u0cXpV/3RYmTx87gAzyj1FYmyz6znUlTLjrUxavigYcXRR3jjsYLnWUlN9tbX1THu00HwLpEksWzL23xK4fJQLNffH4I36HDkvMLMs+U8HyZoyw0p7I8vCU8BZ1NqxkDMt+Jn9/yguO8PbjursER/coNiTlUxc2QFAogdptA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1h8lzpwMN164Fb52sttFjOrxYgGV3lzyi40IB7HY0HE=; b=MnRQ9wE0tu1Fg9BiGRZNUj3NwIqwPeVQVe1tMI1/y12YuxtX7BNHRRjT08KT4kvjVVZPyQmjgzQGgxNPnDKO8QhyrHbfh7CAo98iI9JqtR6Fop5euKv9GAKLMWk+Fo3Bq7cZk59MNdTrofe+yfFVx5xSUUCbvVQjSD3TzobY/Xo= From: Christian Lindig To: Edwin Torok CC: Xen-devel , Henry Wang , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 13/15] tools/ocaml/xenstored: set uncaught exception handler Thread-Topic: [PATCH for-4.17 v3 13/15] tools/ocaml/xenstored: set uncaught exception handler Thread-Index: AQHY84hRz9ZwhCZsU0y+SHd5jJpHJq42ojKA Date: Wed, 9 Nov 2022 14:07:45 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|SJ0PR03MB6342:EE_ x-ms-office365-filtering-correlation-id: 6b22b8f5-da58-4bf4-b25a-08dac25bc6b5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W078qkxDmZrYKOxDXtdhC9NmetQcoCcm9Sn6KcqDUSwkcAx35MYpQbMp4+znNRezAFHINT61HzDIs1H2WQMthRH/+DJGszWu6poN8sc0ds34QR5lAZxD4ZWU3PH1bXAC/XDDQxHvLOqhSovpxMocP6Io5csksU4LSUN0RsaRu7nVU/GNhUhJfc5RD2YHgWUXexgUvgEl/apVp58zvxfZstdTsXxhgfFvRhszfG0/rGYXErDhrahWMfQshuLE17mGc0qEKIGYim5ECIv60VGsptSacc/OOLMsu+gyH9CPIFtmWFgnp8vaHL2pZlJ6u7qTJ1eo0keJ9/X6uuzUuk520vdii5n9W/35/fpalze+IWaDSlP5m7L1ACtEAbXoYQXBZ7j3hhzVWVi7alJ8jfKqQmGFtqrlUB8AwinmCraSJJpbYF2cMK3QG+xGk/Twiez4vkxpC9IoO3DB9UIizpgMVJGGeYiF1waMlA7rpYM7Jb9xBsrRro23EGlxa0B66HeuHoKsJ1RPXQ2AEETKF97r1471igqRgo20r++2WBUoxGkGNTAgYdTOaQ0vWF7Gy51eU5HyiFjHjVQhRhRX4wfWkHSdvovMuxFk9imsEip12mr9L0gMHsmAH64BNtRpviL17fyp3TrEci8GH0fYFhyQVVs6v9sKk067yxxaarAJuneu0akYqSiKOH796+tGHDismX0eXXmcyYzQDqd0YdQLfX99ROcPzkoOdjqPEVg9nT1fnLBZJfzLX7/hpDjof5ORQ4tTN+GpgGSkMWx2awx2bqqXTqqB4+PR4UpumkdjNeY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(366004)(346002)(451199015)(36756003)(38100700002)(122000001)(33656002)(86362001)(478600001)(82960400001)(6486002)(38070700005)(83380400001)(44832011)(2906002)(66574015)(186003)(26005)(4744005)(6506007)(66556008)(91956017)(66446008)(66476007)(107886003)(8936002)(5660300002)(6862004)(64756008)(66946007)(71200400001)(76116006)(2616005)(6512007)(53546011)(4326008)(8676002)(37006003)(41300700001)(54906003)(6636002)(316002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?V0VyejhkWUZaWGxsbTFxb3drNGl3ZFY4eGxOemFSNnI3WkZhN1hwU0YrVnpt?= =?utf-8?B?aVNJcmVlUnd3MlFSWitjT3VLMUZYbUlhVmtEdDVldTlWdHdnSkZvVGJFNFhp?= =?utf-8?B?d0duRnhBQzdKWFRJMlJzWmFTVi96OVZnZFp3NTBkaXBsV3NRRFNHVXplUFJr?= =?utf-8?B?ZHZYMzN6U25SRm1LOHUyajJvdmVLS1cvSnE4TVpXeGhkQzNMNTlYMWFOY1ZY?= =?utf-8?B?V2VqWjczVXBlV1F0OGlQM1htQVR0TUZvRndWbWxQNGdlcXlldFV1ZXp1Sy85?= =?utf-8?B?U0xhUnErQ1RaSGNtcEZydU1MZC9uTjZxS1hlMG1lL0dqRXlzTFBibm55a1p2?= =?utf-8?B?MkVhNjNPL3NmOVQ0c1M4Q3B0OWVIeGxvUTN5aVp6R253ai9DeEJTREhDS3Zo?= =?utf-8?B?WnF0NjRwSFZiR1g1bHByVDNqUmlId0szZ2JBRG10M2lhWmM5QzR1VW9lbHor?= =?utf-8?B?OVI5SGFqNGhVUVdkZ3ptWjI4b0l5a0NDV3ozZENIakEvWHdaaURUdk5mcVZY?= =?utf-8?B?Qm5MTEszWXRBbk5oTlBoK3hBbVNOdUd0aU5kUmtrZ3NJblQyblZlbi9kSWZN?= =?utf-8?B?UWVlaWtXQzFVQmZwZVBIK0w0cmtoZGRrZEVCWU1wL3E4RE1MRHltNXNoSGFF?= =?utf-8?B?SmVDNlBvRXhIQVFGdldYNGMzN2JGb2FZazZOSlF3L3pBL21IVk1IbXZpUlZC?= =?utf-8?B?ZUpxVVdBTHQ4R1psRGxpUE9QOGUyNndHOFhtLzI2ZGRTc1ZHckY0ZWJrcmQ0?= =?utf-8?B?eUVBZXJ4clMxQlJpT0xDN0lnaFliZ3pOeWRDSUpuU1RqdmxQQ1ozWDJ1Sy9M?= =?utf-8?B?c2lLQ2ZGVytYOWh5WTBocXlmSUVjOHRWV0JIWW9mVEgzUG9CcUMvamtxcWpp?= =?utf-8?B?NTBpKzErenUra2s0bGlMOVhjTUpia2NyMG9IMXQvVnoyQkxSUmY5UjZWR09G?= =?utf-8?B?RDFPYmU1WFMwT0lacVJ0MytUUFRpRXp1VUszZC9oTXQyejRIUmtJM0JWUmU2?= =?utf-8?B?eUNMQ3greVNsRHNRME83cEVKN2FMUVVSSWpid0JTQ3JPRUtCbTNJaVR4U09r?= =?utf-8?B?R0dieFl2V0YwdFdFbVNKQUlETUlFdTd2c3JDa3lhcjI2WURHQWsyM1JBTk5F?= =?utf-8?B?VmJmSUFjbE1TcUpIcElEUHM1eTZicVdRb0NIZkpJeVZITDdmSGxLdDJVcEJk?= =?utf-8?B?YTh0aStPSGt2VzVSME1EVi9lYWROM1pxWUNmWiticWtrQzBmNmZ5ZGJMUzc3?= =?utf-8?B?MzZ2L0FNcE1JdG9aV25ESVE1VTV1WXZUUGdmcDZtT050dXpucFlYV0ZJWmNm?= =?utf-8?B?UzVabENLSGVwZFREK1pGQmRKTHhhRG02YXNLdVFZdnFjenhPQzFTODdIUGVm?= =?utf-8?B?ZG9kMENmK281dlhKQ3NDR0JIUE5iUUp1VURrV0dLcFZwSW9TR3JRL2QyZVhU?= =?utf-8?B?elNwYzRZTE53NUQ4VUdGcXZaRXF4aG9lc3FKMmRkNkxDNStTU3JIOW55ZEJ2?= =?utf-8?B?WVZKMlBlMTNsTXJCK1M5T1ZCdWRxbGtGckJZcm5VcGpWVDRZZFYxdWVyS3Zo?= =?utf-8?B?RHVrMGRoMmN5dFlJT2N6VWpOcXRnV1RDRlU4bXdlV3A5RjlTZ1pwdXYvOVND?= =?utf-8?B?Vk1sMEQwdWozYXV1VnUxTmxpZndSdkRxZ0N6akZPbEFOVVVOOFBQbEFQaDFO?= =?utf-8?B?Z1NnYVpxR2FyMmo4Zk0yS084WTlwMS9Dejgxd0RWU29hY0FmQ05SdTQ4ZnE2?= =?utf-8?B?MDVmVERWN05vTHZtdlN5T3N4ZldXY0xQUHRpekROM21rNUViZVhwNnBLSENh?= =?utf-8?B?TEQ2d0tBRmxVa2NaOGptbWlHMmhFb28vSFhYVEJIdkJFd25NWWQ0ZnhCWWVl?= =?utf-8?B?OHJ4aWg1Y0NXYiswVEdDaEY5NHBGb0VRUzhCSWdwbHVxMDFGa2xjcEI3aTFp?= =?utf-8?B?MW9aQkpyNm9JTVk5UGsrelpBSFkyU2dOVEpyYWZtT0xvMTZuVjkzSlkxZnQv?= =?utf-8?B?K0tFVy9tZVkyb3ViS1RZelBrLzhNUXRMTk10K2FVR3lkbzhVTXhPRjhCT2Z1?= =?utf-8?B?bm1nSzJzd0lhM1R2RmtaOUh0bE10N0IwaWNSVnVRZzh2bXZzZ2JBRWlhUlc3?= =?utf-8?B?MWpRSHRkOHgyODZwa1E1SWgzaXVRMEhyMkM2Z09TM1VOZkRhWGFmdGtrS004?= =?utf-8?Q?OkPZrY8uIICbdfu78QD073Q=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <1CA299ECF8BD98408E7FA8CD918FA70F@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b22b8f5-da58-4bf4-b25a-08dac25bc6b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 14:07:45.7799 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /b5aIkoOsPjjbrn6lzYrQ1DNmHGg/+XYCDZq5M2Tsf9ksWZQUmf4voZlQQkZecX6c9iKydHxwxmT2ZnNaZc5WYUNrvDvPlWIDPWe0in2Qek= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6342 DQoNCj4gT24gOCBOb3YgMjAyMiwgYXQgMTU6MzQsIEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9r QGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gSGVscHMgZGVidWcgZmF0YWwgZXJyb3JzIGR1cmlu ZyBsaXZlIHVwZGF0ZQ0KPiANCj4gUHJldmlvdXNseSB0aGlzIHdvdWxkJ3ZlIGp1c3QgZ29uZSB0 byAvZGV2L251bGwsIGJlY2F1c2U6DQo+ICogZGFlbW9uaXplIHJlb3BlbnMgc3RkZXJyIGFzIC9k ZXYvbnVsbA0KPiAqIHN5c3RlbWQgcmVkaXJlY3RzIHN0ZGVyciB0byAvZGV2L251bGwgdG9vDQo+ IA0KPiBQcmV2aW91c2x5IHRoZSBvbmx5IHdheSB0byBkZWJ1ZyB0aGlzIHdhcyB0byBtYW51YWxs eSBydW4gb3hlbnN0b3JlZCB3aXRoDQo+IC0tbm8tZm9yaywgYnV0IHdoZW4geW91IGhhdmUgYSBm YXRhbCBlcnJvciBhbmQgb3hlbnN0b3JlZCBqdXN0DQo+IGRpc2FwcGVhcnMgeW91J2Qgd2FudCB0 byBrbm93IHdoeS4NCj4gVGhlcmUgaGFzIGJlZW4gYXQgbGVhc3Qgb25lIG9ic2VydmVkIGluc3Rh bmNlIG9mIGEgYnVnIHdoZXJlIG94ZW5zdG9yZWQNCj4ganVzdCBkaXNhcHBlYXJlZCBpbmV4cGxp Y2FibHkgKGl0IHdhcyBiZWxpZXZlZCBkdWUgdG8gYW4gT09NIGV4Y2VwdGlvbikuDQo+IA0KPiBT aWduZWQtb2ZmLWJ5OiBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jva0BjaXRyaXguY29tPg0KPiAt LS0NCj4gUmVhc29uIGZvciBpbmNsdXNpb24gaW4gNC4xNzoNCj4gLSBhdm9pZHMgbG9zaW5nIGNy dWNpYWwgaW5mb3JtYXRpb24gZHVyaW5nIGEgZmF0YWwgZXJyb3IgKGUuZy4gZHVyaW5nDQo+ICBs aXZlIHVwZGF0ZSkNCg0KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5k aWdAY2l0cml4LmNvbT4NCg0KPiArbGV0IHByaW50X2ZsdXNoIG1zZyA9DQo+ICsgIHByZXJyX2Vu ZGxpbmUgbXNnOw0KPiArICBmbHVzaCBzdGRlcnINCg0KVGhlIGZsdXNoIGlzIG5vdCByZXF1aXJl ZCBiZWNhdXNlIHByZXJyX2VuZGxpbmUgZG9lcyBpdCBpbXBsaWNpdGx5Lg0KDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 09 14:09:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 14:09:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441041.695292 (Exim 4.92) (envelope-from ) id 1osllD-0005wZ-PD; Wed, 09 Nov 2022 14:08:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441041.695292; Wed, 09 Nov 2022 14:08:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osllD-0005wS-M1; Wed, 09 Nov 2022 14:08:59 +0000 Received: by outflank-mailman (input) for mailman id 441041; Wed, 09 Nov 2022 14:08:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osllC-0005rL-1v for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 14:08:58 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0bd38d78-6038-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 15:08:56 +0100 (CET) Received: from mail-mw2nam12lp2045.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 09:08:43 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by SJ0PR03MB6342.namprd03.prod.outlook.com (2603:10b6:a03:390::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 14:08:38 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 14:08:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bd38d78-6038-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668002936; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=D+1SJ/LS3q3ZNh2nTusBVG7/wuQd6qdFq2Yr7cWM90U=; b=A66MhZVfbzs5Dyi4x2gNzoI/7cFbU7YZzARbgy32VQOyFEIMzpo0MC/T 7JrYnqnzqKGJ6cX/lOLFYfCinF0Dp4ngGLrKNPA/wsGAVUEfp0cVzF05a QnSQCboIOo01XBfbhLiJ77SSqAX1wmYuUrh3Gp+hXpe+SN7/+DSYvjQ+j 0=; X-IronPort-RemoteIP: 104.47.66.45 X-IronPort-MID: 83551206 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:cBtFs60uVhJQIPBu+/bD5exwkn2cJEfYwER7XKvMYLTBsI5bp2cHx mQZXD/UPq2KMDb1Ldl+YYSx9EgAsZfWmtZjHQI9pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVmNKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfJjhE1 eEKKjM2ZxGFo9+HwZyqE8IzmZF2RCXrFNt3VnBI6xj8VKxjZK+ZBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxpvS6PkWSd05C0WDbRUteKX8ROgkeRo CTC/mL1Ax4yP92D0zuVtHmrg4cjmAurA99PTefgqJaGhnWDxDI/DAwICGG0uNv+sUCSUO5NB A89r39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOlMIwXy1s6 VaPkPvgHzkpu7qQIVqR/6mZhSm/Mi8UKSkFfyBsZRQBy8nupsc0lB2nczp4OKu8j9mwHC6qx TmP9XI6n+9L0ZNN0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLlm4U2l/MBVfNgwIQ== IronPort-HdrOrdr: A9a23:BDMUyqAgj5KKKAXlHegasceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEDyewKnyXcV2/haAV7GZmXbUQSTXeZfBOfZogEIXheOjtK1tp 0QPpSWaueAa2SS5PySiGbXLz9j+qj/zEnCv5a9854Zd3APV0gW1XYdNu/0KC1LbTgDIaB8OI uX58JBqTblU28QdN6HCn4MWPWGj8HXlbr9CCR2SCIP2U2rt3eF+bT6Gx+X0lM1SDVU24ov9m DDjkjQ+rijifem0RXRvlWjoai+2eGRi+erNvb8yfT9GQ+cyDpAo74RHoFqiQpF4N1HLmxa1O Uk7S1QePiboEmhA11d6SGdpzUIlgxep0MKgGXo/0fLsIj3Qik3BNFGgp8cehzF61A4tNU5y6 5T2XmF3qAnRC8pDEzGlqf1vjxR5z2JSEAZ4Jgupm0aVZFbZK5arIQZ8k8QGJAcHDji4IRiFO V1FsnT6PtfbFvfNhnizyJS6c3pWm52EgaNQ0AEtMDQ2z9KnGphx09dwMAEhH8P+J80VpEB7e XZNaZjkq1IU6YtHOpALfZERdHyBn3GQBrKPm7XKVP7FLsfM3aIsJLz6KVd3pDfRHXJ9upGpH 3saiIqiYdpQTOeNSSn5uw6zjndBGOgQD/q1sZSo5Bkp7yUfsuYDRG+ X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208,217";a="83551206" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AmMYVqueOcWHHWktdgFgsISVEVGpaemuggWGESM6qpwUPfw4xvL8KCYfR4hU8+hjkkP849w89PAw3u1//achKOaR55838Orz02bJ0Ak7mIHRpp8AcnGNbylzHcbHR2Jb2uUnB5oK78LY09YcvW2M4uE3iLxPuwigj2sHM0HXCQDnbS3TuCwUum7kCBB+W3tOkOHQNOjRkpgrwJluiTgcT6+bUswqOWls/IF4qlYkp4X3MCb2uiI2xWRdrrZA04IQn3OYfpJflWAleDo5bIRQPUo6hzgjMPaHA3XGhCcJ0nGlxAkttDjIpspXEdAQflHQSWPN4M2j4iyuO01ZbVDy8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D+1SJ/LS3q3ZNh2nTusBVG7/wuQd6qdFq2Yr7cWM90U=; b=i+xqWIrDCGsvANkjv/k6mavb523aPNxQMfEalo+gHSeKPXitiZjuRCVjRN2yNY84nTYDOXisAWn/UHjvTiAEAlTYis2hwlm5vyZuVHiUAmGWoGIunp49IpMEwcqCZch3VVDIMVewXOq2i8x2dX0VBzdC1ywC/ax5VMBBG5qZvCKzOfMpJrAu8snPehDuIe99SOB4Q2xmDR20LPC+w+totV2QVnkB/QPbBiQC+rgk2ez6FGgjFf43+gSIAZel2MvugLCp/Apo2hHbkRoRzaSqsXlwU2sczPWBs96qgzuUDj+vwctUfqC/FAlbRl/kXcXUoYjHNKeuQxQjSuWLeYHuYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D+1SJ/LS3q3ZNh2nTusBVG7/wuQd6qdFq2Yr7cWM90U=; b=byxKmkLIAxgTTKor037j/bw5PkyfGay5vlL/hT0D8Xg1q2vK1bglwDr+1ojjsOS9XL7H1mzw9z3TffEKAPCBk9s15AKYPZj5dCZOI1MDpkQMszVRdViEpU0lRjifbgYIjgdxIKpwCmToJATePZppXD3dbv+CIC1TiNdnnE9jlUk= From: Christian Lindig To: Edwin Torok CC: Xen-devel , Henry Wang , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 14/15] tools/ocaml/xenstored/syslog_stubs.c: avoid potential NULL dereference Thread-Topic: [PATCH for-4.17 v3 14/15] tools/ocaml/xenstored/syslog_stubs.c: avoid potential NULL dereference Thread-Index: AQHY84hV+zekFcwy5E+YRPoUo8Fj+K42onCA Date: Wed, 9 Nov 2022 14:08:38 +0000 Message-ID: <2D872B65-A9CB-4EBB-98CB-3B0001FA235E@citrix.com> References: <5da5b63bd6a0f8d0f6ad0281773eefb32de8164d.1667920496.git.edvin.torok@citrix.com> In-Reply-To: <5da5b63bd6a0f8d0f6ad0281773eefb32de8164d.1667920496.git.edvin.torok@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|SJ0PR03MB6342:EE_ x-ms-office365-filtering-correlation-id: dd765256-dcb4-40cd-2429-08dac25be613 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W3NSQrUu6XNDyPBe/sAF9dETBhM1E3S4/stLW9yABmrDHsKPuoG8yefWezd7q35CfBt2b5otyR3eTfJEmeRfIuMCH6I+bZ3uyfpSQpSbk62JvRDuxF1T8VQZFRoTaDrWPW59SnIXZllXp/u+oT7ABWQ3uLr/ZwwT2IATCeoDFLQXpHmhsDOkGuJ1EodOaoOaDH0MnL8C7wqqWYOSjsi0zRvKHw3fHdW0oJTNXLS6lzVtSxvwLNLTzjIt9MC9qJXfUu4/dI5JxRgwKhyDB7VDREpkWOWmNmHmeZqkgco7B3tO5jeqv/eahR2rq4cz1Q3L27jr55G9flUIYaKAskYnbiUzFkhRR0sQ1U23xffNQbsGhx61LYLk6BNJTXbHXNvMO1zyiyxL+EYVFT6cEeMTsKvrWt0/YQt6rPsYGis/vG6dDGtHULN0BL6+k+Kl9tTFmgs8M40qPCUQdh/WL45ZZvs+aWjqgts+yn+n//tG2VjlvF5k2Cj82RmxHo8y9MmOpp4EeRJuHOzB3Gap3uZdFsyHx4JRKGC78g4QRlNVocPQ+kLsCCBm0ir6yKrcDG8CRHf4/NcM9JFU6ZkdkFRr5d/1qub3eW4iynOmzFME+oSRskCSSg12ywTjXaSBej+LEfKtJORPfydOJ2rD/yEY1hJx4khgsu/Y2MN7c29K4SbV03hD/TkD+5t/RIOOChc/KMJf2rHJm7FZHvtIsMX9weUFLRxfbB48oRd20H7MOTCwZxIe8nGSlMNSDSQQh3ugNIUF6ncVw2LHglrD3hezUfq5VD0jVMS79Y1N6r+AEJA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(366004)(346002)(451199015)(36756003)(38100700002)(122000001)(33656002)(86362001)(478600001)(82960400001)(6486002)(38070700005)(83380400001)(44832011)(2906002)(186003)(26005)(4744005)(6506007)(66556008)(91956017)(66446008)(66476007)(107886003)(8936002)(5660300002)(6862004)(64756008)(66946007)(71200400001)(76116006)(2616005)(6512007)(53546011)(4326008)(8676002)(37006003)(41300700001)(54906003)(6636002)(316002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cXhoYTI4YTIyL2FqUUJKYU10QmNsOWRlTlpwZm5NOGprb1JwdjFMM2JwYlZo?= =?utf-8?B?cGZ5RUc0VlR3L3JCY0Q0cjc5MnZVQjFuTWpiQnZLU29McW1RemxsbWRoV215?= =?utf-8?B?ZkpndkRYdDlhY2VBUHZSeWtQSHhmMUIzMEk0RHVxcUt0S3VmQ3JGTlpDN0NI?= =?utf-8?B?VDZoTWJYcXNWMTdBMGR3NkpldkU2YUFoOG50QVdTRUpWMEV6dEE2VHlhRkdq?= =?utf-8?B?L3JuQXpsd2FrWjJseFZPQlN0Uk9EOUFjVk1HTnBmdFM0QUg3NkVBbksraFl6?= =?utf-8?B?UWpzeDdFQytLNU5OclhNSi9LQVVlR1dZRW5Sb25hNXJuQUNVckYzWDlxZnYr?= =?utf-8?B?dkF4c213SHpIbHE4bFV2NVU1bmh6Sy9ZaDZSU05ENExiTktaeWVDYVhPek1B?= =?utf-8?B?V2FZeXRsVzQ0aW05SEZ4cm9KanEwLzQ2cjNYZXhpWERGNUlSVjlMVVk4cW5i?= =?utf-8?B?Y2Y1M0RDbkV6SlJpM1lkRXVuZVpXRE5pekFaV1RsaUdHdEU2QWVDYlBiZ2JF?= =?utf-8?B?OFpGcUFacnZVcXF2eVZCMldLM24xcmN1OVhXcG1HSi8vTWVPY1JpRTlQeCtZ?= =?utf-8?B?eUw1ZEdJTHEzV0Y2VmRuL0xxM2hFdUt4bWg1Y20xYUhjZTh5emNWNytxUHll?= =?utf-8?B?V05aVG9CakM5TWF1djlLRFJVMXFuNmlzRWtGSXV0MDc1TTJ1d1hERm5XZ25z?= =?utf-8?B?VlBkS0ZXanpJUVU2ak90czBzTDV5bi9ZOTJaTnJSTmVlclgvOVVYTjJOcU9I?= =?utf-8?B?YzZSc3FYaGR3cmtuN2ZMK21WT0pwdDFqYmFsSnBNOW9TSnd3TmRRSTJXQVg1?= =?utf-8?B?T1V1bmV0MkdudHZoSXFkM3VoL1Zqd0owbEpvRm1HbkpMZEUxR3ZkTWpISHE1?= =?utf-8?B?bm5OeHZDaTJhOWJ4TXdwNkh0Ti9KemNybm03TisvSHMvZjFyZ0lxMkVwdDdm?= =?utf-8?B?cWdUbm15Y3lsNGJXcDFYSW9GYUd3M1FPVDZSelNTMUtUOXBiVWRRN1V1L3pB?= =?utf-8?B?bzBBY1g3ZEFjREU0dG5TRUhKdDhXdlIzRytzWktsWXJMUXV3Z0YzdzJjTFNM?= =?utf-8?B?SnRvNDRZdEI5RXR2U1BLVHdkT3FuV1prZkhlaHd4ZG5TalVWWFpFTXpXbTRj?= =?utf-8?B?NmEyY3Q3WjVUQlNydDNYaEVlcWphNlhXS05KaGhXWTdXSnRablpJc2M1Rmdm?= =?utf-8?B?dTNNQUlrNG95L1pQTk1GZXFOZmlzYS90V0tFZzNDYUJCU3puTFQ5eDhhWUtv?= =?utf-8?B?bHdtdStZL2ZaV0VTUDM3dXNJalZIOHBobzV0WkprOXRoVEU4MG04S1pKMUdS?= =?utf-8?B?Y0diK01aTTZyVlNrRUx3cjVkOWw1QVh1OXovRFJFTTRDQlZpWXF4OUJTTlBu?= =?utf-8?B?VHd4dTFNN2ROQ2lCbkVoU2doQWpFckl2UWEvby81eGdKbGJnNU1NcEY3WU1F?= =?utf-8?B?d2QrUDMwdjNWaVNidWxCdlltckE2SG5WaFpCaVlhVWpBNG1MQnZ5T0lXbXFW?= =?utf-8?B?d3BET3BQRkplZ3MwNUxiMTFoVHlCWFFMQldpdENsQVFVQnVrZnJWRlArbTVJ?= =?utf-8?B?WUtsaC9JbDlGelVVOXUzUXVqNXF3WjN4a21DMGFkdDdHbmJRNGFRd01RcUd5?= =?utf-8?B?cDcvZTNDNUlFdHlkbERWSG9NMG1NREZ6cG1aWHd4ajhkODFxc3V5UDQzeXMx?= =?utf-8?B?UnQxSTRGdVpFVmNDK0dtK3NiU1ltemw2ZGMrbHhrL1pud0VYdGhPSmc1NVIx?= =?utf-8?B?QStuZEdKSTcrRFZ0OFlkeHIvWWViK0ZreHIxekFjVzlYZDNsQ1I4eXQxYWlm?= =?utf-8?B?U293cTBtSklpNklGTkNqVTY3YjhCaGtvbXJjcEtaVDVub2h3VWo5UUJONE1L?= =?utf-8?B?cjF3TEtjK3k5TTFodUdOdW5JYXgyYkhqUXB1bkJXeFBEZTFSM0Exc0FtbTFo?= =?utf-8?B?b1hlZVNHUlNmYlA4ekJIU0J1UUNEYjhXMGtVbjlmd2tPUWlpbC93Y1dqKzQx?= =?utf-8?B?UmFwUUx3NUlKL3NHUXF4dEE3M2pHZnVQM2trbDc2RzRTcjEzeWxOZ1hmSjFt?= =?utf-8?B?NHJFQTcxaDRjTUxLdEVRdzExT1R2NW43MTNWcDVpVGpHS2o5UjRpR2dhLzNh?= =?utf-8?B?S2hMRHNIUWdiaHRpdXRzY1JUZUNabkJBZmtjcG1tRTlTT2c3U0F3MVY0d3Nm?= =?utf-8?Q?sAAGROjbGjOPlwsCYu4PV1I=3D?= Content-Type: multipart/alternative; boundary="_000_2D872B65A9CB4EBB98CB3B0001FA235Ecitrixcom_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd765256-dcb4-40cd-2429-08dac25be613 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 14:08:38.4016 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g++GZVI1GtCYDPjbCGOTWfGkPthIR/gEt0WRjNtnXaOdMNzRzJPSfC73mAv0hR7q+IfDJ8pywU98K5aJWctZt0Bs+vtFI117i9KZ7vXbTrU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6342 --_000_2D872B65A9CB4EBB98CB3B0001FA235Ecitrixcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DQoNCk9uIDggTm92IDIwMjIsIGF0IDE1OjM0LCBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jva0Bj aXRyaXguY29tPG1haWx0bzplZHZpbi50b3Jva0BjaXRyaXguY29tPj4gd3JvdGU6DQoNCklmIHdl IGFyZSBvdXQgb2YgbWVtb3J5IHRoZW4gc3RyZHVwIG1heSByZXR1cm4gTlVMTCwgYW5kIHBhc3Np bmcgTlVMTCB0bw0Kc3lzbG9nIG1heSBjYXVzZSBhIGNyYXNoLg0KDQpBdm9pZCB0aGlzIGJ5IHVz aW5nIGBjYW1sX3N0YXRfc3RyZHVwYCB3aGljaCB3aWxsIHJhaXNlIGFuIE9DYW1sIG91dCBvZg0K bWVtb3J5IGV4Y2VwdGlvbiBpbnN0ZWFkLg0KVGhpcyB0aGVuIG5lZWRzIHRvIGJlIHBhaXJlZCB3 aXRoIGNhbWxfc3RhdF9mcmVlLg0KDQpTaWduZWQtb2ZmLWJ5OiBFZHdpbiBUw7Zyw7ZrIDxlZHZp bi50b3Jva0BjaXRyaXguY29tPG1haWx0bzplZHZpbi50b3Jva0BjaXRyaXguY29tPj4NCi0tLQ0K UmVhc29uIGZvciBpbmNsdXNpb24gaW4gNC4xNzoNCi0gZml4ZXMgYSBidWcgaW4gb3V0IG9mIG1l bW9yeSBzaXR1YXRpb25zDQoNCkNoYW5nZXMgc2luY2UgdjI6DQotIG5ldyBpbiB2Mw0KLS0tDQp0 b29scy9vY2FtbC94ZW5zdG9yZWQvc3lzbG9nX3N0dWJzLmMgfCA3ICsrKysrLS0NCjEgZmlsZSBj aGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQoNCkFja2VkLWJ5OiBDaHJp c3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb208bWFpbHRvOmNocmlzdGlh bi5saW5kaWdAY2l0cml4LmNvbT4+DQoNCg== --_000_2D872B65A9CB4EBB98CB3B0001FA235Ecitrixcom_ Content-Type: text/html; charset="utf-8" Content-ID: <7E3CA038B8B0324CB335C856A86483D2@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJ3b3JkLXdy YXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZTsgbGluZS1icmVhazogYWZ0 ZXItd2hpdGUtc3BhY2U7IiBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NCjxkaXY+PGJyIGNsYXNz PSIiPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2xhc3M9IiI+DQo8ZGl2IGNsYXNzPSIiPk9u IDggTm92IDIwMjIsIGF0IDE1OjM0LCBFZHdpbiBUw7Zyw7ZrICZsdDs8YSBocmVmPSJtYWlsdG86 ZWR2aW4udG9yb2tAY2l0cml4LmNvbSIgY2xhc3M9IiI+ZWR2aW4udG9yb2tAY2l0cml4LmNvbTwv YT4mZ3Q7IHdyb3RlOjwvZGl2Pg0KPGJyIGNsYXNzPSJBcHBsZS1pbnRlcmNoYW5nZS1uZXdsaW5l Ij4NCjxkaXYgY2xhc3M9IiI+PHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7 IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6 IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0 dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7 IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6 IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5v bmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPklm DQogd2UgYXJlIG91dCBvZiBtZW1vcnkgdGhlbiBzdHJkdXAgbWF5IHJldHVybiBOVUxMLCBhbmQg cGFzc2luZyBOVUxMIHRvPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAw KTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHls ZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBs ZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBw eDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2lu ZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjog bm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7 IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6 IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0 dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7 IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6 IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5v bmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPnN5 c2xvZw0KIG1heSBjYXVzZSBhIGNyYXNoLjwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiBy Z2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7 IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWln aHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQt aW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3 b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRl Y29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigw LCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9u dC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDog NDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRl bnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQt c3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3Jh dGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwg MCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQt c3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQw MDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50 OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNw YWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRp b246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNz PSIiPkF2b2lkDQogdGhpcyBieSB1c2luZyBgY2FtbF9zdGF0X3N0cmR1cGAgd2hpY2ggd2lsbCBy YWlzZSBhbiBPQ2FtbCBvdXQgb2Y8L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAs IDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250 LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0 MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVu dDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1z cGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0 aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAw LCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1z dHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAw OyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6 IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3Bh Y2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlv bjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9 IiI+bWVtb3J5DQogZXhjZXB0aW9uIGluc3RlYWQuPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29s b3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTog MTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250 LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsg dGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3Jt YWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRl eHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9y OiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDEx cHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13 ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRl eHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFs OyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0 LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFu dDsiIGNsYXNzPSIiPlRoaXMNCiB0aGVuIG5lZWRzIHRvIGJlIHBhaXJlZCB3aXRoIGNhbWxfc3Rh dF9mcmVlLjwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQt ZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1h bDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNw YWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQt dHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsg LXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBj bGFzcz0iIj4NCjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1p bHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBm b250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2lu Zzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFu c2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Vi a2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNz PSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5 OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9u dC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6 IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNm b3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtp dC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBu b25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPlNpZ25lZC1vZmYtYnk6 DQogRWR3aW4gVMO2csO2ayAmbHQ7PC9zcGFuPjxhIGhyZWY9Im1haWx0bzplZHZpbi50b3Jva0Bj aXRyaXguY29tIiBzdHlsZT0iZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTog MTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250 LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyBvcnBoYW5zOiBhdXRvOyB0ZXh0 LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdo aXRlLXNwYWNlOiBub3JtYWw7IHdpZG93czogYXV0bzsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJr aXQtdGV4dC1zaXplLWFkanVzdDogYXV0bzsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4 OyIgY2xhc3M9IiI+ZWR2aW4udG9yb2tAY2l0cml4LmNvbTwvYT48c3BhbiBzdHlsZT0iY2FyZXQt Y29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6 ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBm b250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFy dDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBu b3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7 IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1w b3J0YW50OyIgY2xhc3M9IiI+Jmd0Ozwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2Io MCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZv bnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6 IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5k ZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3Jk LXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29y YXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAs IDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250 LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0 MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVu dDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1z cGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0 aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFz cz0iIj4tLS08L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250 LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3Jt YWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1z cGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0 LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7 IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIg Y2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1m YW1pbHk6IE1lbmxvLVJlZ3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFs OyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3Bh Y2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10 cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAt d2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxv YXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZSAhaW1wb3J0YW50OyIgY2xhc3M9IiI+UmVhc29uDQog Zm9yIGluY2x1c2lvbiBpbiA0LjE3Ojwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2Io MCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZv bnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6 IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5k ZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3Jk LXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29y YXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAs IDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250 LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0 MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVu dDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1z cGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0 aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFz cz0iIj4tDQogZml4ZXMgYSBidWcgaW4gb3V0IG9mIG1lbW9yeSBzaXR1YXRpb25zPC9zcGFuPjxi ciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJl Z3VsYXI7IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQt Y2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0 ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7 IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ry b2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPGJyIHN0 eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxh cjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBz OiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQt YWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hp dGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Ut d2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHls ZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7 IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczog bm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFs aWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRl LXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdp ZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlu bGluZSAhaW1wb3J0YW50OyIgY2xhc3M9IiI+Q2hhbmdlcw0KIHNpbmNlIHYyOjwvc3Bhbj48YnIg c3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1 bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNh cHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4 dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3 aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9r ZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0 eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxh cjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBz OiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQt YWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hp dGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Ut d2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTog aW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj4tDQogbmV3IGluIHYzPC9zcGFuPjxiciBzdHls ZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6IE1lbmxvLVJlZ3VsYXI7 IGZvbnQtc2l6ZTogMTFweDsgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczog bm9ybWFsOyBmb250LXdlaWdodDogNDAwOyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFs aWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRl LXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdp ZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9 ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBm b250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5v cm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGln bjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1z cGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0 aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxp bmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPi0tLTwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9y OiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDEx cHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13 ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRl eHQtaW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFs OyB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0 LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjog cmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4 OyBmb250LXN0eWxlOiBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2Vp Z2h0OiA0MDA7IGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0 LWluZGVudDogMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsg d29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1k ZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7 IiBjbGFzcz0iIj50b29scy9vY2FtbC94ZW5zdG9yZWQvc3lzbG9nX3N0dWJzLmMNCiB8IDcgKysr KystLTwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFt aWx5OiBNZW5sby1SZWd1bGFyOyBmb250LXNpemU6IDExcHg7IGZvbnQtc3R5bGU6IG5vcm1hbDsg Zm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNp bmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQtdHJh bnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6IDBweDsgLXdl YmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFz cz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWls eTogTWVubG8tUmVndWxhcjsgZm9udC1zaXplOiAxMXB4OyBmb250LXN0eWxlOiBub3JtYWw7IGZv bnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7IGxldHRlci1zcGFjaW5n OiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDogMHB4OyB0ZXh0LXRyYW5z Zm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJr aXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDog bm9uZTsgZGlzcGxheTogaW5saW5lICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj4xDQogZmlsZSBjaGFu Z2VkLCA1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pPC9zcGFuPjwvZGl2Pg0KPC9ibG9j a3F1b3RlPg0KPC9kaXY+DQo8YnIgY2xhc3M9IiI+DQo8ZGl2IGNsYXNzPSIiPg0KPGRpdiBzdHls ZT0ibWFyZ2luOiAwcHg7IGZvbnQtc3RyZXRjaDogbm9ybWFsOyBmb250LXNpemU6IDExcHg7IGxp bmUtaGVpZ2h0OiBub3JtYWw7IGZvbnQtZmFtaWx5OiBNZW5sbzsiIGNsYXNzPSIiPg0KPHNwYW4g c3R5bGU9ImZvbnQtdmFyaWFudC1saWdhdHVyZXM6IG5vLWNvbW1vbi1saWdhdHVyZXMiIGNsYXNz PSIiPkFja2VkLWJ5OiBDaHJpc3RpYW4gTGluZGlnICZsdDs8YSBocmVmPSJtYWlsdG86Y2hyaXN0 aWFuLmxpbmRpZ0BjaXRyaXguY29tIiBjbGFzcz0iIj5jaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5j b208L2E+Jmd0Ozwvc3Bhbj48L2Rpdj4NCjwvZGl2Pg0KPGRpdiBjbGFzcz0iIj48c3BhbiBzdHls ZT0iZm9udC12YXJpYW50LWxpZ2F0dXJlczogbm8tY29tbW9uLWxpZ2F0dXJlcyIgY2xhc3M9IiI+ PGJyIGNsYXNzPSIiPg0KPC9zcGFuPjwvZGl2Pg0KPC9ib2R5Pg0KPC9odG1sPg0K --_000_2D872B65A9CB4EBB98CB3B0001FA235Ecitrixcom_-- From xen-devel-bounces@lists.xenproject.org Wed Nov 09 14:18:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 14:18:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441052.695303 (Exim 4.92) (envelope-from ) id 1osluK-0007pk-QI; Wed, 09 Nov 2022 14:18:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441052.695303; Wed, 09 Nov 2022 14:18:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osluK-0007pd-NK; Wed, 09 Nov 2022 14:18:24 +0000 Received: by outflank-mailman (input) for mailman id 441052; Wed, 09 Nov 2022 14:18:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osluI-0007pW-V8 for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 14:18:23 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5c4b88a0-6039-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 15:18:21 +0100 (CET) Received: from mail-dm6nam04lp2047.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 09:18:18 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by BL1PR03MB6197.namprd03.prod.outlook.com (2603:10b6:208:30b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 14:18:16 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 14:18:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c4b88a0-6039-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668003501; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=EPqjE7d14wyVWB/3xn2R/Nitu2V1hfAAWa7Ozp9AkEk=; b=aNi6ups4NKdDUuORKToCMY5dfeEzqPvrZxVaBPK+0yGYL2SLEXkK9Oc9 4AcBdSTwaf7OxZr1JH/Vx3kyn19U9bjSYDz/5Hg49YAw9VlcRz9OswGB7 yer9C6o7vJ4SvIed22eQyAcdzgVk1bNmKV4Je5f7xgbSBiKk7uRg9DM/t w=; X-IronPort-RemoteIP: 104.47.73.47 X-IronPort-MID: 83552163 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:sTYhRaJ96fL0D2KYFE+REZQlxSXFcZb7ZxGr2PjKsXjdYENSgTFSy GocXDqObKyKMzCke413ad609k0CsZGHydJnTFFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wRvPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4qJWxHy aACJAk3dx6kpLiXmIyRRs5V05FLwMnDZOvzu1lG5BSBUbMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VspTSMpOBy+OGF3N79d9CURMMTgkGCo WHu9GXlGBAKcteYzFJp91r83bKSx3qlA+r+EpXnrsYzjgSDz1UOSzwnTUHrjqm0oAmHDoc3x 0s8v3BGQbIJ3GymSMPsGSKxpnGstwQZHdFXFoUS6hyJy6fSyxaUAC4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkA9IWYcaAceQAAC4t2lp5s85jrQSv5zHajzicf6cQwc2 BiPpSk6wrkW08gC0v3n+Uid227z4J/UUgQy+wPbGHq/6R90b5KkYIru7kXH6fFHL8CSSVzpU GU4pvVyJdsmVfml/BFhis1RdF11z55p6AHhvGM= IronPort-HdrOrdr: A9a23:wrHWIa/cbd9gRP88Xchuk+F7db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuCKlaDPY0LDErXQBeoR8bMtiA2Xkwltls9dm3K 1R2WWF85JREBPbhSz4o8PFThdwiyOP0DMfeX56tQ0hbWIyUs4nkWUkxjIiLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3f7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPbHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCD34Gyff+qaGj3iq9M1lVBw6du/22z6IJyoHUVf7sLTCJTkwono+pv+gfa/erKc qOBA== X-IronPort-AV: E=Sophos;i="5.96,150,1665460800"; d="scan'208";a="83552163" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tw0Wh+PHwFenlJzaKo0SK7ICQnzjX3sOChVvpihciijRRSlVVTfq9B2X9c45SsYDCYRz5BB5ra5v/WQiq3yirrCBysTAe9oWSpuxNa491c8rmpC+yq+H1oq32Dl8ul06ufotCpGNaVU4u0aFMCU3GgMBF7HZqpLd8P5RY9O2cCkV3eQ0kdVfJ0ZlLS4FUkwSbwAh98euE1hqBHRuiyDd1JIM9ht2PN3ZemNinQGhyRvmd1TFaRf1iKmc0Bg6NHoO9Nby/LYqQQZmp2n7/vTjKW0/v/LJlXQB5PUKxKxF2azCZs+/TpHa3kVNraGgN6Ew5a0Ln+Zsr5S8zxnynhj2nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c8eKovsa9/zAjjj2eEXHy3G9ERh7s5T6IgK4RZzjVC4=; b=Ow+bAFDjkr1ZFQMAD9ulSXwtR0nGaipwXXhFP0GKpTldG1NcAyh8QeqvcRIjBfaS3ittaOow3WLFBmFwRoM0mI+2FCkBRwNj1mmIVj6bvIDPsfUTgYJSYTr4owk6B9lMWgHmxHqUHyOqzCf8zia923tZYGcp1SVjls/ZEgehp8CTxv3iTvq9KUXwfFKn0NgpvBoC0fUx35Jj8/rV7o4BbjVnFHScAhBJFwLTXWRuLxIlOTM+uYgAzKdku+AmI3ENodsbk+3J0XC3RL6+S3o0ja9TCtXoE/DNLCgmL3W0oogBKDtXy40kFIZ1WdiKiXSXwU7LRYeCwmHPKO63KzSWfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c8eKovsa9/zAjjj2eEXHy3G9ERh7s5T6IgK4RZzjVC4=; b=VxdPcWGXkaFbWySYoO5dlsinfUFFitfl74O9pELiZZOtckMkRxxWUsNL68fYrh3l9MuSvn2Ls3Xvf2/twudVatuGE5WMNGv8JwlV1uhm3gQLbfeUSxXX0A8kSRJ4HyL2ie0g1y3iOJzjm+xaEYW7ECtf8OyKjEU7ZEwpcvVzoO8= From: Edwin Torok To: Henry Wang CC: Julien Grall , "xen-devel@lists.xenproject.org" , Christian Lindig , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Index: AQHY84fA+Ym2JRve3kKJcIO1APAKeK41MEgAgACx3ICAAML3gA== Date: Wed, 9 Nov 2022 14:18:15 +0000 Message-ID: <0B9BA046-5FA5-42EC-9959-63F15B833E91@citrix.com> References: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|BL1PR03MB6197:EE_ x-ms-office365-filtering-correlation-id: c27708e0-5c85-4235-0ca6-08dac25d3e4b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jDPvjs6BtuKH0+gf2k8Hhe4oc33lzmAWFnHIoX0RccVWcIZnjoiQ2RA+ZxRlfUNfx/8LnBX+KJZl8Hhl22dhvnG99PwwvmRX4XyizN38N+10BEYFS/aoPnzoyy2PTLvKsZLaBECwuORx8Dfl37dUuUq0PNKVOPi7up6+xkhimQ5IH1+j4A0pdnErr0+uQOpSJbMXQcIL8btPGbGU9IGQvPnzCDdgF4awoYBUk1I3GHtDry58AkIOV01Ko+Xi0nH299lCafXI4LiPXHFRWuQhxwEG+5dudI0qX9zwLqfQh8OKEW68xtBsL83/udrZ9BgW4WsDY5agY/K0/+CiYuQ7g2qKsujj2nWoyo2HNxNhOo0Cx3z26m2L+OqNkiDqiMIPg0HJvEAHUQhwj/nExMG/tEwdfW/kWR4qty31Ef/FzqOrJlXKqEIV2WXNO6p4NRtgvyt6/TQnpQHb4XCh8QvMV/nr8DXPzEopau5kwVFg1C9AVcJCOFWrsJbHjuhKJHhbAnfK91ez9marNduRAJlnUQPOwgoBasTaSTcJZ2cvJOw6/O2SlQJceFNRI5H5wb7fgcd75CHp+zs3YILsesmUdxf8B27a8qRSWzKGpOt/EFo395c6GUoqLgl9uDWWTDnsdW1fs5eTkdzQl1ZnFFJt9GJLV2qsHuMv3Iv8PF4URdWQfdt7qIFU3V/U6WX75NORV84DFwJRCFKrU+8kmhbt7I/VggB9+qRLLd1pIM0DamsadKQXrpwCAPLHHUYclRTgg2aKGO183NlTyT6dx9ZP8hggzJOrjBiIvnmaEVjJqa4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(136003)(346002)(396003)(39860400002)(451199015)(6512007)(107886003)(186003)(2616005)(53546011)(83380400001)(26005)(38100700002)(41300700001)(6916009)(122000001)(2906002)(6506007)(54906003)(478600001)(91956017)(5660300002)(71200400001)(6486002)(316002)(8936002)(4326008)(76116006)(66556008)(64756008)(66446008)(66476007)(8676002)(66946007)(38070700005)(33656002)(36756003)(86362001)(82960400001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?34V4QFY6WNWhxejdbkDKBw+B+GS0dfHmzZHoYj0ztIUqcqQwaDFiV/HH+T2r?= =?us-ascii?Q?U2iJeGkLi9jAHI4J9YNmWRP63TaRJozx1+hmKLbRA05ytxUJBpPWM38FipEk?= =?us-ascii?Q?uB5mJZ1ESAWyHU7CYYjHDlHEtPu8+ljnJwd0qY1SRXVSolcGpOALb5hC5lsB?= =?us-ascii?Q?yrQWBMeonihu1fUOrWeMReByIxlMgpbSRy6QoIAzuGajni3XumIZ+d18Eysq?= =?us-ascii?Q?hdAFJ2ukkdA8xtytoCiiAKdlF/2wb8/6nz5lhCd3r6zj9Kv+kV4ieK/PDc0x?= =?us-ascii?Q?71esbKHPntgZIT1jfUH2chNe3x0tw8yf080HtZX3x8pvB7TtmjW6hMqmFuzJ?= =?us-ascii?Q?zi1ofZlrH1DlHjEd/ida75gz1T6HRgCXIrK9pA5tSkiwAVg/lGPwpJmLgrd1?= =?us-ascii?Q?tNEh6NldDXdmvNfyQtvpU1aFiV7FBAP87HuWU27nWEYURPHTyl170BwQOVeS?= =?us-ascii?Q?XG8RLkUVLHS92f7YMoOX+YE9JtkyYE3/HsB7L2Zj+sfK3oJNm3gxGccaEDZ3?= =?us-ascii?Q?rxjJGenrX6pxYuzS/CscUMtPACyS5KVxEHhUp5zYljiAqZsirJTH+jka2Hf2?= =?us-ascii?Q?ULMbzxYZzmcCfOS1B6HIs+e84iQnMb7IJ4bQvZa4ogKg1v0y/e7UYhpEFJfc?= =?us-ascii?Q?u2iPv7O8KaIX5Y7hFFWdKZQG8DjA9H6wdsLQz9OQgGjQDo6ThUzUGaq5e9Kk?= =?us-ascii?Q?OYB6ZGL/CHrcK1rix0y4DXfxUMTF85d/rh/axhygJEMJtdGuJFSRW+I+4aJd?= =?us-ascii?Q?LN+XfqHJhPagrJG0f4KSeYqOF6pMesi7dPARYDFrX21DAOHmXYBawhRc+9AK?= =?us-ascii?Q?Y0qC1Eax7KVxqiG9JDk9iEngTMfLjxiIFEehSshac8jOZGgfhenCE40gN0G2?= =?us-ascii?Q?WffY/o4qhucDIRKjrZ891yruENNUKzNGQHYjeZLbnz+ReIMhZP2Ew/vFEVm3?= =?us-ascii?Q?sKO9LzeedSuK6yHW+bTMs1tWuBPUbrljN5qD+oKfspuDQjMvhVdj/ef1IQ6q?= =?us-ascii?Q?iznRO0YCngSmlbQnM2zGu3ff4D4RDHgAlNGj0aHNiozMt2VQzuMUrCM1Cv84?= =?us-ascii?Q?3/VoJWUbEx39hON7P6rTXo2XdlRnD3N6/a4BPzR5LquW9jRO+3ihrbDSy2WE?= =?us-ascii?Q?MlANf45guWDpR2VCwAEcqsLiO2OZphhfRSgaCnDLuSG5JU84nwJ1zxIx2r9+?= =?us-ascii?Q?+UE3vn3csHkb4FuCKySjGq/PAJ5VqCSdlHV1oHfQ860W92B4bFzTu15Y2wHb?= =?us-ascii?Q?IVBlZHJukTSEc8qO92hypW6T6/YTbPVM2lHT/bygRGMNTlIcKW3MmZQDrC6L?= =?us-ascii?Q?gse9LS2Oaw/ENT21RipP+8Mk+mtdbpufJCSI3VxUq7tGbX/dCC7exnDZdegu?= =?us-ascii?Q?P2tE8l0HsUxXqSL1m+xVuWjdAqjTKolrxvR7Ejj6q3Kopezzde7BCQ8sw25p?= =?us-ascii?Q?IA4g7Sjwx5KkfDnxM64ci8NRL2szuEnJouDPnwsLrUkAac3uO2Mc0oRcw3uk?= =?us-ascii?Q?a7w1kaSxxMwFDQDT6jlhGRkslJg7tDr5zlcnwxGQDS5/u2INQd6Nf+8OTnEu?= =?us-ascii?Q?qnq25DJdPixlmmtM1CZ88KlmemrBerSnKWdW7sw5RTEdg5FPW/5dRf+dApzM?= =?us-ascii?Q?GQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <0C8391960F24A94183EE0C8D2CD4EA93@namprd03.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c27708e0-5c85-4235-0ca6-08dac25d3e4b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 14:18:15.8886 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tFX+LUToiNd9JvqKMOdVyts/coaCnHkUA/Wy73wTUD967ZspRNlKySZKAwYzcyNo9lcSTtArX3UrJ05K22tSiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6197 > On 9 Nov 2022, at 02:40, Henry Wang wrote: >=20 > Hi Julien, >=20 >> -----Original Message----- >> From: Julien Grall >> Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add >> 'make format' and remove tabs >> While I understand the goal and support, this seems to be a bit too late >> to do it in Xen 4.17 (we are only a couple of weeks away). At this stage >> of the release we should only do bug fix. >>=20 >> This is clearly only a comesmetic change and there I would argue this >> should be deferred to 4.18. That said the last call is from the RM. >=20 > I agree with your point. I think maybe defer the patch to 4.18 is better, > given the deep freeze state we are currently in. On the other hand here is a bug I just spotted when looking at indentation = changes (or rather reading the code after the indentation change), and there are probably more: ``` if not (Domain.get_io_credit dom > 0) then debug "Looking up domid %d" (Domain.get_id dom); - let con =3D Connections.find_domain cons (Domain.get_id dom) in - if not (Connection.has_more_work con) then ( - Process.do_output store cons domains con; - Process.do_input store cons domains con; - if Connection.has_more_work con then - (* Previously thought as no work, but detect some after= scan (as - processing a new message involves multiple steps.) I= t's very - likely to be a "lazy" client, bump its credit. It co= uld be false - positive though (due to time window), but it's no ha= rm to give a - domain extra credit. *) - let n =3D 32 + 2 * (Domains.number domains) in - info "found lazy domain %d, credit %d" (Domain.get_id d= om) n; - Domain.set_io_credit ~n dom - ) in + let con =3D Connections.find_domain cons (Domain.get_id dom) in + if not (Connection.has_more_work con) then ( + Process.do_output store cons domains con; + Process.do_input store cons domains con; + if Connection.has_more_work con then + (* Previously thought as no work, but detect some after sca= n (as + processing a new message involves multiple steps.) It's = very + likely to be a "lazy" client, bump its credit. It could = be false + positive though (due to time window), but it's no harm t= o give a + domain extra credit. *) + let n =3D 32 + 2 * (Domains.number domains) in + info "found lazy domain %d, credit %d" (Domain.get_id dom) = n; + Domain.set_io_credit ~n dom + ) in ``` Notice how all that code "seems" to be inside the if unless you read really= closely, but in fact it isn't, just the debug statement is. Which means whenever I reviewed this code (to look for performance or secur= ity bugs) I've been reading it wrong the same way the original author got i= t wrong when indenting it. In this case the original author being me, as I've introduced this bug in 4= 2f0581a91d4340ae66768a29fd779f83415bdfe back in 2021, where prior to the ch= ange in that commit indentation was correct, but the patch added the 'debug' line in the wrong place (before the let ins= tead of after it, and had I had my usual tools available to indent the file= correctly this problem would've been detected and corrected before commiting the bug = into the codebase... And was probably a side-effect of trying not to reindent the code to reduce= the patch size for the security fix, and by doing so introducing an actual= functional bug ) (And I've recently fixed a similar bug elsewhere in XAPI, in which case I w= asn't the original author of such a bug) Indentation can't really be trusted to humans :) (It means that even if a domain already has IO credit we still scan its rin= g for more work) So some indentation changes will probably come in as bugfixes for 4.17.1 (w= ell maybe not reindenting the whole file, just the problematic region of co= de/function). Best regards, --Edwin= From xen-devel-bounces@lists.xenproject.org Wed Nov 09 15:04:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 15:04:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441062.695321 (Exim 4.92) (envelope-from ) id 1osmci-00061k-70; Wed, 09 Nov 2022 15:04:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441062.695321; Wed, 09 Nov 2022 15:04:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osmci-00061c-48; Wed, 09 Nov 2022 15:04:16 +0000 Received: by outflank-mailman (input) for mailman id 441062; Wed, 09 Nov 2022 15:04:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osmch-00061T-Qh; Wed, 09 Nov 2022 15:04:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osmch-0008Gr-Ny; Wed, 09 Nov 2022 15:04:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osmch-0007Ln-6D; Wed, 09 Nov 2022 15:04:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osmch-0003uh-5W; Wed, 09 Nov 2022 15:04:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=T/zm4q+gOLP192+R3s1e9T2VvAKwhHn6wdBz00ol9IM=; b=NBrzkeGkLgGeknG6cksocHLJ0y WldKgtKIocMrWVxwIi/6PDc3+Fhkafu58fI1KA/aU3Eu0lc7F5L9RJgsJxQAAfZ1xX72HhEH6Ueqr c3hiO6K+XQLrvhy6mq9lebgwBT6ksQfXyxgSW4nNekDhtAxa6NjREUdawmjE7Gk6r0ZI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 174677: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.14-testing:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-localmigrate/x10:fail:heisenbug xen-4.14-testing:test-amd64-i386-xl-vhd:guest-start.2:fail:heisenbug xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=46040a5fe68831530b8ffdea7d264e52ae316c87 X-Osstest-Versions-That: xen=6222bb8bd76a0f21048c852acd2542fa2494a907 From: osstest service owner Date: Wed, 09 Nov 2022 15:04:15 +0000 flight 174677 xen-4.14-testing real [real] flight 174691 xen-4.14-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174677/ http://logs.test-lab.xenproject.org/osstest/logs/174691/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-ovmf-amd64 18 guest-localmigrate/x10 fail pass in 174691-retest test-amd64-i386-xl-vhd 22 guest-start.2 fail pass in 174691-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 174584 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174584 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174584 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174584 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174584 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174584 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174584 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174584 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174584 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174584 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174584 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail like 174584 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174584 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174584 test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 46040a5fe68831530b8ffdea7d264e52ae316c87 baseline version: xen 6222bb8bd76a0f21048c852acd2542fa2494a907 Last test of basis 174584 2022-11-02 11:38:08 Z 7 days Testing same since 174677 2022-11-08 18:07:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6222bb8bd7..46040a5fe6 46040a5fe68831530b8ffdea7d264e52ae316c87 -> stable-4.14 From xen-devel-bounces@lists.xenproject.org Wed Nov 09 16:11:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 16:11:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441071.695333 (Exim 4.92) (envelope-from ) id 1osnfh-0007QU-8Y; Wed, 09 Nov 2022 16:11:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441071.695333; Wed, 09 Nov 2022 16:11:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osnfh-0007QN-5o; Wed, 09 Nov 2022 16:11:25 +0000 Received: by outflank-mailman (input) for mailman id 441071; Wed, 09 Nov 2022 16:11:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osnfg-0007QG-8u for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 16:11:24 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2568b5a4-6049-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 17:11:21 +0100 (CET) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 11:11:09 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5164.namprd03.prod.outlook.com (2603:10b6:5:247::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 16:11:07 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 16:11:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2568b5a4-6049-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668010281; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=M4XaE3dKcv9t5U3oti/AG2Qf6ngG1lZU/yYEKnKSA5A=; b=JJYQOOD+hBgFzO3otK7mW7ILavVS3Ixk25PxKc1r5j03PDglVo0dXtXE Fdui7KMEfs/zRBkqqhdofbUi7hJT3kPptQK2aZxBlcSzjt2/mxOWCMIkC 2W70Vy3WNmi4o95IjhKT+Rw6x63BBxnhzv8jJy/XFZ8MspMLaY154J0Qu g=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 87024462 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:iYWBiqudgz0CeSXcUYIPhCFSj+fnVGhfMUV32f8akzHdYApBsoF/q tZmKWmEPf/ZYmf9f990Pdzk/U0Ov5HQndBrG1Fpq3tmRC4W+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaGxiFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwAzQxQBOtjs+P8LflY+RV2O0MHM20BdZK0p1g5Wmx4fcOZ7nmGv+PyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgf60b4W9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPO3nrqQ23APJroAVIEdNW0WnmdqWs2y/Xo1/M 2sT3wR0nadnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQK2 1mTjpXWDDpgmLSPTDSW8bL8hTG4NDURLGQCTTQZVgZD6N7myKksijrfQ9AlF7S65uAZAhn1y jGO6SQ72bMaiJdR073hpA+YxTWxupLOUwg5oB3NWX6o5R94Y4jjYJG07V/c7rBLK4PxokS9g UXoUvO2tIgmZaxhXgTUKAnRNNlFP8q4DQA= IronPort-HdrOrdr: A9a23:LpdPEqybwnUnik8SNs8iKrPxj+skLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqm16Jr1usMr5 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGLf2RYUh2rD3xnklZqsoDWb/8sQqAe NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN DbXFZRpQcJCjbT4A21reh2Gzz2MRaAtG7Wu7BjDrBCy83BbauuNzGfQ1YzlMblq+kDA6TgKo SOBK4= X-IronPort-AV: E=Sophos;i="5.96,151,1665460800"; d="scan'208";a="87024462" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iqrKeBOejSb04YEi2LLmuDi8K/k6Pk9cSzgDk0foe5s1XDzuCOPoERXXLDQqi8HuQUsT4N69xO7Abw3wOvYh5b7FM1qpDwUpbfuTtmuGoFZyhH9uN9U/AQ6bN/BRliiNTFW1B2wRg0dvK8nNqam4/6t0MwISGWDENtNVMqI2oHcZOqlSFyVVXnN/c8ZRd9+jjAx167ZtYfa8HAwgwgpcirspweVTe9/WwOZyLwukDV2SDFw45/3iaqsHQxB7yty1P9o/RIGDq0KbhNBkZEOp2x0qZBknal8BwHEWxtAQGt1oaQNyV4a7EWuonjgol/5q77v31ARU8KpzIFQWZ3Xnkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M4XaE3dKcv9t5U3oti/AG2Qf6ngG1lZU/yYEKnKSA5A=; b=eQhhwKu9FCcU1KU9ZETGYWF1aFV74xSK7VSDfpT24VV/XDG6VYyMAmp565r+Fs/fVDNpM5zi5JGiiT3YX7yA3exhzWJfDV0M12WB4pqwV5aRgKO3t1IqZ18WgC3dc26Ov0clS9z1WpHSUh/X4uvP0YgVeWGimxgYxOyA81AAbQLrEiJoLd4Gtq8yYrOMTyFHgKPtf4MNlSgXPxQax1vEVCLDBU+4+Yp0wTY58AKCRG0jKBlW/ZXSZ4WP/uY7YnlW8tkuskxf7wWNgVqx+7O8A1hUKCotoS9LAx4kBr3QK3IymptsxptOEWMI30nveSIif6QLw/BM7ExGsoZoksc1RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M4XaE3dKcv9t5U3oti/AG2Qf6ngG1lZU/yYEKnKSA5A=; b=du5nnXydvDbtw3dbmgSUSatwVApyHHwc92WsFliRd9vSADeXG9eg3s1CSNXBnPiULd3wRktETmvYOKzds/XfX02Q1x/c9uDGLNyjhlS7RhzJiKvh1QRs5rxKVjEJm3CcEOxvpdrKOpqzsu2MQNeVNohku3Ad5NkDloxLb5lVTW0= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: "Henry.Wang@arm.com" , Jan Beulich , George Dunlap , Wei Liu , Edwin Torok Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Thread-Topic: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Thread-Index: AQHY82a4cu6AadRChE2NlC8gxlcdqq42xPAA Date: Wed, 9 Nov 2022 16:11:06 +0000 Message-ID: References: <20221108113850.61619-1-roger.pau@citrix.com> In-Reply-To: <20221108113850.61619-1-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM6PR03MB5164:EE_ x-ms-office365-filtering-correlation-id: 8edca0fc-e2cb-42f5-2c66-08dac26d0237 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r2ucO7qzVaa3qKwqvxChdQ/MtkmsvzbEur/nzodmeSEfVWdjpZ/dN0X3mwFNuUluc+48RytVyZ5/6b+gJR3DE2IxOYH+Qois+vcLwHZCCB+tgiPqBDh2mN72wQB/PhEJrcKE4msLCqMyDbTcNoW+TXVsOWx5El8N+e4Rv4VKqtIBesin8POv+HzA0RfnVbV6C1agigyFYnu7vNjNTDFCQy9Rd7/KXxnxW6btRTkSHxB+fAAmLLrlmhj9ps458PHxGRzmpDL/ndGTYHXAjQcD21c/YGKjnMoLcJCz8MfYyfTb6/9iVRLeK8VzUlBS2tf6La7nEmGTIOxnSbOhe8pbAitsTvOsxsRxX7DU/SUpLjUqMy5IRAp3Pgn5bSq7tmZjNnFb1AurnVomSSf0sZ+vuL000JMUImriu3exDLYamAh47r4WgP7uzsx99O0tQ1hR4gkydxZEu7Y3GvKwYrbLmSZ3KU3Ly6OxBrcEogEDhPNjUQyUMuA83AAQP3xdp09mx769b9jhU+gIRZkseW1Q1d0vLqImDad/rtvhjsbr8sQZhl87EdoHxBmXQHB2AMns+M7fjoR3icct0phublgeBUFHtevbKsGOtBF0gRIJxeDRMzygETFb4Beq2aSAkLxcvyailnJGJIU/cXeS1tcC938NE8IJR6/HtlDq03/40l8CKTkbcQY7Id0BujrOIf3KiZEDkeJNqUtgI+zi1XtfCSVUd4CLyg6NK7LBhbtR97imvQgXYHieuj5lHiy4pJYaX/otjBXitbLY8aSDqfufaAO1wTl9+Wghh6+n22Z38JF637+o+rnt9OxmNhaLDXF8nE7/6F683so7g+g3k18l5w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199015)(66899015)(36756003)(31686004)(82960400001)(38100700002)(122000001)(38070700005)(83380400001)(66574015)(86362001)(31696002)(6512007)(2616005)(53546011)(107886003)(76116006)(186003)(6486002)(478600001)(71200400001)(110136005)(54906003)(316002)(66446008)(91956017)(64756008)(66556008)(66946007)(66476007)(5660300002)(8936002)(41300700001)(4326008)(6506007)(26005)(8676002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?V1NaeHhkRFc0a1FQZkQ5M0ZYMFBzQ0JORUU5K09uazdYWGQreEo5MWIwRTEv?= =?utf-8?B?RWlIMEFML3ZwUkFEa09yWjB4RkUyaUI0MFJJYUtPdTBGWVlUc1BZV3VnTDRp?= =?utf-8?B?U2kyQ1RVMzd6b2N2OUJWYitCQ1NTY3BpVU9zY2FRRERUQUV1cDAvL2gzQ1E4?= =?utf-8?B?UkJkdkc5TEZ0bWFiUEZiL1R2TFZPVm9vU1JLTG1iSVRLbW1WM0N5bHpmZ3Rm?= =?utf-8?B?VlVKYmxvQ3B1bnFBY3pjWDBhNTF2bEhNUy8wUmViSlFBMHFFR0hlK1E3ZExU?= =?utf-8?B?MEN4TWlwdnVpNHdINlBaK3Rnc1NteWVLbmdidTRsejhmWUtHVWR5dGxZOTZo?= =?utf-8?B?dkF5YkRlbUoyWksxanNEQlZVODJ6VjhtK1BNa21ncEk3a1ZvUmxUQkFpekhh?= =?utf-8?B?YmJzTXVoaDZZMVNRSjRRQXRLc0FabnlVbUVBbVJNUzlvR3dpbXdRNjExUnlY?= =?utf-8?B?WFIrOVBob1RkaDRlcWJRamRTRlBxQUpOY2hjaEZJREIvTUpUUmcwMTVHSHNR?= =?utf-8?B?YWFMRnRNZGpHL0ZtZnBteEg5M09FWGhZeXJqTlAwWkphWjNSSkdaYURLWmZn?= =?utf-8?B?dkNueEZ3Z3JYSnZrcUxoRC84bk5xNUpiS0pLSTJmTXlFM2VXQ1FEVGhwam1U?= =?utf-8?B?dlA5L1E3WFJsa1VYVVVBQzJCUDdDWGVOWGJMMjZJb2dBa0Vxa0h5SThYelI4?= =?utf-8?B?Y2lNczZYYS9QbkFZY1h5QjJISXUwbmtGRCtuVWVGWENxUEZOcTJnNFFlL2kw?= =?utf-8?B?VzkwSkE5RWZ3WnFWdFJmZXM4KzBWcXl0ZTdDbm1qY1NYNXo0SjdXbml0RU4w?= =?utf-8?B?UnlOVWZJckFhU1lpeW91VmFDaTZWNS9zREVhdVQzQ1dNTTZBTXI0Y0o4RGw2?= =?utf-8?B?d1VaY1pZQitWR1lVVllOMUJQK0xDY3JtZ3VvYVdaZnFTcTVEY1FQL21ad09D?= =?utf-8?B?S3VsYUowTzA4S2hMRXFaMTlUTWRyUlpPbFJLaHFURVV6SGdiWU1GZzF1byta?= =?utf-8?B?T21GdTBKdEowNG11aHpVeS9aTlhTQVhrTk9ENlR2WFNWZVZUUjZDanpVOThI?= =?utf-8?B?S251OFlvV3B5YVhCUnZKd3BFT0VqSTYxc1RPTHN1TFVrSXRqSXR1Z2k4TGZY?= =?utf-8?B?UmhzNEN5eVhBSWtGaXJiV3NnNndmRlY0aHpiRXJLZFZocEl4SkNwU1NTdjVM?= =?utf-8?B?cU1xOUVlUGgxMkFvZ0Vmb1RJL21ab1F6Zit6R0U1eTRMUktyOGFQM3BLeHgz?= =?utf-8?B?eVBEcWIyZEtuTWFoUnl3aEZZeVdyN3FFZEN4WXdLemNQYlhHRDREVEk1TDJB?= =?utf-8?B?RDVXRVQ3QWI1QWlyeGExUWZLdzJqQWRnckxuNnMwalRGRFY4OHVXWXFoVnZp?= =?utf-8?B?d2lMUnlaSEJOUFJwOUpEQ1NwNjV2d2pwMXJNT1V5eUVLcVpjTmRUdnIrLzBC?= =?utf-8?B?WW9hMi9OQXppNFlWT0JlWG4xSWpVNHRBekpKNUhVTHk0ei95V2tOVUY0dVJQ?= =?utf-8?B?NGZhRnFkaWxZbmNaK3NNZURwamZKSXNiVjlvU2lmdXlWS09STmFRZDRnbi9q?= =?utf-8?B?ZUdSQW9uNzlFWEhsVGVGS2R6NGxOWTNMQmpUaWNDUGlFbk9rWXJURXpQSXRR?= =?utf-8?B?UHhIa2drK3piR01YbmJNVTJKeld4TzVsQm9FVlIwUFdzTEF1bk5mMmJHN2lI?= =?utf-8?B?dUthby9ySVFHb01GOGs2L3RKcWdFdFUvaEc1T1M4eFdUSDJIbU83bk8xUmlG?= =?utf-8?B?d1h1dGNYbXZ0Z0FBWmptSVFoOUhLeHV6U2pjejNPUmJLM2JpWElxZmR2V2N1?= =?utf-8?B?b0Ixa2ZGOG5pSkpVODNMblU5SU5jd0hETjM5YnZjTC9ycms1ajZ0YmxVQWpo?= =?utf-8?B?SlFmM1Y3Vmp0WVlEOVhHSjRJZFg5VS8zNlZnTTRmTjB0dUgxUytYZXppbW5T?= =?utf-8?B?WktQVTA0cnB0NGVISzk3bStsQ3hyWFFpYk5YZkJocGp5bHF0OFAybTFtODMw?= =?utf-8?B?aXpEbU9SejhESTlRbWIwbTNwNjVQbTE4NzRESHN6bHpqeFZkSWxMVk13aDl1?= =?utf-8?B?M2gyalgydG9yVEwzeDlUeG5Ib1d3L3NneXViYkJZaXNINFA1SlNIM3ZKUWFn?= =?utf-8?Q?AM4F4Moq8uP9x8bVJLlipd8Dv?= Content-Type: text/plain; charset="utf-8" Content-ID: <78F7FB5784EF0E4D812EBC2FC9E68812@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8edca0fc-e2cb-42f5-2c66-08dac26d0237 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 16:11:07.0115 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BnrmMxL5a+KJqbt/rUqAQfiy0tlfVfyQX14sDZICOF5HqisUWUsmReJZo8963CXdju0q60S6X/ifiBt8fLeBTSr89w/0L+US1brlrLWnzek= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5164 T24gMDgvMTEvMjAyMiAxMTozOCwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBMaWtlIG9uIHRo ZSBBcm0gc2lkZSwgcmV0dXJuIC1FSU5WQUwgd2hlbiBhdHRlbXB0aW5nIHRvIGRvIGEgcDJtDQo+ IG9wZXJhdGlvbiBvbiBkeWluZyBkb21haW5zLg0KDQpIb25lc3RseSwgSSdkIGRyb3AgdGhlIGNv bW1lbnQgYWJvdXQgQVJNLsKgICJ0aGUgQXJtIHNpZGUiIGhhcyBleGlzdGVkDQpmb3Igb2YgYWxs IG9mIGEgY291cGxlIG9mIHdlZWtzLg0KDQpBIGZhciBiZXR0ZXIganVzdGlmaWNhdGlvbiBpcyBi ZWNhdXNlIGFsbW9zdCBhbGwgb3RoZXIgRE9NQ1RMcyBhcmUNCnJlamVjdGVkIHdpdGggLUVJTlZB TCBhZ2FpbnN0IGR5aW5nIGRvbWFpbnMuDQoNCj4gVGhlIGN1cnJlbnQgbG9naWMgcmV0dXJucyAw IGFuZCBsZWF2ZXMgdGhlIGRvbWN0bCBwYXJhbWV0ZXINCj4gdW5pbml0aWFsaXplZCBmb3IgYW55 IHBhcmFtZXRlciBmZXRjaGluZyBvcGVyYXRpb25zIChsaWtlIHRoZQ0KPiBHRVRfQUxMT0NBVElP TiBvcGVyYXRpb24pLCB3aGljaCBpcyBub3QgaGVscGZ1bCBmcm9tIGEgdG9vbHN0YWNrIHBvaW50 DQo+IG9mIHZpZXcsIGJlY2F1c2UgdGhlcmUncyBubyBpbmRpY2F0aW9uIHRoYXQgdGhlIGRhdGEg aGFzbid0IGJlZW4NCj4gZmV0Y2hlZC4NCj4NCj4gUmVwb3J0ZWQtYnk6IEVkd2luIFTDtnLDtmsg PGVkdmluLnRvcm9rQGNpdHJpeC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25u w6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KDQpSZXZpZXdlZC1ieTogQW5kcmV3IENvb3BlciA8 YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4sIGlkZWFsbHkgd2l0aCBhDQptb2RpZmllZCBjb21t aXQgbWVzc2FnZS4NCg0KWGVuJ3MgYmVoYXZpb3VyIGlzIGRlZmluaXRlbHkgYm9ndXMsIHdoYXRl dmVyIHRoZSBwZXJjZWl2ZWQgaW50ZW50aW9uDQpiZWhpbmQgdGhpcyBjaGFuZ2Ugd2FzIG9yaWdp bmFsbHkuDQoNClN5c3RlbS13aWRlIG1lbW9yeSBoYW5kbGluZyBpcyB1bnVzYWJseSBicm9rZW4g Zm9yIGtub3duIHJlYXNvbnMsIGxldA0KYWxvbmUgdW5leHBlY3RlZCBzdXJwcmlzZXMgbGlrZSB0 aGlzLCBpdCBpcyBub3QgY3JlZGlibGUgdG8gc3VnZ2VzdCB0aGF0DQp1bnNwZWNpZmllZCBvYnNv bGV0ZSBjb2RlIG1pZ2h0IGJlIGJyb2tlbiBieSBzdWNoIGEgY2hhbmdlOyBpdCdzDQpkZWZpbml0 ZWx5IGJyb2tlbiwgYW5kIHdoYXQgd2UgcmlzayBpcyBleHBvc2luZyBhIHByZXZpb3VzbHkgaGlk ZGVuIGVycm9yLg0KDQpOb3QgdGhhdCB0aGlzIGlzIHJlbGV2YW50LCBiZWNhdXNlIFhlbmQgb25s eSBtYWtlcyB0aGlzIGh5cGVyY2FsbA0KYm91bmRlZCBieSBkb21jdGxzIHdoaWNoIGRvIHlpZWxk IC1FSU5WQUwgZm9yIGR5aW5nIGRvbWFpbnMuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 09 16:27:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 16:27:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441078.695347 (Exim 4.92) (envelope-from ) id 1osnuy-0001LK-Ks; Wed, 09 Nov 2022 16:27:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441078.695347; Wed, 09 Nov 2022 16:27:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osnuy-0001LD-Gr; Wed, 09 Nov 2022 16:27:12 +0000 Received: by outflank-mailman (input) for mailman id 441078; Wed, 09 Nov 2022 16:27:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osnux-0001L7-Hd for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 16:27:11 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 59d7c5b5-604b-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 17:27:09 +0100 (CET) Received: from mail-dm6nam04lp2046.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 11:27:04 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by CH0PR03MB6033.namprd03.prod.outlook.com (2603:10b6:610:bc::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 16:27:02 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 16:27:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59d7c5b5-604b-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668011229; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=01okUQweI9FcDAGzqugXotVxQCl66ejb7qXpXWy7DPc=; b=KHbrnh0WLe3xV1hzb/gjUxgMlRbwXnXvk4m795fwbLisEMLoureQfr67 JMBufcyOqTMPj6pcDG7Ycugi9dQbIzIqutZIBaXnxq364HlrDit4qs1dH TTWzFcVrbiYjFvfwoW1EWQ/HFf4g3j1q/u4ICY4bSuFeepL0TwVoBabjq w=; X-IronPort-RemoteIP: 104.47.73.46 X-IronPort-MID: 84918370 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Av8Do603FNaLDEET2/bD5RNwkn2cJEfYwER7XKvMYLTBsI5bpzRRn GAWUG6OPfvbajP2Ldsjb4q0/EIE6MDWyt9hQAI4pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVmNKgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfDiIU5 /YUCzAxZ1OG19yUh4u3VdVrr5F2RCXrFNt3VnBI6xj8VapjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouC6PkmSd05C0WDbRUtGGW8RT2Fqfv GXF12/4HgsbJJqUzj/tHneE1rOexHOgB9p6+LuQ+vxqw0aagUMpOhw6RGebrfie0XGkVIcKQ 6AT0m90xUQoz2SLQ9/nTluHqXiLlhcGXpxbFOhSwAOQzqvZ5S6JC25CSSROAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9BWMLeyIsVwYO5Njn5oYpgXrnUdJLAKOzyNrvFlnNL yuiqSE/g/AfiJAN3qDjoVTf2Wrw+N7OUxI/4RjRUiS99ARlaYW5Zouur1/G8fJHK4XfRV6E1 JQZp/WjACk1JcnlvESwrC8lQNlFO97t3OXgvGNS IronPort-HdrOrdr: A9a23:CoDWiK/0OFhMDAdNvMxuk+F7db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuCKlaDPY0LDErXQBeoR8bMtiA2Xkwltls9dm3K 1R2WWF85JREBPbhSz4o8PFThdwiyOP0DMfeX56tQ0hbWIyUs4nkWUkxjIiLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3f7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPbHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCD34Gyff+qaGj3iq9M1lVBw6du/22z6IJyoHUVf7sLTCJTkwono+pv+gfa/erKc qOBA== X-IronPort-AV: E=Sophos;i="5.96,151,1665460800"; d="scan'208";a="84918370" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SKQ1Jeppo2RCrRxErjaRRmeQhImWeKPEEORK5WFOEjaENMg2chcmwE02uLweK+DM/J0jg13WeXTa9LgYZKjBd+Zeq9f0vHvUgicNx10okEz7x9wOOsMB9H8FD4onVNtg14+Gt+OfOGczHQsHrWm4QzON6B532L0liZT/U8u9CFEHf95OAutZOFy+Z2+1wxnbNKfiJUiNrzeUuDJnTkzd9Fiv8dpaOhaw5bbZmSICvNvRKK8azcW8Uum+pCU1Qb9adt8Zyrl0E3xYuquXWZ7GePVtWRzEbALI2CrA8Lkmefxu6PE8+L57UbN1L6r0PGUS38xBzoJ0om5WiMEyYFn54A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d4dAEgVRnGT6vctPCLk+AFIjAqguSpc7AsekpJ7o1ek=; b=KTm04TF33JXnqpHkcc0GkFfKsOKg37DkAa3Z/L2qvxuNWWndlEfRWl5Dnwd9OMMxK2wPJjNvG/W9cP/SVOkNT8yBVatgfho4HQI8DUBQTvSg9B9nc0EWHEhKXRpIktVlbchjPV7YqIb+1n3yDYjAznUhF3yM6YJgFCePRX9HJ+x9daT0NO0rVdozjw5KC5CNkH81avgTpOzbVqZWxKTXe/YWLms5vdUhbusdO0DEV5UTsXnOH1runfvCpciRTRRggKdZMTv7PEPAZefoArDMB17dDYtfPaAw9LNM/CKzPg7l6CW+hDp2qOytVvpPSk7vxiqc8uTsSKOI4G3RXOFx+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d4dAEgVRnGT6vctPCLk+AFIjAqguSpc7AsekpJ7o1ek=; b=JZYTezcYcX3216CsnspjqYmwrZPIoGVk7/MsrHWERB5cGYHDGml6TtsvgtBlfvGA30cgKQT/aRd9g2NloA/IJ8iTdAex4aNlgfuJqg6pDkHkSz8P0UV6OpUva24eyHWu1nWYURWwgNHUOPbeSekh/aoMNEIMNM1CL/pdfhop3bI= From: Edwin Torok To: Henry Wang CC: Julien Grall , "xen-devel@lists.xenproject.org" , Christian Lindig , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Index: AQHY84fA+Ym2JRve3kKJcIO1APAKeK41MEgAgACx3ICAAML3gIAAI/qA Date: Wed, 9 Nov 2022 16:27:02 +0000 Message-ID: <8C257640-9021-4036-8E5F-A085D53CAA60@citrix.com> References: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> <0B9BA046-5FA5-42EC-9959-63F15B833E91@citrix.com> In-Reply-To: <0B9BA046-5FA5-42EC-9959-63F15B833E91@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|CH0PR03MB6033:EE_ x-ms-office365-filtering-correlation-id: 43004ee0-d7e3-456a-7ff7-08dac26f3bae x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eBxK6Q2a7JfrqqmumOrYitWlsvJcY56PIQDRlJUct+64g4IlxmwJnvcayzuZhFHgsM0SpcLJGnaigfIpb9TfmsrGrDwCu1qbIDydJwTyZxxMoi4PpdW3EA0ZhkzBbGXC6a6VpxL16FIQ1814iGJyYZsw7HcWcU/H4W2Zz50nKFPSE0HOgECnAunn2Jx45wjdB07KJKpkg/yW7LoIBzmr9c3CiSMalouwpQszPMzu6+8cZsk3VcP4bc2iqePaadGihFrVM63mUX/jBbUKVP62lVwVPqhdWlKjifuiRwX0wH8uZJccML0nus+dRe9n4F4Bq1PTi8IS8IigDCFIXYqHaZfpMMyd6cAh3Xy/c3DfyOt14OensTTdAVzbN4q913BI0squ1Y3BhZ9LptCqyQa2xwcMRFuPLnVDgBiuHuNvMuo8P7FaAQ/f3b42E5JZ+ebw2eLKKxNn4uqEDrJn0KFXK5QCGYPFY52mTsf3bWtJrjtlg1cXOKbELh9JOuU4EHAIswlFO+gdg4unxYcvi3Z1KhFPCW03dKKeXeF6VZxQFL4CQnWJhh8qMer3IcE7gC9vlXfk4FgyAsnGKpv+12WBNpzRMvd5bHi1QcvBtq9gMKyG2LHSKv64SnqjEmcsHGbZfyyx38DvexhlDtIR5C+db/B0yCFLwEMWkaKKa5Njbk94rwn6waY4ijAy6v6teZETLr+Z8DNST1kA3MDZCY90DNMUa/ax62zdlDRxgKCbQeEKgU9n7yxX9XcwmkP7nXrlfLf8d8+87TzRnOJaGa8AF89o10wuotdBa+Y0bDFpn5bS3xCxnf/zFbfckfPY0zX/VB96utKKOTe68fc0wJebar1TcwozbSoCIFy/HEQd6+erPkguXqXcdzE1vGySdBTD x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(366004)(396003)(136003)(39860400002)(451199015)(478600001)(6486002)(966005)(6916009)(71200400001)(38070700005)(86362001)(122000001)(38100700002)(107886003)(82960400001)(316002)(54906003)(186003)(26005)(6512007)(36756003)(2906002)(2616005)(76116006)(5660300002)(91956017)(6506007)(4326008)(53546011)(8936002)(41300700001)(64756008)(66946007)(66446008)(66556008)(66476007)(83380400001)(8676002)(33656002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4jXeuuXsGR1Uq+K5u83ZpTH95FU6b9zpdvJuCSX2euFdL/Qh6wd9o5Sdz6RA?= =?us-ascii?Q?e/BQNaUOKg9dSwRTegATyRcoGKMnznN5teuZxBqAlXQSEdlBEJNuO+OnYVga?= =?us-ascii?Q?NA4pwIWe+ISruvwfrSPzk3oFyr9O/sj6PNuClshyhQ0SicF6Sax+SlS9YXuC?= =?us-ascii?Q?y5agZyNAQrwv+GGl5vkn302MyUQQ7Asno3n5SlUPF9v1LpRXd7hfCkGwbcNq?= =?us-ascii?Q?pwi1pa+VHujHPyHaWgc6Li6Ki6x0M9zB9odWVpZbFl4qX9DimhUL2loFGc2H?= =?us-ascii?Q?4fpIBWpcHbSBEtfrpnhyZr7/Iwwo7uHG9E9dXeEYNjdsoBWUc1GDKXjbODZh?= =?us-ascii?Q?vtFLBWFsbsITZ5w6B0bMIeRW5AKk8tnHMI8xR54OkOkOoaCbZUM3koZ7zrkd?= =?us-ascii?Q?7exnTP8vmqBkco1b33O/P1+aRI/sGXE/cE9XUZqSvF9vuCXMbxt/PrQ26nnV?= =?us-ascii?Q?+1/xvVh653JhqukPdm9jhiomRvcxFUJCgCaMUyr/4uqLP8VYXLgo9Wry2uOy?= =?us-ascii?Q?p5uJ21myxFS+CxrUcbZwVKn4LaZQuH7qp857vsjvf5bFk5g+wSsyy9UYTvpf?= =?us-ascii?Q?qvMxm+aeminOIgIOrZmXq/ZJfgqrG0ZysQJ/sBvJUtjsmuqKZo4TUa4os1gn?= =?us-ascii?Q?kozTXbb3/0qR8zh08ieMMT+56HvXaWk3q7QgU2n5HwvLUWp+jIWuvgtaRYpy?= =?us-ascii?Q?t036CkzbG+qbRnAecxaXq7F8hdBb9qXlwoB0hdb2lLduyHKVKbmsvsJ2S4Nc?= =?us-ascii?Q?RkhlOfnfualihhvhqGt53pCp1tezB0J4X1WnnV99i6jmvHOSzgGtGKqA2V5y?= =?us-ascii?Q?CEdOs2MoNnmT2pnbUV6vGa1AaC+6a1y7+Ll9NsH1zq34cz8v89elzUHL6cjp?= =?us-ascii?Q?ff6SVuGDR0b5Gl5wsHs/P2RS+JjC/K5QcIaKW2mfia0gqs9EJaY1hzsjaKx1?= =?us-ascii?Q?WGCJU/1lpoYEPIyy+5pw/Pie33Bt/GVqZ1xs5ratd6mUvJTWIyC5imCjF6X6?= =?us-ascii?Q?x0auxO5krVeG+5sAvntvPQuXjPQbuRdfE7JW21EXxpACV15QqGcVy+a4/mll?= =?us-ascii?Q?SQB1QTgCtQFcnL2ODikzwZ28If770u2lER6w6zGI7JXFZLOHWVfAm7z55bkU?= =?us-ascii?Q?L/NOWIFvGk7BCshHETdKrIfEElBt1v7t0f82lM+qt7CL3LI24SzoNV794bb9?= =?us-ascii?Q?RJXNi8s4ZRZ8nsYxSjJWanT7KbrKYNehnpVLJ1uQiAVzP1OQ0g4Ddi7UY/ZB?= =?us-ascii?Q?2ahxtTh5FPm5RcgbrqneJI6tSB9/HeZjt3RnZ33DVLhhbDyfVRtTDJyBwCIV?= =?us-ascii?Q?NGaSt1XGt6qNQ4tx+PzZaH3wBxaYKhpWkeobKYmPePBa0eIKic9ZptcTszi6?= =?us-ascii?Q?KSzFKQHkgR5+A9IRsm0fpNY+TjMAUF5zS6tbk7tLdMc8gaFVlM5WdMraq8Xl?= =?us-ascii?Q?Pc+s7/++Isc8HhcPm7HkSeryy/k/xmrvi0pZfI+2a4OalXcg1Kt+o2fY3SdI?= =?us-ascii?Q?qFz8SWEOsLZByJz63/jxltCxhp7aAr7Jn+yy2MW5NaQozQ39laIopYmLvxDN?= =?us-ascii?Q?xA+IBiZom6rs068dpSjA3pWugAFOljyOWCRVJlaFHBrkxfvILFsO5tR5VFmL?= =?us-ascii?Q?2w=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <2E3358863A041043A53BF182812D22E1@namprd03.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43004ee0-d7e3-456a-7ff7-08dac26f3bae X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 16:27:02.4327 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w7nO+CsquVhEYt0rQD3KRY7ZyIw2V36NPMxyXP2Pw7Yk/vcYMsyBgdZOR2T9b/EPxKl+kyCQZLuIVGIT9QxzXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6033 > On 9 Nov 2022, at 14:18, Edwin Torok wrote: >=20 >=20 >=20 >> On 9 Nov 2022, at 02:40, Henry Wang wrote: >>=20 >> Hi Julien, >>=20 >>> -----Original Message----- >>> From: Julien Grall >>> Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add >>> 'make format' and remove tabs >>> While I understand the goal and support, this seems to be a bit too lat= e >>> to do it in Xen 4.17 (we are only a couple of weeks away). At this stag= e >>> of the release we should only do bug fix. >>>=20 >>> This is clearly only a comesmetic change and there I would argue this >>> should be deferred to 4.18. That said the last call is from the RM. >>=20 >> I agree with your point. I think maybe defer the patch to 4.18 is better= , >> given the deep freeze state we are currently in. >=20 >=20 > Indentation can't really be trusted to humans :) >=20 It might be better to consider oxenstored unsupported in 4.17 at this point= and try again for 4.17.1 or 4.18, it is probably too late to fix up all th= e bugs that I keep finding in it in a way in which it can be (security) sup= ported, although I thought the goal of a release candidate is to try and fi= nd bugs and fix them before release. But doing that while also trying to keep whitespace and indentation changes= out of the patches (or trying to keep the patches small), is more likely t= o introduce more bugs into it at this point rather than fix things. I was not able to do or send any of these patches sooner because the XSA-32= 6 and XSA-115/etc. work in the past years has prevented any other kind of w= ork from being sent (it'd have made rebasing the XSA series more difficult,= and/or reveal the XSA as part of various other changes and commits), it is= unfortunate that there is a release quite so close after an oxenstored XSA I tried fixing up the rest of the series to not depend on this patch, but w= ithout an actual 'make format' rule to give it consistent indentation it is just too error-prone or risky to fix it up at this point (I don't rea= lly mind whether indentation is tabs vs spaces, it is the inconsistency and= non-automated nature of it that is the problem), e.g. it is quite easy to accidentally duplicate code, or get the code in th= e wrong scope, or introduce bugs like the one I just mentioned before when = a new statement gets inserted and the code seemingly looks ok but its seman= tics is entirely changed (and that is hidden by the inconsistent/non-automa= ted indentation). Perhaps by trying to merge some of the changes/fixes from https://github.co= m/mirage/ocaml-xenstore and getting that production ready, which is a much = better codebase to start from than the current one in the Xen tree.: * it has actual unit tests (which I tried to introduce as part of a securit= y fix for the intree version of oxenstored but got repeatedly discouraged f= rom including it to not make the security fix too large) * it was not vulnerable XSA-353 * it has fixed part of XSA-326 together with a unit test nearly 10 years be= fore Xen project rediscovered the same bug and realized it is a security bu= g in the in-tree version: https://github.com/mirage/ocaml-xenstore/commit/2= 1e96654c27c01cf52e5d7aabc5ee53e07f2cbb7 * (of course mirage version has never been used in production so it is enti= rely likely it has *different* bugs) * in-tree Xen is difficult to contribute to:=20 * it has a broken build system that keeps throwing 'inconsistent assumpti= ons' * it has inconsistent and as we can see sometimes wrong indentation * patches get posted to the mailing list and sometimes lost (e.g. https:/= /patchwork.kernel.org/project/xen-devel/list/?series=3D339731&archive=3Dbot= h is still not committed), and I'm fairly sure I've seen an ack somewhere, = but patchwork can't find it now So I think oxenstored in 4.18+ will likely be sufficiently different than 4= .17 that direct backports won't be possible anyway (indentation changes or = not), so having this indentation patch in 4.17 wouldn't really help much. The disadvantage is that we lose all the bugfixes in the patch series after= the indentation change, but if we consider oxenstored unsupported in 4.17 = that may not matter. I can resend this patch series for master without a 'for-4.17 tag' and keep= doing development there. Best regards, --Edwin From xen-devel-bounces@lists.xenproject.org Wed Nov 09 16:55:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 16:55:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441086.695361 (Exim 4.92) (envelope-from ) id 1osoMG-0005Xe-V4; Wed, 09 Nov 2022 16:55:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441086.695361; Wed, 09 Nov 2022 16:55:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osoMG-0005XX-SM; Wed, 09 Nov 2022 16:55:24 +0000 Received: by outflank-mailman (input) for mailman id 441086; Wed, 09 Nov 2022 16:55:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osoMF-0005XR-Ei for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 16:55:23 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a5c8604-604f-11ed-8fd2-01056ac49cbb; Wed, 09 Nov 2022 17:55:20 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 11:55:12 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by SJ0PR03MB5710.namprd03.prod.outlook.com (2603:10b6:a03:2da::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 16:55:10 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%5]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 16:55:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a5c8604-604f-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668012920; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=yR5paNWa+S9Aw2macB++WyQPB95hLTRGgA3wffIcHwk=; b=Fv1AKMXCIJAuk7wJrTzspdzXvUdqYdEKRlxQ1RKX9gFvhkqupvLafIPR /i0AamjhOepQV8qLoojOsQwIoU1M/kAslD//XVNYMVtvUvI33/jzksoYg E4flNr/ZnxbKQ6mHgTO/jhWdtqXpcbwUo9E9mh5UasgUqtbM4VRbCGY16 A=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 87028958 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:e7HdzKq9V3eokdpFyPLKYE9E7HpeBmLbZBIvgKrLsJaIsI4StFCzt garIBmDaP6ON2HyfdFzYIq3pkhT75Hdx9UwHARvqHo2ESoS9JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzyhNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACFUc0qYosKN+6imYK5mv4MgduOxPapK7xmMzRmBZRonabbqZvyToPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYSFEjCJbZw9ckKwq 27Y/mK/HhYAM9+3wjuZ6HO8wOTImEsXXapCS+Xipq830DV/wEQiKQEOBVqYnMWooXyeC88GA UMkxTQh+P1aGEuDC4OVsweDiF6JuAQNHeVZFeIS4RuIjKHT5m6xBHUATzNHQMwrsokxXzNC/ k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMt79D9rakpgxnIT9IlF7S65vXqHRngz jbMqzIx74j/luYO3qS/uFrB0zSlo8GQShZvv1uHGGW48gl+eYipIZSy7kTW5upBK4DfSUSdu H8DmI6V6+Vm4YyxqRFhid4lRNmBj8tp+hWF6bKzN/HNLwiQxkM= IronPort-HdrOrdr: A9a23:5C2dOqBzWSSiC8rlHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkWwqc5Ew6sN5m1q VXm2qfqppMFBvF2D/w/t7SSnhR5wOJSepLq59ts5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7gSwlGl/NLAgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vcPHmZw == X-IronPort-AV: E=Sophos;i="5.96,151,1665460800"; d="scan'208";a="87028958" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XKTlLx8q4w1b+mybl7U7t4qqBvv6LQkb9391w/OK28iZvasLz61bO8PAxlzNJcgDQ4B/C5OvUK2zzaNG8OJtE7N4SyO153tGH0njKclhA3F36Sr6e1kis/E8uoapfISAiVJKIM6aRm8i04bnJum0mrQyGls8E+bgqOWGJ1huzyqydJaG0FAjkzYYloJX39889BHfKMcSjrpS1m5gwaxL8VGRvN8qfOqJSyqPShcPgFIvs4XI42UKsGIbEX3KB2RBChthLMFkVagaTnH24QfHlgais/tvrDMK50YjTAGligZAycv2+c5WclSgsmct3mZ4uUE/FBpRmWKPtutdgsg3YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yR5paNWa+S9Aw2macB++WyQPB95hLTRGgA3wffIcHwk=; b=jwF3A9HezemY1NShsgdSXCtST6C9iTcGINHq5s/7O6t2NUx/64zOM1dBfP/eLPiALClWVauELuztIKDFETtxl+uJxZbKgVm9SRXrnyVAc84yp0ujlpON8sFEvsyFI2Xe2kxbuyNhrLEnpzLag5m4eZJfTKK53zACuVa7dMWH+3qnDNdwzlo1XXMWLdZ5G8KrbEdx6+E29+qmZVqYNmokMyS4moKfWcauMEVnQfpJ6TkfTIx48CQK2x6IourAOCjcakm8eyT7yvq7oEQyfHQNh0nlemma51PCi4SxMVtCVg29nseM/6dkdBKBrpMRUqFBc+9gUn1WEarPpHglnKK2oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yR5paNWa+S9Aw2macB++WyQPB95hLTRGgA3wffIcHwk=; b=Hic5CUMJ7WC5kp2JKABNCh2Yb2sV6L2dhK7BTjKfIbBZxzfbbP/zHbObj+q0yphXePJ/6CY7TM4032QO5B5LjW0qNbuGvx1e/JeKSVuOc/DJaYUiAz6Zws4i1tiSMcHf+B8PeKK8qtsJ3IKDPxcbY1FAl8MFnwdVXhvUAoR6fjg= From: Edwin Torok To: Henry Wang CC: Julien Grall , "xen-devel@lists.xenproject.org" , Christian Lindig , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Index: AQHY84fA+Ym2JRve3kKJcIO1APAKeK41MEgAgACx3ICAAML3gIAAI/qAgAAH3IA= Date: Wed, 9 Nov 2022 16:55:10 +0000 Message-ID: <7A80AE7E-7D9C-491B-9109-ECA4C5C6B304@citrix.com> References: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> <0B9BA046-5FA5-42EC-9959-63F15B833E91@citrix.com> <8C257640-9021-4036-8E5F-A085D53CAA60@citrix.com> In-Reply-To: <8C257640-9021-4036-8E5F-A085D53CAA60@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|SJ0PR03MB5710:EE_ x-ms-office365-filtering-correlation-id: 6711b545-7796-4039-6fc1-08dac27329de x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: o6wWd2V5lS/Mr3YXptkHKE36X13hWhBsVFPgK59it1P3gBSMX0DeomAGVDqenQ2g0bKd4gtDhLBoOgh+E3ssixfRGIkbxpVb6p7Y/8/bTU9oaZ3LONzSmKHWXFsK1psCvgQj7yWSggS9hnVlnAQpEw1ZEyLzlnMNvJb/+NBXcAAN1LHsAp5do1lrJRbci8gK664MSWBNBhFuWNkqfekxDLG9ArSpRfOuAPwpRK/bTOLa79sHAhjOvXQiA+BqWNf/qvH0dNtxHEgOGFlgBcPMdb0gPx7bI3yYsTSTLU1nJ9G5EC7y4wU247bbVvnkVZXtPSGjP0KmW5m13uh0jGEzeMxuOU6c/gLP82wjN6PHRN7c2HXwYoFheiWlf+G+zc1roJok0nHnsXOAcAUqVhImXkniXjLlh9MTBFNOp6DtVUpX9vrxQvv7F99qPRv3xS/JP7eqgSLLzX/p0RpZGGjO2ba2QilhrFW2JWnYaUdyCgpTtwTkP+dWBQXkhtZniFb5KzqwGPQEYi7fordhv1cHKND6ZTi4y9mfDFvC9wjFglAPygQ4L8b2jHhsxlZGzK+Lhh7C8gaAhuFZmUPgXRf/kBtatio7FwhgiEXDtxtK5kUF0jFnp1iIs18fJTP+6EoQVuJhB+safuAYTxgRK9UojGhb9Z/N7iObubxQAal45eKoebFJ4pufaeev1miw9ZtBi2m8Ymqe68EIa4JzdvodMsczfMh1uiTODHbtXZmqgSsZ6YSYi5px024T44u0L5MtSRQGT9yYXKaOq8f5rurbiXwx1+uvtdPyJhlBHjvpWdNc3BOT8E9qh9pEcZlMUewu+ettGMU4jZnGmY4Frv4LOQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(136003)(366004)(376002)(451199015)(82960400001)(66446008)(64756008)(71200400001)(66476007)(478600001)(6486002)(38100700002)(966005)(76116006)(33656002)(66556008)(66946007)(91956017)(38070700005)(4326008)(41300700001)(6916009)(316002)(54906003)(8676002)(53546011)(86362001)(6506007)(6512007)(26005)(66574015)(186003)(83380400001)(2616005)(107886003)(122000001)(5660300002)(8936002)(36756003)(2906002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VmZ6RC9xWW5vNlJmSzdTR3N3SmFtVnlSM0xzU2tMRE5HOEk5THdpTyt0VWVN?= =?utf-8?B?SVF0WU1vaWo0SEtWRHB6VERYbXNXTjNTci9jcGh6UkpnaXZJOGtTd082LzFu?= =?utf-8?B?K2x3cmJwaDhjeS9TZDhTNGdLeVE2SUJPNGxZZ1R1dlNiMXVLS3Brb3BpWlBo?= =?utf-8?B?ME51dmRqTmtDOUVJN09GNWllVFVnczc4TXl6Q0l0N3FUOFNEMFowMmI5dCsw?= =?utf-8?B?Y2ZPRlNBdnBkbnNUNjMxdFUxdnV6S0hrc3F6ZHREb0N5ZlI1V0ZpWXkzVUNH?= =?utf-8?B?dzBJcThjVFdONGFIMUpLR1YwT1pvOTZNZ0RDQ29oc0ZCRE14cExrZHgzUmhu?= =?utf-8?B?eUJGMWxFNUVUU2JObjJuMmw0T0dBOUJkcnBIZEVyL3R1MGlDcnloTjBzaFZQ?= =?utf-8?B?OFBEZ3R0SU5mMjY3T2trSnhLTkhkK010aG1TRFV4UnA3NnlmdUJwNnVlb1ZQ?= =?utf-8?B?cENkbm5laUhNa05JTS9KeDVWRU8vZmEvQ05RR2JOMGdWWHpUSjV4N1dQOTlE?= =?utf-8?B?aW5jRjVhZEl2RFpQdTdNWWlvaldPcVBsd2FWSFdINEp0VzQvTzJGeDV2RGQ4?= =?utf-8?B?VjEvaVYzUE90RDBMbFpZTlk0aXJ3c1RpRVdWNXpiOVB6ZHlZN3NtVUoveW9m?= =?utf-8?B?cmhEWHFRR3hwbS9NV1NRdm9VK0pvWFR3Y3QrenpCQ1YwRit1RUEyaE4zd0Nx?= =?utf-8?B?c2UyWS9Kakw1WGZDTmttMWxQYS9UbEVRVll2c2R4R1JIYUVqUWRVYXRWTWx0?= =?utf-8?B?dHZzNHJoVERGTmxveDhsL3NJaHh3emc2dmJ4NTFWdUNXcFFRMVFIdjNIcnMv?= =?utf-8?B?UmIwLzFSM3RLV0JnWXZCUWozV0loTUZ3QzhNSG55dW1ZK0h3ZkV2NmV5T0hs?= =?utf-8?B?am0wZWhrRjh5UlhNMW1hVTlZWTIzNlYvd1ZQL3VmSHdWNkJKMGtJYzRjakY0?= =?utf-8?B?UlVoK29FV0NvQm0wcW5janBHMG44LzhZQzVNNXN6YjRJNjdISjFhRnovL2FZ?= =?utf-8?B?ekdjM0dJTmdNYVRmK1ZnUVlTY2w2QzhENWRWZkpKRnlnNkFnYnZtd2JDd080?= =?utf-8?B?SENSdkxURmNnUVhEaFlLbVJEMEIyZjZLZ3pMU2lQaFdrbG5TLy9LL1liWWFN?= =?utf-8?B?U1ZHTVA5NStXdTlSRkx5UVBFSXA3NDJQUFJjbWgxaU1nRUM0M3h4a2h5b0ow?= =?utf-8?B?bEZiWk14YTVtcXF5Q1IzV1ZGaGRYQkNaUHp6enpaVC9GbjhPTzV5Qjl1bTFv?= =?utf-8?B?V3k3K1YvN2t1aEc1OFcwdHVpdS81emtCL1JmYmRNRGZ6QjRpOVl6N3hmZzdC?= =?utf-8?B?amlTY2lJaUdFWFBNaEloVkR5eXYrVk1BaUljWHJBenYzSDd3RE4vU2dON1ZU?= =?utf-8?B?Ny9hbXJJVmVxcWhldGFrcFZjOTUvSzlnb3ovR09PN1RxbWN1NXNRWW9Ta2xU?= =?utf-8?B?bmZadlRnZGR1aE10Mmd0Sks3ME1NUVZsR0FQNmxKS3NqZWFjdU9TalNZSXYx?= =?utf-8?B?UFgxRDAxZ1ViMzBPRkY3SkV6ck9EUW5JeHpPdEVJVjdBRXVvSjF2azlvemt6?= =?utf-8?B?V1NUOWtEK1U1NEEyMnRrY2FZMk5XNkFleU53cGlFbkQyL1B6OThkeXZaaEY2?= =?utf-8?B?citOVjY1WHVoOFJjYlAvTExsY0NJa3l3L1ZtUG93Vk9OUC9OL2lFMEoxSTh5?= =?utf-8?B?Q2dVWHVVMGE4blVkMzJvZms3S1RuL2NkOUduNGtyNHNvTG1paVpFYW84WDh6?= =?utf-8?B?R0ViS1NuNjdSQk1GUERRQXNqNjd0b1h1MUZncjJwQ1U1OWw4SUpWNW9wOVhu?= =?utf-8?B?cDg2Nm12RXV5Z1I2bUhSSnhkdGt3dncwNFkrd3Axb0R0MEN1d2RCK2lUQWJk?= =?utf-8?B?WW9odzRlWHVtMUNNVzhteEJmNEc1NkJZaTlRalIvTEZrSS9TUFJiaVRlNHFD?= =?utf-8?B?aEg2UFpwVzlULzg1ZTJ5VWFRWWFtcEswK1hRczhBRjFqdmdlY2hLK0dScnhZ?= =?utf-8?B?SEZMMUdtTW5wTFdpTWNWNjBGZVFYWFZPL3hGaFB5UGlCekl0UWFvT1NxUTY2?= =?utf-8?B?cGNnQWJ0ZEtoYXo0SEZlOU1GeWdsMWwxZUkyQ3FGcmhnOExGZzB5R0tjYmFh?= =?utf-8?B?a3FjbWJNWXUwVWJSYTlNcmpjRzlCaXJrOXJBRTh5dXFQNUZtZ0E1ZzZ4N0tS?= =?utf-8?B?WWc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <234E444792D9B84B9264D6B0627EC065@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6711b545-7796-4039-6fc1-08dac27329de X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 16:55:10.5505 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YcXtCAELjwEbzCKAEh3FpT0ht+F/coiV6M58v4Zy5U3HFk43YlLHrNHR4YDjWzb2kAM9CkBebVGC1kEaegAiHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5710 DQoNCj4gT24gOSBOb3YgMjAyMiwgYXQgMTY6MjYsIEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9r QGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gDQo+IA0KPj4gT24gOSBOb3YgMjAyMiwgYXQgMTQ6 MTgsIEVkd2luIFRvcm9rIDxlZHZpbi50b3Jva0BjaXRyaXguY29tPiB3cm90ZToNCj4+IA0KPj4g DQo+PiANCj4+PiBPbiA5IE5vdiAyMDIyLCBhdCAwMjo0MCwgSGVucnkgV2FuZyA8SGVucnkuV2Fu Z0Bhcm0uY29tPiB3cm90ZToNCj4+PiANCj4+PiBIaSBKdWxpZW4sDQo+Pj4gDQo+Pj4+IC0tLS0t T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+Pj4+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhl bi5vcmc+DQo+Pj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggZm9yLTQuMTcgdjMgMDcvMTVdIENPRElO R19TVFlMRSh0b29scy9vY2FtbCk6IGFkZA0KPj4+PiAnbWFrZSBmb3JtYXQnIGFuZCByZW1vdmUg dGFicw0KPj4+PiBXaGlsZSBJIHVuZGVyc3RhbmQgdGhlIGdvYWwgYW5kIHN1cHBvcnQsIHRoaXMg c2VlbXMgdG8gYmUgYSBiaXQgdG9vIGxhdGUNCj4+Pj4gdG8gZG8gaXQgaW4gWGVuIDQuMTcgKHdl IGFyZSBvbmx5IGEgY291cGxlIG9mIHdlZWtzIGF3YXkpLiBBdCB0aGlzIHN0YWdlDQo+Pj4+IG9m IHRoZSByZWxlYXNlIHdlIHNob3VsZCBvbmx5IGRvIGJ1ZyBmaXguDQo+Pj4+IA0KPj4+PiBUaGlz IGlzIGNsZWFybHkgb25seSBhIGNvbWVzbWV0aWMgY2hhbmdlIGFuZCB0aGVyZSBJIHdvdWxkIGFy Z3VlIHRoaXMNCj4+Pj4gc2hvdWxkIGJlIGRlZmVycmVkIHRvIDQuMTguIFRoYXQgc2FpZCB0aGUg bGFzdCBjYWxsIGlzIGZyb20gdGhlIFJNLg0KPj4+IA0KPj4+IEkgYWdyZWUgd2l0aCB5b3VyIHBv aW50LiBJIHRoaW5rIG1heWJlIGRlZmVyIHRoZSBwYXRjaCB0byA0LjE4IGlzIGJldHRlciwNCj4+ PiBnaXZlbiB0aGUgZGVlcCBmcmVlemUgc3RhdGUgd2UgYXJlIGN1cnJlbnRseSBpbi4NCj4+IA0K Pj4gDQo+PiBJbmRlbnRhdGlvbiBjYW4ndCByZWFsbHkgYmUgdHJ1c3RlZCB0byBodW1hbnMgOikN Cj4+IA0KPiANCj4gDQo+IEl0IG1pZ2h0IGJlIGJldHRlciB0byBjb25zaWRlciBveGVuc3RvcmVk IHVuc3VwcG9ydGVkIGluIDQuMTcgYXQgdGhpcyBwb2ludCBhbmQgdHJ5IGFnYWluIGZvciA0LjE3 LjEgb3IgNC4xOA0KDQpBaCBJIHNlZSB0aGF0ICdMaXZlIFVwZGF0ZScgZm9yIG94ZW5zdG9yZWQg aXMgYWxyZWFkeSBtYXJrZWQgYXMgJ25vdCBmdW5jdGlvbmFsJyAoSSBpbmRlZWQgcmVtZW1iZXIg c2VlaW5nIGEgcGF0Y2ggdG8gdGhhdCBlZmZlY3QpLA0Kc28gbG9va3MgbGlrZSBub3RoaW5nIGVs c2UgbmVlZHMgdG8gYmUgZG9uZSBoZXJlIGZvciA0LjE3Lg0KaHR0cHM6Ly94ZW5iaXRzLnhlbi5v cmcvZG9jcy91bnN0YWJsZS9zdXBwb3J0LW1hdHJpeC5odG1sDQoNCkkgY2FuIHRyeSBmaXhpbmcg dGhhdCB1cCBmb3IgbWFzdGVyLCA0LjE3LjEgb3IgNC4xOCwgd2hlbmV2ZXIgdGhhdCBvcGVucy4N Cg0KQmVzdCByZWdhcmRzLA0KLS1FZHdpbg0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 09 17:22:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 17:22:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441095.695380 (Exim 4.92) (envelope-from ) id 1osomm-0001La-8u; Wed, 09 Nov 2022 17:22:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441095.695380; Wed, 09 Nov 2022 17:22:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osomm-0001LT-3C; Wed, 09 Nov 2022 17:22:48 +0000 Received: by outflank-mailman (input) for mailman id 441095; Wed, 09 Nov 2022 17:22:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osoml-0001LJ-4U; Wed, 09 Nov 2022 17:22:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osoml-0003Vx-1e; Wed, 09 Nov 2022 17:22:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osomk-0007jA-GH; Wed, 09 Nov 2022 17:22:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osomk-0004M9-Fs; Wed, 09 Nov 2022 17:22:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lS8RIW03R5vm0KIQeLi7sCuAclOJzhz1jEtJ9q0vm24=; b=quGvllMaZXcklY2xOFtUFi5UA+ GfNn8JpjNlzq1U9PFdDVAQZChUw/rWpu/LvBrgl/pa8HV4+EuXr40BOJ3TRc+m3ilZkY9n+fiFJwT aV1ZrRGBo8Z01T09U5GgjaC9KEAdsEd1JtBhvwLcprgMiWK8HUHuB5KOkcuQCkaBSnFg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 174678: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.16-testing:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c1e196ab490b47ce42037c2fef8184a19d96922b X-Osstest-Versions-That: xen=1bdd7c438b399e2ecce9e3c72bd7c1ae56df60f8 From: osstest service owner Date: Wed, 09 Nov 2022 17:22:46 +0000 flight 174678 xen-4.16-testing real [real] flight 174693 xen-4.16-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174678/ http://logs.test-lab.xenproject.org/osstest/logs/174693/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-pair 11 xen-install/dst_host fail pass in 174693-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174568 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174568 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174568 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174568 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174568 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174568 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174568 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174568 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174568 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174568 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174568 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174568 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen c1e196ab490b47ce42037c2fef8184a19d96922b baseline version: xen 1bdd7c438b399e2ecce9e3c72bd7c1ae56df60f8 Last test of basis 174568 2022-11-01 15:08:20 Z 8 days Testing same since 174678 2022-11-08 18:07:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 1bdd7c438b..c1e196ab49 c1e196ab490b47ce42037c2fef8184a19d96922b -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Wed Nov 09 18:24:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 18:24:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441104.695390 (Exim 4.92) (envelope-from ) id 1ospkZ-0001AU-VI; Wed, 09 Nov 2022 18:24:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441104.695390; Wed, 09 Nov 2022 18:24:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ospkZ-0001AN-Sb; Wed, 09 Nov 2022 18:24:35 +0000 Received: by outflank-mailman (input) for mailman id 441104; Wed, 09 Nov 2022 18:24:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ospkZ-0001AH-Bm for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 18:24:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ospkZ-0004tj-1x; Wed, 09 Nov 2022 18:24:35 +0000 Received: from [15.248.2.52] (helo=[10.24.69.10]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ospkY-0003MC-RQ; Wed, 09 Nov 2022 18:24:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=9zMIK7DpsgJeo5tLKbfv50cp3mrgjzZTkT6a662sn1E=; b=D0hf34bApVmLBs9RgNJq8S6/e8 Am8tKuNA0BI2IY9r5u50aeNzCrrIWWkMqwRcqN5pdypLLporYvTKfFPiHYV3c2ZaMtzHaKdWWdpOM cr+UqBwCdellft3JDIEjJudb3uk0B90kXPh5m5D1oy09SUavuhjylhMmRinLGMzcAm/8=; Message-ID: Date: Wed, 9 Nov 2022 18:24:32 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform Content-Language: en-US To: Wei Chen , "xen-devel@lists.xenproject.org" Cc: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Jiamei Xie References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-6-wei.chen@arm.com> <0ffe8a4d-7caf-89af-d189-a872b6b4f0fa@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 09/11/2022 04:55, Wei Chen wrote: > Hi Julien, Hi Wei, > >> -----Original Message----- >> From: Julien Grall >> Sent: 2022年11月7日 3:20 >> To: Wei Chen ; xen-devel@lists.xenproject.org >> Cc: nd ; Stefano Stabellini ; Bertrand >> Marquis ; Volodymyr Babchuk >> ; Jiamei Xie >> Subject: Re: [PATCH v6 05/11] xen/arm: define Xen start address for FVP >> BaseR platform >> >> >> >> On 04/11/2022 10:07, Wei Chen wrote: >>> On Armv8-A, Xen has a fixed virtual start address (link address >>> too) for all Armv8-A platforms. In an MMU based system, Xen can >>> map its loaded address to this virtual start address. So, on >>> Armv8-A platforms, the Xen start address does not need to be >>> configurable. But on Armv8-R platforms, there is no MMU to map >>> loaded address to a fixed virtual address and different platforms >>> will have very different address space layout. So Xen cannot use >>> a fixed physical address on MPU based system and need to have it >>> configurable. >>> >>> So in this patch, we reuse the existing arm/platforms to store >>> Armv8-R platforms' parameters. And `XEN_START_ADDRESS` is one >>> kind of FVP BaseR platform's parameters. So we define default >>> `XEN_START_ADDRESS` for FVP BaseR in its platform file. >>> >>> We also introduce one Kconfig option for users to override the >>> default Xen start address of selected platform, if they think >>> the default address doesn't suit their scenarios. For this >>> Kconfig option, we use an unaligned address "0xffffffff" as the >>> default value to indicate that users haven't used a customized >>> Xen start address. >>> >>> And as we introduced Armv8-R platforms to Xen, that means the >>> existed Arm64 platforms should not be listed in Armv8-R platform >>> list, so we add !ARM_V8R dependency for these platforms. >>> >>> Signed-off-by: Wei Chen >>> Signed-off-by: Jiamei.Xie >>> --- >>> xen/arch/arm/Kconfig | 11 +++++++++++ >>> xen/arch/arm/include/asm/platforms/fvp_baser.h | 14 ++++++++++++++ >> >> I looked at the content of fvp_baser.h after this series is applied. >> There are a bit of boiler plate that I expect to be part for other >> platforms. In particular... >> >>> xen/arch/arm/platforms/Kconfig | 16 +++++++++++++--- >>> 3 files changed, 38 insertions(+), 3 deletions(-) >>> create mode 100644 xen/arch/arm/include/asm/platforms/fvp_baser.h >>> >>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >>> index ad592367bd..ac276307d6 100644 >>> --- a/xen/arch/arm/Kconfig >>> +++ b/xen/arch/arm/Kconfig >>> @@ -138,6 +138,17 @@ config TEE >>> This option enables generic TEE mediators support. It allows >> guests >>> to access real TEE via one of TEE mediators implemented in XEN. >>> >>> +config XEN_START_ADDRESS >>> + hex "Xen start address: keep default to use platform defined >> address" >>> + default 0xFFFFFFFF >> >> ... this default value will need to be tested everywhere. At least for >> now, I think you can avoid the per platform header by using the Kconfig >> to select the proper address (see the config for selecting early printk >> address). >> >> This will also avoids to use an invalid value here. >> > > We had considered to use Kconfig to define the start addresses of v8R64 > platforms (prompt users to input the address). But we also want to provide > a default start address for each platform (Discussed in [1], header for > default value, Kconfig option for customized address). Why do you want to provide a default value? And how it is guaranteed that it will work for most of the users? > > We also had thought to use Kconfig to define a default start address > for each platform like what we had done for early printk in RFC[2]. > But this method has been deprecated. Most of the current Xen is board agnostic except the UART. We push back the addition of new one because the address can be found in the firmware table and I wanted to avoid increase the number of option (there are dozens of platform out...). > > So if we don’t use header files, just use the Kconfig, we can't > provide a default start address for platforms, and have to force users > to enter the start address. I am not sure I see the problem to force the user to enter the start address. My worry with per-platform default value is we end up to force each vendor to provide an header in order to boot Xen. I think it would be better to provide a config tailored for that platform (whether it is part of Xen can be debatable). This would allow a user to try a release Xen on their platform with zero changes in the code. >>> diff --git a/xen/arch/arm/platforms/Kconfig >> b/xen/arch/arm/platforms/Kconfig >>> index c93a6b2756..0904793a0b 100644 >>> --- a/xen/arch/arm/platforms/Kconfig >>> +++ b/xen/arch/arm/platforms/Kconfig >>> @@ -1,6 +1,7 @@ >>> choice >>> prompt "Platform Support" >>> default ALL_PLAT >>> + default FVP_BASER if ARM_V8R >> >> Is there any reason to create a new Kconfig rather than using MPU? >> > > Did you mean FVP_BASER? If yes, we want to give each board a MACRO > to indicate its specific configurations. In current series, this MACRO > only be used for board specific start address. See above for this. > > If you meant Armv8R, that's because Armv8R does not equal to MPU. I am not entirely sure to understand. Are you saying that an existing Xen can boot on Armv8R? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 09 18:30:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 18:30:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441110.695402 (Exim 4.92) (envelope-from ) id 1osppu-0002qo-LS; Wed, 09 Nov 2022 18:30:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441110.695402; Wed, 09 Nov 2022 18:30:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osppu-0002qh-GE; Wed, 09 Nov 2022 18:30:06 +0000 Received: by outflank-mailman (input) for mailman id 441110; Wed, 09 Nov 2022 18:30:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osppt-0002kk-Lb for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 18:30:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osppt-00050h-B2; Wed, 09 Nov 2022 18:30:05 +0000 Received: from [15.248.2.52] (helo=[10.24.69.10]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1osppt-0003RY-4V; Wed, 09 Nov 2022 18:30:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=9jGgnFjrBCgjGP16QoDrnZNh4rytMQX3PNDBvtEZAuc=; b=VkLkNTkVB0hcXucQY5dUJc3/Pp DILjLmsA/pjnWTNeAEoOxIjE2p7Ev0ZYXiJar1sIlFxmqXhU7HyEuiaiijoMA4AWiK2UyY9HT7Ju4 ADp+4R4SQdukMA9iQLivOw07uiWcTuM11uiglncAHRNLit8XaV3w1JItr3zojU4Trmdw=; Message-ID: <88350ef8-3f52-7535-b3e0-b2a76e8bc7de@xen.org> Date: Wed, 9 Nov 2022 18:30:02 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 07/11] xen/arm: implement FIXMAP_ADDR for MPU systems Content-Language: en-US To: Wei Chen , "xen-devel@lists.xenproject.org" Cc: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-8-wei.chen@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 09/11/2022 06:46, Wei Chen wrote: > Hi Julien, Hi Wei, > >> -----Original Message----- >> From: Julien Grall >> Sent: 2022年11月7日 3:45 >> To: Wei Chen ; xen-devel@lists.xenproject.org >> Cc: nd ; Stefano Stabellini ; Bertrand >> Marquis ; Volodymyr Babchuk >> >> Subject: Re: [PATCH v6 07/11] xen/arm: implement FIXMAP_ADDR for MPU >> systems >> >> Hi Wei, >> >> On 04/11/2022 10:07, Wei Chen wrote: >>> FIXMAP is a special virtual address section for Xen to map some >>> physical ram or device memory temporarily in initialization for >>> MMU systems. FIXMAP_ADDR will return a virtual address by index >>> for special purpose phys-to-virt mapping usage. For example, >>> FIXMAP_ADDR(FIXMAP_CONSOLE) for early console mapping and >>> FIXMAP_ADDR(FIXMAP_MISC) for copy_from_paddr. >> >> To me, we are bending quite a bit the definition of the fixmap. There >> are not many use of the FIXMAP within the code and I think it would >> simply be better to abstract the use (or removing it when possible) and >> avoid defining FIXMAP_ADDR() & co for MPU. >> > > I agree, if we don't mind to add some CONFIG_HAS_MPU in some generic code. FAOD, this is not what I had in mind. Instead, it was to provide helper which for !HAS_MPU would call fixmap and for HAS_MPU would do the work to map the region in the MPU. [...] >>> xen/arch/arm/Kconfig | 2 +- >>> xen/arch/arm/include/asm/config_mpu.h | 2 ++ >>> xen/arch/arm/include/asm/fixmap.h | 25 +++++++++++++++++++++++++ >>> 3 files changed, 28 insertions(+), 1 deletion(-) >>> >>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >>> index ac276307d6..1458ffa777 100644 >>> --- a/xen/arch/arm/Kconfig >>> +++ b/xen/arch/arm/Kconfig >>> @@ -16,7 +16,7 @@ config ARM >>> select HAS_DEVICE_TREE >>> select HAS_PASSTHROUGH >>> select HAS_PDX >>> - select HAS_PMAP >>> + select HAS_PMAP if !HAS_MPU >> >> I can't find any change of mm.c in this series. So surely this will >> break the build? > > Yes, in our internal testing, open PMAP for MPU will cause building > failed, except we add some new stubs for MPU system. Do you mean you added some stubs for PMAP? If so, I would not expect any caller for the pmap() to be used for the MPU. Therefore, why would they be necessary? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 09 18:33:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 18:33:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441115.695412 (Exim 4.92) (envelope-from ) id 1ospt2-0003X3-30; Wed, 09 Nov 2022 18:33:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441115.695412; Wed, 09 Nov 2022 18:33:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ospt1-0003Ww-W2; Wed, 09 Nov 2022 18:33:19 +0000 Received: by outflank-mailman (input) for mailman id 441115; Wed, 09 Nov 2022 18:33:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ospt1-0003Wm-2g for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 18:33:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ospt0-00054w-QQ; Wed, 09 Nov 2022 18:33:18 +0000 Received: from [15.248.2.52] (helo=[10.24.69.10]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ospt0-0003dV-Jj; Wed, 09 Nov 2022 18:33:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=3+XOca9yPvBad15eW4f5F21HtjgVK7yKFtv6Mh2y+DI=; b=q/N5KVf78SqafFagx4J2LbXfEa ASxYNmLSl/LYrlyjLMyJYIieZPxV6ksp0BIpQq3+tV6H62QlvZh2OFfSPYcRyRY/QHBHrnEJ/2HRr Z/prlLY8Abqsm4bmJHvumrYlbcw17bsEquu61zE/lSRYOTB/sJfsKn3pehX2owDKWLf4=; Message-ID: <5bbc68f5-0ec3-1a21-e2cb-92703fa338d7@xen.org> Date: Wed, 9 Nov 2022 18:33:15 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 08/11] xen/arm64: move MMU related code from head.S to head_mmu.S Content-Language: en-US To: Wei Chen , "xen-devel@lists.xenproject.org" Cc: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Henry Wang References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-9-wei.chen@arm.com> <5b975a59-5e97-c2a8-805c-9ab99b8712aa@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/11/2022 07:36, Wei Chen wrote: > Hi Julien, Hi Wei, >> The patch is already quite difficult to read. So I would rather prefer >> if the indentation is changed separately. >> > > Ok. > >> Furthermore, I think it would be best if the functions moved in the >> header are done separately to help checking (I would be able to diff the >> source with the destination more easily). >> > > Did you mean to create a separate patch for moving the functions in macro.h? I mean the macros in macro.h. Sorry, I misquoted it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 09 20:12:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 20:12:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441124.695430 (Exim 4.92) (envelope-from ) id 1osrQN-0008Nw-5F; Wed, 09 Nov 2022 20:11:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441124.695430; Wed, 09 Nov 2022 20:11:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osrQN-0008Np-1O; Wed, 09 Nov 2022 20:11:51 +0000 Received: by outflank-mailman (input) for mailman id 441124; Wed, 09 Nov 2022 20:11:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osrQK-0008Nh-Ox for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 20:11:49 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id baf7ab3f-606a-11ed-8fd2-01056ac49cbb; Wed, 09 Nov 2022 21:11:46 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 15:11:42 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5409.namprd03.prod.outlook.com (2603:10b6:208:290::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 20:11:40 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 20:11:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: baf7ab3f-606a-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668024706; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=I/GmRUIs0ZBdVCOdBUQ3r9oVmexp/wRq6r25pT5EQjs=; b=UnbTJ9BZwAPjuMWd3S2TYUEcu7jBmQ2dRodvOhXKVoOvJ+Avxm86Xsl+ ++EcZ/N0yDMoN6n87A4tqTaeU87oohGewGmYIHiibs8oikhNeLGRsb9zO ubSBbkoVXBOwFpOIlKZNg8vYYCcSzxjev7zgPns8aTcKgZGLyETNbr9Xj U=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 84532695 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jZqZiqLIS15LSFC9FE+RN5QlxSXFcZb7ZxGr2PjKsXjdYENS0jJRz GcYXm/TOK7eN2H1L4wkO9u08R5Q78eBndVrGgtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wRvPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5yUHtR7 NUHGAsrTTmYgdOxwYDkW+RV05FLwMnDZOvzu1lG5BSAVLMMZ8CGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGNnGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzX+mA9hMReDQGvhCg3CWm28CBj0tD3SL/eWVtVXud+puE hlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWXVHac+7G8vT60fy8PIgcqfjQYRAEI593ipoAbjR/VSNtnVqmvgbXdBjXY0 z2M6i8kiN07rcMNzbT9wlnBjBqlvJ2PRQkwjjg7RUqg5wJ9IYSjN4qh7AGC6e4addjJCF6co HIDhs6SqvgUCo2AnzCMR+NLG6y14/GCM3vXhlsH84QdyglBMkWLJeh4iAyS7m8wWirYUVcFu HPuhD4= IronPort-HdrOrdr: A9a23:cM6CHqN9T0FuHcBcT3n155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8Ar5K0tQ4uxoWZPwCU80kKQY3WB/B8bHYOCLggqVxcRZnPLfKl7bambDH4xmpM BdmsFFYbWeY2SSz/yKhjVQeOxQo+VvhZrY4Ns2uE0dLz2CBZsB0y5JTiKgVmFmTghPApQ0UL CG4NBcmjamcXMLKuymG3gsRYH41pD2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8F LCjxfy6syYwr2GI17npiDuBqZt6ZrcI+h4dYyxYw8uW3bRYzOTFcpcsnu5zXIISa+UmRMXeZ L30m0d1oxImg7slyeO0FHQMkDboUoTwm6nxlmCjXT5p8vlADo8FspanIpcNgDU8kw6obhHod V2Nk+ixu9q5Cn77VDAzsmNUwsvmlu/oHIkn+JWh3tDUZEGYLsUqYAE5ktaHJoJASq/sekcYa BTJdCZ4OwTfUKRbnjfsGUqyNuwXm4rFhPDRkQZoMSa3zVfgXg8xUoFw84UmGsG6fsGOu95zv WBNr4tmKBFT8cQY644DOAdQdGvAmiIWh7IOHL6GyWUKEjGAQO/l3fa2sRF2AjxQu128HIbou W+bHpI8WgvZknpFcqCmJVW7xGlehTMYQjQ X-IronPort-AV: E=Sophos;i="5.96,151,1665460800"; d="scan'208";a="84532695" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j0OtnUg7FQ0mP1QvoPFmb+aXaHX2y51tT9toOjgu7dKeVNbr+crGQ0vLquYg4M0YSBAWFOY2qXbd3xcrA+plW1Ye1ZS/BLtEFiGGrsxZbEzvjbEreaMmrUYqtOBLuDGxpvdxHZ66kCAPdJza7UQDaYcASJV2odVw98PjWA6NMOpde1KB9rWAJaMWfbggnfBJORHxivxYtDczIJZPTdUZSq7YGdZ33LSicMeVNftpql8tJWgUlb1eIyBryMeTmdr5goMsP6GZXpxz+4R8oDINlN9QWoJcF8gR/7950gUBtx2HrReqUg7LULwII+Ym021YJ9HL9VWYQZHtA4pGXGZAdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I/GmRUIs0ZBdVCOdBUQ3r9oVmexp/wRq6r25pT5EQjs=; b=Ko2BJGrZd5iiq1g9UuunbyWXBcM4H98+0hFfA0ETx5IRvR4BUpStswfRV6i6iSp20roUiK1hGa8nRYKLe81Uf22DPuhwoGYkSudJAwpjuqghLP6rTGwKcbj6QD1/nf87NsDw8fQl/s2b2nhmyqTHzyqg3CrQy0zeDjy1fAsp8s25+QCkuUxPqlyXoXacnrzeMfuUoQNXlSMlfgrwyQ8UTHJ9SG2QBj6p/KPWF+YRmxjQYmriPyGEbEOpthUSO0e/susCA3tsStrzTxU0cte633TzFv2TBpbop64S5dZK8LW/q2eUfYqRH7w5lAiwLuJWqRgOpDtdsTk0IJ+tuPXVgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I/GmRUIs0ZBdVCOdBUQ3r9oVmexp/wRq6r25pT5EQjs=; b=sm8KcZtGbTWflXsqgsJDQpPi2OqZNKnExaZHA1PegX7LlFxahgEI6J1lVXq6R8XAQKldza7COkbz29KqE0XA5bApATEmn39NHjDE7GnmEZvdTzGdiP3tYa2xXWBpZnZNryLXbGzwGgaN6jSjG4V6CtnERITQtp8PQEYqBW8L5Ac= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang Subject: Re: [PATCH][4.17] kexec: restore hypercall 1st arg's type Thread-Topic: [PATCH][4.17] kexec: restore hypercall 1st arg's type Thread-Index: AQHY8rrxB22D+mhDmkyvs7CT99N0gq43CX2A Date: Wed, 9 Nov 2022 20:11:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5409:EE_ x-ms-office365-filtering-correlation-id: 93e02fde-4678-4752-8e86-08dac28e9ce5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xgGhkhPMhnu9GddJnz0qiApmFr+CIKgmld3hMhQnA7ddfS1O2O6guhhdcF2QJuzKkTYYUkMHAyUj9WGFL4eENdDITzYG94i+9yHBTkvynYadnoIioB4RHmq/+37h827oXU7Fjc7ZXjOgnZv5STJ1MCPyHGkpJ3I0vzH/C/116AYEuG7a3FDQfwX5bm8F/poh6oJvaQBklitOeZCBKrHjxa2mDzOPZg6EwIqkaYw9nulI3nPpQSSTpjL69Fao6cXcxZnFsNpDSK4OM15HlfR/wagtudtjZGgI+HfJUAKuNfzxUt9eXchcs0sVzphOSuPzuwMzoux20C5vLqmBFGTdH4FY1QAWj08axIafUbHmUl4qM5iUSuKCeJdUTKvKFCKhrdIi07/Ex0McGbljBYTcx44ws6I2/iuRB0LCAkHGC01tFTRYnZJNE0svcq6BA+uX2dZcNpn5R4xi/bMpaJFNxGf3oZV1SbliijfVahvRzPk423EAwVYlotsOFg3kg0skMIuuKnhFEA3pdfPZU05SP2oqawFNbMPvDXvychvmfyYAYjdtqxe1ZWiXtyIbSeqVCsHY2aImdDO/uWToWCXUaEvu2pb972+KYF148RkuRoBGVh+7ej2ivyN00f/8eMkiW3RRDusVDUb6EA0wZjU6PR5ZceHT/l5BW1tdHJErq5RkG+EMh+VP9trMGmWW5XvspDDS48nc4jctunMF+fCYtyoS5b5lmHsg28q8DbQ/sk67uIsk+fZNNMBWGWVvYGAmkE0lXD+CHepUkJKzW/IVdv9WHkOgUIorZ1U/UPKcvP0PpUTJ0tJyvm+Il/y0+PRajEWwasqceFlI70BZANbt4Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(366004)(39860400002)(451199015)(36756003)(31686004)(38100700002)(122000001)(82960400001)(478600001)(6486002)(38070700005)(31696002)(83380400001)(86362001)(4744005)(53546011)(186003)(6512007)(26005)(91956017)(6506007)(2906002)(76116006)(8936002)(71200400001)(66556008)(66946007)(66476007)(5660300002)(41300700001)(2616005)(110136005)(4326008)(316002)(54906003)(8676002)(64756008)(66446008)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?d3daUDJEWDVEVVlCS2V6M2dvZVE1R2JHc3VhWjJ3QXEvQWhKL0c0Q0VlZkhv?= =?utf-8?B?OUZ4aUF6NkdNMG5Cb3BDK1NpbzRGR2ZtSFdyVFB1YjNRYUlDTE9EWlFoYWVW?= =?utf-8?B?MUZrTlhERXR6QW5KaGhOMGV2ejgzVVhhenk2VXlhVUlrcEFISUl0WFRKUldM?= =?utf-8?B?ay9ERzdXT0pHSjVnVnRkVzJsQzllSW9kN2czTERWb3dPNTgzSVN3U29pMlJR?= =?utf-8?B?dStDeW9uT2xRTHpkTm8yMSttTEEwamxWSTArNGFsbXYrQTJ1N3d6akk1ak1E?= =?utf-8?B?TmtxQzVJa1c1US9jS3pkV0V1cG1JR1NzOCsxbjU4OG5iWXRQWWh6SFZERzNy?= =?utf-8?B?c09HaUR6anpOUTFhTUlXejlIOGpFYTlpdmd3Ui9PMks2eFh0YnRCYndCSVNm?= =?utf-8?B?ck1hZlRXcllwNGN0Wk9jZXVzbmNza0N3anhYWHpKVEdnNUo4cVZiYlhCMk5t?= =?utf-8?B?d1RwU1lnNkJLNXRIZURET0lqaHZibm5YM2xoazVjMlpPbHlsUk5PYSthb1U4?= =?utf-8?B?VTZsa0hmc21QQVJqbUZmZkp3VFJ5VEVwV1pSRmFHYmh6MXRZYWdvdUdGeDRP?= =?utf-8?B?ZmhMZDd0NVJUYUdFTHR5cDR2TWd3dmg0bkVCTTVIYVRwREpuZWhFalBnTVdH?= =?utf-8?B?V2pBTE4wc0hlUnVxYUp3bllaVHJ4K1c3eFB1UUVFMFFHNWtqVXI2S21PZkt0?= =?utf-8?B?WUZlYVVVZ293ektrN29CVWhNMy9oalpTU0U0dFByTkwycGZFSG10RFM3d3Zo?= =?utf-8?B?bXJGc0dMZ2hVY2tPQnR3b2hxaDgvSHFPLzE0TFFKSkIwOEFKZjJKKzlWNysz?= =?utf-8?B?a29qNmNZUFpvRlZiU2VFQ0I4YTJGTW14MHlzOTY0ODA0V3k0ek1CSTlCNnpl?= =?utf-8?B?ZkhxbGd4TUdhemhNSkxzQVpUdkRLS2hWYTJaSVFMQ2ZVOFY5VU0vYzFjZ1VN?= =?utf-8?B?SlhacFZ1MUQxSmZUVDY1dXhlYjFNQm5DZHBlODkzeEZhbG1PNFBHV2NNNHlC?= =?utf-8?B?eWM0TTJaekV6bTdoN3B5SXRXUTN2L2dyaHF3RDJicHJyS2FDZkNaWSt2YWl3?= =?utf-8?B?Uk80QVVSSW90VytIRVJFMnFXTGxPOWYzTk02MTZRUllRWjFrSzNQK01qdjZs?= =?utf-8?B?OUlUN0ZvSm5sQTkwRjFpZ3hVK1NmZVQrT2dZK040YU1TQlVsczFKSHc2TWJJ?= =?utf-8?B?YkFxbXc4a2xGR0hEMW40RUZaY0xhQ3o1RDJsa0ZkRThyaTZScDlPLytJR3Nt?= =?utf-8?B?TkdNdEtxWEtzUEhKM1NBZmdoOHZRd3FFN1JacnIrUWpNcGVyNGtqb1A1UkZn?= =?utf-8?B?aTIyMzlKVWk2STFXUnJFeEZ6bHZJYXhvbCtOYS9kT2RzNk9zZkJGUWd6bzFs?= =?utf-8?B?N0lTS1laUWNFd29Uc0k0amFsQXpoaW5udWptZ2ZRUmFXQWxFcUlPM3k4VkFv?= =?utf-8?B?WGpRbTlYWVBaWmt6VzJQdGVzNUVkQko5cklZUTJZOU55cDBMRXpYNDVRZUxt?= =?utf-8?B?WU11NUdqK0JHSmJjaDB0U1Z2NjNJMnYwZHFLMWQreTdwZU1DZERzaFZIUHRI?= =?utf-8?B?UWh5OFBYb0t1NUJsbmFLa0wvUVRCSzFZUXdaSGJzS0NDZFdqUnZxYkJIWHU0?= =?utf-8?B?a0NEWFBhVVY3bEhITjE4c2dCdGNHVFhCc2dzR1lGTnYwSHZ5am1NSDhxSU01?= =?utf-8?B?bms5TG1jdTc2V0F2UDVKV0Q5Z093YkZBaVNQdG9obWpwMFIwN3EwS3l4eEls?= =?utf-8?B?VndaRzU1OG52dTE1ckhtdnN2Q1R2ayt1QzRxVklPVXE5SGtJc3hJd20wUWUz?= =?utf-8?B?eFgySXl1QmdWWkJ1dGpROWkvdnpMcGU1UEFjbytwSEhWWC9ndW5nb0lBTjAx?= =?utf-8?B?MXpSZTgxQjNzWWJ2UlNYMXdDL1NvcnRKTzhTQnFBNlRCWUNpZERoZ3NibVUz?= =?utf-8?B?QjErdUZ4NE4vNTR6NC9TZUdkWHI3YWVGUDMvY3drTXE4bkc1NHVadjFkK0Ja?= =?utf-8?B?SjNMZWxsakdocGNORmJmZVNyM3N3SWRTWVZqd0ViWTJMdFlFWU1TelVTWWJR?= =?utf-8?B?dmNJbmJCR1FuREREQW5qdTVwUlV4ZVB0SDQ2VVlRc0VqU1QvemcwZ2xqZFhN?= =?utf-8?Q?zVokRPk8IfebeCkG8+Fu11Z6v?= Content-Type: text/plain; charset="utf-8" Content-ID: <75515F104CCF5647A9E66F8712C3D125@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93e02fde-4678-4752-8e86-08dac28e9ce5 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 20:11:39.9156 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KRSO+GbPyTRI+5tkUTXVm+LihyNgQBAbY/sliDbNoV92LLv7wpr5uEkrfOPavyrlt6erhQNc7RuvANbjeOetIMz9TK8ShfwNbLUaadOqE4k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5409 T24gMDcvMTEvMjAyMiAxNTowOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFRoaXMgcmV2ZXJ0cyBh IHNtYWxsIHBhcnQgb2YgN2UyMWIyNTA1OWVkICgieGVuOiBoYXJtb25pemUgcmV0dXJuIHR5cGVz DQo+IG9mIGh5cGVyY2FsbCBoYW5kbGVycyIpLiBUaGUgY2hhbmdlIGZyb20gInVuc2lnbmVkIGxv bmciIHRvICJ1bnNpZ25lZA0KPiBpbnQiIGZvciB0aGUgbmF0aXZlIGhhbmRsZXIgZnVuY3Rpb24g bWVhbnQgdGhhdCBwcmV2aW91c2x5IGludmFsaWQNCj4gdmFsdWVzIGJlY2FtZSB2YWxpZC4gV2hp bGUgcGVyaGFwcyBub3QgYSBzaWduaWZpY2FudCBpc3N1ZSwgc3RyaWN0bHkNCj4gc3BlYWtpbmcg dGhhdCdzIHN0aWxsIGEgY2hhbmdlIHRvIHRoZSBBQkkuIERvbid0IGdvIGFzIGZhciBhcyByZXN0 b3JpbmcNCj4gdGhlIGNvbXBhdCBlbnRyeSBwb2ludCdzIHR5cGUgdGhvdWdoOiBUaGF0IG9uZSBj YW4ndCBoYXZlIHZhbHVlcyBwYXNzZWQNCj4gd2hpY2ggZG9uJ3QgZml0IGluIDMyIGJpdHMuDQo+ DQo+IE5vdGUgdGhhdCBhcyBhIHNpZGUgZWZmZWN0IHRoaXMgZml4ZXMgdGhlIGludm9jYXRpb24g b2YNCj4gaHlwZXJjYWxsX2NyZWF0ZV9jb250aW51YXRpb24oKSwgd2hpY2ggYnkgbWlzdGFrZSB3 YXNuJ3QgYWRqdXN0ZWQgYnkgdGhlDQo+IGVhcmxpZXIgY2hhbmdlLg0KPg0KPiBBbHNvIHRha2Ug dGhlIG9wcG9ydHVuaXR5IGFuZCBjb3JyZWN0IHRoZSByZXNwZWN0aXZlIGNvbW1lbnQgaW4gdGhl DQo+IHB1YmxpYyBoZWFkZXIuIChUaGUgd2F5IGl0IHdhcyBpdCByZWFsbHkgc3VwcG9ydHMgdGhh dCBpdCBwcm9iYWJseSB3YXMNCj4gcG9pbnRsZXNzIHRvIHVzZSAibG9uZyIsIGJ1dCB0aGF0J3Mg dGhlIHdheSB0aGUgaHlwZXJjYWxsIHdhcw0KPiBpbnRyb2R1Y2VkLikNCj4NCj4gUmVxdWVzdGVk LWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiBTaWduZWQt b2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNClRoYW5reW91IGZvciBm aXhpbmcgdGhpcy7CoA0KDQpBY2tlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNA Y2l0cml4LmNvbT4NCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 09 20:16:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 20:16:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441130.695441 (Exim 4.92) (envelope-from ) id 1osrUn-0000yh-Qv; Wed, 09 Nov 2022 20:16:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441130.695441; Wed, 09 Nov 2022 20:16:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osrUn-0000ya-Nu; Wed, 09 Nov 2022 20:16:25 +0000 Received: by outflank-mailman (input) for mailman id 441130; Wed, 09 Nov 2022 20:16:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osrUm-0000yS-G1 for xen-devel@lists.xenproject.org; Wed, 09 Nov 2022 20:16:24 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 60490cf9-606b-11ed-91b5-6bf2151ebd3b; Wed, 09 Nov 2022 21:16:22 +0100 (CET) Received: from mail-bn7nam10lp2106.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.106]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Nov 2022 15:16:13 -0500 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by DM6PR03MB5178.namprd03.prod.outlook.com (2603:10b6:5:240::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 20:16:11 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::5d4b:6b1d:efc2:20e5]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::5d4b:6b1d:efc2:20e5%9]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 20:16:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60490cf9-606b-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668024982; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=SyOUv4VDnvtYScPq6xPFgMTCE8uxiQ1QzichdeYDGpo=; b=QGN9DBIwhgsLcb98RGCcPD2iUAx37Ghto0Iho3xh7PBwiX0k1wbo6XP6 wfU+miHRssgy7ZEJglD2B6mJaWEN5qwQOKDTMQODfkglWgJqXrhfUES6b 5ftYtGFg2Iyqvoh2HZ6ixG2+lF4/u48md8DitF3VQSrgD5CEyZyN7upRg o=; X-IronPort-RemoteIP: 104.47.70.106 X-IronPort-MID: 84108518 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:N1wBoaxlv8mMr/w8H/Z6t+dRxirEfRIJ4+MujC+fZmQN5Y8a5oE1v iFGDjfXfrrIN3ykOIpG3L7Go0kCuJTRmt9hTARu+CBjQS0W8saaC4jHJEypZXKbcZXPEhg2s ZxBNonNdJA+FCKE/xmgaOCwpiMljPrZT7D3UYYoVswJqSpMEU/N3jo/y75RbvdUvOWE7yOxV fLa8pSPM1T50jUuajtP5/zSoUM/4quj4G1HtAI0Oa5F5QWPy3VNAJwhfqzgdHGQrqu4vAKZb 72akOzmpDOxEzMFUI7NfmPTKxVSKlLqFVHSzCEQA+362EMqShUais4TLOAbZVpclwKHltVwz MQlnZGrQEIiM7akdN41CnG0KAkje/wYkFP7CSLn65bKlhWXKyCEL8hGVynaA6VJoo6bPkkWn RAoAGhlRgyOgeuw3IW6RoFE7ij0BJC2VG+3kigIIQDxVZ7Kc7iaK0n5zYYwMAMLrtJPBZ7ji /8xMlKDWvhijypnYT/7ALpm9Auha+KWnzdw8Dp5roJvi4TfIZAYPBEA/7M5d/TTLfi5kHp0q UrMp0rbATwrBODP4gai4EP1hbXLwyrkDdd6+L2QrpaGgXW170lKUFg8cwT+pvO0zEmjR9hYN koYvDI0qrQ//1CqSd+7WACkpHmDvVgXXN84/+8SsVnRjPaLpVnBQDFcEFata/R/3CMybRMn0 UWGkpXFGDpruaW9QnOB7LaE6zi1PED5KEdSOXZcHVZcs7EPpqkynE+VSspTKpWRj/+qHh7z8 iu6vCsH0uB7Yckjkv/TEUr8qzCjvJ/SVSYu+x7aGGmi62tRdIOjIoCl91XfxfJBN5qCCEmMu mAenMqT5/xICouC/ASPSugQGLCi596eLSbRx1VoGvEJ9Smp+nOlVZBd5nd5PkgBGt0fZTbjb UvXuAVQzJxeJn2naelweY3ZI9su5bjtE5LiTP+8RvpDZIJgMjCO+i5GbFSVmWvqlSARfboXP J6adYOmCykcAKE+lD6uHb5Fj/ks2zw0wn7VSdbj1RO73LGCZXmTD7AYLF+JaeN/56SByOnIz +ti2wKx4003eIXDjuP/qOb/8XhiwaAHOK3L IronPort-HdrOrdr: A9a23:VPNIDqzQlqN4bDlasGusKrPxmuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk80hqQFm7X5XI3SFjUO3VHFEGgM1/qE/9SNIUzDH6tmpN 9dmstFeZDN5DpB/KDHCWCDer5OruVvsprY/Ns2pE0dLz2CHpsQizuRfTzrd3GeKjMnObMJUL 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUazpALtzIS/PwmT3x8YXT8K66wl63 L5nwvw4bjmm+2nyyXby3TY4/1t6ZXcI5p4dY2xY/ouW3bRYzWTFcZcsnq5zXUISdSUmRYXeR /30lMd1opImjTslyqO0GbQMkHboUoTAjnZuBOlaDLY0LLEbSN/BMxbiY1DdBzFr0ImodFnya pOm3mUrpxNEHr77W3AD0ihbWAUqqOYmwtUrQcotQ0obaIOLLtK6YAP9kJcF5kNWCr89YA8Ce FrSMXR/uxff1+WZ23Q+jAH+q3mYl0jWhOdBkQSsM2c1DZb2Hh/0ksD3cQa2nMN7og0RZVI7/ nNdq5oiLZNRMkLar8VPpZIfeKnTmjWBR7cOmObJlrqUKkBJnLWspbypK444em7EaZ4uKfaWK 6xJW+wmVRCCH4GU/f+raGj2iq9MFmVTHDq1txU4YR/t/n1WKfrWBfzOmwTrw== X-IronPort-AV: E=Sophos;i="5.96,151,1665460800"; d="asc'?scan'208";a="84108518" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a1hD8IbQuDhliSdhfjUXAM50VcVy88yLzAslW6ComOpRYrQ5BDDlBo0twYBgKRQUoMZuMGJo4h6UNTo7GJnDLKnK+tmQuWzf0LMjbXtxinhCCDgwsQOeU9OHGYQLeLcj7sEYYkmwQmKq6oNIgtWmsgSE0wBxlDcB4qIphWkInNIXB/2TLxQdiB8a/neyYu35ZUHzaVHkvuFsoUHYDtlLUaMKtyAvam2rwrk8Be5eslZMu/0Ttt6qmqDUsxAYe0o7aYWXxMU+ATHF+1bnvbcSeb1DhrlXvdIJ3cZN6gENofHUsU3EuK3Z8E3lnx280tHZYM3xlgElGnCC+QwNuRk4mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mnwwo6rFXfDvbocKGyBzR6K3h6CcGpWdic+HRT3+kw8=; b=YM/oL2oRYUwt0CoTYOr4vKUXKi9CdhtoTnGUWGlncmt3A6wyn1p/TKJfMRsKuCh7qdFvDBw9yvJimk3yE1tsBp/3jzLyYLwD1F6tcxONw2R7Go9jIOWlUAs5bZuSzU12efzhq1EM3vnANzF5s3H8Ge6hg/7kfKgsoBA1FRce6QU7iihSfZTzRRwCVRbM2GWmyCmH2O5GYFa4qhlWgZ73GU3syR/DL0o5mxTo6ZemLvq8JJo7dozrQ25eTkRpLlbAJxhISmKJEzC1klG55o9yevJUQ7KQjhk8pvRTEmKDqbphn6hX/yqnMtSXSCfH9S9MHEsp77PAIfUWF6UtEXWAxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mnwwo6rFXfDvbocKGyBzR6K3h6CcGpWdic+HRT3+kw8=; b=bGhxPGX+9k3KKaXmU9JhpBzMykEkBq6+I+sDfaidQ02G55jKjwxVrPvCUFdZQ7k7OHO+DInPiagoAD2hx4CJodUczTcqtRyal3Y8l+k1tO6Le5Xtusdq2OyOZlnEPgalcpyxvp6uXuJWcIi6K0neJtdn0QdeOcTf0p6sYgMJ3dc= From: George Dunlap To: Andrew Cooper CC: Juergen Gross , "xen-devel@lists.xenproject.org" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang Subject: Re: Revert of the 4.17 hypercall handler changes Re: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers Thread-Topic: Revert of the 4.17 hypercall handler changes Re: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers Thread-Index: AQHY76JzZdOUSWsV/EuMjC67io5Dyq4uNcAAgAjbHYA= Date: Wed, 9 Nov 2022 20:16:10 +0000 Message-ID: References: <20221103163631.13145-1-jgross@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR03MB5669:EE_|DM6PR03MB5178:EE_ x-ms-office365-filtering-correlation-id: 27adfd9f-6d13-4d56-630b-08dac28f3e44 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h68ZRQ3fCZC8dX/jUw/C52wnjM8q322VKNVpSAAkW0M/dhWRuoGWCK5VXfYAe7c88TwKxkxFuNgJCv8xHG+5yza7JVqxAEEvqPfnIhPyiqBtfepd0WSvGMXtM17W0jOzsyEK51oGx7IPU6Tlxcz63NRYbCHMUTMYR6H6a+lGEY3z/UgVWjBeEABteG41SZhntupBz3dswwkZRbeKOckRtYqWGz0jHb0kLs/bdH8gUEz8FQVsqGvsUHAVq0YxQzpTRYHz8hQHudOocIQD7K6B2Z3nauyEDCy/fZX9XyPyFSG90MYdeSaLie97a52oX8/g9GZO0G5+XbzRd1NA2O6CesxvYBZg0Q3CINvMXFn4OEG2kbKjR0yWqpqLCzd3eDDObxfuQHBvItOW4o93CMm2P37ru06hYxu4JoBDRmw64d0Bf0AUmWjZq2LFHWavZ6K298Oz1kMbHbibtv+8+Bu0PvK3xn98nwh19fGf6LHyKy4Q2A5GPlKiO2vHxSs3aHW7NRJMSv8RKlQkuLuuKAYGzD7nKdfn+6AU7RHDEFULISGKY+0k8O3+QKGB+poxQGc08WuvCODwW4YjLkMDJ9kiy7fU7adyQwFGS77OGqvqMDYkFwVJqlvNiVy+5jWXtJdBlPuroWljZeV2PIrJHMPuXPCC9VONyT6Kw1KoK3VltW5Wf/7/xBtE3+IpidRa3SX4B9yRP8vWSyRj3gyeA/JNtwEfxVqzderBEckkIJlA4McWvitCkucbyVCvsyLXeMRLs5b1pnNaGczxkXvHqpfPvOGe+Vssjv4YYK0V5w5Dd7k8OMY3dMlXnPoVVH0CCwzx x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(376002)(39860400002)(396003)(136003)(451199015)(186003)(33656002)(8936002)(36756003)(6512007)(41300700001)(4326008)(316002)(26005)(66946007)(66446008)(53546011)(91956017)(66556008)(76116006)(6506007)(64756008)(37006003)(6636002)(66476007)(54906003)(2616005)(6862004)(5660300002)(99936003)(83380400001)(122000001)(38100700002)(82960400001)(2906002)(38070700005)(8676002)(86362001)(71200400001)(6486002)(478600001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SHNPZS9pNVFjclZhekZIVzVSSWdYbzlpRTdhc0NGZFJDMHduazlIbDVTWGc3?= =?utf-8?B?NmhXSHMyZ2ZVcUNoNWlITklQb1RVRjQ0OG15VVlJRE1IckZPSmpreDBlOVZw?= =?utf-8?B?cEVIY3U5TFVlME5DT1NablNMQTBvckpRQ2VkRUl4TEFkb3k5RXFTWXJmaU5J?= =?utf-8?B?Z2xVRGFBNTJid1FaazBTeFQrdS9oSnZQUWlqMTJNR2k5WlhuaGhIZGIwcWls?= =?utf-8?B?VDZseVowV3VNbXFIaThKNnE5LytkdWswNzFHSktlYWhXWkZEcW16SEUwa01t?= =?utf-8?B?WmczZkYvRUNhVjlZN3BTTDJwRVFSWnZPVHlvcEFvRmtka3F1T3hTQ0k3enF4?= =?utf-8?B?ZXBiU3J6SGlrK1VaeUlwS3NSVGNqejh6b1ZwTHc0dFZiRDFOQ2ZOTmtML25v?= =?utf-8?B?TWJtdHVqOG1Idm5mZWZrcXdONUNyVElzcmNqbGR2TUgxejNUV0lCNmhRTHc1?= =?utf-8?B?YUYxVDF0akg4MDIvaktTOVJaZTZIeWJsbDlFYjhlUUc1VFdOYmNHSlduWWxt?= =?utf-8?B?TXkwcm5BTjNxeVdmUGQ4cnBmSlc2RXNzWTBxeUxQSXhzL05mL3pib2dWVGp6?= =?utf-8?B?bzNlQ3RQWVJlTnJEeEcyWTg1MTZ4ZlAyN2ZOcFljdDJVMzNjN0o1Y3BvOVkz?= =?utf-8?B?WWI4eHBPY1NxbEpzWFJqSFF4ZkdFVjlweGlDRFZrVWZxdkowZlVzVGRtMUVB?= =?utf-8?B?UDd5Smc0eGVrRWhoOXFmQXhVaGwrUytlWUdrSFFYUjczU2p2R1JkdVFHZHdM?= =?utf-8?B?VE9RSUl4NmFFMHNVSEVWUHltMEZnL3lldDBsbDdIY3NUc2x5NEI1dDdQZEdB?= =?utf-8?B?OG4xZ2hET1QxUjcvVG5mV3FUZjluQXN4eFVGcXBkaU9vaUxXa2lObDU2MFo1?= =?utf-8?B?UFFJOXhyMFBXcUM1OWZSd1V6ZnY4WVQrazFpM3VaeFpJL3pmR1VOd3piTlVK?= =?utf-8?B?Mkh3czdkdkVtUTJ5MG9TOUhZVlBwWllPNE02UXA4UjQ2VXdVMDltTXYyRlhy?= =?utf-8?B?SkRoUTRlSzkxdlEzblJRSkhjLzFsVlVvRk1KVDVXZTlyaWM4M0lHZzB1K3VN?= =?utf-8?B?TGxXa21QaExJWTJkRlN0VVRmczBveFJ2K0hBYW9OMGdBdlpjUjZMc1IxS05F?= =?utf-8?B?NXZSK0VXWnY0RTgvSUdzaDYrcHhjWWUwNlhSMUtGc2dkdU1zRndWTUZMTy80?= =?utf-8?B?ckprV2IxUlBpeDZyRHN1MERPTUZGakQyRXJJOXZlNzVJclROWDVFZjE5L2Yy?= =?utf-8?B?ZEw3VGRldmk1dnVubXNtRWdCMnhYQXo4dkJPRUN5bkM1K2k2NjlUbEZXT21l?= =?utf-8?B?cGJPTlFJckNMRExZYmJvdW1Vc05tcndLMkszdDFKQzdaY01oaTZWYnVsRStY?= =?utf-8?B?Zy9XeVRlTEJrUDBwdG5yd3Z3anF3T3NrSkRSUnFKZHJwb05oS2wwWEFINzNz?= =?utf-8?B?SjZObHB0eE04RHpCV0owOTRnUHlNcUovVXRya3NFTUt6MTVPcW1aK0VWUHZC?= =?utf-8?B?by9ZMjBXbGdINEhxdmlHMTN2ekVOb3Bibk9sWU5VQzZidlZVdmk1M1NmbWd2?= =?utf-8?B?U0dPN2s2Z3J0ZjY5YUlXYy9qazBXOHBLVmp5OWxKWHJUaGs0SVluWlgzZGhO?= =?utf-8?B?SnpRWkNobE1UQ0N6d2J2Q29uSE01aUR5KzBsOWFYUUxwVkdHODIxdmxGRitp?= =?utf-8?B?S0pkRlNYNmdMeW9Zc01SbjJBSFlwd0FINGc1WE5KM21raWtZUFpXN2tNcVVm?= =?utf-8?B?d1JGU3BaNjZ0c0VSSFRpUWFjWWd5T25IcTBwOHZkUVNyL3Z1NUVvTHlxeUxo?= =?utf-8?B?LzhFdmpvU3RPNmoxd1ROTUQ3d29hNWFrK0UxMHViNGVXWXJIeHdHLy84YlhE?= =?utf-8?B?M0RIdm4ySzhPeUllMjFzKzFKWWtTNW5PUnZLR2FRNkNKNVJvS0Fjc3U3Wk11?= =?utf-8?B?SWoycnUxVDVicHpqd3h5M1R6L096S0lRTFdYR1JWbnJJS25FK01oQm9Pb0J2?= =?utf-8?B?SkxxRUI0U1BGZTRhV2UzRHcyU0ZoVWxtZU5lTTBDYjVZeitvRkRQQXl4SFZN?= =?utf-8?B?cXIvWW1PYlhGa1JkVVRwWmN6SmovODU3aWlBRE9MV0dXc0luc0YxbTR4dEFX?= =?utf-8?B?ZFJHeGhkcFJMV2xCQ1QvcGU0OFNEc1h4bDRlR2xxQmFMNkZGTCtNcEhwRkdu?= =?utf-8?B?cmc9PQ==?= Content-Type: multipart/signed; boundary="Apple-Mail=_96B7D1B1-039B-4AE8-B7B0-7608FC895A12"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27adfd9f-6d13-4d56-630b-08dac28f3e44 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 20:16:10.6503 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HjSanTrJ+g3DwEXmCCck9ZEGnj7mIBsI5SBh5vutvXMJYvWMyRFDXY3ynPmaSXhXxEwrixv3b63SsV2Qjy9jMY3QTtePzPO2fa53rfUNoOs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5178 --Apple-Mail=_96B7D1B1-039B-4AE8-B7B0-7608FC895A12 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 4 Nov 2022, at 05:01, Andrew Cooper = wrote: >=20 > On 03/11/2022 16:36, Juergen Gross wrote: >> The code generated for the call_handlers_*() macros needs to avoid >> undefined behavior when multiple handlers share the same priority. >> The issue is the hypercall number being unverified fed into the = macros >> and then used to set a mask via "mask =3D 1ULL << = ". >>=20 >> Avoid a shift amount of more than 63 by setting mask to zero in case >> the hypercall number is too large. >>=20 >> Fixes: eca1f00d0227 ("xen: generate hypercall interface related = code") >> Signed-off-by: Juergen Gross >=20 > This is not a suitable fix. There being a security issue is just the > tip of the iceberg. At the x86 Maintainer=E2=80=99s meeting on Monday, we (Andrew, Jan, and = I) talked about this patch. Here is my summary of the conversation = (with the caveat that I may get some of the details wrong). The proposed benefits of the series are: 1. By removing indirect calls, it removes those as a =E2=80=9Cspeculative = attack surface=E2=80=9D. 2. By removing indirect calls, it provides some performance benefit, = since indirect calls require an extra memory fetch. 3. It avoids casting function pointers to function pointers of a = different type. Our current practice is *technically* UB, and is = incompatible with some hardware safety mechanisms which we may want to = take advantage of at some point in the future; the series addresses = both. There were two incidental technical problems pointed out: 1. A potential shift of more than 64 bytes, which is UB; this has been = fixed. 2. The prototype for the kexec_op call was changed from unsigned long to = unsigned int; this is an ABI change which will cause differing behavior. = Jan will be looking at how he can fix this, now that it=E2=80=99s been = noted. But the more fundamental costs include: 1. The code is much more difficult now to reason about 2. The code is much larger 3. The long if/else chain could theoretically help hypercalls at the top = if the chain, but would definitely begin to hurt hypercalls at the = bottom of the chain; and the more hypercalls we add, the more of a = theoretical performance penalty this will have 4. By using 64-bit masks, the implementation limits the number of = hypercalls to 64; a number we are likely to exceed if we implement ABIv2 = to be compatible with AMD SEV. Additionally, there is a question about whether some of the alleged = benefits actually help: 1. On AMD processors, we enable IBRS, which completely removes indirect = calls as a speculative attack surface already. And on Intel processors, = this attack surface has already been significantly reduced. So removing = indirect calls is not as important an issue. 2. Normal branches are *also* a surface of speculative attacks; so even = apart from the above, all this series does is change one potential = attack surface for another one. 3. When we analyze theoretical performance with deep CPU pipelines and = speculation in mind, the theoretical disadvantage of indirect branches = goes away; and depending on the hardware, there is a theoretical = performance degradation. 4. =46rom a practical perspective, the performance tests are very much = insufficient to show either that this is an improvement, or that does = not cause a performance regression. To show that there hasn=E2=80=99t = been a performance degradation, a battery of tests needs to be done on = hardware from a variety of different vendors and cpu generations, since = each of them will have different properties after all speculative = mitigations have been applied. So the argument is as follows: There is no speculative benefit for the series; there is insufficient = performance evidence, either to justify a performance benefit or to = allay doubts about a performance regression; and the benefit that there = is insufficient to counterbalance the costs, and so the series should be = reverted. At the end of the discussion, Jan and I agreed that Andrew had made a = good case for the series to be removed at some point. The discussion = needs to be concluded on the list, naturally; and if there is a = consensus to remove the series, the next question would be whether we = should revert it now, before 4.17.0, or wait until after the release and = revert it then (perhaps with a backport to 4.17.1). (Jan and Andy, please let me know if I=E2=80=99ve misunderstood anything = from that meeting.) I have more details regarding the technical aspects above, but this = email is already rather long. Let me know if you need more details and = I=E2=80=99ll try to fill them in. Thoughts? -George --Apple-Mail=_96B7D1B1-039B-4AE8-B7B0-7608FC895A12 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmNsCnkACgkQshXHp8eE G+1/ogf/aMnlFUATa4jp5NKlUuzPrgqGA3d2mPI0i5kkSoukVXYtTkn9aEYhc5Eb f1Ab7uKTGcxO+v9DmtF66GvWCi8DR6kBBAwyACKMNbGNpjCG6y7B7R37Eubbx2/D rrOQVwoRSXMW9qsOunna/gJcpemmbygCdL3dqlQTUTk+Vtasyz4GlQz/YSvKEMfB ViRib2G473Gi47kOOz1PCG0qIW5SEsgQarpK9Bas5vro7yCGNh7kHwn7j/UfHBYt ktLkXfpPDf8nh4wEuPHaxSpXVjWkvXMUS1RC3aGAawZlPVQK2yX+dynQpiC8n2XF WF9nKjpMzfT/PfqApXHvkb0yNH5kqQ== =nuN4 -----END PGP SIGNATURE----- --Apple-Mail=_96B7D1B1-039B-4AE8-B7B0-7608FC895A12-- From xen-devel-bounces@lists.xenproject.org Wed Nov 09 22:31:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 22:31:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441144.695464 (Exim 4.92) (envelope-from ) id 1ostb6-00024t-Ip; Wed, 09 Nov 2022 22:31:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441144.695464; Wed, 09 Nov 2022 22:31:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ostb6-00024m-FF; Wed, 09 Nov 2022 22:31:04 +0000 Received: by outflank-mailman (input) for mailman id 441144; Wed, 09 Nov 2022 22:31:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ostb4-00024J-NT; Wed, 09 Nov 2022 22:31:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ostb4-0001ql-G1; Wed, 09 Nov 2022 22:31:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ostb4-0008OD-08; Wed, 09 Nov 2022 22:31:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ostb3-0006BA-Pw; Wed, 09 Nov 2022 22:31:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WC2g4iJU9qkaRpSXti4i1VZrqNfeKHdiQ0gUxzKAwfE=; b=xEW5DYRb6gn8vazl41Fes/QS3G +FpfyEXUE9oBnVRGW/CRbNvp8k/X4RQZg3WUL8yzsRxBnVH4j/VCepiXC+W7pHPNgl9QXXk+5/8s4 h2xrjetRoiVgOJIXTvGp0YBQe3CV0XV5WaiwQdq9KJVotB6tigT0/xH/KP1KzkL2Wk1Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174682: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2b27967fb89d7904a1571a2fb963b1c9cac548db X-Osstest-Versions-That: xen=e61a78981364925a43c9cc24dc77b62ff7b93c9f From: osstest service owner Date: Wed, 09 Nov 2022 22:31:01 +0000 flight 174682 xen-unstable real [real] flight 174697 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174682/ http://logs.test-lab.xenproject.org/osstest/logs/174697/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-pair 10 xen-install/src_host fail pass in 174697-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174670 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174670 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174670 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174670 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174670 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174670 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174670 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174670 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174670 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174670 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174670 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174670 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 2b27967fb89d7904a1571a2fb963b1c9cac548db baseline version: xen e61a78981364925a43c9cc24dc77b62ff7b93c9f Last test of basis 174670 2022-11-08 09:26:56 Z 1 days Testing same since 174682 2022-11-08 23:08:18 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e61a789813..2b27967fb8 2b27967fb89d7904a1571a2fb963b1c9cac548db -> master From xen-devel-bounces@lists.xenproject.org Wed Nov 09 22:43:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Nov 2022 22:43:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441156.695483 (Exim 4.92) (envelope-from ) id 1ostnE-00045s-Ts; Wed, 09 Nov 2022 22:43:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441156.695483; Wed, 09 Nov 2022 22:43:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ostnE-00045l-RG; Wed, 09 Nov 2022 22:43:36 +0000 Received: by outflank-mailman (input) for mailman id 441156; Wed, 09 Nov 2022 22:43:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ostnD-00045b-5j; Wed, 09 Nov 2022 22:43:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ostnD-000240-3u; Wed, 09 Nov 2022 22:43:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ostnC-0000w6-MZ; Wed, 09 Nov 2022 22:43:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ostnC-0006To-La; Wed, 09 Nov 2022 22:43:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BoPoaESqNG3upmpwUNkgPNqrLIOaxlyuifCMoSjZAmc=; b=oHYCVWVR9Cfafg6rLcvmplryNG HJqmkrBFWbbEQ7Q2bdq/ihpcUtxnTrZeuoUrETrXYNJPYamy+pRkZg55rFieRWr3D9IEhROtUPd+t t+yr/+5bwfbeU/xjG4LvQNY30G14UtBel8c9JLvgpUJILXTvsqDSfPAcEKR/irxVOUx4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174692: all pass - PUSHED X-Osstest-Versions-This: ovmf=b0fd3097193d9c6825979e57e78e6278163bfd8e X-Osstest-Versions-That: ovmf=0be81a4d83810cdb018d293bc264f489e7664043 From: osstest service owner Date: Wed, 09 Nov 2022 22:43:34 +0000 flight 174692 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174692/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b0fd3097193d9c6825979e57e78e6278163bfd8e baseline version: ovmf 0be81a4d83810cdb018d293bc264f489e7664043 Last test of basis 174681 2022-11-08 20:43:50 Z 1 days Testing same since 174692 2022-11-09 15:13:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 0be81a4d83..b0fd309719 b0fd3097193d9c6825979e57e78e6278163bfd8e -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Nov 10 00:00:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 00:00:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441165.695494 (Exim 4.92) (envelope-from ) id 1osuzi-0006uy-Gz; Thu, 10 Nov 2022 00:00:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441165.695494; Thu, 10 Nov 2022 00:00:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osuzi-0006ur-E7; Thu, 10 Nov 2022 00:00:34 +0000 Received: by outflank-mailman (input) for mailman id 441165; Thu, 10 Nov 2022 00:00:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osuzg-0006ul-Il for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 00:00:32 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b0a8de92-608a-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 01:00:31 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9B511B82005; Thu, 10 Nov 2022 00:00:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BC4BC433B5; Thu, 10 Nov 2022 00:00:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0a8de92-608a-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668038429; bh=91RZcB/Wqh151kDL/nvrYpSum707zjk0s+P6Me8r0ao=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=VvxBcVAkdqUubfH4s5sIO3vLgm1lEO6fGVuIZeBrNVFvORtlWwCvjDG1tKYULzJsY +TUsIun7mJTIvTpjoHXNHmxLS5MknJetHSEBEiakZGqwONgJCrS4/D05zvrwG/0mBL XGUdCN6ysbD5P1Qh/jTAqXGossrlYpRh2dB0K9YxxA5M9jjSGTVDqKmeqBA/Fj8z9Q 0xwOkSIIMuk0Fchb+AVD4lsXqofqrLzHY6IfanRjGKZnIYYpo2m87Q6OAIU69wQWSW dU9mtNXBM94dcjfJbEv95BS1MHJ9Kzf2v3mvUDI+ysJlpZuI9f44bPvsNfl3yIrqFK ZE4mHw+OF9pGg== Date: Wed, 9 Nov 2022 16:00:26 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Ayan Kumar Halder cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com, Ayan Kumar Halder Subject: Re: [XEN v3] xen/arm: Enforce alignment check in debug build for {read, write}_atomic In-Reply-To: <20221108094503.40253-1-ayan.kumar.halder@amd.com> Message-ID: References: <20221108094503.40253-1-ayan.kumar.halder@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 8 Nov 2022, Ayan Kumar Halder wrote: > From: Ayan Kumar Halder > > Xen provides helper to atomically read/write memory (see {read, > write}_atomic()). Those helpers can only work if the address is aligned > to the size of the access (see B2.2.1 ARM DDI 08476I.a). > > On Arm32, the alignment is already enforced by the processor because > HSCTLR.A bit is set (it enforce alignment for every access). For Arm64, > this bit is not set because memcpy()/memset() can use unaligned access > for performance reason (the implementation is taken from the Cortex > library). > > To avoid any overhead in production build, the alignment will only be > checked using an ASSERT. Note that it might be possible to do it in > production build using the acquire/exclusive version of load/store. But > this is left to a follow-up (if wanted). > > Signed-off-by: Ayan Kumar Halder > Signed-off-by: Julien Grall > Reviewed-by: Michal Orzel > Reviewed-by: Bertrand Marquis Acked-by: Stefano Stabellini > --- > > Changes from :- > v1 - 1. Referred to the latest Arm Architecture Reference Manual in the commit > message. > > v2 - 1. Updated commit message to specify the reason for using ASSERT(). > 2. Added Julien's SoB. > > xen/arch/arm/include/asm/atomic.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h > index 1f60c28b1b..64314d59b3 100644 > --- a/xen/arch/arm/include/asm/atomic.h > +++ b/xen/arch/arm/include/asm/atomic.h > @@ -78,6 +78,7 @@ static always_inline void read_atomic_size(const volatile void *p, > void *res, > unsigned int size) > { > + ASSERT(IS_ALIGNED((vaddr_t)p, size)); > switch ( size ) > { > case 1: > @@ -102,6 +103,7 @@ static always_inline void write_atomic_size(volatile void *p, > void *val, > unsigned int size) > { > + ASSERT(IS_ALIGNED((vaddr_t)p, size)); > switch ( size ) > { > case 1: > -- > 2.17.1 > From xen-devel-bounces@lists.xenproject.org Thu Nov 10 00:18:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 00:18:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441171.695505 (Exim 4.92) (envelope-from ) id 1osvGy-0000lp-1C; Thu, 10 Nov 2022 00:18:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441171.695505; Thu, 10 Nov 2022 00:18:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osvGx-0000li-TI; Thu, 10 Nov 2022 00:18:23 +0000 Received: by outflank-mailman (input) for mailman id 441171; Thu, 10 Nov 2022 00:18:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osvGx-0000lc-75 for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 00:18:23 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e858215-608d-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 01:18:21 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0DB64615C2; Thu, 10 Nov 2022 00:18:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C02D0C433C1; Thu, 10 Nov 2022 00:18:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e858215-608d-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668039499; bh=I0LwEOAxJdce79XqClkPp/TO9IptgplIdaHd8nsIStU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ZUQNF86cwqhApgSgCq7SGxj6j9EzLt7A1ArSvjmZgySCUWhulN3H75bWZFbxRB6xd g+d7y+tn0+hvGse0Tez+ogrr4QDl/pLKpbqbFimn4rtGx7mcQHTiEU2nL3tTHhMNmR i1GEP73C2ueEGkSU+0nMbW2K2TG9cLPvZoae7qd88/+dNh0uOwpozRO0+VNJHTgpEM hSN4ysleUtUsfpD9VhF6E/bPzH/58U7OkVL0cdWjMSCC1Eg/qaa+TIHFHumGsJdes/ XlTe1sNaAL+zwoM8YNxHJlskXY01ZwreME9eyQ7vOLXgWDAEHjbE1/eE/7XCBvj721 mWHVZB0Z/HV2A== Date: Wed, 9 Nov 2022 16:18:17 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: Bertrand Marquis , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Doug Goldstein Subject: Re: [PATCH v3 0/4] Yocto Gitlab CI In-Reply-To: <6ee0706b-d1b3-187a-1557-c4b8173c6e37@amd.com> Message-ID: References: <1220596a-4fe7-5c08-5437-fa98eb14254c@amd.com> <6ee0706b-d1b3-187a-1557-c4b8173c6e37@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 7 Nov 2022, Michal Orzel wrote: > Hi Bertrand and Stefano, > > On 31/10/2022 16:00, Bertrand Marquis wrote: > > > > > > Hi Michal, > > > >> On 31 Oct 2022, at 14:39, Michal Orzel wrote: > >> > >> Hi Bertrand, > >> > >> On 31/10/2022 15:00, Bertrand Marquis wrote: > >>> > >>> > >>> This patch series is a first attempt to check if we could use Yocto in > >>> gitlab ci to build and run xen on qemu for arm, arm64 and x86. > >>> > >>> The first patch is creating a container with all elements required to > >>> build Yocto, a checkout of the yocto layers required and an helper > >>> script to build and run xen on qemu with yocto. > >>> > >>> The second patch is creating containers with a first build of yocto done > >>> so that susbsequent build with those containers would only rebuild what > >>> was changed and take the rest from the cache. > >>> > >>> The third patch is adding a way to easily clean locally created > >>> containers. > >>> > >>> This is is mainly for discussion and sharing as there are still some > >>> issues/problem to solve: > >>> - building the qemu* containers can take several hours depending on the > >>> network bandwith and computing power of the machine where those are > >>> created > >> This is not really an issue as the build of the containers occurs on the local > >> machines before pushing them to registry. Also, building the containers > >> will only be required for new Yocto releases. > >> > >>> - produced containers containing the cache have a size between 8 and > >>> 12GB depending on the architecture. We might need to store the build > >>> cache somewhere else to reduce the size. If we choose to have one > >>> single image, the needed size is around 20GB and we need up to 40GB > >>> during the build, which is why I splitted them. > >>> - during the build and run, we use a bit more then 20GB of disk which is > >>> over the allowed size in gitlab > >> As we could see during v2 testing, we do not have any space restrictions > >> on the Xen GitLab and I think we already decided to have the Yocto > >> integrated into our CI. > > > > Right, I should have modified this chapter to be coherent with your latest tests. > > Sorry for that. > > > >> > >> I will do some testing and get back to you with results + review. > I did some testing and here are the results: > > In the current form this series will fail when running CI because the Yocto containers > are based on "From ubuntu:22.04" (there is no platform prefix), which means that the containers > are built for the host architecture (in my case and in 99% of the cases of the local build it will > be x86). In Gitlab we have 2 runners (arm64 and x86_64). This means that all the test jobs would need > to specify x86_64 as a tag when keeping the current behavior. > After I built all the containers on my x86 machine, I pushed them to registry and the pipeline was successful: > https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/686853939 When I tested the previous version of this series I built the containers natively on ARM64, so that is also an option. > Here is the diff on patch no. 3 to make the series work (using x86 tag and small improvement to include needs: []): > ``` > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 5c620fefce59..52cccec6f904 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -65,6 +65,9 @@ > paths: > - 'logs/*' > when: always > + needs: [] > + tags: > + - x86_64 > > # Test jobs > build-each-commit-gcc: > @@ -206,19 +209,13 @@ yocto-qemuarm64: > extends: .yocto-test > variables: > YOCTO_BOARD: qemuarm64 > - tags: > - - arm64 > > yocto-qemuarm: > extends: .yocto-test > variables: > YOCTO_BOARD: qemuarm > - tags: > - - arm32 > > yocto-qemux86-64: > extends: .yocto-test > variables: > YOCTO_BOARD: qemux86-64 > - tags: > - - x86_64 > ``` > > Now, the logical way would be to build x86 yocto container for x86, arm64 for arm64 and arm32 on arm64 or x86. > I tried building the container qemuarm64 specifying target arm64 on x86. After 15h, only 70% of the Yocto build > was completed and there was an error with glibc (the local build of the container for the host arch takes on my machine max 2h). > This enormous amount of time is due to the qemu docker emulation that happens behind the scenes (I checked on 2 different machines). > > So we have 3 solutions: > 1) Build and run these containers for/on x86_64: > - local users can build the containers on local machines that are almost always x86 based, in short period of time, > - "everyone" can build/push the containers once there is a new Yocto release > - slightly slower CI build time > 2) Build and run these containers for specific architectures: > - almost no go for local users using x86 machine (unless using more than 16 threads (which I used) and willing to wait 2 days for the build) > - faster CI build time (arm64 runner is faster than x86 one) > - someone with arm64 based machine (not that common) would have to build and push the containers > 3) Try to use CI to build and push the containers to registry > - it could be possible but what about local users >From a gitlab-ci perspective, given the runners we currently have, we have to go with option 2). We don't have enough resources available on the x86 runner to run the Yocto jobs on x86. > Regardless of what we chose, we need to keep in mind that the biggest advantage to the Yocto build/run is that > it allows/should allow local users to perform basic testing for all the Xen supported architectures. This is because > everything happens in one place with one command. That's right, but it should be possible to allow the Yocto containers to also build and run correctly locally on x86, right? The arm/x86 tag in test.yaml doesn't matter when running the containers locally anyway. From xen-devel-bounces@lists.xenproject.org Thu Nov 10 00:32:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 00:32:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441177.695516 (Exim 4.92) (envelope-from ) id 1osvUr-0003QO-81; Thu, 10 Nov 2022 00:32:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441177.695516; Thu, 10 Nov 2022 00:32:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osvUr-0003QH-51; Thu, 10 Nov 2022 00:32:45 +0000 Received: by outflank-mailman (input) for mailman id 441177; Thu, 10 Nov 2022 00:32:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osvUp-0003Q7-SZ; Thu, 10 Nov 2022 00:32:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osvUp-00053K-Q2; Thu, 10 Nov 2022 00:32:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osvUp-0000YQ-DS; Thu, 10 Nov 2022 00:32:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osvUp-00088x-Cy; Thu, 10 Nov 2022 00:32:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rVbEhp7l97xXayt7fM4l9ccegVFLe6hG0X/F2jKpQ10=; b=vvZZYMGhgiDbKGtKibk4H0cDW+ vjBh8WN/ZsVVkwsQrsB2dsIJ5jxcQEf+EWDaqGVJs+PV3T8GaclcZflTqqsZDZLahBY8mi9lOwirt GCfuLirKbho3s2hMeUj938jFsaiIlYYeELdxQbe/IKFhWt8OY3zyf9tNOvwxfrB0dpM4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174699: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a4180b03fffafa1868b0bcacc20198d4caef2908 X-Osstest-Versions-That: xen=aa1bf3858551b7cd1facfb116fe35830aceac497 From: osstest service owner Date: Thu, 10 Nov 2022 00:32:43 +0000 flight 174699 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174699/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen a4180b03fffafa1868b0bcacc20198d4caef2908 baseline version: xen aa1bf3858551b7cd1facfb116fe35830aceac497 Last test of basis 174689 2022-11-09 10:03:35 Z 0 days Testing same since 174699 2022-11-09 21:00:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Roger Pau Monne Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git aa1bf38585..a4180b03ff a4180b03fffafa1868b0bcacc20198d4caef2908 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Nov 10 02:06:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 02:06:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441188.695533 (Exim 4.92) (envelope-from ) id 1oswxl-00062S-2X; Thu, 10 Nov 2022 02:06:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441188.695533; Thu, 10 Nov 2022 02:06:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oswxk-00062L-V4; Thu, 10 Nov 2022 02:06:40 +0000 Received: by outflank-mailman (input) for mailman id 441188; Thu, 10 Nov 2022 02:06:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oswxj-00062B-BN; Thu, 10 Nov 2022 02:06:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oswxj-0005rm-7x; Thu, 10 Nov 2022 02:06:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oswxi-0006sR-Lx; Thu, 10 Nov 2022 02:06:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oswxi-0006hD-Ku; Thu, 10 Nov 2022 02:06:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eyGbe7Xogc7oWlu8sd37aN+bDrTHcUhrzV7/1IMyWxA=; b=JCEkCxXqmGdiirZ5N912kK7qy1 Q0bvDQeZcglexOI0j85+4Z26Ab1npJnJ+DhYG+swv/g/MjgJPa85C2Ag4DgtBwzHxAwYs+2ExHXzu gvBsPII/Hb9n1uobM9ENvmxyoAtYI9VchoLLX1DJkRUjROPMIkv5ZukGKVebfDfzaGmU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174683: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f141df371335645ce29a87d9683a3f79fba7fd67 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 10 Nov 2022 02:06:38 +0000 flight 174683 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174683/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux f141df371335645ce29a87d9683a3f79fba7fd67 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 33 days Failing since 173470 2022-10-08 06:21:34 Z 32 days 52 attempts Testing same since 174683 2022-11-09 02:15:51 Z 0 days 1 attempts ------------------------------------------------------------ 1603 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 152799 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Nov 10 02:48:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 02:48:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441197.695543 (Exim 4.92) (envelope-from ) id 1osxc9-0003L7-A7; Thu, 10 Nov 2022 02:48:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441197.695543; Thu, 10 Nov 2022 02:48:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osxc9-0003L0-7a; Thu, 10 Nov 2022 02:48:25 +0000 Received: by outflank-mailman (input) for mailman id 441197; Thu, 10 Nov 2022 02:48:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osxc7-0003Kq-Rd; Thu, 10 Nov 2022 02:48:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osxc7-0007MD-M0; Thu, 10 Nov 2022 02:48:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osxc7-0000xS-22; Thu, 10 Nov 2022 02:48:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osxc7-000135-1a; Thu, 10 Nov 2022 02:48:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1G03AAWWzuk5fGzJIJe0Sb7bmGi3RjBGMedfv4BGJT8=; b=TnCCz1XNAKvn1XrtJyW022whuo oz7Kg4d0Ubf7PXPEe8E9xEp96Srh4NrH6ugRkg2K/T7BDMKi3AKZ4UrSwwsqCcWVfFmRM66lPFWRg IsVpW3PuAY4RNBAbLR3GkTHeZTvS5sUN5Ev54x3OTE4mTEVJgUnxOq2YwKBX4YPw2YJU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174684: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-amd64-i386-libvirt-xsm:xen-boot:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start.2:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:redhat-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a0d9384967214783a92973c920092b7251c03e57 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Thu, 10 Nov 2022 02:48:23 +0000 flight 174684 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174684/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-xsm 8 xen-boot fail in 174638 pass in 174684 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail in 174638 pass in 174684 test-amd64-i386-pair 11 xen-install/dst_host fail in 174638 pass in 174684 test-armhf-armhf-libvirt-raw 13 guest-start fail in 174638 pass in 174684 test-armhf-armhf-xl-rtds 14 guest-start fail in 174638 pass in 174684 test-armhf-armhf-xl-credit1 19 guest-start.2 fail in 174646 pass in 174638 test-amd64-i386-qemuu-rhel6hvm-amd 12 redhat-install fail in 174646 pass in 174684 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 174646 pass in 174684 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 174646 pass in 174684 test-armhf-armhf-libvirt-qcow2 13 guest-start fail in 174646 pass in 174684 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 174646 pass in 174684 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 174672 pass in 174646 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 174672 pass in 174684 test-armhf-armhf-xl-credit2 14 guest-start fail in 174672 pass in 174684 test-armhf-armhf-xl-credit1 14 guest-start fail pass in 174672 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail pass in 174672 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 174672 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 174672 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux a0d9384967214783a92973c920092b7251c03e57 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 11 days Failing since 174575 2022-11-01 18:42:39 Z 8 days 15 attempts Testing same since 174608 2022-11-03 19:46:50 Z 6 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anssi Hannula Arnaldo Carvalho de Melo Biju Das Brian Foster Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Darrick J. Wong Darrick J. Wong Dave Chinner David S. Miller Demi Marie Obenour Dongliang Mu Eric Dumazet Florian Fainelli Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hannu Hartikainen Hans Verkuil Heiko Carstens Helge Deller Hyong Youb Kim Hyunwoo Kim Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jeff Vanhoof Jens Glathe Jimmy Assarsson Johan Hovold Jon Hunter Jon Maloy Jonathan Cameron Josh Poimboeuf Juergen Gross Justin Chen Konrad Jankowski Kuogee Hsieh Leon Romanovsky Linux Kernel Functional Testing Luiz Capitulino M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Michal Jaron Mike Kravetz Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Paolo Abeni Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rik van Riel Saeed Mahameed Sakari Ailus Sasha Levin Shreeya Patel Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Thinh Nguyen Tom Lendacky Tony O'Brien Ulf Hansson Vasily Gorbik Vineet Gupta Vladimir Oltean Wei Yongjun Xin Long Yang Yingliang Yongqin Liu Zhang Changzhong Zhengchao Shao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2244 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Nov 10 03:06:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 03:06:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441206.695554 (Exim 4.92) (envelope-from ) id 1osxt6-0006SR-QF; Thu, 10 Nov 2022 03:05:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441206.695554; Thu, 10 Nov 2022 03:05:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osxt6-0006SK-NB; Thu, 10 Nov 2022 03:05:56 +0000 Received: by outflank-mailman (input) for mailman id 441206; Thu, 10 Nov 2022 03:05:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osxt5-0006SD-6R for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 03:05:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2069.outbound.protection.outlook.com [40.107.21.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 958613e7-60a4-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 04:05:53 +0100 (CET) Received: from DB8P191CA0007.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::17) by DU0PR08MB8833.eurprd08.prod.outlook.com (2603:10a6:10:478::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Thu, 10 Nov 2022 03:05:49 +0000 Received: from DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::b0) by DB8P191CA0007.outlook.office365.com (2603:10a6:10:130::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Thu, 10 Nov 2022 03:05:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT055.mail.protection.outlook.com (100.127.142.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Thu, 10 Nov 2022 03:05:49 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Thu, 10 Nov 2022 03:05:49 +0000 Received: from 125f96656067.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 59FD003B-0C28-4083-B4D0-F3902DBDF42B.1; Thu, 10 Nov 2022 03:05:40 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 125f96656067.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Nov 2022 03:05:40 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB8201.eurprd08.prod.outlook.com (2603:10a6:10:39c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 03:05:35 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Thu, 10 Nov 2022 03:05:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 958613e7-60a4-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HIpNMgRsC17X6Tp0uSYNCVapkD960JxzB5+Ep3G9uREBoLtMaP81xCI2scjGLAgAIhQsn7iK2PqK5VdT9bK1CggUwrWAqsf+MxEvBF8OX1MFRN7sN05z8xDw5gAirMR9V8sRYFD5SQ8pn7sVTrBFb4EvOcVnLzxIhQ+SRy2MhpLQDYxETT0EaMfxnnyHZH/sxlZ+reE9B4kKtF3c/77BV/7MT8CQTewtu4U+HpCnoPRb1StJxX9CNjih3quwn3IpP+E8cWEy0jKna0gB1E1vAHw8ZxAPgG7AtxkDV8BXZk5h9zKP+NbgmLTSEQL6etZXq/ss9WVZeMp7rANfvMOruQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6T/Zi4qydpSt+j+KVfiN5hv830EHXUJ5QVqY0FaTg0g=; b=nEfVLAncZc0Liwel7PeDlSDyCvlheQj0WAnXN0UBfAwFlm1tPfh0zokf9wmlBA48+rLG29yBn3ouNrZLI8OW6H29hNuIAr1MsoVOQCotdsDxhg+12xYn6AbeOgZExVrABgI6fhsJuh5+rTJp80avGYwMA3Ug6DGXJphhLjdsb209U8C0PDjntbfIda24iWpdRR9nRViKapyQlrJgwTNAkHtUndqFE4lSbm7Y80J0EuWu0UpbeV5I4oi6LPu9a/kf26xvvDjPn0NkWz8q+Bx7v2ScHhNI6lemoyn0VaEsAFdxv10wahxhp7H02tty2cD5XOZDxHULo37tAuO6f+TbcA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6T/Zi4qydpSt+j+KVfiN5hv830EHXUJ5QVqY0FaTg0g=; b=ieb3K94cZWXviHhY5dkoMrMtDviVFtD/Km/ILtlNFnbQqmw/ZRVS9i0atx8zsKXerxOEMmPEMof2iz7G2oZ8DxpDi5Imz8grG53g6yn+QvRY8yXvwSup/fN8xioS/+ML4VQ8TwOJeJXPOG0T8QGXNyDGBZ2z3nsvAMvC92K+Nbg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AivtbV4+UxK51paCufnvv1y4nuBsTX0JvEaEuWVPpelLyiW3bm1cYxU0zc84Z2iNXz1MVFirJY8NnzFFGw/v+ArTJL58T2zcwU4R1THbZicBObNr/oLWeDr2oPAdSYR1W+qW0IYSTZsn1hw/L2iLt/Cai25wyuE6UWrNi/KsBFSC4lyDxsIzUvOcsrlmvjQX9s1ItwiTJanuTpt3Xl13GkVWsdKK6G0jlGTYGXbDp/GyJB6lSeAewUm6ITEaj7s5taTy1KcW+hBCjgFiG+yLk5kuzok4X/OTEC1WR2w/YVMDU6+sSXzx4AZjrbbzqloEWUxXhDo2pF6TI8TUIQHD2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6T/Zi4qydpSt+j+KVfiN5hv830EHXUJ5QVqY0FaTg0g=; b=Ok1sMzw66tRHz6SzIw4AzebfffzAHCzA/SY6iqNXysQYxj/u/x/Ov0kaNtWv2Fjygror3q+3LqHDL3x5hBpdkyXSvuzxJW2QRO3CgRoPf8/xktFnhMRIYbS/Ogrc+QtmBdVVVo8cPbiHMZkmNLmD2Pss5/1y7SYG5dtSYVA4N3oOUddhUqcKpeoFdrZcLDnz+OnTtyKa70WkOThuMzO2hGc97/kwRB6MLN0gzaF54S3WzND5tnIQVtB5JobBd5nrzeVmfMUt+HtGAD3ekQJk5M/eBLxOAuUmWyHDDrh8nI1EZngOQrAu/eThdhYbDqqmsRzqtRKkWa35dlmZPN/8rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6T/Zi4qydpSt+j+KVfiN5hv830EHXUJ5QVqY0FaTg0g=; b=ieb3K94cZWXviHhY5dkoMrMtDviVFtD/Km/ILtlNFnbQqmw/ZRVS9i0atx8zsKXerxOEMmPEMof2iz7G2oZ8DxpDi5Imz8grG53g6yn+QvRY8yXvwSup/fN8xioS/+ML4VQ8TwOJeJXPOG0T8QGXNyDGBZ2z3nsvAMvC92K+Nbg= From: Henry Wang To: Luca Fancellu , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Wei Chen , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: RE: [PATCH for 4.17] arm: fix Kconfig symbol dependency on arm features Thread-Topic: [PATCH for 4.17] arm: fix Kconfig symbol dependency on arm features Thread-Index: AQHY9EQ4YSVwAsUBfECXaLTd4QdGs643eXug Date: Thu, 10 Nov 2022 03:05:34 +0000 Message-ID: References: <20221109140420.31007-1-luca.fancellu@arm.com> In-Reply-To: <20221109140420.31007-1-luca.fancellu@arm.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D00A2AF020131D408DFD83CDEA1E5D1A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB9PR08MB8201:EE_|DBAEUR03FT055:EE_|DU0PR08MB8833:EE_ X-MS-Office365-Filtering-Correlation-Id: 73e95992-d9b2-4c98-9891-08dac2c87830 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: O4hjlYr6sxY2M2F3rkRbDY8EC2qfrnT2kpc0HLnbuj57nh/1Q5y0CXXhFsVLBV65Gh1JCYixUEOsbvRB/85q6143ALseh4iyROLWPQRqQlYIWG5wpWfxUvAQss6MSZnN84deCclqw+93PpAlqpfP/j/0WHYRthyaFz5D2tHg3e8NANEnmnp+7lZSywKvF52yt7GWQgL2K5yBY1MTq0wSUkkVYbf8TPcBfr8keHBhxq2H3GsxBEU7PPjsvOMiOqswEDgqdAQmNa/beILOOzBsigxNDqkfm80NUCne/ZUu0X5081qusgOWv/j8Jy6y7AMe5LwZ7ksqwTyEL2lWOzBEidIj+SH8PsKu0z6p8pRvCabyynXtSm2O0C2sX9MekZqjsP1qO/R8QECgWXFWfQgn3NPKqdHJOeMhqWW/3NFMPsNspfXEJPjaD7AH+4hQ/LSoki0j9jhBUx5qbnXrggQpOiyciCWCP6xGkWhCtAdlQTRrOVufKwtDpeT1PzXgw+4KSd+4IYbMM+UYfvcSi0GlD9R/IZHlqY4jiwkScMMN0sZ4tLvku6BQq/0GB+0Nfa4YZT0E8diAnTyCSji3wHtUyBP27VxR+fDPLAk4O6u/h5HWwKIgB9BnSqHCCsY/mBhSaxMMTDVCzQcLeECrNAwVBOcXd6S7y57DbUoiOKGiO6/11AysGL/+Ksli6ob7TI3OB7jxoMtdIjCQmsCS3hudZWP6m+CyFQ++BhZRAuExilb4iypX1Ce5qMBFVNGnPlDSRRc8j+hzgQdxVwVH9NbC1A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(376002)(136003)(366004)(451199015)(33656002)(6506007)(7696005)(4326008)(2906002)(38070700005)(4744005)(38100700002)(122000001)(86362001)(8936002)(5660300002)(83380400001)(41300700001)(186003)(52536014)(54906003)(66946007)(66476007)(76116006)(66446008)(316002)(66556008)(110136005)(9686003)(26005)(55016003)(8676002)(71200400001)(478600001)(64756008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8201 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d7bbea1d-b37a-472f-6dcf-08dac2c86f6f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KRKJV4b4NC2dG549Hw+IVlvvmE5C4mtNjo9cQWEx9SeSOEtFqNejNUQVOawFO2ylXsxE7hMuJ6EJIY25Id4EVX3KCWb4HAU/Ju4Z+Oynczi4gJaeyNMl6k0GZCvnXHv508MVKXa11hgAFXFTjKVLvYx6eisDUuX4pIUUxOaYqnygfAtQoXrbQ3hzymldSENX8hvyTQAOcEcxTN4cNfhB2nYevCXVXFNRMn+vni+DWRb69MqwPoc9TYKF8Hh11ZPrppQLHdZVOSJqgEVWSf6yR+ULhoFikp+XkoUBgkWNROQhjiz8dzvoATxKAQjs05ZDXD5AMFI/A6JYV77csNn/2Kmg/RpYxZ1ILuQ+VoC3W/g6ALRK8eEOA9HGxsLWHVxpdepuN93Jod12Z2ezeZ9XqEe0dl98jrkkIVTaJjOjAN/3c9QMVkkma9BraKosTF/Dw4ziQ2pOMUn2gUpmb5e7sxgPTX0T/W8WLiXmenDZ9kJ1r/CmTIQMeMv5bdqYXlSSkvpnDeb6hrOaFAKUHUh39RaTxbqQUGiGCDayJgm9rK2XgAFUS+A47Wc6L22Q2G5LUcq3zSST4lagXQJV+ExqdSVabFTojrkadWzLMiSAAwuPFQC4t6duKZ7GnisyxAleAnUonhRY0rq4av6dq+9gK/0NlxlgyYzeOfpGBl2upuhmnd1RrM/7p8Uvsl0sL05PtjGsUg8VW1IHLyzCdoksgzJCCxMWG9PdvLo1C78cUznkGGQRShiyc/Z6RWrBJMomYXthC87Ur7Fx9lAp0aLi+w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(46966006)(36840700001)(40470700004)(7696005)(47076005)(81166007)(55016003)(33656002)(107886003)(8676002)(54906003)(478600001)(4744005)(356005)(40460700003)(86362001)(82740400003)(2906002)(40480700001)(82310400005)(70206006)(36860700001)(83380400001)(186003)(26005)(336012)(6506007)(9686003)(5660300002)(70586007)(316002)(110136005)(4326008)(41300700001)(52536014)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 03:05:49.1888 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73e95992-d9b2-4c98-9891-08dac2c87830 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8833 Hi Luca, > -----Original Message----- > From: Luca Fancellu > Subject: [PATCH for 4.17] arm: fix Kconfig symbol dependency on arm > features >=20 > The commit 3c2a14ea81c7 is introducing some unsupported arm features > that by default are disabled and are used for the cpufeature.c code. >=20 > As they are disabled by default, a typo in the Kconfig symbol they > depend on has landed in the codebase unnoticed, instead of depending > on ARM64 which does not exist, fix the code to depend on ARM_64 that > is the intended symbol. >=20 > Fixes: 3c2a14ea81c7 ("arm: Define kconfig symbols used by arm64 > cpufeatures") > Signed-off-by: Luca Fancellu As IIUC this is a harmless patch, so it is fine to consider this in the rel= ease, but I will let the Arm maintainers to do the final call. If Arm maintainers agree this patch should go to 4.17, feel free to add: Release-acked-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Nov 10 03:21:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 03:21:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441213.695565 (Exim 4.92) (envelope-from ) id 1osy7t-0000lU-8O; Thu, 10 Nov 2022 03:21:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441213.695565; Thu, 10 Nov 2022 03:21:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osy7t-0000lN-5m; Thu, 10 Nov 2022 03:21:13 +0000 Received: by outflank-mailman (input) for mailman id 441213; Thu, 10 Nov 2022 03:21:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osy7s-0000lD-0x; Thu, 10 Nov 2022 03:21:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osy7r-0008CT-UW; Thu, 10 Nov 2022 03:21:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1osy7r-0003E3-Eq; Thu, 10 Nov 2022 03:21:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1osy7r-0000cV-EO; Thu, 10 Nov 2022 03:21:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pOJUE2rZD3GP7s32sIBZ0fZNFf66vbD/JarXCyC/cLY=; b=OBE92QibarJcBN1k5ElGsTgMWb dUN35a7eSKTQ+LkXsIXnDgOHl3Pr7C4BXqTrpJFwcISAMhlpPMtoamL5Cv9B+l4hl8aq64FkjdKN0 5NM+1MFD3v2HWN1bAY6aYgLCGtm21XWn63BMx8VIFx+58qONIxdl6gxZ/cnG4YYAzSSU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174685: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=640e1050bf756c8ccec65cdd6e7ce544bae764db X-Osstest-Versions-That: libvirt=d649faddb3ec0a360d1e15aa7aaf2452eba3bac8 From: osstest service owner Date: Thu, 10 Nov 2022 03:21:11 +0000 flight 174685 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174685/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174667 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174667 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174667 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt 640e1050bf756c8ccec65cdd6e7ce544bae764db baseline version: libvirt d649faddb3ec0a360d1e15aa7aaf2452eba3bac8 Last test of basis 174667 2022-11-08 04:18:58 Z 1 days Testing same since 174685 2022-11-09 04:22:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiri Denemark Lin Yang Michal Privoznik Tim Wiederhake jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git d649faddb3..640e1050bf 640e1050bf756c8ccec65cdd6e7ce544bae764db -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Nov 10 06:26:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 06:26:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441490.695586 (Exim 4.92) (envelope-from ) id 1ot10l-0000Ct-M5; Thu, 10 Nov 2022 06:26:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441490.695586; Thu, 10 Nov 2022 06:26:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot10l-0000Cm-IQ; Thu, 10 Nov 2022 06:26:03 +0000 Received: by outflank-mailman (input) for mailman id 441490; Thu, 10 Nov 2022 06:26:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot10k-0000Cg-9W for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 06:26:02 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8aca3482-60c0-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 07:26:00 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 50EC01F855; Thu, 10 Nov 2022 06:25:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 048641346E; Thu, 10 Nov 2022 06:25:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id S6RxOnaZbGP0AQAAMHmgww (envelope-from ); Thu, 10 Nov 2022 06:25:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8aca3482-60c0-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1668061559; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4Qqm8NV5NfbXssPdd91JJXy1qByRPo1Ka40FbHRtToY=; b=YVYsHQPD8l/cEc3CwEX1A7ho1HmplDR+WX8e7vAoTDaTRp6OWz9/xLSuBsV8aihBxyr+wD eYgKhrl1IaQtO+ojC5Iqz1ViSOZIgBeoY2ZnA+hyr1gkXPNeIiIxsxprc5+wH++x9HXZhv tzYhmMuiIvLpjosIg10fMGGG12iq/KU= Message-ID: <0cfd23d3-2b3d-5e16-2d2e-a2d345bf3d89@suse.com> Date: Thu, 10 Nov 2022 07:25:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 To: George Dunlap , Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang References: <20221103163631.13145-1-jgross@suse.com> Content-Language: en-US From: Juergen Gross Subject: Re: Revert of the 4.17 hypercall handler changes Re: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------MXcCJYGGfwCaK04hIJxn1BFQ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------MXcCJYGGfwCaK04hIJxn1BFQ Content-Type: multipart/mixed; boundary="------------Oe3cela21i1eA2L68jpTQNBA"; protected-headers="v1" From: Juergen Gross To: George Dunlap , Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang Message-ID: <0cfd23d3-2b3d-5e16-2d2e-a2d345bf3d89@suse.com> Subject: Re: Revert of the 4.17 hypercall handler changes Re: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers References: <20221103163631.13145-1-jgross@suse.com> In-Reply-To: --------------Oe3cela21i1eA2L68jpTQNBA Content-Type: multipart/mixed; boundary="------------2BOvoAgTSCF077PThRuMthSh" --------------2BOvoAgTSCF077PThRuMthSh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDkuMTEuMjIgMjE6MTYsIEdlb3JnZSBEdW5sYXAgd3JvdGU6DQo+IA0KPj4gT24gNCBO b3YgMjAyMiwgYXQgMDU6MDEsIEFuZHJldyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJp eC5jb20+IHdyb3RlOg0KPj4NCj4+IE9uIDAzLzExLzIwMjIgMTY6MzYsIEp1ZXJnZW4gR3Jv c3Mgd3JvdGU6DQo+Pj4gVGhlIGNvZGUgZ2VuZXJhdGVkIGZvciB0aGUgY2FsbF9oYW5kbGVy c18qKCkgbWFjcm9zIG5lZWRzIHRvIGF2b2lkDQo+Pj4gdW5kZWZpbmVkIGJlaGF2aW9yIHdo ZW4gbXVsdGlwbGUgaGFuZGxlcnMgc2hhcmUgdGhlIHNhbWUgcHJpb3JpdHkuDQo+Pj4gVGhl IGlzc3VlIGlzIHRoZSBoeXBlcmNhbGwgbnVtYmVyIGJlaW5nIHVudmVyaWZpZWQgZmVkIGlu dG8gdGhlIG1hY3Jvcw0KPj4+IGFuZCB0aGVuIHVzZWQgdG8gc2V0IGEgbWFzayB2aWEgIm1h c2sgPSAxVUxMIDw8IDxoeXBlcmNhbGwtbnVtYmVyPiIuDQo+Pj4NCj4+PiBBdm9pZCBhIHNo aWZ0IGFtb3VudCBvZiBtb3JlIHRoYW4gNjMgYnkgc2V0dGluZyBtYXNrIHRvIHplcm8gaW4g Y2FzZQ0KPj4+IHRoZSBoeXBlcmNhbGwgbnVtYmVyIGlzIHRvbyBsYXJnZS4NCj4+Pg0KPj4+ IEZpeGVzOiBlY2ExZjAwZDAyMjcgKCJ4ZW46IGdlbmVyYXRlIGh5cGVyY2FsbCBpbnRlcmZh Y2UgcmVsYXRlZCBjb2RlIikNCj4+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxq Z3Jvc3NAc3VzZS5jb20+DQo+Pg0KPj4gVGhpcyBpcyBub3QgYSBzdWl0YWJsZSBmaXguICBU aGVyZSBiZWluZyBhIHNlY3VyaXR5IGlzc3VlIGlzIGp1c3QgdGhlDQo+PiB0aXAgb2YgdGhl IGljZWJlcmcuDQo+IA0KPiBBdCB0aGUgeDg2IE1haW50YWluZXLigJlzIG1lZXRpbmcgb24g TW9uZGF5LCB3ZSAoQW5kcmV3LCBKYW4sIGFuZCBJKSB0YWxrZWQgYWJvdXQgdGhpcyBwYXRj aC4gIEhlcmUgaXMgbXkgc3VtbWFyeSBvZiB0aGUgY29udmVyc2F0aW9uICh3aXRoIHRoZSBj YXZlYXQgdGhhdCBJIG1heSBnZXQgc29tZSBvZiB0aGUgZGV0YWlscyB3cm9uZykuDQo+IA0K PiBUaGUgcHJvcG9zZWQgYmVuZWZpdHMgb2YgdGhlIHNlcmllcyBhcmU6DQo+IA0KPiAxLiBC eSByZW1vdmluZyBpbmRpcmVjdCBjYWxscywgaXQgcmVtb3ZlcyB0aG9zZSBhcyBhIOKAnHNw ZWN1bGF0aXZlIGF0dGFjayBzdXJmYWNl4oCdLg0KPiANCj4gMi4gQnkgcmVtb3ZpbmcgaW5k aXJlY3QgY2FsbHMsIGl0IHByb3ZpZGVzIHNvbWUgcGVyZm9ybWFuY2UgYmVuZWZpdCwgc2lu Y2UgaW5kaXJlY3QgY2FsbHMgIHJlcXVpcmUgYW4gZXh0cmEgbWVtb3J5IGZldGNoLg0KPiAN Cj4gMy4gSXQgYXZvaWRzIGNhc3RpbmcgZnVuY3Rpb24gcG9pbnRlcnMgdG8gZnVuY3Rpb24g cG9pbnRlcnMgb2YgYSBkaWZmZXJlbnQgdHlwZS4gIE91ciBjdXJyZW50IHByYWN0aWNlIGlz ICp0ZWNobmljYWxseSogVUIsIGFuZCBpcyBpbmNvbXBhdGlibGUgd2l0aCBzb21lIGhhcmR3 YXJlIHNhZmV0eSBtZWNoYW5pc21zIHdoaWNoIHdlIG1heSB3YW50IHRvIHRha2UgYWR2YW50 YWdlIG9mIGF0IHNvbWUgcG9pbnQgaW4gdGhlIGZ1dHVyZTsgdGhlIHNlcmllcyBhZGRyZXNz ZXMgYm90aC4NCj4gDQo+IFRoZXJlIHdlcmUgdHdvIGluY2lkZW50YWwgdGVjaG5pY2FsIHBy b2JsZW1zIHBvaW50ZWQgb3V0Og0KPiANCj4gMS4gQSBwb3RlbnRpYWwgc2hpZnQgb2YgbW9y ZSB0aGFuIDY0IGJ5dGVzLCB3aGljaCBpcyBVQjsgdGhpcyBoYXMgYmVlbiBmaXhlZC4NCj4g DQo+IDIuIFRoZSBwcm90b3R5cGUgZm9yIHRoZSBrZXhlY19vcCBjYWxsIHdhcyBjaGFuZ2Vk IGZyb20gdW5zaWduZWQgbG9uZyB0byB1bnNpZ25lZCBpbnQ7IHRoaXMgaXMgYW4gQUJJIGNo YW5nZSB3aGljaCB3aWxsIGNhdXNlIGRpZmZlcmluZyBiZWhhdmlvci4gIEphbiB3aWxsIGJl IGxvb2tpbmcgYXQgaG93IGhlIGNhbiBmaXggdGhpcywgbm93IHRoYXQgaXTigJlzIGJlZW4g bm90ZWQuDQo+IA0KPiBCdXQgdGhlIG1vcmUgZnVuZGFtZW50YWwgY29zdHMgaW5jbHVkZToN Cj4gDQo+IDEuIFRoZSBjb2RlIGlzIG11Y2ggbW9yZSBkaWZmaWN1bHQgbm93IHRvIHJlYXNv biBhYm91dA0KPiANCj4gMi4gVGhlIGNvZGUgaXMgbXVjaCBsYXJnZXINCg0KVGhlIHRvIGJl IG1haW50YWluZWQgY29kZSBpcyBzbWFsbGVyLiBUaGUgb3ZlcmFsbCBkaWZmc3RhdCBvZiB0 aGUgc2VyaWVzIHNob3dzDQp0aGF0IG1vcmUgbGluZXMgd2VyZSBkZWxldGVkIHRoYW4gYWRk ZWQuDQoNClRoZSBnZW5lcmF0ZWQgY29kZSBpcyBsYXJnZXIsIGJ1dCB0aGlzIGFwcGxpZXMg dG8gb3RoZXIgY2hhbmdlcyAobmV3IGNvbXBpbGVyLA0KbW9kaWZpZWQgYnVpbGQgc2V0dGlu Z3MsIC4uLikgb2Z0ZW4gZW5vdWdoLCB0b28uDQoNCj4gMy4gVGhlIGxvbmcgaWYvZWxzZSBj aGFpbiBjb3VsZCB0aGVvcmV0aWNhbGx5IGhlbHAgaHlwZXJjYWxscyBhdCB0aGUgdG9wIGlm IHRoZSBjaGFpbiwgYnV0IHdvdWxkIGRlZmluaXRlbHkgYmVnaW4gdG8gaHVydCBoeXBlcmNh bGxzIGF0IHRoZSBib3R0b20gb2YgdGhlIGNoYWluOyBhbmQgdGhlIG1vcmUgaHlwZXJjYWxs cyB3ZSBhZGQsIHRoZSBtb3JlIG9mIGEgdGhlb3JldGljYWwgcGVyZm9ybWFuY2UgcGVuYWx0 eSB0aGlzIHdpbGwgaGF2ZQ0KPiANCj4gNC4gQnkgdXNpbmcgNjQtYml0IG1hc2tzLCB0aGUg aW1wbGVtZW50YXRpb24gbGltaXRzIHRoZSBudW1iZXIgb2YgaHlwZXJjYWxscyB0byA2NDsg YSBudW1iZXIgd2UgYXJlIGxpa2VseSB0byBleGNlZWQgaWYgd2UgaW1wbGVtZW50IEFCSXYy IHRvIGJlIGNvbXBhdGlibGUgd2l0aCBBTUQgU0VWLg0KDQpUaGlzIGlzIHNvbHZhYmxlIGF0 IG9uZSBjZW50cmFsIHBsYWNlLg0KDQo+IEFkZGl0aW9uYWxseSwgdGhlcmUgaXMgYSBxdWVz dGlvbiBhYm91dCB3aGV0aGVyIHNvbWUgb2YgdGhlIGFsbGVnZWQgYmVuZWZpdHMgYWN0dWFs bHkgaGVscDoNCj4gDQo+IDEuIE9uIEFNRCBwcm9jZXNzb3JzLCB3ZSBlbmFibGUgSUJSUywg d2hpY2ggY29tcGxldGVseSByZW1vdmVzIGluZGlyZWN0IGNhbGxzIGFzIGEgc3BlY3VsYXRp dmUgYXR0YWNrIHN1cmZhY2UgYWxyZWFkeS4gIEFuZCBvbiBJbnRlbCBwcm9jZXNzb3JzLCB0 aGlzIGF0dGFjayBzdXJmYWNlIGhhcyBhbHJlYWR5IGJlZW4gc2lnbmlmaWNhbnRseSByZWR1 Y2VkLiAgU28gcmVtb3ZpbmcgaW5kaXJlY3QgY2FsbHMgaXMgbm90IGFzIGltcG9ydGFudCBh biBpc3N1ZS4NCj4gDQo+IDIuIE5vcm1hbCBicmFuY2hlcyBhcmUgKmFsc28qIGEgc3VyZmFj ZSBvZiBzcGVjdWxhdGl2ZSBhdHRhY2tzOyBzbyBldmVuIGFwYXJ0IGZyb20gdGhlIGFib3Zl LCBhbGwgdGhpcyBzZXJpZXMgZG9lcyBpcyBjaGFuZ2Ugb25lIHBvdGVudGlhbCBhdHRhY2sg c3VyZmFjZSBmb3IgYW5vdGhlciBvbmUuDQoNCkhpc3RvcnkgaGFzIHNob3duIHRoYXQgc3Bl Y3VsYXRpdmUgYXR0YWNrcyB2aWEgaW5kaXJlY3QgYnJhbmNoZXMgYXJlIG11Y2gNCmhhcmRl ciB0byBzb2x2ZS4gTmV3IG9uZXMgY29taW5nIHVwIHdpbGwgcHJvYmFibHkgaGF2ZSB0aGUg c2FtZSBwcm9ibGVtLg0KDQo+IDMuIFdoZW4gd2UgYW5hbHl6ZSB0aGVvcmV0aWNhbCBwZXJm b3JtYW5jZSB3aXRoIGRlZXAgQ1BVIHBpcGVsaW5lcyBhbmQgc3BlY3VsYXRpb24gaW4gbWlu ZCwgdGhlIHRoZW9yZXRpY2FsIGRpc2FkdmFudGFnZSBvZiBpbmRpcmVjdCBicmFuY2hlcyBn b2VzIGF3YXk7IGFuZCBkZXBlbmRpbmcgb24gdGhlIGhhcmR3YXJlLCB0aGVyZSBpcyBhIHRo ZW9yZXRpY2FsIHBlcmZvcm1hbmNlIGRlZ3JhZGF0aW9uLg0KPiANCj4gNC4gRnJvbSBhIHBy YWN0aWNhbCBwZXJzcGVjdGl2ZSwgdGhlIHBlcmZvcm1hbmNlIHRlc3RzIGFyZSB2ZXJ5IG11 Y2ggaW5zdWZmaWNpZW50IHRvIHNob3cgZWl0aGVyIHRoYXQgdGhpcyBpcyBhbiBpbXByb3Zl bWVudCwgb3IgdGhhdCBkb2VzIG5vdCBjYXVzZSBhIHBlcmZvcm1hbmNlIHJlZ3Jlc3Npb24u ICBUbyBzaG93IHRoYXQgdGhlcmUgaGFzbuKAmXQgYmVlbiBhIHBlcmZvcm1hbmNlIGRlZ3Jh ZGF0aW9uLCBhIGJhdHRlcnkgb2YgdGVzdHMgbmVlZHMgdG8gYmUgZG9uZSBvbiBoYXJkd2Fy ZSBmcm9tIGEgdmFyaWV0eSBvZiBkaWZmZXJlbnQgdmVuZG9ycyBhbmQgY3B1IGdlbmVyYXRp b25zLCBzaW5jZSBlYWNoIG9mIHRoZW0gd2lsbCBoYXZlIGRpZmZlcmVudCBwcm9wZXJ0aWVz IGFmdGVyIGFsbCBzcGVjdWxhdGl2ZSBtaXRpZ2F0aW9ucyBoYXZlIGJlZW4gYXBwbGllZC4N Cg0KVGhpcyBhcmd1bWVudCBpcyB0cnVlIGZvciBtYW55IGNoYW5nZXMgd2UgYXJlIGRvaW5n Lg0KDQpUaGUgcGVyZm9ybWFuY2UgaW1wYWN0IG1pZ2h0IGJlIHBvc2l0aXZlIG9yIG5lZ2F0 aXZlLiBXaXRoIHRoZSBwb3NzaWJpbGl0eQ0Kb2YgcHJpb3JpdGllcyB0aGUgaW1wYWN0IGNh biBiZSBjb250cm9sbGVkLCB0aG91Z2guDQoNCj4gU28gdGhlIGFyZ3VtZW50IGlzIGFzIGZv bGxvd3M6DQo+IA0KPiBUaGVyZSBpcyBubyBzcGVjdWxhdGl2ZSBiZW5lZml0IGZvciB0aGUg c2VyaWVzOyB0aGVyZSBpcyBpbnN1ZmZpY2llbnQgcGVyZm9ybWFuY2UgZXZpZGVuY2UsIGVp dGhlciB0byBqdXN0aWZ5IGEgcGVyZm9ybWFuY2UgYmVuZWZpdCBvciB0byBhbGxheSBkb3Vi dHMgYWJvdXQgYSBwZXJmb3JtYW5jZSByZWdyZXNzaW9uOyBhbmQgdGhlIGJlbmVmaXQgdGhh dCB0aGVyZSBpcyBpbnN1ZmZpY2llbnQgdG8gY291bnRlcmJhbGFuY2UgdGhlIGNvc3RzLCBh bmQgc28gdGhlIHNlcmllcyBzaG91bGQgYmUgcmV2ZXJ0ZWQuDQo+IA0KPiBBdCB0aGUgZW5k IG9mIHRoZSBkaXNjdXNzaW9uLCBKYW4gYW5kIEkgYWdyZWVkIHRoYXQgQW5kcmV3IGhhZCBt YWRlIGEgZ29vZCBjYXNlIGZvciB0aGUgc2VyaWVzIHRvIGJlIHJlbW92ZWQgYXQgc29tZSBw b2ludC4gIFRoZSBkaXNjdXNzaW9uIG5lZWRzIHRvIGJlIGNvbmNsdWRlZCBvbiB0aGUgbGlz dCwgbmF0dXJhbGx5OyBhbmQgaWYgdGhlcmUgaXMgYSBjb25zZW5zdXMgdG8gcmVtb3ZlIHRo ZSBzZXJpZXMsIHRoZSBuZXh0IHF1ZXN0aW9uIHdvdWxkIGJlIHdoZXRoZXIgd2Ugc2hvdWxk IHJldmVydCBpdCBub3csIGJlZm9yZSA0LjE3LjAsIG9yIHdhaXQgdW50aWwgYWZ0ZXIgdGhl IHJlbGVhc2UgYW5kIHJldmVydCBpdCB0aGVuIChwZXJoYXBzIHdpdGggYSBiYWNrcG9ydCB0 byA0LjE3LjEpLg0KPiANCj4gKEphbiBhbmQgQW5keSwgcGxlYXNlIGxldCBtZSBrbm93IGlm IEnigJl2ZSBtaXN1bmRlcnN0b29kIGFueXRoaW5nIGZyb20gdGhhdCBtZWV0aW5nLikNCg0K SSdtIG5vdCBhZ2FpbnN0IHJldmVydGluZy4NCg0KSSBqdXN0IHdhbnRlZCB0byBzaGFyZSBt eSB0aG91Z2h0cyBvbiBhYm92ZSByZWFzb25pbmcuDQoNCg0KSnVlcmdlbg0K --------------2BOvoAgTSCF077PThRuMthSh Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------2BOvoAgTSCF077PThRuMthSh-- --------------Oe3cela21i1eA2L68jpTQNBA-- --------------MXcCJYGGfwCaK04hIJxn1BFQ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNsmXYFAwAAAAAACgkQsN6d1ii/Ey+R vAgAhWigLXgP1qhAHKlpHiZ+SJmVMOtefy4y2xYle9E6h/p3DNvRaAUk0bebZt7ZXLyQQuF7F8AU VcUiSZ6xbbnRLwoQs9yu12odEHs2A/5ApM4DN/DgOlOjZmztIp2mctflN9EfuhxM3XZ8fCypyUVW dRrgxtveA+U2BaQXzV76rlc2Ie301fwd2LUS7QOXjD3yACYsI5i7rMbR2XlBJsEvaJ5Qlnvv80rp 90x1a66BbPeiFF5zab02dwra83x/sgaGIKon9p6ibM9dPgTEpM7vhVVa+21fsxozkAkFlcHQBHJA wBjxYbphP4C98T/9iqA4q5xNW1sYnQGq6Uyn+4TzLg== =leTL -----END PGP SIGNATURE----- --------------MXcCJYGGfwCaK04hIJxn1BFQ-- From xen-devel-bounces@lists.xenproject.org Thu Nov 10 07:12:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 07:12:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441496.695597 (Exim 4.92) (envelope-from ) id 1ot1jR-0005wc-48; Thu, 10 Nov 2022 07:12:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441496.695597; Thu, 10 Nov 2022 07:12:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot1jR-0005wV-0d; Thu, 10 Nov 2022 07:12:13 +0000 Received: by outflank-mailman (input) for mailman id 441496; Thu, 10 Nov 2022 07:12:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot1jP-0005wL-JP; Thu, 10 Nov 2022 07:12:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot1jP-0005BZ-DX; Thu, 10 Nov 2022 07:12:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot1jP-0008Hz-3W; Thu, 10 Nov 2022 07:12:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ot1jP-0004zi-3C; Thu, 10 Nov 2022 07:12:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=z+ng5Y9W4Slrn6Wth8Zf1JLWMaMHC4SB9kd9YE1VB9Y=; b=rMpfRMc2ogyZk6qpuf4H2gZhw+ UcDxf3KXEtxwCvmDxCztMlGI+KevoohAujdVXKf9wkBJyAUnGcTOYtdzZsKwGBVEu4GYP2DrZ2+g8 PuBVIQ9QjRn+qy7/12vZBiqj5dCm/x/xoxBN3/P2ZwxkVdtkLlgMMh6JXF2Q1puksKsE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174687: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=60ab36907ded2918d33683f2b66f603b7400d8f3 X-Osstest-Versions-That: qemuu=524fc737431d240f9d9f10aaf381003092868bac From: osstest service owner Date: Thu, 10 Nov 2022 07:12:11 +0000 flight 174687 qemu-mainline real [real] flight 174707 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174687/ http://logs.test-lab.xenproject.org/osstest/logs/174707/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 174707-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174668 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174668 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174668 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174668 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174668 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174668 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174668 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174668 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 60ab36907ded2918d33683f2b66f603b7400d8f3 baseline version: qemuu 524fc737431d240f9d9f10aaf381003092868bac Last test of basis 174668 2022-11-08 05:15:02 Z 2 days Failing since 174674 2022-11-08 17:38:38 Z 1 days 2 attempts Testing same since 174687 2022-11-09 07:49:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki <akihiko.odaki@daynix.com>
Akihiko Odaki Akihiko Odaki Alex Bennée Alex Williamson Alexander Bulekov Amarjargal Gundjalam Ani Sinha Bernhard Beschow Brice Goglin Chris Browy Christian A. Ehrhardt Cindy Lu Cédric Le Goater Daniel Henrique Barboza David Daney Eric Auger Gerd Hoffmann Gregory Price Gregory Price Hesham Almatary Huai-Cheng Kuo Igor Mammedov Jason Wang Jean-Philippe Brucker Jiaxun Yang Jonathan Cameron Julia Suvorova Kangjie Xu lei he Markus Armbruster Michael S. Tsirkin Miguel Luis Parav Pandit Pavel Dovgalyuk Philippe Mathieu-Daudé Philippe Mathieu-Daudé Richard Henderson Robert Hoo Si-Wei Liu Stefan Hajnoczi Thomas Huth Xiang Chen Xuan Zhuo Yajun Wu Yicong Yang Zhenzhong Duan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 524fc73743..60ab36907d 60ab36907ded2918d33683f2b66f603b7400d8f3 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Nov 10 07:34:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 07:34:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441505.695607 (Exim 4.92) (envelope-from ) id 1ot250-0000GW-VT; Thu, 10 Nov 2022 07:34:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441505.695607; Thu, 10 Nov 2022 07:34:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot250-0000GP-Sp; Thu, 10 Nov 2022 07:34:30 +0000 Received: by outflank-mailman (input) for mailman id 441505; Thu, 10 Nov 2022 07:34:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot24y-0000GG-L3 for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 07:34:29 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2086.outbound.protection.outlook.com [40.107.212.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 197e24bd-60ca-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 08:34:25 +0100 (CET) Received: from BN9PR03CA0435.namprd03.prod.outlook.com (2603:10b6:408:113::20) by DM4PR12MB6135.namprd12.prod.outlook.com (2603:10b6:8:ac::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Thu, 10 Nov 2022 07:34:22 +0000 Received: from BN8NAM11FT093.eop-nam11.prod.protection.outlook.com (2603:10b6:408:113:cafe::63) by BN9PR03CA0435.outlook.office365.com (2603:10b6:408:113::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Thu, 10 Nov 2022 07:34:21 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT093.mail.protection.outlook.com (10.13.177.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Thu, 10 Nov 2022 07:34:21 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 10 Nov 2022 01:34:21 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Thu, 10 Nov 2022 01:34:20 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 197e24bd-60ca-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WjV4FvNN2fbJMsbly5GSFaF7ie7FHveEHYBk/65iyT4aqSHXjRmhim7aHdVgRLp6xwBCPYR2eRh8SWbIhDpuEuq5GM2/6pXz4l0I3MFxF59mF9NGzlH8yp0tX4AxKUUfElhVLf23eDL593XJlSb2S/HK1cL1DOPyH8jVA60bNoEOx3A9OJmZAh20VTs3IZyu403iQhGm+ikAh4sGn+AQJVeEv7mPdls8dSUw7DcvWXCTdx0pExIVnjxkFxUbWAgy9UprTM3KijlYomrOm8cWmeXcvBd6H+H+B80rv3UR1IDL2prLkzbXe06o8F5rxPNSAx596xh0nZkZN97YHEwCUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ivPN3JXOS4H52Q2GKOk3VRaS0bEO2/LWKmLNXiANbXY=; b=VQfIoTify1pS17FRpMc4NrIz4xfDQLTDxWUfdDYp2D4bmGXd9suFPcaR8y0ug2pODG3ZC91F/9JqDrlIKc4Egaggp8jyqJh3B+lrXWG81VwSuMwgZWyvJMe3B9jSgmT1rdmBxIFh+g1v2k26wYzf/X3Amc014ZmCYNA8aA1SuRdXMBPgmNyvvCb2qyGM1iH9jQLDOlmO4AGLBPFV73Pz+Ey+s/QcKni1Zi1rM0IdS+X/0sKER33H6IjLrW3cd2G+eIuhzfUwLPgWGQEZUdzq2JmwCW1TcQvXziLqmuQwWWendZF+Yfd+N4PkFXZzddM7uStLFL8/RPIq9TTZwBD0pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ivPN3JXOS4H52Q2GKOk3VRaS0bEO2/LWKmLNXiANbXY=; b=ioWMvg0/EGg0PxmFW3JtcB5aFo3bRUyLrYApu0KHtdd+15ykmRITgPDNTGA1EtfyotVICKYtXEp3dmOiDeMJ9r4CUR92QMqyrb6zz1aPVxq6TRSd+rV9CNVJrCc+Fiv19pPZui3xzfq4TbkR1yMNN/EVJOmX6aycIQmgboRs5Uc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <46c0e05f-47e1-39e6-d978-9f6c7d6db53a@amd.com> Date: Thu, 10 Nov 2022 08:34:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 0/4] Yocto Gitlab CI To: Stefano Stabellini CC: Bertrand Marquis , "xen-devel@lists.xenproject.org" , Doug Goldstein References: <1220596a-4fe7-5c08-5437-fa98eb14254c@amd.com> <6ee0706b-d1b3-187a-1557-c4b8173c6e37@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT093:EE_|DM4PR12MB6135:EE_ X-MS-Office365-Filtering-Correlation-Id: d87b0bd3-153e-48e3-c13e-08dac2edfc11 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P2wrq54nRsBi/kT/z1udaWq2eM5gm1IqNnfb1ep03wfaYjFR8ZWG7HaIqRQBGco4nigEhe5XrszFLUewaaclbKx5DCuf5LhTmi5RIC2nYZmszodSVRPr/WBgcXWNalR8uNuQVVONCoxLNa94tVPR6dR0YIveE7fb0rIRlGiJii9+cGPVhq/PvaSo/iEBKVjQ+PpVQ20a3GbuDyI63PoN1PlIU0eoJEAK7DwqbtB7obrsMZ8FfD1K90bttWfV4USWd2C76ZJB3Q9zW9Ln9xFrCyFj0I9Ruye6cwySfVzlXp36q++a6GBkluuO57stEhrDOeo3iirEhYfe7v7b5JLjSsDCfVdr4W8F37JERgTSlJkjyuXiSN8AGZY+2cG9JUWXYwRmiCVmhPWngxbUmTwkfB5USe3MFCJcSHfG2FYo1U1BHfV8YA2w3wDSn0U0x6foTtchVvmVGpZzNi7hzx2fr3FgiTrjWRVM1Umyq5+MNw194WwQVlcIvsbDbgTsRF5t96IvnDVXhqE13NlyfIiqpdqRP6lMxiv9EhpQlVauSKXwYV8vRl2z1WG3RrN9HCkaYmf3wSFMO/Vum7fZrkZpqbxMqaxbKhv4yYTCg0ritLRUB7WNtN7h1zqHlhMlMaMglVqHMtC4M8umsX+kbEdMSZkGWYqkKo7PheMR/PrOJtZBxuwOSiOF6F9zBx0CCAUZDTnCU5AYT+DvZ393U5006h+qoFnDozDn2ci/FayCvBx4Gs4Oe010ElJfZhXBw84QOj8QaSZRV0WRXTCgteTPs2jbz4h/P1vq1ZDO81BruYLPywy7ptaAYlXNEOoKs0zd6yjZC07VlRrScWc5YF1M+PD/RGOJMJmFFH7O3U0ETLk7d5d4vcT5rRl6Ru7THasG X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(136003)(451199015)(46966006)(36840700001)(40470700004)(44832011)(41300700001)(36756003)(8676002)(16576012)(70206006)(54906003)(4326008)(316002)(8936002)(40480700001)(70586007)(6916009)(2906002)(45080400002)(478600001)(5660300002)(36860700001)(47076005)(966005)(356005)(82740400003)(81166007)(53546011)(26005)(31696002)(86362001)(336012)(40460700003)(83380400001)(426003)(186003)(2616005)(31686004)(82310400005)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 07:34:21.7622 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d87b0bd3-153e-48e3-c13e-08dac2edfc11 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT093.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6135 Hi Stefano, On 10/11/2022 01:18, Stefano Stabellini wrote: > > > On Mon, 7 Nov 2022, Michal Orzel wrote: >> Hi Bertrand and Stefano, >> >> On 31/10/2022 16:00, Bertrand Marquis wrote: >>> >>> >>> Hi Michal, >>> >>>> On 31 Oct 2022, at 14:39, Michal Orzel wrote: >>>> >>>> Hi Bertrand, >>>> >>>> On 31/10/2022 15:00, Bertrand Marquis wrote: >>>>> >>>>> >>>>> This patch series is a first attempt to check if we could use Yocto in >>>>> gitlab ci to build and run xen on qemu for arm, arm64 and x86. >>>>> >>>>> The first patch is creating a container with all elements required to >>>>> build Yocto, a checkout of the yocto layers required and an helper >>>>> script to build and run xen on qemu with yocto. >>>>> >>>>> The second patch is creating containers with a first build of yocto done >>>>> so that susbsequent build with those containers would only rebuild what >>>>> was changed and take the rest from the cache. >>>>> >>>>> The third patch is adding a way to easily clean locally created >>>>> containers. >>>>> >>>>> This is is mainly for discussion and sharing as there are still some >>>>> issues/problem to solve: >>>>> - building the qemu* containers can take several hours depending on the >>>>> network bandwith and computing power of the machine where those are >>>>> created >>>> This is not really an issue as the build of the containers occurs on the local >>>> machines before pushing them to registry. Also, building the containers >>>> will only be required for new Yocto releases. >>>> >>>>> - produced containers containing the cache have a size between 8 and >>>>> 12GB depending on the architecture. We might need to store the build >>>>> cache somewhere else to reduce the size. If we choose to have one >>>>> single image, the needed size is around 20GB and we need up to 40GB >>>>> during the build, which is why I splitted them. >>>>> - during the build and run, we use a bit more then 20GB of disk which is >>>>> over the allowed size in gitlab >>>> As we could see during v2 testing, we do not have any space restrictions >>>> on the Xen GitLab and I think we already decided to have the Yocto >>>> integrated into our CI. >>> >>> Right, I should have modified this chapter to be coherent with your latest tests. >>> Sorry for that. >>> >>>> >>>> I will do some testing and get back to you with results + review. >> I did some testing and here are the results: >> >> In the current form this series will fail when running CI because the Yocto containers >> are based on "From ubuntu:22.04" (there is no platform prefix), which means that the containers >> are built for the host architecture (in my case and in 99% of the cases of the local build it will >> be x86). In Gitlab we have 2 runners (arm64 and x86_64). This means that all the test jobs would need >> to specify x86_64 as a tag when keeping the current behavior. >> After I built all the containers on my x86 machine, I pushed them to registry and the pipeline was successful: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fmorzel%2Fxen-orzelmichal%2F-%2Fpipelines%2F686853939&data=05%7C01%7Cmichal.orzel%40amd.com%7C2449f063e67341c3b95a08dac2b112a5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638036363027707274%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=EwTJrW2vuwQIugKc7mnzG9NNbsYLP6tw5UODzBMmPEE%3D&reserved=0 > > When I tested the previous version of this series I built the > containers natively on ARM64, so that is also an option. > > >> Here is the diff on patch no. 3 to make the series work (using x86 tag and small improvement to include needs: []): >> ``` >> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml >> index 5c620fefce59..52cccec6f904 100644 >> --- a/automation/gitlab-ci/test.yaml >> +++ b/automation/gitlab-ci/test.yaml >> @@ -65,6 +65,9 @@ >> paths: >> - 'logs/*' >> when: always >> + needs: [] >> + tags: >> + - x86_64 >> >> # Test jobs >> build-each-commit-gcc: >> @@ -206,19 +209,13 @@ yocto-qemuarm64: >> extends: .yocto-test >> variables: >> YOCTO_BOARD: qemuarm64 >> - tags: >> - - arm64 >> >> yocto-qemuarm: >> extends: .yocto-test >> variables: >> YOCTO_BOARD: qemuarm >> - tags: >> - - arm32 >> >> yocto-qemux86-64: >> extends: .yocto-test >> variables: >> YOCTO_BOARD: qemux86-64 >> - tags: >> - - x86_64 >> ``` >> >> Now, the logical way would be to build x86 yocto container for x86, arm64 for arm64 and arm32 on arm64 or x86. >> I tried building the container qemuarm64 specifying target arm64 on x86. After 15h, only 70% of the Yocto build >> was completed and there was an error with glibc (the local build of the container for the host arch takes on my machine max 2h). >> This enormous amount of time is due to the qemu docker emulation that happens behind the scenes (I checked on 2 different machines). >> >> So we have 3 solutions: >> 1) Build and run these containers for/on x86_64: >> - local users can build the containers on local machines that are almost always x86 based, in short period of time, >> - "everyone" can build/push the containers once there is a new Yocto release >> - slightly slower CI build time >> 2) Build and run these containers for specific architectures: >> - almost no go for local users using x86 machine (unless using more than 16 threads (which I used) and willing to wait 2 days for the build) >> - faster CI build time (arm64 runner is faster than x86 one) >> - someone with arm64 based machine (not that common) would have to build and push the containers >> 3) Try to use CI to build and push the containers to registry >> - it could be possible but what about local users > > From a gitlab-ci perspective, given the runners we currently have, we > have to go with option 2). We don't have enough resources available on > the x86 runner to run the Yocto jobs on x86. > That is what I reckon too. Running the Yocto build/test on CI using x86 runner will always be slower. So, if we go with this solution, then the following is needed: 1. Modify test jobs so that yocto-qemu{arm64/arm} uses arm64 tag to be taken by arm64 runner and use tag x86_64 for yocto-qemux86-64. 2. Come up with a solution to build the yocto containers automatically for the above platforms + possibility to specify the platform for local users. Right now, these containers are being always build for the host machine platform, so without doing tricks like adding --platform or prefix to image name, one cannot build the Yocto containers that would be ready to be pushed to registry. We need to have a clean solution without requiring user to do tricks. The only drawback of this solution is that the person building the yocto-qemu{arm64/arm} container and willing to push it to registry, needs to have access to arm64 machine. > >> Regardless of what we chose, we need to keep in mind that the biggest advantage to the Yocto build/run is that >> it allows/should allow local users to perform basic testing for all the Xen supported architectures. This is because >> everything happens in one place with one command. > > That's right, but it should be possible to allow the Yocto containers to > also build and run correctly locally on x86, right? The arm/x86 tag in > test.yaml doesn't matter when running the containers locally anyway. ~Michal From xen-devel-bounces@lists.xenproject.org Thu Nov 10 08:09:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 08:09:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441514.695619 (Exim 4.92) (envelope-from ) id 1ot2cm-0004oh-15; Thu, 10 Nov 2022 08:09:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441514.695619; Thu, 10 Nov 2022 08:09:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot2cl-0004oa-U0; Thu, 10 Nov 2022 08:09:23 +0000 Received: by outflank-mailman (input) for mailman id 441514; Thu, 10 Nov 2022 08:09:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot2ck-0004oU-Rg for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 08:09:23 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80051.outbound.protection.outlook.com [40.107.8.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fae5b502-60ce-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 09:09:21 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8121.eurprd04.prod.outlook.com (2603:10a6:10:24b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.23; Thu, 10 Nov 2022 08:09:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Thu, 10 Nov 2022 08:09:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fae5b502-60ce-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=imXC9ewODNoFcLlZ8g2twtnP7k7RwIycWi7DgFZ845mJTIUf8rswoDuYbKf6hEEk9wtsffeQCRkXe1pfmk+n+f2OJzRRj4tSc5UpOfUQAkMaL0mZu2U7UoG1mF+DwGSe1dRZoR1mjKv83iZepS53fKM4M7McDEBFvWc+JvQo/rppqGfc61FGCR14/12eeyitZUKjEZj0kd6xZJajNHHG6WLZzFNJ48uNMj/9YzrJIlN2oKkNmalVcukKxzvCsj8rrLmblTrYrXWruIO47NxPKtHDot38MkkKmji7MFjQbVhmcx1iy/ELC+sGVgmCPvk36Ixgn5tjGW3SVvCCEPGnfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HVSJXv1ijN7Q+dCnzUCeiK3AKBL9AoHcmMUtt6QAh6c=; b=DFI2jdyHNUZRSdqbTJ5nGm4jbaGQepRziYxRevLFNvucn0bs7hXcW5IQvq/9RlRZH9BJxAD7Ixvp75H+V2mW1bLulFqVR4OOx4hdbc4u0nrWIeBnyog4ffwmGIQXGk1odTHAXk7bxOrQLH3bFDjTqi+4xOKoOJFt2q/PRF7wN2JiJ5n2tIGqZ3EuB+yn+lPVnttpZHnaqVUpwoZZ4K7InZ0ySxo+v9W75EMobjDCerDxSpNFbfCQBAENL4MrPGWhHGgorY8CppAGlamKciaj3WNZ/npWNMHQwg/7SjRozjI8M0Lg6j61k2tk53amYXyLZTWiKES/2E20CNzwh7V1kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HVSJXv1ijN7Q+dCnzUCeiK3AKBL9AoHcmMUtt6QAh6c=; b=wYQPm3fYM5LNoBsinUOyVGuHDkGKh3McfSYATAl7BGkP9rX7xSKph5AIG4/8f+vyTU2gqC/UTgV3Y7LXBggE5iNM7yt63f+fJA+9/yuWj+1BUyTmFQvswXQ6bA0LXKvsZau52EkelY1uHRZ5UZUJSfrSkaFbBnbv/HnH+2P0MVznj2SQsrbdaZ3bYn/K03eio/F+GaPWj7YaC+cqh9D1p4vru8eMmK3PxYlimtP914GmgdmRoqROSN6uvNub+kQYkESzw0Qb/F9NIocz9wwDu+DhrfBfycgU96+bYKXGoVV7oq9zdKA5tjJTYD7g1I0QTfIpRkEHU6MmyuZKsyg/fg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 10 Nov 2022 09:09:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: Revert of the 4.17 hypercall handler changes Re: [PATCH-for-4.17] xen: fix generated code for calling hypercall handlers Content-Language: en-US To: George Dunlap Cc: Juergen Gross , "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Wei Liu , Henry Wang , Andrew Cooper References: <20221103163631.13145-1-jgross@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM5PR04CA0001.eurprd04.prod.outlook.com (2603:10a6:206:1::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8121:EE_ X-MS-Office365-Filtering-Correlation-Id: 35769db0-21f4-4bf5-8838-08dac2f2ddca X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tyv4BAnh3VLkAqxFh3qRM+7QRnAjnvP+VzzlCJad9VLJaGOjib8twp9WIkH1YJ/DTj+cHlKRIhZpIBBp1l3xdNpWsxe5i/B0wV4Mx5rUUpfFW2EMiiX8PqotSUuQ7heclNcwt0kUsIa4bvcoxFlcoW2TQAZx8nNuPnZfuIiyfHcpGNgfdI0GVbFaPlJbWm3AepCc1fARUkw9ZD3MDLWQmvK+TB27K6L9hGQNDyx+GGTGPmuZgg4CEjImMJxWZgr9rh1BYAGvp2eqUlfhBRSz5MDonkV/W1InxqYN/UEVyFBaGqcdFfVxG8VyrDxK8g0lpWzLvB/cxUNMQsV8spL4vcovXMj5Z6fbovt6gq1u3bqPXV9xbJ1gwZVNeBbFc372bGuuiq2fyb7zcEhcyfnjGIb6Czfrf6ZsusWRLHWlg8rzEUkQdoDmugPjZqeUb4tIgjDGRJtdRrgRKuK7Ybog/ulL7rbu2FmgI//iQTch+nJSktBRPdeUyuSm36bY4sircsk8SywGZIpW7pWCtFpSd1v7cODBoedIGsNs3Fg4v7D0r1LfWRQY99DH8obiB79FUpfdHTh0+rKo0DkHCl+ur5HNMg9HPBu6P7Q4EFp4DLFLzHG6hX6zp9XVERCx9SKAYfj6B5M3dNED0lRzqHzRdTwL9N0ekURkPAFwC/rHC3vJfQYKl+l44Y0pC0/3uVp7wZUmbF/mdaNAYzmVCAnXmHm6rz3Aj+PfYTh+UMwSxAou7Py1XO/abujhNQq+8Y1ry6Ev5W+h7XOIdbuiW1Zt/qFUPEd/Rg44QTppv2AFOpk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(366004)(376002)(396003)(346002)(451199015)(4326008)(6916009)(66556008)(316002)(53546011)(38100700002)(54906003)(66946007)(66476007)(8936002)(5660300002)(6486002)(41300700001)(8676002)(6506007)(478600001)(83380400001)(186003)(26005)(86362001)(2616005)(6512007)(31686004)(31696002)(2906002)(66899015)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c09rVUlxRzltZHBYd0VrK3lUY1NNK3pkaWNSVVAyNTdCR2NXbUlVaUNsT3pW?= =?utf-8?B?M0ZlbytTZStneDllUVFiUzRIRjAyd0NScXFIVWM1RUw5WWxXYUZ1RjF5YlUx?= =?utf-8?B?SVFPRURXRmZYVGhOS0d6cTdXUFdxV3VWTGRXNG5qMW1TeXZRTTJJdWdlNkor?= =?utf-8?B?aFZmNm9Ja2pBd2VaN3orUU8xSStpaitrSUtSei9PZitSVEJZdGsrS29pa2Y2?= =?utf-8?B?TEVGOUpJNmowTzVTanF3WDF6b0tvZGlWemRuMEg2dGkxQjBOTVFxT3dGcnZL?= =?utf-8?B?UUhhdGw2ZmsxY1ZNUCtPTnpyd2NIUXB6czk2WndPdkRZUnNoaFN3ckdDdFFB?= =?utf-8?B?WldndnNtM1FaNHBoSDF5Rnd3ZmVwLzRrenJLNzZmSThhQUc2ZXhNakpHSDJU?= =?utf-8?B?Ky95eUFJSEpMYnU0ZVpKY0hMeC8wSHcyZ1ppajRONS9mUHNqeC9ndUZncVlI?= =?utf-8?B?akVCeS9SamQwT3VrUUZFdDB1ZGFTc1Zid1FJQnVkMy9vYVFpc2VvK2V5Ri9G?= =?utf-8?B?ZWs4M0Mxd2VBOXJrZW5EOWJFNkFpOTJ2S3Y5ckVGaytSVW9wczZaOERYR1Uw?= =?utf-8?B?dkg1ajIvZmIxR1d0d0tWb1RrUTJEZTAyT0N0YXBaRDlEZlFqaHA1TFJuZzBX?= =?utf-8?B?b1pNNlZQbzQ0c0pxZzZoOXU2UzVXa2NtZk1HQ2s5UnZmb3BFVnl6dkVzWlg2?= =?utf-8?B?OTZZLzRubVRrTXBaVHFIRGFCRGpsMjg4VG1FbS9oM3djWVdSY1VWVWR1dE9q?= =?utf-8?B?OGhkbytZd1I1N3QxTHNNdy9TOHVnZ001Qnk0aVlvSS9rWEVXRXNZdVo3ek8x?= =?utf-8?B?VWt1NEtUL2tFeVJqZDdJTWJxRWxWYTNKRWp3OENJT3JBbVpaSXpuMFgzT1J5?= =?utf-8?B?SldKZE9Wam81L0NzMlVwUG1WRkxRTDNkRVJwSUlQcWViTEtueGkzZ2FuNlQw?= =?utf-8?B?VzZxT1JaWVovOFpTbDFacUhlVzlMZjgxaHRwVjNoc1dEQmlITlJRUGhxaFZQ?= =?utf-8?B?ZEU0cmMwR0NrMlpTY2hIWkZZVmZad2dtRUtPYUtHbVR1ZXlmMHB6MnF1V2pz?= =?utf-8?B?eEJoMDFidjQ5OEMxRitvU3ZkdVp5ZlRaZ2J6M1pXVXdiUmhFWTUxaVluWW11?= =?utf-8?B?WW9XQ2xDU1FIdkt3K3Y4RERNYWZsS2ZyNE05NUJLOXBWN2ZpVlRXcHBwRmpN?= =?utf-8?B?NmE1Rk52cWg2K013Sm4rVmtRZDFJK2pOakVhUXluSzMveW1obTBjQkp3czQw?= =?utf-8?B?Sm53WEI4Vzh3SStEMUY0Nm0zeFJWa0w1Q0ZYRW5Zb01uU3plNUN1c1hYS2k1?= =?utf-8?B?VzFQSmxrdHpVWmtkdXRkai82YkVXM1lPUVpxVFpDNUV6YzlwWWRuZzlMVDZY?= =?utf-8?B?Zmt1Y21reS9PUmplblpHMis2WWZtN3NsZUtUaHFYZlhoTFpFQTNPdi9vaXpF?= =?utf-8?B?emxyNVBveVFsWGEyS1h1bkVVWkxpZHQyVVhYY0NJYzI3aTQ5N1JxNFNaMGp0?= =?utf-8?B?UmRRaHJMNjhUak12UHJwcnJIVC8xSkowdEJJWHhPR1BKQmlKUlUvQk1RNW5E?= =?utf-8?B?dHMxMFZnZ0t1blZPTE5ZQmxxQ2ZVWXIxZFdNbWxieUlVWnlMUE9xOG1mUCtr?= =?utf-8?B?MFBsajJhNmFMUUt0THNkV01VVDhJTk1DNUhOT2hxa2NGcXFLb0MxRDBtWVc3?= =?utf-8?B?OXEwelBQV1VlQlRJMlQ4dnRGVE56cG16Q2pmanpXVkMybjBxQnF0VmJnbHl4?= =?utf-8?B?OTVUZXpuWjBFUm5ONE0xcW9lTGE2Y1kzNUwvQ2lqdTdPTWgreHpEYUlScDgz?= =?utf-8?B?OXJ3U0pRMDlzR3gvUDVGZEwvMkYwTmYzeExqSHRya3FQRGs1WXBESTgyUndF?= =?utf-8?B?eTRVTC9RTk5MTDNZdnhMU3RoSlcyNG9udkdrWnA0UUl3MW8wNVhvOTU4cnVB?= =?utf-8?B?YlBxUmxFTkNvcWNTZVhqRHJrM016TUNOU2gxNGMwYzMvTHF1dC8xUzJMenFk?= =?utf-8?B?a0xjU1c3clVadXE3THRzYW92bjJ1VU84SGtaTDdhd1R1MXM4YmZlK3JLUlhL?= =?utf-8?B?NDJwYWEzaWFyeVpOZ3VyR0k4ZWE5RzE1ZzAwd1lDZDdESXhzTUFEWW01UlJh?= =?utf-8?Q?bwGBSR35wFPMUPbsJ/GjGRe6z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35769db0-21f4-4bf5-8838-08dac2f2ddca X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 08:09:18.6508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +ktZ5eQV5gI/gTh1fQYTJ6JlAsl56EkIj4wkIfbP5BOeE7uDCN2w/dcUGHuOo6HdhrB26WlPQ/AvIBjxLOXAyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8121 On 09.11.2022 21:16, George Dunlap wrote: >> On 4 Nov 2022, at 05:01, Andrew Cooper wrote: >> On 03/11/2022 16:36, Juergen Gross wrote: >>> The code generated for the call_handlers_*() macros needs to avoid >>> undefined behavior when multiple handlers share the same priority. >>> The issue is the hypercall number being unverified fed into the macros >>> and then used to set a mask via "mask = 1ULL << ". >>> >>> Avoid a shift amount of more than 63 by setting mask to zero in case >>> the hypercall number is too large. >>> >>> Fixes: eca1f00d0227 ("xen: generate hypercall interface related code") >>> Signed-off-by: Juergen Gross >> >> This is not a suitable fix. There being a security issue is just the >> tip of the iceberg. > > At the x86 Maintainer’s meeting on Monday, we (Andrew, Jan, and I) talked about this patch. Here is my summary of the conversation (with the caveat that I may get some of the details wrong). Just a couple of remarks, mainly to extend context: > The proposed benefits of the series are: > > 1. By removing indirect calls, it removes those as a “speculative attack surface”. > > 2. By removing indirect calls, it provides some performance benefit, since indirect calls require an extra memory fetch. > > 3. It avoids casting function pointers to function pointers of a different type. Our current practice is *technically* UB, and is incompatible with some hardware safety mechanisms which we may want to take advantage of at some point in the future; the series addresses both. > > There were two incidental technical problems pointed out: > > 1. A potential shift of more than 64 bytes, which is UB; this has been fixed. > > 2. The prototype for the kexec_op call was changed from unsigned long to unsigned int; this is an ABI change which will cause differing behavior. Jan will be looking at how he can fix this, now that it’s been noted. Patch was already sent and is now fully acked. Will go in later this morning. > But the more fundamental costs include: > > 1. The code is much more difficult now to reason about > > 2. The code is much larger > > 3. The long if/else chain could theoretically help hypercalls at the top if the chain, but would definitely begin to hurt hypercalls at the bottom of the chain; and the more hypercalls we add, the more of a theoretical performance penalty this will have After Andrew's remark on how branch history works I've looked at Intel's ORM, finding that they actually recommend a hybrid approach: Frequently used numbers dealt with separately, infrequently used ones dealt with by a common indirect call. > 4. By using 64-bit masks, the implementation limits the number of hypercalls to 64; a number we are likely to exceed if we implement ABIv2 to be compatible with AMD SEV. This very much depends on how we encode the new hypercall numbers. In my proposal a single bit is used, and handlers remain the same. Therefore in that model there wouldn't really be an extension of hypercall numbers to cover here. > Additionally, there is a question about whether some of the alleged benefits actually help: > > 1. On AMD processors, we enable IBRS, which completely removes indirect calls as a speculative attack surface already. And on Intel processors, this attack surface has already been significantly reduced. So removing indirect calls is not as important an issue. > > 2. Normal branches are *also* a surface of speculative attacks; so even apart from the above, all this series does is change one potential attack surface for another one. > > 3. When we analyze theoretical performance with deep CPU pipelines and speculation in mind, the theoretical disadvantage of indirect branches goes away; and depending on the hardware, there is a theoretical performance degradation. I'm inclined to change this to "may go away". As Andrew said on the call, an important criteria for the performance of indirect calls is how long it takes to recognize misprediction, and hence how much work needs to be thrown away and re-done. Which in turn means there's a more significant impact here when the rate of mis-predictions is higher. > 4. From a practical perspective, the performance tests are very much insufficient to show either that this is an improvement, or that does not cause a performance regression. To show that there hasn’t been a performance degradation, a battery of tests needs to be done on hardware from a variety of different vendors and cpu generations, since each of them will have different properties after all speculative mitigations have been applied. > > So the argument is as follows: > > There is no speculative benefit for the series; there is insufficient performance evidence, either to justify a performance benefit or to allay doubts about a performance regression; and the benefit that there is insufficient to counterbalance the costs, and so the series should be reverted. > > At the end of the discussion, Jan and I agreed that Andrew had made a good case for the series to be removed at some point. The discussion needs to be concluded on the list, naturally; and if there is a consensus to remove the series, the next question would be whether we should revert it now, before 4.17.0, or wait until after the release and revert it then (perhaps with a backport to 4.17.1). As per above a 3rd option may want considering: Only partially going back to the original model of using indirect calls (e.g. for all hypercalls which aren't explicitly assigned a priority). It's not just this which leaves me thinking that we shouldn't revert now, but instead take our time to decide what is going to be best long term. If then we still decide to fully revert, it can still be an option to do the revert also for 4.17.x (x > 0). Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 10 08:18:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 08:18:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441521.695630 (Exim 4.92) (envelope-from ) id 1ot2lE-0006V0-VF; Thu, 10 Nov 2022 08:18:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441521.695630; Thu, 10 Nov 2022 08:18:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot2lE-0006Ut-SR; Thu, 10 Nov 2022 08:18:08 +0000 Received: by outflank-mailman (input) for mailman id 441521; Thu, 10 Nov 2022 08:18:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot2lD-0006Un-RZ for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 08:18:07 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2057.outbound.protection.outlook.com [40.107.20.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 33ec9801-60d0-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 09:18:06 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8923.eurprd04.prod.outlook.com (2603:10a6:20b:40a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 10 Nov 2022 08:18:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Thu, 10 Nov 2022 08:18:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33ec9801-60d0-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TpNzGYyq8RFcDidnfGqmU9tbBK+ozJ90XtnM3dCUYXpNmlrCDwl59jug2b0M7rD8PBIKb0LoMgeDcdLNUJ1OAgYuwI2E4YuYS3zLD1PD2sXUXYCWLoDdWXCPyn8/LONxU91+1Hrf27JDkx1UvXktyDioA2sYpAdCXCKYAStFJZE0rUIqqRt/5qmIKbTJiwmuvVInj6RJTwDyYtJeiEn4sFZa13pMHOVu93dUoGpcXtAhHygu5dTMICsgeYS4Aw6D3v+knmUppeEVWzhx0D/7+yAy8uMkro+m6zPw7i950N16VCu0RSmFPvjz/w6/8nRFN00yH+aWGc1AnnonaxaPow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RXy8ox5LfHt1uiC0vqAPAoNcGahR2Lyw6PIIp80UN1c=; b=HGi4Qpz1XyxaK8tMI0rp6wm2oh2HefymCVCwc09R5t3yb6enRikE5PyGu0TpwCW1wPQDUTwWTcd4hT0N/l4b+4vpi1mnlrQuKMv9s7lC4s7+NJomGFiOc8xyLjtMwvxf2kKtMV5vc0GVbFkJEfZK0M9mXcQj7obshVDoR5sF03MAWuWk3RZMbRMfTfWdZ2Cx1VDID3pq3J19PTl+ViCpnNTkczc3YIoHBByfwLlwcXJzqc9SdZA5BwsUNZVZGUB75RqnLRs8Prp0xH1V5nwIK6k/GFJ1jOHh9xzcywx2bQTkd3hnylBJxugZCXpzwo1B//ScHoos70MOOlIIg1x7QA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RXy8ox5LfHt1uiC0vqAPAoNcGahR2Lyw6PIIp80UN1c=; b=JYCFo2tf7pcLjPjNfzaZFUUX/FGHrS7QrueZSTU2JF33j1lIiVOatj91wuaUv4iwiuXKDb/0ijMB0A9I/wi13a+wd0PxTu5B60nQYrI18UX98ErZ5BIbBRj3li3vcoGhf8833ffmGYKXjRIHWV6daheO9B9fbZiX4XCKVBA02e25YIPpqyfVmRzLUM2J4R/JYNW1MRAw2SAuelcAlwYwM3Gka6LnuFMp2jtB2l91B40E154SLG42RqKAeuKkACF/GX80ZN37K9sEVsY6rH2sJ2pYT0Kkv92AtkIS4QcYour3s2kx3PuKMgueOtompCc4fO8nZWSbZuLPVeRyzUJ/TQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0fe79723-d279-9744-b6c5-8c43e6bb29cd@suse.com> Date: Thu, 10 Nov 2022 09:18:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [linux-5.4 test] 174684: regressions - FAIL Content-Language: en-US To: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: Cc: osstest service owner , xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8923:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a2269f3-3f5c-40f4-11ef-08dac2f416f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w5+tKFXSNVtET/gyVF+9PUvcKZFWc4mXv17Qt/nWgrwojiHnbMSwnKE1P+TMVuXSs5ZY4CBTlZc1CTLo28O/GB55jhxw2do+kCKxElMDzCcuIgfOO9sYW5mixj861dYknTMvpiv72h5PnVmwmjJUMOCjBTFdcbPeLDOTjzB+06TdfuTbv5MzEIQXbdBA8X0VEB5HnJbtN2IYU5o//94TuklKDslk6Y14GwFkrMYrhxz/OLPbFsv8jVMsxt806Qa77p7+D7MY9aMd+4Yh5U/wLrXRnUjJGxFe/9xnnGJBQEQk6Tibo1AUNaiWti0PzuX573IKypy4J3O7w+e2hULFpk63fQmwJDVlaNLnBa/wzh/mNzDj2W/lLs+wNwJTfP6//RhiN1yr5gSE8Eh6QW1r9x1q+T6YszfxOVuZNC7bMY15oefM8WvnYzhgsbzFV9qTrnoEvz799W3US88lBLyT9Ay+nS1Wu6v0vgjR0nbPNF8fn24CT+LCL8HrQorKBM6hIM/CXi7GYjMkNFZ3J1waK49oWJ4iehw8ykcJ4Yj7QbWGicoKv9oQzOeaTVXefrgEuRSNzIyx20WpWWkANl7AhPPIYWahhm15EZri4NR/bxw5IceFLh/zMN8qMUNucUt36yowSD5DkZc7IZ8ZmzRocAw4XqF3W+0sJsBfjHxWFO4bO5X1A2N/vqH4W/9C8yJJteIoontG6BieHHNhBa3dih7BbxGCH8+Tq90HhK7y/14ZXnC1nwKSHP+QxzwS2+pxk47cDVUA+7hvHLPOR+oYjsSVAa2gg/sAf43s+U6UXX9xUxDyBTO7Cu5eYDhsI6oTzR6IgD5WydQDlMbtGSEq9w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(39860400002)(136003)(366004)(346002)(451199015)(86362001)(5660300002)(4326008)(83380400001)(186003)(38100700002)(316002)(66556008)(66946007)(110136005)(8676002)(66476007)(31696002)(8936002)(41300700001)(53546011)(26005)(6512007)(31686004)(6506007)(966005)(478600001)(36756003)(2906002)(6486002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NS9xMkp2NURyak5kUXJ2VWtidXcyRXY3U0Y0cFlNQWovZ2Rwc3k0T3YwV2ZD?= =?utf-8?B?YXVxemNVWGhyaVNsSjluNHRCY29QTkZIRXlteTFCM0FkNW1EN25CZUs1Q1Er?= =?utf-8?B?MGNCRFUyeld5cXNPQU5pZ0VyY3ZaeDUzMHBZdjR2ZTlGMi9oVUFiaGp6akRy?= =?utf-8?B?TjJjNVBtOVg0VmM2SE1Kb0N2SkRnWHRCN3grK1BEWjU4SUlVM1UxYkVucldG?= =?utf-8?B?VXRaVWdodksvU1NIZlNjQmdIWFdSd2pGVDYrSU45RDZSUXhCN2dyM0hmWnUx?= =?utf-8?B?Nm9SeUV1QVBNWTlOTHBMMzMybkRicWJIbTAycnF6ZEJZazEra1FvLzhSOG1Y?= =?utf-8?B?S1d3eVIvYmRMTzN1bFhRYTJWaFN3ZzB5TkU2d3BOUVYwTldEdTM3Um1hL3Bt?= =?utf-8?B?U2JRdnJDSUlJbkxOOE1pNmh0OWx0QzB0L0o4UmZiSFdQYkNFVXM0OFBDN0pJ?= =?utf-8?B?RU8yL05Sd3ZwTW9OVkE4Tm44WllhNVByc0c3Z1dFTDI2UGpKZGtYaXRaTjNv?= =?utf-8?B?c2czeWZDVEh5S3NDb1VVRlMxQXZhM2crbmM1My9KYmZQUkQ0WUpVV1c0QVg0?= =?utf-8?B?bTBJbUZNWG1qUFNqL1FaTHU4dFhEbXNqbnBQNEFjTnkwKzludjQ5SlhiN1V6?= =?utf-8?B?R1pRT1BOVncwOGdORlRhY2QrS3JQalFCZW1zZ2t2NTd4OCtJVGFzU3IwRzFz?= =?utf-8?B?Z0FVMVpkekhxcmxrT2VsVDNCdHhWWmZxcmFHdVFHUFJnVGNjNnJQOG9oT3RB?= =?utf-8?B?aThVZUljcDhtUkN3OUthcnVRV1d6bWkxNktpeU9qYWhtb1B1YXp3WFQ5cXdQ?= =?utf-8?B?Q3lHd2xNZWxZaTBYYUpOUkRlZVgvOUQ0cDBzL1ErWHZsam5mdTl2L05oUFEy?= =?utf-8?B?U3U2MnpLa2ZDZVVaSzRmTnZyaVdYV0NtSzlaWUtOclN6SXN3ZnorM3JvM0Fu?= =?utf-8?B?U2F0UFlWVGthbjYwYnFCK0RxdDhEcDh4S0xMZ0pMbE80Q1dtWVJFUktkVjUz?= =?utf-8?B?M1MwdUxpekRvNzRWK3ZENXNQcy9lbnpXZ2NLR0xCUG4reGFKei9yL3lGRnVx?= =?utf-8?B?TW9pSnU5M1pBcXBwMVlseVdXanZGSWxTekZ4V29qNUVmUVgxWUc0Q3owRVcx?= =?utf-8?B?Z1NsR3RBVzcwUTJaZUlsK2dKK1Z2YTJORWxLd1FHMFR6R2dkNDJ4Z1JKRU1i?= =?utf-8?B?M01JaE5KT0ZIV2JzRkFRK2JLOVBuekl0SlhwL21mK1crL2VLUmZLd0dBSGpy?= =?utf-8?B?RCt3SUYyb0tVYk5oYWcwNENneldTN3pzaGYybndwVGtVTGFNcGt1dDRma0l5?= =?utf-8?B?YWFDdzJWQ0cvV3dmWTdsZ1k0MWdrdVJ6ODlWeWFkeGJGV0t3QjYyM1VtT093?= =?utf-8?B?Q3o5TjJhaE9QRnFid1hPODZEcmMvZ0hIV1d4TUFmKzlsODBDd2tWZExMNm0v?= =?utf-8?B?TjdsYkhkZ1ZLb1c5NTNlT1pvS0tDb2hkOHV4ZVJya2JOQmdkVnAyL29Qb0M0?= =?utf-8?B?djYvTXRPQUk4eGlMVHU1Sk0zNFZsYzZ5cWw1VERRdTRSR0t5Um9ERlRBQi93?= =?utf-8?B?aHZnSnBxNlpQK0hsY1VEL0Y1VkQvdFdoOFVQaUNwQTJCc0lncEszbmsrK2RJ?= =?utf-8?B?RzR0WFRGRTg1MFFVMFJxckFETEFiTklaeE9XZnNzWEwrdHdBaFlqbEJNZW1n?= =?utf-8?B?TjkvRUZzWnA3a2RQQlJPVmhCZzVFVFlQbkQ2YkZpaEpqWUlRa1RDZ2ZoMmY5?= =?utf-8?B?U05OVE1jUkVCV3MyanZTOVJSZU5hc1hhUUovQ2tMT0VvVExQem9NNXprYUpr?= =?utf-8?B?S0VmZ3VYUDJGeHk0T0x6YzdvZ3hKRHJiZXhGd2VITUV1aHorcm10SGNWQmdp?= =?utf-8?B?TVVxTUE0ZzJsSnhaWUlnWUl5UnZMTmNmTHovb1ZlS1F4ZkJXMitJVXdVUkln?= =?utf-8?B?alpZTWRwL0RpZDZraDJmZDlBWGo2VnhXWDAyWEFIS3F1ZkhuZVNpcGM0VXdx?= =?utf-8?B?U3FhblFBWExrOXdhUEJCclo4elZCcFJKU0ZmZUNNTU0xa01YTk1MaHMvVlNx?= =?utf-8?B?cGlxSzZwSG43MFFTbHRzSkdtai9VaE1lT05TakN0ZVhTemZQbHNqODh3cUY4?= =?utf-8?Q?IEHNQVVHULJexn8WzUmOMLnPs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a2269f3-3f5c-40f4-11ef-08dac2f416f0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 08:18:04.0705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Jg3V+Pj3OKfosIJo5+zT1vyEqTAUxVu//nv8+D6tv5LhIeeQHfwMkGTInxZ1NIvBYVnN6vDHD9LEfhYqGZ1RPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8923 On 10.11.2022 03:48, osstest service owner wrote: > flight 174684 linux-5.4 real [real] > http://logs.test-lab.xenproject.org/osstest/logs/174684/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 This now looks to be failing relatively frequently (about every other flight), and I'd rather suspect it to point at a hypervisor issue than a Linux one. Looking at the log I found (XEN) d5v0: vGICD: unhandled word write 0xffffffff to ICACTIVER0 (XEN) arch/arm/traps.c:1985:d5v1 HSR=0x80000006 pc=00000000 gva=0 gpa=0000000000000000 (XEN) arch/arm/traps.c:1985:d5v1 HSR=0x80000006 pc=0x00000c gva=0xc gpa=0x0000000000000c (XEN) arch/arm/traps.c:1985:d5v1 HSR=0x80000006 pc=0x00000c gva=0xc gpa=0x0000000000000c with the last two messages then repeated over and over, many dozen times a second. Which makes me wonder whether that verbosity alone is causing a problem. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 10 08:41:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 08:41:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441527.695640 (Exim 4.92) (envelope-from ) id 1ot37w-0001Zx-R3; Thu, 10 Nov 2022 08:41:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441527.695640; Thu, 10 Nov 2022 08:41:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot37w-0001Zq-O4; Thu, 10 Nov 2022 08:41:36 +0000 Received: by outflank-mailman (input) for mailman id 441527; Thu, 10 Nov 2022 08:41:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot37v-0001Zk-B4 for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 08:41:35 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 77102eb5-60d3-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 09:41:32 +0100 (CET) Received: from mail-dm6nam04lp2041.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Nov 2022 03:41:06 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by BL1PR03MB5975.namprd03.prod.outlook.com (2603:10b6:208:31a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Thu, 10 Nov 2022 08:41:01 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5813.013; Thu, 10 Nov 2022 08:41:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77102eb5-60d3-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668069692; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=TXednF7H5KKFrI6WoKZEcOzsDTsiotrORWgCBbkEkpA=; b=WSdvVBYXFV2uUOjjQZNZyUio194t6XKnK8pF32Q7hKEtVz/iJmhOGqWw H1GaqXZuNb0O10Vq4EAbd5uUJRx7H/I6o/Mm9dTa7fQFlmwA/tdu/3Zhd DY+fknqCvhw6Ig0YWKbeyjEpRZu1Wub8eYqOoPsN6dPZEYxjJ+lGc/mbL o=; X-IronPort-RemoteIP: 104.47.73.41 X-IronPort-MID: 84139638 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:MwCAw67pvyxWjY/jYp2gBQxRtPfGchMFZxGqfqrLsTDasY5as4F+v mNOD2iAM/feYGX3KN1/bozk8EJV75DdyNcwHgtp+SgwHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkS5AeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m7 fMgKioiT06/g924zfGhb7R2je07I5y+VG8fkikIITDxK98DGcyGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Ml0otidABM/KMEjCObc5VhEeDu mPP+SL9AxcWNdO3wjuZ6HO8wOTImEsXXapCSOTjp6Ax0DV/wEQOBhk1FnKdmsPloXObd+9kM GlN3zIx+P1aGEuDC4OVsweDiF6JuAQNHeVZFeIS4RuIjKHT5m6xBHUATzNHQMwrsokxXzNC/ k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMt79D9rakpgxnIT9IlF7S65vXqHRngz jbMqzIx74j/luYO3qS/uFzC3TSlo8CVShZvvlmOGGW48gl+eYipIZSy7kTW5upBK4DfSUSdu H8DmI6V6+Vm4YyxqRFhid4lRNmBj8tp+hWA6bKzN/HNLwiQxkM= IronPort-HdrOrdr: A9a23:OhIzOKCxCKI2UPblHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkWwqc5Ew6sN5m1q VXm2qfqppMFBvF2D/w/t7SSnhR5wOJSepLq59ts5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7gSwlGl/NLAgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vcPHmZw == X-IronPort-AV: E=Sophos;i="5.96,153,1665460800"; d="scan'208";a="84139638" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ksLfTf9WY/n6jycoMKvWcFgF36SbKLynvJ6k3qvmxAJr7ZQkROnxZzNoXoREZwvaowUoEDuAXP0iJ4jxWaFwl54oRISZgL0gWvJqU2nW7LOt/PJdmFIZ8Wo2Ya45ZqWIDaYiKPN+vn2ttQiQQ8j08MsJpohXfCrgpbjBYHGvDX+0EVZtm5e+V93aHQHjgAxhaDf9BWSb+ANj/UjOL9/bjiBmlAQkxTRhRKGyw/NJU7TkmCfQyt3jWU4WExV2CpH/qp9PMOTM5G9C+PLYnx3oJ6xmqlDxh/AhqmZPPk74Nx0uCfohkKh+kBfsOKZJPohjQf4kOTBs8z+/jFEdUJwrHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TXednF7H5KKFrI6WoKZEcOzsDTsiotrORWgCBbkEkpA=; b=KYrDqhbfcmV83egFnZfZEtZINR+Qd3TT4UiE/6bPb1+UQDoBhQLfH+zOkbLNjg+cAlCr3wlvHDG6VmXKy4a3Euj94JosRr/EtVwwr0jLRSVxEN4wYIToKeEnJ1DbhSD2EgPkMCMJZWJou83mXD7h5cE5emcZ/+AVdKsQsGJE/MGoV+So+hdobSOz5Pt1tqhKzToORwjt2eGU4dPSjWfK8Z+AgrGVN1LHKnN2C/0zkGL9vWxtRyq+tpvwJfxI4aiirdq5esQUfsyF9USdFfqX14Gp0Eq4EN2Bj9iiWqL91LVKBKGjuaLUmwUNJjv5T7wlNMr2IMV79URfsibss0gIwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TXednF7H5KKFrI6WoKZEcOzsDTsiotrORWgCBbkEkpA=; b=UdNYPSwg/uMZIOcJrnHhsoM8dETNQLsSTni/R5Z15+oMu8vewXxE7KRrjm/KmJV/njaRVfdrsFqnEbrQ6mhEV9kIzMSdcsW+SQD0ULBUJPO7+G+/PD9UD3SfZ4B+a1trfHiN5MztUtqahcxTAs5y626SxaKbv4ak4DK5PSqmjAI= From: Christian Lindig To: Henry Wang CC: Julien Grall , Edwin Torok , "xen-devel@lists.xenproject.org" , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Index: AQHY84fBVQkM1eqLakCv8k675veNsq41MEgAgACx3ICAAfcdAA== Date: Thu, 10 Nov 2022 08:41:01 +0000 Message-ID: References: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|BL1PR03MB5975:EE_ x-ms-office365-filtering-correlation-id: 0332440d-142e-4432-b2c7-08dac2f74bd4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eEOU5jP419r1LcniE9r/ItC5DuBS149cvOTXmOSdger+cE32Bhg8OkIzWqbIGYtd8J4GbYICGHMLR6XJmDtc6wMsAJxe1XmRHlVdv2Sv1m/KldnNL1dbgVXb20TAhrQFsHC6RtVEQOYXN/L1L3oqzMS0XDSvALoJHdyMe0vP9eOuqnyKe8TALFlVXZHOXf4H2Rw3a4081k4SNlqYwLhF0eekNoIlVvlpWLFUPqaG6u3BdMCwhsga64u6V0Qp2vx47Fazs7CgXmOu1LOsqZNS80m9VYrpQN8VpIcSW0AhAcbX0Fu2zhuJvbVc+cLDPLsYOR+2ucoGkziOKLuLRhcQQQYA71VQweC6ZCgJv5KOuyw+xap3eUk+Pxj2yuMEUsOCGt7pnVOz+pIXeP28Zv5jOSX6RCN6AjjYWhMikr9x+dD5O4UicB3JU7APQpTF19qkwhxkRiq5PxPreQZ71Z2Fae++X/9JOyRuFEEqonKaMJubTFqSbUwEq7vrxu9Vi6DFlavEnx5lgBcW/oIorwSu5qmLxf4iEabddurfRQDmhKws/jOYv04KpaoUkM2WtGi3uTHAxV8KdpGR3OzqZvnvBJMKw+UpnK2WCcy4sGOqBlyRHxHvfjmBndhtD9otZ4GXiLMWPiO7nrq0dj36eB6l9y/bkr+xHtnGEl2Lqi4nn6cEBjO9hbwN7kuFl1DrFhjG0PFVe+2qfIOV6B+MFCeoF8vBNmnjEXjWDEgbrh4J2uUSsd+Xmipzx4muyRg7xQOtkvI/KQB7AOVZv4NYpgNBbZu61hViupd58G2LXe5jBGI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(376002)(396003)(366004)(451199015)(36756003)(33656002)(82960400001)(38100700002)(122000001)(44832011)(38070700005)(83380400001)(86362001)(6512007)(66446008)(2616005)(6486002)(91956017)(53546011)(76116006)(186003)(66556008)(478600001)(71200400001)(54906003)(316002)(66946007)(64756008)(66476007)(6916009)(8936002)(5660300002)(107886003)(4326008)(41300700001)(2906002)(26005)(8676002)(6506007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VVNMZnVESTZ0UlB6RjF1ZjI1Z1ZXMnFWMFFQOEd4bFEzOCtXcHlvMXc5dE1u?= =?utf-8?B?Wkw5NWRyVHZRNnVaaHJweU1PbDBHTUdWZ2JqK3cyMFBpSHFSOElDdDRaMUFH?= =?utf-8?B?U2JMN01QanNidmVjWTdvcHRSM0lDdGtPRGd0RWk1Q2tMNE45VUhsQVBWeG5O?= =?utf-8?B?YjNzSVV4ZkhWUkVFUlFjSkI2V0tvZDlQZW5oRVZFWFBNWmJYUnk5WjhyZE1S?= =?utf-8?B?RXZJZ2ZqUjFDNXFmdUE2VTBrblphSFdSMU5iMWtGVm9POTUzSGtZMWxIRXAx?= =?utf-8?B?dng0S1MyU1k0M1NOQ1pZSTVWYU1rRlV3L094djE3N1drdTFCY3BRVmpuVzNa?= =?utf-8?B?c0s2VmdNRzkxVWlZSjVrV202a2RoVmRBR0ZwWUg1bmNvNWtRZ2Q4VEhqWG8z?= =?utf-8?B?VjQ3M29ybWpkVklpWXdPak50L0p0T1ZFNDhtYmZFNzZTOWNWNFljMDlOdmha?= =?utf-8?B?ZmlwR0duQUI1V2VjbzNwKzRYdktLOENqbUh0cDU3ODJNdTBpdVNEK0NJSXhF?= =?utf-8?B?MlV1ZTlMWXZKTjVqRlQ1UjdPU053bGd5ejJtM1dnZndLai9VRjZqbWMzRGd6?= =?utf-8?B?Z0J3OUhUVytBWmFOcWpCaUJaYkV0QjlFSVU1SUdTN3o4M2tCQ1ZvTmJPS1RV?= =?utf-8?B?ZkRYWlBFWk1XNVFOREt1QTByVWliZ05ZcWdadnFuc05mbXAyUXduQ1ErYmg5?= =?utf-8?B?dW5GTlovRXB6WGZjd2xSOVR2bitGS1l4d0NubW1zL0VONGNaazRDNFk1T0lk?= =?utf-8?B?NzF5aDYzMkZVNndKek9qZTlkMnhIUFJwQnpueEJFeUlEUnR6di9RcFhZcVR6?= =?utf-8?B?TUFIdEFndjRGWnp5cnVkeXB3cnQ3SkhOZUpraERoNHJIa0JlNUZOTG5EQkNJ?= =?utf-8?B?L2toN1F4YnVOTmVvcmVWcS80MVpubXZVZ29WVjJrWWduczJWaFNJREJ3RFZQ?= =?utf-8?B?KzdKSFBQbDRZd2JoRVFiQWdpL21wZUVrWnpaUEdPcnM1d1dUb2NpdnBndzBx?= =?utf-8?B?SzdqeG9iOU9FR2lJeGpVS2djRWVJK3ZRL05RUEt5VS9iSVBPYXpnb2NWQy9J?= =?utf-8?B?NW1BTEZMcHdEejZIWnRlQisyR1hCOFhGWkkvcnpLKzVoS1haNk94MTEvSmpi?= =?utf-8?B?Y29xcGg5dGs4eUdveS9FNC84dUU4aFdaTkVHOUM2Nk8yY1hoMTI2S3pWOHY2?= =?utf-8?B?NHdSMnFFY1JDbGs3eEZDUUltUnREZ29LZ3J1NkI0MHBqVXA3REQ0VWFMeHdT?= =?utf-8?B?NjdnWkpDNS9yUjhYMmh4dXZmWDJaNkxYVjgvNDlybnhaOC9ZY2RpRk53RHc3?= =?utf-8?B?NmVGTUl0VXBHUzFKeXBXeU4xck1Jd2szdnRYQ2ZrZld3TStUdGxDeUZvZHdk?= =?utf-8?B?ZmcrS3BlL1ZnaWNsbmR0aWVLR2c4dEk1eTJJc2lheGZCYjRMM2R6cEM0K3lN?= =?utf-8?B?TE5GbzQ1NndxVEZHdDRkdlZPTWN1cFJKVC9YRkNHMlpPYVdqdHFQTi9LQW84?= =?utf-8?B?VFVPVDQyeHBXV0NHdmxjbGFXaUdEbHNidWJKVEVMOUhpWlluUzNVYmRsUW9k?= =?utf-8?B?WWE3N2wrMjJSNFZnV2xiUlczTzFSdUpNNlRKdkYwSFRnaklNcXpzSjZhYXR1?= =?utf-8?B?ZFNUUlFBRE9xY1pZMzZZV1lnMkRaVi9MVTFnWTNyMlNkenozSzYwN3RaZEEw?= =?utf-8?B?R3VNNS9XWWF5TzBZdDBBWlppeUFXa2I0T3FsNWttTVQyVnZIejVKaWxOMnJY?= =?utf-8?B?OGhsemxnV01aZkVCR3A2dGFQbW95RkN6R3BpQktyTWJ6N3kxRXIyYmtBdm9r?= =?utf-8?B?SUJyVkl2ZE9HTjJDMExvNnJLazZIeWlQN2w3dFZsaGJXWWxMUDIxUjN1UGpM?= =?utf-8?B?SG01M2h0U2o2cUdmZ3NvdG5yNlI3V0RxZFNISUZLckRZTVlab3dPUm5JRWhF?= =?utf-8?B?QXVOQmxQanJOTEFna0Rmd2ZLMlZ6WkZGdWtlU1lwc0J0ekVoaFk5ajl4STBv?= =?utf-8?B?VUF5aDBTeGk1ZzZ4SC94di9Rc3VmbGNwQUhyQWFqTVd2NUo1bkJuWllUaXJL?= =?utf-8?B?VW0zQzZhL21xMjcwRjA5SFZIL0NmUnViUVdpNFdOVmJ1VFppK0VvU0RoVDFL?= =?utf-8?B?UUtMZ1dGRzg5Y1VUMmNETGRNUTZ5UUtBaGxXWlErT2U4WkFmbHJXeXVLQkxH?= =?utf-8?Q?UJHWD7gkOjbb0cS7GonxFhc=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <219755DE25C70C49AB46A6D0CA02C069@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0332440d-142e-4432-b2c7-08dac2f74bd4 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2022 08:41:01.0819 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wLOVt+Rga+Gr5I77fAJkqWQnhZ2zcB0KaPQOb0GxI1lgzkl5Zh28HmwSwlLI0QP2/WEpBloxKzi8wXPFLTboCWxZUrSfrCgDZc7dSwzujVY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB5975 DQoNCj4gT24gOSBOb3YgMjAyMiwgYXQgMDI6NDAsIEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJt LmNvbT4gd3JvdGU6DQo+IA0KPj4gDQo+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPj4g RnJvbTogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggZm9yLTQuMTcgdjMgMDcvMTVdIENPRElOR19TVFlMRSh0b29scy9vY2FtbCk6IGFkZA0KPj4g J21ha2UgZm9ybWF0JyBhbmQgcmVtb3ZlIHRhYnMNCj4+IFdoaWxlIEkgdW5kZXJzdGFuZCB0aGUg Z29hbCBhbmQgc3VwcG9ydCwgdGhpcyBzZWVtcyB0byBiZSBhIGJpdCB0b28gbGF0ZQ0KPj4gdG8g ZG8gaXQgaW4gWGVuIDQuMTcgKHdlIGFyZSBvbmx5IGEgY291cGxlIG9mIHdlZWtzIGF3YXkpLiBB dCB0aGlzIHN0YWdlDQo+PiBvZiB0aGUgcmVsZWFzZSB3ZSBzaG91bGQgb25seSBkbyBidWcgZml4 Lg0KPj4gDQo+PiBUaGlzIGlzIGNsZWFybHkgb25seSBhIGNvbWVzbWV0aWMgY2hhbmdlIGFuZCB0 aGVyZSBJIHdvdWxkIGFyZ3VlIHRoaXMNCj4+IHNob3VsZCBiZSBkZWZlcnJlZCB0byA0LjE4LiBU aGF0IHNhaWQgdGhlIGxhc3QgY2FsbCBpcyBmcm9tIHRoZSBSTS4NCj4gDQo+IEkgYWdyZWUgd2l0 aCB5b3VyIHBvaW50LiBJIHRoaW5rIG1heWJlIGRlZmVyIHRoZSBwYXRjaCB0byA0LjE4IGlzIGJl dHRlciwNCj4gZ2l2ZW4gdGhlIGRlZXAgZnJlZXplIHN0YXRlIHdlIGFyZSBjdXJyZW50bHkgaW4u DQoNCkkgZGlzYWdyZWUuIFRoaXMgaXMgYW4gYXV0b21hdGVkIGNoYW5nZSB0aGF0IGNhbiBiZSB2 ZXJpZmllZCB0byBub3QgYWRkIGZ1bmN0aW9uYWwgY2hhbmdlcy4gRWR2aW4gaGFzIGRlbW9uc3Ry YXRlZCB0aGF0IHdyb25nIGluZGVudGF0aW9uIGhhcyBtaXNsZWFkIHJldmlld2VycyBpbiB0aGUg cGFzdCBhbmQgY2F1c2VkIGJ1Z3MuIE5vYm9keSBleGNlcHQgRWR2aW4gaGFzIGNvbnRyaWJ1dGVk IHRvIHRoZSBhZmZlY3RlZCBjb2RlIGluIHllYXJzIGFuZCB0aHVzIGl0IGlzIG5vdCBhIGJ1cmRl biBvbiB0aGUgcHJvamVjdCBvdXRzaWRlIHRoZSBPQ2FtbCBwYXJ0LiBJIHN1Z2dlc3QgdG8gYWNj ZXB0IHRoaXMuDQoNCuKAlCBDDQoNCg0KDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Nov 10 08:46:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 08:46:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441532.695652 (Exim 4.92) (envelope-from ) id 1ot3Cg-0002Lg-Cu; Thu, 10 Nov 2022 08:46:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441532.695652; Thu, 10 Nov 2022 08:46:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot3Cg-0002LZ-9q; Thu, 10 Nov 2022 08:46:30 +0000 Received: by outflank-mailman (input) for mailman id 441532; Thu, 10 Nov 2022 08:46:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot3Cf-0002LF-0J for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 08:46:29 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70048.outbound.protection.outlook.com [40.107.7.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 297a5cab-60d4-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 09:46:26 +0100 (CET) Received: from FR3P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::12) by PAXPR08MB7551.eurprd08.prod.outlook.com (2603:10a6:102:24e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Thu, 10 Nov 2022 08:46:24 +0000 Received: from VI1EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1f:cafe::e8) by FR3P281CA0074.outlook.office365.com (2603:10a6:d10:1f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Thu, 10 Nov 2022 08:46:24 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT030.mail.protection.outlook.com (100.127.144.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Thu, 10 Nov 2022 08:46:24 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Thu, 10 Nov 2022 08:46:23 +0000 Received: from 122c5fba2263.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4B66D1C5-1266-44C0-932B-51B787585A55.1; Thu, 10 Nov 2022 08:46:16 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 122c5fba2263.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Nov 2022 08:46:16 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DBAPR08MB5559.eurprd08.prod.outlook.com (2603:10a6:10:1a4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 08:46:09 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5813.013; Thu, 10 Nov 2022 08:46:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 297a5cab-60d4-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nMFdNi2wM9E8aHX95weeYLYI+5Hf15lGM5CxMWrEVK/eR4YY5g0LK2zvZn3tzrbW3iz3NbuaHnCsZ6Y71j1Ri7nrQwv4I/6Fn6uukSZEUgPvr0YFtY9JKCDuI/HuL8Louju+DkMK85NHZb22oRVWwfb5BrVeXx0bIEsYKzRqHju1SMR8f/JHN7aXRZckjvbuENMqf7jGD+YdByqHEUbH+GgDgzKuau5SdTnKcibS1j7yIHBmc6Qk4kIztdeVSaZaVfUZDIm8Rue14L5tfnRc9FO7a2bSFEjt2VPnfnzxGkQ9KgJiXyH8DbfIzaOs37rKtdBlcna0UFymSVU/Fmdn7w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zvV59+SQIO5j7s0FgVtNlBq3dHJrCCn2pQoJJWANYSI=; b=Kng1Qp142AERP+0quX4/1M/st3XWhMRRqUroLlVjPhyCn4keczwdjFvkdEmg3UvrrrQOXuyOWAgcKoJZ7V7ezyBwwo1dGA60xGjrlUu1k1E4Oh6jN78Jzt69EE0D3Ytwqv2WHEY6KlRDMKgUyzyRD6kj1H9srtYr5fpCICwmIKG8IzG+QBkCJSxVZIxum6LdHyM2s1jhM2KTjyXNsCxTIznF0r/MRQoARsQj4Uv3XumbX4EHUzGzlYvXBqu+CZQxo0P67pdxw7Y8E5J4EC9gnf5W0tRjpuHW2Q44HShB/NGooSEEcEIQTVJ2o7NP0QAdG1IzB4NgmQ1iOkDJ5AGvhg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zvV59+SQIO5j7s0FgVtNlBq3dHJrCCn2pQoJJWANYSI=; b=3CB3D53tOKp8r/myJccFj5KFSGAFWOTy9HDxMcIaSbNW62sGRa1lUxGeE6R+3I+xdR0TF1wnsR8cRFPHYYxev2H3MIyNRzPtNPE4N0uOSbLkGO8K5cD3JKcDSWHLYirSnX2Ibbg1oV6xERO6CuYyrwfJDNyP5gRRDZfsej3ZMkk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 77e4f59596e60b8c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HfJfEnuEKR9f5cjQ/8Vp8MOtCToS/E1SVzSI59nENCO54PhO0SEoxpBUUjH79vMYkYD5kGXj8lav2iP4hZZFxM6Gm14xbZ75UNDBUih0aDVKn1sJ/x/ID5m0r3OUtyMzRyag2oo0K0hMSeXKEJqyu8x0aGT94viIVkisEIYv2cscnybyTPbDT/5P6UWn+qI+6XtQXKODuJFQZmHcV6XbF3AoSin8ux6QjsBv2WrdGsF8Vdyozay0zwI2cE9qVtHtLQ7F8iNFv2zsidXxc/O5547/MoOs8QkBmpVQyqdhXETjqfLhIBFDjW7bB1XgVsZFkn93vs81aBJjerTO52JFyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zvV59+SQIO5j7s0FgVtNlBq3dHJrCCn2pQoJJWANYSI=; b=od1Bk/RcmlYxaHztFs+9ILqtww2fdqn+O/mAaAldcpOFFm55SJwCMyjt5z7rEENbZc0GhX8XH7yH0O3nB9/sZ8SpX8q5FtfCTQsPS3tIrOMB3B9FnsbiLOk0R3hu51C8viVqDVukkiEAJcF6bEiHep7NutDcZ4evs6sZlDSHvyr8BYZWLYLC4pSJHJem/a3eQO7bK5JsiZFxai4nrAfZDEH7uAUQsfc68AxnkXt29HGBD5XVBRFdSoFQUpgOHDsKQlbOJMJ9E/GOE/tBJS2vGik8ASp4mwSmzpA29TVuGpjtWu+DIFySWzN8ZmsthGNA177lcwCyChIuPHlsA4Btjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zvV59+SQIO5j7s0FgVtNlBq3dHJrCCn2pQoJJWANYSI=; b=3CB3D53tOKp8r/myJccFj5KFSGAFWOTy9HDxMcIaSbNW62sGRa1lUxGeE6R+3I+xdR0TF1wnsR8cRFPHYYxev2H3MIyNRzPtNPE4N0uOSbLkGO8K5cD3JKcDSWHLYirSnX2Ibbg1oV6xERO6CuYyrwfJDNyP5gRRDZfsej3ZMkk= From: Bertrand Marquis To: Luca Fancellu CC: Xen developer discussion , Wei Chen , Henry Wang , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH for 4.17] arm: fix Kconfig symbol dependency on arm features Thread-Topic: [PATCH for 4.17] arm: fix Kconfig symbol dependency on arm features Thread-Index: AQHY9EQ4iloE8yUW4kqdjRjbTbLxuq432TgA Date: Thu, 10 Nov 2022 08:46:09 +0000 Message-ID: References: <20221109140420.31007-1-luca.fancellu@arm.com> In-Reply-To: <20221109140420.31007-1-luca.fancellu@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DBAPR08MB5559:EE_|VI1EUR03FT030:EE_|PAXPR08MB7551:EE_ X-MS-Office365-Filtering-Correlation-Id: e5c8f4a8-5ff4-4939-b3e0-08dac2f80c86 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oL8kOtWzGfrYVQMQzgt85OhNinYQeLG4h6vHIGE5j35tXost7tJ32MpeYCA13RCefsAH+NHcE81iJDMvTr9TmHHfllc/JuVQwelwdjcSoknZlA4gUPcJz0mzbwDh66aL9brxx5Cde2Oh4iskZsNYyjq+Bcl8hdNeGMA9U5LAIvtTNisc4C4bEEgyoQoQmO9P+ePN1ZH4qP95KO67K3Tr8n5ljs4+tl2fTKk3zJT9JHQiwWx3C8gZEQHY1SXomL2oEeZZrgeyIC3+9Roqx5BLk8tQPbagCvW0dL/+2IDeoyHfwYRmMSTsBxtAtxBoaAP8Z2x3iidF9khLTMijs4M4MNGKI/7UMDzK4JA35/7lOZvOaLkzG17/W6IkclSsqW6reWmWFIBi0vsPzH+B7BoHcP3mbtI3SECTm98DakWnVDPjVHSA7CoT53S8wzTm2cJ58gxHCFlExx5AX1D7gS/61xHDmLd0RYWsaI6mW2aH46TvdIwKFMJmHEcAgvQ1OYknpBC1gr75NjuAB9NlMwDiYcG9UBB2pjiU2/Zfz83WK43ZH/91Rf6ntbPsSochfOHQo62Xds9/g/xOahQ6xgRi5wd+/pFirzjcMUJa1Iknol2jijD1GCKPdptZwUO5bKlQFbZ47I/4z9s5D71mE4zg5l/EbmXqzEJgKBSXNwZSmciIZ2TLpGsynJtzPW5qr2JtUx99jJEW03uUjSdG9IM7Bx2orkqavk3sQ5KlP4QlgDH9NSGucWiimvJW/Bd1fCwk0FP1mT7zU5P0tsCeCrpEIpRa5Cg+OpEho3ixawX0Nh4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(54906003)(6636002)(37006003)(316002)(6506007)(83380400001)(186003)(5660300002)(6862004)(8936002)(2616005)(2906002)(91956017)(53546011)(33656002)(86362001)(26005)(8676002)(41300700001)(36756003)(4326008)(64756008)(66946007)(66446008)(66476007)(66556008)(76116006)(6512007)(6486002)(38100700002)(71200400001)(38070700005)(478600001)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5559 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 320c4e7b-ca00-416f-7793-08dac2f8035d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YDz3lqmDMt3iarvjbwIh4yq9SXt8uBf1ORzGLHS9x/1RIcH1RDmlPWhwoFTXPiXCShM/BLzNNW4zusjHrjkfDZRQbqyEJZtHHo1ussGS0QVVCTBpa0zQd31u31iJuyuM/80vCjwSNJokaTlDig/4Sb1oMqPnkuSqVxxdJ/xmlkcKMlPRa28I73dBz3+UMAs9YoD9NHlX4XSwk7PgFNTHjPY91CXzIdM42tC7aMfaF50qXyjy8v7V30L9/NyRrq8hufHqz0L091IeYefW1Stk1hSdEx57iKuryeJ3aL6KqJiojS/FY6//R87Lx6FLn389wcOn2Tx9ZnPwDqPy4b2k34ADtThFps8nnfF2anNRwJrz4TxBmHObzoolsaVxPWlKqZYSYZMcmsdzpOT9eyW7lmQB3fX9f6P/7fxAf95qp1eDr/ODOw1gWKDSYRlTQPLs+BrRjeKKVqrFBa/Q1kKdHtzvsKgjYghl3zGjf97qVxjnJMCaLnAnl6d7thGH/aDOGLuighx+xDda5BGBL7iWFOoxd6zG73QIg17LQ1NQlNFxWVDkh/tD2GHt+zryiRf6W0mUQ8tU9jAxlINzRqnKSidoKEez63EoVOk9/2Mmdc058+da2tJJEeQYY6kv5f8HiEwWWfFuU4VdNp6QXqQ8eFKSZvACH4eHX0f6ds4eLZVWnkQeN/Ush8eyiKZVx203I3KJE+eCWg3imqeUcK+Grj/l+wAK97REiYLeVP0nCzkxgPDJe67PrcT7l6lnxnhVFTuo3a/IOGLvl7qDaOfS9g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(136003)(451199015)(36840700001)(40470700004)(46966006)(6486002)(356005)(36860700001)(82310400005)(478600001)(26005)(40460700003)(6636002)(81166007)(8936002)(316002)(86362001)(53546011)(2906002)(70586007)(5660300002)(186003)(83380400001)(4326008)(8676002)(54906003)(6506007)(37006003)(41300700001)(6862004)(336012)(107886003)(6512007)(82740400003)(2616005)(70206006)(47076005)(33656002)(40480700001)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 08:46:24.3085 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e5c8f4a8-5ff4-4939-b3e0-08dac2f80c86 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7551 Hi Luca, > On 9 Nov 2022, at 14:04, Luca Fancellu wrote: >=20 > The commit 3c2a14ea81c7 is introducing some unsupported arm features > that by default are disabled and are used for the cpufeature.c code. >=20 > As they are disabled by default, a typo in the Kconfig symbol they > depend on has landed in the codebase unnoticed, instead of depending > on ARM64 which does not exist, fix the code to depend on ARM_64 that > is the intended symbol. >=20 > Fixes: 3c2a14ea81c7 ("arm: Define kconfig symbols used by arm64 cpufeatur= es") > Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis I think this should go in 4.17 as it is fixing an invalid depends in Kconfi= g. The change cannot create any issue as those config options are hidden and d= efault to n at the moment. Cheers Bertrand > --- > xen/arch/arm/Kconfig | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 1fe5faf847b8..52a05f704da5 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -105,28 +105,28 @@ config HARDEN_BRANCH_PREDICTOR >=20 > config ARM64_PTR_AUTH > def_bool n > - depends on ARM64 > + depends on ARM_64 > help > Pointer authentication support. > This feature is not supported in Xen. >=20 > config ARM64_SVE > def_bool n > - depends on ARM64 > + depends on ARM_64 > help > Scalar Vector Extension support. > This feature is not supported in Xen. >=20 > config ARM64_MTE > def_bool n > - depends on ARM64 > + depends on ARM_64 > help > Memory Tagging Extension support. > This feature is not supported in Xen. >=20 > config ARM64_BTI > def_bool n > - depends on ARM64 > + depends on ARM_64 > help > Branch Target Identification support. > This feature is not supported in Xen. > --=20 > 2.17.1 >=20 From xen-devel-bounces@lists.xenproject.org Thu Nov 10 08:54:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 08:54:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441540.695663 (Exim 4.92) (envelope-from ) id 1ot3KN-0003q6-AJ; Thu, 10 Nov 2022 08:54:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441540.695663; Thu, 10 Nov 2022 08:54:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot3KN-0003pz-7P; Thu, 10 Nov 2022 08:54:27 +0000 Received: by outflank-mailman (input) for mailman id 441540; Thu, 10 Nov 2022 08:54:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot3KM-0003pt-RQ for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 08:54:26 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60060.outbound.protection.outlook.com [40.107.6.60]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46d3df98-60d5-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 09:54:25 +0100 (CET) Received: from FR0P281CA0138.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::7) by DB9PR08MB7747.eurprd08.prod.outlook.com (2603:10a6:10:396::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Thu, 10 Nov 2022 08:54:16 +0000 Received: from VI1EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:96:cafe::1) by FR0P281CA0138.outlook.office365.com (2603:10a6:d10:96::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Thu, 10 Nov 2022 08:54:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT060.mail.protection.outlook.com (100.127.144.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Thu, 10 Nov 2022 08:54:14 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Thu, 10 Nov 2022 08:54:13 +0000 Received: from 04a61264e464.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 57490369-0796-4CD6-B613-3C658C5263B4.1; Thu, 10 Nov 2022 08:54:07 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 04a61264e464.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Nov 2022 08:54:07 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB8PR08MB5484.eurprd08.prod.outlook.com (2603:10a6:10:111::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 08:54:06 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5813.013; Thu, 10 Nov 2022 08:54:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46d3df98-60d5-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=F8UQG72crJZajTCLcrPvdckCLVJh/VT1mM1ftpVSQs6NbjIMr96YKIxqFTCalrk19WPAVV9toeOhzZYNy7B/KfGf6cfpqgd47cRgDoZEJemVI5Y0jKfmJ1qfieCY7dmBLFdCRSjffo27f0n28nBKHVQpldD14g57L+2rqWQaqUOxBj7pvXOix0IsT8mmRhFdJ5XFrOLj5pKn1/pqWlzHf4klvMcrEPG+gi4foabFi5PK5NR4nWYGhp3omIB9PZzBQHYJ60Cbr3nnKaPIkofDI3ca30MwJIz/cl7H63wwswlV2WE6a7olppzAmn4Hj+SncA8BraPN6tBaqRf421XFrw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lAE9CgBaMSnFZYP3w6bTPL/eIphS78Wy40DT5C3H23E=; b=GSqDJkG+ktXEb1bzeIr5j89OXTn/P6zyMCTzFvsk6pGveHrj15sSqUJmFm0aTPretYLw3Jj1wj/RlDhXAkTTLAtqwtWVmocMuRKF/TYAaneBJhgOQbIeVzQsNQsmUQgvCuViuIoF88ESHeblyzKvWZHz5f1Kh9D7t+QhRzU51+H4k2YLHHhLoZXdw0jgswP42Ky140F0Lt4FZit50LFkfg7mSs2Q79JESODUdjJ4276WSecAFKUFha5ihZ08h4rXQxCY3dsdRxEUKFrPwe84pXs6cmG/T2pmvJtGzgMwzozUuaCjMgkW+YUVBKpzA7cCbuYTHTghIfG58eQHnDgR9g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lAE9CgBaMSnFZYP3w6bTPL/eIphS78Wy40DT5C3H23E=; b=Nbq28TtknWBH4i+x4XhD1ydRRhgfy5v3hzP4nFFTyERefBU7OvQGC/+MXtckJT10Mr1sfblFjAT6MDuInQIEQ7/BUEa5kd6zkkHYni8apHMhhqyJ4uIcCziF+O3vxNR4nj7VrDiaJfZ6KX4Nt/JNAiAyM6dE8VtmxYSnuTEsFnQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3b3e77e605d14de8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=da/IsVPCbXZcfJcQL9GPXQjYndKbFFccSC11qGnyMolUpi8vnE4zPaBPd3Ehh9kOLOGcbbYtQzhkdj4DHg3DB3iGpQK4FDNhZlhpm36oYUgkCx0Jg6usDCSyAK0N5ygurQlHqTPbx7L9DFWK3UbxsIOgbRql9ZFRHaQsR+z849oTuV2FkLfH6SajrLH2RuOgfX0JF3xtk8gWbMJbYUd5JD8J/Xq/nE02PxEOpFqrPnnGwByaO/BG8Bgu3h3I1cyaWeqebV7JbqleF4PH4p//0FIr8ufCXcV+ku0UyaD2FrV4O4o/57PHX07i4mywkt8R/jI3hJGhMSJlaAxA4zrtYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lAE9CgBaMSnFZYP3w6bTPL/eIphS78Wy40DT5C3H23E=; b=ZH1TG8EnAWQeY9a+b5KBIKSBk89nZzbJ4oyfJ1Dfi/7l9ExGKjMLVQMYv4gn1ve3Zl9abdRlagxH1DGGMhRXGwNiuHPX1xAVQKZUtiDpk8hu7Nw83eh1KrJXx0vy65jGwqTFDV3hTXlvoMBV2x8e4YB7JrURBqw7zlNr30DpDov962p/ySamYIPvStjBMUd1oQPYBPYXXHgrtxs01Y734zEouvqO7fZsNXD3dQThBJyqQujnsWZlJGWYWQyLiMT/LdUt/CZtWw5TTgZQwGYlRbxjq+uU/rEYPpl5fGrCBRuSFr8aDtFuNEs+dfKEfIYkdPg7yvZqSML93BYBGbq9fA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lAE9CgBaMSnFZYP3w6bTPL/eIphS78Wy40DT5C3H23E=; b=Nbq28TtknWBH4i+x4XhD1ydRRhgfy5v3hzP4nFFTyERefBU7OvQGC/+MXtckJT10Mr1sfblFjAT6MDuInQIEQ7/BUEa5kd6zkkHYni8apHMhhqyJ4uIcCziF+O3vxNR4nj7VrDiaJfZ6KX4Nt/JNAiAyM6dE8VtmxYSnuTEsFnQ= From: Bertrand Marquis To: Jan Beulich CC: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , osstest service owner , "xen-devel@lists.xenproject.org" Subject: Re: [linux-5.4 test] 174684: regressions - FAIL Thread-Topic: [linux-5.4 test] 174684: regressions - FAIL Thread-Index: AQHY9K76AziskhXElk+EohtHPDzhJa430IgAgAAKE4A= Date: Thu, 10 Nov 2022 08:54:06 +0000 Message-ID: References: <0fe79723-d279-9744-b6c5-8c43e6bb29cd@suse.com> In-Reply-To: <0fe79723-d279-9744-b6c5-8c43e6bb29cd@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DB8PR08MB5484:EE_|VI1EUR03FT060:EE_|DB9PR08MB7747:EE_ X-MS-Office365-Filtering-Correlation-Id: 6de2541a-ef18-466b-c2a6-08dac2f92496 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4xTLX6XwNm+eLN9EVBFjKcV04dUequYCppZtcFfrGBYXkWtZ8ptIU0l9LezIsViL4Gk+pGqbry9Gs/Ys1yamt616W/6hMe4WWlxpQq4LDvPvx1SuTHh4jGI3fey0DFLK51G/8K7Gf4HbOZXX9Sk13bZ53oU87F8PP2S/YDqhbRY11Udej7GthXpk7+H3An/S1Uq0YQB+OBc5oD03OV5FsS/yxsTvWi2qVESnEpmoTo8V07IxzpGgHxXRu5n5hR6y54dZSJjK4vuKiiU+t83kk3CSFbMUXNRbAUTdNfnUSpeYhzJggsbjaSgG9pt2KoTenYZzabXvd6gWb0zHxBg1GnJxkNFvaRTRaHj+twARw1vtv8iwAnSYi+cnJj0RyFIfz0O+d6XFxNDAP7JxfUi9EZMTaBA/DdYXzMgQclm0c5gsJGZiih2hbyUxsuwmbyS+/q3IXaXJtTd3aF5/10hTgSFplObmmU2b+v4Ek0iiFt9C298ejtKgde2BVrqpz9I+wqF0Oa7qs98tttmqd42YG4Gwr4INOlG+Jkt1hh8W1UwBy2eYYh3/idAjSWPesFacDOSMyBL/3ZxEh3ttL7PnfZQmmDGjDkjIzxsS2wrzs9I/seqnwo5dP9jyF2mqiUUbJ+qNuORXYRPg23MwbnRTg02C19nMIxJztjpElr8xRTSBum2QE00MQ++708g7y3wCDvpYdj9Mx8LjWkfwbIXSXWZKGA3UIv+eiAdjsO2F0nd6v06zE36nB67LdIkYRMKWByKS2v9HPvVB3upjAIQIYe3r6TGB8WSVYG7c6sPE1P7vl5h4lntyRM0X7NGbO3rXqTGXtuD34AEkNnaKhMeBbQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(39860400002)(366004)(451199015)(53546011)(6506007)(2616005)(6512007)(38100700002)(186003)(122000001)(26005)(83380400001)(2906002)(5660300002)(8936002)(54906003)(6916009)(6486002)(71200400001)(966005)(41300700001)(478600001)(64756008)(8676002)(4326008)(66476007)(66446008)(66946007)(76116006)(316002)(91956017)(66556008)(36756003)(38070700005)(86362001)(33656002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5484 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bd912cca-5a9a-415a-bac1-08dac2f91fcc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5AR7sMfCFF+bC9L9caY3opcTdL9RJlqx9sgvav4nC3pP6mc+OIStWYJuFD4VdFiDCoAYkSeoQhEzXVaSRhuu4DCFS6jANCVzwHruCav5lNjL3SsI5RZmVLmiHbYRlHAQ3VJlbCan0rpcJbtx650kZyGq0JJD92cO09RytYeNGn26NNHDsW9rag8diUMqQJXjoALHlJGke1qwjvZLKNBdqPFO+fG1pIJwKDYR1ML+kwiyTA5moF6VUK/DykgvzdZ9feAW9ZGuOvzwQLVfvOBfzZDsPGcbSLb9+Xi/kAPae0ywHjK+xAh44aQ61bK5oPNgp798uvsWSNcKNYdTYKWgQ8tSzto8ybVzHnyor5OMBcEjzUXGtyyQJvhmGBRWv9yLd4zJixTUdDeFoh2wIsMzGldvH6kQ4k0xkyk8kug11VKw4UW6fat00UiMi3LQtuvOSgc47VrkREf8GSiIx0CeBizTZFBtA+UYVc/O8fIh3RrOIQ0i3EB9HvCHTHRsdFQbn0gXRTE9Ek+UrWHW2KpxSh6992EGP+V/VIrTmiO7jLSEQzZ1QQCAGt5OjEZoR+UJsLI2rPLHPldYrwGRUI/EMf69FUJf0jzNd8Qiv32jlHZrW6vXpipG1CXG5vvX+U+VnR3V3OH+WSmM/E+QXqx7bRSSZ4soNscnm6qSWWK85tP6QO8aKue7a4r/G9OcbPW/JeR3CNIHUg1ZqOvw03aW7WS5/nPFIxsZIB+N4gYWr6gwXpsmYi/XZJ3P1cbC/cGeqqlZ+PRUHLf88+f4q9oPaVNhsbPRrfg/50hOq+Um1UVYHhzqrhW2br++qoYXtXVS X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(346002)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(36756003)(40480700001)(33656002)(70206006)(54906003)(6486002)(86362001)(82740400003)(356005)(6862004)(966005)(6512007)(82310400005)(316002)(36860700001)(70586007)(478600001)(81166007)(6506007)(5660300002)(53546011)(26005)(2906002)(4326008)(47076005)(8936002)(41300700001)(2616005)(83380400001)(8676002)(336012)(40460700003)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 08:54:14.1758 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6de2541a-ef18-466b-c2a6-08dac2f92496 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7747 Hi Jan, > On 10 Nov 2022, at 08:18, Jan Beulich wrote: >=20 > On 10.11.2022 03:48, osstest service owner wrote: >> flight 174684 linux-5.4 real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/174684/ >>=20 >> Regressions :-( >>=20 >> Tests which did not succeed and are blocking, >> including tests which could not be run: >> test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. = 174540 >=20 > This now looks to be failing relatively frequently (about every other fli= ght), > and I'd rather suspect it to point at a hypervisor issue than a Linux one= . > Looking at the log I found >=20 > (XEN) d5v0: vGICD: unhandled word write 0xffffffff to ICACTIVER0 > (XEN) arch/arm/traps.c:1985:d5v1 HSR=3D0x80000006 pc=3D00000000 gva=3D0 g= pa=3D0000000000000000 > (XEN) arch/arm/traps.c:1985:d5v1 HSR=3D0x80000006 pc=3D0x00000c gva=3D0xc= gpa=3D0x0000000000000c > (XEN) arch/arm/traps.c:1985:d5v1 HSR=3D0x80000006 pc=3D0x00000c gva=3D0xc= gpa=3D0x0000000000000c >=20 > with the last two messages then repeated over and over, many dozen times = a > second. Which makes me wonder whether that verbosity alone is causing a > problem. The 2 messages are not necessarily related. The first one is a warning and the write is ignored, we see that all the ti= me with Xen in Debug mode during linux boot. The other traps, with PC at 0xc look like there was an exception in Linux b= ut the register pointing to the exception table is at 0 which means the gue= st did an exception before it initialised the exception table pointer. When a guest is going to this kind of error it will loop on this: - exception - jump to exception table at 0 + offset depending on exception - trap in xen because 0 is not mapped and push back the exception to guest - go back to step 1 Now it could be that the first exception we reported back to guest should n= ot have been reported and the guest falls into this loop after. Our CI was a bit late compared to staging status until today (due to some s= ervers being down). I will check what is happening on our side with the last status today on ar= m32. Cheers Bertrand >=20 > Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 10 09:02:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 09:02:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441546.695674 (Exim 4.92) (envelope-from ) id 1ot3S9-0005TZ-32; Thu, 10 Nov 2022 09:02:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441546.695674; Thu, 10 Nov 2022 09:02:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot3S9-0005TS-0L; Thu, 10 Nov 2022 09:02:29 +0000 Received: by outflank-mailman (input) for mailman id 441546; Thu, 10 Nov 2022 09:02:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot3S7-0005TM-Io for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 09:02:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2059.outbound.protection.outlook.com [40.107.21.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 65193812-60d6-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 10:02:25 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8446.eurprd04.prod.outlook.com (2603:10a6:10:2ce::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 10 Nov 2022 09:02:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Thu, 10 Nov 2022 09:02:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65193812-60d6-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fQGdzcvJ5yeA1fA0mrcR2j1eVdY/QUnrDk86EqcP58gbbQrpb49LtYPSbDveWnvrsM0ncRtx4XKYW1rovrAZiiTJm30LKSOuqDmfciLLqBMdkTBmhxS9BufdHU7TdbClUzQjtTuMy8SopQMx/3vD8ETLCKJtSJv+Nt5qxT6NOJMKGnHT1GVBObZnaEQCipgM6qC7+HYwCh+cgw4upf3TGRPwaXa7PiV0WXOwrJuAD75B55e9SA8y2IdtCK5yQ8a4rcUqSfT/ROMyBNZcBtUDHR30knRcsjBHXsHLywxIMA154q8q4AYbklrHC67+tDzi8Qg1RqteevBYjQT8WK4rKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pGEUzAM/tBuNXyuGwpAuLIPgwCVJ81LMNT9tzp4hLaQ=; b=GDSyebhnA6TJyNfmkTy/896b2qyBKmP6IiHTf+rgvbi9Vik8YPvrkIh3yOGaqzQ0YU3kFRY70IG/AYbgl9LdWouQIQVfTFatGV3miNSu/oyuz+0tLA4cQkPG7OsNtBkRAKG/9zLiMcKrw/TH+835E1OuaOjXqngXQ5bnENbn6HJr25GiNn0IuOck+U36x1hsT7tSp/jOIuMOxUTNBFKVPD9EPZp6kQAaI5SgAQNt3MDuyrpyQJjucUU64Jf0lcbcAVBNo3NewM/akmvU5JEt0tExCak/MJdulmLF3WfkamKxj+lWWfQq6XjzPBoo7zFQWQB4qe5f/bvY3bY4ITlxGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pGEUzAM/tBuNXyuGwpAuLIPgwCVJ81LMNT9tzp4hLaQ=; b=boLd260Xb1EfpGPtkLy+5N7E5V8aD4F3MUojpKGapPJxxBOj0bRHz1WcRLydWzWI99nTpU+JT4frmPBFwYLDYgKCPENSN/LDIW3KuQPlzROekVSUAoVv8VOznSZa31bgBVPXzepOyhwrM+K38q7N0mu4v+5NVafRVW5POSMS/0O4lX7k6NXtuX7SVhB1TIpdYJa7VpjS2gp5EUQrAEeR9a8BEQYzqf5jWPR9V2lKRXgW5YIveggg3pRrax6duesXhTzIKxn4raJcgS6sLitk0pk1a/zhV3cGcZS3ucO5i/WPS0+qt61K6NAUVIF02uYB+c+aEvag3xNxUap6BbssPg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3b97cfcd-e741-c89b-8063-e3f977ab7ef0@suse.com> Date: Thu, 10 Nov 2022 10:02:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Content-Language: en-US To: Andrew Cooper Cc: "Henry.Wang@arm.com" , George Dunlap , Wei Liu , Edwin Torok , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <20221108113850.61619-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0110.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8446:EE_ X-MS-Office365-Filtering-Correlation-Id: df2e952d-31ad-4869-a2d1-08dac2fa4899 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rEaNeA/e5VhaF2M8+mkW3RvLPoTSXl1OVASmV3UaV5xTYulzrE34e2tVCDrpnCAiKmrG5EFQpeyODxnMZw+V8SCRliHRfphAMA1rTtF8Ip00nwsjqokqYT6VrFt7JWqN+U14pyGNWRYQitaRtxFGJNFGyJjprcSoN9vjOvJ9nYzGKstqhVXyqURmzn0W8NXm3jR6Sjj48toTMoVZuegcTq+SIpTLpICLr30Z6nABoA+3RlbJIa5yzFbdbYFjPg35WuQn4zJpbtnBE8OEZ+1JQRiTJPFfNVfPxMumrfL9wUIIiv73PmOVUAa29Hh+a6n1K4hIyyiSmniMeZG0FbxUtHY5eO4Ht/fJ2Uyzs+ZJ4szXv1w7vdZ5q81sd/995mmP1snla6wamL/PvQS0Lbgl4RcJD5wsBHBilMExd7WhD/ikjEMg8Vax7+tWPNjd3uXsspfLTJ37uFT0TsavNYXcjS6xhrTlZxmwsxsZepjQFtuEbDXfVzbdTKA9D7JeQDLmwpjt1Gxn/Rg4gai5Yf1vFO1mVZvBVNMqhKNcQX/bwSyLcVhJx/5jvcO9e8IN3vHFksncc2kfB/ZKMeKI0KXZa9cAyBqptLqBENkKaPofHSVTy8Ow/tqNTYavsC34xeZuSx9QrnAM+r4fNIznZn2BspJB0uTfDptmPf2qMa4tN1G7kH6OT5iodAVNnR1AN6gGbpjCqnC2BnUSXobsUfepfEP5HYnMidm3sJa/8W0gFH6/NlSmLUEh0kisgmDLZSqR0nZT2LtK6bgpycd0bwRx5SlSVTtqfhvRikGRoxBZWzU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(366004)(136003)(39860400002)(451199015)(8936002)(66946007)(36756003)(186003)(66476007)(8676002)(4326008)(2906002)(53546011)(2616005)(5660300002)(6512007)(478600001)(86362001)(66556008)(31696002)(6666004)(6486002)(316002)(26005)(6506007)(54906003)(6916009)(4744005)(31686004)(41300700001)(83380400001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzdTRzRpNFNtUGxZTURtVHZrM2VQMGpTaVlPUlc2Q004V3J4OEQ0TjRlbUli?= =?utf-8?B?dmVJQlZsZVF5UUZ2M2w2a05aeWxJUzltbUR0MkJnTExsa1VtUnM0cWFlVjdr?= =?utf-8?B?dGxiNzh1SkxGOFJXRFduOGhPa2Y4OE8zSGtqZUYvdmJCanhVTytKT055S2tV?= =?utf-8?B?eHpoVDFVMEw0ZHhsek5PZDhxSWg3aTF6OHJCK3d4bmdkNGFDOXBsMEtrTVRx?= =?utf-8?B?SjlCRzNxU2lxa3BLK2tJT0YxRlJOQlJFNFNqdzdiZ01laGw1UzRMNG1oV2I3?= =?utf-8?B?cGxnZXdKbkE2dmNSM0tUdGdUYnN3RkdTdnFKdm5DdnBDU3BBbGVoZHNwd0VZ?= =?utf-8?B?cGhaM1Zvem1tazJTZHI3VHFJNDRjWnVvR3FYOFoycmVieG0xNW1DcGt1TWZM?= =?utf-8?B?QWMzSjdHdk1GT3MvMnB1dlM4cmdBQXVwZC90eWJmZTBjTlZLWFdEclZXSWIw?= =?utf-8?B?dTVkT2xvM0w0THpYRmw5dVNZcnVQcGR4b3lDcnVRbWh6SGZ5NkVoREJNKzRU?= =?utf-8?B?aXRXak5PYVFqeXgrakNyOW44cGEza3RGN3djU3J6UUFZTzZyYnh2NmRwNkRz?= =?utf-8?B?L2duK0dvWW9JOWJMVi9IUmROS29rYXM1eWFhQXFCazJXMkJ3MFpxZVVNNk4x?= =?utf-8?B?NGYyS3NwWWUvL2lhekhTZ1VOUzk4MlBDZmtveXZkcTJCSnhYQ0IyMVdLb0ZD?= =?utf-8?B?OUNXRXYvUVJjYVQ1RWpPOElDL2g2VWJTTEF1STdGaTNJNGY1SThyT0Q3aUFC?= =?utf-8?B?Y3AyTWFJWkhaVFJIUHhHNEhIUENkMUJWRnVXbnFYbTZnaE5wdWxWOTFkSlY1?= =?utf-8?B?NzFaRnl6aUgzSmhUMWk0ZENIUzM2NFRQMXM2YTFuV21hRmdJSjl4VDhqdCtk?= =?utf-8?B?NkpvRkJiWXhIZ0RjTCt3TGtLMGk3UjJSTXFkdStadmRDb25DazBXQkorQVBh?= =?utf-8?B?VDJZMVdiNXZ0V1lrZHVRY0h5Z1JpZGRDdGlIUmNTbGtnTHFqbWRmU2NvOUR6?= =?utf-8?B?UjBSSWZNTHllMVE2VENhbllvNmxFejU2a3ZHWnZ0T1pjL1Q2YVJjWlMwSEI1?= =?utf-8?B?QVJUWVNnTkdBOWVlMFdpVDFaNUdoWkVPN2xSTXFCT0wzcThwS243bnYrVUhm?= =?utf-8?B?aTJlWE5aMXorMElwWVhwRmJTSEtkanhlajUybFRIZjJjdUU4TlFmM1VubFNZ?= =?utf-8?B?VXFVbFk3VGNhVXVFSGZ3WU5NUWUvRjZLTm9vcmhyMmJwWDQ1djl0OUloKytX?= =?utf-8?B?R2Q1T3J5eDI0M2ZXK1NhZFIrcE5YR25teU9yR3I5TC9abWxCNzNRZFNGOU52?= =?utf-8?B?R1YzVEZGa1JWYjJCc0FjRm95YkRJQyt1RHpLKzY5RXovTXBmUVBodzlSOHRv?= =?utf-8?B?cDhSLy8zM0hvcjJSU2oxVGNsSE5YOU1ESDlOeDJZSDhaRzdYMGNHMnhhMlFm?= =?utf-8?B?UkZTM0s4MnNIR3hmaFpLQUJic3pndjh1Um1MTDRwVTFOUlYrZ29vZU8wUWYr?= =?utf-8?B?ZWRVWitFZGpvSkgxNTdGcVNBNmFzb3ZLRXBtL3JzMDNKK0poc2xxZ0loSzNj?= =?utf-8?B?cGR2Tm9RQlhnNUhtM0hTRElhNkZnejV2dE9iVjBsTmJBa2NPMkhpSnJva2Ft?= =?utf-8?B?dnl6cXlEQkZjcGFtTWxpQS8yY3lXM2RpM2lxVFNBVFVwMVpIQ21oM2gzMCtM?= =?utf-8?B?dFh5eGFJNVhRSzNvWTc5WVEzQjRVTWpoai9hS21TelJ3c1EzM28weEE5eGRI?= =?utf-8?B?OXBmbHV2S25nYVpLSVdiY1RUUzJ2UkdIWkVMMVVHakRJVGFhaE5LbEtmaXEy?= =?utf-8?B?WHBmVzdjL2JqSWtMWkhFbHJZazNKV2FhQnRwRGZvcVRmOW1mWjF2OGEwajhP?= =?utf-8?B?dnhCdWpVRjRIcXRxNzNpZ0E5TzY3L3oza3R6SWErZ1N6YnY1VkcwcEFHVVVF?= =?utf-8?B?U0hUTDcxMzNHbW8zMXFUeTVkODN6di9QWmZzUkhRUVNOZDdKbXlDcW5TUDMz?= =?utf-8?B?QWhpQ0N2R1JFNHdqSW1hbkJ1b3ZpMWNlK2MzdEdjRlZWbDd0SGpIVzhDZkQw?= =?utf-8?B?aTE5UDlCRmVFdzhHazVBUVRGejlrVVg1S3ZVVVZXaHU5aHRlYmpaaVNFVmFS?= =?utf-8?Q?SNNl5IusTLJ2uakUys5zG9vj5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: df2e952d-31ad-4869-a2d1-08dac2fa4899 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 09:02:24.3393 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QASkbXrib9g1XGVqU/3Wpt8x7SkMlLiRoK6Z2eUyWlEE+yYDspQnwLp78Mu4G/x5gopVNqIpyIfXy+6tH30ADg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8446 On 09.11.2022 17:11, Andrew Cooper wrote: > On 08/11/2022 11:38, Roger Pau Monne wrote: >> Like on the Arm side, return -EINVAL when attempting to do a p2m >> operation on dying domains. > > Honestly, I'd drop the comment about ARM.  "the Arm side" has existed > for of all of a couple of weeks. > > A far better justification is because almost all other DOMCTLs are > rejected with -EINVAL against dying domains. Would you mind supplying data to prove this statement? When looking at just x86'es arch_do_domctl() I can't see this being the case for ioport_permission, getpageframeinfo3, hypercall_init, set_address_size, get_address_size, sendtrigger, bind_pt_irq, unbind_pt_irq, ioport_mapping, set_ext_vcpucontext, and get_ext_vcpucontext. At which point I stopped checking further because in the order they appear in the file these are _all_ except shadow_op and [gs]ethvmcontext*. Am I overlooking hidden checks of ->is_dying? Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 10 09:04:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 09:04:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441551.695685 (Exim 4.92) (envelope-from ) id 1ot3Tg-00061T-Ey; Thu, 10 Nov 2022 09:04:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441551.695685; Thu, 10 Nov 2022 09:04:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot3Tg-00061M-Bj; Thu, 10 Nov 2022 09:04:04 +0000 Received: by outflank-mailman (input) for mailman id 441551; Thu, 10 Nov 2022 09:04:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot3Tf-00061C-Bu for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 09:04:03 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70083.outbound.protection.outlook.com [40.107.7.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9e60a911-60d6-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 10:04:01 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7979.eurprd04.prod.outlook.com (2603:10a6:10:1ec::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Thu, 10 Nov 2022 09:03:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Thu, 10 Nov 2022 09:03:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e60a911-60d6-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DXZt3f4z2BoV9yK3RvnI/laJG/lRn9fNAxPS9jC1KYign/kycPizKuseT/ByX3dHLZw5SX6slasMwpMvu9VG36YW4cX6Dzt1NGA8S9eAfYdUmAsK7lgqEnP6IEleCVdK2/h8Yv9ZVyqp3m45FiD2jUOkusP3Vp/xY8toyt2RcybXG5QlcA0CUBkEXiwrmEIAMjFd7WJp4C1G2Ts40uNTrZQuWgmPr2mEndeCmGnI2AtUp6hSpGYo6zFl0CG98VR6ZIjYaaXnXXAWV96ueGQc0qJsfT+p8GNyNXbhVDtPrb3VbtpbTrt/qQfQvT5p6r3o2W8u42m7qVnO+Kf1cgF1qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pft+1Z+vRWwJOdgy/8sxq8vUhX/cZ7q9kPsXa+supH8=; b=lAJc/9xbw/QIWakVL4b+JOHinxzenuQ3jA3pglgOpx2/G7qrp0pan6dG9OALQ5q7ecZ9mobfDEr4OuR4CbLC9n/UKwzdbeCHhHdUwziX5wnq+1BsbaaZB/TBt8zk2IvDysH5hET/BTe0xgcU6SGkUz44qGVmoUTOgi6aemnSRXUCpHhYPcQOfE1jif5JDX7FTAy4NaOP5jubMfRsUxsAhbF44BXwLqpMMfjw3tgTtHAtP1Ffp1Yur/SHrXWnl49Oz3bN4+EJpP9fVowVn+YHHCk0E3syCc7R+NRsEnZl77HcqNvNAPRyl90KRpvI9qIxb2K5lCD0TYshNlRsXm+Rrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pft+1Z+vRWwJOdgy/8sxq8vUhX/cZ7q9kPsXa+supH8=; b=1/z1xTV/k7Ixx8rFCXdyIk0xJfF5Q3UzKQIHLFxCNILusaW7c++qLTF4r9PWvWRT7McS+QVT7YWbyCEfyEQTJxODe20kwwywyO6DHNy8cOA/MSXdm5JIyueYTurboyRw85Woq/iq3YsuqxK+ScltO1JidYHNhY5y6T79pw/UbLWafRDToBnuEnjnURzNA+mH+Ge9qtZSpjzYVAufNSYtJf2SEc14geMPus4ViIbGRc25cjWGygRd+v6qlOrXZ0QNZ0egOw9PbsHtfixJILFayRwOOXbVBLDYzp7msbXsF3rQ3bcxdT8ue2iTDK+pga9JoWaQwncCBV98cfXXKoNXFQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 10 Nov 2022 10:03:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , xen-devel@lists.xenproject.org References: <20221108113850.61619-1-roger.pau@citrix.com> <58d5e890-e052-47df-42bb-6cc84aedd4a9@suse.com> <76cde159-088a-3351-56e2-0cf14e9c8116@suse.com> <31f048fc-f2e5-a421-0e60-98d1bed47ca1@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P195CA0100.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::41) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7979:EE_ X-MS-Office365-Filtering-Correlation-Id: f231b8a5-d7a8-4564-e059-08dac2fa8127 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2HGZ/Aqqmd30Nak8WthedjzCsk2uXL/iY7wjkC45NTFXTJqXla/XUQA0lMYbcXf3sVQLsj7cFeS9yyA1/7EPpVgk/FniVjYcTmvqRQ1YZTlLx6L1XSNjyPnGNK6OUYF+E1TvdZtwa3z8j1QBdE0DTEPDaWIIDUQNxF0/RYyoGM2BlsSMuDs9ielZB/jPkYdTgWCm79/1zHus87dCEKObFQqJ+AgAo1HCTu6KBsfbcJqb3FLfGzATfQEDvrfjiTiVD8sYgsL0e5pyiwVelJRRD2EJvb0+cF5gKWSkW5HMhX0NjVGfkkD6PqIJALL1cHkvss+Y0WLuyHSKoJQJCoGxxX3pDztS3fQLnXVVveHF4jLDKAenlA2AzCKUBfEZKcC1Ll52dLGFqZXGEVJKFZtQIxYIjwqu3WrJHx8Aop8gJRm83cGZyOVrOoUYaH2O4PpD813DrjcJU/4OL7LEhvAyCbd0hlb+/N1F+qVboHwn1TvFdTdZUnLG8Ei1RMGIrax9dtWoLOuR2WA1C6xxe8ktm5TpKtej0XtAFJ3EHBwrEt5ocMEys1QQ37T4CQZEewo1hbnmHMFVKOEzKyP5NMu/N7kDK5O1dVAn+Y8MxKhr7YfMYCkaoS2fE5BOXzJCiHG0XZA+jqYgPR/WYOGUb9NVf3jVuqMJL1pSEgdSt0Z5DxSi1Rdnq0UEdoYvUzMBWGyI227d0Nj+kdXIdYKZO5+eiYLK2QLeFJVfrcyVLMRAdYDPKNvBrcTU5pIyj6Sf0SyZsFA5fDxv3vB9VAGAk28M+be1+j7Bkf995OI0lD5+Lmc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(376002)(346002)(136003)(39860400002)(451199015)(186003)(31696002)(83380400001)(86362001)(38100700002)(2906002)(41300700001)(4744005)(5660300002)(8936002)(478600001)(53546011)(66946007)(6512007)(26005)(6486002)(4326008)(2616005)(66476007)(8676002)(66556008)(6506007)(6916009)(316002)(54906003)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEpCSEI5MlZmRWU3ak9mQXpEWGNXdjNMTEdvTWZtdWlpTE12R1dRT3JBVlRt?= =?utf-8?B?cU41L1pqWWNMOWI1TGptN0s2NWJnLzVWc28yM3BYaTdlQS80eDFJbE9TaGNK?= =?utf-8?B?Y2F0RW9DWUlnbFhzekh5UkJFVTJpOFB5VWtELzhhM3AwUUFEY1hnSjJiRTd5?= =?utf-8?B?YytacVQxS29GVmdkUzVRTkJ2aklsVTN2RlJpTHVyU1FhK2cwcmE0TzFnNzM2?= =?utf-8?B?TElPZW0zc1d3dm5CMGg2YmNYSmJGbmhlbUU0UHE3N1ZtRFBhbk01NEhRZ0Mz?= =?utf-8?B?bm9iL05uMnMyRklhS1ZkVVlMSjRtVkJVdmhNWVh1Nnp3dFljQTVLdnZYYTd0?= =?utf-8?B?U29xRmdSZGZPbFoyTFNUZ1RRTEVMZ0orVVd0KzIvK2RlTjBhaGFYS01Dd1l0?= =?utf-8?B?dmc3SHlnMEVrTW9jSklyejdNU0dpR1hNOHpJTWVvMnhsZTJNTFdjanpVOHcv?= =?utf-8?B?NjZYdlloV2hQNlhoOWI1YkxuY0dSNG8zNGNwQTFyS3huemFLN1hoUWFxRkVM?= =?utf-8?B?L2N1WVB2Tng3bGVPTXZ4b1dhRkVrZTZLR3ZXUVd5czV4dWFYYlJPM2k2WjN3?= =?utf-8?B?Y0tmZk1SRERXS2xYL04valVBa3FUcjB5Yi91VXVyODgvVFhwVno2bEw2KzBV?= =?utf-8?B?cXRxQWJ5NDRQa0JEdGNjRDY5QVNya2RMd1dVMXRGOXFJeXBmZ1dCYzg2bUZ6?= =?utf-8?B?WXJkbnh5SHF0MzMxN3NhQ1lUZHJTZXoyc3NvZ1lMY29yNTZOQzlPcFVia2x6?= =?utf-8?B?TG1oN0E4RFdTZnhjYWdOd0pQMXpqVE5EUXlFSW5XdjRQeFpaT1J5M09PRUpy?= =?utf-8?B?cERHTnh6M0pqMWxRVkxEblk5V0Q3TldYVFpRSEx0dzd2QzBLVDZOeVE3eTBa?= =?utf-8?B?QmZ1RUp5MkE1OTkrek8xMTFVUEEybDhpcit2czVVZHJ2STh2MVdEVzdSQi9N?= =?utf-8?B?Y3hYSkFYZ3lmUlhOTHRwWDVkSzBQZjROVGp4UkUvcTZRYkQzb1pUSW1mVk1O?= =?utf-8?B?SHZGMlhyUFEvVVl2WVN6TTZmTlZTOFJjVjRWb29SVm5XRFNPRWNQSU9rYWJ5?= =?utf-8?B?NFF6WUxUbjhUQ2JoWjNUWjA0VE40MmMvWUYrRDJRUHR0Rmo0N09rSmVsazY3?= =?utf-8?B?YmRMZVYrNEdXVGxHbE5DSjJ1QjQ2bFI5Ky8xTWRIS3g4dHk2L3ZZWDQwVnpz?= =?utf-8?B?TUJUSm0zaU5DeDRjblVuMExnY1ppNnVDc3dHNDhtZER0RTUzNEZJMVpLZVpH?= =?utf-8?B?SzQ4VmlRbmltS2kwYzIvcnp6TGxjaW9ZZEtJRTBtUHh1Q0RXRElFaHQ1bEgr?= =?utf-8?B?SEZaeS95OThjWkp0RUQzM25ncC9USU02OEJEbXQwOVdCT01PREFkRnlNUWxo?= =?utf-8?B?OS92ZVlmVitHdkNuZnhVNzdmY3gyS0lWdlg4QW1mUTBOcXBSZUMwUFlxdGlH?= =?utf-8?B?UTJaNnBONDQ0Nll3OEw5TkhKeExmd3dSckNCdVNRc2tuU1JpT21CTEl4ZjRx?= =?utf-8?B?ckY5MG1rbkhWWmVZalQyQjNSWE9qQzJ1bVpWMHpvU3BIOURSV1pPMDVPSXhK?= =?utf-8?B?TE9tUk5jVHJoU1ExRW1Yb3JnbHEvSWJNWXJ1TGI5RHNVMHpkRlNRSDZoR2ZX?= =?utf-8?B?OXFDc1N3amZPeDVqNERmeERpV3JTZFcvMVJVVUYzaGRuc1VPWW1sNHlhUEc4?= =?utf-8?B?Q2diYUxrTm43b3BHbTRSTkdOUjBUSWljaTQ2TGFlWEFFdklYeTBQaHN6NVBU?= =?utf-8?B?WCt0Tm8xRUpHelA5K1JZeFRxWXVaY2tZaElESUUxc3dmT2ZCSE81VXlhRU5U?= =?utf-8?B?c3lSNFpUNmhURFo1Zis0NVVnVGJxUHJMeTNnczFpQ01vYVdDU1JEc2VFNDRz?= =?utf-8?B?aTVzNk1sMVk2QlRaUW5KR0IvTk9zWStBWnQvalphR0FTZGI2R0xtcWl4WmhL?= =?utf-8?B?c3ZMb3RjKzgzSGtsOUcySHg5VHBiL1lkTTF4RWJpYUdrTUNqT3ZuUVJJM3da?= =?utf-8?B?dmVEQlhJTW94dkdSZ2JLdUROMWNaMnlJOXkrT2o5czZ3RnBRQi9KWWFyeEd5?= =?utf-8?B?S1B4TXhUaDJ1TDU2dlV2Q2J2TzA0b1FMQXB3WGcyUXU0MVhSbFpFMk9xNGtH?= =?utf-8?Q?uHWGD2zj39HoG8uXvHfL8ydqX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f231b8a5-d7a8-4564-e059-08dac2fa8127 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 09:03:59.2083 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hb3ThsUu3q9eeCMhnPwM2jAd/EKSsjREaz9bjLiisjs3fUjytjFRv0MHE9DZwsifNO3/k4wQZlFwGuIAk0rA7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7979 On 09.11.2022 14:22, Roger Pau Monné wrote: > On Wed, Nov 09, 2022 at 01:02:28PM +0100, Jan Beulich wrote: >> On 09.11.2022 12:36, Roger Pau Monné wrote: >>> Since I don't see replies to my other comments, do you agree on >>> returning an error then? >> >> No, my view there hasn't changed. I wouldn't block a change to go in >> early for 4.18, but I also wouldn't ack such. >> >> Perhaps just one remark on your other earlier comments: While you're >> right about XEN_DOMCTL_SHADOW_OP_{CLEAN,PEEK}, (effectively) random >> data in the bitmap may cause a caller to do extra work, but wouldn't >> look to be otherwise harmful: Considering pages dirty which aren't >> is never a functional problem, while considering pages clean which >> aren't is (imo) not a problem for a dying domain. > > Can't that lead to failures elsewhere when attempts to fetch those > pages find they might have been removed from the p2m? Quite possible, yes. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 10 09:25:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 09:25:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441559.695696 (Exim 4.92) (envelope-from ) id 1ot3om-0000ZZ-Di; Thu, 10 Nov 2022 09:25:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441559.695696; Thu, 10 Nov 2022 09:25:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot3om-0000ZS-AZ; Thu, 10 Nov 2022 09:25:52 +0000 Received: by outflank-mailman (input) for mailman id 441559; Thu, 10 Nov 2022 09:25:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot3ok-0000ZM-6g for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 09:25:50 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140048.outbound.protection.outlook.com [40.107.14.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8e9258c-60d9-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 10:25:48 +0100 (CET) Received: from ZR0P278CA0148.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::23) by DU0PR08MB7613.eurprd08.prod.outlook.com (2603:10a6:10:311::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 09:25:44 +0000 Received: from VI1EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:910:41:cafe::99) by ZR0P278CA0148.outlook.office365.com (2603:10a6:910:41::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Thu, 10 Nov 2022 09:25:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT019.mail.protection.outlook.com (100.127.144.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Thu, 10 Nov 2022 09:25:43 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Thu, 10 Nov 2022 09:25:43 +0000 Received: from 8b07d53cb028.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7E470F6E-C7EB-43A7-B4E9-E2139C39886D.1; Thu, 10 Nov 2022 09:25:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8b07d53cb028.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Nov 2022 09:25:37 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM7PR08MB5319.eurprd08.prod.outlook.com (2603:10a6:20b:dc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 09:25:36 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Thu, 10 Nov 2022 09:25:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8e9258c-60d9-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=b2EHiCWL4CYy30M+lFqrwwWVNzUB00b96X8DO42hlJEO3J3xc/6T20uj40RED/UVlifIFrtWZWYuY/wtVPFe1T889b1RQdmMn91eamJWiuwOc7bQ6kUcbKqPzqoN1/IB7mEwRXztxYl2Y/3xe0fbVkZ6ChBVfzHEYoltzUT2QYmpMDv1zkKOjKGJP0TZczNpdnsQjziQo8QBZ+7/cqCc2Ktjrvh0RJ6VuRaS6sH9hj+FyOymRDHiuM8stcayPJ9zzOPN9crifdxz/K+EHwp3ltLu892OfdZtTJjifzGSzX7g3cnvm6pqqDH6wfgOTgp9ZlVeIzgt8Zf+jSGqIamhIQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I8lggpRIGZfOiJs0bWT/CM5KKEs5qWogZqPrPKzVnZs=; b=DddwQGR2Gj/ttf7Q6kZ7L2BkjJWoEvDzo5LAlQBORKfYuk19RAXweglzlcfrD3DIwMkKBuXctPymssWLBio02k5uIGYC1frUYG5AAAf5hs5G9zfHEqhcGkBMzKXyJvV5nl+vdco7PI3U+l71zZDLGBXSfUdqX4g6GGDCdzJQ6CIm5VeTDKDNfIeXFxdU6Cy8xSyIrPIKJKHMW2eCG08LS6EZq9xTTTy1ndtXfsiCbRj/IwSLLHPDTSWwwoo6May/fby3X4OpPJtnqIM+mjTmOAgTg54D0Ym3N1pa1YKv9yAfCePYmTwsp2Hep6qhuCg5pGYw5Ip50Zo8U7Una+x/rA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I8lggpRIGZfOiJs0bWT/CM5KKEs5qWogZqPrPKzVnZs=; b=HSrDqS6esdgSyM6YyEkg6L0l4TZjd06As0XBSWEB4ediAR03NAHFbMaazxtqqx4pDPqLkKGC9/Z0wDD6Wfgqce6WTpdX1h/peeVR3Rcf8Sod5+K8tVyiZlnlucWXsHgn4sYcRsncnoMfWho1g00rOCtn8l3Hf2zOMw7ZVNFyHHk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OUMaDpNZda7R+nWJzLzXs45L1oxy4Ek3MrKhyiNfVSy/ggBkfobF6ZLKYK6IEYc8Yvp8GwJxEIXh1L3EpQ7D8ezf9nO4rtNvb6eTRnMSBeHFT6d7TWcfQUzt1wLhL0gayZ+htbvhlxn0PkTyINawYuq3zuFKZb/HGRnVl4HJU43tFY7tJ8gRgMVIaTbDD+ymgpHhk+dqwlCFZgXRVdMcGBK5VdYZaTI9kzCCep2+Rs5ibf3PiE2mstp68jXiUNCXie/GpbbyOp6p34dNVV7MHcU5q6KyFTB7+xmSGrYnsZuTtIKhnBdUNTvtdBt4j3pJz3TZTIva3whXaCnDYEUK/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I8lggpRIGZfOiJs0bWT/CM5KKEs5qWogZqPrPKzVnZs=; b=cx8RV1rh/bTItAPCWiJL+h8GAttfHlSOyPdoe97Y/JmKScCzg/ewsVV2C9R8ThojGXkh0DXA7dmCZsi0OA0eAeYOBb4yni35qKHJPpSLbnjHIe0iYGtZQK8dMgnm09vrd1VzRaK+N2RCyrBd6vADeo6htdmLz6kSmrjQP8kQV/zpu3gTQzanvCrVp0bD7Iinc5JOVYJyuhXJQNOOpyDd3bZbvVDNTqBn5FlXBljLIeREvC6EmvhZacleSWXU/dlAlCwuZ6X9fuRACFGl/9Ip+jLAFtnU62QyryW04j0RuAfaQuFH30mX7qJMXFfyTroM6T91YJ76OVPDiRVEF1cN4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I8lggpRIGZfOiJs0bWT/CM5KKEs5qWogZqPrPKzVnZs=; b=HSrDqS6esdgSyM6YyEkg6L0l4TZjd06As0XBSWEB4ediAR03NAHFbMaazxtqqx4pDPqLkKGC9/Z0wDD6Wfgqce6WTpdX1h/peeVR3Rcf8Sod5+K8tVyiZlnlucWXsHgn4sYcRsncnoMfWho1g00rOCtn8l3Hf2zOMw7ZVNFyHHk= From: Henry Wang To: Christian Lindig , Julien Grall CC: Edwin Torok , "xen-devel@lists.xenproject.org" , David Scott , Wei Liu , Anthony Perard Subject: RE: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Index: AQHY84e5FV9zwZ/cMEqESsIC5Hbn0K41MEgAgACxXpCAAfedgIAACnbg Date: Thu, 10 Nov 2022 09:25:36 +0000 Message-ID: References: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B898338E1D01C745802EBCE1E1B1EB68.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM7PR08MB5319:EE_|VI1EUR03FT019:EE_|DU0PR08MB7613:EE_ X-MS-Office365-Filtering-Correlation-Id: 1aa342f0-05bb-46f2-80f2-08dac2fd8ac9 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DvkXNBbXcbdfvRXO7U4wXO8nfH1+Mg3toNnsECmfMRVoP4jVwESWZcA+P3MUuaI3XY9cA6zljHgb99BPwvlRviOqtFiUuSrTMr6ar4pjUL/L/POhxZSS67xOL4U6zlScTFbjf3U+BDYQ91hZeSo68ppf3Dr1HVve7zlhUKpNVdKQnpwpPrhTzWs/IxOUOqRs1uJ3NYPl88agplR7Q99XHjCM+E5OEsKBriOkewOGcD2AlIuuUvnjUg+GECNuXu/um6fKCJa6s9hRIQ3Fo0tAZq8XODCftpe8W+hHsc0dsJS95iVkGJgxDHaZbmrprfAUtk9Y9pqxCWdE1r1Rw1Rnp0C5DZnfCRcWVDfdvGeLPUg8LKxS6Z/n54LOiS+ArC7aFanY/jtVtxYgXBg2bBDOzSrlwYJltghXJUWkVo4CpfCwM3ebHAy5Su9QA87YCfOxDsGB27xCi5ess+Zj9Haqinnw+OWG1Gq9YNufNpnIdCI8ZlkbW6lKJzYU230ZLGNDxnHbKTT6u45GGkADWey3szidrPF4/skr/jLaE8OMteoUk7a2A9vdu3Zz17MmbUnw7ssfxDaOKn3/Rp5mcCQenDRvo9l6FSu+y69OcjTKOMpUJYtfiUPOd0raew9cCCgobHGRmGcG+snfAqAbTy8RTfs60qjmnWWwirbkEisTNNkwG4zeCVSFZ7L8xxnR9DsggK6fMpnDts89KDA3CDNvhcj/xQXnsTWxAY26fU2TCCCcCqSREU4c9Egev2MDgdFKy70MqBO6kWZIUqrzf5qiBflWhv3tP/VfqOVfburhsaE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(396003)(366004)(39860400002)(451199015)(38070700005)(33656002)(478600001)(122000001)(9686003)(2906002)(86362001)(41300700001)(186003)(5660300002)(52536014)(83380400001)(38100700002)(76116006)(71200400001)(66446008)(66476007)(54906003)(66946007)(316002)(7696005)(26005)(64756008)(6506007)(55016003)(66556008)(8936002)(8676002)(966005)(4326008)(110136005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5319 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c9ac6c81-c86a-4544-b5b4-08dac2fd865c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7xUC4lf8gtcBSS8AlemV+0AZqwanhcXl2EVnBI1/MrURu/7a+s50pw1oWraU4qc07TfudZmFYE6e4dzLKH0NMdi0ic3I9y7Y03Htrm3ARFTp3YAYHmHx0Twar57z/QfNKJ96KMh1OTSIMhdAA6i0hgR6ITyfWOsqr/mT1DruycSWIsh+JCMqrS+O3V6x+MdTEzjK8pEs/KsHkz+AjkW77fTUcqk+XIbX09l1a0P+cjJvk1tHD0F7hkh0icbWejuykMIFIx4xsjrqBkMpvAr/1uQG1pxB5uHriiBHeA9kZ6R3i+g0NPvUL1k5P21koujsRyLKfVwKHO6yIYJW1VM1yS4q++8rD45uC2LQ05ZMnt2jRiEpmdjlpalrKqMCIO+l2SzpmuN49q1SvVau6TPhBbcbcHoFlK7AMFCjSbEFxD2VJiDQMSLLQAsXD2sp65+DO4Y+W2hFDGHdLn/qOQqxjcjqYF+0ItIkg85FLu1mhGLVDCnXeVvuqp8IEWZiHbaqVwVF1/7jija4RxEh9YIj307Qg8TB0hgWJ+v6JHTWEEh3yTICkno37t7I3gLzjM3CA1fdRegr82ZecDrqDEV7F3qhE7PskuM1AyU37TellXnnfqRkKuaNHXq8U1jblKfNvdBL2HhGqhNVd+RUeV7ncNbE+YFT7UC2pB6u5rD25OiKj0Zi0TvRF7YCWbGa1kwe5uKPVQ+nPUWe95N1f6G8X/4bJc5ltVVwJaqG73Y3JTuQ8WfVy6WxprGxUP8l6dW/6OFQr3xtDlQkPGyzLX2aJ4dNN38C5Pbkpca3bMag8vH8ykgIUXw0oaMrZKLQWvVS X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199015)(36840700001)(46966006)(40470700004)(356005)(478600001)(82740400003)(82310400005)(107886003)(81166007)(966005)(110136005)(40480700001)(2906002)(36860700001)(54906003)(316002)(5660300002)(6506007)(7696005)(70586007)(9686003)(86362001)(41300700001)(33656002)(83380400001)(52536014)(336012)(8936002)(26005)(70206006)(4326008)(8676002)(40460700003)(55016003)(47076005)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 09:25:43.6385 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1aa342f0-05bb-46f2-80f2-08dac2fd8ac9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7613 SGkgQ2hyaXN0aWFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IENo cmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4NCj4gU3ViamVjdDog UmU6IFtQQVRDSCBmb3ItNC4xNyB2MyAwNy8xNV0gQ09ESU5HX1NUWUxFKHRvb2xzL29jYW1sKTog YWRkDQo+ICdtYWtlIGZvcm1hdCcgYW5kIHJlbW92ZSB0YWJzDQo+ID4+IFdoaWxlIEkgdW5kZXJz dGFuZCB0aGUgZ29hbCBhbmQgc3VwcG9ydCwgdGhpcyBzZWVtcyB0byBiZSBhIGJpdCB0b28gbGF0 ZQ0KPiA+PiB0byBkbyBpdCBpbiBYZW4gNC4xNyAod2UgYXJlIG9ubHkgYSBjb3VwbGUgb2Ygd2Vl a3MgYXdheSkuIEF0IHRoaXMgc3RhZ2UNCj4gPj4gb2YgdGhlIHJlbGVhc2Ugd2Ugc2hvdWxkIG9u bHkgZG8gYnVnIGZpeC4NCj4gPj4NCj4gPj4gVGhpcyBpcyBjbGVhcmx5IG9ubHkgYSBjb21lc21l dGljIGNoYW5nZSBhbmQgdGhlcmUgSSB3b3VsZCBhcmd1ZSB0aGlzDQo+ID4+IHNob3VsZCBiZSBk ZWZlcnJlZCB0byA0LjE4LiBUaGF0IHNhaWQgdGhlIGxhc3QgY2FsbCBpcyBmcm9tIHRoZSBSTS4N Cj4gPg0KPiA+IEkgYWdyZWUgd2l0aCB5b3VyIHBvaW50LiBJIHRoaW5rIG1heWJlIGRlZmVyIHRo ZSBwYXRjaCB0byA0LjE4IGlzIGJldHRlciwNCj4gPiBnaXZlbiB0aGUgZGVlcCBmcmVlemUgc3Rh dGUgd2UgYXJlIGN1cnJlbnRseSBpbi4NCj4gDQo+IEkgZGlzYWdyZWUuIFRoaXMgaXMgYW4gYXV0 b21hdGVkIGNoYW5nZSB0aGF0IGNhbiBiZSB2ZXJpZmllZCB0byBub3QgYWRkDQo+IGZ1bmN0aW9u YWwgY2hhbmdlcy4gRWR2aW4gaGFzIGRlbW9uc3RyYXRlZCB0aGF0IHdyb25nIGluZGVudGF0aW9u IGhhcw0KPiBtaXNsZWFkIHJldmlld2VycyBpbiB0aGUgcGFzdCBhbmQgY2F1c2VkIGJ1Z3MuIE5v Ym9keSBleGNlcHQgRWR2aW4gaGFzDQo+IGNvbnRyaWJ1dGVkIHRvIHRoZSBhZmZlY3RlZCBjb2Rl IGluIHllYXJzIGFuZCB0aHVzIGl0IGlzIG5vdCBhIGJ1cmRlbiBvbiB0aGUNCj4gcHJvamVjdCBv dXRzaWRlIHRoZSBPQ2FtbCBwYXJ0LiBJIHN1Z2dlc3QgdG8gYWNjZXB0IHRoaXMuDQoNCkkgdW5k ZXJzdGFuZCBwb2ludHMgZnJvbSB5b3UsIEVkd2luIGFuZCBKdWxpZW4sIGJ1dCBJIHRoaW5rIGlu IHRoZSBlYXJsaWVyDQpkaXNjdXNzaW9uIGluIHRoaXMgdGhyZWFkLCBKdWxpZW4gaGFzIHByb3Zp ZGVkIGFuIGFyZ3VtZW50IFsxXSB3aGljaCBJIGRvDQp0aGluayBpcyBhIHZhbGlkIHJlYXNvbiB0 byBkZWZlciB0aGlzIHBhdGNoIGEgbGl0dGxlIGJpdC4NCg0KQnV0IHNpbmNlIHlvdSBhcmUgdGhl IG9ubHkgbWFpbnRhaW5lciBvZiB0aGUgT2NhbWwgY29kZSwgc28gaWYgeW91IHN0cm9uZ2x5DQpp bnNpc3QgdGhpcyBwYXRjaCBzaG91bGQgYmUgaW5jbHVkZWQgZm9yIHRoZSByZWxlYXNlIGFuZCB0 aGVyZSB3b3VsZCBub3QgYmUNCmFueSBtb3JlIGV4cGxpY2l0IG9iamVjdGlvbnMgZnJvbSBvdGhl cnMgaW4gdGhlIG5leHQgY291cGxlIG9mIGRheXMsIEkgdGhpbmsgSQ0Kd2lsbCBwcm92aWRlIG15 IHJlbGVhc2UtYWNrIGZvciB0aGUgcHVycG9zZSBvZiByZXNwZWN0aW5nIG9waW5pb25zIGZyb20g dGhlDQptYWludGFpbmVyLiBIb3BlIHRoaXMgc29sdXRpb24gc2hvdWxkIGJlIGFjY2VwdGFibGUg dG8geW91Lg0KDQpbMV0gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzFmOGM5MGNk LTgwMzctODRlYi1kNmY3LWM2MzlmOGE4NzU4NUB4ZW4ub3JnLw0KDQpLaW5kIHJlZ2FyZHMsDQpI ZW5yeQ0KDQo+IA0KPiDigJQgQw0KPiANCj4gDQo+IA0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Nov 10 10:00:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 10:00:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441565.695707 (Exim 4.92) (envelope-from ) id 1ot4Ln-0004MU-0l; Thu, 10 Nov 2022 09:59:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441565.695707; Thu, 10 Nov 2022 09:59:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot4Lm-0004MN-UC; Thu, 10 Nov 2022 09:59:58 +0000 Received: by outflank-mailman (input) for mailman id 441565; Thu, 10 Nov 2022 09:59:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot4Ll-0004MH-U7 for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 09:59:58 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6c3afd84-60de-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 10:59:55 +0100 (CET) Received: from mail-dm6nam11lp2176.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Nov 2022 04:59:46 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by MW4PR03MB6665.namprd03.prod.outlook.com (2603:10b6:303:120::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Thu, 10 Nov 2022 09:59:44 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5813.013; Thu, 10 Nov 2022 09:59:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c3afd84-60de-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668074396; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=UFWDoty6lvFEmcTWTtF78Cyk+M1tvMeDyxkPG2AP6eU=; b=Q0JQEt9Oi/MUi+BTeWcjxN8XwvpE39duGntRS19XRfNakB7g58TuCe+e 6iuDjrOV7KKYqzk7ef/+axLBXSSGq5USiGD2rmjC6XL/gXwnmjfH2JFjB uFkZwyuigzzv7LO+ELINij9PImWVrlbYg6esrlKO0IOqNBmhy7nII08ow 0=; X-IronPort-RemoteIP: 104.47.57.176 X-IronPort-MID: 83622034 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:HHTFKqt/6Qb2jsKbev4VlHKW3+fnVJhfMUV32f8akzHdYApBsoF/q tZmKTrSaP2DZmT1KYt1Otng80sEsZ7SxtUxQVc/+HtgRS0b+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaHzyFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwAioTU0jYgOSK4be8YfUztMJyPOrEI9ZK0p1g5Wmx4fcOZ7nmGvyPyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osj/60b4S9lt+iHK25mm6Tp njH5Hj4CxdcMN2ZxTuK2nmtmvXOjWXwX4d6+LiQpqU02gfLnTB75Bs+CmGXh8WQlQmFctMCL koTvQUn87YdzRn+JjX6d1jiyJKehTY8VtxKAqsF4QeC4qPO5kCSAW1sZjxcbN0rsucmSDps0 UWG9/v5CDoqvLCLRHa18raPsSj0KSUTNXUFZyIPUU0C+daLiI06kB/nVNtoF6+xyNrvFlnY3 DSivCU4wbIJgqY2O76T+FnGh3ego8bPRwtsvwHPBDv6sEV+eZKvYJGu5R7D9/FcIY2FT16H+ n8Zh8yZ6+NIBpaI/MCQfNgw8HiSz67tGFXhbZRHRfHNKxzFF6afQL1t IronPort-HdrOrdr: A9a23:Cz4/3Ksv++PNNtBbd2gjMLRf7skC1YMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIP/Z4StU z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfpWG0hYczAgNkGmpDr1L8Yqq iJn/7mBbU115rlRBD2nfIq4Xin7N9h0Q669bbSuwqfnSWwfkNHNyMGv/MWTvKR0TtfgPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5TOObFuF4O5gLZvi3+9Kq1wah7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm10xR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XXJ0vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLmzNV1wg2XwqUmGLEfQI5tllulEU5XHNcrWGDzGTkwymM29pPhaCtHHWp +ISeBrP8M= X-IronPort-AV: E=Sophos;i="5.96,153,1665460800"; d="scan'208";a="83622034" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hnlvq095diDML9kegvEnuLD9RARzKZlA9XjQRxVzc7b8KU/9tyYr6GbL9E9CJ3p20np2BEqhuBLPaOPRTefVC0ff+RlT4vTRCqfbejQ0DbLGC/m0v0CxHPdx8TYMkBosUcDh9l0Zgy8vC0NqTKVZzFj+WQHdYQRozUYI4/MVkXcagaxCDUgr/mmvQw7TDkv0+YyokVpMo6KiHAFBLZkqJUwvbvMawzM+kPB7RB7MtqdqgymTTSXWnFybNdwSQCgeHba8ovIeuJuXg4Z/so81CNwde+wQEyccX9ggLfzi3NvCozw2BBdXTuj2cKlpmXlGyUMPJotUqQqGNMiH0Xw4xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UFWDoty6lvFEmcTWTtF78Cyk+M1tvMeDyxkPG2AP6eU=; b=BaPTdz7d2SB6bnnOF92M4HDi8GPIsa33kIJvL1/88S1Z4sUheSOr6FlpXArXLZPCK9MewpRMfjD08cZNvxaLi9+o/TBLb4WX2ub3KPp3fbEkjGHoRvjrNrABRtv4qE06Gm/Phx0xBBubqgVTN/vfypeZLFpguiCrdNDBOxcYr28GsxJzjvAdwPTH113eSnnNBjV9U3yUtZQ8Sm3LldQ/9qkoZxlmZz57UTwnZfj/aneRM9pJpPw/JSuK03sFcfO+wgKZqJOQOSy3JHZwsnhtOfSQKd9I6WB3wFam7+56E9pR98sBfRb8QdzlJxpHc/hg7V54Mlghg44qJFQUaUNYQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UFWDoty6lvFEmcTWTtF78Cyk+M1tvMeDyxkPG2AP6eU=; b=Gl9hp8vB4FKuXqeX6YZQI9pOUTzXXuMA5IUoTamgX0H4/dc0FFQ53WC0gVNCeBLMd2h0QKcA3nRHQUtrOJsFB/O7AHStlAKfR7dOMd8oKquGGfzlc3P6/LTNHNgi49HyiaMYI7yDPvK8DY8QxtSIrAdR5JVsZVzrTJOAvtfz/h8= From: Christian Lindig To: Henry Wang , Edwin Torok , Julien Grall CC: "xen-devel@lists.xenproject.org" , David Scott , Wei Liu , Anthony Perard Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Index: AQHY84fBVQkM1eqLakCv8k675veNsq41MEgAgACx3ICAAfcdAIAADHYAgAAJiYA= Date: Thu, 10 Nov 2022 09:59:44 +0000 Message-ID: <5ED80DE2-1AE6-4C56-8C05-E83162EBE534@citrix.com> References: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|MW4PR03MB6665:EE_ x-ms-office365-filtering-correlation-id: 91905e45-2063-4161-1bf2-08dac3024aea x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aJLtlLybdEUEEAo9oKjMpS7kkNW+cYj0N30pL9YKWyXxtX9JlmwlmgRmC/CByAFmIDSqEeNmetSUXe5Otg6rBaDjzNAt+wLKhS7PUPgxi/5orNFen/hN+nXWkxV/bCH3t16sC8G//g//OmC5ZtFo18x3/CzbyfqVj6rUGjS70dhtc/glKXgN1wqg5u0MUjSwiERN8MO9Miac6Ia9Cwv6kdEEcCfq/X+7zh7qcfhvPz84X5Co+boalrBE6C54+XdMIGuBJ7TPJVSI82dZi9CNzP8oq/WttTY/+gHS5Uo1l3GQqXC9Jwf1Tc7kTyToTDr4GkvpnCo/wl3vINFlwQOfOiX6AhiDIBoA6Z8NqMti97hvZ4pUDZ9KQyIBVvm9zdoMha1e/qh9NkNt0Qi8Km5iyvFferlJHdkLrayRI05RMIx3GAVucOslhFeB43OsSMulBS6dgUD5sWWxRz6L9gR+kueYP/yNhiL1GWaD1XvRDoiWxHj6Fo61VRntTLktqgGvoKJy7N/CUXY+alqenBQflxQkB6pxwOZTGGTtGQOWJ1KxcBfnCzM8q/6Fjm3tOH6SqEJScPVOrVEFI/5Kpd9dnfRaOLrrkqzoi/nnRuLsU2p8pLH5W/lOpGtweBEyAlqrWPRrkoZYucXZ6LKNBjapTIkMwlCmT3QjgxWopvRMX92w2aXU+JN/lenQQq/G8k1YKtyUc/J2Ind+C2+/06hw3lf8t/NW9NhaJ/3N0FFVQelxtc7HuwMoRj/mjJS0TMoxlVKcJsbgrnIXqvkIftygV/UtQneIJSS8oKlE3IS2DyM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(136003)(366004)(451199015)(478600001)(6486002)(6512007)(33656002)(44832011)(71200400001)(2616005)(186003)(83380400001)(82960400001)(107886003)(26005)(36756003)(4326008)(38100700002)(6506007)(8676002)(38070700005)(53546011)(2906002)(122000001)(66556008)(76116006)(316002)(66446008)(64756008)(66476007)(66946007)(86362001)(91956017)(8936002)(5660300002)(41300700001)(110136005)(54906003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cWM4MEJ0cDJmSWQ4c29zbWlmek5lU3Z3L0I5UkRjY2MvRWNidkZZdm4xR0Yz?= =?utf-8?B?SWpIVUNvQ1RCclEyY01pVG1SbURMSmlaQWNubWdKcGJtMHZUQUxIRGE5Umps?= =?utf-8?B?b2xCZ1dKNDZSbVhLZkVndUVXdWdjSDBnVFREcUpTcUJFdVlwWVZ6TGs5YWVF?= =?utf-8?B?K3IyRllEWW1kSG5idFhSRlFTdGtsYm9YKzRnZjI5UVlCRURpT3lBemZDc2VE?= =?utf-8?B?ZUNKZkRTclg4djd4K3U5eUlBQ1JZUXhSOEMwSzNTbGtybFJNdXdhQ1liTWVm?= =?utf-8?B?Vm4yTGdIL3FOOHB3WkZYajY3UlpiTHpsTXYvbldSOXNiQWl4aWNnb3JWZUUz?= =?utf-8?B?SjUvSWJ2WmFmM20wejdCWkdoeG00WHUxUDZnNHZ6SGxRVjlWU2tWcFpyY2x4?= =?utf-8?B?ZkhieTBnWC81V3pzSWJoRU5QaDNhbEhIbFFkOUt0by82QUVHc0N5SUxZb3pW?= =?utf-8?B?QzJLcXFtRlBIWnpCdWovcGNpQm5UUm1rYTNFRjJwMXJMSXQ3VXQxSzRQNWF2?= =?utf-8?B?ZjdTdGJiU1VJeitPcTJBOG9HZHcvNElQTzl1VUMzYW9zdWd5VVlrZTN2K1ZK?= =?utf-8?B?R3YwYnhuT2gvdy91K0Q3YkFwUWVWNEJ2Q3N4RkxWYXczdEYzRi9xL1hzQzVN?= =?utf-8?B?TW1WVXp0NzMzMi81cTcxRUxZYldHQS9ieS9pOHBlM2d2NHhUaHNmZWhTNGhB?= =?utf-8?B?eklQYTJmTEIxS2JBWmVEODNZNVU1aXJ1SmxMeW1pR2ZKam1DTmJ4a1h2RUJs?= =?utf-8?B?a0JNSW5aNUxHUS8wUWpMeFVNWEx2WWdVZklNMjZxRG9DOG9UNHNma2t2elVi?= =?utf-8?B?cjVGaXUrZVcrSHpkRi9CWVRUOTR1RTVublB6cEVQTlE3QlJTaEdDMjBJWjJL?= =?utf-8?B?QWNPVmhXOTFvOVlDSDRVRXRnc2NKWWRHWE0renpUSGExMXhzVWhPUTY3UVoz?= =?utf-8?B?a09EbHYvWGVoTzVuMkJieHIwZTI4THovRy9GQk1tSGNwSFhQdkRCWmp4bkM2?= =?utf-8?B?Wi9DT1pBU1pIRlF1Y2pUdnBnd3QxN2FneG1DeVZWTVVhSlpRdXdaMTVveHRh?= =?utf-8?B?c01zNG1kdmZaVmFodW5wNktZd1FLQnJ6dkJHdWE5bDNGczdaZWFwSnhhMW1k?= =?utf-8?B?OU5KTlJPd1B2SlF6cWNtK0hUVmlrUHNpU1JUNFMrenByMERIbUNtbjJndjk3?= =?utf-8?B?dHU0anRYc2R2ZFFWb21XZ1NCazd5RW9IODMrdmlSaGRuN25BSXNHRDJTYmlL?= =?utf-8?B?U1BEL2cxQVNPcnpBbStLclU4MTZIZ0oyS3dZM1pOWTNuNUFtbXRnZTF1eWVV?= =?utf-8?B?TWdaNm5Fc1ZkdTd3cVBqZjNkZ2trbDJiZmdhNndSYkREcnF2MUVCeFZheWY0?= =?utf-8?B?MnBtRC96cDlxVFJCRFJucy9vN1RxeENza0tleTcxOVJGTUpBdm5Kc3M3d0F3?= =?utf-8?B?YnJsd3A1d1RhQUVXaHEwVHlxU3YyWEkwZDF5azlTNEtuVlFtT2dxSEluWXc5?= =?utf-8?B?WkkzSVRxeUpNTEFIL1pmbnhicDB6VXh6Ry9WK1REQVRHRnc3QnMwRGJGbkUy?= =?utf-8?B?QWkvWXY2TENqS0NpOXNoSmNidTloTEpxZjlJZkt0VFlDR0tDOVNEYUZqYTNT?= =?utf-8?B?ZlMyVGgvaDJsbVZyc1BCN2NxZ296UW15L3ZYNC9zN2lQcWFGVkxqamovNDdh?= =?utf-8?B?ODF5SnpzNEova25TcXlTdUJjaTdPRWt5RUxWZVUxTnlJNDJZa2V5SjhYNE91?= =?utf-8?B?YlkzTGZwVnFBUXNqVktaOGJKdlNySkFTVHRRbHgxaW9NR0d2cUhvR2VKeUVs?= =?utf-8?B?UnNneGI2RUdGaXJRcVV5b1RGMnJvUlJxZG1hUU5pbDlHVHg4Uy9QcHErSG1N?= =?utf-8?B?VGd4UDhLOWhsSTZYeEpXNE82MDNKMmx6cXdJNytkTWVnUEZaZEh1cUIrTStJ?= =?utf-8?B?emxIQU9iQnBXeVdNNmtVTkV0RTdTWGhNYTlMNWFmMnlmc2h1NUZLZVFVMFBX?= =?utf-8?B?cjE1TDdiczg5WEMrY1pWblFzTkE4dXE3RzVTL3J3WTdwTm1XYlFuclMzcHZH?= =?utf-8?B?VjZUSUNzOFlWZFhyQW1tZkdaVmdsVnZsZjZuUldmVHhsS0lxNDE5OEVLWkVZ?= =?utf-8?B?cmlXNE1ibXJCSDZwb2RtOTNPU01Oa2FJb2xpMm5Lb2IxZjlnL3NBSW1PTUZj?= =?utf-8?Q?xJZfdkCGCMkEbK9aaWzu0w0=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91905e45-2063-4161-1bf2-08dac3024aea X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2022 09:59:44.0241 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IwcydgXQAtqbVK2vVBPD7RG2jKkAB57mTx8VciGjbZrNWut46IByKxTn6dv8bZwK233Uqo2pJZBG3m64CI71fRyinAibaWB72m3ZzNCfl78= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6665 DQoNCj4gT24gMTAgTm92IDIwMjIsIGF0IDA5OjI1LCBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFy bS5jb20+IHdyb3RlOg0KPiANCj4gSGkgQ2hyaXN0aWFuLA0KPiANCj4+IC0tLS0tT3JpZ2luYWwg TWVzc2FnZS0tLS0tDQo+PiBGcm9tOiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGln QGNpdHJpeC5jb20+DQo+PiBTdWJqZWN0OiBSZTogW1BBVENIIGZvci00LjE3IHYzIDA3LzE1XSBD T0RJTkdfU1RZTEUodG9vbHMvb2NhbWwpOiBhZGQNCj4+ICdtYWtlIGZvcm1hdCcgYW5kIHJlbW92 ZSB0YWJzDQo+Pj4+IFdoaWxlIEkgdW5kZXJzdGFuZCB0aGUgZ29hbCBhbmQgc3VwcG9ydCwgdGhp cyBzZWVtcyB0byBiZSBhIGJpdCB0b28gbGF0ZQ0KPj4+PiB0byBkbyBpdCBpbiBYZW4gNC4xNyAo d2UgYXJlIG9ubHkgYSBjb3VwbGUgb2Ygd2Vla3MgYXdheSkuIEF0IHRoaXMgc3RhZ2UNCj4+Pj4g b2YgdGhlIHJlbGVhc2Ugd2Ugc2hvdWxkIG9ubHkgZG8gYnVnIGZpeC4NCj4+Pj4gDQo+Pj4+IFRo aXMgaXMgY2xlYXJseSBvbmx5IGEgY29tZXNtZXRpYyBjaGFuZ2UgYW5kIHRoZXJlIEkgd291bGQg YXJndWUgdGhpcw0KPj4+PiBzaG91bGQgYmUgZGVmZXJyZWQgdG8gNC4xOC4gVGhhdCBzYWlkIHRo ZSBsYXN0IGNhbGwgaXMgZnJvbSB0aGUgUk0uDQo+Pj4gDQo+Pj4gSSBhZ3JlZSB3aXRoIHlvdXIg cG9pbnQuIEkgdGhpbmsgbWF5YmUgZGVmZXIgdGhlIHBhdGNoIHRvIDQuMTggaXMgYmV0dGVyLA0K Pj4+IGdpdmVuIHRoZSBkZWVwIGZyZWV6ZSBzdGF0ZSB3ZSBhcmUgY3VycmVudGx5IGluLg0KPj4g DQo+PiBJIGRpc2FncmVlLiBUaGlzIGlzIGFuIGF1dG9tYXRlZCBjaGFuZ2UgdGhhdCBjYW4gYmUg dmVyaWZpZWQgdG8gbm90IGFkZA0KPj4gZnVuY3Rpb25hbCBjaGFuZ2VzLiBFZHZpbiBoYXMgZGVt b25zdHJhdGVkIHRoYXQgd3JvbmcgaW5kZW50YXRpb24gaGFzDQo+PiBtaXNsZWFkIHJldmlld2Vy cyBpbiB0aGUgcGFzdCBhbmQgY2F1c2VkIGJ1Z3MuIE5vYm9keSBleGNlcHQgRWR2aW4gaGFzDQo+ PiBjb250cmlidXRlZCB0byB0aGUgYWZmZWN0ZWQgY29kZSBpbiB5ZWFycyBhbmQgdGh1cyBpdCBp cyBub3QgYSBidXJkZW4gb24gdGhlDQo+PiBwcm9qZWN0IG91dHNpZGUgdGhlIE9DYW1sIHBhcnQu IEkgc3VnZ2VzdCB0byBhY2NlcHQgdGhpcy4NCj4gDQo+IEkgdW5kZXJzdGFuZCBwb2ludHMgZnJv bSB5b3UsIEVkd2luIGFuZCBKdWxpZW4sIGJ1dCBJIHRoaW5rIGluIHRoZSBlYXJsaWVyDQo+IGRp c2N1c3Npb24gaW4gdGhpcyB0aHJlYWQsIEp1bGllbiBoYXMgcHJvdmlkZWQgYW4gYXJndW1lbnQg WzFdIHdoaWNoIEkgZG8NCj4gdGhpbmsgaXMgYSB2YWxpZCByZWFzb24gdG8gZGVmZXIgdGhpcyBw YXRjaCBhIGxpdHRsZSBiaXQuDQo+IA0KPiBCdXQgc2luY2UgeW91IGFyZSB0aGUgb25seSBtYWlu dGFpbmVyIG9mIHRoZSBPY2FtbCBjb2RlLCBzbyBpZiB5b3Ugc3Ryb25nbHkNCj4gaW5zaXN0IHRo aXMgcGF0Y2ggc2hvdWxkIGJlIGluY2x1ZGVkIGZvciB0aGUgcmVsZWFzZSBhbmQgdGhlcmUgd291 bGQgbm90IGJlDQo+IGFueSBtb3JlIGV4cGxpY2l0IG9iamVjdGlvbnMgZnJvbSBvdGhlcnMgaW4g dGhlIG5leHQgY291cGxlIG9mIGRheXMsIEkgdGhpbmsgSQ0KPiB3aWxsIHByb3ZpZGUgbXkgcmVs ZWFzZS1hY2sgZm9yIHRoZSBwdXJwb3NlIG9mIHJlc3BlY3Rpbmcgb3BpbmlvbnMgZnJvbSB0aGUN Cj4gbWFpbnRhaW5lci4gSG9wZSB0aGlzIHNvbHV0aW9uIHNob3VsZCBiZSBhY2NlcHRhYmxlIHRv IHlvdS4NCg0KVGhhbmtzIEhlbnJ5LiBJIHRoaW5rIHRoZSBhcmd1bWVudCBoZXJlIGlzIHRoZSBi YWxhbmNlIGJldHdlZW4gbWFpbnRhaW5pbmcgYSBwb2xpY3kgYWdhaW5zdCBsYXRlIGxhcmdlIGNo YW5nZXMgYW5kIGltcHJvdmluZyB0aGUgcXVhbGl0eSBhbmQgdGhlIHJlbGlhYmlsaXR5IG9mIGZ1 dHVyZSBwYXRjaGVzIGJ5IHVzaW5nIG1vcmUgYXV0b21hdGlvbi4gSSBhZ3JlZSB0aGF0IGxhcmdl IGZ1bmN0aW9uYWwgY2hhbmdlcyBhbmQgYW55IGNoYW5nZSB0aGF0IGNhbuKAmXQgYmUgdmVyaWZp ZWQgc2hvdWxkIGJlIGF2b2lkZWQgYnV0IEkgZG9u4oCZdCB0aGluayB0aGlzIGNhc2UgaXMgb25l LiBIb3dldmVyLCANCkkgYW0gZmluZSBkZWZlcnJpbmcgdGhlIHBhdGNoIGJhc2VkIG9uIGFuIGFn cmVlZCBwb2xpY3kgaWYgd2UgY2FuIG1ha2UgaXQgYSBwcmlvcml0eSB0byBnZXQgaW4gaW4gc29v bi4gRm9yIG1lIHRoaXMgaXMgcGFydCBvZiBpbXByb3ZpbmcgdGhlIE9DYW1sIGNvZGUgYmFzZSBh bmQgcHJvamVjdCBxdWFsaXR5IGJ5IHVzaW5nIG1vcmUgYXV0b21hdGlvbiBpbiBmb3JtYXR0aW5n IGFuZCB0aGUgYnVpbGQgc3lzdGVtIHRoYXQgbG93ZXJzIHRoZSBiYXJyaWVyIGZvciBjb250cmli dXRvcnMgc3VjaCB0aGF0IHRoZXkgZG9u4oCZdCBoYXZlIHRvIHdvcnJ5IGFib3V0IHByb2NlZHVy YWwgYXNwZWN0cyBsaWtlIHRhYnMsIHNwYWNlcywgaW5kZW50YXRpb24sIG9yIGJ1aWxkIHN5c3Rl bXMuIA0KDQrigJQgQw== From xen-devel-bounces@lists.xenproject.org Thu Nov 10 10:08:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 10:08:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441574.695718 (Exim 4.92) (envelope-from ) id 1ot4Ts-0006DR-VR; Thu, 10 Nov 2022 10:08:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441574.695718; Thu, 10 Nov 2022 10:08:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot4Ts-0006DK-Sd; Thu, 10 Nov 2022 10:08:20 +0000 Received: by outflank-mailman (input) for mailman id 441574; Thu, 10 Nov 2022 10:08:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot4Tq-0006DE-PK for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 10:08:19 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80088.outbound.protection.outlook.com [40.107.8.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9803af49-60df-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 11:08:16 +0100 (CET) Received: from AM5PR0502CA0003.eurprd05.prod.outlook.com (2603:10a6:203:91::13) by AM8PR08MB6450.eurprd08.prod.outlook.com (2603:10a6:20b:317::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 10:08:12 +0000 Received: from AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:91:cafe::e) by AM5PR0502CA0003.outlook.office365.com (2603:10a6:203:91::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.24 via Frontend Transport; Thu, 10 Nov 2022 10:08:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT046.mail.protection.outlook.com (100.127.140.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Thu, 10 Nov 2022 10:08:11 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Thu, 10 Nov 2022 10:08:11 +0000 Received: from 0a31d866176b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 97DE5B1D-B9FB-4193-B4A5-7E8190CBAE19.1; Thu, 10 Nov 2022 10:08:03 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0a31d866176b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Nov 2022 10:08:03 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DU0PR08MB9510.eurprd08.prod.outlook.com (2603:10a6:10:44e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 10:08:01 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5813.013; Thu, 10 Nov 2022 10:08:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9803af49-60df-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RJohZk5q8a1K90rsFeWkwl7Dug8P7HROwlQBOSRbi1OYmfAV53AqZ7huGiz3Pci4wUFb1CrPkX+yD+T+vooxHypYHTMyH7T5qGgdUyPvojskw7VFkJKjfXExCY/ErdeYg+h0lyCg4CV9ig+XYNBaNVRptnsvQZ/64fb9vAdK4jF0S5W5dqTZrckS3fzFDYV5l3Rk6PlJBfF4Ba/Yfo6XrUskPVgKBzopU0lc/A8yXMEEC4wXuoI9KRv/ByuW5Ku8VEuON5t/dBGlqIL4HhQzKPNWYkFBaKsKpewAPEcFAoVjqKqwsTRaBEC859b5J9BhxZ0+HtuarqEeh4cHL0Stig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pDf9fLYcDaftzMjbxV7J+mqaiqnt7IsTWjw6Qq4tbkU=; b=nyZBoKAb45jhKjEcAj48bn9rZaGNO6thofi89DEbaO5byV0lAeOjB203gssLbJ2dXmx2Tw9JCk/yVRa2n1yA+O8fztmSDdrjOzI52Z4w8EeYd8nQjTydZfTTExX7JrPef5F/PWRqPhVC6tvalonJhFg5Abs/zPFAUa1qhZMpDCZkCT49y2J3nJ+FFhoTcTPhdxWuCmllytE4MoJS/KwSHYstVbR6HADO1WlmwfnmfHrn8n0fDrnUooQelWsR2Y69BB2bMs3CJWSzMVesZVk004EYafYxRoHdzcb7mhKwC9SDlRvNC1ppenrhVKVccEbVGnHqn3vdYHIkFbyGImcmRA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pDf9fLYcDaftzMjbxV7J+mqaiqnt7IsTWjw6Qq4tbkU=; b=fAqOu0BwAplJudW8QlEjA0/RKF2yDpoz43sSnVxs/tsGFIYH9K86oa9ZLdg7UmODrUHp4lkjfYsaOjZKOETvjAEsNltauYh/lj9atZtLneJOO/7Fhnaa1sxNouYTzdwHMUHibSjdLa96lgTc5c+TXHNbvGnN3+/bXAuYyRC+NOA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 028205128a85c7fb X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zn4HnDGLlpwrv8SM1ndWiWunmI+/epqmGFX5w6VRWELmJU2C4aa+/6qn5sJgNkgrrJS714O2+QRSGElukr65/FaZGNUXucWrJ8FrtshiC7g/+Ylv13JeclJ+atq/TwlfxKfA1warKYKA31kTuKS58WHUAMShprHHqieIa2lIorKeUmBsXbe3af8UAbfC0JSRf6Cf8OQh8LnHjkvlCrB9qiUOsj88Bq+zCm9UlX3APc1Ol1sHhH2rYyogkHd5b0eYBSnDIYEGrpzsR1ZOzhq7tgosyky562lBK9fA6ZGEJ8ziBoVWOvXNXvHARbuTWqBztJ3bDt5sXb+85fBCEht9iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pDf9fLYcDaftzMjbxV7J+mqaiqnt7IsTWjw6Qq4tbkU=; b=V8Be2EH8DqvG+b5MXwheTIMlUacUHASFC+JOUfBjPyyZF8weyMJkJyLyFaAZ9xM1eq/3u2lkWdPTwAEi65GKOr4tryYvObtc0js940iQqPKz7l+bs1Bf0l8VGqRMjdFGipqhbKA+cmOUlacDPUfRP5alai+1Z1eOR3kqzIy1M4GoD4QLvC5Sx7kVChWhz2qWWji/cI3GvePj3O7BTkYu9/8p5D8JCnvuU2573egA4+h6ci4CvcCF+gI1uPVSqMheaabGXI/H9Ca8S8WwPUmoeBqIHbUnAc6TtSjrRpyJparWfOmc1sH1JSqawCfkW5qzfpVnIv6Br6VkEpBPPowIJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pDf9fLYcDaftzMjbxV7J+mqaiqnt7IsTWjw6Qq4tbkU=; b=fAqOu0BwAplJudW8QlEjA0/RKF2yDpoz43sSnVxs/tsGFIYH9K86oa9ZLdg7UmODrUHp4lkjfYsaOjZKOETvjAEsNltauYh/lj9atZtLneJOO/7Fhnaa1sxNouYTzdwHMUHibSjdLa96lgTc5c+TXHNbvGnN3+/bXAuYyRC+NOA= From: Bertrand Marquis To: Michal Orzel CC: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Doug Goldstein Subject: Re: [PATCH v3 0/4] Yocto Gitlab CI Thread-Topic: [PATCH v3 0/4] Yocto Gitlab CI Thread-Index: AQHY7TFh2hDh7VPqHUGkPo4tUdJZza4okuGAgAAFoQCACog5gIAEOL6AgAB51ICAACrvgA== Date: Thu, 10 Nov 2022 10:08:00 +0000 Message-ID: <1C829AF9-8DFF-47FA-8334-09A31AA9B069@arm.com> References: <1220596a-4fe7-5c08-5437-fa98eb14254c@amd.com> <6ee0706b-d1b3-187a-1557-c4b8173c6e37@amd.com> <46c0e05f-47e1-39e6-d978-9f6c7d6db53a@amd.com> In-Reply-To: <46c0e05f-47e1-39e6-d978-9f6c7d6db53a@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DU0PR08MB9510:EE_|AM7EUR03FT046:EE_|AM8PR08MB6450:EE_ X-MS-Office365-Filtering-Correlation-Id: aed0e272-9275-4c1f-3859-08dac303797b x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: EI/Ir7VpERGKztJCe/OnmivL+RoHFbXwAd9+mpOZsD0LarbbdJ9bFFxHohAj1hyAIOz0ShUPshuipw+h4Nbzv6AR/bkiapPkwT5v9E+ipnz7r88wn5Q9KVEoE4Y2EkMueroTrBNfwlB1SlRj9ffQOxc60gnahBcqXgOAB0pCqWC/RTiQgKiuc8kRppEKlaQq/1dWnoMVYtCKu+rII9aefhQ9UQ9PWtQLjCfwnhcPPZ57hkdJdqC4orxw6f1yNXC50oI23UzTBYfljub1UpokPoHWEyoR6fQa2jcSMC/j0jA8nOyifrmb3g/KUIP7V/4KMvNwFFXrRtb9GgRx/joMPwjQGTqQ6aZ4mcZCU7d0pzBB5IJEXGFzgplGgUTH1813mu26jyYpMcY/J3tRRH5ksXyzzh4hqa4R9SYy56vp4zg/+cCCzK0jT2/yeLd8JEkZScFRHhONhwvfdh2Q0x3HlDlYnvWSHSccjtf8SqONdIhFzBZzOSJIzIk2Uhee7BnS8q72OlhIOt9WylDU3S+McbQiP1U2Hq9MS3YeVcyebzE+mF1Jlk+RMWz+KgKjsVZ6NVKo3FMo8BAY3rWFpcxZbF9wspa1bduhwtB1b8iCEAdz1m0J0uqynq7aZTT+m1qG649NCiXi6OOO/wdGexumEf9JYJ+ywO8yJIA2/RQt4xCNPRhrwHywCzRlyjHvF3dz5bUmv7a/Af0r23Pzs2lkr6rZUyi6WjTF5mY0m5Cdafxp2s1kNcVDOUH9gs0GQVHew3OqltNeCIIEh2i3LnF9Ze3bN8VNx4QMWjwmJpJwfGxoHXHT/ZAAeOPHHdmrcyIeD+w61Rb0sCIKOPqf4bHiHQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(136003)(346002)(376002)(396003)(451199015)(186003)(2616005)(6512007)(53546011)(6506007)(26005)(478600001)(83380400001)(33656002)(2906002)(86362001)(45080400002)(966005)(6486002)(316002)(6916009)(54906003)(71200400001)(38070700005)(36756003)(5660300002)(8936002)(91956017)(76116006)(66946007)(66446008)(64756008)(66476007)(66556008)(4326008)(8676002)(41300700001)(38100700002)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <26E588448E0DC740AAA97032CF4B2F9A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9510 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 74876afa-e70d-4aaf-e3cb-08dac30372d4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZUKhr2bB4HG+CxbsChDQo5Zr9IDpowdh7KsAECg+ky0dz1sCUetS2oDo2WLsf3wgbGCjk1XBnh8hp8DvM8Wg4qi4jbvWOxUR3iIcybvB4KYEKEIuPW3PUZ3wekoHuqUrMyEtCAvQKK6on1PFC9OMzYj4eS03U/jgSTvwaRUkqEHsJPRB0H/vh60MLPYM48wYyy18hp3BQ809Hmh+pgLNt4OF3MfC0Gq0CPL/xV/fd4ZP076owIejhqFBGvspKNMBbimiWQnR4LUY27ubN8AhlkVx6THUxY8yR8De3wgiARmDzFD7bNvQmcQSZBRcaiRKWUnCIBsmqLQVu5/8XeXu2lfMmPEpXBcdngVTo6vys+vO+6ZmvPe1eCoc6CLT/0lpMQKRvSEywUHCTMn9/Y5OaTNcowzxz5Jc5R6xpLwzA1WmzaWOPcoEfscJGWF8cy506SZX2hkf3px7wpjpGIsV/GhPGaxG+YvovMb3t13J3S8+/U1KEWH7QutnyNjbW8Yrw/+ustozSwfLKcR96xfJHCTWDG3UAkgpCU0NL8shS8Oxc4MKLAGjLwWwCOLj4k9/GelPLLGm9jIewOGPMWqC8epdGJ3ONkn0m3vCp67XDOqdQOzOnjbbolHeW4qL+SaXjV/FUUX20B6BmYPFk1E2G+mn3660gF6gVw0rZE6VX7mH5ZbNVjJwx3RQY8k7uEwWQn6f9p4XIx9fUrK6G4qIp5oOTnJc8PIcprnJm8xaJmH98pCgJiJqD+6oC9wpsnQ9JF1p8I6Po8bo+PYEWbNRLe/+FtwMwLg+KnGdYluprrrZhn7xZHv7GhFoBHBsitPO X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(136003)(396003)(451199015)(40470700004)(36840700001)(46966006)(36860700001)(6506007)(316002)(54906003)(6862004)(8936002)(83380400001)(2616005)(33656002)(336012)(5660300002)(47076005)(40480700001)(40460700003)(2906002)(186003)(70586007)(70206006)(53546011)(4326008)(8676002)(6512007)(41300700001)(26005)(36756003)(86362001)(82740400003)(81166007)(6486002)(966005)(45080400002)(356005)(107886003)(82310400005)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 10:08:11.6158 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aed0e272-9275-4c1f-3859-08dac303797b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6450 Hi Michal, > On 10 Nov 2022, at 07:34, Michal Orzel wrote: >=20 > Hi Stefano, >=20 > On 10/11/2022 01:18, Stefano Stabellini wrote: >>=20 >>=20 >> On Mon, 7 Nov 2022, Michal Orzel wrote: >>> Hi Bertrand and Stefano, >>>=20 >>> On 31/10/2022 16:00, Bertrand Marquis wrote: >>>>=20 >>>>=20 >>>> Hi Michal, >>>>=20 >>>>> On 31 Oct 2022, at 14:39, Michal Orzel wrote: >>>>>=20 >>>>> Hi Bertrand, >>>>>=20 >>>>> On 31/10/2022 15:00, Bertrand Marquis wrote: >>>>>>=20 >>>>>>=20 >>>>>> This patch series is a first attempt to check if we could use Yocto = in >>>>>> gitlab ci to build and run xen on qemu for arm, arm64 and x86. >>>>>>=20 >>>>>> The first patch is creating a container with all elements required t= o >>>>>> build Yocto, a checkout of the yocto layers required and an helper >>>>>> script to build and run xen on qemu with yocto. >>>>>>=20 >>>>>> The second patch is creating containers with a first build of yocto = done >>>>>> so that susbsequent build with those containers would only rebuild w= hat >>>>>> was changed and take the rest from the cache. >>>>>>=20 >>>>>> The third patch is adding a way to easily clean locally created >>>>>> containers. >>>>>>=20 >>>>>> This is is mainly for discussion and sharing as there are still some >>>>>> issues/problem to solve: >>>>>> - building the qemu* containers can take several hours depending on = the >>>>>> network bandwith and computing power of the machine where those are >>>>>> created >>>>> This is not really an issue as the build of the containers occurs on = the local >>>>> machines before pushing them to registry. Also, building the containe= rs >>>>> will only be required for new Yocto releases. >>>>>=20 >>>>>> - produced containers containing the cache have a size between 8 and >>>>>> 12GB depending on the architecture. We might need to store the build >>>>>> cache somewhere else to reduce the size. If we choose to have one >>>>>> single image, the needed size is around 20GB and we need up to 40GB >>>>>> during the build, which is why I splitted them. >>>>>> - during the build and run, we use a bit more then 20GB of disk whic= h is >>>>>> over the allowed size in gitlab >>>>> As we could see during v2 testing, we do not have any space restricti= ons >>>>> on the Xen GitLab and I think we already decided to have the Yocto >>>>> integrated into our CI. >>>>=20 >>>> Right, I should have modified this chapter to be coherent with your la= test tests. >>>> Sorry for that. >>>>=20 >>>>>=20 >>>>> I will do some testing and get back to you with results + review. >>> I did some testing and here are the results: >>>=20 >>> In the current form this series will fail when running CI because the Y= octo containers >>> are based on "From ubuntu:22.04" (there is no platform prefix), which m= eans that the containers >>> are built for the host architecture (in my case and in 99% of the cases= of the local build it will >>> be x86). In Gitlab we have 2 runners (arm64 and x86_64). This means tha= t all the test jobs would need >>> to specify x86_64 as a tag when keeping the current behavior. >>> After I built all the containers on my x86 machine, I pushed them to re= gistry and the pipeline was successful: >>> https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit= lab.com%2Fxen-project%2Fpeople%2Fmorzel%2Fxen-orzelmichal%2F-%2Fpipelines%2= F686853939&data=3D05%7C01%7Cmichal.orzel%40amd.com%7C2449f063e67341c3b9= 5a08dac2b112a5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638036363027707= 274%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1= haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DEwTJrW2vuwQIugKc7mnzG9NNbsY= LP6tw5UODzBMmPEE%3D&reserved=3D0 >>=20 >> When I tested the previous version of this series I built the >> containers natively on ARM64, so that is also an option. >>=20 >>=20 >>> Here is the diff on patch no. 3 to make the series work (using x86 tag = and small improvement to include needs: []): >>> ``` >>> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test= .yaml >>> index 5c620fefce59..52cccec6f904 100644 >>> --- a/automation/gitlab-ci/test.yaml >>> +++ b/automation/gitlab-ci/test.yaml >>> @@ -65,6 +65,9 @@ >>> paths: >>> - 'logs/*' >>> when: always >>> + needs: [] >>> + tags: >>> + - x86_64 >>>=20 >>> # Test jobs >>> build-each-commit-gcc: >>> @@ -206,19 +209,13 @@ yocto-qemuarm64: >>> extends: .yocto-test >>> variables: >>> YOCTO_BOARD: qemuarm64 >>> - tags: >>> - - arm64 >>>=20 >>> yocto-qemuarm: >>> extends: .yocto-test >>> variables: >>> YOCTO_BOARD: qemuarm >>> - tags: >>> - - arm32 >>>=20 >>> yocto-qemux86-64: >>> extends: .yocto-test >>> variables: >>> YOCTO_BOARD: qemux86-64 >>> - tags: >>> - - x86_64 >>> ``` >>>=20 >>> Now, the logical way would be to build x86 yocto container for x86, arm= 64 for arm64 and arm32 on arm64 or x86. >>> I tried building the container qemuarm64 specifying target arm64 on x86= . After 15h, only 70% of the Yocto build >>> was completed and there was an error with glibc (the local build of the= container for the host arch takes on my machine max 2h). >>> This enormous amount of time is due to the qemu docker emulation that h= appens behind the scenes (I checked on 2 different machines). >>>=20 >>> So we have 3 solutions: >>> 1) Build and run these containers for/on x86_64: >>> - local users can build the containers on local machines that are almos= t always x86 based, in short period of time, >>> - "everyone" can build/push the containers once there is a new Yocto re= lease >>> - slightly slower CI build time >>> 2) Build and run these containers for specific architectures: >>> - almost no go for local users using x86 machine (unless using more tha= n 16 threads (which I used) and willing to wait 2 days for the build) >>> - faster CI build time (arm64 runner is faster than x86 one) >>> - someone with arm64 based machine (not that common) would have to buil= d and push the containers >>> 3) Try to use CI to build and push the containers to registry >>> - it could be possible but what about local users >>=20 >> From a gitlab-ci perspective, given the runners we currently have, we >> have to go with option 2). We don't have enough resources available on >> the x86 runner to run the Yocto jobs on x86. >>=20 > That is what I reckon too. Running the Yocto build/test on CI using x86 r= unner will always be slower. > So, if we go with this solution, then the following is needed: > 1. Modify test jobs so that yocto-qemu{arm64/arm} uses arm64 tag to be ta= ken by arm64 runner and use tag x86_64 for yocto-qemux86-64. > 2. Come up with a solution to build the yocto containers automatically fo= r the above platforms + possibility to specify the platform for local users= . > Right now, these containers are being always build for the host machine= platform, so without doing tricks like adding --platform or prefix to imag= e name, > one cannot build the Yocto containers that would be ready to be pushed = to registry. We need to have a clean solution without requiring user to do = tricks. >=20 > The only drawback of this solution is that the person building the yocto-= qemu{arm64/arm} container and willing to push it to registry, > needs to have access to arm64 machine. I think we need to find a solution working for both possibilities. And we also need a solution so that one can have both kind of images so the= host machine should be encoded in the container name somehow. >=20 >>=20 >>> Regardless of what we chose, we need to keep in mind that the biggest a= dvantage to the Yocto build/run is that >>> it allows/should allow local users to perform basic testing for all the= Xen supported architectures. This is because >>> everything happens in one place with one command. >>=20 >> That's right, but it should be possible to allow the Yocto containers to >> also build and run correctly locally on x86, right? The arm/x86 tag in >> test.yaml doesn't matter when running the containers locally anyway. All in all, test.yaml only matter for gitlab. Maybe we could have it supporting both cases but only use one ? Cheers Bertrand >=20 > ~Michal From xen-devel-bounces@lists.xenproject.org Thu Nov 10 10:10:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 10:10:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441579.695729 (Exim 4.92) (envelope-from ) id 1ot4W9-0007YV-CB; Thu, 10 Nov 2022 10:10:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441579.695729; Thu, 10 Nov 2022 10:10:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot4W9-0007YO-9C; Thu, 10 Nov 2022 10:10:41 +0000 Received: by outflank-mailman (input) for mailman id 441579; Thu, 10 Nov 2022 10:10:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot4W7-0007YI-Bz for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 10:10:39 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2085.outbound.protection.outlook.com [40.107.105.85]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eb09ec04-60df-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 11:10:37 +0100 (CET) Received: from AS9PR06CA0307.eurprd06.prod.outlook.com (2603:10a6:20b:45b::32) by AM7PR08MB5319.eurprd08.prod.outlook.com (2603:10a6:20b:dc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 10:10:31 +0000 Received: from VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45b:cafe::23) by AS9PR06CA0307.outlook.office365.com (2603:10a6:20b:45b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Thu, 10 Nov 2022 10:10:31 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT017.mail.protection.outlook.com (100.127.145.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Thu, 10 Nov 2022 10:10:30 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Thu, 10 Nov 2022 10:10:30 +0000 Received: from 0f9682feaf6e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id ECFC59EC-5601-476A-9B3C-357F0BC3EEF6.1; Thu, 10 Nov 2022 10:10:24 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0f9682feaf6e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Nov 2022 10:10:24 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by GV1PR08MB8353.eurprd08.prod.outlook.com (2603:10a6:150:a3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 10:10:22 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Thu, 10 Nov 2022 10:10:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb09ec04-60df-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FqYbxUxz5Yb9OuFUKQQm+F/RK5hzK1b40wjVbQIOeDLtmrqst3bwAlJWlBNiRI/WiSnZlx72gPKH08d3z1A0hrQ5cBlQRdsx48NQm/3RygYYmTLuE00hZyfG784JXLNl1gYnWL/Fg57CmsiRZi7c5CELNoPJTtLaTWW0NSAye5e6Uf+r7w2QnwIDYluhVaWHSdy8YQhdjw/XksjRWX3BaxS4PIlhgqjbYpOWs8Mo1+XFI8MEtWnhZRrcdL/u2IzjHueAlwQX4kuZNsOluW4X3PA5t7Eb/zYGpfzgnk+Y15UO6witBG3M3MwkKrKY5FJlz1PAL8Uq0Y6qnI409NCajQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UNP/8xsd42Y4uzLEw+qfcaeD29WOF8ePPFDhgfwALIE=; b=LWBVsq+zSJLfrRUQYXGvRuCm/iAdXE6wCogtePakiBC0+EZVAlBS9/T8VVr8Gad431OkfyZ4wsqUHEwUtdihjzftivkF8aIXDnq5qOW4nsR8V3vCe/yHJQkTrF6ux86LmoZFJJ9ajk5PNspUF0YDHxnSdveTw5E5/Q4Ke69GRplbEh7PyKadQoI3AbVPX5R2rQGOO1ieZmjs0hEJ8x7t7Mz65iF50AIGClZaqnkXo7ZY1WmnihzE5yHGEML/oB+YErd0qwaeZvOJxQ9GthZsOuQa4CbC3STz5Tuh7mRdEHlQGhm05loKmInz7eILQQdfbwodZQSDHUW6lF07qfkuHQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UNP/8xsd42Y4uzLEw+qfcaeD29WOF8ePPFDhgfwALIE=; b=aSjffxzJ7YSryab/xHSzaKQxNLHio5DFJUhpi3ZjIh/z41hJ4WsSVu9w/wexqqH++IuxZaON+IFO1DDyOK2Czpg2NpkovhpK1LdsyKa/v6OPWa+ti5Oq/5r+1dS8BAqKJ4Ic10BZxiIV6HmSOFXMGObzfDd2fF5gM2viWTjudVw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nPfl0Vgq5GGw5Tv/mvlQ59pc7C9+qcgkkJt6+5PNGU4g4tuU6pot05trdZhfwboHoRsUbNuvanaXfqftiCXcnsamcASpEqwrT0AxbOw1ZuSEAJXuT98FXpFsnnJIQ3wyRTufziancYAilSf9/owty7xNvk5gVI3oyS0pIw3bkknMjPS2luNcGb1SBKvLnS06RTYyqgiTW0OnTuVJKsrcHzIsJy/tqS4+gPuAG+9+IppBoDWivqqk8aatIYBPIBzL3a0CD3gpMqObkY7RLDqJ5x22QteGmg4EgEemMPgFa8a+eE+GTHIKE9W5b5ndGeW/oSzo82bc8yXYI7x51JM0yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UNP/8xsd42Y4uzLEw+qfcaeD29WOF8ePPFDhgfwALIE=; b=QtYy6a8wBlTU3gdfpnGqNnKK46dS9QEwejC1bTNvA4X8r5BoVhitceApf/g+ebGG4VFnELl7bQxJECjCnrxGkwznh7zp6G0ba5RqU9gKkoe5Jy/K7EOH5N5rRs8jM1mINoFND64xrBjbEz2T/bZTVmI3LBQ256u8NdJrbxEGnLxxTCNLl6QvGTpQaHZtucs8qNbAEA4PCAV2O5k0lOd/nTuh7F5u5xnP8FisgrmOx4mmvBWoIwa4ujlVhQ7mXYvuaO7iuPLHE25JTNQWEEkY3FEEFexcltLxRF1Z7s2HWBMeaYsQ0ZwC9e/HVapDxQQIj5qBJDgO0V5xG8jjp2FNAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UNP/8xsd42Y4uzLEw+qfcaeD29WOF8ePPFDhgfwALIE=; b=aSjffxzJ7YSryab/xHSzaKQxNLHio5DFJUhpi3ZjIh/z41hJ4WsSVu9w/wexqqH++IuxZaON+IFO1DDyOK2Czpg2NpkovhpK1LdsyKa/v6OPWa+ti5Oq/5r+1dS8BAqKJ4Ic10BZxiIV6HmSOFXMGObzfDd2fF5gM2viWTjudVw= From: Henry Wang To: Christian Lindig , Edwin Torok , Julien Grall CC: "xen-devel@lists.xenproject.org" , David Scott , Wei Liu , Anthony Perard Subject: RE: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs Thread-Index: AQHY84e5FV9zwZ/cMEqESsIC5Hbn0K41MEgAgACxXpCAAfedgIAACnbggAALiACAAAGC4A== Date: Thu, 10 Nov 2022 10:10:22 +0000 Message-ID: References: <16f52592270e36670947fbcbe1e4d91f1daf9823.1667920496.git.edvin.torok@citrix.com> <4baa6580-a779-f1e4-b504-59895fa97309@xen.org> <5ED80DE2-1AE6-4C56-8C05-E83162EBE534@citrix.com> In-Reply-To: <5ED80DE2-1AE6-4C56-8C05-E83162EBE534@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: CE70FE9CA5E30342A78B968D84B773C2.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|GV1PR08MB8353:EE_|VI1EUR03FT017:EE_|AM7PR08MB5319:EE_ X-MS-Office365-Filtering-Correlation-Id: 8cbff7df-0710-412d-2b03-08dac303cc93 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: a3eHN+tBmYSIS6XD3MZr01xtx6/5goKh9g/UaKdmSUSmh+tSq3mNUNuNWmQrrd+MVn+mSbFyjTgazaYcTja77N7I/cDkjSlMKAASVD/JlMFuQc77ueJsMDpO691zXOmmQ0d7fcOYf8s1GzKb79WCxzhNEQY2maYg9dupwOstAh/sC9v8oxxov4kx5gBBAz2Md9VagR1yg2D94jIILK54Og86829JW+NAYVZlG9aLQmp756DY/WDZJNVpEHtH/XBvarwDeV75Cd5HfT06I37MFhXPOrcT/Se9ZmEqXK9WugDLFB6nhCIMvK4dCy99nY7FMaQiUKn3adAXOlMwucra0k//L2s7JdTbZ0FPzbRIGzGvhoLtVpZRh/j8Qqd+aKbkGBGHmT4LtNiBIwJnEiV+W4JLlTriCOCFXwia4BYHa3lS4pxf/OrPzrtXabujfMqk4vjXTzejIRHz6YdDJcxMqEq5H6DfMiw+uwyewtF5YQ4ywVJUqkkaXKwC/YOuYTSWKZVlVFqWEwhHgey03+gBJZm9vJ9bdD1uOs3LxS8hPlfrtmzjLYH5U6TKDgsFtUxz0yE2r7TVtkQ0ILiZfnh6SVfYX8uMFNGFFok/Pa0sPvqOP/c1tGyMbDuzOkk0mZG3Ozz+2Bdt28yjPq2ctsoZx6vt4F9ngFv0hjNHe9+l53CvFdmNqz561SkOoCgpihLq19cqLWuDw73m963RS17AIWev+kjsQ6BLZgvJhzSpCynpNHwtrWcZTSXXHOaC0xHasnsOFYHAhMsWuFZ5/AjSYA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(376002)(136003)(396003)(39860400002)(451199015)(9686003)(53546011)(83380400001)(186003)(26005)(38100700002)(122000001)(66556008)(6506007)(5660300002)(2906002)(55016003)(7696005)(71200400001)(41300700001)(110136005)(54906003)(478600001)(4326008)(76116006)(52536014)(66946007)(316002)(66476007)(66446008)(64756008)(8676002)(8936002)(33656002)(38070700005)(86362001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8353 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c62a52aa-cc7e-4ac5-8ca4-08dac303c73d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yMMMybz/HSwcKQoiLMvS3uxC/cY0Hh9jniT0Ge8Rp3kfcjdQ+aMS5NDi4S5xzmsZ38BwPHMzX9URKKy16VDHoK+zqtTIui1ukFnTEsijSVjNbxLNOotPH/O4sOfsW9W2IvuPDiMTpKXXcpw+YUucJPYuyM9AGdgvVIfZ0NMKM3AKxrFoV96wFEkrlAuAk1SP7vHrs8Bg2howsyzpF1hqJoZPTB+MaS8bpwsD48UmC8eQsKZueiL0lhvo6Lyw6Sax7cs3+bSHyPBCKHJPiiVRwQrXCLYx8kQpLcOBdWS772bQk2WR/x1xne16QLWCDMyI0k5jUiA/EMqs3dtjsiNRd5ee2pEMcRCQdUyYqFz2OAS8L77PN0/OAShnYO2BrSFZOTK2GZVfwy75+w1AWCt33mwTNWSp14G2psnZqrPZYqiMzmPGOLZ0ENAYwETuotLS7flKGM0nZhc6lo4k/PwzcwY7cvev4nU/jBNiF87SsXwUHhAtV+QvZSAfAqDCsC55USFvGAV551U7nZWOp3RGKmgx5tEGYaCPrZGvVEFfjAMbpluVy4xFOcWUbftGL5TQfXGKjnJJ6mpVmzhJO28KSz36KI4wYhVIAazIwoz0Wpegb6cXVEWj+yxx/Wgb17As+oghNp89sQSy5wDruUoBeL5c9LAFJCQDcPfK4D6WjpQG79ZpHKLhKFhgw0xa2c07lWoR8qbXILrPCEs7+TKMm0UMQ2QwdzomgTynVmROCzEudddj2T/O5laFMJAZo5zqVVdjOsAVcm4X8bsRfk2BdA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199015)(36840700001)(40470700004)(46966006)(9686003)(82310400005)(2906002)(86362001)(33656002)(356005)(40460700003)(82740400003)(81166007)(478600001)(107886003)(26005)(316002)(7696005)(53546011)(6506007)(70206006)(54906003)(4326008)(8676002)(110136005)(55016003)(40480700001)(8936002)(70586007)(5660300002)(36860700001)(41300700001)(186003)(336012)(47076005)(52536014)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 10:10:30.9767 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8cbff7df-0710-412d-2b03-08dac303cc93 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5319 SGkgQ2hyaXN0aWFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IENo cmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4NCj4gU3ViamVjdDog UmU6IFtQQVRDSCBmb3ItNC4xNyB2MyAwNy8xNV0gQ09ESU5HX1NUWUxFKHRvb2xzL29jYW1sKTog YWRkDQo+ICdtYWtlIGZvcm1hdCcgYW5kIHJlbW92ZSB0YWJzDQo+ID4gT24gMTAgTm92IDIwMjIs IGF0IDA5OjI1LCBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+IHdyb3RlOg0KPiA+DQo+ ID4gSGkgQ2hyaXN0aWFuLA0KPiA+DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ ID4+IEZyb206IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4N Cj4gPj4gU3ViamVjdDogUmU6IFtQQVRDSCBmb3ItNC4xNyB2MyAwNy8xNV0gQ09ESU5HX1NUWUxF KHRvb2xzL29jYW1sKTogYWRkDQo+ID4+ICdtYWtlIGZvcm1hdCcgYW5kIHJlbW92ZSB0YWJzDQo+ ID4+Pj4gV2hpbGUgSSB1bmRlcnN0YW5kIHRoZSBnb2FsIGFuZCBzdXBwb3J0LCB0aGlzIHNlZW1z IHRvIGJlIGEgYml0IHRvbyBsYXRlDQo+ID4+Pj4gdG8gZG8gaXQgaW4gWGVuIDQuMTcgKHdlIGFy ZSBvbmx5IGEgY291cGxlIG9mIHdlZWtzIGF3YXkpLiBBdCB0aGlzIHN0YWdlDQo+ID4+Pj4gb2Yg dGhlIHJlbGVhc2Ugd2Ugc2hvdWxkIG9ubHkgZG8gYnVnIGZpeC4NCj4gPj4+Pg0KPiA+Pj4+IFRo aXMgaXMgY2xlYXJseSBvbmx5IGEgY29tZXNtZXRpYyBjaGFuZ2UgYW5kIHRoZXJlIEkgd291bGQg YXJndWUgdGhpcw0KPiA+Pj4+IHNob3VsZCBiZSBkZWZlcnJlZCB0byA0LjE4LiBUaGF0IHNhaWQg dGhlIGxhc3QgY2FsbCBpcyBmcm9tIHRoZSBSTS4NCj4gPj4+DQo+ID4+PiBJIGFncmVlIHdpdGgg eW91ciBwb2ludC4gSSB0aGluayBtYXliZSBkZWZlciB0aGUgcGF0Y2ggdG8gNC4xOCBpcyBiZXR0 ZXIsDQo+ID4+PiBnaXZlbiB0aGUgZGVlcCBmcmVlemUgc3RhdGUgd2UgYXJlIGN1cnJlbnRseSBp bi4NCj4gPj4NCj4gPj4gSSBkaXNhZ3JlZS4gVGhpcyBpcyBhbiBhdXRvbWF0ZWQgY2hhbmdlIHRo YXQgY2FuIGJlIHZlcmlmaWVkIHRvIG5vdCBhZGQNCj4gPj4gZnVuY3Rpb25hbCBjaGFuZ2VzLiBF ZHZpbiBoYXMgZGVtb25zdHJhdGVkIHRoYXQgd3JvbmcgaW5kZW50YXRpb24gaGFzDQo+ID4+IG1p c2xlYWQgcmV2aWV3ZXJzIGluIHRoZSBwYXN0IGFuZCBjYXVzZWQgYnVncy4gTm9ib2R5IGV4Y2Vw dCBFZHZpbiBoYXMNCj4gPj4gY29udHJpYnV0ZWQgdG8gdGhlIGFmZmVjdGVkIGNvZGUgaW4geWVh cnMgYW5kIHRodXMgaXQgaXMgbm90IGEgYnVyZGVuIG9uDQo+IHRoZQ0KPiA+PiBwcm9qZWN0IG91 dHNpZGUgdGhlIE9DYW1sIHBhcnQuIEkgc3VnZ2VzdCB0byBhY2NlcHQgdGhpcy4NCj4gPg0KPiA+ IEkgdW5kZXJzdGFuZCBwb2ludHMgZnJvbSB5b3UsIEVkd2luIGFuZCBKdWxpZW4sIGJ1dCBJIHRo aW5rIGluIHRoZSBlYXJsaWVyDQo+ID4gZGlzY3Vzc2lvbiBpbiB0aGlzIHRocmVhZCwgSnVsaWVu IGhhcyBwcm92aWRlZCBhbiBhcmd1bWVudCBbMV0gd2hpY2ggSSBkbw0KPiA+IHRoaW5rIGlzIGEg dmFsaWQgcmVhc29uIHRvIGRlZmVyIHRoaXMgcGF0Y2ggYSBsaXR0bGUgYml0Lg0KPiA+DQo+ID4g QnV0IHNpbmNlIHlvdSBhcmUgdGhlIG9ubHkgbWFpbnRhaW5lciBvZiB0aGUgT2NhbWwgY29kZSwg c28gaWYgeW91IHN0cm9uZ2x5DQo+ID4gaW5zaXN0IHRoaXMgcGF0Y2ggc2hvdWxkIGJlIGluY2x1 ZGVkIGZvciB0aGUgcmVsZWFzZSBhbmQgdGhlcmUgd291bGQgbm90IGJlDQo+ID4gYW55IG1vcmUg ZXhwbGljaXQgb2JqZWN0aW9ucyBmcm9tIG90aGVycyBpbiB0aGUgbmV4dCBjb3VwbGUgb2YgZGF5 cywgSSB0aGluayBJDQo+ID4gd2lsbCBwcm92aWRlIG15IHJlbGVhc2UtYWNrIGZvciB0aGUgcHVy cG9zZSBvZiByZXNwZWN0aW5nIG9waW5pb25zIGZyb20gdGhlDQo+ID4gbWFpbnRhaW5lci4gSG9w ZSB0aGlzIHNvbHV0aW9uIHNob3VsZCBiZSBhY2NlcHRhYmxlIHRvIHlvdS4NCj4gDQo+IFRoYW5r cyBIZW5yeS4gSSB0aGluayB0aGUgYXJndW1lbnQgaGVyZSBpcyB0aGUgYmFsYW5jZSBiZXR3ZWVu IG1haW50YWluaW5nDQo+IGEgcG9saWN5IGFnYWluc3QgbGF0ZSBsYXJnZSBjaGFuZ2VzIGFuZCBp bXByb3ZpbmcgdGhlIHF1YWxpdHkgYW5kIHRoZQ0KPiByZWxpYWJpbGl0eSBvZiBmdXR1cmUgcGF0 Y2hlcyBieSB1c2luZyBtb3JlIGF1dG9tYXRpb24uIEkgYWdyZWUgdGhhdCBsYXJnZQ0KPiBmdW5j dGlvbmFsIGNoYW5nZXMgYW5kIGFueSBjaGFuZ2UgdGhhdCBjYW7igJl0IGJlIHZlcmlmaWVkIHNo b3VsZCBiZSBhdm9pZGVkDQo+IGJ1dCBJIGRvbuKAmXQgdGhpbmsgdGhpcyBjYXNlIGlzIG9uZS4g SG93ZXZlciwNCj4gSSBhbSBmaW5lIGRlZmVycmluZyB0aGUgcGF0Y2ggYmFzZWQgb24gYW4gYWdy ZWVkIHBvbGljeSBpZiB3ZSBjYW4gbWFrZSBpdCBhDQo+IHByaW9yaXR5IHRvIGdldCBpbiBpbiBz b29uLiANCg0KVGhhbmtzIGZvciB5b3VyIHVuZGVyc3RhbmRpbmcuIEkgd2lsbCB0YWtlIGEgbm90 ZSBvZiB0aGlzIHBhdGNoIGFuZCB0cnkgdG8gcGluZw0KY29tbWl0dGVycyB0byBjb21taXQgdGhp cyBwYXRjaCBhcyBzb29uIGFzIHRoZSBzdGFnaW5nIHRyZWUgZ2V0cyB1bmZyb3plbg0KYWZ0ZXIg dGhlIHJlbGVhc2UuIEluIHRoaXMgd2F5IEkgdGhpbmsgeW91ciBjb25jZXJucyBpbi4uLg0KDQo+ IEZvciBtZSB0aGlzIGlzIHBhcnQgb2YgaW1wcm92aW5nIHRoZSBPQ2FtbCBjb2RlDQo+IGJhc2Ug YW5kIHByb2plY3QgcXVhbGl0eSBieSB1c2luZyBtb3JlIGF1dG9tYXRpb24gaW4gZm9ybWF0dGlu ZyBhbmQgdGhlDQo+IGJ1aWxkIHN5c3RlbSB0aGF0IGxvd2VycyB0aGUgYmFycmllciBmb3IgY29u dHJpYnV0b3JzIHN1Y2ggdGhhdCB0aGV5IGRvbuKAmXQNCj4gaGF2ZSB0byB3b3JyeSBhYm91dCBw cm9jZWR1cmFsIGFzcGVjdHMgbGlrZSB0YWJzLCBzcGFjZXMsIGluZGVudGF0aW9uLCBvcg0KPiBi dWlsZCBzeXN0ZW1zLg0KDQouLi5oZXJlIHdvdWxkIGJlIG1pbmltaXplZC4NCg0KSSBkbyB1bmRl cnN0YW5kIHlvdXIgcG9pbnRzIGFuZCBmcnVzdHJhdGlvbi4gVGhhbmtzIGFnYWluIGZvciB5b3Vy DQp1bmRlcnN0YW5kaW5nLg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiDigJQgQw0K From xen-devel-bounces@lists.xenproject.org Thu Nov 10 10:42:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 10:42:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441761.695812 (Exim 4.92) (envelope-from ) id 1ot50s-0007Ie-Dt; Thu, 10 Nov 2022 10:42:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441761.695812; Thu, 10 Nov 2022 10:42:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot50s-0007IX-B9; Thu, 10 Nov 2022 10:42:26 +0000 Received: by outflank-mailman (input) for mailman id 441761; Thu, 10 Nov 2022 10:42:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot50q-0007IR-E8 for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 10:42:24 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2076.outbound.protection.outlook.com [40.107.92.76]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5ab5b1fd-60e4-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 11:42:21 +0100 (CET) Received: from CY5PR17CA0052.namprd17.prod.outlook.com (2603:10b6:930:12::30) by DS0PR12MB6461.namprd12.prod.outlook.com (2603:10b6:8:c7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Thu, 10 Nov 2022 10:42:18 +0000 Received: from CY4PEPF0000B8EA.namprd05.prod.outlook.com (2603:10b6:930:12:cafe::fc) by CY5PR17CA0052.outlook.office365.com (2603:10b6:930:12::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Thu, 10 Nov 2022 10:42:18 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000B8EA.mail.protection.outlook.com (10.167.241.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.11 via Frontend Transport; Thu, 10 Nov 2022 10:42:17 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 10 Nov 2022 04:42:17 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Thu, 10 Nov 2022 04:42:16 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ab5b1fd-60e4-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cp882Mgrg18cj46MZeMmVLuDGMOpXZ5fQaCp87ky+BdGrgTx0vGuRp1ooNowrgFhhTsemC2focEgZo9pKRUbg/SbnJTE/cn5nYwGBGOU0/NgUzXHXIhLLxDM+OlpAclZxOVoC7t/LhucKMRbBBEu0Z7Mdszv/qQDpQpv6A6SZtADvIRnspLFvNy/9oE3W9PBGwuumU0EKERHsIjU0sFHgXLUgApxijjHfzZDOysxw6SLKa0Et9z1Os68VJOntLIlacHEwO8RONxnov+J1srbTS+jN0xQwCubM5l7bS+mE4libtkK/bCkGYDUdm1SXaLOB3VEXXLeKbEmC7uEJ7gQRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+wpK/MZduZEZ5kc8kxQotTlW3ZytiACOd0D/Vt6r81U=; b=O7psCbXVYeGBZHlPshzFTFOlJg5z6UfASFpuaopn0sYmRlm6Wpk12MUvEbWjHVYBmSD6mn/DZ9T0g+vdfHt5g5C/5jJGfh5FxW8paPT7PqsRaBA3PxpJ/9v6IqQ4BLCn9eC97gcynMvNyL6mEB0CukObnZURynmQYVQJhesMWDB+fH2UfyS8Bq4eoAm4CNrXDVKReqfQiON8VgHBV+RNI5WsqjZXsHwc3X1ojzuxcowrLeh2Q9hX/RuEUWdqs2l9R+Is/qKttcl8jViTwzB+Myis3pxmssdy4D3u9IQ7FXPzEDcQh5pYYDm9LySriNir3XnurQ1kf/Dvm38ghk8mow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+wpK/MZduZEZ5kc8kxQotTlW3ZytiACOd0D/Vt6r81U=; b=HjzCQMjB0br7P8522q6DmMmw2kGBCoUAmMq6vQGuRnwJouLZz58XK3mvgfb1clMs7oAA0CL3H3+ZWxammlbEECEA+/XL0niyA54sgUy02esjUpVLaOYkMK9iid+KjZaOY0OcFFyPEvhcTdsL0PUAPZvrm4z7+SW2sG97c/XI1Wg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <4e486399-8e17-9663-d29a-6edad331d84a@amd.com> Date: Thu, 10 Nov 2022 11:42:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 0/4] Yocto Gitlab CI Content-Language: en-US To: Bertrand Marquis CC: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Doug Goldstein References: <1220596a-4fe7-5c08-5437-fa98eb14254c@amd.com> <6ee0706b-d1b3-187a-1557-c4b8173c6e37@amd.com> <46c0e05f-47e1-39e6-d978-9f6c7d6db53a@amd.com> <1C829AF9-8DFF-47FA-8334-09A31AA9B069@arm.com> From: Michal Orzel In-Reply-To: <1C829AF9-8DFF-47FA-8334-09A31AA9B069@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EA:EE_|DS0PR12MB6461:EE_ X-MS-Office365-Filtering-Correlation-Id: 8890dc42-85e5-4015-b090-08dac3083ced X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i2Jyc2vB06db3303LYBPzL/sGQINV1X1jNF5QaUj7s2Rm/uXglhQEVILVNqajQwR/zRGWWM2f3OltAWgYUTS9MY2rhuekpb5J4PKKlXZhoX61HtohrWQFG0QETRmGCDxnqGw/SLr0gEnbT16cvqp0vFbYZdiOlhu7k7JdtlyYUeh819cDIWSVKFag8aJsZ5gRX8TNYL4Ti3+a9CcMGfmBageJl90AUaOsNtOZ5oj54nMXXXoD/co58R9wjV+03sVDL3wlj1VvEgAmedglYbFdYWdoTxdeOyg0rpf9Gj7Oz4o8vcn02HPmaywwtkczpKEg68EvRR7ypNbCx9dOtw0M9lT6kVPok8W2dr5VQidaQEhUR+T5GUochrGM2c8UIu14FxfPT+/PVV550IbWDQzymG5MSUiqo38v7KH49nZpsjKEuMfeAzKfG7s4fYG78GhDJbOn33LgKPJB89NxEisOWnZquWYAFv7RuhUj4TIfme3tV2ZYajnHTMMVxf1hcoQqQlw7tjT2Hv2X/FGGKSS5FrkHTZq7de5UMwebnCEFrLUWaVYhiXRsAtK55xhSb5oEaxvn2d9B3C3nyvIcOwk4y/EnlqovGa07F2e5uBaN/4ctADEJ+BhYpDNntO06m68Flhsrl/YtNs/jWrFL/djJ42AGGFJ+9cF3bWf9mFZtYvMxuJvXMI0x44+AXLB8+hMiU2D4Wzk9cHxiT04rNRAc9wk4nUf/IWp+I6s/DMfr7UBe4cIjt7Xg9woYA3REoITh2CFuxMpLr5M5xHFCXhQfqeHnASqlhEtvMxP9E4M/ETgcEkGkS1eRPatqGZb6IaQcU0JfLa9eXMxhbmu/rBJb83WhZHvIbu+fquQmva+u35n6RYOh55fTiQejDi6QIy7 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199015)(36840700001)(40470700004)(46966006)(44832011)(966005)(70206006)(41300700001)(8676002)(6916009)(70586007)(54906003)(16576012)(53546011)(316002)(4326008)(40480700001)(8936002)(5660300002)(45080400002)(478600001)(36860700001)(47076005)(2906002)(36756003)(82740400003)(81166007)(26005)(31696002)(336012)(40460700003)(426003)(186003)(83380400001)(86362001)(356005)(2616005)(31686004)(82310400005)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 10:42:17.4617 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8890dc42-85e5-4015-b090-08dac3083ced X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000B8EA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6461 Hello, On 10/11/2022 11:08, Bertrand Marquis wrote: > > > Hi Michal, > >> On 10 Nov 2022, at 07:34, Michal Orzel wrote: >> >> Hi Stefano, >> >> On 10/11/2022 01:18, Stefano Stabellini wrote: >>> >>> >>> On Mon, 7 Nov 2022, Michal Orzel wrote: >>>> Hi Bertrand and Stefano, >>>> >>>> On 31/10/2022 16:00, Bertrand Marquis wrote: >>>>> >>>>> >>>>> Hi Michal, >>>>> >>>>>> On 31 Oct 2022, at 14:39, Michal Orzel wrote: >>>>>> >>>>>> Hi Bertrand, >>>>>> >>>>>> On 31/10/2022 15:00, Bertrand Marquis wrote: >>>>>>> >>>>>>> >>>>>>> This patch series is a first attempt to check if we could use Yocto in >>>>>>> gitlab ci to build and run xen on qemu for arm, arm64 and x86. >>>>>>> >>>>>>> The first patch is creating a container with all elements required to >>>>>>> build Yocto, a checkout of the yocto layers required and an helper >>>>>>> script to build and run xen on qemu with yocto. >>>>>>> >>>>>>> The second patch is creating containers with a first build of yocto done >>>>>>> so that susbsequent build with those containers would only rebuild what >>>>>>> was changed and take the rest from the cache. >>>>>>> >>>>>>> The third patch is adding a way to easily clean locally created >>>>>>> containers. >>>>>>> >>>>>>> This is is mainly for discussion and sharing as there are still some >>>>>>> issues/problem to solve: >>>>>>> - building the qemu* containers can take several hours depending on the >>>>>>> network bandwith and computing power of the machine where those are >>>>>>> created >>>>>> This is not really an issue as the build of the containers occurs on the local >>>>>> machines before pushing them to registry. Also, building the containers >>>>>> will only be required for new Yocto releases. >>>>>> >>>>>>> - produced containers containing the cache have a size between 8 and >>>>>>> 12GB depending on the architecture. We might need to store the build >>>>>>> cache somewhere else to reduce the size. If we choose to have one >>>>>>> single image, the needed size is around 20GB and we need up to 40GB >>>>>>> during the build, which is why I splitted them. >>>>>>> - during the build and run, we use a bit more then 20GB of disk which is >>>>>>> over the allowed size in gitlab >>>>>> As we could see during v2 testing, we do not have any space restrictions >>>>>> on the Xen GitLab and I think we already decided to have the Yocto >>>>>> integrated into our CI. >>>>> >>>>> Right, I should have modified this chapter to be coherent with your latest tests. >>>>> Sorry for that. >>>>> >>>>>> >>>>>> I will do some testing and get back to you with results + review. >>>> I did some testing and here are the results: >>>> >>>> In the current form this series will fail when running CI because the Yocto containers >>>> are based on "From ubuntu:22.04" (there is no platform prefix), which means that the containers >>>> are built for the host architecture (in my case and in 99% of the cases of the local build it will >>>> be x86). In Gitlab we have 2 runners (arm64 and x86_64). This means that all the test jobs would need >>>> to specify x86_64 as a tag when keeping the current behavior. >>>> After I built all the containers on my x86 machine, I pushed them to registry and the pipeline was successful: >>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fmorzel%2Fxen-orzelmichal%2F-%2Fpipelines%2F686853939&data=05%7C01%7Cmichal.orzel%40amd.com%7Ccc0a420856c64224e78208dac3037b95%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638036716985754450%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ARpspaYQlf7gujC11cS4dnR275cCJ6tMRC2J0FyhFIM%3D&reserved=0 >>> >>> When I tested the previous version of this series I built the >>> containers natively on ARM64, so that is also an option. >>> >>> >>>> Here is the diff on patch no. 3 to make the series work (using x86 tag and small improvement to include needs: []): >>>> ``` >>>> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml >>>> index 5c620fefce59..52cccec6f904 100644 >>>> --- a/automation/gitlab-ci/test.yaml >>>> +++ b/automation/gitlab-ci/test.yaml >>>> @@ -65,6 +65,9 @@ >>>> paths: >>>> - 'logs/*' >>>> when: always >>>> + needs: [] >>>> + tags: >>>> + - x86_64 >>>> >>>> # Test jobs >>>> build-each-commit-gcc: >>>> @@ -206,19 +209,13 @@ yocto-qemuarm64: >>>> extends: .yocto-test >>>> variables: >>>> YOCTO_BOARD: qemuarm64 >>>> - tags: >>>> - - arm64 >>>> >>>> yocto-qemuarm: >>>> extends: .yocto-test >>>> variables: >>>> YOCTO_BOARD: qemuarm >>>> - tags: >>>> - - arm32 >>>> >>>> yocto-qemux86-64: >>>> extends: .yocto-test >>>> variables: >>>> YOCTO_BOARD: qemux86-64 >>>> - tags: >>>> - - x86_64 >>>> ``` >>>> >>>> Now, the logical way would be to build x86 yocto container for x86, arm64 for arm64 and arm32 on arm64 or x86. >>>> I tried building the container qemuarm64 specifying target arm64 on x86. After 15h, only 70% of the Yocto build >>>> was completed and there was an error with glibc (the local build of the container for the host arch takes on my machine max 2h). >>>> This enormous amount of time is due to the qemu docker emulation that happens behind the scenes (I checked on 2 different machines). >>>> >>>> So we have 3 solutions: >>>> 1) Build and run these containers for/on x86_64: >>>> - local users can build the containers on local machines that are almost always x86 based, in short period of time, >>>> - "everyone" can build/push the containers once there is a new Yocto release >>>> - slightly slower CI build time >>>> 2) Build and run these containers for specific architectures: >>>> - almost no go for local users using x86 machine (unless using more than 16 threads (which I used) and willing to wait 2 days for the build) >>>> - faster CI build time (arm64 runner is faster than x86 one) >>>> - someone with arm64 based machine (not that common) would have to build and push the containers >>>> 3) Try to use CI to build and push the containers to registry >>>> - it could be possible but what about local users >>> >>> From a gitlab-ci perspective, given the runners we currently have, we >>> have to go with option 2). We don't have enough resources available on >>> the x86 runner to run the Yocto jobs on x86. >>> >> That is what I reckon too. Running the Yocto build/test on CI using x86 runner will always be slower. >> So, if we go with this solution, then the following is needed: >> 1. Modify test jobs so that yocto-qemu{arm64/arm} uses arm64 tag to be taken by arm64 runner and use tag x86_64 for yocto-qemux86-64. >> 2. Come up with a solution to build the yocto containers automatically for the above platforms + possibility to specify the platform for local users. >> Right now, these containers are being always build for the host machine platform, so without doing tricks like adding --platform or prefix to image name, >> one cannot build the Yocto containers that would be ready to be pushed to registry. We need to have a clean solution without requiring user to do tricks. >> >> The only drawback of this solution is that the person building the yocto-qemu{arm64/arm} container and willing to push it to registry, >> needs to have access to arm64 machine. > > I think we need to find a solution working for both possibilities. > And we also need a solution so that one can have both kind of images so the host machine should be encoded in the container name somehow. > >> >>> >>>> Regardless of what we chose, we need to keep in mind that the biggest advantage to the Yocto build/run is that >>>> it allows/should allow local users to perform basic testing for all the Xen supported architectures. This is because >>>> everything happens in one place with one command. >>> >>> That's right, but it should be possible to allow the Yocto containers to >>> also build and run correctly locally on x86, right? The arm/x86 tag in >>> test.yaml doesn't matter when running the containers locally anyway. > > All in all, test.yaml only matter for gitlab. > Maybe we could have it supporting both cases but only use one ? > > Cheers > Bertrand > >> >> ~Michal > I think we are trying to over engineer this problem. We want to start using it asap and this is what we should care about. If we start going into details, like adding more and more code (e.g take into consideration the fact that qemu emulation works only on x86 and what about users having arm64 machine), we will start creating a mess. CURRENT BEHAVIOR: All the containers are build for the host machine architecture. For me, it can stay as a default behavior so that all the local users can make use of it. WHAT WE WANT: The default behavior like above and the possibility to specify the platform the containers will be build for. This is so that we can build the containers for arm on x86 and use it for registry to be used by CI. RESULT: Default behavior is used by local users allowing to perform relatively quick build and test. Possibility to specify the platform is used by the person building and pushing the containers for CI runners. We do not need any duplication in containers' naming or in test.yaml test jobs. Test jobs specify tags to link the job with a proper runner and that is why the registry should only have containers built for proper runners' architectures. ~Michal From xen-devel-bounces@lists.xenproject.org Thu Nov 10 11:12:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 11:12:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441774.695839 (Exim 4.92) (envelope-from ) id 1ot5U4-0002t2-1Z; Thu, 10 Nov 2022 11:12:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441774.695839; Thu, 10 Nov 2022 11:12:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot5U3-0002sv-TQ; Thu, 10 Nov 2022 11:12:35 +0000 Received: by outflank-mailman (input) for mailman id 441774; Thu, 10 Nov 2022 11:12:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot5U2-0002sj-7U; Thu, 10 Nov 2022 11:12:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot5U2-00039e-4v; Thu, 10 Nov 2022 11:12:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot5U1-0003xn-NL; Thu, 10 Nov 2022 11:12:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ot5U1-0000vs-Kb; Thu, 10 Nov 2022 11:12:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uoE6giYUh8PKPVWpLcbC1/Cb5J8oK9wDgu5cs9pp8Mk=; b=T/RYPyjvpmijadYmu+m2pk4r6Z vAvi/LGAqbm93jtOYaL56EWZvYty9O1oaJN5CFm0/gQiAb+yReQkPFi05b6A1DiecDB2PLSg/8bZA 9NkVehDD80n1JXVVvhlvIVmiAyFeCYl1PE3O8fbIAqI16aQqKy0jBaBtEfk2VBg7c/gU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 174690: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=625efe28ab5309ab83f7826ed1de4966ede2f191 X-Osstest-Versions-That: xen=e818f4f0dabf83a6138cd77d7464495fab7bfc16 From: osstest service owner Date: Thu, 10 Nov 2022 11:12:33 +0000 flight 174690 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174690/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174572 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174572 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174572 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174572 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174572 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174572 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174572 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174572 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174572 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174572 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174572 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174572 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: xen 625efe28ab5309ab83f7826ed1de4966ede2f191 baseline version: xen e818f4f0dabf83a6138cd77d7464495fab7bfc16 Last test of basis 174572 2022-11-01 15:38:00 Z 8 days Failing since 174676 2022-11-08 18:06:57 Z 1 days 2 attempts Testing same since 174690 2022-11-09 11:46:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Dario Faggioli Jan Beulich Juergen Gross Marek Marczykowski-Górecki jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e818f4f0da..625efe28ab 625efe28ab5309ab83f7826ed1de4966ede2f191 -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Thu Nov 10 13:11:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 13:11:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441805.695863 (Exim 4.92) (envelope-from ) id 1ot7LI-00007h-0m; Thu, 10 Nov 2022 13:11:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441805.695863; Thu, 10 Nov 2022 13:11:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot7LH-00007Z-TU; Thu, 10 Nov 2022 13:11:39 +0000 Received: by outflank-mailman (input) for mailman id 441805; Thu, 10 Nov 2022 13:11:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot7LG-00007P-PL; Thu, 10 Nov 2022 13:11:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot7LG-00062s-NR; Thu, 10 Nov 2022 13:11:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot7LG-00007B-3z; Thu, 10 Nov 2022 13:11:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ot7LG-0002Ne-3R; Thu, 10 Nov 2022 13:11:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hwDBhOGx8neKcwEWbaLDJAeyzdWaUB6UwucdB5bwMJA=; b=ab3ahS3WaMZAdz0kAsVasEMeH3 thhDnaS9xuO7iUVBhR7LeB7kAd14YsHoPim9EROIc02DOjxyEmwdMrKRzduo9b2NB1ek4f0P1q8CZ SJw/kRmSPJ5DEmPFy4NDAvZefhb3NNAYjynbisVIrxZZX/zi/yvjeWRkSibUM1AAtJ9o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 174695: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=1dc6dccb1a8752f200ec2612b2bd091bbf88b231 X-Osstest-Versions-That: xen=c1e196ab490b47ce42037c2fef8184a19d96922b From: osstest service owner Date: Thu, 10 Nov 2022 13:11:38 +0000 flight 174695 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174695/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174678 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174678 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174678 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174678 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174678 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174678 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174678 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174678 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174678 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174678 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174678 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174678 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen 1dc6dccb1a8752f200ec2612b2bd091bbf88b231 baseline version: xen c1e196ab490b47ce42037c2fef8184a19d96922b Last test of basis 174678 2022-11-08 18:07:08 Z 1 days Testing same since 174695 2022-11-09 17:27:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dario Faggioli Juergen Gross Marek Marczykowski-Górecki jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c1e196ab49..1dc6dccb1a 1dc6dccb1a8752f200ec2612b2bd091bbf88b231 -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Thu Nov 10 13:21:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 13:21:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441813.695873 (Exim 4.92) (envelope-from ) id 1ot7UW-0001mV-UR; Thu, 10 Nov 2022 13:21:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441813.695873; Thu, 10 Nov 2022 13:21:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot7UW-0001mO-Rl; Thu, 10 Nov 2022 13:21:12 +0000 Received: by outflank-mailman (input) for mailman id 441813; Thu, 10 Nov 2022 13:21:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot7UV-0001mI-QG for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 13:21:11 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 855d8796-60fa-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 14:21:03 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 855d8796-60fa-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668086463; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QNXQ4RSm2+GuyrGrrLCXNJaHUednLsnWdQjBWbjUdLs=; b=G3utI71Lvyk8TD2s0horYzjemLZsF82RcaUKVB3GS2K63Ft3JY1Y6gzV 1LwEJYDhZ2VZUPKea48MHQw2wNwdYIXgpaeU5LVlyhU1ByYkMFjZqVKR8 IoBe+QN/KHxP5xPoFmP5H1RjZ7nBeSOG7a4ZJXLbwkGUdUy9/XcgwRiJY Y=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 83633734 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:CXwKhq6k/hHLnpo+qKWSUQxRtAvHchMFZxGqfqrLsTDasY5as4F+v jMfXWHQPqyONGf0c9EgPI2woBhS68DUy4BnT1NvrX0xHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkS5AeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5my +1bcTY8ZxK4tefukZSXSftwt9slM5y+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJU0UUrsUIMtWcOOAj3/jczpeuRSNqLA++WT7xw1tyrn9dtHSf7RmQO0FxRjD/ T2dowwVBDkELuaO0mSh3k7zufDdoy/5WaY4GZu3o6sCbFq7mTVIVUx+uUGAiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0UNNKH+o3wAqE0KbT7kCSAW1sZiVadNUsucsyRDor/ lyEhdXkAXpoqrL9YXec/bedqXW1IzoYKUcLYCNCRgwAi/HJrZsvlBvJQpBGGbSsk9zuMTjqx naBqy1WulkIpZdVjePhpwmB2m/y4MiSJuIo2unJdly0rVp/VYenXL6tsQn9wfVSMLeGSEbU6 RDohPOixOwJCJiMkgmET+MMAKyl6p65DdHMvbJ8N8J/rmrwohZPaagVuWgjfxkxbq7obBezO CfuVRVtCIi/1ZdARYt+eMqPBssj1sAM/vy1B6mPPrKijnWcHTJrHR2Ch2bKgQgBc2B2y8nT3 Kt3lu79ZUv28Yw9kFKLqx41iNfGBkkWnAs/v6zTwRW9yqa5b3WIU7oDO1bmRrlnsvPc+VWEq 44DbJHiJ/BjvArWO3e/zGLuBQpScShT6W7e96S7idJv0iI5QTp8Wpc9MJsqepB/nrQ9qws71 ijVZ6KZoXKh7UD6xfKiMyA9Oem0Dcog8hrW/0UEZD6V5pTqWq73hI93Snf9VeBPGDBLpRKsc 8Q4Rg== IronPort-HdrOrdr: A9a23:mLsUZKAPlCTlry3lHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/ xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U 4KSclD4bPLYmRHsQ== X-IronPort-AV: E=Sophos;i="5.96,153,1665460800"; d="scan'208";a="83633734" Date: Thu, 10 Nov 2022 13:20:47 +0000 From: Anthony PERARD To: Michal Orzel CC: Bertrand Marquis , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Doug Goldstein Subject: Re: [PATCH v3 0/4] Yocto Gitlab CI Message-ID: References: <1220596a-4fe7-5c08-5437-fa98eb14254c@amd.com> <6ee0706b-d1b3-187a-1557-c4b8173c6e37@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <6ee0706b-d1b3-187a-1557-c4b8173c6e37@amd.com> On Mon, Nov 07, 2022 at 08:50:09AM +0100, Michal Orzel wrote: > 3) Try to use CI to build and push the containers to registry > - it could be possible but what about local users FYI, it's already possible to build and push container from the CI, at least on X86, I've made it work: https://lore.kernel.org/all/20220301121133.19271-3-anthony.perard@citrix.com/ This works only when pushing to the "staging" branch on the main "xen" repo as I've added secret variable there. (Also the branch needs to be "protected" if I remember correctly.) I don't know how to use the Arm runner to do container builds like that. (The change done to one x86 runner: https://gitlab.com/xen-project/xen-gitlab-ci/-/merge_requests/15) Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 10 13:34:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 13:34:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441820.695885 (Exim 4.92) (envelope-from ) id 1ot7gq-0003RK-Vs; Thu, 10 Nov 2022 13:33:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441820.695885; Thu, 10 Nov 2022 13:33:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot7gq-0003RD-Sz; Thu, 10 Nov 2022 13:33:56 +0000 Received: by outflank-mailman (input) for mailman id 441820; Thu, 10 Nov 2022 13:33:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot7gp-0003R7-AW for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 13:33:55 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 507fd798-60fc-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 14:33:53 +0100 (CET) Received: from mail-bn7nam10lp2104.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Nov 2022 08:33:45 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA2PR03MB5819.namprd03.prod.outlook.com (2603:10b6:806:113::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Thu, 10 Nov 2022 13:33:43 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.025; Thu, 10 Nov 2022 13:33:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 507fd798-60fc-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668087233; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=IyoEvG2Wg2e5n+UsLlMWKTVh6rIPFbab2153GGZp9rg=; b=fKxJihlk6dH531VXLFX1llIZp9d8ZtMnngcHA3p47DwwE1AA2zR9Rno5 7/SKnI9cEGA+8+Aq1A1NDnvGEOoLJP5os7wjAoiy2YEtJ+sVwDDCz/GW7 Yel0us6R9q5kF6jr4FNsEnYB0NKZx3/El/DZQ/UHi31jxef8EXQ1p9kEr 4=; X-IronPort-RemoteIP: 104.47.70.104 X-IronPort-MID: 84560070 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:I7B7uaLoiU6egehcFE+RzpUlxSXFcZb7ZxGr2PjKsXjdYENS1zwEn DFOXGyDPvvcZGT2L9wnb4nn8xtT6JGHzYVnTwVlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wVmPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5qCGxQ0 McmcgoONDSbmN2Lz4C7aMBF05FLwMnDZOvzu1lG5BSAVbMMZ8+GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VvpTGLkGSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iLw27GXxXyjMG4UPOa06PREmVjO/DUsUBANX2m0nKSEsXfrDrqzL GRRoELCt5Ma8E2tU8m4XBCipnOAlgATVsAWEOAg7gyJjK3O7G6xCmEaTzIHZZoss98eQT0sy 0/PntX1CDgpu7qQIVqc7LqSrDj0IyEXK2IPfi8sQg4M4t2lq4Y25jrDR8hiHOi4yNfyCRnxx SyHqG41gLB7pc4H2qq88FzKqyihqpjAUkg+4QC/dmes9AB2fom+fKSr5ELd4PIGK5yWJnGIu nQemtnY9+ADE5qNmSqOR80JHbe097CENiHRhRhkGJxJ3y+3+niiY4lLpil3IktzL9gNdTbBZ E7VpBMX5ZlPMX/sZqhyC6qzBN4t1rPIDsn+W7bfad8mSoB1fROJ+ztrIEKK3n7gig08wf8XJ 5iWa4CvAGwcBKAhyyC5L88N3Lluyi0gyGf7QZHg0w/hwbeYfGSSS7oOLB2JdO9R0U+fiADc8 tIaPc3VzRxaCbX6enOOqdJVKk0WJ38mA5yws9ZQauOIPgthHicmFuPVxrQiPYdimsy5i9v1w 510YWcAoHKXuJENAVzQApy/QNsDhapCkE8= IronPort-HdrOrdr: A9a23:b1ezQ66VjEGx9hx/wgPXwSeBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HjBEDmewKlyXcV2/hpAV7GZmXbUQSTXeVfBOfZowEIeBeOi9K1q5 0QFJSWYeeYZTYasS+T2njDLz9K+qjjzEnHv5a88587JjsaEJ2Ioj0JfjqzIwlTfk1rFJA5HJ 2T6o5uoCehQ20eaoCeCmMeV+bOitXXnNa+CCR2cSIP2U2rt3eF+bT6Gx+X0lM3VC5O+64r9S zgnxbi7quunvmnwlv31nPV7b5RhNz9o+Ezc/Cku4wwEHHBmwyobINuV/mruy00mvim7BIQnN zFs34bTrdOwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpOCfx2g4FhpVRwa hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvGrf2UIUh4bD3wXklX6vpREnBmc4a+a hVfYnhDc9tAB6nhyuzhBgv/DSuNk5DbituDHJy+vB96AIm4kyR/3FouPD3oU1wi67VM6M0gd gsEp4Y5o2mHfVmGJ5VNaMmffadLFDrbFblDF+ySG6XZZ3vfUi94qLK3A== X-IronPort-AV: E=Sophos;i="5.96,153,1665460800"; d="scan'208";a="84560070" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JF1EcmabSMYcK2N3bfpBwoN1XHD2XSeb6kId634wkNO4EHC0xs4Rj3G6DULN3l5Ne+vDKRWEIsqDwQ3vONa0KVdvRyL2XFYI8izkygefXHhl0pbedDz9vQIfbyVoLW+2pW1GcXYAIiFCuSzUCwuYLLrm2hhSdP+GXIODtNXLJE9nTbN/8G1QixTECXyTxDcvTT01qDuUHRFNiz/dz93cmYtS/9r15WvPcd0ga0u9lbeosKV3BAXQgGfWi98+7tQdkFPzetI7F2o5sa2ACbgZJ9o3kFHigLTTs3Rc+krcA4EInBJ+m1IcM/M89qrfA3Te02rVX/PBPaeFpiVhaPGi4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dzqqmd9ZAYBFPAQ7LVpanx8nD/Gwxq7UiI84XX0ieBo=; b=OVv27C0AMKFuKRleORmG59j5CefvLFRtCInZBxe5GWuextJR7Ayu8w076yhF8gLtGTFouiKOKsiwKIdB8cPe4uIPIWCG7AfPkrGHlYiWBmx/Ddyz0KTrAzcPBUQSaTnO5V0jsNld/vO1ILjjSuuzxTKGUaLXLjLG7Tn44Gip8BrXn85Za775TayW42+PkoC2I7zupNSXDoou+w4i2bGbjQg4HZFZaVhoUTlv5LZXDkeK7UMfsYFM+9OP6cr7hwDJ+r0oH2jfHANVLGpvsb1dZPtjNJ0vHpaErhIbUeW3ZsEje1WXsfbYdWMsdQKq5ltzBuxMF1KNyTacCgA3NEK+qA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dzqqmd9ZAYBFPAQ7LVpanx8nD/Gwxq7UiI84XX0ieBo=; b=HnY/ACftCbXdWQQmJFRiN5KyyEbEd1QJQee2rXml56gzN3MELdtLqmpBnnYuopmsJv9IDvFrDZeUvtLN0Nb1xhCqXOz/8F/OtnSjiiWSjsULAovCH8DIfUVJeaQwfglpowJ0hIWkedwtB2T1sCPLaO3FXOAVdCQvrzcZqQKspR0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: linux-kernel@vger.kernel.org Cc: Roger Pau Monne , "David E . Box" , Rajneesh Bhardwaj , David E Box , Hans de Goede , Mark Gross , Andy Shevchenko , Srinivas Pandruvada , Juergen Gross , platform-driver-x86@vger.kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v2] platform/x86: don't unconditionally attach Intel PMC when virtualized Date: Thu, 10 Nov 2022 14:33:35 +0100 Message-Id: <20221110133335.78442-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0050.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1::14) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA2PR03MB5819:EE_ X-MS-Office365-Filtering-Correlation-Id: 1986a632-e536-4eb5-c802-08dac3202f7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: spL8Fdc+a1fLZywELToiFvlhtLyOGiYl06PODCz3g4wUvBm9UyGuzYgt/qa5Ph807GQ/V8VR8In2x2QxgoYEbFBK+aYb4AcfF8FHGfceziCrOLC+2tmtJJsuiyTavLjLdJCbC4k3sijyQSaY7LA3pCDWSWA554FxsQr+TdNzu3L+uCpzG7Q2Zf6QTIqiWLZC4oQ4jvkUeU6K9gZFvVQ33L/XScMoNmrVzXJPfcMa3yVwMmGAN+eXpcbD/9rYwfCnr9va26EdBp1hfmXB/D5PFimDiy2NVT7MC+cAH72vGNjmgR6B6FqllWnud/DdDN6XK6ltrdrKifc8qYqs0WAZwiY77grcEM8wMolVWtMID5f6ZU2QdcLr2Io3ERX9TOe6ZIa6X4kGJWFxq3OcukmaRFyiYYk70USXPuodu3L0Z77Wc5BC1Op8uJaUhHcAIFr2/vGkJy1WtJ2+lyamOZRQseLK00a22qEKhrKdi1TCSWyX0/RJ8YwXORkHmraekmxjtsp3d6dA3iJKqXnbL2VqaArir33RbVvmWU9gZysZxfwRPrZMTTdZZZxRuztv+tAtA4fu9/95cXPKDqcH5KBU0N5WGr75PGBriToEExxBfj40s4c6pXQfQdKkrcNH8GB9i1NFCCjYQYBvebVYBf9ok0Oygeh8J1lUOfUHb6ClOaoKeHNP2cFQ6Nv8bTEZLvGlOkniX4rAQWrgJ07AjNuxDA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199015)(86362001)(316002)(66946007)(8676002)(66556008)(66476007)(4326008)(82960400001)(38100700002)(36756003)(6666004)(83380400001)(2616005)(6506007)(186003)(26005)(6512007)(1076003)(478600001)(6486002)(8936002)(41300700001)(6916009)(2906002)(5660300002)(54906003)(7416002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T21pdmhiOGtveUZPOEFET1krUkJUOFprdHhweGVqdHJ6VXNLck5PQXhCT3d5?= =?utf-8?B?emhEUS9jMTJrVms4M1U3ZGJyb2RZRXhXYUwzSWJaVjE5MTZSS0tMK1lrK3VQ?= =?utf-8?B?WFVPMFRTU0pDdWpMQ1J6UlpJVWZ3QjhSd05uN2RBcnBFZG03SEl2Q1RDbmJx?= =?utf-8?B?RXpCRE9hQ2tGdkR3TC9IRksxSExzVnVhZFU5a3N1SHpiL2lLNTVrNnU5TS8v?= =?utf-8?B?NWc5amNCNEtxZWFEa3Z3b1N2VEtEVWxlOExDTk1jM1lPNDNuMmpXNVVtUng4?= =?utf-8?B?T0lPajlTdEhjZ0dDUWNWb2xvTFd1RFJLcVZiMldNR0drTXJ1bnZNcUZCT1No?= =?utf-8?B?TmV6ZHpXZ2U0U2h5UDdmQndFZytQclFlaFd0TUVVc2F4SVg3MVNjU0xycUNv?= =?utf-8?B?Qy9HSWttODFZdStYNVNsaVJiem1IbzA3TGx5ZzVZVnFyWUZlbml5YVlMcm96?= =?utf-8?B?Z2FEL2VVRFRiQUVUMWMxV2tyQytULzVRUHcwcG9oOWxSTWQyejlWcExGeXg5?= =?utf-8?B?ZEFBaFJpVm56dG9XcUNyOEtKTElkVUZXVjVIejMyTjhDOWp0R1NveGtUOVpV?= =?utf-8?B?eGoxN01Td2MxVndsYkx6QW5BUEt3MnYzdDNCaDlrSFJsaHArQ21HalN4T3Ju?= =?utf-8?B?VzRULzB1dGtuNmJMNkVUdCt0bDRSV25LMVdBS1R2clUrdENtU1J1aHFPdldX?= =?utf-8?B?cTV0NDUzVml6eWtNbGJRTVJ2cHNLK3F0NCtENzd4dDRXaDhrc2RhV1FjaHlT?= =?utf-8?B?clVvVndOZStWVzJhTjR4bmtYTE9RL3FYd2VnK2tmclg1MTJVWG53dUpOczk1?= =?utf-8?B?bUhiWktseXFBUlhXeHJ6aWNvUmJLUURoUndVNWQ2WEJYaDlCUlV5WDhOM0pJ?= =?utf-8?B?VFdOTGxGWDYzMEprd3hxUUlBemZQdkZOUjdTb2V2cGFYUThibklieC9SMjNp?= =?utf-8?B?ckUzVTZ0ZURReDdvenAzVklyTkNsalZZNERDKzJudGVYYmRxUzJaR2FqT0lM?= =?utf-8?B?enFsZ3VxMENXRk1RMXZYRGpTMStUcTNkZUVDNTlNeWw3M21yU05Wc09LUndR?= =?utf-8?B?YnExY2Q1VDFBQVc2Y3B3RXlXS2c3d1VzRk1sUGhPRjVQWTB4OEhHaEFvdmto?= =?utf-8?B?K1ZKVHQwMTd3bjlPS0ZSUW9BNFI3YWpjeUJ0dXdTUHgwcUhwdkVOME8wZlFw?= =?utf-8?B?L0hpMzREYVdReG0vUzlES3ZYTFg0a3NqVGh4eGtTWkVOellvQ082WHdMSGlI?= =?utf-8?B?YUptM3cwRHUyVXQzMC9reGtmck1JUHdGRUZhcnlWVmpOVWsxVFZ3WS83TkFM?= =?utf-8?B?aGtubnREY3dTTFVsRDg0MExIVDJaNUhaTnBNdGhCU0orOUZhYUdTVllWVjNz?= =?utf-8?B?ODlhakJweitmYTh5L3AvODZDMzEyRUpTWFdoVERjQ01mNzZScGxHK0N3Ritq?= =?utf-8?B?YUQ3aVdEcjVLVjNxN0szRG1jaFgrRzEyWlFHMEF6VXpVWmpNYXhheitHendN?= =?utf-8?B?bkRVZ0wyTDNCMVo3aHdxOU9nRDFFRnU0YkJjRWZRR0EvZ04zN3pCZzZqNlVL?= =?utf-8?B?VDFzZ3lwSDUxV2ZhY1krazRtbHBNUDk5MXpzS3dqQmpFMWhEY1ZCREg4bVdG?= =?utf-8?B?dG1Gb0VBZWhEVWlId2J5ZjZGQVdPVERqcUUrT3dYRDB4SVNkTFcrVTRUOVhy?= =?utf-8?B?a3RBVG4xVlhoTnhEaFN4dlcvemxRS1JDb2hiUlJsUmRNMFl5WkxJVlBWL1JP?= =?utf-8?B?RVBBemVJajdLbG9ERStxQnJZZXdhTTc5Zi91aEczeU02ZFdxczVpeVREYzlY?= =?utf-8?B?NVhKSWVwQ1ZpdmRhZDFONnQxa2RFZ21sb3hkQlVqQUJ2SDJNRzl5QnhxUXdT?= =?utf-8?B?Um40QzFPRnc3ZlV1NVZtNzVwNlNtU0xHNTRzTThCNzUyL1dMbnhqUFI3MlZs?= =?utf-8?B?Wk95UkNzME43Y3ZwMVBYMHZpM1ZCTVN5SER1YW1NRkJHU1l6elRXRnpsVjFZ?= =?utf-8?B?N3ZBWlpPbjFtWm16T2krVzFEaEdlVVpvVTg0Z0VMVTlLZGNwZk5GbmZHZDBI?= =?utf-8?B?dnVCTTdnNXA2RTQxdHVYTk1kNlZvazlCK3d1Z3pqYVRkbHFHRExRQ0ZJcE1a?= =?utf-8?Q?CCxzJxrFPfE1e6bk7zrXRfCoP?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1986a632-e536-4eb5-c802-08dac3202f7b X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 13:33:43.2662 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BaAybgyj35Sf5+LBUOcKMGDqbDZuwC6stspApM2Y/nhnUeb2aYqUjC7u/0eJN3hn5QLj73gdJRDI8n2KNFf+bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5819 The current logic in the Intel PMC driver will forcefully attach it when detecting any CPU on the intel_pmc_core_platform_ids array, even if the matching ACPI device is not present. There's no checking in pmc_core_probe() to assert that the PMC device is present, and hence on virtualized environments the PMC device probes successfully, even if the underlying registers are not present. Previous to 21ae43570940 the driver would check for the presence of a specific PCI device, and that prevented the driver from attaching when running virtualized. Fix by only forcefully attaching the PMC device when not running virtualized. Note that virtualized platforms can still get the device to load if the appropriate ACPI device is present on the tables provided to the VM. Make an exception for the Xen initial domain, which does have full hardware access, and hence can attach to the PMC if present. Fixes: 21ae43570940 ('platform/x86: intel_pmc_core: Substitute PCI with CPUID enumeration') Signed-off-by: Roger Pau Monné Acked-by: David E. Box Cc: Rajneesh Bhardwaj Cc: David E Box Cc: Hans de Goede Cc: Mark Gross Cc: Andy Shevchenko Cc: Srinivas Pandruvada Cc: Juergen Gross Cc: platform-driver-x86@vger.kernel.org Cc: xen-devel@lists.xenproject.org --- Changes since v1: - Use cpu_feature_enabled() instead of boot_cpu_has(). --- drivers/platform/x86/intel/pmc/pltdrv.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/platform/x86/intel/pmc/pltdrv.c b/drivers/platform/x86/intel/pmc/pltdrv.c index 15ca8afdd973..4f9fe8a21d8f 100644 --- a/drivers/platform/x86/intel/pmc/pltdrv.c +++ b/drivers/platform/x86/intel/pmc/pltdrv.c @@ -18,6 +18,8 @@ #include #include +#include + static void intel_pmc_core_release(struct device *dev) { kfree(dev); @@ -53,6 +55,14 @@ static int __init pmc_core_platform_init(void) if (acpi_dev_present("INT33A1", NULL, -1)) return -ENODEV; + /* + * Skip forcefully attaching the device for VMs. Make an exception for + * Xen dom0, which does have full hardware access. + */ + if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR) && + !xen_initial_domain()) + return -ENODEV; + if (!x86_match_cpu(intel_pmc_core_platform_ids)) return -ENODEV; -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Thu Nov 10 14:21:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 14:21:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441828.695896 (Exim 4.92) (envelope-from ) id 1ot8QK-00019k-JZ; Thu, 10 Nov 2022 14:20:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441828.695896; Thu, 10 Nov 2022 14:20:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot8QK-00019d-GJ; Thu, 10 Nov 2022 14:20:56 +0000 Received: by outflank-mailman (input) for mailman id 441828; Thu, 10 Nov 2022 14:20:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot8QI-00019W-Q3 for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 14:20:55 +0000 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dea723cb-6102-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 15:20:49 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 06:20:01 -0800 Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 10 Nov 2022 06:19:58 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ot8PM-00ABIs-2K; Thu, 10 Nov 2022 16:19:56 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dea723cb-6102-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668090050; x=1699626050; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=RHhT2VxJ8li5Rw6AgHiZP5xYVQLOtbkBiRZO9kF6oZU=; b=aGLZWzFrr/EU7PTOiyNcUO/ZRXuC+SI6CzOCtorKE4U5kFfcrTuzACfv IhecmHgmbsQ1TI7QzlcuR4VoMo+u6stmDF5lyId6nDfW201f4C3uwwvR5 TF/b96Ebkvfgb14e7OdHJFlU5FTS1+0wYns/0mvVS8fEPGfG2no2rQ/DR vGgDTyYCn1SCg3eIBxptX47+GMM9SXWNVxvgPVLK7FTJWKFI6pXEM7TWq cTsLKc6S02pp2g1n/CuDFWA8pTdVIH4ZB8nLEPDH784idmbpbgEOHlxMC wyPNdPhnesCxPC15gkKBL89/4Nc7xkUj6z6HvlXZggKYnojTCOQWJnXeU w==; X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="338074349" X-IronPort-AV: E=Sophos;i="5.96,154,1665471600"; d="scan'208";a="338074349" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="742868446" X-IronPort-AV: E=Sophos;i="5.96,154,1665471600"; d="scan'208";a="742868446" Date: Thu, 10 Nov 2022 16:19:56 +0200 From: Andy Shevchenko To: Roger Pau Monne Cc: linux-kernel@vger.kernel.org, "David E . Box" , Rajneesh Bhardwaj , David E Box , Hans de Goede , Mark Gross , Srinivas Pandruvada , Juergen Gross , platform-driver-x86@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v2] platform/x86: don't unconditionally attach Intel PMC when virtualized Message-ID: References: <20221110133335.78442-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221110133335.78442-1-roger.pau@citrix.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Nov 10, 2022 at 02:33:35PM +0100, Roger Pau Monne wrote: > The current logic in the Intel PMC driver will forcefully attach it > when detecting any CPU on the intel_pmc_core_platform_ids array, > even if the matching ACPI device is not present. > > There's no checking in pmc_core_probe() to assert that the PMC device > is present, and hence on virtualized environments the PMC device > probes successfully, even if the underlying registers are not present. > Previous to 21ae43570940 the driver would check for the presence of a > specific PCI device, and that prevented the driver from attaching when > running virtualized. > > Fix by only forcefully attaching the PMC device when not running > virtualized. Note that virtualized platforms can still get the device > to load if the appropriate ACPI device is present on the tables > provided to the VM. > > Make an exception for the Xen initial domain, which does have full > hardware access, and hence can attach to the PMC if present. > > Fixes: 21ae43570940 ('platform/x86: intel_pmc_core: Substitute PCI with CPUID enumeration') > Signed-off-by: Roger Pau Monn > Acked-by: David E. Box > Cc: Rajneesh Bhardwaj > Cc: David E Box > Cc: Hans de Goede > Cc: Mark Gross > Cc: Andy Shevchenko > Cc: Srinivas Pandruvada > Cc: Juergen Gross > Cc: platform-driver-x86@vger.kernel.org > Cc: xen-devel@lists.xenproject.org You may use --cc to the sending tool, instead of polluting a commit message with that. Moreover, the Cc list will be archived on lore.kernel.org anyway, in case you really need it to be recorded. ... > + if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR) && > + !xen_initial_domain()) One line? It's 81 character only and we have no strong 80 here, IIRC. > + return -ENODEV; -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Thu Nov 10 15:25:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 15:25:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441835.695912 (Exim 4.92) (envelope-from ) id 1ot9QD-0008L2-KQ; Thu, 10 Nov 2022 15:24:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441835.695912; Thu, 10 Nov 2022 15:24:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot9QD-0008Kl-Fu; Thu, 10 Nov 2022 15:24:53 +0000 Received: by outflank-mailman (input) for mailman id 441835; Thu, 10 Nov 2022 15:24:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot9QB-0008GP-Oe for xen-devel@lists.xen.org; Thu, 10 Nov 2022 15:24:52 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cb80d08a-610b-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 16:24:44 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot9Pu-0000wW-J5; Thu, 10 Nov 2022 15:24:34 +0000 Received: from andrewcoop by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ot9Pu-000395-Gx; Thu, 10 Nov 2022 15:24:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb80d08a-610b-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=bIbi48JctWNG1MEpjsYmNRjlCgy775Rehf2KMs9C43s=; b=QZg7TAVR7weAVMEKiIsx+gtUNI TX/tSqY4VS0DosMhpJCrSw7sLuekV7o1HJLhQ4T+yKmGMDSdAbHi1p5IiORlNHCo/t0V/92AWf+gP AFosvhRcwJb+cNTy7Ft9tgiJsbUb9H0MSqmrOgjrLhJZz8jscOA7vYUj2W3AZBJAtt1c=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 422 v2 (CVE-2022-23824) - x86: Multiple speculative security issues Message-Id: Date: Thu, 10 Nov 2022 15:24:34 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-23824 / XSA-422 version 2 x86: Multiple speculative security issues UPDATES IN VERSION 2 ==================== Change the URL referenced for the Branch Type Confusion update. ISSUE DESCRIPTION ================= 1) Researchers have discovered that on some AMD CPUs, the implementation of IBPB (Indirect Branch Prediction Barrier) does not behave according to the specification. Specifically, IBPB fails to properly flush the RAS (Return Address Stack, also RSB - Return Stack Buffer - in Intel terminology; one of the hardware prediction structures), allowing attacker controlled values to survive across a deliberate attempt to purge said values. AMD have allocated CVE-2022-23824. For more details, see: https://www.amd.com/en/corporate/product-security/bulletin/amd-sb-1040 2) AMD have discovered that under some circumstances, the previous reported information about Branch Type Confusion (XSA-407 / CVE-2022-23825) was inaccurate. Specifically, it was previously reported that the small speculation window was not long enough to contain two dependent loads. It has turned out not to be true, and in some circumstances, the speculation window is long enough to contain two dependent loads. AMD have not allocated a new CVE for this issue. For more details, see: https://www.amd.com/system/files/documents/technical-guidance-for-mitigating-branch-type-confusion.pdf IMPACT ====== An attacker might be able to infer the contents of memory belonging to other guests. Due to the interaction of this issue with previous speculation fixes in their default configuration, an attacker cannot leverage this vulnerability to infer the content of memory that belongs to Xen itself. VULNERABLE SYSTEMS ================== Systems running all versions of Xen are affected. Only AMD CPUs are potentially vulnerable. CPUs from other hardware vendors are not impacted. Whether a CPU is potentially vulnerable depends on its microarchitecture. Consult your hardware vendor. The fix for XSA-407 / CVE-2022-23825 elected, out of an abundance of caution, to use IBPB-on-entry as a Branch Type Confusion mitigation. It is believed that this mitigation is still sufficient, in light of the new discoveries. Therefore, no changes are being provided at this time. For CVE-2022-23824, patches are being provided on all releases as the bug pertains to a specific speculation control not working as documented, but there are a number circumstances where safety is provided as a side effect of other speculative mitigations. * The issue is that IBPB doesn't flush the RAS (Return Address Stack). Also called the RSB (Return Stack Buffer) in Intel terminology. Xen tends to follow Intel's terminology. * By default, Xen uses IBPB on a context switch from one vCPU to another vCPU to prevent guest to guest attacks. This action is not about protecting Xen from a malicious guest; such protections are elsewhere. * By default, Xen flushes the RAS/RSB on VMExit from HVM/PVH vCPUs, in order to protect itself from a malicious vCPU. Therefore, a malicious HVM/PVH guest cannot mount an attack using this vulnerability. * Whether Xen flushes the RAS/RSB by default on exit from PV vCPUs (again, to protect itself) is more complicated. There is an optimisation commonly used by native OSes when the SMEP (Supervisor Mode Execution Prevention) feature is active, which Xen can make use in some cases. - Xen 4.15 and older flush the RAS/RSB by default. - Xen 4.16 introduced an optimisation to skip flushing the RAS/RSB when safe. For CPUs impacted by CVE-2022-23824, this comes down to whether 32-bit PV guest support is enabled or not; *irrespective* of whether any 32-bit PV guests are actively running. If Xen is built with CONFIG_PV32=n, or Xen is booted with `pv=no-32`, or 32-bit PV guests are disabled as a side effect of CET being active (requires a capable toolchain, CONFIG_XEN_SHSTK=y or CONFIG_XEN_IBT=y, and capable hardware), then Xen will by default use the performance optimisation. In this case, a malicious 64-bit PV guest can mount an attack using this issue. Note: This analysis is only applicable for systems which are fully up to date with previous speculation-related XSAs, and have not used `spec-ctrl=` on the Xen command line to tune the speculative mitigations. MITIGATION ========== If there are untrusted 64-bit PV guests on the system on a Xen 4.16 or later system, specifying `spec-ctrl=rsb` on Xen's command line and rebooting will mitigate the vulnerability. RESOLUTION ========== Applying the appropriate set of patches resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa422/xsa422-?.patch xen-unstable xsa422/xsa422-4.16-?.patch Xen 4.16.x xsa422/xsa422-4.15-?.patch Xen 4.15.x xsa422/xsa422-4.14-?.patch Xen 4.14.x xsa422/xsa422-4.13-?.patch Xen 4.13.x $ sha256sum xsa422* xsa422*/* f8722655564736c69b708a24b524fec5d351aff4ea6cc5c87dff3629561945f2 xsa422.meta c6317d66e60ec8d3c5610646bf0f12f281f000706621804f3c6072d0772fa0bd xsa422/xsa422-1.patch aeec164f676ddef2e7736d733a43a239a4cd0005e82c763b0468259891691be9 xsa422/xsa422-2.patch 0e7603b0538914b675c891c4f1a8b4de19c9ae5b03d29c314d4484338a51e780 xsa422/xsa422-4.13-1.patch 5eefa1ce66b80bfb3ac4e14c99c39c73922f5508aad798aeeecdb9e0f25c3054 xsa422/xsa422-4.13-2.patch 2051142f1131452b5ca2166736866ddc1bf06910f063cdbc3997c89f31db2760 xsa422/xsa422-4.14-1.patch 821764468805547650ce3699ee37fd14083ea70958908d31905adf5ca32302ed xsa422/xsa422-4.14-2.patch 148ec57f7c4970c2d33891a8080ef643d76d1eafa9ca77ac45a1fc1416002cf8 xsa422/xsa422-4.15-1.patch 96e5d7243438bb16aa5b3528136c06f09f18e6ac4a52230d20f9db49a85922a0 xsa422/xsa422-4.15-2.patch f02b62f32d4910ecbe3946722a5f46d65db080e2007823c5bfa5c365d243e45f xsa422/xsa422-4.16-1.patch ba3547df8576433da0b5978e3def70d9804d2ed0847ad58914b78715868657c5 xsa422/xsa422-4.16-2.patch $ -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNtFQQMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZmA4H/ieQkCh/8nKgXCr/82WPtzmN5Ia0PM1AllHtap/B 1+Vap2hJlz0fmsVPvTjUvw4VkGdS9YCiXVc4pZv7PrzWFFqhgZSDEudoDZVw5RgS t3Wnk7+VIqqQ3UFaCskRw1fS3P1YrEVTB8zQKFosQxN986+zCpsBWfpf+tnrVHgi l/GL2/Pfvm6qRbXKGZxb4gHWSSzdzWRJQTL+zVIlNwpdwGNoXFiu1eZPi7IN/ILP craqr4jpqfgKHeRSw/1TE7kyoKubqzRB9fOjaJDE4lMZvgACKbDEiKlUCd5xrtBN W0VsCS7Oc9HvgJpZH0H7iVANl2PCDu3ujq7vfG3Ey0xMMmI= =qd57 -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa422.meta" Content-Disposition: attachment; filename="xsa422.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MjIsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICI0 ZDc1M2NjZjlkZGYxMjMzMjQzNWY1MGQ4OGU4Y2YwMTYxZTdhNWIzIiwKICAg ICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsK ICAgICAgICAgICAgInhzYTQyMi94c2E0MjItNC4xMy0/LnBhdGNoIgogICAg ICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE0Ijog ewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAg ICAgIlN0YWJsZVJlZiI6ICI2MjIyYmI4YmQ3NmEwZjIxMDQ4Yzg1MmFjZDI1 NDJmYTI0OTRhOTA3IiwKICAgICAgICAgICJQcmVyZXFzIjogW10sCiAgICAg ICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQyMi94c2E0MjIt NC4xNC0/LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQog ICAgfSwKICAgICI0LjE1IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAg ICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICJlODE4ZjRmMGRh YmY4M2E2MTM4Y2Q3N2Q3NDY0NDk1ZmFiN2JmYzE2IiwKICAgICAgICAgICJQ cmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAg ICAgInhzYTQyMi94c2E0MjItNC4xNS0/LnBhdGNoIgogICAgICAgICAgXQog ICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE2IjogewogICAgICAi UmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJs ZVJlZiI6ICIxYmRkN2M0MzhiMzk5ZTJlY2NlOWUzYzcyYmQ3YzFhZTU2ZGY2 MGY4IiwKICAgICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0 Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQyMi94c2E0MjItNC4xNi0/LnBh dGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAg ICJtYXN0ZXIiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4i OiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogImU2MWE3ODk4MTM2NDkyNWE0 M2M5Y2MyNGRjNzdiNjJmZjdiOTNjOWYiLAogICAgICAgICAgIlByZXJlcXMi OiBbXSwKICAgICAgICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNh NDIyL3hzYTQyMi0/LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAg ICAgfQogICAgfQogIH0KfQ== --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-1.patch" Content-Disposition: attachment; filename="xsa422/xsa422-1.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW51bWVyYXRpb24gZm9yIElC UEJfUkVUCgpUaGUgSUJQQl9SRVQgYml0IGluZGljYXRlcyB0aGF0IHRoZSBD UFUncyBpbXBsZW1lbnRhdGlvbiBvZiBNU1JfUFJFRF9DTUQuSUJQQgpkb2Vz IGZsdXNoIHRoZSBSU0IvUkFTIHRvby4KClRoaXMgaXMgcGFydCBvZiBYU0Et NDIyIC8gQ1ZFLTIwMjItMjM4MjQuCgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcg Q29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpBY2tlZC1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBh L3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYyBiL3Rvb2xzL2xpYnMv bGlnaHQvbGlieGxfY3B1aWQuYwppbmRleCBkNWE5YjM1Nzc0NmMuLjJhYTIz MjI1ZjQyYyAxMDA2NDQKLS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9j cHVpZC5jCisrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYwpA QCAtMjkxLDYgKzI5MSw3IEBAIGludCBsaWJ4bF9jcHVpZF9wYXJzZV9jb25m aWcobGlieGxfY3B1aWRfcG9saWN5X2xpc3QgKmNwdWlkLCBjb25zdCBjaGFy KiBzdHIpCiAgICAgICAgIHsic3NiLW5vIiwgICAgICAgMHg4MDAwMDAwOCwg TkEsIENQVUlEX1JFR19FQlgsIDI2LCAgMX0sCiAgICAgICAgIHsicHNmZCIs ICAgICAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDI4LCAg MX0sCiAgICAgICAgIHsiYnRjLW5vIiwgICAgICAgMHg4MDAwMDAwOCwgTkEs IENQVUlEX1JFR19FQlgsIDI5LCAgMX0sCisgICAgICAgIHsiaWJwYi1yZXQi LCAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDMwLCAgMX0s CiAKICAgICAgICAgeyJuYyIsICAgICAgICAgICAweDgwMDAwMDA4LCBOQSwg Q1BVSURfUkVHX0VDWCwgIDAsICA4fSwKICAgICAgICAgeyJhcGljaWRzaXpl IiwgICAweDgwMDAwMDA4LCBOQSwgQ1BVSURfUkVHX0VDWCwgMTIsICA0fSwK ZGlmZiAtLWdpdCBhL3Rvb2xzL21pc2MveGVuLWNwdWlkLmMgYi90b29scy9t aXNjL3hlbi1jcHVpZC5jCmluZGV4IDM5MGFjMWRhZmVkMi4uZDU4MzNlOWNl ODc5IDEwMDY0NAotLS0gYS90b29scy9taXNjL3hlbi1jcHVpZC5jCisrKyBi L3Rvb2xzL21pc2MveGVuLWNwdWlkLmMKQEAgLTE2MSw2ICsxNjEsNyBAQCBz dGF0aWMgY29uc3QgY2hhciAqY29uc3Qgc3RyX2U4YlszMl0gPQogICAgIFsy NF0gPSAiYW1kLXNzYmQiLCAgICAgICAgIFsyNV0gPSAidmlydC1zc2JkIiwK ICAgICBbMjZdID0gInNzYi1ubyIsCiAgICAgWzI4XSA9ICJwc2ZkIiwgICAg ICAgICAgICAgWzI5XSA9ICJidGMtbm8iLAorICAgIFszMF0gPSAiaWJwYi1y ZXQiLAogfTsKIAogc3RhdGljIGNvbnN0IGNoYXIgKmNvbnN0IHN0cl83ZDBb MzJdID0KZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBi L3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwppbmRleCA0ZTUzMDU2NjI0YTgu LjBjMzUwM2M5Y2RmZSAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3NwZWNf Y3RybC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwpAQCAtNDIw LDcgKzQyMCw3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwcmludF9kZXRhaWxz KGVudW0gaW5kX3RodW5rIHRodW5rLCB1aW50NjRfdCBjYXBzKQogICAgICAq IEhhcmR3YXJlIHJlYWQtb25seSBpbmZvcm1hdGlvbiwgc3RhdGluZyBpbW11 bml0eSB0byBjZXJ0YWluIGlzc3Vlcywgb3IKICAgICAgKiBzdWdnZXN0aW9u cyBvZiB3aGljaCBtaXRpZ2F0aW9uIHRvIHVzZS4KICAgICAgKi8KLSAgICBw cmludGsoIiAgSGFyZHdhcmUgaGludHM6JXMlcyVzJXMlcyVzJXMlcyVzJXMl cyVzJXMlcyVzJXNcbiIsCisgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGhpbnRz OiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXNcbiIsCiAgICAg ICAgICAgIChjYXBzICYgQVJDSF9DQVBTX1JEQ0xfTk8pICAgICAgICAgICAg ICAgICAgICAgICAgPyAiIFJEQ0xfTk8iICAgICAgICA6ICIiLAogICAgICAg ICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19JQlJTX0FMTCkgICAgICAgICAgICAg ICAgICAgICAgID8gIiBJQlJTX0FMTCIgICAgICAgOiAiIiwKICAgICAgICAg ICAgKGNhcHMgJiBBUkNIX0NBUFNfUlNCQSkgICAgICAgICAgICAgICAgICAg ICAgICAgICA/ICIgUlNCQSIgICAgICAgICAgIDogIiIsCkBAIC00MzcsNyAr NDM3LDggQEAgc3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMoZW51 bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICAgICAg IChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX1NUSUJQX0FMV0FZ UykpICAgPyAiIFNUSUJQX0FMV0FZUyIgICA6ICIiLAogICAgICAgICAgICAo ZThiICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9JQlJTX0ZBU1QpKSAg ICAgID8gIiBJQlJTX0ZBU1QiICAgICAgOiAiIiwKICAgICAgICAgICAgKGU4 YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfSUJSU19TQU1FX01PREUp KSA/ICIgSUJSU19TQU1FX01PREUiIDogIiIsCi0gICAgICAgICAgIChlOGIg ICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0JUQ19OTykpICAgICAgICAg PyAiIEJUQ19OTyIgICAgICAgICA6ICIiKTsKKyAgICAgICAgICAgKGU4YiAg JiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfQlRDX05PKSkgICAgICAgICA/ ICIgQlRDX05PIiAgICAgICAgIDogIiIsCisgICAgICAgICAgIChlOGIgICYg Y3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0lCUEJfUkVUKSkgICAgICAgPyAi IElCUEJfUkVUIiAgICAgICA6ICIiKTsKIAogICAgIC8qIEhhcmR3YXJlIGZl YXR1cmVzIHdoaWNoIG5lZWQgZHJpdmluZyB0byBtaXRpZ2F0ZSBpc3N1ZXMu ICovCiAgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGZlYXR1cmVzOiVzJXMlcyVz JXMlcyVzJXMlcyVzJXMlc1xuIiwKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRl L3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmggYi94ZW4vaW5jbHVk ZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCmluZGV4IDQyZjQ4 YThhZTIyYy4uMDI2NzVlOWM3NTRkIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVk ZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCisrKyBiL3hlbi9p bmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmgKQEAgLTI2 OSw2ICsyNjksNyBAQCBYRU5fQ1BVRkVBVFVSRShWSVJUX1NTQkQsICAgICA4 KjMyKzI1KSAvKiEgIE1TUl9WSVJUX1NQRUNfQ1RSTC5TU0JEICovCiBYRU5f Q1BVRkVBVFVSRShTU0JfTk8sICAgICAgICA4KjMyKzI2KSAvKkEgIEhhcmR3 YXJlIG5vdCB2dWxuZXJhYmxlIHRvIFNTQiAqLwogWEVOX0NQVUZFQVRVUkUo UFNGRCwgICAgICAgICAgOCozMisyOCkgLypTICBNU1JfU1BFQ19DVFJMLlBT RkQgKi8KIFhFTl9DUFVGRUFUVVJFKEJUQ19OTywgICAgICAgIDgqMzIrMjkp IC8qQSAgSGFyZHdhcmUgbm90IHZ1bG5lcmFibGUgdG8gQnJhbmNoIFR5cGUg Q29uZnVzaW9uICovCitYRU5fQ1BVRkVBVFVSRShJQlBCX1JFVCwgICAgICA4 KjMyKzMwKSAvKkEgIElCUEIgY2xlYXJzIFJTQi9SQVMgdG9vLiAqLwogCiAv KiBJbnRlbC1kZWZpbmVkIENQVSBmZWF0dXJlcywgQ1BVSUQgbGV2ZWwgMHgw MDAwMDAwNzowLmVkeCwgd29yZCA5ICovCiBYRU5fQ1BVRkVBVFVSRShBVlg1 MTJfNFZOTklXLCA5KjMyKyAyKSAvKkEgIEFWWDUxMiBOZXVyYWwgTmV0d29y ayBJbnN0cnVjdGlvbnMgKi8K --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-2.patch" Content-Disposition: attachment; filename="xsa422/xsa422-2.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgSUJQQiBub3Qg Zmx1c2hpbmcgdGhlIFJTQi9SQVMKCkludHJvZHVjZSBzcGVjX2N0cmxfbmV3 X2d1ZXN0X2NvbnRleHQoKSB0byBlbmNhcHN1bGF0ZSBhbGwgbG9naWMgcGVy dGFpbmluZyB0bwp1c2luZyBNU1JfUFJFRF9DTUQgZm9yIGEgbmV3IGd1ZXN0 IGNvbnRleHQsIGV2ZW4gaWYgaXQgb25seSBoYXMgb25lIHVzZXIKcHJlc2Vu dGx5LgoKSW50cm9kdWNlIFg4Nl9CVUdfSUJQQl9OT19SRVQsIGFuZCB1c2Ug aXQgZXh0ZW5kIHNwZWNfY3RybF9uZXdfZ3Vlc3RfY29udGV4dCgpCndpdGgg YSBtYW51YWwgZml4dXAgZm9yIGhhcmR3YXJlIHdoaWNoIG1pcy1pbXBsZW1l bnRzIElCUEIuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQyMiAvIENWRS0yMDIy LTIzODI0LgoKU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEphbiBCZXVsaWNoIDxq YmV1bGljaEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv YXNtLW1hY3Jvcy5jIGIveGVuL2FyY2gveDg2L2FzbS1tYWNyb3MuYwppbmRl eCA3ZTUzNmIwZDgyZjUuLjg5MWQ4NmM3NjU1YyAxMDA2NDQKLS0tIGEveGVu L2FyY2gveDg2L2FzbS1tYWNyb3MuYworKysgYi94ZW4vYXJjaC94ODYvYXNt LW1hY3Jvcy5jCkBAIC0xLDIgKzEsMyBAQAogI2luY2x1ZGUgPGFzbS9hc20t ZGVmbnMuaD4KICNpbmNsdWRlIDxhc20vYWx0ZXJuYXRpdmUtYXNtLmg+Cisj aW5jbHVkZSA8YXNtL3NwZWNfY3RybF9hc20uaD4KZGlmZiAtLWdpdCBhL3hl bi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNoL3g4Ni9kb21haW4uYwpp bmRleCBjZTgyYzUwMmJiNWYuLjc5MTA3ZGFjNjkyMiAxMDA2NDQKLS0tIGEv eGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hlbi9hcmNoL3g4Ni9kb21h aW4uYwpAQCAtMjExNyw3ICsyMTE3LDcgQEAgdm9pZCBjb250ZXh0X3N3aXRj aChzdHJ1Y3QgdmNwdSAqcHJldiwgc3RydWN0IHZjcHUgKm5leHQpCiAgICAg ICAgICAgICAgKi8KICAgICAgICAgICAgIGlmICggKmxhc3RfaWQgIT0gbmV4 dF9pZCApCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgd3Jtc3Js KE1TUl9QUkVEX0NNRCwgUFJFRF9DTURfSUJQQik7CisgICAgICAgICAgICAg ICAgc3BlY19jdHJsX25ld19ndWVzdF9jb250ZXh0KCk7CiAgICAgICAgICAg ICAgICAgKmxhc3RfaWQgPSBuZXh0X2lkOwogICAgICAgICAgICAgfQogICAg ICAgICB9CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20v Y3B1ZmVhdHVyZXMuaCBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9jcHVm ZWF0dXJlcy5oCmluZGV4IDM4OTVkZTRmYWY4Zi4uYzY4Y2VkMWI4MjQ3IDEw MDY0NAotLS0gYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVhdHVy ZXMuaAorKysgYi94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVhdHVy ZXMuaApAQCAtNDksNiArNDksNyBAQCBYRU5fQ1BVRkVBVFVSRShJQlBCX0VO VFJZX0hWTSwgICAgWDg2X1NZTlRIKDI5KSkgLyogTVNSX1BSRURfQ01EIHVz ZWQgYnkgWGVuIGZvcgogI2RlZmluZSBYODZfQlVHX0ZQVV9QVFJTICAgICAg ICAgIFg4Nl9CVUcoIDApIC8qIChGKVh7U0FWRSxSU1RPUn0gZG9lc24ndCBz YXZlL3Jlc3RvcmUgRk9QL0ZJUC9GRFAuICovCiAjZGVmaW5lIFg4Nl9CVUdf TlVMTF9TRUcgICAgICAgICAgWDg2X0JVRyggMSkgLyogTlVMTC1pbmcgYSBz ZWxlY3RvciBwcmVzZXJ2ZXMgdGhlIGJhc2UgYW5kIGxpbWl0LiAqLwogI2Rl ZmluZSBYODZfQlVHX0NMRkxVU0hfTUZFTkNFICAgIFg4Nl9CVUcoIDIpIC8q IE1GRU5DRSBuZWVkZWQgdG8gc2VyaWFsaXNlIENMRkxVU0ggKi8KKyNkZWZp bmUgWDg2X0JVR19JQlBCX05PX1JFVCAgICAgICBYODZfQlVHKCAzKSAvKiBJ QlBCIGRvZXNuJ3QgZmx1c2ggdGhlIFJTQi9SQVMgKi8KIAogLyogVG90YWwg bnVtYmVyIG9mIGNhcGFiaWxpdHkgd29yZHMsIGluYyBzeW50aCBhbmQgYnVn IHdvcmRzLiAqLwogI2RlZmluZSBOQ0FQSU5UUyAoRlNDQVBJTlRTICsgWDg2 X05SX1NZTlRIICsgWDg2X05SX0JVRykgLyogTiAzMi1iaXQgd29yZHMgd29y dGggb2YgaW5mbyAqLwpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2luY2x1 ZGUvYXNtL3NwZWNfY3RybC5oIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNt L3NwZWNfY3RybC5oCmluZGV4IDk0MDNiODFkYzdhZi4uNmE3N2MzOTM3ODQ0 IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vc3BlY19j dHJsLmgKKysrIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL3NwZWNfY3Ry bC5oCkBAIC02NSw2ICs2NSwyOCBAQAogdm9pZCBpbml0X3NwZWN1bGF0aW9u X21pdGlnYXRpb25zKHZvaWQpOwogdm9pZCBzcGVjX2N0cmxfaW5pdF9kb21h aW4oc3RydWN0IGRvbWFpbiAqZCk7CiAKKy8qCisgKiBTd2l0Y2ggdG8gYSBu ZXcgZ3Vlc3QgcHJlZGljdGlvbiBjb250ZXh0LgorICoKKyAqIFRoaXMgZmx1 c2hlcyBhbGwgaW5kaXJlY3QgYnJhbmNoIHByZWRpY3RvcnMgKEJUQiwgUlNC L1JBUyksIHNvIGd1ZXN0IGNvZGUKKyAqIHdoaWNoIGhhcyBwcmV2aW91c2x5 IHJ1biBvbiB0aGlzIENQVSBjYW4ndCBhdHRhY2sgc3Vic2VxdWVudCBndWVz dCBjb2RlLgorICoKKyAqIEFzIHRoaXMgZmx1c2hlcyB0aGUgUlNCL1JBUywg aXQgZGVzdHJveXMgdGhlIHByZWRpY3Rpb25zIG9mIHRoZSBjYWxsaW5nCisg KiBjb250ZXh0LiAgRm9yIGJlc3QgcGVyZm9ybWFjZSwgYXJyYW5nZSBmb3Ig dGhpcyB0byBiZSB1c2VkIHdoZW4gd2UncmUgZ29pbmcKKyAqIHRvIGp1bXAg b3V0IG9mIHRoZSBjdXJyZW50IGNvbnRleHQsIGUuZy4gd2l0aCByZXNldF9z dGFja19hbmRfanVtcCgpLgorICoKKyAqIEZvciBoYXJkd2FyZSB3aGljaCBt aXMtaW1wbGVtZW50cyBJQlBCLCBmaXggdXAgYnkgZmx1c2hpbmcgdGhlIFJT Qi9SQVMKKyAqIG1hbnVhbGx5LgorICovCitzdGF0aWMgYWx3YXlzX2lubGlu ZSB2b2lkIHNwZWNfY3RybF9uZXdfZ3Vlc3RfY29udGV4dCh2b2lkKQorewor ICAgIHdybXNybChNU1JfUFJFRF9DTUQsIFBSRURfQ01EX0lCUEIpOworCisg ICAgLyogKGFiKXVzZSBhbHRlcm5hdGl2ZV9pbnB1dCgpIHRvIHNwZWNpZnkg Y2xvYmJlcnMuICovCisgICAgYWx0ZXJuYXRpdmVfaW5wdXQoIiIsICJET19P VkVSV1JJVEVfUlNCIiwgWDg2X0JVR19JQlBCX05PX1JFVCwKKyAgICAgICAg ICAgICAgICAgICAgICA6ICJyYXgiLCAicmN4Iik7Cit9CisKIGV4dGVybiBp bnQ4X3Qgb3B0X2licGJfY3R4dF9zd2l0Y2g7CiBleHRlcm4gYm9vbCBvcHRf c3NiZDsKIGV4dGVybiBpbnQ4X3Qgb3B0X2VhZ2VyX2ZwdTsKZGlmZiAtLWdp dCBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBiL3hlbi9hcmNoL3g4Ni9z cGVjX2N0cmwuYwppbmRleCAwYzM1MDNjOWNkZmUuLmEwODM1MTQzZTM3YyAx MDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCisrKyBiL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwpAQCAtODExLDYgKzgxMSwxNCBAQCBz dGF0aWMgdm9pZCBfX2luaXQgaWJwYl9jYWxjdWxhdGlvbnModm9pZCkKICAg ICB9CiAKICAgICAvKgorICAgICAqIEFNRC9IeWdvbiBDUFVzIHRvIGRhdGUg KEp1bmUgMjAyMikgZG9uJ3QgZmx1c2ggdGhlIHRoZSBSQVMuICBGdXR1cmUK KyAgICAgKiBDUFVzIGFyZSBleHBlY3RlZCB0byBlbnVtZXJhdGUgSUJQQl9S RVQgd2hlbiB0aGlzIGhhcyBiZWVuIGZpeGVkLgorICAgICAqIFVudGlsIHRo ZW4sIGNvdmVyIHRoZSBkaWZmZXJlbmNlIHdpdGggdGhlIHNvZnR3YXJlIHNl cXVlbmNlLgorICAgICAqLworICAgIGlmICggYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX0lCUEIpICYmICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJQ Ql9SRVQpICkKKyAgICAgICAgc2V0dXBfZm9yY2VfY3B1X2NhcChYODZfQlVH X0lCUEJfTk9fUkVUKTsKKworICAgIC8qCiAgICAgICogSUJQQi1vbi1lbnRy eSBtaXRpZ2F0aW9ucyBmb3IgQnJhbmNoIFR5cGUgQ29uZnVzaW9uLgogICAg ICAqCiAgICAgICogSUJQQiAmJiAhQlRDX05PIHNlbGVjdHMgYWxsIEFNRC9I eWdvbiBoYXJkd2FyZSwgbm90IGtub3duIHRvIGJlIHNhZmUsCg== --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.13-1.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.13-1.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW51bWVyYXRpb24gZm9yIElC UEJfUkVUCgpUaGUgSUJQQl9SRVQgYml0IGluZGljYXRlcyB0aGF0IHRoZSBD UFUncyBpbXBsZW1lbnRhdGlvbiBvZiBNU1JfUFJFRF9DTUQuSUJQQgpkb2Vz IGZsdXNoIHRoZSBSU0IvUkFTIHRvby4KClRoaXMgaXMgcGFydCBvZiBYU0Et NDIyIC8gQ1ZFLTIwMjItMjM4MjQuCgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcg Q29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpBY2tlZC1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBh L3Rvb2xzL2xpYnhsL2xpYnhsX2NwdWlkLmMgYi90b29scy9saWJ4bC9saWJ4 bF9jcHVpZC5jCmluZGV4IDExYjQzODA3ZTk2NS4uNjk0ZTU1NGM5Njk2IDEw MDY0NAotLS0gYS90b29scy9saWJ4bC9saWJ4bF9jcHVpZC5jCisrKyBiL3Rv b2xzL2xpYnhsL2xpYnhsX2NwdWlkLmMKQEAgLTI3NSw2ICsyNzUsNyBAQCBp bnQgbGlieGxfY3B1aWRfcGFyc2VfY29uZmlnKGxpYnhsX2NwdWlkX3BvbGlj eV9saXN0ICpjcHVpZCwgY29uc3QgY2hhciogc3RyKQogICAgICAgICB7InNz Yi1ubyIsICAgICAgIDB4ODAwMDAwMDgsIE5BLCBDUFVJRF9SRUdfRUJYLCAy NiwgIDF9LAogICAgICAgICB7InBzZmQiLCAgICAgICAgIDB4ODAwMDAwMDgs IE5BLCBDUFVJRF9SRUdfRUJYLCAyOCwgIDF9LAogICAgICAgICB7ImJ0Yy1u byIsICAgICAgIDB4ODAwMDAwMDgsIE5BLCBDUFVJRF9SRUdfRUJYLCAyOSwg IDF9LAorICAgICAgICB7ImlicGItcmV0IiwgICAgIDB4ODAwMDAwMDgsIE5B LCBDUFVJRF9SRUdfRUJYLCAzMCwgIDF9LAogCiAgICAgICAgIHsibmMiLCAg ICAgICAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQ1gsICAwLCAg OH0sCiAgICAgICAgIHsiYXBpY2lkc2l6ZSIsICAgMHg4MDAwMDAwOCwgTkEs IENQVUlEX1JFR19FQ1gsIDEyLCAgNH0sCmRpZmYgLS1naXQgYS90b29scy9t aXNjL3hlbi1jcHVpZC5jIGIvdG9vbHMvbWlzYy94ZW4tY3B1aWQuYwppbmRl eCA1MmY1MDU5ZDhmN2MuLmQyYWRkNzVmNDNiYyAxMDA2NDQKLS0tIGEvdG9v bHMvbWlzYy94ZW4tY3B1aWQuYworKysgYi90b29scy9taXNjL3hlbi1jcHVp ZC5jCkBAIC0xNTcsNiArMTU3LDcgQEAgc3RhdGljIGNvbnN0IGNoYXIgKmNv bnN0IHN0cl9lOGJbMzJdID0KICAgICBbMjRdID0gImFtZC1zc2JkIiwgICAg ICAgICBbMjVdID0gInZpcnQtc3NiZCIsCiAgICAgWzI2XSA9ICJzc2Itbm8i LAogICAgIFsyOF0gPSAicHNmZCIsICAgICAgICAgICAgIFsyOV0gPSAiYnRj LW5vIiwKKyAgICBbMzBdID0gImlicGItcmV0IiwKIH07CiAKIHN0YXRpYyBj b25zdCBjaGFyICpjb25zdCBzdHJfN2QwWzMyXSA9CmRpZmYgLS1naXQgYS94 ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19j dHJsLmMKaW5kZXggYmZhNWQyN2UwMGY1Li4yM2JjODcwZDNjZmUgMTAwNjQ0 Ci0tLSBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJj aC94ODYvc3BlY19jdHJsLmMKQEAgLTQxOCw3ICs0MTgsNyBAQCBzdGF0aWMg dm9pZCBfX2luaXQgcHJpbnRfZGV0YWlscyhlbnVtIGluZF90aHVuayB0aHVu aywgdWludDY0X3QgY2FwcykKICAgICAgKiBIYXJkd2FyZSByZWFkLW9ubHkg aW5mb3JtYXRpb24sIHN0YXRpbmcgaW1tdW5pdHkgdG8gY2VydGFpbiBpc3N1 ZXMsIG9yCiAgICAgICogc3VnZ2VzdGlvbnMgb2Ygd2hpY2ggbWl0aWdhdGlv biB0byB1c2UuCiAgICAgICovCi0gICAgcHJpbnRrKCIgIEhhcmR3YXJlIGhp bnRzOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlc1xuIiwKKyAgICBw cmludGsoIiAgSGFyZHdhcmUgaGludHM6JXMlcyVzJXMlcyVzJXMlcyVzJXMl cyVzJXMlcyVzJXNcbiIsCiAgICAgICAgICAgIChjYXBzICYgQVJDSF9DQVBT X1JEQ0xfTk8pICAgICAgICAgICAgICAgICAgICAgICAgPyAiIFJEQ0xfTk8i ICAgICAgICA6ICIiLAogICAgICAgICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19J QlJTX0FMTCkgICAgICAgICAgICAgICAgICAgICAgID8gIiBJQlJTX0FMTCIg ICAgICAgOiAiIiwKICAgICAgICAgICAgKGNhcHMgJiBBUkNIX0NBUFNfUlNC QSkgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIgUlNCQSIgICAgICAg ICAgIDogIiIsCkBAIC00MzQsNyArNDM0LDggQEAgc3RhdGljIHZvaWQgX19p bml0IHByaW50X2RldGFpbHMoZW51bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2 NF90IGNhcHMpCiAgICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4 Nl9GRUFUVVJFX1NUSUJQX0FMV0FZUykpICAgPyAiIFNUSUJQX0FMV0FZUyIg ICA6ICIiLAogICAgICAgICAgICAoZThiICAmIGNwdWZlYXRfbWFzayhYODZf RkVBVFVSRV9JQlJTX0ZBU1QpKSAgICAgID8gIiBJQlJTX0ZBU1QiICAgICAg OiAiIiwKICAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZF QVRVUkVfSUJSU19TQU1FX01PREUpKSA/ICIgSUJSU19TQU1FX01PREUiIDog IiIsCi0gICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFU VVJFX0JUQ19OTykpICAgICAgICAgPyAiIEJUQ19OTyIgICAgICAgICA6ICIi KTsKKyAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRV UkVfQlRDX05PKSkgICAgICAgICA/ICIgQlRDX05PIiAgICAgICAgIDogIiIs CisgICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJF X0lCUEJfUkVUKSkgICAgICAgPyAiIElCUEJfUkVUIiAgICAgICA6ICIiKTsK IAogICAgIC8qIEhhcmR3YXJlIGZlYXR1cmVzIHdoaWNoIG5lZWQgZHJpdmlu ZyB0byBtaXRpZ2F0ZSBpc3N1ZXMuICovCiAgICAgcHJpbnRrKCIgIEhhcmR3 YXJlIGZlYXR1cmVzOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlc1xuIiwKZGlm ZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0 dXJlc2V0LmggYi94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVh dHVyZXNldC5oCmluZGV4IDQ0YjNiYTMzMWZiNy4uZGRjZmE1ZTgwNzQ0IDEw MDY0NAotLS0gYS94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVh dHVyZXNldC5oCisrKyBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9j cHVmZWF0dXJlc2V0LmgKQEAgLTI1OSw2ICsyNTksNyBAQCBYRU5fQ1BVRkVB VFVSRShWSVJUX1NTQkQsICAgICA4KjMyKzI1KSAvKiAgIE1TUl9WSVJUX1NQ RUNfQ1RSTC5TU0JEICovCiBYRU5fQ1BVRkVBVFVSRShTU0JfTk8sICAgICAg ICA4KjMyKzI2KSAvKiAgIEhhcmR3YXJlIG5vdCB2dWxuZXJhYmxlIHRvIFNT QiAqLwogWEVOX0NQVUZFQVRVUkUoUFNGRCwgICAgICAgICAgOCozMisyOCkg LyogICBNU1JfU1BFQ19DVFJMLlBTRkQgKi8KIFhFTl9DUFVGRUFUVVJFKEJU Q19OTywgICAgICAgIDgqMzIrMjkpIC8qQSAgSGFyZHdhcmUgbm90IHZ1bG5l cmFibGUgdG8gQnJhbmNoIFR5cGUgQ29uZnVzaW9uICovCitYRU5fQ1BVRkVB VFVSRShJQlBCX1JFVCwgICAgICA4KjMyKzMwKSAvKkEgIElCUEIgY2xlYXJz IFJTQi9SQVMgdG9vLiAqLwogCiAvKiBJbnRlbC1kZWZpbmVkIENQVSBmZWF0 dXJlcywgQ1BVSUQgbGV2ZWwgMHgwMDAwMDAwNzowLmVkeCwgd29yZCA5ICov CiBYRU5fQ1BVRkVBVFVSRShBVlg1MTJfNFZOTklXLCA5KjMyKyAyKSAvKkEg IEFWWDUxMiBOZXVyYWwgTmV0d29yayBJbnN0cnVjdGlvbnMgKi8K --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.13-2.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.13-2.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgSUJQQiBub3Qg Zmx1c2hpbmcgdGhlIFJTQi9SQVMKCkludHJvZHVjZSBzcGVjX2N0cmxfbmV3 X2d1ZXN0X2NvbnRleHQoKSB0byBlbmNhcHN1bGF0ZSBhbGwgbG9naWMgcGVy dGFpbmluZyB0bwp1c2luZyBNU1JfUFJFRF9DTUQgZm9yIGEgbmV3IGd1ZXN0 IGNvbnRleHQsIGV2ZW4gaWYgaXQgb25seSBoYXMgb25lIHVzZXIKcHJlc2Vu dGx5LgoKSW50cm9kdWNlIFg4Nl9CVUdfSUJQQl9OT19SRVQsIGFuZCB1c2Ug aXQgZXh0ZW5kIHNwZWNfY3RybF9uZXdfZ3Vlc3RfY29udGV4dCgpCndpdGgg YSBtYW51YWwgZml4dXAgZm9yIGhhcmR3YXJlIHdoaWNoIG1pcy1pbXBsZW1l bnRzIElCUEIuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQyMiAvIENWRS0yMDIy LTIzODI0LgoKU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEphbiBCZXVsaWNoIDxq YmV1bGljaEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv YXNtLW1hY3Jvcy5jIGIveGVuL2FyY2gveDg2L2FzbS1tYWNyb3MuYwppbmRl eCBiOTYzZDU2YTU2NjMuLjhjNTg1Njk3YjlmNiAxMDA2NDQKLS0tIGEveGVu L2FyY2gveDg2L2FzbS1tYWNyb3MuYworKysgYi94ZW4vYXJjaC94ODYvYXNt LW1hY3Jvcy5jCkBAIC0xICsxLDIgQEAKICNpbmNsdWRlIDxhc20vYWx0ZXJu YXRpdmUtYXNtLmg+CisjaW5jbHVkZSA8YXNtL3NwZWNfY3RybF9hc20uaD4K ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNo L3g4Ni9kb21haW4uYwppbmRleCA2OTk2YzZiMDZhYzIuLmMxNGNjNzI0ZmEx MyAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hl bi9hcmNoL3g4Ni9kb21haW4uYwpAQCAtMTgxNCw3ICsxODE0LDcgQEAgdm9p ZCBjb250ZXh0X3N3aXRjaChzdHJ1Y3QgdmNwdSAqcHJldiwgc3RydWN0IHZj cHUgKm5leHQpCiAgICAgICAgICAgICAgKi8KICAgICAgICAgICAgIGlmICgg Kmxhc3RfaWQgIT0gbmV4dF9pZCApCiAgICAgICAgICAgICB7Ci0gICAgICAg ICAgICAgICAgd3Jtc3JsKE1TUl9QUkVEX0NNRCwgUFJFRF9DTURfSUJQQik7 CisgICAgICAgICAgICAgICAgc3BlY19jdHJsX25ld19ndWVzdF9jb250ZXh0 KCk7CiAgICAgICAgICAgICAgICAgKmxhc3RfaWQgPSBuZXh0X2lkOwogICAg ICAgICAgICAgfQogICAgICAgICB9CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94 ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5k ZXggMjNiYzg3MGQzY2ZlLi4wZGJiN2Q1Zjg3MjIgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3Bl Y19jdHJsLmMKQEAgLTc3NCw2ICs3NzQsMTQgQEAgc3RhdGljIHZvaWQgX19p bml0IGlicGJfY2FsY3VsYXRpb25zKHZvaWQpCiAgICAgfQogCiAgICAgLyoK KyAgICAgKiBBTUQvSHlnb24gQ1BVcyB0byBkYXRlIChKdW5lIDIwMjIpIGRv bid0IGZsdXNoIHRoZSB0aGUgUkFTLiAgRnV0dXJlCisgICAgICogQ1BVcyBh cmUgZXhwZWN0ZWQgdG8gZW51bWVyYXRlIElCUEJfUkVUIHdoZW4gdGhpcyBo YXMgYmVlbiBmaXhlZC4KKyAgICAgKiBVbnRpbCB0aGVuLCBjb3ZlciB0aGUg ZGlmZmVyZW5jZSB3aXRoIHRoZSBzb2Z0d2FyZSBzZXF1ZW5jZS4KKyAgICAg Ki8KKyAgICBpZiAoIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSAm JiAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lCUEJfUkVUKSApCisgICAg ICAgIHNldHVwX2ZvcmNlX2NwdV9jYXAoWDg2X0JVR19JQlBCX05PX1JFVCk7 CisKKyAgICAvKgogICAgICAqIElCUEItb24tZW50cnkgbWl0aWdhdGlvbnMg Zm9yIEJyYW5jaCBUeXBlIENvbmZ1c2lvbi4KICAgICAgKgogICAgICAqIElC UEIgJiYgIUJUQ19OTyBzZWxlY3RzIGFsbCBBTUQvSHlnb24gaGFyZHdhcmUs IG5vdCBrbm93biB0byBiZSBzYWZlLApkaWZmIC0tZ2l0IGEveGVuL2luY2x1 ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5oIGIveGVuL2luY2x1ZGUvYXNtLXg4 Ni9jcHVmZWF0dXJlcy5oCmluZGV4IGM2MTM2Y2E0YTAzMS4uNzMwZWFjNGIy ZjcwIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2NwdWZlYXR1 cmVzLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5o CkBAIC00Niw2ICs0Niw3IEBAIFhFTl9DUFVGRUFUVVJFKElCUEJfRU5UUllf SFZNLCAgICBYODZfU1lOVEgoMjcpKSAvKiBNU1JfUFJFRF9DTUQgdXNlZCBi eSBYZW4gZm9yCiAKICNkZWZpbmUgWDg2X0JVR19GUFVfUFRSUyAgICAgICAg ICBYODZfQlVHKCAwKSAvKiAoRilYe1NBVkUsUlNUT1J9IGRvZXNuJ3Qgc2F2 ZS9yZXN0b3JlIEZPUC9GSVAvRkRQLiAqLwogI2RlZmluZSBYODZfQlVHX0NM RkxVU0hfTUZFTkNFICAgIFg4Nl9CVUcoIDIpIC8qIE1GRU5DRSBuZWVkZWQg dG8gc2VyaWFsaXNlIENMRkxVU0ggKi8KKyNkZWZpbmUgWDg2X0JVR19JQlBC X05PX1JFVCAgICAgICBYODZfQlVHKCAzKSAvKiBJQlBCIGRvZXNuJ3QgZmx1 c2ggdGhlIFJTQi9SQVMgKi8KIAogLyogVG90YWwgbnVtYmVyIG9mIGNhcGFi aWxpdHkgd29yZHMsIGluYyBzeW50aCBhbmQgYnVnIHdvcmRzLiAqLwogI2Rl ZmluZSBOQ0FQSU5UUyAoRlNDQVBJTlRTICsgWDg2X05SX1NZTlRIICsgWDg2 X05SX0JVRykgLyogTiAzMi1iaXQgd29yZHMgd29ydGggb2YgaW5mbyAqLwpk aWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaCBi L3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmgKaW5kZXggMmYxNWFl OTgxNDk1Li5mY2FlZjQ5NjI5ZDUgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRl L2FzbS14ODYvc3BlY19jdHJsLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4 Ni9zcGVjX2N0cmwuaApAQCAtNjUsNiArNjUsMjggQEAKIHZvaWQgaW5pdF9z cGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKTsKIHZvaWQgc3BlY19jdHJs X2luaXRfZG9tYWluKHN0cnVjdCBkb21haW4gKmQpOwogCisvKgorICogU3dp dGNoIHRvIGEgbmV3IGd1ZXN0IHByZWRpY3Rpb24gY29udGV4dC4KKyAqCisg KiBUaGlzIGZsdXNoZXMgYWxsIGluZGlyZWN0IGJyYW5jaCBwcmVkaWN0b3Jz IChCVEIsIFJTQi9SQVMpLCBzbyBndWVzdCBjb2RlCisgKiB3aGljaCBoYXMg cHJldmlvdXNseSBydW4gb24gdGhpcyBDUFUgY2FuJ3QgYXR0YWNrIHN1YnNl cXVlbnQgZ3Vlc3QgY29kZS4KKyAqCisgKiBBcyB0aGlzIGZsdXNoZXMgdGhl IFJTQi9SQVMsIGl0IGRlc3Ryb3lzIHRoZSBwcmVkaWN0aW9ucyBvZiB0aGUg Y2FsbGluZworICogY29udGV4dC4gIEZvciBiZXN0IHBlcmZvcm1hY2UsIGFy cmFuZ2UgZm9yIHRoaXMgdG8gYmUgdXNlZCB3aGVuIHdlJ3JlIGdvaW5nCisg KiB0byBqdW1wIG91dCBvZiB0aGUgY3VycmVudCBjb250ZXh0LCBlLmcuIHdp dGggcmVzZXRfc3RhY2tfYW5kX2p1bXAoKS4KKyAqCisgKiBGb3IgaGFyZHdh cmUgd2hpY2ggbWlzLWltcGxlbWVudHMgSUJQQiwgZml4IHVwIGJ5IGZsdXNo aW5nIHRoZSBSU0IvUkFTCisgKiBtYW51YWxseS4KKyAqLworc3RhdGljIGFs d2F5c19pbmxpbmUgdm9pZCBzcGVjX2N0cmxfbmV3X2d1ZXN0X2NvbnRleHQo dm9pZCkKK3sKKyAgICB3cm1zcmwoTVNSX1BSRURfQ01ELCBQUkVEX0NNRF9J QlBCKTsKKworICAgIC8qIChhYil1c2UgYWx0ZXJuYXRpdmVfaW5wdXQoKSB0 byBzcGVjaWZ5IGNsb2JiZXJzLiAqLworICAgIGFsdGVybmF0aXZlX2lucHV0 KCIiLCAiRE9fT1ZFUldSSVRFX1JTQiIsIFg4Nl9CVUdfSUJQQl9OT19SRVQs CisgICAgICAgICAgICAgICAgICAgICAgOiAicmF4IiwgInJjeCIpOworfQor CiBleHRlcm4gaW50OF90IG9wdF9pYnBiX2N0eHRfc3dpdGNoOwogZXh0ZXJu IGJvb2wgb3B0X3NzYmQ7CiBleHRlcm4gaW50OF90IG9wdF9lYWdlcl9mcHU7 Cg== --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.14-1.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.14-1.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW51bWVyYXRpb24gZm9yIElC UEJfUkVUCgpUaGUgSUJQQl9SRVQgYml0IGluZGljYXRlcyB0aGF0IHRoZSBD UFUncyBpbXBsZW1lbnRhdGlvbiBvZiBNU1JfUFJFRF9DTUQuSUJQQgpkb2Vz IGZsdXNoIHRoZSBSU0IvUkFTIHRvby4KClRoaXMgaXMgcGFydCBvZiBYU0Et NDIyIC8gQ1ZFLTIwMjItMjM4MjQuCgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcg Q29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpBY2tlZC1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBh L3Rvb2xzL2xpYnhsL2xpYnhsX2NwdWlkLmMgYi90b29scy9saWJ4bC9saWJ4 bF9jcHVpZC5jCmluZGV4IDI1NTc2YjRkOTkyZC4uMWI3NjI2ZjdkNDFjIDEw MDY0NAotLS0gYS90b29scy9saWJ4bC9saWJ4bF9jcHVpZC5jCisrKyBiL3Rv b2xzL2xpYnhsL2xpYnhsX2NwdWlkLmMKQEAgLTI4MSw2ICsyODEsNyBAQCBp bnQgbGlieGxfY3B1aWRfcGFyc2VfY29uZmlnKGxpYnhsX2NwdWlkX3BvbGlj eV9saXN0ICpjcHVpZCwgY29uc3QgY2hhciogc3RyKQogICAgICAgICB7InNz Yi1ubyIsICAgICAgIDB4ODAwMDAwMDgsIE5BLCBDUFVJRF9SRUdfRUJYLCAy NiwgIDF9LAogICAgICAgICB7InBzZmQiLCAgICAgICAgIDB4ODAwMDAwMDgs IE5BLCBDUFVJRF9SRUdfRUJYLCAyOCwgIDF9LAogICAgICAgICB7ImJ0Yy1u byIsICAgICAgIDB4ODAwMDAwMDgsIE5BLCBDUFVJRF9SRUdfRUJYLCAyOSwg IDF9LAorICAgICAgICB7ImlicGItcmV0IiwgICAgIDB4ODAwMDAwMDgsIE5B LCBDUFVJRF9SRUdfRUJYLCAzMCwgIDF9LAogCiAgICAgICAgIHsibmMiLCAg ICAgICAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQ1gsICAwLCAg OH0sCiAgICAgICAgIHsiYXBpY2lkc2l6ZSIsICAgMHg4MDAwMDAwOCwgTkEs IENQVUlEX1JFR19FQ1gsIDEyLCAgNH0sCmRpZmYgLS1naXQgYS90b29scy9t aXNjL3hlbi1jcHVpZC5jIGIvdG9vbHMvbWlzYy94ZW4tY3B1aWQuYwppbmRl eCBlNTIwOGNmYTQ1MzguLjc3NzFkYTQ5NTMyZiAxMDA2NDQKLS0tIGEvdG9v bHMvbWlzYy94ZW4tY3B1aWQuYworKysgYi90b29scy9taXNjL3hlbi1jcHVp ZC5jCkBAIC0xNTgsNiArMTU4LDcgQEAgc3RhdGljIGNvbnN0IGNoYXIgKmNv bnN0IHN0cl9lOGJbMzJdID0KICAgICBbMjRdID0gImFtZC1zc2JkIiwgICAg ICAgICBbMjVdID0gInZpcnQtc3NiZCIsCiAgICAgWzI2XSA9ICJzc2Itbm8i LAogICAgIFsyOF0gPSAicHNmZCIsICAgICAgICAgICAgIFsyOV0gPSAiYnRj LW5vIiwKKyAgICBbMzBdID0gImlicGItcmV0IiwKIH07CiAKIHN0YXRpYyBj b25zdCBjaGFyICpjb25zdCBzdHJfN2QwWzMyXSA9CmRpZmYgLS1naXQgYS94 ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19j dHJsLmMKaW5kZXggNTYzNTE5Y2UwZTMxLi42NzlmYmFjNTdlYzcgMTAwNjQ0 Ci0tLSBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJj aC94ODYvc3BlY19jdHJsLmMKQEAgLTQxOSw3ICs0MTksNyBAQCBzdGF0aWMg dm9pZCBfX2luaXQgcHJpbnRfZGV0YWlscyhlbnVtIGluZF90aHVuayB0aHVu aywgdWludDY0X3QgY2FwcykKICAgICAgKiBIYXJkd2FyZSByZWFkLW9ubHkg aW5mb3JtYXRpb24sIHN0YXRpbmcgaW1tdW5pdHkgdG8gY2VydGFpbiBpc3N1 ZXMsIG9yCiAgICAgICogc3VnZ2VzdGlvbnMgb2Ygd2hpY2ggbWl0aWdhdGlv biB0byB1c2UuCiAgICAgICovCi0gICAgcHJpbnRrKCIgIEhhcmR3YXJlIGhp bnRzOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlc1xuIiwKKyAgICBw cmludGsoIiAgSGFyZHdhcmUgaGludHM6JXMlcyVzJXMlcyVzJXMlcyVzJXMl cyVzJXMlcyVzJXNcbiIsCiAgICAgICAgICAgIChjYXBzICYgQVJDSF9DQVBT X1JEQ0xfTk8pICAgICAgICAgICAgICAgICAgICAgICAgPyAiIFJEQ0xfTk8i ICAgICAgICA6ICIiLAogICAgICAgICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19J QlJTX0FMTCkgICAgICAgICAgICAgICAgICAgICAgID8gIiBJQlJTX0FMTCIg ICAgICAgOiAiIiwKICAgICAgICAgICAgKGNhcHMgJiBBUkNIX0NBUFNfUlNC QSkgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIgUlNCQSIgICAgICAg ICAgIDogIiIsCkBAIC00MzUsNyArNDM1LDggQEAgc3RhdGljIHZvaWQgX19p bml0IHByaW50X2RldGFpbHMoZW51bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2 NF90IGNhcHMpCiAgICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4 Nl9GRUFUVVJFX1NUSUJQX0FMV0FZUykpICAgPyAiIFNUSUJQX0FMV0FZUyIg ICA6ICIiLAogICAgICAgICAgICAoZThiICAmIGNwdWZlYXRfbWFzayhYODZf RkVBVFVSRV9JQlJTX0ZBU1QpKSAgICAgID8gIiBJQlJTX0ZBU1QiICAgICAg OiAiIiwKICAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZF QVRVUkVfSUJSU19TQU1FX01PREUpKSA/ICIgSUJSU19TQU1FX01PREUiIDog IiIsCi0gICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFU VVJFX0JUQ19OTykpICAgICAgICAgPyAiIEJUQ19OTyIgICAgICAgICA6ICIi KTsKKyAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRV UkVfQlRDX05PKSkgICAgICAgICA/ICIgQlRDX05PIiAgICAgICAgIDogIiIs CisgICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJF X0lCUEJfUkVUKSkgICAgICAgPyAiIElCUEJfUkVUIiAgICAgICA6ICIiKTsK IAogICAgIC8qIEhhcmR3YXJlIGZlYXR1cmVzIHdoaWNoIG5lZWQgZHJpdmlu ZyB0byBtaXRpZ2F0ZSBpc3N1ZXMuICovCiAgICAgcHJpbnRrKCIgIEhhcmR3 YXJlIGZlYXR1cmVzOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlc1xuIiwKZGlm ZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0 dXJlc2V0LmggYi94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVh dHVyZXNldC5oCmluZGV4IDc0NmE3NTIwMGFiOC4uZTUzNmFiNDJiMzFkIDEw MDY0NAotLS0gYS94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVh dHVyZXNldC5oCisrKyBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9j cHVmZWF0dXJlc2V0LmgKQEAgLTI2NSw2ICsyNjUsNyBAQCBYRU5fQ1BVRkVB VFVSRShWSVJUX1NTQkQsICAgICA4KjMyKzI1KSAvKiAgIE1TUl9WSVJUX1NQ RUNfQ1RSTC5TU0JEICovCiBYRU5fQ1BVRkVBVFVSRShTU0JfTk8sICAgICAg ICA4KjMyKzI2KSAvKkEgIEhhcmR3YXJlIG5vdCB2dWxuZXJhYmxlIHRvIFNT QiAqLwogWEVOX0NQVUZFQVRVUkUoUFNGRCwgICAgICAgICAgOCozMisyOCkg LypTICBNU1JfU1BFQ19DVFJMLlBTRkQgKi8KIFhFTl9DUFVGRUFUVVJFKEJU Q19OTywgICAgICAgIDgqMzIrMjkpIC8qQSAgSGFyZHdhcmUgbm90IHZ1bG5l cmFibGUgdG8gQnJhbmNoIFR5cGUgQ29uZnVzaW9uICovCitYRU5fQ1BVRkVB VFVSRShJQlBCX1JFVCwgICAgICA4KjMyKzMwKSAvKkEgIElCUEIgY2xlYXJz IFJTQi9SQVMgdG9vLiAqLwogCiAvKiBJbnRlbC1kZWZpbmVkIENQVSBmZWF0 dXJlcywgQ1BVSUQgbGV2ZWwgMHgwMDAwMDAwNzowLmVkeCwgd29yZCA5ICov CiBYRU5fQ1BVRkVBVFVSRShBVlg1MTJfNFZOTklXLCA5KjMyKyAyKSAvKkEg IEFWWDUxMiBOZXVyYWwgTmV0d29yayBJbnN0cnVjdGlvbnMgKi8K --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.14-2.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.14-2.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgSUJQQiBub3Qg Zmx1c2hpbmcgdGhlIFJTQi9SQVMKCkludHJvZHVjZSBzcGVjX2N0cmxfbmV3 X2d1ZXN0X2NvbnRleHQoKSB0byBlbmNhcHN1bGF0ZSBhbGwgbG9naWMgcGVy dGFpbmluZyB0bwp1c2luZyBNU1JfUFJFRF9DTUQgZm9yIGEgbmV3IGd1ZXN0 IGNvbnRleHQsIGV2ZW4gaWYgaXQgb25seSBoYXMgb25lIHVzZXIKcHJlc2Vu dGx5LgoKSW50cm9kdWNlIFg4Nl9CVUdfSUJQQl9OT19SRVQsIGFuZCB1c2Ug aXQgZXh0ZW5kIHNwZWNfY3RybF9uZXdfZ3Vlc3RfY29udGV4dCgpCndpdGgg YSBtYW51YWwgZml4dXAgZm9yIGhhcmR3YXJlIHdoaWNoIG1pcy1pbXBsZW1l bnRzIElCUEIuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQyMiAvIENWRS0yMDIy LTIzODI0LgoKU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEphbiBCZXVsaWNoIDxq YmV1bGljaEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv YXNtLW1hY3Jvcy5jIGIveGVuL2FyY2gveDg2L2FzbS1tYWNyb3MuYwppbmRl eCBiOTYzZDU2YTU2NjMuLjhjNTg1Njk3YjlmNiAxMDA2NDQKLS0tIGEveGVu L2FyY2gveDg2L2FzbS1tYWNyb3MuYworKysgYi94ZW4vYXJjaC94ODYvYXNt LW1hY3Jvcy5jCkBAIC0xICsxLDIgQEAKICNpbmNsdWRlIDxhc20vYWx0ZXJu YXRpdmUtYXNtLmg+CisjaW5jbHVkZSA8YXNtL3NwZWNfY3RybF9hc20uaD4K ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNo L3g4Ni9kb21haW4uYwppbmRleCA0ZmI3OGQzOGU3MTkuLmIzNzc0YWYxYTVm NiAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hl bi9hcmNoL3g4Ni9kb21haW4uYwpAQCAtMTgzMiw3ICsxODMyLDcgQEAgdm9p ZCBjb250ZXh0X3N3aXRjaChzdHJ1Y3QgdmNwdSAqcHJldiwgc3RydWN0IHZj cHUgKm5leHQpCiAgICAgICAgICAgICAgKi8KICAgICAgICAgICAgIGlmICgg Kmxhc3RfaWQgIT0gbmV4dF9pZCApCiAgICAgICAgICAgICB7Ci0gICAgICAg ICAgICAgICAgd3Jtc3JsKE1TUl9QUkVEX0NNRCwgUFJFRF9DTURfSUJQQik7 CisgICAgICAgICAgICAgICAgc3BlY19jdHJsX25ld19ndWVzdF9jb250ZXh0 KCk7CiAgICAgICAgICAgICAgICAgKmxhc3RfaWQgPSBuZXh0X2lkOwogICAg ICAgICAgICAgfQogICAgICAgICB9CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94 ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5k ZXggNjc5ZmJhYzU3ZWM3Li5jNjUwZTA3YjA2MjkgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3Bl Y19jdHJsLmMKQEAgLTc3Nyw2ICs3NzcsMTQgQEAgc3RhdGljIHZvaWQgX19p bml0IGlicGJfY2FsY3VsYXRpb25zKHZvaWQpCiAgICAgfQogCiAgICAgLyoK KyAgICAgKiBBTUQvSHlnb24gQ1BVcyB0byBkYXRlIChKdW5lIDIwMjIpIGRv bid0IGZsdXNoIHRoZSB0aGUgUkFTLiAgRnV0dXJlCisgICAgICogQ1BVcyBh cmUgZXhwZWN0ZWQgdG8gZW51bWVyYXRlIElCUEJfUkVUIHdoZW4gdGhpcyBo YXMgYmVlbiBmaXhlZC4KKyAgICAgKiBVbnRpbCB0aGVuLCBjb3ZlciB0aGUg ZGlmZmVyZW5jZSB3aXRoIHRoZSBzb2Z0d2FyZSBzZXF1ZW5jZS4KKyAgICAg Ki8KKyAgICBpZiAoIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSAm JiAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lCUEJfUkVUKSApCisgICAg ICAgIHNldHVwX2ZvcmNlX2NwdV9jYXAoWDg2X0JVR19JQlBCX05PX1JFVCk7 CisKKyAgICAvKgogICAgICAqIElCUEItb24tZW50cnkgbWl0aWdhdGlvbnMg Zm9yIEJyYW5jaCBUeXBlIENvbmZ1c2lvbi4KICAgICAgKgogICAgICAqIElC UEIgJiYgIUJUQ19OTyBzZWxlY3RzIGFsbCBBTUQvSHlnb24gaGFyZHdhcmUs IG5vdCBrbm93biB0byBiZSBzYWZlLApkaWZmIC0tZ2l0IGEveGVuL2luY2x1 ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5oIGIveGVuL2luY2x1ZGUvYXNtLXg4 Ni9jcHVmZWF0dXJlcy5oCmluZGV4IGIyMzNlNTgzNWZiNS4uYmRiMTE5YTM0 YzVkIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2NwdWZlYXR1 cmVzLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5o CkBAIC00OCw2ICs0OCw3IEBAIFhFTl9DUFVGRUFUVVJFKElCUEJfRU5UUllf SFZNLCAgICBYODZfU1lOVEgoMjkpKSAvKiBNU1JfUFJFRF9DTUQgdXNlZCBi eSBYZW4gZm9yCiAKICNkZWZpbmUgWDg2X0JVR19GUFVfUFRSUyAgICAgICAg ICBYODZfQlVHKCAwKSAvKiAoRilYe1NBVkUsUlNUT1J9IGRvZXNuJ3Qgc2F2 ZS9yZXN0b3JlIEZPUC9GSVAvRkRQLiAqLwogI2RlZmluZSBYODZfQlVHX0NM RkxVU0hfTUZFTkNFICAgIFg4Nl9CVUcoIDIpIC8qIE1GRU5DRSBuZWVkZWQg dG8gc2VyaWFsaXNlIENMRkxVU0ggKi8KKyNkZWZpbmUgWDg2X0JVR19JQlBC X05PX1JFVCAgICAgICBYODZfQlVHKCAzKSAvKiBJQlBCIGRvZXNuJ3QgZmx1 c2ggdGhlIFJTQi9SQVMgKi8KIAogLyogVG90YWwgbnVtYmVyIG9mIGNhcGFi aWxpdHkgd29yZHMsIGluYyBzeW50aCBhbmQgYnVnIHdvcmRzLiAqLwogI2Rl ZmluZSBOQ0FQSU5UUyAoRlNDQVBJTlRTICsgWDg2X05SX1NZTlRIICsgWDg2 X05SX0JVRykgLyogTiAzMi1iaXQgd29yZHMgd29ydGggb2YgaW5mbyAqLwpk aWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaCBi L3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmgKaW5kZXggMzNlODQ1 OTkxYjBhLi5lNDAwZmYyMjczOTEgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRl L2FzbS14ODYvc3BlY19jdHJsLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4 Ni9zcGVjX2N0cmwuaApAQCAtNjUsNiArNjUsMjggQEAKIHZvaWQgaW5pdF9z cGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKTsKIHZvaWQgc3BlY19jdHJs X2luaXRfZG9tYWluKHN0cnVjdCBkb21haW4gKmQpOwogCisvKgorICogU3dp dGNoIHRvIGEgbmV3IGd1ZXN0IHByZWRpY3Rpb24gY29udGV4dC4KKyAqCisg KiBUaGlzIGZsdXNoZXMgYWxsIGluZGlyZWN0IGJyYW5jaCBwcmVkaWN0b3Jz IChCVEIsIFJTQi9SQVMpLCBzbyBndWVzdCBjb2RlCisgKiB3aGljaCBoYXMg cHJldmlvdXNseSBydW4gb24gdGhpcyBDUFUgY2FuJ3QgYXR0YWNrIHN1YnNl cXVlbnQgZ3Vlc3QgY29kZS4KKyAqCisgKiBBcyB0aGlzIGZsdXNoZXMgdGhl IFJTQi9SQVMsIGl0IGRlc3Ryb3lzIHRoZSBwcmVkaWN0aW9ucyBvZiB0aGUg Y2FsbGluZworICogY29udGV4dC4gIEZvciBiZXN0IHBlcmZvcm1hY2UsIGFy cmFuZ2UgZm9yIHRoaXMgdG8gYmUgdXNlZCB3aGVuIHdlJ3JlIGdvaW5nCisg KiB0byBqdW1wIG91dCBvZiB0aGUgY3VycmVudCBjb250ZXh0LCBlLmcuIHdp dGggcmVzZXRfc3RhY2tfYW5kX2p1bXAoKS4KKyAqCisgKiBGb3IgaGFyZHdh cmUgd2hpY2ggbWlzLWltcGxlbWVudHMgSUJQQiwgZml4IHVwIGJ5IGZsdXNo aW5nIHRoZSBSU0IvUkFTCisgKiBtYW51YWxseS4KKyAqLworc3RhdGljIGFs d2F5c19pbmxpbmUgdm9pZCBzcGVjX2N0cmxfbmV3X2d1ZXN0X2NvbnRleHQo dm9pZCkKK3sKKyAgICB3cm1zcmwoTVNSX1BSRURfQ01ELCBQUkVEX0NNRF9J QlBCKTsKKworICAgIC8qIChhYil1c2UgYWx0ZXJuYXRpdmVfaW5wdXQoKSB0 byBzcGVjaWZ5IGNsb2JiZXJzLiAqLworICAgIGFsdGVybmF0aXZlX2lucHV0 KCIiLCAiRE9fT1ZFUldSSVRFX1JTQiIsIFg4Nl9CVUdfSUJQQl9OT19SRVQs CisgICAgICAgICAgICAgICAgICAgICAgOiAicmF4IiwgInJjeCIpOworfQor CiBleHRlcm4gaW50OF90IG9wdF9pYnBiX2N0eHRfc3dpdGNoOwogZXh0ZXJu IGJvb2wgb3B0X3NzYmQ7CiBleHRlcm4gaW50OF90IG9wdF9lYWdlcl9mcHU7 Cg== --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.15-1.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.15-1.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW51bWVyYXRpb24gZm9yIElC UEJfUkVUCgpUaGUgSUJQQl9SRVQgYml0IGluZGljYXRlcyB0aGF0IHRoZSBD UFUncyBpbXBsZW1lbnRhdGlvbiBvZiBNU1JfUFJFRF9DTUQuSUJQQgpkb2Vz IGZsdXNoIHRoZSBSU0IvUkFTIHRvby4KClRoaXMgaXMgcGFydCBvZiBYU0Et NDIyIC8gQ1ZFLTIwMjItMjM4MjQuCgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcg Q29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpBY2tlZC1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBh L3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYyBiL3Rvb2xzL2xpYnMv bGlnaHQvbGlieGxfY3B1aWQuYwppbmRleCAyNjMyZWZjNmFkYjAuLjRjYzJm MjExYjg3OCAxMDA2NDQKLS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9j cHVpZC5jCisrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYwpA QCAtMjg0LDYgKzI4NCw3IEBAIGludCBsaWJ4bF9jcHVpZF9wYXJzZV9jb25m aWcobGlieGxfY3B1aWRfcG9saWN5X2xpc3QgKmNwdWlkLCBjb25zdCBjaGFy KiBzdHIpCiAgICAgICAgIHsic3NiLW5vIiwgICAgICAgMHg4MDAwMDAwOCwg TkEsIENQVUlEX1JFR19FQlgsIDI2LCAgMX0sCiAgICAgICAgIHsicHNmZCIs ICAgICAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDI4LCAg MX0sCiAgICAgICAgIHsiYnRjLW5vIiwgICAgICAgMHg4MDAwMDAwOCwgTkEs IENQVUlEX1JFR19FQlgsIDI5LCAgMX0sCisgICAgICAgIHsiaWJwYi1yZXQi LCAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDMwLCAgMX0s CiAKICAgICAgICAgeyJuYyIsICAgICAgICAgICAweDgwMDAwMDA4LCBOQSwg Q1BVSURfUkVHX0VDWCwgIDAsICA4fSwKICAgICAgICAgeyJhcGljaWRzaXpl IiwgICAweDgwMDAwMDA4LCBOQSwgQ1BVSURfUkVHX0VDWCwgMTIsICA0fSwK ZGlmZiAtLWdpdCBhL3Rvb2xzL21pc2MveGVuLWNwdWlkLmMgYi90b29scy9t aXNjL3hlbi1jcHVpZC5jCmluZGV4IGU4M2JjNDc5M2Q2ZS4uNWM5NDRjMjRm ZTM2IDEwMDY0NAotLS0gYS90b29scy9taXNjL3hlbi1jcHVpZC5jCisrKyBi L3Rvb2xzL21pc2MveGVuLWNwdWlkLmMKQEAgLTE1OCw2ICsxNTgsNyBAQCBz dGF0aWMgY29uc3QgY2hhciAqY29uc3Qgc3RyX2U4YlszMl0gPQogICAgIFsy NF0gPSAiYW1kLXNzYmQiLCAgICAgICAgIFsyNV0gPSAidmlydC1zc2JkIiwK ICAgICBbMjZdID0gInNzYi1ubyIsCiAgICAgWzI4XSA9ICJwc2ZkIiwgICAg ICAgICAgICAgWzI5XSA9ICJidGMtbm8iLAorICAgIFszMF0gPSAiaWJwYi1y ZXQiLAogfTsKIAogc3RhdGljIGNvbnN0IGNoYXIgKmNvbnN0IHN0cl83ZDBb MzJdID0KZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBi L3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwppbmRleCAzZmY2MDJiZDAyODEu LjQ1OWM2NGQxMzliNiAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3NwZWNf Y3RybC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwpAQCAtNDE5 LDcgKzQxOSw3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwcmludF9kZXRhaWxz KGVudW0gaW5kX3RodW5rIHRodW5rLCB1aW50NjRfdCBjYXBzKQogICAgICAq IEhhcmR3YXJlIHJlYWQtb25seSBpbmZvcm1hdGlvbiwgc3RhdGluZyBpbW11 bml0eSB0byBjZXJ0YWluIGlzc3Vlcywgb3IKICAgICAgKiBzdWdnZXN0aW9u cyBvZiB3aGljaCBtaXRpZ2F0aW9uIHRvIHVzZS4KICAgICAgKi8KLSAgICBw cmludGsoIiAgSGFyZHdhcmUgaGludHM6JXMlcyVzJXMlcyVzJXMlcyVzJXMl cyVzJXMlcyVzJXNcbiIsCisgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGhpbnRz OiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXNcbiIsCiAgICAg ICAgICAgIChjYXBzICYgQVJDSF9DQVBTX1JEQ0xfTk8pICAgICAgICAgICAg ICAgICAgICAgICAgPyAiIFJEQ0xfTk8iICAgICAgICA6ICIiLAogICAgICAg ICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19JQlJTX0FMTCkgICAgICAgICAgICAg ICAgICAgICAgID8gIiBJQlJTX0FMTCIgICAgICAgOiAiIiwKICAgICAgICAg ICAgKGNhcHMgJiBBUkNIX0NBUFNfUlNCQSkgICAgICAgICAgICAgICAgICAg ICAgICAgICA/ICIgUlNCQSIgICAgICAgICAgIDogIiIsCkBAIC00MzYsNyAr NDM2LDggQEAgc3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMoZW51 bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICAgICAg IChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX1NUSUJQX0FMV0FZ UykpICAgPyAiIFNUSUJQX0FMV0FZUyIgICA6ICIiLAogICAgICAgICAgICAo ZThiICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9JQlJTX0ZBU1QpKSAg ICAgID8gIiBJQlJTX0ZBU1QiICAgICAgOiAiIiwKICAgICAgICAgICAgKGU4 YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfSUJSU19TQU1FX01PREUp KSA/ICIgSUJSU19TQU1FX01PREUiIDogIiIsCi0gICAgICAgICAgIChlOGIg ICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0JUQ19OTykpICAgICAgICAg PyAiIEJUQ19OTyIgICAgICAgICA6ICIiKTsKKyAgICAgICAgICAgKGU4YiAg JiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfQlRDX05PKSkgICAgICAgICA/ ICIgQlRDX05PIiAgICAgICAgIDogIiIsCisgICAgICAgICAgIChlOGIgICYg Y3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0lCUEJfUkVUKSkgICAgICAgPyAi IElCUEJfUkVUIiAgICAgICA6ICIiKTsKIAogICAgIC8qIEhhcmR3YXJlIGZl YXR1cmVzIHdoaWNoIG5lZWQgZHJpdmluZyB0byBtaXRpZ2F0ZSBpc3N1ZXMu ICovCiAgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGZlYXR1cmVzOiVzJXMlcyVz JXMlcyVzJXMlcyVzJXMlc1xuIiwKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRl L3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmggYi94ZW4vaW5jbHVk ZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCmluZGV4IDFiYmM3 ZGE0YjUzYy4uNDFhMzU4ZDU3NWQzIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVk ZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCisrKyBiL3hlbi9p bmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmgKQEAgLTI2 Niw2ICsyNjYsNyBAQCBYRU5fQ1BVRkVBVFVSRShWSVJUX1NTQkQsICAgICA4 KjMyKzI1KSAvKiAgIE1TUl9WSVJUX1NQRUNfQ1RSTC5TU0JEICovCiBYRU5f Q1BVRkVBVFVSRShTU0JfTk8sICAgICAgICA4KjMyKzI2KSAvKkEgIEhhcmR3 YXJlIG5vdCB2dWxuZXJhYmxlIHRvIFNTQiAqLwogWEVOX0NQVUZFQVRVUkUo UFNGRCwgICAgICAgICAgOCozMisyOCkgLypTICBNU1JfU1BFQ19DVFJMLlBT RkQgKi8KIFhFTl9DUFVGRUFUVVJFKEJUQ19OTywgICAgICAgIDgqMzIrMjkp IC8qQSAgSGFyZHdhcmUgbm90IHZ1bG5lcmFibGUgdG8gQnJhbmNoIFR5cGUg Q29uZnVzaW9uICovCitYRU5fQ1BVRkVBVFVSRShJQlBCX1JFVCwgICAgICA4 KjMyKzMwKSAvKkEgIElCUEIgY2xlYXJzIFJTQi9SQVMgdG9vLiAqLwogCiAv KiBJbnRlbC1kZWZpbmVkIENQVSBmZWF0dXJlcywgQ1BVSUQgbGV2ZWwgMHgw MDAwMDAwNzowLmVkeCwgd29yZCA5ICovCiBYRU5fQ1BVRkVBVFVSRShBVlg1 MTJfNFZOTklXLCA5KjMyKyAyKSAvKkEgIEFWWDUxMiBOZXVyYWwgTmV0d29y ayBJbnN0cnVjdGlvbnMgKi8K --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.15-2.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.15-2.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgSUJQQiBub3Qg Zmx1c2hpbmcgdGhlIFJTQi9SQVMKCkludHJvZHVjZSBzcGVjX2N0cmxfbmV3 X2d1ZXN0X2NvbnRleHQoKSB0byBlbmNhcHN1bGF0ZSBhbGwgbG9naWMgcGVy dGFpbmluZyB0bwp1c2luZyBNU1JfUFJFRF9DTUQgZm9yIGEgbmV3IGd1ZXN0 IGNvbnRleHQsIGV2ZW4gaWYgaXQgb25seSBoYXMgb25lIHVzZXIKcHJlc2Vu dGx5LgoKSW50cm9kdWNlIFg4Nl9CVUdfSUJQQl9OT19SRVQsIGFuZCB1c2Ug aXQgZXh0ZW5kIHNwZWNfY3RybF9uZXdfZ3Vlc3RfY29udGV4dCgpCndpdGgg YSBtYW51YWwgZml4dXAgZm9yIGhhcmR3YXJlIHdoaWNoIG1pcy1pbXBsZW1l bnRzIElCUEIuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQyMiAvIENWRS0yMDIy LTIzODI0LgoKU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEphbiBCZXVsaWNoIDxq YmV1bGljaEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv YXNtLW1hY3Jvcy5jIGIveGVuL2FyY2gveDg2L2FzbS1tYWNyb3MuYwppbmRl eCA3ZTUzNmIwZDgyZjUuLjg5MWQ4NmM3NjU1YyAxMDA2NDQKLS0tIGEveGVu L2FyY2gveDg2L2FzbS1tYWNyb3MuYworKysgYi94ZW4vYXJjaC94ODYvYXNt LW1hY3Jvcy5jCkBAIC0xLDIgKzEsMyBAQAogI2luY2x1ZGUgPGFzbS9hc20t ZGVmbnMuaD4KICNpbmNsdWRlIDxhc20vYWx0ZXJuYXRpdmUtYXNtLmg+Cisj aW5jbHVkZSA8YXNtL3NwZWNfY3RybF9hc20uaD4KZGlmZiAtLWdpdCBhL3hl bi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNoL3g4Ni9kb21haW4uYwpp bmRleCBlOWI4ZWQ0Yzk2YzIuLmI4MmUxOGRkNjJkOCAxMDA2NDQKLS0tIGEv eGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hlbi9hcmNoL3g4Ni9kb21h aW4uYwpAQCAtMjA2OSw3ICsyMDY5LDcgQEAgdm9pZCBjb250ZXh0X3N3aXRj aChzdHJ1Y3QgdmNwdSAqcHJldiwgc3RydWN0IHZjcHUgKm5leHQpCiAgICAg ICAgICAgICAgKi8KICAgICAgICAgICAgIGlmICggKmxhc3RfaWQgIT0gbmV4 dF9pZCApCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgd3Jtc3Js KE1TUl9QUkVEX0NNRCwgUFJFRF9DTURfSUJQQik7CisgICAgICAgICAgICAg ICAgc3BlY19jdHJsX25ld19ndWVzdF9jb250ZXh0KCk7CiAgICAgICAgICAg ICAgICAgKmxhc3RfaWQgPSBuZXh0X2lkOwogICAgICAgICAgICAgfQogICAg ICAgICB9CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMg Yi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5kZXggNDU5YzY0ZDEzOWI2 Li41NjM2ODUzYWFlNmIgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9zcGVj X2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKQEAgLTc3 Niw2ICs3NzYsMTQgQEAgc3RhdGljIHZvaWQgX19pbml0IGlicGJfY2FsY3Vs YXRpb25zKHZvaWQpCiAgICAgfQogCiAgICAgLyoKKyAgICAgKiBBTUQvSHln b24gQ1BVcyB0byBkYXRlIChKdW5lIDIwMjIpIGRvbid0IGZsdXNoIHRoZSB0 aGUgUkFTLiAgRnV0dXJlCisgICAgICogQ1BVcyBhcmUgZXhwZWN0ZWQgdG8g ZW51bWVyYXRlIElCUEJfUkVUIHdoZW4gdGhpcyBoYXMgYmVlbiBmaXhlZC4K KyAgICAgKiBVbnRpbCB0aGVuLCBjb3ZlciB0aGUgZGlmZmVyZW5jZSB3aXRo IHRoZSBzb2Z0d2FyZSBzZXF1ZW5jZS4KKyAgICAgKi8KKyAgICBpZiAoIGJv b3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSAmJiAhYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX0lCUEJfUkVUKSApCisgICAgICAgIHNldHVwX2ZvcmNl X2NwdV9jYXAoWDg2X0JVR19JQlBCX05PX1JFVCk7CisKKyAgICAvKgogICAg ICAqIElCUEItb24tZW50cnkgbWl0aWdhdGlvbnMgZm9yIEJyYW5jaCBUeXBl IENvbmZ1c2lvbi4KICAgICAgKgogICAgICAqIElCUEIgJiYgIUJUQ19OTyBz ZWxlY3RzIGFsbCBBTUQvSHlnb24gaGFyZHdhcmUsIG5vdCBrbm93biB0byBi ZSBzYWZlLApkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVm ZWF0dXJlcy5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5o CmluZGV4IGIyMzNlNTgzNWZiNS4uYmRiMTE5YTM0YzVkIDEwMDY0NAotLS0g YS94ZW4vaW5jbHVkZS9hc20teDg2L2NwdWZlYXR1cmVzLmgKKysrIGIveGVu L2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5oCkBAIC00OCw2ICs0OCw3 IEBAIFhFTl9DUFVGRUFUVVJFKElCUEJfRU5UUllfSFZNLCAgICBYODZfU1lO VEgoMjkpKSAvKiBNU1JfUFJFRF9DTUQgdXNlZCBieSBYZW4gZm9yCiAKICNk ZWZpbmUgWDg2X0JVR19GUFVfUFRSUyAgICAgICAgICBYODZfQlVHKCAwKSAv KiAoRilYe1NBVkUsUlNUT1J9IGRvZXNuJ3Qgc2F2ZS9yZXN0b3JlIEZPUC9G SVAvRkRQLiAqLwogI2RlZmluZSBYODZfQlVHX0NMRkxVU0hfTUZFTkNFICAg IFg4Nl9CVUcoIDIpIC8qIE1GRU5DRSBuZWVkZWQgdG8gc2VyaWFsaXNlIENM RkxVU0ggKi8KKyNkZWZpbmUgWDg2X0JVR19JQlBCX05PX1JFVCAgICAgICBY ODZfQlVHKCAzKSAvKiBJQlBCIGRvZXNuJ3QgZmx1c2ggdGhlIFJTQi9SQVMg Ki8KIAogLyogVG90YWwgbnVtYmVyIG9mIGNhcGFiaWxpdHkgd29yZHMsIGlu YyBzeW50aCBhbmQgYnVnIHdvcmRzLiAqLwogI2RlZmluZSBOQ0FQSU5UUyAo RlNDQVBJTlRTICsgWDg2X05SX1NZTlRIICsgWDg2X05SX0JVRykgLyogTiAz Mi1iaXQgd29yZHMgd29ydGggb2YgaW5mbyAqLwpkaWZmIC0tZ2l0IGEveGVu L2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaCBiL3hlbi9pbmNsdWRlL2Fz bS14ODYvc3BlY19jdHJsLmgKaW5kZXggMzNlODQ1OTkxYjBhLi5lNDAwZmYy MjczOTEgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19j dHJsLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaApA QCAtNjUsNiArNjUsMjggQEAKIHZvaWQgaW5pdF9zcGVjdWxhdGlvbl9taXRp Z2F0aW9ucyh2b2lkKTsKIHZvaWQgc3BlY19jdHJsX2luaXRfZG9tYWluKHN0 cnVjdCBkb21haW4gKmQpOwogCisvKgorICogU3dpdGNoIHRvIGEgbmV3IGd1 ZXN0IHByZWRpY3Rpb24gY29udGV4dC4KKyAqCisgKiBUaGlzIGZsdXNoZXMg YWxsIGluZGlyZWN0IGJyYW5jaCBwcmVkaWN0b3JzIChCVEIsIFJTQi9SQVMp LCBzbyBndWVzdCBjb2RlCisgKiB3aGljaCBoYXMgcHJldmlvdXNseSBydW4g b24gdGhpcyBDUFUgY2FuJ3QgYXR0YWNrIHN1YnNlcXVlbnQgZ3Vlc3QgY29k ZS4KKyAqCisgKiBBcyB0aGlzIGZsdXNoZXMgdGhlIFJTQi9SQVMsIGl0IGRl c3Ryb3lzIHRoZSBwcmVkaWN0aW9ucyBvZiB0aGUgY2FsbGluZworICogY29u dGV4dC4gIEZvciBiZXN0IHBlcmZvcm1hY2UsIGFycmFuZ2UgZm9yIHRoaXMg dG8gYmUgdXNlZCB3aGVuIHdlJ3JlIGdvaW5nCisgKiB0byBqdW1wIG91dCBv ZiB0aGUgY3VycmVudCBjb250ZXh0LCBlLmcuIHdpdGggcmVzZXRfc3RhY2tf YW5kX2p1bXAoKS4KKyAqCisgKiBGb3IgaGFyZHdhcmUgd2hpY2ggbWlzLWlt cGxlbWVudHMgSUJQQiwgZml4IHVwIGJ5IGZsdXNoaW5nIHRoZSBSU0IvUkFT CisgKiBtYW51YWxseS4KKyAqLworc3RhdGljIGFsd2F5c19pbmxpbmUgdm9p ZCBzcGVjX2N0cmxfbmV3X2d1ZXN0X2NvbnRleHQodm9pZCkKK3sKKyAgICB3 cm1zcmwoTVNSX1BSRURfQ01ELCBQUkVEX0NNRF9JQlBCKTsKKworICAgIC8q IChhYil1c2UgYWx0ZXJuYXRpdmVfaW5wdXQoKSB0byBzcGVjaWZ5IGNsb2Ji ZXJzLiAqLworICAgIGFsdGVybmF0aXZlX2lucHV0KCIiLCAiRE9fT1ZFUldS SVRFX1JTQiIsIFg4Nl9CVUdfSUJQQl9OT19SRVQsCisgICAgICAgICAgICAg ICAgICAgICAgOiAicmF4IiwgInJjeCIpOworfQorCiBleHRlcm4gaW50OF90 IG9wdF9pYnBiX2N0eHRfc3dpdGNoOwogZXh0ZXJuIGJvb2wgb3B0X3NzYmQ7 CiBleHRlcm4gaW50OF90IG9wdF9lYWdlcl9mcHU7Cg== --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.16-1.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.16-1.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW51bWVyYXRpb24gZm9yIElC UEJfUkVUCgpUaGUgSUJQQl9SRVQgYml0IGluZGljYXRlcyB0aGF0IHRoZSBD UFUncyBpbXBsZW1lbnRhdGlvbiBvZiBNU1JfUFJFRF9DTUQuSUJQQgpkb2Vz IGZsdXNoIHRoZSBSU0IvUkFTIHRvby4KClRoaXMgaXMgcGFydCBvZiBYU0Et NDIyIC8gQ1ZFLTIwMjItMjM4MjQuCgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcg Q29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpBY2tlZC1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBh L3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYyBiL3Rvb2xzL2xpYnMv bGlnaHQvbGlieGxfY3B1aWQuYwppbmRleCBiZjZmZGVlMzYwYTkuLjY5MWQ1 YzZiMmE2OCAxMDA2NDQKLS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9j cHVpZC5jCisrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYwpA QCAtMjg5LDYgKzI4OSw3IEBAIGludCBsaWJ4bF9jcHVpZF9wYXJzZV9jb25m aWcobGlieGxfY3B1aWRfcG9saWN5X2xpc3QgKmNwdWlkLCBjb25zdCBjaGFy KiBzdHIpCiAgICAgICAgIHsic3NiLW5vIiwgICAgICAgMHg4MDAwMDAwOCwg TkEsIENQVUlEX1JFR19FQlgsIDI2LCAgMX0sCiAgICAgICAgIHsicHNmZCIs ICAgICAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDI4LCAg MX0sCiAgICAgICAgIHsiYnRjLW5vIiwgICAgICAgMHg4MDAwMDAwOCwgTkEs IENQVUlEX1JFR19FQlgsIDI5LCAgMX0sCisgICAgICAgIHsiaWJwYi1yZXQi LCAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDMwLCAgMX0s CiAKICAgICAgICAgeyJuYyIsICAgICAgICAgICAweDgwMDAwMDA4LCBOQSwg Q1BVSURfUkVHX0VDWCwgIDAsICA4fSwKICAgICAgICAgeyJhcGljaWRzaXpl IiwgICAweDgwMDAwMDA4LCBOQSwgQ1BVSURfUkVHX0VDWCwgMTIsICA0fSwK ZGlmZiAtLWdpdCBhL3Rvb2xzL21pc2MveGVuLWNwdWlkLmMgYi90b29scy9t aXNjL3hlbi1jcHVpZC5jCmluZGV4IGZlMjJmNWY1YjY4Yi4uY2QwOTQ0Mjdk ZDRjIDEwMDY0NAotLS0gYS90b29scy9taXNjL3hlbi1jcHVpZC5jCisrKyBi L3Rvb2xzL21pc2MveGVuLWNwdWlkLmMKQEAgLTE1OSw2ICsxNTksNyBAQCBz dGF0aWMgY29uc3QgY2hhciAqY29uc3Qgc3RyX2U4YlszMl0gPQogICAgIFsy NF0gPSAiYW1kLXNzYmQiLCAgICAgICAgIFsyNV0gPSAidmlydC1zc2JkIiwK ICAgICBbMjZdID0gInNzYi1ubyIsCiAgICAgWzI4XSA9ICJwc2ZkIiwgICAg ICAgICAgICAgWzI5XSA9ICJidGMtbm8iLAorICAgIFszMF0gPSAiaWJwYi1y ZXQiLAogfTsKIAogc3RhdGljIGNvbnN0IGNoYXIgKmNvbnN0IHN0cl83ZDBb MzJdID0KZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBi L3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwppbmRleCAwZjRiYWQzZDNhYmIu LjE2YTU2MmQzYTE3MiAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3NwZWNf Y3RybC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwpAQCAtNDE5 LDcgKzQxOSw3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwcmludF9kZXRhaWxz KGVudW0gaW5kX3RodW5rIHRodW5rLCB1aW50NjRfdCBjYXBzKQogICAgICAq IEhhcmR3YXJlIHJlYWQtb25seSBpbmZvcm1hdGlvbiwgc3RhdGluZyBpbW11 bml0eSB0byBjZXJ0YWluIGlzc3Vlcywgb3IKICAgICAgKiBzdWdnZXN0aW9u cyBvZiB3aGljaCBtaXRpZ2F0aW9uIHRvIHVzZS4KICAgICAgKi8KLSAgICBw cmludGsoIiAgSGFyZHdhcmUgaGludHM6JXMlcyVzJXMlcyVzJXMlcyVzJXMl cyVzJXMlcyVzJXNcbiIsCisgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGhpbnRz OiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXNcbiIsCiAgICAg ICAgICAgIChjYXBzICYgQVJDSF9DQVBTX1JEQ0xfTk8pICAgICAgICAgICAg ICAgICAgICAgICAgPyAiIFJEQ0xfTk8iICAgICAgICA6ICIiLAogICAgICAg ICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19JQlJTX0FMTCkgICAgICAgICAgICAg ICAgICAgICAgID8gIiBJQlJTX0FMTCIgICAgICAgOiAiIiwKICAgICAgICAg ICAgKGNhcHMgJiBBUkNIX0NBUFNfUlNCQSkgICAgICAgICAgICAgICAgICAg ICAgICAgICA/ICIgUlNCQSIgICAgICAgICAgIDogIiIsCkBAIC00MzYsNyAr NDM2LDggQEAgc3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMoZW51 bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICAgICAg IChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX1NUSUJQX0FMV0FZ UykpICAgPyAiIFNUSUJQX0FMV0FZUyIgICA6ICIiLAogICAgICAgICAgICAo ZThiICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9JQlJTX0ZBU1QpKSAg ICAgID8gIiBJQlJTX0ZBU1QiICAgICAgOiAiIiwKICAgICAgICAgICAgKGU4 YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfSUJSU19TQU1FX01PREUp KSA/ICIgSUJSU19TQU1FX01PREUiIDogIiIsCi0gICAgICAgICAgIChlOGIg ICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0JUQ19OTykpICAgICAgICAg PyAiIEJUQ19OTyIgICAgICAgICA6ICIiKTsKKyAgICAgICAgICAgKGU4YiAg JiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfQlRDX05PKSkgICAgICAgICA/ ICIgQlRDX05PIiAgICAgICAgIDogIiIsCisgICAgICAgICAgIChlOGIgICYg Y3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0lCUEJfUkVUKSkgICAgICAgPyAi IElCUEJfUkVUIiAgICAgICA6ICIiKTsKIAogICAgIC8qIEhhcmR3YXJlIGZl YXR1cmVzIHdoaWNoIG5lZWQgZHJpdmluZyB0byBtaXRpZ2F0ZSBpc3N1ZXMu ICovCiAgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGZlYXR1cmVzOiVzJXMlcyVz JXMlcyVzJXMlcyVzJXMlc1xuIiwKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRl L3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmggYi94ZW4vaW5jbHVk ZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCmluZGV4IGU3Yjgx Njc4MDBhMi4uZTA3MzEyMjE0MDRjIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVk ZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCisrKyBiL3hlbi9p bmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmgKQEAgLTI2 Nyw2ICsyNjcsNyBAQCBYRU5fQ1BVRkVBVFVSRShWSVJUX1NTQkQsICAgICA4 KjMyKzI1KSAvKiAgIE1TUl9WSVJUX1NQRUNfQ1RSTC5TU0JEICovCiBYRU5f Q1BVRkVBVFVSRShTU0JfTk8sICAgICAgICA4KjMyKzI2KSAvKkEgIEhhcmR3 YXJlIG5vdCB2dWxuZXJhYmxlIHRvIFNTQiAqLwogWEVOX0NQVUZFQVRVUkUo UFNGRCwgICAgICAgICAgOCozMisyOCkgLypTICBNU1JfU1BFQ19DVFJMLlBT RkQgKi8KIFhFTl9DUFVGRUFUVVJFKEJUQ19OTywgICAgICAgIDgqMzIrMjkp IC8qQSAgSGFyZHdhcmUgbm90IHZ1bG5lcmFibGUgdG8gQnJhbmNoIFR5cGUg Q29uZnVzaW9uICovCitYRU5fQ1BVRkVBVFVSRShJQlBCX1JFVCwgICAgICA4 KjMyKzMwKSAvKkEgIElCUEIgY2xlYXJzIFJTQi9SQVMgdG9vLiAqLwogCiAv KiBJbnRlbC1kZWZpbmVkIENQVSBmZWF0dXJlcywgQ1BVSUQgbGV2ZWwgMHgw MDAwMDAwNzowLmVkeCwgd29yZCA5ICovCiBYRU5fQ1BVRkVBVFVSRShBVlg1 MTJfNFZOTklXLCA5KjMyKyAyKSAvKkEgIEFWWDUxMiBOZXVyYWwgTmV0d29y ayBJbnN0cnVjdGlvbnMgKi8K --=separator Content-Type: application/octet-stream; name="xsa422/xsa422-4.16-2.patch" Content-Disposition: attachment; filename="xsa422/xsa422-4.16-2.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgSUJQQiBub3Qg Zmx1c2hpbmcgdGhlIFJTQi9SQVMKCkludHJvZHVjZSBzcGVjX2N0cmxfbmV3 X2d1ZXN0X2NvbnRleHQoKSB0byBlbmNhcHN1bGF0ZSBhbGwgbG9naWMgcGVy dGFpbmluZyB0bwp1c2luZyBNU1JfUFJFRF9DTUQgZm9yIGEgbmV3IGd1ZXN0 IGNvbnRleHQsIGV2ZW4gaWYgaXQgb25seSBoYXMgb25lIHVzZXIKcHJlc2Vu dGx5LgoKSW50cm9kdWNlIFg4Nl9CVUdfSUJQQl9OT19SRVQsIGFuZCB1c2Ug aXQgZXh0ZW5kIHNwZWNfY3RybF9uZXdfZ3Vlc3RfY29udGV4dCgpCndpdGgg YSBtYW51YWwgZml4dXAgZm9yIGhhcmR3YXJlIHdoaWNoIG1pcy1pbXBsZW1l bnRzIElCUEIuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQyMiAvIENWRS0yMDIy LTIzODI0LgoKU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEphbiBCZXVsaWNoIDxq YmV1bGljaEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv YXNtLW1hY3Jvcy5jIGIveGVuL2FyY2gveDg2L2FzbS1tYWNyb3MuYwppbmRl eCA3ZTUzNmIwZDgyZjUuLjg5MWQ4NmM3NjU1YyAxMDA2NDQKLS0tIGEveGVu L2FyY2gveDg2L2FzbS1tYWNyb3MuYworKysgYi94ZW4vYXJjaC94ODYvYXNt LW1hY3Jvcy5jCkBAIC0xLDIgKzEsMyBAQAogI2luY2x1ZGUgPGFzbS9hc20t ZGVmbnMuaD4KICNpbmNsdWRlIDxhc20vYWx0ZXJuYXRpdmUtYXNtLmg+Cisj aW5jbHVkZSA8YXNtL3NwZWNfY3RybF9hc20uaD4KZGlmZiAtLWdpdCBhL3hl bi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNoL3g4Ni9kb21haW4uYwpp bmRleCAzZmFiMjM2NGJlOGQuLjMwODBjZGU2MmI1YiAxMDA2NDQKLS0tIGEv eGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hlbi9hcmNoL3g4Ni9kb21h aW4uYwpAQCAtMjA5Miw3ICsyMDkyLDcgQEAgdm9pZCBjb250ZXh0X3N3aXRj aChzdHJ1Y3QgdmNwdSAqcHJldiwgc3RydWN0IHZjcHUgKm5leHQpCiAgICAg ICAgICAgICAgKi8KICAgICAgICAgICAgIGlmICggKmxhc3RfaWQgIT0gbmV4 dF9pZCApCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgd3Jtc3Js KE1TUl9QUkVEX0NNRCwgUFJFRF9DTURfSUJQQik7CisgICAgICAgICAgICAg ICAgc3BlY19jdHJsX25ld19ndWVzdF9jb250ZXh0KCk7CiAgICAgICAgICAg ICAgICAgKmxhc3RfaWQgPSBuZXh0X2lkOwogICAgICAgICAgICAgfQogICAg ICAgICB9CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMg Yi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5kZXggMTZhNTYyZDNhMTcy Li45MGQ4NmZlNWNiNDcgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9zcGVj X2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKQEAgLTgw NSw2ICs4MDUsMTQgQEAgc3RhdGljIHZvaWQgX19pbml0IGlicGJfY2FsY3Vs YXRpb25zKHZvaWQpCiAgICAgfQogCiAgICAgLyoKKyAgICAgKiBBTUQvSHln b24gQ1BVcyB0byBkYXRlIChKdW5lIDIwMjIpIGRvbid0IGZsdXNoIHRoZSB0 aGUgUkFTLiAgRnV0dXJlCisgICAgICogQ1BVcyBhcmUgZXhwZWN0ZWQgdG8g ZW51bWVyYXRlIElCUEJfUkVUIHdoZW4gdGhpcyBoYXMgYmVlbiBmaXhlZC4K KyAgICAgKiBVbnRpbCB0aGVuLCBjb3ZlciB0aGUgZGlmZmVyZW5jZSB3aXRo IHRoZSBzb2Z0d2FyZSBzZXF1ZW5jZS4KKyAgICAgKi8KKyAgICBpZiAoIGJv b3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSAmJiAhYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX0lCUEJfUkVUKSApCisgICAgICAgIHNldHVwX2ZvcmNl X2NwdV9jYXAoWDg2X0JVR19JQlBCX05PX1JFVCk7CisKKyAgICAvKgogICAg ICAqIElCUEItb24tZW50cnkgbWl0aWdhdGlvbnMgZm9yIEJyYW5jaCBUeXBl IENvbmZ1c2lvbi4KICAgICAgKgogICAgICAqIElCUEIgJiYgIUJUQ19OTyBz ZWxlY3RzIGFsbCBBTUQvSHlnb24gaGFyZHdhcmUsIG5vdCBrbm93biB0byBi ZSBzYWZlLApkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVm ZWF0dXJlcy5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5o CmluZGV4IDY3MmM5ZWUyMmJhMi4uZWNjMWJiMDk1MDVhIDEwMDY0NAotLS0g YS94ZW4vaW5jbHVkZS9hc20teDg2L2NwdWZlYXR1cmVzLmgKKysrIGIveGVu L2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5oCkBAIC00OSw2ICs0OSw3 IEBAIFhFTl9DUFVGRUFUVVJFKElCUEJfRU5UUllfSFZNLCAgICBYODZfU1lO VEgoMjkpKSAvKiBNU1JfUFJFRF9DTUQgdXNlZCBieSBYZW4gZm9yCiAjZGVm aW5lIFg4Nl9CVUdfRlBVX1BUUlMgICAgICAgICAgWDg2X0JVRyggMCkgLyog KEYpWHtTQVZFLFJTVE9SfSBkb2Vzbid0IHNhdmUvcmVzdG9yZSBGT1AvRklQ L0ZEUC4gKi8KICNkZWZpbmUgWDg2X0JVR19OVUxMX1NFRyAgICAgICAgICBY ODZfQlVHKCAxKSAvKiBOVUxMLWluZyBhIHNlbGVjdG9yIHByZXNlcnZlcyB0 aGUgYmFzZSBhbmQgbGltaXQuICovCiAjZGVmaW5lIFg4Nl9CVUdfQ0xGTFVT SF9NRkVOQ0UgICAgWDg2X0JVRyggMikgLyogTUZFTkNFIG5lZWRlZCB0byBz ZXJpYWxpc2UgQ0xGTFVTSCAqLworI2RlZmluZSBYODZfQlVHX0lCUEJfTk9f UkVUICAgICAgIFg4Nl9CVUcoIDMpIC8qIElCUEIgZG9lc24ndCBmbHVzaCB0 aGUgUlNCL1JBUyAqLwogCiAvKiBUb3RhbCBudW1iZXIgb2YgY2FwYWJpbGl0 eSB3b3JkcywgaW5jIHN5bnRoIGFuZCBidWcgd29yZHMuICovCiAjZGVmaW5l IE5DQVBJTlRTIChGU0NBUElOVFMgKyBYODZfTlJfU1lOVEggKyBYODZfTlJf QlVHKSAvKiBOIDMyLWJpdCB3b3JkcyB3b3J0aCBvZiBpbmZvICovCmRpZmYg LS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybC5oIGIveGVu L2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaAppbmRleCA5NDAzYjgxZGM3 YWYuLjZhNzdjMzkzNzg0NCAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvYXNt LXg4Ni9zcGVjX2N0cmwuaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3Nw ZWNfY3RybC5oCkBAIC02NSw2ICs2NSwyOCBAQAogdm9pZCBpbml0X3NwZWN1 bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpOwogdm9pZCBzcGVjX2N0cmxfaW5p dF9kb21haW4oc3RydWN0IGRvbWFpbiAqZCk7CiAKKy8qCisgKiBTd2l0Y2gg dG8gYSBuZXcgZ3Vlc3QgcHJlZGljdGlvbiBjb250ZXh0LgorICoKKyAqIFRo aXMgZmx1c2hlcyBhbGwgaW5kaXJlY3QgYnJhbmNoIHByZWRpY3RvcnMgKEJU QiwgUlNCL1JBUyksIHNvIGd1ZXN0IGNvZGUKKyAqIHdoaWNoIGhhcyBwcmV2 aW91c2x5IHJ1biBvbiB0aGlzIENQVSBjYW4ndCBhdHRhY2sgc3Vic2VxdWVu dCBndWVzdCBjb2RlLgorICoKKyAqIEFzIHRoaXMgZmx1c2hlcyB0aGUgUlNC L1JBUywgaXQgZGVzdHJveXMgdGhlIHByZWRpY3Rpb25zIG9mIHRoZSBjYWxs aW5nCisgKiBjb250ZXh0LiAgRm9yIGJlc3QgcGVyZm9ybWFjZSwgYXJyYW5n ZSBmb3IgdGhpcyB0byBiZSB1c2VkIHdoZW4gd2UncmUgZ29pbmcKKyAqIHRv IGp1bXAgb3V0IG9mIHRoZSBjdXJyZW50IGNvbnRleHQsIGUuZy4gd2l0aCBy ZXNldF9zdGFja19hbmRfanVtcCgpLgorICoKKyAqIEZvciBoYXJkd2FyZSB3 aGljaCBtaXMtaW1wbGVtZW50cyBJQlBCLCBmaXggdXAgYnkgZmx1c2hpbmcg dGhlIFJTQi9SQVMKKyAqIG1hbnVhbGx5LgorICovCitzdGF0aWMgYWx3YXlz X2lubGluZSB2b2lkIHNwZWNfY3RybF9uZXdfZ3Vlc3RfY29udGV4dCh2b2lk KQoreworICAgIHdybXNybChNU1JfUFJFRF9DTUQsIFBSRURfQ01EX0lCUEIp OworCisgICAgLyogKGFiKXVzZSBhbHRlcm5hdGl2ZV9pbnB1dCgpIHRvIHNw ZWNpZnkgY2xvYmJlcnMuICovCisgICAgYWx0ZXJuYXRpdmVfaW5wdXQoIiIs ICJET19PVkVSV1JJVEVfUlNCIiwgWDg2X0JVR19JQlBCX05PX1JFVCwKKyAg ICAgICAgICAgICAgICAgICAgICA6ICJyYXgiLCAicmN4Iik7Cit9CisKIGV4 dGVybiBpbnQ4X3Qgb3B0X2licGJfY3R4dF9zd2l0Y2g7CiBleHRlcm4gYm9v bCBvcHRfc3NiZDsKIGV4dGVybiBpbnQ4X3Qgb3B0X2VhZ2VyX2ZwdTsK --=separator-- From xen-devel-bounces@lists.xenproject.org Thu Nov 10 15:36:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 15:36:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441904.695953 (Exim 4.92) (envelope-from ) id 1ot9at-0003ug-Ie; Thu, 10 Nov 2022 15:35:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441904.695953; Thu, 10 Nov 2022 15:35:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot9at-0003uZ-Fk; Thu, 10 Nov 2022 15:35:55 +0000 Received: by outflank-mailman (input) for mailman id 441904; Thu, 10 Nov 2022 15:35:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot9RV-0000zN-Eg for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 15:26:13 +0000 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ff298871-610b-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 16:26:09 +0100 (CET) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4N7Qdq2RdCz15MNt; Thu, 10 Nov 2022 23:25:51 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 10 Nov 2022 23:26:05 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 10 Nov 2022 23:26:04 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff298871-610b-11ed-91b5-6bf2151ebd3b From: Yang Yingliang To: CC: , , , Subject: [PATCH] xen/pcpu: fix possible memory leak in register_pcpu() Date: Thu, 10 Nov 2022 23:24:41 +0800 Message-ID: <20221110152441.401630-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected In device_add(), dev_set_name() is called to allocate name, if it returns error, the name need be freed. As comment of device_register() says, it should use put_device() to give up the reference in the error path. So fix this by calling put_device(), then the name can be freed in kobject_cleanup(). Fixes: f65c9bb3fb72 ("xen/pcpu: Xen physical cpus online/offline sys interface") Signed-off-by: Yang Yingliang --- drivers/xen/pcpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/pcpu.c b/drivers/xen/pcpu.c index 47aa3a1ccaf5..fd3a644b0855 100644 --- a/drivers/xen/pcpu.c +++ b/drivers/xen/pcpu.c @@ -228,7 +228,7 @@ static int register_pcpu(struct pcpu *pcpu) err = device_register(dev); if (err) { - pcpu_release(dev); + put_device(dev); return err; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 10 15:37:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 15:37:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441952.695963 (Exim 4.92) (envelope-from ) id 1ot9cr-0004TM-U3; Thu, 10 Nov 2022 15:37:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441952.695963; Thu, 10 Nov 2022 15:37:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot9cr-0004TF-RJ; Thu, 10 Nov 2022 15:37:57 +0000 Received: by outflank-mailman (input) for mailman id 441952; Thu, 10 Nov 2022 15:37:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot9cr-0004T9-2S for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 15:37:57 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2047.outbound.protection.outlook.com [40.107.249.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a49f349e-610d-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 16:37:55 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8154.eurprd04.prod.outlook.com (2603:10a6:10:243::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.24; Thu, 10 Nov 2022 15:37:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Thu, 10 Nov 2022 15:37:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a49f349e-610d-11ed-91b5-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yrb/WSoL/sjYl1BF7gIQyXJFULOPh5PSSKlLCm6ZinadVPZHWs2qnJnpcIvxVQui1J/RFeh/nte/zndLHI9PQGgLoiaN03oNzGhgnuvkMdh5zZpmL8JIEMcEiv7xEpNM8+K3m6XlXz7jKfSwx93NLZE9uAsqP0Gr8R1cCqE2JJus1VvoY6l7OSrBnU3LEoeiIglKEUG8U2FGa3DktJ0onMdHsMEf3dNgn/ULl1+GJanVxlqT+ePSFFy3xt1DlYQTsKq3AeL8sITbZhfP4HVuqLHMSlA638sw9+ZV5hZV2uKNBOv1kgQ9vFFC94Ud0lxfLdStgeBRgWhHKOQHbe2GGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KTiObr5smwAPI/hAgA+hdQks/N76nKnZadRCg7Ok+NA=; b=IXsR8BXJp0LVkc4DITqLz1YD6rhtEPu98sJrQLnxdSpPhjdajKmS6QgtCQOTL+scI7K5soUQ8c5VrsqcBCf3wRGS+YXjZYPnRB0T2QJ+WQGVvi4hDifE94Tpy7ntMS7o2YVrKHotFokzhIaoc8qYNNZiEgPDS4ocGtz2MmYsH7I5cmSZHbhn5MMjHMuDyzghGRoGBnv2eQ0P7t4+dxSAFwGUSiMaTCZi2jjawqniisB7c1JJZ0dt9UFEaVtV0JarRP2SmvYC/+KJ5ARyfqsOpS9VgFx1uPG7aEn3Rgs7B6zW8599kY0sZZlYL0ZmnoF0H8zGIEUamsEEWUSsCnnYCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KTiObr5smwAPI/hAgA+hdQks/N76nKnZadRCg7Ok+NA=; b=JJoS2PUcDTghD6m0YjU9BjWY+J0PobO0+Lf7l8rZWLrdX0EaoVpOOAUDPiBLhfSHHi5GcpF1jsgsDl6ZxYNOAKfvXbHEp/A06Skq2jm78rgh+l0pIBBDTjUHvX+c4QnnSZFQUMgdMbhC8hAQ9z8ei+UEVEzHuF7NeREAfVIFRtFQ/0GNkYW0NLKdLcsBW/4T6UCOez04HtvxeZx1ENqfbkM1oAP5c3uOXAdxOvqfp7N5YNbgNbQC230jXetFcS/IRJAcO0rbUqmhcQBiar0Dm7832qV7irQtdToo6yEWFS5SSLfkuHz1NSqmwWyyY69r8w8L8eQwVRp9BXGAh62ymg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 10 Nov 2022 16:37:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] xen/notifier: simplify using notifier_[to|from]_errno() Content-Language: en-US To: Juergen Gross Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Dario Faggioli , xen-devel@lists.xenproject.org References: <20221028114111.8150-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20221028114111.8150-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8154:EE_ X-MS-Office365-Filtering-Correlation-Id: 557c5410-9042-45d9-da89-08dac3318837 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j2dIh8A7e+nCjJHDcJfi7YrU3rm5vwd7nujMMiqOiz4IbAFYjmygW6rTfcXjQrwR+6lcXICFgg9nFyhLpVYHtann5kNIxlWC2sYyu69sneabjd1J7yE+mJDO3ZdwShQ+fVa9Z1FSjdSRXDFr8CdNsdDCqLPPr1ekfDozsxrbWDCaDOltinYEL3WxPO1fWV1jUNo4PYOtKK90P+pdH6/1V0ppJwx2RcVGwGHx1kJ7b2gtpfvP6ZZmdJlhlZ5poKAZR6Q8zenhP7S54DIZj90arcMAWPdh6fhxd2Knkwsl3AsLbstkPSR6ZRb/TZaNog7OFsrk1pKHrBCTU8chu70kr9n9xBwVqVz0buvEOje7GAL450Uy4MXnPgdKxPxZKN5HWkJ0xlTuNrNyk4AyncSX/HQ2CqlY10W57To+i0HCDkHiFFu7/1iRgV2wVB31CVGKDTWBbx53ZXPdL0AV3K1tSUFj527gIiPP1GU/VXa4/gbyhWemLiZ0QxhT2kbLYu1zZjSEC1Irx56/+Uvd3yR6dsLPoq73JqS0AmDrVvljC0BlEJ4EYFGfTaD00k27lW2+oexjzpPSYFN7HZ1pGr2SNegSWj6DCyh8QQ/+Z9ZYtxv29PsdXFprpI3OOZNFqN1CQw62fkiNnypUHwoTAXHhqBcfIVFE9hyr0lJ4Yk9iij8PGzQhEM2iD4LGVQJZL/fx6BWa9JuCi/D7UwtbuQ/gGGwJJhhRZ7ABx4Mi9lIJLqJ6V9ci2knEM7IEeMPHs4ba/7diQ754pyCNMYZGOtg5jiyVIeXZJEVJfVIlzPC1KKY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(346002)(39860400002)(136003)(396003)(451199015)(38100700002)(31696002)(86362001)(478600001)(6512007)(53546011)(37006003)(8936002)(66556008)(6862004)(6636002)(8676002)(6486002)(5660300002)(66946007)(66476007)(316002)(41300700001)(54906003)(4326008)(186003)(2616005)(6506007)(26005)(2906002)(4744005)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWVya2tIVzYvMlpTTFROM3hWQW5ZbDNPUGRJN0RZdmlhUHlualduVlp3Wita?= =?utf-8?B?aHRiWXRuL0lPTHkzU3FmQW1PZ3FQRlBLQVcxdHJRcG55ZUhNa2ZXQkEwWERK?= =?utf-8?B?RjJlRlowam83YVZ5V1JsZVVGb1dVTGM4MEphYWVNM09TdTB1M0JFZzhQUEtl?= =?utf-8?B?VEdoWW9rS1NUbUVBN2pFVWtMNEpFL3IvWWV4MVdqcFZWZXVUVVlHZjlhNitp?= =?utf-8?B?NnlzVHFWdzNHc2tvdzh3SlAzWHlQdmdKTUxpR2Z5NkY1OFIxY0gyRjZTWjJI?= =?utf-8?B?dXdEdHBGbUlDSHUwY0tFemlBNXQ1V3orSHJsTVR5TXBMSjFIcURRcFpFcktS?= =?utf-8?B?bVVObUc3QmJpcS91TWZSeFhuekpGMGZkN3RZSHFpQ3FkZURTWlFjbkhmdlcx?= =?utf-8?B?UXBSdm8zRTZoREV0T1ZhZWY2REFkWVY0UHd3K3BHbXp3NVo2ZFM2UG1XRmh1?= =?utf-8?B?MENhYkZqdXZLM2ZQZVdlOENtQzVPVlJWcGN0dE5BdkRudTgvY2ZpUHdNQktt?= =?utf-8?B?N2srUFVTeVk1RkE3RUNiRUZ5ZXZhdm9CWTd4bStnMFg0Z0ovQWtBenMzS05F?= =?utf-8?B?QldWd3RNdnZRTTRUaWxFTUlwWVdoc1hJVm5mNENnSmpuVWgvQkR1YnR0K3lm?= =?utf-8?B?TSs1MTFCNWtqaEFlZG92L1hPZGFUNmtoWXB6aDByU2VocWo5U21CTVp4WkZT?= =?utf-8?B?d0c4d2c0amIwWmovempLRVM0MXZFRXdTSjlJUmZPUmV1MUtCZHdLa25IRFBP?= =?utf-8?B?TzRzN0d3S3MydUc5bkR0bGo3aFcvd2dhdkNzbTdPeXZZaTZaYlVuSFF5R3Jk?= =?utf-8?B?bjBpYnloTmIwb1JGTU1VYUo2c2VvNERBdmoxc2ZjT3BWb0hqczdKdjIxVXcr?= =?utf-8?B?Qk8rc3B6UDlVeGxPMU5xY0hYNkk3eHAyam9RTElvb0xZZlB6VzlKclpBZU1E?= =?utf-8?B?ZEp6czM1YWJBbHNrMitpa3ZNbDVwZXpxTEpSZlFQdTRBSXdHc2xWRFZCcWRW?= =?utf-8?B?SnNEZWVWaElKU2ZyV2xIMGlYT0dUOC9YWGptdXNtaG5sQTNIOG0vdmFCR2g5?= =?utf-8?B?RnByOVN5aTV6Z0E2ajJESVhXSVU4NkVRa042aEJkTU9vRTYvNDRFVzFsSW1i?= =?utf-8?B?RnRPZDBmekNtZW5qN3NXQ29QTzdVT09PNy9ZNW9uUHQzZmx6aTNVazBablhz?= =?utf-8?B?SDBuVXh2Y1ZiWmZDNEQ2TTlIaVcyMEJBWFVpcTlKSFExR0NjM0RnRUZQeVVR?= =?utf-8?B?ZjFFNHBmaHFVT21seURRNGpMV21kelJMdC9IYUxBUkIwby85THVjVzVBWDJt?= =?utf-8?B?YkcvQWgvQk5wcTQ4Wk5zVG82ZXV3TnUzeDh3R1kxb2lneVdKbWtWb3phdjI5?= =?utf-8?B?VndCT20zRkNjOXp2ZnN1bkdlbVVwaGdoK1NKcUZyRG9JVDZPaTlML0pXalNV?= =?utf-8?B?L2R3aFYxSXhHanpjdjBCOW5JZklXeE5YZzlSV0ErU2h1Rk1OQW9ySm9GT0V2?= =?utf-8?B?NGZ2aWZFLzYyd1FOeDRNTkxtK1BwcXNsN2xydWR4Z1h5RnFhVzVYTk9IZmVs?= =?utf-8?B?REk3eDUxZWgyZEtLRDRuOXhYMUpyMVRSMnd1VEtSaXUwUlFibWNvTFA4dkJF?= =?utf-8?B?NXRqSzRNRmd5TWhCZzg0bEtwVzFnTUJieEpSaWYxU2JRRmdJNFJOVjYzSWdz?= =?utf-8?B?ZHg0WUlXckNwMWVITFQwOEF3bUNKV0lscVBoL0hIWVlPdjRlRndqWWI0aGpn?= =?utf-8?B?U0MwTCtQUGF0c1ZpclFTMk5ENzgvbnk2bForVTVja3JRSW4zd1BOVGRHdUcv?= =?utf-8?B?bUdTV2hkUTQ3Y09vaWswdG1JRUpBcisxL0s0S0ZDZE12em9hSldJdEdjVFJh?= =?utf-8?B?bm1UVFV2Tk9rRjE3MVphR3Z4QVMydGs1dDl2TFRWZ0hBeDJnMG44OXJqalBM?= =?utf-8?B?Q2FvQkdxNlJVem8xamZLOFpJUHhwQ3NaRFBFejRmYUdGVStxVkxsdEpSbWtB?= =?utf-8?B?YjRMOFZrcWZPY3JOUGIvZzM5YjhIN3dkYjFjZU1kWmExNTZxUEZCQlQvZVdN?= =?utf-8?B?WWpvN1RHQTFoQ2lwNE1UR3VUSG55d3FaY2tlQ1Z0Qi9ld2xtK0hVQ2JCV3BY?= =?utf-8?Q?XJKp7FDHgvBDz68pimzX+k42y?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 557c5410-9042-45d9-da89-08dac3318837 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 15:37:53.3928 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q4t6Nb5lEK3su3d/cz0PZLuRqcwpeJqWcM7otDkQEY0LwjsNbcGqQYumLZlRWVbGlLePfZnc9G0K9jAJNfWvRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8154 On 28.10.2022 13:41, Juergen Gross wrote: > Today all users of notifier_from_errno() and notifier_to_errno() are > Handling the success case the same way, by using > > !rc ? NOTIFY_DONE : notifier_from_errno(rc) > > or > > (notifier_rc == NOTIFY_DONE) ? 0 : notifier_to_errno(notifier_rc); > > Simplify the use cases by moving the handling of the success case into > the functions. > > Signed-off-by: Juergen Gross Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Thu Nov 10 15:41:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 15:41:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441958.695975 (Exim 4.92) (envelope-from ) id 1ot9fu-0005sV-CR; Thu, 10 Nov 2022 15:41:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441958.695975; Thu, 10 Nov 2022 15:41:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot9fu-0005sO-9E; Thu, 10 Nov 2022 15:41:06 +0000 Received: by outflank-mailman (input) for mailman id 441958; Thu, 10 Nov 2022 15:41:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot9ft-0005s9-Cy for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 15:41:05 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150075.outbound.protection.outlook.com [40.107.15.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 14980c50-610e-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 16:41:02 +0100 (CET) Received: from AS9PR04CA0159.eurprd04.prod.outlook.com (2603:10a6:20b:530::20) by AS4PR08MB8190.eurprd08.prod.outlook.com (2603:10a6:20b:58d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Thu, 10 Nov 2022 15:41:01 +0000 Received: from VI1EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:530:cafe::29) by AS9PR04CA0159.outlook.office365.com (2603:10a6:20b:530::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Thu, 10 Nov 2022 15:41:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT005.mail.protection.outlook.com (100.127.144.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Thu, 10 Nov 2022 15:41:00 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Thu, 10 Nov 2022 15:41:00 +0000 Received: from f04df8ca5a3d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C970CCAB-CCB7-4357-A35A-47417528718B.1; Thu, 10 Nov 2022 15:31:00 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f04df8ca5a3d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Nov 2022 15:31:00 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB8PR08MB5387.eurprd08.prod.outlook.com (2603:10a6:10:115::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 15:30:58 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5813.013; Thu, 10 Nov 2022 15:30:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14980c50-610e-11ed-91b5-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dw20qXpPDLUFdY3yGvNOahBFHZ2N/PxDAhh/AqWEmLWf+fcJhRcsPWVDfuF5XysYpKtdy//h5Woa4SdGEe5h/NyyfKuVXOP48pt86YihiLwYshqxV+reJREQc/Bo8jSB1+vVcj+FS3UEspw5k7LycixXaI1BDOMHFBBlwr6nreu1Gv1L5TlDyEtSABYhku9HQUh7gEtPIAU6NE+ChYxrghPHmPyxk8zzF9NoH2Vo0/J7jgJDrvrnF82Jk9hefOjj7zuhG2Nc4YrxHmICEx064jpSSh4UyLoPECeW9X/YlZEIjPa1pg5curvGrOvtyopPx/dUL/IRXLww6CcZ1G18oA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tw8EvDKGBg2jPS/aZQ+f/zpJmMBD5pLdBi0GUxsfPPw=; b=n6yLu1fbsScBx9sDRAaJfJY6hrMAQ6vM3NMntfGxenSqy3ENj4Qopir7DX+0skrbcQ8GdXbfZBVu+b8/g2vNbKhHygAJ/+ikf/409D4LSGXlq48XeN1c7/wVwdixqYX0ftITUE4HNW3LSrM9BOd9j5lxr1+MJZ0cKSfE5vhQ9qouGu3kGHPJ/ejtudIQ1wrXvhoNwxnrgI5Y348l3JrykZlAoqGLAAJcaL8/vaw+hj5EQRyYUB4k5n16biHfn1/RlQP8q2TB/UsxWyhusLnSA46omNakskblJXLYhKu5WehuEspdn1DFMWveDCKEjfCiJxuBu+0cEMJNiKJ/W6atyg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tw8EvDKGBg2jPS/aZQ+f/zpJmMBD5pLdBi0GUxsfPPw=; b=oFAU2lZTKU8HpKdD8v88IbID6KynjVbN5L2ziMlb7xmmYn414hGcgrzlTC6MPryf0IJTmRoXsjzPdqkts0blPO3EPOhoVi6UB313SM4gsJq7qOTQzbFXBpbHAVJnuIxszEHbnQ6Y5cGfpo2xysAEy3nKFDN8UH9dctVv9QlZaWs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 606fcb29b1086a9a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GK4jpCZ+HU1wupQkQxGfo9+bFKhYbOmTXYE1ImHJYsM+8z6ozfdKCJSSSg+sK9o0fgxSmJwHu71u5RHQUmT6jXbJTl8afcgJjnDVoUCxFbBlCYrnCAI6YGil5FxNGEJNJl5zn1pbWFWcdqRFYBELk/805g8XJNDMgDae48+Cwvmoeru3p+TgbQVsGpqZj/tMDyTuLrAblfI5daJnebF9WbLSV1jvCd0iic+oObOzAD3Mixp9hBY5GDrP4AYqqcoPyLE+yi+RfzcXkI7qBN8z4qL8iNJGN8RQ4BnIl2BaZcCyaE99AWYYg5uHIfNfUy1xFmqn6Zqeh8iDKZZbV9n3tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tw8EvDKGBg2jPS/aZQ+f/zpJmMBD5pLdBi0GUxsfPPw=; b=Nt0KmO9J3uUeYQeUjNcHoRDVO1Q+Uga9jlRn17L+K0SnsYjwGKbkEIgkfpUkbET8h3AC8NLvvaQmwtFrH1Vsft00+0HTxfhcl+Z6BDJt+LR2qffi7cJtGp72BLWrro88nacFUU/augCFFcbyWj/LS01EAuAy0TQ30SVNkDhrVv2RwTz1Ezg4lN9VW3UUUuZTGSDXBYVTH4F6xfBVu8tPqRcxRIjkW0Wr8q473Xc1oCzQBh1enCdxt5OXw232MUR9dUY2J3p/HW0YCNFNSWdxIa0zlPihLUxlxXTMvZV9r+l9K/gh/VlBP8oIsCk/8UonkGW/B9H84G3eboD1zwCvSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tw8EvDKGBg2jPS/aZQ+f/zpJmMBD5pLdBi0GUxsfPPw=; b=oFAU2lZTKU8HpKdD8v88IbID6KynjVbN5L2ziMlb7xmmYn414hGcgrzlTC6MPryf0IJTmRoXsjzPdqkts0blPO3EPOhoVi6UB313SM4gsJq7qOTQzbFXBpbHAVJnuIxszEHbnQ6Y5cGfpo2xysAEy3nKFDN8UH9dctVv9QlZaWs= From: Bertrand Marquis To: Anthony PERARD CC: Michal Orzel , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Doug Goldstein Subject: Re: [PATCH v3 0/4] Yocto Gitlab CI Thread-Topic: [PATCH v3 0/4] Yocto Gitlab CI Thread-Index: AQHY7TFh2hDh7VPqHUGkPo4tUdJZza4okuGAgAAFoQCACog5gIAFE1+AgAAkXoA= Date: Thu, 10 Nov 2022 15:30:58 +0000 Message-ID: <05E5D394-6943-4712-8716-7FE704B44B9F@arm.com> References: <1220596a-4fe7-5c08-5437-fa98eb14254c@amd.com> <6ee0706b-d1b3-187a-1557-c4b8173c6e37@amd.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DB8PR08MB5387:EE_|VI1EUR03FT005:EE_|AS4PR08MB8190:EE_ X-MS-Office365-Filtering-Correlation-Id: fd9c69df-fff9-4e3e-cdff-08dac331f7f3 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6ivgGTcm1iOq7odWVzJrQpn4sKXU65xAGtgUTt1il7Ti1fSSF1tMWSWyV2/rXT7m4DqQZmF2kScxBEhPhMuTQY1pGcXujluk0iWS4NgW9FQgdza/4dujDQDN0AjHZT4QDNW+GCEFD4A+PuBwaXElxsDsl3oftUC6kaAy3t3I7h6usAxpAguJQwMC+poK+cPPHgItdg9qd7tpYfS3E1+FdGGWmNmuOh6xqbhdIfB31X+D14UmN1jfMY2vfYZd+TWdbYr7gOLOXuouaKdRA+JecCRg3BLVab0vvEjrdDcsRjZu+2EYEcAdQCxeRRGyzL1x+17OxV69ag7JKdkIBnhxQQA5XfQD9Vg3uQa671hmtdbqBcX1hZYr5spA/Cl/fMy9jQyJ/Vnq24Bk3vIi3Ne3TEwS7y58jZxXmVsfn+N5jvSwOz0DB15fQ62bvE4eB7jYf3pbFHBKqxb142MaXYFf+uRGC3SBd27X40dUHqbCMJvqVFpE3QgA0aaI09lS+ZDkZqOjyGlC7nPZm2RJTJYWvs+xNtIqz+ihv7pj++F7f+yNzmzcf1fWkG9mEwKYxD6CkdoHZ52cOPeWvekD5w+A1TtbaV2rF/7xDqWHemPxRe+z/l6vqoU/O+qN/Y7rKrwx/5pigwbvIfI6PiuIS+fshzKo3Sflgwne7R4JhQbCDpJPBYabZ9A67LrrHyriqi3bdiqaKH8tuDPwZuoH0UJVeg/0Q6W69L+PyG1rKBOTWRJcYK7UbWliQk4mMJ5jpvTJM+KqPiNlRae8Finsa2mK7zN5sfU9tgOWlJBKdpo3FxkJzyhTR8a4UDDaFJyI9awf1GEJ2n7OgMvATiFQmUmZuE8Fb9dKPPQKi3S2m5eoH7R1Uz/PLXSjjjOtAea2xANF X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(396003)(346002)(136003)(39860400002)(451199015)(38100700002)(316002)(38070700005)(33656002)(53546011)(6486002)(6506007)(966005)(478600001)(6916009)(54906003)(4326008)(76116006)(91956017)(41300700001)(8936002)(8676002)(66476007)(66946007)(64756008)(66446008)(66556008)(5660300002)(122000001)(186003)(2906002)(2616005)(4744005)(36756003)(83380400001)(86362001)(26005)(6512007)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <835A15B9243AF54C9B1285CB78E649EB@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5387 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 791cccec-6ae3-4c62-4dda-08dac3309112 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BcRwsE71FfRyFddqfk/CtMjY4gdqY75U+yNz+VmY6v1muK5t/hqNp5qWvqYtAZ9+TA8Zdi+1UXSCr1yt/fxwQBsJzSMgMMljf4BRWI74PIuZVYZAkckJa/36IiEA2xI97zkQ2n9+I+tz9hClbZmIIBGY/y00jEBER9nCCgebaQ1qSTZYQC5hAre3g6UuE516pbwN3fYlt1V+D0uIVjBsZ8qAVvQK5RjIqwZAnL8fhiD6Un388pSbUGTeXSviAnh6GiXEgOb2N75n8DFuAQ5h8yOJPprJZa/LNU2Ln4mniuuIMGsC0UtP1LFuHgyBVLgvCIengxxLMql0lLS58Csx69C4l7Ff6VrsMIBqgMACYjWmVqFuzVkYDRME2MCwoSL6D/UmHellnzqVKHXOwbS0wLH/2aUSozB+5NKgydF/lp08x56cuu0hkEY9jwLYSlND5ppAzXts60IeqvlSPb83yd4O/7tDPzjrnWKBZRH05WzwoBeUzI5FaAFOk45J/nndg40wD9P52brUBLgFSIEMCJzVmLQuPQoEEsWvJDJYXFWqIe9uhKmx+vpljfigUc+X0rYM2cii3p/eV3yxPk8wz3DFZjfj/qDpbtDqkedSTKNJkbq6zhiDZNQvtt96shln3QQ2/cEnP1rInzFEftCUNi5//BD55d4FZE1ol74RYLZ9PZe0ymxBr7MG2ZzsJIhpRkQt/qfHVoXet44N6ZWV4nTKaEVfnOJ9tC26merHYYDEWaLX0BbjsTe4M9h9x1E6NPOUqEsFfnfPRRH3dkYU8X52B9HcD2IhX4gj+Khj5WOTmtVwas950Q9jgoGybZt2MYTVFlG3n8S7+E7tC2HhVg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(396003)(346002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(6862004)(82740400003)(70586007)(70206006)(40480700001)(5660300002)(83380400001)(41300700001)(316002)(36756003)(54906003)(8936002)(33656002)(4326008)(81166007)(36860700001)(966005)(8676002)(356005)(6486002)(478600001)(82310400005)(2616005)(107886003)(2906002)(6506007)(26005)(86362001)(6512007)(336012)(53546011)(186003)(47076005)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 15:41:00.6016 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fd9c69df-fff9-4e3e-cdff-08dac331f7f3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8190 Hi Anthony, > On 10 Nov 2022, at 13:20, Anthony PERARD wrot= e: >=20 > On Mon, Nov 07, 2022 at 08:50:09AM +0100, Michal Orzel wrote: >> 3) Try to use CI to build and push the containers to registry >> - it could be possible but what about local users >=20 > FYI, it's already possible to build and push container from the CI, at > least on X86, I've made it work: > https://lore.kernel.org/all/20220301121133.19271-3-anthony.perard@citr= ix.com/ > This works only when pushing to the "staging" branch on the main "xen" > repo as I've added secret variable there. (Also the branch needs to be > "protected" if I remember correctly.) Very nice :-) Would definitely be a good solution to have a solution like that for yocto. >=20 > I don't know how to use the Arm runner to do container builds like that. >=20 > (The change done to one x86 runner: > https://gitlab.com/xen-project/xen-gitlab-ci/-/merge_requests/15) Something to look at definitely. Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 10 15:59:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 15:59:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441967.695986 (Exim 4.92) (envelope-from ) id 1ot9xh-0007ri-SW; Thu, 10 Nov 2022 15:59:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441967.695986; Thu, 10 Nov 2022 15:59:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot9xh-0007rb-PX; Thu, 10 Nov 2022 15:59:29 +0000 Received: by outflank-mailman (input) for mailman id 441967; Thu, 10 Nov 2022 15:59:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot9xf-0007rS-NZ for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 15:59:28 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a49172c0-6110-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 16:59:24 +0100 (CET) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2AAFrrSj003418; Thu, 10 Nov 2022 15:58:57 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ks3ndr46x-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Nov 2022 15:58:55 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2AAFVLgj035688; Thu, 10 Nov 2022 15:45:29 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2043.outbound.protection.outlook.com [104.47.66.43]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3kpcsgp7jt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Nov 2022 15:45:28 +0000 Received: from BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14) by BN0PR10MB5286.namprd10.prod.outlook.com (2603:10b6:408:127::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Thu, 10 Nov 2022 15:45:25 +0000 Received: from BY5PR10MB3793.namprd10.prod.outlook.com ([fe80::72b3:f74a:9e7c:680a]) by BY5PR10MB3793.namprd10.prod.outlook.com ([fe80::72b3:f74a:9e7c:680a%4]) with mapi id 15.20.5813.012; Thu, 10 Nov 2022 15:45:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a49172c0-6110-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2022-7-12; bh=wZFvsrRB7UNO2B1spkvO0RBbeIn9H9kWVvu50sJTlhs=; b=nulYF1SUAnJWiz0c83e/ikz/CXMeTL3MgM8JxksfMC9nmE5Wwp520a3xwbahxRtuiSZO FSMQtsuINe4fRczqsdWPmX/+mo6ktxL1YTzrmuGXfWOoOGgQdRMGUBWlzlXmQgym2yaB 9FremrctABd92xkB3fHyijuMy+JkquduLyIY1lxi+BwPOHE2hEQYlWRVcMOMTP+wLeU1 rWgZD+OUHCT3NUD1vyvE5T47E5pSWNvAwewVME0VkqwXDl8Khg+uxFCpu8qNq6aW5Ef+ Nt7ApG/Ks41ji6EfZakL3EaY1AxmRul/9ktG8l5oIrTvwJ/VOwolr5DcHuXSXXCVkWW9 /g== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lks1p6tGiIq/IY9oyPussSnaO5hEdwScGy+XgTZkqCRtGAB0nsOnWe8hVZ73NY6jLgHg3FkBGBQ6YCvtJI7wDiauGIRf5lH4YZOJ8FEqJDkv4sYfswy3ZRkPasFBaGkEo6GywAYmvJ8ugtq8WbjaWF4WdUlkmnDPuwTMtPyYAkYXiAOQ7g1M2Mr8RxR4/dixlSrIWolZxC8PQg1nwX1DG+M7FKpi5yZqcE2UqiFjakpVFttgXI+dSLd9mcf3GGV4Saif1Ut9vRi43cqtHnqJUqWexcULpw2jf1yrS0j2nsewELlSx5k4vguheCkG/cBYmN2zuRhJxGRE6w+PYv6nzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wZFvsrRB7UNO2B1spkvO0RBbeIn9H9kWVvu50sJTlhs=; b=W2lURc9F9xAuFOOYvnGNYbmCTwKk7Gmrf8MNUvnet3FzdwZXqsiZYzgfZu/LlxE4N+d4DVutc+JDZA74rpB5NKkimGTqiLlAZj9OqZaQV4AW3F1PD1l9J1T6pV2RQxUVYnld6ALrQcGlGydnxYjfO4M2MZIu+MUv6Wq44HVxfFai103LFIMZcd0PG45FB3X9TuB3YIK/BxLYtw66DKD1g6AZDPywDjChB/uePn2vbSLndJFTk+6zunO5/tFg//cp7jq2eFRgu0kiH3NOm0aXC1RJKbmweYZUGefElOl417f3y4BZdYjtMEy/0uXMpiVLsF8FQpTjGRJNfDnplnCWLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wZFvsrRB7UNO2B1spkvO0RBbeIn9H9kWVvu50sJTlhs=; b=ZRbW9/tHcVpAzs03rdFxRScD+KWMZimQPfSGyYVX7/DJbc9WR7siE3TB+PRjDlLZ6Z13eVJyAHiZCNqce2LuRVMbS20emo3Ky/t8q9WR97K6P4h4S59d4Enzgo0ampCN3/ISM6WG6PnyrjrMkyhaLhnoXqtFbXzqvuMuiXq3Owk= From: Ross Philipson To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: ross.philipson@oracle.com, dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com, jailhouse-dev@googlegroups.com, jan.kiszka@siemens.com, xen-devel@lists.xenproject.org, jgross@suse.com, boris.ostrovsky@oracle.com, andrew.cooper3@citrix.com Subject: [PATCH v2 1/2] x86: Check return values from early_memremap calls Date: Thu, 10 Nov 2022 15:45:20 +0000 Message-Id: <20221110154521.613472-2-ross.philipson@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20221110154521.613472-1-ross.philipson@oracle.com> References: <20221110154521.613472-1-ross.philipson@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SA1P222CA0029.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:22c::24) To BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB3793:EE_|BN0PR10MB5286:EE_ X-MS-Office365-Filtering-Correlation-Id: b1d00032-e387-404d-0381-08dac33295b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aXcIu01lm0/OTsHR/2fIJkaPiGWQ8F3bMHs2s32R9YNAK0lXMEggqysGY0rIUVf6GSy8W5hFQCXvtCSQN3jKlbNmfZvtP6YWvLgN6VjhesLH2Deqgrpix1XQuzFCCbMM0nSFToPmzZ/5XXNc8Pkju+t6YvOGmFsUdoUVsjCyV7r9u7YKm4PwO/TMt/p6ohZ1Pv040A1YswWR0nG75TATyZ4+0XLE9wGAEwKvdfJ05obPX2PZvZphspPhp6S40mMyEwUaTJt5Bfe5VcZ9XhgLeJ+YYwvtscdWwjOxEhwxFKF7l69mNjDBMJt0IAaEh15miCLeFkXiORNkNwmFkCDl5kHGn/ocVrTDERC+KzBJyjHDoAz50yZXYPNMpzvYr3BoRW+7wS0uIXgQvgtEBfNrNVQVCqI3y8QQdSz+e5VPMo4bgm3/5zdsCAAiMtGJnzU9fUl3Q8fvmjC6uP6Tv3sJPVW8YJF2w9shM4AN1KBY4dO+YV/B4jKnDRmCGzL4MvW4KZmal8vbKdfKiGaGkerWpEt3LPWO60sx9fjYkcFE1+H5EZqVzezMdjUnqNWAwrIwsHcmudnFG83hNiGPqwd0cpQHYDeWiGN1l2b3agVWQG9qsahIl2oRty9IcntXtgfH/ooCrMJLHiW9wmXKwhePD7cBCiX64Pq8aTVm3ttLvsfOwNp6wxsrAJZSIFXNj53QPDODnqfjNnLBRdP8QbQCiw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB3793.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(396003)(376002)(39860400002)(366004)(451199015)(86362001)(7416002)(44832011)(8936002)(41300700001)(6666004)(6506007)(66946007)(2906002)(4326008)(8676002)(66556008)(1076003)(5660300002)(66476007)(30864003)(83380400001)(6486002)(316002)(478600001)(2616005)(186003)(36756003)(38100700002)(26005)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J75jdnPVdJxr87+fS6V7+LEzCJZq/KeQDo/uphxDxzClxaxw/AyHzbfyyYmR?= =?us-ascii?Q?JrsF1qqYGSQ42x+SMOVepM7zeSonhYcO14HS8JGJsddKdsQ3gWqnr9kMpru4?= =?us-ascii?Q?YGy2/aN96QKHgLQHk2qw3Tf1s2SEtur/M510+a+mJQUJkRclnOdtUW60cjpM?= =?us-ascii?Q?RBZllUc+uvVJaowg133yDHq+I4WE2Fs2REfC/gh7sFmzEBvbcXvuM/q2G3GZ?= =?us-ascii?Q?4DpXXLNVhUU//O1iCYu7yYmK7gM4lKoLOZnSfpinVI4vDKWrvVuzjD1Gccru?= =?us-ascii?Q?Cs3ATdjE14K6XJxgS4XuHNPRdi/YGHK2DE3H/bIm0B51ElXfAVts9HnSbyMp?= =?us-ascii?Q?ijsNgWttJkW/G69EgPuTOciGUdqgFdGjY7IX7MNpnGvCTrdVcMFxvqho0cbs?= =?us-ascii?Q?sEaBsorEoHc83gLWGKGf96qiq1498Ly4oFJL22u/zYxAWALR6oQ3yBYq9ES+?= =?us-ascii?Q?fkleLM+zfCZRzrSpiqTODfLgNcfxC1/ISGKmAiHWIdLBPPYwct+bv2gcvFZ7?= =?us-ascii?Q?4qIVMAUxXvgc0+7yoLyYZp5xYB6E3iFBOv8DQmL8w5G16ockTR7sR+tSlccO?= =?us-ascii?Q?ujLwcXFklqu3U9VHdqJM+o2xVzmgXE+j0y9Cto+iVyqu1ngDjE99XG0tR7TD?= =?us-ascii?Q?zJaiQOGNSMAjiXxwP0mFgOHe+yqnUvZT98a2J+78AmjrznfeOl+dnl2z7oqU?= =?us-ascii?Q?eVaMs4w+mAISH4akrQSfHV3ullHSGV6ixNpb2p3G50WhASHHuP+HenCCpzUt?= =?us-ascii?Q?Z6HPMsFACuVgLYWyRZNr3R4bfS1nvSq1ElXsz/UiBAEc4xEA6jTZLtNY94+n?= =?us-ascii?Q?3Hq2ykeCj9MhMzJk7PmNzOHxafi0V2lHIo3WiiKC2g1H4iGi5vCKVgPeSuBe?= =?us-ascii?Q?rPPVqA/0LxAGQtwbtK5Rr5dbdTGlMsMXUhkKBMwt6iQp1hmPaR4/68uYJVSK?= =?us-ascii?Q?PdSDW3Wdb1Gk/ww+3NBXjCkud33EBHr3rzXsgesh2ifX0H1qG9Ri5wAp7qA+?= =?us-ascii?Q?8UMp0gNd/btSPURXzYkNjx4Z/UC3Y8xRW8CReObbPnBzKMHJ46IN86Y43epd?= =?us-ascii?Q?JAcU0OKvo1KgCFo6K4TsC6Q4UOX0Enleg6xIIQ3NFXgMMlaKx2FJahBYNiEI?= =?us-ascii?Q?RqPmw+aU8kZ1P4HkNL5nbp0Q+8YKtRDMzHpkz1JPLbwrenmOEGhIJErzIMKb?= =?us-ascii?Q?JRD/41C2n76s82h2DRBY5juirGRf4yL27P66e7GNNPgkq64B54wQbWNGr46D?= =?us-ascii?Q?LJaG5y5vqF7UlA9GGcm3LcvUWoL5JXh4hzDGj1mMvVxEoO0qhZotnJg65hlR?= =?us-ascii?Q?8BIRCO5N8ID6i+eGuK65OpdNLjO1oKePVALCzKUMe9BzhqZQzkEAr5ngIjaN?= =?us-ascii?Q?R3yJCuRMnwnfLEKGENmsi/paX7YHUNaz3qHmYgz+XAgt+UuCvrKgLSzVAvcr?= =?us-ascii?Q?pWZbj5xGQw4vojG02Bgn+LQwPTH76U6yA1t/4j0Hzv6Ff0bqWSDeYiLo5O0J?= =?us-ascii?Q?lDiVISAfyaWnt5NScjNiZUGxt1rdYWvvbiShbolk1o7tf0IrO25LsWeoeO9w?= =?us-ascii?Q?26Of4wwNSFdrWKpuJ/elEWxwwECnD6dJzIgDds1jvCVWn2Q/io5Bh3QXYAil?= =?us-ascii?Q?Rw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1d00032-e387-404d-0381-08dac33295b0 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB3793.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 15:45:25.5811 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1l9V2oP5i6p+CKuRRH8gJ12/pMdBQ4oFpIGVVw/jJ99Vb1mW/vanLfbvb6WfNh334D3D9u5Rvd4BpSBdVdMyoHHrfQpTZzeQ9Jo80chpMpk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5286 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-10_10,2022-11-09_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211100111 X-Proofpoint-GUID: f6bqTGryMEv8ezWQccwpVqLkZLbSi357 X-Proofpoint-ORIG-GUID: f6bqTGryMEv8ezWQccwpVqLkZLbSi357 There are a number of places where early_memremap is called but the return pointer is not checked for NULL. The call can result in a NULL being returned so the checks must be added. Note that the maintainers for both the Jailhouse and Xen code approved of using panic() to handle allocation failures. In addition to checking the return values, a bit of extra cleanup of pr_* usages was done since the pr_fmt macro was introduced in the modules touched by this patch. Signed-off-by: Ross Philipson --- arch/x86/kernel/devicetree.c | 13 +++++++++++ arch/x86/kernel/e820.c | 12 +++++++++-- arch/x86/kernel/jailhouse.c | 6 ++++++ arch/x86/kernel/mpparse.c | 51 +++++++++++++++++++++++++++++++++----------- arch/x86/kernel/setup.c | 19 ++++++++++++++--- arch/x86/xen/enlighten_hvm.c | 2 ++ arch/x86/xen/mmu_pv.c | 8 +++++++ arch/x86/xen/setup.c | 2 ++ 8 files changed, 95 insertions(+), 18 deletions(-) diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c index 5cd51f2..4a5ca9a 100644 --- a/arch/x86/kernel/devicetree.c +++ b/arch/x86/kernel/devicetree.c @@ -2,6 +2,9 @@ /* * Architecture specific OF callbacks. */ + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include #include #include @@ -292,10 +295,20 @@ static void __init x86_flattree_get_config(void) map_len = max(PAGE_SIZE - (initial_dtb & ~PAGE_MASK), (u64)128); dt = early_memremap(initial_dtb, map_len); + if (!dt) { + pr_warn("failed to memremap initial dtb\n"); + return; + } + size = fdt_totalsize(dt); if (map_len < size) { early_memunmap(dt, map_len); dt = early_memremap(initial_dtb, size); + if (!dt) { + pr_warn("failed to memremap initial dtb\n"); + return; + } + map_len = size; } diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c index 9dac246..9cbc724 100644 --- a/arch/x86/kernel/e820.c +++ b/arch/x86/kernel/e820.c @@ -9,6 +9,9 @@ * quirks and other tweaks, and feeds that into the generic Linux memory * allocation code routines via a platform independent interface (memblock, etc.). */ + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include #include #include @@ -728,6 +731,11 @@ void __init e820__memory_setup_extended(u64 phys_addr, u32 data_len) struct setup_data *sdata; sdata = early_memremap(phys_addr, data_len); + if (!sdata) { + pr_warn("failed to memremap extended\n"); + return; + } + entries = sdata->len / sizeof(*extmap); extmap = (struct boot_e820_entry *)(sdata->data); @@ -1007,7 +1015,7 @@ void __init e820__reserve_setup_data(void) while (pa_data) { data = early_memremap(pa_data, sizeof(*data)); if (!data) { - pr_warn("e820: failed to memremap setup_data entry\n"); + pr_warn("failed to memremap setup_data entry\n"); return; } @@ -1030,7 +1038,7 @@ void __init e820__reserve_setup_data(void) early_memunmap(data, sizeof(*data)); data = early_memremap(pa_data, len); if (!data) { - pr_warn("e820: failed to memremap indirect setup_data\n"); + pr_warn("failed to memremap indirect setup_data\n"); return; } diff --git a/arch/x86/kernel/jailhouse.c b/arch/x86/kernel/jailhouse.c index 4eb8f2d..80db0c2 100644 --- a/arch/x86/kernel/jailhouse.c +++ b/arch/x86/kernel/jailhouse.c @@ -221,6 +221,9 @@ static void __init jailhouse_init_platform(void) while (pa_data) { mapping = early_memremap(pa_data, sizeof(header)); + if (!mapping) + panic("Jailhouse: failed to memremap setup_data header\n"); + memcpy(&header, mapping, sizeof(header)); early_memunmap(mapping, sizeof(header)); @@ -241,6 +244,9 @@ static void __init jailhouse_init_platform(void) setup_data_len = min_t(unsigned long, sizeof(setup_data), (unsigned long)header.len); mapping = early_memremap(pa_data, setup_data_len); + if (!mapping) + panic("Jailhouse: failed to memremap setup_data\n"); + memcpy(&setup_data, mapping, setup_data_len); early_memunmap(mapping, setup_data_len); diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c index fed721f..4254163 100644 --- a/arch/x86/kernel/mpparse.c +++ b/arch/x86/kernel/mpparse.c @@ -8,6 +8,8 @@ * (c) 2008 Alexey Starikovskiy */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include #include #include @@ -145,33 +147,33 @@ static int __init smp_check_mpc(struct mpc_table *mpc, char *oem, char *str) { if (memcmp(mpc->signature, MPC_SIGNATURE, 4)) { - pr_err("MPTABLE: bad signature [%c%c%c%c]!\n", + pr_err("bad signature [%c%c%c%c]!\n", mpc->signature[0], mpc->signature[1], mpc->signature[2], mpc->signature[3]); return 0; } if (mpf_checksum((unsigned char *)mpc, mpc->length)) { - pr_err("MPTABLE: checksum error!\n"); + pr_err("checksum error!\n"); return 0; } if (mpc->spec != 0x01 && mpc->spec != 0x04) { - pr_err("MPTABLE: bad table version (%d)!!\n", mpc->spec); + pr_err("bad table version (%d)!!\n", mpc->spec); return 0; } if (!mpc->lapic) { - pr_err("MPTABLE: null local APIC address!\n"); + pr_err("null local APIC address!\n"); return 0; } memcpy(oem, mpc->oem, 8); oem[8] = 0; - pr_info("MPTABLE: OEM ID: %s\n", oem); + pr_info("OEM ID: %s\n", oem); memcpy(str, mpc->productid, 12); str[12] = 0; - pr_info("MPTABLE: Product ID: %s\n", str); + pr_info("Product ID: %s\n", str); - pr_info("MPTABLE: APIC at: 0x%X\n", mpc->lapic); + pr_info("APIC at: 0x%X\n", mpc->lapic); return 1; } @@ -242,7 +244,7 @@ static int __init smp_read_mpc(struct mpc_table *mpc, unsigned early) } if (!num_processors) - pr_err("MPTABLE: no processors registered!\n"); + pr_err("no processors registered!\n"); return num_processors; } @@ -424,6 +426,9 @@ static unsigned long __init get_mpc_size(unsigned long physptr) unsigned long size; mpc = early_memremap(physptr, PAGE_SIZE); + if (!mpc) + return 0; + size = mpc->length; early_memunmap(mpc, PAGE_SIZE); apic_printk(APIC_VERBOSE, " mpc: %lx-%lx\n", physptr, physptr + size); @@ -437,7 +442,16 @@ static int __init check_physptr(struct mpf_intel *mpf, unsigned int early) unsigned long size; size = get_mpc_size(mpf->physptr); + if (!size) { + pr_err("error getting MP table size\n"); + return -1; + } + mpc = early_memremap(mpf->physptr, size); + if (!mpc) { + pr_err("error mapping MP table physptr\n"); + return -1; + } /* * Read the physical hardware table. Anything here will @@ -505,7 +519,7 @@ void __init default_get_smp_config(unsigned int early) mpf = early_memremap(mpf_base, sizeof(*mpf)); if (!mpf) { - pr_err("MPTABLE: error mapping MP table\n"); + pr_err("error mapping MP table\n"); return; } @@ -552,6 +566,7 @@ void __init default_get_smp_config(unsigned int early) static void __init smp_reserve_memory(struct mpf_intel *mpf) { + /* If get_mpc_size() is 0, memblock_reserve() will just do nothing */ memblock_reserve(mpf->physptr, get_mpc_size(mpf->physptr)); } @@ -567,6 +582,11 @@ static int __init smp_scan_config(unsigned long base, unsigned long length) while (length > 0) { bp = early_memremap(base, length); + if (!bp) { + pr_err("error mapping SMP config\n"); + return 0; + } + mpf = (struct mpf_intel *)bp; if ((*bp == SMP_MAGIC_IDENT) && (mpf->length == 1) && @@ -850,7 +870,7 @@ static int __init update_mp_table(void) mpf = early_memremap(mpf_base, sizeof(*mpf)); if (!mpf) { - pr_err("MPTABLE: mpf early_memremap() failed\n"); + pr_err("mpf early_memremap() failed\n"); return 0; } @@ -864,9 +884,14 @@ static int __init update_mp_table(void) goto do_unmap_mpf; size = get_mpc_size(mpf->physptr); + if (!size) { + pr_err("error getting MP table size\n"); + goto do_unmap_mpf; + } + mpc = early_memremap(mpf->physptr, size); if (!mpc) { - pr_err("MPTABLE: mpc early_memremap() failed\n"); + pr_err("mpc early_memremap() failed\n"); goto do_unmap_mpf; } @@ -897,7 +922,7 @@ static int __init update_mp_table(void) } else { mpc_new = early_memremap(mpc_new_phys, mpc_new_length); if (!mpc_new) { - pr_err("MPTABLE: new mpc early_memremap() failed\n"); + pr_err("new mpc early_memremap() failed\n"); goto do_unmap_mpc; } mpf->physptr = mpc_new_phys; @@ -911,7 +936,7 @@ static int __init update_mp_table(void) /* steal 16 bytes from [0, 1k) */ mpf_new = early_memremap(0x400 - 16, sizeof(*mpf_new)); if (!mpf_new) { - pr_err("MPTABLE: new mpf early_memremap() failed\n"); + pr_err("new mpf early_memremap() failed\n"); goto do_unmap_mpc; } pr_info("mpf new: %x\n", 0x400 - 16); diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index 216fee7..621fc3e 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -5,6 +5,9 @@ * This file contains the setup_arch() code, which handles the architecture-dependent * parts of early kernel initialization. */ + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include #include #include @@ -344,7 +347,7 @@ static void __init add_early_ima_buffer(u64 phys_addr) data = early_memremap(phys_addr + sizeof(struct setup_data), sizeof(*data)); if (!data) { - pr_warn("setup: failed to memremap ima_setup_data entry\n"); + pr_warn("failed to memremap ima_setup_data entry\n"); return; } @@ -401,6 +404,11 @@ static void __init parse_setup_data(void) u32 data_len, data_type; data = early_memremap(pa_data, sizeof(*data)); + if (!data) { + pr_warn("failed to memremap in parse_setup_data\n"); + return; + } + data_len = data->len + sizeof(struct setup_data); data_type = data->type; pa_next = data->next; @@ -421,6 +429,11 @@ static void __init parse_setup_data(void) break; case SETUP_RNG_SEED: data = early_memremap(pa_data, data_len); + if (!data) { + pr_warn("failed to memremap RNG seed data\n"); + return; + } + add_bootloader_randomness(data->data, data->len); /* Zero seed for forward secrecy. */ memzero_explicit(data->data, data->len); @@ -446,7 +459,7 @@ static void __init memblock_x86_reserve_range_setup_data(void) while (pa_data) { data = early_memremap(pa_data, sizeof(*data)); if (!data) { - pr_warn("setup: failed to memremap setup_data entry\n"); + pr_warn("failed to memremap setup_data entry\n"); return; } @@ -460,7 +473,7 @@ static void __init memblock_x86_reserve_range_setup_data(void) early_memunmap(data, sizeof(*data)); data = early_memremap(pa_data, len); if (!data) { - pr_warn("setup: failed to memremap indirect setup_data\n"); + pr_warn("failed to memremap indirect setup_data\n"); return; } diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c index c1cd28e..2135bfe 100644 --- a/arch/x86/xen/enlighten_hvm.c +++ b/arch/x86/xen/enlighten_hvm.c @@ -70,6 +70,8 @@ static void __init reserve_shared_info(void) memblock_reserve(pa, PAGE_SIZE); HYPERVISOR_shared_info = early_memremap(pa, PAGE_SIZE); + if (!HYPERVISOR_shared_info) + panic("xen: failed to memmap hypervisor shared page: 0x%llx\n", pa); } static void __init xen_hvm_init_mem_mapping(void) diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index ee29fb5..b164d8f 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -1824,6 +1824,8 @@ static unsigned long __init xen_read_phys_ulong(phys_addr_t addr) unsigned long val; vaddr = early_memremap_ro(addr, sizeof(val)); + if (!vaddr) + panic("xen: failed to memmap physical address: 0x%llx\n", addr); val = *vaddr; early_memunmap(vaddr, sizeof(val)); return val; @@ -1919,14 +1921,20 @@ void __init xen_relocate_p2m(void) new_p2m = (unsigned long *)(2 * PGDIR_SIZE); for (idx_pud = 0; idx_pud < n_pud; idx_pud++) { pud = early_memremap(pud_phys, PAGE_SIZE); + if (!pud) + panic("xen: failed to memmap PUD physical address: 0x%llx\n", pud_phys); clear_page(pud); for (idx_pmd = 0; idx_pmd < min(n_pmd, PTRS_PER_PUD); idx_pmd++) { pmd = early_memremap(pmd_phys, PAGE_SIZE); + if (!pmd) + panic("xen: failed to memmap PMD physical address: 0x%llx\n", pmd_phys); clear_page(pmd); for (idx_pt = 0; idx_pt < min(n_pt, PTRS_PER_PMD); idx_pt++) { pt = early_memremap(pt_phys, PAGE_SIZE); + if (!pt) + panic("xen: failed to memmap PT physical address: 0x%llx\n", pt_phys); clear_page(pt); for (idx_pte = 0; idx_pte < min(n_pte, PTRS_PER_PTE); diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index 4f43095..2f3cf6c 100644 --- a/arch/x86/xen/setup.c +++ b/arch/x86/xen/setup.c @@ -685,6 +685,8 @@ static void __init xen_phys_memcpy(phys_addr_t dest, phys_addr_t src, len = min(dest_len, src_len); to = early_memremap(dest - dest_off, dest_len + dest_off); from = early_memremap(src - src_off, src_len + src_off); + if (!to || !from) + panic("xen: failed to memmap for physical address memcpy\n"); memcpy(to, from, len); early_memunmap(to, dest_len + dest_off); early_memunmap(from, src_len + src_off); -- 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 10 16:01:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 16:01:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441973.695997 (Exim 4.92) (envelope-from ) id 1ot9z9-0001O3-Bg; Thu, 10 Nov 2022 16:00:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441973.695997; Thu, 10 Nov 2022 16:00:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot9z9-0001Nw-85; Thu, 10 Nov 2022 16:00:59 +0000 Received: by outflank-mailman (input) for mailman id 441973; Thu, 10 Nov 2022 16:00:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ot9z7-0001Nk-VJ for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 16:00:57 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d91443fb-6110-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 17:00:51 +0100 (CET) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2AAFtNeT004497; Thu, 10 Nov 2022 16:00:20 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ks3w583na-50 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Nov 2022 16:00:19 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2AAFVLgk035688; Thu, 10 Nov 2022 15:45:29 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2043.outbound.protection.outlook.com [104.47.66.43]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3kpcsgp7jt-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Nov 2022 15:45:29 +0000 Received: from BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14) by BN0PR10MB5286.namprd10.prod.outlook.com (2603:10b6:408:127::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Thu, 10 Nov 2022 15:45:27 +0000 Received: from BY5PR10MB3793.namprd10.prod.outlook.com ([fe80::72b3:f74a:9e7c:680a]) by BY5PR10MB3793.namprd10.prod.outlook.com ([fe80::72b3:f74a:9e7c:680a%4]) with mapi id 15.20.5813.012; Thu, 10 Nov 2022 15:45:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d91443fb-6110-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2022-7-12; bh=FZ/LmP2GHXCQVdjees4T+utybli0PrM7N5WDJIbg/ec=; b=SBC/BqplCMsO3McO4soPq+t3WgdqC8Jg0T2htbJeZ0CK0YL+x6/FcCGNyt+jg0NxASW1 6Ixvzyx0204bQ6rkf1eHOUQXVzfdf4lJLH20bbp9zd7QhMtsCpJjSSwPNGmj30/BnYii 4dEICE03/Cn8TEKrkT1nCx7LNBwz6lwM194E4VaMVK/v1E662UHsikkZsKXQdJpWZKPt HOwrzuRfSyDqoTA4P2Mh/1cClx4di4r+/SGZrOoWmclytXWf9PyEljCWM/m4LaaDy2MC oiZYzle4uOdd9bioUNBKvbfDncgrzcjUgML4X4XQXsF59xjdv4V/nmb3zPyiAipAFYId 7w== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ksdvWPaRLnvHizAVfGikYehb+YJW8RwuQ7SeeH96Pbor12ms2BhKg1ZgBLoaLE5GI0tt888LZtyhqAfLiRwZHsHENDXNkDT05dDtqdDXv294JjTplDNLAPMhtogSkgWcwaLjX6iKSm7+wroDEQKBRVdbZGYD0GWGy0c1jBxD0zJhnkX0MTHd14kYXSyRKYJ2GSGoKstB9/bVG0ArDqd9EdM++WK259p63Y0BPt5hQBE9e+UeNHt0qSfsXInpLNb/xnqn6skV1QjHcfsKPbC7PMdhOPAwEypMKaKud+Z4wOuzwAOLoX6R91/H/aTPm+e1qf2PBsT+F0i42+VXF1yjgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FZ/LmP2GHXCQVdjees4T+utybli0PrM7N5WDJIbg/ec=; b=VpzN6faisB/jWsXwXoQ0tK+C3guublIBIp6nv10tSpScrdpbMbi8Jk8S14nZuuaHkHmREpVxnj2+otp1CTPT3yeRUDayFpARmzX0Pc6gGBdoxmYN0SX53tKDbwgpBcynZDxtOU6nGNVV15nZUYivhiBIKo/RYBGBiHHA6TuKJq+3MYRR1g4R3/VLRyMT9oKeiAPWN7N8Qfb8T2J6HkwG5HGmqQPjNJQxkPFr9Qyid0Q7byJwmBOC6+sUtKJLM7f2T+YqSiacIvBE66LbtP8xZSxC5a/sTfWBQh51bcA+hcEtRa4RwurDxj8GlNocQWTY/hEIztv6MTfrppUTH9FALQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FZ/LmP2GHXCQVdjees4T+utybli0PrM7N5WDJIbg/ec=; b=cOkQ2RmH2lnvge0RY24jWI4J5kVyf8DUgqfvPBQJW9mIpk/N2yJ6jpPXEvUGOf7uESMN7t6JaTllF60NnaWYzyBtb/JqkH1VqzKVNMQXF0IE27gEZLOathUayWbb/ZTB3mz0qGK+inRxRGI8QW7FxukoNBMg+Szu90dsxbIAlNY= From: Ross Philipson To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: ross.philipson@oracle.com, dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com, jailhouse-dev@googlegroups.com, jan.kiszka@siemens.com, xen-devel@lists.xenproject.org, jgross@suse.com, boris.ostrovsky@oracle.com, andrew.cooper3@citrix.com Subject: [PATCH v2 2/2] x86: Check return values from early_ioremap calls Date: Thu, 10 Nov 2022 15:45:21 +0000 Message-Id: <20221110154521.613472-3-ross.philipson@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20221110154521.613472-1-ross.philipson@oracle.com> References: <20221110154521.613472-1-ross.philipson@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SA1P222CA0044.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:2d0::9) To BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB3793:EE_|BN0PR10MB5286:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ebc7c4a-2dcf-43ac-dcd7-08dac33296d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gMu/rr0Pal3xuw6SVZSRZFzQ7IVSHKqErBhuZnuIFMwjnvn7Axnw4NvVnXn6a7OoMC54wUQQ+d0XVzOaWpA4wlk7Dw05YsH5KbClSUOcb6gU+8ikneSUuigzSHl5eIiVD9lzn5IoFCDCNe5mRJWMmJe8tA9hMyI0WLQr3yZDSalL6roP8Sw0inhTqrXC5G7jr/OPTkaBOKGF9AmvCdKlqf9E954ExVIAR8o2r7ZYCL+A+et/NE1kHWFNWwNs4kS3IrSVk315FmMfu6I8BHWTTCEIl4wg0ofm+DUHF6SfhhewGFBraOWiP/mDBeamaqklMJIxG4pAPnQ2ddgRoLtYuOg5oo8bKIPg926KdU67mwDjgxtaKuv31H6DRd4pcDgDxemW0wAgSUx197d5X4DxgxLlf6syCVxfCSmA6JCzr/jANhU+IJY853Gc0HiPixLhP9q2Rsv8ATerCZItvkPRo7PUVq+t8VWzhPAAh/wsBArMHWIiFw39yWtZJjjIR09mA+AhEztFVLamex5iJc0t27nM25nxs0qydaeHISiLcZ7DTJ3lYhpz30K818UrjnQkaOR1/vUCksogkVOHGidwj3y+zZxFqj1qxvVcx3dtOpJ3cj+X1AB3NAq8TvS1zjk/0CIglhf0xvBWN8796vuTzch56sYlNUeOHFQDXBouEo46iWWkMIOTseSyAdYE+gvCF+wsLuEYvSSopyUsfsbIpg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB3793.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(396003)(376002)(39860400002)(366004)(451199015)(86362001)(7416002)(44832011)(8936002)(41300700001)(6666004)(6506007)(66946007)(2906002)(4326008)(8676002)(66556008)(1076003)(5660300002)(66476007)(83380400001)(6486002)(316002)(478600001)(2616005)(186003)(36756003)(38100700002)(26005)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PdEuHQoYy2GgDaKQTjt1WE0sclKzu2/U5dXhgifaZr8m+jHw6MjUWOoLrD4p?= =?us-ascii?Q?HtqOQ8oBBue/PPEL2Th289ZZH6qPgkZdaUsx/UKf4aeVIjMxDwrT/KhyO6YF?= =?us-ascii?Q?5RuTPoiF3u4HHalpXCBOtn6+KzU5Cy23ToTzoGTh8o9yEdcfu8kmG6Rg87lE?= =?us-ascii?Q?5mFc2P9tFIVfTxAAqMaXClFCePyLC3dJt+jFSr76e5B92GzCdvow4yVYqZBn?= =?us-ascii?Q?vyMjk4M+HcxtcKH4qpMB0hxTc0CQ3tBWUK0/Sy8EXhl66YdkZcSZ69VQO5mp?= =?us-ascii?Q?75KSG6R3Y2C9/tFg51B5EejVSp1lABWnAAQ46QJ9je5Q0zkoPkLKAAdGTG8F?= =?us-ascii?Q?Yr/Q7ff/33tLwHUrcN4BD9FqskkQpfV6XuxnyYqWo5Q6PPUglHgXwciJLRrp?= =?us-ascii?Q?r6GhOudd+9+M6opBiZcD4yLiycTQ6htEs2XFC/GrfYPf5LNJW0vLllmg5vDx?= =?us-ascii?Q?FvpHPTWnYX9wM91xq3lxxibbU8g9rvpYIRI1bim6qXBmukAtiHWzL3KW13xg?= =?us-ascii?Q?Zb/Lsi55ECPmHeAK8gaY13xavtoS1rjf1bDTD0dFVqYNNTO6i9Gf7W47GRZd?= =?us-ascii?Q?tCCsc3/eAQK/fCdrEud2WEpNW04LUX32n4fDR7M44lEPUW/DWYNLfGrIy74Q?= =?us-ascii?Q?fQORNg4rUPN/EQOYRHMNiDWY1aFL/4r5VxwmQhRvpvE6KpW/0vgQ8/ONQdrj?= =?us-ascii?Q?5TidIHPHbOkvQZIKHTjPQ384KdLHw9nPdcE6L7vz5pcA9ZiBqZTlPJJVPXJl?= =?us-ascii?Q?xW5nE841IbrsfLUPb/yavi8dDHT0CgnQ2aT23V8rBWcD7RTq4RhANzY6Oy0U?= =?us-ascii?Q?LASMfLN2tsyCy6XKM+lKNXT4wFDQonszQk9KagRgDWgRdi1q2v6vqJ6hOmIc?= =?us-ascii?Q?K0NDrkrt6f77zzVMJwmWbkRsPjcFH1a9uAI5b7b+1Mdv8mKBVegjDf20Prm9?= =?us-ascii?Q?62jdhhx4ZUw0oXMv4o48mNuxGPgf9knx7k5UmSsYwimlTKQAmeGKAgmkO+9o?= =?us-ascii?Q?3MLEE8Ff5DpVAA1+nfUi8cGuWRJjjEi2EIyZvl2Q9pbQEw1GYzKnZmQTNO71?= =?us-ascii?Q?uvTMPHKnDZ9hKZA7rjYsJt/+6L6lGcnVEA9vDzxmFw9xo0Dy8V/Ug0+gt5nV?= =?us-ascii?Q?BnoOYGYvqx7bKcc9gtEcu3+EknegWtI7cCBzd7qpJgZpIXZvMy9c5PQqcXTU?= =?us-ascii?Q?msgkthPumGDt2aerrg6Dp0GDj3ZMAsOFQ0lAV7ReTzzfSQfqVyfYpmPbaezK?= =?us-ascii?Q?uJABOSKwvJ5woRJPSa+PSm+HCZp9qnPG+/61njDGfSlgn3JUHoKaj0g+9XJ4?= =?us-ascii?Q?sYuucnP5ALmF7fz1C5yg1unjzS6UYzl3Ry2SegBLDaZuc6rI3SjqSIkF27VI?= =?us-ascii?Q?ic/2Ns68jrcj+i4+aQirHA/wrm/WH2CaiVJHZE9Ax+4Sqd762c9SaJN9Rv6z?= =?us-ascii?Q?BnSRfPazNGi82HUovfuPrH+Rjd3wztAw9k5B547HXk9OdrbBS9wljLCxqSrP?= =?us-ascii?Q?dFMcA/4WkyDXao5LiXUpQdtLHpvTg3CKdXbvpLyX+M70C5ryHn51zt733m8e?= =?us-ascii?Q?pRBi62D3ElSFVPRuBw7lhMiL10Za/77cFDZAQGjPzZmKMaUBRkjRBZP7jjDk?= =?us-ascii?Q?8g=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ebc7c4a-2dcf-43ac-dcd7-08dac33296d2 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB3793.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 15:45:27.4247 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xh82Ny6Rc3B4MKUkb7ldQ/T1LLyRH1jfLAr5AfOKZ9HUq87Y92c9VD6oEuIJBFHtYJ3xGLYMRbJMykVZ6mnqsdy4fdEvtEOwIcdCVch1DeY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5286 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-10_10,2022-11-09_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211100111 X-Proofpoint-GUID: MhanIWHAGLZ17MoaZ1IsEFFLUsnZMsVY X-Proofpoint-ORIG-GUID: MhanIWHAGLZ17MoaZ1IsEFFLUsnZMsVY There are a number of places where early_ioremap is called but the return pointer is not checked for NULL. The call can result in a NULL being returned so the checks must be added. On allocation failures, panic() was used since this seemed to be the action taken on other failures in the modules touched by this patch. Signed-off-by: Ross Philipson --- arch/x86/kernel/apic/x2apic_uv_x.c | 2 ++ arch/x86/kernel/early_printk.c | 2 ++ arch/x86/kernel/vsmp_64.c | 3 +++ 3 files changed, 7 insertions(+) diff --git a/arch/x86/kernel/apic/x2apic_uv_x.c b/arch/x86/kernel/apic/x2apic_uv_x.c index 4828552..4ffdc27 100644 --- a/arch/x86/kernel/apic/x2apic_uv_x.c +++ b/arch/x86/kernel/apic/x2apic_uv_x.c @@ -75,6 +75,8 @@ static unsigned long __init uv_early_read_mmr(unsigned long addr) unsigned long val, *mmr; mmr = early_ioremap(UV_LOCAL_MMR_BASE | addr, sizeof(*mmr)); + if (!mmr) + panic("UV: error: failed to ioremap MMR\n"); val = *mmr; early_iounmap(mmr, sizeof(*mmr)); diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c index 44f9370..1fe590d 100644 --- a/arch/x86/kernel/early_printk.c +++ b/arch/x86/kernel/early_printk.c @@ -290,6 +290,8 @@ static __init void early_pci_serial_init(char *s) /* WARNING! assuming the address is always in the first 4G */ early_serial_base = (unsigned long)early_ioremap(bar0 & PCI_BASE_ADDRESS_MEM_MASK, 0x10); + if (!early_serial_base) + panic("early_serial: failed to ioremap MMIO BAR\n"); write_pci_config(bus, slot, func, PCI_COMMAND, cmdreg|PCI_COMMAND_MEMORY); } diff --git a/arch/x86/kernel/vsmp_64.c b/arch/x86/kernel/vsmp_64.c index 796cfaa..39769f4 100644 --- a/arch/x86/kernel/vsmp_64.c +++ b/arch/x86/kernel/vsmp_64.c @@ -32,6 +32,9 @@ static void __init set_vsmp_ctl(void) /* set vSMP magic bits to indicate vSMP capable kernel */ cfg = read_pci_config(0, 0x1f, 0, PCI_BASE_ADDRESS_0); address = early_ioremap(cfg, 8); + if (WARN_ON(!address)) + return; + cap = readl(address); ctl = readl(address + 4); printk(KERN_INFO "vSMP CTL: capabilities:0x%08x control:0x%08x\n", -- 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 10 16:02:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 16:02:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441977.696008 (Exim 4.92) (envelope-from ) id 1otA13-0001xQ-Ll; Thu, 10 Nov 2022 16:02:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441977.696008; Thu, 10 Nov 2022 16:02:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otA13-0001xJ-Iy; Thu, 10 Nov 2022 16:02:57 +0000 Received: by outflank-mailman (input) for mailman id 441977; Thu, 10 Nov 2022 16:02:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otA11-0001x9-Hf for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 16:02:55 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 208ce74d-6111-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 17:02:51 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BF7531FDF1; Thu, 10 Nov 2022 16:02:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 993EA1332F; Thu, 10 Nov 2022 16:02:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rv/9I60gbWNcWwAAMHmgww (envelope-from ); Thu, 10 Nov 2022 16:02:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 208ce74d-6111-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1668096173; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EH1RsOGCFqO3Gwh5C+rmGdbYlC05tU3LBQpJ6dmL0Ck=; b=k+kePPyF/ssAgAJupcwAl+3aekx6Drn+6VGHnS94pEU+tr80YXMUP4c5kWG1rah0O1pfPS 4rJGl8G+wlqz4hB2+hvbR6M55aziSEvXyJJDfHHBukTnJm1P55GZ0TFSQD20OgShDa7mU6 vYuYj90zbFrYiJgSHTKKHrnJR9hHdqE= Message-ID: <71bf1069-88d3-a9dd-157f-90ecb37ad9a1@suse.com> Date: Thu, 10 Nov 2022 17:02:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] xen/pcpu: fix possible memory leak in register_pcpu() Content-Language: en-US To: Yang Yingliang , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com References: <20221110152441.401630-1-yangyingliang@huawei.com> From: Juergen Gross In-Reply-To: <20221110152441.401630-1-yangyingliang@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------6fkCioUGQkjyRoZzh4hlkvgS" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------6fkCioUGQkjyRoZzh4hlkvgS Content-Type: multipart/mixed; boundary="------------gEimVDGntJGH0oqgfWUQE39h"; protected-headers="v1" From: Juergen Gross To: Yang Yingliang , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com Message-ID: <71bf1069-88d3-a9dd-157f-90ecb37ad9a1@suse.com> Subject: Re: [PATCH] xen/pcpu: fix possible memory leak in register_pcpu() References: <20221110152441.401630-1-yangyingliang@huawei.com> In-Reply-To: <20221110152441.401630-1-yangyingliang@huawei.com> --------------gEimVDGntJGH0oqgfWUQE39h Content-Type: multipart/mixed; boundary="------------cm09FzvPvSXkufkIg2tBLfP6" --------------cm09FzvPvSXkufkIg2tBLfP6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTAuMTEuMjIgMTY6MjQsIFlhbmcgWWluZ2xpYW5nIHdyb3RlOg0KPiBJbiBkZXZpY2Vf YWRkKCksIGRldl9zZXRfbmFtZSgpIGlzIGNhbGxlZCB0byBhbGxvY2F0ZSBuYW1lLCBpZiBp dCByZXR1cm5zDQo+IGVycm9yLCB0aGUgbmFtZSBuZWVkIGJlIGZyZWVkLiBBcyBjb21tZW50 IG9mIGRldmljZV9yZWdpc3RlcigpIHNheXMsIGl0DQo+IHNob3VsZCB1c2UgcHV0X2Rldmlj ZSgpIHRvIGdpdmUgdXAgdGhlIHJlZmVyZW5jZSBpbiB0aGUgZXJyb3IgcGF0aC4gU28gZml4 DQo+IHRoaXMgYnkgY2FsbGluZyBwdXRfZGV2aWNlKCksIHRoZW4gdGhlIG5hbWUgY2FuIGJl IGZyZWVkIGluIGtvYmplY3RfY2xlYW51cCgpLg0KPiANCj4gRml4ZXM6IGY2NWM5YmIzZmI3 MiAoInhlbi9wY3B1OiBYZW4gcGh5c2ljYWwgY3B1cyBvbmxpbmUvb2ZmbGluZSBzeXMgaW50 ZXJmYWNlIikNCj4gU2lnbmVkLW9mZi1ieTogWWFuZyBZaW5nbGlhbmcgPHlhbmd5aW5nbGlh bmdAaHVhd2VpLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0Bz dXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQoNCg== --------------cm09FzvPvSXkufkIg2tBLfP6 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------cm09FzvPvSXkufkIg2tBLfP6-- --------------gEimVDGntJGH0oqgfWUQE39h-- --------------6fkCioUGQkjyRoZzh4hlkvgS Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNtIK0FAwAAAAAACgkQsN6d1ii/Ey+t ZAf/akaqdY1YnXDgKrQLwNexTKEkJqzBovalU4VbjlpzcDw+w4GTVD1Bj+qmr7EBUbMlrPA6ITt2 5ehRyxJtP6789lzTLeDNnfGdroouOpJjwS0ME6df2gMZNWPAP/00BVSKICsxG7z3ay4S2eNdZMuu XcZ4LTpFKlYNYuqyeVA8mHzbFcwwrn2i+mJPFi9vL935O5/HfhoIaF7YBm1PycLeDpIoaD03REl4 53UKskZCWqkTBMzjDNDJvUq1izUiSs1IAMdT6linJmYPyVDHeo43Xn066fIl2/kRvRCICDpr8E8o 6Qrvu7VkizAZYwFXZXlOFrcclcZtzUJDaHTLL9aadA== =Kzys -----END PGP SIGNATURE----- --------------6fkCioUGQkjyRoZzh4hlkvgS-- From xen-devel-bounces@lists.xenproject.org Thu Nov 10 16:07:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 16:07:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441987.696030 (Exim 4.92) (envelope-from ) id 1otA5k-000331-Lk; Thu, 10 Nov 2022 16:07:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441987.696030; Thu, 10 Nov 2022 16:07:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otA5k-00032o-HI; Thu, 10 Nov 2022 16:07:48 +0000 Received: by outflank-mailman (input) for mailman id 441987; Thu, 10 Nov 2022 16:07:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otA5j-0002n7-4u for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 16:07:47 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ce42f4e5-6111-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 17:07:42 +0100 (CET) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2AAFvJje017398; Thu, 10 Nov 2022 16:07:32 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ks4d581r2-30 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Nov 2022 16:07:31 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2AAFaWBp035073; Thu, 10 Nov 2022 15:45:26 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2043.outbound.protection.outlook.com [104.47.66.43]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3kpctfahdn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Nov 2022 15:45:26 +0000 Received: from BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14) by BN0PR10MB5286.namprd10.prod.outlook.com (2603:10b6:408:127::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Thu, 10 Nov 2022 15:45:23 +0000 Received: from BY5PR10MB3793.namprd10.prod.outlook.com ([fe80::72b3:f74a:9e7c:680a]) by BY5PR10MB3793.namprd10.prod.outlook.com ([fe80::72b3:f74a:9e7c:680a%4]) with mapi id 15.20.5813.012; Thu, 10 Nov 2022 15:45:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce42f4e5-6111-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=corp-2022-7-12; bh=0tIq+Nk9fP8w3iWkgsV7ZO05ZvnZbB65xj6iQU83LWA=; b=SAcskyplNTxQOltZwOHQeXIl7O72J0k/d1mousiQuZbMk3HTtSulh515Mg9xJmcdKX/B /yuZJHsSMR1yib3aISCytx8IUW69KbiRKkRjMvFAh0IqgaIwg7+T9k8MSOuogOLtsraG 1yaZSMk5T4W+DG/I+F0lmUzdY0lqPcYaEwpKZL7Qv4GdA2FxQWn0HU48mf6s/kG8+93p 572nBUkbe5Pu2NQoUikuhDQQayylQyhlM5JQKJ9JX+/w34RxQM+O9inQ3S5NqZoJ2lY6 rmBmQqvPzL9rwTsDa/QG2f6IjMzC5NNunmp4IVgHu+a3cFT+jaDD+s+xJtpYA7LdLFgn qg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hk94l+0YDzJMJ996aup9FtDik88ppQAy9rCYbBMWv68M3Llcpsp6zDCDxZxa8aSbPN/jk9fQH5IIK4zf/Kk47VRPsrUlxt1ZvYR6vKifhoaZxu2yRXicuEqUuoMpyhTGGNeKuOAmvzaAZg1t0I65H4xly5YQ3Ko7QvNPSrhVWiA+sGZYzjzEomPtSx0/MRVs7Ka2u5jLU23UvNxouu8uflorfp/D8YsbHGSiFGpRWWr8RYF3U08FHSbQUAzkIiN7asEt8Qdyuc9BwLE50ADTyL5GiEz3ycIjz/BtOxj+xmaDA3qwLYQ3Mh4LMCCrqw7HpVKEYpMftQc72BKb2HGluw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0tIq+Nk9fP8w3iWkgsV7ZO05ZvnZbB65xj6iQU83LWA=; b=FlHMlHiD4W4zC5brSuC6h32f4z7fTE371qOPBZF9UFux5D7UMgyqZXCsWxODVOG5oDFlDgTugpxjrnuEOXUhym6LL6++KEXntn2dhnBk7WHrVAD+8wPMIrR50+B1K49KhI5KdVhOIRQuAuvDlWAWWtZ8UgMjaLXBR1xnAYgzoiHE4XRkglCCtxb+l9uAGCV/d/e+qLEAqHsAmUsLmTYBS+nz7kyzj+4gsvXZs1ciTuPBWtjkFgi0MKAuGNtp0beloZp0ZFF4u67MlaWUkXRQevT481UxcowepHPPY8cKrA8tnQTTpVIneqKY6P/4cn28NmQzEpy3LCuquuTo618vow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0tIq+Nk9fP8w3iWkgsV7ZO05ZvnZbB65xj6iQU83LWA=; b=aVMcad4g66TYhg1YlYzTZCwvP6l8fHRjvb/pmPYvtLoAiMU+z1pnyvKvM3PqXtAb7HC7bQBbnXeqB9bfrEF1/zoS2j9N+26RYifwKNphoSu7B+40IE9GCxmioxONTsEwJRrOZ56zep/vI7DLknV4bEWQRlZ6f0OYFA45Jeeliok= From: Ross Philipson To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: ross.philipson@oracle.com, dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com, jailhouse-dev@googlegroups.com, jan.kiszka@siemens.com, xen-devel@lists.xenproject.org, jgross@suse.com, boris.ostrovsky@oracle.com, andrew.cooper3@citrix.com Subject: [PATCH v2 0/2] x86: Check return values for early memory/IO remap calls Date: Thu, 10 Nov 2022 15:45:19 +0000 Message-Id: <20221110154521.613472-1-ross.philipson@oracle.com> X-Mailer: git-send-email 2.31.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SA9PR13CA0173.namprd13.prod.outlook.com (2603:10b6:806:28::28) To BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB3793:EE_|BN0PR10MB5286:EE_ X-MS-Office365-Filtering-Correlation-Id: cdc44359-3b45-4427-9eac-08dac33294a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: If/RgOQlPiPi57BbY+nwagCaBxGqJLuUX5nCtb5wU7Lt5fuv7+K3sVU9NRWa9HSgKGxg6IRNL0k0iTNbhhTRZL/xucHh57J5zqvRfKMCiD2uwHy+NzOXj6cfpwY+sAiTBslpeJ3M4+7UVLg/zC0PtIxur3xy95l6gIvJQl60Y6RbJVzrwNkvPnM90872pfkLvzDPQURtPfKriZpQZiglfGsPSiHPTKnhHV/VDxzcP/mgTwRCPDFWHJ2nxCf/DO6MX6hHtnh+TCD/WP47z7J74/kmgL+5Lk76977fhT156AEFMGMQUZbR4RXAgd2mS8B45X5oYRr62PEflU94H3hbDaqEb+SZNA0wyfzX1OG/L9FLjV8BPamJkuDbgSxNW+1twrBNiTMf0QD9qGcnOR6/E5jaDESzcdJ2oPl1QsbE/u/zcC/1O/+MX36ozVNjTf94Wyc8BGXRlrwQOOtHQJwZ6TQGrLl90olImT39a0Pv00Cxg2W4EvnvfyqLD1ZOxHJph3RpWV1japI6nrnPyIiJj1zTtzELXJZZOTiu4kWHI5IGwiL8S+MeiXyAOiroUHhhBSjry9oX9B6CBP681oElQJPLjN6eHP86hvPNfJ03Ky5kBjrNUoTI4Acea8LPWGsG3sSqyq6RlZlJOvA+v54lm+R7aMZVFFe6t1t0ZLIW7j8pyT4MokTbZV2p1eOqNRgUUyiXWE9ioDcpQaii2miZ6g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB3793.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(396003)(376002)(39860400002)(366004)(451199015)(86362001)(7416002)(44832011)(8936002)(41300700001)(6666004)(6506007)(66946007)(2906002)(4326008)(8676002)(66556008)(1076003)(5660300002)(66476007)(83380400001)(6486002)(316002)(478600001)(2616005)(186003)(36756003)(38100700002)(26005)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c9VomFaLbZSYbYnPXlqTqw/Q9tgio1lZBkDZYLNnVKK9MVs8PStlEl8CyRnj?= =?us-ascii?Q?MeU4Yx//JFLRiqLyUptwuZ4B5QE3AlaDMEDlIRKtA15IbRKrAc07OCNi76w3?= =?us-ascii?Q?8IaKP004Q5KhRjXeu6CWv6vkGDOlBJ44hVSEXv8Hj3TV6rAmZG06VlZPN5Zi?= =?us-ascii?Q?1TsMbI7Temed44F6kxXz418siuG93JQFiEmVJHznXEZJJwk257dHfTjfBj5r?= =?us-ascii?Q?EJdVrOYqWO+Mjl586nhMZcTluxAXty5OvWntNan+aLzIpy2siP747+Xr8gvz?= =?us-ascii?Q?HRkkZl6Zstmmpo2gPcWR2fvS2P9K5Qndu/03v7O8XnWn7GxvqZ9yK6BBOsOc?= =?us-ascii?Q?1Mux3nc1C/dJh3kpl39dmIlbjel7EGpQ45KveALBzf2PyQlKvRIiPL76mCGJ?= =?us-ascii?Q?IUK/Tu8JwtbH7+QvjC8ndhBYvUUjBl9278RKt/zOgP9ftFlXFB5XB+aWR5Kh?= =?us-ascii?Q?kYhwGE75317ItO5wmGHNXBayV+fM9N6VJp3KnySW5nsp5TxjQtwlXkFF/rKF?= =?us-ascii?Q?wn68bDp4qqWac7UNgAui9qf54pvtTxa+1QIuVnyRB/MUDDJaIRgcQnnq4Iqg?= =?us-ascii?Q?6GCBFyz0q1Xlhn2M5kS+3+4vZnA3eCB36tFgWp/gFzmpEd9cVvYnKL32VDsc?= =?us-ascii?Q?Xnsk0P4uAteUtjTkS33LxkVC1eqbfLQhITAl5oUPWeGwIkY6vlRw5No6DBPL?= =?us-ascii?Q?9zQuSeIhu9T98mxim0BkkpNYWSI4zn5ye59qdtwcayz9zo4NDpSFO7cGypiE?= =?us-ascii?Q?1Rfw/xBNk6qkBEJeIR8klEaR2AtCE17rjOWKxittq3y5/f7aZQnmk2B1zEhK?= =?us-ascii?Q?TY1UckGs+mhqeIOdvfAHJl4t02F7zd+ygrjwBos9ah0sFMToUrVjRe4dwxqq?= =?us-ascii?Q?165PQ6FODsGexbx3VLt04SoF8yWuCQO611jwjnXGDfv01Xfgl8c4LMU4lA0d?= =?us-ascii?Q?aaXFNDq2+aNnNtjx2Jd9dIvZl99X2TbX72Rf+3xKV4vDr0uhcgYTIa8c/03V?= =?us-ascii?Q?xbWjaCszMApzxXMG/YYsnzfd7DFB2Od2jTJkECvVETn/+Cz6jDba4WBkrpo7?= =?us-ascii?Q?aGVp+/74DUF/ubFsqGBFmyRkfCHeFqX6xFFGmxecrlF3/M473FtG0wVaGSeS?= =?us-ascii?Q?aaOJgRRQ3dAXkmoww1WZDXswV1Z2MKX6QdPIgiEjXdYvYBX+lodW6/bR9mmb?= =?us-ascii?Q?mvbT169N8po3lBz2AeAOhHL2poGGGbwvu0X10NFGPV/ucl2kY9+WeuFG7WYj?= =?us-ascii?Q?BZRG/JHgKoegSOjzd8FFITjOtPXxugCvnDRY7PLrrelN+gISNh4pE7sShYth?= =?us-ascii?Q?MvdzhYwYvYyKqfgzOD1XuozuTu3drmTSbmahxDGg7N9r4XQiSetUDNgCf6N1?= =?us-ascii?Q?K9itbahGppdSqwZ+AqWKQic81MNRysZDg17SaYNAmLncHvxwAtvW1X+gUgLK?= =?us-ascii?Q?IYI825WEZ+HvgGPUs+BxGmDB+k93/N2/6WkWYLCrxgbizvgezilKJ096S9t2?= =?us-ascii?Q?wxUbAzdTiDpnM6/ORAxnRlunoH0zY/DMNMh0hgsx48g54V1Dj1Sxz1e1PGrW?= =?us-ascii?Q?jglH0JMI/HfyxLOu1vDSYelVZRd8yUXHW/UbEn/YcdwP2fahujp5nUPsqrVD?= =?us-ascii?Q?Ug=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdc44359-3b45-4427-9eac-08dac33294a2 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB3793.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 15:45:23.7687 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FTpsJqvgszOxPEqQJ1cBZvOT1BDwD+x6B3L2yepoXinaxA7A6yt17UrNQIFxXFb+04eUFwZ8HC3Xo/XV9xiYABXTA5RQ/3+EL+dxEZaCnMY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5286 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-10_10,2022-11-09_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxlogscore=694 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211100111 X-Proofpoint-GUID: 5ZCQR8N8QRNY8JYeYDKOaztjqMhOmB2S X-Proofpoint-ORIG-GUID: 5ZCQR8N8QRNY8JYeYDKOaztjqMhOmB2S While sending an earlier patch set it was discovered that there are a number of places in early x86 code were the functions early_memremap() and early_ioremap() are called but the returned pointer is not checked for NULL. Since NULL can be returned for a couple of reasons, the return value should be checked for NULL. This set fixes the places where the checks were missing. It was not always clear what the best failure mode should be when NULL is detected. In modules where other places tended to pr_warn or panic e.g., the same was done for the checks. In other places it was based on how significantly fatal the failure would end up being. The review process may point out places where this should be changed. Changes in v2: - Added notes in comments about why panic() was used in some cases and the fact that maintainers approved the usage. - Added pr_fmt macros in changed files to allow proper usage of pr_* printing macros. Ross Philipson (2): x86: Check return values from early_memremap calls x86: Check return values from early_ioremap calls arch/x86/kernel/apic/x2apic_uv_x.c | 2 ++ arch/x86/kernel/devicetree.c | 13 ++++++++++ arch/x86/kernel/e820.c | 12 +++++++-- arch/x86/kernel/early_printk.c | 2 ++ arch/x86/kernel/jailhouse.c | 6 +++++ arch/x86/kernel/mpparse.c | 51 ++++++++++++++++++++++++++++---------- arch/x86/kernel/setup.c | 19 +++++++++++--- arch/x86/kernel/vsmp_64.c | 3 +++ arch/x86/xen/enlighten_hvm.c | 2 ++ arch/x86/xen/mmu_pv.c | 8 ++++++ arch/x86/xen/setup.c | 2 ++ 11 files changed, 102 insertions(+), 18 deletions(-) -- 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 10 16:07:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 16:07:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441986.696018 (Exim 4.92) (envelope-from ) id 1otA5j-0002nK-79; Thu, 10 Nov 2022 16:07:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441986.696018; Thu, 10 Nov 2022 16:07:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otA5j-0002nD-4Y; Thu, 10 Nov 2022 16:07:47 +0000 Received: by outflank-mailman (input) for mailman id 441986; Thu, 10 Nov 2022 16:07:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otA5i-0002n7-CX for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 16:07:46 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ce24a1ae-6111-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 17:07:42 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 13E231FE12; Thu, 10 Nov 2022 16:07:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 996B01332F; Thu, 10 Nov 2022 16:07:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9TMgJNAhbWMSXgAAMHmgww (envelope-from ); Thu, 10 Nov 2022 16:07:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce24a1ae-6111-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1668096465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EV/Fk1WylZ737nbacAp1wmPRQUJJLl/hYoCm6tBJc+g=; b=nuCNQXMwMuX6G2Ywwfd8gVZ2wx1nduLSo8n016Ry6i7Ai2xJgEo5F7kImLJPYrEARtt5aR zicwAYOimOh1id6LFb/dlBRh8GSw7k/usqkL95l8ooNl96keOYmDkB8bWvVeTHxz228Hf3 LfdewH9uHlZDWLzRL7zi6eNVDMgxnhM= Message-ID: <66c5c5a8-7a8b-aefc-6466-c7d20236550e@suse.com> Date: Thu, 10 Nov 2022 17:07:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2 1/2] x86: Check return values from early_memremap calls Content-Language: en-US To: Ross Philipson , linux-kernel@vger.kernel.org, x86@kernel.org Cc: dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com, jailhouse-dev@googlegroups.com, jan.kiszka@siemens.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, andrew.cooper3@citrix.com References: <20221110154521.613472-1-ross.philipson@oracle.com> <20221110154521.613472-2-ross.philipson@oracle.com> From: Juergen Gross In-Reply-To: <20221110154521.613472-2-ross.philipson@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------mBxoMJgcAlsBu0oRWxNGGnrZ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------mBxoMJgcAlsBu0oRWxNGGnrZ Content-Type: multipart/mixed; boundary="------------dd6c6hUQlWDPpqABWqQLDgwl"; protected-headers="v1" From: Juergen Gross To: Ross Philipson , linux-kernel@vger.kernel.org, x86@kernel.org Cc: dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com, jailhouse-dev@googlegroups.com, jan.kiszka@siemens.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, andrew.cooper3@citrix.com Message-ID: <66c5c5a8-7a8b-aefc-6466-c7d20236550e@suse.com> Subject: Re: [PATCH v2 1/2] x86: Check return values from early_memremap calls References: <20221110154521.613472-1-ross.philipson@oracle.com> <20221110154521.613472-2-ross.philipson@oracle.com> In-Reply-To: <20221110154521.613472-2-ross.philipson@oracle.com> --------------dd6c6hUQlWDPpqABWqQLDgwl Content-Type: multipart/mixed; boundary="------------5DbFnzzLZhZ4rEqvlNR47BD1" --------------5DbFnzzLZhZ4rEqvlNR47BD1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTAuMTEuMjIgMTY6NDUsIFJvc3MgUGhpbGlwc29uIHdyb3RlOg0KPiBUaGVyZSBhcmUg YSBudW1iZXIgb2YgcGxhY2VzIHdoZXJlIGVhcmx5X21lbXJlbWFwIGlzIGNhbGxlZA0KPiBi dXQgdGhlIHJldHVybiBwb2ludGVyIGlzIG5vdCBjaGVja2VkIGZvciBOVUxMLiBUaGUgY2Fs bA0KPiBjYW4gcmVzdWx0IGluIGEgTlVMTCBiZWluZyByZXR1cm5lZCBzbyB0aGUgY2hlY2tz IG11c3QNCj4gYmUgYWRkZWQuDQo+IA0KPiBOb3RlIHRoYXQgdGhlIG1haW50YWluZXJzIGZv ciBib3RoIHRoZSBKYWlsaG91c2UgYW5kIFhlbiBjb2RlDQo+IGFwcHJvdmVkIG9mIHVzaW5n IHBhbmljKCkgdG8gaGFuZGxlIGFsbG9jYXRpb24gZmFpbHVyZXMuDQo+IA0KPiBJbiBhZGRp dGlvbiB0byBjaGVja2luZyB0aGUgcmV0dXJuIHZhbHVlcywgYSBiaXQgb2YgZXh0cmENCj4g Y2xlYW51cCBvZiBwcl8qIHVzYWdlcyB3YXMgZG9uZSBzaW5jZSB0aGUgcHJfZm10IG1hY3Jv IHdhcw0KPiBpbnRyb2R1Y2VkIGluIHRoZSBtb2R1bGVzIHRvdWNoZWQgYnkgdGhpcyBwYXRj aC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFJvc3MgUGhpbGlwc29uIDxyb3NzLnBoaWxpcHNv bkBvcmFjbGUuY29tPg0KPiAtLS0NCj4gICBhcmNoL3g4Ni9rZXJuZWwvZGV2aWNldHJlZS5j IHwgMTMgKysrKysrKysrKysNCj4gICBhcmNoL3g4Ni9rZXJuZWwvZTgyMC5jICAgICAgIHwg MTIgKysrKysrKysrLS0NCj4gICBhcmNoL3g4Ni9rZXJuZWwvamFpbGhvdXNlLmMgIHwgIDYg KysrKysrDQo+ICAgYXJjaC94ODYva2VybmVsL21wcGFyc2UuYyAgICB8IDUxICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tDQo+ICAgYXJjaC94ODYva2Vy bmVsL3NldHVwLmMgICAgICB8IDE5ICsrKysrKysrKysrKysrLS0tDQo+ICAgYXJjaC94ODYv eGVuL2VubGlnaHRlbl9odm0uYyB8ICAyICsrDQo+ICAgYXJjaC94ODYveGVuL21tdV9wdi5j ICAgICAgICB8ICA4ICsrKysrKysNCj4gICBhcmNoL3g4Ni94ZW4vc2V0dXAuYyAgICAgICAg IHwgIDIgKysNCj4gICA4IGZpbGVzIGNoYW5nZWQsIDk1IGluc2VydGlvbnMoKyksIDE4IGRl bGV0aW9ucygtKQ0KDQpGb3IgdGhlIFhlbiBwYXJ0czoNCg0KUmV2aWV3ZWQtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQoNCg== --------------5DbFnzzLZhZ4rEqvlNR47BD1 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------5DbFnzzLZhZ4rEqvlNR47BD1-- --------------dd6c6hUQlWDPpqABWqQLDgwl-- --------------mBxoMJgcAlsBu0oRWxNGGnrZ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNtIdAFAwAAAAAACgkQsN6d1ii/Ey/Z uwf9GfCYNTgYAn6tunrIu6M+RENPMwwvmUVC0CjrSU/ln3KvegZRL+VgXLxTe01E1j8c3VGle1xW tzawO3vkDoilvke4V7OwBvIWKzgUJxNboCy5d9B2TOPbjZTi1qediSlKKv8K5Rckxe9ff/GLhcMr yJzHkVbt8O1QzPN/sWEA0cKUG9DPRY5mKks9ysu1pF7gbaiRTKs8dSMg0q1XU7Cpaw33aozsaYlu DMfWdMzGQFfQooVaJzJl2nHQR6RSb5lKouJ8lps4g0dZzGoFLD3SUIKfiMhRwQFltl7ej8S6W8U+ j7qVorWMIVyGqkPQFDZhgGI89ST+XlCqNVonfOCz6w== =AnkP -----END PGP SIGNATURE----- --------------mBxoMJgcAlsBu0oRWxNGGnrZ-- From xen-devel-bounces@lists.xenproject.org Thu Nov 10 16:08:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 16:08:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.441989.696041 (Exim 4.92) (envelope-from ) id 1otA5x-0003Rl-UX; Thu, 10 Nov 2022 16:08:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 441989.696041; Thu, 10 Nov 2022 16:08:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otA5x-0003Rc-RP; Thu, 10 Nov 2022 16:08:01 +0000 Received: by outflank-mailman (input) for mailman id 441989; Thu, 10 Nov 2022 16:08:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otA5w-0003Nw-3M for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 16:08:00 +0000 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d60a0e6e-6111-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 17:07:57 +0100 (CET) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 08:07:55 -0800 Received: from csalvo-mobl1.amr.corp.intel.com (HELO [10.212.217.97]) ([10.212.217.97]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 08:07:54 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d60a0e6e-6111-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668096477; x=1699632477; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=JPp5EDDddCIcW0tICeOFfz4HE4lQV+wPxVcAIA4+K6M=; b=ILDFbCoRv6Z6ZC7iLQ9ZZQguYluYQVYF5GqmyeVSGICIGgeJLD3ErfCn Dss3ImDXR3PECBB5KGxxZ6/2IcQUZOoSvUKWoQ68rq1gfGDDnG4r4Q26o dUwDL80YenrAiRgomGAjjDR9il6GlJqmX4LFPCceojsOvt1EYW4ER1/zR Lwd+xAV7Wv+NRaMAkgKgAdxGvySu2C55ZhBHY5vbWVD5EQx7mtuNW1xgZ dMXvuKLon7WlrYSyr4FTUcjjLVFDmUiuoa22tTC6nbpgDaMjjLAF+L0C4 BjOP3fDOb284GpGqeKCn48bC1mu5J4po61XLh/MZ73JaFNN9hGL55kAMc Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="310063739" X-IronPort-AV: E=Sophos;i="5.96,154,1665471600"; d="scan'208";a="310063739" X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="631702730" X-IronPort-AV: E=Sophos;i="5.96,154,1665471600"; d="scan'208";a="631702730" Message-ID: <8e62a029-f2fa-0627-1f71-4850a68ec6b6@intel.com> Date: Thu, 10 Nov 2022 08:07:53 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 1/2] x86: Check return values from early_memremap calls Content-Language: en-US To: Ross Philipson , linux-kernel@vger.kernel.org, x86@kernel.org Cc: dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com, jailhouse-dev@googlegroups.com, jan.kiszka@siemens.com, xen-devel@lists.xenproject.org, jgross@suse.com, boris.ostrovsky@oracle.com, andrew.cooper3@citrix.com References: <20221110154521.613472-1-ross.philipson@oracle.com> <20221110154521.613472-2-ross.philipson@oracle.com> From: Dave Hansen In-Reply-To: <20221110154521.613472-2-ross.philipson@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/10/22 07:45, Ross Philipson wrote: > dt = early_memremap(initial_dtb, map_len); > + if (!dt) { > + pr_warn("failed to memremap initial dtb\n"); > + return; > + } Are all of these new pr_warn/err()'s really adding much value? They all look pretty generic. It makes me wonder if we should just spit out a generic message in early_memremap() and save all the callers the trouble. Oh, and don't we try to refer to functions() with parenthesis? From xen-devel-bounces@lists.xenproject.org Thu Nov 10 16:32:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 16:32:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442012.696056 (Exim 4.92) (envelope-from ) id 1otATP-0007gL-Vr; Thu, 10 Nov 2022 16:32:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442012.696056; Thu, 10 Nov 2022 16:32:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otATP-0007gE-Sj; Thu, 10 Nov 2022 16:32:15 +0000 Received: by outflank-mailman (input) for mailman id 442012; Thu, 10 Nov 2022 16:32:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otATO-0007fs-A2 for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 16:32:14 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3949d2ef-6115-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 17:32:12 +0100 (CET) Received: from mail-bn8nam12lp2172.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Nov 2022 11:32:03 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6545.namprd03.prod.outlook.com (2603:10b6:806:1c4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 16:32:01 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.025; Thu, 10 Nov 2022 16:32:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3949d2ef-6115-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668097932; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=/ajotvBabRkAJRa8WyNoPM3w5dHVQCnNTELU9LsS+qQ=; b=O1VjgkV3dOXuz2DY3uihIHFGGJfgw7TTeo3HLx6iRiv+ou3VFBIhkC2K 7lrbEjUuc8nZvVyBX3wk/lC31kp8680Fqe9ZDoV/yo7Vwhm5lZe5eGfVs TfOE8WMMtGSARx9zlslg5Kc6BWGKgAgYgHVIdH7WyX9vMUlKIiXycFOMI A=; X-IronPort-RemoteIP: 104.47.55.172 X-IronPort-MID: 83651182 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xxNJlq1BWPIEkHSv9/bD5c9xkn2cJEfYwER7XKvMYLTBsI5bpzwGz jQaWjyDOfeCM2Twed8lOoW/9kkGvcKBzdAyHVA+pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVnPagQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfCkpxx NckDjs3c0rbiaWRnaK6dPMyr5F2RCXrFNt3VnBI6xj8VKxja7aTBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvi6Kk1YZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r83bGSxHqrAur+EpW4zK53nFOUn1ciGQMkfwOckOKzlQmHDoc3x 0s8v3BGQbIJ3EiqSMTtGh61uniJujYCVNdKVe438geAzuzT+QnxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8rzyoPjMOBXQffiJCRgwAi/HvqZ8yglTCCNxkAIaxj9voCXfxx SyHqG41gLB7pc8R2qO69hbdijCqq5XSTiY64wzWWiSu6QYRTIKseY2kr1Wd5/FQBIefUlSF+ nMDnqC27OwDApaAmCGlWugBHLi1of2CNVX0hFd1HJY78C+2032uZ4Zd5Hd5PkgBGs8CdSXoc QnIuQ5P759eOnitRat2ZZ+hTcUs0aXkU9/iU5j8dcBPZJlvfRTB5ChoaVSNwWnhmWAokKciK dGad9qhCTARDqEP5CKyTvsT1qUugywkxH3eX9Xrn0qPz7WTfjiWRK0DPV/Iafo2hJ5ouy3Q+ tdbcsGMmxNWVbSkZjGNqNFJa1cXMXI8GJb67dRNcfKOKRZnH2dnDOLNxbQmeMpumKE9evr0w 0xRk3RwkDLX7UAr4y3RApy/QNsDhapCkE8= IronPort-HdrOrdr: A9a23:hBLtdq4lm0A39770MAPXwSeBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HjBEDmewKlyXcV2/hpAV7GZmXbUQSTXeVfBOfZowEIeBeOi9K1q5 0QFJSWYeeYZTYasS+T2njDLz9K+qjjzEnHv5a88587JjsaEJ2Ioj0JfjqzIwlTfk1rFJA5HJ 2T6o5uoCehQ20eaoCeCmMeV+bOitXXnNa+CCR2cSIP2U2rt3eF+bT6Gx+X0lM3VC5O+64r9S zgnxbi7quunvmnwlv31nPV7b5RhNz9o+Ezc/Cku4wwEHHBmwyobINuV/mruy00mvim7BIQnN zFs34bTrdOwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpOCfx2g4FhpVRwa hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvGrf2UIUh4bD3wXklX6vpREnBmc4a+a hVfYnhDc9tAB6nhyuzhBgv/DSuNk5DbituDHJy+vB96AIm4kyR/3FouPD3oU1wi67VM6M0gd gsEp4Y5o2mHfVmGJ5VNaMmffadLFDrbFblDF+ySG6XZZ3vfUi94qLK3A== X-IronPort-AV: E=Sophos;i="5.96,154,1665460800"; d="scan'208";a="83651182" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M3oXtMg77lXL9aexkF0fEWovV60EY6CZfI++HBlXsWzr/Z/DSi+/Bs7dcr6vMW+LGj5DgKOPRl7ufyLPxJlR4lFo8/53E5SkoH3DW+c/t5RkqClUx+jHa12FeqnhgRRqmrhWeWayq3hZiBvi6Vssa6gxTZu/ee8iANttu9Cc8bsP3gPypzC1kiLOkV2klxacLjYsuwY7AnXgnCvAcjhh9xSpnnhoMBpa1fUHP3B7VR0fKagVZOzZbfuVcwv8oZvFYXsiJQ4UXUE+xvCKB1t9/ipdV5bLKp/eTko58lKf4dC/OC6XAqlZ2WeHaeH0Dc+aG9YpPQO9HzfVB9kUMQI7+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=anhVgeEpURpP2uRlzZ2W5M+ywycrkzKb3c1lNsONauU=; b=ODH52CuwS8nvfMmbbLeYwQb2zkEJ0MWvEo5MjZyx+dWrg4PBRQZYzWrM/ifHPGjVyR0z49C+DJt460xwaBKIzT10Sy9brexzLWbbnGxPbErEnD0EXKOAFVREz/ZLA1EPMYvCVgR+k4ZcCmStGDmNx32x1l5i2oYegs/5VwpKS6/8Xn/m0l0XM3cTqX+b4dUeCF5TwCGKI8K7J/aSxWnbFoL5lP+j/eeubQ0n6xo55JzdTF0KjcG7Mlb5XnhnQJNZAWvOq95I99Yadnkq4G9vs9+WRDxx5QQfwN5TJel1Qswmx6P38yRJLBXnutsqpKIQL8BDT1tFIX0h4XlFXAf/qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=anhVgeEpURpP2uRlzZ2W5M+ywycrkzKb3c1lNsONauU=; b=M+yd9u8UCzTeCFoJKiz50I7VGVcfXZyZhMje8EbZvnqB74dHbV+c0N6v+WSJ3o6KotR++e85V4LEuZ7txrBezbhf5OhWVRkAHe8TnP+WxqQPGNXBcamnDe9+tN2aNi9RTP+E+QpDdd/63DC3wqwtJgefKfYOASkqfPHv1WG0MdE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, jgross@suse.com, Roger Pau Monne , "David E . Box" , Rajneesh Bhardwaj , David E Box , Hans de Goede , Mark Gross , Andy Shevchenko , Srinivas Pandruvada , platform-driver-x86@vger.kernel.org Subject: [PATCH v3] platform/x86: don't unconditionally attach Intel PMC when virtualized Date: Thu, 10 Nov 2022 17:31:44 +0100 Message-Id: <20221110163145.80374-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0340.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::16) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6545:EE_ X-MS-Office365-Filtering-Correlation-Id: fb50074d-7b0f-416a-6aba-08dac339181c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3eBEcCx3nG7+hZ0i7ZYqER5qRygPZtLH0anPwtWdKqLGpQEok8n4K6xR/UeVnjx48OSx8IPx9tQa6tdqgKcX27xq4rRV1JP4A4cP21q7bOyAQJInINL47oHgZJHN8x9MHEPvRE7wlyXx1gba/8FERhqzTNstbvfF7leyGZH+xuysy6sKu2eqB1m2M+YkY9EUFRAzeQ6ZOcX5IvtzU4SG/TKuGZPzgkXgSophPb1XGCu/lWOc+FYueO1ySN+Vp3YvsZV5aeYOpqSqwW5zTxihdpRSNCGSDAAoTjnrEyOz4BDZjA7jm3suKjVyhlJH4BGI0XMKjCNE5Ii03SLVhHyxOY5mMDOhK8Y/yRoUdnlHtfXVTNiivvJT2xp20fvn6n0CgotlZiOtF15u8n9fbwThXtKW0LsYexYvBgsJnbR5MXC4K51jR2Bu5l47xvWEH7W+PdeQ7N41HWXeLPN3TMKv3v2RUy8VwsUaDgSO7QYIoMkTG1ZNxIUEu6Wf6DptgMY5IosnC28t50pYA7t4ti+uau+vkCfvHZQSCb2n0vIlumdW9VECbELC827ktdueyaUKm1yWFXqmPp5JSA0yx65Y9036EDGOynBopDyjaKJO/lawTTajLw+aKJhJnp54T2hWD103EMBSRVZ/kI+tgZCjSb4DV0JM8FVIr0JSPzkm1fnyY0QAIgr+3fAYnT1wGwWMHCqtagao1QeMVaBgNrWlCw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(376002)(136003)(396003)(346002)(451199015)(82960400001)(38100700002)(66946007)(6666004)(66556008)(8676002)(4326008)(66476007)(41300700001)(2616005)(5660300002)(7416002)(316002)(86362001)(6486002)(478600001)(54906003)(6916009)(1076003)(186003)(83380400001)(8936002)(2906002)(6506007)(6512007)(26005)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGhpNnVaeG12aGdUcjRyNUZ2L0FpaVRHUHZwMWdVWG81eDRDWHJDMmUwTnY0?= =?utf-8?B?dXFpOThUK0tmK1JSenp0TDF6NXR6Tk03YlVSNW82dnhRWGF4RVVaVDNOWFVv?= =?utf-8?B?WU42TkRIcDNLZEM2YmN3OFZxMDIvQVhIaU03cmxHZW50clV6QmxUcWFacXN4?= =?utf-8?B?WGhTaGRlODFGYmxuNUdyZ3Zkais5NjhPZGNLUXBSaEZGS0hVcmZPcGZWMm9v?= =?utf-8?B?UDltT2JzZXRLNlJsOHhPUUM1Nit4VDJQcVFIakRDRXgrV1NFSEFuMmZza21P?= =?utf-8?B?TUc0ZTBHNysrdEdMaXhuZUd1U3F6SFBJN0pvQTF4SVB2M2RVdXRSMkhqV1lZ?= =?utf-8?B?Tm1yOEdUZWxWT0tIQkUyUVVCbEh0dmFsVytXMjh6bldrMGRRdXQ3WkFHRmIx?= =?utf-8?B?ZU8xdnozZkxubXZjci9nL3ZLVWZMY2lYN2cza2tleVNyTWtQZ3RzemVZZ2RP?= =?utf-8?B?blJ2VHoxRXJDYkZpUkpXNVhUSktEYjVORDRsQ3RyRHRUWExNOFh2VGMyWTJs?= =?utf-8?B?eXduSTVBR1BYajZTTDlxMzhHak9RdG53ZUs2R0NOaURLSVl6cmtXcENpaVRC?= =?utf-8?B?ZEFUa0ZRQmxPK3pYRERRcm50SHN5RGIwMmo4UjJWRlA3R083R045TUU0Z09j?= =?utf-8?B?UjhqYlNaeUthL3A3WmdEMkY4K1MvYVl3cVNDZitIY2E5Z0FNazRTN1Jwckx0?= =?utf-8?B?Ung5ajFxSmsxWnlxVWczd3c4cGxyRldVZ2IreGtCYnVUWlpvUWJlanRyUGYy?= =?utf-8?B?aURQb09WL2VFOWl5SHRjY0J1Y0RnNmEvbGxjZi9US3hGNXRSYjlJSkQ1ME9n?= =?utf-8?B?WlJaY3ZWaW1IRXFqZGtmaXlacTZFbGdpUm1jb0xCR3ord1hLU0dWcU5EL0Jm?= =?utf-8?B?S0x3a1E3Y0JLbkpsaVFGUG5VL0tpQTZ5VFNyQUlFRHNSUlFaU3NDRGsvcmNJ?= =?utf-8?B?dk50cG0yRERta2hJL1lZcTgxWGxRaWNjL2NJeVlBSXc5VzJnSWRya1FiNFc1?= =?utf-8?B?eEN3ZkZGcVBkMGtsUjhydTRnUmZWOHg5Z28wdGxZaEF4T25TVGI2K0JUbDRp?= =?utf-8?B?OGxPNWdONnNSSG1oTktxWGxoOU55L3BWd3NCVXk4Z01kb1J1Y3B1Y1B1UE5K?= =?utf-8?B?ZHlsbC9tQ2ovMnVXcnUzcitYM2tRQTE0Tm94RkxkMU9Mc1BGL0xENS81RlRT?= =?utf-8?B?blZyYk52ZUNDc0JnRzZFRWJ4TFFWUlFCQnhDcFZnL1RoU1A3U0hjWU1RUGN2?= =?utf-8?B?WldGWlhHMFF4am9YdmlFKzBiWFhtSXJGZVhLS3ZlTU1ITDZPdFpoQWk3N2RK?= =?utf-8?B?RTRvVnUzQTh4aXE4RzgvcUx1Y3pZZmRKYktuSUhoT2RKU204YXNhQTh6aEN2?= =?utf-8?B?cXRKUHlqOE8vUno3Nmt0ZW9ueVNaN0NIQmlzNCs5dDV4L1hhWXpRVExQMk50?= =?utf-8?B?QU51cVEzNDNSVFJpUVdKVmpWYkJZMUZGc1VkdURIWlB2bGo4MHlxYk1HTGFY?= =?utf-8?B?OGMraFl6cWttcUs4dFFyTnNKU2p6a25LaHVZZXlieTcwRXlNbnY3RzBxWENl?= =?utf-8?B?b1lRUGJTcU1GNkhIMDNsK1UzZ01NSllkd2QyZjhYSmZmUzJDWGxEbEhITTdK?= =?utf-8?B?QXliOUtYM3lXZUZZMUtvemZQYWpQVysyMXFmQnRzN1Z6Z1FoOHJ2Z3VlZ1Fm?= =?utf-8?B?NEhHSXkycnZ2RUNOaG53d2FTVDBlRTg3ZVlBcGZETnpLSkNtRWFHRzM4V3l0?= =?utf-8?B?WDJ0eDJPL1g5TjVlNncyb0ZaUWFCc1hCci9DWFkxSmZyd2dUZlBTWUV6akx6?= =?utf-8?B?eDZRK1F1TG5oUVJJb2VpaTZYMGdNNzJEQ2N0TnZGZmZOajRhek1lOW9PQVdp?= =?utf-8?B?MGNuTUdiSVpSU0luZmJRUEl3eWZWL2xwRUdxOStkREZvWWxXNFVxQnZUaW5L?= =?utf-8?B?bCtib3dpYmUzalZSdUgvNnFET2hlRGkyNnhIaU9vUmVWMVpkWkJOQUdLM29P?= =?utf-8?B?SjlYaU9BYzA1cXlBM3JrSGtzWDlWWHRiODBCRFVXM2tXVDM0aU90OGl3T2w2?= =?utf-8?B?UlM3ZVh1T0tEb1JCU0s5STVacXJtQVlGcEpxOEtrV1F5dU5qQjY0RmRFTXp4?= =?utf-8?Q?3PRxgG5LElyEcln+tGovTnwk1?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb50074d-7b0f-416a-6aba-08dac339181c X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 16:32:01.3913 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uz8xCiazrWtnLry56VlovYblzxRaMoZzgPw6qcCxWQdDJui1lTe3yuJxWY+byHmQ3TXarxL+mPbclyFsoau+/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6545 The current logic in the Intel PMC driver will forcefully attach it when detecting any CPU on the intel_pmc_core_platform_ids array, even if the matching ACPI device is not present. There's no checking in pmc_core_probe() to assert that the PMC device is present, and hence on virtualized environments the PMC device probes successfully, even if the underlying registers are not present. Previous to 21ae43570940 the driver would check for the presence of a specific PCI device, and that prevented the driver from attaching when running virtualized. Fix by only forcefully attaching the PMC device when not running virtualized. Note that virtualized platforms can still get the device to load if the appropriate ACPI device is present on the tables provided to the VM. Make an exception for the Xen initial domain, which does have full hardware access, and hence can attach to the PMC if present. Fixes: 21ae43570940 ('platform/x86: intel_pmc_core: Substitute PCI with CPUID enumeration') Signed-off-by: Roger Pau Monné Acked-by: David E. Box --- Changes since v2: - Don't split condition line. Changes since v1: - Use cpu_feature_enabled() instead of boot_cpu_has(). --- drivers/platform/x86/intel/pmc/pltdrv.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/intel/pmc/pltdrv.c b/drivers/platform/x86/intel/pmc/pltdrv.c index 15ca8afdd973..ddfba38c2104 100644 --- a/drivers/platform/x86/intel/pmc/pltdrv.c +++ b/drivers/platform/x86/intel/pmc/pltdrv.c @@ -18,6 +18,8 @@ #include #include +#include + static void intel_pmc_core_release(struct device *dev) { kfree(dev); @@ -53,6 +55,13 @@ static int __init pmc_core_platform_init(void) if (acpi_dev_present("INT33A1", NULL, -1)) return -ENODEV; + /* + * Skip forcefully attaching the device for VMs. Make an exception for + * Xen dom0, which does have full hardware access. + */ + if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR) && !xen_initial_domain()) + return -ENODEV; + if (!x86_match_cpu(intel_pmc_core_platform_ids)) return -ENODEV; -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Thu Nov 10 16:47:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 16:47:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442023.696067 (Exim 4.92) (envelope-from ) id 1otAht-0001FD-Eu; Thu, 10 Nov 2022 16:47:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442023.696067; Thu, 10 Nov 2022 16:47:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otAht-0001F6-Bv; Thu, 10 Nov 2022 16:47:13 +0000 Received: by outflank-mailman (input) for mailman id 442023; Thu, 10 Nov 2022 16:47:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otAhs-0001F0-6Z for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 16:47:12 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130040.outbound.protection.outlook.com [40.107.13.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 51d6912a-6117-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 17:47:10 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8840.eurprd04.prod.outlook.com (2603:10a6:10:2e3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 10 Nov 2022 16:47:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Thu, 10 Nov 2022 16:47:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51d6912a-6117-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YXBFYXKPP83Bvnc6R/izr2x3zbUqKPju6Hdr1AYFV5koMkbGBWrOjuEKMCs3WJnNzhTw+K/JBKB8wKcWYpyrXjwIEyAC0aCk1CGh2rda7ymQzik3/wdbR6Pbk84ygbNN7WQDcAIA03r2t8yuXpKIULQI9kljRubhoU0LL2emIXhDysUwm7bA9zVWjUD9pxVuV2DZDenRmQhQ+EqISU6WbjBH1quVOJJTKRtYWqeiIZU0nsNnGrZXyvn6GPWqQ2bKQt2xuPYNWL8l5AmahazRhh/l31QWfXO9yV+Gh4YxQeefAeCH0dtUhup/WiTajOkH+gb23GMZqOTRE5+DrVuEyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5lKcOLx4akakoXrqY8U5a0xwc8cdQmoFqA3mntJ4N3g=; b=RIiyK+KMip/qCDYyKm+89qzPQlgBXg/8KZ8Uug43rba5mXUArLsKxng3355BtNiqoarHeJ+ASZ7iEuVt5R6H8i+GEE/Op22fkyC7u6+jC1DMyqdVhqtD92iHhi01rNxcuZZ7vOcKqvAFWeUZSZjSYd6Wrpjt7qyeXXfu3DtREEX4elIhsAVlDnRfIV62NuQPjZvf4fkX4FxKgNpVorwm+SvczRLVL5OwTGF5kSAGvb8wFL2227HvbhAnFlxye7tqzABUN6uMIxx+8d/fVPIhzaeS9s5ktafLcOBVIjSwRHIrk7/sYKaFRbDPgH7ajHSsgI0bLihKhmgBj06nHVGoYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5lKcOLx4akakoXrqY8U5a0xwc8cdQmoFqA3mntJ4N3g=; b=tdGLbV66CIDq4G1HBX/Be1Jd6Rw/gtSw9AYbqnNylSEWv3Nn9klvVEeMERGMER+7aFyYnUGlSO3zYtlcmOZIKa0h8h8dCrWi/E1AUoTvl3l+NOxUeuyyezQKDOQ1FZ8WV7gJz8WdUZ0uuPtnrJWr/MWw5JMfwGTwqBbrvuSFR5C0CDezgXD2xR/V+ymhxY7EhBuMKniDikXt/oGvps7fZa79jF7qsYt6M8zCcWR+oP3wtjLRQq+kd8L5hvQ8XcipRA1p9qB/u9Mq326FcLpRR7ylhyammo55nruezo5HOMaTj2mAYTUxUd1HtoSyHf2TeOGApS3IOQ49qbYV84xTBQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 10 Nov 2022 17:47:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v3 6/9] xen/common: add cache coloring allocator for domains Content-Language: en-US To: Carlo Nonato Cc: marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Marco Solieri , xen-devel@lists.xenproject.org References: <20221022155120.7000-1-carlo.nonato@minervasys.tech> <20221022155120.7000-7-carlo.nonato@minervasys.tech> From: Jan Beulich In-Reply-To: <20221022155120.7000-7-carlo.nonato@minervasys.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0062.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8840:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ee855d0-adbc-4e36-f6bf-08dac33b34a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c5PJVBPJ8IpJ/xJWU3dVNmSPkMZahoe9q7gSlf27jJOBMI6Ii7abZ7sDNr5zdtVw+AgVKOPhAQgA/V9F1QLaAxWfhbtB9sLexQOClHGFvoBloGvqnMpRvvllD0l//z0khsWmoLe71mAYjY+FnNzMGKPVzZlJ4swToArHKJCPmTEBsM6NQ6dH74YJAUpCO0N8GA2sFAhqMwGutUV0JvBnzol3E35LgRbHPztBAKJ5DYLasEkUGUjmN/20cEAcXfx3XVzi92ny6/pH2O4xkV24QpKGpNtoaJVtW92Ubi2Y3JbTAoNYdL90I3IjxpDPwYTj7l/Pwtyx3EVYz2+zWgvpHiGzFMp9seSUmOtnko6JWOCrb0OLCKfgsJ8QRFk/a3YVhUxMtRpLfCqYCQ3L8oz9u8Mrs+jAq2Rpw2UiPl6AA7Li9aqKVh26yYEyeUtPzXwDbEjOOABtnrpgZiXL3XDDpfK/rsl94QOoiWFrIng8DzYdo/EoYWQHczUvf7LYK5wbFt7IR5KsR5OaLNzE/dlqjexeKcbGg3l1wTeXDE1w7eSTjlPZbEpEJpYubb/p39ObnfjTBWMfb9nLQbQq2fiuPn6ujYVJuW/xL8Bj+UP7I/sGUckwgeoxmaNvGq92CupOwin4j3hNbEbC8spuQ4gM1Q1mmgiWeqIanXXd7mV57RprDcd7EnaVEvUqgZ0oZ4ggtpTibyqGMHFZ0I4jYQzGOgKo5MTj1OiaN7MLfgNv0BGB2nS/D3A7OIq0biA1Fo5f/sTD64q1eO9dcav01f4p+3KphM1R1bEQJP5h9/VUQQ8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(346002)(39860400002)(136003)(396003)(451199015)(83380400001)(86362001)(31696002)(478600001)(6486002)(38100700002)(54906003)(41300700001)(8936002)(4326008)(26005)(5660300002)(66476007)(8676002)(2616005)(6916009)(316002)(66556008)(66946007)(186003)(6512007)(2906002)(6506007)(53546011)(7416002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzV4M1pCM3VoNmtNendUaHpsMG1ZS3BOV1dMd3J4cTh4MDlZTkU5UTVBT1Zi?= =?utf-8?B?ZFE2ais2Qk5BR3FiVTJFR1BxaU9zQzhvWDZobXU3ckw3eGhUV1RpMzFTWWhM?= =?utf-8?B?TzdvcWF5cTFZRFIvVmF5RVcrOHI5ZmtQdFJNUVBnR2VVTDZFU1dtOUU0QmVh?= =?utf-8?B?dmdNTFNlVyt0YlJWbXF1SmlUUGdJZzBROHN1OUJRbG5SVzhIc0RpR0xodlZN?= =?utf-8?B?eUYrdmJuZk5ta3BvK2h4NFVSM3g4dXRrU2wvc1NOZXhTREsxajA5bzNtc1Bm?= =?utf-8?B?bkJGeXVOcXZSR1lhZ0ZxNXFiSUczM1BLejVMVTExYnN6eElUbGNUdVpVd2hy?= =?utf-8?B?TEZpbjhlUmVJNkVVVTIreHFaOHg0N1gzSHVNWDJXc051L2JKazQ5L3krTU9j?= =?utf-8?B?VGx5ZWRBN3ZNMEJLOEZFNEJ2OHNQTUpJYjlES0FhNmV3enVKcExsR3pNMDl2?= =?utf-8?B?cWlYRE8vNVdTWlVXbUprdGczUEdkeWIwTmhLcWl4V202MDVZVjluRXd4Zjdo?= =?utf-8?B?MlNuWlFQcUUvNTNGWk1la2xKU0c2YVpUUmFCMnZDVFhieFpzaTNZSnVqeXZP?= =?utf-8?B?em1udDZvRUh0TmNWY1BJaExGWmhhZmRCT0svcG9IZER2QXdnMGhTTjdVeXhH?= =?utf-8?B?NlhyR3U1d1hFSzJUZHROcXNJejZiWE8vNjlJdndoMHN0OStPVy9FaXVNcnVO?= =?utf-8?B?S1NPZ2VqMTBvZlc3MEs5bUV3SWVzRExrUW1hYWNuOTlKM1EzNzdPbzNTcC9C?= =?utf-8?B?cWJtWWw4VW5VZnJZaU9vZEtVRmZpdUUrendEd25ReWlQQUw2NEZmdGVzMTNG?= =?utf-8?B?U2RRRS9yK0hDVEg1eFlxbmJVOXE1bWNnVGpneEdyVWhGVENzMEs4RWdDT1BS?= =?utf-8?B?VVpxbG91TU8xcWxSQk1kS3FEOWdrTmVzdkhYdTJ5VlZ2Z1lLL1pORCs0azhi?= =?utf-8?B?N0xEVWNMS0RjR05Cc3FweVZuTkRweC93MGtJU0xsQ1NhQ0JzcXdHc1ZzcGlM?= =?utf-8?B?U0lXd01TQUVUU2tlMzlMY0NXbElIVlZqcnRRWjhFMU1ZQjlZRThjRm1kQkpz?= =?utf-8?B?M2NQYmZBNTJZbzFIVnpOeVN3MWN3Q05wWkp0SUsxTHRqSWd3TE9pTmtsMkZq?= =?utf-8?B?NHU0aUJ6cDJXYUE0SC8wYUMyc1o3TG9vaEloS00yaTl6NkpYRW44R2ZvdHVK?= =?utf-8?B?ZUFha0VmR2QwMnJ4RnFYaklGeDdTV1RJWm1tWFNzOWlFWDMxNVVlNDYzdWJi?= =?utf-8?B?WG1TdlczUUcySk8rU2N5dzNTVWNROGMyS3JVK3VvdnBORHhaTUZnaUJuUGRk?= =?utf-8?B?TGRTZTFxWktIbkV1dkFZdCtpY09Jdm5STlcvTFZVZWU2WS8wWExEelk0SlhT?= =?utf-8?B?MkdmQVdGUUNhNEFmSW44dk5xdmZHTjRNNHMwZnFSWnFZa09aZzZRcEJSSkIv?= =?utf-8?B?WGVxVU9Ea04vTDQrdzZWYTJrWGNiZzRNTjRIMXVOLzdYZ0I2SkhTejU1NWJI?= =?utf-8?B?bjlHNDlzTlFiSG9uTFlkak5yMmZucDFxODNNcFMyQ0FJdnpqRDluS00rdXpU?= =?utf-8?B?Y1pnZ2puRUx5djhuUWxXeVczd2FXdTRCcnUwVnhqWHJ0Q1ZRSGxwT0pVQ2Vx?= =?utf-8?B?aEJvMHlOd3BGbWhDYktqalE0TlZob1k5Sk83RW42NG15dDA3eWNETG16dTdM?= =?utf-8?B?S2RvY0ZudEtNQUNwbkpON3VZR3JOOVc5L1JXMUVqYXlwV0kzVDY4RjJrc1Br?= =?utf-8?B?R1BjOXU4dUZxazRudjdwZFR1SHdxelVqKy9kUDU2cXZDTEdSRmJScjNESGJN?= =?utf-8?B?endpSUcxTWxrcVlFNlRuVU5zK29KWlQvU2hYa1FURytTQ0NHVC85N2pFS3hE?= =?utf-8?B?REdCWEtkeHZOdm5ZeUtjR1B5Wjl6TXJJM0VVTzdNT0ZsR3BUV2EyL3p5QzFJ?= =?utf-8?B?Z1FVcTZRZkVNb1o0MXhXb0JyUzZ5cTg4N2Z4VE9BOFZNVjJaWTl5T3VnQW5o?= =?utf-8?B?Y3ZFRlpiYThsOW9qcFVTY28rQzlsUi9zaVd1eS9zV25xQU8vWko0YW5zSksz?= =?utf-8?B?RUdTS0FOTFBhWmZFYVlLaHo5KzJ3OGNMVEF3bWpEbDAzdEhZSzE3Mm1EaGx2?= =?utf-8?Q?hlzkVUI0SdW/TlY054Ct78fsb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ee855d0-adbc-4e36-f6bf-08dac33b34a6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 16:47:08.4252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uZY9qgrQnRJftq92yBQh+ftFNy78mU41/QAnqawTLtveAFce9lXd5l1S9kpxIbeo5/bTWzO7K162vFY3yDV8PQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8840 On 22.10.2022 17:51, Carlo Nonato wrote: > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -661,7 +661,12 @@ static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry) > > ASSERT(!p2m_is_valid(*entry)); > > - page = alloc_domheap_page(NULL, 0); > + /* If cache coloring is enabled, p2m tables are allocated using the domain > + * coloring configuration to prevent cache interference. */ > + if ( IS_ENABLED(CONFIG_CACHE_COLORING) ) > + page = alloc_domheap_page(p2m->domain, MEMF_no_refcount); Are you sure you don't mean MEMF_no_owner (which implies MEMF_no_refcount) here? And then ... > + else > + page = alloc_domheap_page(NULL, 0); ... is it really necessary to keep the two cases separate? Also nit: Comment style. > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -150,6 +150,9 @@ > #define p2m_pod_offline_or_broken_hit(pg) 0 > #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) > #endif > +#ifdef CONFIG_HAS_CACHE_COLORING > +#include > +#endif > > #ifndef PGC_static > #define PGC_static 0 > @@ -231,6 +234,14 @@ static bool __read_mostly scrub_debug; > #define scrub_debug false > #endif > > +/* Memory required for buddy allocator to work with colored one */ > +#ifdef CONFIG_BUDDY_ALLOCATOR_SIZE > +static unsigned long __initdata buddy_alloc_size = > + CONFIG_BUDDY_ALLOCATOR_SIZE << 20; > +#else > + static unsigned long __initdata buddy_alloc_size = 0; Nit: Bogus indentation. I wonder anyway whether if wouldn't better be static unsigned long __initdata buddy_alloc_size = #ifdef CONFIG_BUDDY_ALLOCATOR_SIZE CONFIG_BUDDY_ALLOCATOR_SIZE << 20; #else 0; #endif or static unsigned long __initdata buddy_alloc_size #ifdef CONFIG_BUDDY_ALLOCATOR_SIZE = CONFIG_BUDDY_ALLOCATOR_SIZE << 20 #endif ; > +static void free_color_heap_page(struct page_info *pg) > +{ > + struct page_info *pos; > + unsigned int color = page_to_color(pg); > + colored_pages_t *head = color_heap(color); > + > + spin_lock(&heap_lock); > + > + pg->count_info = PGC_state_free | PGC_colored; > + page_set_owner(pg, NULL); > + free_colored_pages[color]++; > + > + page_list_for_each( pos, head ) > + { > + if ( page_to_maddr(pos) < page_to_maddr(pg) ) > + break; > + } I continue to view such loops as problematic. With them in place I don't think this feature can move to being (security) supported, so I think this and similar places want annotating with a FIXME or alike comment. > + page_list_add_next(pg, pos, head); > > + spin_unlock(&heap_lock); > +} > + > +static struct page_info *alloc_color_heap_page(unsigned int memflags, > + const unsigned int *colors, > + unsigned int num_colors) > +{ > + struct page_info *pg = NULL; > + unsigned int i, color; > + bool need_tlbflush = false; > + uint32_t tlbflush_timestamp = 0; > + > + spin_lock(&heap_lock); > + > + for ( i = 0; i < num_colors; i++ ) > + { > + struct page_info *tmp; > + > + if ( page_list_empty(color_heap(colors[i])) ) > + continue; > + > + tmp = page_list_first(color_heap(colors[i])); > + if ( !pg || page_to_maddr(tmp) > page_to_maddr(pg) ) > + pg = tmp; > + } > + > + if ( !pg ) > + { > + spin_unlock(&heap_lock); > + return NULL; > + } > + > + pg->count_info = PGC_state_inuse | PGC_colored; > + > + if ( !(memflags & MEMF_no_tlbflush) ) > + accumulate_tlbflush(&need_tlbflush, pg, &tlbflush_timestamp); > + > + init_free_page_fields(pg); > + flush_page_to_ram(mfn_x(page_to_mfn(pg)), > + !(memflags & MEMF_no_icache_flush)); > + > + color = page_to_color(pg); You don't really need to retrieve the color here, do you? You could as well latch it in the loop above. > +static void dump_color_heap(void) > +{ > + unsigned int color; > + > + printk("Dumping coloring heap info\n"); > + for ( color = 0; color < get_max_colors(); color++ ) > + printk("Color heap[%u]: %lu pages\n", color, free_colored_pages[color]); > +} > + > +integer_param("buddy-alloc-size", buddy_alloc_size); This would preferably live next to the variable it controls, e.g. (taking the earlier comment into account) static unsigned long __initdata buddy_alloc_size = #ifdef CONFIG_CACHE_COLORING CONFIG_BUDDY_ALLOCATOR_SIZE << 20; integer_param("buddy-alloc-size", buddy_alloc_size); #else 0; #endif (Assuming buddy_alloc_size is indeed used anywhere outside any #ifdef CONFIG_CACHE_COLORING in the first place.) > @@ -1926,24 +2106,49 @@ static unsigned long avail_heap_pages( > void __init end_boot_allocator(void) > { > unsigned int i; > + unsigned long buddy_pages; > > - /* Pages that are free now go to the domain sub-allocator. */ > - for ( i = 0; i < nr_bootmem_regions; i++ ) > + buddy_pages = PFN_DOWN(buddy_alloc_size); Any reason this can't be the initializer of the variable? > + if ( !IS_ENABLED(CONFIG_CACHE_COLORING) ) > { > - struct bootmem_region *r = &bootmem_region_list[i]; > - if ( (r->s < r->e) && > - (phys_to_nid(pfn_to_paddr(r->s)) == cpu_to_node(0)) ) > + /* Pages that are free now go to the domain sub-allocator. */ > + for ( i = 0; i < nr_bootmem_regions; i++ ) > { > - init_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s); > - r->e = r->s; > - break; > + struct bootmem_region *r = &bootmem_region_list[i]; > + if ( (r->s < r->e) && Even if you're only re-indenting the original code (which personally I'd prefer if it was avoided), please add the missing blank line between declaration and statement here. > + (phys_to_nid(pfn_to_paddr(r->s)) == cpu_to_node(0)) ) > + { > + init_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s); > + r->e = r->s; > + break; > + } > } > } > + > for ( i = nr_bootmem_regions; i-- > 0; ) > { > - struct bootmem_region *r = &bootmem_region_list[i]; > + struct bootmem_region *r; > + > + if ( IS_ENABLED(CONFIG_CACHE_COLORING) ) > + r = &bootmem_region_list[nr_bootmem_regions - i - 1]; If you want to handle things low-to-high, why don't you alter the earlier loop rather than skipping (and re-indenting) it? However, considering that in alloc_color_heap_page() you prefer pages at higher addresses, I continue to find it odd that here you want to process low address pages first. > + else > + r = &bootmem_region_list[i]; > + > + if ( buddy_pages && (r->s < r->e) ) > + { > + unsigned long pages = MIN(r->e - r->s, buddy_pages); > + init_heap_pages(mfn_to_page(_mfn(r->s)), pages); Nit: Blank line between declaration(s) and statement(s) please. Also: Any reason the type-safe min() cannot be used here? > --- a/xen/include/xen/mm.h > +++ b/xen/include/xen/mm.h > @@ -297,6 +297,37 @@ page_list_add_tail(struct page_info *page, struct page_list_head *head) > } > head->tail = page; > } > +static inline void > +_page_list_add(struct page_info *new, struct page_info *prev, > + struct page_info *next) > +{ > + new->list.prev = page_to_pdx(prev); > + new->list.next = page_to_pdx(next); > + prev->list.next = page_to_pdx(new); > + next->list.prev = page_to_pdx(new); Nit: Several hard tabs here, and ... > +} > +static inline void > +page_list_add_next(struct page_info *new, struct page_info *prev, > + struct page_list_head *head) > +{ > + struct page_info *next = page_list_next(prev, head); ... one more here (and at least one more further down). Afaict you're passing a NULL "pos" in here from free_color_heap_page() if the list was previously empty and page lists aren't simply "normal" (xen/list.h) lists. I don't consider it valid to call page_list_next() with a NULL first argument, even if it looks as if this would work right now as long as the list is empty (but I think we'd see a NULL prev here also if all other pages looked at by free_color_heap_page() are at lower addresses). So perhaps ... > + if ( !next ) > + page_list_add_tail(new, head); > + else > + _page_list_add(new, prev, next); if ( !prev ) page_list_add_tail(new, head); else _page_list_add(new, prev, page_list_next(prev, head)); ? > +} > +static inline void > +page_list_add_prev(struct page_info *new, struct page_info *next, > + struct page_list_head *head) > +{ > + struct page_info *prev = page_list_prev(next, head); > + > + if ( !prev ) > + page_list_add(new, head); > + else > + _page_list_add(new, prev, next); > +} This function looks to not be used anywhere. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 10 17:00:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 17:00:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442033.696111 (Exim 4.92) (envelope-from ) id 1otAuM-0004GR-Lu; Thu, 10 Nov 2022 17:00:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442033.696111; Thu, 10 Nov 2022 17:00:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otAuM-0004Fr-I9; Thu, 10 Nov 2022 17:00:06 +0000 Received: by outflank-mailman (input) for mailman id 442033; Thu, 10 Nov 2022 17:00:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otAuK-0002uf-TZ for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 17:00:05 +0000 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [2a00:1450:4864:20::332]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1ea114a4-6119-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 18:00:03 +0100 (CET) Received: by mail-wm1-x332.google.com with SMTP id h133-20020a1c218b000000b003cf4d389c41so3893540wmh.3 for ; Thu, 10 Nov 2022 09:00:03 -0800 (PST) Received: from pear.davidvrabel.org.uk (pear.davidvrabel.org.uk. [82.70.146.41]) by smtp.googlemail.com with ESMTPSA id j5-20020a05600c1c0500b003cfbbd54178sm9403666wms.2.2022.11.10.09.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 09:00:02 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 1ea114a4-6119-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=dhv0GF+4ldSl9zCEdd3fJE2z3jaTvmUFTFv68dRAO/4=; b=IRHDhysvNWJWMsqBjN/T1DE6hOaiVDieZCMNS0K82fU3npGmvQfhh2jR+bmXZy3lLW L4yCcXuLxxl8R1YGF58dI5Y50XUPGnXhdoMYyCNMJo0dfBaY4wmHMIrKjkuNcDggEbhg zTdgHcgGJZgmKsVpRgwO2O0JFKbeuPjzAE8cidqiA/qOpODgqhWumRrjCiBBiI5Kvlub bJg4CCaPWtv/Ewer0VfcGMMxB1LBvtdlhSCkigtRaFtuxYpIe+5/gsNjmwHmR7NmW9pR 0Jq64EdHo7lU0Dc2JmX58nJTbDH8Tkwrtx8iZoGZP6u2nC955WZ9twM64aeS4svzyrrv aiwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dhv0GF+4ldSl9zCEdd3fJE2z3jaTvmUFTFv68dRAO/4=; b=lEt8OCFO/S9DrHQ+0v2JR/Wrx+9Egm/R/ed68PwhC39jlmdENq/qWH+Pi1cLRm/ipu qNvhTOv8B2KtCR1JQyMEx7PbN/cHqgrOWKHzbvuGgknA8oHL/33NsvTuqI8ounwVi2Ib +60ltZYedXmk+wM6uNL/fFBFSrxAZXuQsXUUnwypIRKxcN8l0vEdfGq6RSdzMSlRgpmC O1/smy7+l76Gohom8fuvwsI1rknMLQUQmKZ8igok5ox6uZGTGJQCWJKOjYFVLekdVJ7l /qBNQR3Xu81WZ5F+k6ye060kciXT6CNlXudAXzsEr2IQHW+p0Ra7QhkS9m/UWd0hqV4D diOg== X-Gm-Message-State: ACrzQf2Dda4MINtYxJCZumi3hoqyhhLmqSwbErNOZ8HD6AY61slwYwrY gq5RK2cDY/4O8X2ze6UUg6+cqfcJhZPMGg== X-Google-Smtp-Source: AMsMyM5uvX6gpkkiFwXXfo8XmYbzXmlGMvesWd1fEUHxGEBga/cz37onbiuekcmb+5yuh8J7lsAsvA== X-Received: by 2002:a7b:c5d8:0:b0:3cf:9cd9:a889 with SMTP id n24-20020a7bc5d8000000b003cf9cd9a889mr20999323wmk.26.1668099603118; Thu, 10 Nov 2022 09:00:03 -0800 (PST) Sender: David Vrabel From: David Vrabel X-Google-Original-From: David Vrabel To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , David Vrabel Subject: [PATCH 3/3] x86/pci: Fix racy accesses to MSI-X Control register Date: Thu, 10 Nov 2022 16:59:35 +0000 Message-Id: <20221110165935.106376-4-dvrabel@amazon.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221110165935.106376-1-dvrabel@amazon.co.uk> References: <20221110165935.106376-1-dvrabel@amazon.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Concurrent access the the MSI-X control register are not serialized with a suitable lock. For example, in msix_capability_init() access use the pcidevs_lock() but some calls to msi_set_mask_bit() use the interrupt descriptor lock. This can lead to MSI-X being incorrectly disabled and subsequent failures due to msix_memory_decoded() calls that check for MSI-X being enabled. This was seen with some non-compliant hardware that gated MSI-X messages on the per-vector mask bit only (i.e., the MSI-X Enable bit and Function Mask bits in the MSI-X Control register were ignored). An interrupt (with a pending move) for vector 0 would occur while vector 1 was being initialized in msix_capability_init(). Updates the the Control register would race and the vector 1 initialization would intermittently fail with -ENXIO. Typically a race between initializing a vector and another vector being moved doesn't occur because: 1. Racy Control accesses only occur when MSI-X is (guest) disabled 2 Hardware should only raise interrupts when MSI-X is enabled and unmasked. 3. Xen always sets Function Mask when temporarily enabling MSI-X. But there may be other race conditions depending on hardware and guest driver behaviour (e.g., disabling MSI-X when a IRQ has a pending move on another PCPU). Fix this by: 1. Tracking the host and guest enable state in a similar way to the host and guest maskall state. Note that since multiple CPUs can be updating different vectors concurrently, a counter is needed for the host enable state. 2. Add a new lock for serialize the Control read/modify/write sequence. 3. Wrap the above in two helper functions (msix_update_lock(), and msix_update_unlock()), which bracket any MSI-X register updates that require MSI-X to be (temporarily) enabled. Signed-off-by: David Vrabel SIM: https://t.corp.amazon.com/P63914633 CR: https://code.amazon.com/reviews/CR-79020945 --- xen/arch/x86/include/asm/msi.h | 3 + xen/arch/x86/msi.c | 215 +++++++++++++++++---------------- xen/drivers/passthrough/msi.c | 1 + 3 files changed, 114 insertions(+), 105 deletions(-) diff --git a/xen/arch/x86/include/asm/msi.h b/xen/arch/x86/include/asm/msi.h index fe670895ee..aa36e44f4e 100644 --- a/xen/arch/x86/include/asm/msi.h +++ b/xen/arch/x86/include/asm/msi.h @@ -237,7 +237,10 @@ struct arch_msix { int table_refcnt[MAX_MSIX_TABLE_PAGES]; int table_idx[MAX_MSIX_TABLE_PAGES]; spinlock_t table_lock; + spinlock_t control_lock; bool host_maskall, guest_maskall; + uint16_t host_enable; + bool guest_enable; domid_t warned; }; diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index 6c675d11d1..8e394da07a 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -147,6 +147,57 @@ static bool msix_memory_decoded(const struct pci_dev *dev, unsigned int pos) return memory_decoded(dev); } + +/* + * Ensure MSI-X interrupts are masked during setup. Some devices require + * MSI-X to be enabled before we can touch the MSI-X registers. We need + * to mask all the vectors to prevent interrupts coming in before they're + * fully set up. + */ +static uint16_t msix_update_lock(struct pci_dev *dev, unsigned int pos) +{ + uint16_t control, new_control; + unsigned long flags; + + spin_lock_irqsave(&dev->msix->control_lock, flags); + + dev->msix->host_enable++; + + control = pci_conf_read16(dev->sbdf, msix_control_reg(pos)); + if ( !(control & PCI_MSIX_FLAGS_ENABLE) ) + { + new_control = control | PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL; + pci_conf_write16(dev->sbdf, msix_control_reg(pos), new_control); + } + else + dev->msix->guest_enable = true; + + spin_unlock_irqrestore(&dev->msix->control_lock, flags); + + return control; +} + +static void msix_update_unlock(struct pci_dev *dev, unsigned int pos, uint16_t control) +{ + uint16_t new_control; + unsigned long flags; + + spin_lock_irqsave(&dev->msix->control_lock, flags); + + dev->msix->host_enable--; + + new_control = control & ~(PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL); + + if ( dev->msix->host_enable || dev->msix->guest_enable ) + new_control |= PCI_MSIX_FLAGS_ENABLE; + if ( dev->msix->host_maskall || dev->msix->guest_maskall || dev->msix->host_enable ) + new_control |= PCI_MSIX_FLAGS_MASKALL; + if ( new_control != control ) + pci_conf_write16(dev->sbdf, msix_control_reg(pos), control); + + spin_unlock_irqrestore(&dev->msix->control_lock, flags); +} + /* * MSI message composition */ @@ -288,7 +339,7 @@ static void msi_set_enable(struct pci_dev *dev, int enable) __msi_set_enable(seg, bus, slot, func, pos, enable); } -static void msix_set_enable(struct pci_dev *dev, int enable) +static void msix_force_disable(struct pci_dev *dev) { int pos; u16 control, seg = dev->seg; @@ -299,11 +350,16 @@ static void msix_set_enable(struct pci_dev *dev, int enable) pos = pci_find_cap_offset(seg, bus, slot, func, PCI_CAP_ID_MSIX); if ( pos ) { + spin_lock_irq(&dev->msix->control_lock); + + dev->msix->host_enable = false; + dev->msix->guest_enable = false; + control = pci_conf_read16(dev->sbdf, msix_control_reg(pos)); control &= ~PCI_MSIX_FLAGS_ENABLE; - if ( enable ) - control |= PCI_MSIX_FLAGS_ENABLE; pci_conf_write16(dev->sbdf, msix_control_reg(pos), control); + + spin_unlock_irq(&dev->msix->control_lock); } } @@ -318,9 +374,10 @@ static void msi_set_mask_bit(struct irq_desc *desc, bool host, bool guest) { struct msi_desc *entry = desc->msi_desc; struct pci_dev *pdev; - u16 seg, control; + u16 seg; u8 bus, slot, func; - bool flag = host || guest, maskall; + bool flag = host || guest; + uint16_t control; ASSERT(spin_is_locked(&desc->lock)); BUG_ON(!entry || !entry->dev); @@ -343,30 +400,18 @@ static void msi_set_mask_bit(struct irq_desc *desc, bool host, bool guest) } break; case PCI_CAP_ID_MSIX: - maskall = pdev->msix->host_maskall; - control = pci_conf_read16(pdev->sbdf, - msix_control_reg(entry->msi_attrib.pos)); - if ( unlikely(!(control & PCI_MSIX_FLAGS_ENABLE)) ) - { - pdev->msix->host_maskall = 1; - pci_conf_write16(pdev->sbdf, - msix_control_reg(entry->msi_attrib.pos), - control | (PCI_MSIX_FLAGS_ENABLE | - PCI_MSIX_FLAGS_MASKALL)); - } + control = msix_update_lock(pdev, entry->msi_attrib.pos); + if ( likely(memory_decoded(pdev)) ) { writel(flag, entry->mask_base + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET); readl(entry->mask_base + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET); - - if ( likely(control & PCI_MSIX_FLAGS_ENABLE) ) - break; } - else if ( flag && !(control & PCI_MSIX_FLAGS_MASKALL) ) + else if ( !pdev->msix->host_maskall && !pdev->msix->guest_maskall ) { domid_t domid = pdev->domain->domain_id; - maskall = true; + pdev->msix->host_maskall = true; if ( pdev->msix->warned != domid ) { pdev->msix->warned = domid; @@ -375,11 +420,8 @@ static void msi_set_mask_bit(struct irq_desc *desc, bool host, bool guest) desc->irq, domid, &pdev->sbdf); } } - pdev->msix->host_maskall = maskall; - if ( maskall || pdev->msix->guest_maskall ) - control |= PCI_MSIX_FLAGS_MASKALL; - pci_conf_write16(pdev->sbdf, - msix_control_reg(entry->msi_attrib.pos), control); + + msix_update_unlock(pdev, entry->msi_attrib.pos, control); break; } entry->msi_attrib.host_masked = host; @@ -494,26 +536,19 @@ static struct msi_desc *alloc_msi_entry(unsigned int nr) int setup_msi_irq(struct irq_desc *desc, struct msi_desc *msidesc) { - const struct pci_dev *pdev = msidesc->dev; - unsigned int cpos = msix_control_reg(msidesc->msi_attrib.pos); - u16 control = ~0; + struct pci_dev *pdev = msidesc->dev; + uint16_t control = 0; int rc; if ( msidesc->msi_attrib.type == PCI_CAP_ID_MSIX ) - { - control = pci_conf_read16(pdev->sbdf, cpos); - if ( !(control & PCI_MSIX_FLAGS_ENABLE) ) - pci_conf_write16(pdev->sbdf, cpos, - control | (PCI_MSIX_FLAGS_ENABLE | - PCI_MSIX_FLAGS_MASKALL)); - } + control = msix_update_lock(pdev, msidesc->msi_attrib.pos); rc = __setup_msi_irq(desc, msidesc, msi_maskable_irq(msidesc) ? &pci_msi_maskable : &pci_msi_nonmaskable); - if ( !(control & PCI_MSIX_FLAGS_ENABLE) ) - pci_conf_write16(pdev->sbdf, cpos, control); + if ( control ) + msix_update_unlock(pdev, msidesc->msi_attrib.pos, control); return rc; } @@ -754,14 +789,14 @@ static int msix_capability_init(struct pci_dev *dev, { struct arch_msix *msix = dev->msix; struct msi_desc *entry = NULL; - u16 control; u64 table_paddr; u32 table_offset; u16 seg = dev->seg; u8 bus = dev->bus; u8 slot = PCI_SLOT(dev->devfn); u8 func = PCI_FUNC(dev->devfn); - bool maskall = msix->host_maskall; + uint16_t control; + int ret = 0; unsigned int pos = pci_find_cap_offset(seg, bus, slot, func, PCI_CAP_ID_MSIX); @@ -770,37 +805,22 @@ static int msix_capability_init(struct pci_dev *dev, ASSERT(pcidevs_locked()); - control = pci_conf_read16(dev->sbdf, msix_control_reg(pos)); - /* - * Ensure MSI-X interrupts are masked during setup. Some devices require - * MSI-X to be enabled before we can touch the MSI-X registers. We need - * to mask all the vectors to prevent interrupts coming in before they're - * fully set up. - */ - msix->host_maskall = 1; - pci_conf_write16(dev->sbdf, msix_control_reg(pos), - control | (PCI_MSIX_FLAGS_ENABLE | - PCI_MSIX_FLAGS_MASKALL)); - - if ( unlikely(!memory_decoded(dev)) ) - { - pci_conf_write16(dev->sbdf, msix_control_reg(pos), - control & ~PCI_MSIX_FLAGS_ENABLE); - return -ENXIO; - } - if ( desc ) { entry = alloc_msi_entry(1); if ( !entry ) - { - pci_conf_write16(dev->sbdf, msix_control_reg(pos), - control & ~PCI_MSIX_FLAGS_ENABLE); return -ENOMEM; - } ASSERT(msi); } + control = msix_update_lock(dev, pos); + + if ( unlikely(!memory_decoded(dev)) ) + { + ret = -ENXIO; + goto out; + } + /* Locate MSI-X table region */ table_offset = pci_conf_read32(dev->sbdf, msix_table_offset_reg(pos)); if ( !msix->used_entries && @@ -834,10 +854,8 @@ static int msix_capability_init(struct pci_dev *dev, { if ( !msi || !msi->table_base ) { - pci_conf_write16(dev->sbdf, msix_control_reg(pos), - control & ~PCI_MSIX_FLAGS_ENABLE); - xfree(entry); - return -ENXIO; + ret = -ENXIO; + goto out; } table_paddr = msi->table_base; } @@ -863,9 +881,8 @@ static int msix_capability_init(struct pci_dev *dev, } else if ( !msix->table.first ) { - pci_conf_write16(dev->sbdf, msix_control_reg(pos), control); - xfree(entry); - return -ENODATA; + ret = -ENODATA; + goto out; } else table_paddr = (msix->table.first << PAGE_SHIFT) + @@ -880,9 +897,8 @@ static int msix_capability_init(struct pci_dev *dev, if ( idx < 0 ) { - pci_conf_write16(dev->sbdf, msix_control_reg(pos), control); - xfree(entry); - return idx; + ret = idx; + goto out; } base = fix_to_virt(idx) + (entry_paddr & (PAGE_SIZE - 1)); @@ -906,12 +922,6 @@ static int msix_capability_init(struct pci_dev *dev, if ( !msix->used_entries ) { - maskall = false; - if ( !msix->guest_maskall ) - control &= ~PCI_MSIX_FLAGS_MASKALL; - else - control |= PCI_MSIX_FLAGS_MASKALL; - if ( rangeset_add_range(mmio_ro_ranges, msix->table.first, msix->table.last) ) WARN(); @@ -940,23 +950,13 @@ static int msix_capability_init(struct pci_dev *dev, WARN_ON(msix->table.first != (table_paddr >> PAGE_SHIFT)); ++msix->used_entries; - /* Restore MSI-X enabled bits */ - if ( !hardware_domain ) - { - /* - * ..., except for internal requests (before Dom0 starts), in which - * case we rather need to behave "normally", i.e. not follow the split - * brain model where Dom0 actually enables MSI (and disables INTx). - */ - pci_intx(dev, false); - control |= PCI_MSIX_FLAGS_ENABLE; - control &= ~PCI_MSIX_FLAGS_MASKALL; - maskall = 0; - } - msix->host_maskall = maskall; - pci_conf_write16(dev->sbdf, msix_control_reg(pos), control); + out: + if ( ret < 0 ) + xfree(entry); - return 0; + msix_update_unlock(dev, pos, control); + + return ret; } /** @@ -1180,7 +1180,7 @@ void pci_cleanup_msi(struct pci_dev *pdev) { /* Disable MSI and/or MSI-X */ msi_set_enable(pdev, 0); - msix_set_enable(pdev, 0); + msix_force_disable(pdev); msi_free_irqs(pdev); } @@ -1229,11 +1229,20 @@ int pci_msi_conf_write_intercept(struct pci_dev *pdev, unsigned int reg, if ( reg != msix_control_reg(pos) || size != 2 ) return -EACCES; + spin_lock_irq(&pdev->msix->control_lock); + + pdev->msix->guest_enable = !!(*data & PCI_MSIX_FLAGS_ENABLE); + if ( pdev->msix->host_enable ) + *data |= PCI_MSIX_FLAGS_ENABLE; pdev->msix->guest_maskall = !!(*data & PCI_MSIX_FLAGS_MASKALL); if ( pdev->msix->host_maskall ) *data |= PCI_MSIX_FLAGS_MASKALL; - return 1; + pci_conf_write16(pdev->sbdf, reg, *data); + + spin_unlock_irq(&pdev->msix->control_lock); + + return -EPERM; /* Already done the write. */ } } @@ -1324,15 +1333,12 @@ int pci_restore_msi_state(struct pci_dev *pdev) } else if ( !type && entry->msi_attrib.type == PCI_CAP_ID_MSIX ) { - control = pci_conf_read16(pdev->sbdf, msix_control_reg(pos)); - pci_conf_write16(pdev->sbdf, msix_control_reg(pos), - control | (PCI_MSIX_FLAGS_ENABLE | - PCI_MSIX_FLAGS_MASKALL)); + control = msix_update_lock(pdev, pos); + if ( unlikely(!memory_decoded(pdev)) ) { + msix_update_unlock(pdev, pos, control); spin_unlock_irqrestore(&desc->lock, flags); - pci_conf_write16(pdev->sbdf, msix_control_reg(pos), - control & ~PCI_MSIX_FLAGS_ENABLE); return -ENXIO; } } @@ -1372,8 +1378,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) } if ( type == PCI_CAP_ID_MSIX ) - pci_conf_write16(pdev->sbdf, msix_control_reg(pos), - control | PCI_MSIX_FLAGS_ENABLE); + msix_update_unlock(pdev, pos, control); return 0; } diff --git a/xen/drivers/passthrough/msi.c b/xen/drivers/passthrough/msi.c index ce1a450f6f..436c78b7aa 100644 --- a/xen/drivers/passthrough/msi.c +++ b/xen/drivers/passthrough/msi.c @@ -44,6 +44,7 @@ int pdev_msi_init(struct pci_dev *pdev) return -ENOMEM; spin_lock_init(&msix->table_lock); + spin_lock_init(&msix->control_lock); ctrl = pci_conf_read16(pdev->sbdf, msix_control_reg(pos)); msix->nr_entries = msix_table_size(ctrl); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Nov 10 17:00:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 17:00:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442031.696083 (Exim 4.92) (envelope-from ) id 1otAuI-0003AC-TX; Thu, 10 Nov 2022 17:00:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442031.696083; Thu, 10 Nov 2022 17:00:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otAuI-00038X-Ni; Thu, 10 Nov 2022 17:00:02 +0000 Received: by outflank-mailman (input) for mailman id 442031; Thu, 10 Nov 2022 17:00:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otAuH-0002uk-Au for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 17:00:01 +0000 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [2a00:1450:4864:20::32b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1cbb9d02-6119-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 18:00:00 +0100 (CET) Received: by mail-wm1-x32b.google.com with SMTP id fn7-20020a05600c688700b003b4fb113b86so1587687wmb.0 for ; Thu, 10 Nov 2022 09:00:00 -0800 (PST) Received: from pear.davidvrabel.org.uk (pear.davidvrabel.org.uk. [82.70.146.41]) by smtp.googlemail.com with ESMTPSA id j5-20020a05600c1c0500b003cfbbd54178sm9403666wms.2.2022.11.10.08.59.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 08:59:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 1cbb9d02-6119-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=XT451c2UjX6nYO0HqV5+AhJZLhiaFB3XbFUJQqv3uCY=; b=CULL7YC3PMCsFzcTYGiZxMBXj6yB7FCvh+dUXW6kjrLQStq+pPz28vAty3KSawfQcD Au1t6o+Ie3GEoRXBo2+DRT0f+j/RIsu2YyKYG+hWBH4aVCCFe/OaOeTHhsyPyTozzXGG 0S+GVk7SomYkoOdo2fEAaW8hGiLvnSMi+DLmuhptKn1ecNB4b2DTknM1XqFuT2Qgrp13 Pgj5t70odUKK7UzUX7MVApSHfyXik31o+kf9p2zc1NEH9wLdw7FWgNBSNGOPNx4PWGTc pVDMC4/cRDKHNBYBbmvdH7GvgUsSyulOxcEdnoDAFtSfwJWmivUmjGhhdaGhJfC1TRUU Obaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XT451c2UjX6nYO0HqV5+AhJZLhiaFB3XbFUJQqv3uCY=; b=MgZZwub8mWWeSI+cvMkTAORrr3f9GbZ0MjoNsV1nu/mDrs3SEDVkUZfesOTII5+YTz ugAR71WWg4OpXSSWBc2eQVY9g5o0OZQEBbzCcyl3Uuf8dnRK7QwsetaSHMVF4u6bbFty VMC3Sl1i093nelr//cO+KB6huWtwsigKXDt7qsqrI2bWJV59aQztdEsarWaPpDwoQ8TX hIlEylPxt7EBDeCohAroIt0RQRyyAS9kkqphhJIid8Gqc431pbdghglqui8jk/lWkM// 8ZC/9c0YmS3ODC00MKYUI69c9anxsH59XmR3cT5u3Is0zQRXRbspoaPlhNO4gSXfSTqF psiA== X-Gm-Message-State: ACrzQf34s55O7IFlpF3GdU+Q5b3yzGLzrY7oRL6/M1Gpy7pvqDw67wDf TauLQuZlpF+EVjtYiMnre3h+v6KNYC41EA== X-Google-Smtp-Source: AMsMyM7GfvspitH2uSrPLzAx3bEUHQuXm3d3qm+8bJzz0Yle0Sh2GhBYOAU4hJ45yWvKo9t9l+nHLQ== X-Received: by 2002:a05:600c:1e26:b0:3cf:5238:13fc with SMTP id ay38-20020a05600c1e2600b003cf523813fcmr51763388wmb.151.1668099599882; Thu, 10 Nov 2022 08:59:59 -0800 (PST) Sender: David Vrabel From: David Vrabel X-Google-Original-From: David Vrabel To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , David Vrabel Subject: [PATCH 1/3] x86/msi: consistently handle BAR mapping failures in MSI-X setup Date: Thu, 10 Nov 2022 16:59:33 +0000 Message-Id: <20221110165935.106376-2-dvrabel@amazon.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221110165935.106376-1-dvrabel@amazon.co.uk> References: <20221110165935.106376-1-dvrabel@amazon.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When setting up an MSI-X vector in msix_capability_init() the error handling after a BAR mapping failure is different depending on whether the first page fails or a subsequent page. There's no reason to break working vectors so consistently use the later error handling behaviour. The zap_on_error flag was added as part of XSA-337, beb54596cfda (x86/MSI-X: restrict reading of table/PBA bases from BARs), but appears to be unrelated to XSA-337 and is not useful because: 1. table.first and pba.first are not used unless msix->used_vectors > 0. 2. Force disabling MSI-X in this error path is not necessary as the per-vector mask is still still set. Signed-off-by: David Vrabel CR: https://code.amazon.com/reviews/CR-79020908 --- xen/arch/x86/msi.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index d0bf63df1d..8bde6b9be1 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -776,7 +776,7 @@ static int msix_capability_init(struct pci_dev *dev, u8 bus = dev->bus; u8 slot = PCI_SLOT(dev->devfn); u8 func = PCI_FUNC(dev->devfn); - bool maskall = msix->host_maskall, zap_on_error = false; + bool maskall = msix->host_maskall; unsigned int pos = pci_find_cap_offset(seg, bus, slot, func, PCI_CAP_ID_MSIX); @@ -875,8 +875,6 @@ static int msix_capability_init(struct pci_dev *dev, BITS_TO_LONGS(msix->nr_entries) - 1); WARN_ON(rangeset_overlaps_range(mmio_ro_ranges, msix->pba.first, msix->pba.last)); - - zap_on_error = true; } else if ( !msix->table.first ) { @@ -897,14 +895,6 @@ static int msix_capability_init(struct pci_dev *dev, if ( idx < 0 ) { - if ( zap_on_error ) - { - msix->table.first = 0; - msix->pba.first = 0; - - control &= ~PCI_MSIX_FLAGS_ENABLE; - } - pci_conf_write16(dev->sbdf, msix_control_reg(pos), control); xfree(entry); return idx; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Nov 10 17:00:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 17:00:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442032.696101 (Exim 4.92) (envelope-from ) id 1otAuK-0003h9-9a; Thu, 10 Nov 2022 17:00:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442032.696101; Thu, 10 Nov 2022 17:00:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otAuK-0003g9-06; Thu, 10 Nov 2022 17:00:04 +0000 Received: by outflank-mailman (input) for mailman id 442032; Thu, 10 Nov 2022 17:00:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otAuI-0002uf-Oz for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 17:00:02 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d976744-6119-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 18:00:01 +0100 (CET) Received: by mail-wm1-x32e.google.com with SMTP id v124-20020a1cac82000000b003cf7a4ea2caso3881881wme.5 for ; Thu, 10 Nov 2022 09:00:01 -0800 (PST) Received: from pear.davidvrabel.org.uk (pear.davidvrabel.org.uk. [82.70.146.41]) by smtp.googlemail.com with ESMTPSA id j5-20020a05600c1c0500b003cfbbd54178sm9403666wms.2.2022.11.10.08.59.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 09:00:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 1d976744-6119-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=3MJeW3qL/c7Nl4JPpfIgJfXaM8AY5MEnPk3q1bmBjO0=; b=AQvCwpnwVjp3w+MErojUhbmijOfiwpaBMHtyR/Ux9TYtGaRbrG3eIEXpvlhlN5cdqs 2siEbbuirbd8VG84r6buUjggBxObJ2jots3hO3qEZhSOSNzXgfMHZkelr4bNxpCQVa+I o+z/fiklDX0anJMA+QjU8u/W2LG+6FUw7fxs7kyAyWDe9hBuWvHbTn7SepiLt2AUT9k/ EUXBNEnVyjIO0wDdf7hxtJrDcU80JyjOI3zJzh18meU4d78HQZ0UxoCJW4Ktdr03gB5a /btoLShA3+6q8ualNTEw4skoAlb8cSbaLYF/7g9ldcjYIFsy0YmoqaNE4s/3DeWmiIvf 8ziw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3MJeW3qL/c7Nl4JPpfIgJfXaM8AY5MEnPk3q1bmBjO0=; b=3N4RQczP+4nnZ5lEzHxAbIsuvgbkkSqjEjD+510Fiw1b0oOo5WnkTCVUkS5OOTj4vl DvOczIiuCSsLrNWj5tqBuHD7iQGSJYzqHWZqIexrqEM2RkMG5/CaZ7YPC5WEgONXoVGm QS57b6TYSL1xx/joE443Q+ctH4LWFGSiu/yT4eGmxzb5DqmSTAiTGztxCXJKWEPX+naC KC9bBj0jeXMZoQXfp/TRkT/h6l2tED5g2r8+mLYpvXNOtvnPS4Usg4Qh6l1QAK62PI9c /wEiTyYJfaiIWhyIX3+o55H+MiTyeEd8MwTmdmMMLFqisNpGd/0ed85HSxPNJkiN79rv +foA== X-Gm-Message-State: ACrzQf05ceyyawdpb2b1pPpAlFK+lmHP+ZZg23zL5MGbD6my9ke7YJLq A7DJo4OPatDM/QliUYdRMHsHwOWqpR2MmQ== X-Google-Smtp-Source: AMsMyM40n8czUkrqnA7n+hbZVa0+8Z+b/+T5uaerrS29tarrjqZX00xmpUVP3PYRoSHVqyKEW9glFw== X-Received: by 2002:a7b:c3d8:0:b0:3cf:9b7b:b96c with SMTP id t24-20020a7bc3d8000000b003cf9b7bb96cmr21909005wmj.113.1668099601471; Thu, 10 Nov 2022 09:00:01 -0800 (PST) Sender: David Vrabel From: David Vrabel X-Google-Original-From: David Vrabel To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , David Vrabel Subject: [PATCH 2/3] x86/msi: remove return value from msi_set_mask_bit() Date: Thu, 10 Nov 2022 16:59:34 +0000 Message-Id: <20221110165935.106376-3-dvrabel@amazon.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221110165935.106376-1-dvrabel@amazon.co.uk> References: <20221110165935.106376-1-dvrabel@amazon.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The return value was only used for WARN()s or BUG()s so it has no functional purpose. Simplify the code by removing it. The meaning of the return value and the purpose of the various WARNs() and BUGs() is rather unclear. The only failure path (where an MSI-X vector needs to be masked but the MSI-X table is not accessible) has a useful warning message. Signed-off-by: David Vrabel CR: https://code.amazon.com/reviews/CR-79020927 --- xen/arch/x86/msi.c | 34 +++++++++------------------------- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index 8bde6b9be1..6c675d11d1 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -314,7 +314,7 @@ int msi_maskable_irq(const struct msi_desc *entry) || entry->msi_attrib.maskbit; } -static bool msi_set_mask_bit(struct irq_desc *desc, bool host, bool guest) +static void msi_set_mask_bit(struct irq_desc *desc, bool host, bool guest) { struct msi_desc *entry = desc->msi_desc; struct pci_dev *pdev; @@ -361,11 +361,6 @@ static bool msi_set_mask_bit(struct irq_desc *desc, bool host, bool guest) if ( likely(control & PCI_MSIX_FLAGS_ENABLE) ) break; - - entry->msi_attrib.host_masked = host; - entry->msi_attrib.guest_masked = guest; - - flag = true; } else if ( flag && !(control & PCI_MSIX_FLAGS_MASKALL) ) { @@ -385,14 +380,10 @@ static bool msi_set_mask_bit(struct irq_desc *desc, bool host, bool guest) control |= PCI_MSIX_FLAGS_MASKALL; pci_conf_write16(pdev->sbdf, msix_control_reg(entry->msi_attrib.pos), control); - return flag; - default: - return 0; + break; } entry->msi_attrib.host_masked = host; entry->msi_attrib.guest_masked = guest; - - return 1; } static int msi_get_mask_bit(const struct msi_desc *entry) @@ -418,16 +409,12 @@ static int msi_get_mask_bit(const struct msi_desc *entry) void cf_check mask_msi_irq(struct irq_desc *desc) { - if ( unlikely(!msi_set_mask_bit(desc, 1, - desc->msi_desc->msi_attrib.guest_masked)) ) - BUG_ON(!(desc->status & IRQ_DISABLED)); + msi_set_mask_bit(desc, 1, desc->msi_desc->msi_attrib.guest_masked); } void cf_check unmask_msi_irq(struct irq_desc *desc) { - if ( unlikely(!msi_set_mask_bit(desc, 0, - desc->msi_desc->msi_attrib.guest_masked)) ) - WARN(); + msi_set_mask_bit(desc, 0, desc->msi_desc->msi_attrib.guest_masked); } void guest_mask_msi_irq(struct irq_desc *desc, bool mask) @@ -437,15 +424,13 @@ void guest_mask_msi_irq(struct irq_desc *desc, bool mask) static unsigned int cf_check startup_msi_irq(struct irq_desc *desc) { - if ( unlikely(!msi_set_mask_bit(desc, 0, !!(desc->status & IRQ_GUEST))) ) - WARN(); + msi_set_mask_bit(desc, 0, !!(desc->status & IRQ_GUEST)); return 0; } static void cf_check shutdown_msi_irq(struct irq_desc *desc) { - if ( unlikely(!msi_set_mask_bit(desc, 1, 1)) ) - BUG_ON(!(desc->status & IRQ_DISABLED)); + msi_set_mask_bit(desc, 1, 1); } void cf_check ack_nonmaskable_msi_irq(struct irq_desc *desc) @@ -1358,10 +1343,9 @@ int pci_restore_msi_state(struct pci_dev *pdev) for ( i = 0; ; ) { - if ( unlikely(!msi_set_mask_bit(desc, - entry[i].msi_attrib.host_masked, - entry[i].msi_attrib.guest_masked)) ) - BUG(); + msi_set_mask_bit(desc, + entry[i].msi_attrib.host_masked, + entry[i].msi_attrib.guest_masked); if ( !--nr ) break; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Nov 10 17:00:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 17:00:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442030.696078 (Exim 4.92) (envelope-from ) id 1otAuI-00037I-Ls; Thu, 10 Nov 2022 17:00:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442030.696078; Thu, 10 Nov 2022 17:00:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otAuI-00036a-GO; Thu, 10 Nov 2022 17:00:02 +0000 Received: by outflank-mailman (input) for mailman id 442030; Thu, 10 Nov 2022 17:00:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otAuG-0002uf-MF for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 17:00:00 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c2dcb2e-6119-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 17:59:59 +0100 (CET) Received: by mail-wm1-x32a.google.com with SMTP id ay14-20020a05600c1e0e00b003cf6ab34b61so3896581wmb.2 for ; Thu, 10 Nov 2022 08:59:59 -0800 (PST) Received: from pear.davidvrabel.org.uk (pear.davidvrabel.org.uk. [82.70.146.41]) by smtp.googlemail.com with ESMTPSA id j5-20020a05600c1c0500b003cfbbd54178sm9403666wms.2.2022.11.10.08.59.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 08:59:56 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 1c2dcb2e-6119-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=jR9sL9xZ87Lim2oBNCVC1s9tGbb7OCjb5ynHIotoKw0=; b=qWbUXpUaZO2M2dtX+vIvfmPuj/g8QkzNqZBcpZu9CWe3QeQ04ksOAu1srnyERkmOtf SwWmFHXm+onT912QNEFJPrLOiWNBoo+Hv5iP8n1AWuXad+ap5XCyggjv3vK32Gjjg97W uSE9r3qCFM/2wJuVBamxEK4si+AgfN2k4MiAYE/xs/KdYrrFRw+ECvs69G7BjqnGIE3N v2008s552u9U5FsZfnB5aSzIjiQkhODxiWSyRagwjJMbAVJLWXK32ZpDpvtHtiZU7f6a 9fHSwRpjo4LpKCuEPAySmM4eJIBJSN4JE4ZDdSNGaIe8ScldymXeFqnmAltzNPmsLaZ6 EMQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jR9sL9xZ87Lim2oBNCVC1s9tGbb7OCjb5ynHIotoKw0=; b=JkJMtSzCCnj4tauxY6EAjQzawqwLKbVkh3MmPTNES9z90kbnKkQ8rNRiwOJa6muz1y VDecGzCjxtR6OB9ybxVYg514PxkAAzVYAWD227GFdBcmq74YMzfP0mDEk4nWufpJYlHZ jOsY+IITerkpX1C5N2HNkoRiJC8yWBxmgXO4HOjSsc5iaRJ1kCd9LncLNGKGf7cWUtiK NslsDDCRimjX/AvWA61WJnv50w6R00QyQp9BKMPEkcTZIGZUbzFsDOinqijqMHfIZkkM 6Yjw+FFRDSG++9SkdeLEAHOjdMOkBCDx//zeGWfb8ZV0gTbKWI+IpDguRF1PUBNPzP3b fPQQ== X-Gm-Message-State: ACrzQf2XPicgPpjgLaHH72Xe0vJ4ruGmrERJsEM9i+Zac8LmEuDrkVwD qKVN4kcuRrWZhndr6ln/LsVBg/oA+jQ= X-Google-Smtp-Source: AMsMyM6n1OFHG8Zd8JC3d6UsF+ZjrzWpShMVJmuZY4jAtLsdc3XLhCBK16lMu+nx1LpJfKfi/GEBkQ== X-Received: by 2002:a7b:c30c:0:b0:3c6:f26a:590f with SMTP id k12-20020a7bc30c000000b003c6f26a590fmr44268221wmj.205.1668099598900; Thu, 10 Nov 2022 08:59:58 -0800 (PST) Sender: David Vrabel From: David Vrabel X-Google-Original-From: David Vrabel To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , David Vrabel Subject: [PATCH 0/3] x86: Fix racy accesses to MSI-X Control register Date: Thu, 10 Nov 2022 16:59:32 +0000 Message-Id: <20221110165935.106376-1-dvrabel@amazon.co.uk> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The main patch in this series is 3/3 with some preparatory patches to simplify the implementation. To summarize: Concurrent access the the MSI-X control register are not serialized with a suitable lock. For example, in msix_capability_init() access use the pcidevs_lock() but some calls to msi_set_mask_bit() use the interrupt descriptor lock. This can lead to MSI-X being incorrectly disabled and subsequent failures due to msix_memory_decoded() calls that check for MSI-X being enabled. David From xen-devel-bounces@lists.xenproject.org Thu Nov 10 18:07:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 18:07:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442109.696139 (Exim 4.92) (envelope-from ) id 1otBxp-0005po-4K; Thu, 10 Nov 2022 18:07:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442109.696139; Thu, 10 Nov 2022 18:07:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otBxp-0005ph-1W; Thu, 10 Nov 2022 18:07:45 +0000 Received: by outflank-mailman (input) for mailman id 442109; Thu, 10 Nov 2022 18:07:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otBxn-0005pb-G7 for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 18:07:44 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 915fe572-6122-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 19:07:42 +0100 (CET) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1otBxJ-00ALFj-P7; Thu, 10 Nov 2022 18:07:14 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5777E30041D; Thu, 10 Nov 2022 19:07:12 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 3CDAE2BB18BCD; Thu, 10 Nov 2022 19:07:12 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 915fe572-6122-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TAqMJ9XEgcb7EhZe2sWVJH4nswduJ2xyoOUcpLbLbEM=; b=hfNGu4eXvHj3RG9HNpNohVHc16 ipyrTZ3rsXdUovuTXkVMvNvcA9s8TrtXk46ii1oNq2be7fSpxn6H9eegzIIAWqSVBXTJcK+Ez8+ME pOohQG7JKCGxgTNvUSu6SVJSB8qaAcJEbh+/iu2qYAPFTQHYlwRHmMAHQnvuhFChodjPEahlNbJDM aKBfh5GytMaVXtYrg2V4hwEYK9qeBj8H7Jhh6YIPmYGzxi3ntCfEJmDD/eWv0aNF4pkmwcDlko2Kx 27mtN6UPSwW5ZHDyfQFaxCUgc+ItsGMDVOkBT/pytFNCUiIliVRqVjHseXp0Yyg2bgDiXn6TI70/I VDHKTGcA==; Date: Thu, 10 Nov 2022 19:07:12 +0100 From: Peter Zijlstra To: Ross Philipson Cc: linux-kernel@vger.kernel.org, x86@kernel.org, dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com, jailhouse-dev@googlegroups.com, jan.kiszka@siemens.com, xen-devel@lists.xenproject.org, jgross@suse.com, boris.ostrovsky@oracle.com, andrew.cooper3@citrix.com Subject: Re: [PATCH v2 2/2] x86: Check return values from early_ioremap calls Message-ID: References: <20221110154521.613472-1-ross.philipson@oracle.com> <20221110154521.613472-3-ross.philipson@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221110154521.613472-3-ross.philipson@oracle.com> On Thu, Nov 10, 2022 at 03:45:21PM +0000, Ross Philipson wrote: > On allocation failures, panic() was used since this seemed > to be the action taken on other failures in the modules > touched by this patch. How is the panic() more useful than the obvious NULL deref that also splats? From xen-devel-bounces@lists.xenproject.org Thu Nov 10 18:28:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 18:28:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442122.696150 (Exim 4.92) (envelope-from ) id 1otCI6-0000Ao-Ra; Thu, 10 Nov 2022 18:28:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442122.696150; Thu, 10 Nov 2022 18:28:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otCI6-0000Ac-Ou; Thu, 10 Nov 2022 18:28:42 +0000 Received: by outflank-mailman (input) for mailman id 442122; Thu, 10 Nov 2022 18:28:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otCI5-0000AV-95 for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 18:28:41 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7e43e841-6125-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 19:28:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e43e841-6125-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668104919; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=IplWisakSoiSoSMaFnJnLlsHSTrJiLd8Gc+8zqQWMhs=; b=YFoudXFVA/Gi/K2/i8FqrnRyFOp+XidXY5C9tkwypHewbjNTQ67OLbd0 c0AykJq5vFEYGRdXrR/D7rQUnfSyAP9VsY14NtR/bWhMueMWk0znnzjmO VNuO/c8sdbTylUJMa6ATGTzu3wtT/+iIg3WEnNsf+15mlao46W0xxtoet o=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84184755 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:XsRbWKuW+dqYHgzt0+dPgfr4pefnVFpeMUV32f8akzHdYApBsoF/q tZmKWuBPvveYTP0KdojOdzkoU0EscSDn4cxHQQ6qy00ECtE+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaHzyFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwCA8xZVe+oeaP0L+SVbIwmN8JJdX2FdZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfAdMYH49tL7Aan3XfjFGqVTTua0t5Gv7xw1tyrn9dtHSf7RmQO0Fwh/I+ j2bogwVBDlHKduHwB6Uw0uzl/bjmhHadNwjSqGRo6sCbFq7mTVIVUx+uUGAiea9ol6zXZRYM UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL8wwufHHlCcTdHZ/QvrspwTjsvv neFls3kLSZiu7qUTTSa7Lj8kN+pEXFLdylYP3ZCFFZbpYm4yG0usv7RZvZcLKXys/vxICH96 i/R8DYlrbwPkOdegs1X4mv7qz6ro5HISCs86QPWQn+p42tFWWK1W2C7wQOFtKgdde51WnHE5 SFZwJbGsIjiGLnXzESwrPMx8KZFDhpvGBnVmhZREpYo7FxBEFbzLNkLsFmSyKqEW/vomAMFg meJ52u9B7cJZhNGiJObhKrgY/nGNYC6SbzYugn8N7KjovFZLWdrBh1Ga0+KxHzKm0Mxi6w5M przWZ/yUyZCUPQ2lGLqHL11PVoXKscWnD27eHwG507/jer2iIC9Fd/pz2dinshmtfjZ8W05A v5UNteQygU3bQENSnC/zGPSRHhURUUG6Wfe8JUKJ7LbfFA3QAnMyZb5mNscRmCspIwN/s+gw 513chUwJIbX7ZEfFTi3Vw== IronPort-HdrOrdr: A9a23:dCzgW6BAC7FAXhblHemg55DYdb4zR+YMi2TC1yhKJyC9Ffbo8P xG/c5rsSMc5wxwZJhNo7y90cq7MBbhHPxOkOos1N6ZNWGM0gaVxelZnO3fKlbbehEWmNQz6U 4ZSdkdNOHN X-IronPort-AV: E=Sophos;i="5.96,154,1665460800"; d="scan'208";a="84184755" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: Henry Wang , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [[PATCH for-4.17 v1]] tools/ocaml/xenstored/xenstored.ml: fix incorrect scope Date: Thu, 10 Nov 2022 18:28:10 +0000 Message-ID: <356deefe1251ac353b346762df94a134c02508f0.1668104890.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit A debug statement got introduced and code not reindented (as it was part of a security fix and was trying to avoid that), however that resulted in *only* the debug statement being part of the 'if', and everything else outside of it. This results in some unnecessary ring checks for domains which otherwise have IO credit. Remove the debug line. Fixes: 42f0581a91 ("tools/oxenstored: Implement live update for socket connections") Signed-off-by: Edwin Török --- Reason for inclusion in 4.17: - bugfix for commit already in master Changes since v3: - new in v4 --- tools/ocaml/xenstored/xenstored.ml | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml index ffd43a4eee..79f04178d8 100644 --- a/tools/ocaml/xenstored/xenstored.ml +++ b/tools/ocaml/xenstored/xenstored.ml @@ -476,7 +476,6 @@ let _ = let ring_scan_checker dom = (* no need to scan domains already marked as for processing *) if not (Domain.get_io_credit dom > 0) then - debug "Looking up domid %d" (Domain.get_id dom); let con = Connections.find_domain cons (Domain.get_id dom) in if not (Connection.has_more_work con) then ( Process.do_output store cons domains con; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 10 19:03:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 19:03:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442134.696161 (Exim 4.92) (envelope-from ) id 1otCpd-0004tp-Fa; Thu, 10 Nov 2022 19:03:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442134.696161; Thu, 10 Nov 2022 19:03:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otCpd-0004ti-Cv; Thu, 10 Nov 2022 19:03:21 +0000 Received: by outflank-mailman (input) for mailman id 442134; Thu, 10 Nov 2022 19:03:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otCpb-0004tc-Uy for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 19:03:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otCpb-0006nY-Cm; Thu, 10 Nov 2022 19:03:19 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.6.115]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1otCpa-0001ma-VA; Thu, 10 Nov 2022 19:03:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=kRZNe64XznxWHyXRAN3SMueTiN1/weR4zBnn2Lp6AXM=; b=0B23unkqry+7ChEaEMjleREj1X bU5NpaNdqvsnW0FMFAEgozgwTeSeBkuMOkcSmvhLahbhg1UCgTKChAdWPtihrYNuJN8pPVvaXwFkE mund4WJHHCNo1YR9wg6p/UZDoPZN3h5VhgiBmhwZAe38UeMWT1TG/2fkZ7Zgg45NH90U=; Message-ID: <6adb621c-e3ef-ec22-fb46-3c04f52d0b8a@xen.org> Date: Thu, 10 Nov 2022 19:03:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v3] xen/arm: Enforce alignment check in debug build for {read, write}_atomic Content-Language: en-US To: Stefano Stabellini , Ayan Kumar Halder Cc: xen-devel@lists.xenproject.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com, Ayan Kumar Halder References: <20221108094503.40253-1-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 10/11/2022 00:00, Stefano Stabellini wrote: > On Tue, 8 Nov 2022, Ayan Kumar Halder wrote: >> From: Ayan Kumar Halder >> >> Xen provides helper to atomically read/write memory (see {read, >> write}_atomic()). Those helpers can only work if the address is aligned >> to the size of the access (see B2.2.1 ARM DDI 08476I.a). >> >> On Arm32, the alignment is already enforced by the processor because >> HSCTLR.A bit is set (it enforce alignment for every access). For Arm64, >> this bit is not set because memcpy()/memset() can use unaligned access >> for performance reason (the implementation is taken from the Cortex >> library). >> >> To avoid any overhead in production build, the alignment will only be >> checked using an ASSERT. Note that it might be possible to do it in >> production build using the acquire/exclusive version of load/store. But >> this is left to a follow-up (if wanted). >> >> Signed-off-by: Ayan Kumar Halder >> Signed-off-by: Julien Grall >> Reviewed-by: Michal Orzel >> Reviewed-by: Bertrand Marquis > > Acked-by: Stefano Stabellini I have pushed this patch in a branch for-next/4.18 on my public repo. I will apply the patch to staging once the tree re-opened. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Nov 10 19:05:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 19:05:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442142.696173 (Exim 4.92) (envelope-from ) id 1otCs1-0005ip-0T; Thu, 10 Nov 2022 19:05:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442142.696173; Thu, 10 Nov 2022 19:05:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otCs0-0005ii-TN; Thu, 10 Nov 2022 19:05:48 +0000 Received: by outflank-mailman (input) for mailman id 442142; Thu, 10 Nov 2022 19:05:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otCrz-0005iU-VJ for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 19:05:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otCrz-0006rW-Ic; Thu, 10 Nov 2022 19:05:47 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.6.115]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1otCrz-0001t4-CB; Thu, 10 Nov 2022 19:05:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=T0QrY3FVUdYlbls3nIzMMlfO9sggwM+/nKfZzAPrt6A=; b=ZO6FeISZAZnPTYd86BumdqW8nx kXeWWZU1HQfNULjvLfJvCv9daEa1zlK3clmgPshhJiu3Pc1CS5UUsGKImPwmU0OTUuikUOpI87x8o N8xiboCJyBTkWM04vi/ZHOLPasq5EC27TA0zYMx9bVCUfqgjZFRepJUoHAkOGRtJjSDo=; Message-ID: <0c1600b2-0c71-2a94-86c5-e0eec85ca502@xen.org> Date: Thu, 10 Nov 2022 19:05:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for 4.17] arm: fix Kconfig symbol dependency on arm features Content-Language: en-US To: Bertrand Marquis , Luca Fancellu Cc: Xen developer discussion , Wei Chen , Henry Wang , Stefano Stabellini , Volodymyr Babchuk References: <20221109140420.31007-1-luca.fancellu@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, On 10/11/2022 08:46, Bertrand Marquis wrote: >> On 9 Nov 2022, at 14:04, Luca Fancellu wrote: >> >> The commit 3c2a14ea81c7 is introducing some unsupported arm features >> that by default are disabled and are used for the cpufeature.c code. >> >> As they are disabled by default, a typo in the Kconfig symbol they >> depend on has landed in the codebase unnoticed, instead of depending >> on ARM64 which does not exist, fix the code to depend on ARM_64 that >> is the intended symbol. >> >> Fixes: 3c2a14ea81c7 ("arm: Define kconfig symbols used by arm64 cpufeatures") >> Signed-off-by: Luca Fancellu > > Reviewed-by: Bertrand Marquis > > I think this should go in 4.17 as it is fixing an invalid depends in Kconfig. > The change cannot create any issue as those config options are hidden and default to n at the moment. Committed. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Nov 10 19:19:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 19:19:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442152.696185 (Exim 4.92) (envelope-from ) id 1otD58-0007TU-71; Thu, 10 Nov 2022 19:19:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442152.696185; Thu, 10 Nov 2022 19:19:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otD58-0007TN-2S; Thu, 10 Nov 2022 19:19:22 +0000 Received: by outflank-mailman (input) for mailman id 442152; Thu, 10 Nov 2022 19:19:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otD57-0007TD-2N; Thu, 10 Nov 2022 19:19:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otD56-0007If-Ti; Thu, 10 Nov 2022 19:19:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otD56-0001CV-IM; Thu, 10 Nov 2022 19:19:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otD56-0004My-Hx; Thu, 10 Nov 2022 19:19:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/5YScjV8dmuAcC8InozNiSI5lrzdXltn2h3LS/wX3T8=; b=otnW58Iyf6B2Bz7NtdKLotg0VB 06hgpOogAp+4Oq/fGKj8SzcTpwm8qZxZD9hG4TVoe6ZM1gsQdtjHpY07XqIO+0fVgjj734dbuWvi9 X6ndn6EaWVxhynWrivff6F6plO7IPfXQajORoS58IsNLxwkNfKvZrYSdVeztwR1EY9NY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174701: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-freebsd10-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-pair:xen-install/src_host:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=aa1bf3858551b7cd1facfb116fe35830aceac497 X-Osstest-Versions-That: xen=2b27967fb89d7904a1571a2fb963b1c9cac548db From: osstest service owner Date: Thu, 10 Nov 2022 19:19:20 +0000 flight 174701 xen-unstable real [real] flight 174723 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174701/ http://logs.test-lab.xenproject.org/osstest/logs/174723/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-freebsd10-amd64 7 xen-install fail pass in 174723-retest Tests which did not succeed, but are not blocking: test-amd64-i386-pair 10 xen-install/src_host fail like 174682 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174682 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174682 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174682 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174682 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174682 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174682 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174682 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174682 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174682 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174682 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174682 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174682 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen aa1bf3858551b7cd1facfb116fe35830aceac497 baseline version: xen 2b27967fb89d7904a1571a2fb963b1c9cac548db Last test of basis 174682 2022-11-08 23:08:18 Z 1 days Testing same since 174701 2022-11-09 22:34:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Lindig Edwin Török Juergen Gross jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2b27967fb8..aa1bf38585 aa1bf3858551b7cd1facfb116fe35830aceac497 -> master From xen-devel-bounces@lists.xenproject.org Thu Nov 10 19:32:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 19:32:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442163.696203 (Exim 4.92) (envelope-from ) id 1otDHe-0001dV-CV; Thu, 10 Nov 2022 19:32:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442163.696203; Thu, 10 Nov 2022 19:32:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otDHe-0001dO-8t; Thu, 10 Nov 2022 19:32:18 +0000 Received: by outflank-mailman (input) for mailman id 442163; Thu, 10 Nov 2022 19:32:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otDHc-0001d2-NT for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 19:32:16 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 60e2bf8d-612e-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 20:32:14 +0100 (CET) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2AAJSNOj005810; Thu, 10 Nov 2022 19:31:53 GMT Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ks7g5g0hn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Nov 2022 19:31:53 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2AAJBg9q023083; Thu, 10 Nov 2022 19:31:52 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2049.outbound.protection.outlook.com [104.47.74.49]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3kpcysaqgr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Nov 2022 19:31:52 +0000 Received: from BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14) by PH0PR10MB4472.namprd10.prod.outlook.com (2603:10b6:510:30::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 19:31:50 +0000 Received: from BY5PR10MB3793.namprd10.prod.outlook.com ([fe80::72b3:f74a:9e7c:680a]) by BY5PR10MB3793.namprd10.prod.outlook.com ([fe80::72b3:f74a:9e7c:680a%4]) with mapi id 15.20.5813.012; Thu, 10 Nov 2022 19:31:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60e2bf8d-612e-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=/sM/RPyc7Kd7E67aKBnYNlDIEac+lgJDXcu0AB5D5GA=; b=T0Lw7Kb8T906fGCWG0ABZFQKs5Z8sf9rh4QbCc2QARO8hIjwIn28lktjWpgDwdXLM8ZV ruPrLuXXIat9OVKjt/ArrIH8vpPmHtf1X5kYvbd7I7PnYzEguaLoOFVaLJmMgQcnCrkQ BMmxkba0WZVCO5c+6mgnnDzB1XtJSfvlIzPxNZlkR9lApG5rX4kS2PZJyqozJdPvxFnl uvHpkLKwGahPrBjns36BoihZ5XGROYHo3+g53MAoyuTfulcVAWIv9XIOvWODODYjiZt7 BrIRFrCEXviCm2bg+w6tFh8RBuTZndp+u468EEz7Fx5ItnWTQUrZdEfR1NPrAJHlFpao /w== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QTWqO1T0XTQ1DiTZ4DytNiqkkRwlYZw9rbw6IeQpUfuQ+6J8L3/NqUkd9CTDbfx4TnZePYh2jfmIbba+O9w9cCldlJRIFNZAcXqyleOnlqINzdelZBW/gqaMSN/rDRt5CYdH1MvsTPyvd31vu3JM6VFU6uQyViwO9/waQ+6rOJvI0tSkNCRpzBj7LNb1q4Ht3irEOJ5klqW6CrJEyfPxwwLV76b6g4GhkYlt0AotQm00CRFf3de5eN6BrdpH9V6u5OIbO6svsFISeU7IU7mDFcMsmsdYxldw25aoZAIm2O/mvTGMWmLHjhzs4ebbz9G8R7GyZzSTnEB53kb4tRXI/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/sM/RPyc7Kd7E67aKBnYNlDIEac+lgJDXcu0AB5D5GA=; b=WAN3PBHBzpFlRLkNzQZUiRyisBB/X0tf2DD80KNTJRdKSHwBI7BqKpocBOm2SEXOFJEspleVQDizLHPbv/Chv/Deo51vJOoFI8QvY4lAfMaLoiHmujIKFHb1atbcOtf1rHfVVQd5jq61zEI5h3u2pUH4ZeGqqXZXsS6bloAGWX/K4Gw+nM/9EIsT4yFw1npf3PDwQhgVdPqH6jj9maHhszQgy36M0T0wBAysONjOqD/03qWIc2EJIsIQYDkeCkYMs+w4lucfHXOiqvc3IjfLJUfRP64yScEH87RYud4yM7DJ7TIuD8wzTBdUdpg5i+oJfQWIc+JRMKFAOcgdmqZKHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/sM/RPyc7Kd7E67aKBnYNlDIEac+lgJDXcu0AB5D5GA=; b=qJfO5IdOge+kw+jCEF2tbPyXQjuy70dHOwU8BsA+Owezxp5dOaG0+S8W9NJRikailaQAWjjnHEBflnq8rEtI4SCQf3ao3UMEfUJdcpm4ZCqkBYHRuzCKT4YT93MXZSHs9EPnKxu7IQPA9hy2jF0pVXNdttojI65ZcFCteAX8u5U= Message-ID: Date: Thu, 10 Nov 2022 14:31:45 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 2/2] x86: Check return values from early_ioremap calls Content-Language: en-US To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, x86@kernel.org, dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com, jailhouse-dev@googlegroups.com, jan.kiszka@siemens.com, xen-devel@lists.xenproject.org, jgross@suse.com, boris.ostrovsky@oracle.com, andrew.cooper3@citrix.com References: <20221110154521.613472-1-ross.philipson@oracle.com> <20221110154521.613472-3-ross.philipson@oracle.com> From: Ross Philipson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN9PR03CA0138.namprd03.prod.outlook.com (2603:10b6:408:fe::23) To BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB3793:EE_|PH0PR10MB4472:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d6d970b-9383-4304-e85e-08dac35236fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v5xeQVpHd6ABx8NRdxFVoeMFSxcG7T9+az6eteS4tXQktYBZd0TwgHUsZS8tUtPoPouNHzUIdgcAbGvrIK31SFKXcEAgOuQXSvNoSU5IyDMgIfkvhVr9+dABTN6oBJLFolFHLMJZh4BHlNSptzMrDKjws3YFFREObZNEkCz6/XjTPR635vZCha5DaFmZKZGYEEVLuTQA7Z34v7AlbUho/jzJKXViUw5xKiQ/noEwfU/JqXImRr2oS7tWEQwl+/r5x0tBjZJ195a/Q5UcvyF0/IK0x3ubbUuYwSXF/IFhI7NGMqSoKpi5EjDZNzv/XTfOrcFs5Fu2OO3b9/fuGmlEyATUoOK0Z0EAQvA8VmauTCOsIWL3FOIpdh2oookV+sOb8C5iWUKgVQrZAPyhPfBKx9+uwaNss1S0G76j/s2zbxiUSO0ONsBlfVP5wM1v61D0v9fA4WFDw27hQxFpn/fr+KaU1j1d/F6P9D45TwH7dUtcrp00w7eBhrRt58Do7QnXVR7mtG6tBEH9f3YPuoE90iw83oYrKnqLs14CFO0COyvg/jMcm1nT1PnRleuot/WGiPQ3RwEecmIRUPXDTH1QdY+1O/iF23PCbuMQFIo8VpmD+wUqCbk7vH6jpZCEENMuRMkdlplgaw5YvWZlrChSttt6CdC+IJaadeJ1zJ33etAyUTdi3YBUSRwfYm/JRH9axeMnkU+PWzYv/TPbbekAOQRQ+rAf4Aqe9ZBen8e+ybFe596pirB9ovm8VrUm55en7pq5zIf/LXpAGjkrDM6LVTaL81wk0U6kJmjc1CECtIM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB3793.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(396003)(366004)(376002)(39860400002)(451199015)(316002)(6916009)(2616005)(41300700001)(44832011)(4744005)(5660300002)(7416002)(186003)(2906002)(6506007)(8936002)(36756003)(53546011)(66556008)(4326008)(6512007)(66946007)(8676002)(66476007)(31696002)(86362001)(31686004)(478600001)(6666004)(6486002)(83380400001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjlCeE5SaGZNMjRTVjIwTi9WNTR3REdnZjN3UXdTWVdMWWh5SmkrSWN6Sndv?= =?utf-8?B?Q1k5ajc5MWdkd0lMR1BpdDBQZUdCZ1NPOWlPVkNUSEhiaFpZbG96NnQ4MEFa?= =?utf-8?B?TnlxTzUvMGptbFZUaEY1YWR0amxKK2dpQ2ZHSXR1QVNBV3ZXakh3ZGsrVnZs?= =?utf-8?B?SzBTcTh1YmxKU0RiZFZIUE5IRkczYWIyT010SW1SV2tMb1BzWDVkcG14MW9n?= =?utf-8?B?cXFqNnJqd1JNbGVCM0d6Q1VOM1U5UHZkNW9La1FsNGJkd2dFeDcvTHl0WERx?= =?utf-8?B?V202Yk96aXh2RlIrSmNRWGdIckNvZzA2bTcrRFRmRHE1YUZ0WWxiWERiOWcx?= =?utf-8?B?MHQ2WHViNm5CQm9TclRyekxvRDhXcEpZa2RYY2dTUllvSlJhR0szNzNtblBV?= =?utf-8?B?N0dUenkxZE5vMVdoR1R4OUFJWC9iN1FNQ1dKeFphTzFic1J5bDViM1dLWTg0?= =?utf-8?B?TUlvRTFpMEl4ZERXeXZNSENFNWxNZHk0UGZPektUWFpqdHcyWU5INUR6WmNR?= =?utf-8?B?d2Z2cm5xUlpkVks0QVlwd0xibnM3TnBRMmtKUU1NZmdxZ3plUVYzV0QvcFFH?= =?utf-8?B?azlnTHZKZEFHT0lKZEd2M3JEU3N2emVtWWxLSkJTL3NyaVh2OGlyNFgrWWpr?= =?utf-8?B?ZzJKVDVxWnJCZFBxeWZ0ZWNnUHNQOE1VRXNRQVNEbitiUkVEVCtLeERUSlll?= =?utf-8?B?c3kxaW1YZlRYaytCZ1hFTVp6M0NQeEZCYmhXU1ZUYmpzMXZRck1OSWloWThy?= =?utf-8?B?UmtVeHBySldBMVBGaU5vcFhYSUpRcEhoWlJtNGNnWnA4Q0pKdWx0TGxlODVl?= =?utf-8?B?OThVQk1HbUtmZkxkUko5blVINUpUTWdJOUo2TngwRks0MFJZVkhBVzIraHdX?= =?utf-8?B?Ung5MllselJWSloyWDZoNXRIVEtMcExIN0RqeDNJT2NTREVNc0Zhbit1aDlw?= =?utf-8?B?Nlh2SU1RekNpcThuaUdISEQ0ZnNJS21jeHpZY3ZBbVBneGhuZDFaNjRtdzJq?= =?utf-8?B?T05WTTZod2FzaXpJaXQ4RUNDeCtCUXpJQTk4WklOWjNaWWlpUnM1MUVPeGFh?= =?utf-8?B?WHVhMmZPU2lKcVNMNE9kU0hoMWpDZUFMcHV3cUpOazF2aDZ2VWVkSkNjYmVJ?= =?utf-8?B?aU52VjBTV01wMDZiVFl4K1RCWmMwaXhKRkgwSDJoTFNNcFpwRGtQYm5odmVr?= =?utf-8?B?cEE0UFR2UnV1cExUZXB2UXEvanQwQjd4b1VYZW02czVJTmg4V3VuaUtPOVBu?= =?utf-8?B?NkZHN0t2ajZqeUFvRmVrcHE1SnNuSnNBUjZhMWl5UCt5eGoybVpXbzZSaURV?= =?utf-8?B?RjV4eWJnR1ljcGxjQkRTZlR0OUZER0ljTlY4cVdJYU5KdFJ6TStNd1duS1Av?= =?utf-8?B?b2lZNndCWGxXTG84YXIvQXZXUVh1dTNuaUlvTmQvVTdyRHZIMUJwUXJFMk1C?= =?utf-8?B?djI3c3I3Q0dOekw0QlUzMHFRdzhsZmZBUzBuSFErN1lvT1RtbTJGcExIdUVJ?= =?utf-8?B?WUhNSkJtZ3lFMWFLZndYWTloWHYzM2JhOVFsUzZiUGlmNWc5ZThNU2NFWGU0?= =?utf-8?B?OEo0aFZaN3ZMS1A3L0NZaGpyMVNiVVROYm9xNkUwRmRJRnF4WHhiT20wdHZp?= =?utf-8?B?RzhkbTJMU29QYVoreDBJeVR6SG4rVzVzT283RkQ0T1lEaDdJeUsxTnpzRzkx?= =?utf-8?B?dDZCZ1AzbUNFU1Q2UEU1Z085YW1ZdlBjeFpmakxkYkl3d1pGdXFVQUxHbGl5?= =?utf-8?B?T1MvanJMamxTK3BaNTJFNjBCR0Q0U2hSN1hvaHoyU1NzTnp2MnYwQlFHNS9n?= =?utf-8?B?eTRWMFlwZzhUUTc0VzdyTG84TnVPRnF2STdQSnZZOU0wMHNoSnVBMUJyYk40?= =?utf-8?B?RXI3OHgvRk5mWFVlQnJLdFRJaGhuNDJyV0hRK0pEUUwxbi8yejBRWVIrR3lR?= =?utf-8?B?TUcxaUJOS00rTzFCZ1R4dklkRUljSW95TWNndkc2bHQ0ZytidEVxS2dCWnlL?= =?utf-8?B?aDNNNHQzMmsvZnZjTFp2eW01OHRmbjNOVWE1ZlVNNkc5WWRxTncrYUFRZ3JZ?= =?utf-8?B?NHluMkJHRkd0b3hnYlBnWWppZkNRMlEvemYvdHVPTVg1UGw3ZzkzblF5ZkFx?= =?utf-8?B?Z1IrbTdEWWZuT3lrS01WZTN3M2d0alppT0QyN3FtbDBTdTQ4d25uOWNSbkJ0?= =?utf-8?Q?sGc8SnPV9ZLQKnsyvSCZ28c=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d6d970b-9383-4304-e85e-08dac35236fb X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB3793.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 19:31:50.5590 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5x7oUzUPXZDE31Mh13cpEQhRs1g8s/RRpns2BgkacxnbhFb2S6X3xvgBt756NwgIOn1WIG70lGkqVL76a00Z9tJV9iiFNryA4/ruHTje9cE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4472 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-10_12,2022-11-09_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211100136 X-Proofpoint-ORIG-GUID: eRrxUR0XbnRdPgqB_luf7_7bo16mrCLW X-Proofpoint-GUID: eRrxUR0XbnRdPgqB_luf7_7bo16mrCLW On 11/10/22 13:07, Peter Zijlstra wrote: > On Thu, Nov 10, 2022 at 03:45:21PM +0000, Ross Philipson wrote: >> On allocation failures, panic() was used since this seemed >> to be the action taken on other failures in the modules >> touched by this patch. > > How is the panic() more useful than the obvious NULL deref that also > splats? > My answer here is basically the same as the answer in the reply to Dave Hansen I sent a moment ago. I think one of the primary motivation was to make things consistent. Thanks Ross From xen-devel-bounces@lists.xenproject.org Thu Nov 10 20:07:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 20:07:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442171.696214 (Exim 4.92) (envelope-from ) id 1otDps-0005pY-3H; Thu, 10 Nov 2022 20:07:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442171.696214; Thu, 10 Nov 2022 20:07:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otDps-0005pR-0K; Thu, 10 Nov 2022 20:07:40 +0000 Received: by outflank-mailman (input) for mailman id 442171; Thu, 10 Nov 2022 20:07:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otDpq-0005pL-Ma for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 20:07:39 +0000 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4fd389a5-6133-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 21:07:35 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 12:07:31 -0800 Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 10 Nov 2022 12:07:29 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1otDpe-00AK6n-37; Thu, 10 Nov 2022 22:07:26 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4fd389a5-6133-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668110855; x=1699646855; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=XMCPCA1iwhiwEmRKQ5eEAZ8oTjY1Alafexj9ZcyNpxo=; b=WT3+yKNwDFa5cxd4OUN4h1/A6eG6FkSd1DJ3ZjV4vO3qCcze3ShMiVzp QSwQt5uXR0j0UUnrrPtU/W4KmfdQokjyp5mpaQroQmn7hwYR+XwMvfsBf Pm2kF0+0JZkhuHPn/07GU0UCYcVGPsbRVrBGf5U0RDnMAtN9b0EkBlKWp iJZuIJ1ivWPA368AWektrRV1xHqLedjP/GlUd70kXVQmKnMOVUdDdYpdK wHS3EG3ZaQcj1Xe6+h6eSInSgs5aY9v/LLuoQnGlOdJu/rwGpNRXfIsxl pQGY8oQz3JLJRnRi9d4mkk0un8HodM01A50KZB+d31Mk1TSz1C0n61RlO Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="294784446" X-IronPort-AV: E=Sophos;i="5.96,154,1665471600"; d="scan'208";a="294784446" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="706285378" X-IronPort-AV: E=Sophos;i="5.96,154,1665471600"; d="scan'208";a="706285378" Date: Thu, 10 Nov 2022 22:07:26 +0200 From: Andy Shevchenko To: Roger Pau Monne Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, jgross@suse.com, "David E . Box" , Rajneesh Bhardwaj , David E Box , Hans de Goede , Mark Gross , Srinivas Pandruvada , platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v3] platform/x86: don't unconditionally attach Intel PMC when virtualized Message-ID: References: <20221110163145.80374-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221110163145.80374-1-roger.pau@citrix.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Nov 10, 2022 at 05:31:44PM +0100, Roger Pau Monne wrote: > The current logic in the Intel PMC driver will forcefully attach it > when detecting any CPU on the intel_pmc_core_platform_ids array, > even if the matching ACPI device is not present. > > There's no checking in pmc_core_probe() to assert that the PMC device > is present, and hence on virtualized environments the PMC device > probes successfully, even if the underlying registers are not present. > Previous to 21ae43570940 the driver would check for the presence of a > specific PCI device, and that prevented the driver from attaching when > running virtualized. > > Fix by only forcefully attaching the PMC device when not running > virtualized. Note that virtualized platforms can still get the device > to load if the appropriate ACPI device is present on the tables > provided to the VM. > > Make an exception for the Xen initial domain, which does have full > hardware access, and hence can attach to the PMC if present. Reviewed-by: Andy Shevchenko > Fixes: 21ae43570940 ('platform/x86: intel_pmc_core: Substitute PCI with CPUID enumeration') > Signed-off-by: Roger Pau Monn > Acked-by: David E. Box > --- > Changes since v2: > - Don't split condition line. > > Changes since v1: > - Use cpu_feature_enabled() instead of boot_cpu_has(). > --- > drivers/platform/x86/intel/pmc/pltdrv.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/platform/x86/intel/pmc/pltdrv.c b/drivers/platform/x86/intel/pmc/pltdrv.c > index 15ca8afdd973..ddfba38c2104 100644 > --- a/drivers/platform/x86/intel/pmc/pltdrv.c > +++ b/drivers/platform/x86/intel/pmc/pltdrv.c > @@ -18,6 +18,8 @@ > #include > #include > > +#include > + > static void intel_pmc_core_release(struct device *dev) > { > kfree(dev); > @@ -53,6 +55,13 @@ static int __init pmc_core_platform_init(void) > if (acpi_dev_present("INT33A1", NULL, -1)) > return -ENODEV; > > + /* > + * Skip forcefully attaching the device for VMs. Make an exception for > + * Xen dom0, which does have full hardware access. > + */ > + if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR) && !xen_initial_domain()) > + return -ENODEV; > + > if (!x86_match_cpu(intel_pmc_core_platform_ids)) > return -ENODEV; > > -- > 2.37.3 > -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Thu Nov 10 20:11:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 20:11:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442176.696225 (Exim 4.92) (envelope-from ) id 1otDtH-0007Dh-JC; Thu, 10 Nov 2022 20:11:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442176.696225; Thu, 10 Nov 2022 20:11:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otDtH-0007Da-Fb; Thu, 10 Nov 2022 20:11:11 +0000 Received: by outflank-mailman (input) for mailman id 442176; Thu, 10 Nov 2022 20:11:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otDtF-0007DS-Ky for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 20:11:09 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cc02d07e-6133-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 21:11:02 +0100 (CET) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2AAK9uWO017710; Thu, 10 Nov 2022 20:10:49 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ks82q805p-9 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Nov 2022 20:10:48 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2AAJFSGF004161; Thu, 10 Nov 2022 19:30:33 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3kpctpvfex-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Nov 2022 19:30:33 +0000 Received: from BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14) by CH0PR10MB4987.namprd10.prod.outlook.com (2603:10b6:610:c1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 19:30:30 +0000 Received: from BY5PR10MB3793.namprd10.prod.outlook.com ([fe80::72b3:f74a:9e7c:680a]) by BY5PR10MB3793.namprd10.prod.outlook.com ([fe80::72b3:f74a:9e7c:680a%4]) with mapi id 15.20.5813.012; Thu, 10 Nov 2022 19:30:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc02d07e-6133-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=O8ZQBeQ4uz997ZkYw7OOdLDUfFU9LYeBcDcBTLN/pnA=; b=y478Q4hXpnfPptRbnXLc9QKiqFboQcr18w2rloL5FCJAJVjkpB/mKM4ITyzAvo9Afhix NXrvZb7ug0wsxecGUxQL3O9iBo3ubJeIfrr1tEByfPbfCDM/qhF46u6UJPYmzsnEBG5d M9lhSFPIwS70hNBvHmQNdVUulfT4osa96E/oGbOSyHkWiZGWGCrqWTlIPULwGzv9wleZ yRZI4m5Jfix3LbCBcESyIVF7iDj9ofwBAcjTmTRahM+9b9cD/B4TyLHjP37DJeyfWj73 KGgdQ0bZqK66NiMKQm7H4vuFX7uizmZmBauemkOMgO8H86vNpi5Qb42bb1DdemMISty5 TQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NcX7SPicFWGGLjP8I8YWtsQzk2UmytGdrMlunr8n/hEPkRxARoOiNxWYvZN8aH4odJGouzoUra1tMEeYuhpzLI2mBeJPQxhMNhG6HnKs4a01M0XvLkn5mpCABuww3IigLBlTN2mOAvd499hjYoV8aqFnA8vK3Cw6KNRCRz1GWo4HcUNXQxBgDbZnuSJpg31YNSz8vKkGhrkXPciIyr/iuyLhI690Lxnj6R6/ABHEEy16I9OUqG9MA/FxfohHtVSd9D41Lbb+C3BzdCeRTBl9E2Ilm8USIcMnMalzvOs2QGWz4BGlzdFzCCW/UKlzEJ6MNV0iJbj6VjU32ewOP/GklQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O8ZQBeQ4uz997ZkYw7OOdLDUfFU9LYeBcDcBTLN/pnA=; b=JXCutMoB0lgZkhtMUUZxi0/oftunNQvs4kf4qhbZJvad840JWb342zq6c18COwiUdIpOUELhz0Imxy7/+ETBp9OO1MWpKAiRhV2wLnMKut7lHhLvGDrLcraROxXJYAWU21Za7EnoZJ/okLPg/rQgSlHymtwucJkG+Q8ga5JeWyUkYYkivo2waVRFs/L77tCzEOSXevOIdKf05XWg/BzF7tJZ1qkxkfL1ctfAX2qVOCYF9L7yWvYn2H/nCOEaG2XQeF4QlEQdkZE+Ub3/VAoO21CR8UZkDjxLSaeGy6hHeU0sAT0g+Hp2tsQt1CYH77LKR9O7FzXGbzwzn/+DKVyHSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O8ZQBeQ4uz997ZkYw7OOdLDUfFU9LYeBcDcBTLN/pnA=; b=AiqCmhQadovFKm3bZKyFwH8/e/Gq5wOzwf8MMdsaVntXB4xBxCrBJ6ZPFa09gnNPG7ggt/Z1mDmVVptJampQpkQrhLN8eEqWvD5wt8avOLWiNUrYKpN9boowsY89pcC7qr3Y+ewY0/aGERM1r1eid/3O2AmSH4rzi579CG3UMRo= Message-ID: <267d84e3-3fbe-f010-113a-805763b7a325@oracle.com> Date: Thu, 10 Nov 2022 14:30:26 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 1/2] x86: Check return values from early_memremap calls Content-Language: en-US To: Dave Hansen , linux-kernel@vger.kernel.org, x86@kernel.org Cc: dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com, jailhouse-dev@googlegroups.com, jan.kiszka@siemens.com, xen-devel@lists.xenproject.org, jgross@suse.com, boris.ostrovsky@oracle.com, andrew.cooper3@citrix.com References: <20221110154521.613472-1-ross.philipson@oracle.com> <20221110154521.613472-2-ross.philipson@oracle.com> <8e62a029-f2fa-0627-1f71-4850a68ec6b6@intel.com> From: Ross Philipson In-Reply-To: <8e62a029-f2fa-0627-1f71-4850a68ec6b6@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN9PR03CA0130.namprd03.prod.outlook.com (2603:10b6:408:fe::15) To BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB3793:EE_|CH0PR10MB4987:EE_ X-MS-Office365-Filtering-Correlation-Id: df339611-71bd-4c8a-c31c-08dac352074d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZTjfKNRR1crSA0GaNU/deML7H2fClMYqinvliL1cLcxSZe15XF8ZsJJKscbTK+gbi5k17d3VLqhWJHVHxm9JiZ2svOIWdXkaMRSdpmutBg/FsLCci4JeQe5HkuNTsgQf+FHf/h6SUaEIDMIs7vXiLqkXjcebj7/tXEnz1nOMB2241LgPXhEd9+xUjaniF41U3E1PCiyUcnpaXL9jfQuyHCpVxQFV+zcJyTgMnwZHXLtzILHZItp2jLEoCLW768zMGrklLCAD3HChLIWWPaUJ55LS1U1To0WJAnqKqEWJJ6WWJQpeKWUv6sWhyGb09z4bhqAz0I2m3/lJv8JxnlmDZZple+xkmOTf2y+VoF+5OsfPdz818HKyyjpNIX0QO8ogOTLnYcbb41pQ0MUbQEv0RWizANoGNKpc6HrQoao6GUwuZbHJby2sP/nA8wqak2UtihEY5G4AJ32F2mAw2Y62H8BBp9R705C3Mpxm5K3NEyNrkHxaaYnD6vaU3XDI9vFHCagdyD66qQQkkl6MCUzeZrHS8vhRtzKuXppyyko5YHb2DPnRygl6AlkwmqLE7YQVMDnXJISjrJVY4lin6FEZe7+SDVwOD4KS9opKbfsTCl5pMuLTucuDYgVxjuUFHu05pkGCnSFGMsr81nTKvUdGZ/bb5txFc02l5fvCBvdmIPq/CJybnE6p9+Q1T+ZOxWE/ZNmyRdKEtfHikKkE3ZCMuBHVw1nxsXmd4+yPrqKfaJ3J0B0d5jOUFn7R5wOFQBgy4p6l5jcaETgE3n5biRwrig== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB3793.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(136003)(39860400002)(366004)(346002)(451199015)(44832011)(31696002)(2616005)(316002)(6486002)(66476007)(4744005)(66556008)(6512007)(66946007)(8676002)(4326008)(2906002)(6666004)(41300700001)(36756003)(8936002)(5660300002)(7416002)(53546011)(186003)(86362001)(6506007)(478600001)(31686004)(38100700002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3pvZktoWFZiclkxTUgvaXd4NmhxRE1mTUlGODlCUzUydkM0VXNVbjVYT24v?= =?utf-8?B?dFZ4UTZMVUNSaU9TNUtPdE1abTAxWjRaVHlKNEpGaEpORVhoQk1EQmIwUXNV?= =?utf-8?B?UWpkTG0rbi9QcTJYUC8yZEpLcC8wWmJnT0VLZktobW1sVHU4WlhqMzZvRmJN?= =?utf-8?B?V25Ebnd4dFZhNjVueE1pYzRMbWlwK3lnQ3VhSzhUekh1UVpiVVl1R3BpWDVm?= =?utf-8?B?RVpHUVRGbmpzalkvYzhrN3JRRzlYVWRqQnluWnVQdTJsa0pYRDJ1aUVIOWFn?= =?utf-8?B?R1pHS1NUNmhyNzRlMEtoYjZuZUdjSmNrb0pWY29udjJmSklHaGRsMVIxTmpG?= =?utf-8?B?aFpmYlMwRDg3MnpNdWlXN3lKVlJrbkVxdURDVHZ1M0hKdHJxQ1lEaUd4NDRt?= =?utf-8?B?RkdYano3M2F3WjFVU3gvQzJnUHRDZ2hTeW44R3RQYlFZU1ZrYkU4UXBhd29Z?= =?utf-8?B?cFdQT0kwL1VKdlZSMzFWMDRzMXI2M25UcEtEZFNyUWF2dkE2YTNJZEJua2Z2?= =?utf-8?B?TWNSd3BxRFZhQVlvUjd5YlBabXIxZUZvYnBMeW9KN2RUelh5ZWxlQXRnbEhV?= =?utf-8?B?T204ZmtyQ2NscmQrTzgxSlMvME9YNmkwcjBiQmtONzJzRUdlYmtDYjdKNE1E?= =?utf-8?B?V0RuN2tWOTh1SnBVYWVrRUVZS1RDa0lRc0FkNmxMbGNwYmI4bXN1R0dVZWVn?= =?utf-8?B?N1Bod2dvaExqZlRaeHIxUFRPQUt0cFZsNm01YW5uQTRGbUdxaUR2MGJ1amli?= =?utf-8?B?NU9uYTJ4dTJBUlVvQm91UDdtUHJXMzVJV1dVZ3JUanB0bEVZQkhTN2dqNjJy?= =?utf-8?B?RGFvVHRZQlZMb3hPRHB3RythemNNeUFhNVczeFlSYWZVYStYS1RNNFhqa0dZ?= =?utf-8?B?SnR0QjJiVDNKdG44SFduaXFPVTVyYkxaakhWQjI4NGxvd3czcjMxL1E4blB1?= =?utf-8?B?R01rMWxZTHZ5bjVCaGVFbnhObzBUMWgwNVlOVERCRnNPK0F3cndEbjRPUXZY?= =?utf-8?B?K0JubC92Y3lkR3F5RG40Q0VTbmRld1BTWGl6NUJocHRQNGdnL2RTTkRpckto?= =?utf-8?B?bjVha3h1UDI2alRxeHJ6b1hmcEw2RzhKN3YxTndpWnpWeHBVZkMxcm5odEk4?= =?utf-8?B?NG42WGpOaW5NSFNpMGV5RXRISmEyR2lqRTNiMzZCNE9kSVFLaFZ6alVjUEU5?= =?utf-8?B?V2F3MEs3U29wck1tWVEzVmdHQ0ZML1J4dElTWnpzcm5PVE13Z1hBOXdROFNZ?= =?utf-8?B?bTRncDY2WC9ZSWZBMHYwWlRTTlhHYXFZQUxsVCtZNWlaY2ErWThtYlB1NW5U?= =?utf-8?B?QlJvS1VNU0NSb2hsQjVnTjhKODYrMG82dE9MZ1JneGR0QlBzOTUvOTV3SXRW?= =?utf-8?B?dTAyekZGSWJ5MDRDMUphRFpBZ3QvWE0zTVMwUE5OYmp6NHlsU2ZxOE5TL2l5?= =?utf-8?B?T0hnYTNrUnpSSDh0SmoyalJjendWU2RHcGd5WkdZWVFXdmljYTZmaE56RW1E?= =?utf-8?B?MmVJMUc3UGNQbWxZeU9lTXo1Zm9CTTR3cURlWmRlSmFqK1J4bE9Zc0NJdjV3?= =?utf-8?B?Rlk0OWp6dmpPZFFwRDdTYytQNmFrR3pvSHIvd3FReGxOUzFIMGtvSXBpbFFh?= =?utf-8?B?YmlkL2NaYlMzVExkQjdiYWw4NkdNTTZYTml0QVdwT1FXZTBsREVreTIveVZy?= =?utf-8?B?TU5YanpCNFc4WG0xTXRvTU1JUllxSTNlVjBIdzdaaERoM0tuWkFCTWpCeTBr?= =?utf-8?B?YnN2WGhzdGlKZlB3bUZTVnVWV29SVW42aHBJL21hUngyQThrVWhGcnhYb3Qz?= =?utf-8?B?amF6TGFPb3V0UmFTck9KRUpCVGx1NzVLdXgrSDIxSjVTcEI3OGttd3JsSVpB?= =?utf-8?B?VXlXdXlzYnpHazNCbUc3MXl5VXhob1d5ZHB1V3FmWWd5WlRoOEwwcTkrYTdC?= =?utf-8?B?QlFLalZOQkFjdEJ1cUJaTEdieFFJeWQ5NmxtUllDVTVSSnRvRVBCcEZ1Y0xT?= =?utf-8?B?MGhmMUkvbWRKa0g1NkVaRTBLVmE4SG5vaUFzMmcrL2R0eG1ialF4OXF3REMy?= =?utf-8?B?T0pXRXI2aWxIcUZJeXBMelIzdHR0cXVZVEVXV3llTXlCVVRBSEVlMUU5U3lB?= =?utf-8?B?MklBYlpyYTFjcVJoQTRPeEtXeDlySVdWblljN29uRWJUeTg3VzJwRjVBZFZm?= =?utf-8?Q?2drO1uwH/e9pdsSDxyRAXOI=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: df339611-71bd-4c8a-c31c-08dac352074d X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB3793.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 19:30:30.7055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E8UjmBgIxTL5BS48FqDndM3TTnLk/2edmfQjIcGcANXp5ehiq9hBDuokEGxeVfoal2l/b5SZLENuGwe+1DT1MfYu76gNGBYwRCBTuHZIdiI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4987 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-10_12,2022-11-09_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 bulkscore=0 adultscore=0 mlxscore=0 suspectscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211100136 X-Proofpoint-GUID: VjBUBuG55t1ISJRWg0gP5HrFJPs_aDr1 X-Proofpoint-ORIG-GUID: VjBUBuG55t1ISJRWg0gP5HrFJPs_aDr1 On 11/10/22 11:07, Dave Hansen wrote: > On 11/10/22 07:45, Ross Philipson wrote: >> dt = early_memremap(initial_dtb, map_len); >> + if (!dt) { >> + pr_warn("failed to memremap initial dtb\n"); >> + return; >> + } > > Are all of these new pr_warn/err()'s really adding much value? They all > look pretty generic. It makes me wonder if we should just spit out a > generic message in early_memremap() and save all the callers the trouble. These changes were prompted by some comments on an earlier patch set I sent. It was requested that I fix the other missing checks for NULL returns from these functions but I thought that was out of scope for that patch set. So I agreed to submit this set and add the checks making things consistent. > > Oh, and don't we try to refer to functions() with parenthesis? Yes I can fix that. Thanks Ross > From xen-devel-bounces@lists.xenproject.org Thu Nov 10 20:25:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 20:25:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442185.696236 (Exim 4.92) (envelope-from ) id 1otE7H-0000g4-QG; Thu, 10 Nov 2022 20:25:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442185.696236; Thu, 10 Nov 2022 20:25:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otE7H-0000fx-MT; Thu, 10 Nov 2022 20:25:39 +0000 Received: by outflank-mailman (input) for mailman id 442185; Thu, 10 Nov 2022 20:25:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otE7G-0000fr-4K for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 20:25:38 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d5498d2d-6135-11ed-8fd2-01056ac49cbb; Thu, 10 Nov 2022 21:25:36 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 506A961E38; Thu, 10 Nov 2022 20:25:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E377C433D6; Thu, 10 Nov 2022 20:25:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5498d2d-6135-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668111934; bh=Dj9JLbk/XgYmb3XuISwvjPsoDAkGQpAnCPw8tAHRoYU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=awlsCD8msUaKXo/JjwU06KDw9vgH8akIuASeBUi1KGArcW+cD5f4Bc6oDKuQAedI9 8LHGuF510AJJnPQGfbgRsQvskoICm/FSzGR2NHY8eRyQCZ7Vpdi3/4/Mg5g73SJwA9 IbaIb4Vv/5RLqpR4oKCc36pYDRwRkITr3MCJTma4mA4tGG2SHGoiPnWsfTTwfTa0WH 3KspnrDg7XCmYGFgsqRYbf+NfAeQstOq9kqEF38OZoyzurwdtkVOOnA8+qVqKQH/59 Ne0+Jglv77Rj0xJEZyoB0K5rMXaODXW4ka8clq3v6clxOxOTuYbEoBlfhFVF9gdUeB wrGsHO+J80i9A== Date: Thu, 10 Nov 2022 12:25:32 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: Stefano Stabellini , Bertrand Marquis , "xen-devel@lists.xenproject.org" , Doug Goldstein Subject: Re: [PATCH v3 0/4] Yocto Gitlab CI In-Reply-To: <46c0e05f-47e1-39e6-d978-9f6c7d6db53a@amd.com> Message-ID: References: <1220596a-4fe7-5c08-5437-fa98eb14254c@amd.com> <6ee0706b-d1b3-187a-1557-c4b8173c6e37@amd.com> <46c0e05f-47e1-39e6-d978-9f6c7d6db53a@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 10 Nov 2022, Michal Orzel wrote: > Hi Stefano, > > On 10/11/2022 01:18, Stefano Stabellini wrote: > > > > > > On Mon, 7 Nov 2022, Michal Orzel wrote: > >> Hi Bertrand and Stefano, > >> > >> On 31/10/2022 16:00, Bertrand Marquis wrote: > >>> > >>> > >>> Hi Michal, > >>> > >>>> On 31 Oct 2022, at 14:39, Michal Orzel wrote: > >>>> > >>>> Hi Bertrand, > >>>> > >>>> On 31/10/2022 15:00, Bertrand Marquis wrote: > >>>>> > >>>>> > >>>>> This patch series is a first attempt to check if we could use Yocto in > >>>>> gitlab ci to build and run xen on qemu for arm, arm64 and x86. > >>>>> > >>>>> The first patch is creating a container with all elements required to > >>>>> build Yocto, a checkout of the yocto layers required and an helper > >>>>> script to build and run xen on qemu with yocto. > >>>>> > >>>>> The second patch is creating containers with a first build of yocto done > >>>>> so that susbsequent build with those containers would only rebuild what > >>>>> was changed and take the rest from the cache. > >>>>> > >>>>> The third patch is adding a way to easily clean locally created > >>>>> containers. > >>>>> > >>>>> This is is mainly for discussion and sharing as there are still some > >>>>> issues/problem to solve: > >>>>> - building the qemu* containers can take several hours depending on the > >>>>> network bandwith and computing power of the machine where those are > >>>>> created > >>>> This is not really an issue as the build of the containers occurs on the local > >>>> machines before pushing them to registry. Also, building the containers > >>>> will only be required for new Yocto releases. > >>>> > >>>>> - produced containers containing the cache have a size between 8 and > >>>>> 12GB depending on the architecture. We might need to store the build > >>>>> cache somewhere else to reduce the size. If we choose to have one > >>>>> single image, the needed size is around 20GB and we need up to 40GB > >>>>> during the build, which is why I splitted them. > >>>>> - during the build and run, we use a bit more then 20GB of disk which is > >>>>> over the allowed size in gitlab > >>>> As we could see during v2 testing, we do not have any space restrictions > >>>> on the Xen GitLab and I think we already decided to have the Yocto > >>>> integrated into our CI. > >>> > >>> Right, I should have modified this chapter to be coherent with your latest tests. > >>> Sorry for that. > >>> > >>>> > >>>> I will do some testing and get back to you with results + review. > >> I did some testing and here are the results: > >> > >> In the current form this series will fail when running CI because the Yocto containers > >> are based on "From ubuntu:22.04" (there is no platform prefix), which means that the containers > >> are built for the host architecture (in my case and in 99% of the cases of the local build it will > >> be x86). In Gitlab we have 2 runners (arm64 and x86_64). This means that all the test jobs would need > >> to specify x86_64 as a tag when keeping the current behavior. > >> After I built all the containers on my x86 machine, I pushed them to registry and the pipeline was successful: > >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fmorzel%2Fxen-orzelmichal%2F-%2Fpipelines%2F686853939&data=05%7C01%7Cmichal.orzel%40amd.com%7C2449f063e67341c3b95a08dac2b112a5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638036363027707274%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=EwTJrW2vuwQIugKc7mnzG9NNbsYLP6tw5UODzBMmPEE%3D&reserved=0 > > > > When I tested the previous version of this series I built the > > containers natively on ARM64, so that is also an option. > > > > > >> Here is the diff on patch no. 3 to make the series work (using x86 tag and small improvement to include needs: []): > >> ``` > >> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > >> index 5c620fefce59..52cccec6f904 100644 > >> --- a/automation/gitlab-ci/test.yaml > >> +++ b/automation/gitlab-ci/test.yaml > >> @@ -65,6 +65,9 @@ > >> paths: > >> - 'logs/*' > >> when: always > >> + needs: [] > >> + tags: > >> + - x86_64 > >> > >> # Test jobs > >> build-each-commit-gcc: > >> @@ -206,19 +209,13 @@ yocto-qemuarm64: > >> extends: .yocto-test > >> variables: > >> YOCTO_BOARD: qemuarm64 > >> - tags: > >> - - arm64 > >> > >> yocto-qemuarm: > >> extends: .yocto-test > >> variables: > >> YOCTO_BOARD: qemuarm > >> - tags: > >> - - arm32 > >> > >> yocto-qemux86-64: > >> extends: .yocto-test > >> variables: > >> YOCTO_BOARD: qemux86-64 > >> - tags: > >> - - x86_64 > >> ``` > >> > >> Now, the logical way would be to build x86 yocto container for x86, arm64 for arm64 and arm32 on arm64 or x86. > >> I tried building the container qemuarm64 specifying target arm64 on x86. After 15h, only 70% of the Yocto build > >> was completed and there was an error with glibc (the local build of the container for the host arch takes on my machine max 2h). > >> This enormous amount of time is due to the qemu docker emulation that happens behind the scenes (I checked on 2 different machines). > >> > >> So we have 3 solutions: > >> 1) Build and run these containers for/on x86_64: > >> - local users can build the containers on local machines that are almost always x86 based, in short period of time, > >> - "everyone" can build/push the containers once there is a new Yocto release > >> - slightly slower CI build time > >> 2) Build and run these containers for specific architectures: > >> - almost no go for local users using x86 machine (unless using more than 16 threads (which I used) and willing to wait 2 days for the build) > >> - faster CI build time (arm64 runner is faster than x86 one) > >> - someone with arm64 based machine (not that common) would have to build and push the containers > >> 3) Try to use CI to build and push the containers to registry > >> - it could be possible but what about local users > > > > From a gitlab-ci perspective, given the runners we currently have, we > > have to go with option 2). We don't have enough resources available on > > the x86 runner to run the Yocto jobs on x86. > > > That is what I reckon too. Running the Yocto build/test on CI using x86 runner will always be slower. > So, if we go with this solution, then the following is needed: > 1. Modify test jobs so that yocto-qemu{arm64/arm} uses arm64 tag to be taken by arm64 runner and use tag x86_64 for yocto-qemux86-64. > 2. Come up with a solution to build the yocto containers automatically for the above platforms + possibility to specify the platform for local users. > Right now, these containers are being always build for the host machine platform, so without doing tricks like adding --platform or prefix to image name, > one cannot build the Yocto containers that would be ready to be pushed to registry. We need to have a clean solution without requiring user to do tricks. > > The only drawback of this solution is that the person building the yocto-qemu{arm64/arm} container and willing to push it to registry, > needs to have access to arm64 machine. I am fine with this drawback for now. Due to resource constraints, we might want to avoid adding yocto-qemux86-64 (if yocto-qemux86-64 has to run on x86) for now, I worry it might choke the x86 ci-loop. Or we could add it but keep it disabled. We'll enable it when we get better x86 runners. From xen-devel-bounces@lists.xenproject.org Thu Nov 10 20:32:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 20:32:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442191.696247 (Exim 4.92) (envelope-from ) id 1otEEJ-00027k-IJ; Thu, 10 Nov 2022 20:32:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442191.696247; Thu, 10 Nov 2022 20:32:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otEEJ-00027d-EO; Thu, 10 Nov 2022 20:32:55 +0000 Received: by outflank-mailman (input) for mailman id 442191; Thu, 10 Nov 2022 20:32:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otEEI-00027X-NA for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 20:32:54 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d98e308e-6136-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 21:32:53 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 16A0361E42; Thu, 10 Nov 2022 20:32:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86EB0C433C1; Thu, 10 Nov 2022 20:32:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d98e308e-6136-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668112371; bh=RSkH0eIhqO5qHX3t/JTR3U9rAH4fDPGI76TxdDGTIp0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TRiSyxq60KGhCoJOYc4WFhEt89b5OkqwN7Et2vwGTPhW3up25sB8DQqLLwYIuJ/tb +zzaMfwSDkEUs5zfS9+hhXTk/OFgdogeX+N3Ps2fVP4kiz8rBWsbtW6IQACTI2sKwX CU9Wz/i52HBVSlN97Q9K/tqzCVZ5t1616gKGevY8xjFJQ+uopUA5f23K22EBs4jzIw YYiyNuYLTb6AFIYxIyP3VkybCbc+1tbfz+8XkfV+xtRVZzBW4O3FWuqjfn2vN0uS7l D8kTJT8neTj9BI4vDLwFfJVJKD6Kz2Sfhj+sY/3vcHUQ07NZSlywef75JERsgzk9Jv FLgZsN9TCB7KA== Date: Thu, 10 Nov 2022 12:32:49 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: Jiamei Xie , "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , "julien@xen.org" , "sstabellini@kernel.org" Subject: Re: Xen Arm vpl011 UART will cause segmentation fault in Linux guest In-Reply-To: Message-ID: References: <00764fe2-f78a-e5db-cb16-903ad1a5ec03@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-861249806-1668112371=:50442" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-861249806-1668112371=:50442 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 9 Nov 2022, Michal Orzel wrote: > Hi Jiamei, > > On 09/11/2022 09:25, Jiamei Xie wrote: > > > > > > Hi Michal， > > > > Below log can be got when stating the linux guest. It says 9c09 is sbsa. And 9c09 is also output > > in bootlogd error message: > > Serial: AMBA PL011 UART driver > > 9c0b0000.uart: ttyAMA0 at MMIO 0x9c0b0000 (irq = 12, base_baud = 0) is a PL011 rev2 > > printk: console [ttyAMA0] enabled > > 9c090000.sbsa-uart: ttyAMA1 at MMIO 0x9c090000 (irq = 15, base_baud = 0) is a SBSA > > > > Xen behavior is correct and this would be Linux fault to try to write to DMACR for SBSA UART device. > DMACR is just an example. If you try to program e.g. the baudrate (through LCR) for VPL011 it will > also result in injecting abort into the guest. Should Xen support it? No. The reason why is that > it is not spec compliant operation. SBSA specification directly specifies what registers are exposed. > If Linux tries to write to some of the none-spec compliant registers - it is its fault. Yeah, we need to fix Linux. FYI this is not the first bug in Linux affecting the sbsa-uart driver: the issue is that the pl011 driver and the sbsa-uart driver share the same code in Linux so it happens sometimes that a pl011-only feature creeps into the sbsa-uart driver by mistake. > >> -----Original Message----- > >> From: Michal Orzel > >> Sent: Wednesday, November 9, 2022 3:40 PM > >> To: Jiamei Xie ; xen-devel@lists.xenproject.org > >> Cc: Wei Chen ; Bertrand Marquis > >> ; julien@xen.org; sstabellini@kernel.org > >> Subject: Re: Xen Arm vpl011 UART will cause segmentation fault in Linux > >> guest > >> > >> Hi Jiamei, > >> > >> On 09/11/2022 08:20, Jiamei Xie wrote: > >>> > >>> > >>> Hi all, > >>> > >>> When the guest kernel enables DMA engine with > >> "CONFIG_DMA_ENGINE=y", Linux AMBA PL011 driver will access PL011 > >> DMACR register. But this register have not been supported by vpl011 of Xen. > >> Xen will inject a data abort into guest, this will cause segmentation fault of > >> guest with the below message: > >> I am quite confused. > >> VPL011 implements SBSA UART which only implements some subset of PL011 > >> operations (SBSA UART is not PL011). > >> According to spec (SBSA ver. 6.0), the SBSA_UART does not support DMA > >> features so Xen code is fine. > >> When Xen exposes vpl011 device to a guest, this device has "arm,sbsa-uart" > >> compatible and not "uart-pl011". > >> Linux driver "amba-pl011.c" should see this compatible and assign proper > >> operations (sbsa_uart_pops instead of amba_pl011_pops) that do not enable > >> DMA. > >> Maybe the issue is with your configuration? > >> > >> ~Michal > >> > >>> Unhandled fault at 0xffffffc00944d048 > >>> Mem abort info: > >>> ESR = 0x96000000 > >>> EC = 0x25: DABT (current EL), IL = 32 bits > >>> SET = 0, FnV = 0 > >>> EA = 0, S1PTW = 0 > >>> FSC = 0x00: ttbr address size fault > >>> Data abort info: > >>> ISV = 0, ISS = 0x00000000 > >>> CM = 0, WnR = 0 > >>> swapper pgtable: 4k pages, 39-bit VAs, pgdp=0000000020e2e000 > >>> [ffffffc00944d048] pgd=100000003ffff803, p4d=100000003ffff803, > >> pud=100000003ffff803, pmd=100000003fffa803, pte=006800009c090f13 > >>> Internal error: ttbr address size fault: 96000000 [#1] PREEMPT SMP > >>> Modules linked in: > >>> CPU: 0 PID: 132 Comm: bootlogd Not tainted 5.15.44-yocto-standard #1 > >>> pstate: 604000c5 (nZCv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > >>> pc : pl011_stop_rx+0x70/0x80 > >>> lr : uart_tty_port_shutdown+0x44/0x110 > >>> sp : ffffffc00999bba0 > >>> x29: ffffffc00999bba0 x28: ffffff80234ac380 x27: ffffff8022f5d000 > >>> x26: 0000000000000000 x25: 0000000045585401 x24: 0000000000000000 > >>> x23: ffffff8021ba4660 x22: 0000000000000001 x21: ffffff8021a0e2a0 > >>> x20: ffffff802198f880 x19: ffffff8021a0e1a0 x18: 0000000000000000 > >>> x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 > >>> x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 > >>> x11: 0000000000000000 x10: 0000000000000000 x9 : ffffffc00871ba14 > >>> x8 : ffffffc0099de260 x7 : ffffff8021a0e318 x6 : 0000000000000003 > >>> x5 : ffffffc009315f20 x4 : ffffffc00944d038 x3 : 0000000000000000 > >>> x2 : ffffffc00944d048 x1 : 0000000000000000 x0 : 0000000000000048 > >>> Call trace: > >>> pl011_stop_rx+0x70/0x80 > >>> tty_port_shutdown+0x7c/0xb4 > >>> tty_port_close+0x60/0xcc > >>> uart_close+0x34/0x8c > >>> tty_release+0x144/0x4c0 > >>> __fput+0x78/0x220 > >>> ____fput+0x1c/0x30 > >>> task_work_run+0x88/0xc0 > >>> do_notify_resume+0x8d0/0x123c > >>> el0_svc+0xa8/0xc0 > >>> el0t_64_sync_handler+0xa4/0x130 > >>> el0t_64_sync+0x1a0/0x1a4 > >>> Code: b9000083 b901f001 794038a0 8b000042 (b9000041) > >>> ---[ end trace 83dd93df15c3216f ]--- > >>> note: bootlogd[132] exited with preempt_count 1 > >>> /etc/rcS.d/S07bootlogd: line 47: 132 Segmentation fault start-stop- > >> daemon > >>> In Xen, vpl011_mmio_write doesn't handle DMACR . And kernel doesn't > >> check if pl011_write executes sucessfully in pl011_dma_rx_stop . So such > >> segmentation fault occurs. > >>> static inline void pl011_dma_rx_stop(struct uart_amba_port *uap) > >>> { > >>> /* FIXME. Just disable the DMA enable */ > >>> uap->dmacr &= ~UART011_RXDMAE; > >>> pl011_write(uap->dmacr, uap, REG_DMACR); > >>> } > >>> > >>> I think we should prevent such segmentation fault. We have checked the > >> PL011 spec, it seems there is not any register bit can indicate DMA support > >> status of PL011. We might have two options: > >>> 1. Option#1 is to add DMA support for vpl011, but this is not trivial. > >>> 2. Option#2 is to ignore the write to DMACR, and return 0 for DMACR read > >> in vpl011. But this option need co-work with kernel, because current Linux > >> PL011 driver assume the write operation will never be failed, and will not > >> fallback to no-DMA mode, when Xen return 0 for DMA enabled bit in DMACR. > >>> > >>> How do you think about it? Any suggestion about it is welcome. Thanks. > >>> > >>> Best wishes > >>> Jiamei Xie > >>> > --8323329-861249806-1668112371=:50442-- From xen-devel-bounces@lists.xenproject.org Thu Nov 10 21:23:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 21:23:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442204.696258 (Exim 4.92) (envelope-from ) id 1otF1L-0008EZ-CU; Thu, 10 Nov 2022 21:23:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442204.696258; Thu, 10 Nov 2022 21:23:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otF1L-0008ES-9m; Thu, 10 Nov 2022 21:23:35 +0000 Received: by outflank-mailman (input) for mailman id 442204; Thu, 10 Nov 2022 21:23:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otF1K-0008EI-1u; Thu, 10 Nov 2022 21:23:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otF1J-0001uy-Vc; Thu, 10 Nov 2022 21:23:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otF1J-0005S5-E1; Thu, 10 Nov 2022 21:23:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otF1J-0004aW-Db; Thu, 10 Nov 2022 21:23:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9U0CO2g2y1YYfT/PNydR7DV4LvWwwjh3rbuyqJnaBgw=; b=s/DK4o1J6Fs7T+9cMCtWzme+AM 9dNaLijJXupxXwQLhhFq8IAIBhMGYP9yI9ZqI9QrQsTFzh+XXAHTZAJp5AK1DxYK6i5SSuv04t8gf 5MDZqyZirVqsP092jwccfDYB+pktwoAlXG7hgZmg31CWwDrOyGqplb3pUpxjNTPJMpFc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174703: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f67dd6ce0723ad013395f20a3f79d8a437d3f455 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 10 Nov 2022 21:23:33 +0000 flight 174703 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174703/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux f67dd6ce0723ad013395f20a3f79d8a437d3f455 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 34 days Failing since 173470 2022-10-08 06:21:34 Z 33 days 53 attempts Testing same since 174703 2022-11-10 02:10:19 Z 0 days 1 attempts ------------------------------------------------------------ 1603 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 152931 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Nov 10 22:06:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 22:06:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442219.696268 (Exim 4.92) (envelope-from ) id 1otFgV-0004xl-Oq; Thu, 10 Nov 2022 22:06:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442219.696268; Thu, 10 Nov 2022 22:06:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otFgV-0004xe-Ls; Thu, 10 Nov 2022 22:06:07 +0000 Received: by outflank-mailman (input) for mailman id 442219; Thu, 10 Nov 2022 22:06:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otFgT-0004xR-Q0; Thu, 10 Nov 2022 22:06:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otFgT-0002ry-N6; Thu, 10 Nov 2022 22:06:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otFgT-0007iq-BU; Thu, 10 Nov 2022 22:06:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otFgT-0005xK-B3; Thu, 10 Nov 2022 22:06:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bh4tBNmpQR+3PovMHGCvie1SB0l948rji/8TkJiBvxs=; b=Xl92wZYfAIxz7CGEXBW6GIydCp NjzPxEFnXVGuzqwIp0i1pCNnCVwGZRh5bh9WItmYZunqftl6zRSoiZlN1SLIN1PbkCI7XIq6Cfodt yNi70to5Tcxme0mUkrrbEclsL6xyJLmeMx1u/+06YnnyFbs7IucHzkmFbaz1vytmPBTM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174704: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-amd64-i386-libvirt-xsm:xen-boot:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start.2:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:redhat-install:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a0d9384967214783a92973c920092b7251c03e57 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Thu, 10 Nov 2022 22:06:05 +0000 flight 174704 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174704/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-xsm 8 xen-boot fail in 174638 pass in 174704 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail in 174638 pass in 174704 test-amd64-i386-pair 11 xen-install/dst_host fail in 174638 pass in 174704 test-armhf-armhf-xl-rtds 14 guest-start fail in 174638 pass in 174704 test-armhf-armhf-xl-credit1 19 guest-start.2 fail in 174646 pass in 174638 test-amd64-i386-qemuu-rhel6hvm-amd 12 redhat-install fail in 174646 pass in 174704 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 174646 pass in 174704 test-armhf-armhf-libvirt-qcow2 13 guest-start fail in 174646 pass in 174704 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 174672 pass in 174704 test-armhf-armhf-xl-credit2 14 guest-start fail in 174672 pass in 174704 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174684 pass in 174672 test-armhf-armhf-xl-credit1 14 guest-start fail in 174684 pass in 174704 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 174646 test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 174684 test-armhf-armhf-libvirt-raw 13 guest-start fail pass in 174684 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 174684 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 174684 like 174540 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 174684 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 174684 never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 174684 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux a0d9384967214783a92973c920092b7251c03e57 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 12 days Failing since 174575 2022-11-01 18:42:39 Z 9 days 16 attempts Testing same since 174608 2022-11-03 19:46:50 Z 7 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anssi Hannula Arnaldo Carvalho de Melo Biju Das Brian Foster Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Darrick J. Wong Darrick J. Wong Dave Chinner David S. Miller Demi Marie Obenour Dongliang Mu Eric Dumazet Florian Fainelli Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hannu Hartikainen Hans Verkuil Heiko Carstens Helge Deller Hyong Youb Kim Hyunwoo Kim Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jeff Vanhoof Jens Glathe Jimmy Assarsson Johan Hovold Jon Hunter Jon Maloy Jonathan Cameron Josh Poimboeuf Juergen Gross Justin Chen Konrad Jankowski Kuogee Hsieh Leon Romanovsky Linux Kernel Functional Testing Luiz Capitulino M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Michal Jaron Mike Kravetz Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Paolo Abeni Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rik van Riel Saeed Mahameed Sakari Ailus Sasha Levin Shreeya Patel Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Thinh Nguyen Tom Lendacky Tony O'Brien Ulf Hansson Vasily Gorbik Vineet Gupta Vladimir Oltean Wei Yongjun Xin Long Yang Yingliang Yongqin Liu Zhang Changzhong Zhengchao Shao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2244 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Nov 10 22:12:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 22:12:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442228.696280 (Exim 4.92) (envelope-from ) id 1otFmn-0006Sg-N4; Thu, 10 Nov 2022 22:12:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442228.696280; Thu, 10 Nov 2022 22:12:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otFmn-0006SZ-KH; Thu, 10 Nov 2022 22:12:37 +0000 Received: by outflank-mailman (input) for mailman id 442228; Thu, 10 Nov 2022 22:12:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otFmm-0006ST-Tr for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 22:12:36 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c79979a2-6144-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 23:12:35 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8D8DBB82382; Thu, 10 Nov 2022 22:12:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1AFDC433D7; Thu, 10 Nov 2022 22:12:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c79979a2-6144-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668118352; bh=SMSKk0HZGZPcpN73DjRbSFsnc01NEI1CyX+n7keWthQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=lJLiE3uNql1oheB7Q7Qx6eEIEyHDQK0WuWCcrXbgatziMKXTYtGu/YHoMYnnoDV05 EyGVyKPHOfy9+tk/14bX+A7Vrei80k7s3hh3enC/QTvtmJvQElSBhg39Kl47tON7t6 S3ry3Wbxw7Rjele7kkt2QLxULaSL0g07PmAEVmXWFzApcpDLdAHKqf4P1jo+hzr1nx I0hR/0Z3eM541vCVYnAkHpJUtEaWk3GmBV0qkMmLqc194U6fk52b3dra0n7dutIzNj owtfNH5m6YNmvxPr/QlRMfEbNHlvU/SrMSPPyd9+E0zaaVN6BPZUOqpLsYEuMN7iPF UZG8yn2fCQs6w== Date: Thu, 10 Nov 2022 14:12:30 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Wei Chen , "xen-devel@lists.xenproject.org" , nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Jiamei Xie Subject: Re: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform In-Reply-To: Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-6-wei.chen@arm.com> <0ffe8a4d-7caf-89af-d189-a872b6b4f0fa@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-600931272-1668118352=:50442" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-600931272-1668118352=:50442 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 9 Nov 2022, Julien Grall wrote: > > > -----Original Message----- > > > From: Julien Grall > > > Sent: 2022年11月7日 3:20 > > > To: Wei Chen ; xen-devel@lists.xenproject.org > > > Cc: nd ; Stefano Stabellini ; Bertrand > > > Marquis ; Volodymyr Babchuk > > > ; Jiamei Xie > > > Subject: Re: [PATCH v6 05/11] xen/arm: define Xen start address for FVP > > > BaseR platform > > > > > > > > > > > > On 04/11/2022 10:07, Wei Chen wrote: > > > > On Armv8-A, Xen has a fixed virtual start address (link address > > > > too) for all Armv8-A platforms. In an MMU based system, Xen can > > > > map its loaded address to this virtual start address. So, on > > > > Armv8-A platforms, the Xen start address does not need to be > > > > configurable. But on Armv8-R platforms, there is no MMU to map > > > > loaded address to a fixed virtual address and different platforms > > > > will have very different address space layout. So Xen cannot use > > > > a fixed physical address on MPU based system and need to have it > > > > configurable. > > > > > > > > So in this patch, we reuse the existing arm/platforms to store > > > > Armv8-R platforms' parameters. And `XEN_START_ADDRESS` is one > > > > kind of FVP BaseR platform's parameters. So we define default > > > > `XEN_START_ADDRESS` for FVP BaseR in its platform file. > > > > > > > > We also introduce one Kconfig option for users to override the > > > > default Xen start address of selected platform, if they think > > > > the default address doesn't suit their scenarios. For this > > > > Kconfig option, we use an unaligned address "0xffffffff" as the > > > > default value to indicate that users haven't used a customized > > > > Xen start address. > > > > > > > > And as we introduced Armv8-R platforms to Xen, that means the > > > > existed Arm64 platforms should not be listed in Armv8-R platform > > > > list, so we add !ARM_V8R dependency for these platforms. > > > > > > > > Signed-off-by: Wei Chen > > > > Signed-off-by: Jiamei.Xie > > > > --- > > > > xen/arch/arm/Kconfig | 11 +++++++++++ > > > > xen/arch/arm/include/asm/platforms/fvp_baser.h | 14 ++++++++++++++ > > > > > > I looked at the content of fvp_baser.h after this series is applied. > > > There are a bit of boiler plate that I expect to be part for other > > > platforms. In particular... > > > > > > > xen/arch/arm/platforms/Kconfig | 16 +++++++++++++--- > > > > 3 files changed, 38 insertions(+), 3 deletions(-) > > > > create mode 100644 xen/arch/arm/include/asm/platforms/fvp_baser.h > > > > > > > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > > > > index ad592367bd..ac276307d6 100644 > > > > --- a/xen/arch/arm/Kconfig > > > > +++ b/xen/arch/arm/Kconfig > > > > @@ -138,6 +138,17 @@ config TEE > > > > This option enables generic TEE mediators support. It allows > > > guests > > > > to access real TEE via one of TEE mediators implemented in > > > > XEN. > > > > > > > > +config XEN_START_ADDRESS > > > > + hex "Xen start address: keep default to use platform defined > > > address" > > > > + default 0xFFFFFFFF > > > > > > ... this default value will need to be tested everywhere. At least for > > > now, I think you can avoid the per platform header by using the Kconfig > > > to select the proper address (see the config for selecting early printk > > > address). > > > > > > This will also avoids to use an invalid value here. > > > > > > > We had considered to use Kconfig to define the start addresses of v8R64 > > platforms (prompt users to input the address). But we also want to provide > > a default start address for each platform (Discussed in [1], header for > > default value, Kconfig option for customized address). > Why do you want to provide a default value? And how it is guaranteed that it > will work for most of the users? > > > > > We also had thought to use Kconfig to define a default start address > > for each platform like what we had done for early printk in RFC[2]. > > But this method has been deprecated. > > Most of the current Xen is board agnostic except the UART. We push back the > addition of new one because the address can be found in the firmware table and > I wanted to avoid increase the number of option (there are dozens of platform > out...). > > > > > So if we don’t use header files, just use the Kconfig, we can't > > provide a default start address for platforms, and have to force users > > to enter the start address. > > I am not sure I see the problem to force the user to enter the start address. > My worry with per-platform default value is we end up to force each vendor to > provide an header in order to boot Xen. > > I think it would be better to provide a config tailored for that platform > (whether it is part of Xen can be debatable). This would allow a user to try a > release Xen on their platform with zero changes in the code. I agree with Julien, especially on this last point. Of course we need a default configuration for a given platform, we don't want every user of the same platform to have to go and look at the manual to find the right address to use. The question is where to put the per-platform default value. The kconfig "default" keyword is not great for that and it is not realistic to have a single address that works everywhere. Instead, we could have a prepopulated kconfig under xen/arch/arm/configs, or something under ImageBuilder, or maybe expand the existing "Platform Support" kconfig menu. If this was just XEN_START_ADDRESS, I would suggest to keep it in xen.git somewhere. But given that there are a few addresses and sizes to provide/calculate for Xen on MPU to work, using ImageBuilder could be a good idea. --8323329-600931272-1668118352=:50442-- From xen-devel-bounces@lists.xenproject.org Thu Nov 10 22:25:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 22:25:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442237.696291 (Exim 4.92) (envelope-from ) id 1otFzR-0008JX-SF; Thu, 10 Nov 2022 22:25:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442237.696291; Thu, 10 Nov 2022 22:25:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otFzR-0008JQ-OC; Thu, 10 Nov 2022 22:25:41 +0000 Received: by outflank-mailman (input) for mailman id 442237; Thu, 10 Nov 2022 22:25:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otFzQ-0008JK-Kv for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 22:25:40 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9a19ac1b-6146-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 23:25:38 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7E80461E72; Thu, 10 Nov 2022 22:25:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BDD7C433D6; Thu, 10 Nov 2022 22:25:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a19ac1b-6146-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668119136; bh=OGXpqZOsihHBOHJJuEZehP/mdsP7AIgnzmZBombuNoo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=utz3zyNTDi/CrMVlbfwbTQb01cGtaJMbfSc8LZ+RT1YDldIqcXggd0NXG0k5THw7D 3eOXuyNdrILItvyZEz1CSr2ttxE0dpMpc2/ogaOCaL5oR7J1wK96+qUnPF+AaJJ5/F IWFU3VMkprm/m+eHW7ukIYw71dha0pzqOOVXD139n0mkfu3hmGC/ckudPMUDnMQ4Ym 5iPPbk7OfMInmR1FUosdnZn5Qez3tDxJFrc2Inx+mIvL1pjNdRd2fXsejN3o4+aTci iheZkMr1oCygj2VP9WUC0GxKyxttKaC9z/4n8/8SBoASw/AqkSScft48QDfvux6jQD 4szqh2JDG0w3g== Date: Thu, 10 Nov 2022 14:25:34 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Wei Chen cc: Julien Grall , "xen-devel@lists.xenproject.org" , nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 In-Reply-To: Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <9c3bfa0c-2c8f-2160-46d1-3be234b5bcaf@xen.org> <88c909b5-4cad-aab0-2acd-fb3519963128@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-523053921-1668119039=:50442" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-523053921-1668119039=:50442 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Mon, 7 Nov 2022, Wei Chen wrote: > Hi Julien, > > > -----Original Message----- > > From: Julien Grall > > Sent: 2022年11月7日 18:16 > > To: Wei Chen ; xen-devel@lists.xenproject.org > > Cc: nd ; Stefano Stabellini ; Bertrand > > Marquis ; Volodymyr Babchuk > > > > Subject: Re: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - > > Part#1 > > > > > > > > On 07/11/2022 09:52, Wei Chen wrote: > > > Hi Julien, > > > > Hi, > > > > > > > >>> - Supports only a single Security state - Secure. > > >>> - MPU in EL1 & EL2 is configurable, MMU in EL1 is configurable. > > >>> > > >>> These patch series are implementing the Armv8-R64 MPU support > > >>> for Xen, which are based on the discussion of > > >>> "Proposal for Porting Xen to Armv8-R64 - DraftC" [1]. > > >>> > > >>> We will implement the Armv8-R64 and MPU support in three stages: > > >>> 1. Boot Xen itself to idle thread, do not create any guests on it. > > >> > > >> I read this as I can build Xen and see it boots (not creating domain). > > >> However... HAS_MPU is not defined and I was expecting mm.c to be > > >> modified to cater the MPU support. So I am a bit ensure what the series > > >> is actually doing. > > >> > > > > > > These 11 patches are part#1 of stage#1, the full stage#1 has about 30 > > > patches. We have some concerns if we send so many patches at once, the > > > review pressure of maintainers may be very high, so we only choose about > > > 10 to send as part of it. But this also means that we can't do a > > relatively > > > complete thing in this part#1 series. > > > > > > We want to hear some suggestions from you to make so many patches can be > > > Reviewed efficiently. Can we send the patches by stages, even the > > stage#1 > > > will have about 30 patches? > > > > 30 patches in a go is no too bad. I would personally prefer that because > > at least I have better idea of the shape of the code after stage#1 and > > also possibly test it (I need to check if I have access for the ARMv8-R > > model). > > > > I also prefer to this way. After we have addressed the comments in > this series, we will send the full stage#1 patches together in v2. One suggestion to make things easier to review and to commit is to organize the series in a way so that the first 10 patches can still be committed first independently, even if all 30 patches are sent together. Or alternatively only send 10 patches but also add a link to a github/gitlab tree with all the 30+ patches so that maintainers can have a look how the whole work fit together. I think we are all on the same page -- I just wanted to highlight that we don't have to finish the review of all 30 patches before we can start committing some of the initial patches in the series. Cheers, Stefano --8323329-523053921-1668119039=:50442-- From xen-devel-bounces@lists.xenproject.org Thu Nov 10 22:47:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 22:47:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442243.696302 (Exim 4.92) (envelope-from ) id 1otGKL-0002eQ-IH; Thu, 10 Nov 2022 22:47:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442243.696302; Thu, 10 Nov 2022 22:47:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otGKL-0002eJ-F3; Thu, 10 Nov 2022 22:47:17 +0000 Received: by outflank-mailman (input) for mailman id 442243; Thu, 10 Nov 2022 22:47:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otGKJ-0002eD-SR for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 22:47:16 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9cdf32bf-6149-11ed-91b5-6bf2151ebd3b; Thu, 10 Nov 2022 23:47:13 +0100 (CET) Received: from mail-dm3nam02lp2049.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Nov 2022 17:47:09 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO3PR03MB6726.namprd03.prod.outlook.com (2603:10b6:303:17d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Thu, 10 Nov 2022 22:47:07 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5791.027; Thu, 10 Nov 2022 22:47:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cdf32bf-6149-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668120433; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=HygNMoa1zA5IOSkG7shyTOV+OSbjkPOmrang5ai7tI0=; b=cMm5NAskj17LkHW751mUPIw3XC7kR5Q47nWufAeaIyaRR6vL+6O7/ghD knFxDb5H23m3JnqYgpK8unP5QCUzSTvrKI9WobmoIFX6dwt6AyV7iwX9r e9VpPDpX5G29ZUr93vQiBOXSOA5Hl57p0tIJY7tFVIfNlPovVI1xACYCp I=; X-IronPort-RemoteIP: 104.47.56.49 X-IronPort-MID: 84626398 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Ss8X8a0rmfWhsHA6XfbD5SBwkn2cJEfYwER7XKvMYLTBsI5bpzdRz WVJCm6GOK2NYWfyc41/PIW38xgFsZTWm9RgGwA/pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVnPagX1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfGyJx7 +AeGRQ3ciuHrb6y6b/nEsB2v5F2RCXrFNt3VnBI6xj8VaxjbbWYBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvS6PnWSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzX+lAtxJRe3QGvhCuHfO5EdMNzEtUUqhqvielmuAAfVON BlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQPwrstUnAwMj0 FChlsnsQzdotdW9UXuA8p+EoDX0PjIaRUcdYQcUQA1D5MPsyKkxhB/SStdoEIauk8b4Xzr3x liirjU4wbMajscJ1qCy1VHBnz+o4JPOS2Yd5QjJX2Tj8gJwYqakYZCl7R7Q6vMoEWqCZlyIv XxBl83F6ukLVcuJjHbVHLRLG6y17fGYNjGamURoA5Qq6zWq/TikYJxU5zZ9YkxuN67oZAPUX aMagisJjLc7AZdgRfYfj16ZYyjy8ZXdKA== IronPort-HdrOrdr: A9a23:MTIDCK/cCID+mZwXOa5uk+GBdr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrbX5To3SJjUO31HYY72KjLGSjgEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpgdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1cjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3bRY0eTFcZcso+5zXQISdKUmREXeR 730lEd1vFImjbsl6eO0ELQMkfboW4TAjTZuCKlaDPY0LDErXQBeot8bMtiA2XkAwBLhqAC7I tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0WbWKwUs4ikWUzxjIiLH47JlOy1Kk3VO 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEy82IIgMgE2nsQ/pM0TJdJo+ zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBNB1vd75rspLkl7uCjf5IFiJM0hZ TaSVtd8XU/fkr/YPf+q6GjMiq9NFlVcQ6duf22vaIJy4EUbICbQRGrWRQpj9aqpekZD4nSR+ uzUagmdsPeEQ== X-IronPort-AV: E=Sophos;i="5.96,155,1665460800"; d="scan'208";a="84626398" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KCJnHGirYi14b37lekF70Tn19E+qHhRLibEHaKV12xzkRKZaHGaXUT4RlxjmiB5QtGt9UWKDW3Me0m24NKbLi2Qz1Rt+D5TgI43vzZ2KLU9s3c6w3GSBhCiy6g9uHHu0CP49CcVUaZVCwhBux+pboGwBBvL3JZ0PFKWPKiao0DubWYZeR6ikGGb0rCbuuApHiBMqrdOg2vHOASaY7I4Kx6CAt8rWw33GqzyEOyrZXduuz4UKOgrz5I5M8vJJE/rCQOfQxc+e5uC6F4qiLuNlAt3rrYZ+J8xChwveUa3YHb4C6SLlYxzOYl6dONzCBeL92dOq5BKYtKmslVd5kZ2BhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HygNMoa1zA5IOSkG7shyTOV+OSbjkPOmrang5ai7tI0=; b=RHg2LYmxVL/4ijOPAxhENOG7h72Cyl4sfXIZxGdGb7ZTlDB77o3c7s7CS+C1DtRN0/ocys1hvbGAB1xHyWd2t/1njNummBiO6b7rRK6XPsy3cYIhzc6m+VJH8wIOjpeSjPt6QI/X+1BsSCMFOHMuIkqRNKyHjQYGnkoLXTb28oiZeMneYxULVC3oZ+We1u9KNjts8g3wfbELZNgyR9Nafw+SuTFmRtkAszwj/fi7BPwHNlF/3w7/6CP0pFjkMYkO9be0csrHxSeHFInSBRfeKdN5YTVBL8W1Dek9oq60RHTB7OoGm6QSABRHEZUL5rvgu30gc1WfkfPRQkqPXyr/yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HygNMoa1zA5IOSkG7shyTOV+OSbjkPOmrang5ai7tI0=; b=i1tJkCPEC4ifUwngNuHxLCLYKqgQaHtCBM/xTUb2/yaQDHlCte48Pnvj6vaYyN1oZ+fEfPgMOvAwtri7b25mG7V5KlUI3JffG/iyoFuaqxVn670EzwR2rsHoLKafs9LFvuhj2nQvXBNNs+k7pmeVH99FzJsLy7gx/e7LjXZtOLA= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: "Henry.Wang@arm.com" , Paul Durrant , Wei Liu , Jan Beulich , Jun Nakajima , Kevin Tian Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Thread-Topic: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Thread-Index: AQHY8GkXjZEVf2M/t0iebvsck9V8qq44y+aA Date: Thu, 10 Nov 2022 22:47:07 +0000 Message-ID: <69841767-ccc4-5eeb-6e9c-d59dfb197ea5@citrix.com> References: <20221104161815.38007-1-roger.pau@citrix.com> In-Reply-To: <20221104161815.38007-1-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CO3PR03MB6726:EE_ x-ms-office365-filtering-correlation-id: 0eafad21-df8a-44f8-c8b5-08dac36d7f1b x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SlNfYzIqSmb7+FDTirksYMxVxu/NIWp2+lhaPAN1/vwkGKD+A3/ZT6lCOz8bU/hrxgrVaONgz9bWpyuwc9NTypeaWOFQByYmOk+C7tuE/mi0EV7+44X3c2wv3hPxNNVMgT3rIkX1D7b3W3hrHlHj4EwNjbmv9lZkqhMripWTqN8tA9bmfdVfU+66uAYqItKbqZAcZ8GNzp/0wgpcN5gDG+RiSrwvjUZHIE5u/advuR8IE4uw8b3KUzzHLteILQvdQ1NIwSSj+az2sKRP0ELQlzbdxD6gYlsaTxWFV7NN/W8wriC5I/t6VyV7a5S60Us/FF123CkkK/1X1Pxnq4Me5kyltiaL9veHyl6mIwHiHFc/ttAp6YBmZZ53waR7hvcCNt9xTX/iIqRbd9kAaOPhcnCELoEs0z6VD9EPK3MMFRsMsuaDMsrKwk+iCQVW+U0p52hrbMnANZ//krWzrkAWlD62IqRNozBLnL/UnVxjob+InaB5O/7lnriV7O2fm4LLvDK/yrY2xmVyuMByNOIW1hTzxngrL48yel3CLOu8X0t7+gVLwsR/okGXT+HWE9HeLBaeqqTAQ8j6TsV1LNLYmUhK0xEr84gPm1WghhYzbeD2m4yBW2klB6JUzvDW/Q14UKZ+Rv7pN2y9YNXGoHudWEI7kIT37hiYoFI1f2APMT7BtGflIcj6q5eX1Zb9pipcMuonh8wCMxhn6eP55veNPrAFAq1WMNTrge9OlgZyrtVtyyRMBd+rdp/3KZjcq+dY1nOgSl1oWq1+weUsynAefo+CllsSqwzP/x9hJ2vJGnyj0PT378xlIFoxWYG7PQrwPv7zYxiEshSqCvPzFpzixQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(366004)(376002)(136003)(451199015)(54906003)(8936002)(110136005)(31696002)(5660300002)(2616005)(91956017)(86362001)(66476007)(4326008)(36756003)(66946007)(8676002)(26005)(66446008)(66556008)(6512007)(64756008)(76116006)(6486002)(316002)(83380400001)(41300700001)(53546011)(478600001)(82960400001)(122000001)(71200400001)(31686004)(38100700002)(2906002)(6506007)(186003)(38070700005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bW4vT21ITTNGWDNGKy8xRXY5OU44VWRiTG4wWVJ0MGxZNHFkMGtHRVJVNTMr?= =?utf-8?B?UUZqaDFPaE8yZi9ubCtyK3RMZXhWVDVGYlhsOWZQVE9UemhsanlsYnJZYmg2?= =?utf-8?B?T2NnbDFzYmxGRStlQ2U3SXdzOXUzMFlpMVdkR0xCY1d5clU2L2V1NlRVM0la?= =?utf-8?B?WTVKbGthMTB6Z0N1ZEhnL21IV3VHc2tQYXhJVnQvRTdiOEtmOGcvUkJOemEr?= =?utf-8?B?RWlUREtPcDFMTGN6ZFkyRUx6ZVRJeTJ6Uy95cy9scHl6VFdBUGozbFByaTdS?= =?utf-8?B?eUthYW1SMTN4VGhJcUYzZDdYLzY1ZTJPZG0ySzZQWlpDTTl6ckR1Q1QrOHI2?= =?utf-8?B?dDNLdVBnYjQrVGpkOUg3eko3U01nNUFaYTAxQzJ3L3VtYTI5eDZ5MDhmSjUw?= =?utf-8?B?cHBRdkUyRDQvTzNLNDVGRGE4MFk3bHdQSHZBMGcrMGVETDZYcUdIdHRxVzRB?= =?utf-8?B?MlpDVmVTSStPY1FscXQxWFRPYVp4dHZDZXlzamFKdlNVZjNhbkIxM3EvQzVz?= =?utf-8?B?QUtEUTlQWUtobU1wc2RqQkhtUGpycStHRkhhWDBDcXRFWWxiYzM5UHZiQ2dC?= =?utf-8?B?c2tONDQ3U0F6d0czU2dSUi9wSklDRW92TkJDaXdvdlQwUXZ1Q2pZei9DNEcz?= =?utf-8?B?a1NFSWhWR0I2SjRRSitBT0pIL3RHRkExdFV6UzltUy9oL3ZvV01rM2Y1OTlD?= =?utf-8?B?TnNUbWJ3MWZDSGV6ZG1rLzRPTFZoekcrZkNyTWgrRTlSb2g5V3h0MXNRd2gw?= =?utf-8?B?SDMvdVg2NVdqSVhkYkpGclRKRVJPNjFDaXoyUGV0NTRkNnd1ZDF0bEl5SW9y?= =?utf-8?B?OUJuOWYzNXA3SVdJWEI0N3o0aEovV1gxR3pDREZyOE5SSlFiN0huWjM1ZnpD?= =?utf-8?B?QVdiRVhsZWZJVWg2anhraWRiVXdnRHRYWmxzbExWWWl2S2l5dXNVSWZiMXVa?= =?utf-8?B?OGk4dHBTazFQWG9SWW9RSjdsV3cwOHlvVmVUL0RpSXUraEdWaVBOUVJ4dW9U?= =?utf-8?B?d0M3b3ZrUWZpeEZWaWwzTC9QV0lxYk52YWlZOGY0UUF2Qm5zWGlGYWpCRXpJ?= =?utf-8?B?aE55bHZQb1Y3WTNYYWFneHJVSytxY3EyS0tTc1VaNnBPd1pEbkNTNVFVMEQ4?= =?utf-8?B?cmVJTFZLM1pPNmh2eHMxTWd5UllHQm0vWkxiby9PbitrYXUyOUpESlFLeFRY?= =?utf-8?B?eWdqMkV1Zk80ZjZJWWxPUHVqMVp1VXVPcVNYSWQvc1B0S09OTlBjbStKbkNP?= =?utf-8?B?c0k5dkM1NjVsZTdUdi9QSnlhTzd1Y2FFb0ZBSzI2M1pBMlRHbHZyUEpPK0Jl?= =?utf-8?B?ak92TUI2T1EreWxUcmJ3NFlmQlE0d1ozdnY5anBNRkFLNGpWSGtQTFFuWUNt?= =?utf-8?B?MUVFTXpYVTZWWXczdjVBZmQvRmNnUXBSVE5iMWpqSno0ZHk3M1BFVHdZUzIr?= =?utf-8?B?KzJ2cVVpbGIyVm5wWFRIVE5Pbk5CNnZmbU9KMCtFUGs0TVYycko2S0Z2WUZN?= =?utf-8?B?TnRKRndDaVBQbVdPaC93Rm05UDZLVTRqdkxjcHRUam1OKzlTYWw5bnRFVGVx?= =?utf-8?B?QkhjOThqbmV4S1B5U0tBSWQxeU9qV2ZUeWdOSEZpcEJjWnJONXgwT2p4ckZ6?= =?utf-8?B?SGxOb01neDQ4VitDWlJaSkw4Nm4xWEFxNXhCZ1hyQ3AvVXU1aG5uSHV2dmpy?= =?utf-8?B?Q25vWkxhREgzSnM3NEwzejZ0TWcrNVRqejN6QlVpMEdqRVJmMjZGb1o3WjFM?= =?utf-8?B?L1Bmd1V0RFhsQkhtSWRSTEd3MWVuUDlmazd6UDE2c0N3V1FveFkxd3greXFT?= =?utf-8?B?dU9oV2ZRblR0a00yb0Z1NHZtTFN4LzJQMHlYK25xNXBCcG5UUG5valJLZ21j?= =?utf-8?B?TzRLaUVJZUhiRld3bnZJakdITUZDVG1NWmpySlY3Y3B5MnBJTDc5QitmaENs?= =?utf-8?B?MGlVQzY2aWt0ZWUxV3B1NTV6eElibStoZitpQktqb1lCU2NXZEkzcitlN2Vm?= =?utf-8?B?VWIwN05RQWcvaFZXdzVkdnZySytmZE1DQmlZMCtTRk1VUXp0ZWRFVDR5Qkl1?= =?utf-8?B?ZmVqcVNERUdEOHB2Y2xKa2wxRmhXM1hqVmNHM2NhVjBCR2lBV3ZLSjVLYmd4?= =?utf-8?Q?DH1Z1YAeu/vV8vweivAvK4Txf?= Content-Type: text/plain; charset="utf-8" Content-ID: <399A8C83E6496C4F8946E0917301CEFD@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0eafad21-df8a-44f8-c8b5-08dac36d7f1b X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2022 22:47:07.7569 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JAZdSS0KAUVQIxnoiD5q25BsTtGBhmIlCjALI/C6a8G3HQzCkoHVwozU9STzUYxxt28lQynpz2F6ACjjZB3aRK6NmhdtnBVrQhYeDRl0Kqs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6726 T24gMDQvMTEvMjAyMiAxNjoxOCwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBUaGUgY3VycmVu dCByZXBvcnRpbmcgb2YgdGhlIGhhcmR3YXJlIGFzc2lzdGVkIEFQSUMgb3B0aW9ucyBpcyBkb25l IGJ5DQo+IGNoZWNraW5nICJ2aXJ0dWFsaXplIEFQSUMgYWNjZXNzZXMiIHdoaWNoIGlzIG5vdCB2 ZXJ5IGhlbHBmdWwsIGFzIHRoYXQNCj4gZmVhdHVyZSBkb2Vzbid0IGF2b2lkIGEgdm1leGl0LCBp bnN0ZWFkIGl0IGRvZXMgcHJvdmlkZSBzb21lIGhlbHAgaW4NCj4gb3JkZXIgdG8gZGV0ZWN0IEFQ SUMgTU1JTyBhY2Nlc3NlcyBpbiB2bWV4aXQgcHJvY2Vzc2luZy4NCj4NCj4gUmVwdXJwb3NlIHRo ZSBjdXJyZW50IHJlcG9ydGluZyBvZiB4QVBJQyBhc3Npc3RhbmNlIHRvIGluc3RlYWQgcmVwb3J0 DQo+IHN1Y2ggZmVhdHVyZSBhcyBwcmVzZW50IHdoZW4gdGhlcmUncyBzdXBwb3J0IGZvciAiVFBS IHNoYWRvdyIgYW5kDQo+ICJBUElDIHJlZ2lzdGVyIHZpcnR1YWxpemF0aW9uIiBiZWNhdXNlIGlu IHRoYXQgY2FzZSBzb21lIHhBUElDIE1NSU8NCj4gcmVnaXN0ZXIgYWNjZXNzZXMgYXJlIGhhbmRs ZWQgZGlyZWN0bHkgYnkgdGhlIGhhcmR3YXJlLCB3aXRob3V0DQo+IHJlcXVpcmluZyBhIHZtZXhp dC4NCj4NCj4gRm9yIHN5bWV0cnkgYWxzbyBjaGFuZ2UgYXNzaXN0ZWQgeDJBUElDIHJlcG9ydGlu ZyB0byByZXF1aXJlDQo+ICJ2aXJ0dWFsaXplIHgyQVBJQyBtb2RlIiBhbmQgIkFQSUMgcmVnaXN0 ZXIgdmlydHVhbGl6YXRpb24iLCBkcm9wcGluZw0KPiB0aGUgb3B0aW9uIHRvIGFsc28gYmUgcmVw b3J0ZWQgd2hlbiAidmlydHVhbCBpbnRlcnJ1cHQgZGVsaXZlcnkiIGlzDQo+IGF2YWlsYWJsZS4g IFByZXNlbmNlIG9mIHRoZSAidmlydHVhbCBpbnRlcnJ1cHQgZGVsaXZlcnkiIGZlYXR1cmUgd2ls bA0KPiBiZSByZXBvcnRlZCB1c2luZyBhIGRpZmZlcmVudCBvcHRpb24uDQo+DQo+IEZpeGVzOiAy Y2UxMWNlMjQ5ICgneDg2L0hWTTogYWxsb3cgcGVyLWRvbWFpbiB1c2FnZSBvZiBoYXJkd2FyZSB2 aXJ0dWFsaXplZCBBUElDJykNCj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9n ZXIucGF1QGNpdHJpeC5jb20+DQo+IC0tLQ0KPiBJIGZpbmQgdGhlIGxvZ2ljIGluIHZteF92bGFw aWNfbXNyX2NoYW5nZWQoKSBoYXJkIHRvIGZvbGxvdywgYnV0IEkNCj4gZG9uJ3Qgd2FudCB0byBy ZXdyaXRlIHRoZSBmdW5jdGlvbiBsb2dpYyBhdCB0aGlzIHBvaW50Lg0KPiAtLS0NCj4gQ2hhbmdl cyBzaW5jZSB2MToNCj4gIC0gRml4IFZpcmlkaWFuIE1TUiB0aXAgY29uZGl0aW9ucy4NCj4gLS0t DQo+ICB4ZW4vYXJjaC94ODYvaHZtL3ZpcmlkaWFuL3ZpcmlkaWFuLmMgfCAgMiArLQ0KPiAgeGVu L2FyY2gveDg2L2h2bS92bXgvdm1jcy5jICAgICAgICAgIHwgIDggKysrKy0tLS0NCj4gIHhlbi9h cmNoL3g4Ni9odm0vdm14L3ZteC5jICAgICAgICAgICB8IDI1ICsrKysrKysrKysrKysrKysrKy0t LS0tLS0NCj4gIHhlbi9hcmNoL3g4Ni90cmFwcy5jICAgICAgICAgICAgICAgICB8ICA0ICstLS0N Cj4gIDQgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pDQo+ DQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3ZpcmlkaWFuL3ZpcmlkaWFuLmMgYi94 ZW4vYXJjaC94ODYvaHZtL3ZpcmlkaWFuL3ZpcmlkaWFuLmMNCj4gaW5kZXggMjVkY2E5M2U4Yi4u NDRlYjNkMDUxOSAxMDA2NDQNCj4gLS0tIGEveGVuL2FyY2gveDg2L2h2bS92aXJpZGlhbi92aXJp ZGlhbi5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vdmlyaWRpYW4vdmlyaWRpYW4uYw0KPiBA QCAtMTk3LDcgKzE5Nyw3IEBAIHZvaWQgY3B1aWRfdmlyaWRpYW5fbGVhdmVzKGNvbnN0IHN0cnVj dCB2Y3B1ICp2LCB1aW50MzJfdCBsZWFmLA0KPiAgICAgICAgICByZXMtPmEgPSBDUFVJRDRBX1JF TEFYX1RJTUVSX0lOVDsNCj4gICAgICAgICAgaWYgKCB2aXJpZGlhbl9mZWF0dXJlX21hc2soZCkg JiBIVk1QVl9oY2FsbF9yZW1vdGVfdGxiX2ZsdXNoICkNCj4gICAgICAgICAgICAgIHJlcy0+YSB8 PSBDUFVJRDRBX0hDQUxMX1JFTU9URV9UTEJfRkxVU0g7DQo+IC0gICAgICAgIGlmICggIWNwdV9o YXNfdm14X2FwaWNfcmVnX3ZpcnQgKQ0KPiArICAgICAgICBpZiAoICFoYXNfYXNzaXN0ZWRfeGFw aWMoZCkgKQ0KPiAgICAgICAgICAgICAgcmVzLT5hIHw9IENQVUlENEFfTVNSX0JBU0VEX0FQSUM7 DQoNClRoaXMgY2hlY2sgaXMgYnJva2VuIGJlZm9yZSBhbmQgYWZ0ZXIuwqAgSXQgbmVlZHMgdG8g YmUga2V5ZWQgb24NCnZpcnR1YWxpc2VkIGludGVycnVwdCBkZWxpdmVyeSwgbm90IHJlZ2lzdGVy IGFjY2VsZXJhdGlvbi4NCg0KQnV0IGRvaW5nIHRoaXMgY29ycmVjdGx5IG5lZWRzIGEgcGVyLWRv bWFpbiB2aW50ciBzZXR0aW5nLCB3aGljaCB3ZQ0KZG9uJ3QgaGF2ZSB5ZXQuDQoNCkl0IGlzIG1h cmdpbmFsbHkgbGVzcyBicm9rZW4gd2l0aCB0aGlzIGNoYW5nZSwgdGhhbiB3aXRob3V0LCBidXQg dGhhdCdzDQpub3Qgc2F5aW5nIG11Y2guDQoNCj4gICAgICAgICAgaWYgKCB2aXJpZGlhbl9mZWF0 dXJlX21hc2soZCkgJiBIVk1QVl9oY2FsbF9pcGkgKQ0KPiAgICAgICAgICAgICAgcmVzLT5hIHw9 IENQVUlENEFfU1lOVEhFVElDX0NMVVNURVJfSVBJOw0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gv eDg2L2h2bS92bXgvdm1jcy5jIGIveGVuL2FyY2gveDg2L2h2bS92bXgvdm1jcy5jDQo+IGluZGV4 IGExYWNhMWVjMDQuLjdiYjk2ZTFhOGUgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0v dm14L3ZtY3MuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMNCj4gQEAgLTEx MzYsNyArMTEzNiw3IEBAIHN0YXRpYyBpbnQgY29uc3RydWN0X3ZtY3Moc3RydWN0IHZjcHUgKnYp DQo+ICANCj4gICAgICBpZiAoICFoYXNfYXNzaXN0ZWRfeGFwaWMoZCkgKQ0KPiAgICAgICAgICB2 LT5hcmNoLmh2bS52bXguc2Vjb25kYXJ5X2V4ZWNfY29udHJvbCAmPQ0KPiAtICAgICAgICAgICAg flNFQ09OREFSWV9FWEVDX1ZJUlRVQUxJWkVfQVBJQ19BQ0NFU1NFUzsNCj4gKyAgICAgICAgICAg IH5TRUNPTkRBUllfRVhFQ19BUElDX1JFR0lTVEVSX1ZJUlQ7DQo+ICANCj4gICAgICBpZiAoIGNw dV9oYXNfdm14X3NlY29uZGFyeV9leGVjX2NvbnRyb2wgKQ0KPiAgICAgICAgICBfX3Ztd3JpdGUo U0VDT05EQVJZX1ZNX0VYRUNfQ09OVFJPTCwNCj4gQEAgLTIxNTYsMTAgKzIxNTYsMTAgQEAgaW50 IF9faW5pdCB2bXhfdm1jc19pbml0KHZvaWQpDQo+ICAgICAgaWYgKCAhcmV0ICkNCj4gICAgICB7 DQo+ICAgICAgICAgIC8qIENoZWNrIHdoZXRoZXIgaGFyZHdhcmUgc3VwcG9ydHMgYWNjZWxlcmF0 ZWQgeGFwaWMgYW5kIHgyYXBpYy4gKi8NCj4gLSAgICAgICAgYXNzaXN0ZWRfeGFwaWNfYXZhaWxh YmxlID0gY3B1X2hhc192bXhfdmlydHVhbGl6ZV9hcGljX2FjY2Vzc2VzOw0KPiArICAgICAgICBh c3Npc3RlZF94YXBpY19hdmFpbGFibGUgPSBjcHVfaGFzX3ZteF90cHJfc2hhZG93ICYmDQo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNwdV9oYXNfdm14X2FwaWNfcmVnX3Zp cnQ7DQo+ICAgICAgICAgIGFzc2lzdGVkX3gyYXBpY19hdmFpbGFibGUgPSBjcHVfaGFzX3ZteF92 aXJ0dWFsaXplX3gyYXBpY19tb2RlICYmDQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoY3B1X2hhc192bXhfYXBpY19yZWdfdmlydCB8fA0KPiAtICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGNwdV9oYXNfdm14X3ZpcnR1YWxfaW50cl9kZWxpdmVyeSk7 DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjcHVfaGFzX3ZteF9hcGlj X3JlZ192aXJ0Ow0KDQphcGljIHJlZyB2aXJ0IGFscmVhZHkgZGVwZW5kcyBvbiB0cHIgc2hhZG93 LCBzbyB0aGF0IHBhcnQgb2YgdGhlDQpjb25kaXRpb24gaXMgcmVkdW5kYW50Lg0KDQp2aXJ0dWFs aXNlIHgyYXBpYyBtb2RlIGFuZCBhcGljIHJlZyB2aXJ0IGFyZW4ndCBkZXBlbmRlbnQsIGJ1dCB0 aGV5IGRvDQpvbmx5IGV2ZXIgYXBwZWFyIHRvZ2V0aGVyIGluIGhhcmR3YXJlLg0KDQpLZWVwaW5n IHRoZSBjb25kaXRpb25hbHMgbWlnaHQgYmUgb2sgdG8gY29tYmF0IGEgYmFkIG91dGVyIGh5cGVy dmlzb3IsDQpidXQgLi4uDQoNCj4gICAgICAgICAgcmVnaXN0ZXJfa2V5aGFuZGxlcigndicsIHZt Y3NfZHVtcCwgImR1bXAgVlQteCBWTUNTcyIsIDEpOw0KPiAgICAgIH0NCj4gIA0KPiBkaWZmIC0t Z2l0IGEveGVuL2FyY2gveDg2L2h2bS92bXgvdm14LmMgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92 bXguYw0KPiBpbmRleCBlNjI0YjQxNWM5Li5iZjBmZTMzNTVjIDEwMDY0NA0KPiAtLS0gYS94ZW4v YXJjaC94ODYvaHZtL3ZteC92bXguYw0KPiArKysgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bXgu Yw0KPiBAQCAtMzQwNSwyNSArMzQwNSwyOSBAQCBzdGF0aWMgdm9pZCB2bXhfaW5zdGFsbF92bGFw aWNfbWFwcGluZyhzdHJ1Y3QgdmNwdSAqdikNCj4gIA0KPiAgdm9pZCB2bXhfdmxhcGljX21zcl9j aGFuZ2VkKHN0cnVjdCB2Y3B1ICp2KQ0KPiAgew0KPiArICAgIGJvb2wgdmlydHVhbGl6ZV94MmFw aWNfbW9kZSA9IGhhc19hc3Npc3RlZF94MmFwaWModi0+ZG9tYWluKSB8fA0KPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChjcHVfaGFzX3ZteF92aXJ0dWFsaXplX3gyYXBpY19t b2RlICYmDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNwdV9oYXNfdm14 X3ZpcnR1YWxfaW50cl9kZWxpdmVyeSk7DQoNCi4uLiB0aGlzIGlzIHN0aWxsIHdyb25nLCBhbmQg Li4uDQoNCj4gICAgICBzdHJ1Y3QgdmxhcGljICp2bGFwaWMgPSB2Y3B1X3ZsYXBpYyh2KTsNCj4g ICAgICB1bnNpZ25lZCBpbnQgbXNyOw0KPiAgDQo+IC0gICAgaWYgKCAhaGFzX2Fzc2lzdGVkX3hh cGljKHYtPmRvbWFpbikgJiYNCj4gLSAgICAgICAgICFoYXNfYXNzaXN0ZWRfeDJhcGljKHYtPmRv bWFpbikgKQ0KPiArICAgIGlmICggIWNwdV9oYXNfdm14X3ZpcnR1YWxpemVfYXBpY19hY2Nlc3Nl cyAmJg0KPiArICAgICAgICAgIXZpcnR1YWxpemVfeDJhcGljX21vZGUgKQ0KPiAgICAgICAgICBy ZXR1cm47DQoNCi4uLiB0aGlzIHN1cmVseSBjYW5ub3QgYmUgcmlnaHQuDQoNCldoaWxlIGF0dGVt cHRpbmcgdG8gZmlndXJlIF4gb3V0LCBJJ3ZlIGZvdW5kIHlldCBhbm90aGVyIHJlZ3Jlc3Npb24g dnMNCjQuMTYuwqAgQmVjYXVzZSB2aXJ0IGludHIgZGVsaXZlcnkgaXMgc2V0IGluIHRoZSBleGVj dXRpb24gY29udHJvbHMNCnN5c3RlbS13aWRlIGFuZCBub3QgY29udHJvbGxlZCBwZXIgZG9tYWlu LCB3ZSdsbCB0YWtlIGEgdm1lbnRyeSBmYWlsdXJlDQpvbiBTS1gvQ0xYL0lDWCB3aGVuIHRyeWlu ZyB0byBidWlsZCBhbiBIVk0gZG9tYWluIHdpdGhvdXQgeEFQSUMNCmFjY2VsZXJhdGlvbi4NCg0K DQpUaGlzLCBjb21iaW5lZCB3aXRoIHRoZSBBQkkgZXJyb3JzICgvbWlzZmVhdHVyZXMpIHRoYXQg d2UgcmVhbGx5IGRvbid0DQp3YW50IHRvIGVzY2FwZSBpbnRvIHRoZSB3b3JsZCBidXQgSSBoYXZl bid0IGZpbmlzaGVkIGZpeGluZyB5ZXQsIG1lYW5zDQp0aGF0IHRoZSBvbmx5IGFwcHJvcHJpYXRl IGNvdXJzZSBvZiBhY3Rpb24gaXMgdG8gcmV2ZXJ0Lg0KDQpJJ2QgcmVhbGx5IGhvcGVkIHRvIGF2 b2lkIGEgZnVsbCByZXZlcnQsIGJ1dCB3ZSd2ZSBydW4gb3V0IG9mIHRpbWUuDQoNCn5BbmRyZXcN Cg== From xen-devel-bounces@lists.xenproject.org Thu Nov 10 23:01:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 23:01:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442251.696313 (Exim 4.92) (envelope-from ) id 1otGY3-0005FD-TG; Thu, 10 Nov 2022 23:01:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442251.696313; Thu, 10 Nov 2022 23:01:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otGY3-0005F6-QD; Thu, 10 Nov 2022 23:01:27 +0000 Received: by outflank-mailman (input) for mailman id 442251; Thu, 10 Nov 2022 23:01:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otGY2-0005Eq-0J for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 23:01:26 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 999100ed-614b-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 00:01:24 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DC374B823D3; Thu, 10 Nov 2022 23:01:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 193C1C433D6; Thu, 10 Nov 2022 23:01:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 999100ed-614b-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668121282; bh=/9R3N4720f/BX838d0wuD/vGzbwI3ZUDkCT1+ryl9lY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=sKCszCjUIxQnvAZAUyn2460uVo2fXLAU14fSns8Bb/dYJ23vNV6V4KhYeZjKcUN0I f9D2BAD1ZZuLWcD1V5oW9NAP+/2Jikrl44KeBFsk6GWNOUWdD+cByj0Wq2KkET9CEe VNtMcdbBiHOsHiG07EtaSP4WS3EcZvc+rrHAclPat5URU5wpGuahEzmavnRw6IFcwR 77+uBW0310ThqRwtEYkr5/wwrjrcmxi/qGLpStzQ8CSJe9gMECHj94eJUHD2/F8nw7 /ittQBn3h/GKPImDlyJLs4I/Q4O0gm8VnsvJ3UqY3xTCrZF4jMf5psW1/U5TulIR6m aGCL4TQghP1IQ== Date: Thu, 10 Nov 2022 15:01:19 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Bertrand Marquis cc: Stefano Stabellini , Julien Grall , Rahul Singh , Xen developer discussion , Michal Orzel , Oleksandr Tyshchenko , Oleksandr Andrushchenko , Volodymyr Babchuk , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Andrew Cooper , Juergen Gross Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices In-Reply-To: <9F323893-B1C9-4D31-9A40-213345421860@arm.com> Message-ID: References: <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org> <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com> <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org> <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com> <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com> <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org> <82c45bc1-6052-502b-3007-8a16fbd1d433@xen.org> <9F323893-B1C9-4D31-9A40-213345421860@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-163733150-1668121282=:50442" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-163733150-1668121282=:50442 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Mon, 31 Oct 2022, Bertrand Marquis wrote: > Hi All, > > > On 30 Oct 2022, at 21:14, Stefano Stabellini wrote: > > > > On Sun, 30 Oct 2022, Julien Grall wrote: > >> Hi Stefano, > >> > >> On 30/10/2022 14:23, Stefano Stabellini wrote: > >>> On Fri, 28 Oct 2022, Julien Grall wrote: > >>>> On 28/10/2022 14:13, Bertrand Marquis wrote: > >>>>>> On 28 Oct 2022, at 14:06, Julien Grall wrote: > >>>>>> > >>>>>> Hi Rahul, > >>>>>> > >>>>>> On 28/10/2022 13:54, Rahul Singh wrote: > >>>>>>>>>>>> For ACPI, I would have expected the information to be > >>>>>>>>>>>> found in > >>>>>>>>>>>> the IOREQ. > >>>>>>>>>>>> > >>>>>>>>>>>> So can you add more context why this is necessary for > >>>>>>>>>>>> everyone? > >>>>>>>>>>> We have information for IOMMU and Master-ID but we don’t > >>>>>>>>>>> have > >>>>>>>>>>> information for linking vMaster-ID to pMaster-ID. > >>>>>>>>>> > >>>>>>>>>> I am confused. Below, you are making the virtual master ID > >>>>>>>>>> optional. So shouldn't this be mandatory if you really need > >>>>>>>>>> the > >>>>>>>>>> mapping with the virtual ID? > >>>>>>>>> vMasterID is optional if user knows pMasterID is unique on the > >>>>>>>>> system. But if pMasterId is not unique then user needs to > >>>>>>>>> provide > >>>>>>>>> the vMasterID. > >>>>>>>> > >>>>>>>> So the expectation is the user will be able to know that the > >>>>>>>> pMasterID > >>>>>>>> is uniq. This may be easy with a couple of SMMUs, but if you have > >>>>>>>> 50+ > >>>>>>>> (as suggested above). This will become a pain on larger system. > >>>>>>>> > >>>>>>>> IHMO, it would be much better if we can detect that in libxl (see > >>>>>>>> below). > >>>>>>> We can make the vMasterID compulsory to avoid complexity in libxl to > >>>>>>> solve this > >>>>>> > >>>>>> In general, complexity in libxl is not too much of problem. > >>> > >>> I agree with this and also I agree with Julien's other statement: > >>> > >>> "I am strongly in favor of libxl to modify it if it greatly improves the > >>> user experience." > >>> > >>> I am always in favor of reducing complexity for the user as they > >>> typically can't deal with tricky details such as MasterIDs. In general, > >>> I think we need more automation with our tooling. > >>> > >>> However, it might not be as simple as adding support for automatically > >>> generating IDs in libxl because we have 2 additional cases to support: > >>> 1) dom0less > >>> 2) statically built guests > >>> > >>> For 1) we would need the same support also in Xen? Which means more > >>> complexity in Xen. > >> Xen will need to parse the device-tree to find the mapping. So I am not > >> entirely convinced there will be more complexity needed other than requiring a > >> bitmap to know which vMasterID has been allocated. > >> > >> That said, you would still need one to validate the input provided by the > >> user. So overall maybe there will be no added complexity? > >> > >>> > >>> 2) are guests like Zephyr that consume a device tree at > >>> build time instead of runtime. These guests are built specifically for a > >>> given environment and it is not a problem to rebuild them for every Xen > >>> release. > >>> > >>> However I think it is going to be a problem if we have to run libxl to > >>> get the device tree needed for the Zephyr build. That is because it > >>> means that the Zephyr build system would have to learn how to compile > >>> (or crosscompile) libxl in order to retrieve the data needed for its > >>> input. Even for systems based on Yocto (Yocto already knows how to build > >>> libxl) would cause issues because of internal dependencies this would > >>> introduce. > >> > >> That would not be very different to how this works today for Zephyr. They need > >> libxl to generate the guest DT. > >> > >> That said, I agree this is a bit of a pain... > > > > Yeah.. > > > > > >>> So I think the automatic generation might be best done in another tool. > >> It sounds like what you want is creating something similar to libacpi but for > >> Device-Tree. That should work with some caveats. > > > > Yes, something like that. We have a framework for reading, editing and > > generating Device Tree: Lopper https://github.com/devicetree-org/lopper > > > > It is mostly targeted at build time but it could also be invoked on > > target at runtime. > > > > > >>> I think we need something like a script that takes a partial device tree > >>> as input and provides a more detailed partial device tree as output with > >>> the generated IDs. > >> > >> AFAICT, having the partial device-tree is not enough. You also need the real > >> DT to figure out the pMaster-ID. > >> > >>> > >>> If we did it that way, we could call the script from libxl, but also we > >>> could call it separately from ImageBuilder for dom0less and Zephyr/Yocto > >>> could also call it. > >>> > >>> Basically we make it easier for everyone to use it. The only price to > >>> pay is that it will be a bit less efficient for xl guests (one more > >>> script to fork and exec) but I think is a good compromise. > >> > >> We would need an hypercall to retrieve the host Device-Tree. But that would > >> not be too difficult to add. > > > > Good point > > > > > >>> I think this is a great idea, I only suggest that we move the automatic > >>> generation out of libxl (a separate stand-alone script), in another > >>> place that can be more easily reused by multiple projects and different > >>> use-cases. > >> > >> If we use the concept of libacpi, we may not need a to have a stand-alone > >> script. It could directly linked in libxl or any other tools. > > > > I don't feel strongly whether it should be a library, a script or > > something else. My only point is that it should be easy to use both at > > build time (e.g. Yocto/Zephyr/ImageBuilder/Lopper) and runtime > > (xl/libxl). > > > > We have already a partial DTB generator as a Lopper "lop" (a Lopper > > plugin). Probably using Lopper would be the easiest way to implement it, > > and the "lop" could be under xen.git (it doesn't have to reside under > > the lopper repository). > > > > But if we wanted a library that would be OK too. The issue with libxl is > > not much that it is a library but that it is complex to build and has > > many dependencies (it can only be built from the top level ./configure > > and make). > > > > Ideally this would be something quick that can be easily invoked as the > > first step of an external third-party build process. > > I think that we are making this problem a lot to complex and I am not sure > that all this complexity is required. > > For now, we could make the assumption that a master ID is uniq and never > reused on a system. Linux is currently making this assumption to simplify > the code. We also found no hardware with the same master ID reused. > > It would mean that the user would just need to keep the stream-id property > in the device tree, replace the link to the SMMU with a fake phandle. The > tools could then add the vIOMMU node and fix all phandle in the device tree > to properly point to it. In practice the user can simply copy the whole device > node with the stream-id properties and just replace the phandle by 0x0. > > This will make the first implementation a lot simpler and prevent adding > hyper calls or to much magic in the tools for now. > This will also give us more time to check if we need more complex use > cases and how they could be configured. > > What do you think ? I think it is a good idea. It will allow us to have something that works and learn the details of the implementation. I think we'll be able to come up with a better idea on how to solve it afterwards. --8323329-163733150-1668121282=:50442-- From xen-devel-bounces@lists.xenproject.org Thu Nov 10 23:16:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 23:16:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442258.696324 (Exim 4.92) (envelope-from ) id 1otGmI-000799-4p; Thu, 10 Nov 2022 23:16:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442258.696324; Thu, 10 Nov 2022 23:16:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otGmI-000792-1r; Thu, 10 Nov 2022 23:16:10 +0000 Received: by outflank-mailman (input) for mailman id 442258; Thu, 10 Nov 2022 23:16:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otGmF-00078s-Vw; Thu, 10 Nov 2022 23:16:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otGmF-0004dK-RC; Thu, 10 Nov 2022 23:16:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otGmF-0003bz-9B; Thu, 10 Nov 2022 23:16:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otGmF-0006NI-8g; Thu, 10 Nov 2022 23:16:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LpCEI44gNuo7aDLGzYfMSG+R9nuE2V8r1+VCuKAKlyk=; b=XPacDIbi7H/6FsmDzm1IgR4V3Z mAOA0wjSSabcY+8ejTaAxO0/QXiVolifD5qLeocy2u/EcJnUiRZELTtexdMSRhDBGuJxWwP2cEMql Afy3gk5lGEWBMgxhXLqTxbLah9z3ioHjbsxuFuEIjOBQkG9QcvqbtdeAGQK7zWy+b51o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174725: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=08c6f57cfebad4046dabc05092b4a27c61a39980 X-Osstest-Versions-That: xen=a4180b03fffafa1868b0bcacc20198d4caef2908 From: osstest service owner Date: Thu, 10 Nov 2022 23:16:07 +0000 flight 174725 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174725/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 08c6f57cfebad4046dabc05092b4a27c61a39980 baseline version: xen a4180b03fffafa1868b0bcacc20198d4caef2908 Last test of basis 174699 2022-11-09 21:00:29 Z 1 days Testing same since 174725 2022-11-10 20:00:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Luca Fancellu jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a4180b03ff..08c6f57cfe 08c6f57cfebad4046dabc05092b4a27c61a39980 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Nov 10 23:17:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Nov 2022 23:17:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442265.696335 (Exim 4.92) (envelope-from ) id 1otGnd-0007h9-GU; Thu, 10 Nov 2022 23:17:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442265.696335; Thu, 10 Nov 2022 23:17:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otGnd-0007h2-Dc; Thu, 10 Nov 2022 23:17:33 +0000 Received: by outflank-mailman (input) for mailman id 442265; Thu, 10 Nov 2022 23:17:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otGnc-0007gu-JJ for xen-devel@lists.xenproject.org; Thu, 10 Nov 2022 23:17:32 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d925ee24-614d-11ed-91b5-6bf2151ebd3b; Fri, 11 Nov 2022 00:17:31 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A72C161B97; Thu, 10 Nov 2022 23:17:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F359C433D6; Thu, 10 Nov 2022 23:17:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d925ee24-614d-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668122249; bh=gZ6l0O/lCjUNbu1K+43xFwYYz+6DXABKrxCMwJLaWZI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=V1cYjlIiJX28ACqmiEP3XhZLFMEQqGwk7naFkrWBXyLun66hDPMecANgh3aj/J5wb 7G89BwIFGlq8H3U/E7e5LJVXBYj7cXBdHAGCu0okbGDq+6xxPUbebLQBaaU4spv8Mj sH/iJXUf5aDXRjdoTIfdXw1RCe6UQPIs9qFOjIkXI9yeNFjn+9xs8ryvNCLMti1T05 bbsDDzuCdWU99iRcPG060VlQgiXVjnkpC+nKDc52nEedQnRpeg/ecQmNipoQBUR5MR Ojq3U7z8I/AfSOZqKNT8N+cBQ6gqGqlkp/egYhD4XL0qfMH+930O9YxTotk2vXRfea CyAkvDPYefQ0w== Date: Thu, 10 Nov 2022 15:17:25 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Anthony PERARD cc: xen-devel@lists.xenproject.org, Wei Liu , Stefano Stabellini , George Dunlap , Julien Grall , Jan Beulich , Henry Wang , Andrew Cooper , Bertrand Marquis , Petre Pircalabu , Alexandru Isaila , Tamas K Lengyel , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Juergen Gross , Paul Durrant , Christopher Clark Subject: Re: [XEN PATCH for-4.17 v2 0/6] Fixing some licences issue in public headers In-Reply-To: <20221103115204.49610-1-anthony.perard@citrix.com> Message-ID: References: <20221103115204.49610-1-anthony.perard@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi Anthony, Thank you for doing this, it was much needed! Hi all, I think if we are going to commit this series for 4.17 then I would suggest to also commit patches 1-3 of my "introduce SPDX" series: https://marc.info/?l=xen-devel&m=166562222522996 They are already acked/reviewed and are zero risk as they don't actually change any of the headers. For clarify, I don't mean to cause any trouble to this series. I am also happy to have this series committed in 4.17 without "introduce SPDX". Cheers, Stefano On Thu, 3 Nov 2022, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.licences-fix-public-headers-v2 > > Hi, > > Andrew pointed out some licences issue: > > https://lore.kernel.org/xen-devel/b58f5340-d4fa-df9d-89de-6137005add77@citrix.com/T/#u > tracked here: https://gitlab.com/xen-project/xen/-/issues/35 > > So I attempt to fix them with this series. > > For 4.17: > This mostly change "documentation" so little risk for those patch, except > "xen-foreign: Capture licences from the input headers" which changes > "mkheader.py" which could generate broken headers. > > Anthony PERARD (6): > xen: Add licence information to public/errno.h > xen: Used SPDX identifier in some public headers > tools/include/xen-foreign: Add SPDX identifier to generated headers > xen: Add licence header to device_tree_defs.h > Rework COPYING installed in /usr/include/xen/, due to several licences > xen: Used SPDX identifier in public headers > > tools/include/Makefile | 1 - > xen/include/public/arch-arm.h | 19 +------------- > xen/include/public/arch-arm/hvm/save.h | 19 +------------- > xen/include/public/arch-arm/smccc.h | 19 +------------- > xen/include/public/arch-x86/cpufeatureset.h | 19 +------------- > xen/include/public/arch-x86/cpuid.h | 19 +------------- > xen/include/public/arch-x86/guest-acpi.h | 19 +------------- > xen/include/public/arch-x86/hvm/save.h | 19 +------------- > xen/include/public/arch-x86/hvm/start_info.h | 19 +------------- > xen/include/public/arch-x86/pmu.h | 19 +------------- > xen/include/public/arch-x86/xen-mca.h | 19 +------------- > xen/include/public/arch-x86/xen-x86_32.h | 19 +------------- > xen/include/public/arch-x86/xen-x86_64.h | 19 +------------- > xen/include/public/arch-x86/xen.h | 19 +------------- > xen/include/public/arch-x86_32.h | 19 +------------- > xen/include/public/arch-x86_64.h | 19 +------------- > xen/include/public/argo.h | 19 +------------- > xen/include/public/callback.h | 19 +------------- > xen/include/public/device_tree_defs.h | 6 +++++ > xen/include/public/dom0_ops.h | 19 +------------- > xen/include/public/domctl.h | 19 +------------- > xen/include/public/elfnote.h | 19 +------------- > xen/include/public/errno.h | 2 ++ > xen/include/public/event_channel.h | 19 +------------- > xen/include/public/features.h | 19 +------------- > xen/include/public/grant_table.h | 19 +------------- > xen/include/public/hvm/dm_op.h | 19 +------------- > xen/include/public/hvm/e820.h | 19 +------------- > xen/include/public/hvm/hvm_info_table.h | 19 +------------- > xen/include/public/hvm/hvm_op.h | 19 +------------- > xen/include/public/hvm/hvm_vcpu.h | 19 +------------- > xen/include/public/hvm/hvm_xs_strings.h | 19 +------------- > xen/include/public/hvm/ioreq.h | 19 +------------- > xen/include/public/hvm/params.h | 19 +------------- > xen/include/public/hvm/pvdrivers.h | 19 +------------- > xen/include/public/hvm/save.h | 19 +------------- > xen/include/public/hypfs.h | 19 +------------- > xen/include/public/io/9pfs.h | 19 +------------- > xen/include/public/io/blkif.h | 19 +------------- > xen/include/public/io/cameraif.h | 19 +------------- > xen/include/public/io/console.h | 19 +------------- > xen/include/public/io/displif.h | 19 +------------- > xen/include/public/io/fbif.h | 19 +------------- > xen/include/public/io/fsif.h | 19 +------------- > xen/include/public/io/kbdif.h | 19 +------------- > xen/include/public/io/libxenvchan.h | 19 +------------- > xen/include/public/io/netif.h | 19 +------------- > xen/include/public/io/pciif.h | 19 +------------- > xen/include/public/io/protocols.h | 19 +------------- > xen/include/public/io/pvcalls.h | 19 +------------- > xen/include/public/io/ring.h | 19 +------------- > xen/include/public/io/sndif.h | 19 +------------- > xen/include/public/io/tpmif.h | 19 +------------- > xen/include/public/io/usbif.h | 19 +------------- > xen/include/public/io/vscsiif.h | 19 +------------- > xen/include/public/io/xenbus.h | 19 +------------- > xen/include/public/io/xs_wire.h | 19 +------------- > xen/include/public/kexec.h | 19 +------------- > xen/include/public/memory.h | 19 +------------- > xen/include/public/nmi.h | 19 +------------- > xen/include/public/physdev.h | 19 +------------- > xen/include/public/platform.h | 19 +------------- > xen/include/public/pmu.h | 19 +------------- > xen/include/public/sched.h | 19 +------------- > xen/include/public/sysctl.h | 19 +------------- > xen/include/public/tmem.h | 19 +------------- > xen/include/public/trace.h | 19 +------------- > xen/include/public/vcpu.h | 19 +------------- > xen/include/public/version.h | 19 +------------- > xen/include/public/vm_event.h | 19 +------------- > xen/include/public/xen-compat.h | 19 +------------- > xen/include/public/xen.h | 19 +------------- > xen/include/public/xencomm.h | 19 +------------- > xen/include/public/xenoprof.h | 19 +------------- > xen/include/public/xsm/flask_op.h | 19 +------------- > tools/include/xen-foreign/mkheader.py | 23 ++++++++++++++--- > tools/include/xen/COPYING | 26 ++++++++++++++++++++ > 77 files changed, 125 insertions(+), 1301 deletions(-) > create mode 100644 tools/include/xen/COPYING > > -- > Anthony PERARD > From xen-devel-bounces@lists.xenproject.org Fri Nov 11 00:54:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 00:54:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442273.696346 (Exim 4.92) (envelope-from ) id 1otIIu-0002fW-Th; Fri, 11 Nov 2022 00:53:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442273.696346; Fri, 11 Nov 2022 00:53:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otIIu-0002fP-PW; Fri, 11 Nov 2022 00:53:56 +0000 Received: by outflank-mailman (input) for mailman id 442273; Fri, 11 Nov 2022 00:53:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otIIt-0002fF-9I; Fri, 11 Nov 2022 00:53:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otIIt-0007S0-2e; Fri, 11 Nov 2022 00:53:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otIIs-0002kk-KW; Fri, 11 Nov 2022 00:53:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otIIs-000204-K5; Fri, 11 Nov 2022 00:53:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Hq2qN1x0QSvEK6WkKES1RQiu+rZEZQ8T71O86TOH+yQ=; b=hehCeW789P4jxLMEwc+NdgCyJw aYYGStbCFPwKJ/DGB5MP1Cxl7QqYyGb0x89Di+4o0Uhrs5yiawFjs/O7tA29SYZ5l9TKeMynU8Njd NUX4MAjf/8in6U9k7mKZwid0JBPc+mZYA1h9IYMCMllNVTscErl+qxwLhrG5dMzwVgmE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174706: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=2e16c9f20280fc051adea7544600fdc351415739 X-Osstest-Versions-That: libvirt=640e1050bf756c8ccec65cdd6e7ce544bae764db From: osstest service owner Date: Fri, 11 Nov 2022 00:53:54 +0000 flight 174706 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174706/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174685 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174685 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174685 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt 2e16c9f20280fc051adea7544600fdc351415739 baseline version: libvirt 640e1050bf756c8ccec65cdd6e7ce544bae764db Last test of basis 174685 2022-11-09 04:22:09 Z 1 days Testing same since 174706 2022-11-10 04:18:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Göran Uddeborg Michal Privoznik Peter Krempa Roman Bogorodskiy Stefan Berger jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 640e1050bf..2e16c9f202 2e16c9f20280fc051adea7544600fdc351415739 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Nov 11 01:10:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 01:10:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442283.696357 (Exim 4.92) (envelope-from ) id 1otIZG-0003l2-K6; Fri, 11 Nov 2022 01:10:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442283.696357; Fri, 11 Nov 2022 01:10:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otIZG-0003kv-Gz; Fri, 11 Nov 2022 01:10:50 +0000 Received: by outflank-mailman (input) for mailman id 442283; Fri, 11 Nov 2022 01:10:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otIZE-0003kp-Tg for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 01:10:49 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id abc88e73-615d-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 02:10:46 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8D599B81E60; Fri, 11 Nov 2022 01:10:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DF3AC433D6; Fri, 11 Nov 2022 01:10:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abc88e73-615d-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668129044; bh=YzbJGfV+GbWcoB2qHagvlM8dDZxVeC7dDd5F0rbbej4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Hfw+zo6vuuyF0fmplR03+rcaynVXm8T1F9V1WY/KktbitZwklhzMvldoMni4MolHe mv8BeihUu8LEmmuGaMSH0NV4yCzD5xjWfQ9mMlhBXr4vtTsb/m0zm18R486zVhIVEI Z8/THXr+wLl58Bi7fE7Xs4TfckKmFCN94T3uLzPeLeE46SjFqq5smtSqO3PNvvQFNL nrkadHWnbZNPB7RjsvJFZfKVuhTmoEI11ncU777hoRCUJ8feX0PZNhsP/hHs/fGkeu L1ileVvXCVqcZlbjIqWNucnDrgorzhEMRujhOu9gJhfsNuxFqbUu9lFvFg20mq71Xe WfnNW4tu8lrWA== Date: Thu, 10 Nov 2022 17:10:41 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Vipul Suneja cc: Stefano Stabellini , xen-devel@lists.xenproject.org, oleksandr_andrushchenko@epam.com, oleksandr_tyshchenko@epam.com, jgross@suse.com, boris.ostrovsky@oracle.com, Bertrand.Marquis@arm.com Subject: Re: Porting Xen in raspberry pi4B In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1863259185-1668129009=:50442" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1863259185-1668129009=:50442 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: Hi Vipul, Sorry for the late reply. From the earlier logs that you sent, it looks like everything should be working correctly. Specifically:     vfb = ""      1 = ""       0 = ""        frontend = "/local/domain/1/device/vfb/0"        frontend-id = "1"        online = "1"        state = "4"        vnc = "1"        vnclisten = "127.0.0.1"        vncdisplay = "0"        vncunused = "1"        sdl = "0"        opengl = "0"        feature-resize = "1"        hotplug-status = "connected"        request-update = "1" state "4" means "connected". So I would expect that you should be able to connect to the vnc server using vncviewer. You might not see anything (black screen) but you should definitely be able to connect. I wouldn't try to launch x11 in the guest just yet. fbcon in Linux is enough to render something on the screen. You should be able to see the Linux text-based console rendered graphically, connecting to it via vnc. Sorry for the basic question, but have you tried all the following? vncviewer 127.0.0.1:0 vncviewer 127.0.0.1:1 vncviewer 127.0.0.1:2 vncviewer 127.0.0.1:5900 vncviewer 127.0.0.1:5901 vncviewer 127.0.0.1:5902 Given that from the xenstore-ls logs everything seems to work correctly I am not sure what else to suggest. You might have to add printf to QEMU ui/vnc.c and hw/display/xenfb.c to see what is going wrong. Cheers, Stefano On Mon, 7 Nov 2022, Vipul Suneja wrote: > Hi Stefano, > Thanks! > > Any input further on "xenstore-ls" logs? > > I am trying to run the x0vncserver & x11vnc server manually on guest machine(xen_guest_image_minimal) image but it's failing with the below > error. > > root@raspberrypi4-64:/usr/bin# x0vncserver > x0vncserver: unable to open display "" > root@raspberrypi4-64:/usr/bin# > root@raspberrypi4-64:/usr/bin# x11vnc > ############################################################### > #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@# > #@                                                           @# > #@  **  WARNING  **  WARNING  **  WARNING  **  WARNING  **   @# > #@                                                           @# > #@        YOU ARE RUNNING X11VNC WITHOUT A PASSWORD!!        @# > #@                                                           @# > #@  This means anyone with network access to this computer   @# > #@  may be able to view and control your desktop.            @# > #@                                                           @# > #@ >>> If you did not mean to do this Press CTRL-C now!! <<< @# > #@                                                           @# > #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@# > #@                                                           @# > #@  You can create an x11vnc password file by running:       @# > #@                                                           @# > #@       x11vnc -storepasswd password /path/to/passfile      @# > #@  or   x11vnc -storepasswd /path/to/passfile               @# > #@  or   x11vnc -storepasswd                                 @# > #@                                                           @# > #@  (the last one will use ~/.vnc/passwd)                    @# > #@                                                           @# > #@  and then starting x11vnc via:                            @# > #@                                                           @# > #@      x11vnc -rfbauth /path/to/passfile                    @# > #@                                                           @# > #@  an existing ~/.vnc/passwd file from another VNC          @# > #@  application will work fine too.                          @# > #@                                                           @# > #@  You can also use the -passwdfile or -passwd options.     @# > #@  (note -passwd is unsafe if local users are not trusted)  @# > #@                                                           @# > #@  Make sure any -rfbauth and -passwdfile password files    @# > #@  cannot be read by untrusted users.                       @# > #@                                                           @# > #@  Use x11vnc -usepw to automatically use your              @# > #@  ~/.vnc/passwd or ~/.vnc/passwdfile password files.       @# > #@  (and prompt you to create ~/.vnc/passwd if neither       @# > #@  file exists.)  Under -usepw, x11vnc will exit if it      @# > #@  cannot find a password to use.                           @# > #@                                                           @# > #@                                                           @# > #@  Even with a password, the subsequent VNC traffic is      @# > #@  sent in the clear.  Consider tunnelling via ssh(1):      @# > #@                                                           @# > #@    http://www.karlrunge.com/x11vnc/#tunnelling            @# > #@                                                           @# > #@  Or using the x11vnc SSL options: -ssl and -stunnel       @# > #@                                                           @# > #@  Please Read the documentation for more info about        @# > #@  passwords, security, and encryption.                     @# > #@                                                           @# > #@    http://www.karlrunge.com/x11vnc/faq.html#faq-passwd    @# > #@                                                           @# > #@  To disable this warning use the -nopw option, or put     @# > #@  'nopw' on a line in your ~/.x11vncrc file.               @# > #@                                                           @# > #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@# > ############################################################### > 09/03/2018 12:58:41 x11vnc version: 0.9.16 lastmod: 2019-01-05  pid: 424 > 09/03/2018 12:58:41 XOpenDisplay("") failed. > 09/03/2018 12:58:41 Trying again with XAUTHLOCALHOSTNAME=localhost ... > 09/03/2018 12:58:41 > 09/03/2018 12:58:41 *** XOpenDisplay failed. No -display or DISPLAY. > 09/03/2018 12:58:41 *** Trying ":0" in 4 seconds.  Press Ctrl-C to abort. > 09/03/2018 12:58:41 *** 1 2 3 4 > 09/03/2018 12:58:45 XOpenDisplay(":0") failed. > 09/03/2018 12:58:45 Trying again with XAUTHLOCALHOSTNAME=localhost ... > 09/03/2018 12:58:45 XOpenDisplay(":0") failed. > 09/03/2018 12:58:45 Trying again with unset XAUTHLOCALHOSTNAME ... > 09/03/2018 12:58:45 > > 09/03/2018 12:58:45 *************************************** > 09/03/2018 12:58:45 *** XOpenDisplay failed (:0) > > *** x11vnc was unable to open the X DISPLAY: ":0", it cannot continue. > *** There may be "Xlib:" error messages above with details about the failure. > > Some tips and guidelines: > > ** An X server (the one you wish to view) must be running before x11vnc is >    started: x11vnc does not start the X server.  (however, see the -create >    option if that is what you really want). > > ** You must use -display , -OR- set and export your $DISPLAY >    environment variable to refer to the display of the desired X server. >  - Usually the display is simply ":0" (in fact x11vnc uses this if you forget >    to specify it), but in some multi-user situations it could be ":1", ":2", >    or even ":137".  Ask your administrator or a guru if you are having >    difficulty determining what your X DISPLAY is. > > ** Next, you need to have sufficient permissions (Xauthority) >    to connect to the X DISPLAY.   Here are some Tips: > >  - Often, you just need to run x11vnc as the user logged into the X session. >    So make sure to be that user when you type x11vnc. >  - Being root is usually not enough because the incorrect MIT-MAGIC-COOKIE >    file may be accessed.  The cookie file contains the secret key that >    allows x11vnc to connect to the desired X DISPLAY. >  - You can explicitly indicate which MIT-MAGIC-COOKIE file should be used >    by the -auth option, e.g.: >        x11vnc -auth /home/someuser/.Xauthority -display :0 >        x11vnc -auth /tmp/.gdmzndVlR -display :0 >    you must have read permission for the auth file. >    See also '-auth guess' and '-findauth' discussed below. > > ** If NO ONE is logged into an X session yet, but there is a greeter login >    program like "gdm", "kdm", "xdm", or "dtlogin" running, you will need >    to find and use the raw display manager MIT-MAGIC-COOKIE file. >    Some examples for various display managers: > >      gdm:     -auth /var/gdm/:0.Xauth >               -auth /var/lib/gdm/:0.Xauth >      kdm:     -auth /var/lib/kdm/A:0-crWk72 >               -auth /var/run/xauth/A:0-crWk72 >      xdm:     -auth /var/lib/xdm/authdir/authfiles/A:0-XQvaJk >      dtlogin: -auth /var/dt/A:0-UgaaXa > >    Sometimes the command "ps wwwwaux | grep auth" can reveal the file location. > >    Starting with x11vnc 0.9.9 you can have it try to guess by using: > >               -auth guess > >    (see also the x11vnc -findauth option.) > >    Only root will have read permission for the file, and so x11vnc must be run >    as root (or copy it).  The random characters in the filenames will of course >    change and the directory the cookie file resides in is system dependent. > > See also: http://www.karlrunge.com/x11vnc/faq.html > > Regards, > Vipul Kumar > > On Thu, Nov 3, 2022 at 10:27 PM Vipul Suneja wrote: > Hi Stefano, > Thanks! > > I used xen-guest-image-minimal(simple console based image) as a guest with fbcon & fbdev enabled in kernel configurations but still > the same error can't open the display. > below are the outcome of "xenstore-ls": > > root@raspberrypi4-64:~/guest1# xenstore-ls > tool = "" >  xenstored = "" > local = "" >  domain = "" >   0 = "" >    control = "" >     feature-poweroff = "1" >     feature-reboot = "1" >    domid = "0" >    name = "Domain-0" >    device-model = "" >     0 = "" >      backends = "" >       console = "" >       vkbd = "" >       vfb = "" >       qnic = "" >      state = "running" >     1 = "" >      backends = "" >       console = "" >       vkbd = "" >       vfb = "" >       qnic = "" >      state = "running" >    backend = "" >     vbd = "" >      1 = "" >       51712 = "" >        frontend = "/local/domain/1/device/vbd/51712" >        params = "/home/root/guest2/xen-guest-image-minimal-raspberrypi4-64.ext3" >        script = "/etc/xen/scripts/block" >        frontend-id = "1" >        online = "1" >        removable = "0" >        bootable = "1" >        state = "4" >        dev = "xvda" >        type = "phy" >        mode = "w" >        device-type = "disk" >        discard-enable = "1" >        feature-max-indirect-segments = "256" >        multi-queue-max-queues = "4" >        max-ring-page-order = "4" >        node = "/dev/loop0" >        physical-device = "7:0" >        physical-device-path = "/dev/loop0" >        hotplug-status = "connected" >        feature-flush-cache = "1" >        discard-granularity = "4096" >        discard-alignment = "0" >        discard-secure = "0" >        feature-discard = "1" >        feature-barrier = "1" >        feature-persistent = "1" >        sectors = "1794048" >        info = "0" >        sector-size = "512" >        physical-sector-size = "512" >     vfb = "" >      1 = "" >       0 = "" >        frontend = "/local/domain/1/device/vfb/0" >        frontend-id = "1" >        online = "1" >        state = "4" >        vnc = "1" >        vnclisten = "127.0.0.1" >        vncdisplay = "0" >        vncunused = "1" >        sdl = "0" >        opengl = "0" >        feature-resize = "1" >        hotplug-status = "connected" >        request-update = "1" >     vkbd = "" >      1 = "" >       0 = "" >        frontend = "/local/domain/1/device/vkbd/0" >        frontend-id = "1" >        online = "1" >        state = "4" >        feature-abs-pointer = "1" >        feature-raw-pointer = "1" >        hotplug-status = "connected" >     console = "" >      1 = "" >       0 = "" >        frontend = "/local/domain/1/console" >        frontend-id = "1" >        online = "1" >        state = "1" >        protocol = "vt100" >     vif = "" >      1 = "" >       0 = "" >        frontend = "/local/domain/1/device/vif/0" >        frontend-id = "1" >        online = "1" >        state = "4" >        script = "/etc/xen/scripts/vif-bridge" >        mac = "e4:5f:01:cd:7b:dd" >        bridge = "xenbr0" >        handle = "0" >        type = "vif" >        hotplug-status = "connected" >        feature-sg = "1" >        feature-gso-tcpv4 = "1" >        feature-gso-tcpv6 = "1" >        feature-ipv6-csum-offload = "1" >        feature-rx-copy = "1" >        feature-xdp-headroom = "1" >        feature-rx-flip = "0" >        feature-multicast-control = "1" >        feature-dynamic-multicast-control = "1" >        feature-split-event-channels = "1" >        multi-queue-max-queues = "4" >        feature-ctrl-ring = "1" >   1 = "" >    vm = "/vm/d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f" >    name = "guest2" >    cpu = "" >     0 = "" >      availability = "online" >     1 = "" >      availability = "online" >    memory = "" >     static-max = "2097152" >     target = "2097152" >     videoram = "0" >    device = "" >     suspend = "" >      event-channel = "" >     vbd = "" >      51712 = "" >       backend = "/local/domain/0/backend/vbd/1/51712" >       backend-id = "0" >       state = "4" >       virtual-device = "51712" >       device-type = "disk" >       multi-queue-num-queues = "2" >       queue-0 = "" >        ring-ref = "8" >        event-channel = "4" >       queue-1 = "" >        ring-ref = "9" >        event-channel = "5" >       protocol = "arm-abi" >       feature-persistent = "1" >     vfb = "" >      0 = "" >       backend = "/local/domain/0/backend/vfb/1/0" >       backend-id = "0" >       state = "4" >       page-ref = "275022" >       event-channel = "3" >       protocol = "arm-abi" >       feature-update = "1" >     vkbd = "" >      0 = "" >       backend = "/local/domain/0/backend/vkbd/1/0" >       backend-id = "0" >       state = "4" >       request-abs-pointer = "1" >       page-ref = "275322" >       page-gref = "1284" >       event-channel = "10" >     vif = "" >      0 = "" >       backend = "/local/domain/0/backend/vif/1/0" >       backend-id = "0" >       state = "4" >       handle = "0" >       mac = "e4:5f:01:cd:7b:dd" >       mtu = "1500" >       xdp-headroom = "0" >       multi-queue-num-queues = "2" >       queue-0 = "" >        tx-ring-ref = "1280" >        rx-ring-ref = "1281" >        event-channel-tx = "6" >        event-channel-rx = "7" >       queue-1 = "" >        tx-ring-ref = "1282" >        rx-ring-ref = "1283" >        event-channel-tx = "8" >        event-channel-rx = "9" >       request-rx-copy = "1" >       feature-rx-notify = "1" >       feature-sg = "1" >       feature-gso-tcpv4 = "1" >       feature-gso-tcpv6 = "1" >       feature-ipv6-csum-offload = "1" >    control = "" >     shutdown = "" >     feature-poweroff = "1" >     feature-reboot = "1" >     feature-suspend = "" >     sysrq = "" >     platform-feature-multiprocessor-suspend = "1" >     platform-feature-xs_reset_watches = "1" >    data = "" >    drivers = "" >    feature = "" >    attr = "" >    error = "" >    domid = "1" >    store = "" >     port = "1" >     ring-ref = "233473" >    console = "" >     backend = "/local/domain/0/backend/console/1/0" >     backend-id = "0" >     limit = "1048576" >     type = "xenconsoled" >     output = "pty" >     tty = "/dev/pts/1" >     port = "2" >     ring-ref = "233472" >     vnc-listen = "127.0.0.1" >     vnc-port = "5900" >    image = "" >     device-model-pid = "788" > vm = "" >  d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f = "" >   name = "guest2" >   uuid = "d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f" >   start_time = "1520600274.27" > libxl = "" >  1 = "" >   device = "" >    vbd = "" >     51712 = "" >      frontend = "/local/domain/1/device/vbd/51712" >      backend = "/local/domain/0/backend/vbd/1/51712" >      params = "/home/root/guest2/xen-guest-image-minimal-raspberrypi4-64.ext3" >      script = "/etc/xen/scripts/block" >      frontend-id = "1" >      online = "1" >      removable = "0" >      bootable = "1" >      state = "1" >      dev = "xvda" >      type = "phy" >      mode = "w" >      device-type = "disk" >      discard-enable = "1" >    vfb = "" >     0 = "" >      frontend = "/local/domain/1/device/vfb/0" >      backend = "/local/domain/0/backend/vfb/1/0" >      frontend-id = "1" >      online = "1" >      state = "1" >      vnc = "1" >      vnclisten = "127.0.0.1" >      vncdisplay = "0" >      vncunused = "1" >      sdl = "0" >      opengl = "0" >    vkbd = "" >     0 = "" >      frontend = "/local/domain/1/device/vkbd/0" >      backend = "/local/domain/0/backend/vkbd/1/0" >      frontend-id = "1" >      online = "1" >      state = "1" >    console = "" >     0 = "" >      frontend = "/local/domain/1/console" >      backend = "/local/domain/0/backend/console/1/0" >      frontend-id = "1" >      online = "1" >      state = "1" >      protocol = "vt100" >    vif = "" >     0 = "" >      frontend = "/local/domain/1/device/vif/0" >      backend = "/local/domain/0/backend/vif/1/0" >      frontend-id = "1" >      online = "1" >      state = "1" >      script = "/etc/xen/scripts/vif-bridge" >      mac = "e4:5f:01:cd:7b:dd" >      bridge = "xenbr0" >      handle = "0" >      type = "vif" >      hotplug-status = "" >   type = "pvh" >   dm-version = "qemu_xen" > root@raspberrypi4-64:~/guest1# > > Any input as per above? Looking forward to hearing from you. > > Regards, > Vipul Kumar > > On Wed, Oct 26, 2022 at 5:21 AM Stefano Stabellini wrote: > Hi Vipul, > > If you look at the QEMU logs, it says: > > VNC server running on 127.0.0.1:5900 > > That is the VNC server you need to connect to. So in theory: > >   vncviewer 127.0.0.1:5900 > > should work correctly. > > > If you have: > >   vfb = ["type=vnc"] > > in your xl config file and you have "fbdev" in your Linux guest, it > should work. > > If you connect to the VNC server but you get a black screen, it might be > a guest configuration issue. I would try with a simpler guest, text only > (no X11, no Wayland) and enable the fbdev console (fbcon). See > Documentation/fb/fbcon.rst in Linux. You should be able to see a > graphical console over VNC. > > If that works, then you know that the fbdev kernel driver (xen-fbfront) > works correctly. > > If it doesn't work, the output of "xenstore-ls" would be interesting. > > Cheers, > > Stefano > > > On Wed, 19 Oct 2022, Vipul Suneja wrote: > > Hi Stefano, > > > > Thanks for the response! > > > > I am following the same link you shared from the beginning. Tried the command "vncviewer localhost:0" in DOM0 but same > issue "Can't open > > display", below are the logs: > > > > root@raspberrypi4-64:~# vncviewer localhost:0 > > > > TigerVNC Viewer 64-bit v1.11.0 > > Built on: 2020-09-08 12:16 > > Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst) > > See https://www.tigervnc.org for information on TigerVNC. > > Can't open display: > > > > Below are the netstat logs, i couldn't see anything running at port 5900 or 5901: > > > > root@raspberrypi4-64:~# netstat -tuwx > > Active Internet connections (w/o servers) > > Proto Recv-Q Send-Q Local Address           Foreign Address         State       > > tcp        0    164 192.168.1.39:ssh        192.168.1.38:37472      ESTABLISHED > > Active UNIX domain sockets (w/o servers) > > Proto RefCnt Flags       Type       State         I-Node Path > > unix  8      [ ]         DGRAM      CONNECTED      10565 /dev/log > > unix  3      [ ]         STREAM     CONNECTED      10891 /var/run/xenstored/socket > > unix  3      [ ]         STREAM     CONNECTED      13791 > > unix  3      [ ]         STREAM     CONNECTED      10843 /var/run/xenstored/socket > > unix  3      [ ]         STREAM     CONNECTED      10573 /var/run/xenstored/socket > > unix  2      [ ]         DGRAM      CONNECTED      14510 > > unix  3      [ ]         STREAM     CONNECTED      13249 > > unix  2      [ ]         DGRAM      CONNECTED      13887 > > unix  2      [ ]         DGRAM      CONNECTED      10599 > > unix  3      [ ]         STREAM     CONNECTED      14005 > > unix  3      [ ]         STREAM     CONNECTED      13258 > > unix  3      [ ]         STREAM     CONNECTED      13248 > > unix  3      [ ]         STREAM     CONNECTED      14003 > > unix  3      [ ]         STREAM     CONNECTED      10572 /var/run/xenstored/socket > > unix  3      [ ]         STREAM     CONNECTED      10786 /var/run/xenstored/socket > > unix  3      [ ]         DGRAM      CONNECTED      13186 > > unix  3      [ ]         STREAM     CONNECTED      10864 /var/run/xenstored/socket > > unix  3      [ ]         STREAM     CONNECTED      10812 /var/run/xenstored/socket > > unix  2      [ ]         DGRAM      CONNECTED      14083 > > unix  3      [ ]         STREAM     CONNECTED      10813 /var/run/xenstored/socket > > unix  3      [ ]         STREAM     CONNECTED      14068 > > unix  3      [ ]         STREAM     CONNECTED      13256 > > unix  3      [ ]         STREAM     CONNECTED      10571 /var/run/xenstored/socket > > unix  3      [ ]         STREAM     CONNECTED      10842 > > unix  3      [ ]         STREAM     CONNECTED      13985 > > unix  3      [ ]         DGRAM      CONNECTED      13185 > > unix  2      [ ]         STREAM     CONNECTED      13884 > > unix  2      [ ]         DGRAM      CONNECTED      14528 > > unix  2      [ ]         DGRAM      CONNECTED      13785 > > unix  3      [ ]         STREAM     CONNECTED      14034 > > > > Attaching xen log files of /var/log/xen. > > I didn't get the role of QEMU here because as mentioned earlier, I am porting in raspberrypi 4B. > > > > Regards, > > Vipul Kumar > > > > On Wed, Oct 19, 2022 at 12:43 AM Stefano Stabellini wrote: > >       It usually works the way it is described in the guide: > > > >      >  https://www.virtuatopia.com/index.php?title=Configuring_a_VNC_based_Graphical_Console_for_a_Xen_Paravirtualized_domainU_Guest > > > >       You don't need to install any VNC-related server software because it is > >       already provided by Xen (to be precise it is provided by QEMU working > >       together with Xen.) > > > >       You only need the vnc client in dom0 so that you can connect, but you > >       could also run the vnc client outside from another host. So basically > >       the following should work when executed in Dom0 after creating DomU: > > > >         vncviewer localhost:0 > > > >       Can you attach the Xen and QEMU logs (/var/log/xen/*)? And also use > >       netstat -taunp to check if there is anything running at port 5900 or > >       5901? > > > >       Cheers, > > > >       Stefano > > > > > >       On Tue, 18 Oct 2022, Vipul Suneja wrote: > >       > Hi Stefano, > >       > > >       > Thanks for the response! > >       > > >       > I could install tigerVNC, x11vnc & libvncserver in Dom0 xen-image-minimal but only manage to install > libvncserver(couldn't > >       install tigervnc > >       > & x11vnc because of x11 > >       > support missing, it's wayland) in DOMU custom graphical image. I tried running vncviewer with IP address & port > in dom0 to > >       access the domu > >       > graphical image display as per below commands. > >       >   > >       >  vncviewer 192.168.1.42:5901 > >       >   > >       >  But it showing can't open display, below are the logs: > >       >   > >       > root@raspberrypi4-64:~/guest1# vncviewer 192.168.1.42:5901 > >       > > >       > TigerVNC Viewer 64-bit v1.11.0 > >       > Built on: 2020-09-08 12:16 > >       > Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst) > >       > See https://www.tigervnc.org for information on TigerVNC. > >       > Can't open display: > >       > root@raspberrypi4-64:~/guest1# > >       > > >       > I am not exactly sure what the issue is but I thought only libvncserver in DOMU could work to get access but it > did not > >       work.  > >       > If TigerVNC is the issue here then is there any other VNC source which could be installed for both x11 & > wayland supported > >       images? > >       > > >       > Regards, > >       > Vipul Kumar > >       > > >       > On Tue, Oct 18, 2022 at 2:40 AM Stefano Stabellini wrote: > >       >       VNC is typically easier to setup, because SDL needs extra libraries at > >       >       build time and runtime. If QEMU is built without SDL support it won't > >       >       start when you ask for SDL. > >       > > >       >       VNC should work with both x11 and wayland in your domU. It doesn't work > >       >       at the x11 level, it exposes a special fbdev device in your domU that > >       >       should work with: > >       >       - a graphical console in Linux domU > >       >       - x11 > >       >       - wayland (but I haven't tested this so I am not 100% sure about it) > >       > > >       >       When you say "it doesn't work", what do you mean? Do you get a black > >       >       window? > >       > > >       >       You need CONFIG_XEN_FBDEV_FRONTEND in Linux domU > >       >       (drivers/video/fbdev/xen-fbfront.c). I would try to get a graphical text > >       >       console up and running in your domU before attempting x11/wayland. > >       > > >       >       Cheers, > >       > > >       >       Stefano > >       > > >       >       On Mon, 17 Oct 2022, Vipul Suneja wrote: > >       >       > Hi, > >       >       > Thanks! > >       >       > > >       >       > I have ported xen minimal image as DOM0 & custom wayland GUI based image as DOMU in raspberry pi4B. I > am trying to > >       make GUI > >       >       display up > >       >       > for guest machine. I tried using sdl, included below line in guest.conf file > >       >       > vfb= [ 'sdl=1' ] > >       >       > > >       >       > But it is throwing below error: > >       >       > > >       >       > root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg > >       >       > Parsing config from guest1.cfg > >       >       > libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain 3:error on QMP socket: Connection reset by > peer > >       >       > libxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the QMP connection to > QEMU > >       >       > libxl: error: libxl_dm.c:3351:device_model_postconfig_done: Domain 3:Post DM startup configs failed, > rc=-26 > >       >       > libxl: error: libxl_create.c:1867:domcreate_devmodel_started: Domain 3:device model did not start: -26 > >       >       > libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device Model already exited > >       >       > libxl: error: libxl_domain.c:1183:libxl__destroy_domid: Domain 3:Non-existant domain > >       >       > libxl: error: libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to destroy guest > >       >       > libxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain 3:Destruction of domain failed > >       >       > > >       >       > Another way is VNC, i could install tigervnc in DOM0 but same i couldn't in guest machine because it > doesn't support > >       >       x11(supports wayland > >       >       > only). I am completely blocked here, Need your support to enable the display up. > >       >       > Any alternative of VNC which could work in both x11 & wayland supported images? > >       >       > > >       >       > Any input on VNC, SDL or any other way to proceed on this? Looking forward to hearing from you. > >       >       > > >       >       > Regards, > >       >       > Vipul Kumar > >       > > >       > > >       > > > > > > > > > > --8323329-1863259185-1668129009=:50442-- From xen-devel-bounces@lists.xenproject.org Fri Nov 11 02:22:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 02:22:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442291.696368 (Exim 4.92) (envelope-from ) id 1otJgV-0003x2-Uu; Fri, 11 Nov 2022 02:22:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442291.696368; Fri, 11 Nov 2022 02:22:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otJgV-0003wv-RA; Fri, 11 Nov 2022 02:22:23 +0000 Received: by outflank-mailman (input) for mailman id 442291; Fri, 11 Nov 2022 02:22:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otJgU-0003wl-5p; Fri, 11 Nov 2022 02:22:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otJgU-0008Kd-13; Fri, 11 Nov 2022 02:22:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otJgT-0008Bn-A5; Fri, 11 Nov 2022 02:22:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otJgT-00081K-7x; Fri, 11 Nov 2022 02:22:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=K1t1+zysPL96sjGnYr51+8snqvwv9ofNX88N1VQWi5A=; b=0yttSIquISYI1xFkuGWQE+WSo7 yW4oMKHDWgy7+3FEI/ox6f+R3bkSvedjWx+K8altGnmOBCdolyE7y9YQYig35iCXFKBkydiWnTy7E qgMmyJc54yzOtcKOi3bJ7G6VLU8Ul61+jTgR7RgA79HYCE6hjVRjesh0wX8ZVJV18l8s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174708: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=2ccad61746ca7de5dd3e25146062264387e43bd4 X-Osstest-Versions-That: qemuu=60ab36907ded2918d33683f2b66f603b7400d8f3 From: osstest service owner Date: Fri, 11 Nov 2022 02:22:21 +0000 flight 174708 qemu-mainline real [real] flight 174728 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174708/ http://logs.test-lab.xenproject.org/osstest/logs/174728/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-pair 11 xen-install/dst_host fail pass in 174728-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174687 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174687 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174687 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174687 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 174687 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174687 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174687 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174687 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174687 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 2ccad61746ca7de5dd3e25146062264387e43bd4 baseline version: qemuu 60ab36907ded2918d33683f2b66f603b7400d8f3 Last test of basis 174687 2022-11-09 07:49:56 Z 1 days Testing same since 174708 2022-11-10 07:14:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Richard Henderson Stefan Hajnoczi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 60ab36907d..2ccad61746 2ccad61746ca7de5dd3e25146062264387e43bd4 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Nov 11 03:45:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 03:45:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442299.696379 (Exim 4.92) (envelope-from ) id 1otKyd-00054L-Qx; Fri, 11 Nov 2022 03:45:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442299.696379; Fri, 11 Nov 2022 03:45:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otKyd-00054E-Ny; Fri, 11 Nov 2022 03:45:11 +0000 Received: by outflank-mailman (input) for mailman id 442299; Fri, 11 Nov 2022 03:45:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otKyb-000532-QB; Fri, 11 Nov 2022 03:45:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otKyb-0001gg-OQ; Fri, 11 Nov 2022 03:45:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otKyb-00043E-Dt; Fri, 11 Nov 2022 03:45:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otKyb-0007oi-DS; Fri, 11 Nov 2022 03:45:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1KtlFoO0P4sWU94I8nirUvhZYHb/0O6rq6hN8iVqUME=; b=fS5NBirPRYrQGZH1smDJvTOinj WR+uJ7tprWM2GmMY32MbBJ3cNgOZrGOLALCvsT2x2yZxYCs9EFB8omG/YE/w8Ckrq+WuKW1t/vDkx xgu9Y3BCqxVU5uYYG1vMPvZ1o7PNG+NX4z8zyQtO7TbzJoJzOCxMYIo7z4/bmkUuQzkA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174729: all pass - PUSHED X-Osstest-Versions-This: ovmf=342813a3f7794bf67405a236053f27c916804d36 X-Osstest-Versions-That: ovmf=b0fd3097193d9c6825979e57e78e6278163bfd8e From: osstest service owner Date: Fri, 11 Nov 2022 03:45:09 +0000 flight 174729 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174729/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 342813a3f7794bf67405a236053f27c916804d36 baseline version: ovmf b0fd3097193d9c6825979e57e78e6278163bfd8e Last test of basis 174692 2022-11-09 15:13:33 Z 1 days Testing same since 174729 2022-11-11 01:10:36 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael D Kinney jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b0fd309719..342813a3f7 342813a3f7794bf67405a236053f27c916804d36 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Nov 11 04:31:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 04:31:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442307.696390 (Exim 4.92) (envelope-from ) id 1otLhX-0002Vz-8E; Fri, 11 Nov 2022 04:31:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442307.696390; Fri, 11 Nov 2022 04:31:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otLhX-0002Vs-5G; Fri, 11 Nov 2022 04:31:35 +0000 Received: by outflank-mailman (input) for mailman id 442307; Fri, 11 Nov 2022 04:31:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otLhU-0002Vm-Uy for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 04:31:33 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2053.outbound.protection.outlook.com [40.107.105.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b68d6ff9-6179-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 05:31:31 +0100 (CET) Received: from DB8PR03CA0035.eurprd03.prod.outlook.com (2603:10a6:10:be::48) by DU2PR08MB9964.eurprd08.prod.outlook.com (2603:10a6:10:499::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 04:31:26 +0000 Received: from DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:be:cafe::d) by DB8PR03CA0035.outlook.office365.com (2603:10a6:10:be::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 11 Nov 2022 04:31:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT050.mail.protection.outlook.com (100.127.142.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 04:31:26 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Fri, 11 Nov 2022 04:31:25 +0000 Received: from aff93b07dbb3.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7BC1FD9C-E779-45B3-A18F-A219FE485371.1; Fri, 11 Nov 2022 04:31:15 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id aff93b07dbb3.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 04:31:15 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11) by PA4PR08MB7667.eurprd08.prod.outlook.com (2603:10a6:102:264::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Fri, 11 Nov 2022 04:31:13 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f]) by AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f%3]) with mapi id 15.20.5813.012; Fri, 11 Nov 2022 04:31:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b68d6ff9-6179-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=b0hNZuwOyXL3aNpKYGT3qfLgnRpQMi7Wil+skqhxU/LDUTccjj4qS4ZIaNXndEOGNSQuG1Inrt+pjWWUrNYJfvBOhVL8MYX7lqnk2QCIL3mUVFT+CK6YWdQ6cHW7+fy4f5e7t5qZCBF2imPo+xGKHwNSLzgdDArS435PBDCrUqme/RUjHLyupCxls8xZE2SLAeciwrFQUEOmXB35EHV6WiovWuweXDwTGvLBcHleeb9axw7+DxKmcK6SuJudS+IH1/F9wxkcyCFuj21h4r+vL9oCZ8w987K1kxx/mTFu0RxKtouBXnmLLv1p1iJL5piz49Ciko7M89Q+5jLeYPuTXw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yq3sN+1jEDS2xker+jK8CP5AAX7J6XYXi5NGFWGOaPk=; b=Fmg/Y1ctblKGP3KKFOi3JD/DKhWxRk+atqKR4mt8YeWz2JJQ9lm2OhPmew0F6xy9yT6S/3NkyI/By43XOn0sszHNyIeDwTBTUGnRuIR3+a/t38JczE4UzaZ8lA1BuIdSLHCwiDfWQHKJsV0o8XweM5bWV8iGolaK/T2o6beDTHYhW4XHUKv+lxwRboWPZO5Rc7BEjWZl/BZ/HJzv1ypyAK/hrgkWYCa9UUstNfn0OBzP4uUtWUyeuudglISI44OKMPHTyX7gFJ3NyFAI3vicNAOg8rzbJ3FlcY5S2xFaqEaslaw8O1zLOvb2PemNBgzwRc6Zc0yXPCfeaRez3acdLw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yq3sN+1jEDS2xker+jK8CP5AAX7J6XYXi5NGFWGOaPk=; b=Kof4cYuM+Ppv2h5O0qp05pPu23dNZaQfMSEZ35XTYIp93jA/obcbGPM+upuSCDJNwLRaoiM7wBc4BEbjOnNxvNIQLCNbRAjGi3/5jFu+DGasu5s3/WzU5o6O/HE7eKCMLcULTiXOYpfar+grYcmB6lerSecywW9gubdC9bNqE7c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AAlD8NYdAXrigkJy4MrEZ7Kl6Q8Hq+zgZQlux5hy/CnZQ4TQlA0SAyjP1dXoMAeu7lRj27XWbtmKY99o1jKVIPwKdQ2iM82SbfGQfsyQiuAQ5itmhdoRqCmzjH/dEUhHb1AmHASfz5QjbnYPpCDA+SCA6EIg9Fr0SkX2ORN8+crozzfhRh8vswXnJSJD5VNwKTKB5+V5B0JTZkaf+LEoBBz1Z/4+Dp2tUhdxI7omJhtnoKFHaJnHLpMtAA0ZPrLFe0MdwtnqrwOSthL3aaTa68QCXTqYcWrCsSc1Px7P+zFOIADz8zaApNP6Q05d7oMZZcSfjPpxO9Ord50uVThKHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yq3sN+1jEDS2xker+jK8CP5AAX7J6XYXi5NGFWGOaPk=; b=REmLpxetysRhvPkG0FV+BuWADumGTVxPD7kn+XJDIRAQNcgOsaoVPIRSUHKVqZ3qk/KU4pZ7SxtLTDjOSESWwGgc2c6MnnUhz+WfKKZBri64MnuCQYlkPyYOVgKuMXRG6FRdx1kp6oYfly0TAEjUBUMn9BPg1BOFXm5PA/tXX8r+50GD0a27hys76IlrITuaX7cbpCp1I3OXv8KqFjUdgnOXEo36+ZK9/9I1f82Zk4CIq8XQa/BhcHhGowEqNILVkAzHeAFuMmDDOIwnxF6NHEHGVwfB25cXDSqFKXshoug1YxZYmFSQnPKVmw6QLl5nSB1uNM3a8XCK5XJUwAhs6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yq3sN+1jEDS2xker+jK8CP5AAX7J6XYXi5NGFWGOaPk=; b=Kof4cYuM+Ppv2h5O0qp05pPu23dNZaQfMSEZ35XTYIp93jA/obcbGPM+upuSCDJNwLRaoiM7wBc4BEbjOnNxvNIQLCNbRAjGi3/5jFu+DGasu5s3/WzU5o6O/HE7eKCMLcULTiXOYpfar+grYcmB6lerSecywW9gubdC9bNqE7c= From: Jiamei Xie To: Stefano Stabellini , Michal Orzel CC: "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , "julien@xen.org" Subject: RE: Xen Arm vpl011 UART will cause segmentation fault in Linux guest Thread-Topic: Xen Arm vpl011 UART will cause segmentation fault in Linux guest Thread-Index: Adj0C3U97KqJOGXWTaWwFEv08mPlLwAAvb+AAAFgduAAAlWjgABJlSiAABB0itA= Date: Fri, 11 Nov 2022 04:31:12 +0000 Message-ID: References: <00764fe2-f78a-e5db-cb16-903ad1a5ec03@amd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: FD6E4A1A982D8D4B92319F9467166F27.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7696:EE_|PA4PR08MB7667:EE_|DBAEUR03FT050:EE_|DU2PR08MB9964:EE_ X-MS-Office365-Filtering-Correlation-Id: 8005b0c6-cee6-430e-afef-08dac39d9872 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GcZTs4Zjpdv8wNMGVEzuVqUTQkxTs+YV8rosj8sLHf109AxZaKf4DWhv27s+RXkhGQMG6ZI8wekIIl+ExQ2CPzfDawozOuqrpN3XPgrIH+rq0af1nBL8P+dvnBWHYI/ZgeW/Fe1RYA43f+wsJRY/lcK1bPu1Zsnli0fdoJMVLGceWSxA7uA2t91WowRiND0EkN7Fsgc/qg1Jfd/3VuHdMhT9ZGXNMJj/iBXJfVyD68DCP6VIZifCv66xC9bO4ttHRVSHFzwckMrnxUPFgre0XVIp+WlfkgF+sLFy8quP6cI39O9/l72LqRzwd7t74o6v+TENtTcZRhyGYHs7yaURNIafJhuTnBSayNgM4CNL3Zp+5ptC1Tu499Ju3QHqYc6XTqBYT4ne9jBeqU36Maf6XREyB+H2QyoHr2ZyMxpr+JLwh2+u1URRJhYwV6/bsK9dUk4bQk6V6YfTCg39IBs/6dPoIkd8WtL3AAKFwLBB1xnIRCgrtPXAXodIi0zw/pEqZXD36QXsg5X14UKYDN8S+RX8ymSARYG9friHVJ5ITvutxT0h0W8HpsNH3hSvpA2+2Mngi9whc+VmYZftL+f7BVwao+PU6m71lxdJ9pUva9SZWVWyyPWcydlY5hdFrZXSBEmZBhq0XY7QFInp1+ONpwJTC8qQkkDPPETo0+y0z3xT+hJ9s4gEFwIk9ZkoGZL1bqntDCWC+cWnY7UKWLcHIP+e0cXVsSBO3waD9j6EgxsMqiGnfwz3askXNLENrVC7pC22fIsjn15mfbdxiO1Heg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(136003)(396003)(366004)(451199015)(52536014)(186003)(66899015)(38100700002)(316002)(55016003)(54906003)(45080400002)(110136005)(122000001)(86362001)(38070700005)(33656002)(7696005)(8936002)(83380400001)(2906002)(6506007)(26005)(53546011)(9686003)(41300700001)(478600001)(8676002)(64756008)(5660300002)(71200400001)(76116006)(66946007)(66446008)(66476007)(4326008)(66556008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7667 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a1923b02-8dc6-4cde-84dd-08dac39d907c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YpFgCSijMgZtXZpn2jZX6NTJzlXnm0JVmL2KKetD5korLOpcQubXaglIBHXwP5jQ8t2tC9Z4c/OM44niYQvxF1Z7v8iWc45t3N0djM5PjKPIrqPnsEop3ELCv12Ed838J81VpOIKmxb045+A5ge5uSa8yl98Xd3Iv/nfx4i9UQwhZQSD2v0L93Z80nFEXnPpcQOpuj9cT8hvu3kLENx9CDwyCRBdIeBce0VWviMnie9kYPkoCRw233pgMGl6zsf5cyXoHtyKyPXbJt/T2h51gKE7pyeg5YdfEt29iIIUzp7TmSZH4Z1JOErERqKLnvfEZMzzQo+WIijqY1JQ+Wry/NFQPSryKJGBVtTNTaWwZBiHrzUC8x4WEg7TA6b3GqovLyBMf6awiQHemTpWBpuPAMwAyhhyCc44n/8s9dswnrynpuF5YDJm3g0gWRtHxa5pWE/qntX6qY2XthDc7Zg2pW1Y09eszUC+D8MRblBycrbdPN1s6xLej9lSQwW0F8LJ3APK4NTQwZyxKnTdQnNee8iitHPNihTvFJTx3j+FGTediMb+gtozv9lpZudkiY24UJNEhvQv7fgZQ1+BEa6YLh5op3ZbqDlS6kkIrpCmNZbXJvHPXzcP4gx0CFyMZcbgBawVedfZI5j/42pCrp/n26IuDQJbqLMKUj0h5pmfOZsaZwax51ALVHEAISKtps2QdZU/0KcXRO5kG1VFErvOkwgu8WEoElGkh1GU3ti3pigO9ZP/Pj1m9o+Dh/hp+SGbaUKud1uhryerSQoOIUr5sA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199015)(46966006)(36840700001)(40470700004)(82310400005)(82740400003)(66899015)(45080400002)(36860700001)(83380400001)(110136005)(54906003)(40460700003)(9686003)(47076005)(4326008)(8676002)(2906002)(33656002)(70206006)(70586007)(26005)(478600001)(7696005)(40480700001)(81166007)(6506007)(356005)(316002)(41300700001)(53546011)(336012)(52536014)(5660300002)(8936002)(86362001)(55016003)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 04:31:26.1281 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8005b0c6-cee6-430e-afef-08dac39d9872 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB9964 SGkNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTdGVmYW5vIFN0YWJl bGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IFNlbnQ6IEZyaWRheSwgTm92ZW1iZXIg MTEsIDIwMjIgNDozMyBBTQ0KPiBUbzogTWljaGFsIE9yemVsIDxtaWNoYWwub3J6ZWxAYW1kLmNv bT4NCj4gQ2M6IEppYW1laSBYaWUgPEppYW1laS5YaWVAYXJtLmNvbT47IHhlbi1kZXZlbEBsaXN0 cy54ZW5wcm9qZWN0Lm9yZzsgV2VpDQo+IENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBCZXJ0cmFu ZCBNYXJxdWlzDQo+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBqdWxpZW5AeGVuLm9yZzsg c3N0YWJlbGxpbmlAa2VybmVsLm9yZw0KPiBTdWJqZWN0OiBSZTogWGVuIEFybSB2cGwwMTEgVUFS VCB3aWxsIGNhdXNlIHNlZ21lbnRhdGlvbiBmYXVsdCBpbiBMaW51eA0KPiBndWVzdA0KPiANCj4g T24gV2VkLCA5IE5vdiAyMDIyLCBNaWNoYWwgT3J6ZWwgd3JvdGU6DQo+ID4gSGkgSmlhbWVpLA0K PiA+DQo+ID4gT24gMDkvMTEvMjAyMiAwOToyNSwgSmlhbWVpIFhpZSB3cm90ZToNCj4gPiA+DQo+ ID4gPg0KPiA+ID4gSGkgTWljaGFs77yMDQo+ID4gPg0KPiA+ID4gQmVsb3cgbG9nIGNhbiBiZSBn b3Qgd2hlbiBzdGF0aW5nIHRoZSBsaW51eCBndWVzdC4gSXQgc2F5cyA5YzA5IGlzIHNic2EuDQo+ IEFuZCA5YzA5IGlzIGFsc28gb3V0cHV0DQo+ID4gPiAgaW4gYm9vdGxvZ2QgZXJyb3IgbWVzc2Fn ZToNCj4gPiA+IFNlcmlhbDogQU1CQSBQTDAxMSBVQVJUIGRyaXZlcg0KPiA+ID4gOWMwYjAwMDAu dWFydDogdHR5QU1BMCBhdCBNTUlPIDB4OWMwYjAwMDAgKGlycSA9IDEyLCBiYXNlX2JhdWQgPSAw KQ0KPiBpcyBhIFBMMDExIHJldjINCj4gPiA+IHByaW50azogY29uc29sZSBbdHR5QU1BMF0gZW5h YmxlZA0KPiA+ID4gOWMwOTAwMDAuc2JzYS11YXJ0OiB0dHlBTUExIGF0IE1NSU8gMHg5YzA5MDAw MCAoaXJxID0gMTUsIGJhc2VfYmF1ZA0KPiA9IDApIGlzIGEgU0JTQQ0KPiA+ID4NCj4gPg0KPiA+ IFhlbiBiZWhhdmlvciBpcyBjb3JyZWN0IGFuZCB0aGlzIHdvdWxkIGJlIExpbnV4IGZhdWx0IHRv IHRyeSB0byB3cml0ZSB0bw0KPiBETUFDUiBmb3IgU0JTQSBVQVJUIGRldmljZS4NCj4gPiBETUFD UiBpcyBqdXN0IGFuIGV4YW1wbGUuIElmIHlvdSB0cnkgdG8gcHJvZ3JhbSBlLmcuIHRoZSBiYXVk cmF0ZSAodGhyb3VnaA0KPiBMQ1IpIGZvciBWUEwwMTEgaXQgd2lsbA0KPiA+IGFsc28gcmVzdWx0 IGluIGluamVjdGluZyBhYm9ydCBpbnRvIHRoZSBndWVzdC4gU2hvdWxkIFhlbiBzdXBwb3J0IGl0 PyBOby4gVGhlDQo+IHJlYXNvbiB3aHkgaXMgdGhhdA0KPiA+IGl0IGlzIG5vdCBzcGVjIGNvbXBs aWFudCBvcGVyYXRpb24uIFNCU0Egc3BlY2lmaWNhdGlvbiBkaXJlY3RseSBzcGVjaWZpZXMNCj4g d2hhdCByZWdpc3RlcnMgYXJlIGV4cG9zZWQuDQo+ID4gSWYgTGludXggdHJpZXMgdG8gd3JpdGUg dG8gc29tZSBvZiB0aGUgbm9uZS1zcGVjIGNvbXBsaWFudCByZWdpc3RlcnMgLSBpdCBpcyBpdHMN Cj4gZmF1bHQuDQo+IA0KPiBZZWFoLCB3ZSBuZWVkIHRvIGZpeCBMaW51eC4NCj4gDQo+IEZZSSB0 aGlzIGlzIG5vdCB0aGUgZmlyc3QgYnVnIGluIExpbnV4IGFmZmVjdGluZyB0aGUgc2JzYS11YXJ0 IGRyaXZlcjoNCj4gdGhlIGlzc3VlIGlzIHRoYXQgdGhlIHBsMDExIGRyaXZlciBhbmQgdGhlIHNi c2EtdWFydCBkcml2ZXIgc2hhcmUgdGhlDQo+IHNhbWUgY29kZSBpbiBMaW51eCBzbyBpdCBoYXBw ZW5zIHNvbWV0aW1lcyB0aGF0IGEgcGwwMTEtb25seSBmZWF0dXJlDQo+IGNyZWVwcyBpbnRvIHRo ZSBzYnNhLXVhcnQgZHJpdmVyIGJ5IG1pc3Rha2UuDQoNClRoYW5rcyBmb3IgeW91ciBjb25maXJt IGFib3V0IHRoaXMuIEluIHRoYXQgY2FzZSwgSSB3aWxsIGNoZWNrIHRoZSBMaW51eCBjb2RlIHRv IHNlZSB3aHkgdGhpcyBoYXBwZW5zIGFuZCBob3cgdG8gZml4IGl0Lg0KDQpCZXN0IHdpc2hlcw0K SmlhbWVpIFhpZQ0KPiANCj4gDQo+ID4gPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4g PiA+PiBGcm9tOiBNaWNoYWwgT3J6ZWwgPG1pY2hhbC5vcnplbEBhbWQuY29tPg0KPiA+ID4+IFNl bnQ6IFdlZG5lc2RheSwgTm92ZW1iZXIgOSwgMjAyMiAzOjQwIFBNDQo+ID4gPj4gVG86IEppYW1l aSBYaWUgPEppYW1laS5YaWVAYXJtLmNvbT47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9y Zw0KPiA+ID4+IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IEJlcnRyYW5kIE1hcnF1 aXMNCj4gPiA+PiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsganVsaWVuQHhlbi5vcmc7IHNz dGFiZWxsaW5pQGtlcm5lbC5vcmcNCj4gPiA+PiBTdWJqZWN0OiBSZTogWGVuIEFybSB2cGwwMTEg VUFSVCB3aWxsIGNhdXNlIHNlZ21lbnRhdGlvbiBmYXVsdCBpbiBMaW51eA0KPiA+ID4+IGd1ZXN0 DQo+ID4gPj4NCj4gPiA+PiBIaSBKaWFtZWksDQo+ID4gPj4NCj4gPiA+PiBPbiAwOS8xMS8yMDIy IDA4OjIwLCBKaWFtZWkgWGllIHdyb3RlOg0KPiA+ID4+Pg0KPiA+ID4+Pg0KPiA+ID4+PiBIaSBh bGwsDQo+ID4gPj4+DQo+ID4gPj4+IFdoZW4gdGhlIGd1ZXN0IGtlcm5lbCBlbmFibGVzIERNQSBl bmdpbmUgd2l0aA0KPiA+ID4+ICJDT05GSUdfRE1BX0VOR0lORT15IiwgTGludXggQU1CQSBQTDAx MSBkcml2ZXIgd2lsbCBhY2Nlc3MgUEwwMTENCj4gPiA+PiBETUFDUiByZWdpc3Rlci4gQnV0IHRo aXMgcmVnaXN0ZXIgaGF2ZSBub3QgYmVlbiBzdXBwb3J0ZWQgYnkgdnBsMDExIG9mDQo+IFhlbi4N Cj4gPiA+PiBYZW4gd2lsbCBpbmplY3QgYSBkYXRhIGFib3J0IGludG8gZ3Vlc3QsIHRoaXMgd2ls bCBjYXVzZSBzZWdtZW50YXRpb24gZmF1bHQNCj4gb2YNCj4gPiA+PiBndWVzdCB3aXRoIHRoZSBi ZWxvdyBtZXNzYWdlOg0KPiA+ID4+IEkgYW0gcXVpdGUgY29uZnVzZWQuDQo+ID4gPj4gVlBMMDEx IGltcGxlbWVudHMgU0JTQSBVQVJUIHdoaWNoIG9ubHkgaW1wbGVtZW50cyBzb21lIHN1YnNldCBv Zg0KPiBQTDAxMQ0KPiA+ID4+IG9wZXJhdGlvbnMgKFNCU0EgVUFSVCBpcyBub3QgUEwwMTEpLg0K PiA+ID4+IEFjY29yZGluZyB0byBzcGVjIChTQlNBIHZlci4gNi4wKSwgdGhlIFNCU0FfVUFSVCBk b2VzIG5vdCBzdXBwb3J0DQo+IERNQQ0KPiA+ID4+IGZlYXR1cmVzIHNvIFhlbiBjb2RlIGlzIGZp bmUuDQo+ID4gPj4gV2hlbiBYZW4gZXhwb3NlcyB2cGwwMTEgZGV2aWNlIHRvIGEgZ3Vlc3QsIHRo aXMgZGV2aWNlIGhhcyAiYXJtLHNic2EtDQo+IHVhcnQiDQo+ID4gPj4gY29tcGF0aWJsZSBhbmQg bm90ICJ1YXJ0LXBsMDExIi4NCj4gPiA+PiBMaW51eCBkcml2ZXIgImFtYmEtcGwwMTEuYyIgc2hv dWxkIHNlZSB0aGlzIGNvbXBhdGlibGUgYW5kIGFzc2lnbg0KPiBwcm9wZXINCj4gPiA+PiBvcGVy YXRpb25zIChzYnNhX3VhcnRfcG9wcyBpbnN0ZWFkIG9mIGFtYmFfcGwwMTFfcG9wcykgdGhhdCBk byBub3QNCj4gZW5hYmxlDQo+ID4gPj4gRE1BLg0KPiA+ID4+IE1heWJlIHRoZSBpc3N1ZSBpcyB3 aXRoIHlvdXIgY29uZmlndXJhdGlvbj8NCj4gPiA+Pg0KPiA+ID4+IH5NaWNoYWwNCj4gPiA+Pg0K PiA+ID4+PiBVbmhhbmRsZWQgZmF1bHQgYXQgMHhmZmZmZmZjMDA5NDRkMDQ4DQo+ID4gPj4+IE1l bSBhYm9ydCBpbmZvOg0KPiA+ID4+PiBFU1IgPSAweDk2MDAwMDAwDQo+ID4gPj4+IEVDID0gMHgy NTogREFCVCAoY3VycmVudCBFTCksIElMID0gMzIgYml0cw0KPiA+ID4+PiBTRVQgPSAwLCBGblYg PSAwDQo+ID4gPj4+IEVBID0gMCwgUzFQVFcgPSAwDQo+ID4gPj4+IEZTQyA9IDB4MDA6IHR0YnIg YWRkcmVzcyBzaXplIGZhdWx0DQo+ID4gPj4+IERhdGEgYWJvcnQgaW5mbzoNCj4gPiA+Pj4gSVNW ID0gMCwgSVNTID0gMHgwMDAwMDAwMA0KPiA+ID4+PiBDTSA9IDAsIFduUiA9IDANCj4gPiA+Pj4g c3dhcHBlciBwZ3RhYmxlOiA0ayBwYWdlcywgMzktYml0IFZBcywgcGdkcD0wMDAwMDAwMDIwZTJl MDAwDQo+ID4gPj4+IFtmZmZmZmZjMDA5NDRkMDQ4XSBwZ2Q9MTAwMDAwMDAzZmZmZjgwMywgcDRk PTEwMDAwMDAwM2ZmZmY4MDMsDQo+ID4gPj4gcHVkPTEwMDAwMDAwM2ZmZmY4MDMsIHBtZD0xMDAw MDAwMDNmZmZhODAzLA0KPiBwdGU9MDA2ODAwMDA5YzA5MGYxMw0KPiA+ID4+PiBJbnRlcm5hbCBl cnJvcjogdHRiciBhZGRyZXNzIHNpemUgZmF1bHQ6IDk2MDAwMDAwIFsjMV0gUFJFRU1QVCBTTVAN Cj4gPiA+Pj4gTW9kdWxlcyBsaW5rZWQgaW46DQo+ID4gPj4+IENQVTogMCBQSUQ6IDEzMiBDb21t OiBib290bG9nZCBOb3QgdGFpbnRlZCA1LjE1LjQ0LXlvY3RvLXN0YW5kYXJkDQo+ICMxDQo+ID4g Pj4+IHBzdGF0ZTogNjA0MDAwYzUgKG5aQ3YgZGFJRiArUEFOIC1VQU8gLVRDTyAtRElUIC1TU0JT IEJUWVBFPS0tKQ0KPiA+ID4+PiBwYyA6IHBsMDExX3N0b3BfcngrMHg3MC8weDgwDQo+ID4gPj4+ IGxyIDogdWFydF90dHlfcG9ydF9zaHV0ZG93bisweDQ0LzB4MTEwDQo+ID4gPj4+IHNwIDogZmZm ZmZmYzAwOTk5YmJhMA0KPiA+ID4+PiB4Mjk6IGZmZmZmZmMwMDk5OWJiYTAgeDI4OiBmZmZmZmY4 MDIzNGFjMzgwIHgyNzogZmZmZmZmODAyMmY1ZDAwMA0KPiA+ID4+PiB4MjY6IDAwMDAwMDAwMDAw MDAwMDAgeDI1OiAwMDAwMDAwMDQ1NTg1NDAxIHgyNDoNCj4gMDAwMDAwMDAwMDAwMDAwMA0KPiA+ ID4+PiB4MjM6IGZmZmZmZjgwMjFiYTQ2NjAgeDIyOiAwMDAwMDAwMDAwMDAwMDAxIHgyMTogZmZm ZmZmODAyMWEwZTJhMA0KPiA+ID4+PiB4MjA6IGZmZmZmZjgwMjE5OGY4ODAgeDE5OiBmZmZmZmY4 MDIxYTBlMWEwIHgxODogMDAwMDAwMDAwMDAwMDAwMA0KPiA+ID4+PiB4MTc6IDAwMDAwMDAwMDAw MDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwIHgxNToNCj4gMDAwMDAwMDAwMDAwMDAwMA0KPiA+ ID4+PiB4MTQ6IDAwMDAwMDAwMDAwMDAwMDAgeDEzOiAwMDAwMDAwMDAwMDAwMDAwIHgxMjoNCj4g MDAwMDAwMDAwMDAwMDAwMA0KPiA+ID4+PiB4MTE6IDAwMDAwMDAwMDAwMDAwMDAgeDEwOiAwMDAw MDAwMDAwMDAwMDAwIHg5IDoNCj4gZmZmZmZmYzAwODcxYmExNA0KPiA+ID4+PiB4OCA6IGZmZmZm ZmMwMDk5ZGUyNjAgeDcgOiBmZmZmZmY4MDIxYTBlMzE4IHg2IDogMDAwMDAwMDAwMDAwMDAwMw0K PiA+ID4+PiB4NSA6IGZmZmZmZmMwMDkzMTVmMjAgeDQgOiBmZmZmZmZjMDA5NDRkMDM4IHgzIDog MDAwMDAwMDAwMDAwMDAwMA0KPiA+ID4+PiB4MiA6IGZmZmZmZmMwMDk0NGQwNDggeDEgOiAwMDAw MDAwMDAwMDAwMDAwIHgwIDogMDAwMDAwMDAwMDAwMDA0OA0KPiA+ID4+PiBDYWxsIHRyYWNlOg0K PiA+ID4+PiBwbDAxMV9zdG9wX3J4KzB4NzAvMHg4MA0KPiA+ID4+PiB0dHlfcG9ydF9zaHV0ZG93 bisweDdjLzB4YjQNCj4gPiA+Pj4gdHR5X3BvcnRfY2xvc2UrMHg2MC8weGNjDQo+ID4gPj4+IHVh cnRfY2xvc2UrMHgzNC8weDhjDQo+ID4gPj4+IHR0eV9yZWxlYXNlKzB4MTQ0LzB4NGMwDQo+ID4g Pj4+IF9fZnB1dCsweDc4LzB4MjIwDQo+ID4gPj4+IF9fX19mcHV0KzB4MWMvMHgzMA0KPiA+ID4+ PiB0YXNrX3dvcmtfcnVuKzB4ODgvMHhjMA0KPiA+ID4+PiBkb19ub3RpZnlfcmVzdW1lKzB4OGQw LzB4MTIzYw0KPiA+ID4+PiBlbDBfc3ZjKzB4YTgvMHhjMA0KPiA+ID4+PiBlbDB0XzY0X3N5bmNf aGFuZGxlcisweGE0LzB4MTMwDQo+ID4gPj4+IGVsMHRfNjRfc3luYysweDFhMC8weDFhNA0KPiA+ ID4+PiBDb2RlOiBiOTAwMDA4MyBiOTAxZjAwMSA3OTQwMzhhMCA4YjAwMDA0MiAoYjkwMDAwNDEp DQo+ID4gPj4+IC0tLVsgZW5kIHRyYWNlIDgzZGQ5M2RmMTVjMzIxNmYgXS0tLQ0KPiA+ID4+PiBu b3RlOiBib290bG9nZFsxMzJdIGV4aXRlZCB3aXRoIHByZWVtcHRfY291bnQgMQ0KPiA+ID4+PiAv ZXRjL3JjUy5kL1MwN2Jvb3Rsb2dkOiBsaW5lIDQ3OiAxMzIgU2VnbWVudGF0aW9uIGZhdWx0IHN0 YXJ0LXN0b3AtDQo+ID4gPj4gZGFlbW9uDQo+ID4gPj4+IEluIFhlbiwgdnBsMDExX21taW9fd3Jp dGUgZG9lc24ndCBoYW5kbGUgRE1BQ1IgLiBBbmQga2VybmVsIGRvZXNuJ3QNCj4gPiA+PiBjaGVj ayBpZiBwbDAxMV93cml0ZSBleGVjdXRlcyBzdWNlc3NmdWxseSBpbiBwbDAxMV9kbWFfcnhfc3Rv cCAuIFNvDQo+IHN1Y2gNCj4gPiA+PiBzZWdtZW50YXRpb24gZmF1bHQgb2NjdXJzLg0KPiA+ID4+ PiBzdGF0aWMgaW5saW5lIHZvaWQgcGwwMTFfZG1hX3J4X3N0b3Aoc3RydWN0IHVhcnRfYW1iYV9w b3J0ICp1YXApDQo+ID4gPj4+IHsNCj4gPiA+Pj4gICAgICAgICAvKiBGSVhNRS4gIEp1c3QgZGlz YWJsZSB0aGUgRE1BIGVuYWJsZSAqLw0KPiA+ID4+PiAgICAgICAgIHVhcC0+ZG1hY3IgJj0gflVB UlQwMTFfUlhETUFFOw0KPiA+ID4+PiAgICAgICAgIHBsMDExX3dyaXRlKHVhcC0+ZG1hY3IsIHVh cCwgUkVHX0RNQUNSKTsNCj4gPiA+Pj4gfQ0KPiA+ID4+Pg0KPiA+ID4+PiBJIHRoaW5rIHdlIHNo b3VsZCBwcmV2ZW50IHN1Y2ggc2VnbWVudGF0aW9uIGZhdWx0LiBXZSBoYXZlIGNoZWNrZWQNCj4g dGhlDQo+ID4gPj4gUEwwMTEgc3BlYywgaXQgc2VlbXMgdGhlcmUgaXMgbm90IGFueSByZWdpc3Rl ciBiaXQgY2FuIGluZGljYXRlIERNQQ0KPiBzdXBwb3J0DQo+ID4gPj4gc3RhdHVzIG9mIFBMMDEx LiBXZSBtaWdodCBoYXZlIHR3byBvcHRpb25zOg0KPiA+ID4+PiAxLiBPcHRpb24jMSBpcyB0byBh ZGQgRE1BIHN1cHBvcnQgZm9yIHZwbDAxMSwgYnV0IHRoaXMgaXMgbm90IHRyaXZpYWwuDQo+ID4g Pj4+IDIuIE9wdGlvbiMyIGlzIHRvIGlnbm9yZSB0aGUgd3JpdGUgdG8gRE1BQ1IsIGFuZCByZXR1 cm4gMCBmb3IgRE1BQ1INCj4gcmVhZA0KPiA+ID4+IGluIHZwbDAxMS4gQnV0IHRoaXMgb3B0aW9u IG5lZWQgY28td29yayB3aXRoIGtlcm5lbCwgYmVjYXVzZSBjdXJyZW50DQo+IExpbnV4DQo+ID4g Pj4gUEwwMTEgZHJpdmVyIGFzc3VtZSB0aGUgd3JpdGUgb3BlcmF0aW9uIHdpbGwgbmV2ZXIgYmUg ZmFpbGVkLCBhbmQgd2lsbA0KPiBub3QNCj4gPiA+PiBmYWxsYmFjayB0byBuby1ETUEgbW9kZSwg d2hlbiBYZW4gcmV0dXJuIDAgZm9yIERNQSBlbmFibGVkIGJpdCBpbg0KPiBETUFDUi4NCj4gPiA+ Pj4NCj4gPiA+Pj4gSG93IGRvIHlvdSB0aGluayBhYm91dCBpdD8gIEFueSBzdWdnZXN0aW9uIGFi b3V0IGl0IGlzIHdlbGNvbWUuDQo+IFRoYW5rcy4NCj4gPiA+Pj4NCj4gPiA+Pj4gQmVzdCB3aXNo ZXMNCj4gPiA+Pj4gSmlhbWVpIFhpZQ0KPiA+ID4+Pg0KPiA+DQo= From xen-devel-bounces@lists.xenproject.org Fri Nov 11 05:57:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 05:57:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442317.696409 (Exim 4.92) (envelope-from ) id 1otN2g-0004HZ-Ml; Fri, 11 Nov 2022 05:57:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442317.696409; Fri, 11 Nov 2022 05:57:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otN2g-0004HS-JD; Fri, 11 Nov 2022 05:57:30 +0000 Received: by outflank-mailman (input) for mailman id 442317; Fri, 11 Nov 2022 05:57:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otN2f-0004HI-Tc; Fri, 11 Nov 2022 05:57:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otN2f-0005Il-R0; Fri, 11 Nov 2022 05:57:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otN2f-0000nA-AQ; Fri, 11 Nov 2022 05:57:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otN2f-0003XR-9v; Fri, 11 Nov 2022 05:57:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PkZVj+TrwgqZd2GxOULm0mkxvC3pRm8sjG270WqFC6A=; b=nYyEGEw1FGLpHaR65pai7fUnxf hnRsYRwzzeaft/aljPgebXTdrHevDMPOcQQqi3JNFmyXEsnopQ/8mpYhUPbjqAhmGBqca636VWt31 WqILtvCTTnoBj+Whdg89OLhI3gzia6yX50SIUTw9tnUS0triR54BaHHuyc/B25HVFkgY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174724: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-i386-freebsd10-amd64:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a4180b03fffafa1868b0bcacc20198d4caef2908 X-Osstest-Versions-That: xen=aa1bf3858551b7cd1facfb116fe35830aceac497 From: osstest service owner Date: Fri, 11 Nov 2022 05:57:29 +0000 flight 174724 xen-unstable real [real] flight 174732 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174724/ http://logs.test-lab.xenproject.org/osstest/logs/174732/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-pair 11 xen-install/dst_host fail pass in 174732-retest Tests which did not succeed, but are not blocking: test-amd64-i386-freebsd10-amd64 7 xen-install fail like 174701 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174701 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174701 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174701 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174701 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174701 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174701 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174701 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174701 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174701 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174701 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174701 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174701 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen a4180b03fffafa1868b0bcacc20198d4caef2908 baseline version: xen aa1bf3858551b7cd1facfb116fe35830aceac497 Last test of basis 174701 2022-11-09 22:34:06 Z 1 days Testing same since 174724 2022-11-10 19:21:35 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Roger Pau Monne Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git aa1bf38585..a4180b03ff a4180b03fffafa1868b0bcacc20198d4caef2908 -> master From xen-devel-bounces@lists.xenproject.org Fri Nov 11 06:03:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 06:03:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442325.696420 (Exim 4.92) (envelope-from ) id 1otN86-0005mn-Bl; Fri, 11 Nov 2022 06:03:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442325.696420; Fri, 11 Nov 2022 06:03:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otN86-0005mg-98; Fri, 11 Nov 2022 06:03:06 +0000 Received: by outflank-mailman (input) for mailman id 442325; Fri, 11 Nov 2022 06:03:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otN85-0005mW-Cb; Fri, 11 Nov 2022 06:03:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otN85-0005VU-4x; Fri, 11 Nov 2022 06:03:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otN84-00010I-Bc; Fri, 11 Nov 2022 06:03:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otN84-0006BO-BD; Fri, 11 Nov 2022 06:03:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kNNdSXDjGWhOF67UoW7qbElsIcNtkIfsWv4J1eVrliU=; b=cMpZxNoth5+4VonBHZbsMLR1El gErZrKFxgAZoJUOoLv6a2fprbOCEHx8xjnah6C8DTk0SSrxjVKZcnc1QzbamP89+TLO/TiAhNO6sP jxo+Avf7HRWKSPOZkVznF5JtdnqtV6yKHwowGZM4dqSbQQRYJHyd0ynAaWAlEkwXmLFs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174730: all pass - PUSHED X-Osstest-Versions-This: ovmf=c8fb7240469b5753773da4fa5710b870b790c363 X-Osstest-Versions-That: ovmf=342813a3f7794bf67405a236053f27c916804d36 From: osstest service owner Date: Fri, 11 Nov 2022 06:03:04 +0000 flight 174730 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174730/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c8fb7240469b5753773da4fa5710b870b790c363 baseline version: ovmf 342813a3f7794bf67405a236053f27c916804d36 Last test of basis 174729 2022-11-11 01:10:36 Z 0 days Testing same since 174730 2022-11-11 03:48:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Michael D Kinney Sainadh Nagolu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 342813a3f7..c8fb724046 c8fb7240469b5753773da4fa5710b870b790c363 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Nov 11 07:46:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 07:46:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442337.696431 (Exim 4.92) (envelope-from ) id 1otOjU-0000f1-Qh; Fri, 11 Nov 2022 07:45:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442337.696431; Fri, 11 Nov 2022 07:45:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otOjU-0000eu-Nd; Fri, 11 Nov 2022 07:45:48 +0000 Received: by outflank-mailman (input) for mailman id 442337; Fri, 11 Nov 2022 07:45:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otOjT-0000eo-7w for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 07:45:47 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80051.outbound.protection.outlook.com [40.107.8.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d958d46c-6194-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 08:45:45 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6769.eurprd04.prod.outlook.com (2603:10a6:208:17f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 07:45:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Fri, 11 Nov 2022 07:45:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d958d46c-6194-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=csb4OnKo7CR8/RmlcqfwUHh8SZJQl+9cMudikig7efwKmQNHIiKcxdWPO6p3Rwj0x6oDdUEcCL+9R43NEIb8RG9KsscqH4uRAafLnwLcD3s01RSV+OA/La6xyJn10v9PzIgmEkzwDhxi9nzJNA1uVfuoGP5pdTSwv3M3v9nuxVdHI+JDGJytBqFP8/TG78nOCW6r1tZAg0pkiWocP1ocpXYmwSaxjpD76GR+OS3TWR67CkNIGkUZCL5BLCAiW/NYCcCcg444Uou+BamZi2IUc7QHLmSI+uF29F65h6HsplrhX28jZIYBsu6T2EYp2xA5xlDpgn0seOjhati76Q91Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bM0Si6t+vEsHgvIJc9kYQOKQoFI7uNYZTr7nOJuTpLE=; b=E/i3m2rOig+Z/P3jiGDuQNZ/4e8f18myQLR3MxWNFnWtWVi1OEPapYJeSvkd5xE2euaZ2Ujn9ArRHUnewP/nZDPOh8zToggBCq8rAijs8SR37tGJUDVCdAd+kR5aPc4FrwcEx1wd8oR1TvUo/K6Rk4r9JbKsjvzIWz3c4qSAlYD8FKqT/JxCUtTwXtfjRU7p+weisUquTV+ztoAxFFJDU3RV3wn7xyztNugsJXaZxTaY5I8ssmobktK4lryJgE+y7FEa/fIKs/NoU/lSUUGeCpzb+C9j/u9oycHKac/BnTBox+tsC+EW3/dDdgXwmWzceEyLYxF83DPxPDCYLOZ3mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bM0Si6t+vEsHgvIJc9kYQOKQoFI7uNYZTr7nOJuTpLE=; b=f01CR1L74L5J7cNRDeB0ZYCYZCh0L7GzZy0k4Ae/2jfzv/jWmdj2KxQ5ADoHlsW9A6iHCIXouvzpRGuQ0EgUgxviHDg1/TdHNLICyLeHHWv2ToKzB4UDTQxEO2/tbaDs/GTSyDlwNkUfRhypZs2Wyuw+qY3d3NgleIyZhzLkTrINN2CaLEJ08HmVQg7g5AoDYCWxHDgNuHqmfnyfOChknMTolZqkYEPCWuEKizKUDJyZUMyhM087zo5mdA1vJfIuw3J/pAlYFQw4AF1HRRnK7tsRuRLPAvna0rPzN6CUqIeFAQclREriW734t9lZOz5BHnzVVSo2uNptJti70z9+Iw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8e52a065-0141-f75c-03e8-e9ceb18a0aa1@suse.com> Date: Fri, 11 Nov 2022 08:45:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Content-Language: en-US To: Andrew Cooper Cc: "Henry.Wang@arm.com" , Paul Durrant , Wei Liu , Jun Nakajima , Kevin Tian , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <20221104161815.38007-1-roger.pau@citrix.com> <69841767-ccc4-5eeb-6e9c-d59dfb197ea5@citrix.com> From: Jan Beulich In-Reply-To: <69841767-ccc4-5eeb-6e9c-d59dfb197ea5@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0064.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6769:EE_ X-MS-Office365-Filtering-Correlation-Id: 478f6dc6-2ffb-4aeb-8a54-08dac3b8bc11 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: whRglS81c0JytezXxvjmuS5yE9IcXA7lcJQGBSKzUAJun+KYhIyDkpFpXyY2D6rC1JCNfkqfuOdR8loIov5EJAFpmXFctJg8DGYKe1sJ3bXDH+FhjmKoAHKVUMcaU4L4qC65qQJUQ92JoWi72lbtDr5JNxyEvU/aTX2FkDahWKSQh6IKynWGby5i9VyNK22leREwfNY0kgS/HNXpAsX5/akbg8le7K/I4ZCvRjOVqdQTatZN5ndx4cJUoiIXXnGDMfncPURrCk9Hz7YqsqSUhvQnmIary3QhrnzcEx9xqsE515tQOoJAc4cyso3sD5GnbrxXtO2+sbgUdTMpLgwjAjZ74WGIyeZCmEpVl9PfCqGtg8f7o1nqx2lyQhVgo+PE+7ou+XdhRPalsL9WHQp2dkl9unsTjR/698IrwRUQ03zvP/zEFE0HjVtuMBAuGsK8u+Gmp7wZhgcBaptyjscco8OxsIik0WKsibd6ljQ7L5GNXzulIAn7YGaDyzWk8oHgCIgWiI4WMP4qYMrMJK2QKXouYeEfmsBgJ3aFddUKZtLooEZZY7kyinA8lnAs6BGkL/cp3yB/vjJyK95z0ZZqQ1G2t1EF3fk6K2eIwdIoBACHO87FjsWxi3Xqu5kqfbK1EFbrp5okkAMEOadBf3eGDIJq6AEFdDI5kBB+4ryzzZBKXzQBqRCwz2LS4Ze0siJzXGnjsuLJsWwR67DF4cPCqh8t4EUZTYTnatE04Cm9rMv0AFSrtFVXB/wkDgSjdSSjEBjwX2gd794/+PYaxWEdTYC9vuO0ArdZ1eoLt0tQKF0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(136003)(396003)(366004)(39860400002)(451199015)(83380400001)(6486002)(8936002)(478600001)(41300700001)(5660300002)(4744005)(186003)(316002)(6506007)(4326008)(38100700002)(6512007)(36756003)(26005)(31696002)(86362001)(2616005)(31686004)(2906002)(8676002)(66556008)(66946007)(53546011)(6916009)(66476007)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEdLT0N2VkQrcHBaR3p4NTJRVm92ekd5TkhrcVUraFB1bjJMYlhwY2htZ0sr?= =?utf-8?B?TUw4RmdnWDJ2QytZVWJ0M3VDY2RpQy9SZnhQU05EUjY4ZnYxVFowOEd3aWlj?= =?utf-8?B?Rmd0NWV1QXI4WVYzaXVLVnpUMlRwbVZ5RlRIMGRmc0FuTjZtd3F0MnI4RmhF?= =?utf-8?B?VFpSaVR2U2ZKakZZSUFNMjJJVjBTRFZJMnVHNEdNck84WklHN1hvczRONzNZ?= =?utf-8?B?eEo3R2pxdzZtOUlETmpSVUY2eFBBOWtrWGNSdVhRM3RMQ1NaUDYyYmNUdU9K?= =?utf-8?B?ajdUaWtCNXo2d0RmZ0ZUQmJFdzM1TDVZNlN4eEdKbnlTM3dJSlhhS2Ryd1Fo?= =?utf-8?B?ajZQZ2IrY2pIa2orMW0yYWRtSGNoK1dQenJPeGhKWllCbVRrUHI4S0M0TzQ4?= =?utf-8?B?VnNWZ3dMUlhUd1AxR1g5MkpLUlhHSDE5Y0JNcUZUUnZabXorczV2N0c4cXB6?= =?utf-8?B?eFZPaURhRnVqWWMyV2NIbzZyNk4zYUNxU0UrdzBRZXNUcWhmY1NFckJld2dE?= =?utf-8?B?Y0FNVDdFVGM0NTJ6WVhjQmU1NWhZQTQ1Q1hxVHBaYU1lbW9oaHZqTnBtZlNa?= =?utf-8?B?QXFvR2NtRUE0NnNkUjRHSHI3dkgxWEhnQVRDaStoL2c3RTBxcjVvSmM3cDYx?= =?utf-8?B?R0tsMURRL1lkY1dmQXpTTWRwNGN0d3d5WWxUcUFwV1hIMUhCUk44bFErYjl6?= =?utf-8?B?T3h5aDN0dXlsMzA5cmNGTWRNdy9OeVVxRFpRV0p1WXF6RGNqc1R0aEhHL0tk?= =?utf-8?B?NzNONlRJRjRUSTZ4YjRvUENOU29rQWxDVC9pSlVNYlh1MkxrZ1o4TGFmdGdV?= =?utf-8?B?VFNnWTd5WkljMGVmdmNRQmhRWlhZU21RVzBiMkJRTkpIUE9KWGFBOEhGNWRH?= =?utf-8?B?ZjNSZld3czZ6MWlFb1QxRXc4MDJta1ovOFM0cHZkeDluR2Qxc01QK2Z4S2lM?= =?utf-8?B?bnpvYStXYjlHdEFvNm1RUVdFalQra2pRanZsbGsveVZUcHREK051VDhnNFNU?= =?utf-8?B?Qi9CVzRZTERONFNoZDNOYksvRncwWC9YVm9rRnJmNlJRbVF1cFJiS2NUZ2xG?= =?utf-8?B?RTdIVWtOQjE3c0doYWpWdS9CbkkyWkU0SHdESExRL2pRSERCdGVWZk9NYkFW?= =?utf-8?B?RjdUZm9FUEhBb1E5anczMTg1dXVuWURVRnlwSGxWZmc0NDdKc2ZGRlB6dWhE?= =?utf-8?B?TnJncnp3QUk2NjZ3VHZZYXppUk0vODlNZHZRR1QzT1ZmcTM0NzhqUjZGQzlQ?= =?utf-8?B?bjMwVjVReWRDcjNmcFEzMTVUc0RrUURQbktCUnB4Qk4xc08veVpvSUNCeG9s?= =?utf-8?B?Tzd5ejNCMkVrYU02RVRYNmhOUjIzanZhQmxDaERaM3kwOHpSZzUvOE5qMUZw?= =?utf-8?B?alMzYXJ0S0kzVHA1VTFjY2k1SVFVc0IrRWpxS0NlNkd2WDhYOVBvRXNIczd5?= =?utf-8?B?RFpTYlJ1VDAwUlVYem9GTm54YWtFRWluSTFIZDc0ZHQrWW5ZS2ZJeE9xbnN2?= =?utf-8?B?ME5UTFduUDlHWHlvQU9CVmdYV0NwakZyL2JxbnBYUWlrK3JqdFFOSTA1OGgw?= =?utf-8?B?L1ExK3pHRSs4RE1HNnE4K0pHZzliZXkvVmF4N2tIK01jaVN1aithN0RUNjMz?= =?utf-8?B?Z0RScnpiRi9JWmlzWEhzYTNlMUc4UUtoRkZlUFpSaUUxUisyd3lOczY4UWtM?= =?utf-8?B?cGVmR201cCtLelpVSE12WDc2Um1TUnlOdHpMbys0a1ZOSklSaW4xTDE0M1RP?= =?utf-8?B?YThhK00rek1SRGIva1hQcTBVZWRFbDNqUnZ3WmlxQzFqVmp0ZWR6eW5PRXZL?= =?utf-8?B?dUZINGNJbWRSb1FhTDIxbjZGbmxwcDkrcnFLVUpQUnljQ1VDcEtIaHNndVNv?= =?utf-8?B?SWI0dEp6MVR5eHB2b1I5c3dUei9qTFBueTNPanNmYjkzYngwNU5aVmJvdzBC?= =?utf-8?B?a1NWdysvTzM2YXMvVnRwVElOSUdnMitqRlNkK0dLN1F2dlhyL21JVkZiVmpu?= =?utf-8?B?Z21oQWk4aUhhV2h3bjdqSG1lcGJxNUpQM0FrSHE0Z1pVQzZkNC9Jb25janNR?= =?utf-8?B?UEpWSDJDWlh4UHM0VzY3aTFHMzIvdUc0cjRaNHl1eTkxWEs1NkxLN3cxRGQy?= =?utf-8?Q?HLfWxIgz2F3c2/nqdNKMrlan3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 478f6dc6-2ffb-4aeb-8a54-08dac3b8bc11 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 07:45:42.6917 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PCZspe0k7UlW6Jj6uf0Bed69k8qPnThxkZJrtcV4qRS+CjYSIZWsRHyc6UUX6E5DsjAlHbH3UZ9cOR2g+QeKzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6769 On 10.11.2022 23:47, Andrew Cooper wrote: > On 04/11/2022 16:18, Roger Pau Monne wrote: >> --- a/xen/arch/x86/hvm/viridian/viridian.c >> +++ b/xen/arch/x86/hvm/viridian/viridian.c >> @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, >> res->a = CPUID4A_RELAX_TIMER_INT; >> if ( viridian_feature_mask(d) & HVMPV_hcall_remote_tlb_flush ) >> res->a |= CPUID4A_HCALL_REMOTE_TLB_FLUSH; >> - if ( !cpu_has_vmx_apic_reg_virt ) >> + if ( !has_assisted_xapic(d) ) >> res->a |= CPUID4A_MSR_BASED_APIC; > > This check is broken before and after.  It needs to be keyed on > virtualised interrupt delivery, not register acceleration. To me this connection you suggest looks entirely unobvious, so would you mind expanding as to why you're thinking so? The hint to the guest here is related to how it would best access certain registers (aiui), which to me looks orthogonal to how interrupt delivery works. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 11 07:57:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 07:57:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442346.696442 (Exim 4.92) (envelope-from ) id 1otOuK-0002Og-1R; Fri, 11 Nov 2022 07:57:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442346.696442; Fri, 11 Nov 2022 07:57:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otOuJ-0002OZ-TF; Fri, 11 Nov 2022 07:56:59 +0000 Received: by outflank-mailman (input) for mailman id 442346; Fri, 11 Nov 2022 07:56:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otOuI-0002OT-BC for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 07:56:58 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70041.outbound.protection.outlook.com [40.107.7.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6901710b-6196-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 08:56:55 +0100 (CET) Received: from DB8PR06CA0022.eurprd06.prod.outlook.com (2603:10a6:10:100::35) by VE1PR08MB5856.eurprd08.prod.outlook.com (2603:10a6:800:1ab::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 07:56:52 +0000 Received: from DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::ec) by DB8PR06CA0022.outlook.office365.com (2603:10a6:10:100::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Fri, 11 Nov 2022 07:56:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT021.mail.protection.outlook.com (100.127.142.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 07:56:51 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Fri, 11 Nov 2022 07:56:51 +0000 Received: from 060c07116091.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B09D2327-91C7-4306-A780-B7EDDBF94AA7.1; Fri, 11 Nov 2022 07:56:40 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 060c07116091.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 07:56:40 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM9PR08MB6676.eurprd08.prod.outlook.com (2603:10a6:20b:2ff::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 07:56:39 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 07:56:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6901710b-6196-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Xx0E53wLiwXKbWSxiCJu+fxPZ0MT3oeLpM35PLMIwTG1io8Cv6OecRcLJ4ocy5ytTsuOyH89qmVOvWFErdpufw9AVoxLPYtu1BKYC2iQ0EHt1FuHU0ipvVKCNU3tMVc4IbUElIMQrjSF2jo93IQTYRJjUpI/Wlsw0O+F/q6r9zSG1z5TfvQ0LKYe9XuVTRJfrpeniFCDbBz7/GkHpkqQT3uKsiBfCbhnIiKcHIFNSzDp7St84ZRuYCuFGY1NrO+ptnUIX/+WVV2JUu1rOy+RouAFI+/Vmyjnk0MUdw5Nm42yxnMNLrGfrcAvzPxlbaW3f+FDl3KGF4mPkxI9HaDaqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p4K/JReIs0wGnmT/fHNkpujlAvHDTOvPix5oIV+KhSU=; b=kOFqfnzB1IQn9z8Ns0g0D7zLT5XkmFnRsmnPC4xQbEJ4+4iyuqmNIMiCYAQ5t3uXwE3H5YEEllglJstYcdoUaVbaLZDSLDwAD05oLlfA6OaVNWPFURF2sMDqv7wI0F7onNOimCa25jK5XCJqaN03cekuI4Sla954Z9rJqF4jb7u7cU8PKEINWN7XN7R/yKHbA+bNBmMDP9XKdHN5tmVx3woDgNHvQQWYcc1KKQWhGvOevUICzK1GJ8zn/qiALgIAXVzWykYLMyfJghFlKCfd5uN++ySGsZBgDAg9g6y1zcWcpRIwen1QXQ9gTAxQL6ZpNgQk78ue2l9AQf4SL4QGgg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p4K/JReIs0wGnmT/fHNkpujlAvHDTOvPix5oIV+KhSU=; b=7eJmDkYy35cSscsQrjbDjD2+4cjC1YrYe+ut8E+d6bwURIfuq7CiMoqG5At0t/xBRqqJZem2cNByMaOCdounDGI5Y2+8vyKTl5h2pfbNN1oNvJqgnDwHev3WoK528j44Nj7QkhR84A9OjSvwgjkevXjz9/ksLR5zLm7UbCZINsc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z81Q+O2j9KN0FhnAsRhMlyLRpsIU2QPpogeN6X5C9OgvNPaPwGQAjKIs9J/jgypD/Z5V+h5p7m1lgMAX3FWIRDMJUI5waXEaNz+5Ob2+Y8zpRbtbez4CndNUtVdW6Bv9aIzzTaQ/hV/L8/ZiKazwWB2nz0TGAGLjkxX78luUQhBmBQ91CnpkaZk5oQtzEXBixZApOoSy6UUp86tV2SIPfaxSvBJcufqavr3DpAgWJIJa6VCeCGD54YEnVcZQ/y0pNaVCuEFx5x7pfB/g41GMIuf8fm6W1gJOHmw3kZaYmEBzZlJsZMzEPrMjBgPWHa4DJZ+fAtwO+izHefMOuQicog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p4K/JReIs0wGnmT/fHNkpujlAvHDTOvPix5oIV+KhSU=; b=FBjy8bnacf97SXNuJkRPeLb1/eWhtZ7G8q042pPlOmo8s5oredjKRRG9c973jgyecvO2E2RvUEqkg9rU+63SbrdWIoN+Bj1Raef6Vjslx0EzEjhvnSrm/++cRLGB1nZzj7JJX3FJnP8igcZa8oTq69KTG3mRmp7JkXeb7K+rjM4ndGlJCZPyD9gdCjdTEiZs5tAGrfNRFmcs8QkwRkVxVzbVkdwy4sCbXlj5Q7J8sijNJ+v4w6nVEWjCUQw+/ozi2V4vnWZPBSz513liuP1DcErpcHmA7gB6GVrjNS/RyPdRrOGbCfL1BKPltlEAdokG27DK+oDabA+A9X1KhBNs+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p4K/JReIs0wGnmT/fHNkpujlAvHDTOvPix5oIV+KhSU=; b=7eJmDkYy35cSscsQrjbDjD2+4cjC1YrYe+ut8E+d6bwURIfuq7CiMoqG5At0t/xBRqqJZem2cNByMaOCdounDGI5Y2+8vyKTl5h2pfbNN1oNvJqgnDwHev3WoK528j44Nj7QkhR84A9OjSvwgjkevXjz9/ksLR5zLm7UbCZINsc= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 07/11] xen/arm: implement FIXMAP_ADDR for MPU systems Thread-Topic: [PATCH v6 07/11] xen/arm: implement FIXMAP_ADDR for MPU systems Thread-Index: AQHY8DVneLUTj6n4XEmKaYaqtg988K4yT/yAgAPcKRCAAMX/AIACaq9w Date: Fri, 11 Nov 2022 07:56:38 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-8-wei.chen@arm.com> <88350ef8-3f52-7535-b3e0-b2a76e8bc7de@xen.org> In-Reply-To: <88350ef8-3f52-7535-b3e0-b2a76e8bc7de@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6D600E6ACDB5524E846A4B24DAEDF1A0.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|AM9PR08MB6676:EE_|DBAEUR03FT021:EE_|VE1PR08MB5856:EE_ X-MS-Office365-Filtering-Correlation-Id: 74ea0241-116d-4d19-e411-08dac3ba4af0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lkyRzgwAjtRy4kuETLnabTtAEVAeZCWEAuK3TxOLnmIASoC8kGD7GMhRhmbzqWHnuaZJWXHU6jhHk2wIgK4yb9pwGx1Yl+juwm3sYNve/KCP/w1vExo1RSXjSXhuRJSKRwg5Wp4P5H//wmSzWoFRGbAczXEtpclnmnwugiCFG4ZiHWn7lgBt/lS4OI7plwJC5l//NxIPSPdvfFErQAq6dsgBYi4QMsyKSRRoPYPAJwaPHas9OUxSYjaU8lFmSq6ltdKmGg4gYH+N6QfAGDgdMkOJwFGED5Fz+cKkrx9df9Ch9z9Qv2fZRZHkoPHHnLDd2pGN/6rnVawc76VZuKyER3oGVhTr9oZ7XsEqXpapt4G1OY4Ror8+t8EERNbrepAD94d4pZO0424BUjZcSuhiLyCmDPvEZ7NnrmoczfAsIQSNedWlRFY9nEIwyfBqPMDjfx/E8s71XBMBXou409gn6WCsMrxRwVP0uUnb8FqK7gsCO/V9kRfrDS5Kl7RdzU6xULHYi54Lhc2BmjlUiXwEKv9yELMxORmJPN42QHzlKSk69NqI4rYxWyuoAmswhQFV5V4es+0OplCA2vP02a7CnbPB0IpQR28eaU3T+hwoOgATSSVn7qsWpVVIz2ASsIIKXTrGmSLQP+/zVGz8TZU/eqKszYC/zI3hIhxG813miD8Ixue9VXV0iEClkdH5a0YFx6UvOkVngmrqfy+rRRRb+vSa8spvjtW9jGpJ4MmVfG35YA1A8hROSAVUH+YoEHW5EowRGwyu+9n2IRbB9DAX7g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(366004)(39860400002)(451199015)(38070700005)(71200400001)(110136005)(66446008)(316002)(66556008)(76116006)(66476007)(64756008)(66946007)(8676002)(38100700002)(55016003)(86362001)(33656002)(122000001)(26005)(6506007)(186003)(7696005)(9686003)(53546011)(54906003)(478600001)(41300700001)(2906002)(4326008)(83380400001)(5660300002)(52536014)(8936002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6676 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 18ed0bb3-e988-4e02-914b-08dac3ba4374 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 22VgmkHq5Xf2DkjaEdj5wAdn662hKfJ7MvOebXZ2yx0kVHMAZ9qvy+ibtDtfHIRfnFKMkMJLklK9Fv8XMxD6hkuF7ig3N0nw5Smcq8tJ8TKSvltzUquMuZi/4EUFfpK5I11f40KZ7VxLjTzfNrocR55wHGBf8qMYEk/OKZ0lT9q2bTC6yma02Hz2elZnTRWcJCMAGI9G8VOm4zbeVNTM/O9AzZ2Uyd3gwbodinJIWA0irA/1UFWv8CZnvzzxRfq3SLiUUsa+DzXBM8vKV8Js+qObgmy9njkzwRVPReV17PW0HKO+UV4hOzo9wTpQI9UYP/ri3ATaumULcTW7UOgZaDEFe/5H5EB9UsYfRTWRtyiV68A8jtikMub4M908Nyk/F1fiKLuDeaROYgMSIfh7PH1Yc3hmYpubiufrNNaFbQqSB3jU+0rOz1Ilj9HZ/60ktfSG9mGICen84jRaxJa+F9m1KqtjUO7+7rku21U061+U15ob+uEhNmq6E8x3kCDthYHl26QdBFIu7lrJPIrV7QsV2L300rKiGroTiBD66pXVMuJ+qcRlzSbPtzkkrF5vmZGs08N83BCYLVVmciqiVOUMeHafXzo9eqvoD1aXAr1JxC7T3sK1f1Ov9cmoSMzH+JMmDg9h5c7GILkv0YUy2TY2T1sbViEUU+D4qmoJVCItB3s/lKdz7L8hOUodRFgB8pZDEHjiRNVvX5hRM7xwDWHbpeC6T6gsbaKUxi0noqfPooK0BjZ2aigG/bzJ2bGk8rkVS9B2SSuqKs+RzXAKBw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(39860400002)(346002)(451199015)(40470700004)(36840700001)(46966006)(26005)(4326008)(47076005)(9686003)(40460700003)(8676002)(33656002)(70586007)(70206006)(2906002)(52536014)(8936002)(107886003)(86362001)(5660300002)(41300700001)(336012)(316002)(53546011)(356005)(186003)(55016003)(7696005)(478600001)(6506007)(81166007)(40480700001)(82310400005)(82740400003)(54906003)(83380400001)(110136005)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 07:56:51.4980 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 74ea0241-116d-4d19-e411-08dac3ba4af0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5856 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQxMeaciDEw5pelIDI6MzAN Cj4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnDQo+IENjOiBuZCA8bmRAYXJtLmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0 YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRyYW5kDQo+IE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1 aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVrDQo+IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFt LmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2NiAwNy8xMV0geGVuL2FybTogaW1wbGVtZW50 IEZJWE1BUF9BRERSIGZvciBNUFUNCj4gc3lzdGVtcw0KPiANCj4gDQo+IA0KPiBPbiAwOS8xMS8y MDIyIDA2OjQ2LCBXZWkgQ2hlbiB3cm90ZToNCj4gPiBIaSBKdWxpZW4sDQo+IA0KPiBIaSBXZWks DQo+IA0KPiA+DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206IEp1 bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4+IFNlbnQ6IDIwMjLlubQxMeaciDfml6Ug Mzo0NQ0KPiA+PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlz dHMueGVucHJvamVjdC5vcmcNCj4gPj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsgU3RlZmFubyBTdGFi ZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsNCj4gQmVydHJhbmQNCj4gPj4gTWFycXVp cyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPj4gPFZv bG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPiA+PiBTdWJqZWN0OiBSZTogW1BBVENIIHY2IDA3 LzExXSB4ZW4vYXJtOiBpbXBsZW1lbnQgRklYTUFQX0FERFIgZm9yIE1QVQ0KPiA+PiBzeXN0ZW1z DQo+ID4+DQo+ID4+IEhpIFdlaSwNCj4gPj4NCj4gPj4gT24gMDQvMTEvMjAyMiAxMDowNywgV2Vp IENoZW4gd3JvdGU6DQo+ID4+PiBGSVhNQVAgaXMgYSBzcGVjaWFsIHZpcnR1YWwgYWRkcmVzcyBz ZWN0aW9uIGZvciBYZW4gdG8gbWFwIHNvbWUNCj4gPj4+IHBoeXNpY2FsIHJhbSBvciBkZXZpY2Ug bWVtb3J5IHRlbXBvcmFyaWx5IGluIGluaXRpYWxpemF0aW9uIGZvcg0KPiA+Pj4gTU1VIHN5c3Rl bXMuIEZJWE1BUF9BRERSIHdpbGwgcmV0dXJuIGEgdmlydHVhbCBhZGRyZXNzIGJ5IGluZGV4DQo+ ID4+PiBmb3Igc3BlY2lhbCBwdXJwb3NlIHBoeXMtdG8tdmlydCBtYXBwaW5nIHVzYWdlLiBGb3Ig ZXhhbXBsZSwNCj4gPj4+IEZJWE1BUF9BRERSKEZJWE1BUF9DT05TT0xFKSBmb3IgZWFybHkgY29u c29sZSBtYXBwaW5nIGFuZA0KPiA+Pj4gRklYTUFQX0FERFIoRklYTUFQX01JU0MpIGZvciBjb3B5 X2Zyb21fcGFkZHIuDQo+ID4+DQo+ID4+IFRvIG1lLCB3ZSBhcmUgYmVuZGluZyBxdWl0ZSBhIGJp dCB0aGUgZGVmaW5pdGlvbiBvZiB0aGUgZml4bWFwLiBUaGVyZQ0KPiA+PiBhcmUgbm90IG1hbnkg dXNlIG9mIHRoZSBGSVhNQVAgd2l0aGluIHRoZSBjb2RlIGFuZCBJIHRoaW5rIGl0IHdvdWxkDQo+ ID4+IHNpbXBseSBiZSBiZXR0ZXIgdG8gYWJzdHJhY3QgdGhlIHVzZSAob3IgcmVtb3ZpbmcgaXQg d2hlbiBwb3NzaWJsZSkgYW5kDQo+ID4+IGF2b2lkIGRlZmluaW5nIEZJWE1BUF9BRERSKCkgJiBj byBmb3IgTVBVLg0KPiA+Pg0KPiA+DQo+ID4gSSBhZ3JlZSwgaWYgd2UgZG9uJ3QgbWluZCB0byBh ZGQgc29tZSBDT05GSUdfSEFTX01QVSBpbiBzb21lIGdlbmVyaWMNCj4gY29kZS4NCj4gDQo+IEZB T0QsIHRoaXMgaXMgbm90IHdoYXQgSSBoYWQgaW4gbWluZC4gSW5zdGVhZCwgaXQgd2FzIHRvIHBy b3ZpZGUgaGVscGVyDQo+IHdoaWNoIGZvciAhSEFTX01QVSB3b3VsZCBjYWxsIGZpeG1hcCBhbmQg Zm9yIEhBU19NUFUgd291bGQgZG8gdGhlIHdvcmsNCj4gdG8gbWFwIHRoZSByZWdpb24gaW4gdGhl IE1QVS4NCj4gDQoNClNvcnJ5LCBJIGFtIHN0aWxsIGNvbmZ1c2VkIGFib3V0IHRoaXMgY29tbWVu dCwgZGlkIHlvdSBtZWFuIHdlIGNhbiBwcm92aWRlcg0KU29tZSBnZW5lcmljIGhlbHBlcnMgbGlr ZTogZWFybHlfbWFwX2NvbnNvbGUgLyBlYXJ5X21hcF9ndWVzdF9tZW1vcnkuDQpGb3Igbm9uLU1Q VSBzeXN0ZW0sIHdlIHN0aWxsIGNhbiBjYWxsIGZpeG1hcCBpbiB0aGVzZSBjYWxsZXJzLCBidXQg Zm9yDQpNUFUgc3lzdGVtLCB3ZSBoYXZlIHRvIG1hcCB0aGUgcmVnaW9uIHRvIE1QVSByZWdpb24/ DQoNCj4gWy4uLl0NCj4gDQo+ID4+PiAgICB4ZW4vYXJjaC9hcm0vS2NvbmZpZyAgICAgICAgICAg ICAgICAgIHwgIDIgKy0NCj4gPj4+ICAgIHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9jb25maWdf bXB1LmggfCAgMiArKw0KPiA+Pj4gICAgeGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2ZpeG1hcC5o ICAgICB8IDI1DQo+ICsrKysrKysrKysrKysrKysrKysrKysrKysNCj4gPj4+ICAgIDMgZmlsZXMg Y2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPiA+Pj4NCj4gPj4+IGRp ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vS2NvbmZpZyBiL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+ ID4+PiBpbmRleCBhYzI3NjMwN2Q2Li4xNDU4ZmZhNzc3IDEwMDY0NA0KPiA+Pj4gLS0tIGEveGVu L2FyY2gvYXJtL0tjb25maWcNCj4gPj4+ICsrKyBiL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+ID4+ PiBAQCAtMTYsNyArMTYsNyBAQCBjb25maWcgQVJNDQo+ID4+PiAgICAJc2VsZWN0IEhBU19ERVZJ Q0VfVFJFRQ0KPiA+Pj4gICAgCXNlbGVjdCBIQVNfUEFTU1RIUk9VR0gNCj4gPj4+ICAgIAlzZWxl Y3QgSEFTX1BEWA0KPiA+Pj4gLQlzZWxlY3QgSEFTX1BNQVANCj4gPj4+ICsJc2VsZWN0IEhBU19Q TUFQIGlmICFIQVNfTVBVDQo+ID4+DQo+ID4+IEkgY2FuJ3QgZmluZCBhbnkgY2hhbmdlIG9mIG1t LmMgaW4gdGhpcyBzZXJpZXMuIFNvIHN1cmVseSB0aGlzIHdpbGwNCj4gPj4gYnJlYWsgdGhlIGJ1 aWxkPw0KPiA+DQo+ID4gWWVzLCBpbiBvdXIgaW50ZXJuYWwgdGVzdGluZywgb3BlbiBQTUFQIGZv ciBNUFUgd2lsbCBjYXVzZSBidWlsZGluZw0KPiA+IGZhaWxlZCwgZXhjZXB0IHdlIGFkZCBzb21l IG5ldyBzdHVicyBmb3IgTVBVIHN5c3RlbS4NCj4gDQo+IERvIHlvdSBtZWFuIHlvdSBhZGRlZCBz b21lIHN0dWJzIGZvciBQTUFQPyBJZiBzbywgSSB3b3VsZCBub3QgZXhwZWN0IGFueQ0KPiBjYWxs ZXIgZm9yIHRoZSBwbWFwKCkgdG8gYmUgdXNlZCBmb3IgdGhlIE1QVS4gVGhlcmVmb3JlLCB3aHkg d291bGQgdGhleQ0KPiBiZSBuZWNlc3Nhcnk/DQo+IA0KDQpObywgSSBtZWFuIGlmIHdlIHdhbnQg dG8gbWFrZSBwbWFwIGNhbiBiZSBidWlsdCBzdWNjZXNzZnVsbHkgZm9yIE1QVSwNCndlIGhhdmUg dG8gaW1wbGVtZW50IHNvbWUgc3R1YnMgbGlrZTogZml4X3RvX3ZpcnQsIHhlbl9maXhtYXAgYW5k DQp3cml0ZV9wdGUsIHRvIG1ha2UgY29tcGlsaW5nIHN1Y2Nlc3MuIEJ1dCBqdXN0IGFzIHlvdSBz YWlkLCB3ZSB3b3VsZA0Kbm90IGV4cGVjdCBNUFUgdG8gdXNlIGFueSBQTUFQIGZ1bmN0aW9uLCBz byB3ZSBoYXZlIG5vdCBpbXBsZW1lbnRlZA0KdGhlbSBmb3IgTVBVLiBJbnN0ZWFkIHdlIGRpc2Fi bGUgUE1BUCBmb3IgTVBVLiANCg0KQ2hlZXIsDQpXZWkgQ2hlbg0KDQo+IENoZWVycywNCj4gDQo+ IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Fri Nov 11 08:48:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 08:48:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442361.696453 (Exim 4.92) (envelope-from ) id 1otPhm-0000Xb-5b; Fri, 11 Nov 2022 08:48:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442361.696453; Fri, 11 Nov 2022 08:48:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otPhm-0000XU-1M; Fri, 11 Nov 2022 08:48:06 +0000 Received: by outflank-mailman (input) for mailman id 442361; Fri, 11 Nov 2022 08:48:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otPhk-0000XO-UI for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 08:48:05 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2042.outbound.protection.outlook.com [40.107.22.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8bf78eb3-619d-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 09:48:03 +0100 (CET) Received: from DB9PR05CA0013.eurprd05.prod.outlook.com (2603:10a6:10:1da::18) by AS2PR08MB9943.eurprd08.prod.outlook.com (2603:10a6:20b:546::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Fri, 11 Nov 2022 08:47:57 +0000 Received: from DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1da:cafe::7a) by DB9PR05CA0013.outlook.office365.com (2603:10a6:10:1da::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Fri, 11 Nov 2022 08:47:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT058.mail.protection.outlook.com (100.127.142.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 08:47:57 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Fri, 11 Nov 2022 08:47:57 +0000 Received: from 585ade191016.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C5D9AE2E-4E69-4114-B3E4-426C167EE7D4.1; Fri, 11 Nov 2022 08:47:51 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 585ade191016.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 08:47:51 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DBAPR08MB5735.eurprd08.prod.outlook.com (2603:10a6:10:1a1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 08:47:49 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 08:47:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8bf78eb3-619d-11ed-91b6-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=UDoVX3EJoPm6h5Y2ep1ODqB2fG19GCV7hh/n051/Y6ldy54uW+gYXJbnUUoxXZL5wv83amukw2PfDBW0rSWWhRMysYjskRWQXwBHlIT2EfAdVm/LCb3QEuEuGgrzvqVsMpPXM7u9PbYQb4FVahJU/JK1C402HmN3iBDVIapK17MpT3q6D8IPTe8lpKt0U82YUu677wWgxf5bluGiVst0BHeoeOJePYctg/TNtsUbTDTF/HS65LiUkjY00P6NkDravqbzkfs+66SDdaghPC+yJIa0vBu/XNoqvU61bNCu+kGLUWEZ2dD8zaJLewWU/tFsUNwF9zQUOvrUk5c/CJKNkw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8XmmDx9oXfjzp+Pt4XxDc/KYVeY5G1xcwQlLS/djCSo=; b=DSXhFj663X1lUubjgve84OnnYi8IoYC5X0z0P8zQjnb52S8/w9h2bTdPvnfng1fnTYRqA3tID81bVpFrT4uLiwZQtf5aeiq0M5eZYayN6PGw4hCzwjUbblCqjQoike52h0k0bVDjXuwKgQ0kDzNav6Np/Atj8qo8wzlrBXf2pc3HZ3hkTwODMqGIa3ODfTyJm7SGnyRFp6uClKo9hE1wmLwEB/hJi1ZusK6Nn0m6dNrftOhUX//lo0cMiarT73++6jqFjo2FOzwDN8Q9zPrSRdBdP8NirrmmJsqMN0x1OAMYmTMYN9Uhqrydr/0MzVRu3AC/HqfBpP+aMJbvplGYQg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8XmmDx9oXfjzp+Pt4XxDc/KYVeY5G1xcwQlLS/djCSo=; b=wgmuxiS65oaV2JJFSgfQvxo+Ka7Bp0zu9c6gmS2RDQiS7iErWOdhDNhG8CfJkQWrWfOxcs0J87aBUJaq8e2Bjctu1/rgd4w27g7u9KHwmObRay7S0hwVnHI4EzMRjy3I3vEJHN1LPoZ0rNwQ8EUaR41t40bbu37vlBB2rYIZcOI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 2d3b40075698a225 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VmNFCTf41CM3xxTjL+k2S3j2U8SoUxALHk3/7H38aY7yjUDs0ahWQornrMWkdLfjrM/qWkO1LeBRu3IF6pojLXkfQxQJs+DtiG3gxjP09GwrT+oZz+ZWoyQ64L5M4QsOOu0Isp4t5I6h3NfU/bK9zD0vrAKJ+bJdZyJrAchpjAf2r10o1asY+EvfLuuPILvytCx9vHRPfG9MRqPEE0Tx5xA1B1sFMsYDmHu48vsoULG400QE32WvSehdqWfY7C1VXb+/VQwV95F6gLWEc2z5VJH1/GhudvgMhHjYxfG0o4Al7NgcUuTPeF66VrM05ZNrd4Dl2Hc29MrNGu3k7mAP6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8XmmDx9oXfjzp+Pt4XxDc/KYVeY5G1xcwQlLS/djCSo=; b=X5O72lIfJ6w0M7ZDuc2CfCqECICRyRrV4BT9E0OZ+scDUhuZ1nvbVnrjSp4Ry+BsiF4BM0VZLXDYPiUWGoo20GQgR4G/kwy3JiYNx2PJyEwATluZyj6KqyUEnaf5MiXLN/KcabloPBYaLnkxv2w8HsWE75Bhp14yBFxlPxp4FZrZqaBIKc4C5tYUhIEA6MApQMaNL8Z2V2NMXNkKh/W15KDk9zs/t6mfR23zzOX92jMBkf2wsDTaWHMKr4CAx+SE7zDk69ZTR6p3ENCQGiZBuhGAxhPQxIHJTXB95+en+oc5alqgUZJhHo7+j5y1Z4j2CbzWuxCOS2JnfkYIOP1lnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8XmmDx9oXfjzp+Pt4XxDc/KYVeY5G1xcwQlLS/djCSo=; b=wgmuxiS65oaV2JJFSgfQvxo+Ka7Bp0zu9c6gmS2RDQiS7iErWOdhDNhG8CfJkQWrWfOxcs0J87aBUJaq8e2Bjctu1/rgd4w27g7u9KHwmObRay7S0hwVnHI4EzMRjy3I3vEJHN1LPoZ0rNwQ8EUaR41t40bbu37vlBB2rYIZcOI= From: Bertrand Marquis To: Stefano Stabellini CC: Michal Orzel , "xen-devel@lists.xenproject.org" , Doug Goldstein Subject: Re: [PATCH v3 0/4] Yocto Gitlab CI Thread-Topic: [PATCH v3 0/4] Yocto Gitlab CI Thread-Index: AQHY7TFh2hDh7VPqHUGkPo4tUdJZza4okuGAgAAFoQCACog5gIAEOL6AgAB51ICAANd5AIAAz2MA Date: Fri, 11 Nov 2022 08:47:48 +0000 Message-ID: References: <1220596a-4fe7-5c08-5437-fa98eb14254c@amd.com> <6ee0706b-d1b3-187a-1557-c4b8173c6e37@amd.com> <46c0e05f-47e1-39e6-d978-9f6c7d6db53a@amd.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DBAPR08MB5735:EE_|DBAEUR03FT058:EE_|AS2PR08MB9943:EE_ X-MS-Office365-Filtering-Correlation-Id: f5a6d0d0-e4da-4338-a6ca-08dac3c16e50 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8nqAuAk1zky22tWZMVfVl7JinUk/VBQzucZAAuLXr5AUxR2LeOgnZrSnrg3dH4UP3Vp/WHKwVJvT6wQKVPMZg8Mkw5/J1vlw5hFwBdG1Tw1on86AfCDsEZYHz61WnMmPTYs8X7XnTnA+RBrOveOlZDYyJmnvGNiUjBzP4883ZQ/oA5r/tN1a7/jkpob6U3QoRv+Mi5wnt+S8JqBIL4r59BWFYjPK9Yl0lKGxJIKealxApWkrenGyQSfqIJvylFShZsiZJpmUaG2vsHEeJctZe1xjf3Bo6lA8l1oFRCIgM3bs1CnAa1tgyp8zUJrfXoIceXjWexW/8iAyul+0DtyC+j3k6YlzjlPUOKnB6vrXPrq9B6TWY8PqSSiFuyRndyhaWYaFeVkl+DJ/4oD8328vMu4KNaDHmjR1ozUE0Z3JnvQuRc5HWMlTmpJ/psCtP5kNDCNgWCAF0I4EWpBXMNazhQjN1dciS+Xz3tV+kUIAKbIVBa1nKvtOtoWaSPpt0JcI/ZgJiYfmYruM71EuHf+QZPkjFS4101kOUdLLhI4LJa3fNBjoAuTZZuNa3bFXHjSITqe+lJc2GhQJUd7R5hKEYU91eAtG7XP10rY8X9qcGJExgHS4UitQMmHLkv0tJZ+6PI0I2B0d4g+HcIr7Nr93TmDQ++f6AuJ7EuZIiW7h6Qr8VtXvAdvLE+ZxcWyxPKtEz03yx4y0MC8mZ02Yyxo+4vZoYF21VgdiomXyFOUqAQhynG74S6tGVHcpMjfkwUS2TUBdiLu/HzSG64LaiBY+Vgr6XB+HspN/2/DxBWScYq5eUx/YYCnRXaG4Lgw6jJoKExz/cmf5r7V5Dv5D7YpX8A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(136003)(39860400002)(346002)(396003)(451199015)(33656002)(86362001)(36756003)(122000001)(38100700002)(5660300002)(2906002)(8936002)(26005)(186003)(83380400001)(2616005)(38070700005)(6512007)(66446008)(91956017)(54906003)(316002)(66476007)(64756008)(6916009)(76116006)(66556008)(41300700001)(8676002)(66946007)(4326008)(966005)(71200400001)(53546011)(6486002)(6506007)(45080400002)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <77957D1AE399A540B3F45D2795C75AB6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5735 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 03e144a2-8ace-4610-1c07-08dac3c16954 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CVZoIEU4uUOxR+IEgLhKnAdl5k4fY3IB1jzK8BPte614JT4u/JfeeQK6iqR9pDYX3xo4/WTihpSsiVj2hZ9M//hzqGAcec6PhT5TQ8Ft0TCyiTL1S0MOCNG7YsTsSUDz+NMHEdF/1PgKRyN6SHGsRJdZshj8z4oeI0MU9OzvGuuakGFHTeHiK4Uy2rWNl5Op8RB8elr3/Knxzch/X1V5KUWrNPoOHftgWFUelnM1ImKQPICNZAQb91fgkeZ/hl/BexgMr8gxpvIBlif9JVk3ksCt4h9hmCiu4g4imKUtsxdcy2n1LRLFvybby3InpaYDGQISCMJ85GiinMEwZ1tO9g7NEvcUNap4m6ouR2cELRAGSgf47FFp6y5ZXNCxgzGnXgv710zpzCwoNISUZwjj4Pw8QTB2S/VOJZGOCVBrflEtesmiQFvobHj/ukPFzhfuQggxTRHyrJDw6n1g5KCFjL2vpkjByj2Ny+VbktWi0nR5x1pPdnFw83TMNgLU2b82uWncuGR2N9qCcTO217pbZ6f04zU/Kaw6RFkmKzI3ZkZSGeMQLPB0y8CTCD8aP2vLjZJdIOY8IQrAj/qCtmSU2v2zoM2rlc0Jsp7bomFQPUVDbzeGnZOPQb1G+wG4LERys6eIKfWsWya+huC+1yhgioIbjyDaxgsslvKngZUNVd375AaqIVCf/uUjzTfaG8grOHaOgakNE2wHZqnCsmBEa4S+NhBn3yjN4a0bDbW4iGVjoR1g0OnaG/uShpaE49oYwdNosSA/9teJDmKm1Th2Tayf7C7yo5Xtj6PVduDyWh4g59cD/bKFcDEypvuFKZ4y X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(136003)(396003)(346002)(451199015)(46966006)(36840700001)(40470700004)(36756003)(2906002)(966005)(33656002)(356005)(40480700001)(81166007)(6486002)(478600001)(26005)(83380400001)(36860700001)(82310400005)(86362001)(6506007)(186003)(70586007)(336012)(45080400002)(8936002)(82740400003)(40460700003)(6512007)(107886003)(6862004)(5660300002)(2616005)(41300700001)(47076005)(8676002)(53546011)(70206006)(316002)(54906003)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 08:47:57.3074 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f5a6d0d0-e4da-4338-a6ca-08dac3c16e50 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9943 Hi Stefano, > On 10 Nov 2022, at 20:25, Stefano Stabellini wro= te: >=20 > On Thu, 10 Nov 2022, Michal Orzel wrote: >> Hi Stefano, >>=20 >> On 10/11/2022 01:18, Stefano Stabellini wrote: >>>=20 >>>=20 >>> On Mon, 7 Nov 2022, Michal Orzel wrote: >>>> Hi Bertrand and Stefano, >>>>=20 >>>> On 31/10/2022 16:00, Bertrand Marquis wrote: >>>>>=20 >>>>>=20 >>>>> Hi Michal, >>>>>=20 >>>>>> On 31 Oct 2022, at 14:39, Michal Orzel wrote: >>>>>>=20 >>>>>> Hi Bertrand, >>>>>>=20 >>>>>> On 31/10/2022 15:00, Bertrand Marquis wrote: >>>>>>>=20 >>>>>>>=20 >>>>>>> This patch series is a first attempt to check if we could use Yocto= in >>>>>>> gitlab ci to build and run xen on qemu for arm, arm64 and x86. >>>>>>>=20 >>>>>>> The first patch is creating a container with all elements required = to >>>>>>> build Yocto, a checkout of the yocto layers required and an helper >>>>>>> script to build and run xen on qemu with yocto. >>>>>>>=20 >>>>>>> The second patch is creating containers with a first build of yocto= done >>>>>>> so that susbsequent build with those containers would only rebuild = what >>>>>>> was changed and take the rest from the cache. >>>>>>>=20 >>>>>>> The third patch is adding a way to easily clean locally created >>>>>>> containers. >>>>>>>=20 >>>>>>> This is is mainly for discussion and sharing as there are still som= e >>>>>>> issues/problem to solve: >>>>>>> - building the qemu* containers can take several hours depending on= the >>>>>>> network bandwith and computing power of the machine where those are >>>>>>> created >>>>>> This is not really an issue as the build of the containers occurs on= the local >>>>>> machines before pushing them to registry. Also, building the contain= ers >>>>>> will only be required for new Yocto releases. >>>>>>=20 >>>>>>> - produced containers containing the cache have a size between 8 an= d >>>>>>> 12GB depending on the architecture. We might need to store the buil= d >>>>>>> cache somewhere else to reduce the size. If we choose to have one >>>>>>> single image, the needed size is around 20GB and we need up to 40GB >>>>>>> during the build, which is why I splitted them. >>>>>>> - during the build and run, we use a bit more then 20GB of disk whi= ch is >>>>>>> over the allowed size in gitlab >>>>>> As we could see during v2 testing, we do not have any space restrict= ions >>>>>> on the Xen GitLab and I think we already decided to have the Yocto >>>>>> integrated into our CI. >>>>>=20 >>>>> Right, I should have modified this chapter to be coherent with your l= atest tests. >>>>> Sorry for that. >>>>>=20 >>>>>>=20 >>>>>> I will do some testing and get back to you with results + review. >>>> I did some testing and here are the results: >>>>=20 >>>> In the current form this series will fail when running CI because the = Yocto containers >>>> are based on "From ubuntu:22.04" (there is no platform prefix), which = means that the containers >>>> are built for the host architecture (in my case and in 99% of the case= s of the local build it will >>>> be x86). In Gitlab we have 2 runners (arm64 and x86_64). This means th= at all the test jobs would need >>>> to specify x86_64 as a tag when keeping the current behavior. >>>> After I built all the containers on my x86 machine, I pushed them to r= egistry and the pipeline was successful: >>>> https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgi= tlab.com%2Fxen-project%2Fpeople%2Fmorzel%2Fxen-orzelmichal%2F-%2Fpipelines%= 2F686853939&data=3D05%7C01%7Cmichal.orzel%40amd.com%7C2449f063e67341c3b= 95a08dac2b112a5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63803636302770= 7274%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik= 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DEwTJrW2vuwQIugKc7mnzG9NNbs= YLP6tw5UODzBMmPEE%3D&reserved=3D0 >>>=20 >>> When I tested the previous version of this series I built the >>> containers natively on ARM64, so that is also an option. >>>=20 >>>=20 >>>> Here is the diff on patch no. 3 to make the series work (using x86 tag= and small improvement to include needs: []): >>>> ``` >>>> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/tes= t.yaml >>>> index 5c620fefce59..52cccec6f904 100644 >>>> --- a/automation/gitlab-ci/test.yaml >>>> +++ b/automation/gitlab-ci/test.yaml >>>> @@ -65,6 +65,9 @@ >>>> paths: >>>> - 'logs/*' >>>> when: always >>>> + needs: [] >>>> + tags: >>>> + - x86_64 >>>>=20 >>>> # Test jobs >>>> build-each-commit-gcc: >>>> @@ -206,19 +209,13 @@ yocto-qemuarm64: >>>> extends: .yocto-test >>>> variables: >>>> YOCTO_BOARD: qemuarm64 >>>> - tags: >>>> - - arm64 >>>>=20 >>>> yocto-qemuarm: >>>> extends: .yocto-test >>>> variables: >>>> YOCTO_BOARD: qemuarm >>>> - tags: >>>> - - arm32 >>>>=20 >>>> yocto-qemux86-64: >>>> extends: .yocto-test >>>> variables: >>>> YOCTO_BOARD: qemux86-64 >>>> - tags: >>>> - - x86_64 >>>> ``` >>>>=20 >>>> Now, the logical way would be to build x86 yocto container for x86, ar= m64 for arm64 and arm32 on arm64 or x86. >>>> I tried building the container qemuarm64 specifying target arm64 on x8= 6. After 15h, only 70% of the Yocto build >>>> was completed and there was an error with glibc (the local build of th= e container for the host arch takes on my machine max 2h). >>>> This enormous amount of time is due to the qemu docker emulation that = happens behind the scenes (I checked on 2 different machines). >>>>=20 >>>> So we have 3 solutions: >>>> 1) Build and run these containers for/on x86_64: >>>> - local users can build the containers on local machines that are almo= st always x86 based, in short period of time, >>>> - "everyone" can build/push the containers once there is a new Yocto r= elease >>>> - slightly slower CI build time >>>> 2) Build and run these containers for specific architectures: >>>> - almost no go for local users using x86 machine (unless using more th= an 16 threads (which I used) and willing to wait 2 days for the build) >>>> - faster CI build time (arm64 runner is faster than x86 one) >>>> - someone with arm64 based machine (not that common) would have to bui= ld and push the containers >>>> 3) Try to use CI to build and push the containers to registry >>>> - it could be possible but what about local users >>>=20 >>> From a gitlab-ci perspective, given the runners we currently have, we >>> have to go with option 2). We don't have enough resources available on >>> the x86 runner to run the Yocto jobs on x86. >>>=20 >> That is what I reckon too. Running the Yocto build/test on CI using x86 = runner will always be slower. >> So, if we go with this solution, then the following is needed: >> 1. Modify test jobs so that yocto-qemu{arm64/arm} uses arm64 tag to be t= aken by arm64 runner and use tag x86_64 for yocto-qemux86-64. >> 2. Come up with a solution to build the yocto containers automatically f= or the above platforms + possibility to specify the platform for local user= s. >> Right now, these containers are being always build for the host machin= e platform, so without doing tricks like adding --platform or prefix to ima= ge name, >> one cannot build the Yocto containers that would be ready to be pushed= to registry. We need to have a clean solution without requiring user to do= tricks. >>=20 >> The only drawback of this solution is that the person building the yocto= -qemu{arm64/arm} container and willing to push it to registry, >> needs to have access to arm64 machine. >=20 > I am fine with this drawback for now. >=20 > Due to resource constraints, we might want to avoid adding > yocto-qemux86-64 (if yocto-qemux86-64 has to run on x86) for now, I > worry it might choke the x86 ci-loop. Or we could add it but keep it > disabled. We'll enable it when we get better x86 runners.=20 Yocto-qemux86 actually runs quite well on an arm64 platform :-) Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Fri Nov 11 08:49:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 08:49:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442365.696464 (Exim 4.92) (envelope-from ) id 1otPjQ-00018a-KI; Fri, 11 Nov 2022 08:49:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442365.696464; Fri, 11 Nov 2022 08:49:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otPjQ-00018T-Gx; Fri, 11 Nov 2022 08:49:48 +0000 Received: by outflank-mailman (input) for mailman id 442365; Fri, 11 Nov 2022 08:49:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otPjP-00018J-01 for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 08:49:47 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c5cfe499-619d-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 09:49:43 +0100 (CET) Received: from mail-dm6nam04lp2049.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Nov 2022 03:48:01 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by DS7PR03MB5415.namprd03.prod.outlook.com (2603:10b6:5:2cf::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 08:47:58 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 08:47:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5cfe499-619d-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668156584; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=qfyL22txZXfv/J2TntjZ5eSLwm+hAxB0tQgn76UqQbg=; b=IJLkQ6hfR8e/n6MbvZPmszvr+D6hE2H28M7avenYDPCHb0hySLMYUl12 sG7nAxqIO17nO/VeFEeUCUY+gRSs2gT1ei5L2RXJ0SHFaQbXQ5P+yqnoH HBviBvGDuDqXGs/UJJU4yQACrf2M+LG9X7pI9GE+g40QOohi7tIdooPGl k=; X-IronPort-RemoteIP: 104.47.73.49 X-IronPort-MID: 83701194 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:h88Dtq2GSpBd571Y7fbD5epwkn2cJEfYwER7XKvMYLTBsI5bpzUPz 2MbWDiAO6mINDDyKN11bou2pkwG6J7QnN9nHgJopC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVnPKgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfQj9nr vZHKAs3bh3dvaW95ZeWF+BrmZF2RCXrFNt3VnBI6xj8VapjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouC6PnWSd05C0WDbRUteKX8ROgkeRo CTC/mL1Ax4yP92D0zuVtHmrg4cjmAurA91KTeTpqpaGhnXN/3AuEhlIR2G3pKSckWK7ZfFge 1ILr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOlMIwXy1s6 VaPkPvgHzkpu7qQIVqR/6mZhSm/Mi8UKSkFfyBsZRQBy8nupsc0lB2nczp4OKu8j9mwFTSux TmP9HQ6n+9L0Z9N0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLlQU/lhSATlrD0xIYyU IronPort-HdrOrdr: A9a23:oJP/FaF2EQy2x9UrpLqFS5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTjLJr0Unp91yy6 RNwiaQsIdWFwrJmGDn68HPTAwCrDv8nZKz+dRj8EC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBoPkoLVeLizNbFwg2PwqT+GLEXQI+llluhEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8 o= X-IronPort-AV: E=Sophos;i="5.96,156,1665460800"; d="scan'208";a="83701194" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bZn9AsSVi7iJnxyYIpyysm1hM2X+rFnuLVQNwQpzNca0RgxIcNR+47qI/tQ+1Jaiw02sEgBDPe148dbxrUyw3X/qvGBCrYmKWkCsCYXSOlqhDJkoaXw2QiH/42Z7TGu4ivTnqBAwSJ6ZYZGUbeP2148SMWIEZtiyp+bLJBvPNt2EboOV5b8oCzGHW3XZtesft9c5866Er/cjoIhzeq8zRR3K23Rxl8aPsbH2CMvtL367SbYkcnV8LANVmKJkYP5rCl66/qZgh4e9kpWxbY6n2KxTMWzVEETPzaUUs+6ecTDbrVWNwlBPURmEpRm6nbxlvlFsDy8zaPhTCHcAWtdCPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qfyL22txZXfv/J2TntjZ5eSLwm+hAxB0tQgn76UqQbg=; b=hzbk63mQgVjorUqV7hmSgsOo6IvR2/tWFBZ++EUpPq6EhYQeQXQh755AHyRWzMvCaygpP8UfNFXqwM9Y35gu2QmhraEFK7rRhmTpx0715KywY0agZ7JD6r7eTjYCG+eMInz/XjpJwxDNTMZjek/tgs4X4VtBtT89zMFDmwMBwWVxlPSAJLpqRJvnsWN3JnSq8TFAvBg5OOCqGSxnUOQyK3GwrIMDhVO0/j6U5yGUEmqIVFnRBLImLvzqZglsIFoufs4WNAyWDbc3njUVkf52wsTn7KU6W0GTAlPsfRiTBeDPc4ZelaaQebtZrs5dYG75/Nj6hRzkssEuhqyXO0jw7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qfyL22txZXfv/J2TntjZ5eSLwm+hAxB0tQgn76UqQbg=; b=a5sAVnww/22eVSMv4+dgsG4G6SJ9yHcT84tY2T7qcptYPkXYmQ3kz8yfcVV817aQnU7R1zirmRWK1RNlfJFlHZKaczPBVZA9MfITyw7o1zQ4EpH4djvrfbRkyHKwXOHo/HlCA+4MMadqXmmpqOFgZAb7oz2qPC6O2kLtfdfCvqk= From: Christian Lindig To: Edwin Torok CC: Xen-devel , Henry Wang , David Scott , Wei Liu , Anthony Perard Subject: Re: [[PATCH for-4.17 v1]] tools/ocaml/xenstored/xenstored.ml: fix incorrect scope Thread-Topic: [[PATCH for-4.17 v1]] tools/ocaml/xenstored/xenstored.ml: fix incorrect scope Thread-Index: AQHY9TJA3NadmOqYwUG//a2f83zQw645ajKA Date: Fri, 11 Nov 2022 08:47:57 +0000 Message-ID: <53AB1B57-4156-4AB7-B284-05BEFBD47B2D@citrix.com> References: <356deefe1251ac353b346762df94a134c02508f0.1668104890.git.edvin.torok@citrix.com> In-Reply-To: <356deefe1251ac353b346762df94a134c02508f0.1668104890.git.edvin.torok@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|DS7PR03MB5415:EE_ x-ms-office365-filtering-correlation-id: 5a3b9fd6-86db-40f5-2c07-08dac3c16eb6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FHt1qlmi+Zsm96zyg2A01GWH/bx+HcsEfs8+MKOIMqU3LLyNMfjpbVNg867yA6IAfpvHCq9nlBBr1jMhM7SfsCnLCbpbnii6+DmbY9Ucw7d1Ad/2j6A9Q24jzEezd2lVJSkZkCeNSoZacd5tq+OGJrG2Hm53R+KGAGg7EIC0jfy1deYZDtkYebAR7yB5MTSO9svQycac3C5pJfwtW3um9vHW5CeOhfL4ckknAcAUR/Q81njHWwVFEvb/vBtvdQD5GMGgB7GcMyl5m6hmdZAFwILUKT+nc2Yb7pZegQws8bLbcKsKWBhLaoojEtHR9xaYYwiLkfF0+AqqoZhoj5U1SSzMVJrUz0bXrDzQS4T+Qy3PS+KM0NgCuc/SJ+PpoRmdIjbwDYSaTI46troPPGo/jB5iL5Ph33mLJYG5H/ufBV71qNPuX2iaWqc/T+LSEXImj1kb8stdosIp37dt+LQkMO3/GnYcslII7cm8t5p0Gbi17h1gzNIcgGsTM9C5ryRMuITAuh6wv/p1+ur3UzP36tbvkEKEK3M8nOwfm9E4ZtWRAuW4pP47AhauTVwAdDpAQ56D9WweBAGSIDnn9gfvp2yWFaLx04xnhE1+PsH47vrH0rZJ7CJJ8mkNiz8MqmPEjczspshtWPKJh2PVSVO8/32lSCIvkm6xD7YMRsq3hIbrwQPjeCeC4D+RDcizDs77bqusoMA7lvjYdIb3P00Di1x3sv2J7eMYLo/l6YPs46GontXar/BsuyzyIhVwMlrgFH5c7ny4qgkghwIAV5z//eweR7t5PUgg6KecV3T2o+I= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(396003)(346002)(39860400002)(136003)(451199015)(6512007)(6506007)(26005)(2616005)(478600001)(38070700005)(53546011)(6486002)(107886003)(82960400001)(83380400001)(86362001)(38100700002)(186003)(36756003)(66574015)(122000001)(33656002)(8936002)(6862004)(5660300002)(41300700001)(2906002)(4744005)(44832011)(316002)(91956017)(54906003)(37006003)(6636002)(4326008)(66556008)(66476007)(64756008)(66446008)(8676002)(76116006)(66946007)(71200400001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?V1ZscEJiQmcxYXhUQ09aRWNmZVFncll4UVJGdEhhTU9zTzk0dW5ZNlFxbWcy?= =?utf-8?B?T0F4TitBTldiVXFHZDBXelJFUHR2YWdUMmxFYXkybzhPOUxvSjZ6V0pVWVl1?= =?utf-8?B?NXZ1eUdXL1d0eWpOTmJydUJLUjVqa0hkS2FkRDFxQ21wS0tCNUpQVllYVzJ0?= =?utf-8?B?UCt4bmNjWG1TdFgvazIwODVnbCt3blY1YjdZaXVVT0QyYmhaLzBNYVFvK2dt?= =?utf-8?B?OGlKL0M4VWZTS3ZMbCtobXdXeXdtaEJGeHZHVFpoaWo5Nm9Ib2J1Y2FpLzRv?= =?utf-8?B?RTdGbWNmL2pYaDdHYVZlUHNKL09iTDU4enFFS2dFUnJiSU1NUzRxSmNuREsx?= =?utf-8?B?cmtWSnhudmRmQjNIUUQzV01Ec3U0THAyR0VKaEtpVEhTaXQyWm0yY2ZWY1Jx?= =?utf-8?B?Sm10TVBteW51NEIwSFZpSFYwdXFqMHdwbnlwWWJ2aHZ0SFFOODJlZmFiUXZu?= =?utf-8?B?UWRBNmVBM1BOanpUc1RpWkM1cVJmQ095M2lrdFFrYmd6SjRaeDR1RlNJNUM4?= =?utf-8?B?bGN5dzRMc2Z5YWtXd1V6NWN5NmFFZlBMQ2J5ek91aXBVc0g1ek9iOTRqWjhB?= =?utf-8?B?ZzA0RzBVNTRyL21wRTlocEhaNkVuMVdZeXpyUGlacXZYMkp0dE1taWN6UHR6?= =?utf-8?B?NkZkamxPNThTaTRNZFJLRjhNMGp1TG1mQ1B0a01aTmhCMG9nWW4zS1VVSi9C?= =?utf-8?B?V2NjWWZTUWdXUXRzYmRseUg4anZCSytkeU1RZWFCY0dVNUozZGdQRm5TVll6?= =?utf-8?B?UXl1TGYrMDBxdGdPRjloZmp1NDZIWlY2d3JsS0NhdXpITnpJZG9pTDMrNGlV?= =?utf-8?B?Y3dBNVl4a1ArYUtkc2tkK24xTjR2Yk5uMk43WjhDQ0IzVndzR3pQaTA2bW40?= =?utf-8?B?RlAvOTF1UURFNkF3QWpBeTNxUHA0bGQyREtzZkNBQ0w0Mkg1bVRwcnZMdUxF?= =?utf-8?B?S2JPaGRneHFZUzFhL3UzZFBHclk3S1VCeW1jbUV3QXpNSzdvQXUvdHB1SlNV?= =?utf-8?B?MER5dHRaVklqSDBqa3p3RlhrRGdKMG9Lb2xNZTBNTXRZN2dtVWZ0WEhSQUVR?= =?utf-8?B?ekIrKzc5UVZZdG1DNytTQWV4VlptRnNWdHRWeXkreVU4V3hwSXhHb2MzcWQ0?= =?utf-8?B?NmU3czBVc2lzQmV2eVlFcStXZjM0cmFoVWRMYUtVTm9peTVWZk5NQ09ERVNv?= =?utf-8?B?K1VqWG92amduWXZxL0tqdEhYRytYMXNPTk9waWZoRTgxcWFUYlk5SG5UQmZT?= =?utf-8?B?S08xejhIUkpHWS9iMXRzK2ZZNlY5SmZ3NDkrcTV2YXhzWlpKSU00S0lvdWc4?= =?utf-8?B?c3R0TGY1aDh0cVZsUGdLMzVSd1RsckdmS3lEaEg5alJQQVc0RXZpYUFvYUFw?= =?utf-8?B?VDl2cmpTSVNzUjNkTXpYeGhJN0hNejRSdTB6RGlsUmU0S1JvQ3U2QkJCZElE?= =?utf-8?B?SzZsS0dMVjA4TGRReS8vRTlwZ0lHdlBWQVZSM292WnVheFNLTVJJSDhnc0Va?= =?utf-8?B?NEc0TE03ZW9Rd2JwblVXNkNnaU5QZHdXQTF4Yk9FYmRRRmk0Y2N2K1ZyZmRo?= =?utf-8?B?bFBkaTFxSHNiVGU0ZmJRT3hMZmxUL3E0SnhOSXdqTGJnUWtOcEJzVWU0K0hl?= =?utf-8?B?TFhTRjRKeWs5WEdqMGs3VjJicUMySXRIVmJoRm1XZEgrbVYzbzlCeXpuU0Zq?= =?utf-8?B?azk4TVZ4SW4vR0xXUlRiMjdaL0RyRjNIV0owODdoN2J4cDI1UGs1VFVyL1lF?= =?utf-8?B?YzVuNXMxUlZNT2ZZTTkzYnIxZE1yMGJ1WSt0SzM3Z1lTcnE0WEdOMnNzL05j?= =?utf-8?B?eC84eU5qcDdqVVFCR0o0bHE0ZEx4RUhzRzdOenlNMy9kTFErN1Q4ZGR5TEZw?= =?utf-8?B?ejRaclpLb0d6dW9SK3ZleE02RzludDJCRVhxTnVHMFhCSXpuQnhzV0JyVGps?= =?utf-8?B?bnQ4c09KMUhIaTFsVTE5K3NIQ21sK0Y2OS92Q2syWERWcUI2WTludFQ0b0lK?= =?utf-8?B?ODh5N2hyVjFZWXVMVjRMTXlBQmxUWlU0ZjhVK0UxY2JiMmx4Qmc3WmtIeXVT?= =?utf-8?B?V25KZUJUOWh1WFQ2TkJpRTNFWktaR2N1ZmZrQ2VHVnBEczhSYkx0VUNRbG8y?= =?utf-8?B?K1Z2cnRnZXl2WWhZaDVPNEZqZzlYaTJYNU1TWnpIQlBYZW1TSFdSb2VTZGg3?= =?utf-8?Q?psihPf49g7qE46f0JhbmxMw=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a3b9fd6-86db-40f5-2c07-08dac3c16eb6 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2022 08:47:57.9414 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G/slITA3UgDl7uI7qWgAOCg2sZDerRbrxVINNuyclf+YU8y0cLAwsug/7eENeGZN7VsqdTNK+Sv/Xt9ehHO+20I5mBSA/HmxtwsFYEopgrg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5415 DQoNCj4gT24gMTAgTm92IDIwMjIsIGF0IDE4OjI4LCBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jv a0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IEEgZGVidWcgc3RhdGVtZW50IGdvdCBpbnRyb2R1 Y2VkIGFuZCBjb2RlIG5vdCByZWluZGVudGVkDQo+IChhcyBpdCB3YXMgcGFydCBvZiBhIHNlY3Vy aXR5IGZpeCBhbmQgd2FzIHRyeWluZyB0byBhdm9pZCB0aGF0KSwNCj4gaG93ZXZlciB0aGF0IHJl c3VsdGVkIGluICpvbmx5KiB0aGUgZGVidWcgc3RhdGVtZW50IGJlaW5nIHBhcnQgb2YgdGhlICdp ZicsDQo+IGFuZCBldmVyeXRoaW5nIGVsc2Ugb3V0c2lkZSBvZiBpdC4NCj4gVGhpcyByZXN1bHRz IGluIHNvbWUgdW5uZWNlc3NhcnkgcmluZyBjaGVja3MgZm9yIGRvbWFpbnMgd2hpY2ggb3RoZXJ3 aXNlDQo+IGhhdmUgSU8gY3JlZGl0Lg0KPiANCj4gUmVtb3ZlIHRoZSBkZWJ1ZyBsaW5lLg0KPiAN Cj4gRml4ZXM6IDQyZjA1ODFhOTEgKCJ0b29scy9veGVuc3RvcmVkOiBJbXBsZW1lbnQgbGl2ZSB1 cGRhdGUgZm9yIHNvY2tldCBjb25uZWN0aW9ucyIpDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBFZHdp biBUw7Zyw7ZrIDxlZHZpbi50b3Jva0BjaXRyaXguY29tPg0KPiAtLS0NCj4gUmVhc29uIGZvciBp bmNsdXNpb24gaW4gNC4xNzoNCj4gLSBidWdmaXggZm9yIGNvbW1pdCBhbHJlYWR5IGluIG1hc3Rl cg0KDQpBY2tlZC1ieTogQ2hyaXN0aWFuIExpbmRpZyA8Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXgu Y29tPg0KDQo= From xen-devel-bounces@lists.xenproject.org Fri Nov 11 08:56:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 08:56:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442370.696475 (Exim 4.92) (envelope-from ) id 1otPpY-0002ng-8v; Fri, 11 Nov 2022 08:56:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442370.696475; Fri, 11 Nov 2022 08:56:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otPpY-0002nZ-5l; Fri, 11 Nov 2022 08:56:08 +0000 Received: by outflank-mailman (input) for mailman id 442370; Fri, 11 Nov 2022 08:56:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otPpX-0002nP-0K; Fri, 11 Nov 2022 08:56:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otPpW-0001dW-Uj; Fri, 11 Nov 2022 08:56:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otPpW-0001e2-FM; Fri, 11 Nov 2022 08:56:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otPpW-0005Mb-Eu; Fri, 11 Nov 2022 08:56:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1d0duTjC4JW2opyL++ZB8tEHKvbl5xDVnoCokQdOf5Q=; b=HIpGRPv7pVipaEx6vkegxnpkFm fB6eNSO53KvEruIPcv562t5H0X6ZGCK+WGn8oRAhPrM+pFf2mwD5hrxSWVy9jaKO+Iu7onHD96ZyZ O9gxgiwjYe5ERRrjM7vcLTO3srqhA4wchqPXMm2nO94RWKx0BgJ3XAV6q6QfqHMKsYY8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174726: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:build-arm64-xsm:xen-build:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1767a722a708f1fa3b9af39eb091d79101f8c086 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Fri, 11 Nov 2022 08:56:06 +0000 flight 174726 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174726/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 build-arm64-xsm 6 xen-build fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 1767a722a708f1fa3b9af39eb091d79101f8c086 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 34 days Failing since 173470 2022-10-08 06:21:34 Z 34 days 54 attempts Testing same since 174726 2022-11-10 21:43:04 Z 0 days 1 attempts ------------------------------------------------------------ 1607 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm fail build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 153489 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Nov 11 09:01:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 09:01:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442376.696486 (Exim 4.92) (envelope-from ) id 1otPuS-0004Ej-TA; Fri, 11 Nov 2022 09:01:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442376.696486; Fri, 11 Nov 2022 09:01:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otPuS-0004Ec-Pj; Fri, 11 Nov 2022 09:01:12 +0000 Received: by outflank-mailman (input) for mailman id 442376; Fri, 11 Nov 2022 09:01:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otPuR-0004EW-N2 for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 09:01:11 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62020435-619f-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 10:01:09 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D5A5A1F37C; Fri, 11 Nov 2022 09:01:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7813D13357; Fri, 11 Nov 2022 09:01:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uMXXG1QPbmOCUgAAMHmgww (envelope-from ); Fri, 11 Nov 2022 09:01:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62020435-619f-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1668157268; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/lspCkDNCYN0BihwrR2TfrBJPIdxMA5VNPOiPc3CMUQ=; b=P7/ZX+SygRJNACjEgHO0GZadvRJq2WHDmLHQURI5/CjQMC2TLFgvGXo4eroK/eXmzKd9Bx sxv0fHMrSq9myc7T34BODP3Ve/+kQ4BI7wAHXAp51MJX527srKG2z2mXhgN7iDyf3l9MHD W6KcowZBxFzj5scnovMv6xN3Y8P72f8= Message-ID: <2476e467-1c31-91f4-1e75-86723b8da486@suse.com> Date: Fri, 11 Nov 2022 10:01:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v4] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Content-Language: en-US To: Jan Beulich , Stefano Stabellini Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Oleksandr Tyshchenko , Maximilian Heyne , xen-devel@lists.xenproject.org, LKML References: <20220729070416.23306-1-jane.malalane@citrix.com> <1918c63f-0065-b468-3691-de6e314f4374@suse.com> <9ab99257-844b-de15-cd20-7cda61295186@suse.com> From: Juergen Gross In-Reply-To: <9ab99257-844b-de15-cd20-7cda61295186@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------C1r5uw2pnvVs2iKcq7dJOozD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------C1r5uw2pnvVs2iKcq7dJOozD Content-Type: multipart/mixed; boundary="------------DEY2bd0n5CFo0bkhFII07cP0"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , Stefano Stabellini Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Oleksandr Tyshchenko , Maximilian Heyne , xen-devel@lists.xenproject.org, LKML Message-ID: <2476e467-1c31-91f4-1e75-86723b8da486@suse.com> Subject: Re: [PATCH v4] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector References: <20220729070416.23306-1-jane.malalane@citrix.com> <1918c63f-0065-b468-3691-de6e314f4374@suse.com> <9ab99257-844b-de15-cd20-7cda61295186@suse.com> In-Reply-To: <9ab99257-844b-de15-cd20-7cda61295186@suse.com> --------------DEY2bd0n5CFo0bkhFII07cP0 Content-Type: multipart/mixed; boundary="------------tf1QLtQu4n1YEyi0ELgOlR0F" --------------tf1QLtQu4n1YEyi0ELgOlR0F Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMTEuMjIgMTc6MjYsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwMy4xMS4yMDIy IDE2OjQxLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+IE9uIDAzLjExLjIwMjIgMTQ6MzgsIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDI5LjA3LjIwMjIgMDk6MDQsIEphbmUgTWFsYWxh bmUgd3JvdGU6DQo+Pj4+IEBAIC0xMjUsNiArMTMwLDkgQEAgREVGSU5FX0lEVEVOVFJZX1NZ U1ZFQyhzeXN2ZWNfeGVuX2h2bV9jYWxsYmFjaykNCj4+Pj4gICB7DQo+Pj4+ICAgCXN0cnVj dCBwdF9yZWdzICpvbGRfcmVncyA9IHNldF9pcnFfcmVncyhyZWdzKTsNCj4+Pj4gICANCj4+ Pj4gKwlpZiAoeGVuX3BlcmNwdV91cGNhbGwpDQo+Pj4+ICsJCWFja19BUElDX2lycSgpOw0K Pj4+PiArDQo+Pj4+ICAgCWluY19pcnFfc3RhdChpcnFfaHZfY2FsbGJhY2tfY291bnQpOw0K Pj4+PiAgIA0KPj4+PiAgIAl4ZW5faHZtX2V2dGNobl9kb191cGNhbGwoKTsNCj4+Pj4gQEAg LTE2OCw2ICsxNzYsMTUgQEAgc3RhdGljIGludCB4ZW5fY3B1X3VwX3ByZXBhcmVfaHZtKHVu c2lnbmVkIGludCBjcHUpDQo+Pj4+ICAgCWlmICgheGVuX2hhdmVfdmVjdG9yX2NhbGxiYWNr KQ0KPj4+PiAgIAkJcmV0dXJuIDA7DQo+Pj4+ICAgDQo+Pj4+ICsJaWYgKHhlbl9wZXJjcHVf dXBjYWxsKSB7DQo+Pj4+ICsJCXJjID0geGVuX3NldF91cGNhbGxfdmVjdG9yKGNwdSk7DQo+ Pj4NCj4+PiAgRnJvbSBhbGwgSSBjYW4gdGVsbCBhdCBsZWFzdCBmb3IgQVBzIHRoaXMgaGFw cGVucyBiZWZvcmUgc2V0dXBfbG9jYWxfYXBpYygpLg0KPj4+IFdpdGggdGhlcmUgYmVpbmcg QVBJQyBpbnRlcmFjdGlvbiBpbiB0aGlzIG9wZXJhdGlvbiBtb2RlLCBhcyBzZWVuIGUuZy4g aW4NCj4+PiB0aGUgZWFybGllciBodW5rIGFib3ZlLCBJIHRoaW5rIHRoaXMgaXMgbG9naWNh bGx5IHdyb25nLiBBbmQgaXQgbGVhZHMgdG8NCj4+PiBhcGljX3BlbmRpbmdfaW50cl9jbGVh cigpIGlzc3VpbmcgaXRzIHdhcm5pbmc6IFRoZSB2ZWN0b3IgcmVnaXN0cmF0aW9uLCBhcw0K Pj4+IGFuIGludGVudGlvbmFsIHNpZGUgZWZmZWN0LCBtYXJrcyB0aGUgdmVjdG9yIGFzIHBl bmRpbmcuIFVubGVzcyBJUlFzIHdlcmUNCj4+PiBlbmFibGVkIGF0IGFueSBwb2ludCBiZXR3 ZWVuIHRoZSByZWdpc3RyYXRpb24gYW5kIHRoZSBjaGVjaywgdGhlcmUncw0KPj4+IHNpbXBs eSBubyB3YXkgZm9yIHRoZSBjb3JyZXNwb25kaW5nIElSUiBiaXQgdG8gYmUgZGVhbHQgd2l0 aCAoYnkNCj4+PiBwcm9wYWdhdGluZyB0byBJU1Igd2hlbiB0aGUgaW50ZXJydXB0IGlzIGRl bGl2ZXJlZCwgYW5kIHRoZW4gYmVpbmcgY2xlYXJlZA0KPj4+IGZyb20gSVNSIGJ5IEVPSSku DQo+Pg0KPj4gV2l0aCBSb2dlcidzIGhlbHAgSSBub3cgaGF2ZSBhIHBvaW50ZXIgdG8gb3Nz dGVzdCBhbHNvIGV4cG9zaW5nIHRoZSBpc3N1ZToNCj4+DQo+PiBodHRwOi8vbG9ncy50ZXN0 LWxhYi54ZW5wcm9qZWN0Lm9yZy9vc3N0ZXN0L2xvZ3MvMTc0NTkyL3Rlc3QtYW1kNjQtYW1k NjQteGwtcHZodjItaW50ZWwvaHV4ZWxyZWJlMC0tLXZhci1sb2cteGVuLWNvbnNvbGUtZ3Vl c3QtZGViaWFuLmd1ZXN0Lm9zc3Rlc3QubG9nLmd6DQo+IA0KPiBJJ3ZlIG5vdGljZWQgb25s eSBub3cgdGhhdCBteSBtYWlsIHRvIEphbmUgYm91bmNlZCwgYW5kIEknbSBub3cgdG9sZA0K PiBzaGUncyBubyBsb25nZXIgaW4gaGVyIHJvbGUgYXQgQ2l0cml4LiBTaW5jZSBJIGRvbid0 IGV4cGVjdCB0byBoYXZlIHRpbWUNCj4gdG8gaW52ZXN0aWdhdGUgYW4gYXBwcm9wcmlhdGUg c29sdXRpb24gaGVyZSwgbWF5IEkgYXNrIHdoZXRoZXIgb25lIG9mDQo+IHRoZSB0d28gb2Yg eW91IGNvdWxkIGxvb2sgaW50byB0aGlzLCBiZWluZyB0aGUgbWFpbnRhaW5lcnMgb2YgdGhp cyBjb2RlPw0KDQpJIHRoaW5rIHRoZSBjb3JyZWN0IHdheSB0byBoYW5kbGUgdGhpcyB3b3Vs ZCBiZToNCg0KLSByZW5hbWUgQ1BVSFBfQVBfQVJNX1hFTl9TVEFSVElORyB0byBDUFVIUF9B UF9YRU5fU1RBUlRJTkcNCi0gbW92ZSB0aGUgeGVuX3NldF91cGNhbGxfdmVjdG9yKCkgY2Fs bCB0byBhIG5ldyBob3RwbHVnIGNhbGxiYWNrDQogICByZWdpc3RlcmVkIGZvciBDUFVIUF9B UF9YRU5fU1RBUlRJTkcgKHRoaXMgY2FuIGJlIGRvbmUgZXZlbg0KICAgY29uZGl0aW9uYWxs eSBvbmx5IGlmIHhlbl9wZXJjcHVfdXBjYWxsIGlzIHNldCkNCg0KV3JpdGluZyBhIHBhdGNo IG5vdyAuLi4NCg0KDQpKdWVyZ2VuDQo= --------------tf1QLtQu4n1YEyi0ELgOlR0F Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------tf1QLtQu4n1YEyi0ELgOlR0F-- --------------DEY2bd0n5CFo0bkhFII07cP0-- --------------C1r5uw2pnvVs2iKcq7dJOozD Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNuD1QFAwAAAAAACgkQsN6d1ii/Ey+G PQf+LP86UAyDjkJFsH+4lklRY+EQX/COMzwb+/vd6CjA1Q4jgerLOyJxpcJ1z4R6kB+QCIfR+2ks lnZ5FYZ5XrH+GA6/IeHHk6/9EGPB10Ftk78v3seLMVjDzR4wurIfrEM4jzFQC2Jq7qUqyhApbcPM aAPJYuPlE34bSpG6R25N9Vpk2ZJls6y8hsgz84gS+U8fvO8cXCwb4kz5C8zZpOjifXsNNMFvD+zI sMlCRDkzSAFdFTOssGmuwgh93ChLKa+hunEGyX5lvX+EjORC3xGsBZmZzOS5vijjxa+u1HETVGeZ Y3O74CGsmVeMatk83oJGUVc2R5Af4af6wXh5v8c78g== =xu0e -----END PGP SIGNATURE----- --------------C1r5uw2pnvVs2iKcq7dJOozD-- From xen-devel-bounces@lists.xenproject.org Fri Nov 11 09:24:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 09:24:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442383.696497 (Exim 4.92) (envelope-from ) id 1otQGt-00074h-Md; Fri, 11 Nov 2022 09:24:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442383.696497; Fri, 11 Nov 2022 09:24:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otQGt-00074a-JU; Fri, 11 Nov 2022 09:24:23 +0000 Received: by outflank-mailman (input) for mailman id 442383; Fri, 11 Nov 2022 09:24:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otQGr-00074U-Bz for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 09:24:21 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2072.outbound.protection.outlook.com [40.107.103.72]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9ede3895-61a2-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 10:24:20 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6948.eurprd04.prod.outlook.com (2603:10a6:208:187::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.24; Fri, 11 Nov 2022 09:24:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Fri, 11 Nov 2022 09:24:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ede3895-61a2-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h5WITQSkFKKCeKRQ7+J3/lgVqz4sifvmvSgia8tAgLRbenzGWgU9RVsJgMLsBDhoo7Ah0keLgF3h9G8kCb2ddniOONFJ81QLumo4dxO0kuX61BtpFPHAS71PPEiEBPV3xHYqZVGrVRBT5DCuWczn0ndeZajkrgCwp+tquQGRyig4J6sJdsdvOQKzccpyYiJ+5dNRTEPL+N17wJG1NHhpdYTxWG2VPvDmhVDfjDeo247WvWXlDi+EYhhaOhppDbFRR+kFjwI3NdaILKGtoF7QZtdaTIDHlQuTUCoUdttv3OrTlBJMkkuZWn//2zsbGzQM+/Qtit0ow4kuHQ2x8OASgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CzH3s03D4qYTPtNr6CWCV/Oumo1cd+OBTpQQkCBljfM=; b=Jqgs74kTQMs3/WDNJpQDXIjOX6uazvDm2SznEEruhupMauQn1DJnKaS0y0h2ow/YnUUmOhFGN5fzQoxTslk2w/gYEmn5Prcd4aZUv3cRuagZ0TlVzpchDejtpZiGoNHoVeVS5R/WELWN5vwQzPeVo54VJvGdfDvr+qd7osmoGHmKXh5i42FU2IyceRBspy01F4vAVG0Pei2RaAmuy+FhH6Gr/4pBAcpN92Dea2QWi/SXcZH0mgmRU5i/j2riRymM0XkLFfnOJVwolkegQj4XsT9jXSHrz3q0oIilcNwyn24IiJ+B66SdpBDv7RkgMHBjy/kzdGWYtjE62HGcrnQv/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CzH3s03D4qYTPtNr6CWCV/Oumo1cd+OBTpQQkCBljfM=; b=jnoe2zXm6O8DfYzjwMEIaKogBHkNseoVNFDWjsdeqLdR9VFgqozCPp9ETkSTZ6T0iGILtTqFqs4UmvolJ6bs2bcAqYTMabI88cW+TVmOLTibef42pOkruSP8FM0i2q3niTWp4V6MVkduFbLHuO0VeZE+KySi3y9fRSn3iOPXrPiln4327erQIDdeZit3KRc9QjRL27asppFG36bMByW3wSoPSAiAh5grsX5xW0QGlR+tbMd90LK0d/iVHuGhetZAjOBZf1qBuqFhT+7KegbHm4w0S3203ERDbj0Ohbgu3sPHYhWByfe0zFlv2YnZh55TmYgn150cfoCN1Bdovad5Pw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <078656a9-4362-5d7a-fbd0-64c739256012@suse.com> Date: Fri, 11 Nov 2022 10:24:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 1/3] x86/msi: consistently handle BAR mapping failures in MSI-X setup Content-Language: en-US To: David Vrabel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , David Vrabel , xen-devel@lists.xenproject.org References: <20221110165935.106376-1-dvrabel@amazon.co.uk> <20221110165935.106376-2-dvrabel@amazon.co.uk> From: Jan Beulich In-Reply-To: <20221110165935.106376-2-dvrabel@amazon.co.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0095.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6948:EE_ X-MS-Office365-Filtering-Correlation-Id: cf7790bc-06ca-436f-4976-08dac3c68253 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /SA9w8yuXQBTzn5HQNd27tYMk3S3KL9nowNR4eQfkLcQboB7AY3RHHTL7zAFoh68WO5TTN+ZQVVASI+3j8dSrG1cg6ph3MeXfHJ2/z/LkOyCy1na0ox2u/YbffIW6apdW9WWeMbR49QieKatqW3jcEI6TrR2EUAn2UlaH+NhNJpBKHN0krBgP/qI8crPD664Mf/eJAo34xlazLaoqikyF+eLizYXGv++jSfz8JwFG4w+V8iFsYmglhaoZbqB67i6mvEDL2HK9311SN51pbxtTiV6abLA8p1TrCk6fjcoVR4Gx8d/U6M8z9XqgBiOglgDlJOXuqo3FivkRjG0k8iBedYRDKgFtzefPGEp2eooHEhBEcUWvrGyz9WpvWiXVZdEvLZQgwb9+XE+ok+32ueJdKxdr/YScYZNJo35uVKYbl4s4i4B5Vq9taO3PFD9kes+818ZndgugLXGFW3eBkwQkNvFlJV9TdiolvCl9Dv3aKRvWXMdq2i/gbkpLie99pd/uaqvU+rq/JPMLhPccv1D2PaxTdADLwrUu04tt1M7XAxniKRl0aTWYIFWcIIMZYJKhzdT37tgIWuUZWsCBQqGrM7j4e5bP8mmnIs1sJFFlH6zaYL1BJaWGU07gbAnJqARITFt1KhgPaRjamCMYkj3QSqK2xeFRnmBo9OuPYMNlH7R3VVLWFdyQsw5rZd5Z+fUPBOYGd7y9FwPcJ9n0jn4Zq8RbOu0uYqQBcGM+p4bZXhuhNPJsC/Wg1BnWI/aQly4T887wmiJrkynJ5mzEvdb+OmMcv5jBKTwhC1AJCQKcMM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(366004)(346002)(39860400002)(376002)(451199015)(8676002)(31696002)(66556008)(86362001)(54906003)(6916009)(6486002)(316002)(2906002)(66476007)(8936002)(4326008)(5660300002)(83380400001)(2616005)(186003)(41300700001)(38100700002)(66946007)(478600001)(53546011)(6512007)(6506007)(36756003)(31686004)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDlDbUw4ZmxFZ0RwVG5VUm5kUk5nK2RRTTlQVUJuSWIzWjVRNW9pMUo1S014?= =?utf-8?B?REZ6Nmg1ZGU5MS8vZFE2MkVzV0s0ZTk3ZTBIREtjS2QxV0hHUFdnSnhVZFRa?= =?utf-8?B?bWRoQ1NKcGRpKzN1VlQ4bkFwV0h0TFVYZU4vN2k4SjFMQUhIUVorYUd0R2Fn?= =?utf-8?B?MFQ1V2FubU5raVhVOTJuWmNLWXZ2RkZnTVMxNi9XTmFFSkpLUEZBRHJJSWJ2?= =?utf-8?B?bmdIV0gwbDFTN3R4UjE0dmZtZTJGTksvTFNLOHp1WVkxN0xrd3lZUnNSeXRl?= =?utf-8?B?elBOTDF5RDA2dTF6OWw5T2xGbGpvN0hYWHhKZjkvN0IwZll4U2c0Nm1qN3Yw?= =?utf-8?B?OE1leWZNekZkRnl6allJOGc2UHNLSG1CdlhlcHdjQ1FIUlhhNS9aamtaUG13?= =?utf-8?B?MGF3Qm9XNmJlc1IrR0Y3ZkJ1eEx3QUJFd256QnpkdGc2TXdNRitzcCtxT0Q1?= =?utf-8?B?bHBZcGgvdEFIVkdYVWpPcU5acHFEQWlTUGtVZlpSRFZPdmFBVnJhbkxsQmFH?= =?utf-8?B?Njh0UHFFdlUyUzhiUlVwejltdG85Y2lNajNmbDRQQzdUM1lhbTN2RlFoZnRl?= =?utf-8?B?c2dPaGQvREpGVXRYRDN6QWVTb1REVDVnL2NqTkpVdS9JT2hPeWJMdkw2Q0FZ?= =?utf-8?B?bnV3QkhMQk1qd1NwLytZNnlkZmZyLzdSSXBycVJsV2lLZHloWS82Qi82VllR?= =?utf-8?B?bVdGU21CMi9EMmhmVlpLc2hQZ3kwamkrZ0tuTVl0V0VOMmx1ekQwcFA4b1RI?= =?utf-8?B?cHNPOG11NTQvTGRaSERUS2k0dkVWYTBlQnZMSE54eXltakRDNE1ObG1GVm1C?= =?utf-8?B?UGx3YnV1RXlsQmhrS3Fwa3piTVJxNk1VQWZDZk96L09maE9XdHprcThUd2s5?= =?utf-8?B?U1diTmJydnRDa0dVN3pCOGluQzY4aGR4elNYK25aeDZaeVJjS3JGNTdPUzVQ?= =?utf-8?B?dm9VNFI3eVlJNXJXUHZpc0lnNkhoejBsSEZTa29yemc0Z0lDV1lYUG9FNlFQ?= =?utf-8?B?OFRKOFBFMEdHVDlYckwrS3ovWnpienZBbWRyVEFncmQvblU5TXdwN2U0S3BN?= =?utf-8?B?MUxNOUMyRGFlalVzRnBqQ0hHWi9kMStvY3ViR2Y5YTlTYmdZalNpaEtua3d0?= =?utf-8?B?ZGtsbkNrWlo5dCs1TllTbDZtZnNGMTZtVjZuV1Fkczh0TjBhcml5NytpR0lq?= =?utf-8?B?OElTRlBHdE85WHd0WmRsM2JocXZ0MjhxUG9JY2FlWHRPSUlrTDlTd2czQVAw?= =?utf-8?B?a2xtdU9EWTQzUnJZWUhyV2dEYXJMUmtmMnB6bTlvU05WTUNwR3pXS09menhS?= =?utf-8?B?VUJkazRvT0IwTHlSblJOSklSb1NnVmhJbjlvVkZqWXdxenYxTGV3QWdnMm5Z?= =?utf-8?B?WmQ5ek1BU2prT1pNVE04cVRrbGFYRlE0eDQrQzQxcUQvemUzLzQyNktVczcw?= =?utf-8?B?eEM2RGtBZGppa1lQR0tnTzdHK01vSEFXY09hMWpVYXN4KzdUT25sRmNlbXZz?= =?utf-8?B?bU5YUFhqRlhQVHlObEhBVzZCLy9jdVc4bDN0YVFPQnRITzN6cXFvN3F3UmpU?= =?utf-8?B?VHBINm1QY01pWjVEMFY3VW9lVnZvc1ZWeGM1YzYzdE1PRFo2UHEwdjNSVVRP?= =?utf-8?B?cVlDM25tU2lRU0tENjE5QUUwUFJGeVVQU0U4S3VkQ1dlVDlxVzVNdHJFbjNO?= =?utf-8?B?cWhRNHU5OVBZRnl1MjJxb0RBTTNBenRSakMvZFgrTms5VjZKRUFwM01WWHRC?= =?utf-8?B?eUZaZk1YQ0x6NVo3dTlKeXBwTWtpWnZtMUZWRVhRWVFQL1BURUhUZzdoNHM1?= =?utf-8?B?bThaS1JEczNMZ25rSWtPaUZqSzlhWCs5V29RL2NNVkpaQUZhcm1RUndxdEZv?= =?utf-8?B?TTVxUFdKR0ZTMHdlclhYSXdnd240dEoyYk43akZhSHRTckhDclN5WjNGdFB5?= =?utf-8?B?USs4SC9YalUrVmoxY0Y2ZWltNDhMSDJlZHhNK3RzNlc4SXYvTDR3Uk1QZzV4?= =?utf-8?B?WDhQS1R6ME95Unc2WHRqcmJFbXZubzh1ZXN6Ulh3NVhYMm95QW5KN0V4U0JU?= =?utf-8?B?aTBCZ016dmhOTzQ1SHE1cG1pL3hwTDByb2twZkVKdUgvdE9jaTlVVklhZkpv?= =?utf-8?Q?jcJkMPk5IDZsqRyVhlaE1SByr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf7790bc-06ca-436f-4976-08dac3c68253 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 09:24:18.5033 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 47SJ+qMeBT24kV5ThPJ8Oq1LnpWlx5emEZIEdrpg5VW6kFWO2bZMBR97ThQOTTH1MkmYSJ+aWzBRXEXK/P3r9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6948 On 10.11.2022 17:59, David Vrabel wrote: > When setting up an MSI-X vector in msix_capability_init() the error > handling after a BAR mapping failure is different depending on whether > the first page fails or a subsequent page. There's no reason to break > working vectors so consistently use the later error handling > behaviour. "zap_on_error" can only be set when there were no working vectors yet (msix->used_entries being zero), so I don't see what case this last sentence describes. In fact it was the intention with "zap_on_error" to leave previously set up vectors functional. > The zap_on_error flag was added as part of XSA-337, beb54596cfda > (x86/MSI-X: restrict reading of table/PBA bases from BARs), but > appears to be unrelated to XSA-337 and is not useful because: > > 1. table.first and pba.first are not used unless msix->used_vectors > 0. This isn't true afaics. The condition around their setting up is involving more than just ->used_vectors: if ( !msix->used_entries && (!msi || (is_hardware_domain(current->domain) && (dev->domain == current->domain || dev->domain == dom_io))) ) Hence the associated "else if( !msix->table.first )" can also be taken if msix->used_entries is zero. And in case of a failure we need to force the error return there for DomU-s, which is achieved by clearing msix->table.first on the error handling path you alter. Furthermore I'd consider it bad practice to leave stale values on record. > 2. Force disabling MSI-X in this error path is not necessary as the > per-vector mask is still still set. I agree that we might be overly strict there, but to remove that disabling you'd need to further prove that no other inconsistencies can (later) result (this being on the safe side is where the connection to the rest of the XSA-337 changes comes from, along with the desire to not leave stale values around, as per above). Plus you'd want to justify why this error path is different from others in the function where we also disable MSI-X altogether (beyond the path you modify there's exactly one error path where we don't, and I now wonder why I had done it like that). But then I may also be misunderstanding some of your intentions here. The "consistently" in the title and the associated first sentence of the description escape me for the moment: You're talking about things in terms of pages, when the handling really is in terms of entries. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 11 09:40:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 09:40:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442390.696508 (Exim 4.92) (envelope-from ) id 1otQWd-0001Km-0S; Fri, 11 Nov 2022 09:40:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442390.696508; Fri, 11 Nov 2022 09:40:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otQWc-0001Kf-TW; Fri, 11 Nov 2022 09:40:38 +0000 Received: by outflank-mailman (input) for mailman id 442390; Fri, 11 Nov 2022 09:40:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otQWb-0001KZ-QS for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 09:40:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otQWb-0002aF-D7; Fri, 11 Nov 2022 09:40:37 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1otQWb-0002s4-61; Fri, 11 Nov 2022 09:40:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=+mUlFzNxdGf+4madsJO3GIwt3c6V3D8vy0iAY4rP9qY=; b=SKwXC3DSqRfMVPZWqsINMzq9iO ftTfEDI4SdOGpJvOiNPW3jm6gWaih1gFDXgJ2FgZC4Qpou4riByL6KtOCO3mKkMcO/bvaxRbq2HR7 0dN9ucKvik3hgfTRIsNA9Q8AQYjfi8Y8x1Sox5n7k7CcyN+NrZ+iP+kd03g64sCzdKOw=; Message-ID: <23b5f80f-c99c-5993-f940-11402bb98994@xen.org> Date: Fri, 11 Nov 2022 09:40:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 07/11] xen/arm: implement FIXMAP_ADDR for MPU systems Content-Language: en-US To: Wei Chen , "xen-devel@lists.xenproject.org" Cc: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-8-wei.chen@arm.com> <88350ef8-3f52-7535-b3e0-b2a76e8bc7de@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/11/2022 07:56, Wei Chen wrote: > Hi Julien, > >> -----Original Message----- >> From: Julien Grall >> Sent: 2022年11月10日 2:30 >> To: Wei Chen ; xen-devel@lists.xenproject.org >> Cc: nd ; Stefano Stabellini ; Bertrand >> Marquis ; Volodymyr Babchuk >> >> Subject: Re: [PATCH v6 07/11] xen/arm: implement FIXMAP_ADDR for MPU >> systems >> >> >> >> On 09/11/2022 06:46, Wei Chen wrote: >>> Hi Julien, >> >> Hi Wei, >> >>> >>>> -----Original Message----- >>>> From: Julien Grall >>>> Sent: 2022年11月7日 3:45 >>>> To: Wei Chen ; xen-devel@lists.xenproject.org >>>> Cc: nd ; Stefano Stabellini ; >> Bertrand >>>> Marquis ; Volodymyr Babchuk >>>> >>>> Subject: Re: [PATCH v6 07/11] xen/arm: implement FIXMAP_ADDR for MPU >>>> systems >>>> >>>> Hi Wei, >>>> >>>> On 04/11/2022 10:07, Wei Chen wrote: >>>>> FIXMAP is a special virtual address section for Xen to map some >>>>> physical ram or device memory temporarily in initialization for >>>>> MMU systems. FIXMAP_ADDR will return a virtual address by index >>>>> for special purpose phys-to-virt mapping usage. For example, >>>>> FIXMAP_ADDR(FIXMAP_CONSOLE) for early console mapping and >>>>> FIXMAP_ADDR(FIXMAP_MISC) for copy_from_paddr. >>>> >>>> To me, we are bending quite a bit the definition of the fixmap. There >>>> are not many use of the FIXMAP within the code and I think it would >>>> simply be better to abstract the use (or removing it when possible) and >>>> avoid defining FIXMAP_ADDR() & co for MPU. >>>> >>> >>> I agree, if we don't mind to add some CONFIG_HAS_MPU in some generic >> code. >> >> FAOD, this is not what I had in mind. Instead, it was to provide helper >> which for !HAS_MPU would call fixmap and for HAS_MPU would do the work >> to map the region in the MPU. >> > > Sorry, I am still confused about this comment, did you mean we can provider > Some generic helpers like: early_map_console / eary_map_guest_memory. > For non-MPU system, we still can call fixmap in these callers, but for > MPU system, we have to map the region to MPU region? Yes. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Nov 11 09:44:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 09:44:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442394.696519 (Exim 4.92) (envelope-from ) id 1otQam-0001wn-H7; Fri, 11 Nov 2022 09:44:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442394.696519; Fri, 11 Nov 2022 09:44:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otQam-0001wg-EP; Fri, 11 Nov 2022 09:44:56 +0000 Received: by outflank-mailman (input) for mailman id 442394; Fri, 11 Nov 2022 09:44:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otQal-0001wa-Hw for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 09:44:55 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60075.outbound.protection.outlook.com [40.107.6.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7e7c31ce-61a5-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 10:44:54 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9098.eurprd04.prod.outlook.com (2603:10a6:10:2f1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 11 Nov 2022 09:44:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Fri, 11 Nov 2022 09:44:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e7c31ce-61a5-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rt4GZIwBCySAJz8mjO2Omdjn3XtZymEZ4MH6p+hgW0llAJdqsVEGPJjH0nnr8fQVPwTQGGYHQ01esqnHSV9CL0LZNaRFQWlyN4pTGCKyCEfEdeSjwpEdtubFv+hQyQSTn403lWUuF+A331QD/Umxxuv5L6ij+Lf1fp1I9kdQzDDorYacOQnR/McBTzvXxdHdY83mijsKxy8QsKx/I8p4g6o3dsRbPxUW1UNKetwK9JYUHY8YgUqmS2enBG1QZ961+rPkXzULhhLSiswrTA7gmcsnVGK7dLR8kvOqt2baui0dx9Tbsu5ho/h36qTehKGM8H9VCQljRSR12TpHOGNxLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HMdjc1Jw8nTIAr/jG5D1RVh4couVyT+4RZNHhYm/lno=; b=WBypLfs+Jwp9OIl/OYo1bmC1iWC/a5IMNjigTYvKiYpcvNwyHsG7JuMcwNLEGjHfP5hC2ibqYQYtG0UEowbWcMwnn+IpcWZQLLeEnh3IfVMENSxsSAcSMXRilwubxXIw4fZ9FwOJ0OHkq2laSMKYS2mqWA1AkpAtlOXACwpKIH5LF+cTSefORH3ooC+PooVhrI5UlzQbo/+GMW1P14GjPO1XJqrCSdIXDRSwbEmIGDB9HHO8T0rnLQoad+8Yc022sWlFRdI/iMo4kt33DuvJpA4mHx8pGyu9ra/j9SbCDPb0EIbC5Rs5+lwqeoWwl47yWnUyN4Wf0pNwkMRDLyXq6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HMdjc1Jw8nTIAr/jG5D1RVh4couVyT+4RZNHhYm/lno=; b=F3lQO7jL7yMZrgPr1vE8OIy5+D6vNadi3jhZucul7UhJKuEhxtLJLCthvm/ArbdRk5G7r2N1fKHYIOMLTeLOajTWs1gZFdNLEnABFOCXvm8J1WXB1d+xYuBD8uOfuC1c4RFcOwZkosD16fDPylntzRRaGUYhmjKT1tApgMRIzmZrSIqTnQ/s4Q1fpO5iH/h/6xCMcmbHTxUpfzkvSv+NG6eruOy2dSkGDuGSCdE00IQFwLMb8bNqIfTtaqSSUkDNBOCQ529fyCwkx2myJTbuXL4SA0DYzdUtZrvRypj+AgbFR5hgWdQMSADK9Y/aN7w0Vsy3swKrJNIS6ItwSQ86hg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <29e6e6ca-ffb8-3719-5004-0cccaeb5578b@suse.com> Date: Fri, 11 Nov 2022 10:44:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/3] x86/msi: remove return value from msi_set_mask_bit() Content-Language: en-US To: David Vrabel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , David Vrabel , xen-devel@lists.xenproject.org References: <20221110165935.106376-1-dvrabel@amazon.co.uk> <20221110165935.106376-3-dvrabel@amazon.co.uk> From: Jan Beulich In-Reply-To: <20221110165935.106376-3-dvrabel@amazon.co.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0019.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9098:EE_ X-MS-Office365-Filtering-Correlation-Id: 28e21ff9-b37f-45ce-0b80-08dac3c9614c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XPIWHNTnY6mQKlCaBEVQknDUlNNB1Qrk+thqPUCmGGtnk7dlBpDqwBL3wjrVqcm2EuwH8RTOcBcljBDzAkjGOabgy1mRGi/IMKsfetAL1kG2qAA3XGJy3NBeYEi2N9BAZMfCvpGauDRpcinrotSDxESkU3PzcaCzy6pdBp7uEXogtCNh14SLWiDmv8F78lEsMHGpSYDfSb9xZe3DQH8ThGrNxXm+s6nT0VsiKDt7H7PJFQhgAmjewgQQN76TV1TidCzwttsfankMBhTMRokVhLo7a34eVvd27MpDXzIkiu1ux0FJGv5y9u9M2SygCZgFQ/lQsSSZ4Ok5arLBKlrSWff8D1qG5Od6W/YxN8o8EtkfxMLLRyFeSdLnXxtwnk0dHvZK70Ncp4yUfpfYkx51pZG1KClXcnNxK2trtg9JI6wkfcaCIjL/mqRajheCtKhVoO4A+vhdM4BpBamXDzCWrQhcH8PlUjkfa562wNcvDD08qKGOSd+mgLlJeoz5gqBnfSYRPU//0c8sw9NjF2DSxg1r8wBangV2DvbzmFfyU5hDrpbsVI2CjSvKyhCA7OWCMj13pv5mbcxSa+4K7fGB1ejvNC6HQRavjzNVwagFFQhPheEptoXGK+cfwxR0KKmOi32p9fM07XSg3vHfIPVO138TmUnFjJ9wj0RQ6UXWnbrhxZtYAp/IXatCiAtBwzLC/job4dqpehbXZfvE7vxbIN9WqTakUXwWWpMnKV2xS2ozOU6PeTs17l0BgBhmjpZnwUgK/RtPvvZ7ocXmKmin5shu357LqqylAxf1jNnOJHs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(396003)(376002)(136003)(451199015)(6916009)(8676002)(31696002)(8936002)(5660300002)(86362001)(4326008)(41300700001)(2906002)(316002)(36756003)(66946007)(6486002)(66556008)(26005)(186003)(2616005)(83380400001)(6512007)(66476007)(53546011)(6506007)(54906003)(38100700002)(478600001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckdteUFQL2pnSmk5Si9YVzd6aVMzRjJlTlBNSHgwczB2Z2hDeVA2TXd6RlJ6?= =?utf-8?B?WlJURTRYQWhZeHhVczE0R0VUWGVrVmpONVczSDE1VEZNRHduMlRhU3AvWjcw?= =?utf-8?B?Y1FWTGdKREVBOTFGdFl0ZXNXUEgyQi9NMFBYMmFGeTVnRDU4dnMwVVVFUjN1?= =?utf-8?B?KzJOUFU1aXFTVDNXRW9xY0pzRmRsVGVUZ0FsaXdMOHArRGdZVkdGYmp5OURa?= =?utf-8?B?UHhrc3lsQmllc3ZMN0N2YnQrUlZ5VTRTVzFYMFEzOTc4anE5NnJhcW5GaDhp?= =?utf-8?B?TlBzOUpaUDZXUVQwMFRFOHk5ODE4Nzh1dzI5cjBDa2g1KzhRRjgwUDUxeTYv?= =?utf-8?B?VndKakFFaWlNMnNzS3hXM251UW5PVm5hbTE5RlNzMUlCQ1dNOGtDSkpKbDNm?= =?utf-8?B?SXZuSzl2eHJhWngzcnJEZXc3OGt5QzZ2ajh0N0FOYW4yR0NROWhva1J6Y0FX?= =?utf-8?B?aTBpSDM2M1FNd2ZCRmljWVQrNnFTMTZLcFhzT0tYOTVubmdvOEZLcEMvV1hr?= =?utf-8?B?bFNvQnZobGlZdy9UajMrNWJ3dHRQVlJuZ0E2VEtJNjVBRTVra2RDbythYWl6?= =?utf-8?B?dXdLaWFydW5RVkJOSk9YaDR2dDNKMUpreW9scEZEYTJoakd6WTN0UGJJa3pG?= =?utf-8?B?cHh3UFdYNWZtK0dmZmZsNkR0eFdDRVhpSkRkR0Z1UXAzTnFBN1doZUdRdXE1?= =?utf-8?B?WEdnenZaK3FCMU5GK2dVU3lPQ0FvcjF6VHI3UDN1clFmNUl3dGZEaXJuci9P?= =?utf-8?B?WWRlTTZBSjgwcGtDcmhSaU5idVdBelJSb01iVEJlRTJKRmhXNzJPQVNHNmIv?= =?utf-8?B?Y0Nrcng3YThqelh6dGlpMU1DcDd3THpmMjYxTm9yNC93VFBaUnRUVzVqV0hk?= =?utf-8?B?c1ovdEZwQTg4OU1kU3FLOFRtb1V6dGU3SE95N0hoWmhGQm40cHM5dERGWElQ?= =?utf-8?B?aVQrZkVqT3ZtN0hCaVRPYW1zYk8zaWM5Sm5PQXpoSklJZ1QrNXNTUXhlTFBk?= =?utf-8?B?aFlPTkRremZEbEtSVnVwWHdTbFN1cTJuRFgraENGazd0VHM5aGZFUVZaN21w?= =?utf-8?B?Wk1qbW9CejdWZGl1cXExZGFZQXZFakk0WHJ0SnNaYjRYMk1WOTRzNkg0VnJQ?= =?utf-8?B?NWpRODJqNzVaVFdqRHExb2lweGI2Y0lCV0VkQysxUmFEcDkzdGM1TDRQekVN?= =?utf-8?B?UnlEQm1kcUJITkpFRXBhZTBwaXBxMFBRa3JFQzBaWmdHTEpwOEdIdXVyR0J3?= =?utf-8?B?eEVBZWN4bHZoQXhLdFgwamp2VVcwVFhjbDhPajA3YnZ3T3VhVXQxbit6MjB2?= =?utf-8?B?ZXdJK3FXc2ZMSE5Ob3hBV2FGWWo0RnhhK3QveFo3TkhUZm43ak5PTTZYTG96?= =?utf-8?B?ZEkyaWpuYlJXRTRtYXFRRjdCL2NDeko0V3JaaW9mOXAxdFJCS2xoUXpzYmRk?= =?utf-8?B?SmhVMUR4TGpDS21Oc00xVVZkWTRDbHNVUG1seGg4RFJOZmNDMml2RlhsdkIy?= =?utf-8?B?NHE4VTMxSXVqZ0ZMVTduc0dXZ3J4QXNVaUZRSjR1NWl4M0FmRHBwZEw3TDRG?= =?utf-8?B?bG5kM0l4VGpyUFIxc1BRYkZyM3gvZ1JLZWJUanQwRENLbXBudlhRSVFoSDFl?= =?utf-8?B?Q0l1NFZSNmFKTGo3Q1hCOVZSTXQzcTdPM3h5anlueW54L0Ivd2psV0gwcjhW?= =?utf-8?B?OWR4b2VURUNOdlZJVE5UMzQrd0xQcEV4dXh6K0Jrc3ZNUU1VdUtzN20reXFO?= =?utf-8?B?aW5yOFpVZHArSmF6c2pZdXgvc3Q4Z1ZGSTBVTVhFaHlhZUxIdGdBWXI4MVpy?= =?utf-8?B?Q3pxTzZRclNLS2IvZEsyRmsxU3ZtQzMzZHljRFFMRmFTQ1h2RDRybjd6bHBl?= =?utf-8?B?d0VYMVRHTHBRenQwT09KdEZ0NzU0WFNLd3JtR25BQkJITDY3cEVJNDd4N0ds?= =?utf-8?B?MlF5WU9aWGdKaUx2WlVKNG56R2dVZXN5YS94R3daMUZ4bHM3S2FkTjJNb1pC?= =?utf-8?B?ZU9YU2ZrSUxZSjdvNS9acCtCc1RHWFdxSElVUExyVjVxVUxVNUthOXduL0xO?= =?utf-8?B?Wk5QSGNYdjdDMG5GckZENFMwM1lVelplOVk0STBoazV5VDVFZ2ZmYWR1WGZZ?= =?utf-8?Q?kbsgD1iNqjKI7kaAC2jNfDnWC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28e21ff9-b37f-45ce-0b80-08dac3c9614c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 09:44:51.5656 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pFvMDHpxwpGHUkOiSnFz6el7VGanTFHY41+l+dOVMDUD1EA2kgP3NBclsthAXIDu3SjgRNe0a6ow6Y3uRLMGXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9098 On 10.11.2022 17:59, David Vrabel wrote: > The return value was only used for WARN()s or BUG()s so it has no > functional purpose. Simplify the code by removing it. > > The meaning of the return value and the purpose of the various WARNs() > and BUGs() is rather unclear. The only failure path (where an MSI-X > vector needs to be masked but the MSI-X table is not accessible) has a > useful warning message. No, you're removing an important 2nd such path - the default case in the switch() statement. Getting there would mean another bug elsewhere, which we don't want to leave undetected for yet longer (and hence yet harder to debug once finally some misbehavior surfaces). That default case may warrant the addition of ASSERT_UNREACHABLE() according to the respective description in ./CODING_STYLE, but I don't see the removal of the "return" as acceptable (also for another reason as explained below). The idea of the WARN() / BUG_ON() is to - not leave failed unmasking unrecorded, - not continue after failure to mask an entry. This combines with the functions where the constructs are not having ways to properly propagate the errors to their callers. > @@ -361,11 +361,6 @@ static bool msi_set_mask_bit(struct irq_desc *desc, bool host, bool guest) > > if ( likely(control & PCI_MSIX_FLAGS_ENABLE) ) > break; > - > - entry->msi_attrib.host_masked = host; > - entry->msi_attrib.guest_masked = guest; > - > - flag = true; > } > else if ( flag && !(control & PCI_MSIX_FLAGS_MASKALL) ) > { > @@ -385,14 +380,10 @@ static bool msi_set_mask_bit(struct irq_desc *desc, bool host, bool guest) > control |= PCI_MSIX_FLAGS_MASKALL; > pci_conf_write16(pdev->sbdf, > msix_control_reg(entry->msi_attrib.pos), control); > - return flag; Both this and ... > - default: > - return 0; ... this have previously prevented to make it ... > + break; > } > entry->msi_attrib.host_masked = host; > entry->msi_attrib.guest_masked = guest; ... here. This is a change in behavior which is neither obviously benign nor properly justified in the description, yet clearly going beyond what the title says the patch is about. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 11 10:09:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 10:09:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442400.696530 (Exim 4.92) (envelope-from ) id 1otQye-00050w-G8; Fri, 11 Nov 2022 10:09:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442400.696530; Fri, 11 Nov 2022 10:09:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otQye-00050p-DT; Fri, 11 Nov 2022 10:09:36 +0000 Received: by outflank-mailman (input) for mailman id 442400; Fri, 11 Nov 2022 10:09:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otQyd-00050f-9N; Fri, 11 Nov 2022 10:09:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otQyd-0003Hz-5j; Fri, 11 Nov 2022 10:09:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otQyc-0005kg-Lg; Fri, 11 Nov 2022 10:09:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otQyc-0001QP-L7; Fri, 11 Nov 2022 10:09:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4gXaMUEfWUteq6u/m5e7yljKcgHu5xdWncfGGT0sv1A=; b=Ru3N0Fsd1GOLlWIDLRTXWkI8Is ixwFEciNaal3nuqPwRRQIa24jODG9bqWevwFewva9N7aru5nXpcuu/BMwWH2kqSYevTw6MEqsmdyC AldCYZZNtfJ/cirkyjG0s4Vd5SHFWPVSVjuh6pMOB7f8MY6VWvGNcFjWfb1qz47qBIRQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174734: all pass - PUSHED X-Osstest-Versions-This: ovmf=6d55ad9a592ba3bbc9392a67fd8c936279b73a45 X-Osstest-Versions-That: ovmf=c8fb7240469b5753773da4fa5710b870b790c363 From: osstest service owner Date: Fri, 11 Nov 2022 10:09:34 +0000 flight 174734 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174734/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6d55ad9a592ba3bbc9392a67fd8c936279b73a45 baseline version: ovmf c8fb7240469b5753773da4fa5710b870b790c363 Last test of basis 174730 2022-11-11 03:48:41 Z 0 days Testing same since 174734 2022-11-11 06:10:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Kuo, Ted Leif Lindholm Michael D Kinney Ted Kuo jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git c8fb724046..6d55ad9a59 6d55ad9a592ba3bbc9392a67fd8c936279b73a45 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Nov 11 10:12:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 10:12:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442406.696541 (Exim 4.92) (envelope-from ) id 1otR10-0006Rt-1s; Fri, 11 Nov 2022 10:12:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442406.696541; Fri, 11 Nov 2022 10:12:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otR0z-0006Rm-UV; Fri, 11 Nov 2022 10:12:01 +0000 Received: by outflank-mailman (input) for mailman id 442406; Fri, 11 Nov 2022 10:12:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otR0y-0006Rg-Gr for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 10:12:00 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2045.outbound.protection.outlook.com [40.107.105.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 471c8ea0-61a9-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 11:11:59 +0100 (CET) Received: from DB9PR05CA0008.eurprd05.prod.outlook.com (2603:10a6:10:1da::13) by DB4PR08MB8173.eurprd08.prod.outlook.com (2603:10a6:10:383::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Fri, 11 Nov 2022 10:11:49 +0000 Received: from DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1da:cafe::3) by DB9PR05CA0008.outlook.office365.com (2603:10a6:10:1da::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 10:11:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT038.mail.protection.outlook.com (100.127.143.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 10:11:48 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Fri, 11 Nov 2022 10:11:48 +0000 Received: from 6638fae2ef66.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7BD403B0-A39F-47FA-8146-B9C8E88953A4.1; Fri, 11 Nov 2022 10:11:42 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6638fae2ef66.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 10:11:42 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB8386.eurprd08.prod.outlook.com (2603:10a6:10:3d9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 10:11:40 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Fri, 11 Nov 2022 10:11:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 471c8ea0-61a9-11ed-91b6-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Bh0mxMs/bOoF/UIaI/o4EwQDoNUpRcVG6JBdahEsrlqr3wTshpT6l4duFS3DckZgi0wDOZStmtdZLjijAQW3zRdTVHgYECn5TwAKxYZhl5VQr0rvsw3KuLR6135w6ltHJbSKb4lKpHsohrpenQD6+0euvgLpaxBtsZX0VWSbbODGO4lT6wkYCeY7Y0tDK3+0mL0G774b8Psf1AI6jfpH3FyPfkcUG/pBw16DyMfIbAQWSeeYxL95s7gRCinPjeWysjZo6Gw+LtxuDa/71tk73V84ne+0SztlicwPcYjCJXPoCwdiZBcEbydSDHPdHM0QtJ2c2cW8S/Ia6f/UZDWjhw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=htO6k5tkRGlYJygU8RCCLu2Lydw8uEvKCH62asuzYpM=; b=b85f4QFdov3mXXimbAUUgmUFbraE24/68hfISONHL5KNkLK760CDZgZtAF6nTKNGpZ0uot/fuir6MwCzX7Y+S4CTgoyNnppRbbKeUTUT0qPAvpKhWiF8FXcn8tt3ZPvcUoNEt9zQnT+PV/NE13Uzo9YCqHsG/RiXryzyUCAUb98gLhep1pzrcDuvIKHmARis9uXoUrqV4UbvI/PgtpnvoeysYDX9yK1NyvThdKL81gDIyHoqW9wpWvyVCtd7Tbq+pMtKk9oHRvGPsqkNBqSHuynrJb1YfUt6uwUviGknspQe0wuz7SHHw+zWFTZ01VO/T4xCW/vgp7OcVCqYcX3jmw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=htO6k5tkRGlYJygU8RCCLu2Lydw8uEvKCH62asuzYpM=; b=writGn/oLJWj++88QuLRzn4cquokHAqmtC2hXAYFcs3lLFFLSHD335hqPtZB9Ikls9t3paHR0v9bCLdc7Nnr08KDZHKMW2rHoDho7Tx3b0l12aBYu0uKiSTvkuKcDKqJlGuXPVIYUAZdBo8TK1X3QJWggN2KLNs0eW80dWAv2eo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MrkeOGYzDFJ82QcMrQ2e+KqyBs62/ysE8jSQUx643nSduTW0SIC0tvdFHbWkeh4fwYr0lajnIOFA7dxFtLzwflDuMDW4u5OtWWCvR196gST8Y4RlztwCM+Z18625Yr2kjW4Okq/4TS46f0dfQY1PvOtEz15ZlKsHE9uu0eKjKawsu7mlq1H9PgFCym9hJ4hQn8SX97jUIu6RBsqyByQQ79hIo5ANl/P6tMCq1nLV0O9LOek4SjHw+ttwIUROO2Rcjyi9fAszlVxSPmJAyzPUMa4Nr/aoFMJMLs23Lw9EOSoS5z6w9O/zuI38OSosVrkVKFKPgdXDyus92bLdnC3fWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=htO6k5tkRGlYJygU8RCCLu2Lydw8uEvKCH62asuzYpM=; b=iuPUEQSNFOp795LXvR37BB2ZgrvZLMcKMTFQxNrdH2Vzuyg/11JUsnZTD1Ymd/APrSxK+m5GUBAUIlDymVDI/JVYm08F7Ta0sYJmqJhCwPgH+V1mD2OYaOYs9GczTDU25COwJwNlLIVhKTKPa1+92ALmNBbtBvaMEmteR8XUEFNl59hYIaUUyKeZIMQIoGEEZiYi8nqVj1Tw4xJqX0ixrot0+KS+d5HhEfD+mu5aswAG+Eal1eionnNMM5ykSLdRvQCc2KhkrnwGdwQUMMGg32CKIUs2ae7313xK1WaSSIvX0T3XwsMjdKfUtiwe1kzMs6Z4WN9gnfHVSMFpzT57WA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=htO6k5tkRGlYJygU8RCCLu2Lydw8uEvKCH62asuzYpM=; b=writGn/oLJWj++88QuLRzn4cquokHAqmtC2hXAYFcs3lLFFLSHD335hqPtZB9Ikls9t3paHR0v9bCLdc7Nnr08KDZHKMW2rHoDho7Tx3b0l12aBYu0uKiSTvkuKcDKqJlGuXPVIYUAZdBo8TK1X3QJWggN2KLNs0eW80dWAv2eo= From: Henry Wang To: Andrew Cooper , Xen-devel , Julien Grall , Stefano Stabellini , Bertrand Marquis CC: Xen Security Team , Jan Beulich , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , Volodymyr Babchuk , Anthony PERARD Subject: RE: [PATCH 4/4] xen/arm: Correct the p2m pool size calculations Thread-Topic: [PATCH 4/4] xen/arm: Correct the p2m pool size calculations Thread-Index: AQHY6SStZDoQezt9v0CQXVr6uHbE2645mSbA Date: Fri, 11 Nov 2022 10:11:39 +0000 Message-ID: References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-5-andrew.cooper3@citrix.com> In-Reply-To: <20221026102018.4144-5-andrew.cooper3@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C7F6F5BFF6475346A872C647395091CE.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB9PR08MB8386:EE_|DBAEUR03FT038:EE_|DB4PR08MB8173:EE_ X-MS-Office365-Filtering-Correlation-Id: 90a048a3-70cd-4ca7-98cd-08dac3cd254a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8sehzj2l716Vo8Ty8NaMLpqQfxT4sxIhx3s7GBZq1IOjekR/8C4X+UmQMnmsOYVQB/NcDXJ/viB7WNI5PnLBMHta48BYe70atyGB97FJfTz9Q0pZLbMvgX8GnvLEa1qFiem4MuoZUVjgYumeSAGbKF5THM6UDO3sWop/KlBCOjr92a07N+yvfNvq5AEM6PCpg1E3hQiiaiTeNP8UFQvFp82fMNj1MT98ycb+LypsGCt8pMO54qXslTINQAXiV11cxB1t500cX3G4Ec+yldfqKzOARuiXmwS6/0DHnhc68sQGl1Qt7L3w0tGG5jwo1unuHmLWlRU32Ix1i23/C/eVKFAIh3Ho5RZ3YwhBE3xF+6o0N5BTvSdZcNQDmPqKggG7pAYZaHTj7MZkT0Z3un4XzgBRbioZFe7oNQxkF7EsRKJAdfS7KDijPe3GdaZ1ezfnvIq739MPn6Z2zphwY7a30kP2Tv5S9WduAh/9LPuH2XbujBZsQ6nUmfkoJP+TwNEZAIh5pyQ4ESO/rrW7JSt6kpzUt/uWnZHK53iJWJXepaO4SlqXd3sqJXRJVFZtwK2E/80Eqq6q4F3hAJMHnVo+Qe0nwQxGZ8wFWdKPPiy4aC0L5MH1PLGBI8v3FY+Ly6U+/hqyc85V33whshu9E/A7PSfLWWnJoMiObG8Np6FU2rWBf2fLYy68WXACYgi11mN3ekWCB1VMuMsIQDHfjxnWOJTjzzUUthnKu2RlQhvgFdshdRulzXc52UINL9fyVhPCgCdEeqJdWRCv4ozld+kZgg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(451199015)(110136005)(54906003)(316002)(71200400001)(6636002)(2906002)(52536014)(4744005)(5660300002)(7416002)(86362001)(66476007)(64756008)(4326008)(76116006)(41300700001)(8936002)(8676002)(66556008)(66946007)(66446008)(83380400001)(122000001)(38070700005)(38100700002)(6506007)(55016003)(7696005)(33656002)(26005)(186003)(9686003)(478600001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8386 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9f145550-0eb1-449e-b0e9-08dac3cd2000 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zEApmmjQlFBuoGpaafyH34EVqMjCdD9Tl3d3vGnisuII07G+v/2nOcBiScT9oz6qXFSd0LufPjg9HBYdZ0leD+hFjMS8IZZ1SGPAix+GYVAbbaOx3nSPgypqsURcjfyMDBbRzztiqHFuOa1Nqwb2+mZ8+YE+u+Xqmhi2IAnnuPyPbwj6p9GeBl+FLTXVLgyj7PoNg6A5pmbgQQTgkS+zfCvuwpxPJGG6CJOVbUwCosPSMCDRFxTHdhIaRwA/LUP2VXbPmQWP3BT9FR/AdDUbfh48csz/2g5e8byLnT/Ee4VOE1nSHXb5bldSzk1D2O+0XX0YmzlBbBTbtf08XM3hUKBrwiUk/C/u73Ughb6KjXVaDyLAvXuRIYyzwrwkQS6MJkkNu0Q+q/frzGM1TzpzDcdumi9xIQKviCFmqEPqrzDLf9wGjoPdaiEDXVKHLAhvfXAZHAbqUmzA53Wf88JIJ0AkzCaYrszxwM8D+oolsMGRrhKqEvTW8Z2at0zR/V8Gs5+I5pdzwCbBMyABas80Y6st13klm0Y90ocjBNmXUDFQbdcAiuSoOi7LUXazgWwIeUtU0Ys9uLUhhM60qmUbjrFKvKTTuHokjD75/6QidCaW+bcGBuRamZ3Y/960OiDKe21q13OG2xgtdpCH3hXbChJJRNBkF1qFhPENlhs8JlM32HVDuMnHipe01ZX3sguEJSboOGlKHoBn8dxQl2vVylTErcNJTGG72iJQnYnAJvHNi5CW9lzFP9ob5GlzHIFO/bE5hC6tOTLT46Cy0VXZEQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199015)(40470700004)(36840700001)(46966006)(83380400001)(41300700001)(33656002)(86362001)(8676002)(7696005)(6506007)(82740400003)(2906002)(8936002)(356005)(40460700003)(55016003)(4326008)(36860700001)(5660300002)(82310400005)(52536014)(47076005)(336012)(81166007)(4744005)(107886003)(26005)(316002)(40480700001)(186003)(478600001)(110136005)(6636002)(9686003)(70206006)(54906003)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 10:11:48.7548 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90a048a3-70cd-4ca7-98cd-08dac3cd254a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8173 SGkgQW5kcmV3LA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFtQ QVRDSCA0LzRdIHhlbi9hcm06IENvcnJlY3QgdGhlIHAybSBwb29sIHNpemUgY2FsY3VsYXRpb25z DQo+IA0KPiBBbGxvY2F0aW5nIG9yIGZyZWVpbmcgcDJtIHBhZ2VzIGRvZXNuJ3QgYWx0ZXIgdGhl IHNpemUgb2YgdGhlIG1lbXBvb2w7IG9ubHkNCj4gdGhlIHNwbGl0IGJldHdlZW4gZnJlZSBhbmQg dXNlZCBwYWdlcy4NCj4gDQo+IFJpZ2h0IG5vdywgdGhlIGh5cGVyY2FsbHMgb3BlcmF0ZSBvbiB0 aGUgZnJlZSBzdWJzZXQgb2YgdGhlIHBvb2wsIG1lYW5pbmcNCj4gdGhhdA0KPiBYRU5fRE9NQ1RM X2dldF9wMm1fbWVtcG9vbF9zaXplIHZhcmllcyB3aXRoIHRpbWUgYXMgdGhlIGd1ZXN0IHNodWZm bGVzDQo+IGl0cw0KPiBwaHlzbWFwLCBhbmQgWEVOX0RPTUNUTF9zZXRfcDJtX21lbXBvb2xfc2l6 ZSBpZ25vcmVzIHRoZSB1c2VkDQo+IHN1YnNldCBvZiB0aGUNCj4gcG9vbCBhbmQgbGV0cyB0aGUg Z3Vlc3QgZ3JvdyB1bmJvdW5kZWQuDQo+IA0KPiBUaGlzIGZpeGVzIHRlc3QtcDJtLXBvb2wgb24g QVJNIHNvIHRoYXQgdGhlIGJlaGF2aW91ciBtYXRjaGVzIHg4Ni4NCj4gDQo+IFRoaXMgaXMgcGFy dCBvZiBYU0EtNDA5IC8gQ1ZFLTIwMjItMzM3NDcuDQo+IA0KPiBGaXhlczogY2JlYTVhMTE0OWNh ICgieGVuL2FybTogQWxsb2NhdGUgYW5kIGZyZWUgUDJNIHBhZ2VzIGZyb20gdGhlIFAyTQ0KPiBw b29sIikNCj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0 cml4LmNvbT4NCg0KUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0u Y29tPg0KDQpIaSBBcm0gbWFpbnRhaW5lcnMsIG1heSBJIGFzayBmb3IgYSByZXZpZXdlZC1ieS9h Y2sgZnJvbSB5b3UgZm9yIHRoZQ0KY29ycmVjdG5lc3Mgb2YgdGhlIGNvZGUgaW4gdGhlIHJlbGVh c2U/IFRoYW5rIHlvdSB2ZXJ5IG11Y2ghDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQo= From xen-devel-bounces@lists.xenproject.org Fri Nov 11 10:13:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 10:13:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442409.696552 (Exim 4.92) (envelope-from ) id 1otR2j-000719-EB; Fri, 11 Nov 2022 10:13:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442409.696552; Fri, 11 Nov 2022 10:13:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otR2j-000712-Aj; Fri, 11 Nov 2022 10:13:49 +0000 Received: by outflank-mailman (input) for mailman id 442409; Fri, 11 Nov 2022 10:13:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otR2h-00070t-Kq for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 10:13:47 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80040.outbound.protection.outlook.com [40.107.8.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 86b96ee4-61a9-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 11:13:46 +0100 (CET) Received: from FR3P281CA0108.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::11) by DU0PR08MB7740.eurprd08.prod.outlook.com (2603:10a6:10:3bc::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 10:13:43 +0000 Received: from VI1EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a3:cafe::7) by FR3P281CA0108.outlook.office365.com (2603:10a6:d10:a3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Fri, 11 Nov 2022 10:13:43 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT016.mail.protection.outlook.com (100.127.144.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 10:13:42 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Fri, 11 Nov 2022 10:13:42 +0000 Received: from 5417698481b3.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3CA2C238-E79B-4AAF-97C8-091D6E9F04F5.1; Fri, 11 Nov 2022 10:13:36 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5417698481b3.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 10:13:36 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM7PR08MB5317.eurprd08.prod.outlook.com (2603:10a6:20b:101::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 10:13:35 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 10:13:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86b96ee4-61a9-11ed-91b6-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=KJD2ychhI913e0Y3e3bDp3TmZENAb7zkUWzBjTy/uvMBIHJI5v+rIpmC6h6W0z7K6smlP3qoe0NoYmkc/elpidhUE7oo/fHuQatfGea0KbSzJHh64KJIqy1gfARdtbFgeUvgc1P4CxBcEsV+U96SLN/D/NBXxDzsiJQakrMe43qL9rjhsunI1oEkDU8M+444zQ5f1a5UCkOHyJi7BKMWS7U8xYrm1h0TQnGnQ7wq19IN9XgQvxXhUN4kPQKHmUYzz2O7N9I2mmM6I4R51vYc1K2nZ7+SGwgFqAGHiFCK1dRpEzoKkcHjwi7mFHeKDGbKdtO2opbdN0Y2ljErhNQvew== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uBH9rh7P9eM9JZEnhJuEPOHZEq+2CEa1iYUBDb3Vjuo=; b=FUrpU/U5X1MgyTEDsnBR/5dILVbIEgoxx0xkc1wlbqSkP9YZi2C/tEVx0sLuBBDz6nDxlGXnVGBZb0FfbrwUV6dd641es5L6AHb/Rn0ck5e6/9WaLFpq2IE9X2VZmaxzw9SYS1eorS8jWhH3k+1ZHgkn3C7lsf5mHI9am5sEtREBXghxf9LdkrYqfZgR/ShiLeMFGn69F53/GIzBiKWGUPw34iW3yMR7xZfvbIYxFu0v1ce4ctJ9hkBd28S2fOwuVwoV9S6AZ3aiccC/vK8iqxZFjkMl3NmsLs1wIkrj31N2ffy077UGrYkLROaej6XsV+lUDCcQfWXZyLR3nt72XA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uBH9rh7P9eM9JZEnhJuEPOHZEq+2CEa1iYUBDb3Vjuo=; b=QBA7kFjy3HYXCTDiJtbUdSd+T1ouTY0BpxQhKsQy5XVbXwgHiVXv+IrX6BFGDnpvZGwd7F+RfmnumLhUPPAorVncbfXzUGJqDDCH+qYYMqusXd3k7GaqTwGcAjjimATxqtR6nfSy3CWVRQaH0A1ONL682zWF+ueg//4vFWB+rGI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G8gNETefFrMXC35elVBSb46YtgXX/KQU535bsFgZQCoAi+opiyUrhU5Osfcz7tkf9PKYQbhcfqytdnev7CamplpNFEFqG6np2N0hJBIT/GM27LYGPOQRqRcgCy1zibJFy15PBJEftNWuw8PBiE93PX/lZCtIEkbZF5IBNudHN1UapwBYNJxsDJ6oi//5bc2HS/IWZIfSMqnvWDPXMdRr2FNRiD+qXwlPSYck+Auuaoi8WLhh6wfJeRDWz0zUtt9RqkXijbBFtf3b91So4X9cBT4ZYKYybCINgh/V9AAi9B7YHIssFvDOlIJN+JReWE08mJ2RWebpAwTaqRxCSjHhaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uBH9rh7P9eM9JZEnhJuEPOHZEq+2CEa1iYUBDb3Vjuo=; b=B/MjBlI1EQsPa2gW6uBC93bNmej/ijHR9+tgeCnRNO9CkKyk+Io6jO9Qr8egY17FjdjeA/36lfqw2ZvzuXfYyo7z7cxEqMENPSestbgu6MBKIhIu01ZilCVJVuIqRSdELnzcAPvmmfjOGRTc0S6p8KqvXWJCY2F+lwKjz3w1FcHzKE2ganqkajXBTV+V1GmztfXPTxkgpkPSGO0q0CWxOY5wEAubCoO3RUUBND5xUCIvFwJnJohZ5k5OPKpsGPN0MUJFCZH4HBN6VoTsLkTgGPkXPjQRq+j5SbiO8iAdGwR8KbdQn510bCh04Lsq5pnp8hgMrhKNLPd6u8ZZKJq8Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uBH9rh7P9eM9JZEnhJuEPOHZEq+2CEa1iYUBDb3Vjuo=; b=QBA7kFjy3HYXCTDiJtbUdSd+T1ouTY0BpxQhKsQy5XVbXwgHiVXv+IrX6BFGDnpvZGwd7F+RfmnumLhUPPAorVncbfXzUGJqDDCH+qYYMqusXd3k7GaqTwGcAjjimATxqtR6nfSy3CWVRQaH0A1ONL682zWF+ueg//4vFWB+rGI= From: Wei Chen To: Stefano Stabellini , Julien Grall CC: "xen-devel@lists.xenproject.org" , nd , Bertrand Marquis , Volodymyr Babchuk , Jiamei Xie Subject: RE: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform Thread-Topic: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform Thread-Index: AQHY8DVkWYjGQuvcKkq0uEcag43TF64ySPmAgAO1+zCAAPGnAIAB0gYAgAC9l7A= Date: Fri, 11 Nov 2022 10:13:34 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-6-wei.chen@arm.com> <0ffe8a4d-7caf-89af-d189-a872b6b4f0fa@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 572198DB5C01B24EB0BC00FE0235931E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|AM7PR08MB5317:EE_|VI1EUR03FT016:EE_|DU0PR08MB7740:EE_ X-MS-Office365-Filtering-Correlation-Id: f538b5eb-5cc2-4ec9-d79f-08dac3cd6976 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hs8om6YC8Yj7FYRtlV7Wq7pJcC3bVM4XoSlxpED9ObxzUKMxGDYrA3z8e6IHHdeph0IS1y9Uc1lK/Rmk69iWSp+4HbaxJlPhLtPreMWk1DaIH02JgnGV30onaS4cSnQUnzXrwJi2OluMBMTRuGTUVmtHTTxYUUWtoLwSrncxGJC2slLpEPr4duzymSc65wX39Jw0M4xfp2RN7KaEzjuhR/3GP5YF+yDzR3zO3I39OK2bcnlpiGSQheyRQ8ntaFpCkI6oqUNtrkCMNSKIWMiAzV6G6WPMebw/3GZDknsOrPwgfSX55cPRdaxonK9POue44ePUPVd2szX+2mM32KaQLi0D7uZz9DRpLw5PwvAOjLmlfcc395dqteHErrIzjuVVygRaMkt5U2NWho8rKTO4vw6ozjQpc8owyGtFdRLVCVYWJn7WQwJj7J/QtCeXRP47edzxIMLgZ47gDviU5Rgv+k+QBLK94oCymcDdUgIBF+6DPU9vZYpgrkE3VXEdQksnit2i9fpWNPbqHTpImC99Ypxe0W5UQFXvSc/EtfrNaXZHJ5KF2x5AXaxfnwuj7h9+xrLwBpojAu2Io1SZfU+/UJEoVoTxpJ+KQNW2fPI+Zh6p0bCzXjldCInY5Ik11XBwO0Hsk0qjddAYUX1A9jwLi49wQuwzZHWYJZDc+Uo303m8ugqNtI133OielwLWGaTVWyFaiTl5ER3eTuLYqY68xz/9Y9p/R9CfU9/b6mLZ2kAW2cRKSh1M8y/vfcRuPX/njE4AoAKbQK2NP/SjwBAiLQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(346002)(39860400002)(366004)(451199015)(38070700005)(316002)(478600001)(33656002)(9686003)(86362001)(2906002)(122000001)(41300700001)(186003)(53546011)(52536014)(5660300002)(66476007)(76116006)(71200400001)(6506007)(54906003)(66946007)(7696005)(66446008)(64756008)(38100700002)(26005)(66556008)(83380400001)(55016003)(8936002)(110136005)(4326008)(8676002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5317 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1eab6355-bc69-4467-8b0e-08dac3cd6498 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pglp98k9ybZTgmyvmQS0fv1e4ZmiuE6nNvpUwPHCJ7zgiLWT+WXSr3k7ou8Pp0oGvLIf6xytSYv7ceNgJGuOLzPy8Aj4NPQp9PpCgKVZ6FaAzejdiOI/P0AlGqUbGCFLeF4ATI348z00GwiIgyxi6d+NbtAwXMo5w8cUJUZVoYANEGRG94YZzIyzsMY9cGGRJC7jpCkxVwE2SvDbmQPyrLI7PhQ7/X4MQVkfUJpYQCSlUlQyNODW7Wi37cx6rPVNbDHbkF3S4uR95kT+vch5r8TSukvv1vinwuhxa5CGKiQjwtXsGFXjTKiS7wyUHaiUCHfjwgLmqd7Ce0t627ybidjHyP05pnSBXrG6TCBXBl5W7vlTuTkyfN2bDNmppD5kSQhOhAId6ZTm4d9KzD2cE6SVmC/1dJC34uLV84Fg5I1JtR5vZaPXtvRExHoSBdSJm7qmd5YU5q08BODjkIrv7zhilj6fWmqVJhYyhKsETjPOM/rR4UCV9VlfhAS9BfvMiZOQfcr41YVJX2/pfKmqAXzYouIsPIDilksehAgfuxcIbmVqA7v6L6jw+SJ9bWYwBF+u/paINYxsQBSUYMdmDDvfU/H/ZsNAwQ9qOWTFjUfER8nfAqLZlr/6n4cCSCVwyecUMZklMuFyfzLES926ErFbp141P1EjIxuVkd4tLzN5t27SFMeI12NlcvART1loi/Kh9FjhY4RDsay6XYUx/o453B2cJegy4DQJgocDJB8KElVGL+puanCsB1jvXuE3GtNoXqR3Mz7Sr209bjGWPA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(136003)(396003)(451199015)(36840700001)(46966006)(40470700004)(82740400003)(2906002)(40460700003)(81166007)(33656002)(356005)(6506007)(7696005)(70206006)(4326008)(82310400005)(86362001)(41300700001)(47076005)(336012)(8936002)(186003)(36860700001)(83380400001)(53546011)(5660300002)(54906003)(52536014)(70586007)(316002)(478600001)(9686003)(8676002)(110136005)(26005)(40480700001)(55016003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 10:13:42.9892 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f538b5eb-5cc2-4ec9-d79f-08dac3cd6976 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7740 SGkgU3RlZmFubywgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZy b206IFhlbi1kZXZlbCA8eGVuLWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9u IEJlaGFsZiBPZg0KPiBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gU2VudDogMjAyMuW5tDEx5pyIMTHm l6UgNjoxMw0KPiBUbzogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gQ2M6IFdlaSBD aGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBu ZA0KPiA8bmRAYXJtLmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVs Lm9yZz47IEJlcnRyYW5kDQo+IE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZv bG9keW15ciBCYWJjaHVrDQo+IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT47IEppYW1laSBY aWUgPEppYW1laS5YaWVAYXJtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2NiAwNS8xMV0g eGVuL2FybTogZGVmaW5lIFhlbiBzdGFydCBhZGRyZXNzIGZvciBGVlANCj4gQmFzZVIgcGxhdGZv cm0NCj4gDQo+IE9uIFdlZCwgOSBOb3YgMjAyMiwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiA+ID4g PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gPiBGcm9tOiBKdWxpZW4gR3JhbGwg PGp1bGllbkB4ZW4ub3JnPg0KPiA+ID4gPiBTZW50OiAyMDIy5bm0MTHmnIg35pelIDM6MjANCj4g PiA+ID4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgeGVuLWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnDQo+ID4gPiA+IENjOiBuZCA8bmRAYXJtLmNvbT47IFN0ZWZhbm8gU3RhYmVs bGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47DQo+IEJlcnRyYW5kDQo+ID4gPiA+IE1hcnF1 aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVrDQo+ID4gPiA+ IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT47IEppYW1laSBYaWUgPEppYW1laS5YaWVAYXJt LmNvbT4NCj4gPiA+ID4gU3ViamVjdDogUmU6IFtQQVRDSCB2NiAwNS8xMV0geGVuL2FybTogZGVm aW5lIFhlbiBzdGFydCBhZGRyZXNzIGZvcg0KPiBGVlANCj4gPiA+ID4gQmFzZVIgcGxhdGZvcm0N Cj4gPiA+ID4NCj4gPiA+ID4NCj4gPiA+ID4NCj4gPiA+ID4gT24gMDQvMTEvMjAyMiAxMDowNywg V2VpIENoZW4gd3JvdGU6DQo+ID4gPiA+ID4gT24gQXJtdjgtQSwgWGVuIGhhcyBhIGZpeGVkIHZp cnR1YWwgc3RhcnQgYWRkcmVzcyAobGluayBhZGRyZXNzDQo+ID4gPiA+ID4gdG9vKSBmb3IgYWxs IEFybXY4LUEgcGxhdGZvcm1zLiBJbiBhbiBNTVUgYmFzZWQgc3lzdGVtLCBYZW4gY2FuDQo+ID4g PiA+ID4gbWFwIGl0cyBsb2FkZWQgYWRkcmVzcyB0byB0aGlzIHZpcnR1YWwgc3RhcnQgYWRkcmVz cy4gU28sIG9uDQo+ID4gPiA+ID4gQXJtdjgtQSBwbGF0Zm9ybXMsIHRoZSBYZW4gc3RhcnQgYWRk cmVzcyBkb2VzIG5vdCBuZWVkIHRvIGJlDQo+ID4gPiA+ID4gY29uZmlndXJhYmxlLiBCdXQgb24g QXJtdjgtUiBwbGF0Zm9ybXMsIHRoZXJlIGlzIG5vIE1NVSB0byBtYXANCj4gPiA+ID4gPiBsb2Fk ZWQgYWRkcmVzcyB0byBhIGZpeGVkIHZpcnR1YWwgYWRkcmVzcyBhbmQgZGlmZmVyZW50IHBsYXRm b3Jtcw0KPiA+ID4gPiA+IHdpbGwgaGF2ZSB2ZXJ5IGRpZmZlcmVudCBhZGRyZXNzIHNwYWNlIGxh eW91dC4gU28gWGVuIGNhbm5vdCB1c2UNCj4gPiA+ID4gPiBhIGZpeGVkIHBoeXNpY2FsIGFkZHJl c3Mgb24gTVBVIGJhc2VkIHN5c3RlbSBhbmQgbmVlZCB0byBoYXZlIGl0DQo+ID4gPiA+ID4gY29u ZmlndXJhYmxlLg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gU28gaW4gdGhpcyBwYXRjaCwgd2UgcmV1 c2UgdGhlIGV4aXN0aW5nIGFybS9wbGF0Zm9ybXMgdG8gc3RvcmUNCj4gPiA+ID4gPiBBcm12OC1S IHBsYXRmb3JtcycgcGFyYW1ldGVycy4gQW5kIGBYRU5fU1RBUlRfQUREUkVTU2AgaXMgb25lDQo+ ID4gPiA+ID4ga2luZCBvZiBGVlAgQmFzZVIgcGxhdGZvcm0ncyBwYXJhbWV0ZXJzLiBTbyB3ZSBk ZWZpbmUgZGVmYXVsdA0KPiA+ID4gPiA+IGBYRU5fU1RBUlRfQUREUkVTU2AgZm9yIEZWUCBCYXNl UiBpbiBpdHMgcGxhdGZvcm0gZmlsZS4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IFdlIGFsc28gaW50 cm9kdWNlIG9uZSBLY29uZmlnIG9wdGlvbiBmb3IgdXNlcnMgdG8gb3ZlcnJpZGUgdGhlDQo+ID4g PiA+ID4gZGVmYXVsdCBYZW4gc3RhcnQgYWRkcmVzcyBvZiBzZWxlY3RlZCBwbGF0Zm9ybSwgaWYg dGhleSB0aGluaw0KPiA+ID4gPiA+IHRoZSBkZWZhdWx0IGFkZHJlc3MgZG9lc24ndCBzdWl0IHRo ZWlyIHNjZW5hcmlvcy4gRm9yIHRoaXMNCj4gPiA+ID4gPiBLY29uZmlnIG9wdGlvbiwgd2UgdXNl IGFuIHVuYWxpZ25lZCBhZGRyZXNzICIweGZmZmZmZmZmIiBhcyB0aGUNCj4gPiA+ID4gPiBkZWZh dWx0IHZhbHVlIHRvIGluZGljYXRlIHRoYXQgdXNlcnMgaGF2ZW4ndCB1c2VkIGEgY3VzdG9taXpl ZA0KPiA+ID4gPiA+IFhlbiBzdGFydCBhZGRyZXNzLg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gQW5k IGFzIHdlIGludHJvZHVjZWQgQXJtdjgtUiBwbGF0Zm9ybXMgdG8gWGVuLCB0aGF0IG1lYW5zIHRo ZQ0KPiA+ID4gPiA+IGV4aXN0ZWQgQXJtNjQgcGxhdGZvcm1zIHNob3VsZCBub3QgYmUgbGlzdGVk IGluIEFybXY4LVIgcGxhdGZvcm0NCj4gPiA+ID4gPiBsaXN0LCBzbyB3ZSBhZGQgIUFSTV9WOFIg ZGVwZW5kZW5jeSBmb3IgdGhlc2UgcGxhdGZvcm1zLg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gU2ln bmVkLW9mZi1ieTogV2VpIENoZW4gPHdlaS5jaGVuQGFybS5jb20+DQo+ID4gPiA+ID4gU2lnbmVk LW9mZi1ieTogSmlhbWVpLlhpZSA8amlhbWVpLnhpZUBhcm0uY29tPg0KPiA+ID4gPiA+IC0tLQ0K PiA+ID4gPiA+ICAgIHhlbi9hcmNoL2FybS9LY29uZmlnICAgICAgICAgICAgICAgICAgICAgICAg ICAgfCAxMSArKysrKysrKysrKw0KPiA+ID4gPiA+ICAgIHhlbi9hcmNoL2FybS9pbmNsdWRlL2Fz bS9wbGF0Zm9ybXMvZnZwX2Jhc2VyLmggfCAxNA0KPiArKysrKysrKysrKysrKw0KPiA+ID4gPg0K PiA+ID4gPiBJIGxvb2tlZCBhdCB0aGUgY29udGVudCBvZiBmdnBfYmFzZXIuaCBhZnRlciB0aGlz IHNlcmllcyBpcyBhcHBsaWVkLg0KPiA+ID4gPiBUaGVyZSBhcmUgYSBiaXQgb2YgYm9pbGVyIHBs YXRlIHRoYXQgSSBleHBlY3QgdG8gYmUgcGFydCBmb3Igb3RoZXINCj4gPiA+ID4gcGxhdGZvcm1z LiBJbiBwYXJ0aWN1bGFyLi4uDQo+ID4gPiA+DQo+ID4gPiA+ID4gICAgeGVuL2FyY2gvYXJtL3Bs YXRmb3Jtcy9LY29uZmlnICAgICAgICAgICAgICAgICB8IDE2DQo+ICsrKysrKysrKysrKystLS0N Cj4gPiA+ID4gPiAgICAzIGZpbGVzIGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDMgZGVsZXRp b25zKC0pDQo+ID4gPiA+ID4gICAgY3JlYXRlIG1vZGUgMTAwNjQ0DQo+IHhlbi9hcmNoL2FybS9p bmNsdWRlL2FzbS9wbGF0Zm9ybXMvZnZwX2Jhc2VyLmgNCj4gPiA+ID4gPg0KPiA+ID4gPiA+IGRp ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vS2NvbmZpZyBiL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+ ID4gPiA+ID4gaW5kZXggYWQ1OTIzNjdiZC4uYWMyNzYzMDdkNiAxMDA2NDQNCj4gPiA+ID4gPiAt LS0gYS94ZW4vYXJjaC9hcm0vS2NvbmZpZw0KPiA+ID4gPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9L Y29uZmlnDQo+ID4gPiA+ID4gQEAgLTEzOCw2ICsxMzgsMTcgQEAgY29uZmlnIFRFRQ0KPiA+ID4g PiA+ICAgIAkgIFRoaXMgb3B0aW9uIGVuYWJsZXMgZ2VuZXJpYyBURUUgbWVkaWF0b3JzIHN1cHBv cnQuIEl0IGFsbG93cw0KPiA+ID4gPiBndWVzdHMNCj4gPiA+ID4gPiAgICAJICB0byBhY2Nlc3Mg cmVhbCBURUUgdmlhIG9uZSBvZiBURUUgbWVkaWF0b3JzIGltcGxlbWVudGVkIGluDQo+ID4gPiA+ ID4gWEVOLg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gK2NvbmZpZyBYRU5fU1RBUlRfQUREUkVTUw0K PiA+ID4gPiA+ICsJaGV4ICJYZW4gc3RhcnQgYWRkcmVzczoga2VlcCBkZWZhdWx0IHRvIHVzZSBw bGF0Zm9ybSBkZWZpbmVkDQo+ID4gPiA+IGFkZHJlc3MiDQo+ID4gPiA+ID4gKwlkZWZhdWx0IDB4 RkZGRkZGRkYNCj4gPiA+ID4NCj4gPiA+ID4gLi4uIHRoaXMgZGVmYXVsdCB2YWx1ZSB3aWxsIG5l ZWQgdG8gYmUgdGVzdGVkIGV2ZXJ5d2hlcmUuIEF0IGxlYXN0DQo+IGZvcg0KPiA+ID4gPiBub3cs IEkgdGhpbmsgeW91IGNhbiBhdm9pZCB0aGUgcGVyIHBsYXRmb3JtIGhlYWRlciBieSB1c2luZyB0 aGUNCj4gS2NvbmZpZw0KPiA+ID4gPiB0byBzZWxlY3QgdGhlIHByb3BlciBhZGRyZXNzIChzZWUg dGhlIGNvbmZpZyBmb3Igc2VsZWN0aW5nIGVhcmx5DQo+IHByaW50aw0KPiA+ID4gPiBhZGRyZXNz KS4NCj4gPiA+ID4NCj4gPiA+ID4gVGhpcyB3aWxsIGFsc28gYXZvaWRzIHRvIHVzZSBhbiBpbnZh bGlkIHZhbHVlIGhlcmUuDQo+ID4gPiA+DQo+ID4gPg0KPiA+ID4gV2UgaGFkIGNvbnNpZGVyZWQg dG8gdXNlIEtjb25maWcgdG8gZGVmaW5lIHRoZSBzdGFydCBhZGRyZXNzZXMgb2YNCj4gdjhSNjQN Cj4gPiA+IHBsYXRmb3JtcyAocHJvbXB0IHVzZXJzIHRvIGlucHV0IHRoZSBhZGRyZXNzKS4gQnV0 IHdlIGFsc28gd2FudCB0bw0KPiBwcm92aWRlDQo+ID4gPiBhIGRlZmF1bHQgc3RhcnQgYWRkcmVz cyBmb3IgZWFjaCBwbGF0Zm9ybSAoRGlzY3Vzc2VkIGluIFsxXSwgaGVhZGVyDQo+IGZvcg0KPiA+ ID4gZGVmYXVsdCB2YWx1ZSwgS2NvbmZpZyBvcHRpb24gZm9yIGN1c3RvbWl6ZWQgYWRkcmVzcyku DQo+ID4gV2h5IGRvIHlvdSB3YW50IHRvIHByb3ZpZGUgYSBkZWZhdWx0IHZhbHVlPyBBbmQgaG93 IGl0IGlzIGd1YXJhbnRlZWQNCj4gdGhhdCBpdA0KPiA+IHdpbGwgd29yayBmb3IgbW9zdCBvZiB0 aGUgdXNlcnM/DQo+ID4NCj4gPiA+DQo+ID4gPiBXZSBhbHNvIGhhZCB0aG91Z2h0IHRvIHVzZSBL Y29uZmlnIHRvIGRlZmluZSBhIGRlZmF1bHQgc3RhcnQgYWRkcmVzcw0KPiA+ID4gZm9yIGVhY2gg cGxhdGZvcm0gbGlrZSB3aGF0IHdlIGhhZCBkb25lIGZvciBlYXJseSBwcmludGsgaW4gUkZDWzJd Lg0KPiA+ID4gQnV0IHRoaXMgbWV0aG9kIGhhcyBiZWVuIGRlcHJlY2F0ZWQuDQo+ID4NCj4gPiBN b3N0IG9mIHRoZSBjdXJyZW50IFhlbiBpcyBib2FyZCBhZ25vc3RpYyBleGNlcHQgdGhlIFVBUlQu IFdlIHB1c2ggYmFjaw0KPiB0aGUNCj4gPiBhZGRpdGlvbiBvZiBuZXcgb25lIGJlY2F1c2UgdGhl IGFkZHJlc3MgY2FuIGJlIGZvdW5kIGluIHRoZSBmaXJtd2FyZQ0KPiB0YWJsZSBhbmQNCj4gPiBJ IHdhbnRlZCB0byBhdm9pZCBpbmNyZWFzZSB0aGUgbnVtYmVyIG9mIG9wdGlvbiAodGhlcmUgYXJl IGRvemVucyBvZg0KPiBwbGF0Zm9ybQ0KPiA+IG91dC4uLikuDQo+ID4NCj4gPiA+DQo+ID4gPiBT byBpZiB3ZSBkb27igJl0IHVzZSBoZWFkZXIgZmlsZXMsIGp1c3QgdXNlIHRoZSBLY29uZmlnLCB3 ZSBjYW4ndA0KPiA+ID4gcHJvdmlkZSBhIGRlZmF1bHQgc3RhcnQgYWRkcmVzcyBmb3IgcGxhdGZv cm1zLCBhbmQgaGF2ZSB0byBmb3JjZSB1c2Vycw0KPiA+ID4gdG8gZW50ZXIgdGhlIHN0YXJ0IGFk ZHJlc3MuDQo+ID4NCj4gPiBJIGFtIG5vdCBzdXJlIEkgc2VlIHRoZSBwcm9ibGVtIHRvIGZvcmNl IHRoZSB1c2VyIHRvIGVudGVyIHRoZSBzdGFydA0KPiBhZGRyZXNzLg0KPiA+IE15IHdvcnJ5IHdp dGggcGVyLXBsYXRmb3JtIGRlZmF1bHQgdmFsdWUgaXMgd2UgZW5kIHVwIHRvIGZvcmNlIGVhY2gN Cj4gdmVuZG9yIHRvDQo+ID4gcHJvdmlkZSBhbiBoZWFkZXIgaW4gb3JkZXIgdG8gYm9vdCBYZW4u DQo+ID4NCj4gPiBJIHRoaW5rIGl0IHdvdWxkIGJlIGJldHRlciB0byBwcm92aWRlIGEgY29uZmln IHRhaWxvcmVkIGZvciB0aGF0DQo+IHBsYXRmb3JtDQo+ID4gKHdoZXRoZXIgaXQgaXMgcGFydCBv ZiBYZW4gY2FuIGJlIGRlYmF0YWJsZSkuIFRoaXMgd291bGQgYWxsb3cgYSB1c2VyIHRvDQo+IHRy eSBhDQo+ID4gcmVsZWFzZSBYZW4gb24gdGhlaXIgcGxhdGZvcm0gd2l0aCB6ZXJvIGNoYW5nZXMg aW4gdGhlIGNvZGUuDQo+IA0KPiBJIGFncmVlIHdpdGggSnVsaWVuLCBlc3BlY2lhbGx5IG9uIHRo aXMgbGFzdCBwb2ludC4NCj4gDQo+IE9mIGNvdXJzZSB3ZSBuZWVkIGEgZGVmYXVsdCBjb25maWd1 cmF0aW9uIGZvciBhIGdpdmVuIHBsYXRmb3JtLCB3ZSBkb24ndA0KPiB3YW50IGV2ZXJ5IHVzZXIg b2YgdGhlIHNhbWUgcGxhdGZvcm0gdG8gaGF2ZSB0byBnbyBhbmQgbG9vayBhdCB0aGUNCj4gbWFu dWFsIHRvIGZpbmQgdGhlIHJpZ2h0IGFkZHJlc3MgdG8gdXNlLg0KPiANCj4gVGhlIHF1ZXN0aW9u IGlzIHdoZXJlIHRvIHB1dCB0aGUgcGVyLXBsYXRmb3JtIGRlZmF1bHQgdmFsdWUuIFRoZSBrY29u ZmlnDQo+ICJkZWZhdWx0IiBrZXl3b3JkIGlzIG5vdCBncmVhdCBmb3IgdGhhdCBhbmQgaXQgaXMg bm90IHJlYWxpc3RpYyB0byBoYXZlDQo+IGEgc2luZ2xlIGFkZHJlc3MgdGhhdCB3b3JrcyBldmVy eXdoZXJlLg0KPiANCj4gSW5zdGVhZCwgd2UgY291bGQgaGF2ZSBhIHByZXBvcHVsYXRlZCBrY29u ZmlnIHVuZGVyDQo+IHhlbi9hcmNoL2FybS9jb25maWdzLCBvciBzb21ldGhpbmcgdW5kZXIgSW1h Z2VCdWlsZGVyLCBvciBtYXliZSBleHBhbmQNCg0KRG8geW91IG1lYW4gd2UgY2FuIGtlZXAgYSBj b25maWcgbGlrZSBhcm12OHJfZnZwX2Jhc2VyX2NvbmZpZyBpbg0KeGVuL2FyY2gvYXJtL2NvbmZp Z3MgZm9yIHVzZXJzIHRvIGdlbmVyYXRlIGEgZGVmYXVsdCBjb25maWc/DQpJZiB5ZXMgSSB0aGlu ayB0aGlzIG1ldGhvZCBtaWdodCBiZSBiZXR0ZXIgZm9yIG5vdy4gQW5kIGFib3V0IEltYWdlQnVp bGRlcg0Kc29sdXRpb24gd2UgY2FuIGRvIGl0IGFmdGVyIE1QVSBzdXBwb3J0IGJlIG1lcmdlZD8N Cg0KQ2hlZXJzLA0KV2VpIENoZW4NCg0KPiB0aGUgZXhpc3RpbmcgIlBsYXRmb3JtIFN1cHBvcnQi IGtjb25maWcgbWVudS4NCj4gDQo+IElmIHRoaXMgd2FzIGp1c3QgWEVOX1NUQVJUX0FERFJFU1Ms IEkgd291bGQgc3VnZ2VzdCB0byBrZWVwIGl0IGluDQo+IHhlbi5naXQgc29tZXdoZXJlLiBCdXQg Z2l2ZW4gdGhhdCB0aGVyZSBhcmUgYSBmZXcgYWRkcmVzc2VzIGFuZCBzaXplcyB0bw0KPiBwcm92 aWRlL2NhbGN1bGF0ZSBmb3IgWGVuIG9uIE1QVSB0byB3b3JrLCB1c2luZyBJbWFnZUJ1aWxkZXIg Y291bGQgYmUgYQ0KPiBnb29kIGlkZWEuDQoNCg== From xen-devel-bounces@lists.xenproject.org Fri Nov 11 10:25:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 10:25:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442419.696563 (Exim 4.92) (envelope-from ) id 1otRDX-0000Ld-IN; Fri, 11 Nov 2022 10:24:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442419.696563; Fri, 11 Nov 2022 10:24:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otRDX-0000LW-FI; Fri, 11 Nov 2022 10:24:59 +0000 Received: by outflank-mailman (input) for mailman id 442419; Fri, 11 Nov 2022 10:24:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otRDW-0000LQ-Pu for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 10:24:59 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 14f81aba-61ab-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 11:24:55 +0100 (CET) Received: from mail-bn1nam07lp2047.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Nov 2022 05:24:39 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BN8PR03MB5137.namprd03.prod.outlook.com (2603:10b6:408:d8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Fri, 11 Nov 2022 10:24:34 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::d197:992c:4dca:3c4c%6]) with mapi id 15.20.5791.030; Fri, 11 Nov 2022 10:24:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14f81aba-61ab-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668162295; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=sGhnX9PEbGHHKW4pIF89GXQE1AbpTAFbQNeOWTAF5cM=; b=g/at61tQM9xdD0HR1uaK/vlruRXayM6AJS7RvkQEAIoK64spFasqaLtd GT2Rq+OxhlOwaaebV+whFKbgUvHtO5Srheu7+x1Eog6sXLuGiCuXs1A0S StXuUK8N9QJqwmj89m/iXld1P1Lzl8r/rUuj1FGb88qbqQtlxZ5fIj6jG s=; X-IronPort-RemoteIP: 104.47.51.47 X-IronPort-MID: 84230055 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jPoQGqpjvmnlVFHoCgmMD6V/nIJeBmLvZBIvgKrLsJaIsI4StFCzt garIBnSM/+JMDH1eth0aN7k8kIOu5/WxtdmGlFppSo8FXlDpZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHziBNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAApcQxqRvuHr+6OmRMBuuOEqMeXIZJxK7xmMzRmBZRonabbqZv2QoPV+hXI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeGrbIW9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAurBNhJTOXlq5aGhnXJ/jMuKAQGfGC5rOv+p1CCd8hZB h09r39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOlMIwXy1s6 VaPkPvgHzkpu7qQIVqF/6qQhSO/P24SN2BqTTAAZRsI5Z/kuo5bphDFQ8tnEaW1psboAjy2y DePxAA8mrNVi8cI3qe6+FnvgjSwq5yPRQkwji3UU3yk6EVlZYejT42u9VXfq/1HKe6kokKpu XEFn42U6rkIBJTVyyiVGr1RQ/eu+uqPNyDajRh3BZ49+j+x+nmlO4dN/DV5I0QvOcEBEdP0X HLuVcpqzMc7FBOXgWVfOtrZ5xgCpUQ4KenYaw== IronPort-HdrOrdr: A9a23:8Lq7Ma10V0YiJ71e6jGRlAqjBSByeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6 Dsm/av6gDQMEj+Ka+Adwo4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA H+4kfEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z HxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72MeBsKT+56wa5JeBrQ7EQt+Ptm1r hQ4m6fv51LSTvdgSXU/bHzJl5Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP JlAKjnlbprmGuhHjHkV1RUsZyRtixZJGbEfqFCgL3Z79FupgE286NCr/Zv3Evp9/oGOux5Dq r/Q+FVfYp1P78rhJJGdZk8qPSMex3wqDL3QRWvyAfcZdc6EkOIjaLLy5MIw8zvUKA07fIJ6e b8uRVjxCQPR34= X-IronPort-AV: E=Sophos;i="5.96,156,1665460800"; d="scan'208";a="84230055" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ULa2pLAMWXsgbpcPLxyhNaenkTDOiren7Ut0v7YUWt94oL383GDYYq+vhkYH0rQ2oPXRzSTNRh7JXe76BOlC3utnFXiylDjmSbiV6+48RlNFymNfzKIc6ARuRI7ROwWYipC7ZwgXArEqaDFiGXYoiZA+CT83bNWSU/q8QnhTXgiQlVHzzLGR8qphA53/d/Cr0vOw+7XISB/pG/KW+6ew6DhCM526l+4/jspmt4TtaeclHtIIlCBcOlOloJC0izFvv7Z8SM26FYt2SIgg1WhBFMfJRWlMB170q+cZSvA6lc4h+x7MvSn16jbDMNO1pClPhiZX3yPtqmxsl4zJ52n3tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vrs8A0dqY/TrkOge+2bnNZFSQX12ELuGSsJShoXRY7U=; b=FfZ3NS2l6bpvF5M/6MX8OywSlYYapsMrxfXMGtNAySBRafml6Hx41wQmoDkLtZqQF7T6edEgQjKYl4vfjJaVyUrejRSlcf7gVvJTx+GkvMg1sjTMTDzfZxbAcqdNFLHOIHNPriZHyE/Nu9PT0gC25b+b9gjJjoVq0/vP9gDSXACUrUgeMCreAt3FRb3uSjMy4foWEIJhmSM+hLjLOi4VSuzN5NV09s6qSLxRKF4Xv7+DrTX9ax4Vb/PVCyAk9fpf5vqN4I1ZS27Go+GkmylgRQlPg4Nay0XnDECHb1aPHmY5oBzzn8eLp06FcXcZcTviy/fBhzGS9oxXU91oOnz66Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vrs8A0dqY/TrkOge+2bnNZFSQX12ELuGSsJShoXRY7U=; b=bT75qaCHGMUOeONPR8I7r6AZ5jytkTEyCGpAFc2/znevy5XTZznouCv6uj8Naj/aAX3znFAFaSYKVm+rbHGCQIpi6TYoIZS3ceycr3M1F8XFxFnIqj5lDShgBDMfZFu2a0Ck7AvsFXSOkP+O+Xa9Fcw1B1s2of8v2z46eKuCEVY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 11 Nov 2022 11:24:27 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , "Henry.Wang@arm.com" , Paul Durrant , Wei Liu , Jan Beulich , Jun Nakajima , Kevin Tian Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Message-ID: References: <20221104161815.38007-1-roger.pau@citrix.com> <69841767-ccc4-5eeb-6e9c-d59dfb197ea5@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <69841767-ccc4-5eeb-6e9c-d59dfb197ea5@citrix.com> X-ClientProxiedBy: PA7P264CA0045.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:34b::7) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN8PR03MB5137:EE_ X-MS-Office365-Filtering-Correlation-Id: 019f65cc-71ee-41a1-6f6d-08dac3ceed05 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W9K/gJ6y1+i/PKhIn87ksgPIfe3XxJ+sq3WaKmWCbBQy1NWDpKDceOia42umNebWKJLTiVdgnDh3EO+AwFx5B+YEKbOE/bi4Vv/6USbsoiDGb5BH3bicpBVLpvmHTjeeeucDyl53iCxtJ6q+0TL5NhUZaJ7U6S7hekSqV8aOInmXOI1ZDf91ktaj3CZMNdQBlbvgWizhZY3bdL0jBV66YHsS//SRFRpRZ83ZWViaMbXpzQW6zJsduU4j8OH0514ds/bEexxuXsU8qss3riyIGXWOdMLQA4bFmokIP1dGBmTxGkDDJUXrjTLRCaMUEJTNNfbanHjUnCbmxQY2l0bzoBlYA6GUlFScvEC2nySDw5ugQOUODpBzKgGV0kboeUrMWAOyljv167RXiUi5wB1/6aarWUmdyHRenyCaeATOw8LNOYGdZ9vD96vrOFu+inVLlaYYYrIgIc6KbwaO5N8/Ld8D59KChJ9J2MdVIJF2xNV/m7WM0CNgMmwAfhOqCsCfmgyQv8Pu0pUrM2Mz0sFXQopY0SFSDONy94FQLOloLIyy2FXvKc4AFZOQMA0SNyTFNhbpED82XauyNDW6vhEDs7Vls58onNpIXwK8jnQvjRY+lgOeNgfXyKA3gD21CxJOIUHbvsTRZljRiOdBmHJD5heDu1qHBh6AB9g2JMW2G5CoRuC9tBMudVH3N/RzqJa2x4OqalJOBaWC0BTLsWE/Aw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(346002)(396003)(39860400002)(366004)(376002)(136003)(451199015)(82960400001)(38100700002)(316002)(33716001)(54906003)(4326008)(66946007)(66476007)(8676002)(66556008)(41300700001)(6636002)(6512007)(9686003)(86362001)(5660300002)(83380400001)(6486002)(478600001)(6506007)(6862004)(53546011)(186003)(8936002)(26005)(85182001)(6666004)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFhsZTc5cXFDczYrSVoxdTFKOS9yU0syTnpJMVZib3VhTndzRys0ZitBam5N?= =?utf-8?B?TStSeElXRjRFa2duY3dtdmJDK3M5VWxUVEtDTGhvL05DVHd2ZFpGa2FqQTB2?= =?utf-8?B?MEtpeWJYNlM0TTVKRDcrMXF0MHQ5SGhKR0F2V3pEeWcwMjVlejF3M3ZmYXo5?= =?utf-8?B?dWxRcm5zemJPU0hzbFhmMHpqSGV4R1VBUVdab0VBbHpEN205R1Y3czdiWThY?= =?utf-8?B?WHNtcmUyaDhTSGJUd3ZiTDhXVGhhejU1K2svN2xtSXNuK2tVYW0rdTUyV2hh?= =?utf-8?B?OTAranZSSDAzb1NTTW9HVVFla0ZPN3RjZXI2RkJ2NjlnbVQzQU9QK0Y5NTcv?= =?utf-8?B?Qi9JK0EraVJpTDBkNW8rbWJHRHJWai94djJ2dVZyN2pFMG4zQTgvS2prWnc5?= =?utf-8?B?dnRkVjU3SFp5WXI3UTVFRHM2UWU2NE12NlZRVC9XaThYcTJGeGFPZ2RaU3J6?= =?utf-8?B?b3BBaE1GUWhsTTFnZm5vci9vRjh5bjhLUURMYy9iQ1BuZEdIU1ZOM0xQK1Z5?= =?utf-8?B?UDFyNHUyS3E2MnRVUkxRK3JRMTBZbWNxOE9vUXQvckRlRWVSM3dqZnZUT1dB?= =?utf-8?B?eDhhV1FZREZGM1ZHSTlnYTFLYktYRVNPdHRFK2o4blI0SC9zRXNOSk9ZN0ZE?= =?utf-8?B?SXRSMlNGcjVESFQ2MjFIcjYvcjFaMEpuV1c2WWxwMmx4N2dYSEcreUtHVlZ2?= =?utf-8?B?UTZGTFUyU0ZlS2RRM29Md2kydGVLbTVrQWJsYk1paFBHYlpHTVlnN3MwUGpX?= =?utf-8?B?ekdsdnI1cEhsNXBOOHg1R2Nvd3BwaXg1elZ5M1pKMVQ4bWF1TVZGSGFYVlR2?= =?utf-8?B?STBZbGZ1cWVzVEoyWDBCQmpjaUk5TkVKS2t1SGtKb2JXMWZHSkNwQVQ3Si9M?= =?utf-8?B?OUpaQ2YrL1pQL0dMam1mZVVnT2pMLzZGUzhTVmhlYmJHc3hnNU9lNmJwYXIx?= =?utf-8?B?amRuSzNqY01QT01XelFVN2V4NTVUaDdZRk8rUXhnclJPSXh6Ujk2S1hRYmVu?= =?utf-8?B?eW1wYjBvTzFRTk5IckNiMTJFMjA1ZTJVRUlkSFV4Q2FSK005clNTem1pYmdC?= =?utf-8?B?U2pxc05qZk94MDAxQ0F1RkE3ZUxhK1VGL1EyWWNRSDRFam9xcEZ6MnBVMUts?= =?utf-8?B?VTVTYWVXNzdUUFJqVWg2ME9YQkhRamhocHZqQWxzdm1ib0xXVFJua0IvZlB0?= =?utf-8?B?Vmh0ektmVitpYUFQcjExNENGSGxLaDNubXlhdmxlamhOZ3BML3BLUFJhcCtT?= =?utf-8?B?ZHNVVnMrR0ZOYzFqTHNmbnhSQzZVd2lGL2t5L2hPNSs5TnNzSDZqNTY5TlY2?= =?utf-8?B?YzhTcUQwUkg4Q1N0d1duWDNlT0dvUFpXSDhSNlRoVlg1M1B3L1lsWENhQmUv?= =?utf-8?B?MU4zVzN2eHJXVTJjU25BdzIraVRvV1NuU0l2SmNLNm13bnJ4S1ZFQUg4aE9a?= =?utf-8?B?ZmhvNzgwZnN4bWJ1UWJHVkVINVhVTzF0cWo5OUgzcHpxaU1RVWNpUUh5OGt1?= =?utf-8?B?ZGdZckg1UUgzUGphTExNRzhIdUxwRWVDWXZ5cFpWbTlmL2t0Ym5pSGZsQ2xO?= =?utf-8?B?SmlCSWg0b3lZMjdDazFpOGd1bmFtanVoRjJ6MWVKSTlCVVREbWtyWnJWMFZV?= =?utf-8?B?dUF3VXZ2WFFsMzFIMExXTmJRYkJrdCtsRWdqS2MxUjFTNG9sZStNbExnRElm?= =?utf-8?B?dG92L2t6Z2RLQlQ2Y1hwNXVGNWxnbGgrVEdXUnFNV3phZFBtOHo5cE9zNi9Z?= =?utf-8?B?WUk2UlNvUHUrUEdZbTJaWGRBZTgzUHB0WWlYWGI1eDd5YWlVV3M2YVowUkxu?= =?utf-8?B?ZnVqc2g4UGR6MlpZTDhBOFNNaVBVOFVLMTl3b2RaZkF1T1dwTnVEc2hhOHlJ?= =?utf-8?B?WWhCbWY5cC9PUUtwdzg5bStOdmx4a05oVGVTNUc0YlVoNEFEZmxTbjZxeGxL?= =?utf-8?B?L2luYUFaUE1qZHB0S3VxTmhXejF2elRMK3luWGdWMHh4bGU1OHViWXhQanZL?= =?utf-8?B?YVpMdG1mWTBpVnlxbzRyQWhQdW5mdDgyNmNvNVhHY01UWGFHWFYxWVc2TDE3?= =?utf-8?B?MWs5RzBiT0trWmdTZGZjS0pIcWliMzlKZFBzVjJ0ZVJ4U2pQNVdHTUkvWTNn?= =?utf-8?Q?mP78WuiPAZhkLWz6hoXsNQp2v?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 019f65cc-71ee-41a1-6f6d-08dac3ceed05 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 10:24:33.5300 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EjIpE5xsMqHFWiMQNXTP+l+Dk20gypJMgnTkNIdTA3r02lXOQ7+z6RvsadkmB58jGCW7SfeQjg6Bat5fQDNOkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5137 On Thu, Nov 10, 2022 at 10:47:07PM +0000, Andrew Cooper wrote: > On 04/11/2022 16:18, Roger Pau Monne wrote: > > The current reporting of the hardware assisted APIC options is done by > > checking "virtualize APIC accesses" which is not very helpful, as that > > feature doesn't avoid a vmexit, instead it does provide some help in > > order to detect APIC MMIO accesses in vmexit processing. > > > > Repurpose the current reporting of xAPIC assistance to instead report > > such feature as present when there's support for "TPR shadow" and > > "APIC register virtualization" because in that case some xAPIC MMIO > > register accesses are handled directly by the hardware, without > > requiring a vmexit. > > > > For symetry also change assisted x2APIC reporting to require > > "virtualize x2APIC mode" and "APIC register virtualization", dropping > > the option to also be reported when "virtual interrupt delivery" is > > available. Presence of the "virtual interrupt delivery" feature will > > be reported using a different option. > > > > Fixes: 2ce11ce249 ('x86/HVM: allow per-domain usage of hardware virtualized APIC') > > Signed-off-by: Roger Pau Monné > > --- > > I find the logic in vmx_vlapic_msr_changed() hard to follow, but I > > don't want to rewrite the function logic at this point. > > --- > > Changes since v1: > > - Fix Viridian MSR tip conditions. > > --- > > xen/arch/x86/hvm/viridian/viridian.c | 2 +- > > xen/arch/x86/hvm/vmx/vmcs.c | 8 ++++---- > > xen/arch/x86/hvm/vmx/vmx.c | 25 ++++++++++++++++++------- > > xen/arch/x86/traps.c | 4 +--- > > 4 files changed, 24 insertions(+), 15 deletions(-) > > > > diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c > > index 25dca93e8b..44eb3d0519 100644 > > --- a/xen/arch/x86/hvm/viridian/viridian.c > > +++ b/xen/arch/x86/hvm/viridian/viridian.c > > @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, > > res->a = CPUID4A_RELAX_TIMER_INT; > > if ( viridian_feature_mask(d) & HVMPV_hcall_remote_tlb_flush ) > > res->a |= CPUID4A_HCALL_REMOTE_TLB_FLUSH; > > - if ( !cpu_has_vmx_apic_reg_virt ) > > + if ( !has_assisted_xapic(d) ) > > res->a |= CPUID4A_MSR_BASED_APIC; > > This check is broken before and after.  It needs to be keyed on > virtualised interrupt delivery, not register acceleration. > > But doing this correctly needs a per-domain vintr setting, which we > don't have yet. > > It is marginally less broken with this change, than without, but that's > not saying much. > > > if ( viridian_feature_mask(d) & HVMPV_hcall_ipi ) > > res->a |= CPUID4A_SYNTHETIC_CLUSTER_IPI; > > diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c > > index a1aca1ec04..7bb96e1a8e 100644 > > --- a/xen/arch/x86/hvm/vmx/vmcs.c > > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > > @@ -1136,7 +1136,7 @@ static int construct_vmcs(struct vcpu *v) > > > > if ( !has_assisted_xapic(d) ) > > v->arch.hvm.vmx.secondary_exec_control &= > > - ~SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; > > + ~SECONDARY_EXEC_APIC_REGISTER_VIRT; > > > > if ( cpu_has_vmx_secondary_exec_control ) > > __vmwrite(SECONDARY_VM_EXEC_CONTROL, > > @@ -2156,10 +2156,10 @@ int __init vmx_vmcs_init(void) > > if ( !ret ) > > { > > /* Check whether hardware supports accelerated xapic and x2apic. */ > > - assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses; > > + assisted_xapic_available = cpu_has_vmx_tpr_shadow && > > + cpu_has_vmx_apic_reg_virt; > > assisted_x2apic_available = cpu_has_vmx_virtualize_x2apic_mode && > > - (cpu_has_vmx_apic_reg_virt || > > - cpu_has_vmx_virtual_intr_delivery); > > + cpu_has_vmx_apic_reg_virt; > > apic reg virt already depends on tpr shadow, so that part of the > condition is redundant. > > virtualise x2apic mode and apic reg virt aren't dependent, but they do > only ever appear together in hardware. > > Keeping the conditionals might be ok to combat a bad outer hypervisor, > but ... > > > register_keyhandler('v', vmcs_dump, "dump VT-x VMCSs", 1); > > } > > > > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > > index e624b415c9..bf0fe3355c 100644 > > --- a/xen/arch/x86/hvm/vmx/vmx.c > > +++ b/xen/arch/x86/hvm/vmx/vmx.c > > @@ -3405,25 +3405,29 @@ static void vmx_install_vlapic_mapping(struct vcpu *v) > > > > void vmx_vlapic_msr_changed(struct vcpu *v) > > { > > + bool virtualize_x2apic_mode = has_assisted_x2apic(v->domain) || > > + (cpu_has_vmx_virtualize_x2apic_mode && > > + cpu_has_vmx_virtual_intr_delivery); > > ... this is still wrong, and ... > > > struct vlapic *vlapic = vcpu_vlapic(v); > > unsigned int msr; > > > > - if ( !has_assisted_xapic(v->domain) && > > - !has_assisted_x2apic(v->domain) ) > > + if ( !cpu_has_vmx_virtualize_apic_accesses && > > + !virtualize_x2apic_mode ) > > return; > > ... this surely cannot be right. > > While attempting to figure ^ out, I've found yet another regression vs > 4.16.  Because virt intr delivery is set in the execution controls > system-wide and not controlled per domain, we'll take a vmentry failure > on SKX/CLX/ICX when trying to build an HVM domain without xAPIC > acceleration. > > > This, combined with the ABI errors (/misfeatures) that we really don't > want to escape into the world but I haven't finished fixing yet, means > that the only appropriate course of action is to revert. > > I'd really hoped to avoid a full revert, but we've run out of time. Can we wait for the revert until Monday, it's a public holiday here today and won't be able to reply to the comments. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Nov 11 10:42:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 10:42:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442427.696574 (Exim 4.92) (envelope-from ) id 1otRU2-000359-1U; Fri, 11 Nov 2022 10:42:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442427.696574; Fri, 11 Nov 2022 10:42:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otRU1-000352-Td; Fri, 11 Nov 2022 10:42:01 +0000 Received: by outflank-mailman (input) for mailman id 442427; Fri, 11 Nov 2022 10:42:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otRU1-00034w-5q for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 10:42:01 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70043.outbound.protection.outlook.com [40.107.7.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 779c0ef6-61ad-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 11:41:58 +0100 (CET) Received: from AS9PR06CA0116.eurprd06.prod.outlook.com (2603:10a6:20b:465::26) by AS4PR08MB7508.eurprd08.prod.outlook.com (2603:10a6:20b:4fa::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 10:41:51 +0000 Received: from AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:465:cafe::d5) by AS9PR06CA0116.outlook.office365.com (2603:10a6:20b:465::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Fri, 11 Nov 2022 10:41:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT013.mail.protection.outlook.com (100.127.140.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 10:41:51 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Fri, 11 Nov 2022 10:41:51 +0000 Received: from 359a832b9bba.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EA777137-8E52-4DE8-B5ED-E12A1CCA4993.1; Fri, 11 Nov 2022 10:41:45 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 359a832b9bba.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 10:41:45 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by PA4PR08MB6158.eurprd08.prod.outlook.com (2603:10a6:102:e2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 10:41:43 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 10:41:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 779c0ef6-61ad-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nQY9NuMirQm7gMK46psNevGLcifgmC7QHT0wU8AFbCPP7fm/TMG3Ft6Q4MJk5RPZXEw0/nPJu9YRppzxcEpzAseOAiy2MkEkC2AdD7ekuplhMcPknCRnySb/u4cVm1vLGQ+lHFLzhTv2C0emVmtUATnYwV3Yp1Bgs8u7VMA5gTcWL016GMwtYjeAgrQUDZeTAx4hy0UpjaMhBdGApZ9UxBh77rSlIf4DIGvp3S2NrRZV/fTNRh6YrdXro5pEKYdgOyXhVswLZpHAlfdm3N+K/A4QB3L6/gGZZ2j91QQ+DmjtBO2WwnYvvBsIGJEzealm3uQRUxc6nzPV9HFrEoP5EA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ERJWhtGlLPpaSTkzlryZMpTsv33uMWawfDic7zG+PuU=; b=laPH6XOrR+4gBDUwpS4XEpY+RXOeNJHC38NGNYuOAbxjvfcRNU/VIEHc+jRQhgxdDCB/6s9+3Yk4berughyV+fXo/eNkWYHOF7e6A1X48R8BolQ/dU8AqTFUMoy+XWDXNK+W+IyE7n2gMxGi0STyQQuuk5pnZcYyoU3m0cE5BAMZ6tGOmh/rGw0myNcGmD1oz8XmzHubWiwqhO3k4Dq1W5R2luNIfxVmkSBlP+Jqa9/KQ9itznPr/C2M/gBnYkT/gkdugNFwYbbt6HeodC9rsfwxeVKyWXrotueHXBqHo+yPvwCi67zCLnBmOhXRnEcRF8487PjGHDbsw3KQyjTMvw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ERJWhtGlLPpaSTkzlryZMpTsv33uMWawfDic7zG+PuU=; b=eAJ5KIU82Y/TmmSWMlGSpOIkg/q9sXbERST14InOJm9csGes2hkji//3aSLSqhkazRybBHwBQ6iW/FY2xAMzKGDtW7iZQE4T/Y4bhqov+qyEyiDXHf936cN6mt8ni+04K2HjkEeYrXInyYpTLHVNImcERKN9wPQ0N7fuXXiZCRA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wbd/fN5ms09I/JT7luXAAQiPPW7MrvmvExEFYJsAsWx5CfIaMX6zcxLso9sQ/z6JhdGURpLTsuOl9yiNGmxqWLaidTzzYxYoTSjbLH5Uhnd1e18MYaQIFD7KVx6sitjT4fLWUn4jnqIJHe5vcGxMi1NOWXApLsTNHYK8Kyx2jajs/xu4HbrwSOvaXI219Ut7eO7CKIN4OqwiMKqVh/v+PK3xGxLxSdPewsOb/An9CJ8QTWStn+d3e/ERz2FF0XC5OOd/5IUIne/FqOOaQa6J2IArvgdbZt2gDe1xVc36rT1bBTu3aXpgjKUQ+EMCFF/3QzgHbbykYagtPrQorQV8Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ERJWhtGlLPpaSTkzlryZMpTsv33uMWawfDic7zG+PuU=; b=fjy3ScPBQW7kp3jLXcZUm8GFRbRFVEuzQs0JUWtO/XsEdMJjzdX/xgIjtTsZSpy2YdSzBBKtBIHX86aIBTqSmZr+r58ft3bbywqSmziaMVLuk7LtXYV6rqhcK4XE6L7uey+Cunh7Aww80LepjK2JnIo3rTVw3rrvy2CXBoMsVmVsK1N7rXISzOaQTvfg5p4bsfGZ0Rv17pauw6iBZxTP7U42tQgLIxvi1t5EXuusAsDWfotHITpDHszooX9YlvQOjiSwJW3xw5do7884TNSWNcXcoTudlYArZw9UtP6KC19IsOorwV0+fWlBmSMkB2VMb3Pf6i/jPc+RTy+BrXrHug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ERJWhtGlLPpaSTkzlryZMpTsv33uMWawfDic7zG+PuU=; b=eAJ5KIU82Y/TmmSWMlGSpOIkg/q9sXbERST14InOJm9csGes2hkji//3aSLSqhkazRybBHwBQ6iW/FY2xAMzKGDtW7iZQE4T/Y4bhqov+qyEyiDXHf936cN6mt8ni+04K2HjkEeYrXInyYpTLHVNImcERKN9wPQ0N7fuXXiZCRA= From: Wei Chen To: Stefano Stabellini CC: Julien Grall , "xen-devel@lists.xenproject.org" , nd , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 Thread-Topic: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 Thread-Index: AQHY8DVcKFNDls96akm0LlhB1cf9B64yRBkAgADyKCCAAA1MAIAAAWqggAWBUQCAAMY1wA== Date: Fri, 11 Nov 2022 10:41:43 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <9c3bfa0c-2c8f-2160-46d1-3be234b5bcaf@xen.org> <88c909b5-4cad-aab0-2acd-fb3519963128@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 62A7EE719CDB9044B34973E2CB774014.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|PA4PR08MB6158:EE_|AM7EUR03FT013:EE_|AS4PR08MB7508:EE_ X-MS-Office365-Filtering-Correlation-Id: e684e707-679f-4ffc-d742-08dac3d157b9 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jgq7Oc+5vpAsfo84VfMZj/7YGz5HJ5XqBTW/oBnlw8DuLfN1/TNN72e2E4aPNBxk1wXAWsAvOH/rSbQfioZG+B4KG7pRuiJwReThxL6hdwB21RE/KTg0amW97/Uju2dUcrDaAG+AStuBb3vRE2uTtQbfwBMmtU69KDQPt8YvnRgzl2cdr2rBMMCz9rWdGhuh6sZbCelLbIm7ruaiIRACf2mDliOnbUcBh1t4ka5U+g6bVsTa5A/sxFxKhjMvpMeYNtpAdlIUSf0e5glCT54I8VnydrApITp6pMvVHVdpv9Vr0BUE1hcW5DYasa8vtcReOPuWrKg3UUipCZpgH78AuMfd7+4ZwskMqIGwTgkK4MPHJQqJKip2NdZG7aB3I+gUVZlpdlRlMEmUCcfc1tT+KUoQR1gwGX995FeL7t2jf8N184VM/xEkUW3F+kamG29vToh5651+5fjT3KnCIOWIRyflLPEP5Li8ZBBb9TsmVbT6UJeQZ5x8WScAzDsdq02SRCVElI5krGLRexELl15D6Q8kDrPmYcjd23YnJE5VQwBbfbao5ivCuI8+laaCjY+SdkEooRNJfMwP5lHSWe4209Fd9xGvscDwS8UeG+kLk94Gb6SOvQMlyQMCZ035KF62g5yHLLMdjQ2UiuZjaszV5ufw9Sj6sD/3SOxF1jGOYBGuSK+i8OOntLhEWZyEvCgpr153TFrz3YApmfxJqM7KvSymvE1RJrZvRSlSOZ0wf3yy+mS+oaaQfLz6q3X243D9S499KYv+C/Vif5oivsUo0IZ+ZxQ5MwKwLp3nlCKvLD8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(396003)(39860400002)(136003)(346002)(451199015)(38070700005)(71200400001)(6916009)(54906003)(6506007)(316002)(122000001)(7696005)(2906002)(53546011)(38100700002)(33656002)(83380400001)(55016003)(52536014)(8936002)(478600001)(41300700001)(8676002)(5660300002)(4326008)(186003)(26005)(9686003)(76116006)(64756008)(66476007)(66446008)(66556008)(66946007)(86362001)(17413003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6158 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dff67ecd-d7de-40b7-bbf2-08dac3d1533d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iUBikSXuUxPaXA2U8chuagd2Nv0/Xw0zXI5tBEDSV0YBRJ5y3t8uWF4QXTm3kBIvvgOlFbR3/NmEu69nSUUM6u9FGJRM7Uj0lCV/Kc8gXoC5FlF5WD93Z9GwEt6+CuGzoXGHnMKxgQTnL5hP/PVCzsf0XzaicF9iO/AHMBDK89yMJHBYIKl0gBETtE+8OyJNGfhC9oToGLK039U6eJcjy5eNKYOGl8Uto4iem1h8voRMtbM5NDVoUoqE0Us2iX8CFjcPgZvM6YhHuNQdNAuDYhVUcqwk/ZVplLUJJlXac56oRr9VyAKLGEsm6DLJp/iE8cfrkxxMPoLEFdhzapnwzINjPDFf2XQ7F8ysuCGzu5fls8YX/772lnwvVz4eDyMabJXL2SU0ksTTulmwFGmCeubmnVkI8+i75YpZk7PlujcK3CmnQ2z6edPClJfCRLPej36x7c7pX1x95cqfVpkuLn58gtSCDkI3kZ0c9vGvvciEm2VltUnyYiBuQBYHi5T1UoQsFA+80l1jIbhQnhZEw17rdNLQSfbD6JSm9yUb/ZQ/r6ZY2TrRuAYLHJdvpEEvX9JJxnJssUoMaWz2VL05+OTVqC+gk9/2SgxkapWnf2GzHZOL2b13tziaW4rgGrTOxsGKAIpoDG/wMEksyoLX1DWbZGyqYPq1KSgVvuHP0mU3R/KsmFjY5K5w81wqZHPIdeRR/Vx79CYPFSLwx5QubaQPi9rHZWM/PWBda24R/LxxJ0UZlN5FuY3GZIPevLKSCHryvh5+gana9uELOZjW3B1AWphKGKRIzXqN1ErgqL8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(376002)(39860400002)(136003)(451199015)(40470700004)(36840700001)(46966006)(5660300002)(52536014)(6862004)(8936002)(4326008)(70586007)(70206006)(41300700001)(8676002)(2906002)(33656002)(83380400001)(47076005)(478600001)(40480700001)(336012)(40460700003)(107886003)(53546011)(7696005)(26005)(6506007)(186003)(55016003)(316002)(356005)(81166007)(82740400003)(9686003)(54906003)(36860700001)(86362001)(82310400005)(17413003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 10:41:51.2943 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e684e707-679f-4ffc-d742-08dac3d157b9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7508 SGkgU3RlZmFubywgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZy b206IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4gU2VudDog MjAyMuW5tDEx5pyIMTHml6UgNjoyNg0KPiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+ DQo+IENjOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsgeGVuLWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnOyBuZA0KPiA8bmRAYXJtLmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0 YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRyYW5kDQo+IE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1 aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVrDQo+IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFt LmNvbT4NCj4gU3ViamVjdDogUkU6IFtQQVRDSCB2NiAwMC8xMV0geGVuL2FybTogQWRkIEFybXY4 LVI2NCBNUFUgc3VwcG9ydCB0byBYZW4gLQ0KPiBQYXJ0IzENCj4gDQo+IE9uIE1vbiwgNyBOb3Yg MjAyMiwgV2VpIENoZW4gd3JvdGU6DQo+ID4gSGkgSnVsaWVuLA0KPiA+DQo+ID4gPiAtLS0tLU9y aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVu Lm9yZz4NCj4gPiA+IFNlbnQ6IDIwMjLlubQxMeaciDfml6UgMTg6MTYNCj4gPiA+IFRvOiBXZWkg Q2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0K PiA+ID4gQ2M6IG5kIDxuZEBhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGlu aUBrZXJuZWwub3JnPjsNCj4gQmVydHJhbmQNCj4gPiA+IE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1 aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVrDQo+ID4gPiA8Vm9sb2R5bXlyX0JhYmNodWtA ZXBhbS5jb20+DQo+ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIIHY2IDAwLzExXSB4ZW4vYXJtOiBB ZGQgQXJtdjgtUjY0IE1QVSBzdXBwb3J0IHRvDQo+IFhlbiAtDQo+ID4gPiBQYXJ0IzENCj4gPiA+ DQo+ID4gPg0KPiA+ID4NCj4gPiA+IE9uIDA3LzExLzIwMjIgMDk6NTIsIFdlaSBDaGVuIHdyb3Rl Og0KPiA+ID4gPiBIaSBKdWxpZW4sDQo+ID4gPg0KPiA+ID4gSGksDQo+ID4gPg0KPiA+ID4gPg0K PiA+ID4gPj4+ICAgIC0gU3VwcG9ydHMgb25seSBhIHNpbmdsZSBTZWN1cml0eSBzdGF0ZSAtIFNl Y3VyZS4NCj4gPiA+ID4+PiAgICAtIE1QVSBpbiBFTDEgJiBFTDIgaXMgY29uZmlndXJhYmxlLCBN TVUgaW4gRUwxIGlzIGNvbmZpZ3VyYWJsZS4NCj4gPiA+ID4+Pg0KPiA+ID4gPj4+IFRoZXNlIHBh dGNoIHNlcmllcyBhcmUgaW1wbGVtZW50aW5nIHRoZSBBcm12OC1SNjQgTVBVIHN1cHBvcnQNCj4g PiA+ID4+PiBmb3IgWGVuLCB3aGljaCBhcmUgYmFzZWQgb24gdGhlIGRpc2N1c3Npb24gb2YNCj4g PiA+ID4+PiAiUHJvcG9zYWwgZm9yIFBvcnRpbmcgWGVuIHRvIEFybXY4LVI2NCAtIERyYWZ0QyIg WzFdLg0KPiA+ID4gPj4+DQo+ID4gPiA+Pj4gV2Ugd2lsbCBpbXBsZW1lbnQgdGhlIEFybXY4LVI2 NCBhbmQgTVBVIHN1cHBvcnQgaW4gdGhyZWUgc3RhZ2VzOg0KPiA+ID4gPj4+IDEuIEJvb3QgWGVu IGl0c2VsZiB0byBpZGxlIHRocmVhZCwgZG8gbm90IGNyZWF0ZSBhbnkgZ3Vlc3RzIG9uIGl0Lg0K PiA+ID4gPj4NCj4gPiA+ID4+IEkgcmVhZCB0aGlzIGFzIEkgY2FuIGJ1aWxkIFhlbiBhbmQgc2Vl IGl0IGJvb3RzIChub3QgY3JlYXRpbmcNCj4gZG9tYWluKS4NCj4gPiA+ID4+IEhvd2V2ZXIuLi4g SEFTX01QVSBpcyBub3QgZGVmaW5lZCBhbmQgSSB3YXMgZXhwZWN0aW5nIG1tLmMgdG8gYmUNCj4g PiA+ID4+IG1vZGlmaWVkIHRvIGNhdGVyIHRoZSBNUFUgc3VwcG9ydC4gU28gSSBhbSBhIGJpdCBl bnN1cmUgd2hhdCB0aGUNCj4gc2VyaWVzDQo+ID4gPiA+PiBpcyBhY3R1YWxseSBkb2luZy4NCj4g PiA+ID4+DQo+ID4gPiA+DQo+ID4gPiA+IFRoZXNlIDExIHBhdGNoZXMgYXJlIHBhcnQjMSBvZiBz dGFnZSMxLCB0aGUgZnVsbCBzdGFnZSMxIGhhcyBhYm91dA0KPiAzMA0KPiA+ID4gPiBwYXRjaGVz LiBXZSBoYXZlIHNvbWUgY29uY2VybnMgaWYgd2Ugc2VuZCBzbyBtYW55IHBhdGNoZXMgYXQgb25j ZSwNCj4gdGhlDQo+ID4gPiA+IHJldmlldyBwcmVzc3VyZSBvZiBtYWludGFpbmVycyBtYXkgYmUg dmVyeSBoaWdoLCBzbyB3ZSBvbmx5IGNob29zZQ0KPiBhYm91dA0KPiA+ID4gPiAxMCB0byBzZW5k IGFzIHBhcnQgb2YgaXQuIEJ1dCB0aGlzIGFsc28gbWVhbnMgdGhhdCB3ZSBjYW4ndCBkbyBhDQo+ ID4gPiByZWxhdGl2ZWx5DQo+ID4gPiA+IGNvbXBsZXRlIHRoaW5nIGluIHRoaXMgcGFydCMxIHNl cmllcy4NCj4gPiA+ID4NCj4gPiA+ID4gV2Ugd2FudCB0byBoZWFyIHNvbWUgc3VnZ2VzdGlvbnMg ZnJvbSB5b3UgdG8gbWFrZSBzbyBtYW55IHBhdGNoZXMNCj4gY2FuIGJlDQo+ID4gPiA+IFJldmll d2VkIGVmZmljaWVudGx5LiBDYW4gd2Ugc2VuZCB0aGUgcGF0Y2hlcyBieSBzdGFnZXMsIGV2ZW4g dGhlDQo+ID4gPiBzdGFnZSMxDQo+ID4gPiA+IHdpbGwgaGF2ZSBhYm91dCAzMCBwYXRjaGVzPw0K PiA+ID4NCj4gPiA+IDMwIHBhdGNoZXMgaW4gYSBnbyBpcyBubyB0b28gYmFkLiBJIHdvdWxkIHBl cnNvbmFsbHkgcHJlZmVyIHRoYXQNCj4gYmVjYXVzZQ0KPiA+ID4gYXQgbGVhc3QgSSBoYXZlIGJl dHRlciBpZGVhIG9mIHRoZSBzaGFwZSBvZiB0aGUgY29kZSBhZnRlciBzdGFnZSMxIGFuZA0KPiA+ ID4gYWxzbyBwb3NzaWJseSB0ZXN0IGl0IChJIG5lZWQgdG8gY2hlY2sgaWYgSSBoYXZlIGFjY2Vz cyBmb3IgdGhlIEFSTXY4LQ0KPiBSDQo+ID4gPiBtb2RlbCkuDQo+ID4gPg0KPiA+DQo+ID4gSSBh bHNvIHByZWZlciB0byB0aGlzIHdheS4gQWZ0ZXIgd2UgaGF2ZSBhZGRyZXNzZWQgdGhlIGNvbW1l bnRzIGluDQo+ID4gdGhpcyBzZXJpZXMsIHdlIHdpbGwgc2VuZCB0aGUgZnVsbCBzdGFnZSMxIHBh dGNoZXMgdG9nZXRoZXIgaW4gdjIuDQo+IA0KPiANCj4gT25lIHN1Z2dlc3Rpb24gdG8gbWFrZSB0 aGluZ3MgZWFzaWVyIHRvIHJldmlldyBhbmQgdG8gY29tbWl0IGlzIHRvDQo+IG9yZ2FuaXplIHRo ZSBzZXJpZXMgaW4gYSB3YXkgc28gdGhhdCB0aGUgZmlyc3QgMTAgcGF0Y2hlcyBjYW4gc3RpbGwg YmUNCj4gY29tbWl0dGVkIGZpcnN0IGluZGVwZW5kZW50bHksIGV2ZW4gaWYgYWxsIDMwIHBhdGNo ZXMgYXJlIHNlbnQgdG9nZXRoZXIuDQo+IA0KDQpJIHRoaW5rIHRoaXMgaXMgZm9yZXNlZWFibGUs IGFuZCB3ZSBoYXZlIGRvbmUgaW4gdGhpcyB3YXkgaW50ZXJuYWxseS4NCkV2ZXJ5IHBhdGNoIGNh biBiZSBidWlsdCBhbmQgd2lsbCBub3QgYnJva2VuIG90aGVyIGFyY2hpdGVjdHVyZXMuDQoNCj4g T3IgYWx0ZXJuYXRpdmVseSBvbmx5IHNlbmQgMTAgcGF0Y2hlcyBidXQgYWxzbyBhZGQgYSBsaW5r IHRvIGENCj4gZ2l0aHViL2dpdGxhYiB0cmVlIHdpdGggYWxsIHRoZSAzMCsgcGF0Y2hlcyBzbyB0 aGF0IG1haW50YWluZXJzIGNhbiBoYXZlDQo+IGEgbG9vayBob3cgdGhlIHdob2xlIHdvcmsgZml0 IHRvZ2V0aGVyLg0KPiANCg0KSW4gdGhpcyBzZXJpZXMgd2UgaGF2ZSBsaW5rZWQgdGhlIGdpdGxh YiBicmFuY2ggd2l0aCB0aGUgZnVsbCBwYXRjaGVzLg0KDQo+IEkgdGhpbmsgd2UgYXJlIGFsbCBv biB0aGUgc2FtZSBwYWdlIC0tIEkganVzdCB3YW50ZWQgdG8gaGlnaGxpZ2h0IHRoYXQNCj4gd2Ug ZG9uJ3QgaGF2ZSB0byBmaW5pc2ggdGhlIHJldmlldyBvZiBhbGwgMzAgcGF0Y2hlcyBiZWZvcmUg d2UgY2FuIHN0YXJ0DQo+IGNvbW1pdHRpbmcgc29tZSBvZiB0aGUgaW5pdGlhbCBwYXRjaGVzIGlu IHRoZSBzZXJpZXMuDQo+IA0KDQpZZXMsIEkgYWdyZWUgd2l0aCBpdC4gQW5kIGFib3ZlIHNvbHV0 aW9ucyBhcmUgb2sgZm9yIHVzLiBUaGVyZSB3aWxsIG5vdA0KYmUgbXVjaCBkaWZmZXJlbmNlIGlu IGVmZm9ydHMgZm9yIHRoZXNlIHR3byB3YXlzIGZvciB1cywgc28gaWYgeW91IGd1eXMNCnRoaW5r IHdoaWNoIG1ldGhvZCBpcyB0aGUgbW9zdCBlZmZpY2llbnQsIEkgd2lsbCBmb2xsb3cgaXQuDQoN CkNoZWVycywNCldlaSBDaGVuDQoNCj4gQ2hlZXJzLA0KPiANCj4gU3RlZmFubw0K From xen-devel-bounces@lists.xenproject.org Fri Nov 11 10:42:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 10:42:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442429.696585 (Exim 4.92) (envelope-from ) id 1otRUQ-0003X0-D9; Fri, 11 Nov 2022 10:42:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442429.696585; Fri, 11 Nov 2022 10:42:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otRUQ-0003Wt-A5; Fri, 11 Nov 2022 10:42:26 +0000 Received: by outflank-mailman (input) for mailman id 442429; Fri, 11 Nov 2022 10:42:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otRUO-00034w-RN for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 10:42:25 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2042.outbound.protection.outlook.com [40.107.104.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86782a2e-61ad-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 11:42:23 +0100 (CET) Received: from DB6PR0501CA0046.eurprd05.prod.outlook.com (2603:10a6:4:67::32) by GV2PR08MB8654.eurprd08.prod.outlook.com (2603:10a6:150:b6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Fri, 11 Nov 2022 10:42:21 +0000 Received: from DBAEUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:67:cafe::ea) by DB6PR0501CA0046.outlook.office365.com (2603:10a6:4:67::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Fri, 11 Nov 2022 10:42:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT012.mail.protection.outlook.com (100.127.142.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 10:42:20 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Fri, 11 Nov 2022 10:42:20 +0000 Received: from 658ffd5b839d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 52671418-F9C9-49F7-AE47-0ED738A1033B.1; Fri, 11 Nov 2022 10:42:09 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 658ffd5b839d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 10:42:09 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by GV2PR08MB9278.eurprd08.prod.outlook.com (2603:10a6:150:e1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Fri, 11 Nov 2022 10:42:05 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893%4]) with mapi id 15.20.5813.012; Fri, 11 Nov 2022 10:42:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86782a2e-61ad-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=SkpmSBBZPhVoym0EZ5q2Wkf3yCE3a2KrUySIye7wC5MdC8zwEXeuvFuyedp6R3ibuKgiUitF8jWkn6XWLVMcKbpFLfPXCNlmShg8TLYz0fWmsBL45q6aU1P5cAoI69tJMmyaia9bFvbQMjd8kVErrWxx0L7KCjYyfsrFoRQjwAl+Onx6R/f8rD7PVAHUpO/w/kILDKjBt7yXwIU4BMeS7EvVJFOAyyUAHfXYbxEZ1Temdqe50bL5aBer1c4vK8tx2iVdvHPZ3fJg2D836MYhrX8LpIMECtuNrxTc3rTjP5ikBBmFebPdiEmunrF6vkWQFcyLymy6aZV3V0mQxZxnOg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JiXdLH3PAjg8XG2TJLnwfb8ZEzGzKAHNOgYAh9D1JcA=; b=dSw/o1lKV8q8WtTse84RSo7cem6RYf1NzGwYj2G2rQvN1avFLmvEGfykq69wpe1DBF80t+4QYG+26Ijg3xhqGJv1aUA62kQUaYyZ6anZdS26iNnruX4j7ndoIrcpGy3T8XrCaxi9Ba/F1hhk7HsD5N0BBjUfBNdyc8QrgGHMVuKDUT1d5m9tZS00iWl/v39yOZRPlpNjsa4Ft9kBsnNmbiUtJ95HLAVD+mKFo9YHUmQkh4Q1yLxDglES2MQHIWemvYWHZvZiHGmvVMbC55eUW0013RMHgBpGBTKopdzHYoxSDvwZM+8GItkV/0wvsHyOTaPwQ086L2/s2tht+kbrYg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JiXdLH3PAjg8XG2TJLnwfb8ZEzGzKAHNOgYAh9D1JcA=; b=CE2D5TRguFndTnGL6kyBTLdOE7nkbbQCe96+qflxN9wIeDDPADhnNgDpCrLOHR/QXyuRh0J0DP9TNT0PK5/lPTQVAFDXJZBWzBDNLq6AhWJeUkeg/zx5rqIXzKG/dZSjrMNydbLIKaX8SxY/wmvi53iiNNJJt1QUCWuRWEVr3Zk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a1aabf630d7c27ec X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l35MnVZn/JGQ2r4G/otS18uvqJ3+Gu9ar11tGc4iQmSxZSfFwrnwFJS8mp1FOi24lo5w1yuzxD+g8UvVFQuee62byYieBP0N9PZviN4UNvJ8aV2Qz+wYRnXNkFsYnN6GzXePY1LjBDI9kz2t+xdF+GTwpTsjOPK/ZeNFyFe4smpwaFeUQ9teoyGKRy2QVGWUX/UR0Xo3CJ5cSkTqhEG6CuxQUQB7MSXfFckKFfv87xy1NKfJibpy7bKuekPdf5ZtEHC4ULLuRXFVYGDQIk7zE53HGWNTcTmQ871inXe+27RcY1cDgY0u1zpczZDCN5RosUSoZFGHGgp/0esVw2azpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JiXdLH3PAjg8XG2TJLnwfb8ZEzGzKAHNOgYAh9D1JcA=; b=kntYio/jafOGfe6tjQK2p7kYLXMcHberkG+6GOrDgyB6uxXBNSIx3PKni03iBfrNXXf2LzBFah4HgEW9VXP5pW7GdOxt4DFhtJjCX+9CCQqMVloLG/Ss3q8Gi4dCrdlAngc5gYraeqM6lUu9j+44YD4uY2lD0OHeCQleDUc1jILjH1OsDc/utxEvBCuXSywmJUyYP+879a9ghkuEj6/kCa5AOm0klz2ueMVTQb2jsYAy0LeuHd9YXfx2Mb/vUGR9wCbNhgoGnFH+nbmIdLAWOy5T0P/R4WdSSu8fVCKzwaniS868a9EBXMzEMpKTjLztSDi1lIPBudr+fNYumZ8M8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JiXdLH3PAjg8XG2TJLnwfb8ZEzGzKAHNOgYAh9D1JcA=; b=CE2D5TRguFndTnGL6kyBTLdOE7nkbbQCe96+qflxN9wIeDDPADhnNgDpCrLOHR/QXyuRh0J0DP9TNT0PK5/lPTQVAFDXJZBWzBDNLq6AhWJeUkeg/zx5rqIXzKG/dZSjrMNydbLIKaX8SxY/wmvi53iiNNJJt1QUCWuRWEVr3Zk= From: Luca Fancellu To: Jan Beulich CC: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Thread-Topic: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Thread-Index: AQHY8pZ008DS0BACDkyhs+OWN8Oan64zqLWAgAE0WoCAAA3SgIAAJOMAgAAeVoCAABeCgIABAHkAgAAbOoCAAAfgAIADJhyA Date: Fri, 11 Nov 2022 10:42:04 +0000 Message-ID: References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> <7d56c33d-4b03-9aa1-6abc-45a8ad41caca@suse.com> <2E0BFEFC-5BEE-4F8B-BD9E-94CB9A5B2BC9@arm.com> <9CE2A214-2D64-4BEC-A78B-393BF7AEDD9D@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|GV2PR08MB9278:EE_|DBAEUR03FT012:EE_|GV2PR08MB8654:EE_ X-MS-Office365-Filtering-Correlation-Id: 06d92d13-d777-4180-e5a4-08dac3d16921 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +DBRUu+UgrofU6PnK73VwYl8uxStoUsG/PNkJuURpyxVj9rOZkVfLCnZytTH8HsQRaKIG6Y1WApZL5WFwyklFcpeBYmbWBAQ+Lqa6x+i5E45FOAEGTQnDNtvpLtTma22an0b3SRFgpUPfReAGYmwKCDT2QNU2kSPkrNnLPx2lQsl4TRtBzlMjDjfeSNgQQfS4f9XS2xjR/dtOTsCPnPkY7zc6XM/xj8mLgzIiQIsATStFLFwY0JhzIquK8vUKGvg/93cZnLBE+0mHhjJjTJo1pone27QxuzC5BnPtriIL6trsm22FsiV1FLUq16iy8lcjE2iNVf68J27YTQjOdUK/UnJM3KI97N+6BpHVm1lyZFmrQOs4F5jtRwERKPKRGZ6j+yKofGN5iuVG9R9a8RCmxYc/dJS+8UEZpk4/LXJK+bLmE/8zJrd3pCjKB4TwH3A6OVvUstxO36HW3ieR05tZtGBB93xMT6JoZA8q8qsaA61cImBiIJN5AMbqFkFJUlRRqz6UKS7D2nnctPaddV0e4+0RjdcD01j2NrHNvoXVcE2GL09bUP4puY3F5wQmBopal+2CClhLW8lY3K7PAdvMtBHmJJ7A36rzZs9D0ZPMWfQi/MJ6ltLpzYWVOzAwt4YprBsWXbNzyGYlTZiZAb7geL73iuaPxYlkow94xMwvwrcqcaVVmXBDW7E1ey8sSb4BZqwvkxVkQKFXKodT9K/3jZm5E9cVfXRD71ZZgqQK3+HEcIHL2AESFjNcED8GKTyDSOj03V/1Aj0PuW0YKKzIJY0x697k2/xhDqGVJjIwro= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(366004)(39860400002)(396003)(451199015)(83380400001)(76116006)(186003)(6512007)(2906002)(316002)(53546011)(8936002)(41300700001)(5660300002)(6916009)(36756003)(478600001)(6486002)(6506007)(26005)(33656002)(122000001)(2616005)(66446008)(66946007)(38070700005)(66476007)(91956017)(54906003)(8676002)(71200400001)(66556008)(86362001)(38100700002)(4326008)(64756008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <1BFEA80D0EF0134C9DFE8999D44DF305@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9278 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1aefce9b-05a2-4149-2355-08dac3d15f7a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nCsSXTCTaklvMBoyCGOugGnullxo5BCtoUoJO5jc8098vCqtiN7cUhdW+z/zc0+4VD0bPEi0aVk8tYxpS9yjiJeDjsS/NBVgHqz7pg0InVjuMO7y1OKBPcIex5/aLKebzJKzNV6tBpJFD8phFEVk9/6OU2cQIfxX6h5KrCsI31D37PpJNJ75H5q0QIbi3QQOHfk6bFlliv4iNAKbD3fND8IWrP6preZxDsm25RO1O/fGjFC+haxKM61fWmhOO5zMYe8xv2aRwxZwO4gFgs9itTD1iXJJbxt3Z65v+S+Xkw9snGMUTyKHrtc9It7bXLAYwaBQoycs/2jAHb7iUbVDV5CNrrNW6gtb/Xw4v7n5IrzQ71UaoouNviavWFlr9Ly/7KA08lEyOv26B6aqpKEn2mlMnjvtm5On4uJd4/BbEO2lZbl8JrPJgj1Eqvsow1LO1DAXCs7ZAEteEwU8S/Bic7TWLy/bNeXkaJU0uTwv9/o+H3TP9am/a2B0YCpGeEpi8y+BRjWSsswmqMOUKYJ3YnOInTo5t4kJbbcx72iabqx6GL5UwwRe6FEnFK6qXeDHiR6yEkTZx4XBwmDUlpy0rbAh2s9pqaGr4ByH+SIwTEFw9g8WE2hKPYnJkv2b5gHlOZx9oNG0IOWGOzz48ZChILL1x66MLfo22iGmUSKk+cq5U4lsyW9uKuSrH5lGq2XHlYUD9NYBY2pGoBC49pKfY9P3TjwCfTjhQXFlUbleAkXEvQiqKeUPpCfXPSQKFdD1hULUkj297hau2+f82aLszw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199015)(36840700001)(40470700004)(46966006)(6512007)(478600001)(316002)(36756003)(8676002)(5660300002)(33656002)(6862004)(8936002)(36860700001)(53546011)(26005)(336012)(82740400003)(6506007)(40480700001)(186003)(40460700003)(86362001)(2906002)(70586007)(70206006)(6486002)(356005)(4326008)(2616005)(47076005)(54906003)(41300700001)(82310400005)(83380400001)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 10:42:20.5600 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06d92d13-d777-4180-e5a4-08dac3d16921 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8654 DQoNCj4gT24gOSBOb3YgMjAyMiwgYXQgMTA6MzYsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwOS4xMS4yMDIyIDExOjA4LCBMdWNhIEZhbmNlbGx1IHdy b3RlOg0KPj4+PiBPbiAwNy4xMS4yMDIyIDExOjQ3LCBMdWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4+ Pj4gK0hlcmUgaXMgYW4gZXhhbXBsZSB0byBhZGQgYSBuZXcganVzdGlmaWNhdGlvbiBpbiBmYWxz ZS1wb3NpdGl2ZS08dG9vbD4uanNvbjo6DQo+Pj4+IA0KPj4+PiBXaXRoIDx0b29sPiBhbHJlYWR5 IHByZXNlbnQgaW4gdGhlIG5hbWUsIC4uLg0KPj4+PiANCj4+Pj4+ICt8ew0KPj4+Pj4gK3wgICAg InZlcnNpb24iOiAiMS4wIiwNCj4+Pj4+ICt8ICAgICJjb250ZW50IjogWw0KPj4+Pj4gK3wgICAg ICAgIHsNCj4+Pj4+ICt8ICAgICAgICAgICAgImlkIjogIlNBRi0wLWZhbHNlLXBvc2l0aXZlLTx0 b29sPiIsDQo+Pj4+PiArfCAgICAgICAgICAgICJhbmFseXNlciI6IHsNCj4+Pj4+ICt8ICAgICAg ICAgICAgICAgICI8dG9vbD4iOiAiPHByb3ByaWV0YXJ5LWlkPiINCj4+Pj4gDQo+Pj4+IC4uLiBj YW4gd2UgYXZvaWQgdGhlIHJlZHVuZGFuY3kgaGVyZT8gUGVyaGFwcyAuLi4NCj4+Pj4gDQo+Pj4+ PiArfCAgICAgICAgICAgIH0sDQo+Pj4+PiArfCAgICAgICAgICAgICJ0b29sLXZlcnNpb24iOiAi PHZlcnNpb24+IiwNCj4+Pj4gDQo+Pj4+IC4uLiBpdCBjb3VsZCBiZQ0KPj4+PiANCj4+Pj4gICAg ICAgICAgImFuYWx5c2VyIjogew0KPj4+PiAgICAgICAgICAgICAgIjx2ZXJzaW9uPiI6ICI8cHJv cHJpZXRhcnktaWQ+Ig0KPj4+PiAgICAgICAgICB9LA0KPj4gDQo+PiBBYm91dCB0aGlzLCBJ4oCZ dmUgaW52ZXN0aWdhdGVkIGEgYml0IGFuZCBJIGRvbuKAmXQgdGhpbmsgdGhpcyBpcyB0aGUgcmln aHQgc29sdXRpb24sIGl0IHdvdWxkbid0IG1ha2UNCj4+IG11Y2ggc2Vuc2UgdG8gaGF2ZSBhIHNj aGVtYSB3aGVyZSBpbiBvbmUgZmlsZSB0aGUgYW5hbHlzZXIgZGljdGlvbmFyeSBrZXkgaXMgdGhl IHRvb2wgbmFtZQ0KPj4gYW5kIGluIGFub3RoZXIgaXQgaXMgYSB2ZXJzaW9uIChvciByYW5nZSBv ZiB2ZXJzaW9ucykuDQo+PiANCj4+IEhvd2V2ZXIgSSBjYW4gcmVtb3ZlIHRoZSBhbmFseXNlciBk aWN0aW9uYXJ5IGFuZCB1c2UgdGhpcyBzY2hlbWEgZm9yIHRoZSBmYWxzZS1wb3NpdGl2ZSwgd2hp Y2ggaXMNCj4+IG1vcmUgY29tcGFjdDoNCj4+IA0KPj4gfHsNCj4+IHwgICAgInZlcnNpb24iOiAi MS4wIiwNCj4+IHwgICAgImNvbnRlbnQiOiBbDQo+PiB8ICAgICAgICB7DQo+PiB8ICAgICAgICAg ICAgImlkIjogIlNBRi0wLWZhbHNlLXBvc2l0aXZlLTx0b29sPiIsDQo+PiB8ICAgICAgICAgICAg 4oCcdG9vbC1wcm9wcmlldGFyeS1pZOKAnTogIjxwcm9wcmlldGFyeS1pZD7igJ0sDQo+PiB8ICAg ICAgICAgICAgInRvb2wtdmVyc2lvbiI6ICI8dmVyc2lvbj4iLA0KPj4gfCAgICAgICAgICAgICJu YW1lIjogIlIyMC43IFsuLi5dIiwNCj4+IHwgICAgICAgICAgICAidGV4dCI6ICJbLi4uXSINCj4+ IHwgICAgICAgIH0sDQo+PiB8ICAgICAgICB7DQo+PiB8ICAgICAgICAgICAgImlkIjogIlNBRi0x LWZhbHNlLXBvc2l0aXZlLTx0b29sPiIsDQo+PiB8ICAgICAgICAgICAg4oCcdG9vbC1wcm9wcmll dGFyeS1pZOKAnTogIiIsDQo+PiB8ICAgICAgICAgICAgInRvb2wtdmVyc2lvbiI6ICIiLA0KPj4g fCAgICAgICAgICAgICJuYW1lIjogIlNlbnRpbmVsIiwNCj4+IHwgICAgICAgICAgICAidGV4dCI6 ICJOZXh0IElEIHRvIGJlIHVzZWQiDQo+PiB8ICAgICAgICB9DQo+PiB8ICAgIF0NCj4+IHx9DQo+ PiANCj4+IFRoaXMgbmVlZHMgaG93ZXZlciBhIGNoYW5nZSBpbiB0aGUgaW5pdGlhbCBkZXNpZ24g YW5kIG1vcmUgZG9jdW1lbnRhdGlvbiBvbiB0aGUgZGlmZmVyZW50IGhhbmRsaW5ncw0KPj4gb2Yg dGhlIHNhZmUuanNvbiBzY2hlbWEgYW5kIHRoZSBmYWxzZS1wb3NpdGl2ZS08dG9vbD4uanNvbiBz Y2hlbWEuIElzIGl0IHdvcnRoPw0KPiANCj4gSSB0aGluayBpdCBpcywgYnV0IG9mIG90aGVycyBk aXNhZ3JlZSwgc28gYmUgaXQuDQoNClNvLCBzaW5jZSBubyBvbmUgcmVwbGllZCBvbiB0aGF0LCBJ IHRoaW5rIGV2ZXJ5Ym9keSBhZ3JlZXMgdGhhdCBzYWZlIGFuZCBmYWxzZS1wb3NpdGl2ZSBjYW4g aGF2ZSBhIGRpZmZlcmVudCBzY2hlbWEsDQpJIHdpbGwgdXBkYXRlIHRoZSBweXRob24gdG9vbCB0 byBoYW5kbGUgdGhhdCBhbmQgSSB3aWxsIHVwZGF0ZSB0aGUgbWFrZSByZWNpcGUgY29uc2VxdWVu dGx5Lg0KDQo+Pj4+PiANCj4+Pj4+IEhtbSwgbm90IHN1cmU6IC0taW5jbHVkZSBpc24ndCBhIHN0 YW5kYXJkIG9wdGlvbiB0byBncmVwLCBhbmQgd2UNCj4+Pj4+IGdlbmVyYWxseSB0cnkgdG8gYmUg cG9ydGFibGUuIEFjdHVhbGx5IC1SIChvciAtcikgaXNuJ3QgZWl0aGVyLiBJdA0KPj4+Pj4gbWF5 IHN0aWxsIGJlIG9rYXkgdGhhdCB3YXkgaWYgcHJvcGVybHkgZG9jdW1lbnRlZCB3aGVyZSB0aGUg aW52b2x2ZWQNCj4+Pj4+IGdvYWxzIHdpbGwgd29yayBhbmQgd2hlcmUgbm90Lg0KPj4+PiANCj4+ Pj4gSXMgYSBjb21tZW50IGJlZm9yZSB0aGUgbGluZSBvayBhcyBkb2N1bWVudGF0aW9uPyBUbyBz dGF0ZSB0aGF0IOKAlGluY2x1ZGUgYW5kDQo+Pj4+IC1SIGFyZSBub3Qgc3RhbmRhcmQgb3B0aW9u cyBzbyBhbmFseXNpcy17Y292ZXJpdHksZWNsYWlyfSB3aWxsIG5vdCB3b3JrIHdpdGhvdXQgYQ0K Pj4+PiBncmVwIHRoYXQgdGFrZXMgdGhvc2UgcGFyYW1ldGVycz8NCj4+PiANCj4+PiBBIGNvbW1l bnQgX21pZ2h0XyBiZSBva2F5LiBJcyB0aGVyZSBubyBvdGhlciBkb2N1bWVudGF0aW9uIG9uIGhv dyB0aGVzZQ0KPj4+IGdvYWxzIGFyZSB0byBiZSB1c2VkPyBUaGUgbWFpbiBxdWVzdGlvbiBoZXJl IGlzIGhvdyBpbXBhY3RpbmcgdGhpcyBtaWdodA0KPj4+IGJlIHRvIHRoZSB2YXJpb3VzIGVudmly b25tZW50cyB3ZSBhbGxvdyBYZW4gdG8gYmUgYnVpbHQgaW46IFdvdWxkIGF0DQo+Pj4gbGVhc3Qg bW9kZXJuIHZlcnNpb25zIG9mIGFsbCBMaW51eCBkaXN0cm9zIHdlIGNhcmUgYWJvdXQgYWxsb3cg dXNpbmcNCj4+PiB0aGVzZSBydWxlcz8gV2hhdCBhYm91dCBub24tTGludXg/DQo+Pj4gDQo+Pj4g QW5kIGNvdWxkIHlvdSBhdCBsZWFzdCBiYWlsIHdoZW4gUEFSU0VfRklMRV9MSVNUIGVuZHMgdXAg ZW1wdHksIHdpdGggYQ0KPj4+IGNsZWFyIGVycm9yIG1lc3NhZ2UgYXVnbWVudGluZyB0aGUgb25l IGdyZXAgd291bGQgaGF2ZSBpc3N1ZWQ/DQo+PiANCj4+IEFuIGVtcHR5IFBBUlNFX0ZJTEVfTElT VCBzaG91bGQgbm90IGdlbmVyYXRlIGFuIGVycm9yLCBpdCBqdXN0IG1lYW5zIHRoZXJlIGFyZSBu bw0KPj4ganVzdGlmaWNhdGlvbnMsIGJ1dCBJIHNlZSBpdCBjYW4gYmUgcHJvYmxlbWF0aWMgaW4g Y2FzZSBncmVwIGRvZXMgbm90IHdvcmsuDQo+PiANCj4+IFdoYXQgYWJvdXQgdGhpcz8gVGhleSBz aG91bGQgYmUgc3RhbmRhcmQgb3B0aW9ucyByaWdodD8NCj4+IA0KPj4gUEFSU0VfRklMRV9MSVNU IDo9ICQoYWRkc3VmZml4IC5zYWZwYXJzZSwkKHNoZWxsIGZpbmQgJChzcmN0cmVlKSAtdHlwZSBm IFwNCj4+ICAgIC1uYW1lICcqLmMnIC1vIC1uYW1lICcqLmgnIC1leGVjIFwNCj4+ICAgIGdyZXAg LUVsICdeW1s6Ymxhbms6XV0qXC9cKltbOnNwYWNlOl1dK1NBRi0uKlwqXC8kJCcge30gKyApKQ0K PiANCj4gQ29taW5nIGNsb3NlciB0byBiZWluZyBnZW5lcmFsbHkgdXNhYmxlLiBZb3Ugbm93IGhh dmUgdGhlIHByb2JsZW0gb2YNCj4gcG90ZW50aWFsbHkgZXhjZWVkaW5nIGNvbW1hbmQgbGluZSBs aW1pdHMgKGlpcmMgdGhlcmUgd2VyZSBpc3N1ZXMgaW4NCj4gZmluZCBhbmQvb3Iga2VybmVscyks IGJ1dCBJIGFncmVlIGl0IGxvb2tzIHN0YW5kYXJkLWNvbmZvcm1pbmcgbm93Lg0KPiANCj4+Pj4+ IEFuZCB0aGVuIC0gd2h5IGRvIHlvdSBlc2NhcGUgc2xhc2hlcyBpbiB0aGUgRVJFPw0KPj4+Pj4g DQo+Pj4+PiBUYWxraW5nIG9mIGVzY2FwaW5nIC0gcGVyc29uYWxseSBJIGZpbmQgYmFja3NsYXNo IGVzY2FwZXMgaGFyZGVyIHRvDQo+Pj4+PiByZWFkIC8gZ3JvayB0aGFuIHF1b3RhdGlvbiwgc28g SSdkIGxpa2UgdG8gcmVjb21tZW5kIHVzaW5nIHF1b3Rlcw0KPj4+Pj4gYXJvdW5kIGVhY2ggb2Yg dGhlIHR3byAtLWluY2x1ZGUgKGlmIHRoZXkgcmVtYWluIGluIHRoZSBmaXJzdCBwbGFjZSkNCj4+ Pj4+IGluc3RlYWQgb2YgdGhlIFwqIGNvbnN0cnVjdC4NCj4+Pj4gDQo+Pj4+IE9rIEnigJl2ZSBy ZW1vdmVkIHRoZSBlc2NhcGUgZnJvbSB0aGUgKiBhbmQgYWxzbyBmcm9tIHNsYXNoZXM6DQo+Pj4+ IA0KPj4+PiBQQVJTRV9GSUxFX0xJU1QgOj0gJChhZGRzdWZmaXggLnNhZnBhcnNlLCQoc2hlbGwg Z3JlcCAtRVJsIC0taW5jbHVkZT0nKi5oJyBcDQo+Pj4+ICAgLS1pbmNsdWRlPScqLmMnICdeW1s6 Ymxhbms6XV0qL1wqW1s6c3BhY2U6XV0rU0FGLS4qXCovJCQnICQoc3JjdHJlZSkpKQ0KPj4+IA0K Pj4+IEdvb2QgLSBzZWVpbmcgdGhpbmdzIG1vcmUgY2xlYXJseSBub3cgbXkgbmV4dCBxdWVzdGlv biBpczogSXNuJ3QNCj4+PiBtYXRjaGluZyBqdXN0ICIvKiBTQUYtLi4uKi8iIGEgbGl0dGxlIHRv byBsYXg/IEFuZCBpcyB0aGVyZSByZWFsbHkgYQ0KPj4+IG5lZWQgdG8gcGVybWl0IGxlYWRpbmcg YmxhbmtzPw0KPj4gDQo+PiBJ4oCZbSBwZXJtaXR0aW5nIGJsYW5rcyB0byBhbGxvdyBzcGFjZXMg b3IgdGFicywgemVybyBvciBtb3JlIHRpbWVzIGJlZm9yZSB0aGUgc3RhcnQgb2YNCj4+IHRoZSBj b21tZW50LCBJIHRoaW5rIGl0IHNoYWxsIGJlIGxpa2UgdGhhdC4NCj4gDQo+IEhtbSwgSSB3aXRo ZHJhdyBteSBxdWVzdGlvbiByZWFsaXppbmcgdGhhdCB5b3Ugd2FudCB0aGVzZSBjb21tZW50cw0K PiBpbmRlbnRlZCB0aGUgc2FtZSBhcyB0aGUgbGluZSB0aGV5IHJlbGF0ZSB0by4NCj4gDQo+PiBB Ym91dCBtYXRjaGluZywgbWF5YmUgSSBjYW4gbWF0Y2ggYWxzbyB0aGUgbnVtYmVyIGFmdGVyIFNB Ri0sIHRoaXMgc2hvdWxkIGJlIGVub3VnaCwNCj4+IA0KPj4gW+KApl0gZ3JlcCAtRWwgJ15bWzpi bGFuazpdXSpcL1wqW1s6c3BhY2U6XV0rU0FGLVswLTldKy4qXCpcLyQk4oCZIFvigKZdDQo+IA0K PiBJJ2QgbGlrZSB0byBzdWdnZXN0IHRvIGdvIG9uZSB0aW55IHN0ZXAgZnVydGhlciAoYW5kIG9u Y2UgYWdhaW4gdG8NCj4gZHJvcCB0aGUgZXNjYXBpbmcgb2Ygc2xhc2hlcyk6DQo+IA0KPiAnXltb OmJsYW5rOl1dKi9cKltbOnNwYWNlOl1dK1NBRi1bMC05XSstLipcKi8kJCcNCg0KSSBhZ3JlZSwg SSB3aWxsIHVzZSB0aGlzIG9uZSB0aGF0IGlzIHNhZmVyIGFuZCBpbmNsdWRlcyB5b3VyIHN1Z2dl c3Rpb25zOg0KDQpQQVJTRV9GSUxFX0xJU1QgOj0gJChhZGRzdWZmaXggLnNhZnBhcnNlLCQoc2hl bGwgZmluZCAkKHNyY3RyZWUpIC10eXBlIGYgXA0KICAgIC1uYW1lICcqLmMnIC1vIC1uYW1lICcq LmgnIC1leGVjIFwNCiAgICBncmVwIC1FbCAnXltbOmJsYW5rOl1dKi9cKltbOnNwYWNlOl1dK1NB Ri1bMC05XSstLipcKi8kJCcge30gXDsgKSkNCg0KPiANCj4+Pj4gTm93IGFuYWx5c2lzLWJ1aWxk LWNvdmVyaXR5IHdpbGwgYmUgY2FsbGVkLCB0aGUgYmVzdCBtYXRjaCBpcyBhbmFseXNpcy1idWls ZC0lLCBzbyBhZ2FpbiB0aGUgZGVwZW5kZW5jeQ0KPj4+PiB3aGljaCBpcyBhbmFseXNpcy1wYXJz ZS10YWdzLSUsIHdpbGwgYmUgdHJhbnNsYXRlZCB0byBhbmFseXNpcy1wYXJzZS10YWdzLWNvdmVy aXR5Lg0KPj4+PiANCj4+Pj4gTm93IGFuYWx5c2lzLXBhcnNlLXRhZ3MtY292ZXJpdHkgd2lsbCBi ZSBjYWxsZWQsIHRoZSBiZXN0IG1hdGNoIGlzIGFuYWx5c2lzLXBhcnNlLXRhZ3MtJSwgc28gdGhl ICUgd2lsbA0KPj4+PiBIYXZlIHRoZSDigJhjb3Zlcml0eeKAmSB2YWx1ZSBhbmQgaW4gdGhlIGRl cGVuZGVuY3kgd2Ugd2lsbCBoYXZlICQob2JqdHJlZSkvJS5zZWQgLT4gJChvYmp0cmVlKS9jb3Zl cml0eS5zZWQuDQo+Pj4+IA0KPj4+PiBMb29raW5nIGZvciAkKG9ianRyZWUpL2NvdmVyaXR5LnNl ZCB0aGUgYmVzdCBtYXRjaCBpcyAkKG9ianRyZWUpLyUuc2VkLCB3aGljaCB3aWxsIGhhdmUgJChK VVNUSUZJQ0FUSU9OX0ZJTEVTKQ0KPj4+PiBhbmQgdGhlIHB5dGhvbiBzY3JpcHQgaW4gdGhlIGRl cGVuZGVuY3ksIGhlcmUgd2Ugd2lsbCB1c2UgdGhlIHNlY29uZCBleHBhbnNpb24gdG8gc29sdmUN Cj4+Pj4gJChYRU5fUk9PVCkvZG9jcy9taXNyYS9mYWxzZS1wb3NpdGl2ZS0kJCouanNvbiBpbiAk KFhFTl9ST09UKS9kb2NzL21pc3JhL2ZhbHNlLXBvc2l0aXZlLWNvdmVyaXR5Lmpzb24NCj4+Pj4g DQo+Pj4+IFNvIG5vdyBhZnRlciBhbmFseXNpcy1wYXJzZS10YWdzLWNvdmVyaXR5IGhhcyBlbmRl ZCBpdHMgZGVwZW5kZW5jeSBpdCB3aWxsIHN0YXJ0IHdpdGggaXRzIHJlY2lwZSwgYWZ0ZXIgaXQg ZmluaXNoZXMsDQo+Pj4+IHRoZSByZWNpcGUgb2YgYW5hbHlzaXMtYnVpbGQtY292ZXJpdHkgd2ls bCBzdGFydCBhbmQgaXQgd2lsbCBjYWxsIG1ha2UgdG8gYWN0dWFsbHkgYnVpbGQgWGVuLg0KPj4+ IA0KPj4+IE9rYXksIEkgc2VlIG5vdyAtIHRoaXMgYnVpbGRpbmcgb2YgWGVuIHJlYWxseSBfaXNf IGluZGVwZW5kZW50IG9mIHRoZQ0KPj4+IGNoZWNrZXIgY2hvc2VuLiBJJ20gbm90IHN1cmUgdGhv dWdoIHdoZXRoZXIgaXQgaXMgYSBnb29kIGlkZWEgdG8NCj4+PiBpbnRlZ3JhdGUgYWxsIHRoaXMs IGluY2x1ZGluZyAuLi4NCj4+PiANCj4+Pj4gQWZ0ZXIgdGhlIGJ1aWxkIGZpbmlzaGVzLCBpZiB0 aGUgc3RhdHVzIGlzIGdvb2QsIHRoZSBhbmFseXNpcy1idWlsZC1jb3Zlcml0eSBoYXMgZmluaXNo ZWQgYW5kIHRoZSBfYW5hbHlzaXMtY292ZXJpdHkNCj4+Pj4gcmVjaXBlIGNhbiBub3cgcnVuLCBp dCB3aWxsIGNhbGwgbWFrZSB3aXRoIHRoZSBhbmFseXNpcy1jbGVhbiB0YXJnZXQsIHJlc3Rvcmlu ZyBhbnkgPGZpbGU+LntjLGh9LnNhZnBhcnNlIHRvIDxmaWxlPi57YyxofS4NCj4+PiANCj4+PiAu Li4gdGhlIHN1YnNlcXVlbnQgY2xlYW5pbmcuIFRoZSBzdGF0ZSBvZiB0aGUgX3NvdXJjZV8gdHJl ZSBhZnRlciBhDQo+Pj4gYnVpbGQgZmFpbHVyZSB3b3VsZCBiZSBkaWZmZXJlbnQgZnJvbSB0aGF0 IGFmdGVyIGEgc3VjY2Vzc2Z1bCBidWlsZC4NCj4+PiBQZXJzb25hbGx5IEkgY29uc2lkZXIgdGhp cyBhdCBiZXN0IHN1cnByaXNpbmcuDQo+Pj4gDQo+Pj4gSSB3b25kZXIgd2hldGhlciBpbnN0ZWFk IHRoZXJlIGNvdWxkIGJlIGEgc2hlbGwoPykgc2NyaXB0IGRyaXZpbmcgYQ0KPj4+IHNlcXVlbmNl IG9mIG1ha2UgaW52b2NhdGlvbnMsIGxlYXZpbmcgdGhlIG5ldyBtYWtlIGdvYWxzIGFsbCBiZSBz ZWxmLQ0KPj4+IGNvbnRhaW5lZC4gU3VjaCBhIHNjcmlwdCBjb3VsZCByZXZlcnQgdGhlIHNvdXJj ZSB0cmVlIHRvIGl0cyBvcmlnaW5hbA0KPj4+IHN0YXRlIGV2ZW4gdXBvbiBidWlsZCBmYWlsdXJl IGJ5IGRlZmF1bHQsIHdpdGggYW4gb3B0aW9uIGFsbG93aW5nIHRvDQo+Pj4gc3VwcHJlc3MgdGhp cyBiZWhhdmlvci4NCj4+IA0KPj4gSW5zdGVhZCBvZiBhZGRpbmcgYW5vdGhlciB0b29sLCBzbyBh bm90aGVyIGxheWVyIHRvIHRoZSBvdmVyYWxsIHN5c3RlbSwgSSB3b3VsZCBiZSBtb3JlIHdpbGxp bmcgdG8gYWRkIGRvY3VtZW50YXRpb24NCj4+IGFib3V0IHRoaXMgcHJvY2VzcywgZXhwbGFpbmlu ZyBob3cgdG8gdXNlIHRoZSBhbmFseXNpcy0qIGJ1aWxkIHRhcmdldHMsIHdoYXQgdG8gZXhwZWN0 IGFmdGVyIGEgc3VjY2Vzc2Z1bCBydW4gYW5kIHdoYXQNCj4+IHRvIGV4cGVjdCBhZnRlciBhIGZh aWx1cmUuDQo+PiANCj4+IFdoYXQgZG8geW91IHRoaW5rPw0KPiANCj4gUGVyc29uYWxseSBJJ2Qg cHJlZmVyIG1ha2UgZ29hbHMgdG8gYmVoYXZlIGFzIHN1Y2gsIHdpdGggbm8gc3VycHJpc2VzLg0K DQpUaGUgYW5hbHlzaXMtKiBnb2FsIHJlcXVpcmVzIGEgYnVpbGQgc3RlcCwgb3RoZXJ3aXNlIG5v IGFuYWx5c2lzIGNhbiBiZSBwZXJmb3JtZWQgYnkgdGhlIGFuYWx5c2lzIHRvb2xzLCBzbyBJIGhv cGUgd2UgYWdyZWUNCndlIG5lZWQgdG8gaW50ZWdyYXRlIHRoYXQgc3RlcCBhcyBhIGRlcGVuZGVu Y3kgb2YgdGhlIGFuYWx5c2lzLSouDQpJIHVuZGVyc3RhbmQgdGhhdCB0aGUgYW5hbHlzaXMtY2xl YW4gbWlnaHQgYmUgYSDigJxzdXJwcmlzZeKAnSBpZiBub3Qgd2VsbCBkb2N1bWVudGVkLCB0aGlz IGNvbWVzIGZyb20gdGhlIG5lZWQgdG8gc3Vic3RpdHV0ZSB0aGUNCnRhZ3MgaW4gdGhlIHRyZWUg KHRvIGtlZXAgdGhlIHJlYWwgcGF0aCBpbiB0aGUgcmVwb3J0IGxvZykgYW5kIHRvIHJldmVydCB0 aGVtIGJhY2sgYXQgdGhlIGVuZCBvZiB0aGUgYW5hbHlzaXMuDQoNClNvLCBzdWNoIHNjcmlwdCBz aG91bGQganVzdCBtYXNrIHRvIHRoZSB1c2VyIHRoZSBhbmFseXNpcy1jbGVhbiBpbnZvY2F0aW9u IGluIGNhc2Ugb2YgZXJyb3JzICh3aXRoIGFuIG9wdGlvbiB0byBkb27igJl0IGRvIHRoYXQpPw0K DQo+IA0KPiBKYW4NCg0K From xen-devel-bounces@lists.xenproject.org Fri Nov 11 10:54:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 10:54:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442440.696596 (Exim 4.92) (envelope-from ) id 1otRfs-0005O5-ID; Fri, 11 Nov 2022 10:54:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442440.696596; Fri, 11 Nov 2022 10:54:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otRfs-0005Ny-E1; Fri, 11 Nov 2022 10:54:16 +0000 Received: by outflank-mailman (input) for mailman id 442440; Fri, 11 Nov 2022 10:54:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otRfq-0005Ns-Rw for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 10:54:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otRff-0004Kl-Tm; Fri, 11 Nov 2022 10:54:03 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1otRff-0005YS-M4; Fri, 11 Nov 2022 10:54:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ZQpJo21zs1i55Uy36nEz1DJotTrs5ORqnBzNy5wV+mw=; b=k9qmDmdKX3ZD4p4YiNvt/oVaNk 1ChWHLomiRv9Io3OscEJWlJ1qOd/wcf/pLYY63sGTqm4536FSO5ErNhXTzC/wBWfvNA//c4JwOCLR 71X2Lj2kHlDemOWxG/jC6Pjs7OIjwgac8KecOjc6cMY7fgjPMsK/rpWUr1gn6v/S1ZR0=; Message-ID: Date: Fri, 11 Nov 2022 10:54:00 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 4/4] xen/arm: Correct the p2m pool size calculations Content-Language: en-US To: Henry Wang , Andrew Cooper , Xen-devel , Stefano Stabellini , Bertrand Marquis Cc: Xen Security Team , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Volodymyr Babchuk , Anthony PERARD References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-5-andrew.cooper3@citrix.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/11/2022 10:11, Henry Wang wrote: >> -----Original Message----- >> Subject: [PATCH 4/4] xen/arm: Correct the p2m pool size calculations >> >> Allocating or freeing p2m pages doesn't alter the size of the mempool; only >> the split between free and used pages. >> >> Right now, the hypercalls operate on the free subset of the pool, meaning >> that >> XEN_DOMCTL_get_p2m_mempool_size varies with time as the guest shuffles >> its >> physmap, and XEN_DOMCTL_set_p2m_mempool_size ignores the used >> subset of the >> pool and lets the guest grow unbounded. >> >> This fixes test-p2m-pool on ARM so that the behaviour matches x86. >> >> This is part of XSA-409 / CVE-2022-33747. >> >> Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M >> pool") >> Signed-off-by: Andrew Cooper > > Release-acked-by: Henry Wang > > Hi Arm maintainers, may I ask for a reviewed-by/ack from you for the > correctness of the code in the release? Thank you very much! Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Nov 11 11:07:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 11:07:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442449.696606 (Exim 4.92) (envelope-from ) id 1otRt2-0007JI-Mm; Fri, 11 Nov 2022 11:07:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442449.696606; Fri, 11 Nov 2022 11:07:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otRt2-0007JB-K3; Fri, 11 Nov 2022 11:07:52 +0000 Received: by outflank-mailman (input) for mailman id 442449; Fri, 11 Nov 2022 11:07:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otRt1-0007J1-8f; Fri, 11 Nov 2022 11:07:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otRt1-0004b8-56; Fri, 11 Nov 2022 11:07:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otRt0-0000Dt-Qz; Fri, 11 Nov 2022 11:07:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otRt0-0006vU-QS; Fri, 11 Nov 2022 11:07:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L45ugX/yX1uNcbGwICsjz2FYUampOarAujHSjilEcPs=; b=DgyDtGe4T12AiC2Gtjt1N+yG11 zJNj97opjnBXE156e+S2qazoYfcz4vquskoFRfKdAzVpiJn0RLVd/ikOhrnL6BCkOCiHGPM0xfLPv 55AVE7sovCTZexNse0eLb1UCVIPKV3zKFM+hySNkFUZbGvWxodoL5rS4EP1Os1o6njKc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174727: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-pair:guest-migrate/dst_host/src_host:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=771a8acbb84145b943bd608ba376e104ebfa9664 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Fri, 11 Nov 2022 11:07:50 +0000 flight 174727 linux-5.4 real [real] flight 174736 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174727/ http://logs.test-lab.xenproject.org/osstest/logs/174736/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 14 guest-start fail in 174736 pass in 174727 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 174736 pass in 174727 test-armhf-armhf-xl-credit1 14 guest-start fail pass in 174736-retest test-amd64-i386-libvirt-pair 27 guest-migrate/dst_host/src_host fail pass in 174736-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 174736 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 174736 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 771a8acbb84145b943bd608ba376e104ebfa9664 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 12 days Failing since 174575 2022-11-01 18:42:39 Z 9 days 17 attempts Testing same since 174727 2022-11-10 22:13:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anna Schumaker Anssi Hannula Ard Biesheuvel Arnaldo Carvalho de Melo Biju Das Brian Foster Brian Norris Carlos Llamas Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Chuhong Yuan Damien Le Moal Dan Carpenter Darrick J. Wong Darrick J. Wong Dave Chinner Dave Chinner David S. Miller David Sterba Dean Luick Demi Marie Obenour Dennis Dalessandro Dokyung Song Dongliang Mu Eric Dumazet Eric Sandeen Filipe Manana Florian Fainelli Gaosheng Cui Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Han Xu Hangyu Hua Hannu Hartikainen Hans Verkuil Heiko Carstens Heiko Stuebner Helge Deller Hyong Youb Kim Hyunwoo Kim Håkon Bugge Ilias Apalodimas Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jason Gunthorpe Jeff Vanhoof Jens Axboe Jens Glathe Jim Mattson Jimmy Assarsson Jiri Kosina Johan Hovold John Veness Jon Hunter Jon Maloy Jonathan Cameron Jonathan Corbet Josh Poimboeuf Juergen Gross Julian Anastasov Justin Chen Kalle Valo Kan Liang Konrad Jankowski Kuniyuki Iwashima Kuogee Hsieh Leon Romanovsky Leon Romanovsky Li Qiang Linus Torvalds Linux Kernel Functional Testing Luiz Augusto von Dentz Luiz Capitulino Luís Henriques M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Martin K. Petersen Martin Tůma Masami Hiramatsu (Google) Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Maxim Levitsky Maxim Mikityanskiy Meena Shanmugam Michal Hocko Michal Jaron Michal Simek Mike Kravetz Miklos Szeredi Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Pablo Neira Ayuso Paolo Abeni Paolo Bonzini Paul E. McKenney Paul Moore Peter Zijlstra (Intel) Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rasmus Villemoes Richard Weinberger Rik van Riel Saeed Mahameed Sakari Ailus Samuel Bailey Sascha Hauer Sasha Levin Serge Hallyn Sergey Shtylyov Shakeel Butt Shang XiaoJing Shreeya Patel Shuah Khan Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Theodore Ts'o Thinh Nguyen Tim Harvey Tom Lendacky Tomasz Moń Tony O'Brien Trond Myklebust Tvrtko Ursulin Uday Shankar Ulf Hansson Vasily Averin Vasily Gorbik Ville Syrjälä Vineet Gupta Vladimir Oltean Wei Yongjun Willy Tarreau Wolfram Sang Xin Long Yang Yingliang Ye Bin Yongqin Liu Yu Kuai Zhang Changzhong Zhang Qilong Zhang Xiaoxu Zheng Yejian Zhengchao Shao Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 4692 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Nov 11 11:22:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 11:22:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442456.696618 (Exim 4.92) (envelope-from ) id 1otS7I-0001R7-5o; Fri, 11 Nov 2022 11:22:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442456.696618; Fri, 11 Nov 2022 11:22:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otS7I-0001R0-2h; Fri, 11 Nov 2022 11:22:36 +0000 Received: by outflank-mailman (input) for mailman id 442456; Fri, 11 Nov 2022 11:22:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otS7G-0001Qu-N9 for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 11:22:34 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 2094a972-61b3-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 12:22:29 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E21771FB; Fri, 11 Nov 2022 03:22:34 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 95CB93F73D; Fri, 11 Nov 2022 03:22:17 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2094a972-61b3-11ed-8fd2-01056ac49cbb From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Jan Beulich , Christopher Clark , Nathan Studer , Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Doug Goldstein , Juergen Gross , Dario Faggioli , Elena Ufimtseva , George Dunlap , Nick Rosbrook , Lukasz Hawrylko , "Daniel P . Smith" , =?UTF-8?q?Mateusz=20M=C3=B3wka?= , Kevin Tian , Jun Nakajima , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Anthony Perard , Bob Eshleman , Alistair Francis , Connor Davis , Meng Xu , Samuel Thibault , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Daniel De Graaf , Quan Xu Subject: [PATCH 0/3] Populate entries for 4.17 Date: Fri, 11 Nov 2022 19:22:05 +0800 Message-Id: <20221111112208.451449-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello, The following changes are preparation work for the 4.17 release. This is my first pass at the log for the release, it's likely missing more entries. I'm Ccing all maintainers in this cover letter and also in patch #2 for further feedback on missing items. Thanks, Henry Henry Wang (3): CHANGELOG: Update link for RELEASE-4.16.0 CHANGELOG: Add missing entries for work during the 4.17 release CHANGELOG: Start new "unstable" section CHANGELOG.md | 31 +++++++++++++++++++++++++++++-- 1 file changed, 29 insertions(+), 2 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 11:22:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 11:22:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442457.696629 (Exim 4.92) (envelope-from ) id 1otS7Q-0001i6-Dx; Fri, 11 Nov 2022 11:22:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442457.696629; Fri, 11 Nov 2022 11:22:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otS7Q-0001hz-B7; Fri, 11 Nov 2022 11:22:44 +0000 Received: by outflank-mailman (input) for mailman id 442457; Fri, 11 Nov 2022 11:22:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otS7O-0001Qu-W8 for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 11:22:42 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 282bbb6c-61b3-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 12:22:42 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ADBE623A; Fri, 11 Nov 2022 03:22:47 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 66DE33F73D; Fri, 11 Nov 2022 03:22:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 282bbb6c-61b3-11ed-8fd2-01056ac49cbb From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Jan Beulich , Christopher Clark , Nathan Studer , Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Doug Goldstein , Juergen Gross , Dario Faggioli , Elena Ufimtseva , George Dunlap , Nick Rosbrook , Lukasz Hawrylko , "Daniel P . Smith" , =?UTF-8?q?Mateusz=20M=C3=B3wka?= , Kevin Tian , Jun Nakajima , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Anthony Perard , Bob Eshleman , Alistair Francis , Connor Davis , Meng Xu , Samuel Thibault , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Daniel De Graaf , Quan Xu Subject: [PATCH 1/3] CHANGELOG: Update link for RELEASE-4.16.0 Date: Fri, 11 Nov 2022 19:22:06 +0800 Message-Id: <20221111112208.451449-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221111112208.451449-1-Henry.Wang@arm.com> References: <20221111112208.451449-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Henry Wang --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5e4bae5f35..adbbb216fa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,7 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ### Removed / support downgraded - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options -## [4.16.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2021-12-02 +## [4.16.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.16.0) - 2021-12-02 ### Removed - XENSTORED_ROOTDIR environment variable from configuartion files and -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 11:22:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 11:22:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442460.696640 (Exim 4.92) (envelope-from ) id 1otS7d-0002DJ-Mt; Fri, 11 Nov 2022 11:22:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442460.696640; Fri, 11 Nov 2022 11:22:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otS7d-0002DA-JW; Fri, 11 Nov 2022 11:22:57 +0000 Received: by outflank-mailman (input) for mailman id 442460; Fri, 11 Nov 2022 11:22:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otS7c-0001Qu-Ef for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 11:22:56 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 300d774e-61b3-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 12:22:55 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E24011042; Fri, 11 Nov 2022 03:23:00 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 995E73F73D; Fri, 11 Nov 2022 03:22:43 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 300d774e-61b3-11ed-8fd2-01056ac49cbb From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Jan Beulich , Christopher Clark , Nathan Studer , Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Doug Goldstein , Juergen Gross , Dario Faggioli , Elena Ufimtseva , George Dunlap , Nick Rosbrook , Lukasz Hawrylko , "Daniel P . Smith" , =?UTF-8?q?Mateusz=20M=C3=B3wka?= , Kevin Tian , Jun Nakajima , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Anthony Perard , Bob Eshleman , Alistair Francis , Connor Davis , Meng Xu , Samuel Thibault , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Daniel De Graaf , Quan Xu Subject: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release Date: Fri, 11 Nov 2022 19:22:07 +0800 Message-Id: <20221111112208.451449-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221111112208.451449-1-Henry.Wang@arm.com> References: <20221111112208.451449-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Henry Wang --- CHANGELOG.md | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index adbbb216fa..fa8cc476b3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,16 +4,41 @@ Notable changes to Xen will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) -## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD +## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2022-11-?? ### Changed - On x86 "vga=current" can now be used together with GrUB2's gfxpayload setting. Note that this requires use of "multiboot2" (and "module2") as the GrUB commands loading Xen. + - The "gnttab" option now has a new command line sub-option for disabling the + GNTTABOP_transfer functionality. + - The x86 MCE command line option info is now updated. ### Added / support upgraded + - Out-of-tree builds for the hypervisor now supported. + - The project has officially adopted 4 directives and 24 rules of MISRA-C, + added MISRA-C checker build integration, and defined how to document + deviations. - IOMMU superpage support on x86, affecting PV guests as well as HVM/PVH ones when they don't share page tables with the CPU (HAP / EPT / NPT). - - Support VIRT_SSBD feature for HVM guests on AMD. + - Support VIRT_SSBD feature for HVM guests on AMD and MSR_SPEC_CTRL feature for + SVM guests. + - Improved TSC, CPU frequency calibration and APIC on x86. + - Improved support for CET Indirect Branch Tracking on x86. + - Improved mwait-idle support for SPR and ADL on x86. + - Extend security support for hosts to 12 TiB of memory on x86. + - Add command line option to set cpuid parameters for dom0 at boot time on x86. + - Improved static configuration options on Arm. + - cpupools can be specified at boot using device tree on Arm. + - It is possible to use PV drivers with dom0less guests, allowing statically + booted dom0less guests with PV devices. + - On Arm, p2m structures are now allocated out of a pool of memory set aside at + domain creation. + - Improved mitigations against Spectre-BHB on Arm. + - Add support for VirtIO toolstack on Arm. + - Allow setting the number of CPUs to activate at runtime from command line + option on Arm. + - Improved toolstack build system. + - Add Xue - console over USB 3 Debug Capability. ### Removed / support downgraded - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 11:23:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 11:23:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442465.696651 (Exim 4.92) (envelope-from ) id 1otS7t-0002kJ-0X; Fri, 11 Nov 2022 11:23:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442465.696651; Fri, 11 Nov 2022 11:23:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otS7s-0002kC-Tz; Fri, 11 Nov 2022 11:23:12 +0000 Received: by outflank-mailman (input) for mailman id 442465; Fri, 11 Nov 2022 11:23:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otS7r-0001z9-Tu for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 11:23:11 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 393bace1-61b3-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 12:23:10 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 535001063; Fri, 11 Nov 2022 03:23:16 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0D1DC3F73D; Fri, 11 Nov 2022 03:22:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 393bace1-61b3-11ed-91b6-6bf2151ebd3b From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Jan Beulich , Christopher Clark , Nathan Studer , Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Doug Goldstein , Juergen Gross , Dario Faggioli , Elena Ufimtseva , George Dunlap , Nick Rosbrook , Lukasz Hawrylko , "Daniel P . Smith" , =?UTF-8?q?Mateusz=20M=C3=B3wka?= , Kevin Tian , Jun Nakajima , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Anthony Perard , Bob Eshleman , Alistair Francis , Connor Davis , Meng Xu , Samuel Thibault , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Daniel De Graaf , Quan Xu Subject: [PATCH 3/3] CHANGELOG: Start new "unstable" section Date: Fri, 11 Nov 2022 19:22:08 +0800 Message-Id: <20221111112208.451449-4-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221111112208.451449-1-Henry.Wang@arm.com> References: <20221111112208.451449-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Henry Wang --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index fa8cc476b3..d2ed1fdcb9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ Notable changes to Xen will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) +## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD + ## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2022-11-?? ### Changed -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 11:29:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 11:29:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442476.696662 (Exim 4.92) (envelope-from ) id 1otSDR-0003w4-La; Fri, 11 Nov 2022 11:28:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442476.696662; Fri, 11 Nov 2022 11:28:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otSDR-0003vx-IV; Fri, 11 Nov 2022 11:28:57 +0000 Received: by outflank-mailman (input) for mailman id 442476; Fri, 11 Nov 2022 11:28:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otSDQ-0003vr-DC for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 11:28:56 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80089.outbound.protection.outlook.com [40.107.8.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 06b21635-61b4-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 12:28:55 +0100 (CET) Received: from DB6P195CA0019.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::29) by PR3PR08MB5578.eurprd08.prod.outlook.com (2603:10a6:102:83::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 11:28:42 +0000 Received: from DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::b0) by DB6P195CA0019.outlook.office365.com (2603:10a6:4:cb::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Fri, 11 Nov 2022 11:28:42 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT031.mail.protection.outlook.com (100.127.142.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 11:28:41 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Fri, 11 Nov 2022 11:28:41 +0000 Received: from fa6c0fb95f04.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A2E4F9C5-4AA7-4791-9A7A-FCFA4B679DBD.1; Fri, 11 Nov 2022 11:28:35 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fa6c0fb95f04.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 11:28:35 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAXPR08MB7574.eurprd08.prod.outlook.com (2603:10a6:102:23c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 11:28:33 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Fri, 11 Nov 2022 11:28:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06b21635-61b4-11ed-91b6-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=g63rZzxltL78Cok08vvTWLL8c56SIV0zc4CMwdOMcvxDV1Z/ftfc0lID1NouBoFoXmvehj/NrZl8OpJj1Gekn33h5P70lKlWqsa0UslgzRyqysJ5jmRLTyOyvlMI+nGD9Zc046g8p/zTkUP5hjkY4xh99GRpQri0Uqy2ilnvbb9LI+el1d3JOIvv+2u2zZZBPtjKcyi20XdFys+HWKPIUVrJHNBdpQ5bJbbeuMa9HIg0s5YMlusOH09ppfElbOumMsxoB2cicwbBd3/YWC3Jr2Sve7XO9s9zMBIZEe2FXsSIgyDxOt1hSRgwqQf5VL8jn/12fV0AE6GC1CBRiY7htA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s5DU4q2sjXsgqUvemwSEiZekAWd8/hzjJT7DFNzLHgg=; b=eRNYUHNOGeDEF2dmNt2SHL9revha5cAt22zlzNxznmDV0rQRolTOnkTdFs0YqSR1GK6vH0WOaPcvPrVcecEw6yIY522pVoqQK6bxsi5KeMpOKyLv6HPp4NZCcj+vB4ne3/KpLIOsEYlezWjCjTc8sCV9wdTjHf4MycF86tRpj1OnMlQRdAAgi45WanZiuO0qm+bgO2Lg54gXX1hCaXkNfBMSBFl25RH7ABy2Znu2/VH6F3gCy6diPV86KCx83u84jtbVNSORVgHJ+ItHRd0dfFj//3qvzI0zQ7Soe2uNGZhTWWFy3143pgjmhgsHSusvC3Li+iQgdPaN2Ynx9SUgZg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s5DU4q2sjXsgqUvemwSEiZekAWd8/hzjJT7DFNzLHgg=; b=pLr7Mkg4A/lWL+A//lRe31mPn6MY2BkkPBV+q1ALbfA5M2T2/tNZUCL/bfYcFnziNsK0+2TP/foK+STEV3IOZAjFjR6fmgqV2z7ACwEjpo6lLutPSsq9jFjlMurqYKkaS9GKpfOvll778eTkhZCZi/hliR0gq0r88D7ynRbARfo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A5mcJVIcuMcWCZ3X8ReB6WNvqc6UUNsUZhra9Eg1gIsNmguQLHI5JuR8x7sFMkK/Vfjhz16nuw6qa39ziBRjwS/+Dj/rWWWjI/rAm8X2NTxyGne1tVo1rHgaYrbLOjCAel93M5PC66EN77Hnm7PSfR3AUjDAu4W874us8ZctFzZcs1R6bahbzgoJgXqeyUXS2hEx8XWlil4TZEbON3tOvKdzCu5AuADf0MQIQkWbvKsNAj4Tw5gy4mM3eAiCMN86FUIIzKH+EC8XVEV7PB5KkwnB053i4T4FH+XzRZNG+rHhAwOPPd4+BPosbTs3I+x6t0jf1F0CdLb/FotBjCCxTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s5DU4q2sjXsgqUvemwSEiZekAWd8/hzjJT7DFNzLHgg=; b=kT2iV9gp3JhXH1PrNZAhCYwgEAkKxH8Y7wFxyoCu2la2l7ETHOr/qF/USJP4LxsPne97bpQdFmVa5HivolJL+KNKlq4U10GRnOVu03EQggp+JgBMfsgqGWhuN0G7km2ogrCVV146zqzgJTQ1KyTenBoNCciLWtcPuUMQ4HKx/YLCviEIsb3Gt50TixusnIddHzC7XvyyBqKSEpGoUaSOA97sP+rHzm4xgDLXvTKK8U/oPC6WI3jvusDn0od7zDXXpD0VsJ01ejmXb3JC6V399I2+P+DTWtH/9pehaY2CXL7jsJydgDl4c/VFQnjzs66tf5f9O3I6MlvJkxF0JDZRfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s5DU4q2sjXsgqUvemwSEiZekAWd8/hzjJT7DFNzLHgg=; b=pLr7Mkg4A/lWL+A//lRe31mPn6MY2BkkPBV+q1ALbfA5M2T2/tNZUCL/bfYcFnziNsK0+2TP/foK+STEV3IOZAjFjR6fmgqV2z7ACwEjpo6lLutPSsq9jFjlMurqYKkaS9GKpfOvll778eTkhZCZi/hliR0gq0r88D7ynRbARfo= From: Henry Wang To: Stefano Stabellini , Anthony PERARD CC: "xen-devel@lists.xenproject.org" , Wei Liu , George Dunlap , Julien Grall , Jan Beulich , Andrew Cooper , Bertrand Marquis , Petre Pircalabu , Alexandru Isaila , Tamas K Lengyel , Volodymyr Babchuk , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Juergen Gross , Paul Durrant , Christopher Clark Subject: RE: [XEN PATCH for-4.17 v2 0/6] Fixing some licences issue in public headers Thread-Topic: [XEN PATCH for-4.17 v2 0/6] Fixing some licences issue in public headers Thread-Index: AQHY73rCghjYe94nkUWe9AEw9k4cv6441jqAgADLbvA= Date: Fri, 11 Nov 2022 11:28:33 +0000 Message-ID: References: <20221103115204.49610-1-anthony.perard@citrix.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F60953AF969FDB4C9768217585D981E9.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAXPR08MB7574:EE_|DBAEUR03FT031:EE_|PR3PR08MB5578:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d0cabf3-0045-4ba1-6818-08dac3d7e2e7 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OSDVp4kRPzhbQQu4fi8OJQllALBug+vXkgHH336paH63QlFWoXHthihyu6F1aLu+k0WybVKMuBS1EIOnQnXx+lurxbQ6/W3apugpWOWl9awXWynCyIug6lG7W00gSbU3vdNkStyyQo5wuN+KjMMQJKn8skdFwCcD688YQWfmyPRzjriqfj9or/GHifY+xwoMSE4twiabjHAlJRHlT6svAGQS4bUXPFsnq6uikm6PkXzlN/sIKJbGHuflsUDmVjP0m5e2JFhmgA8duPvMf7mKWBdWwvorNPJp9rSTBzt4YqVa9UE7eLrqa9QMh06rSIvoXlqDHx8CT4NM2fXbbJECKZOXRBB0F45Is/UIC86+5LNJ8WmLhumfUopA8rxbYJWXAs5CtR6yJXOLb/QwFfg46U0to/nAvKsUMQay/7l42oj/DkRkIHH9idXp1aVmrzV0YFZcv1v3kn5RfqlwDNyOOPa0TOjYLc88sKlYC8gnJkJ9MO/y5yUuwppExV+2O+O0dXJ5YqjfD94l/ezRo2Z0aPeEDkP0eHNBMZQA2t7DdAoWB4PKZRLkUdKPBW+/1+QdLl1O0LX+eMlevjlS0j1U7NqrmWPoynCofqExiA1PDTSUYxIkQbgdWQK+DTnq+xhHIIlhoQwqfQWcOQY/YB3KoGFQx8KquvMkH4zTBQdLGhwWLUufE/b9BzkOlw3LDCFe0ZQLJIeP1ewv2wj2zRKOqEXbKchBiv7uFbfRfVHzIrAtYKdPfiEk5xDGaOjqE0dK1M6M4gDH5lk7GqMY7lya+WMtXDikNGW493s1xYKM0Kk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(39860400002)(346002)(136003)(376002)(451199015)(2906002)(8936002)(4326008)(66946007)(8676002)(66556008)(64756008)(66476007)(76116006)(66446008)(7416002)(5660300002)(4744005)(52536014)(41300700001)(316002)(122000001)(33656002)(55016003)(71200400001)(478600001)(9686003)(966005)(26005)(7696005)(6506007)(54906003)(110136005)(186003)(38100700002)(86362001)(38070700005)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7574 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 16b61a06-402a-4dc1-a69e-08dac3d7de0f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SheMhFnfGr3feptSMrm7Q7QjGs0pqYzOZ7WbgYBhgYNFofx++z15gMZBYGDS+IQXIfGE7rsqWceP3gCWY1cHULOpIQay593qJzvr4WPMw1tkDXSHFiPwJx0+v6QJVoU13X7W5F/0oe8BwoTgezeDnd+f7MYVodE8A6uycM4PyKlpt3lL2B9kKMbCRHZVGjUNpvqRllPV91zw/v218BY20K15GNdet8atMcVkLs9rWog/5hMnkKYiv1ZznJpLDk1yu67a2e9fybSSWQaNl+e1Rc1Ml+0YGmV4sx6IKo6n37asx1ep8LSpmrYZjbCaOjV+6l26tvhcKWpsXt+OMZRdlHPtSd9VWgQUNU4Gmgv6Y5ruUis5bPzDQZ3DCnY+yCAdK9gXINIE/SNZiN1TaRs7aeUjfIA//n6REM9Ax/KKa1ZhLkt/BayQPBohSaL5o+KTmwIpnDOUKVV5KDx69DeW4v6RplcyzU5dtBmsievutTX9Pk5DTg0T/AAVzZgn6sJirR3GWRCL4UJdx2X9nonG5TO8USfQpSNuJd46oGVOPnzDYnXJRrvA3jk69AEhdmkq2ALNd2V7KqDCh0+atIyeWtbfYRQ18N3KuD1gwQkbb3toX5PfOFjXaCjUUF8miHrGYRn+PFeHYHehNzAj6yV/fJyp0HT7EYWWVBsFVeYxdMNu0A3pG6mVjixuJg3CFLxgfqcIvtv6oC9CGSFv9YwG9ddm6H4n5XS9hrz141IgKEtjowm05Z7tz4+oV43I+YFcrpfOiDmuidGg/FPK4I2F7Bsv/5lQ6e01xyJzoIxl2fw= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199015)(40470700004)(36840700001)(46966006)(70206006)(110136005)(4326008)(8676002)(70586007)(54906003)(316002)(41300700001)(2906002)(478600001)(966005)(4744005)(8936002)(5660300002)(52536014)(26005)(40460700003)(107886003)(9686003)(7696005)(6506007)(33656002)(55016003)(186003)(86362001)(47076005)(40480700001)(336012)(83380400001)(82310400005)(82740400003)(81166007)(36860700001)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 11:28:41.8391 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1d0cabf3-0045-4ba1-6818-08dac3d7e2e7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5578 Hi Stefano, > -----Original Message----- > From: Stefano Stabellini > Hi all, >=20 > I think if we are going to commit this series for 4.17 then I would > suggest to also commit patches 1-3 of my "introduce SPDX" series: >=20 > https://marc.info/?l=3Dxen-devel&m=3D166562222522996 >=20 > They are already acked/reviewed and are zero risk as they don't actually > change any of the headers. After some thinking and discussion I would like to follow your suggestion i= n here. So for the first 3 patches from your "introduce SPDX" series: Release-acked-by: Henry Wang I will need some more time to figure out some uncertain part from Anthony's series about the relicensing of device_tree_defs.h [1] before providing my release ack there. [1] https://lore.kernel.org/xen-devel/fad0265d-a736-5135-b5ea-3735a8bc72da@= xen.org/ Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Nov 11 11:47:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 11:47:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442482.696672 (Exim 4.92) (envelope-from ) id 1otSVN-0006jS-93; Fri, 11 Nov 2022 11:47:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442482.696672; Fri, 11 Nov 2022 11:47:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otSVN-0006jL-6R; Fri, 11 Nov 2022 11:47:29 +0000 Received: by outflank-mailman (input) for mailman id 442482; Fri, 11 Nov 2022 11:47:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otSVM-0006jF-AO for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 11:47:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otSVC-0005ZO-NF; Fri, 11 Nov 2022 11:47:18 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1otSVC-00083j-Ff; Fri, 11 Nov 2022 11:47:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=N/gx48E/hyKxHVGQtcs4Psp0OGUYRELrIE62QBmAlSs=; b=p4SFXOtwDwbNzgDoIa03l6qnaM vMR/b6dL5EZCpUJ6F8M0Czun/ZZrXIO7TrukfB1LwH949hL2UlgFnOqbQ/tJkcvk3X/g5umkw1zSN HzywPkTpTK8+koOjrKTU5OUqcvVIOZRkFC1hZYt95laCcztJfrKNt3Xzsty4btu1t3Kg=; Message-ID: Date: Fri, 11 Nov 2022 11:47:10 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 3/3] CHANGELOG: Start new "unstable" section Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Jan Beulich , Christopher Clark , Nathan Studer , Stewart Hildebrand , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Doug Goldstein , Juergen Gross , Dario Faggioli , Elena Ufimtseva , George Dunlap , Nick Rosbrook , Lukasz Hawrylko , "Daniel P . Smith" , =?UTF-8?Q?Mateusz_M=c3=b3wka?= , Kevin Tian , Jun Nakajima , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Anthony Perard , Bob Eshleman , Alistair Francis , Connor Davis , Meng Xu , Samuel Thibault , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Daniel De Graaf , Quan Xu References: <20221111112208.451449-1-Henry.Wang@arm.com> <20221111112208.451449-4-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20221111112208.451449-4-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 11/11/2022 11:22, Henry Wang wrote: > Signed-off-by: Henry Wang Acked-by: Julien Grall > --- > CHANGELOG.md | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index fa8cc476b3..d2ed1fdcb9 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -4,6 +4,8 @@ Notable changes to Xen will be documented in this file. > > The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > > +## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD AFAICT, this patch should only be merged after we branched for 4.17. > + > ## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2022-11-?? > > ### Changed Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Nov 11 11:48:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 11:48:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442485.696683 (Exim 4.92) (envelope-from ) id 1otSWc-0007Gi-Je; Fri, 11 Nov 2022 11:48:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442485.696683; Fri, 11 Nov 2022 11:48:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otSWc-0007Gb-GZ; Fri, 11 Nov 2022 11:48:46 +0000 Received: by outflank-mailman (input) for mailman id 442485; Fri, 11 Nov 2022 11:48:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otSWb-0007GT-Fx for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 11:48:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otSWV-0005bH-Is; Fri, 11 Nov 2022 11:48:39 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1otSWV-00085C-9a; Fri, 11 Nov 2022 11:48:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=smojBBlr3oxx8n7hMCZmeYtv9g/ogqx8PnI6PLESvhY=; b=2JDtfy0IeydFckdWxuK1CFiDa4 gkVcvBIEwRveU1PSSHU2cDVlEnMiK90s4yPzCJufzfWgRwX2baQsWlJ0GWQHSYoEr5Va1aaWye9Px YNeoz6+ZnSpoEN3gSgqGiGDOpU5CJOoqiEvnaEzt5JK+mHeCYDO6Bo/8vPix5T/4jIrk=; Message-ID: <901a6fbc-1ea4-4192-b735-6384dcadbf07@xen.org> Date: Fri, 11 Nov 2022 11:48:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 1/3] CHANGELOG: Update link for RELEASE-4.16.0 Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Jan Beulich , Christopher Clark , Nathan Studer , Stewart Hildebrand , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Doug Goldstein , Juergen Gross , Dario Faggioli , Elena Ufimtseva , George Dunlap , Nick Rosbrook , Lukasz Hawrylko , "Daniel P . Smith" , =?UTF-8?Q?Mateusz_M=c3=b3wka?= , Kevin Tian , Jun Nakajima , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Anthony Perard , Bob Eshleman , Alistair Francis , Connor Davis , Meng Xu , Samuel Thibault , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Daniel De Graaf , Quan Xu References: <20221111112208.451449-1-Henry.Wang@arm.com> <20221111112208.451449-2-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20221111112208.451449-2-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 11/11/2022 11:22, Henry Wang wrote: > Signed-off-by: Henry Wang Acked-by: Julien Grall This also wants to be backported to staging-4.16. Cheers, > --- > CHANGELOG.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 5e4bae5f35..adbbb216fa 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -18,7 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > ### Removed / support downgraded > - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options > > -## [4.16.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2021-12-02 > +## [4.16.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.16.0) - 2021-12-02 > > ### Removed > - XENSTORED_ROOTDIR environment variable from configuartion files and -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Nov 11 12:13:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 12:13:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442496.696694 (Exim 4.92) (envelope-from ) id 1otSuN-0002XI-JK; Fri, 11 Nov 2022 12:13:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442496.696694; Fri, 11 Nov 2022 12:13:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otSuN-0002XB-GO; Fri, 11 Nov 2022 12:13:19 +0000 Received: by outflank-mailman (input) for mailman id 442496; Fri, 11 Nov 2022 12:13:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otSuM-0002X1-7w; Fri, 11 Nov 2022 12:13:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otSuM-00064V-5k; Fri, 11 Nov 2022 12:13:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otSuL-0004Eb-Lt; Fri, 11 Nov 2022 12:13:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otSuL-0002V2-LO; Fri, 11 Nov 2022 12:13:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QEGnu7BiPBs+hpycSbT8jO/Ul0Z0lbdKleM4k5JxP40=; b=bWnuWKVZJ6aMMOHJvYTefa4J6b FJgC1yhhC7i2ISvHTrANgIMh98hcUjF56LsCc7sK9sPs3SgDe5eKsb2M1x0j7lAHKRVRxzYdYrZOM pIh8f0vLXZgrg7Y5Q6lev7NzSJh0b2NuUlOasyZN4Tpb6/P4cPHW2V+iS3XciiQOzu3k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174737: all pass - PUSHED X-Osstest-Versions-This: ovmf=b9e702c3c9bfe7bfb6bbcff44603add64e1787bf X-Osstest-Versions-That: ovmf=6d55ad9a592ba3bbc9392a67fd8c936279b73a45 From: osstest service owner Date: Fri, 11 Nov 2022 12:13:17 +0000 flight 174737 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174737/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b9e702c3c9bfe7bfb6bbcff44603add64e1787bf baseline version: ovmf 6d55ad9a592ba3bbc9392a67fd8c936279b73a45 Last test of basis 174734 2022-11-11 06:10:20 Z 0 days Testing same since 174737 2022-11-11 10:10:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Duggapu Chinni B Duggapu, Chinni B jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 6d55ad9a59..b9e702c3c9 b9e702c3c9bfe7bfb6bbcff44603add64e1787bf -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Nov 11 12:44:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 12:44:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442502.696706 (Exim 4.92) (envelope-from ) id 1otTOR-0006Rl-VW; Fri, 11 Nov 2022 12:44:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442502.696706; Fri, 11 Nov 2022 12:44:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otTOR-0006Re-T1; Fri, 11 Nov 2022 12:44:23 +0000 Received: by outflank-mailman (input) for mailman id 442502; Fri, 11 Nov 2022 12:44:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otTOR-0006RY-7i for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 12:44:23 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8fd6b8e3-61be-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 13:44:20 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E1DA220139; Fri, 11 Nov 2022 12:44:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7A6A213357; Fri, 11 Nov 2022 12:44:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UIpMHKNDbmOvUgAAMHmgww (envelope-from ); Fri, 11 Nov 2022 12:44:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8fd6b8e3-61be-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1668170659; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iHLVtlGvNUo2QbTFNdF4X8PIvYLZYIjqtQgebJXxiWc=; b=f4d3gKGf7D3Kfb273CsZYzqr/R7yLMLkO7JA/yUmyRCREZKkzwSH6t2a0wiG+MwPPJvSyN zZOuktfvMXa8cgDOMYsi3cn67yQBoFksldF32VnJR0kdq3Go4Yg555Prh/blaToYKR4JeU KyAUTROPTv09HX6kHv0Hk+SsXBy466w= Message-ID: <3cd62b0b-a131-b709-4244-0ae694c3d022@suse.com> Date: Fri, 11 Nov 2022 13:44:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v4] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Content-Language: en-US From: Juergen Gross To: Jan Beulich , Stefano Stabellini Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Oleksandr Tyshchenko , Maximilian Heyne , xen-devel@lists.xenproject.org, LKML References: <20220729070416.23306-1-jane.malalane@citrix.com> <1918c63f-0065-b468-3691-de6e314f4374@suse.com> <9ab99257-844b-de15-cd20-7cda61295186@suse.com> <2476e467-1c31-91f4-1e75-86723b8da486@suse.com> In-Reply-To: <2476e467-1c31-91f4-1e75-86723b8da486@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------RC0z0fZj2rQ40xWZ1MdQ0Lnn" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------RC0z0fZj2rQ40xWZ1MdQ0Lnn Content-Type: multipart/mixed; boundary="------------iWWawB60R0iaQYOmG0H0B83k"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , Stefano Stabellini Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Oleksandr Tyshchenko , Maximilian Heyne , xen-devel@lists.xenproject.org, LKML Message-ID: <3cd62b0b-a131-b709-4244-0ae694c3d022@suse.com> Subject: Re: [PATCH v4] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector References: <20220729070416.23306-1-jane.malalane@citrix.com> <1918c63f-0065-b468-3691-de6e314f4374@suse.com> <9ab99257-844b-de15-cd20-7cda61295186@suse.com> <2476e467-1c31-91f4-1e75-86723b8da486@suse.com> In-Reply-To: <2476e467-1c31-91f4-1e75-86723b8da486@suse.com> --------------iWWawB60R0iaQYOmG0H0B83k Content-Type: multipart/mixed; boundary="------------bn0Y0emSpJJpT0zCz5kDR6cA" --------------bn0Y0emSpJJpT0zCz5kDR6cA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMTEuMjIgMTA6MDEsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE9uIDA4LjExLjIy IDE3OjI2LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+IE9uIDAzLjExLjIwMjIgMTY6NDEsIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDAzLjExLjIwMjIgMTQ6MzgsIEphbiBCZXVsaWNo IHdyb3RlOg0KPj4+PiBPbiAyOS4wNy4yMDIyIDA5OjA0LCBKYW5lIE1hbGFsYW5lIHdyb3Rl Og0KPj4+Pj4gQEAgLTEyNSw2ICsxMzAsOSBAQCBERUZJTkVfSURURU5UUllfU1lTVkVDKHN5 c3ZlY194ZW5faHZtX2NhbGxiYWNrKQ0KPj4+Pj4gwqAgew0KPj4+Pj4gwqDCoMKgwqDCoCBz dHJ1Y3QgcHRfcmVncyAqb2xkX3JlZ3MgPSBzZXRfaXJxX3JlZ3MocmVncyk7DQo+Pj4+PiAr wqDCoMKgIGlmICh4ZW5fcGVyY3B1X3VwY2FsbCkNCj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBh Y2tfQVBJQ19pcnEoKTsNCj4+Pj4+ICsNCj4+Pj4+IMKgwqDCoMKgwqAgaW5jX2lycV9zdGF0 KGlycV9odl9jYWxsYmFja19jb3VudCk7DQo+Pj4+PiDCoMKgwqDCoMKgIHhlbl9odm1fZXZ0 Y2huX2RvX3VwY2FsbCgpOw0KPj4+Pj4gQEAgLTE2OCw2ICsxNzYsMTUgQEAgc3RhdGljIGlu dCB4ZW5fY3B1X3VwX3ByZXBhcmVfaHZtKHVuc2lnbmVkIGludCBjcHUpDQo+Pj4+PiDCoMKg wqDCoMKgIGlmICgheGVuX2hhdmVfdmVjdG9yX2NhbGxiYWNrKQ0KPj4+Pj4gwqDCoMKgwqDC oMKgwqDCoMKgIHJldHVybiAwOw0KPj4+Pj4gK8KgwqDCoCBpZiAoeGVuX3BlcmNwdV91cGNh bGwpIHsNCj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCByYyA9IHhlbl9zZXRfdXBjYWxsX3ZlY3Rv cihjcHUpOw0KPj4+Pg0KPj4+PiDCoEZyb20gYWxsIEkgY2FuIHRlbGwgYXQgbGVhc3QgZm9y IEFQcyB0aGlzIGhhcHBlbnMgYmVmb3JlIHNldHVwX2xvY2FsX2FwaWMoKS4NCj4+Pj4gV2l0 aCB0aGVyZSBiZWluZyBBUElDIGludGVyYWN0aW9uIGluIHRoaXMgb3BlcmF0aW9uIG1vZGUs IGFzIHNlZW4gZS5nLiBpbg0KPj4+PiB0aGUgZWFybGllciBodW5rIGFib3ZlLCBJIHRoaW5r IHRoaXMgaXMgbG9naWNhbGx5IHdyb25nLiBBbmQgaXQgbGVhZHMgdG8NCj4+Pj4gYXBpY19w ZW5kaW5nX2ludHJfY2xlYXIoKSBpc3N1aW5nIGl0cyB3YXJuaW5nOiBUaGUgdmVjdG9yIHJl Z2lzdHJhdGlvbiwgYXMNCj4+Pj4gYW4gaW50ZW50aW9uYWwgc2lkZSBlZmZlY3QsIG1hcmtz IHRoZSB2ZWN0b3IgYXMgcGVuZGluZy4gVW5sZXNzIElSUXMgd2VyZQ0KPj4+PiBlbmFibGVk IGF0IGFueSBwb2ludCBiZXR3ZWVuIHRoZSByZWdpc3RyYXRpb24gYW5kIHRoZSBjaGVjaywg dGhlcmUncw0KPj4+PiBzaW1wbHkgbm8gd2F5IGZvciB0aGUgY29ycmVzcG9uZGluZyBJUlIg Yml0IHRvIGJlIGRlYWx0IHdpdGggKGJ5DQo+Pj4+IHByb3BhZ2F0aW5nIHRvIElTUiB3aGVu IHRoZSBpbnRlcnJ1cHQgaXMgZGVsaXZlcmVkLCBhbmQgdGhlbiBiZWluZyBjbGVhcmVkDQo+ Pj4+IGZyb20gSVNSIGJ5IEVPSSkuDQo+Pj4NCj4+PiBXaXRoIFJvZ2VyJ3MgaGVscCBJIG5v dyBoYXZlIGEgcG9pbnRlciB0byBvc3N0ZXN0IGFsc28gZXhwb3NpbmcgdGhlIGlzc3VlOg0K Pj4+DQo+Pj4gaHR0cDovL2xvZ3MudGVzdC1sYWIueGVucHJvamVjdC5vcmcvb3NzdGVzdC9s b2dzLzE3NDU5Mi90ZXN0LWFtZDY0LWFtZDY0LXhsLXB2aHYyLWludGVsL2h1eGVscmViZTAt LS12YXItbG9nLXhlbi1jb25zb2xlLWd1ZXN0LWRlYmlhbi5ndWVzdC5vc3N0ZXN0LmxvZy5n eg0KPj4NCj4+IEkndmUgbm90aWNlZCBvbmx5IG5vdyB0aGF0IG15IG1haWwgdG8gSmFuZSBi b3VuY2VkLCBhbmQgSSdtIG5vdyB0b2xkDQo+PiBzaGUncyBubyBsb25nZXIgaW4gaGVyIHJv bGUgYXQgQ2l0cml4LiBTaW5jZSBJIGRvbid0IGV4cGVjdCB0byBoYXZlIHRpbWUNCj4+IHRv IGludmVzdGlnYXRlIGFuIGFwcHJvcHJpYXRlIHNvbHV0aW9uIGhlcmUsIG1heSBJIGFzayB3 aGV0aGVyIG9uZSBvZg0KPj4gdGhlIHR3byBvZiB5b3UgY291bGQgbG9vayBpbnRvIHRoaXMs IGJlaW5nIHRoZSBtYWludGFpbmVycyBvZiB0aGlzIGNvZGU/DQo+IA0KPiBJIHRoaW5rIHRo ZSBjb3JyZWN0IHdheSB0byBoYW5kbGUgdGhpcyB3b3VsZCBiZToNCj4gDQo+IC0gcmVuYW1l IENQVUhQX0FQX0FSTV9YRU5fU1RBUlRJTkcgdG8gQ1BVSFBfQVBfWEVOX1NUQVJUSU5HDQo+ IC0gbW92ZSB0aGUgeGVuX3NldF91cGNhbGxfdmVjdG9yKCkgY2FsbCB0byBhIG5ldyBob3Rw bHVnIGNhbGxiYWNrDQo+ICDCoCByZWdpc3RlcmVkIGZvciBDUFVIUF9BUF9YRU5fU1RBUlRJ TkcgKHRoaXMgY2FuIGJlIGRvbmUgZXZlbg0KPiAgwqAgY29uZGl0aW9uYWxseSBvbmx5IGlm IHhlbl9wZXJjcHVfdXBjYWxsIGlzIHNldCkNCj4gDQo+IFdyaXRpbmcgYSBwYXRjaCBub3cg Li4uDQoNCkZvciB0aGUgQVBzIHRoaXMgaXMgd29ya2luZyBhcyBleHBlY3RlZC4NCg0KVGhl IGJvb3QgcHJvY2Vzc29yIHNlZW1zIHRvIGJlIGhhcmRlciB0byBmaXguIFRoZSByZWxhdGVk IG1lc3NhZ2UgaXMgYmVpbmcNCmlzc3VlZCBldmVuIHdpdGggaW50ZXJydXB0cyBiZWluZyBv biB3aGVuIHNldHVwX2xvY2FsX0FQSUMoKSBpcyBjYWxsZWQuDQoNCkkndmUgdHJpZWQgdG8g cmVnaXN0ZXIgdGhlIGNhbGxiYWNrIG9ubHkgYWZ0ZXIgdGhlIHNldHVwX2xvY2FsX0FQSUMo KSBjYWxsLA0KYnV0IHRoaXMgcmVzdWx0cyBpbiBhIHN5c3RlbSBoYW5nIHdoZW4gdGhlIEFQ cyBhcmUgc3RhcnRlZC4NCg0KQW55IGlkZWFzPw0KDQoNCkp1ZXJnZW4NCg== --------------bn0Y0emSpJJpT0zCz5kDR6cA Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------bn0Y0emSpJJpT0zCz5kDR6cA-- --------------iWWawB60R0iaQYOmG0H0B83k-- --------------RC0z0fZj2rQ40xWZ1MdQ0Lnn Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNuQ6MFAwAAAAAACgkQsN6d1ii/Ey83 1QgAhQ6o6Gtpiho0auSQ1GHFKXoaL8gwudJwqh6sl3eSqa55ZqAPtIYuMqhesz1L/yXTDyohddPo S9YPTA0ApT1dAJSV2bj5DTbTyYf/cFQlEXx+1kWKI7I+bfH3V14h1KauYeQHdDvxnRPSyhEjuSDT n47RMH90ueVbZUvNFFw/0imZWO/fjp4f51mF1C8S2r1emOcOgScYxaqFDHIKHU9BzDImQMjyNdWR 2ax36MUeSh8Pze2zflrs3zIi8JIFWV2psLo8DbETK51Qmn+VO5ey4BhDqFuYjslHxxz7oA3H5TZG LL1FC+kdDjcGM0Hacy4d2wk10ob4cNwTxPJCfCVsoQ== =6X9E -----END PGP SIGNATURE----- --------------RC0z0fZj2rQ40xWZ1MdQ0Lnn-- From xen-devel-bounces@lists.xenproject.org Fri Nov 11 12:51:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 12:51:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442506.696716 (Exim 4.92) (envelope-from ) id 1otTVG-00084n-Ly; Fri, 11 Nov 2022 12:51:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442506.696716; Fri, 11 Nov 2022 12:51:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otTVG-00084g-In; Fri, 11 Nov 2022 12:51:26 +0000 Received: by outflank-mailman (input) for mailman id 442506; Fri, 11 Nov 2022 12:51:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otTVF-00084a-9b for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 12:51:25 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2054.outbound.protection.outlook.com [40.107.22.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b72e022-61bf-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 13:51:22 +0100 (CET) Received: from AS8PR04CA0043.eurprd04.prod.outlook.com (2603:10a6:20b:312::18) by GVXPR08MB7896.eurprd08.prod.outlook.com (2603:10a6:150:16::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 12:51:17 +0000 Received: from AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:312:cafe::ab) by AS8PR04CA0043.outlook.office365.com (2603:10a6:20b:312::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Fri, 11 Nov 2022 12:51:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT036.mail.protection.outlook.com (100.127.140.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 12:51:16 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Fri, 11 Nov 2022 12:51:15 +0000 Received: from 22c0bff7a52f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A6449811-A5C9-4DDD-818A-7CE740F43CF1.1; Fri, 11 Nov 2022 12:51:05 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 22c0bff7a52f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 12:51:05 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB9412.eurprd08.prod.outlook.com (2603:10a6:20b:5ab::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 12:51:03 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Fri, 11 Nov 2022 12:51:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b72e022-61bf-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=OkLVahn9q7Ph3PJe75pcLxFMm/Uh9cyknUlA2bcMlRc4fc3iUuG83Q9AKv8Oe1ZCwZq6ACkaU+qnZv1V43smaY+hkXWFWo4wBbqy/yBdZR7jKEJ2zf6uHyKXS63o6ElGKOZR8b6RTJMfeGLHLpYS7NtMoSj7EnkOz3MLVPM0WxLiPdifgPcHETeVIEn2F35ZH3VKaL3pFLwfOFUaP53CmZ/KnU5R/DV03UsuAR7hkz3aTtVdj18aFHZnQTylMpThaRZgzhDVj6jNudbcp1CcGqEhxx7gz/BteML95EXGRjWGwclQh6p7Rq0zIavBT6+ytJfQs38NQ3adLHk2ieAlHQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sJ4LStr/nXEypSZaEi5eQ8vzMsFk2DTB6/dBQFv0Vu4=; b=NYWsf6+VHJDEbs25rftbuyLkb7ntVotMNmEUFCnULAR1qJ8OK8SUKCk7luKFMy4y3a6qYDKHmb7bYwC8hJmC74o1v9euukdPP3zF8MHfjlHcVYMJq8CrCFvgHDenboWrslXDH5LPMxMFdQMzjNII1ULJ24n6uTpS27Vejro7xYaIbjREOFdYrVAM+9N+IMGoF572a0+ylwhpMhUokQgsUN4CQG8JK94t+zvb19Xc+fKqVkD9+98HnjKgHmkgHChaxwx0dd3EtYswAd/B0wnV/YQg0HJCaZJEo/pFmwW3hf0F8qI9SXiXnIPOf/n2qCkbpVx7KN2bKkBqNLodAEsVYw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sJ4LStr/nXEypSZaEi5eQ8vzMsFk2DTB6/dBQFv0Vu4=; b=EMXmozlFydVYeIp6wZ6LBOWk30g0rsw16Doyl7zI2xsPnpoNxWybzDBpF/zUoHQr1GNYgDL681mijBT1ieI0r1sstGy33yVngghGWzoSE27pnt9CdEea4F03/xXZfDt9HekSyUWoQiL8wb68hdjJgE8ToCu76YEuKgTpP1vLWj0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aAgrn8rqOGf17YS+fkLpB1Nu+FPaPVF8FbzxW5bYr4qYdtGgibvF7evY3iRd7UWpOPULspHV4jOGKBx/6SdPDJcVsjKv+dFuovbccyWadE2+FR3W4JLtsl0vCQkhfhjMASvizx58KCkfPVUR5ePGe0bPETlU2uXICu60RfuY5ZYe+Pzkjnc4VKQj3gXIHofAd2TwAKrejhjB8Zu5YV1cMjmxmSswN4UXy+GcjGPwTQqqPSrXBAkvfi8Sl6xSEyhdZ1+wnT67hRxlY/Pcy7zgRzB6kYTG7gV1PpqZj59Uv3JTL8DjZE7jlZOYol1IteBw2O6exE0eRgM5G3Avxjkgsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sJ4LStr/nXEypSZaEi5eQ8vzMsFk2DTB6/dBQFv0Vu4=; b=frDFpnpPIqJNBjyitOZd/+q8vVJnSdP/XBwr4ZEKL+TMv+u8yg0PCP3KfVffPLuUs0s+qcX9Cg4m3TdHXlLHd4yuXEp1MkZTbuJiOaEqrmMpQEeWXZfmwveXDe15ajyMumHOSlovOlo6gI1bIhAradnt11JK3HhvHUDeKpCp23tZY40dY0LN4NmGEIRekIjU+dKHppmmmBdu6+iQy9LmrqHphJIr+AmLLLiX3jekGUNp3h8/KS3t7ITSUUfhbtMh2MXWgy54ob7oRJmbkA/OwyqlN8oSaNqY3edfVeO4Ggn/1wxpFtwMdcXFQQsXjW6SXel8IUeNk0aKvbTudFC1tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sJ4LStr/nXEypSZaEi5eQ8vzMsFk2DTB6/dBQFv0Vu4=; b=EMXmozlFydVYeIp6wZ6LBOWk30g0rsw16Doyl7zI2xsPnpoNxWybzDBpF/zUoHQr1GNYgDL681mijBT1ieI0r1sstGy33yVngghGWzoSE27pnt9CdEea4F03/xXZfDt9HekSyUWoQiL8wb68hdjJgE8ToCu76YEuKgTpP1vLWj0= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Christopher Clark , Nathan Studer , Stewart Hildebrand , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Doug Goldstein , Juergen Gross , Dario Faggioli , Elena Ufimtseva , George Dunlap , Nick Rosbrook , Lukasz Hawrylko , "Daniel P . Smith" , =?utf-8?B?TWF0ZXVzeiBNw7N3a2E=?= , Kevin Tian , Jun Nakajima , Paul Durrant , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Tim Deegan , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , Anthony Perard , Bob Eshleman , Alistair Francis , Connor Davis , Meng Xu , Samuel Thibault , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Daniel De Graaf , Quan Xu Subject: RE: [PATCH 3/3] CHANGELOG: Start new "unstable" section Thread-Topic: [PATCH 3/3] CHANGELOG: Start new "unstable" section Thread-Index: AQHY9cAJliHTlqC4uUC7lkNIBCaS5q45mykAgAARNQA= Date: Fri, 11 Nov 2022 12:51:03 +0000 Message-ID: References: <20221111112208.451449-1-Henry.Wang@arm.com> <20221111112208.451449-4-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C3BD2BE908D1CA4A936607708FD5DA01.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB9412:EE_|AM7EUR03FT036:EE_|GVXPR08MB7896:EE_ X-MS-Office365-Filtering-Correlation-Id: dd461678-340c-42ff-cb3c-08dac3e36c09 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +YCvejwn3dDDuWbQlmwzUmRMLX1rzjtV80AtSU8sON/mhtIJnab5yE2kp6agS4ZxU4pNYBgSeMN5lo6DoIQk8tvu3mvrqdt3HwRwdf3jgPr02xZELNb87C4onDldfrdXav8VUX1///Y3/5FZgPG6JCfLK84MHOIvn2pBp/lai0BvDNwX0egRxEdvcUsXVB/DGMaxxY5jzi65+tBRbScP6JnA0w/BGhqwdkZyQvkd+5vxKmrIwzQjS3T2pcOkj1t67UFypkpWy89ihcmhtgCZmqevkLq1ncm77UMQGOy+pu4efbimLTEQtraAibGssAT3RbZk81JOufS/VSakIKZe5dJB4F0T3u35AwsdY5VgEpvj46XU9pESFXeVdk3KsBk5UVw8bt08G2sU3G62zJsGpxOVpKSvLhnnaVK8wh9rFrz+vAwsJGPEIjer8VXqXgih3qtk3gahBD32Dzo6gUfJQeFSDtVsFy+YAGL686wgi7JWipnAFqJHD2RPa+QpYEzdKsTDgcvmy9HbtE3N0oPp3L+IdKKwMaLkvMQ4vQs0k/RKEM4E0nNQa/P4hJmtKAQ11V5JHr3czo90GF2m/AirCNZtCAezIb3unLhOdJINqlAlJ6DwxA26lGADEZu2uGbSIEmdJSgf//pavCdgz/30ZR9wU1iE9ItEHso3mBDAn3HUtO242hGjtenb/EK3yPOROe/Zb20NLBirOG0075dxntfaEM10Sn7JNWIVvoq0n8+5JXiNFLM0JTHRkmxEiRmkCRsm27d6gMG+FFbavMdOUmFwpM9U+t4YvMrEUbhqWut/oaHvwz0yOazMHJil9KDkqzxAStHkzzv5Kfj73WUJnyOtrTDZeASqWWknVVMpGmcXryGmvxqrUaWiwguWbapUresXLaU/d9Fspm/SuThR0xTtXcUL7d7mwpj3te3iWKY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(366004)(346002)(376002)(451199015)(33656002)(55016003)(71200400001)(110136005)(316002)(54906003)(8676002)(66946007)(66556008)(64756008)(66476007)(66446008)(76116006)(38070700005)(38100700002)(86362001)(4326008)(122000001)(53546011)(478600001)(7696005)(6506007)(26005)(9686003)(186003)(41300700001)(7406005)(2906002)(5660300002)(7416002)(83380400001)(8936002)(52536014)(59356011)(219803003)(207903002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9412 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1bb44c7c-f3a4-4769-e666-08dac3e36464 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GhiZkDNLYnrRzEvZ6iZZ4Q6gxPzODx3NbTRhFTduR6qK3jPtEb1nn7nyWY+MSddlekt5JlTRiTlxn89+S1/gtjNEb73nspxBVEJHTtvuufqPnKmJVYgLZDBXJIKUR5Gl7fGnbKDR/xzHgoLxLPxkxrRRymzwKrIjqNhgEi/4Bn/oFlyW6cysP0FqenMFWIO980ZEas3RE24ShPhBi2PNerggVBWzW9yaL8lMW9mHlv3YwBjY/1z9r4lPrbCOLUYJn+PgY5+z9q+dBDgPh4GIqYZJJvCN8ORDdbZxsMhiJSe98XmjEvWPteGtexVEqwqqflmPju/2WrO2mYhKeoZhFzrlzwqXYl7eTKjk5rTMQByxtQf+4A5/VEHutyG4eJc3PQb/15p1C0YXBC/HYv7P2e0XUYJ/23joLk/g/z6ENiPxLlsUw2VfeYPfbrtWIm3ro0I12OZ4v6WWZWcOWwcqkmwz38n/0z0K3jqxjdzL0t0GO7VkiuwgsgH73ESKpDNol9RaARpcNkxxPRlZusEZnuTwFqG4lupo2wFPRmiSQR/eXEsKdrnyODeNOUeH3Vdq2k4h9Nh3KGLKQaudC9O8PSSM9jcwWnDd6HI5DjSPCjLOVdaFGCXKdFZRLjtInHqo57esIw9bv4iVBK3Jd1tbhEqQwJpv4EFFVK3zsz1u6fg9nbEqCNddoMmAQG5kYsmdIsNIc1YMKfAeSLabwiFrKiidtM0MPn1gcXhM0psq5NNfWwsgv89BnPTDgd8cqlOKF3GhPoMMi+uHQMtjvrIMnLWdhARESypcqPT9o12sOxF0e5HZ4c/XSH3HX7rKjRXoZBs7b1Y2orUWm1MmqpzYEdHTuhidv49ZS87vCO/bxm6RPTpEsPla7pOMvzW2z//PD1T9THao2JKm94gCYJ1dWF+xYA6XWCmZI+CiUH1Y9yc= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(336012)(26005)(47076005)(53546011)(33656002)(83380400001)(6506007)(7696005)(356005)(478600001)(81166007)(316002)(55016003)(5660300002)(107886003)(86362001)(8936002)(2906002)(9686003)(40460700003)(186003)(70586007)(70206006)(8676002)(4326008)(36860700001)(110136005)(40480700001)(54906003)(52536014)(82310400005)(82740400003)(41300700001)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 12:51:16.3295 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd461678-340c-42ff-cb3c-08dac3e36c09 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7896 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFJl OiBbUEFUQ0ggMy8zXSBDSEFOR0VMT0c6IFN0YXJ0IG5ldyAidW5zdGFibGUiIHNlY3Rpb24NCj4g DQo+IEhpIEhlbnJ5LA0KPiANCj4gT24gMTEvMTEvMjAyMiAxMToyMiwgSGVucnkgV2FuZyB3cm90 ZToNCj4gPiBTaWduZWQtb2ZmLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+ IA0KPiBBY2tlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCg0KVGhhbmtz IHZlcnkgbXVjaCENCg0KPiANCj4gPiAtLS0NCj4gPiAgIENIQU5HRUxPRy5tZCB8IDIgKysNCj4g PiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykNCj4gPg0KPiA+IGRpZmYgLS1naXQg YS9DSEFOR0VMT0cubWQgYi9DSEFOR0VMT0cubWQNCj4gPiBpbmRleCBmYThjYzQ3NmIzLi5kMmVk MWZkY2I5IDEwMDY0NA0KPiA+IC0tLSBhL0NIQU5HRUxPRy5tZA0KPiA+ICsrKyBiL0NIQU5HRUxP Ry5tZA0KPiA+IEBAIC00LDYgKzQsOCBAQCBOb3RhYmxlIGNoYW5nZXMgdG8gWGVuIHdpbGwgYmUg ZG9jdW1lbnRlZCBpbiB0aGlzIGZpbGUuDQo+ID4NCj4gPiAgIFRoZSBmb3JtYXQgaXMgYmFzZWQg b24gW0tlZXAgYQ0KPiBDaGFuZ2Vsb2ddKGh0dHBzOi8va2VlcGFjaGFuZ2Vsb2cuY29tL2VuLzEu MC4wLykNCj4gPg0KPiA+ICsjIyBbdW5zdGFibGUNCj4gVU5SRUxFQVNFRF0oaHR0cHM6Ly94ZW5i aXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zaG9ydGxvZztoPXN0YWdpbg0KPiBnKSAt IFRCRA0KPiANCj4gQUZBSUNULCB0aGlzIHBhdGNoIHNob3VsZCBvbmx5IGJlIG1lcmdlZCBhZnRl ciB3ZSBicmFuY2hlZCBmb3IgNC4xNy4NCg0KWWVzIEkgZnVsbHkgYWdyZWUuIEkgd2FzIGp1c3Qg c3RhcnRpbmcgZWFybHkgaW4gY2FzZSBJIGZvcmdvdCB0aGlzIG9yIHNvbWUgdW5leHBlY3RlZA0K c3R1ZmYuLi4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gPiArDQo+ID4gICAjIw0K PiBbNC4xNy4wXShodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdpdDthPXNo b3J0bG9nO2g9c3RhZ2luZykgLQ0KPiAyMDIyLTExLT8/DQo+ID4NCj4gPiAgICMjIyBDaGFuZ2Vk DQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Fri Nov 11 12:57:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 12:57:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442512.696727 (Exim 4.92) (envelope-from ) id 1otTbM-0000Wa-D0; Fri, 11 Nov 2022 12:57:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442512.696727; Fri, 11 Nov 2022 12:57:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otTbM-0000WT-AQ; Fri, 11 Nov 2022 12:57:44 +0000 Received: by outflank-mailman (input) for mailman id 442512; Fri, 11 Nov 2022 12:57:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otTbK-0000WJ-Mn; Fri, 11 Nov 2022 12:57:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otTbK-00076X-G6; Fri, 11 Nov 2022 12:57:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otTbK-0006Ki-3Z; Fri, 11 Nov 2022 12:57:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otTbJ-0005tG-WC; Fri, 11 Nov 2022 12:57:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ri5V/LmzEDC2U+YuRRM/xPfEjZQhwB2Fqv5b/5HvfE0=; b=MgFEgikSa51/dVc/x63WwxrC8p D0QaTb/FwWU6LwPO7MA9Nk48g9JldiB+En6nrw5dgkodDyCFBped29E8vkjF4xIEwcA19C5z4+Kxq isY9VSykuVhO6oLNM8wkMYWU3J7Mp8zo2VqCH4quzo9Q2nLXIYKUbkw4WpaMgtMCYhXY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174731: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=697e26fac66d9b1458ad67261014284c249ecd2d X-Osstest-Versions-That: libvirt=2e16c9f20280fc051adea7544600fdc351415739 From: osstest service owner Date: Fri, 11 Nov 2022 12:57:41 +0000 flight 174731 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174731/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174706 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174706 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174706 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt 697e26fac66d9b1458ad67261014284c249ecd2d baseline version: libvirt 2e16c9f20280fc051adea7544600fdc351415739 Last test of basis 174706 2022-11-10 04:18:51 Z 1 days Testing same since 174731 2022-11-11 04:18:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Ehrhardt Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 2e16c9f202..697e26fac6 697e26fac66d9b1458ad67261014284c249ecd2d -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Nov 11 13:11:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 13:11:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442519.696739 (Exim 4.92) (envelope-from ) id 1otToN-00031s-LM; Fri, 11 Nov 2022 13:11:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442519.696739; Fri, 11 Nov 2022 13:11:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otToN-00031l-Hg; Fri, 11 Nov 2022 13:11:11 +0000 Received: by outflank-mailman (input) for mailman id 442519; Fri, 11 Nov 2022 13:11:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otToM-00031f-Fb for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 13:11:10 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2041.outbound.protection.outlook.com [40.107.20.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4adb3221-61c2-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 14:11:03 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6790.eurprd04.prod.outlook.com (2603:10a6:20b:dd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.24; Fri, 11 Nov 2022 13:11:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Fri, 11 Nov 2022 13:11:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4adb3221-61c2-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RwfDNt+f5JlEtUQdootiZnFJiXdur7Fz884/M30BFSNSX9/snCXMjMUlaE+t1XAq+tpPefu0q2UnQJw2xjBqD94yFUT176d+xiXkJXn/XmYvIujYTlMtNiqnONYikpGMWwml8DblOOzboBFpAvF04jBgdlSAkFxpuAvML28UnwKB0tJhtAeu8ekx2R8/+YXjA6SFqJKHubW/A1cTfBvzdJ1cqamhBj0a1xSvcY+Sv2242uH5pZIVKmH8vo/zSfH2q5qnCM0a0Y+RzOF1ddl0zTpKaatUTGHnybLyaiZaN/JDfPNToYfIj9Zisj4SITBFaOo0RKfPF5WsZI5s7Q1hgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=89qPfLStwqXJST/DW9eXDaWOqfPRcZ34IgPDI2WShGs=; b=l9wt+d6WaxED4BoaNpJpw2j78Y9SVev4Ihk9zjvD4MYsLQASGm7moO+I9r/GAW1tI0X7mUeerK6N4db+VuNDMmfg84dWwX96VZIV2PHLQQXTINroXFMysm7uYeM4cDBUMRwk03XpbKn27y5KeUSy1grX7nQ9O9gD420jd9Zw+Qqcpsd+2MjRmO7/qDis+zi3aqUCXn6TNdijCjafaOCdaiq6FZ1qEpKaNWXNl5/lp+/crOM10nfA8jzCpBGRX3F7M0sOQ2f36goh4ZbhTJn8PHLehRkc8Off8tI2Gm/ptFtgHlBCDpOuO3+9DyvSFX+BjYdMySJVtAOOoo0tlGWLdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=89qPfLStwqXJST/DW9eXDaWOqfPRcZ34IgPDI2WShGs=; b=z7sVuaxkQqiwuq1ehfczxhChHLrX0ThGGR6TatKdu7eQan81H3ETUroUQPRygKHBUIsEHRqhPFE34RbXe3EuUulWYzz7P4jZLlHleao1nY0Jx5KsUN70xrFgtPqCMv9YvGlQ9raxVFubE/sRXb9Dg6C7T2LsaIf1GHsaoeqG6n+j08T7rGtrvwRPcAwDVY5V/idona5aMPSrFG+6y00hRrCx5mP2ZZvRidO/1dCs76OaewgVT5wMXvAEvA+EJQEGDS0OtGxvET/FlYhINxbleTlPVM/2YWBjJrHRYZqhLWv7lTpzwTsUq5JzJ+f1yakbila4wNLYcgpJOFTYjdHVzg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <826eb0df-fb52-fa25-c908-977285a6ec8b@suse.com> Date: Fri, 11 Nov 2022 14:10:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Content-Language: en-US To: Luca Fancellu Cc: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" , Anthony Perard References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> <7d56c33d-4b03-9aa1-6abc-45a8ad41caca@suse.com> <2E0BFEFC-5BEE-4F8B-BD9E-94CB9A5B2BC9@arm.com> <9CE2A214-2D64-4BEC-A78B-393BF7AEDD9D@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS8P250CA0016.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6790:EE_ X-MS-Office365-Filtering-Correlation-Id: fae1eae0-d5ee-4145-90f9-08dac3e62d7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IXkDWlL+I0tFIt0AVwYMpPzrcDsUasK5Z6/j3LNFV3wX33EezsWn+m5aBq/LQiln+HOjSu/X2qxYKB+CLE/dplEEWPCmgix5xE2G8cW0UAMBWVdnVTLQ42DqNhkxTs0n7Mhz5BzoYBtlDD+rt7RSdZRN5Vso5Cn7SWDS7sgDd7uV8SW4eVGylQBjzWiCiIo8D4y36q5MNlfXmpfCiC7XtVtZOKqSHboYRv22buy2myZYVfaSbIRyWKs+fsi9qOxyNFTU9MSYGPkuROmhZ858abPwgv2c6RrDtJ9t56sS4lV6uVfzNU6Y9V72ZxufkXpKFOryUMS3CJcLlKmDoFWZwShD7w29x8p6saCZRHjPJz5Zz8Q53onPlJKJwUQB4DK62BNmWxtlixtpdmK974z7A4QMcHsgTsEdWy89/owAEPqgOFbS3IV0ru9Wdb/aBPhn1J0mRbyfeovBsEKaRc4bgCwJZnAjrULfjoWCYLSt4gCj0QkFrBh0XC4WLy8QvdQP3rmLvochFA8rUECn0mavdwZ5hZ8jXnALA3k8e6HQ8vmhyfJpOoOFufKxQlP4Aho48nx2V++T8iiJNZzVE2iaxzmm0T5O6B0j9sRrDGiw3fctcAmPRG7haMuNECIGfes07sHrHZEWD2AQMg/uFn4/3ssSlaaz1zp/M9FSknqOVnwf6pADWbNwIK6pWUVnN8Sy1szcSWG3SCBvj8uHZLwCFQxL7W39LPNQEd42vV/SJatuW2xC9WGWR2JNAXQdUoZxJ1x+/GfmcVovjslYUYOJ0X/yXwsUD1sPVUPlVKbY984= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39860400002)(396003)(346002)(366004)(451199015)(31686004)(31696002)(6506007)(54906003)(36756003)(478600001)(86362001)(2906002)(6486002)(38100700002)(53546011)(83380400001)(66476007)(6916009)(6512007)(26005)(186003)(41300700001)(8676002)(4326008)(2616005)(66556008)(66946007)(5660300002)(8936002)(316002)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGZtUlpTTDZYdFgyTGJTYVRnTWExREpJaE5vdit0dlIwMUJaL080WFROV2Q0?= =?utf-8?B?ZG5QSUE1SHJXaUJMczFIYTkyZm1hNGZ0THorRm9QcllCZ3VNTi9aOEZBc29x?= =?utf-8?B?cm9aZ3F0Z0ZpRU5GSGJ4bkhvQWlCZjFhNnJUUUM4Tll3dUVZcWNaV1dRNWF0?= =?utf-8?B?SGs1bnZ1bUdpRXlUeGNzajF0YnJOMEdSRXRuMmlZaENvcFM2clFnNmNxR3h6?= =?utf-8?B?aUJFK1ZzcklheEpiYlJPcU9Fc20weTRsUk1lUXhoRW5oWm9WNXQyd094RVdO?= =?utf-8?B?Q25QbHR3WGl5TXpBdHJLdFhNWmtlSjhvK1QyT216SzZ1TjFNbkk5d0xPK0xy?= =?utf-8?B?VlJUMXRPNUZXTUptaURYQ2pMYkNwOU5mdTdZZ29objlHM1ZNZFZzRVNrQU9K?= =?utf-8?B?ZVJjSlEzbTNsUFVsWDBhejVQR1VlbHVkMTJzMWxEWWVCL3dKZG1rakFkUU1q?= =?utf-8?B?WmRlZC8zbWR4azNvNXlpN1haSktZWkd2Z1c4R0IvYndjcEVEaHU0ZGM5Ny85?= =?utf-8?B?T3dYK2wxL2E1SGNpL0tYaW5abEN2NzJRY25QMGlzM2JhMHhkVktLN2w5UFVK?= =?utf-8?B?ZUUyU2pqWm5YeFJ3UzJpcWYra0txMGR4Ujh0Qlh6eTcrSkNGa3ZrdkhVeEcx?= =?utf-8?B?b3k4a1Zuc2FodUpnVXV2YXdxbHJ1OFBiRmRrUDRucHJxNDVxWlVKOG93RlFB?= =?utf-8?B?VmQ5Z08yYjl5ZnV5c0ZYS0lpQ2NBblR4YlF6RUtKZ2d1NHBVV0NTS2NyQWtl?= =?utf-8?B?Qk5kREE0bUNOUlZOMGFZTGV1aU1OQ20vUkxyRTZkeXVLVU1yR0RPc1ZkL2tr?= =?utf-8?B?cjJJK0poelovRmRzR3dXazNlRHc5OGFKK2R6VHE2KzZhODczZ1ppc21qWmRM?= =?utf-8?B?bFRHVWJHdEZ0eHJzT2x0c2YwVWg0Nm5GOEtrUGVqNUpzcVJmeEpYZGZRVjJh?= =?utf-8?B?R2IzdG5INmxVaTFlb0h3UlNybE5BaEpqanM0RkZhSEN0L0pXbnNncG5HcVBG?= =?utf-8?B?ZVVjT0Z5RjRZY0FzcFVHaUN6N0ordkYxZCtrdEVGMWJDM1VEWU1UTlVZY1p6?= =?utf-8?B?MUNraHhuclRUSzZpNm51QSszOEV5T09PWnYvclVTWWx6blhGdURYd1RyeUVo?= =?utf-8?B?d2ROcThMRmw3eDJ1MysveUZtZzNTMzZwZ01UZk8rUUc2OStRREhFOW1uYVR3?= =?utf-8?B?V3Q3MGJMSVdrdVdNcUJGeFdIY3ppUXpUejdqY3gyV29kUTZINWIxN1B4a3NJ?= =?utf-8?B?dHY4OUF2WTJ3ZWM5WXh2V1lpUlE0bHZwU2wrTjlpbEJXUGJHa1BRT0hqZGps?= =?utf-8?B?NDZGcTlGYW92V2RMVE1BUUl3UDcxSjdRSzdKc3IyL2tZWUttQ0NOdVd2UDlj?= =?utf-8?B?SEJOdlFNQkE0ZlduUTc1UzdZU2hHWWw4RXBKaUllcmxiSCs4RDBSZTBYZEM5?= =?utf-8?B?YSt6OFZpcXdQUXI3bFVDWFhwWjR4NWxJeXU0UFRwNUJVMTdiWFZoV2FFZisr?= =?utf-8?B?LzNNSTlHcUYxb1NpWUNscGttL0xkbVBnUm90Q09kY1B5bHVWSFNSSDVtR1ZC?= =?utf-8?B?Z3FId2Z2TEwvMnJMMzE2WlhyQVBMeXZkdExpSlBmME1TdFV3N3pwTS9pQm1i?= =?utf-8?B?WTdmQnU4dnBSQ2lYVGlNSDUrSi9VTFRDZ2pmNmNoNnZtanVVZVFmd29lME1Z?= =?utf-8?B?MDhUL1c1c1lhME44SHFCOUlnMHBaTTBWL0hVVDZZczlZQ3o3S3lycVdjd0oz?= =?utf-8?B?d3dEWTc4VUxwWGlGLy90Q2lrZHhpdW1BNHY1c09yWWg4VHBUNDltdzJuNFE4?= =?utf-8?B?OWc5RlA2Szk5K2NoSGFTNXBXZE5zYU92TVI3T2pTYlBOaGdUcldNd3VSNEtq?= =?utf-8?B?Q3lyQWc1b0JLVmdVK1hWNkthRmlOUXI2RjlxR24vayt6cjRyRmw3TkVCeVpN?= =?utf-8?B?a05PMHJDblo0ZXYxeVBKaXFCSWFmdWxQWXZhS1owU3ROWU1rdFNMcURUaFNl?= =?utf-8?B?S0lHaUNIUDY5V2dZZ2VQNUFzYkUyaENINmtQMHV0aytyYlJaQzMwZ2Roazd4?= =?utf-8?B?dVN0VWZYL2R5SkVoblhBSVk5UzBlODNDRlBUeTJRNXJVTkVRQllWdm9hU3Iw?= =?utf-8?Q?/z/8GWMmeeTKDfAZ/evPPKLK4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fae1eae0-d5ee-4145-90f9-08dac3e62d7e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 13:11:00.3416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QmnOA4mztcfYva0z/O3dzhzUbX/Psw01rlt/kcxOoOYgHf1ZYoI6fM0WZmgfQRvHrvYW7XOORQaEuJmNfWQEBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6790 On 11.11.2022 11:42, Luca Fancellu wrote: >> On 9 Nov 2022, at 10:36, Jan Beulich wrote: >> On 09.11.2022 11:08, Luca Fancellu wrote: >>>>> On 07.11.2022 11:47, Luca Fancellu wrote: >>>>> Now analysis-build-coverity will be called, the best match is analysis-build-%, so again the dependency >>>>> which is analysis-parse-tags-%, will be translated to analysis-parse-tags-coverity. >>>>> >>>>> Now analysis-parse-tags-coverity will be called, the best match is analysis-parse-tags-%, so the % will >>>>> Have the ‘coverity’ value and in the dependency we will have $(objtree)/%.sed -> $(objtree)/coverity.sed. >>>>> >>>>> Looking for $(objtree)/coverity.sed the best match is $(objtree)/%.sed, which will have $(JUSTIFICATION_FILES) >>>>> and the python script in the dependency, here we will use the second expansion to solve >>>>> $(XEN_ROOT)/docs/misra/false-positive-$$*.json in $(XEN_ROOT)/docs/misra/false-positive-coverity.json >>>>> >>>>> So now after analysis-parse-tags-coverity has ended its dependency it will start with its recipe, after it finishes, >>>>> the recipe of analysis-build-coverity will start and it will call make to actually build Xen. >>>> >>>> Okay, I see now - this building of Xen really _is_ independent of the >>>> checker chosen. I'm not sure though whether it is a good idea to >>>> integrate all this, including ... >>>> >>>>> After the build finishes, if the status is good, the analysis-build-coverity has finished and the _analysis-coverity >>>>> recipe can now run, it will call make with the analysis-clean target, restoring any .{c,h}.safparse to .{c,h}. >>>> >>>> ... the subsequent cleaning. The state of the _source_ tree after a >>>> build failure would be different from that after a successful build. >>>> Personally I consider this at best surprising. >>>> >>>> I wonder whether instead there could be a shell(?) script driving a >>>> sequence of make invocations, leaving the new make goals all be self- >>>> contained. Such a script could revert the source tree to its original >>>> state even upon build failure by default, with an option allowing to >>>> suppress this behavior. >>> >>> Instead of adding another tool, so another layer to the overall system, I would be more willing to add documentation >>> about this process, explaining how to use the analysis-* build targets, what to expect after a successful run and what >>> to expect after a failure. >>> >>> What do you think? >> >> Personally I'd prefer make goals to behave as such, with no surprises. > > The analysis-* goal requires a build step, otherwise no analysis can be performed by the analysis tools, so I hope we agree > we need to integrate that step as a dependency of the analysis-*. No, I'm afraid we don't agree. But like said for another piece we didn't initially agree on - if others think what you propose is fine, so be it. I'm specifically adding Anthony to Cc, as he's been working on make rules the most of all of us in the recent past. > I understand that the analysis-clean might be a “surprise” if not well documented, this comes from the need to substitute the > tags in the tree (to keep the real path in the report log) and to revert them back at the end of the analysis. > > So, such script should just mask to the user the analysis-clean invocation in case of errors (with an option to don’t do that)? Hmm, here you're saying "such script", which looks to not fit with the earlier part of your reply above. (Just in case that's what I was to read out of this: I wouldn't see value in a script which existed _solely_ to make the cleaning conditional.) Did you consider the alternative approach of copying the tree, altering it (while or after copying), running the build there, pulling out the result files, and delete the entire copy? Such a model would likely get away without introducing surprising make rules. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 11 13:17:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 13:17:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442523.696750 (Exim 4.92) (envelope-from ) id 1otTuG-0003q0-BQ; Fri, 11 Nov 2022 13:17:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442523.696750; Fri, 11 Nov 2022 13:17:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otTuG-0003pt-8b; Fri, 11 Nov 2022 13:17:16 +0000 Received: by outflank-mailman (input) for mailman id 442523; Fri, 11 Nov 2022 13:17:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otTuE-0003pn-Er for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 13:17:14 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70073.outbound.protection.outlook.com [40.107.7.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 27b76aa8-61c3-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 14:17:13 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7305.eurprd04.prod.outlook.com (2603:10a6:102:83::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 11 Nov 2022 13:17:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Fri, 11 Nov 2022 13:17:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27b76aa8-61c3-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ANXkdngUoHz2SdpUe5XRaK48zCD1icWa9slvhMiePhKHU6m0XI5L7GujXvabU9Z7yNz5Z49L01rVivVgxmw56KRJiySH/r1Hnlq95Ma+jCKW85d7QPSDCjhGJNA3lQGbR94CKqNQTehfeYdXVPde/5FVX5iF4JHEz/iqq+sPTa6Egpygg0k61bt4DAGnwRRheadOWhoBNVEUMjX/PNrQyUfBkun1FNBufYXnFZP9bhK64ruoGyDcj8bjZTTilsibTskRHerlG0noIh3Ds7xGx0oHAMzJmBkIbwh7fCTkB23gLWQyTn4pLlkkofwaarhnqaz9LN6UTSKuQHMzRli9Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7gVJNPOdGAhOJDsHLjXSVBNI9ScG0dhMwplf0lU6tTs=; b=IomPxy1R+MGiXjxz84+K9v+8a0dN6iGd+ScY3BwJ9wFGXBa+dq6UNff7JU97ltbuMyOxZLkJ+oNXPpBc/xzirNaw46tRnABngBn5plWtduRvhCXve4QqRCESEeiP//dRNeV9C3QD6H+Is2+TL86oeR5F02fetASlRryCcwkAW5hhlmLnO235Lk8o2mUX1dpRusiNjs2D3tfFmLM3VDAvSIg/ttNqeJpQZTXYuqRbfuOYvCE6r2u46OaFoTWrBjlSE6G4tlNBIhVyVANyOVCdxMxJfnhxSYCUo36RtZI6kPG81sVZPpdYKHjD/k8CICsknHio78qHL+H35oSHfJ4Lmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7gVJNPOdGAhOJDsHLjXSVBNI9ScG0dhMwplf0lU6tTs=; b=wngRwgYWM92C4S3R0kit61Z8KJ5U5w+QWEI+Q3H2SML5QrzAQ6T2lAMde3/vdRjL8DKYRA1VPg4xXTmvxpw1CMH7iA42QrDQGaja2MMORMRi8nzqPx3glK6yh/MSTCoJaFo4z6PrZGuweGEjUa3Za8ikMilXVnOHUgHTsasmzen+WaO+/qKQli9/ZZSj/4PygAa/D9eQKWMg1LkcZjcFPAwJTHyxxW2aYBWJ7Pjfgy2EAhhLehCrnCg2gBtMNkqUvtLth0oyokabKfLKJ+xb8LvwoLp1cZVC2wC1jISCYyFUhnElmt1WZ2OrSDUnpkx3kIz1pIQtcLK8tSrH7hUJ/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 11 Nov 2022 14:17:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v4] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Content-Language: en-US To: Juergen Gross Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Oleksandr Tyshchenko , Maximilian Heyne , xen-devel@lists.xenproject.org, LKML , Stefano Stabellini References: <20220729070416.23306-1-jane.malalane@citrix.com> <1918c63f-0065-b468-3691-de6e314f4374@suse.com> <9ab99257-844b-de15-cd20-7cda61295186@suse.com> <2476e467-1c31-91f4-1e75-86723b8da486@suse.com> <3cd62b0b-a131-b709-4244-0ae694c3d022@suse.com> From: Jan Beulich In-Reply-To: <3cd62b0b-a131-b709-4244-0ae694c3d022@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0098.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7305:EE_ X-MS-Office365-Filtering-Correlation-Id: efbb3f72-791e-4c74-45fe-08dac3e709ea X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FCbG47FCQl6AjfO2+RL0Lg6rguLhSfxGiQh30xwYB5SI7eLTCNLWXKQYDDMc8cXEw/9sYGMQFn0nCZRDMlEWtCsxbNAPIumgWL1TgHobeje/lH9AjeKgAkYcCY76kLxTBKGp08ahN82YgUyVfNcuHdrw+Z7n/+q4QZS66geQDhgajE5DpNdqgFNUH7Ed6NUWUtbKBUoPqYfLUXCCMmZt+zQpF8dU5PDBkgetqt6LsKrLMs7lF6hFixMn0bMQFTbApP9mUhLE6pVrXQnQnmODJ7LjEE+DHB/Eq/+7NIl7/UIwPbpn1/oM4wXCo7B2Mb43KMU/rg94+krGwR3ET/HxKsLuu2bWWns6HOIn4L/euw0Mshmd5AH33j+ihaSTiWcL9pkjJ3V4ZeddU9Ya1j2+yRxUm0ROu3J8xoEr4TCt+zuEgSrvx1Qpoc0uHaJp39EI6asR4jMKhGRnPUY4OKu4qSBbCkgtKF5D1yyZOqwKNP3DFHQKWjZt4zoKs++vz1kjjVj7NJZESkIX5YoLY2mLYyc8Wu5YaIFzj5jJ50rFx+y5g8dytmWKg5i9fqYoZ9CvXaOkzpkxRR7DzobHsWDD1kA1Rr38F+viHSozqcQV0JDUWn/iP2sgiV1BJqEreCkNtqKFH5lnRPncgtURKAa447E+smbaBUKFDoO25LIumXFCJWgLw7fj6EIvDghncFJR9G80Mc9QgCS7U9+3KltEHZyvcNITTPAj3PbSpsNu8BaN8IRaS06fL4mNZ4UWMhAnQAwPDvq5G+Ce4lzoznSt+Lz0APt8T7/UCfDl4R4rgsYsJoXamnrjZ9VgwHVYCuieNTTvfNWg8UaJQumr6miPsA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(396003)(346002)(376002)(366004)(451199015)(38100700002)(54906003)(31686004)(66899015)(6636002)(37006003)(316002)(86362001)(83380400001)(2616005)(2906002)(36756003)(41300700001)(966005)(6486002)(66476007)(31696002)(66556008)(6512007)(66946007)(8676002)(186003)(4326008)(6506007)(6862004)(5660300002)(8936002)(478600001)(7416002)(26005)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NCtTa0NRdmF6VHh1cU1xVkY4MzQvSGZ2WE9RVUVRZENId002elJGOEhVdXpV?= =?utf-8?B?S3YwRVdyeVFZdWc3VWVZdzBIWmdwZllsSU11bDRsODBIM00xaUNVN3QycUZX?= =?utf-8?B?aEh2TU42RURTZ0ZoYkt1L3QwZmdEMGNUVDdKV3NQWFdad2lQbEpSczkxdzRm?= =?utf-8?B?VENHS29LSEdITXFCTlZwUlBIU2VVQ0ZhMzlUK3hBS3RKaHNZaUNPQUtZVzZS?= =?utf-8?B?N1hCSnlob1JGMnd5TlZubWwyL3FhWFRsU3hKTXZKOVdBS1hIdzhJamw1WS8w?= =?utf-8?B?MVd1eWsyUmxKM095dVBNMFY0Mm5IWVlaVm0wYVhmN1JYVjlJbW5SS0R4d3J2?= =?utf-8?B?RGtReVUzbU9Uek5aVm1vTDd4b1FmZ3JpeUR2ZVJwUVV6bVRoQnUycGtoZkdn?= =?utf-8?B?c2Z2QnJYQjY0WmM4OFdmOU4wblJKMmoxYlBuN1NER0JNMTg0QzlUNk1JRCth?= =?utf-8?B?ZDRXTStHSTBPNnhNSXh2VWlLaU4wZGwwcmNFNG5wMHRHZW0wZW50L1UwejJO?= =?utf-8?B?cnBhK2NnOTJFRHVncW5iWVF2Y1dqYW9ab3p4MDhIK0pDSmdWUEN6NUNVL3dM?= =?utf-8?B?V1hXalZzT1RtZ2x2RmJ1ZDQ0ckJSV1lBNWc1SFdhWVNoZitFTEtwTzJhNGo4?= =?utf-8?B?VjFNTzJHSUp0cE8wU25GNDZkZVRoTUQrWEcvQnFRbWthdnhhK0xCUjZHaVFG?= =?utf-8?B?Q3hLMDIvTkNnbEpIR0g5NFBvbWthbHdtR1ZkT3d1MG9PTWdTY1FsNSt5QXUx?= =?utf-8?B?RnNpODNIeGtWQ0oyenMySTd3UW1ZenJJMkpsaDJqY3E4cndYREtqWitwdW43?= =?utf-8?B?U2s3OVVpcVpEdEZwM2MxbXJSVStMKzgrMXBSQ3UrWStONkRMdU5NMUhjSis2?= =?utf-8?B?RmU3cHVLZURuNVRIOG1XRDJwTlEwcGRHQk5HUDF5L1J2cEFIK2NZWkp3N1d3?= =?utf-8?B?UlEzTUJkRDFKZFBFK0lmOGQyZ3ZIcTdHeWRiNlJaY0Ixa1JUOUdsZ21lS1cw?= =?utf-8?B?UStab0tBVjdXNVRuZHAxVG52bE5sQ1lDTzRQQjNOQzdITzJ2czkyeHhLaEM2?= =?utf-8?B?czRyRHEraHduSFVpOXVrbWlvR3RrWFU1U2VXM3dieDZUeW9JQ2l0dGlFVWZD?= =?utf-8?B?bis0Tk9SOEtPcjB5U1ltUGl5TjZtZkltT0lZZU05c2FMemJaVi93bGR4ZXlI?= =?utf-8?B?Y3ZCK0gwMW5RL2cwSmszUzhaQjA1aHIrNi93TE8rVmtZakY2ckY4Z3BtVkpJ?= =?utf-8?B?aHJQczlad1BxZndON0F1SVc5dzFGbWZIb0JSTFNINzVkUjA2L2x3RzRlSWFh?= =?utf-8?B?OTdBcy95Y3hRZmFxRXVuVGNueWRkU29HNlR3YXJrWk5XNnVZbklhaGpIZU15?= =?utf-8?B?amNnekRzVFdnWHpFWTV1NWFqLzNOODhvbmJGbkduL093dDU2cG1pejZESXdB?= =?utf-8?B?b1BnK2FaVGltZ0hoejBuTUxVRUpFTS9MWkxEUllzcmd3bUZydWpTcm00ZGho?= =?utf-8?B?M05FT2p0bStyS1ZqRCtaY3FHQ3lMdlZSaGl6RkNqcEVxME15QXd5c3daVDFl?= =?utf-8?B?aWhuTEJENTZFV1hEVXkzTU1IYVdHQnFXcDBZa0ptbHJiOEVvOVFaN3p6RnU3?= =?utf-8?B?blhKcU15RG9nZVlTbDBoOEY5ckp6YU8ra21kREE1bUtiS1NqNER5THlXVm0x?= =?utf-8?B?Q1o4OGZkZUYweGdsbTFWMmIrbnh6VllqSmdSYnNYeTFYYnVFNHUrbU9hZDVi?= =?utf-8?B?bkdHRXl0bms2ZUNna3Fmbit1blo1ZlNSUW9pMm13TEc5aHBWaEM3T3JZeFNL?= =?utf-8?B?MkdzbTJzVnNZN3Bucm5zNGNhQm8rb3l4d3hPZlNFS3RodWtwN3h0aUR1UFFt?= =?utf-8?B?Y3RGd0RKTVcxQ3RkcytxNnFtaWNnZDgwaGxvVUpoNUx6WkhnakdIdmVBWHR6?= =?utf-8?B?M2R2S0s4alc1NFR1eTFOTnYyS212TjZ1eW55b3d0alRmOEhTVXord3phQ0t4?= =?utf-8?B?aDVicGhXRi9zY3hlZ01TM2RIUjNaODM3Wi9qTHkwSVA0ZVRLUHo0SmJBTzZE?= =?utf-8?B?UnVTSTVYWFhDRmY1ZzRkb1FlNFdINFNLVnJBcnJKcHBDSnc0RWpDS08veXRF?= =?utf-8?Q?mvHoLO96GjUf++D47rotIFtq5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: efbb3f72-791e-4c74-45fe-08dac3e709ea X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 13:17:09.9118 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RfuH74SsjDif+Gm6NJAymNqZZgc5OklAZHvskt0ghbqSQiG923oi8CP6Tq6GPeQNT5NFZWxudd5ToLaltBU2VA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7305 On 11.11.2022 13:44, Juergen Gross wrote: > On 11.11.22 10:01, Juergen Gross wrote: >> On 08.11.22 17:26, Jan Beulich wrote: >>> On 03.11.2022 16:41, Jan Beulich wrote: >>>> On 03.11.2022 14:38, Jan Beulich wrote: >>>>> On 29.07.2022 09:04, Jane Malalane wrote: >>>>>> @@ -125,6 +130,9 @@ DEFINE_IDTENTRY_SYSVEC(sysvec_xen_hvm_callback) >>>>>>   { >>>>>>       struct pt_regs *old_regs = set_irq_regs(regs); >>>>>> +    if (xen_percpu_upcall) >>>>>> +        ack_APIC_irq(); >>>>>> + >>>>>>       inc_irq_stat(irq_hv_callback_count); >>>>>>       xen_hvm_evtchn_do_upcall(); >>>>>> @@ -168,6 +176,15 @@ static int xen_cpu_up_prepare_hvm(unsigned int cpu) >>>>>>       if (!xen_have_vector_callback) >>>>>>           return 0; >>>>>> +    if (xen_percpu_upcall) { >>>>>> +        rc = xen_set_upcall_vector(cpu); >>>>> >>>>>  From all I can tell at least for APs this happens before setup_local_apic(). >>>>> With there being APIC interaction in this operation mode, as seen e.g. in >>>>> the earlier hunk above, I think this is logically wrong. And it leads to >>>>> apic_pending_intr_clear() issuing its warning: The vector registration, as >>>>> an intentional side effect, marks the vector as pending. Unless IRQs were >>>>> enabled at any point between the registration and the check, there's >>>>> simply no way for the corresponding IRR bit to be dealt with (by >>>>> propagating to ISR when the interrupt is delivered, and then being cleared >>>>> from ISR by EOI). >>>> >>>> With Roger's help I now have a pointer to osstest also exposing the issue: >>>> >>>> http://logs.test-lab.xenproject.org/osstest/logs/174592/test-amd64-amd64-xl-pvhv2-intel/huxelrebe0---var-log-xen-console-guest-debian.guest.osstest.log.gz >>> >>> I've noticed only now that my mail to Jane bounced, and I'm now told >>> she's no longer in her role at Citrix. Since I don't expect to have time >>> to investigate an appropriate solution here, may I ask whether one of >>> the two of you could look into this, being the maintainers of this code? >> >> I think the correct way to handle this would be: >> >> - rename CPUHP_AP_ARM_XEN_STARTING to CPUHP_AP_XEN_STARTING >> - move the xen_set_upcall_vector() call to a new hotplug callback >>   registered for CPUHP_AP_XEN_STARTING (this can be done even >>   conditionally only if xen_percpu_upcall is set) >> >> Writing a patch now ... > > For the APs this is working as expected. > > The boot processor seems to be harder to fix. The related message is being > issued even with interrupts being on when setup_local_APIC() is called. Hmm, puzzling: I don't recall having seen the message for the BSP. Which made me assume (without having actually checked) that ... > I've tried to register the callback only after the setup_local_APIC() call, ... it's already happening afterwards in that case. > but this results in a system hang when the APs are started. > > Any ideas? Not really, to be honest. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 11 13:25:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 13:25:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442528.696761 (Exim 4.92) (envelope-from ) id 1otU1l-0005Ki-8m; Fri, 11 Nov 2022 13:25:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442528.696761; Fri, 11 Nov 2022 13:25:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otU1l-0005Kb-65; Fri, 11 Nov 2022 13:25:01 +0000 Received: by outflank-mailman (input) for mailman id 442528; Fri, 11 Nov 2022 13:25:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otU1k-0005KV-BQ for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 13:25:00 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062.outbound.protection.outlook.com [40.107.22.62]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d595eff-61c4-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 14:24:59 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8711.eurprd04.prod.outlook.com (2603:10a6:10:2de::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 11 Nov 2022 13:24:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Fri, 11 Nov 2022 13:24:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d595eff-61c4-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T3kk2oo+vNJsFt/veyYzS/3Zv1KavYTjHVBeM72eiG43mExVKuTBfxoQuoS4DDpu1IDlcjorSCL+G7/CXjt8jmIifc+6kezVe9+RvYkSoCyxe2FohoTN90G61iudQUg2YQRTeLFjyIwdiXE5WCckgLzg6O+ePTL/wkypPg0okSSPcQ5rnSwK3Oo+Ta0R1aYWizqnU07ejdgrzFWkVYkscpImcQhX+Qicj+EIgTpAgbiIhXu/RlkNz5jNsWSs81LbB4gvAAYEhWwAvCjrNkGNOVhLpLxcjLw+b8nVp0Z2snPzlAwPV6J8Ow/Y3z6eKQPkGhPZEglXybig2rOzEQpflg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nGKe9HZwjhkuwHoS3sQ1ZbGRV9Am9GDl/MNAwMSTwYU=; b=cfC/3BdDZJWS+0x2IgnEzoOMBDbrrjc+ghdl+IBIgJlt/fKP/YNu+C6Fwh2LTGpArslFObaJzoTe0EbThPKAAegeurSRwc1Nu+8CIdCE2iMOg4IdObxYtxOLPQdXdtic3TlbckYyx3jUEPPMZ3mOHcPBEefM1uldZDGr9eEMlYVR7dnmH69Bnq2PhvFrIYmiafxuu1+1z0Fb34BjxIxmTGSPxZ3+rzqXWfvSB3MksEymwC32mivqCWENM6UxK1N/Mqf5k5577yPt8a3OzcoSj+gFzgOPwhwaWrHFPitD47z1x9MQ3ORiRhfSvxn+T0TFndXm74hGg/NYBwSISpQGGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nGKe9HZwjhkuwHoS3sQ1ZbGRV9Am9GDl/MNAwMSTwYU=; b=rJZBLX161kPf9ZO0akaC3xyaOlgkIaT+/h7I8qW0x1PatkL2e5x2Q/3RDIHQmJbJdocb8SXj0+aThjG58DiMEXv1WfUjzsKrv0kk++5E1Jda24o7W/WTMGdU9DwfwRsxFdwu9ZJmOo6+WbchCc5tF18dHalK7phB8UIhW1K61eYBTarc1dT5unqYHQaA/cGM4j+O2zyS/hQvFGOLycWCyq4gKhX7ph8ov4VUXeqbsiQObrhpnNOF2l8E0lpjI8sTt3t5aOAi99m0KIFj9/BLsA7VOsNien/A3f0zFPF5vnZ5/qIBRSrZG1PuCkJ46njj3VKS+qeBoW/9x90SnhAKAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4482952f-86a9-d232-6cf5-afa6523012dc@suse.com> Date: Fri, 11 Nov 2022 14:24:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release Content-Language: en-US To: Henry Wang Cc: xen-devel@lists.xenproject.org References: <20221111112208.451449-1-Henry.Wang@arm.com> <20221111112208.451449-3-Henry.Wang@arm.com> From: Jan Beulich In-Reply-To: <20221111112208.451449-3-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0132.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8711:EE_ X-MS-Office365-Filtering-Correlation-Id: eaec810d-797c-422c-683e-08dac3e820c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1S4xbyMVYf0C/HguHK93ryMMWbjI+yJvDCfhv/OOz9FbxoPI3V7t6RtShE2mPmuM3nYlDJV4wvfICHJOJaY9caouYqzAsmFwLB53iUsdZNbfTDGyONryf7U8o4hRK5VEcJnMVevhKvhlirzVPHF08Z9dezwPqX6DTQJmMNQ+JFrP2ZJ0UCd/FBbMuF43uT6n9Wy0hmHUI6GRHCVuBtQP7NJUJ+5ZhgpEJPPjEJHPms+ZQmxuPWDEEXu2efUlQBsODAajC9Nr50yna7cq4C30rKDekKFuobr3kW0Xb0wJfYJuNf5vGiMHYw4waMjzH+gHBrZ8h9hT6TkJzicvoXpvZW8drRZMV3PIevTadjgWpFESh1QtviqUyrzoFRwhA+9xfMIK5furyfGp0Hi+P3AdVMlP3T8RCYBQ7HKhs+egymkVT9Tqb5M9QyaNOzYgZB9pHKzQUCt+GRkbdRq8UozwRPw3CLCsXtod0kddx7sdQUT5aMMZtlRbk863fwu14WuioZQNqDUkDb7nNCG5gJiAwTE/PE7L3I1t26/AsegK9EXKcVtZoGv4uySuGXL/1SKvcNaPOhrLJTYT83MZ+PBSKF1DCT/uPE+Y4rNyKlrQ+E7LHAio6ja2tel87AK84sl4L26zIiRarFnXj3x/cNro1ixNwixP3f2DbVa/ov9ZZzQqrd1AtlPlejthE6altUTjuF+p5YjzbHsD/aCUqE9JM/UT2J7ekAHuF/vgaZH77SWWHPis0ea2Xu+b8UVkzTLQVt/poyD1jVj4Mw9dumKP17rcQPCLoSInV1HXKyu3x/6ahWe1/vjzJkYd9R6HjrZQmHI/JnN21n47nOGtQxqkb1gM5y/PvmKJKfbYCnANnpvhE0cR3I1F0QOIPLhTrQsK X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(366004)(396003)(136003)(346002)(451199015)(53546011)(6512007)(186003)(6506007)(6486002)(36756003)(31686004)(4744005)(2906002)(2616005)(478600001)(26005)(83380400001)(38100700002)(316002)(86362001)(5660300002)(4326008)(41300700001)(8936002)(31696002)(66556008)(6916009)(66946007)(66476007)(8676002)(59356011)(219803003)(207903002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWlTLy9OekRacVNGME9SZ25rVTlSZW9EZWFMS2p0QnYvdTFvM2dKY0c5ekJO?= =?utf-8?B?WGgwb0xlaDV4UkZpYy9OMEsrZFNsY1N5OXRFTXJEYmgrb0NCdDFwZzR0ZUlY?= =?utf-8?B?Rk1mQTJqZXB0UEUvNmtKR0RsNzJHMSs0QzRHU0xnU1VpUWJxN0I3VW0zK215?= =?utf-8?B?Szh0UTRUTzdjOStsY1ducERDT1hmVmtlN0Z6U3c1aDAvRENLLzQvZ2NRbnIw?= =?utf-8?B?QjZhaVNNSFdiYkxoZ0kxejliYUIweXBGMkNkWCtzejBWVlZkd05jYzVmTExr?= =?utf-8?B?aCtZemxNVnRoTXpibUtGd2FtUGZqenh5TE01Rm1mbFBPOGxvb3NPbmwzZlVo?= =?utf-8?B?ZVpUaFFPSVpXNW9DR21kZHRYMWxHbjhyblVVanFpQ0RJdVFiNG9GNUlMaDlk?= =?utf-8?B?ZlNtNk9tUGs0RXZWS3dFMlpCWVNaSWhUeGNzZFl5WEY4TjdYZjNBMHV2QU9M?= =?utf-8?B?ck5UOHQ2WmtmM0lWcktzQzRYN2FwNFVtTXR3RjJHQ2FEcVUvNWUwcnM1SDZw?= =?utf-8?B?VHkrUzkxVTRDNVlndG1hRVpHbExwU3VHNGE3cXYzUU9pdDRlN0tYK2xoQk12?= =?utf-8?B?Q1JlUVpYN1RpS0hMWnRqSUhzNjcyTHYwS0NBaVdybjd6cklFUGhxTVdTNHN0?= =?utf-8?B?TlJSUnFrU0ZaUHJRd3FlVzg2Z2NNSXl5a2dMQTZJcWQzd3lHRWRrbkhoTGV6?= =?utf-8?B?VE5DbnRVM1lHdWdFSUVYWE1TcWtlenM1Y3lobU9SUG43N1NQVnFQREJtaWtz?= =?utf-8?B?aVlLeW51R0FKcGJZcE1YQWNsVHBERzZTdS95ODJiZ1d6RGJMYlZTVDdWOUdk?= =?utf-8?B?cFRLQWhaNjFnYnRVemtvOHBSNzhHWml5dnJzeENkRmVjNU0yTW5Ib1RUSjYz?= =?utf-8?B?Y3pGaDcwTkFYNTU1bGplODhwVm5EZjRPU0hZRWJRSVQ4alZCZUQwQVdxOUxv?= =?utf-8?B?QkhGaXM2UEJnWEUrUStSTDZBRjBtVTd3NWg4N0F0UHZNRS9GcGt6Y3Fob3dC?= =?utf-8?B?SFZqdkpRcTR2OTg4NHZJM2M0SEdNSHJxanR2WDBMZ2tYRTR4azR6RFB2bWpH?= =?utf-8?B?QTkveFRDRGtBalRmK0dWRnh6UVcwSXByZFIxbzFUZWtPOHk0LzJtV3lRSjVE?= =?utf-8?B?VC9XSjAxUW1lM3o5RjFIZXNRUVp6Z0RkZXU2cU9QN3hXZ05zUGFWcWYzM1di?= =?utf-8?B?Tm5SaTVXdjRjb2lkeEdWSWFUcXJGNStndDJvSWlLNWFZVkF2N0hURTZrR3do?= =?utf-8?B?VUttUW50ZHk1MnhkYjBFaW5NTG9XbEpBb2t2NVFFbGk4cGtuczVRUDJ1Yk1K?= =?utf-8?B?Nk4zUHpMOGY3bXRvOWJlNXl2R2EzU1RGTE9iYWh1eFVWTm5jQ3o2NDJOQWpL?= =?utf-8?B?SElzNFliZ3RmR3RzeEhSVEkyeFR3azFLR0hlNTdzNlhLVWV6R2VZcWo0Q1I4?= =?utf-8?B?ODBMMzVrTnc0RUQxdGgxNnZnRXVJRU1ONmdDdmxEK2lSOGJza0tXVisvTDZ5?= =?utf-8?B?bmQyaGl6ZElYOTZVNkdLbkZKTHcwbXQ3eDhsd2pMNGxja1BRZXIzU0F1L1Bp?= =?utf-8?B?c0plcU5hMTRWU1k0cDVWRGNUUmx6c1E2V20rVVE5bWpqRGVHM2dVSXZ6SDlt?= =?utf-8?B?NWR1NVVLZVVNOUpoSVRMZ1EwbzZYVyt5OVRibzU0K21kQjRIY1F5WHd6ZWlm?= =?utf-8?B?dEREMlNkZFJtY0ZvYzU4cmUyVlJXdHNQU2g3RjVoaStCdkwvQmtGTTBIQUlr?= =?utf-8?B?cHRzMGxsYXM0ZkRZdTlJWFFwUFdramNNYUh1dFVidXFSZFJXSDBpWFd6SFVj?= =?utf-8?B?dGJTQjlIQVNtNlJnSFMraGVFeUgzYWFyNVJpMjBIdzhvZkRSM2pkcmN4NE9T?= =?utf-8?B?ZE1zbUpvWm85eVk0ZExTWGhkb2VKUEVqdmRkZ0p0QTRyTzZyK1p5YTBvcHN1?= =?utf-8?B?K3BuODV0NkpvVWMwRTV6WmozZktvQll5ZkJzdTBMeGQzQnU0YzZvNnRadnEy?= =?utf-8?B?bnpYb043WWREZlZnRnZWODJuWUtnNkRobXhRUDdkTTVCTkRSTDQzc3Z1ZXp1?= =?utf-8?B?V055RkpJNmhub2lBa0JmT2tvdDcvcTRLWUMrNXdlamI5RGx5YUswbVFvR2th?= =?utf-8?Q?mkOv3tEdMBwW7DN1gWlWF/yE0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: eaec810d-797c-422c-683e-08dac3e820c3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 13:24:57.6946 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LJAYPa+gvgM4d0pMBwLsgOgPLOqW87/qQhkotxvJ7Ade9iUxLEkXDemAWhLDvAU8s0sWKSCT2MluuiQHcEhBZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8711 (reducing the Cc list to just xen-devel@) On 11.11.2022 12:22, Henry Wang wrote: > ### Added / support upgraded > + - Out-of-tree builds for the hypervisor now supported. > + - The project has officially adopted 4 directives and 24 rules of MISRA-C, > + added MISRA-C checker build integration, and defined how to document > + deviations. > - IOMMU superpage support on x86, affecting PV guests as well as HVM/PVH ones > when they don't share page tables with the CPU (HAP / EPT / NPT). > - - Support VIRT_SSBD feature for HVM guests on AMD. > + - Support VIRT_SSBD feature for HVM guests on AMD and MSR_SPEC_CTRL feature for > + SVM guests. > + - Improved TSC, CPU frequency calibration and APIC on x86. Maybe better "Improved TSC, CPU, and APIC clock frequency calibration on x86"? > + - Improved support for CET Indirect Branch Tracking on x86. > + - Improved mwait-idle support for SPR and ADL on x86. SPR and ADL support is new in the driver, not improved. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 11 13:30:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 13:30:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442534.696772 (Exim 4.92) (envelope-from ) id 1otU6w-0006vR-Ts; Fri, 11 Nov 2022 13:30:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442534.696772; Fri, 11 Nov 2022 13:30:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otU6w-0006vK-QJ; Fri, 11 Nov 2022 13:30:22 +0000 Received: by outflank-mailman (input) for mailman id 442534; Fri, 11 Nov 2022 13:30:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otU6v-0006vE-Cl for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 13:30:21 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fb4f2f8c-61c4-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 14:30:19 +0100 (CET) Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Nov 2022 08:29:54 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by DM6PR03MB4921.namprd03.prod.outlook.com (2603:10b6:5:1ea::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 13:29:51 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 13:29:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb4f2f8c-61c4-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668173419; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=e1wd13aFpX+t2aJMyOroH0QE+VdZUhC3e1G7wjOv4CI=; b=cncmzS3Z9Eyom76EMoa2+AicJ6yQjt9j53S5yhjWRWFCk7XqfQFJSQiv 35+aLG9J8+yIF5+ITtZb463T514RH8+HjZIMwzadsdB/7XuP6g7RatPDb xdwtmxmWlSrnw3Ow6K6dY+Uf6CbMF1b7KSAQgBQ4CeH/4E2ML8LB7daNT E=; X-IronPort-RemoteIP: 104.47.55.176 X-IronPort-MID: 84239427 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:j2COvKxXzZhw90B0fQh6t+cWwCrEfRIJ4+MujC+fZmUNrF6WrkUCy mUZWDrQOazZYjD3KNx+bITi8EgPu57RyNE3QVZt+yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPKkT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KXMf6 Po3cmA0VTmsoqGq7J7nT8Nrn+12eaEHPKtH0p1h5RfwKK98BLrlE+DN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjWVlVMvuFTuGIO9ltiiTsVPn12Ep 2vAuWD4BB0bO/SUyCaf82LqjejK9c/+cNJOTubpqqQ16LGV7kAyKgEdVn2hncOouhWzV+99K G9ToDV7+MDe82TuFLERRSaQgHOCpA9aZNNWHMUz8gTLwa3Riy6bDGUZSj9KaPQ9qdQ7Azct0 zehlNPzBCdzt6WVRGjb6fGfqTqoOgAaKGYDYWkPSg5ty9/qvIE6iFTUUstvHbSdgtrvHzzq3 DeQrzN4jLIW5eYQy6ik9Erbqymwq4ePQg1dzh7MQmuv4wd9ZYikT4+l817W6bBHNonxZlucu HkJneCO4eZICouC/ASdTeNIELy36vKtNDzHnUUpD5Qn7y6q+XOoYcZX+j4WDE1kKNoecDnlJ kraoxpM5YR7NWGvK6RwZuqZAM0wwa/tPd/sTPzTY5xFZZ0ZXA2I5iZ1fmaLwnvg1kMrlMkXN ZmSfsmtCnIbIb961zfwTOAYuZcmwi04zCXOS5H+0w+qz7O2Y2ScQrMIdlCJa4gR9qSfqh/S9 NVZH8SPwhRbFub5Z0H/9ZMQJEsYBXgyGornr89QMPaHSiJYH2UmB+7U0KkWUYVvlKRIlc/F5 ni4HERfzTLXiWXcLASWalhqcL71QYtktnU/IDAtOlCznXMkZO6H6a4DeoYsb/8i8/NgxNZ1S eUIf4OLBfEnYjfK5TUbK4X8pYpKdRK3iAbINC2gCBAndoNkbxzE/JnjZASH3DUPCwKnuM14p KevvivERbITSgIkC9zZANqsyFWrtHRbh+N2XGPPONBYfEiq+49vQwT9h+E6C9sBIhLCwn2dz Qn+KRIRv+zEuYI22NjPm6Gfro2tHvd+H0xVBG3S5/C9Miyy1mi+x8lGWeWBfzHYXUv1/rmvY aNeyPSUGPcAllxbvpF8F7tuxKQW6N7mprscxQNhdF3AaFKtDbFsK2eHxuFAs6RMwvlSvg7ec keC/NZKJJ2COdijDUYcIgxjY+ievdkPkzzP4PBzPEX77iZq+KavXENJeh2djyobK6F6WKs5y OIoo+YK6AiyjBU7P9LAhSdRn0yFL2cJUqEunpsbHIPmhActxlxYJ5fbD0fe+ImOcd5FNkAgP xeehbbOirpRwEbPaTw4En2l9eNZhI8SsRFQilEYLlKCm8HtmfM8mhZW9FwfQgtZwxpd2spvK 2NrMAtzPqzI8DB27OBaQmmqXRFcXDWW/0Xwzx0Ck2ixcqWzfmnELWl4M+Dd+kkcqjhYZmICo +/ez3v5WzH3es23xjE1RUNut/3kS5p26xHGn8ekWc+CGvHWfAbYv0NnXkJQwzOPPC/7rBOvS TVClAqoVZDGCA== IronPort-HdrOrdr: A9a23:qWc676AdvRluN+HlHej1sseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuaKdkrNhR4tKOzOW91dATbsSoLcKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUeF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlil9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4sow3TX+0SVjbZaKvm/VQMO0aaSAZER4Z /xSiIbToFOArXqDziISFXWqlHdOX0VmgLfIBej8AfeSIrCNXMH4oN69PxkWwqc5Ew6sN5m1q VXm2qfqppMFBvF2D/w/t7SSnhR5wKJSNUZ4JwuZ+w2a/pgVFZ9l/1owKpuKuZIIAvqrIQ8VO V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkdoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWtKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFEhVsGYjEniefvFmHKc7hiwlbF/NLggFkPsulqSRkoeMNIbDIGmEVE0kldemrrEWHtDbMs zDTa5rPw== X-IronPort-AV: E=Sophos;i="5.96,156,1665460800"; d="scan'208";a="84239427" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Px4H+z/IuS6jfqAo5fRpncqlF//1jSDUULZff8K3Zi/KbrxIQy6l5DOireqCX050tKHDsi7hIyYlnv4ke+b7jnftuBKIZ1hmFzJrWpuTWLng2tQQU/MPNjv9yRZMrfZrAhJJTYQi4VcNfug+udhVmxob746TRrOPkK++MU8yPdmSO+9P9n6OA+XnNoUe3/F/9xlxPocQjpgZWK+c2CSSlgcg4buHaDthtjhXZHGzvl9Re429pq0vkj4eORw5bI+rrzTw0yeVeGxJfxhhAtmyLHUaVtZsPVTZSzddBGiVdvvIIHMx8fcSr0fRISEPOG5AvfYEWaG0TQBNCZG2f25mPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e1wd13aFpX+t2aJMyOroH0QE+VdZUhC3e1G7wjOv4CI=; b=ltH9IOI8RDnoZDXkXkeWpDO8RbNCt+f5jKBdP8vPf5JljbTmgtp4i1V9qZfNvkUCat9afSmlxvU82Cme5kpZLrBozeOe611jR+xhWAfkiMdONAAymRAN735ScJ13wnjjvfL8cjBxkHIpRQwHZ9daqM8LYFXPGW09NqVcqF81Ih2A0PzgvH+jLUfl8uwKn7O5jZAxF1DM75z1Osooi3yPwa2U4Mc/A28cBCL9XziTWcymPWAlVkLpLRUjStlhco22FGm/p5e6tlMuVsxvqOZpkPdrnW5WgtIQ1Ab32lp8zcL8c2eH3Ef0+abVnBeHQi5hJ3Z9WmsmOtux7F5OZuAV8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e1wd13aFpX+t2aJMyOroH0QE+VdZUhC3e1G7wjOv4CI=; b=Vc3+43M/57ItxNUYYS2kUoSqkhoKnyb5l2jlxrKikWgaGvpKYsnrEzke3AgkyrRECPFDEWjXYQ2DNosuVZR+dXu/x2C1ZqkyQ163RcdYL0NuLf74mkJp6706/k1S8HDpo6i6l/Kuc2PegioWBuzFrsc8YaXfxS7BZrQhq1BgUrk= From: Christian Lindig To: Henry Wang CC: Xen-devel , Jan Beulich , Christopher Clark , Nathan Studer , Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Doug Goldstein , Juergen Gross , Dario Faggioli , Elena Ufimtseva , George Dunlap , Nick Rosbrook , Lukasz Hawrylko , "Daniel P . Smith" , =?utf-8?B?TWF0ZXVzeiBNw7N3a2E=?= , Kevin Tian , Jun Nakajima , Paul Durrant , Roger Pau Monne , "Tim (Xen.org)" , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , David Scott , =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , Anthony Perard , Bob Eshleman , Alistair Francis , Connor Davis , Meng Xu , Samuel Thibault , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Daniel De Graaf , Quan Xu Subject: Re: [PATCH 1/3] CHANGELOG: Update link for RELEASE-4.16.0 Thread-Topic: [PATCH 1/3] CHANGELOG: Update link for RELEASE-4.16.0 Thread-Index: AQHY9b/tV4PXQktPckC2MFDCwX3RyK45t9kA Date: Fri, 11 Nov 2022 13:29:51 +0000 Message-ID: References: <20221111112208.451449-1-Henry.Wang@arm.com> <20221111112208.451449-2-Henry.Wang@arm.com> In-Reply-To: <20221111112208.451449-2-Henry.Wang@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|DM6PR03MB4921:EE_ x-ms-office365-filtering-correlation-id: 57b27f65-4a18-43e0-dd00-08dac3e8d00d x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VzT7EUfwrCUGDO4Iny3Xh82bIVqjt+KRTKHnXHZcJMlyUT3g2tmF70RN1Wb+LKx5EOkMtwhXQzFS0i96g3A3aEmoRdoqn9Z7IQ919K/sYFOlRTqM1GIsc0CMeQPFlkCGrUV55zjMm6fVncOFN7VDLmSIsFuxkNlgbADuqfgF/4cIOBT0RajXq0xa1Txbrj3+ePjMgNl/UGxQIJMT+KIqBkptq7QIyJuHZcceKoe6BtU/4zfqszLu+x17JiEIiIj6yB8sVjwwTpmQCPx752KyrqXD393A++n3cwmmJRj43ZH0vG6k6kEEv7y74zHFPtHxG80zI8xt795a3FpZYpDQ96hdWEFtmMRVTOQhfWctlV16F09K7NyKRX+66lBXYj5u3mfFELBBk3LQ3waz+L7f7E+JE9YCt89qvyJfkiO9QMeh5q5nOBmmgfGros2XZS8rIBpWBnOT9r+2niDxUJeJLKuZhIDELp2strpGsWC2f3GbreR98uW8SqdFtFs85DaBNAk5uuVxWttoHHeN+at8M0UVgWct3GaxFjOUseCFxbngdp/PxX3QLLyxG9BsVTUcJgrL78GAhAIeoMi5KhV5E4CgfMI8vkCl8w7luRKCLofUqzoIvT4C6hkeptqYR/Fb7oqYQOVRuDFsSztbmFeOb0ueeTsq3LlwOjnLCOIx1twGZv4K8qBR27K8NfFsyukBnsNrUyHKexky2gkMUR/swb3qAbCvw4h96m5tcABxVJyRz7DgF9IDOBhT8gGZnsxjQ8VmKKKKLSyOMJipSim0eG15KVLbSnEWR5ewsZzFInC/Gq1kvCib83Luvhoyd7UENV9gb03lbDcGXLwoHLL42rf6x17wEvVZfHT0aW43ZRM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(366004)(39860400002)(376002)(451199015)(6916009)(54906003)(38070700005)(122000001)(316002)(2616005)(8936002)(41300700001)(66446008)(44832011)(5660300002)(4744005)(7416002)(186003)(7406005)(2906002)(33656002)(53546011)(6506007)(66556008)(26005)(86362001)(76116006)(66476007)(91956017)(6512007)(66946007)(4326008)(8676002)(36756003)(64756008)(478600001)(6486002)(83380400001)(38100700002)(82960400001)(71200400001)(219803003)(207903002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dnJvWXRZdVYwNlhmMEJUZjN0NnZ5MHQwQUFZelJGMjI4TUIvNnZobWZaZDEx?= =?utf-8?B?aytRNzE3V0lDZHVOYm8yWGhwR2dYSzdLeDdjdlBVTFUrb2NraDNoYTBoTUJ3?= =?utf-8?B?bkV0RS9LbTA4TW90MWNaUjZ1YXZObS9CWmhHTllvdFVaQy9TQnQyUXE4NGVE?= =?utf-8?B?WWZ4Vklja1E5L0h2THh0QUdySHg3SU5aeDU5Z05Mc3VDOGl3OWVOK2Jsa0Zt?= =?utf-8?B?NGdVODZNekVpK2JLdGEzVTB2am12SkxSeFFnclhCems0dTJEVkZQOEp3Y0Fn?= =?utf-8?B?UG93Mm9QUk84MFZIQ2p5NEcvMmRCVE91OUpPajNtcUtCdVZkVmVBR01NYncy?= =?utf-8?B?UnFVZG1pUFdCWlYrdExpcVRqNjRMWkJNcWxLOUVTbURnc1dCNzFJRkl2UjZV?= =?utf-8?B?QzlEOHZnZDljL1hvVzVSRHdUQjRsbDlyT21WMnl6RWUwTkt4RzNZOGFoUnYx?= =?utf-8?B?ekZOMC9oMFBHcDVaYWVMazNsaUJuSmovSWxhbHpEdWExS0oxSExlaDJCVUFI?= =?utf-8?B?b09pMFhoaW8rWWxObU5oeUs1Tm9oRFVwNU9lUFNZajlsQjhYZkNsSHNiRmdk?= =?utf-8?B?aUVEbTdhbisvUGd6UkJLWEJldEMyclJiblg0bSszV0twTG5LS0gyb0Frc3pU?= =?utf-8?B?bWNGbkRUWHpHZjR1cXVVWVFaekd1TVloT3BDMWNFVUdFOWZVV0czSktVcFJC?= =?utf-8?B?alZEekJaMnE2QzVTMC9TNFNYaXVjYlFGczNhbFB3Q2tUZHNhZXRIcmNOOWJj?= =?utf-8?B?YndCKzAra3NyWjVIMWlkWUJRSTdvUmE5djlRazdYUVJ5UDh3dGdUdDhMVEJj?= =?utf-8?B?ejJqM0FoZWNBMjVWYzlDbkVySk5LbHZXSWtUM0hFM1JnRDd2ZnQ4VjAweTNx?= =?utf-8?B?bGxaekNQM2grS1lMN1lkRUorQysxaUFQWHRSZXZDd0FEMTZDRHFLRTFBcGkw?= =?utf-8?B?cmZ1WlMzMTc1eTRHY3RtMzJrQThxZEViU0JEdUtwcUlpc0QxRkdudzVOYjhx?= =?utf-8?B?WFdpd2ZCRHNyaGEzQlNPanJZZklNQS9xa3VHdmVuMnQxVWFoMUVSM3JJZ1BX?= =?utf-8?B?Wk1ON3JWYUVMNnBZeVp1clRHNHJvbTdwbG5pZFRoS1hHNkNJQjRGaDJyakNT?= =?utf-8?B?dW02TUE1Rk4xVWdPMm5XUHFYdHd5bWVQUjM3NHNhUS9NcTVUK1JsN3B3N01X?= =?utf-8?B?eklmdzFCUFlZVVdIWjdXUDQxZXRCOE04eFRxUE9LRkJSanNvMHM0WVRBb3cz?= =?utf-8?B?UHE2REZ6ZCt5aHc5c1lSdVVoeFE5bHBwajduMjVNMnJVZzhxMHcwbWRkSTVV?= =?utf-8?B?YkduLzdkcFR3VUpaZmlVelhMTk1yU2NsbVJVVno2bXlXbW9KWUpvekFRKy9I?= =?utf-8?B?ODdVRWNNYlR2MFlIVnk3cjhCMEdmcXJUVHVPQVhqakJRM3BIODI5THNmQTh3?= =?utf-8?B?VWV5ZURRL1htTlh4cnd4YW84TFNGZFhmS3hhblFCbVcrM1p2T2p1SURSeDFR?= =?utf-8?B?T2FLYnNkNGZ2UlVrdTJocUJnL3AvY1VKb3VsOFpQRUZleUwwcGdSTHpjd2Vj?= =?utf-8?B?dTdIbWRNdXY0bGFvK2xkTDRZdWRjSVZPOUg5dG9pTEVYQm51MmdaWWc3azF6?= =?utf-8?B?V20wRlZodDFML2NINHE2VWFDTlZUeXh5V05YMkF0VnlRVUZwcDJyVjgvckNL?= =?utf-8?B?MHc0dmlObk9WYjBrdkdURU1HMHVRdzcwV3crbUYvR3ozRWVZUzlOUVdFaGsy?= =?utf-8?B?ajkrUGFtTGlWbkdvOEY5bHVLUlo2Qjh5M2M1cUNyV2VrQUE3dHBsVWI5VHhn?= =?utf-8?B?ZFFSVjIwZEV4Y1NwRmljUGZjRDRQa09QM0tLSmZaMGJrQUlYTUtlUGFadk5t?= =?utf-8?B?RjR4bUIzM2pKT3llTnFKOGxJelJCNGtVUFVtQndReVBaMWtJeXVMbXUrcVRY?= =?utf-8?B?VEFPRGZLbGtBaHFXMUNQaUZ2L1pNMHQwTjlFTDVRNFd0dU8xSmRkNkdNR2tY?= =?utf-8?B?dnQ4YkFCcGhVYUtCcTNRdnppYmM0VXNXQi9PRnd1UEVQRmdrUXZwUDhoMExi?= =?utf-8?B?aCszN21ObEZmVFVqUy9QbFZSMjRRMTEzdnBheHJDTHd3TXU4STdDWlkwUDJU?= =?utf-8?B?MnVIZUZZbHpVWm96Z2xGTzFqNVNCVnhGVG5xSjdZM3ZqdzBMclRibWVjVDNT?= =?utf-8?Q?ikSAQYj1lznAiAXZljkrGZY=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57b27f65-4a18-43e0-dd00-08dac3e8d00d X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2022 13:29:51.6432 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hY1J+ujbeuHW3Q7Llz1A9ZaWveWWQUfDKiKLEEYdz/kF2c1gGx4J/3agEe//Ybf24KJU8tPhRA/XGDGcsT6QosxgmtVrgejJQlIvo69Bpeg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4921 DQoNCj4gT24gMTEgTm92IDIwMjIsIGF0IDExOjIyLCBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFy bS5jb20+IHdyb3RlOg0KPiANCj4gU2lnbmVkLW9mZi1ieTogSGVucnkgV2FuZyA8SGVucnkuV2Fu Z0Bhcm0uY29tPg0KPiAtLS0NCj4gQ0hBTkdFTE9HLm1kIHwgMiArLQ0KPiAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCg0KQWNrZWQtYnk6IENocmlzdGlhbiBM aW5kaWcgPGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4NCg0KSGkgSGVucnksDQoNClRoZSBj aGFuZ2VzIGRvbuKAmXQgc2VlbSB0byBiZSBzcGVjaWZpYyB0byB0aGUgT0NhbWwgdG9vbHMvIHBh cnQgdGhhdCBJIGNhcmUgYWJvdXQgYW5kIHNvIG5vdCBzdXJlIGlmIHlvdSB3ZXJlIGxvb2tpbmcg Zm9yIGFuIGFuIEFjayBidXQgaGFwcHkgdG8gcHJvdmlkZSBmb3IgdGhpcyBhbmQgeW91ciAyIG90 aGVyIENIQU5HRUxPRyBwYXRjaGVzLg0KDQrigJQgQw== From xen-devel-bounces@lists.xenproject.org Fri Nov 11 13:38:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 13:38:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442540.696783 (Exim 4.92) (envelope-from ) id 1otUER-0007m6-OO; Fri, 11 Nov 2022 13:38:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442540.696783; Fri, 11 Nov 2022 13:38:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUER-0007lz-KM; Fri, 11 Nov 2022 13:38:07 +0000 Received: by outflank-mailman (input) for mailman id 442540; Fri, 11 Nov 2022 13:38:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUEP-0007lt-Me for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 13:38:05 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70088.outbound.protection.outlook.com [40.107.7.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 11341004-61c6-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 14:38:04 +0100 (CET) Received: from AS8P189CA0057.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:458::35) by DBAPR08MB5607.eurprd08.prod.outlook.com (2603:10a6:10:1ae::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 13:38:01 +0000 Received: from VI1EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:458:cafe::4f) by AS8P189CA0057.outlook.office365.com (2603:10a6:20b:458::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Fri, 11 Nov 2022 13:38:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT013.mail.protection.outlook.com (100.127.145.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 13:38:00 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Fri, 11 Nov 2022 13:38:00 +0000 Received: from 18f89e021f57.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 182227E7-8AE6-46B0-AC20-6A3A3BBB5AEB.1; Fri, 11 Nov 2022 13:37:54 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 18f89e021f57.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 13:37:54 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB7324.eurprd08.prod.outlook.com (2603:10a6:20b:443::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 13:37:52 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Fri, 11 Nov 2022 13:37:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11341004-61c6-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=URkXotxa9CReliKmWEVfJASzydhHwGKmFU9dJAhXRnl5wDWlBMaNSPELP7g7Tu1GaB8RtzV0D0mfyQ0WXVb8p+qW5u63Ymo/XA3i2WKGEyczY8uWLr3kEf/kT45xDZn1WyhrcxW1FuzikIV32jVwX2FKoJyHCzm3t7NLgxYQStQvmgGxSDX/yyYjcGyXUhFoWFmAC+gO9K5J2C3uzYD+RiGFxmJvtArRPRjkuJRYdxvCVqR19JABKcaLEUSeHJk7inTCHkTHn52oaYvL5mBLxfa8imGwPm7OsMCORIe5EIO8EfT1+clKFgBdPxjsX+fZRp7ULqiTcY938HEFE+2i1A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BX/77w8igStMoOc+Zb5oEeSYBhzeohtIobGZWTMWzas=; b=V9dweTYf2JwWe37VlXuzPWzJELm7Dm0uwB56+0C+miI7wnvv/k6VwxDQ6lZi+k74yFjaCh6bn2tt/BbFpBkW6anSdT3SN2g+4KmYghZCzBeeF4u443oVdtltBXo10EpkFlQADw+pH54bUj0FAx69M1C8teju0F6kTNMjDpzkuH9qepnf7Vuj8pYMHozfs3ADHn6GpplZ2QpmUEXLfGY/YLQNdpZ5vm/Qdirbwq4eiAfXDYLbOyGgPU7eB+PTDWembcU/YeOa3DpMvWoG0bnvYxJCWp+cb5GQwtoP+tlaV6PE+DJ/D6ZuEHKq+JmaxfMx3QwSB/mVmUATgOGQP3nx1Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BX/77w8igStMoOc+Zb5oEeSYBhzeohtIobGZWTMWzas=; b=0Q9BSf62EHIYja8UEnzD7QXwrgYLIhoIE1iOteXhbA8ViFzQTON9wnKHbVgU4HEroSPl22J8Lyhvzkm6df6R/8YmQHYXp+jOpsWc/4VuASRsppXV64C0s4TtRxyz22Z9Y720kG2ZRn8n6oxX7QqGaelpt12C3MIAc/LfhGO5y0E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eTJdL8wEuoDdZlohTxmZ9x4u48t9LujN79d7f0rjxE0alTTLwFtw5KMkiVYmkoEkbE0bynjVLBXjE4SDSwwZ0lK5w0l5NDxWgDAEKdOqrsVsgXc7jrF2qn8SA21AOFi7T1Wb/Tlip9ecVYn6vvCasrLN/0Ejpv+drDkixkMEPLGvGlPWPdOwyOUysaOyKzbdS3M+aoL7KqMae+2L111oGUiBwW6jidM3ajPQhD87HmK/+cQOJlSOePWyD3kFcOYOpOfRs7D0FTGndwzcqAkDhlhJCb7lzo62vKG4XN9TiQpvLo1ccAHq6xTvY/t1SQgqU3zdL7aX46EpoooUdLXlNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BX/77w8igStMoOc+Zb5oEeSYBhzeohtIobGZWTMWzas=; b=LQzs6RUnXUVTjq7vMQaRmq0x1kWWk7IBkUnSCe4cGMwDbsar+iHDetYjfR1BSWVqCIuqMXO5V+kvG1nLAV7UnoCvZZYTKk3GcfN5laXQg+ZfTKJSeDE7lllHQC5ChmW+3rTJWAcE/N1ToC/IvXFEdZjoIpb7pdbxS+KSkwpfQGA55g7eI/t5V7dRqx9djH8tbhvVuGWfwEaYf3Kg8nfaRiTZ/gqFTQoabsI9Ofkjsw9CI48n/nEE1djKSyAGIxGnnh0gtAcUqlrqTwPMWwRoLOmIN5r9XAldYRLUFj+KiSmrPlYDuD7KQJROBp+iwPMNrn/puC0WFPULhAWhz5/5Gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BX/77w8igStMoOc+Zb5oEeSYBhzeohtIobGZWTMWzas=; b=0Q9BSf62EHIYja8UEnzD7QXwrgYLIhoIE1iOteXhbA8ViFzQTON9wnKHbVgU4HEroSPl22J8Lyhvzkm6df6R/8YmQHYXp+jOpsWc/4VuASRsppXV64C0s4TtRxyz22Z9Y720kG2ZRn8n6oxX7QqGaelpt12C3MIAc/LfhGO5y0E= From: Henry Wang To: Christian Lindig CC: Xen-devel Subject: RE: [PATCH 1/3] CHANGELOG: Update link for RELEASE-4.16.0 Thread-Topic: [PATCH 1/3] CHANGELOG: Update link for RELEASE-4.16.0 Thread-Index: AQHY9b/5dZvLlHGq0UahfbAIkO+VQ645t9qAgAABBcA= Date: Fri, 11 Nov 2022 13:37:52 +0000 Message-ID: References: <20221111112208.451449-1-Henry.Wang@arm.com> <20221111112208.451449-2-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 31C3E5C4497F3247B373F70358FE488B.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB7324:EE_|VI1EUR03FT013:EE_|DBAPR08MB5607:EE_ X-MS-Office365-Filtering-Correlation-Id: 59fe688b-5be0-4a6b-9ac4-08dac3e9f3a0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ele557Pty7hyZL39ETSq2gNxLzNF1dgdIw7hCYwllSTO8alwobuG4hDTnZABhJtKDG6sQuja6cM/FcMjAJokKD6ifkTswf5rSYySuqAPk0MKFAUhhWD9CL6xRf8ErtgAq5sPfNteO2IJifPlQAQwXa/yEY5wY9c+SfdrqbwTN3H321E9W5pmQq9GK7JAxAFGztL0tN46tqX4esEmOZqDIxO+GVb0ujLjwku/Mn3eRGZwCCn0+26i+DE0lCnPOu2XqbtR53y3534tqVfCAXiecLVZ4iFxeairQQ6FZ5Bwrk4x8iDhMy2RQI6g5RLJeWLVF8mYo4q2S4ZjRI0fd8cH7EBs/7xU6xKrpyYFfCV/xiHa3GAmAp/kvE6DV//+7tXWT5/er70ekne+hdwkBLRmCihtpL27fs1wzvXbTmL4A/fVT/T2RGMAIhPXb+ZmH5oYQ6TAyPDgdh7KOdouPHjjnD7EK+TxEakyTIf7z0x5ggVmi1w8B8j/vbALmRjduqEFnr7Gupyb13jayLHlVmgYWuOKg368kZ5AgHZO31rQwPNPMiHdoG2E3DdQfvSiVD1MFuOOBIhYT4JfKEHTaKccaqCGEWAOopf+5BZRpg5V/wTbf/9YtnHP4T4sYc4COpcfd6GYARr0+wbhskJU3dk+shoFyUV/cblO2Qs+bA11dVLRq47UM+yesH/uUV9chgHBGztTWc+DboavK8wuM3DbZGSMTfAkmMnuBbVO+2LqnSZcmzGipEq91YArbjlTaWNRIZjXg2L0ziNghGs6+LUeCBwR1mhryZ9Qghmd5d+5S7h+BRkcjd6zbP/tqLG5Z6c8J8b7gc1nsa1oXG5r85CjBuZNbvJvbD4E5bANM4m8a5c= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(136003)(346002)(376002)(39860400002)(451199015)(83380400001)(186003)(38070700005)(33656002)(55016003)(86362001)(122000001)(38100700002)(8936002)(52536014)(5660300002)(316002)(66556008)(76116006)(66476007)(6916009)(64756008)(8676002)(4326008)(41300700001)(66446008)(7696005)(6506007)(66946007)(53546011)(26005)(9686003)(4744005)(71200400001)(15650500001)(478600001)(2906002)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7324 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fdb449cc-e7c2-4bc8-5008-08dac3e9eecf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lw9CYVUFOCgjwm81C3ULalMu5Tbg7ft8t+gC5mFfveIlA06VPhzQTAkhqEAFzPQjvvFwyx5VzaHKdrEw75z3UPjLmy/PpebmTQPXFL2N+0Lzuj7N/nCHN0CQ2iMSzKTyd6x+I/dX6tC9XzP4R6sqFxXh3x4jPu88jBqMHRhB1k9XLA4a6UODeZw+Hh8LBq+x29kG14aZKoZr2QDLvEhtbh1K+uNE2LdKSeIMQR2DmVwGY8Cd1EwTwep5yU2kiI5J5mI/fE+EbYE6/MxfITgfa5T5WxV15Li6rJn5ytGVDoMOAmbc5QHXUR46KrfOCjlAdeuErnJw8+qzs3LgEi1Cid8sspzNj/JoWZgoTDjVJIiSlPXXJwrowmwTXkgoHT9ySQWNEXyc/swqNNlZQpipVLeasxgxtO0K65GcX/vUvmfyl4tPIU4cG6OskgviRFv6xDfk30QOLQKIqqoajhhSQv7PSJXoqz0x+7troQ6NfP7PTlpNSFcJ35G38gCsettdc7TR7MZVXTUYdi2DRxc/cjwK5dMJaTpkutrJKC6LCICP3eW/Rsp3B4BXldpomyrVkEzCqGchpqH86T3UVDy0CrE4aSn0s99Jg5netXmt5E7EKpm+s4BNNIAKv3jAA/St1DBnMnGTctv5Gl4ooKK8rMmlpbS6wkovnhSBkeTN5/LyZ23WxrkSC+MIYBrPY95L4xa8SmZNWTOnJndXsKRrzWTxJO9qltlbv0e+oGYyNiglKMqND9THib9SDie7SSTPeiLYJmWP8m1fIenChA4Ob6EwMl/Uk2Y8Nvp/esNRrRQU0+Ue8y7AEurY+qPJkAoBVjOzRThZe/CnqDeWLRvoqhxTOB9nB1nZfo6umiKjFO0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(376002)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(82740400003)(336012)(83380400001)(47076005)(81166007)(356005)(9686003)(52536014)(26005)(186003)(6862004)(36860700001)(2906002)(8936002)(5660300002)(15650500001)(4744005)(40480700001)(55016003)(40460700003)(82310400005)(4326008)(478600001)(7696005)(6506007)(53546011)(41300700001)(70206006)(316002)(8676002)(70586007)(33656002)(86362001)(59356011)(219803003)(207903002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 13:38:00.7594 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59fe688b-5be0-4a6b-9ac4-08dac3e9f3a0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5607 SGkgQ2hyaXN0aWFuLA0KDQoodHJpbSB0aGUgQ0MgbGlzdCB0byBhdm9pZCBzcGFtbWluZykNCg0K PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBDaHJpc3RpYW4gTGluZGlnIDxj aHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+DQo+ID4gT24gMTEgTm92IDIwMjIsIGF0IDExOjIy LCBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+IHdyb3RlOg0KPiA+DQo+ID4gU2lnbmVk LW9mZi1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KPiA+IC0tLQ0KPiA+IENI QU5HRUxPRy5tZCB8IDIgKy0NCj4gPiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEg ZGVsZXRpb24oLSkNCj4gDQo+IEFja2VkLWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4u bGluZGlnQGNpdHJpeC5jb20+DQo+IA0KPiBIaSBIZW5yeSwNCj4gDQo+IFRoZSBjaGFuZ2VzIGRv buKAmXQgc2VlbSB0byBiZSBzcGVjaWZpYyB0byB0aGUgT0NhbWwgdG9vbHMvIHBhcnQgdGhhdCBJ IGNhcmUNCj4gYWJvdXQgYW5kIHNvIG5vdCBzdXJlIGlmIHlvdSB3ZXJlIGxvb2tpbmcgZm9yIGFu IGFuIEFjayBidXQgaGFwcHkgdG8gcHJvdmlkZQ0KPiBmb3IgdGhpcyBhbmQgeW91ciAyIG90aGVy IENIQU5HRUxPRyBwYXRjaGVzLg0KDQpUaGFuayB5b3UgdmVyeSBtdWNoISBJIHdpbGwga2VlcCB5 b3VyIGFjayBmb3IgdGhpcyBwYXRjaC4NCg0KRm9yIHRoZSBvdGhlciB0d28sIEkgbWlnaHQgYmUg d3JvbmcgYnV0IEkgdGhpbmsgeW91IG9ubHkgbmVlZCB0byByYWlzZSB5b3VyDQpjb25jZXJucyBh bmQgb2JqZWN0aW9ucyBhYm91dCB0aGUgcGF0Y2hlcyBpZiB5b3UgaGF2ZSBhbnkuIFRoYW5rcyA6 KQ0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeSANCg0KDQo+IA0KPiDigJQgQw0K From xen-devel-bounces@lists.xenproject.org Fri Nov 11 13:52:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 13:52:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442547.696794 (Exim 4.92) (envelope-from ) id 1otUS3-0001uK-2I; Fri, 11 Nov 2022 13:52:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442547.696794; Fri, 11 Nov 2022 13:52:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUS2-0001uD-Vv; Fri, 11 Nov 2022 13:52:10 +0000 Received: by outflank-mailman (input) for mailman id 442547; Fri, 11 Nov 2022 13:52:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUS1-0001u7-E7 for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 13:52:09 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2054.outbound.protection.outlook.com [40.107.20.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 07fc675a-61c8-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 14:52:07 +0100 (CET) Received: from DB7PR03CA0095.eurprd03.prod.outlook.com (2603:10a6:10:72::36) by DU0PR08MB8836.eurprd08.prod.outlook.com (2603:10a6:10:47d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Fri, 11 Nov 2022 13:51:53 +0000 Received: from DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::10) by DB7PR03CA0095.outlook.office365.com (2603:10a6:10:72::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 13:51:53 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT008.mail.protection.outlook.com (100.127.142.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 13:51:53 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Fri, 11 Nov 2022 13:51:52 +0000 Received: from c7df5f06e025.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FDAD0144-DC77-4C0A-8B1B-34A7BA91A0D1.1; Fri, 11 Nov 2022 13:51:41 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c7df5f06e025.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 13:51:41 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM8PR08MB6578.eurprd08.prod.outlook.com (2603:10a6:20b:36a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 13:51:39 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 13:51:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07fc675a-61c8-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=emnQ+k3LSt2VIAKXCCaCPd2/QsyJYTt8xQki67RR2TDSHUwri0eIiB+N3XFbucwLOW+hsVUVS4+qpIV7l3Q7ZpPA8al3+fj98f1rWHR7yI8Te/f5BHbTZgyeRG8gW7G5unypB9fAibD1Mst1HjPX+E+znGYBe/kHLljs2BFZe/WBLFFO6/Xz1TaLRc6sbxS1Ul/MN+B5DF3c7b4pEHD0y60OKrHfO5W7JsXM2HGbSMex4/ISnKRfXFEuDqI6uEQb4LKtSPrB+2XEtD8N9G6e3rz1BKFaklJ3CfmL3RAhstMompKIrs9oFsSdpkDO4RXYSg/vJIt2zjYs2oRWi6uDbA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dfqVXyaICvmhK25swRZqBbV0EKJoVYmMb+psTFZtFgk=; b=kZW+KGWA+5UXyYRVuCksTnKl90GOgaTfUdYc3YFjJLTEVVtUVSKL0NQbfA8MEWjhiXePXQQDIOQ+qBlSQcfl4y1mPpDWNFaCjBWvhY0rA/1K3fppSr2MkXqydY3sS+MzbqTtiljb7SxDi0iLy/q7fvLgBwmAq/gvBSyuwi9OLjChUuAzVczuXN0XF3eIcmajpSXYojtElGDcKj85gEUk1Wf3kVf/j9P0jG1iW7JOtWXeqmbpMCUKqTfrAH8/hhICubZmei97XXO4teYurYCuU3jAv2b+G23GP83aJ19yg4OP3K5rEQ9O+JDXzrqktP9rIGNTpb0/OizA4/r9t/9Mkg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dfqVXyaICvmhK25swRZqBbV0EKJoVYmMb+psTFZtFgk=; b=oB5+5k8YiNUzwyfUeI+H3XABKiufNok3t23kjWa827a+zNSDUgwvkfStUA2OzKfQmrhzvN6w45BoaYJKWxEwPyj1rZUzknrpRhnyGx72RhMCVoFfxvfHvTvLxOFqIr3F1CKnc1tnzpTrHf7EUoaJeqQG9HMXNYvxa4J4XjO0r14= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 79ec041c3eb3595d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QLdEqURQhmZdtck3DgpSphR1gcHonRhyrTFyqtErBFh5Hrh/PnmAga0/fqVJZ0fG0H/JiTex+2WcNL7lNbUvE9391B0FzQLvtBYEHkPpqWxSD3Jh+H1ONaB/Q/7FDWJSWhseKzpa/9OQMD7BI5IWrcMOOKnFVDypwcl7cFgGbSHFI9dR610wDwLGADS5keu6ZezUfvHluLQbHta8GctBx5Tn0c+DGzs02yMLQKm9ebTTM/HAsV5g5+J7Yfrn2OB5+nAEuwx7QbqcOVgv83HAcqzikYIn5HX4GlkgpceWjmprJmxxyvaUIye5ewsYQV+nmOzwbhs6GJQm9hNNwWyuJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dfqVXyaICvmhK25swRZqBbV0EKJoVYmMb+psTFZtFgk=; b=OyJu+swHReFdaDbzpKSrSPRai4bBh5wGbrYRp/Qfe2euy+8ZTJIfAiARMaBx8QM2kYNWAAmNpVCpKMWlJc5VA37AY/r8PoQCIs/PaKpi37GQe8iJUQ09upqifWPTb7cJ07M5X1T60UZ7GVAUdzRJ9b5cEBjD5acdbn0z7EvbqB2H2k5bJuZNovME2Yc9wmEeJ4FFQA5iG7A/HeJfIjYxLzTZc59iy24e7XuZdvvCCdaTjTnm20iqAGAu9qJxF3++MRY3rdhbJz5ig67KkGnSyOJ8LUY3L7CIwWs0ILYGa0SPeLJxeXpu+wGqj2uc/8NhYkf6SPwpaq7lli0c8jn7pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dfqVXyaICvmhK25swRZqBbV0EKJoVYmMb+psTFZtFgk=; b=oB5+5k8YiNUzwyfUeI+H3XABKiufNok3t23kjWa827a+zNSDUgwvkfStUA2OzKfQmrhzvN6w45BoaYJKWxEwPyj1rZUzknrpRhnyGx72RhMCVoFfxvfHvTvLxOFqIr3F1CKnc1tnzpTrHf7EUoaJeqQG9HMXNYvxa4J4XjO0r14= From: Bertrand Marquis To: Anthony PERARD , "grant.likely@linaro.org" CC: Xen developer discussion , Henry Wang , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Andrew Wafaa Subject: Re: [XEN PATCH for-4.17 3/4] xen: Add licence header to device_tree_defs.h Thread-Topic: [XEN PATCH for-4.17 3/4] xen: Add licence header to device_tree_defs.h Thread-Index: AQHY7q5sdhpegtQed02rRUz1XHl2w645zBMA Date: Fri, 11 Nov 2022 13:51:39 +0000 Message-ID: References: <20221102112854.49020-1-anthony.perard@citrix.com> <20221102112854.49020-4-anthony.perard@citrix.com> In-Reply-To: <20221102112854.49020-4-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AM8PR08MB6578:EE_|DBAEUR03FT008:EE_|DU0PR08MB8836:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d49211a-bb9a-43b0-e58f-08dac3ebe3a9 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9AQ60l2gKyqA8sQ2iHsRu05dOPDIarUO4psjfSoNTwonoaRirK8J0QJ2zWJM53tRp1jZhg3KlMcfyKLrmIOvtZP6GdkjPVg4YjiMxX6eccwarNm3TEwivlprCKHno/P1Xd3ct2nBnvmMb3uOLLhOph/q3QIsjIkZZDPsUyzcIt2rMb3PBYg1vf1CWgaGrcHwkqQZurGDXuZ6eiNOwqyX/u+dT2a0F9tEAnP4Y0KMKNrhxEWNJJWJP43FXUVIP2IFQW3wd7jYIKaxlpWxQm+w2JiB8RWAIGDBzPHvI+FNwdGg+5aR+TDfGCgKk64SAFo3KDLy8ic5Hf25Qc/bk0Wn0Qh78hMszhR6inC3sxAfMEN4mq0mIxsfY2SRVUd75cGSoH7+we1KKwcs8IEcJBRiUyE85hspIpYmHvP+8+um8HtjKSTRlI60Q1AebbGK+cecoNqJ4SKwFVRGo2zX7sdXeuaJk37Jdo5jPmYjOH5dtX4Mb3T3/5/9GsKbDIX5VBAGoxSRpzEKpw1lULVG+2uzxu5Koq0ar+SVD8VzzjKySj8NqVH7ljFCen1hfvjmlnLCpesDA5BBG5vvn1zYhdg2MfacZww5OEX2Y9kDELCWAJv60bLwr7Tqbe72/fbUCr4dQ9mQ3zTnM9bKNAYI65MYdSCw4g0pdO+fixqE++CRshm4EFsbdLIILaSLAxy+if6efdFj47AJn1mfziVwC2SOhfVkI8wu4HlXtv36b5s++q2Mhm2U69Hv4kEO9raUUUqmQEYYqFx3SsFVYxYBUgm5t1LaIfPYmzPGTHSM+hqlyGc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(136003)(346002)(376002)(451199015)(316002)(86362001)(36756003)(33656002)(8676002)(64756008)(66446008)(4326008)(66476007)(8936002)(66556008)(83380400001)(66946007)(5660300002)(41300700001)(38100700002)(122000001)(76116006)(6486002)(186003)(478600001)(110136005)(71200400001)(54906003)(26005)(6512007)(2616005)(38070700005)(53546011)(6506007)(91956017)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6578 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e3c8b7d2-88ee-434f-ec83-08dac3ebdb52 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9EoYgMyOtHM7472dYZ1V/llgoh7i/V+b/bh2YrZsXGTTrdovCiDQ37ImFhmrLwy8iYsE8FWftljTbwEDIOh5Znza2iSUOaJsJ4KDdvZdhQUqSE0BaunNduyHevg5AswYcUqIC985P1kTlwKthb253jLN8yMOoD+k7YEUBCE1RMMzXbB9D5g+d5o7JLd7MZeoHXLNoDvWdrj6LwPyOjY9HP/Y40m9Xnr/Qa7XfHqFVYbOkOzm54NhFiljAbmD6IEPT1l5pzSOC+TZkfPirlBsSWuFMuK/bMhnt2KNkudOnzTjhEV/ljLhczfBxB/M0x9a7pEvVEJuYvsbcCqK7SQyH+grjFR1ISYexCzU73kme7I+9DY5qWK63+ThFl3ah5n5urbhuHG+SHrHNI/nvy03TB6gTrhcaM4jJ710uMNaQ7DCwuaNQeYo08bV3CyfaNbFFYKimVufEdKyI2U+QZA17nNecqFmA4UIy9uMtFqNQU95cE/K176G4neSLcVjG6zsAXfN5aWRNmPV7cKoE4qVXoBdOG7LdaQw7CXJBumeroROXw/3yGUwG584xIwnbMFTd95eeonTLKpbB9tKOyUbfzHSOlAuQFho83hOuti/mujgMsPoPuQW06hnAcl6TzGSBVNWInG2fcd0NoZE9CuMF7YE6zN6xfSk+qPWwIV+hAS9X1NLpEwia3IyhBcE9YKAM7ahi+Z84pYiI23EzS+vrPTumIq76Cg5RGaw2d/hcoyUt+2osOrLYTd9XvDVclvVUhu/++rrqE9eV7C3nAFdeg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(82310400005)(36756003)(5660300002)(82740400003)(8676002)(40480700001)(2906002)(36860700001)(8936002)(186003)(336012)(6506007)(6486002)(70586007)(70206006)(33656002)(54906003)(4326008)(110136005)(316002)(356005)(86362001)(83380400001)(81166007)(40460700003)(41300700001)(26005)(6512007)(47076005)(53546011)(2616005)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 13:51:53.0483 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3d49211a-bb9a-43b0-e58f-08dac3ebe3a9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8836 Hi, +Grant Likely from Linaro. In the following change, we need to change the license to MIT (from GPL) of= one of Xen public headers which has a Linaro copyright. @Grant Likely: could you confirm that Linaro is agreeing for Xen Project to= do such a change ? Kind regards Bertrand Marquis > On 2 Nov 2022, at 11:28, Anthony PERARD wrote= : >=20 > This header have been created by moving code from other part of the > project and miss a licence header. The original source code was some > version of GPL or LGPL but we intend to have the public header to be > MIT so they can be included easily in other projects. >=20 > Part of device_tree_defs.h were moved from libxl_arm.c which is > LGPL-2.1-only. And part were moved from device_tree.h that is > GPL-2.0-only. >=20 > Part of the original code were added by Julien Grall @ Citrix with a > Linaro "hat" in commits c3ba52a84dd8 and 405c167f0ec9 and > 886f34045bf0. The other part were added by Ian Campbell @ Citrix, with > commit 0c64527e7fc9. >=20 > Resolves: xen-project/xen#35 > Fixes: 1c898a9fec7e ("xen/arm: move a few DT related defines to public/de= vice_tree_defs.h") > Reported-by: Andrew Cooper > Signed-off-by: Anthony PERARD > --- >=20 > Notes: > Julian was working @citrix until 2015. >=20 > xen/include/public/device_tree_defs.h | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/d= evice_tree_defs.h > index 228daafe81..9e80d0499d 100644 > --- a/xen/include/public/device_tree_defs.h > +++ b/xen/include/public/device_tree_defs.h > @@ -1,3 +1,9 @@ > +/* SPDX-License-Identifier: MIT */ > +/* > + * Copyright (c) 2013 Linaro Limited > + * Copyright (c) 2015 Citrix Systems, Inc > + */ > + > #ifndef __XEN_DEVICE_TREE_DEFS_H__ > #define __XEN_DEVICE_TREE_DEFS_H__ >=20 > --=20 > Anthony PERARD >=20 >=20 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 13:58:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 13:58:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442551.696804 (Exim 4.92) (envelope-from ) id 1otUY7-0002ii-Nc; Fri, 11 Nov 2022 13:58:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442551.696804; Fri, 11 Nov 2022 13:58:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUY7-0002ib-Ku; Fri, 11 Nov 2022 13:58:27 +0000 Received: by outflank-mailman (input) for mailman id 442551; Fri, 11 Nov 2022 13:58:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUY6-0002iV-AX for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 13:58:26 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80054.outbound.protection.outlook.com [40.107.8.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e8c851a2-61c8-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 14:58:25 +0100 (CET) Received: from AM5PR1001CA0038.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::15) by PA4PR08MB6127.eurprd08.prod.outlook.com (2603:10a6:102:f3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 13:58:22 +0000 Received: from AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:15:cafe::51) by AM5PR1001CA0038.outlook.office365.com (2603:10a6:206:15::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Fri, 11 Nov 2022 13:58:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT011.mail.protection.outlook.com (100.127.140.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 13:58:22 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Fri, 11 Nov 2022 13:58:21 +0000 Received: from 6a33e3a41d09.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1EDE3BA0-0121-4D3D-8C65-636DD0069EEF.1; Fri, 11 Nov 2022 13:58:16 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6a33e3a41d09.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 13:58:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB4PR08MB7958.eurprd08.prod.outlook.com (2603:10a6:10:38f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Fri, 11 Nov 2022 13:58:13 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Fri, 11 Nov 2022 13:58:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8c851a2-61c8-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iv3NcsxYsA1YcoeA/4oLtp2DQvO3N13+yDIrMS/28kzZGou1/8+9sMhYrGWXRvKc8DkD9G3bowPy6wKEAguqfW082A8JVXAw4PtDVKsZos6xfG+iC15MXe/XC2nBQ3uiwzCavw2/Z+iQiiYjqvlRZRGkNEfErGKJhy/X6/8aDWIfkqWAB0CqBfXAGFFbFNqCpav4xdCuM1UZDCFP7hmHsS/iZRHIvhWnNiBeGfVMHaGi1nlBLjDXKlOXCmZbGkhPCnFoSoc+deiIHyxxmiQ2Qy6QmHACTWW0ipnpobtBGef8lWG9G/jt4eEtuNt1XmEmZbpr2AsAIfRmdWsPOkrLqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kxgM71bdUWDiIaORyQCjR1xnPaHpLLNXjJNEsaJFXEA=; b=j36Eh0eNZ+UGQbA/5NWIZkJvFmJ0ehfUnG5RKPa72fx6+qedu5eQnDBcWOQtXC1yzjOFQJXh4l7zawyWZXSvpF6Y9jTWXYIOlwWurR7onNLzpIq/Cyv0HN3sIbda7uSkN/kc15z8vZDxOsVQYOZX/pYREs79WUjB3f/ln/u4aARPPq1aXfkmU5j/FUtshAYAuOVL7eoQqLVni4joLShTi1r9dOo3ui5xszMCw2BKGd99PR1oS9CugwW9411eJ2GZZM6iJDe+EKc+FvtXAF3bRPif2p5mdmRehKf4tpY7AzDsnwLtPOiujAuY3l7fNwag9lBDGGIwvXREeRc56WRuDg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kxgM71bdUWDiIaORyQCjR1xnPaHpLLNXjJNEsaJFXEA=; b=0kHRcgPbRzMkr02NFD7Fui+Dl+mch244kiR1Nr6w6i5NGFTyO/7QJgNERUZlX6BRRVoBnSyV5J1dmyGxsAcPUXasAsnEAOfJuhKEpgrsk9Ia+yBbyAyjYHLz8hMpjhbbDnFhiPr7QWQ8Tfc6TQWK8gmxdqRlez4RXI75ILiyIig= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N9iR2xoF7XKAAGzePg6vVoUV20eyTRJT15jtPfJFyUozjbbqPDUvhhcLOv+6sYvLpeusocEEGMuwY13XlaQxQKlaMbS0Nhm4TwB7uC5C4e9AsYWR65OqT+gS6aWHl8UXLE9ziFgRBMZuWjPLElYsAE8pQgM+vC+qK3MMEAUJESEqW/tOF61A3vqCEC4w9wu/qKCbN/HrM3d5VwHhWpXjW8nvbTs/9lbf9WT2OgP1BEJG5ak/tDgQj5665x8gmqE5n1vR9EBADf2l2clYWOSLVL+/0nSPfBJFqvWA5g+kH3Pmjk4me0CfYVZ/5UE9zhDGsJE4TpNcBVVMSb8io0K/DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kxgM71bdUWDiIaORyQCjR1xnPaHpLLNXjJNEsaJFXEA=; b=NbffnxFzB6WzYdWAebdAkAYU+3WwksBRlGEVitSXDqx5ZQD6RtmJV2kA3U+uYvKPaP7F1Ch0uWGHNtPWFEFem3xpZhwM6hlgcxYwgkAJOywW4Ko5ssohUULc3+J6M4O/qbKjOME5L/QiGGavrH/MMOkhjFnL4f6+5cPZsw9PqNFo/ojCCxFZ4zf5dnR9yZD8VwUlPbVmgcayIDVQ+JDfTUZHcN4J4BOJLZtKUP1lCpFQzJqDPaMmLPNEz3NSYMID/Xhs5pAkI3zgs3lmdcPb+IWUSBy85i23mBPUK/J1wET9wy17CamJMn0SIV3UbEDTnFgSSL10TC9jWLGSRxHFCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kxgM71bdUWDiIaORyQCjR1xnPaHpLLNXjJNEsaJFXEA=; b=0kHRcgPbRzMkr02NFD7Fui+Dl+mch244kiR1Nr6w6i5NGFTyO/7QJgNERUZlX6BRRVoBnSyV5J1dmyGxsAcPUXasAsnEAOfJuhKEpgrsk9Ia+yBbyAyjYHLz8hMpjhbbDnFhiPr7QWQ8Tfc6TQWK8gmxdqRlez4RXI75ILiyIig= From: Henry Wang To: Jan Beulich CC: "xen-devel@lists.xenproject.org" Subject: RE: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release Thread-Topic: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release Thread-Index: AQHY9cAA3X9w+pjMxES5dLMt0fkbDa45tnoAgAABRRA= Date: Fri, 11 Nov 2022 13:58:13 +0000 Message-ID: References: <20221111112208.451449-1-Henry.Wang@arm.com> <20221111112208.451449-3-Henry.Wang@arm.com> <4482952f-86a9-d232-6cf5-afa6523012dc@suse.com> In-Reply-To: <4482952f-86a9-d232-6cf5-afa6523012dc@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 2993D9F48A2B1046B4DF9B38069EE25D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB4PR08MB7958:EE_|AM7EUR03FT011:EE_|PA4PR08MB6127:EE_ X-MS-Office365-Filtering-Correlation-Id: 4810428d-24d4-4f1a-82e9-08dac3eccb89 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: G+/M5ApMYz+Z8ttnqfDHAkmlYaHepU+NPxrdYkF5cXz66hL4/jfzL9aF5RQxgL/0vccigfHdiCs2VzMoPNORGPsxFRTp1q+r/+bCBurCWOWkgGvZh+Qb+hXLfPLaajgJv/8hrnuQSKQMMmjm/QMyMKrk7E/Bgk/jZXF4hiYw65yTDd9KzWYevrxnqFu2VVjTriYWE+Ldn6fl8dQc7uWnSehB45l0fNJhcQlRk5abfP5e/nAHXWH6soA+HDHmduCErN1Ut2OEFe+cnl9HcpQR0Exe5vkq/CL31ztCthHLXzLlnnRSCitVa3xXMfLkcnqAKPpnHIgZpRAksYsqyuha0fGF3BaXDX1yFXzoPlIyk/mrlJdcloCqFHshM1Gl9e5WoxX1/sg72PAmJvReA2n4F1sknAS+69Nenc+nZliJS3hIRHpfefoSTToStpfZlY1or0CB4RLIi4cbBNEjmaFk/cv8xXqbqvq6Z5cBUNloaTigWvi765I2C7jzwXLZSEnyRZGOmjMVXkoNRtO+QvZstwSktNicBCHegcKgERu84BeJYbR5n30bFICxCrHrOIMpv3E5cjM9CG7vphFlBqZ6kUonM086sDv6WAqdJ0B2rc/7ra8+jK9ZN6maWBI2KdbIOWoduADYa16YG4AEw4KltCfJwpcGeIKMdjcDq8ZL7ZuXCn9BJsLeXuWTRGE1YhlJgiXLQTROZAY6jeagpiwjclpaWMqK+iArlTQRedhc15ePn07EkFErCHB5y0GPNFbg6eGxgUQi4frlXm6FgP+yonL71UWqDcNR7BsNWdluY94t8Ka0nQZk37Fv0E5tmOKDw/TNOtIkVUYn+khMjfzyeohvXpwEefF+05sH/skF9bs9LkQ7SJP+6nQj3x9z6spn X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(366004)(396003)(136003)(376002)(451199015)(8936002)(53546011)(33656002)(6916009)(8676002)(966005)(55016003)(4326008)(38070700005)(83380400001)(66946007)(478600001)(2906002)(7696005)(76116006)(52536014)(66476007)(41300700001)(316002)(66446008)(64756008)(71200400001)(122000001)(66556008)(26005)(186003)(9686003)(5660300002)(6506007)(86362001)(38100700002)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB7958 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1c445d06-8781-4b16-49ff-08dac3ecc634 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0nTdUQNRO0R7IyqMWOhQ85tdTSx+u6rgLCXWOq9Uh6MgeOM40T7bXzCBew/Mb6j0EaranJBCp3ZQGx381do+OgyY8aPxNL4w50p4xy7i+3bLLtVzytRqLWcv6m3cbcGWdbZ0zGz6YMb63cuddh1m8g+J2ETT5vdIkk87IKdE4RYhJpHxn+CGaQwjcsQSisrrjgO3kDvqVgskMoxcp2TsNzso9O7d3lQdbznDxGchNrwnHthP0NBT7YblzHVfUZ+dzVa0a2HNDDCdMmYTPiid4ucwaGi1uTahI4f6X1geAHPbGMoPb31b7ufwnxPOPPUe1Pt3hQfoO6fi/hgyG0O6KNlMw2TCBzvXQ2oPDt+anM9eg6zbHMLldjMSO1jnlEZ9aihzjdIJmehuJCk7vbfjVUw3Vs7t15ZfHX5nMbs0twM9m8trzaVvgACX2a0KhR2lLKdnn1ToMa+PNt+OHqQKKEg0/04XBtRhUvP+5nci71910pfMeyAsfX54HIJ+jXS9CBVq3/eXkGscBN9YNa4dyYANDFGMOmveimjvgCQpnjFMJy4B44rYDKi7mTRpwEWCFGPz5nG3XOP6Umi4BTGvvEfPkY4FOM8m5OOHYOy8Lg97vDfcsqDI6kDB6e9ioeIymSPAoF66i3S+ScYwNOdt5vCrs2Fg7qrt1UfH0bOo/3FmN7fWRKekE7CjXcl54IJbgtC2+K6anUzzI09Bi2h0wAZMqmviabnhpX1iTGVhZyQu4UzFvKdlpXF6MvdHN4bpmVTus1F64u002P3xoDT7wFwmQLmLo+rIR+P8P28r72cmzoX4LXATY0fAbzJ7x/U/06GBYnHIVDgzf4YfvFBxdrGy7IZcfbHsy4+PObujZgte79ggQvlxi0Q+AcVKluG4 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(396003)(136003)(376002)(451199015)(46966006)(36840700001)(40470700004)(81166007)(6506007)(4326008)(40460700003)(33656002)(7696005)(26005)(356005)(70206006)(2906002)(82310400005)(86362001)(70586007)(47076005)(186003)(52536014)(5660300002)(83380400001)(336012)(82740400003)(966005)(8936002)(36860700001)(41300700001)(478600001)(53546011)(316002)(9686003)(55016003)(8676002)(6862004)(40480700001)(59356011)(219803003)(207903002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 13:58:22.0206 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4810428d-24d4-4f1a-82e9-08dac3eccb89 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6127 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFJlOiBb UEFUQ0ggMi8zXSBDSEFOR0VMT0c6IEFkZCBtaXNzaW5nIGVudHJpZXMgZm9yIHdvcmsgZHVyaW5n DQo+IHRoZSA0LjE3IHJlbGVhc2UNCj4gDQo+IChyZWR1Y2luZyB0aGUgQ2MgbGlzdCB0byBqdXN0 IHhlbi1kZXZlbEApDQoNClRoYW5rcyBmb3IgZG9pbmcgdGhpcyA6KSBJIHdhcyBqdXN0IG5vdCBz dXJlIHdobyB3b3VsZCBiZSBpbnRlcmVzdGVkIGluIHRoZSBzZXJpZXMuDQoNCj4gDQo+IE9uIDEx LjExLjIwMjIgMTI6MjIsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+ID4gICMjIyBBZGRlZCAvIHN1cHBv cnQgdXBncmFkZWQNCj4gPiArIC0gT3V0LW9mLXRyZWUgYnVpbGRzIGZvciB0aGUgaHlwZXJ2aXNv ciBub3cgc3VwcG9ydGVkLg0KPiA+ICsgLSBUaGUgcHJvamVjdCBoYXMgb2ZmaWNpYWxseSBhZG9w dGVkIDQgZGlyZWN0aXZlcyBhbmQgMjQgcnVsZXMgb2YgTUlTUkEtQywNCj4gPiArICAgYWRkZWQg TUlTUkEtQyBjaGVja2VyIGJ1aWxkIGludGVncmF0aW9uLCBhbmQgZGVmaW5lZCBob3cgdG8gZG9j dW1lbnQNCj4gPiArICAgZGV2aWF0aW9ucy4NCj4gPiAgIC0gSU9NTVUgc3VwZXJwYWdlIHN1cHBv cnQgb24geDg2LCBhZmZlY3RpbmcgUFYgZ3Vlc3RzIGFzIHdlbGwgYXMNCj4gSFZNL1BWSCBvbmVz DQo+ID4gICAgIHdoZW4gdGhleSBkb24ndCBzaGFyZSBwYWdlIHRhYmxlcyB3aXRoIHRoZSBDUFUg KEhBUCAvIEVQVCAvIE5QVCkuDQo+ID4gLSAtIFN1cHBvcnQgVklSVF9TU0JEIGZlYXR1cmUgZm9y IEhWTSBndWVzdHMgb24gQU1ELg0KPiA+ICsgLSBTdXBwb3J0IFZJUlRfU1NCRCBmZWF0dXJlIGZv ciBIVk0gZ3Vlc3RzIG9uIEFNRCBhbmQNCj4gTVNSX1NQRUNfQ1RSTCBmZWF0dXJlIGZvcg0KPiA+ ICsgICBTVk0gZ3Vlc3RzLg0KPiA+ICsgLSBJbXByb3ZlZCBUU0MsIENQVSBmcmVxdWVuY3kgY2Fs aWJyYXRpb24gYW5kIEFQSUMgb24geDg2Lg0KPiANCj4gTWF5YmUgYmV0dGVyICJJbXByb3ZlZCBU U0MsIENQVSwgYW5kIEFQSUMgY2xvY2sgZnJlcXVlbmN5IGNhbGlicmF0aW9uIG9uDQo+IHg4NiI/ DQoNClRoYW5rcyBmb3IgeW91ciBmZWVkYmFjayBmb3IgdGhpcyBhbmQgbXkgcHJldmlvdXMgZW1h aWwuIFRoZXkgYXJlIHJlYWxseQ0KdXNlZnVsLg0KDQpZZXMgb2YgY291cnNlLCBJIGd1ZXNzIEkg bWlzdW5kZXJzdG9vZCB0aGUgb3JpZ2luYWwgc2VyaWVzIGFuZCB0aG91Z2h0DQp0aGVyZSBpcyBh bm90aGVyIGltcHJvdmVtZW50IGZvciB0aGUgQVBJQy4NCg0KPiANCj4gPiArIC0gSW1wcm92ZWQg c3VwcG9ydCBmb3IgQ0VUIEluZGlyZWN0IEJyYW5jaCBUcmFja2luZyBvbiB4ODYuDQo+ID4gKyAt IEltcHJvdmVkIG13YWl0LWlkbGUgc3VwcG9ydCBmb3IgU1BSIGFuZCBBREwgb24geDg2Lg0KPiAN Cj4gU1BSIGFuZCBBREwgc3VwcG9ydCBpcyBuZXcgaW4gdGhlIGRyaXZlciwgbm90IGltcHJvdmVk Lg0KDQpJIHdpbGwgY29ycmVjdCB0aGlzIGluIFYyLg0KDQpBbm90aGVyIHF1ZXN0aW9uIGZvciBh ZGRpbmcgYW5vdGhlciBlbnRyeSBmb3IgeDg2IHRoYXQgd29ydGggdG8NCmJyYWcgYWJvdXQgYSBs aXR0bGUgYml0OiBJIGRpZCBhbm90aGVyIGRpZyBpbnRvIHBhdGNod29yayBhbmQgZm91bmQgdGhh dA0KdGhpcyBbMV0gbWlnaHQgYmUgYSBnb29kIGNhbmRpZGF0ZS4gSUlVQyBfX3JvX2FmdGVyX2lu aXQgaXMgYSBnb29kDQpmZWF0dXJlIHRoYXQgYm90aCB4ODYgYW5kIEFybSBoYXZlIGxldmVyYWdl ZCBpbiBkaWZmZXJlbnQgbGV2ZWwgdG9kYXksDQpzbyBwcm9iYWJseSB0aGUgX19yb19hZnRlcl9p bml0IG1pZ2h0IHdvcnRoIGFuIGVudHJ5IGluIENIQU5HRUxPRy4NCg0KSG93ZXZlciBJIHNhdyB5 b3VyIGNvbW1lbnRzIGluIFsxXSBzbyBJIGFtIG5vdCByZWFsbHkgc3VyZSBpZiB5b3UgYXJlDQpo YXBweSB3aXRoIHRoYXQsIG1heWJlIHdlIG5lZWQgdG8gY2hhbmdlIHRoZSB3b3JkaW5nIGEgbGl0 dGxlIGJpdCB0bw0KcmVtb3ZlIHlvdXIgY29uY2Vybj8gV291bGQgeW91IG1pbmQgc2hhcmluZyBz b21lIHRob3VnaHRzPw0KDQpUaGFua3MhDQoNClsxXSBodHRwczovL3BhdGNod29yay5rZXJuZWwu b3JnL3Byb2plY3QveGVuLWRldmVsL3BhdGNoLzIwMjIwMzA5MTIzOTM2LjE2OTkxLTMtYW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbS8NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCj4gDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:09:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:09:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442557.696816 (Exim 4.92) (envelope-from ) id 1otUiB-0004VK-QI; Fri, 11 Nov 2022 14:08:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442557.696816; Fri, 11 Nov 2022 14:08:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUiB-0004VD-Ma; Fri, 11 Nov 2022 14:08:51 +0000 Received: by outflank-mailman (input) for mailman id 442557; Fri, 11 Nov 2022 14:08:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUiA-0004V7-BD for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:08:50 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2055.outbound.protection.outlook.com [40.107.20.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5cf1374e-61ca-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 15:08:49 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9101.eurprd04.prod.outlook.com (2603:10a6:150:20::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 11 Nov 2022 14:08:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.027; Fri, 11 Nov 2022 14:08:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5cf1374e-61ca-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Aw3fvTPZKUrET96znaE1Yv659nzGqrfLxSsu9LgD0BBLGJgQqwGgbEKTu2WtnE+bcS2pII4sYebUuNOFtbdlNDFydTeRbohTE1Ssh842LtRrb1bUJGafxj2RoXWrlvyqMUvMxy7ALxyjw6TrkmZ3n1MX7g9hJcGn6/kd0YYYPxx9optDymFZ4BRijUn744DNaUK/b8fYNjHtjpwhRbKID8cVLNnk8n5m50dpqD/UjuG19LP2LD8Hp+2a1fxJq3aluSVvTtV5wu0fczwZAmlfavSqMRPnNCZmE92JFrMmh0sfFpdusL3xBMF1/piiiYTuZIeARyUb8TWvuqkVDla4tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ogewk2GqxyZhk4qra3R1iN0Isd8UxgdYdYLOlrEG7Bk=; b=k6dC70TppX8IdcqkDyA3Q5fffXJNM/2q1/fFCUY0/taKKxHbYlMeqCxTV+Kql3lO1m1KVdrtJj1IOeWA6uq/xGgbqcoIgX3ZO2tAQGbzo9ZVa+OaLYaI7T6YDc3GIPxb1241Ynb9ymVEHYEJIG/Jk3PoGWBx+XL/uFVNB39fA5E7Vu8YXxwVXRBNi2LzUNqGs5uKDL3oJzYnfgg7WZ9vnZcxKTID08jkXGSlaDavKdNy/YeWx3ZPCfuRkUW6DVsYBZQriR1/dcRGwqvMWriO++jyT7zywXEjJ+m5NbkkDC4bl4Ej5Soc+Stusy4kPF3ifnW7/6YXNRuGSvrjbsXCKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ogewk2GqxyZhk4qra3R1iN0Isd8UxgdYdYLOlrEG7Bk=; b=zoWKyuWfyjn81sv5TjhrpiksauiR/kESphpZK/u2MJZg8L6leBpG95zcvgCK7sxr0HCiqq1IcP3NkFdcY03rNfdV9S8zYe/gNbmdm5rVJnDs5D2fi/y6gZBjCDft23en1ps9YdQsXsg0Ne0S67i5EYANaS/CQuimqLIwKsRdfZLmWKGnrkr/nzQoyEET0NMNVy69MFU5qtDwCrBoZAyJOmVnhYuxjMyEtdFbpcvrJONImcCDFdGNNZ1lHB+tjatmNlFfJ/gqiz2HwpSV4kzHxT1D/yJEgIbMXD0F6Q6RmLgENV+15Seo5YSajIcJXVvOOxPloLqqUv8zSwyQ3+W99g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 11 Nov 2022 15:08:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release Content-Language: en-US To: Henry Wang Cc: "xen-devel@lists.xenproject.org" References: <20221111112208.451449-1-Henry.Wang@arm.com> <20221111112208.451449-3-Henry.Wang@arm.com> <4482952f-86a9-d232-6cf5-afa6523012dc@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0744.eurprd06.prod.outlook.com (2603:10a6:20b:487::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9101:EE_ X-MS-Office365-Filtering-Correlation-Id: e529b98a-9995-467e-c05a-08dac3ee3f9a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QZvLKTWqqRs4/OM1kdJLw4ocX15Aeg4Zdrbz0i4E0dwf2gyRhu0ylkqJxa3pU1nLTkeHZ/5RsxjV+6q/aXssLJycpS3A/m9Tqcx2s/DOdeg0iT0mGH6hCIU1tUyOnzLlcogIq8CAS5CfDBEnwwGVmhDNaC5ghaWFH96xsdInNd8J4/DjAs1jFhrKdj2mzROOsgdJ2uOAfpdbLNFVB60EbIyu+vEu4RA4a4r1pfKpFfAEvc2KYUmJOJt+3U/3QWNGDe7bjbdkXAw5ayyGNQO49fLJhP7dOnmSWU8uG6ntkvUpcvLc58ADyB+AV5h+KqFn0ted1m5nwHoM98ZeFg0aoFLfk7FliCbvs1YS91k56rxE79Y8Fu+4GzNHa7FxSazScgKjT8mFs+A3oA3IAOauD5C+XhZgFkVHnHenXuN00ftrFjveId7AiuEum61V/9qCDGPateKM6nc1gDrQmo9yxgwav4Q1YCaJTFxjXObnOZN4mVCl+ckhba6WstAdHiCfu7dyPDPP7tBD886ghTeSwhJiwO6+wWSRz1Ify2yOcfhToRmQY6F1ZRTLLG1F8Gs1K0mt1u/MvkE8oTbIHTlajraelot/yoIMLQu+RF4iJFOe5k4ySzvh6ps/rGxrGWeNSpcYVbZxenDTtAOgwBzftoc6+RKDNfsU23zytFkcPcFvdheBOkkvTgjDGxcHNtD352qopXiId9/bbD5Faqq1mkR0DtYALLklxLq9Lls8PJi3mikSthxzGuedTZ+epd/M16gjb4OW/AXd+ZuDpn2bG0LhD9MdvMbpo13UaoRqZHhvArOVnzMpKU7cYSoU+TH19PnP6/JsdpgzWu77+Hfc9e6x3x0QyvzoT6d9CUZA9uFPiVueE+PAWisgDq/5iLba6ZldPk/ELj+tAdKDKZOZmw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(396003)(366004)(376002)(39860400002)(451199015)(86362001)(5660300002)(4326008)(38100700002)(316002)(6916009)(66556008)(66946007)(8676002)(66476007)(31696002)(8936002)(41300700001)(186003)(53546011)(6512007)(6506007)(966005)(478600001)(26005)(36756003)(31686004)(6486002)(2616005)(4744005)(2906002)(59356011)(207903002)(219803003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aE93ejZEUkRka0Z0WWRWVVdMK2krVWRpY1VTaGhTMDN6QjJkNk1veGxicU9l?= =?utf-8?B?Yk0wMXVpOUVBUlRmemlPbzVlVUtCZDBwVFhzZUp5RlRqb2dicyttRUZmcUhM?= =?utf-8?B?WUc5OTRxS294NzhOQ0lWdHlIeXJ1UFljbGJ0amhETFJQS0RzcjdNQlJWK2JR?= =?utf-8?B?ODI5MUlaU3Mxb1VSekNBS3FRM0MyaGxuL1Q4NDFFZU1SdHhuUEZ6Z1NzcWNk?= =?utf-8?B?OU13OWc4eHliOU03M2pWMjBOSTdlMUdVbTFJOW9pQWJPV0ZkL2dwdEgybXN5?= =?utf-8?B?UUNGcHZkQllIMjdwUmNaeTlKS0xkQ0NMM2FHSzRwc09rNFplcjZKMTkwcStR?= =?utf-8?B?Z1VGeEJQVzZPMU1SUjZiY2NvSlFCYUlKSkQ2eGVkekFVaDdjTFp5QlhJYkl2?= =?utf-8?B?WDdVdnFXcTZyZjlzeVZUMmx4SDM1U0lRUERuZjBOQ2p2eUVNd3pTSHNDeUVy?= =?utf-8?B?cDVhb1B5MkxPMVJzUVc2RHBBQ3dmU3RFVGtUYk5YRGVQTURDUGEzRkxmTkdY?= =?utf-8?B?MWdoMXFwRlJKckJyM1RGN0xyM1liRmJKdldCY2dFYlVGYVFPaDhrQ3djWGdh?= =?utf-8?B?dnZ0U2lkb0NIL2poZkRpeGgrM3VGZU1GUWExZXFqNXFWYmtMQ0lYSlB3RFpL?= =?utf-8?B?Qnk3ZUc3U3hBSWFYTjdaYVNLWmtLOEphbk9NMmd2bVM1MDJpVkVPOW9RWndp?= =?utf-8?B?ZkRKNDVKTytIL3lUVlQ4MjJPR21zVERKZ29YYVpjdnpKZXo2eEx4V0hzdGR1?= =?utf-8?B?RGZZVE1ac2pUY29LbjFyODRjTU5ETUNlQUNYUW1HK2JYeW9vVjBaWnVhYmI2?= =?utf-8?B?c1JDQXdnbVowMEozZ1FxYzVlSjVYVDFLS0srWFJjVElzUW5uYkhHcDdKZk5s?= =?utf-8?B?SGpYd3djZzRKZXpMdllyQkN5Zi9XRmRIT2NZUzBFalI2ZGxaMlhueGR1a1dR?= =?utf-8?B?RUdlT2hXNDY0SDBodS9GYjEyT2NkaFl4YWI4LzJ5aGJCV3Zjd1RkdkM0b2dW?= =?utf-8?B?bzRYdWhUbjM1S2FwY2liaHRKeTNPN2J1cDhEU3pLYlJvN01jY1h0WWZSOFJQ?= =?utf-8?B?RnVzZ2lzY2Uxa3pPT0V3QUFMNVBILzh1cVg1bFZhZ2xmekVvTDZ2ZXFOQ0dV?= =?utf-8?B?STUxODZDeVBHbzhiVC9LWC9VZlN2dWlrZ1crT3JaeStxa2NtYys5WlMreFVL?= =?utf-8?B?OWdRZUJ3MFgxUGV3MlpHSXhZb2dZMXluQ3BMeVFiZDFqMW9WYU1mOHdvRitX?= =?utf-8?B?TTE1SFBycGhZWjI1VlpqVlhyNlJ5YkhRTERIUGlKTEsxMXBHSTF2WDJVRHVM?= =?utf-8?B?M25qVE5PVUdVVVpmNkg4dHNTNjVKTWRLUVo2SHoyR0J3VnpkZWVUT2FtOE00?= =?utf-8?B?ZEI4Y2Z3UWxKMWNMUDV0SW5pbHpnanlnM1hRYWJjRHptRHhUQTJoTlBhZXhI?= =?utf-8?B?THB3ODlKeGxibHBRb21TSVd5UUhXR3dNWHg3MWR3L1JrRTdmL1JEa3J3ZzZt?= =?utf-8?B?TWJ2eDl1dGpMRWVZZGlCOG85VmNTU0JqakdFVzR1SjNPT2wrZzgrVkdlNDB2?= =?utf-8?B?REF1b2JuMmNPNTRxVXllOGNuUEd4R1RGS3VDWHpPMUNNNk1QZGUyQ2R3TVlv?= =?utf-8?B?NFVjR1ZuL284T25TZlV5THZkdlNSM05UWHpWWjJrd2lUZDROL2FLNGtoYi9t?= =?utf-8?B?dklOVFNGVWszZWZyaVc2dUJWRVpwM3VVMkQzVWREeXkrNGZaWDlpYnJhdVNS?= =?utf-8?B?V1dXdEZLZ0lkR1k3YXBRWTRxRG5LV2ZDQzcrT1FZWjFrMVBLWXJqc0RHODV1?= =?utf-8?B?YW9ZMGdCWDBDajhCUHNTUXpHTGFqTTFMOURIVGNnUWlVK01XcjNUMWZ6bm5D?= =?utf-8?B?TU8xelJ5L242azVnQkF0bEpjcEhiUXU0OUVETHdtS2YzZ21zMUZnK0ptb3Rs?= =?utf-8?B?MGlhMWNuN2lMbUJZZC8rcjBob21BRVJvN09IaS9XOFcvblYzZU9wbE1ZWUJj?= =?utf-8?B?N3U3c1owVmpNV2FDL2FZeEpmeGxWK3l1SUNuQ2dzcnlUTi9pYzVHbXFEd2V4?= =?utf-8?B?WWN2c2NEU0FqL2wvYUp4MHF1NGNER0JNVmdzanMyRmFHTmhObmFVRDg4N3Az?= =?utf-8?Q?jq0BbVeFdDaPa2I9pTx+nh2at?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e529b98a-9995-467e-c05a-08dac3ee3f9a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:08:46.4335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4bc16F++72i7qD1AQHZvkMwfo0Ysm2K5BTaaqyCWMR1NSg02VSVuogNbjUSUt9j/QkbPcMZ6drQ0mvjVG6IXXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9101 On 11.11.2022 14:58, Henry Wang wrote: > Another question for adding another entry for x86 that worth to > brag about a little bit: I did another dig into patchwork and found that > this [1] might be a good candidate. IIUC __ro_after_init is a good > feature that both x86 and Arm have leveraged in different level today, > so probably the __ro_after_init might worth an entry in CHANGELOG. > > However I saw your comments in [1] so I am not really sure if you are > happy with that, maybe we need to change the wording a little bit to > remove your concern? Would you mind sharing some thoughts? My view hasn't changed, but if Andrew and Roger think this should be mentioned, then I'm not going to stand in the way. Jan > [1] https://patchwork.kernel.org/project/xen-devel/patch/20220309123936.16991-3-andrew.cooper3@citrix.com/ > > Kind regards, > Henry >> >> Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:12:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:12:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442560.696827 (Exim 4.92) (envelope-from ) id 1otUlc-0005uP-9i; Fri, 11 Nov 2022 14:12:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442560.696827; Fri, 11 Nov 2022 14:12:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUlc-0005uI-5P; Fri, 11 Nov 2022 14:12:24 +0000 Received: by outflank-mailman (input) for mailman id 442560; Fri, 11 Nov 2022 14:12:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUla-0005u6-Qx for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:12:22 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2071.outbound.protection.outlook.com [40.107.22.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id db8b0f76-61ca-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 15:12:21 +0100 (CET) Received: from AS9PR06CA0014.eurprd06.prod.outlook.com (2603:10a6:20b:462::8) by PA4PR08MB7522.eurprd08.prod.outlook.com (2603:10a6:102:26b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 14:12:19 +0000 Received: from AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:462:cafe::ac) by AS9PR06CA0014.outlook.office365.com (2603:10a6:20b:462::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Fri, 11 Nov 2022 14:12:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT016.mail.protection.outlook.com (100.127.140.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 14:12:19 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Fri, 11 Nov 2022 14:12:19 +0000 Received: from 00687880f820.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AFB41216-47A5-4B4B-92E0-345D8E8B9A18.1; Fri, 11 Nov 2022 14:12:14 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 00687880f820.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 14:12:14 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAXPR08MB6432.eurprd08.prod.outlook.com (2603:10a6:102:154::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 14:12:12 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Fri, 11 Nov 2022 14:12:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db8b0f76-61ca-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Qi3P9WgRnMO3ufrf4imC2nhrXLn3q/5vmrAt5fiqNQ+U2Z1w6CskmQnSgb3B5B3GFMAWgJIhV1Kn76RpB1ThXSCe6cODx3A3c/NuGzw1UtyVISaN3ZpRfVZ5zPzDbpMvjMnX9FUazmW/uXNkyjn5tra5+TAllDEOruyIkKK0e6soqx6uHqPhsHVNBWj2fS+nkjMgBvBAGOLUpaS5SyTNwtgDPuCXz0kdTuTNVjezgba+T3TZYRXqoJTc724k7pHfPe/v7rFl1oG5AJZt0xDLfmdRJwEB19i9TOB/oFW4MZcg/FMCxbr8mf2f9GSu7EgGzIdlUoAnFXVRizygHcsSBw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GkPoq7KHg8gvsjBSRB/PlTQJD+gulsNomEHgbBYpi+c=; b=Ze8K81t8qo+KerieDLDtGGuMXYtb9ejTdU9aiT9oJxIH4RrkDqDO8+dVLh22dl0YL3GO0pRW6mj81IDhtHFbEBKssjwW4WKmf8xNtNTim5m6Ob0RWPHv4l2h8YYVhCooisyUYCm+V6TPn0JzPINCkZuMhBbpDUW9yjONY+wnq98P6q+Nx9ji1s47SZLZTnNzvIuLAfjYABv19Faa57GMGvAkBMAjW7bW9HEOFPnkZMc5QEoaCheg09XpwYamrKJWRNEFY4dT2ggDa+OWvc5xcA6qqG63GSPFnVVGmz844YIHcHzj0kdK5EsTdRvIws2MtdafiBXrXl+xG0g926Jovg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GkPoq7KHg8gvsjBSRB/PlTQJD+gulsNomEHgbBYpi+c=; b=VFBHpgWCSLeC0eXf+Pa19UB8+nNrRMuTiKiilnaJxjAGLvn01MJKxBNqp0w+hW47rHdAKuRW4z2HfCyCe0WZGaY8AA1Rzt3ubjtk3Z5eJQ8/jNoT/IBJsVGvI+elyMuOPeUIYv7WAKoCxDEZwN/hN72pE26NlaVURLk4XVNdC+Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G2yQYbDY55nzg3UXte7ZlbgImTKQlcsn8XUeFcUtf1A+z0egoXIdwkxLqtnOl/Brt6SlnMNbA6Y9+iqAAmzJs54fgSfYECNo1TgEt+iGvp1/NTKKcto7a/kMGhiyujSAl9SBVudCuUKrLFP1TXN+1P6CpP/PsEIBoZXl2p7B79oPIvUvamh968oneGjczV9dpmpFjb1ZnI4wibKQ4YpcCeowGfHGCZZyBoHFGnMjfGzqN3T21v32YoS21iM8i1L6cl73JKnkjTJsE05LHFwiYnopSjNwC4UtR3pysIDJ4+9kib2fYBnWzA7flt9yG+cUpE+CM+3+5XkfCbZWhGSeKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GkPoq7KHg8gvsjBSRB/PlTQJD+gulsNomEHgbBYpi+c=; b=bfi1LIZT+vaVldUjW6z6rmO6ViICl+edNVXu6Ptf7IloEvgBmaXgKROmb/0tANBzL4IzqhVXZUUEIi2isrKo3R4bKq3H/wXYGW4+Pm61omdUEkSQPmqADtSDR8nytPLLpNtiNXfWpvEo2hBO93JRxxIMFnsx0ALAMgz3/gNRjsft8Kdau7f88lNbhx+VHNinHDTlzfgDatb3Q2nTmp/YvIHmNl1kSj9oHZBxdQHv1r0PalSev/IiUTG+eaYrgNrN5JzdJsVLqant8pUtPMIbgdlx6tqXCv0IgKeGtKAoEeFaascXF5M0Uwh9mpSESvsmiYxudwmqeomx4xu7rXz62Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GkPoq7KHg8gvsjBSRB/PlTQJD+gulsNomEHgbBYpi+c=; b=VFBHpgWCSLeC0eXf+Pa19UB8+nNrRMuTiKiilnaJxjAGLvn01MJKxBNqp0w+hW47rHdAKuRW4z2HfCyCe0WZGaY8AA1Rzt3ubjtk3Z5eJQ8/jNoT/IBJsVGvI+elyMuOPeUIYv7WAKoCxDEZwN/hN72pE26NlaVURLk4XVNdC+Q= From: Henry Wang To: Jan Beulich CC: "xen-devel@lists.xenproject.org" Subject: RE: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release Thread-Topic: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release Thread-Index: AQHY9cAA3X9w+pjMxES5dLMt0fkbDa45tnoAgAABRRCAAAr5gIAAALlw Date: Fri, 11 Nov 2022 14:12:10 +0000 Message-ID: References: <20221111112208.451449-1-Henry.Wang@arm.com> <20221111112208.451449-3-Henry.Wang@arm.com> <4482952f-86a9-d232-6cf5-afa6523012dc@suse.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 13D7A72EAF19EB46B612DE800F5FED68.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAXPR08MB6432:EE_|AM7EUR03FT016:EE_|PA4PR08MB7522:EE_ X-MS-Office365-Filtering-Correlation-Id: 832b83e0-52ac-42bc-c73f-08dac3eebe99 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eQ7l5N79b/LUnX4qBwdywk5ZHJUitxR1r5pr+Omq4mTNDeHB1CCCnlsCMJNQtD1UQLdkcRjkWrIbeA+h0KsJpgQLHHWVYazHxTlFbGTBxEU7bDq7kcwSpoX4zTQOfA6ES8EM9SfKcHUIEtsxpRCJhC7aKMer6BVkThjpXhwW04SHmXPzVDpnRo6eVWbvVRpuvSnAOiZVBft5Ef5F2HU72E5U87heEO0r28Y2xDNeELvpyzyAhkRUuSntNb5lJxR2DiaxXQ4wWdMZG1b0h11SE5MxPVcgRIThZ5Qpn17Wcom3EJpp8GV7fMNLQlreDWx3YD8dUQXpktT4hpEoRPTENn3Ky59c3EdS/ihZgsrZMovJ/2sVWc+5ZpeSDS9Hd878y0+oITKPhyhpcIFNPZsaU7AAVhfuaNvr4VjbhYBTzpI7FyMnEwhh4QcdJYwucnlBOzviFZH5yJwHCQHMl0Q9x7P5YlKkyEuYGKKNhJO+ER2H9fChjojBV87mWFQzf3gbyVwOpRcAELmhYqgEOG+4L9GsR51n9i/IptwLqfG3H+zfcQJwvBd1S5o+JW7PW3/LIRCbnCSoFqcj1JmsY/ovJhKGtgGd9woe0YCppP6M+JYutiOw5fmuSZL72nR5wY9hvIvBJDUQMZgnPedEHMI9EuEz1ZW8z7A8vqKrj61SryQ2xHBs58nPTttB75MB+++SVbxLczgEAwxpLYI+Ww4QvjJ4o0gnbEoR8qAvZX6Og8Y7fxQZI1WcwNU+T6uZm0YWqJQIczGAMxhC+tfx4IQMUnqF6PNZVmTVySUe5qqjJgNQ5Ut15e05hhxNfzM/KtQghKMnLljGZIxb0kfos+b3PUGonMhuldE6SDRDkygZccTSFK5Tumb+InIoLOuBeHtCouXv5vvR9sY9J5G8iJnfii242A4MNWAUI7Xs5FVC5AE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(346002)(376002)(136003)(396003)(451199015)(33656002)(38070700005)(86362001)(83380400001)(55016003)(2906002)(5660300002)(9686003)(53546011)(26005)(7696005)(6506007)(122000001)(186003)(38100700002)(76116006)(6916009)(71200400001)(966005)(66446008)(316002)(66476007)(4326008)(8676002)(64756008)(66946007)(66556008)(8936002)(478600001)(52536014)(41300700001)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6432 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0b34389c-2e0d-4f04-9a89-08dac3eeb9a1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FErqWrn9awvs0zeN5/t02xuRhVCOg/cMDbvCDVWpgG1MeOrEkhcdYWyc5IVhBZSMv4sYYkrUWZOCtffVU2TZhqlYo45LJuRuyHqpLVEY6dmg1fMMWFTSC77U2OGaA7m0jktJBSxq7oLsgNZr63tzktL4ocKiSPNmCY5uZIspFvhrihlDZ5EJ0vInUVzmVzsh5aumNtB5EslMrxk1sYvq1qhSgkm4aI2c0kikzca7MDg4jjVuN6kMw5zgc3GAWqB0j+pG/o3Yv1/yYJ/fC83CnUVEwEzyidwwXK38YV+RXOGc6fjR7gB7ASzhHAG8ADjQ/9pyDBnw+bqUXJFRFYySEPuDAL/1dMq4SjOE1O48STruSzch0yh0T2Cm5OLP6HEEzNPaiGgoxULspORIs/HDxKETnp7gB02Z8ftsazF1GJa3laDgoG1+m6eu38zjsMfAXKt1xLK2Qmoy6U3CpI46QPHTmsO3lLkJ9goENjaj8ma+Zk/LZy0XPFVe6cAgKPGdMb6DtBVrPmFiRyXfI2ltnwRdSaEbqS6ebbMKGz4pc3fRZEuEKUbI/vGaO5soYTBAjypUzsgsT2mlhDP5RehbZsnlaUupLJAxnCAEb4x0hesfeNSZHpvPjKYB6OpIt8kzVYcgDiBLe9RGU2umfGloV866zqldQvSJINp6zi4UJK2FzGj7/84ZRTRzDZzJJMovfitN7EAg5ockM8vlWlNCQW/Eqk/s7uJHAvA2nrNldKvJwDa7PZXC+NPFIJFQEHFLaL16Xp3XVu0ZFQEUZXC7JIbz8daRk7O+2m1gEZfs6MD92ftP80rfvbndN9gT65hCvTx+ZwMblMq5nwnDO4JP3sMvmOnfFTY+oieDpRxqbjoLqs38FlXoCdXFJT8vywxd X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199015)(46966006)(36840700001)(40470700004)(8936002)(6862004)(86362001)(5660300002)(2906002)(26005)(9686003)(83380400001)(7696005)(6506007)(478600001)(33656002)(53546011)(356005)(81166007)(966005)(55016003)(316002)(40480700001)(82740400003)(41300700001)(82310400005)(52536014)(186003)(40460700003)(70586007)(70206006)(8676002)(4326008)(36860700001)(336012)(47076005)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:12:19.3103 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 832b83e0-52ac-42bc-c73f-08dac3eebe99 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7522 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IE9uIDExLjExLjIwMjIg MTQ6NTgsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+ID4gQW5vdGhlciBxdWVzdGlvbiBmb3IgYWRkaW5n IGFub3RoZXIgZW50cnkgZm9yIHg4NiB0aGF0IHdvcnRoIHRvDQo+ID4gYnJhZyBhYm91dCBhIGxp dHRsZSBiaXQ6IEkgZGlkIGFub3RoZXIgZGlnIGludG8gcGF0Y2h3b3JrIGFuZCBmb3VuZCB0aGF0 DQo+ID4gdGhpcyBbMV0gbWlnaHQgYmUgYSBnb29kIGNhbmRpZGF0ZS4gSUlVQyBfX3JvX2FmdGVy X2luaXQgaXMgYSBnb29kDQo+ID4gZmVhdHVyZSB0aGF0IGJvdGggeDg2IGFuZCBBcm0gaGF2ZSBs ZXZlcmFnZWQgaW4gZGlmZmVyZW50IGxldmVsIHRvZGF5LA0KPiA+IHNvIHByb2JhYmx5IHRoZSBf X3JvX2FmdGVyX2luaXQgbWlnaHQgd29ydGggYW4gZW50cnkgaW4gQ0hBTkdFTE9HLg0KPiA+DQo+ ID4gSG93ZXZlciBJIHNhdyB5b3VyIGNvbW1lbnRzIGluIFsxXSBzbyBJIGFtIG5vdCByZWFsbHkg c3VyZSBpZiB5b3UgYXJlDQo+ID4gaGFwcHkgd2l0aCB0aGF0LCBtYXliZSB3ZSBuZWVkIHRvIGNo YW5nZSB0aGUgd29yZGluZyBhIGxpdHRsZSBiaXQgdG8NCj4gPiByZW1vdmUgeW91ciBjb25jZXJu PyBXb3VsZCB5b3UgbWluZCBzaGFyaW5nIHNvbWUgdGhvdWdodHM/DQo+IA0KPiBNeSB2aWV3IGhh c24ndCBjaGFuZ2VkLCBidXQgaWYgQW5kcmV3IGFuZCBSb2dlciB0aGluayB0aGlzIHNob3VsZCBi ZQ0KPiBtZW50aW9uZWQsDQo+IHRoZW4gSSdtIG5vdCBnb2luZyB0byBzdGFuZCBpbiB0aGUgd2F5 Lg0KDQpUaGFua3MgZm9yIHRoZSBjb25maXJtYXRpb24uIEkgd2lsbCB3YWl0IGZvciBSb2dlcidz IGJhY2sgb24gbmV4dCBNb25kYXkNCnRoZW4uDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4g DQo+IEphbg0KPiANCj4gPiBbMV0gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9qZWN0 L3hlbi0NCj4gZGV2ZWwvcGF0Y2gvMjAyMjAzMDkxMjM5MzYuMTY5OTEtMy1hbmRyZXcuY29vcGVy M0BjaXRyaXguY29tLw0KPiA+DQo+ID4gS2luZCByZWdhcmRzLA0KPiA+IEhlbnJ5DQo+ID4+DQo+ ID4+IEphbg0KDQo= From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:17:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:17:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442565.696837 (Exim 4.92) (envelope-from ) id 1otUqu-0006ib-Sf; Fri, 11 Nov 2022 14:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442565.696837; Fri, 11 Nov 2022 14:17:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUqu-0006iU-Pk; Fri, 11 Nov 2022 14:17:52 +0000 Received: by outflank-mailman (input) for mailman id 442565; Fri, 11 Nov 2022 14:17:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUqu-0006iO-7A for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:17:52 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11hn2243.outbound.protection.outlook.com [52.100.172.243]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9f28a3dc-61cb-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 15:17:50 +0100 (CET) Received: from DS7PR03CA0352.namprd03.prod.outlook.com (2603:10b6:8:55::32) by DM6PR12MB4060.namprd12.prod.outlook.com (2603:10b6:5:216::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 14:17:47 +0000 Received: from DM6NAM11FT105.eop-nam11.prod.protection.outlook.com (2603:10b6:8:55:cafe::dd) by DS7PR03CA0352.outlook.office365.com (2603:10b6:8:55::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25 via Frontend Transport; Fri, 11 Nov 2022 14:17:47 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT105.mail.protection.outlook.com (10.13.173.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 14:17:46 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:17:46 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:17:46 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 11 Nov 2022 08:17:44 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f28a3dc-61cb-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gR2ZhK/uVLMuLFTFO/fxtJoeMjqOwRmuhkrFXvSztwysbXjpzvQHT+KHswvti0Kk9UKx/WLWjlmx4aqr4GS5lgpJ2gZY91aGpwzRsojxn1/lgKeM0Qhw6xlM50i1nPJOUx0IUUWp3sXbZrEM8U4SBoOyIlnqbEFO2JwUppG6YpMBx5sDDvqtstbFo3WC09gslPjtv/e7B8QH2XZhGNOq5m8A5TXlj9V86z1wft6Pf4ZI/av1t0RuQ3dAeomBudsfwWQK1G+tiJns1+B7TgAq3zyRR9KlTRfVNqqOIthgYU1sxyzsAOHA9mgKFQ5y/GCAl657v4zTxk3KfRfAd5/1vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aim/bCE7/5lpbsSDqhk+xfMHlx/OJpQ0bTD2473DUf4=; b=NGPr1AF6aDROaRdEsiS7YBQ5YzBv6wiOdWVQocUP2ru4A2gKako57DLDIoQ5ewu+0fA9o8dum7Ytij1rngRRLytY299sGmWFevAGiZo7QxvTDdzVyBK5FCnftnwZMMasBtRAyGEQln/mZzNfqxNqAA+M57qvnfAVYDpYpsmeSLQ+HYNzisMoQSQrYwTkh4xmufBAQF5avK0Za/1TDg/wEdKfidvEg/o2A3CFtgZMM+66XPshhhFtQz9OCxdk31o12xvAWTb/ZrhD1stYz0uaVEmzXGeJM0hPGxv3RLQq1PhFXXl12aEAlAhWeacX4v8C9hToDfEANK5U4v5qC1/WLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aim/bCE7/5lpbsSDqhk+xfMHlx/OJpQ0bTD2473DUf4=; b=N/cRNXsQZYQPc5joez3vmCH8wk8+VuJviv3WO2bLXiYCDDumyDXzddK8h1wDH0JVLBzaBEtqOWE0q5gXSI38HgMJdbnjDlnE95mKR4X+Pi4Z+RRlfdpRk3oyd5ZcxwCH3ZAxjPFcTxkmrGe2w0XJs//fs+K8VFD8LCwZXrz5/EA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v3 00/12] Arm: Enable GICv3 for AArch32 Date: Fri, 11 Nov 2022 14:17:27 +0000 Message-ID: <20221111141739.2872-1-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT105:EE_|DM6PR12MB4060:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c8fdc8a-f5b3-4605-deeb-08dac3ef81d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?BrO9EfVrG4q9RhJU+JHXIn6pUjHtUfaKzn/WMAecKulffcsEb9aQ7nmY+TZ7?= =?us-ascii?Q?sIPAKeKTtOzbKmAhoFU2k0VS4fsJX51E0wVifc6sp5QUPpKxUUrnC0jVLSRA?= =?us-ascii?Q?0E+9SjZcZO/6io1vEg2cTzo9MQalQ3r5+Llo4zypAPj7uf73qhisMyAT+g2A?= =?us-ascii?Q?0gljOJnB0j0ovsDFwoyOGIW4O4ZmqTRQ+ccT93t2ObTWNyHW9FYkIFCetbul?= =?us-ascii?Q?u5ZsBDDyP+YzFlKqWwAXo+B3/YPVOJfHuWi3aKnDWRiyAo4IzQMQHXL4ai9U?= =?us-ascii?Q?nPCRd6djQINfEAhsQQ/lxjII/aBxVT2xACidQT0KfDkF+wK7nu4qOyBZOKJS?= =?us-ascii?Q?z3gGh32ItLr6p+bXUwIU8PjrZOyDa7166j6K6kIXQWE1ZWj5ukbuF/7Jqohb?= =?us-ascii?Q?PQPT9hYa9qIWklglmcwdfN38lrCOLDSqUu63QJuy0Wz/BjRYnhb6Y96UTGlE?= =?us-ascii?Q?zApvdjujSCAgfVNz1gBhGnmIzKpVKYHCZh5aCJHFjiv/1HwGPjNpaCXUY8XT?= =?us-ascii?Q?8+hps9e7/NhWv4xE1+Dji/ydIxj2uzNo7xc+Z79TCe6NiBmvu1GSr7cI/31/?= =?us-ascii?Q?PEfLtN7MvfiZyP+ZCmOzFVFirRxpqSRA0BrqQL092YFpAY5IHIGCDf1iDhKK?= =?us-ascii?Q?1MfFERH0SxQ3ocNJOBRWenJA0r7Ec9VOKBGLQIVtamlxzJILx2TkWqfny3W/?= =?us-ascii?Q?39um9y+tjYBHTsF3YBFoneCAy9vTD4QnIUzXGpeJWEQm5T9O+ZPgXclW+U9z?= =?us-ascii?Q?r1aC6Fp1XvEVfBz6npDtWej7wEBf9SLsuAUX+MhGyULXrrssb4xQpFqOUDO5?= =?us-ascii?Q?/606iVZ3tMNMz5aIiz4RHsXQurJNjBa5EOAWkSSUj35FX2agUP5Jilotu/Jf?= =?us-ascii?Q?tCeHcTwk8FZGiDuRLP8GxYH1hc2mfcyeEfqsnUNiry5D1DuOsBKEnO+ulFUH?= =?us-ascii?Q?TVBC5kdCc21mf8Y0XpbW6aBMHwNxlBDaXhVXrjYb+yhEPpXiY87oqdrcEXq6?= =?us-ascii?Q?ZKQeSzQT0cI30yLyh34GLYDjjawRIj03qk6OTDMzlU5suxKYm7HpSHGsbm1t?= =?us-ascii?Q?coKKqSPs7Rdq6BO8HFYZqJ2/06RRb+RCFAHrIpl2b59X+KQcLwU0bVV3i7hU?= =?us-ascii?Q?8EzGP0ohnBa80b6pflC+n199CKUa4py/FWYc9FdxUUd5NwizSUlWTPh8mS8i?= =?us-ascii?Q?wZ7A2C1sW4av6jRft+TrqoykSaNmJ2L6sANwZlg6WHhNXAAaOfA1mXQjlUY?= =?us-ascii?Q?=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:5;SRV:;IPV:CAL;SFV:SPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:OSPM;SFS:(13230022)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199015)(36840700001)(46966006)(40470700004)(36756003)(26005)(82310400005)(356005)(82740400003)(81166007)(36860700001)(5660300002)(426003)(47076005)(2906002)(1076003)(186003)(40460700003)(2616005)(83380400001)(86362001)(41300700001)(8936002)(6666004)(8676002)(70206006)(70586007)(4326008)(478600001)(336012)(103116003)(54906003)(6916009)(316002)(40480700001)(36900700001)(11215385002);DIR:OUT;SFP:1501; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:17:46.8180 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c8fdc8a-f5b3-4605-deeb-08dac3ef81d1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT105.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4060 Hi All, Please find the following patches to enable GICv3 for AArch32. This is a pre-requisite to support Xen on Cortex-R52 (AArch32-v8R system) Let me know your thoughts. The following patches have been reviewed and acked and contain no changes from v2 :- 1. [XEN v3 05/12] xen/Arm: GICv3: Fix GICR_{PENDBASER, PROPBASER} emulation on 32-bit host 2. [XEN v3 06/12] xen/Arm: vGICv3: Fix emulation of ICC_SGI1R on AArch32 Changes from - v1 :- 1. Updated in the changelog for each of the patches. v2 :- 1. Dropped "xen/Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32". The reason being aff3 does not exist on arm32. And aff0..2 is the same between arm32, AArch32 and AArch64. 2. Introduce a new patch "xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32". 3. For the new registers introduced, we have defined the arm32 name and then an alias. 4. Use 'AArch32' across all the patches. 5. Dropped the 'R-b' and 'Ack' in "[XEN v3 08/12] xen/Arm: GICv3: Define ICH_AP0R and ICH_AP1R for AArch32". Ayan Kumar Halder (12): xen/Arm: vGICv3: Sysreg emulation is applicable for AArch64 only xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32 xen/Arm: vreg: Support vreg_reg64_* helpers on AArch32 xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32 xen/Arm: GICv3: Fix GICR_{PENDBASER, PROPBASER} emulation on 32-bit host xen/Arm: vGICv3: Fix emulation of ICC_SGI1R on AArch32 xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32 xen/Arm: GICv3: Define ICH_AP0R and ICH_AP1R for AArch32 xen/Arm: GICv3: Define remaining GIC registers for AArch32 xen/Arm: GICv3: Use ULL instead of UL for 64bits xen/Arm: GICv3: Define macros to read/write 64 bit xen/Arm: GICv3: Enable GICv3 for AArch32 SUPPORT.md | 7 + xen/arch/arm/Kconfig | 5 +- xen/arch/arm/gic-v3.c | 159 +++++++++++++---------- xen/arch/arm/include/asm/arm32/io.h | 9 ++ xen/arch/arm/include/asm/arm32/sysregs.h | 19 +++ xen/arch/arm/include/asm/arm64/sysregs.h | 4 + xen/arch/arm/include/asm/cpregs.h | 135 +++++++++++++++++++ xen/arch/arm/include/asm/cpufeature.h | 1 + xen/arch/arm/include/asm/gic_v3_defs.h | 24 ++-- xen/arch/arm/include/asm/vreg.h | 86 +++--------- xen/arch/arm/vgic-v3.c | 18 ++- 11 files changed, 312 insertions(+), 155 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:17:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:17:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442566.696849 (Exim 4.92) (envelope-from ) id 1otUr0-0006zu-Ap; Fri, 11 Nov 2022 14:17:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442566.696849; Fri, 11 Nov 2022 14:17:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUr0-0006zn-6N; Fri, 11 Nov 2022 14:17:58 +0000 Received: by outflank-mailman (input) for mailman id 442566; Fri, 11 Nov 2022 14:17:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUqz-0006iO-24 for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:17:57 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2057.outbound.protection.outlook.com [40.107.102.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a280a751-61cb-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 15:17:56 +0100 (CET) Received: from BN9PR03CA0598.namprd03.prod.outlook.com (2603:10b6:408:10d::33) by IA1PR12MB6044.namprd12.prod.outlook.com (2603:10b6:208:3d4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 14:17:52 +0000 Received: from BN8NAM11FT057.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10d:cafe::ec) by BN9PR03CA0598.outlook.office365.com (2603:10b6:408:10d::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Fri, 11 Nov 2022 14:17:52 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT057.mail.protection.outlook.com (10.13.177.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 14:17:52 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:17:51 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 11 Nov 2022 08:17:50 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a280a751-61cb-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HrkJpRu+NyjLPEmr87NhX3otYxqvPQb7F/ZAg0Jspkc2ZIIB+sDuDL46dmJp6KTP1R92//FEssHF0pYROuUAKv40tZzWbYFWvr2fHDWVo1YhGPq9xYFvIM4VpqIN2UyA1roZ+gn5NMborj1GX0rcZH/FQa1NsAG0cRyfLQu9//DiwV91sKB3zCNNMgUh2gMkOgHPTm3za/mmpmXLJCF76d9yc7V/5Hsuq22t4rn0azbWMEivMyJmKO2FWqRlpxVgvqs1/ZyrM+fV/z9Vtqo0dLTEfssxUDnBVdhiO/XmVnt5L1fEFx+t+E1s9U4V9S1LMwkSwujCeT0rAI7Qes7U4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BYhqWJyHaM087JXotqIXKs3EOmyezlCfEHykNXyKFgM=; b=HMr3Y/mIGg+M7X3FmcpDrVekJhQOlJ9rjIjPjpt1zn8H6cBHxr2sss2L+dqHGGlqN0hYgM/jJg1jdilJazqurwDGn4tHtmfotK7hJJhXVFBLe7bW/YQVf5mRJN3aerSKkRNPL3EKEdR/rAbVGQWxn+xGe8CVuKOgQfEU91AjnajOEXZ+v9ANkEnlYqNzsfkN519zA8UVOgxh52aH/rjkTUEjP7YmKbpmKwQb6HJXdXN0EoHYc7YeXgQwi2Ua38E4XbYjykteUparJe7FrayiSCuMtVZd6mKTCjBaYC5Lg/hLd5p8KAjUwVFiHFxJe1kvUyN7lE1G+GCYYtm4sNbnTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BYhqWJyHaM087JXotqIXKs3EOmyezlCfEHykNXyKFgM=; b=HGUgDDBMYzMbWfx+gcvZGOdZSDRcl8wm7vA+8tFulo6K2xmBE3iDevvt5fpCjldsXNL+pBsfp1soJ2xFKB+xpa3iq97OO1eSkKekmPoRiJo87yDlKXhmUV6wNXgJBUtDA4CafoJyCf6/ItDeDuuAASO4rHcEwKqbaNC9DekR1ak= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v3 01/12] xen/Arm: vGICv3: Sysreg emulation is applicable for AArch64 only Date: Fri, 11 Nov 2022 14:17:28 +0000 Message-ID: <20221111141739.2872-2-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221111141739.2872-1-ayan.kumar.halder@amd.com> References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT057:EE_|IA1PR12MB6044:EE_ X-MS-Office365-Filtering-Correlation-Id: 937cc39e-55e3-4c99-3922-08dac3ef851f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +IewGGV8Ju5CHU5Wzj5url6mxu2PKE013VUfmQOVVEB9yl1un9Zvbuh7DW+KK03S3shgEDgkHml1OJZhYUpGfEuVaE8Zgm04MY8T2oKkMRyXe3Z+LQF1Ze1mY0gj/L2Ik+N4/Myk78WyzqOObz9as43HNydkF7Q3x9t09WDYOmsbAdA4mPbXfdUHMYwRlujNyqd/Pkjl34cDaapqWKuoByXQ5ZiWL46vny+ylt++O9uRVYXxj1ol+YjyHDedsY17Jw4tlpRYUjMB9aJIyGH96VK5SVjBwI9RsZsY8PuVimzRU/aQH/i0YHfWluQl+htMs9ublOLZmA8ZZ/NfqdcweN6DfT38ZkWwmpcoULsAAtvTWUDN/ScwkXFMhk5si3GyfcqDSW0cK9k82BL5JbfhGJwzz8s1GVnRon8nt2JF+MggHq4Td24dAT0/TbZ6uGOg5uU5BqC7a3iz3FkahJPGtsd1KdL2xqgmmh33TaxWxgnqruauJDAd3ZYp5NBzGk+Kj2VqqufWTG2fyQVH+tbOjaNWKqhSf8vFMXeKjQKYxCs29eE18d43skrLzkqzTPxikfwqwbPLDW/AqpkwQJZirU7alnbxLOEhxyWsu5MVwaxqCSyPVEi+NjDipPV8TNfNFbrhkrbrp6SbX64uBlW3GBQlEd0J46DC4Yq3qr4azO84uuIWbwhhVHIW0rwfSJlBQuDSfbGVQS4R0phY6iT68EctUKzpAUIQ48dMHTWywCooEovb4YQT1B4adjLBXjfNfJUT2XNKxY4FiUDkdHYVv5ThJJtX5L9YZosEtoYe5gA5bdA6P2IJwHiCAsSNP1xQ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(396003)(346002)(451199015)(46966006)(40470700004)(36840700001)(81166007)(356005)(316002)(6916009)(82740400003)(54906003)(478600001)(8936002)(83380400001)(2616005)(36860700001)(36756003)(47076005)(26005)(6666004)(40480700001)(103116003)(70586007)(426003)(41300700001)(2906002)(70206006)(86362001)(82310400005)(8676002)(1076003)(4326008)(186003)(5660300002)(40460700003)(336012)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:17:52.3893 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 937cc39e-55e3-4c99-3922-08dac3ef851f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT057.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6044 Sysreg emulation is 64-bit specific, so guard the calls to vgic_v3_emulate_sysreg() as well as the function itself with "#ifdef CONFIG_ARM_64". Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - 1. Updated the commit message. v2 - 1. Updated the commit message (removed the reference to Arm ARM as it is not required). xen/arch/arm/vgic-v3.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index 015446be17..3f4509dcd3 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -1519,6 +1519,7 @@ static bool vgic_v3_emulate_sgi1r(struct cpu_user_regs *regs, uint64_t *r, } } +#ifdef CONFIG_ARM_64 static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr) { struct hsr_sysreg sysreg = hsr.sysreg; @@ -1539,6 +1540,7 @@ static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr) return false; } } +#endif static bool vgic_v3_emulate_cp64(struct cpu_user_regs *regs, union hsr hsr) { @@ -1562,8 +1564,10 @@ static bool vgic_v3_emulate_reg(struct cpu_user_regs *regs, union hsr hsr) { switch (hsr.ec) { +#ifdef CONFIG_ARM_64 case HSR_EC_SYSREG: return vgic_v3_emulate_sysreg(regs, hsr); +#endif case HSR_EC_CP15_64: return vgic_v3_emulate_cp64(regs, hsr); default: -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:18:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:18:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442567.696860 (Exim 4.92) (envelope-from ) id 1otUr8-0007LW-IW; Fri, 11 Nov 2022 14:18:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442567.696860; Fri, 11 Nov 2022 14:18:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUr8-0007LN-Ez; Fri, 11 Nov 2022 14:18:06 +0000 Received: by outflank-mailman (input) for mailman id 442567; Fri, 11 Nov 2022 14:18:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUr6-0006iO-FL for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:18:04 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2055.outbound.protection.outlook.com [40.107.92.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a725e825-61cb-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 15:18:03 +0100 (CET) Received: from BN0PR04CA0206.namprd04.prod.outlook.com (2603:10b6:408:e9::31) by DM4PR12MB7695.namprd12.prod.outlook.com (2603:10b6:8:101::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 14:18:00 +0000 Received: from BN8NAM11FT108.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e9:cafe::79) by BN0PR04CA0206.outlook.office365.com (2603:10b6:408:e9::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Fri, 11 Nov 2022 14:18:00 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT108.mail.protection.outlook.com (10.13.176.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 14:18:00 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:17:56 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 11 Nov 2022 08:17:55 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a725e825-61cb-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CO5fa6Rz3XtdJioO9GQMDMVkMdHj/oQZEjmU43fCOn4bIIJj6jV1YyeITMp1/LeuXtFGtXggfd5LAN1o/mEkMPonKNYhLj6I6y5aoD6aTG9KyRrI0EXebe3xExmcVyNMYiQQUnBRQ8S+utXzQqH6CMDOHwx2iDjBqlIzfViFPZJaDubcQ3oY06l4t97FmHkcWfZ0YVhLOANV93iYUpONK9MJnn7j5uFLoYPKG7ubVH2mUMqDE9pjM4R+Si5598fadyERCWNDVfqvWLNxbo1hfB5rsH6GMTTvl8knjIeegQDd5+RHnJm6ADRMhztfA/RqVsETAMMuMOEuY2fDiyq3XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YxCh5IDTqC9PMIY7uCyOxr731NE746qnqsoe38S3DXU=; b=S8ZT9f6UWWJpYHQf6Ci6DaK71ffCOKikPsIwklX5GS7xixo4uMmgRXZumsz2UmaIWNPFkrKLswjL+0f/YSHaE3VWEec0mppKoxUIulShpOL/wycC5prR0C28eoY5mgSQtn0ONcYnS/R9XxpPoa2lgKBqI/Vp3NiOSeZqpj1G3wt4t3CcD0LCnSezpmVU8rwefh85DaDxxfejxBgx6VLJpeebWxptqkCqU3uA91JVTusLpQsqde4pVWcPcFqYVFmirH1RyQL4CRMqjp5GiCSez9Fma3uzUCCaqD1uFaBLoIPQoFXXT1seu3T8ELDQ74AT1P97TMIr7EUByThSPjemJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YxCh5IDTqC9PMIY7uCyOxr731NE746qnqsoe38S3DXU=; b=KZ/uuSWDxtSMkpPtlBDQoIuYyBGjZF4hskfOaUFY4fU+5ptqNiCpPSi0B/Uh4tEzer+PKQKJULksM79Z7AvObudMYEElCFUi1PE7BYVw5cEU33+TBipTvgxM2EXRNq3rfDwPJdfd+nxthJ4MbxYmwS17NGYSJqLFeem6CtYjO8M= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v3 02/12] xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32 Date: Fri, 11 Nov 2022 14:17:29 +0000 Message-ID: <20221111141739.2872-3-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221111141739.2872-1-ayan.kumar.halder@amd.com> References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT108:EE_|DM4PR12MB7695:EE_ X-MS-Office365-Filtering-Correlation-Id: a50614c5-522b-4cc4-0801-08dac3ef89e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H4ZYvbFSXLsI7le10NxAY/UAQ8CTwKME+uDCkhArhc9RNc0Tn+cPBYwlHhQGaBjsU/Z/y0b+EpPaNWm1wcwJfPo7nkp3fRw6UuwjDn4ZXwq1uzLqt6jRY1h8k+MBdFhRNQq/6u+lu6HlqypfHNeEHcHZ3yMmXNEKA1O4ilf+XSFuRIdHtxxJ7XZ+2nno2SznoCX/8eiqf7DQFJq6AU+Gems2pD0XCO+/NWMGk+ynu0cV5TUQdgQWpGO9bokiDOZaUojKMqwNwVj9QYXck0/zLTZqYGqJNNFzxHEACFqC4LzN4kpB50yoH7XvwXePNygdI+3fLUJ5ZZf+sHIk24YNVxipxKBo5oG9rApzFcoOw0JFXe1j8YMcXuZUsb/v8A3YmPJDGGCjm78Hv16B0ZjHvhEXrZRTRLG+s434IpB30A59wVWMXU0Ufxy/1rW46o4DWxUjvBqFiD7gRAje7BxvOpOaAvEXNb1M1uJ/EfeVUt03Q8NcDjS+DZW0FLbgl4N5RmRGWzu8ri88bQXYTRt1xVCQQJjszYCjBZ0SCYrHVIiVkbUz76yy14rRBFcu1pfEEVmUwccos+hPnxiFhbPkPG4EZe4nd8j1CCJuu3Q3qt29Cgr3kZmhHQrqq7lMB4dJ8LmqmRlYzVdlVd/keiOmbwVr32tlz10XaFBHwsbgLEGvl4tQR+JjDusLmEWa2nwSIwuQG9qSfos5OVY7X+i9rTVCBvho+K8C/RWxSlGGwQeVJq4DlXtu/4+e34TgQUv90Gl2mqbi2mvykpko+s6TcN/A1j7jrNDt0Bqchg1GAYYiroO4kmVLvvSPaJY3Sr5A X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(83380400001)(36860700001)(86362001)(82740400003)(356005)(5660300002)(81166007)(2906002)(8676002)(4326008)(41300700001)(8936002)(82310400005)(40480700001)(70586007)(47076005)(26005)(6666004)(426003)(336012)(316002)(2616005)(1076003)(186003)(54906003)(6916009)(40460700003)(478600001)(70206006)(36756003)(103116003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:18:00.3638 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a50614c5-522b-4cc4-0801-08dac3ef89e0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT108.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7695 Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169 Affinity level 3 is not present in AArch32. Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106, Affinity level 3 is not present in Armv7 (ie arm32). Thus, any access to affinity level 3 needs to be guarded within "ifdef CONFIG_ARM_64". Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - NA (as it is a new patch) v2 - NA (as it is a new patch) xen/arch/arm/gic-v3.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 018fa0dfa0..64a76307dd 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -527,7 +527,10 @@ static void gicv3_set_pending_state(struct irq_desc *irqd, bool pending) static inline uint64_t gicv3_mpidr_to_affinity(int cpu) { uint64_t mpidr = cpu_logical_map(cpu); - return (MPIDR_AFFINITY_LEVEL(mpidr, 3) << 32 | + return ( +#ifdef CONFIG_ARM_64 + MPIDR_AFFINITY_LEVEL(mpidr, 3) << 32 | +#endif MPIDR_AFFINITY_LEVEL(mpidr, 2) << 16 | MPIDR_AFFINITY_LEVEL(mpidr, 1) << 8 | MPIDR_AFFINITY_LEVEL(mpidr, 0)); @@ -720,7 +723,10 @@ static int __init gicv3_populate_rdist(void) * Convert affinity to a 32bit value that can be matched to GICR_TYPER * bits [63:32] */ - aff = (MPIDR_AFFINITY_LEVEL(mpidr, 3) << 24 | + aff = ( +#ifdef CONFIG_ARM_64 + MPIDR_AFFINITY_LEVEL(mpidr, 3) << 24 | +#endif MPIDR_AFFINITY_LEVEL(mpidr, 2) << 16 | MPIDR_AFFINITY_LEVEL(mpidr, 1) << 8 | MPIDR_AFFINITY_LEVEL(mpidr, 0)); @@ -972,7 +978,10 @@ static void gicv3_send_sgi_list(enum gic_sgi sgi, const cpumask_t *cpumask) * Prepare affinity path of the cluster for which SGI is generated * along with SGI number */ - val = (MPIDR_AFFINITY_LEVEL(cluster_id, 3) << 48 | + val = ( +#ifdef CONFIG_ARM_64 + MPIDR_AFFINITY_LEVEL(cluster_id, 3) << 48 | +#endif MPIDR_AFFINITY_LEVEL(cluster_id, 2) << 32 | sgi << 24 | MPIDR_AFFINITY_LEVEL(cluster_id, 1) << 16 | -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:18:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:18:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442569.696871 (Exim 4.92) (envelope-from ) id 1otUrE-0007nw-TU; Fri, 11 Nov 2022 14:18:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442569.696871; Fri, 11 Nov 2022 14:18:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrE-0007ni-QD; Fri, 11 Nov 2022 14:18:12 +0000 Received: by outflank-mailman (input) for mailman id 442569; Fri, 11 Nov 2022 14:18:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrC-0006iO-AT for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:18:10 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20601.outbound.protection.outlook.com [2a01:111:f400:fe59::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9e8a8f8-61cb-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 15:18:08 +0100 (CET) Received: from DS7PR03CA0097.namprd03.prod.outlook.com (2603:10b6:5:3b7::12) by LV2PR12MB5750.namprd12.prod.outlook.com (2603:10b6:408:17e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 11 Nov 2022 14:18:04 +0000 Received: from DM6NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b7:cafe::8f) by DS7PR03CA0097.outlook.office365.com (2603:10b6:5:3b7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Fri, 11 Nov 2022 14:18:03 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT025.mail.protection.outlook.com (10.13.172.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 14:18:03 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:18:02 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 06:18:02 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 11 Nov 2022 08:18:01 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9e8a8f8-61cb-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HNKDI362Avd+lC5c3Zb/psgtuOKmblKmUAoa+P4Ybu30d7slGsM2Vh08ApNmw7bnT4HhkqFDDzWdEBhPC/Pxrq+AG/3WLIRkGwAaFgwIFuYA3NnKq71dI67xDF3X7sOXbvJxlJ6mcSi29xjImCFtLkPlNAhCsBfDqV51UVFPt+RPGWfRLcmbnTwpF5zC1dz5DrnbHi6B6ZpsN9zs+jsMDF/U49muvw/giEZIG7BvTBLXpApu+V2eMmnnylkchYbwkVBOVckykhe27DnkXf73J8rMHeCgLdmSisOTUTDW0wnzorgQLdXFOSSqslqcJaczQBs0Omet79/iQgPeCMSg/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7SAGGElGou5wa0MfGAJqr0ibpG1sOdIuxKIEF2iwXxM=; b=ZAHW+r7lS+N+J4B8dPqag1Dk2UMW+xDOof/Ei8Au5z7ZfuIgN00xI1nwF4hc+tiGIeED5mfUgS2MTkLXrbGEqT8b8hnYti9brr2fVx+I9XhUqKUuBAJc/IDWdNQniFpmnl0ZdCsmxxz3IpbbmEyo/Y6s9wM3J1SLIPojC4w2SrNMkr03b6upBeKKuqFhT/V6XAj4FOVcU/aGX5U9flLlO4govqpatxiFsV1qSfs+1mGXLNJe1a2OT8uuXDzE23hva8RT5Z3DoOEQOXTI5TiDg5GXXkEBq2h975VrPvXmKAf/6CQ30QTCxRhsp11aSrYyHD9cljbu5e9VIcD8hwG8Hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7SAGGElGou5wa0MfGAJqr0ibpG1sOdIuxKIEF2iwXxM=; b=2ukgacSQX7mgIoNq5PeJDFOrrFQecBDRZ7Smy3Bb9FPyi7RcksXG3875lC0FIcGT8XsTLH6v8aFpyeVFFBAF5WFUZZUyl59fIaOVIo0KUvshHwBofU4Sk73/Ytx8w/qRrK26eWzWEeYC5XYeIhEC6s95zFpCVsxNTIMtE0vx4D4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v3 03/12] xen/Arm: vreg: Support vreg_reg64_* helpers on AArch32 Date: Fri, 11 Nov 2022 14:17:30 +0000 Message-ID: <20221111141739.2872-4-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221111141739.2872-1-ayan.kumar.halder@amd.com> References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT025:EE_|LV2PR12MB5750:EE_ X-MS-Office365-Filtering-Correlation-Id: 43cfbe62-499d-441f-5b40-08dac3ef8bcf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LYU+lVrkeNW4TlYNSjmLHWbykoKFJmIPeSrOoj+GB2tc4iLJWGc0yFAJW+aHKxvYC+3un8XlDSCBHLwcnlbiq5r45bmgt0SpME2/PBZVLQVvVW8KobIYFUza6RVdVAyXWwFGx2G/1tJbDSPlzIUqbBiP5rq0Bw/PWo/IqSaPzA78gmu481Z09OqorY648gi0H9dQhU2SVYbM7g0OBE/2KAXAKLoE3ncVmfw9aQoV/Trck772t1QZoFPqj7p6TChaKoaeMPVsRGZdP6SZCF501o4sdswEoNmD2iXgnys/HWhnP3HGJL8EazaoiX6op0luX1gPfFJPtrzQBU4ewWtBSGQLEM49Ts4DEvO7zG86hHM5hCWtIPaV5G3pdycEBJywaHO8TcKrlmB6eHbWvJ/w4PJ6tdcoSV98s0JF+0SK48KeTNZEJnqHhMQDS7oAhGEqFrJU6KiCtlVJtUC/oXSIEg9qzY8p4zlDuGXBE1oUaHr6p+kjKuPYYno2Wyq8+1v4Oxw837FmlrgMIh9YLpOjDmdKHeW9J9tt5vP03McXQzuL6m+iYQwfBVKWazMGmBmrIvomWCXntgae6LYuiPhQHcIEc+ClJOW/VRi/FFpqMD0hcik9vUBkpQtym3ziGV6dDLkVZhev0lfKbyWIGZvNOxDsrqr7eK2EjazNDSBE5YzvOw/jxq0n77aopI3z6PC9RlO0konefKBEn5e4ATo21oWTCPo4TEEiUABO3O5+EpKumiWk6m1aFG6ic/V5esHUpzsq9529vrn+XfNNXp6G0PUCWdogU2ct4p/v6is8RdWyo4huxbEub+nwDGhQuYrR X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(376002)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(86362001)(2906002)(82740400003)(40480700001)(6666004)(36756003)(356005)(81166007)(103116003)(186003)(478600001)(83380400001)(26005)(41300700001)(316002)(54906003)(8676002)(36860700001)(6916009)(4326008)(2616005)(70206006)(40460700003)(70586007)(5660300002)(1076003)(336012)(426003)(8936002)(47076005)(82310400005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:18:03.5787 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 43cfbe62-499d-441f-5b40-08dac3ef8bcf X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5750 In some situations (e.g. GICR_TYPER), the hypervior may need to emulate 64bit registers in AArch32 mode. In such situations, the hypervisor may need to read/modify the lower or upper 32 bits of the 64 bit register. In AArch32, 'unsigned long' is 32 bits. Thus, we cannot use it for 64 bit registers. While we could replace 'unsigned long' by 'uint64_t', it is not entirely clear whether a 32-bit compiler would not allocate register for the upper 32-bit. Therefore fold vreg_reg_* helper in the size specific one and use the appropriate type based on the size requested. Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - 1. Remove vreg_reg_extract(), vreg_reg_update(), vreg_reg_setbits() and vreg_reg_clearbits(). Moved the implementation to vreg_reg##sz##_*. 'mask' and 'val' is now using uint##sz##_t. v2 - 1. Use 'unsigned int' for 'shift' variable. 2. Updated the commit message. xen/arch/arm/include/asm/vreg.h | 86 ++++++++------------------------- 1 file changed, 19 insertions(+), 67 deletions(-) diff --git a/xen/arch/arm/include/asm/vreg.h b/xen/arch/arm/include/asm/vreg.h index f26a70d024..d92450017b 100644 --- a/xen/arch/arm/include/asm/vreg.h +++ b/xen/arch/arm/include/asm/vreg.h @@ -89,106 +89,58 @@ static inline bool vreg_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr * The check on the size supported by the register has to be done by * the caller of vreg_regN_*. * - * vreg_reg_* should never be called directly. Instead use the vreg_regN_* - * according to size of the emulated register - * * Note that the alignment fault will always be taken in the guest * (see B3.12.7 DDI0406.b). */ -static inline register_t vreg_reg_extract(unsigned long reg, - unsigned int offset, - enum dabt_size size) -{ - reg >>= 8 * offset; - reg &= VREG_REG_MASK(size); - - return reg; -} - -static inline void vreg_reg_update(unsigned long *reg, register_t val, - unsigned int offset, - enum dabt_size size) -{ - unsigned long mask = VREG_REG_MASK(size); - int shift = offset * 8; - - *reg &= ~(mask << shift); - *reg |= ((unsigned long)val & mask) << shift; -} - -static inline void vreg_reg_setbits(unsigned long *reg, register_t bits, - unsigned int offset, - enum dabt_size size) -{ - unsigned long mask = VREG_REG_MASK(size); - int shift = offset * 8; - - *reg |= ((unsigned long)bits & mask) << shift; -} - -static inline void vreg_reg_clearbits(unsigned long *reg, register_t bits, - unsigned int offset, - enum dabt_size size) -{ - unsigned long mask = VREG_REG_MASK(size); - int shift = offset * 8; - - *reg &= ~(((unsigned long)bits & mask) << shift); -} /* N-bit register helpers */ #define VREG_REG_HELPERS(sz, offmask) \ static inline register_t vreg_reg##sz##_extract(uint##sz##_t reg, \ const mmio_info_t *info)\ { \ - return vreg_reg_extract(reg, info->gpa & (offmask), \ - info->dabt.size); \ + unsigned int offset = info->gpa & (offmask); \ + \ + reg >>= 8 * offset; \ + reg &= VREG_REG_MASK(info->dabt.size); \ + \ + return reg; \ } \ \ static inline void vreg_reg##sz##_update(uint##sz##_t *reg, \ register_t val, \ const mmio_info_t *info) \ { \ - unsigned long tmp = *reg; \ + unsigned int offset = info->gpa & (offmask); \ + uint##sz##_t mask = VREG_REG_MASK(info->dabt.size); \ + unsigned int shift = offset * 8; \ \ - vreg_reg_update(&tmp, val, info->gpa & (offmask), \ - info->dabt.size); \ - \ - *reg = tmp; \ + *reg &= ~(mask << shift); \ + *reg |= ((uint##sz##_t)val & mask) << shift; \ } \ \ static inline void vreg_reg##sz##_setbits(uint##sz##_t *reg, \ register_t bits, \ const mmio_info_t *info) \ { \ - unsigned long tmp = *reg; \ - \ - vreg_reg_setbits(&tmp, bits, info->gpa & (offmask), \ - info->dabt.size); \ + unsigned int offset = info->gpa & (offmask); \ + uint##sz##_t mask = VREG_REG_MASK(info->dabt.size); \ + unsigned int shift = offset * 8; \ \ - *reg = tmp; \ + *reg |= ((uint##sz##_t)bits & mask) << shift; \ } \ \ static inline void vreg_reg##sz##_clearbits(uint##sz##_t *reg, \ register_t bits, \ const mmio_info_t *info) \ { \ - unsigned long tmp = *reg; \ - \ - vreg_reg_clearbits(&tmp, bits, info->gpa & (offmask), \ - info->dabt.size); \ + unsigned int offset = info->gpa & (offmask); \ + uint##sz##_t mask = VREG_REG_MASK(info->dabt.size); \ + unsigned int shift = offset * 8; \ \ - *reg = tmp; \ + *reg &= ~(((uint##sz##_t)bits & mask) << shift); \ } -/* - * 64 bits registers are only supported on platform with 64-bit long. - * This is also allow us to optimize the 32 bit case by using - * unsigned long rather than uint64_t - */ -#if BITS_PER_LONG == 64 VREG_REG_HELPERS(64, 0x7); -#endif VREG_REG_HELPERS(32, 0x3); #undef VREG_REG_HELPERS -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:18:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:18:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442570.696882 (Exim 4.92) (envelope-from ) id 1otUrI-0008AF-BS; Fri, 11 Nov 2022 14:18:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442570.696882; Fri, 11 Nov 2022 14:18:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrI-0008A6-7n; Fri, 11 Nov 2022 14:18:16 +0000 Received: by outflank-mailman (input) for mailman id 442570; Fri, 11 Nov 2022 14:18:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrG-00085I-Kw for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:18:14 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2070.outbound.protection.outlook.com [40.107.220.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ac856a98-61cb-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 15:18:13 +0100 (CET) Received: from BN0PR04CA0040.namprd04.prod.outlook.com (2603:10b6:408:e8::15) by MN0PR12MB5786.namprd12.prod.outlook.com (2603:10b6:208:375::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14; Fri, 11 Nov 2022 14:18:09 +0000 Received: from BN8NAM11FT115.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e8:cafe::15) by BN0PR04CA0040.outlook.office365.com (2603:10b6:408:e8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Fri, 11 Nov 2022 14:18:09 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT115.mail.protection.outlook.com (10.13.177.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 14:18:08 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:18:08 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 11 Nov 2022 08:18:06 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac856a98-61cb-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CSivghVVgBOla/cD8KPmGcV4jcpghTzlsoC6EhzTl4Eoc12qeWDaE8JckyczhbCB78v07fSK0joMCnGKUvsFwSjopaWLiVNeuBRV7rUsdgN6e4C1rIMCh4BK/JtqNZz25mNVGReUOnpGBhxVz6Fw1hzBiyMHRMDwKC+iL6hFUPfoQ5JqmKE5l9DFRRD0sHeObI2ycdJoAzVFg//GwvT6d9sQGQx5AN4hq/xX5mZDLLGTawr+rPCDSiDTpLsq5JvO2aEOvBtyt2zZU2ehyUnyDydp+/YuY8OvSdaBcnL/v1KEMumoqe091UDbrGZ7UBYsewjaNSySOv2SC8gLI002WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9BuV+HyjL7BNV9FxH0s8ANwm+9yeR0vLmx92BP5Ij4I=; b=Rd6pgOsmmhYro7CDAGmt1/m6Tu0Omz/N5GNljZ7FUxV6+SyB4mTTq2bmwpjXRZZ2V9uG+rKXES/KFz/7buRauMya5QSr1vopR6Sa7W7Qq7PprF/KU16ihKHDJ/xuUudb6ew0FAq3XVCycssfiSgAX72UXdT7lepNYWrvQtjSLTPE7rI6+0BIlp1stMdhI36JkvIJsZci0xOQ+I5F+JrwP6MhTmnGhqTq2LpDxcUELiA1lK4j+QCw+7h+2IithlODdhvKQ014DLeQw2mb0v7xdYZe7ZNtMos3re1QNojjpZJqu4Il0ERK4fGHEShxLAxnEWvbZs5ffePjr5LOhqbWtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9BuV+HyjL7BNV9FxH0s8ANwm+9yeR0vLmx92BP5Ij4I=; b=TZ1QPMQs3zflUa0jo+j5IfyGD0zohlulmbtVqgZK4OxQESQdBujEyXWNd32I0yPhbpQeSYvoyLL207RAMbbL+4EfoBeqL01lozvjWN1/j0/Q+b4/G9Y4fgiz8ChXdfk1TV6wZBS2oug4oUTUMx2zX1HKiMQdzH+y3G4M0H96Pag= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v3 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32 Date: Fri, 11 Nov 2022 14:17:31 +0000 Message-ID: <20221111141739.2872-5-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221111141739.2872-1-ayan.kumar.halder@amd.com> References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT115:EE_|MN0PR12MB5786:EE_ X-MS-Office365-Filtering-Correlation-Id: f1ba89d3-1d1e-40ee-1859-08dac3ef8ee0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AuyaT3j/1xFhz7vB7vs5DkIYHp33jBoXTvc6dQURFB+CCecrR+aYkHXJeY8QsBNesMTmf4mc8uyiiN1HzkR+4O2VP4FkBJZMb9PoOSU++d7j8j3L841mPJ+wciZVbbuHUEA7QlIpzOrX1w8X8sDZzTsWDgVJLmQeMM4J6K9ewn4rodPgzz0l4xs91pnUwpHw8prkS/HaQS6V/QBgcUiYP0mS+G0ai/XYKvFgJIjRRB208t8Q7HSxl425HqBw1srv284W/JnUV0mxGJc24qpSV45LuAgIVYgnbSVLEBh34WNss1zGbrFYlZN+IMqT5y2bgRg//pROYtKbgCFttvFO7k3bkPcDc66pe46B/SAcoU4tHvQ7e5ZO0IISPXwJKSjFk5Y0VbtpV7SJe47bgAJQIzw3xKl3Ah12rglamka/intr47zllQ/CUTbPuBNZJGowDxE+t+GAL1xyB2KErB7yVObZ5mt5ogo3VYxMOmLaH3fv5nUBThzRCDa0SFF8TO6sAJZpCPCzFJ6drSBMya6yLU+2LZPOhAUDuFVZI0YDvHhL9ZfeArOQsuB0Ko0Ai/CV7dZbBS5kd4Z2K8isKQHTv3dKQnRidmG9G1d3C2vlVAANqQ1iuz5EaVk4+aUrBTSH+pPW9axnVWTV7ex3DB/MoPgFIhlyZpbcOoozmKbSmriH1wDm8REjfvAoEzNO3sUMfxkpsPnkKl4/zS345WAruqweYDC2PEIfrKMWSKsnaqVeqLjbQG8+ZzIyFRHZwxXL5ByunpGPuG0TZ5mOnEPQFARYuEP1ffVWX97ef1dXr0+d4Xi+m/AcfYNp41Anoiey X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(376002)(346002)(451199015)(46966006)(36840700001)(40470700004)(36756003)(103116003)(2906002)(4326008)(8936002)(82740400003)(40460700003)(36860700001)(86362001)(83380400001)(356005)(81166007)(70206006)(54906003)(316002)(6916009)(336012)(186003)(2616005)(1076003)(426003)(47076005)(478600001)(40480700001)(8676002)(82310400005)(70586007)(41300700001)(5660300002)(26005)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:18:08.7528 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f1ba89d3-1d1e-40ee-1859-08dac3ef8ee0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT115.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5786 Refer ARM DDI 0487I.a ID081822, G8-9650, G8.2.113 Aff3 does not exist on AArch32. Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106 Aff3 does not exist on Armv7 (ie arm32). Thus, access to aff3 have been contained within "#ifdef CONFIG_ARM_64". Also, v->arch.vmpidr is a 32 bit register on AArch32. So, we have copied it to 'uint64_t vmpidr' to perform the shifts. Signed-off-by: Ayan Kumar Halder --- Changes from :- v1 - Assigned v->arch.vmpidr to "uint64_t vmpdir". Then, we can use MPIDR_AFFINITY_LEVEL macros to extract the affinity value. v2 - 1. "MPIDR_AFFINITY_LEVEL(vmpidr, 3)" is contained within "#ifdef CONFIG_ARM_64". 2. Updated commit message. xen/arch/arm/vgic-v3.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index 3f4509dcd3..a7a935ff57 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -191,12 +191,16 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info, case VREG64(GICR_TYPER): { uint64_t typer, aff; + uint64_t vmpidr = v->arch.vmpidr; if ( !vgic_reg64_check_access(dabt) ) goto bad_width; - aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 | - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 | - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 | - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32); + aff = ( +#ifdef CONFIG_ARM_64 + MPIDR_AFFINITY_LEVEL(vmpidr, 3) << 56 | +#endif + MPIDR_AFFINITY_LEVEL(vmpidr, 2) << 48 | + MPIDR_AFFINITY_LEVEL(vmpidr, 1) << 40 | + MPIDR_AFFINITY_LEVEL(vmpidr, 0) << 32); typer = aff; /* We use the VCPU ID as the redistributor ID in bits[23:8] */ typer |= v->vcpu_id << GICR_TYPER_PROC_NUM_SHIFT; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:18:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:18:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442572.696893 (Exim 4.92) (envelope-from ) id 1otUrO-0000Bu-K7; Fri, 11 Nov 2022 14:18:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442572.696893; Fri, 11 Nov 2022 14:18:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrO-0000Bg-FM; Fri, 11 Nov 2022 14:18:22 +0000 Received: by outflank-mailman (input) for mailman id 442572; Fri, 11 Nov 2022 14:18:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrM-00085I-Pj for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:18:20 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2060.outbound.protection.outlook.com [40.107.223.60]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b08522b0-61cb-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 15:18:19 +0100 (CET) Received: from BN9PR03CA0379.namprd03.prod.outlook.com (2603:10b6:408:f7::24) by PH7PR12MB6540.namprd12.prod.outlook.com (2603:10b6:510:213::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Fri, 11 Nov 2022 14:18:14 +0000 Received: from BN8NAM11FT011.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f7:cafe::bc) by BN9PR03CA0379.outlook.office365.com (2603:10b6:408:f7::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Fri, 11 Nov 2022 14:18:14 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT011.mail.protection.outlook.com (10.13.176.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 14:18:14 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:18:13 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 06:18:12 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 11 Nov 2022 08:18:11 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b08522b0-61cb-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S6cheBqbLMxEYuEXVGvabVtAQVqbUE4tmBDb9Ui+8mXe72bYdF+VxDpmcMVPtWv9Hfn70BfU8F4DLoe/ylDgHCUrJTLBK+XzrY8Vq8AapAX+S68DDEb8ZxP0VNs4JP/iuCIkR9Wx+ykBFB83Uq11Dqv1v2rlTG0H9JhgbTDfkkr55Chdz7cPqlHNGarXP/VSFfKgfGL2NZygaCF4Vn9IZllK7VXhRMHI3UX2GQDWt9h+Dx0Atz7NQWPVOtOD0aCJHQfKHW6FUOtqufmx9lBuSaV9+Ud6Ric7zET5OsxZdrrMcdafYTsncSoi534yiJoGOj8lmpJWpZRyEmm26wU0Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5OPx6FJDxVrIqVmDw4a5rdKvuGJuCxKW/GJwYRzDB0Q=; b=mgQ/L+bt2iZqha1ttrcKZW4QXnBUgHjzBBBHVlfAfKqTyS88XfvGajHhm577syO3sfNlxE8bRAEVAxve1iLNVsbiuHAzfjdGZ4hc6pV35XaZ7/QTggoEeDh6wU0PoJxmWoxgvB+oxpQpih7beAlii4OSz6X94wzvg62/ohw8sAyGUJeOu+qu2eCTu/3e7PEa32kG2ES9QM3qWEPcmmChCmqubWw3gS5XYb87wNQvLlKP35+PieVsD9sgD/Yn/cAsxrcSbr+w+O9vBmy5uMwFn3zviWxV3l7T/gNcmq4xk9ThrnPeMRSTqI55NALZcSRiG+lcRohNpt0LvfN6gEr+OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5OPx6FJDxVrIqVmDw4a5rdKvuGJuCxKW/GJwYRzDB0Q=; b=smSyzRbkL3mpn+WU9nhNPpx93hfFSoKgVHxUf22L3uGKHYztvDDWEr4lmsHDDkqkIuiyzRY2ACQQbAl3bgN2b8mm98xZr7irXte1JqyPZNAh4+Skx1dan6R+pXSMeTmruItAuxdUXU0SVKldvCiu4drpeoGj1U5gRPXCShsg79M= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v3 05/12] xen/Arm: GICv3: Fix GICR_{PENDBASER, PROPBASER} emulation on 32-bit host Date: Fri, 11 Nov 2022 14:17:32 +0000 Message-ID: <20221111141739.2872-6-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221111141739.2872-1-ayan.kumar.halder@amd.com> References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT011:EE_|PH7PR12MB6540:EE_ X-MS-Office365-Filtering-Correlation-Id: aab0ecc1-79aa-4d9c-1e31-08dac3ef9223 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w+ZTliEPG2YElirV9Voc9p+RkKXR/sm8Riqk+UsdGNzTGSqk6C37IXyNL3e3028VG2+joh4DQZg0SfhNibS493NWdPXzREQzEwFOWa5dXAvUqZOAAdku/v79e4tJkZlPHMbep86e9LzK/oZ/A9t/E4v0V6OdM/lFm5fhpW8j49gI2VpcfaEWVk01IH7cjr0ug0FVf2qKbCTuLglcr87JtDZYo+CgZRx7ZZRHDGFnSVlkdvZgaD55SBT1ISCeZbJQIW95FrBhbohs1HYGZvQc6myGSTf0KRzc55wVYAEsQ9KTX+3pZzoW7/032X8qI52RtgD4eEUzJXLKLmzt7iop/cnkJxquAi8O2mk4GpRggNKreCU2Q5GLonX1YnihifvSijLjJyp9XG80G9Y1oGBXg/irwtchxBzuDQ4B2IPeizqNgR3U5vFyJPeZkkzhgS+iw4QLGOXWEIJYJVk+KvBNeRp0MA+9n/8S8GrNtASV9X03zebufOipyBRkN/YRlf0NLYSKDgFnvKeYR0TNScUVAkeZgj9YtWndHKihoMIk+20Gsey+d5lQyTkngpnDFtxTz9EAHybNKcx/6g3fI+kz2EOFO9VDrLC6959rnMtjBLzTYupMWM9g+Tmle+WXW0C9AcLLe8ydzJoqsSsHRSXcjJEWUS6Jzq7CXhIiN69b6qNh36IXOQCStMrsRJ5dFTvYV8f9HzZ9CRPKAX+nQ2tYPp11E7lGwrjefkFXqx4XnfqMXEDXhxAtT1U08Nv7pmC88KvSJypJ6S54nZF6zS+PyMZ7ZbOSGAerBVM97P71PJqSAT4QDoS6HpVnBpOsCprRw3kn6aY2HgmikOeekA9Xmw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(46966006)(36840700001)(40470700004)(36756003)(356005)(2906002)(81166007)(186003)(86362001)(82310400005)(8936002)(83380400001)(82740400003)(336012)(426003)(103116003)(47076005)(478600001)(8676002)(70206006)(40460700003)(4326008)(70586007)(2616005)(54906003)(966005)(316002)(26005)(36860700001)(41300700001)(6666004)(6916009)(5660300002)(1076003)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:18:14.2252 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aab0ecc1-79aa-4d9c-1e31-08dac3ef9223 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT011.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6540 'unsigned long long' is defined as 64 bit across both AArch32 and AArch64. So, use 'ULL' for 64 bit word instead of UL which is 32 bits for AArch32. GICR_PENDBASER and GICR_PROPBASER both are 64 bit registers. Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel Acked-by: Julien Grall --- Changes from - v1 - 1. Extract the bug fix for incorrect bit clearing (GICR_PENDBASER_PTZ) into a separate patch fix. https://patchwork.kernel.org/project/xen-devel/patch/20221027185555.46125-1-ayankuma@amd.com/ v2 - No changes. xen/arch/arm/include/asm/gic_v3_defs.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h index 728e28d5e5..48a1bc401e 100644 --- a/xen/arch/arm/include/asm/gic_v3_defs.h +++ b/xen/arch/arm/include/asm/gic_v3_defs.h @@ -134,15 +134,15 @@ #define GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT 56 #define GICR_PROPBASER_OUTER_CACHEABILITY_MASK \ - (7UL << GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT) + (7ULL << GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT) #define GICR_PROPBASER_SHAREABILITY_SHIFT 10 #define GICR_PROPBASER_SHAREABILITY_MASK \ - (3UL << GICR_PROPBASER_SHAREABILITY_SHIFT) + (3ULL << GICR_PROPBASER_SHAREABILITY_SHIFT) #define GICR_PROPBASER_INNER_CACHEABILITY_SHIFT 7 #define GICR_PROPBASER_INNER_CACHEABILITY_MASK \ - (7UL << GICR_PROPBASER_INNER_CACHEABILITY_SHIFT) + (7ULL << GICR_PROPBASER_INNER_CACHEABILITY_SHIFT) #define GICR_PROPBASER_RES0_MASK \ - (GENMASK(63, 59) | GENMASK(55, 52) | GENMASK(6, 5)) + (GENMASK_ULL(63, 59) | GENMASK_ULL(55, 52) | GENMASK_ULL(6, 5)) #define GICR_PENDBASER_SHAREABILITY_SHIFT 10 #define GICR_PENDBASER_INNER_CACHEABILITY_SHIFT 7 @@ -152,11 +152,11 @@ #define GICR_PENDBASER_INNER_CACHEABILITY_MASK \ (7UL << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT) #define GICR_PENDBASER_OUTER_CACHEABILITY_MASK \ - (7UL << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT) -#define GICR_PENDBASER_PTZ BIT(62, UL) + (7ULL << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT) +#define GICR_PENDBASER_PTZ BIT(62, ULL) #define GICR_PENDBASER_RES0_MASK \ - (BIT(63, UL) | GENMASK(61, 59) | GENMASK(55, 52) | \ - GENMASK(15, 12) | GENMASK(6, 0)) + (BIT(63, ULL) | GENMASK_ULL(61, 59) | GENMASK_ULL(55, 52) | \ + GENMASK_ULL(15, 12) | GENMASK_ULL(6, 0)) #define DEFAULT_PMR_VALUE 0xff -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:18:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:18:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442574.696904 (Exim 4.92) (envelope-from ) id 1otUrP-0000Tc-TX; Fri, 11 Nov 2022 14:18:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442574.696904; Fri, 11 Nov 2022 14:18:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrP-0000Sc-Pi; Fri, 11 Nov 2022 14:18:23 +0000 Received: by outflank-mailman (input) for mailman id 442574; Fri, 11 Nov 2022 14:18:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrO-0006iO-FR for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:18:22 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2044.outbound.protection.outlook.com [40.107.223.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1a2e667-61cb-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 15:18:21 +0100 (CET) Received: from BN1PR10CA0020.namprd10.prod.outlook.com (2603:10b6:408:e0::25) by DM6PR12MB4912.namprd12.prod.outlook.com (2603:10b6:5:20b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Fri, 11 Nov 2022 14:18:17 +0000 Received: from BN8NAM11FT033.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e0:cafe::7b) by BN1PR10CA0020.outlook.office365.com (2603:10b6:408:e0::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Fri, 11 Nov 2022 14:18:17 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT033.mail.protection.outlook.com (10.13.177.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 14:18:17 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:18:15 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 11 Nov 2022 08:18:14 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1a2e667-61cb-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A2JqJJ4fseB34F0NMFpJOLSEmVIRk0hngztiVW78/S6q7qo5Tygeljd3RYWGp47JCpizBDr2EL2K6R0JhyqezaP4CymejtYdnnwaB/EL0g6O98TWCHZGS4zqAg8uJmChuUNF69FzIWGZ35iGEu0b63z04eEe8b6iPQmrHO2KBHFdyYWdkDYovKz/UEB3W8vOFW1M6GruUgvoX1+TMe1P/tSaD1TnS66NIMV3abJ+rJV19yakS4EvEXhnfa+K4/RocRJA8nryI7bkqgXmlmV5irO8Pzp4U7lzgYd5DN/vlILiOs4PDnoB9zmjHDKwe8+/IgRDGPPuR3hRukp/SsYlJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FxJEzx55FB4HZS9AGsQGP4TBIHzxSrHrhRRSTavBMYM=; b=B5Tldffa7e7Tbyk21fXSakNWNLFQaRvmalgEcpW9prlEEsJ/3fRNnS7J2d4sCbnN9BrOUuOHGvmHQk+VkJLo9UUM5IByZsDbTXkqWy0LtA7H5i5HY3AR5sZe+DFniu+CNARYVU4AWsOqaq1Qd5UIxqSyi1OL23mdcDAyo/Peznv2e3DpkzxcNANPDrKyX08EQLJiynX/4wxCZwiqTm7re7K8pHpaxNtbKa4tr6DUoIstRZH6nRmPub/CTFbataEstEi9z7RbP/ruDmLbYyRfJKU8iQl1Z+M9OE0/aD7HVn23UAL5dJlQ0OmPGgLt4P20uYGG0WPsWySHSW2Log5jEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FxJEzx55FB4HZS9AGsQGP4TBIHzxSrHrhRRSTavBMYM=; b=DgiJ/9dJHPmJD/FFO+A+hpoOGI774kBbVZRjd+ofoeOvvU5G2O9NTdUkH5/JY8Wk0jVh96ejJ21MAeWmuckQNDX1GzPdshAM6cMas5BE/gtxlc7uty6p/igrHFxKQbN2+yDxds8TF10TKzEYEC5GARoCw3sJxgRqoM02r+UtenM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v3 06/12] xen/Arm: vGICv3: Fix emulation of ICC_SGI1R on AArch32 Date: Fri, 11 Nov 2022 14:17:33 +0000 Message-ID: <20221111141739.2872-7-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221111141739.2872-1-ayan.kumar.halder@amd.com> References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT033:EE_|DM6PR12MB4912:EE_ X-MS-Office365-Filtering-Correlation-Id: 94eb4e8e-dd0c-4df3-9698-08dac3ef93f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1q0psyAvFiNBju3PdoTzq+BQ8fLTZg9FNcwf31OdO0UVTLXAjKNJD8nGxeyX6ZPjSu/W23/Md4KEMC3e2Ac46d6jrLGN9q4+LnbAQDD5kwe2+X+531KfHqq5GFatDGtHnvvgz8Vg1WL5FBrmjW6vRZneNrC1n5KM8LCX8l5cN+VLHxcTz8kJCqNs0OsQBtkoRmQUvG/Va3Kshmd+TMfIQ3CAkF1Vtby5x4wgz0r6HaBpUc6aGuPe5rPSzH1JRek/a1kXpivdGu7pL1RYX7cXRix/CR08VdiZRBEgE8m2hoYccGvH1RMMuOO5cUC+FZCgPuF6X4v/l82qLE7aWBcf5SQactG8RGxWmFNKD2N3XLyzzokLTkvZo9K0Wea3uODTHPRHxlR+plZCDXDzI+5G37y5TUCoajlfpsDddZMP3whpqMCGUEh24Lfqm/yPJN8/LbIWIZD/PKf4rxN6LTSqritA+TCaZAtKOzYr/MO3eHVzRQzpVmOypIWJJke5kVumhogP5+Y8ur1zyTgETyRqgof4uqToI148UXSyL+BX1ImQ1emP8W4fV+OnxFIs1z0sLgjZ4yGYFo+Axhrwpr4TI9c5OGYlAawGQurfMZdsoy1Nw89LrY61t7bVKbKK9LexPeAgFm4vtn+JuAQgyjn2xYEuZhrxXXDfNv+JDYo3AKJ1o/CVWOsUnhDTf5F39sJWC7KAjyoqtllrechBAPQW/F7FlUAU2+tVE+1eeSt+2+ja+NLSCjtWVyMLzaImIOQ5snNC1gfP2hbiFFHYMbPGUYAJdosajpG4fURr2a5OokQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(5660300002)(356005)(8936002)(81166007)(186003)(70206006)(70586007)(478600001)(1076003)(47076005)(426003)(2906002)(336012)(40460700003)(86362001)(26005)(36756003)(8676002)(4326008)(82310400005)(83380400001)(2616005)(82740400003)(103116003)(6666004)(36860700001)(40480700001)(6916009)(54906003)(316002)(41300700001)(4744005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:18:17.2823 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94eb4e8e-dd0c-4df3-9698-08dac3ef93f5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT033.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4912 Refer Arm IHI 0069H ID020922, 12.5.23, ICC_SGI1R is a 64 bit register on AArch32 systems. Thus, the function needs to change to reflect this. The reason being 'register_t' is defined as 'u32' on AArch32. Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel Acked-by: Julien Grall --- Changes from :- v1 - 1. Updated the commit message. v2 - 1. No changes. xen/arch/arm/vgic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index a7a935ff57..93c8a0ae79 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -1479,7 +1479,7 @@ write_reserved: return 1; } -static bool vgic_v3_to_sgi(struct vcpu *v, register_t sgir) +static bool vgic_v3_to_sgi(struct vcpu *v, uint64_t sgir) { int virq; int irqmode; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:18:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:18:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442576.696915 (Exim 4.92) (envelope-from ) id 1otUrT-0000yB-AS; Fri, 11 Nov 2022 14:18:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442576.696915; Fri, 11 Nov 2022 14:18:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrT-0000xy-6Y; Fri, 11 Nov 2022 14:18:27 +0000 Received: by outflank-mailman (input) for mailman id 442576; Fri, 11 Nov 2022 14:18:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrR-00085I-Qb for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:18:26 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20626.outbound.protection.outlook.com [2a01:111:f400:fe59::626]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b326abb2-61cb-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 15:18:24 +0100 (CET) Received: from BN9PR03CA0467.namprd03.prod.outlook.com (2603:10b6:408:139::22) by CH3PR12MB7644.namprd12.prod.outlook.com (2603:10b6:610:14f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 11 Nov 2022 14:18:21 +0000 Received: from BN8NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:408:139:cafe::24) by BN9PR03CA0467.outlook.office365.com (2603:10b6:408:139::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Fri, 11 Nov 2022 14:18:20 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT047.mail.protection.outlook.com (10.13.177.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 14:18:20 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:18:19 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 06:18:19 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 11 Nov 2022 08:18:18 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b326abb2-61cb-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=blhiKs/MNGBc5qYMI9EZfkBroSX4j2CxXg1JtkJrDeHLmhA8VobQZ9CH73N9KyM8/9GIYirPb4CYyOyPObxIh8YRF6Xrc3wi/+ex0gWpiY9T52ROQAB2R6QzZ3Xl5OoPq7C1qy9irLvVJuJOVuKlbHdWRgCLnIyWZuBbtMK3kviUphI5LvSKwMyiKpXArgqkNu2gUGwGT3X8hwGlZ2vF3etK6T2EFpgjtZ0ndF+iq0gluLMusM98spMexfzwsGQ8NY5wcg8QJ74i9bpHNGNm/z1T3rWzSg05CRlYGc8xuaEtufXCY/wCvF83QqoHFziDTbsD4mEf7mKexXQWmTQcuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t2d4+K++sH6is+m73K0jRpobMHYo2Q5WMjnpk6XoADA=; b=MSHtYBF06DrVIeN/N0/hTBJ8rlYlxpvXuvrw4cTITs0U91VjE+fn9OCskD//Q4W7yR1VkYbOqFPnAOlfG5x3DYFXXothS5i0f1zWqQdXdQSlq8hv0VRbW6HvsATQC7TBtIOvxtzzdxtonS7u9m5hwR+FZkyWppJfTIN5JdiH4hf7u4tyBwqVYx0e4T95lJe9SpMW/thwv4ts46TwLBDuUVEbsnjGtG/moY2GXf9Okmtub/tY3aK+UQny9RUjPOu7nKwMOEtrR9MtMaCNAUzQOzQE9s+ip3jQVWCeE7gqdRY5NaoG/sPUSXIrPS5QnapUIdLdEz8Y5sKdVGcuam/zrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t2d4+K++sH6is+m73K0jRpobMHYo2Q5WMjnpk6XoADA=; b=38qBT6O4ZVv3F2Vqhi4anYEzN6aPRlaUeE2h96S4dnYopOjU87OY6tWTKi0V/vcGMTKEPYiXnsF4m4jq1BcTRdFQezqogy3iqayN/PfujvVWk8PAyMfnY2B9PCXuVqt/678OPpddm0qqZ49mKocLvKkI9AmTnA2LyCS+uOU4PHU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v3 07/12] xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32 Date: Fri, 11 Nov 2022 14:17:34 +0000 Message-ID: <20221111141739.2872-8-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221111141739.2872-1-ayan.kumar.halder@amd.com> References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT047:EE_|CH3PR12MB7644:EE_ X-MS-Office365-Filtering-Correlation-Id: 463621d2-5d41-476b-33da-08dac3ef95f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wm4uQINZPGrDlbRjkupRpgR/snCZb6ZFi8H8ihHFgFBxQlI4KYT1D6yjYCO1a271VcZbX0Qe46myrQYWMZvc7TzLgC0KUqatqmY7eRphyHNNS4bOz7Y9FIG+rEo3cHoNpIeyhtDPiHgAI9KF/HrR56zTAdNp1FAnyoW5YC70fkPDMu9VBYys1nfppxtrz397XqvIY5uhMO8N1ErMYciQ/5L52faHTA4ZXGi+1JUwKnbbZrgMLC5IIU5Ex+hVQ4K/c4oa5DEV1AGZal2xgauU+Tx+JVlqS18RXUATue/c5zSD8qGL1P/J/c1TmuunAfS7wTBiHjNuk0El55XpQ9WTP7Gu4eq22T34oObV+qjvYFxg5RCeZ43VRfKdQv6g8uayR1PnDgRYIMI5MRE8zDygjaxeQu6VtBsKMmBfu/AwN3vM+Wm/br49W/ccX7JIWF85nz1T5Www0ZXPu/TDsQarNmaFiEFdgvmkcBRzdNJATYOX+B+M49EH/Lx/okROHxCflStKsZoZ2X9VTn8SlaPEYXP6zBeW0rNz4VXiyyX+aI3Q0ZddBKn9zw9hj5g0+Bck7e005koZGO6dsKydv2UWVYhVdUVCoKzXcEuq6BsYqqLvTF/O+MdCzgTHpUyMazRhUpx9BIBDTpjHrPa8IjgnFZ7iRTFoiKD6cTNuCBjTpLODdrjTxfReKrfLl5oIQGmAqwdVBE5NCoQc/VVHLXFo1rnyav9+4HyU2/pLBQa3Wf1wsiYXWOhfZfPgNAoAISa6mKqChdCJ8SAIsV2jkSV0WbU7w00kV5jMKFcPkGZyo3s= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(376002)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(82740400003)(36860700001)(41300700001)(478600001)(356005)(8676002)(6666004)(40460700003)(30864003)(36756003)(8936002)(82310400005)(70206006)(2906002)(70586007)(4326008)(86362001)(54906003)(316002)(5660300002)(6916009)(81166007)(40480700001)(103116003)(336012)(186003)(2616005)(83380400001)(426003)(1076003)(26005)(47076005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:18:20.6549 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 463621d2-5d41-476b-33da-08dac3ef95f8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7644 Refer "Arm IHI 0069H ID020922", 12.4.6, Interrupt Controller List Registers AArch64 System register ICH_LR_EL2 bits [31:0] are architecturally mapped to AArch32 System register ICH_LR[31:0]. AArch64 System register ICH_LR_EL2 bits [63:32] are architecturally mapped to AArch32 System register ICH_LRC[31:0]. Defined ICH_LR<0...15>_EL2 and ICH_LRC<0...15>_EL2 for AArch32. For AArch32, the link register is stored as :- (((uint64_t) ICH_LRC<0...15>_EL2) << 32) | ICH_LR<0...15>_EL2 Also, ICR_LR macros need to be modified as ULL is 64 bits for AArch32 and AArch64. Signed-off-by: Ayan Kumar Halder --- Changes from :- v1 - 1. Moved the coproc register definitions to asm/cpregs.h. 2. Use GENMASK(31, 0) to represent 0xFFFFFFFF 3. Use READ_CP32()/WRITE_CP32() instead of READ_SYSREG()/WRITE_SYSREG(). 4. Multi-line macro definitions should be enclosed within ({ }). v2 - 1. Use WRITE_SYSREG_LR(V, R) to make it consistent with before. 2. Defined the register alias. 3. Style issues. xen/arch/arm/gic-v3.c | 132 +++++++++++------------ xen/arch/arm/include/asm/arm32/sysregs.h | 19 ++++ xen/arch/arm/include/asm/arm64/sysregs.h | 4 + xen/arch/arm/include/asm/cpregs.h | 75 +++++++++++++ xen/arch/arm/include/asm/gic_v3_defs.h | 6 +- 5 files changed, 167 insertions(+), 69 deletions(-) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 64a76307dd..4722bb4daf 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -73,37 +73,37 @@ static inline void gicv3_save_lrs(struct vcpu *v) switch ( gicv3_info.nr_lrs ) { case 16: - v->arch.gic.v3.lr[15] = READ_SYSREG(ICH_LR15_EL2); + v->arch.gic.v3.lr[15] = READ_SYSREG_LR(15); case 15: - v->arch.gic.v3.lr[14] = READ_SYSREG(ICH_LR14_EL2); + v->arch.gic.v3.lr[14] = READ_SYSREG_LR(14); case 14: - v->arch.gic.v3.lr[13] = READ_SYSREG(ICH_LR13_EL2); + v->arch.gic.v3.lr[13] = READ_SYSREG_LR(13); case 13: - v->arch.gic.v3.lr[12] = READ_SYSREG(ICH_LR12_EL2); + v->arch.gic.v3.lr[12] = READ_SYSREG_LR(12); case 12: - v->arch.gic.v3.lr[11] = READ_SYSREG(ICH_LR11_EL2); + v->arch.gic.v3.lr[11] = READ_SYSREG_LR(11); case 11: - v->arch.gic.v3.lr[10] = READ_SYSREG(ICH_LR10_EL2); + v->arch.gic.v3.lr[10] = READ_SYSREG_LR(10); case 10: - v->arch.gic.v3.lr[9] = READ_SYSREG(ICH_LR9_EL2); + v->arch.gic.v3.lr[9] = READ_SYSREG_LR(9); case 9: - v->arch.gic.v3.lr[8] = READ_SYSREG(ICH_LR8_EL2); + v->arch.gic.v3.lr[8] = READ_SYSREG_LR(8); case 8: - v->arch.gic.v3.lr[7] = READ_SYSREG(ICH_LR7_EL2); + v->arch.gic.v3.lr[7] = READ_SYSREG_LR(7); case 7: - v->arch.gic.v3.lr[6] = READ_SYSREG(ICH_LR6_EL2); + v->arch.gic.v3.lr[6] = READ_SYSREG_LR(6); case 6: - v->arch.gic.v3.lr[5] = READ_SYSREG(ICH_LR5_EL2); + v->arch.gic.v3.lr[5] = READ_SYSREG_LR(5); case 5: - v->arch.gic.v3.lr[4] = READ_SYSREG(ICH_LR4_EL2); + v->arch.gic.v3.lr[4] = READ_SYSREG_LR(4); case 4: - v->arch.gic.v3.lr[3] = READ_SYSREG(ICH_LR3_EL2); + v->arch.gic.v3.lr[3] = READ_SYSREG_LR(3); case 3: - v->arch.gic.v3.lr[2] = READ_SYSREG(ICH_LR2_EL2); + v->arch.gic.v3.lr[2] = READ_SYSREG_LR(2); case 2: - v->arch.gic.v3.lr[1] = READ_SYSREG(ICH_LR1_EL2); + v->arch.gic.v3.lr[1] = READ_SYSREG_LR(1); case 1: - v->arch.gic.v3.lr[0] = READ_SYSREG(ICH_LR0_EL2); + v->arch.gic.v3.lr[0] = READ_SYSREG_LR(0); break; default: BUG(); @@ -120,37 +120,37 @@ static inline void gicv3_restore_lrs(const struct vcpu *v) switch ( gicv3_info.nr_lrs ) { case 16: - WRITE_SYSREG(v->arch.gic.v3.lr[15], ICH_LR15_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[15], 15); case 15: - WRITE_SYSREG(v->arch.gic.v3.lr[14], ICH_LR14_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[14], 14); case 14: - WRITE_SYSREG(v->arch.gic.v3.lr[13], ICH_LR13_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[13], 13); case 13: - WRITE_SYSREG(v->arch.gic.v3.lr[12], ICH_LR12_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[12], 12); case 12: - WRITE_SYSREG(v->arch.gic.v3.lr[11], ICH_LR11_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[11], 11); case 11: - WRITE_SYSREG(v->arch.gic.v3.lr[10], ICH_LR10_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[10], 10); case 10: - WRITE_SYSREG(v->arch.gic.v3.lr[9], ICH_LR9_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[9], 9); case 9: - WRITE_SYSREG(v->arch.gic.v3.lr[8], ICH_LR8_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[8], 8); case 8: - WRITE_SYSREG(v->arch.gic.v3.lr[7], ICH_LR7_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[7], 7); case 7: - WRITE_SYSREG(v->arch.gic.v3.lr[6], ICH_LR6_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[6], 6); case 6: - WRITE_SYSREG(v->arch.gic.v3.lr[5], ICH_LR5_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[5], 5); case 5: - WRITE_SYSREG(v->arch.gic.v3.lr[4], ICH_LR4_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[4], 4); case 4: - WRITE_SYSREG(v->arch.gic.v3.lr[3], ICH_LR3_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[3], 3); case 3: - WRITE_SYSREG(v->arch.gic.v3.lr[2], ICH_LR2_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[2], 2); case 2: - WRITE_SYSREG(v->arch.gic.v3.lr[1], ICH_LR1_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[1], 1); case 1: - WRITE_SYSREG(v->arch.gic.v3.lr[0], ICH_LR0_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[0], 0); break; default: BUG(); @@ -161,22 +161,22 @@ static uint64_t gicv3_ich_read_lr(int lr) { switch ( lr ) { - case 0: return READ_SYSREG(ICH_LR0_EL2); - case 1: return READ_SYSREG(ICH_LR1_EL2); - case 2: return READ_SYSREG(ICH_LR2_EL2); - case 3: return READ_SYSREG(ICH_LR3_EL2); - case 4: return READ_SYSREG(ICH_LR4_EL2); - case 5: return READ_SYSREG(ICH_LR5_EL2); - case 6: return READ_SYSREG(ICH_LR6_EL2); - case 7: return READ_SYSREG(ICH_LR7_EL2); - case 8: return READ_SYSREG(ICH_LR8_EL2); - case 9: return READ_SYSREG(ICH_LR9_EL2); - case 10: return READ_SYSREG(ICH_LR10_EL2); - case 11: return READ_SYSREG(ICH_LR11_EL2); - case 12: return READ_SYSREG(ICH_LR12_EL2); - case 13: return READ_SYSREG(ICH_LR13_EL2); - case 14: return READ_SYSREG(ICH_LR14_EL2); - case 15: return READ_SYSREG(ICH_LR15_EL2); + case 0: return READ_SYSREG_LR(0); + case 1: return READ_SYSREG_LR(1); + case 2: return READ_SYSREG_LR(2); + case 3: return READ_SYSREG_LR(3); + case 4: return READ_SYSREG_LR(4); + case 5: return READ_SYSREG_LR(5); + case 6: return READ_SYSREG_LR(6); + case 7: return READ_SYSREG_LR(7); + case 8: return READ_SYSREG_LR(8); + case 9: return READ_SYSREG_LR(9); + case 10: return READ_SYSREG_LR(10); + case 11: return READ_SYSREG_LR(11); + case 12: return READ_SYSREG_LR(12); + case 13: return READ_SYSREG_LR(13); + case 14: return READ_SYSREG_LR(14); + case 15: return READ_SYSREG_LR(15); default: BUG(); } @@ -187,52 +187,52 @@ static void gicv3_ich_write_lr(int lr, uint64_t val) switch ( lr ) { case 0: - WRITE_SYSREG(val, ICH_LR0_EL2); + WRITE_SYSREG_LR(val, 0); break; case 1: - WRITE_SYSREG(val, ICH_LR1_EL2); + WRITE_SYSREG_LR(val, 1); break; case 2: - WRITE_SYSREG(val, ICH_LR2_EL2); + WRITE_SYSREG_LR(val, 2); break; case 3: - WRITE_SYSREG(val, ICH_LR3_EL2); + WRITE_SYSREG_LR(val, 3); break; case 4: - WRITE_SYSREG(val, ICH_LR4_EL2); + WRITE_SYSREG_LR(val, 4); break; case 5: - WRITE_SYSREG(val, ICH_LR5_EL2); + WRITE_SYSREG_LR(val, 5); break; case 6: - WRITE_SYSREG(val, ICH_LR6_EL2); + WRITE_SYSREG_LR(val, 6); break; case 7: - WRITE_SYSREG(val, ICH_LR7_EL2); + WRITE_SYSREG_LR(val, 7); break; case 8: - WRITE_SYSREG(val, ICH_LR8_EL2); + WRITE_SYSREG_LR(val, 8); break; case 9: - WRITE_SYSREG(val, ICH_LR9_EL2); + WRITE_SYSREG_LR(val, 9); break; case 10: - WRITE_SYSREG(val, ICH_LR10_EL2); + WRITE_SYSREG_LR(val, 10); break; case 11: - WRITE_SYSREG(val, ICH_LR11_EL2); + WRITE_SYSREG_LR(val, 11); break; case 12: - WRITE_SYSREG(val, ICH_LR12_EL2); + WRITE_SYSREG_LR(val, 12); break; case 13: - WRITE_SYSREG(val, ICH_LR13_EL2); + WRITE_SYSREG_LR(val, 13); break; case 14: - WRITE_SYSREG(val, ICH_LR14_EL2); + WRITE_SYSREG_LR(val, 14); break; case 15: - WRITE_SYSREG(val, ICH_LR15_EL2); + WRITE_SYSREG_LR(val, 15); break; default: return; @@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v) if ( v == current ) { for ( i = 0; i < gicv3_info.nr_lrs; i++ ) - printk(" HW_LR[%d]=%lx\n", i, gicv3_ich_read_lr(i)); + printk(" HW_LR[%d]=%llx\n", i, gicv3_ich_read_lr(i)); } else { for ( i = 0; i < gicv3_info.nr_lrs; i++ ) - printk(" VCPU_LR[%d]=%lx\n", i, v->arch.gic.v3.lr[i]); + printk(" VCPU_LR[%d]=%llx\n", i, v->arch.gic.v3.lr[i]); } } diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h index 6841d5de43..31ad7eaefb 100644 --- a/xen/arch/arm/include/asm/arm32/sysregs.h +++ b/xen/arch/arm/include/asm/arm32/sysregs.h @@ -62,6 +62,25 @@ #define READ_SYSREG(R...) READ_SYSREG32(R) #define WRITE_SYSREG(V, R...) WRITE_SYSREG32(V, R) +/* Wrappers for accessing interrupt controller list registers. */ +#define ICH_LR_REG(index) ICH_LR ## index ## _EL2 +#define ICH_LRC_REG(index) ICH_LRC ## index ## _EL2 + +#define READ_SYSREG_LR(index) ({ \ + uint64_t _val; \ + uint32_t _lrc = READ_CP32(ICH_LRC_REG(index)); \ + uint32_t _lr = READ_CP32(ICH_LR_REG(index)); \ + \ + _val = ((uint64_t) _lrc << 32) | _lr; \ + _val; \ +}) + +#define WRITE_SYSREG_LR(V, index) ({ \ + uint64_t _val = (V); \ + WRITE_CP32(_val & GENMASK(31, 0), ICH_LR_REG(index)); \ + WRITE_CP32(_val >> 32, ICH_LRC_REG(index)); \ +}) + /* MVFR2 is not defined on ARMv7 */ #define MVFR2_MAYBE_UNDEFINED diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index 54670084c3..b72a6ea3b0 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -472,6 +472,10 @@ #define READ_SYSREG(name) READ_SYSREG64(name) #define WRITE_SYSREG(v, name) WRITE_SYSREG64(v, name) +/* Wrappers for accessing interrupt controller list registers. */ +#define ICH_LR_REG(index) ICH_LR ## index ## _EL2 +#define WRITE_SYSREG_LR(V, index) WRITE_SYSREG(V, ICH_LR_REG(index)) +#define READ_SYSREG_LR(index) READ_SYSREG(ICH_LR_REG(index)) #endif /* _ASM_ARM_ARM64_SYSREGS_H */ /* diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h index 6daf2b1a30..242dabaea8 100644 --- a/xen/arch/arm/include/asm/cpregs.h +++ b/xen/arch/arm/include/asm/cpregs.h @@ -259,6 +259,49 @@ #define VBAR p15,0,c12,c0,0 /* Vector Base Address Register */ #define HVBAR p15,4,c12,c0,0 /* Hyp. Vector Base Address Register */ +/* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ +#define ___CP32(coproc, opc1, crn, crm, opc2) coproc, opc1, crn, crm, opc2 +#define __LR0(x) ___CP32(p15, 4, c12, c12, x) +#define __LR8(x) ___CP32(p15, 4, c12, c13, x) + +#define ICH_LR0 __LR0(0) +#define ICH_LR1 __LR0(1) +#define ICH_LR2 __LR0(2) +#define ICH_LR3 __LR0(3) +#define ICH_LR4 __LR0(4) +#define ICH_LR5 __LR0(5) +#define ICH_LR6 __LR0(6) +#define ICH_LR7 __LR0(7) +#define ICH_LR8 __LR8(0) +#define ICH_LR9 __LR8(1) +#define ICH_LR10 __LR8(2) +#define ICH_LR11 __LR8(3) +#define ICH_LR12 __LR8(4) +#define ICH_LR13 __LR8(5) +#define ICH_LR14 __LR8(6) +#define ICH_LR15 __LR8(7) + +/* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ +#define __LRC0(x) ___CP32(p15, 4, c12, c14, x) +#define __LRC8(x) ___CP32(p15, 4, c12, c15, x) + +#define ICH_LRC0 __LRC0(0) +#define ICH_LRC1 __LRC0(1) +#define ICH_LRC2 __LRC0(2) +#define ICH_LRC3 __LRC0(3) +#define ICH_LRC4 __LRC0(4) +#define ICH_LRC5 __LRC0(5) +#define ICH_LRC6 __LRC0(6) +#define ICH_LRC7 __LRC0(7) +#define ICH_LRC8 __LRC8(0) +#define ICH_LRC9 __LRC8(1) +#define ICH_LRC10 __LRC8(2) +#define ICH_LRC11 __LRC8(3) +#define ICH_LRC12 __LRC8(4) +#define ICH_LRC13 __LRC8(5) +#define ICH_LRC14 __LRC8(6) +#define ICH_LRC15 __LRC8(7) + /* CP15 CR13: */ #define FCSEIDR p15,0,c13,c0,0 /* FCSE Process ID Register */ #define CONTEXTIDR p15,0,c13,c0,1 /* Context ID Register */ @@ -317,6 +360,38 @@ #define HCR_EL2 HCR #define HPFAR_EL2 HPFAR #define HSTR_EL2 HSTR +#define ICH_LR0_EL2 ICH_LR0 +#define ICH_LR1_EL2 ICH_LR1 +#define ICH_LR2_EL2 ICH_LR2 +#define ICH_LR3_EL2 ICH_LR3 +#define ICH_LR4_EL2 ICH_LR4 +#define ICH_LR5_EL2 ICH_LR5 +#define ICH_LR6_EL2 ICH_LR6 +#define ICH_LR7_EL2 ICH_LR7 +#define ICH_LR8_EL2 ICH_LR8 +#define ICH_LR9_EL2 ICH_LR9 +#define ICH_LR10_EL2 ICH_LR10 +#define ICH_LR11_EL2 ICH_LR11 +#define ICH_LR12_EL2 ICH_LR12 +#define ICH_LR13_EL2 ICH_LR13 +#define ICH_LR14_EL2 ICH_LR14 +#define ICH_LR15_EL2 ICH_LR15 +#define ICH_LRC0_EL2 ICH_LRC0 +#define ICH_LRC1_EL2 ICH_LRC1 +#define ICH_LRC2_EL2 ICH_LRC2 +#define ICH_LRC3_EL2 ICH_LRC3 +#define ICH_LRC4_EL2 ICH_LRC4 +#define ICH_LRC5_EL2 ICH_LRC5 +#define ICH_LRC6_EL2 ICH_LRC6 +#define ICH_LRC7_EL2 ICH_LRC7 +#define ICH_LRC8_EL2 ICH_LRC8 +#define ICH_LRC9_EL2 ICH_LRC9 +#define ICH_LRC10_EL2 ICH_LRC10 +#define ICH_LRC11_EL2 ICH_LRC11 +#define ICH_LRC12_EL2 ICH_LRC12 +#define ICH_LRC13_EL2 ICH_LRC13 +#define ICH_LRC14_EL2 ICH_LRC14 +#define ICH_LRC15_EL2 ICH_LRC15 #define ID_AFR0_EL1 ID_AFR0 #define ID_DFR0_EL1 ID_DFR0 #define ID_DFR1_EL1 ID_DFR1 diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h index 48a1bc401e..743ebb20fd 100644 --- a/xen/arch/arm/include/asm/gic_v3_defs.h +++ b/xen/arch/arm/include/asm/gic_v3_defs.h @@ -185,9 +185,9 @@ #define ICH_LR_HW_SHIFT 61 #define ICH_LR_GRP_MASK 0x1 #define ICH_LR_GRP_SHIFT 60 -#define ICH_LR_MAINTENANCE_IRQ (1UL<<41) -#define ICH_LR_GRP1 (1UL<<60) -#define ICH_LR_HW (1UL<<61) +#define ICH_LR_MAINTENANCE_IRQ (1ULL << 41) +#define ICH_LR_GRP1 (1ULL << 60) +#define ICH_LR_HW (1ULL << 61) #define ICH_VTR_NRLRGS 0x3f #define ICH_VTR_PRIBITS_MASK 0x7 -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:18:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:18:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442579.696926 (Exim 4.92) (envelope-from ) id 1otUrV-0001Ol-SD; Fri, 11 Nov 2022 14:18:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442579.696926; Fri, 11 Nov 2022 14:18:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrV-0001OG-NW; Fri, 11 Nov 2022 14:18:29 +0000 Received: by outflank-mailman (input) for mailman id 442579; Fri, 11 Nov 2022 14:18:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrU-0006iO-Jp for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:18:28 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2047.outbound.protection.outlook.com [40.107.212.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b4df67b2-61cb-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 15:18:26 +0100 (CET) Received: from DM6PR03CA0050.namprd03.prod.outlook.com (2603:10b6:5:100::27) by PH8PR12MB6721.namprd12.prod.outlook.com (2603:10b6:510:1cc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Fri, 11 Nov 2022 14:18:23 +0000 Received: from DM6NAM11FT086.eop-nam11.prod.protection.outlook.com (2603:10b6:5:100:cafe::20) by DM6PR03CA0050.outlook.office365.com (2603:10b6:5:100::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Fri, 11 Nov 2022 14:18:23 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT086.mail.protection.outlook.com (10.13.173.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 14:18:23 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:18:22 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 11 Nov 2022 08:18:21 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4df67b2-61cb-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cX2R6X9nTOHOkmcoEEzQaY0OSPVqAV6tVs/574NINwL04VSDnhjZk6y8C18PQ3zcVe2qLHxenzyCSoVAfog6t8f6e4yb7ig7eHkRGJ4SBM4YuT0n55jDVY/j8bWn9zpiLNtCEKZcPKbUSQqe9lS2Kjd4P41SqiVjOdIhbjkAZCkzAIo8tzNQJn2BvFN5+/AQwhlaOorIFcgRiS1TQpIcoiexJGkDZUdSvMi/wsn7Ddv8s+snItHzfFqj6b4XGl4817f+aiK7huVvFH+6/C4Zr3RWp8KjC6yrfJnNW15fqPG7mrjYj9FQZIt/cKbZi9StnVa+6DzPF5M0Uu9hf/TSXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IsAJVVAUjSFPGt2LeVQyetBWveT0jt2DV1V4P7YMw1Q=; b=iTcte/8PSbjvxsdL1Kzkyr+zTUtzoNn8LWCiHAVumLsbm01SvWfgECrFA9X9EjJrPblrTjzHDpIe3TZOqsHDPxOeljyusz2OkQzxkDeRVoAj/AHJEnLmOGCisQfq181IJWWxycO5WW7Oca8Ao84QhhHCQcWOmk1AzvX1b/qGErs4+7B5rd17BnVHJ0OjR3iInPANYEa+8TL03n4EzMl/XrmQcMMNlTE2SmYdidER1VgULRXNp6i0s/njU7h4fv8A8YigeFmQCHVrdOBBQE6w/CaZb5li3aad7oT6m7J/Wu/BVySjzij5Y5jqy4TNgxOIdVncfiUOm1ZE8AsZ1FYtOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IsAJVVAUjSFPGt2LeVQyetBWveT0jt2DV1V4P7YMw1Q=; b=Sh6B8zrXHRbLgL8Er/Jy8Mr5yx0pzc6/TTR2GYDupKfYmGt6By9m0fk3hYdE5igY74YC/hztjmR3n7KAn84Mo3dtEIWRhURHr3X/SH31CgXqLI32bkDZxKcPiBTMATVFtH+38Ntcw/XZJ8jlHZ9d1mvvvLNCBtIVgC9VnLJKTVY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v3 08/12] xen/Arm: GICv3: Define ICH_AP0R and ICH_AP1R for AArch32 Date: Fri, 11 Nov 2022 14:17:35 +0000 Message-ID: <20221111141739.2872-9-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221111141739.2872-1-ayan.kumar.halder@amd.com> References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT086:EE_|PH8PR12MB6721:EE_ X-MS-Office365-Filtering-Correlation-Id: a0998ee4-dffc-4346-cb76-08dac3ef9775 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P0g2ZPs/8oV63KPXWCK6Dh5H9lTdyQZF7S/ctpMowZn9w6KaUVOt7sWwAWeWxPzvUt50LyY3M+vopmT1X9X06A/207HKRICC81rjBpaUdifv5FjVpbK2vwZctsEwKgI2K1IytEPwm1ZdpXLEDHZN5jHKlgJvABx9Np5Q4LP0f9dssCHHz2dWsoPesvgP83sDpgOrWRHRm5IxdW7xV3A0VQtKd3Gx2DJTrXdiW+mDzZZiMcymMPbhcUG0kIDTbGvnDKa9eHHJ1WtpZgM2gF9NvnjVlNiaWMpd/ayRXsejycVJlRcY8lynfvm9gS6oYJK+EPoph38nq7ld/AmqSBdoylCjF8EtWbDqYHEt723mYhrzo6MWODA7k/ym9kAMWiItglP11XwZjvKnvy21Y161u1QAojOQu4q6/T4AHQe/rwAN921BNUYtahAjKw/cmIPN7qk9wlrVbk30Ctk/+GQffAJC9DMXZUJFV+29VIdmbhyqV187ZHr+idQmWAXw9SYab5FVK0tD5vf7Zx5I1VHGKJpuPKL0O2Kr7BhILC+1Z6YukvfgkCA65JD3dCVtC0Xw1iFm0nP2c8UjUfLQCsdhC5cmB8tkr7yOAE8omDNojgWP4JWi9yq8B3Gktrv0k4VV6gpnd76u9g2/At1UUvx+1AjbvIVdRbC82Qpfp7uT0Ro/0/3NKaBa1vXlPY/br6O8supeAujcEF4QJaweRtval5MLfGxl1ot7JE+YVYh+dNxIvL+iHXmF7q1DNNFxJYPowx8upFGG9gciMn1J4T49IZShqXoWKdPzeCL1yPBApfU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(376002)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(40460700003)(47076005)(426003)(83380400001)(186003)(54906003)(336012)(6916009)(36756003)(2616005)(41300700001)(1076003)(8676002)(70586007)(82740400003)(4326008)(356005)(8936002)(81166007)(70206006)(82310400005)(40480700001)(26005)(5660300002)(2906002)(103116003)(316002)(86362001)(6666004)(36860700001)(478600001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:18:23.1244 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a0998ee4-dffc-4346-cb76-08dac3ef9775 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT086.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6721 Adapt save_aprn_regs()/restore_aprn_regs() for AArch32. For which we have defined the following registers:- 1. Interrupt Controller Hyp Active Priorities Group0 Registers 0-3 2. Interrupt Controller Hyp Active Priorities Group1 Registers 0-3 Signed-off-by: Ayan Kumar Halder --- Changes from :- v1 - 1. Moved coproc register definition to asm/cpregs.h. v2 - 1. Defined register alias. 2. Style issues. 3. Dropped R-b and Ack. xen/arch/arm/include/asm/cpregs.h | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h index 242dabaea8..5331ec3448 100644 --- a/xen/arch/arm/include/asm/cpregs.h +++ b/xen/arch/arm/include/asm/cpregs.h @@ -259,6 +259,26 @@ #define VBAR p15,0,c12,c0,0 /* Vector Base Address Register */ #define HVBAR p15,4,c12,c0,0 /* Hyp. Vector Base Address Register */ +/* + * CP15 CR12: Interrupt Controller Hyp Active Priorities Group 0 Registers, + * n = 0 - 3 + */ +#define __AP0Rx(x) ___CP32(p15, 4, c12, c8, x) +#define ICH_AP0R0 __AP0Rx(0) +#define ICH_AP0R1 __AP0Rx(1) +#define ICH_AP0R2 __AP0Rx(2) +#define ICH_AP0R3 __AP0Rx(3) + +/* + * CP15 CR12: Interrupt Controller Hyp Active Priorities Group 1 Registers, + * n = 0 - 3 + */ +#define __AP1Rx(x) ___CP32(p15, 4, c12, c9, x) +#define ICH_AP1R0 __AP1Rx(0) +#define ICH_AP1R1 __AP1Rx(1) +#define ICH_AP1R2 __AP1Rx(2) +#define ICH_AP1R3 __AP1Rx(3) + /* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ #define ___CP32(coproc, opc1, crn, crm, opc2) coproc, opc1, crn, crm, opc2 #define __LR0(x) ___CP32(p15, 4, c12, c12, x) @@ -360,6 +380,14 @@ #define HCR_EL2 HCR #define HPFAR_EL2 HPFAR #define HSTR_EL2 HSTR +#define ICH_AP0R0_EL2 ICH_AP0R0 +#define ICH_AP0R1_EL2 ICH_AP0R1 +#define ICH_AP0R2_EL2 ICH_AP0R2 +#define ICH_AP0R3_EL2 ICH_AP0R3 +#define ICH_AP1R0_EL2 ICH_AP1R0 +#define ICH_AP1R1_EL2 ICH_AP1R1 +#define ICH_AP1R2_EL2 ICH_AP1R2 +#define ICH_AP1R3_EL2 ICH_AP1R3 #define ICH_LR0_EL2 ICH_LR0 #define ICH_LR1_EL2 ICH_LR1 #define ICH_LR2_EL2 ICH_LR2 -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:18:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:18:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442580.696937 (Exim 4.92) (envelope-from ) id 1otUra-0001vY-5z; Fri, 11 Nov 2022 14:18:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442580.696937; Fri, 11 Nov 2022 14:18:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUra-0001uJ-1f; Fri, 11 Nov 2022 14:18:34 +0000 Received: by outflank-mailman (input) for mailman id 442580; Fri, 11 Nov 2022 14:18:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrY-00085I-HM for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:18:32 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20609.outbound.protection.outlook.com [2a01:111:f400:fe5a::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b7559c7d-61cb-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 15:18:31 +0100 (CET) Received: from DM6PR07CA0105.namprd07.prod.outlook.com (2603:10b6:5:330::8) by PH7PR12MB5975.namprd12.prod.outlook.com (2603:10b6:510:1da::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Fri, 11 Nov 2022 14:18:26 +0000 Received: from DM6NAM11FT098.eop-nam11.prod.protection.outlook.com (2603:10b6:5:330:cafe::7) by DM6PR07CA0105.outlook.office365.com (2603:10b6:5:330::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Fri, 11 Nov 2022 14:18:26 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT098.mail.protection.outlook.com (10.13.173.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 14:18:26 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:18:25 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 06:18:25 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 11 Nov 2022 08:18:23 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7559c7d-61cb-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WwjnwvzpgMxB8tmoZKj4AUdLg9rXsbqvvljkmZsMDwlvcQ1JLodgLZ0FZSF9d82kSFrlpRJXMxA4+dgJedBfDzbd+iE+s7EKC0BKABLDK85djIrOl7Vf87+Eob8fo+8Y7HD2pYOz2wmB7YcqOIKWiMOFVw/oHF6duBkIPbNI717M4wyW1/jEH9DC6H59PHgrIWAM+q/DkGvtT1/b5p9oeb3FJObOUgswpZqWjYkxdxJuKJyNUa++JJUlG+CJ3u0iYjx0zF7GOn5YdBs0a1s5XW9zHjXZHQdPfjojGVuRRhOaGGsNS1KGTaw5LuVvrqQRegNGPO665b1WNm9rRUJBTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zc5XsypOg79Sm/oGi7O9cX08XDJ7yyoeCUIF1WKA744=; b=KrYiGHy74/zYCuI46WM6wi5UQe5jZnk5p/4g3MI6/jzKFtmizcTQCrP8TsZHxeVGWRYY1mqf16gmdrSDOuKNw1XNPpI616cGlG1bOQwojsc+3X/+4ppdpbGKADOcggRMB8VAgzDZkxuwStxFvTSehx8Clu4Oe9lpc5R8Am3oYc9WuTGiIaoVaRQDPsaE8aotm/ZgyVyolDWgHQ8IAhcfai0uAYaA0NwnLcmQNqQ+AY7S+1mI7ZWBMwdyedtXNkIlas1n7NlFRppSkVA4SGD5DK2NrgxIHiz0E3LTVeCBKmsYCaWl8lwECskNiBrNpredPX+ncJi0iofOzItW7aqnnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zc5XsypOg79Sm/oGi7O9cX08XDJ7yyoeCUIF1WKA744=; b=fii/TbwheW5GyDJ+YE0+sHCXHSgrdolsBKSPoZz7BbjYT7kCDAe2GpNsSxHWo0b1531PCG65ri4Lot343Vmyy8ECZ3om0gaL0DumqKJ2pBWdzA2qhFoDc4oyoNPjFjxLq3GCDrL9ogVhk7CtUl5ncJbh3t4sXPJsTIjfVALGUjw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v3 09/12] xen/Arm: GICv3: Define remaining GIC registers for AArch32 Date: Fri, 11 Nov 2022 14:17:36 +0000 Message-ID: <20221111141739.2872-10-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221111141739.2872-1-ayan.kumar.halder@amd.com> References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT098:EE_|PH7PR12MB5975:EE_ X-MS-Office365-Filtering-Correlation-Id: edf990fd-4e92-4e8f-996c-08dac3ef992e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dE8bzmQ4mapU1jNtZNP2li30DMGzqwpSVleWnmxfaYFOp7CjjFohxEu0EgpVll7BrwcmQ0Kp+G9VlkPpHQiyYnKYndGo3IwlbXoef4o3bE1EaFE9CsG/05ctW2u1a4nYMt8lDcqre5l9nV7E1TdJYml7NYdU3hNZUKqgFiI/qYymM0ms41avTibJxRYiomn622W4DWTdTwZjUKMARMO+O6qa3tFV84YYG6RUd0foxOJjDpxURtSHhTIj6nxE+rlOpgGchx6GICg0wOMwClKK1ieEKOty0DFIdho23HJkiiUMdn05Rctq3IvyMYpIQu4zpMtsVJXU2Y6FaNy4IcmcqfX4fyjpRHb9CGYiJDcHq8fwxnMg44HkfnnumXJJeyfp7i44DKd0tfXohT7n7KAhuVmxf/bz9uJQFQQGhYlTH0DM1tWVzFB1xRbH8tkBl3vURLufmm5aiz1P7IxfZy+CEhjsTjQFUuzvq1fd7SkYilNstbZPXEyiW4J7dg9vHRwg5M/M+FixOpR3t1XanAecZLmgXCXfLppQ4x3FcI0QpBgw5jstQipS+EGKE58y/uuSNSDyg4RSFpucwTTv/OELPzA/huPDtC7a/fu6p6+Vhr0onyoGuO1cXvvZQ1r9Q6DzwP0xXVq93c15lPLrOvazP7ZSo9Q0t59CgR4n+bNijuEC9r7qqR85IQF66jUV03hAgaQfuKDFEhw3o2v4i1BpH2JiRvJsnaI7IuHgsdSgHjVFvgd1ghnWo64uTY0y3Zbhhl2R/bUB2C8GcXuFIr24exPpeGuVNt98hJo1jhnMUfStzhUXmYCWLm9K4afczc0F X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(136003)(396003)(451199015)(46966006)(40470700004)(36840700001)(83380400001)(81166007)(186003)(316002)(82740400003)(336012)(426003)(4326008)(6916009)(36860700001)(8936002)(5660300002)(26005)(2906002)(1076003)(47076005)(6666004)(40460700003)(478600001)(41300700001)(356005)(54906003)(82310400005)(40480700001)(70586007)(8676002)(70206006)(2616005)(86362001)(36756003)(103116003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:18:26.0289 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: edf990fd-4e92-4e8f-996c-08dac3ef992e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT098.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5975 Define missing assembly aliases for GIC registers on arm32, taking the ones defined already for arm64 as a base. Aliases are defined according to the GIC Architecture Specification ARM IHI 0069H. Defined the following registers:- 1. Interrupt Controller Interrupt Priority Mask Register 2. Interrupt Controller System Register Enable register 3. Interrupt Controller Deactivate Interrupt Register 4. Interrupt Controller End Of Interrupt Register 1 5. Interrupt Controller Interrupt Acknowledge Register 1 6. Interrupt Controller Binary Point Register 1 7. Interrupt Controller Control Register 8. Interrupt Controller Interrupt Group 1 Enable register 9. Interrupt Controller Maintenance Interrupt State Register 10. Interrupt Controller End of Interrupt Status Register 11. Interrupt Controller Empty List Register Status Register 12. Interrupt Controller Virtual Machine Control Register Signed-off-by: Ayan Kumar Halder --- Changes from :- v1 - 1. Moved coproc regs definition to asm/cpregs.h v2 - 1. Defined register alias. 2. Style issues. 3. Defined ELSR, MISR, EISR to make it consistent with AArch64. xen/arch/arm/include/asm/cpregs.h | 32 +++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h index 5331ec3448..0fc606fe99 100644 --- a/xen/arch/arm/include/asm/cpregs.h +++ b/xen/arch/arm/include/asm/cpregs.h @@ -161,6 +161,7 @@ #define DACR p15,0,c3,c0,0 /* Domain Access Control Register */ /* CP15 CR4: */ +#define ICC_PMR p15,0,c4,c6,0 /* Interrupt Priority Mask Register */ /* CP15 CR5: Fault Status Registers */ #define DFSR p15,0,c5,c0,0 /* Data Fault Status Register */ @@ -254,6 +255,8 @@ /* CP15 CR12: */ #define ICC_SGI1R p15,0,c12 /* Interrupt Controller SGI Group 1 */ +#define ICC_DIR p15,0,c12,c11,1 /* Interrupt Controller Deactivate Interrupt Register */ +#define ICC_SRE_L1 p15,0,c12,c12,5 /* Interrupt Controller System Register Enable register */ #define ICC_ASGI1R p15,1,c12 /* Interrupt Controller Alias SGI Group 1 Register */ #define ICC_SGI0R p15,2,c12 /* Interrupt Controller SGI Group 0 */ #define VBAR p15,0,c12,c0,0 /* Vector Base Address Register */ @@ -279,6 +282,19 @@ #define ICH_AP1R2 __AP1Rx(2) #define ICH_AP1R3 __AP1Rx(3) +#define ICC_IAR1 p15,0,c12,c12,0 /* Interrupt Controller Interrupt Acknowledge Register 1 */ +#define ICC_EOIR1 p15,0,c12,c12,1 /* Interrupt Controller End Of Interrupt Register 1 */ +#define ICC_BPR1 p15,0,c12,c12,3 /* Interrupt Controller Binary Point Register 1 */ +#define ICC_CTLR p15,0,c12,c12,4 /* Interrupt Controller Control Register */ +#define ICC_IGRPEN1 p15,0,c12,c12,7 /* Interrupt Controller Interrupt Group 1 Enable register */ +#define ICC_SRE p15,4,c12,c9,5 /* Interrupt Controller Hyp System Register Enable register */ +#define ICH_HCR p15,4,c12,c11,0 /* Interrupt Controller Hyp Control Register */ +#define ICH_VTR p15,4,c12,c11,1 /* Interrupt Controller VGIC Type Register */ +#define ICH_MISR p15,4,c12,c11,2 /* Interrupt Controller Maintenance Interrupt State Register */ +#define ICH_EISR p15,4,c12,c11,3 /* Interrupt Controller End of Interrupt Status Register */ +#define ICH_ELRSR p15,4,c12,c11,5 /* Interrupt Controller Empty List Register Status Register */ +#define ICH_VMCR p15,4,c12,c11,7 /* Interrupt Controller Virtual Machine Control Register */ + /* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ #define ___CP32(coproc, opc1, crn, crm, opc2) coproc, opc1, crn, crm, opc2 #define __LR0(x) ___CP32(p15, 4, c12, c12, x) @@ -380,6 +396,15 @@ #define HCR_EL2 HCR #define HPFAR_EL2 HPFAR #define HSTR_EL2 HSTR +#define ICC_BPR1_EL1 ICC_BPR1 +#define ICC_CTLR_EL1 ICC_CTLR +#define ICC_DIR_EL1 ICC_DIR +#define ICC_EOIR1_EL1 ICC_EOIR1 +#define ICC_IGRPEN1_EL1 ICC_IGRPEN1 +#define ICC_PMR_EL1 ICC_PMR +#define ICC_SGI1R_EL1 ICC_SGI1R +#define ICC_SRE_EL1 ICC_SRE_L1 +#define ICC_SRE_EL2 ICC_SRE #define ICH_AP0R0_EL2 ICH_AP0R0 #define ICH_AP0R1_EL2 ICH_AP0R1 #define ICH_AP0R2_EL2 ICH_AP0R2 @@ -388,6 +413,10 @@ #define ICH_AP1R1_EL2 ICH_AP1R1 #define ICH_AP1R2_EL2 ICH_AP1R2 #define ICH_AP1R3_EL2 ICH_AP1R3 +#define ICH_EISR_EL2 ICH_EISR +#define ICH_ELRSR_EL2 ICH_ELRSR +#define ICH_HCR_EL2 ICH_HCR +#define ICC_IAR1_EL1 ICC_IAR1 #define ICH_LR0_EL2 ICH_LR0 #define ICH_LR1_EL2 ICH_LR1 #define ICH_LR2_EL2 ICH_LR2 @@ -420,6 +449,9 @@ #define ICH_LRC13_EL2 ICH_LRC13 #define ICH_LRC14_EL2 ICH_LRC14 #define ICH_LRC15_EL2 ICH_LRC15 +#define ICH_MISR_EL2 ICH_MISR +#define ICH_VMCR_EL2 ICH_VMCR +#define ICH_VTR_EL2 ICH_VTR #define ID_AFR0_EL1 ID_AFR0 #define ID_DFR0_EL1 ID_DFR0 #define ID_DFR1_EL1 ID_DFR1 -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:18:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:18:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442581.696941 (Exim 4.92) (envelope-from ) id 1otUra-00021p-LX; Fri, 11 Nov 2022 14:18:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442581.696941; Fri, 11 Nov 2022 14:18:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUra-0001zb-F9; Fri, 11 Nov 2022 14:18:34 +0000 Received: by outflank-mailman (input) for mailman id 442581; Fri, 11 Nov 2022 14:18:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrZ-00085I-HQ for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:18:33 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20612.outbound.protection.outlook.com [2a01:111:f400:fe5b::612]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b8252356-61cb-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 15:18:32 +0100 (CET) Received: from BN0PR07CA0001.namprd07.prod.outlook.com (2603:10b6:408:141::12) by PH7PR12MB7209.namprd12.prod.outlook.com (2603:10b6:510:204::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 14:18:29 +0000 Received: from BN8NAM11FT034.eop-nam11.prod.protection.outlook.com (2603:10b6:408:141:cafe::49) by BN0PR07CA0001.outlook.office365.com (2603:10b6:408:141::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Fri, 11 Nov 2022 14:18:29 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT034.mail.protection.outlook.com (10.13.176.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 14:18:28 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:18:28 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 06:18:28 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 11 Nov 2022 08:18:26 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8252356-61cb-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H3mAgt6KPzjmOdXw8z4wOzoKbz+pd/alfqtEyBLF/n4q2MCRbAzg6Zu44rKU7cX9WpyquVR41higJ2Qdz83qdOy9ZEIr8krpBF0XsuXqvRW1GT/iJDeIh6eJFHp7Bhh99vvRMZW3vtldU52P10fBHTHsK0Pgqeajg24pLC4Nu2XjY43RsvTlDh21UsBxrYsXAxpij9jhDhreeT2sc6GdPLEgAABLjvQY5qgHWOmr//v3i9orKuFS66OPvKFj0z1pjsbep/U8ntQWXqFX/pqSMPXWmjP4b/ZX0jC4IKhmch7KDxdxd3EVN4Du6Wy94V20QbZvfCgIPH3Ey3fTdmgLAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1x+Puzll95MEDtEeq/rqhbLsQp4Myk6gWMYulb4I/w8=; b=fxUK2fB5c29H4g3lFQjHvlHl1Qu5EveoTP7/RpeXZAnvprfXnw+Rf2CrmAcE/t0iIARnhG/O+r41mZhqQCKSD+73z2nFp+mrfDWNlebkFy5VLSG1Ja6T6PGE/wXwS07LvlbaV7SGi+z32+fZ9lK4zHws7YVJi2ktgli2jPupaht64A3mnSA2QklwXl9a2vC5snNCUqcZUgo0mLTZbtHOZ5YXnDu37P758CL3gvWq10ZOnEIY60s7IahqVcyYvyW5nWoh+Se5LEksOdGzMHxIsMjiMThOeqD5bvKNXRZTPvOYfhPskIC0MHpGWcOWTHnUsvlxomrieXX/4ZydY1Lw6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1x+Puzll95MEDtEeq/rqhbLsQp4Myk6gWMYulb4I/w8=; b=VjPNbTclx+wX2TMIcN9P94s4hT5whkHBxajjmmbaPpyF9vDMK2azMX5FjbrL5KNTIvK8rKHq9GTy61PdWfvCe9ZkDVM3zwzxTjBFu6sLe4k7kN0z4rLhxHptma2I4eNB6w+eReDGqaaozPkeKAdOxSf5qWc61SoQY0HnRBzZxFE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v3 10/12] xen/Arm: GICv3: Use ULL instead of UL for 64bits Date: Fri, 11 Nov 2022 14:17:37 +0000 Message-ID: <20221111141739.2872-11-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221111141739.2872-1-ayan.kumar.halder@amd.com> References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT034:EE_|PH7PR12MB7209:EE_ X-MS-Office365-Filtering-Correlation-Id: 93dcf15a-3ba7-48bb-81b4-08dac3ef9ad1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4hoZao0metB8SjaRvJB6RFnU7zMBWoaIJ9SVfa9CmnVircOaD+fXqUBPAQucp0DiBEzG/CC2R7sMIMGPXLVl2uKQqkRAm8MxNvJaRK/uW+6ZTJ/fWAj/AfwSOB32rN+Y9zBVX/kOx2/3tIz4J1DNHdwhMTXAH6mTUO7x3GIm1OL8ZGp9B9r992oEXe5D4WLGiAQfFu16DYe5iO+wtQmkURHIQdiT1LxXEnL4nOvhA9/wFukh7JJUTZy8wVeTEjI8pFaT0/cldemBJPnuI1A0DyyI8Rexyf5cj4WgUhpztjKJPA2TLnWPy3+mJd/cfhj7kV/NvOu3zQDzMBlA3nzA5yx/4lqF82G9CrgTt6tPpxevr20PfdGtdJuwXegMnixD77VuZkfzo2G+yEUm2P3hcBfrqpgX2BVkhZsuQv32Q80EZlTg+DlVPCpzdhxOyT9H91ysH4U4+M/RjL6DQQF+Ll0myMBjggrqw75QYASF8me/ll4CvC1NbaNXbGgjI4wOPP1JJZhizyKDGsziUyZ/15g5OcOxzzzGBTbvgR+HHLyqDd0GARwIqehUI7cbKkSi1BgwIBvQy7eHPb1JCCZ9bvTbDyC6SrpyY0qOcWw+Fa1Fmxv6iB8p9a6/gXs+QtKVRGqs/hAQXgm2Gkg6rrDBhSVJ/6oacnXeYmVJgC8YA1lfHF3fWnrcSBWEwtunqWik0UWoPzvmEtM7L9SAIpdm7jgRRhh/lwnbjue+zpB16ay/jbqo8qTs+k2m7a9LU6wCdXjTM2ZAYZERP1nBMU9GOhQ9/rH8fUbEVhmbeQ/Rf7WKE8hjvXXaAHGI3gHzotDC X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(376002)(39860400002)(136003)(451199015)(36840700001)(40470700004)(46966006)(8676002)(36860700001)(4326008)(70206006)(36756003)(70586007)(26005)(81166007)(316002)(356005)(6916009)(103116003)(54906003)(40460700003)(186003)(5660300002)(426003)(47076005)(1076003)(40480700001)(2906002)(478600001)(336012)(86362001)(41300700001)(2616005)(8936002)(83380400001)(82310400005)(82740400003)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:18:28.7899 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93dcf15a-3ba7-48bb-81b4-08dac3ef9ad1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT034.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7209 "unsigned long long" is defined as 64 bits on AArch64 and AArch32 Thus, one should this instead of "unsigned long" which is 32 bits on AArch32. Also use 'PRIx64' instead of 'lx' or 'llx' to print uint64_t. Signed-off-by: Ayan Kumar Halder --- Changed from :- v1 - 1. Replace PRIu64 with PRIx64 so that the values are printed in hex as desired. 2. Use ULL in GITS_BASER_RO_MASK as MMIO registers are always unsigned. v2 - 1. Removed changes to ITS and LPI as they are not supported for AArch32. xen/arch/arm/gic-v3.c | 4 ++-- xen/arch/arm/include/asm/gic_v3_defs.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 4722bb4daf..6457e7033c 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v) if ( v == current ) { for ( i = 0; i < gicv3_info.nr_lrs; i++ ) - printk(" HW_LR[%d]=%llx\n", i, gicv3_ich_read_lr(i)); + printk(" HW_LR[%d]=%" PRIx64 "\n", i, gicv3_ich_read_lr(i)); } else { for ( i = 0; i < gicv3_info.nr_lrs; i++ ) - printk(" VCPU_LR[%d]=%llx\n", i, v->arch.gic.v3.lr[i]); + printk(" VCPU_LR[%d]=%" PRIx64 "\n", i, v->arch.gic.v3.lr[i]); } } diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h index 743ebb20fd..227533868f 100644 --- a/xen/arch/arm/include/asm/gic_v3_defs.h +++ b/xen/arch/arm/include/asm/gic_v3_defs.h @@ -195,7 +195,7 @@ #define ICH_SGI_IRQMODE_SHIFT 40 #define ICH_SGI_IRQMODE_MASK 0x1 -#define ICH_SGI_TARGET_OTHERS 1UL +#define ICH_SGI_TARGET_OTHERS 1ULL #define ICH_SGI_TARGET_LIST 0 #define ICH_SGI_IRQ_SHIFT 24 #define ICH_SGI_IRQ_MASK 0xf -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:18:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:18:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442585.696959 (Exim 4.92) (envelope-from ) id 1otUrh-00031Z-6d; Fri, 11 Nov 2022 14:18:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442585.696959; Fri, 11 Nov 2022 14:18:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrh-00031J-3Q; Fri, 11 Nov 2022 14:18:41 +0000 Received: by outflank-mailman (input) for mailman id 442585; Fri, 11 Nov 2022 14:18:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrf-00085I-No for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:18:39 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2072.outbound.protection.outlook.com [40.107.93.72]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bbe728aa-61cb-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 15:18:39 +0100 (CET) Received: from DS7PR03CA0145.namprd03.prod.outlook.com (2603:10b6:5:3b4::30) by DM4PR12MB7504.namprd12.prod.outlook.com (2603:10b6:8:110::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 14:18:35 +0000 Received: from DM6NAM11FT023.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b4:cafe::1d) by DS7PR03CA0145.outlook.office365.com (2603:10b6:5:3b4::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Fri, 11 Nov 2022 14:18:35 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT023.mail.protection.outlook.com (10.13.173.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 14:18:35 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:18:34 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:18:34 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 11 Nov 2022 08:18:32 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbe728aa-61cb-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AUusyGVrtXgm3jfhJhYpk/ozrC3Ol+6ckGPap16FHNK0ba2z6kqBOTb+NrYpAPcFea8TETzThNqE73psy3xSqWcs9kWKOcbzGA5eJ/2gpsGrJB/Gd4SS22TELMBvLzYHK2MDWIH9aW5mhaAb7lCKZhwR77exFirE4cryN/pTRLX77PMi1hsUJNgYYi+RWxDW2CCqynFIzgdvp5r/bXXuwAmE+i9HdbYvCkzhI70XWKlie7ahEeRkP/QI8H54iAOhE4jtKMV0bqfXpe4S9DTySIQRVarbbZfdj5DYXjnBILZyl1H4cHQjjRY7zzW82cH/dw/WyJ+ZkeNWzQ7/3pDPGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rC2CEEelnbLAOBw163E+15A6DiW8jj2UsQYupwZAM2g=; b=VrudPAi4VpiDe30AjvxZbeaHW4Bek0PUq3BLpSldrtc9iA575JkIPo1G0aM3w0yBttGbpM8XV9mw9RfpM8NKm6NR0txfeci9FcaWDeof1otUsywWAxWXaXDsC01zrhjSG4R8yzOcPM8qkp5vofKXVFFtxsn1Mj8OMEd4k3vb2cZCduX8e35O1S7jUqRBjZ6qiYbfayITZNnRt0MN+l561AOxRWicj+qBsF+kf8bd5MZRd2p/8uZiJb+ztRDS7Wfsnf6jhcauReH3gD/60Qugt1t800enDnFRQ1WggqHXFS8btXRiIRyuFktvdnm7vOklf4OhSm9TSVzIwP8EWrauag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rC2CEEelnbLAOBw163E+15A6DiW8jj2UsQYupwZAM2g=; b=TJULe66gespsRJW/aAzmTJEukRVB7dG5pEzYRxW2Os8K0bYhe01Ut2YT86Z6N/2XR87RFYwIBqIZkhxdQpNN2+Cyr+repK00F7rSbcZMyC6qSCOq83cnLflUg/xA7JN+cQue1RQpXsP2mTMFV8M91VwO5SMbbB9uiRN/CDyHGGE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v3 12/12] xen/Arm: GICv3: Enable GICv3 for AArch32 Date: Fri, 11 Nov 2022 14:17:39 +0000 Message-ID: <20221111141739.2872-13-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221111141739.2872-1-ayan.kumar.halder@amd.com> References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT023:EE_|DM4PR12MB7504:EE_ X-MS-Office365-Filtering-Correlation-Id: d7f5c4d0-fe23-4473-d92a-08dac3ef9ebd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aqB9KHBg2QXaAO7xJlTW79jqgvm85wELiz0N3uG5Bs+gicghnCa6F9H9hxxet7cVoVL/nYJqltUNgeC+5bdyhHsV0+8dgcpgrM+EKw8E6VF1lFLhZHFT9aiotBWBkVCkmURSACz+IgdoTJqsDq5vORmok3D7i1jyG2gmutkM9UObf7KPal9Si72eE6b3jWlzhudWISGpuxmLPhSmS02WIL+iGGQg+hBsIAs7mln8nNAPGzfTI3mCIMHbjVDwZwi4Qti3DepVgLbsCmpwmwBsTB6pZGy6AWjf/FShpTFGVxng68NE92HCqR8m7pZC7udltYFeFi1ieFBpDlp8R5NfvuGMxH0zO9T2qxGN8IuHNLg2dt68LUj1/euLND7feZ9gUtYTgMUD/MqXQdDnYZOkeq6qdT0wQd/bnvFC3lT85vZYfUJLwwlnIi+F3/Edb2TyrCOYZUDvOtt3h8UK8wyjY4k7ZhQoPws1/QGoO0x2wS6bJ26YE+E5r9nxkqnVcbF9ssQR0LH3LFaQ0F0L5E3qyQqCa19Fg2E1rICA/TeNemmY5oHRf3PafUkuzs0tQ1IQgBFPhXlEX/4WgeLSE7udYXeeS1XuN8D9c2O80dUKf2OHaS+vrqAph1ArIiuNnjQpfvma3PH8WXEU3YlMQ/A3AhS/dmfhHh9mhOIZqO2u9RCj91NuXWtxPdU4qhd5OrBmHcbcB8rZK6Bl3WQg6H+1GF+Rv9cr76X7jIaGZSAyLDjrE09GlpgK9Jo8lfxSwKdTqsEZPrcnNNF47QoWwy0Fv5fKd6CepjaaKkhFUK+4/ik7y2t8hQ41z7bcLZfziVvm X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(396003)(136003)(376002)(451199015)(46966006)(36840700001)(40470700004)(356005)(36860700001)(6916009)(81166007)(2906002)(82740400003)(86362001)(316002)(82310400005)(54906003)(5660300002)(426003)(70586007)(336012)(70206006)(4326008)(1076003)(2616005)(186003)(8676002)(47076005)(41300700001)(40460700003)(8936002)(83380400001)(478600001)(26005)(40480700001)(103116003)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:18:35.2157 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d7f5c4d0-fe23-4473-d92a-08dac3ef9ebd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT023.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7504 One can now use GICv3 on AArch32 systems. However, ITS is not supported. The reason being currently we are trying to validate GICv3 on an AArch32_v8R system. Refer ARM DDI 0568A.c ID110520, B1.3.1, "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE must not implement LPI support." By default GICv3 is disabled on AArch32 and enabled on AArch64. Updated SUPPORT.md to state that GICv3 on Arm32 is not security supported. Signed-off-by: Ayan Kumar Halder --- Changed from :- v1 - 1. Remove "ARM_64 || ARM_32" as it is always true. 2. Updated SUPPORT.md. v2 - 1. GICv3 is enabled by default only on ARM_64. 2. Updated SUPPORT.md. SUPPORT.md | 7 +++++++ xen/arch/arm/Kconfig | 9 +++++---- xen/arch/arm/include/asm/cpufeature.h | 1 + 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/SUPPORT.md b/SUPPORT.md index ab71464cf6..3f16d83191 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -82,6 +82,13 @@ Extension to the GICv3 interrupt controller to support MSI. Status: Experimental +### ARM/GICv3 + +GICv3 is an interrupt controller specification designed by Arm. + + Status, Arm64: Security supported + Status, Arm32: Supported, not security supported + ## Guest Type ### x86/PV diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 1fe5faf847..b90930955b 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -9,6 +9,7 @@ config ARM_64 select 64BIT select ARM_EFI select HAS_FAST_MULTIPLY + select GICV3 config ARM def_bool y @@ -41,16 +42,16 @@ config ARM_EFI config GICV3 bool "GICv3 driver" - depends on ARM_64 && !NEW_VGIC - default y + depends on !NEW_VGIC + default n ---help--- Driver for the ARM Generic Interrupt Controller v3. - If unsure, say Y + If unsure, say N config HAS_ITS bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED - depends on GICV3 && !NEW_VGIC + depends on GICV3 && !NEW_VGIC && !ARM_32 config HVM def_bool y diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h index c86a2e7f29..c62cf6293f 100644 --- a/xen/arch/arm/include/asm/cpufeature.h +++ b/xen/arch/arm/include/asm/cpufeature.h @@ -33,6 +33,7 @@ #define cpu_has_aarch32 (cpu_has_arm || cpu_has_thumb) #ifdef CONFIG_ARM_32 +#define cpu_has_gicv3 (boot_cpu_feature32(gic) >= 1) #define cpu_has_gentimer (boot_cpu_feature32(gentimer) == 1) /* * On Armv7, the value 0 is used to indicate that PMUv2 is not -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:25:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:25:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442611.696969 (Exim 4.92) (envelope-from ) id 1otUyM-0006Jt-2m; Fri, 11 Nov 2022 14:25:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442611.696969; Fri, 11 Nov 2022 14:25:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUyL-0006JT-Vv; Fri, 11 Nov 2022 14:25:33 +0000 Received: by outflank-mailman (input) for mailman id 442611; Fri, 11 Nov 2022 14:25:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otUrb-0006iO-Ut for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:18:36 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2063.outbound.protection.outlook.com [40.107.223.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9c8a642-61cb-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 15:18:35 +0100 (CET) Received: from BN9PR03CA0666.namprd03.prod.outlook.com (2603:10b6:408:10e::11) by DS0PR12MB6533.namprd12.prod.outlook.com (2603:10b6:8:c2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Fri, 11 Nov 2022 14:18:31 +0000 Received: from BN8NAM11FT031.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10e:cafe::25) by BN9PR03CA0666.outlook.office365.com (2603:10b6:408:10e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Fri, 11 Nov 2022 14:18:31 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT031.mail.protection.outlook.com (10.13.177.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 14:18:31 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:18:31 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 08:18:31 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend Transport; Fri, 11 Nov 2022 08:18:29 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9c8a642-61cb-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V8N+/7J6PtYsQ7nQ8SIKMSDRIvLGgTAlvWhZCOfvgLlSYBn6PjGaadupH7W+XJXkIuxyElxp2LVNsPOEIM4FY7IlJXakcfveOUWYSqXWukmXCgbr/SRhTyFaPbo2qsLCxS3LXOBCMHMvuW6DF5G4Vi/qWs9IoBIQzsXyLip6HvE6x2h64lR2mpPCl6WF8hwT2X6ja1T/w2Ah68TQd7WTiWiRGU4YTXj7Zd9RPppLNbJqXXY7c+2krKrmmre1h/2asMHCrRUO7CVrDjLB9kfgs4TUjNhdyhP4MGEjeYs1dRVA5AjyRbQG5e/eZpvvoW9qg4Q6BNSyXr4nT1m4Np+ZIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KCUBl3NeZdaqie+yGuXB6G+9OD+z9IExC+PESznGZWc=; b=aX0ucPRRZT0OlD7JqH1MCOmACymYYRWqRJHlRrSmfw5KwdjJ1q63r2yC+Agm9UVMRS2g0E3nTVC5YEyd8e6WCCsKG6ayJzPQ5LXeG7B3XjmfcE9HS3BZyGy6exaJfKc9ZtO23BYZaEwz5+YdI60H44j31It9yJYzbWFbyz5vG131gCsIYLP1TiVP+XB0g/YCCubqlXUgbLzsEbXqK9GVfSNdHnxdMRjCvOcX+g9lXgC6LfNNW5qlWJQL3zN9IYhJPaMkXte5FnTAObluwzLKy9KGpRh8+5i1n068wxIVtLD6lef9f/lIL5w6qpZ5zQg7QKIIsD6X4VY5lqylqna/gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KCUBl3NeZdaqie+yGuXB6G+9OD+z9IExC+PESznGZWc=; b=IzP5t8nU6b3ywdKAjRpN/RNVsh8sr46Mv7JUqrEOtz6vz2QXiXlgeOyk7wtshhTH13hc+h/NURloj7pbtgm5qlQugCFRtKurUp5U1i5qj7I1IGvJooTpmchzYf7G0b4sbGQFpUOMbd0S5vNB5/5RCi8h0+Zb5uvW16WQjBtPXY4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v3 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit Date: Fri, 11 Nov 2022 14:17:38 +0000 Message-ID: <20221111141739.2872-12-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221111141739.2872-1-ayan.kumar.halder@amd.com> References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT031:EE_|DS0PR12MB6533:EE_ X-MS-Office365-Filtering-Correlation-Id: 1cc6be3e-67fd-4adb-65b9-08dac3ef9c89 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LHZcWIeBuwwmekOZdYAda5ghfomTC6sxjuyLA455dMXwtkHp0WZv6nQhMB2cLidFUL5vufaGrUYR/d8JWhfRhN4G/8OCBqo1fMxcSbYv1oVYI6jLXY2MQKVBX7Jds7V5Kfjc5fP1u0VpXLriK++ioe7C/QWwHJOg1se0ZmDXsH46n09FQtXcBNnKzVgLMaaD0o7/SdaN4Or1BgFE/L9jROeyWyKxOJio4rnAj00nWm7krui0gQA85hexdFB0SV8TPrn5OTCxpi09zUWQ2n47b7+FlshAwpC+XHU4tbwl9mD+eQOuAfe85YFaYgw1vpPfiFlIcXbNk8iChvv41dZYZ68rqInUDjCplkrqmr+WeGylSUamRucFs1MEnjuJtkUnzWYRP1qaNz2fPPiXZu0h7yaNub4mIeE0hXIfyEUtcS0JADEidUAJdx0pYjFDHJT7j0NfXHN/I4ThWzF9ZLkKVaIIGPndU2K2UuwLJ1KNOnyG5QxQnmPpsxR6HkW5idVx5NAWpAJSYEpxpfJwsdu5BngmgR+uIgzeYccaQVcPZ8wbKD0JqmynWCOef7N4KTJZBsNvwf7cQ7UhNQmV6s1fr1o4QW6tCngHvGH+MkQtRflRg9ELar6W5K8C1VuuZxeM6Nkd9zwuhN2R4vrn0hsJ1n8kD3iY9Lgibti77MQEPBciKqbibsutSG58HpzXy/yDAKnRybUNpnR5VNtwTrnPT6NLkBRDCabBv8BcsVvt4AbvxMauo4dPWrBsB3JahXqlt3jrCbWNtXvtoGaMAfX+FeVO0GgfafNkVk5XSV5Cy8RhYIvPzcuDFHpA8F+clR6N X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(70586007)(86362001)(6666004)(478600001)(336012)(8676002)(6916009)(41300700001)(316002)(40460700003)(26005)(5660300002)(103116003)(1076003)(70206006)(2616005)(4326008)(36756003)(186003)(2906002)(83380400001)(82740400003)(82310400005)(47076005)(426003)(8936002)(54906003)(40480700001)(36860700001)(356005)(81166007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:18:31.6728 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1cc6be3e-67fd-4adb-65b9-08dac3ef9c89 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT031.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6533 On AArch32, ldrd/strd instructions are not atomic when used to access MMIO. Furthermore, ldrd/strd instructions are not decoded by Arm when running as a guest to access emulated MMIO region. Thus, we have defined readq_relaxed_non_atomic()/writeq_relaxed_non_atomic() which in turn calls readl_relaxed()/writel_relaxed() for the lower and upper 32 bits. As GICv3 registers (GICD_IROUTER, GICR_TYPER) can be accessed in a non atomic fashion, so we have used {read/write}q_relaxed_non_atomic() on Arm32. Signed-off-by: Ayan Kumar Halder --- Changes from :- v1 - 1. Use ldrd/strd for readq_relaxed()/writeq_relaxed(). 2. No need to use le64_to_cpu() as the returned byte order is already in cpu endianess. v2 - 1. Replace {read/write}q_relaxed with {read/write}q_relaxed_non_atomic(). xen/arch/arm/gic-v3.c | 12 ++++++++++++ xen/arch/arm/include/asm/arm32/io.h | 9 +++++++++ 2 files changed, 21 insertions(+) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 6457e7033c..a5bc549765 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -651,7 +651,11 @@ static void __init gicv3_dist_init(void) affinity &= ~GICD_IROUTER_SPI_MODE_ANY; for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i++ ) +#ifdef CONFIG_ARM_32 + writeq_relaxed_non_atomic(affinity, GICD + GICD_IROUTER + i * 8); +#else writeq_relaxed(affinity, GICD + GICD_IROUTER + i * 8); +#endif } static int gicv3_enable_redist(void) @@ -745,7 +749,11 @@ static int __init gicv3_populate_rdist(void) } do { +#ifdef CONFIG_ARM_32 + typer = readq_relaxed_non_atomic(ptr + GICR_TYPER); +#else typer = readq_relaxed(ptr + GICR_TYPER); +#endif if ( (typer >> 32) == aff ) { @@ -1265,7 +1273,11 @@ static void gicv3_irq_set_affinity(struct irq_desc *desc, const cpumask_t *mask) affinity &= ~GICD_IROUTER_SPI_MODE_ANY; if ( desc->irq >= NR_GIC_LOCAL_IRQS ) +#ifdef CONFIG_ARM_32 + writeq_relaxed_non_atomic(affinity, (GICD + GICD_IROUTER + desc->irq * 8)); +#else writeq_relaxed(affinity, (GICD + GICD_IROUTER + desc->irq * 8)); +#endif spin_unlock(&gicv3.lock); } diff --git a/xen/arch/arm/include/asm/arm32/io.h b/xen/arch/arm/include/asm/arm32/io.h index 73a879e9fb..4ddfbea5c2 100644 --- a/xen/arch/arm/include/asm/arm32/io.h +++ b/xen/arch/arm/include/asm/arm32/io.h @@ -80,17 +80,26 @@ static inline u32 __raw_readl(const volatile void __iomem *addr) __raw_readw(c)); __r; }) #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \ __raw_readl(c)); __r; }) +#define readq_relaxed_non_atomic(c) \ + ({ u64 __r = (((u64)readl_relaxed((c) + 4)) << 32) | \ + readl_relaxed(c); __r; }) #define writeb_relaxed(v,c) __raw_writeb(v,c) #define writew_relaxed(v,c) __raw_writew((__force u16) cpu_to_le16(v),c) #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c) +#define writeq_relaxed_non_atomic(v,c) \ + ({ writel_relaxed((u32)v, c); \ + writel_relaxed((u32)((v) >> 32), (c) + 4); }) #define readb(c) ({ u8 __v = readb_relaxed(c); __iormb(); __v; }) #define readw(c) ({ u16 __v = readw_relaxed(c); __iormb(); __v; }) #define readl(c) ({ u32 __v = readl_relaxed(c); __iormb(); __v; }) +#define readq(c) ({ u64 __v = readq_relaxed_non_atomic(c); \ + __iormb(); __v; }) #define writeb(v,c) ({ __iowmb(); writeb_relaxed(v,c); }) #define writew(v,c) ({ __iowmb(); writew_relaxed(v,c); }) #define writel(v,c) ({ __iowmb(); writel_relaxed(v,c); }) +#define writeq(v,c) ({ __iowmb(); writeq_relaxed_non_atomic(v,c); }) #endif /* _ARM_ARM32_IO_H */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:42:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:42:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442623.696981 (Exim 4.92) (envelope-from ) id 1otVEU-0000SW-EY; Fri, 11 Nov 2022 14:42:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442623.696981; Fri, 11 Nov 2022 14:42:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otVEU-0000SP-Bc; Fri, 11 Nov 2022 14:42:14 +0000 Received: by outflank-mailman (input) for mailman id 442623; Fri, 11 Nov 2022 14:42:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otVET-0000SJ-0a for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:42:13 +0000 Received: from smarthost01c.sbp.mail.zen.net.uk (smarthost01c.sbp.mail.zen.net.uk [212.23.1.5]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 061abaac-61cf-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 15:42:11 +0100 (CET) Received: from [82.70.146.41] (helo=pear.davidvrabel.org.uk) by smarthost01c.sbp.mail.zen.net.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otVEO-0006Et-Mx; Fri, 11 Nov 2022 14:42:08 +0000 Received: from apple.davidvrabel.org.uk ([82.70.146.43]) by pear.davidvrabel.org.uk with esmtp (Exim 4.94.2) (envelope-from ) id 1otVEE-000WAF-6k; Fri, 11 Nov 2022 14:42:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 061abaac-61cf-11ed-91b6-6bf2151ebd3b Message-ID: <2991d69a-eb13-7044-d65f-14540676e642@cantab.net> Date: Fri, 11 Nov 2022 14:41:58 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , David Vrabel , xen-devel@lists.xenproject.org References: <20221110165935.106376-1-dvrabel@amazon.co.uk> <20221110165935.106376-3-dvrabel@amazon.co.uk> <29e6e6ca-ffb8-3719-5004-0cccaeb5578b@suse.com> Content-Language: en-GB From: David Vrabel In-Reply-To: <29e6e6ca-ffb8-3719-5004-0cccaeb5578b@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 82.70.146.43 X-SA-Exim-Mail-From: dvrabel@cantab.net X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pear.davidvrabel.org.uk X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_SOFTFAIL autolearn=ham autolearn_force=no version=3.4.6 Subject: Re: [PATCH 2/3] x86/msi: remove return value from msi_set_mask_bit() X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on pear.davidvrabel.org.uk) X-Originating-smarthost01c-IP: [82.70.146.41] Feedback-ID: 82.70.146.41 On 11/11/2022 09:44, Jan Beulich wrote: > > The idea of the WARN() / BUG_ON() is to > - not leave failed unmasking unrecorded, > - not continue after failure to mask an entry. Then lets make msi_set_mask_bit() unable to fail with something like this (untested) patch. Would this be acceptable? David From 837649a70d44455f4fd98e2eaa46dcf35a56d00a Mon Sep 17 00:00:00 2001 From: David Vrabel Date: Fri, 11 Nov 2022 14:30:16 +0000 Subject: [PATCH] x86: Always enable memory space decodes when using MSI-X Instead of the numerous (racy) checks for memory space accesses being enabled before writing the the MSI-X table, force Memory Space Enable to be set in the Command register if MSI-X is used. This allows the memory_decoded() function and the associated error paths to be removed (since it will always return true). In particular, msi_set_mask_bit() can no longer fail and its return value is removed. Note that if the PCI device is a virtual function, the relevant command register is in the corresponding physical function. Signed-off-by: David Vrabel --- xen/arch/x86/include/asm/pci.h | 3 + xen/arch/x86/msi.c | 116 +++++++++------------------------ xen/arch/x86/pci.c | 39 ++++++++++- 3 files changed, 71 insertions(+), 87 deletions(-) diff --git a/xen/arch/x86/include/asm/pci.h b/xen/arch/x86/include/asm/pci.h index f4a58c8acf..4f59b70959 100644 --- a/xen/arch/x86/include/asm/pci.h +++ b/xen/arch/x86/include/asm/pci.h @@ -32,8 +32,11 @@ struct arch_pci_dev { domid_t pseudo_domid; mfn_t leaf_mfn; struct page_list_head pgtables_list; + uint16_t host_command; + uint16_t guest_command; }; +void pci_command_override(struct pci_dev *pdev, uint16_t val); int pci_conf_write_intercept(unsigned int seg, unsigned int bdf, unsigned int reg, unsigned int size, uint32_t *data); diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index d0bf63df1d..2f8667aa7b 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -124,27 +124,11 @@ static void msix_put_fixmap(struct arch_msix *msix, int idx) spin_unlock(&msix->table_lock); } -static bool memory_decoded(const struct pci_dev *dev) -{ - pci_sbdf_t sbdf = dev->sbdf; - - if ( dev->info.is_virtfn ) - { - sbdf.bus = dev->info.physfn.bus; - sbdf.devfn = dev->info.physfn.devfn; - } - - return pci_conf_read16(sbdf, PCI_COMMAND) & PCI_COMMAND_MEMORY; -} - static bool msix_memory_decoded(const struct pci_dev *dev, unsigned int pos) { uint16_t control = pci_conf_read16(dev->sbdf, msix_control_reg(pos)); - if ( !(control & PCI_MSIX_FLAGS_ENABLE) ) - return false; - - return memory_decoded(dev); + return control & PCI_MSIX_FLAGS_ENABLE; } /* @@ -314,7 +298,7 @@ int msi_maskable_irq(const struct msi_desc *entry) || entry->msi_attrib.maskbit; } -static bool msi_set_mask_bit(struct irq_desc *desc, bool host, bool guest) +static void msi_set_mask_bit(struct irq_desc *desc, bool host, bool guest) { struct msi_desc *entry = desc->msi_desc; struct pci_dev *pdev; @@ -354,45 +338,26 @@ static bool msi_set_mask_bit(struct irq_desc *desc, bool host, bool guest) control | (PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL)); } - if ( likely(memory_decoded(pdev)) ) - { - writel(flag, entry->mask_base + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET); - readl(entry->mask_base + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET); - if ( likely(control & PCI_MSIX_FLAGS_ENABLE) ) - break; - - entry->msi_attrib.host_masked = host; - entry->msi_attrib.guest_masked = guest; + writel(flag, entry->mask_base + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET); + readl(entry->mask_base + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET); - flag = true; - } - else if ( flag && !(control & PCI_MSIX_FLAGS_MASKALL) ) + if ( unlikely(!(control & PCI_MSIX_FLAGS_ENABLE)) ) { - domid_t domid = pdev->domain->domain_id; - - maskall = true; - if ( pdev->msix->warned != domid ) - { - pdev->msix->warned = domid; - printk(XENLOG_G_WARNING - "cannot mask IRQ %d: masking MSI-X on Dom%d's %pp\n", - desc->irq, domid, &pdev->sbdf); - } + pdev->msix->host_maskall = maskall; + if ( maskall || pdev->msix->guest_maskall ) + control |= PCI_MSIX_FLAGS_MASKALL; + pci_conf_write16(pdev->sbdf, + msix_control_reg(entry->msi_attrib.pos), control); } - pdev->msix->host_maskall = maskall; - if ( maskall || pdev->msix->guest_maskall ) - control |= PCI_MSIX_FLAGS_MASKALL; - pci_conf_write16(pdev->sbdf, - msix_control_reg(entry->msi_attrib.pos), control); - return flag; + break; default: - return 0; + ASSERT_UNREACHABLE(); + break; } + entry->msi_attrib.host_masked = host; entry->msi_attrib.guest_masked = guest; - - return 1; } static int msi_get_mask_bit(const struct msi_desc *entry) @@ -418,16 +383,12 @@ static int msi_get_mask_bit(const struct msi_desc *entry) void cf_check mask_msi_irq(struct irq_desc *desc) { - if ( unlikely(!msi_set_mask_bit(desc, 1, - desc->msi_desc->msi_attrib.guest_masked)) ) - BUG_ON(!(desc->status & IRQ_DISABLED)); + msi_set_mask_bit(desc, 1, desc->msi_desc->msi_attrib.guest_masked); } void cf_check unmask_msi_irq(struct irq_desc *desc) { - if ( unlikely(!msi_set_mask_bit(desc, 0, - desc->msi_desc->msi_attrib.guest_masked)) ) - WARN(); + msi_set_mask_bit(desc, 0, desc->msi_desc->msi_attrib.guest_masked); } void guest_mask_msi_irq(struct irq_desc *desc, bool mask) @@ -437,15 +398,13 @@ void guest_mask_msi_irq(struct irq_desc *desc, bool mask) static unsigned int cf_check startup_msi_irq(struct irq_desc *desc) { - if ( unlikely(!msi_set_mask_bit(desc, 0, !!(desc->status & IRQ_GUEST))) ) - WARN(); + msi_set_mask_bit(desc, 0, !!(desc->status & IRQ_GUEST)); return 0; } static void cf_check shutdown_msi_irq(struct irq_desc *desc) { - if ( unlikely(!msi_set_mask_bit(desc, 1, 1)) ) - BUG_ON(!(desc->status & IRQ_DISABLED)); + msi_set_mask_bit(desc, 1, 1); } void cf_check ack_nonmaskable_msi_irq(struct irq_desc *desc) @@ -785,6 +744,12 @@ static int msix_capability_init(struct pci_dev *dev, ASSERT(pcidevs_locked()); + /* + * Force enable access to the MSI-X tables, so access to the + * per-vector mask bits always works. + */ + pci_command_override(dev, PCI_COMMAND_MEMORY); + control = pci_conf_read16(dev->sbdf, msix_control_reg(pos)); /* * Ensure MSI-X interrupts are masked during setup. Some devices require @@ -797,13 +762,6 @@ static int msix_capability_init(struct pci_dev *dev, control | (PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL)); - if ( unlikely(!memory_decoded(dev)) ) - { - pci_conf_write16(dev->sbdf, msix_control_reg(pos), - control & ~PCI_MSIX_FLAGS_ENABLE); - return -ENXIO; - } - if ( desc ) { entry = alloc_msi_entry(1); @@ -1122,19 +1080,15 @@ static void __pci_disable_msix(struct msi_desc *entry) BUG_ON(list_empty(&dev->msi_list)); - if ( likely(memory_decoded(dev)) ) - writel(1, entry->mask_base + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET); - else if ( !(control & PCI_MSIX_FLAGS_MASKALL) ) - { - printk(XENLOG_WARNING "cannot disable IRQ %d: masking MSI-X on %pp\n", - entry->irq, &dev->sbdf); - maskall = true; - } + writel(1, entry->mask_base + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET); + dev->msix->host_maskall = maskall; if ( maskall || dev->msix->guest_maskall ) control |= PCI_MSIX_FLAGS_MASKALL; pci_conf_write16(dev->sbdf, msix_control_reg(pos), control); + pci_command_override(dev, 0); + _pci_cleanup_msix(dev->msix); } @@ -1353,13 +1307,6 @@ int pci_restore_msi_state(struct pci_dev *pdev) pci_conf_write16(pdev->sbdf, msix_control_reg(pos), control | (PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL)); - if ( unlikely(!memory_decoded(pdev)) ) - { - spin_unlock_irqrestore(&desc->lock, flags); - pci_conf_write16(pdev->sbdf, msix_control_reg(pos), - control & ~PCI_MSIX_FLAGS_ENABLE); - return -ENXIO; - } } type = entry->msi_attrib.type; @@ -1368,10 +1315,9 @@ int pci_restore_msi_state(struct pci_dev *pdev) for ( i = 0; ; ) { - if ( unlikely(!msi_set_mask_bit(desc, - entry[i].msi_attrib.host_masked, - entry[i].msi_attrib.guest_masked)) ) - BUG(); + msi_set_mask_bit(desc, + entry[i].msi_attrib.host_masked, + entry[i].msi_attrib.guest_masked); if ( !--nr ) break; diff --git a/xen/arch/x86/pci.c b/xen/arch/x86/pci.c index 97b792e578..0c4b49f042 100644 --- a/xen/arch/x86/pci.c +++ b/xen/arch/x86/pci.c @@ -69,6 +69,24 @@ void pci_conf_write(uint32_t cf8, uint8_t offset, uint8_t bytes, uint32_t data) spin_unlock_irqrestore(&pci_config_lock, flags); } +void pci_command_override(struct pci_dev *pdev, uint16_t val) +{ + pci_sbdf_t sbdf = pdev->sbdf; + + ASSERT(pcidevs_locked()); + + if ( pdev->info.is_virtfn ) + { + sbdf.bus = pdev->info.physfn.bus; + sbdf.devfn = pdev->info.physfn.devfn; + + pdev = pci_get_pdev(NULL, sbdf); + } + + pdev->arch.host_command = val; + pci_conf_write16(sbdf, PCI_COMMAND, pdev->arch.host_command | pdev->arch.guest_command); +} + int pci_conf_write_intercept(unsigned int seg, unsigned int bdf, unsigned int reg, unsigned int size, uint32_t *data) @@ -85,14 +103,31 @@ int pci_conf_write_intercept(unsigned int seg, unsigned int bdf, * Avoid expensive operations when no hook is going to do anything * for the access anyway. */ - if ( reg < 64 || reg >= 256 ) + if ( reg != PCI_COMMAND && (reg < 64 || reg >= 256) ) return 0; pcidevs_lock(); pdev = pci_get_pdev(NULL, PCI_SBDF(seg, bdf)); if ( pdev ) - rc = pci_msi_conf_write_intercept(pdev, reg, size, data); + { + switch ( reg ) + { + case PCI_COMMAND: + if ( size == 2 ) + { + pdev->arch.guest_command = *data; + *data |= pdev->arch.host_command; + } + else + rc = -EACCESS; + break; + + default: + rc = pci_msi_conf_write_intercept(pdev, reg, size, data); + break; + } + } pcidevs_unlock(); -- 2.37.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:48:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:48:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442629.696992 (Exim 4.92) (envelope-from ) id 1otVKf-0001LB-6m; Fri, 11 Nov 2022 14:48:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442629.696992; Fri, 11 Nov 2022 14:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otVKf-0001L4-30; Fri, 11 Nov 2022 14:48:37 +0000 Received: by outflank-mailman (input) for mailman id 442629; Fri, 11 Nov 2022 14:48:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otVKd-0001Ky-2K for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:48:35 +0000 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [2607:f8b0:4864:20::1029]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e9d6d13f-61cf-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 15:48:33 +0100 (CET) Received: by mail-pj1-x1029.google.com with SMTP id q1-20020a17090a750100b002139ec1e999so4898319pjk.1 for ; Fri, 11 Nov 2022 06:48:33 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9d6d13f-61cf-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IhWJ2nLOKJu8brLADrOERw4TNBcH2kQxpA6zIJNjozs=; b=dEtrqs4York8w/lGHpP+yDOG5OEboeDpOIo+L5WqUX7bmdympj9nybP4eSytGPAZQ/ stbe/MqTf/e3JdBEw3T3/Avwcpq34GdYwD6n5rM+eQH4wmHvTnbbQOCwetqwCGxc1llV jNLTRo90w9m2rnFKcSs4WIXz9ti83M4Mm4zDfwmvnjEXAsYdcFdiw8zLIQJeZyLsHJcQ 2hyPi3JRNDWgwQ1pKVg5u2RCR1bJExZ9ZwtulE4yVdhvpZDzwjVkMuvt9mOl8rS/seYP qD/l4Fs5FgGFeLcTQT9fB5gib5uMYFvU7lvwjaNxOWpPFc9NwT+khPIn/a7+Z65NjnmN FcvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IhWJ2nLOKJu8brLADrOERw4TNBcH2kQxpA6zIJNjozs=; b=RsFpY91d94uKnCdlc7iEVwCFM7H6l5VD9NdVyJJtB+pgVqJ8a1On6K5z23thbAjXuY 5gS8/K3llt2rbEHaVo54tEruUK7xcNyD6pyGVJvca7OX5DT7Hx/qJarI92zlrw4bDrjW y+LBJT8EcTVPrnQOKrvKRXv7eN2NOfhK7o6CRKREl4a1MvOxja6fESVepyK3tw4k6oEh hhN0S303oR5DToWicizYSsUhOQhqb+NdtlD6TKgbp29tAYHG1ZZ7O6iL+xpscbfbYqIj FLGd9KW6/32M9r2N3bnqt5LVxvFdfl2Hjp157G/dUfJJRojYjt8QYy82THISFRAsKClR ZPyQ== X-Gm-Message-State: ANoB5plFIduqDSsoJSuErLwdOd/VC3jlLYxBDwp4Q/NeADJcy0RweFJA i9jyIVbPbR2CxL9dCFvhCz06VO5lPwA8hR3GStQ= X-Google-Smtp-Source: AA0mqf4H1yoeVxLU98n1XLKOYks3RamLzGyjbmjJ/GqJtIAuMQeqv1N5M0gvruyjDPZYPUDqy9DYHkJ8hXRFm6+opKA= X-Received: by 2002:a17:902:70c1:b0:188:77a7:eb5 with SMTP id l1-20020a17090270c100b0018877a70eb5mr2666367plt.6.1668178111994; Fri, 11 Nov 2022 06:48:31 -0800 (PST) MIME-Version: 1.0 References: <20221111112208.451449-1-Henry.Wang@arm.com> <20221111112208.451449-3-Henry.Wang@arm.com> In-Reply-To: <20221111112208.451449-3-Henry.Wang@arm.com> From: Oleksandr Tyshchenko Date: Fri, 11 Nov 2022 14:48:20 +0000 Message-ID: Subject: Re: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release To: Henry Wang Cc: xen-devel Content-Type: multipart/alternative; boundary="000000000000c9a02705ed32fbc8" --000000000000c9a02705ed32fbc8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Nov 11, 2022 at 11:23 AM Henry Wang wrote: Hello Henry [leave only xen-devel@lists.xenproject.org in CC] [sorry for the possible format issues] Signed-off-by: Henry Wang > --- > CHANGELOG.md | 29 +++++++++++++++++++++++++++-- > 1 file changed, 27 insertions(+), 2 deletions(-) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index adbbb216fa..fa8cc476b3 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -4,16 +4,41 @@ Notable changes to Xen will be documented in this file. > > The format is based on [Keep a Changelog]( > https://keepachangelog.com/en/1.0.0/) > > -## [unstable UNRELEASED]( > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dshortlog;h=3Dstaging) - T= BD > +## [4.17.0]( > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dshortlog;h=3Dstaging) - > 2022-11-?? > > ### Changed > - On x86 "vga=3Dcurrent" can now be used together with GrUB2's gfxpaylo= ad > setting. Note that > this requires use of "multiboot2" (and "module2") as the GrUB command= s > loading Xen. > + - The "gnttab" option now has a new command line sub-option for > disabling the > + GNTTABOP_transfer functionality. > + - The x86 MCE command line option info is now updated. > > ### Added / support upgraded > + - Out-of-tree builds for the hypervisor now supported. > + - The project has officially adopted 4 directives and 24 rules of > MISRA-C, > + added MISRA-C checker build integration, and defined how to document > + deviations. > - IOMMU superpage support on x86, affecting PV guests as well as HVM/PV= H > ones > when they don't share page tables with the CPU (HAP / EPT / NPT). > - - Support VIRT_SSBD feature for HVM guests on AMD. > + - Support VIRT_SSBD feature for HVM guests on AMD and MSR_SPEC_CTRL > feature for > + SVM guests. > + - Improved TSC, CPU frequency calibration and APIC on x86. > + - Improved support for CET Indirect Branch Tracking on x86. > + - Improved mwait-idle support for SPR and ADL on x86. > + - Extend security support for hosts to 12 TiB of memory on x86. > + - Add command line option to set cpuid parameters for dom0 at boot time > on x86. > + - Improved static configuration options on Arm. > + - cpupools can be specified at boot using device tree on Arm. > + - It is possible to use PV drivers with dom0less guests, allowing > statically > + booted dom0less guests with PV devices. > + - On Arm, p2m structures are now allocated out of a pool of memory set > aside at > + domain creation. > + - Improved mitigations against Spectre-BHB on Arm. > + - Add support for VirtIO toolstack on Arm. > I would clarify that only virtio-mmio is supported on Arm. > + - Allow setting the number of CPUs to activate at runtime from command > line > + option on Arm. > + - Improved toolstack build system. > + - Add Xue - console over USB 3 Debug Capability. > I would probably also add the following: - Add Renesas R-Car Gen4 IPMMU-VMSA support (Arm) - grant-table support on Arm was improved and hardened by implementing =E2=80=9Csimplified M2P-like approach for the xenheap pages=E2=80=9D > > ### Removed / support downgraded > - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" > command line options > -- > 2.25.1 > > > --=20 Regards, Oleksandr Tyshchenko --000000000000c9a02705ed32fbc8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Nov 11, 2022 at 11:23 AM Henr= y Wang <Henry.Wa= ng@arm.com> wrote:
Hello Henry

[leave only xen-devel@lists.xenproject.org in CC]
[sorry for the possible format issues]

Signed-off-by: Henry Wang <Henry.Wang@arm.com>
---
=C2=A0CHANGELOG.md | 29 +++++++++++++++++++++++++++--
=C2=A01 file changed, 27 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index adbbb216fa..fa8cc476b3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,16 +4,41 @@ Notable changes to Xen will be documented in this file.
=C2=A0The format is based on [Keep a Changelog](https://keepacha= ngelog.com/en/1.0.0/)

-## [unstable UNRELEASED](https:= //xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dshortlog;h=3Dstaging) - TBD +## [4.17.0](https://xenbits.xen= .org/gitweb/?p=3Dxen.git;a=3Dshortlog;h=3Dstaging) - 2022-11-??

=C2=A0### Changed
=C2=A0 - On x86 "vga=3Dcurrent" can now be used together with GrU= B2's gfxpayload setting. Note that
=C2=A0 =C2=A0 this requires use of "multiboot2" (and "module= 2") as the GrUB commands loading Xen.
+ - The "gnttab" option now has a new command line sub-option for= disabling the
+=C2=A0 =C2=A0GNTTABOP_transfer functionality.
+ - The x86 MCE command line option info is now updated.

=C2=A0### Added / support upgraded
+ - Out-of-tree builds for the hypervisor now supported.
+ - The project has officially adopted 4 directives and 24 rules of MISRA-C= ,
+=C2=A0 =C2=A0added MISRA-C checker build integration, and defined how to d= ocument
+=C2=A0 =C2=A0deviations.
=C2=A0 - IOMMU superpage support on x86, affecting PV guests as well as HVM= /PVH ones
=C2=A0 =C2=A0 when they don't share page tables with the CPU (HAP / EPT= / NPT).
- - Support VIRT_SSBD feature for HVM guests on AMD.
+ - Support VIRT_SSBD feature for HVM guests on AMD and MSR_SPEC_CTRL featu= re for
+=C2=A0 =C2=A0SVM guests.
+ - Improved TSC, CPU frequency calibration and APIC on x86.
+ - Improved support for CET Indirect Branch Tracking on x86.
+ - Improved mwait-idle support for SPR and ADL on x86.
+ - Extend security support for hosts to 12 TiB of memory on x86.
+ - Add command line option to set cpuid parameters for dom0 at boot time o= n x86.
+ - Improved static configuration options on Arm.
+ - cpupools can be specified at boot using device tree on Arm.
+ - It is possible to use PV drivers with dom0less guests, allowing statica= lly
+=C2=A0 =C2=A0booted dom0less guests with PV devices.
+ - On Arm, p2m structures are now allocated out of a pool of memory set as= ide at
+=C2=A0 =C2=A0domain creation.
+ - Improved mitigations against Spectre-BHB on Arm.
+ - Add support for VirtIO toolstack on Arm.
=C2=A0
I would clarify that only virtio-mmio is supported on Arm.
=C2=A0
+ - Allow setting the number of CPUs to activate at runtime from command li= ne
+=C2=A0 =C2=A0option on Arm.
+ - Improved toolstack build system.
+ - Add Xue - console over USB 3 Debug Capability.
I would probably also add the following:

- Add Renesas R-Car Gen4 IPMMU-VMSA support (Arm)
- grant-= table support on Arm was improved and hardened by implementing =E2=80=9Csim= plified M2P-like
approach for the xenheap pages=E2=80=9D

=C2=A0

=C2=A0### Removed / support downgraded
=C2=A0 - dropped support for the (x86-only) "vesa-mtrr" and "= ;vesa-remap" command line options
--
2.25.1




--
Regards,=

Oleksandr Tyshchenko<= /span>
--000000000000c9a02705ed32fbc8-- From xen-devel-bounces@lists.xenproject.org Fri Nov 11 14:50:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 14:50:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442632.697003 (Exim 4.92) (envelope-from ) id 1otVM8-0002fN-GZ; Fri, 11 Nov 2022 14:50:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442632.697003; Fri, 11 Nov 2022 14:50:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otVM8-0002fG-Dm; Fri, 11 Nov 2022 14:50:08 +0000 Received: by outflank-mailman (input) for mailman id 442632; Fri, 11 Nov 2022 14:50:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otVM7-0002de-B3 for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 14:50:07 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 21546fae-61d0-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 15:50:06 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7CC482250A; Fri, 11 Nov 2022 14:50:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2077113357; Fri, 11 Nov 2022 14:50:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MsldBh1hbmMRHQAAMHmgww (envelope-from ); Fri, 11 Nov 2022 14:50:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21546fae-61d0-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1668178205; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mByjmISEKdalqe7JQPlupRP4g09wlWA9jjtuTrL9KpY=; b=F0Zo+/xJHagbEfqClZuEBxIS5uSdUGb/ZhWp9LJjKXcdzLi21N7iDjiAkTTpiyX0SlUOFD qAc1zY6MDng8twz4XKsSUdPuCR42jqlQsZ1cObmJUAv0G5bkBQHrrkClmurbJ/h1kcea92 MmexqAT8bhdvKXsUIjodKUr9a8/wCRA= Message-ID: <7a7553b2-79c1-759d-b020-c75b3118661f@suse.com> Date: Fri, 11 Nov 2022 15:50:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Content-Language: en-US To: Jan Beulich Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Oleksandr Tyshchenko , Maximilian Heyne , xen-devel@lists.xenproject.org, LKML , Stefano Stabellini References: <20220729070416.23306-1-jane.malalane@citrix.com> <1918c63f-0065-b468-3691-de6e314f4374@suse.com> <9ab99257-844b-de15-cd20-7cda61295186@suse.com> <2476e467-1c31-91f4-1e75-86723b8da486@suse.com> <3cd62b0b-a131-b709-4244-0ae694c3d022@suse.com> From: Juergen Gross Subject: Re: [PATCH v4] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------0hRGbhcyHFwbcd61gAq87GYo" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0hRGbhcyHFwbcd61gAq87GYo Content-Type: multipart/mixed; boundary="------------5FjtObaYiiDKaRpBY8HzAwLk"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Oleksandr Tyshchenko , Maximilian Heyne , xen-devel@lists.xenproject.org, LKML , Stefano Stabellini Message-ID: <7a7553b2-79c1-759d-b020-c75b3118661f@suse.com> Subject: Re: [PATCH v4] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector References: <20220729070416.23306-1-jane.malalane@citrix.com> <1918c63f-0065-b468-3691-de6e314f4374@suse.com> <9ab99257-844b-de15-cd20-7cda61295186@suse.com> <2476e467-1c31-91f4-1e75-86723b8da486@suse.com> <3cd62b0b-a131-b709-4244-0ae694c3d022@suse.com> In-Reply-To: --------------5FjtObaYiiDKaRpBY8HzAwLk Content-Type: multipart/mixed; boundary="------------eZPec4DGzN1q5kIEiQLZsg00" --------------eZPec4DGzN1q5kIEiQLZsg00 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMTEuMjIgMTQ6MTcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAxMS4xMS4yMDIy IDEzOjQ0LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMTEuMTEuMjIgMTA6MDEsIEp1 ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4gT24gMDguMTEuMjIgMTc6MjYsIEphbiBCZXVsaWNo IHdyb3RlOg0KPj4+PiBPbiAwMy4xMS4yMDIyIDE2OjQxLCBKYW4gQmV1bGljaCB3cm90ZToN Cj4+Pj4+IE9uIDAzLjExLjIwMjIgMTQ6MzgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+Pj4+ IE9uIDI5LjA3LjIwMjIgMDk6MDQsIEphbmUgTWFsYWxhbmUgd3JvdGU6DQo+Pj4+Pj4+IEBA IC0xMjUsNiArMTMwLDkgQEAgREVGSU5FX0lEVEVOVFJZX1NZU1ZFQyhzeXN2ZWNfeGVuX2h2 bV9jYWxsYmFjaykNCj4+Pj4+Pj4gIMKgIHsNCj4+Pj4+Pj4gIMKgwqDCoMKgwqAgc3RydWN0 IHB0X3JlZ3MgKm9sZF9yZWdzID0gc2V0X2lycV9yZWdzKHJlZ3MpOw0KPj4+Pj4+PiArwqDC oMKgIGlmICh4ZW5fcGVyY3B1X3VwY2FsbCkNCj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGFj a19BUElDX2lycSgpOw0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICDCoMKgwqDCoMKgIGluY19pcnFf c3RhdChpcnFfaHZfY2FsbGJhY2tfY291bnQpOw0KPj4+Pj4+PiAgwqDCoMKgwqDCoCB4ZW5f aHZtX2V2dGNobl9kb191cGNhbGwoKTsNCj4+Pj4+Pj4gQEAgLTE2OCw2ICsxNzYsMTUgQEAg c3RhdGljIGludCB4ZW5fY3B1X3VwX3ByZXBhcmVfaHZtKHVuc2lnbmVkIGludCBjcHUpDQo+ Pj4+Pj4+ICDCoMKgwqDCoMKgIGlmICgheGVuX2hhdmVfdmVjdG9yX2NhbGxiYWNrKQ0KPj4+ Pj4+PiAgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAwOw0KPj4+Pj4+PiArwqDCoMKgIGlm ICh4ZW5fcGVyY3B1X3VwY2FsbCkgew0KPj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgcmMgPSB4 ZW5fc2V0X3VwY2FsbF92ZWN0b3IoY3B1KTsNCj4+Pj4+Pg0KPj4+Pj4+ICDCoEZyb20gYWxs IEkgY2FuIHRlbGwgYXQgbGVhc3QgZm9yIEFQcyB0aGlzIGhhcHBlbnMgYmVmb3JlIHNldHVw X2xvY2FsX2FwaWMoKS4NCj4+Pj4+PiBXaXRoIHRoZXJlIGJlaW5nIEFQSUMgaW50ZXJhY3Rp b24gaW4gdGhpcyBvcGVyYXRpb24gbW9kZSwgYXMgc2VlbiBlLmcuIGluDQo+Pj4+Pj4gdGhl IGVhcmxpZXIgaHVuayBhYm92ZSwgSSB0aGluayB0aGlzIGlzIGxvZ2ljYWxseSB3cm9uZy4g QW5kIGl0IGxlYWRzIHRvDQo+Pj4+Pj4gYXBpY19wZW5kaW5nX2ludHJfY2xlYXIoKSBpc3N1 aW5nIGl0cyB3YXJuaW5nOiBUaGUgdmVjdG9yIHJlZ2lzdHJhdGlvbiwgYXMNCj4+Pj4+PiBh biBpbnRlbnRpb25hbCBzaWRlIGVmZmVjdCwgbWFya3MgdGhlIHZlY3RvciBhcyBwZW5kaW5n LiBVbmxlc3MgSVJRcyB3ZXJlDQo+Pj4+Pj4gZW5hYmxlZCBhdCBhbnkgcG9pbnQgYmV0d2Vl biB0aGUgcmVnaXN0cmF0aW9uIGFuZCB0aGUgY2hlY2ssIHRoZXJlJ3MNCj4+Pj4+PiBzaW1w bHkgbm8gd2F5IGZvciB0aGUgY29ycmVzcG9uZGluZyBJUlIgYml0IHRvIGJlIGRlYWx0IHdp dGggKGJ5DQo+Pj4+Pj4gcHJvcGFnYXRpbmcgdG8gSVNSIHdoZW4gdGhlIGludGVycnVwdCBp cyBkZWxpdmVyZWQsIGFuZCB0aGVuIGJlaW5nIGNsZWFyZWQNCj4+Pj4+PiBmcm9tIElTUiBi eSBFT0kpLg0KPj4+Pj4NCj4+Pj4+IFdpdGggUm9nZXIncyBoZWxwIEkgbm93IGhhdmUgYSBw b2ludGVyIHRvIG9zc3Rlc3QgYWxzbyBleHBvc2luZyB0aGUgaXNzdWU6DQo+Pj4+Pg0KPj4+ Pj4gaHR0cDovL2xvZ3MudGVzdC1sYWIueGVucHJvamVjdC5vcmcvb3NzdGVzdC9sb2dzLzE3 NDU5Mi90ZXN0LWFtZDY0LWFtZDY0LXhsLXB2aHYyLWludGVsL2h1eGVscmViZTAtLS12YXIt bG9nLXhlbi1jb25zb2xlLWd1ZXN0LWRlYmlhbi5ndWVzdC5vc3N0ZXN0LmxvZy5neg0KPj4+ Pg0KPj4+PiBJJ3ZlIG5vdGljZWQgb25seSBub3cgdGhhdCBteSBtYWlsIHRvIEphbmUgYm91 bmNlZCwgYW5kIEknbSBub3cgdG9sZA0KPj4+PiBzaGUncyBubyBsb25nZXIgaW4gaGVyIHJv bGUgYXQgQ2l0cml4LiBTaW5jZSBJIGRvbid0IGV4cGVjdCB0byBoYXZlIHRpbWUNCj4+Pj4g dG8gaW52ZXN0aWdhdGUgYW4gYXBwcm9wcmlhdGUgc29sdXRpb24gaGVyZSwgbWF5IEkgYXNr IHdoZXRoZXIgb25lIG9mDQo+Pj4+IHRoZSB0d28gb2YgeW91IGNvdWxkIGxvb2sgaW50byB0 aGlzLCBiZWluZyB0aGUgbWFpbnRhaW5lcnMgb2YgdGhpcyBjb2RlPw0KPj4+DQo+Pj4gSSB0 aGluayB0aGUgY29ycmVjdCB3YXkgdG8gaGFuZGxlIHRoaXMgd291bGQgYmU6DQo+Pj4NCj4+ PiAtIHJlbmFtZSBDUFVIUF9BUF9BUk1fWEVOX1NUQVJUSU5HIHRvIENQVUhQX0FQX1hFTl9T VEFSVElORw0KPj4+IC0gbW92ZSB0aGUgeGVuX3NldF91cGNhbGxfdmVjdG9yKCkgY2FsbCB0 byBhIG5ldyBob3RwbHVnIGNhbGxiYWNrDQo+Pj4gICDCoCByZWdpc3RlcmVkIGZvciBDUFVI UF9BUF9YRU5fU1RBUlRJTkcgKHRoaXMgY2FuIGJlIGRvbmUgZXZlbg0KPj4+ICAgwqAgY29u ZGl0aW9uYWxseSBvbmx5IGlmIHhlbl9wZXJjcHVfdXBjYWxsIGlzIHNldCkNCj4+Pg0KPj4+ IFdyaXRpbmcgYSBwYXRjaCBub3cgLi4uDQo+Pg0KPj4gRm9yIHRoZSBBUHMgdGhpcyBpcyB3 b3JraW5nIGFzIGV4cGVjdGVkLg0KPj4NCj4+IFRoZSBib290IHByb2Nlc3NvciBzZWVtcyB0 byBiZSBoYXJkZXIgdG8gZml4LiBUaGUgcmVsYXRlZCBtZXNzYWdlIGlzIGJlaW5nDQo+PiBp c3N1ZWQgZXZlbiB3aXRoIGludGVycnVwdHMgYmVpbmcgb24gd2hlbiBzZXR1cF9sb2NhbF9B UElDKCkgaXMgY2FsbGVkLg0KPiANCj4gSG1tLCBwdXp6bGluZzogSSBkb24ndCByZWNhbGwg aGF2aW5nIHNlZW4gdGhlIG1lc3NhZ2UgZm9yIHRoZSBCU1AuIFdoaWNoDQo+IG1hZGUgbWUg YXNzdW1lICh3aXRob3V0IGhhdmluZyBhY3R1YWxseSBjaGVja2VkKSB0aGF0IC4uLg0KPiAN Cj4+IEkndmUgdHJpZWQgdG8gcmVnaXN0ZXIgdGhlIGNhbGxiYWNrIG9ubHkgYWZ0ZXIgdGhl IHNldHVwX2xvY2FsX0FQSUMoKSBjYWxsLA0KPiANCj4gLi4uIGl0J3MgYWxyZWFkeSBoYXBw ZW5pbmcgYWZ0ZXJ3YXJkcyBpbiB0aGF0IGNhc2UuDQo+IA0KPj4gYnV0IHRoaXMgcmVzdWx0 cyBpbiBhIHN5c3RlbSBoYW5nIHdoZW4gdGhlIEFQcyBhcmUgc3RhcnRlZC4NCj4+DQo+PiBB bnkgaWRlYXM/DQo+IA0KPiBOb3QgcmVhbGx5LCB0byBiZSBob25lc3QuDQoNCkkgbWlnaHQg YmUgd3JvbmcgaGVyZSwgYnV0IGlzIGEgYml0IHNldCBpbiBJUlIgcGx1cyBpbnRlcnJ1cHRz IGVuYWJsZWQNCmVub3VnaCB0byBtYWtlIHRoZSBrZXJuZWwgaGFwcHk/IFRoZSBsb2NhbCBB UElDIGlzbid0IGVuYWJsZWQgeWV0IHdoZW4NCmFwaWNfcGVuZGluZ19pbnRyX2NsZWFyKCkg aXMgYmVpbmcgY2FsbGVkLCBzbyBJTUhPIHRoZSBoeXBlcnZpc29yIHdpbGwNCm5ldmVyIHBy b3BhZ2F0ZSB0aGUgYml0IHRvIElTUi4NCg0KSSBkaWRuJ3QgZmluZCBhbnkgc3BlY2lmaWMg aW5mb3JtYXRpb24gaW4gdGhlIFNETSByZWdhcmRpbmcgImFjY2VwdGluZw0KYW4gaW50ZXJy dXB0IiBvZiBhIGRpc2FibGVkIGxvY2FsIEFQSUMsIGJ1dCBtYXliZSBJIGRpZG4ndCBmaW5k IHRoZQ0KcmVsZXZhbnQgcGFydCBvZiB0aGUgbWFudWFsLg0KDQoNCkp1ZXJnZW4NCg== --------------eZPec4DGzN1q5kIEiQLZsg00 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------eZPec4DGzN1q5kIEiQLZsg00-- --------------5FjtObaYiiDKaRpBY8HzAwLk-- --------------0hRGbhcyHFwbcd61gAq87GYo Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNuYRwFAwAAAAAACgkQsN6d1ii/Ey/E Zgf/eU++OBDGUwnTkMOfDChOoHfGUWCh6/cnwF9FScf3bB8ujsf3/rDr6FjQQIkqInEWQ9i7ijIE /tAxEcNHI6olYq1BKBlvWo06REPOj02JEK484iOk0lbdmtH6PFZnkQxud7nc0xNsyUGD8VEHMOb0 1C2JKj5QLIc8JU06TQx6P7BslA1LkzIFPSQcm9I5Gi71OGA+DsD+1+gmxecUm+8WOIqLxhsuH8eL 0vW/LxUMREVGemthAVglbcPREtUtu84TpQOTNVmw4cSK+Li/GmQ72CerOqLTk7+fEJ1WOda7+inC ju53yIgXpru9Nvp2LY9pIBJgDOn7n3pGmXccAcQroQ== =+tSq -----END PGP SIGNATURE----- --------------0hRGbhcyHFwbcd61gAq87GYo-- From xen-devel-bounces@lists.xenproject.org Fri Nov 11 15:10:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 15:10:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442637.697013 (Exim 4.92) (envelope-from ) id 1otVfv-0005Tc-4M; Fri, 11 Nov 2022 15:10:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442637.697013; Fri, 11 Nov 2022 15:10:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otVfv-0005TV-1L; Fri, 11 Nov 2022 15:10:35 +0000 Received: by outflank-mailman (input) for mailman id 442637; Fri, 11 Nov 2022 15:10:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otVfs-0005TP-Ib for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 15:10:32 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03hn2220.outbound.protection.outlook.com [52.100.13.220]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fab784ea-61d2-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 16:10:29 +0100 (CET) Received: from DB7PR05CA0052.eurprd05.prod.outlook.com (2603:10a6:10:2e::29) by AS8PR08MB5926.eurprd08.prod.outlook.com (2603:10a6:20b:29d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 15:10:24 +0000 Received: from DBAEUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2e:cafe::11) by DB7PR05CA0052.outlook.office365.com (2603:10a6:10:2e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Fri, 11 Nov 2022 15:10:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT020.mail.protection.outlook.com (100.127.143.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Fri, 11 Nov 2022 15:10:23 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Fri, 11 Nov 2022 15:10:23 +0000 Received: from 70de0e96278c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7A154121-C49B-48D3-BFD0-71C90F55AC72.1; Fri, 11 Nov 2022 15:10:18 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 70de0e96278c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Nov 2022 15:10:18 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB9847.eurprd08.prod.outlook.com (2603:10a6:10:444::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 15:10:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Fri, 11 Nov 2022 15:10:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fab784ea-61d2-11ed-91b6-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nie1C5+u5DqMKNDIgmWXCt503aEMJBwfpMVr66ZOsA3bE7tNWqxIEmEKoX3WMm2hbPDEE2ulnCHG/JycJwbvfz0+RAAlAoH/Q+Ulv2FTumm8aPETn1elohoHym8pjASUS503IJjgE1Hkw+CHfhYJ1FB4HjciLln/ndMXhkTiZsqFz5IQ111jq+H67tcrww7SXc8ZtVNR+t76m1ORTJ+VDNDRbPcxBMrm3IzsjnBgfrmG8EReZjurItEfzz1Iim9a9OOJR/Wx52tjJG3edkH2TFxTeN8NwAWdx8PdoN3DvLlA2UY5/tVign2cTBjmaCqdu0bERULMNiXuoqB/UqH1ow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=98utQ0xUj7UoTyrkMXlQ/hkGzAJ6XYPMrvthwKWK+Dk=; b=CU62uqenZQgUGvXa8q+V3jGUnh1vd6tWzczonWr3Y/ijbtbD/X2Eq+PBXPiunWUMyJgSrh+cjmQYc2+VttoEMdLNAXuc2fYj5lmC/RHYjExEcmi09vDfN0aNFp+TG/6gyWjS0zH8FOE88pE8BMalwQrfxR0mEta/VzoqTvmUAJQkyGnon2vp3fWFOvPAdu3NAM9u/Q5bvSoOIajGhiICP37ZVuDOeRz6ZfPtmlNjWwnbnr9Q1O8GTpiL+7AhakY2wsHmf3HOtDt12PIVb2QakZnQ6jbBlsPmR1VQtiOuLtnz1kGEal+uxYmJtT/5H2rbSZBiHId2hnyJOnSNGBXezQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=98utQ0xUj7UoTyrkMXlQ/hkGzAJ6XYPMrvthwKWK+Dk=; b=wveK3YmEjhswHFgmhlPSK88L8UFebT6nWPZ+6TePF5nkOddCo9Icb2ysXLJ8sxBIJZtld/t5qMnzTSxZCsp7tyT0u0/GKTXO++3sSyOQF8kQHL/7YFXi3zpLeU5Fl2m07CGlJN8NzKg8j1Suzwewtn9PI0CoSrWedbL2Mqg1Hfc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LMJE85uuYf5wgQ02r4TrFLXrHuh4RvQ6yEUGccfM6DY1i3BFO38GA+LrnShc7ZyruU37h5WgPQAX3DqJ2yMWZ+/1N9be9y07qaXibIdYbcOgnIiRuMxediRpBdOoRwIUY8BCON63ZAIQTThQzLifDJ1zV1AXxTlN/CyRVqEj3V0ieUo1ZWsoOM0M/4FJXS8RICJEWwoItO8iY/AHgaBzW2vZprDiWaG95Kz7ddWiejaU1VJxfRqJrEGeu+CSMY5bRlveVKLfEgkfnM+EsqWw80uA+/PYlKKDzEdYt/z84gdm639XM6iFgGTOrG+tataJxZrnhp3Ij3uatHK4WU4Uzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=98utQ0xUj7UoTyrkMXlQ/hkGzAJ6XYPMrvthwKWK+Dk=; b=MtxdvxIdSC+PDom1oXW84wpHwLFUyrRcpAaHcxX6a9uAyafufOFCS8ub0QeFeY8gwgJXVr4u/fTkmIJMSo4R1cx9dg8buwjnEE0Iih5zJRh8CkRMVtKDFm0r0HV4zCCzO83PnozPd1nGJmMIrLPRitW/KwG6wZ44lKt1SvLOVsVq3WuZxaLtnwbeN8N4PrnnNAoJC6uHJm3Ao5YaOZ5GxGdZSPk8tNWRfN6kz1s8DygHgOLOuuY9qxRCzTkD9yOvT8x28HsildPvxTL6FboSEHhCa6l2AqxpjL5pbJLCHQxYSNJ2unwXqTxtaeyzx5cnQSL3j0DU1zcF/QiyNo4Fsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=98utQ0xUj7UoTyrkMXlQ/hkGzAJ6XYPMrvthwKWK+Dk=; b=wveK3YmEjhswHFgmhlPSK88L8UFebT6nWPZ+6TePF5nkOddCo9Icb2ysXLJ8sxBIJZtld/t5qMnzTSxZCsp7tyT0u0/GKTXO++3sSyOQF8kQHL/7YFXi3zpLeU5Fl2m07CGlJN8NzKg8j1Suzwewtn9PI0CoSrWedbL2Mqg1Hfc= From: Henry Wang To: Oleksandr Tyshchenko CC: xen-devel , Bertrand Marquis , Julien Grall , "sstabellini@kernel.org" Subject: RE: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release Thread-Topic: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release Thread-Index: AQHY9cAA3X9w+pjMxES5dLMt0fkbDa45zccAgAAEr0A= Date: Fri, 11 Nov 2022 15:10:15 +0000 Message-ID: References: <20221111112208.451449-1-Henry.Wang@arm.com> <20221111112208.451449-3-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5AB4A6D966307E4B8092C68C17689BE7.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DU0PR08MB9847:EE_|DBAEUR03FT020:EE_|AS8PR08MB5926:EE_ X-MS-Office365-Filtering-Correlation-Id: 49869a80-50fb-4c42-a92f-08dac3f6db4f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: =?us-ascii?Q?J5nenWBz43nYYSglBG/qzC9SlJ1k7W8yz9HenifJhfv41gh69wBzFNzGHKSX?= =?us-ascii?Q?VtWgcxinTaPYyEZevl2yBFSRaV7SIe+jBUjPTQ9DIE6ard6FIv9Pqtloht+0?= =?us-ascii?Q?tPEq6aOWOdofHq/7DxyVcOeKRu2su2NEapE1ORVAmiS4tuiyIZ5fbdP0rdOF?= =?us-ascii?Q?8kL2rmwN89t7FCqJnGG60f9eZy548nhGpLxHWwevosTOYpQxVTY7cYVXr3Id?= =?us-ascii?Q?aVyMBumwejwYKRF5wuTEEkwv3aYZYugffv3bKaxFqWaBe7Q8PnLrqLbFHhvo?= =?us-ascii?Q?sNIgZNEylyaLi7ddPpF1AN6TF2e+jVSNs7X8dFuDNmjThiuuU/BGBfs7bZxW?= =?us-ascii?Q?2z+XSXkdw07trzrjCQ1+y4rBrPMPt5mvLzwrafLkjV3mKx6ABe0JMQjqsp1X?= =?us-ascii?Q?UOOu/gnceq43JYB9A9EhOYXe74aGqVe7dxvajU71ZljVlysYlrN4QVpkxVrO?= =?us-ascii?Q?Y4JwfZlTtUbJD+qYVnxQz/VeqKbCPLfdcCodNGjyN5j2miok5nV/57aHRawA?= =?us-ascii?Q?6ldn/mFwNPuZOZZjpCimDzzOu9c1Qlr3tRsIY2ByV0ULHK22xdpjJwvGVMJe?= =?us-ascii?Q?K18N/DFUB50tCjXYz30BqYNYswsN7ENOx1HUr3MiVutUD8SSrNyU6t0aaU8U?= =?us-ascii?Q?qG1DanAnYIOyjENfLrO4XRTUI6w31o0QCkDdpycJcNGYmnxwDzaQQOqf9Xj1?= =?us-ascii?Q?SyDa8e/1gxvym4kn/dI0BXIqb2Ca94bfsy2nyC95gxpjqhAjJrjtpdp0heN5?= =?us-ascii?Q?q457iJveM6ZM8jCVrowBtVT+VhMAXd5bjXLm7kiQY0W8juj4TZBNhCQ43/lS?= =?us-ascii?Q?cUrC34aA7NPQhuDx7q/i2ARGhFqDGuoxl6bMn2Nx4QCxLbnt4xo/MNpaQx96?= =?us-ascii?Q?SWtZD/Ryo/ETTA2/onCWcpgkBJW8qCaVee2K9dHb/O4KHJ1hIqvpqlNjHCSa?= =?us-ascii?Q?O7wj6zVWCHDVeNu3/CEuUzMtD1C56qyIM2L23WZrf//CwxGqBQ5eDQgiZVKb?= =?us-ascii?Q?MVl0HpMg6sW2MVmWHd3/tqLBfHpQmKxsndNcVGkyuSAl8zRU6IGPSsRFOlmL?= =?us-ascii?Q?4CLcq8oT0M1H2Lywycu+Ex/miP6cHK4rkfw9X/0RByEOGpRCMp/5PvUhbFeV?= =?us-ascii?Q?tUXcjA2ASjvA8hPiv9ENlNH08YkJrYwEr81pjUMlqj7j4uQDoXlQIudUtxWd?= =?us-ascii?Q?+vwttj/oL7thZQF1UVMqXPWAViUOtY+tjeZV8sW9gMFFUG7qxhd5D/Q4d+w?= =?us-ascii?Q?=3D?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:5;SRV:;IPV:NLI;SFV:SPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:OSPM;SFS:(13230022)(4636009)(366004)(136003)(39860400002)(346002)(396003)(376002)(451199015)(33656002)(8936002)(4744005)(52536014)(9326002)(4326008)(5660300002)(41300700001)(2906002)(55016003)(8676002)(83380400001)(186003)(86362001)(38070700005)(38100700002)(122000001)(54906003)(76116006)(66946007)(64756008)(66556008)(316002)(66446008)(66476007)(6916009)(71200400001)(6506007)(9686003)(7696005)(26005)(478600001)(71176010)(59356011)(219803003);DIR:OUT;SFP:1501; Content-Type: multipart/alternative; boundary="_000_AS8PR08MB7991BAC837FD2D31D99BB1C392009AS8PR08MB7991eurp_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9847 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 37d5b409-fe27-4a16-9fb8-08dac3f6d68e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZE9GcHdkc0tKdVJORlc2QTdaSHpoVDlHUElRRmlPWUpVQmphVmswUWdEQ05v?= =?utf-8?B?RFNqTndnMHNNM0xRUVZlK3k0NXpEbDlJZ2pFVjlTZmlUemUzTk1ldnBjY29n?= =?utf-8?B?YkJlbU1UNGlSOXcwclBPbjR5U3BIUVcyZnkzZjU1bmU0TFJtbWdlcTNyRHJo?= =?utf-8?B?STJ3TzRzQmJzTFlwbklxaXJNMVFSeG9sYnpFZUlKR0wwQjJnaENMYWJLZWFQ?= =?utf-8?B?aXdLcmJRTW50VmFTNHRNM1ZmYzRoMFNZOWtpSUd2REVVVkljZ1QvNnJtSUw3?= =?utf-8?B?bW5RRlRBZUhnUkwyai83N1VNWHVEYUE4MmVyTGpUd2VQcUJOQWtNUEtEOTR6?= =?utf-8?B?VU8xdFp2cWlvR0Qyam41L2l5RzZxQzRhSjZLQjFHR1B3dG9QWm9Bc2xiVHZI?= =?utf-8?B?Zlk0WU9kNVNKZlk0dGRMbmI4SmxPZGZLNkUxTVVNejNmWmVTamF2UkhubnZJ?= =?utf-8?B?RTNXUWk0eDRxL0tjNktJMjNLSkczb1pHNklZVDdWZXpMZzdxL3U1aStYKzZN?= =?utf-8?B?Z0RIRCtCaldhNS9qeGNpRzIxOUdvNy9zTTZSVWlWWUsxWHVySUZTZWQvWC80?= =?utf-8?B?MzNub3dlK0RqQnQ5VU13dDJHWkVhbTRpRDZWUHZOYjM5RERKbDh4Tkh0SG1m?= =?utf-8?B?RStkVzRRd2ttWUo2YXE5YTVPT1grTUhId0lIcXZiQjRDUHJzOXBQTTc3UWZw?= =?utf-8?B?YysrS2UrUjY1d215VGcvMmlmWWVJVUx3RENEajRXN1pmdG9HSDk4VGdZM1NK?= =?utf-8?B?RGFUNDZWVU94eEJoODV4MXM4Ykc1VVhvaWpyOWFxbjdtdUZHVVVaL3d5WlNF?= =?utf-8?B?K29BUjl4azdHWGZRWUtuZUdwL2ExSjQ3dmgxZVowaVFGZUdUUVpXbUkyUzRE?= =?utf-8?B?a1p5SmFhMkVRWTYrZVJiamRYaFB1aWV2ZnFjc2ZLM1huazVvb3AvL0R3RUpI?= =?utf-8?B?SG0xYjdUWElET3RPUzQrWDBBRlJpUmxFRkVIN2FmVWh5MmtRNU5mQmtsMGZ6?= =?utf-8?B?OHVqeG8rN1Y3d25sU2ljMVMwMG1OK2ZPNldTSVZOUUdPcU84ZlhPVGhZSjc4?= =?utf-8?B?MkFRU292MWV6dWFXM0RoM0dUd2phQ01ESnVZOUNBNE1FNVJBWFUwK2UyY0Fk?= =?utf-8?B?NTNabitZUWF0RFVqc29iaEVReWYvbGVVd2F1cno2NDV3dFAzOTIwUkNXZCtw?= =?utf-8?B?bzMwN1Z4N2lyT0pwdU5qb09CcnJLdjBwV2RlVWY4L1l4YXlGdWlCaUxvdWY5?= =?utf-8?B?U3YybnU3d0NTd1ljR0ZUME1jQzIvSVZNSlFtc3d5VjhRTTdmRGlUdWpIOGx0?= =?utf-8?B?ZXpsYXBxRDIzZ1pacVFNSlcvUWN4ZCtPUU56QzZiWVhscm0xSVp0YWpMV2do?= =?utf-8?B?Y01STm1aL1BoTG1laVRPajJmdm1BbjZXT2hoSGtxRllCOHpINFFBSFRlZTVL?= =?utf-8?B?WUNCZWRESmZxT0NubnUrOXBJdm9iL1IxUGFSbU1BeThYRmFxYk9nQkxKMk1v?= =?utf-8?B?eG9vbjJWWW9QVUVqS0FMR0Q2V21lZWljZjBMTStGc2YxUGoyRDIwMzZLYkM0?= =?utf-8?B?YkJYR2Q0MkdsdGNIS3M1LzV4ZU94TGwxTlVtc2FPVW1GcUlyRnUvUE9kWEJa?= =?utf-8?B?blVqSkJCMHhrL25pcDV6TGdBZlc5eXc9PQ==?= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:5;SRV:;IPV:CAL;SFV:SPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:OSPM;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(396003)(136003)(451199015)(40470700004)(36840700001)(46966006)(33656002)(86362001)(36860700001)(6862004)(5660300002)(2906002)(8936002)(9326002)(83380400001)(336012)(82740400003)(26005)(186003)(356005)(9686003)(47076005)(81166007)(496002)(52536014)(54906003)(316002)(70206006)(41300700001)(8676002)(70586007)(82310400005)(4326008)(40480700001)(55016003)(40460700003)(6506007)(33964004)(7696005)(107886003)(478600001)(71196009)(71176010);DIR:OUT;SFP:1501; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 15:10:23.4992 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 49869a80-50fb-4c42-a92f-08dac3f6db4f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5926 --_000_AS8PR08MB7991BAC837FD2D31D99BB1C392009AS8PR08MB7991eurp_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgT2xla3NhbmRyLA0KDQooKyBBcm0gbWFpbnRhaW5lcnMgZm9yIGEgcXVlc3Rpb24pDQoNClBs ZWFzZSBzZWUgYmVsb3cgaW5saW5lIGNvbW1lbnRzIChJIHNvbWVob3cgY2Fubm90IHJlcGx5IGFz IHBsYWluIHRleHQgZm9yIHRoaXMgZW1haWwpLg0KDQorIC0gQWRkIHN1cHBvcnQgZm9yIFZpcnRJ TyB0b29sc3RhY2sgb24gQXJtLg0KDQpJIHdvdWxkIGNsYXJpZnkgdGhhdCBvbmx5IHZpcnRpby1t bWlvIGlzIHN1cHBvcnRlZCBvbiBBcm0uDQoNCihIZW5yeSk6IFN1cmUsIHdpbGwgY2xhcmlmeSB0 aGF0Lg0KDQorIC0gQWxsb3cgc2V0dGluZyB0aGUgbnVtYmVyIG9mIENQVXMgdG8gYWN0aXZhdGUg YXQgcnVudGltZSBmcm9tIGNvbW1hbmQgbGluZQ0KKyAgIG9wdGlvbiBvbiBBcm0uDQorIC0gSW1w cm92ZWQgdG9vbHN0YWNrIGJ1aWxkIHN5c3RlbS4NCisgLSBBZGQgWHVlIC0gY29uc29sZSBvdmVy IFVTQiAzIERlYnVnIENhcGFiaWxpdHkuDQoNCkkgd291bGQgcHJvYmFibHkgYWxzbyBhZGQgdGhl IGZvbGxvd2luZzoNCg0KLSBBZGQgUmVuZXNhcyBSLUNhciBHZW40IElQTU1VLVZNU0Egc3VwcG9y dCAoQXJtKQ0KDQooSGVucnkpOiBJZiBzb21ldGhpbmcgZnJvbSBhIHNwZWNpZmljIHZlbmRvciBu ZWVkcyB0byBiZSBpbmNsdWRlZCwgSSB3b25kZXIgaWYg4oCcYWRkIGkuTVggbHB1YXJ0IGFuZCBp Lk1YOFFNIGluaXRpYWwgc3VwcG9ydOKAnSBhbHNvIHF1YWxpZnkuIEkgd2lsbCBsZXQgQXJtIG1h aW50YWluZXJzIHRvIGRvIHRoZSBmaW5hbCBjYWxsIGhlcmUuIEhvcGUgeW91IHdvdWxkIGJlIGZp bmUgd2l0aCB0aGF0Lg0KDQotIGdyYW50LXRhYmxlIHN1cHBvcnQgb24gQXJtIHdhcyBpbXByb3Zl ZCBhbmQgaGFyZGVuZWQgYnkgaW1wbGVtZW50aW5nIOKAnHNpbXBsaWZpZWQgTTJQLWxpa2UNCmFw cHJvYWNoIGZvciB0aGUgeGVuaGVhcCBwYWdlc+KAnQ0KDQooSGVucnkpOiBTdXJlLCBJIHdpbGwg YWRkIHRoaXMuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQo= --_000_AS8PR08MB7991BAC837FD2D31D99BB1C392009AS8PR08MB7991eurp_ Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: base64 PGh0bWwgeG1sbnM6dj0idXJuOnNjaGVtYXMtbWljcm9zb2Z0LWNvbTp2bWwiIHhtbG5zOm89InVy bjpzY2hlbWFzLW1pY3Jvc29mdC1jb206b2ZmaWNlOm9mZmljZSIgeG1sbnM6dz0idXJuOnNjaGVt YXMtbWljcm9zb2Z0LWNvbTpvZmZpY2U6d29yZCIgeG1sbnM6bT0iaHR0cDovL3NjaGVtYXMubWlj cm9zb2Z0LmNvbS9vZmZpY2UvMjAwNC8xMi9vbW1sIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcv VFIvUkVDLWh0bWw0MCI+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIg Y29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjxtZXRhIG5hbWU9IkdlbmVyYXRv ciIgY29udGVudD0iTWljcm9zb2Z0IFdvcmQgMTUgKGZpbHRlcmVkIG1lZGl1bSkiPg0KPHN0eWxl PjwhLS0NCi8qIEZvbnQgRGVmaW5pdGlvbnMgKi8NCkBmb250LWZhY2UNCgl7Zm9udC1mYW1pbHk6 IkNhbWJyaWEgTWF0aCI7DQoJcGFub3NlLTE6MiA0IDUgMyA1IDQgNiAzIDIgNDt9DQpAZm9udC1m YWNlDQoJe2ZvbnQtZmFtaWx5OkRlbmdYaWFuOw0KCXBhbm9zZS0xOjIgMSA2IDAgMyAxIDEgMSAx IDE7fQ0KQGZvbnQtZmFjZQ0KCXtmb250LWZhbWlseTpDYWxpYnJpOw0KCXBhbm9zZS0xOjIgMTUg NSAyIDIgMiA0IDMgMiA0O30NCkBmb250LWZhY2UNCgl7Zm9udC1mYW1pbHk6IlxARGVuZ1hpYW4i Ow0KCXBhbm9zZS0xOjIgMSA2IDAgMyAxIDEgMSAxIDE7fQ0KLyogU3R5bGUgRGVmaW5pdGlvbnMg Ki8NCnAuTXNvTm9ybWFsLCBsaS5Nc29Ob3JtYWwsIGRpdi5Nc29Ob3JtYWwNCgl7bWFyZ2luOjBp bjsNCglmb250LXNpemU6MTEuMHB0Ow0KCWZvbnQtZmFtaWx5OiJDYWxpYnJpIixzYW5zLXNlcmlm O30NCnNwYW4uRW1haWxTdHlsZTE4DQoJe21zby1zdHlsZS10eXBlOnBlcnNvbmFsLXJlcGx5Ow0K CWZvbnQtZmFtaWx5OiJDYWxpYnJpIixzYW5zLXNlcmlmOw0KCWNvbG9yOndpbmRvd3RleHQ7fQ0K Lk1zb0NocERlZmF1bHQNCgl7bXNvLXN0eWxlLXR5cGU6ZXhwb3J0LW9ubHk7DQoJZm9udC1mYW1p bHk6IkNhbGlicmkiLHNhbnMtc2VyaWY7fQ0KQHBhZ2UgV29yZFNlY3Rpb24xDQoJe3NpemU6OC41 aW4gMTEuMGluOw0KCW1hcmdpbjoxLjBpbiAxLjBpbiAxLjBpbiAxLjBpbjt9DQpkaXYuV29yZFNl Y3Rpb24xDQoJe3BhZ2U6V29yZFNlY3Rpb24xO30NCi0tPjwvc3R5bGU+PCEtLVtpZiBndGUgbXNv IDldPjx4bWw+DQo8bzpzaGFwZWRlZmF1bHRzIHY6ZXh0PSJlZGl0IiBzcGlkbWF4PSIxMDI2IiAv Pg0KPC94bWw+PCFbZW5kaWZdLS0+PCEtLVtpZiBndGUgbXNvIDldPjx4bWw+DQo8bzpzaGFwZWxh eW91dCB2OmV4dD0iZWRpdCI+DQo8bzppZG1hcCB2OmV4dD0iZWRpdCIgZGF0YT0iMSIgLz4NCjwv bzpzaGFwZWxheW91dD48L3htbD48IVtlbmRpZl0tLT4NCjwvaGVhZD4NCjxib2R5IGxhbmc9IkVO LVVTIiBsaW5rPSJibHVlIiB2bGluaz0icHVycGxlIiBzdHlsZT0id29yZC13cmFwOmJyZWFrLXdv cmQiPg0KPGRpdiBjbGFzcz0iV29yZFNlY3Rpb24xIj4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPkhp IE9sZWtzYW5kciw8bzpwPjwvbzpwPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxvOnA+Jm5i c3A7PC9vOnA+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+KCsgQXJtIG1haW50YWluZXJzIGZv ciBhIHF1ZXN0aW9uKTxvOnA+PC9vOnA+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+PG86cD4m bmJzcDs8L286cD48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj5QbGVhc2Ugc2VlIGJlbG93IGlu bGluZSBjb21tZW50cyAoSSBzb21laG93IGNhbm5vdCByZXBseSBhcyBwbGFpbiB0ZXh0IGZvciB0 aGlzIGVtYWlsKS48bzpwPjwvbzpwPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxvOnA+Jm5i c3A7PC9vOnA+PC9wPg0KPGRpdiBzdHlsZT0iYm9yZGVyOm5vbmU7Ym9yZGVyLWxlZnQ6c29saWQg Ymx1ZSAxLjVwdDtwYWRkaW5nOjBpbiAwaW4gMGluIDQuMHB0Ij4NCjxkaXY+DQo8ZGl2Pg0KPGJs b2NrcXVvdGUgc3R5bGU9ImJvcmRlcjpub25lO2JvcmRlci1sZWZ0OnNvbGlkICNDQ0NDQ0MgMS4w cHQ7cGFkZGluZzowaW4gMGluIDBpbiA2LjBwdDttYXJnaW4tbGVmdDo0LjhwdDttYXJnaW4tcmln aHQ6MGluIj4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPisgLSBBZGQgc3VwcG9ydCBmb3IgVmlydElP IHRvb2xzdGFjayBvbiBBcm0uPG86cD48L286cD48L3A+DQo8L2Jsb2NrcXVvdGU+DQo8ZGl2Pg0K PHAgY2xhc3M9Ik1zb05vcm1hbCI+Jm5ic3A7PG86cD48L286cD48L3A+DQo8L2Rpdj4NCjxkaXY+ DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj5JIHdvdWxkIGNsYXJpZnkgdGhhdCBvbmx5IHZpcnRpby1t bWlvIGlzIHN1cHBvcnRlZCBvbiBBcm0uPG86cD48L286cD48L3A+DQo8cCBjbGFzcz0iTXNvTm9y bWFsIj48bzpwPiZuYnNwOzwvbzpwPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPihIZW5yeSk6 IFN1cmUsIHdpbGwgY2xhcmlmeSB0aGF0LjxvOnA+PC9vOnA+PC9wPg0KPC9kaXY+DQo8ZGl2Pg0K PHAgY2xhc3M9Ik1zb05vcm1hbCI+PG86cD4mbmJzcDs8L286cD48L3A+DQo8L2Rpdj4NCjxibG9j a3F1b3RlIHN0eWxlPSJib3JkZXI6bm9uZTtib3JkZXItbGVmdDpzb2xpZCAjQ0NDQ0NDIDEuMHB0 O3BhZGRpbmc6MGluIDBpbiAwaW4gNi4wcHQ7bWFyZ2luLWxlZnQ6NC44cHQ7bWFyZ2luLXJpZ2h0 OjBpbiI+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj4rIC0gQWxsb3cgc2V0dGluZyB0aGUgbnVtYmVy IG9mIENQVXMgdG8gYWN0aXZhdGUgYXQgcnVudGltZSBmcm9tIGNvbW1hbmQgbGluZTxicj4NCism bmJzcDsgJm5ic3A7b3B0aW9uIG9uIEFybS48YnI+DQorIC0gSW1wcm92ZWQgdG9vbHN0YWNrIGJ1 aWxkIHN5c3RlbS48YnI+DQorIC0gQWRkIFh1ZSAtIGNvbnNvbGUgb3ZlciBVU0IgMyBEZWJ1ZyBD YXBhYmlsaXR5LjxvOnA+PC9vOnA+PC9wPg0KPC9ibG9ja3F1b3RlPg0KPGRpdj4NCjxwIGNsYXNz PSJNc29Ob3JtYWwiPjxvOnA+Jm5ic3A7PC9vOnA+PC9wPg0KPC9kaXY+DQo8ZGl2Pg0KPHAgY2xh c3M9Ik1zb05vcm1hbCI+SSB3b3VsZCBwcm9iYWJseSBhbHNvIGFkZCB0aGUgZm9sbG93aW5nOjxv OnA+PC9vOnA+PC9wPg0KPC9kaXY+DQo8ZGl2Pg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+PG86cD4m bmJzcDs8L286cD48L3A+DQo8L2Rpdj4NCjxkaXY+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj4tIEFk ZCBSZW5lc2FzIFItQ2FyIEdlbjQgSVBNTVUtVk1TQSBzdXBwb3J0IChBcm0pPG86cD48L286cD48 L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48bzpwPiZuYnNwOzwvbzpwPjwvcD4NCjxwIGNsYXNz PSJNc29Ob3JtYWwiPihIZW5yeSk6IElmIHNvbWV0aGluZyBmcm9tIGEgc3BlY2lmaWMgdmVuZG9y IG5lZWRzIHRvIGJlIGluY2x1ZGVkLCBJIHdvbmRlciBpZiDigJxhZGQgaS5NWCBscHVhcnQgYW5k IGkuTVg4UU0gaW5pdGlhbCBzdXBwb3J04oCdIGFsc28gcXVhbGlmeS4gSSB3aWxsIGxldCBBcm0g bWFpbnRhaW5lcnMgdG8gZG8gdGhlIGZpbmFsIGNhbGwgaGVyZS4gSG9wZSB5b3Ugd291bGQgYmUg ZmluZSB3aXRoIHRoYXQuPG86cD48L286cD48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48bzpw PiZuYnNwOzwvbzpwPjwvcD4NCjwvZGl2Pg0KPGRpdj4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPi0g Z3JhbnQtdGFibGUgc3VwcG9ydCBvbiBBcm0gd2FzIGltcHJvdmVkIGFuZCBoYXJkZW5lZCBieSBp bXBsZW1lbnRpbmcg4oCcc2ltcGxpZmllZCBNMlAtbGlrZTxvOnA+PC9vOnA+PC9wPg0KPC9kaXY+ DQo8ZGl2Pg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+YXBwcm9hY2ggZm9yIHRoZSB4ZW5oZWFwIHBh Z2Vz4oCdPG86cD48L286cD48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj48bzpwPiZuYnNwOzwv bzpwPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPihIZW5yeSk6IFN1cmUsIEkgd2lsbCBhZGQg dGhpcy48bzpwPjwvbzpwPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxvOnA+Jm5ic3A7PC9v OnA+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+S2luZCByZWdhcmRzLDxvOnA+PC9vOnA+PC9w Pg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+SGVucnk8bzpwPjwvbzpwPjwvcD4NCjwvZGl2Pg0KPC9k aXY+DQo8L2Rpdj4NCjwvZGl2Pg0KPC9kaXY+DQo8L2JvZHk+DQo8L2h0bWw+DQo= --_000_AS8PR08MB7991BAC837FD2D31D99BB1C392009AS8PR08MB7991eurp_-- From xen-devel-bounces@lists.xenproject.org Fri Nov 11 15:21:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 15:21:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442644.697024 (Exim 4.92) (envelope-from ) id 1otVqi-0007Dt-7t; Fri, 11 Nov 2022 15:21:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442644.697024; Fri, 11 Nov 2022 15:21:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otVqi-0007Dm-54; Fri, 11 Nov 2022 15:21:44 +0000 Received: by outflank-mailman (input) for mailman id 442644; Fri, 11 Nov 2022 15:21:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otVqg-0007Dg-Jt for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 15:21:42 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8a1e7511-61d4-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 16:21:40 +0100 (CET) Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-547-jt7WmHpEMculnadCQ5nRdg-1; Fri, 11 Nov 2022 10:21:38 -0500 Received: by mail-qv1-f71.google.com with SMTP id do17-20020a056214097100b004c6183e6ce4so2061017qvb.11 for ; Fri, 11 Nov 2022 07:21:38 -0800 (PST) Received: from ovpn-194-83.brq.redhat.com (nat-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id g10-20020ae9e10a000000b006fa4cac54a5sm1505749qkm.72.2022.11.11.07.21.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 07:21:33 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a1e7511-61d4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668180099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V/2KUIcNea2iSiMMtPiiwN4PyC8vWPzRYRSCfguAA+4=; b=OiZTfLLH3s+wVl7cdae38GXXvw8WavqSCGFV65snoTCmuXdb3a5FUi7wDMhmHVgLYCtxhn FbCobhNG8OGwxTPQFJiVQylU0gVvnKir5zju4Rh6XtdMuL1336XywmstFr2tBBextJM+H+ 2fzZ8AsqnNqXxm6IBbF5jBuKqmWIHLA= X-MC-Unique: jt7WmHpEMculnadCQ5nRdg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V/2KUIcNea2iSiMMtPiiwN4PyC8vWPzRYRSCfguAA+4=; b=zU/SKBFSPPsD0/797VTafRkof7jLUNB2GW+gW7APwauR/kVeR0oQ0mlHlAx+PQ7irM AlIeft6RLfz1bGJNLa0boLMAPqjIuqgZqk9VVi1SQidMW96hT9tGx0dTe4M9mOTeOvVU ZvMi/AAb8crDnepRmhA3/Wpj7Aone3IW32nssodOjyDSgJzWV3HLFS820QKSDbsMmsFf DGwiaqsVEcgNjzPWdyfQR/bmLgggpulB8yNT0KK+LgcHRT7q/B8enToyGTJ3lsFvep/Q soHCndtBSE2uXTh+4r5XlMCiOQowSxRPuM1h9zQPr3N8o3M3COUEAjgcSXmCAOQHTGm1 Q+Ag== X-Gm-Message-State: ANoB5plabXDrl/4KxXqnqJzkNK0HMWDobz09+w49SznxMBYurnPLveEd OPfH8EKN45zu5GGZ8qmJl03GdRVguWa03AXpbPMqlPYzbj5gFOXRjhaI1DdmE8kd4FxKgeDG1al sd0yqg32sHA8x3QeyfBPaReiBJJM= X-Received: by 2002:a37:a809:0:b0:6fa:1e46:291b with SMTP id r9-20020a37a809000000b006fa1e46291bmr1465831qke.494.1668180094471; Fri, 11 Nov 2022 07:21:34 -0800 (PST) X-Google-Smtp-Source: AA0mqf4obT3Iyq7MtRwR9wMVvHN14BtAVf2chkJjW7Rv7zzWBQO/nMTwoZWfZ6eZpZKrZsTfLu+riQ== X-Received: by 2002:a37:a809:0:b0:6fa:1e46:291b with SMTP id r9-20020a37a809000000b006fa1e46291bmr1465801qke.494.1668180094202; Fri, 11 Nov 2022 07:21:34 -0800 (PST) From: Vitaly Kuznetsov To: Alexander Potapenko Cc: Peter Zijlstra , kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Paolo Bonzini , Wanpeng Li , Juergen Gross , srivatsa@csail.mit.edu Subject: Re: Making KMSAN compatible with paravirtualization In-Reply-To: References: Date: Fri, 11 Nov 2022 16:21:30 +0100 Message-ID: <875yflo6th.fsf@ovpn-194-83.brq.redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Alexander Potapenko writes: > Hi, > > While investigating KMSAN's incompatibilities with the default Ubuntu > config (https://github.com/google/kmsan/issues/89#issuecomment-1310702949), > I figured out that a kernel won't boot with both CONFIG_KMSAN=y and > CONFIG_XEN_PV=y. > > In particular, it may crash in load_percpu_segment(): > > __loadsegment_simple(gs, 0); > wrmsrl(MSR_GS_BASE, cpu_kernelmode_gs_base(cpu)); > > Here the value of %gs between __loadsegment_simple() and wrmsrl() is > zero, so when KMSAN's __msan_get_context_state() instrumentation > function is called before the actual WRMSR instruction is performed, > it will attempt to access percpu data and crash. > > Unless instructed otherwise (by noinstr or __no_sanitize_memory on the > source level, or by KMSAN_SANITIZE := n on the Makefile level), KMSAN > inserts instrumentation at function prologue for every non-inlined > function, including native_write_msr(). > > Marking native_write_msr() noinstr actually makes the kernel boot for > me, but I am not sure if this is enough. In fact we'll need to fix > every situation in which instrumentation code may be called with > invalid %gs value. Do you think this is feasible? Overall, should we > care about KMSAN working with paravirtualization? I think XEN PV is really special, let's Cc: xen-devel@ first. -- Vitaly From xen-devel-bounces@lists.xenproject.org Fri Nov 11 15:34:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 15:34:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442648.697036 (Exim 4.92) (envelope-from ) id 1otW37-0000SW-DW; Fri, 11 Nov 2022 15:34:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442648.697036; Fri, 11 Nov 2022 15:34:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otW37-0000SP-A1; Fri, 11 Nov 2022 15:34:33 +0000 Received: by outflank-mailman (input) for mailman id 442648; Fri, 11 Nov 2022 15:34:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otW35-0000S3-82 for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 15:34:31 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 543ad9cd-61d6-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 16:34:29 +0100 (CET) Received: from mail-dm3nam02lp2040.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Nov 2022 10:34:26 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6587.namprd03.prod.outlook.com (2603:10b6:303:12a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Fri, 11 Nov 2022 15:34:23 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 15:34:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 543ad9cd-61d6-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668180869; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=tAtlsusJi2Uehnp+gIp0x/mg5H8s7s0QemxFHGuOce8=; b=gpTNDm0VuJFHbew87n/RAYEikTO0stBm2ccobDwj+X/QcjhsdQwIQBO7 77QTcM3yLA2zaCHaTu6unxrar+sKXa9M9U2FzETlYU1lW4p9kI2oJa2Ri 5cFAyH3YwE0zdIAU0aoh/XhIWSQZyFUfUmUh2YlcNlZ6fZW4i8c+dLLBd s=; X-IronPort-RemoteIP: 104.47.56.40 X-IronPort-MID: 84652039 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:dtVhLam0kYEQYpLHpjTpY2Ho5gwrJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIaWzjQMvyKN2r3co9/OYy+oUoF65PTzdA1HlRuqyE0RiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5QaGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 dElMTYwbQmDvM633ryHcuRg3uY+EPC+aevzulk4pd3YJdAPZMiZBonvvppf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVI3jOCF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJOSuDirqU76LGV7kw2N0w3aAvimuCGtW29Q9V7M E0t4QN7+MDe82TuFLERRSaQvn2ZrBgRR8F4CeA26AiRjKHT5m6xCWwFQjNbQNMhs8AySHoh0 Vrht8vkGTF1opWUT3yH/7uZpD/0PjIaRUcBeyosUwQI+Z/grZs1gxaJScxseIalg9uwFTzuz jSiqCklm65VncMNz7+8/13Mn3SrvJehZhY/4QPFX2Skxhl0aI6se8qj7l2zxelJKp6USFaFv VAYls6V4eYSS5qKkUSlQuoXG6qyz+2YKzCaillqd7E67TWz8mK4dKhb+zh/IAFsM9pCdDP0C HI/oitU7Z5XeXevNql+ZtrrD9xwlfS4U9P4SvrTc9xCJIBrcxOK9z1vYkjW2H3xlE8rkuc0P pLznduQMEv2wJ9PlFKeL9rxG5dwrszi7Qs/nazG8ik= IronPort-HdrOrdr: A9a23:XUzji6Ae9//M07HlHeiEsseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzI39QWUijusybjiVzyVxA0XXT9jyaortT GtqX252oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuQFNzn2jQ6sRYJ5H5mPpio8ru2D4Esj1P PMvxAjFcJu7G65RBD6nTLdny3blBo+4X7rzlGVxVH5p9bieT48A81dwapEbxrw8SMbzZJB+Z MO+1jcm4tcDBvGkii4zcPPTQtWmk29pmdnufIPjkZYTZAVZNZq3M4iFQJuYdI99RDBmcca+d pVfYfhDTFtAAqnhkXizy1SKRqXLywO91m9MxM/U4euokVrdThCvjclLYok7zc9HdsGOud5D6 6vCNUWqJheCsARdq5zH+EHXI++DXHMWwvFNCaILU3gD7xvAQOFl3fb2sRD2AiRQu1/8LIi3J DaFF9Iv287fEzjTcWIwZ1Q6xjIBGGwRy7kxM1S74Vw/uSUfsuhDQSTDFQ118ewqfQWBcPWH/ 61JZJNGvfmaW/jA5xA0QHyU4RbbXMeTMoWsNAmXE/mmLOCFqT68ujANPrDLrvkFjgpHmv5H3 sYRTD2YN5N60i6M0WI9CQ5m0mdD3AX0agAY5QypdJjubTlHrc8wjQ9mBC++tyBLyFEv+g/YF Z+SYmX4J+GmQ== X-IronPort-AV: E=Sophos;i="5.96,156,1665460800"; d="scan'208";a="84652039" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gOL3gS31xHqeqiQQztyC+11RSEf4JtkvyWC8A2kyglcJ01JOZAFfRrDH8pmZW+w/ywE7RkGIFfHqt+gFaKTCHOaABk48J5gvbGyqXM3ByZ1tcV8aRW6n1FhnLHJvrBGUmPQdn4u2R5wxxa5O8zJ49KhnvWhUkh74+PxZLNhyO2HP+JgXJKdEmRBFXnMtBtCiINVGIWZNcEaTbjWv7BOFgMermKxOxJypSE5pDeqaEpdoEXCqddTGjUWD67OkLaoGhV+47HKzUvqLeeAWZ8FtFJvctGsZq4Wo3QBTz0xTKcq5Dr5x8fsl1iFxR9lme8W/1gtDQgejGK5iMl6D8Xs0VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tAtlsusJi2Uehnp+gIp0x/mg5H8s7s0QemxFHGuOce8=; b=UebEQC39n7jg6/HR5bEEem3mb/xcMrpNR442Vrdytbc4PL5X+SZyqBAMuE4Jf6gf/qP+myx21163GTmRmqQnkwDURfezr07hWYBcuvqqwvnVXAq1L8Dj5ezYh99HfbYUsb/HBSuISdZs4RJEl7lIroGOb/dHeetAKRGSMmamLNlUWhAMbPOvGVtmHnNDWj0xYxew1dI2L8zWF5VY9D0WFI4QOqarqmGc6P18QDugACozmSQYsscwJxrU5LAeyn9ocrqct1EehTyihO2fBeSalpG9Z3k4M9R52/rTzDw0rpoanFqo3R9omot/Hff7RR/xIQ8QiqjGAWkp4luCa1wlNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tAtlsusJi2Uehnp+gIp0x/mg5H8s7s0QemxFHGuOce8=; b=gQP7+/pLOPNaM/BtNOvaGpDaQcTwewDQU+lzjbSM1qS37GU2kMbPG4wfsM5BsZp538avyUdh2SBl2ASOp1uN1mpIGg5h3CuCyX3WC51o9Xu+53aUd7xynlPavX52hOiv3+UGalNplK6Wp23kF/t2HXVCgoDWexJjwr3MqwD5R8o= From: Andrew Cooper To: Vitaly Kuznetsov , Alexander Potapenko CC: Peter Zijlstra , "kvm@vger.kernel.org" , "xen-devel@lists.xenproject.org" , Paolo Bonzini , Wanpeng Li , Juergen Gross , "srivatsa@csail.mit.edu" Subject: Re: Making KMSAN compatible with paravirtualization Thread-Topic: Making KMSAN compatible with paravirtualization Thread-Index: AQHY9eFcHH1JYMsgREmwx+zG/XY6ba452mKA Date: Fri, 11 Nov 2022 15:34:23 +0000 Message-ID: <2a8fb798-7680-8b9c-7aef-f267eae98f4d@citrix.com> References: <875yflo6th.fsf@ovpn-194-83.brq.redhat.com> In-Reply-To: <875yflo6th.fsf@ovpn-194-83.brq.redhat.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MW4PR03MB6587:EE_ x-ms-office365-filtering-correlation-id: 33ca7de7-0321-43ff-9a21-08dac3fa359a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: =?utf-8?B?aGRTcVVlanlWNE5SdEFSTHIvTFNIN0tWVFV1V2ZwVUVVaDRlb2huaXB3Umpx?= =?utf-8?B?ZXEyZUkwVW03UWhXYnU4YjNJUlVGRFVneEI2OTBJWHNPQWpHM0lsNkZ2dmxD?= =?utf-8?B?TmovM1lRTnI2SHpIQTFJd2pMZkJyZi9xWXMwcTZRcTJUS3RucW8wZWJTRmtv?= =?utf-8?B?VkpLcTZFMCtkdnFsWnFMTXA2Q0Fkdm91N3ZpNzNOUXEwOWNJZEhydVpBQVVw?= =?utf-8?B?YjBDN3NSUjFnUzJoUzNqOU9OV0s4TWpVbXh0ZU5ScDlUdENlRGRTQnJjVVBx?= =?utf-8?B?c2RLUmxudXZpYkp4K0VvcnM2aFlwd0EvZFg2blM5NVJOSXJ2MUhaSVBZVkY4?= =?utf-8?B?N2hsdFdEcVJBbmZ1K0hqVWk5bEZ2WkZNaElZY0F1TThVZi8vb0pQUlY1SU9n?= =?utf-8?B?d25qN0FBK3JGVHlGMk5rcmN3MjdkRWQ5T05UYW1rWUhFcVpielVPbGx6SDNT?= =?utf-8?B?TTExY0R5K2JiOU94aFg5NERpR3hycnYvUEg3Yjd5ckFxS05IakZkTWo5VDcz?= =?utf-8?B?Um9Kb042NVIwdlZCeHU4ZU4xZnFhbFBxa2FoSExjbWlSWHlVU3FtUnJEdlJR?= =?utf-8?B?WXIwOWlYSzVsSlkzK1Y3MFRsb2JsbnhpWFo3Z0tzbFg3ZU10NHNCUU1kNkFG?= =?utf-8?B?ME5BNURnVGZmc1Fta3VBc3orZ2hLSFdXTXlwK1RBQ3VLZCtKTEhqTEZ3TGFa?= =?utf-8?B?MnZrVE9YcFc4L2xTVVNQSFk0bnluMGZ0NWZsWEI5bjduaFlDZExWakRpQTRu?= =?utf-8?B?MDhZMW9XaXZQcW4xc1J1UE9ZVmVuelRBZmViZXd0K3RQUHhKZG90bWg1dzYr?= =?utf-8?B?VXBWZERHNmVienNGOHRjZ3JSZHhkSUhZcmZuNkY1TEZ1UERKVlBETUNDbW41?= =?utf-8?B?OStFRW5OS1V6ZGFPZWd2Rkg0SjFwMmFTTjU4dGwreitpdFMvbGk5Nk5IaDF1?= =?utf-8?B?YUx4VUNDT2ZDa1A0RmtXQll2SWQ1cmx0eDg5d3V3UGZyR0Q3NElVT0VOanJI?= =?utf-8?B?ME4raVoybmxnaCtJWTdFQVpqZ2JGZ0dFSTJlNC9mWGdYNFU2Y3V6Ti8zUWhC?= =?utf-8?B?SFVxL0Ivb0dVTVNTWmRQcHBCUXRNL3NpVEV6UzFqQk5iRjNMTDI2U3BSYWpn?= =?utf-8?B?RFp4ZGVFMUdLcnBudVBvMjhLWERDcnhYakFDZmZtakUrbHI0NUNIRnUwSGVM?= =?utf-8?B?N3VRMm9HSHdZWG8yWW9wWmJzSW5hVUdaZ2ZVN2F3RnBhc1crdUtVQ3VRdFJV?= =?utf-8?B?WU1SNU8zYWREbzdxWkdoaEUydEhzT2ZzUlh4VnJrMnJLT3hkUT09?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(346002)(366004)(396003)(451199015)(36756003)(86362001)(31686004)(82960400001)(31696002)(38070700005)(54906003)(83380400001)(122000001)(26005)(6512007)(2906002)(6506007)(53546011)(2616005)(38100700002)(186003)(66446008)(66946007)(66476007)(66556008)(478600001)(64756008)(110136005)(6486002)(5660300002)(8676002)(4326008)(91956017)(316002)(76116006)(71200400001)(8936002)(41300700001)(966005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Sis1TnpWVzlUZ0ZWNmhYVVF1Y1ZvYm5UQ2N5MTRBMWNqWGtxejRnMytTVHNK?= =?utf-8?B?NllCS1NhblR3cDRqcGd2RHpjWDViSEhZK1lFZlRUdkJmYnp0L0RnZ1FDd3Vj?= =?utf-8?B?YU9jWmU0ZVBtMXFTTmpNZ1JBeEJoTVNWVzRCL3YwREIvRDBDY3RBQ2dRTlRv?= =?utf-8?B?REFwT1MvM3RUNWRQNERFNUdFY0ZYaU9wUjB3YXRwa1pVZmxrQ3ZnOElRWDZS?= =?utf-8?B?LzZJWkg3VlRpQU9hb0ZwVEt2QjJhdjV0Y0hvZmJJSC9UQjFKSjlQc0hzRGsw?= =?utf-8?B?dVVmTVVJSnVBcVBSdldGQkNySmRCSFdMUjdaSmtCOENPS3g5QlYwdjJGVUg5?= =?utf-8?B?U1NMY01NY09jUTA5V0FDTm5USUE1dWdCSWxQakgvYlplbVJtTk1hSGNXajli?= =?utf-8?B?THdVSXladzFOTUh5MEZGb2oxUVZONm5hTlo4WVpCYmxYSytRQmlPU2d3RVM5?= =?utf-8?B?TTlCNFdjL25kTFd2UDFRb0xLM3RpcjUzWmIrQ1poTjVYbm1sZEpDbUFpNi9z?= =?utf-8?B?NlM1ZENweGtkTU9nek96MjhnUnNKYzArTjZJaDZzb0JiMFphc0pJN1pxS3hC?= =?utf-8?B?NGJScDJNYWgvd0V5QTJTVEFIVmY0RG9aWTZkVkdSZHlxYXBJNnM0STlUbmpT?= =?utf-8?B?Y04zTkdsKzlTaThxRHlFOGpLUENFRDEvSVNTU0t5RWNGVkVoMCtRYVFvanJQ?= =?utf-8?B?N3Y2NTlLMmw3dk9rUWh0bUxuaU5ObEs0SmFnOWxmRWVZU3cwZGJyR3lxQkpK?= =?utf-8?B?WTA0bE01T0NRZmR6em94RXpDME9HbVV1QnpzalRnSkpYS2JSbXpkc3NFbUZR?= =?utf-8?B?T1d6YjY0OWN2OGQ3WFNYQXpYSzFTZ2IybUJ5YkhJQXRmSjgwVFZidk80ZVVW?= =?utf-8?B?MlowSWtqalNPTy9JaEdRRnZscGRGTzRWRmVVVGJpMkRHZUFnRnJWcDZ1MFVT?= =?utf-8?B?eDdVL0JMOXpCRWZ1blNwZ1VIdDJxWkVISUdFNi9kdHhMd1RoMi9ISXJKUmha?= =?utf-8?B?SDFpKzlobDNWQk9MbTlkV3g1ZGNMRkpqUEdYeGdOOFd3YnRFdzMwVDR4Nlpm?= =?utf-8?B?ZVBvNFQzVHg3NlIxd3JSeUJzaS81NHg0WmVmb3hpN0N1UUJqS3R6cEVNRzJj?= =?utf-8?B?NnFlQnVuOS9tdE56d2FnTXMzQnBCc0JiWDFzeGM3Tm9yYkVZOTA0WkVMblVw?= =?utf-8?B?YkpudGhFalBCSktBVFpFcEtsNTdRekpTS3RZSVdjdUIxNzYrQ3p4b3FzRk9Z?= =?utf-8?B?d2ZvSUFKTWFFaGY5VkkwdWpUZXllSXZuWWRHQWlsVkdBeHVHS1dKZkZQSk5v?= =?utf-8?B?U05Ic2VyTXBRakNqRnVHejVtd0s3OXFVVklRY1dneTZEU24yaC9tWlFQVlYv?= =?utf-8?B?bkZPL0Rpc3h1cFhXSFJsUGVKL05BRkVuMmZsSHcvbkVCZm1VUE5tOUlzeUxz?= =?utf-8?B?ck90U1E5ejA2ZWNtbUEvQmFuUkNJOU55WVEwelhUZ3pSd2ZMUjhHOTF6NU9t?= =?utf-8?B?ejhpSlB0T1pRS3JXdEhVVEdLL0tPb2h5am9GV3FFRlQ3WU10L1l6T3MxYVBw?= =?utf-8?B?anAzN21tc09UdWw1a1UwMmpYTzl1dmxOaWg4eFU0Tk9WaUpmNFZlMHVnQXRB?= =?utf-8?B?YUZiNURldVFjd2dPWm9UZitGbnRYY1NQeExxVUVWRXp6cWYvN3AreWVPa05M?= =?utf-8?B?cVJvcC9tOW5XUzJ0bjNYQXlYSTBaeEs2Si91Y1BMTWFQS25WcW50cXRwN1lm?= =?utf-8?B?Y2szSFdCenZOWFp3Y3pmL1NOVmVNcFJ0S3ZuZEV4RmExdkZRMUNMblp5bnNo?= =?utf-8?B?ZCtRTTNwUzBkRkdLY05oaVhENGRBSWwxMmxhQm5mVlpocWx4ZkRGOWNISWVs?= =?utf-8?B?VDdjZ3c5bjd3WWd2Y0VGWEdEQ2xpUk1SZWN5enBKMUFQNUFIa2ViVllzbjhP?= =?utf-8?B?aURnQjF6WnRwamJKVWNCK1lLd0xGbW40VXpRYXFIN3NUblgwdW1adjZpR2F5?= =?utf-8?B?QkF6elNMZGJUUlJ3azN0djZRSVVoanZydUhkTVBIL2t1UE80L2ZUVitDWjRM?= =?utf-8?B?WVIzYzB1SU1KdEYzQ3MxNWh4VzFVMEJoVGlUSzEwaGZXVUJneGdnd3h5WlQ4?= =?utf-8?Q?dXlRFq3QHaKJGNOMWfoyu5CqY?= Content-Type: text/plain; charset="utf-8" Content-ID: <7C7266F3CBADC84FBCCBCEA61F0AC99F@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?b2VKcGJBL1lpRlJFN3hXbU9FQ1c2Uy9jSWE3WDRWNjNYcEFOdHRIVG1iTmt2?= =?utf-8?B?K0ZLV0Yyd3p2aHBDTjV1K3lTUUlkQjNoNWRtWTMyZmNubGFDbTdtemovWjZB?= =?utf-8?B?ak5BY0dHTXB4cXl5a1VzREhDRTJKbWVHWEVGOEpySlMxdjhEenNEVDBHRng4?= =?utf-8?B?R3ltUDZZUXEvUHN0MnF3ZE13ZWpNdGM3VnUwakhuSWoydVB3VHVlYkM4cDBr?= =?utf-8?B?K1VLWkI2QUY2dlp1bmlhVnF0dGs2dGlvdzNVQ2lEVzJpejNSR0ZjRCs2NlZx?= =?utf-8?B?TTNuNGRyemE1dzFQMElwUFdwU1BjTElTd2NWZUNoWk03ZTVVMFBRdVBCejdV?= =?utf-8?B?ZnBvK3hmeHIvN0liMWZmSGFuMWwyQ2ZlM1VqeTVXT0JpdFpHTXRiaFVIR2Rs?= =?utf-8?B?dGtZOFpmZlVSam5nMFpMcDdUTzdCUkgvclczSGVaaGdHWTJkZk8xcTJBUGpr?= =?utf-8?B?OTZBc3l0T3VBRFg4U204Y1pzdmNqUFRsUjYwelJIdmtKb2dsUEFHUFpTVkJj?= =?utf-8?B?ZnErM1FxcWgyZk1vVE9IQlJZQUxXTFJJaEorQ2JPYkhWWWpJOVlYYVZ3R21S?= =?utf-8?B?REZTRTYxVUxzSVZKakZkN1liaDlzKzZ0cUU1QzF1bjhIUHdHelQ3Mk90L2V3?= =?utf-8?B?bUJvSU5wa0x1elFxdkgveFBhLzhqd0FuQ0xUR2xyYit5L2xqbGhJWXIvdHk5?= =?utf-8?B?Z3ZhbVZtc1NLbmUwckZkSTVRUll4RGdBUmdFT1RSSUw2cHEvTlFCUE1MMGh1?= =?utf-8?B?dTNFMFFsaHNzYTZSL2p5Ri9XUXZnK3NDN0NPeFVkUlJIUFhleUsySnVtRWdR?= =?utf-8?B?WXhSM0tHeitQVlFBd0ljcTNqM21kYmxQMjhTNzFINlVUMmY5S094VEpVN2lw?= =?utf-8?B?R0RCQ0pQWUVRL0xrTlVVNVVNdnkxUTlUOEErc204Mldna3N3V01QNVZPZnd0?= =?utf-8?B?VG1ES2p4dzYwT28xN1p0Q05laFNISkpFOHdYOStPc1ZnbUsvT285SFZoSE1T?= =?utf-8?B?dlZ0WjdJVXRCUWdiWEVIWlM3NU41TXNLaVdYcy9seXd1ZW82UnpyUzd0TnFK?= =?utf-8?B?VDFla1NTVHZqRVl1dTRReHRKeGZzbklQSmEvb29wYmZWSk02U21rMERwckd3?= =?utf-8?B?UU1CZ0Y4eHB2dDhaNmYwc1JSRG9pa3FIcXRkekhaV1M0SHpraTZ3blpPODVx?= =?utf-8?B?dGx4aGZMbE5GZktPUkV6YU5HN1ZJQkYxMHZFaW9iU3lOYzk3RFRHSG9vSU1L?= =?utf-8?B?WE5rd28xZVJDYnJtT0VITWVKOWlBUmZtaWpCV29SdXZMM3FqRHA5bGZCdE03?= =?utf-8?B?SkNXZ21qbE4rTWZDOHBPSkc1V3pPcXJIY3pBRnhmSnVvTnFlcW9FYjM5ZSs4?= =?utf-8?Q?ZfkLue8BBDHWEpzcre0qls60YV+b4PNQ=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33ca7de7-0321-43ff-9a21-08dac3fa359a X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2022 15:34:23.4442 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t2G1tv4slj4FDUVcNIhOW9Y1JqSU3r/TA1rcYjnkB/9djFm0uoXPQeVT6OwdmvDZ39SSiPtLnkqnwvu0DwOHfPc0dzf05YBI+P0uUohUos8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6587 T24gMTEvMTEvMjAyMiAxNToyMSwgVml0YWx5IEt1em5ldHNvdiB3cm90ZToNCj4gQWxleGFuZGVy IFBvdGFwZW5rbyA8Z2xpZGVyQGdvb2dsZS5jb20+IHdyaXRlczoNCj4NCj4+IEhpLA0KPj4NCj4+ IFdoaWxlIGludmVzdGlnYXRpbmcgS01TQU4ncyBpbmNvbXBhdGliaWxpdGllcyB3aXRoIHRoZSBk ZWZhdWx0IFVidW50dQ0KPj4gY29uZmlnIChodHRwczovL2dpdGh1Yi5jb20vZ29vZ2xlL2ttc2Fu L2lzc3Vlcy84OSNpc3N1ZWNvbW1lbnQtMTMxMDcwMjk0OSksDQo+PiBJIGZpZ3VyZWQgb3V0IHRo YXQgYSBrZXJuZWwgd29uJ3QgYm9vdCB3aXRoIGJvdGggQ09ORklHX0tNU0FOPXkgYW5kDQo+PiBD T05GSUdfWEVOX1BWPXkuDQo+Pg0KPj4gSW4gcGFydGljdWxhciwgaXQgbWF5IGNyYXNoIGluIGxv YWRfcGVyY3B1X3NlZ21lbnQoKToNCj4+DQo+PiAgICAgICAgIF9fbG9hZHNlZ21lbnRfc2ltcGxl KGdzLCAwKTsNCj4+ICAgICAgICAgd3Jtc3JsKE1TUl9HU19CQVNFLCBjcHVfa2VybmVsbW9kZV9n c19iYXNlKGNwdSkpOw0KPj4NCj4+IEhlcmUgdGhlIHZhbHVlIG9mICVncyBiZXR3ZWVuIF9fbG9h ZHNlZ21lbnRfc2ltcGxlKCkgYW5kIHdybXNybCgpIGlzDQo+PiB6ZXJvLCBzbyB3aGVuIEtNU0FO J3MgX19tc2FuX2dldF9jb250ZXh0X3N0YXRlKCkgaW5zdHJ1bWVudGF0aW9uDQo+PiBmdW5jdGlv biBpcyBjYWxsZWQgYmVmb3JlIHRoZSBhY3R1YWwgV1JNU1IgaW5zdHJ1Y3Rpb24gaXMgcGVyZm9y bWVkLA0KPj4gaXQgd2lsbCBhdHRlbXB0IHRvIGFjY2VzcyBwZXJjcHUgZGF0YSBhbmQgY3Jhc2gu DQo+Pg0KPj4gVW5sZXNzIGluc3RydWN0ZWQgb3RoZXJ3aXNlIChieSBub2luc3RyIG9yIF9fbm9f c2FuaXRpemVfbWVtb3J5IG9uIHRoZQ0KPj4gc291cmNlIGxldmVsLCBvciBieSBLTVNBTl9TQU5J VElaRSA6PSBuIG9uIHRoZSBNYWtlZmlsZSBsZXZlbCksIEtNU0FODQo+PiBpbnNlcnRzIGluc3Ry dW1lbnRhdGlvbiBhdCBmdW5jdGlvbiBwcm9sb2d1ZSBmb3IgZXZlcnkgbm9uLWlubGluZWQNCj4+ IGZ1bmN0aW9uLCBpbmNsdWRpbmcgbmF0aXZlX3dyaXRlX21zcigpLg0KPj4NCj4+IE1hcmtpbmcg bmF0aXZlX3dyaXRlX21zcigpIG5vaW5zdHIgYWN0dWFsbHkgbWFrZXMgdGhlIGtlcm5lbCBib290 IGZvcg0KPj4gbWUsIGJ1dCBJIGFtIG5vdCBzdXJlIGlmIHRoaXMgaXMgZW5vdWdoLiBJbiBmYWN0 IHdlJ2xsIG5lZWQgdG8gZml4DQo+PiBldmVyeSBzaXR1YXRpb24gaW4gd2hpY2ggaW5zdHJ1bWVu dGF0aW9uIGNvZGUgbWF5IGJlIGNhbGxlZCB3aXRoDQo+PiBpbnZhbGlkICVncyB2YWx1ZS4gRG8g eW91IHRoaW5rIHRoaXMgaXMgZmVhc2libGU/IE92ZXJhbGwsIHNob3VsZCB3ZQ0KPj4gY2FyZSBh Ym91dCBLTVNBTiB3b3JraW5nIHdpdGggcGFyYXZpcnR1YWxpemF0aW9uPw0KPiBJIHRoaW5rIFhF TiBQViBpcyByZWFsbHkgc3BlY2lhbCwgbGV0J3MgQ2M6IHhlbi1kZXZlbEAgZmlyc3QuDQoNClhl biBQViBoYXMgc29tZSBzb21lIHF1aXJrcywgYnV0IGl0J3MgcmVhbGx5IG5vdCBhcyBzcGVjaWFs IGFzIG1vc3QNCnBlb3BsZSB0aGluay7CoCBDZXJ0YWlubHkgbm90IHJlbGV2YW50IGhlcmUuDQoN Ckl0J3MgYWN0dWFsbHkgbG9hZF9wZXJjcHVfc2VnbWVudCgpIHdoaWNoIGlzIGJyb2tlbiBoZXJl LCBhbmQgd2FzIGZpeGVkDQppbiB0aGUgY2FsbCBkZXB0aCB0cmFja2luZyBzZXJpZXMuDQoNCmh0 dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xrbWwvMTY2NjAxODQ3MTEzLjQwMS4xMzYxNjgxMDU5MzUx MzM2Nzg5My50aXAtYm90MkB0aXAtYm90Mi8NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Fri Nov 11 15:59:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 15:59:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442653.697051 (Exim 4.92) (envelope-from ) id 1otWRF-0003Vt-FK; Fri, 11 Nov 2022 15:59:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442653.697051; Fri, 11 Nov 2022 15:59:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otWRF-0003Vm-AR; Fri, 11 Nov 2022 15:59:29 +0000 Received: by outflank-mailman (input) for mailman id 442653; Fri, 11 Nov 2022 15:59:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otWRD-0003Vb-Rr; Fri, 11 Nov 2022 15:59:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otWRD-0002je-PI; Fri, 11 Nov 2022 15:59:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otWRD-0007fq-9j; Fri, 11 Nov 2022 15:59:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otWRD-0000Gz-9E; Fri, 11 Nov 2022 15:59:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vQAJeXAyVA6QhwxGvbOqR29vLWTy4Px594Bu0B3bHQY=; b=jEjyyyf/uw+22kfY2kjnC1aPJ4 nh1m3Qin5BCXurR5dkKglgDKjVuSSm6ADJxBkfBXrm6yPy/ECaUq9vl+ZyH6MVnHMMwOaiDHNysPK 3xgJifno2q8h3T3u6meX1Hx1QA/9capemlLpTxP/ejCEoJEVd03nXMtpHN9EKp3VKCYY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174733: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=08c6f57cfebad4046dabc05092b4a27c61a39980 X-Osstest-Versions-That: xen=a4180b03fffafa1868b0bcacc20198d4caef2908 From: osstest service owner Date: Fri, 11 Nov 2022 15:59:27 +0000 flight 174733 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174733/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174724 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174724 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174724 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174724 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174724 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174724 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174724 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174724 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174724 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174724 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174724 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174724 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 08c6f57cfebad4046dabc05092b4a27c61a39980 baseline version: xen a4180b03fffafa1868b0bcacc20198d4caef2908 Last test of basis 174724 2022-11-10 19:21:35 Z 0 days Testing same since 174733 2022-11-11 06:01:23 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Luca Fancellu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a4180b03ff..08c6f57cfe 08c6f57cfebad4046dabc05092b4a27c61a39980 -> master From xen-devel-bounces@lists.xenproject.org Fri Nov 11 16:18:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 16:18:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442661.697063 (Exim 4.92) (envelope-from ) id 1otWj0-0006s5-67; Fri, 11 Nov 2022 16:17:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442661.697063; Fri, 11 Nov 2022 16:17:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otWj0-0006ry-0q; Fri, 11 Nov 2022 16:17:50 +0000 Received: by outflank-mailman (input) for mailman id 442661; Fri, 11 Nov 2022 16:17:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otWiz-0006rs-1Y for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 16:17:49 +0000 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [2a00:1450:4864:20::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 617531e1-61dc-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 17:17:47 +0100 (CET) Received: by mail-ej1-x630.google.com with SMTP id kt23so13611002ejc.7 for ; Fri, 11 Nov 2022 08:17:47 -0800 (PST) Received: from [192.168.1.93] (adsl-235.109.242.225.tellas.gr. [109.242.225.235]) by smtp.gmail.com with ESMTPSA id fi11-20020a056402550b00b00461c1804cdasm1275204edb.3.2022.11.11.08.17.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Nov 2022 08:17:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 617531e1-61dc-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XXjrCI04EMEzHiFcpiETeIefl7LbYSYwy1waySB6kBw=; b=XD4Bpv0QcKegzLvzhdebKdsYmiCxqTFb5e4OiPfdi+rKpOVY5N4Pf+Dej+yqSsB4cp irfFINdp9vjtwnMs7VB1d7O5eJ/tRn5WadorgD76c6eQZmEZWaOQk07IZMNb2oCp83Sv a/wVEOmPq9NwTWiyo9ZDtc+4Uw02xrX7y9CdmyufuUSd54WHwfK25SPbTbYfv0hN2wKO Bvd3UeG4OqLVLc0IZyAR+fn+DIjWx/5qFZg/MOcih7sr9NXZFL3ITY+E8yAU7XI+A9J2 RcrVrKfEj6jNIBBZeevxdFrsKcpyj+RtZ+7POgTWGdARb1DRGBsaO5ca6vZhyNCLfz4p EuNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XXjrCI04EMEzHiFcpiETeIefl7LbYSYwy1waySB6kBw=; b=xwhX5qOG8kzJj66dsc0Qp491ol3DAeS+w+ROcCSdyqlQe4nJcVFo0pXHwQQ2oDR/rc 6pA+H3FEiwOR0MbLcu05LkbmBz+gAOr8m9vlJKOcPsg2kVzX3QUoQfaLAwvvexZTSwSf Yc6chf2BOndPwyPqDQ8yp/DzumA6aL8iKSFCA3bMFqLXsYZTtf9ogQ5ChaC3Xgnisyba TdI0d8AsxsAHE2rKqmHUCKUpA3aKEOBbWIgBgiQ3D6mRrbV/nwhJFO3wPQ4RYRC3dUgq s9N6A6lvtr6XJerUS0j6mR2Zf+X8upfx8TwR2Jt+2opu1aQnvnANm80iRUXBbIXOpaW+ XanA== X-Gm-Message-State: ANoB5plZ/ruB8X6VRb17FzKWx0Nsl0J2UKWCDHTswhmlRBuwbaFPfopF CAOcVgs2p6WBcD5RI7vb4II= X-Google-Smtp-Source: AA0mqf7Lv8kNiAW3eH5AgwpyJcc5OzzP1sQ7R+10oP7P6H6vve5TR5jFwrMvaijr1oW3E6UaVvlLHw== X-Received: by 2002:a17:906:c9d9:b0:78d:46b1:3cf2 with SMTP id hk25-20020a170906c9d900b0078d46b13cf2mr2426451ejb.727.1668183467028; Fri, 11 Nov 2022 08:17:47 -0800 (PST) Message-ID: <3ea29174-abb4-0fe9-fde8-28d4d62f2f67@gmail.com> Date: Fri, 11 Nov 2022 18:17:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [XEN v3 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com, jgrall@amazon.com References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-12-ayan.kumar.halder@amd.com> From: Xenia Ragiadakou In-Reply-To: <20221111141739.2872-12-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 11/11/22 16:17, Ayan Kumar Halder wrote: > On AArch32, ldrd/strd instructions are not atomic when used to access MMIO. > Furthermore, ldrd/strd instructions are not decoded by Arm when running as > a guest to access emulated MMIO region. > Thus, we have defined readq_relaxed_non_atomic()/writeq_relaxed_non_atomic() > which in turn calls readl_relaxed()/writel_relaxed() for the lower and upper > 32 bits. > As GICv3 registers (GICD_IROUTER, GICR_TYPER) can be accessed in a non atomic > fashion, so we have used {read/write}q_relaxed_non_atomic() on Arm32. > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from :- > v1 - 1. Use ldrd/strd for readq_relaxed()/writeq_relaxed(). > 2. No need to use le64_to_cpu() as the returned byte order is already in cpu > endianess. > > v2 - 1. Replace {read/write}q_relaxed with {read/write}q_relaxed_non_atomic(). > > xen/arch/arm/gic-v3.c | 12 ++++++++++++ > xen/arch/arm/include/asm/arm32/io.h | 9 +++++++++ > 2 files changed, 21 insertions(+) > > diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c > index 6457e7033c..a5bc549765 100644 > --- a/xen/arch/arm/gic-v3.c > +++ b/xen/arch/arm/gic-v3.c > @@ -651,7 +651,11 @@ static void __init gicv3_dist_init(void) > affinity &= ~GICD_IROUTER_SPI_MODE_ANY; > > for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i++ ) > +#ifdef CONFIG_ARM_32 > + writeq_relaxed_non_atomic(affinity, GICD + GICD_IROUTER + i * 8); > +#else > writeq_relaxed(affinity, GICD + GICD_IROUTER + i * 8); > +#endif > } > > static int gicv3_enable_redist(void) > @@ -745,7 +749,11 @@ static int __init gicv3_populate_rdist(void) > } > > do { > +#ifdef CONFIG_ARM_32 > + typer = readq_relaxed_non_atomic(ptr + GICR_TYPER); > +#else > typer = readq_relaxed(ptr + GICR_TYPER); > +#endif > > if ( (typer >> 32) == aff ) > { > @@ -1265,7 +1273,11 @@ static void gicv3_irq_set_affinity(struct irq_desc *desc, const cpumask_t *mask) > affinity &= ~GICD_IROUTER_SPI_MODE_ANY; > > if ( desc->irq >= NR_GIC_LOCAL_IRQS ) > +#ifdef CONFIG_ARM_32 > + writeq_relaxed_non_atomic(affinity, (GICD + GICD_IROUTER + desc->irq * 8)); > +#else > writeq_relaxed(affinity, (GICD + GICD_IROUTER + desc->irq * 8)); > +#endif > > spin_unlock(&gicv3.lock); > } > diff --git a/xen/arch/arm/include/asm/arm32/io.h b/xen/arch/arm/include/asm/arm32/io.h > index 73a879e9fb..4ddfbea5c2 100644 > --- a/xen/arch/arm/include/asm/arm32/io.h > +++ b/xen/arch/arm/include/asm/arm32/io.h > @@ -80,17 +80,26 @@ static inline u32 __raw_readl(const volatile void __iomem *addr) > __raw_readw(c)); __r; }) > #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \ > __raw_readl(c)); __r; }) > +#define readq_relaxed_non_atomic(c) \ > + ({ u64 __r = (((u64)readl_relaxed((c) + 4)) << 32) | \ > + readl_relaxed(c); __r; }) As Julien pointed out, the expression c will be evaluated twice and if it produces side effects they will be performed twice. To prevent this, you can either assign the expression to a local variable and pass this one to readl_relaxed() or use a static inline function instead of a macro, for implementing readq_relaxed_non_atomic(). The latter is the MISRA C recommended (not strictly required) approach according to Dir 4.9 "A function should be used in preference to a function-like macro where they are interchangeable". ... > > #define writeb_relaxed(v,c) __raw_writeb(v,c) > #define writew_relaxed(v,c) __raw_writew((__force u16) cpu_to_le16(v),c) > #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c) > +#define writeq_relaxed_non_atomic(v,c) \ > + ({ writel_relaxed((u32)v, c); \ > + writel_relaxed((u32)((v) >> 32), (c) + 4); }) ... same here. > > #define readb(c) ({ u8 __v = readb_relaxed(c); __iormb(); __v; }) > #define readw(c) ({ u16 __v = readw_relaxed(c); __iormb(); __v; }) > #define readl(c) ({ u32 __v = readl_relaxed(c); __iormb(); __v; }) > +#define readq(c) ({ u64 __v = readq_relaxed_non_atomic(c); \ > + __iormb(); __v; }) I think that, here also, the macro identifier needs to inform that the access is non-atomic. ... > > #define writeb(v,c) ({ __iowmb(); writeb_relaxed(v,c); }) > #define writew(v,c) ({ __iowmb(); writew_relaxed(v,c); }) > #define writel(v,c) ({ __iowmb(); writel_relaxed(v,c); }) > +#define writeq(v,c) ({ __iowmb(); writeq_relaxed_non_atomic(v,c); }) ... same here. > > #endif /* _ARM_ARM32_IO_H */ -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Nov 11 17:35:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 17:35:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442671.697073 (Exim 4.92) (envelope-from ) id 1otXwN-0007ky-QC; Fri, 11 Nov 2022 17:35:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442671.697073; Fri, 11 Nov 2022 17:35:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otXwN-0007kr-Mm; Fri, 11 Nov 2022 17:35:43 +0000 Received: by outflank-mailman (input) for mailman id 442671; Fri, 11 Nov 2022 17:35:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otXwL-0007jE-GO for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 17:35:42 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4075c659-61e7-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 18:35:38 +0100 (CET) Received: from mail-mw2nam12lp2042.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Nov 2022 12:35:13 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB5861.namprd03.prod.outlook.com (2603:10b6:510:3a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 17:35:10 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 17:35:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4075c659-61e7-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668188137; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=smZ58v/FslrPexfN30gyavdb6Ze/BgyaJ4Zpb6h/nTI=; b=J/1e0Nqu8tI3iuGaZSoD/SBgtuN0t3HWD5ia5vcCM8zMPaHhMoyiZWuF RKi9pZM13Y+pbQgzYvPnWF+KDOZuA7+0ICvOdC/mX7IIg3mW3npae7/wN sS6wpLLH/1LSCHYBcLEeoRhmNAHA8dTMqtgLTtFJLtsYc1JCwydacbLdD 8=; X-IronPort-RemoteIP: 104.47.66.42 X-IronPort-MID: 83730408 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:u+0Zoq1F9B2uKv834/bD5bdxkn2cJEfYwER7XKvMYbSIYAOW5UVBk yoBGTfRCku5EmCjKoh/Ponjp0JX6sODmoI2QQtlqCpmFCNEosaYCdrDIBqhZy/OI5DNEB9tt c4VZ4OYIpk/FiWD+E71aeS78XIUOc1kJ1bZILes1ndZFFE/E3tJZWtfptMEbq5UbfmRUl3c5 d+irpXVNg6pgzR6bTtF5vuIpB5i5ar54zlC4wxvOfwTsFHgzHREV5h3yYNdjZfbatINQrPlH barIJWRpD6xE8IFU4v9+lrDWhRWBOWUZU3W0CE+t5GK2nBqvjY13rswKM0SYEJWjyTht91qw ZBGuIfYpT0BZ8Ugo8xAFUgGe81CFfceouWeeCHm6Zb7I3DuKBMA/d0/VCnaAqVAkgpHKTkm3 eAVLjkLcieCi4qeqF5sYrAx7iiLBJCD0LI34hmM/xmAZRoVacmrr5Hxzc1ZxF8NavVmRp4yU Sa7hQ1HN3wsazUXUrse5QlXcO2A3hETeBUAwL6ZSDZeD8E+A2Wd3ZC0WOc5dOBmSu1sm3ay9 0zr4F/YDzoDNde1yxGCr1iV07qncSPTAOr+FZWe39sz2hi2+TZWDxcbE1ymvfO+l0iyHcpFL FAZ8TYvqq5081G3St76XFuzp3vsUhw0AoIMVbFlrl/TjPaOi+qaLjFsojppQdoqrsIpAxct0 UeEhYjBDj1zqryFD3ma8994qBviYndOdTNaNUfoSyNfzYTthpkKii7gDf9dV7OxseLoBhD/l mXiQC8Wwu97YdQw/6ex8E3DgjmsjoPUVQNz7QLSNkqF4wVjdciaboqnwVHB6LBLK4PxZkGIo Xwsi8WYqucUAvmliyilUOgLWraz6J6tMiDax1hmHJAj9jGk03+lYY1Upjp5IS9BMcsaeDmvf E7avytQ4oNeOD2haqofS5K8DYEmwLbtEfzhV+vIdZxeb55pbgiF8SpyI0mK0AjQfFMElKg+P dKebpyqBHNDU6B/lmLqHaEazKMhwT04ySXLX5fnwh+70L2YInmIVbMCN1jIZec8hE+ZnDjoH x9kH5Pi431ivCfWM0E7LaZ7wYg2EEUG IronPort-HdrOrdr: A9a23:3itKqKtUD4YGBAklKidV7yno7skCR4Aji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKdkrNhR4tKPTOW9VdASbsP0WKM+UyGJ8STzI9gPO JbAtBD4b7LfBRHZKTBkW+F+r8bqbHpnpxAx92utkuFJjsaCZ2Imj0JbjpzZXcGITWua6BYKL Osou584xawc3Ueacq2QlEDQuj4vtXO0L72fBIcABYjyQ+WyRel8qTzHRS01goXF2on+8ZtzU H11yjCoomzufCyzRHRk0fV8pRtgdPkjvdTGcCWjcARCzP0ziKlfp5oVbGutC085Muv9FEput /RpApIBbU911rhOkWO5Tf90Qjp1zgjr1X4z0WDvHflqcvlABonFston+tiA1vkwntlmOs5/L NA3mqfuZYSJwjHhj7B69/BUAwvvlaooEAljfUYgxVkIMgjgf5q3M4iFXFuYdM99RHBmcca+S 5VfYfhDcNtABanhrbizzBSKZKXLywO91y9MzU/U4SuokRrdTZCvgolLYUk7wk9HNhWceg628 3Udqtvj71AVckQcOZ0A/oAW9K+DijXTQvLK3/6GyWuKEipAQO+l3fb2sRC2AiRQu1A8LIi3J DaFF9Iv287fEzjTcWIwZ1Q6xjIBGGwRy7kxM1S74Vw/uSUfsugDQSTDFQ118ewqfQWBcPWH/ 61JZJNGvfmaW/jA5xA0QHyU4RbbXMeTMoWsNAmXE/mmLOBFqT68ujANPrDLrvkFjgpHmv5H3 sYRTD2YN5N60i6M0WI9yQ5m0mdDnAX0agAY5QypdJjubTlHrc8wjQ9mBC++tyBLyFEv+g/YF Z+SYmX55+GmQ== X-IronPort-AV: E=Sophos;i="5.96,157,1665460800"; d="png'150?scan'150,208,150";a="83730408" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TX89Wla0wRTdwDGcecHaR8Xx0aJwhIy8r478v9jIBzCo7MRYNRBv5XRcUs0JFW4gmajlBsBMqe/FoEs3C1TR1jjQKg2pLo/fMiSM6gFXsVYyLB3affrIqpTC8cmMLffvSBgsElBbTqciZh9OGWZL8i7uLgIMGApzuPJ4KGkzsbNubTGRz7Rz4oTnebrDROPIpjxamBQTPiJ7IORT8fzfRvjkZJMa0tv58fDtaPRtO01WGLaNNpwV76AY6w4QcUpN8EkKReVm3XwsRdxv9dVn99Q6eo5nwwTtQMXb4Bl/gc4ExJp1a6MF6u6qRrq91ofv49L1ch3aXM3rsRVUkjUmOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2aNnhXGdbMeRDfxzN5MWwxCstAyPPPnL0PId/USpFHQ=; b=H1dEnBQhk6LOzrF0JyTuTXkc0LuNjHz0WDGWKfBuG7Xdt3rZ9rL11hlEhlb5CXNSyIAnnVVSRTtzOcpVGW3IrhWQugT8FOHIYoi9IjZwLe5R9HN11MQhDLucgAdriLGJDS23OnfEeQG9aPUcVpr/1J/pquHwDMtJIlA9hICgVDefo6HbdxLkZfMI0oS7RyBF9aRQk6lfqgSUF0Ge7UjwbRScoNljoMch6rmMtHYKb43Efl7q5n5xXzgLpXPEtd84Kgbr3/HHji833WZFiZIAuXzT2N9UncrJLNz6lWMcxsPnkRYOGONA2zDpgmmmhezF7fVKfc/Dv5fsPFNJAvH87Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2aNnhXGdbMeRDfxzN5MWwxCstAyPPPnL0PId/USpFHQ=; b=JtZO3t/wV4qfaa1rdkS5EBtJWA8OpPssg9TF7zmXYcAqZ5yJx/7BrvtEbJduXGhWkQWC/VYTbH2PhtBbsWr/Anb76ak5GsWMQQRa9PCbzUdoMH/dupjbv5wiM7WLiiUbMJc1SUGqAnhyiVhG0bqetb3IAmoXBhY4UyDVouv8i8M= From: Andrew Cooper To: Jan Beulich CC: "Henry.Wang@arm.com" , Paul Durrant , Wei Liu , Jun Nakajima , Kevin Tian , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Thread-Topic: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Thread-Index: AQHY8GkXjZEVf2M/t0iebvsck9V8qq44y+aAgACWeYCAAKSxAA== Date: Fri, 11 Nov 2022 17:35:09 +0000 Message-ID: <4d0edf44-bb7c-85d9-0890-79c999428ef6@citrix.com> References: <20221104161815.38007-1-roger.pau@citrix.com> <69841767-ccc4-5eeb-6e9c-d59dfb197ea5@citrix.com> <8e52a065-0141-f75c-03e8-e9ceb18a0aa1@suse.com> In-Reply-To: <8e52a065-0141-f75c-03e8-e9ceb18a0aa1@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: yes X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB5861:EE_ x-ms-office365-filtering-correlation-id: 02a65f88-6730-45d7-bdcb-08dac40b148c x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L2g1zNWwjfdc8+9/GkuMSM/Ev0USuNqJDxV91rg8EQA3RGQzFZH27+tMOgk+3Ftv4ZHGWN6vr0vEk1lR1EBcD+eVFO7Wz1x7PiwhV+JfYW5Sb8RG5XWnza6KxqZ7ItzJh0BMRm1rnAS/7bwSQKfly6SuPIt8BlkCnOdciKiSRZzTaxjs5/kxW/fGNXVZ/LH8cHqgj7uhnNpg8LYapVQnJZnAxVAeT72SosUW5lQBy1GTMNDml+jopXL/OHgu/EO5Uj0CBkWYLZPZ/2uwa0wWCDZ2NeQmljI7rZUc84h02FLQnfhnxj3QRaOKmY7tX4lx+eyU7G/c2+KkqZh3oGCNvaEOL9DZXc8CuclXvZuO1aoQa7HrQx9I76aeAj7kBOK81KRCrBZoW/iKWlnyyacCGNlmpATdr0qpAKl50tiLmmyYyx+/LQbFhRYTXPzk2Foy68onx+vmr4eLVcok9G3HuobVyuxj35/+ldve9A8EZyz9vhu3naMO6ajz4MtYoK0AzNktNl4dSaMR7mnP4/2yE8klSFA4+4+EKeIFydWshYNiSHAFi0ZlDghUvmteBpD49HZR9+QEZFXJt4CrWY7ihtAq0T1BE0c4JDGAFmPkIatl9NJT/m3VLyYfgja2hSgKWnEVKfvVbsaoftHc/O+o1cxzBInFuBEe3NvGBiu+n9mk8uJAONp306Vko886waHI6jJH/qqinnv+HLdl4kNo/Z847ghc2QMSIZzyTZi0H5dLj3jzRTJ+XJp0JBR++JdElQin/ldXbU2d1F/WPgP7MXkL6j4mldL19jAx110SR4rmqwCypqmTxLdBsfUPXSPmgOZnq7TJmPmaGyUumluCRw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(396003)(366004)(346002)(451199015)(122000001)(82960400001)(38100700002)(71200400001)(38070700005)(6916009)(54906003)(83380400001)(91956017)(6486002)(66476007)(4326008)(26005)(66446008)(6512007)(66946007)(66556008)(64756008)(8676002)(76116006)(31696002)(316002)(2906002)(99936003)(478600001)(41300700001)(5660300002)(6506007)(53546011)(8936002)(36756003)(31686004)(2616005)(86362001)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UnBOcVk3ZUN1Q3hoQ091dXJMRmdURW9KQ25RQ29QTVNWV0R4NnlLZUZlc1N1?= =?utf-8?B?YWZnQnUxdk4zbWU0dHlVeDN2Mkl6RnVBY05JdnlEaWpYMVVtejZYY3oybnFx?= =?utf-8?B?VFUwems2NnZyWlRlbklhai9EOU9kYlJ1bkF2Q3ZBTHM4b2ZMbG5UNjFmdFdY?= =?utf-8?B?SXUzb0NXWjg1bStQaEFod0o4SmNaM1RDY3A2dW04QU1UWS9ORFd4QUY5VmZj?= =?utf-8?B?Tmk4ZFhiVFVGYW9ROFM2QW03U2ZRT25JZU9OWmxQQWRpVDJULys5eGdnK0RZ?= =?utf-8?B?cDEwdTRKNTZCWTVjSUIyREc0d3dxRnZjUEJ2Y3N5dDlZNWxhU2pvWGN4elhT?= =?utf-8?B?VjRNSlF6eVNwQjBiVTg3M3IrdFZtMXd6eUloVHNReGFtcUp3ZjlYL0ZDeFIw?= =?utf-8?B?NWdkS25NNVJGRWRKR0NYRmZVK0FWRTlPdEdWTTlGVGdLT3ZvejhPTXBmN3ZD?= =?utf-8?B?MFp4ZkdqdEdWZHIzS0VPUkNGTmwxOUk0UnVvUTdVYjRjM3VSWDFhRmI1TXlV?= =?utf-8?B?SWhEMGdJL1J2UGFXemlIY0gzeHhsYmE5SVFiMW9MK3JjS3RISStFQi9ZZ1N3?= =?utf-8?B?NHFPSnROZytpVkw5VUdBcGlUb3BKZU5mdVB1OWxrSUdKbHNDWE1rNnZZSnFw?= =?utf-8?B?c241YVMzYWxLTFB3NzNDamdPNk1ESVBqbWE0MVkxTy9scXg2NGt2cDVuM2M3?= =?utf-8?B?NDlnUjc3MEFWTnFlQi9vYklLY0JPTE9Yc2NLQ3JpLzB3RHpocDJuSzhKcUFW?= =?utf-8?B?SEE2L0R4NFhKSmU4Y3JRM3ZDUEtrQkd2QTZkRGdJbEtZYnhVb1NYRHliTlN3?= =?utf-8?B?QjRSYWNQVzFzdndxeW9IM1M5RmozUWdVQUxqeDJRcjFkbGFUVjZGQk8zTkdk?= =?utf-8?B?Mm5rWDZ5ZlNmOEh1aUhRaGNDL2lBN2xlMGM5RDluVG9OQzVkRVpqdk52SWhS?= =?utf-8?B?Qm1nSklNbGxtOHRKN3Q2elkzUURjMWF0VTBodU1ONlpYNS9HcTU2MW5ZMkVB?= =?utf-8?B?M204ZS82Y3ZXV01rLzM5S2VQVXFxRm1oZVFwVlpadWlYNjZnRitjNmlSa05R?= =?utf-8?B?cW1UMitTclBtZlVFZ0FEOXVtd1VGSHZtdGl2eDE3RmthNWR0dVo1cmJIVDJJ?= =?utf-8?B?dmxka2JycE16ZzJ6QVZubyt2eHJxblhXVjNnY1RrWmR4MkVuaDVGTmppeEoz?= =?utf-8?B?WVVEcGxFV3lRcE4vYzRoY3pmc1JiZ2tLeWx6amV3RHFtS1VTMysxU2J0czZY?= =?utf-8?B?NTE5Z1dQUEhPWk44cGhuYjlYb1V1d3A4Sm9xcWtER2pVREhYN1daT2dNVGEw?= =?utf-8?B?WHBnRlhVbm5JWnVJOWxVRytHR1krRGgxVmpNVi90a1hvbk0zaVBNRzhwU2ZJ?= =?utf-8?B?UUpJUzhmMVFyZG5zYW14TnoyTUdlSTBKNG5SQTF1S0dVNXdTRm5EY0QxeEY0?= =?utf-8?B?VmZ3VFFNZC9xcnJvMGZNSjVmLzlFTnplYlJKaVNDYnJVYzJmaFdyTmlHd05E?= =?utf-8?B?eVBFMTIxamdvOU8rN3p1aWNUUWlncTBBamtyb2c4NDloQ0Nzd1R5bnZhUjh0?= =?utf-8?B?bkRqaGhjK0hqRlVtWElVbkdwOEV5WWlZdnR1T0Rkd09RQ2Z6cWFvbFNTQ2tk?= =?utf-8?B?MWoxUE5FNWt0OWF3ZEJsUnU4OW8wQVB3OVNFcW9Sc2p5ZDEvblN2YXo1REVC?= =?utf-8?B?WnViVVRHUWVwY29rekpsMVVIbWpvNTFZejNMWStRdWNnTXlYV0paS3NBNmly?= =?utf-8?B?NnlaZUVsQ1RjK0pjbENvVjg1SjdTcUJzWmIxZ3BtRDVRcVFrcGR4d2k4OC9z?= =?utf-8?B?QkM2QkptQzFiSmFZcmFJa1BHSEN1NVBpaTRYbSswUUcxL0RaekpDeFpSNHEw?= =?utf-8?B?QVZBTnFlZks1Wks4T0p6aTJJYklMWlpuVkZ5U0s2VktZMnMyVU5iUXFQSDd6?= =?utf-8?B?RWs3ZEFTemRUOEF2YkxGdGxBbmN4c1VsS3BPR04vdnY4T3lxZzVjeFprYkxx?= =?utf-8?B?Z1BGcnZaempObXRBRVJIaVc1a09IeXZJUzIvQ0x0WjV6aDg1VGxYVWlEbjRD?= =?utf-8?B?UlM0OXhVaFB4ZGtlcElxdFc4THBxbGx4anNPREVXYytUOU5nQXZtZCtTL1Js?= =?utf-8?Q?sBOy+9DDZtKPf8+MUVWUP5JIF?= Content-Type: multipart/mixed; boundary="_002_4d0edf44bb7c85d9089079c999428ef6citrixcom_" MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Jad9JWaThyV6nZYLeUAM3OgESoGIExujrGsJSWMSAYRO/8+SFXLVn0w3iD9kgqW52vbBnUXS3aXpkgZY5VReSCxbw3vd/QmScpg/EXazO9bHe7KsfJoXK2TCP6EcKhfB0pNNBaeHB5aFT0q6ad3xMWmlgt52fWjdfeWl5VIHkKEEz/inoQFAKuqc6Jvzy/Ezz97lB25NwxQuS3cqH/lH088fyjrxKv0Zrzh1L+LVwb7p7o70QdbTCayYvweoBWzE1iVVZ4feKBROD4zSaKXqatLs5F3eZ8frA703Jjpt6nHoF34qOcTEiTRiO4IEme+3zT69YoEPUD82UHy87QYeLOyG/4DPW3OzyobO5llhu4zwywP24yf7eSS9BKGIksg7wO/dj1CuDOu4h6CHkVWviuwca8zlloSUZW9a5DQ1VcSbumPULjjsEcjn1wzJYksj0vTTQzwJevG+QonHXwLYH/oKXZ+Q/1OlehSt6mtSyY+bIb6+8WU0t61d0J8O2d5jdwPqECYvHAWClXON90hKZUACOfj2qtSbEi4vOhK9yEsJZ5W4FNUU1Zja3m7WiK/zTZTHSNUSeW3EiKp6YNUbrjcmccYU/upzcx224mLhQd9pu327/XeOdyVLOqo57gbz6B4o9CFLLdmn60TX6b+BxGm/qbjcadLAOfaZazaVhlF4SFLfDGt57/BzX0wlKsaSiiLt2ExV00t2IfgKUWEMNWQb+YQ74x+c6TgnzQtOc1LbbwoNMEfnjfPdUmjPdOkEgAk2BSn/2TRgRrzAzz4sRyttmpWLHsyPMzsYA3+Hzvvh7ka8Bf/XKKalZEm2yW3oMQLPp/maGqaXSmErUjWl4ap5NOxSh13k7pwiJwCUgDx+Gi7B2kdjYFGpzJbza2S5T7MGJuFE8hIkLfJToR/5N5fQa6pZOh0blE09CgVqOcU= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02a65f88-6730-45d7-bdcb-08dac40b148c X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2022 17:35:09.4486 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: U2ZsGTwRqwrdjn4oaQ+QVp4KCrad7cE4HYGgNfweZoA0cNQyBrkmJadkk57YDDk1GAm6oAhzmLK/z5CGx89zeyBWge2XpiO06jmK6Gi3va8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5861 --_002_4d0edf44bb7c85d9089079c999428ef6citrixcom_ Content-Type: text/plain; charset="utf-8" Content-ID: <9800EEEA16096446BF62DBFEDA84C2D4@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 T24gMTEvMTEvMjAyMiAwNzo0NSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDEwLjExLjIwMjIg MjM6NDcsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAwNC8xMS8yMDIyIDE2OjE4LCBSb2dl ciBQYXUgTW9ubmUgd3JvdGU6DQo+Pj4gLS0tIGEveGVuL2FyY2gveDg2L2h2bS92aXJpZGlhbi92 aXJpZGlhbi5jDQo+Pj4gKysrIGIveGVuL2FyY2gveDg2L2h2bS92aXJpZGlhbi92aXJpZGlhbi5j DQo+Pj4gQEAgLTE5Nyw3ICsxOTcsNyBAQCB2b2lkIGNwdWlkX3ZpcmlkaWFuX2xlYXZlcyhjb25z dCBzdHJ1Y3QgdmNwdSAqdiwgdWludDMyX3QgbGVhZiwNCj4+PiAgICAgICAgICByZXMtPmEgPSBD UFVJRDRBX1JFTEFYX1RJTUVSX0lOVDsNCj4+PiAgICAgICAgICBpZiAoIHZpcmlkaWFuX2ZlYXR1 cmVfbWFzayhkKSAmIEhWTVBWX2hjYWxsX3JlbW90ZV90bGJfZmx1c2ggKQ0KPj4+ICAgICAgICAg ICAgICByZXMtPmEgfD0gQ1BVSUQ0QV9IQ0FMTF9SRU1PVEVfVExCX0ZMVVNIOw0KPj4+IC0gICAg ICAgIGlmICggIWNwdV9oYXNfdm14X2FwaWNfcmVnX3ZpcnQgKQ0KPj4+ICsgICAgICAgIGlmICgg IWhhc19hc3Npc3RlZF94YXBpYyhkKSApDQo+Pj4gICAgICAgICAgICAgIHJlcy0+YSB8PSBDUFVJ RDRBX01TUl9CQVNFRF9BUElDOw0KPj4gVGhpcyBjaGVjayBpcyBicm9rZW4gYmVmb3JlIGFuZCBh ZnRlci7CoCBJdCBuZWVkcyB0byBiZSBrZXllZCBvbg0KPj4gdmlydHVhbGlzZWQgaW50ZXJydXB0 IGRlbGl2ZXJ5LCBub3QgcmVnaXN0ZXIgYWNjZWxlcmF0aW9uLg0KPiBUbyBtZSB0aGlzIGNvbm5l Y3Rpb24geW91IHN1Z2dlc3QgbG9va3MgZW50aXJlbHkgdW5vYnZpb3VzLCBzbyB3b3VsZA0KPiB5 b3UgbWluZCBleHBhbmRpbmcgYXMgdG8gd2h5IHlvdSdyZSB0aGlua2luZyBzbz8gVGhlIGhpbnQg dG8gdGhlIGd1ZXN0DQo+IGhlcmUgaXMgcmVsYXRlZCB0byBob3cgaXQgd291bGQgYmVzdCBhY2Nl c3MgY2VydGFpbiByZWdpc3RlcnMgKGFpdWkpLA0KPiB3aGljaCB0byBtZSBsb29rcyBvcnRob2dv bmFsIHRvIGhvdyBpbnRlcnJ1cHQgZGVsaXZlcnkgd29ya3MuDQoNCkkgcmVmZXIgeW91IGFnYWlu IHRvIHRoZSBkaWFncmFtLsKgIChGb3IgZXZlcnlvbmUgZWxzZSBvbiB4ZW4tZGV2ZWwsIEkNCnB1 dCB0aGlzIHRvZ2V0aGVyIHdoZW4gZml4aW5nIFhTQS00MTIgYmVjYXVzZSBJbnRlbCdzIEFQSUMg YWNjZWxlcmF0aW9uDQpjb250cm9scyBhcmUgZW50aXJlbHkgdW5pbnR1aXRpdmUuKQ0KDQpJdCBp cyAidmlydHVhbCBpbnRlcnJ1cHQgZGVsaXZlcnkiIHdoaWNoIGNvbnRyb2xzIEVPSS9JQ1IgYWNj ZWxlcmF0aW9uLA0KYW5kIG5vdCAiYXBpYyByZWdpc3RlciB2aXJ0dWFsaXNhdGlvbiIuwqAgVGhl cmUncyBhIGRlY2FkZSB3b3J0aCBvZg0KaGFyZHdhcmUgd2hlcmUgdGhpcyBsb2dpYyBpcyBhbiBh bnRpLW9wdGltc2lhdGlvbiwgYnkgdGVsbGluZyB3aW5kb3dzIHRvDQp1c2UgYSBWTUV4aXQtaW5n IG1lY2hhbmlzbSBldmVuIHdoZW4gbWljcm9jb2RlIHdvdWxkIGhhdmUgYXZvaWRlZCB0aGUNClZN RXhpdC4NCg0KSXQgaXMgbm90IGJ5IGFjY2lkZW50IHRoYXQgInZpcnR1YWwgaW50ZXJydXB0IGRl bGl2ZXJ5IiwgaW50cm9kdWNlZCBpbg0KSXZ5QnJpZGdlLCBpcyBleGFjdGx5IHRoZSBtaXNzaW5n IHJlZ2lzdGVycyAob24gdG9wIG9mICJ1c2UgVFBSIFNoYWRvdyINCndoaWNoIGlzIGV2ZW4gb2xk ZXIpIHRvIG1ha2Ugd2luZG93cyBwZXJmb3JtYW5jZSBsZXNzIGJhZC4NCg0KfkFuZHJldw== --_002_4d0edf44bb7c85d9089079c999428ef6citrixcom_ Content-Type: image/png; name="vmx.png" Content-Description: vmx.png Content-Disposition: attachment; filename="vmx.png"; size=96334; creation-date="Fri, 11 Nov 2022 17:35:08 GMT"; modification-date="Fri, 11 Nov 2022 17:35:08 GMT" Content-ID: <968AB147A8C2D14AA05DF5E0F71432D0@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 iVBORw0KGgoAAAANSUhEUgAABsgAAAEzCAYAAACcz4azAAAABmJLR0QA/wD/AP+gvaeTAAAgAElE QVR4nOzdd1gUV/s38O8uZZeyLL3aEAQs2FAUwViwYKIBSSxJxJhiNM2oD0afFE2iiSYaS6LGltie hKhJJGKLWCNYEAMaQUBBlCp96f3+/eHLvKy7NAVX9P5c11zLzpw5c5+dmXXde885IiIiMMYYY4wx xhhjjDHGGGOMMfaUEGs6AMYYY4wxxhhjjDHGGGOMMcYeJU6QMcYYY4wxxhhjjDHGGGOMsacKJ8gY Y4wxxhhjjDHGGGOMMcbYU0Vb0wEwxhhjjDHGGGOMMcYYYw+roqICpaWlKC8vR1lZGQCgrKwM5eXl AICqqioUFxcDAIgIBQUFKvs2pX59AGBiYtLkPiKRCMbGxsJzqVQKPT09AIC2tjZkMpmwzdjYGCKR SNhHLBZDLpc3eQzGWMtxgowxxhhjjDHGGGOMMcbYI1FdXQ2FQgGFQoGCggKUlJSgpKQERUVFUCgU KC0tRUlJCRQKBYqKioTtBQUFqKmpQWFhIaqrq1FUVCQkvCorK1FSUvJQcd2fxGpI/YRVc49bP2H3 oLS0tGBkZCQk1HR0dGBoaCg8SqVSGBgYQC6XQyaTwcDAAPr6+jAxMYGBgQEMDAxgaGgIY2NjGBgY QCaTwdjYGIaGhg8VF2PtmYiISNNBMMYYY4wxxhhjjDHGGGsfiAg5OTnIzc1Fbm6u0t8FBQVC8qtu qf+8rgeXOkZGRkJipy55o6+vLyR2xGKxUq+qhpJGurq6MDAwAABIJBLo6+sDgEpvLLlcDrH40c9C VFJSgsrKSgDKSbba2looFAoAaDIZeH9vudLSUpSWlqKwsBCFhYVCorEuCVl3vPtpa2vD2NgYcrkc xsbGMDExgbGxsdI6Y2NjmJmZwdzcHBYWFsLfdb3gGGuvOEHGGGOMMcYYY4wxxhhjT7mcnBzcvXsX WVlZyMjIQFZWFjIzM5Gdna02GXb/18qGhoYwNzdXSaw09Fwul8PExAT6+vpCjybWduoSbAUFBUIi TV0SMz8/X21iMzc3F9XV1Up16uvrw8zMDGZmZrC0tFRKotnY2MDKygqWlpawtbWFhYUFpFKphlrP mHqcIGOMMcYYY4wxxhhjjLEnEBHh7t27SE9PR1paGlJSUoS/s7OzkZmZiczMTGRlZaGqqkrYT1tb G5aWlrCysoKVlZWQBDE3N1fbk8jMzAwSiUSDLWWPQn5+PnJyctQmTLOysoR1WVlZSE9PR1FRkdL+ xsbGsLa2hqWlpZBAs7W1hZ2dHTp27AhbW1t06NCBe6axR4YTZIwxxhhjjDHGGGOMMdYOZWVl4fbt 27h9+zZSU1Nx584dpKenIzU1FampqcjIyFAaWs/U1FRIQtQlwGxsbFR6/FhaWmqwVexJUVZWhrt3 7yr1SKzrlZieno6srCy116mZmRlsbW2VkmYdO3ZEp06d0LlzZ3Tq1IkTsqxVcIKMMcYYY4wxxhhj jDHGHkPp6em4desWbt++jTt37gjJsNu3b+PWrVsoKysDcG9uLWtra3To0EFILNjZ2SklGTp27Mg9 c9hjqa6nY1pamlJPx/qJ3tu3b6O0tBQAIBKJYGNjgy5duqBz584qS9euXXk4R9YsnCBjjDHGGGOM McYYY4wxDcnPz0dMTAxiY2ORlJQkLAkJCcIQdTo6OjA3N4etrS26du2qtNQlCgwMDDTcEsbaVn5+ PtLT05GRkaF0ryQlJQnr65iYmCjdJz169EDPnj3h6OgIuVyuwVawxwknyBhjjDHGGGOMMcYYY6wN ZWVlITY2FgkJCYiLi0NcXBwSExORnJwsDC1nbGwMBwcHODo6Kj3a29vD1tYWWlpaGm4FY4+3wsJC 3L59G4mJibh586bS4507d1BTUwMAsLCwgIODA5ycnODi4gJnZ2e4uLjA0dERurq6Gm4Fe5Q4QcYY Y4wxxhhjjDHGGGMPqbq6GklJSYiNjUV8fDzi4+Nx/fp1xMfHIz8/HwBgZGQEZ2dnODs7o1u3bkqJ MHNzcw23gLEnV2VlJZKTk5USZ/Hx8UhISMDt27dRW1sLbW1t2Nvbw8XFRUicde/eHd27d4eJiYmm m8DaACfIGGOMMcYYY4wxxhhjrAXqhkW8fPkyYmNjERMTg6ioKGGOJBMTE2FIt/rDu9nb20MkEmk4 esZYfZWVlUhNTVUa6jQmJgZXr14Vhjmtu6fd3NzQs2dP9OjRA/3794e+vr6Go2cPgxNkjDHGGGOM McYYY4wxpkZZWRn+/fdfREVF4cqVK7h27RquXbsm9Aizs7NDr1690Lt3b/Tq1Qu9evWCi4sLf2nO 2BOAiJCSkoLY2FhcvXpVuP9jY2NRUVEBLS0tODo6wtXVFa6urujTpw/69++Pjh07ajp01kycIGOM McYYY4wxxhhjjD31FAoFoqKilJa4uDhUV1fDyMgIrq6uSskwV1dXHnaNsadQdXU1bt68iX///Rf/ /vsvYmJicOXKFSQlJYGIYG5ujn79+ikt3bp1g1gs1nTo7D6cIGOMMcYYY4wxxhhjjD1VSkpKcPny ZVy8eBERERH4559/kJSUBACwtLRU+XLb0dGRh0ZkjDWqsLAQ0dHRSkn22NhYVFdXw9DQEH379oWb mxsGDRoEd3d3ODg4aDrkpx4nyBhjjDHGGGOMKSkpKUFlZWWD26uqqlBcXPxAdWtra0MmkzVaRi6X 8y9sGWOMtZqamhrExsYiIiICFy5cQEREBGJiYlBTUwMbGxu4u7vDzc1NSIbZ2dlpOmTG2BOivLwc 165dwz///IOoqChcunQJV69eRVVVFczNzeHu7g53d3chaWZqaqrpkJ8qnCBjjDHGGGOMsVZSXV2N oqIilJaWoqKiAsXFxaiqqgIAYa6SujLAvXlNysvLAdz7xWlNTQ1qa2uhUCgAABUVFSgtLQWgnLQq KCgAETVZV0PqYmmv9PT0IJVKG9xuaGgIHR0dABCGvtLR0YGhoaHK/kZGRtDS0oJYLIZcLgcASCQS Ye6Y+nUZGxtDJBIpJfnU1SWXyyGRSITjMcYYe7QKCwtx7tw5hIeHIywsDJGRkSguLoaBgQH69++P QYMGCV9Gd+rUSdPhMsaeMmVlZYiKikJERAQuXryIixcv4tatWwCAbt26wcPDA0OHDoWnpydcXFy4 92ob4gQZY4wxxhhj7KlRXl6OsrIyFBYWoqKiQimZlZ+fj8rKSpSUlKCoqAiVlZVQKBRC4qmgoACV lZUoLi5GcXExKisrUVBQoFRnY0kpdR42EdOcpI46BgYG0NXVbXB7/WRSQ+pibKn6iTx16if9GqJQ KFBbW9vg9qaSjfUTl81NNtavqyUMDAwgkUhgbGwsnCMjIyNIJBLIZDLo6+tDIpHAxMQEurq6MDAw gEwmg66uLuRyuXDe6yfd6tfJGGMMSEtLQ1hYGMLDw3H27Fn8+++/qKmpQbdu3eDp6QkPDw8MGjQI PXv2hLa2tqbDZYwxFVlZWYiIiEBERATCwsIQERGBkpISmJubw9PTE15eXvD09MSAAQMa/ZzPWoYT ZIwxxhhjjLHHXlVVFRQKBQoLC5Gfnw+FQiEshYWFSs8VCgUKCgqUtpeVlaGgoKDJ4zSVoNDV1YVM JhMSTCYmJkLSQ90+TSW1WPvUVLKtqWSrQqFAZWUlioqKhJ6B+fn5Qr3192lK3XVmbGwMuVwOuVwO IyMj4e+65yYmJg1ub2rIS8YYe9ykpaXh5MmTOHnyJM6cOYNbt25BW1sbffv2haenp9DzwtraWtOh MsbYA6mqqsI///wjJP7PnTuHrKws6OnpYdCgQRgxYgS8vb3h7u7OCbOHwAkyxhhjjDHGWJsrLy9H bm4ucnJykJub22iCq35yq257XTLifgYGBmq/8DcxMVFap6enB7lcLiQTGkp2Mfa4aW5Sre6+uf9+ qntel1hW1/NOJBLB2NhYSLKpS7DV3Vf1n5ubm8PMzAxmZmYaeGUYY0+T3NxcnD59WkiKxcXFQVdX F4MHD8aIESPg5eWFwYMH89C2jLEnWnx8PMLDw3HmzBmcPHkSqampMDQ0xNChQzFy5Eh4e3ujT58+ PJdvC3CCjDHGGGOMMdYi5eXlyMvLQ35+vsqSkZGB9PR0lfWZmZm4/78e9XtYmZiYNLg0VMbMzAwS iURDrwJj7VNZWRny8/OFoUHV3ceNbc/NzRXmwquv7h61tbWFjY2Nyv16/3orKytoaWlp4BVgjLUH lZWVCAsLw9GjR3H8+HFcuXIFIpEI/fr1g7e3N0aOHAkvLy9haGHGGHsaJSQkCD8cOH36NLKzs2Fm Zobhw4dj7Nix8PHxQceOHTUd5mONE2SMMcYYY4w9xWpra5GVlYWsrCzk5uYiOztb6OVVv8dXTk4O srOzkZubi+LiYqU6xGKx0IvEzMxM6FVibm4OCwsLpXV1f8vlcp4DhLF2qri4GAUFBUrvDfXfN9St v78XqJaWlsr7gpmZGSwtLVXeT8zNzWFra8tfhDP2hEtOTsbRo0dx9OhRnDhxAsXFxXB2dsaYMWMw cuRIDB8+nOdeZIyxBhARrl69ipMnT+L48eM4ffo0SktL0atXL/j4+MDHxwdDhw5tdB7ipxEnyBhj jDHGGHsCVVZWIicnR6lXl7rHlJQUYf6kOk31BLl/m6WlJSe7GGONaqjnaUO9TtPT01XmDZRKpUrv PXV/3/9obW3NQwsx1g5UV1fjzJkzOHToEI4cOYK4uDgYGBhg5MiRGDduHHx8fGBvb6/pMBljrF0q Ly/H33//jaNHjwrvsYaGhsJ77IQJE2BnZ6fpMDWOE2SMMcYYY4y1I6WlpUhLS8Pdu3eFJFdmZibS 09OFx7t37yI7O1tpP1NTU9jY2AiLtbU1bG1tYWVlBTs7O6VeG/zFMmPscVBaWir0RKv/Xnf37l3h fbDusf6wj1KpVOU9Tt2jpaUlv98x9oiVlpbi6NGjCA4OxqFDh5CXl4cePXoICbGhQ4fy8MmMMdYG kpOTceTIEaGXbmlpKQYOHIiJEyfCz88PLi4umg5RIzhBxhhjjDHG2GOisLAQd+7cQXJyMm7fvo07 d+4gNTUVqampyMrKQlpaGoqKioTyYrEYlpaWSl8Ed+jQAZaWlipfBEulUg22jDHG2lZ2drbww4H6 Pxqo66FWl0yrP9SjtrY2LC0tYWtrC2tra9jZ2aFTp07o3LmzsNja2vJcaYw9pJycHISEhODPP//E sWPHUFFRgSFDhsDX1xcTJ06Eg4ODpkNkjLGnSnl5OUJDQ/Hnn3/iwIEDyM7OhouLC/z8/ODn5wd3 d3eIRCJNh/lIcIKMMcYYY4yxRyQjI0NIfNUt9ZNh9YcTMzU1RefOndGxY0fY2dnB2tpaqQeYjY0N D23IGGMtVFRUhLS0NGRlZSE1NVUpqZaSkiL8MKFu6FltbW106NBBKXFW93fdo56enoZbxdjjR6FQ 4M8//8S+ffvw119/QUtLC15eXhg/fjwmTZoEW1tbTYfIGGMM9+akjoqKQkhICH799VfEx8ejQ4cO 8Pf3x6RJk+Dp6flEJ8s4QcYYY4wxxlgrqKqqEoYBS0pKEpa6YRDj4+NRXFwslDcxMUHXrl3RtWtX Ye6cuueOjo6Qy+UabA1jjD3d8vPzVd7H654nJiYq/aDBxMRE5X28/nu7vb39E/3FEmN1SkpKhC9Y jx49CgDw8fHB1KlTMX78eBgaGmo4QsYYY025cuUK9u7diz179iAxMRFOTk6YOnUqpkyZgh49emg6 vFbHCTLGGGOMMcaaKTs7G4mJibh58yZu3ryJxMREJCUlITk5GZmZmaitrQUA6OnpCb0L6pbOnTuj S5cu6NSpE+zs7KCjo6Ph1jDGGHtQ+fn5Qu/f5ORkpZ7Bt2/fRmZmplDWwMAAnTt3hr29PRwcHODo 6Cg8dunSBbq6uhpsCWMPp7a2FqGhodi5cycOHDiAiooKeHt7Y+rUqfDz84OxsbGmQ3ykbt68iW7d uiEoKAhTp07F7NmzcfToUSQnJ2s6tEdm1apVWLBgAQDAzs4OqampGo6ocTdu3ICTkxMGDRqECxcu qC1jaGiIkpISlfUikQhmZmbw9PTExx9/jIEDBza6z8qVKxEYGKi07tKlS9iwYQPOnDmDzMxM6Onp wdbWFs7Ozhg1ahTGjBnDw5A+QnwPK4uIiMCePXuwd+9epKamonfv3pg2bRoCAgJgbW2t6fBaBY/H whhjjDHGWD3p6elISEhAYmKikAyreywsLAQA6Orqwt7eHo6OjhgwYABefPFFpUSYpaWlhlvBGGOs LZmYmMDExAR9+/ZVu728vFwlaZaUlIRLly4hKCgI2dnZAAAtLS106tQJDg4OKskzJycnSCSSR9ks xpotKSkJO3bswI4dO5CSkoIhQ4bgm2++waRJk2BhYaHp8J4YxcXF6NevH5ydnXHw4EFNh9MsgYGB CAwMRN++fZGTk6O07XFsz/bt2wEAFy9eRGxsrNoeMsXFxYiOjka/fv3g6+uL4OBgAPeGEj158iRm z54NT09PHD58GKNGjWp0nzq1tbVYuHAh1q5di3nz5uHIkSOwt7dHQUEBrl69im+++QbvvPMOgHsj VfCw6kwT3N3d4e7ujpUrVyIsLAxBQUFYvnw5PvroIzz77LN4/fXX8eyzz7brH3/yncUYY4wxxp46 VVVVSElJQUxMDGJjY5GUlISYmBj8+++/QhJMIpHAzs4OXbt2xYABAzB9+nT07NkTXbt2RefOnaGl paXhVjDGGHtcSaVSODk5wcnJSe328vJypKenK/07lJiYiNDQUCQnJws9km1sbIR/e3r06CH8zcM2 Mk0oKyvDb7/9hu3bt+P06dOwtrZGQEAAXnvtNbi4uGg6vCcSEaG2tlZ4T2gpQ0ND9O3bF2FhYa0c 2YN52Pa0ttraWuzatQv9+vVDVFQUtm/fjpUrVzZ7f7lcjokTJ6K0tBTTpk3D3Llzce3atWbt++mn n2LVqlXYsmULZs6cKay3srLC6NGjMXLkSEyYMAFHjhxpcbsYa21isRjPPPMMnnnmGaxZswb79+/H 9u3b4e/vDwsLC0ybNg2vv/56uxyCkRNkjDHGGGPsiVVQUIDY2FjExMTg+vXruH79OhISEoQvH7W0 tNClSxdhWJWAgAA4OzvDycmJJ49njDHWZqRSqTBX2YQJE5S2lZeX48aNG4iPj0dCQgLi4uIQFRWF PXv2QKFQAACMjIzg5OQEZ2dn9OjRA927d0evXr3QtWtX/gEHa3VJSUnYsmULtm3bhoKCAowYMQJ7 9uyBn59fu+410B7IZDIkJiZqOoxW87i159ixY9DW1saWLVswcOBA7N69G8uXL29xb60RI0YAAGJi YlBQUNDk0KJxcXFYsWIF3NzclJJj9WlpaeHTTz/lBBl77EilUrz00kt46aWXkJaWhv/973/YunUr vv32W7i5uWHOnDl46aWX2s2/D5wgY4wxxhhj7V5hYSFiY2Nx7do1XL9+HdeuXUNsbKww54FMJkP3 7t3h4uKCZ555RvhSsVu3bjx8FWOMsceKVCqFq6srXF1dVbZlZGQgPj5eWOLi4rBt2zYkJyeDiCCV StG9e3f06NEDvXr1Eh67dOkCsVisgdaw9qq2thbHjh3Dhg0bcPjwYdjZ2eE///kP3njjDR5Kmj0x fvrpJ8yYMQMDBgxA7969cfXqVRw+fBjPP/98i+ohIuHv5vTu3bJlC2prazFp0qRGy3l4eCjVzdjj xs7ODgsXLsSHH36IEydOYP369Xj99dfx0UcfYfbs2Zg5cyasrKw0HWaj+NMRY4wxxhhrN2pqahAf H4+9e/fio48+wnPPPYfOnTtDLpfDw8MDc+fOxd9//w1bW1vMmTMHhw8fxq1bt1BYWIiLFy9i586d +O9//4sXXngBvXr14uQYY4yxdsXGxgbDhw/HrFmzsHr1ahw+fBhJSUkoLCxEREQENm7ciFGjRiEv Lw+bNm2Cr68vHBwcIJPJMGDAALz55pv4/vvvcebMGRQUFGi6OewxVFpaiu+//x4uLi4YN24cSkpK sG/fPiQlJeG///0vJ8ea4OjoCCLC1KlTAQCbNm1CcnIygHsjG4hEIqVl2bJlAIDq6mql9S+++CKC g4OV1pWXlwOAyvr4+HhMnjwZZmZmwrpFixZBJBKhpKQE4eHhwvq6nlHLli0T1nl5eQnxHz16VFhv bm6u1Lbq6mrs2bMHo0ePhrW1NfT09ODq6op169Y1a8jEhtoDABUVFVi8eDFcXFygr68PU1NTTJgw AQcOHEBNTY1SPdnZ2ZgzZw66dOkCXV1dWFhYwN/fH9HR0S06V3l5eQgJCcGrr74KAHjttdcA3Eua tdTp06cBAD179oRcLm+y/N9//w0A6N27d4uPpU5Lz01ubi7mz58PBwcHSCQSdOjQAaNGjcKOHTtQ VlbW4nLNPSfNPc9tcT00t87G7mHWMJFIhFGjRiE4OBg3b97EK6+8grVr16Jz584ICAho8f35SBFj jDHGGGOPocLCQgoPD6eNGzfSW2+9RYMGDSJ9fX0CQNra2tSzZ096+eWXacWKFRQSEkJJSUlUW1ur 6bAZY4yxx0ZhYSFduHCBtm3bRvPmzaORI0eSqakpASAA1KVLF/L19aXFixfT77//TomJifxv6VMq Ly+Pli5dShYWFqSvr0+zZ8+ma9euaTqsJ5KPjw+JxWK6efOmyjYPDw/65ZdflNb5+voSACorK1O7 ftiwYXTq1CkqKSmhCxcukJaWFmVnZxMRkYGBAXl6ejYYS0Pb3dzcyMzMTGldSEgIAaCvvvqK8vLy KDs7m7777jsSi8UUGBioUkefPn3Izs5OZb269rz55pskl8vp2LFjVFpaSpmZmRQYGEgA6NSpU0K5 9PR06ty5M1lZWdGhQ4eoqKiIrl27RsOGDSOpVErnzp1rsK33+/7772nEiBHC8+zsbNLR0SFtbW26 e/euSvmoqCgCQL6+vsI6hUJBf/zxB1laWpKOjg6FhoY2uQ8RkY2NDQGgixcvNjvexrTk3GRkZJC9 vT1ZW1tTSEgIFRYWUmZmJi1dupQA0Jo1a1pUriXnpLnnuS2uh+bWyVpPaWkpbdu2jfr06UMikYjG jRtHZ86c0XRYKjhBxhhjjDHGNK6yspIiIyNp7dq1FBAQQD169CCxWEwAyMjIiNzc3CggIIDWrl1L Z8+epZKSEk2HzBhjjLVbaWlpFBoaqvbfXZlMRp6enjRnzhzauXMnXbt2jZNmT7C7d+/SkiVLyNjY mGQyGc2ZM4fS09M1HdYT7fjx4wSA3nnnHaX1YWFh1KlTJ6qqqlJa31SC7PDhww0eq7UTZMOHD1cp O23aNNLR0SGFQqG0viUJMnt7exoyZIhKWScnJ6XkxauvvkoA6Oeff1Yql5GRQRKJhNzc3NQ3VI3+ /fvTrl27lNZNnDiRANCqVatUytclu+ovIpGIzMzM6Pnnn6eIiIgG92koQaZunwfRknMzY8YMAkB7 9uxRKe/j4yMkvppbriXnpLnnuS2uh+bWydrG2bNnafz48QSA+vfvT3v37n1sPltwgowxxhhjjD1S FRUVdPHiRdqwYQO99tpr5OrqSlpaWgSAzMzMaOzYsfTxxx/TH3/8QUlJSZoOlzHGGHsqFBUV0blz 52j9+vU0Y8YM6tWrl/Dvs7m5Ofn4+NAnn3xCwcHBlJaWpulw2UPKzMyk999/nyQSCVlbW9PXX3+t kuBgbadfv36kr69POTk5wjpfX19avXq1StmmEmT167hfaybIGrJy5UoCoNJ7qyUJsrfffpsA0MyZ M+n8+fNUXV2t9lhyuZzEYrHaa7V///4EgFJSUpqM+cqVKySTyVR+dHfgwAECQD179lTZp6FkV2Ma 2sfNza3J5GZrUHdu5HI5AaDCwsJG921Jueaek+ae57a4HppbJ2tbZ8+epeeee45EIhH17t2bDhw4 oOmQSLv1BmtkjDHGGGNM1d27dxEREYHLly8jPDwc4eHhKCsrg0wmQ+/evTFixAgEBgbCzc0NPXr0 aNbE1owxxhhrXYaGhvDw8ICHh4ewrrKyEv/++y/CwsJw+fJl/PHHH/jqq69QW1sLGxsbuLm5wcvL C56enhg4cCDP7dkOKBQKrFq1CmvXroWRkRFWr16N119/HVKpVNOhPVX+85//YNq0adi4cSM+/fRT JCQk4O+//8bu3btbXJeBgUEbRKhKoVDg22+/xf79+5Gamqoyj2FpaekD171hwwZ4eHhg586d8Pb2 BgAMHToUs2bNwsSJEwHcm0NKoVAAQKPzfN24cQMdOnRo9Hg//fQTioqKGnztYmJiEBERAXd39wdp TpOGDRuGy5cv4+rVqxg3btxD19fcc1P3GkqlUshksgbra2k5oHnnpDnnGWib66G5x2Zty8vLCwcP HsTVq1fx+eefw9fXF0OGDMHy5csxdOhQjcQk1shRGWOMMcbYE6m2thZXr17FDz/8gOnTp8PR0RHW 1tbw8/PD77//jq5du+KHH35AXFwcFAoFwsLCsG7dOkyfPh09e/bk5Bh7JG7evAmRSIRff/0VADB7 9mx06dJF2J6amqo0iXzdEhwcrFTPJ598olImLi7uUTYFffv2VRtrQ8uyZctgaGiodptYLIaFhQX8 /Pxw6dIlpeM0tI9IJIJUKkXv3r2xYcMGEFGzY6+pqcGmTZswZMgQyOVy6OjowNbWFs8++yzWr1+v NCF6cHCw0jHLy8tb6yVs0K+//qrURk1p6nplrC3p6urCzc0NH3zwAXbt2oWYmBjk5eXh+PHjePvt t1FTU4MVK1Zg6NChMDMzw4gRI/Dxxx/j4MGDyMvL03T4rJ7Kykps2bIFzs7OWLduHd59913ExcXh nXfe4eSYBkyZMgUdO3bE+vXrUVFRgW+//RYzZ85sNBnxIJr6bC0Wi1FZWamy/v4ECwBMmDABS5cu xcyZM5GQkIDa2loQEdasWQMALfoMoC7OgIAAHD9+HAUFBQgODgYRwd/fHxNGBL4AACAASURBVKtX rwYASCQSGBsbQ1tbG1VVVaB7I6OpLCNGjGj0WFVVVfj5558RHh6udv+5c+cCALZv3/7A7WnKrFmz oK2tjd9++63Rch9++CHEYnGTny+be24kEgnkcjnKy8tRVFTUYH0tKdeSc9Kc89zccm11bPZo9O7d G7///jsuXrwIqVSKZ555BqNHj8Y///zzyGPhBBljjDHGGHsoSUlJ2LJlCyZPngxLS0v06dMHH374 IZKSkvDiiy/iwIEDyM7Oxr///ovNmzfj1VdfhbOzMyfD2GOrQ4cOICIEBQUBABYuXAgigp+fn1K5 ZcuWgYgwbNgwbN26FUQEFxeXRx7vvn37lL4ImDVrFgDgyJEjSuunTJkCACguLkZUVBQAwNfXV9ie n5+PLVu24Pz58/D09MTx48eFYzS0T0VFBS5cuAAjIyO89957WLhwYbPjDggIwLvvvgs/Pz/ExMSg qKgIZ8+eRb9+/TBnzhwMGDBAKOvn5wcigq+v70O/Xs01depUEJHwK2PG2D1yuRze3t749NNPcfjw YeTn5yMxMREbN25E79698ddff8HX1xdmZmZwcHDArFmzsG/fPuTm5mo69KdWSEgIXFxcMG/ePMyY MQO3b9/GihUrWj0Zw5pPW1sbH3zwAbKysvDtt9/i119/xZw5c1r9OPr6+koJMGdnZ2zZskV4bmNj g7S0NKV9MjMzcefOHaV1NTU1CA8Ph7W1NebMmQMLCwvhs3xZWdlDx2lsbCwkgXR0dDB69GjhxzGH Dh0Syvn7+6O6uhrh4eEqdXz99dfo1KkTqqurGz1WSEgIzM3NMWTIELXb33jjDQBAUFBQq7RNHScn JyxZsgSRkZH46aef1JaJj4/H5s2bMXny5EY/X7b03NT1ljp8+LDKtn79+mHevHktKteSc9Lc89wW 10Nz62SP1sCBA3H8+HGEhoaioKAAAwYMwPTp05Gdnf3IYuAEGWOMMcYYa7ba2lpERUVh7dq18PX1 hampKRwcHPDRRx+huroan376KaKjo1FQUICwsDCsWLECEyZMgKmpqaZDZ4w1QS6XY+LEiVi9ejWq qqqEX1A3RldXF3379kVQUBDEYjHWrFnTrF4jly5dQlBQEN544w18+OGH6NChA6RSKRwcHPDll1/i 7bffbo0mMcYeka5du2L69OlYt24dIiMjkZWVheDgYDz//POIiIjA1KlTYWlpib59+2Lu3LkIDg7m HmaPQGJiIsaPHw9fX194eHjgxo0bWLFiBUxMTDQdGgPw1ltvQS6X45NPPoGfnx/s7Oxa/Rj9+/dH QkICUlJScP78eSQlJSkNYzZmzBikp6dj/fr1KC4uRmJiIj744ANYWloq1aOlpYXhw4cjMzMTK1eu RE5ODsrKynDq1Cls2rSpVWKdPXs2rl69ioqKCmRlZeGbb74BEWHkyJFCmeXLl8PBwQGvv/46jhw5 AoVCgby8PGzevBlffPEFVq1aBW3txmcU2r59O15//fUGt/fq1Qvu7u5QKBT4448/WqVt6nzyySdY tGgRZs+ejUWLFiEhIQGVlZVIS0vDjz/+iBEjRqB379748ccfG62npedm+fLlsLe3x7x583Do0CEU FRUhNTUV77zzDjIyMoTEV0vKteScNOc8N7dcWx2bPXqjRo1CREQEdu/ejePHj6N79+7YsmULamtr 2/7grTulGWOMMcYYe9JkZWXR3r176a233iJbW1sCQDKZjEaNGkUrVqygyMhIqqmp0XSYjDXbjRs3 CAAFBQUREdGsWbOoc+fOKuWCgoIIAC1cuLDR+oYNG0Zbt25ti1AfyKxZswgAHTlypMEyjU00n5aW RgAIAOXn5zdrHyIiOzs7AkAnT55sMsbt27cTAFq1apXa7adPnyYzMzOV9b6+vgSAysrKmjxGa/H2 9iaJRPLIjne/5l6vjD3OCgsLKTQ0lBYuXEhubm4kFotJLBaTm5sbLVy4kEJDQ6myslLTYT4xysrK aPHixSSVSqlnz5506tQpTYfEGrBgwQICQFeuXFHZtn//fuHf47rllVdeofPnz6usb+gr3ri4OBo6 dCgZGBhQx44dacOGDUrbCwoK6M033yQbGxvS09MjLy8vunTpErm5uQn11n0Oys7OplmzZlHHjh1J R0eHrKysaMaMGbRo0SKhrJubG61cuVIlto8//rjB9hARRUdH06xZs6h79+6kr69PpqamNHjwYNq6 dSvV1tYqxZybm0vz58+nrl27ko6ODllYWNCYMWMoNDS00dc6JSVF6diDBg1SKXPr1i2VGK2srMjA wEBlvbOzc6PHU7fPypUrVcpFRERQQECA8LrKZDIaPHgwrVu3jioqKho9Rp3mnps6OTk5NHfuXLK3 tycdHR2ysbGhqVOnUkJCglK9zS3X3HPS3PPcFtdDS+pkmqVQKGjevHmkra1NAwcOpIiIiDY9nojo IQaIZYwxxhhjT5yqqiqcO3cOf/31F/766y9ERUVBR0cHXl5eGDt2LMaOHQtXV1eIxTwYAWufbt68 iW7duiEoKAhTp07F7NmzcfToUaU5r4B7c1C99NJLWLhwIVasWNFgfcOHD8e0adPw5ptvtnHkzTN7 9mxs3rwZR44cgY+Pj9oy0dHR6NevH3x9fVXmVktLSxMmty8oKBAmPm9sHwCws7NDeno6zp07Bw8P j0ZjPHLkCJ599lmMHTsWR48ebXbb/Pz88Oeff6KsrOyRzZkzatQohIWFPZJ5z9Rp7vXKWHuSn5+P kydP4q+//sLRo0eRkpICU1NTjBo1CmPHjoWPjw9sbW01HWa7dPXqVQQEBCAxMRGBgYH46KOPoKur q+mwGGOMsRaJj4/H+++/jxMnTuC9997DN998A4lE0urH4W81GGOMMcYYSktLERISgunTp8PS0hLD hw/Hnj17MGDAAOzZswdZWVk4ceIEPvzwQ/Tp04eTY6xdc3R0BBFh6tSpAIBNmza1erKhoqICixcv houLC/T19WFqaooJEybgwIEDqKmpUSqbnZ2NOXPmoEuXLtDV1YWFhQX8/f0RHR3dqjE11+nTpwEA PXv2FJJjTblz5w4yMjJgZGSEnj17Nll+6NChsLa2xl9//YVx48bh9OnTLRpCJTMzE1OmTIGxsTHM zMwwfvx4JCYmKpWprq7Gnj17MHr0aFhbW0NPTw+urq5Yt26d2mPFxcXBz88PcrkcBgYGGDp0KMLC whqMITc3F/Pnz4eDgwN0dXVhYmKCcePG4dSpU0IZPz8/iEQiYfHy8hK2nThxAiKRCCEhIcK6uXPn KpWvrq5+JNcrY4+aiYkJXnjhBWzZsgV37txBYmIili9fDiLCBx98ADs7O/Ts2ROfffYZLl++rOlw 24Xq6mp8/fXXGDhwIGQyGa5cuYLPPvuMk2OMMcbaJWdnZxw7dgzbt2/HTz/9hAEDBrTJ/4/4mw3G GGOMsadUVlYWtm3bhvHjx8PMzAwTJ05ESkoKlixZghs3biAxMRGbN2/GpEmTmv0lOWPsnvfeew/f ffcdvv/+e+Tm5uL69etwcXGBr68vzp49K5TLyMjAwIEDsXfvXmzcuBF5eXk4ffo08vLy4OHhgfPn zz+ymAsLC7F//37Mnz8fOjo6WLt2bZP7VFVVITo6Gi+//DJ0dHSwfv16GBkZNbmfoaEh9u3bh44d O+Lo0aMYMWIEbGxsMG3aNAQFBaG0tLTR/efOnYu5c+ciLS0N+/btw9mzZ/HSSy8plTl69CimTp2K kSNH4vr160hJScFbb72F+fPnY+HChUplb968CQ8PD0RGRuK3337D3bt3sXHjRixdulQl8QbcS9AN HDgQv/zyC9atW4ecnBxcvHgR+vr68Pb2xrZt2wAAwcHB2LBhAwDg559/Vkq4/e9//xPW11m7di32 798Pb29vEFGT86gw9qTo2rUr3nrrLezduxdZWVk4fPgwvLy8sHnzZgwYMADdunXDggULEB4e/mjm I2ln4uPjMWTIEHz++edYuXIlzp49CwcHB02HxRhjjD206dOnIyoqCkZGRhg8eDBWrlzZup8F2nQA R8YYY4wx9ljJy8ujLVu20LBhw0gsFpOenh75+vrSTz/9RNnZ2ZoOj7HHysPMQWZvb09DhgxRKevk 5KQ0F8yrr75KAOjnn39WKpeRkUESiURpvojmaskcZPUXkUhEZmZm9Pzzz6sd61/dPnXLxIkT6ebN my2Otby8nHbu3Em+vr4kk8mE+szMzIQ5t+qrm4MsJCREaf3LL79MAJTex0JCQmj48OEqdUybNo10 dHRIoVAI6yZNmkQA6LffflMqm5aWRhKJRGUOshkzZijNC1a/Pba2tqSnp0eZmZlEdG9uDF1dXfLx 8RHKlZaWkomJCTk6OpKenh4VFhYK2yZOnEg7d+5s8DVj7GlSU1ND586dow8//JC6desmzAf0/vvv 0/nz5zUd3mNh//79JJPJyN3dna5fv67pcBhjjLE2UV1dTcuXLyddXV2aMGGC0mf5h8E9yBhjjDHG nnDl5eX4/fffMXHiRNjY2OCDDz6AlZUV9u3bh5ycHAQHB+O1116Dubm5pkNl7LGipaUFACpDIt6v pqZGKFvHx8cH586dw1tvvYULFy4IdcTHx2P48OFCueDgYIjFYowfP15pf2tra/Ts2ROXL19Gampq K7RGPV9fXxARiAi1tbXIycnBn3/+iYEDBzZrn9TUVEyZMgX79+/Hli1bWnx8iUSC6dOnIzg4GHl5 eThx4gSmTp2K3NxcTJs2DVFRUWr3uz8+Ozs7AEB6erqwbvz48UrDHdbp06cPqqqqEBMTI6yrmwdt 7NixSmVtbW3h5OSkUsf+/fsBAM8995xKe7y9vVFWVoa//voLAGBqaopnn30WoaGhyMzMBAD8+eef GDRoEN59912UlZXhjz/+AAChB6G/v7/adjP2tBGLxfDw8MDXX3+NhIQExMTE4N1330VoaCg8PDzQ rVs3LFmyBAkJCZoO9ZEjInz99dd44YUX8NJLL+Hs2bNwcXHRdFiMMcZYm9DS0sKiRYtw6tQpREZG YsCAAUqf5x8UJ8gYY4wxxp5QkZGReOutt2BjY4MpU6agpKQEmzdvRmZmJvbs2QN/f3/o6+trOkzG HluGhoYA7g092JiCggKVYQU3bNiAXbt2ISkpCd7e3jAyMoKPj4+QWAHuzVOmUChQW1sLuVyuNPeU SCTCP//8AwC4ceNGK7es9djZ2WHHjh1wcHDAypUrERkZ+cB1aWtrY+TIkQgKCsLChQtRU1OD3377 TW3Z+4d9rZsXsf5wKwqFAosXL4arqytMTEyE13XBggUAIAzjWFFRgaKiIkilUuGc12dpaan0vO68 SaVSyGQylfJWVlYAICTDgHtDw9TU1OCXX34BAOzevRvTp0/HSy+9BC0tLWGYxaCgIIwfP15tHIwx oEePHvj0009x/fp1REZGYsKECdi6dSucnZ3h7u6OTZs2oaioSNNhtrnCwkL4+vpi8eLF2LRpEzZv 3sxzjTHGGHsqDBkyBJGRkTAzM8OQIUOU5vN9EJwgY4wxxhh7gpSUlGDbtm0YMGAABg4ciAsXLmDx 4sVISUnBsWPH8OqrrzZrfiDGGISeQ439MrGiogI3b95Et27dlNaLRCIEBATg+PHjKCgoQHBwMIgI /v7+WL16NYB7vY2MjY2hra2NqqoqoVfW/cuIESParpGtQCqV4quvvgIRYdGiRc3aJzw8XEgkqVPX 5vz8/AeOa8KECVi6dClmzpyJhIQE1NbWgoiwZs0aAPd6XwD3zoNMJkN5eTmKi4tV6snLy1N6LpFI IJfLUV5ervaL+Lt37wK41wuwznPPPQdTU1Ps3r0b2dnZuHDhAvz8/GBlZYUxY8bg5MmTyMjIwM6d OzF9+vQHbjNjTxM3NzesXr1a+IzTvXt3zJ8/H3Z2dpg9ezaio6M1HWKbyM3Nhbe3NyIjI3Hq1CnM nDlT0yE9dgwNDVV+dFK3SKVS9O7dGxs2bBD+HWCPRnFxscr5aM5cqwsWLFDaZ9myZa1aF6D+mlm1 apXK/pGRkZgxYwa6dOkCqVQKY2NjDBw4EF988QUKCgpa/qI8hn799Vel+4VpxqpVq4Tz0KFDB02H 89ixtbXF6dOnMWnSJEycOBE7d+584Lo4QcYYY4wx9gSIj4/He++9Bzs7O7z//vvo3r07wsLCcPXq VcybNw82NjaaDpGxdsfBwQEuLi64cOFCg7249u7dCwsLC/Tq1UtpvbGxMeLi4gAAOjo6GD16NIKD gyESiXDo0CGhnL+/P6qrqxEeHq5S99dff41OnTqhurq6FVvVNiZNmoR+/frhxIkTCA0NbbI8ESEr KwsXLlxQu72uJ1q/fv0eKJ6amhqEh4fD2toac+bMgYWFBUQiEQCgrKxMpfy4ceMA/P+hFuvk5OQg Pj5epfzEiRMBQOlcAvcSpidOnICenp7ScI26urqYMmUKoqOj8fHHH8PX1xd6enoAgICAANTU1GDJ kiXIyMjAyJEjH6jNjD2ttLS0MHr0aOzcuRNpaWn44osvcObMGfTr1w8eHh7YvXs3qqqqNB1mq7h7 9y5GjhyJ7Oxs/P333xgyZIimQ3osFRcXC0P01h8WuKKiAhcuXICRkRHee+89LFy4UMORPlrFxcXo 1q2byrDOj4qhoSGISGn45KVLlza6T25uLjZt2gQAeOWVV0BE+OSTT1q1LkD9NRMYGKi0/3//+18M HjwYJiYmOHjwIAoKCnDr1i0sWbIE+/fvh5OTk9rPc+3N1KlTQUTw9vZW2abpa+hpEhgYCCJCnz59 NB3KY0sikWDbtm348ssv8dprr2HdunUPVA8nyBhjjDHG2rF//vkHkyZNQo8ePXDs2DF8+umnSE1N xe7du+Hp6anp8Bhr99asWQOxWIxx48bhjz/+QF5eHmpqapCeno6NGzfivffew+rVq4Uh/uqbPXs2 rl69ioqKCmRlZeGbb74BESklQJYvXw4HBwe8/vrrOHLkCBQKBfLy8rB582Z88cUXWLVqFbS1tR9l kx9I/V9hL1q0qNm/yp88eTJ++eUXpKeno6KiAsnJyVi1ahW++OILuLm5PXBvKi0tLQwfPhyZmZlY uXIlcnJyUFZWhlOnTglfjtX31VdfwdTUFHPnzkVoaCiKi4sRGxuLadOmqR3ucPny5bC3t8fcuXNx 8OBBFBUVISEhAS+//DIyMjKwbt06lR5yAQEBAICtW7cqtcvPzw8ymQxbt27FK6+8ovZaYow1j4mJ CebOnYvY2FicPHkSnTt3xhtvvAFHR0d8//33wtCq7VFKSgqeeeYZlJeX4+zZs3B0dNR0SO2Orq4u +vbti6CgIIjFYqxZs0all/CTrG6+0frDEWuKnp4eOnfujCNHjjQ6PPOaNWvQsWPHR1ZXQ5YtW4YV K1Zgw4YNWLNmDXr16gWpVAoTExOMHz8e4eHh6NSpE8aNGyf8QOpJ9DhdQ3UMDQ3h5eWl6TCYBi1c uBBffvkl5s2bp7bnZ5OIMcYYY4y1O2fPnqXx48eTSCSiPn360M6dO6m6ulrTYTH2RLp8+TJNmzaN unTpQhKJhHR1dalDhw40adIkCg8PV7tPdHQ0zZo1i7p37076+vpkampKgwcPpq1bt1Jtba1S2dzc XJo/fz517dqVdHR0yMLCgsaMGUOhoaEtinP79u0EQGUpKipSKmdgYKBSxtnZudG61e0zZcoUlXJe Xl7Cdk9Pzwbrq6mpobCwMAoMDKRBgwaRra0taWtrk0wmowEDBtBXX31FJSUlQvnz58+rHP/jjz8m IlJZ/9xzzxERUXZ2Ns2aNYs6duxIOjo6ZGVlRTNmzKBFixYJZd3c3IRjxMfHk5+fHxkZGZGenh4N HDiQDh48SN7e3kL5N954Qyifk5NDc+fOJXt7e9LR0SG5XE5jx46lEydONNjubt26UadOnVSugRkz ZhAAiomJafQ8MMZa7vbt2zRnzhzS19cnc3NzWrJkCeXl5Wk6rBbJz8+nHj16UK9evSgzM1PT4bQL UVFRBIB8fX3VbrezsyMAdPLkyUccGYuKiiIDAwP64YcfGj1H+fn5ZGpqSjt27CAA9Morr7R5Xerq uHHjBmlra1P//v0bbdfff/9NAGj06NGNlmsvvL29SSKRaDqMJhkYGDT6mbO969OnD9nZ2Wk6jHZh 3bp1JBKJaNu2bS3aT0TEA+4yxhhjjLUXcXFxCAwMxKFDh+Dp6YmFCxdi/PjxwtBhjDHGGGNMVU5O DtavX4/vvvsOwL1fnM+dOxcSiUTDkTWuuroazz77LK5du4aLFy8+cA+Yp010dDT69esHX19fBAcH q2y3s7NDeno6zp07Bw8PDw1E+PSKjo6Gl5cXcnNz4eDggPT0dERHR6N3795K5b744gvcuHEDs2bN wtChQ/HKK6/gf//7X5vWpe6aCQwMxLfffovly5c3Oddq3XWVmJiIrl27PsjL89gYNWoUwsLCUF5e rulQGmVoaIi+ffsiLCxM06G0ib59+yInJwepqamaDqVdWLx4MVasWIEjR46oHSZUHR67gTHGGGOs HcjKysLs2bPRq1cvZGZm4vTp0wgLC8OECRM4OcYYY4wx1gRzc3N89tlnuHXrFmbNmoXPPvsMvXv3 xp9//qnp0Br1wQcfICwsDMHBwZwcayV37txBRkYGjIyM0LNnT6Vt2dnZmDNnDrp06QJdXV1YWFjA 398f0dHRKvXk5uZi/vz5cHBwgEQiQYcOHTBq1Cjs2LFDab7L+uV0dXVhYmKCcePG4dSpUyp1xsXF wc/PD3K5HPr6+nB3d8fBgwcxatQoiEQiiEQivPnmm8K8pnVLcnIypkyZAmNjY5iZmWH8+PFITEwU 6r2/fP2kR0VFBRYvXgwXFxfo6+vD1NQUEyZMwIEDB1BTU/PAr09TJBIJFixYACLCl19+qbStuLgY 33//PT766KNHXtf9zpw5AwDNmguqrszZs2dbdIyWns86Lbm2GlL/mjMwMMDQoUPVJpsauobuXx8f H4/JkyfDzMxMWJeTkwOgde+vVatWQSQSoaSkBOHh4cKxmjM0eXV1Nfbs2YPRo0fD2toaenp6cHV1 xbp169QOH/kg93pj5VrzPmLKPv/8c0yePBn+/v6IiYlp3k5t0JuNMcYYY4y1ktraWvruu+/IyMiI 7OzsaMeOHVRTU6PpsBhjjDHG2rVbt27RlClTSCQS0ciRIykpKUnTIanYtWsXicViCg4O1nQo7Y66 4fIqKyspKiqKPD09SVdXl3bt2qW0T3p6OnXu3JmsrKzo0KFDVFRURNeuXaNhw4aRVCqlc+fOCWUz MjLI3t6erK2tKSQkhAoLCykzM5OWLl1KAGjNmjVK5aysrCgkJIQUCgXFx8eTv78/iUQi2rp1q1Dn jRs3yNjYmOzs7OjYsWPC8UeNGkUWFhZqh7vz9fUV2nnu3DkqLi6m0NBQYajghsqXlZUJ6958802S y+V07NgxKi0tpczMTAoMDCQAdOrUqQd6fZo6NwYGBkREVFpaSlZWViQWiyk2NlYos2LFCpo8eTIR 3RtaHk0Msdhadd1/zRAR2djYEAC6ePFik22bNm0aAaCvvvqqybLqtOR8tuTaaoi6a+7q1as0ZswY YWjxhmKsfw3VXz9s2DA6deoUlZSU0IULF0hLS4uys7Pb5P4ierAhFkNCQoTzlJeXR9nZ2fTdd9+R WCymwMBAta9zc+/1psq19D7iIRZbrqysjDw8PKhHjx5UXl7eZHlOkDHGGGOMPaZSU1NpzJgxpK2t TZ988gkVFxdrOiTGGGOMsSdKeHg4ubq6kkwmo59++knT4QjS09PJ1NSUPvjgA02H0i7VJTvULRMn TqSbN2+q7PPqq68SAPr555+V1mdkZJBEIlGat7Ju7sg9e/ao1OPj4yN8GV5XLigoSKlMeXk52dra kp6enjCv3KRJkwgA/fbbb0pls7KySF9fv9FkRUhIiNL6F198kQBQdna22vL1kxv29vY0ZMgQlbqd nJyUEmQteX0aUz+pRUT09ddfEwCaNm0aERGVlJSQlZUVXblyhYianyBrjboaS5BFREQ02ba6BNny 5cubLKtOS85nS66thjR0zaWlpZFEInmgBNnhw4fVHqst7i+iB0+QDR8+XGX9tGnTSEdHhxQKRYtj aW65lt5HnCB7MMnJySSTyeijjz5qsiwnyBhjjDHGHkP79u0jU1NTcnJyatavFRljjDHG2IMpLy+n wMBAEovF5O/vTzk5OZoOiSZOnEj29vZUVFSk6VDaJXXJjtTUVJoyZQoBoA8//FBlH7lcTmKxWOnL 8Tr9+/cnAJSSkiKUBUCFhYWNxtFYuYCAAAJAO3fuJCIimUxGANSe8/79+zearLg/ETJv3jwCICSG 7i9fP7nx9ttvEwCaOXMmnT9/nqqrqxtsS3Nfn8bcn9QqKioiMzMz0tLSohs3btDq1auVzltLEmQP W5e6BJmbmxsBoCNHjjTZtnHjximd05ZqyflsybXVkMauOVdX1wdKkDX0/tkW9xfRgyXIGrJy5UoC oNSLqzXu9fvLteQ+4gTZg9uwYQNpa2vTpUuXGi3Hc5AxxhhjjD1mli5dismTJ2PKlCmIioqCu7u7 pkNijDHGGHtiSSQSrFy5EidOnEBkZCQ8PDxw69YtjcUTEhKC4OBg/PjjjzA0NNRYHE8aOzs77Nix Aw4ODli5ciUiIyOFbRUVFVAoFKitrYVcLleaU0kkEuGff/4BANy4cUMoK5VKIZPJGjxeU+WsrKwA AJmZmaioqEBRURGkUqnac25iYtJo2+RyudJzXV1dAFA7n9L9NmzYgF27diEpKQne3t4wMjKCj48P 9u/fr9KW5rw+LWVoaIi5c+eipqYGS5YswapVq/DJJ5+0uJ7WrqvOsGHDAKBZ80NduXIFADB8+PCH OmZT57Ml11ZDmrrmLC0tHyh2AwMDtcdq7fvrYSgUCixevBiurq4wYSAZuwAAIABJREFUMTER4liw YAEAoLS0VCnuh73X7y/XFvcRU/X222/Dy8sLb7/9dqPlOEHGGGOMMfaYqKmpwTvvvIPPP/8cGzdu xMaNG6Gvr6/psNj/c+PGDYhEIgwePFjToaiom6RaJBKhQ4cOTZYvLi5W+Q/Z+fPnm9xvwYIFSvss W7ZMpUxkZCRmzJiBLl26QCqVwtjYGAMHDsQXX3yBgoICoVx0dLRKDI6Ojir1FRQUqJRrjkuXLmHG jBmwt7eHnp4eTE1N0atXL7zwwgv44YcflCY6NzQ0VDlG3SKVStG7d29s2LABRKRynOrqavz4449w d3eHmZkZTExM4ObmhvXr16OysrJZsbKWaeh6b+l90BJ9+/Zt8BpRtyxbtqzB60osFsPCwgJ+fn64 dOmS0nEe5lq8X2ve5639nqGunatWrVLZv7nvJ+qEhYVBJBLh4MGDrf5+V1NTg02bNmHIkCGQy+XQ 0dGBra0tnn32Waxfvx7JyclKdbXmeWVta/jw4YiIiICRkRGGDBkifFn5qC1fvhx+fn4YMWKERo7/ JJNKpfjqq69ARFi0aJGwXiKRwNjYGNra2qiqqgLdG3VLZRkxYgQkEgnkcjnKy8tRVFTU4LGaKnf3 7l0AgLW1NSQSCWQyGcrLy1FcXKxSNisrqxVar55IJEJAQACOHz+OgoICBAcHg4jg7++P1atXC21p 7uvzIN5//33I5XL88ssv6NOnDwYMGPDA7WnNugBg1qxZ0NbWxr59+xotFxYWhvT0dEyYMAGdOnV6 qGM2pSXXVmN1NHbN5f0fe3ca1tS17gH8n5gwCBIEAYEida4iIuKARasi1tIiaK2Cioq2SrVVgYI4 9WiPw1Xg1HrVKtaCPSrowSqUOoulCmpBi9giWHCoigIyKchQSN77wZscQgaSkBjbrt/z5AM7613r XXuvHZK99lBZqdV8tb1/ian626CliRMnYt26dZg/fz5+++03iEQiEBG2bNkCAJL/x9ra11uW0+V+ xEjjcDjYsmULrl69itOnTysuqK1L1hiGYRiGYRjNCYVCmjZtGhkbG7MHsb+kVqxYIXl2RV5enr7T kUvdW3C0fD6Ht7e30rLl5eVkamqq8LY0RETLly+nDh06UEhICP3yyy9UX19PlZWVlJqaSoMGDSIr KyvKyMiQinn//fcJAK1atUpp+76+vrR58+Y2+yQUCik8PJx4PB5FRERQfn4+NTQ0UElJCZ0+fZq8 vLwkfW5qapJZFy1vq9PY2Eg5OTnk4eFBACgiIkKmPfGzJlasWEGlpaVUXl4uef6Fj49Pm/m+rGpq aqhXr170zjvv6DsVhRSNd13cisbFxYWSkpKklgUHB8u95ZK/vz+tW7eOiOSPq+rqajpy5AhZW1sT n8+nM2fOSMVrOhYV0eZ+rou6Wt/KSkyTz5OWIiIiyMLCQrKfazP36dOnE5fLpc2bN9P9+/epvr6e ioqKaOXKlcThcMjS0lKl/rZnuzK69fTpUxo/fjyZmZnR5cuXX2jbP/zwg8wtvhj1KfuMEYlE5Orq SgDo9OnTkuXz5s0jAJSeni4Ts2nTJnJwcJB8poifN3Tw4EGZsoMGDaKQkBCpcqo8J2ratGkEQOb/ jfjZROrc7i4yMpIAUE5OTpvlBQIB5efnS5Wrq6sjDodDnp6eGq0fZVrfFlHss88+I4FAQJmZmVLL 1bnFYnvrUjRm1q1bRwBo165dcvv07NkzcnNzI0tLS7p165bcMqpQZ3tq4xlkisbc48eP23zunaJb LLZeLqaL/YuIyNramoYOHSr5u0+fPhQbG6uwz83NzcTlcqlr164y723cuJEASH03U3dfb6ucuvsR u8Vi+40fP17qs6w1NkHGMAzDMAzzEggPDydDQ0OpB2EzLw+hUEj29vaSgynh4eH6TkkuTSbIjI2N ydHRkQAovT/7qlWrqF+/fgoPKqh64KBTp05SB2EyMjIIADk4OJBQKJQbW1paSkZGRvTw4cM2+7Ry 5UoCQLt375b7fnNzs+T5EG1NkIndu3ePuFwu8Xg8qqiokCy/desWASBXV1eZmPHjx6v8QHd9UfbM hqdPn1KPHj3anEjQpz/rBJnY/v37CQA5OTlJLddkLCqjzf1c23W190Bk68+Tlvr06UOzZs3Seu5Z WVmSZ/XIs2jRIpUnyMQ02a6M7jU2NtLbb79N1tbWdPfu3RfWro+PD40ePfqFtfdX1dYk/LFjxwgA DR48mEQiERE9/77Rs2dP6tGjBx0/fpyqq6upoqKCdu3aRR07dqRDhw5J4h89ekTdu3cnW1tb+v77 7+np06d0//59WrhwIdnY2NDvv/8uVc7GxoZSU1Pp6dOndPPmTXr33XeJw+FIfV8pKioiCwsLsre3 p9OnT1NNTQ398ssv9NZbb5Gjo6NOJ8hGjx5Nubm51NDQQKWlpbR27VoCQOvXr5eUU2f9tLVt5E1q KaLJBJmmdSkbMytWrKAOHTpQaGgo/frrr9TQ0EBVVVWUmppKrq6uZG9vT1euXJGKmTlzJgGg27dv q5SfOttTnbGliLwxl5eXRxMmTCBra2utTpDpYv8iInrrrbdIIBDQvXv36OLFi8Tj8ejGjRtK++3p 6UkAKCoqih4/fkx1dXV07tw56tatm8wEmbr7elvl1N2P2ARZ+6WlpREAmf1TjE2QMQzDMAzD6Nmx Y8eIw+HQvn379J0Ko8CJEyfI0dGRsrOzCQDZ2NiodIbsi6bJBJmJiQnt3LlT6QGBqqoqsrCwoL17 98o9qFBYWEg8Ho8GDx6stL3z588TABo/frzU8t69exMAOnXqlNy46Ohola7Gys/PJy6XS25ubkrL Xbx4Ua0JMiIie3t7AkDnzp2TLEtPTycANGPGDJnyixcvJgB0+PDhNvPWF20+1FwfXuQEmTyKJsha UjauiouLJVc0VVVVqRRDJH8sKqOt/VwXdcmro72fJ0TPPwta73/ayj0+Pp4AUExMjNz49PR0tSfI iNTfrsyLUVNTQ87OzuTh4fFC/u/X1NSQgYEB+07YTiYmJpLPV/HL399fptzIkSMl74v/H1ZUVFBY WBj16NGD+Hw+WVlZ0ZtvvilztS/R86tNQ0JCqHv37sTn88nW1pYCAgLot99+U1pOIBDQhAkTKC0t TabOmzdv0qRJk8jMzIw6duxIr7/+Ov344480ZswY6tixo6TcpUuXZPoovhq/9fJ33nmHjh49KrNc /Pl27do1Cg4Opn79+lHHjh3JwsKC3N3d6auvvpJMHoqps35U2TYTJkxQWr51zgBo27ZtOq8LAEVH R8vUkZ2dTXPmzCFHR0cyMDCgTp060ZAhQ2j9+vVUXV0tU97T05NMTU2publZaW7qbk8xdcaWIi3H nLGxMQ0dOpS+//57GjdunKTN999/X+EYkpc7IH/KQRf7V0FBAY0aNYpMTEzIwcGBduzY0WafHz9+ TMHBweTg4EB8Pp9sbGwoKCiIli9fLsm/5e8JTfd1ReVUWQ/R0dEKxwSjvp49eypcf2yCjGEYhmEY Ro/q6uqoW7duFBgYqO9UGCWmTp1Ka9asISKigQMHEgBKSUnRb1JyaDpB1tDQQPb29sThcCg3N1em 3GeffUaBgYEKz7r95JNPCAD9z//8T5tt2tnZEQCp289s2LCBAFBAQIDcmP79+9O3337bZt2hoaEE gDZt2tRm2dbaOngtzrvlLa9KSkqIz+fLPZA/fvx44nA4dPPmTbVzeVHYBFn7tHeC7MGDB5IDHi0P qmkyFpXR1n6ui7rk9bO9nydEz29RZGhoSDU1NVrP/fjx4yodiG1N29uVeXF++eUXMjAwoC+//FLn bX333XfE5XKptLRU520xfy59+/albt266TsNRg1VVVVkbGxMH3zwgb5TYZi/vUWLFtGQIUPkvscF wzAMwzAMozexsbGorKxEdHS0vlNhFKisrERqairmzJkDAJg7dy4AIC4uTm75iooKhIWFoWfPnjA0 NMQrr7wCLy8v7N27F/X19WqXe/z4MZYsWYJXX30VBgYGsLKywrvvvotr165prY+GhoaIiIgAEWHD hg1S79XW1mLbtm1YuXKlwvgff/wRAODi4tJmW+IyFy5ckCybPXs2uFwukpOTUV1dLVX+p59+QllZ GSZOnNhm3efPnwcADBw4sM2y6rh37x4ePXoEMzMzODk5SZbb2NggJiYGubm5WLlyJR4/fozKykpE RUXh7Nmz+Mc//oE+ffq0q+2W48TAwACdO3eGt7c3fvjhB0mZmJgYcDgccDgcvPLKK8jOzsa4cePQ qVMndOzYEWPHjkVmZqZM+WfPniEzM1MSy+PxAADJycmSZRwOBw0NDWrn1LqOu3fvwt/fH+bm5rC0 tISPjw9u3bolVW9zczMOHTqE8ePHo2vXrjA2NoazszO2bt0KkUik0fqrrq6WyoPD4WD9+vWS9lou f++99zRqQ1Pp6ekAACcnJwgEApViFI1FVbR3P9dVXa219/MEAL777jt4enrC1NRU67mPGjUKXbt2 xalTp+Dt7Y309HSNx6dYe7Yro3sDBgzARx99hH/+85/4448/dNrWqVOn4OrqCmtra522w7ycSkpK YGFhgaamJqnld+/exa1bt+Dp6amnzBh1ERGWLFkCMzMzrFu3Tt/pMMzf3oQJE/Dzzz+jrKxM5j02 QcYwDMMwDKNHe/bsQWBgILp27arvVBgFEhISMGLECHTv3h0AEBgYCD6fj2PHjsl8wS4pKcHQoUOR mJiIrVu3ory8HFevXsWYMWMwd+5cxMbGqlXu0aNHGDp0KP7zn//gyy+/RGVlJdLT01FZWYkRI0bg 0qVLWuvnggULYGNjg8OHDyM/P1+yfMeOHfD09ES/fv0UxhYXFwMALC0t22xHXObhw4eSZeLJwYaG BiQmJkqVj4+Pl6zztojrVCUPVTQ1NeHatWuYMWMG+Hw+tm/fDjMzM6kyS5YsQWJiIvbt2wdra2tY WloiOjoae/bswdq1a9vVvnicJCQkSMbJTz/9hI4dO2LcuHHYs2cPACA8PBxEBBcXF1RXV2Pp0qVY v349SkpKcP78eVRWVsLT01My8SAub2JiAg8PD9DzO4ugubkZADBp0iQQEfz8/DTOqXUdISEhCAkJ QXFxMQ4dOoRz585h+vTpUnWfPHkSAQEB8PT0RH5+Pu7fv48FCxYgLCwMkZGRGq1Dc3NzEBEmTJgA LpeLoqIirF69GgDA4/FARBgxYgQOHDiAw4cPa9SGup4+fYqjR48iLCwMfD4fX3zxRZsxqoxFVbRn P9dlXS219/OkrKwMly9fljt+tZG7qakpkpKS4ODggJMnT2Ls2LGwtbVFYGAgEhMTUVdX12beYtra rozuhYWF4fHjx0hNTdVpO1lZWRg1apRO22BeblVVVQgODsb9+/dRV1eHrKws+Pv7w8zMDJ9++qm+ 02NUVFpaitu3byMtLY39zmOYl8Abb7wBkUiEq1evyr6p+wvYGIZhGIZhGHnEz59R9Z79jH4MHjyY /v3vf0stmzx5stxn0AQFBREAuQ8pf+utt2jLli1qlZszZw4BoAMHDkiVefToERkaGso8a0vTWyyK bd68mQBIbvn57NkzsrGxkdyGTNEtx2xtbQkAZWVltdlmYGCg3NunJSYmEgAaOnSoZFldXR0JBAK6 fv26Sv1RJ4/WxLc/k/eaPHkyFRUVycSIRCKaP38+8fl8+vzzz6mkpIQeP35MsbGxZGxsTP7+/u16 Zo14nCQmJkotb2hoIDs7OzI2NqaSkhLJchcXFwKkH+BORHT9+nUCQC4uLlLL27rForyHraubk7iO 1NRUqfLvvfceAaDHjx9LlqWmptKYMWNk8ggMDCQ+n09PnjyRWq7OLRZPnTpFAGjRokVSyzMyMsje 3p7++OMPRatBIXVusdjyxeFwyNLSknx9feWOVU3GojLa2s91URfk3HKwvZ8ne/bsIQ6HQ8XFxTrL nej5mP/mm2/Iz8+POnXqJNlGlpaWMvtHy/5qa7syL56HhwcFBwfrtA1LS0uVnp/D/HWdPXuWJk+e TK+++ioZGBiQjY0NzZw5k31GMAzDtFOXLl0kzx1siV1BxjAMwzAMoyfis9ZdXV31nAmjyPXr11FY WIgpU6ZILRffZjE+Pl5q+dGjRwEA3t7eMnWdOHECISEhapVLTk4Gl8uFj4+PVJmuXbvCyckJV69e xYMHDzTpmlyLFi2CpaUlEhMTUVRUhNjYWLi7u7d5y0I7OzsAz2+91xZxGXGM2KRJk2Bubo7s7Gzk 5eUBAI4cOYJevXrB2dlZpfzFdZaXl6tUXh4/Pz/JFVUPHjyAv78/jh49it27d8uU3bdvH7766it8 +OGHCA0NhY2NDbp06YIFCxZg+fLlOHToELZv365xLuJx8s4770gtNzQ0xLhx41BfX49Tp05JvWdi YoJBgwZJLXN2doadnR1yc3Px6NEjjfPRNCcAGDp0qNTfDg4OAKSv/PHx8ZG6TaOYi4sLmpqaJONC E2+++SacnZ2xd+9eqXEaHR2NxYsXq3SFYnu0HFcikQjl5eVISUmRWS+KYtoai+rQdD/XdV1i7f08 SUlJwZAhQ2Q+Y7Sdu6GhIWbPno3k5GRUVlYiLS0NAQEBqKioQGBgIHJycuTG6Wq7Mrrn6uqKGzdu 6Kx+IkJVVRW6dOmiszaYl9+4ceNw5MgR3LlzB42NjSgpKcH+/fvRs2dPfafGMAzzp9alSxdUVlbK LGcTZAzDMAzDMHry9OlTAGC3U3qJxcXFoaamBiYmJlLPKvL19QUA5OXlISsrCwDQ2NiIJ0+ewMjI CJ06dVJYp7rlRCIRBAKBzHOUfv75ZwBAYWGh1vpramqKkJAQCIVCrFmzBjExMZLb0SkzevRoAFDp uWi5ubkAgDFjxkgtNzIyQkBAAID/Pt8tLi4O8+bNUzl/cR7Xr19XOUYZe3t77N27Fz179kR0dDSu XLki9f7JkycBAF5eXjKx48aNA/B8wlMTbY0TGxsbAM9vediSubm53PrEz7ORd999XecEQOYZWwYG BgAg9eymJ0+e4B//+AecnZ3RuXNnyViPiIgAALVuXSdPSEgI6urq8OWXXwIAfvvtN5w7dw4LFixo V70vQltjUR2a7ue6rkusPZ8ndXV1OHv2rNLbK4ppM3cejwdPT08kJiYiMjISQqFQpVt2anO7Mron EAjw5MkTndX/xx9/QCQSwdDQUGdtMAzDMMzfVceOHaWe9S3GJsgYhmEYhmH0RHwgW95ZTIz+NTU1 4cCBA8jMzJSc7d/yJb7KS3wVmaGhIQQCARoaGlBTU6OwXnXKmZubg8fjoampSW4ORISxY8dqtd+L Fy+GQCBAQkICXFxcMGTIkDZjgoODwePxkJSUpLRcRkYGHj58iIkTJ6Jbt24y74uvzNu/fz+Kiopw 6dIlmedUqZJHWwemly1bBi6Xi4KCgjbrNDIywsaNG0FEWL58udR7z549azO+tra2zTLytDVOSktL AUDmuRYVFRUgIpny4okx8UQZAHA4nBeSk6omTpyIdevWYf78+fjtt98gEolARNiyZQsAyO2XOmbO nAkbGxts374djY2N+Ne//oU5c+agc+fO7ar3RVE2FtWlyX7+IuoC2vd5cubMGdTX16s0QaZp7pmZ mZLJYHnEn8lVVVUq5aDN7croVkVFhU4/LwwMDNChQwc0NDTorA1G2rVr12ROQOrVq5dMuerqaply rV+qPBc2IiJCKmb9+vUyZbKzsxEUFITu3bvD2NgYFhYWGDBgAKZMmYKdO3fi1q1bUuWFQiF27dqF 119/HQKBAHw+H3Z2dnj77bexfft23L17V6N1U1hYCA6HA3d3d4VlTE1N5a4LLpcLKysrTJo0CdnZ 2W3GxMTEtHs96KJ/2shHnThF61Peq/UJFZqMA22PndraWp3tF4DmY5LL5aJz585wcXHBokWL5D+D Sgex4peRkREGDhyIHTt2tPu7LNM+z549Q8eOHWWWswkyhmEYhmEYPXF2dgaHw5H54ci8HFJTU9Gl Sxe8/vrrct9///33AQCJiYmSM9EmT54MADh+/LhMeVdXV4SGhqpV7t1330VzczMyMzNlym3evBnd unVDc3Ozul1TSiAQICwsDAKBQOWrKfr06YM1a9bg559/RmxsrNwydXV1CAkJgaWlJb744gu5ZYYN G4b+/fujrKwMM2fOhJ+fn1oHI8V5XLlyRXIVWms3b95EbGwspk2bhtdee02leqdOnQpXV1ekpaXh zJkzkuXDhw8HAKSlpcnEnDt3DgBUPvAij3icHDt2TGp5Y2Mj0tLSYGxsjAkTJki919DQIPOZ8ssv v+Dhw4dwcXGBra2tZHnHjh3xxx9/SP7u27dvm7d50yQnVQiFQmRmZqJr165YsmQJrKysJBN48s70 1IShoSEWLVqEsrIy/Otf/8KBAwewdOlSrdT9oigai+rSZD9/EXUB7fs8SUlJQY8ePTBgwACd5U5E KCsrw+XLl+W+Lz5oqc7tk7W1XRndys7OhouLi87q53A4sLS0lJxswOjeoEGDQESS73SrVq1CUVGR TDlzc3MQEXx9fbF582bJSUotb6W6bt06pW1VVFRg165dAJ6fsEFEUp87IpEIEREReP3112FtbY0T J06guroa+fn52LJlC54+fYpFixahV69eUt/9Zs2ahY8++giTJk1CXl4eampqcOHCBbi6umLJkiUa n7QgPgHsp59+Unhr0draWsk6aHn72KqqKuzevRuXLl2Ch4cHzp49qzQmPDy83etBF/1rTz6axCla n61fra/KBzQbB9oeO6amplrfL1rSdEw2NTWhoKAA//znP1FQUIAhQ4Zg7ty5Mncm0HYsEaGxsRGX L1+GmZkZPv74Y0RGRipdH4xulZaWwsrKSvYNLTzfjGEYhmEYhtHQsGHDKDAwUN9pMHL4+PhQVFSU 0jLDhg0jALR//34iInr06BF1796dbG1t6fvvv6enT5/S/fv3aeHChWRjY0O///67WuVKS0upZ8+e 1KNHDzp+/DhVV1dTRUUF7dq1izp27EiHDh2SysfFxYXs7e1V7mNOTg6ZmJioXP7ChQsEgGbOnCn3 /RUrVlCHDh0oNDSUfv31V2poaKCqqipKTU0lV1dXsre3pytXrihtIyoqigAQADp16pTKubW0fPly 4vP5FBkZSTdv3qTGxkZ68OAB7dmzh2xtbWnkyJFUW1srFZOTk0MAyM/PT26dx44dIwA0ePBgEolE RERUVVVFvXv3Jj6fT1u3bqXS0lIqLy+nPXv2UMeOHcne3p4ePnwoVc/MmTMJAN2+fbvNfojHiY2N DaWmptLTp0/p5s2b9O677xKHw6Hdu3dLlXdxcSGBQEDjxo2jixcvUm1tLWVnZ9PAgQPJwMCA0tPT pcq/9dZbJBAI6N69e3Tx4kXi8Xh048YNyft+fn4EgOrr6zXOSV4dRESRkZEEgHJyciTLPD09CQBF RUXR48ePqa6ujs6dO0fdunUjAHTmzBmZ/sob78r2g8ePH5OxsTFxOByF21pVwcHBBIBOnDihsExb 40qTGHljsa36tLWfa7suZf1U9/NEKBSSlZUVhYSEyK1PW7mLlzs4ONCBAweouLiYGhoa6M6dOxQd HU0GBgbk5uZGDQ0NavVX3e3KvFg3b94kDodDJ0+e1Gk7r7/+On300Uc6bYORlZGRIdmvhUKh3DKl paVkZGQk9X89JyeHjI2NydHRkQBQdna2wjZWrVpF/fr1U/iZuHLlSgIg839UrLm5mby9vQkANTU1 ERFRVlYWAaD58+fLjVm0aBFZWloqzEkRoVBI9vb25OrqSgAoPDxcYVlln2379+8nAOTk5KRyjCbr QV3q9E/TfDSNU+V7g0AgkBprmowDXY0dIu3uF2LaGpNERMuWLSMA5OvrK/P/Vlex9+7dIy6XSzwe jyoqKhTmzuhOaWkpAaDTp0/LvMcmyBiGYRiGYfQoLi6ODAwMqKioSN+pMP/v/v37kgkaADR8+HCZ Mnfu3JEqA4BsbGyIiKi8vJxCQkKoe/fuxOfzydbWlgICAui3336TqkPVchUVFRQWFkY9evQgPp9P VlZW9Oabb0pNFkRHR8vks2rVKqX9NDExkSo/YcIEpeVb1w+Atm3bJlMuOzub5syZQ46OjmRgYECd OnWiIUOG0Pr166m6ulppG0TPJ2B4PJ7Sg1SqyMrKolmzZpGDgwPx+Xzq1KkTubu709atW6mxsVGq bOt1AYD8/f1l6hw5cqTkfQ8PDyIiqqyspIiICHrttdfI0NCQDAwMqGfPnvTxxx9TSUmJTB2enp5k ampKzc3NKvWj9TgRCAQ0YcIESktLkykrnhi6ceMGTZgwgTp16kTGxsY0evRoysjIkClfUFBAo0aN IhMTE3JwcKAdO3YQEdHRo0dl1kfLgxaq5HTp0iWFY7L18nfeeYeInk9eBQcHS7aZjY0NBQUF0fLl yyVl3dzcFI53VfeD+fPnEwD68ccfVdoGrcXHx8vdH2pqaqTKyRtXffv2VVp3e8aiKvW1Zz/XZV0A KDo6WqYOdT5PxAe4f/jhB52uB6FQSBkZGRQeHk7Dhw8nOzs74vF4ktw2btxIz549U9p+e7cr8+IF BQVRz5492/V/SRWffPKJzGQC82L07t2bAMUn50RHR5OPj4/UMvHE+86dO5UeVK+qqiILCwvau3ev 3ImA/Px84nK55ObmpjTHixcvSk2oiP8fxcTEyC2fnp6u0STHiRMnyNHRkbKzsyXfcRVNRimbFCgu LpZ8plVVVbUZo+l6UJeq/dM0n/b0Q5MTazQZB7oaO0Ta2y9a0taYJCISiUQ0fPhwAkAJCQkvLNbe 3p4A0Llz5xT2k9GdgwcPEo/Hk/t7lE2QMQzDMAzD6FFTUxP179+f3nrrLXbGOMP8xVVVVZGxsTF9 8MEHOqlf3SsI/67i4uLaPGjF/PlERESQhYWFxgdMGUaR8+cyGmyIAAAgAElEQVTPE5fLpcTERJ23 dfr0aQIguZKceXE2bNhAACggIEDu+/3796dvv/1Wapl4IqChoYHs7e2Jw+FQbm6uTOxnn31GgYGB Cq9MDQ0NJQC0adMmtXI+fvy4SpP+6po6dSqtWbOGiIgGDhxIACglJUVuWWWTAg8ePJBMkLU8KK0o RtP1oC5V+6dpPu3ph7L16eHhQfHx8TLLNRkHuho7RNrbL1rS1pgU27dvHwGgkSNHvrBYOzs7AkAX L15UWDejO3PnzqVRo0bJfY89g4xhGIZhGEaPeDwevv76a5w9exbR0dH6TodhGB0hIixZsgRmZmZt Po+B0a1du3YhLCxM32kwWpaSkoK3334bPB5P36kwfyGlpaUIDAyEj48P/P39dd7eqFGj0LFjR5w6 dUrnbTHSZs+eDS6Xi+TkZFRXV0u999NPP6GsrAwTJ06UG2toaIiIiAgQETZs2CD1Xm1tLbZt24aV K1cqbPv8+fMAgIEDB6qV86hRo9C1a1ecOnUK3t7eSE9Ph0gkUquO1iorK5Gamoo5c+YAAObOnQsA Cp/tqkx6ejoAwMnJSe5zs1rTdD2oQ53+aZrPi+hHS5qMA12Mndbau1+IaXNMio0cORIAcPnyZTQ1 Nek89t69e3j06BHMzMzg5OSkXrJMu4lEIpw+fRpvvvmm3PfZBBnDMAzDMIyeubu7IyoqCitWrEBi YqK+02EYRgdKS0tx+/ZtpKWloWvXrvpO529lz549mDx5Mmpra7Fr1y5UVVVh2rRp+k6L0bKbN29i 3759+k6D+Qt58uQJfH19YWhoiLi4OHA4HJ23aWRkBF9fX+zcuVPnbTHSXnnlFXh5eaGhoUHm+3h8 fDwCAwPB5/MVxi9YsAA2NjY4fPgw8vPzJct37NgBT09P9OvXT2Hsw4cPAQCWlpZq5WxqaoqkpCQ4 ODjg5MmTGDt2LGxtbREYGIjExETU1dWpVR8AJCQkYMSIEejevTsASPp97NgxlJWVqVTH06dPcfTo UYSFhYHP5+OLL75QKU7T9aAOdfqnaT7a6EdKSgo4HI7UKzMzU25ZTcaBLsaOPO3ZL8S0MSZbE38X b25uRnl5uc5im5qacO3aNcyYMQN8Ph/bt2+HmZmZRjkzmvvuu+/w6NEjvPfee3LfZxNkDMMwDMMw L4HQ0FCEhoYiMDAQ27dv13c6DMNoWdeuXZGRkaGTs0ZjYmLA4XCQm5uL4uJicDgcrF69Wuvt/Jkl Jyejc+fO2LlzJw4ePMiuMmIYRqlHjx5h9OjRKC4uxrFjx3R6wL615cuX49q1a+wqMj0QX5kSHx8v WVZfX4+DBw9i3rx5SmONjY0RFhYGkUiEjRs3AgDq6uqwZcsWrFq1SqX2NZmEHTlyJAoLC/HNN9/A z88P9fX1OHDgAGbMmIFu3brh4MGDatUXHx8vWQ8A0KVLF/j4+KC5uVnpSQgtJ3TMzc0xf/58uLu7 IzMzE15eXmrloMvJaE36p2k+7emHn58f6PmjkSQvDw8PheU1GQfaHjvyaGO/0HRMKkNEGsWpEtty XzAwMICrqyusra1x48YNzJo1S+N2Gc1FRUXBz88Pr732mtz32QQZwzAMwzDMSyImJgaff/45li5d iqVLl7brizvDMH8f4eHhMgdR1q9fr++0XhoffPABiAhNTU3Izc3F4MGD9Z0SwzAvsVu3buGNN97A H3/8gYsXL6J3794vtH0XFxe8+eab2LRp0wttlwEmTZoEc3NzZGdnIy8vDwBw5MgR9OrVC87Ozm3G L1q0CJaWlkhMTERRURFiY2Ph7u7e5q327OzsAEDtK1nEDA0NMXv2bCQnJ6OyshJpaWkICAhARUUF AgMDkZOTo1I9169fR2FhIaZMmSK1XN7EYWstJ3REIhHKy8uRkpKCoUOHqtyP9q6HtqjbP03z0XU/ FNFkHGhr7Cij6X4BtG9MKvPo0SMAAJ/PR5cuXbQa23JfePDgAfz9/XH06FHs3r1bo1yZ9vnhhx9w 6dIlREZGKizDJsgYhmEYhmFeIkuXLsXevXuxc+dOvPXWW5JbdDAMwzAMwzC6lZSUhKFDh8LCwgLn z59Ht27d9JLHqlWr8OOPP+Lw4cN6af/vysjICAEBAQD++3yjuLi4Nq8eEzM1NUVISAiEQiHWrFmD mJgYla7oHj16NIDnkwHtxePx4OnpicTERERGRkIoFKo8juLi4lBTUwMTExOpW/v5+voCAPLy8pCV ldXuHBXR5nqQR93+aZqPrvqRkZGBoKAglcpqMg7aM3aU0XS/AHQ3JjMyMgAAI0aMUHrr1PbG2tvb Y+/evejZsyeio6Nx5coVtXNlNNfU1ITQ0FC8+eabGD58uMJybIKMYRiGYRjmJTNr1ixcuHABd+7c gZOTE3suGfOncO3aNZlnJfTq1UumXHV1tUy51q9Lly612V5ERIRUjLwrprKzsxEUFITu3bvD2NgY FhYWGDBgAKZMmYKdO3fi1q1bUuWFQiF27dqF119/HQKBAHw+H3Z2dnj77bexfft23L17V6N1U1hY CA6HA3d3d4VlTE1N5a4LLpcLKysrTJo0CdnZ2W3GxMTEtHs9tEVRrhwOB0ZGRhg4cCB27NghcxWs srjWL0UHEK5du4YFCxagb9++MDU1hampKfr06SO52iInJ0emXW1v19raWp2NWUDz8cLlctG5c2e4 uLhg0aJFuHr16guJVWXbM8zLrrq6GoGBgfD398fUqVPxww8/qH1VgTaNGjUK77//PhYuXKjxM3YY zYivTNm/fz+Kiopw6dIlTJ8+XeX4xYsXQyAQICEhAS4uLhgyZEibMcHBweDxeG1ORixbtgxcLhcF BQUAgMzMTNjY2CgsP3bsWABAVVVVmzk0NTXhwIEDyMzMlLkqnYgQEhICQPMrdlSh6XpQhSb90zQf XfZDHk3GgTbHjio02S90NSZFIhF27NgBAPjoo490HmtkZISNGzeCiLB8+XK12mPaZ+PGjSgsLJRs M4WIYRiGYRiGeSnV1NTQ/PnzCQDNnDmTHjx4oO+UGKZN77//PgGgVatWKS3n6+tLmzdvlvydk5ND AAgAeXt7K40tLy8nU1NTyb7RmlAopPDwcOLxeBQREUH5+fnU0NBAJSUldPr0afLy8pK01dTUJImb Pn06cblc2rx5M92/f5/q6+upqKiIVq5cSRwOhywtLdVcG8+tWLFC0l5eXp7CcuJ14OfnJ1lWXV1N R44cIWtra+Lz+XTmzJk2Y9q7HlQhr93GxkbKyckhDw8PAkAREREqxbUmEAgoOztbpi/Lli2jDh06 0Mcff0w5OTlUV1dHVVVVlJWVRfPmzZP0pXWsrrarNsdsS5qOl+bmZiopKaHk5GQaO3YsAaCgoCB6 9uyZTmOJVNv2DPMyEolElJCQQLa2tuTg4EBpaWn6TkniyZMn5ODgQDNmzNB3Kn87/fv3JwA0bNgw CggIUFguJyeHTExMZJZ/9tlnJBAIKDMzU2r5hQsXFP4fWLduHQGgr7/+Wm5bBQUFZGZmRv7+/jL1 Xbp0SW7M+vXrCQDt3r1bYR/Evv32W3rttdcUvv/LL78QABIIBFRXVydZrsr/9daUxWiyHlShaf80 zUfTOFXWp5ubGyUmJkr+1mQcaHPstKat/UJXY3LZsmUEgCZPnkwikUgmd13EikQicnV1JQB0+vRp hX1itOfGjRtkaGhIW7ZsabMsmyBjGIZhGIZ5yaWmplL37t3JxMSE1q5dS7W1tfpOiWEUysjIIADk 4OBAQqFQbpnS0lIyMjKihw8fSpbl5OSQsbExOTo6yp3kaGnVqlXUr18/hQeZVq5cqfRHfXNzM3l7 e0tNDGVlZREAmj9/vtyYRYsWaTSRIhQKyd7eXvKjODw8XGFZZT+s9+/fTwDIyclJ5RhN1oOqlLV7 79494nK5xOPxqKKiQuU4MXkTZOK+7Ny5U2FcZGSkzNjR1XYl0u6YFdPWeCH670EcX19fjQ8AqRur bNszzMvm4sWLNHz4cOJyufT+++9TVVWVvlOScfz4ceJwOLRr1y59p/K3EhUVJTlR4dSpUwrLKZoI UETZBBkR0fLly4nP51NkZCTdvHmTGhsb6cGDB7Rnzx6ytbWlkSNHSv0OENfn4OBABw4coOLiYmpo aKA7d+5QdHQ0GRgYkJubGzU0NLSZm4+PD0VFRSktM2zYMAJA+/fvlyzT9gQZkfrrQRWa9q89+WgS 154JMnXGgTbHTmva2i+0NSaFQiGVlpZScnIyeXp6EgCaN2+e1KSaLmJbO3bsGAGgwYMHy3y3YrSr srKSXnvtNfLw8FD4e7QlNkHGMAzDMAzzJ1BfX0+bNm0iMzMzsre3p/j4eLUPaDPMi9K7d2+lB5Wi o6PJx8dHapn4x/TOnTuV/risqqoiCwsL2rt3r9wf0/n5+cTlcsnNzU1pjhcvXpSaGIqPjycAFBMT I7d8enq6RhMpJ06cIEdHR8rOziYAZGNjo3DfVfbDuri4WHKwruVBXEUxmq4HVbV1EMDe3p4A0Llz 59SKk+fGjRsq9aWqqoqMjIykJqp0tV2JtDdmW9LWeCF6frby8OHDCQAlJCS8sFhF255hXhaFhYXk 7+9PHA6Hxo4dSzk5OfpOSam1a9cSj8djVx28QI8ePSIej6f0ZB8TExPJ/2UANGHCBKV1tiwrfm3b tk2mXFZWFs2aNYscHByIz+dTp06dyN3dnbZu3UqNjY1SZYVCIWVkZFB4eDgNHz6c7OzsiMfjUadO nWjIkCG0ceNGuVcCt3T//n2pnIYPHy5T5s6dOzK529jYyKwDANS3b1+l7cmLiY6Obtd60FX/tJGP OnHy1o2iV8sJMk3GgTbGjjza2C/EJzxpa0xyOBwSCATk7OxMCxcupKtXr6qUe3tj5V3lOHLkSMn7 Hh4eKqxRRl1//PEHeXl5kZ2dHd2/f1+lGDZBxjAMwzAM8ydSWlpKwcHBxOPxqHv37vTll19SfX29 vtNiGCkbNmwgAApvS9S/f3/69ttvpZaJJxsaGhrI3t6eOBwO5ebmysR+9tlnFBgYqPBs09DQUAJA mzZtUivn48ePq/RDXl1Tp06lNWvWEBHRwIEDCQClpKTILats4uHBgweSH9TV1dVtxmi6HlTV1iSJ nZ0dAaCLFy+qHOfh4UHx8fEyy0NCQjTui662K5H2xmxL2hovYvv27SMANHLkyBcWq2jbM4y+5ebm 0vTp06lDhw7Up08fSk5O1ndKKhGJRDRr1iwyMzOj69ev6zsdhmEYhnlpffjhh2RqakrXrl1TOYYL hmEYhmEY5k/D2toau3btQmFhISZOnIhPPvkEjo6OWLt2Laqrq/WdHsMAAGbPng0ul4vk5GSZcfnT Tz+hrKwMEydOlBtraGiIiIgIEBE2bNgg9V5tbS22bduGlStXKmz7/PnzAICBAweqlfOoUaPQtWtX nDp1Ct7e3khPT4dIJFKrjtYqKyuRmpqKOXPmAADmzp0LAIiLi1O7rvT0dACAk5MTBAJBm+U1XQ/a cO/ePTx69AhmZmZwcnJqd33ivri4uKgdq4vt2lp7x6yYNseL2MiRIwEAly9fRlNTk85jtb3tGUYb fv75Z0ybNg2DBg3Cr7/+iri4OOTl5cHPz0/fqamEw+Hgq6++grOzM7y9vVFQUKDvlBiGYRjmpUJE +OSTT/DVV1/h4MGDav1uYBNkDMMwDMMwf0Kvvvoqtm7dirt372LhwoXYunUrHB0dERwcjNzcXH2n x/zNvfLKK/Dy8kJDQwMSExOl3ouPj0dgYCD4fL7C+AULFsDGxgaHDx9Gfn6+ZPmOHTvg6emJfv36 KYx9+PAhAMDS0lKtnE1NTZGUlAQHBwecPHkSY8eOha2tLQIDA5GYmIi6ujq16gOAhIQEjBgxAt27 dwcASb+PHTuGsrIylep4+vQpjh49irCwMPD5fHzxxRcqxWm6HtqjqakJ165dw4wZM8Dn87F9+3aY mZnJLZuSkgIOhyP1yszMlFv20aNHAAALCwu1c9LFdpWnPWNWTBvjpbWuXbsCAJqbm1FeXq6zWHW2 PcO8CI2NjUhKSsL48ePh5uaGW7du4dChQ8jNzcXs2bPB4/H0naJaDA0NcezYMTg6OmL06NHsux7D MAzD/D8iwtKlS7F161bEx8fjnXfeUSueTZAxDMMwDMP8iVlbW2Pt2rW4ffs2/vGPf+CHH37AoEGD 8MYbbyAhIQGNjY36TpH5mxJf/RIfHy9ZVl9fj4MHD2LevHlKY42NjREWFgaRSISNGzcCAOrq6rBl yxasWrVKpfY5HI7aOY8cORKFhYX45ptv4Ofnh/r6ehw4cAAzZsxAt27dcPDgQbXqi4+Pl6wHAOjS pQt8fHzQ3NyMffv2KYxrOXlkbm6O+fPnw93dHZmZmfDy8lIrB03Wgzpa5mpgYABXV1dYW1vjxo0b mDVrlsI4Pz8/0PNb/kteHh4ecssSkdIcBg0aJDXRNmnSJKn3tb1d5dHGmNV0vCjT1rprT6ym255h dKmgoAChoaGwtbXFrFmzYGVlhQsXLuDq1auYOnWqzj8TdUkgEOD06dNwcXHBmDFjcPnyZX2nxDB6 1/pkG3mvtWvX6jvNPz22npmXlVAoxLx58xAbG4ukpCSNvoOyCTKGYRiGYZi/gM6dO+OTTz7BzZs3 cebMGVhbWyMoKAgODg4ICQlBVlaWvlNk/mYmTZoEc3NzZGdnIy8vDwBw5MgR9OrVC87Ozm3GL1q0 CJaWlkhMTERRURFiY2Ph7u7e5i0D7ezsAEDtq2XEDA0NMXv2bCQnJ6OyshJpaWkICAhARUUFAgMD kZOTo1I9169fR2FhIaZMmSK1XN7EYWstJ49EIhHKy8uRkpKCoUOHqtyP9q4HVbXM9cGDB/D398fR o0exe/durbVhb28PQHFfrl27BiJCdna2wjq0tV2V0XTMAu0bL8qIr77j8/no0qWLVmNfxLZnGFVU VVVhz549GDNmDPr374+UlBQsW7YM9+7dQ0JCguR2oX8FJiYmSElJgYeHB8aPH48jR47oOyWG0avW J9vIe7GJm/Zj65l5GVVVVcHHxwf/+c9/kJqaismTJ2tUD5sgYxiGYRiG+QvhcDjw8vLC4cOHcffu XSxZsgQnT57E8OHD0adPH6xduxa//fabvtNk/gaMjIwQEBAA4L/PUIqLi2vz6jExU1NThISEQCgU Ys2aNYiJicHq1avbjBs9ejSA5xMO7cXj8eDp6YnExERERkZCKBTi8OHDKsXGxcWhpqYGJiYmUmfX +vr6AgDy8vJ0OnGtzfWgKnt7e+zduxc9e/ZEdHQ0rly5olZ8RkYGgoKCZJa/8cYbAJ4/R0gb2rNd ldF0zAK6Gy8ZGRkAgBEjRii9rWl7Y9u77RlGXQ0NDTh8+DDeffdd2NraYvHixbCyssKxY8dQVFSE 5cuXw9raWt9p6oSxsTGOHj2KOXPm4L333sPq1au1/mxFhmEYhnmZ/frrrxg2bBh+/fVXpKen4803 39S4LjZBxjAMwzAM8xdlZ2eH1atXo6CgAFeuXIGPjw92796Nvn37YtiwYfjXv/6FW7du6TtN5i9M fPXL/v37UVRUhEuXLmH69Okqxy9evBgCgQAJCQlwcXHBkCFD2owJDg4Gj8drc8Jj2bJl4HK5KCgo AABkZmbCxsZGYfmxY8cCeH6mYluamppw4MABZGZmyj3DNiQkBIDmVwWpQtP10F5GRkbYuHEjiAjL ly/XSp3z588Hl8vFwYMH1b5loDa3qyo0GbO6Gi8ikQg7duwAAHz00Uc6j9XFtmeYlhoaGvD9999j 7ty56Nq1KwICAlBTU4Ndu3ahpKQESUlJ8Pb2Bpf71z/UJX7W37///W98/vnn8PHx0drnGPPiXbt2 TeZ2db169ZIpV11d3eZt7i5dutRmexEREVIx69evB/D8RA9VbqXH4XAkJ0IMGDBA5j3xCVIA4OXl JfWe+P+ivLZiYmJkbpvc1kucuyoKCwvB4XDg7u6usIyidcDlcmFlZYVJkybJXLGuqC+tZWdnIygo CN27d4exsTEsLCwwYMAATJkyBTt37mz37zJV+qeNfNSJ02RMiQmFQuzatQuvv/46BAIB+Hw+7Ozs 8Pbbb2P79u24e/euTG6axDB/PqmpqfDw8ICNjQ2ys7PVusuGXMQwDMMwDMP8bTQ3N9OZM2coKCiI LCwsCAA5OzvTp59+SlevXtV3esxfUP/+/QkADRs2jAICAhSWy8nJIRMTE5nln332GQkEAsrMzJRa fuHCBQJAM2fOlIlZt24dAaCvv/5ablsFBQVkZmZG/v7+MvVdunRJbsz69esJAO3evVthH8S+/fZb eu211xS+/8svvxAAEggEVFdXJ1mek5NDAMjPz6/NNlSJ0WQ9aKNdkUhErq6uBIBOnz6tcpyYm5sb JSYmSi1buXIlAaBNmzYpjLt8+bJM3drcrq1pa8zqarwsW7aMANDkyZNJJBLJ5K6LWGXbnmE0UVVV Rfv376f33nuPTE1NicPh0PDhw2nLli308OFDfaf3Urh69Sp169aNHB0d6dy5c/pOh2mH999/nwDQ qlWrlJbz9fWlzZs3S/4Wfy4DIG9vb6Wx5eXlZGpqqvA7lCr/pwUCAWVnZ0v+LikpIUtLSwJA+/fv lyl/7Ngx6t27Nz179qzNtlxcXCgpKUmqXHBwMAGgEydOSC339/endevWKe1vSytWrJCsp7y8PIXl 5OVVXV1NR44cIWtra+Lz+XTmzJk2Y8SEQiGFh4cTj8ejiIgIys/Pp4aGBiopKaHTp0+Tl5eXJK+m piaV+6Np/zTNR9M4TcYUEdH06dOJy+XS5s2b6f79+1RfX09FRUW0cuVK4nA4ZGlpKVOPJjHMn0dd XR0tWbKEOBwOLViwgBobG7VSL5sgYxiGYRiG+Ztqamqis2fP0scff0wODg4EgBwdHWnJkiV0+vRp qq+v13eKzF9AVFSU5MfyqVOnFJZTNNmgiLIJMiKi5cuXE5/Pp8jISLp58yY1NjbSgwcPaM+ePWRr a0sjR46k2tpamfocHBzowIEDVFxcTA0NDXTnzh2Kjo4mAwMDcnNzo4aGhjZz8/HxoaioKKVlhg0b JnMgSdsTZETqrwdttXvs2DECQIMHD5aaYNF0gkwoFFJERARxOByaN28eXblyhZ49e0Z1dXV0/fp1 2rBhA9nY2FCHDh2kDpZpc7vKWwfaGLPaGi9CoZBKS0spOTmZPD09CQDNmzdPalJNF7GtKdr2DKOq W7du0Y4dO2j8+PHE5/OJz+fT+PHj6csvv6QHDx7oO72XUmlpKfn5+RGXy6WwsDD2He5PKiMjQ/I/ SygUyi1TWlpKRkZGUhPEOTk5ZGxsTI6OjgRAZqKhpVWrVlG/fv20OkFGRHTgwAECQJaWllRSUiJZ XllZSQ4ODjInjShqS1cTZEKhkOzt7SUncYSHhyssq2wd7N+/nwCQk5OTyjHik3wUnYzT3NxM3t7e 7ZogU6d/muajaZwmYyorK4sA0Pz58+WWX7RokcxklyYxzJ9HZmYm9erViywtLenQoUNarZtNkDEM wzAMwzAkEokoOzubVq1aRQMGDCAA1LFjR/L29qatW7dSQUGBvlNk/qQePXpEPB5P6cEeExMTySQa AJowYYLSOluWFb+2bdsmUy4rK4tmzZpFDg4OxOfzqVOnTuTu7k5bt26VOeNQKBRSRkYGhYeH0/Dh w8nOzo54PB516tSJhgwZQhs3bpQ587m1+/fvS+U0fPhwmTJ37tyRyd3GxkZmHQCgvn37Km1PXkx0 dHS71oMq5LUr7yq0kSNHSt738PCQG6fo1XqCTOzq1as0b9486tmzJxkbG5OBgQF17dqVPD09af36 9XT79m2p8trYrqqsA03GbGRkpFbHC4fDIYFAQM7OzrRw4UKFVwVrO1aVbc8wytTW1tL3339PH3/8 MfXu3ZsAkKmpKb333nu0f/9+qqqq0neKfxpxcXFkZmZG/fv3pytXrug7HUYD4n1A0UlF0dHR5OPj I7VMfMLGzp07lU5EVFVVkYWFBe3du7ddE2SK+Pr6EgCaMmWKZNnMmTNp2bJlcsur2paiCTJ1nDhx ghwdHSk7O1vyv1TRZJSyvIqLiyX/31p+NimKyc/PJy6XS25ubkrzu3jxYrsmyFTtn6b5tKcfmoyp +Ph4AkAxMTFy309PT5eZ7NIkhnn5NTY20ooVK6hDhw7k7e1NxcXFWm+DTZAxDMMwDMMwMn7//Xfa vXs3TZkyhczNzQkAvfrqqxQcHExHjhyhiooKfafIMAzDMMyfkFAopJ9//pmioqJo3LhxZGhoSBwO hwYNGkSRkZH0ww8/aO22SX9Hv//+O40dO5a4XC7NmjWLysvL9Z0So4YNGzYQAIW3pe7fvz99++23 UsvEE2QNDQ1kb29PHA6HcnNzZWI/++wzCgwMVHoVvrLJDA8PD4qPj1eY+8OHD6lz584EgJKSkujo 0aPk5OSk8CrtFzlBNnXqVFqzZg0REQ0cOJAAUEpKitp5PXjwQDJBVl1d3WZMaGgoAcpvEa0NqvZP 03za0w9NxtTx48dVOgGpvTHMyy0tLY369+9PxsbG9MUXX+jszgR//SeXMgzDMAzDMGrr1q0b5s+f j8OHD6O8vBxXrlzBhx9+iFu3bmHatGmwtLREz549ERwcjKSkJFRUVOg7ZYZhGIZhXlK3b9/G7t27 MW3aNFhbW2Pw4MGIioqChYUF/vd//xf37t1DTk4ONm3ahDFjxsDAwEDfKf9pdevWDWlpaYiPj8ep U6fQt29fbN26FSKRSN+pMSqYPXs2uFwukpOTUV1dLfXeTz/9hLKyMkycOFFurKGhISIiIkBE2LBh g9R7tbW12LZtG1auXKmz3G1tbbFlyxYAwEcffYSPP/4Y33zzDQwNDXXWpioqKyuRmpqKOXPmAADm zp0LAIiLi1O7rvT0dACAk5MTBAJBm+XPnz8PABg4cLRyY1kAACAASURBVKDabalKnf5pms+L6EdL o0aNQteuXXHq1Cl4e3sjPT29zc8wTWKYl1NxcTFmz56NcePGoUePHrhx4waWLl0KDoejk/bYBBnD MAzDMAyjVIcOHeDm5obIyEicOXMGpaWlSE5OxsSJE5GVlYWAgABYW1vD1dUVoaGhSElJwePHj/Wd NsMwDMMwetDc3Iyff/4ZW7duxaRJkyQn1axcuRJNTU349NNPkZubi9LSUvznP//BggUL8Morr+g7 7b8UDoeD2bNno6CgAP7+/vjkk08watQoXL16Vd+pMW145ZVX4OXlhYaGBiQmJkq9Fx8fj8DAQPD5 fIXxCxYsgI2NDQ4fPoz8/HzJ8h07dsDT0xP9+vVTKY+UlBRwOBypV2ZmZptxc+bMwdtvv42ysjL0 6tULbm5uKrWnSwkJCRgxYgS6d+8OAJJ1eOzYMZSVlalUx9OnT3H06FGEhYWBz+fjiy++UCnu4cOH AABLS0vNkleBOv3TNB9t9EOdMWVqaoqkpCQ4ODjg5MmTGDt2LGxtbREYGIjExETU1dVpJYZ5udTV 1WH9+vXo06cPfvrpJ5w8eRKpqal49dVXddoumyBjGIZhGIZh1GJhYQE/Pz988cUXyMnJQXV1NU6d OoUJEybgwoULePfdd2FtbQ07OztMmzYNW7duxdWrV9kZfAzzkmt90ELea+3atfpOU6fYOmAY9T19 +hRnz57F2rVrMXHiRFhZWcHNzQ2ffvopnj17hmXLluHKlSsoKyvD0aNHsXTpUgwcOBBcLjskpWud O3fGjh07kJ2dDSLC0KFDERAQgMLCQn2nxighvgIoPj5esqy+vh4HDx7EvHnzlMYaGxsjLCwMIpEI GzduBPD8oPOWLVuwatUqlXPw8/MDPX80j+Tl4eGhUmzv3r0BAD/++CNSUlJUblNX4uPjJesUALp0 6QIfHx80Nzdj3759CuNaTuiYm5tj/vz5cHd3R2ZmJry8vNTKQVdXvgCa9U/TfNrTD3XH1MiRI1FY WIhvvvkGfn5+qK+vx4EDBzBjxgx069YNBw8e1EoMo39NTU2IjY1Fnz59sGnTJqxevRq//PILJkyY 8ELaZ99GGIZhGIZhmHbp1KkTvLy8sGnTJly5cgUVFRU4fvw4PvjgA1RWVuLTTz/FkCFD0LlzZ0yY MAFr167FyZMnUV5eru/UGYZpofVBC3mvv/rkEFsHDKNcc3Mzrl+/jq+//hrz5s1D//79YW5ujvHj x+PgwYPo0qULoqKi8Ouvv6K6uhpnzpxBZGQk3Nzc2ISYHrm6uuLixYs4ffo08vPz0b9/fwQHB0uu CmFeLpMmTYK5uTmys7ORl5cHADhy5Ah69eoFZ2fnNuMXLVoES0tLJCYmoqioCLGxsXB3d38ht8e7 cOECjhw5gs8//xwA8OGHH6Kqqkrn7Spy/fp1FBYWYsqUKVLL5U1CttZyQkckEqG8vBwpKSkYOnSo yu3b2dkBgM5+96jbP03z0XU/FDE0NMTs2bORnJyMyspKpKWlISAgABUVFQgMDEROTo5WYhj9ICIk JSVhwIABWLx4Md555x0UFhZixYoVL/RWy+zbCcMwDMMwDKNV5ubm8Pb2xj//+U+cPXsWVVVV+PXX X7Ft2za8+uqrSEpKwttvvw0rKyvY2dlh4sSJWLt2LVJTU9mkGcMwDMO8RB4+fIikpCQsXboUI0eO hEAggIuLC5YsWYLffvsN48ePx6FDh1BWVoaCggLEx8dj/vz5cHJyYhNiLyEvLy/8/PPPiI2NxcmT J9G7d29ERESgpKRE36kxLRgZGSEgIADAf58jFRcX1+bVY2KmpqYICQmBUCjEmjVrEBMTg9WrV7c7 r4yMDAQFBSl8v7a2FkFBQdi9ezdCQ0Ph7e2NkpISLF26tN1tayouLg41NTUwMTGRuhrc19cXAJCX l4esrCydtT969GgAzyeydEHd/mmaj6760daYaonH48HT0xOJiYmIjIyEUCjE4cOHtR7D6B4R4bvv vsOQIUMQEBCAYcOGoaCgALGxsbC1tX3h+bBvKwzDMAzDMIxOdejQAU5OTpg9ezZiY2ORl5eH0tJS HD9+HAsXLgSXy8VXX30FX19fWFtbo2/fvpg5cyY+//xzpKWlobKyUt9dYBiGYZi/tObmZuTl5SEh IQHh4eEYM2YMzMzMYG9vj8DAQFy8eBEDBw7Etm3bkJubiydPniAjIwNbt27F1KlTYWVlpe8uMCrq 0KED5s2bh5s3b2L9+vXYt28funfvjoULF+L27dv6To/5f+IrgPbv34+ioiJcunQJ06dPVzl+8eLF EAgESEhIgIuLC4YMGaKrVCU++eQTeHl54a233gIAxMbGwszMDPv27cP333+v8/Zba2pqwoEDB5CZ mSn3ivCQkBAAyq8ia6/g4GDweLw2J2WWLVsGLpeLgoIClevWpH+a5qPLfsiTmZkJGxsbhe+PHTsW AKSuTtQkhnmxmpqasG/fPjg7O2PSpEl45ZVXkJOTg3379qFHjx56y4tNkDEMwzAMwzAvnJWVFby9 vfHpp58iJSUFxcXFKC4uRnJyMqZNm4bKykps2rQJXl5esLS0RLdu3TBx4kSsXr0aSUlJKCwsZM80 YxiGYRgNPHnyBOfPn8e2bdvwwQcfYMiQIejUqRMGDBiAoKAgnD17Fr169UJUVBSys7NRU1OD7Oxs fPnll5g3bx4GDhwIHo+n724w7WRkZITQ0FDcu3cPsbGxOHfuHHr37o2JEyfiypUr+k7vb2/YsGHo 378/ysrKMHPmTPj5/R97dx4W1X2oD/xl2Pd9B9FRAw4aRYwbJFFEQTNH0Dhqltos1aSprWmS3iap TWxNb2KTJtfG20Zz06a2TzVOosCMojLGJSxJFMXEUTEwgoLsOwzbLL8/Us5Pgho14GF5P88zzzCH MzPvQRjhvPP9flPg7e190/f39PTEc889B09Pz34ZPXa1adOm9VnL6cCBA8jKysJbb70lbgsPDxdv P/XUU2hsbOzXHN9Ho9HAz88Ps2fPvubnn3zySQDAjh070N7ePiAZ7rrrLrz66qs4ceKEOBrwuwoL C7F161YsX74cUVFRN/3Yt3N8t5tnII8D6Ps9ZbVaUV1djc8///ya+/e8RsXExPyg+9Cd0dnZie3b tyM6OhqPPfYYxowZg+PHjyM9Pf2OTP36ffgbDRERERENCiEhIVi8eLE4JQjw7dROp0+fxunTp1FQ UIDdu3fjjTfegNlshpubGyZNmoS7774bEydOhEKhwMSJExEQECDhURAREQ0OXV1dKCwsxNmzZ3Hm zBmcOXMGp0+fxsWLFwEA3t7emDJlCu69916sXbsWkydPRnR09B1d94Ok5+DggFWrVuHhhx/GRx99 hE2bNmH69OlYsGAB1q5di0WLFnG6TIk89thj+K//+i98+eWX2Lhx4y3f/5VXXsErr7wyAMl6a2xs xOrVq7F9+3a4u7v3+tzq1auxa9cu6HQ6/PKXvxzQ0Vrf9fe///2G01JOnDgR06dPx5dffondu3fj kUceGZAc69evR1tbG55++mlcuHABTzzxBEaPHo2amhrs378fv/3tb3H33Xfjgw8+uKXHvd3ju908 A3UcN7J8+XK88cYbmDNnDnx9fVFRUYGPP/4Yv//97xEbG4tVq1b1y31oYJSVleG9997Dtm3b0Nra iscffxwHDhzAmDFjpI7Wi43VarVKHYKIiIiI6Ga1t7fjzJkzKCgowOnTp8WTfnV1dQAAPz8/TJo0 SSzMeq59fHwkTk5ERNT/TCYTvvnmG+j1+l6Xb775Bt3d3bCzs8P48eMxceJETJ48GXfffTcmT56M UaNGSR2dBiGr1Yp9+/Zh8+bN0Ol0GDNmDJ555hk88cQTtzSCiX64yspKhIeHIzg4GCUlJdcsKt3c 3NDW1ibeTkpKwv79+6/7mDY2Nn22vfvuu1i7dm2fx7qRHTt2YOXKlQgLC0N5ebm4PSUlBWlpaQC+ Lc6u9T3zzjvviGXL1d5880288MIL4u0PP/xQnGryai0tLXBzc7tutrKyMoSHh4u3Z8yY0WdUUUlJ SZ+T9IGBgWhtbe2TKzIy8oZTBl7r6/bdYwGA48eP491338WRI0dQWVkJJycnREdH46GHHsLTTz99 029O+CHHd/V6g7eb51budzvfUwBgsViQl5eHtLQ0fPbZZ7h8+TKqq6vh7OyMyMhILF26FOvWrYOL i4t4/9u5Dw2MY8eOYcuWLdizZw/8/PywevVq/OxnP7vhFJhSYkFGRERERMNCZWVln5ODer1enM4l KCgIUVFRiIyMxF133SV+PHr0aNja2kqcnoiI6MYaGhpw4cIFnD9/HoWFhbhw4YJ43dXVBVtbW4wZ M0Z8c0jPm0WioqI4KoxuS2FhIbZs2YLt27fDZDLhkUcewTPPPIMpU6ZIHY2IiAaR1tZW7Ny5E1u2 bMHp06cxc+ZM/PznP8eyZcsG/e8gLMiIiIiIaFgrKyvD2bNnodfrxROJ58+fR0VFBYBvpxYaN24c IiMjxfIsMjIS48aN43SNRER0R3V2duLixYu9yq/CwkKcP38eNTU1AABHR0eMHz9e/D9rwoQJiI6O xoQJE+Ds7CzxEdBw1NLSgu3bt2PLli04f/48YmJi8MQTT+Dhhx/mCH0iohHKarUiJycHf/vb36BW q2EymbBixQqsXbsW06ZNkzreTWNBRkREREQjUmdnJ4qKinD27FkYDAbo9XqcPXsWhYWFaG1tBfDt ScjQ0FDI5XIoFApER0dDLpdDLpcjIiKCI8+IiOiWdXZ2ory8HAaDodf/PwaDAaWlpTCbzQC+XSPs u//39IwI4/8/JJX8/Hxs27YNO3bsQFdXF+bPn49Vq1ZhyZIlsLOzkzoeERENsIqKCuzatQsffPAB vv76aygUCqxatQpPPPEE/P39pY53y1iQERERERFdxWKx4PLlyyguLkZxcTGKiop6XfeUZ05OTpDL 5Rg7dixGjx6NiIgIjBo1SrwEBwdLfCRERCSF9vZ2lJaW4tKlS72uL168iKKiInENGJlMhrCwMIwd Oxbjxo3rc32jNXaIpNba2gq1Wo2//e1vyMnJQWhoKB566CE89NBDiImJkToe0ZB1rXXivuvVV1/F hg0bBj4M0X80NTUhLS0NO3fuRFZWFry9vfHwww/jiSeewOTJk6WO94OwICMiIiIiugVVVVUoKioS CzODwYCSkhKUlpaioqJCfOe/o6Njn9Ls6iItLCxs0M/HTkREfdXV1fUqvr5bhlVXV4v7uru7IyIi Qnz9HzdunFiCyeVyODo6SngkRP3jm2++wT/+8Q/s2LEDBoMBkZGRWLlyJVauXImoqCip4xER0W0w Go3QarXYuXMnMjMzYbVakZycjEcffRSLFy8eNn/LsiAjIiIiIuon3d3dqKmpQUVFhTh1lsFgwJUr V1BRUYELFy6gpaVF3N/b21ucNis4OBghISHi7bFjx8LLy0vCoyEiGpkaGhqu+RpuMBhQVFSEpqYm cd+e1/HvvoZfvY1oJPniiy+wc+dOqNVqlJeXY/LkyVi5ciWWLVuGcePGSR2PiIhuoL29HVlZWfjo o4+QkZGB9vZ2zJs3DytXrsSSJUuG5d+nLMiIiIiIiO6gqqoqcZRBz4iDkpIS8XZ9fb24r7e3N8LD wxEWFoaAgACEhoYiMDBQvA4JCUFwcDCcnJwkPCIioqGhuroaVVVVKC8vR1VVFa5cuYLKykrxuqys DOXl5eju7gYA2NvbIywsDKNGjRJHgfV83DMymK+/RNdmsVhw7Ngx7Ny5E5988glqa2sRHR2N1NRU pKamIjY29qamkiMiooHV0NAArVaL9PR07N+/H+3t7Zg9ezZWrlwJlUqFgIAAqSMOKBZkRERERESD SGtra6/S7PLly7hy5Uqvk7pXT98FfFukBQcHIygoCCEhIb1KtKvLNXd3d4mOiohoYJhMJlRXV4uj vK4uvL772tlTfAGAs7Oz+JrZcx0SEtKrDAsODoZMJpPw6IiGB7PZjLy8PGi1WuzevRvffPMNAgIC kJSUBJVKhaSkpGEzVRcR0VBQXV2N/fv3Q61W4+DBgzCbzZg5cyZUKhWWLVuG0NBQqSPeMSzIiIiI iIiGmO7u7huOgjh8+DA6OjpgNptx9a/79vb2cHd3h6enJ3x9fREQEICAgADxxHBoaCgiIiIQHh4O Pz8/CY+QiEYyk8mEuro61NXVoba2FrW1tWLZVVZWhurqavH1r6qqqtfrnIeHB0JDQxEQEHDD0bfD cYogoqFCr9dDq9VCo9EgNzcXLi4umDt3LgRBwMKFCxEeHi51RCKiYcVsNqOgoAAajQZarRYnT56E s7MzEhISoFKpkJKSAk9PT6ljSoIFGRERERHRMLNmzRp88MEHsFgsAAAbGxvIZDJxKiOr1Qqr1Sp+ /locHR3h4+MDb2/vPpeeqR2vtZ2I6Lva29vR0NCAiooKXLlyBYWFhaisrERtbS2am5tRXV2N2tpa tLa2orW1FS0tLX1en2xtbeHq6gonJyc4ODhAqVSKo7x6XpPCwsJG7MkdoqGquLgYWq0W+/fvx9Gj R9He3o7JkycjOTkZCxcuxOzZs2Fvby91TCKiIae8vBz79+9HZmYmdDodmpqaMH78eCxcuBCLFi3C nDlz4OjoKHVMybEgIyIiIiIaZtLS0rB06VLc6q/6M2fOxPr162FjYyOO3Oi5rqmp6bWtrq6u13Rl wLdTlvn6+sLPzw/+/v7w8/MTb/v6+sLX1xf+/v7w8fGBl5cXPD094enpCTs7u/48fCIaIC0tLWhu bkZTUxMaGxv7vEZc/fpw9ee+y83NDSaTCR0dHb2295T5AHqV+jY2NmJhZjKZEBUVhbNnzw7w0RLR ndbe3o4jR44gMzMTmZmZKCoqgoeHBxISEjB37lzMmzcPCoWCa5cREV1Dc3Mzjh49ik8//RSffvop vvrqKzg7O2POnDlYtGgRFi5ciLFjx0odc9BhQUZERERENMy0tbXB29u7T4F1LXZ2drBarVi/fj1e eeWVW1pvp2dUSM+lZ3TI1duu3l5bW3vNTE5OTnB2doaTk9M1R6x5e3vf8PO+vr589yPR9+j5ee3o 6Ojzs/vdy7X2qaurQ1dXV5/HvdbP5Y1GmYaGhsLR0REmkwnr16/HH//4x14F2PdxcHDAyy+/jFdf fbW/v0RENMgUFRWJIx+OHTuGxsZGBAYGYu7cuUhISEBCQgJP9hLRiGU0GpGTk4PDhw/j008/RX5+ PsxmMyZNmoSEhAQkJSXh/vvvh7Ozs9RRBzUWZEREREREw9B9992HnJycG550trOzQ0REBHbt2oWp U6fekVz19fVoaGhAY2MjmpqaxEvPqJSejxsbG9HY2Nhne1tb2zUf19nZWRyR5uHhAU9PT3h7e4u3 XV1d4erqCjc3Nzg6OsLT01Ms5jw9PeHg4AB3d3e4urrC0dGR6xORpHoKqqamJnR1daGlpQVtbW3o 6upCQ0MDOjs7YTQa0dzcjK6uLjQ3N6OlpeWaP089o72u9ae/TCbr87Ny9XXPxz2fv/pzXl5e8PX1 hZOT0w86Vp1OhxUrVqClpeWmSn0A+OqrrzBp0qQf9LxENLSYzWacPHlSHBmRnZ0No9GIiIgIzJkz B/feey/i4uIQFRUldVQiogHR0tKC3Nxc5OTk4OjRo/jiiy/Q2dmJu+66SxxpO3fuXPj7+0sddUhh QUZERERENAwYjUbk5uZCo9Fgz549cHJywsWLF2EymfrsK5PJYLFY8Mgjj2Dr1q1wdXWVIPHtMZlM vU76X6tc6/m4oaFBvG00GtHa2oq2tjZ0dnaisbHxe5/L0dERLi4u8PDwgIODAzw8PODi4iIWaI6O jn1Kt56Rbp6enrC3t4eHhweA/z9KDgDc3d1hZ2cHGxsbsYhzcHAYUv8ON6Ozs3NYjOwzm81obm4G 8P+LK+DbkxQ9P18NDQ0AgO7ubrS2tsJoNKKzs7NXmdXS0oLOzk40Nzejvb0dHR0daGxsRFdXl7j2 VmdnJ5qamr43U8/3k4eHBxwdHeHu7g4PD48+xVbPx97e3tcsv9zc3Aboq3ZrysrKoFKpcPz4cZjN 5hvuGxISgvLy8juUjIgGq66uLnzxxRc4dOgQjh49ii+//BJGoxH+/v6Ii4sTC7OpU6dyDTMiGpKu XLmC7Oxs5OTk4LPPPsNXX30Fs9mMcePGIT4+XhxNGxYWJnXUIY0FGRERERHREFVUVIR9+/Zh7969 OHr0KLq7uzFt2jQ88MADiImJweLFi/vcx97eHo6Ojnj//fexcuVKCVIPHtcbpdNToF09Sqezs/Om RvFcXYzcLldXVzg4OAAAPD09IZPJYGtr2y9lm4eHB2xtba/73D2PdzPZrqWnIASAv/3tbxAE4YaP 19TUdMNRjleXUNfS8+/xXbdTagEQ//1uJtuNXF2UOjo6ws3N7bqjF3s+f/XoxZE4utFkMmHjxo3Y uHHjdadctLe3h9lsxqxZs6BSqaBSqRASEiJBWiIabLq7u5Gfny+eSM7NzUVNTQ1cXFwwY8YMzJo1 C9OnT8f06dMRHBwsdVwiol66u7tRUFCAL7/8El9++SVycnJQXFwMW1tbTJ48GfHx8WLxz9ew/sWC jIiIiIhoiDCbzcjLy4NWq4VOp0N+fj5cXV0xd+5cCIIApVLZ62TxmDFjUFJSIt6WyWSIi4vDjh07 EBoaKsERjCxdXV3ilJBXFzk90919X4ljtVrFkW5XP9a1SpzrPdbVrt7nWq5+vuv5IcXftVxdqF1L zyi+67leGXi9wrBnBCBw8+UjAHh7ewP4tqDpGXX1fY9Ft+fQoUNYvnz5dadcXL9+PfR6PQ4cOICO jg7MmjULqampWLJkCdciIqJezp07h5ycHGRnZ+OLL75AYWEhrFYrRo0ahenTp2PGjBmYMWMGpk6d OuxGcRPR4FZcXIwvvvhCLMROnTqFjo4OeHp64p577sHs2bMRFxeHWbNmwd3dXeq4wxoLMiIiIiKi QaympgZHjhyBRqNBRkYGmpqaIJfLoVQqIQgC7rvvvuuO6HnuueewZcsWce2hP/zhD3jhhRcgk8nu 5CHQCNJT2OXl5eGBBx7A/PnzcfDgQalj0RBzvSkXfXx8UFNTA5lMhvb2duh0Omi1WqSlpaG6uhoK hUJ8s0BcXBxsbGwkPAoiGmyamprEk9E9l8rKStjZ2SE6OhqxsbGYOnUqYmJicPfddw+aaWiJaGgz GAw4efIkTp06hVOnTuH48eOora2Fvb097r77bsyYMUMc4RoZGcm/1e4wFmRERERERIOIxWLBqVOn oNPpoNFokJeXBwcHB8THxyMxMREpKSk3vQC9TqfD/PnzMWbMGKjVasTGxg5weqJvPf/883jnnXdg Y2ODS5cuccQi3TKTyYTf/va32LRpE2xsbGBra4vHH38cW7du7bNvz+hatVqN3bt3o6ysDBEREUhJ SYEgCJgzZ84Np/okopGrtLRULMt6TmA3NDRAJpPhrrvuQkxMDGJiYsTizMfHR+rIRDRImc1mnD9/ HqdOnRJfTwoKCtDY2AhbW1tERkYiJiYG99xzD6ZPn46YmJgbzqRAdwYLMiIiIiIiibW1teHTTz+F VquFVqvFlStXEBgYiAULFkAQBCQnJ9/W1BpdXV144YUX8Prrr3PqILqjwsPDUVZWBnt7e/zud7/D Sy+9JHUkGqIyMzPx8MMPo7GxEZmZmUhOTv7e++j1eqjVaqjVapw9exa+vr5YtGgRVCoVFixYIE6N SUR0LRcvXhRHevSc5K6oqAAAjBo1CtHR0Zg0aRImTpyIiRMnQqFQ8HWFaIQpKyuDXq/HV199Bb1e jzNnzuDs2bNob2+Hg4MDJk6cKBbrMTExmDx58g2nDSfpsCAjIiIiIpKAwWCARqOBVqvFsWPHYDab MWXKFHHqxKlTp3J6MBqSCgoKEBMTI94ODw9HaWkpv5/ptpWVleHpp5/G7t27rzul7PX0vNaq1Wrk 5ubC2dkZCQkJUKlUSE1N5ZpxRHRTKisrcerUKXz11Vf4+uuvodfrcfbsWXR1dcHOzg7jxo3DxIkT MWnSJERHR2PChAkYN27cLb9mEdHgUl1djXPnzuHs2bP4+uuvcebMGZw5c0ZclzckJATR0dG4++67 ER0djSlTpmDixImwt7eXODndLBZkRERERER3QEdHB7Kzs6HT6ZCWlobCwkL4+voiISFBLMW8vb2l jkn0g7366qt4/fXX0d3dLW47evQo7rvvPglTEQGXL19GZmYmNBoNDhw4AJlMhnvvvRdKpRLLly9H cHCw1BGJaAgxmUy4dOmSWJbp9Xrk5+ejsLAQZrMZdnZ2GDVqFORyORQKBaKjoyGXyzFx4kQEBQVJ HZ+I/qPnZ9lgMIg/zwaDAWfOnEFlZSUAwNPTE+PGjYNCoUBsbKw4kjQwMFDi9PRDsSAjIiIiIhog VVVVOHDgALRaLfbv34+WlhYoFAoIgoDExESui0PD0oQJE3D+/Hnxtr29PR566CH84x//kDAVUW/1 9fXitLaZmZkwGo2YNWsWBEHA0qVLMX78eKkjEtEQ1dHRgcLCQhQWFuL8+fM4d+6ceNtoNAIA/P39 xVFmY8eOxdixY8WPvby8JD4CouGnpwQrKipCcXExiouLUVRUhAsXLqCoqEh8Y9eoUaMQGRmJqKgo TJgwQfw4JCRE4iOggcKCjIiIiIion5jNZhQUFIhTJ548eRLOzs6YPXs2lEolli5divDwcKljEg2Y oqKiaxYLTk5OqKqq4nR2NCi1t7dDp9NBrVZDo9GgsbERCoUCKpUKgiAgNjZW6ohENAxYrVaUlpaK xdn58+fFE/WXLl2CyWQCAPj5+fUqzMaOHQu5XI6IiAiEhITA1tZW4iMhGpyam5tRWlqKkpKSXiVY cXExSkpKxBLM29tb/NkaP358ryKM6zaPPCzIlG1cdwAAIABJREFUiIiIiIh+gLq6Onz66adiKdbQ 0AC5XI7ExEQolUosWLCAC7fTiPHmm2/i5ZdfFk/y9bC1tcVf//pXrF69WqJkRDfHbDYjLy8ParUa H3/8Ma5cuYIxY8ZAEASoVCrMnj0bMplM6phENMx0d3eLJ/V7Tuj3XBsMBnR2dgL4dlR2WFgYIiIi EBERgdGjR2P06NHi7bCwMK57RsNWXV0dSktLxUtJSQlKSkrE2z3rggFAUFBQr6L56sLZ19dXwqOg wYYFGRERERHRLdLr9dBqtdDpdDhy5AisVitmzpwpTp3I0QY0Uk2fPh0nTpzAd//MtLGxQWxsLI4f Py5RMqJbZ7FYcOrUKWg0GuzcuROFhYXw9/dHcnIyVCoVkpKSeCKaiO6IhoYGGAwG8XLlyhVUVFTA YDDgwoULaGlpEff19vZGcHAwQkJCxGu5XN5nG9Fg0vM93vO9ffX3+JUrV1BWVobm5mZxf29vb8jl 8l7f2z23x48fz1kL6KaxICMiIiIi+h5GoxG5ubnQaDTYvXs3ysrKxJOkgiBgwYIF8PT0lDomkaSq qqoQHBzcpxy7ml6vh0KhuIOpiPpPz5sjNBoNcnNz4enpifnz50OpVGLJkiVwd3eXOiIRjVBVVVUo LS3F5cuXUVZWhrKyMlRUVODSpUuoqKhAWVkZOjo6xP3d3d0RGhoKf39/BAcHIzAwEAEBAQgJCUFA QAACAwMRHByMgICAEflGAJPJxHWC+0F9fT2qqqpQXV2NK1euoLq6GlVVVaioqEB1dTUqKytRWVmJ qqoqmM1m8X6BgYEICQlBaGgowsLCEBISgvDwcISGhoqjJTlDB/UXFmRERERERNdgMBig0+mg0WiQ lZWF7u5uxMTEiFMnxsXFwcbGRuqYRIPGe++9h7Vr1/Y6wXE1e3t7rFu3Dm+++eYdTkbU/0pLS5GW lgatVosjR47Azs4OiYmJEAQBKSkpCAwMlDoiEVEvtbW1YmnWMzqnuroaFRUVYolRUVGB1tbWXvfz 8fGBv78//Pz84OvrC19fX/j5+cHf31/8uGd7z+2h/jtyRkYGkpKSbruEKS4uxtixY/s5lbSMRiPq 6upQW1uLmpoa8eO6ujrxUlNTg9raWnGfnqlBgW+n2w4ICBCLWH9/fwQFBSEoKKhPGTYSS1mSDgsy IiIiIiJ8+07Rzz//XBwdcPbsWbi6umLu3LkQBAFKpZLT0RDdQGJiIo4cOXLdggz4djqcqqoq2Nvb 38FkRAOrrq4Oe/fuhVqtRlZWFkwmE2bOnAmVSoUHH3wQYWFhUkckIrppRqNRHNlTU1ODK1euiEXI 1dc9Jcl3CzUA8PT0hJeX13Uv3t7e8PLygqenJ9zc3ODl5QUXFxe4uLjA09MT7u7uko7gKi4uxiuv vIJ//etft1z2bd++HePGjcPs2bMHKN2ta2lpgdFoRFtbGxoaGmA0GmE0GtHY2CheGhoaet3+7rau rq5ej2lnZ9erFO35OCAgQLwODAxEUFCQWIwN9eKUhicWZEREREQ0YtXU1CAzMxNarRYHDx5EU1MT 5HI5lEolBEHAfffdx3cwEt2ExsZG+Pv7w2QyXXcfGxsbWK1W7NmzB6mpqXcwHdGdYzQacejQIajV aqSnp6O5uRkKhQIqlQrLly/nFKNENOx0dnb2GU303aLlepe2trbrPq6DgwNcXV3h7e0tlmceHh5w dHSEi4sLnJ2d4eTkBBcXFzg6OsLV1RUODg5iuebh4QFbW1vY2tr2Wo/Ky8tLLGp67gNAfNwey5cv x4wZM/D8888D+HYkvJub2w2/Fmq1Gu+99x4+/vjja37eYrGgqalJvN3c3Cy+schoNIojrrq6usSv TWtrK7q7u9HS0gKTySTep7GxEVarFQ0NDbBarWhsbER3dzdaW1vR2NgoFmJXr9v1XTKZrE9peb0y 08vLSyzB/P394eXldcOvBdFQwYKMiIiIiEYMi8WCU6dOiVMn5ubmwsnJCXFxcUhMTERqaioiIyOl jkk05Gg0GnF6RW9vbwAQT8xMmzYNLi4u4oml2bNn48c//rHEiYkGXkdHB7Kzs6HRaLBr1y5UVlaK b8JQqVScqpeIRryeQqepqQltbW1iodPS0iLe7inS2tra0NraKhZJbW1t6Orq6lMgNTU1wWKxiAXS UPfdAtDNzQ329vZiAejp6SkWXfb29nB3d4eHhwdcXV3h6uoqjtLrud1TOLq6unLtTCKwICMiIiKi Ya61tRWHDx8Wp06sqKhAREQEkpKSkJiYiOTkZP5xSDQAfvOb32Dv3r0oKCiQOgqR5CwWC3Jzc6HV arF792588803CA8Px8KFC6FUKpGcnMypR4mIBsDVo7F6Rlr1uN4ILuDb1+1HHnkETU1NePvttxEe Ho6uri4cP34cb775Jv7973+L00B+/fXXeP311zFmzBhs2bIFMpnsunmuHsHWU3YBvUewfXfUGxEN HBZkRERERDTsGAwGaDQaaLVaHD16FBaLBVOmTBGnTpw6dSrftU80wH7/+99jx44dOHfunNRRiAYd vV4PtVoNrVaL/Px8+Pj44IEHHoAgCFi4cOH3TuNFREQD7/XXX8fLL78MX19f5OfnIyIiAjt37sTD Dz8Mi8UCAMjLy8O8efPQ3t6O/fv3IykpSeLURHQrWJARERER0ZDX3t6OnJwcaDQapKeno7S0FL6+ vkhISBBLsZ5p34jozti0aRPee+89XLx4UeooRIPaxYsXkZGRAbVajby8PDg6OmLevHlQqVRYvHgx 13khIpJIbW0tQkJC0N3djfHjx+P48eNIS0vDT3/6UxiNRhQUFOC+++5DS0sLJk2ahNOnT/NNeERD zPXHexIRERERDWIlJSXYtm0bli9fjoCAAMyfPx86nQ4rV65EVlYWKisrsWvXLqxatYrlGJEEnJyc ek1VRETXNmbMGKxbtw7Z2dmorKzEe++9BwBYvXo1/Pz8EB8fj82bN6O8vFzipEREI4ufnx9UKhVk MhlKSkqwYsUKGI1GODo64uuvv8acOXPQ2toKANi4cSPLMaIhiCPIiIiIiGhIMJvNKCgoEKdOPHny JJydnTF79mwolUo8+OCDCAsLkzomEf3H1q1b8dJLL6G+vl7qKERDUkNDA3Q6HTQaDdLS0tDW1oaY mBgolUqsXLkSUVFRUkckIhr2cnNzERcXB+DbtcGCg4PR0NAAJycnNDU1wWKxIDIyEnq9ngUZ0RDE goyIiIiIBq3a2locPnxYLMUaGhogl8uRmJgIpVKJBQsWwNHRUeqYRHQNH374IZ555hkYjUapoxAN eR0dHcjKyoJWq0V6ejqqqqqgUCggCAKUSiXi4uJ4YpaIaIBMnDgR586dE9cdAwB7e3t0d3fDxsYG O3fuxPLlyyVMSES3iwUZEREREQ0qer0eWq0WOp0OR44cAQDMmDEDgiBAEAQoFAppAxLRTdm5cyce eeQRmM1mqaMQDStmsxl5eXlQq9XYvXs3ysrKEBERgZSUFAiCgDlz5sDOzk7qmEREw8a2bdvwzDPP iL/T2NjYwGq1QiaTQS6Xo7CwEDIZVzIiGopYkBERERGRpIxGIw4dOgStVot9+/ahrKwMAQEBSEpK giAISEpKgoeHh9QxiegWpaWlYcmSJejq6oK9vb3UcYiGLb1eD7VaDbVajbNnz8LX1xeLFi2CSqXi SGsion7Q1taGwMBAtLW19douk8nw4Ycf4kc/+pFEyYjoh2JBRkRERER3nMFgENdVycrKQnd3N2Ji YsSpEzlVFNHQl5mZiUWLFqG5uRnu7u5SxyEaEQwGAzQaDdRqNXJzc+Hs7IyEhASoVCqkpKTA09NT 6ohEREPSunXr8Ne//hXd3d0Avh1FFhYWBoPBwFG7REMYCzIiIiIiGnAmkwmff/45tFotMjIycO7c Ofj4+GDevHlITEyEIAgIDg6WOiYR9aPDhw8jISEB1dXV8Pf3lzoO0Yhz+fJlZGZmQqPR4MCBA5DJ ZLj33nuhVCqxfPly/r9LRHQLzp8/D4VCgZ5T6TKZDNu2bcOTTz4pcTIi+iFYkBERERHRgKiursb+ /fuh1Wpx4MABNDc3Qy6XQ6lUQhAE3H///Zx2jWgYy83NRVxcHC5fvoywsDCp4xCNaPX19dBqtdBq tcjMzITRaMSsWbMgCAKWLFmCu+66S+qIRESD3ty5c5GdnQ2TyYSgoCCUlpbCwcFB6lhE9AOwICMi IiKifmGxWHDq1CloNBpotVqcPHkSTk5OiIuLg1KpxJIlSzBq1CipYxLRHXLy5EnExsbim2++wbhx 46SOQ0T/0d7eDp1OB7VaDY1Gg8bGRigUCqhUKgiCgNjYWKkjEhENSp988glUKhVkMhn+/Oc/45ln npE6EhH9QCzIiIiIiOi21dfX49ChQ9DpdMjIyEBlZSVGjx6NBQsWIDExEQsXLoSbm5vUMYlIAmfP nkV0dDTOnDmD6OhoqeMQ0TWYzWbk5eVBrVbj448/xpUrVzB69GgsXrwYKpUKs2fPhkwmkzomEdGg YDKZEBISAovFgrKyMjg5OUkdiYh+IBZkRERERHRLDAaDOErs6NGjsFgsmDJlijh1It95TkQAUFxc jHHjxuHEiRN8XSAaAq4eCf7RRx/h/Pnz8PPzw8KFC6FSqZCUlMSpxIhoxIuKioK7uzuOHz8udRQi 6gcsyIiIiIjohtrb25GTkwONRoO0tDRcunQJfn5+mDt3LpRKJRYvXgwvLy+pYxLRIFNeXo6wsDBk Z2cjLi5O6jhEdIv0ej20Wi00Gg1yc3Ph6emJ+fPni9Mmu7u7Sx2RiOiOe//99+Hn54clS5ZIHYWI +gELMiIiIiLq4+LFi8jKyoJOp0NmZiZaW1uhUCggCAKUSiWnXCKi71VbWwt/f38cOnQICQkJUsch oh+gtLQUaWlp0Gq1OHLkCOzs7JCYmAhBEJCSkoLAwECpIxIRERHdMhZkRERERCSuQaLVaqHT6ZCf nw9XV1fMnTsXgiDggQceQGhoqNQxiWgIaW1thbu7O/bu3YtFixZJHYeI+kldXR327t0LtVqNrKws mEwmzJw5EyqVCkuXLkV4eLjUEYmIiIhuCgsyIiIiohGqtrYWhw8fhkajgUajQWNjI+RyORITE6FU KrnWCBH9ICaTCfb29vjkk0+wdOlSqeMQ0QAwGo04dOgQ1Go1MjIy0NTUBIVCAZVKheXLl0OhUEgd kYiIiOi6WJARERERjSBXryeSl5cHmUyGGTNmQBAELF68GBMmTJA6IhENI3Z2dvjnP/+Jhx56SOoo RDTAOjs78dlnn0Gj0UCtVqOiogJyuRxKpRIqlQpxcXGwsbGROiYRERGRiAUZERER0TDW1taGTz/9 FFqtFnv37kV5eTkCAgKQlJQEQRCQlJQEDw8PqWMS0TDl6uqKLVu24PHHH5c6ChHdQRaLBbm5udBq tdizZw8uXLgg/v6hUqmQnJwMe3t7qWMSERHRCMeCjIiIiGiYMRgM0Ol00Gg0OHjwIEwmE2JiYqBU KiEIAqZOncp3cBPRHeHr64s//OEPePrpp6WOQkQS0uv1UKvV0Gq1yM/Ph7e3tzil89KlS+Hm5iZ1 RCIiIhqBWJARERERDXEdHR3Izs6GTqdDeno6zp8/Dx8fH8ybNw+JiYlYvHgxgoKCpI5JRCNQaGgo fvWrX+HZZ5+VOgoRDRIXL15ERkYG1Go18vLy4OjoiHnz5kEQBKSmpiIgIEDqiERERDRCsCAjIiIi GoKqqqpw4MABaLVaHDhwAM3NzeI6H4Ig4P777+fURUQkOblcjjVr1uDFF1+UOgoRDUK1tbXYt28f 1Go1Dh48CLPZjJkzZ0KlUmHZsmUIDQ2VOiIRUS/r16/Hgw8+iJiYGKmjEFE/YEFGRERENASYzWYU FBRAo9FAq9Xi5MmTcHJyQlxcnDg9UXh4uNQxiYh6USgUWLFiBV599VWpoxDRINfY2IisrCxoNBqk paWhpaUFCoUCKpUKK1euRFRUlNQRiYggk8mwY8cOrFixQuooRNQPZFIHICIiIqJrq6+vh1qtxlNP PYWwsDBMmzYN27dvR2xsLNLT01FfX4+srCysW7eO5RgRDUpOTk7o7OyUOgYRDQFeXl5QqVTYvn07 qqurkZGRgfj4eLz33nuYMGECxo4di3Xr1iE7Oxt8rzcRSaGzsxNWqxVOTk5wc3ODjY3NTV1OnDgx YJneeust8XnCwsIG7HmIhiuOICMiIiIaRPR6PbRaLXQ6HY4ePQqLxYKZM2dCEAQkJiYiNjZW6ohE RDdt1qxZmDVrFt5++22poxDREGU2m5GXlwe1Wo3du3ejrKwMo0aNQnJyMpRKJZKTkzmtNBHdEVar FRcvXkRQUBBcXFxQUFCAmJgYpKSkIC0t7Zr38fLygk6nw7Rp0wY025QpU1BbW4uysrIBfR4AaG1t RUxMDCIjI6HVagf8+YgGkp3UAYiIiIhGsvb2duTk5ECj0WDPnj24fPky/P39MWfOHPzf//0fFi9e DC8vL6ljEhHdFo4gI6IfytbWFvHx8YiPj8fmzZuh1+uhVquhVquxbds2+Pr6YtGiRRAEAYsWLYKr q6vUkYlomLKxsYFcLpc6huSsVissFgssFovUUYh+MBZkRERERHfYxYsXxTU2dDodOjo6oFAo8PDD D0OpVGL27NmQyTgTNhENfY6Ojujo6JA6BhENI9HR0YiOjsaGDRtgMBig0WigVquxYsUKODs7IyEh ASqVCikpKfD09JQ6LhGNcI2NjVJH6Hfu7u4oLi6WOgZRv+CZFyIiIqIBZjabkZ2djRdffBHTpk2D XC7Hc889BwDYvHkzysvLodfr8cYbbyA+Pp7lGBENG05OTizIiGjAyOVycV2y0tJSvPPOOwCAn/zk J/Dz8xNHnVVUVEiclIhGmvj4eHz44YdSxyCi78GzL0REREQDoKamBmq1GqtWrYKvry/uvfdeqNVq xMXFISsrC/X19dBoNFizZg1CQkKkjktENCA4xSIR3Snh4eFYs2YNNBoNKisr8cEHHyAkJATr169H WFgYpk2bhg0bNuDChQtSRyWiESo+Ph42Njbi5dFHHwUAJCYm9tp+9aizuro6PPfccxg7diwcHR0R FhaGxMREfPjhh2hvb7/uc7322mvi48XHx4vb9+/fL2738/PrdZ/Ozk688soriIqKgouLC3x8fCAI AjIyMmA2mwEAaWlpvbJ2dHSgsbGx1zYbGxu89tprAACTydRr+7Jly8Tnq6mpwS9+8QuMHj0aDg4O 8Pf3x9KlS1FQUPDDv9hEN4kFGREREVE/sFgsyM/Px6ZNmxAfH4+goCCsWrUKFRUVeOmll3Du3DkU Fxdj8+bNSExMhIODg9SRiYgGHKdYJCIp+Pj4YNWqVdi1axeqq6uRlpYGhUKBzZs3IzIyEtHR0Xjx xReRnZ0tdVQiGgbS09P7FEQ5OTl99svOzkZBQQFcXV0xefJkbN26FQCwd+9ezJgxAzt27IDVahXX oK6srMQ999yDHTt2YPPmzaitrUV+fj7mzJmDxx9/XLz/taxfvx5Wq7XPuozJycmwWq2IjY3tc5+1 a9fiz3/+M959913U1dXh3LlziIqKQkpKCj777DMAQGpqKqxWK1JSUsT7eXl5wWq1Ijk5GTKZDEVF RVi/fj0AwM7ODlarFbNmzcK///1vfPzxxwCAiooK3HPPPdi1axf+8pe/oL6+HkeOHEF9fT1mzZqF vLy8W/knILptLMiIiIiIblNbWxs0Gg2eeuophIeHY9q0aXjnnXcgl8uxc+dOVFdXIysrC7/+9a8R FRUldVwiojuOI8iISGrOzs4QBAHbt29HbW0tPvvsMyQmJuJf//oX7r33XowZMwbr1q2DTqeDyWSS Oi4RDUEpKSmwWq29LnFxcdfcd/Lkyfj73/+O06dPY9WqVbBarXjqqacwb948rFy5ste+L730Ei5e vIjNmzdDqVTC3d0dgYGBWL9+PZKTk/v9OA4dOoTo6GjMnz8fzs7OCAwMxJtvvom77rrrpu7/wgsv wGKx4O233+61PScnB+Xl5VCpVOK2l156CaWlpXj77bexaNEiuLm5ITo6Gjt37oTVasXPf/7zfj02 outhQUZERER0CwwGAzZv3oz58+fDx8cHS5YsQX5+PlavXo0TJ06goqIC27dvh0qlgru7u9RxiYgk xRFkRDSY2NraiuuSXbp0CSdOnMCPf/xjHDx4EPPnz0dwcDBWrVoFjUaDrq4uqeMS0TClUqnwm9/8 Brt370Z8fDzq6uqwcePGPvvt2bMHALBw4cI+n8vMzMSzzz7br7mSk5ORm5uLNWvW4PPPPxenVSws LMScOXO+9/7z5s1DTEwMPvzwQ9TV1Ynb33zzTTz77LOws7MTt6WlpUEmk0GpVPZ6jKCgIERHRyM/ Px9lZWX9c2BEN8CCjIiIiOgGOjo6oNPp8OKLL2LChAkYO3YsNm7cCG9vb7z77rsoLy/HiRMnsGHD BsTGxsLGxkbqyEREg4aTkxMLMiIalGQyGWJjY7FhwwZxKuz169fDYDAgJSVFXHtn+/btaG5uljou EQ0Chw4dwtixY2+49leP7OxsPPbYY9f9/MaNGzFjxgzk5uZCpVJBJut9mr6zsxNNTU1wcnK6Y2+8 /N///V9s374dBoMB8+bNg4eHB5KTk8Wi7mY8//zzMBqN+Mtf/gIAuHDhAo4dO4af/OQn4j49x2ax WODp6dlnesqTJ08CAL755pv+PUCia2BBRkRERPQdVVVV2L59O5YvX46AgADMnz8fGo0GKSkpyMrK QkVFBXbt2oU1a9YgMDBQ6rhERIMWp1gkoqFCLpdj3bp1yM7ORklJiThF2JNPPonAwEDMnz8fmzdv RmVlpcRJiUgqjY2NMBgM/bKe9JEjR9DU1IRJkybhmWeewenTp3t93tHREZ6enujo6EBLS8ttP49M JrvmiNjGxsY+22xsbPCjH/0IOp0OjY2NSEtLg9VqxdKlS/tMm3g9K1asQHh4OLZs2YLOzk786U9/ wurVq3uVfI6OjvDy8oKdnR26u7v7TE/Zc5k7d+5tHzfRzWJBRkRERCOe2WxGfn4+NmzYgGnTpiE4 OBg//elP0dDQgI0bN+LSpUvQ6/V44403kJiYCHt7e6kjExENCZxikYiGolGjRmHNmjXQaDSorKzE 1q1b4e3tjd/85jcICwtDfHw8Nm3ahKKiIqmjEtEd5ObmhnvuuQe2trY3fZ9p06Zh586dvbZdvHgR Tz75JD755BNkZGTA2dkZKSkpqKmp6bXfkiVLAAD79u3r87gxMTH45S9/+b3PHxwcjPLy8l7bKisr cenSpT77enl54fz58wAAe3t7zJ8/H2lpabCxscHevXu/97kAwM7ODuvWrUN1dTX+9Kc/YefOnfjF L37RZ7+lS5fCZDIhJyenz+c2bdqEUaNGcV1IuiNYkBEREdGIVFdXB7VajVWrVsHf3x/Tpk3DP//5 T8TGxiI9PR319fXIysrCunXrEB4eLnVcIqIhiQUZEQ11vr6+WLVqFXbt2oXq6mrs2bMHcrkcr7/+ OsaPH4/o6Ghs2LAB+fn5UkclogGWlJSEL7/88gc9RmtrK1JTU/E///M/UCgUGD16ND7++GNcuXIF y5YtQ3d3t7jv66+/jjFjxuCXv/wl9u7di5aWFpSVleGZZ55BRUXFTRVkCxYswJUrV7Blyxa0trai uLgY69atQ0BAwDX3f/rpp/HVV1+hs7MT1dXV+OMf/wir1YqEhISbPsY1a9bA09MT69evR2pqKkJD Q/vs8/rrr2Ps2LF44oknkJmZiaamJtTX12Pr1q34/e9/j7feeqvXmmVEA4UFGREREY0Yer0emzZt wvz58xEUFISHHnoIBoMBv/71r3HixAkUFxdj69atEAQBjo6OUsclIhryOMUiEQ0nLi4u4rpktbW1 +Oyzz5CYmIht27Zh2rRpGDt2rDhNo9VqlTouEQ0gNzc3xMTEAADS09P7rKPVc7m6PF+7di3c3d3x 1VdfISUlBWfOnEFtbS3mzJmD7u5uHDt2DA4ODnjttdcAAEFBQTh+/DhWrFiBn//85/D19cX06dPR 0NCAzz77DKNGjcJbb70FGxsbnD59GuXl5bCxscH69evF53zttdfwk5/8BP/93/+NgIAAPPbYY/jV r36FoKAg1NXVwcbGBi+++CIA4OjRo4iKisLKlSvh4+ODCRMmYP/+/Xj//ffx8ssvA4A4oiw9PR0A 4OzsjEcffbTX18bd3R1r1qyB1WrF888/f82vX0BAAL788kukpqZi7dq18Pf3R1RUFHbv3o309HQs X768n/6liG7Mxsr/sYmIiGiYMhqNyM3NhUajwe7du1FWVgZ/f38kJydDEAQsWLAAnp6eUsckIhq2 3n//fbzwwgtoamqSOgoR0YCxWCw4deoUNBoNduzYgQsXLoi/c6pUKiQlJfXLmkVERETUv1iQERER 0bBiMBig0+mg0WiQlZWF7u5uxMTEIDExEUqlEnFxcbCxsZE6JhHRiPDPf/4Tq1ev5jSLRDSi6PV6 aLVaaDQa5OTkwNvbW/xddOnSpXBzc5M6IhEREYEFGREREQ1xJpMJn3/+ObRaLXQ6HfLz8+Hq6oq5 c+dCEAQolUqEhIRIHZOIaERSq9VYvnw5zGYzZDLO8E9EI09JSQnS09Oh1Wpx5MgR2NvbY968eRAE AampqdddB4iIiIgGHgsyIiIiGnJqamqQmZkJrVaLgwcPoqmpCXK5HEqlEoIg4L777uM0NkREg0BG RgZSUlLQ3t4OJycnqeMQEUmqtrYW+/btg1qtxsGDB2E2mzFz5kyoVCosW7YMoaGhUkckIiIaUViQ ERER0aDXs65Dz9SJubm5cHJyQlxcHBITE5GamorIyEipYxIR0XccPHgQSUlJaGhogJeXl9RxiIgG jba2Nnz66adQq9VIT09Hc3MzFAoFVCqAGqdqAAAgAElEQVQVVqxYgQkTJkgdkYiIaNhjQUZERESD Us9Jg571GyoqKhAREYGkpCQkJiYiOTkZ7u7uUsckIqIbOHr0KObMmYPKykoEBgZKHYeIaFDq6OhA dnY2NBoNPvroI1RVVYmzI6hUKq6hSzRIGAwGmEwm3HXXXVJHIaJ+woKMiIiIBg2DwQCNRgOtVotj x47BbDZjypQp4tSJU6dO5ckBIqIh5IsvvsDMmTNRUlKCiIgIqeMQEQ16ZrMZeXl50Gq1+OSTT1BU VIRRo0YhOTkZSqUSycnJsLe3lzom0Yj0xBNPoLKyEvv27ZM6ChH1EzupAxAREdHI1d7ejpycHGg0 GqSnp6O0tBS+vr5ISEjA+++/D0EQ4O3tLXVMIiK6TT3rjnV0dEichIhoaLC1tUV8fDzi4+Pxxhtv QK/XQ61WQ6vVYtu2bfD19cWiRYsgCAIWLVoEV1dXqSMTjRgdHR1wdHSUOgYR9SOOICMiIqI7qqSk BAcPHoROp0NmZiZaW1uhUCggCAISExMxZ84c2NnxPTxERMPB+fPnMWHCBJw+fRp333231HGIiIa0 ntkW1Go1cnNz4ezsjISEBKhUKqSkpMDT01PqiETD2t69e2EymZCSkiJ1FCLqJyzIiIiIaECZzWYU FBSIUyeePHkSzs7OmD17NpRKJR588EGEhYVJHZOIiAZASUkJxowZgy+++ALTp0+XOg4R0bBRU1OD zMxMqNVqHDhwABaLBTNnzoRKpYJKpUJISIjUEYmIiAY9FmRERETU72pra3H48GGxFGtoaIBcLkdi YiKUSiUWLFjAqSmIiEaAyspKBAcH49ixY7j33nuljkNENCw1NDRAp9NBo9Fgz549MBqNiImJgVKp xEMPPYTIyEipIxIREQ1KLMiIiIioX+j1emi1Wuh0Ohw5cgQAMGPGDAiCAEEQoFAopA1IRER3XEND A3x8fHDw4EHMnz9f6jhERMNee3s7dDodtFot0tLSUF1dLU5nrlQqERcXBxsbG6ljEhERDQosyIiI iOi2GI1GHDp0CFqtFvv27UNZWRkCAgKQlJQEQRCQlJQEDw8PqWMSEZGE2tvb4eLigoyMDAiCIHUc IqIRxWw2Iy8vD2q1Gp988gnKy8sxevRoLF68GIIgcO1fIiIa8ViQERER0U0zGAzi9C1ZWVno7u5G TEyMOHUi35FKRERXs1gssLW1hVqtxrJly6SOQ0Q0oun1eqjVauzatQvnzp2Dn58fFi5cCJVKxSnQ iYhoRGJBRkRERNdlMpnw+eefQ6vVQqPR4OzZs/Dx8cG8efOQmJgIQRAQHBwsdUwiIhrEHB0d8cEH H+DRRx+VOgoREf2HwWCARqOBWq1Gbm4unJ2dkZCQAJVKhdTUVM4EQUREIwILMiIiIuqluroa+/fv h1arxYEDB9Dc3Ay5XA6lUglBEHD//ffD3t5e6phERDREeHh44J133sGTTz4pdRQiIrqGS5cuYf/+ /dBoNDhw4ABsbW0RHx8PpVKJFStWICgoSOqIREREA4IFGRER0QhnsVhw6tQpcerE3NxcODk5IS4u DkqlEkuWLMGoUaOkjklERENUQEAAXn31VfzsZz+TOgoREX2Puro67N27V1xnuKOjAzNnzoQgCFi6 dCnGjx8vdUQiyaxfvx5KpRIzZ86UOgoR9RMWZERERCNQfX09Dh06BJ1Oh4yMDFRWVmL06NFYsGAB EhMTsXDhQri5uUkdk4iIhoHw8HA8++yzeP7556WOQkREt8BoNOLQoUNQq9XIyMhAU1MTFAoFVCoV BEFAbGys1BGJ7iiOiicafuykDkBERER3Rs86A1qtFkePHoXFYsGUKVPw1FNP8Q9cIiIaME5OTujs 7JQ6BhER3SIXFxcIggBBEGA2m5GXlwe1Wo1t27bhd7/7HcaMGQNBEKBSqRAXFwcbGxupIxMNqI6O Djg5OUkdg4j6EUeQERERDVPt7e3IycmBRqNBWloaLl26BD8/P8ydOxdKpRKLFy+Gl5eX1DGJiGiY mzRpEpYuXYrf/e53UkchIqJ+0DNFu0ajwc6dO1FYWAh/f38kJydDpVIhKSkJDg4OUsck6ndlZWXw 8vLibCtEwwgLMiIiomGkpKQEBw8ehE6nQ2ZmJlpbW6FQKCAIApRKJWbPng2ZTCZ1TCIiGkGmTZuG efPmYdOmTVJHISKiAaDX66HVasX1jL28vJCYmCiuZ+zu7i51RCIiomtiQUZERDSE9Ux1otVqodPp kJ+fDxcXFyQkJEAQBDzwwAMIDQ2VOiYREY1g8fHxiI2NxebNm6WOQkREA6ykpATp6enQarU4cuQI 7O3tMW/ePAiCgNTUVAQEBEgdkYiISMSCjIiIaIipra3F4cOHodFooNFo0NjYCLlcLr5Lc8GCBXB0 dJQ6JhEREYD/x96dxzV1pf8D/wQSCGvYd2RRQHGXugGOC6hYwR27abWtttaZ2tpqbafftjPTdqaL XWxra3W+9qvdVDrVCmqrVK1FXBE3UEQWlSUsQiBsgYTn94e/3ElM2BQJwvN+ve4LuDn35rkJuffk POfcA0RFRSEoKAgbNmwwdSiMMca6UHl5Ofbu3YuEhATs378fGo0GY8aMQXx8PObNm8cd+RhjjJkc J8gYY4yx+4DubUuOHTsGMzMzjB49GnFxcZgxYwYGDBhg6hAZY4wxo6ZPnw5XV1f83//9n6lDYYwx ZiK1tbU4ePAgEhIS8PPPP6O6uhqhoaGIj4/HQw89xN9nGGOMmQQnyBhjjLFuSPsFMikpCXv27EFh YSHc3NwwdepUxMXFYerUqbC3tzd1mIwxxlib5s6dCwsLC/zwww+mDoUxxlg30NDQgJSUFCQmJmLH jh2Qy+UIDAxEbGws4uPjERERAZFIZOowGWOM9QKcIGOMMca6idzcXCQnJyMxMRH79++HWq3G8OHD ERsbi7i4OIwYMYK/KDLGGLvvPProo6ivr8fOnTtNHQpjjLFuRndO5f/85z+4evUq+vTpg5iYGMTG xiImJgYSicTUYTLGGOuhOEHGGGOMmYi252RycjJ2796NS5cuwcnJCVFRUYiOjsaMGTPg4eFh6jAZ Y4yxu/Lkk0+iuLgY+/btM3UojDHGurmMjAwkJCQgKSkJaWlpcHJywvTp0xEXF4cHH3wQNjY2pg6R McZYD8IJMsYYY6wLlZSU4Ndff0VSUhJ+/fVXVFdXC7cTiYuLw/jx47mHJGOMsR7l2WefRVZWFg4e PGjqUBhjjN1H8vLysHv3biQkJCA1NRVSqRRRUVGIj4/HzJkzIZPJTB0i60WOHj2KRx99FGlpaXBx cTF1OIyxTsIJMsbYfYeIoFAo2l3ezMyMK87MZDQaDc6ePYvExEQkJSXhzJkzkEqliIiIQGxsLGbP no0+ffqYOkzGGGOs0zQ3N6Oqqkr4+7XXXsPp06fx66+/Gi1va2vLnUMYY4y1qqysDPv27UNCQgL2 798PjUaDMWPGID4+HvHx8fDy8jJ1iKyH+/XXXxETEwOFQsFtTIz1IJwgY6wHUqvVUCqV0Gg0qK6u BgDU19ejoaEBAFBdXQ2NRtPi41VVVWhubhb2AwB1dXVQqVQAAIVCASJCU1MTampqDB7X3ZcxjY2N qK2tbfFx3bi6ioODQ6tzO9nb28Pc3LzFx21sbGBhYQEAsLa2hqWlJQBAJpPBzMwMYrEYdnZ2Bo9r n1cikcDW1tZgX46OjgAACwsL4VYSxh5vK37WtSoqKvDbb78Jt06Uy+UICAjA5MmTERsbi8mTJ0Mq lZo6TMYYY91AZWWl3s+GhgbU19cD+G+dS6VSoa6uDsB/63G69TClUgm1Wq1Xh6qtrUVjY6Neskq3 vqb7uzHafbZEG1tX0NanjBGJRHBwcGhxW906mG59S5uUMzc3h729PYD/1rF0O1dZWVkJ12xtvUsq lcLKykovNt26mrbe2Fb9kTHG2J2prKwU5m7euXMn6urqhLmbH3nkEYSEhJg6RNYD7d+/Hw8//DCK i4uFNh3G2P2PE2SMmUhVVRVUKhVqamqgVCqhUqlQXV0tNFZUVlYKjSHV1dVoaGhATU0NampqoFKp UFVVJSSiFAoFVCoVamtrhUaTjrK0tIS1tTUAwM7ODmKxWK9xQLchoK3HdRsajGmrIQNovSEE6FhP Y92GJmN0G5iMub0XtDHaRi0AqKmpQVNTk95IN92GrbYeb6tBqiXahhl7e3tYWlrCzs4ONjY2sLS0 hIODg/AeyWQySKVS2NjYwM7ODpaWlrC3txcSd46OjnplLS0thcYk1rLc3FxhlNjvv/+O5uZmjBkz BnFxcYiOjkZYWJipQ2SMMXaHampq0NDQgOrqatTW1qK+vl74vaGhAVVVVairq0N9fb3wu7aOpvu7 tu5WWVnZZoeilhhL7Giv4bp1rLYSO7rJImN0yxqj22HHmI4kh3TrUbdrq+NUWx2vdF9n3fqWtkOY sUSjbicxbb2tPfVBY3TrZ1KpFLa2trCzs4OVlZXwu1QqhZ2dnd7vtra2kEqlsLe31/vdxsYGVlZW rda1GWOsN6mvr0dycjKSkpKwa9culJaWIjQ0FHFxcYiNjUVERAR3JmWd4o033sDbb7+NixcvIjQ0 1NThMMY6CSfIGOug6upqKBQKVFVVCcvtf1dWVhqs1zaMtJWs0XJ0dBSSVu1JeGiTGLa2trC0tBQS V8ZGIGkbVtqTqGKmo9sQo/t/c/sIQG2iTVtGN/naVkJVNznbFt3/LWtra8hkMjg4OEAmkwmLg4OD sM7YYz1pQuX6+nocPXpU6LV448YNuLq6YsKECYiNjcWMGTP488UYY92AQqEQFm39rK2luroaNTU1 qK+vFxIlLdF2GLK2toZUKoWDg4OQnHJ0dNT7XVt309bjtNdT7T5uH4mk7ZSkOwqKmZ62Q5tuZyfd RJx2dJ22flZXVyfUxbS/NzQ0CJ3btB3hlEolGhoaoFQqhcRca2xsbCCVSiGTyWBjYyPUw9qzODo6 8h0IGGM9jkajwbFjx5CQkID//Oc/KCwshJ+fH2bOnIm4uDhMmDABYrHY1GGy+1BVVRV8fHxQU1OD 5cuXY/369aYOiTHWSThBxnqdiooKlJeXt5rMMpb40jaYGPvIWFhY6CUCtF84dddpE1naRhIHBwdY Wlq2OIqHsa7W0uhFlUoFpVKJ2tpaqFQqoTd8a5+TqqoqoyMZxWKx3udEN3l2ezJN93dHR0e4urqa vHEwLy8PBw4cQGJiIpKTk9HQ0KDXOzE8PLzVkY+MMcY6rrGxEeXl5SgvL29Xckt3aWlkkjaZoFtv 0106MpqntVFUjN0N7Ui220cw6o5a1HZ+qq2tbfWz0FKiV7eDU2uLbjkXFxe4uLi0OsKQMca6g4yM DCQkJGDHjh24dOkSXFxcMG3aNMTHx2PKlCnc9sLa7Z133sHf/vY3qNVqWFlZQS6X82huxnoITpCx +1p9fT0qKyv1luLiYhQVFRldV15ebrQnprZXr3bR7enb2qIt5+npyb0vGbuN9vOpHdl2+2fV2KJb tqSkBM3NzQb7dXR0hKenp95n0cvLy2Cdo6MjfHx87mryXG0PxKSkJCQnJyMtLQ02NjaYOHGikBTj yaAZY6xjGhoaUFFR0WLd7fa/W7oetKeuZmxxdnbmBjHWK7W3Pmas/mbsc6j7GTRWF7t9HX9nYoyZ kvaW+AkJCUhNTYWVlRUmTZqE+Ph4zJo1i5MdrEW1tbXw8fERRo2bm5vj888/x7Jly0wcGWOsM3CC jHUbarUaZWVluHnzJsrLy1FWVqb3d3l5OW7evImSkhJh3e23KrSwsICLiwucnZ3h4uICNzc3oYej dp2rqytcXV31RrEwxrofjUYjjErTjvzUnge0v5eWlhqsu33kmq2trd75QHsu0D0faNc5OzsDAJKS krB3714cOHAA1dXVGDBgAKZPn44HH3wQkZGR7Z7/jjHGeoO6ujqUlpaipKREOBeXlZUZ/F1aWoqy sjKDeT8tLS2Fc7K7u7veOdrNzU2vPqcdwcIJLsa6VlNTkzAaTfu51tbFtPWx2z/72vnetKysrIQ6 me7nWvez7+rqChcXF3h4eJj8zgGMsZ7r+vXr+OWXX5CYmIhff/0V5ubmiIyMRGxsLB566CF4eHiY OkTWjaxduxavvPKK0NYgEokQFBSEy5cvc8cPxnoATpCxLlFZWYmioiKhR7Cxn9evX4dardbbTtsr sT09Eh0dHeHh4cG3N2Osl9P2djY2mrS9IxNEIhGsra3h6emJ0NBQDBgwAJ6ensJ5x8vLC35+fjA3 NzfRUTLGWNfQrcPl5uYarcfJ5XK9W1DfPrLr9jrb7X9z/Y2xnun2EWttjRY1di7RrXsZ++nv79+j 5rhljHW9iooKJCUlCZ0k6+vrMXbsWMTFxWHOnDkICgoydYjMhOrr6+Hr64ubN28aPPbHH38gMjLS BFExxjoTJ8jYHVOr1SgpKUFhYSHkcrnBT23DSWlpqV7js/b2Gsa+5Hh4eOiN7uDGEsbYvdbU1KTX Ezo/Px8lJSXCaIiCggLhZ21trbCdRCKBm5sbfHx84O7uLvz09vaGh4eH8NPd3Z17lTHGuh2FQoHC wkIUFhaiuLgYBQUFKC4uxo0bN1BcXIzCwkKUlJTojcp1cXGBp6cnfH194eHhAR8fH3h5ecHb21sY AeLq6sqN1YyxO9LQ0CDcRUQul0Mul6OgoABFRUUoKipCYWEhioqKUFJSopdIc3d3h6enp3BO8vLy go+PDzw8PODr6wtPT0+4urqa8MgYY/eL+vp6JCcnIyEhAbt370ZVVRVCQ0MRHx+PuLg4hIWFmTpE 1sU+++wzrFy50uBONRKJBHPmzMG2bdtMFBljrLNwgowZ1dTUhIKCAly7dg3Xrl1Dfn4+bty4oZcA u/2LSWuJL92fPJkzY+x+VVNTo5cwa+mnbiJNLBYbJM58fHzg5+cHf39/+Pv7w9PTkzsEMMY6TUND A/Lz85Gfn4+8vDzk5+ejsLBQqMsVFBTo3fpMKpXC29vbaKOyboOzVCo14VExxtgtTU1NkMvleuc0 bRJNN9mvWx+ztLQUzmXa811AQICw+Pv7w9bW1oRHxRjrbrTzUSckJODHH39EUVERAgICEBcXh/j4 eISHh/N3uB6usbERfn5+QvunSCTSawcVi8UoKCiAu7u7CaNkjN0tTpD1UiqVSkh+6S55eXm4du0a ioqKhN4RUqkUfn5+QkMJJ74YY6x1bSXSbty4gYKCAjQ1NQG4NX+ir68v/Pz8hCUgIED43cfHB2Kx 2MRHxRjrLtRqNW7cuCEkv/Ly8vR+LyoqEso6ODggICAAPj4+8Pb21hsBpq3baedfZIyxnkSpVArJ M90Rszdu3EBRURHy8/NRWloqlHd1dYW/v79e0kz709/fn+c+ZKwXa25uRnp6OhITE7Ft2zZkZWXB 1dUVMTExiI+Px9SpU2FhYWHqMFkn27hxI5599lk0NzfDzMwMtra20Gg0QgcMsViMv//97/jrX/9q 4kgZY3eDE2Q9lEqlQmFhIXJzc/Xmi9D+fe3aNb0EmJeXFwIDA4VFm/gKDAyEv78/94phjLF7oLKy Ujgv336+zsrKQk1NjVDW0dFR7zyte67u378/39KMsR7G2PlBu+jO22ppaQlvb2+D84PuOYIxxphx t39v1l1ycnKgUCiEssbqYtqlT58+3JmJsV4kIyMDSUlJSExMRGpqKhwcHBAdHY3Y2FjMnj0bdnZ2 pg6R3SW1Wo3AwEDcuHED5ubmWLRoEczNzZGbm4uhQ4di3bp10Gg08PT0FMowxu5PnCC7jxUVFSE7 OxtXr14Vlvz8fFy7dg1lZWVCOUdHR2EUgrb3m+4oBe41zBhj3VNxcbHR0b7aW6dpe66JRCJhonp/ f3/069cPQUFB6NevH/r16wcXFxcTHwlj7HYajQbXrl3DlStXhEVbl8vPz4dKpQJwa4SpdlSp7mgG 7U++pQtjjN07lZWVLY7WzcvLQ319PYBbowh8fX0REBCAvn37Ijg4WFgCAwN5ZAljPdi1a9ewa9cu JCUl4fDhwxCLxYiOjkZcXBxmzZoFNzc3U4fI7sCWLVuwePFiAMDDDz+M7777Dk888QRu3ryJ3bt3 Y8aMGdizZw8AYNeuXZg5c6YJo2WM3Q1OkHVzhYWFBkmwq1evIjs7W5g7wsbGRmgE1Sa/dBNh9vb2 Jj4Kxhhj90J5eblB4iwvLw/Z2dnIzc1FY2MjgFsdJbTXCd3kWXBwMHeSYOweKykpweXLl5GdnY0r V64gOzsbWVlZyMnJET6jrq6uCA4ORlBQkN7tvQICAuDl5cUj+RljrJuSy+V68z3m5eXh6tWruHLl CgoLCwHcSp75+fkhODgYISEhwvk+ODgYffr0MfERMMY6U3l5Ofbu3YuEhAQcOHAAarUaY8aMQXx8 PObOnQsfHx9Th8jaQaPRIDg4GLm5uYiNjcVPP/0EiUSChx56CBqNBj/++CPq6uoQERGBs2fPIioq CsnJyaYOmzF2hzhB1g2o1Wpcv34dubm5yMjIQGZmJjIyMnDhwgVUV1cD0L99TmhoKAYOHCjczoFv gcgYY8yYyspK4bqie8ugy5cvC6PPtLcL0r22hIaGon///nybCMY6QPfzpv158eJFyOVyAP+ty91e jxs0aBA8PDxMHD1jjLHOpr194+11sduvDX379sXAgQOF6wPXwxjrGerq6vDbb78hISEBP//8M6qr qxEaGor4+HjMnz8foaGhpg6RtWDbtm145JFHEBUVhT179ghzUM6aNQs2Njb47rvvAAAFBQUICwtD WVkZsrKyEBQUZMqwGWN3iBNkXaihoUGv0eTy5cu4dOkScnNz0dTUBDMzM/Tp0wf9+/fHgAED0L9/ f6GHmaenp6nDZ4wx1kM0Nzfj+vXryM7OFq5FWVlZuHTpEoqLiwHcmp8yJCQEISEh6N+/PwYOHIhB gwYhKCgIEonExEfAmOmUlJTg/PnzOH/+PC5duoSMjAxcunQJVVVVAG6NBhs4cKDwuRkwYABCQkK4 xzBjjDGBtjE1MzNTuJZcvnwZN27cAABYW1sL7QLaOtiQIUPg5+dn4sgZY3eioaEBKSkpSExMxI4d OyCXyxEYGIjY2FjEx8cjIiICIpHI1GHeU3V1dVCpVGhoaBBuT6tdBwA1NTVoamoCAFRXV0Oj0QAA FAoFiAhEJMwLqdFohAEFTU1NenN3627TEt19GXP8+HGIxWIEBAToDUgoLS2Fubk5nJ2dIRKJ4ODg gOrqapw+fRo+Pj4IDg7W24+ZmRlkMlmrr4tYLDaYs04mkwnP6+joaLAv3W0sLCyE+cilUimsrKwA 3LqOaBN7tra2kEgkeusYY//FCbJ7QK1W48qVK8IosMzMTJw/fx65ubnQaDSwtLRE//79DZaQkBDh RMYYY4yZQlVVlZAsu3z5stB4k5OTA7VaDQsLC6Hhf/DgwUKjTUBAQI//Usd6F23HpvPnz+PChQtC Uqy0tBQA4OHhIfT0Dw0NFRoxec4/xhhjd6q6ulqv80VmZiYyMzORn58P4Faj6ZAhQzB48GAMGTIE Q4YMwaBBgwwaVxlj3VdzczNSU1ORlJSEn376CdnZ2fD19cW0adMQGxuLmJgYk3RIVCgUqK6uhlKp RF1dHaqqqqBSqVBXV4fa2lo0NjZCoVCgqakJSqUS9fX1aGhoQHV1NZqamvTKa5NdlZWVRhNYHWFv by+MqHVwcIBIJBKSUwBgbm5uMLVMexJBNjY2RueHzM/Px9mzZzF9+nQ4OTlBLBYb3V57rACQl5eH I0eO4LHHHtMrr5sMbIluklCrsrISwK3/FW0nPLVaDaVSCQBobGwU7ghzJ2QyGSQSCezt7YWkmp2d HSQSCRwcHISkm/Y1cnBwgEQigZ2dHaysrCCVSmFvbw+JRAKZTAYbGxvY2dnB3t6er0fsvsQJsrtU UVGB9PR0nD17Funp6bhw4QIuX76MxsZGiMVi9O3bV68BcfDgwejbt2+LJ1jGGGOsO1KpVEKDzcWL F4Xl2rVrICLY2NggNDQUQ4cOxfDhwzFs2DAMGTIEtra2pg6dsTYpFAqcOXMGZ86cQVpaGs6dO4fs 7Gyo1WpIpVIMHDjQoEHS1dXV1GEzxhjrJaqrq4XOGufOncOFCxdw4cIFKJVKiEQiBAQEYOjQoRgx YgRGjBiBsLAwuLu7mzpsxlg7ZGRkICEhAUlJSUhLS4OTkxOmT5+OuLg4TJs2rc3vU1VVVUJiq7q6 GtXV1aiqqhLW6z5WVVUFhUKhV1apVApJmJZoRyA5OjpCIpHA1tbWaKKktcSKNhHTkRFPpvDUU0/h gw8+gJOTU4e2e++99+Dq6oonn3zyHkVmXEdG5GnXtZToVKvVUCgUQgJONzGqVqtRXV3dZtJPm7y0 t7cXFm3yzMHBATKZTPhb+5h2vW5ZbkdgXYkTZB2g7UWgTYadPXsW169fB3CrF/GwYcMwdOhQDBo0 SOhRzENXGWOM9WRKpRKZmZm4cOECLl68iHPnzuHs2bNQKBQwMzNDv379MGzYMAwfPlxInHGDDTOl iooKpKWlCcmwM2fOICcnB8Ct+tyIESOEOt3gwYMRHBzM88AwxhjrdogIeXl5wkjns2fP4syZM8Jo M29vb4SFheklzby8vEwbNGOsRUqlEqdPn8bOnTtx4MABZGVlwcLCAgsWLICtrS0qKipQUVGBmzdv 6v1sqVnXwcHBIBEhk8mE5IXuY9rkhfZ3a2tr2Nvbw9LSEtbW1l38SphOXl4ebGxs4Obmdkfbf/HF F1i+fHknR9U9KZVKqNVqVFZWoq6uTi/hWllZaZCcra6uFkYp6i4tjS4Ui8VwcnKCs7Oz3k/d311c XAwe703/r6zzcIKsBUVFRTh16hROnjyJU6dO4fTp06isrDRo7Bs2bBiGDRvGk6szxhhjOvLy8oRO JdpF26nEy8sLDzzwAEaOHIlRo/zWRagAACAASURBVEZh5MiRwr3VGetMjY2NOHPmDE6cOIETJ07g +PHjyMvLAwD4+PjoNRqOGDGCGw4ZY4zd93Q7gmg7g+Tm5oKI4OnpiVGjRmHMmDEYO3YswsLCuJc+ Y/eARqNBWVkZSktLUVRUhNLSUpSUlKC0tNRokuvmzZvCaB8tc3NzWFlZwcvLy2giQPu7sYRXW/Ne sXujsbERAIzeupEZp50P7vaRkAqFQvh8tPSZqaioMNifVCo1+Kw4OzvDxcUFrq6ucHNzg6enJ9zd 3eHm5sZ3BWEAOEEG4NZtdU6dOqW3FBYWwszMDCEhIRg5ciRGjhyJESNG8O2iGGOMsTukvS3xmTNn hE4o165dAwAEBQUJ19uRI0di+PDh3PuLdVh+fj6OHz+O48eP48SJE0hPT4dKpYKzszNGjx6N0aNH C3U6HsnIGGOst1AoFEhPT8fp06eFa2RhYSHMzc0xaNAgjBkzBmPGjMHo0aPRv39/nleWsRZok14l JSUoLi5GaWkpiouLheSXNhlWWlqK5uZmYTupVCo0yBtrvL898eXi4iLMscUYM665udlo0uz2ddpF +9nUTUZLJBK4ubnBw8MDHh4ecHNzg5eXF9zc3ODu7g5PT08hqcaJ556rVybIioqKcPToUaSkpODo 0aNIT09Hc3MzPD09ERYWJizh4eFwdnY2dbiMMcZYj1VVVYVTp04hJSUFaWlpOHnyJEpLS2Fubo6Q kBBERkYiIiIC48ePh5+fn6nDZd1Mbm4ukpOTkZKSgiNHjuDatWsQi8UIDg5GWFiY8P8TGhrKjX2M McaYjqKiIqSlpSEtLQ1Hjx5Famoq6urqYGdnh9GjRyM6OhoREREYNWoUj4ZgPZ5KpcKNGzdQUFCA Gzdu4Pr168LvcrkccrmcG9YZ6yFaS3SXlJSgqKhIKGMs0a0dgebn5wcfHx/4+PigT58+8PX1hZeX F8RisQmPjt2JHp8gU6vVOHPmDI4ePSoscrkclpaWeOCBBxAeHo7IyEiMHDkSnp6epg6XGXH16lUE BQXhhx9+wMMPP4xly5bhl19+Ee6tbkx2djaCg4MxevRoHD9+3GgZW1tb1NbWGqwXiURwdnZGREQE XnvtNYwcObLVbT744AOsWrVKb92pU6ewfv16/P7775DL5cKw+JCQEERHR2PKlCno27dvB14Fxoxb u3YtVq9eDeDWPAMFBQUmjqj7uJNzB+secnNzcfz4caSmpiIlJQUXL16ERqNB3759ERERISyc9Ohd 1Go10tPTkZKSgt9//x0pKSm4efMm7O3tERkZicjISIwbNw5hYWHCZN+se+LzM1+/72fbtm3DI488 AgCwtLREQ0NDh/fRk99//nzfv5qamnDu3DkcPXoUR44cQUpKCkpLS2Fra4vw8HCMGzcOf/rTnzBq 1ChIpVJTh8tYu6nVahQXF+P69et6SbBr166hoKAABQUFKCkpEcpbWlrqNXq7u7sLiS/dZBjfmo2x nk2j0aC0tBRlZWUoLCxEWVkZ5HI5iouLIZfLhWR6cXEx1Go1gFu3RvXw8DCaPPPx8YGvry88PDy4 HaOb6XEpTY1Gg7Nnzwqjww4cOACFQgF7e3uMGjUKzzzzjNCbmBtPeq6vv/4aAHDixAlkZmYiNDTU oExNTQ3Onj2L4cOHY+bMmdi1axeAW6MZDh48iGXLliEiIgJ79+5FdHR0q9toNTc3Y82aNfjkk0+w cuVK7Nu3DwEBAVAoFDh//jzef/99YcLOpqambt2roKamBsOHD0dISAiSkpJMHU6XuB+PedWqVVi1 ahWGDRuG8vJyvce60/F0p1hY9xcYGIjAwEA8+uijAP577tWO/l6zZg0UCgVcXFwwZswYREZGIjo6 GiNGjOCKZg+jHSGmXSorK4U63erVqxEREYHRo0dDIpGYOlRmQvfjNaa163dL7sfj7IkefvhhPPzw w4iOjkZKSsod7eN+qb+x3kUikeCBBx7AAw88gOeffx7Areuwtm1l8+bNeP3112FlZYWIiAhER0cj Ojoaw4cPh5mZmYmjZ70ZEaGgoAA5OTnCkpubKyTB5HI5NBoNAEAsFsPT01NosJ44cSJ8fX3Rp08f oTHbw8PDxEfEGOsOzM3N4enpCU9PTwwZMqTFchqNBnK5XC/prk3Ip6SkCCNRtWOULCws4O3tDR8f H/j7+yMwMBB9+/ZFv3790LdvX7i5uXXVIbL/r/u2zrdTc3MzLly4gEOHDuHgwYM4cuQIqqqq4Obm hokTJ+Ldd9/Fn/70J76Pdi/S3NyMrVu3Yvjw4UhPT8fXX3+NDz74oN3by2QyzJ49G3V1dViwYAFe eOEFXLx4sV3bvv7661i7di02btyIpUuXCuvd3d0xefJkTJo0CXFxcdi3b1+Hj6urERGam5v1hhN3 lK2tLYYNG3bHjQdd7W6Pubsdb2e8hx3R2vF3dSysZ7G1tRVGCK1ZswZqtRrnzp3D4cOHcejQIbzz zjt45ZVX4OnpiYkTJwoLj9S9/8jlcvz2229CQqygoAAymQwTJ07EW2+9hYkTJ2LAgAFcp2N6etr1 uyWdeS29X465M90vx8x1JtadaDstPf744wBuzfV56NAhJCcn4+OPP8Yrr7wCFxcXTJo0SUiYBQQE mDhq1hM1NTUhPz9fSIBdvXpV+JmXlyeM5rW1tUXfvn0RGBiIkSNHYu7cuULiy8/PDx4eHjA3Nzfx 0TDGehJzc3N4e3vD29u7xTKNjY0oLCxEQUGBXiLt2rVr2L59O/Ly8qBSqQAAdnZ26Nu3r7BoE2d9 +/aFr68vd0q5B+7LBFlFRYXQeLJnzx4UFhYK98l+9dVXuRd5L7d//36IxWJs3LgRI0eOxDfffIN/ /etfHR6tNXHiRABARkYGFApFmxOkXr58Ge+++y7CwsL0kmO6zM3N8frrr98XCTI7Ozvk5OSYOowu 1dOOuTsdT3eKhd3/xGKxMF/oSy+9JIwe185F9dJLL6G6uhoBAQGYPHkyoqOjERMTAzs7O1OHzozI yMhAUlISEhMTkZqaCnNzcwwdOhSPPfYYoqOj8ac//YnnPmGt6i3XmN5ynL0dv8+sO/P398cTTzyB J554AoD+SO/Vq1ejqqoKgYGBiI2NRVxcHF/DWYdoNBrk5eUhIyMD2dnZeomw69evC6PAnJ2dhQbj efPm6TUg8+gvxlh3ZGFhgYCAAAQEBGDcuHEGjzc3NwsjYbXnvZycHBw4cABffvkllEql3n50k2ch ISEYMGAA+vTp09WH1WPcFwkyIkJ6ejr27duHffv24fjx4xCJRAgPD8df/vIXTJ06FUOHDuUMKgMA bN68GYsXL8YDDzyAIUOG4Pz589i7dy9mzJjRof3oTs/XnmTrxo0b0dzcjPj4+FbLjR07Fj186j/G GOtS5ubmQsJszZo1aGxsxPHjx/HLL7/gl19+waZNm2BpaYnx48fjwQcfxLRp0xAUFGTqsHut2tpa oZNTUlISiouL4evri+nTp+PVV1/FhAkTYGNjY+owGWOMMdaGwMBAPP3003j66afR2NiI1NRU7N27 F4mJifj000/h6OiIqVOnIi4uDjExMXBycjJ1yKybKCoqQmZmJjIyMoSfZ8+eFeZ8d3R0FEYwzp8/ H4GBgQgNDcWgQYPa7LzMGGP3GzMzM/Tp0wd9+vQRBmzoqqysRG5urt5y6dIl7NmzB3l5eSAi2Nvb IygoCKGhoRg4cKDw09/fn3MmbaFuqqmpiQ4cOEDPPvsseXp6EgDy8vKiJ598khISEkihUJg6RNYN 3bx5k6RSKeXm5hIR0ccff0wAaObMmUbLp6ent/j4t99+SwBo4MCB7domLCyMANDevXvv+jh27txJ AITl8uXLFB8fT05OTsK6srIyIiIqLS2l5557jvz8/EgikZCLiwvNnj2b0tPTDfZ76dIlmjlzJtnb 25OVlRWNHDmSEhMTKSoqStjvU089ZfD89fX1wj4aGhro9ddfp5CQELKysiJHR0eKjY2ln3/+mdRq NRERffDBB3rbaxdzc3O9eNoTe0deC12VlZUGz//WW28R0a3zi+76uXPntnjM7Xn+NWvWtHq8b731 lrAuIiJCiHHfvn3CemdnZ734m5qaaNu2bRQdHU3u7u4klUpp0KBB9Mknn5BGozE43qFDh5K3t3eL r1tH38OOxNDW+91aLERE5eXltHLlSgoMDCSJREIODg4UExNDBw8ebPF48vLyaP78+SSTycjJyYmm T59OV69eNXhdGCMiKioqos2bN1N8fDw5ODgQAAoODqY1a9bQyZMnqbm52dQh9njV1dX03Xff0axZ s0gqlZKZmRmNGjWK3nrrLaPXK9Z79fbrd0vae5xtXR+7uo62adOmNss8//zzHXqddY/B29ubTp48 SZMmTSJbW1uysrKiCRMmUEpKSoePuSW69Wdra2uKjIykP/74g6KiosjS0tKgfEfq5u2pv3X0M9HZ 7+GdPDdjRETZ2dn08ccfU1RUFEkkEjI3N6eoqCjasGEDlZaWmjo81kUKCwvpwIED9Mknn9DTTz9N ERERZGNjI5w7PD09KTo6mlasWEFfffUV/fHHH1RdXW3qsBlj7L5RWVlJp0+fpi1bttCaNWsoNjaW AgMDSSQSEQCyt7ensLAwWrhwIb377ru0e/duysnJMfrdpLfqVgmyuro6+vnnn2nRokVCpXz48OFC 4wk3YLG2fPbZZzRx4kTh77KyMpJIJCQWi6mkpMSgvLFkV1VVFf3000/k5uZGEomEDhw40OY2RCQk ck+cONFpxzNz5kwCQOPHj6dDhw5RbW0tHT9+nMzNzamsrIyKiorIz8+P3N3dac+ePaRUKunixYs0 fvx4kkqllJqaKuwrOzubHBwcyNvbm/bv3y+UjY6OJldXV6Nf8LXPr5vQWLJkCclkMtq/fz/V1dWR XC6nVatWEQA6dOiQ3vY2NjZ6DR26OhJ7e16LlsTExJCZmZnR5MnYsWPp+++/b/OY2/v8rR1va4+H hYUZNLAlJiYSAPrnP/9JFRUVVFZWRp9++imZmZnRqlWrDPbRUgPb3byHHY2hreM3FktxcTEFBASQ u7s7JSYmUlVVFWVlZdGcOXNIJBLRpk2bjO5j5syZlJqaSjU1NXTgwAEh4ctYW5qamujIkSO0atUq CgwMJADk6+tLK1asoMOHD+slidndUSqV9P3339Ps2bPJysqKJBIJTZ06lTZt2kRyudzU4bFurrdf v1vS1nG29/rY1XW0u3kfjL3ORLdeOxsbGxo7dqxwzKdOnaIhQ4aQhYUFHT58uN3H3BJj9efz58/T lClTyN/f36D+3NHXriP1t458Jjr7PZw6dWqrz/3dd9+17wVlvZZCoaDt27fTvHnzyNramszNzSk6 Opq++uqrVr/LsftHY2MjpaWl0YYNG2jp0qU0YsQIkkqlBIBEIhH5+/vTtGnTaPXq1bR582Y6efIk KZVKU4fNGGM91s2bN+nIkSO0YcMGeu655ygqKoo8PDyEDgr29vYUERFBK1asoK1bt1JmZmavTZqZ PEHW1NREe/bsoUceeYRsbW3JzMyMwsPDae3atcIoIMbaa8SIEbR161a9dbNnzyYAtHbtWoPy2mSX 7iISicjZ2ZlmzJhBJ0+ebHGblhJkxra5U9ovqy2NSlu0aBEBMPhSWlxcTJaWlhQWFiasi4+PJwD0 448/6pUtLS0la2vrdifIAgICKDw83KBscHBwhxJkHYldN5aOjtBLTk4mALR8+XK99SkpKdSnTx9q amoy+jwtNTy19vyd3cA2YcIEg7ILFiwgiURCVVVVeus70sDS3vewozHcSYJs8eLFBIB++OEHvbIN DQ3k5eVFVlZWeg3p2n0kJibqlZ83bx4BxkcTMtaa9PR0euONN2jQoEEEgFxdXWn58uUGjYesfdRq Ne3du5fi4+PJysqKxGIxTZkyhf79739TeXm5qcNj95Hefv1uSVvH2d7rY1fX0e7mfWgtQQbAYGTW +fPnCQANHTq0XftvTUv158LCQrK0tDSoP3f0tetI/a0jn4nOfg9//fXXFp/b29ubGhsbjW7HmDE1 NTW0fft2mjt3rlBXmDp1Kv3www8G5zbWPTU1NdG5c+fof//3f+nZZ5+lkSNHkqWlJQEgW1tb+tOf /kQvvvgiff3115wIY4yxbkY3caY9h1tYWBAAsrOzE87h33//PWVlZfWKAUsmS5CdOXOGVq5cSR4e HiQSiSgiIoLWr19PhYWFpgqJ3efOnTtHdnZ2VFtbq7d+9+7dBBjeKpGo9VsstqQzb7F44cIFgwTd n//8Z+Fx7ZfVlhoVZTIZmZmZGTS2EN1KFgKgGzduEBGRnZ0dATBaOR0xYkS7E2TPPvssAaClS5fS sWPHWh1t0VpDREdi143lThpYhw8fTtbW1nrbzpw5kz766CODsm01PLX2/J3ZwNYS7W2C7qYHckfe w47EcCcJMplMRgCM3kZj4cKFBIC2bNlisI/bR5+sXLmSANC5c+c6dCyM6bpy5Qr985//pIEDBxIA CgoKor///e+Uk5Nj6tC6vStXrtCrr75K3t7eJBKJaNy4cbRp0yZOirG70huv3+2tG7Z0nO29PnZ1 He1u3oe2RpAZ4+XlRQCoqKiozf23prX68+DBgw3qzx197TpSfyNq/2fiXryHgwcPNvrc7777bovb MNaWmpoa2rZtG8XGxpJYLCZHR0davnw5nTp1ytShsf9Po9HQxYsXacuWLfTcc8/R2LFjycrKigCQ tbU1hYeH04oVK2jLli2UkZHRa0cfMMbY/ayxsZFOnz5NGzZsoCVLltCwYcNIIpEQAJLJZDRp0iR6 +eWXaceOHT1yQFOXztBWUVGBjz76CIMHD8aIESOwe/duLFu2DNnZ2UhJScHy5cvh5eXVlSGxHmTz 5s1QKpWwsbGBSCQSlhkzZgAAMjIycPLkyXv2/OPHjwcAnD9/vt3bDBo0CHQrUS0sn3/+uUE5Gxsb g3UqlQpVVVVobm6GTCbTO2aRSIQzZ84AALKzs6FSqaBUKiGVSmFra2uwL0dHx3bHvH79emzduhW5 ubmIioqCvb09YmJisHPnznbvoyOx387Ya9GWl156CXV1dfjiiy8AAFeuXMGRI0ewZMmSDu/rTp7/ TlRVVeGNN97A4MGD4ejoKLw2q1evBgDU1dXd8b7b+x7eyxiA//4fSKVS2NnZGTzu7u4OAJDL5QaP yWQyvb8tLCwAAM3NzXcVE+vdgoKC8Oqrr+LixYtIS0vD9OnT8cUXX6Bfv34YN24cvv76a9TX15s6 zG6jsbER3377LcaNG4eQkBB88803WLRoEbKysoRzrLOzs6nDZPex3nj9bm/dsCV3e32813W0zn4f HBwcjK53c3MDAJSWlt7xvtuqP2ufQ7f8nb527dWez8S9eg9feOEFg+c+ePAgnn766Ts+HsZsbGzw 0EMPITExEdevX8err76KQ4cOYeTIkRg8eDA+++wzKJVKU4fZq6jVaqSlpWHdunWYP38+XF1dMWjQ ICxZsgS//fYb+vXrh3/961/4448/UFFRgaNHj2LdunV4/PHHERoaCjOzLm1mZIwx1gkkEgnCwsLw zDPPYNOmTUhPT0dtbS0uXryITz/9FIMGDcLRo0exYMECBAYGwsPDA3FxcXjvvfeQkpKCxsZGUx/C XemSK1daWhqeeuop+Pj44O9//zsiIiJw9OhRZGdn480330Tfvn27IgzWgzU1NeG7777D0aNHDRoV iAgvvPACAODrr7++ZzE888wzEIvF+PHHH1st9/LLL8PMzAyXL1++q+eztLSEg4MDxGIxmpqajB43 EWHixImwtLSEnZ0dGhoaUFNTY7CvjjQeiEQiLFy4EMnJyVAoFNi1axeICHPmzMFHH31kUPZuY+8M Dz30EHx9ffH5559DpVLhww8/xNKlS40mZe5GS8erZWZmZvSioVAoDNbFxcXhrbfewtKlS3HlyhU0 NzeDiPDxxx8DAIjoruJsz3vY0RjaOv7bWVpaQiaToaGhwegX35KSEgCAh4dHRw+Rsbs2YsQIfPzx xygoKEBSUhK8vb2xbNky+Pj4YPXq1cjJyTF1iCZTUlKCf/zjH/D398eTTz4JT09P7N27F/n5+Xjn nXcQFBRk6hBZD8HX73unu9TRdHXkdda6efOm0ddUW7fVTWLdST2ltfpzRUWFQfl7/dq15zNxr+J4 7LHH4O7urvfcixYt6lBHO8Za4+npidWrVyMzMxPHjh1DeHg4Xn31Vfj4+GDlypW9uu51L6lUKhw6 dAj/8z//g8jISNja2uKBBx7A+++/D5FIhL/97W9IS0tDbW0tMjIysHXrVjz//POIjIyEpaWlqcPv dq5evQqRSIRt27YBAJYtWwZ/f3/TBtXF1q5dK3TK8PHxMXU4d6WyshIbNmzApEmT4OTkBCsrKwQF BeGxxx7DuXPn2tw+OzsbIpEIY8aMabGMra2tQWcWkUgEMzMzuLq6YtasWTh16lSb26xdu9Zg36dO ncLixYsREBAAKysrODk5YdCgQZg7dy6+/PLL++q8um3bNuFYpVLpHe+HP6PtJ5FIMHDgQDz++ONY t24dUlJSUFFRgT/++AMrV64EALz33nsYN24cXFxcEBMTg3fffRenTp2CRqMxcfQdc88SZE1NTfjm m28wZswYPPDAAzh58iQ+/PBDFBQUYMOGDQgPD+/wlxTGWpKYmAgXFxeEh4cbffypp54CAPzwww/3 rPd/cHAw3nzzTZw+fRqbN282WiYrKwtfffUV5s+fj/79+9/1c86ZMwdqtRpHjx41eOy9995Dnz59 oFarAQDTpk0DAPzyyy965eRyOa5cudLu53RwcBCSexKJBJMnT8auXbsgEomwZ88evbLW1tZ6DR0h ISHYuHFjh2O/W2KxGM8//zxKS0vx4YcfYtu2bVixYkWn7FtXa8cL3PrSV1hYqLeNXC7H9evX9dZp NBocPXoUHh4eWLFiBVxdXYXzZWf8/7bnPbyTGNo6fmNmz54NAAb/OyqVCr/99husrKwwderUOztQ xjqBWCzGgw8+iG3btuH69et48cUXsX37dgQHB+PBBx/E3r17u02D97127tw5LF68GH5+fvj000+x ePFi5ObmYseOHYiJiYG5ubmpQ2Q9DF+/753uUkfT1d7XWVdDQ4NBo9GFCxdQVFSEoUOHwtPTU1h/ J/WUlurP5eXlyMrKMih/r1+79n4m7kUclpaWWL58ufDc3333HZ5//vk7PhbGWjNmzBh89dVXKCgo wOuvv46dO3ciODgYM2fOxOHDh00d3n2NiJCeno4PPvgAU6dOhZOTEyZNmoRt27ZhwIAB2LhxI3Jy clBYWIjt27fjueeew4gRIyCRSEwdeq9UU1ODoKAgxMbGmjqUdlu1ahWICEOHDjV47H47ntWrV+O5 557DzJkzkZmZiZs3b2Lz5s04e/YswsLCsGvXrla313bSP3HiBDIzM42WqampQXp6OgBg5syZQkeW yspKbNy4EceOHUNERASSk5Nb3WbVqlXC483NzVi9ejXCw8Ph5uaGffv2QaFQ4NKlS/j4449RXV2N 5cuXo1+/fvekTncvPPzwwyAiREVFmTqUXs3GxgaRkZFYs2YNEhMTUV5ejvPnz+Pdd9+Fk5MTPvnk E4waNQpubm6YN28evvzyy7u6e0KX6aRbNQrq6+tp/fr15OfnRxKJhObPn0+HDx/u7KdhTE9sbCy9 //77rZYZNWoUAaBvv/1WWNeZc5BpvfLKKySRSGjNmjWUlZVFKpWKCgoK6N///jd5enpSZGQk1dTU tOu5Wpp/QKukpIT69u1LgYGBtHfvXlIoFHTz5k3asGEDWVtb0/bt24WyV69eJScnJ/L29qb9+/eT UqmkCxcuUExMDPn5+bV7DjKZTEbjx4+nc+fOUUNDA5WUlNDf/vY3AkBvv/223vYxMTEkk8no+vXr lJqaSmKxmDIzMzsce3tei7ZUV1eTTCYjkUhEjz/+eIvl2prbo7Xnb+14iYj+8pe/EAD67LPPSKlU 0tWrV2n+/Pnk7e1tMLfGpEmTCAC9//77VFZWRnV1dXTw4EHq06cPAaADBw7ole/IHBbtfQ87GkNb x28sluLiYgoICCB3d3dKTEyk6upqysrKojlz5pBIJKKNGze2631Ys2YNAaD09PQW3x/GOotaraaf fvqJoqOjSSQS0dChQ2nHjh09ds6FCxcu0Ny5c0kkEtGgQYNo06ZNVFdXZ+qwWC/RW6/fnXWcLV0f u7qO1p4yHXmdiW69djKZjKKioig1NZVqamro1KlTNGTIELKwsDD4DtrW+2yMsfpzRkYGTZ06ldzc 3Azqzx197To6BxlR+z4T96qeXVZWRlZWViQSiTr0/Ymxu6VWq+nHH3+kcePGEQAaP348/f7776YO 675RW1tLBw4coBUrVpC3tzcBIFdXV4qPj6evvvqqR84nYyrZ2dkEgH744QciInrmmWfIz8/vjvdX XV1NgYGBNG3atDva/k7m3+wsxq5xd3s8Xe2pp56ip59+2mD92bNnhTmrW6LRaMjb25uGDx9OAGjV qlUtlm2tnfHbb78lADRw4MB2b/PXv/6VABi0p2ip1WqaNm0aAaCmpqYW4+qOoqKijLZftldnf0aZ oZycHPrqq68oPj6eHBwcCAAFBgbS008/Tbt376aGhgZTh2ig0xJkNTU19Mknn5C3tzdZWFjQwoUL 6erVq521e8aMunHjht4k5qNHjzYok5eXZzDZubu7O9nY2BisDwkJafX5jG3zwQcfGJQ7efIkLVy4 kHx9fUkikZCdnR2NGTOG1q1bRyqVqs3jOnbsmMHztJTPvnnzJr344osUGBhIEomEXF1dacqUKQYN MEREWVlZNGvWLLK3txcm1P39999pwoQJZG1tLZTbuXOnwXM/9thjRHSrIvDMM8/QgAEDyNrampyc nGjMmDG0adMmam5u1nu+EEKRogAAIABJREFUy5cv07hx48jGxoZ8fX1p/fr1HY69I69FW1avXm10 ovrWjrkjz9/W8SoUClqyZAl5enqSlZUVRUZG0qlTpygsLEzY75o1a4joVgPEM888I/wPubu70+LF i+mVV14RyoaFhdEHH3xgENtrr73WKe9he2No6/hbi4WIqLy8nF544QUKCAggiURCMpmMpk6dSr/9 9ptQxtj78NprrxERGayfPn16h/4vGLsbFy5coIULF5K5uTn17duXvvrqq/vuS0ZLMjMzhWMbNGgQ 7dixw+A8z1hX6E3X75Z05Djbc33sqjpaR96HjrzORP9teMvMzKSpU6eSnZ0dWVlZ0fjx4yklJaXD 73NLdOvPVlZWNHLkSEpKSqKoqCghrqeeeqpDr92d1N90tfaZ6Egcd1LPXrp0KQHg5AQzmdTUVIqN jSUAFBERQQcPHjR1SN1SaWkpffnllzRlyhSytLQkMzMzGjt2LL3zzjuUnp7Odbp7pLs1vne3BFlP YmVlRWZmZi1+lvbt20d+fn506tQpoR2ype+JrSW7CgsLhetzZWVlm9tcunSJzMzM9NpqjElNTSWA E2Sm/oz2dE1NTXTkyBFas2YNDRw4kACQvb09zZs3j77//ntSKpWmDpGIOiFBptFo6N///reQcHjx xRepqKioM2JjjHWRkJAQ6tOnj6nDYIyx+1ZmZiYtWLCAxGIx9e/fn/bu3WvqkO7YzZs3admyZWRm ZkaDBw+mH3/8kRtRGGPdTk9veOuuNm/e3GajG2Nd4fDhwzR+/HgCQLNmzaK8vDxTh2Ry5eXltHHj RoqOjiZzc3Oytram+Ph42rJlC5WWlpo6vF6huzW+c4Ls3qipqSEANGTIkBbLxMfH05tvvklEREOG DCEA9PPPPxst21qCrKCgQEiQKRSKNrdZuXIlAaB33333Do6s++ME2f0tNzeXPvvsM5o8eTKJxWKy srKiuXPn0vbt26m2ttZkcd3VHGQpKSkYNWoUli1bhvj4eOTl5eHDDz/Uu9c7Y6x7kMvlcHJyQlNT k976/Px85OTkYNKkSSaKjDHG7n8DBgzAN998g0uXLmHgwIF48MEHMX36dKNz1HRXzc3N+N///V+E hITg559/xpYtW3D27FnMnTuX541ljDEGANiwYQNefPFFU4fBGMaPH4/Dhw9j//79uHz5MgYOHIh3 3nkHKpXK1KF1qebmZiQnJ2P+/Pnw9PTEihUrIJVKsXnzZsjlcuzYsQOPP/44XF1dTR1qr9CvXz8Q ER5++GEAt86Z+fn5AACFQgGRSKS3vP322wAAtVqtt37evHnCPOHapaGhAQAM1mdlZWH+/PlwdnYW 1r3yyisQiUSora3F0aNHhfVisRgA8PbbbwvrIiMjhfh/+eUXYb2Li4vesanVamzfvh2TJ0+Gh4cH rKysMHjwYKxbtw7Nzc1tvjYtHQ9waw7yN954A/3794e1tTWcnJwQFxeH3bt3Q6PR6O2nrKwMK1as gL+/PywsLODq6oo5c+bg7NmzbcYQGRmpF8OCBQsAANHR0XrrFQpFq/tJSEgAALz22mtGH6+oqEBi YiIWLVoEAHjiiScAAJs3b24zxttp510cOHAgZDJZm+WPHDkCABgyZEiHn+t2t79n165dw0MPPQQ7 Ozs4Oztj4cKFqKysRH5+PuLi4mBnZwdPT08sXboUSqXSYH83b97Eiy++iL59+8LCwgKOjo6YNm0a Dh06ZFD28uXLmDVrFmQyGWxsbDBu3DikpKS0GGt7/y9a+4yyey8gIAB/+ctfsH//fpSUlGDDhg1Q qVRYsGABnJ2dMX/+fCQnJ3f9PO93klUrLy+nRx99lEQiEU2ePJkuXrzYqVk7xljnKy4uJgD0xBNP 0PXr16m2tpZOnDhBo0aNIicnJ8rJyTF1iIwx1mMcPHiQhgwZQhKJhF5++eVueZ9tXZcvX6YxY8aQ WCymF154gaqqqkwdEmOMtaon90zvTjZt2kSzZs0ipVJJX375JQUFBd13t2NiPZ9KpaJ//etfZGNj Q8HBwfTHH3+YOqR7Ljc3l9asWUOenp4kEolowoQJtHXrVqqurjZ1aKwNMTExZGZmZnRamrFjx9L3 33+vt66t+UfHjx9Phw4dotraWjp+/DiZm5tTWVkZEbU9gqylx8PCwgzm/0xMTCQA9M9//pMqKiqo rKyMPv30UzIzMzM6v1ZH5tlcsmQJyWQy2r9/P9XV1ZFcLqdVq1YRADp06JBQrqioiPz8/Mjd3Z32 7NlDSqWSLl68SOPHjyepVEqpqaktHqvW2bNnycbGhoYOHUo1NTVERNTQ0ECjR48WRhW1Ri6Xk7u7 Oy1ZsqTFMp999hlNnDhR+LusrIwkEgmJxWIqKSkxKG9sNFhVVRX99NNP5ObmRhKJxGAalZZGkHl6 ehIAOnHiRJvH0l7a92zOnDl0+vRpqqmpoa1btxIAmjZtGs2cOZPS09NJqVTShg0bCACtXLlSbx+3 zz9fVVWlN//8pk2bhLLZ2dnk4OCgNwfs+fPnacqUKeTv728wgqwz/i+YaZWUlNC6deto6NChBNya Aum9996j8vLyLnn+DifIfvvtN/L29iZfX1/atWvXvYiJMXaPJCcn0+zZs8nf358sLCzI3d2dHnvs MZ4vkDHG7gG1Wk1ffPEF2dvb09ChQykjI8PUIRn1zTffkK2tLY0aNarV+WwYY6w76Oj8bezubNq0 iQCQWCymIUOGUFpamqlDYqxF165do9jYWBKLxfTOO++QRqMxdUid7sSJEzR//nwyNzcnHx8fev31 17mz630mOTmZANDy5cv11qekpFCfPn0MOiG0lSBr7dbunZ0gmzBhgkHZBQsWkEQiMehg15EEWUBA AIWHhxuUDQ4O1kuQLVq0iADQd999p1euuLiYLC0t230L4B07dggJn+bmZlq0aBH99a9/bXO78vJy GjZsGD300EOkVqtbLDdixAjaunWr3rrZs2cTAFq7dq1BeW2yS3cRiUTk7OxMM2bMoJMnT7a4TUsJ MmPb3Cnte7Znzx699do5pW6flzQgIIBCQkL01i1evFjv1oZaDQ0N5OXlRVZWViSXy4no1u0pAdCP P/6oV7awsJAsLS0NEmSd9X/Buoe0tDT685//TA4ODmRjY0N//vOfKTs7+54+Z7sTZCqVil5++WUy MzOjefPmUUVFxb2MizHGGGOsR8jJyaGxY8eSlZUVrV+/3tThCGpra+nJJ58kkUhEK1euJJVKZeqQ GGOMMcbuSnNzM3388cdkYWFBkydPNjpa4370+++/07hx4wgAhYWF0ffff8+jOe9jw4cPJ2tra73R ETNnzqSPPvrIoGxbCbLWRlh0ZoKsJdqOK7eP0ulIguzZZ58lALR06VI6duxYi8knmUxGZmZmRu92 MWLECAJAN27caFfcr732GgGg8PBwio2NbTOhXlNTQ2FhYfToo4+2mhw7d+4c2dnZGcyntHv3bgJA AwcONNimtTnIWtLSNmFhYW0mTjtK+57dfj6dPHkyATA41sjISLKzs9NbJ5PJCIDRUa4LFy4kALRl yxYiIrKzsyMApFQqDcoOHjzYIEHWmf8XrPtQKpW0bt06CgwMFPJRmZmZ9+S52jUHWW1tLWbOnInP PvsMH330ERISEuDo6Nj++zgyxhhjjPVSgYGBOHLkCN5880288MILeOKJJ6BWq00aU1VVFSZPnoz/ /Oc/2LFjBz766CNYWFiYNCbGGGOMsbslEonwwgsvIDU1Fbm5uRg1ahRycnJMHdYdO3/+PKZPn47x 48fD0tIShw8fxunTp/HII48I80mx+89LL72Euro6fPHFFwCAK1eu4MiRI1iyZEmH92VjY9PZ4RlV VVWFN954A4MHD4ajo6MwL9Xq1asBAHV1dXe87/Xr12Pr1q3Izc1FVFQU7O3tERMTg507dwplVCoV qqqq0NzcDJlMZjCf25kzZwAA2dnZ7XrOt956C6NHj0Zqairi4+NhZtZyE7larUZ8fDy8vb2xZcsW mJubt1h28+bNUCqVsLGx0YtvxowZAICMjAycPHmyXTHeifHjxwO4de7obPb29np/m5mZwdzcHNbW 1nrrzc3N9eal0753UqkUdnZ2Bvt1d3cHAMjlcqhUKiiVSkilUtja2hqUdXNz0/u7s/8vWPdha2uL FStW4MqVK9i+fTuuXLmCwYMHY8mSJSgoKOjU52ozQVZRUYHJkycjPT0dR48exfPPP9+pAbA7k52d DZFIhDFjxpg6FANr164VTkQ+Pj5dsu97+Zxdsf+eatu2bcLrJpVK73p/KSkpEIlEwiSlzLiamhqD SsGxY8fa3G716tUGEwZ35r6AWxe42/e3du1ag+1Pnz6NxYsXw9/fH1KpFA4ODhg5ciT+8Y9/tDlh blfr7NcIADQaDTZs2IDw8HDIZDJIJBJ4eXnhwQcfxOeff24wiayx11X3szdkyBCsX7++6yc6ZQKx WIw1a9bgp59+wvbt2xEfH683MXVXqqysxJQpU5CXl4eUlBTMmzfPJHH0NsY+p2b/j73zjovq+P7+ Z5ell6UIixQRUWPH3o0KRtGIorElipJYSEyixIgQS4zBGBWi4ackahLFrtHEgh0LKigBjaKiCFYs NOldynn+8Nn9smy9W1gw9/167R8798yZM3Pn3nvmnjszXC6srKzg7u6OuXPn4vr162qVwforDYOm /RuWxsPbeg2pUi95vkX937Vr16TqYOrPKesn1h0TKJsnMTERfn5+cHV1hbGxMaytrdGpUyd88MEH +PXXX8UCKJrwq06cOIG2bduyAQwd0qNHDyQkJEAgEGDQoEG4e/eurk1iRHl5OYKDg9G9e3dkZ2fj 7NmziI6OFr38ZmnaTJ48Gc7Ozti4cSMqKyvx008/Yfbs2VKDB+rA4XDkHudyuXj9+rVEurR7tLe3 N0JCQjB79mykpqaitrYWRIT169cDgFpjTQ6HA19fX5w9exYFBQU4fPgwiAjjx4/HunXrAACGhoaw tLQEj8dDVVUV6M2qaBK/oUOHKlVmTEwMCgsL0blzZ8ydOxdJSUkyZf39/VFZWYk///xT7L7eunVr xMfHi/5XVVVh9+7diIuLk2pbQEAAAGDbtm2qNJNS+Pv7g8fj4eDBg3LlFi1aBC6Xi5SUFK3ZIsTQ 0BB8Ph8VFRUoLi6WOJ6VlQUAsLe3h6GhIczNzVFRUYGSkhIJ2by8PAndmuwXLI0PPT09TJgwATdu 3MDevXsRExODtm3bYs2aNaipqdFMIfKml2VnZ1P79u2pVatWWl/rkYUZ33zzjWhd2sa6p4k2N86W pVvbm3Wrq7+4uJhat25N77//vgatavx4enpKTIFWhcDAQLK2tm6wpSSa+vmqu471yJEj5cq+evWK zMzMCABNnTq1QXTJWj4gODiY9PT0KCAggG7fvk3l5eWUl5dHUVFR1LVrV7K1taXY2Fi5NugCTbbR hx9+SFwul9asWUPPnj2j8vJyevDgAS1evFi0Frms8uu2a2VlJd24cYMGDBhAACgwMFD9irKozcWL F4nP59Pw4cMbfFnDwsJC6tSpE7m6utKjR48atGwWyeu0urqaMjMz6fDhwzR06FACQH5+fhLLlDBF mr/S1J9pjRFp/g3bzoppCm2k7TGFrmBaL2WWfOLz+ZSYmCiRrqo/p0yZ9ccE8vLU1NTQwoULicfj UWBgIN27d48qKiooMzOTzpw5Q8OGDRP5b3XHGKr6VQ8ePCBvb2/q0qULWVhYkJ6ensx6sDQMeXl5 1LdvX7K3t28ye29fvHiR3NzcyMrKirZt20a1tbW6NolFC4SFhREA+uGHH8jCwoKeP38uVU7REov1 0+tiZ2dHvXr1Ev1v27Ytbd68Wey/g4ODWJ6MjAzS19cXG3NWV1cTl8sle3t7iTJWrVpFACg6Olos nckSi3w+n+7duycmV1ZWRhwOhzw8PERpn3zyCQGgmJgYCb2rV68mZ2dnpd4XPXr0iFxdXSk5OZke P35MzZo1IxcXF8rOzpaQXb58OfXp00fqcn9ubm509epV0f+//vqL2rVrJ7Pc27dvEwDi8/lUVlYm StfkEotERCEhIQSA/vjjD6l5U1JSyMLCgiZPnqxUWbL62ogRI6Q+5wYPHkympqZiaUz2IJs0aRIB oAMHDojJ5uTkkImJiYT/ral+wdI0qKyspBUrVpCBgQH169ePUlJS1NYpcwbZ69ev4ePjg8rKSsTG xqJ169aaicixqE1tbS127NiBbt26AdDulwcsmoWIUFtbKzbVmEV5jhw5gvfff7/BvsSUd77MzMww cODABrFDHYyNjeHi4oKTJ0/K/LoXANavXw9nZ+cG0yWLlStXYvXq1YiIiMD69evRqVMnGBkZwcrK CqNHj0ZcXBxatGiBkSNHNsiXTkzRRBslJiZi7969mDlzJhYtWgQnJycYGRnBzc0NP/zwAz777DOl 7TEwMEDXrl2xd+9ecLlcrF+/XuKLK5aG591338X58+dx9epVRudTE3z66ad49eoVLl26BFdX1wYt m0USPT09CAQCjB07FufPn8eiRYsQGRmJDz/8UOMzPlkfpGFg2/kN8vwkto3efrTtzzEZEyxbtgxh YWH45ZdfsHbtWrRr1w6GhoYQCAR47733cOrUKYwcOVKpcpXxq5YtW4b+/fvj+vXrGp8JwqIaVlZW OHPmDBwdHTF27FipMxIaE5s2bYKnpyc6duyI5ORk+Pn5KZwFxNI0mTNnDvh8PpYuXQofHx84Ojpq vIzu3bsjNTUVz549w9WrV/Ho0SMMGjRIdHz48OF4+fIlNm7ciJKSEjx8+BDz58+XWMZOT08PQ4YM QWZmJkJDQ/Hq1SuUl5fjwoUL2LRpk0Zs/fTTT3Hr1i1UVlYiOzsba9euBRHBw8NDJPPjjz/Czc0N n3zyCU6ePInCwkLk5eVh8+bN+P777xEWFqbw2VBSUgIfHx/8/PPP6NChA1q2bImDBw/i5cuXmDBh AqqqqkSykZGRWLFiBf755x+Ym5tLzCquv3zrtm3b8Mknn8gsu1OnTujduzcKCwvx999/q9hSilm6 dCmCg4Px6aefIjg4GKmpqXj9+jVevHiBP/74A0OHDkWXLl3wxx9/aM2G+vz4449wdXVFQEAAjh07 huLiYqSmpuKjjz5CRkYGwsPDRUstrlq1CtbW1ggICEB0dDRKSkpw9+5dTJs2Teqyi5roFyxNBwMD A3z77be4fv06qqqq0KdPH5w5c0Y9pbIiZ0FBQWRmZqa1zc9YVOfkyZPk4uJCiYmJBIAEAkGjjISz M8hYhGhiBtm9e/cIAB08eFBDVqmHos1uGwM3btwgU1NT+vXXX+V+jZSfn0/W1tYUGRkpd9aXJnVJ 05GWlkY8Ho+6d+8ut16XLl0iAPTee+/JlWtoNNVG27ZtIwAUFhYmNX9MTIzSM8jq4ujoSADo/Pnz DGvGoi2OHj1KHA6Hdu/e3SDl/f7778TlcunMmTMNUh6LJIqu09raWurTpw8BoD179qhcDuuvNAya miH/NtIU/CR5vK3XkDZmkNVHXX9OUZnSxgSy8ty7d4+4XC716NFDri1XrlxRagZZXWT5VXVnBDg6 OrIzyBoRz549o2bNmtFnn32ma1NksnDhQuJwOBQSEsLOGvuPEBgYSAAoKSlJ4tihQ4dEM1yFv6lT p9LVq1cl0mW93k1JSaFBgwaRqakpOTs7U0REhNjxgoICmjVrFjVv3pyMjY1p4MCBlJiYSD169BDp DQoKIqI3s3f8/f3J2dmZ9PX1SSAQkJ+fHwUHB4tke/ToQaGhoRK2LVmyRGZ9iIhu3rxJ/v7+1L59 ezIxMSFra2vq27cv/fbbbxLXQm5uLi1YsIBatWpF+vr6ZGtrS8OHD5eYwSaNzz//XKz827dvU05O joRdISEhRET0/vvvS23rur+rV6/Ss2fPxNL69OkjUfbjx48l8goEAjI1NZVIf+edd+TWQ1qe0NBQ CbmEhATy9fUVnTNzc3Pq27cvhYeHK7WSibS+tmTJEtH76Lq/H3/8kS5fviyRvnz5cpG+V69eUUBA ALm6upK+vj7x+XwaMWIEnTt3TqLs+/fvk4+PD1lYWJCxsTH16tWLjh07Rp6eniLdM2fOFMmr0y9Y mi4VFRXk6+tLPB6Ptm7dqrIeqXfQO3fukJ6eHm3atEllxSzaY+LEiaIbTJcuXQgAHTlyRLdGSYEN kLEI0cQLpNWrV5OhoaHUae26oCm8+BEGbCoqKsjR0ZE4HI5Ux3vFihU0bdo0kTMjL0CmKV3SXjh8 /fXXIsdKEQ4ODgSAHj58qFC2odBUG504cYIA0IgRIxiXL+9FjrDNrly5wkgvi3b54osvqFmzZlRQ UKDVcrKzs8nc3JyCg4O1Wg6LfJR52bxz504CQAMHDlS5HNZfaRjYAJlsmoKfJI+39RrSZIBswIAB tG3bNol0df05RfdJaWMCWXm++uorAkCrV69WaEt9NOFXsQGyxseePXuIw+HQ9evXdW2KBOvWrSM9 PT21PpBhYWFhYWH5r1FbW0tLly4lHo9HJ0+eVEmH1CUWV6xYgc6dO2P27NnSDrPokLy8PERFRWHG jBkAgI8//hgAsHXrVqnyubm5WLBgAdzc3GBoaAgnJycMGzYMkZGRKC8vZyyXk5ODefPmoWXLljAw MICtrS3Gjx+PmzdvqlWv6upq7N+/H++99x7s7e1hbGyMzp07Izw8XCvLr9TfqDoxMRGenp4wNzeH iYkJhg4diri4OI3afvjwYbGp2BUVFVLTnzx5gsmTJ8PS0hI2NjYYPXq0xLRtadTXc//+fUyaNAk2 NjaitFevXgFQ/jwyPS8pKSnw8fEBn8+HqakpBg0ahNjYWKn2VlZW4ttvv0W7du1gYmICa2treHt7 4+jRo1I3WTx69Cg8PDxgZmYGHx8fsbrWXcLn3Llz4HA4iIqKEqUFBASIyR88eFBhW/3+++9Sz5ew 75SWliIuLk50vP50bWXbmGk7qIKhoSECAwNBRPjhhx/EjpWUlGDDhg1YvHhxg+uqz8WLFwEA7u7u CmWFMpcvX1YoW/f+ZmBgACsrK4wcORIXLlwQyTC5fhShbhsNGjQI9vb2OH36NEaOHImYmBi174Pp 6enIyMiAhYUFOnbsqJYuFs0SEhKC2tpahIeHa7Wc9evXw9TUFEuXLtVqOSzqI3ymxcfHiy3xoo4P Js0HKSgokFgmZuXKlQDePP/rpk+YMIGRHercU1X10VSxS1mfS1n/RtO+Xt1yTUxM0Lt3bxw7dgzD hg0T6Zo1a5as064QZZ6PTM+HIj9JVhsxsUmV9tTmWIOp7qYyPlMVbflzQuqOCRRx6dIlAECXLl2U 1q8MrF/VdJkyZQp69eolet41Fi5evIjAwECsXbsWH374oa7NYWFhYWFhaTJwOByEhIRg2rRpmDJl Cp4+fcpcSf2IWU5ODhkYGNDOnTvVC9+xaIUNGzbQ0KFDRf9zcnJIX1+feDweZWVliclmZGSQq6sr 2dvbU1RUFBUVFVFmZqZos8b169czknv58iW5uLiQQCCg48ePU3FxMd25c4cGDx5MRkZGEl/PMflC MSoqigDQqlWrKC8vj3Jycuj//u//iMvl0sKFCyXkNTWDzN3dnUxNTalfv3505coVKikpocTEROrS pQsZGBhIbPAoTT9T2xVtsDp27FiRLdHR0aKpxMoi1DN48GC6cOEClZaWUnx8POnp6VFOTg6j88ik bmlpaWRpaUmOjo505swZKi4uplu3btHw4cOpZcuWEl9Yz5o1i/h8Pp05c4bKysooMzOTFi5cSADo woULYrJZWVnE5XLFZrVGREQQAImlyYQbf9bfbPTQoUPk6enJqK3qytQ/X/K+jGbSxkzagSnCGU1E b5Z7EQgExOVyxZbOXb16NU2aNImISKkZZJrSBSlf5DZv3pwA0D///KOwbtOmTRP1TXkI728CgYCi oqKosLCQ7t+/T+PHjycOh0O//fabmLwyfUIWmmyjy5cvk7Ozs2jpADs7O5o6dSrt2bOHSktLZZZf v11fv34t2kzewMCAduzYIbcOLLph0aJF1KJFC60tpVNTU0MODg60bNkyrehnUR5lZpCVl5eLrv2X L18SkeZ8MGnPNC8vL+JyufTgwQMJ+X79+ol9yc7UDnXuqUx8NFXtUsbnYurfyGpnTZR7584dGjZs GNna2qo9c43p85Gpz6xoBpm0NlL1ma1Me2pqrCENJrqb0viM6H/3LFk/aTPI1PXn5N0npY0J5OVh Ykt9NOFXsTPIGie7d+8mfX19ys7O1rUpIvr160ejRo3StRksLCwsLCxNlsrKSmrdujXNmjWLcV6J ANmff/5JPB6v0SxjxiJO9+7dJRzxcePGESC5X40wULB//34JPV5eXqKBlbJyM2bMkBqQyMjIIEND Q4m13ZkOLIcMGSKRPm3aNNLX16fCwkKldKsSIANAN27cEEu/desWASB3d3eF+pnaruilSVRUlFj6 hAkTCIDCF0n19Zw4cULqcSbnkUndJk6cSIDkHmEvXrwgQ0NDiRc5rq6u1L9/fwndbdu2lQgM/f77 78ThcOjFixeitNzcXDIwMCAvLy9RWllZGVlZWVHr1q3J2NiYioqKRMfGjRtH27dvF9OrqK3qyjAJ kDFpYybtwJS6ARsiojVr1hAAmjZtGhERlZaWkkAgEC0DqGyATBO65L3ESEhIUFg34QsVRcv3CO9v e/fuFUuvqKggBwcHMjY2pszMTFG6Mn1CFppsI6GN27dvp7Fjx5K5ubnoZZSNjY1EfYTly3qBNW7c OKkvv1kaB8I13LW172tycjIBoGvXrmlFP4vyKBMgKysrkwiQacoHk/ZMO3v2LAGguXPnisnGxsZS ixYtxPbkYWqHOvdUJj6aqnYp43Mx9W/q6lfH15NVbnZ2NpmYmKgdIGP6fGTqM6sSIFP1ma1Me2pq rCENJrqb0viMSLWo/t21AAAgAElEQVQlFtX15+SVKW1MIC8PE1vqowm/ig2QNU6KiopIT0+v0ext HRsby/ppLCwsLCwsGiAyMpL09fUpIyODUT6JJRbv3LmDtm3bKrVkAUvDcuvWLaSlpeGDDz4QSxcu s7ht2zax9EOHDgEARo4cKaHr5MmTCAgIYCR3+PBhcLlcjB49WkzG3t4eHTt2xPXr1/H8+XNVqobR o0eLLZ0ixN3dHVVVVUhOTlZJrzKYmpqia9euYmmdO3eGg4MDkpKSkJGRITe/pm3v1auX2H9nZ2cA wMuXLxnp6d27t9R0JueRSd1OnToFABgxYoSYrIODA9q2bSuhw8vLC1euXMGcOXMQHx8vWk7w/v37 GDJkiJjskSNH0LNnTzg4OIjSrK2tMWrUKERHRyMzM1Mk16dPH3z++ecoLy/H33//DeDN0qQxMTEY P3681DaR1VaqwqSNmbSDusydOxc2NjbYu3cvHjx4gM2bN6Nv374qLTujSV1ChOc3NzdXoaxQpm6f kIbw/vb++++LpRsaGsLT0xPl5eU4ffq0RD5N9Al128jQ0BDTp0/H4cOHkZeXh3PnzmHKlCnIzc3F tGnTcOPGDan5xo4dC3rzAQyeP3+OyZMn49ChQ9iyZYvadWLRDl27doWenh5u376tFf13794Fl8vV +BJTLNpB6Hfo6+ujWbNmALTrg3l6eqJbt26IjIwUu/+GhoYiICBAbAlhVe1Q9Z6qrI+mql3K+FxM /RtlUKdcW1tbtGvXTqVy66LK81Fdn1kbNgHKtac2xxpMdDel8ZmqaMOfEyJtTKCMLcouky0N1q96 +zA3N4ebm5tW3zEw4dq1a2jevDl69Oiha1NYWFhYWFiaNBMmTAARydzuRxYSAbKCggJYWVlpzDAW zbF161YUFxfD1NRUbN39MWPGAACSk5ORkJAA4M2+RoWFhTAyMoK5ublMnUzlamtrwefzJfas+Pff fwEAaWlpKtWtsLAQ3377LTp37gwrKyuR3sDAQABAWVmZSnqVwdLSUmq6nZ0dACA7O1tufk3bzufz xf4bGBgAAOP9EUxNTSXSmJ5HZetWWVmJ4uJiGBkZSQ2uC9uyLhEREdixYwcePXoET09PWFhYwMvL S/RCQEhZWRnOnj2LsWPHSuiYPn06ampqsGfPHgDAzp07MX36dHz44YfQ09PD7t27AQB79+7F6NGj ZQb+pbWVqjBtY2XbQROYmZkhICAANTU1WL58OcLCwlTej0iTuoQMHjwYAJTaMyMpKQkA5AYRFd3f BAIBAIgCrHXRRJ/QZBvxeDx4eHhg7969CAoKQk1NDQ4ePKgwn6OjIyIjI+Hm5obQ0FBcu3ZNpfJZ tAuPx4OFhQUKCgq0or+wsBCmpqbQ19fXin4WzSJ05vv16wd9fX2t+2AA8PXXX6OsrAy//PILACA1 NRWXLl0S299KHTtUvacq46OpY5cin0sV/0YZ1C1X3bGaqs9HdX1mbdgEKOc7a3OswcRfbkrjM0XE xsbCz89PIl3T/pwQeWMCWQhtuXXrltJ55MH6VW8P1tbWKCws1LUZAIAnT56gZcuWujaDhYWFhYWl yWNqagpLS0vG4xKJABmfz9faCxoW1amqqsLu3bsRFxcn+oKt7k/4FaFwFpmhoSH4fD4qKipQXFws Uy8TOUtLS/B4PFRVVUm1gYgwdOhQlern7e2NkJAQzJ49G6mpqaitrQURYf369QAAIlJJrzLk5uZK 1S+8mBS9/NCl7Uxheh6VrZuhoSHMzc1RUVGBkpISiXLz8vIk0jgcDnx9fXH27FkUFBTg8OHDICKM Hz8e69atE8lFR0ejvLxc6mD4/fffh7W1NXbu3ImcnBzEx8fDx8cHAoEAw4cPx/nz55GRkYHt27dj +vTpGmnDuvZLg2kbK9sOmuLLL78En8/Hnj174O7ujp49ezYKXQDg7+8PHo+HAwcOyJWLjY3Fy5cv 4e3tjRYtWsiUU3R/y8rKAvDmK2ttoUobxcXFiV4ESkPYd/Lz85WywcjICKtWrQIRITg4WDnDWRqU 6upqFBUVSbzk1RQWFhYoLS1FdXW1VvSzaI7a2lpEREQAAD7//HMA2vfBAGDy5MlwdnbGxo0bUVlZ iZ9++gmzZ88WeznfEHbURxkfTZt2qeLfaAJF5aoTiBLqV+X5yMRnluUnadomZdGmv87EX25K4zNV 0bQ/J0TemECRLYo+Klq0aBG4XC5SUlIU6mT9qreDgoICWFhY6NoMAICLiwvS09N1bUaTx8zMTOJD AeHPyMgIXbp0QURERKN6P/NfoKSkROJ8XL16VWG+wMBAsTwrV64UHaupqcGmTZvQv39/8Pl86Ovr w8HBAaNGjcLGjRvx5MkTMV1s35DOvn37xNqBRTeEhYWJzoOTk5OuzWnylJWVoaCgALa2tozySQTI OnTogNTUVJSWlmrMOBb1iYqKQrNmzdC/f3+px2fOnAngzUyZ8vJyAMC4ceMAACdOnJCQ79atG776 6itGcuPHj0d1dTXi4uIk5NasWYMWLVqo9PKtpqYGcXFxsLe3x7x582BraysaVAvrok0qKiqQmJgo lnb79m28fPkS7u7uaN68ucy8urZdFZQ9j0zrJlwCRrgkkJBXr17h/v37EvKWlpaiQai+vj7ee+89 HD58GBwOB8ePHxfJHTlyBK1atUKnTp0kdBgYGGDy5Mm4efMmlixZgrFjx8LY2BgA4OvrK5q5k5GR AQ8PD2WbSClMTEzw+vVr0f933nlHtNQKk2tF2XbQFHw+HwsWLACfz1d7xpcmdQFA27ZtsXz5cvz7 77/YvHmzVJmysjIEBATAxsYGP//8s0Kdwvtb/basrKzEuXPnYGxsLLF8lSZRpY2ICNnZ2YiPj5d6 XPi1crdu3ZS2Y+LEiejWrRvOnTuH6OhopfOxNAy3bt1CTU0NOnbsqBX97du3R21trdaWcGTRHN98 8w0SEhIwbtw4TJw4UZSuLR9MCI/Hw/z585GdnY2ffvoJ+/btw7x58yTktG1HfZT10bRpF1P/RlPI KjczMxOpqalq61fl+cjEZ5bnJ2nSJmXQpr/OVHdTGZ8xoWfPnti3b5/ovzb8OUD+mEAWQluuXbuG rVu3SpW5f/8+Nm/ejEmTJim9fCnrVzVtSktL8eDBA3To0EHXpgAAunfvjhcvXohmVLKoRklJiWgJ +rpLo1ZWViI+Ph4WFhb44osvEBQUpGNLG5aSkhK0adNGYinehsLMzAxEJLY9QEhIiNw8ubm52LRp EwBg6tSpICKxsbSvry8+//xz+Pj4IDk5GcXFxbh8+TK6deuGefPmSXyUyvYN6UyZMgVEBE9PT4lj uu43/yUWLlwIIoK7u7uuTXkrEK7GNWDAAGYZ629KlpmZSTwej/bs2aPMHmYsDcTo0aNp7dq1cmV6 9+5NAGjXrl1E9GZzZldXV2revDkdO3aMioqK6NmzZ/TZZ5+RQCCgp0+fMpLLysoiNzc3atWqFZ04 cYIKCgooNzeXNm3aRCYmJhKbSDPZBNrDw4MA0Nq1ayknJ4fKysro/Pnz1KJFCwJA0dHRSulmuvG0 u7s78fl88vT0pCtXrlBJSQklJiZSly5dyMDAgGJiYhTqZ2q7oo3b66cHBQVJ3RRdFrL0CGFyHpnU 7cGDB2RtbU2Ojo505swZKi4upuTkZBoxYgTZ2dlJbCbP5/Np8ODBlJSURBUVFZSVlUXfffcdAaCV K1cSEVFNTQ3Z2tpSQECAzPpeuXJFtGH2hQsXROllZWVkbm5OACgoKEiltpIn4+XlRXw+n9LT0+nK lSvE4/Ho7t27jNtYmXYQMnXqVAJAjx49kmlvXW7cuEGmpqZKyRIRXb58mQDQ1KlTta4LMjZfJyL6 5ptvSE9Pj7766iu6c+cOVVRUUH5+PkVFRVG3bt3I0dFR6U2shfc3gUBAUVFRVFRURPfv36fx48cT h8OhLVu2iMkr0ydkoak2EqY7OzvT7t276cWLF1RRUUGPHz+m0NBQMjAwoB49elBFRYVE+fLa9fjx 4wSAunfvTrW1tYzrx6I9Fi9eTI6OjlRTU6MV/TU1NWRvb0/fffedVvSzKE/967SmpoaysrLo8OHD omfuJ598QmVlZWL5NOWDybvHFRUVEZ/PJw6HQ9OnT5dqP1M71LmnMvHRNGWXNJ+LqX8jT7+65d6+ fZu8vLzIxcVFarlM/ASmz0emPrM8P0lWW2jqmS2tPTU11pAGE91NaXxGpNi3ICLq0aMH7d27VyJd VX9OWpmKxgSK7AwODiZ9fX0KCgqi+/fvU2VlJT1//px+//13at68OQ0cOJBKSkoY6VTGr3J0dCQ9 PT2px1h0x759+4jH41FWVpauTRHRq1cvudcZi3LIu27T09OJy+USj8ej3NxcHVinG4qKiqhVq1Y0 cuRIndpx48YNMjY2JhcXFwJAiYmJMmWXLFlC7du3lzpWTkhIIAA0e/ZsqXnnzp1LNjY2Ustn+4Z0 PD09JfzKxtJv6mJqakoDBgzQtRlag6mPxiLJ69evqV27duTn58c4r0SAjIho3Lhx1LNnT/YFWiPg 2bNnopf/AKhPnz4SMo8fPxaTAUACgYCIiF69ekUBAQHk6upK+vr61Lx5c5oyZQqlpqaK6VBWLjc3 lxYsWECtWrUifX19srW1peHDh4sN/EJDQyXsWbJkidx65uTkkL+/Pzk7O5O+vj4JBALy8/Oj4OBg kY4ePXrI1K1KmUT/uwHdvXuXRowYQebm5mRsbEyDBw+m2NhYpeqkrO2HDh2S0DF16lS6evWqTN31 099//32ZdZGmR0oMXOnzyKRuQu7fv08+Pj5kYWFBxsbG1KtXLzp27Bh5enqK5GfOnElERDdv3iR/ f39q3749mZiYkLW1NfXt25d+++030b0nNjZWIvAljTZt2lCLFi0k7ll+fn4EgJKTkxm3lazzJSQl JYUGDRpEpqam5OzsTBERESq1sTLtIMTDw4PMzMyourpabnsQvXEe6to+YsQIufLS2mPDhg1a1wWA QkNDJXQkJibSjBkzyMXFhQwMDMjc3Jx69uxJK1eupIKCAoX1r0v9+xufz6cRI0bQuXPnRDJMrh9p aLKNampqKDY2lhYuXEh9+vQhBwcH4vF4ojZYtWoVlZaWyi0fAE2ePFmi3IEDB4qOv83OZVOisLCQ mjVrRsuWLdNqOYGBgeTg4CAReGFpOKRdpxwOh/h8PnXu3Jk+++wzun79usz86vhgip5pQgIDAwkA JSUlqWWHuvdUIuV9NHXtUsbnUta/0bSvV7dcExMT6t+/P128eJGGDBlCJiYmEm3AxE8gUu75qOr5 kOUnKeqLqj6zFbWnumMNeTD1l5vK+EzaPUvWT1qAjIi5PyfLT5Q3JlDWt0xISCBfX1/ReTI3N6e+ fftSeHg4VVZWKtSprF8VFRUls51+++03uW3O0jD079+fvL29dW2GGNHR0cTlckXjARbVUBTYdnR0 JAB0/vz5BraMRfgx6a+//ir3HOXn55O1tTVFRkZK9Ve3bdtGACgsLExq/piYGMYBMqL/dt+QFiBr jLABMhZFzJkzh8zMzOjhw4eM80odqSYlJRGXy6WtW7eqbRwLS2OGvQE1bgIDA8na2pqqqqp0bYrO yc/PJ2NjY5o1a5auTWFhYdEgX331FVlZWVFeXp5Wy8nIyCBTU1MKCQnRajksLJqC9dFk884771CL Fi3E0rTtJ7Dng0WXsGMCFk1x8OBB4nA49M8//+jaFAl+/PFH4vF49Ndff+nalCaLoiCIg4MDAaAr V640sGUswgBZRUUFOTo6EofDkfpB1ooVK2jatGkyV1s5ceKEUh+kSiuf7RvSYQNkjQPW11aPkJAQ 4nK5dOTIEZXyS+xBBgBdunRBQEAAAgICkJaWJk2EhYWFRescOXIEo0aNAo/H07UpOoWIMG/ePFhY WChcr5uFhaXpcPr0aYSHh2PdunWwsrLSaln29vb47rvvsHLlSrE9AFhYWBonmZmZsLa2RlVVlVj6 kydP8PDhQ7G9VVk/geVthx0TsGiCjIwMzJ07FzNnzkTv3r11bY4EwcHB+PTTTzFx4kT89NNPujbn rSM9PR0ZGRmwsLCQ2Pc3JycH8+bNQ8uWLWFgYABbW1uMHz8eN2/elNCTm5uLBQsWwM3NDYaGhnBy csKwYcMQGRkptvdkXTkDAwNYWVlh5MiRuHDhgoTOlJQU+Pj4gM/nw8TEBL1798axY8cwbNgwcDgc cDgczJo1S7RXufD35MkTTJ48GZaWlrCxscHo0aPx8OFDkd768hUVFaJjlZWV+Pbbb9GuXTuYmJjA 2toa3t7eOHr0KGpqalRuH0UYGhoiMDAQRIQffvhB7FhJSQk2bNiAxYsXy8w/aNAg2Nvb4/Tp0xg5 ciRiYmJQW1vL2I66yOobTNpIWZieQyFM+pMs6vYzU1NTDBo0CLGxsQptFPab+un379/HpEmTYGNj I0p79eoVAM1eU2FhYeBwOCgtLUVcXJyoLGV8gurqauzfvx/vvfce7O3tYWxsjM6dOyM8PFxqv1Hl +pYnp8lrh0U61dXV8Pf3x3fffYeNGzdizJgxqimSFTkrLy+n3r17U9u2bRvV2swsLJqEjdCzNAUy MjJowIABdOfOHV2bwsLCoiFu3bpFlpaW5Ovr22BlVldXk6enJ7m4uFBGRkaDlcvCogr/dR8tIyOD ANDHH39M6enpVFpaSv/88w/17t2brK2txZYOaQg/4b9+PlhYWJo2paWl1LdvX2rXrh0VFhbq2hy5 rFu3jvT09Gjy5MmUnZ2ta3OaFNJmCb1+/Zpu3LhBAwYMIAMDA9qxY4dYnpcvX5KLiwsJBAI6fvw4 FRcX0507d2jw4MFkZGQkNqNIuD+kvb29aK/MzMxMCgkJIQC0fv16MTnhnpqFhYVie2rWXW41LS2N LC0txfYcvXPnDg0bNoxsbW3l7nU6duxY0b6g0dHRomWgZcnX3bNz1qxZxOfz6cyZM1RWVkaZmZm0 cOFCieVsmbSPonMj3K+7rKyMBAIBcblcsf1JV69eTZMmTSIi+XuaX758mZydnUXL19rZ2dHUqVNp z549ElsR1C2fad9Qto1Ugck5ZNKfZCGtn926dYuGDx9OLVu2VGlP3cGDB9OFCxeotLSU4uPjSU9P j3JycrRyTRGpNoNMuOzxqlWrKC8vj3Jycuj//u//iMvl0sKFC6W2s7LXtyI5ptcO62szJzU1lQYO HEhmZmZ09OhRtXTJ3QwgIyODWrduTW3btqUnT56oVRALS2NC1T3LWFhYWFhY1CU+Pp6sra1pyJAh VFFR0aBlv3r1it555x1q27YtpaenN2jZLCzKwPpo/+Ps2bM0btw4atmyJRkYGJBAIKCpU6fSgwcP GswG9nywsLA0dYqKiujdd98lW1tbSklJ0bU5SnH69GlydnYmOzs72rdvn67NaTIIgyDSfuPGjZP6 /JwxYwYBoN27d4ulZ2RkkKGhodgeksI9zvfv3y+hx8vLS/RiXChXf3/GiooKcnBwIGNjY8rMzCQi ookTJxIAOnjwoJhsdnY2mZiYyA1cREVFiaVPmDCBAFBOTo5U+bqBDldXV+rfv7+E7rZt24oFf5i0 jzzqBsiIiNasWUMAaNq0aUT0JogtEAhEyy7KC5ARvWnL7du309ixY8nc3Fx0nm1sbKTui6lK31C2 jVSByTlk0p9kIaufvXjxggwNDVUKkJ04cUJqWdq4pohUD5ANGTJEIn3atGmkr68v9sEE0+tbkRzT a4cNkClPVVUVrV27loyNjalbt25069YttXUq3C07MzOTunXrRs2bN5e7YTcLCwsLCwsLC4t8zp07 R+bm5jR69GgqKyvTiQ1ZWVnk7u5OLi4ulJaWphMbWFhYWFhYWFi0TX5+PvXr148EAoFGXqA1JIWF hTRv3jzicrnUt29fiomJ0bVJjR5ps4SeP39OkydPJgC0aNEiiTx8Pp+4XK7UmYXdu3cnAPTs2TOR LAAqKiqSa4c8OV9fXwJA27dvJyISBXeKi4ulli8vcFE/KPLVV18RAIl3t9ICHZ999hkBoNmzZ9PV q1epurpaZl2UbR951A+QFRcXk42NDenp6VFaWhqtW7dO7LwpCpDVpaqqis6dO0dTpkwhAKSnp0f/ /vuvRPlM+4aybaQKTM4hk/4kC3n9rHPnzioFyF69eiW1LG1cU0Sa3YNM+AFY3Vlcmri+68sxuXbY AJlyHD16lNq2bUv6+voUFBRElZWVGtErdQ+yuggEAly4cAFt2rTBu+++i3379inKwsLCwsLCwsLC Uofa2lqsXr0aXl5eGDduHA4dOgRjY2Od2GJnZ4dz587B1tYWAwcORHR0tE7sYGFhYWFhYWHRFrdu 3UK/fv3w4sULXL58GZ07d9a1SYywsLBAeHg44uPjYWJigiFDhmDMmDFISEjQtWlNCkdHR0RGRsLN zQ2hoaG4du2a6FhlZSUKCwtRW1sLPp8vtr8Sh8PBv//+CwBIS0sTyRoZGcHc3FxmeYrkBAIBgDd7 jVZWVqK4uBhGRkYwMzOTkFW0RzGfzxf7b2BgAABK7ckVERGBHTt24NGjR/D09ISFhQW8vLxw6NAh iboo0z5MMTMzQ0BAAGpqarB8+XKEhYVh6dKljPUAAI/Hg4eHB/bu3YugoCDU1NTg4MGDCvPJ6xuA cm2kLorOIZP+JAtF/czOzk4l201NTaWWpelrSh0KCwvx7bffonPnzrCyshLZERgYCAAoKysTs1vd 67u+nDaunf8iRITjx4+jd+/e8PHxQa9evZCSkoLVq1eLrhl1URggA95csKdPn4avry8++ugjTJ8+ HUVFRRoxgIVFVW7evClxk2ndurWEXEFBgYRc/d/Vq1cVlhcYGCiWZ+XKlQDePNgV6Rf+hA/cTp06 SRybMmWKqKy6m7FyOBz07NlTZllhYWHo2rWr0jbUtV0Z0tLSwOFw0LdvX5kystqAy+XC1tYWPj4+ SExMVJgnLCxMQndiYiL8/Pzg6uoKY2NjWFtbo1OnTvjggw/w66+/St3AVBb29vYSZaakpIjJTJgw ARwOBy9evBBLX7p0qVi+1atXyz33RkZG6NKlCyIiIkBEStVdlfOoSv9TlqdPn2LMmDFN5n4fHByM /fv369oMFhYJnj17Bk9PTyxfvhyrVq1CZGSkUpsKaxMbGxucP38eHh4e8PLywpIlS1BdXa1Tm1j+ OzQWH64uTP2NmpoabNq0Cf379wefz4e+vj4cHBwwatQobNy4EU+ePFFolyaf+0x9LmX8lYayv77/ 5+TkJCEjfGmmSd9LFX9JGb8YYN4/1G2Xuly7dg1+fn5o2bIljIyMYGlpiV69euH7779HQUGBhLyy Prk8eS6XCysrK7i7u2Pu3Lm4fv263PZhYdE2mzZtQt++fWFnZ4crV66gTZs2ujZJZXr16oVz587h 1KlTyMzMRJ8+fTBo0CAcOnRIqUAIC2BkZIRVq1aBiBAcHCxKNzQ0hKWlJXg8HqqqqkBvVtmS+A0d OhSGhobg8/moqKhAcXGxzLIUyWVlZQF4827C0NAQ5ubmqKioQElJiYRsdna2BmovHQ6HA19fX5w9 exYFBQU4fPgwiAjjx4/HunXrRHVRtn1U4csvvwSfz8eePXvg7u4ueu8lj7i4OFFQSBpCW/Lz85Wy QVbfAJRrI23DpD/J0yGvn+Xl5WnUXk1fU0I4HA5je7y9vRESEoLZs2cjNTUVtbW1ICKsX78eAET+ oqau77py2rx2/itUVFRgy5Yt6NChA7y9vWFnZ4d///0Xu3btQqtWrTRbGNMpZ8ePHyeBQECurq50 6tQp5nPWWFg0zMyZM5XaD2HMmDG0Zs0a0f+6axCPHDlSbt5Xr16RmZmZzCne0qZr14fP51NiYqLo f2ZmJtnY2BAA2rVrl4T88ePHqU2bNhKbjEory93dnQ4cOCAm5+/vTwDo5MmTYumTJ0+mkJAQufWt yzfffCNqp+TkZJly0uwqKCigv//+m+zs7EhfX5+io6MV5hFSU1NDCxcuJB6PR4GBgXTv3j2qqKig zMxMOnPmDA0bNkxkV1VVldL12bJlCwGggIAAiWPV1dVkaWlJAOiPP/6QOJ6bm0uWlpb0+vVruXWo rKwUbfYKgAIDAyV0afI8qtL/FHHjxg1q1qwZbdiwQek8uubBgwfk6upKS5cu1bUpLCxE9OY+tnXr VrKysqL27dtLLPXRWNiyZQsZGxvTgAED6N69e7o2h+U/RGPw4VT1Nz788EPicrm0Zs0aevbsGZWX l9ODBw9o8eLFxOFwyMbGRmH9NfncV8XnUsZfaSj76/P48WMCIHUpHU36XvVR5C8p6xer0j/UbRci ouDgYNLT06OAgAC6ffs2lZeXU15eHkVFRVHXrl3J1taWYmNjVSpbnnx1dTVlZmbS4cOHaejQoQSA /Pz8JMYxLCza5uXLl/TBBx8Ql8ulZcuWaXRJtMZCTEwMeXt7E5fLJTc3N/rhhx/o+fPnujarUSDv XlZbW0vdunUjAHTmzBlR+ieffEIApC5huXr1anJ2dhY9/4V7D0nbF65r166idwxM9oyaNGkSAZB4 ngr3KWKy9F1QUBABoBs3biiU5/P5En5/WVkZcTgc8vDwUKl95FF/iUUhK1asID6fT3FxcWLpspZY FKZfvXpVajkrV64kALRlyxaJ8pn2DWXbSBWYnENN7EEmq5/l5OQo3OtO1hKL9dOFaOOaIiKys7Oj Xr16if63bduWNm/eLLPO1dXVxOVyyd7eXuLYqlWrCICYv8z0+lYkx/TaYZdY/B/Jycn09ddfk62t LRkaGtLMmTPpzp07Wi2TcYCM6M2L/fHjxxMAGj16NKWmpmraLhYWpYmNjSUA5OzsTDU1NVJlsrKy yMjIiF6+fClKu3HjBhkbG5OLiwsBkDsYXrJkCbVv316jATIiot27d4s2Eq37QMvLyyNnZ2cJJ0FW WdoKkNXU1Cbvg/kAACAASURBVJCjo6PIWVi4cKFMWXltsGvXLgJAHTt2VDrP4sWLpTo2Qqqrq2nk yJGMA2Tp6ekEgNq1aydxLC4ujkxMTAgATZw4UeL4vn37JGyVV4f09HTicrnE4/EoNzdXYb7GEiAr LCwkJycn8vf3lzimyXWftcHNmzeJw+FI3TCVhaUhiYuLo549exKPx6N58+Y1+peEt2/fpm7dupGB gQEFBwdTSUmJrk1i+Q/QGHw4VfyNhIQE0Z4U0pg7d26DB8iEqOJzyfNXGtp+IUwDZMrURV1/SVm/ WNX+oW67hISEEADatGmT1LylpaXUo0cPMjc3l3jhp26ArD6LFi0iADRmzBiqra1VSicLizpUVVXR zz//TBYWFtSyZUs6e/asrk3SOikpKTR//nzRPk6jRo2igwcPynxp/V9A0b3p+PHjBIC6d+8uujdl ZWWRm5sbtWrVik6cOEEFBQWUm5tLmzZtIhMTE7FxZUZGBrm6ulLz5s3p2LFjVFRURM+ePaPPPvuM BAIBPX36VExOIBBQVFQUFRUV0f3792n8+PHE4XDEfI4HDx6QtbU1OTo60pkzZ6i4uJhu375NXl5e 5OLiotUA2eDBgykpKYkqKiooKyuLvvvuOwJAK1euFMkxaR9F50ZagEwWigJkzs7OtHv3bnrx4gVV VFTQ48ePKTQ0lAwMDKhHjx5UUVEhUT7TvqFsGxERTZ06lQDQo0ePlKofk3PIpD/JQlo/S05OphEj RpCdnZ1GA2TauKaIiLy8vIjP51N6ejpduXKFeDwe3b17V269PTw8CACtXbuWcnJyqKysjM6fP08t WrSQCJAxvb4VyTG9dv7rAbL8/Hz6/fffqV+/fgSAWrZsSStWrFAY/NUUKgXIhJw9e5Y6depEBgYG tHDhQsrLy9OUXSwsjGjTpg0BoNOnT0s9HhoaSqNHjxZLEz6gf/31V7kPyvz8fLK2tqbIyEi1AmSy GDNmDAGgDz74QJQ2depUqZuEMilL1gsKJpw8eZJcXFwoMTGRAJBAIJAZjJJn14sXL0Rf2+bn5yvM c+/ePeJyudSjRw+59l25coVxgIyIRC/K6j5siYi+/fZbWrBgAZmZmZGVlZXEF4cff/wx/fLLL2Jp is6Ho6MjAaDz588zyidEmfOoTv+TxpIlS4jH49GLFy8kjjX2ABkR0cSJE8nJyYlxv2Bh0QRPnz6l qVOnir4sbEobwldXV9PGjRvJ0tKSWrRoQQcPHmRfbLJoHV36cKr6G9u2bSMAFBYWJlU+JiZGqQCZ NNR97jP1uYTI8lca2n4hqgbIiNT3vWShrF+sav9Qp13S0tKIx+NR9+7d5dbh0qVLBIDee+89xmUz ka+traU+ffoQANqzZ49SOllYVOXSpUvk7u5OhoaGtHTpUiorK9O1SQ1KZWUlHT16lCZOnEg8Ho9M TExo9OjRtH379kb/gZYmMTU1FT3/hL/JkydLyA0cOFB0XHgvzc3NpQULFlCrVq1IX1+fbG1tafjw 4RKzsYnezEwPCAggV1dX0tfXp+bNm9OUKVMkJg7Ul+Pz+TRixAg6d+6chM779++Tj48PWVhYkImJ CfXv358uXrxIQ4YMIRMTE5Hc1atXJeoonIVfP/3999+nQ4cOSaQLfaGbN2+Sv78/tW/fnkxMTMja 2pr69u1Lv/32m4T/z6R9lDk3I0aMkCtf32YAopVtampqKDY2lhYuXEh9+vQhBwcH4vF4ZG5uTj17 9qRVq1ZJ9HtV+waTNvLw8CAzMzOFs1aZnkMhTPqTLOr2M2NjY+rVqxcdO3aMPD09RWXOnDlTZr+R ZjsgPaygjWsqJSWFBg0aRKampuTs7EwREREK65yTk0P+/v7k7OxM+vr6JBAIyM/Pj4KDg0X21x0H qHp9y5JTph1CQ0Nl9om3ndLSUjp69Cj5+vqKZjJOnDiRjh492uAzwNUKkBG9+VInIiKCbGxsyMLC ghYvXkzZ2dmasI2FRWl++OEHAkBTpkyRerxDhw70119/iaUJX65UVFSQo6MjcTgcSkpKksi7YsUK mjZtmswvWIS6ZA0SBwwYQNu2bZNp+8uXL8nKyoqAN9OdDx06RB07dpT44kWZsuqiiQDZxIkTafny 5URE1KVLFwJAR44cYWzX8+fPRTf6goIChXm++uorAkCrV69W2XZ5CPXXn47du3dvunDhgihoeeXK FbHjjo6OEl8EKTofDg4OUnU1VIBMUf+rT21tLQkEAplBsKYQINuzZw8BoMOHD+vaFJb/EA8fPqRZ s2aRgYEBtWrViv7++29dm6QyWVlZNGPGDOJwONSzZ086duyYrk1ieYvRpQ+nqr9x4sQJpV7wqIK6 z32mPpcQWf5KQ9svRJ0AmSq+lzL+krJ+sar9Q512+frrrwkA/fjjjwrLEbbPw4cPGZXN1NadO3cS ABo4cKBSOllYmBIfH08jRowgAOTl5cWubERvngHh4eE0YMAA4nK5xOfzadq0abR//36xjyZYmgbv vPMOtWjRQtdmsCggPz+fjI2NadasWbo2hYWl0fPixQv67bffyNvbmwwNDcnAwIBGjRpFkZGROn1O caEmPB4Pc+fOxZMnT/D9999j27ZtcHV1xfz58/HixQt11bOwKMX06dPB5XJx+PBhic2n//nnH2Rn Z8Pb21tqXkNDQwQGBoKI8MMPP4gdKykpwYYNG7B48WKt2d68eXPRBpGff/45vvjiC2zfvh2GhoZa K1MZ8vLyEBUVhRkzZgAAPv74YwDA1q1bGeuKiYkBAHTs2BF8Pl+h/KVLlwAAXbp0YVyWMowYMQIA cPr0aVFaXl4eUlJS0L9/f6nH79y5AxMTE7i6uipdTnp6OjIyMmBhYYGOHTtqyHrtkpSUhKysLLi7 u4ulh4WFgcPhoLS0FHFxcaJN2Xk8HgDg8OHDYpu1379/H5MmTYKNjY0o7dWrV6iursb+/fvx3nvv wd7eHsbGxujcuTPCw8PFNpkWlsfhcODk5ITExER4enrC3NwcJiYmGDp0KOLi4qTWoWvXrgDEzx8L i7Z4+PAh/P398c477+Ds2bNYu3YtkpOTMW7cOF2bpjJ2dnaIjIzErVu34OrqCm9vb3Tt2hUHDhzQ tWksbyG69OFU9TcGDRoEe3t7nD59GiNHjkRMTIzYM0yXMPW5gKbpr8hCW3Vh4hfron9cvHgRACT8 N2kIZS5fvqxVmwYOHAgAiI+PR1VVlVbLYvlvcevWLUyaNAn9+vVDUVERjh49ipMnT6JNmza6Nk3n ODo6Yt68eYiNjcXTp0/x3XffIT09HVOnToWdnR08PDzw008/ISUlRdemsvx/MjMzYW1tLXGffPLk CR4+fAgPDw8dWcaiDESEefPmwcLCAiEhIbo2h4Wl0VFbW4vExEQsX74cPXv2hJOTE+bPnw8iwq+/ /orMzEwcP34cM2bMgKWlpc7sVDtAJsTMzAzz589HWloavv/+exw4cACtW7eGn58fEhISNFUMC4tU nJycMGzYMFRUVGDv3r1ix7Zt24Zp06ZBX19fZv45c+ZAIBDg4MGDuHfvnig9IiICHh4eaN++vVJ2 HDlyRCxIwOFwZL7Er8uMGTMwatQoZGdno3Xr1ujRo4dS5WmTPXv2oF+/fqKAkLANjx8/juzsbKV0 FBUV4dChQ1iwYAH09fXx888/K5Xv5cuXAAAbGxvVjFfA4MGDYWxsjHPnzqG6uhoAEB0djcGDB8PA wEAUIDt16pQoz+nTp0XpiqiqqsLNmzfx0UcfQV9fHxs3boSFhYXmK1IPVftfXe7cuQPgzTVVl4UL F4KIYGpqigEDBoDezEAWtZ+Pjw+ICGPHjgUA+Pv7Y+7cuXj27Bni4+Ohp6cH4E2bTpkyBR4eHrh3 7x6ePXuGOXPmYMGCBQgKCpIoz93dHQUFBZg/fz5WrlyJzMxMXLp0CXl5efDw8BC9EKqLo6OjWF1Y WDRNbW0tTp06BW9vb7Rt2xaXL1/G1q1bkZaWhvnz58PIyEjXJmqETp064c8//0RiYiKcnJwwadIk 9OrVC7t27cLr1691bR7LW4IufThV/Q0zMzMcOHAAzs7OOHXqFIYOHYrmzZtj2rRp2Lt3L8rKyhjp 0wSq+Fy68leESPNbhD8mHyQBzOqiir/ExC9Wt3+o0i7CD1OV6ctCGWH/1xb29vYAgOrqarx69Uqr ZbG8/dTW1uL48eMYPnw4unbtivT0dJw8eRJXrlyR+RHFfx0nJycEBATg4sWLKCgowF9//YU2bdog LCwM7du3R/PmzTFp0iRs2bIF6enpujb3P01+fj78/f3x7NkzlJWVISEhAZMnT4aFhQWWLVuma/NY 5JCVlYVHjx7h3LlzouceC8t/nUePHmHLli2YNGkS7Ozs0Lt3b2zevBkdOnTA/v37kZWVhaioKHz8 8cewsrLStbkANBggE2JqaooFCxbg0aNHCA8Px82bN9GnTx/07t0bkZGRqKio0HSRLCwA/vcl57Zt 20Rp5eXl2LdvHz755BO5eY2NjbFgwQLU1tZi1apVAICysjKsX78eS5YsUdqGsWPHigIHwt+AAQOU yiv84u3ixYs4cuSI0mVqi23btonaFACaNWuG0aNHo7q6Gjt37pSZr+6g3tLSErNnz0bfvn0RFxeH YcOGMbKBw+GobL88jIyM8O6776KwsBDx8fEAxANgbm5ucHNzQ2JiIvLy8kTHvby8ZOqsW28DAwN0 69YNdnZ2uHv3Lnx9fbVSj/qo0/+EZGRkAIDSX53LIigoCEOGDIGJiQn69OmD6upqNGvWDAAwZMgQ fPPNN7CyskKzZs3w5Zdf4qOPPkJ4eDiKiookdJWWluKXX35Bv379YGpqip49e4pe0M+fP19C3sLC AhwOR1QXFhZNkZ+fj3Xr1uGdd97ByJEjUVpaij///BN37tyBr6+vaEbl20aPHj1w7Ngx/PPPP3Bz c8PHH3+Mli1bIiQkROkPJlhY5KFrH04Vf2PgwIFIS0vD9u3bMXbsWJSXl2P37t346KOP0KJFC+zb t4+xTqao4nM1Bn9FiDS/Rfh7/Pixwvyq1kUVf4mpX6xO/1CnXZj0ZW352UKISKv6Wf4blJSUICIi Au3bt4e3tzc4HA5OnDiB+Ph4pT9eZHnzns7b2xubN2/G8+fPceXKFcydOxfZ2dn48ssv4eLigo4d O+KLL77Avn372NWgGhB7e3ucPXsWBQUFePfdd2FlZYUxY8agTZs2SEhIQKtWrXRtIosc7O3tERsb 2+Rn4LOwqMP9+/exdetW+Pn5oUWLFnBzc8PXX3+NsrIyLF26FLdu3UJmZiZ27NiBiRMnwszMTNcm S6DxAJkQIyMjzJkzBzdv3sTly5fh5uYGf39/ODk5YcGCBbhx44a2imb5j+Lj4wNLS0skJiYiOTkZ APD333+jdevW6Ny5s8L8c+fOhY2NDfbu3YsHDx5g8+bN6Nu3r9aW+avL5cuX8ffff2PdunUAgE8/ /RT5+flaL1cWt27dQlpaGj744AOxdGkvsOpTd1BfW1uLV69e4ciRI+jVq5fS5Ts4OACAVr82rT9L 7MyZM2IBMC8vL9TW1iI6Ohrl5eVISEjAkCFDZOqrW+/nz59j8uTJOHToELZs2aK1OmgD4UcM8r7W V4bevXtLTR89ejQuXLggke7u7o6qqirRtVsXU1NT0bKJQjp37gwHBwckJSVJDYTxeDyUl5eraD0L y/+ora1FTEwMPvnkEzg5OeG7777D8OHDkZycjPPnz+ODDz4Al6s1d6pR0bt3b+zbtw+PHz/GjBkz EB4eDhcXF/j5+eHSpUvsy1AWldGVD6euv2FoaIjp06fj8OHDyMvLw7lz5zBlyhTk5uZi2rRpWh/v qOJzvS3+CtBwdVHVL27I/iHsy7m5uQplhTLCPNpC6J/p6+uLPpJiYVGWpKQkBAQEwNnZGYsWLcKQ IUNw584dhR8tsihGT08P/fr1w7JlyxATE4P8/HycOnUKo0aNQkJCAnx9feHk5AQ3Nzf4+fnhjz/+ wL179xrNUsJvI56envj777/x+PFjVFZWIjMzE7t27YKbm5uuTWNhYWERo6qqCteuXUN4eDgmTJgA e3t7tGvXDl988QWePn2KmTNnIjY2Fvn5+Th27BgCAgKUGs/pmgZ5ozNw4EDs3bsXT58+RUBAAKKi otC9e3d06tQJa9aswbNnzxrCDJa3HCMjI0yZMgXA//YD2Lp1q8Ivj4WYmZkhICAANTU1WL58OcLC wrB06VK17YqNjYWfn5/M4yUlJfDz88OWLVvw1VdfYeTIkcjMzJQ6M6ah2Lp1K4qLi2Fqaiq2rMuY MWMAAMnJyVpdOnXw4MEA3ryQ0BbCgdXp06dx+/ZtGBkZiTmgdfchu3jxInr27AlTU1OldDs6OiIy MhJubm4IDQ3FtWvXNF8BJVHU/+ojXBpO3b0iZLVVYWEhvv32W3Tu3BlWVlaivhUYGAgAUpcdkrUO sZ2dHQBIncFSXV0NY2NjVc1nYcHdu3exePFiuLq6YujQoUhKSkJoaChevHiBiIgIdOjQQdcm6gwn Jyf8+OOPSE9PR3h4OO7cuYPBgwejTZs2CAkJYZfpYWGMrnw4TfobPB4PHh4e2Lt3L4KCglBTU4OD Bw+qrVebNCZ/RV3UrYs8f0kTfrG2+4ewL9+8eVOhbFJSEgDI/fBLE8TGxgIA+vXrp/aHVyz/DXJz c7FhwwZ0794dXbt2xfHjxxEUFIT09HTR0kwsmsfExAQjRoxAaGgoEhISUFBQgMuXL2POnDnIzc3F 119/jQ4dOoDP52PgwIGYP38+duzYgeTkZDZoxsLCwvIWU1NTg+TkZOzYsQPz58/HwIEDwefz0atX LyxbtgyFhYX49NNPER0djby8PFy4cAHLly/HgAEDmtzqOg36ybO9vT2WLl2K1NRUxMXF4d1338Xa tWvRsmVLeHp64o8//mDXJ2dRC+GXnLt27cKDBw9w9epVfPjhh0rn//LLL8Hn87Fnzx64u7ujZ8+e 2jJVxNdff41hw4aJAjabN2+GhYUFdu7ciWPHjmm9/PpUVVVh9+7diIuLk7q0S0BAAAD5s8jUxd/f HzweT+GLg0WLFoHL5aq0yXD79u3h7OyM69evY9euXRJLdAwdOhQGBgY4ffo0Tp06xXgJDyMjI6xa tQpEhODgYMb26YrmzZsDeBPIkoa6y/F4e3sjJCQEs2fPRmpqKmpra0FEWL9+PQDpy/Hk5uZKTRcG xoSBMiFFRUUgIlFdWFiU5enTp1i/fj169uyJjh07Yvfu3Zg6dSqSk5Nx/fp1zJ07F+bm5ro2s9Fg YmKCOXPm4Nq1a0hKSoK3tzc2bNgAV1dXDB8+HDt37pR5L2FhqY8ufDhV/Y24uDgIBAKZ8kOHDgUA na4GoCxN1V+RhjbqoopfrIv+IezLBw4ckCsXGxuLly9fwtvbGy1atNBY+fWpra1FREQEAODzzz/X WjksTZ+KigocPnwYEyZMgIODAxYvXoyuXbvi0qVLSE1NRXBwsNb2pWaRjqmpKQYOHIigoCBERUUh JycH165dE+1ddvnyZcyaNQudOnWCjY0NPD09ERQUhAMHDii1PC4LCwsLS+OjbjBs3rx56N+/P/5f e3ce22Z5+AH868TOacfOZee+mjZnczQ9gKQH0FI2OsGOMqZRYDDGGGgCtIlSGGVTQROgcQw22ERh 0ygaEkilRVVVWBGkZ442aZqjR+7YOZzER2zHTpz390f1vj9fSdPTSfr9SK/svH5tP29iv++T5/s8 z6tSqVBcXIzHH38ctbW1WLZsGd577z2cPn0aJpMJBw4cwEsvvYT169fP++uwB2VOIJlMhltuuQV/ +9vfYDAY8Nlnn0GtVuPJJ59EUlISbrvtNrzzzjuc95gu2cqVK1FYWIjBwUH8/Oc/x913331JF/xT q9V45plnoFarr8roMU/Lly/3u97A/v37ceDAAbz++uvSuvT0dOnnxx57DCaT6aqW42L27NmDhIQE 3HLLLQEff+SRRwAAn3zyyTWbwm7JkiXYvn07amtrpZ7kvtra2vD+++/j3nvvRX5+/mW9z8aNGyEI At5++22/qTqUSiUqKyuh1+vx0UcfXdYc95s3b0Z5eTm+/vprHDhw4LLKeLUE+vwFUlxcDADo7e0N +HhUVBRcLpf0c15e3qynMnK73Th06BCSkpLw29/+FomJiVLgNtNnaXx8HDU1NV7rTp06Bb1ej9LS Ur8gTDx3iPtCNJPW1la88sorWL58uXRdrdLSUhw8eBAdHR145ZVX2GN5FkpKSvDGG2+gr68Pn332 GSIjI/HLX/4SOp0Od999N/7zn/8EvMYgkSgYdbjLrW8IgoDBwUHpOqa+xNFL5eXlsy5/MM2l+sqV utJ98a0vXU69OBifD/GzXF9fj/fffz/gNna7HU899RTi4+Px5ptvXvJ7yOXyWXdKe+6553D8+HH8 8Ic/xObNmy/5vWhhGx8fx+7du3H//fdDq9Xixz/+MYaHh/GPf/wDBoMBO3fuxOrVq6/5dfJodhQK BSoqKvDYY4/hn//8J+rr62GxWHD06FHs2LEDmZmZ2LdvH372s58hJycH8fHx2LhxI7Zt24b//ve/ aGxs9Pr/kYiIgmtsbAy1tbX46KOP8PTTT2PNmjXQaDQoLi7Gr371Kxw7dgzl5eV455130NDQALPZ jEOHDuHtt9/GAw88gMLCwgV3mYmg701YWBjuuecefP755xgaGsInn3wCrVaLbdu2IT09HTfffDNe e+01tLW1BbuoNE+I06McP37c62Las/Xiiy/CZDJN+4/w1WIymfDoo49i586dfiMSHn30Uaxfvx56 vR5PP/30NS2Hrw8//HDGKY2Ki4uxcuVKmM1mfP7559esHC+88AK2bt2KX//619i6dSvOnDkDl8uF vr4+fPDBB7j11ltRUlKCDz744LLfQwzF3G631JvXkxiKRUVFXda16GQyGXbs2AEA2Lp167y4Pk9p aSm0Wq00/Y6vZcuW4cyZM+jp6cGRI0fQ3t6O1atXz+q1Q0NDsW7dOvT39+O1116D0WiEw+HAwYMH 8d577037PLVajW3btuHIkSOw2Wyora3F/fffj7CwMLz11lt+24vTC91xxx2zKhfdWKamplBbW4s/ /OEPKCoqQkFBAd5++21UVFRg//79GBgYwAcffIB169YtuErf9aBQKHDPPfdg9+7d6O/vx3vvvYfJ yUk88sgj0Ol0uOeee/Dxxx/Pi5E1dP0Fow53JfWNe++9F7t27YJer4fT6URnZydef/11/OlPf0JF RQUeeOCBS96HYJiP9ZXpXO19uZJ68fX+fLzwwgt47rnn8MQTT+CZZ57B6dOn4XQ6YTKZsHfvXlRV VaG/vx/79+9HTk7OVX3vqakpDA4OYvfu3bj99tvx6quv4uGHH8bHH3/MkIMAXAhod+/ejS1btkCn 0+FHP/oRurq68PLLL6OnpwcHDx7Egw8+CKVSGeyi0ixERERg1apVeOKJJ7Bz5040NjbCYrGguroa 27dvh06nk0LQ0tJSREdHo6CgAD/5yU/w4osv4tNPP0VTUxODMyKia8hut6Ourg7//ve/8eyzz2LT pk3IyclBTEwMVqxYgccffxzfffcdCgoK8Je//AX19fWwWq04duwY3n33XTz88MMoKSmZd9MlXhZh jnI4HMKePXuEX/ziF0J8fLwAQMjOzhZ+85vfCF988YUwNjYW7CLSHGUwGAS5XC6kp6cLbrc74DbR 0dECAGnZuHHjjK/pua24/PWvfw34WjMtn3zyiSAIgpCamuq1/u6775bea3R0NOBz33jjjYDv9dpr r3mV9cMPPwz4fKvVOuM+9vT0eG2/atUqv206Ojr8Xlen0wUsV15e3ozvN5t9EQRBOH78uLBlyxYh PT1dUCgUgkqlEm666SbhrbfeEpxO54zvcTEmk0mQy+XCunXrAj5+4sQJAYDw0EMPzXoffvrTn/pt V1VVJT1eWVl5Vf+Ol/P5u5ht27YJcrlc6Ovr83ustbVVWL16tRAdHS2kp6cL7777riAIgnDkyJGA 7+lraGhIeOyxx6S/p06nEx566CFh69at0nMqKiqk7UtLS4XU1FShublZ2Lhxo6BSqYTIyEhh7dq1 QnV1dcDyb968WUhNTRVcLtes9pcWPqPRKOzatUvYsmWLoNVqBQBCZmam8NRTTwnffvvttOcKunpG RkaEnTt3CnfeeaegUCgEuVwurF27Vnj11VeFlpaWYBeP5ojrXYfzdCn1DbfbLVRXVwu/+93vhFWr VgkpKSmCXC4XVCqVsHz5cuGVV14RbDbbJe37lZz3L6fONZv6yvUqv28dyLeeDEB4/vnnr2hfLrW+ dCX14sv5fFzp78VTTU2N8OCDDwqZmZlCWFiY9L47duwQTCaT3/aX8rtpaWkJuL1MJhPUarWwdOlS 4fHHHxfq6uqm+aTQjaS7u1v4+9//Lnz/+98XIiMjhZCQEKGyslJ48803hd7e3mAXj64Dl8slnD9/ Xvjiiy+EP//5z8KWLVuEiooKITw8XAAgyOVyIScnR9i0aZPw7LPPCv/617+E2tpawW63B7voRETz htPpFJqamoRPP/1U2L59u7B582ahsLBQCAkJEQAICoVCKCwsFDZv3ixs375d+PTTT4WmpiZhcnIy 2EWfM2SCMPe7CLrdbhw7dgz79u3Dvn37UF9fj7CwMKxZswZ33nknNm7ciKKiomAXk4hoQTCbzSgq KsKmTZtmHNl1PZSVlcFoNE475aOvhoYGlJeXY9euXbjvvvuucelornK73aitrcX+/fuxb98+1NTU ICQkBJWVlfje976HO++887JGhdLVYTabsX//fuzduxf79u2D0WhEbm4uNm3ahLvuugtVVVXzfg5z IiKiG43b7UZNTQ327t2LL7/8EidPnoRSqcSGDRtw1113YdOmTTNen49uHE6nE62trWhpaUFTUxOa m5vRsT762gAAF39JREFU1NSE9vZ2uN1uKBQKZGdnY9GiRVi0aBFyc3Ol+zk5OQgPDw/2LhARXVdj Y2M4f/6813Lu3DmcP38e3d3dmJqaQlhYGPLz81FYWIji4mIUFBSguLgYOTk5N8YosCswLwIyX0aj EQcPHsSePXvw5ZdfYmRkBFqtFmvXrkVlZSWqqqpQUVER7GISEc1bJ06cwIYNG/DHP/4xqBdXv5SA rL29HRs2bMB9992Hl19++TqUjuaS9vZ2fPXVV9IyOjoKrVaLjRs34gc/+AE2bNgAjUYT7GKSj6mp KZw4cQJ79uzB3r17UV9fj4iICFRWVmL9+vVYv349ysvLOd0lERHRHBSo/pWVlYU77rgDmzZtwh13 3MEwg2bN6XSipaUFLS0tOHPmjFcj8ODgIAAgJCQEaWlpUmDmu6jV6iDvBRHR5RkaGpo2BBsYGABw YTpx32PgkiVLUFRUhNzcXAZhl2leBmSe3G436urq8L///Q8HDx7EoUOHYLPZkJGRgVtvvRW33XYb 1q5di8zMzGAXlYhoXuns7MSTTz6JXbt2ISYmJihluJSA7Nlnn0V5eTlHjt0ABEFAS0sLvvnmGxw8 eBDffPMNjEYj4uLisG7dOun8X1hYGOyi0iXq7u6WGtm+/vprDA4OIjExEbfffjvWr1+P2267DdnZ 2cEuJhER0Q2pv78f33zzDb766iscOHAA3d3diImJwbp167B+/Xps2LAB+fn5wS4mLUBWq9Wv4Vhc enp64Ha7AQCJiYlSo3FGRgbS0tKQnp4u3Y+Pjw/ynhDRjcpgMKC3txe9vb3o7u5GT08Puru7pSDM YrEAAMLCwpCVleXXASA3N5ejaK+ReR+Q+ZqcnERDQ4PUuFJdXY3x8XEkJyejoqICVVVVqKysxMqV KxEWFhbs4hLRVTKbC4Bv374dL7300rUvDF2x119/Hb///e+91j3//PPYsWNHkEpEwTQxMYHGxkZU V1fj0KFDOHjwIIxGI6Kjo3HzzTdzpNEC5tkzff/+/bBYLEhOTpbqc1VVVVi2bNmszgFENHusVxER AOj1ehw6dEiqg9XX1yMkJARlZWVS/WvNmjVsW6Ggcrlc6Ozs9AvOuru70dvbi+HhYWnbqKgoKSxL S0tDZmamFKKJQZpSqQzi3hDRfDQyMoKenh4p9BKDsK6uLvT29qKvrw9OpxPAhXp2UlIS0tLSkJGR 4ReEpaenIzQ0NMh7dGNZcAGZL4fDgZqaGlRXV+Pw4cM4fPgwRkdHoVQqsWrVKlRWVuKWW27BypUr ERsbG+ziEhER3fD0ej2OHTuG6upqHDlyBHV1dXC5XEhJSUFlZaV07i4vL+cUAjcQp9OJ48eP49tv v8V3332Hw4cPw2q1IjExEVVVVVizZg0qKytRVlYGhUIR7OISERHNK1NTU2hubsahQ4fw3Xff4dtv v0VPTw8iIiKwYsUKrFmzBqtXr0ZlZSUDBJpXHA6H1EgtNlj39PSgt7dXasweGxuTttdoNFJ4lpqa iuTkZGi1WqSkpECr1SIpKQlJSUmIiooK4l4R0fVgsVhgMBgwODiI/v5+9Pf3Y3BwUAq9xGOK3W6X nhMXFyeFX4EC+bS0NHYsmWMWfEAWSHt7u9QDqrq6Gi0tLRAEwW+U2bJly3jCIyIiuoasVisaGhpQ V1cnLc3NzQCAnJwcaZRQZWUlioqKglxamkvcbjdaW1tx6NAhfPXVV9LIQoVCgZKSElRWVqKiogIV FRX87BAREfkwm81SZ+K6ujocPnwYIyMjiI6ORllZGaqqqrB+/XpUVlYiMjIy2MUluqZMJpPXaA9x JEhPTw8GBgbQ39+PkZERr+colUopNNPpdFKQJgZoiYmJSE1NRWJiIiIiIoK0Z0Tky2azwWAwYGBg AIODg9Dr9RgaGkJ/fz8MBgOGhoag1+sxODgIh8MhPU8mk0Gr1UqBeWpqasAQjFnC/HNDBmS+BgYG UFNTg5qaGhw/fhw1NTUYHh6GXC7H0qVLsXLlSixfvhzl5eUoLi7mXJ9ERESXwWq1orGxEfX19dJ5 t62tDYIgIC0tDStXrsSKFSuwcuVKVFRU8CLbdEkEQUBbWxuOHTuGo0eP4siRIzh9+jQmJyeRkpKC VatW4eabb5bqdBqNJthFJiIiui7sdjsaGhpQW1srnSfPnz8PmUyGvLw8rFq1SjpPFhcXc4Q+UQBO pxNDQ0N+Deu+I0sMBoN0LSGRRqORQrO4uDjEx8cjLi4OCQkJiI+Pl372vGXbI9HF2e12DA8PY2Rk BMPDw36LuH5kZET6ftpsNq/XSEhIkILulJQUJCYmSkG35+hRrVbLqQ8XKAZk02hvb5fCspqaGtTX 18Nms0GhUKCgoABlZWUoKytDeXk5ysrK2MhCRETkwWAw4OTJk9Jy4sQJnD9/HlNTU4iLi8OKFSu8 luTk5GAXmRYgm82G2tpaHD16FEePHsWxY8dgMBggk8mQk5ODiooKLFu2TLqNi4sLdpGJiIiuiNVq xcmTJ1FfX4/6+nrU1dWhtbUVbrcbsbGxUhh20003YdWqVbzUBNE14HA4vEamiKGa0Wj0arQXf/YN 1IALI9TEsCw+Ph4JCQl+IVpcXBzUajVUKhViYmKg0WgQExPDRnyaV1wuF6xWK8xmM0wmk3TfM9zy /L54rvcc4SXy/I543k9ISPCbKjUxMZHTHRIDstmamprCmTNnvBr6Tp48icHBQQBAdnY2ysrKUFJS guLiYixduhS5ubk8KRER0YLmcrnQ3NyM06dP49SpU2hoaMDJkyfR398PAMjMzJQ6lYgdSzIzM4Nc arqR6fV61NXVSY2G9fX16OvrAwBkZWWhoqJCqtOVlJQgKysruAUmIiKahsFgwKlTp3Dy5Ek0NDSg vr4eZ86cwdTUFOLj4706gVRUVCAnJyfYRSaiACYnJ/0a/j1HwPgGA+L98fHxgK8XHR2NmJgYv+DM c51KpUJsbOy068PCwhAdHX2dfxM0n1gsFrhcLlgsFphMJlgsFlitVlgsFmnxXe8bhFkslhk/xxcL iQONvpTJZNf5N0HzHQOyK6TX66WwTKyUtre3w+12IyIiAgUFBSguLpZCs6KiImRkZAS72ERERJdk amoK7e3taGxslMKwpqYmnD17FpOTkwgLC0N+fj5KSkq8wjCOyKH5YGBgwCs0a2hoQGdnJwRBgFqt xtKlS1FSUoLS0lKpM5RSqQx2sYmI6AbhdDql+ldjYyMaGxvR0NCAoaEhAEBKSgpKS0uxbNkyKQxj hySihc9ms3mFD2IY4RtIjI6O+oUXnuvdbve07xEdHY2wsDBoNBooFAqoVCpERkYiIiICMTExUCgU UKvVCA8PR1RUFJRKJRQKBWJjY6FQKKBUKhEVFYXw8HCo1WqEhIRI6wFIzwMgvS5dOpvNBpfLBeDC SOLJyUkAF643OTU1hYmJCYyNjcFut8PpdMJsNmNiYkIKqBwOB6xWKyYmJmAymeByuWCz2aTXNZlM mJiYgNVqhcPhmDbUAi78TcXANTY21it8FQNZMbT1fEytVkOj0Ujr+Fmg64UB2TXgcDjQ3NyMpqYm r0bE3t5eAIBarUZhYSEKCgqQl5eH/Px85OfnIycnh3N9ExFRUDmdTrS1tUlLS0uLdGu32xESEoLs 7Gyp00dJSQmKioqwZMkSKBSKYBef6KqxWCw4deqUNDKysbERp06dgtVqlb4HRUVFKCgoQGFhIQoL C5Gfn8/gjIiILptYD2tpaUFzc7N029bWhsnJSUREREj1r5KSEixduhSlpaVISEgIdtGJaB6z2+1e Adro6GjAQEWcCk8MSCwWCyYmJmA2m2cMWS6HGMwBgEqlktpLxZANgDRFbEhIyLTXr/Z8nUBmeq5I DPgASL+P6QiCAJPJNOPrTRcweT7X7XZLU2+KfwvgwnnCbrfP+DqzMV24KYah4ghCz4A0LCzML/BU KBR+QRivn0fzDQOy68hkMqGpqQlNTU1obm5Ga2sr2tra0N3dDQAICwvDokWL/IKzxYsXc15wIiK6 qgYGBvyCsNbWVnR1dcHtdiM0NBTZ2dnSuaiwsBBLly5FYWGh1MOP6EYjCAI6OjqksOz06dNobW1F a2srnE4nZDIZMjIykJ+f7xWe5eXlIT4+PtjFJyKiOcJiseDMmTN+QZg4G41cLseiRYtQVFQkjdAv KSnB4sWL2amWiOYdcRTS6OgoAEhhGuAdOI2NjWFiYgIAvEa2mUwmCIIwqwDJl/ie0/Esy3TE9wcA uVwOlUo14/biKLrphIaGIiYmJuBjFwsAPd/fcxrMiIgIREZGAvAO9MSyiO/JUXpE/hiQzQFOpxPn zp2TKsSnT5+WAjSxp0VsbCxycnL8lqKiIiQnJwd5D4iIaC4aHR1Fe3u7tIjnl7Nnz0r/TISHh0sN MDk5OSgsLJQa9hmEEc2eXq+Xrscn3jY0NEj/rPvW5cTvWl5eHkedEREtQBMTE+jp6fGrh7W3t6Oj owOCIEChUCA9PV06J3jeig2dRERERHTtMCCbw9xuNzo7O3Hu3DmcO3cOZ8+exdmzZ3Hu3Dl0dnZK c8vGxcVh8eLFyM3NRXZ2NjIzM70WDm0lIlqYbDYbOjs70dnZia6uLnR1daGjo0M6V4gN85GRkcjN zUVubq50vhDvp6WlBXkviBYuQRDQ1dWFM2fO4OzZs2hra5Pui6M1ZTIZ0tLSsGTJEixevBjZ2dnI yspCdnY2srOzOW0WEdEcZjab0dHRgc7OTnR0dEj1sLNnz6Kzs1Ma/eB5nF+yZAmWLFmCvLw8ZGdn c0QYERERURAxIJunJicn0d3d7RWenTt3Dh0dHejq6pIaRWUyGZKSkpCVleUXnGVlZSErK4sjBIiI 5iiTySQFX75BWFdXF4xGo7RtXFwcMjMzkZ2d7ReEpaamQiaTBXFPiMiX0+nE+fPn0dbWJjWmnj17 Fh0dHejr65MaVZVKpV9oJi5ZWVnTTs9CRERXzuFw+AVg4v3Ozk6MjIxI2yYnJyM7OxuLFi1CXl6e FIYtXrxYmgKLiIiIiOYWBmQL1OjoKPR6PQwGg9f0Wu3t7dJ6UWxsLJKTk5GSkhJwGkde/4yI6NqY 6Vjd3t7uNV+6OD1boOP1okWLoNFogrgnRHQ1idNyTXd86OzsxNTUFICZ63GcvpGIaGY83hIRERHd 2BiQ3aAsFovfiATPkQlDQ0PSthqNBpmZmcjIyJD+IfC91Wq1CA0NDeIeERHNHS6XC4ODg+jp6fG7 HRgYkI65drsdwIXRvsnJydJoX99Rv1lZWbwOBRFJxBEN041q8AzXxRENaWlpSElJQVpaGpKTk5Ge no7k5GSkpqby+EJEC5LL5YLBYEBvby/0ej30ej16e3thMBjQ09ODzs5OvxG7043Wzc7O5ohdIiIi ogWIARkFZLfb/abz6uvrQ29vLwYGBtDX1weLxSJtHxoaCp1ON22AxiCNiBaCmYIvz9uBgQGv5yUk JCApKUk6HmZkZHgFYBkZGbxeJBFdNSaTyS846+npQX9/vxTUT05OStvHxsb6hWdJSUlSqJaamgqd ToeQkJAg7hUR0f8bHByUjmkGgwF9fX3o6+uTQrD+/n6v+phMJoNOp5OOaWlpadLU1GIAlpiYGMQ9 IiIiIqJgYEBGl81ut6Ovrw/9/f0z3l5KkKbVaqHT6RAfH88pKojoujGbzRgcHITRaLys4Cs1NXXG W4ZfRDSXTE1NSR2ePBuTxYZmcbSF50g0uVwOnU4nhWeeI9DEAC0hIQEJCQmQy+VB3Dsimq8EQYDR aMTQ0BCMRqNX+KXX66UQzGAwwOl0Ss9TKpV+x6Tk5GSv0F+n00GhUARx74iIiIhoLmJARtfc+Pg4 RkZGYDAYpLndA9329/fD8+MYERGB2NhYr0UM0wKtT0tLQ1hYWBD3lIjmAvGYMzo6Ki3iccZznbi+ t7cXLpfL6zUiIiJmHA0rjgJTqVRB2ksiomvP6XRieHhYui5PoPpbT08PrFar1/PEOpxvvS3Qz6y/ ES1sDofDrx423c9GoxETExNez/e9BqvvLa+ZTURERERXggEZzRl2ux0DAwMYHBzE8PAwjEYjjEYj hoeHMTAw4LVOXO/78VWr1dBqtVIP5vj4eCQkJHitE9fHxcVBrVazJyHRHDY+Pg6z2YyRkRGvY4A4 2ks8FniuGxsb83oNuVwuHQvERTwmeK4X12m1Wo74IiK6BJ7H4KGhIQwMDHiNAhkYGJDuG41Gr+kd gQsN4J51Na1WC61Wi8TERCQkJCAxMRE6nQ5xcXHQaDTsnEAUJHa7HSaTCSMjI9J33fO77fmzeOv5 /5pMJpO+057fbfG7L/4sPq7T6SCTyYK4x0RERES00DEgo3ktUI/EmUaM+I5SAy70co6MjAw4Ys13 CbRdYmIiQzaiaTgcDr/v5ujoKMbHx6d9zHc7X57fwUCjSn3X6XQ6XvuQiGgOEY//sxlVEmiULxB4 poHZ1t2SkpJ4PTW6IYnfvdnWwzyXkZERr2kNRZ6j7mcaLZqcnMz/m4iIiIhozmFARjeU8fFxqYfj 6OgozGaz32IymaRb8b64BPqnELgwck2j0UCtVk+7xMTEICIiAkqlEkqlEuHh4VCr1VLDjUajQURE BKKioq7zb4Xo/1ksFjidTlitVthsNjidTphMJqkhxWw2Y3x8HGNjYwG/I57fI9+RXKKoqKiA35HY 2Nhpv0uxsbFS72I2rBAR3VhMJhMGBwcxMjIinXs8F7FOF+ixQHW30NBQaDQaafE8/4iLSqVCZGQk NBoNIiMjpftiXY31NrpenE6nNHJrfHwcdrsdZrMZDodDuj8+Pg6r1er1nfD9LpjN5oBhs0Kh8Pv8 x8bGSvd9H9NoNIiLi5PqZRzhRURERETzGQMyoksgTvfmufgGbdMFBp7Bw8XExMQgPDwcKpUK0dHR CA8PlxpixAaa8PBwREdHQ6VSITw8HDExMYiKivIK2yIjIwEAGo0GMpkMcrlcmpYoKiqK08jNE3a7 XWrgM5lMEAQBk5OT0mdpbGwMTqcTZrNZ2nZ0dFRqUPH87Hlu63A4MD4+LjUg2my2i5ZF/GxFR0d7 NZyIS6Bwy3c7BlxERHS9iJ07AoVnMy1jY2NSKHGxf5fEDk9iBxDxPBkTE4PIyEjpvthRyvO+SqVC RESEVD+LiYlBaGgoFAoFlEolAEClUkEul1/z3xVdmqmpKZjNZgCQ6lQAMDo6CuBC/U2sZzkcDjgc Dun++Pg4RkdHve57juoS78/m8yfWzVQqlVTv8gy4Zgq6NBoNoqOjr+0vioiIiIhoDmNARhQENptN Cts8QwqxV+jFAg3f8EMc0TM2NuZ3YevZEAM0z8aY6OhohIWFAYB04euwsDDpn2ilUgmFQgGZTAaN RgMACA8PD9iTWnz96cx0Ye2QkBCo1eppHw8NDUVMTEzAx2ZqVBAEASaTadrX9Wz0CMQzoPJktVox OTnp9XyxkQO4MELL7XbD7XbDYrEA8G5UMZvNmJqamvb1L0YMRj0b6DxD1NkErmIji+e24khHIiKi G02gETwzjeaZzf3x8fFZdUzx5FnnEetpnvUkz85PYt0qUIepQPW1mepTvq8dyEx1uenqh+LvdTpi nSmQi9WTbDab32gpz/qYWN9yuVzS30F8v4mJCWkUvFi39qy3BXrti/Gsc3mOSJzufqCRihzBSERE RER09TEgI1pgxGBGHEnkGQR5NkRcLMi50qBH5NnIEIhnw8RcI/bino5arfa7hsmVBosXe1zsRe7b ICaOHCQiIqL5wzcsEzv3eNbZAoU5Yj3Nd0S5b5gTqD4YqL7mWcebrpxTU1NXd+ev0EwdsDzrXoHW ifUpz9kVxDpYoNDRs17m2WkoUOgo1g89QzFOQ0hERERENDcxICOiOe1ivYsDNfKIPMOqQMSGECIi IiK6PBfrDDXdDAcXmyWAo9eJiIiIiOhaY0BGREREREREREREREREN5SQi29CRERERERERERERERE tHAwICMiIiIiIiIiIiIiIqIbihxAXbALQURERERERERERERERHS9/B+hDeGJgGPJhgAAAABJRU5E rkJggg== --_002_4d0edf44bb7c85d9089079c999428ef6citrixcom_-- From xen-devel-bounces@lists.xenproject.org Fri Nov 11 17:37:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 17:37:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442675.697083 (Exim 4.92) (envelope-from ) id 1otXyX-0008Mr-A3; Fri, 11 Nov 2022 17:37:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442675.697083; Fri, 11 Nov 2022 17:37:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otXyX-0008Mk-7L; Fri, 11 Nov 2022 17:37:57 +0000 Received: by outflank-mailman (input) for mailman id 442675; Fri, 11 Nov 2022 17:37:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otXyV-0008Me-Bh for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 17:37:55 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2048.outbound.protection.outlook.com [40.107.93.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9141274c-61e7-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 18:37:53 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by SJ2PR12MB8136.namprd12.prod.outlook.com (2603:10b6:a03:4f8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Fri, 11 Nov 2022 17:37:50 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57%4]) with mapi id 15.20.5813.012; Fri, 11 Nov 2022 17:37:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9141274c-61e7-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JbEOqGd1niI7ePAOxiTbbesZWP+eky3avIWIeNgf44hYkjJxaV9ewhUKqiR3Mpt0pS8z6+cHTJqeJmA9qL+p22gTc+0VDHYvhmzG/K/muO8p217uC/6MN4ufwvC+hrRVjCHGw7NubQH+xzWemLGvnjenceR/w6NapgqkRGBQlDN3iaLx5mtLod5x3jFfSpKzdk1LKIdhBaYbTwyuEWXC+7Eo7rJsRJtJqro0A9GUXNxBxoS5ZK+bJgpSn2oBX9hiwWgdA006uVoyOrJ6Ih+mLsBKq5jDNr/Krm82KmLPi0kfe5NuCCwBaww1XnoknPBd70LB0g4R4on75J7pnNNgwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HJTSrsiM8tI7h3okmkI3MOEcRpPnaGaRUJzP//EFAps=; b=mGY78XAZyrM7sAU5bKVvjumYcmpnc+KUgmNeSimdfvD1QyiAK3mqZJU1l7NHzz55p26XbZP4cYfeP0vDAGJ0AhjB5z81VrVj8eGgc2V5+MXArnpVbN3hAmimhmrtlkNcswadzX/SqaQ/H7HbMN8Rc4/X/qmw/3gvFSSUBD4/bRpduQUxgRENute9t9oJWMSWhVOqERi06r9G49/gcT9lDBiogWIWYmsjDvOQHYj37LYiUpyNWmwwqA5mg+WgeXckf3hnRPiEQF6IkijWoJ+/XP30A7u77Alq91C+v42peRxmZ/Ldzl+AimPc601Yy0rQf0lMu6F8ZRKQHJhlD+ASdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HJTSrsiM8tI7h3okmkI3MOEcRpPnaGaRUJzP//EFAps=; b=qDCkHr9ZsvO8VWZNdPSE6PCKooLkVdHVBYRcZnlUVleS/Flg3CHNZdAia2jr8AtkarbFVOh6yO8BU4tc+G09o5ngNQSAOQcCU7lA83AfBIbFFHsLNZP/MlqIeSfNQSD7jkgmvjp7Ja4MAve3kt3j46B9YOqvQlVqnFFV6WzG4N4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <96e799be-fc98-3457-2243-c979162e8a79@amd.com> Date: Fri, 11 Nov 2022 17:37:43 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v3 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit To: Xenia Ragiadakou , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com, jgrall@amazon.com References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-12-ayan.kumar.halder@amd.com> <3ea29174-abb4-0fe9-fde8-28d4d62f2f67@gmail.com> From: Ayan Kumar Halder In-Reply-To: <3ea29174-abb4-0fe9-fde8-28d4d62f2f67@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0187.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::31) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|SJ2PR12MB8136:EE_ X-MS-Office365-Filtering-Correlation-Id: 37e1d83d-3e81-4037-4744-08dac40b7409 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E62z506K3Cswl/s2XIk0JeMoCQifIYoF9cmujzpr89wsPGCJFENftx6sEronC2XLtO89kv2XAUBU6xljM7JG3o0CJ8b/ya49df9E0GdygxV1UT6+cRvA/MPaphAE54YYLwiWX3fnV/MA13Bt8zqsbxAhXxI6hZ4YDrVOlDCTJUUMBgb6qgIOBeSE6akN5wZlR1+aQgFTNpRk+mhyV9SZFxK49HZmHg6uJCIeS0ZE9RjpX8ESLLSg445JgR15Jc7VZI4gb46ZsVQcgsMAfWAXsMXPS3YDVFuGSKbiPk50MwqORHr6XDpYt61D8hrzewDpZ+ThmCsFByqGO/Q7mo9II1rDECVFPH1LPu8JTCnqHgJHOUXa3W2avCbxT/qRY7zsw64jh3ojs6M2FoZez4/SCT0mdSRBOUi6CL2TN2LFjT24QnEqcTSIpUX16/S/ZRnN3xKRwFE2GRPeGG82yKH5zcU4S7ONEjmqQrrUl9hjd0wwj9Saa9oCG3ncpYpNlDbNBO1tYHmzXGq05Ew+CbzKiinrNx8anKP8gTpo9274Cz/v5EXn3dRos5qpTgg8F69RiwIUPLSRLArJbvIk13ibeD8MuUglVCaaHDU4XC0SWqudNKpIgFYb2Q2yrNtGJz+hSGwIEATn0w6KUe6t2PBpm91sI6CZDQbAPAafWjwnlOGrjaJhQlNyPS1UrL6SBZCnumxmNZ24xXvZFtX+Y8VyKBUG1rRSke3sBVGvsBZg6UGQ4NBh1dB1SBIGwcW2rjpY7AbLdLS930yBw69jeItIOfU4cRpmUZ8pbOkfarGwG04= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(366004)(39860400002)(136003)(376002)(451199015)(2616005)(36756003)(31686004)(31696002)(83380400001)(6512007)(2906002)(38100700002)(186003)(53546011)(6506007)(6666004)(26005)(66556008)(4326008)(8676002)(66946007)(316002)(66476007)(110136005)(41300700001)(8936002)(478600001)(6486002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWZMSXFkb3JMaXgvR1FsT1lleTlnUEZSTXJJVHRnOGw3TkxOaUFBZWx6aXdR?= =?utf-8?B?WVJDdytPNUd3RUVPZnBkRjliTE9PeTlidnRWSG5LaWZWQk54SHN1YVdRRzFJ?= =?utf-8?B?VGM4RzB0NjN5MjFvNnRCZmRsSWs0dEJnRE9IVCtSMnR2SkxZTFZja1hDZVJn?= =?utf-8?B?eUE2bmtQWEJaU2hYSTlQSmw5ajhqSm9MaDcwT2Jhek84eDlJZTI2ZlZYN1p4?= =?utf-8?B?eWU4MVAyZmJHQWRKZm5hbVhPVUpYUGZQTUZvWVVFWmtoV2pCUFVMbUxvT1pU?= =?utf-8?B?cllrQVpCNVZiUkJrTWQ5cFJvY3BjcGFiN3d3aXkrQTc1QjZFSGs4U2NXeGRr?= =?utf-8?B?NHh3TEFVM0N3RmR2WmhEaENjaDM1WE5jV0pXNjYvdWpXZmRGK2pyRDFodjh1?= =?utf-8?B?Q0VueU44Z1ltZ0dVYmNneTdZQkswQndXdWxGNnBMRXl0NnNmcTlTYVJmWk5p?= =?utf-8?B?emkrQ3ZPeDczMTR3WnA3WFNLSXpBZ1FGbkF4eGtYbmE2SVF1a1g0R3BrNE9P?= =?utf-8?B?a3lSY3AzVDBSN3ZCUmE3OXc5dFR2MTJiT2xiWUF3Nys4d2Y0NDRqM1VGUUJX?= =?utf-8?B?THFySkd1aC9hZlc5SkxFZTV4RmZESHRyU0dUOFJiMjJGUERFV21PQnNLd1Zm?= =?utf-8?B?Z1lZdzJMZERIdHY5SDVVK1hKYUFkcGpMWlhGRzlCVHkxVmdNalRDdnJOeWxv?= =?utf-8?B?T2ZHQThtc1d4UGhMUEZHUFFQby9CdG8yQzBjMHlia1ZEbGx1SlcrL0lPZEdW?= =?utf-8?B?R25STWpETXlHM0Z2K1pRdUYvcndGTnNZa2ErbUN0WjFONTM5M0dPN04zMHVX?= =?utf-8?B?STk5V0E4YU5WM0ZQWnQ3RDk5RENmOFhWNUw3SUt2WUdrbWYzak1RQkNLcGN1?= =?utf-8?B?OC9uY1pYUmhaeHNFV1V5Rk01Kzk1Q2hIZlhkNk1kRGhWUkJwMW44b0U5UGVy?= =?utf-8?B?NDNzajRvQ1A5WmQ4VGRpeTc4bHk5N1VVb0kvUmRkQ1Bva2ZrN0Y2ajQxYjVs?= =?utf-8?B?OWNYUXl1endNcFlSRVgzcHZkcVRxNUM4eDNtcFhodGxwbHNEY1hOSmlUOFVX?= =?utf-8?B?RmY4OGZrMXczcVdWUllYVHFwQ1RLVk50am5vY0E3WUI3dVZEblFPYUI0N3lh?= =?utf-8?B?QkJhTExBOC9WZFNNUTQ0OXFUNDVNR1pFQ3VoYVJEci90ekNJdnIxek9vZDlO?= =?utf-8?B?OEVybFp5czNQd1B1aHI5WWFLTTFMd0JKazRXWGUyMFJVYXhCS0FZUnpzeFNI?= =?utf-8?B?dktiQW1hNjBjNURIUldjS2Z6QTJxaTBIclVHekliSG8vMjZHVllFWmNobXFX?= =?utf-8?B?d2NWV2JEM1JYcGJpc0VScVNRZmRUNWJtajJ6eFRROHEzSk1xRHowTnZhNWpl?= =?utf-8?B?Ui82aFRiQ2dqclM1T2FZUWVBaXJ5UHZQd05qNUNWVmN3WjVjRUlQYmFMVGth?= =?utf-8?B?VGVGb2dLak9NcmxCazJLNG1UQStYZFZPazY1bVJubms4TUFlQURnT0l0R2pS?= =?utf-8?B?MDZYWm51WWhKdW8zaHNOVXd4SGtZMjdDS0szdnlUaFRXYjBtalc3NTY1b1BJ?= =?utf-8?B?cThYQzI5NEFPZlVLRkNESjBiYjNFYmdsZzlNQU1kbW4yV2dDY0NQK2svVmZB?= =?utf-8?B?KzFPRXBLZVJFYWZ4OWJtTXNmb3k1TTZpVHFidmo2RTBDVEJlSEdvbXFCZEdL?= =?utf-8?B?bmIyK1RkbFZFSUtZL3JhV1ozQTNtV3k1aXpXR3lDVHAyTDVNZDhrWUJ3ZEhH?= =?utf-8?B?UzJtbisybkcrVkZsbGJEZjJ3UVB4YlQvcVJ6bEswMnpmUnRkYzFkZHBES3p3?= =?utf-8?B?K0w3eU1kb3VRZzI0YU5VRnpMV2JPbDhhNnYvUU9UTjF4NGZuNlpWdzBUcmh4?= =?utf-8?B?R2dKQ2Yydit5QmhvMmcyRjZuU0pFM2U3VWNxVkNWV2swMWhDSDVJZmlqVWty?= =?utf-8?B?d283TTEzc3kzN0lwWDFScUtkb0VPdUs0M2lFQ3piYy9zSTd4VzA0U0JucXQ4?= =?utf-8?B?ZFNxZHYra0QzcTlxc2pRZnlqcERjbG1neTdHOE85a3pWZEI1c202RFZ0Q0FE?= =?utf-8?B?RGZIU3llRm82ZUQ4azk2dEltMmQ1RS9KdTVtTWlLM2NQeUx1eVpYNVRsV2Rs?= =?utf-8?Q?0jOeBtPgVfWoSPHDzhQHyl87e?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37e1d83d-3e81-4037-4744-08dac40b7409 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 17:37:49.9139 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IiXdWGkoOERy9d0LGmMLsCRaPLiQTlhgettkwoaNVVUou+uBDNbyK6troZdf3W3NzlKqcsj/fgB5eyvEmJaIww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8136 On 11/11/2022 16:17, Xenia Ragiadakou wrote: > Hi Ayan, Hi Xenia, > > On 11/11/22 16:17, Ayan Kumar Halder wrote: >> On AArch32, ldrd/strd instructions are not atomic when used to access >> MMIO. >> Furthermore, ldrd/strd instructions are not decoded by Arm when >> running as >> a guest to access emulated MMIO region. >> Thus, we have defined >> readq_relaxed_non_atomic()/writeq_relaxed_non_atomic() >> which in turn calls readl_relaxed()/writel_relaxed() for the lower >> and upper >> 32 bits. >> As GICv3 registers (GICD_IROUTER, GICR_TYPER) can be accessed in a >> non atomic >> fashion, so we have used {read/write}q_relaxed_non_atomic() on Arm32. >> >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changes from :- >> v1 - 1. Use ldrd/strd for readq_relaxed()/writeq_relaxed(). >> 2. No need to use le64_to_cpu() as the returned byte order is already >> in cpu >> endianess. >> >> v2 - 1. Replace {read/write}q_relaxed with >> {read/write}q_relaxed_non_atomic(). >> >>   xen/arch/arm/gic-v3.c               | 12 ++++++++++++ >>   xen/arch/arm/include/asm/arm32/io.h |  9 +++++++++ >>   2 files changed, 21 insertions(+) >> >> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c >> index 6457e7033c..a5bc549765 100644 >> --- a/xen/arch/arm/gic-v3.c >> +++ b/xen/arch/arm/gic-v3.c >> @@ -651,7 +651,11 @@ static void __init gicv3_dist_init(void) >>       affinity &= ~GICD_IROUTER_SPI_MODE_ANY; >>         for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i++ ) >> +#ifdef CONFIG_ARM_32 >> +        writeq_relaxed_non_atomic(affinity, GICD + GICD_IROUTER + i >> * 8); >> +#else >>           writeq_relaxed(affinity, GICD + GICD_IROUTER + i * 8); >> +#endif >>   } >>     static int gicv3_enable_redist(void) >> @@ -745,7 +749,11 @@ static int __init gicv3_populate_rdist(void) >>           } >>             do { >> +#ifdef CONFIG_ARM_32 >> +            typer = readq_relaxed_non_atomic(ptr + GICR_TYPER); >> +#else >>               typer = readq_relaxed(ptr + GICR_TYPER); >> +#endif >>                 if ( (typer >> 32) == aff ) >>               { >> @@ -1265,7 +1273,11 @@ static void gicv3_irq_set_affinity(struct >> irq_desc *desc, const cpumask_t *mask) >>       affinity &= ~GICD_IROUTER_SPI_MODE_ANY; >>         if ( desc->irq >= NR_GIC_LOCAL_IRQS ) >> +#ifdef CONFIG_ARM_32 >> +        writeq_relaxed_non_atomic(affinity, (GICD + GICD_IROUTER + >> desc->irq * 8)); >> +#else >>           writeq_relaxed(affinity, (GICD + GICD_IROUTER + desc->irq * >> 8)); >> +#endif >>         spin_unlock(&gicv3.lock); >>   } >> diff --git a/xen/arch/arm/include/asm/arm32/io.h >> b/xen/arch/arm/include/asm/arm32/io.h >> index 73a879e9fb..4ddfbea5c2 100644 >> --- a/xen/arch/arm/include/asm/arm32/io.h >> +++ b/xen/arch/arm/include/asm/arm32/io.h >> @@ -80,17 +80,26 @@ static inline u32 __raw_readl(const volatile void >> __iomem *addr) >>                                           __raw_readw(c)); __r; }) >>   #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \ >>                                           __raw_readl(c)); __r; }) >> +#define readq_relaxed_non_atomic(c) \ >> +                         ({ u64 __r = (((u64)readl_relaxed((c) + 4)) >> << 32) | \ >> +                                             readl_relaxed(c); __r; }) > > As Julien pointed out, the expression c will be evaluated twice and if > it produces side effects they will be performed twice. > To prevent this, you can either assign the expression to a local > variable and pass this one to readl_relaxed() Just to make sure I understand you correctly, you are suggesting this :- #define readq_relaxed_non_atomic(c) \                         ({ void _iomem *__addr = (c); \                             u64 __r = (((u64)readl_relaxed(__addr + 4)) << 32) | \ readl_relaxed(__addr); __r; }) #define writeq_relaxed_non_atomic(v,c) \                        (( u64 __v = (v); \                           void _iomem *__addr = (c); \                           writel_relaxed((u32)__v, __addr); \                           writel_relaxed((u32)((__v) >> 32), (__addr + 4); }) Is this correct understanding ? > or use a static inline function instead of a macro, for implementing > readq_relaxed_non_atomic(). > The latter is the MISRA C recommended (not strictly required) approach > according to Dir 4.9 "A function should be used in preference to a > function-like macro where >  they are interchangeable". I have mixed opinion about this. On one hand, there will be a performance penalty when invoking a function (compared to macro). On the other hand {readq/writeq}_relaxed_non_atomic() are called during init (gicv3 initialization, setting up the interrupt handlers), so the impact will not be bad. I am fine with whatever you and any maintainer suggest. Also now I realize that I had missed another point raised by Julien (a code comment explaining why ldrd/strd cannot be used) :(. I will address this in my next version > ... > >>     #define writeb_relaxed(v,c) __raw_writeb(v,c) >>   #define writew_relaxed(v,c)     __raw_writew((__force u16) >> cpu_to_le16(v),c) >>   #define writel_relaxed(v,c)     __raw_writel((__force u32) >> cpu_to_le32(v),c) >> +#define writeq_relaxed_non_atomic(v,c) \ >> +                                ({ writel_relaxed((u32)v, c); \ >> +                                   writel_relaxed((u32)((v) >> 32), >> (c) + 4); }) > > ... same here. Ack > >>     #define readb(c)                ({ u8 __v = readb_relaxed(c); >> __iormb(); __v; }) >>   #define readw(c)                ({ u16 __v = readw_relaxed(c); >> __iormb(); __v; }) >>   #define readl(c)                ({ u32 __v = readl_relaxed(c); >> __iormb(); __v; }) >> +#define readq(c)                ({ u64 __v = >> readq_relaxed_non_atomic(c); \ >> +                                             __iormb(); __v; }) > > I think that, here also, the macro identifier needs to inform that the > access is non-atomic. I will remove this as we will be using readq_relaxed_non_atomic() in the code. > ... > >>     #define writeb(v,c)             ({ __iowmb(); >> writeb_relaxed(v,c); }) >>   #define writew(v,c)             ({ __iowmb(); writew_relaxed(v,c); }) >>   #define writel(v,c)             ({ __iowmb(); writel_relaxed(v,c); }) >> +#define writeq(v,c)             ({ __iowmb(); >> writeq_relaxed_non_atomic(v,c); }) > > ... same here. I will remove this as we will be using writeq_relaxed_non_atomic()  in the code. - Ayan > >>     #endif /* _ARM_ARM32_IO_H */ > From xen-devel-bounces@lists.xenproject.org Fri Nov 11 17:47:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 17:47:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442680.697095 (Exim 4.92) (envelope-from ) id 1otY7T-0001R2-5W; Fri, 11 Nov 2022 17:47:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442680.697095; Fri, 11 Nov 2022 17:47:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otY7T-0001Qv-2R; Fri, 11 Nov 2022 17:47:11 +0000 Received: by outflank-mailman (input) for mailman id 442680; Fri, 11 Nov 2022 17:47:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otY7R-0001Qp-ID for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 17:47:09 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id daf09bb0-61e8-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 18:47:07 +0100 (CET) Received: from mail-mw2nam04lp2176.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Nov 2022 12:47:04 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6474.namprd03.prod.outlook.com (2603:10b6:303:121::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Fri, 11 Nov 2022 17:47:02 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 17:47:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: daf09bb0-61e8-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668188827; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=8YQyqVhJN6151+7qOuGBFn37agomXb/nUWcYX6AHZ7Q=; b=BYGXQtBaAiZ58xgeIGtXI+MSRYQf5Uropi/ArHnIrHqim12RzXSuqzeJ oc0JBkRZMVp1HRtPCEKBb225QHzqC3+wqpgX4ssy2sfJPKRPoGccI67df Dr5Ng1FvidwhetPz/HOF8NyTu2SQo1kNMQIlNRTy+B6JJSeJHoBDaRIsp U=; X-IronPort-RemoteIP: 104.47.73.176 X-IronPort-MID: 84659818 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:MtLBSKIwpUXJlkr3FE+RI5QlxSXFcZb7ZxGr2PjKsXjdYENS02MCy mdLUD/Ua/bfYjfxfYt0O4vn/U0A7JDdytZlGwZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wVnPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4oE0xws vkaDwwnURGkqfm2nrGxEvlz05FLwMnDZOvzu1lG5BSBUbMDfsqGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VspTGMkmSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzX+lBdNCTe3QGvhCvmDQ+moVVTgvXHShrb6itmDhdOwYN BlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml6qfS+RffOWECQRZIctlgv8gzLRQy3 0KNt8PkA3poqrL9YW2Z3qeZq3W1Iyd9BW0fY2kCRAgM4djmqakyiA7CSpBoF6vdpt74BzD2h SyLpS4WhrMPgMpN3KK+lXjXjjTpqpXXQwod4gTMQnnj/g5/fJSiZYGj9R7c9/koEWqCZlyIv XxBntfE6ukLVc2JjHbUH7tLG6y17fGYNjGamURoA5Qq6zWq/TikYJxU5zZ9YkxuN67oZAPUX aMagisJjLc7AZdgRfMfj16ZYyjy8ZXdKA== IronPort-HdrOrdr: A9a23:Lyv4Ia5jPA1lxVQpegPXweaCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+843WBjB8bZYOCAghrmEGgC1/qu/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXerIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpixBiSgSiu4LvaFQHd+hsFSTtAzZor7G CAymXCl+WemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQBiTwhh2ubIFBXaTHmDwuuumg5Hsjjd GJiRY9OMZY7W/XYwiO0FrQ8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMkp 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvuX+9Ua1wWB4S2rpXVt WGP/usvcq+tmnqN0wxi1Mfh+BEmE5DRStuDHJy4PB9mAIm4UyRh3FouPD32E1wt67VAqM0md gteM5T5c5zZ95TYqRnCOgbR8yrTmTLXBLXKWqXZU/qDacdJhv22tbKCRoOlZOXkbEzve0Pca 76IRplnH93f1irBdyF3ZVN/ByISGKhXS71wsUb45RioLXzSLfiLCXGETkV4oGdiuRaBteeV+ e4OZpQDfOmJWzyGZxR1wm7X5VJM3ERXMAcp95+UVOTpcDALJHsq4XgAb3uDauoFSxhVnL0A3 MFUjS2LMJc7lqzUnu9mxTVU2OFQD2JwXuxKtmvwwE+8vl/CmQXiHlltb2Q3LD6FRRS9qorYU B5PLTr1qumuGjexxe801lU X-IronPort-AV: E=Sophos;i="5.96,157,1665460800"; d="scan'208";a="84659818" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7QuXDJmfSGzzPflFl2Omw6zlJcgafQkueGLpP5TM0rDpEInH1+zGkZNlP3040jUulZ1puTzrWEzhgwYvhFJTylD6vK0ngREjuspgAXYPIQ28qJDIbPR7kwDPgKajJzzAtGzGpINsgDzO+To+Ur/dvgYKw1HPnaIO+sM9H7Guv11XFHpHxRhHsLxEtKPwhvmNPm/p0sLK62Jrppu2ADF9+bdzltoirKXO+kWWWDl52y4hBEQ+BzKJbhUzcKvy9zmSEK36IBVylBPX1ih+EagKSkG3vEJ6xSTlKDSJz9Mum5HrSFIgwVH5rU8l0iwcKTTuuUD3yMdZF8TSm+pBvqyLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8YQyqVhJN6151+7qOuGBFn37agomXb/nUWcYX6AHZ7Q=; b=PHQGIjP7tWzpEuihQYAMOlPTZ8XjzyUoC9V3i5iUFxAOfv3MH7+AEWnU2vPv85wJqiewct1qF9EywQFeLF87IDyCoMV6GhqaaJfH51VLxh8S087ABDAsOTi/fQk73TM+L66N2nB2FBAg4KMwUre+BgdnN7KZ69aOA+GK7hKzbfLjogCWm34vvndTGPFh/OhbEXCH7guQMaywIvCo9+IYfFD7z3OnINeUpqJh8X35ccR+lZ9kA1N+Zoy8rPXByCye2v/QwaQwFK6ZNyRI2OCQA0V6lkFmrua/3Dj6wM2JsODH3cL1HfJv5rNoInbpwthhrzaygy0ciAZqevTdUeCW2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8YQyqVhJN6151+7qOuGBFn37agomXb/nUWcYX6AHZ7Q=; b=iho10ML+hhtprGgm32v/2IRDinPSOTobCg8LQSbv7HTBlpE5tuRzpPlQBiAigxbBITmveINKWDRwocwUTQkM2XyJjqEs5JdCEK+ALUXksQ+l/FVKgHv9ImuKGX4CMAszjR/fDCl4F2z/V4rSQexD5rHGcayEkAUhl/uQrccmEek= From: Andrew Cooper To: Jan Beulich CC: "Henry.Wang@arm.com" , Paul Durrant , Wei Liu , Jun Nakajima , Kevin Tian , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Thread-Topic: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Thread-Index: AQHY8GkXjZEVf2M/t0iebvsck9V8qq44y+aAgACWeYCAAKSxAIAAA1KA Date: Fri, 11 Nov 2022 17:47:02 +0000 Message-ID: <1051eec8-8074-39e8-299d-a540d12bc997@citrix.com> References: <20221104161815.38007-1-roger.pau@citrix.com> <69841767-ccc4-5eeb-6e9c-d59dfb197ea5@citrix.com> <8e52a065-0141-f75c-03e8-e9ceb18a0aa1@suse.com> <4d0edf44-bb7c-85d9-0890-79c999428ef6@citrix.com> In-Reply-To: <4d0edf44-bb7c-85d9-0890-79c999428ef6@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MW4PR03MB6474:EE_ x-ms-office365-filtering-correlation-id: 4a07e13f-ff28-47cf-2cfc-08dac40cbd74 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Jx9M5HdFo/BVr/mm4m3i/YIaWXRdg4Qpr0/H9+srXnqCEKUlUXfV2MXOkUEA+4ocuwL/mc1EXvtdPoRmVd4lT1vYc3dqnX6jM/rBFD6hSKTKTwepIcNCdOyRKW3VRs1qUTNQ/spn9id9pXd2G0OFCX5+n3vX4JiV8PV/ix22HjIIBIzAEzMymjfjAi2K15GbXr3ImXpTUf6tJk8H7ythOh1dTtVMV1syfb2hW+RqcIacGaLllS/apXamLd6qz6zxl7wCNqZTAEFbidOeTBBgYr8BjpimTMCDewYlOV5YrU+EDvLJJvhUcGYgnNUGa7o5QaX2ZkMuZmzAn0urMAgSESK7fdQ0NhyNryhTkiFWYqHs3JlyT7B8FdW54SR/y2zAoEtDE2e7DKT/bA+F7pqaVRAsSCgMyyGhXzqJGXViokfLcDwqpJz7FsFRLOD0Vhuhg01HSS5OZRizKC0zlKWb8pY5XsCurqe1dzCUKYaiya1VMaXVHw45IU3YRTGMXoVBB9ytJZP2uO89cJgeag9PojaESMlkoEYLJF4frFaTTU/ZsfWoI7RXTfa+/LnrBZ3ZvFNc8DXMuKUMBUyf//UU8MqVfNVopBuwTsaLbC0p5GP3mlNBFhbEAXabzQDSX4BMlTa2XH/pQxtqWQ23gDHG5KKdHlapPrw9cjjiIJ3sOOpMONl4yJ3CLwL6GBuZz8BsHN/gkqxzwWUkEeYw5At4uqWxN5B3ztvLFTDIeCzDfbRWMfr8tqVvPKf2J9S5YGMmEwVJPlsd71rJUxd4pdp37RN6ivMF5IQ3MM8ePHPovL2GguNnK2+2gzclKD3eh47u6r1zCKDVYo4Ehlz6KZif8w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(451199015)(31696002)(83380400001)(71200400001)(38100700002)(82960400001)(86362001)(38070700005)(6512007)(41300700001)(4326008)(5660300002)(122000001)(26005)(8676002)(6506007)(8936002)(2906002)(66556008)(6486002)(91956017)(66446008)(2616005)(64756008)(478600001)(186003)(53546011)(66476007)(6916009)(66946007)(76116006)(54906003)(316002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aDZIWmlvYkV4bmxrb0F6QW5jVE8xdUMyTnR6clNjL1hNc2NwT1puQTVuWDdZ?= =?utf-8?B?RW41VVlmeWlHb1ArZjhGam45UDVvMjkzdUJVZ3lNNFF1d3lrU3FZRVVBMjhH?= =?utf-8?B?MkRYNTUwNG9xT3VzT3dLNHJ3bWszaGlGdW53Q1QrMUNEV3VzOFRYc3VLaVJZ?= =?utf-8?B?UWlYWld5QTBnOUJibEc2RTlFVW5ReHZ5cGg2VVluU0ZPdGtWV2RLdUhVZjVq?= =?utf-8?B?Nk5oc04zN2dFakpsR2MyQlBLNUJnelQ1eEl2TlBuWjlQWjZUL25jQ2hrTGZE?= =?utf-8?B?ZFVNR0wrcERVcWRLRkVIYmJIWXBvU2NKc2c0QkQ4R1FyTDcvd1hBR3RrczBu?= =?utf-8?B?SHIyeEVLcUVkKzlSZ1RpUjM3eVJzR285RCtZRmg4TkFhZzRVa3BNbUlvVDdD?= =?utf-8?B?ZXREbjU5VDUwdXdiNU9FdUhVL3dHeEIxMEYyb2VYd21pTG5aOGhpeWIyZ3lp?= =?utf-8?B?VUFKUC93MUp6Y3hERUhFSjBOODJmMHZHb1RWSm5RVFdHV1RwTWUrZmlxMDNq?= =?utf-8?B?WnBzR2ZjWkNtTmVwR2RlL3MvejVmcDBvcVpXK25wVHRocXViZWhtdG1nMUg4?= =?utf-8?B?b3B3dGZDb1UyeVFuV25xeXgxRnFiRWtQbGFZMWo4SER2ZTBLZFFFWkZCR3g4?= =?utf-8?B?U1A5dmJoZW16ZmFMNDFYMnlNL0dHWGZvRkczRnVjTWJOeFpEYTlkK0lvZ2JW?= =?utf-8?B?cXFNTTdqbnpnWG1lQld3aW1iYTI0K2hPVXZVQ1VxMWhtaU1venVHVWJaRlBO?= =?utf-8?B?bjU2NEZ0UEd4eE9hOHJjWDQxKzZTVkd2Q3BuK0FDQ2t3ZndwYjg3WkdRY3N6?= =?utf-8?B?TFUyL2pVN2Yvb1lMSThUMG05V0RmWTNoSlY0ZDBQNzgzaUptemtqZ3VXVHVF?= =?utf-8?B?Mlp2ZVM1eUpDaDg2UmRiNXkyTEhadWpPZXJ1ZUFVNUlxSTBDN1Z3K2NvSlB0?= =?utf-8?B?SUF0eWo0Z2RmbzdXY0FMaWw2cDNkMUFvS09wVURBZDh5d2tDV2lIaFZleWpD?= =?utf-8?B?K0diWWNLK0FHSXRmWEU2V2VUM3A2cVJYMCt3dzR0b0xjUGV6dlprK05ScHps?= =?utf-8?B?dUZDTGRFWWhvUkxDR1BkTmxZVVlzbXNMNFFQQWtwMHNnd2g1TjJaUHdpWkpX?= =?utf-8?B?cklGSmVDaGlITGdQa2JpdzFwKzgxL2U0eGhjZmdMdjRBUDV0NHg4YTNJN0xC?= =?utf-8?B?VVB3ZlZsRkMvNmNIK1daZHJSR2lKYVkxdXdDazlYRUR0TU9DMWt0WVdnQUJz?= =?utf-8?B?TlBvSTNGVDE3Mnlmcjk5Q2hNVGFVMVFtZ20xa1Jtc1BGNlhQU3QxSjlGd2sy?= =?utf-8?B?QytlQ0Y0TGxhOVI5bk9jTmVnTElhR20wUUNGN1dKODlBQlpzMFBqMUFPWTV4?= =?utf-8?B?QUM3a3RvY0VIeUFMaGV2ZSt0K003YitBL1B1RmF3TEg2NWh4ZjY0cXZXUjJ5?= =?utf-8?B?QTdXd1cvQS9JTFd0OU14blloTzJkQ09ZSmt6YWMzTGtnYVMzcWgvTDFtTW9q?= =?utf-8?B?U0lpY3hubUhtdDZjOHB5RHBnVkxrdWhsdFVsMWN2S3NLdHg2c3psVXYyQXh3?= =?utf-8?B?SzN0eExYbWtWcFJrclc1ekN2QkdTWXp2Q2lJMk95L2JyVHd1Um4rYURkaU85?= =?utf-8?B?QnZXWkRjS2FGeGk4UGoyOXRkd255TUd4OWVjTnZpSmxONk51NFRFaW5ocjFD?= =?utf-8?B?cEt5VXlKZjh0ZWtIVmJPVXRtSjRTQVU5Z2FjTW5WUTkxeGhlakkzbTEzK0Ez?= =?utf-8?B?aTZ3T1AxUk05QW8xYXhGUW9mKzFVM3JqeHJwZXFXcmFjODB6ZWZkTmRRTnpN?= =?utf-8?B?UTFrTkxKWWErQnlqSUI2Mzl4anhsZzJlZm1BV3VwYlp2aHZIMVpSZWdNbG9H?= =?utf-8?B?ZCt1VVZoR3MrOXNtdlk4Q2pMV0J1WHdjNjI5Q3BLTjh6UnYyOW1QL1hoRklB?= =?utf-8?B?eGlKdWJTcHdjeWhnTzRqOUdRdDVVMk50aS9MR2wyblpkeGhOeGl5THlCNllu?= =?utf-8?B?Wm9IWVNUTGFGckJrUStORDVTMU5ja3paakgra0t4NXBCVHdPM1BTUmk2enkw?= =?utf-8?B?R3d5WkJUZU4zYU4yaG5ZOWZ0c0lWTjdZOWtBb0RxaVBvSUNzMmRpRU82VXJq?= =?utf-8?Q?d8S0Au7lUixWNG27DwyH+kc8J?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: BhBLN6ZpWuKfKeeOCUTK+tz81noPP2FHQn3TXWIGl7SXHc1Ebz7CZkodKruDsGmC0w0V+iRod9iz4E7eQZBVej2IsnzxrYHH3991kks9O8BMo/FZwRvVNc+sL1WVkRpzrmJi4fzHBqtYuFbvk0/xLNXA/bOg5E1By5fZaSCBabhUlQn7l0GiVDy8W0CKVcEEEPORtfmmB/sRql8icNoKzeUUOroJzAFFkd8zHtFymYzIQetjAuN7R9FZAJQsKy9IqpHfFCXsEDq1teyLG8fIe/gj7MW3qzWwC2mejpQkdvNxgvhjaHpusT/SNsMLZGRo0hafMmMKb+F+YLbImGg+gMxRIoa192NvvyMYlj06DKPuSuUk8AQ/UcAV2Ln7cJ3u4qRkfNZM1yCOUTBUTqhpUJwPZR9uksUA1RYiT3cgOt7MRP/M8WtKA5d6qCzJtwj3+WxpNc2sX4hFu03WSoHiBDJMCSxIb/2Aj2IqAVEdJHeg+JeiZeMortz1XlhUa9GJjW8auQOEzpNfQn8FUhKH8sjHmpFKRbg6XrnmUqRrduEkJmXt8YtBp+vPzFVUgHYOvUzBINexHDIt2MW9TFTCf/dUHIHPVYYR209K3CqNW1G+nYRQKJRymOqv2a5c0QxZoaoqoOivKGTVUZLBgRf74yXNaTSf0NFA8fE7vbnZdpXp/9VMAzlTsHxwbHQ81YfBGc36G5aLuA2pvO/qdtrsqS4NCAqwAYnqC050yk4ovqHTctiAM7J9kezOkG+xPo9691etDWJhInm0dDl7sefyjm6LO+PNg5YOJ6eFy7Jt6sYhOLOVNtvsS68zZmeyNtNCkA7Be5tOcUpS3IvH5Zzv/2cxDpXfuPXOFaHK/MAOD476FFiuSBHQigPri4T4+n1DH19mYutLjI3GdDcCb47BmWduwDJfbDctC7w9huy9Gxk= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a07e13f-ff28-47cf-2cfc-08dac40cbd74 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2022 17:47:02.2880 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zfUArlcIB4S0hNa7BzXkTe8xB7nwkMSMYVFWMAMEFEdYrJ/RzkcdU7GZ7GIS/Q1yq0zDJNujCMe+rKJMvy4APLihP773l4aZYZdmhlXNQMk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6474 T24gMTEvMTEvMjAyMiAxNzozNSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMTEvMTEvMjAy MiAwNzo0NSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiBPbiAxMC4xMS4yMDIyIDIzOjQ3LCBBbmRy ZXcgQ29vcGVyIHdyb3RlOg0KPj4+IE9uIDA0LzExLzIwMjIgMTY6MTgsIFJvZ2VyIFBhdSBNb25u ZSB3cm90ZToNCj4+Pj4gLS0tIGEveGVuL2FyY2gveDg2L2h2bS92aXJpZGlhbi92aXJpZGlhbi5j DQo+Pj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vdmlyaWRpYW4vdmlyaWRpYW4uYw0KPj4+PiBA QCAtMTk3LDcgKzE5Nyw3IEBAIHZvaWQgY3B1aWRfdmlyaWRpYW5fbGVhdmVzKGNvbnN0IHN0cnVj dCB2Y3B1ICp2LCB1aW50MzJfdCBsZWFmLA0KPj4+PiAgICAgICAgICByZXMtPmEgPSBDUFVJRDRB X1JFTEFYX1RJTUVSX0lOVDsNCj4+Pj4gICAgICAgICAgaWYgKCB2aXJpZGlhbl9mZWF0dXJlX21h c2soZCkgJiBIVk1QVl9oY2FsbF9yZW1vdGVfdGxiX2ZsdXNoICkNCj4+Pj4gICAgICAgICAgICAg IHJlcy0+YSB8PSBDUFVJRDRBX0hDQUxMX1JFTU9URV9UTEJfRkxVU0g7DQo+Pj4+IC0gICAgICAg IGlmICggIWNwdV9oYXNfdm14X2FwaWNfcmVnX3ZpcnQgKQ0KPj4+PiArICAgICAgICBpZiAoICFo YXNfYXNzaXN0ZWRfeGFwaWMoZCkgKQ0KPj4+PiAgICAgICAgICAgICAgcmVzLT5hIHw9IENQVUlE NEFfTVNSX0JBU0VEX0FQSUM7DQo+Pj4gVGhpcyBjaGVjayBpcyBicm9rZW4gYmVmb3JlIGFuZCBh ZnRlci7CoCBJdCBuZWVkcyB0byBiZSBrZXllZCBvbg0KPj4+IHZpcnR1YWxpc2VkIGludGVycnVw dCBkZWxpdmVyeSwgbm90IHJlZ2lzdGVyIGFjY2VsZXJhdGlvbi4NCj4+IFRvIG1lIHRoaXMgY29u bmVjdGlvbiB5b3Ugc3VnZ2VzdCBsb29rcyBlbnRpcmVseSB1bm9idmlvdXMsIHNvIHdvdWxkDQo+ PiB5b3UgbWluZCBleHBhbmRpbmcgYXMgdG8gd2h5IHlvdSdyZSB0aGlua2luZyBzbz8gVGhlIGhp bnQgdG8gdGhlIGd1ZXN0DQo+PiBoZXJlIGlzIHJlbGF0ZWQgdG8gaG93IGl0IHdvdWxkIGJlc3Qg YWNjZXNzIGNlcnRhaW4gcmVnaXN0ZXJzIChhaXVpKSwNCj4+IHdoaWNoIHRvIG1lIGxvb2tzIG9y dGhvZ29uYWwgdG8gaG93IGludGVycnVwdCBkZWxpdmVyeSB3b3Jrcy4NCj4gSSByZWZlciB5b3Ug YWdhaW4gdG8gdGhlIGRpYWdyYW0uwqAgKEZvciBldmVyeW9uZSBlbHNlIG9uIHhlbi1kZXZlbCwg SQ0KPiBwdXQgdGhpcyB0b2dldGhlciB3aGVuIGZpeGluZyBYU0EtNDEyIGJlY2F1c2UgSW50ZWwn cyBBUElDIGFjY2VsZXJhdGlvbg0KPiBjb250cm9scyBhcmUgZW50aXJlbHkgdW5pbnR1aXRpdmUu KQ0KPg0KPiBJdCBpcyAidmlydHVhbCBpbnRlcnJ1cHQgZGVsaXZlcnkiIHdoaWNoIGNvbnRyb2xz IEVPSS9JQ1IgYWNjZWxlcmF0aW9uLA0KPiBhbmQgbm90ICJhcGljIHJlZ2lzdGVyIHZpcnR1YWxp c2F0aW9uIi7CoCBUaGVyZSdzIGEgZGVjYWRlIHdvcnRoIG9mDQo+IGhhcmR3YXJlIHdoZXJlIHRo aXMgbG9naWMgaXMgYW4gYW50aS1vcHRpbXNpYXRpb24sIGJ5IHRlbGxpbmcgd2luZG93cyB0bw0K PiB1c2UgYSBWTUV4aXQtaW5nIG1lY2hhbmlzbSBldmVuIHdoZW4gbWljcm9jb2RlIHdvdWxkIGhh dmUgYXZvaWRlZCB0aGUNCj4gVk1FeGl0Lg0KPg0KPiBJdCBpcyBub3QgYnkgYWNjaWRlbnQgdGhh dCAidmlydHVhbCBpbnRlcnJ1cHQgZGVsaXZlcnkiLCBpbnRyb2R1Y2VkIGluDQo+IEl2eUJyaWRn ZSwgaXMgZXhhY3RseSB0aGUgbWlzc2luZyByZWdpc3RlcnMgKG9uIHRvcCBvZiAidXNlIFRQUiBT aGFkb3ciDQo+IHdoaWNoIGlzIGV2ZW4gb2xkZXIpIHRvIG1ha2Ugd2luZG93cyBwZXJmb3JtYW5j ZSBsZXNzIGJhZC4NCg0KU29ycnksIHNlbnQgdG9vIGVhcmx5Lg0KDQpUaGlzIGFsc28gZmlybWx5 IGhpZ2hsaWdodHMgd2h5IHRoZSBBUEkvQUJJIGlzIGJyb2tlbi7CoCBJdCBoYXMNCnN1Y2Nlc3Nm dWxseSBmb29sZWQgYWxsIHRoZSBvdGhlciBtYWludGFpbmVycyBpbnRvIGRvaW5nIHRoZSB3cm9u Zw0KdGhpbmcsIGV2ZW4gYWZ0ZXIgcmVjZW50bHkgZGlzY3Vzc2luZyB0aGUgY29tcGxleGl0eSBh bmQgc3VidGx5IGluIGZ1bGwNCmFzIHBhcnQgb2YgdGhlIFhTQS00MTIgc2VjdXJpdHkgZml4Lg0K DQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri Nov 11 17:53:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 17:53:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442686.697106 (Exim 4.92) (envelope-from ) id 1otYDJ-00035U-Up; Fri, 11 Nov 2022 17:53:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442686.697106; Fri, 11 Nov 2022 17:53:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otYDJ-00035N-RX; Fri, 11 Nov 2022 17:53:13 +0000 Received: by outflank-mailman (input) for mailman id 442686; Fri, 11 Nov 2022 17:53:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otYDJ-00035H-49 for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 17:53:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otYDI-0005m6-N5; Fri, 11 Nov 2022 17:53:12 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.11.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1otYDI-0002Gs-G5; Fri, 11 Nov 2022 17:53:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=7x4fSVNoFVXEjjkkkEI9Pyq+oOD42XESGGKw/cmc6BM=; b=InBXtNR6qEQ7FVPnqY4aW6PGS2 300p46B0qIwAKCC6Yp5BRq4cQbuotbQfRn/vPgeepsU/yTNMc2lD1JeagKiiOEWifGOAwAtJ2sdnv FmAQS0+JDG0gbPDn+Qua9Snt3JRgSTjvzEn0+UrzYz5Qa83KftpNbdUjgYzlQ1MEPu/Y=; Message-ID: <36c7f27d-10c7-b4fd-c775-a247660ec125@xen.org> Date: Fri, 11 Nov 2022 17:53:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [XEN v3 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit Content-Language: en-US To: Ayan Kumar Halder , Xenia Ragiadakou , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com, jgrall@amazon.com References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-12-ayan.kumar.halder@amd.com> <3ea29174-abb4-0fe9-fde8-28d4d62f2f67@gmail.com> <96e799be-fc98-3457-2243-c979162e8a79@amd.com> From: Julien Grall In-Reply-To: <96e799be-fc98-3457-2243-c979162e8a79@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 11/11/2022 17:37, Ayan Kumar Halder wrote: > > On 11/11/2022 16:17, Xenia Ragiadakou wrote: >> Hi Ayan, > Hi Xenia, >> >> On 11/11/22 16:17, Ayan Kumar Halder wrote: >>> On AArch32, ldrd/strd instructions are not atomic when used to access >>> MMIO. >>> Furthermore, ldrd/strd instructions are not decoded by Arm when >>> running as >>> a guest to access emulated MMIO region. >>> Thus, we have defined >>> readq_relaxed_non_atomic()/writeq_relaxed_non_atomic() >>> which in turn calls readl_relaxed()/writel_relaxed() for the lower >>> and upper >>> 32 bits. >>> As GICv3 registers (GICD_IROUTER, GICR_TYPER) can be accessed in a >>> non atomic >>> fashion, so we have used {read/write}q_relaxed_non_atomic() on Arm32. >>> >>> Signed-off-by: Ayan Kumar Halder >>> --- >>> >>> Changes from :- >>> v1 - 1. Use ldrd/strd for readq_relaxed()/writeq_relaxed(). >>> 2. No need to use le64_to_cpu() as the returned byte order is already >>> in cpu >>> endianess. >>> >>> v2 - 1. Replace {read/write}q_relaxed with >>> {read/write}q_relaxed_non_atomic(). >>> >>>   xen/arch/arm/gic-v3.c               | 12 ++++++++++++ >>>   xen/arch/arm/include/asm/arm32/io.h |  9 +++++++++ >>>   2 files changed, 21 insertions(+) >>> >>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c >>> index 6457e7033c..a5bc549765 100644 >>> --- a/xen/arch/arm/gic-v3.c >>> +++ b/xen/arch/arm/gic-v3.c >>> @@ -651,7 +651,11 @@ static void __init gicv3_dist_init(void) >>>       affinity &= ~GICD_IROUTER_SPI_MODE_ANY; >>>         for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i++ ) >>> +#ifdef CONFIG_ARM_32 >>> +        writeq_relaxed_non_atomic(affinity, GICD + GICD_IROUTER + i >>> * 8); >>> +#else >>>           writeq_relaxed(affinity, GICD + GICD_IROUTER + i * 8); >>> +#endif I would have been OK if there was one place needed a #ifdef. But 2 is a bit too much. Please provide a wrapper writeq_relaxed_non_atomic() for arm64. The implementation would call writeq(). The same stands for... >>>   } >>>     static int gicv3_enable_redist(void) >>> @@ -745,7 +749,11 @@ static int __init gicv3_populate_rdist(void) >>>           } >>>             do { >>> +#ifdef CONFIG_ARM_32 >>> +            typer = readq_relaxed_non_atomic(ptr + GICR_TYPER); >>> +#else >>>               typer = readq_relaxed(ptr + GICR_TYPER); >>> +#endif ... here. >>>                 if ( (typer >> 32) == aff ) >>>               { >>> @@ -1265,7 +1273,11 @@ static void gicv3_irq_set_affinity(struct >>> irq_desc *desc, const cpumask_t *mask) >>>       affinity &= ~GICD_IROUTER_SPI_MODE_ANY; >>>         if ( desc->irq >= NR_GIC_LOCAL_IRQS ) >>> +#ifdef CONFIG_ARM_32 >>> +        writeq_relaxed_non_atomic(affinity, (GICD + GICD_IROUTER + >>> desc->irq * 8)); >>> +#else >>>           writeq_relaxed(affinity, (GICD + GICD_IROUTER + desc->irq * >>> 8)); >>> +#endif >>>         spin_unlock(&gicv3.lock); >>>   } >>> diff --git a/xen/arch/arm/include/asm/arm32/io.h >>> b/xen/arch/arm/include/asm/arm32/io.h >>> index 73a879e9fb..4ddfbea5c2 100644 >>> --- a/xen/arch/arm/include/asm/arm32/io.h >>> +++ b/xen/arch/arm/include/asm/arm32/io.h >>> @@ -80,17 +80,26 @@ static inline u32 __raw_readl(const volatile void >>> __iomem *addr) >>>                                           __raw_readw(c)); __r; }) >>>   #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \ >>>                                           __raw_readl(c)); __r; }) >>> +#define readq_relaxed_non_atomic(c) \ >>> +                         ({ u64 __r = (((u64)readl_relaxed((c) + 4)) >>> << 32) | \ >>> +                                             readl_relaxed(c); __r; }) >> >> As Julien pointed out, the expression c will be evaluated twice and if >> it produces side effects they will be performed twice. >> To prevent this, you can either assign the expression to a local >> variable and pass this one to readl_relaxed() > > Just to make sure I understand you correctly, you are suggesting this :- > > #define readq_relaxed_non_atomic(c) \ > >                         ({ void _iomem *__addr = (c); \ > >                             u64 __r = (((u64)readl_relaxed(__addr + 4)) > << 32) | \ > > readl_relaxed(__addr); __r; }) > > #define writeq_relaxed_non_atomic(v,c) \ > >                        (( u64 __v = (v); \ > >                           void _iomem *__addr = (c); \ > >                           writel_relaxed((u32)__v, __addr); \ > >                           writel_relaxed((u32)((__v) >> 32), (__addr + > 4); }) > > Is this correct understanding ? > >> or use a static inline function instead of a macro, for implementing >> readq_relaxed_non_atomic(). >> The latter is the MISRA C recommended (not strictly required) approach >> according to Dir 4.9 "A function should be used in preference to a >> function-like macro where >>  they are interchangeable". > > I have mixed opinion about this. > > On one hand, there will be a performance penalty when invoking a > function (compared to macro). Most of the compilers are nowadays clever enough to inline small functions. But we can force the compiler with the attribute always_inline. > > On the other hand {readq/writeq}_relaxed_non_atomic() are called during > init (gicv3 initialization, setting up the interrupt handlers), so the > impact will not be bad. > > I am fine with whatever you and any maintainer suggest. Project wide, we are trying to use "static inline" whenever it is possible because it adds a bit more type-safety (the error you made wouldn't have happened) and the code is clearer (no slash). So my preference is to use static line. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Nov 11 20:15:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 20:15:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442698.697117 (Exim 4.92) (envelope-from ) id 1otaQh-0002Vf-Tr; Fri, 11 Nov 2022 20:15:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442698.697117; Fri, 11 Nov 2022 20:15:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otaQh-0002VY-QU; Fri, 11 Nov 2022 20:15:11 +0000 Received: by outflank-mailman (input) for mailman id 442698; Fri, 11 Nov 2022 20:15:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otaQg-0002VS-Av for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 20:15:10 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 899172d0-61fd-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 21:15:08 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 582CFB8260C; Fri, 11 Nov 2022 20:15:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09FFEC433D6; Fri, 11 Nov 2022 20:15:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 899172d0-61fd-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668197706; bh=bR2dMVzmjdvM7WFCh+o1y8snkL418ulaASAYMDx2CdA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Y4cpybX5zBOQRwHfLN610OFoJKDhmt7V4YpdsSMuWNf2812mqsBtACyBACI0LMU+E efvhu/ZARAGxiyQ9saQhMKwX1IMdhTa3SB+EO3OV1ss9m8u7QK7rfgvBvrK2u9YSU3 lfXzRQJ0VOodswRYCWAmzYDYRjTd1iZONYM0YLxFrH6eMfV5sM+PHwT+34UgaJ7Hjj EqM/AuDpHa/QApckfhEufeN5fytTKuLLN8n9ZLLoRJaPagZKVYbc5muH6f6xArFSz9 6iQu69ZlU/KzjrLlXwBqtkPmoAzyVd3Y77pMngarUvYe5kp+umkl0ZuPeiGVSoDW2S vLsjJ7kpNO7jw== Date: Fri, 11 Nov 2022 12:15:03 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Wei Chen cc: Stefano Stabellini , Julien Grall , "xen-devel@lists.xenproject.org" , nd , Bertrand Marquis , Volodymyr Babchuk , Jiamei Xie Subject: RE: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform In-Reply-To: Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-6-wei.chen@arm.com> <0ffe8a4d-7caf-89af-d189-a872b6b4f0fa@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-44684058-1668197705=:50442" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-44684058-1668197705=:50442 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 11 Nov 2022, Wei Chen wrote: > Hi Stefano, Julien, > > > -----Original Message----- > > From: Xen-devel On Behalf Of > > Stefano Stabellini > > Sent: 2022年11月11日 6:13 > > To: Julien Grall > > Cc: Wei Chen ; xen-devel@lists.xenproject.org; nd > > ; Stefano Stabellini ; Bertrand > > Marquis ; Volodymyr Babchuk > > ; Jiamei Xie > > Subject: Re: [PATCH v6 05/11] xen/arm: define Xen start address for FVP > > BaseR platform > > > > On Wed, 9 Nov 2022, Julien Grall wrote: > > > > > -----Original Message----- > > > > > From: Julien Grall > > > > > Sent: 2022年11月7日 3:20 > > > > > To: Wei Chen ; xen-devel@lists.xenproject.org > > > > > Cc: nd ; Stefano Stabellini ; > > Bertrand > > > > > Marquis ; Volodymyr Babchuk > > > > > ; Jiamei Xie > > > > > Subject: Re: [PATCH v6 05/11] xen/arm: define Xen start address for > > FVP > > > > > BaseR platform > > > > > > > > > > > > > > > > > > > > On 04/11/2022 10:07, Wei Chen wrote: > > > > > > On Armv8-A, Xen has a fixed virtual start address (link address > > > > > > too) for all Armv8-A platforms. In an MMU based system, Xen can > > > > > > map its loaded address to this virtual start address. So, on > > > > > > Armv8-A platforms, the Xen start address does not need to be > > > > > > configurable. But on Armv8-R platforms, there is no MMU to map > > > > > > loaded address to a fixed virtual address and different platforms > > > > > > will have very different address space layout. So Xen cannot use > > > > > > a fixed physical address on MPU based system and need to have it > > > > > > configurable. > > > > > > > > > > > > So in this patch, we reuse the existing arm/platforms to store > > > > > > Armv8-R platforms' parameters. And `XEN_START_ADDRESS` is one > > > > > > kind of FVP BaseR platform's parameters. So we define default > > > > > > `XEN_START_ADDRESS` for FVP BaseR in its platform file. > > > > > > > > > > > > We also introduce one Kconfig option for users to override the > > > > > > default Xen start address of selected platform, if they think > > > > > > the default address doesn't suit their scenarios. For this > > > > > > Kconfig option, we use an unaligned address "0xffffffff" as the > > > > > > default value to indicate that users haven't used a customized > > > > > > Xen start address. > > > > > > > > > > > > And as we introduced Armv8-R platforms to Xen, that means the > > > > > > existed Arm64 platforms should not be listed in Armv8-R platform > > > > > > list, so we add !ARM_V8R dependency for these platforms. > > > > > > > > > > > > Signed-off-by: Wei Chen > > > > > > Signed-off-by: Jiamei.Xie > > > > > > --- > > > > > > xen/arch/arm/Kconfig | 11 +++++++++++ > > > > > > xen/arch/arm/include/asm/platforms/fvp_baser.h | 14 > > ++++++++++++++ > > > > > > > > > > I looked at the content of fvp_baser.h after this series is applied. > > > > > There are a bit of boiler plate that I expect to be part for other > > > > > platforms. In particular... > > > > > > > > > > > xen/arch/arm/platforms/Kconfig | 16 > > +++++++++++++--- > > > > > > 3 files changed, 38 insertions(+), 3 deletions(-) > > > > > > create mode 100644 > > xen/arch/arm/include/asm/platforms/fvp_baser.h > > > > > > > > > > > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > > > > > > index ad592367bd..ac276307d6 100644 > > > > > > --- a/xen/arch/arm/Kconfig > > > > > > +++ b/xen/arch/arm/Kconfig > > > > > > @@ -138,6 +138,17 @@ config TEE > > > > > > This option enables generic TEE mediators support. It allows > > > > > guests > > > > > > to access real TEE via one of TEE mediators implemented in > > > > > > XEN. > > > > > > > > > > > > +config XEN_START_ADDRESS > > > > > > + hex "Xen start address: keep default to use platform defined > > > > > address" > > > > > > + default 0xFFFFFFFF > > > > > > > > > > ... this default value will need to be tested everywhere. At least > > for > > > > > now, I think you can avoid the per platform header by using the > > Kconfig > > > > > to select the proper address (see the config for selecting early > > printk > > > > > address). > > > > > > > > > > This will also avoids to use an invalid value here. > > > > > > > > > > > > > We had considered to use Kconfig to define the start addresses of > > v8R64 > > > > platforms (prompt users to input the address). But we also want to > > provide > > > > a default start address for each platform (Discussed in [1], header > > for > > > > default value, Kconfig option for customized address). > > > Why do you want to provide a default value? And how it is guaranteed > > that it > > > will work for most of the users? > > > > > > > > > > > We also had thought to use Kconfig to define a default start address > > > > for each platform like what we had done for early printk in RFC[2]. > > > > But this method has been deprecated. > > > > > > Most of the current Xen is board agnostic except the UART. We push back > > the > > > addition of new one because the address can be found in the firmware > > table and > > > I wanted to avoid increase the number of option (there are dozens of > > platform > > > out...). > > > > > > > > > > > So if we don’t use header files, just use the Kconfig, we can't > > > > provide a default start address for platforms, and have to force users > > > > to enter the start address. > > > > > > I am not sure I see the problem to force the user to enter the start > > address. > > > My worry with per-platform default value is we end up to force each > > vendor to > > > provide an header in order to boot Xen. > > > > > > I think it would be better to provide a config tailored for that > > platform > > > (whether it is part of Xen can be debatable). This would allow a user to > > try a > > > release Xen on their platform with zero changes in the code. > > > > I agree with Julien, especially on this last point. > > > > Of course we need a default configuration for a given platform, we don't > > want every user of the same platform to have to go and look at the > > manual to find the right address to use. > > > > The question is where to put the per-platform default value. The kconfig > > "default" keyword is not great for that and it is not realistic to have > > a single address that works everywhere. > > > > Instead, we could have a prepopulated kconfig under > > xen/arch/arm/configs, or something under ImageBuilder, or maybe expand > > Do you mean we can keep a config like armv8r_fvp_baser_config in > xen/arch/arm/configs for users to generate a default config? Yes > If yes I think this method might be better for now. And about ImageBuilder > solution we can do it after MPU support be merged? That's fine --8323329-44684058-1668197705=:50442-- From xen-devel-bounces@lists.xenproject.org Fri Nov 11 20:35:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 20:35:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442702.697128 (Exim 4.92) (envelope-from ) id 1otakP-0005GM-IX; Fri, 11 Nov 2022 20:35:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442702.697128; Fri, 11 Nov 2022 20:35:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otakP-0005GF-Fn; Fri, 11 Nov 2022 20:35:33 +0000 Received: by outflank-mailman (input) for mailman id 442702; Fri, 11 Nov 2022 20:35:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otakN-0005G9-V5 for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 20:35:32 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 61d2cf84-6200-11ed-8fd2-01056ac49cbb; Fri, 11 Nov 2022 21:35:30 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 83F51620DB; Fri, 11 Nov 2022 20:35:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23800C433D7; Fri, 11 Nov 2022 20:35:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61d2cf84-6200-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668198928; bh=3Q7a4gdSE+f41T4qAzT3X+d57B6huLNydDq+POH/mKs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=USbYA8toQY0iC4WtmhML/VAAMBxnbFTOHZNjjy727nHHwvqE+d9j4TAIykf8+fXuv NqrGpn4Ghd9O7OC+DvKSBxjsig0x7lTxiOWrqV0py+7R/HTAKyUBmkKkTIdSMJQebK wrnw742ALJm1vRNwZzjIIpf6lcQ5LnqjQcCF/0ecU+1mfSjcB57e8P60CT8LA6G/64 TAMEYb9Rn5amPynMQp61HGpxs7Ip3s+HztDafrk7ldw1qHZHvx9bcumDIa4yqnQ8My HXitv+cgx52WKEDq3FPiguU/swzsvwITPLenNGLh2iPWoWZww3mYDTUukeFzADmBA4 a5nbulbdKr46Q== Date: Fri, 11 Nov 2022 12:35:26 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Henry Wang cc: Oleksandr Tyshchenko , xen-devel , Bertrand Marquis , Julien Grall , "sstabellini@kernel.org" Subject: RE: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release In-Reply-To: Message-ID: References: <20221111112208.451449-1-Henry.Wang@arm.com> <20221111112208.451449-3-Henry.Wang@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-71014710-1668198928=:50442" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-71014710-1668198928=:50442 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 11 Nov 2022, Henry Wang wrote: > - Add Renesas R-Car Gen4 IPMMU-VMSA support (Arm) > >   > > (Henry): If something from a specific vendor needs to be included, I wonder if “add i.MX lpuart and i.MX8QM initial support” also qualify. > I will let Arm maintainers to do the final call here. Hope you would be fine with that. Yes I think that's fine to add things from a specific vendor, including i.MX related stuff --8323329-71014710-1668198928=:50442-- From xen-devel-bounces@lists.xenproject.org Fri Nov 11 20:46:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 20:46:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442706.697139 (Exim 4.92) (envelope-from ) id 1otavK-0006x8-Kb; Fri, 11 Nov 2022 20:46:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442706.697139; Fri, 11 Nov 2022 20:46:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otavK-0006x1-GT; Fri, 11 Nov 2022 20:46:50 +0000 Received: by outflank-mailman (input) for mailman id 442706; Fri, 11 Nov 2022 20:46:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otavI-0006wv-V6 for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 20:46:49 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f42fb3b4-6201-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 21:46:47 +0100 (CET) Received: from mail-co1nam11lp2177.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Nov 2022 15:46:36 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5634.namprd03.prod.outlook.com (2603:10b6:208:285::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 20:46:34 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 20:46:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f42fb3b4-6201-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668199606; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=LbQKZwwFb+48b2hZwngj2rcQlT1T0oyCgAu2QSPatl0=; b=Qq1IL/lWr9rHirhtI3T7S2sKvEPOOn9BM1r8TVZ6zByKWY53F17FpvLZ 3C+GkmYd8L/ZUU0iZqzgoIiC58547cnTyY5Or9IK+01xNwaERAnGNhorR L7zA1269DI5arfIVtaLnfLyF3fKeOs9lP93nqsA9cp416QbbBJVzxkGYn I=; X-IronPort-RemoteIP: 104.47.56.177 X-IronPort-MID: 83739244 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:YCG/nK3EklrggLk7xPbD5e9wkn2cJEfYwER7XKvMYLTBsI5bpzZTz zNLD2DTPK2OY2TzKI1/Ot+08UJX75GGytRhGwM6pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVnPKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfWnFvp PVFEyExNxm6n8mrmIOeb+lvmZF2RCXrFNt3VnBI6xj8VK9jareaBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvS6Kk1MZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXOgB9lDTuHknhJsqGO55U1NFhM5bgSE/9Wg1XLicdIPN 1NBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQGucksVHoV3 1mGt9rzAHpkt7j9YX6U6Lq8tz65PikRa2gYakcsUg8t89Tl5oYpgXryos1LFae0ipj+Hmj2y jXT9Swm3exM0ogMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl BA5dwK2tYji0bnlePSxfdgw IronPort-HdrOrdr: A9a23:AK98DatHs7BD7etl35JuaRfd7skCXoAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeF+aP3CB+R2zYZSndqza05+W bIvgTl7uH72svLiyP05iv21dB7idHhwtxMCIiljdUUECzljkKFdZlsQLqLuREyuaWK5EwxmN fBjh88N4BY6m/XfEuyvRzxsjOQngoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L gj5RPbi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZDIMu60vFjLA BdNrCa2B9kSyLdU5kfhBg3/DWYZAV2Iv5BeDlbhiXa6UkMoJkz9Tpk+CVWpAZ9yHt6cegF2w 2MCNUXqFkFJPVmEp5VFaMPR9C6BXfKRg+JOGWOIU7/HKVCIH7VrYXriY9Frd1CVaZ4u6faoq 6xJm9wpCo3YQbjGMeO1JpE/lTER3i8Ry3kzoVb64JisrPxSbL3OWnbIWpe2PeIsrEaGInWSv yzMJVZD7vqKnbvA59A20n7V4NJIXcTXcUJspIwWk6IoMjMNor239arOMr7Nf7oC3IpS2n/Cn wMUHz6I9hB9FmiXjvijB3YSxrWCzjCFFJLYd3nFsQoufsw39d3w3koYHyCl7G2ACwHtLAqd0 1jJ76imr+npACNjBT101k= X-IronPort-AV: E=Sophos;i="5.96,157,1665460800"; d="scan'208";a="83739244" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KKak4GeWZwSWTcqexCI3JtrTbXPIXgvIlfAzJZ9m5oblxH2zspH9vldoCft7QwxFuMqXUCmRDRQTfwhIhPq1DcbEc+8EvVIlh/Ag8+h6bxv2xQavjwX32aWtIcoAjvfiN1bPdhOHmvGpuc/4qu80We0qyJTTYHtBZykJ5bPVzDZBcnIUdpdR1Ry+eJ1V2L0avMpAe6PcfkuPxcltWu3+DQpiJni49xF4r2MSFDIOq6pg6jYC+zdMrDeDVh0WKsKp6WwTsSynQ/CN/6RBJWzE6n8237QiTKMIuKf8SVfUqPRxJb2P+na8TAGmayZs1KlgU/yjhw4ZOkmXUUeA0b4TfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LbQKZwwFb+48b2hZwngj2rcQlT1T0oyCgAu2QSPatl0=; b=MXyaniQTYZN+AmgGuVFNZah06bX6ZQBpvTykyK15gg1v3NqL8966sbUKO6ShEk/hvzFWLVAGFNe7m8+27IMxWHb73qJ20fsQntz/cnbvnfO+YhUHzlolkmKzTCZwrHeuDhyxAsx0ELrgocuv79QzC/sd654oCqH2mKBBorHeHwPRjflsaDCB6ht7E5Bo81tbWoHcK14FXs9PqTP6PTtR3MRzUoXAPMmJPXiHEt5SRbzKPk3x7x6ppkW+uRFleOwnHBdlUf0thVAiPQcAXHKD7+DXfHx6Z9k6yaZnnbpw+Idpg1i1DnhuSKurx6MPKAxdWrjpWpcvPNUsieOkd136AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LbQKZwwFb+48b2hZwngj2rcQlT1T0oyCgAu2QSPatl0=; b=XCUB3zQL0J9Wi+Yq5FNVoNfcPt9C9GG7sVU+x2jGacWGE4Y2nbg8ftPHaQSqEx7R6nQiuF9Yu1MQDLoXEpZzN8M8xEaGvvxiUqHlEfZGR4Ek0l18G681OagteDGounYZO7GX5GN9wprU8tn/PtstoPOYMFPYT43LaTr6UXgM0uY= From: Andrew Cooper To: Edwin Torok , "xen-devel@lists.xenproject.org" CC: Henry Wang , Christian Lindig , David Scott , Wei Liu , Anthony Perard Subject: Summary: Re: [PATCH for-4.17 v3 00/15] OCaml fixes for Xen 4.17 Thread-Topic: Summary: Re: [PATCH for-4.17 v3 00/15] OCaml fixes for Xen 4.17 Thread-Index: AQHY84ewJ0jjWhTeBE61ayU/ec/VkK46Nk6A Date: Fri, 11 Nov 2022 20:46:33 +0000 Message-ID: <75fef917-499d-ab02-9429-39ed59d87c97@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5634:EE_ x-ms-office365-filtering-correlation-id: b99dfc9a-2f9d-4cb8-37f7-08dac425d1d0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sXXK7sZMfaIRIb7ny2CX2bYopV8VEMAxAxxEtfMJbBDEEeFv7u3DazJJVx3gJGtKeWEWwWrkMZOfkaCFUUNiEsIsnv6oelAxHlVupCXE+iOLSSRMwTHfL3ctu0lt6GES7wOl0hJ7D//19ymIjZhkLSozJ4R0nPKc/zcSrEFI0CjXAhAH7ykNHDbJ2wNDw5i3wQ9hRmtaxe9iRmwg6PeSZ8vPXBLKQy0nCEUN3AVQHKE0X0MypvOoAFkgQo3Ip4EYQyWPL3XqLdjIKc7mCHOMZTXHHcm4XwvihpQ+kKZH5lk6GigtHdMNl3oqWN6vIkPwHH3T7csEZ5K/evfToAWNDFRTLLZUvS8dJ8l7nZND4FMTsob87AbBmlDrD2MPClP0d3dCvHaqKeoTUQIXAt9Z46GI83ZyKMNeX7fFFDPjZd5xO+/FuseS8dIYNJaWKa9UvalIUB2pA8t/BSr5+gjOoNoKxpBM145XZIs6bNZZdTR20zNwr+RzksNJCQm4Yg8zdH/tRYsfxMK0E9QgnBM7o77DN8nW/4aoEq9CbzafWuy44jPyKHTN506e6sHbhvTTUI1y6uzck25UncF7zakFQfFmXZ88l+m1I+5k8t6L+W/4PV713b0wy//uFyacg9WXEnwUtghNgi4HG/4AS8Upe/SCpBzPTeaT5VCulIKqAMsTXPQpuUKAMuuPQshJAaTaXzl8cDph+7IRSYgbbIynLp16GKiB29KUv+1Dm6ai+y7eCNIyIMuMbkyZNzgolnHVqrKDsMgWIhE9dtNrb78zb+NH5PKIXjhxn1yTqJnbQUHy+XKl9Pd6ApLKZjAvxc9DFEqub7QWUux65wLYuGmbPA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(39860400002)(376002)(366004)(451199015)(36756003)(38070700005)(31686004)(31696002)(86362001)(83380400001)(2906002)(5660300002)(2616005)(6506007)(26005)(6512007)(122000001)(38100700002)(186003)(82960400001)(110136005)(91956017)(71200400001)(76116006)(66899015)(107886003)(54906003)(6486002)(66476007)(316002)(66446008)(4326008)(8676002)(64756008)(66946007)(66556008)(8936002)(478600001)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cU01U3VicXM5OEx2bENTZmpidjdFSHdMTjRJcHMzUmJoQjJMZ1pqY3pDNk5p?= =?utf-8?B?eDdKaTVBUENQSGI1VTJrMnE1cVYvZDRBVis5Um81akx4QVlXUmxlSmhpYmZX?= =?utf-8?B?djYreDQ3a0xIWWxRKzkrUVd2Ynl2amY0dEVrc0poNHREWlJqZnZGU3h5cGc2?= =?utf-8?B?aHVDM2plemtzaTBtVjgxejhDV2tHd1EwQm1CeXlEZTZHQTdnNkNuQ0pOYVlW?= =?utf-8?B?ODQ0ZjFZUlVyRnhNbDdMQmlRaDc5ZVlvOHdJMkxHOTJYcHFpSkxOaG5OcS9I?= =?utf-8?B?UWNwSWY5THZoQ1VvSkNHQS9tU0llZWJYSWR5NkVNNnVocmtSbVQ5YTFEQ2hp?= =?utf-8?B?OHBwdm1LZ0pQZGZyb2hUNUdqbUV4SEZESUZCd0dER3JQYk8rWjJHVGt5NGxG?= =?utf-8?B?UDdWUEE4eVQxeTNpbmkvdDhJWGRHcnZqWFJHb0Mrb2QrUURBUnc2dmM1Yksx?= =?utf-8?B?WlpoZ05uVlZDcnNkS0ZTNTNRakQvWVJVS213Z3dxamJiV3lnVTAxeHg0dGs3?= =?utf-8?B?Q3UrMkIrUXpyL3NlZGFTUFF2M2dUcHdiTVZCSTdxZ05jSzdwQm1yYzNHYVdZ?= =?utf-8?B?NWJhem1FS1lsSWpjODhzMjByYU1EZkdtZmJTSXFpNkpPRll6dGc0WmVNV0Js?= =?utf-8?B?TzRvTG9jMTR3ajFKem9XdFliZHJVN2o2ZlkrQzVrVXZJaGl3RVVGZ1llOVA5?= =?utf-8?B?dTdvT0JXcUhvbTQ2VUVLeXhXM0IyUCtabWowcDZSa1ZqbTNIUm1UWldhL0o0?= =?utf-8?B?MjhkQWl6OG9LWUNlaTIvM01BZFhjZXJaQ0txRS9QV3pvdWNFOGVZTElYbklK?= =?utf-8?B?NWk3ZHZwdmdVSTJqTTdvb1Zka0R2VThmYVY4OWt2ZlpKT3B4SnJrTGdRSVNB?= =?utf-8?B?ZllMeUYrYmFNaUppK2daR3ZxZm5tNHdDajNaaHNVTk44VXZNV1gvdTZHZzRq?= =?utf-8?B?dzRQZzNoWjFqcmRWclJUSU9XdUZsY1pRclJaQmc2R05YSXlLUkJaQWU5UzY5?= =?utf-8?B?Y3RneHBqWEZUMllxZzY1TDNhUU9wenlEU1VKbnNKMEgwMUVhTVNmQlFzeGVj?= =?utf-8?B?c2ZrYUFIZ2FqMjJyM1poRDEwZW5VMSt1MTAyWW1WZ2NEak8xZnAxdEhmWmlZ?= =?utf-8?B?b3ZacHJjaTk4NjlTWEE5L0l3Q2ZUemxoNnFsdHVvdmlBSUYrR1A5djlyV2RU?= =?utf-8?B?bEtDOGpSU3BFbjVGbXpRd1ZUWTV6LzVFZ05DWWNLSlB4aytPWXR6SVJoendZ?= =?utf-8?B?Wk95Z25PYUpZSC9xOU1GV251SUxPYkZhY1dVelBRN3ZYenYyZTE0ZFJpQ3o5?= =?utf-8?B?cHpLY3hzMzZZTzFEcS9ibG5tQ29IQVdWaXRUVjhic1E2N2l5aUNhOENOZnBu?= =?utf-8?B?b0Y4dkJKUFRlRDdFbk1BdXRYbi9USlBHRytBdGhwc2lndi9Da0FVSllLRFU4?= =?utf-8?B?REhtOHlWTHc3Q0MwSU90cE9uSzJmWCtKRXVNbWdKdVhmQVZkTkVIajNHQTJO?= =?utf-8?B?em1ISU03WWRzUTBIVXV6eUJkTS84OEFqQ3NySTU1RUJneHBZU2V3Q29LeG5Y?= =?utf-8?B?UGNMQnZ3anI5cGM1cE9iNzZGckpreHh2SlZPZUxyc2x4aGlvSUNDS0FYcEUw?= =?utf-8?B?eGFubEFyUjRTejRLQTB2Ym1uREFPOWxSTFlvcDJvNnVUSkhzTHZnMnoraitU?= =?utf-8?B?WmhMNUxrVEdRbW9JS2hlcmUySSttbjY1NksrMWI0bTFEdGpIRGI2VTM1YnVl?= =?utf-8?B?dUZON1B4cllqUmx3RzliOWphUU1uRVpLNmlCWEpxWGVmM2Q4bVkxV0tSWUhw?= =?utf-8?B?WlBKSGpvb2ZuZkJ3d0hvN0g3bHhlR1ppbi91TFpjcU1peTM0SGdXR2gzNmdk?= =?utf-8?B?MzF5dmFtb2xvRmZUbFRzSVp6aVBGYXFJdEFKVXpoRjgvcXBJc0MvK1VHQTgw?= =?utf-8?B?WjRMY2M2ajcvMVVWcE9ZSmFYdlA4aEgwS1NwV3hxU3hUdnhwR21udnBoODhV?= =?utf-8?B?Znp1ZDQvMy85SWpwWDVLMTcxcGNWcTNBbkJWNERidHpXVDVKYVdMSWMrTWpx?= =?utf-8?B?QVgxNkVkQzdSSk9Tb2kyQktaNXBoVVI4Rnorb2hoTzNJUDVBb2pmNHpKbGdz?= =?utf-8?Q?h12q6XRKiaKZ+3BXXHVQLJH6i?= Content-Type: text/plain; charset="utf-8" Content-ID: <6E7EA2D8D3841741A93DAC8F65169C76@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CyUQHMt698TG1ercIMdEA9DT8MdLTWW/t3h9A/rHFLWM9U9cH3POubhoNM4RaM0grK2vEh09X0/Xo0M8BNDc+iVcVUFkHnc17FbZun3Qpj4hfucyJjfgMhOf+kIhk6zCc8uFHbzQKA6+TlHCpxhCl5zcunRlP4HJiJXhdCJ/lXWcHFb18G16veSHcQI2D6vmpnbG1/lT/kXL+r4zjmk8cm7cgqRCaWwNcs9h0xSzK/Xt0Jj+rU+ITD2Ggc4gIWaOJ5ZLMWq43UooImNoC2w3jac6w6LkzDcdhPDs2pvS4eTP8UXT9R5F6TdESkM7XHIC+lWzcfO1bu+NdyhbJRcTUK/Zj9eGMDJbNWQQcdaotoqbg0SsFChIm35WFjvOEx4TOBpSZJ40G9va6GXSc0CS7KD6dpLsC18l80DJf6/hvh4vMo+dWCqDJ9U9c1QpbIEYSFkt8cvwSAXmLBQxCgBtR2h2PV5aJGlxg4DLQ/+p/gcVWcadcKH4EdyUggOAzYY6jJj91RdDFi6PHS926cVe5WYXILNDoQGwA1Iii3ljSPpuW33vvaTjTLKYznKnhLTcexVmu0Au04l7vCHKiII++rV2hWfweuvm4ZExRib9HFyT/XAoiKqv1KAkVaL4sIuVUa/kA1+HNAwxmPmyiITaqRqsTSG3tXoPKTwukwtSvCpYpjQ21AV5UjZsFtgWVtuUG2sJTVsooiZaDsmedXYfN5zTTdJuMGDQ5HaLczh4zsrL7Hl15M6TvypRBxz3m8opAE2kDYYrmON2BvI9cYGcaqQCz8qv01uN4IRu9+3N8yKgqYdMbpmqZ83x2KkyiCn9hoR30eIQOcbfNpb6pX6BwY71fRZ/NXIk8OZSaZ6DfQE= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b99dfc9a-2f9d-4cb8-37f7-08dac425d1d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2022 20:46:33.8795 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6CHb9vJx8BbiyDbQNeg1gefSR0sxwfYwJrrBbuuFOw7g7K+IMsBw7JZLGZH5aO24bLQE4L/IK4vRj1GZFmUl3W4/DUGx8xk61c+y8omJMB8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5634 Tm90aGluZyBoZXJlIGlzIGNyaXRpY2FsIGVub3VnaCB0byBnbyBpbnRvIDQuMTcgYXQgdGhpcyBq dW5jdHVyZS4NCg0KVmFyaW91cyBub3Rlcy9vYnNlcnZhdGlvbnMgZnJvbSBoYXZpbmcgc3BlbnQg YSBkYXkgdHJ5aW5nIHRvIHVudGFuZ2xlDQp0aGluZ3MuDQoNCjEpIFBhdGNoZXMgNS82IGFyZSBh IHNpbmdsZSBidWdmaXggYW5kIG5lZWQgbWVyZ2luZy7CoCBFeGNlcHQgdGhlcmUgd2FzDQphbHNv IGFuIGVycm9yIHdoZW4gdGFraW5nIGZlZWRiYWNrIGZyb20gdGhlIGxpc3QsIGFuZCB0aGUgbmV0 IHJlc3VsdA0KcmVncmVzc2VzIHRoZSBvcmlnaW5hbCBvcHRpbWlzYXRpb24uwqAgSSBoYXZlIGEg Zml4IHNvcnRlZCBpbiBteSBsb2NhbCBxdWV1ZS4NCg0KMikgVGhlIGluZGVudGF0aW9uIGZpeCAo bm90IGF0dGFjaGVkIHRvIHRoaXMgc2VyaWVzKSBzaG91bGQgc2NvcGUgdGhlDQpsb2dpYywgbm90 IGRlbGV0ZSBhIGRlYnVnIGxpbmUgd2hpY2ggd2FzIHByZXN1bWFibHkgYWRkZWQgZm9yIGEgZ29v ZA0KcmVhc29uLsKgIEkndmUgZ290IGEgZml4IHRvIHRoaXMgZWZmZWN0IGluIG15IGxvY2FsIHF1 ZXVlLCBhbmQgd2UgY2FuDQpkaXNjdXNzIHRoZSBwcm9zL2NvbnMgb2YgdGhlIGFwcHJvYWNoIGlu IGR1ZSBjb3Vyc2UuDQoNCjMpIFBhdGNoIDEsIGV2dGNobiBPY2FtbCA1LjAgY29tcGF0LCBpcyBz dGlsbCBtaXNzaW5nIHNvbWUgY29ycmVjdGlvbnMNCndoaWNoIEkgZ2F2ZSBvbiBlYXJsaWVyIHBv c3RpbmdzLsKgIEkndmUgZml4ZWQgaXQgdXAgbG9jYWxseSBpbiBteSBxdWV1ZS4NCg0KSSBhbHNv IG5vdGljZSwgd2hpbGUgcmV2aWV3aW5nIHRoZSB3aG9sZSwgdGhhdCBzdHViX2V2ZW50Y2huX2lu aXQoKQ0KcGFzc2VzIE5VTEwgYXMgYSBsb2dnZXIsIHdoaWNoIGhhcyB0aGUgc2lkZSBlZmZlY3Qg b2YgbGlieGVuZXZ0Y2huDQppbnN0YW50aWF0aW5nIGEgZGVmYXVsdCBsb2dnZXIgd2hpY2ggdGFr ZXMgY29udHJvbCBvZiBzdGRvdXQvc3RkZXJyLsKgDQpXaXRob3V0IHN0YXJ0aW5nIHRoZSBmaWdo dCBvdmVyIHRveGljIGxpYnJhcnkgYmVoYXZpb3VyIHlldCBhZ2FpbiwgaXQNCm9jY3VycyB0byBt ZSBpbiB0aGUgY29udGV4dCBvZiBQYXRjaCAxMywgdW5jYXVnaHQgZXhjZXB0aW9uIGhhbmRsZXIs DQp0aGF0IGluIG94ZW5zdG9yZWQsIGFueSBsb2dnaW5nIGZyb20gdGhlIEMgbGV2ZWwgbmVlZHMg dG8gZW5kIHVwIGVsc2V3aGVyZS4NCg0KV2hpbGUgd2UgZG8gaGF2ZSBvY2FtbCBiaW5kaW5ncyBm b3IgeGVudG9vbGxvZywgbm90aGluZyB1c2VzIGl0LCBhbmQNCm5vbmUgb2YgdGhlIG90aGVyIGxp YnJhcmllcyAoc2F2ZSB4bCwgd2hpY2ggaXNuJ3QgdXNlZCkgaGF2ZSBhIHdheSBvZg0KcGFzc2lu ZyB0aGUgT2NhbWwgWGVudG9vbGxvZyBkb3duLsKgIFRoaXMgcHJvYmFibHkgd2FudHMgcmV0aGlu a2luZywgb25lDQp3YXkgb3IgYW5vdGhlci4NCg0KNCkgUGF0Y2hlcyAyLzMuwqAgQWxsIHRoZXNl IGxpYnJhcmllcyBoYXZlIGZhciB3b3JzZSBwcm9ibGVtcyB0aGFuDQpldnRjaG4sIGJlY2F1c2Ug dGhleSBjYW4gZWFzaWx5IHVzZS1hZnRlci1mcmVlLsKgIFRoZXkgYWxsIG5lZWQgdG8gYmUNCkN1 c3RvbSB3aXRoIGEgZmluYWxpc2VyLg0KDQo1KSBQYXRjaCA0LsKgIFRoZSBjb21taXQgbWVzc2Fn ZSBzYXlzICJBIGJldHRlciBzb2x1dGlvbiBpcyBiZWluZyB3b3JrZWQNCm9uIGZvciBtYXN0ZXIi LCBidXQgdGhpcyBpcyBtYXN0ZXIuwqAgQWxzbywgaXQncyBub3QgYSBwcmVyZXF1aXNpdGUgZm9y IGENCnNlY3VyaXR5IGZpeDsgbWVyZWx5IHNvbWV0aGluZyB0byBtYWtlIGEgZGV2ZWxvcGVycyBs aWZlIGVhc2llci4NCg0KNikgVGhlIHJlLWluZGVudCBwYXRjaC7CoCBQb2xpY2llcyBvZiB3aGVu IHRvIGRvIGl0IGFzaWRlLCBoYXZpbmcgdHJpZWQNCnVzaW5nIGl0LCB0aGUgZm9ybWF0IGFkanVz dG1lbnQgaXMgaW5jb21wbGV0ZSAocnVubmluZyBvY3AtaW5kZW50IGdldHMNCm1lIGRlbHRhcyBp biBmaWxlcyBJIGhhdmVuJ3QgdG91Y2hlZCksIGFuZCB0aGVyZSBuZWVkcyB0byBiZSBzb21lDQou Z2l0aWdub3JlIGNoYW5nZXMuDQoNClRoYXQgc2FpZCwgaXQgaXMgdXN1YWxseSBmcm93bmVkIHVw b24gdG8gaGF2ZSBsb2dpYyBkZXBlbmRpbmcgb24gYmVpbmcNCmluIGEgZ2l0IHRyZWUuwqAgVGhp cyB3YXMgcGVyaGFwcyBhIGJpZ2dlciBkZWFsIGJhY2sgd2hlbiB3ZSB1c2VkIGhnIGJ5DQpkZWZh dWx0IGFuZCBtaXJyb3JlZCBpbnRvIG11bHRpcGxlIFNDTXMsIGJ1dCBpdCdzIHN0aWxsIGV4cGVj dGVkIG5vdCB0bw0KcmVseSBvbiB0aGlzLg0KDQo3KSBQYXRjaCA4LCBldnRjaG4gZmRvcGVuLCBp cyB0d28gc2VwYXJhdGUgcGF0Y2hlcy7CoCBPbmUgYWRkaW5nIGZkb3BlbiwNCmFuZCBvbmUgYWRk aW5nIGEgTk9DTE9FWEVDIGFyZ3VtZW50IHRvIHRoZSBleGlzdGluZyBpbml0Lg0KDQpUaGV5IHdh bnQgc3BsaXR0aW5nIGluIHR3by7CoCBmZG9wZW4oKSBvdWdodCB0byBwYXNzIGZsYWdzIHNvIHdl IGRvbid0DQpoYXZlIHRvIGJyZWFrIHRoZSBBQkkgYWdhaW4gd2hlbiB0aGVyZSBpcyBhIGZsYWcg bmVlZGluZyBwYXNzaW5nLCBhbmQNCmNsb2V4ZWMgcHJvYmFibHkgc2hvdWxkbid0IGJlIGEgYm9v bGVhbi7CoCBXZSBzaG91bGQgZWl0aGVyIHBhc3MgYSByYXcNCmludDMyLCBvciBhIGxpc3Qtb2Yt ZW51bXMgbGlrZSB3ZSBkbyBpbiB0aGUgeGVuY3RybCBzdHVicy7CoCBBbHNvLCB0aGlzDQpwYXRj aCBoYXMgaW5oZXJpdGVkIGVycm9ycyBmcm9tIHBhdGNoIDEuDQoNCjkpIFBhdGNoZXMgOCB0aHJ1 IDE1IG5lZWQgdG8gYmUgdGhlIG90aGVyIHNpZGUgb2YgdGhlIGludGVudCBwYXRjaCwNCmJlY2F1 c2UgdGhleSBuZWVkIGJhY2twb3J0aW5nIHRvIGJyYW5jaGVzIHdoaWNoIHdpbGwgbmV2ZXIgZ2V0 IGl0LsKgIFRoaXMNCmlzIHdoeSBidWdmaXhlcyBhbHdheXMgZ28gYXQgdGhlIGhlYWQgb2YgYSBw YXRjaCBzZXJpZXMsIGFuZA0KaW1wcm92ZW1lbnRzIGF0IHRoZSB0YWlsLg0KDQoxMCkgUGF0Y2gg MTIgdGFsa3MgYWJvdXQgZGVmYXVsdCBsb2cgbGV2ZWxzLCBidXQgdGhhdCdzIGJvZ3VzDQpyZWFz b25pbmcuwqAgVGhlIG1lc3NhZ2VzIHNob3VsZCBiZSB3YXJuaW5ncyBiZWNhdXNlIHRoZXkgbm9u LWZhdGFsDQpleGNlcHRpb25hbCBjYXNlcy4NCg0KMTEpIFBhdGNoIDE0IHRhbGtzIGFib3V0IHVz aW5nIGNhbWxfc3RhdF9zdHJkdXAoKSwgYnV0IGRvZXNuJ3QuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri Nov 11 20:52:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 20:52:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442711.697150 (Exim 4.92) (envelope-from ) id 1otb12-0008QG-BP; Fri, 11 Nov 2022 20:52:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442711.697150; Fri, 11 Nov 2022 20:52:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otb12-0008Q9-8g; Fri, 11 Nov 2022 20:52:44 +0000 Received: by outflank-mailman (input) for mailman id 442711; Fri, 11 Nov 2022 20:52:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otb11-0008Q3-As for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 20:52:43 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c8ee8378-6202-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 21:52:42 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 33795B82775; Fri, 11 Nov 2022 20:52:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83682C433D7; Fri, 11 Nov 2022 20:52:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8ee8378-6202-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668199959; bh=LtA/jFLCl2WZr8Qec7rfAHu/R79aDlTJqh0pstc7w58=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=iZBk8c/Aw/MIgp/XQk16WJX5Ay4fErwHqr07Lz7b6hZLGugzTJGehLALVhgr2o3ep E2jtoARIdHn3onLXm7KFZpsvee1x27XdCNofLUjWNbMvDPgbJ3Eetnm1EE9M/UiRh1 3+xT4srg89T6Lk//TgCV2BiP3yTImWNCYBWzHJJWGazvjNi7S5WPIrpFAi/mxOZM1m 8Sp5LYezY9Z6KB3w/2RMIosi7G0015LmJKoLSsw0WJvLdhS9s4Bbr86svODaGAitxG HmQ1k83hGGlBS086RYUmdreUwX17cpCIWyjHs+tLMhg9qslcpfAOwe+6QE3rJc2SIQ 2IquPNF/OHlGw== Date: Fri, 11 Nov 2022 12:52:37 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Luca Fancellu , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" , Anthony Perard Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair In-Reply-To: <826eb0df-fb52-fa25-c908-977285a6ec8b@suse.com> Message-ID: References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> <7d56c33d-4b03-9aa1-6abc-45a8ad41caca@suse.com> <2E0BFEFC-5BEE-4F8B-BD9E-94CB9A5B2BC9@arm.com> <9CE2A214-2D64-4BEC-A78B-393BF7AEDD9D@arm.com> <826eb0df-fb52-fa25-c908-977285a6ec8b@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1125273999-1668199697=:50442" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1125273999-1668199697=:50442 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Fri, 11 Nov 2022, Jan Beulich wrote: > On 11.11.2022 11:42, Luca Fancellu wrote: > >> On 9 Nov 2022, at 10:36, Jan Beulich wrote: > >> On 09.11.2022 11:08, Luca Fancellu wrote: > >>>>> On 07.11.2022 11:47, Luca Fancellu wrote: > >>>>> Now analysis-build-coverity will be called, the best match is analysis-build-%, so again the dependency > >>>>> which is analysis-parse-tags-%, will be translated to analysis-parse-tags-coverity. > >>>>> > >>>>> Now analysis-parse-tags-coverity will be called, the best match is analysis-parse-tags-%, so the % will > >>>>> Have the ‘coverity’ value and in the dependency we will have $(objtree)/%.sed -> $(objtree)/coverity.sed. > >>>>> > >>>>> Looking for $(objtree)/coverity.sed the best match is $(objtree)/%.sed, which will have $(JUSTIFICATION_FILES) > >>>>> and the python script in the dependency, here we will use the second expansion to solve > >>>>> $(XEN_ROOT)/docs/misra/false-positive-$$*.json in $(XEN_ROOT)/docs/misra/false-positive-coverity.json > >>>>> > >>>>> So now after analysis-parse-tags-coverity has ended its dependency it will start with its recipe, after it finishes, > >>>>> the recipe of analysis-build-coverity will start and it will call make to actually build Xen. > >>>> > >>>> Okay, I see now - this building of Xen really _is_ independent of the > >>>> checker chosen. I'm not sure though whether it is a good idea to > >>>> integrate all this, including ... > >>>> > >>>>> After the build finishes, if the status is good, the analysis-build-coverity has finished and the _analysis-coverity > >>>>> recipe can now run, it will call make with the analysis-clean target, restoring any .{c,h}.safparse to .{c,h}. > >>>> > >>>> ... the subsequent cleaning. The state of the _source_ tree after a > >>>> build failure would be different from that after a successful build. > >>>> Personally I consider this at best surprising. > >>>> > >>>> I wonder whether instead there could be a shell(?) script driving a > >>>> sequence of make invocations, leaving the new make goals all be self- > >>>> contained. Such a script could revert the source tree to its original > >>>> state even upon build failure by default, with an option allowing to > >>>> suppress this behavior. > >>> > >>> Instead of adding another tool, so another layer to the overall system, I would be more willing to add documentation > >>> about this process, explaining how to use the analysis-* build targets, what to expect after a successful run and what > >>> to expect after a failure. > >>> > >>> What do you think? > >> > >> Personally I'd prefer make goals to behave as such, with no surprises. > > > > The analysis-* goal requires a build step, otherwise no analysis can be performed by the analysis tools, so I hope we agree > > we need to integrate that step as a dependency of the analysis-*. > > No, I'm afraid we don't agree. But like said for another piece we didn't > initially agree on - if others think what you propose is fine, so be it. > I'm specifically adding Anthony to Cc, as he's been working on make rules > the most of all of us in the recent past. > > > I understand that the analysis-clean might be a “surprise” if not well documented, this comes from the need to substitute the > > tags in the tree (to keep the real path in the report log) and to revert them back at the end of the analysis. > > > > So, such script should just mask to the user the analysis-clean invocation in case of errors (with an option to don’t do that)? > > Hmm, here you're saying "such script", which looks to not fit with the > earlier part of your reply above. (Just in case that's what I was to read > out of this: I wouldn't see value in a script which existed _solely_ to > make the cleaning conditional.) > > Did you consider the alternative approach of copying the tree, altering > it (while or after copying), running the build there, pulling out the > result files, and delete the entire copy? Such a model would likely get > away without introducing surprising make rules. Another, maybe simpler idea: what if the build step is not a dependency of the analysis-* goals? Basically, the user is supposed to: 1) call analysis-parse-tags-* 2) build Xen (in any way they like) 3) call analysis-clean Making steps 1-3 into a single step is slightly more convenient for the user but the downside is that dealing with build errors becomes problematic. On the other hand, if we let the user call steps 1-3 by hand individually, it is slightly less convenient for the user but they can more easily deal with any build error and sophisticated build configurations. This is one of those cases where I think "less is more". --8323329-1125273999-1668199697=:50442-- From xen-devel-bounces@lists.xenproject.org Fri Nov 11 21:50:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 21:50:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442716.697161 (Exim 4.92) (envelope-from ) id 1otbut-000778-LF; Fri, 11 Nov 2022 21:50:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442716.697161; Fri, 11 Nov 2022 21:50:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otbut-000771-IT; Fri, 11 Nov 2022 21:50:27 +0000 Received: by outflank-mailman (input) for mailman id 442716; Fri, 11 Nov 2022 21:50:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otbur-00076r-Vw; Fri, 11 Nov 2022 21:50:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otbur-0002bL-SB; Fri, 11 Nov 2022 21:50:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otbur-0007ef-AQ; Fri, 11 Nov 2022 21:50:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otbur-0003E0-9w; Fri, 11 Nov 2022 21:50:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=534lLUOCr68hs2jOgNE4i+6viRKaQRtPigStU4LTv1g=; b=a/aqOCSOGuBrHcMJHQc6AGUlvX gqqkNzPrU5VH20a+d15vFmYYN5oi9FpuIIPdz6zQA4TZiSSZ/WSbY/oZvQgnIdu+VkVDzvpbeeddG 3b+NP6NZ1Kai1+qKjydbrS7TGlbwAFmy2ZtrJeqx9ss1o+ZaCx9zJwR0UK4ZGyqZOA84=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174735: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4bbf3422df78029f03161640dcb1e9d1ed64d1ea X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Fri, 11 Nov 2022 21:50:25 +0000 flight 174735 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174735/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 4bbf3422df78029f03161640dcb1e9d1ed64d1ea baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 35 days Failing since 173470 2022-10-08 06:21:34 Z 34 days 55 attempts Testing same since 174735 2022-11-11 09:00:29 Z 0 days 1 attempts ------------------------------------------------------------ 1653 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 156545 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Nov 11 22:18:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 22:18:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442723.697171 (Exim 4.92) (envelope-from ) id 1otcLn-0001mI-SD; Fri, 11 Nov 2022 22:18:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442723.697171; Fri, 11 Nov 2022 22:18:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otcLn-0001mB-PQ; Fri, 11 Nov 2022 22:18:15 +0000 Received: by outflank-mailman (input) for mailman id 442723; Fri, 11 Nov 2022 22:18:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otcLm-0001m5-6m for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 22:18:14 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ba99a012-620e-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 23:18:12 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A2186210D; Fri, 11 Nov 2022 22:18:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0F48C433C1; Fri, 11 Nov 2022 22:18:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba99a012-620e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668205090; bh=HUmklLsRcj8o4GSmpeB1SyWK5agxHuvDdIr4q87pvdE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ZqTRIhJiAOrCpSDm8O3rCCHPz2olP0S5AZmTsMesRn3Ve1aMueJknFlccLMdn8jOg BWhaKpcdZWpBVZAftQmUpE2Q3m+Kp0MJd3qApyFfrtN04ypp3gPFkmpnz6RzvvpR79 0bO4T8xiX87U+TQIut6zXSlyx0CQGj5CgI0cRUvclXT1Es8PaIPWkjeDvKLh5/ZcJY cHkNBi0e9ScLxfEOhGdFip2vMLCAi/K012pcbGL1fLCsRw++Xf+SBKcnBXumkcPim7 5/mQEF2Xpa6pyep2GeBK3IW5LlH4pQ7T0739KNnHEoRJnKydAfgTcy2E+F3zbNi/HO o4hXI94OCZ/sQ== Date: Fri, 11 Nov 2022 14:18:04 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Henry Wang cc: Stefano Stabellini , Anthony PERARD , "xen-devel@lists.xenproject.org" , Wei Liu , George Dunlap , Julien Grall , Jan Beulich , Andrew Cooper , Bertrand Marquis , Petre Pircalabu , Alexandru Isaila , Tamas K Lengyel , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Juergen Gross , Paul Durrant , Christopher Clark Subject: RE: [XEN PATCH for-4.17 v2 0/6] Fixing some licences issue in public headers In-Reply-To: Message-ID: References: <20221103115204.49610-1-anthony.perard@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 11 Nov 2022, Henry Wang wrote: > Hi Stefano, > > > -----Original Message----- > > From: Stefano Stabellini > > Hi all, > > > > I think if we are going to commit this series for 4.17 then I would > > suggest to also commit patches 1-3 of my "introduce SPDX" series: > > > > https://marc.info/?l=xen-devel&m=166562222522996 > > > > They are already acked/reviewed and are zero risk as they don't actually > > change any of the headers. > > After some thinking and discussion I would like to follow your suggestion in > here. So for the first 3 patches from your "introduce SPDX" series: > > Release-acked-by: Henry Wang Thanks, I pushed the first 3 patches. From xen-devel-bounces@lists.xenproject.org Fri Nov 11 22:31:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 22:31:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442728.697182 (Exim 4.92) (envelope-from ) id 1otcYy-0004HA-2S; Fri, 11 Nov 2022 22:31:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442728.697182; Fri, 11 Nov 2022 22:31:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otcYx-0004H3-VN; Fri, 11 Nov 2022 22:31:51 +0000 Received: by outflank-mailman (input) for mailman id 442728; Fri, 11 Nov 2022 22:31:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otcYw-0004Gt-Nu; Fri, 11 Nov 2022 22:31:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otcYw-0003S6-Ih; Fri, 11 Nov 2022 22:31:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otcYw-00008D-4N; Fri, 11 Nov 2022 22:31:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otcYw-0006Q0-3r; Fri, 11 Nov 2022 22:31:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DjhqCXxmvDY4kn06NTBYiM5Aopz7Saj58rGyNSD6W8o=; b=hrVOR5ZZIgoS1GJqDFsPXR+9XE YEgkzmuhMRTL+HMIRCvbxxTqbJC4tGPFbUwCeSfw2mcidWDQr1nMgyN8gnUOdvwEi/MRYG07bMXSI PpF1eo8F1KQkldUoQinB/+RAqQO0+dMzcZprhAo8xD8SbO1LBClxpiuKuldmwfF7i/oU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174738: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-pair:guest-migrate/dst_host/src_host:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=771a8acbb84145b943bd608ba376e104ebfa9664 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Fri, 11 Nov 2022 22:31:50 +0000 flight 174738 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174738/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174727 REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit1 14 guest-start fail in 174727 pass in 174738 test-amd64-i386-libvirt-pair 27 guest-migrate/dst_host/src_host fail in 174727 pass in 174738 test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 174727 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 174727 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 174727 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 771a8acbb84145b943bd608ba376e104ebfa9664 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 13 days Failing since 174575 2022-11-01 18:42:39 Z 10 days 18 attempts Testing same since 174727 2022-11-10 22:13:32 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anna Schumaker Anssi Hannula Ard Biesheuvel Arnaldo Carvalho de Melo Biju Das Brian Foster Brian Norris Carlos Llamas Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Chuhong Yuan Damien Le Moal Dan Carpenter Darrick J. Wong Darrick J. Wong Dave Chinner Dave Chinner David S. Miller David Sterba Dean Luick Demi Marie Obenour Dennis Dalessandro Dokyung Song Dongliang Mu Eric Dumazet Eric Sandeen Filipe Manana Florian Fainelli Gaosheng Cui Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Han Xu Hangyu Hua Hannu Hartikainen Hans Verkuil Heiko Carstens Heiko Stuebner Helge Deller Hyong Youb Kim Hyunwoo Kim Håkon Bugge Ilias Apalodimas Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jason Gunthorpe Jeff Vanhoof Jens Axboe Jens Glathe Jim Mattson Jimmy Assarsson Jiri Kosina Johan Hovold John Veness Jon Hunter Jon Maloy Jonathan Cameron Jonathan Corbet Josh Poimboeuf Juergen Gross Julian Anastasov Justin Chen Kalle Valo Kan Liang Konrad Jankowski Kuniyuki Iwashima Kuogee Hsieh Leon Romanovsky Leon Romanovsky Li Qiang Linus Torvalds Linux Kernel Functional Testing Luiz Augusto von Dentz Luiz Capitulino Luís Henriques M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Martin K. Petersen Martin Tůma Masami Hiramatsu (Google) Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Maxim Levitsky Maxim Mikityanskiy Meena Shanmugam Michal Hocko Michal Jaron Michal Simek Mike Kravetz Miklos Szeredi Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Pablo Neira Ayuso Paolo Abeni Paolo Bonzini Paul E. McKenney Paul Moore Peter Zijlstra (Intel) Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rasmus Villemoes Richard Weinberger Rik van Riel Saeed Mahameed Sakari Ailus Samuel Bailey Sascha Hauer Sasha Levin Serge Hallyn Sergey Shtylyov Shakeel Butt Shang XiaoJing Shreeya Patel Shuah Khan Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Theodore Ts'o Thinh Nguyen Tim Harvey Tom Lendacky Tomasz Moń Tony O'Brien Trond Myklebust Tvrtko Ursulin Uday Shankar Ulf Hansson Vasily Averin Vasily Gorbik Ville Syrjälä Vineet Gupta Vladimir Oltean Wei Yongjun Willy Tarreau Wolfram Sang Xin Long Yang Yingliang Ye Bin Yongqin Liu Yu Kuai Zhang Changzhong Zhang Qilong Zhang Xiaoxu Zheng Yejian Zhengchao Shao Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 4692 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Nov 11 22:56:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Nov 2022 22:56:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442735.697194 (Exim 4.92) (envelope-from ) id 1otcwX-0007MQ-5A; Fri, 11 Nov 2022 22:56:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442735.697194; Fri, 11 Nov 2022 22:56:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otcwX-0007MJ-2A; Fri, 11 Nov 2022 22:56:13 +0000 Received: by outflank-mailman (input) for mailman id 442735; Fri, 11 Nov 2022 22:56:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otcwV-0007MD-J8 for xen-devel@lists.xenproject.org; Fri, 11 Nov 2022 22:56:11 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2057.outbound.protection.outlook.com [40.107.22.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0368395d-6214-11ed-91b6-6bf2151ebd3b; Fri, 11 Nov 2022 23:56:02 +0100 (CET) Received: from AM6PR04MB4901.eurprd04.prod.outlook.com (2603:10a6:20b:1::32) by AM8PR04MB7796.eurprd04.prod.outlook.com (2603:10a6:20b:243::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 11 Nov 2022 22:56:00 +0000 Received: from AM6PR04MB4901.eurprd04.prod.outlook.com ([fe80::78b2:ed7e:4e32:df8a]) by AM6PR04MB4901.eurprd04.prod.outlook.com ([fe80::78b2:ed7e:4e32:df8a%7]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 22:55:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0368395d-6214-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O5muzCD4evWv2hmvCy3XB3gp1SLxFy9/xq6VV6B+8wrnlpM8nrIsZyyg/h+PjGB9q4SKS92k02uoaCp9dKRzml4KRO7XflazAAF9YJ+NKO254igrr9vuLg+o/jVjxiri8SKEvTliTt1j3FzcVwYzVix4NhKPCOaebfZKPQDqoZPABjwQn5QBJhs6WyyKv02Zn0V3aMY+Va01WtlSKoj2/lWta8QWP/ZIPK+nQ4Fwkoegs5mUTga2/hIwDKRI+5V3qRstV33D/QNpbpLMNOB8IiguSxG4CdalWgMnYF2JSwvH/QgRV9DGV6HmodVZsh4Y7EB16tb5+B0iHfencPrXqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X1c1p5kOom6v9Hgu60KfRA/hvXIyiH2M0ufyRW+1hEQ=; b=D8P2l13suWC/Cffa39NZr9YYbfr+EMvHjgccV0oddMf7Kfn3InSc+dNcdWGAK2J3hQ65MqWIxm7W7+tL4yojlCb3FlALJdoeUYwba7qMSyNt9WNQ0XDTdN5i0p+OMMe4CTzbRBI3AJ6/kYX8SdacSpzYEA4a54CAr5yW4nz2O5qc9XGeCpV6VXTHxhfQhept6V3pEHWBOI9y4g1OayzGa5pVRgfLW86jXxNGO2dP3HxoGbZqPfemEDBRSWpXVvT+JczrPrfwAn+18R4YiHLFq9SZ7XDYE9WnffxjB7+tJo6rdFK4KjxKCVPNkcsAN1ShCd6bId7vHJDmkeIxVdDB4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X1c1p5kOom6v9Hgu60KfRA/hvXIyiH2M0ufyRW+1hEQ=; b=O8EdPPxV8pveqVbvkG8C816qa8gMvq2qGvYEO6wb0OdAZOf1eU66gRK8OSqXyQANBuswgAUvvgyDQaWA5ddQDgQRtykT6ihnFGDX7zeQXJfQNbs0Okqd1eQALXCErbfByi+rNIdWrwUPyKYljiELgl0naGkH44tBjTKpWGQD8ZuCEy/w0lno5gG2PIT9tSi9ZiHc+mm3IU/ZPjiyysuNrAVOmp9HO716CFKRGhho6nIclyeQeEjxKtlrmRp2DpWTzOfs+hJiwzIpZKdtXjXF7icK1+rWPfOk4rSu54QwqGgx1uwbgIDRAm80pr8tFp8ee08305ZjQGkxPvgNb9tYBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2046b5fb-2533-02fe-69e8-f46174cf825d@suse.com> Date: Fri, 11 Nov 2022 15:55:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: xen-devel From: Jim Fehlig Subject: vnuma_nodes missing pnode 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::13) To AM6PR04MB4901.eurprd04.prod.outlook.com (2603:10a6:20b:1::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4901:EE_|AM8PR04MB7796:EE_ X-MS-Office365-Filtering-Correlation-Id: 50c727b0-edbe-46b2-629f-08dac437e67e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MoTj+5suuUfH/PbAS7Ii7anP2D8Z6fA+JZJI5EbcjPUUihzexGYdLP/Pu2Kv7+lB72HBo57/bz/6DPnXYnt4T+ZnJVKnJ+yYccdq2IDaYUR/OV9qozTqCPaPmr1FbPPiiVCxzF+YDdKxqoqBkxQyqX7VQkYgDi4dtVtqkHVgNxHlalYARlNlpsjeNGn/V4yUDR6CAtpPYBCNwL41yhcJ8xmiSA0Im8/YEeA4zQEzsTxhDxTOkJu1i6PqaBLZ1/uopSJa4ojSWCPs2Xo3ftClSyI26zT14IwJqsvwBV8eNqTnKGX+V9JhPk/plGOqGQu28PlpT6RW+JqdRJBmpY5Bz2U4hMKKRZAV8kyW41LKQhhlw6WbBoPXPyxkz0s5QTs5qedVamVRfrYdaLB0Q4n93jTTeBW34+7Kn16ZZkuF3N0YYuSNYfBSw555lg8j8J+/C5xWCerYHtEPB82G/OFTwi88A8hSXrpKTWUoycLJIyO0YzVxQF8+KsssXhMAFSkXyGBx83Tehk0EqSRwSFRDwfFGYk6RQk/6bozW81bbf4yWrRRZVt4a0r3eW8H+XnEN6u29aexSX0DJq2z9LAnrZnzU7+/FyGxE9Ca+4uWmbHMDg1xnxtlVEu4CK5ZVX6/f/MRpCI7497fDA4jBir0Mep3TaFyhFv7AsRxqrHFRDBScrBnRcK95trCgJSkdyTafRo7QFazbZvzUJaGbPQe1gjc2Z90zKOsiJnzWsqo0D7WJ1b7vU/ULthEjdoc56FEsJMWXO1zbZ10ZoGprgrhyfeCNSfDrLKKky590u+oEmP8Bo4TDwHq1eO9c8Vy+/z+rg4k4fgGMvaZxPKcQu7kKfaipGHhlriDL1bwWHC0rVqQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4901.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(376002)(346002)(366004)(39860400002)(451199015)(86362001)(83380400001)(186003)(31696002)(38100700002)(41300700001)(966005)(2906002)(5660300002)(478600001)(2616005)(8936002)(6666004)(4744005)(6512007)(66556008)(26005)(8676002)(66476007)(66946007)(6486002)(7116003)(316002)(6916009)(6506007)(36756003)(31686004)(533714002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzVyNWMvQTZOZ0hyMnhtRFRCTUF3Z2VkWUJMNjFxNm1PTy84QmVhR2pNZWNW?= =?utf-8?B?TTVMZmxhaStDZWlpOGt2bE9XWkdoRmYwdnNiTGV1d25haGFVaFdZN0NSbFow?= =?utf-8?B?cDNId3k3OFE0YXBuejZuWWl0dzJwQUlOMjM1cUs2ZzZZcDRsMEgrQ0hpR1hT?= =?utf-8?B?aTV1RTNjWkJYNmdoL1gxMEYwMm9jVWk0L1V3Vit1MUcwaUMydDd1a1lkdTEv?= =?utf-8?B?ZVlRZXhoK1kwaGxma1dHYmovS1Y0TFpkZmI4OHBiYVNvRUtYandKT1JhWThU?= =?utf-8?B?cjBteEthV0dHbmpTb0NZY3lsbzIxMGFBT0M2UHFCcysvSllPbU1yNmZMUHR4?= =?utf-8?B?cnFZNG93WFNDSC9sNmowQVAzUzNLbkxQeStjME03UU5udjYyTjN6OW9JRHhl?= =?utf-8?B?S0RaK0lERm44RVlxd1E0aGhzeWFUc0JWUW1BZ2NBN1ViQTFPSjUzZzh2Zi8r?= =?utf-8?B?RnFhSmZXdENXdjZzWnVLZVRsQW5TZEVkalI5RDY1SXppSTFuYS9wYUhISWVZ?= =?utf-8?B?QS9xNFp5NldQS1NkYm1yN2FFSDNGYW1nQjgvaDJQZ2lSUE9XN2ZMVno5WEE4?= =?utf-8?B?NGlvMVdxUEptQ1hRbEt6R0RNcU9LYXZCc3gwblJhbUpqL3ZLdFVxL05DdTdC?= =?utf-8?B?bnc3Mk1iSlBxYXFyV2J3dzBBWDkvZzdKSU8wRC9TOGpqRXZPSzZ2VkpHcjRo?= =?utf-8?B?QWE0NFRCYjhtRFV3bXRwSy9scVMxbStNMkZtbTRqRFJzM3ROQVU0aE9GZyt0?= =?utf-8?B?SG0yajN2b1RhNWJCV1F5WWIrRjRHMnNZaFNIN1BQdHJHNDZsdHN5K1Z0V1Z3?= =?utf-8?B?TXdEWEZtZTdZcDJvVVhBQVZyZFQ4Z3ZmSjN3aXVlamEzTEFZMnJTYy9HajJL?= =?utf-8?B?WHB1ZWJtdENQNGhiZ1VtRDBCVWpHOGI1cmRkYlM5UDZyZ3c1YWtBWStZOTgz?= =?utf-8?B?WkJuRDY3Qkl2OWRMTzM5ZncyOC9HZ2J4QXhwRGJHMG5SOFh3Ris1ZlNUVDhD?= =?utf-8?B?WGU3dlFSd0laRGk1UWt6MGllcEVzc3NYamlKTUl0TWxxbmhMbmtzWTZ2SHBx?= =?utf-8?B?Qk53MHZIdUF2OFFUM3YwN3IrUUMrVlpVT21GNzIyYzl5WTFxTjlGelhMd1Bv?= =?utf-8?B?SytqTTZmZEFZM3ZHdHpLK0FXRkcxeDVPcmVucUxWOU0vZWlzeERranhzOFQ5?= =?utf-8?B?MEkvK2VGN1lpeXl3N2ZHNjFtdmp4ZitiWUF2c2dzTm1xTHBLZHVxODFxNG9y?= =?utf-8?B?dTd6ZEJ5VVphUXp1OU1zZkVGMlNVeXhCU0pCTHN1eWV2TDliOFRLTmpyTFVr?= =?utf-8?B?NWRUSVd4bW02Y2lGWWhBME13WDA0djFueUl4Q3BGdERqM3htYmJLRDhqMjNu?= =?utf-8?B?aEpSSExad3UvZEJPZkk1bzF4Mk1mTWJ5WHAxeDBBbXdia3lWT0FQODJ1cW9q?= =?utf-8?B?ZUlRNVltaUdlbTBSUThvbENKTXFra0lYSkdmYjViTTkxV0ZHbS9WZERxNnFx?= =?utf-8?B?QnM2b3ZrTkFrRUhDcDkwa2JJTkxLQUYyM0ZHRll4aVZhVnc2b0tNUS9wRWlS?= =?utf-8?B?ZjN3aFRyNGFtMUZ3blRnRkFuVWhqWXpYanZxRzJkQnNKTnJncEQrOWZBaFJp?= =?utf-8?B?NWxYQVFnTENmOVBCdGkxbVhlWjBJVjdlZE10MWNOOXR6M3pjcER3aWRseERI?= =?utf-8?B?bkRibDdxQmpMUERVT2MrTVZlZnBEMTlhaHhnZDZLMGZhOW5QTWVLL251SWhy?= =?utf-8?B?TFJYYVJ2MWs1Y2VVSzFIaEIvN1RNaEczL3MvVDB5cnNtRmlOOCtHMU02bVAw?= =?utf-8?B?MHdHQnRVdE15UllWaGt0SUVNQzhPM3psR09Rd3BZeUE3MmV5aWJpdHVzbkQ0?= =?utf-8?B?ZlpqS01RY2xnM3Y0aFNqSzJEYlFpWmdIb2ZEayt4NEg5eGlHalVPV2daL3l6?= =?utf-8?B?alh0NnAxTCs1ekovbjE4TUZnUnhBbGR5U09Ta1pPa0hEbmp3WlZxZ1lXSUpR?= =?utf-8?B?aUZQU1E5WVpBUzk3NVFZK20xcm1qNE84VDB4UDRCOUNxc25XUm1LWmd1a2NN?= =?utf-8?B?czd4eGF1Wmp3NUhPVzBRclNWVjlJdFpGVU4yTTcxSWpLVHp1YkdaeVluWjVk?= =?utf-8?Q?sY9cBVQjQnTowhCKJ1iEsdfAV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50c727b0-edbe-46b2-629f-08dac437e67e X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4901.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 22:55:59.6884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aYEQQ8rEIdxag+6UTzH9yrPCJ2ZKJL6p/4xeDEMs4qW3UOXNRrWRtN0B7bLh9yN5/7PClWzmc92VcbQoNpeSkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7796 Hi All, While fixing [1] a recent downstream libvirt build failure against 4.17 rc3, I noticed the json representation of libxl_vnode_info omits pnode when value is 0. The problem can be seen by starting a VM containing the following vnuma config vnuma = [ [ "pnode=0", "size=2048", "vcpus=0", "vdistances=10,20" ], [ "pnode=1", "size=2048", "vcpus=1", "vdistances=20,10" ] ] The json representation for this config does not contain pnode 0 "vnuma_nodes": [ { "memkb": 2097152, "distances": [ 10, 20 ], "vcpus": [ 0 ] }, { "memkb": 2097152, "distances": [ 20, 10 ], "pnode": 1, "vcpus": [ 1 ] } ], I'm not familiar with the code generator for the *_to_json functions, but with a hint I can probably cook up a patch :-). Regards, Jim [1] https://listman.redhat.com/archives/libvir-list/2022-November/235745.html From xen-devel-bounces@lists.xenproject.org Sat Nov 12 03:00:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 12 Nov 2022 03:00:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442746.697205 (Exim 4.92) (envelope-from ) id 1otgkB-0008RE-8C; Sat, 12 Nov 2022 02:59:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442746.697205; Sat, 12 Nov 2022 02:59:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otgkB-0008R7-50; Sat, 12 Nov 2022 02:59:43 +0000 Received: by outflank-mailman (input) for mailman id 442746; Sat, 12 Nov 2022 02:59:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otgk9-0008Qx-BK; Sat, 12 Nov 2022 02:59:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otgk9-0008Tz-98; Sat, 12 Nov 2022 02:59:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otgk8-00064J-QX; Sat, 12 Nov 2022 02:59:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otgk8-0007pU-Q3; Sat, 12 Nov 2022 02:59:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QpWrofnr4ehu5jqAR92VcSb1dlpHlZSnkFTX+AR6upc=; b=wmg2LVqVw1AsL/COjEYFMMVOnk TwmAs/JsvAFN6acqerOTaKYvisLcf9jkSi0JMwCXGQWK/DYK2EYorx75+yYCQ616ENm70vju+wJKy Y8sdFoTd2vMcF3gZ8qNtV1jc438kqLFnX0DO6wxpwYrha6gNDY0a8o66LfJHNo38MbI4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174741: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 X-Osstest-Versions-That: xen=08c6f57cfebad4046dabc05092b4a27c61a39980 From: osstest service owner Date: Sat, 12 Nov 2022 02:59:40 +0000 flight 174741 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174741/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 baseline version: xen 08c6f57cfebad4046dabc05092b4a27c61a39980 Last test of basis 174725 2022-11-10 20:00:24 Z 1 days Testing same since 174741 2022-11-11 23:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 08c6f57cfe..17dfc79ce9 17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 -> smoke From xen-devel-bounces@lists.xenproject.org Sat Nov 12 06:41:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 12 Nov 2022 06:41:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442758.697216 (Exim 4.92) (envelope-from ) id 1otkCI-00012M-KD; Sat, 12 Nov 2022 06:40:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442758.697216; Sat, 12 Nov 2022 06:40:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otkCI-00012F-HQ; Sat, 12 Nov 2022 06:40:58 +0000 Received: by outflank-mailman (input) for mailman id 442758; Sat, 12 Nov 2022 06:40:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otkCH-000125-3m; Sat, 12 Nov 2022 06:40:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otkCH-0005FE-02; Sat, 12 Nov 2022 06:40:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otkCG-0003Mx-Iu; Sat, 12 Nov 2022 06:40:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otkCG-0001pp-IR; Sat, 12 Nov 2022 06:40:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5tIusdBYfqM+U4vc7NjqCVs2I1JscfkSE9CeqX8uKbY=; b=F5ynvYxHozcEMp8bexyLYI6DYh Hh4XfeECcimtf+xxpJX9I/8ZDL7tn1apRjTsMpfHrj66repwNHOYd568lMAgB6150cmxaA0uMP+7N DibOFtWZgvvv53QhsZO8+/+6EE94Nmrmx/rQRzlX5bs1z9ZqtRDIYxmeevT9P1vgAxzw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174739: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f5020a08b2b371162a4a16ef97694cac3980397e X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sat, 12 Nov 2022 06:40:56 +0000 flight 174739 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174739/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux f5020a08b2b371162a4a16ef97694cac3980397e baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 35 days Failing since 173470 2022-10-08 06:21:34 Z 35 days 56 attempts Testing same since 174739 2022-11-11 22:12:48 Z 0 days 1 attempts ------------------------------------------------------------ 1690 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 160230 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 12 07:22:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 12 Nov 2022 07:22:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442766.697227 (Exim 4.92) (envelope-from ) id 1otkqr-00069j-1E; Sat, 12 Nov 2022 07:22:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442766.697227; Sat, 12 Nov 2022 07:22:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otkqq-00069c-U8; Sat, 12 Nov 2022 07:22:52 +0000 Received: by outflank-mailman (input) for mailman id 442766; Sat, 12 Nov 2022 07:22:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otkqq-00069S-Ab; Sat, 12 Nov 2022 07:22:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otkqq-0006GC-0n; Sat, 12 Nov 2022 07:22:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otkqp-0005er-5F; Sat, 12 Nov 2022 07:22:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otkqp-00008Y-4g; Sat, 12 Nov 2022 07:22:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fRKKIMq5ZsKbLXkO5jfqhi6lUxAk5QBSa12eNi7vaFI=; b=OpyOCJmWv4aQ2lhc6pizYGgWKH U7gVuj3Z00njS4Vu7guM92s75CMob94xaRug+fveC3ogU/j1ewhYIvaXgoZpEYBOuIPd2QM/qyOPv IKivt98D3M13Eh7Qc49tg8n8Rx+mXD5NOjCyqe/ZVOUfacA5W6eHTqpMEx8w/dToQ7Xs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174740: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=771a8acbb84145b943bd608ba376e104ebfa9664 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Sat, 12 Nov 2022 07:22:51 +0000 flight 174740 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174740/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 14 guest-start fail in 174738 pass in 174740 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 174738 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 771a8acbb84145b943bd608ba376e104ebfa9664 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 13 days Failing since 174575 2022-11-01 18:42:39 Z 10 days 19 attempts Testing same since 174727 2022-11-10 22:13:32 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anna Schumaker Anssi Hannula Ard Biesheuvel Arnaldo Carvalho de Melo Biju Das Brian Foster Brian Norris Carlos Llamas Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Chuhong Yuan Damien Le Moal Dan Carpenter Darrick J. Wong Darrick J. Wong Dave Chinner Dave Chinner David S. Miller David Sterba Dean Luick Demi Marie Obenour Dennis Dalessandro Dokyung Song Dongliang Mu Eric Dumazet Eric Sandeen Filipe Manana Florian Fainelli Gaosheng Cui Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Han Xu Hangyu Hua Hannu Hartikainen Hans Verkuil Heiko Carstens Heiko Stuebner Helge Deller Hyong Youb Kim Hyunwoo Kim Håkon Bugge Ilias Apalodimas Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jason Gunthorpe Jeff Vanhoof Jens Axboe Jens Glathe Jim Mattson Jimmy Assarsson Jiri Kosina Johan Hovold John Veness Jon Hunter Jon Maloy Jonathan Cameron Jonathan Corbet Josh Poimboeuf Juergen Gross Julian Anastasov Justin Chen Kalle Valo Kan Liang Konrad Jankowski Kuniyuki Iwashima Kuogee Hsieh Leon Romanovsky Leon Romanovsky Li Qiang Linus Torvalds Linux Kernel Functional Testing Luiz Augusto von Dentz Luiz Capitulino Luís Henriques M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Martin K. Petersen Martin Tůma Masami Hiramatsu (Google) Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Maxim Levitsky Maxim Mikityanskiy Meena Shanmugam Michal Hocko Michal Jaron Michal Simek Mike Kravetz Miklos Szeredi Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Pablo Neira Ayuso Paolo Abeni Paolo Bonzini Paul E. McKenney Paul Moore Peter Zijlstra (Intel) Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rasmus Villemoes Richard Weinberger Rik van Riel Saeed Mahameed Sakari Ailus Samuel Bailey Sascha Hauer Sasha Levin Serge Hallyn Sergey Shtylyov Shakeel Butt Shang XiaoJing Shreeya Patel Shuah Khan Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Theodore Ts'o Thinh Nguyen Tim Harvey Tom Lendacky Tomasz Moń Tony O'Brien Trond Myklebust Tvrtko Ursulin Uday Shankar Ulf Hansson Vasily Averin Vasily Gorbik Ville Syrjälä Vineet Gupta Vladimir Oltean Wei Yongjun Willy Tarreau Wolfram Sang Xin Long Yang Yingliang Ye Bin Yongqin Liu Yu Kuai Zhang Changzhong Zhang Qilong Zhang Xiaoxu Zheng Yejian Zhengchao Shao Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 4692 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 12 12:11:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 12 Nov 2022 12:11:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442798.697238 (Exim 4.92) (envelope-from ) id 1otpLs-0005hC-1L; Sat, 12 Nov 2022 12:11:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442798.697238; Sat, 12 Nov 2022 12:11:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otpLr-0005h3-Rb; Sat, 12 Nov 2022 12:11:11 +0000 Received: by outflank-mailman (input) for mailman id 442798; Sat, 12 Nov 2022 12:11:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otpLq-0005gt-Ne; Sat, 12 Nov 2022 12:11:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otpLq-0004Oo-K2; Sat, 12 Nov 2022 12:11:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otpLq-0006y8-3v; Sat, 12 Nov 2022 12:11:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otpLq-0005Ix-3T; Sat, 12 Nov 2022 12:11:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dJ5Ilfbj4TftrRHzJKfyyjlW5z7WUvD3krgSFQ8T3NU=; b=sOoQ4ffPzXBHmsiyD2A99B59E7 2PHE5FO0mtlU0cG2VEUiEXvMDvCgAo2qvTqX9cIQ/b51MLu/MnU3ocidaSZB3Js0RDBbMk5+zrggI vYmcArSojfTDOhqyAJGkhikPWMASs4yERokzmExYT2AaccgIuiv2C8Ndl8jpzkL+XNww=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174742: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=08c6f57cfebad4046dabc05092b4a27c61a39980 X-Osstest-Versions-That: xen=08c6f57cfebad4046dabc05092b4a27c61a39980 From: osstest service owner Date: Sat, 12 Nov 2022 12:11:10 +0000 flight 174742 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174742/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174733 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174733 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174733 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174733 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174733 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174733 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174733 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174733 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174733 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174733 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174733 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174733 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 08c6f57cfebad4046dabc05092b4a27c61a39980 baseline version: xen 08c6f57cfebad4046dabc05092b4a27c61a39980 Last test of basis 174742 2022-11-12 01:53:47 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Nov 12 13:24:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 12 Nov 2022 13:24:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442804.697248 (Exim 4.92) (envelope-from ) id 1otqU5-0005Yh-8w; Sat, 12 Nov 2022 13:23:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442804.697248; Sat, 12 Nov 2022 13:23:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otqU5-0005Ya-6D; Sat, 12 Nov 2022 13:23:45 +0000 Received: by outflank-mailman (input) for mailman id 442804; Sat, 12 Nov 2022 13:23:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otqU3-0005YB-Te for xen-devel@lists.xenproject.org; Sat, 12 Nov 2022 13:23:44 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 383a576d-628d-11ed-8fd2-01056ac49cbb; Sat, 12 Nov 2022 14:23:42 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8FE111F890; Sat, 12 Nov 2022 13:23:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 22A4C13A08; Sat, 12 Nov 2022 13:23:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bWkWB1qeb2MyGQAAMHmgww (envelope-from ); Sat, 12 Nov 2022 13:23:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 383a576d-628d-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1668259418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Lzs4s6ThfI/Cryj0DS92Vtk9nJ4GBe5JTPtbjjKk9HI=; b=dy+yrA7+wJLuK/hi2++hyzE90Av1bO8emPl4vdobeaup1lfBoKcNPnR5Xi/ex2wJE7jgwb ZiEDMqw8d340OavTInDgcs710dqR516tS0v76gSCQd1wuP51tcu+jb5beZkShn2qFuzoIj WvV38uMkQ0R6DiiV3RUYKd75TSHf3Kk= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Stefano Stabellini , Russell King , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, Jan Beulich Subject: [PATCH] x86/xen: call xen_set_upcall_vector() only after local apic setup Date: Sat, 12 Nov 2022 14:23:36 +0100 Message-Id: <20221112132336.698-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Calling xen_set_upcall_vector() before the local APIC has been initialized results in warnings when setting up the local APIC: [ 0.037322] APIC: Stale IRR: 00080000, ... Avoid this problem by moving the call of xen_set_upcall_vector() for APs from xen_cpu_up_prepare_hvm() to a new hotplug callback called on the AP before interrupts are enabled and after the local APIC has been initialized. There is already a Xen specific hotplug state defined at a matching position, but right now it is specific to Arm. So rename the CPUHP_AP_ARM_XEN_STARTING to CPUHP_AP_XEN_STARTING and use it for x86, too. On the boot processor use the x86_init.irqs.intr_mode_init hook to call xen_set_upcall_vector() only after the local APIC initialization. As interrupts are on already at the time when the hook is being used, modify xen_init_setup_upcall_vector() to disable interrupts. This is needed as the xen_percpu_upcall flag is set only after the callback has been registered, and the flag is needed for correctly acknowledging an interrupt. Fixes: b1c3497e604d ("x86/xen: Add support for HVMOP_set_evtchn_upcall_vector") Reported-by: Jan Beulich Signed-off-by: Juergen Gross --- arch/arm/xen/enlighten.c | 4 ++-- arch/x86/xen/enlighten_hvm.c | 9 --------- drivers/xen/events/events_base.c | 22 +++++++++++++++++----- include/linux/cpuhotplug.h | 2 +- 4 files changed, 20 insertions(+), 17 deletions(-) diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index 93c8ccbf2982..1778a7a7c3ed 100644 --- a/arch/arm/xen/enlighten.c +++ b/arch/arm/xen/enlighten.c @@ -529,8 +529,8 @@ static int __init xen_guest_init(void) if (xen_initial_domain()) pvclock_gtod_register_notifier(&xen_pvclock_gtod_notifier); - return cpuhp_setup_state(CPUHP_AP_ARM_XEN_STARTING, - "arm/xen:starting", xen_starting_cpu, + return cpuhp_setup_state(CPUHP_AP_XEN_STARTING, + "xen:starting", xen_starting_cpu, xen_dying_cpu); } early_initcall(xen_guest_init); diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c index c1cd28e915a3..55d140cc6128 100644 --- a/arch/x86/xen/enlighten_hvm.c +++ b/arch/x86/xen/enlighten_hvm.c @@ -177,15 +177,6 @@ static int xen_cpu_up_prepare_hvm(unsigned int cpu) if (!xen_have_vector_callback) return 0; - if (xen_percpu_upcall) { - rc = xen_set_upcall_vector(cpu); - if (rc) { - WARN(1, "HVMOP_set_evtchn_upcall_vector" - " for CPU %d failed: %d\n", cpu, rc); - return rc; - } - } - if (xen_feature(XENFEAT_hvm_safe_pvclock)) xen_setup_timer(cpu); diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index c443f04aaad7..7609fedb2a33 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -39,6 +39,7 @@ #include #ifdef CONFIG_X86 +#include #include #include #include @@ -2209,16 +2210,27 @@ void xen_setup_callback_vector(void) */ static __init void xen_init_setup_upcall_vector(void) { + unsigned long flags; + + apic_intr_mode_init(); + if (!xen_have_vector_callback) return; + local_irq_save(flags); + if ((cpuid_eax(xen_cpuid_base() + 4) & XEN_HVM_CPUID_UPCALL_VECTOR) && - !xen_set_upcall_vector(0)) + !xen_set_upcall_vector(0)) { xen_percpu_upcall = true; + WARN_ON(cpuhp_setup_state(CPUHP_AP_XEN_STARTING, "xen:starting", + xen_set_upcall_vector, NULL)); + } else if (xen_feature(XENFEAT_hvm_callback_vector)) xen_setup_callback_vector(); else xen_have_vector_callback = false; + + local_irq_restore(flags); } int xen_set_upcall_vector(unsigned int cpu) @@ -2250,9 +2262,7 @@ static __init void xen_alloc_callback_vector(void) } #else void xen_setup_callback_vector(void) {} -static inline void xen_init_setup_upcall_vector(void) {} int xen_set_upcall_vector(unsigned int cpu) {} -static inline void xen_alloc_callback_vector(void) {} #endif /* CONFIG_XEN_PVHVM */ #endif /* CONFIG_X86 */ @@ -2314,9 +2324,11 @@ void __init xen_init_IRQ(void) if (xen_initial_domain()) pci_xen_initial_domain(); } - xen_init_setup_upcall_vector(); - xen_alloc_callback_vector(); +#ifdef CONFIG_XEN_PVHVM + x86_init.irqs.intr_mode_init = xen_init_setup_upcall_vector; + xen_alloc_callback_vector(); +#endif if (xen_hvm_domain()) { native_init_IRQ(); diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h index f61447913db9..c232ada4e4ca 100644 --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -191,7 +191,7 @@ enum cpuhp_state { CPUHP_AP_KVM_ARM_TIMER_STARTING, /* Must be the last timer callback */ CPUHP_AP_DUMMY_TIMER_STARTING, - CPUHP_AP_ARM_XEN_STARTING, + CPUHP_AP_XEN_STARTING, CPUHP_AP_ARM_CORESIGHT_STARTING, CPUHP_AP_ARM_CORESIGHT_CTI_STARTING, CPUHP_AP_ARM64_ISNDEP_STARTING, -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Sat Nov 12 14:10:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 12 Nov 2022 14:10:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442810.697259 (Exim 4.92) (envelope-from ) id 1otrCm-0002Pr-M1; Sat, 12 Nov 2022 14:09:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442810.697259; Sat, 12 Nov 2022 14:09:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otrCm-0002Pk-JP; Sat, 12 Nov 2022 14:09:56 +0000 Received: by outflank-mailman (input) for mailman id 442810; Sat, 12 Nov 2022 14:09:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otrCl-0002Pa-3f; Sat, 12 Nov 2022 14:09:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otrCl-000700-0J; Sat, 12 Nov 2022 14:09:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otrCk-0003mi-Fa; Sat, 12 Nov 2022 14:09:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otrCk-0004Wu-F3; Sat, 12 Nov 2022 14:09:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SwlSzC9S1raF7av3slL6cJbc6LbXiq0YgSMQgwQbuWI=; b=U67rhu1VbvWBfbo6mufRTEhc3U 7hrHrR5oGoK/VDm1soSsgvkiYT4evN/r9FroOIBtStfRJsyci160Mju/yH2klO8GdDfUS3GAf1ezW UxzlVWDeUxqbLAyM7NUUYdqIjKAjfSbostpSDGQHqDOILHpdDna8WEavfMr4jX9Uce54=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174743: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-arm64-pvops:kernel-build:fail:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=6a4cff8e1a80bafc4b8fe2bfb10081f4880d1b3b X-Osstest-Versions-That: qemuu=2ccad61746ca7de5dd3e25146062264387e43bd4 From: osstest service owner Date: Sat, 12 Nov 2022 14:09:54 +0000 flight 174743 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174743/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 174708 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174708 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174708 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174708 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174708 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174708 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174708 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174708 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174708 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 6a4cff8e1a80bafc4b8fe2bfb10081f4880d1b3b baseline version: qemuu 2ccad61746ca7de5dd3e25146062264387e43bd4 Last test of basis 174708 2022-11-10 07:14:28 Z 2 days Testing same since 174743 2022-11-12 03:09:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ahmed Abouzied Daniel Henrique Barboza Laurent Vivier Michael S. Tsirkin Miroslav Rezanina Philippe Mathieu-Daudé Stefan Hajnoczi Stefan Weil Thomas Huth Xuan Zhuo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 389 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 12 15:02:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 12 Nov 2022 15:02:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442821.697273 (Exim 4.92) (envelope-from ) id 1ots18-0000wr-RE; Sat, 12 Nov 2022 15:01:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442821.697273; Sat, 12 Nov 2022 15:01:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ots18-0000wk-OL; Sat, 12 Nov 2022 15:01:58 +0000 Received: by outflank-mailman (input) for mailman id 442821; Sat, 12 Nov 2022 15:01:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ots16-0000wa-VD; Sat, 12 Nov 2022 15:01:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ots16-00088G-Pt; Sat, 12 Nov 2022 15:01:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ots16-0007NU-Fv; Sat, 12 Nov 2022 15:01:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ots16-00066U-FU; Sat, 12 Nov 2022 15:01:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oyscHnFxbBqBkSJZNzyJcnlgEewk419M+N55RF5nb6I=; b=EgfFeQGN9/pEmwA8w/9WeyQLuU kPd4J7TZm8ewvsFJZDPDWH2ziDgycOjQD03j/ax6FRjwanXf4XCqWrc/rIk8TTDNQO+e+F33A6DcO VTX3njnK30n78WYV4qLs6nEEhi594xcPqutx1Mw0dnS1Q11xUdBM7LAfSvZfcQQkDtVs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174744: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=e5d86975857f1ca5431a84c460adc5bd4a260795 X-Osstest-Versions-That: libvirt=697e26fac66d9b1458ad67261014284c249ecd2d From: osstest service owner Date: Sat, 12 Nov 2022 15:01:56 +0000 flight 174744 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174744/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174731 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174731 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174731 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt e5d86975857f1ca5431a84c460adc5bd4a260795 baseline version: libvirt 697e26fac66d9b1458ad67261014284c249ecd2d Last test of basis 174731 2022-11-11 04:18:49 Z 1 days Testing same since 174744 2022-11-12 04:19:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Haibin Huang Jim Fehlig Lin Yang Michal Privoznik Tim Wiederhake jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 697e26fac6..e5d8697585 e5d86975857f1ca5431a84c460adc5bd4a260795 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Nov 12 19:02:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 12 Nov 2022 19:02:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442880.697285 (Exim 4.92) (envelope-from ) id 1otvlD-0002ch-Hk; Sat, 12 Nov 2022 19:01:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442880.697285; Sat, 12 Nov 2022 19:01:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otvlD-0002ca-Cd; Sat, 12 Nov 2022 19:01:47 +0000 Received: by outflank-mailman (input) for mailman id 442880; Sat, 12 Nov 2022 19:01:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otvlC-0002cQ-N3; Sat, 12 Nov 2022 19:01:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otvlC-0005yM-I6; Sat, 12 Nov 2022 19:01:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otvlC-0004FE-2S; Sat, 12 Nov 2022 19:01:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otvlC-0003qv-1v; Sat, 12 Nov 2022 19:01:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=D5a2Pp0hrrc3xu9CDqJwqPJQZlup2cBoQ+N53aVw/tQ=; b=5g/hKL3nHteiwgOHwku2fMmYdW 6k1ji+Y+/AwG/8DbA8r0H0Po9LRX93jm3jd5/tE+whROPve2GlYmUOTa7dDM198BrR4ojseu46m+j e5Bc5uoLfOnuEiHakVqbv4qrwxazAnapFxKOfepGTBByKQmUoHfHOKgbxild2xHD3w30=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174745: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=8f2975c2bb4c6fd43d778db55481fc11806c8773 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sat, 12 Nov 2022 19:01:46 +0000 flight 174745 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174745/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 8f2975c2bb4c6fd43d778db55481fc11806c8773 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 36 days Failing since 173470 2022-10-08 06:21:34 Z 35 days 57 attempts Testing same since 174745 2022-11-12 06:45:22 Z 0 days 1 attempts ------------------------------------------------------------ 1698 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 161754 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 12 19:19:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 12 Nov 2022 19:19:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442886.697296 (Exim 4.92) (envelope-from ) id 1otw2P-0004Ug-Up; Sat, 12 Nov 2022 19:19:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442886.697296; Sat, 12 Nov 2022 19:19:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otw2P-0004UZ-RK; Sat, 12 Nov 2022 19:19:33 +0000 Received: by outflank-mailman (input) for mailman id 442886; Sat, 12 Nov 2022 19:19:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otw2O-0004UP-13; Sat, 12 Nov 2022 19:19:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otw2N-0006Pi-J7; Sat, 12 Nov 2022 19:19:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otw2N-0004xB-2Q; Sat, 12 Nov 2022 19:19:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otw2N-00021a-1y; Sat, 12 Nov 2022 19:19:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=G6BNhhVEbR8wa6otOLTxqSgiAikuFeH4Eicgx+0INJI=; b=3+mR4Xw27ySXOh5RfKNP0zSo0s 5fa480Z47eqloNHRfHQlJSYQ9Nxt9iyjuJ7lCbB4hDhN+5IffP4aQTnjMT9Q128yzRLoOztdZDhZe Pt2uxZT6Zy4wFoTVDojKchSHtjwvg7H1qKKmlfwriw69VVZnNf+p3hWvDrXTWKXB4ENY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174746: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=771a8acbb84145b943bd608ba376e104ebfa9664 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Sat, 12 Nov 2022 19:19:31 +0000 flight 174746 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174746/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174740 REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 174740 pass in 174738 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail pass in 174740 test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 174740 test-armhf-armhf-xl-credit1 14 guest-start fail pass in 174740 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 174740 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 174740 never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 174740 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 174740 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 771a8acbb84145b943bd608ba376e104ebfa9664 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 14 days Failing since 174575 2022-11-01 18:42:39 Z 11 days 20 attempts Testing same since 174727 2022-11-10 22:13:32 Z 1 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anna Schumaker Anssi Hannula Ard Biesheuvel Arnaldo Carvalho de Melo Biju Das Brian Foster Brian Norris Carlos Llamas Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Chuhong Yuan Damien Le Moal Dan Carpenter Darrick J. Wong Darrick J. Wong Dave Chinner Dave Chinner David S. Miller David Sterba Dean Luick Demi Marie Obenour Dennis Dalessandro Dokyung Song Dongliang Mu Eric Dumazet Eric Sandeen Filipe Manana Florian Fainelli Gaosheng Cui Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Han Xu Hangyu Hua Hannu Hartikainen Hans Verkuil Heiko Carstens Heiko Stuebner Helge Deller Hyong Youb Kim Hyunwoo Kim Håkon Bugge Ilias Apalodimas Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jason Gunthorpe Jeff Vanhoof Jens Axboe Jens Glathe Jim Mattson Jimmy Assarsson Jiri Kosina Johan Hovold John Veness Jon Hunter Jon Maloy Jonathan Cameron Jonathan Corbet Josh Poimboeuf Juergen Gross Julian Anastasov Justin Chen Kalle Valo Kan Liang Konrad Jankowski Kuniyuki Iwashima Kuogee Hsieh Leon Romanovsky Leon Romanovsky Li Qiang Linus Torvalds Linux Kernel Functional Testing Luiz Augusto von Dentz Luiz Capitulino Luís Henriques M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Martin K. Petersen Martin Tůma Masami Hiramatsu (Google) Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Maxim Levitsky Maxim Mikityanskiy Meena Shanmugam Michal Hocko Michal Jaron Michal Simek Mike Kravetz Miklos Szeredi Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Pablo Neira Ayuso Paolo Abeni Paolo Bonzini Paul E. McKenney Paul Moore Peter Zijlstra (Intel) Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rasmus Villemoes Richard Weinberger Rik van Riel Saeed Mahameed Sakari Ailus Samuel Bailey Sascha Hauer Sasha Levin Serge Hallyn Sergey Shtylyov Shakeel Butt Shang XiaoJing Shreeya Patel Shuah Khan Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Theodore Ts'o Thinh Nguyen Tim Harvey Tom Lendacky Tomasz Moń Tony O'Brien Trond Myklebust Tvrtko Ursulin Uday Shankar Ulf Hansson Vasily Averin Vasily Gorbik Ville Syrjälä Vineet Gupta Vladimir Oltean Wei Yongjun Willy Tarreau Wolfram Sang Xin Long Yang Yingliang Ye Bin Yongqin Liu Yu Kuai Zhang Changzhong Zhang Qilong Zhang Xiaoxu Zheng Yejian Zhengchao Shao Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 4692 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 12 23:23:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 12 Nov 2022 23:23:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442902.697319 (Exim 4.92) (envelope-from ) id 1otzq2-0006Df-LY; Sat, 12 Nov 2022 23:23:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442902.697319; Sat, 12 Nov 2022 23:23:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otzq2-0006DY-Hk; Sat, 12 Nov 2022 23:23:02 +0000 Received: by outflank-mailman (input) for mailman id 442902; Sat, 12 Nov 2022 23:23:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otzq1-0006DO-77; Sat, 12 Nov 2022 23:23:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otzq1-0003Dv-4Y; Sat, 12 Nov 2022 23:23:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1otzq0-0001b6-Ks; Sat, 12 Nov 2022 23:23:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1otzq0-0005Rn-I9; Sat, 12 Nov 2022 23:23:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XXa+UxeUkGBnmG30n3X5NTOg4R7+UhBOOuUpj2+lZh4=; b=R+znIR2C9KBDrrmyoqARcF/P9C 8zaQp9nu07npp5Cws50urgZes0hEIzWLJ+MftufXaIKwR+WPluuKnGoysNoCVW+qaeMWHymUpOEnq Z87XjN7zbzQcNh/gc4KV5IHjYDGe23fabK5yvKMSds0fbVZYoKPrff/Y0r5rcBEU1jJw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174747: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 X-Osstest-Versions-That: xen=08c6f57cfebad4046dabc05092b4a27c61a39980 From: osstest service owner Date: Sat, 12 Nov 2022 23:23:00 +0000 flight 174747 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174747/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174742 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174742 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174742 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174742 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174742 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174742 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174742 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174742 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174742 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174742 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174742 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174742 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 baseline version: xen 08c6f57cfebad4046dabc05092b4a27c61a39980 Last test of basis 174742 2022-11-12 01:53:47 Z 0 days Testing same since 174747 2022-11-12 12:39:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 08c6f57cfe..17dfc79ce9 17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 -> master From xen-devel-bounces@lists.xenproject.org Sun Nov 13 00:53:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 13 Nov 2022 00:53:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442910.697330 (Exim 4.92) (envelope-from ) id 1ou1Ev-0008Pr-Ub; Sun, 13 Nov 2022 00:52:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442910.697330; Sun, 13 Nov 2022 00:52:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ou1Ev-0008Pk-Q6; Sun, 13 Nov 2022 00:52:49 +0000 Received: by outflank-mailman (input) for mailman id 442910; Sun, 13 Nov 2022 00:52:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ou1Eu-0008Pa-OX; Sun, 13 Nov 2022 00:52:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ou1Eu-0005jO-JN; Sun, 13 Nov 2022 00:52:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ou1Eu-0006EO-2W; Sun, 13 Nov 2022 00:52:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ou1Eu-0005OQ-25; Sun, 13 Nov 2022 00:52:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tVDfz3vhsv/d+9noSaJpd2uwK6awrN5EwdKq5DPL5CE=; b=t6JxUP6ut/Nkirf7nqH4U7SoZO 2Nn01c46HlZoG5h384f6azRc63eAma+cLcomu+5cmPb3CPo2Btp1op2kNwTl1x2phA3NttkC16O6t s8J7lEZmmkdChzkKDCaEqnMg3jP0yNJhCGMLz/vSANICFmZEssGA0FcEnmRVfzjrsVHs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174749: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-arm64-pvops:kernel-build:fail:regression qemu-mainline:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug qemu-mainline:test-amd64-i386-xl-vhd:guest-start.2:fail:heisenbug qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=6a4cff8e1a80bafc4b8fe2bfb10081f4880d1b3b X-Osstest-Versions-That: qemuu=2ccad61746ca7de5dd3e25146062264387e43bd4 From: osstest service owner Date: Sun, 13 Nov 2022 00:52:48 +0000 flight 174749 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174749/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail in 174743 REGR. vs. 174708 Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 10 xen-install/src_host fail pass in 174743 test-amd64-i386-xl-vhd 22 guest-start.2 fail pass in 174743 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-seattle 1 build-check(1) blocked in 174743 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 174743 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 174743 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 174743 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 174743 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 174743 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 174743 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 174743 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 174743 n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174708 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174708 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174708 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174708 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174708 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174708 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174708 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174708 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 6a4cff8e1a80bafc4b8fe2bfb10081f4880d1b3b baseline version: qemuu 2ccad61746ca7de5dd3e25146062264387e43bd4 Last test of basis 174708 2022-11-10 07:14:28 Z 2 days Testing same since 174743 2022-11-12 03:09:00 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Ahmed Abouzied Daniel Henrique Barboza Laurent Vivier Michael S. Tsirkin Miroslav Rezanina Philippe Mathieu-Daudé Stefan Hajnoczi Stefan Weil Thomas Huth Xuan Zhuo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 389 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 13 07:35:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 13 Nov 2022 07:35:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442930.697342 (Exim 4.92) (envelope-from ) id 1ou7WC-0008Q5-7S; Sun, 13 Nov 2022 07:35:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442930.697342; Sun, 13 Nov 2022 07:35:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ou7WC-0008Py-1J; Sun, 13 Nov 2022 07:35:04 +0000 Received: by outflank-mailman (input) for mailman id 442930; Sun, 13 Nov 2022 07:35:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ou7WB-0008Po-96; Sun, 13 Nov 2022 07:35:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ou7WB-00059D-2i; Sun, 13 Nov 2022 07:35:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ou7WA-0002wL-LF; Sun, 13 Nov 2022 07:35:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ou7WA-0001Js-Kj; Sun, 13 Nov 2022 07:35:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=G9OvhSzby1YadwCUBaYdWJaKj8YrQwLKL53FeifOvck=; b=lQp+bUnvWBT5WnZDQh8qGOF/1/ GozH2aMJdWBMccOQB+xmS0k0BfE9LSaGSfWvh0DXU8cbh25JKXxpNlqz2IrQDhNlqdWp1PXcpWUdk plyd2ucO/img6gZh5VT9A2EGXPMdjD2RwK+8RoQ4P3p0Taoo9DyXr95gC57lceUMN8nA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174750: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=fef7fd48922d11b22620e19f9c9101647bfe943d X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sun, 13 Nov 2022 07:35:02 +0000 flight 174750 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174750/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux fef7fd48922d11b22620e19f9c9101647bfe943d baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 36 days Failing since 173470 2022-10-08 06:21:34 Z 36 days 58 attempts Testing same since 174750 2022-11-12 19:13:14 Z 0 days 1 attempts ------------------------------------------------------------ 1700 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 161904 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 13 08:16:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 13 Nov 2022 08:16:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442943.697352 (Exim 4.92) (envelope-from ) id 1ou8A8-0005OZ-Nr; Sun, 13 Nov 2022 08:16:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442943.697352; Sun, 13 Nov 2022 08:16:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ou8A8-0005OS-KA; Sun, 13 Nov 2022 08:16:20 +0000 Received: by outflank-mailman (input) for mailman id 442943; Sun, 13 Nov 2022 08:16:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ou8A7-0005OI-66; Sun, 13 Nov 2022 08:16:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ou8A7-0006e7-00; Sun, 13 Nov 2022 08:16:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ou8A6-00048z-FH; Sun, 13 Nov 2022 08:16:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ou8A6-0005le-Ep; Sun, 13 Nov 2022 08:16:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FLHCv6yTcAG6HUwLD/by9GFnuIwNZI6i7MxSp8G2hcA=; b=qRiygE0fo9gV12H/R7MqV6ALdT bB7CPdbkuSAPmQIW5Kzj3KyTHQZm8EV5cRhNbS0ykDt3SLcVUesqbEQCiWiyPhI/IDAnKcbjxmLRl X4Owc6U0+dTuE9A6LXB0fCSttVY5c7xcHFJuUBNRIEFohysnegk6pf16DHOZHx5PjSls=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174751: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=771a8acbb84145b943bd608ba376e104ebfa9664 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Sun, 13 Nov 2022 08:16:18 +0000 flight 174751 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174751/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174740 REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail in 174746 pass in 174751 test-armhf-armhf-xl-credit1 14 guest-start fail in 174746 pass in 174751 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 174746 pass in 174751 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 174738 test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 174740 test-amd64-i386-xl-shadow 7 xen-install fail pass in 174746 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail pass in 174746 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 174740 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 174740 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 771a8acbb84145b943bd608ba376e104ebfa9664 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 14 days Failing since 174575 2022-11-01 18:42:39 Z 11 days 21 attempts Testing same since 174727 2022-11-10 22:13:32 Z 2 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anna Schumaker Anssi Hannula Ard Biesheuvel Arnaldo Carvalho de Melo Biju Das Brian Foster Brian Norris Carlos Llamas Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Chuhong Yuan Damien Le Moal Dan Carpenter Darrick J. Wong Darrick J. Wong Dave Chinner Dave Chinner David S. Miller David Sterba Dean Luick Demi Marie Obenour Dennis Dalessandro Dokyung Song Dongliang Mu Eric Dumazet Eric Sandeen Filipe Manana Florian Fainelli Gaosheng Cui Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Han Xu Hangyu Hua Hannu Hartikainen Hans Verkuil Heiko Carstens Heiko Stuebner Helge Deller Hyong Youb Kim Hyunwoo Kim Håkon Bugge Ilias Apalodimas Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jason Gunthorpe Jeff Vanhoof Jens Axboe Jens Glathe Jim Mattson Jimmy Assarsson Jiri Kosina Johan Hovold John Veness Jon Hunter Jon Maloy Jonathan Cameron Jonathan Corbet Josh Poimboeuf Juergen Gross Julian Anastasov Justin Chen Kalle Valo Kan Liang Konrad Jankowski Kuniyuki Iwashima Kuogee Hsieh Leon Romanovsky Leon Romanovsky Li Qiang Linus Torvalds Linux Kernel Functional Testing Luiz Augusto von Dentz Luiz Capitulino Luís Henriques M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Martin K. Petersen Martin Tůma Masami Hiramatsu (Google) Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Maxim Levitsky Maxim Mikityanskiy Meena Shanmugam Michal Hocko Michal Jaron Michal Simek Mike Kravetz Miklos Szeredi Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Pablo Neira Ayuso Paolo Abeni Paolo Bonzini Paul E. McKenney Paul Moore Peter Zijlstra (Intel) Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rasmus Villemoes Richard Weinberger Rik van Riel Saeed Mahameed Sakari Ailus Samuel Bailey Sascha Hauer Sasha Levin Serge Hallyn Sergey Shtylyov Shakeel Butt Shang XiaoJing Shreeya Patel Shuah Khan Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Theodore Ts'o Thinh Nguyen Tim Harvey Tom Lendacky Tomasz Moń Tony O'Brien Trond Myklebust Tvrtko Ursulin Uday Shankar Ulf Hansson Vasily Averin Vasily Gorbik Ville Syrjälä Vineet Gupta Vladimir Oltean Wei Yongjun Willy Tarreau Wolfram Sang Xin Long Yang Yingliang Ye Bin Yongqin Liu Yu Kuai Zhang Changzhong Zhang Qilong Zhang Xiaoxu Zheng Yejian Zhengchao Shao Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 4692 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 13 10:41:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 13 Nov 2022 10:41:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442969.697363 (Exim 4.92) (envelope-from ) id 1ouAQa-0004sS-3S; Sun, 13 Nov 2022 10:41:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442969.697363; Sun, 13 Nov 2022 10:41:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouAQa-0004sL-0g; Sun, 13 Nov 2022 10:41:28 +0000 Received: by outflank-mailman (input) for mailman id 442969; Sun, 13 Nov 2022 10:41:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouAQY-0004sB-PN; Sun, 13 Nov 2022 10:41:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouAQY-0001Df-LF; Sun, 13 Nov 2022 10:41:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouAQY-0003Mn-6D; Sun, 13 Nov 2022 10:41:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouAQY-0007WR-5f; Sun, 13 Nov 2022 10:41:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KNu0Uzss5frTcIDjiku6ZeZD4KFqQ9CXAG0KFlHWtmw=; b=cs0SMqV2HaaaHc+P3vTtX7sH8m fFoitzAfDJi/bhWwiDRBoWy3IZK1j36uE5LjUY9+5cuG+yjPUrFF1C7t3CPVeuZ3Ehq4ecA1buxH3 PbVsei/CuAQSbFaB8Yx60alONmGHBPRjGXHn7zMQXpLWdYIFOaaG8tSeKFxQVN2kXQNs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174752: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=6a4cff8e1a80bafc4b8fe2bfb10081f4880d1b3b X-Osstest-Versions-That: qemuu=2ccad61746ca7de5dd3e25146062264387e43bd4 From: osstest service owner Date: Sun, 13 Nov 2022 10:41:26 +0000 flight 174752 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174752/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174708 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174708 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174708 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174708 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174708 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174708 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174708 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174708 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 6a4cff8e1a80bafc4b8fe2bfb10081f4880d1b3b baseline version: qemuu 2ccad61746ca7de5dd3e25146062264387e43bd4 Last test of basis 174708 2022-11-10 07:14:28 Z 3 days Testing same since 174743 2022-11-12 03:09:00 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Ahmed Abouzied Daniel Henrique Barboza Laurent Vivier Michael S. Tsirkin Miroslav Rezanina Philippe Mathieu-Daudé Stefan Hajnoczi Stefan Weil Thomas Huth Xuan Zhuo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 2ccad61746..6a4cff8e1a 6a4cff8e1a80bafc4b8fe2bfb10081f4880d1b3b -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Nov 13 11:12:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 13 Nov 2022 11:12:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442979.697374 (Exim 4.92) (envelope-from ) id 1ouAuh-00008p-HH; Sun, 13 Nov 2022 11:12:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442979.697374; Sun, 13 Nov 2022 11:12:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouAuh-00008i-Dm; Sun, 13 Nov 2022 11:12:35 +0000 Received: by outflank-mailman (input) for mailman id 442979; Sun, 13 Nov 2022 11:12:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouAug-00008c-15 for xen-devel@lists.xenproject.org; Sun, 13 Nov 2022 11:12:34 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0f682180-6344-11ed-8fd2-01056ac49cbb; Sun, 13 Nov 2022 12:12:30 +0100 (CET) Received: from mail-dm6nam12lp2170.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Nov 2022 06:12:26 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by SJ0PR03MB6221.namprd03.prod.outlook.com (2603:10b6:a03:3ab::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Sun, 13 Nov 2022 11:12:25 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%4]) with mapi id 15.20.5813.017; Sun, 13 Nov 2022 11:12:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f682180-6344-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668337950; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=0Hi6ePSm2uVE6xnHiWvSI3W7dG5dku8deEBf88wrVkQ=; b=X1zr3Ay9kXi492OQjzwaevFEgZZ4MUglfzSAVKp4QpGE6xipEEZAlIb0 RtilsJAWl5zxY7crrsSN1T46RgHgrNym/+l3Bp+xBi4D8ezYQWMFRPfxQ p5O2k5AFIjLCwU23Z68D9t7drrfIEtM3sVcCIm6XViPVd6KPADlowMEia 4=; X-IronPort-RemoteIP: 104.47.59.170 X-IronPort-MID: 84308149 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:zfrzgaJ7+pzjVaaEFE+R4pQlxSXFcZb7ZxGr2PjKsXjdYENS0WBVz jMYDD+FPqqPZ2Ojeowkad/n8kxU7ZaGyoRnTANlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wVlPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5vIGF0q fUdDgpOdwvY3tCNmJSeGsxV05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMlGSd05C0WDbRUtGGW8RT2Fqfv GXF12/4HgsbJJqUzj/tHneE1rOUxXOiBNN6+LuQzeU3vQah60kvKQA8SmC5p8iwsXCSRIcKQ 6AT0m90xUQoz2S7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZh5MbsY38vA/QzMC3 0WM2djuAFRHvLSLRFqH+7yTrDf0PjIaRUcdYQcUQA1D5MPsyLzflTrKR9dnVaKw0Nv8HGiqx yjQ9XdmwbIOkcQMyqO3u0jdhC6hrYTISQhz4RjLWmWi7UVyY4vNi5GU1GU3JM1odO6xJmRtd lBd8yRCxIji1a2wqRE= IronPort-HdrOrdr: A9a23:d9GbTa3Kdz6/wCYKrUy9YAqjBZpxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LoSK05KX8Gx242A5bdz9U278t/U XMjgS8v8yYwrCG4y6Z81WWw4VdmdPnxNcGLMuQivINIjGpphe0aJ9nU7iiuilwhO208l4lnP TFvh9lFcVu7HH6eH2zvHLWqkfd+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ g7nF6xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklUqvoXRiKrbzPIt MeS/0018wmN29yqEqp51WH9ebcGkjb2C32GnTq9PbliAS+10oJsnfwjPZv4kvosqhNC6Wsrt 60TJhAhfVASNQbYrl6A/pEScyrCnbVSRaJK26KJ0/7fZt3ck4kO/bMkcoIDcyRCes1JaEJ6e L8eUIdsXR3d1PlCMWI0pEO+hfRQH+lVTCozs1F/ZB2trD1WbKuaES4ORsTutrlp+9aDtzQWv 61Np4TC/j/LXH2EYIM2wHlQZFdJXQXTcVQsNcmXFCFpN7NN+TRx6TmWeeWIKCoHScvW2v5DH dGVD/vJN9Y5kTuQXP8iAi5YQKYRqU+x+MELEH3xZlh9GFWDPw8juE8syXI2uibbTtfr6cxYE xyZLv6j6LTnxjFwVr1 X-IronPort-AV: E=Sophos;i="5.96,161,1665460800"; d="scan'208";a="84308149" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vdq787LwmqBRogh5Ou1WcUW/Uztfhwu6LwXjHBGVT0y+0px9fZj+lQ52FbAp7m7Ms0W5c5nchuPno0pzf/bl8pCuCuucp8muzllRYkhggw69yOdOKhYYdQAd11hcFhgIk/MbBL1Wb0siZU9BBeX8+Su1uFaGsjHXzrBQR8htWT7/xHiL5HTr/otdKt/YByve6mkwpBskpYpOTI/iU8/OjpSMR+OiPUM90MAzLPfFRzamcKfWov5ih+WaQZaaS2tkUmgc+X4CXRAyWjVJJQGo3CPNrHNpsL1gOreMvOBfTg3Y6cpmwhxrR5lmA7mI1XJhDyVLWC5OViS1EkI9cCvUhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P6bmGn9NFYDHljzIZ3nIV4aKlkw1EmJnaglQNUbX9L4=; b=TYzsy10JPhCG6NQxLUuO1hp79PUrho1bGC29OamQJxYwTtYw6qZYzTqDWVZM4+tkPrR32ErnfSRurnCy3Pc/bsxGCKURpqHknhc2+Fj9upNjgV1hJQ4A7Yok/L9mz5apQc3Nql18E6gqVJ0Qs8zaNett7xS9gGbDUnV0CDhJBiKgxGGPxTxGfwTMBG+flSTKl1n6Szh9J7Bfo/Z7J+nIlCnYLgN1kvK/B54QIkEk4zD63Ssrl1778WvVww/+GlnNbghWNOA5hZ5bvju5qt3eJDRzDUpZ2uiAsslnlT5jyRDaBhIHHvOq0+Fijo98AWUwWqrJM8bXjGSkyb3995FiVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P6bmGn9NFYDHljzIZ3nIV4aKlkw1EmJnaglQNUbX9L4=; b=Qawg+mUbaCWgSuNTH9r+QOVHoaB9b6bEVNVx6IUgar0FJHwnz8LrByopruLVw3vRpmWowVYJSVMjSyLFKDbd6ZtLo49eK9K10Z+Dd8UkqweMWF8tWkIV81Qwou7Q0iGgw1OQQrlnfQVTzuFbMLdkfXYRKSk2NgI6DeEoqaVPcqA= From: Edwin Torok To: Andrew Cooper CC: "xen-devel@lists.xenproject.org" , Henry Wang , Christian Lindig , David Scott , Wei Liu , Anthony Perard Subject: Re: Summary: Re: [PATCH for-4.17 v3 00/15] OCaml fixes for Xen 4.17 Thread-Topic: Summary: Re: [PATCH for-4.17 v3 00/15] OCaml fixes for Xen 4.17 Thread-Index: AQHY84ehGvE29j6O1UW/SkvcImf7eq46Nk6AgAECtwA= Date: Sun, 13 Nov 2022 11:12:24 +0000 Message-ID: <083B5B38-7005-46DD-B28C-4832B9EBAB9B@citrix.com> References: <75fef917-499d-ab02-9429-39ed59d87c97@citrix.com> In-Reply-To: <75fef917-499d-ab02-9429-39ed59d87c97@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|SJ0PR03MB6221:EE_ x-ms-office365-filtering-correlation-id: f24d4d27-19d0-4071-b392-08dac567f143 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: w4XFo1Po6nrEKiK2GP3cas8tjjGcQGzBRXMQzAon+qO9jlErD0TDPPBlwe6FV5zT6b2Pz4TxKZDWqzyh9gczU9EuCRaDoYIM5MqSJTxk/7fXCGc0mJL0dDBbGF0WRgblaKiNXlM1luZkwYQm0s6slMX5Pydtrpo965CmlHWhksEFaXBmPJF8LdZVpzO9t7IhLjAdWqV3LdAhpHJm1EORTvgrEVvC37Q/XDrUAPFGO4nJ7VpgHB5O1pGD2d4d6IMgc+gGMJtxWGxrCwJGteNoFCS3x3FsVWh3nUClB9T6Oj0/mEV+DZIU+pKzMXp5gUiKUzLL1G7vA6wCC/FtOA/jm0CDqxzaD8SMu+ghKC9QZ+76UeAxFHZ20HwdTF0KkquFsCWM+KbWPqWFtINcOVNB/DQG5OeagxbB/qRrszClN+rky6Qgofbx0FLdq9x3SfbSdwONT2rfSxSkoX4Uj/f8PUz0kJqTZLtXRiU+RCYY2f+rxgnrnYomma5a5xL++czDWN0Ojp/QtZoUYuNW10Cf2ofIX+Bd8DbhbFvqRb8QishqGY2wuLYHqgyYU3bZWI980Cg/I8zXIPwZ7+w++kVxtKxIogal/UidBI3LdE428nOIrzm9HfOyDnD9KsrNTURW7KmRMwvU4kNP0+GrjkMox/3PXzTCUA35/HkBTvgnkYQOHdpdQrzpmZ06Q3DvTQDBLynMyjG0YXL4osNMrq3iiN0NalC2d1Sxh3kiTyxFfTErfA2Hy02htnknnzBNu2xkMZ6LG9ZeiYKyeVF+dn5pr8Bs1mZfr0v99PTyLYS8qWP5IJDS72ifKiGY3k81E0ttYzenaNcKpP79rWyrRI8T0qyLsb/IOWP4NMDzWn07rzICSZemzA4RSCIxYzzrDt4g x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(39860400002)(366004)(451199015)(71200400001)(36756003)(54906003)(37006003)(6636002)(53546011)(33656002)(316002)(107886003)(122000001)(2906002)(38100700002)(6506007)(82960400001)(83380400001)(41300700001)(6512007)(8676002)(4326008)(64756008)(91956017)(26005)(66946007)(66556008)(66476007)(186003)(86362001)(66446008)(5660300002)(76116006)(38070700005)(2616005)(8936002)(6862004)(966005)(6486002)(66899015)(478600001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UeA+0kvif7CBKxZUV0uyMMb5AajELF24wT9iS4Ki8cbj5uXlYTZ95auhwvdN?= =?us-ascii?Q?yy7GDVVoBoSskbZ/V/brNt44mQ37pUnAKCnz/oSayJ+vWc09MKrfUHTGmvTH?= =?us-ascii?Q?0K5cZyLX83KAbuDuEynvV6Y0UMNCdlhUsZou90fqobZKDKOER9+KbItg/r+W?= =?us-ascii?Q?4V/6HbV1+vJmVOKwaBJhT7XydSwj3ScamZuztRvh2Bdp1hTgqsbifKp4CR4e?= =?us-ascii?Q?AvdUobkOG+aCyVwJwEGSItDCt8LD6GnQV3QgVrI7Ndwaqt+o1SWs4LWjDDvr?= =?us-ascii?Q?jogrgI41WDSI+6krGPX4UJVWtGsZ8FtFIN8Yw/T0QauE6+eahj3C8imOluFz?= =?us-ascii?Q?STBn0LQ+tlIYmicIfnaQoUUXpCQoT5uOmFx/BuoAft7zjdqAotmEBQ8DBnk8?= =?us-ascii?Q?rU8UJRE+CDZ4U+bDAdNEchcf3drJ91FyfzT0PqFw4BRxwbij/WiSZz+Kn65L?= =?us-ascii?Q?6nSv95fY/ru0yLDWIIjhblXD/od7ZZfzNJvjADtPaclht3EhjX+8QHrr2wlq?= =?us-ascii?Q?yDHbF6ugnwJsjpKCt2sMrDn/wd8jeWgfY7cXrPdlpBSLbR2PMbWLs5e1VrVS?= =?us-ascii?Q?KSBy0CmbIOE8/zDID5tcvBI6VuHN+SGgdPwGToSLf4yLOki/bfxGnGB4Pcgo?= =?us-ascii?Q?nyWwiyoNMO2f1TfRXZoiUIKFiA7lI0W7ty71VJFBOoJTQALfEHEtEk1fdAvB?= =?us-ascii?Q?nLBL7KdIOlvRl0s6llrZNEtfOFoE67sLkFgH3Aqs6bTop6qPAKhgjU/micLV?= =?us-ascii?Q?1aKlPsKyofY4MnJPPsvQ8nOUiAPNjWpKQpk0asduF8s/F7DuNiP3uWhiYUP9?= =?us-ascii?Q?Kp1EcT9VPyBKV7p8KRb2RhndC9EPgMIKygQThqmFf4DIirUOUuV7HP5hvAMl?= =?us-ascii?Q?77v9f+uXniCEn4tdv5wGcTit+za/s/ZsOyTBGylvqyvm4xiupwSI+rvE8vCw?= =?us-ascii?Q?/sMsh6t7JbAB1Rpb/n996ntQk+rL5tE6cy+vghEyuZH1Kz6Hlv63TDLtnj9Q?= =?us-ascii?Q?h50XJ2BK6NyrM5ePlb5RQukDtvgCEWcpy9lzdntBVWVyo1QokkzDpMQpTSBr?= =?us-ascii?Q?LDI7N5qrgU7O8ENt21VoHmBbRpLZupj/PyBq6cdv+X0grpBRzRYqukvLxjzE?= =?us-ascii?Q?1bAHH9RksFO5B8T42UrlvUHlGyNeXl6fkKIkkf0W8hYEuQk36TTONK7ddvAE?= =?us-ascii?Q?6sVsQsNgXKSMbE7lRB41rqqsmaQ4EcR0sW6/PIwV4zTP+sJncP1qdr58S9us?= =?us-ascii?Q?mLgCVpUodTvuttOZ245B5Eu+o0OvL2ofPOCTt4w+xq2G3AUbM490DWkMIGJu?= =?us-ascii?Q?f2Nc6jPD9CH2i14aEwjR8tUsZM9enyu8+dmA5IW7ZGZWzDBQJS18xl9hLe9V?= =?us-ascii?Q?VEOJhjyMDAgzYcak8KcnBnBlwppMmFyZ9TgXwbJW2ohLYOCuae40yMP8pqzF?= =?us-ascii?Q?fYXdIPCS1Dus2T6iD8s1FMLPKkCaj2jTH7vfLy/QQLL3nmx0o3UlhO0zDbbE?= =?us-ascii?Q?ksc7Vza1XNV+Q9Hwvk66+t3vzZ4z8NG3dtCtg2VT1OT6Gl1529tgAcOmmXJ2?= =?us-ascii?Q?7JLjIjNDUWeMVwox+mhbjRr1eWnZ7UBkxGB9tLpiMV0BWrwjCgXgP1pBc4f0?= =?us-ascii?Q?Wg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: utswfbLePw+CXd0nzo8ZP3SGgVoPySnBDIaN8Y1XEfTYDTp9GcmIhg22y5+rlS/7PQphWkBloPrHFOyzA7Y5RraEAl4P17x9+n2tCtXI738FerDcooOpzJTFwBiAo0Nq0a4QZB8ACou43wIzm8Ed7Buo+VLdz9T9MZAbx3Mx+zk42QTEwukgMAdTRv8lb16Wfaj2psWx69/2pD1/WEbVt+26ht37rdPRaaiPjGDXC9/7xcPqS70e060H4n0RBqGLXVFAp5yxSDTOCgXFDotcbXEjrI2Ky6vFYfkgDa5kgqcWdKkC/uMaZzuC7cVaKAsnn4JBiiT65QcmYsekMtEHMoL2/Fw+lbrjLxcm57KLNNLBXbHGtkY6o16VF/Ag0WQCtXUrFv7+xpchSC/IQ53GQmRz1c1HMCMr6DNfGGYwG/9g8IBFbDtVjk+Ogg05ua3JKQXo0QIxFqKHkajA/J5dpeXfY4oB2fC8xNcUMs47RbLrFdt/cxVRmfFe8zD3azULJeoe4UDYcMM8KMKP2+wkqfMLahc7ycNF/5/pimjb7Udy/15zFgvFKMZbWalKXind4DFfYfdokjzm7k+ZuD7z8jSJ4VO54LSqeM1IYiC/TCyUz+qo2pEaNkeTLkbczfB2agZa8bqHart07dctouyL90kP8LCk4l+CoCfzyuOCRC2/FB24TCVI9HiHpb48pISR7ShlK4u1Vi/f64UQ8BSsdGOODLMkyzYUMRSATbuxIRlXFo381UPRv7t5e4f5PBfjRlMD4olEKGUhNEQSse7VP6jwYmKfQXfDh8LjP6T+Qwqib1cEc/6ADxwMin4k8Tx/Ome5W2oLAdfMZT+ojs81BimbhRVeyPOdPcqpJx0MoPg= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f24d4d27-19d0-4071-b392-08dac567f143 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2022 11:12:24.6083 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fOxfaEDa6LSOYdqk00htAz9LYKmOcPmwLONfUs6xIeGRhYRkuZPKo3YQDr1OcMAzTgBw1fEzRErdRrL2xWTLRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6221 > On 11 Nov 2022, at 20:46, Andrew Cooper wrote= : >=20 > Nothing here is critical enough to go into 4.17 at this juncture. Agreed >=20 > Various notes/observations from having spent a day trying to untangle > things. Thanks. >=20 > 1) Patches 5/6 are a single bugfix and need merging. Except there was > also an error when taking feedback from the list, and the net result > regresses the original optimisation. I have a fix sorted in my local que= ue. >=20 > 2) The indentation fix (not attached to this series) should scope the > logic, not delete a debug line which was presumably added for a good > reason. I've got a fix to this effect in my local queue, and we can > discuss the pros/cons of the approach in due course. I deleted the debug line to avoid reindenting code, which was frowned upon. Either way it is fine for me. >=20 > 3) Patch 1, evtchn Ocaml 5.0 compat, is still missing some corrections > which I gave on earlier postings. I've fixed it up locally in my queue. >=20 > I also notice, while reviewing the whole, that stub_eventchn_init() > passes NULL as a logger, which has the side effect of libxenevtchn > instantiating a default logger which takes control of stdout/stderr.=20 > Without starting the fight over toxic library behaviour yet again, it > occurs to me in the context of Patch 13, uncaught exception handler, > that in oxenstored, any logging from the C level needs to end up elsewher= e. >=20 > While we do have ocaml bindings for xentoollog, nothing uses it, and > none of the other libraries (save xl, which isn't used) have a way of > passing the Ocaml Xentoollog down. This probably wants rethinking, one > way or another. We should probably start by reviewing the xentoollog bindings, if they neve= r got used they're probably buggy. I think Pau might have some xentoollog bindings though. >=20 > 4) Patches 2/3. All these libraries have far worse problems than > evtchn, because they can easily use-after-free. They all need to be > Custom with a finaliser. Indeed, the bindings aren't very safe, and that should be fixed separately. I've got some patches somewhere to stop the mmap bindings from segfaulting = on invalid data, but I lost track whether that got commited or still in one of my local bran= ches. >=20 > 5) Patch 4. The commit message says "A better solution is being worked > on for master", but this is master. Also, it's not a prerequisite for a > security fix; merely something to make a developers life easier. It is to avoid having to add Makefile changes in each security patch commit= (potentially). Perhaps the commit message can be changed to say this is the minimal change= to unbreak the build system, and a more comprehensive solution is being worked on (using Dune, or dune g= enerated makefiles). >=20 > 6) The re-indent patch. Policies of when to do it aside, having tried > using it, the format adjustment is incomplete (running ocp-indent gets > me deltas in files I haven't touched), Perhaps we need to use the strict_comments setting, I think it tries to lea= ve comments untouched, but that also means the outcome depends on the starting state. And I hope it doesn't depend on ocp-indent version. > and there needs to be some > .gitignore changes. >=20 > That said, it is usually frowned upon to have logic depending on being > in a git tree. This was perhaps a bigger deal back when we used hg by > default and mirrored into multiple SCMs, but it's still expected not to > rely on this. We could use 'find' instead. >=20 > 7) Patch 8, evtchn fdopen, is two separate patches. One adding fdopen, > and one adding a NOCLOEXEC argument to the existing init. >=20 > They want splitting in two. fdopen() ought to pass flags so we don't > have to break the ABI again The ABI changes everytime a new variant is added (the interface hash will c= hange, and you need to rebuild/relink), so using a single flag variant doesn't avoid ABI changes like it would in C= . > when there is a flag needing passing, and > cloexec probably shouldn't be a boolean. The preferred way to bind CLOEXEC in OCaml is to use a boolean, see Unix.html , in particular `val socket : ?cloexec:bool -> socket_domain -> socket_type -> int -> file_descr` Perhaps I should've spelled this out in the commit message. > We should either pass a raw > int32, or a list-of-enums like we do in the xenctrl stubs. Also, this > patch has inherited errors from patch 1. >=20 > 9) Patches 8 thru 15 need to be the other side of the intent patch, > because they need backporting to branches which will never get it. This was done on purpose like this to ensure that indentation is backported= in some way, because the lack of indentation has previously broken backports/rebases (se= e the debug line introduced in the wrong place in the live update patch). Without a comprehensive testsuite (which is being worked on, but not ready = yet) it is then impossible to tell whether a backport is correct or not, even if it compiles, it may have some things in the wrong place, and wrong = indentation just makes reviewing those more difficult. Otherwise I have to keep making changes with the wrong indentation or avoid= indentation changes in patches, which has previously introduced bugs. It is extra work, and all it does is decrease the quality of the end result= and confuse both patch authors and reviewers. Furthermore the indentation commit on its own is separate and can be proven= to have no functional changes if you view the diff ignoring whitespace. We first need to make oxenstored suitable to be developed on, which means s= tarting at the basics, fixing up indentation, build systems (all the bugs in the bindings you pointed out), etc. I tried my best to avoid making changes like this within the XSA fix (which= only contributed to lengthening the time to develop it), but now that we're no longer constrained by XSA rules we should fix things = the right way. Keeping the status quo just for the sake of it only discourages contributio= n to oxenstored. If it helps we can consider all past versions of oxenstored unsupported (by= me) and support only master going forward, and once we have master in a re= asonable shape we can decide what and how to backport, and which versions to reinstate sup= port on. That would avoid placing artificial constraints on master developm= ent. I intend to change master substantially enough that most backports will be = impossible unless you take an almost entirely new version of oxenstored. In fact releases of oxenstored shouldn't be tied to a particular hypervisor= version: there should be a single long term supported stable branch of oxe= nstored and a master branch. (I understand that is not possible yet due to the use of the 2 unstable xen= ctrl APIs, one of which has an outstanding patch series to remove the depen= dency) The current situation only creates the illusion of support for the backport= ed versions, because there is no (comprehensive) testsuite to check that th= ose backports work, and XenServer only tests internally 4.13 and latest master, anything inbetw= een is technically untested, and may be more buggy than just running one ve= rsion. > This > is why bugfixes always go at the head of a patch series, and > improvements at the tail. I agree that is how it should generally be, but that means improvements can= never be done because we always keep finding more and more bugs as we do i= mprovements, and then do a lot of risky rebases to get patches moved ahead, and without = minimal things like automated tools to keep at least indentation consistent the end result is a mess that cannot be trusted. >=20 > 10) Patch 12 talks about default log levels, but that's bogus > reasoning. The messages should be warnings because they non-fatal > exceptional cases. >=20 > 11) Patch 14 talks about using caml_stat_strdup(), but doesn't. The commit message for this is fixed on my github branch: https://github.co= m/edwintorok/xen/commit/dc893a079fd7cf2a9bb8ed03cca3d249a53e3c44 It initially had that function, but it is not available in 4.02.3=20 Thanks for helping sort out the patch series. Best regards, --Edwin= From xen-devel-bounces@lists.xenproject.org Sun Nov 13 12:49:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 13 Nov 2022 12:49:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.442989.697385 (Exim 4.92) (envelope-from ) id 1ouCQV-0001wO-HG; Sun, 13 Nov 2022 12:49:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 442989.697385; Sun, 13 Nov 2022 12:49:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouCQV-0001wH-Dy; Sun, 13 Nov 2022 12:49:31 +0000 Received: by outflank-mailman (input) for mailman id 442989; Sun, 13 Nov 2022 12:49:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouCQU-0001w7-5D; Sun, 13 Nov 2022 12:49:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouCQT-00044O-Ts; Sun, 13 Nov 2022 12:49:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouCQT-0001nC-HE; Sun, 13 Nov 2022 12:49:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouCQT-00084t-Ge; Sun, 13 Nov 2022 12:49:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JbPhoyQuCVqIhkKwPJudWsn/FpEkITubA84XY8mzZ5E=; b=xwE/kT77H3IB86jSjf5GUe4Uo7 CstZHSZiwHi4ANVE6P5LHkCEqnHUhZd+ATcnSmGVfQmVkVIXZoMRB6Ef1hAHNkp73D+ixI1PG8p9W R8pF/VI80MaGZcyzAI0/SaCx1b6Heg74hVXaMM2j5UZuIsnK72lRDkFzXG8Fa71nZgZs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174753: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 X-Osstest-Versions-That: xen=17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 From: osstest service owner Date: Sun, 13 Nov 2022 12:49:29 +0000 flight 174753 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174753/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl 22 guest-start/debian.repeat fail pass in 174747 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174747 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174747 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174747 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174747 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174747 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174747 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174747 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174747 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174747 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174747 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174747 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174747 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 baseline version: xen 17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 Last test of basis 174753 2022-11-13 01:52:17 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Nov 13 19:50:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 13 Nov 2022 19:50:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443023.697397 (Exim 4.92) (envelope-from ) id 1ouIzU-0004jB-Rm; Sun, 13 Nov 2022 19:50:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443023.697397; Sun, 13 Nov 2022 19:50:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouIzU-0004iR-Lt; Sun, 13 Nov 2022 19:50:04 +0000 Received: by outflank-mailman (input) for mailman id 443023; Sun, 13 Nov 2022 19:50:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouIzS-0004Ly-Gq; Sun, 13 Nov 2022 19:50:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouIzS-0005Bn-Dc; Sun, 13 Nov 2022 19:50:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouIzR-0002Ux-Un; Sun, 13 Nov 2022 19:50:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouIzR-00062z-UO; Sun, 13 Nov 2022 19:50:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2PxY74MD+AHVQoiUzftdcJOMgiTaVvcPbjBwz0Cqe28=; b=IeITmxhERW2VjzA2yJxW8T2fgy RncIhmJ7nYPr0VvOr7F42moSFhle5RtjMmyL7/Vy0779uxMxVOtlmt7KhJKgiaXkuxQtrYrepf6zD sgOnEECzPqstPekur1ZoEU5nROedDo9NcMY0StFkURolaZTewUx+hZmQWXFtkbN9OJEw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174754: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=fef7fd48922d11b22620e19f9c9101647bfe943d X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sun, 13 Nov 2022 19:50:01 +0000 flight 174754 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174754/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux fef7fd48922d11b22620e19f9c9101647bfe943d baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 37 days Failing since 173470 2022-10-08 06:21:34 Z 36 days 59 attempts Testing same since 174750 2022-11-12 19:13:14 Z 1 days 2 attempts ------------------------------------------------------------ 1700 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 161904 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 13 20:31:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 13 Nov 2022 20:31:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443032.697406 (Exim 4.92) (envelope-from ) id 1ouJdY-0001P1-5w; Sun, 13 Nov 2022 20:31:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443032.697406; Sun, 13 Nov 2022 20:31:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouJdY-0001Ou-3H; Sun, 13 Nov 2022 20:31:28 +0000 Received: by outflank-mailman (input) for mailman id 443032; Sun, 13 Nov 2022 20:31:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouJdX-0001Ok-CQ; Sun, 13 Nov 2022 20:31:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouJdX-00066M-8F; Sun, 13 Nov 2022 20:31:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouJdW-0003f5-LT; Sun, 13 Nov 2022 20:31:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouJdW-0003uG-L0; Sun, 13 Nov 2022 20:31:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=doxmqDuph80d1dzmogNMFtX0UF+BsBSg3M+pJQcVFBw=; b=IowetTBvsIpWhlKSWHCXubiW9p GtOTXhqekSx+ndwLFfduzBSa9jS96w0rkh582uYqCo1CGVG/xRcnOf1OjrmQD3tk/uWfuUNgrQVjg of3sq/0H95BrsTZZ4Uf0vmtVFv3rEOIx/MEQgJ1ml63wwuBQ76g8EAOiZYJy6Dh8nKXM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174755: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=771a8acbb84145b943bd608ba376e104ebfa9664 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Sun, 13 Nov 2022 20:31:26 +0000 flight 174755 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174755/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 174540 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 14 guest-start fail in 174738 pass in 174755 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 174738 pass in 174755 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 174738 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 771a8acbb84145b943bd608ba376e104ebfa9664 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 15 days Failing since 174575 2022-11-01 18:42:39 Z 12 days 22 attempts Testing same since 174727 2022-11-10 22:13:32 Z 2 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anna Schumaker Anssi Hannula Ard Biesheuvel Arnaldo Carvalho de Melo Biju Das Brian Foster Brian Norris Carlos Llamas Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Chuhong Yuan Damien Le Moal Dan Carpenter Darrick J. Wong Darrick J. Wong Dave Chinner Dave Chinner David S. Miller David Sterba Dean Luick Demi Marie Obenour Dennis Dalessandro Dokyung Song Dongliang Mu Eric Dumazet Eric Sandeen Filipe Manana Florian Fainelli Gaosheng Cui Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Han Xu Hangyu Hua Hannu Hartikainen Hans Verkuil Heiko Carstens Heiko Stuebner Helge Deller Hyong Youb Kim Hyunwoo Kim Håkon Bugge Ilias Apalodimas Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jason Gunthorpe Jeff Vanhoof Jens Axboe Jens Glathe Jim Mattson Jimmy Assarsson Jiri Kosina Johan Hovold John Veness Jon Hunter Jon Maloy Jonathan Cameron Jonathan Corbet Josh Poimboeuf Juergen Gross Julian Anastasov Justin Chen Kalle Valo Kan Liang Konrad Jankowski Kuniyuki Iwashima Kuogee Hsieh Leon Romanovsky Leon Romanovsky Li Qiang Linus Torvalds Linux Kernel Functional Testing Luiz Augusto von Dentz Luiz Capitulino Luís Henriques M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Martin K. Petersen Martin Tůma Masami Hiramatsu (Google) Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Maxim Levitsky Maxim Mikityanskiy Meena Shanmugam Michal Hocko Michal Jaron Michal Simek Mike Kravetz Miklos Szeredi Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Pablo Neira Ayuso Paolo Abeni Paolo Bonzini Paul E. McKenney Paul Moore Peter Zijlstra (Intel) Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rasmus Villemoes Richard Weinberger Rik van Riel Saeed Mahameed Sakari Ailus Samuel Bailey Sascha Hauer Sasha Levin Serge Hallyn Sergey Shtylyov Shakeel Butt Shang XiaoJing Shreeya Patel Shuah Khan Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Theodore Ts'o Thinh Nguyen Tim Harvey Tom Lendacky Tomasz Moń Tony O'Brien Trond Myklebust Tvrtko Ursulin Uday Shankar Ulf Hansson Vasily Averin Vasily Gorbik Ville Syrjälä Vineet Gupta Vladimir Oltean Wei Yongjun Willy Tarreau Wolfram Sang Xin Long Yang Yingliang Ye Bin Yongqin Liu Yu Kuai Zhang Changzhong Zhang Qilong Zhang Xiaoxu Zheng Yejian Zhengchao Shao Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 4692 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 13 21:43:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 13 Nov 2022 21:43:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443038.697418 (Exim 4.92) (envelope-from ) id 1ouKkk-0000jV-Dv; Sun, 13 Nov 2022 21:42:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443038.697418; Sun, 13 Nov 2022 21:42:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouKkk-0000jO-AY; Sun, 13 Nov 2022 21:42:58 +0000 Received: by outflank-mailman (input) for mailman id 443038; Sun, 13 Nov 2022 21:42:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouKki-0000jI-UV for xen-devel@lists.xenproject.org; Sun, 13 Nov 2022 21:42:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouKki-0007YV-Kl; Sun, 13 Nov 2022 21:42:56 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ouKki-0001mM-Ev; Sun, 13 Nov 2022 21:42:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=/ypwJxiHzPl9vExkIEqQHC4z5UcjeSfFVjYZkhhExrc=; b=SrAZ5RJv6RIn0BAtwpum5G8o1s L5RXxTjbtiRATcir8v8Zd+08fMoouOcBdPwXbwChWUdGEtvsuDfecDClKNjaatz120R6Xwy9UmZlz TFeGT0Kk3Xpu9P8/PnzvsTztwVFg5Z6iKdnwZIhCUTpBK+Exr6f7QGf4cR0W1v3grsaw=; Message-ID: <927355c8-aea1-83c4-60c1-b06f8e0f182f@xen.org> Date: Sun, 13 Nov 2022 21:42:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 To: Wei Chen , "xen-devel@lists.xenproject.org" Cc: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Henry Wang References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-9-wei.chen@arm.com> <5b975a59-5e97-c2a8-805c-9ab99b8712aa@xen.org> From: Julien Grall Subject: Re: [PATCH v6 08/11] xen/arm64: move MMU related code from head.S to head_mmu.S In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 09/11/2022 07:36, Wei Chen wrote: > Hi Julien, Hi Wei, > >> -----Original Message----- >> From: Julien Grall >> Sent: 2022年11月7日 4:06 >> To: Wei Chen ; xen-devel@lists.xenproject.org >> Cc: nd ; Stefano Stabellini ; Bertrand >> Marquis ; Volodymyr Babchuk >> ; Henry Wang >> Subject: Re: [PATCH v6 08/11] xen/arm64: move MMU related code from head.S >> to head_mmu.S >> >> Hi Wei, >> >> On 04/11/2022 10:07, Wei Chen wrote: >>> There are lots of MMU specific code in head.S. This code will not >>> be used in MPU systems. If we use #ifdef to gate them, the code >>> will become messy and hard to maintain. So we move MMU related >>> code to head_mmu.S, and keep common code still in head.S. >> >> I am afraid that you can't simply move the MMU code out of head.S >> because this will break Xen when running using the identity map. >> >> This is because we only map the first 4KB of Xen with PA == VA. At the >> moment, we guarantee it by having everything that needs to be used in >> the identity mapping before _end_boot and checking at link time if this >> fits in 4KB. >> >> Now that you moved the MMU code outside of head.S. We need to find a >> different way to guarantee it. One way to do it would be to create a >> section that would be used for everything that needs to be identity mapped. >> > > Quote from next email > " > Looking at the code this morning, I noticed that we already have the > section ".text.header". For now, that should do the job. So we just need > to check the size of .text.header. > > Ideally, checking the size should be done in a separate pre-patch so it > is easier to review. > " > > OK. We will create a patch to check the size, and place it in the > head of the series. I thought a bit more about what I wrote. Xen binary should always start with the Image/Zimage header. At the moment, this is guaranteed because there is only one object using the section .text.header. With the change introduced in this patch, there will be multiple objects using with the sections .text.header. This means we are relying on the compiler to always put the content of head.S first. This is basically reverting to the behavior before commit 4267a33b19d ("xen/build: put image header into a separate section"). Therefore we do need a separate section to be used for head_*.S and maybe part of head.S. This new section could be called text.idmap so we know what the section is used for. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 14 00:40:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 00:40:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443048.697429 (Exim 4.92) (envelope-from ) id 1ouNWB-0003h1-0I; Mon, 14 Nov 2022 00:40:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443048.697429; Mon, 14 Nov 2022 00:40:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouNWA-0003gu-TT; Mon, 14 Nov 2022 00:40:06 +0000 Received: by outflank-mailman (input) for mailman id 443048; Mon, 14 Nov 2022 00:40:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouNWA-0003gk-Ba; Mon, 14 Nov 2022 00:40:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouNWA-0003Wc-70; Mon, 14 Nov 2022 00:40:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouNW9-0000w9-N6; Mon, 14 Nov 2022 00:40:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouNW9-0000RA-Kt; Mon, 14 Nov 2022 00:40:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0cmDFqiSfWeRA8TVzzF1o1AFd/1QZCrBupoKLObZfYc=; b=IB98+wTmHX1VMurFgxEd3z0dAR CU7BUv2BSzSLj1tVr7J1TLQlLsP2jC/MAUnhQ+nUorXiHaoTwcQ8U0tr+9ppPX4VddL7WDCc1046d iRM+sM4NQLygrCDin771hOtCdLTC27pLUu20NzEeEa0xXRI+KjEn9wwJjEYJtTDHHwrE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174756: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-libvirt-raw:xen-boot:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:windows-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=305f6f62d9d250a32cdf090ddcb7e3a5b26a342e X-Osstest-Versions-That: qemuu=6a4cff8e1a80bafc4b8fe2bfb10081f4880d1b3b From: osstest service owner Date: Mon, 14 Nov 2022 00:40:05 +0000 flight 174756 qemu-mainline real [real] flight 174759 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174756/ http://logs.test-lab.xenproject.org/osstest/logs/174759/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 174752 Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-raw 8 xen-boot fail pass in 174759-retest test-amd64-amd64-xl-qemuu-ws16-amd64 12 windows-install fail pass in 174759-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail in 174759 like 174752 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 174759 like 174752 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 174759 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174752 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174752 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174752 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174752 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174752 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174752 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 305f6f62d9d250a32cdf090ddcb7e3a5b26a342e baseline version: qemuu 6a4cff8e1a80bafc4b8fe2bfb10081f4880d1b3b Last test of basis 174752 2022-11-13 01:10:32 Z 0 days Testing same since 174756 2022-11-13 11:40:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bin Meng Philippe Mathieu-Daudé Philippe Mathieu-Daudé Richard Henderson Song Gao Stefan Hajnoczi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 305f6f62d9d250a32cdf090ddcb7e3a5b26a342e Merge: 57bc6e40e8 46b21de238 Author: Stefan Hajnoczi Date: Sat Nov 12 09:17:06 2022 -0500 Merge tag 'pull-la-20221112' of https://gitlab.com/rth7680/qemu into staging Fix loongarch make check-tcg failure. # -----BEGIN PGP SIGNATURE----- # # iQFRBAABCgA7FiEEekgeeIaLTbaoWgXAZN846K9+IV8FAmNu8aUdHHJpY2hhcmQu # aGVuZGVyc29uQGxpbmFyby5vcmcACgkQZN846K9+IV90jAgAsaB0nU7YGzJRYRmK # +QXtrQa5AmXf014X7OeOZyxdYCPCwri2rnCxc1eOKAIOeSbdFY54xjXXEV8qpej+ # ZiLbdvXFG519vJpZquEJm1wgk68NnKYy2wfeRuwBMcQD4E7yeE9y11IKtuN6vbcq # sh/Zxh43KwzyZ1wrVQl8DUxesTcE4RwVDJ+t2q+uYKcgmUVRQJJd9aXLkOKpOb1f # QU+6lJAGv293IbW5LUD8fIPNKVWqlVwDIsFVWhYYJFxvWfbL211NsJbX70RnKahr # vJ6olGORlShNJEiV++9QTrgGr1v76KkVECaKNtohkYL/BkfNxoy4yWxcC7I9zds+ # 6oH9vQ== # =7NI1 # -----END PGP SIGNATURE----- # gpg: Signature made Fri 11 Nov 2022 20:06:45 EST # gpg: using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F # gpg: issuer "richard.henderson@linaro.org" # gpg: Good signature from "Richard Henderson " [full] # Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A 05C0 64DF 38E8 AF7E 215F * tag 'pull-la-20221112' of https://gitlab.com/rth7680/qemu: hw/loongarch: Fix loongarch fdt addr confict Signed-off-by: Stefan Hajnoczi commit 57bc6e40e82c0446a358ab01f9bbf0db0d9465e4 Author: Philippe Mathieu-Daudé Date: Fri Nov 11 13:45:50 2022 +0100 libvduse: Avoid warning about dangerous use of strncpy() GCC 8 added a -Wstringop-truncation warning: The -Wstringop-truncation warning added in GCC 8.0 via r254630 for bug 81117 is specifically intended to highlight likely unintended uses of the strncpy function that truncate the terminating NUL character from the source string. Here the next line indeed unconditionally zeroes the last byte, but 1/ the buffer has been calloc'd, so we don't need to add an extra byte, and 2/ we called vduse_name_is_invalid() which checked the string length, so we can simply call strcpy(). This fixes when using gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0: [42/666] Compiling C object subprojects/libvduse/libvduse.a.p/libvduse.c.o FAILED: subprojects/libvduse/libvduse.a.p/libvduse.c.o cc -m64 -mcx16 -Isubprojects/libvduse/libvduse.a.p -Isubprojects/libvduse -I../../subprojects/libvduse [...] -o subprojects/libvduse/libvduse.a.p/libvduse.c.o -c ../../subprojects/libvduse/libvduse.c In file included from /usr/include/string.h:495, from ../../subprojects/libvduse/libvduse.c:24: In function ‘strncpy’, inlined from ‘vduse_dev_create’ at ../../subprojects/libvduse/libvduse.c:1312:5: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 256 equals destination size [-Werror=stringop-truncation] 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors ninja: build stopped: cannot make progress due to previous errors. Fixes: d9cf16c0be ("libvduse: Replace strcpy() with strncpy()") Suggested-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Xie Yongji Reviewed-by: Stefan Hajnoczi Tested-by: Bin Meng Signed-off-by: Stefan Hajnoczi Message-Id: <20221111124550.35753-1-philmd@linaro.org> commit 46b21de238c643ea098f2dcffe493abd135f7d89 Author: Song Gao Date: Wed Nov 9 10:04:49 2022 +0800 hw/loongarch: Fix loongarch fdt addr confict Fix LoongArch check-tcg error: TEST hello on loongarch64 qemu-system-loongarch64: Some ROM regions are overlapping These ROM regions might have been loaded by direct user request or by default. They could be BIOS/firmware images, a guest kernel, initrd or some other file loaded into guest memory. Check whether you intended to load all this guest code, and whether it has been built to load to the correct addresses. The following two regions overlap (in the memory address space): hello ELF program header segment 0 (addresses 0x0000000000200000 - 0x0000000000242000) fdt (addresses 0x0000000000200000 - 0x0000000000300000) make[1]: *** [Makefile:177: run-hello] Error 1 Fixes: 021836936ef ("hw/loongarch: Load FDT table into dram memory space") Reported-by: Richard Henderson Signed-off-by: Song Gao Reviewed-by: Richard Henderson Message-Id: <20221109020449.978064-1-gaosong@loongson.cn> Signed-off-by: Richard Henderson From xen-devel-bounces@lists.xenproject.org Mon Nov 14 01:18:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 01:18:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443055.697443 (Exim 4.92) (envelope-from ) id 1ouO7U-0005tY-U0; Mon, 14 Nov 2022 01:18:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443055.697443; Mon, 14 Nov 2022 01:18:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouO7U-0005tR-Qk; Mon, 14 Nov 2022 01:18:40 +0000 Received: by outflank-mailman (input) for mailman id 443055; Mon, 14 Nov 2022 01:18:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouO7T-0005tJ-Vm for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 01:18:40 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2085.outbound.protection.outlook.com [40.107.22.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 428e0452-63ba-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 02:18:36 +0100 (CET) Received: from AS8PR07CA0040.eurprd07.prod.outlook.com (2603:10a6:20b:459::11) by AS2PR08MB9691.eurprd08.prod.outlook.com (2603:10a6:20b:605::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 01:18:33 +0000 Received: from AM7EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:459:cafe::d1) by AS8PR07CA0040.outlook.office365.com (2603:10a6:20b:459::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 01:18:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT038.mail.protection.outlook.com (100.127.140.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 01:18:32 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Mon, 14 Nov 2022 01:18:32 +0000 Received: from 385ba41371eb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 511128A7-C8BD-44B4-A90E-42F9C6251995.1; Mon, 14 Nov 2022 01:18:26 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 385ba41371eb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 01:18:26 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB6053.eurprd08.prod.outlook.com (2603:10a6:20b:292::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 01:18:24 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Mon, 14 Nov 2022 01:18:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 428e0452-63ba-11ed-91b6-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=IfKgzMdsJAKpl57lA8z9nDDRl2d2dDeQUNKvNWNWPP7yqSP9YnpoMtsV/TKBUVn6jpZkB8msYmxWgAc43VcMWu3TFh3WMeEQ39B2BiHYfoJbTKE6+GChEdJY9J/0j4xu93aDhGTMARoY1Q2tW/gTYEx+tsyC3IeKWKdx4RSHwQNTbOQXhho6FcQdfHXE2DVNdCREN8bnbl7SJn1xW3RrvCz9lkc6gkJL4gWeglkz/SQYkHGMhoiRFlNFq6Rs0m5EDlZ0wkknFxC7xNuVpUwwBlG32QGf8lPpxia8tmaObKHyWAnku5FWBrqsf478uJnMxiENlIXyovQ+uB1NsF68kw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MsATxt7qa+FQO28pzai6izHvkY7Or/JLb2YXVkoOEbE=; b=azQiOzCi7bDKVzrFrQsX4bjh5vMt0Ar5tgYBg6eTGR//MUJQB824fh/96+sekzGjxMA5fsr+Bdwd8FZlU1G3R0pLleSXwbdlLXbcgpprbiEu+ivDcqaYxDc0ZfwzXcvvs2wnyz7nsW2rw4AfFWvZGRAmYiAhxPJlTYeBWiEciOEcR8vf0XDU+ws10jQxPHSlrhQZ5XXxZj4jvM9QUgi7Yr5sKE4VWn4ZuPyLRFIiBRr2ziUhExkUSt/rPqLwH0J/sc4V7xCHg3RsR7U0u2l3uEt6jqnhZFaPG6lSjjk0VrMPCMpLoTk50Yj2SivSt4aNMRaEDKSZBOWawcp6r/VXYg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MsATxt7qa+FQO28pzai6izHvkY7Or/JLb2YXVkoOEbE=; b=557/J8rSz/ThPeyd1MBrZSixnxYfk5ySoKzL6pR+B8EsWrNNInRXqSnE0rEnm0fgsZ/vb2EKmCJxEVqiZYMslhBbEjz/UKz2Evcaq5lqH9OYBI6dYbjmks9MVr/w3PPkEuoPVDY3Tkc3ZPneXmYlcklnnVpsJxDVU6yc+nSdWmM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OXsGLxn5qxiCR9KvBMfIKIAnjFtP3a0S9V/Tly7Cqesu8W4rQaARCcmsOZn3xG6DH2yLq7nn1NTwmxaZkY2f/jV2FM33xwo/FsBMdsHc8iX623VTX4qK5Te3PP3xEJl3AZMMFynQ9K2hvt4faKxW4NvVYWuS5vflxHfTzss++rUGMAYRSsMCUWocRWj+DX/X0oYpYXHpiSkgvnBF/4Iul5mPEg+UW1aOHpA8twVhV2WT0ekKh/oizUtRzyWm0uNeBD8KEdPOF3T/U2fHkYe3Ano+vmhp5IH0AbpAG611Q7jeDAbKskB4EYFZwRT9AE5NjWAIv5ZEBFVsErdbWpk1YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MsATxt7qa+FQO28pzai6izHvkY7Or/JLb2YXVkoOEbE=; b=KZ3uY2GV5SatJcJ0JJyathsxxYk4JbEt/ZtNroip07KKB67+oeTygC53B3jzAK6xPi/QJCQbm2zuV5F0jQW757t7kXmTSlF+9GYfepPh0yb5UyaD7b/s+/cr3DkAUbVh4RhES0k6XjqCABmKwthDKkgtOgsS16fPTke5cRfeXioAA1YNJaH3jtlQ3k4DxpOi2ks7F5kKfiFH8vkvFNyJqbFFCaNiLADez2LAVjdzC2cEPGmNhc0J59JzsXlwdN5k/CuCfdKRTPkv7ygBc22NpmHuMqrqqCtjZV5xeMYEkyKosEAREwcpxdLrHAwMPQxY7kP7HK1qdkq65IVoNkmKTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MsATxt7qa+FQO28pzai6izHvkY7Or/JLb2YXVkoOEbE=; b=557/J8rSz/ThPeyd1MBrZSixnxYfk5ySoKzL6pR+B8EsWrNNInRXqSnE0rEnm0fgsZ/vb2EKmCJxEVqiZYMslhBbEjz/UKz2Evcaq5lqH9OYBI6dYbjmks9MVr/w3PPkEuoPVDY3Tkc3ZPneXmYlcklnnVpsJxDVU6yc+nSdWmM= From: Henry Wang To: Jim Fehlig , xen-devel CC: Jan Beulich , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Andrew Cooper Subject: RE: vnuma_nodes missing pnode 0 Thread-Topic: vnuma_nodes missing pnode 0 Thread-Index: AQHY9iDYCXvlfuymEU2cRUBeAI3Esq49n+1w Date: Mon, 14 Nov 2022 01:18:24 +0000 Message-ID: References: <2046b5fb-2533-02fe-69e8-f46174cf825d@suse.com> In-Reply-To: <2046b5fb-2533-02fe-69e8-f46174cf825d@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3FBC458A4BB07840885FE2C5728B6C64.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB6053:EE_|AM7EUR03FT038:EE_|AS2PR08MB9691:EE_ X-MS-Office365-Filtering-Correlation-Id: b4d860fa-2262-4115-f2f1-08dac5de254c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1apFI6iQUdjdWnDlfWGFs3uOusX9EGEBsIrUW7Hw19EfNlOiEuMjEYjn6fLNcsgrwhJ+RJYtGo1TtxkW4scIrqxLsEGCAXRPaOR8G6du7ylYi5WPocjCh6j+8z9OM/sI0u5sWyhvjcldT568N1E8eX46qHuPdS4aV26CDS/p7x9W3hhZg86d2WpGl/AZuds8iHZJ7Gu24fs7+GXYxUyMp0d9d9URx4U2090FbIOqXAbgZ6MZehDJEBRF7y8XIaMBebf9VU13JGfO6rlcLptHc8pCXI13YQr9bcZdSkAHB3Letpg7MZA635vZet2l1AKvemnXKTdR2xan0bB7QkCfmN0P0g04nK0ZEh1V1hp/8ijEm5duwleVSUIlljODcfdcsuc6csFBnvP5xe0DK13emigj3VR20tOkc8MA3Fgg3NWPxfSfDQ+ahdNCFQDsPVD+Bh1nj+PiyxFRRTrlvMJ7nclGEI4zDBhokTNY6tiB3SOctahPYtuaPR8UOTXP/KTvikkMrLBBKhnDAZhAWroSWDBx8f1tySE623P+ltgmltBvFBZwG5YogH9zYZ8bUKSSbCAoocuUEoGPJCvQnC7FVX4NPL+rlfeajFNbv4PFRm/JsfRSlS+n9eqLJgSr6NfFYabi/0mnYtvzjaGIOimQIO3pQqLB2vo5pAH5Wy7C6+Jn8VLTkApYpA2Cbe+sCzTE9e4gpzphw6wYSu4tJLOXyuZt8g2/z6Vw5WkEIaMMTZqbZKXVWKeo1FRG7ikD3AHrJyIzEC74MgQSGFUujk+N2kOeCYX3ZCkB1Gte+JXNaoQa8O8Ip3kNlY3117sS4dlo3o6u89XbbJxtYaVwWnKgbg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39850400004)(346002)(366004)(376002)(136003)(396003)(451199015)(55016003)(33656002)(6506007)(7696005)(26005)(4326008)(2906002)(86362001)(54906003)(316002)(186003)(478600001)(41300700001)(966005)(83380400001)(38070700005)(5660300002)(8936002)(110136005)(52536014)(38100700002)(71200400001)(66476007)(66946007)(66446008)(8676002)(64756008)(122000001)(7116003)(76116006)(66556008)(9686003)(533714002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6053 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6fba7b1f-c3ec-4f31-5221-08dac5de2058 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3WQdjGFoUiyCdcTjrw9eRKR1HVBWnXWXsnAx+ivlpmv9bY4NXIoaYXMkvwjd0o+HrwFdRvrL9pNNarUOYL1XiSIl1Mx1Msr70QCxt2IFNfSwwV4vAmX7V2RA/2ORByT1ZeUvmWOHYTd2ZBMrDHURAHvwF+OFCAk3cha/T3pt28c4d4Qk+k5eVVQJD7DyNFX0UDGXtZ0DTvZavCIyNLOMlvoworJ2UcpY4oT5ZEIhYl1xtskWnvkGS8DvG3I4oH82uK+j9On8BwktMKg9wYjGS0b4bV0/gPFSzVwRjph8qFunuieks0ZrH2Sh5T5sZu3abUjHZv+ML02TexQIrhSUCsRYA5gw59/5UF8RL+E8TfsxC5KG7LC+gltb8Cjbum5tmyKP6y3J+/QHskcJm5kcO18leYxMRWMAzWo8gPU6YMNaV59loMdGsE7Ryldk+GfANd6n/VbwXlIyEvaUsjoAWwFCQKmnnX30jYuP6K6LiF4JL9aZy+TFSURy3ntj8Edrpps5vmic034B9e6IpFIjXCUheM1Ob879GjOVw27LKILNSzDGtAP3VTVi8x0QZSwGeHYpYLA2DgNRz/8V4doMRPn+/8im9+BdPgKCNwTyEEr1eVufIemVoFv4HVeOgC2wRBnHGY01OeYnHPQA1VzTYRUIXPTroizspg0nxsYO0XSTxIR+uKybNLyowmEpF8Ho9AhSNMxBgRiLsdxflc2U/yeMq358Pvr6J6wpe+BqtdE6buUk4xDzKiU75cWA/6MczBO9hKkZyqClQTCoBJrGfF7vkcok1NCf9EDbKRGLnfM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(376002)(39850400004)(451199015)(36840700001)(46966006)(33656002)(82740400003)(41300700001)(2906002)(356005)(81166007)(83380400001)(36860700001)(86362001)(54906003)(70206006)(70586007)(47076005)(110136005)(966005)(4326008)(478600001)(336012)(316002)(186003)(7116003)(82310400005)(40480700001)(8936002)(107886003)(52536014)(5660300002)(6506007)(55016003)(7696005)(26005)(8676002)(9686003)(533714002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 01:18:32.5089 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4d860fa-2262-4115-f2f1-08dac5de254c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9691 KEFkZCB4ODYgbWFpbnRhaW5lcnMgZm9yIG1vcmUgdmlzaWJpbGl0eSkNCg0KSGkgeDg2IG1haW50 YWluZXJzLA0KDQpTaW5jZSB0aGlzIHJlcG9ydCBtaWdodCBiZSByZWxhdGVkIHdpdGggdGhlIHJl bGVhc2UsIGlmIHlvdSBoYXZlIHRpbWUsDQpwbGVhc2UgaGF2ZSBhIGxvb2suIFRoYW5rIHlvdSB2 ZXJ5IG11Y2guDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNz YWdlLS0tLS0NCj4gU3ViamVjdDogdm51bWFfbm9kZXMgbWlzc2luZyBwbm9kZSAwDQo+IA0KPiBI aSBBbGwsDQo+IA0KPiBXaGlsZSBmaXhpbmcgWzFdIGEgcmVjZW50IGRvd25zdHJlYW0gbGlidmly dCBidWlsZCBmYWlsdXJlIGFnYWluc3QgNC4xNyByYzMsIEkNCj4gbm90aWNlZCB0aGUganNvbiBy ZXByZXNlbnRhdGlvbiBvZiBsaWJ4bF92bm9kZV9pbmZvIG9taXRzIHBub2RlIHdoZW4gdmFsdWUN Cj4gaXMgMC4NCj4gVGhlIHByb2JsZW0gY2FuIGJlIHNlZW4gYnkgc3RhcnRpbmcgYSBWTSBjb250 YWluaW5nIHRoZSBmb2xsb3dpbmcgdm51bWENCj4gY29uZmlnDQo+IA0KPiB2bnVtYSA9IFsgWyAi cG5vZGU9MCIsICJzaXplPTIwNDgiLCAidmNwdXM9MCIsICJ2ZGlzdGFuY2VzPTEwLDIwIiBdLCBb DQo+ICJwbm9kZT0xIiwgInNpemU9MjA0OCIsICJ2Y3B1cz0xIiwgInZkaXN0YW5jZXM9MjAsMTAi IF0gXQ0KPiANCj4gVGhlIGpzb24gcmVwcmVzZW50YXRpb24gZm9yIHRoaXMgY29uZmlnIGRvZXMg bm90IGNvbnRhaW4gcG5vZGUgMA0KPiANCj4gICAgICAgICAgICAgICAgICJ2bnVtYV9ub2RlcyI6 IFsNCj4gICAgICAgICAgICAgICAgICAgICAgew0KPiAgICAgICAgICAgICAgICAgICAgICAgICAg Im1lbWtiIjogMjA5NzE1MiwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICJkaXN0YW5jZXMi OiBbDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMTAsDQo+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgMjANCj4gICAgICAgICAgICAgICAgICAgICAgICAgIF0sDQo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAidmNwdXMiOiBbDQo+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgMA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgXQ0KPiAgICAgICAgICAgICAgICAg ICAgICB9LA0KPiAgICAgICAgICAgICAgICAgICAgICB7DQo+ICAgICAgICAgICAgICAgICAgICAg ICAgICAibWVta2IiOiAyMDk3MTUyLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgImRpc3Rh bmNlcyI6IFsNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAyMCwNCj4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAxMA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgXSwNCj4g ICAgICAgICAgICAgICAgICAgICAgICAgICJwbm9kZSI6IDEsDQo+ICAgICAgICAgICAgICAgICAg ICAgICAgICAidmNwdXMiOiBbDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMQ0KPiAg ICAgICAgICAgICAgICAgICAgICAgICAgXQ0KPiAgICAgICAgICAgICAgICAgICAgICB9DQo+ICAg ICAgICAgICAgICAgICAgXSwNCj4gDQo+IEknbSBub3QgZmFtaWxpYXIgd2l0aCB0aGUgY29kZSBn ZW5lcmF0b3IgZm9yIHRoZSAqX3RvX2pzb24gZnVuY3Rpb25zLCBidXQgd2l0aA0KPiBhDQo+IGhp bnQgSSBjYW4gcHJvYmFibHkgY29vayB1cCBhIHBhdGNoIDotKS4NCj4gDQo+IFJlZ2FyZHMsDQo+ IEppbQ0KPiANCj4gWzFdIGh0dHBzOi8vbGlzdG1hbi5yZWRoYXQuY29tL2FyY2hpdmVzL2xpYnZp ci1saXN0LzIwMjItDQo+IE5vdmVtYmVyLzIzNTc0NS5odG1sDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon Nov 14 05:37:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 05:37:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443065.697457 (Exim 4.92) (envelope-from ) id 1ouS9j-0000fX-9O; Mon, 14 Nov 2022 05:37:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443065.697457; Mon, 14 Nov 2022 05:37:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouS9j-0000fQ-5t; Mon, 14 Nov 2022 05:37:15 +0000 Received: by outflank-mailman (input) for mailman id 443065; Mon, 14 Nov 2022 05:37:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouS9i-0000fI-3N for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 05:37:14 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2055.outbound.protection.outlook.com [40.107.247.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 61cd2757-63de-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 06:37:11 +0100 (CET) Received: from DB6PR1001CA0019.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::29) by PAWPR08MB9967.eurprd08.prod.outlook.com (2603:10a6:102:358::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 05:37:07 +0000 Received: from DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b7:cafe::4d) by DB6PR1001CA0019.outlook.office365.com (2603:10a6:4:b7::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 05:37:07 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT047.mail.protection.outlook.com (100.127.143.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 05:37:06 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Mon, 14 Nov 2022 05:37:06 +0000 Received: from 9ff5d077711d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4AE02F0E-C796-4897-9BC9-0770327EECEA.1; Mon, 14 Nov 2022 05:37:00 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9ff5d077711d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 05:37:00 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AS2PR08MB8286.eurprd08.prod.outlook.com (2603:10a6:20b:555::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.5; Mon, 14 Nov 2022 05:36:58 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5834.005; Mon, 14 Nov 2022 05:36:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61cd2757-63de-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XcOVKeudHohIxCx+wwN6dFhd1ba4C+jLykpJJXE+ddVcY4CNf69HvModXTrer0VaaYris06zOKMYF7i/EHzHAT82Ni5fvw1Joh68YOp2Zrwda8hKnpMz7C1fbNTuaURFGpOSYsgIRMSNAccpr+9ccz/k4+JuI8g14t09Vd6cpKP56B4WB9D9q3ZGCTePAOWbiP8wIWXRc4xoch6elc0LFukOVosOIWRd/7Str0JOsnwvh0UI/rBpXNjoh6eEY8dmrJFevQgn4WuKUtb3Ws59sH+bic7MvWDn2GPo8FV4/+T57a6zNOEq7re2hFZUl2JBvdDofCac84zbQrQt60xnew== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bAkquCMnSf9NUHtJdbRks7IaTcn+PKulVs5WYvkH5yU=; b=ZYj1sGvBd5YEHb/XMzc5JAeP4nI0tgUeczOkMHG0OMvlduN2nLf7EbvsvS4D0n/LvX+UAq6HYnxOhru+Fkm4IXOfQmezR8mmq7IxGHmGlL6TQ3bGzfn0qpNtweUGV2I/BXNFn6PcjJxsSvbGkdAKgmxX/LJxrtd7wCYRvW6ZiBryupltCFcElPEm2oghWsNFqYj4vTKx3elYXEWRsV5REWr+VcGz/1H7T7i3tVZnBN/uJvBALBfAnBypZhj36xtJEQKCqHwAZWvkfhNZeNdgEYn5l/hZvmBwwKvmH3uZdKIKAJaRbSkCHdGsa8RC09YWsKs4SBSSVRQ4ClHqb8f6Rg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bAkquCMnSf9NUHtJdbRks7IaTcn+PKulVs5WYvkH5yU=; b=0xL3idI/QrHgi3FTreyc5Z8QK9OJLZ6U2UTYA0IfOGAMYEjS8NUWs7OumQFh6vfXB9pSmjojcXwVBwaPy/WYkZP7M2eOfMKDECwdsnETeqwe4oZ7mKo7WRmSzfnev5Arvy9oIQSBFJF8V0kINPdrH1ZFFYFNwKfpED/pqhdkuo4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GnYABCFwzrUUpUTYiEqyTwCOQZJdpA79/pdtSFxUqiNnYoJealtzcpQVrSWdhrKIbsjTOyMaypdCyQH7eciFVanuhuZuJbSGw/LNTh9CZxEmqoani8+9TGx7rR4tznFgverQ8NGpSynV3HwgcU5ywYS3ZcSGiz7hqD0CfP/CiGEmbW+vXHUfPSIaza8J/zSprY2bLjIJTdsXHs5iK0JVfXGxwOq9t57vfFSwC0zshB7sS8LbOf+HLh2CVfgKoPBHVwqBwMJBGZCJcsGS0HBU7Onn+HZcAS6tIlXOMQju248Opxj7zH0aw0i4jLKUbbp2az7b4V2it9tiCr0PbkYd8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bAkquCMnSf9NUHtJdbRks7IaTcn+PKulVs5WYvkH5yU=; b=UuwU0ozDci/t944A4icqIT19axMhJPlVIYJhAJrIcZwWn58pjLS43ENCo5lj/9LUe2Zbl3eaHPYBgEOLvBjZa2No09FK6j7WiIAjXunii4Jnioqz3A4sLh7RMP8HgBkGrd2N89kMRLf44xUmbVIredHM+bDBXk3RkUPAHcNSAOVYF6yosQ1Hq/kk8NeL99JlDL0257WcWapziaSSQeXPku1Y3ne63fV3eafd0aywNjzWrJi2VoWo9T5AkkmhDqRVvHZK8AQgnaWwRwtC0iRmBdS6kxNgy1Z5fX6d4OlBfLufPvcAZp+Nndvc7QevB5pIRSDrFIdFlKLMWPV2Hefv6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bAkquCMnSf9NUHtJdbRks7IaTcn+PKulVs5WYvkH5yU=; b=0xL3idI/QrHgi3FTreyc5Z8QK9OJLZ6U2UTYA0IfOGAMYEjS8NUWs7OumQFh6vfXB9pSmjojcXwVBwaPy/WYkZP7M2eOfMKDECwdsnETeqwe4oZ7mKo7WRmSzfnev5Arvy9oIQSBFJF8V0kINPdrH1ZFFYFNwKfpED/pqhdkuo4= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: RE: [PATCH v6 08/11] xen/arm64: move MMU related code from head.S to head_mmu.S Thread-Topic: [PATCH v6 08/11] xen/arm64: move MMU related code from head.S to head_mmu.S Thread-Index: AQHY8DVrMB29cZJCrk+wAkCu80OmKq4yVgCAgAPeDBCABz1OAIAAUxAg Date: Mon, 14 Nov 2022 05:36:58 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-9-wei.chen@arm.com> <5b975a59-5e97-c2a8-805c-9ab99b8712aa@xen.org> <927355c8-aea1-83c4-60c1-b06f8e0f182f@xen.org> In-Reply-To: <927355c8-aea1-83c4-60c1-b06f8e0f182f@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5FCE17B43323BD469D5FB109401E6D25.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|AS2PR08MB8286:EE_|DBAEUR03FT047:EE_|PAWPR08MB9967:EE_ X-MS-Office365-Filtering-Correlation-Id: b6644650-61b6-42e7-fd2e-08dac602444f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oSwpW8cHe797NSp5wPeZA60y0ZGssP3s9D2qUMb8LnqVeHB+ejdSjJ5ovHHV9c5y2JEo41V9QuRkpb4xKIiNuUvUcDejcq1j1q3DW2jsODNCGv50I7t0jfKmHnfn/ARbAubi8lgzxRzZ4uBiP3dEeVhkhmG+ecjiqhG7ddT6WAoj8koQMSuGECsXzT4Kz285BnvA691tTWw9mmbmJc6N0ph7U4L278l60hjN0ffsrhxSsJBjLCYZG4OIVL1i4VhbAYmwvLceM7Us/xIJ+DytT+xuxFhqgBF50c4MZbviHD3bvw1jW2qaSEHZ0w7d+yclTLS36zF3ek/U86EtGOyfr1EV1uwfklc80D4A4y7oukkioIU2u3LQBLCxmic6WH3szdr7W/XscsfdHn0xz5RwlwctR3RQ1mZoftyaP3o917EmSc595Q6S2y4Le8PtXRpqw6LfHwqzBfbNJzthu7gTV3kJq+0cOWhUpnxbQ4Qbwc76Pcf+0oJJnFQ5lkeW2vajCddY0rEKVqbgMEfpxzl+oFbjovt7aBfWsuWxZ5amh2JnuCJwOVEZNbbnVDGCkHNChf/adqGiOgIMONeBo4Oxw/sela9Q85sgolENbY/doAdJUIusVxLfa6JqV6JWPI1UJMsTjVkQqdjW3p8mXFWT78KzJfW4G+PYaeYpReRGI71w0QGWZ+sH+V9Cw/wA2z9SWw+GkA4Pu7Xq3dvuFJ0QAy2GAWZoPIk0+v+Nb0+G64/k8MLK0kNT3Qa3fIHPHzIbQjDeKfUUR5DgIoB3nVJMBOblqjBx2T5qqnzMAGCGW/M= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(366004)(396003)(136003)(376002)(451199015)(83380400001)(86362001)(64756008)(38100700002)(122000001)(38070700005)(2906002)(41300700001)(8936002)(52536014)(5660300002)(8676002)(9686003)(66446008)(66476007)(66556008)(71200400001)(53546011)(6506007)(7696005)(55016003)(186003)(54906003)(76116006)(110136005)(478600001)(4326008)(66946007)(316002)(66899015)(33656002)(60764002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8286 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 56b32369-e3ec-43ea-c9cf-08dac6023f8b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ULAx8fiNHCGS82H3qzl9ZVqsJAcqe4MkkYBnEulxhmmwfEwMJBp+2wBc537X/gpyN5SKQR9YjkiI4QdqmnNS2FhldMD1aIIEdV22adYcftBGLvbQmz+R0LAEaDuDgx+sId8E7BBRldfw8LVlpNHho3Z/PIJkvvp6V7PyQL0Tu1DSJ6pw18KxWzWWyWYx1gTBVxzti9gEH6faq1hsTY2wv0T8vmXv5Y+3NgtmaBYkClkYDHHCSnx+2vzbc325YXjAT+ow2sJ8F1a3d0YS+O71VLt0mPi6RipEM/sx6dY0dbD3zJ0rk2eR7OHIyIvgPvSeWH/HQuxx1DI6/kAZC38VU7NhbJWB6kqcxF0ksYC+8sQ/OL+mOmiBVi7f66recy77SRlzBrqboiZdybslhJb4i1OXUf9NKEM5PiC6qpyhGiwXyN3mPFNSW0tL+1BQ6ecTySv/IYnkpPFB1AemjeXPUmjmQvimmXdl6HNzx00t2qp4qs9IZU5GuYi4CUoHeUqVLwj2ZkkUwjlZVoHykgQnPOfGmQEm79TPHoVIN1M1ACPAclEZNPJG4caCOf9KJ+apm44GHYmQHhtbvJ88NF5YPASYiIm25vT/ZBkjh3xSgs1uuu4eC8RSGddfymhNQVL5FT+G50VzOdj8iDWcmT/NrecHysCATqNec6MkaHY53QuqpR48xMZtHAqA6AvirLXDsdDsMj7FcHFzLjK0oZWZGUFSexr54CrhRCkxaqI7ORPax//ILXf1Pzh5M41Rq2kJCXwljZ6mjsG5W0yZ+ElGYfFuZTwCH5YbkpjDJjmfkqE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(26005)(478600001)(33656002)(7696005)(6506007)(9686003)(53546011)(40480700001)(55016003)(86362001)(110136005)(54906003)(316002)(186003)(336012)(47076005)(52536014)(8936002)(36860700001)(81166007)(2906002)(70206006)(70586007)(82740400003)(82310400005)(41300700001)(83380400001)(5660300002)(66899015)(356005)(8676002)(4326008)(40460700003)(60764002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 05:37:06.4673 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b6644650-61b6-42e7-fd2e-08dac602444f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9967 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQxMeaciDE05pelIDU6NDMN Cj4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnDQo+IENjOiBuZCA8bmRAYXJtLmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0 YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRyYW5kDQo+IE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1 aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVrDQo+IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFt LmNvbT47IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQ QVRDSCB2NiAwOC8xMV0geGVuL2FybTY0OiBtb3ZlIE1NVSByZWxhdGVkIGNvZGUgZnJvbSBoZWFk LlMNCj4gdG8gaGVhZF9tbXUuUw0KPiANCj4gDQo+IA0KPiBPbiAwOS8xMS8yMDIyIDA3OjM2LCBX ZWkgQ2hlbiB3cm90ZToNCj4gPiBIaSBKdWxpZW4sDQo+IA0KPiBIaSBXZWksDQo+IA0KPiA+DQo+ ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206IEp1bGllbiBHcmFsbCA8 anVsaWVuQHhlbi5vcmc+DQo+ID4+IFNlbnQ6IDIwMjLlubQxMeaciDfml6UgNDowNg0KPiA+PiBU bzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmcNCj4gPj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3Rh YmVsbGluaUBrZXJuZWwub3JnPjsNCj4gQmVydHJhbmQNCj4gPj4gTWFycXVpcyA8QmVydHJhbmQu TWFycXVpc0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPj4gPFZvbG9keW15cl9CYWJj aHVrQGVwYW0uY29tPjsgSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KPiA+PiBTdWJq ZWN0OiBSZTogW1BBVENIIHY2IDA4LzExXSB4ZW4vYXJtNjQ6IG1vdmUgTU1VIHJlbGF0ZWQgY29k ZSBmcm9tDQo+IGhlYWQuUw0KPiA+PiB0byBoZWFkX21tdS5TDQo+ID4+DQo+ID4+IEhpIFdlaSwN Cj4gPj4NCj4gPj4gT24gMDQvMTEvMjAyMiAxMDowNywgV2VpIENoZW4gd3JvdGU6DQo+ID4+PiBU aGVyZSBhcmUgbG90cyBvZiBNTVUgc3BlY2lmaWMgY29kZSBpbiBoZWFkLlMuIFRoaXMgY29kZSB3 aWxsIG5vdA0KPiA+Pj4gYmUgdXNlZCBpbiBNUFUgc3lzdGVtcy4gSWYgd2UgdXNlICNpZmRlZiB0 byBnYXRlIHRoZW0sIHRoZSBjb2RlDQo+ID4+PiB3aWxsIGJlY29tZSBtZXNzeSBhbmQgaGFyZCB0 byBtYWludGFpbi4gU28gd2UgbW92ZSBNTVUgcmVsYXRlZA0KPiA+Pj4gY29kZSB0byBoZWFkX21t dS5TLCBhbmQga2VlcCBjb21tb24gY29kZSBzdGlsbCBpbiBoZWFkLlMuDQo+ID4+DQo+ID4+IEkg YW0gYWZyYWlkIHRoYXQgeW91IGNhbid0IHNpbXBseSBtb3ZlIHRoZSBNTVUgY29kZSBvdXQgb2Yg aGVhZC5TDQo+ID4+IGJlY2F1c2UgdGhpcyB3aWxsIGJyZWFrIFhlbiB3aGVuIHJ1bm5pbmcgdXNp bmcgdGhlIGlkZW50aXR5IG1hcC4NCj4gPj4NCj4gPj4gVGhpcyBpcyBiZWNhdXNlIHdlIG9ubHkg bWFwIHRoZSBmaXJzdCA0S0Igb2YgWGVuIHdpdGggUEEgPT0gVkEuIEF0IHRoZQ0KPiA+PiBtb21l bnQsIHdlIGd1YXJhbnRlZSBpdCBieSBoYXZpbmcgZXZlcnl0aGluZyB0aGF0IG5lZWRzIHRvIGJl IHVzZWQgaW4NCj4gPj4gdGhlIGlkZW50aXR5IG1hcHBpbmcgYmVmb3JlIF9lbmRfYm9vdCBhbmQg Y2hlY2tpbmcgYXQgbGluayB0aW1lIGlmIHRoaXMNCj4gPj4gZml0cyBpbiA0S0IuDQo+ID4+DQo+ ID4+IE5vdyB0aGF0IHlvdSBtb3ZlZCB0aGUgTU1VIGNvZGUgb3V0c2lkZSBvZiBoZWFkLlMuIFdl IG5lZWQgdG8gZmluZCBhDQo+ID4+IGRpZmZlcmVudCB3YXkgdG8gZ3VhcmFudGVlIGl0LiBPbmUg d2F5IHRvIGRvIGl0IHdvdWxkIGJlIHRvIGNyZWF0ZSBhDQo+ID4+IHNlY3Rpb24gdGhhdCB3b3Vs ZCBiZSB1c2VkIGZvciBldmVyeXRoaW5nIHRoYXQgbmVlZHMgdG8gYmUgaWRlbnRpdHkNCj4gbWFw cGVkLg0KPiA+Pg0KPiA+DQo+ID4gUXVvdGUgZnJvbSBuZXh0IGVtYWlsDQo+ID4gIg0KPiA+IExv b2tpbmcgYXQgdGhlIGNvZGUgdGhpcyBtb3JuaW5nLCBJIG5vdGljZWQgdGhhdCB3ZSBhbHJlYWR5 IGhhdmUgdGhlDQo+ID4gc2VjdGlvbiAiLnRleHQuaGVhZGVyIi4gRm9yIG5vdywgdGhhdCBzaG91 bGQgZG8gdGhlIGpvYi4gU28gd2UganVzdCBuZWVkDQo+ID4gdG8gY2hlY2sgdGhlIHNpemUgb2Yg LnRleHQuaGVhZGVyLg0KPiA+DQo+ID4gSWRlYWxseSwgY2hlY2tpbmcgdGhlIHNpemUgc2hvdWxk IGJlIGRvbmUgaW4gYSBzZXBhcmF0ZSBwcmUtcGF0Y2ggc28gaXQNCj4gPiBpcyBlYXNpZXIgdG8g cmV2aWV3Lg0KPiA+ICINCj4gPg0KPiA+IE9LLiBXZSB3aWxsIGNyZWF0ZSBhIHBhdGNoIHRvIGNo ZWNrIHRoZSBzaXplLCBhbmQgcGxhY2UgaXQgaW4gdGhlDQo+ID4gaGVhZCBvZiB0aGUgc2VyaWVz Lg0KPiANCj4gSSB0aG91Z2h0IGEgYml0IG1vcmUgYWJvdXQgd2hhdCBJIHdyb3RlLiBYZW4gYmlu YXJ5IHNob3VsZCBhbHdheXMgc3RhcnQNCj4gd2l0aCB0aGUgSW1hZ2UvWmltYWdlIGhlYWRlci4g QXQgdGhlIG1vbWVudCwgdGhpcyBpcyBndWFyYW50ZWVkIGJlY2F1c2UNCj4gdGhlcmUgaXMgb25s eSBvbmUgb2JqZWN0IHVzaW5nIHRoZSBzZWN0aW9uIC50ZXh0LmhlYWRlci4NCj4gDQo+IFdpdGgg dGhlIGNoYW5nZSBpbnRyb2R1Y2VkIGluIHRoaXMgcGF0Y2gsIHRoZXJlIHdpbGwgYmUgbXVsdGlw bGUgb2JqZWN0cw0KPiB1c2luZyB3aXRoIHRoZSBzZWN0aW9ucyAudGV4dC5oZWFkZXIuIFRoaXMg bWVhbnMgd2UgYXJlIHJlbHlpbmcgb24gdGhlDQo+IGNvbXBpbGVyIHRvIGFsd2F5cyBwdXQgdGhl IGNvbnRlbnQgb2YgaGVhZC5TIGZpcnN0Lg0KPiANCg0KWWVzLCBub3cgaXQgZGVwZW5kcyBvbiB0 aGUgb2JqZWN0cycgb3JkZXIgaW4gTWFrZWZpbGUuIFRoaXMgc2hvdWxkIGJlDQphIHJpc2suDQoN Cj4gVGhpcyBpcyBiYXNpY2FsbHkgcmV2ZXJ0aW5nIHRvIHRoZSBiZWhhdmlvciBiZWZvcmUgY29t bWl0IDQyNjdhMzNiMTlkDQo+ICgieGVuL2J1aWxkOiBwdXQgaW1hZ2UgaGVhZGVyIGludG8gYSBz ZXBhcmF0ZSBzZWN0aW9uIikuDQo+IA0KPiBUaGVyZWZvcmUgd2UgZG8gbmVlZCBhIHNlcGFyYXRl IHNlY3Rpb24gdG8gYmUgdXNlZCBmb3IgaGVhZF8qLlMgYW5kDQo+IG1heWJlIHBhcnQgb2YgaGVh ZC5TLiBUaGlzIG5ldyBzZWN0aW9uIGNvdWxkIGJlIGNhbGxlZCB0ZXh0LmlkbWFwIHNvIHdlDQo+ IGtub3cgd2hhdCB0aGUgc2VjdGlvbiBpcyB1c2VkIGZvci4NCj4gDQoNClllcywgd2UgbWlnaHQg cGxhY2UgdGhpcyBuZXcgc2VjdGlvbiBhZnRlciB0ZXh0LmhlYWRlci4NCg0KQ2hlZXJzLA0KV2Vp IENoZW4NCg0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Mon Nov 14 05:43:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 05:43:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443068.697468 (Exim 4.92) (envelope-from ) id 1ouSFe-00025v-Vw; Mon, 14 Nov 2022 05:43:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443068.697468; Mon, 14 Nov 2022 05:43:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouSFe-00025n-RZ; Mon, 14 Nov 2022 05:43:22 +0000 Received: by outflank-mailman (input) for mailman id 443068; Mon, 14 Nov 2022 05:43:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouSFe-00025d-7L; Mon, 14 Nov 2022 05:43:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouSFe-0001FT-2x; Mon, 14 Nov 2022 05:43:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouSFd-0000TY-JR; Mon, 14 Nov 2022 05:43:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouSFd-0004Sz-J4; Mon, 14 Nov 2022 05:43:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=50HVS61qd6ZdGZyf+jkGYawKeKOFT07NobtGGmDQ1CY=; b=LQPKAAHfD32VCf/+/gdmfZT7Hx yRbPJ/SQiHyajohE2VZRJsGxPQ7LjsJgZ3SmjqxC4BTX+eKoPt2whc/l7rREqwkBW/Z4Qdd5NX+nq 7XC7VfKkjyrJDfA6W4CuTAL1wvy1lWEDHlEjJ46VREtmcBAeDyJjagZGaD9KtQ10CrNM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174757: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=af7a056891899fd3942afec79fb219f58271e319 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Mon, 14 Nov 2022 05:43:21 +0000 flight 174757 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174757/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux af7a056891899fd3942afec79fb219f58271e319 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 37 days Failing since 173470 2022-10-08 06:21:34 Z 36 days 60 attempts Testing same since 174757 2022-11-13 20:13:06 Z 0 days 1 attempts ------------------------------------------------------------ 1704 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 162121 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Nov 14 06:24:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 06:24:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443078.697479 (Exim 4.92) (envelope-from ) id 1ouStL-0006wu-8I; Mon, 14 Nov 2022 06:24:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443078.697479; Mon, 14 Nov 2022 06:24:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouStL-0006wn-5V; Mon, 14 Nov 2022 06:24:23 +0000 Received: by outflank-mailman (input) for mailman id 443078; Mon, 14 Nov 2022 06:24:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouStJ-0006wd-P6; Mon, 14 Nov 2022 06:24:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouStJ-0002JL-Kv; Mon, 14 Nov 2022 06:24:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouStJ-00038i-5y; Mon, 14 Nov 2022 06:24:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouStJ-0002TR-5a; Mon, 14 Nov 2022 06:24:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KoOFxXWCUOJOgJ4380Dxr4knUo1mwhrs4pMZd3JiWB4=; b=4tWLOhh1Ml6oGq1mRRODudLaVt AeRt8OAUZQl/QN4MHXqSPY/V/L4RtHw7UW0JnMGK6CBXZYEVey7PtHNXKHOKHA5P0oyNHA+CihOkX in1nh8Jiq5zDrXoXIgO+5jDcTPtbwAhwhZzsJIzLnvRwoB+cS806EJZckevJ0khxScxA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174758: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=771a8acbb84145b943bd608ba376e104ebfa9664 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Mon, 14 Nov 2022 06:24:21 +0000 flight 174758 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174758/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 174540 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 174540 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 174755 pass in 174758 test-armhf-armhf-libvirt-raw 13 guest-start fail pass in 174755 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 174755 like 174540 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 174755 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 771a8acbb84145b943bd608ba376e104ebfa9664 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 15 days Failing since 174575 2022-11-01 18:42:39 Z 12 days 23 attempts Testing same since 174727 2022-11-10 22:13:32 Z 3 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anna Schumaker Anssi Hannula Ard Biesheuvel Arnaldo Carvalho de Melo Biju Das Brian Foster Brian Norris Carlos Llamas Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Chuhong Yuan Damien Le Moal Dan Carpenter Darrick J. Wong Darrick J. Wong Dave Chinner Dave Chinner David S. Miller David Sterba Dean Luick Demi Marie Obenour Dennis Dalessandro Dokyung Song Dongliang Mu Eric Dumazet Eric Sandeen Filipe Manana Florian Fainelli Gaosheng Cui Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Han Xu Hangyu Hua Hannu Hartikainen Hans Verkuil Heiko Carstens Heiko Stuebner Helge Deller Hyong Youb Kim Hyunwoo Kim Håkon Bugge Ilias Apalodimas Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jason Gunthorpe Jeff Vanhoof Jens Axboe Jens Glathe Jim Mattson Jimmy Assarsson Jiri Kosina Johan Hovold John Veness Jon Hunter Jon Maloy Jonathan Cameron Jonathan Corbet Josh Poimboeuf Juergen Gross Julian Anastasov Justin Chen Kalle Valo Kan Liang Konrad Jankowski Kuniyuki Iwashima Kuogee Hsieh Leon Romanovsky Leon Romanovsky Li Qiang Linus Torvalds Linux Kernel Functional Testing Luiz Augusto von Dentz Luiz Capitulino Luís Henriques M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Martin K. Petersen Martin Tůma Masami Hiramatsu (Google) Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Maxim Levitsky Maxim Mikityanskiy Meena Shanmugam Michal Hocko Michal Jaron Michal Simek Mike Kravetz Miklos Szeredi Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Pablo Neira Ayuso Paolo Abeni Paolo Bonzini Paul E. McKenney Paul Moore Peter Zijlstra (Intel) Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rasmus Villemoes Richard Weinberger Rik van Riel Saeed Mahameed Sakari Ailus Samuel Bailey Sascha Hauer Sasha Levin Serge Hallyn Sergey Shtylyov Shakeel Butt Shang XiaoJing Shreeya Patel Shuah Khan Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Theodore Ts'o Thinh Nguyen Tim Harvey Tom Lendacky Tomasz Moń Tony O'Brien Trond Myklebust Tvrtko Ursulin Uday Shankar Ulf Hansson Vasily Averin Vasily Gorbik Ville Syrjälä Vineet Gupta Vladimir Oltean Wei Yongjun Willy Tarreau Wolfram Sang Xin Long Yang Yingliang Ye Bin Yongqin Liu Yu Kuai Zhang Changzhong Zhang Qilong Zhang Xiaoxu Zheng Yejian Zhengchao Shao Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 4692 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Nov 14 06:33:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 06:33:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443084.697490 (Exim 4.92) (envelope-from ) id 1ouT28-00005t-46; Mon, 14 Nov 2022 06:33:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443084.697490; Mon, 14 Nov 2022 06:33:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT28-00005m-1M; Mon, 14 Nov 2022 06:33:28 +0000 Received: by outflank-mailman (input) for mailman id 443084; Mon, 14 Nov 2022 06:33:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT26-00005g-EB for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 06:33:26 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60086.outbound.protection.outlook.com [40.107.6.86]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3cd8c34d-63e6-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 07:33:23 +0100 (CET) Received: from AM5PR0502CA0020.eurprd05.prod.outlook.com (2603:10a6:203:91::30) by AS8PR08MB6088.eurprd08.prod.outlook.com (2603:10a6:20b:291::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 06:33:16 +0000 Received: from AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:91:cafe::c4) by AM5PR0502CA0020.outlook.office365.com (2603:10a6:203:91::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Mon, 14 Nov 2022 06:33:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT032.mail.protection.outlook.com (100.127.140.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:33:16 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Mon, 14 Nov 2022 06:33:15 +0000 Received: from ecc797ed8142.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CF3ECC59-CE3E-49FF-B1B0-AB8270467EA8.1; Mon, 14 Nov 2022 06:33:09 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ecc797ed8142.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 06:33:09 +0000 Received: from FR3P281CA0184.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::19) by DU2PR08MB10278.eurprd08.prod.outlook.com (2603:10a6:10:46e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 06:33:06 +0000 Received: from VI1EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a4:cafe::f0) by FR3P281CA0184.outlook.office365.com (2603:10a6:d10:a4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 06:33:06 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT010.mail.protection.outlook.com (100.127.144.228) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:33:05 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 14 Nov 2022 06:33:04 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 14 Nov 2022 06:33:03 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Mon, 14 Nov 2022 06:33:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3cd8c34d-63e6-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fa9ydqmGlydP2i1jNGbPKWp98VrSwiEtVEF4O0khvv8=; b=Ev+8xR3sAoIJOL2bBT/MsU/bHvq6J9TkR9BQ+ikRbIohjEv/ruA9Lio8JIGEmDE6OHyU1Frf2BF33/sa0I6C36NoKlx+Z5+wou3Sm04Z/NCd4yZxLJ8wRRtF7JnBGVwyF+4bpe+cWKZnfFBwS+PRXkio0uAIp72PjjBNmB9KKTY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a4aedd2f7361b588 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zj+MJ7QLGdLiAEnyT0/oa70HrJRVpNuNjVV5stN+tftYIkt2YAkC7jhCEvM7+tDKcknad4WS4a6xz21c4CKhrakxmcfBxQ05HiUYO3zaeZgcuB5Y50Tu5hfGUAE9URVyt4r0MNCgrbHIyYGP63MQ45cPvIjMcJKzoyPcRa+DaBPoMEl7uV3d2R+FdXWxH68QD3KufrLx95blQYQ0fW8O+8m+co1rowW2aXXu0XaeLMNLusKIQhLfmSf31q/0tfUn0H+YOq0aA6C1bOWN+dhIeuDhzgoyJUVaIKTwsUEml7xEwWQiB30/8jH2o0tGbHuAg1+8SSNE/RQ6piOOhkM37Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fa9ydqmGlydP2i1jNGbPKWp98VrSwiEtVEF4O0khvv8=; b=YqndY98VCCRkF9UTJLWfvIHEdNuNMHrRFh8V8DG3IQCVwp+WK5GamlAUfFXr/O3F4NYPlNsyMqjczCVkpKul9Ts1hYlBcSu7ZlV9iUfMXKEh5jha/Hd5MMXc6K4hHUbZZj52ZfKLajkemiRA9HlRMmLVr8NZbTPcj/Rr7PXJIeWtDThMSQB4LlCTMDu0UXhuFZCBr6Y0QtzRc9ekI9xfgdju+Z1QEaMhvCCVuWxHRcfiugD+NSmGOLYMAcVC6fMoX9bhT7ud38uWZnL4izTvg0oFAnNa49/Z+j9MhnRIt5rxLdkbrNJJquN6YaG8FdoNxL4L0jIErIb27odnztfDEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fa9ydqmGlydP2i1jNGbPKWp98VrSwiEtVEF4O0khvv8=; b=Ev+8xR3sAoIJOL2bBT/MsU/bHvq6J9TkR9BQ+ikRbIohjEv/ruA9Lio8JIGEmDE6OHyU1Frf2BF33/sa0I6C36NoKlx+Z5+wou3Sm04Z/NCd4yZxLJ8wRRtF7JnBGVwyF+4bpe+cWKZnfFBwS+PRXkio0uAIp72PjjBNmB9KKTY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: , CC: , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v8 0/6] Device tree based NUMA support for Arm - Part#2 Date: Mon, 14 Nov 2022 14:32:51 +0800 Message-ID: <20221114063257.473585-1-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT010:EE_|DU2PR08MB10278:EE_|AM7EUR03FT032:EE_|AS8PR08MB6088:EE_ X-MS-Office365-Filtering-Correlation-Id: 933a4e7e-25b6-471e-cc14-08dac60a1cd1 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wuT6hRCyynWPn6MhufH2pGPg2H9RyAaDiX89Z9EZsukXwquvhcreriutWgfydGFrWKejHRR6TWzTNhOiG/IJ11Fi0rfJn9YQqFpsn9iYnI06oFiGosWD+GYAPxOlH6tkHHQBnci8rL5X03cvKBPtmoFgylf9uwBjk6igZfFt0SQYx9NlMHs4pNkVXw5fhIxzDEISwlAkQ+1pNR8t1fHQclBfty2MtouMpgRCC/DFh5xGaHWRMqZ0tc0PuVSRl1IU46Uavn6w/H/V6F6k6NUGxpjBkmEjA+tK/L0Jvr1bD4aP05jw6p+l+ZIz8fpbIQvavUwl8EWxGqsGX4/5SPx3s6LkI0wgdh9K40/H50TO8hvVW5A6hr3YBjfzHZ+oHlANKqFdrkTjazDNrtXiHk71F9PiOw1xwjter213XAYzvwKaYhzFwGcE6nxPcNq0en7agZavO9233yV8Mm5Rw/z0hFW0+lgyHJGPhfElQyu20ht+P6yyEjM4xKsV64c6qtQ7JCaFLKFKoz9n9uwMFCiWkePnIefY/plfRvEDCFUvEkeZQsn5+KhNGexDd9mGvY0qJTFamlV8J4ZcTQOUbgZa7AB8+2sFy4qvp0jjW+dtgXL9ULSx1fNCqIwSs5a0C9DZEoLk2RLRAC/y6z7RsG9zAqxlZPhegnW1BXym58vCd3Tlip/wTHQ47WfSBdokHOaz2XzMPQAadlC6MBQ+fOv5fuEnymVLIaaO0iaYu4+CwMRP5AG7f/Mjcr090JxWGm1DTvAyNqbba9s4pYCBiJCQ0+ue1FsYTyzjoTp8h0MuqWEjLvOrI4LrZ56yG8XdVb0vPVZo/gmKd13CaCQWTzMeLU1NlGKSCm5cc6k4/sLPCmV/t9FpGuekKc2Yhf6dubH0 X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(396003)(451199015)(46966006)(36840700001)(40470700004)(356005)(26005)(7696005)(6666004)(83380400001)(36860700001)(966005)(8676002)(4326008)(110136005)(478600001)(82740400003)(54906003)(316002)(70206006)(70586007)(41300700001)(5660300002)(81166007)(40460700003)(44832011)(8936002)(2906002)(86362001)(82310400005)(47076005)(426003)(336012)(2616005)(1076003)(186003)(40480700001)(36756003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB10278 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 735e4fa5-d3fe-4c05-8be2-08dac60a167d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HQIK7vZq/fJWvZQeIJLwZzVZ+m/Mcs2Abho5um+ZQn07lqTjJIkG8qtAKV7N8sL+JOOZhOTkzgmVtHW5o7rwwG2aYJ0GeulM0SPbgy/EjmyRpkTGXjbCZ8B3BAbGBRpDYO/pmvi+vnBzQ4D5oWgwH+CNisEQUYKynKdA9BvCv4/POmzAopTGTr4NFW9TK+p1wv0UQNDleUYRn4wxECyGqKdB7y4wwT9UhHB55Oa8YId7iCIY1avnoqkuMGHpenKRYOKPnrHu56GHbrOSgN1GJLLG9TZosufblc4zOOiowbH3pi89F/AL1F6/VjTAkXPrT/P4hFaRll3YXLwk+kOawXuYqjqmbvHo27ju9R8VrQDpVLzJr4yRPKI5OAJjCnrAuhuW0+ZnmTxNsMbcUIaO7MCJ+MgHrV2aBJIELqLfWakhmr46+wn0dSkMiMCxZfwxF9AhMgR/njhsbDy06rrvB0eBChgdCBu3QzXOot121ORqemBwZQhD3alShjPwV9otO5JNCEPdh9h3hhFjF/zywtbW+w+WOM/ZLjTBzK9Tmat3cWDS3CzV1VnfOs9BFS+L4jQ/uk5p51194tHK4YvlRiFIxNInrKrMYCk4MjbtYERjIoou8PyrG08Z96M0RUDwDSmpBvNxX2C/GEnlfdadcbtFYNDihB7dd8+DfrqySsCfpxisIsKmUFj97OlGdNfCg8Qr8ufS733zVBpBVIYFtClVrXhqcMDhyxVbwC7WTCxVUYtTisT3hQhh20vjXMQft9tybYGDKULZYqgPAzyL8VrfX+N8hMOtTMIbvOEJH33khhnl7RKz6GaHX0YD96QiKNReTFjuD5t7PfdJHhN1fjl6gXLSQJFh1j9GjbTMSKTUUH0MqgmcQQPtwVHojslay0Fwgs4KHbeSegAMFxoMNg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(376002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(7696005)(6666004)(86362001)(107886003)(2906002)(966005)(478600001)(26005)(5660300002)(82310400005)(44832011)(41300700001)(40480700001)(70206006)(36860700001)(4326008)(2616005)(336012)(70586007)(8676002)(47076005)(426003)(1076003)(186003)(40460700003)(81166007)(110136005)(83380400001)(82740400003)(8936002)(54906003)(316002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 06:33:16.1049 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 933a4e7e-25b6-471e-cc14-08dac60a1cd1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6088 (The Arm device tree based NUMA support patch set contains 35 patches. In order to make stuff easier for reviewers, I split them into 3 parts: 1. Preparation. I have re-sorted the patch series. And moved independent patches to the head of the series - merged in [1] 2. Move generically usable code from x86 to common - this series. 3. Add new code to support Arm. This series only contains the second part patches. As the whole NUMA series has been reviewed for 1 round in [2], so this series would be v8) Xen memory allocation and scheduler modules are NUMA aware. But actually, on x86 has implemented the architecture APIs to support NUMA. Arm was providing a set of fake architecture APIs to make it compatible with NUMA awared memory allocation and scheduler. Arm system was working well as a single node NUMA system with these fake APIs, because we didn't have multiple nodes NUMA system on Arm. But in recent years, more and more Arm devices support multiple nodes NUMA system. So now we have a new problem. When Xen is running on these Arm devices, Xen still treat them as single node SMP systems. The NUMA affinity capability of Xen memory allocation and scheduler becomes meaningless. Because they rely on input data that does not reflect real NUMA layout. Xen still think the access time for all of the memory is the same for all CPUs. However, Xen may allocate memory to a VM from different NUMA nodes with different access speeds. This difference can be amplified in workloads inside VM, causing performance instability and timeouts. So in this patch series, we implement a set of NUMA API to use device tree to describe the NUMA layout. We reuse most of the code of x86 NUMA to create and maintain the mapping between memory and CPU, create the matrix between any two NUMA nodes. Except ACPI and some x86 specified code, we have moved other code to common. In next stage, when we implement ACPI based NUMA for Arm64, we may move the ACPI NUMA code to common too, but in current stage, we keep it as x86 only. This patch serires has been tested and booted well on one Arm64 NUMA machine and one HPE x86 NUMA machine. [1] https://lists.xenproject.org/archives/html/xen-devel/2022-06/msg00499.html [2] https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg01903.html --- v7 -> v8: 1. Rebase code to resolve merge conflict. 2. Change "of shift too small" to "or shift too small". 3. Add numa_fw_nid_name setting in srat_parse_regions after acpi_table_parse succeeded. v6 -> v7: 1. Restore %d for nodeid_t in dump_numa. 2. Use sizeof(page_num_node) for page_num_node size in memset. 3. Add description for using min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift when only one node is in the system. 4. Use %pd for domain print in dump_numa. 5. Add __init for arch_numa_unavailable. 6. Use __ro_after_init for mem_hotplug. 7. Use "???" instead of "NONAME" for unset numa_fw_nid_name. 8. Fix code-style. v5 -> v6: 1. Revert arch_numa_broken to arch_numa_disabled, as acpi_numa can be set to -1 by users. So acpi_numa < 0 does not mean a broken firmware. 2. Replace numa_scan_node to numa_process_nodes in commit log. 3. Limit the scope of page_num_node, vnuma and page of numa_setup function. 4. Use memset to init page_num_node instead of for_each_online_node. 5. Use %u instead of %d for nodeid_t and j in numa_setup print messages. 6. Use min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift when only one node is in the system. 7. Drop the marco: node_to_first_cpu(node) 8. Use arch_numa_unavailable to replace arch_numa_disabled for acpi_numa <= 0. 9. Remove Kconfig for HAS_NUMA_NODE_FWID. 10. Use numa_fw_nid_name for NUMA implementation to set their fw NUMA node name for print messages. v4 -> v5: 1. Use arch_numa_broken instead of arch_numa_disabled for acpi_numa < 0 check. Because arch_numa_disabled might include acpi_numa < 0 (init failed) and acpi_numa == 0 (no data or data no init) cases. 2. Use nodeid_t instead of uint8_t for memnodemap. 3. Restore to use typeof(*memnodemap) for _memnodemap, this will avoid the further adjustments for _memnodemap's type. 4. Use __ro_after_init for numa_off. 5. Use pointer-to-const for proper function parameters. 6. Use unsigned int for variables that are not realy used for node ID. 7. Fix code comments code-style and adjust the length. 8. Fix code-styles. 9. Rename numa_scan_nodes to numa_process_nodes. 10. Defer introduce arch_numa_disabled for acpi_numa <= 0. And remove the paramter init_as_disable of arch_numa_disabled. 11. Fix typo "expandsion". 12. Fix Indentation for l1tf_safe_maddr. 13. Remove double blank lines. 14. Add a space between for_each_node_mask and '('. Add a space page_list_for_each and '('. 15. Use bool for nodes_cover_memory return value. 16. Use a plain "int ret" to record compute_hash_shift return value. 17. Add a blank line before the function's main "return". 18. Add new Kconfig option HAS_NUMA_NODE_FWID to common/Kconfig. v3 -> v4: 1. Add init_as_disable as arch_numa_disabled parameter in the patche where use it. 2. Drop unnecessary "else" from arch_numa_setup, and fix its indentation. 3. Restore compute_hash_shift's return value to int. 4. Remove unnecessary parentheses for macros. 5. Use unsigned int for proper variables. 6. Fix some code-style. 7. Move arch_get_ram_range function comment to header file. 8. Use bool for found, and add a new "err" for the return value of arch_get_ram_range. 9. Use -ENODATA instead of -EINVAL for non-RAM type ranges. 10. Use bool as return value for functions that only return 0/1 or 0/-EINVAL. 11. Move mem_hotplug to a proper place in mm.h 12. Remove useless "size" in numa_scan_nodes. 13. Add CONFIG_HAS_NUMA_NODE_FWID to gate print the mapping between node id and architectural node id (fw node id). v2 -> v3: 1. Drop enumeration of numa status. 2. Use helpers to get/update acpi_numa. 3. Insert spaces among parameters of strncmp in numa_setup. 4. Drop helpers to access mem_hotplug. Export mem_hotplug for all arch. 5. Remove acpi.h from common/numa.c. 6. Rename acpi_scan_nodes to numa_scan_nodes. 7. Replace u8 by uint8_t for memnodemap. 8. Use unsigned int for memnode_shift and adjust related functions (compute_hash_shift, populate_memnodemap) to use correct types for return values or parameters. 9. Use nodeid_t for nodeid and node numbers. 10. Use __read_mostly and __ro_after_init for appropriate variables. 11. Adjust the __read_mostly and __initdata location for some variables. 12. Convert from plain int to unsigned for cpuid and other proper 13. Remove unnecessary change items in history. 14. Rename arch_get_memory_map to arch_get_ram_range. 15. Use -ENOENT instead of -ENODEV to indicate end of memory map. 16. Add description to code comment that arch_get_ram_range returns RAM range in [start, end) format. 17. Rename bad_srat to numa_fw_bad. 18. Rename node_to_pxm to numa_node_to_arch_nid. 19. Merge patch#7 and #8 into patch#6. 20. Move NR_NODE_MEMBLKS from x86/acpi.h to common/numa.h 22. Use 2-64 for node range. v1 -> v2: 1. Refine the commit messages of several patches. 2. Merge v1 patch#9,10 into one patch. Introduce the new functions in the same patch that this patch will be used first time. 3. Fold if ( end > mem_hotplug ) to mem_hotplug_update_boundary, in this case, we can drop mem_hotplug_boundary. 4. Remove fw_numa, use enumeration to replace numa_off and acpi_numa. 5. Correct return value of srat_disabled. 6. Introduce numa_enabled_with_firmware. 7. Refine the justification of using !node_data[nid].node_spanned_pages. 8. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. 9. Adjust the conditional express for ASSERT. 10. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86. 11. Use conditional macro to gate MAX_NUMNODES for other architectures. 12. Use arch_get_memory_map to replace arch_get_memory_bank_range and arch_get_memory_bank_number. 13. Remove the !start || !end check, because caller guarantee these two pointers will not be NULL. 14. Add code comment for numa_update_node_memblks to explain: Assumes all memory regions belonging to a single node are in one chunk. Holes between them will be included in the node. 15. Merge this single patch instead of serval patches to move x86 SRAT code to common. 16. Export node_to_pxm to keep pxm information in NUMA scan nodes error messages. 17. Change the code style to target file's Xen code-style. 18. Adjust some __init and __initdata for some functions and variables. 19. Replace CONFIG_ACPI_NUMA by CONFIG_NUMA. Replace "SRAT" texts. 20. Turn numa_scan_nodes to static. 21. Change NR_NUMA_NODES upper bound from 4095 to 255. Wei Chen (6): xen/x86: Provide helpers for common code to access acpi_numa xen/x86: move generically usable NUMA code from x86 to common xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid xen/x86: use arch_get_ram_range to get information from E820 map xen/x86: move NUMA process nodes nodes code from x86 to common xen: introduce a Kconfig option to configure NUMA nodes number xen/arch/Kconfig | 11 + xen/arch/x86/include/asm/acpi.h | 2 - xen/arch/x86/include/asm/mm.h | 2 - xen/arch/x86/include/asm/numa.h | 61 +-- xen/arch/x86/include/asm/setup.h | 1 - xen/arch/x86/mm.c | 2 - xen/arch/x86/numa.c | 441 +---------------- xen/arch/x86/smpboot.c | 2 +- xen/arch/x86/srat.c | 336 ++----------- xen/common/Makefile | 1 + xen/common/numa.c | 803 +++++++++++++++++++++++++++++++ xen/common/page_alloc.c | 2 + xen/include/xen/mm.h | 2 + xen/include/xen/numa.h | 96 +++- 14 files changed, 961 insertions(+), 801 deletions(-) create mode 100644 xen/common/numa.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 06:35:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 06:35:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443089.697512 (Exim 4.92) (envelope-from ) id 1ouT3s-0000zH-RS; Mon, 14 Nov 2022 06:35:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443089.697512; Mon, 14 Nov 2022 06:35:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT3s-0000z7-Nh; Mon, 14 Nov 2022 06:35:16 +0000 Received: by outflank-mailman (input) for mailman id 443089; Mon, 14 Nov 2022 06:35:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT3r-0000jp-Lj for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 06:35:15 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2063.outbound.protection.outlook.com [40.107.22.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7eb9acab-63e6-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 07:35:14 +0100 (CET) Received: from AS9PR06CA0254.eurprd06.prod.outlook.com (2603:10a6:20b:45f::29) by PA4PR08MB7594.eurprd08.prod.outlook.com (2603:10a6:102:270::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Mon, 14 Nov 2022 06:35:11 +0000 Received: from AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45f:cafe::27) by AS9PR06CA0254.outlook.office365.com (2603:10a6:20b:45f::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 06:35:11 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT045.mail.protection.outlook.com (100.127.140.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:11 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Mon, 14 Nov 2022 06:35:11 +0000 Received: from bb2e14286891.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 63C7EE23-4EA2-4853-85DD-8BDF269879A3.1; Mon, 14 Nov 2022 06:35:04 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bb2e14286891.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 06:35:04 +0000 Received: from AM6PR0202CA0058.eurprd02.prod.outlook.com (2603:10a6:20b:3a::35) by GV2PR08MB8076.eurprd08.prod.outlook.com (2603:10a6:150:7a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 06:35:01 +0000 Received: from VI1EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:3a:cafe::7a) by AM6PR0202CA0058.outlook.office365.com (2603:10a6:20b:3a::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Mon, 14 Nov 2022 06:35:01 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT006.mail.protection.outlook.com (100.127.144.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:00 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 14 Nov 2022 06:34:59 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 14 Nov 2022 06:34:59 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Mon, 14 Nov 2022 06:34:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7eb9acab-63e6-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6BX3altsA9WE+7OQp4hlskOrTm04k11y2EFC28HI9J0=; b=jQqGCu64+aQExqPelXrAqV8V1HyZhOYUtMcjIFW91GdeHjbLeSzpXHIbTW9uLmHFrKaq/Pwx58du2YAFzFLa67Ab0HP/BSaQkpVyiq6jXmtK/cPLl5IivojDx66ZDcnBpSG3doejhf9UfY2uam8Q0J52f7AiKMsRVo58xQie/5I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 959ea5b20c4765b5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UR4DZGFV8EMQb3YEjOKATkifgzx3LtJ/6wmN8qEsm+JV873T13T/xgV9IbsRMZ+JmyDcsxeDQ4eJmNhkg4ZMQG5lAR+dQrUdlgasNwUAOag0pRBxKGn8/uU3pK8R28c3XoHry4LQsUbG6C3QNkcpYiFHRhVYibcG/UkHvlLOPQs1+9J3oUvoGCta/VF7+IVBbRVRTVZbHgQ5rHEJlVPBqOKTRSM6vRR0frPli0SlYPxidy7HMspdsrHpLz4kL2t2X471yv2LZdPpOyioKeu/KLa8Cex8yWgntt4rB9knZWD5MfVY4grdEjG6haEDO3Cv+4nbwzAhrrmrvuCnNzrCAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6BX3altsA9WE+7OQp4hlskOrTm04k11y2EFC28HI9J0=; b=FdL4j92CsAm5eItSkO+Ju5xGW3LBgMuHnjU+iTa4DfOfIEkZywQhm7HO0xYzU3XC33UoGrQ6hzFpvdiHwWcA2+FfZL5Xxt8fssfEwMZmKjd4G/gpA5DXaVXdR88h++NXBE0DySPAPVaP6OFINEcASnKLfo0IBtfcFPtbDlLpv36/kd4rmfVhNV3VSxlhXGykgoSwYtVWR33TEOUNOJ2KulvvU1BCYBJBtirP9dAWGfDAQCPLJBUjsQUQIGvftbV5zX6cO3cU33yAATZBUcA0sCpNw/f0fc3MXXm0SHS6R0CRW2uoNFMatHlLPCe+M2S2gnPlFydO+9nHdPbHG9I+EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6BX3altsA9WE+7OQp4hlskOrTm04k11y2EFC28HI9J0=; b=jQqGCu64+aQExqPelXrAqV8V1HyZhOYUtMcjIFW91GdeHjbLeSzpXHIbTW9uLmHFrKaq/Pwx58du2YAFzFLa67Ab0HP/BSaQkpVyiq6jXmtK/cPLl5IivojDx66ZDcnBpSG3doejhf9UfY2uam8Q0J52f7AiKMsRVo58xQie/5I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v8 1/6] xen/x86: Provide helpers for common code to access acpi_numa Date: Mon, 14 Nov 2022 14:34:46 +0800 Message-ID: <20221114063451.473711-2-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221114063451.473711-1-wei.chen@arm.com> References: <20221114063451.473711-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT006:EE_|GV2PR08MB8076:EE_|AM7EUR03FT045:EE_|PA4PR08MB7594:EE_ X-MS-Office365-Filtering-Correlation-Id: abefe6af-4272-4586-476e-08dac60a61a7 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ZDbOr2LrNHVBwdXeWEazDd91g+IwyFTQNZQHQpDnexUrKgmyvTb/bno1PdZ+hQ5omI3tZgTKf5SMSieqmfodCVQ9wurx9Y+Tceoxu3YwibKWBVpKHagSK7BeY4RPYmWOBBaPakd6EECNUDOYD8+t05Z++6puX0tMcES/1TWq0PXZkIri0XcQcU6TsHNhPPrVJaBqlVs5bkkI7ISllrX/257kbfpGuiWG5K+nb5SaZPhPcHucX9ZxHK4rCOw24MJ3fIu+oxOjL4ZOG5fgH5GSKTu+37RqLR0UBeBYeXK1Hwaq77roxAxtUcGr5pcTrd7CjIIGpif9+xVVPZanr2mNgWTkesEEt/01PL3n2ujMdFTMoxzOI7IWBCgggP/vj8UDaSXdnOzbccIDwXB/mkMA53xSECmQDG24F+q8h25X952KgemXgmanMh+mLyYLNazpKL6z+EAFTFELbRlEVGymYI8WmIJ/13sp+bgYTd6khxB1krtgzkDXsAqeTOnjcctiOLBCjAdzdP2IbTrkPKg/SuzD+iVk/AnascM2Mhp7CQLPxDS6SkoB7QUUnpI1H+vVsS7dkGU43ucABtwIOvB0ULmmv3AtGwdSXNept85MEySKjx+YOdPe5rMu4rGsjh/Cy+d6Zvm4dd8ikSzZ3pXz80VFv69R3h6SE5GeEDPpfsOrBpGIMbzf8+myEPykryFR6DibvYqnom6wNfX4sD8CF73cVkE/SxDGTPmARLEiJYlLawLWqMxoUEcZTiU36iTANpxRd0aQkA6K3Ql7zIcl8djW5UX/otP0KE6vF8y4v0uxpf4zYeYTUPCPPJaSQ/2Y X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(346002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(6666004)(40480700001)(36860700001)(478600001)(54906003)(6916009)(1076003)(5660300002)(41300700001)(336012)(44832011)(36756003)(47076005)(426003)(2906002)(8936002)(70206006)(186003)(316002)(26005)(4326008)(8676002)(70586007)(7696005)(2616005)(40460700003)(83380400001)(86362001)(82740400003)(82310400005)(81166007)(356005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8076 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5aec99bc-82b9-45db-7e3e-08dac60a5b28 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eU7WKeXIafYyzgYg9H5F101ZRlsKxL9Rb2Pc5iygWknuVg+V2dyTS8IMWQj2dfDEF5BbZFtqCP9wQeFPWKu6AFlwVJXZ6ycykwCU1nkmlUhMgjZOHqkRNx5kXQPB2apmWfrz6cKMEzAWTrTE0pwrWJOrI+IkvfFpgp2amX+cEIszPtWAMD44lA/QUGJRWnfG5A5G05mh+NcutDLwpd0MoaqNcNgW/o3jXAu7d8GC6/0bol6wQEyuDh3OpRRj1Ow04pF7b1LIYYDqG/WBLrsxnOQZfjaAm1OK18wjFK+Wttdz8/nslBTidEmCjiXWxokPvlzTQ4lxpYweBo2nnjB4hvu0SieO2/iyctxmQ5zAsAcAA0aTQI7urHIkqRl64+9AuQsiFnLodkEiOX0ymV8CZsEWcprOU2NBoCzk5GCmZ2w6XKuuHpyBs9eOpazkUtWT6/GWttd43ZYI2a4HkWNRDm4apzqSu2mnTBD1zLDmqmpXMqw6yEKnZSptppKAMFDaJLtvzdtz2YqcW1IQo2qZBjXi033cszvUZneRNpggUhNh7UwFCyTAZLS478ZZvilpykHE17PkgbWx9cKJwHuMKLR6zjgJBJyP5zGkdU2oICpOtpqdNr2Dt3Rc/ezkpgikN4+LLIYwKTjwOOZHppEse7avNd+444vzxY34Z9HJOrMGzF3b3DRVdZ9aHHryWsfT+o7T32CQ2OVAmJ2M2z7qbXBYr087SVA1IrX8WBkz5+I+HLPAv1KFqGKYyV/SOqtm1pBoYEpJ+nmNGZmLXiSHjQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199015)(36840700001)(40470700004)(46966006)(36860700001)(2906002)(86362001)(36756003)(40460700003)(40480700001)(81166007)(336012)(47076005)(426003)(82310400005)(82740400003)(478600001)(316002)(186003)(54906003)(7696005)(6916009)(8676002)(70586007)(44832011)(1076003)(2616005)(4326008)(70206006)(26005)(8936002)(6666004)(41300700001)(5660300002)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 06:35:11.6046 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: abefe6af-4272-4586-476e-08dac60a61a7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7594 acpi_numa is a specific NUMA switch for ACPI NUMA implementation. Other NUMA implementation may not need this switch. But this switch is not only used by ACPI code, it is also used directly in some general NUMA logic code. So far this hasn't caused any problem because Xen only has x86 implementing ACPI NUMA, but now Arm is implementing device tree based NUMA. Accesssing acpi_numa directly in some functions will be a block of reusing NUMA common code. It is also difficult for us to replace it with a new generic switch, because it is hard to prove that the new switch states can guarantee the original code will work correctly. So in this patch, we provide two helpers for common code to update and get states of acpi_numa. And other new NUMA implementations just need to provide the same helpers for common code. In this case, the generic NUMA logic code can be reused by all NUMA implementations. Signed-off-by: Wei Chen Reviewed-by: Jan Beulich --- v7 -> v8: 1. No change. v6 -> v7: 1. Add Rb. v5 -> v6: 1. Revert arch_numa_broken to arch_numa_disabled, as acpi_numa can be set to -1 by users. So acpi_numa < 0 does not mean a broken firmware. v4 -> v5: 1. Use arch_numa_broken instead of arch_numa_disabled for acpi_numa < 0 check. Because arch_numa_disabled might include acpi_numa < 0 (init failed) and acpi_numa == 0 (no data or data no init) cases. v3 -> v4: 1. Drop parameter from arch_numa_disabled, the parameter will be introduced in later patch where use it. 2. Drop unnecessary "else" from arch_numa_setup, and fix its indentation. v2 -> v3: 1. Drop enumeration of numa status. 2. Use helpers to get/update acpi_numa. 3. Insert spaces among parameters of strncmp in numa_setup. v1 -> v2: 1. Remove fw_numa. 2. Use enumeration to replace numa_off and acpi_numa. 3. Correct return value of srat_disabled. 4. Introduce numa_enabled_with_firmware. --- xen/arch/x86/include/asm/numa.h | 5 +++-- xen/arch/x86/numa.c | 38 ++++++++++++++++++++++----------- 2 files changed, 28 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index c32ccffde3..237f2c6dbf 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -32,8 +32,9 @@ extern void numa_add_cpu(int cpu); extern void numa_init_array(void); extern bool numa_off; - -extern int srat_disabled(void); +extern int arch_numa_setup(const char *opt); +extern bool arch_numa_disabled(void); +extern bool srat_disabled(void); extern void numa_set_node(int cpu, nodeid_t node); extern nodeid_t setup_node(unsigned int pxm); extern void srat_detect_node(int cpu); diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 322157fab7..1c3198445d 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -50,9 +50,28 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; bool numa_off; s8 acpi_numa = 0; -int srat_disabled(void) +int __init arch_numa_setup(const char *opt) { - return numa_off || acpi_numa < 0; +#ifdef CONFIG_ACPI_NUMA + if ( !strncmp(opt, "noacpi", 6) ) + { + numa_off = false; + acpi_numa = -1; + return 0; + } +#endif + + return -EINVAL; +} + +bool arch_numa_disabled(void) +{ + return acpi_numa < 0; +} + +bool srat_disabled(void) +{ + return numa_off || arch_numa_disabled(); } /* @@ -294,28 +313,21 @@ void numa_set_node(int cpu, nodeid_t node) /* [numa=off] */ static int __init cf_check numa_setup(const char *opt) { - if ( !strncmp(opt,"off",3) ) + if ( !strncmp(opt, "off", 3) ) numa_off = true; - else if ( !strncmp(opt,"on",2) ) + else if ( !strncmp(opt, "on", 2) ) numa_off = false; #ifdef CONFIG_NUMA_EMU else if ( !strncmp(opt, "fake=", 5) ) { numa_off = false; - numa_fake = simple_strtoul(opt+5,NULL,0); + numa_fake = simple_strtoul(opt + 5, NULL, 0); if ( numa_fake >= MAX_NUMNODES ) numa_fake = MAX_NUMNODES; } -#endif -#ifdef CONFIG_ACPI_NUMA - else if ( !strncmp(opt,"noacpi",6) ) - { - numa_off = false; - acpi_numa = -1; - } #endif else - return -EINVAL; + return arch_numa_setup(opt); return 0; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 06:35:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 06:35:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443088.697501 (Exim 4.92) (envelope-from ) id 1ouT3r-0000jx-IX; Mon, 14 Nov 2022 06:35:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443088.697501; Mon, 14 Nov 2022 06:35:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT3r-0000jq-Fl; Mon, 14 Nov 2022 06:35:15 +0000 Received: by outflank-mailman (input) for mailman id 443088; Mon, 14 Nov 2022 06:35:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT3p-0000je-BO for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 06:35:13 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2070.outbound.protection.outlook.com [40.107.22.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7d70b6b4-63e6-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 07:35:12 +0100 (CET) Received: from FR0P281CA0115.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::14) by PAWPR08MB9853.eurprd08.prod.outlook.com (2603:10a6:102:2e6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Mon, 14 Nov 2022 06:35:09 +0000 Received: from VI1EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a8:cafe::77) by FR0P281CA0115.outlook.office365.com (2603:10a6:d10:a8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 06:35:09 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT026.mail.protection.outlook.com (100.127.144.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:08 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Mon, 14 Nov 2022 06:35:08 +0000 Received: from 1064e1a21da7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A5D57DC8-D973-4F9D-954C-6959773FC0FB.1; Mon, 14 Nov 2022 06:35:01 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1064e1a21da7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 06:35:01 +0000 Received: from AM6P191CA0102.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::43) by DB9PR08MB6396.eurprd08.prod.outlook.com (2603:10a6:10:23e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 06:34:58 +0000 Received: from VI1EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8a:cafe::b6) by AM6P191CA0102.outlook.office365.com (2603:10a6:209:8a::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 06:34:58 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT030.mail.protection.outlook.com (100.127.144.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:34:57 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 14 Nov 2022 06:34:56 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Mon, 14 Nov 2022 06:34:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d70b6b4-63e6-11ed-91b6-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LCxBp8/Y6a1XNQyu2bHf6du2PkpnPhjpit+kGzITmB2NGFXolYAsda71H3U6/EaYFTG5SBnrQOOxYtIzFLuASPmAlEftLvrk6XdSUbRufUAyEs0G2WrZdxzlpTotRPGgu5dgnRaX+vAG+R1dme05d7wYt0ua6DuovfJbHkuc6VUDgiSJJuhffhFYlqe++cYPZ1fncA5nOKid8p075mj2Off+1R0IH6zrkr/e44ve4C53GteTeYmSmvaoezfSKC2qg1VplR7zAVwVlQgzNfY9sq9dxRBCmuHLb0DmKEP/LToen8ucJSfyI7uKAnHPhOBQS+I6L0xMoKWsj1iCb9KmNA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fa9ydqmGlydP2i1jNGbPKWp98VrSwiEtVEF4O0khvv8=; b=K9B5pEtJ0Pe3kRXz/kAQvWGqwgAvLRKJKPze6/Om0yx10Wic4rKECBIyrau94xwvgJkEOtB3VRMqCMCOPFVTDqvc1YUXNzX4NN44UbrKdSHTijgmLuJtw2OrgYqWp5Dw57YXvUzg/JsUcCIjuLFX1e8iJtHWAS0Tw7iHRYwpoUU0M8lO3xXi+HQHAVc4fBYcw/FNXahM68mEsFwKjahM5IsjHNo6cfOShgoPubwtYwwaVkRaHtIj8Pae+46t3mPC7QdYpm5Rl8EC5i1GnBQFQrQCBEBUjHDn9JPecTb1EgLEjpfKpZs0ayLYOgjEWqF+mq7woAWFScdNGDxXLOiVNg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fa9ydqmGlydP2i1jNGbPKWp98VrSwiEtVEF4O0khvv8=; b=Ux1cQjBrNagpiZ8TxTzzQYcAmU2ng6izu7bEYPfS47op7rDnYl6pUOOFZllN6BMoJJbS/XmGEz3rbf/Kx2k7aHVxFqJ3y/bXrUQoP4fHzEhKjvTJthcmDZT7Ef3+wPTUCyxvZs83VIbckDKpAIDsH3KVExM/tzIrlLnnr+XwYrU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 23741b2be7ca534b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cnwf9kGYTMNl9+KNxt5K1WpPpS18QcdEXwUaHaS4ou9b4EFfIUQBggzZ06WCf0ZCS6Mefk9+3KLkFVKt4nKej2FQiHnSNBmmuKgZW0LbaPoEJ+uGyRMf8uM9tovwbtWYmP6vpijlSxlK0tQeqNMf311xSU99/AGcEACvp+OTZL6gJX4nQ4nBDz3B7CQilHTQCycZ2WdGtkq5q5u4gg7D+RGZm2nU0NRm9Z2LOcv5DbDgIg+bkXTWb7e6vhFUjadB2Mc2R1ydGjYJ+XM1058kOPx/JlinoxI0eGk5j+uNI23MZQsTicVXIiZWtyeDiml1+DmYeqMYm2/jQKQKDOtSWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fa9ydqmGlydP2i1jNGbPKWp98VrSwiEtVEF4O0khvv8=; b=cIEsQDttIatumRL70BE6S03u5HBI6ZgxB399jIQ4mSujMsMVQ5Xb1IXXExGDJqwsnxgGo67uO8BUpif7DuN2k2jiGjQacuMyq8HbPE0H5A4ULzC101lcNSGtrorWjVGZDTURKfD1QoCXLtU7Wr3cp2L2s58S35dXA+a+1SNQHwqR5BrdWeAqDbqqm16CrSSKMuqpCATGIvIitGNAzzXCh3Ds7V+5kV0FVXyR9pvn6iTbH9ol+7yxSx3c3zuKMzNzp7LVEbrH+UYFa7ZYdBccJeVf7IUSC/w31Lc8kr16eFBWuzZpOg/jG62S74R9XaMTMDpoTyy3U51aNR1evtOnTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fa9ydqmGlydP2i1jNGbPKWp98VrSwiEtVEF4O0khvv8=; b=Ux1cQjBrNagpiZ8TxTzzQYcAmU2ng6izu7bEYPfS47op7rDnYl6pUOOFZllN6BMoJJbS/XmGEz3rbf/Kx2k7aHVxFqJ3y/bXrUQoP4fHzEhKjvTJthcmDZT7Ef3+wPTUCyxvZs83VIbckDKpAIDsH3KVExM/tzIrlLnnr+XwYrU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v8 0/6] Device tree based NUMA support for Arm - Part#2 Date: Mon, 14 Nov 2022 14:34:45 +0800 Message-ID: <20221114063451.473711-1-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT030:EE_|DB9PR08MB6396:EE_|VI1EUR03FT026:EE_|PAWPR08MB9853:EE_ X-MS-Office365-Filtering-Correlation-Id: 3186f97e-cca9-4ba8-cb4d-08dac60a5ff1 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 33bpLYfgfMqQ4DQt2K2L9IYOnghvZ/pJdIQYX53Q8f4QXRdb7Gf9AxSGID8xdG4Ax3HrikGl2nCnpQRKt/qhQSQoJfTL4R1rOFPT54nCkMnc1Pf2FRXm31vXq2VbVWgaKPowKJRSLoA3YKcpW2GNgpfC6YKI3qZDXWEKJg1ZxliAunLY8kSqbazMCR6kZgtoGOoYUG6EFuweRYFi11PB8wJxWHk5UxeG5WAHSCd9yOwA+qys3qQVXhknr4gN0jgMV0pVNH6Bxvo8x8mqIaN47lpeZCG0RqQ4BLC62oeA9aGzVD/Qn8nVZs+M/111JtpMeDbjJtdSMDHM7Sk6GDgl5tWYRpaZhq/PHLyFdWKmzfTF3FUpidNJXd3GzFKGBvmzEA1+0HYdssH3x+of5oq9F2q1hilhEjgspitkmSTLY5fSKDqrYRkk7yXEIdYgAmob5hknbXGMJIFn+Ajn70VPnw8X8ACrX1qEsPaD1Ag0T30PCn++htmUoEw6fZX1CYftTShL9u1IGQDNKQj6UAcR2vu6iMVkLYZggtZVWCkOb3kIDHZW86tJDTwQmqm8YeDJdkOqq+EhYXOQAA2GBXyVIUw2UPeSlKnmeB120w6efcK3HMyqYK42m3JfGN35VMJ/yggNT/ioRR+fZKsxhomXvAlSKr3bXEiyHtEu09MuUPmEFqWrZuA23hk41umYkP1sv7a9RXs8sEECTjiqSSXWk+zi+cDCOGDIlEQYENtQIjhn3f/BE5u+SduUS4aXCov+lVOZYzK0SjABObqx5CQTEUW2BjqZZPXWZQ9dE1KNYmWHld0bcIcR++RK1jJayKAUwrLlJw4T4ln94sTlyj3bSlhVL7c25yIu5IrZZO+QABO4bhEHRecW6kL65+SrbXhq X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(376002)(136003)(451199015)(40470700004)(36840700001)(46966006)(41300700001)(426003)(5660300002)(336012)(47076005)(186003)(1076003)(2616005)(8936002)(81166007)(26005)(44832011)(7696005)(6666004)(82740400003)(478600001)(966005)(36756003)(8676002)(40460700003)(356005)(70206006)(70586007)(6916009)(316002)(40480700001)(4326008)(54906003)(36860700001)(2906002)(82310400005)(86362001)(83380400001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6396 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: eed4997e-ac80-4bde-7120-08dac60a598d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1xYt3mVfW628312nJjxR8I0u0vm0OU07EfOj2KjVUAMLdXu40rX0eeHjUmNNBTS0PGtSivTfMGYmaqU53w15rsy7KGI4XykVPj8CdkZql1lCB7kWO1VeJWbgRu88uX76rkhHMeoX6Q3WLrg+bdRLef2wbstJjCMZZhP7kaLZVfojXuqOEJJsGzHOwEIiclW/oc0f2+lbtWFKgHUdIpyYZ07yKqcjvkcjOilUHvv/t0bBvH6ipiQ+L4CJIHI1jWR6srePD1pWdjEhuiAxPlTkst+2QED2PK5AhNdedTPP+rgIPtzh4EBqXCXX4/smBuh8JUUWkjgzqysiNmed1qD1TRat1By87Q195Z5MPWjbNNzfvQ4Up1XnL4gEfPUleDZvq8jZ4XuxYeIsskvNKKg0eecOZtzzgYS+ZV3lUDh/ME6SDMnYX1xloRnXfYTxV6ymMjxorkPU/ApOiMUKZz1Izm+ifsj4r2ffVySn3kZOmhIxaWa7DIkNdx576S2PWjXzBOtd2/vCbK5z2gx5m3M2X9boPjJeXuaGTagPLPtsjf/OQNZmJFau+hxX2xYIkTRLrLPeSOxIo5eRHXgSuilirATVzJ7PbFffkoO+XN/flrfRhZbD49zqGoUJFP07o4bMJH3HKwWSvPkNed3IORrtf6S/UFB3hj4+/aV9YopvLlmqv/PXcIgK3cAT3v0bxG6ZhvrrfFIWlZdVZKVoe5oj76ip0uDTpAULtt84h58WTz/qWI4X2bQpVej+tEqVBm52iTx92y1/OiXpIwvA8EvyywCs+PMTAphde0CR0q7PHS7f6cpziYNDf1emYD1GnLeJd46u9w+MF8fi9ckTSiZxzw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(376002)(346002)(451199015)(46966006)(36840700001)(40470700004)(7696005)(107886003)(82310400005)(336012)(186003)(966005)(1076003)(6666004)(26005)(40460700003)(2616005)(81166007)(40480700001)(36756003)(86362001)(478600001)(47076005)(83380400001)(426003)(36860700001)(82740400003)(5660300002)(8936002)(41300700001)(2906002)(6916009)(44832011)(316002)(70586007)(8676002)(54906003)(4326008)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 06:35:08.6594 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3186f97e-cca9-4ba8-cb4d-08dac60a5ff1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9853 (The Arm device tree based NUMA support patch set contains 35 patches. In order to make stuff easier for reviewers, I split them into 3 parts: 1. Preparation. I have re-sorted the patch series. And moved independent patches to the head of the series - merged in [1] 2. Move generically usable code from x86 to common - this series. 3. Add new code to support Arm. This series only contains the second part patches. As the whole NUMA series has been reviewed for 1 round in [2], so this series would be v8) Xen memory allocation and scheduler modules are NUMA aware. But actually, on x86 has implemented the architecture APIs to support NUMA. Arm was providing a set of fake architecture APIs to make it compatible with NUMA awared memory allocation and scheduler. Arm system was working well as a single node NUMA system with these fake APIs, because we didn't have multiple nodes NUMA system on Arm. But in recent years, more and more Arm devices support multiple nodes NUMA system. So now we have a new problem. When Xen is running on these Arm devices, Xen still treat them as single node SMP systems. The NUMA affinity capability of Xen memory allocation and scheduler becomes meaningless. Because they rely on input data that does not reflect real NUMA layout. Xen still think the access time for all of the memory is the same for all CPUs. However, Xen may allocate memory to a VM from different NUMA nodes with different access speeds. This difference can be amplified in workloads inside VM, causing performance instability and timeouts. So in this patch series, we implement a set of NUMA API to use device tree to describe the NUMA layout. We reuse most of the code of x86 NUMA to create and maintain the mapping between memory and CPU, create the matrix between any two NUMA nodes. Except ACPI and some x86 specified code, we have moved other code to common. In next stage, when we implement ACPI based NUMA for Arm64, we may move the ACPI NUMA code to common too, but in current stage, we keep it as x86 only. This patch serires has been tested and booted well on one Arm64 NUMA machine and one HPE x86 NUMA machine. [1] https://lists.xenproject.org/archives/html/xen-devel/2022-06/msg00499.html [2] https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg01903.html --- v7 -> v8: 1. Rebase code to resolve merge conflict. 2. Change "of shift too small" to "or shift too small". 3. Add numa_fw_nid_name setting in srat_parse_regions after acpi_table_parse succeeded. v6 -> v7: 1. Restore %d for nodeid_t in dump_numa. 2. Use sizeof(page_num_node) for page_num_node size in memset. 3. Add description for using min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift when only one node is in the system. 4. Use %pd for domain print in dump_numa. 5. Add __init for arch_numa_unavailable. 6. Use __ro_after_init for mem_hotplug. 7. Use "???" instead of "NONAME" for unset numa_fw_nid_name. 8. Fix code-style. v5 -> v6: 1. Revert arch_numa_broken to arch_numa_disabled, as acpi_numa can be set to -1 by users. So acpi_numa < 0 does not mean a broken firmware. 2. Replace numa_scan_node to numa_process_nodes in commit log. 3. Limit the scope of page_num_node, vnuma and page of numa_setup function. 4. Use memset to init page_num_node instead of for_each_online_node. 5. Use %u instead of %d for nodeid_t and j in numa_setup print messages. 6. Use min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift when only one node is in the system. 7. Drop the marco: node_to_first_cpu(node) 8. Use arch_numa_unavailable to replace arch_numa_disabled for acpi_numa <= 0. 9. Remove Kconfig for HAS_NUMA_NODE_FWID. 10. Use numa_fw_nid_name for NUMA implementation to set their fw NUMA node name for print messages. v4 -> v5: 1. Use arch_numa_broken instead of arch_numa_disabled for acpi_numa < 0 check. Because arch_numa_disabled might include acpi_numa < 0 (init failed) and acpi_numa == 0 (no data or data no init) cases. 2. Use nodeid_t instead of uint8_t for memnodemap. 3. Restore to use typeof(*memnodemap) for _memnodemap, this will avoid the further adjustments for _memnodemap's type. 4. Use __ro_after_init for numa_off. 5. Use pointer-to-const for proper function parameters. 6. Use unsigned int for variables that are not realy used for node ID. 7. Fix code comments code-style and adjust the length. 8. Fix code-styles. 9. Rename numa_scan_nodes to numa_process_nodes. 10. Defer introduce arch_numa_disabled for acpi_numa <= 0. And remove the paramter init_as_disable of arch_numa_disabled. 11. Fix typo "expandsion". 12. Fix Indentation for l1tf_safe_maddr. 13. Remove double blank lines. 14. Add a space between for_each_node_mask and '('. Add a space page_list_for_each and '('. 15. Use bool for nodes_cover_memory return value. 16. Use a plain "int ret" to record compute_hash_shift return value. 17. Add a blank line before the function's main "return". 18. Add new Kconfig option HAS_NUMA_NODE_FWID to common/Kconfig. v3 -> v4: 1. Add init_as_disable as arch_numa_disabled parameter in the patche where use it. 2. Drop unnecessary "else" from arch_numa_setup, and fix its indentation. 3. Restore compute_hash_shift's return value to int. 4. Remove unnecessary parentheses for macros. 5. Use unsigned int for proper variables. 6. Fix some code-style. 7. Move arch_get_ram_range function comment to header file. 8. Use bool for found, and add a new "err" for the return value of arch_get_ram_range. 9. Use -ENODATA instead of -EINVAL for non-RAM type ranges. 10. Use bool as return value for functions that only return 0/1 or 0/-EINVAL. 11. Move mem_hotplug to a proper place in mm.h 12. Remove useless "size" in numa_scan_nodes. 13. Add CONFIG_HAS_NUMA_NODE_FWID to gate print the mapping between node id and architectural node id (fw node id). v2 -> v3: 1. Drop enumeration of numa status. 2. Use helpers to get/update acpi_numa. 3. Insert spaces among parameters of strncmp in numa_setup. 4. Drop helpers to access mem_hotplug. Export mem_hotplug for all arch. 5. Remove acpi.h from common/numa.c. 6. Rename acpi_scan_nodes to numa_scan_nodes. 7. Replace u8 by uint8_t for memnodemap. 8. Use unsigned int for memnode_shift and adjust related functions (compute_hash_shift, populate_memnodemap) to use correct types for return values or parameters. 9. Use nodeid_t for nodeid and node numbers. 10. Use __read_mostly and __ro_after_init for appropriate variables. 11. Adjust the __read_mostly and __initdata location for some variables. 12. Convert from plain int to unsigned for cpuid and other proper 13. Remove unnecessary change items in history. 14. Rename arch_get_memory_map to arch_get_ram_range. 15. Use -ENOENT instead of -ENODEV to indicate end of memory map. 16. Add description to code comment that arch_get_ram_range returns RAM range in [start, end) format. 17. Rename bad_srat to numa_fw_bad. 18. Rename node_to_pxm to numa_node_to_arch_nid. 19. Merge patch#7 and #8 into patch#6. 20. Move NR_NODE_MEMBLKS from x86/acpi.h to common/numa.h 22. Use 2-64 for node range. v1 -> v2: 1. Refine the commit messages of several patches. 2. Merge v1 patch#9,10 into one patch. Introduce the new functions in the same patch that this patch will be used first time. 3. Fold if ( end > mem_hotplug ) to mem_hotplug_update_boundary, in this case, we can drop mem_hotplug_boundary. 4. Remove fw_numa, use enumeration to replace numa_off and acpi_numa. 5. Correct return value of srat_disabled. 6. Introduce numa_enabled_with_firmware. 7. Refine the justification of using !node_data[nid].node_spanned_pages. 8. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. 9. Adjust the conditional express for ASSERT. 10. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86. 11. Use conditional macro to gate MAX_NUMNODES for other architectures. 12. Use arch_get_memory_map to replace arch_get_memory_bank_range and arch_get_memory_bank_number. 13. Remove the !start || !end check, because caller guarantee these two pointers will not be NULL. 14. Add code comment for numa_update_node_memblks to explain: Assumes all memory regions belonging to a single node are in one chunk. Holes between them will be included in the node. 15. Merge this single patch instead of serval patches to move x86 SRAT code to common. 16. Export node_to_pxm to keep pxm information in NUMA scan nodes error messages. 17. Change the code style to target file's Xen code-style. 18. Adjust some __init and __initdata for some functions and variables. 19. Replace CONFIG_ACPI_NUMA by CONFIG_NUMA. Replace "SRAT" texts. 20. Turn numa_scan_nodes to static. 21. Change NR_NUMA_NODES upper bound from 4095 to 255. Wei Chen (6): xen/x86: Provide helpers for common code to access acpi_numa xen/x86: move generically usable NUMA code from x86 to common xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid xen/x86: use arch_get_ram_range to get information from E820 map xen/x86: move NUMA process nodes nodes code from x86 to common xen: introduce a Kconfig option to configure NUMA nodes number xen/arch/Kconfig | 11 + xen/arch/x86/include/asm/acpi.h | 2 - xen/arch/x86/include/asm/mm.h | 2 - xen/arch/x86/include/asm/numa.h | 61 +-- xen/arch/x86/include/asm/setup.h | 1 - xen/arch/x86/mm.c | 2 - xen/arch/x86/numa.c | 441 +---------------- xen/arch/x86/smpboot.c | 2 +- xen/arch/x86/srat.c | 336 ++----------- xen/common/Makefile | 1 + xen/common/numa.c | 803 +++++++++++++++++++++++++++++++ xen/common/page_alloc.c | 2 + xen/include/xen/mm.h | 2 + xen/include/xen/numa.h | 96 +++- 14 files changed, 961 insertions(+), 801 deletions(-) create mode 100644 xen/common/numa.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 06:35:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 06:35:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443090.697523 (Exim 4.92) (envelope-from ) id 1ouT3z-0001Jn-7H; Mon, 14 Nov 2022 06:35:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443090.697523; Mon, 14 Nov 2022 06:35:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT3z-0001Jg-3j; Mon, 14 Nov 2022 06:35:23 +0000 Received: by outflank-mailman (input) for mailman id 443090; Mon, 14 Nov 2022 06:35:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT3x-0000je-Am for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 06:35:21 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60058.outbound.protection.outlook.com [40.107.6.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8283bc60-63e6-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 07:35:20 +0100 (CET) Received: from AM6PR02CA0026.eurprd02.prod.outlook.com (2603:10a6:20b:6e::39) by DBBPR08MB5900.eurprd08.prod.outlook.com (2603:10a6:10:200::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 06:35:18 +0000 Received: from VI1EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::9f) by AM6PR02CA0026.outlook.office365.com (2603:10a6:20b:6e::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Mon, 14 Nov 2022 06:35:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT024.mail.protection.outlook.com (100.127.145.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:17 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Mon, 14 Nov 2022 06:35:17 +0000 Received: from f86e1ad6935a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 417D2173-24BE-462E-82A4-C024437D6604.1; Mon, 14 Nov 2022 06:35:10 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f86e1ad6935a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 06:35:10 +0000 Received: from AM5PR0701CA0012.eurprd07.prod.outlook.com (2603:10a6:203:51::22) by AS8PR08MB9979.eurprd08.prod.outlook.com (2603:10a6:20b:633::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.5; Mon, 14 Nov 2022 06:35:09 +0000 Received: from VI1EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:51:cafe::ea) by AM5PR0701CA0012.outlook.office365.com (2603:10a6:203:51::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 06:35:09 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT037.mail.protection.outlook.com (100.127.145.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:08 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 14 Nov 2022 06:35:06 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8283bc60-63e6-11ed-91b6-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hkjfLnulgTyObZoO0fVFr/lI4OKC+V2BhspmIrjXd4I9Rge3auZ1fGWZ3s7/WXm3aSQFvzRfX0PuTutvqgWHkYNeC729G73n661pL8hmTv6NAvcXiGbqIGAa4BM2Y+yiE1filgceD8mMeB7oH3TWLBqjA5Yj+tbAcVDVyXjSURLmNWuX5gsQnqQM27cM+DGYKZyDun2sROSCjjAvHSnRbRVYfXBhNXur7v++LiR5KEGdNFvoqs5mpRLpwHc44T//jYY4+MStmpYNmK2c48vJaFA/bc8iNK5TIPwbQY17dIhgdq4dAChE9miPRffvcXIBTZfjerE0PihuSjiajQ1NSQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=brakFrnKNMC9j4IFSknCbUCY2g1RemWkZGm8rewRdUM=; b=gb5f0qfqrkxxiW3u86t9SuQF44IzXw8FlSpxwep1wALPJGKtgTLLgYHWICyMA/1t/gelkrdSN7aeagGYLv3lhpIss56QhmGfCUbpMN4R80bdKtm8hWNHc0xUMvMz8qmO3+9CMvpI1XFlmOpAmE3+QMoDIchg40TDUPhsmcV8gHwHZ2KKuz20ZyBpI/CJhxs6n/iifWe/ejj95OV9HJ2KSLopxJPYcSJepiP7VI0pB5sniQN6XUVV1C4jpkb/0eBJ8Cyp/uv64CdFmLDXo9hBQKYgKilDWSm8GSeSRS87skZk6hg7z5V1V4ZgeT+fGwYhRxmAWluXPyD1C+qUy3RmgA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=brakFrnKNMC9j4IFSknCbUCY2g1RemWkZGm8rewRdUM=; b=ZdAGfM7nVK5fPS8KGNjPSTPPbfeHOVV6uXyU5yn6AOnBhdRtvNqPB0JXhZktKUJIWXHhbp7WHlsoy5hr48Jr/B0CGiXMLIfbqbFMNqW7zGgNHauHSpncKzv4o0jV2WgPdhLZ/iZlbUaKcZIwELtjfqURPd56DSTxs3neMEEz6ZY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8357d9c9261fc323 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nY8DYQTFCyb3KF0OQNUSNeJ611n4utt+xJy3rRanE/R8QMLFYKpb0O92zFUtiMQvGz7v5T+8fRepNhIoCZmVm79GUfiCZdsKXE3mCmR1RnCeX3FuZTGF3WqmZSnK9GCxqgi9Q4S/NuHZ3fG0GQI9ovu+KaKYi3Mczc4Wokg3FjcMLWoQHLO8P4FC3zLDqbLCueBpX+jSHr+C0tU70WbLIvum+bq1JJo81p1jTbN+4iRcZYgpEAqB5Y9Wy/N4M0ZhBspDtS9zKuwEheZ5OFN3xmPlNWobYFYXhMb32YKgghHXwCgsTt3Jqwp9Qww0oyFUuBBzPESnb2n7gMw4GkRgkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=brakFrnKNMC9j4IFSknCbUCY2g1RemWkZGm8rewRdUM=; b=kcyEcThEJ3MYYT7RZxK4Ka5mTTWD7v9fUD+zhowLDgNr7nNWkSvFJTkZ0RhblHm3zW9Z/KWEUwP0e1VVVYE808C/f1dbVex96MJ+JNi2OYppTu+mkIChlX5fBAHF9oCRabawvd6RRJIkRLKKwZszFILxemUiQErj9sGqepwkfvmtjLLHzsaGmK/RMWgwF58Nut9bBPNkdMhMhHnOi7q1pzkgu0bJa1n6ffkhA6FMQsOptg+uPg5xsKylP2YAckzDZXyZBxop8mVqEkQD4ZjJul8mqm/fVElnCD4g4/P+yyJRMk8+oMiwtCKJsq+gsZfPJgyrO7qwCGfzjq4lBEOHmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=brakFrnKNMC9j4IFSknCbUCY2g1RemWkZGm8rewRdUM=; b=ZdAGfM7nVK5fPS8KGNjPSTPPbfeHOVV6uXyU5yn6AOnBhdRtvNqPB0JXhZktKUJIWXHhbp7WHlsoy5hr48Jr/B0CGiXMLIfbqbFMNqW7zGgNHauHSpncKzv4o0jV2WgPdhLZ/iZlbUaKcZIwELtjfqURPd56DSTxs3neMEEz6ZY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu , Jiamei Xie Subject: [PATCH v8 3/6] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid Date: Mon, 14 Nov 2022 14:34:48 +0800 Message-ID: <20221114063451.473711-4-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221114063451.473711-1-wei.chen@arm.com> References: <20221114063451.473711-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT037:EE_|AS8PR08MB9979:EE_|VI1EUR03FT024:EE_|DBBPR08MB5900:EE_ X-MS-Office365-Filtering-Correlation-Id: ad26973c-3d69-4d28-fabf-08dac60a654d x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eIFhIPK0bOwOdjipffFndQNmendCHrvKAUjSAI6ZIZyMtIJ/u5FYJnnC5AxiSfQQGKRwvM3E99gHVjRHmblS7O6RVJ5WK7AyhLs+jYp6YxXzn86YKtXTJfGQ5CfJuD/n8KtGz/zzovKvoZigq0l7IwJRYJo09UJ9Hn8cHzU5LUAJ9oNIh2DYYSMe/iovPEr8jeeX701uymwlWUrzt7Yu/hj89LqWVlvFaLnHEZSgdH5wdT3b547q+bftigh3VEtHg6yFvutrcifz4X0OrmmRp/qMHcuXKJ9Y8XV05RKf7GuazTc72+tqIJ9xwA9n6gmTvtHkb5DhggN1D32whu38gci27brdXwRtob0CK7WAqfxYJF3gEgTWGOzAn++Lnv1l0RDim5wsSUy3jCDsq0o+Jc1QMhVuHrx2Nwvie48sc1Bzfg45f17gKNnG4hayIvD5/+66svQb69x4CdZ+c25Y/iUID9LcxrrtONoEIHYM3FyH6NSOKGmfOXxiKeNNKztBAkGMAVN/Dpnb7jVZbK0zTqybB2UHcfy9daWoZU+HYE0tvANs3L+vxSF+JPFYLw0/emWQupHthrFjCXjPupph9NEl6zfVGWWAtryJcqW1Qeqk4yyzujbr7SYcBeP9OmQId45ZQbBXINqU257YvJXcZpsLvrCfH5PLW55BtXDo/FUcWhv3PUUzBMtWqQyAl0TbwAllxVsK48SLgghPqfa/RrDHUT6gqZ0U4SI4cHhzDvTIZgK9liNzX/xT/mWNdzVxvqZWarmWSM31hsoJM9cyYv7cKEFFU/yjadOODMmlN7eZKNo5aoXPM2iDCwW05Ghb X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(39860400002)(376002)(451199015)(40470700004)(46966006)(36840700001)(8936002)(54906003)(2906002)(316002)(44832011)(4326008)(6916009)(5660300002)(70206006)(70586007)(8676002)(36756003)(40460700003)(40480700001)(82310400005)(86362001)(36860700001)(47076005)(1076003)(2616005)(83380400001)(81166007)(186003)(356005)(426003)(82740400003)(336012)(26005)(41300700001)(478600001)(6666004)(7696005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9979 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7d13e506-fdb3-44f5-8523-08dac60a600d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lbodbcb2G15TOtRmXjnv5qMee54jl0uycfH2GWN3CerLx3Je/ZbUPJaNy75jcz6rZwbP50G3OFIJDkFzj5o4uF03z4vDHlAf/WOGFucm4YHlKCJkSaI5PeZc0LB/+UKpz2byU86gTsPCMNbWfr2TUGCI4jPuuYRT6aQnWmlS0yVmIG+FIyD16e9Zv0GzTs7oQv8J2iJrur15TSecOXsyWz6yW8JSopmu7cjIApPChQ/j/F8s8oAe8/uZB3PAYrGO13TTIJGFeD7oZchN67UBUYSi4tVu4LUpxij9syNP1508tLqYZZftVK8k2y/mHIlylgd4V1V+N6YTIaG6VSsGLvB1piGzjkd7ERnhipb1+rKwjiiE/bOHut6sRpp+pJUaSAgOcjhJuT+6RsEBE9pNCZ7aVwjXmFC/QRHnVYXSTBXoXLZykxwF3tstl+eVo65aQ7wpE7QWJl9S2YbTwKLCrkmTPURmka6qa2OhjsrOEFdPvlWsQFE0LxlmHmclYBw02P534U4BqxlKWMQ0gWmlkyrvxXd9mXGe4ig8ryHkgLRBp2drsEi5kULRElRkrQPdWARxjlnDzeoOzgJ249UsqzsJulbuGqP9+3Ez9SZ9PY8l4SAQgCAgCmgy+yoKYff6fZT2n15Xdek98mqYpy2sQN0bBfUtVzpbPkBbVo3Ts/J+4fFwEkRirigmPOSh7zkZ8SZzAizrMF0NJqG5XL3vCjshsbxf/B6JH1eTRGDrYW6R6VaS7kdONyO7rcTGZB4X2JYVVKztMBIiwEw2ejf6BA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(396003)(346002)(451199015)(40470700004)(36840700001)(46966006)(44832011)(8936002)(2906002)(82310400005)(5660300002)(36756003)(478600001)(8676002)(316002)(6916009)(54906003)(36860700001)(70586007)(70206006)(26005)(41300700001)(4326008)(7696005)(6666004)(40480700001)(86362001)(83380400001)(1076003)(2616005)(336012)(426003)(186003)(40460700003)(81166007)(47076005)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 06:35:17.6834 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad26973c-3d69-4d28-fabf-08dac60a654d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5900 VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This results in two lines of error-checking code in phys_to_nid that is not actually working and causing two compilation errors: 1. error: "MAX_NUMNODES" undeclared (first use in this function). This is because in the common header file, "MAX_NUMNODES" is defined after the common header file includes the ARCH header file, where phys_to_nid has attempted to use "MAX_NUMNODES". This error was resolved after we moved the phys_to_nid from x86 ARCH header file to common header file. 2. error: wrong type argument to unary exclamation mark. This is because, the error-checking code contains !node_data[nid]. But node_data is a data structure variable, it's not a pointer. So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to enable the two lines of error-checking code. And fix the left compilation errors by replacing !node_data[nid] to !node_data[nid].node_spanned_pages. Although NUMA allows one node can only have CPUs but without any memory. And node with 0 bytes of memory might have an entry in memnodemap[] theoretically. But that doesn't mean phys_to_nid can find any valid address from a node with 0 bytes memory. Signed-off-by: Wei Chen Tested-by: Jiamei Xie Acked-by: Jan Beulich --- v7 -> v8: 1. No change. v6 -> v7: 1. No change. v5 -> v6: 1. No change. v4 -> v5: 1. No change. v3 -> v4: 1. No change. v2 -> v3: 1. Remove unnecessary change items in history. 2. Add Acked-by. v1 -> v2: 1. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. 2. Adjust the conditional express for ASSERT. 3. Refine the justification of using !node_data[nid].node_spanned_pages. --- xen/include/xen/numa.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 5b3877344b..04556f3a6f 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -35,8 +35,6 @@ struct node { extern int compute_hash_shift(const struct node *nodes, unsigned int numnodes, const nodeid_t *nodeids); -#define VIRTUAL_BUG_ON(x) - extern bool numa_off; extern void numa_add_cpu(unsigned int cpu); @@ -69,9 +67,9 @@ extern struct node_data node_data[]; static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) { nodeid_t nid; - VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); + ASSERT((paddr_to_pdx(addr) >> memnode_shift) < memnodemapsize); nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; - VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); + ASSERT(nid < MAX_NUMNODES && node_data[nid].node_spanned_pages); return nid; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 06:35:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 06:35:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443091.697534 (Exim 4.92) (envelope-from ) id 1ouT40-0001aI-EV; Mon, 14 Nov 2022 06:35:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443091.697534; Mon, 14 Nov 2022 06:35:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT40-0001a9-BC; Mon, 14 Nov 2022 06:35:24 +0000 Received: by outflank-mailman (input) for mailman id 443091; Mon, 14 Nov 2022 06:35:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT3y-0000jp-Mh for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 06:35:23 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20068.outbound.protection.outlook.com [40.107.2.68]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 826c55e2-63e6-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 07:35:20 +0100 (CET) Received: from FR0P281CA0147.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::11) by VI1PR08MB5487.eurprd08.prod.outlook.com (2603:10a6:803:13c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 06:35:15 +0000 Received: from VI1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:96:cafe::b1) by FR0P281CA0147.outlook.office365.com (2603:10a6:d10:96::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 06:35:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT064.mail.protection.outlook.com (100.127.144.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:14 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Mon, 14 Nov 2022 06:35:14 +0000 Received: from ddba82e70f16.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id ECC065DD-007C-46B8-A4A2-F67D14D8688E.1; Mon, 14 Nov 2022 06:35:07 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ddba82e70f16.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 06:35:07 +0000 Received: from FR3P281CA0196.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::14) by PAVPR08MB9747.eurprd08.prod.outlook.com (2603:10a6:102:31e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 06:35:04 +0000 Received: from VI1EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a5:cafe::73) by FR3P281CA0196.outlook.office365.com (2603:10a6:d10:a5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 06:35:04 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT031.mail.protection.outlook.com (100.127.144.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:04 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 14 Nov 2022 06:35:02 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Mon, 14 Nov 2022 06:34:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 826c55e2-63e6-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aSr2WwyXgvdqymjr+8KCBsRS4I0s7K/AlKWcrKVu0+dPeoUU/nNVWkKW5XAuwnBEDAo+60M1AIIrcuowWSn8uqrVKBNnCWgJAio1vQqTy8RbTlKkSsweQWt7MSPiTUW1NkiEdwo+K77gqktGmtPGpCEJESKiquDVsocHs3QWv4s65Yw2MMfZMjmPzokV48inthdl/ydmkD/fUsjMEuzk93L6fqB2AmLhkmZywW6sOcZ/Gf4fYCG+SBNvl73UBJVMYZsykfzTKY5ZRsXLn61EU7E3sEeO2xQh9NbMM04vR9QtxZO7gFN2yyiJugAh6IbOSdY7goQk8tyAhl7bA08mkQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dV/9iohMe315GxBzR5bLvszpzJI9gfUdIVf7JFndT0E=; b=Jrcjs/djKThvjg/MAkgO+LiqCixqYIDPZikd1F9TI32R7MdWwttgmlfATxnm4TLTlxtSvsisN2v69J/InZITRhOAdSv6Ygc+ylJf6bPu5WTtQoaZ0dCDb0KzWqWfbPcoO4cfZVfFIjkDScF3b9jYpecXrTWBFfZ+KbR6RMeWqNkcseBULLrqg8lapJwpIKTURHMGq92kRF6d1t+bW042HExwN586qaBQpa6ghJXMtqB/gDDteLEZ8swvxebcI3hADg0Q3r4JyI+Zj3kPR+u1u0ePJkxVSdWcvVezcEnaipPrl4Qu+Md73seq40+X4uChnJtQ3Y3w5upocMJC4yoj4Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dV/9iohMe315GxBzR5bLvszpzJI9gfUdIVf7JFndT0E=; b=F/r8EZG18cfu3hROJLI2BMKqik7O3ucnjhRaN0Ldodzxl+A8KwaMMuQ6clZ3h5xvtEJEmkAKvo+PDxUgJkUqJTI8xKwpVIOny6IegMvvNXZfMu/ZZBkRWcgzckanKUGjMlCJ/ug1p5ZXE5OOBtPFEpe+pEzFOZzVWFfMznEu/kc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 50a5bfcc4f076e57 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XEcHff4xlEAB89ds9H0SfbPw/BPP2NWBgpuLsae4eTWD5SxGgU7IX+P8VFHIQ40o9pK2lXYu3jHmlG2v3XaBTD0UN0cicMYgRM5EgWIRsjwuRcv9fOZYygTfDVFxjXqSdhduUGoMRVybA9Ych+tJk8kafw99NUrX2MK9VD8BzVwVR/cnuw/im4iuvQf4WfiVjaYDqV7uvJ+nCYuSEzgN8ecKlyeiUbNHNJngiNNChRe0lPZHTf6CXt+imwSDTG67JzZza/ZokuRpyUkx1Wew6ANohwvWbYmnIUl+ofFD6lkBrZkBNFR22X0pVODsxtrbz/akvuf1q+LCPSGD43PgNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dV/9iohMe315GxBzR5bLvszpzJI9gfUdIVf7JFndT0E=; b=KC03kdPxAVcLXQ141gOlLErpx23CWD/A2++tAgWCwVNwMG8BfVN7H3KGhyzH5nYNgeCu7yyvHHEr5UcxuxFhgBXDFcItMZFElQpIRIcIGJKwdFxXSTBfaH/Mf1AnAtgXtPYYL4bdIaW1oTsQk88UwpSNsRPnTGIkLO6lso/Sh2MiGpbOB0KfVQxde85Ntd3Ep5bPNfprHk/uokUXAL1HkaBPrn665qftlei9bu2EaqHPARuP5kTIUNVpz3b/uRLmisKqnjebGJTIqmdezYcLSulj1vWdrqxOI+srt+2HHvlysZm8XrOZ3i9dB3B/6+DMFpYrV9e1CSJGdcbPFiB/ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dV/9iohMe315GxBzR5bLvszpzJI9gfUdIVf7JFndT0E=; b=F/r8EZG18cfu3hROJLI2BMKqik7O3ucnjhRaN0Ldodzxl+A8KwaMMuQ6clZ3h5xvtEJEmkAKvo+PDxUgJkUqJTI8xKwpVIOny6IegMvvNXZfMu/ZZBkRWcgzckanKUGjMlCJ/ug1p5ZXE5OOBtPFEpe+pEzFOZzVWFfMznEu/kc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v8 2/6] xen/x86: move generically usable NUMA code from x86 to common Date: Mon, 14 Nov 2022 14:34:47 +0800 Message-ID: <20221114063451.473711-3-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221114063451.473711-1-wei.chen@arm.com> References: <20221114063451.473711-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT031:EE_|PAVPR08MB9747:EE_|VI1EUR03FT064:EE_|VI1PR08MB5487:EE_ X-MS-Office365-Filtering-Correlation-Id: 785a1c6d-290d-4421-20db-08dac60a63a7 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WRtDnTmKBjzzSXAdMwsmhEUaDm2/xmQIojefdCvORU61Zv2qTuVag3IPE9/iugE0ZxdNH/fsaOQr9CEiGcHRuUCldSxHZCKGaxL4yUZ6YaRr1ZwTduXK1l/7Ht9b7AUUoNED3emrGobDw2WvlushkywjKlRrirxb+E2Mpb/2gBj0RxXfnF0AeRWaRqxd2FB/mr8+FPOmarwH1GzWDgOJkXSKNJyMzHUoYUNro3yRa1VVF+6+509g+X5YKl299Uo0pLZp3a6z1P2HlcV65ApQJPkX7i9pbr0ojPgKKkXGj88a5dLBsMsaHEGlacuxOzlGu7bKZbziCzQY3MpiAONGFKUTYS3SwW4qJbpuVs0DZOvH3cvNuPaj++yEUBcl0W+CxAdU5ZsTAZndIZK1PXx/IMoBezNT5VTNL39xEY8Wtq/TRh6TCZghiJ6BRQ9JxxX5ec+1/CC6VtGal2TLt9uBwXtyNhTCYZ1byEa6AF4+5u+PpD9Hr8Q8a0XFIIfqmNjm3kq8mDIYmKzc9ewydhU33/YSv4rFBMlJh2HxWGjEUmB0tYItSFfiop2qnWKFIhkKngbO5nVucAyP6cujxaUeVgb+iPcmBPndBhSjYyoyT4maKrbKE8nOuuQWLzpLA7UZ3wf3xsq9UmvwMACwx3W5YRP9rpc/GHHjyuVBkF3JoTSUdqNlxZTl6I9moqnGX2umDDHnaeLftwHlxE2/QN6ZHkSyuhZ9/KfLLSZ664/F9Ef38E+E5Q0sIlKoKwwvbcEOomMUCe8X+KRuodIojrJ5Hzz7UByqMsZta+MAD9SLgAQO8upEMHE3FhApBa/V2ObwZG2uzX80jFps6waWkq6vyQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(376002)(346002)(451199015)(46966006)(40470700004)(36840700001)(83380400001)(2616005)(336012)(186003)(47076005)(426003)(82740400003)(1076003)(356005)(81166007)(36860700001)(2906002)(8936002)(44832011)(30864003)(40460700003)(40480700001)(82310400005)(478600001)(26005)(6666004)(7696005)(8676002)(41300700001)(70586007)(70206006)(5660300002)(4326008)(6916009)(316002)(54906003)(36756003)(86362001)(21314003)(36900700001)(579004);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9747 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4b400869-836f-4a0e-84da-08dac60a5d3b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vW42Vb6r6g4BQmALwPbxRA9rSqluZIW8mySQumca7yVcreOJjdRYI1J2GPhdY7nwuK3Wq8xufhMcuGfjYCHlqVqFmSB6oIutP0t0/Eadhzc1iblcm0waFggfAVaCwcyS4sxtcsXLeIxm3nJ7NWeRghKHUAXaQ7JZrI2TxCizlPUZckdBt5QJgP/+3atwBxkNbBysZw07c6/goHyX21H8zzmKhV65NzaLf6cGdjXjc/wt+B0PT5SflUKuy9TcHpsW8oYQJ/myT2QXDK93ET5U9G1aNkEV1lbaYt6gO2lNURixopt4H91Oi8Ll/+aKiaykzkjUAh2hwckLyChs7YuihopnP/StN0ZjV7rSY7rWjXeLfT0S9CsLfmSRVG7qeP6YylVr37kkcuYcMygcUMLrE1SYaszd1uPM2xhoZ3Nv93IhJDX0t0jb44q0WMsZNClszELalM1T77MNZMXE7Ca/L3lOyYrg0uujrpVhYqSzGH/QwAkn+2d70r1xEfUyQdVqZ3jD44xzNQfTUHYSd/NULUSpZ2wcEAlGu03SmLzOo6dZRsmWrm+uNEccKvzf5+rTNf3qN5ZNmRgC4P7icqkaw35rAZW2Hgjjk6obwWjuzG87S3W6iDw3yaoJ8gyFaOOgNobaqpaGNRon0ez5b4Sj3G2UOgG9etYgaIKhtf11YrSvne2rNMcod8Y6A1F54SH+5phBXPde1q1Z81NACRucEOjeGUCX2VZgddy8vsoJ1JGLQ5IvgSd0ha9ynrzIEf4NR3SuYHEx4RbcEfenG+PnUQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39850400004)(396003)(451199015)(36840700001)(46966006)(40480700001)(82310400005)(36756003)(107886003)(336012)(186003)(6916009)(426003)(316002)(54906003)(30864003)(1076003)(47076005)(478600001)(36860700001)(26005)(7696005)(6666004)(2906002)(41300700001)(86362001)(70586007)(81166007)(8676002)(82740400003)(4326008)(70206006)(2616005)(83380400001)(44832011)(8936002)(5660300002)(21314003)(579004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 06:35:14.8810 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 785a1c6d-290d-4421-20db-08dac60a63a7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5487 There are some codes in x86/numa.c can be shared by common architectures to implememnt NUMA support. Just like some variables and functions to check and store NUMA memory map. And some variables and functions to do NUMA initialization. In this patch, we move them to common/numa.c and xen/numa.h and use the CONFIG_NUMA to gate them for non-NUMA supported architectures. As the target header file is Xen-style, so we trim some spaces and replace tabs for the codes that has been moved to xen/numa.h at the same time. As acpi_scan_nodes has been used in a common function, it doesn't make sense to use acpi_xxx in common code, so we rename it to numa_process_nodes in this patch too. After that if we still use CONFIG_ACPI_NUMA in to gate numa_process_nodes in numa_initmem_init, that doesn't make sense. As CONFIG_NUMA will be selected by CONFIG_ACPI_NUMA for x86. So, we replace CONFIG_ACPI_NUMA by CONFIG_NUMA to gate numa_process_nodes. As arch_numa_disabled has been implememnted for ACPI NUMA, we can rename srat_disabled to numa_disabled and move it to common code as well. The macro node_to_first_cpu(node) hasn't been used anywhere, so we drop it in this patch too. Because some architectures allow to use all 64 physical address bits, but some architectures are not (like Arm64 allows 52, 48 bits). In this case, we use min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift when only one node is in the system in this patch too. Signed-off-by: Wei Chen Reviewed-by: Jan Beulich --- v7 -> v8: 1. Add Rb. 2. Change "of shift too small" to "or shift too small". v6 -> v7: 1. Restore %d for nodeid_t in dump_numa. 2. Use sizeof(page_num_node) for page_num_node size in memset. 3. Add description for using min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift when only one node is in the system. 4. Use %pd for domain print. v5 -> v6: 1. Replace numa_scan_node to numa_process_nodes in commit log. 2. Limit the scope of page_num_node, vnuma and page of numa_setup function. 3. Use memset to init page_num_node instead of for_each_online_node. 4. Use %u instead of %d for nodeid_t and j in numa_setup print messages. 5. Use min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift when only one node is in the system. 6. Drop the marco: node_to_first_cpu(node) v4 -> v5: 1. Use nodeid_t instead of uint8_t for memnodemap. 2. Restore to use typeof(*memnodemap) for _memnodemap, this will avoid the further adjustments for _memnodemap's type. 3. Use __ro_after_init for numa_off. 4. Use pointer-to-const for proper function parameters. 5. Use unsigned int for variables that are not realy used for node ID. 6. Fix code comments code-style and adjust the length. 7. Fix code-styles. 8. Rename numa_scan_nodes to numa_process_nodes. 9. Use a plain "int ret" to record compute_hash_shift return value. v3 -> v4: 1. Restore compute_hash_shift's return value to int. 2. Remove unnecessary parentheses for macros. 3. Use unsigned int for proper variables. 4. Fix some code-style. v2 -> v3: 1. Remove acpi.h from common/numa.c. 2. Rename acpi_scan_nodes to numa_scan_nodes. 3. Replace u8 by uint8_t for memnodemap. 4. Use unsigned int for memnode_shift and adjust related functions (compute_hash_shift, populate_memnodemap) to use correct types for return values or parameters. 5. Use nodeid_t for nodeid and node numbers. 6. Use __read_mostly and __ro_after_init for appropriate variables. 7. Adjust the __read_mostly and __initdata location for some variables. 8. convert from plain int to unsigned for cpuid and other proper variables. 9. Use __attribute_pure__ instead of __attribute__((pure)). 10. Replace CONFIG_ACPI_NUMA by CONFIG_NUMA in numa_initmem_init. 11. Add const for some functions' parameters. 12. Move srat_disabled to common code with new name numa_disabled. 13. Fix some spaces code-style for numa_emulation. 14. Change from int to unsigned int for numa_fake. v1 -> v2: 1. New patch in v2. --- xen/arch/x86/include/asm/acpi.h | 1 - xen/arch/x86/include/asm/numa.h | 57 +--- xen/arch/x86/include/asm/setup.h | 1 - xen/arch/x86/numa.c | 433 +--------------------------- xen/arch/x86/smpboot.c | 2 +- xen/arch/x86/srat.c | 10 +- xen/common/Makefile | 1 + xen/common/numa.c | 464 +++++++++++++++++++++++++++++++ xen/include/xen/numa.h | 66 +++++ 9 files changed, 539 insertions(+), 496 deletions(-) create mode 100644 xen/common/numa.c diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h index 9a9cc4c240..5c2dd5da2d 100644 --- a/xen/arch/x86/include/asm/acpi.h +++ b/xen/arch/x86/include/asm/acpi.h @@ -102,7 +102,6 @@ extern unsigned long acpi_wakeup_address; #define ARCH_HAS_POWER_INIT 1 extern s8 acpi_numa; -extern int acpi_scan_nodes(u64 start, u64 end); #define NR_NODE_MEMBLKS (MAX_NUMNODES*2) extern struct acpi_sleep_info acpi_sinfo; diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 237f2c6dbf..6c87942d43 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -9,72 +9,17 @@ typedef u8 nodeid_t; extern int srat_rev; -extern nodeid_t cpu_to_node[NR_CPUS]; -extern cpumask_t node_to_cpumask[]; - -#define cpu_to_node(cpu) (cpu_to_node[cpu]) -#define parent_node(node) (node) -#define node_to_first_cpu(node) (__ffs(node_to_cpumask[node])) -#define node_to_cpumask(node) (node_to_cpumask[node]) - -struct node { - paddr_t start, end; -}; - -extern int compute_hash_shift(struct node *nodes, int numnodes, - nodeid_t *nodeids); extern nodeid_t pxm_to_node(unsigned int pxm); #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) -#define VIRTUAL_BUG_ON(x) -extern void numa_add_cpu(int cpu); -extern void numa_init_array(void); -extern bool numa_off; - -extern int arch_numa_setup(const char *opt); -extern bool arch_numa_disabled(void); -extern bool srat_disabled(void); -extern void numa_set_node(int cpu, nodeid_t node); +extern bool numa_disabled(void); extern nodeid_t setup_node(unsigned int pxm); extern void srat_detect_node(int cpu); -extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); extern nodeid_t apicid_to_node[]; extern void init_cpu_to_node(void); -static inline void clear_node_cpumask(int cpu) -{ - cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); -} - -/* Simple perfect hash to map pdx to node numbers */ -extern int memnode_shift; -extern unsigned long memnodemapsize; -extern u8 *memnodemap; - -struct node_data { - unsigned long node_start_pfn; - unsigned long node_spanned_pages; -}; - -extern struct node_data node_data[]; - -static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) -{ - nodeid_t nid; - VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); - nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; - VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); - return nid; -} - -#define NODE_DATA(nid) (&(node_data[nid])) - -#define node_start_pfn(nid) (NODE_DATA(nid)->node_start_pfn) -#define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages) -#define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ - NODE_DATA(nid)->node_spanned_pages) #define arch_want_default_dmazone() (num_online_nodes() > 1) extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 21037b7f31..ae470ea12f 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -20,7 +20,6 @@ void early_time_init(void); void set_nr_cpu_ids(unsigned int max_cpus); -void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); void arch_init_memory(void); void subarch_init_memory(void); diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 1c3198445d..90b2a22591 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -4,20 +4,11 @@ * Adapted for Xen: Ryan Harper */ -#include -#include #include -#include +#include #include #include -#include -#include -#include -#include -#include #include -#include -#include #ifndef Dprintk #define Dprintk(x...) @@ -26,28 +17,13 @@ /* from proto.h */ #define round_up(x,y) ((((x)+(y))-1) & (~((y)-1))) -struct node_data node_data[MAX_NUMNODES]; - -/* Mapping from pdx to node id */ -int memnode_shift; -static typeof(*memnodemap) _memnodemap[64]; -unsigned long memnodemapsize; -u8 *memnodemap; - -nodeid_t cpu_to_node[NR_CPUS] __read_mostly = { - [0 ... NR_CPUS-1] = NUMA_NO_NODE -}; /* * Keep BIOS's CPU2node information, should not be used for memory allocaion */ nodeid_t apicid_to_node[MAX_LOCAL_APIC] = { [0 ... MAX_LOCAL_APIC-1] = NUMA_NO_NODE }; -cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly; -nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; - -bool numa_off; s8 acpi_numa = 0; int __init arch_numa_setup(const char *opt) @@ -69,270 +45,6 @@ bool arch_numa_disabled(void) return acpi_numa < 0; } -bool srat_disabled(void) -{ - return numa_off || arch_numa_disabled(); -} - -/* - * Given a shift value, try to populate memnodemap[] - * Returns : - * 1 if OK - * 0 if memnodmap[] too small (of shift too small) - * -1 if node overlap or lost ram (shift too big) - */ -static int __init populate_memnodemap(const struct node *nodes, - int numnodes, int shift, nodeid_t *nodeids) -{ - int i, res = -1; - - memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap)); - for ( i = 0; i < numnodes; i++ ) - { - unsigned long spdx = paddr_to_pdx(nodes[i].start); - unsigned long epdx = paddr_to_pdx(nodes[i].end - 1); - - if ( spdx > epdx ) - continue; - if ( (epdx >> shift) >= memnodemapsize ) - return 0; - do { - if ( memnodemap[spdx >> shift] != NUMA_NO_NODE && - (!nodeids || memnodemap[spdx >> shift] != nodeids[i]) ) - return -1; - - if ( !nodeids ) - memnodemap[spdx >> shift] = i; - else - memnodemap[spdx >> shift] = nodeids[i]; - - spdx += (1UL << shift); - } while ( spdx <= epdx ); - res = 1; - } - - return res; -} - -static int __init allocate_cachealigned_memnodemap(void) -{ - unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap)); - unsigned long mfn = mfn_x(alloc_boot_pages(size, 1)); - - memnodemap = mfn_to_virt(mfn); - mfn <<= PAGE_SHIFT; - size <<= PAGE_SHIFT; - printk(KERN_DEBUG "NUMA: Allocated memnodemap from %lx - %lx\n", - mfn, mfn + size); - memnodemapsize = size / sizeof(*memnodemap); - - return 0; -} - -/* - * The LSB of all start addresses in the node map is the value of the - * maximum possible shift. - */ -static int __init extract_lsb_from_nodes(const struct node *nodes, - int numnodes, const nodeid_t *nodeids) -{ - int i, nodes_used = 0; - unsigned long spdx, epdx; - unsigned long bitfield = 0, memtop = 0; - - for ( i = 0; i < numnodes; i++ ) - { - spdx = paddr_to_pdx(nodes[i].start); - epdx = paddr_to_pdx(nodes[i].end - 1) + 1; - if ( spdx >= epdx ) - continue; - if ( i && (!nodeids || nodeids[i - 1] != nodeids[i]) ) - bitfield |= spdx; - if ( !i || !nodeids || nodeids[i - 1] != nodeids[i] ) - nodes_used++; - if ( epdx > memtop ) - memtop = epdx; - } - if ( nodes_used <= 1 ) - i = BITS_PER_LONG - 1; - else - i = find_first_bit(&bitfield, sizeof(unsigned long)*8); - memnodemapsize = ((memtop - 1) >> i) + 1; - return i; -} - -int __init compute_hash_shift(struct node *nodes, int numnodes, - nodeid_t *nodeids) -{ - int shift; - - shift = extract_lsb_from_nodes(nodes, numnodes, nodeids); - if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) ) - memnodemap = _memnodemap; - else if ( allocate_cachealigned_memnodemap() ) - return -1; - printk(KERN_DEBUG "NUMA: Using %d for the hash shift.\n", shift); - - if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 ) - { - printk(KERN_INFO "Your memory is not aligned you need to " - "rebuild your hypervisor with a bigger NODEMAPSIZE " - "shift=%d\n", shift); - return -1; - } - - return shift; -} -/* initialize NODE_DATA given nodeid and start/end */ -void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end) -{ - unsigned long start_pfn = paddr_to_pfn(start); - unsigned long end_pfn = paddr_to_pfn(end); - - NODE_DATA(nodeid)->node_start_pfn = start_pfn; - NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn; - - node_set_online(nodeid); -} - -void __init numa_init_array(void) -{ - int rr, i; - - /* There are unfortunately some poorly designed mainboards around - that only connect memory to a single CPU. This breaks the 1:1 cpu->node - mapping. To avoid this fill in the mapping for all possible - CPUs, as the number of CPUs is not known yet. - We round robin the existing nodes. */ - rr = first_node(node_online_map); - for ( i = 0; i < nr_cpu_ids; i++ ) - { - if ( cpu_to_node[i] != NUMA_NO_NODE ) - continue; - numa_set_node(i, rr); - rr = cycle_node(rr, node_online_map); - } -} - -#ifdef CONFIG_NUMA_EMU -static int numa_fake __initdata = 0; - -/* Numa emulation */ -static int __init numa_emulation(unsigned long start_pfn, - unsigned long end_pfn) -{ - int i; - struct node nodes[MAX_NUMNODES]; - uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake; - - /* Kludge needed for the hash function */ - if ( hweight64(sz) > 1 ) - { - u64 x = 1; - while ( (x << 1) < sz ) - x <<= 1; - if ( x < sz/2 ) - printk(KERN_ERR "Numa emulation unbalanced. Complain to maintainer\n"); - sz = x; - } - - memset(&nodes,0,sizeof(nodes)); - for ( i = 0; i < numa_fake; i++ ) - { - nodes[i].start = pfn_to_paddr(start_pfn) + i * sz; - if ( i == numa_fake - 1 ) - sz = pfn_to_paddr(end_pfn) - nodes[i].start; - nodes[i].end = nodes[i].start + sz; - printk(KERN_INFO "Faking node %d at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n", - i, - nodes[i].start, nodes[i].end, - (nodes[i].end - nodes[i].start) >> 20); - node_set_online(i); - } - memnode_shift = compute_hash_shift(nodes, numa_fake, NULL); - if ( memnode_shift < 0 ) - { - memnode_shift = 0; - printk(KERN_ERR "No NUMA hash function found. Emulation disabled.\n"); - return -1; - } - for_each_online_node ( i ) - setup_node_bootmem(i, nodes[i].start, nodes[i].end); - numa_init_array(); - - return 0; -} -#endif - -void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) -{ - int i; - paddr_t start = pfn_to_paddr(start_pfn); - paddr_t end = pfn_to_paddr(end_pfn); - -#ifdef CONFIG_NUMA_EMU - if ( numa_fake && !numa_emulation(start_pfn, end_pfn) ) - return; -#endif - -#ifdef CONFIG_ACPI_NUMA - if ( !numa_off && !acpi_scan_nodes(start, end) ) - return; -#endif - - printk(KERN_INFO "%s\n", - numa_off ? "NUMA turned off" : "No NUMA configuration found"); - - printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n", - start, end); - /* setup dummy node covering all memory */ - memnode_shift = BITS_PER_LONG - 1; - memnodemap = _memnodemap; - /* Dummy node only uses 1 slot in reality */ - memnodemap[0] = 0; - memnodemapsize = 1; - - nodes_clear(node_online_map); - node_set_online(0); - for ( i = 0; i < nr_cpu_ids; i++ ) - numa_set_node(i, 0); - cpumask_copy(&node_to_cpumask[0], cpumask_of(0)); - setup_node_bootmem(0, start, end); -} - -void numa_add_cpu(int cpu) -{ - cpumask_set_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); -} - -void numa_set_node(int cpu, nodeid_t node) -{ - cpu_to_node[cpu] = node; -} - -/* [numa=off] */ -static int __init cf_check numa_setup(const char *opt) -{ - if ( !strncmp(opt, "off", 3) ) - numa_off = true; - else if ( !strncmp(opt, "on", 2) ) - numa_off = false; -#ifdef CONFIG_NUMA_EMU - else if ( !strncmp(opt, "fake=", 5) ) - { - numa_off = false; - numa_fake = simple_strtoul(opt + 5, NULL, 0); - if ( numa_fake >= MAX_NUMNODES ) - numa_fake = MAX_NUMNODES; - } -#endif - else - return arch_numa_setup(opt); - - return 0; -} -custom_param("numa", numa_setup); - /* * Setup early cpu_to_node. * @@ -381,146 +93,3 @@ unsigned int __init arch_get_dma_bitsize(void) flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1) + PAGE_SHIFT, 32); } - -static void cf_check dump_numa(unsigned char key) -{ - s_time_t now = NOW(); - unsigned int i, j, n; - struct domain *d; - struct page_info *page; - unsigned int page_num_node[MAX_NUMNODES]; - const struct vnuma_info *vnuma; - - printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, - now); - - for_each_online_node ( i ) - { - paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); - - printk("NODE%u start->%lu size->%lu free->%lu\n", - i, node_start_pfn(i), node_spanned_pages(i), - avail_node_heap_pages(i)); - /* sanity check phys_to_nid() */ - if ( phys_to_nid(pa) != i ) - printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n", - pa, phys_to_nid(pa), i); - } - - j = cpumask_first(&cpu_online_map); - n = 0; - for_each_online_cpu ( i ) - { - if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] ) - { - if ( n > 1 ) - printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); - else - printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); - j = i; - n = 1; - } - else - ++n; - } - if ( n > 1 ) - printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); - else - printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); - - rcu_read_lock(&domlist_read_lock); - - printk("Memory location of each domain:\n"); - for_each_domain ( d ) - { - process_pending_softirqs(); - - printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d)); - - for_each_online_node ( i ) - page_num_node[i] = 0; - - spin_lock(&d->page_alloc_lock); - page_list_for_each(page, &d->page_list) - { - i = phys_to_nid(page_to_maddr(page)); - page_num_node[i]++; - } - spin_unlock(&d->page_alloc_lock); - - for_each_online_node ( i ) - printk(" Node %u: %u\n", i, page_num_node[i]); - - if ( !read_trylock(&d->vnuma_rwlock) ) - continue; - - if ( !d->vnuma ) - { - read_unlock(&d->vnuma_rwlock); - continue; - } - - vnuma = d->vnuma; - printk(" %u vnodes, %u vcpus, guest physical layout:\n", - vnuma->nr_vnodes, d->max_vcpus); - for ( i = 0; i < vnuma->nr_vnodes; i++ ) - { - unsigned int start_cpu = ~0U; - - if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE ) - printk(" %3u: pnode ???,", i); - else - printk(" %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]); - - printk(" vcpus "); - - for ( j = 0; j < d->max_vcpus; j++ ) - { - if ( !(j & 0x3f) ) - process_pending_softirqs(); - - if ( vnuma->vcpu_to_vnode[j] == i ) - { - if ( start_cpu == ~0U ) - { - printk("%d", j); - start_cpu = j; - } - } - else if ( start_cpu != ~0U ) - { - if ( j - 1 != start_cpu ) - printk("-%d ", j - 1); - else - printk(" "); - start_cpu = ~0U; - } - } - - if ( start_cpu != ~0U && start_cpu != j - 1 ) - printk("-%d", j - 1); - - printk("\n"); - - for ( j = 0; j < vnuma->nr_vmemranges; j++ ) - { - if ( vnuma->vmemrange[j].nid == i ) - printk(" %016"PRIx64" - %016"PRIx64"\n", - vnuma->vmemrange[j].start, - vnuma->vmemrange[j].end); - } - } - - read_unlock(&d->vnuma_rwlock); - } - - rcu_read_unlock(&domlist_read_lock); -} - -static int __init cf_check register_numa_trigger(void) -{ - register_keyhandler('u', dump_numa, "dump NUMA info", 1); - return 0; -} -__initcall(register_numa_trigger); - diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index b46fd9ab18..9df08e9366 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -1350,7 +1350,7 @@ int cpu_add(uint32_t apic_id, uint32_t acpi_id, uint32_t pxm) x86_acpiid_to_apicid[acpi_id] = apic_id; - if ( !srat_disabled() ) + if ( !numa_disabled() ) { nodeid_t node = setup_node(pxm); diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index fbcd8749c4..ce507dac9e 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -238,7 +238,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) unsigned pxm; nodeid_t node; - if (srat_disabled()) + if (numa_disabled()) return; if (pa->header.length < sizeof(struct acpi_srat_x2apic_cpu_affinity)) { bad_srat(); @@ -274,7 +274,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) unsigned pxm; nodeid_t node; - if (srat_disabled()) + if (numa_disabled()) return; if (pa->header.length != sizeof(struct acpi_srat_cpu_affinity)) { bad_srat(); @@ -314,7 +314,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) unsigned int i; bool next = false; - if (srat_disabled()) + if (numa_disabled()) return; if (ma->header.length != sizeof(struct acpi_srat_mem_affinity)) { bad_srat(); @@ -543,8 +543,8 @@ void __init srat_parse_regions(paddr_t addr) pfn_pdx_hole_setup(mask >> PAGE_SHIFT); } -/* Use the information discovered above to actually set up the nodes. */ -int __init acpi_scan_nodes(paddr_t start, paddr_t end) +/* Use discovered information to actually set up the nodes. */ +int __init numa_process_nodes(paddr_t start, paddr_t end) { int i; nodemask_t all_nodes_parsed; diff --git a/xen/common/Makefile b/xen/common/Makefile index 3baf83d527..9a3a12b12d 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -26,6 +26,7 @@ obj-$(CONFIG_MEM_ACCESS) += mem_access.o obj-y += memory.o obj-y += multicall.o obj-y += notifier.o +obj-$(CONFIG_NUMA) += numa.o obj-y += page_alloc.o obj-$(CONFIG_HAS_PDX) += pdx.o obj-$(CONFIG_PERF_COUNTERS) += perfc.o diff --git a/xen/common/numa.c b/xen/common/numa.c new file mode 100644 index 0000000000..a135154c3e --- /dev/null +++ b/xen/common/numa.c @@ -0,0 +1,464 @@ +/* + * Generic VM initialization for NUMA setups. + * Copyright 2002,2003 Andi Kleen, SuSE Labs. + * Adapted for Xen: Ryan Harper + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +struct node_data __ro_after_init node_data[MAX_NUMNODES]; + +/* Mapping from pdx to node id */ +unsigned int __ro_after_init memnode_shift; +unsigned long __ro_after_init memnodemapsize; +nodeid_t *__ro_after_init memnodemap; +static typeof(*memnodemap) __ro_after_init _memnodemap[64]; + +nodeid_t __read_mostly cpu_to_node[NR_CPUS] = { + [0 ... NR_CPUS-1] = NUMA_NO_NODE +}; + +cpumask_t __read_mostly node_to_cpumask[MAX_NUMNODES]; + +nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; + +bool __ro_after_init numa_off; + +bool numa_disabled(void) +{ + return numa_off || arch_numa_disabled(); +} + +/* + * Given a shift value, try to populate memnodemap[] + * Returns : + * 1 if OK + * 0 if memnodmap[] too small (or shift too small) + * -1 if node overlap or lost ram (shift too big) + */ +static int __init populate_memnodemap(const struct node *nodes, + unsigned int numnodes, unsigned int shift, + const nodeid_t *nodeids) +{ + unsigned int i; + int res = -1; + + memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap)); + + for ( i = 0; i < numnodes; i++ ) + { + unsigned long spdx = paddr_to_pdx(nodes[i].start); + unsigned long epdx = paddr_to_pdx(nodes[i].end - 1); + + if ( spdx > epdx ) + continue; + + if ( (epdx >> shift) >= memnodemapsize ) + return 0; + + do { + if ( memnodemap[spdx >> shift] != NUMA_NO_NODE && + (!nodeids || memnodemap[spdx >> shift] != nodeids[i]) ) + return -1; + + if ( !nodeids ) + memnodemap[spdx >> shift] = i; + else + memnodemap[spdx >> shift] = nodeids[i]; + + spdx += (1UL << shift); + } while ( spdx <= epdx ); + + res = 1; + } + + return res; +} + +static int __init allocate_cachealigned_memnodemap(void) +{ + unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap)); + unsigned long mfn = mfn_x(alloc_boot_pages(size, 1)); + + memnodemap = mfn_to_virt(mfn); + mfn <<= PAGE_SHIFT; + size <<= PAGE_SHIFT; + printk(KERN_DEBUG "NUMA: Allocated memnodemap from %lx - %lx\n", + mfn, mfn + size); + memnodemapsize = size / sizeof(*memnodemap); + + return 0; +} + +/* + * The LSB of all start addresses in the node map is the value of the + * maximum possible shift. + */ +static unsigned int __init extract_lsb_from_nodes(const struct node *nodes, + nodeid_t numnodes, + const nodeid_t *nodeids) +{ + unsigned int i, nodes_used = 0; + unsigned long bitfield = 0, memtop = 0; + + for ( i = 0; i < numnodes; i++ ) + { + unsigned long spdx = paddr_to_pdx(nodes[i].start); + unsigned long epdx = paddr_to_pdx(nodes[i].end - 1) + 1; + + if ( spdx >= epdx ) + continue; + + if ( i && (!nodeids || nodeids[i - 1] != nodeids[i]) ) + bitfield |= spdx; + + if ( !i || !nodeids || nodeids[i - 1] != nodeids[i] ) + nodes_used++; + + if ( epdx > memtop ) + memtop = epdx; + } + + if ( nodes_used <= 1 ) + i = min(PADDR_BITS, BITS_PER_LONG - 1); + else + i = find_first_bit(&bitfield, sizeof(unsigned long) * 8); + + memnodemapsize = ((memtop - 1) >> i) + 1; + + return i; +} + +int __init compute_hash_shift(const struct node *nodes, + unsigned int numnodes, const nodeid_t *nodeids) +{ + unsigned int shift = extract_lsb_from_nodes(nodes, numnodes, nodeids); + + if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) ) + memnodemap = _memnodemap; + else if ( allocate_cachealigned_memnodemap() ) + return -1; + + printk(KERN_DEBUG "NUMA: Using %u for the hash shift\n", shift); + + if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 ) + { + printk(KERN_INFO "Your memory is not aligned you need to " + "rebuild your hypervisor with a bigger NODEMAPSIZE " + "shift=%u\n", shift); + return -1; + } + + return shift; +} + +/* Initialize NODE_DATA given nodeid and start/end */ +void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end) +{ + unsigned long start_pfn = paddr_to_pfn(start); + unsigned long end_pfn = paddr_to_pfn(end); + + NODE_DATA(nodeid)->node_start_pfn = start_pfn; + NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn; + + node_set_online(nodeid); +} + +void __init numa_init_array(void) +{ + unsigned int i; + nodeid_t rr; + + /* + * There are unfortunately some poorly designed mainboards + * around that only connect memory to a single CPU. This + * breaks the 1:1 cpu->node mapping. To avoid this fill in + * the mapping for all possible CPUs, as the number of CPUs + * is not known yet. We round robin the existing nodes. + */ + rr = first_node(node_online_map); + for ( i = 0; i < nr_cpu_ids; i++ ) + { + if ( cpu_to_node[i] != NUMA_NO_NODE ) + continue; + numa_set_node(i, rr); + rr = cycle_node(rr, node_online_map); + } +} + +#ifdef CONFIG_NUMA_EMU +static unsigned int __initdata numa_fake; + +/* Numa emulation */ +static int __init numa_emulation(unsigned long start_pfn, + unsigned long end_pfn) +{ + int ret; + unsigned int i; + struct node nodes[MAX_NUMNODES]; + uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake; + + /* Kludge needed for the hash function */ + if ( hweight64(sz) > 1 ) + { + uint64_t x = 1; + + while ( (x << 1) < sz ) + x <<= 1; + if ( x < sz / 2 ) + printk(KERN_ERR "Numa emulation unbalanced. Complain to maintainer\n"); + sz = x; + } + + memset(&nodes, 0, sizeof(nodes)); + for ( i = 0; i < numa_fake; i++ ) + { + nodes[i].start = pfn_to_paddr(start_pfn) + i * sz; + + if ( i == numa_fake - 1 ) + sz = pfn_to_paddr(end_pfn) - nodes[i].start; + + nodes[i].end = nodes[i].start + sz; + printk(KERN_INFO "Faking node %u at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n", + i, nodes[i].start, nodes[i].end, + (nodes[i].end - nodes[i].start) >> 20); + node_set_online(i); + } + + ret = compute_hash_shift(nodes, numa_fake, NULL); + if ( ret < 0 ) + { + printk(KERN_ERR "No NUMA hash function found. Emulation disabled.\n"); + return -1; + } + memnode_shift = ret; + + for_each_online_node ( i ) + setup_node_bootmem(i, nodes[i].start, nodes[i].end); + + numa_init_array(); + + return 0; +} +#endif + +void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) +{ + unsigned int i; + paddr_t start = pfn_to_paddr(start_pfn); + paddr_t end = pfn_to_paddr(end_pfn); + +#ifdef CONFIG_NUMA_EMU + if ( numa_fake && !numa_emulation(start_pfn, end_pfn) ) + return; +#endif + +#ifdef CONFIG_NUMA + if ( !numa_off && !numa_process_nodes(start, end) ) + return; +#endif + + printk(KERN_INFO "%s\n", + numa_off ? "NUMA turned off" : "No NUMA configuration found"); + + printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n", + start, end); + + /* Setup dummy node covering all memory */ + memnode_shift = BITS_PER_LONG - 1; + memnodemap = _memnodemap; + + /* Dummy node only uses 1 slot in reality */ + memnodemap[0] = 0; + memnodemapsize = 1; + + nodes_clear(node_online_map); + node_set_online(0); + for ( i = 0; i < nr_cpu_ids; i++ ) + numa_set_node(i, 0); + + cpumask_copy(&node_to_cpumask[0], cpumask_of(0)); + setup_node_bootmem(0, start, end); +} + +void numa_add_cpu(unsigned int cpu) +{ + cpumask_set_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); +} + +void numa_set_node(unsigned int cpu, nodeid_t node) +{ + cpu_to_node[cpu] = node; +} + +/* [numa=off] */ +static int __init cf_check numa_setup(const char *opt) +{ + if ( !strncmp(opt, "off", 3) ) + numa_off = true; + else if ( !strncmp(opt, "on", 2) ) + numa_off = false; +#ifdef CONFIG_NUMA_EMU + else if ( !strncmp(opt, "fake=", 5) ) + { + numa_off = false; + numa_fake = simple_strtoul(opt + 5, NULL, 0); + if ( numa_fake >= MAX_NUMNODES ) + numa_fake = MAX_NUMNODES; + } +#endif + else + return arch_numa_setup(opt); + + return 0; +} +custom_param("numa", numa_setup); + +static void cf_check dump_numa(unsigned char key) +{ + s_time_t now = NOW(); + unsigned int i, j, n; + struct domain *d; + + printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, + now); + + for_each_online_node ( i ) + { + paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); + + printk("NODE%u start->%lu size->%lu free->%lu\n", + i, node_start_pfn(i), node_spanned_pages(i), + avail_node_heap_pages(i)); + /* Sanity check phys_to_nid() */ + if ( phys_to_nid(pa) != i ) + printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n", + pa, phys_to_nid(pa), i); + } + + j = cpumask_first(&cpu_online_map); + n = 0; + for_each_online_cpu ( i ) + { + if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] ) + { + if ( n > 1 ) + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); + else + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); + j = i; + n = 1; + } + else + ++n; + } + if ( n > 1 ) + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); + else + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); + + rcu_read_lock(&domlist_read_lock); + + printk("Memory location of each domain:\n"); + for_each_domain ( d ) + { + const struct page_info *page; + unsigned int page_num_node[MAX_NUMNODES]; + const struct vnuma_info *vnuma; + + process_pending_softirqs(); + + printk("%pd (total: %u):\n", d, domain_tot_pages(d)); + + memset(page_num_node, 0, sizeof(page_num_node)); + + spin_lock(&d->page_alloc_lock); + page_list_for_each ( page, &d->page_list ) + { + i = phys_to_nid(page_to_maddr(page)); + page_num_node[i]++; + } + spin_unlock(&d->page_alloc_lock); + + for_each_online_node ( i ) + printk(" Node %u: %u\n", i, page_num_node[i]); + + if ( !read_trylock(&d->vnuma_rwlock) ) + continue; + + if ( !d->vnuma ) + { + read_unlock(&d->vnuma_rwlock); + continue; + } + + vnuma = d->vnuma; + printk(" %u vnodes, %u vcpus, guest physical layout:\n", + vnuma->nr_vnodes, d->max_vcpus); + for ( i = 0; i < vnuma->nr_vnodes; i++ ) + { + unsigned int start_cpu = ~0U; + + if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE ) + printk(" %3u: pnode ???,", i); + else + printk(" %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]); + + printk(" vcpus "); + + for ( j = 0; j < d->max_vcpus; j++ ) + { + if ( !(j & 0x3f) ) + process_pending_softirqs(); + + if ( vnuma->vcpu_to_vnode[j] == i ) + { + if ( start_cpu == ~0U ) + { + printk("%u", j); + start_cpu = j; + } + } + else if ( start_cpu != ~0U ) + { + if ( j - 1 != start_cpu ) + printk("-%u ", j - 1); + else + printk(" "); + start_cpu = ~0U; + } + } + + if ( start_cpu != ~0U && start_cpu != j - 1 ) + printk("-%u", j - 1); + + printk("\n"); + + for ( j = 0; j < vnuma->nr_vmemranges; j++ ) + { + if ( vnuma->vmemrange[j].nid == i ) + printk(" %016"PRIx64" - %016"PRIx64"\n", + vnuma->vmemrange[j].start, + vnuma->vmemrange[j].end); + } + } + + read_unlock(&d->vnuma_rwlock); + } + + rcu_read_unlock(&domlist_read_lock); +} + +static int __init cf_check register_numa_trigger(void) +{ + register_keyhandler('u', dump_numa, "dump NUMA info", 1); + return 0; +} +__initcall(register_numa_trigger); diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 7aef1a88dc..5b3877344b 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -18,4 +18,70 @@ (((d)->vcpu != NULL && (d)->vcpu[0] != NULL) \ ? vcpu_to_node((d)->vcpu[0]) : NUMA_NO_NODE) +/* The following content can be used when NUMA feature is enabled */ +#ifdef CONFIG_NUMA + +extern nodeid_t cpu_to_node[NR_CPUS]; +extern cpumask_t node_to_cpumask[]; + +#define cpu_to_node(cpu) cpu_to_node[cpu] +#define parent_node(node) (node) +#define node_to_cpumask(node) node_to_cpumask[node] + +struct node { + paddr_t start, end; +}; + +extern int compute_hash_shift(const struct node *nodes, + unsigned int numnodes, const nodeid_t *nodeids); + +#define VIRTUAL_BUG_ON(x) + +extern bool numa_off; + +extern void numa_add_cpu(unsigned int cpu); +extern void numa_init_array(void); +extern void numa_set_node(unsigned int cpu, nodeid_t node); +extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); +extern int numa_process_nodes(paddr_t start, paddr_t end); + +extern int arch_numa_setup(const char *opt); +extern bool arch_numa_disabled(void); +extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); + +static inline void clear_node_cpumask(unsigned int cpu) +{ + cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); +} + +/* Simple perfect hash to map pdx to node numbers */ +extern unsigned int memnode_shift; +extern unsigned long memnodemapsize; +extern uint8_t *memnodemap; + +struct node_data { + unsigned long node_start_pfn; + unsigned long node_spanned_pages; +}; + +extern struct node_data node_data[]; + +static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) +{ + nodeid_t nid; + VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); + nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; + VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); + return nid; +} + +#define NODE_DATA(nid) (&node_data[nid]) + +#define node_start_pfn(nid) (NODE_DATA(nid)->node_start_pfn) +#define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages) +#define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ + NODE_DATA(nid)->node_spanned_pages) + +#endif + #endif /* _XEN_NUMA_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 06:35:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 06:35:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443093.697545 (Exim 4.92) (envelope-from ) id 1ouT4B-0002EO-0H; Mon, 14 Nov 2022 06:35:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443093.697545; Mon, 14 Nov 2022 06:35:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT4A-0002EH-Rn; Mon, 14 Nov 2022 06:35:34 +0000 Received: by outflank-mailman (input) for mailman id 443093; Mon, 14 Nov 2022 06:35:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT49-0000jp-Kx for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 06:35:33 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60066.outbound.protection.outlook.com [40.107.6.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 89c19741-63e6-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 07:35:32 +0100 (CET) Received: from DU2PR04CA0357.eurprd04.prod.outlook.com (2603:10a6:10:2b4::32) by PAXPR08MB7466.eurprd08.prod.outlook.com (2603:10a6:102:2b8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 06:35:31 +0000 Received: from DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b4:cafe::5e) by DU2PR04CA0357.outlook.office365.com (2603:10a6:10:2b4::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Mon, 14 Nov 2022 06:35:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT008.mail.protection.outlook.com (100.127.142.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:30 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Mon, 14 Nov 2022 06:35:30 +0000 Received: from d7949b411b9a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 61DC6679-4E7B-4400-8EA8-17C810EE16A2.1; Mon, 14 Nov 2022 06:35:24 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d7949b411b9a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 06:35:24 +0000 Received: from FR3P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::7) by AS8PR08MB6646.eurprd08.prod.outlook.com (2603:10a6:20b:350::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 06:35:19 +0000 Received: from VI1EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1f:cafe::3c) by FR3P281CA0079.outlook.office365.com (2603:10a6:d10:1f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 06:35:19 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT027.mail.protection.outlook.com (100.127.144.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:18 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 14 Nov 2022 06:35:17 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 14 Nov 2022 06:35:17 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89c19741-63e6-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=KQEFoFyNuQprUxMtixpzxTQR31dmGvno4As4t+1mvBXxzoMHPdHz5g10t80MRSI7D6G8MKffVT7dlH8GGj55fjMNYU4oa9eY0ZdNAQPDyGUkYVvkH+HY7WEBxAEaHSZJHXPX0gFHXMQ7mxHG3LEXL4OWokxH3vreVa8US2Wdzxq6Zs3ugrGoqHtn1Gr3zjxJxktGfysz7/Mu5Qn/MjRgTBFtCNC7SaxPpR2rs9Ei2KRHkoLJ9/5+m4s2gUEktXHRdzo+I3X19N0GyrsfHnsnYjdPXikyXnq18t8BteJHxHq3m4Q5N7ljGNqgGnGHfxJ4eTi0yljsPlOYf6dRGsm1lA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BEU5rsHGyAZiILfC21Y3SzOiZY3jP1U/4HF25Ob+mHw=; b=R0CLcffvyJqv9n2ZOPHDAcmQl10zgEJAZAOadM8bSm/QODF1yduiR8Yc0Wby7XgWaNKa5YEH4ohz+lXQ1k+MtSLsDwi9cbUvHZa0+ldQnYmisk8pv9x1seiwJWOTlI2B1N6xXG95CySILbSTqF+oMmjyB4TZhD9bMxVikEQJj84szMJW+LJkfiFr+kmyOFLpI0BVa5Muo1ZDIdgz2fCKbeT0KBpqdHE5waWoo2SPOZvyULHTZS7/ertZfZG30lTLFkXgx1esXn7mVWovJOixJZxJswtsML6gEBm1qmDDGScLcyMoy2pf3KQnc8xL0mBxqsbcq8JqJlJRKtNQOGkzAg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BEU5rsHGyAZiILfC21Y3SzOiZY3jP1U/4HF25Ob+mHw=; b=8mmH1M4P/tHrP9rd9dxkbnIGoAzu42OKRThp60cpM9kJ3JqQ2eZJaF/C9cXED067/ga4f8mTQtg0P/xD9FEf3IMg3hXnWwVE/aNtCjvN0BJmdsNLyyAedRgs777ZYkDoPuNx2+PYiWA0hcPwl7Lt1FUyY0FZeqtPPEs8jQXOI44= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 65785e3cdb1d72b9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vb4DXNcZGP9lUuO4OMcYHXCL40/YBrU30S6h1gF/EmnrG5a0tm532CO2vuCNa8njjP+EKr3UsVQTZnY4eP8xxzPakcuCb8GXViD9o9RtnOQiX8SIA72KHN5/shT/ZgZmzIyi1NFdqDga2z45a54gbG8zMxywR0ff7toBLJ3GTtHwWBgQ1oZQJ3NOJoi6PElHOoN+fTdgBQGyi9s72PqZ+Lf3mNDbOMEch4x8SlCiI1brSzRMNAlVGwxPII6Ckpi2TaMACre/6UwmdIbN7Lb9LbdYeLdah15bVbG8R/IzIoJ0LhWVJr8e7sw3jPrvp8rA5G33yldJ1AYs6R3AS82dBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BEU5rsHGyAZiILfC21Y3SzOiZY3jP1U/4HF25Ob+mHw=; b=jg/Y+MGXUSlhVxVn2tP0QLzeXv0LWfJgfbOMkQmKrBsV5gmKa134q3qdqGvdN5byOTwn4xuC11d0HkV5YIYzKlV1YBKCJHdMySQXe99cjI3CO+PyqKmL4Wx4nyQF8S9cwIuh9AX34H6HYKDh3HXtqQ3yRvl2MC5Jl1QhDXOSvXxnHQvHXEMaukzXk9xanyurqCQpN/2dnpjqTAI7C2qy+T018u8S45Hdpzle2+KtqSJ91H2yGOUqVjNoCE+kV0g4ajgN1eIkUkUcxJgmCzYu0hHNLifPXuGRCwfblxkJQHWwX+lYqON33UnQWWiO+WmBJ8qReZAK4a1M6eACjEQn5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BEU5rsHGyAZiILfC21Y3SzOiZY3jP1U/4HF25Ob+mHw=; b=8mmH1M4P/tHrP9rd9dxkbnIGoAzu42OKRThp60cpM9kJ3JqQ2eZJaF/C9cXED067/ga4f8mTQtg0P/xD9FEf3IMg3hXnWwVE/aNtCjvN0BJmdsNLyyAedRgs777ZYkDoPuNx2+PYiWA0hcPwl7Lt1FUyY0FZeqtPPEs8jQXOI44= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v8 6/6] xen: introduce a Kconfig option to configure NUMA nodes number Date: Mon, 14 Nov 2022 14:34:51 +0800 Message-ID: <20221114063451.473711-7-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221114063451.473711-1-wei.chen@arm.com> References: <20221114063451.473711-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT027:EE_|AS8PR08MB6646:EE_|DBAEUR03FT008:EE_|PAXPR08MB7466:EE_ X-MS-Office365-Filtering-Correlation-Id: 858dc4d3-0cd8-47a1-81da-08dac60a6d15 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dUPtLgPW0M5YrRPDGV1SqxQxHX4miwdOeVMkPlEpS3GAg/+1Dr9we/nwG2T5Li9ZnYuq4ENFF8gcJlaiIaf62UCgZmen6gmPl/xnjcUJKaU4C+gHveYFtM3985uEoraXpxDvgA7hiY8YwqZKXOfgRHUubGpGU7BNcghEz+D/v6f1LjNEJkk9iLSe1hJ3yivv0uGtCZr6s7ky8G15b+3w5i6PsY7HATg4lZXuyDqc8/4727nGfchHu2t1fQACDG2wt80PXcQRY430nEBFhuAmx35FnoNKr9BK6H5Cz7frAA9trkwjRKbr2mOj1HJst3gPVlE4mFLor1o8IqIWYJ8yrFyJVQ+JVnhV/BunKbkHAgLCiQh9quCaEDxkWbje4EUw9JbZC57upWMWgrGrpO0iDO6Oa0KneR3BH8rNTjycVTX5Y6kQtMLdbKoiX+zgGmBWJaoU7XBjW6D3yKK6jRW7dDSg+3GujksBoHnAWJ57O5to4JtN/c5BjNjZLN2deSFKf4RihLIjzHHAMV7IgIvaRMCpBylUEXi+sGvQs4LUMYE2LeWehWiUDCNjxLNvtGCGRjc3lUNIpmQLOoqoqqYeA33cwrDnAuQeRUy9jHq0p4IcNImRuE/63ZD4DCcrRz21yN1aCc8ytqbU6fLbFxMFzEbUKEOO6ZtviF455tlRG4JXsY9D85+MTwJxZZsOTNgXJoTRuaCL6ffZ1XHBiHbWaRc0HPF+5FMjLs+Uje314oync6ORz/wR28Fik8J8Ha0o9k3JPKpO9CFZuH+mDhLJnAlhJQxzI4JqWKlpfXwTIoQ= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(346002)(396003)(451199015)(36840700001)(40470700004)(46966006)(36860700001)(2906002)(70586007)(70206006)(4326008)(8936002)(5660300002)(41300700001)(83380400001)(44832011)(8676002)(40460700003)(40480700001)(86362001)(82740400003)(36756003)(81166007)(82310400005)(356005)(478600001)(54906003)(7696005)(6666004)(47076005)(26005)(316002)(6916009)(426003)(1076003)(186003)(2616005)(336012)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6646 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 434985c3-4fa4-4246-966c-08dac60a65c5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y5bxqbmcslUJVOUVo1J2T0wmN0ReR5TnzgwPiLEX11Zv/DlSYVXX5QiFtbxCQMsAjn7bB6fvQakqBth+iZamHoYsZX8Vz91IN8c1gGJklGlOfHImW9hhM7bSTGiI+kOHKJ22xAAOt5nVN7TICBqBrm3H3RY5pkiAtpoQS5gANfuZVCLvzKAg16Swy6NkYJP3NqAoQa9t7XXlkDtrS/5a024uJu8ULuESbu86lg/Oq4gZyv7BuoFiRQMpTV8jBkXzORBE3++YMQwItVGwhovlCGIQNYRlCHk22NxOYLINVgfRxQy3B7sTI1UdcmcdcqOH1G/B7c60GdFNV/q2ZxarCEPyZCzXE5KZKp+b5lNZENrwKgg5XdxJ18M+hF/3P7q/0LhQA3fpjISYXuSeyV8Ep1dCM/5MENFJXII4dQPjTHwhA5l9BwxpM+KL6tCkIdYIeUCsBNTMqh/iET4ERGBdHjeFmi4NCk+KSGrnWqmE4eMGKRoIMcv5J6IsM7GZ8TmFvu8PQGApygnOqOoySdkjAKN4J08sGI2SIWA/Jp91L/pDq1Wv93oacTVsIZBOT2zX4OG0fUZvxM/XJ35pHt4T8UyS702opaPIt6yvwDndq+f/TN/oXCVEVbDxEwdm5bftjIzPCyWgcngIhedpnwOK5ltJdQH5yo6MFQf8A7n+ITnWiM/2XDaySX5Tbg44ddB4fmK7kcbEesTciO1ONYaR02mAppi3ZRiS283SDrZgrFBlOxFJHgRhWmS+m6SDTw/UhOaYHivcIDlGP2w3D5taMw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199015)(40470700004)(36840700001)(46966006)(426003)(7696005)(47076005)(6666004)(83380400001)(107886003)(186003)(336012)(1076003)(26005)(2616005)(40480700001)(81166007)(82740400003)(36860700001)(2906002)(5660300002)(8936002)(44832011)(478600001)(8676002)(70586007)(70206006)(54906003)(41300700001)(316002)(4326008)(6916009)(82310400005)(36756003)(40460700003)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 06:35:30.8445 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 858dc4d3-0cd8-47a1-81da-08dac60a6d15 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7466 Currently the maximum number of NUMA nodes is a hardcoded value. This provides little flexibility unless changing the code. Introduce a new Kconfig option to change the maximum number of NUMA nodes conveniently. Also considering that not all architectures support NUMA, this Kconfig option is only visible on NUMA enabled architectures. Architectures not supporting NUMA still use 1 for MAX_NUMNODES. As NODES_SHIFT is currently unused, we're taking this opportunity to remove it. Signed-off-by: Wei Chen Acked-by: Jan Beulich --- v7 -> v8: 1. No change. v6 -> v7: 1. No change. v5 -> v6: 1. No change. v4 -> v5: 1. No change. v3 -> v4: 1. Update the commit log to follow Jan's suggestion. 2. Add Ack-by. v2 -> v3: 1. Fix indent. 2. Use 2-64 for node range. v1 -> v2: 1. Add NODES_SHIFT remove message in commit log 2. Change NR_NUMA_NODES upper bound from 4095 to 255. --- xen/arch/Kconfig | 11 +++++++++++ xen/arch/x86/include/asm/numa.h | 2 -- xen/include/xen/numa.h | 11 ++++++----- 3 files changed, 17 insertions(+), 7 deletions(-) diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig index f16eb0df43..7028f7b74f 100644 --- a/xen/arch/Kconfig +++ b/xen/arch/Kconfig @@ -17,3 +17,14 @@ config NR_CPUS For CPU cores which support Simultaneous Multi-Threading or similar technologies, this the number of logical threads which Xen will support. + +config NR_NUMA_NODES + int "Maximum number of NUMA nodes supported" + range 2 64 + default "64" + depends on NUMA + help + Controls the build-time size of various arrays and bitmaps + associated with multiple-nodes management. It is the upper bound of + the number of NUMA nodes that the scheduler, memory allocation and + other NUMA-aware components can handle. diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 2ca3475271..7866afa408 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -3,8 +3,6 @@ #include -#define NODES_SHIFT 6 - typedef u8 nodeid_t; extern int srat_rev; diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 04ecaf7769..71a5f837b3 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -3,14 +3,15 @@ #include -#ifndef NODES_SHIFT -#define NODES_SHIFT 0 -#endif - #define NUMA_NO_NODE 0xFF #define NUMA_NO_DISTANCE 0xFF -#define MAX_NUMNODES (1 << NODES_SHIFT) +#ifdef CONFIG_NR_NUMA_NODES +#define MAX_NUMNODES CONFIG_NR_NUMA_NODES +#else +#define MAX_NUMNODES 1 +#endif + #define NR_NODE_MEMBLKS (MAX_NUMNODES * 2) #define vcpu_to_node(v) (cpu_to_node((v)->processor)) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 06:35:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 06:35:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443095.697556 (Exim 4.92) (envelope-from ) id 1ouT4D-0002af-5f; Mon, 14 Nov 2022 06:35:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443095.697556; Mon, 14 Nov 2022 06:35:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT4D-0002aU-2c; Mon, 14 Nov 2022 06:35:37 +0000 Received: by outflank-mailman (input) for mailman id 443095; Mon, 14 Nov 2022 06:35:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT4B-0000je-K3 for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 06:35:36 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2049.outbound.protection.outlook.com [40.107.103.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8a393815-63e6-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 07:35:33 +0100 (CET) Received: from FR3P281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::6) by AS2PR08MB9987.eurprd08.prod.outlook.com (2603:10a6:20b:645::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 06:35:31 +0000 Received: from VI1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1d:cafe::cc) by FR3P281CA0007.outlook.office365.com (2603:10a6:d10:1d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 06:35:31 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT023.mail.protection.outlook.com (100.127.144.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:30 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Mon, 14 Nov 2022 06:35:30 +0000 Received: from 59c246908d72.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4AB303AF-8B90-4C1B-8973-E335F49EF59B.1; Mon, 14 Nov 2022 06:35:23 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 59c246908d72.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 06:35:23 +0000 Received: from AM5PR0201CA0003.eurprd02.prod.outlook.com (2603:10a6:203:3d::13) by PAVPR08MB9817.eurprd08.prod.outlook.com (2603:10a6:102:31d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 06:35:15 +0000 Received: from AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:3d:cafe::7c) by AM5PR0201CA0003.outlook.office365.com (2603:10a6:203:3d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Mon, 14 Nov 2022 06:35:15 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT025.mail.protection.outlook.com (100.127.140.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:14 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 14 Nov 2022 06:35:13 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a393815-63e6-11ed-91b6-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PIwa0Xb9Oy0MR4jE6xCXLnMNfSmtOPft9gAxQn7GrIH97Y+OR9j5tH1TJ/3nUFqL2V4zfx6jDIKgDl5MmZLZdilRj3OwzWWNwg+IbWCbqLYPpm+vGohra24H6NS+yfwYtrQdWe2NEMYauHmsKztefSWkk/IvjVZTHDnpwSGneTRmTWe8RabQ/kqRaAm8aFOg9dUa97yw255sfFDe4r2CJ84ifK4Ni0J10luUnbplYKbxWwI9DyTNPzv0wO3FeNWlA4BVgGJLqVlo2hqsWJO3dB6pHiEe9Ydul+Q4f8BZOO/YkOSxwnPi4TfTW8CJ/Mwypmwyy7Pma5cebHldXYL+gw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LEGNLm+cLEOdzsuwBLr9kWs4a8FoN0EWcOOLw22Cn0s=; b=JjrM1eMgRvGsHUAxtHxjb88ce4F/F8e4eDwTCwbt/ZmTGzs6lZSzC3sWa/Nb6UVY78PEE4DdhlR617FxXFWhm2hRL2tNNOHSeD76gMlZ3ojS3esgrkhdoUwt4WvbL+cafuLI+9SHcnhjo0V1RmM1lFk2Ctl+9/6KKz+4nxKSv3vEqt98s+mwd3aA8ZnCTQhXs7Njqgf+o/LqMJm3fKlbq96sR3JDB+2i1gTFU/MeB+SJhsP01e2lp2TgY9ElrJXPUZfE7x5UqOs/8SYIsZIehXdU3+HB/eFPevnzEYKZ4DHOmRxu56HfdzXxmcNUFcJzENWcBwWblRS2nZZLnSYHww== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LEGNLm+cLEOdzsuwBLr9kWs4a8FoN0EWcOOLw22Cn0s=; b=iIMcERX60YovyG9/fE58G+N7ShpXKCI4SpC355gm1FWPpeZJWITR7/MjVaJctkBhFjx0urGclMxauq+s21GHz3gEedF/YHQhaGYPE9w55+aNk58ONCxZIVuU2G33Wj5XAOSbKcF+ZeQIB2bziYx2fz98auvvF4BdxCvFElCdsF8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 2499bbdfd8a5776c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hFBfYZkOcXLFtJFL8wBPDgUsz/zts7Vw5QULuTu7OdZvEDLg6FOdFV9GDpouBfbo3D4uzM3lNC7nTkyCOQhjAgBOIxMhJUweLOASiM3qyDrNVuDA3LXvQgw1U0qoMgrLhe7w4C7sQlW7YsQTsh9JatyNWTczk8e4Gbt8Kx8STTWZOLiWzdOSFT6WSX2Uc60zKTNpJr1vDQki5TWfcRfeSLSPGwO5UAxXOnxnFNFWqQGwZsTXbSCjn890+G2Zq9yofuSdPMbIInGY2RU1lzvL5Fi4LjzpcqlW7Md2GWgekT+/f7o+9u2H7yr+0SIIyHLVmCK6NhBqPGqgRs9j8t58og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LEGNLm+cLEOdzsuwBLr9kWs4a8FoN0EWcOOLw22Cn0s=; b=JEGBaVuhYaj6h2SPW3poSK7ep7HZgkGaraARX1otQN9V2YQxOFc2mPaoorvHRaegS6kJ8a12r2/ZGK+/80Y9rVM4HrYDyV37iNUTsW9t+woqUlu9dJibOaqBfZZ4y8doacOkW4PyVVV85Al9V+XsyPC//Pf4dQRjn+UDzxkgrXIIiJLxTFwjE2+BN30XuDWuXkCwWDfQLYVn6LeWO2Guly5OiI0ievQBXHF4SPpZnd/ZHFXimQ7t8EZEc4/Vm17P9t0Pf9SkRfBHRnq4rSJbuQ5DvEZi1rBQSdX13SwMTvZrKm/Vl/wO13HwkYnyz/AB/N52myMwm241yFBMeHNmXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LEGNLm+cLEOdzsuwBLr9kWs4a8FoN0EWcOOLw22Cn0s=; b=iIMcERX60YovyG9/fE58G+N7ShpXKCI4SpC355gm1FWPpeZJWITR7/MjVaJctkBhFjx0urGclMxauq+s21GHz3gEedF/YHQhaGYPE9w55+aNk58ONCxZIVuU2G33Wj5XAOSbKcF+ZeQIB2bziYx2fz98auvvF4BdxCvFElCdsF8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v8 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common Date: Mon, 14 Nov 2022 14:34:50 +0800 Message-ID: <20221114063451.473711-6-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221114063451.473711-1-wei.chen@arm.com> References: <20221114063451.473711-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT025:EE_|PAVPR08MB9817:EE_|VI1EUR03FT023:EE_|AS2PR08MB9987:EE_ X-MS-Office365-Filtering-Correlation-Id: f1499b65-223f-4e19-6187-08dac60a6d09 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0ucUNO36BaxkBx9HGwgcjUAoP38Hv2Ud19Ls3MPF0BZr5Gi5Bdblbo9OgDRhlqt0KwYgNgojDuHVVjK6ZaVUWpbHmDBEshOJzWqLMLEvB0c69hBpbKxZHwdKSq1bKynxcggtUjcj8wu++iHmiUrHE16P5K2aBkIs5cI1utBxddjV3kOOM2S8UAIUaAkUEg0CDQFd5g2GYVzyFPA4BilH7chKdk/3aIbGWg+PG6FXAsTr9jtZcmA3dHJWW9l9yrUPd6/sQBz9XlzpagiY+4Gj5r0t+LbqZN5O2oG4JON7CrSY4vSCLKM6ZnxLMXB8iLqr1raLeFCFXP/qvYQsElKO1/3AkS3vs0FYzSVNcTF5HbprbJFzejeF6S339V5k4FJ/jIk9Car5bHNXjAvstx5Uh5/IbtKdeve1ad1CFj3c/POe/HFyRwI2KkGwu/FKOmWk8XHtQndyrHlI1yApuurEfeghQFfIHh8Df9UmPPPLikwJKy1v2mfOeO3MY/DZ5dgPfKOHzSCCBKFZ91fEdiO/YCgWC7oK4kNGh7gGi+OIFZeFzGI4+s73LTnYZqd44bNHyTE7N+/0q9RzAq9NzijaBRqP4ekyXOkFKHXS3cOhem5/7a1RIulUHs6CSLEhgg8/H6o8IFeprdhd22ZBbqeFVQm/UpnmDdWCQ/PJUBHIoGXPAG3n/H2+R/FiBqzJL7GsfxzpA7ImtYZqmmrcZe71nCxDzbXb+y0oqWjdXlYg/TCU6l8uMXiCcDKy/12psFbfW51OxBIam2nAwIB7c/YBkUNlMfTrZxeYqcSGHl2hy1mLbPM0tD4lywJdysyGyMrA X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(40470700004)(36840700001)(46966006)(6916009)(54906003)(316002)(44832011)(4326008)(8676002)(30864003)(5660300002)(8936002)(86362001)(41300700001)(70206006)(70586007)(2616005)(1076003)(47076005)(36756003)(82740400003)(40480700001)(336012)(186003)(426003)(36860700001)(83380400001)(478600001)(81166007)(6666004)(40460700003)(7696005)(356005)(26005)(82310400005)(2906002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9817 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2387f042-cb03-456a-65de-08dac60a6382 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bOcvoiOLg0rNZxzVnpR6Ox2tgja1IcafFXFp3a9OXVKCMwxp0uFlC/1MNa1hj2FdjMmIE15rW0S/7gcgoTcZEcUqa2l5qkhRn85Mn0eI/T4zSFNoT/37/JTHUrbjfhUwGuufYwfjLm9vwDAj8NVRyinROgLu4GTNCi5HxDYN+ybR56l7Lshk9Zgo/DRzGnG03JXuXApWwm+cML3YgVGJZJjFPrTkwQ0GWVMuf1R9PW+KDFMxGHfQ/x3Rs6E+puOkZk7xx63pX7Gt/UHrDdFek/GnLcx5leCkD27s2KCCjysvz8G0OMb/wsxSvDy4+26K/OM13QJEIQTmR7dXVJxtXMA6u5JfUAI7A+LIFPN23/fw+mrk8XcKHGLtrDveSLopj77TIIxllzt9ovyqn/fI9SfMImtYxQvDsDGCFUBXjKPGZwpWDSRA5O4bjmlnJEqkOMBZYJPupy+3Pdz/IuBOdEhXBLeX22ixzCRy1Kd762dZxuAml/wo7aDs/rQ5nWYpz8amrYMs3wFZkV1yrTGbWBL+JrmK0Nc+/k+fBH0lgSB1do+r3ETl8LE1eMSeyJHJfzgYtJznVAUuo0pz56ArBS8ijLbPALW+T7QOLAtn8hZ2PcueQcIV5cFixg80xMkca9g+ld/UF8Cc1hfg1ZfklqbvU/QWBzTwmG2c9gJDNz6bbPCPcGUF8GnCQglbl2kYzzYzQC5MCV1cb+fMcvB61otvKi7yxYeSstosHbPvrhmLkORjnRJ6zDkhODdP0D99tMBt69hAvGoh8Oa+QDJKUw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(396003)(136003)(451199015)(36840700001)(46966006)(40470700004)(478600001)(81166007)(36756003)(40460700003)(54906003)(316002)(2906002)(4326008)(107886003)(6666004)(70586007)(70206006)(6916009)(8676002)(86362001)(40480700001)(7696005)(82310400005)(8936002)(41300700001)(26005)(82740400003)(44832011)(47076005)(426003)(5660300002)(2616005)(36860700001)(336012)(83380400001)(186003)(30864003)(1076003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 06:35:30.6244 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f1499b65-223f-4e19-6187-08dac60a6d09 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9987 x86 has implemented a set of codes to process NUMA nodes. These codes will parse NUMA memory and processor information from ACPI SRAT table. But except some ACPI specific codes, most of the process code like memory blocks validation, node memory range updates and some sanity check can be reused by other NUMA implementation. So in this patch, we move some variables and related functions for NUMA memory and processor to common as library. At the same time, numa_set_processor_nodes_parsed has been introduced for ACPI specific code to update processor parsing results. With this helper, we can reuse most of NUMA memory affinity init code from ACPI. As bad_srat and node_to_pxm functions have been used in common code to do architectural fallback and node to architectural node info translation. But it doesn't make sense to reuse the functions names in common code, we have rename them to neutral names as well. PXM is an ACPI specific item, we can't use it in common code directly. As an alternative, we extend the parameters of numa_update_node_memblks. The caller can pass the PXM as print messages' prefix or as architectural node id. And we introduced an numa_fw_nid_name for each NUMA implementation to set their specific firmware NUMA node name. In this case, we do not need to retain a lot of per-arch code but still can print architectural log messages for different NUMA implementations. A default value "???" will be set to indicate an unset numa_fw_nid_name. mem_hotplug is accessed by common code if memory hotplug is activated. Even if this is only supported by x86, export the variable so that other architectures could support it in the future. As asm/acpi.h has been removed from common/numa.c, we have to move NR_NODE_MEMBLKS from asm/acpi.h to xen/numa.h in this patch as well. Signed-off-by: Wei Chen --- v7 -> v8: 1. Add numa_fw_nid_name setting in srat_parse_regions after acpi_table_parse succeeded. v6 -> v7: 1. Add __init for arch_numa_unavailable. 2. Use __ro_after_init for mem_hotplug. 3. Use "???" instead of "NONAME" for unset numa_fw_nid_name. 4. Fix code-style. v5 -> v6: 1. Fix code-style. 2. Use arch_numa_unavailable to replace arch_numa_disabled for acpi_numa <= 0. 3. Remove Kconfig for HAS_NUMA_NODE_FWID. 4. Use numa_fw_nid_name for NUMA implementation to set their fw NUMA node name for print messages. v4 -> v5: 1. Introduce arch_numa_disabled for acpi_numa <= 0 in this patch. 2. Remove the paramter init_as_disable of arch_numa_disabled. 3. Fix typo "expandsion". 4. Add const to proper varibales. 5. Fix Indentation for l1tf_safe_maddr. 6. Remove double blank lines. 7. Add a space between for_each_node_mask and '('. Add a space page_list_for_each and '('. 8. Use bool for nodes_cover_memory return value. 9. Use a plain "int ret" to record compute_hash_shift return value. 10. Add a blank line before the function's main "return". 11. Add new Kconfig option HAS_NUMA_NODE_FWID to common/Kconfig. v3 -> v4: 1. Use bool as return value for functions that only return 0/1 or 0/-EINVAL. 2. Move mem_hotplug to a proper place in mm.h 3. Remove useless "size" in numa_scan_nodes. 4. Use unsigned int or const for proper variables. 5. Fix code-style. 6. Add init_as_disable as arch_numa_disabled parameter. 7. Add CONFIG_HAS_NUMA_NODE_FWID to gate print the mapping between node id and architectural node id (fw node id). v2 -> v3: 1. Add __ro_after_init to proper variables. 2. Rename bad_srat to numa_fw_bad. 3. Rename node_to_pxm to numa_node_to_arch_nid. 4. Merge patch#7 and #8 into this patch. 5. Correct int to unsigned int in proper places. 6. Move NR_NODE_MEMBLKS from x86/acpi.h to common/numa.h 7. Drop helpers to access mem_hotplug, we export mem_hotplug from x86/mm.c to common/page_alloc.c v1 -> v2: 1. Add code comment for numa_update_node_memblks to explain: Assumes all memory regions belonging to a single node are in one chunk. Holes between them will be included in the node. 2. Merge this single patch instead of serval patches to move x86 SRAT code to common. 3. Export node_to_pxm to keep pxm information in NUMA scan nodes error messages. 4. Change the code style to target file's Xen code-style. 5. Adjust some __init and __initdata for some functions and variables. 6. Merge two patches into this patch: 1. replace CONFIG_ACPI_NUMA by CONFIG_NUMA. 2. replace "SRAT" texts. 7. Turn numa_scan_nodes to static. --- xen/arch/x86/include/asm/acpi.h | 1 - xen/arch/x86/include/asm/mm.h | 2 - xen/arch/x86/include/asm/numa.h | 3 +- xen/arch/x86/mm.c | 2 - xen/arch/x86/numa.c | 5 + xen/arch/x86/srat.c | 336 +++---------------------------- xen/common/numa.c | 341 +++++++++++++++++++++++++++++++- xen/common/page_alloc.c | 2 + xen/include/xen/mm.h | 2 + xen/include/xen/numa.h | 10 +- 10 files changed, 383 insertions(+), 321 deletions(-) diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h index 5c2dd5da2d..c453450a74 100644 --- a/xen/arch/x86/include/asm/acpi.h +++ b/xen/arch/x86/include/asm/acpi.h @@ -102,7 +102,6 @@ extern unsigned long acpi_wakeup_address; #define ARCH_HAS_POWER_INIT 1 extern s8 acpi_numa; -#define NR_NODE_MEMBLKS (MAX_NUMNODES*2) extern struct acpi_sleep_info acpi_sinfo; #define acpi_video_flags bootsym(video_flags) diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h index d723c7c38f..2c5f856067 100644 --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -456,8 +456,6 @@ static inline int get_page_and_type(struct page_info *page, ASSERT(((_p)->count_info & PGC_count_mask) != 0); \ ASSERT(page_get_owner(_p) == (_d)) -extern paddr_t mem_hotplug; - /****************************************************************************** * With shadow pagetables, the different kinds of address start * to get get confusing. diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 6c87942d43..2ca3475271 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -10,6 +10,7 @@ typedef u8 nodeid_t; extern int srat_rev; extern nodeid_t pxm_to_node(unsigned int pxm); +extern unsigned int numa_node_to_arch_nid(nodeid_t n); #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) @@ -22,8 +23,6 @@ extern void init_cpu_to_node(void); #define arch_want_default_dmazone() (num_online_nodes() > 1) -extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); - void srat_parse_regions(paddr_t addr); extern u8 __node_distance(nodeid_t a, nodeid_t b); unsigned int arch_get_dma_bitsize(void); diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index db1817b691..68f9989e1f 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -157,8 +157,6 @@ l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) l1_fixmap_x[L1_PAGETABLE_ENTRIES]; -paddr_t __read_mostly mem_hotplug; - /* Frame table size in pages. */ unsigned long max_page; unsigned long total_pages; diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index fa8caaa084..4b0b297c7e 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -46,6 +46,11 @@ bool arch_numa_disabled(void) return acpi_numa < 0; } +bool __init arch_numa_unavailable(void) +{ + return acpi_numa <= 0; +} + /* * Setup early cpu_to_node. * diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index 1a108a34c6..7944723d2d 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -24,10 +24,6 @@ static struct acpi_table_slit *__read_mostly acpi_slit; -static nodemask_t memory_nodes_parsed __initdata; -static nodemask_t processor_nodes_parsed __initdata; -static struct node nodes[MAX_NUMNODES] __initdata; - struct pxm2node { unsigned pxm; nodeid_t node; @@ -35,19 +31,6 @@ struct pxm2node { static struct pxm2node __read_mostly pxm2node[MAX_NUMNODES] = { [0 ... MAX_NUMNODES - 1] = {.node = NUMA_NO_NODE} }; -static unsigned node_to_pxm(nodeid_t n); - -static int num_node_memblks; -static struct node node_memblk_range[NR_NODE_MEMBLKS]; -static nodeid_t memblk_nodeid[NR_NODE_MEMBLKS]; -static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS); - -enum conflicts { - NO_CONFLICT, - OVERLAP, - INTERLEAVE, -}; - static inline bool node_found(unsigned idx, unsigned pxm) { return ((pxm2node[idx].pxm == pxm) && @@ -110,78 +93,7 @@ nodeid_t setup_node(unsigned pxm) return node; } -int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node) -{ - int i; - - for (i = 0; i < num_node_memblks; i++) { - struct node *nd = &node_memblk_range[i]; - - if (nd->start <= start && nd->end >= end && - memblk_nodeid[i] == node) - return 1; - } - - return 0; -} - -static -enum conflicts __init conflicting_memblks(nodeid_t nid, paddr_t start, - paddr_t end, paddr_t nd_start, - paddr_t nd_end, unsigned int *mblkid) -{ - unsigned int i; - - /* - * Scan all recorded nodes' memory blocks to check conflicts: - * Overlap or interleave. - */ - for (i = 0; i < num_node_memblks; i++) { - struct node *nd = &node_memblk_range[i]; - - *mblkid = i; - - /* Skip 0 bytes node memory block. */ - if (nd->start == nd->end) - continue; - /* - * Use memblk range to check memblk overlaps, include the - * self-overlap case. As nd's range is non-empty, the special - * case "nd->end == end && nd->start == start" also can be covered. - */ - if (nd->end > start && nd->start < end) - return OVERLAP; - - /* - * Use node memory range to check whether new range contains - * memory from other nodes - interleave check. We just need - * to check full contains situation. Because overlaps have - * been checked above. - */ - if (nid != memblk_nodeid[i] && - nd->start >= nd_start && nd->end <= nd_end) - return INTERLEAVE; - } - - return NO_CONFLICT; -} - -static __init void cutoff_node(int i, paddr_t start, paddr_t end) -{ - struct node *nd = &nodes[i]; - if (nd->start < start) { - nd->start = start; - if (nd->end < nd->start) - nd->start = nd->end; - } - if (nd->end > end) { - nd->end = end; - if (nd->start > nd->end) - nd->start = nd->end; - } -} - -static __init void bad_srat(void) +void __init numa_fw_bad(void) { int i; printk(KERN_ERR "SRAT: SRAT not used.\n"); @@ -241,7 +153,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) if (numa_disabled()) return; if (pa->header.length < sizeof(struct acpi_srat_x2apic_cpu_affinity)) { - bad_srat(); + numa_fw_bad(); return; } if (!(pa->flags & ACPI_SRAT_CPU_ENABLED)) @@ -254,12 +166,12 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) pxm = pa->proximity_domain; node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_fw_bad(); return; } apicid_to_node[pa->apic_id] = node; - node_set(node, processor_nodes_parsed); + numa_set_processor_nodes_parsed(node); acpi_numa = 1; if (opt_acpi_verbose) @@ -277,7 +189,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) if (numa_disabled()) return; if (pa->header.length != sizeof(struct acpi_srat_cpu_affinity)) { - bad_srat(); + numa_fw_bad(); return; } if (!(pa->flags & ACPI_SRAT_CPU_ENABLED)) @@ -290,11 +202,11 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) } node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_fw_bad(); return; } apicid_to_node[pa->apic_id] = node; - node_set(node, processor_nodes_parsed); + numa_set_processor_nodes_parsed(node); acpi_numa = 1; if (opt_acpi_verbose) @@ -306,33 +218,27 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) void __init acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) { - struct node *nd; - paddr_t nd_start, nd_end; - paddr_t start, end; unsigned pxm; nodeid_t node; - unsigned int i; - bool next = false; if (numa_disabled()) return; if (ma->header.length != sizeof(struct acpi_srat_mem_affinity)) { - bad_srat(); + numa_fw_bad(); return; } if (!(ma->flags & ACPI_SRAT_MEM_ENABLED)) return; - start = ma->base_address; - end = start + ma->length; /* Supplement the heuristics in l1tf_calculations(). */ - l1tf_safe_maddr = max(l1tf_safe_maddr, ROUNDUP(end, PAGE_SIZE)); + l1tf_safe_maddr = max(l1tf_safe_maddr, + ROUNDUP(ma->base_address + ma->length, + PAGE_SIZE)); - if (num_node_memblks >= NR_NODE_MEMBLKS) - { + if (!numa_memblks_available()) { dprintk(XENLOG_WARNING, - "Too many numa entry, try bigger NR_NODE_MEMBLKS \n"); - bad_srat(); + "Too many numa entries, try bigger NR_NODE_MEMBLKS!\n"); + numa_fw_bad(); return; } @@ -341,159 +247,14 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) pxm &= 0xff; node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_fw_bad(); return; } - /* - * For the node that already has some memory blocks, we will - * expand the node memory range temporarily to check memory - * interleaves with other nodes. We will not use this node - * temp memory range to check overlaps, because it will mask - * the overlaps in same node. - * - * Node with 0 bytes memory doesn't need this expandsion. - */ - nd_start = start; - nd_end = end; - nd = &nodes[node]; - if (nd->start != nd->end) { - if (nd_start > nd->start) - nd_start = nd->start; - - if (nd_end < nd->end) - nd_end = nd->end; - } - - /* It is fine to add this area to the nodes data it will be used later*/ - switch (conflicting_memblks(node, start, end, nd_start, nd_end, &i)) { - case OVERLAP: - if (memblk_nodeid[i] == node) { - bool mismatch = !(ma->flags & - ACPI_SRAT_MEM_HOT_PLUGGABLE) != - !test_bit(i, memblk_hotplug); - - printk("%sSRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n", - mismatch ? KERN_ERR : KERN_WARNING, pxm, start, - end - 1, node_memblk_range[i].start, - node_memblk_range[i].end - 1); - if (mismatch) { - bad_srat(); - return; - } - break; - } - - printk(KERN_ERR - "SRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with PXM %u [%"PRIpaddr", %"PRIpaddr"]\n", - pxm, start, end - 1, node_to_pxm(memblk_nodeid[i]), - node_memblk_range[i].start, - node_memblk_range[i].end - 1); - bad_srat(); - return; - - case INTERLEAVE: - printk(KERN_ERR - "SRAT： PXM %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with PXM %u memblk [%"PRIpaddr", %"PRIpaddr"]\n", - pxm, nd_start, nd_end - 1, node_to_pxm(memblk_nodeid[i]), - node_memblk_range[i].start, node_memblk_range[i].end - 1); - bad_srat(); - return; - - case NO_CONFLICT: - break; - } - - if (!(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) { - node_set(node, memory_nodes_parsed); - nd->start = nd_start; - nd->end = nd_end; - } - - printk(KERN_INFO "SRAT: Node %u PXM %u [%"PRIpaddr", %"PRIpaddr"]%s\n", - node, pxm, start, end - 1, - ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); - - /* Keep node_memblk_range[] sorted by address. */ - for (i = 0; i < num_node_memblks; ++i) - if (node_memblk_range[i].start > start || - (node_memblk_range[i].start == start && - node_memblk_range[i].end > end)) - break; - - memmove(&node_memblk_range[i + 1], &node_memblk_range[i], - (num_node_memblks - i) * sizeof(*node_memblk_range)); - node_memblk_range[i].start = start; - node_memblk_range[i].end = end; - - memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i], - (num_node_memblks - i) * sizeof(*memblk_nodeid)); - memblk_nodeid[i] = node; - - if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) { - next = true; - if (end > mem_hotplug) - mem_hotplug = end; - } - for (; i <= num_node_memblks; ++i) { - bool prev = next; - - next = test_bit(i, memblk_hotplug); - if (prev) - __set_bit(i, memblk_hotplug); - else - __clear_bit(i, memblk_hotplug); - } - - num_node_memblks++; -} - -/* Sanity check to catch more bad SRATs (they are amazingly common). - Make sure the PXMs cover all memory. */ -static int __init nodes_cover_memory(void) -{ - unsigned int i; - - for (i = 0; ; i++) { - int err; - unsigned int j; - bool found; - paddr_t start, end; - - /* Try to loop memory map from index 0 to end to get RAM ranges. */ - err = arch_get_ram_range(i, &start, &end); - - /* Reached the end of the memory map? */ - if (err == -ENOENT) - break; - - /* Skip non-RAM entries. */ - if (err) - continue; - - do { - found = false; - for_each_node_mask(j, memory_nodes_parsed) - if (start < nodes[j].end - && end > nodes[j].start) { - if (start >= nodes[j].start) { - start = nodes[j].end; - found = true; - } - if (end <= nodes[j].end) { - end = nodes[j].start; - found = true; - } - } - } while (found && start < end); - - if (start < end) { - printk(KERN_ERR "NUMA: No NODE for RAM range: " - "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); - return 0; - } - } - return 1; + numa_fw_nid_name = "PXM"; + if (!numa_update_node_memblks(node, pxm, ma->base_address, ma->length, + ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) + numa_fw_bad(); } void __init acpi_numa_arch_fixup(void) {} @@ -534,6 +295,7 @@ void __init srat_parse_regions(paddr_t addr) acpi_table_parse(ACPI_SIG_SRAT, acpi_parse_srat)) return; + numa_fw_nid_name = "PXM"; srat_region_mask = pdx_init_mask(addr); acpi_table_parse_srat(ACPI_SRAT_TYPE_MEMORY_AFFINITY, srat_parse_region, 0); @@ -549,59 +311,9 @@ void __init srat_parse_regions(paddr_t addr) pfn_pdx_hole_setup(mask >> PAGE_SHIFT); } -/* Use discovered information to actually set up the nodes. */ -int __init numa_process_nodes(paddr_t start, paddr_t end) +unsigned int numa_node_to_arch_nid(nodeid_t n) { - int i; - nodemask_t all_nodes_parsed; - - /* First clean up the node list */ - for (i = 0; i < MAX_NUMNODES; i++) - cutoff_node(i, start, end); - - if (acpi_numa <= 0) - return -1; - - if (!nodes_cover_memory()) { - bad_srat(); - return -1; - } - - memnode_shift = compute_hash_shift(node_memblk_range, num_node_memblks, - memblk_nodeid); - - if (memnode_shift < 0) { - printk(KERN_ERR - "SRAT: No NUMA node hash function found. Contact maintainer\n"); - bad_srat(); - return -1; - } - - nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed); - - /* Finally register nodes */ - for_each_node_mask(i, all_nodes_parsed) - { - uint64_t size = nodes[i].end - nodes[i].start; - - if ( size == 0 ) - printk(KERN_INFO "SRAT: node %u has no memory\n", i); - - setup_node_bootmem(i, nodes[i].start, nodes[i].end); - } - for (i = 0; i < nr_cpu_ids; i++) { - if (cpu_to_node[i] == NUMA_NO_NODE) - continue; - if (!nodemask_test(cpu_to_node[i], &processor_nodes_parsed)) - numa_set_node(i, NUMA_NO_NODE); - } - numa_init_array(); - return 0; -} - -static unsigned node_to_pxm(nodeid_t n) -{ - unsigned i; + unsigned int i; if ((n < ARRAY_SIZE(pxm2node)) && (pxm2node[n].node == n)) return pxm2node[n].pxm; @@ -618,8 +330,8 @@ u8 __node_distance(nodeid_t a, nodeid_t b) if (!acpi_slit) return a == b ? 10 : 20; - index = acpi_slit->locality_count * node_to_pxm(a); - slit_val = acpi_slit->entry[index + node_to_pxm(b)]; + index = acpi_slit->locality_count * numa_node_to_arch_nid(a); + slit_val = acpi_slit->entry[index + numa_node_to_arch_nid(b)]; /* ACPI defines 0xff as an unreachable node and 0-9 are undefined */ if ((slit_val == 0xff) || (slit_val <= 9)) diff --git a/xen/common/numa.c b/xen/common/numa.c index a135154c3e..4948b21fbe 100644 --- a/xen/common/numa.c +++ b/xen/common/numa.c @@ -13,6 +13,21 @@ #include #include +static nodemask_t __initdata processor_nodes_parsed; +static nodemask_t __initdata memory_nodes_parsed; +static struct node __initdata nodes[MAX_NUMNODES]; + +static unsigned int __ro_after_init num_node_memblks; +static struct node __ro_after_init node_memblk_range[NR_NODE_MEMBLKS]; +static nodeid_t __ro_after_init memblk_nodeid[NR_NODE_MEMBLKS]; +static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS); + +enum conflicts { + NO_CONFLICT, + OVERLAP, + INTERLEAVE, +}; + struct node_data __ro_after_init node_data[MAX_NUMNODES]; /* Mapping from pdx to node id */ @@ -31,11 +46,335 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; bool __ro_after_init numa_off; +const char *__ro_after_init numa_fw_nid_name = "???"; + bool numa_disabled(void) { return numa_off || arch_numa_disabled(); } +void __init numa_set_processor_nodes_parsed(nodeid_t node) +{ + node_set(node, processor_nodes_parsed); +} + +bool valid_numa_range(paddr_t start, paddr_t end, nodeid_t node) +{ + unsigned int i; + + for ( i = 0; i < num_node_memblks; i++ ) + { + const struct node *nd = &node_memblk_range[i]; + + if ( nd->start <= start && nd->end >= end && + memblk_nodeid[i] == node ) + return true; + } + + return false; +} + +static enum conflicts __init conflicting_memblks( + nodeid_t nid, paddr_t start, paddr_t end, paddr_t nd_start, + paddr_t nd_end, unsigned int *mblkid) +{ + unsigned int i; + + /* + * Scan all recorded nodes' memory blocks to check conflicts: + * Overlap or interleave. + */ + for ( i = 0; i < num_node_memblks; i++ ) + { + const struct node *nd = &node_memblk_range[i]; + + *mblkid = i; + + /* Skip 0 bytes node memory block. */ + if ( nd->start == nd->end ) + continue; + /* + * Use memblk range to check memblk overlaps, include the + * self-overlap case. As nd's range is non-empty, the special + * case "nd->end == end && nd->start == start" also can be covered. + */ + if ( nd->end > start && nd->start < end ) + return OVERLAP; + + /* + * Use node memory range to check whether new range contains + * memory from other nodes - interleave check. We just need + * to check full contains situation. Because overlaps have + * been checked above. + */ + if ( nid != memblk_nodeid[i] && + nd->start >= nd_start && nd->end <= nd_end ) + return INTERLEAVE; + } + + return NO_CONFLICT; +} + +static void __init cutoff_node(nodeid_t i, paddr_t start, paddr_t end) +{ + struct node *nd = &nodes[i]; + + if ( nd->start < start ) + { + nd->start = start; + if ( nd->end < nd->start ) + nd->start = nd->end; + } + + if ( nd->end > end ) + { + nd->end = end; + if ( nd->start > nd->end ) + nd->start = nd->end; + } +} + +bool __init numa_memblks_available(void) +{ + return num_node_memblks < NR_NODE_MEMBLKS; +} + +/* + * This function will be called by NUMA memory affinity initialization to + * update NUMA node's memory range. In this function, we assume all memory + * regions belonging to a single node are in one chunk. Holes (or MMIO + * ranges) between them will be included in the node. + * + * So in numa_update_node_memblks, if there are multiple banks for each + * node, start and end are stretched to cover the holes between them, and + * it works as long as memory banks of different NUMA nodes don't interleave. + */ +bool __init numa_update_node_memblks(nodeid_t node, unsigned int arch_nid, + paddr_t start, paddr_t size, bool hotplug) +{ + unsigned int i; + bool next = false; + paddr_t end = start + size; + paddr_t nd_start = start; + paddr_t nd_end = end; + struct node *nd = &nodes[node]; + + /* + * For the node that already has some memory blocks, we will + * expand the node memory range temporarily to check memory + * interleaves with other nodes. We will not use this node + * temp memory range to check overlaps, because it will mask + * the overlaps in same node. + * + * Node with 0 bytes memory doesn't need this expansion. + */ + if ( nd->start != nd->end ) + { + if ( nd_start > nd->start ) + nd_start = nd->start; + + if ( nd_end < nd->end ) + nd_end = nd->end; + } + + /* It is fine to add this area to the nodes data it will be used later */ + switch ( conflicting_memblks(node, start, end, nd_start, nd_end, &i) ) + { + case OVERLAP: + if ( memblk_nodeid[i] == node ) + { + bool mismatch = !hotplug != !test_bit(i, memblk_hotplug); + + printk("%sNUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n", + mismatch ? KERN_ERR : KERN_WARNING, numa_fw_nid_name, + arch_nid, start, end - 1, + node_memblk_range[i].start, node_memblk_range[i].end - 1); + if ( mismatch ) + return false; + break; + } + + printk(KERN_ERR + "NUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with %s %u [%"PRIpaddr", %"PRIpaddr"]\n", + numa_fw_nid_name, arch_nid, start, end - 1, numa_fw_nid_name, + numa_node_to_arch_nid(memblk_nodeid[i]), + node_memblk_range[i].start, node_memblk_range[i].end - 1); + return false; + + case INTERLEAVE: + printk(KERN_ERR + "NUMA： %s %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with %s %u memblk [%"PRIpaddr", %"PRIpaddr"]\n", + numa_fw_nid_name, arch_nid, nd_start, nd_end - 1, + numa_fw_nid_name, numa_node_to_arch_nid(memblk_nodeid[i]), + node_memblk_range[i].start, node_memblk_range[i].end - 1); + return false; + + case NO_CONFLICT: + break; + } + + if ( !hotplug ) + { + node_set(node, memory_nodes_parsed); + nd->start = nd_start; + nd->end = nd_end; + } + + printk(KERN_INFO "NUMA: Node %u %s %u [%"PRIpaddr", %"PRIpaddr"]%s\n", + node, numa_fw_nid_name, arch_nid, start, end - 1, + hotplug ? " (hotplug)" : ""); + + /* Keep node_memblk_range[] sorted by address. */ + for ( i = 0; i < num_node_memblks; ++i ) + if ( node_memblk_range[i].start > start || + (node_memblk_range[i].start == start && + node_memblk_range[i].end > end) ) + break; + + memmove(&node_memblk_range[i + 1], &node_memblk_range[i], + (num_node_memblks - i) * sizeof(*node_memblk_range)); + node_memblk_range[i].start = start; + node_memblk_range[i].end = end; + + memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i], + (num_node_memblks - i) * sizeof(*memblk_nodeid)); + memblk_nodeid[i] = node; + + if ( hotplug ) + { + next = true; + if ( end > mem_hotplug ) + mem_hotplug = end; + } + + for ( ; i <= num_node_memblks; ++i ) + { + bool prev = next; + + next = test_bit(i, memblk_hotplug); + if ( prev ) + __set_bit(i, memblk_hotplug); + else + __clear_bit(i, memblk_hotplug); + } + + num_node_memblks++; + + return true; +} + +/* + * Sanity check to catch more bad SRATs (they are amazingly common). + * Make sure the PXMs cover all memory. + */ +static bool __init nodes_cover_memory(void) +{ + unsigned int i; + + for ( i = 0; ; i++ ) + { + int err; + unsigned int j; + bool found; + paddr_t start, end; + + /* Try to loop memory map from index 0 to end to get RAM ranges. */ + err = arch_get_ram_range(i, &start, &end); + + /* Reached the end of the memory map? */ + if ( err == -ENOENT ) + break; + + /* Skip non-RAM entries. */ + if ( err ) + continue; + + do { + found = false; + for_each_node_mask ( j, memory_nodes_parsed ) + if ( start < nodes[j].end && end > nodes[j].start ) + { + if ( start >= nodes[j].start ) + { + start = nodes[j].end; + found = true; + } + + if ( end <= nodes[j].end ) + { + end = nodes[j].start; + found = true; + } + } + } while ( found && start < end ); + + if ( start < end ) + { + printk(KERN_ERR "NUMA: No node for RAM range: " + "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); + return false; + } + } + + return true; +} + +/* Use discovered information to actually set up the nodes. */ +static bool __init numa_process_nodes(paddr_t start, paddr_t end) +{ + int ret; + unsigned int i; + nodemask_t all_nodes_parsed; + + /* First clean up the node list */ + for ( i = 0; i < MAX_NUMNODES; i++ ) + cutoff_node(i, start, end); + + /* When numa is on and has data, we can start to process numa nodes. */ + if ( arch_numa_unavailable() ) + return false; + + if ( !nodes_cover_memory() ) + { + numa_fw_bad(); + return false; + } + + ret = compute_hash_shift(node_memblk_range, num_node_memblks, + memblk_nodeid); + if ( ret < 0 ) + { + printk(KERN_ERR + "NUMA: No NUMA node hash function found. Contact maintainer\n"); + numa_fw_bad(); + return false; + } + memnode_shift = ret; + + nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed); + + /* Finally register nodes */ + for_each_node_mask ( i, all_nodes_parsed ) + { + if ( nodes[i].end == nodes[i].start ) + printk(KERN_INFO "NUMA: node %u has no memory\n", i); + + setup_node_bootmem(i, nodes[i].start, nodes[i].end); + } + + for ( i = 0; i < nr_cpu_ids; i++ ) + { + if ( cpu_to_node[i] == NUMA_NO_NODE ) + continue; + if ( !nodemask_test(cpu_to_node[i], &processor_nodes_parsed) ) + numa_set_node(i, NUMA_NO_NODE); + } + + numa_init_array(); + + return true; +} + /* * Given a shift value, try to populate memnodemap[] * Returns : @@ -261,7 +600,7 @@ void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) #endif #ifdef CONFIG_NUMA - if ( !numa_off && !numa_process_nodes(start, end) ) + if ( !numa_off && numa_process_nodes(start, end) ) return; #endif diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 62afb07bc6..07df36d475 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -159,6 +159,8 @@ #define PGT_TYPE_INFO_INITIALIZER 0 #endif +paddr_t __ro_after_init mem_hotplug; + /* * Comma-separated list of hexadecimal page numbers containing bad bytes. * e.g. 'badpage=0x3f45,0x8a321'. diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index a925028ab3..9d14aed74b 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -147,6 +147,8 @@ int assign_page( /* Dump info to serial console */ void arch_dump_shared_mem_info(void); +extern paddr_t mem_hotplug; + /* * Extra fault info types which are used to further describe * the source of an access violation. diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 9da0e7d555..04ecaf7769 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -11,6 +11,7 @@ #define NUMA_NO_DISTANCE 0xFF #define MAX_NUMNODES (1 << NODES_SHIFT) +#define NR_NODE_MEMBLKS (MAX_NUMNODES * 2) #define vcpu_to_node(v) (cpu_to_node((v)->processor)) @@ -36,14 +37,16 @@ extern int compute_hash_shift(const struct node *nodes, unsigned int numnodes, const nodeid_t *nodeids); extern bool numa_off; +extern const char *numa_fw_nid_name; extern void numa_add_cpu(unsigned int cpu); extern void numa_init_array(void); extern void numa_set_node(unsigned int cpu, nodeid_t node); extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); -extern int numa_process_nodes(paddr_t start, paddr_t end); +extern void numa_fw_bad(void); extern int arch_numa_setup(const char *opt); +extern bool arch_numa_unavailable(void); extern bool arch_numa_disabled(void); extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); @@ -92,6 +95,11 @@ static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) */ extern int arch_get_ram_range(unsigned int idx, paddr_t *start, paddr_t *end); +extern bool valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); +extern bool numa_memblks_available(void); +extern bool numa_update_node_memblks(nodeid_t node, unsigned int arch_nid, + paddr_t start, paddr_t size, bool hotplug); +extern void numa_set_processor_nodes_parsed(nodeid_t node); #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 06:35:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 06:35:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443103.697567 (Exim 4.92) (envelope-from ) id 1ouT4Q-0003Yo-NR; Mon, 14 Nov 2022 06:35:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443103.697567; Mon, 14 Nov 2022 06:35:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT4Q-0003Yc-JN; Mon, 14 Nov 2022 06:35:50 +0000 Received: by outflank-mailman (input) for mailman id 443103; Mon, 14 Nov 2022 06:35:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouT4P-0000jp-9m for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 06:35:49 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2081.outbound.protection.outlook.com [40.107.20.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 92c8d0b0-63e6-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 07:35:48 +0100 (CET) Received: from DB6PR0301CA0051.eurprd03.prod.outlook.com (2603:10a6:4:54::19) by GV2PR08MB7953.eurprd08.prod.outlook.com (2603:10a6:150:ab::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 06:35:28 +0000 Received: from DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:54:cafe::cd) by DB6PR0301CA0051.outlook.office365.com (2603:10a6:4:54::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT048.mail.protection.outlook.com (100.127.142.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:27 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Mon, 14 Nov 2022 06:35:27 +0000 Received: from 2a635dd1e6b1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4567AD6B-AC80-4922-A470-46BE61EC94E1.1; Mon, 14 Nov 2022 06:35:21 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2a635dd1e6b1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 06:35:21 +0000 Received: from AM6PR05CA0008.eurprd05.prod.outlook.com (2603:10a6:20b:2e::21) by DB8PR08MB5404.eurprd08.prod.outlook.com (2603:10a6:10:117::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 06:35:12 +0000 Received: from VI1EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2e:cafe::2) by AM6PR05CA0008.outlook.office365.com (2603:10a6:20b:2e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.15 via Frontend Transport; Mon, 14 Nov 2022 06:35:12 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT040.mail.protection.outlook.com (100.127.145.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:11 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 14 Nov 2022 06:35:10 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 14 Nov 2022 06:35:09 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Mon, 14 Nov 2022 06:35:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92c8d0b0-63e6-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=O1Dtv7HDSHme0nROMVDvehr/Q2so3iCiXKez0ZKLVjFEABDDTeS6Rr7+0+ZWXKTcKucSvW8bgi+cBAXcDikonmom7zHLIaLKeh1HN8DS/i3rm/KGMMcBKlkQqzhvD7p/MKDzcHbjSALYiXPKEwrDC+x2CX0c64sKJb/5yhjQeh4FHc8Nm4WQrEsx9tEL7VVFeeOPF+Ya5IEMRryKyYM+SYf4kC8SFqqqpfWdJQM1LCp9JXsh6tjTHSmv/9RtngigAW43AFAmV6dBTjMSrK7iX3mG9ZJ1rFcH+tMnkC3tvNyoOZS/ZlNSNIsf+5IeRAF7CNywxIj5dsrMigOJZHc9Iw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u/aAu/7EVuDCZBKD/793DLiQP8lHkAQyvu0W/tbihJg=; b=U5fOZJ1DP7PErteLnRSzTtmuTOFx68qghT5IE1F+qLxidF0L8aVJUV9VgWc25fx9tnrr/ChzX8euMMEyqcLA8Hn1Gpz5sznA5uqYLfaCqXCWc+GjATNY96B2bEGxa3imS+HuT5EqcNEKbI3WZJZhjd4oiiftDkA2MexfkvZgdGGzy2aoA2S2dXnwxsrCDxQnH7UNt3rczi3Tr6uJYtKjd9x/IUbYpQaio4ESYM92SlE5e2360zhaa5vsJqzTpSxQqKhMynV5WJyZC13aWZOfoyo9+j1HN3LXjqQ7jgislbxSRXnEFvwTXXpfzcFvG1NKAmbCNLCEwqSXaDN+3LitaA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u/aAu/7EVuDCZBKD/793DLiQP8lHkAQyvu0W/tbihJg=; b=Gb3m+XvK3MzlEGXwVU46IPoqOTKxlTXgeMoukfWqCE95JSw0Oi2BCqbaRdvZMa/H2wYqQ11SuLY5qUsP1Ez1sU6ZJi+XSytUhe7e9Q61Oxr0i4NFSmTRCvwQjMIr8WO6Q7lCWkQvjeryQdiZ/lmSNX9skOQoL6AP+e3EClH8JzE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a430c7b60befda4d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X4FocFVqkNCgEShQfNgbczJCUkmMDGPHk3+0uod3sfMym/wZlg8qzGMkcwOEdZHsjuw6BTTSjQU+rAtEYWXX99GFCRLo7tVPECw1JQdIhZxLTkpqJubnV5NpavGNSJCZEzWTaSIkiJRV+i6FtBgFgi43ioWSoRj0ZMFmU20kmRIfNhBvioL6kk/y1tbSUQDiB9aRWLyxPfrwiNuzAVUt237zHfppX3IGFztO/0BAOq0YnFM+bugpmFJILY4r0Z47XyLrHQ7/Be+Ksridem4sJE7kxnDqAQC24YHLybjkH7fr6lhtzbbq5cvpMZQ/Jwdtj8YgaQj3222yiUjFSI5xBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u/aAu/7EVuDCZBKD/793DLiQP8lHkAQyvu0W/tbihJg=; b=HKePW+CUT4OFmg6uuQDtsokd1KMQHwBgZ3Lq/W8xdblxLzJPJJafmKG7Zss+x2gOdSQNjUjAXW0tnNh6fUR/wBVAM485pUXSjU/YWTRke3g1zy4o/WUhohajSxN38Y8jvCXpiQihO4VIwX5Wb4Ldri+7/xbHxNC0Tx66a99GOzIPM8PM+pEF7bToQNioxPTkob3MS5krDkPeHU2jdCyRWBsGPTUAx1gDpV7RS4XRutb8rpl/2OZEolYIZgfXDj652QxZUZTEBBT+7P1mn5IsUXW6F4lxmGc/19kdXOAPVKEK9yQyC0QWZqpe/89xA8PVmDx/jFMGS35WJrEFg1j6Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u/aAu/7EVuDCZBKD/793DLiQP8lHkAQyvu0W/tbihJg=; b=Gb3m+XvK3MzlEGXwVU46IPoqOTKxlTXgeMoukfWqCE95JSw0Oi2BCqbaRdvZMa/H2wYqQ11SuLY5qUsP1Ez1sU6ZJi+XSytUhe7e9Q61Oxr0i4NFSmTRCvwQjMIr8WO6Q7lCWkQvjeryQdiZ/lmSNX9skOQoL6AP+e3EClH8JzE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v8 4/6] xen/x86: use arch_get_ram_range to get information from E820 map Date: Mon, 14 Nov 2022 14:34:49 +0800 Message-ID: <20221114063451.473711-5-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221114063451.473711-1-wei.chen@arm.com> References: <20221114063451.473711-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT040:EE_|DB8PR08MB5404:EE_|DBAEUR03FT048:EE_|GV2PR08MB7953:EE_ X-MS-Office365-Filtering-Correlation-Id: 75da3369-81c0-4af9-96a7-08dac60a6b34 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jSLUC7kXMWJhWwGIu4uUayBv/5a62k7W7DClmv+NU/Fhab3Trpb+U1eg99q0wmXMd/GUfhFUg46R3BV48rHYE5fmBXE+j4MDGairOR0eUP0T0xloJOdbGGyQCfawEW5nTphHo4G2dxxvJRNH9snD/4i7FyZp68hD8DGuSi5EDkzbch/DFbyf/9wlWK/xYawAzcJukF0TjUcBDyjlqGerO5tEmSSLtQr2WfceTjec9hZF/WxNfPoIURTW/1mwf8JoDDuDdqBPHeT4j+swkwnWzHTPFu6p49P1U8Q53NjepstUH+HxrHggQCSBd4J3Kbg+mxoBmpeQAtVt4umkraWBVVIV8IKOPq6eygUrdhp3EQzAt23Rk9105XtEf0Wl+IKUDOPCRESqgaMKNWSY2yjUq+nbnhWYTiBayj44Leqhr4wZdnADnaVRB45aHg9A9Mun6NJ+qrLaNYPEGfc8+nZ0nFH7CvKus6qPFIZvgOH962ToIIHTBKdG7bz7fESZNJ9UoTKDvymyHMbLqbFnRLsQFwnse27qi8Pu1HY917+YlAB8afGSDtPOQyG4KN0MbAzDF6Bga6300siW5yYzSq4SQLGmX4zU2hkZS1cz8hzKB69WS2R97RCisqTQibqwwqYBXY64WXUfABpNfE6f73UeMcnDwfm0rfn0VDRH+2t8oOBZXVwDVJzkOrv59+mWga7z2XHTONzouVYvy2M7b0fPohMhRu/sEc0ZAZYYIVB5TmAcHpHVU/lmRUa+qLWcsybQwilyrpSAzZPqHaRGphWefu2ylOJZBMvC46xF8Fp4C+FZdIJ8qVNzmYZjtUcJWhVR X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(346002)(396003)(451199015)(36840700001)(40470700004)(46966006)(36860700001)(2906002)(70586007)(70206006)(4326008)(8936002)(5660300002)(41300700001)(83380400001)(44832011)(8676002)(40460700003)(40480700001)(86362001)(82740400003)(36756003)(81166007)(82310400005)(356005)(478600001)(54906003)(7696005)(6666004)(47076005)(26005)(316002)(6916009)(426003)(1076003)(186003)(2616005)(336012)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5404 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 46774657-6733-4d9b-1ac6-08dac60a61b2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LyXUbDo9X8M3a2TDNRzMFruVKwoTkzDC5qVyZKdH9cw9Pk1MdCTqRBP30jf027USuibX5ikbS+X2dCw5ZF/w5V9aL07tK7CVzZXVtjupdQ15lMyxjgDB6NTWL3iSGXySFzQVYohL0RSXb0A0TwKipIyEmfgfzwbFapqfU+SsI7W4fadYeRaHj4DNXZd/OuR0qUy9O8xwHUPxoX+VVWX3XgO7Lx1haHnaqSlLEh9jsX/6yK+Dkm9P3SHp8Jh7cJ2wgwxBlXSV1kwVRcWW35nu0UvTVOGYcFBP6cS3KLZm0T95NyOfKT9PbwNGGW8EksBD/cHABXTJI9fnV3GlGUp88rd3M1zhMxrl55eeiMPMNC2xsOkI0HEsCTFOBPghfmqb1lt7Bbg7n0B/ViOHntflWkDHSxa+MJLbu8wn+Bp6kUeaWig4Plccpp2fFIEjlgIybzYhNkQoUhEdvPei7lGqM8dnRbXnFauX+eYsF8Ltw51xBD+xBkm98kK1qJ2fm1DwiXmla1f3a/FtPKSe8oYv0Q956IlVpRZ71q8zPSC4n/yAY/vnDeOxNhCUrg9tvb8+2tUp+iHkWL8oZLAvcyMOzTvqlNXVuRfPDSLGb95S4LfqQoHjPqsqny1hFWR0kTbVmHtLPltxaFtlUvInc/UNMf8TTXeZZmDQxWxLFKcUJzpo4hk0ZKZudWwexlBWiy6xzl061aYcPsacPdamyD41KBjtHWko6w+I38JGaDpJKqcU2HlKm9UISODMAqGwMZb0Ka3o8spGT+lwWijtFco2GA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(396003)(346002)(451199015)(46966006)(36840700001)(40470700004)(41300700001)(6666004)(7696005)(26005)(86362001)(2906002)(54906003)(1076003)(426003)(336012)(186003)(6916009)(47076005)(36860700001)(478600001)(2616005)(83380400001)(316002)(4326008)(8936002)(5660300002)(40460700003)(44832011)(8676002)(81166007)(70206006)(82740400003)(70586007)(40480700001)(82310400005)(36756003)(107886003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 06:35:27.6927 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 75da3369-81c0-4af9-96a7-08dac60a6b34 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB7953 The sanity check of nodes_cover_memory is also a requirement of other architectures that support NUMA. But now, the code of nodes_cover_memory is tied to the x86 E820. In this case, we introduce arch_get_ram_range to decouple architecture specific memory map from this function. This means, other architectures like Arm can also use it to check its node and memory coverage from bootmem info. Depends arch_get_ram_range, we make nodes_cover_memory become architecture independent. We also use neutral words to replace SRAT and E820 in the print message of this function. This will to make the massage seems more common. As arch_get_ram_range use unsigned int for index, we also adjust the index in nodes_cover_memory from int to unsigned int. Signed-off-by: Wei Chen Reviewed-by: Jan Beulich --- v7 -> v8: 1. No change. v6 -> v7: 1. No change. v5 -> v6: 1. No change. v4 -> v5: 1. Add Rb. 2. Adjust the code comments. v3 -> v4: 1. Move function comment to header file. 2. Use bool for found, and add a new "err" for the return value of arch_get_ram_range. 3. Use -ENODATA instead of -EINVAL for non-RAM type ranges. v2 -> v3: 1. Rename arch_get_memory_map to arch_get_ram_range. 2. Use -ENOENT instead of -ENODEV to indicate end of memory map. 3. Add description to code comment that arch_get_ram_range returns RAM range in [start, end) format. v1 -> v2: 1. Use arch_get_memory_map to replace arch_get_memory_bank_range and arch_get_memory_bank_number. 2. Remove the !start || !end check, because caller guarantee these two pointers will not be NULL. --- xen/arch/x86/numa.c | 15 +++++++++++++++ xen/arch/x86/srat.c | 30 ++++++++++++++++++------------ xen/include/xen/numa.h | 13 +++++++++++++ 3 files changed, 46 insertions(+), 12 deletions(-) diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 90b2a22591..fa8caaa084 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -9,6 +9,7 @@ #include #include #include +#include #ifndef Dprintk #define Dprintk(x...) @@ -93,3 +94,17 @@ unsigned int __init arch_get_dma_bitsize(void) flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1) + PAGE_SHIFT, 32); } + +int __init arch_get_ram_range(unsigned int idx, paddr_t *start, paddr_t *end) +{ + if ( idx >= e820.nr_map ) + return -ENOENT; + + if ( e820.map[idx].type != E820_RAM ) + return -ENODATA; + + *start = e820.map[idx].addr; + *end = *start + e820.map[idx].size; + + return 0; +} diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index ce507dac9e..1a108a34c6 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -452,37 +452,43 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) Make sure the PXMs cover all memory. */ static int __init nodes_cover_memory(void) { - int i; + unsigned int i; - for (i = 0; i < e820.nr_map; i++) { - int j, found; + for (i = 0; ; i++) { + int err; + unsigned int j; + bool found; paddr_t start, end; - if (e820.map[i].type != E820_RAM) { - continue; - } + /* Try to loop memory map from index 0 to end to get RAM ranges. */ + err = arch_get_ram_range(i, &start, &end); - start = e820.map[i].addr; - end = e820.map[i].addr + e820.map[i].size; + /* Reached the end of the memory map? */ + if (err == -ENOENT) + break; + + /* Skip non-RAM entries. */ + if (err) + continue; do { - found = 0; + found = false; for_each_node_mask(j, memory_nodes_parsed) if (start < nodes[j].end && end > nodes[j].start) { if (start >= nodes[j].start) { start = nodes[j].end; - found = 1; + found = true; } if (end <= nodes[j].end) { end = nodes[j].start; - found = 1; + found = true; } } } while (found && start < end); if (start < end) { - printk(KERN_ERR "SRAT: No PXM for e820 range: " + printk(KERN_ERR "NUMA: No NODE for RAM range: " "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); return 0; } diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 04556f3a6f..9da0e7d555 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -80,6 +80,19 @@ static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) #define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ NODE_DATA(nid)->node_spanned_pages) +/* + * This function provides the ability for caller to get one RAM entry + * from architectural memory map by index. + * + * This function will return zero if it can return a proper RAM entry. + * Otherwise it will return -ENOENT for out of scope index, or other + * error codes, e.g. return -ENODATA for non-RAM type memory entry. + * + * Note: the range is exclusive at the end, e.g. [*start, *end). + */ +extern int arch_get_ram_range(unsigned int idx, + paddr_t *start, paddr_t *end); + #endif #endif /* _XEN_NUMA_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 06:43:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 06:43:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443117.697578 (Exim 4.92) (envelope-from ) id 1ouTC2-0005r8-FV; Mon, 14 Nov 2022 06:43:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443117.697578; Mon, 14 Nov 2022 06:43:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouTC2-0005r1-Cj; Mon, 14 Nov 2022 06:43:42 +0000 Received: by outflank-mailman (input) for mailman id 443117; Mon, 14 Nov 2022 06:43:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouTC0-0005qv-MO for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 06:43:41 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2059.outbound.protection.outlook.com [40.107.247.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab338eca-63e7-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 07:43:38 +0100 (CET) Received: from FR3P281CA0164.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::18) by VI1PR08MB10146.eurprd08.prod.outlook.com (2603:10a6:800:1cf::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 14 Nov 2022 06:43:35 +0000 Received: from VI1EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a2:cafe::ab) by FR3P281CA0164.outlook.office365.com (2603:10a6:d10:a2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 06:43:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT059.mail.protection.outlook.com (100.127.144.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 06:43:34 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Mon, 14 Nov 2022 06:43:34 +0000 Received: from 40761ba1d67d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 170F6227-2A96-4751-B2CF-51AE4B00F371.1; Mon, 14 Nov 2022 06:43:28 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 40761ba1d67d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 06:43:28 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 06:43:26 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Mon, 14 Nov 2022 06:43:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab338eca-63e7-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YnwnOBOx5/TajPcgXOeSkbPD01vKG+Irih0l7gRicd/aalaniQ4b5JipYHsdgB3YA0iqz8U+DIRUFGDRnmuqsneh2xLIRCZEN4NML3RvDwildhYh/sDHhCLNKJG+RHuzz0n+M1GSsTufTgLy33R9yPyegS5OvBwvqkrD6xTFWK0bMZr82gsdSeESJWckJT0NqX0wVEi/+USayqioGZUrcWZX/ryAZ0pJSSAiER8pVZ85byciW+oggMN+Rd4loVb7vb7k2cEHgtitVGeg5WWXmDqIr3TP0RSeqvWIjJbPN/gXz7UrJYQ308QbJqKVJD64AXcP0RTfkD5nVAQH4UgmAw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OqcPNPtm1Vh7mIugQy6ZBNavN5MJJ4FG58YXRZuZ4Yo=; b=No1pdbbw1ADYp4HWWD0uyVCLv5GrZQsdWz7IeYXuuMYDGn5ZRXhzihtMhcgoF4kjytI984LxgsYvsyWmlsI1sNTSAbrOjNY2rh3dtLgGLZmRERvDiaQWQp43lkrtaowUriXPdnftPtw2OK6ETuHBXEyhSq2GdKrH2C/qAJnJSJ/BVxy0ZfOz9tpGKOZRGxvXiJttkRT0Vd+q8KMqkkVTheMiRPB+1tU7B3dUKnsPORtdQkXjDuS2az9mHMpB4EOL4btBL8S9mAsUXGGB/phWDeHBcLXl13LIdcMHv/PU4Z/3n9dQ1VRBbtphmiyFn6HBUPyYXwqf5sFbOMUdyVNT0Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OqcPNPtm1Vh7mIugQy6ZBNavN5MJJ4FG58YXRZuZ4Yo=; b=IHR76jI7IZ1squ1sv/fv2qfO5LxikZgkGEv5VH08e0LNuTM/P/+tsCKByt074s6JSF4wWwZ7d91G/VQkdzndFoCbVzTWZRmc9MZJkKZ3koMRoDe1SHXc3sahcpnrq+MyfFUpPoQGsk6/9I7WmWzPp7CeXltkYXkIfVstbU9DH5E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R5IlCu6V8KLDSPm9rxk6vb/IHPU2wZRzOXe/vCWYc5wHFO6G6zj6hENK8l/iVvbzT0WFBUSiBu5D1uqEu4r9qxsuzlrSrtqt0KrWUSmrsin5+k+/miKBpi2p08Kx9lTYnghoL60AeuMiJTIVm1v+uGhVFsmmPMReqzT5XzaI1DJWjfvRvYu2R1QO3/WM8JdwHN1vU0EmgYey7cdd0yf6yoOIc8U0IN+WpW1VLlOJJBsQkURvQnUnPIPnGJu81oOh31sIHzkRejDszuQ9C4NPYEGyamkTF87rlL3C2lGGL6ubOkFd8zQUf2S8yqW1n1c2h/5Mj/F+vLN2d0sNY15h1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OqcPNPtm1Vh7mIugQy6ZBNavN5MJJ4FG58YXRZuZ4Yo=; b=FWllCglrsGww9JSuPRWSHumPbF+e4zNyLH88mWGJCNh7GZoyxnE0jmlRvkxilYq6bapk0mzMsdULXOao26TNlu15JEJm+Wn/pp6sF/c7tGOFACz3c3pMBdExA3L4/IIW+vcRiUOpZEUrfat5XrrAGP5raDTdWAxk35n6ye0B27zDLqAojMNKi8apadRZTtfytQKO0OZ3Fs0kxM652g7vVtEe6f6yCZfTJx1NIV1wPYCdl2dcywIuhmO1eQpepCvglN+y1FehcADdvxSDU8ydOfTujmk0U2d2j88w6nyL16x2A0XYbZzGBK2KrWUb0pBlEKCLjrDOZ2BGDPDdJBrdgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OqcPNPtm1Vh7mIugQy6ZBNavN5MJJ4FG58YXRZuZ4Yo=; b=IHR76jI7IZ1squ1sv/fv2qfO5LxikZgkGEv5VH08e0LNuTM/P/+tsCKByt074s6JSF4wWwZ7d91G/VQkdzndFoCbVzTWZRmc9MZJkKZ3koMRoDe1SHXc3sahcpnrq+MyfFUpPoQGsk6/9I7WmWzPp7CeXltkYXkIfVstbU9DH5E= From: Henry Wang To: Jim Fehlig , xen-devel CC: Jan Beulich , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Andrew Cooper , Anthony PERARD Subject: RE: vnuma_nodes missing pnode 0 Thread-Topic: vnuma_nodes missing pnode 0 Thread-Index: AQHY9iDYCXvlfuymEU2cRUBeAI3Esq49n+1wgABcSsA= Date: Mon, 14 Nov 2022 06:43:25 +0000 Message-ID: References: <2046b5fb-2533-02fe-69e8-f46174cf825d@suse.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: FF34FAFDE635BA4FA546ECD2AD9A762F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAWPR08MB8982:EE_|VI1EUR03FT059:EE_|VI1PR08MB10146:EE_ X-MS-Office365-Filtering-Correlation-Id: f5a1785c-91bc-4966-f16e-08dac60b8d81 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Na69fLpnrE8fQojUi2U2iLSOi30WQ4gdKWAEQTQeRKEOTQrQCyO+/FJvh2qMs4b5Av95vwjwNbJu5hAW6+ucvmTsKaPdEqTAyVqRft1XBwA6Hj96J7ytsMLgjewhrjg8XV2ktGWt3/3u/WU62kceIJd10xZKmlTTOJINiPagFx9T0liOZFcJTaBMtPYiMcR1U7D/K1OOsJA1txSaE1KgZcqOxTZljPdHGYEGHNvrtO/yTlIDYFBzB1JTkIE7Hf+5wq+aqiWjTS/L4kN/h9DNE0EjO8sqQUmQGJ44524SvK2aa5rJ0NwhNV/Y3Cx2ySgLApPXzhOGVpz5TAWPxp8Cs6O2TXs2p+U/jJswdGxvjjMcwXHZTK6VaTYGVSZPPuhulhsKslEFCwZzXF4VUEAvqVPn9jSRUghYHiJZCtiqJWj9DmJIQkidoHDeSJ5sPu37cBY+dGsKhGf1xAj8nMb/mkar7PCtEgNR/F8xuuWlspCuFutXy4qV/IhrCO4uz0JuH5XIz5xJeQpwYaMRVQw1OFCr2iab5f6jFgRL6+70FPk2nkF1bxQ/2Rchz0PxaEQdnCdYGnigG2OeF0q59jPulxsLCV4aXrZmEEOC6eFUzv13RYc/HYKcPkhT+PK510A1rRKv8PN+ondAYTDYVeFNyUPcJJ4sf0dbPTMqsCAVZtJsRY4tpX7rF7wkmdY774eh1UjIKtnPE8yXxCuT7nN21EBH7n/J5S46SdYzJrf877OX90LYQZJW28I5Vue4N8V4P1IrbjZqbnKLkiISCJtkBg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(136003)(376002)(39860400002)(451199015)(83380400001)(2940100002)(38070700005)(186003)(38100700002)(122000001)(2906002)(8936002)(52536014)(55016003)(478600001)(26005)(6506007)(5660300002)(9686003)(7696005)(64756008)(4326008)(8676002)(7116003)(66556008)(66476007)(71200400001)(76116006)(66946007)(41300700001)(66446008)(110136005)(316002)(54906003)(33656002)(558084003)(86362001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB8982 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 99d0b0ae-0461-4b65-cac8-08dac60b8816 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aBUVdSv+FqxrZ8C8PeV7L8G3VC3RxT3ppvPCdqrE0CDDCheWAw/cuSuvhEpTZqKUIQpfnwTBwRnOednkx1XasCH2uCoYS8vFeCLC8bPxkptOWUDaN8jfBYMhJ7i7j0tA5ZNWaYbrtjaCRiuwTOhUFknPQAxWofFV4csxTHlZfkU7rN5V9rRHYTzTzkzxy50LGqRLtpbG8U2LTZQe6qh5np5DgfKLQuPTPG7HGLRlWaZWcHIT8NmcHs/CHK2X+OOmpiwKmRKxv8GTpqrSzaNgYrLMyJK/pr8KgDKVkty56ZEPXMkXsL3fJwAUADZqM6XkqqLwR8uR6hbEG8gSu2aOSBnP4HgALILf/71U9ad360B9XQMOy1QiDZayr+D2Z1jHm7oLiDRXs5nwa1E4edNwAhyxj2kNmhF7/BGaUE4ppD8ZFQqSQi02uHuTYv7yBoxHALIC+mS/QvnHsKGFoMxBsbUPpgXZ1Il3zl5LK2t2H1RlLnw623K+ighxW8VTFcgWq7TTZyMAuc3ORELG6zY3PNc7VC02VuiwxRgnDAzQCyIXVG+GJRz2JnhjOOOBZWCULV2Uqbq2P354Ss3aVwg8h//Dgd3stAarA1GVhQ1a4yB4ckmLcjUAMeFV7tQnwi0cmkw3mDi5ndMuwqteFrditEU3Uai0nWmW9hv/cTKIC1ApkiAGfoV0+FOQEBsrYo0hj9jiK0p8SIIKbKR/cbK+lxb7mLtsgCGLjOOp6NzVuYz+546CoaDjZmnhbsGOUAQ7 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(136003)(39850400004)(451199015)(36840700001)(46966006)(9686003)(54906003)(41300700001)(70586007)(2906002)(186003)(8936002)(70206006)(356005)(7116003)(52536014)(316002)(82740400003)(36860700001)(107886003)(478600001)(110136005)(2940100002)(26005)(33656002)(336012)(8676002)(40480700001)(47076005)(6506007)(83380400001)(86362001)(4326008)(81166007)(558084003)(55016003)(7696005)(5660300002)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 06:43:34.6296 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f5a1785c-91bc-4966-f16e-08dac60b8d81 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB10146 U29ycnksIG1pc3NlZCBBbnRob255IChUaGUgdG9vbHN0YWNrIG1haW50YWluZXIpLiBBbHNvIGFk ZGVkIGhpbQ0KdG8gdGhpcyB0aHJlYWQuDQoNCj4gKEFkZCB4ODYgbWFpbnRhaW5lcnMgZm9yIG1v cmUgdmlzaWJpbGl0eSkNCj4gDQo+IEhpIHg4NiBtYWludGFpbmVycywNCj4gDQo+IFNpbmNlIHRo aXMgcmVwb3J0IG1pZ2h0IGJlIHJlbGF0ZWQgd2l0aCB0aGUgcmVsZWFzZSwgaWYgeW91IGhhdmUg dGltZSwNCj4gcGxlYXNlIGhhdmUgYSBsb29rLiBUaGFuayB5b3UgdmVyeSBtdWNoLg0KPiANCj4g S2luZCByZWdhcmRzLA0KPiBIZW5yeQ0K From xen-devel-bounces@lists.xenproject.org Mon Nov 14 07:10:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 07:10:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443134.697589 (Exim 4.92) (envelope-from ) id 1ouTbx-0001Bi-Jb; Mon, 14 Nov 2022 07:10:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443134.697589; Mon, 14 Nov 2022 07:10:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouTbx-0001Bb-Gx; Mon, 14 Nov 2022 07:10:29 +0000 Received: by outflank-mailman (input) for mailman id 443134; Mon, 14 Nov 2022 07:10:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouTbx-0001BV-1K for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 07:10:29 +0000 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 684a74c2-63eb-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 08:10:26 +0100 (CET) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4N9gRl72F2zmVpJ; Mon, 14 Nov 2022 15:09:55 +0800 (CST) Received: from huawei.com (10.67.175.83) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 14 Nov 2022 15:10:15 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 684a74c2-63eb-11ed-91b6-6bf2151ebd3b From: ruanjinjie To: , , , , CC: Subject: [PATCH] xen: add missing free_irq() in error path Date: Mon, 14 Nov 2022 15:07:02 +0800 Message-ID: <20221114070702.1887144-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.67.175.83] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected free_irq() is missing in case of error, fix that. Signed-off-by: ruanjinjie --- drivers/xen/platform-pci.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c index 18f0ed8b1f93..6ebd819338ec 100644 --- a/drivers/xen/platform-pci.c +++ b/drivers/xen/platform-pci.c @@ -144,7 +144,7 @@ static int platform_pci_probe(struct pci_dev *pdev, if (ret) { dev_warn(&pdev->dev, "Unable to set the evtchn callback " "err=%d\n", ret); - goto out; + goto irq_out; } } @@ -152,13 +152,16 @@ static int platform_pci_probe(struct pci_dev *pdev, grant_frames = alloc_xen_mmio(PAGE_SIZE * max_nr_gframes); ret = gnttab_setup_auto_xlat_frames(grant_frames); if (ret) - goto out; + goto irq_out; ret = gnttab_init(); if (ret) goto grant_out; return 0; grant_out: gnttab_free_auto_xlat_frames(); +irq_out: + if (!xen_have_vector_callback) + free_irq(pdev->irq, pdev); out: pci_release_region(pdev, 0); mem_out: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 07:30:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 07:30:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443140.697599 (Exim 4.92) (envelope-from ) id 1ouTvL-0003qU-5I; Mon, 14 Nov 2022 07:30:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443140.697599; Mon, 14 Nov 2022 07:30:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouTvL-0003qN-2h; Mon, 14 Nov 2022 07:30:31 +0000 Received: by outflank-mailman (input) for mailman id 443140; Mon, 14 Nov 2022 07:30:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouTvJ-0003qH-SV for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 07:30:30 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140072.outbound.protection.outlook.com [40.107.14.72]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 361e5973-63ee-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 08:30:28 +0100 (CET) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AS4PR04MB9266.eurprd04.prod.outlook.com (2603:10a6:20b:4e1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 07:30:25 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5%3]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 07:30:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 361e5973-63ee-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BzhfiW8cvj2XLtrou9Z6utWMzkZEUSOTQeO20JzxE4N4+75rFnd2KbrXhSmKfCJOIjjYy/UEkVF4Zuzh3/lrmM72VU55zXX7h3LeiIs6cB1Nm3UUwh4PAvKBNSCD0Jr4MvYUy05HzWlDRqKqgPR/LCZENZSGXxXxagVYynWHoQfCCs9o4LyhBNGHbzRp4TdLA9TWqPslArdWMgu1xbZYinh14AyWM632njxBg2YjdNXis3DuVqer6JdIxKd7mhYYgFf/HmPRUAq5K5I28xm3+ootmTCYP9lOEhVVQ4aWBW/pcXbuLKjkugiOzGr3qna7YQ1xARGzHLrFZcmOW2NmBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ta4/jXh/7sjcIT9Cu/F5RZOkPaSpkFsBebUjs20bUxc=; b=ah1+SS5/kYmU1akKktdEDP9p3At1l2iHKB3Cjl+7/i7qGZNThnra5EIsmERRICZS+yIFl0NLy1Kt630wus8JPsy2iOUV7pMKFXPmbg5uzqWf4yI3fRPIoEv5LbCdOZ/Im90jMfEu8upN4s8qAlWpBXz/eM+YbwmNMA3M/FMzZoC4y20FiW3McANZRaPydarvPonmG0K0fZnzVgPwWToaQY3gz3vGTCQuW3zRiFXmo7elWhCVkKj7Tf7VRrZmBQ32kukjIs3tTo2wk0n+VrMcLj6Zh1Wr1S71F/h8p96dlZKAqvq/UvIU3ZLPBRk6+AOkA0oWbG798KDY2Gcrz2ULYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ta4/jXh/7sjcIT9Cu/F5RZOkPaSpkFsBebUjs20bUxc=; b=2sIKQDLEkcP+4bexwG6M6/xt2BK+VXK4qNZ4PAyufAnuWAgoSAB8ZJAD1tfYxHxuy99HhMCNDuxKHJiPY1Bklp2eBTIadQ5dJbC4aqHX+FtcBKXqKu6OM7vNT8eq4QoNLerKhp1juDCoUPsu00k1NCGmjQT6FZO8R3lzyogQnprYIXNMF5OCrgvVKoqKz46czmp313ONLC+M+bJPz+KPMUiprfKxV3NXmAGQwP39/VkjH1WaYQOj0oX4cEfXGv9BZIDe4yFRY/aPWgALCDwa8ZblreF+UnWIaTqTkJdehuPAiMLgXDyRO0Wp02GH9a1VJN0osgWxRT6LKaugYpoxig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 14 Nov 2022 08:30:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair To: Stefano Stabellini Cc: Luca Fancellu , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , "xen-devel@lists.xenproject.org" , Anthony Perard References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> <7d56c33d-4b03-9aa1-6abc-45a8ad41caca@suse.com> <2E0BFEFC-5BEE-4F8B-BD9E-94CB9A5B2BC9@arm.com> <9CE2A214-2D64-4BEC-A78B-393BF7AEDD9D@arm.com> <826eb0df-fb52-fa25-c908-977285a6ec8b@suse.com> Content-Language: en-US From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::18) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AS4PR04MB9266:EE_ X-MS-Office365-Filtering-Correlation-Id: efe9e614-9c0e-4c07-608b-08dac61218b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8YqIRR2MZGCn9nRaBspTTlLfBYUCcVJWMUMr5c7UHVZSVfal6r8XET04DGEamGkCuwrDTHipiVOfdotSUzibGqevAYRbSjPQXLByLXMjBjmnWp768rAavynSSFfBZ9LadWwHUb4tvusrLWNBwuQ350wni27d/Z4nC77wFWHLRoZ1uZrx4AXtr7NTp15pQ6wu9C+PtUy0HtszRt8Jx36KidMnwN66Sn4fbgsVybsConD50EXWFRVFlteffqrlBrFXsu37RcIkbXEEhHI6kRHLUEUH+XTDCKrO/cRf/2q+SryLf++ttFQvWpJLkwTTPc7nh9SCoy15eNQ6ct5UC07QaaL+fkJXGP2cOsixjMuV8fpMtGfTAzAURL2TQPf+heogwVM2AX7bDTtk15gZ8rpVfBAxub7DtJjWrDQEIRp7/h11wvcDwRpF3JjpwsXI5cSma915Lj7hKPD+/uoAHX6CiiHxn1mpRMI6IorPeqSsJSUV61iwXJKMWjXYQQNpAp3Ax/vVVH/lom72ZBSqkxaCQutUxUjsHa7xZNOV94/vtY6Z3OYL8+lcK8nhFMmMbz3iuChjx+oXTTkaYY4jIeqlcaVZ1nTACjA/wlTKugfrAV8GxU1F/daE9C7bqsVWTM4peWkvpOq0zu7oaRrETtbGb5hRznTI9Lbl3hMkzZtw+GQIjIWUKzpdTUXtyLr1OZOUoxnCom+tldTKEy1oFHmahrXeeZSZF5OGjlK7s5emhchjDtdH39l6nF/r/2Yqaog6DNpJIB39ga8QsEeYpW6eGeF3W6mNZLL7WkjSZLSplrg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(136003)(396003)(366004)(376002)(451199015)(31686004)(7416002)(8936002)(5660300002)(8676002)(66899015)(66476007)(41300700001)(4326008)(66556008)(66946007)(316002)(6916009)(54906003)(36756003)(6486002)(6512007)(6506007)(26005)(478600001)(31696002)(53546011)(2616005)(186003)(2906002)(83380400001)(38100700002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0xNVWZHc3NCNkRKbXdUZnB6dkp1WksyVDU5REhCamVXZENiaHBZZHJGTVVS?= =?utf-8?B?MTgvRyt0bTFoMDNLd3JsZnRYZm16LzVlNjNURDBkY29scjJ2OXA1ZWhBWTFC?= =?utf-8?B?dkVjUVBHQUZ6Yld1enEzaHE5aVdheWd1ekI4b1BVdkY2NSttUHF2YVhmdWdS?= =?utf-8?B?YzdGODF2cVVRSmVpdlNHQW1aRUdvaFI5VHZhZFg4c0JOSVhIdW95bEZ0azl2?= =?utf-8?B?TGhMT0IyckN2bWYyNXBxQnFyNFpNTmthOE1LdFROVnA3dC8rbk9ZSnQ2aU9m?= =?utf-8?B?SGlaSGkrZ3Q1V0xqL2NSdUtzY1craUl2Ky9Wc0xhVDFLODdEcXhUbGcyNERE?= =?utf-8?B?UklSOHRENWhBS1h2NGlPVG1BQ01GMkczTHQ1dkkybzI5YTkwZkRBSFZuWm1G?= =?utf-8?B?RFR3cHZjcEMzVTViall6THprb0pYcVNuM2xENDd4OE5Jdmd2QUd5elhZRW5a?= =?utf-8?B?eGxiQXFPNkx1QUg3WGQ4a0c1bnRlMHRMTzM3WjdQeXFpOU5JeUgxTkluYThY?= =?utf-8?B?VUlWd25KMXk0dWc4ZHg2UzUwRWxSajlML2ViTURiVU5LYkVjVy9jOUczYXA4?= =?utf-8?B?dENMVnFjSnVJUFlvcmgzeEpOa25KVU4zVmhVUitOK3BIQkQ1S2hUaE8xeFg1?= =?utf-8?B?a0FmZGJoNVRQUUJ3eVV4Ry9IYXkrTnl3eFdoOXBrUGd1bExxeW9SN05tZ21x?= =?utf-8?B?WjQ3UDFLSjF5anMreGQ5SVgzK25YUk5uV2gvUEJwdFVoVzc2bnNhTmlyQmo3?= =?utf-8?B?UmUzUVpDdExkVHZGZklRQmRVcUM4RGJmd0dxdVd4SHg0dXN3cEVRY1hQOWdS?= =?utf-8?B?VGs1OHNHRS9vajU3aGxZakpnSVdsRkh3UElGWU1ydlc3WnlwQ3RmaHVRc3NX?= =?utf-8?B?RG55bzVtTVRzT1JXZlFqVGcrWDIzYnJFV2xEa3k3NThLTG8xSktHVk13SUx5?= =?utf-8?B?Qjh5VXJUUFlxazRNbytxV2svZWg4RXlpWGVrVi8zS0FBMWZidGxwOEtPQTd6?= =?utf-8?B?eTIyb01xbnFtbHhWVXc2K1Mvc2pndUhKSnd3d2pLSlM1WUdSdzJYaU1zalJq?= =?utf-8?B?RE4zVExCM0d1VnVRSFRRK1RxWkl0TGJXNlcvdzg4SGJGOTd0ay9ObU9ramhj?= =?utf-8?B?RGhnbDcrNUx0b0Z6QWNMeThsdGZ3YW5MdGppa3NYZTJyQmpLNGVnSjFEelRa?= =?utf-8?B?QVByeUtmeXl3Y2RxOXFkRkozVFhLTFJwNHJOcEttd0RPdEVqcUVvTjJ6NUFk?= =?utf-8?B?dTdZOWFsU3JsdzRLU2NBb05aRGtEZ0g4NnlLUi8rU2tpTW9EbDc2c1lyWDhs?= =?utf-8?B?bzhIMkdoRzl6eHdmMkZSVDI4dnk2Tnl0UXF3QTAzQ0JRSnBXTU1uQVQ0TTVp?= =?utf-8?B?bU41VlFQVWVUUVNwWHA2UGIwRjFKTXJMSTJvRTdkRmY4WFZySjdNcTFEYjJa?= =?utf-8?B?OTR6aXd4YVhoTnNMeVRjSlY5UXFqWStGN0Nld3djNjhEd21MNGhkc29kZUFX?= =?utf-8?B?L1NYSFFDUlF0T2pibHRxSWVxWTd5em9XamtEbi9HaUxEelJpZkZVbTdNcW1C?= =?utf-8?B?R2xiSGpTemQ2RTZzY1FxMHVpRXJWME1RMWRIdnZDOTZKRHllYlJJa3NpV205?= =?utf-8?B?akFhZ2IwS2J5bEZMTUhaNDlubGtpVWI2YkcwbUtwaUl0YjYycWRDT0pPMDhR?= =?utf-8?B?NGlUd05yWWZwVytrdkcvclQyekY4Yk1yL2lpQ3cwTzlpaGtKbFlDeWJUNkc4?= =?utf-8?B?SFFtb2E3djJTZXBHTEZRMHduWmg4ZmxEeEtTdGtNTklkZHZPSFNGYkVWM1h2?= =?utf-8?B?VzZyTlBtR3YwVzJGUjBNeEFPcVRONTRMWmVQOTYrSE40MGZQZmhiZGNWOGNX?= =?utf-8?B?OVJWNDRqc1YrajFIQjA3VUxHamlVMWN4QXdnclQ0YXBMWWVwZmZiL3hHMWo2?= =?utf-8?B?V2RQMS93dmFUMDVCM1dPSFluSndkV3lhelhDUEo2ZjlHWm9NMFNHZDNRaXA5?= =?utf-8?B?bnVYNlVEN2xKVytFS3hGVVdPbXFQOGFHVEcwTEkxVDBtSUE1NlNQbWwxK1Zr?= =?utf-8?B?aWdUa1M0MHQ1VkVQOTRMWjRGMmFXQkhzUm9QbXdvSWlKUE5leFU2djFzQlZC?= =?utf-8?Q?/FTaQi/Dl+Kg9kCrV5XxzVvW8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: efe9e614-9c0e-4c07-608b-08dac61218b3 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 07:30:25.4341 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yF0OXIk3A5fa6n56KHlwymrOq/ZOSrIyr6XQ2v100Tx50S+Fag5cbcdJgNlEifE4UtfTr8vtULfno5or8l9x7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9266 On 11.11.2022 21:52, Stefano Stabellini wrote: > On Fri, 11 Nov 2022, Jan Beulich wrote: >> On 11.11.2022 11:42, Luca Fancellu wrote: >>>> On 9 Nov 2022, at 10:36, Jan Beulich wrote: >>>> On 09.11.2022 11:08, Luca Fancellu wrote: >>>>>>> On 07.11.2022 11:47, Luca Fancellu wrote: >>>>>>> Now analysis-build-coverity will be called, the best match is analysis-build-%, so again the dependency >>>>>>> which is analysis-parse-tags-%, will be translated to analysis-parse-tags-coverity. >>>>>>> >>>>>>> Now analysis-parse-tags-coverity will be called, the best match is analysis-parse-tags-%, so the % will >>>>>>> Have the ‘coverity’ value and in the dependency we will have $(objtree)/%.sed -> $(objtree)/coverity.sed. >>>>>>> >>>>>>> Looking for $(objtree)/coverity.sed the best match is $(objtree)/%.sed, which will have $(JUSTIFICATION_FILES) >>>>>>> and the python script in the dependency, here we will use the second expansion to solve >>>>>>> $(XEN_ROOT)/docs/misra/false-positive-$$*.json in $(XEN_ROOT)/docs/misra/false-positive-coverity.json >>>>>>> >>>>>>> So now after analysis-parse-tags-coverity has ended its dependency it will start with its recipe, after it finishes, >>>>>>> the recipe of analysis-build-coverity will start and it will call make to actually build Xen. >>>>>> >>>>>> Okay, I see now - this building of Xen really _is_ independent of the >>>>>> checker chosen. I'm not sure though whether it is a good idea to >>>>>> integrate all this, including ... >>>>>> >>>>>>> After the build finishes, if the status is good, the analysis-build-coverity has finished and the _analysis-coverity >>>>>>> recipe can now run, it will call make with the analysis-clean target, restoring any .{c,h}.safparse to .{c,h}. >>>>>> >>>>>> ... the subsequent cleaning. The state of the _source_ tree after a >>>>>> build failure would be different from that after a successful build. >>>>>> Personally I consider this at best surprising. >>>>>> >>>>>> I wonder whether instead there could be a shell(?) script driving a >>>>>> sequence of make invocations, leaving the new make goals all be self- >>>>>> contained. Such a script could revert the source tree to its original >>>>>> state even upon build failure by default, with an option allowing to >>>>>> suppress this behavior. >>>>> >>>>> Instead of adding another tool, so another layer to the overall system, I would be more willing to add documentation >>>>> about this process, explaining how to use the analysis-* build targets, what to expect after a successful run and what >>>>> to expect after a failure. >>>>> >>>>> What do you think? >>>> >>>> Personally I'd prefer make goals to behave as such, with no surprises. >>> >>> The analysis-* goal requires a build step, otherwise no analysis can be performed by the analysis tools, so I hope we agree >>> we need to integrate that step as a dependency of the analysis-*. >> >> No, I'm afraid we don't agree. But like said for another piece we didn't >> initially agree on - if others think what you propose is fine, so be it. >> I'm specifically adding Anthony to Cc, as he's been working on make rules >> the most of all of us in the recent past. >> >>> I understand that the analysis-clean might be a “surprise” if not well documented, this comes from the need to substitute the >>> tags in the tree (to keep the real path in the report log) and to revert them back at the end of the analysis. >>> >>> So, such script should just mask to the user the analysis-clean invocation in case of errors (with an option to don’t do that)? >> >> Hmm, here you're saying "such script", which looks to not fit with the >> earlier part of your reply above. (Just in case that's what I was to read >> out of this: I wouldn't see value in a script which existed _solely_ to >> make the cleaning conditional.) >> >> Did you consider the alternative approach of copying the tree, altering >> it (while or after copying), running the build there, pulling out the >> result files, and delete the entire copy? Such a model would likely get >> away without introducing surprising make rules. > > Another, maybe simpler idea: what if the build step is not a dependency > of the analysis-* goals? > > Basically, the user is supposed to: > > 1) call analysis-parse-tags-* > 2) build Xen (in any way they like) > 3) call analysis-clean Well, that's exactly what I've been proposing, with the (optional) addition of a small (shell) script doing all of the three for ... > Making steps 1-3 into a single step is slightly more convenient for the > user but the downside is that dealing with build errors becomes > problematic. > > On the other hand, if we let the user call steps 1-3 by hand > individually, it is slightly less convenient for the user but they can > more easily deal with any build error and sophisticated build > configurations. ... convenience. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 14 07:58:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 07:58:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443145.697610 (Exim 4.92) (envelope-from ) id 1ouUMT-0006ky-Bt; Mon, 14 Nov 2022 07:58:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443145.697610; Mon, 14 Nov 2022 07:58:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUMT-0006kr-9I; Mon, 14 Nov 2022 07:58:33 +0000 Received: by outflank-mailman (input) for mailman id 443145; Mon, 14 Nov 2022 07:58:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUMR-0006kj-Ha for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 07:58:31 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2050.outbound.protection.outlook.com [40.107.20.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 20849254-63f2-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 08:58:30 +0100 (CET) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM9PR04MB8356.eurprd04.prod.outlook.com (2603:10a6:20b:3b4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Mon, 14 Nov 2022 07:58:28 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5%3]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 07:58:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20849254-63f2-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aU9RsyA4N/4EilHcStXHrLp05X+g+Y5uEbEHhlTg0YjuugdmKHWdMOuINem+Qb/z/pJMTZJ0te6IXEBVzfvmn2/XdENKczvaKCCrn8Lh5wx11CTF5gGkw+Uo12psl5YhR4GBHLC8WdZsDlFRn9pfYgOeI6+diw/tWwj278vo0qDgfjssz+VyfJnzbAKatWy+pBtDid8KR1uBsQyr4oUgfttrSOx7HeVYXpDqivkstr+gfnHvSxnzxBxdnk4qr/K+DuxCyleXz7wJo8QQ5rRz1H0vkRHJVRqb7ETuJbgbaDKXmprnJuRGhiZMhrcJv0nBGQH4X+LeCUcooraYMPqNVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nz+m1dnv0aD4k84yhtrbB9jb2qGDUFOyLj/d3nJlj3Y=; b=hl9wUhbZF5Ca3I4j3nQvrZ90FMRLnBc4qpXyXqE00t797guQ3O0eqY1SqtZFxL9BIt5Z229lCQWEYVKQMnmjkbRUKhXivS0C2XVHrnuJTg6tDMfI6HbZLnh3XeaNuZ9Y4vdtTV2ugK/3dBfwGuRVabkVpsyZZgrK4oFgbZOvxXz4hxv8DmB3lsWsCt/ulz/DIrqf+rnr2tY3Ir9HqX+kqwQlrmvOTsIK/zxDI7TA6HbBglSOJUwVCU9BQ/oXuyVTwiVRUNqTnrw1wRyxJZ38ZF0ZfZ2tC7m9o0ulmQRO39ESNljQrVxoym8ehj6ONzdQFgFQVzajc8SroztZm/m5sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nz+m1dnv0aD4k84yhtrbB9jb2qGDUFOyLj/d3nJlj3Y=; b=mk00cjjpH0js10VasOhgWt5U9h8bOFAHKg1caabGyjbsJhJnevZkOM1BGWlckHX2fiT1pJzjsmZxEOMn3W8opUuC2Tlq55OJ2Ux2r3YSHaCtbqNHAaSfz4k/Aqq8YU9PHuDYp02Wm+WK8wrXZzI4J+zW72a+ympu2UxM80/pBef8ZAXsA3pZJM4m/jhT/onYXJxnJxtshuRWoyLzD9LoeaqTgYQTr+MSfMwmUclcRUjrgFPapwq+OAoDCqLNMs2aMr4jOuqlEPIQP8p2mzmHYe1WMnQCe3T5oaJFbWyEVJOAx08Qpb2U8fDxoTWrqGGGNuqxBdScbTDojEWW5WEa3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 14 Nov 2022 08:58:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options To: Andrew Cooper Cc: "Henry.Wang@arm.com" , Paul Durrant , Wei Liu , Jun Nakajima , Kevin Tian , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <20221104161815.38007-1-roger.pau@citrix.com> <69841767-ccc4-5eeb-6e9c-d59dfb197ea5@citrix.com> <8e52a065-0141-f75c-03e8-e9ceb18a0aa1@suse.com> <4d0edf44-bb7c-85d9-0890-79c999428ef6@citrix.com> Content-Language: en-US From: Jan Beulich In-Reply-To: <4d0edf44-bb7c-85d9-0890-79c999428ef6@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P192CA0035.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::48) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AM9PR04MB8356:EE_ X-MS-Office365-Filtering-Correlation-Id: e5342b64-7bbe-4e0d-84d7-08dac616037c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7JlmAOBlF7o3R+K3g7hI+zutnFsEtlkVyKqHT4n1BPI/UBpX9P/8P//LxR47J9jpIfuX1Ky6I5ApkwnBYZJk/ry1CoFenZkcK/iJFEYeHYg48XSh51QG4+ag2lEwHYeOgsymrKjZEgPLwWcAi5b968Sk31xlQE5VGNQR3D48fs975MgHgyPGwaCXJN1GeiRR3XWjdhYzj84jamSP38InV69V7STGZWJ2YJLw7xUAFe/19PTEnZ6/BRgGjyYo1oelEONrrOySZF37ye5oGNGvV1pPEuaCoqL25n3ps8vK6R6mDSMgXmT4YvQZZR/FNpYswb4swh+8J3iA6BmU4jcKm7mC89+DC+9fMsauo10vz4HVuQEca270LChFQA0TWdyvMydmli5LP89RGz0fGyI6qSu7hRigmVrdhI9vugzhkStuR9msRjK5hjDVd/9MEINWbLEAmRrF93HL1EDwJg5sZJxvrR6OmRohIFmFtNgPtBI/VzmnrhBvKfqtryzCU0CP0xr0I2IMuO7FhPOFxVSzlUz+9k04RJeHgkBxulibnVWCfImN5cFr7WWvyADenKO/fcoksSBZP9UUFCVZeoc35TzTnsS1mRRaIakuDuE/ElhKp8iKlzXnsoy1eLjK/3JD+GTAeBWq6BwxFe5rLWpkhgOlajHBCAHQ0MEA/uw+EIXVd9SoSzTo+Kok5ILs6YQMikkOGFznU9oFS34x68/DA7DKu1uKQ8gr7DdmM0yPbnxT/5ljn11SNMDquuBJQeX44w2hb99LuV1DiT0U9yladvfJXoGvodeZ0xZrdxyz604= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(39860400002)(396003)(346002)(366004)(451199015)(38100700002)(2616005)(6506007)(31696002)(86362001)(53546011)(186003)(6512007)(26005)(6916009)(54906003)(66476007)(66556008)(316002)(6486002)(8676002)(478600001)(4326008)(41300700001)(2906002)(5660300002)(83380400001)(36756003)(66946007)(8936002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFRPQWl0aUQ0eCt6YlVtT1BmY3dOcC9ud05kQnVFenM2MUZ4b21nSTZxMjN1?= =?utf-8?B?TDMyVUEzcUZCNE94YU52T0xUckVoMXRLdldyMTJQQ2JjRjRteEo0cGRKNGwy?= =?utf-8?B?SEFyY29vRXlEbkZNRXVwakpuOTNpdDRlQjYzM05aUTh0VEEvVm54WlAxRFJP?= =?utf-8?B?eXlRdTYrL2xwZGducnpwRC93bE0zNEFXL3M2c0VKcGRLdTgzNDV0K3ZkLy83?= =?utf-8?B?dEVWeXFKZVEwNXpmRTZuMXhVTFdFQzBsVldyVk0xdFk4d3B1cVhRbEgxeThU?= =?utf-8?B?T2t6S1R5NExiNWQvNFlCMDVEVUxCN2paeFFBa1laWlA4MXhMSGxPQ3JndGZl?= =?utf-8?B?clRLUXJFc3ZxOFNXUWsvUjJwa2tMQTlQS002TVdjd2NMaWR6cGtHNVRJd3B6?= =?utf-8?B?TUJEckhiK2g2TjlSL1hhcngzTUdEZnRvUW9qTjdaZXVwSkFzK3luU1FjN0RV?= =?utf-8?B?bWFOQm5QdjRzRGZNVlo4YnVLemE5cDdaRVpxc2xJTzYwV0tOTmJHTmpOMlZa?= =?utf-8?B?M2E5SS9McEIwb2xmeUU0VEFZdGhVSFBzVFZib2Fsb1gzMHR4M3BFOWliNldN?= =?utf-8?B?a2tUTGxKTEdYeTZvU1dNR2tIVzBPaHJ3U1NQaDlyaE1VNDFRQTZsVGdrWW5z?= =?utf-8?B?c0RVRndpYzBzVDVzOFNreTdPS2pvdHZTSHpXdElLZlBiajd0NE02eGdFL1Yx?= =?utf-8?B?Yjc3YkZQM2tFYkxtMzZ0ZHVNcXE1S1Arb1NwRjB5RXV1MW5BVktQVEIwamJ3?= =?utf-8?B?cDBVVkxVVDRoOTUzbzZITGxYMmo4MEphdVFFNzR0cFRBMHNoMlQ5NTlJMkxk?= =?utf-8?B?WFNBWUM3TWM2TUxHT3ZzY3Q2K1MxZS9hRE5qMnZLWjZvdXFvRERoc211eVBz?= =?utf-8?B?NXltNy9ldGJqeThmV1VLZG9SRGdoMGdUWld5TTNFcWNrSjJNVlNKb0d4Y0pI?= =?utf-8?B?cFQ1R3I0cDdidWZ6eU1FVmNHY3ZIV2lPQ1hZK0tvVFg1Rm5IbDRyMDFmSHJ1?= =?utf-8?B?bkM5K1B0Wk1iMS9oVkpieXZFMTdMV20xM0o2RjlYRit0ejRGYVRhZ1NlTlNI?= =?utf-8?B?ZmppVUFHZDNjOFR6SnRkQy9DOE02SEtpdlVFZnFzdkE0aEk1NllxVElkRE5F?= =?utf-8?B?YmFNUFc5R0t3RlV6MkNXWkNydk4wZ1ljTHcyc2VQenE1K2RVY01WNnZDNkc3?= =?utf-8?B?aDVrRUxaUDFrMzFMOEZRNTJDbUxGbTJUOXBSRmJpSGlHWnpqMHdLN1Ria3NG?= =?utf-8?B?SEVpa2h3cUd1QlR0djZDMnRFUno0QkExajg1NEp0U3FmZUwvais4bytmUFF4?= =?utf-8?B?QVplYnJ2eUlsa1ZUSzErMmJaeXkvaXdHUTdRc0FITVMvbUdxMTE1VG84OHIx?= =?utf-8?B?OUVxbSt2eHUyeU15SjBOSXRCd0o1VWEzbFMxRlRTdU1TYXJYcStFSTlkTGh0?= =?utf-8?B?UVk5TmEvNkFha0o3WitVU1hyWWFQSVl4RkNqZUQzbEorREpLdlErSTVTcDdY?= =?utf-8?B?MFkvREV6MjFHQ1Z5QmM4bzFXRWQydDJHa3BTeHVNUHUzM3N5QzAvSXFYQ0Y4?= =?utf-8?B?ZjdpQk5BNTZXYlpRcm1UL0ZncXg0MjJDYlZjQkRBMi9rZzdhcDFiSkxhakgv?= =?utf-8?B?a29WMll5TFdhMjRwSVVGMmEwRzM4YjVlVzBqck1XdlJDZkRCUjZMVTFCMkhp?= =?utf-8?B?NEtLVUNpcTB6RW5XWDZJbnpDby96WnBzRXpGUXk5UFdYSnk4cTIzU1VTbmk1?= =?utf-8?B?UmtWWmhOR3U1WllkdTNqbjcvSy91Y0JPYktQeENZaC9yWmVjOHVyUk90aHlj?= =?utf-8?B?cndjUGp1Qkp0UjU3eXd4MitCOUdMTWFTNTdmRUQwUWlVSi9YMDJ0TzQ4eTdo?= =?utf-8?B?RlRoWm5CNTlYNStJN0RQS3lKa2VyZnhlUTJjTFpqUFQyVTVhRlk2L293S1o4?= =?utf-8?B?NXlPT2tSZTZMeUZYL2tuZGlTbjRxRHVaOXczVHRVVnJtL0MzOW9WWHVsclNT?= =?utf-8?B?aFplVS95c2JJcTdYM3dQL2p2elM5OGtzWmVQZzJDditkQ1dRY2dOWmg0d0pR?= =?utf-8?B?Wjl0c0VxUzdRaTY2NkltM3dEb3pqd3RjWjl5MTlreDAxeG9jbU03Uzk0NUNX?= =?utf-8?Q?TM9ppi7W6W2YZLBZg7hGQRnTQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5342b64-7bbe-4e0d-84d7-08dac616037c X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 07:58:28.1574 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /8jn3YDC9V0FfssLeCeOer8qbD7EMYrM0k1eSMfuiDlurGrb8jQVjbMiZDh3tEau16CWfiNv4wdU64azxBmkgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8356 On 11.11.2022 18:35, Andrew Cooper wrote: > On 11/11/2022 07:45, Jan Beulich wrote: >> On 10.11.2022 23:47, Andrew Cooper wrote: >>> On 04/11/2022 16:18, Roger Pau Monne wrote: >>>> --- a/xen/arch/x86/hvm/viridian/viridian.c >>>> +++ b/xen/arch/x86/hvm/viridian/viridian.c >>>> @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, >>>> res->a = CPUID4A_RELAX_TIMER_INT; >>>> if ( viridian_feature_mask(d) & HVMPV_hcall_remote_tlb_flush ) >>>> res->a |= CPUID4A_HCALL_REMOTE_TLB_FLUSH; >>>> - if ( !cpu_has_vmx_apic_reg_virt ) >>>> + if ( !has_assisted_xapic(d) ) >>>> res->a |= CPUID4A_MSR_BASED_APIC; >>> This check is broken before and after.  It needs to be keyed on >>> virtualised interrupt delivery, not register acceleration. >> To me this connection you suggest looks entirely unobvious, so would >> you mind expanding as to why you're thinking so? The hint to the guest >> here is related to how it would best access certain registers (aiui), >> which to me looks orthogonal to how interrupt delivery works. > > I refer you again to the diagram.  (For everyone else on xen-devel, I > put this together when fixing XSA-412 because Intel's APIC acceleration > controls are entirely unintuitive.) > > It is "virtual interrupt delivery" which controls EOI/ICR acceleration, > and not "apic register virtualisation".  There's a decade worth of > hardware where this logic is an anti-optimsiation, by telling windows to > use a VMExit-ing mechanism even when microcode would have avoided the > VMExit. Okay, I agree that I was mislead by the name of the control. Together with Paul (re)clarifying what (virtual) MSRs the CPUID hint is about I agree that it wants to be "virtual interrupt delivery" alone which is checked here. Which in turn makes this a change orthogonal to the other APIC assist work. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 14 08:01:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 08:01:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443152.697622 (Exim 4.92) (envelope-from ) id 1ouUPG-0000K9-7B; Mon, 14 Nov 2022 08:01:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443152.697622; Mon, 14 Nov 2022 08:01:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUPG-0000K2-4B; Mon, 14 Nov 2022 08:01:26 +0000 Received: by outflank-mailman (input) for mailman id 443152; Mon, 14 Nov 2022 08:01:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUPF-0000Js-Dw; Mon, 14 Nov 2022 08:01:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUPF-0004yd-CV; Mon, 14 Nov 2022 08:01:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUPE-0001Qh-SW; Mon, 14 Nov 2022 08:01:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouUPE-0007XY-S3; Mon, 14 Nov 2022 08:01:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BQFVHFGJfr3mIRlWuJagkgmcsT0HtrJSx7D1neRRCqU=; b=XW6b6B9Xe/rbgp89+c9v8cul5S UWz233jEErhEbGkbHNgw0j4ABqO45e+KDGjvSYyq9iJUnNEvxgX7n2k5geHAaOUy+lRGhp+zt4Lf3 qHLoTKRSUd0HgwRcVbIAvKCn2yc7DESrin9Hq+bPeWdnee0poVvLRzD/n15/y5FXC9uo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174763: all pass - PUSHED X-Osstest-Versions-This: ovmf=0cb30c3f5e9b2be5157224afdf75fa16bc09b9c7 X-Osstest-Versions-That: ovmf=b9e702c3c9bfe7bfb6bbcff44603add64e1787bf From: osstest service owner Date: Mon, 14 Nov 2022 08:01:24 +0000 flight 174763 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174763/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0cb30c3f5e9b2be5157224afdf75fa16bc09b9c7 baseline version: ovmf b9e702c3c9bfe7bfb6bbcff44603add64e1787bf Last test of basis 174737 2022-11-11 10:10:24 Z 2 days Testing same since 174763 2022-11-14 05:14:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Min M Xu Min Xu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b9e702c3c9..0cb30c3f5e 0cb30c3f5e9b2be5157224afdf75fa16bc09b9c7 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Nov 14 08:05:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 08:05:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443159.697633 (Exim 4.92) (envelope-from ) id 1ouUT5-00014d-O7; Mon, 14 Nov 2022 08:05:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443159.697633; Mon, 14 Nov 2022 08:05:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUT5-00014W-L9; Mon, 14 Nov 2022 08:05:23 +0000 Received: by outflank-mailman (input) for mailman id 443159; Mon, 14 Nov 2022 08:05:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUT4-00014Q-Vf for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 08:05:22 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2053.outbound.protection.outlook.com [40.107.20.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 15b607b7-63f3-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 09:05:21 +0100 (CET) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AS8PR04MB8659.eurprd04.prod.outlook.com (2603:10a6:20b:42a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Mon, 14 Nov 2022 08:05:20 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5%3]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 08:05:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15b607b7-63f3-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ENJwJIshxyLE8QFcmVcIRiwDpWqWm42jsjEhgukiz84cHAqKZT9NttAhKThTDEfT5Dz5zB8VG6rhPoq2VpT4rO+ad/o6QsAutRqFiVZc+IuutpkBMjvxQ3NCTaBk+MLK+at3F+S/p49vfVtOfAP1ltyzWsrpl7TW0RCKRJSwO8Z0GyGN1BvU1JK6mLkV5pHcS1w9aqASXJMquSOYJPDsS2Dpw+JtWYX7nNFa++vCevGRYaajWFRZaWiCI0wRpEPihKD2znKpg/2umPQyoTNPVRrdR/OuZInDUexqBKs/MIK/IypyBywUvaJfSyZH0AYD1Q1ULFl44Td2beqnMvvEVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hzeG/rUAn0/ElhMrKWbiKgW5t+kpvQ1MfO9huLRsLtQ=; b=JAI+g+Y752E16vx4LxVHiJqJntbgOBHIf7hx1GYrKfch2nmRaotX45hou75t8DLPjXfOMpufRqfRkRpe1HXE4seO9OH1dNyOktsZdSYOLv9V6TUS2fdWLvHYnFIPoTU0JKiwDlNm/+7ICvnZ8uUDj7rUsrnFjb8+hw0iYYGFdSWzRJCI8hX7Dx5FSQWdsXfDlqgSF5rc2m5hh5u/bkW9QggRYvL55Y7D3rHKcQFwzqJe2BDQEaS8C165EDZ6yUDQbXnlfVKQpuQQ0jEvQVY3tSs6btii1DZU11eBpOcrGRY7IppvM3Mh6sbwtjeMloOty2BR14ptBOvnNTfU0gL77A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hzeG/rUAn0/ElhMrKWbiKgW5t+kpvQ1MfO9huLRsLtQ=; b=4nz/sDtiYazPayxDISpVBYiqKTmaWiAabh6QE2mVQ0CZ54FFoV5gTFCH1l8bR3sPyPMQ0rwNo4EO8/UGKeyzGxjFwiz0LIY3aSf5P+kzsPYEQ94gcnfsiXrNljhq33IikFfq1osjmBbUdRa2up0Eym7902fCvUjZKe6KeyXAbJmyuNE90ScH7Xd1c03CNoM6ABC40WoZcj4BhRD7a4f5s/kVGyOV4CirgB1m3BQDtutlp+R9BZsl4TAMNCjn6ta4hmMr4tIapzHIDdgcCMm74x6dcLxxe3MxBQs/2AUqtnYQEIeNWsHt0BmSfF0RMJsH7PjRQfwIFYDYL0n4n8luOA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3aa067b2-fa49-326a-c5a0-6735bc95951e@suse.com> Date: Mon, 14 Nov 2022 09:05:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v8 0/6] Device tree based NUMA support for Arm - Part#2 Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20221114063451.473711-1-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20221114063451.473711-1-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0124.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::13) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AS8PR04MB8659:EE_ X-MS-Office365-Filtering-Correlation-Id: be02c441-7bcd-4177-60d2-08dac616f952 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IA5M1AT1cTijKioHgB0kSfisMYYJT3zJDuRpW2kATEALviCR6RdIe3bB2HcdTppaXU2AqPUPvawx1wFN+UBwYsdIR6JTjiCvhhzEdjHm3tWwpjt838qeUtj/UHG59rR7gRIKEtg7FwVkVnIgEvT0n1P9YfbO6P4HYA6YzoI/01yaHblhzzvt9IHGEXG9k5ezk+VULrAdxZbuKjgmz3q/IdIJUyeIfa9oONb/Lp5lQzV+lY82FomBj53ahypSzC4H/KMAyaXAgaNIQooVP9HGMMFUwlf9Yn5EYruxg5gmyl0aXj5dBE3akgt9WAZo5kvtFwp3c6efK8BiqAbwehozWUQHaxE4krvdN1M+RLEzmEZvv2cB46FEk+kO9TaSUgy7FmrsbIsppaljMAy2bE83+0Seo8zTc4wdvd9AOzli38NLFJ4L+zxmripyyTL77789nJbtldm5E6P2J0h4Y4b/ydVXNcXLaBNJ5y5kqS3ZSOh1Bl6UPhUdg+ijKMj4xoe1O+Wjy5g/B5O9gnXbH/nhhtpaH6CElzj/Boo+I3lur0GyiFbFjpv5iL4pdfZZ05ULIRkTNlmq6RieqYWPSmkjbZHgH7R0F+JDIYG3R9Re24xrJhEANzX2R8XoIBnqUpF/i64LqXCgkcN4fhNgvy+SGtnUgXgjkLkPavM8MvwKjyEcddCgHpCd/DreREVgJvgeoupex2wrCfFR6Qy2OSLvjF8oM3v1jjAh1Suf/d2+mnN1w6g8GYQti8CAUIfVgFbMAAp903ZeLFEBt368hY8WOo0UvJgDQx5yhx6iqP0qCXT6pGGZZI4Y/oyV2KigovnW2TU4xhYQyaF2Iqwh+eGfFguXQo9rY3pUjTs0uY5/g6c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(346002)(396003)(136003)(376002)(451199015)(966005)(5660300002)(41300700001)(6486002)(36756003)(8936002)(2906002)(478600001)(38100700002)(83380400001)(26005)(6512007)(53546011)(31696002)(6506007)(86362001)(2616005)(186003)(54906003)(8676002)(31686004)(66556008)(66946007)(6916009)(4326008)(66476007)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0pDNVNzbXRUdHQzVmViNURLYU1UUk9rUG95SUoxWjIzR3dJZjhKNkE2bElB?= =?utf-8?B?b0lkVmZuelZWWkd1Qk0vNko4YnhDUlNjRjR4NHJNSEw0dVU4R0NvZ1NwNkk2?= =?utf-8?B?UjhFOFZtNzFwUHBLQ1R2U3ZNSXBvVG1SZ1JZamxQMUFzVVJFQUNsdkgvMy93?= =?utf-8?B?WXl5bVJ5UEhSemdHMlBwUDFQUVVsTEZpQUtKTGE1SnFzWHZXRy8rOWR4OEtE?= =?utf-8?B?L25rVkpwVk9wRTNqR01iTjhyUS9vd3BtaUpVTGxtZStmeWgvRlhJSGhLN2gy?= =?utf-8?B?a09hS28xRnFYbVJFWnRUWFh1N3hVVkFDNGJlWFVybkVTOHNoZ2lRTmRCR2ds?= =?utf-8?B?WWliV0pzTWV6ZUpnZnhsdW9LeU4rWVpJYjZBM3FyTWZnUkxiSFBTc3VMVysy?= =?utf-8?B?cHhHZ1hvM0ZCYkVlYkxQOUJTRm8xZDhjbWJnQjFMQzRraUIzWFdDR001cHZw?= =?utf-8?B?cmNYNUFuQSszclpleGM4d2dLNE1oM3BrbnR2bEZnTnI0SGxQeWRnKys3c2Fs?= =?utf-8?B?cE5UY0FaNUJqbEFTQUN1UlM0UUF4bHNvVVpldW1XYi9FcE42QzRZeGpvelo0?= =?utf-8?B?SGpCWVd2K0lDcE1oUExsdG1NQzFOS1ZCZkgyTHdyakVyakltZjcwN2d4bHpz?= =?utf-8?B?WEdBQUhhUHdjL2I4aU11VXUyQXpJYUdJcG1memFYeWx5ajZjZGhTdWhVS2dD?= =?utf-8?B?aEJ4SjFrSWZEVjJ2Z0FvMlNiQ1EwUWhNdHJJSE5IMUdqQm1CRXZrNUdDSTZH?= =?utf-8?B?SlNoSWVxeVE1OE1WbElZa0lRTUVjNWMwM1l3NkVTNlptRUtPbHU3V2xSRlR1?= =?utf-8?B?NGQwWUQ1RzlwQmlHOFhPaUdLVkVNZThNWVVZMC82dWRWTXRidDM2U0NUcXpC?= =?utf-8?B?NHd1cVg3ZE8wZVNVS3Y3RFlDdmtWUDYzRVE0eTA1TE54NFR3b055N2Exc1N0?= =?utf-8?B?bTkrWjA1ZjlxcW1DRkc4NGU1Nm9GTzVlekIvcHNrZ2RMMTZ3VUJHakNuOStk?= =?utf-8?B?aGoza3p3WjlGOWtqWlV1NlNCa2VQMzRPSnZOWCtMWHlRRDl1c1VNSE00NE5V?= =?utf-8?B?S2FadVQvTko0NDYrU2p1azJzTFFLVGF4U01pNndDRFI3WXhCTUxPQlhtVVdv?= =?utf-8?B?RXJhemtOOXBBL3EzMElwWDQ1ZjZ2NHJWTTUrM2xRdHpmSThCOFRkQ0VqVis5?= =?utf-8?B?M2k5MExEVE1kZkQ2WTVLalJVV2sra0F3ZHNwZmtPUEluWjQ5Q2NQdnVQSHR6?= =?utf-8?B?Z2hldlpUR2FrWFg0aHhHOVRPenJKTWw4NTJvOUR5WFdUQUc2clpMZUFBeWY2?= =?utf-8?B?WWpuTE1OWDN2dzBGY09UblFBWndra09lZEpOT1FWR25uZzBkdnc2d1dndkF0?= =?utf-8?B?aEZ2amYyMFkwMUdwK0pwdWdMUXowTjhjWkNiL0ptanhabGtodXQyaktGci94?= =?utf-8?B?bTlQenJaMWdISUhWckdvWjNkKzU3RTNBZS9Sb2dMcEdtSzJTSmkreTBsWG0z?= =?utf-8?B?bVJmUkIrWUViSkFTRTl0R2tVWVVqczhaaGwrT2pnZFVhVm14eGp4VC9jc2dL?= =?utf-8?B?VGUveUNBMnUydlpLOFowNXZ5ditnT1o2U05KSjAvVVZ0dDM1eU5UT3JERVlX?= =?utf-8?B?eUZOTjNTYlJwOVlzbVJkWlpwY1NnZ3BUd2pEMXVxOGwxV004OFE4VkUxdVpl?= =?utf-8?B?ODNxNGpvS0h5SHVIM0wwbkt5Y1Nqa3FLWUM0dmErVFRMcFNjc0FmcXowRVNo?= =?utf-8?B?OW8xc0x2MEhGN2lpSUJNTDk1VURsc3lJL1ZRbUtHa0lEamplRjkvcUgraDVu?= =?utf-8?B?ZytNT2xkWHI3T2RORjdxS0ViSnJZRzZnTWtWQ0pvRGpkUFV2MkFzUFArejdQ?= =?utf-8?B?SHpwb29SUWdvbGNiaEpsV29VWmRJaXh3QXY0RTk2QkIraUMvcW9CYmNuUzd5?= =?utf-8?B?STgxUDlCaXhpWkN6VFFhRU1VYWU0Nk05K1MySTBsUFgvazY0NFpoN0h0S0p5?= =?utf-8?B?LzV6K3k1bFBzS1RSRTQ0aG5oSDRaNkx1ZFhiQXZsL1FRZXJWaVh4Z0Vjcnpn?= =?utf-8?B?dllDVEllMHkzTThvSWFIblBPV0VYOWJ1ZEdQUHVTTDVWVnJWcDc0UE1KZ2Yr?= =?utf-8?Q?N7NJ6tU1boJgYT6kpDWrBxQGu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: be02c441-7bcd-4177-60d2-08dac616f952 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 08:05:20.3039 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iZ7sa1zN1x6wrND0W1ovZoECWsqx0nMNuzzRPX39V0P/kDTCVHaXeqThOy5+TNWIZMrcpn5ZpO6HoaVAAigiCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8659 On 14.11.2022 07:34, Wei Chen wrote: > (The Arm device tree based NUMA support patch set contains 35 > patches. In order to make stuff easier for reviewers, I split > them into 3 parts: > 1. Preparation. I have re-sorted the patch series. And moved > independent patches to the head of the series - merged in [1] > 2. Move generically usable code from x86 to common - this series. > 3. Add new code to support Arm. > > This series only contains the second part patches. As the whole NUMA > series has been reviewed for 1 round in [2], so this series would > be v8) > > Xen memory allocation and scheduler modules are NUMA aware. > But actually, on x86 has implemented the architecture APIs > to support NUMA. Arm was providing a set of fake architecture > APIs to make it compatible with NUMA awared memory allocation > and scheduler. > > Arm system was working well as a single node NUMA system with > these fake APIs, because we didn't have multiple nodes NUMA > system on Arm. But in recent years, more and more Arm devices > support multiple nodes NUMA system. > > So now we have a new problem. When Xen is running on these Arm > devices, Xen still treat them as single node SMP systems. The > NUMA affinity capability of Xen memory allocation and scheduler > becomes meaningless. Because they rely on input data that does > not reflect real NUMA layout. > > Xen still think the access time for all of the memory is the > same for all CPUs. However, Xen may allocate memory to a VM > from different NUMA nodes with different access speeds. This > difference can be amplified in workloads inside VM, causing > performance instability and timeouts. > > So in this patch series, we implement a set of NUMA API to use > device tree to describe the NUMA layout. We reuse most of the > code of x86 NUMA to create and maintain the mapping between > memory and CPU, create the matrix between any two NUMA nodes. > Except ACPI and some x86 specified code, we have moved other > code to common. In next stage, when we implement ACPI based > NUMA for Arm64, we may move the ACPI NUMA code to common too, > but in current stage, we keep it as x86 only. > > This patch serires has been tested and booted well on one > Arm64 NUMA machine and one HPE x86 NUMA machine. > > [1] https://lists.xenproject.org/archives/html/xen-devel/2022-06/msg00499.html > [2] https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg01903.html > > --- > v7 -> v8: > 1. Rebase code to resolve merge conflict. You mention this here but not in any of the patches. Which leaves reviewers guessing where the re-base actually was: Re-bases, at least sometimes, also need (re-)reviewing. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 14 08:15:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 08:15:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443163.697644 (Exim 4.92) (envelope-from ) id 1ouUcX-0002aw-Lr; Mon, 14 Nov 2022 08:15:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443163.697644; Mon, 14 Nov 2022 08:15:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUcX-0002ap-J6; Mon, 14 Nov 2022 08:15:09 +0000 Received: by outflank-mailman (input) for mailman id 443163; Mon, 14 Nov 2022 08:15:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUcW-0002aj-74 for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 08:15:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2052.outbound.protection.outlook.com [40.107.21.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7270fee1-63f4-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 09:15:06 +0100 (CET) Received: from AS8PR04CA0166.eurprd04.prod.outlook.com (2603:10a6:20b:331::21) by DU0PR08MB7833.eurprd08.prod.outlook.com (2603:10a6:10:3b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.5; Mon, 14 Nov 2022 08:14:52 +0000 Received: from AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:331:cafe::85) by AS8PR04CA0166.outlook.office365.com (2603:10a6:20b:331::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Mon, 14 Nov 2022 08:14:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT036.mail.protection.outlook.com (100.127.140.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 08:14:51 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Mon, 14 Nov 2022 08:14:51 +0000 Received: from 10f395130d89.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 95DF9526-7590-443B-837E-6A9D6C6B544D.1; Mon, 14 Nov 2022 08:14:46 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 10f395130d89.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 08:14:46 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by GV1PR08MB8216.eurprd08.prod.outlook.com (2603:10a6:150:5f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 08:14:44 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5834.005; Mon, 14 Nov 2022 08:14:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7270fee1-63f4-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QeU7Q5XY8wgxKxgipZkCubYiIEDkmm+QFGINvV3epsgKYSLfJNZ+oTt77stSqVfx1lK+nQWpjZvbHzHVc5vpXz6yheMs4kLQH/9hM6IsBCnDBdy8bxnWpwvvT7V+s0PqAhVIIXC63v0NPQw/0OwfiDLn9UBpAiMNMPOx/XQe/DCe/Oy14YsdiqCBqhBpwEIZILmmYG/6lQLwzKoVkYokhg2IdbfF91KThKQXQco9w42JCo5crvar9bQhIXetvqApBf6Oq97Cl+GKXtzzh9fDFvV3zMX2enGI6P7WB7WyrMd3kJsYUuNtZjaB2zS9yxsXhnVmaLC3HPJz3oxbBthl0g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jykWMjFo6ItSlI6iXCvjyj9v3NJA994pl1+dKjvUtio=; b=AxnPNgA5yKJ51xgdXd45qGePijIgf/z1vpjM9MLiVMKXh6zAopMhZ9wBFHpd03J6fTAByaKjBSkPiyjPbkmpuydZwrUev1pv7ES6DU5Nn3v7VPlCjhncHoe5PDhEH+fJPYJCZlwOi/3SDaNAz2uyaqh7namGSzcITGVFydKjQUxCV1okeLUl12IZ0fpuAxUs2KTSTMhVucX6UmhLpoFbpyzLzJz90QWwA1MxOsdTo++AtTtFMuyWOj486zJjjaNxZIlGuFt+9dPJZK/SuApdZ1YqmeEHRASFcChxVgK4VDYPnVsqwCfSNTJNan1VSQrteCVlokldaZ81Fcv1jWBYgg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jykWMjFo6ItSlI6iXCvjyj9v3NJA994pl1+dKjvUtio=; b=crMFsA44XLDYv4upBpubgqWtn54f+c0bniY0BFGqNqUqnSyyqr+5NszH3w+HNLJuWV4+4Q+pT/4rbugQ7lKhVhQus6J2ecD7vlmtetpW1IJUBhRM85/T+5IJKXMTDJ5GBIbDFwE/42paKWUnZc6MDCvP6E8shCyt1GZvVKzh9ow= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cJ+EZ2wfpKV5S+D2zlLwR5MW6Si/4D/tD9SmHLE/8DAddO8RlC8PhyiSG+/YyXiCeULWEEiLPf4DEBxJAegZYd4IXgik5v6PN+c+5Imaqa0w2BgRx3Sb9cqYHA1aknxHEHgimtQ7d91NA4gVv01rYRqoup2GuSx1ZYXSoQM0ycVSN7bwCivm0qJykNiIfAgLV7O2O+lc2jQfH5wHIKKCNLk7939KyrPRPqQX+wP31MGEDofYYXyoiw3Uqbrf6QL+wcf42lJhzvDqYj1FBfAjHWieGXYaEdgo6ErHV0XbG4zBlx+1W8CJJSHIIdWA2MzH0r8tLsrDzKjg8pNY0si7Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jykWMjFo6ItSlI6iXCvjyj9v3NJA994pl1+dKjvUtio=; b=BTDbCJZzXWYREpuSZ8dd2kO71s0hs0oRv8BCrVjOt0hZWlrC/zepOkYHN5H2SbfDK3nFD5nxUY7M476i7Ki7LX+hREbPj9oaPjYYLZH1v+rdMgmhvtlRZbfEFlm7m5IEO+FfBXoyEhiDEyI1HIASOzmFlcFxjfgisURyGVGvuqco62Bjo1k+MbNcxSduEGzgQwmHfCtn7m28JGaVa6aVM1T9x0IgpNTOSe/K9uy7MJjCq/snPL+R4LCrKggRUJX3B0/m3zPZ8bvlAVK9H2vcUc6LlRNfraPvtQaMH3h2oKfQ3OxoNd75bdlgTIwckPKZFLiUWdNuyGDnA2W18iP/rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jykWMjFo6ItSlI6iXCvjyj9v3NJA994pl1+dKjvUtio=; b=crMFsA44XLDYv4upBpubgqWtn54f+c0bniY0BFGqNqUqnSyyqr+5NszH3w+HNLJuWV4+4Q+pT/4rbugQ7lKhVhQus6J2ecD7vlmtetpW1IJUBhRM85/T+5IJKXMTDJ5GBIbDFwE/42paKWUnZc6MDCvP6E8shCyt1GZvVKzh9ow= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v8 0/6] Device tree based NUMA support for Arm - Part#2 Thread-Topic: [PATCH v8 0/6] Device tree based NUMA support for Arm - Part#2 Thread-Index: AQHY9/NBdTAzy3F6U0ar/3rX7ynbh64+D8cAgAABF9A= Date: Mon, 14 Nov 2022 08:14:44 +0000 Message-ID: References: <20221114063451.473711-1-wei.chen@arm.com> <3aa067b2-fa49-326a-c5a0-6735bc95951e@suse.com> In-Reply-To: <3aa067b2-fa49-326a-c5a0-6735bc95951e@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C49993FA732C9C4AB00A558200440B28.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|GV1PR08MB8216:EE_|AM7EUR03FT036:EE_|DU0PR08MB7833:EE_ X-MS-Office365-Filtering-Correlation-Id: e6f35982-f186-44ac-89eb-08dac6184e3b x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4d1fDC7fthejTXvZQ3mTiOk0Epe5iorUauLv0mXRyqjMIg0N7z41ZtWKiSjaWqhEczANdG/6KWm6Q+2oDATbjz4xgd4fCFC0rzGPSQYxHAummMTtf/nPtUT5VycZ8oL+4r/8rIPhX714h3E6o6KbSZB1e1ytVfqHyCp26l1xph5Ilc1Tk/4pq9/NkDWCu0zKrJTq7CQGFT9AXpc0jInCoNcSDdQL3959BXfbDWTbYbait7sbuEbpBwKVCYNqEHr9+QwmWopsQGwvqrbSHPiPokW9l2rpZjffW1vgivl5EKz/yi3iTy1B0/TllnsvIv5A2/S8cP00bAL+HAwv5tuMUGKVVehimm5Yu9rPgp25vFRejiPNaCXcqcaqpkF5xRMSwRfknkCrMTEhFGcb4W+z0xlczswk6N7y14/J7sUuCVq1supsuniFL9cGrk+he0g9CsyclfyzxUXntGYlyRb1C7wO1C+pLDWS4hzaEMWcf4xkbm3sGKn6baXVUgYwdvb/g2b3x1Kfh0oswsu2t9tj7Z+0UODPOJo5Ml8pT6FFnniTw+xd2mLeLWXusJrA4z+lWbMJIPwOtcX6hTp65OSy8RcwJWOS90/bjY0HuCjSY5uKAjOlhZ/NXN8RB9uotufiv3IzscKBVD1yrLeYv1Zmhjkr8fCbawq/ByCTSHu7t9VRehMr1p/+MNZGZyMU8AHVUJKPIStwvqnwpZFROLN755F9+GesXphPMLuVAe/6aTTLephBuOwVcD7GjCeDY92Zgt4Xwvvly2d6CcINxEJN5cj237rqW/5MW1zAiYnarrbanCD1FYk/+fz9UmWcyi7zdnfSQpcPIwExv3M5ATH+aw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(366004)(136003)(376002)(346002)(451199015)(9686003)(53546011)(186003)(6916009)(86362001)(54906003)(478600001)(55016003)(6506007)(2906002)(41300700001)(33656002)(7696005)(966005)(66946007)(66556008)(8676002)(122000001)(66476007)(66446008)(64756008)(76116006)(316002)(8936002)(38070700005)(4326008)(83380400001)(52536014)(38100700002)(5660300002)(71200400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8216 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: aa84583c-dedb-4e08-ca06-08dac61849b5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UYPkP1QhVHqhzKcmhJ0JzG2yEOIb09jbXxqmVmZ4gyISxYeUYtE4V332GmctjGBoWgeI7GhfdMDSjKkAjZgEnpMBdPnkJv5+N++78h9+OvuV6mQ4D3BXL9ZDZrEnGbMPbVskHVQBkmj+fjAXT9q5sodxabJKwyKXYKIblMdSHPLuxRNsOseseK6unh48wyXjQkheEUfOtsdmVvkZIvlKtbBCdNKINochHZ8WYPsfOZWwFgcBbS3mXlAyKtmJeDodiGlI9qdxS8+nvq78qPgDavQXI5a/uoESoyUv0VSiOVpBYtuKSneSgB94u5LiCOHjT7kl1qpAfGa8GahgfuCRlTIw/rqhL2wFJVR6bFHSBAkQgzKHkTRhpRWwMpNvnBVDtI9a6E8uerPFprTU9AAOVqRj8LwJo4zpCuU4AHcebtNYJvcghaDGftMv7Gfxm448t7QzoG2Lx4aOzrUM9yc+gyQM4mRATWRUMNOm+7ZGsoygpkuQq4Ar3eTxz2BWt/HUkBGN+MmUwaT756hIcxuS8DAB4ZsXj8werr0V93zg2Fwn/m2cHZfU8WIRhwS2hQHhFn09QfRmmc7ERGjFs1csd1vIsxZLHt85zLUlavPlFLPa1+P5eZo4J/8hxYS4yUw/AGk4jOVMhn1bqTgmNkO3A4UZ/u9eKPLQbfoTmkroZ/whuasl2eZ/+oVWiiJ8OA0/+Ct5lIaaojBQVndMtW3JQJKJjB56uloFMFoqt/gRlTrbpGXv3FbjlGy4Zy77ykxH10Yk8HHDPIju1C3cogDxVUQ2cIWUgaXbJ6YRPZD0GFTK3khuiOlbmIZFdBbqrHsVOeXa7veWNbNEuJebYQhumA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(136003)(346002)(451199015)(40470700004)(46966006)(36840700001)(54906003)(36860700001)(83380400001)(86362001)(82740400003)(356005)(81166007)(40460700003)(6862004)(41300700001)(2906002)(316002)(52536014)(82310400005)(5660300002)(8936002)(40480700001)(53546011)(7696005)(9686003)(6506007)(26005)(55016003)(47076005)(336012)(70586007)(70206006)(4326008)(478600001)(966005)(186003)(33656002)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 08:14:51.9761 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e6f35982-f186-44ac-89eb-08dac6184e3b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7833 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDEx5pyIMTTml6UgMTY6MDUN Cj4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPg0KPiBDYzogbmQgPG5kQGFybS5jb20+ OyBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgUm9nZXIgUGF1DQo+ IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgR2Vv cmdlIER1bmxhcA0KPiA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsgSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz47IFN0ZWZhbm8NCj4gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVs Lm9yZz47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BB VENIIHY4IDAvNl0gRGV2aWNlIHRyZWUgYmFzZWQgTlVNQSBzdXBwb3J0IGZvciBBcm0gLQ0KPiBQ YXJ0IzINCj4gPiBTbyBpbiB0aGlzIHBhdGNoIHNlcmllcywgd2UgaW1wbGVtZW50IGEgc2V0IG9m IE5VTUEgQVBJIHRvIHVzZQ0KPiA+IGRldmljZSB0cmVlIHRvIGRlc2NyaWJlIHRoZSBOVU1BIGxh eW91dC4gV2UgcmV1c2UgbW9zdCBvZiB0aGUNCj4gPiBjb2RlIG9mIHg4NiBOVU1BIHRvIGNyZWF0 ZSBhbmQgbWFpbnRhaW4gdGhlIG1hcHBpbmcgYmV0d2Vlbg0KPiA+IG1lbW9yeSBhbmQgQ1BVLCBj cmVhdGUgdGhlIG1hdHJpeCBiZXR3ZWVuIGFueSB0d28gTlVNQSBub2Rlcy4NCj4gPiBFeGNlcHQg QUNQSSBhbmQgc29tZSB4ODYgc3BlY2lmaWVkIGNvZGUsIHdlIGhhdmUgbW92ZWQgb3RoZXINCj4g PiBjb2RlIHRvIGNvbW1vbi4gSW4gbmV4dCBzdGFnZSwgd2hlbiB3ZSBpbXBsZW1lbnQgQUNQSSBi YXNlZA0KPiA+IE5VTUEgZm9yIEFybTY0LCB3ZSBtYXkgbW92ZSB0aGUgQUNQSSBOVU1BIGNvZGUg dG8gY29tbW9uIHRvbywNCj4gPiBidXQgaW4gY3VycmVudCBzdGFnZSwgd2Uga2VlcCBpdCBhcyB4 ODYgb25seS4NCj4gPg0KPiA+IFRoaXMgcGF0Y2ggc2VyaXJlcyBoYXMgYmVlbiB0ZXN0ZWQgYW5k IGJvb3RlZCB3ZWxsIG9uIG9uZQ0KPiA+IEFybTY0IE5VTUEgbWFjaGluZSBhbmQgb25lIEhQRSB4 ODYgTlVNQSBtYWNoaW5lLg0KPiA+DQo+ID4gWzFdIGh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5v cmcvYXJjaGl2ZXMvaHRtbC94ZW4tZGV2ZWwvMjAyMi0NCj4gMDYvbXNnMDA0OTkuaHRtbA0KPiA+ IFsyXSBodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL2FyY2hpdmVzL2h0bWwveGVuLWRldmVs LzIwMjEtDQo+IDA5L21zZzAxOTAzLmh0bWwNCj4gPg0KPiA+IC0tLQ0KPiA+IHY3IC0+IHY4Og0K PiA+ICAxLiBSZWJhc2UgY29kZSB0byByZXNvbHZlIG1lcmdlIGNvbmZsaWN0Lg0KPiANCj4gWW91 IG1lbnRpb24gdGhpcyBoZXJlIGJ1dCBub3QgaW4gYW55IG9mIHRoZSBwYXRjaGVzLiBXaGljaCBs ZWF2ZXMNCj4gcmV2aWV3ZXJzIGd1ZXNzaW5nIHdoZXJlIHRoZSByZS1iYXNlIGFjdHVhbGx5IHdh czogUmUtYmFzZXMsIGF0DQo+IGxlYXN0IHNvbWV0aW1lcywgYWxzbyBuZWVkIChyZS0pcmV2aWV3 aW5nLg0KPiANCg0KSSBqdXN0IGFwcGxpZWQgdGhlIHY3IHRvIHRoZSBsYXRlc3Qgc3RhZ2luZyBi cmFuY2gsIHRoaXMgd29yayBoYXMgbm90DQpHZW5lcmF0ZWQgYW55IG5ldyBjaGFuZ2UgZm9yIHRo aXMgc2VyaWVzLiBJIHNob3VsZCBoYXZlIGRlc2NyaWJlZCBpdA0KY2xlYXIgb3Igbm90IG1lbnRp b25lZCB0aGlzIGluIGNvdmVyIGxldHRlci4gU29ycnkgZm9yIGNvbmZ1c2luZyB5b3UhDQoNCkNo ZWVycywNCldlaSBDaGVuDQoNCj4gSmFuDQo= From xen-devel-bounces@lists.xenproject.org Mon Nov 14 08:18:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 08:18:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443168.697655 (Exim 4.92) (envelope-from ) id 1ouUg3-0003LN-93; Mon, 14 Nov 2022 08:18:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443168.697655; Mon, 14 Nov 2022 08:18:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUg3-0003LG-69; Mon, 14 Nov 2022 08:18:47 +0000 Received: by outflank-mailman (input) for mailman id 443168; Mon, 14 Nov 2022 08:18:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUg1-0003L6-8O for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 08:18:45 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60049.outbound.protection.outlook.com [40.107.6.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f40f67e6-63f4-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 09:18:44 +0100 (CET) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by PAXPR04MB8374.eurprd04.prod.outlook.com (2603:10a6:102:1bd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Mon, 14 Nov 2022 08:18:41 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5%3]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 08:18:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f40f67e6-63f4-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WD2Wmj8q4q55KKs9yMQscN35ILy2wKfKSkNOmZA3pUA4FDY2jybSGBip8uXhl3eb/nn8M0f/Q71z0jJHoTVzAHAMKQUyvxVBbByxDiwV9EiLMHyRyw5UYguSzHAsy7jR9kvFd3OPCpfHoivm6BfUJVF829AjMMvVGhbn4y9l22Khb7Xa0/M5ja0g1F46Mrpt2Lp2FPexfIzv9dm9gC9I9Oc2FHqrALRO7b1GfZRpVTfJjKAFBnKhomumTUKpe20ffZyII1Z55F/26INMhnR2p3EhIDdIDg4UTMBph1Tz0Qabx3B7zsM0ZAoyCU1/njPS5aFZXXaogI1R0RnI7wEeWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nXFe90L2XRJ0XtiplkbFA/f+LUhTE/ryZkdQXNNeaUc=; b=VDra0JVDrWbfmHaPIXvU7x6MmcQfiFX2M71wbvsXOmvKjyF7ffyk/H1sqtSwY6Ex1vGYPglJJQDm7rod/yh5S01AVQL2c6XlLzKOfUeGGLA7jUQuqHEH+wt2N7Uz4nn63IjeJ27AqdqamNOWhOWZ23pfNO5nbQY3vVm9+7mEzC2UVMd8S4q7I5+lDMrqWdmRsQbUTD3fFTMQOMHhabmHTCrSQ5wVJmHVFIGWcdSy5HKlhozGIW0APG5/zhKeXOVq7V71V0+bnArS1c+a5mQ0HuRRvGvxJFihrkrqdgIP2zXDVFrm0GwPnhHa4fg/PW4F6b5lcZjFRFjyF3rdT+qEbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nXFe90L2XRJ0XtiplkbFA/f+LUhTE/ryZkdQXNNeaUc=; b=MnyXDaH5bbHdFAkYXVn8LNUZux++ttB8eJlvxIufPCNR2EWFVPQN9a+SwvtEvcpYypp0myNUm69HwGMxCPIgkvzVBULps09i1zqz5p8KX33aK1An3+YbC2JmLdlx2IVAlxZSY4s+G9RtUZC48IHj+4j8hbx6zEqdtfzK9ZdTuAipq6dT7kHOpiAGT0H90OdGaQlY85BQ58RyRHu7VXqASBiiiklYiG0CEI6QntSnL3FPYbfyRaP7c9hlHbiWDGgps3+LzO9UrETSBuZNsnnuMVK52xswrWob6eu4EJCDBHxqpTfSc+uPuQC4Zl0zit7rC9EoV97+LZuOg9ulCY746Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 14 Nov 2022 09:18:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: vnuma_nodes missing pnode 0 Content-Language: en-US To: Henry Wang , Anthony PERARD Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , Jim Fehlig , xen-devel References: <2046b5fb-2533-02fe-69e8-f46174cf825d@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0061.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::9) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|PAXPR04MB8374:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ac044ba-00c4-46ba-cc65-08dac618d6f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 73uJzBY1aoNc6QgByVzYhfDdqBwMatQQW9avhvnnlFqEMMJ53CRECUuKMBI/U8RCIFvpqLCXSHL+JcaslJIZp4h37MDtdWJwlGxGKLwqNVgX4q0XMrSgjUPCIKxnY+Jd9Ov3flSiCHPp4uAZSBx4DtYv4ZGmkr1z3atYESCYe3D/U/6zY26hWfmaz/cs2vqP8LyP4a6+He+ntnQc9CM0FAW2YCdrADKiVpqcvKIJGWr9xHM9OzR0UEdCF3oP02OAxpIwrunZ6c2gb14W3t9IhAOtmYdeE1I9KEm3qGdiU4t2RmQwL1qP30CO4boXIDp1AbT+QHz4MTGPdP6kLl6ecOAT158iSFWxupE+9xEDjguNIMcUPsqkj52WgG0G0AjVuZW18U0qH4ipiyK1/o+gX7+yFzZ7EYw1/aCXqXqdG8wP5WfvHRY8bUDUQ1pvbM3mX3yn7yx/komSeBpeLTovz2Lw0nhk56wdzAnS4UVn8gvLoAqpyuC6j6bQSO1+unf2OUADcZlZGTQhVR0Rros2/QdmqFxhZz5Fv+PvBS83nRitgFR+STnI49k7owQy2k+btXQ3gEFRFwfBTTW8s1iQicbLiwSPGpn7qkOuKYKXIRHC2o+Js43Wa0mwyoaYLIuAgLZ3Fqrg4e8l9vOdbfL70/9RhERbhcksOaH80LJVVXftCEkKr5e9wMBZKVhP6qa0hN0OZ6QWLUUHvPBGEVgbZdtppV8TYeV/H67rEjAfdzKS0AWgpgtq63ccCdurIWlHMfC0/smkBVxulSKnDgl2tisOhOikDUiIcNfgg3ISS/g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(39860400002)(376002)(396003)(366004)(451199015)(38100700002)(31696002)(86362001)(41300700001)(6486002)(478600001)(5660300002)(8936002)(7116003)(4744005)(316002)(66946007)(66556008)(66476007)(4326008)(8676002)(110136005)(54906003)(2616005)(186003)(83380400001)(2906002)(6506007)(53546011)(26005)(6512007)(31686004)(36756003)(66899015)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVd1akJicmtpWm1wWW0rNzd4MDZZS29ZTkgydTlYSUFub1p6ZWF5aTF6bTB0?= =?utf-8?B?YXh4dTBISGFVTlh1VGRQUjFBczNWbmxoTk1qTS90VUdrU01qRWhDTWhhUUxq?= =?utf-8?B?cm12Smk4d29aSFhSVGdaNzVVa0U1d1Y2bGE5Ri9pb1psdU5OVzFCSm5GKzZ6?= =?utf-8?B?cXQ2ZmRsYzBBMmREbENoY2xGdEl1amFRMVZUc0o5RE0yd3NQRVZMbCs4MjlL?= =?utf-8?B?dDRuUnU1K242L1kxZTRibGhubit4YnBkclhNY0M4UTMzeldsVVdKOEEwQVRo?= =?utf-8?B?bXNHbXp1aUVtK2NLL3JnTXg2bVlLZmxxcmR0QzRGSmp4MGpEWlRpYUVzb0di?= =?utf-8?B?d0JEcG96QStqLytRRkFMTUR4TmdnaVR1VEtlbGNucWNkaEtFQXhyeTRFQVNI?= =?utf-8?B?aHJHOHNTU2ZEUytyOFJ6NXM0elgxVWlrZkhPUWhaWmo1MFN6d2hQZjBkbVhq?= =?utf-8?B?eXF5VnFNTlBxc28rMWVCbTlZbTlVZ1ZDd0RPb1BUeXJ1cFBSOU5DYVZrdFpj?= =?utf-8?B?VHhCY0ErMGVtSTJuc1pvUmpzNTU1aXFueDcrYUV3QVd1dmVNemc2NWRwZlFC?= =?utf-8?B?VkxWRmN4dDRqdjJGdUJsZko3eEZLOGJRWTJabkRXQndqU2lUTGFJWVMrVHdw?= =?utf-8?B?M051YmQycUlWeXZNRUNiTWlXNUVCakF5MXRIbUphNGdzSVNsWEZiVE9kSmFO?= =?utf-8?B?anNaQUc1V3dhbVpuNC84SHZ3alVIRklGVTJITHQ4aWhUOHVWWnkrQUZ1RXhM?= =?utf-8?B?RWgxMlNqUWdEYUxPTnIwQ3U2Qk1qTFl3QXhJZEtHdzhldlNoK2IzUGhXL01a?= =?utf-8?B?dU54WU1qd0Q1UCthUGs5elUvTVR4THE0OENmUVc2elllaXpvNHhyNko1UFBU?= =?utf-8?B?SmlaU1hpRzk2S1pNa3pRbmFWWDR4SnBRcE51YTM2cWt4cC9QYWpkdmJmRVVR?= =?utf-8?B?Si9xZmFQMG42SHF6bkFnSHBnS2VhZlhNdzNhRU5neGdPKysyVWJ2YjZZREtw?= =?utf-8?B?eUZDTXFJZkpHMEwxYXZYM3dtRk8vcTkxM0Z3Y2FDMlkyeWd3OTBiTDEyYWQ1?= =?utf-8?B?bitxMzBSM1lJTVhHNGZ3VUdySS8xdklWVDVFZDB3cjNjcmFQVDhpS2NjWXh4?= =?utf-8?B?aFUxdTl2cy9Cc1BsYmFvMEhka285aWdMcXpKQTJGL2xCQnRCNVlMNmE2UGR5?= =?utf-8?B?OUQrTHBYOFkwWEtXc25xNDZwdzRVS0d6WUgvUnZFTEZLN05TSlMzUCtqQURz?= =?utf-8?B?WWcyS0xuMFcxWU9GTW9CeEJYZDJhSHpmV1R6Y2d5ZGMrQ1JKTTBHWTV0Y0tz?= =?utf-8?B?NnlTRlpKVnZPTktYSGx3TFZkL09qNE1leUdjckNteU9oZzVYdE5EV1huL3JX?= =?utf-8?B?ODVWdVpIN0Y0MzdweENxbTFCN1Jvc0RTbEJ5akJyd0VQMGl2eDJTMFNCbVFN?= =?utf-8?B?Zlh6MXYxaTRER0tFN0dEQ2ZuTG9QVy9wbDYzYmQ4QW1XVHhIOG1wajE3cjU5?= =?utf-8?B?c2lpaHRaUVIvZjNJOWZZWUlLM01tZUJzcmR6Yml6aGxFYlU1b2NHbzRQT0pt?= =?utf-8?B?SncvTUJCYXBqWWxvNzh5STlJMTZmT1htbGlHQjhsRGQyZVB0QVZQSnNTbzZs?= =?utf-8?B?Q01JSnNhUTZaQ284VXNESmJlbDRtTktrOTYzQ2ZQUVl5dmhOa0NPSUgyNTR0?= =?utf-8?B?cW9VY3g2VGE1c3RyZzcyMi9kejJUMFRNdjkwVGxWbDZqNER3anc3M0ZjQWZB?= =?utf-8?B?a2o1NTBId1FwWEtKNE5FL0Z6ZEMyVDRTbXcreTZvSHF0WFdXR3VNWkc2MFhU?= =?utf-8?B?Z202MDRlN0ZYbWp5N2ZBd01EbC8vRFhZMnc0aU0xM1ZrSDlGOCtRN3NpWjB0?= =?utf-8?B?TXVHSkJ6MDFQaTBSbFF4eUF3UXNhSkFXRFpSSUJKanlibjVvWHBBTXNUT1gr?= =?utf-8?B?dlJOVGp4eFNUNlZ4bUlTblRKMCt2aXRBajM4Rmt1cmNwN1I2WWh1NTU3VFRY?= =?utf-8?B?c1paRTA4dWVlcEd2YjY0aGRjY3FaWFJvcDdENlo1VTEwRWo3djVSaWc3T0tn?= =?utf-8?B?REUrdTlzUFAxbmFWSWE2UndjcDdmN0d1SldENGo3UCtsYXRrQ2tZTzZpNXFo?= =?utf-8?Q?iGpwXAhrL9UxScDDFfd0RjN3g?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ac044ba-00c4-46ba-cc65-08dac618d6f2 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 08:18:41.5659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BZLiuoXcPbqsaMvoBHjmDEURGziw3+eld/sotp+eQVUs1UbrNfJbPGWX9gFi2Iqkl1l9hSl8ll15zjibh0GiUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8374 On 14.11.2022 07:43, Henry Wang wrote: > Sorry, missed Anthony (The toolstack maintainer). Also added him > to this thread. Indeed there's nothing x86-ish in here, it's all about data representation. It merely happens to be (for now) x86-specific data which is being dealt with. Internally I indicated to Jim that the way the code presently is generated it looks to me as if 0 was simply taken as the default for "pnode". What I don't know at all is whether the concept of any kind of default is actually valid in json representation of guest configs. Jan >> (Add x86 maintainers for more visibility) >> >> Hi x86 maintainers, >> >> Since this report might be related with the release, if you have time, >> please have a look. Thank you very much. >> >> Kind regards, >> Henry From xen-devel-bounces@lists.xenproject.org Mon Nov 14 08:23:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 08:23:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443173.697665 (Exim 4.92) (envelope-from ) id 1ouUkJ-0004km-PO; Mon, 14 Nov 2022 08:23:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443173.697665; Mon, 14 Nov 2022 08:23:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUkJ-0004kf-Mk; Mon, 14 Nov 2022 08:23:11 +0000 Received: by outflank-mailman (input) for mailman id 443173; Mon, 14 Nov 2022 08:23:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUkH-0004kZ-RQ for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 08:23:09 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150041.outbound.protection.outlook.com [40.107.15.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 91d983d5-63f5-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 09:23:08 +0100 (CET) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AS8PR04MB8626.eurprd04.prod.outlook.com (2603:10a6:20b:429::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Mon, 14 Nov 2022 08:23:07 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5%3]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 08:23:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91d983d5-63f5-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RlQ6PcCIqNGSBe3Bbm7nAsc61ak3qf9D0HnLAxHuw3pgivmfiLcrhDSbzuiNRI4J45dzdthOF+uuVLXjd4ojkE6fzKNsJvU/KKWuwpsOT1yvN9tEtRI1PSUz1LYqMdMoTXoSUT3BSJGeO+1pNIUbYNYSGKDd5LOb9lHP1wZYn+xih6/gtSxv8WduL1K2zpI52D1TvlFJN+fDIkuFka+jTZR4oa8g39TGFvDvLZKnO4ozxCYlNk2bAoFhE5AMt1Z4IXLm/n8KAgjcTW8QdRfae90vYbgK83+TsIA/amLcRAE63wJKEroCPX5pJVf8QuDcMWP5zTuvxZvL++1PmQtHXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8xnVIDzEtFZM0rZ/XO1S7BuTcV7lwr43sCcylfCTjE0=; b=iQFVXgoJG9sWq+LnEeCkLMVZ9ZrHcHCQjliynfwgsTLbxUGedMktkcGlxM1osYb2SdLc29rnps3SFcGjdcXhk58gBEhw1YL5BhQPyDRT7N2ULBWiTPwTo4gPtwE28D04c1KD9pndN7AFMcu5aL9bF0jqutMMSOBjVFhNSylDKeVzV1JWdprr6wYk2ub/T4OEnBAcKObfFO6fNkjJnFH+Vz13rE4LpmeRkC1ZtmJpOr2zMjOrq4f6EjZPFOWVxyVUYnJjZi+K66y5/MpVHdgZQstYgVh18PP1feRlCMVALr6r4vdtCWXMwxqibzTuzg3kYxaRxGqJYHpUHzQ3Yy3S+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8xnVIDzEtFZM0rZ/XO1S7BuTcV7lwr43sCcylfCTjE0=; b=sMXCpdMtvftVUSGAgbaClPJ2OWjoxoL8hKBoHE+qWoPQvZ1qrUt600YGJK7/Hk/qXVs+E+tIUAjjQJVhNsiFuknUXVt2cqw+IfEYigvGHeuBmPAChvOyPoTsbD6ODnCNnpVlLiQTrlyQbv4llAi4Alj6Q24QsCEgp5G4m92xYDZBGkmm72brZ6ml2LuJBY1Cr5YBv2GIPIGhMO1F+Egs8L4MbAtpVhu+S55RNm5ncgKvLANDulYKsTAe+1SjMjP4/ywBjiyXp+YknKszvhfwcThj6uR3Pk1jpmZlavAJAfz9o9fgUAImCemOG5+AB+GGNX0gp2cg4MeRHUVt3nsRUQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2beb3d17-99f6-77fe-a5d6-d60e665f01d5@suse.com> Date: Mon, 14 Nov 2022 09:23:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v8 0/6] Device tree based NUMA support for Arm - Part#2 Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <20221114063451.473711-1-wei.chen@arm.com> <3aa067b2-fa49-326a-c5a0-6735bc95951e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::15) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AS8PR04MB8626:EE_ X-MS-Office365-Filtering-Correlation-Id: e715f0b2-cfb2-49b5-5734-08dac619755b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8RuPVS41RO1g+k9zFEQnA22gVmSNhAbp+yHZeZCcgkus+F475fvg8/Fs133DWTvZllb3hXLvH+legpOv9vSXYxFqqFiFSzg2Jmsrf2AJuXiJ1ngLK+BNBzw3q5dl+mTQ7JAeDCMelHtrqNwQaG4IPdr58RtRYEubkhCywGE8wPk2hltqnUrNeM35aQD6IciAb2RLGjVbBjJ1xqdC73elRQa6MLyDVKyRkEN1xZ+QaAuktQB4cCtXgMISyYKMoblYFqGslGzVr2A2HwXU6i2NvsTdJYTAjOf3gyjg7GlhcsboHH/kIoRwL+teDraerWZxp6WMdFrCditNt76ravpE+YWc2kk9MEmXCO7EbIXUZilKBpgQA8nOeVe0lB4bkUxQGqwPAcWc23yLkvXH521Te+xWNQTD330I7J50SKyD20vXzYHqxphA7rI9Dz8ewpiGcCjzwE4J+la4p7IustKGfORIXc/rBT5s8ph0hDEMmc1+ayAvxcV6oeYr2pWtC4TBxRLAo0qVWYNe/suuOqAFX44XAl12avNR8kFQzaqiDgFHuAc5NZaKBprJObXTi1/DKf84jTK/5rpGVkAG+ZDJh2EXA06ScIlcacSVD0mSCTwnE6xrTQyPStJyJ5XV+77w9w9FtsP2Qho84A8o80lKlKgaTWc+tnK5AUHw/D8GF0FWPVwxsrfZH7hqdyqpo0h2Mj7xtb1yrwklk7voCa9qvGfiGllJEqxYEIDdD8pJD8Ygv3I21xVrtnkgZ7a7tEW3kT1EXKy5OpGVBwAPoGAyIKneJxe8/Ki9wLB5pXmo/sfwqF+VuJYhKOS7YhJW/jEO+7e0x/qTWbT8D4wIl9Le6tBpGBgCpqd/UtPQzioqflI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(376002)(346002)(39860400002)(451199015)(2906002)(36756003)(8676002)(4326008)(66556008)(86362001)(66946007)(6916009)(316002)(54906003)(83380400001)(478600001)(6486002)(966005)(8936002)(5660300002)(41300700001)(38100700002)(6512007)(53546011)(186003)(2616005)(31686004)(6506007)(26005)(66476007)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1JHanRTOU9WSGVRbDJnOS92MTlmd2VpSytYMlBReXZtRTI1NjZRVGNrbXlK?= =?utf-8?B?aU94VXZLbGo5U09hZkJtdm9KOTNNYm1Lem4wWmJ3WmRMTFlicFBteW9waWRB?= =?utf-8?B?YlpuMzZONXRKUmxtbGVyS25lcUQwMkRja0ozVHI5NEFPN3pjdnRxMGlHaVBu?= =?utf-8?B?aGk0UHRrazNjT0pzaFBOci9iNDBwTGM1MjY0aWJmMDArbXg5QWxaWHlxdkx4?= =?utf-8?B?NTh2S2hIOC9QdGlFbFUxQU5tMzgwcUxITmR4dU1iWE9hRmZjSlhyWFJkUGly?= =?utf-8?B?cFQ2MEhpb24xV0ExVlpZT3c4cm9SRmhMYWcyWnFQazJWcmN4VCtreFZEaVlU?= =?utf-8?B?ejdhaWJtc05udjJBQTdTT2VxSHdIRFRJcHBkTlBhd1c0b0x3U2pBTkRvQnRW?= =?utf-8?B?RjZtZDZKb0VkcXhjVjdMSTFEUllLVk1MbkZQM3lBOEM1TEJZanRHQzEyWkpv?= =?utf-8?B?VGk3d20yNjhKeFdmM3ZwRlYwU3VIZVkxdmViZ0hDU0FxQXpoTyt6bCs1SXB3?= =?utf-8?B?UEFPeUpqdXk0NEpyelBUUFFQUjZ3aE1JSmk3T2l0a2hZNWlpREY3bmRpWWV0?= =?utf-8?B?SHY5MHhMdzYvbDBCbDdSYzYrcVlwQVprQmpYenRKSG1TMkgzRU8rVWM4dVlK?= =?utf-8?B?bTZXNjZwT3dGNTZLbXFhZE1WaW14ZkJLZms0SFk4Y0RzTzZTZjhCNi9GbThz?= =?utf-8?B?bThsZ1BrOUZyT1FxcGltTitjOGhCV01zNGlSMUJnN2tuaDVnQnJrTUhYWitm?= =?utf-8?B?d0hYbnRRcE1iUHl2ZnViMithbWRBaEVkUFE5S2V4aU1SV1BWZmx5OHpsdUZw?= =?utf-8?B?am8rYkVCbnVCT0hVWm9qRHVZcGpZbVh6V2JVeGZTSzdndlBnV0wzeldxaTVB?= =?utf-8?B?YnJxd0d6MWkwSmhHY2pKU0RHWkJFdmFyQ1Z1a0txNlZMSFlzZVdSR2RwdFZV?= =?utf-8?B?bm9ZYUdVQVhObm03UVZEeVVhVFUycHBvSW9FbTZpMVFQcVB4cmJ2TjJzd0li?= =?utf-8?B?Ti9OK25lRUlZVFN3WkY1V09ZK0gvTEp1NkdYT0RXVnpQa1FQMmxuVncrNlZ2?= =?utf-8?B?SEdadCtMMTYwRi9LeUVTRnNzR3dGN0pQaVZzNi8vUXpxTS8wdThrek9xTEZB?= =?utf-8?B?RHIyYkVVRlRBN0VBb29Ibmo1QndpSTEvYnpqd0FKUU5OR2pIdkNhWC9sTEdh?= =?utf-8?B?bCtVeEx4ZzgrWnlaT1dwdTRMNW5yZko0RVZSQ0RVL0RoZzk5bUdHR2NiTEdH?= =?utf-8?B?aTZhbG9mNXZreWFRVXVnbUswalR3NGJuWDByZEJQWCtiaVNpbDZKV3RzZDU1?= =?utf-8?B?OHZXNERnL3RwenZjQndtQk5UaE10dklTcU1VaVplak9MTG4zTG5jeTRpbW9E?= =?utf-8?B?bGRyWTFaZkVKdCt3OXJXdllaUzJtOWExTkJuZzlYTDc4RERoSUh5ci9yNldT?= =?utf-8?B?UzM1WGphWGE2ak1RV0FMUWhjV2RRMGZkSWdYdk14WHNwZFFEd0JUdUJVZitP?= =?utf-8?B?VUsxYzJIZXRwbEl0dDFldE85MDk5UGxsSVRwZGdEMW4rZ01PQjJoMzIwUGd5?= =?utf-8?B?L1VmYmM5SEFOUTNLNzhGc3JtbTR2aUdFQnpBQVMwSnI5aFNyelF0cTkrbUZj?= =?utf-8?B?d1p0NWdpMDBtUForeWVsbCtiZjIySUk1ZFEwTEJhUTBzNVB4WWovc0RBdzZL?= =?utf-8?B?cC9sNnp6RCtmZnY0OUpMNHFvamlzOGlDSGlzTnRTQ21vSmFRUFI2Zk5HK2cw?= =?utf-8?B?TDlBV2ZjUW5jYWF4Y1VBT1ZsK0ZkS0xmTjh5N2t6cGdxRUllZHpqUG0vMU1T?= =?utf-8?B?L24ybCtvYTVEVGprZ0tVV2xaR1NXTHlocXR1QkFNNmQyWVRZSEx2cGozRXRW?= =?utf-8?B?V0RSNFQzc2dRNlZ1ZG44WVlQRUxlbFE3MkhtZXpvMW1pY3kwdmR2b3R4OWZ0?= =?utf-8?B?djYzcXpjT1dJN2s3c3F1Z2ltM3dZTU5OZEpMc01FSEYvbDVxYkVQNGRmZnVs?= =?utf-8?B?dXcyckVoUEl2Uy9kUDVNQ2NNQ3ZvZ0kyRzRLdjB1cGVYc3JtSnZGUUEyZFM2?= =?utf-8?B?bzJOTGdyMUhDaWkyaWhMV3NHUzBmT0N4U1U1ZEg2NDJWaEFOZG5zK0xWU1hX?= =?utf-8?Q?/QbFGz6tt+QrpqDHNICtv/1o8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e715f0b2-cfb2-49b5-5734-08dac619755b X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 08:23:07.2998 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vxu5wEl6Sw5J2pJyfsmE95zl3T9+ECxbMY2dE1/tV0EMgnPtB8neFcL4YCtonh6zox/DFIJQxADMy1eQqQ9g8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8626 On 14.11.2022 09:14, Wei Chen wrote: > Hi Jan, > >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年11月14日 16:05 >> To: Wei Chen >> Cc: nd ; Andrew Cooper ; Roger Pau >> Monné ; Wei Liu ; George Dunlap >> ; Julien Grall ; Stefano >> Stabellini ; xen-devel@lists.xenproject.org >> Subject: Re: [PATCH v8 0/6] Device tree based NUMA support for Arm - >> Part#2 >>> So in this patch series, we implement a set of NUMA API to use >>> device tree to describe the NUMA layout. We reuse most of the >>> code of x86 NUMA to create and maintain the mapping between >>> memory and CPU, create the matrix between any two NUMA nodes. >>> Except ACPI and some x86 specified code, we have moved other >>> code to common. In next stage, when we implement ACPI based >>> NUMA for Arm64, we may move the ACPI NUMA code to common too, >>> but in current stage, we keep it as x86 only. >>> >>> This patch serires has been tested and booted well on one >>> Arm64 NUMA machine and one HPE x86 NUMA machine. >>> >>> [1] https://lists.xenproject.org/archives/html/xen-devel/2022- >> 06/msg00499.html >>> [2] https://lists.xenproject.org/archives/html/xen-devel/2021- >> 09/msg01903.html >>> >>> --- >>> v7 -> v8: >>> 1. Rebase code to resolve merge conflict. >> >> You mention this here but not in any of the patches. Which leaves >> reviewers guessing where the re-base actually was: Re-bases, at >> least sometimes, also need (re-)reviewing. >> > > I just applied the v7 to the latest staging branch, this work has not > Generated any new change for this series. I should have described it > clear or not mentioned this in cover letter. Sorry for confusing you! But you talk about a merge conflict. And that's what I refer to when saying "may need (re-)reviewing". The same happened during earlier versions of the series, except there I was aware of what you needed to re-base over because it was changes I had done (addressing observations made while reviewing your changes). This time round I'm simply not aware of what change(s) you needed to re-base over (which is why I pointed out that it is generally helpful to indicate on a per-patch basis when non-trivial re-basing was involved). Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 14 08:23:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 08:23:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443174.697676 (Exim 4.92) (envelope-from ) id 1ouUkW-00054j-0w; Mon, 14 Nov 2022 08:23:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443174.697676; Mon, 14 Nov 2022 08:23:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUkV-00054c-UX; Mon, 14 Nov 2022 08:23:23 +0000 Received: by outflank-mailman (input) for mailman id 443174; Mon, 14 Nov 2022 08:23:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUkU-0004kZ-Fi for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 08:23:22 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150042.outbound.protection.outlook.com [40.107.15.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98d15b0a-63f5-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 09:23:20 +0100 (CET) Received: from AM6P194CA0079.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::20) by VI1PR08MB9958.eurprd08.prod.outlook.com (2603:10a6:800:1c0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 08:23:18 +0000 Received: from AM7EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8f:cafe::97) by AM6P194CA0079.outlook.office365.com (2603:10a6:209:8f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 08:23:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT064.mail.protection.outlook.com (100.127.140.127) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 08:23:17 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Mon, 14 Nov 2022 08:23:17 +0000 Received: from 19d26e4bc034.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 83093BC0-515B-43F7-A9DB-9D0FC12365B5.1; Mon, 14 Nov 2022 08:23:12 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 19d26e4bc034.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 08:23:12 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB8470.eurprd08.prod.outlook.com (2603:10a6:10:406::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.5; Mon, 14 Nov 2022 08:23:06 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Mon, 14 Nov 2022 08:23:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98d15b0a-63f5-11ed-91b6-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NEVrn6M7TTUMIOgnfeioFwJQ6KASZmLS1OJhIHdzIRGGd1Abz8znyQHSCPOj7WIbfaRu3hAtsTUBCrlxQtU155YlL4LSYm5eWnkmMJV2D0Nwh/8e70crBcOAJK0uWQcjs9Yx5To+S6lnxInl0H0NwE4lS/aAitRRXAVdkXX62okiEsI70IWG+lqWxptXKOfvmW0nNLChgNyJCJf50HAjGu+Bju17j3YJsT3blO8USPLlclEzQbIaH/o5tKqrZdRwzpywOQ5n1eYbi6wjwSYvrt25+5F7yJ/odifWW2TUiLJsJiVEL5OF8Fupz6n3NUtFuGbCIOqzUVHlPvJPHeaIZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=udlqaRv59/uhgmT2ydhP1Tf+ZQ80ekLRtjCVDZyr1u8=; b=UD1B5zQreEZ8SzE3xAhaWD3FaofAETXqUePnVCXzKHzVKDwrhL+BqJ0bKTnDRVQ6q5fmlesxfWDEhT2DVXtLK5JALouKfR9VewQsdPaVH4lei6g4Br2IeH0d+b8Po4xq6rn2em6GVLvkbhaZi/kXrnrdsKs6TLU6QlKvwHCGL10wKA6C1f64Vh8wb7hYpIhVoZeog5W6nhKwGP/yIVekkrVBJ6di3YH04AE11YK2ouGkN9cFOUvDU2yczqc4qrfYP1TY+kVuaSgZFDv+1ibTfDgRdUMJCrTzMgJpHPLXq6IJJmwdCQH8NPECL41Rl3HYsYdwMRnnToBevcdQ1oJhVA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=udlqaRv59/uhgmT2ydhP1Tf+ZQ80ekLRtjCVDZyr1u8=; b=rvNUQDxpU9uQ1XlUC+MjGpHbm+LaPj8XZ1cH4VL/bhN/v/QgO2boYteXwzmMEcSLqIsLRsx+B4TOEJ9CCC1Ja83uOMYhvjLv31ol1e7lNyJ0BgOK+ssa4W22FxmS53WXcV12NeqdAPc9xhhqvTzU4ZW2v6LbH+DbjFDfoXo3nuY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aGfCd+F+xZOuYX2RgQiDHrqCP8OocjCtijBuarku4yr7Pd8h+qujNQUleJiSsGZ6jxmXxwNHMNsvwn3kLF/VVd4XQjUho31SVcSmkIpgOrgMJ+w8CSqBwIIVOB6fG3CsjGPuAbRjJpM6mpaHAYFNyNcFMlw3IYdkcORd4WtmDmf37Gx/FqcygUDIIez4j+36rs75pKYjgyDX8loEC3f+FY2FaqvaqbtfZdvbZ/S461GFz0P3KA120c1rnsMYFvEMDc4SvMa6nRXKJ1qxeP2UspeJbSKdP1HVs48Ta137vZgPnEfdFJK18c3Dh8zia/+7zKaV0tS+PFlWAipDIso2jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=udlqaRv59/uhgmT2ydhP1Tf+ZQ80ekLRtjCVDZyr1u8=; b=YIIrXFTuPRjq8hbWk6uglFL8Ty3dhkK4RGfkDeizT3XUQWCCLIp7k8MccH2Q/RxFdTRgNulgjkWkA7In3vcKXYj7gf8QzVuJ6EWaZXLMHxnKy7GoUOt/YHdGFyj7wx1nY0rZzBUv3JFBAJZQh4p/Ai6tqKZoKXmT54ehfhh1Ec+clEgfGiD6J4gNTkctcsEmZhwpMMABmWTMHw8j+Nh5pzm3pQdwUxjjN2JwpgqZHiZylvNSmdj/ZYVYW9VtVmcBeoCGHI16SaImqDsOIwqNs356x6wulSC64hz5Q5iSEKMR1TryMOO7bEEvVxCwixNxMluKByqhkl1gLUQo6wBGSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=udlqaRv59/uhgmT2ydhP1Tf+ZQ80ekLRtjCVDZyr1u8=; b=rvNUQDxpU9uQ1XlUC+MjGpHbm+LaPj8XZ1cH4VL/bhN/v/QgO2boYteXwzmMEcSLqIsLRsx+B4TOEJ9CCC1Ja83uOMYhvjLv31ol1e7lNyJ0BgOK+ssa4W22FxmS53WXcV12NeqdAPc9xhhqvTzU4ZW2v6LbH+DbjFDfoXo3nuY= From: Henry Wang To: Jan Beulich , Anthony PERARD CC: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Andrew Cooper , Jim Fehlig , xen-devel Subject: RE: vnuma_nodes missing pnode 0 Thread-Topic: vnuma_nodes missing pnode 0 Thread-Index: AQHY9iDYCXvlfuymEU2cRUBeAI3Esq49n+1wgABcSsCAABrwAIAAAERw Date: Mon, 14 Nov 2022 08:23:05 +0000 Message-ID: References: <2046b5fb-2533-02fe-69e8-f46174cf825d@suse.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 80A024D32941CE4C9584E98C7F14C9BC.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DU0PR08MB8470:EE_|AM7EUR03FT064:EE_|VI1PR08MB9958:EE_ X-MS-Office365-Filtering-Correlation-Id: 067f8354-6744-4f44-1809-08dac6197bb3 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SU711Vvq8vvgWEYSVhdWOILwXfSmVIoB/OV9OCcSJI6osvoY36IIgIu6macE4hCUL/1BfpLoePYZtwwkphWU285SLxjhi3BinFa0TX4d6TzMZpdSnNviMhZ6E8h1wTkjyW8cR/MdDHbWqMRYZrNUHWrHJnzVlg6MYmGyP+NVk+zteHaxxs1SbCrUoBDtAdD1oYr9JHulosIiSXe2CLUbePD2TQ9CH2vS+EldKLryfcXHQ7eHQV2tA+hPfFGE1zokNCLnxEe0aYnY+w9WqN61UvfPVxxUpP7bkHbH/vDJW048rlXYMKpIM01AeYKe/F4DSiQAHTmKICrqG7vofI8DoDSrA8s81EKNUxRrn1/UnI3XVj/PvfzdL020svTAtKkulxFYkrE3koVuBn7c6C5A5gW77iI4LH7yeKvoMeV/zMMN5AuWZqpj37y20m6k0CFOHnkXKXYAZ/4/P9hwE4j4M02g2tEdihuA22KgQY9kXBzu3BQP5BKQcdA/oBq4lQAV3mHEQe0E1N5MlYO+o9NrU3QXgLO0NduIDYmfhIxj2yQfzfLiJxScxlLnLRl2Gp3vxSChm9VDyDKEkEFVUTodPG4UTZLOhpOBfFXc8IQ72EIZY1zolZ6goCSMihMMXVJssOAxykalZ7AfKjqbpSQGa+mSk8BgJdT1BUFch1h7GceNibniw8mQxwei/aw9t3qE70Nj0Z6DOlvbzM2UQDtOFG5inQ2X+asKEwlIsyPbnsWUf8raEvfz8Pv0rD9JfMKF7OCAUZeAB7sk5rhU7kHOqA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(396003)(136003)(376002)(346002)(451199015)(83380400001)(86362001)(64756008)(122000001)(38070700005)(2906002)(41300700001)(52536014)(8936002)(5660300002)(38100700002)(7116003)(8676002)(66446008)(9686003)(66476007)(66556008)(6506007)(53546011)(26005)(71200400001)(7696005)(55016003)(54906003)(76116006)(478600001)(110136005)(4326008)(316002)(66946007)(186003)(66899015)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8470 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dca640b2-e9e3-4ea3-d5fa-08dac6197417 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Wv2Cbn6srD3HS/Vw3txWRndvX4xBarHF4sU9tNuxdGj+PMoBKw6FC0buxj2lk1rbnh6U3UTasEeMI6XB5o4k4FWR+NrmTjst65rrOwmL6XB01OkXbrMEmpJYi0EGUoIIUXYEGnnevf9R51K6WvcMjpTS57hiWW8yALm6THtaFYESz6fZ4frUvfrALpDLvdCJEdFoOx/6HDKUfpc33XoU3DJhIkgEfa0BEnnZPEYM0DSz2I4E0ovPrh+k/oVQV6AKlfQKpqhZX6yAF+QFpmqniIXeCyBMHY1XStOYAayV7XrX1iV0NNUxcL0rDwDUBPivThcmAKp+5ZwGCD5qAiAo/JHY7Wq/+oj5v6TIgqL9ePU7rPQgWoKwY1uCubilPWIXKTWkOarWNcnuAIxKnpiWoih15FaTmlw4I5T7ls+/Le5lYHrIKPn55qH77PZhMB1Z5gdZTovWupEkZJSFUmmvcQP1vhSdbR6dnnghhIru2W3i1ho4ZCnj3rMWacEA2Kvg9+yT2/erLJgCatU7mlVkLdyITOgCqqb8DE+prj2+/dgVsccVtJ3q35ma5IWXO/lc7gGZeakOwAYMQDZVjykHPFa/5Qg6StiA/d+nIJbOnKbEIcpL+9ttDhALCfy16HbvN23mzf4d4Tn85+GiFWAZVTGxOQ4oBAEvIyQt3FUrfv5WZQNKjgRoLirTFl1jgHbTu/PLoqe+tQEXHzerIKtnkXF0/+kykVhtjiv55rlDkCHWJkVxkB35hOEZ+K43kA9U X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39850400004)(376002)(136003)(451199015)(46966006)(36840700001)(8676002)(52536014)(4326008)(7116003)(41300700001)(336012)(47076005)(82310400005)(8936002)(5660300002)(9686003)(186003)(2906002)(316002)(53546011)(70586007)(26005)(70206006)(40480700001)(86362001)(36860700001)(33656002)(83380400001)(55016003)(82740400003)(81166007)(356005)(66899015)(54906003)(6506007)(110136005)(7696005)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 08:23:17.7538 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 067f8354-6744-4f44-1809-08dac6197bb3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB9958 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IHZudW1hX25vZGVzIG1pc3Np bmcgcG5vZGUgMA0KPiANCj4gT24gMTQuMTEuMjAyMiAwNzo0MywgSGVucnkgV2FuZyB3cm90ZToN Cj4gPiBTb3JyeSwgbWlzc2VkIEFudGhvbnkgKFRoZSB0b29sc3RhY2sgbWFpbnRhaW5lcikuIEFs c28gYWRkZWQgaGltDQo+ID4gdG8gdGhpcyB0aHJlYWQuDQo+IA0KPiBJbmRlZWQgdGhlcmUncyBu b3RoaW5nIHg4Ni1pc2ggaW4gaGVyZSwgaXQncyBhbGwgYWJvdXQgZGF0YSByZXByZXNlbnRhdGlv bi4NCj4gSXQgbWVyZWx5IGhhcHBlbnMgdG8gYmUgKGZvciBub3cpIHg4Ni1zcGVjaWZpYyBkYXRh IHdoaWNoIGlzIGJlaW5nIGRlYWx0DQo+IHdpdGguDQoNClRoYW5rIHlvdSBmb3IgbG9va2luZyBp bnRvIHRoaXMgaXNzdWUgOikNCg0KPiANCj4gSW50ZXJuYWxseSBJIGluZGljYXRlZCB0byBKaW0g dGhhdCB0aGUgd2F5IHRoZSBjb2RlIHByZXNlbnRseSBpcyBnZW5lcmF0ZWQNCj4gaXQgbG9va3Mg dG8gbWUgYXMgaWYgMCB3YXMgc2ltcGx5IHRha2VuIGFzIHRoZSBkZWZhdWx0IGZvciAicG5vZGUi LiANCg0KWWVhaCB0aGlzIGFsc28gbWF0Y2hlcyBteSBmaXJzdCB0aG91Z2h0LiBJIGFsc28gZGlk IGEgZ2l0IGJsYW1lIGFuZCBkaWRuJ3QNCnJlYWxseSBzZWUgc29tZSByZWNlbnQgY29tbWl0cyB0 aGF0IGNoYW5nZSB0aGlzIHBhcnQgb2YgbG9naWMuDQoNCj4gV2hhdCBJDQo+IGRvbid0IGtub3cg YXQgYWxsIGlzIHdoZXRoZXIgdGhlIGNvbmNlcHQgb2YgYW55IGtpbmQgb2YgZGVmYXVsdCBpcyBh Y3R1YWxseQ0KPiB2YWxpZCBpbiBqc29uIHJlcHJlc2VudGF0aW9uIG9mIGd1ZXN0IGNvbmZpZ3Mu DQoNCkxldCdzIHNlZSBpZiBBbnRob255IGhhcyBzb21lIGlkZWFzIDopDQoNCktpbmQgcmVnYXJk cywNCkhlbnJ5DQoNCj4gDQo+IEphbg0KPiANCj4gPj4gKEFkZCB4ODYgbWFpbnRhaW5lcnMgZm9y IG1vcmUgdmlzaWJpbGl0eSkNCj4gPj4NCj4gPj4gSGkgeDg2IG1haW50YWluZXJzLA0KPiA+Pg0K PiA+PiBTaW5jZSB0aGlzIHJlcG9ydCBtaWdodCBiZSByZWxhdGVkIHdpdGggdGhlIHJlbGVhc2Us IGlmIHlvdSBoYXZlIHRpbWUsDQo+ID4+IHBsZWFzZSBoYXZlIGEgbG9vay4gVGhhbmsgeW91IHZl cnkgbXVjaC4NCj4gPj4NCj4gPj4gS2luZCByZWdhcmRzLA0KPiA+PiBIZW5yeQ0KDQo= From xen-devel-bounces@lists.xenproject.org Mon Nov 14 08:34:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 08:34:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443183.697687 (Exim 4.92) (envelope-from ) id 1ouUv2-0006zd-4g; Mon, 14 Nov 2022 08:34:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443183.697687; Mon, 14 Nov 2022 08:34:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUv2-0006zW-1n; Mon, 14 Nov 2022 08:34:16 +0000 Received: by outflank-mailman (input) for mailman id 443183; Mon, 14 Nov 2022 08:34:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouUv0-0006zQ-J1 for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 08:34:14 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2040.outbound.protection.outlook.com [40.107.21.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1ddd6412-63f7-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 09:34:13 +0100 (CET) Received: from DB7PR05CA0025.eurprd05.prod.outlook.com (2603:10a6:10:36::38) by PA4PR08MB6318.eurprd08.prod.outlook.com (2603:10a6:102:e2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 08:34:05 +0000 Received: from DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:36:cafe::6f) by DB7PR05CA0025.outlook.office365.com (2603:10a6:10:36::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Mon, 14 Nov 2022 08:34:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT037.mail.protection.outlook.com (100.127.142.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 08:34:05 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Mon, 14 Nov 2022 08:34:05 +0000 Received: from d21dedf9b84e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B66C9A36-83C2-49FB-814C-661351483EFD.1; Mon, 14 Nov 2022 08:33:58 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d21dedf9b84e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 08:33:58 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB9PR08MB8675.eurprd08.prod.outlook.com (2603:10a6:10:3d1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 08:33:54 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5834.005; Mon, 14 Nov 2022 08:33:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ddd6412-63f7-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r63zZomc9U74+1Bh9OYsZ1IPa6dITlE3XkixBna1HC8=; b=BLL+m0scZx7DykFMbpG9Lvwy50JFIZW8jnZelB4GuokvJSCW99Ez8Z1hyPbqAtn2gCiYMgsEmDUBT13V9xjRIN3keqTZJD92Z05AXKq+5Z3Vy5hxu7WmiG25CGe8LXFwUAc8sM+dD7HZ+V7NUq3WgtapZmXz9vjIHEcX+eFTSrg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oM9IYadFdahKA17x7Hh+4B/cu3h4UkerMLABbA+I4A6VuYZkvvortOwpG3GVmdKfOewf1Op/E5rL38LRBEbbCwTDUVBx+xfgRmNPFUVcCNp9oUUMl3W0AY49pz3EbgW//1iD+iiToMzSL3zu4VFG6Tsey2EHkcL+itQFszwyDTMbq0sajoAcyU/aoPFl9YoYYeZQSPeJbp/KrLkhwuTkh6PnUCT72PnPjSIIwJCcl6mRTzB8iLBSI1hbmQk0Jgobnn0ldwDaGiJ5/W2Q3iKHt34ZQn1LrbIu7MKUVUuRiQcWItcdlpfGqa/8/KzcNDH6HOCzN73ujoajJzoVEgY4YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r63zZomc9U74+1Bh9OYsZ1IPa6dITlE3XkixBna1HC8=; b=SmOmexYwZk51+1msBiqNhC1BVLafKINtaRSBPWu8N7cB3Fa4smrY3dGC5X1Vpc9P3kJoKYtHa4bq73dnK0wp0uIB3c998n2uEeQIiKD/JH6jkOMajQ0ViwZfUFVZOd1x7GGiwH2HbjeFBH3hZ8e+CDvUeeAksby01R4Cq7gTtOOSBd9iqr5ypOrz1T8l2THs1f+9YDmmaI0XEm7enmWUPGpXvb20XBCj3xe6AyTllLpLdK+C2xLzZw+5eZwtLDExnKhWUzmJLhuehubscR1zR/pYAh4YHpeZn8teko/m0kr31wMBPqJzYBj5RcyhPbV7pHkdTYiXVr6R3Ki27s2F4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r63zZomc9U74+1Bh9OYsZ1IPa6dITlE3XkixBna1HC8=; b=BLL+m0scZx7DykFMbpG9Lvwy50JFIZW8jnZelB4GuokvJSCW99Ez8Z1hyPbqAtn2gCiYMgsEmDUBT13V9xjRIN3keqTZJD92Z05AXKq+5Z3Vy5hxu7WmiG25CGe8LXFwUAc8sM+dD7HZ+V7NUq3WgtapZmXz9vjIHEcX+eFTSrg= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v8 0/6] Device tree based NUMA support for Arm - Part#2 Thread-Topic: [PATCH v8 0/6] Device tree based NUMA support for Arm - Part#2 Thread-Index: AQHY9/NBdTAzy3F6U0ar/3rX7ynbh64+D8cAgAABF9CAAAPhgIAAADOQ Date: Mon, 14 Nov 2022 08:33:54 +0000 Message-ID: References: <20221114063451.473711-1-wei.chen@arm.com> <3aa067b2-fa49-326a-c5a0-6735bc95951e@suse.com> <2beb3d17-99f6-77fe-a5d6-d60e665f01d5@suse.com> In-Reply-To: <2beb3d17-99f6-77fe-a5d6-d60e665f01d5@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F9316812B391AD488484EADEEDEB89F3.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|DB9PR08MB8675:EE_|DBAEUR03FT037:EE_|PA4PR08MB6318:EE_ X-MS-Office365-Filtering-Correlation-Id: 191046d0-5d0d-440c-7874-08dac61afd92 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Y9oj1rqn979jggL74S8UM2TScOjNCYAFyojpROduYDbt7zK5dZX2fJDUWng86qLhLFMsg7eWYIQrYxynQC1LGhtguXn/rWp9IfM1zXsbVJYsAv2UJrz8AuaJzJuqr4pnQxyAKXBxd8SUdkYM2DLrWLxPI35Rjpnfs1RvFgSbzF7slz+XylCzEiyS7IB+3qb3ghdNY8nEi9aXe3JC72Kf9PCQ+M07+H4/Lt0fkucnP1HMd+hcBE0rZQkwcgei44an2mQ0Z7tij9iP91Xx5vex4LwMKRTw84FhtkrKZHiAyN00PpJJPnMlUb2q2uoPWLZnDteninMsl2ob+aZUhdMqVUNC4GvJLhEp7Lx0+7QGiVKNS/y1ASA9goit5Y6MrS9FAPtLiCV6ChjINeKDX9m/VT2PM+UX1iQRkm4cknKza15fz7gHnqW+/un0N0iUagxKYBafCDbMhrTu0J9+6VshZMYo0y1Np62P4qiq9e4NBJOYf/lJXWaX5m7r+a8ULXFB3p7vf20Bu3w626wPh8TlTXgk74OteYhKOKVZQIOjKe83q9FsGcp/p70QheskR/dqUC7DF0v79/rJtJyrFQGB7C8E6je2DnerYLSdJU6rrnuOkDaoPd8VmhsOSFw35nBl3LN1u9426ZmyHfCKF7PBLUZPqQcSunYwbPlHUSJqXX1+IKN4xNl0YoiqMNYsOp44tPx0Xx9nh+KMe3JJ6pS+o71NQ9rBNAMzZNKRqa5em5hMB1Qxs6QM318CNUPDqm0y2/ZoiCLJGLhGRXeO+H1XNH2Eg6jlrjY5PIEM01l8+6Agp9z9kpAqUwcDw2CBSmUzxUQCXsB3+oF/SFmp1LkP4w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(376002)(346002)(39860400002)(396003)(451199015)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(122000001)(38100700002)(52536014)(2906002)(8936002)(38070700005)(4326008)(8676002)(5660300002)(83380400001)(41300700001)(71200400001)(478600001)(53546011)(7696005)(33656002)(6506007)(9686003)(186003)(6916009)(54906003)(316002)(55016003)(86362001)(966005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8675 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 91e07873-0478-45f6-eab3-08dac61af6ec X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I4vv8qku45BNnYNn/ll9Zqz6tz43bvTJxxxmHhGQ/zPUhbpYxK9X9fOioICx1OwlF/jS4vaaVhK//lxer0EcK7VL/qPiDHKnkpZx2DgyqDu72Bipr6YjSmOMWB8Lv2ntZqchjjgHdnnsyCFkgyCjiZ2l0DhCU3+nZrtJp3RfPemmeI7DzMYM9/gESEl8GKFcNWU8Uhpf5NKxYWzY6K5bqL5fKZBLhxClATq1lXIxj1Sdl18ahWBNWrBVUEaMq6nEeujTnzsgttl4PFGPJnaIALXub+YhXFyMDHxir3vkv+YoPAHLqrc/tDk5KOzBDWcfI3gkbmndM1wgxIh+vj/hoR5X20XgmQ6nTMiyWqDz/d72gNfgCQ3s2eNiFVpgC2W/zIERtbUhGqGbC0yi2taLdCa3Q+tMKpiJY5ouQcI8qF5MtpRJGXGV2Ju4aAbiVonBPboZO3foClIBZcj8xmzHhAuNqbYEgK2Y7234Pzp8cNbniRhQRrKlXI62UjiOhxFhh8yM03+Uo5++2JzgeSDWDQlPvYLWLLedRZcmi6p0S3WpqHQfpMqrE0iUKiLUE54aGuUWjivW6ejPbsGPrcOm2alAmDytYphHBux8Sb/irwREiiGIuc5Y6ZVt5n4eMiwvA+zt/5k64fF/jnXiepKQXRc8KBe8fuf2zT5xb3xlWeAZSX6dyuE55QScTYwsb/blLvP1zAu2XoKqzJhOQKey3zbjclYyPt08v2BXQVjpDP6UysVno3qLayJ0eow+VEzHT8YwJardWbFy7GULnIve6HBobW7L3bldZEDZlKoRlvCKeWDwMKr9Vt49+AKs6auE1bfSLBXp5iB+J4ChfOk8ig== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(33656002)(82740400003)(41300700001)(2906002)(356005)(81166007)(6862004)(40460700003)(83380400001)(36860700001)(86362001)(54906003)(70206006)(70586007)(478600001)(47076005)(966005)(336012)(4326008)(316002)(186003)(82310400005)(40480700001)(52536014)(8936002)(5660300002)(53546011)(55016003)(26005)(7696005)(6506007)(8676002)(9686003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 08:34:05.2030 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 191046d0-5d0d-440c-7874-08dac61afd92 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6318 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDEx5pyIMTTml6UgMTY6MjMN Cj4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPg0KPiBDYzogbmQgPG5kQGFybS5jb20+ OyBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgUm9nZXIgUGF1DQo+ IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgR2Vv cmdlIER1bmxhcA0KPiA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsgSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz47IFN0ZWZhbm8NCj4gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVs Lm9yZz47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BB VENIIHY4IDAvNl0gRGV2aWNlIHRyZWUgYmFzZWQgTlVNQSBzdXBwb3J0IGZvciBBcm0gLQ0KPiBQ YXJ0IzINCj4gDQo+IE9uIDE0LjExLjIwMjIgMDk6MTQsIFdlaSBDaGVuIHdyb3RlOg0KPiA+IEhp IEphbiwNCj4gPg0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PiBGcm9tOiBK YW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+ID4+IFNlbnQ6IDIwMjLlubQxMeaciDE0 5pelIDE2OjA1DQo+ID4+IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gPj4gQ2M6 IG5kIDxuZEBhcm0uY29tPjsgQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT47IFJvZ2VyDQo+IFBhdQ0KPiA+PiBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPjsgV2Vp IExpdSA8d2xAeGVuLm9yZz47IEdlb3JnZSBEdW5sYXANCj4gPj4gPGdlb3JnZS5kdW5sYXBAY2l0 cml4LmNvbT47IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyBTdGVmYW5vDQo+ID4+IFN0 YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcNCj4gPj4gU3ViamVjdDogUmU6IFtQQVRDSCB2OCAwLzZdIERldmljZSB0cmVlIGJh c2VkIE5VTUEgc3VwcG9ydCBmb3IgQXJtIC0NCj4gPj4gUGFydCMyDQo+ID4+PiBTbyBpbiB0aGlz IHBhdGNoIHNlcmllcywgd2UgaW1wbGVtZW50IGEgc2V0IG9mIE5VTUEgQVBJIHRvIHVzZQ0KPiA+ Pj4gZGV2aWNlIHRyZWUgdG8gZGVzY3JpYmUgdGhlIE5VTUEgbGF5b3V0LiBXZSByZXVzZSBtb3N0 IG9mIHRoZQ0KPiA+Pj4gY29kZSBvZiB4ODYgTlVNQSB0byBjcmVhdGUgYW5kIG1haW50YWluIHRo ZSBtYXBwaW5nIGJldHdlZW4NCj4gPj4+IG1lbW9yeSBhbmQgQ1BVLCBjcmVhdGUgdGhlIG1hdHJp eCBiZXR3ZWVuIGFueSB0d28gTlVNQSBub2Rlcy4NCj4gPj4+IEV4Y2VwdCBBQ1BJIGFuZCBzb21l IHg4NiBzcGVjaWZpZWQgY29kZSwgd2UgaGF2ZSBtb3ZlZCBvdGhlcg0KPiA+Pj4gY29kZSB0byBj b21tb24uIEluIG5leHQgc3RhZ2UsIHdoZW4gd2UgaW1wbGVtZW50IEFDUEkgYmFzZWQNCj4gPj4+ IE5VTUEgZm9yIEFybTY0LCB3ZSBtYXkgbW92ZSB0aGUgQUNQSSBOVU1BIGNvZGUgdG8gY29tbW9u IHRvbywNCj4gPj4+IGJ1dCBpbiBjdXJyZW50IHN0YWdlLCB3ZSBrZWVwIGl0IGFzIHg4NiBvbmx5 Lg0KPiA+Pj4NCj4gPj4+IFRoaXMgcGF0Y2ggc2VyaXJlcyBoYXMgYmVlbiB0ZXN0ZWQgYW5kIGJv b3RlZCB3ZWxsIG9uIG9uZQ0KPiA+Pj4gQXJtNjQgTlVNQSBtYWNoaW5lIGFuZCBvbmUgSFBFIHg4 NiBOVU1BIG1hY2hpbmUuDQo+ID4+Pg0KPiA+Pj4gWzFdIGh0dHBzOi8vbGlzdHMueGVucHJvamVj dC5vcmcvYXJjaGl2ZXMvaHRtbC94ZW4tZGV2ZWwvMjAyMi0NCj4gPj4gMDYvbXNnMDA0OTkuaHRt bA0KPiA+Pj4gWzJdIGh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvYXJjaGl2ZXMvaHRtbC94 ZW4tZGV2ZWwvMjAyMS0NCj4gPj4gMDkvbXNnMDE5MDMuaHRtbA0KPiA+Pj4NCj4gPj4+IC0tLQ0K PiA+Pj4gdjcgLT4gdjg6DQo+ID4+PiAgMS4gUmViYXNlIGNvZGUgdG8gcmVzb2x2ZSBtZXJnZSBj b25mbGljdC4NCj4gPj4NCj4gPj4gWW91IG1lbnRpb24gdGhpcyBoZXJlIGJ1dCBub3QgaW4gYW55 IG9mIHRoZSBwYXRjaGVzLiBXaGljaCBsZWF2ZXMNCj4gPj4gcmV2aWV3ZXJzIGd1ZXNzaW5nIHdo ZXJlIHRoZSByZS1iYXNlIGFjdHVhbGx5IHdhczogUmUtYmFzZXMsIGF0DQo+ID4+IGxlYXN0IHNv bWV0aW1lcywgYWxzbyBuZWVkIChyZS0pcmV2aWV3aW5nLg0KPiA+Pg0KPiA+DQo+ID4gSSBqdXN0 IGFwcGxpZWQgdGhlIHY3IHRvIHRoZSBsYXRlc3Qgc3RhZ2luZyBicmFuY2gsIHRoaXMgd29yayBo YXMgbm90DQo+ID4gR2VuZXJhdGVkIGFueSBuZXcgY2hhbmdlIGZvciB0aGlzIHNlcmllcy4gSSBz aG91bGQgaGF2ZSBkZXNjcmliZWQgaXQNCj4gPiBjbGVhciBvciBub3QgbWVudGlvbmVkIHRoaXMg aW4gY292ZXIgbGV0dGVyLiBTb3JyeSBmb3IgY29uZnVzaW5nIHlvdSENCj4gDQo+IEJ1dCB5b3Ug dGFsayBhYm91dCBhIG1lcmdlIGNvbmZsaWN0LiBBbmQgdGhhdCdzIHdoYXQgSSByZWZlciB0byB3 aGVuDQo+IHNheWluZyAibWF5IG5lZWQgKHJlLSlyZXZpZXdpbmciLiBUaGUgc2FtZSBoYXBwZW5l ZCBkdXJpbmcgZWFybGllcg0KPiB2ZXJzaW9ucyBvZiB0aGUgc2VyaWVzLCBleGNlcHQgdGhlcmUg SSB3YXMgYXdhcmUgb2Ygd2hhdCB5b3UgbmVlZGVkDQo+IHRvIHJlLWJhc2Ugb3ZlciBiZWNhdXNl IGl0IHdhcyBjaGFuZ2VzIEkgaGFkIGRvbmUgKGFkZHJlc3NpbmcNCj4gb2JzZXJ2YXRpb25zIG1h ZGUgd2hpbGUgcmV2aWV3aW5nIHlvdXIgY2hhbmdlcykuIFRoaXMgdGltZSByb3VuZCBJJ20NCj4g c2ltcGx5IG5vdCBhd2FyZSBvZiB3aGF0IGNoYW5nZShzKSB5b3UgbmVlZGVkIHRvIHJlLWJhc2Ug b3ZlciAod2hpY2gNCj4gaXMgd2h5IEkgcG9pbnRlZCBvdXQgdGhhdCBpdCBpcyBnZW5lcmFsbHkg aGVscGZ1bCB0byBpbmRpY2F0ZSBvbiBhDQo+IHBlci1wYXRjaCBiYXNpcyB3aGVuIG5vbi10cml2 aWFsIHJlLWJhc2luZyB3YXMgaW52b2x2ZWQpLg0KPiANCg0KSSBoYWQgdGhvdWdodCBpdCB3YXMg YSBjb2RlIGNvbmZsaWN0IGJlZm9yZSwgYmVjYXVzZSBvdXIgaW50ZXJuYWwgZ2Vycml0DQpzeXN0 ZW0gbWFya2VkIHRoYXQgdGhpcyBzZXJpZXMgaGFzIGEgbWVyZ2UgY29uZmxpY3QuIEJ1dCB0aGUg YWN0dWFsDQpzaXR1YXRpb24gaXMgb3VyIGdlcnJpdCBzZXR0aW5nIHBvbGljeSBwcm9ibGVtLiBU aGVyZSBhcmUgbm8gY29kZSBjb25mbGljdHMNCmluIHRoZXNlIHBhdGNoZXMgdGhlbXNlbHZlcy4g V2UgYWxzbyBkaWQgbm90IG1vZGlmeSB0aGUgcGF0Y2ggdG8gcmVzb2x2ZQ0KdGhlIGdlcnJpdCBj b25mbGljdHMuIFJlZ2FyZGxlc3Mgb2Ygd2hldGhlciBpdCBpcyBhIG5ldyBvciBvbGQgdmVyc2lv biwNCmlmIEkgbW9kaWZ5IHRoZSBwYXRjaCwgSSB3aWxsIHJlbW92ZSB0aGUgcmV2aWV3ZWQtYnku DQoNClNvcnJ5IGZvciB3cml0aW5nIHRoaXMgYW1iaWd1b3VzIGRlc2NyaXB0aW9uIGluIHRoZSBj aGFuZ2UgbG9nLg0KDQpDaGVlcnMsDQpXZWkgQ2hlbg0KDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Mon Nov 14 08:39:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 08:39:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443187.697699 (Exim 4.92) (envelope-from ) id 1ouV0P-0007lb-Pj; Mon, 14 Nov 2022 08:39:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443187.697699; Mon, 14 Nov 2022 08:39:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouV0P-0007lU-Mp; Mon, 14 Nov 2022 08:39:49 +0000 Received: by outflank-mailman (input) for mailman id 443187; Mon, 14 Nov 2022 08:39:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouV0N-0007lK-T4; Mon, 14 Nov 2022 08:39:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouV0N-0005mD-QJ; Mon, 14 Nov 2022 08:39:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouV0N-0003r9-Dn; Mon, 14 Nov 2022 08:39:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouV0N-0008CO-DH; Mon, 14 Nov 2022 08:39:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SSc3Poo7IwfETPzZY0FAZXJ3SBTv/eGmU+7G/cszqhk=; b=VSOlp0Y7rvzV/cF5n3mLqsbe/k hWbcxIujMWDoAzZI/yHavSMjEjWLB1TLSBES9HoTLETC3ef81BTfHTPnu/yk7+swDYrlWqSZwPhTX DWUgiVeTwemgsQt9Gv9K2pAhFk7kg4xWljdInPf3ggDRVaYVZlVzfmGmFuyYLCzVIrmg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174761: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt-raw:xen-boot:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:windows-install:fail:heisenbug qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=305f6f62d9d250a32cdf090ddcb7e3a5b26a342e X-Osstest-Versions-That: qemuu=6a4cff8e1a80bafc4b8fe2bfb10081f4880d1b3b From: osstest service owner Date: Mon, 14 Nov 2022 08:39:47 +0000 flight 174761 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174761/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-raw 8 xen-boot fail in 174756 pass in 174761 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail in 174756 pass in 174761 test-amd64-amd64-xl-qemuu-ws16-amd64 12 windows-install fail in 174756 pass in 174761 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 174756 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-pair 10 xen-install/src_host fail like 174749 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174752 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174752 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174752 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174752 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174752 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174752 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174752 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174752 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 305f6f62d9d250a32cdf090ddcb7e3a5b26a342e baseline version: qemuu 6a4cff8e1a80bafc4b8fe2bfb10081f4880d1b3b Last test of basis 174752 2022-11-13 01:10:32 Z 1 days Testing same since 174756 2022-11-13 11:40:07 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Bin Meng Philippe Mathieu-Daudé Philippe Mathieu-Daudé Richard Henderson Song Gao Stefan Hajnoczi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 6a4cff8e1a..305f6f62d9 305f6f62d9d250a32cdf090ddcb7e3a5b26a342e -> upstream-tested From xen-devel-bounces@lists.xenproject.org Mon Nov 14 09:26:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 09:26:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443199.697710 (Exim 4.92) (envelope-from ) id 1ouVjJ-0001ag-NF; Mon, 14 Nov 2022 09:26:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443199.697710; Mon, 14 Nov 2022 09:26:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouVjJ-0001aG-H6; Mon, 14 Nov 2022 09:26:13 +0000 Received: by outflank-mailman (input) for mailman id 443199; Mon, 14 Nov 2022 09:26:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouVjI-0001aA-BO for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 09:26:12 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20043.outbound.protection.outlook.com [40.107.2.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c5dbe49-63fe-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 10:26:04 +0100 (CET) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM7PR04MB6949.eurprd04.prod.outlook.com (2603:10a6:20b:102::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Mon, 14 Nov 2022 09:26:01 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5%3]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 09:26:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c5dbe49-63fe-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tas0LWHppEWz14yazVTBgFK9wpYrXX8CSg5euVN938oWgHwW19UKNpXglxhoGKfO2vO6azSkt6+OFEHvi+XI2hd0ZuyLeV9AMSHMkE7H8xvv0S5XiKhw/TmzmjXVi/5S2kd8qwFg3p5Y8912hsS14QkLGI1Cj3eH/6XdiYWNTR433S7USnHe0v04tR4MREk/qjkK91D0Eo39P0ecVQbNsnW5pmNo7V0xVFrxCkD8+awkhub5QmCHM3J03OVvBDQuxf5Uri65Xc9ean4OKFZYb6sVplfcGi4/CBYP4RMtYiGJRyI+vDBRPxPJi8qoIk7X9dsYRmc6q3MW62pSrwKSxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UdAL1XpAjq4WoxGL5qA2Foa6E74MDjQhd1Bmh15UbTc=; b=XrjiQ+B3YASVixOI4jYJop//8gSLcyQLx0yyE+lUZQrq+SYKgXSTh9l5KqNli+IchJujCchX05YNkXvdsY32u+L7b8O5lHJtSOUApyURPUCbKP3Y2+BEkc1XnTrrITXSiAOTHu+L5CWi5UJEYRaHtntnS0dfgbizJG1FACjbaxzGGhApZTKbwN/38V4DXeqH8Zl/AYSZ5XkimCb5AoXdEHSBuOUARA26lGPeUwbYwlflcbHjVhFSEkLYjGus2ea68gqiLZXJfWp+zdRkSkqQl2eZhV176FJU7YmE5JN6REdIw+qHc5keNtNhdnWVE+HnFTOzJTSg3ogRz1fNitY1CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UdAL1XpAjq4WoxGL5qA2Foa6E74MDjQhd1Bmh15UbTc=; b=iZxBiNtJAih4OE5AvjMd4sDWyAitj3IqJGCPsKuW98X9UeOhQWwAoxI/4NU8G8aCFY7iWHUJxJqUGFc3fb5fHqtpWW+gjh6gwhSUJQx4zGv/6P54MyHeMGv1KcOgHxmrrg+mo+FPm/4hvMb9y6uCL2FzyoYr+ukOKoHR9Lg4kkuVmQ9vLDrOE5bzqukUXEz/BB5M55C+kzDXhTUivbe3PpvHJc73WkH+RVVg3i3l0zZgcosw/IDcU16Grmq37A2bnHjf2S6hYbagshLPl+5Bs9vX4bTiYgNZZ8inIyt1NhiVg0DaLZ2bDQU+cTeYSyayCvv1c5zzInX/IV9NR+7Qtg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9ba6748c-ca72-a36a-05f7-dab0334e1a61@suse.com> Date: Mon, 14 Nov 2022 10:26:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Content-Language: en-US To: Juergen Gross , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper Cc: xen-devel@lists.xenproject.org References: <20220729070416.23306-1-jane.malalane@citrix.com> <1918c63f-0065-b468-3691-de6e314f4374@suse.com> <9ab99257-844b-de15-cd20-7cda61295186@suse.com> <2476e467-1c31-91f4-1e75-86723b8da486@suse.com> <3cd62b0b-a131-b709-4244-0ae694c3d022@suse.com> <7a7553b2-79c1-759d-b020-c75b3118661f@suse.com> From: Jan Beulich In-Reply-To: <7a7553b2-79c1-759d-b020-c75b3118661f@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::7) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AM7PR04MB6949:EE_ X-MS-Office365-Filtering-Correlation-Id: 356affbd-f89b-4bda-f56b-08dac6223f15 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iAyfDQGRL4LpyqrCAuWebfaJHJ/hsWw9kV3rJj3ldYfWt9/IT5+5gE5HvaJitBV0erVeV7jQ8j7i2Rwj30yAeR9AivbcKVyxKsxeQfBxz0PP1eKuaJEXB+LvGJO3PzSV2rKlr4VjJmiZMTAIrqznBwKvBOCRMctnosWIhxQI9N8q+ljqDz4zHQ12h1L2ggKA2Fpy+NS43/bpKjBz+LEGtP83JoSFbRRjMvRF+MXWTNGk/Z+kkzkOsCDoSWkWodM6BZZUIfiPXopBRVvezkSuwOCqDCneAsoWV/CnmhIwIVlATiIbQRr+aR4E+OjgsisKvTWZo8F+AAlGdJHCXQA6nCxBykq0XTjNbQUeYfNafOpr8+lHSqUYatrgANrHS2K9P0MPVbEMIS2h3bPmkEXf4DACqX+uu2BC8usNToszczI/5CDL6NopCTUZi7hHnPamF0wopdBTw3/TY7sE9hqdLV9dCqP8UoSpgm8n3tsD+hrtp9FYIdvBO5yLrr3VBk/SNhtsQhoueAzYSGsPVxdrylsiep6yLVIcJKSQ0ftn1R3sQDh+AfkAwTycBG4jWU+7LhNyq4NFlQ1n/NUZx9oXutmvOEo/tOWhSTVOL2Lc5KMlg+hhHGdd6fyQpvulK0c5wufxa+qJcMwL2HU3F3S2RzVSB2i1QGCjbgc5ww8v9wHnaqA8pWljDNn7gJyr47wY6nAWcnc8pkWsIS49X15XQpR8kxCnfg4HV7oM1qfpLqScLAKlrr2Kjsv8goe+TdTnRtc/xQCql/vpBXFtvzAfwBrxF4sgBIxXOW1sEBADHLY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(366004)(376002)(346002)(136003)(396003)(451199015)(31686004)(6486002)(6506007)(478600001)(110136005)(53546011)(6512007)(66476007)(66946007)(26005)(66556008)(8676002)(36756003)(2616005)(8936002)(41300700001)(4326008)(2906002)(5660300002)(186003)(31696002)(316002)(38100700002)(83380400001)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjRTcUdVWUVnUjlyNjdEc0dXckx2c21jc2Z0RytIWTRma3JnSndqWVhkcCsr?= =?utf-8?B?K29ubmc4OHBUOUwzeHppaGUrbVRFMEY3UDQwM2RpTnpQaVlCUTRXVXRkQmhh?= =?utf-8?B?QzA5ekdGUkpKL1M1SzUzK0NPTUtxMzdkS1liUUUydjJwbzA2VWZYTmRzV0ha?= =?utf-8?B?cUlSZVdOOG9ldjZiOHZqK1lTT21vRVZlWEh0UlE4Wm9jMlNKR0FVL00vTnZn?= =?utf-8?B?eWI5MExHVW9GU2YvSmNHWG1NT2ZSNmFSUXU3UlNCTU5KaGZiSnJZL3p2QkEz?= =?utf-8?B?dGQweFdiVU1EU2FHQklJMDEzREdGN2trYUxqSU5BcDhnNFkyblc2eXMzSCt5?= =?utf-8?B?V2FrWjlFSkxSZGNPR2tUbUZKZnNXQ1JNTVo3ZjV6Z0VkS2o5d3B2cDR3K2Ji?= =?utf-8?B?VlVIKzNNY1htcVFpcjFOcXZ3ZkhWOTdwL2NrVy9TdTFNb2p1UGttWk5KVW9s?= =?utf-8?B?QTVobDJIZUdJYSs4bERkcXJFaTBhNHZLb1dMSTRpOTQ5SUIyUVNHWVd3bUJs?= =?utf-8?B?dUV6eDdQWEI2RHlaVXBDVFlXT1M2MmRqM05MYm03ZWxJd3ZNbzI1dUp0VXk0?= =?utf-8?B?NnNjNjlWZmVhMHkzSDBhaWxUSU9NeW1xSWgyZmhwNm5PaFhsc3JSOHh2VWZF?= =?utf-8?B?Y0tOZ1NqRkJRNWJrNnZqN250YUxqY2JWOUdEK0U2SUUzZnlYZ0xSWHFWMFlU?= =?utf-8?B?MVZ4c3RIN3dKdUZDTVRoTlduSGFpUlVpRHpxS1MyMmU3MHVkMjYyc1pWUEU4?= =?utf-8?B?NXliaWFKZDVuN0dveksvZTA2Wk12SGZJMmkyMDdpLzhkSU42aW5DaVQ3VVNK?= =?utf-8?B?bHI4N1I1cnVGekllM3ZiZWNOZytONW4yUGZNY3N0M1ZOeTRRYXM5VnhXekNh?= =?utf-8?B?QzNuL3BsYXNPWFcxSVB3WFp3UXVKNjV0Qkl3VEQrUFdEcnFQL1FIcTUzS1VW?= =?utf-8?B?bkJBSlJjcXBhQXlwVFEvWFZ5UWJueklRQUtZeXlJUHNyMUhFa2dzMGsrUnBF?= =?utf-8?B?ZFFCbzhpR09Lenh4WFRUbjJwTGlueHhXSSt0bXBFeW43ek4vUEhNSnYvVTJx?= =?utf-8?B?aUVveG1BK3g1anNZbEtrb1M2ZUlaMTZTUWpSODZmWWlsMkRCS3dXbVppV1hv?= =?utf-8?B?c0NKK042ZitiaUt3Tk5yVHNIdWVaVVJFZUxkQk95dloyVXlqZjhnMmdVMFFO?= =?utf-8?B?RENYWDQrZzEzY05ON1ljOUk4Szl5S3IzNjl1QVpKMWUvWjY2UE9Dck0vVjZI?= =?utf-8?B?SmR1cndNQ09CRzNzV3dXZWhlR1grQVF3aU04akVlanpLWmpaQ0JPMVFTV2Y5?= =?utf-8?B?WHp5SXpuQUdJY3NvRFlGR0R1bE9welhybm1PdHVaV0hDZlZ6SlhQTHQ1Nm13?= =?utf-8?B?YXdPN0t4YWp2R2pIN1hiTzZSc2Y1V2ZhejdlNHZYTFQ3cjViRXNsV3M2MTVn?= =?utf-8?B?MHUxQzlSREFPdnV5K1M5NXRjZW5lbUVNc0tMZXJyT0I5c1pXTDh3RURkZEdo?= =?utf-8?B?Ym13VUFqRnJwS0ZheUV6c0JZR3QyVnF1NmNXQ3p0d0NZNGpqYk9sU3hKOWph?= =?utf-8?B?NHl0U1h5NUVORk9TRHFBdHVWZ1pFZkNnSVNQVGxRcFBtSUlpbWh0ZWlCS002?= =?utf-8?B?V2psSlpQNk9IUlUycENjaFFlSUliUk54Mkl4cVJxN0EvSzF1NndJVDBPUWxU?= =?utf-8?B?a3FtMHdCWTQyWkdHd21FaGF6VzB6bDZkZS80SVVkUUdrd2JxUVFpMkZzMjQ4?= =?utf-8?B?elRRcjN2ZjFTMmovL2VhcGczZm96cDRWMTNhWWJrektDa2tRWDMzRlFvd0Rr?= =?utf-8?B?UEw3SHAxeEhVVU40bjB3eGNoY2c3ZEExK0MzTUFodnVwZGhOMWZ5Y015N09x?= =?utf-8?B?ZGRLL0NjcXBRRW5uRDVNaWtON1ZJaDJ3dTgzMzV6SWlNVjNDWlcxUzdma2E1?= =?utf-8?B?aHJ5aUplTmtka0dLSnZ4L0VzU3pnSjE4VHFTdWdVcWJTeEFOQVFBYXFaOEVZ?= =?utf-8?B?bU1QbHoza3RpcGFJbHJzdEpTNGxibnlkZTloT2ZEUzBDWWdvSGYvZk1tYnVY?= =?utf-8?B?dTNTL1VpWjZEY1BEQjU3R3BVTDVhQVNoOWhUTHcwMjA2M2JjZlNXY25Ob3ky?= =?utf-8?Q?mxyi4PctF5Tg7IDCqIHymD1Gw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 356affbd-f89b-4bda-f56b-08dac6223f15 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 09:26:01.7500 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X5xgP2R+5ZQM7flswYsn6L3czrDL+aCu74SlKukyNt1lkgrMtxBvEAVHHScwB7qpmrLyUf2KVGgSpirkQ/Pxlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6949 (shrinking Cc list to just xen-devel@) On 11.11.2022 15:50, Juergen Gross wrote: > On 11.11.22 14:17, Jan Beulich wrote: >> On 11.11.2022 13:44, Juergen Gross wrote: >>> On 11.11.22 10:01, Juergen Gross wrote: >>>> Writing a patch now ... >>> >>> For the APs this is working as expected. >>> >>> The boot processor seems to be harder to fix. The related message is being >>> issued even with interrupts being on when setup_local_APIC() is called. >> >> Hmm, puzzling: I don't recall having seen the message for the BSP. Which >> made me assume (without having actually checked) that ... >> >>> I've tried to register the callback only after the setup_local_APIC() call, >> >> ... it's already happening afterwards in that case. >> >>> but this results in a system hang when the APs are started. >>> >>> Any ideas? >> >> Not really, to be honest. > > I might be wrong here, but is a bit set in IRR plus interrupts enabled > enough to make the kernel happy? If you add in PPR, then yes. > The local APIC isn't enabled yet when > apic_pending_intr_clear() is being called, so IMHO the hypervisor will > never propagate the bit to ISR. What would suffice is an interrupts-enabled window between the hypercall and apic_pending_intr_clear(), like is occurring e.g. in timer_irq_works() (which is what I was guessing might avoid the issue on the BSP). As an aside - it may be the hypervisor or hardware, depending on APIC virtualization capabilities of the latter. > I didn't find any specific information in the SDM regarding "accepting > an interrupt" of a disabled local APIC, but maybe I didn't find the > relevant part of the manual. Indeed much needs to be inferred from how things have been written for all the years, rather than being explicitly said. This specific aspect is probably worse, because you can't really infer the behavior from anything that's written anywhere (afaict; or maybe like you I haven't been able to spot relevant text). The section that's looks to be supposed to have this information is "Local APIC State After It Has Been Software Disabled", but behavior as to IRR is only explicitly described there for things already "in progress" when the enable bit is cleared. I'm inclined to infer that no such processing would occur afterwards anymore, until the enable bit was set again. Which raises the question whether in the hypervisor a call to vlapic_enabled() isn't actually missing from hvm_assert_evtchn_irq() before calling vlapic_set_irq(). If so, a Linux side change would likely be unnecessary. The problem then is that if an upcall was already pending, it would never be delivered to the vCPU (since vcpu_mark_events_pending() is a no-op when the pending flag is already set, even subsequently arising causes would result in no further signaling). IOW adding the check there would likely need to be accompanied by a further change elsewhere - e.g. adding of a (conditional) call to hvm_assert_evtchn_irq() (or directly to vlapic_set_irq()) when the software-enable bit is set by the guest, much like we already call pt_may_unmask_irq() there. Andrew, Roger - do you have any thoughts here? Similarly I wonder whether that call to hvm_assert_evtchn_irq() is actually necessary when evtchn_upcall_pending is "false". Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 14 09:28:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 09:28:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443202.697721 (Exim 4.92) (envelope-from ) id 1ouVls-00028a-42; Mon, 14 Nov 2022 09:28:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443202.697721; Mon, 14 Nov 2022 09:28:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouVlr-00028T-Ur; Mon, 14 Nov 2022 09:28:51 +0000 Received: by outflank-mailman (input) for mailman id 443202; Mon, 14 Nov 2022 09:28:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouVlq-00028L-O6 for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 09:28:50 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70071.outbound.protection.outlook.com [40.107.7.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bee76a12-63fe-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 10:28:49 +0100 (CET) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AS8PR04MB7973.eurprd04.prod.outlook.com (2603:10a6:20b:28b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Mon, 14 Nov 2022 09:28:48 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5%3]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 09:28:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bee76a12-63fe-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=du0uay7OA1w6Ows0oJ3y7fNSjFcAHSRIPCHcaERD+4MF9RAd9K9CFFhdrh8JNjX4hKy1qljEbcFaHQN/bvuAYcZAzhuNV172fOPrt3EmhAe0BuLZjPlfliXIs7wP/qshnID+HISJYSnhUDhmihmYB0q3Ab+CVc1GHrmkNC1lv99o4YnYcD65wwqT3TgtjMc81bdNaDQFoPqH4c0PidCitVFwiQFkBHONyoaZShTJRRCPiHbJkGJ7YY6wij/VH/lJjSalz55+6+y+vONkP4SLNIOR8ORTWxV4R8CVV9iwZwvg7Kv+mgyUWsKfN0r4SY2LGQCXcVpwhEbJitPixZeAfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UmNa0uYvjtufCq0VaHCrZkh48Hhuo/JIzUc3gUDieck=; b=a4B9qr3OJF2kplr0zLeRlw9ZcPcA7QRqbWnUDwiGr+cNIT0xT3TLhVRrDG6Yyv6+hUvVV5jyRw4WIaEaiOqmj37uANVFDF8EniCyEfiGHtp53UwPpa1Z9wmReoQrEudP7HtkPuKAAaQEXoSwT5AmjSLOT2oZGKT1sGDD2z35UglFkU802Ts+caOIUO94aKQVrI7dhUj98AoO4v1zXDP+6k/oYxVsQWNza1abicHKEgN8gfdOItNngyxkGBa7cBWNJ8iFWMRbl9iXFhPmMeq7UNlsgxBmzTrmhhMIC7cZqY/gm3nx0RnXtJRfQHabRi9PEvVLEdiRP6MctyC1WMqZxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UmNa0uYvjtufCq0VaHCrZkh48Hhuo/JIzUc3gUDieck=; b=B1s1RYeUkdPH+vLXYENqYBj5cjodDKsTZ1TdeDCLVp8rv33e5d80QdgZ1BZmfGZAIbZU9VDAVoAcm/Wjbh4fVCRI4TYao2rfeoMob04wAOXrBAYuJveQS6x4ofAH2EW3JqDbTMlkAbAs1okNV3jjELuAR3ZUgOafUpaxGCx7nhW7Y/6yKcbmJ4WhSxx5rdY2D0Otp7R6E2SsY/YgykYJ9O/aDQTEbHYbOd7kbGzJpP4pKg3mXgezyrtLGr6+H8z4khtdQhDAUvAV2a4q4fmq+25citXccHPH+uPouooXFqVujKG9GmCi1V0M3bippJ5dtO2gaSwHA0ULyG3/o1MGzA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <73becaf7-8c94-1261-f504-865cc0425c79@suse.com> Date: Mon, 14 Nov 2022 10:28:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v8 0/6] Device tree based NUMA support for Arm - Part#2 Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <20221114063451.473711-1-wei.chen@arm.com> <3aa067b2-fa49-326a-c5a0-6735bc95951e@suse.com> <2beb3d17-99f6-77fe-a5d6-d60e665f01d5@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0729.eurprd06.prod.outlook.com (2603:10a6:20b:487::24) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AS8PR04MB7973:EE_ X-MS-Office365-Filtering-Correlation-Id: 88c2e1ea-3d0c-4581-aca6-08dac622a235 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PBAAOprXkuRJN5LbQYqCFTc+Dk2mEo2RogjAaCSVbd2HH/kI0kSO3xVcdW5qGJANTgFs4noLBn1B0X+pwWSzG3ntVPxXRUeVE+h1qWFxmFlda/sX91oD8IWeDZ2o2H1i/3BM0msvR6c4PLxR4FHmSmaxXXz/3fK8lCKA1uoSq6KHI4jlk5iHMBQbNDZc3F3WKBTQG806M58Z829D2k62QqFM6TNF3XuGwTYgM/jEYkKXijTxT1HuJaBPydwTt1/HW5ZOSNGtLdIGkyWNGay5QEFqIeTqjOrQFaRPJuUYv2PGLVtQSpub98iLtXjQ8oa4ggw/ZvkpCmKPxjjuxDatf1jQC79wRKPlifCx8srhp0gGeVDDGX6qhnbpLjZldlIJ06lyktfnGvz4lur57dkITRhJ0Hw3oRhoMSk7enEuXsOzQ6nxBlx2o8UZ+scH4uFtafWBm2c7zPuuBWtvcJx/3F1l3hPaNOVksHKzAKcURY4Rw70dwebrSth2Kb6w5i/MCyIYZ72XRcZiGoIEGmKhIOAOyKl5TiwibGMuAgDO9Zvo5h2SlmOnaQPaqy5n5rrURLr4jSRthqws5qlAsJk86gVymiI9bFjzQEUe+/NtHcYffhyAiNJYjEqiT52aMtd5kfNbafIIyOMtPN3kYg82L6nxdakOlMtdZMqZEu4Mv43/wQOtYlN3+tcaGay8/72m13XotA+8w+cDVCIs6IeXe7sT3dhoRRNiBLrHwq+dB8Wesad9MGXW4AV9msYiKzkxw6TT5qahyNQbL3QZLSiAkjOSrON8tkishHX6Omp7uZxZC5gU/ohwNN38Rdvg4lSKeMgPGfA2SotFS0t9QaLYiWgfXxASDXrXdu8vq6hQC2RiO5DX3Mdv0j9er9b0mR7d X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(366004)(376002)(136003)(346002)(451199015)(54906003)(26005)(31686004)(6506007)(478600001)(6512007)(53546011)(86362001)(966005)(31696002)(6486002)(2616005)(186003)(316002)(6916009)(5660300002)(36756003)(2906002)(38100700002)(66556008)(66946007)(66476007)(8936002)(83380400001)(41300700001)(8676002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEV6d2prd1dPdWdtOFlMMElaNXVVbThqYi9UcmxrcHRUME1rbnRaU3lMRnpm?= =?utf-8?B?RG8zVGtCVjRQYjhuQTZYek9uaXVhZGdYSnRBNnRYbWtSTWp0dVQ5aTNTa2pM?= =?utf-8?B?cDhWUk51SHRzWHZWUkViMlQ2b0QxM0pIVzVTT1RWSW5Ibm1CZkFCN3NlS0Zi?= =?utf-8?B?eXFQWVpTWFVqeXQ4OGN4bFJJbDFRWkpDZ00wbU5WY0RENkhJSFd1a2JuM1ZP?= =?utf-8?B?b3pTRzFSZXEvYWt1cUsyMDNlZlJrL2lSYzNnZzhNU2hwdlhtR1RYMjRPZFpQ?= =?utf-8?B?RnJMcEJVeldud1lKZ3NOT3BxOVZ0RW8rbjE4TWVHNVJXZU5zWjl6SFBuRW0r?= =?utf-8?B?WWk3end1NnU5c1oyVElJc1pHRTV3SktpNWUwaEdMTzBaR3Fsd29XNFRhYU51?= =?utf-8?B?K0hRUzIydC9sWE96aW94a2lnSVBReWVnWVhMUlRKMC9VWW43b3NvZXFjcW4y?= =?utf-8?B?WXBxTW43Wk1GMFhxYTAyNG96VnVOK2Z3Vjc2YkJpT25aQW1lVnZueEo4WUVD?= =?utf-8?B?TEZNMTRaNU9SM21RbklaSDNucEU0eU9nT3haWmxlbDRxWE44VzZvekVuMUVL?= =?utf-8?B?ODJydGRveDBrOWxwcWlOUCtmT0x2NHBqcC9ORjI3NnV0blY5TDArTWgzS1Ni?= =?utf-8?B?dWVSd0x1NVo0UitJcENuL2ExMzVaOWt4aW5VVUVBZDhCRWo2OFkxNEl4cjhu?= =?utf-8?B?cThhaWpKakNwYWxvVG1lc29oblJqRmEzejNBQ1pSVVN5OXJQbEpvRDBHdkNW?= =?utf-8?B?QktUZk9OZEJPMkN2VjIyanBteTJUeFBGOG1aQk5ETlB5cTBPSTJEdXRsQmZy?= =?utf-8?B?bnNIZHpVRGtJTGdzckpmNUJJdG9sbFRXL1BYZ215NURjMkZyV1hlRStMMmhW?= =?utf-8?B?MEdJYnBmMFgwZ3pjVTU5cGNpTHh3UDY3TVZ2b3Rwb0pJejNQejhDdFhuRjFy?= =?utf-8?B?MEtzWU42YjNNaUltMGprNkpMODgrZm1lM1U5eUZBYVg2TjFJQk12NDg1QUQx?= =?utf-8?B?U1c3akYzZmxjMTRIWU9rTXVhWXZuNjltS2FaUmtEMnRQUGgyMlRjZ3hmRlhM?= =?utf-8?B?U1gycERUQnl2dFBPYlVwR0VXMGNSVzJqa1QrZDh4RXlkMjJkbGFJQ0RMM096?= =?utf-8?B?ZUF2dHN1RnU5Rytpb1FSTEphWDZ1RGdHK2c5Z1o2UzZVVElvbWhmOVFCWmx6?= =?utf-8?B?bTgxKzV5YzBXbWpXdDVCQllpK3lZNXl6ZmJxRDM1U1ZEU1RkbC9qNU9nY09U?= =?utf-8?B?ZTBaRHhPUWhKbUkvUmxja2JpeHNzeXVkNGdvclJONWc3RXNxUUxKSkM2MDh2?= =?utf-8?B?cEY5UnRYVURYazRqWjB0Tnk4N3UxaEcrbUJyaVByM1Vud1RhbHZtbU5zWTBS?= =?utf-8?B?VDFrek9aWUtsTndQclIzbG05Qlh2U0pvS0RuNFlhdnUwVVN5ZzZwekFvVENX?= =?utf-8?B?SXUxY2NRM2V4dmhFU0grN2hHTUtpQnZ5ZVhZVUF6U1R5Y2tsZ0c2Qk1odEpM?= =?utf-8?B?OFVJcGF5NHZLc2tVOFg2RFQzb0FJd3BGZXdsTmVIVXVkS2t2L1cyU21LK1Jn?= =?utf-8?B?K2hGWlNxNG0wOERYVVoyQUR1RlBCbCtrdFI3RWxQaU05ZHlYeW9aSlduZFFa?= =?utf-8?B?N3M3WGxORVJsbG1hWVlwSjVDK20xbExkaGZtQWpJNWdDcVdVUlQ4N2gxV0Vn?= =?utf-8?B?R2dmTUZFNmYxWE9hbWlGa1kyOEhoY0o0c3lXRFBrNENqcDNvcGsrUWxQSXFu?= =?utf-8?B?dzVCVWJMQThCSUNSaUNyRDlHcjUyNXFoUXlibmxsMW9YSDdFVWxrbS85Wk9O?= =?utf-8?B?eitDMklPTDFBWUkvUDNnSFZyUGtVajkzaGJ6clQyYmpmS2MzS2ZTbGxaUlVS?= =?utf-8?B?eDJMTGN1YXBXTHpoSjRtWndkZEx3cGkwdWZHSVhuMVN1R1VvYlYyOXYrMmdr?= =?utf-8?B?RENlb085OWkyNXBETnBLamExS2xqQnU4enFkb3FTa3RhVkRLMlZjbEZrTXNj?= =?utf-8?B?VWVWSUYzQVlNTkZjZWRqUTBoL0VEaHU5UWRZT3VCK2JwUUtWWmZ4YmI2dDhZ?= =?utf-8?B?WG9HUmU0NmkrbmpRSDJ4YXUzM2UyYjZxeWFUdkw2SkdBRjdUOXpMd0ZIUUNj?= =?utf-8?Q?jA7J5XMs84eDNGR0FTJTc0vIP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88c2e1ea-3d0c-4581-aca6-08dac622a235 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 09:28:48.0210 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /6voeRK657HaG0ODOCRAeYmu8BXGiB+btAvq0YLYHjArL+i9s407dznnvUGYJ3b5hZkj7HANJgBmfil5VD3Few== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7973 On 14.11.2022 09:33, Wei Chen wrote: > Hi Jan, > >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年11月14日 16:23 >> To: Wei Chen >> Cc: nd ; Andrew Cooper ; Roger Pau >> Monné ; Wei Liu ; George Dunlap >> ; Julien Grall ; Stefano >> Stabellini ; xen-devel@lists.xenproject.org >> Subject: Re: [PATCH v8 0/6] Device tree based NUMA support for Arm - >> Part#2 >> >> On 14.11.2022 09:14, Wei Chen wrote: >>> Hi Jan, >>> >>>> -----Original Message----- >>>> From: Jan Beulich >>>> Sent: 2022年11月14日 16:05 >>>> To: Wei Chen >>>> Cc: nd ; Andrew Cooper ; Roger >> Pau >>>> Monné ; Wei Liu ; George Dunlap >>>> ; Julien Grall ; Stefano >>>> Stabellini ; xen-devel@lists.xenproject.org >>>> Subject: Re: [PATCH v8 0/6] Device tree based NUMA support for Arm - >>>> Part#2 >>>>> So in this patch series, we implement a set of NUMA API to use >>>>> device tree to describe the NUMA layout. We reuse most of the >>>>> code of x86 NUMA to create and maintain the mapping between >>>>> memory and CPU, create the matrix between any two NUMA nodes. >>>>> Except ACPI and some x86 specified code, we have moved other >>>>> code to common. In next stage, when we implement ACPI based >>>>> NUMA for Arm64, we may move the ACPI NUMA code to common too, >>>>> but in current stage, we keep it as x86 only. >>>>> >>>>> This patch serires has been tested and booted well on one >>>>> Arm64 NUMA machine and one HPE x86 NUMA machine. >>>>> >>>>> [1] https://lists.xenproject.org/archives/html/xen-devel/2022- >>>> 06/msg00499.html >>>>> [2] https://lists.xenproject.org/archives/html/xen-devel/2021- >>>> 09/msg01903.html >>>>> >>>>> --- >>>>> v7 -> v8: >>>>> 1. Rebase code to resolve merge conflict. >>>> >>>> You mention this here but not in any of the patches. Which leaves >>>> reviewers guessing where the re-base actually was: Re-bases, at >>>> least sometimes, also need (re-)reviewing. >>>> >>> >>> I just applied the v7 to the latest staging branch, this work has not >>> Generated any new change for this series. I should have described it >>> clear or not mentioned this in cover letter. Sorry for confusing you! >> >> But you talk about a merge conflict. And that's what I refer to when >> saying "may need (re-)reviewing". The same happened during earlier >> versions of the series, except there I was aware of what you needed >> to re-base over because it was changes I had done (addressing >> observations made while reviewing your changes). This time round I'm >> simply not aware of what change(s) you needed to re-base over (which >> is why I pointed out that it is generally helpful to indicate on a >> per-patch basis when non-trivial re-basing was involved). >> > > I had thought it was a code conflict before, because our internal gerrit > system marked that this series has a merge conflict. But the actual > situation is our gerrit setting policy problem. There are no code conflicts > in these patches themselves. We also did not modify the patch to resolve > the gerrit conflicts. Regardless of whether it is a new or old version, > if I modify the patch, I will remove the reviewed-by. I'd prefer if you didn't unilaterally. Instead I'd like to suggest that you apply common sense as to whether mere re-basing might actually invalidate previously supplied tags. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 14 09:33:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 09:33:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443208.697732 (Exim 4.92) (envelope-from ) id 1ouVpq-0003he-Jk; Mon, 14 Nov 2022 09:32:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443208.697732; Mon, 14 Nov 2022 09:32:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouVpq-0003hW-Ek; Mon, 14 Nov 2022 09:32:58 +0000 Received: by outflank-mailman (input) for mailman id 443208; Mon, 14 Nov 2022 09:32:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouVpp-0003hQ-2m for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 09:32:57 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2070.outbound.protection.outlook.com [40.107.22.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51b3a07b-63ff-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 10:32:56 +0100 (CET) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DB8PR04MB7002.eurprd04.prod.outlook.com (2603:10a6:10:119::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Mon, 14 Nov 2022 09:32:47 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5%3]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 09:32:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51b3a07b-63ff-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OO+qjfbMaBiuBcjcz7F4Tr/siQZyOBc2BfuvUCk4FkpL9z7yGbiV7iy4T6iKIx/GFnZf7p95CsLPvXnQUMB3UaPD9LPuiKKukhknXqu2wJqxQvv7KZWgVjtDMw/SZrYwOIA1HxInJ18UE6hDCizBeFH8iVqMH6G1/WUpEYK0qn6D2qZudo8+O97fwUZhOXM+0lcgQwux9EBqLG7aKqL163x2PDRv/DRLLsvoFJKKopbrJHg06elg8y60bdeEwDX+4pPSTVum4IFsh+yNOkPqiLNPoAbNJM9i1dhyYXvoeVKcb5J0jgtlE1kYOstbvuhpMPlBIjO5IYIqIx+tnBpUPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kd8rI4gWaybIXfyrl2buRn0IJO2ZUf0e+JRjkHL7QEw=; b=Zh7aEhxYmEhECungSXCgnQKT6i6zRIfy/Y6prvCLtAxB9m7NX72SlTWxaxG+0LSdyoim7M8KRR9njao1l7I6s7vqf4naS85ocLsDioVRvZnQvaFbaT4IST2gPxTpf3wLkHTxNW3JbwoZhAD9QjXD93+j7XPoXdQB66wt0kcqmXisorHciE5q2wuiFssOQYPjE64UpOsrmL8n6x2S6P1CsrF+soyGdKCUwkbDgRX0AP3c3/Scmakovi70bwLU+WZVbURCCQbBM4sYASbG+pYI5AbM9pjkrpLP/+tupTa7LneoId26g8GDKd8Sxj8aOjgPF9402mNDmJiNxCkoRIwOYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kd8rI4gWaybIXfyrl2buRn0IJO2ZUf0e+JRjkHL7QEw=; b=rSQHHoLipmZQAkIwZcKToGmRcPVFb1qOiFq5K1sErD0+73fclcSMatCNFCvNgMhobcN/QLMH1ED/iotlSwbkfD2TnHUaYJHb8NQXKYo8wT0H4nFvKSWCtESNSZitQkkof78TWLsOrAE1TngU2zugJKT+Jouy+1P3qJHHNUHpaxSkcas7vPYfVbt3mNQg9i3hBY6R2ukAjb4m1HcGx+t8/RSMPfGdqydU4a/aQehbNaijo4sl/sLgok5BuOmxgYSPnv3PRhD417E7Q06jYx8iFQku0mnncgcGD60h85TbBrAfeIgF64fSoa0+uOx+6g6YLYYWO8EqVxsfwPYgZd+KbA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5ac0cc88-fb43-120c-975a-f1ad23ed30fb@suse.com> Date: Mon, 14 Nov 2022 10:32:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] x86/xen: call xen_set_upcall_vector() only after local apic setup Content-Language: en-US To: Juergen Gross Cc: Stefano Stabellini , Russell King , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, x86@kernel.org References: <20221112132336.698-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20221112132336.698-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0150.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::8) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DB8PR04MB7002:EE_ X-MS-Office365-Filtering-Correlation-Id: 444aa9fe-700d-4dc7-b440-08dac6233109 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fj7KIwcWkqKLgv57/PlDiL40x4OCnLks64ja8iucNx/rN0Pf4PN8L/Z8kyyCGt6OuBgHsGHjTS/R5PmA/JUW+qFFelexA9uuE7HQSFwK7x9TVz2ENgliILnJZfDNBGn9XC9ygX8jdaMECvHLOchu51hFRvWplwfNjUjceKrEIxH/cH2Dlu56KRyGG0RbV2eUjIy4Tci5SAaIKCIGYXM7ZPZX4hs+2fZ7gDL6+GH0jHDKLeBX7+dtJBYEgZcZPmkp74e6pJLuhSt9JQxjb1qZMl56WqAKjWffug46d2b3Yg/C7FSJs74VPGaVl2usGh5iWwV2y2V/2GW+xVEx1XfA//4xNL2SEEsHwyWjZ7xQafSxb2LR3fb/ZGHKmahei7DucBJ/KzNAjFDb3I123HApeAsVL6w2SRucj6aJZAlYt7PPstDFkLRgKas7PcYPOWycHpQgkqowAvzZr4sZjToA7EwABcT7K77GUo0cA6vYlDdORLjel34wbRrABc57RGyYwa2RUtth3VNMuxKdNqjoyX65iKEulzxfzYk+P6l+Vk7CISlS/UV44tK0e/oY61Mv6MQjNRVebVZZpiylOzCvF/iYyuzTNpri7zrKox8DZwTp7KEYuDfZc9B1NG5UTYS49pdYmt+EDAe7+nbc0MOmaVA4pZe/ze1QYL9+hwvnp/hvalxcVPLXthTRi8cEIj/qCdlVb5Eztk4CALr4sMtB4d+Woh669J5tF68/2xpRV3QFKaG9hWHPyNivT/pMmHhGXrR0CyS5iIIhiT/JE4t1E/4ge+FteyCTfYDEy/E533+U26vCeLGkz1UXqLc7llhl X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(136003)(366004)(376002)(396003)(451199015)(36756003)(41300700001)(37006003)(54906003)(2906002)(53546011)(6636002)(316002)(83380400001)(38100700002)(4326008)(31696002)(6512007)(8676002)(26005)(7416002)(66946007)(86362001)(66476007)(66556008)(186003)(5660300002)(6506007)(8936002)(2616005)(6862004)(31686004)(966005)(6486002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1VMbzFJWldOcVpncnRmU0lEVnRCUlhMb1crZExJSFVFYTdwWXVxajRTamZC?= =?utf-8?B?VUMxTE03QjAwRHdPQ1kxN3lxSEtLMDZUQW1mcTcxeCtvWG43UVJCTVpER0xz?= =?utf-8?B?eXZ4ZDR2MW9BNXJ0c3dGRUFQbWl3NHZWamw5alZUR3M5djRaWFhKTldyaldH?= =?utf-8?B?dndMQXJYdUwxRlIrL1hhWkltYm4rWmV1YnAxdUYxRzBNWHlTUnQxRzgvcmFy?= =?utf-8?B?Z0pmSUJhNHk1ay9LTjVkYmtBNmxhUmgyeVBrTVB3Z2FsY2J1NURRbllqcUh1?= =?utf-8?B?TC9PK1pnZmF2L2hqTnlZdU8zTnlzcnNqbEV3c1VVOFZrcUJ3M1BsUHN0SGY4?= =?utf-8?B?MS8xS3lvYjAxcHYxNkNkOVV6bldReGloUm5kRWxsTHg5cVk1Z1RCSHgyd1U3?= =?utf-8?B?UmRZMTBPZDZsc3g0eGdLTmozZWVYdXp4RXRiWFlaMWhZajlpaXZLcFRlTWw3?= =?utf-8?B?VjR6Q3ZyeS8xbGNwSmVGZ201SHA4YnAxSEkzZTZUTFVRblN0RnRZZUI5Qnh1?= =?utf-8?B?djJrQzNoZ1JoNG5nSGpScU9zWjR0d2FGTytMbHRMeERnb21uMVp0WHROSGR3?= =?utf-8?B?L1JoZGttMkQrQjVoZGhGbFcwRVJlM1ZxUkpPTlZzUUdERnhEZmhFaDVQZGpl?= =?utf-8?B?MHN3UXlEcXZ3bnNJSGhFZm5RU2VzNmFJYnk2UEx4bkVidzdLWkZRdUxOeWdj?= =?utf-8?B?OGhqS1kzQm03M0wvYkRtTnhOLzVNSUk5UUtxTjdQekpPTXhrbzF3Y25oTTA4?= =?utf-8?B?K05RakdhUkVETk5SOFJMVEIrd3ZxV3FSeTlXKzNFYjJlM1Frbk1vOFRkZ1Jo?= =?utf-8?B?Wk1VVVh2R2Y4SmZqemtJb3hCTUZGNXlOY1hwLzFZcDRYM05PZlJhWExkRHor?= =?utf-8?B?eHY3b1AwUUNjYTlqYUpiMmlDdDNyVEcvVXRlQkMvL1pDZ3duRmN3YzFHTUp0?= =?utf-8?B?eDJwOUVlRVAwY2plNjZ2WTdSWEMzekIwWldzdlcxQXJLNXdMdXUxZTFQTkUy?= =?utf-8?B?WFFYSU5VNHM3c2lzcHBVc2pTWDN1S1YrUUttNEEyc1VOM2s2OEZVeUJCWHY1?= =?utf-8?B?b3UvVXgrWDdaNTU1ZjdHN3BPd202ZnoyWmNucGFxWVFiY1lRYXZ0Zk43QkRm?= =?utf-8?B?RXdaeUdvZXIzWlJudWcvS3hXVWgxZlorZ2hZQ0xFeWdwOWs1TE1CU2g2aEpL?= =?utf-8?B?cTVtNHZNUFdyWExuQmJQZ090TXRQRUZqRjBFRWFhdllCVWlqZHZuODBjYnJX?= =?utf-8?B?MG1scm5jSWU4ZC9OaDAyRnJzWGJiK0g0eUNBSDJNYktlQ0VkajZLQTZ2YkNY?= =?utf-8?B?MVJCZTBkdjRVYUttM2Z3YlJJTE5YdDkrZnM0enMwcFI0RVNURkJCcDZKMDRW?= =?utf-8?B?ZEltOFdycWIvazhpQmFsMThkQmo4YkZIRXdEV3ZmWEUyRlpFMjY0aFhPRjdr?= =?utf-8?B?NjA0azMzMjYrZGtId0EzMVlWeitoc0hkN0JsbXJoZzVwaFRmamorTkkrTlZF?= =?utf-8?B?NUpWNTl0d1RsdHNDYU9lUzlpb0wxMlRUeUoxUmQwcEkyRkc3R2RmcWVqUkFY?= =?utf-8?B?ZGdVTnNENmZxcENRVVZoM3YxNTk5cldBWjBmRjdYRzF0eG5qVnBadDl3QTNm?= =?utf-8?B?VGVjSnE5YmlObXB0ai81L2k1WG16eU4rUlRpYWZzWW1mak93a3RYRWpGeEZH?= =?utf-8?B?K21INU0yWWk0MVVzZ1cxVENaa3hscFFsM3o1cGVSdkdYUSsxNHg0eTl0ZlVF?= =?utf-8?B?WHpLck5PY1ZtSG15K29PM1ZhdjZzYW4rV2lxWmZVT0ptTmlXelo2OWtpMVph?= =?utf-8?B?UFNuRmFQaW1Hc1o0TlBHUitpZndQR2hXVTFNSHNGelBwb2JkSDNjN1dEOUV3?= =?utf-8?B?emttY2M4TnZLWlpzUzI5K1JkWmtHQW5aZWROU3JOSVBUMFdjMDRFR05laXAy?= =?utf-8?B?bG55ZG1BTVpBVWdUK0NmMGRGK3BIZlBDVVlmNnlwYlpCcnBaWDFpWUxleGpq?= =?utf-8?B?ZjZnRjVlRFM5Y1V4STErWE9mSkFzWnZPVkt2YjhldmFoRU95LzhzZ3JOUFNi?= =?utf-8?B?dG9ZZlFIUkRSRjh0a3hWaTRMOEZRZlU2WHJnV3JzYXYycGdZVDZHc2hETk5M?= =?utf-8?Q?1N/YfeGKuykaG2WsuvrvaivaG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 444aa9fe-700d-4dc7-b440-08dac6233109 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 09:32:47.6939 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OOn0sE4iRL9rVxHCTe0PB5MGwEajW9VaSGDp3ou1qiy/zezMBtBKqR//bxNcgvx9+VOZ6Zz4Oqu2HkBjv3nGwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7002 On 12.11.2022 14:23, Juergen Gross wrote: > Calling xen_set_upcall_vector() before the local APIC has been > initialized results in warnings when setting up the local APIC: > > [ 0.037322] APIC: Stale IRR: 00080000, ... > > Avoid this problem by moving the call of xen_set_upcall_vector() for > APs from xen_cpu_up_prepare_hvm() to a new hotplug callback called on > the AP before interrupts are enabled and after the local APIC has been > initialized. There is already a Xen specific hotplug state defined at > a matching position, but right now it is specific to Arm. So rename > the CPUHP_AP_ARM_XEN_STARTING to CPUHP_AP_XEN_STARTING and use it for > x86, too. > > On the boot processor use the x86_init.irqs.intr_mode_init hook to > call xen_set_upcall_vector() only after the local APIC initialization. > As interrupts are on already at the time when the hook is being used, > modify xen_init_setup_upcall_vector() to disable interrupts. This is > needed as the xen_percpu_upcall flag is set only after the callback > has been registered, and the flag is needed for correctly acknowledging > an interrupt. > > Fixes: b1c3497e604d ("x86/xen: Add support for HVMOP_set_evtchn_upcall_vector") > Reported-by: Jan Beulich > Signed-off-by: Juergen Gross Just to mention it here - as per [1] the issue may instead result from hypervisor misbehavior, so I guess we want to investigate that route first. Jan [1] https://lists.xen.org/archives/html/xen-devel/2022-11/msg00783.html From xen-devel-bounces@lists.xenproject.org Mon Nov 14 09:38:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 09:38:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443213.697743 (Exim 4.92) (envelope-from ) id 1ouVuo-0004O2-8h; Mon, 14 Nov 2022 09:38:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443213.697743; Mon, 14 Nov 2022 09:38:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouVuo-0004Nv-4Z; Mon, 14 Nov 2022 09:38:06 +0000 Received: by outflank-mailman (input) for mailman id 443213; Mon, 14 Nov 2022 09:38:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouVum-0004Np-SR for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 09:38:05 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2081.outbound.protection.outlook.com [40.107.105.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 090cfff9-6400-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 10:38:03 +0100 (CET) Received: from DU2PR04CA0086.eurprd04.prod.outlook.com (2603:10a6:10:232::31) by DB9PR08MB8481.eurprd08.prod.outlook.com (2603:10a6:10:3d7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.5; Mon, 14 Nov 2022 09:37:54 +0000 Received: from DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:232:cafe::32) by DU2PR04CA0086.outlook.office365.com (2603:10a6:10:232::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Mon, 14 Nov 2022 09:37:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT059.mail.protection.outlook.com (100.127.142.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 09:37:53 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Mon, 14 Nov 2022 09:37:53 +0000 Received: from 042fae081247.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6E4481CE-9ADC-496A-B011-E57F20568F5C.1; Mon, 14 Nov 2022 09:37:48 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 042fae081247.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 09:37:48 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by PAXPR08MB7417.eurprd08.prod.outlook.com (2603:10a6:102:2bc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.5; Mon, 14 Nov 2022 09:37:46 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5834.005; Mon, 14 Nov 2022 09:37:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 090cfff9-6400-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zZfr/uLkzzsAP79kZA9Nbzxa2g/WxRWrkxKEHa4UFJw=; b=yu2qFOjIZrYJ6mZr/pP5BnMzIh7OVyOEY0o5+prQbuyhRMNzeeRSb/Z3cAQiwxpcS9I9LKxLDPRwJXi/Ae7jxDZJfzkQ5KfctBNTew7UL8DQ2Cfyr5/oG9xVxMtw+vhBTHgLsyjeZcAnMyfdc9U3FI+08W5EJ1VPbM2dbWyIDrA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NIwD91ukMja7CFH5b2tmGsogoGxaUI6zVruh3/P85k5LGTAu0uycPDuWO6KvE2p0GW56fPi1ZFm5xj9QEmS9cySjrjWxLKZ8AgRYAhu8VF/FyAFaj2EGLj0TW4D+Vt2YAjRE7E8wplKlfEmhtlbHcNhc76Em31x8XTsZGAlWArzBEXf95/Va80c3MzJwMk4ya6hAtinweCbqzvH7dPW9QmV0SUs2BJk4FlhxNUOSI/KMVCjptOJAQxCRM4SOnHNGvd6DHX3cTLq+VLxIxQCKQ/ERdun8eTyzoqP69lhS34bOt8h/1iEH/Bjl3LfC67uAteJLMAhZrS3Fo/NME4DTDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zZfr/uLkzzsAP79kZA9Nbzxa2g/WxRWrkxKEHa4UFJw=; b=MNcAGYpj5pNvCqyGgev9mniU1fY93OdF2KICH7JeAxsK0G/BlDB2Ri5IloOQ5/kN3wIulW25wDDR0l9xqUfky7hvPIh9ss/BIqUXxzx2Qlrm5niC82br8fxh5vl5dVHR2i9HtGZC+mNPnKfspJFt3xcQID8PXQ5MexLXAOwPvX3mPVm1wUnlWl8GTuycy+QMRGftuzvXsQb4avStLCbBKIlyI/ueCCc81gCbcbeGVZsSitrwy4BEvISerGSNJlrbXe3KlZilZtcHSI3a6sKD6JdWLw6ZCvra9j7XwhZc5IKZe0aoXH6BPcD1oiqYtz1vLId3cthQk3W6UoTrLtEuRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zZfr/uLkzzsAP79kZA9Nbzxa2g/WxRWrkxKEHa4UFJw=; b=yu2qFOjIZrYJ6mZr/pP5BnMzIh7OVyOEY0o5+prQbuyhRMNzeeRSb/Z3cAQiwxpcS9I9LKxLDPRwJXi/Ae7jxDZJfzkQ5KfctBNTew7UL8DQ2Cfyr5/oG9xVxMtw+vhBTHgLsyjeZcAnMyfdc9U3FI+08W5EJ1VPbM2dbWyIDrA= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v8 0/6] Device tree based NUMA support for Arm - Part#2 Thread-Topic: [PATCH v8 0/6] Device tree based NUMA support for Arm - Part#2 Thread-Index: AQHY9/NBdTAzy3F6U0ar/3rX7ynbh64+D8cAgAABF9CAAAPhgIAAADOQgAASJwCAAAESkA== Date: Mon, 14 Nov 2022 09:37:46 +0000 Message-ID: References: <20221114063451.473711-1-wei.chen@arm.com> <3aa067b2-fa49-326a-c5a0-6735bc95951e@suse.com> <2beb3d17-99f6-77fe-a5d6-d60e665f01d5@suse.com> <73becaf7-8c94-1261-f504-865cc0425c79@suse.com> In-Reply-To: <73becaf7-8c94-1261-f504-865cc0425c79@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 2B8ADBDB78608C43B21F36703A4DBE7E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|PAXPR08MB7417:EE_|DBAEUR03FT059:EE_|DB9PR08MB8481:EE_ X-MS-Office365-Filtering-Correlation-Id: c8638516-3622-4e4e-3826-08dac623e79d x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bctTCFcdYILFvZO5bKlX2//whv6cEo+GrT4YQj3UaTjGVINQqbyBrdWulNVV+jzj6XTF1CbUE+eMGBmdaDJlfHUrY7b/MfOjKU/OTRBfxfjsKrFa5f9El/t8qyyoom9UBT+6u4fW8HlfY42kPpxISaF6tfnuN5HQCrJ/4xDGuVkesWHOlq1kwCTHT5ZztrVP2yJuWDjB0jRbcyQci8PUOJeYqsnQaWtO7DcS+s3UGD3oUlzNB1YfiFHTQEAlUmPQ+/ZEu/lgj6GsPAH+lfngeEQJDA/RF994zBuTIsnWQ5PSYQPrRo8pXcktHs5QdePh9Bpyl9oarqzh82GGqrqYnWuy52rilHMxIgu7YPysUqmYNBQv80FWhNMlabe0rrISQeVXLFgwDrVhhRr4nKsT25nCs25cJSQmk1rdCPwsU3fOIa1DRSjJUJ7yW2dgvkHTN9UPXBKASwfAGiYNfniZGp8IJ/L/ufV+26p9ujQk8bExZHgtXdp8I57/ma2HBZvp+oGb/N3RndCS9F2GDrqiI3kSonaOipzbB0oQDOlQX9bwbbIdn6tGkUMegGOuI36MdDqGkBA2QMWIClVgsO4x02hFwK7O3YuTw7zyYUQ+8ahgmECJxJfXfwuMQxcReAoa+az1xodX1UPZxniaGRSKgaqiKrARFrsGxPfhwgYgqIt638Z322xKuvptJDvHxXkqce/tEldD8m/+DxOgaILa4yhNfhllcMIIN28ydGfPKdyOpYovXZl/6Q6N0Cod2INRGRbNi4fTgFeLd1+sDqqnlsKmQafyobovIBcksygahBoi93AAIXodbHSM6hANp3zZzVoq9EGr4dK8HC4pqt25GA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(366004)(376002)(451199015)(8676002)(33656002)(38100700002)(122000001)(2906002)(38070700005)(41300700001)(83380400001)(54906003)(64756008)(86362001)(6916009)(76116006)(66946007)(4326008)(186003)(71200400001)(478600001)(966005)(8936002)(5660300002)(316002)(52536014)(55016003)(6506007)(66446008)(7696005)(53546011)(66476007)(66556008)(9686003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7417 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dd3cdbb9-503d-4675-e398-08dac623e32f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6sisnrd2CeAONmL8wDXBCbxUevpFK0mU2W1FgHP89W4rq/jq83unySUEoRjeW5Dlde6IAezMw4F0Z352h4KN05y+b6kVDpqJgxMofw4XH/qVK3V1xBMyd2DwzOjz07hCL1XehyIaQBWCc3pHR6EuCjjVJIiNtiApQ5wRv7wWOvHYKzHnax25Q86bcSui/7TIghVbNoCKixQ15hk27HAyTJcW4CH3CFFxzAFhe5PfeilLj88Y/jlDI30TeHmD6jEVnU+9VwGDQzjayNwukqKk9XhAUWFSUJPZNzlXi7weq5LixzyUrDAWo5XO/mj+gz96+pbPy+Am46JgioJAgDIO9rMVOPkfzT6tY48Q/zqrUnCnuIRJalv73etI6oBCVCiFG+VEK+ZNZGlH9YdZEBqR1xcTH0DnKU57/WExZ6xRFEpjJtTjdVbzpw/OyvaGgmGU0kU/gqMuoMRFTsOq42EQmMmVmz9j/raRJ54pMH+skJ9Nw25fCxrBRIW6SbuesWCK8O1NriFfHfdcssisztkmaNzPZpaqbEa2peRIGyeQs6FL3QD38w+w+LKPcXm3kGu+N3dqFDAGFTaTDk8oCZmAVx+5NszWRW1s1NM6D+oeLLSbNhXiKaMlpZje/NKEvXxL0KoOhGxlbPG/9LP/7gIgvYmkMmCLLOUEEHmfuHUc7RvezBO9Xwy38moDrQLlmtQECFD8Osg/XCk7I4gRhDsAmVLs+moW+2lRxmBh9hNYqcIy5jYOjXMLC/S57zw3KNhPGz7llhwFs5EkGLnCuW1u5Eyk14ZaL2qZm1jq0Se4C+QUWPArSjVwwSaOIDM08lzkrFahh6x4mdbw6qCVuNZJmw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(40480700001)(36860700001)(83380400001)(316002)(86362001)(82740400003)(356005)(81166007)(6862004)(40460700003)(41300700001)(2906002)(82310400005)(4326008)(52536014)(5660300002)(53546011)(8936002)(7696005)(55016003)(9686003)(26005)(186003)(336012)(70586007)(8676002)(47076005)(6506007)(478600001)(966005)(54906003)(70206006)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 09:37:53.8185 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c8638516-3622-4e4e-3826-08dac623e79d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8481 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDEx5pyIMTTml6UgMTc6MjkN Cj4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPg0KPiBDYzogbmQgPG5kQGFybS5jb20+ OyBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgUm9nZXIgUGF1DQo+ IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgR2Vv cmdlIER1bmxhcA0KPiA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsgSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz47IFN0ZWZhbm8NCj4gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVs Lm9yZz47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BB VENIIHY4IDAvNl0gRGV2aWNlIHRyZWUgYmFzZWQgTlVNQSBzdXBwb3J0IGZvciBBcm0gLQ0KPiBQ YXJ0IzINCj4gDQo+IE9uIDE0LjExLjIwMjIgMDk6MzMsIFdlaSBDaGVuIHdyb3RlOg0KPiA+IEhp IEphbiwNCj4gPg0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PiBGcm9tOiBK YW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+ID4+IFNlbnQ6IDIwMjLlubQxMeaciDE0 5pelIDE2OjIzDQo+ID4+IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gPj4gQ2M6 IG5kIDxuZEBhcm0uY29tPjsgQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT47IFJvZ2VyDQo+IFBhdQ0KPiA+PiBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPjsgV2Vp IExpdSA8d2xAeGVuLm9yZz47IEdlb3JnZSBEdW5sYXANCj4gPj4gPGdlb3JnZS5kdW5sYXBAY2l0 cml4LmNvbT47IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyBTdGVmYW5vDQo+ID4+IFN0 YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcNCj4gPj4gU3ViamVjdDogUmU6IFtQQVRDSCB2OCAwLzZdIERldmljZSB0cmVlIGJh c2VkIE5VTUEgc3VwcG9ydCBmb3IgQXJtIC0NCj4gPj4gUGFydCMyDQo+ID4+DQo+ID4+IE9uIDE0 LjExLjIwMjIgMDk6MTQsIFdlaSBDaGVuIHdyb3RlOg0KPiA+Pj4gSGkgSmFuLA0KPiA+Pj4NCj4g Pj4+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+Pj4+IEZyb206IEphbiBCZXVsaWNo IDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPj4+PiBTZW50OiAyMDIy5bm0MTHmnIgxNOaXpSAxNjow NQ0KPiA+Pj4+IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gPj4+PiBDYzogbmQg PG5kQGFybS5jb20+OyBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsg Um9nZXINCj4gPj4gUGF1DQo+ID4+Pj4gTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdl aSBMaXUgPHdsQHhlbi5vcmc+OyBHZW9yZ2UgRHVubGFwDQo+ID4+Pj4gPGdlb3JnZS5kdW5sYXBA Y2l0cml4LmNvbT47IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyBTdGVmYW5vDQo+ID4+ Pj4gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IHhlbi1kZXZlbEBsaXN0cy54 ZW5wcm9qZWN0Lm9yZw0KPiA+Pj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjggMC82XSBEZXZpY2Ug dHJlZSBiYXNlZCBOVU1BIHN1cHBvcnQgZm9yIEFybSAtDQo+ID4+Pj4gUGFydCMyDQo+ID4+Pj4+ IFNvIGluIHRoaXMgcGF0Y2ggc2VyaWVzLCB3ZSBpbXBsZW1lbnQgYSBzZXQgb2YgTlVNQSBBUEkg dG8gdXNlDQo+ID4+Pj4+IGRldmljZSB0cmVlIHRvIGRlc2NyaWJlIHRoZSBOVU1BIGxheW91dC4g V2UgcmV1c2UgbW9zdCBvZiB0aGUNCj4gPj4+Pj4gY29kZSBvZiB4ODYgTlVNQSB0byBjcmVhdGUg YW5kIG1haW50YWluIHRoZSBtYXBwaW5nIGJldHdlZW4NCj4gPj4+Pj4gbWVtb3J5IGFuZCBDUFUs IGNyZWF0ZSB0aGUgbWF0cml4IGJldHdlZW4gYW55IHR3byBOVU1BIG5vZGVzLg0KPiA+Pj4+PiBF eGNlcHQgQUNQSSBhbmQgc29tZSB4ODYgc3BlY2lmaWVkIGNvZGUsIHdlIGhhdmUgbW92ZWQgb3Ro ZXINCj4gPj4+Pj4gY29kZSB0byBjb21tb24uIEluIG5leHQgc3RhZ2UsIHdoZW4gd2UgaW1wbGVt ZW50IEFDUEkgYmFzZWQNCj4gPj4+Pj4gTlVNQSBmb3IgQXJtNjQsIHdlIG1heSBtb3ZlIHRoZSBB Q1BJIE5VTUEgY29kZSB0byBjb21tb24gdG9vLA0KPiA+Pj4+PiBidXQgaW4gY3VycmVudCBzdGFn ZSwgd2Uga2VlcCBpdCBhcyB4ODYgb25seS4NCj4gPj4+Pj4NCj4gPj4+Pj4gVGhpcyBwYXRjaCBz ZXJpcmVzIGhhcyBiZWVuIHRlc3RlZCBhbmQgYm9vdGVkIHdlbGwgb24gb25lDQo+ID4+Pj4+IEFy bTY0IE5VTUEgbWFjaGluZSBhbmQgb25lIEhQRSB4ODYgTlVNQSBtYWNoaW5lLg0KPiA+Pj4+Pg0K PiA+Pj4+PiBbMV0gaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9hcmNoaXZlcy9odG1sL3hl bi1kZXZlbC8yMDIyLQ0KPiA+Pj4+IDA2L21zZzAwNDk5Lmh0bWwNCj4gPj4+Pj4gWzJdIGh0dHBz Oi8vbGlzdHMueGVucHJvamVjdC5vcmcvYXJjaGl2ZXMvaHRtbC94ZW4tZGV2ZWwvMjAyMS0NCj4g Pj4+PiAwOS9tc2cwMTkwMy5odG1sDQo+ID4+Pj4+DQo+ID4+Pj4+IC0tLQ0KPiA+Pj4+PiB2NyAt PiB2ODoNCj4gPj4+Pj4gIDEuIFJlYmFzZSBjb2RlIHRvIHJlc29sdmUgbWVyZ2UgY29uZmxpY3Qu DQo+ID4+Pj4NCj4gPj4+PiBZb3UgbWVudGlvbiB0aGlzIGhlcmUgYnV0IG5vdCBpbiBhbnkgb2Yg dGhlIHBhdGNoZXMuIFdoaWNoIGxlYXZlcw0KPiA+Pj4+IHJldmlld2VycyBndWVzc2luZyB3aGVy ZSB0aGUgcmUtYmFzZSBhY3R1YWxseSB3YXM6IFJlLWJhc2VzLCBhdA0KPiA+Pj4+IGxlYXN0IHNv bWV0aW1lcywgYWxzbyBuZWVkIChyZS0pcmV2aWV3aW5nLg0KPiA+Pj4+DQo+ID4+Pg0KPiA+Pj4g SSBqdXN0IGFwcGxpZWQgdGhlIHY3IHRvIHRoZSBsYXRlc3Qgc3RhZ2luZyBicmFuY2gsIHRoaXMg d29yayBoYXMgbm90DQo+ID4+PiBHZW5lcmF0ZWQgYW55IG5ldyBjaGFuZ2UgZm9yIHRoaXMgc2Vy aWVzLiBJIHNob3VsZCBoYXZlIGRlc2NyaWJlZCBpdA0KPiA+Pj4gY2xlYXIgb3Igbm90IG1lbnRp b25lZCB0aGlzIGluIGNvdmVyIGxldHRlci4gU29ycnkgZm9yIGNvbmZ1c2luZyB5b3UhDQo+ID4+ DQo+ID4+IEJ1dCB5b3UgdGFsayBhYm91dCBhIG1lcmdlIGNvbmZsaWN0LiBBbmQgdGhhdCdzIHdo YXQgSSByZWZlciB0byB3aGVuDQo+ID4+IHNheWluZyAibWF5IG5lZWQgKHJlLSlyZXZpZXdpbmci LiBUaGUgc2FtZSBoYXBwZW5lZCBkdXJpbmcgZWFybGllcg0KPiA+PiB2ZXJzaW9ucyBvZiB0aGUg c2VyaWVzLCBleGNlcHQgdGhlcmUgSSB3YXMgYXdhcmUgb2Ygd2hhdCB5b3UgbmVlZGVkDQo+ID4+ IHRvIHJlLWJhc2Ugb3ZlciBiZWNhdXNlIGl0IHdhcyBjaGFuZ2VzIEkgaGFkIGRvbmUgKGFkZHJl c3NpbmcNCj4gPj4gb2JzZXJ2YXRpb25zIG1hZGUgd2hpbGUgcmV2aWV3aW5nIHlvdXIgY2hhbmdl cykuIFRoaXMgdGltZSByb3VuZCBJJ20NCj4gPj4gc2ltcGx5IG5vdCBhd2FyZSBvZiB3aGF0IGNo YW5nZShzKSB5b3UgbmVlZGVkIHRvIHJlLWJhc2Ugb3ZlciAod2hpY2gNCj4gPj4gaXMgd2h5IEkg cG9pbnRlZCBvdXQgdGhhdCBpdCBpcyBnZW5lcmFsbHkgaGVscGZ1bCB0byBpbmRpY2F0ZSBvbiBh DQo+ID4+IHBlci1wYXRjaCBiYXNpcyB3aGVuIG5vbi10cml2aWFsIHJlLWJhc2luZyB3YXMgaW52 b2x2ZWQpLg0KPiA+Pg0KPiA+DQo+ID4gSSBoYWQgdGhvdWdodCBpdCB3YXMgYSBjb2RlIGNvbmZs aWN0IGJlZm9yZSwgYmVjYXVzZSBvdXIgaW50ZXJuYWwgZ2Vycml0DQo+ID4gc3lzdGVtIG1hcmtl ZCB0aGF0IHRoaXMgc2VyaWVzIGhhcyBhIG1lcmdlIGNvbmZsaWN0LiBCdXQgdGhlIGFjdHVhbA0K PiA+IHNpdHVhdGlvbiBpcyBvdXIgZ2Vycml0IHNldHRpbmcgcG9saWN5IHByb2JsZW0uIFRoZXJl IGFyZSBubyBjb2RlDQo+IGNvbmZsaWN0cw0KPiA+IGluIHRoZXNlIHBhdGNoZXMgdGhlbXNlbHZl cy4gV2UgYWxzbyBkaWQgbm90IG1vZGlmeSB0aGUgcGF0Y2ggdG8gcmVzb2x2ZQ0KPiA+IHRoZSBn ZXJyaXQgY29uZmxpY3RzLiBSZWdhcmRsZXNzIG9mIHdoZXRoZXIgaXQgaXMgYSBuZXcgb3Igb2xk IHZlcnNpb24sDQo+ID4gaWYgSSBtb2RpZnkgdGhlIHBhdGNoLCBJIHdpbGwgcmVtb3ZlIHRoZSBy ZXZpZXdlZC1ieS4NCj4gDQo+IEknZCBwcmVmZXIgaWYgeW91IGRpZG4ndCB1bmlsYXRlcmFsbHku IEluc3RlYWQgSSdkIGxpa2UgdG8gc3VnZ2VzdCB0aGF0DQo+IHlvdSBhcHBseSBjb21tb24gc2Vu c2UgYXMgdG8gd2hldGhlciBtZXJlIHJlLWJhc2luZyBtaWdodCBhY3R1YWxseQ0KPiBpbnZhbGlk YXRlIHByZXZpb3VzbHkgc3VwcGxpZWQgdGFncy4NCj4gDQoNCkkgd2lsbCBrZWVwIHRoaXMgaW4g bWluZCBpbiB0aGUgZnV0dXJlLiBTaW5jZSBmb3IgdjggdGhlcmUgaXMgYWN0dWFsbHkgbm8NCmNo YW5nZSAoZXhjZXB0IHBhdGNoIDUgdG8gZml4IHRoZSBjb21tZW50KSBjb21wYXJlZCB0byBpbiB0 aGUgcmViYXNlDQpjb21wYXJlZCB0byB2Nywgc2hvdWxkIEkgaW52YWxpZGF0ZSB5b3VyIHRhZ3Mg dGhpcyB0aW1lPw0KDQpUaGFua3MsDQpXZWkgQ2hlbg0KDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Mon Nov 14 09:39:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 09:39:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443216.697754 (Exim 4.92) (envelope-from ) id 1ouVw3-0004v5-Hm; Mon, 14 Nov 2022 09:39:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443216.697754; Mon, 14 Nov 2022 09:39:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouVw3-0004uy-EY; Mon, 14 Nov 2022 09:39:23 +0000 Received: by outflank-mailman (input) for mailman id 443216; Mon, 14 Nov 2022 09:39:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouVw1-0004um-TK for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 09:39:21 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2083.outbound.protection.outlook.com [40.107.103.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36ce8db1-6400-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 10:39:20 +0100 (CET) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DB8PR04MB7002.eurprd04.prod.outlook.com (2603:10a6:10:119::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Mon, 14 Nov 2022 09:39:18 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5%3]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 09:39:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36ce8db1-6400-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L8G73hh6YgpGhJBggZXpmrFjoKS8n+FD+1Gk6QNgbmk2l7H+v84coDndIJ6Ey3P59nW4GJsMj7CbZDgwfKx9GiGs+jl6vfpyIfV6y4OGOrdMOPM1HsnjPqHIooQ6B9sv+X6XcsrVWLyblxF3uSrdv+mapEhjux+ysy4Zx0rZGLOJbOmtl9CZBDmYXOz9lftKDVrBZneAzWiiZLWN2Lngp4GiSVeG30g81r0/CDjRqwQoslrUrK2guVy5CqkEL1fRiJOucs6u+Qhc5fZw/iBNGcPayoZxO7UzpbOfQqiKh0kRcDSx2ddep7iEDeH4051uFh02Q+yUKwgqq9z8/HyO+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Leacm4iRByqnWFw5F+GclDO3j67JX2ZwadIo5qzMmRc=; b=eBsXNK8b0zq+fY2CxUPe3W2cGQZNOY4VrY7amFHULzYiIWPGHVaiYSX334kWkRZfEVBVxYqsx3eFqVMt46koxHgoADXR1hNyf95MqMOT3E3+bE9HMQb9MRH9E7p2bIaaYKvsxU0Gnki05xNMXC8JRQiYjJbs7Wjhpc/9Zxy38PEQJk8e1gQhA1LvEY1mXgjQqpNPfgCdk+bqPx3qYXqx3CzG5PFC/09Ip4dbtcqKRLnun1KTaiRaiPhgGymVoLii02mUmdo7U1p7qa0G9jtjVvrwUSo4BCy7HcJBofr/pccZhZDJqfu7pFKatYvX8v7HqZdJsCi/FA+exXtPazVDwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Leacm4iRByqnWFw5F+GclDO3j67JX2ZwadIo5qzMmRc=; b=bE5O5klJ7ivzy/JrYzKf1ER61aBIPb52tZwe79im8TgiiqkIAbS7FpePq9JmxBg266E5P4ksZcFn4WAIxJGIAyb9klWmHrWeY09/lp+k+n/ngacHr/cTMe3+SK9oaqTxB4zaP/G7x/nqJ9Wxeor4o5CWzG0GwU57qE2jicziqtsZF4FYrsyKqyV7lFrJ6fA/ZRuRM90lyJqkV9TgeFhhDajUspNqsN9g6hj25XvtTqG7B0D0U7mys6u+0R7+YqcvnvLc2Yp+tnjw6S39uEo8yQ/d1xn+6dy8Y13Y8Ve37cuEE6EGke4alXXd9cloR8SRPqYjKYiEqbQ98MO8fS1hXw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6592a385-296e-dff6-f6f3-3f8fecef5174@suse.com> Date: Mon, 14 Nov 2022 10:39:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v8 0/6] Device tree based NUMA support for Arm - Part#2 Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <20221114063451.473711-1-wei.chen@arm.com> <3aa067b2-fa49-326a-c5a0-6735bc95951e@suse.com> <2beb3d17-99f6-77fe-a5d6-d60e665f01d5@suse.com> <73becaf7-8c94-1261-f504-865cc0425c79@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::14) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|DB8PR04MB7002:EE_ X-MS-Office365-Filtering-Correlation-Id: 9322d59e-9932-4c6b-e283-08dac6241a26 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h+xjglSDDGvj1FTlGyyqjYjnJhcRzlgX4hCSY02TVfwL/9opK3msZiDFIuYJgQLDofgDH8p+dhzVe2VEeZc+GlC5nqzFUAI1pxc+K2PCxm1eRTDBXDNx7in0Nu1lS4DTgkZeELtPCkcT2VqXQBm5xBVLmZiLvvS16T2zN42fFw/+CZ3EIJ2WLJwZjH2asbtv5ap4rQaXzt5SJgXxj7+bw73H4XtY2qu7Hyp07Vchrg7Z84hpO768ed26436KRIzGBRejpzxGKvW4PfyX062QB3gYxEc1d1xOKBe3/cJ6KD2yiK2GyL6AXlmnvPtFsbMJA29+O32MoOWowasva3way8EC0rH0G9/n+6cIsMLBqyXBT4VmPmc22NKc9qfS1zvbiT6abUTY7vILtUvaUr9irbuk62Twg1cCczcbBfV5X4kPFc2JlUqQqaOi50z1LKMXlvtIxyX00yF6E0Gz7kKNZG5qPhd102KNZV/c1/5TUN3WbAx50a0Dr/qwl5ew3dpEXiJE2UfBop3st7AtPJtEAQzQk8BFm2RwcuvXbEzF+7VnQrOGFRFDdTwSHOeSmkOvqJYBGLrxAqx7ALus/q1wSY45+qEzsCQMBI7EM2LRw/MBwpD9xFndTG+TFDZOXXdfczmp0P/nZ9VEjP2pktVRg0t0evPwJGXZu8GQT3z+ulQtofqq7jIYsMHignK/Rz5mwjSJK0DljHuuE49JUTQzymc663wE5ng1XKylvoYINNUyaFWxwU8xksZs1pJZa6cjBtyln2N5i4t4EVYd3iCgEIRkcLmRWz/1acodnefflw7EVL7/pfBp50Vxg8TyTIEXN2gs6Uf2/u8Lq5UQU0SqTQniNv4KPlJw8BF/w35ViIk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(366004)(136003)(346002)(451199015)(31686004)(2616005)(8936002)(478600001)(6486002)(966005)(6506007)(53546011)(54906003)(6916009)(2906002)(316002)(36756003)(41300700001)(86362001)(66476007)(66946007)(5660300002)(186003)(66556008)(31696002)(4326008)(8676002)(26005)(6512007)(83380400001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3RpR0x0WVhyWHRVRTMvZ2lOYkpkNUFKQ3ZRMWtIam9UMTFqZkFkTUI2UnRw?= =?utf-8?B?S05hLzRJbU44bG9uV1ZQTVFWbFRzZ21WYjk4Z0wzRVpONEp2dXREU1dnczhC?= =?utf-8?B?NUZ2bXUrN3dRWktPdVNhR0k1cnlTSWNuUVo1SmM2SnJjaWpweUVadWxTUUVC?= =?utf-8?B?ZzZUQ014Y0drOVZxb0dqMmdtNTY2emRJcDlXcXdpNVVxOUFtWnZtTktsU2hl?= =?utf-8?B?UjV3L2Rpc2dMNjQvcVFEQTg1cWdtd3FIYmhKQVRTdlpkM0FNTVRpRjJlTERT?= =?utf-8?B?MUdkM2lJd25EdGV1c0VORys3elFIRFFabEZGYUluTkEyL3RBbis5NWdmeVZm?= =?utf-8?B?SGUwdnExV3FGK05iQnd2M3JBaGp5L09kZzI5ZlFxUG5UWmgwTkkvaUQ0VGRI?= =?utf-8?B?ZExVcVQ3WThxc1Y5YXV2QTdoKzh5SjNnWk16SXA1aStteEpia0E5MFFpckFh?= =?utf-8?B?RFhlbFJOd0ovZXdTN1RBNUMwcUs0U0JJNTQ4dmNsUVY4dWVXSVVMcklsWlZ3?= =?utf-8?B?K2xDczc0UFZxaDRLY3g2MGdpdnVnM1l1NUxTdHBBd1ltaHZXbUswSnFzNG9I?= =?utf-8?B?ZWtld3dHbUcxZitwdXZJTG9rZTl6ejdNSlpSOFVlMlpPMHhjNDB4VkJ4ZEpy?= =?utf-8?B?S3hOdjJzbmFnYnZDT0pOZVFaV2pHS3pGaU5RR1hMSHV0MEtNcStBak1rNXBQ?= =?utf-8?B?YjEwWWIwSyt4UVR5VFpnU3N0UUtBRkU5UXE1MklGaFFpZnd3MnpnTjhNdDZN?= =?utf-8?B?WE1iYjRFcFcrOE5zdHpaSW42M0V5aWZPMjNDV2pKOHhpaFBZaktyRFlNMlky?= =?utf-8?B?MVpGVWJySHczWEZsT090Ty81cEg5am1wRUt4dm9tOS9ob0gydFpDaGZmclVP?= =?utf-8?B?TWNhZWthYmIzOXJoNnA5NzgvRWkzR0tkblcyQ0pqbjNZb2RMQlhQbllJKzdi?= =?utf-8?B?c2hZQ0JndExPcmFWc3prQnQ3S0t3aXQydXdYKzBxaFNjMldBekg3UFQ4M0tZ?= =?utf-8?B?bW5iOWNHNUN3Q1VJWVZ0S2xwdFozanlRYzIxT3VIVXBwYUM1Q3Y1bUVzU0VE?= =?utf-8?B?dUdTVHV1a2Z1SFA4WlVDZHFwVDByTmx6czFwU2xsWncwY3htY0tHazE0WmtB?= =?utf-8?B?cHI2bUFmV0VIWmVaV1NUa3BscHlrN2pLUkhJcStQeVdhYjJYQXUyazZVcE93?= =?utf-8?B?eFZOQitRZVZwQUNVY2ZTNFlzU0pDM1pvOFF0QUFiMkIzK1h2UkNmUEpHSzJD?= =?utf-8?B?K0hLWWQ2NWo3L3RVNGhYRlBvZXlOdXl0SXRycnhITnduN1VTTmxuRzRSaUs3?= =?utf-8?B?V3doYWgra1gwMUpZTDVTRFFtcUI3RUdqVHc1R1hNUmMzNHZhQmZZb3YwaHY3?= =?utf-8?B?aG1iKzNMZUd6ekJnRXZJSU9VMGtONDFZT05HQU5EMjlWS09pNXhOWVN1MTNs?= =?utf-8?B?eERnYy9tdFVwbStxeE5ybEs2V1JVdXorWHJDVXNYWlJZWVJHM0diRndSaGx5?= =?utf-8?B?Vk5PazY0NFBJbmVTM0NxRXJYVm5pekZ3V0RaWWZBS1l1NW1NVngwdHZGZEda?= =?utf-8?B?Wkx4SGZrUkFIc25pd1dRWlRBb2xKYzZ4VmVXWHFScUI5a01MNk0rS01McVE4?= =?utf-8?B?MmowbkMvSU0rRnFzSXh6THVQcHBsaCtyQktaR1NINnVZRUR5Ky8ydC9oeXNt?= =?utf-8?B?YlRrQkRyQ21jdlIrODlQVW8yc2tBRDM0QmJGcWRFV0JsMElzMy9PSjFJbWpk?= =?utf-8?B?VHZSNS9jcEhKYmtzREExR1FLVmZmM210U0J0Nkp6MmxSKzRkMUZrZmF3YWh4?= =?utf-8?B?UTF4OFFoYUVCbEtseFNqZlJTSkc1Mm0rVkN3MXpBWW5JVW9qdGQ1VVV0NHhM?= =?utf-8?B?Y0hKak9OZDBBZVpYMFBtLzFuTHM3a3k3YjJUREdRdVlwZ0ROUmsrY2ZtakY1?= =?utf-8?B?N3F2Vzc1R1ArMW1xUXNJYW1GWWEyYjNhSHU0d21XMnpCemlOam5BR05JaWo5?= =?utf-8?B?Y1hGU1RPQkFKRnJrM3VnMWxaUWJ5QlRhS1ZwcFV6OW0rRVpRU1N5S0VGOEFw?= =?utf-8?B?NXQ1b3BuWFc3TUk5VjZKNDdueTFsaTk0RlRqTERYMU45VXg3TXNHOEloRmtt?= =?utf-8?Q?YDFFk5fncoBQj4hRXYGpK55hG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9322d59e-9932-4c6b-e283-08dac6241a26 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 09:39:18.7162 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9u4f+WhqYPcGnGtRTE61ez+TwL3JYxfn2OKWcthgLk86TsMq66eTq/C9pJVZyGIwswbzu5h1bHBes2Rkm+RJ9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7002 On 14.11.2022 10:37, Wei Chen wrote: > Hi Jan, > >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年11月14日 17:29 >> To: Wei Chen >> Cc: nd ; Andrew Cooper ; Roger Pau >> Monné ; Wei Liu ; George Dunlap >> ; Julien Grall ; Stefano >> Stabellini ; xen-devel@lists.xenproject.org >> Subject: Re: [PATCH v8 0/6] Device tree based NUMA support for Arm - >> Part#2 >> >> On 14.11.2022 09:33, Wei Chen wrote: >>> Hi Jan, >>> >>>> -----Original Message----- >>>> From: Jan Beulich >>>> Sent: 2022年11月14日 16:23 >>>> To: Wei Chen >>>> Cc: nd ; Andrew Cooper ; Roger >> Pau >>>> Monné ; Wei Liu ; George Dunlap >>>> ; Julien Grall ; Stefano >>>> Stabellini ; xen-devel@lists.xenproject.org >>>> Subject: Re: [PATCH v8 0/6] Device tree based NUMA support for Arm - >>>> Part#2 >>>> >>>> On 14.11.2022 09:14, Wei Chen wrote: >>>>> Hi Jan, >>>>> >>>>>> -----Original Message----- >>>>>> From: Jan Beulich >>>>>> Sent: 2022年11月14日 16:05 >>>>>> To: Wei Chen >>>>>> Cc: nd ; Andrew Cooper ; Roger >>>> Pau >>>>>> Monné ; Wei Liu ; George Dunlap >>>>>> ; Julien Grall ; Stefano >>>>>> Stabellini ; xen-devel@lists.xenproject.org >>>>>> Subject: Re: [PATCH v8 0/6] Device tree based NUMA support for Arm - >>>>>> Part#2 >>>>>>> So in this patch series, we implement a set of NUMA API to use >>>>>>> device tree to describe the NUMA layout. We reuse most of the >>>>>>> code of x86 NUMA to create and maintain the mapping between >>>>>>> memory and CPU, create the matrix between any two NUMA nodes. >>>>>>> Except ACPI and some x86 specified code, we have moved other >>>>>>> code to common. In next stage, when we implement ACPI based >>>>>>> NUMA for Arm64, we may move the ACPI NUMA code to common too, >>>>>>> but in current stage, we keep it as x86 only. >>>>>>> >>>>>>> This patch serires has been tested and booted well on one >>>>>>> Arm64 NUMA machine and one HPE x86 NUMA machine. >>>>>>> >>>>>>> [1] https://lists.xenproject.org/archives/html/xen-devel/2022- >>>>>> 06/msg00499.html >>>>>>> [2] https://lists.xenproject.org/archives/html/xen-devel/2021- >>>>>> 09/msg01903.html >>>>>>> >>>>>>> --- >>>>>>> v7 -> v8: >>>>>>> 1. Rebase code to resolve merge conflict. >>>>>> >>>>>> You mention this here but not in any of the patches. Which leaves >>>>>> reviewers guessing where the re-base actually was: Re-bases, at >>>>>> least sometimes, also need (re-)reviewing. >>>>>> >>>>> >>>>> I just applied the v7 to the latest staging branch, this work has not >>>>> Generated any new change for this series. I should have described it >>>>> clear or not mentioned this in cover letter. Sorry for confusing you! >>>> >>>> But you talk about a merge conflict. And that's what I refer to when >>>> saying "may need (re-)reviewing". The same happened during earlier >>>> versions of the series, except there I was aware of what you needed >>>> to re-base over because it was changes I had done (addressing >>>> observations made while reviewing your changes). This time round I'm >>>> simply not aware of what change(s) you needed to re-base over (which >>>> is why I pointed out that it is generally helpful to indicate on a >>>> per-patch basis when non-trivial re-basing was involved). >>>> >>> >>> I had thought it was a code conflict before, because our internal gerrit >>> system marked that this series has a merge conflict. But the actual >>> situation is our gerrit setting policy problem. There are no code >> conflicts >>> in these patches themselves. We also did not modify the patch to resolve >>> the gerrit conflicts. Regardless of whether it is a new or old version, >>> if I modify the patch, I will remove the reviewed-by. >> >> I'd prefer if you didn't unilaterally. Instead I'd like to suggest that >> you apply common sense as to whether mere re-basing might actually >> invalidate previously supplied tags. >> > > I will keep this in mind in the future. Since for v8 there is actually no > change (except patch 5 to fix the comment) compared to in the rebase > compared to v7, should I invalidate your tags this time? No (with me now understanding that the statement in the 0/6 changelog simply was wrong). Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 14 10:14:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 10:14:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443224.697764 (Exim 4.92) (envelope-from ) id 1ouWTd-0001NX-C1; Mon, 14 Nov 2022 10:14:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443224.697764; Mon, 14 Nov 2022 10:14:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouWTd-0001NQ-8N; Mon, 14 Nov 2022 10:14:05 +0000 Received: by outflank-mailman (input) for mailman id 443224; Mon, 14 Nov 2022 10:14:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouWTb-0001NJ-Qd for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 10:14:03 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130052.outbound.protection.outlook.com [40.107.13.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0fe82300-6405-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 11:14:02 +0100 (CET) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AS8PR04MB7495.eurprd04.prod.outlook.com (2603:10a6:20b:295::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Mon, 14 Nov 2022 10:14:00 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5%3]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 10:14:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fe82300-6405-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n4rUQHgBuZLw/ICToqjKgatK9uiK1qk76bXO4bpGQnAIa/cm0RdIPvY9+sZew/Q38yGb+++V42byyH1/y38DOkwljYGUZRXarA+jI+p1xCSyvAnRfnC8GYxeEyj6aJ6kaTJxcXNJurRrFEotPYqjIPTTgay9z3O7cVf/kY2nYhUx7DCMGbGVzyr6XNGgWB4GlH6hL6BtIJFYZaLQ6FrSwXldh5FAdN3lbH+8H9zodee2H4Vd+7kV/5P6Zlo5oFY9hicpcTXZldheraQ6JEjj6k4yoCO0IvvXTP5JSFpiJvXXQ/NOALD1B644ABxHX8e+KODGwEfP/zv+igOkvw+k1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bDg6WjHBKLnweFvSdnfYqoVVNaj+eMRAPRBVESqmdOk=; b=iMAyvvW6mer/wBFU/qin7C4c9EshKsftI/j02fC/kpa4uIHjyVLe+Vna7W01KdN+Gsfk8K9/m0dSE1Md91+tptLkHEKh5ixx8ksscUgD95K/GkI+lqtrlKW+cpEv0kcZIYxCscl64PTgOE1M7o4hEsPjTkMvDLG9hEJNBvNN4wG2a9T2C0hgalct5SaX4nYa6GTyeSSecaAFeBLs6qefp+hl9haXjVWvHxWUXSfNBFnjrGrujTPT53SXCUr55iloSppuHL2pG/FtAsDa0H/SpfzGGZ/b9W6knOHdnSgj5gb6RDgizJIS3i/hmw6UkYONaTn3XEwEnlMhoqAYhiRg3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bDg6WjHBKLnweFvSdnfYqoVVNaj+eMRAPRBVESqmdOk=; b=YoTFiIH3pKeh6mjcTeK+7uTBzYZxqBLrqF3DNN0fLtkv032a1yC1krRKH1xKDyDf8sSX+N9Zi7QpkRs93D/qwyuSWtZxMCxCcDipCeLUkWqmQwy7E0LuxPukNB9yYa4s5xjbdvt2LFvGEXf/DVgKXdq9zEsXHNLD3IksT23p5p337xK9uiSF/Q3rc1gp8QD5t2j946vBOKKCRxtafX9KsuwhSND+MZd8MEFFOpVOM5UYTCFtL/h7uW31G8EJ9XF7go6VC4q6cIlNqK/26j/K+VRFwgaHG57WI0ZHddiggGSJ2LKTSygyTOaOboRWtS7HcZ3hNcxoPFRpgzKCK/9dxg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 14 Nov 2022 11:14:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/3] x86/msi: remove return value from msi_set_mask_bit() Content-Language: en-US To: David Vrabel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , David Vrabel , xen-devel@lists.xenproject.org References: <20221110165935.106376-1-dvrabel@amazon.co.uk> <20221110165935.106376-3-dvrabel@amazon.co.uk> <29e6e6ca-ffb8-3719-5004-0cccaeb5578b@suse.com> <2991d69a-eb13-7044-d65f-14540676e642@cantab.net> From: Jan Beulich In-Reply-To: <2991d69a-eb13-7044-d65f-14540676e642@cantab.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0068.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::15) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AS8PR04MB7495:EE_ X-MS-Office365-Filtering-Correlation-Id: 73e50b56-0c60-489f-b0a8-08dac628f316 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +P1sKUlsUSQPuZVSqHmdTMrAu2no4aCLgOwQ0YoPJSd3H8vkBrI06J3HprbjULVfWn4TRES9ye3dX5ZvJDCge+G6Qsle3gGVwOx2u6wmpUpFTPkVCwoFMNtXp0bxZku2wt+kuz3aRtQ9T6xKwo61jMw0p85bwjjEpxSxEtHNo9uYCdUTLVyhEQqgWgtiA/vvJBjIO7BEw/VfAqNLekPEMH48EiW4bTBssD1NPt+Nc4DeOC6PhOPi3JsLSoO1KgMqNzPXHkULeI/TmQSuchKyF74BnPnYOlUDXQVsQoWVyrRs4JzGxmoiVmAPNyegu2u8iGZFrWjiov8X63WKBe7ZoLNROV+UGb8eHZ47TeLBF6wf/BaEsKFFBBES55t/d0WmNHHJsQi6nAIuijehSOaScom1js0fvu5EFn1bvmCpjyQRLeAiXKGB66stNNZD4aMzO9WJNl6f1gUWFvvHxdEy41ZutI70INtnr0Olpcxfdo4lLUNNVu5qrR7nryuE8IGOzMHazVVCNyW+7RWLapIP4LWOjOR/MFEc0bDNko0nkg2GA8BOXZx037oTyP9cSzteCoe9rFyCnFvDw1+nBRBvKcMXO+8Eio9GUHR/GQofOcRtsluF6w1n3FmlzSD143kN7cYcaOAeHK+OYXKGBoN9MpbV7ZvR5hAequypSGn7FG2rgcAlq5XG5Vsvp37jOFdZE2UcM0jHLsOlmJZ8fQmHmYwW2Zvj8G0P/qCm1hJrI44CNLM+hXz75yeQzfHjCmr9gumxltwDuPR6SFbHWoLVCTOoaLkSH2B/oFltMJoBvoA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(396003)(346002)(136003)(39860400002)(451199015)(6486002)(31686004)(53546011)(478600001)(66899015)(6506007)(6916009)(54906003)(316002)(66946007)(8936002)(6512007)(36756003)(4326008)(66556008)(66476007)(26005)(8676002)(41300700001)(2616005)(5660300002)(186003)(2906002)(83380400001)(31696002)(38100700002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWRSUy9nM2NYSXpsUlA2WDBGdFlvclFjVnpoeC9aZjFwUWdzaVJXNmRvakFN?= =?utf-8?B?cnB4VC9uNlBqbXI4WmR4NFBJd0lRdFRHdSsxc1AvK3FUNFB2VW5WSGF4bmVK?= =?utf-8?B?eTFQNk4zeWRaTUUxYWo5VjJSak5NNGxuc2N0TFF1YVdTeW12Y2lXSndCK3Mw?= =?utf-8?B?QnRIa3FPOXlZcy9FQWlQTHU5Y0Vidm5HN085a3hSVzZSYlo3WUZ4cFlGenVD?= =?utf-8?B?UGViQlc0c01NVThmYlQ2bzlyTUQyenNwSTBJMmdJZzRzcjUrMTV1eUh0dCt4?= =?utf-8?B?aE1OUFFwSzBIUzRmRFRvcEQxQXk5cXljd051NWNNZXJwbnpkRmRVMGpNdWhX?= =?utf-8?B?dXFGc09uMTdWNis5aUovUUo1WUZQSnA5QXRER1MvOU5CYWhHT0Z2WDRGWkow?= =?utf-8?B?OFd5RDBIWHlsTExOZ0lBVmZQdW93UFZsc3E4b3h0TTdmbUt5RTFWakdYeXJG?= =?utf-8?B?eVZNY1FoQWQ0WWZoU1VBSnVQc2xKNHVBK1VyZDBSZEFBT1hvQklrNDhuSjI0?= =?utf-8?B?K2QrU2xnaWRmSTcxRWtTWjU3d0k4a2N3OStNZkdYeThubzJRREJlZnNUbFV2?= =?utf-8?B?L0pvUFlPMEtEUzJJNVhIVFRVWVZuV0VSUUVnQVJVSDhXdEVFS2UzMGZPMmNY?= =?utf-8?B?SjM2SGxBUEdSRnF1WWowS2dEYktFeTdVekxJTHoyRkNmUWZyMEUwVmFDZGpG?= =?utf-8?B?ZXltd0RXLzRwOUs0a3loWXdwaG5wYk0xOStucTFVQjFmbkwwbWFKRXlVcXZu?= =?utf-8?B?NGd1VEhoUGxGUStLMThkT1hPdC9wQjJIMlBiNzN0VUtqcmpqV0dwWXFjR21U?= =?utf-8?B?d2V4Rm43REpYc2NRQlNlbExqSCs2YzhUemxNdE9mQWFrZWpnRlYyWS9pTGJQ?= =?utf-8?B?bThMdUp6RVRTU1AvYitFeExjT3BtRGhmeTRNd3ZTbnJxekRXZGpJcHY2aDdw?= =?utf-8?B?ZnN6MnUxSHN1TDhKM3FKaTlsZnZMNWNwVWZXV3k4ckd3aEpVTlFQQVYvSjFn?= =?utf-8?B?SWM0TDlSRjVBNDlhZU1CWlFrcit5Nm1aZkVUUTBnUFY5d1pFcE5paitSbTlj?= =?utf-8?B?QTZyaUg1aGRqLzYzK3Uzb0x2MDJHWUJDK21LVFRpbmxkT2FoelZPSTRGT2hT?= =?utf-8?B?NHQyb0MybWJaRGZWM2pBQ0c1QlpPVEV0amdRZW1pcnJQZUZJWEVVNEN6T3BL?= =?utf-8?B?NytWSVJ6UXQ0WjYxc05XQnJJOHZJYzZUeDJiRXkrQ2QwWnZucHkvaFBST1V6?= =?utf-8?B?cnZQSGFWU2hvVnBsbUdsSGZ2MGtET0QrOUNKMTNTWHcvVnpXeWVzMmRuUEhk?= =?utf-8?B?dXdxTHIvSXBuZW5iYk44TmtKckViR0wxeHZleStMQnBPL2hIdlp1OU1wMHZX?= =?utf-8?B?QUF1NVU5OTNwaXlTc3B0ak5tUFFtb1BleGdTTThEaEN1VmVaZ0hjMWJsTk84?= =?utf-8?B?TE1IWVN1dWlxejlGM3ZlSkFqUmNiM1VhdSs1bXgyeHM0RFhNS2JWSDg0c2Zw?= =?utf-8?B?TkpRZ0xCSHVWanVzcmhTdHQwR2lhVWJUV08yRjBpV0FSaGZ0WVJYNzVGb2xE?= =?utf-8?B?eVN0RHFmMEQxUnJHMWNreWhQMm0wT3QrVTRzWDdVOW04UTg1UElCby9uVXlo?= =?utf-8?B?dE1FWXNETE1jZzhHK2tGN21SN3AvREl2UWhXVW9zcXR4dXNzL0laRUFWSm13?= =?utf-8?B?dFErdmFITGlXeUl5dGdWR3VXc3FZV01iSVEyenBMeWtOYjZNRU5kN01Fc0dH?= =?utf-8?B?ajhmVGdqOHpkYXRnZWVCVkt2VEM3S1ZIMzJBQWczV3Y2ZFhhSVJNckJ3cWlP?= =?utf-8?B?Y3djdVliK3VpVjNtUUhILzlpYVJhS3Fzd0VPeEtQWlB6ek15dk9oUjNKd2VG?= =?utf-8?B?QVJoQmVPdmtXR0dTMmQyb015M21yZmZWUDYvcWZRa0VNWGxLcE45MCtaUlln?= =?utf-8?B?VkdhcDFnYk03Y3VSemRNZmVNMmxjMWsxUWFIRGEralZ2cG5Sb3ZhN3gxamIx?= =?utf-8?B?ck0reWVldndrenNNVVBCaUZhWXJOVXdvRUd3ZlZuT053NnB3cEplc3RWcktS?= =?utf-8?B?di9JbHJRbC93WnRtcXBGTVZ3OEN6NVVhS1VCTnRXYTBLa3FPQUtKeFNVVjEr?= =?utf-8?Q?7mKnh4xVskvSuRGuKWw0R6IcM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73e50b56-0c60-489f-b0a8-08dac628f316 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 10:14:00.6938 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R7XwhS9OeNlQP2JB1Gz7l28+whmTHYK1fY0+nbCjUoPFx6lXmbztv7Cwwe4TU8KLgiEA3uQrteRzEmdc/cMYog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7495 On 11.11.2022 15:41, David Vrabel wrote: > On 11/11/2022 09:44, Jan Beulich wrote: >> >> The idea of the WARN() / BUG_ON() is to >> - not leave failed unmasking unrecorded, >> - not continue after failure to mask an entry. > > Then lets make msi_set_mask_bit() unable to fail with something like > this (untested) patch. Would this be acceptable? > > David Hmm, that's quite a bit of code churn for something which, for now at least, I'm not convinced needs changing. Yes, ... > From 837649a70d44455f4fd98e2eaa46dcf35a56d00a Mon Sep 17 00:00:00 2001 > From: David Vrabel > Date: Fri, 11 Nov 2022 14:30:16 +0000 > Subject: [PATCH] x86: Always enable memory space decodes when using MSI-X > > Instead of the numerous (racy) checks for memory space accesses being > enabled before writing the the MSI-X table, force Memory Space Enable > to be set in the Command register if MSI-X is used. ... there is some raciness there, but we assume a well-behaved Dom0 (and DomU don't have direct access to the decode enable bits), so the checks are more to be on the safe side (the original change attempted to merely deal with the specific pciback behavior, without impacting other [odd/unexpected] things Dom0 may be doing, as long as what it's doing isn't plain wrong/buggy). > This allows the memory_decoded() function and the associated error > paths to be removed (since it will always return true). In particular, > msi_set_mask_bit() can no longer fail and its return value is removed. > > Note that if the PCI device is a virtual function, the relevant > command register is in the corresponding physical function. > > Signed-off-by: David Vrabel What I'm missing in the description is a discussion of the safety of the change, in particular the taking away of the control of the memory decode bit from Dom0 (over certain periods of time). Without that I'm afraid I can't answer your question (and wouldn't want to review the change in detail). Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 14 10:31:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 10:31:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443251.697776 (Exim 4.92) (envelope-from ) id 1ouWkW-00042w-OW; Mon, 14 Nov 2022 10:31:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443251.697776; Mon, 14 Nov 2022 10:31:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouWkW-00042p-Lj; Mon, 14 Nov 2022 10:31:32 +0000 Received: by outflank-mailman (input) for mailman id 443251; Mon, 14 Nov 2022 10:31:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouWkV-00042j-1A for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 10:31:31 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7d98d61a-6407-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 11:31:27 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D047F5C01A3; Mon, 14 Nov 2022 05:31:24 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 14 Nov 2022 05:31:24 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Nov 2022 05:31:23 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d98d61a-6407-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1668421884; x=1668508284; bh=ucONn4Vdr4H2NM0BX9SZfqEHZEPMffIrGjL SNtqQzlM=; b=Vp72NYFefjy9vy3UqOS+H1WUdeGDGamvbwiqHAR/1cOB1t/JaIS QD3NER9FDpkdrBLDdMcGdcqUSXEIi7rZpWY5OcbOaEdz9auBDmv4pXIxSha505H6 aY33T9v5S4K82NwBzx35OkcmqjEa+M44EO71+8+JC27Ui2QgiBUf443CmI924Qm+ Ttxde/WDwa4/Ye7C5Fz4ptyhJMPV76oF7GnFsSz9LjFzN/0me48J98KRjuy6+Bf7 /Tlmu4Ff8jvuPClkb+Dszw8dHKd7eXuUQBN081XIwJfrrjAN7thpY3HBgXBxQ1IZ LrV7xaXl80LKnTBxGf4/yrRxaqYeKmDnbGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1668421884; x=1668508284; bh=ucONn4Vdr4H2N M0BX9SZfqEHZEPMffIrGjLSNtqQzlM=; b=JFF542PckgJqbVZS+4Do7YSqN+jSO TKt7h2BkG/G2j+sv5jYmGCUy6L1WiHZplZuxwFTUwZLWTVkzOHDD39s5WIIYGMaW EcWM1M9FKtiM/qU47tnZDbAePVpE48iW96buzCy9YL3h9Ec97p8DO9mL1xa7CDZW EDkxZ7AM1gSJQhBlqH5oLpimul8pSU4erAGCtfEs1zhaaBJOce0mwqdMe121Gean kFkLGyJ9GV9iCDjVlLA3PYRhxHFKeZcC7mYHakHlCTPq4VZkNwbyijS4uKxZCugR yryKiOapq7xmT95ay7kxSkg7ZT+EYDmuN4fkBSu5Kgir892NoVsqHhHww== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgedugddugeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelkefh udelteelleelteetveeffeetffekteetjeehlefggeekleeghefhtdehvdenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR INTERFACE) Subject: [PATCH] xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKALL too Date: Mon, 14 Nov 2022 11:31:08 +0100 Message-Id: <20221114103110.1519413-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When Xen domain configures MSI-X, the usual approach is to enable MSI-X together with masking all of them via the config space, then fill the table and only then clear PCI_MSIX_FLAGS_MASKALL. Allow doing this via QEMU running in a stub domain. Previously, when changing PCI_MSIX_FLAGS_MASKALL was not allowed, the whole write was aborted, preventing change to the PCI_MSIX_FLAGS_ENABLE bit too. Note the Xen hypervisor intercepts this write anyway, and may keep the PCI_MSIX_FLAGS_MASKALL bit set if it wishes to. It will store the guest-requested state and will apply it eventually. Signed-off-by: Marek Marczykowski-Górecki --- drivers/xen/xen-pciback/conf_space_capability.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xen/xen-pciback/conf_space_capability.c index 5e53b4817f16..097316a74126 100644 --- a/drivers/xen/xen-pciback/conf_space_capability.c +++ b/drivers/xen/xen-pciback/conf_space_capability.c @@ -190,13 +190,16 @@ static const struct config_field caplist_pm[] = { }; static struct msi_msix_field_config { - u16 enable_bit; /* bit for enabling MSI/MSI-X */ - unsigned int int_type; /* interrupt type for exclusiveness check */ + u16 enable_bit; /* bit for enabling MSI/MSI-X */ + u16 allowed_bits; /* bits allowed to be changed */ + unsigned int int_type; /* interrupt type for exclusiveness check */ } msi_field_config = { .enable_bit = PCI_MSI_FLAGS_ENABLE, + .allowed_bits = PCI_MSI_FLAGS_ENABLE, .int_type = INTERRUPT_TYPE_MSI, }, msix_field_config = { .enable_bit = PCI_MSIX_FLAGS_ENABLE, + .allowed_bits = PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL, .int_type = INTERRUPT_TYPE_MSIX, }; @@ -229,7 +232,7 @@ static int msi_msix_flags_write(struct pci_dev *dev, int offset, u16 new_value, return 0; if (!dev_data->allow_interrupt_control || - (new_value ^ old_value) & ~field_config->enable_bit) + (new_value ^ old_value) & ~field_config->allowed_bits) return PCIBIOS_SET_FAILED; if (new_value & field_config->enable_bit) { -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 10:47:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 10:47:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443256.697787 (Exim 4.92) (envelope-from ) id 1ouWzi-0005hD-Vq; Mon, 14 Nov 2022 10:47:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443256.697787; Mon, 14 Nov 2022 10:47:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouWzi-0005h6-Ro; Mon, 14 Nov 2022 10:47:14 +0000 Received: by outflank-mailman (input) for mailman id 443256; Mon, 14 Nov 2022 10:47:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouWzh-0005h0-74 for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 10:47:13 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b09f95f9-6409-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 11:47:11 +0100 (CET) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AE8gwiq016065; Mon, 14 Nov 2022 10:46:54 GMT Received: from eur02-db5-obe.outbound.protection.outlook.com (mail-db5eur02lp2111.outbound.protection.outlook.com [104.47.11.111]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3kt4pm57yq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Nov 2022 10:46:54 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by AM7PR03MB6546.eurprd03.prod.outlook.com (2603:10a6:20b:1bf::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Mon, 14 Nov 2022 10:45:54 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::37b7:df9f:30b7:b89a]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::37b7:df9f:30b7:b89a%4]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 10:45:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b09f95f9-6409-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aGw3raqRN56WFwiPDnIPo2p7nQFNU0xUyTLFddlYixNLeaakbJrGMHRgpOLxwjBnjbag2smnx9W+dePT39KONByhlDzgGMs98cPxzJW24wTYNotgePglu3OqC2yluWo1xh3/DGjeN8S+4+hGnAPno8QqAX4+UpNakycixVQ4bMiV9qb5l7Al3IsUwgywkmiz1HJx+i5g2p/WXhiaYke24yGJ6JxAZERpcuyJZLCy2y6oo1NC/IplmNkIdNeV+3bIw3bW8YLhwPaoieOb8A47r+RIUP4AbirNJtl5ruD4aA1keTYvv15Aw2SVWsNrwbJPflZsOijUwqmn3p/9SlEW/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fevBkTPNXeMFVaX0MKbOLarAmh6rSiRFVTzDzhoa4gA=; b=cB70QAcHPP+KvQFn3TS6Pgd7WbmPPKoiH5I2R/wyNvBu7bxsW0C+2oe5hnqAeHL2yAijNbz35e/Iqbq+HuUL5P0aAb9qiKlnzzX4n0oQB5S+v6pHRYxzVNY4I6rvSs45Z73iZEnhnuHWT6+luPe81ScXoAq6qj+T3Fim2sZA899g4ZsagOqkEUplYQda1k8NSl9Nrhn4paPeTIh0w7On85gs8CRG60fc2hnZtgOSwxIptwxcbG2sGhvDKEVPD9y4tsPW4ioo3cxbFahpRxoqpyc9sAqW4Z+vmoBMAMWWlIsnbvy9lfOOmuwn7afzusvq5XkKk7rVBBatGJ86rFyX/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fevBkTPNXeMFVaX0MKbOLarAmh6rSiRFVTzDzhoa4gA=; b=P/Wyh7LIUatucVOseujq//LN2OplzGJ5q5mplbywy9qB3NELHkja1M24kG5iq7AFDeJ6nskqxaZ17+e2SNOSaWBzOtg71EU/nfRZocZPKJTWWD5KVWxcWrtQypY/6nT/9Fxaic3WKb2vfJlsEx9ndmhqGVcKOd27+HF3HEuVqFrhBller5KZuQaLfTTLh+LHRO3q+B7ckHNbCs2YcSmi/BHkVVh7bFY9Tn+tqIPEVpyJ9s84FrvQbhDu4BwI467Wns3H3b4+GXLYABYG/6KwNQoyCOgJ+I1aVI+Zha+N/SiiEVBLdjsyKTVXJq8lv6lNn5TwWXawj41WIAewDQ6FUg== From: Oleksandr Tyshchenko To: ruanjinjie CC: "jgross@suse.com" , "sstabellini@kernel.org" , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] xen: add missing free_irq() in error path Thread-Topic: [PATCH] xen: add missing free_irq() in error path Thread-Index: AQHY9/gpVHEumnLn90aQTNX0N6Gi5K4+PJAA Date: Mon, 14 Nov 2022 10:45:54 +0000 Message-ID: <4b735f01-6028-d7dc-d715-8c56c790a8ad@epam.com> References: <20221114070702.1887144-1-ruanjinjie@huawei.com> In-Reply-To: <20221114070702.1887144-1-ruanjinjie@huawei.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|AM7PR03MB6546:EE_ x-ms-office365-filtering-correlation-id: 86fb9042-89c0-4f2e-b9d2-08dac62d67db x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UbtksaEgj69dW3LjaKMq2hsJhfr6wZ7FqLC3mp37txNHzo/vGKE6FzJR49049CuZGrL+8+Aw8kZiUTt1VltuWI0PZkfOQVkqueeYTKOsYJyBZ8CZguDIztOvmcI36VC6OOpiSkuEqJnPNLbpxKJ77FihUzAp1mFskgeXIHosaoOsTj06XLQkKiU27cZDeXH9h8oGNMXv5LukQWvVgCb7oQO4HoxuNJqY3VN6JhUV+ZzTdXPDzwPSF8x5DbyCwLveqkYfm35ujnqUxdv3KulRtHSy3Dlj/Bhhw2uhZGwont6ddhTQ4G9dtyn5o0kORFDQ6upEzzbNlctZcdmQTHE4jQxNPLD9N2OL91kiSiHAuzmrXToL4kOnglQJkrS8gDFMzHdVuvW/Biw00SRe1uxl0pBqpTncG7nxTzCNV/F0DxJ5iKVmjaqr/m8N8ShDIq+WsKFunfPD5dORSUh25gBTTq/EwiIkJ/0DRRhX6nKQPHeDnLvyujyFGeR3AnuFG4zLjO6zbeVlufO2LpecK6JonWRWmQGPArG31wtotcFI6G+rt8YdS93MLVQKNTpGLQVp1PwzlkpH88/ouYbd1xlqXSb7E8KvxCKMnyqywpsWT4E55Rju+7EFeGSBTcwdxDd+zyTpfM9m7FP25mGZ6kIi6YNtxZ/+UVAFAJ5aeCj9ZJBkJO2QMu+1rZpIr1UBl5415MC34zi965Ck/fn/hH9DWuIOU/Gs3n7eYEZszpdJprSqMPCnvAqVRmgJ87oEUbV+dDo8pSUpMLHIfSYvI+VmwTR+aOplvq698nUycwVoBgI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(136003)(376002)(366004)(451199015)(83380400001)(38070700005)(2616005)(55236004)(186003)(122000001)(2906002)(38100700002)(8936002)(6486002)(478600001)(26005)(6506007)(71200400001)(6512007)(5660300002)(53546011)(8676002)(66556008)(76116006)(64756008)(66446008)(4326008)(66476007)(41300700001)(66946007)(91956017)(6916009)(54906003)(316002)(31686004)(36756003)(31696002)(86362001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VGZnN2prclhXRHk0OWpJM3JNL0NNN3BvSHFDcGZtMFNsUHpPTm90d2d5bDN1?= =?utf-8?B?eWJ2aGdlY2prTFFzWEQyaUlCeS96Um5aMEV0OU4zYzlhMWpVRExvUVJ0c2dI?= =?utf-8?B?RXRteWlQV2hza3RoREhvclZtVmgzS0Uxa1dJVWVRdmtjQktWdUJNb2NMSXNX?= =?utf-8?B?am5KQmJmMTdGT3drelVySDJvdHhFU1ZxVng2dW1LdXdMME1CaVdIU2EwdlIy?= =?utf-8?B?UzQ4QmhpQUJHSm8xaGlKcVRPMzdUUGIxdkRXWkxwMnN0ZE8xRE5HNVFpalFy?= =?utf-8?B?VlMxNkRiZWwyZjBOQlhNRi9YeDJrY2lsQ0NDbTVueWcyM3BiV0JwdEZDdGoy?= =?utf-8?B?OWt0SDRGT2hHaEFCeEViUHpUVE5kSHhmV1IrMFJxWFNKS3RVV295YzNCd2pK?= =?utf-8?B?WmFKaFJzY0NZQVpGTG9uT1FJcElHbE11MmpDeW5YbzdQbTlRMUo1ODFreUdj?= =?utf-8?B?M0FJaFV4aGh5WDN6L08xTnVDaitVQmljM1Jqdm5JT2JYOUlLT24yRmM3U1Yw?= =?utf-8?B?QmRScEgrcVpIbTVCT0Z0NXZnanRTeEt5d2hrL2lHTER2czBzSXJvY29MTytx?= =?utf-8?B?V3RuYWFocHBnWHdhcXE3NDBYa0NJQXlqTnZkVGlvQVIxZFYzTWRvZWt2eUNm?= =?utf-8?B?dTdjaEhqdzExUTlEVTBGQU9DdnA0QUFwVmVyOXhIWG9jWlJtVE0rand1aEdz?= =?utf-8?B?UWE5am1BRk9wb3VSWEZNVUhPckJ3ZFd3M281WWVpZ2tWRmU5RGhmbjNZVDVj?= =?utf-8?B?eDJrWkFOTk05TG1EdTM5eHlNZFJ1ckd4R01jeldjOTVHUVB4RklZb3FodUQ3?= =?utf-8?B?dFNDVGRaYWJleU9XUzBidmt2U0J1MEY5VSsrSUdPLytueUF1TU9CZnpRRlJm?= =?utf-8?B?azNiK2xWeFVwWVRRN1dtcGFncTlGTU9rL29ucTZjZW5LTDNsM1FwUWcwK2x0?= =?utf-8?B?bWtTNDNEajU5aHZJdVRaUE5ZdjNSdnF6b3dVaGc1ZFFFcTVxZFZEcUUvQ2Fm?= =?utf-8?B?elN2aERWWnBOdVljZ0VnY2VHMlFvdHZtbmgwM05yMTdTNnBMRCt3OG5KbEZk?= =?utf-8?B?OUt5Rkt6OGx3aDVmM1lXZnV1bHhzTXB6ZmM1elk3SGZTL0xKbzkvcVlVdHlS?= =?utf-8?B?cmF1QXpSMDFFMDhDZWFUeXA1djRoWlR5c2VobUVxZ1lnMGE2WFdZaWZpZHZW?= =?utf-8?B?TmJaSUFuUGFnbGpJL09NcG44SklQOXMrK1BSNEx1NkxGeFlnV1lNQ1FucEI2?= =?utf-8?B?SUhHd2x5elpIR0V6WFE3WnA5UTBjc081MTZWdzgyMHBubk9WeW5NcmNvWlpQ?= =?utf-8?B?WXVRMy9TTi95cGlBSUx4dnhRNjB0MktXNCt0VzZwLzVUZGw4cEY2dDc3aFRn?= =?utf-8?B?VGhPTWNNdVUrWnMyQmRtT3RUZ0czKzMzTndNR0tkL2hibng0cG5jbGQxYWxj?= =?utf-8?B?TmtVcmd4Z2RFWVZ1U1NEVG5jUUpXc3VXTVNEaTlhNFdpZktCSHliMVAvV0JU?= =?utf-8?B?UEJyT3NlZTJoZFBqNXM1L2NOdlZ2VEZuTzlxNFBpZGdocEc3VThCVHZJK3FZ?= =?utf-8?B?WWZQQnFpUGlYRm1RVC9xNmowazMwdE53c2w1QzNUOEJFbzF5TnpxeGsvdGRL?= =?utf-8?B?dXIvTTQxTU9FM29GSnBHcU9hVTVCVlN0RllGVTJQbFltWkg3TGg1d09hN0Jh?= =?utf-8?B?WVNwbDNZUWFPVDhSRCtLcXBrRXFnM0t5NlRTb2pjVjBJZGdvcjVhT1NXMGNE?= =?utf-8?B?cFpsczlYNFBmZmZJRkI3YXNnM0NURTBSYUt4SDZWemVsc0lnRzY0NDJsdUNW?= =?utf-8?B?SXpTMzNuRFZXR0VuT0R4aVM0cjB3TlZjU2YzTEJBYU9QN3pRRHpPUEg4N240?= =?utf-8?B?QWhvVW4wa3JCZ3M0bGtRWjFGY0ZwckJmSXNoc1V6Q252MDRNYVJQZ0Q3NHhK?= =?utf-8?B?QUc5aG5HeTZnbXRETGVDKzg1ZkFOSXVPVkQxTVJYSStWakUrUy9ueEJMVEFV?= =?utf-8?B?N1dCVXRJbC8yWE94MkZPOFBoY2pRMU1JMHY2ZXkwM29xemwyRHArY2RRdTJw?= =?utf-8?B?c001KzIyZUl5NmFoUEpTZnZJa2FSVHJpdnFFWG80MFAyYVpaVVJNUmIvN2xj?= =?utf-8?B?bXB5VTlrSCs0cFpUa1dubDdMTVRzeFgyWE4zWU4yVmxlWXYrSGV0OWlaV2k1?= =?utf-8?Q?JkMRWLtAMmwsnSDKlnJEUUM=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <68217844BDBE554CA29B78D501DA1C90@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86fb9042-89c0-4f2e-b9d2-08dac62d67db X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 10:45:54.4002 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DOrDh6KMOG04lBAL5ok9S57Mb42lzQThyhqPb6WuXJvnd1iDla3EgZow8RdsxBQ49mysm5g308SQZDulRfVfnUv3p/UuxRGm5wotdsNne30= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6546 X-Proofpoint-ORIG-GUID: MgblZhzVT5SQ8QsGrKZEBmeUgFsDvcbD X-Proofpoint-GUID: MgblZhzVT5SQ8QsGrKZEBmeUgFsDvcbD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-14_10,2022-11-11_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 spamscore=0 clxscore=1011 adultscore=0 mlxlogscore=999 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211140078 DQpPbiAxNC4xMS4yMiAwOTowNywgcnVhbmppbmppZSB3cm90ZToNCg0KSGVsbG8NCg0KDQo+IGZy ZWVfaXJxKCkgaXMgbWlzc2luZyBpbiBjYXNlIG9mIGVycm9yLCBmaXggdGhhdC4NCj4NCj4gU2ln bmVkLW9mZi1ieTogcnVhbmppbmppZSA8cnVhbmppbmppZUBodWF3ZWkuY29tPg0KDQoNCk5pdDog bmVpdGhlciBzdWJqZWN0IG5vciBkZXNjcmlwdGlvbiBtZW50aW9ucyB3aGljaCBzdWJzeXN0ZW0g Y3VycmVudCANCnBhdGNoIHRhcmdldHMuDQoNCkkgd291bGQgYWRkICJ4ZW4tcGxhdGZvcm06IiBv ciAieGVuL3BsYXRmb3JtLXBjaToiIGF0IGxlYXN0Lg0KDQoNClJldmlld2VkLWJ5OiBPbGVrc2Fu ZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQoNClRoYW5rcy4N Cg0KPiAtLS0NCj4gICBkcml2ZXJzL3hlbi9wbGF0Zm9ybS1wY2kuYyB8IDcgKysrKystLQ0KPiAg IDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+DQo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9wbGF0Zm9ybS1wY2kuYyBiL2RyaXZlcnMveGVuL3BsYXRm b3JtLXBjaS5jDQo+IGluZGV4IDE4ZjBlZDhiMWY5My4uNmViZDgxOTMzOGVjIDEwMDY0NA0KPiAt LS0gYS9kcml2ZXJzL3hlbi9wbGF0Zm9ybS1wY2kuYw0KPiArKysgYi9kcml2ZXJzL3hlbi9wbGF0 Zm9ybS1wY2kuYw0KPiBAQCAtMTQ0LDcgKzE0NCw3IEBAIHN0YXRpYyBpbnQgcGxhdGZvcm1fcGNp X3Byb2JlKHN0cnVjdCBwY2lfZGV2ICpwZGV2LA0KPiAgIAkJaWYgKHJldCkgew0KPiAgIAkJCWRl dl93YXJuKCZwZGV2LT5kZXYsICJVbmFibGUgdG8gc2V0IHRoZSBldnRjaG4gY2FsbGJhY2sgIg0K PiAgIAkJCQkJICJlcnI9JWRcbiIsIHJldCk7DQo+IC0JCQlnb3RvIG91dDsNCj4gKwkJCWdvdG8g aXJxX291dDsNCj4gICAJCX0NCj4gICAJfQ0KPiAgIA0KPiBAQCAtMTUyLDEzICsxNTIsMTYgQEAg c3RhdGljIGludCBwbGF0Zm9ybV9wY2lfcHJvYmUoc3RydWN0IHBjaV9kZXYgKnBkZXYsDQo+ICAg CWdyYW50X2ZyYW1lcyA9IGFsbG9jX3hlbl9tbWlvKFBBR0VfU0laRSAqIG1heF9ucl9nZnJhbWVz KTsNCj4gICAJcmV0ID0gZ250dGFiX3NldHVwX2F1dG9feGxhdF9mcmFtZXMoZ3JhbnRfZnJhbWVz KTsNCj4gICAJaWYgKHJldCkNCj4gLQkJZ290byBvdXQ7DQo+ICsJCWdvdG8gaXJxX291dDsNCj4g ICAJcmV0ID0gZ250dGFiX2luaXQoKTsNCj4gICAJaWYgKHJldCkNCj4gICAJCWdvdG8gZ3JhbnRf b3V0Ow0KPiAgIAlyZXR1cm4gMDsNCj4gICBncmFudF9vdXQ6DQo+ICAgCWdudHRhYl9mcmVlX2F1 dG9feGxhdF9mcmFtZXMoKTsNCj4gK2lycV9vdXQ6DQo+ICsJaWYgKCF4ZW5faGF2ZV92ZWN0b3Jf Y2FsbGJhY2spDQo+ICsJCWZyZWVfaXJxKHBkZXYtPmlycSwgcGRldik7DQo+ICAgb3V0Og0KPiAg IAlwY2lfcmVsZWFzZV9yZWdpb24ocGRldiwgMCk7DQo+ICAgbWVtX291dDoNCg0KLS0gDQpSZWdh cmRzLA0KDQpPbGVrc2FuZHIgVHlzaGNoZW5rbw0K From xen-devel-bounces@lists.xenproject.org Mon Nov 14 10:55:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 10:55:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443263.697799 (Exim 4.92) (envelope-from ) id 1ouX7T-0007LO-SS; Mon, 14 Nov 2022 10:55:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443263.697799; Mon, 14 Nov 2022 10:55:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouX7T-0007LH-O9; Mon, 14 Nov 2022 10:55:15 +0000 Received: by outflank-mailman (input) for mailman id 443263; Mon, 14 Nov 2022 10:55:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouX7R-0007Kx-Rg for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 10:55:13 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2066.outbound.protection.outlook.com [40.107.21.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d0268237-640a-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 11:55:12 +0100 (CET) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AS1PR04MB9309.eurprd04.prod.outlook.com (2603:10a6:20b:4df::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Mon, 14 Nov 2022 10:55:11 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5%3]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 10:55:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0268237-640a-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TEt/uPzLIKdkVBat7FUApZ/jbril+zNw9+1fLw7PpZU5GZ+WCEo4CTLnxoXouHlkk5cqHgdLFxr0aU9uZPn1BDrHClF3CiCqyvODDd5SUUvFG69gVFuULvjb/KV8mlpMCEMlfMFmK3Re3jcZ4zcjnojqiyCf/+7ftkdaV9QLCL/uhJrvT7V07OdAZnsHlTvpZbGdqCn5Wg58rOC08nvLUJcgmxOAvA/HJ/UYBlTc+TRrwfeTbRQJx2iahLA61us9//aLrlTiiXBbY0jPnouGaSbs6R57Ln+YsU5IEvUyJSDwfu6DtIUMh6MgXCfzVWlXTCSj9OygIm/LbYZh/jM/XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A+l3sX5ll1BOtoYQOTgBV4AShXzgXANvr9yYhrIbgTY=; b=k4xx7YJRzvdxXxU9P8PuN+swvSVBdy+JPen0YWxJtDDyDbmKgB2o0nxj5WJUlAYhW4plLlisJm9l8CBlyE+Ii9ae+s7Vifc5l3tVAIS7DgL2EywF2FDzxIFntatlzz+s88qU9xizLznkT8xVUG4maMP30h2GPR0asfc6w+vGtH8IiVBVWh9J+0b7PXPqirp6EufWi85bO9ZBI11op7txl4qk7sdkdKKexPpsu8agpQhcnGtaGW6QSVFLzzvMwyfZG9wtvc8SselSz8bNOpbeHFzs+GJJn+bs4wJjyDTPjYSmQenvFRvpHYJT8D0/B9vkZVPaYY7dad26gM9Xx7MklQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A+l3sX5ll1BOtoYQOTgBV4AShXzgXANvr9yYhrIbgTY=; b=RncC5eOU5rVg6FlKLU/X5QxJBN77dhBEr+/whRltqPn6F2FQoXNb8cfxkHEVmrTCq3u1t9pX1WCDHRII2e4r94QaKEpmgt2nDlglFdO7cqFjNSzxXPWXOFWITqLGY7iDF0gt9As5trvf3vbret1Ucogsd9Z5gDTO3e24HrJolQLbnWoyYK8Farhj7+bASdsY1UNpSahGJSI5g0jsXqNrXZeI0zfKm7kL7F9a4bMDKNd3MwScFjbTevXJ5ug2JlnOE0eUkICj3N2BALG/ZgmLWZbVicy9P6/X8IvBzeDozwifg2EKR7CiJsx4SC8La0TMoFoh6lA90ZcTuQb5ovnHKQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 14 Nov 2022 11:55:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKALL too Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , "moderated list:XEN HYPERVISOR INTERFACE" , linux-kernel@vger.kernel.org References: <20221114103110.1519413-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20221114103110.1519413-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM5PR0202CA0013.eurprd02.prod.outlook.com (2603:10a6:203:69::23) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AS1PR04MB9309:EE_ X-MS-Office365-Filtering-Correlation-Id: 3502c171-6bf9-42af-43e0-08dac62eb36d X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nlr1Wx8GBsawTTmTW9iADzzBoyZiw8ScUb3iyGFbSmPEJBZcBbFrkaD2ZskdnqTB1MWk/L/EUowDezaZ08w7lQfyPAGnTR97YJi0ZRtyXICRlpNa/ZheccA1AmxdP84GZ+ge9Rumo79AN1fbV9ziGuboR5++Jld+TSIhj3OZYVrAGpZY7qD+LbsIgG8jYWaCxc6Ot7OJAbZ7jL1RVHxac3SpdD/RFz8FdmM8K4gE4GMGXKu8IB4ReFX68/rdEQko0xq77dOpWEkIvqyPErDmN8tvzc/w4G+Gs3E4Brp/LLK9BVeXemUkn8bOGHKNSksYJ1dbfCUj28nrJmqpq4v5LTbSGwYZDbbnFmtpzoqohA01IAq5NdczpxQELez/ZfwlmMZcMfd+ZBwJz/mmwbhKq64lWYnURxLnXQ60UQlC/yILV5CFe2PQv+nOVkiBcxPzXxQP98Ota1ptXL+LeBCfjKozeDkvZYZwGrDtG2EFYew224gPXTZgFpPp/xcrC40iBpe1bPM9dRQ2Lu8h+3t4krVGF6mHhXfueFU5ZU/di8tOKggbbKFjkC7sJ7w9s/gpDQK94l6NgTJPkAsMV6az1HhOyw5xTt9SQNzMyzj2b3XqiqE91WC4FbBiMAo5jOy/Vi+3n6VvuiIJaPzlFydgvEjMfjnW1vqKXB9WE4xhagVXNzGh11TIXQF4HSPY8R42XkqTJmQiaU5RASFBx5WTWWNHF13HcnAkUa86Y6TfN7b55/mWrD1vpDJWxyBxREWjY2DtotStu9REcOA9sujZ/paarY1fPBYp0p6EnNtm3nk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(39860400002)(396003)(136003)(346002)(451199015)(36756003)(2616005)(186003)(83380400001)(31696002)(86362001)(6486002)(478600001)(6512007)(6506007)(53546011)(38100700002)(41300700001)(26005)(5660300002)(2906002)(31686004)(4326008)(66556008)(66476007)(8676002)(66946007)(8936002)(4744005)(54906003)(316002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rk4xMmYxaENEU3p6MDVJMnN6d2ZQRm5Fb2ZhTUFCdDhidm92OS95ZG9BVVVH?= =?utf-8?B?V2E0ck1UditzdEhwY2JHSlphMDZUSGhDVmllTG5nankwQTVQZzQreHZ2V0F0?= =?utf-8?B?ek9zMVg3OWE2VitNdFBDVnBxWlNSTjRWUGxwUGNUYzY5TEZUNkJQUjlkclFJ?= =?utf-8?B?WkloZkpOV2JxTXlyV21KYUYxU3M1SnluVkpqN3AzL1EzbHUrVW56Mk5wdlF0?= =?utf-8?B?UW0zTStJdm1wOGUyd3krY2hUV29Ca0xhNFk0VW8zWEhCQ0pqRGZrOFlkbWVP?= =?utf-8?B?NkgrRldiMnNkN0J4ZGFEYmFoQk9wcXNWSlowQ0VTOHNmT3RNbnEvN3Y0UVJJ?= =?utf-8?B?SVZTUEtQVTZHK29HQlFFN2hoL1hVc3dOVDRqclRZdmovREtYeTJpdmVGYkxI?= =?utf-8?B?V3hTOUk1UTRQeVJZVCtSM0dZb1NXSjY3eDdZQ01oUHFQdXlabWZVMXo0RGJP?= =?utf-8?B?S2F4bU0waVpLT3lhM1hBVEVYRUFTUFlRNlBwWFJGRVNYclJHMmhpOTFydzJW?= =?utf-8?B?TGJ2SEVqOHEraWlNWEZMaWNQSjBrNWw0ZE4raWlOb1lFS1kvTCtjTlByTDJl?= =?utf-8?B?YVFKQTUzTlBRNE5xdm9tNjdVUVg3Q2hmWkF2UmNBMUwxZ0xEWEpWbVExSVpv?= =?utf-8?B?eTRqSjZTOUF5ditBdjNOazYxb2x3VlZaclpNaUt4Y0V3Qk9zUE5HRkRTcGly?= =?utf-8?B?RUt6N2JPNlNBZUEzU1cwOFQ5ZGVPSWRpSFRBRE9QOW9Id3M3SXVnV1RoZDcz?= =?utf-8?B?V3NsMG1ZN2pScHQ1RjBUbWlKMk45bFY3Z3VzRTQ4WW9oc3QxSENpWE4vVnpk?= =?utf-8?B?UmFTbXE1TG9BaTBYV292SmkzMjVwNS9KUnMvbkJYZFJxZG4vcWkzMzZ4QmUz?= =?utf-8?B?ZmRKUWsrSkhGdVdZM3Y2TXRTQ00rUnNHUUx5dTJhbDRhOSt0YXl3YitsSlVq?= =?utf-8?B?VXlUUFM1cmNRR3luQmR3S0hrU09TUXpOYmRyTzVJWTErSm5hY3pFYXNOV1o4?= =?utf-8?B?VERQNGNwY3hPa2w4aDg3OUJsR3o0MWdMRTlPR0VFQng3S1ZoRG91a1pEWTZG?= =?utf-8?B?L3NYRUVhZWpJbnBMMnNucm10MFp0S0xpaUdqcGJJZXRvY3RTdU1ZMVgvOWhU?= =?utf-8?B?ZmdaZStLSmJBUDk1TXhXeGlYUFpERFZyUjFpcjVONk1Od2FJSzA0RXo4bnFi?= =?utf-8?B?My9ia1k0S2VOdWZ5OWxmWjZ2dEVzb3RqWHp3ZXZIRFFZZFQ0TmsrTTZONG11?= =?utf-8?B?clpsSEdubUtVaHY4Vk13SzlXVFV5cDVsSDVuL2RIMGIvUXlqVzZWMWJiVHRX?= =?utf-8?B?NTRLNU5WL0o3TmMyV3p2MVQ0WlhWbW5QZmhVcW81UWFyOTNQSWdyYXBEZ1cr?= =?utf-8?B?Sk5qZWxLK25Ib05Qc3U4R0VtMjcyajdybTIzZWRwRHN0QzRnNnE1cVFRTnpo?= =?utf-8?B?Z3g4N2MvREgzUVJJL0xQd085OFZlNDVBbzFRMm9UL1RkYUM1dTlkblRVRjFU?= =?utf-8?B?bWVVdktVeEkrSnpSb3dmbStDdnVtRjJIQldZT3AzZUo3MS9tbmUzMEUwcmxp?= =?utf-8?B?VlEzUk5rUCt0OHF5SlV4L1FiRVpQQ3J5djNmUXpCNU9PSGZxcEpTdWhEREtr?= =?utf-8?B?YklzcnhySkw1cmoyZjNPZ0hGQ28wa3RIeVMyQ3RmVkhuMm5uUTBRZEpRSGJM?= =?utf-8?B?b3ZBRE5OOG56TzlRcGQ1ajY4NFk4VVRENEFGek5wTmwyc1BFWnNjQVFGNGRl?= =?utf-8?B?MjFWOGQxSXcxL2dNYk1mQ0lhbjNhbmlVNTZySk4xSnFaQjhkRnM4K2JiVnNM?= =?utf-8?B?TVZsaHBDa3ZLcE5oZUNWbi9HVlVQWEZEOXpTMFM5c1JEUmx4Qm14OERUN2VE?= =?utf-8?B?SmJOUm1WTFNFVzFZbkJNcDNJdmt3dnVJeEtxa2dRK1NocTNZSExQNjM1dHY1?= =?utf-8?B?cWd5S3FqZnBWVEdnWnlSby9BeUY0cFNqODZockFrT0UxbHJXK0l3anQwZ2p2?= =?utf-8?B?RS9OS3gzZUNST3RkRFZzbUN5MmliYlN6bUpHb0htTzljN0FhWkNNM3pQbmxQ?= =?utf-8?B?cnV6MHlOTlR3VWpmcEk2WUJncUY2RUtkNUVPNTJiaFd0NUEwOXNEdDhGRExl?= =?utf-8?Q?0QX8+eWMgygfodDIQ9aw8DTw5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3502c171-6bf9-42af-43e0-08dac62eb36d X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 10:55:10.9142 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mvDG+OiCzV7sjqgVkKx0dSOwnK96JyHcif9fHryrLDyqX0k5lcL2deqgeTRjex47fq/9FGBpFihSM0syrkxyXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9309 On 14.11.2022 11:31, Marek Marczykowski-Górecki wrote: > When Xen domain configures MSI-X, the usual approach is to enable MSI-X > together with masking all of them via the config space, then fill the > table and only then clear PCI_MSIX_FLAGS_MASKALL. Allow doing this via > QEMU running in a stub domain. > > Previously, when changing PCI_MSIX_FLAGS_MASKALL was not allowed, the > whole write was aborted, preventing change to the PCI_MSIX_FLAGS_ENABLE > bit too. > > Note the Xen hypervisor intercepts this write anyway, and may keep the > PCI_MSIX_FLAGS_MASKALL bit set if it wishes to. It will store the > guest-requested state and will apply it eventually. > > Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Nov 14 11:01:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 11:01:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443267.697809 (Exim 4.92) (envelope-from ) id 1ouXDL-0000VU-G3; Mon, 14 Nov 2022 11:01:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443267.697809; Mon, 14 Nov 2022 11:01:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouXDL-0000VN-DG; Mon, 14 Nov 2022 11:01:19 +0000 Received: by outflank-mailman (input) for mailman id 443267; Mon, 14 Nov 2022 11:01:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouXDK-0000VD-Vk; Mon, 14 Nov 2022 11:01:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouXDK-0002o7-SI; Mon, 14 Nov 2022 11:01:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouXDK-0003dw-2d; Mon, 14 Nov 2022 11:01:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouXDJ-0007D6-VB; Mon, 14 Nov 2022 11:01:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=y7WVCKnowe+Ia9qGiX3rxkehDeazSGPrSK0xLSgjyoo=; b=NQZtsAS13udL0heA9ykBbPbd+l K7OL6p9+ngSGe4ml4CX+JbW19F4alGAUhd+9W1cpJ0oIVfhKD+Yll24Dv7V/ARnKk8JAqk5yFJ+HO IGTdfo7ABWHVTJ1SEBsPAThG38DjkoLZ/fc2IStB9KCdWnu4+5jsCe9lKFwnhs+cAf8Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174762: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 X-Osstest-Versions-That: xen=17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 From: osstest service owner Date: Mon, 14 Nov 2022 11:01:17 +0000 flight 174762 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174762/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl 22 guest-start/debian.repeat fail in 174753 pass in 174762 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 174753 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 174753 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174753 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174753 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174753 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174753 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174753 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174753 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174753 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174753 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174753 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174753 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174753 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174753 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 baseline version: xen 17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 Last test of basis 174762 2022-11-14 01:52:18 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Nov 14 11:11:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 11:11:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443274.697821 (Exim 4.92) (envelope-from ) id 1ouXN9-0002AF-Hv; Mon, 14 Nov 2022 11:11:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443274.697821; Mon, 14 Nov 2022 11:11:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouXN9-0002A8-EY; Mon, 14 Nov 2022 11:11:27 +0000 Received: by outflank-mailman (input) for mailman id 443274; Mon, 14 Nov 2022 11:11:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouXN8-0002A2-QT for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 11:11:26 +0000 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 122ba2f9-640d-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 12:11:24 +0100 (CET) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4N9mnz1YN8zRpK3; Mon, 14 Nov 2022 19:11:03 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 14 Nov 2022 19:11:19 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 122ba2f9-640d-11ed-91b6-6bf2151ebd3b Message-ID: Date: Mon, 14 Nov 2022 19:11:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] xen: add missing free_irq() in error path To: Oleksandr Tyshchenko CC: "jgross@suse.com" , "sstabellini@kernel.org" , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" References: <20221114070702.1887144-1-ruanjinjie@huawei.com> <4b735f01-6028-d7dc-d715-8c56c790a8ad@epam.com> Content-Language: en-US From: Ruan Jinjie In-Reply-To: <4b735f01-6028-d7dc-d715-8c56c790a8ad@epam.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected On 2022/11/14 18:45, Oleksandr Tyshchenko wrote: > > On 14.11.22 09:07, ruanjinjie wrote: > > Hello > > >> free_irq() is missing in case of error, fix that. >> >> Signed-off-by: ruanjinjie > > > Nit: neither subject nor description mentions which subsystem current > patch targets. > > I would add "xen-platform:" or "xen/platform-pci:" at least. > Thank you very much! > > Reviewed-by: Oleksandr Tyshchenko > > Thanks. > >> --- >> drivers/xen/platform-pci.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c >> index 18f0ed8b1f93..6ebd819338ec 100644 >> --- a/drivers/xen/platform-pci.c >> +++ b/drivers/xen/platform-pci.c >> @@ -144,7 +144,7 @@ static int platform_pci_probe(struct pci_dev *pdev, >> if (ret) { >> dev_warn(&pdev->dev, "Unable to set the evtchn callback " >> "err=%d\n", ret); >> - goto out; >> + goto irq_out; >> } >> } >> >> @@ -152,13 +152,16 @@ static int platform_pci_probe(struct pci_dev *pdev, >> grant_frames = alloc_xen_mmio(PAGE_SIZE * max_nr_gframes); >> ret = gnttab_setup_auto_xlat_frames(grant_frames); >> if (ret) >> - goto out; >> + goto irq_out; >> ret = gnttab_init(); >> if (ret) >> goto grant_out; >> return 0; >> grant_out: >> gnttab_free_auto_xlat_frames(); >> +irq_out: >> + if (!xen_have_vector_callback) >> + free_irq(pdev->irq, pdev); >> out: >> pci_release_region(pdev, 0); >> mem_out: > From xen-devel-bounces@lists.xenproject.org Mon Nov 14 11:24:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 11:24:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443280.697832 (Exim 4.92) (envelope-from ) id 1ouXa1-0003ma-K8; Mon, 14 Nov 2022 11:24:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443280.697832; Mon, 14 Nov 2022 11:24:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouXa1-0003mT-HU; Mon, 14 Nov 2022 11:24:45 +0000 Received: by outflank-mailman (input) for mailman id 443280; Mon, 14 Nov 2022 11:24:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouXZz-0003mN-V5 for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 11:24:43 +0000 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed457ba5-640e-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 12:24:41 +0100 (CET) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4N9n224lmfzJnhv; Mon, 14 Nov 2022 19:21:30 +0800 (CST) Received: from huawei.com (10.67.175.83) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 14 Nov 2022 19:24:36 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed457ba5-640e-11ed-91b6-6bf2151ebd3b From: ruanjinjie To: , , , , CC: Subject: [PATCH v2] xen/platform-pci: add missing free_irq() in error path Date: Mon, 14 Nov 2022 19:21:24 +0800 Message-ID: <20221114112124.1965611-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.67.175.83] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected free_irq() is missing in case of error in platform_pci_probe(), fix that. Signed-off-by: ruanjinjie Reviewed-by: Oleksandr Tyshchenko --- v2: - improve the subject to describe which subsystem it targets. --- drivers/xen/platform-pci.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c index 18f0ed8b1f93..6ebd819338ec 100644 --- a/drivers/xen/platform-pci.c +++ b/drivers/xen/platform-pci.c @@ -144,7 +144,7 @@ static int platform_pci_probe(struct pci_dev *pdev, if (ret) { dev_warn(&pdev->dev, "Unable to set the evtchn callback " "err=%d\n", ret); - goto out; + goto irq_out; } } @@ -152,13 +152,16 @@ static int platform_pci_probe(struct pci_dev *pdev, grant_frames = alloc_xen_mmio(PAGE_SIZE * max_nr_gframes); ret = gnttab_setup_auto_xlat_frames(grant_frames); if (ret) - goto out; + goto irq_out; ret = gnttab_init(); if (ret) goto grant_out; return 0; grant_out: gnttab_free_auto_xlat_frames(); +irq_out: + if (!xen_have_vector_callback) + free_irq(pdev->irq, pdev); out: pci_release_region(pdev, 0); mem_out: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 11:44:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 11:44:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443323.697864 (Exim 4.92) (envelope-from ) id 1ouXtC-0006mG-ER; Mon, 14 Nov 2022 11:44:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443323.697864; Mon, 14 Nov 2022 11:44:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouXtC-0006m9-9l; Mon, 14 Nov 2022 11:44:34 +0000 Received: by outflank-mailman (input) for mailman id 443323; Mon, 14 Nov 2022 11:44:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouXtB-0006m3-15 for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 11:44:33 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b40ad893-6411-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 12:44:31 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E97ACB80E78; Mon, 14 Nov 2022 11:44:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB5DEC43145; Mon, 14 Nov 2022 11:44:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b40ad893-6411-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668426270; bh=wui7Joclil/1Zhbm3X8SG6joq+UGvmdb9Y11/m4UBYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oDcoRSsaEpF5qFmILR9P2mJ5a8lkQVqMz+gUsBuNicjhyBffTPM5tdA/mPGhAiGic b5Wgy7NrKtO74lPiJPFz39XuitjuukIBpJcWmqcaBGCVEmSV9ucqUPWl6gUdl9BQXX a+Ju58arWUNE9xg75AuU4gCyovLx/ItgDUgsr1wBwfbwhZkJPO/4/TJI+qMf2UmfoR QlFdhFWt8ofWnNOWLzvO8u0t1IFU0YF853oowuhb98g1SDgmNnnzJ48rj2v1CL7+R8 AWDAd2XOz2ooKCMSPSbZwiKQ8kngNUK18qlmx+FMIcPKRaS9JrURlWmTDeKaFml2Z4 5lHZGRLILvEUA== From: "Jiri Slaby (SUSE)" To: linux-kernel@vger.kernel.org Cc: Andi Kleen , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, Martin Liska , Jiri Slaby Subject: [PATCH 15/46] x86/xen, lto: Mark xen_vcpu_stolen() as __visible Date: Mon, 14 Nov 2022 12:43:13 +0100 Message-Id: <20221114114344.18650-16-jirislaby@kernel.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221114114344.18650-1-jirislaby@kernel.org> References: <20221114114344.18650-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Andi Kleen Symbols referenced from assembler (either directly or e.f. from DEFINE_STATIC_KEY()) need to be global and visible in gcc LTO because they could end up in a different object file than the assembler. This can lead to linker errors without this patch. So mark xen_vcpu_stolen() as __visible. Cc: Juergen Gross Cc: Stefano Stabellini Cc: Oleksandr Tyshchenko Cc: Signed-off-by: Andi Kleen Signed-off-by: Martin Liska Signed-off-by: Jiri Slaby --- drivers/xen/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/time.c b/drivers/xen/time.c index 152dd33bb223..006a04592c8f 100644 --- a/drivers/xen/time.c +++ b/drivers/xen/time.c @@ -145,7 +145,7 @@ void xen_get_runstate_snapshot(struct vcpu_runstate_info *res) } /* return true when a vcpu could run but has no real cpu to run on */ -bool xen_vcpu_stolen(int vcpu) +__visible bool xen_vcpu_stolen(int vcpu) { return per_cpu(xen_runstate, vcpu).state == RUNSTATE_runnable; } -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 12:21:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 12:21:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443343.697874 (Exim 4.92) (envelope-from ) id 1ouYSs-0003Da-Vc; Mon, 14 Nov 2022 12:21:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443343.697874; Mon, 14 Nov 2022 12:21:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouYSs-0003DT-Ry; Mon, 14 Nov 2022 12:21:26 +0000 Received: by outflank-mailman (input) for mailman id 443343; Mon, 14 Nov 2022 12:21:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouYSr-0003DN-HL for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 12:21:25 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d9b02794-6416-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 13:21:23 +0100 (CET) Received: from mail-dm6nam10lp2100.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Nov 2022 07:21:16 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BL1PR03MB6118.namprd03.prod.outlook.com (2603:10b6:208:31c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 12:21:14 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Mon, 14 Nov 2022 12:21:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9b02794-6416-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668428483; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=lBXnySvigQeqW+ZDw01qKtbs/eKRULhXbeuejXvQDEA=; b=JuJkvHyohtrQ/f5i9dRvjnm0H8mbNl5fmH1EOwxk4ANoMK/15nAlVwBr a/h7xXkK43iY760aq86lhojSRBEUgT0iFy5ByzvsWYdvi93TgLz00UFZT 5bYWl+PMW8iU8rwUgiMEpnFM/Gb1AQXvSWKgEDKss+i4oIZZJpr/5ISXj 8=; X-IronPort-RemoteIP: 104.47.58.100 X-IronPort-MID: 83829768 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:eRtrRa0DsfT2G4GhxPbD5SRwkn2cJEfYwER7XKvMYLTBsI5bp2cPm mUeXW7QaKnYN2emedhzbYWz9EwF78OBm4cxSgVkpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVnOagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfGGht+ /wbLAo2Uk673euT5fWUVeRVmZF2RCXrFNt3VnBI6xj8VK5jbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6KlFQZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r83b+VzHylCOr+EpWJ8PEyuRqpmVc/SzcwZWqk4ubohA2xDoc3x 0s8v3BGQbIJ3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsbjNHcs1gi8YwShQjz FrPlNTsbRR3uaCRYWKQ8PGTtzzaETcRBX8PY2kDVwRty9vprZw3jxnPZs1+C6PzhdrwcRny3 jbMqiE9jrcSiMcj1qOn8FSBiDWpzrDKQxA04EPLX2ujxgJ/eIOhIYev7DDmAe1oKY+YShyNu SYCks3HtOQWV8jVzGqKXfkHG6yv67CdKjrAjFVzHp4nsTOw53qkeoMW6zZ7TKt0Dvs5lfbSS Be7kWtsCFV7ZRNGsYcfj1qNNvkX IronPort-HdrOrdr: A9a23:00jV0652qNBYKYKXUgPXwa+CI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A37gZJPh8sH7eGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu1Lh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboXwTwk6n7WXdrWrooMT/Sj5/I81dhbhBeh+cz0Y7ptlz3I 9Cwmrc7vNsfFj9tRW4w+KNewBhl0Kyr3ZnuekPj0ZHWY9bTLNKt4QQ8G5cDZ9FNiPn74IMFv VoEajnlb5rWGLfS0qcknhkwdSqUHh2NhCaQnIassjQ6DRSlGAR9Tpt+OUv2lM7sL4tQZhN4O rJdo5ykqtVc8MQZaVhQM8cXMqeEAX2MFPxGVPXBW6iOLAMOnrLpZKyyq4y/vuWdJsBy4Z3sI jdUWlfqXU5dyvVeIOzNaVwg1PwqViGLHbQIpk03ek9hlS8fsulDcS7ciFvryP6yM9vRvEyWJ 6ISedr6rHYXCzT8L1yrn3DsqlpWAcjufIuy6cGsnK107X2w97Rx5rmWceWAobROhAZfU66Kk c/fVHIVbd9BwaQKzPFvCQ= X-IronPort-AV: E=Sophos;i="5.96,161,1665460800"; d="scan'208";a="83829768" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jiq5zdj9TXMp5mQGFuOAbY4VTu0hQE8Xc0XAENwJZxpXaXEXdlIGI16KfGFBrp8DMjvvNLN3EmTjaxKdAlIkEjOZSUOC04miBakMt/2Q5eVIoWe6msViO/p+hKAMF4kTx0wJRAxTz80bfcAfiIiLQwsKkHW1khT5qq6Iem6P8O/6GZ480Fr0JVYwSg8xODBjUbs9NTrqBf/Z+llk5bqzfOiryvQHAuxhgKZb+jPbtdysIw6Ab9qPgTKZcjr/SbPQ5G2hpRzfvzXr4ysrpt0tEaoHtbL9NoslwF8STvPHI+9/im3YRW7a+8YtzAe4u8EvB1Xz9GWFSZPjupMDPW8glA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tNTcsBiFZbrLh133XwDwMIdoXwDbriQt8eK9G94FhYo=; b=G6qEqDcGWD1QE/BIyw0+EiGa1cyqVZL7Yk03DeqR4XRs0L1v2jLirm1VO9ve9aia/e455fEpBefSZ6eHgPbEYVo22D4kZxdhSHs1f7nSrgV3Uzs5jG+HYxxFCnsVv+kEwvDmtQgvIaip+7GJJoFMJzw7Kgzz741fwLf05iql0RNprt2D9cLPrAeEivLOZSbf/KxdyzocZcM4sOzDGAtQsh+cZKSia0En75ta2kR5iFraNKLfeEx1L6Zr204qSFqRlrYhLgqcFrLSscqbbwG+DlDAIEXG8dtg85jeIAMBAvTb99f2UNDmtGxxdzxsGNOET78ZlMx9yCGKASsMyFR++A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tNTcsBiFZbrLh133XwDwMIdoXwDbriQt8eK9G94FhYo=; b=sc34zIBgjJtEmfhKfsWpQ23NLmjNXFATmQfYwGqtJ1p7zSETy52ycdLMrxBf66nr19pvKuGd/dL1qpwBX+ifSN84NR8VaKquLt/U65uBeKswdI8q3OG9XLIGdvcEbO9P816p0s7RYPYCjaOglOKdjwWEbodgiSoMnsfwl5ceDeo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 14 Nov 2022 13:21:08 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , "Henry.Wang@arm.com" , Paul Durrant , Wei Liu , Jan Beulich , Jun Nakajima , Kevin Tian Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Message-ID: References: <20221104161815.38007-1-roger.pau@citrix.com> <69841767-ccc4-5eeb-6e9c-d59dfb197ea5@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <69841767-ccc4-5eeb-6e9c-d59dfb197ea5@citrix.com> X-ClientProxiedBy: LO4P123CA0606.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::14) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB6118:EE_ X-MS-Office365-Filtering-Correlation-Id: f640fa84-07b2-4962-f403-08dac63ab8e2 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WYdSwBj3jmsnBHyrtTLBH9RixqQ0vqVLr66zEockPFmtMhLflrbYzR6CQJKFBYCmxm1KIfDEkwB7pfMHBYjrdDRieT6Ws8ZJI90FDL0uY3eKXyCjHIbSKrTqTTrZaoJv4ts+hCY3MXuFbcxbGL/ri2SRywJeCkR+BNySFLgOrMvc324JAjknoO8uW0McypvrdqFcw0njgfzjtabW/vb7/N75XwBhafeEbB1WrbH6ja+dGC0xgKtbaEaffwHve2zwT8MRVc8/iESstmxjABeIIrjdIedVO5APAp9Kp2tQxxNxzZG+1a5KObta92YYFGceNr0rFfs8i7gYij++L7WmFKmZpjUDt3AJE/fn7y05RLRtMnbdryvKwlgMbSPJ9jnCI4bPQi3Pj3DD6nY2AGzX2tuDfmo+5QrE1SJxIEgAgMa8FC1wLgIzK58UmL8erACvFE6k/yP5FoQBiZVQXgDDKxoGhKaP/nRYV7rnRtoJDPAE8oCDB5u5lXo3OVPUAh9FAIrwz8knsAk0Jj52fjUOW9+u7tHAtfEfz709khbYKIJCxnOziq7MvTibgPcex/ETcueFxNrU782TRvhMjdahmqXKDGHvk4OiPVQNW/b0Su0VkCcP+DyfQE2zDRW9lb/XxBuL/wq5oZVNzq/rq0gmuiKHrWySkRU/avzcRnhTOxXquMQpuiAQUojcR7/CKlx+mqtzb1ugac/cdwfxb33qkg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(346002)(39860400002)(366004)(396003)(376002)(451199015)(41300700001)(26005)(2906002)(6666004)(6506007)(54906003)(86362001)(186003)(6636002)(6512007)(478600001)(6486002)(4326008)(316002)(5660300002)(8936002)(6862004)(38100700002)(83380400001)(66946007)(66556008)(66476007)(82960400001)(8676002)(9686003)(85182001)(53546011)(33716001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amJ1Q3ZnY3NRZDdWUk9SelkyUktPa2N0TGoyZDYvQzV0d0Q5emlFQzVYTVc4?= =?utf-8?B?bW1VVnJmU05oMzhkbyt1RXdkNXoxM1lHbGlDakJXbGFnSUFhVTNxQVNMWkta?= =?utf-8?B?bUppUXdpMWlyd2V6N3FYUzF0S1hDaDR0RHFkekgrSFZmYks1YjN6ak9nOEU2?= =?utf-8?B?U2xsR2d2bUlLTmUycVBEQVRJY1NJUVlvZEM5alg1dEZRUWJzMTZGYTBPUkdF?= =?utf-8?B?NExET01HTkhZUnl3bnhtS2paRGF3QmRUa3ZhRGZvSkdYK2dEYVg3R2dENUFF?= =?utf-8?B?eEs2dlJkRm4zYVU3dHNORVVtQ1pLZXIralptODJJSGtlamkzSEMzaEhPc1d6?= =?utf-8?B?dDVIY0V3RzJzTG9SOHBjV3lmY2MyaGxYa3VNUjhaK0phOGVjaHU5QU1kNG5F?= =?utf-8?B?QWl2VWxMWEthQWxOUmFlamVMZUFuRHQvbHVMaGdnRkQ3OXJ6cmRETFJWMTM2?= =?utf-8?B?WTd0LzNRZkpMMndDMC8xK1VqamZSWExkTjJuQnREUkRjQU51OTdGQnhEdEow?= =?utf-8?B?MzZoZ1M2dnBJRzYyd3dqTGZuWXFHN3h1QU1JZmQyS1hCZk1NdXVkN3BBUTFK?= =?utf-8?B?ZWIyWG1kUTFTTTZTMTRaaVBEYkRsdHA3ZC9yL3ZlbU9qUGMzWHBMdGpzbjBt?= =?utf-8?B?MlRzWjMxaHU5ZDdkNGpubHh5ZjJkbm9PRFlIdHNYWU9CbDhIWHVNckl1dWVv?= =?utf-8?B?a1NENDF0VW9WeWt0c3RNa040K1ZINFpSTW41eHNweEJ5aDRyVDlLeW84dWlD?= =?utf-8?B?czBodWYxN1gxNVduWEhkay92dHhIZXRKL3N6N1N4YWpFVGk1a1hSUmMzOHZ3?= =?utf-8?B?SW43RlFDL3VybkdyZGJYMDlQdXlJRWMxM1FSK2VTZE1pbkFaL0JUOVN5K3lL?= =?utf-8?B?RENUNm9YM3lTT1J6VnNmVzlDSGpHeUV1d3RwNWh6UTRwOWpwUVVIMURZcFRX?= =?utf-8?B?UnFQVHo5TEVWb0JsOE5UcmYya1BnSWdYeXlyMzlZL21QWmd0NTV0VWFTcG9s?= =?utf-8?B?MkZGVE4vdU1DMU85L2JDOE8vT1JIdGo3ZGE0TTVLM0FFY3RXVlBIOGwwWm1C?= =?utf-8?B?WnFkTFczSnFWcm1UQkg5cStnc2hUUmpLMm50dytYQlJibU44Z2xmejE5Qzh0?= =?utf-8?B?UTVZNEZmaGpwc29DUHVBdjIwbTYydXRoTk9WZDVNY3QrN2VnUDgwS3UvNTli?= =?utf-8?B?ZTZOZE5NS2ZwNXY4d2ZSblNJM1RJZlpoSW1sZVdFOGM4MlhoZWZaUUgxMEhL?= =?utf-8?B?YUJBSzdWYVdpK09NWDJZVDJsVy9teWo0dng2ZERtbVBUZFkwaXQ3eWYwaFox?= =?utf-8?B?K05QdUF2aFJQMTluTDJSeHc2bStMZFRTcStRaWVTVFRweXQydXI1Zm5GaW1t?= =?utf-8?B?OXhIekxXUERNMWNBaFFBbEVWcElVaWhuNGtXd3VLTGgwbmIyMXlmMHN0dllk?= =?utf-8?B?OWhJbkdrKzJ5VDIrVWUySHpVV1VsWWJuS282N1NwbklhbGd2UkhpZkdYY1Mr?= =?utf-8?B?NEZ1eUlOTzJxdGFEZG8xNUFXcEFQWkMxRWZNVXR4RjE1M1pUL2l4SjZlckJs?= =?utf-8?B?Q3l6ZjVYd3BYV3hoZVRvSmFYYXd6Z1oxRWl5cnUrMmZFQmplSXh1MXZwSlVX?= =?utf-8?B?UEY0Ly9rL09vaEZBOGpLSHpYT29Ec3dxeUdodmRDSWNiQjdNeE1jZUVwS3Fz?= =?utf-8?B?Tll2Y29BdEdEdFJrNUVpRDNQVjl1dEs2dHY2YTVxTitlbXhEekdUSndJSmR6?= =?utf-8?B?NVB1Tkg0UU5ybWJEL3BYakROWjVLTEJ5MURoZHJmYmpGNS94bDlRL1gwbTdL?= =?utf-8?B?Zlp3TVlQTnkya2JBUXZsaGRlLzBnSmhobU1ZVFJsM3lGRlBZMmk5TmYvanEz?= =?utf-8?B?NkwrTENFQUZvUFFwdnR4d2x0cWFvWng3bzd2cytLdXBXUHI1RTAwUUZSZFhJ?= =?utf-8?B?blF1NEtVdDRWWUJMTG91YmxMN2NEVjJ0ck1xRGJxSTNHZXVTK21MZzJjMlhC?= =?utf-8?B?NjdKOXFIMEdqUkxjb21xRHJJZ1VTNFJYeEVJeGMrUW53VUk4MFdJWHE1NE1S?= =?utf-8?B?YzhodGtvL3ZEWnRGUGtUWTZvWjkvdklLdEsrVnpwWjRET2U4UHNIQkRnVzgx?= =?utf-8?Q?TU1Q1QUyQTxBC9oMObpel8Pvc?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: X+5oCyDV+fmsytNy1/JIcV169SxzgW0yWMoJ5y+CueFN0nmxvyE/6QYFTkrJLgHiuNS066baT42uC7k51WJ82MOSAq8EVUKKxVdyi+0cZ7DY5MkedU2T8/jFuDjdDD8N52ilvwasaFHKrsfQ9rNpsok2Ounl9oUBYxMd2x24i0mlyxE0PQb3gCsBo/kAV2TzDHwXfZDvZDOfmDiX1BmCd6bhznPsXf/2MiVqsMRVKNBimULuWhwK8bf9l9NxU8d+fqEeGnANKrLgnaWNJKY0x3pevnN3KAVGx3k4u1VVz9Z3Cpqx81lS0BglHSp+wvjjYbvlOD0Wjd2j0xFV6sfMZH4v02K5Qr//4UuC1J0PejjqAwcYQQAXWIvgeGKuf/VXZfZItzPwTmd6Tzd2d0tQ5PAV0VAdHaYlN+zdKEkL8r3B+l4sGuzCIrmaANRbZzuBi2lkBrz9gxxXzpeto86K8JVIY9kxsZ+BePcQXFw53ZRyNpF0/Mo7CiNeB6BFFX0lH6hzzogzp0sG8gLkTLmqXRJVwBxBncI0jmCRsmSalCdIxUfYtxCc/69JQ7xXhbob6gapV1pUGLeM8YesIKkGusLs8Z7ZfJlXy+Ap961iDjV6oCw5wc0FlcEhHDtamy12/xRFHWwc7AE51KPUEXP2BsYinLyMBp+sjGmxmnx+TuiOGgJdVVnJax0bf9r8H2kXD/QzuMwI1nwHl3Ki+iU+ub/HnRDDwBbr4HmtloP7k/z079KreNJhDif3M4VcWypBT3h/FIXeCp3iy7XRI4mm3vda9cecsm40/lmPvrQz8mGeioQYptU+OfuDaYfPH4/JZ6wST+IehtOn0A6zRo/QVUH8vfObvwW7/z1pulr8umhfnMYImfkBtNsgIy0XhGB/ApTBw7YC9EAja9jdwWL41O96E3L36HyfC6mc1bKBVDs= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f640fa84-07b2-4962-f403-08dac63ab8e2 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 12:21:14.2238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PiFUUADt2et8yAmICqwVEh/6r7mA6Z/uX6++/LDsIvF55c3eIdEwqX05JwRZ8/hhjT6Q5Z1DTSFvwW28kNbJ4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6118 On Thu, Nov 10, 2022 at 10:47:07PM +0000, Andrew Cooper wrote: > On 04/11/2022 16:18, Roger Pau Monne wrote: > > The current reporting of the hardware assisted APIC options is done by > > checking "virtualize APIC accesses" which is not very helpful, as that > > feature doesn't avoid a vmexit, instead it does provide some help in > > order to detect APIC MMIO accesses in vmexit processing. > > > > Repurpose the current reporting of xAPIC assistance to instead report > > such feature as present when there's support for "TPR shadow" and > > "APIC register virtualization" because in that case some xAPIC MMIO > > register accesses are handled directly by the hardware, without > > requiring a vmexit. > > > > For symetry also change assisted x2APIC reporting to require > > "virtualize x2APIC mode" and "APIC register virtualization", dropping > > the option to also be reported when "virtual interrupt delivery" is > > available. Presence of the "virtual interrupt delivery" feature will > > be reported using a different option. > > > > Fixes: 2ce11ce249 ('x86/HVM: allow per-domain usage of hardware virtualized APIC') > > Signed-off-by: Roger Pau Monné > > --- > > I find the logic in vmx_vlapic_msr_changed() hard to follow, but I > > don't want to rewrite the function logic at this point. > > --- > > Changes since v1: > > - Fix Viridian MSR tip conditions. > > --- > > xen/arch/x86/hvm/viridian/viridian.c | 2 +- > > xen/arch/x86/hvm/vmx/vmcs.c | 8 ++++---- > > xen/arch/x86/hvm/vmx/vmx.c | 25 ++++++++++++++++++------- > > xen/arch/x86/traps.c | 4 +--- > > 4 files changed, 24 insertions(+), 15 deletions(-) > > > > diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c > > index 25dca93e8b..44eb3d0519 100644 > > --- a/xen/arch/x86/hvm/viridian/viridian.c > > +++ b/xen/arch/x86/hvm/viridian/viridian.c > > @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, > > res->a = CPUID4A_RELAX_TIMER_INT; > > if ( viridian_feature_mask(d) & HVMPV_hcall_remote_tlb_flush ) > > res->a |= CPUID4A_HCALL_REMOTE_TLB_FLUSH; > > - if ( !cpu_has_vmx_apic_reg_virt ) > > + if ( !has_assisted_xapic(d) ) > > res->a |= CPUID4A_MSR_BASED_APIC; > > This check is broken before and after.  It needs to be keyed on > virtualised interrupt delivery, not register acceleration. > > But doing this correctly needs a per-domain vintr setting, which we > don't have yet. > > It is marginally less broken with this change, than without, but that's > not saying much. I took a look at the HyperV TLFS spec but the table that lists the CPUID bits don't explicitly name which registers are accessed using MSRs rather than MMIO when the 'MSR_BASED_APIC' suggestion is set on CPUID. It's my understanding that the hint is not useful anymore, as Xen exposes x2APIC by default, and that's what any new-ish version of Windows should use, in which case all APIC registers are already accessed using MSRs and the hint is moot. > > if ( viridian_feature_mask(d) & HVMPV_hcall_ipi ) > > res->a |= CPUID4A_SYNTHETIC_CLUSTER_IPI; > > diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c > > index a1aca1ec04..7bb96e1a8e 100644 > > --- a/xen/arch/x86/hvm/vmx/vmcs.c > > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > > @@ -1136,7 +1136,7 @@ static int construct_vmcs(struct vcpu *v) > > > > if ( !has_assisted_xapic(d) ) > > v->arch.hvm.vmx.secondary_exec_control &= > > - ~SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; > > + ~SECONDARY_EXEC_APIC_REGISTER_VIRT; > > > > if ( cpu_has_vmx_secondary_exec_control ) > > __vmwrite(SECONDARY_VM_EXEC_CONTROL, > > @@ -2156,10 +2156,10 @@ int __init vmx_vmcs_init(void) > > if ( !ret ) > > { > > /* Check whether hardware supports accelerated xapic and x2apic. */ > > - assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses; > > + assisted_xapic_available = cpu_has_vmx_tpr_shadow && > > + cpu_has_vmx_apic_reg_virt; > > assisted_x2apic_available = cpu_has_vmx_virtualize_x2apic_mode && > > - (cpu_has_vmx_apic_reg_virt || > > - cpu_has_vmx_virtual_intr_delivery); > > + cpu_has_vmx_apic_reg_virt; > > apic reg virt already depends on tpr shadow, so that part of the > condition is redundant. > > virtualise x2apic mode and apic reg virt aren't dependent, but they do > only ever appear together in hardware. I would keep those as-is for sanity, it's easier to spot the dependencies between them. And then it's also possible that we want to introduce a control for tpr_shadow, and which point having the conditional here is a good reminder that virtualize_apic_accesses depends on that feature being available and enabled. > Keeping the conditionals might be ok to combat a bad outer hypervisor, > but ... > > > register_keyhandler('v', vmcs_dump, "dump VT-x VMCSs", 1); > > } > > > > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > > index e624b415c9..bf0fe3355c 100644 > > --- a/xen/arch/x86/hvm/vmx/vmx.c > > +++ b/xen/arch/x86/hvm/vmx/vmx.c > > @@ -3405,25 +3405,29 @@ static void vmx_install_vlapic_mapping(struct vcpu *v) > > > > void vmx_vlapic_msr_changed(struct vcpu *v) > > { > > + bool virtualize_x2apic_mode = has_assisted_x2apic(v->domain) || > > + (cpu_has_vmx_virtualize_x2apic_mode && > > + cpu_has_vmx_virtual_intr_delivery); > > ... this is still wrong, and ... > > > struct vlapic *vlapic = vcpu_vlapic(v); > > unsigned int msr; > > > > - if ( !has_assisted_xapic(v->domain) && > > - !has_assisted_x2apic(v->domain) ) > > + if ( !cpu_has_vmx_virtualize_apic_accesses && > > + !virtualize_x2apic_mode ) > > return; > > ... this surely cannot be right. It's indeed missing a has_assisted_xapic(v->domain), so it should be: if ( !cpu_has_vmx_virtualize_apic_accesses && !has_assisted_xapic(v->domain) && !virtualize_x2apic_mode ) return; Logic in this function is not the best one IMO, as I've already mentioned in a post-commit remark. > > While attempting to figure ^ out, I've found yet another regression vs > 4.16.  Because virt intr delivery is set in the execution controls > system-wide and not controlled per domain, we'll take a vmentry failure > on SKX/CLX/ICX when trying to build an HVM domain without xAPIC > acceleration. I've tried creating the following guest on one of our Ice Lake boxes (with and without this patch applied): type="pvh" name = "test" memory = 1024 vcpus = 1 kernel = "/root/vmlinuz-6.1.0-rc4+" extra = "console=hvc0" assisted_xapic=0 And it seem s to boot just fine, no vmentry failure. > This, combined with the ABI errors (/misfeatures) that we really don't > want to escape into the world but I haven't finished fixing yet, means > that the only appropriate course of action is to revert. Hm, I'm confused by this, as it is still not clear to me what's wrong with the ABI. Is it the way in which we expose the flags? Or is it the naming? AFAIK we want to have a flag to toggle apic_reg_virt, which is the proposal here. Should it be named differently? > I'd really hoped to avoid a full revert, but we've run out of time. I've also hoped so. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Nov 14 12:31:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 12:31:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443347.697885 (Exim 4.92) (envelope-from ) id 1ouYcX-0004p6-Rx; Mon, 14 Nov 2022 12:31:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443347.697885; Mon, 14 Nov 2022 12:31:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouYcX-0004oz-Op; Mon, 14 Nov 2022 12:31:25 +0000 Received: by outflank-mailman (input) for mailman id 443347; Mon, 14 Nov 2022 12:31:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouYcW-0004ot-1S for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 12:31:24 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7e1a::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3e43976a-6418-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 13:31:20 +0100 (CET) Received: from DB6PR0402CA0021.eurprd04.prod.outlook.com (2603:10a6:4:91::31) by AS2PR08MB9197.eurprd08.prod.outlook.com (2603:10a6:20b:57b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.5; Mon, 14 Nov 2022 12:31:04 +0000 Received: from DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:91:cafe::dc) by DB6PR0402CA0021.outlook.office365.com (2603:10a6:4:91::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Mon, 14 Nov 2022 12:31:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT048.mail.protection.outlook.com (100.127.142.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 12:31:03 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Mon, 14 Nov 2022 12:31:03 +0000 Received: from 80f396de32e6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4B25B06A-F45E-4933-A71B-A23039685AE3.1; Mon, 14 Nov 2022 12:30:57 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 80f396de32e6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 12:30:57 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by GV1PR08MB8570.eurprd08.prod.outlook.com (2603:10a6:150:82::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.5; Mon, 14 Nov 2022 12:30:39 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::a504:d47b:217:4893%4]) with mapi id 15.20.5834.006; Mon, 14 Nov 2022 12:30:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e43976a-6418-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zeiOHxSl/qaF1n6/NrvSK1g2pa8UvUf2Okn9OHZqDRU=; b=xCl67g5niQbE/GCX1BsqSRBy9A7FegHmrIj3IsbKa9TeS561P/fIRIppXJe0c/MtAukDURM16ytmncMhEnBij+MZBC3KYShuHwkAHJ1Kfr/39YRytlIVwIYq8WawNeCTAUBi+WgC7qOTSFDQYhdBYGLR23hMMo156xJfy/iBO1w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f87d98c07e9fff2b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nSzHYgQeqTU5D2/qpxGeU2gJPJy+lTOcvYIdt9z+tyGRBIAPWWsnGyr2Oc32Eg0luQQ1DAL5EtgpI093CmhaE2+G9XvORmfeQXzVtzMjSlyuhF9wUtXymtEXb6zrKNN1DxHzdptRRxuXswkN5xlEiivls4LkWcMtFFatD2u5f01v+96U1zmA8139U2fUDqG7pmHp51Cf3s0CV6pkI3zDnevGLPwwArUG6javrDu9nJDQO2XKobu5/Hptsmo7qlqcj1+0njwyS4gG9XtJe4XED8CWWZHvYM5wzXuSepPt659DkSgcSuB249DfdULxqIE2/y5Eg3iYlxtaD/FY/ispog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zeiOHxSl/qaF1n6/NrvSK1g2pa8UvUf2Okn9OHZqDRU=; b=fA8PWGCJbF7WuRZ/0wkIoT3hVP7xJ3HcpFuEJ5Cf4QaXmUodZzT1gCV7JJofcEKzyVHISOKyeeeHAN3DG4YRp4k3k8hT0rHNRqTFlRnyPmCIH6cFY1xGvXTkM3Uyg8yPrKrAAqSSJYebDpXZWHOfBePyWMxnRxZour0goAPyS8K2bZkNUBOnGuitRABD12w8XVylFF+4V/a5MVRvYR7eUtRtRovtHlfjvStRMKn92ZLuHl/swJFIhvF/fvGJMWhbdmIWq+yRSlMsnaRkye+FFn5aexZPT5ZiSDO1eh3Pr8C9zxIdn99fMS9R1Z4VjtdKGCbbt5tMXQASMBT5sRy7MQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zeiOHxSl/qaF1n6/NrvSK1g2pa8UvUf2Okn9OHZqDRU=; b=xCl67g5niQbE/GCX1BsqSRBy9A7FegHmrIj3IsbKa9TeS561P/fIRIppXJe0c/MtAukDURM16ytmncMhEnBij+MZBC3KYShuHwkAHJ1Kfr/39YRytlIVwIYq8WawNeCTAUBi+WgC7qOTSFDQYhdBYGLR23hMMo156xJfy/iBO1w= From: Luca Fancellu To: Jan Beulich CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , "xen-devel@lists.xenproject.org" , Anthony Perard Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Thread-Topic: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Thread-Index: AQHY8pZ008DS0BACDkyhs+OWN8Oan64zqLWAgAE0WoCAAA3SgIAAJOMAgAAeVoCAABeCgIABAHkAgAAbOoCAAAfgAIADJhyAgAApmwCAAID8gIAD1tqAgABT5AA= Date: Mon, 14 Nov 2022 12:30:39 +0000 Message-ID: <282F1A51-D143-4F23-BEF6-43648505E7D9@arm.com> References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> <7d56c33d-4b03-9aa1-6abc-45a8ad41caca@suse.com> <2E0BFEFC-5BEE-4F8B-BD9E-94CB9A5B2BC9@arm.com> <9CE2A214-2D64-4BEC-A78B-393BF7AEDD9D@arm.com> <826eb0df-fb52-fa25-c908-977285a6ec8b@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB3809:EE_|GV1PR08MB8570:EE_|DBAEUR03FT048:EE_|AS2PR08MB9197:EE_ X-MS-Office365-Filtering-Correlation-Id: 687fd5fb-8709-45b3-d93d-08dac63c1896 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: T1VnlGLe9CyllnWp09DfUyS/PaXAkbvx1mq0W2uVgESmwG0nwfMd1WR/S/7TP65sFjjEuZ3gW7FNHDGMHYRDBlxC+LrzjdNQEiUQJVeJ/RURwz1dKpWXPkQK9IxhD8PiUEeZ3cTH9B8Q76JX5iXCS7t6hrWpgaJhAizrz2ATQsTMHwdJpCsbfr76H9p6o+DBba/t727BIrOwIo9uztW0gfYsh5mU3huPW2mrtlPU2ExX+PKiWmpWvpqt9EcCKnuXS1WBgGvP0T13k2J179DpfdOp6l8lQXdadt9k6nSOLhGTJ/FHCJw4pGviOhS2Y2uU1IoXqWtSjXqVTHhnUtu1XYcByxVrvkFvBSvcYxxfe620ovKWgGfEHIltS+ZjevfRib817XuD268+7w7SEnMo9OTXDwLD2NGoHp4LW8JBIEI5vTiGLa3BBQrLDzo9riKYiwtcqacAeT1Jp6PsIC880bwHqwyr9QT59HTD469k5fNrxPOK2CDXrItp4BwNd5leoj3sIYjv/7Jq6rLaXt8g+omwu36ePx26QlyxdNsNLHsRCZRbm8EOWF+xmCmbSV9j7p0wOgYOmZOUlWwRSMiJxQ8QwQVgSxdzH4TnmBU3InU5ZN3Er7VtgT382j+hrN8Fgqs0grzfEF1jvWIcZq6m8wJYmiqhUsWWgtDMQp+zn/TuqA1xiITCoirvAsdU4xKCV9iKFCyTPYAs1VI2M7IRPz095IAKo/9kUZ7TG7frL2+D3I0IVXNIwChrPVxJVGV/bVfPvcAEIs0jExnWghtHip6myYDqiPRyubRURcVmI9U= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(136003)(376002)(346002)(39860400002)(451199015)(66899015)(86362001)(36756003)(33656002)(122000001)(2906002)(8936002)(2616005)(186003)(83380400001)(38070700005)(38100700002)(316002)(6916009)(91956017)(54906003)(5660300002)(6486002)(478600001)(8676002)(71200400001)(64756008)(66446008)(4326008)(41300700001)(66946007)(66476007)(66556008)(76116006)(26005)(6506007)(6512007)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8570 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 23cca5f9-a3bc-43fb-9527-08dac63c09e4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BOdYRfTe/WV7niuZLRBm1FUkMSnCiOXTT4Y6lUhoT6ZZ7MK9vTkN1F3y5EtKP23qHXaBySBbhK99guKqMND/LB0Jd+X/ODCQYhouehIBBagwydNb3IB6VfaARQ3mAlQVc/KJ2nH6TgxZHaT8MlxOFG32hB1a02NOG6aq7g/0ybMu/2iTY4ML6Nb8Rxa1sGDt9LEjt3F5cjFDhDUOBk7sVzzXovzwYHyB2Z1lRanCX+lIEGcWomu0FMnuqYQ7fcfJXMiqn3K1N6V/qf2r0wrcwtmx46tNP5H8rbWI+fUXOJwszHUrVcJKKD/HWDNINVANR7p0icLul0LsN+uxx4g4LH5Z1tzoWYX+VBbWEnzsuZ9NpRYPLzzGCeeL/Qxf1MbVaoD4wIpzAGQ5x7iaJXMud02zmxjvf8rvvKd68B8rTSSlIkr6yTcJdsI2uAULeAtOwDac32GsKAzm8icogPDBx10eIDYOdinPJMJiQrKqLy75nvVS/ua5TGCJupRECPb9bqb/bUcdHKZI9W7UsxxP90tGuRF8taal/dhlhvyquzsqzDMTqq6f8ewPoAAPfFA5PjmzmGifTwtIbcz1tf1zMCbjaycvcnZTYqklW1BYBYmHstGK/IeMD719hxmVNmcrHbkEZdNGl62AfDtFpKOflkgrrYQjOxe1uRQpeGQpPU6nf7OJhwneq2tgQD0Ar8EJSM2yqg5Bp432fLjpG2sYepPiKET3m+GgFPxAo4KO8gtUzQt026ERO0TRkkTqrEOY X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(39860400002)(451199015)(36840700001)(46966006)(8676002)(33656002)(6862004)(70206006)(70586007)(8936002)(4326008)(36756003)(5660300002)(41300700001)(36860700001)(53546011)(6512007)(26005)(6506007)(356005)(82310400005)(83380400001)(47076005)(336012)(186003)(2616005)(316002)(54906003)(81166007)(107886003)(86362001)(478600001)(6486002)(82740400003)(40480700001)(66899015)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 12:31:03.9066 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 687fd5fb-8709-45b3-d93d-08dac63c1896 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9197 DQoNCj4gT24gMTQgTm92IDIwMjIsIGF0IDA3OjMwLCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTEuMTEuMjAyMiAyMTo1MiwgU3RlZmFubyBTdGFiZWxs aW5pIHdyb3RlOg0KPj4gT24gRnJpLCAxMSBOb3YgMjAyMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+ Pj4gT24gMTEuMTEuMjAyMiAxMTo0MiwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+Pj4+IE9uIDkg Tm92IDIwMjIsIGF0IDEwOjM2LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+IHdyb3Rl Og0KPj4+Pj4gT24gMDkuMTEuMjAyMiAxMTowOCwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+Pj4+ Pj4+IE9uIDA3LjExLjIwMjIgMTE6NDcsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4+Pj4+PiBO b3cgYW5hbHlzaXMtYnVpbGQtY292ZXJpdHkgd2lsbCBiZSBjYWxsZWQsIHRoZSBiZXN0IG1hdGNo IGlzIGFuYWx5c2lzLWJ1aWxkLSUsIHNvIGFnYWluIHRoZSBkZXBlbmRlbmN5DQo+Pj4+Pj4+PiB3 aGljaCBpcyBhbmFseXNpcy1wYXJzZS10YWdzLSUsIHdpbGwgYmUgdHJhbnNsYXRlZCB0byBhbmFs eXNpcy1wYXJzZS10YWdzLWNvdmVyaXR5Lg0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBOb3cgYW5hbHlz aXMtcGFyc2UtdGFncy1jb3Zlcml0eSB3aWxsIGJlIGNhbGxlZCwgdGhlIGJlc3QgbWF0Y2ggaXMg YW5hbHlzaXMtcGFyc2UtdGFncy0lLCBzbyB0aGUgJSB3aWxsDQo+Pj4+Pj4+PiBIYXZlIHRoZSDi gJhjb3Zlcml0eeKAmSB2YWx1ZSBhbmQgaW4gdGhlIGRlcGVuZGVuY3kgd2Ugd2lsbCBoYXZlICQo b2JqdHJlZSkvJS5zZWQgLT4gJChvYmp0cmVlKS9jb3Zlcml0eS5zZWQuDQo+Pj4+Pj4+PiANCj4+ Pj4+Pj4+IExvb2tpbmcgZm9yICQob2JqdHJlZSkvY292ZXJpdHkuc2VkIHRoZSBiZXN0IG1hdGNo IGlzICQob2JqdHJlZSkvJS5zZWQsIHdoaWNoIHdpbGwgaGF2ZSAkKEpVU1RJRklDQVRJT05fRklM RVMpDQo+Pj4+Pj4+PiBhbmQgdGhlIHB5dGhvbiBzY3JpcHQgaW4gdGhlIGRlcGVuZGVuY3ksIGhl cmUgd2Ugd2lsbCB1c2UgdGhlIHNlY29uZCBleHBhbnNpb24gdG8gc29sdmUNCj4+Pj4+Pj4+ICQo WEVOX1JPT1QpL2RvY3MvbWlzcmEvZmFsc2UtcG9zaXRpdmUtJCQqLmpzb24gaW4gJChYRU5fUk9P VCkvZG9jcy9taXNyYS9mYWxzZS1wb3NpdGl2ZS1jb3Zlcml0eS5qc29uDQo+Pj4+Pj4+PiANCj4+ Pj4+Pj4+IFNvIG5vdyBhZnRlciBhbmFseXNpcy1wYXJzZS10YWdzLWNvdmVyaXR5IGhhcyBlbmRl ZCBpdHMgZGVwZW5kZW5jeSBpdCB3aWxsIHN0YXJ0IHdpdGggaXRzIHJlY2lwZSwgYWZ0ZXIgaXQg ZmluaXNoZXMsDQo+Pj4+Pj4+PiB0aGUgcmVjaXBlIG9mIGFuYWx5c2lzLWJ1aWxkLWNvdmVyaXR5 IHdpbGwgc3RhcnQgYW5kIGl0IHdpbGwgY2FsbCBtYWtlIHRvIGFjdHVhbGx5IGJ1aWxkIFhlbi4N Cj4+Pj4+Pj4gDQo+Pj4+Pj4+IE9rYXksIEkgc2VlIG5vdyAtIHRoaXMgYnVpbGRpbmcgb2YgWGVu IHJlYWxseSBfaXNfIGluZGVwZW5kZW50IG9mIHRoZQ0KPj4+Pj4+PiBjaGVja2VyIGNob3Nlbi4g SSdtIG5vdCBzdXJlIHRob3VnaCB3aGV0aGVyIGl0IGlzIGEgZ29vZCBpZGVhIHRvDQo+Pj4+Pj4+ IGludGVncmF0ZSBhbGwgdGhpcywgaW5jbHVkaW5nIC4uLg0KPj4+Pj4+PiANCj4+Pj4+Pj4+IEFm dGVyIHRoZSBidWlsZCBmaW5pc2hlcywgaWYgdGhlIHN0YXR1cyBpcyBnb29kLCB0aGUgYW5hbHlz aXMtYnVpbGQtY292ZXJpdHkgaGFzIGZpbmlzaGVkIGFuZCB0aGUgX2FuYWx5c2lzLWNvdmVyaXR5 DQo+Pj4+Pj4+PiByZWNpcGUgY2FuIG5vdyBydW4sIGl0IHdpbGwgY2FsbCBtYWtlIHdpdGggdGhl IGFuYWx5c2lzLWNsZWFuIHRhcmdldCwgcmVzdG9yaW5nIGFueSA8ZmlsZT4ue2MsaH0uc2FmcGFy c2UgdG8gPGZpbGU+LntjLGh9Lg0KPj4+Pj4+PiANCj4+Pj4+Pj4gLi4uIHRoZSBzdWJzZXF1ZW50 IGNsZWFuaW5nLiBUaGUgc3RhdGUgb2YgdGhlIF9zb3VyY2VfIHRyZWUgYWZ0ZXIgYQ0KPj4+Pj4+ PiBidWlsZCBmYWlsdXJlIHdvdWxkIGJlIGRpZmZlcmVudCBmcm9tIHRoYXQgYWZ0ZXIgYSBzdWNj ZXNzZnVsIGJ1aWxkLg0KPj4+Pj4+PiBQZXJzb25hbGx5IEkgY29uc2lkZXIgdGhpcyBhdCBiZXN0 IHN1cnByaXNpbmcuDQo+Pj4+Pj4+IA0KPj4+Pj4+PiBJIHdvbmRlciB3aGV0aGVyIGluc3RlYWQg dGhlcmUgY291bGQgYmUgYSBzaGVsbCg/KSBzY3JpcHQgZHJpdmluZyBhDQo+Pj4+Pj4+IHNlcXVl bmNlIG9mIG1ha2UgaW52b2NhdGlvbnMsIGxlYXZpbmcgdGhlIG5ldyBtYWtlIGdvYWxzIGFsbCBi ZSBzZWxmLQ0KPj4+Pj4+PiBjb250YWluZWQuIFN1Y2ggYSBzY3JpcHQgY291bGQgcmV2ZXJ0IHRo ZSBzb3VyY2UgdHJlZSB0byBpdHMgb3JpZ2luYWwNCj4+Pj4+Pj4gc3RhdGUgZXZlbiB1cG9uIGJ1 aWxkIGZhaWx1cmUgYnkgZGVmYXVsdCwgd2l0aCBhbiBvcHRpb24gYWxsb3dpbmcgdG8NCj4+Pj4+ Pj4gc3VwcHJlc3MgdGhpcyBiZWhhdmlvci4NCj4+Pj4+PiANCj4+Pj4+PiBJbnN0ZWFkIG9mIGFk ZGluZyBhbm90aGVyIHRvb2wsIHNvIGFub3RoZXIgbGF5ZXIgdG8gdGhlIG92ZXJhbGwgc3lzdGVt LCBJIHdvdWxkIGJlIG1vcmUgd2lsbGluZyB0byBhZGQgZG9jdW1lbnRhdGlvbg0KPj4+Pj4+IGFi b3V0IHRoaXMgcHJvY2VzcywgZXhwbGFpbmluZyBob3cgdG8gdXNlIHRoZSBhbmFseXNpcy0qIGJ1 aWxkIHRhcmdldHMsIHdoYXQgdG8gZXhwZWN0IGFmdGVyIGEgc3VjY2Vzc2Z1bCBydW4gYW5kIHdo YXQNCj4+Pj4+PiB0byBleHBlY3QgYWZ0ZXIgYSBmYWlsdXJlLg0KPj4+Pj4+IA0KPj4+Pj4+IFdo YXQgZG8geW91IHRoaW5rPw0KPj4+Pj4gDQo+Pj4+PiBQZXJzb25hbGx5IEknZCBwcmVmZXIgbWFr ZSBnb2FscyB0byBiZWhhdmUgYXMgc3VjaCwgd2l0aCBubyBzdXJwcmlzZXMuDQo+Pj4+IA0KPj4+ PiBUaGUgYW5hbHlzaXMtKiBnb2FsIHJlcXVpcmVzIGEgYnVpbGQgc3RlcCwgb3RoZXJ3aXNlIG5v IGFuYWx5c2lzIGNhbiBiZSBwZXJmb3JtZWQgYnkgdGhlIGFuYWx5c2lzIHRvb2xzLCBzbyBJIGhv cGUgd2UgYWdyZWUNCj4+Pj4gd2UgbmVlZCB0byBpbnRlZ3JhdGUgdGhhdCBzdGVwIGFzIGEgZGVw ZW5kZW5jeSBvZiB0aGUgYW5hbHlzaXMtKi4NCj4+PiANCj4+PiBObywgSSdtIGFmcmFpZCB3ZSBk b24ndCBhZ3JlZS4gQnV0IGxpa2Ugc2FpZCBmb3IgYW5vdGhlciBwaWVjZSB3ZSBkaWRuJ3QNCj4+ PiBpbml0aWFsbHkgYWdyZWUgb24gLSBpZiBvdGhlcnMgdGhpbmsgd2hhdCB5b3UgcHJvcG9zZSBp cyBmaW5lLCBzbyBiZSBpdC4NCj4+PiBJJ20gc3BlY2lmaWNhbGx5IGFkZGluZyBBbnRob255IHRv IENjLCBhcyBoZSdzIGJlZW4gd29ya2luZyBvbiBtYWtlIHJ1bGVzDQo+Pj4gdGhlIG1vc3Qgb2Yg YWxsIG9mIHVzIGluIHRoZSByZWNlbnQgcGFzdC4NCj4+PiANCj4+Pj4gSSB1bmRlcnN0YW5kIHRo YXQgdGhlIGFuYWx5c2lzLWNsZWFuIG1pZ2h0IGJlIGEg4oCcc3VycHJpc2XigJ0gaWYgbm90IHdl bGwgZG9jdW1lbnRlZCwgdGhpcyBjb21lcyBmcm9tIHRoZSBuZWVkIHRvIHN1YnN0aXR1dGUgdGhl DQo+Pj4+IHRhZ3MgaW4gdGhlIHRyZWUgKHRvIGtlZXAgdGhlIHJlYWwgcGF0aCBpbiB0aGUgcmVw b3J0IGxvZykgYW5kIHRvIHJldmVydCB0aGVtIGJhY2sgYXQgdGhlIGVuZCBvZiB0aGUgYW5hbHlz aXMuDQo+Pj4+IA0KPj4+PiBTbywgc3VjaCBzY3JpcHQgc2hvdWxkIGp1c3QgbWFzayB0byB0aGUg dXNlciB0aGUgYW5hbHlzaXMtY2xlYW4gaW52b2NhdGlvbiBpbiBjYXNlIG9mIGVycm9ycyAod2l0 aCBhbiBvcHRpb24gdG8gZG9u4oCZdCBkbyB0aGF0KT8NCj4+PiANCj4+PiBIbW0sIGhlcmUgeW91 J3JlIHNheWluZyAic3VjaCBzY3JpcHQiLCB3aGljaCBsb29rcyB0byBub3QgZml0IHdpdGggdGhl DQo+Pj4gZWFybGllciBwYXJ0IG9mIHlvdXIgcmVwbHkgYWJvdmUuIChKdXN0IGluIGNhc2UgdGhh dCdzIHdoYXQgSSB3YXMgdG8gcmVhZA0KPj4+IG91dCBvZiB0aGlzOiBJIHdvdWxkbid0IHNlZSB2 YWx1ZSBpbiBhIHNjcmlwdCB3aGljaCBleGlzdGVkIF9zb2xlbHlfIHRvDQo+Pj4gbWFrZSB0aGUg Y2xlYW5pbmcgY29uZGl0aW9uYWwuKQ0KPj4+IA0KPj4+IERpZCB5b3UgY29uc2lkZXIgdGhlIGFs dGVybmF0aXZlIGFwcHJvYWNoIG9mIGNvcHlpbmcgdGhlIHRyZWUsIGFsdGVyaW5nDQo+Pj4gaXQg KHdoaWxlIG9yIGFmdGVyIGNvcHlpbmcpLCBydW5uaW5nIHRoZSBidWlsZCB0aGVyZSwgcHVsbGlu ZyBvdXQgdGhlDQo+Pj4gcmVzdWx0IGZpbGVzLCBhbmQgZGVsZXRlIHRoZSBlbnRpcmUgY29weT8g U3VjaCBhIG1vZGVsIHdvdWxkIGxpa2VseSBnZXQNCj4+PiBhd2F5IHdpdGhvdXQgaW50cm9kdWNp bmcgc3VycHJpc2luZyBtYWtlIHJ1bGVzLg0KDQpUaGlzIGFwcHJvYWNoIGRvZXMgbm90IHdvcmsg YmVjYXVzZSB0aGUgcmVwb3J0IHdpbGwgY29udGFpbiBhIHBhdGggdGhhdCBpcyBkaWZmZXJlbnQg ZnJvbSB0aGUgc291cmNlIHBhdGggYW5kDQpzb21lIHdlYiBiYXNlZCB0b29scyB3b27igJl0IGJl IGFibGUgdG8gdHJhY2sgYmFjayB0aGUgb3JpZ2luIG9mIHRoZSBmaW5kaW5nLg0KDQplLmcuIC9w YXRoL3RvL3hlbi9hcmNoL2FybS88ZmlsZT4gaXMgdGhlIG9yaWdpbmFsIGZpbGUsIHdlIHJ1biB0 aGUgYW5hbHlzaXMgb24gL3BhdGgvdG8yL3hlbi9hcmNoL2FybS88ZmlsZT4sDQp0aGUgZmluZGlu ZyBpcyBpbiAvcGF0aC90bzIveGVuL2FyY2gvYXJtLzxmaWxlPiBidXQgdGhlIHNvdXJjZSByZXBv c2l0b3J5IGNvbnRhaW5zIG9ubHkgL3BhdGgvdG8veGVuL2FyY2gvYXJtLzxmaWxlPg0KDQo+PiAN Cj4+IEFub3RoZXIsIG1heWJlIHNpbXBsZXIgaWRlYTogd2hhdCBpZiB0aGUgYnVpbGQgc3RlcCBp cyBub3QgYSBkZXBlbmRlbmN5DQo+PiBvZiB0aGUgYW5hbHlzaXMtKiBnb2Fscz8NCj4+IA0KPj4g QmFzaWNhbGx5LCB0aGUgdXNlciBpcyBzdXBwb3NlZCB0bzoNCj4+IA0KPj4gMSkgY2FsbCBhbmFs eXNpcy1wYXJzZS10YWdzLSoNCj4+IDIpIGJ1aWxkIFhlbiAoaW4gYW55IHdheSB0aGV5IGxpa2Up DQo+PiAzKSBjYWxsIGFuYWx5c2lzLWNsZWFuDQo+IA0KPiBXZWxsLCB0aGF0J3MgZXhhY3RseSB3 aGF0IEkndmUgYmVlbiBwcm9wb3NpbmcsIHdpdGggdGhlIChvcHRpb25hbCkNCj4gYWRkaXRpb24g b2YgYSBzbWFsbCAoc2hlbGwpIHNjcmlwdCBkb2luZyBhbGwgb2YgdGhlIHRocmVlIGZvciAuLi4N Cj4gDQo+PiBNYWtpbmcgc3RlcHMgMS0zIGludG8gYSBzaW5nbGUgc3RlcCBpcyBzbGlnaHRseSBt b3JlIGNvbnZlbmllbnQgZm9yIHRoZQ0KPj4gdXNlciBidXQgdGhlIGRvd25zaWRlIGlzIHRoYXQg ZGVhbGluZyB3aXRoIGJ1aWxkIGVycm9ycyBiZWNvbWVzDQo+PiBwcm9ibGVtYXRpYy4NCj4+IA0K Pj4gT24gdGhlIG90aGVyIGhhbmQsIGlmIHdlIGxldCB0aGUgdXNlciBjYWxsIHN0ZXBzIDEtMyBi eSBoYW5kDQo+PiBpbmRpdmlkdWFsbHksIGl0IGlzIHNsaWdodGx5IGxlc3MgY29udmVuaWVudCBm b3IgdGhlIHVzZXIgYnV0IHRoZXkgY2FuDQo+PiBtb3JlIGVhc2lseSBkZWFsIHdpdGggYW55IGJ1 aWxkIGVycm9yIGFuZCBzb3BoaXN0aWNhdGVkIGJ1aWxkDQo+PiBjb25maWd1cmF0aW9ucy4NCj4g DQo+IC4uLiBjb252ZW5pZW5jZS4NCg0KRm9yIGNvdmVyaXR5IGFuZCBlY2xhaXIsIGl0IG1ha2Vz IHNlbnNlLCB0aGVzZSB0b29scyBkb2VzbuKAmXQgcmVxdWlyZSBtdWNoIGVmZm9ydCB0byBiZSBp bnRlZ3JhdGVkLA0KdGhleSBhcmUgYnVpbHQgdG8gaW50ZXJjZXB0IGZpbGVzLCBjb21waWxlcnMs IGVudmlyb25tZW50IHZhcmlhYmxlcyBkdXJpbmcgdGhlIG1ha2UgcnVuIGluIGENCnRyYW5zcGFy ZW50IHdheS4NCg0KU28gdGhlIHdvcmtmbG93IGlzOg0KDQoxKSBjYWxsIGFuYWx5c2lzLXBhcnNl LXRhZ3MtKg0KMikgYnVpbGQgWGVuIChpbiBhbnkgd2F5IHRoZXkgbGlrZSkNCjMpIGNhbGwgYW5h bHlzaXMtY2xlYW4NCg0KDQpJZiB3ZSB0aGluayBhYm91dCBjcHBjaGVjayBob3dldmVyLCBoZXJl IHRoZSBzdG9yeSBjaGFuZ2VzLCBhcyBpdCByZXF1aXJlcyBhbGwgdGhlc2UgaW5mb3JtYXRpb24N CnRvIGJlIGdpdmVuIGFzIGlucHV0cywgd2UgaGF2ZSB0byBkbyBhbGwgdGhlIHdvcmsgdGhlIGNv bW1lcmNpYWwgdG9vbHMgZG8gdW5kZXIgdGhlIGhvb2QuDQoNClRoZSBjcHBjaGVjayB3b3JrZmxv dyBpbnN0ZWFkIGlzOg0KDQoxKSBjYWxsIGFuYWx5c2lzLXBhcnNlLXRhZ3MtY3BwY2hlY2sNCjIp IGdlbmVyYXRlIGNwcGNoZWNrIHN1cHByZXNzaW9uIGxpc3QNCjMpIGJ1aWxkIFhlbiAoYW5kIHJ1 biBjcHBjaGVjayBvbiBidWlsdCBzb3VyY2UgZmlsZXMpDQo0KSBjb2xsZWN0IGFuZCBnZW5lcmF0 ZSByZXBvcnQNCjUpIGNhbGwgYW5hbHlzaXMtY2xlYW4NCg0KU28gbGV04oCZcyB0aGluayBhYm91 dCBkZXRhY2hpbmcgdGhlIGJ1aWxkIHN0YWdlIGZyb20gdGhlIHByZXZpb3VzIHN0YWdlcywgSSB0 aGluayBpdCBpcyBub3QgdmVyeSBjb252ZW5pZW50DQpmb3IgdGhlIHVzZXIsIGFzIGR1cmluZyBj cHBjaGVjayBhbmFseXNpcyB3ZSBidWlsZCAkKG9ianRyZWUpL2luY2x1ZGUvZ2VuZXJhdGVkL2Nv bXBpbGVyLWRlZi5oLCB3ZSBidWlsZCANCiQob2JqdHJlZSkvc3VwcHJlc3Npb24tbGlzdC50eHQs IHNvIHRoZSB1c2VyIG5lZWRzIHRvIGJ1aWxkIFhlbiB3aGVyZSB0aG9zZSBmaWxlcyBhcmUgY3Jl YXRlZA0KKGluLXRyZWUgb3Igb3V0LW9mLXRyZWUpIG90aGVyd2lzZSB0aGUgYW5hbHlzaXMgd29u 4oCZdCB3b3JrIGFuZCB0aGF04oCZcyB0aGUgZmlyc3QgdXNlciByZXF1aXJlbWVudCAoc3RhZ2Ug IzMpLg0KDQpUaGUgbW9zdCBjcml0aWNhbCBpbnB1dCB0byBjcHBjaGVjayBpcyBYZW7igJlzICQo Q0MpLCBpdCBjb21lcyBmcm9tIHRoZSBidWlsZCBzeXN0ZW0gaW4gdGhpcyBzZXJpZSwgdGhlIHVz ZXIgd291bGQNCm5lZWQgdG8gcGFzcyB0aGUgY29ycmVjdCBvbmUgdG8gY3BwY2hlY2sgd3JhcHBl ciwgdG9nZXRoZXIgd2l0aCBjcHBjaGVjayBmbGFncywgYW5kIHBhc3MgdG8gWGVuIGJ1aWxkIHN0 YWdlICMzDQp0aGUgd3JhcHBlciBhcyBDQywgc2Vjb25kIHVzZXIgcmVxdWlyZW1lbnQuDQoNCkFm dGVyIHRoZSBhbmFseXNpcywgdGhlIHVzZXIgbmVlZHMgdG8gcnVuIHNvbWUgc2NyaXB0cyB0byBw dXQgdG9nZXRoZXIgdGhlIGNwcGNoZWNrIHJlcG9ydCBmcmFnbWVudHMNCmFmdGVyIGl0cyBhbmFs eXNpcywgdGhpcyBzdGVwIHJlcXVpcmVzIGFsc28gdGhlIGtub3dsZWRnZSBvZiB3ZXJlIFhlbiBp cyBidWlsdCwgaW4tdHJlZSBvciBvdXQtb2YtdHJlZSwgc28NCmhlcmUgdGhlIHRoaXJkIHVzZXIg cmVxdWlyZW1lbnQgKHNpbWlsYXIgdG8gdGhlIGZpcnN0IG9uZSwgYnV0IHRoZSBzdGFnZSBpcyAj NCkuDQoNCkluIHRoZSBlbmQsIHdlIGNhbiBzZWUgdGhlIHVzZXIgd291bGQgbm90IGJlIGFibGUg dG8gY2FsbCBpbmRpdmlkdWFsbHkgdGhlIHRhcmdldHMgaWYgaXQgaXMgbm90IG1hc3RlcmluZw0K dGhlIHN5c3RlbSwgaXTigJlzIHRvbyBjb21wbGV4IHRvIGhhdmUgc29tZXRoaW5nIHdvcmtpbmcs IHdlIGNvdWxkIGNyZWF0ZSBhIHNjcmlwdCB0byBoYW5kbGUgdGhlc2UgcmVxdWlyZW1lbnRzLA0K YnV0IGl0IHdvdWxkIGJlIGNvbXBsZXggYXMgaXQgd291bGQgZG8gdGhlIGpvYiBvZiB0aGUgbWFr ZSBzeXN0ZW0sIHBsdXMgaXQgbmVlZHMgdG8gZm9yd2FyZCBhZGRpdGlvbmFsIG1ha2UgYXJndW1l bnRzDQp0byBpdCBhcyB3ZWxsIChDUk9TU19DT01QSUxFLCBYRU5fVEFSR0VUX0FSQ0gsIGluLXRy ZWUgb3IgT3V0LW9mLXRyZWUgYnVpbGQsIC4uLiBmb3IgZXhhbXBsZSkuDQoNCkluIHRoaXMgdGhy ZWFkIHRoZSBtZXNzYWdlIGlzIHRoYXQgaW4gY2FzZSBvZiBlcnJvcnMsIHRoZXJlIHdpbGwgYmUg c29tZSBhcnRpZmFjdHMgKDxmaWxlPi5zYWZwYXJzZSwgbW9kaWZpZWQgPGZpbGU+KQ0KYW5kIHRo aXMgaXMgdW5leHBlY3RlZCBvciBzdXJwcmlzaW5nLCBidXQgd2UgYXJlIGdvaW5nIHRvIGFkZCBh IGxvdCBvZiBjb21wbGV4aXR5IHRvIGhhbmRsZSBzb21ldGhpbmcgdGhhdCBuZWVkcw0KanVzdCBk b2N1bWVudGF0aW9uIChpbiBteSBvcGluaW9uKS4NCg0KSWYgdGhlIGNvbW11bml0eSBkb27igJl0 IGFncmVlIHRoYXQgZG9jdW1lbnRhdGlvbiBpcyBlbm91Z2gsIGEgc29sdXRpb24gY291bGQgYmUg dG8gcHJvdmlkZSBhIHNjcmlwdCB0aGF0IGluIGNhc2Ugb2YNCmVycm9ycywgY2FsbHMgYXV0b21h dGljYWxseSB0aGUgYW5hbHlzaXMtY2xlYW4gdGFyZ2V0LCBhbmFseXNpcy08dG9vbD4gd2lsbCBj YWxsIGFsc28gdGhlIGJ1aWxkIHN0ZXAgaW4gdGhpcyBjYXNlLA0KaGVyZSBzb21lIHBzZXVkb2Nv ZGU6DQoNCgkjIS9iaW4vYmFzaA0KCXNldCAtZQ0KDQoJdHJhcCBbY2FsbCBhbmFseXNpcy1jbGVh bl0gRVhJVA0KDQoJW2NhbGwgYW5hbHlzaXMtPHRvb2w+XQ0KDQoNClRoaXMgc2NyaXB0IG5lZWRz IGhvd2V2ZXIgYWxsIHRoZSBtYWtlIGFyZ3VtZW50cyB0aGF0IHdlIHdvdWxkIGhhdmUgcGFzc2Vk IHRvIG1ha2UgaW5zdGVhZDoNCg0KLi9zY3JpcHQuc2ggLS10b29sPTx0b29sPiBbLS1kb250LWNs ZWFuLW9uLWVycl0gLS0gQ1JPU1NfQ09NUElMRT3igJxbLi4uXeKAnCBYRU5fVEFSR0VUX0FSQ0g9 4oCcWy4uLl3igJ0gW290aGVycy4uLl0NCg0KDQoNCg0KPiANCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon Nov 14 13:16:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 13:16:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443368.697896 (Exim 4.92) (envelope-from ) id 1ouZJg-0001JW-HK; Mon, 14 Nov 2022 13:16:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443368.697896; Mon, 14 Nov 2022 13:16:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouZJg-0001JP-Ec; Mon, 14 Nov 2022 13:16:00 +0000 Received: by outflank-mailman (input) for mailman id 443368; Mon, 14 Nov 2022 13:16:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouZJg-0001JJ-1Q for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 13:16:00 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78fc5141-641e-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 14:15:58 +0100 (CET) Received: from mail-bn8nam04lp2044.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Nov 2022 08:15:54 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB5773.namprd03.prod.outlook.com (2603:10b6:a03:2db::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 13:15:52 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Mon, 14 Nov 2022 13:15:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78fc5141-641e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668431758; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=9ZYr6+Lo9tDzaLW4FGiKqdSBkBqqUuYei0FlhK+kDG4=; b=XuTFo6YUS5kMu3yF7RxUsYxqFfyfqkWFniRXsSBl63EdiwxbKIbNsqNZ siClHsrW1nUBEXWuGQwHgRqllEppNTIrx4IdJSqVb+bGk97AFb4x2i8k4 IhHTzfLwHqKIjQXBxvIM66xOcMeTrG8aGTRkeiMvQ/Jd9Gy/vSrMLHvBc E=; X-IronPort-RemoteIP: 104.47.74.44 X-IronPort-MID: 84784970 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:bgIWiKMDphtRlS7vrR1RlsFynXyQoLVcMsEvi/4bfWQNrUpz1zYDy GJLW2zUP/rYazGhc99zbo208UxTu5eBmIM1Ggto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5wBmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vRHHnB85 /0/EzoqfxGGhO6/x7SyQ8A506zPLOGzVG8ekldJ6GmFSNwAEdXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vZxvzS7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLVri382r6QxUsXXqpPU6Ce2aRqpGTMx3QDBUUxaHflgPq23xvWt9V3b hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JwHusg+Ueyw6zbyw+DAy4PSTspQMQvqcseVTEsk FiTkLvBGjhHoLCTD3WH+d+8ry60fy4cLmYAZCoNZQoD/9Tn5oo0i3rnTdt9Eajzktz8Hxnxx SyHqG41gLB7pd4G0eC38E7Khxqop4PVVUgl6wPPRGWn4whlIom/aOSVBUPz6P9BKMOTSAmHt X1cx8yGtrhSUdeKiTCHR/gLEPex/fGZPTbAgFlpWZ486zCq/H3ldodViN1jGHpU3g8/UWeBS CfuVcl5vfe/4FPCgXdLXr+M IronPort-HdrOrdr: A9a23:TcoCoq/RqmPxiZ/jeC1uk+G/dr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81nOdkTN9VLXJOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJLqDhSC2R8acjVXhZMv63 LMnQDV7riq96jT8G6Q60bjq7Bt3PfxwNpKA8KBzuATNzXXkw6tIKhxRrGYuzgxgee3rHInis PFrRsMN9l6r1nRYma2ix3w3BSI6kdl11bSjXujxVfzq83wQzw3T+JHmIJiaxPcr24tpst13q 5n13+Q88M/N2KKoA3No/zzEz16nEu9pnQv1cYVknxkSIMbLJtct5YW8k95GIoJWAj69IckOu 9zC9y03ocfTXqqK1Ti+kV/yt2lWXo+Wj+AX0g5o8SQlwNbmXhopnFosPA3rzMlztYQWpNE7+ PLPuBDj7dVVPIbaqp7GaMoXda3Inale2OMDEuiZXDcUI0XMXPErJD6pJ8v4vuxRZAOxJwu3L zcTVJjs3IocU6GM7zB4HRyyGGPfIyBZ0Wu9ikHjKIJ/4EUBYCbfhFrcWpe0/dJ+J4kc4nms/ XaAuMiPxasFxqoJW9z5XyPZ3BjEwhhbCQrgKdLZ7uvmLO9FmS4jJ2sTN/jYJzQLB0DZkTTRl M+YRmbHrQz0qnsYA61vCTs X-IronPort-AV: E=Sophos;i="5.96,161,1665460800"; d="scan'208";a="84784970" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Grn4UxJG8L7goysYETDVxSJfYy3LGc81DAiFSHF7wU12yQBeXz3rjaaUc8+yjXGVb/WdUyIj9v611MQln2kB/Ar7l2ayG4A6tmSU3jp/bD4jaHL6wEFlJDbZG99r1h/87/+RnIaa6V5JGmXcCe3XYgxTOhUJzlfc5/nydENsC7S5dAIQwZrfnj5yWD1ayVTKuYLF/TatNwxWybHKTZElpOK7MhP2br5AsAveSoOSc9zVozCSuCycQLdJmZtAlntYdqQBAIXhRBo2px09/wmGOvV6zNrIYgVoBBNzjWma5MfflHtLwzC3KgBDzsjtr7GvcAQ37pbUhQvRgbdtWaedGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9S3OqI265xwlmtbBZgc0vnpQZ4HAew4TlLAgf6CY90k=; b=H2JuPoOrdlnl4YX5UnMyL6t5wH4z2QzTEMf9UkgkNYBtZ4uOCGZlMxnbeCm0Rdxvc+s3h6LUudHbzgZybJRw7mitk1reaulbt4I96yYxEG7+OAK0Gh+1P5rzJl+kYGU5kVk0aUNgbGPizNfCHPodKt0/erPgfIvVCaDS9sDTRDw3qnu9osYVVGXAoQYL8lcD23qdGc8g2kMMCfJOFNvJjCN8EmdKLtBATnAQDz+mXkN4K2d45jbdWLxtDQQKPdMg0V2oFBl20t6hSLP3ObZzcDe6D8zhKA1Jk9fCZ2i62q4HEKKFqnwFOfM9oZqNkgl8bX9fTRuM8ZEfvHGuxt504Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9S3OqI265xwlmtbBZgc0vnpQZ4HAew4TlLAgf6CY90k=; b=YubJZel3cLL4coYmZRBWygO9jX0QzmyA3YNiCdSLNpodCs6+aJMuuZuJCGq17C8fVmJL2W7Q1yMGSh9ShOoc5+9OIjpLxweDNNp8VvPuQhr2MHOFdQLHutii03NTC5scnqYBajXvrGIAx4H2/op+hFS5T0btne+LeNoDhzUiIlU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 14 Nov 2022 14:15:46 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Jan Beulich , "Henry.Wang@arm.com" , Paul Durrant , Wei Liu , Jun Nakajima , Kevin Tian , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Message-ID: References: <20221104161815.38007-1-roger.pau@citrix.com> <69841767-ccc4-5eeb-6e9c-d59dfb197ea5@citrix.com> <8e52a065-0141-f75c-03e8-e9ceb18a0aa1@suse.com> <4d0edf44-bb7c-85d9-0890-79c999428ef6@citrix.com> <1051eec8-8074-39e8-299d-a540d12bc997@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1051eec8-8074-39e8-299d-a540d12bc997@citrix.com> X-ClientProxiedBy: LO4P265CA0167.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::12) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5773:EE_ X-MS-Office365-Filtering-Correlation-Id: 43619981-8254-4c6a-7a2c-08dac6425a80 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y2DlkdPfOPPYRaDUqVftcLmo0OtxuCf0LM8w88HQh9+2UtcJnZNZjbWyxlNybXkEy3eCSd9VbWpnCjZBDEYEye3ujrD3QwcCkOtXzrUBPQuB+97PNTgTee7hhhLjUlA/qGFejeWvzXDb/3EKarP0ck3DtgbU1MgUMpdaaxb7xa7SZmYIiXTQJ7MnSzxxRA5mt08Q1DxDspq7cHTRKI/Te380w5rLljumyR9vYFeDsLwKllm1VMY35fRCkFC1Q8Wb1TVuaT3Pq51Xtq5bOhMpvbe1ePLXlpudVZdDPps+zSTJWbIPHj/1r99Wnf3a1hOrHYRsB1aNLgdlioEZ5eznZ4BMgP2jhPoJFE2sqbXxM8uK7WyCUNTy4ax8ccief3JzlLurePCs6BC6EVFxMnqgv/WNkhm/HzLfPpaQXYKMVs1d2m0KtX7Iof9LpPElf3YQeuOKkBuMSSVcvA2LIvCPfdvvfXfr3Tc2dC8BVxiivQ4RWzJqu+MR5jQi2467zttlXVeEnjS0ehYToEoNjr24uLLnnRU9EgPLz0tBCPFDFnZg2ZPvinkKKA/jGuITP94QFKJ80TlziAu7KDWJcWgTvS1znjvo9Nu0LoMVnNyTE9mmc7kthYCxNjikQg3ipc4piyeIDlOzkRI28vKqMt1RuXTTF/KjSE5MESty4xXaTaJ6yK2WDAiLx7XFAdq7MvoKZEOyERiTRQSeqrR2e4JuTQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(376002)(366004)(396003)(39860400002)(346002)(136003)(451199015)(6512007)(9686003)(26005)(54906003)(6636002)(186003)(66556008)(66476007)(8676002)(85182001)(66946007)(2906002)(316002)(4326008)(86362001)(82960400001)(6666004)(33716001)(6506007)(6486002)(83380400001)(5660300002)(478600001)(41300700001)(53546011)(8936002)(6862004)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXg5aDgwNDlIQWFWZkJtMm1rbWsrcGI1RHpERWhEVjlNeVBuYlMwbWJwSmJl?= =?utf-8?B?LzVvaUttYlBURzdBNWNnOGk2VDNGOHhFeFlESTBmU3VrL0RyeDhrYlpzVVJP?= =?utf-8?B?dnVBNElad2FOeEJtWDhpdGFKTHMwSDFuS2tvWHg4V09sRGlRRzlSZ2tUMXhT?= =?utf-8?B?Z20rR2ovQWZBWkFuV2RDeTFPREQ2S21mWFAyaFl1bk1IRnlTSWVsT3JFaEZW?= =?utf-8?B?T1l1SXJoVVVoOFFya2NyWms4WFhpMmVsTStkcExNZnI4Y1lDVXFaRjBkdVhl?= =?utf-8?B?cEExMnJOWTFjZEQ4VTRUU1dyaU1sckVpYWZlNEU1MmR3cWxnZzloRjAyc1dn?= =?utf-8?B?ajJLN2lIdXVqNUlzNTRncHp1TlRTc2dyR2lsZ3BheUMzaDNmZndBVm5Xb1ky?= =?utf-8?B?OUtBazlIVit6THZGbjlkOTVYR3FsK1RtN092bE1TZmZwenZDTHZyZmpsWE8y?= =?utf-8?B?K2ZCNG9qQWlUYnhqVEN4SXA0QWU4NE1DOXk2dXhSZDVvTlhvNmdpc29XY040?= =?utf-8?B?aXl2V3lla1g3azVueCtIeEx1RlN0dXJjYWI0UkFjbk44YU0vTlZnWHlENzBS?= =?utf-8?B?VG1WaDU3ZWFiU21xdXNFWlJwSVF5aDA0VVVNb1VBeStEVUtjUnlLOE5QM0p4?= =?utf-8?B?c3EvWVZKcXBBMlRaNVNDaTBTV1JvOHYxeXY2Q3phNmhQNWxnam9TZUhDQi9G?= =?utf-8?B?UXlvV0NHQTU0Nk1RdThvR0NGRHVVTTdXL0lBcnFpaGk0WlJBU0FqczlNVThw?= =?utf-8?B?dG81RmpBNzFoL3g2QnQzazFDckUxWUx4V2lZT3NIWkxwQjBGcnJXa0Y0SEdx?= =?utf-8?B?SE1rc0xhN01RWDFNbTgvZkVQSFoyc051azZDUVpxYUEvRFhaSWhxc244UXV0?= =?utf-8?B?UmlaaTBWZzR2VXp5Wkx0ZzBsNThIVzczQkxlQnR2UnY3K29CMG1yZHNuWkR4?= =?utf-8?B?Qm9EcC9aTFlKN05UZVl6UEZiNm5ibU9SMnNuYVFJUVdzZXlqVzZOUlVlbGhz?= =?utf-8?B?RkdCY0V0OTJROUtXeDVJSGpjVnBZbVc0b2xBYXRqSjdWU0RBMGNlZFB0MFVD?= =?utf-8?B?Z1lFa3BFOFZVT3BlejBsbmRrOXJjYWRJRHdPRHVRcFNzaDZsTmt2V05LTlNC?= =?utf-8?B?TGpEUkVSTWtTRDBJeVE4SE5rMFY5ZGw1dTNRenlQNm9JelR2eDBYNXpjSEl4?= =?utf-8?B?T2owWi94Rm9CdStDa3NwSFNPeUZmVEZWYjJwNXdESStEYVdSUGNOV2RnNUVh?= =?utf-8?B?TUtXZzNzV0RyeDlJUXZJcldDUXkrU3FUcUlMNStaOE4yaVQ2UWQ0bmUreVlp?= =?utf-8?B?ckl4QnJwK25VeldYYmZXZTFBM3g5dUw5NDNFZGVuVXozQUdSTmFvL2wrVDlp?= =?utf-8?B?V044eHk0b2ZDUWV4T1ZnbnUzd09oT2Z2YUc4Q3hzOENhbklkbDU2aUNQU0NF?= =?utf-8?B?aG9IVTF3cFBnZTltN2w2ZEFsZnczVlJlaUpnd0kvZTRLeWFxNC9YLzVOcGZV?= =?utf-8?B?dzVqMzA0TGJNZkxzTHlMZ1FDVnlmaHFjL1lWU3QxS1pZdUZTRURLWU03U2NU?= =?utf-8?B?Y0VrcThTdStaVTRZa0V0RGRlc2FWWkZueVNtWTkwSlNseSt6V2xBQ1ZrZk9l?= =?utf-8?B?QXgvNHpzaE9YODllSnk3M2RBb1JsbDgxNllSN2FSQUo1bXVMQUNZMUlhQ2lQ?= =?utf-8?B?NTVLZEM2bDVKT1dtenREWG52eTFYSXk4NjM2cDlpNWsxQ2RqQmhDU1dEVUNL?= =?utf-8?B?TUxsV3FXTm15Vmo2bHVWTW5vYWJqT1ltTFZwaHJaRk1TeklzeU9FeDIvK1JQ?= =?utf-8?B?Y2RuSXdFLy9tSGx4c3p0OXFZSGFQOTZOL2ViUHR4YUxMdDB2b3dlWHovY1N6?= =?utf-8?B?M2pkOEhxeHVjRVJCY0NaOFFpS0tRQ1Y4ejdaZm5yWjY0Z0QvSWVHV2htdGU4?= =?utf-8?B?b1l3Q2FLOFNTSDhPWjc2MmJRZXBpdWxsb3pnN1g3Mk00RUliUlNMUFFkRE9I?= =?utf-8?B?Q3A5b2NDZXcrSVJQa2ZYQVVYN0dXQUNLZnd2TWZYT0JGaGRjYS8ycmU1RHpp?= =?utf-8?B?bE1CVHMweHVUTHByOG44dWhsNmFuNnRwTHhuSEt6YTFuQTJoNE1lcWNLL3oz?= =?utf-8?Q?rKg3qYBf5JEbdQ2xAeP0mU6WQ?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: qt18qbMk06qZL9kEa9F/CniaiqMXpfXw127Ehwf4EyDVg70TCZCH6JAjvQxNf45CNeNseYyhXW+KusOiInjk8qpe1JbBFgMMB1dq+811UhS0LYDsfy+pFxLuPzRxuvMGsqUqj2+dzzXng/TvcUJo23CoVXWCZ8iSsX+FHrzoNFzefRO3OXoalU62i6XI0pSEeRVX2FAhX2+lN4HeTGP/6n4cg/a3Y1Atp3GSNCBKSJKc8ELUZ1x9BziXeYUP6pDSvb9TEkOKu0VSW25hnVUPhKs1P0kUgMZXUToifVAF9CVuqeHCvs9EEHAMhWz1fnQvUg9QGuTzN+Q/VIGfNaFjfpOfEdrTZ3Ph2YYu/shHEhEZ/x4Wdx0X1czqaxolpTS4fHakXymYthKctvhwy5VggDgEQNEyAYLuvTmWmojb0ZUwROsROmpgQBTD7r2cNEYGdMoiOW3QRe6GY+FhoFuKdpn0IwmypWoaY9aPj0j+3vAkd+P4OljRpMlNfZO87+/rB1VCadOqjTNP+O14xrLGHism5Ux3VUI8tQyyz0EqalQAG9ieHFS1lXw9Knv5WwKEbtueBFNlkqOLT5/9CmBIbjQZyUyGzp9elob5Czz4VBTD4w9xmpWpRSxS2ZDfr5P1krj/s7+XXRcDbgc1fyh/pUMm4lIvQeqF4+474nmleoS4WypomeupNLyptGedDQn6NZYYr9P+n+Yz7N2O7AYvwlb1Kf4rJrPlNjkfECQ0wHx2yqxPuGDlfkQtWhFYSfskt8piBHRBfvlNhvvqnsbeBw1nLdgZoKnU2VomWC+ytXpgBo1lZSIE4NOmOUTtb3TDBt2INkWAJjYk1pciyVkqWdx/7grmgu3TUuT8wn9F7U8Cm1g5wo4qnuJJuxHWDyzBcCY+/MQyqdWWYCy/0DIYKdFx3DZE462HaJp1T9lL6qs= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43619981-8254-4c6a-7a2c-08dac6425a80 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 13:15:51.8450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sTa0pNehX/Pa1iKQskKuknqXtyy9lNIx8QmHrj2HX4whxyTqTZu2IuwB1MXvvcDvExiXwMgY8D2mEomdrBJPiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5773 On Fri, Nov 11, 2022 at 05:47:02PM +0000, Andrew Cooper wrote: > On 11/11/2022 17:35, Andrew Cooper wrote: > > On 11/11/2022 07:45, Jan Beulich wrote: > >> On 10.11.2022 23:47, Andrew Cooper wrote: > >>> On 04/11/2022 16:18, Roger Pau Monne wrote: > >>>> --- a/xen/arch/x86/hvm/viridian/viridian.c > >>>> +++ b/xen/arch/x86/hvm/viridian/viridian.c > >>>> @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, > >>>> res->a = CPUID4A_RELAX_TIMER_INT; > >>>> if ( viridian_feature_mask(d) & HVMPV_hcall_remote_tlb_flush ) > >>>> res->a |= CPUID4A_HCALL_REMOTE_TLB_FLUSH; > >>>> - if ( !cpu_has_vmx_apic_reg_virt ) > >>>> + if ( !has_assisted_xapic(d) ) > >>>> res->a |= CPUID4A_MSR_BASED_APIC; > >>> This check is broken before and after.  It needs to be keyed on > >>> virtualised interrupt delivery, not register acceleration. > >> To me this connection you suggest looks entirely unobvious, so would > >> you mind expanding as to why you're thinking so? The hint to the guest > >> here is related to how it would best access certain registers (aiui), > >> which to me looks orthogonal to how interrupt delivery works. > > I refer you again to the diagram.  (For everyone else on xen-devel, I > > put this together when fixing XSA-412 because Intel's APIC acceleration > > controls are entirely unintuitive.) > > > > It is "virtual interrupt delivery" which controls EOI/ICR acceleration, > > and not "apic register virtualisation".  There's a decade worth of > > hardware where this logic is an anti-optimsiation, by telling windows to > > use a VMExit-ing mechanism even when microcode would have avoided the > > VMExit. > > > > It is not by accident that "virtual interrupt delivery", introduced in > > IvyBridge, is exactly the missing registers (on top of "use TPR Shadow" > > which is even older) to make windows performance less bad. > > Sorry, sent too early. > > This also firmly highlights why the API/ABI is broken.  I'm not seeing how you are making this connection: the context here is strictly about a Viridian hint which Xen has been wrongly reporting, but has nothing to do with the APIC assist API/ABI stuff. It was wrong before the introduction of APIC assist, and it's also wrong after. Also see my other reply - I'm dubious whether this hint is useful for any Windows version that supports x2APIC (which seems to be >= Windows Server 2008), because we expose x2APIC to guests regardless of whether the underlying platform APIC supports such mode. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Nov 14 14:06:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 14:06:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443375.697907 (Exim 4.92) (envelope-from ) id 1oua6D-0007BV-9h; Mon, 14 Nov 2022 14:06:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443375.697907; Mon, 14 Nov 2022 14:06:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oua6D-0007BO-6v; Mon, 14 Nov 2022 14:06:09 +0000 Received: by outflank-mailman (input) for mailman id 443375; Mon, 14 Nov 2022 14:06:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oua6B-0007BE-Re; Mon, 14 Nov 2022 14:06:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oua6B-0006so-OT; Mon, 14 Nov 2022 14:06:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oua6B-0005S8-DS; Mon, 14 Nov 2022 14:06:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oua6B-00087R-D0; Mon, 14 Nov 2022 14:06:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TjmF5xarnhEv9cj52iZ3iYUo7EBAqN1UkxctY5jLCvs=; b=fwk/sFtUtuH/NNNOtcWjLno3fW 2or7NgGTX461j0IEA+usoGsjfdNaT/7rV2+FAuh/zo4b+PJORpZQ8JW44bnJtqUdkPjTieg4kc0j/ Zzjw+m7T2c+GZTvRDj+3kG1iuqMg+4MmCvay7yhnOQcNpZGHUHzaqZtGgdAPB5KGyc04=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174766: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c805ceb0b26a643c7e47f01f2dbc50555d93cce8 X-Osstest-Versions-That: xen=17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 From: osstest service owner Date: Mon, 14 Nov 2022 14:06:07 +0000 flight 174766 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174766/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen c805ceb0b26a643c7e47f01f2dbc50555d93cce8 baseline version: xen 17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 Last test of basis 174741 2022-11-11 23:00:26 Z 2 days Testing same since 174766 2022-11-14 11:04:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Lindig Henry Wang Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 17dfc79ce9..c805ceb0b2 c805ceb0b26a643c7e47f01f2dbc50555d93cce8 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Nov 14 14:24:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 14:24:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443381.697918 (Exim 4.92) (envelope-from ) id 1ouaNP-0001O8-QU; Mon, 14 Nov 2022 14:23:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443381.697918; Mon, 14 Nov 2022 14:23:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouaNP-0001O1-Me; Mon, 14 Nov 2022 14:23:55 +0000 Received: by outflank-mailman (input) for mailman id 443381; Mon, 14 Nov 2022 14:23:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouaNN-0001Nv-Q3 for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 14:23:53 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f0072a96-6427-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 15:23:41 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B547620047; Mon, 14 Nov 2022 14:23:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8528113A92; Mon, 14 Nov 2022 14:23:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OwIAH3dPcmMtagAAMHmgww (envelope-from ); Mon, 14 Nov 2022 14:23:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0072a96-6427-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1668435831; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=sAfl5fuNeiYw163kQkU47PxfF3Zja2zKggUEdCCcBhk=; b=gp8JXiltXKb1uWqjC2t5qQtcG7+F9MBrH/xUbap/0IPmp81Z94Iz2J/dS88U0CRcqLhWQV wTEvQEfHqi/kDIGYEh8ZGKJV6Es/bCBCLhtpO9FonmMEi/N9et6tYlBl/oV3YJbbAQPHDW xXQhut/guvd1A7piXFT6qk4zMoX7oLM= From: Juergen Gross To: linux-kernel@vger.kernel.org Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Subject: [PATCH] xen/platform-pci: use define instead of literal number Date: Mon, 14 Nov 2022 15:23:48 +0100 Message-Id: <20221114142348.1499-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of "0x01" use the HVM_PARAM_CALLBACK_TYPE_PCI_INTX define from the interface header in get_callback_via(). Signed-off-by: Juergen Gross --- drivers/xen/platform-pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c index 18f0ed8b1f93..24a3de1b7b03 100644 --- a/drivers/xen/platform-pci.c +++ b/drivers/xen/platform-pci.c @@ -54,7 +54,8 @@ static uint64_t get_callback_via(struct pci_dev *pdev) pin = pdev->pin; /* We don't know the GSI. Specify the PCI INTx line instead. */ - return ((uint64_t)0x01 << HVM_CALLBACK_VIA_TYPE_SHIFT) | /* PCI INTx identifier */ + return ((uint64_t)HVM_PARAM_CALLBACK_TYPE_PCI_INTX << + HVM_CALLBACK_VIA_TYPE_SHIFT) | ((uint64_t)pci_domain_nr(pdev->bus) << 32) | ((uint64_t)pdev->bus->number << 16) | ((uint64_t)(pdev->devfn & 0xff) << 8) | -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 15:05:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 15:05:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443386.697928 (Exim 4.92) (envelope-from ) id 1oub1J-0006Bu-Pi; Mon, 14 Nov 2022 15:05:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443386.697928; Mon, 14 Nov 2022 15:05:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oub1J-0006Bn-My; Mon, 14 Nov 2022 15:05:09 +0000 Received: by outflank-mailman (input) for mailman id 443386; Mon, 14 Nov 2022 15:05:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oub1H-0006Bh-K2 for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 15:05:07 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b26b6d67-642d-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 16:04:55 +0100 (CET) Received: by mail-ed1-x536.google.com with SMTP id f7so17739596edc.6 for ; Mon, 14 Nov 2022 07:05:05 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b26b6d67-642d-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dT0DldhRQ1Rv2uvTCiK9GiQ3pfOMhNFKBi3Sli3lCEI=; b=oSUQZrv9hzfsoOUyzseFH/14zyaRLNg5wZqjx2R4YYXyhtTZqNqKWRLZnCebDESS1P sFiiNDjS/3GGGQoLFerTk9HlG73s6YRae6qNkzGtkvNnK4uQnOT/lSgazrw1mrBMFbNg iLB9E7N336YTkkCQUbQefZN4ni5G4GzwGwv/H2A6btAllY8VUif7gO9MM2J5dbwsPi5N 1uC4DGOtUYaL7XVAxtaKNAHGDIzLDXUyKtYr2GDIm8qDplPVqcEm7fRtoj4tq7EaieFK l6nssqVwco+WyNf04zmHkVT0SQteeV6g9le5YLJtRKMWsAoUIdgXxt3y7K2Oqw/97YU8 rFpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dT0DldhRQ1Rv2uvTCiK9GiQ3pfOMhNFKBi3Sli3lCEI=; b=iAYf+cIsR5EgHDD3Xxad774VUqofzqY0FSYzVVQeuM29mKMKFtze2Kz9HCvx8oY0SS M2bIPtTRdR31QxscQJ9mKoG8LGRf3aP7dju4/++Xuh2ph2K91epNRQMM/9i3j7cYsU/S GADlchrAr4puoPEPUCfG1RpnMhk4cfbhf3pnOGHeNdurg84W8oy+vU5K2/wh7+e122cI 6uasm+ZqjhGkuIUqwlZ5u5vGft9Kh0Fwsdar3A06gV0GWsvmrav/H4cS8x9pc4GfMNEF XPE0WT1DQPtK/mBXVgDNZk0/T5Vt/HYoxUfNv8DG9A5B91zVC+17ggh5/USdu2QH2Hjx z3MQ== X-Gm-Message-State: ANoB5pk/0EEFTqfZfHvK5xhkdmXT86JCP88eTQOnBNiioVveLFzQj2lb NNckbd7HOz3Y3H27ccdfwikqabWMcFn6SF6eEqNU8w== X-Google-Smtp-Source: AA0mqf44Yuq4D3K2d4jhT85UGH/dYLFM7bhtooOP18p5Pa89Wa77QMDwrfAzqJ2imCQav1H03TjykFIiINnfjJqn67U= X-Received: by 2002:aa7:d6cb:0:b0:467:e2dd:b593 with SMTP id x11-20020aa7d6cb000000b00467e2ddb593mr3721870edr.378.1668438305197; Mon, 14 Nov 2022 07:05:05 -0800 (PST) MIME-Version: 1.0 References: <20221022155120.7000-1-carlo.nonato@minervasys.tech> <20221022155120.7000-7-carlo.nonato@minervasys.tech> In-Reply-To: From: Carlo Nonato Date: Mon, 14 Nov 2022 16:04:51 +0100 Message-ID: Subject: Re: [PATCH v3 6/9] xen/common: add cache coloring allocator for domains To: Jan Beulich Cc: marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Marco Solieri , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Hi Jan, On Thu, Nov 10, 2022 at 5:47 PM Jan Beulich wrote: > > On 22.10.2022 17:51, Carlo Nonato wrote: > > --- a/xen/arch/arm/p2m.c > > +++ b/xen/arch/arm/p2m.c > > @@ -661,7 +661,12 @@ static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry) > > > > ASSERT(!p2m_is_valid(*entry)); > > > > - page = alloc_domheap_page(NULL, 0); > > + /* If cache coloring is enabled, p2m tables are allocated using the domain > > + * coloring configuration to prevent cache interference. */ > > + if ( IS_ENABLED(CONFIG_CACHE_COLORING) ) > > + page = alloc_domheap_page(p2m->domain, MEMF_no_refcount); > > Are you sure you don't mean MEMF_no_owner (which implies MEMF_no_refcount) > here? And then ... Yes. I've already fixed it in the v4 that I'm working on right now. > > + else > > + page = alloc_domheap_page(NULL, 0); > > ... is it really necessary to keep the two cases separate? Not sure. I don't know the reason behind the original code. > Also nit: Comment style. > > > --- a/xen/common/page_alloc.c > > +++ b/xen/common/page_alloc.c > > @@ -150,6 +150,9 @@ > > #define p2m_pod_offline_or_broken_hit(pg) 0 > > #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) > > #endif > > +#ifdef CONFIG_HAS_CACHE_COLORING > > +#include > > +#endif > > > > #ifndef PGC_static > > #define PGC_static 0 > > @@ -231,6 +234,14 @@ static bool __read_mostly scrub_debug; > > #define scrub_debug false > > #endif > > > > +/* Memory required for buddy allocator to work with colored one */ > > +#ifdef CONFIG_BUDDY_ALLOCATOR_SIZE > > +static unsigned long __initdata buddy_alloc_size = > > + CONFIG_BUDDY_ALLOCATOR_SIZE << 20; > > +#else > > + static unsigned long __initdata buddy_alloc_size = 0; > > Nit: Bogus indentation. I wonder anyway whether if wouldn't better > be > > static unsigned long __initdata buddy_alloc_size = > #ifdef CONFIG_BUDDY_ALLOCATOR_SIZE > CONFIG_BUDDY_ALLOCATOR_SIZE << 20; > #else > 0; > #endif > > or > > static unsigned long __initdata buddy_alloc_size > #ifdef CONFIG_BUDDY_ALLOCATOR_SIZE > = CONFIG_BUDDY_ALLOCATOR_SIZE << 20 > #endif > ; > > > +static void free_color_heap_page(struct page_info *pg) > > +{ > > + struct page_info *pos; > > + unsigned int color = page_to_color(pg); > > + colored_pages_t *head = color_heap(color); > > + > > + spin_lock(&heap_lock); > > + > > + pg->count_info = PGC_state_free | PGC_colored; > > + page_set_owner(pg, NULL); > > + free_colored_pages[color]++; > > + > > + page_list_for_each( pos, head ) > > + { > > + if ( page_to_maddr(pos) < page_to_maddr(pg) ) > > + break; > > + } > > I continue to view such loops as problematic. With them in place I don't > think this feature can move to being (security) supported, so I think this > and similar places want annotating with a FIXME or alike comment. So I have another change for that but I don't think it solves much. I've turned free_color_heap_page() into free_color_heap_pages() to free more pages with a single call. By doing so I can do the linear search once for each color: after finding the right insert position, all the pages that share the same color can be inserted one after the other. This should speed up the init phase, but it doesn't solve the domain destroy phase where pages are freed one by one. > > + page_list_add_next(pg, pos, head); > > > > + spin_unlock(&heap_lock); > > +} > > + > > +static struct page_info *alloc_color_heap_page(unsigned int memflags, > > + const unsigned int *colors, > > + unsigned int num_colors) > > +{ > > + struct page_info *pg = NULL; > > + unsigned int i, color; > > + bool need_tlbflush = false; > > + uint32_t tlbflush_timestamp = 0; > > + > > + spin_lock(&heap_lock); > > + > > + for ( i = 0; i < num_colors; i++ ) > > + { > > + struct page_info *tmp; > > + > > + if ( page_list_empty(color_heap(colors[i])) ) > > + continue; > > + > > + tmp = page_list_first(color_heap(colors[i])); > > + if ( !pg || page_to_maddr(tmp) > page_to_maddr(pg) ) > > + pg = tmp; > > + } > > + > > + if ( !pg ) > > + { > > + spin_unlock(&heap_lock); > > + return NULL; > > + } > > + > > + pg->count_info = PGC_state_inuse | PGC_colored; > > + > > + if ( !(memflags & MEMF_no_tlbflush) ) > > + accumulate_tlbflush(&need_tlbflush, pg, &tlbflush_timestamp); > > + > > + init_free_page_fields(pg); > > + flush_page_to_ram(mfn_x(page_to_mfn(pg)), > > + !(memflags & MEMF_no_icache_flush)); > > + > > + color = page_to_color(pg); > > You don't really need to retrieve the color here, do you? You could as > well latch it in the loop above. Yes. > > +static void dump_color_heap(void) > > +{ > > + unsigned int color; > > + > > + printk("Dumping coloring heap info\n"); > > + for ( color = 0; color < get_max_colors(); color++ ) > > + printk("Color heap[%u]: %lu pages\n", color, free_colored_pages[color]); > > +} > > + > > +integer_param("buddy-alloc-size", buddy_alloc_size); > > This would preferably live next to the variable it controls, e.g. (taking > the earlier comment into account) > > static unsigned long __initdata buddy_alloc_size = > #ifdef CONFIG_CACHE_COLORING > CONFIG_BUDDY_ALLOCATOR_SIZE << 20; > integer_param("buddy-alloc-size", buddy_alloc_size); > #else > 0; > #endif > > (Assuming buddy_alloc_size is indeed used anywhere outside any #ifdef > CONFIG_CACHE_COLORING in the first place.) > > > @@ -1926,24 +2106,49 @@ static unsigned long avail_heap_pages( > > void __init end_boot_allocator(void) > > { > > unsigned int i; > > + unsigned long buddy_pages; > > > > - /* Pages that are free now go to the domain sub-allocator. */ > > - for ( i = 0; i < nr_bootmem_regions; i++ ) > > + buddy_pages = PFN_DOWN(buddy_alloc_size); > > Any reason this can't be the initializer of the variable? Nope. The end_boot_allocator() changes are a bit messy. In v4 I'm doing things more nicely, moving everything in init_color_heap_pages(). > > + if ( !IS_ENABLED(CONFIG_CACHE_COLORING) ) > > { > > - struct bootmem_region *r = &bootmem_region_list[i]; > > - if ( (r->s < r->e) && > > - (phys_to_nid(pfn_to_paddr(r->s)) == cpu_to_node(0)) ) > > + /* Pages that are free now go to the domain sub-allocator. */ > > + for ( i = 0; i < nr_bootmem_regions; i++ ) > > { > > - init_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s); > > - r->e = r->s; > > - break; > > + struct bootmem_region *r = &bootmem_region_list[i]; > > + if ( (r->s < r->e) && > > Even if you're only re-indenting the original code (which personally I'd > prefer if it was avoided), please add the missing blank line between > declaration and statement here. > > > + (phys_to_nid(pfn_to_paddr(r->s)) == cpu_to_node(0)) ) > > + { > > + init_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s); > > + r->e = r->s; > > + break; > > + } > > } > > } > > + > > for ( i = nr_bootmem_regions; i-- > 0; ) > > { > > - struct bootmem_region *r = &bootmem_region_list[i]; > > + struct bootmem_region *r; > > + > > + if ( IS_ENABLED(CONFIG_CACHE_COLORING) ) > > + r = &bootmem_region_list[nr_bootmem_regions - i - 1]; > > If you want to handle things low-to-high, why don't you alter the > earlier loop rather than skipping (and re-indenting) it? Yes, you're right. > However, > considering that in alloc_color_heap_page() you prefer pages at > higher addresses, I continue to find it odd that here you want to > process low address pages first. It doesn't matter if alloc_color_heap_page() returns higher or lower addresses. The important thing is to create a sorted list so that min or max are easily found. Having a sorted list means that it's easier to insert pages if their addresses are always increasing or always decreasing, so that starting either from the head or from the tail, the position where to insert is found in O(1). If regions are processed high-to-low but pages of each region are instead low-to-high, the always-decreasing/always-increasing property doesn't hold anymore and the linear search needs to be repeated multiple times. This problem can be solved in many ways and doing everything low-to-high is one solution. > > + else > > + r = &bootmem_region_list[i]; > > + > > + if ( buddy_pages && (r->s < r->e) ) > > + { > > + unsigned long pages = MIN(r->e - r->s, buddy_pages); > > + init_heap_pages(mfn_to_page(_mfn(r->s)), pages); > > Nit: Blank line between declaration(s) and statement(s) please. Also: > Any reason the type-safe min() cannot be used here? Not really. I've changed it. > > --- a/xen/include/xen/mm.h > > +++ b/xen/include/xen/mm.h > > @@ -297,6 +297,37 @@ page_list_add_tail(struct page_info *page, struct page_list_head *head) > > } > > head->tail = page; > > } > > +static inline void > > +_page_list_add(struct page_info *new, struct page_info *prev, > > + struct page_info *next) > > +{ > > + new->list.prev = page_to_pdx(prev); > > + new->list.next = page_to_pdx(next); > > + prev->list.next = page_to_pdx(new); > > + next->list.prev = page_to_pdx(new); > > Nit: Several hard tabs here, and ... > > > +} > > +static inline void > > +page_list_add_next(struct page_info *new, struct page_info *prev, > > + struct page_list_head *head) > > +{ > > + struct page_info *next = page_list_next(prev, head); > > ... one more here (and at least one more further down). Sorry, I don't really know how I've added those since my editor only uses spaces... > Afaict you're passing a NULL "pos" in here from free_color_heap_page() > if the list was previously empty and page lists aren't simply "normal" > (xen/list.h) lists. I don't consider it valid to call page_list_next() > with a NULL first argument, even if it looks as if this would work > right now as long as the list is empty (but I think we'd see a NULL > prev here also if all other pages looked at by free_color_heap_page() > are at lower addresses). So perhaps ... > > > + if ( !next ) > > + page_list_add_tail(new, head); > > + else > > + _page_list_add(new, prev, next); > > if ( !prev ) > page_list_add_tail(new, head); > else > _page_list_add(new, prev, page_list_next(prev, head)); > > ? Note: I was wrongly calling page_list_add_next() while I'm inserting a predecessor instead. Anyway, yes, you're right about the fact that both next and prev need to be checked since both can be NULL. This is my last version of page_list_add_prev(). static inline void page_list_add_prev(struct page_info *page, struct page_info *next, struct page_list_head *head) { struct page_info *prev; if ( !next ) { page_list_add_tail(page, head); return; } prev = page_list_prev(next, head); if ( !prev ) page_list_add(page, head); else _page_list_add(page, prev, next); } > > +} > > +static inline void > > +page_list_add_prev(struct page_info *new, struct page_info *next, > > + struct page_list_head *head) > > +{ > > + struct page_info *prev = page_list_prev(next, head); > > + > > + if ( !prev ) > > + page_list_add(new, head); > > + else > > + _page_list_add(new, prev, next); > > +} > > This function looks to not be used anywhere. Yes. I've added it only for completeness. I'm gonna drop it. > Jan Thanks. - Carlo Nonato From xen-devel-bounces@lists.xenproject.org Mon Nov 14 15:19:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 15:19:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443392.697940 (Exim 4.92) (envelope-from ) id 1oubFD-0007ug-58; Mon, 14 Nov 2022 15:19:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443392.697940; Mon, 14 Nov 2022 15:19:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oubFD-0007uZ-2P; Mon, 14 Nov 2022 15:19:31 +0000 Received: by outflank-mailman (input) for mailman id 443392; Mon, 14 Nov 2022 15:19:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oubFB-0007uP-Pr; Mon, 14 Nov 2022 15:19:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oubFB-0008WA-Kt; Mon, 14 Nov 2022 15:19:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oubFB-0001Kj-4H; Mon, 14 Nov 2022 15:19:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oubFB-00011b-3r; Mon, 14 Nov 2022 15:19:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=87D9qNcAiH5FBNqS3eevj/WI0mjSYx/dC4+7MT9+UtE=; b=JYiokaz81KzAaMXKy10t30BS6p cVIF499M3VFoMOKY7QQ3SU4wpbwAXG8KdVCZM2NBxjD73zXee9uR40I3ueel04q78VPs3oBuyvJFG LpxO0Sdu3sXiaLJk3yHtvtRO8FDDkoJP3tsXUApB8TlAVBPlUOQL4P6qSIiPZuOEkQCg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174764: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:build-arm64:xen-build:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:build-arm64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=094226ad94f471a9f19e8f8e7140a09c2625abaa X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Mon, 14 Nov 2022 15:19:29 +0000 flight 174764 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174764/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 build-arm64 6 xen-build fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 094226ad94f471a9f19e8f8e7140a09c2625abaa baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 37 days Failing since 173470 2022-10-08 06:21:34 Z 37 days 61 attempts Testing same since 174764 2022-11-14 05:45:10 Z 0 days 1 attempts ------------------------------------------------------------ 1704 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 fail build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt blocked build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 162127 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Nov 14 15:32:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 15:32:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443407.697950 (Exim 4.92) (envelope-from ) id 1oubRA-000262-5R; Mon, 14 Nov 2022 15:31:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443407.697950; Mon, 14 Nov 2022 15:31:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oubRA-00025v-2l; Mon, 14 Nov 2022 15:31:52 +0000 Received: by outflank-mailman (input) for mailman id 443407; Mon, 14 Nov 2022 15:31:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oubR9-00025p-0r for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 15:31:51 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 72b84899-6431-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 16:31:48 +0100 (CET) Received: from mail-dm3nam02lp2041.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Nov 2022 10:31:43 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6665.namprd03.prod.outlook.com (2603:10b6:303:120::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 15:31:40 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8eca:f9cc:8bf5:83a6]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8eca:f9cc:8bf5:83a6%5]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 15:31:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72b84899-6431-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668439908; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=O7notWDT+KDnhlrQycg4nUgTl2NXmKwGHx4KmYADghc=; b=DXkG1rmnpXHMjGvK0N8ZntfYjVF6Z1MAXqjGRllbA5sCzcU45hJa36aQ B2uD+y1uEsEOuRcHUOgPXUXshHJH0hNgZ/kaf2dYBwZLq3QvDXVCQGckD 4T2RC7yabUeXcsCAK2nGfnY8xx/MHsgqaz6T/YlAl3iGPdbGsIEzDL7Yz E=; X-IronPort-RemoteIP: 104.47.56.41 X-IronPort-MID: 84368668 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:o6KtQ6pmANy3ZFfEYAmS2F1rVA5eBmLrZBIvgKrLsJaIsI4StFCzt garIBmFb6nZYDbwLdEjPty+8BlQuZSHz9RjTQBoqC49QiIQpJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHziVNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAD8vQCvagf+c+rGAEsVSlOYABcLCAYxK7xmMzRmBZRonabbqZv2QoPN9h3I3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jearbIO9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPO3kraA63gPDroAVIBtKW36a/9KLsEyjAu4BB x1L0woLkZFnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLkgJSCRQLuMvssAeTCYvk FSOmrvBHTVytJWFRHTb8a2bxRutPQAFIGlEYjULJSMH/t+lpogwhxDOS99LEaipg9mzEjb1q xiJoTY/gfMPjMcN/6S94V3DxTmro/DhXgMzownaQG+hxgd4f5K+IZyl70DB6vRNJ5rfSUOO1 EXogOCb5eEKSJ2IzyqERb1XGKnzv6rcdjrBnVRoAp8tsSy3/GKudpxR5zc4I1p1NsEDenniZ 0q7VR5t2aK/9UCCNcdfC79dwex3pUQ8PbwJjszpU+c= IronPort-HdrOrdr: A9a23:biJdp6/4DrfTiziJjjBuk+H2dr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrbX5To3SJjUO31HYY72KjLGSjgEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpgdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirCWekD+y77b+Mh6AmjMTSSlGz7sO+X XM11WR3NTij9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhn8lwqyY4xlerua+BQ4uvum5loGmM TF5z0gI8NwwXXMeXzdm2qt5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe B29lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQZo+dY7bWbHAbIcYa 9T5fLnla9rmJShHijkV1xUsZuRt7IIb0y7qwY5y5aoOnNt7Q1EJgMjtbAidzE7hdEAotB/lp r52u4DrsAwcuYGKa16H+sPWs2xFyjERg/NKnubJRD9GLgAIG+lke++3Fyb3pDZRHUk9upFpH 36aiIQiUciP0b1TcGe1pxC9R7ABG27QDT208lbo5x0oKf1SrbnOTCKDAlGqbrrn9wPRsnAH/ qjMpNfBPHuaWPoBIZSxgX7H51fM2MXXsEZsssyH1iOvsXIIIv3sfGzSoeZGJP9VTI/Hm/vCH oKWzb+YM1G80CwQ3f9xAPcXnv8E3aPiq6Y0JKqi9T75LJ9RbGk6DJl+GhRzvv7WQFqo+gxYF Z0Jq/hn+eyuXS2lFy4mllUBg== X-IronPort-AV: E=Sophos;i="5.96,164,1665460800"; d="scan'208";a="84368668" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GPlVpyr4E/8Hmgy+ZGNUAsrMtCNoyW1V8hvM3rFaeW3FrTdHORIN+LRFr4PMqmS8VhMYH2+CS6RLmqkiJBX8/7L5dxok2OtTuAagYEdSD2PpUpwkt3QZnLAkFc6/jerQ1fg80fjgQrCvHgrO/EaJFjOgoc0FNiacAhkkcCvaqvCU2FonsZuSTg8JeqdnAp3zmYJHAlTNOXi+JoSARYwqn/0zTqfB+656Nxhmu771bZDkiIHAEgXc90t9FDfpePapnx1lZ45wgoornHfbuVwNbjm+W2TowglZpdt1xAnGkxcAJ1bkL6sKyeN06OKHJEuFAjbWhV1aBAIvJZXRv+LZRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O7notWDT+KDnhlrQycg4nUgTl2NXmKwGHx4KmYADghc=; b=LK3mcmGyrV9UR/6wrZo1Vt3oaMYtdHIV0S4N+YJFlQPKHaScEtbO4n7pmo+diPXVBpgnWSIqx00Rv2UwgAA40WV1kq0narg9Pf0MdEoC2esHaLSVqF0XaAxYx9aoVP1gd6FUweey0tz3kHHaGgNvS9sMymNdhhfGNq4Jd91lWzU6BCDUrWliP/S/JtE5nBDvlJyW1yhi6GS78xYzHAUE9zsRaOmklQR0jVV4ob7CC5RnoAnSuo5X51Jn+f++FnUVfua9mhrnrmxOlSRcdafs3fJsrWj+2BXiPlPlIQ+MH/bS4AYkoAMylOnG16F3DCRSfbkCYLjm8sPxyH/650fBWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O7notWDT+KDnhlrQycg4nUgTl2NXmKwGHx4KmYADghc=; b=AAlInikRYdHsqhzFMjCViwAcOb9zl/QmBJF02IcI7TlKaj9XdmSLRqioIGnht7Ie0Ix6rveNu7+OEM+la11dI2rlBnmNsyBlT3I3ZMyyPjE4dMZCJ63gTfwEaojrvySQRg3wBxU1c+LGQkxrOhcIIe2EdBKL5ZdZfZ6y502pLps= From: Andrew Cooper To: Roger Pau Monne CC: Jan Beulich , "Henry.Wang@arm.com" , Paul Durrant , Wei Liu , Jun Nakajima , Kevin Tian , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Thread-Topic: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Thread-Index: AQHY8GkXjZEVf2M/t0iebvsck9V8qq44y+aAgACWeYCAAKSxAIAAA1KAgARrNQCAACX3gA== Date: Mon, 14 Nov 2022 15:31:39 +0000 Message-ID: References: <20221104161815.38007-1-roger.pau@citrix.com> <69841767-ccc4-5eeb-6e9c-d59dfb197ea5@citrix.com> <8e52a065-0141-f75c-03e8-e9ceb18a0aa1@suse.com> <4d0edf44-bb7c-85d9-0890-79c999428ef6@citrix.com> <1051eec8-8074-39e8-299d-a540d12bc997@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MW4PR03MB6665:EE_ x-ms-office365-filtering-correlation-id: 04839542-55ab-42fe-a4b7-08dac6555369 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ABi4t3cazHO0oeFfKaFzjTUyM0BnqLlpujgUFVEjtIBwLsKcu+1wO8aVehQy1qdN3cM6azkh7JuLzvGKNYaEk4q7GRKdv/zdu3CrKkcFWl1vVbgbVLVOTEzv9Gg0DZDr2gY6nSweomKzShwVSLXCp4Vn1oGBxAq6K9hPy7r0MD5gGlox/q6K8v9AeGn95RF6TH+aM1kL5dvfA57qF5yW/FqUB8NF44SbrXULSnQylNxaM2IFsFSH+BXeBgHnX2kLq9M7P5kSOcfOFZJqKVwex2mMwMVgraTXKiTa08u8D19fqxYMSNf/1VzlQBQp6SAIf3No25cFeEG52n7qegnAk5z45KdGAd6yASwKS6/maKYxVBweMcbQuvJrQOlKKSvZ2byGoXIoPQLix+X59LTE5ySk73uVhwGVkhsVuKsCDRtm68m38GvNojr3ic/tY3blkqVTs2m+QFM6wqpodhLee7Ik/m3BQDgwdXJuvyiIEXJXkCoOor0ysgF3OpMPtaCj0Odk7C8mq2TXDuktek1gj9YBY48ACS44MGkgt93VGmYkWB2LfasdjUXgW4BNuQ0lvlw0qKsK1XwJjlVlpsP15SoWSyp1tL0JD2V2nyzKOiyb3D6nrfgBIbdAlelOyPfhl9NBK8tSdm3WtgzqllLsaJUPBwPwBzVsTZa5jP1ijGhDZaQxNZeCzvX1CjAMz7C/Qam1hbFDwin5zcArOPWvA3GOwN81PVJPR+YJ3RQ1+Us9n9BM3gNqAnYj+tMRgARjpa87kEJ7nEMAt+7GCHnXlLo1lFB8/k9OadsA4mA92SfFAbSsAx6qDh60gGyR9jSi2injLzcXK7peKs2pHfffng== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(366004)(136003)(346002)(451199015)(71200400001)(478600001)(54906003)(37006003)(6636002)(6486002)(31686004)(5660300002)(186003)(8936002)(6862004)(36756003)(2616005)(6506007)(41300700001)(2906002)(26005)(91956017)(66476007)(53546011)(66446008)(316002)(66556008)(4326008)(76116006)(8676002)(64756008)(6512007)(66946007)(83380400001)(82960400001)(86362001)(38100700002)(31696002)(38070700005)(122000001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Sks3NDRGVVRZNHZ6VmhPcXF2b3FTTGYxK3hRM1ZVYkxiUzVzNEFHcms5bDQ4?= =?utf-8?B?S25CZWNJcUYrV0s4WnRKYjVmdExVZThEVTdMdmpaeXZjU01GVlFxOW1OU1do?= =?utf-8?B?aG55TS9sTnA3VnVTU3ByM29rVWIyNEhyL1VLaHBLZXVYeXdpUDMvMUlabzR0?= =?utf-8?B?UUNtZHBoZndXeG9Gc2ViZUhyRXlOU2svK1lENXcvTGRCVjVEVGdBUjNtVyth?= =?utf-8?B?dFg5VEk0YU9lQ3Q5czU3VGVhY0NNRm5YWjVpUnJ6OUtTYldIMkE5RGNRa1py?= =?utf-8?B?UHhoWTVjSkpURCtnOWJCUlhPZTB2d09VTy9wbUFqaCtJVFd3SGJkYkgwYVNC?= =?utf-8?B?djZtQVdKdHZHY0pMeWoxQm5PQThtbjFFWXZHMnNqQTBKMURiNEZqdUFuV3Nu?= =?utf-8?B?cERDRmRobTB5cEFJNHNXdXI1cHJiQjB2bVpPY2JwWXFQRGE5QmE3Sk5mbTEw?= =?utf-8?B?TDc1aVRvMGJCRmIvVWt5RGdFL0wyRDJJcGhPS3g5dVhlL3dBaFo4Mzk2U2xv?= =?utf-8?B?Y3preHJGQWNFOFVGZVArTThHTG1CTitNQWdad0h2UTVTTWV0TzFVWENFdWlm?= =?utf-8?B?YkdBaXhlb0Y1TXEzNlhPT1JEUkdyWDFScHVOYWg5aS9EZjd1RThKYmg3Z1c5?= =?utf-8?B?ZkEzeXlNNXdMRUhXdlZ4QlNaOXBrbXZnLzdvOVFiaytnZXBzTDVha3AxbHhN?= =?utf-8?B?d1FmQ1RsSGdGQTZwanZDTlN1eWJMZUJRQVBTNkdlNWtqR1BwRWp6TzhHWVRY?= =?utf-8?B?WWx4Wkd0V2FnR0VDajhYK3hLSW8xMVlYZUdReUV3cnRpa2M1NGJnNlV2UmpO?= =?utf-8?B?Y3I1YnRtTXkySCttNnJ4bDVldG1GUCtRQkdaUDhxVWxqNEEyUHFESXduc0FZ?= =?utf-8?B?SWpSdzRWNEVic1UvV1hMY3M2bm5yK3BXOE1aR2Z6My9uRHJLS1F5RWpMZFpz?= =?utf-8?B?UC9ZTnk4TisxQUgzRGowbG5EMFhlOEgyazgvVGE4VUQ4Tk9uekx0YkUzU0RJ?= =?utf-8?B?K1J2ZXhEYTY0dnp2ZUpDekx6NFZlUzFIY0dDZHd2VFFaYWJ5RzdaRzZyM21u?= =?utf-8?B?MWwycWVJTjIwRGxVUlVOYWVJa0o2S0VOcnZxdmZNY1ExVGV1ZHd2VkRTck1X?= =?utf-8?B?U21ydnJac3FmbjUxN3RiRzVWWGd0NHZhblNPNXlrZ3RWRktvbmVtaXl3Y1dC?= =?utf-8?B?YXlPS25RL1Qvb2pCZkhiRE04em91ZHhBaWh3ZnhDSFc0WTh0cmt1eXMyUWRR?= =?utf-8?B?YmI3UHdhZ3JxY09acmR5bXJMSEY2ek1Ibys1UVozd21GZWdjM2psaHpNcDJu?= =?utf-8?B?WitxL3JaUWEveFFwUCtxNkVqaThxb2FFQmc1cXJJWEJoVFFONzdBZGR5NFJW?= =?utf-8?B?L1JzSVNOaGlUYjNvY3MveXJkOXJqSTUra3g5SDhLTktnSnpnbUJkdUJvY0Fk?= =?utf-8?B?b09SY2JSR1VHOXJEMnJkRXMxV3BjOUlDQWF4aWRWY0JUZUViazRobWh0amJM?= =?utf-8?B?bjFFblVLejZzaWZDcTNDdGVWNDFzQllXZlB0dFI1TUlKajN3ZnQ0YjZhT2dj?= =?utf-8?B?OGZMTUNOZ0UyVkoxZDJNS3NONEordzlRWGprakY5aURRa1RHVjd3dGQ5Q1Y3?= =?utf-8?B?Z245dHR0bXhSUDZsTk1wcmdaL3FKaGhlY0tsL0puR3RheVdjWHQ1UWpBRmxo?= =?utf-8?B?bXVyakVJV0ZwU3V6ek9HUVVDMjBGcDRPOUFrTnJ5OU1QTFREWklUOVJPVlgy?= =?utf-8?B?eVp0RC9JdytEVUlYSDZqN0k1UHY1TVlwZ0VHV2p6dUZCQmpaeUhQRGZrNnRv?= =?utf-8?B?RFVCUjNhZUZmVmxaS3h2LytIejVVa3BwMVM2YjFKY1BmcGppYXlHZFBZMDI1?= =?utf-8?B?N3NlODhyWWpmdHRqQUZRditra3YyM2lETUZRZ0dlNHFFM3k4VUhsRG9Cdkdh?= =?utf-8?B?WmdOdE55b1J5RmJld2ZxeFpqQ3pMQTFsb3dwVytqNGdoQytSY1c5M2orR2hx?= =?utf-8?B?YlQvUlc3S2kxTXVrYlV6cm1jalY5QnY5bTFBcXMza0U1YlkrS2RMUlJOZDAw?= =?utf-8?B?azJzM2NacC9zWVhOVGdNWitJKy9NN0xhbkY1VlV5MjFlRjkvUk9GOG1YM0lO?= =?utf-8?Q?ppF6uQ5wMPZV+kdbYr4hkRJJ2?= Content-Type: text/plain; charset="utf-8" Content-ID: <40198E1F7F8A9441A7068918DBA64C7B@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1dcYkDJZAXIcN71EoGUT3hiwWIRk4sfyHmwdC1PH7C7FxD586XgJNQ1924vjr5NxqbJ0cYURswCrpG07FnNhxYzuNdUvsccu87C/Z1jw9mXNgf1dGXaYx7tVAUWOeZFEIgKff82VE1AddxLN7569si76me0TzmQJgNH6fXtReKdgpGZI36dBFMKfavz/tEi3os3IH2gjamhHyGTc4YUcxEAL2qN7uRYe86uh3vHrun/vwqDZDFm1V99XR82JwODp8J6CVncVbnvzaGI6K+KfdmWst9wys5MUBKYKjvJmLPEuYKamZo6Zn3I0aoA7LsNeGwVjPklICgdFEKgjJaQ43HzGRTQY8+0iX5xM47YFtI2LQG9ErgSyrahlIQnlGCzlpDOReY6Gwr34nIdXslcPNqo9PChxpmdbe8ew4HvnYso3R2wlk0i9FfzWgOuKdTaRE9+/0WrkbqASRsCFedZflqIrjgDlOXBU5ptwsIYL85nfViJyEUvHZueVukDZ1cwtuypkbQL2ASuC+e3DutEC/y0XYK8pGNAD2+0eyo0fr5q7G2wytRvl267h3/WM84EKKgq4BUfzCOI8PZc5mHu8ToE7Kh4nXVSKPZyG8LHuAT9h0x7oQ5QHaGMstuoKCDxaIW9Husj3O4B9kKt8HbGJWAPwj+u2d8L/e3VRflqa17K3WzjMPt0H5uhi3y3kZ7bwcQQJFzorZWctWvQ8YT2lslCOGyb6FDTwnd6vrp4KDMBV3SxZoopYXNKAZ4IlAfMyNNSJjVDvcph6t3Gqy8NqJMneVBd8lqSRK4Katjg8E8Zx5Mi/6v1AcCGKmvZ06giN7w2f90ccSUMABNdvUWW+WbAMiCgf2TRFIioSo6iYbqd6td2yeSlcoFP1eID0eyMw30wKuE87i5QE0Zhjh4ewWuCDPajdTZVjsVQB0zdmPgc= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04839542-55ab-42fe-a4b7-08dac6555369 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 15:31:39.9673 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QCwsiHIN1eVp0fNqzUCwCFeWMPV5QPei/uj1Lj16l5W5NGACyNrlsNY2I8S2oRyK8q2OJhd1q9DkQIG1YEr0shlVRqwctW1AOAxIPqIyUXQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6665 T24gMTQvMTEvMjAyMiAxMzoxNSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBPbiBGcmksIE5v diAxMSwgMjAyMiBhdCAwNTo0NzowMlBNICswMDAwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4g T24gMTEvMTEvMjAyMiAxNzozNSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+PiBPbiAxMS8xMS8y MDIyIDA3OjQ1LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4gT24gMTAuMTEuMjAyMiAyMzo0Nywg QW5kcmV3IENvb3BlciB3cm90ZToNCj4+Pj4+IE9uIDA0LzExLzIwMjIgMTY6MTgsIFJvZ2VyIFBh dSBNb25uZSB3cm90ZToNCj4+Pj4+PiAtLS0gYS94ZW4vYXJjaC94ODYvaHZtL3ZpcmlkaWFuL3Zp cmlkaWFuLmMNCj4+Pj4+PiArKysgYi94ZW4vYXJjaC94ODYvaHZtL3ZpcmlkaWFuL3ZpcmlkaWFu LmMNCj4+Pj4+PiBAQCAtMTk3LDcgKzE5Nyw3IEBAIHZvaWQgY3B1aWRfdmlyaWRpYW5fbGVhdmVz KGNvbnN0IHN0cnVjdCB2Y3B1ICp2LCB1aW50MzJfdCBsZWFmLA0KPj4+Pj4+ICAgICAgICAgIHJl cy0+YSA9IENQVUlENEFfUkVMQVhfVElNRVJfSU5UOw0KPj4+Pj4+ICAgICAgICAgIGlmICggdmly aWRpYW5fZmVhdHVyZV9tYXNrKGQpICYgSFZNUFZfaGNhbGxfcmVtb3RlX3RsYl9mbHVzaCApDQo+ Pj4+Pj4gICAgICAgICAgICAgIHJlcy0+YSB8PSBDUFVJRDRBX0hDQUxMX1JFTU9URV9UTEJfRkxV U0g7DQo+Pj4+Pj4gLSAgICAgICAgaWYgKCAhY3B1X2hhc192bXhfYXBpY19yZWdfdmlydCApDQo+ Pj4+Pj4gKyAgICAgICAgaWYgKCAhaGFzX2Fzc2lzdGVkX3hhcGljKGQpICkNCj4+Pj4+PiAgICAg ICAgICAgICAgcmVzLT5hIHw9IENQVUlENEFfTVNSX0JBU0VEX0FQSUM7DQo+Pj4+PiBUaGlzIGNo ZWNrIGlzIGJyb2tlbiBiZWZvcmUgYW5kIGFmdGVyLsKgIEl0IG5lZWRzIHRvIGJlIGtleWVkIG9u DQo+Pj4+PiB2aXJ0dWFsaXNlZCBpbnRlcnJ1cHQgZGVsaXZlcnksIG5vdCByZWdpc3RlciBhY2Nl bGVyYXRpb24uDQo+Pj4+IFRvIG1lIHRoaXMgY29ubmVjdGlvbiB5b3Ugc3VnZ2VzdCBsb29rcyBl bnRpcmVseSB1bm9idmlvdXMsIHNvIHdvdWxkDQo+Pj4+IHlvdSBtaW5kIGV4cGFuZGluZyBhcyB0 byB3aHkgeW91J3JlIHRoaW5raW5nIHNvPyBUaGUgaGludCB0byB0aGUgZ3Vlc3QNCj4+Pj4gaGVy ZSBpcyByZWxhdGVkIHRvIGhvdyBpdCB3b3VsZCBiZXN0IGFjY2VzcyBjZXJ0YWluIHJlZ2lzdGVy cyAoYWl1aSksDQo+Pj4+IHdoaWNoIHRvIG1lIGxvb2tzIG9ydGhvZ29uYWwgdG8gaG93IGludGVy cnVwdCBkZWxpdmVyeSB3b3Jrcy4NCj4+PiBJIHJlZmVyIHlvdSBhZ2FpbiB0byB0aGUgZGlhZ3Jh bS7CoCAoRm9yIGV2ZXJ5b25lIGVsc2Ugb24geGVuLWRldmVsLCBJDQo+Pj4gcHV0IHRoaXMgdG9n ZXRoZXIgd2hlbiBmaXhpbmcgWFNBLTQxMiBiZWNhdXNlIEludGVsJ3MgQVBJQyBhY2NlbGVyYXRp b24NCj4+PiBjb250cm9scyBhcmUgZW50aXJlbHkgdW5pbnR1aXRpdmUuKQ0KPj4+DQo+Pj4gSXQg aXMgInZpcnR1YWwgaW50ZXJydXB0IGRlbGl2ZXJ5IiB3aGljaCBjb250cm9scyBFT0kvSUNSIGFj Y2VsZXJhdGlvbiwNCj4+PiBhbmQgbm90ICJhcGljIHJlZ2lzdGVyIHZpcnR1YWxpc2F0aW9uIi7C oCBUaGVyZSdzIGEgZGVjYWRlIHdvcnRoIG9mDQo+Pj4gaGFyZHdhcmUgd2hlcmUgdGhpcyBsb2dp YyBpcyBhbiBhbnRpLW9wdGltc2lhdGlvbiwgYnkgdGVsbGluZyB3aW5kb3dzIHRvDQo+Pj4gdXNl IGEgVk1FeGl0LWluZyBtZWNoYW5pc20gZXZlbiB3aGVuIG1pY3JvY29kZSB3b3VsZCBoYXZlIGF2 b2lkZWQgdGhlDQo+Pj4gVk1FeGl0Lg0KPj4+DQo+Pj4gSXQgaXMgbm90IGJ5IGFjY2lkZW50IHRo YXQgInZpcnR1YWwgaW50ZXJydXB0IGRlbGl2ZXJ5IiwgaW50cm9kdWNlZCBpbg0KPj4+IEl2eUJy aWRnZSwgaXMgZXhhY3RseSB0aGUgbWlzc2luZyByZWdpc3RlcnMgKG9uIHRvcCBvZiAidXNlIFRQ UiBTaGFkb3ciDQo+Pj4gd2hpY2ggaXMgZXZlbiBvbGRlcikgdG8gbWFrZSB3aW5kb3dzIHBlcmZv cm1hbmNlIGxlc3MgYmFkLg0KPj4gU29ycnksIHNlbnQgdG9vIGVhcmx5Lg0KPj4NCj4+IFRoaXMg YWxzbyBmaXJtbHkgaGlnaGxpZ2h0cyB3aHkgdGhlIEFQSS9BQkkgaXMgYnJva2VuLsKgDQo+IEkn bSBub3Qgc2VlaW5nIGhvdyB5b3UgYXJlIG1ha2luZyB0aGlzIGNvbm5lY3Rpb246IHRoZSBjb250 ZXh0IGhlcmUgaXMNCj4gc3RyaWN0bHkgYWJvdXQgYSBWaXJpZGlhbiBoaW50IHdoaWNoIFhlbiBo YXMgYmVlbiB3cm9uZ2x5IHJlcG9ydGluZywNCj4gYnV0IGhhcyBub3RoaW5nIHRvIGRvIHdpdGgg dGhlIEFQSUMgYXNzaXN0IEFQSS9BQkkgc3R1ZmYuICBJdCB3YXMNCj4gd3JvbmcgYmVmb3JlIHRo ZSBpbnRyb2R1Y3Rpb24gb2YgQVBJQyBhc3Npc3QsIGFuZCBpdCdzIGFsc28gd3JvbmcNCj4gYWZ0 ZXIuDQoNCkFuZCBub3cgaXQgaGFzIGEgbGF5ZXIgb2Ygb2JmdXNjYXRpb24gd2hpY2ggbWFrZXMg dGhlIGJ1ZyBsZXNzIG9idmlvdXMuDQoNCj4gQWxzbyBzZWUgbXkgb3RoZXIgcmVwbHkgLSBJJ20g ZHViaW91cyB3aGV0aGVyIHRoaXMgaGludCBpcyB1c2VmdWwgZm9yDQo+IGFueSBXaW5kb3dzIHZl cnNpb24gdGhhdCBzdXBwb3J0cyB4MkFQSUMgKHdoaWNoIHNlZW1zIHRvIGJlID49IFdpbmRvd3MN Cj4gU2VydmVyIDIwMDgpLCBiZWNhdXNlIHdlIGV4cG9zZSB4MkFQSUMgdG8gZ3Vlc3RzIHJlZ2Fy ZGxlc3Mgb2Ygd2hldGhlcg0KPiB0aGUgdW5kZXJseWluZyBwbGF0Zm9ybSBBUElDIHN1cHBvcnRz IHN1Y2ggbW9kZS4NCg0KSXQncyBub3QgYWJvdXQgd2hldGhlciBhIHZlcnNpb24gb2YgV2luZG93 cyBzdXBwb3J0cyB4MkFQSUMuwqAgSXRzDQp3aGV0aGVyIHdpbmRvd3MgdHVybnMgeDJBUElDIG9u Lg0KDQpTaG9ydCBvZiBoYXZpbmcgYW4gZW11bGF0ZWQgSU9NTVUsIG9yIGFuIGFic2VuY2Ugb2Yg YW4gSU8tQVBJQyAobmVpdGhlcg0Kb2Ygd2hpY2ggd2UgZG8pLCBndWVzdHMgd29udCB0dXJuIHgy QVBJQyBvbi4NCg0KSSBrbm93IHdlIGhhdmUgdGhlIG1hZ2ljIGhhY2sgZm9yIElPLUFQSUMgd2l0 aCA+OCBiaXQgZGVzdGluYXRpb25zLCBidXQNCnRoYXQgb25seSBnb3QgZW51bWVyYXRlZCBpbiB0 aGUgWGVuIGxlYXZlcyAoSUlSQz8pLCBzbyBvbmx5IExpbnV4IGNhbg0KcGljayBpdCB1cC4NCg0K VGhlIGhpbnQgaXMgc3RpbGwgdmVyeSByZWxldmFudCBmb3IgYW55IHZlcnNpb24gb2Ygd2luZG93 cyBydW5uaW5nIGluDQp4QVBJQyBtb2RlIHdoaWNoLCBhdCBhIGd1ZXNzLCBpcyBhbGwgb2YgdGhl bSB1bmRlciBYZW4uDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Mon Nov 14 15:53:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 15:53:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443415.697961 (Exim 4.92) (envelope-from ) id 1oubm5-0004oo-12; Mon, 14 Nov 2022 15:53:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443415.697961; Mon, 14 Nov 2022 15:53:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oubm4-0004oh-UM; Mon, 14 Nov 2022 15:53:28 +0000 Received: by outflank-mailman (input) for mailman id 443415; Mon, 14 Nov 2022 15:53:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oubm3-0004ob-9r for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 15:53:27 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062c.outbound.protection.outlook.com [2a01:111:f400:7e1b::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78f7c7db-6434-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 16:53:25 +0100 (CET) Received: from AM0PR04MB4899.eurprd04.prod.outlook.com (2603:10a6:208:c5::16) by PAXPR04MB8238.eurprd04.prod.outlook.com (2603:10a6:102:1bc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Mon, 14 Nov 2022 15:53:23 +0000 Received: from AM0PR04MB4899.eurprd04.prod.outlook.com ([fe80::3342:8b15:bc9b:3d47]) by AM0PR04MB4899.eurprd04.prod.outlook.com ([fe80::3342:8b15:bc9b:3d47%7]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 15:53:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78f7c7db-6434-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q6TEHFbJzBod3q8943dNCoY7HinDI2SCtjIZKU1dxwf7I0NQFHguhZ8nFdD5K2um9lwXOOIOhJ0Kl+RXpAIGVDV8WE2gZgNy/0B6L+vR15OG2LWC3WHKChxTldKXIVkc/TLZk9ILg1PazvJ64sS4D+gkFwm7lClbc+a7vaA4QukHEqgh1res9I6RCTuiHFwH2tRHyqPDLX9x9TrTN2ASgSo8S3o1ZcPslYAlUr1HaiI5uE1z1mo+hJ6/rWdwQP7HlnOFA3DjYgm+Ie0Wdi9BKwK2azOk9UtR+bcbrgFBZBpuhHj3Y/cH788U6/gDQ9soikvolzcAhhoGus+gBSdoHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G5xEF9WofVQd1cS4v3OPFN8SNzwMy+Tm4AXP1Fjabsw=; b=EDsOdaxgsPLzJ99h0YSLIH58tSPcvjtRqSBOCX8oP0TMv/1H+ypRnPbKXh+du2ZXKOfmNq2gCvtdJaefPZeOH3IlSfoblPLxLLUWncCw0WV6WNJVuWwXtIwqKQ7rBdJTLqznzmX4yPrxCpx5R0MHDwsHwuncDDAfDm7EuxZcmXdEEfSuGB9Fj80IfD8G+gTDc33MMl63bVlEGmYrP6slBFfomHArVJ4y97H1UfOHHpLQnEfPep8B0elTM2AJOEK/ojECu179B5ilmo1O7vC9DTLWjW0N4D9VffxeQ8CpnAllbJiUTu7DJQfOOCVLiReUz0UHz1PE02PcMOg8WevlEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G5xEF9WofVQd1cS4v3OPFN8SNzwMy+Tm4AXP1Fjabsw=; b=JoQIYENObUyUPzFCxxG7eaSt4rywovl9rxcZ63fI/MZTtqYoUu6bG+PjzpdEuGpGO1W/97540B09hvK8nFxvptKY5l4s+TkdzLjlrZjVqJJTfRCQUVBRO2HQ5d3dIfAalDfRuH/oNnk+OvHEqTX6HWZMC9HQlYMx3mqXa1NuL8WsTVVrqGMvqeV+ZYMbvV+cXng6sAiUCU4Cnfb3ugEwCTBkUF6xvmaIEQPYuZfNvsvxpul87X973socsZETCtDgBZQ1LtWBBNbOl0io1tfca+drd89D4jywjmTZQuvNyXmzgGeApKs/cnbpdzRe2wQSxPyd5akhCAOjT04FzYPLKw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 14 Nov 2022 08:53:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: vnuma_nodes missing pnode 0 Content-Language: en-US To: Jan Beulich , Henry Wang , Anthony PERARD Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , xen-devel References: <2046b5fb-2533-02fe-69e8-f46174cf825d@suse.com> From: Jim Fehlig In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0175.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::12) To AM0PR04MB4899.eurprd04.prod.outlook.com (2603:10a6:208:c5::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB4899:EE_|PAXPR04MB8238:EE_ X-MS-Office365-Filtering-Correlation-Id: c8bc7a8e-77b9-4f09-7420-08dac6585bdc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wLTT5tplE2Upfs3gm2N9I3zfMycrFpXFPcR8XngMaQb03DcmSDoDvW/9Zqx1n4prj/EWLhK10GJ6gNVBIsWKapgxdzsE7S7pyb9r2KsI3aYkvYZZ2Njir42Jp5i62jWpmXpTzpe//ccuifqHnvuJGsO0Nnwq/YvKywuTJaLV8yu3Zi+oNtv91cHAW7PQkN6hHGtiLIJiv3soVK46DAx2SdPCcrRnnSbe5plC67Lg/SssS2zFPy50R0NDbEk2MGnmHPZ5PB81vURBZu0sd+2m6DFPUGidCC1jmVBQnXnPJkjf568UBYkPGq3c5BFaSsO6vyIcAVcY4fQAcum4n26DoOqhzasGkvr0yCZH81/mEXmiJ7SkWPKwJnwz4Js/cSl+GqwfTCfXGoOYuEhL9hOFMaGiU7w2cbC1wVs6khfJMHeRFr7YUNOSoaF2fvfQ3y4EYYHdjT0OalBTjam801RiB4z4/f2KFuiijMSkQD+bWiyjPX0kkQd6O5VrwUxSAVBHiE6PHju6G0TGdnOj2QxUHPFDYRY6mBPg7Viq9VlZbzxwxKAdrcSXZWRT+mFEXalxyHa48imcYM6onsXyi4vz79WEj7G1+2P+352djln20nVC0ffhfTdq24+wmmlRaDHSekvp/hs25dOR4qA7/gqZG8pZRlzS8EeoXM2S9Q8QHaJx/t88lSas9k5JReds8CdsgBWWKy2wrcUr9/Ts3oj6GNM5DjHrHgbRmIJXvxPPg1bgLjWrqjc3+bdlJh2Gz0H0VdnSFKjNe2tKuBGMWWZP1VWH4qYbDT4i0O0D+qcWbBY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB4899.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(396003)(136003)(376002)(366004)(451199015)(54906003)(66556008)(86362001)(31696002)(316002)(4326008)(7116003)(8676002)(8936002)(41300700001)(36756003)(5660300002)(66476007)(66946007)(2616005)(38100700002)(186003)(83380400001)(478600001)(6486002)(6512007)(6506007)(53546011)(6666004)(110136005)(26005)(2906002)(31686004)(66899015)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXJ6eFk5OHhwSnFOclE0SVgxL1lLdlduM1M3ZlpESE1uVERvWCtZVlJnN0tJ?= =?utf-8?B?S2pSVVF2UFJ5c3J5VVBocmNCYnlST1BUeFRlWjg1ZktTQnB6aWxMSVkzOEt4?= =?utf-8?B?NUloMjNJRXhjTStzeFJUczVFaWNXMWpHaE5qTFFNNnYwVE8xRlVRdFRLUm5E?= =?utf-8?B?VmR5dkNRK2kyeUNycWUxL01MYWN0OFR4b3VGWUxuSlZ3YXV4b0NGd213QjlK?= =?utf-8?B?a0ZjTUlJQ1QvOFovbzBjMjFneXEvYmpSczN5SE4xR3VIT0hnT0paWFYvMUFn?= =?utf-8?B?S0Zsc2ttc2lxOVlFTVFBcE5zemlEc0ZocENpbDJOYnpzRFZZMWNiOG5WeDBV?= =?utf-8?B?cXlhTDZvOVNtRXVBeDZsdzlDWU1xYndFMGpjMnpwYSsvMXN5em45YU9qSFhv?= =?utf-8?B?elBEYldQY3o2bHRmQXNab3prY1kwNk93NDVkcTR2Q2N0M3FYdlNKY09SNk8r?= =?utf-8?B?VmhVcjR3bEczZm40RmhrU3pYN1dGc3Y0MWxmWTBldWZtakl6alpWbkd3ZDlh?= =?utf-8?B?YkpUeFNGUDh3Q3FOaVgzaWU4MXhUeVJvaHI1WVk5R2NlZHl3RTFtczNkbGxt?= =?utf-8?B?ZmpJb3EvV0VLR0lRTDBCYmJNYXVVRW8yN0F6RlFnVUlZR3RoNHJleDIrdVBJ?= =?utf-8?B?OWlabllud3d6MVM2ZjRuaDZaeU9EeWVLU2U1NHZpQ3JVc3Y2MHJLTEZnSXZ1?= =?utf-8?B?QlFCUGhWM0t0NmxlQTNOM3dOLzFHcnY1SERPaFFkTGVnQVJpdmFrWml5bFNG?= =?utf-8?B?aGgxaVViOXF0YzZjZTdzS1RFakRsVVpIamNJQ0xDajdlbjY3MjZ6YU1WM3BC?= =?utf-8?B?NjVRaThSMXlpUFVKdmlZMUFKNWR5R2c5OVAydFVnRjFRRWEvWGdzdDJCMmtt?= =?utf-8?B?TE1Ubk1ydzJKWjN0eE4xQWVmcGw4QXM0TkpDMnZZczRYVFpqSmZnblo3dmNv?= =?utf-8?B?NTMwWTNMalVsamcyTVRNTjlxd2Q0MFRwY0swZ3RWZ1pKRXozcEhBaEpuNzVH?= =?utf-8?B?Z0VUcjFGeUZKdzhHT3J2R3hkeGZzN2orVG96d0JqbDFTMHVEN1RXQ0VhWVVx?= =?utf-8?B?ZFozOG9UbkI5eGw0K2xKWUg1eHpLY2MvYXFlVDkvUFlwc1JhWDhoZGRva2hv?= =?utf-8?B?YWJnV2NSV2VDakRjeWtIcE5zaVl1bWdLSnUveDQ1T000UUpQRFEvaXRYbGRS?= =?utf-8?B?ZmVmR0VUTUdRY1VHUzkrdmNpdFU4amNGUG9SbDRNVi8vVzhGRjhNZFh3NTlm?= =?utf-8?B?WWRyOHpuUERJL0wza1ZTbGppYWVBNUVFUkJUeXZPbU1yb2JyUVhnMmF2a2JZ?= =?utf-8?B?djJVdGJ1SnlFTm5jUUFEYTFRZmNuNmlRYlNwZk9nS3VtQTlYNm4vTUlabE5h?= =?utf-8?B?QjZrb3p4VnFLTXBWbUtYUlZVL1U4ZkMwbDcvRGRvVVVYa29HVm5Ea3g2aFVL?= =?utf-8?B?ZG9NWnNFdzc2dThVZkNVQ0JLQXYwSFlvRCt6VnpZU1FDa3JlNVlTengwaDhj?= =?utf-8?B?MFV4eVZMZ1BySVJtSTFaWVJEc1dwK3RTZkYzZkZGVk12WkkvblpJRXhJR0J2?= =?utf-8?B?KzQ0bXN2MnFtRWpVU2k1eUNMa2VxcDFRK1NrRjlyZEtZTVhUakdwY3M5WGpV?= =?utf-8?B?OW9halNCU3FWTnpiSnRvb2pPVkF2TVZ6UmxoWlpKRVlIVmZSODcyODRIano0?= =?utf-8?B?SG9qc0tUcEVnc0tWNUxvTHNQQnh5YUVVY2x3cDN5OXJrcFV2dXEyeUdkVDZn?= =?utf-8?B?RjBrVk40dlZzbVF0SVgxR0QrUHZZUDlKSUF3MnJ5MkhNQmtVUFNDOHZPanVH?= =?utf-8?B?VzI2TW5oNFlXQWZsSXJkVCsrRjBnVm95T3NJSnRnelpJS1JXMFhDWGV3M2My?= =?utf-8?B?Vjl1Ymc2R29xWHpQZWw1dTUwa2doVmV1alRWSk40ZmJpR1I4cGNwYnlISEcz?= =?utf-8?B?aHArTjZBZ1VPVzViQ0E5U0VlUDFJWjd6d0FyUS9teXJqWGl4aElMQUozWm5E?= =?utf-8?B?TGpXUGVjbTJDSmNsSlZ0RFFpaW94eDdUSzdRNHBJRGdaYnB0VGhEelZjVjlL?= =?utf-8?B?TWpRQk1NOTJGWlJIdHZiSkRFZGY1Vk0xb2dkZ05RVUxiWHJnazhQUEw2ejNm?= =?utf-8?Q?JboAWW+JbxX/XoAcXGp7N4lxh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8bc7a8e-77b9-4f09-7420-08dac6585bdc X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB4899.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 15:53:23.0067 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MIVi3gBuqIPNmIBg0zjPDxG3o5VLwiiPRxLaUw8BsDr3YgyWptn2/bf7kaNcFJq3nctHOG7oE0WysqKaw+5ZWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8238 On 11/14/22 01:18, Jan Beulich wrote: > On 14.11.2022 07:43, Henry Wang wrote: >> Sorry, missed Anthony (The toolstack maintainer). Also added him >> to this thread. > > Indeed there's nothing x86-ish in here, it's all about data representation. > It merely happens to be (for now) x86-specific data which is being dealt > with. > > Internally I indicated to Jim that the way the code presently is generated > it looks to me as if 0 was simply taken as the default for "pnode". What I > don't know at all is whether the concept of any kind of default is actually > valid in json representation of guest configs. 0 is definitely ignored in the generated libxl_vnode_info_gen_json() function, which essentially has if (p->pnode) format-json I took a quick peek at the generator, but being totally unfamiliar could not spot a fix. I'm also not sure how such a fix could be detected for testing purposes by libxl users like libvirt. I.e. how to detect a libxl that emits `"pnode:" 0` in the json representation of libxl_domain_config object and one that does not. Jim From xen-devel-bounces@lists.xenproject.org Mon Nov 14 16:03:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 16:03:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443420.697973 (Exim 4.92) (envelope-from ) id 1oubw4-0006yr-Vc; Mon, 14 Nov 2022 16:03:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443420.697973; Mon, 14 Nov 2022 16:03:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oubw4-0006yk-Rx; Mon, 14 Nov 2022 16:03:48 +0000 Received: by outflank-mailman (input) for mailman id 443420; Mon, 14 Nov 2022 16:03:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oubw2-0006ye-Po for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 16:03:46 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e93a800c-6435-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 17:03:44 +0100 (CET) Received: from mail-mw2nam10lp2109.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Nov 2022 11:03:39 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB5792.namprd03.prod.outlook.com (2603:10b6:a03:2d5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Mon, 14 Nov 2022 16:03:37 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Mon, 14 Nov 2022 16:03:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e93a800c-6435-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668441825; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=D59OyGxJSlfZw/EWAPVGKJlVvF/NuGqf/Wp7wERk2wQ=; b=OMQj5HeqmRHlvshnlqdXnLswfTBIhTsuzlL8QMv6mK5gwJixFq05FHfM ajkDc893Ag4i/6wF+m6R2HYQOEc0MccbZrEJH6Hfgc3iRrBeOYKhApNpV LYbBLqgofPnoutOOun4/PTWFghyB2SzKMivgsJyZakcuCDyCRb+ab1uOF A=; X-IronPort-RemoteIP: 104.47.55.109 X-IronPort-MID: 83849292 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:BQ71k6qQ/eIMGopEHi0IOnRG8kxeBmLvZBIvgKrLsJaIsI4StFCzt garIBnSb66CNmv9Lo92YYiy/BxXvsXXxoU1T1Fk+Xw2RihB+JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHziVNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABkXXDmJvv+2+ZuEWORxxd49NZPvM6pK7xmMzRmBZRonabbqZvySoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeWraYKEEjCJbZw9ckKwv GXJ8n6/GhgHHNee1SCE4jSngeqncSbTCNlCSOzip6QCbFu7mWEwITwWT1+Hntq4iR7kBMsFK 3JMw397xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L8wwufHHlCcTdHZ/QvrspwTjsvv neRls7tLSxitvuSU3313qiQhSO/P24SN2BqTS0ZS00D6trqooA2hzrOSMpuFOi+ididMTL93 TGM6jQ/jrM7jMgX2qH99lfC6xq8q56MQgMr6wH/WmO+8hg/dIOjf5av61XQ8bBHNonxc7Wal H0Nmszb6f9UC5iIzXSJWL9URODv4OuZOjrBh1IpB4Mm6zmm53+ke8ZX/S16I0BqdM0DfFcFf XPuhO+Y37cLVFPCUEO9S9jZ5xgCpUQ4KenYaw== IronPort-HdrOrdr: A9a23:qcXTdK31Gl/6RJBygxkLFwqjBdVxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6 Dsm/av6gDQMEj+Ka+Adwo4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/PwmE0gwYWzZvx65n1W TeiQT26oiqrvn+k3bnpiLuxqUTvOGk5spIBcSKhMRQAjLwijywbIAkd6yesCszqOSP7k9vtN XXuR8vM+l69nuUVGCophnG3RXmzV8VmjXf4G7dpUGmjd3yRTo8BcYErYVFciHB405lmN1nyq pE00+QqpISVHr77W/AzumNcysvulu/oHIkn+JWp3tDUbEGYLsUiYAE5ktaHLoJASq/woE6F+ tFCt3a+Z9tABunRkGcmlMq7M2nX3w1EBvDak8euvaN2zwTp3x9x1tw/r1qol4wsLYGD7VU7e XNNapl0JtUSNUNUK57DOAdBeOqF23kW3v3QSOvCGWiMJtCF2PGqpbx7rlwzvqtYoY0wJw7n4 mEeE9EtFQ1Z1nlBaS1rdN2Gyj2MSaAtAnWu4NjD8ATgMy4eFOrC1zNdLkWqbrhnx1FaferH8 paO/ptcorexCXVaMF0NjbFKulvwEklIbMoU+kAKiOzS+LwW/rXX7/gAYDuDYuoNwoYcUXCJV ZGdATPBax7nzKWsznD8VTsZ08= X-IronPort-AV: E=Sophos;i="5.96,164,1665460800"; d="scan'208";a="83849292" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=csjXnPVLcRCX7mrLW322tC533iak/72JRWx9aZBwwdeedVrFEEJCPteq47E75WV0rI0GWOtFjanUTrttVljo8yEgbUZo5r0CEy1uti67iOF7jsrWIKS6MeZJR7YZVi2eaBwl2haOITidsHZ19K64ASEl3gq5qGSPXYPIA4yBaTlXz8n5i2ntR/XHai5M7HDygOQkwbeEPj8TLP3upGbPcUglaARMXfnZmmD4E4jaAialcXRvzTYCwe6i66Iw0guUgpyXVhV7ZTNOEhfA1PnpATb7cZqi8yCWqYae9XBmj07vOT5acqlZuGAEKTS6iprvfKCOUbcDmnIxBtLPx0AGxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=38LJPAxnV34lWMQ5oUKrBWC+5t5gji8ZMChY5vETx9k=; b=EA2ccuxw3ydwLqed+63LRLy4Na9Q/3utANizJ6fTO4JO81B8nbl4YGc05kGyhBL+jhjYujqjy+ht1NZp73NAXAV4wQpdVJw4/ujePJwQFoFh/32NdDcwfIONgSnPhD/YF7YdjeXEm5j2P7TXUUldDCA2BW/TpCf4/eRfHWhvvASc2utElTM9+qG1YjKiupgI/FnzgMD75zLmeGXs124MNZ0GWqW+FgXkFp0Dzv/GxI8+HKxCDZzGPQAFWVAMiTanEaR+Nig/r2dTXiByqNQmflfMjZVj64RamZ6g3d0+Vnjq3FIkOLcxu7hJ3ylQN9Drkqq2MMRZGNy0o6myCQ5fHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=38LJPAxnV34lWMQ5oUKrBWC+5t5gji8ZMChY5vETx9k=; b=cJyYzZjRLDDPXTALFmNfScQm0S2xyODqbh+LZNTeaF35q81jHri4TaWCtPb241BqZjXtgvUvvO4/QDNgyv/waJ90tKmqDeelWwLPpXGB6MduLYZl1Gezegs5dNg2frOqLHNEqXx1EcuiGviYudPBzhafl4WqpZAnvQfSMjJPU0s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 14 Nov 2022 17:03:28 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Jan Beulich , "Henry.Wang@arm.com" , Paul Durrant , Wei Liu , Jun Nakajima , Kevin Tian , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options Message-ID: References: <20221104161815.38007-1-roger.pau@citrix.com> <69841767-ccc4-5eeb-6e9c-d59dfb197ea5@citrix.com> <8e52a065-0141-f75c-03e8-e9ceb18a0aa1@suse.com> <4d0edf44-bb7c-85d9-0890-79c999428ef6@citrix.com> <1051eec8-8074-39e8-299d-a540d12bc997@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LNXP265CA0030.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::18) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5792:EE_ X-MS-Office365-Filtering-Correlation-Id: 27b9bbe6-9e31-4ec9-548c-08dac659c8ac X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BbhLCDW/2kuWa+2rWEFBjQc+1CTJeIlPXG3Xwh7dIXEfWIdafZzQLq96zzrIxG7yH/baOiTh2LY+yenrEo5gAeqxXgpVhF4AZz0mrV5BmO/e4gnkhUheSEjqSs6PJTpI4BJ6eTsK/75k450LvY9MvNMZvxCMqxigpQlfBJH9+D9i5m8UQwhxGSXq60DtGh1bMiwLb7jcXTEfyJ9WR77+Z+CuKRwoLqA/JS1LGFcHHlD8EWjdWJ8+1fzIBxoTz5CKfU/zzSE8p7ZdQt/Bgnpi9ybli8XO57Q6aTgQfxbuZK8qd7tjUhzDUFwyweZZoErj/yPVP4tOgqFbiE7OjQ+w6+XP+MwoXmAFXiS04Olev4VqabYJuJxcgipJJEZEmN4aFuzM0cBeT6PFAMbm9iljZdnodtYImxEsxR9J3ssXFRBzw3dMxABfrtuK9ZFdRJmySDho4y2xiaPYFBBMwReG3WDOCEIdMQqC5as341ZkA3ouwyJV09ajSnZM7IwJkb3pqgt8MhW7ChZrHGIUjuKv0CImYck3qh+MBHsm2BeCTFMt7DzvVuzk3JSZ1KfmZPnaj5+SfgGg/bpjcleG+EvdBliKyaQU9iY53bn5kFYGc6k+Msk6+EG3uDucC6Uqz58jWfgfcj9t0a7PcRzZYepv5o6GLUEDoPOinsKfL5hUxqn5MFth/GV+prDzCk+vHWauridF0aVdXuRRgPnuHPEPMe7Ouf/YXqbyu0I1g3GMoYg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(136003)(376002)(396003)(346002)(39860400002)(366004)(451199015)(33716001)(6862004)(8936002)(41300700001)(83380400001)(186003)(5660300002)(26005)(316002)(85182001)(9686003)(4326008)(6512007)(478600001)(6486002)(66556008)(38100700002)(66946007)(966005)(53546011)(86362001)(2906002)(66476007)(6666004)(54906003)(8676002)(6506007)(6636002)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkxkallhakZ4NE55MDEwcVo1K2t1UGErdUpmVHlJbUsrdGtBN3RBZkhQRE9T?= =?utf-8?B?bFhvbXl1OFZ4aFJUM0RyaERNbnRBaUo1SzFCSG0wZXFMODYzMXNPa0NGTXlI?= =?utf-8?B?U2M0S3ZOakRENTMzYzZGQVR2bC9MbWI2Z01vMXpvaTNEMzhqcDBCWUd5cGVH?= =?utf-8?B?bkQrNWtmbFJPMGdUeXhwbHlzNHZidUFHSktrcU1sWE5ENmJoWlpTU1VHOXVD?= =?utf-8?B?VUc4UUNNbzdRSDB2TTFGakV5ZVZmMm5tY2I2SXBEUytuU1phdm5DbW0rc3RY?= =?utf-8?B?RW9EMFJCU1Y5blVWbFRaR2NqVE05M0ROL0dCb1RDVTNPUGtsbzI1cG1nakZh?= =?utf-8?B?SHBBYjNNcEVGS0V0Rk03UW9EYXJxWk9mSGlSK3hWeWNXQ2RrNzlmTStzY0ZU?= =?utf-8?B?ampZekN0Ukx0TEVMWE9zY05PWUxKSk9YZDZHblAyQzdaTU04UUZKaE01Nm5F?= =?utf-8?B?THVBWnJUZStxK0xPTjN5aU5WQXhzN2prZ080QlZhTUQ2ZGFuWFQ2cStmWFdR?= =?utf-8?B?R0hjUFhtUndkK2NMWERXN09KTzlUdmxqemNCSGhZREhpK21DdWNGTStJM1V0?= =?utf-8?B?ZStDQW1icnpRRlN4VWlXbWphSVo2RThBcGdTanJrcWtVd2FYWWZKNXBVdlo5?= =?utf-8?B?V29vR21hUWsza01DVmdTVDhPbWxROXZsNitWVU96bVNTYmpiNXhManFwdTNQ?= =?utf-8?B?cUxHRGY4eUgyUzNzQUQzN0VqR2VnL2FzMXo5U2p6a0owZEhNVGRqekRjQ1NO?= =?utf-8?B?cFd5a3ZQVmtWQ2I5N2NnMjl5MzBhRjZhTWt1djF4dm1STWpSUmtNQ2RueFlL?= =?utf-8?B?KzZRZW9pNFY5ZndvN25pNU52QnZPdi9NWEhmcGFPMThnL3JxZzN6eDJRcXJa?= =?utf-8?B?akdnYmNjeUhyalJCUndta0NVZ2p1d1FrODlJYjkwcnp1K2F0QUZtT282V2pE?= =?utf-8?B?VlNJYkd1c3lPZ2VsbmRPdGlUQVBRVGF1cDg2WmRpRFJhYXp3UkpBS3JlcXZn?= =?utf-8?B?T3piL3kxVUlpOWUvRXdnNmF4UTk3aGZQbWxQOTNXS0xvcTQ3dk0xcGFTZHJr?= =?utf-8?B?MjlVL29vY21ocWRSeU0vdUpmcjZmR2JWakphL1FYRkorWFFla0FDd3RLZnY3?= =?utf-8?B?RFBobUxiNHIwcXRTVmY0TnJ6NDZJQmhWRTY1U2Zham9jN0RPUVRMbHVxTUwv?= =?utf-8?B?aGZsN0ZBWHVFOWE0elBsWEZlVDFMa1ZoS0ZEK0Urbk5ZdU90aWdkL1dlek5m?= =?utf-8?B?VzRzSmlUYU1Bc1dieXoyRUNIcStVSXppaGloenJhalpGWnZYVU5hMlRJSC94?= =?utf-8?B?K3JyYVpaWHRYRzdwWFNkaVBJazJ1U1ZXOU9SSzRNN3JZWlFTc0phY09hZWNN?= =?utf-8?B?RTVYTjBzRWxIYnFoOXYveUF2S0NGTW1ERE1HT0NMYVVhZjUxVkFUcVFpMGlv?= =?utf-8?B?M1hZUFYrVlNlY2dmdlpXYUszWDR3dVJRbGtWZGF1Qy84N280Qi96OERyUDFS?= =?utf-8?B?QmdpT3JCK01LR2dnV1V3QW1VNVdTQVhNdjNDY0wvTkQ5K0lxMkhOczdWNDgy?= =?utf-8?B?b3BxWllmM3VMTHFGVnRuM3gySWhqQmYrelBIcEpYSkZXWVNvSE40elA2R01u?= =?utf-8?B?NUVKbGltU29XYTlmbDVDbnVucjcrNjRqaEFXMmJkd2Q5RHpwcVg4Y2t0ZHJh?= =?utf-8?B?RDJYRDlLWSsva3RCNW51OXVtenlrdzBtamh3dndwTUxlR2l6YlJtVHRKWHdT?= =?utf-8?B?Ymx1UktjcE5zYmJmN09oT1FBZmkzRGVyNVFINFhieHZkdGVZUGpaOGhvOTQ1?= =?utf-8?B?dUZnRFg4Y1FyQzd6QTloS2NRU2tVdzNrSWREVjJ2d25hR2QwWHhuZU45bHBW?= =?utf-8?B?TnYzbVdWRzg3Q2FnQXI5c3ZFSE4xbnJ1cXpTY1Y5WEN6SEg4YXJWeUoyVGwy?= =?utf-8?B?a1dvTlRwb3J3ZXlNZVRkc2NKREh5aUd6Z0hVblFvaUFEanZ4MVJRVy9RQ3RW?= =?utf-8?B?bG84WTE1Z2xtT0hUTTdDaWFkK0ZOVWpHcnMrcUNFTjhlOXFjYU0rMEhpWmRn?= =?utf-8?B?aWZaaDdIaEJ0M1ViY3JpUzFSU21WdndWQ042MmVZakk0QXdGU2p2ZWhRSmtk?= =?utf-8?Q?XNfVtd+iMHRn5TqOL+StVaePF?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: wH3gLWOdGjA35PL535k2jkDdt0kL4FYikftDk/w4BmkH4abuCx94RoHdWhkYBDxacTL8dNb6tuvb9YrgOKoOdASqMSVLCAgE6m8VbBk/rOfGrk51J0OjIrR9OFmSFPhuYnH7RvbK+1P8+rOCD3A1hm4bun8kw1tLigcPLZ65aeqnyKh8nN+Us2bNzaABnQCz8FIoxdSZhYASRSPqU+g9U8UdjkQ3th0nFq8XLidt48xXkY8OYCOECz7fw0WRdVvXo5TFPQV90vVWKc0oWOP3m93VBB7VyVGPCMQ3rrQ7BQFonvzEPIhk95nNJhqmHQDRR4GGkfpXwe95ENDFOgKF+ilma4+ttumKsrh/pWwa39f06O/zQaBq23fL+dzVNQ0Lu2F2pNPKFqeGMJGDVJZ7jxnfRshB4RePNsLjHD5NXg+sAEPdJVX/Xq4xZsJ91qemVjQL0C7U7Hqy+50hCSDikSMGiyJb9/1Qx5zlwJkZmyLqTG48n+vueYbLh1By2Ql1wkbgbILupm9LMbz7llQti4nhkcEVjhvf+U8p1jiTwI528QByRCnwocYMx+3V9o0dRqX73I8pu7m4okGVAYSJFceHkoJ5R5xlIQTbzSilu7DaVAv4O2rrS5oU2HAK6lpNRDsMYiYYnnkSMdq5cYR18Wrcerx9ZGxOBHcORHiddiQ7usUfoWHjWDRxkJJg4TrJw/6DD3rl5mtVnhk1W7zUfU41Tvpxl5Z2D3etpM0cHacglME3tJSwCknTCDg6HS/DxW6OGjRhbT+hrH6AEoKURdeiGxgA2pyHe74XAy9L66SqabPb95lL77po3nJYqWUM4+bi+Iq5VCk2933OcOxwItlS8Yk3yh413e7L/CHRnjNAArx/dnDXlqHyZ4bMAbinyXbPm8YHUyQ/AkLaTYBqQ0XFjpGost3zZzKpOVVF3i4= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27b9bbe6-9e31-4ec9-548c-08dac659c8ac X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 16:03:37.0608 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vgw12X1wz1tpT498WBm8bXO4kbI/fxBxw703GfAQbhhyUwMWe8g4vs4v1Ek6bEo4dhr4CTZqoXScsuZBz2wupQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5792 On Mon, Nov 14, 2022 at 03:31:39PM +0000, Andrew Cooper wrote: > On 14/11/2022 13:15, Roger Pau Monne wrote: > > On Fri, Nov 11, 2022 at 05:47:02PM +0000, Andrew Cooper wrote: > >> On 11/11/2022 17:35, Andrew Cooper wrote: > >>> On 11/11/2022 07:45, Jan Beulich wrote: > >>>> On 10.11.2022 23:47, Andrew Cooper wrote: > >>>>> On 04/11/2022 16:18, Roger Pau Monne wrote: > >>>>>> --- a/xen/arch/x86/hvm/viridian/viridian.c > >>>>>> +++ b/xen/arch/x86/hvm/viridian/viridian.c > >>>>>> @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t leaf, > >>>>>> res->a = CPUID4A_RELAX_TIMER_INT; > >>>>>> if ( viridian_feature_mask(d) & HVMPV_hcall_remote_tlb_flush ) > >>>>>> res->a |= CPUID4A_HCALL_REMOTE_TLB_FLUSH; > >>>>>> - if ( !cpu_has_vmx_apic_reg_virt ) > >>>>>> + if ( !has_assisted_xapic(d) ) > >>>>>> res->a |= CPUID4A_MSR_BASED_APIC; > >>>>> This check is broken before and after.  It needs to be keyed on > >>>>> virtualised interrupt delivery, not register acceleration. > >>>> To me this connection you suggest looks entirely unobvious, so would > >>>> you mind expanding as to why you're thinking so? The hint to the guest > >>>> here is related to how it would best access certain registers (aiui), > >>>> which to me looks orthogonal to how interrupt delivery works. > >>> I refer you again to the diagram.  (For everyone else on xen-devel, I > >>> put this together when fixing XSA-412 because Intel's APIC acceleration > >>> controls are entirely unintuitive.) > >>> > >>> It is "virtual interrupt delivery" which controls EOI/ICR acceleration, > >>> and not "apic register virtualisation".  There's a decade worth of > >>> hardware where this logic is an anti-optimsiation, by telling windows to > >>> use a VMExit-ing mechanism even when microcode would have avoided the > >>> VMExit. > >>> > >>> It is not by accident that "virtual interrupt delivery", introduced in > >>> IvyBridge, is exactly the missing registers (on top of "use TPR Shadow" > >>> which is even older) to make windows performance less bad. > >> Sorry, sent too early. > >> > >> This also firmly highlights why the API/ABI is broken.  > > I'm not seeing how you are making this connection: the context here is > > strictly about a Viridian hint which Xen has been wrongly reporting, > > but has nothing to do with the APIC assist API/ABI stuff. It was > > wrong before the introduction of APIC assist, and it's also wrong > > after. > > And now it has a layer of obfuscation which makes the bug less obvious. Still, that's not an argument as to why the API/ABI is broken, just a remark that the current usage here needs fixing (which it does). > > Also see my other reply - I'm dubious whether this hint is useful for > > any Windows version that supports x2APIC (which seems to be >= Windows > > Server 2008), because we expose x2APIC to guests regardless of whether > > the underlying platform APIC supports such mode. > > It's not about whether a version of Windows supports x2APIC.  Its > whether windows turns x2APIC on. >From my previous conversation with Paul I got the impression that Windows would choose x2APIC based solely on the CPUID bit: https://lore.kernel.org/xen-devel/2c2d8b2b-e607-6d9d-b991-d1c065aac95d@xen.org/ > Short of having an emulated IOMMU, or an absence of an IO-APIC (neither > of which we do), guests wont turn x2APIC on. > > I know we have the magic hack for IO-APIC with >8 bit destinations, but > that only got enumerated in the Xen leaves (IIRC?), so only Linux can > pick it up. We don't have the hack yet, just the CPUID bit reserved. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Nov 14 16:05:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 16:05:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443423.697984 (Exim 4.92) (envelope-from ) id 1oubxx-0007YQ-Ab; Mon, 14 Nov 2022 16:05:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443423.697984; Mon, 14 Nov 2022 16:05:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oubxx-0007YJ-7T; Mon, 14 Nov 2022 16:05:45 +0000 Received: by outflank-mailman (input) for mailman id 443423; Mon, 14 Nov 2022 16:05:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oubxv-0007YD-KB for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 16:05:43 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20617.outbound.protection.outlook.com [2a01:111:f400:7e1a::617]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3021d7ac-6436-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 17:05:42 +0100 (CET) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VI1PR04MB7101.eurprd04.prod.outlook.com (2603:10a6:800:12e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Mon, 14 Nov 2022 16:05:39 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::48df:9a8c:c706:36b5%3]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 16:05:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3021d7ac-6436-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kxqbWpoGNwn7PxE2cKKZ1J9Y7BXT9Pogb6VoeZ1fxSM4vUKHC18aPtGmzJGfJNvPogYYr4Lx9B2KQAoUtpvJ+T65940KXAw0jKKhV+LIR+JDsO23WGro/buda8VUe5gjbv5Zscv5ujlzIqTpPLC7J2ooCzFu+BEEM9Nhl+lI6paME5tNeR9sO2VodC37bUurAkCCkaIjeDi2DikSwzqXZOCMxtp+/XrGPQ/15S3GFAZ77tcpVIatb0A0k9LQTvPc+b08WVdgdYLJ457qgMdp68xiPp3nQ00pUJTSC5XBF0Ts/6yeBxq+QUxKUAJV/n8FzNgIkxsMncY61422gppAYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gQgseoSQVd1e05VTTeEWL0ZknjU3TTN/8sH+WnMVZHE=; b=F3ns03ZGBDtYF1x8r2Nc2wbvfCNDo9StUgWC4f2FpCiRQb8ShVailTmZGlS5f2TLr7Zjlua4Mzz946hHD2fxHFgaUrErNBTPr/gdq1qwSqMG8hrKhl6VrAzSVccrgmo0Kq3V5Qe0rmDRlSNz378Yq8jO4MoXbubtuYPcni2bbEiLCqmE88nM5lFni9OvFOBX0Yvfjf0VMAcx101FU7NLg2onOWCkWqRVTxJLxtevDUBIjQjXK+DucNn/kUsOkA5Yq/QfZtgP0e+SLEyZuNeZ1wZFLGyoOl6W3XGHzl0AGiEEQWI/ccoJMZV8SzXoBqQL05/OmkHRtOJGD+xJFO95+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gQgseoSQVd1e05VTTeEWL0ZknjU3TTN/8sH+WnMVZHE=; b=rF3kSUgyZQYFOul2iRdMt20/1afDCmB1L6RCSuUntIZQB6TiTaDHO3GLCJxiRhfvro9b1s+IqmKIOPadbA2mCzpkUsLixBWyuu91ckqppQ/hck6mk5R2I+cksB5Fn4uacescs/RgSXSttbRDS6rxZsmchSUPOmsgTxjGk4qyjvqZbr5EScb4DMdf8aHDLamaHlqRW2liX7T/QY3wAPngpwulet/2cMiIg+I+XZS09/vnMbcp9Zl/uHXFH02a7jqxoCmwgNYEPLUo6arSgSD1LnROnhD8ALghjpHCnGyS9ZUnrnwYAwzhTgFtRerZmMUXST9/EiYwpdIoLKkzWtzWQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7a7a032a-9be7-b011-dc88-3c4e7f253ef6@suse.com> Date: Mon, 14 Nov 2022 17:05:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Content-Language: en-US To: Luca Fancellu Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , "xen-devel@lists.xenproject.org" , Anthony Perard References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> <8632FA78-B316-4866-8E78-D4CD127C8602@arm.com> <7d56c33d-4b03-9aa1-6abc-45a8ad41caca@suse.com> <2E0BFEFC-5BEE-4F8B-BD9E-94CB9A5B2BC9@arm.com> <9CE2A214-2D64-4BEC-A78B-393BF7AEDD9D@arm.com> <826eb0df-fb52-fa25-c908-977285a6ec8b@suse.com> <282F1A51-D143-4F23-BEF6-43648505E7D9@arm.com> From: Jan Beulich In-Reply-To: <282F1A51-D143-4F23-BEF6-43648505E7D9@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0119.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::17) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|VI1PR04MB7101:EE_ X-MS-Office365-Filtering-Correlation-Id: 8474952d-8c59-44d7-53f8-08dac65a12af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uNoRIBZ3xtfpdTdMV5A0O5Zl54BSYReceVnp0qQ0j0tLQfJB20yxVDeAvXUHbxC5RiRrVFd56tTOheoZ4GsOm4cZ3PxlgmWNH+O7Prn0eiVUYpzOIVH+Te+S1SUnkqNoLxv1BAc9u1CT1m5og9vLO56bJcvGKGiYk+iWQu3U3z+ROjyaTRNUMOheDyMFK4mIX1Qv9yTUsNby6C43Xo/NqykwomZzxDfZxfEMauc06hbzocXoaK8ZZVYNhkllRXhQ0/Xibrk1pSWTSZfKjYOPeTdJ0h1HqSm+7kGBvQSxOnokpe/HiGI+W/8nCr+wESSgeFhr7U1N9zCOPqs5H2QPe59Me3pdPVFRyw+mmeLZ+sdVZZukIb49XRtcPvLa35ug2MvHxJhZBZgCqcSTY6Hw0U7tD13lQ+zfDT/meh4l+FEJoOwZyZajvNyQJjyuNrCkCUt6vpyy3hkZd29jJV/2BbhyMiqiwJT14cYwUih3KPtrWDoETrjB5BlLXx6M1Ig+M9AuBtmC64JVavQcwEbBHmanw7rqCie/vD6+u337vieSHtMPHiKJSqfc7WT3/5HA0zzoIBWViylbTXBzzx6eEiBNlbhsuz43aAg13Klo5AJAdy8l6NvO0iePuRqQb71ryh9gUyus1U7MwHE41S90sTa9wN3FyFctiDlE8LzD+gzx0R6xUv9hngvSoLm3z9QF5j3mAGMBCkEfsLU2GGVufFxq1Tk+kYGl7F9DbvmMRAQM3MbD/DAqvpEpPLwT1DKykmvsDLwXUL+Ztl1S9+jlYv6Gt6FSgOcRCTDRN9bxm9A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(346002)(366004)(376002)(39860400002)(451199015)(66899015)(36756003)(31686004)(31696002)(86362001)(2906002)(7416002)(8936002)(38100700002)(83380400001)(2616005)(186003)(6916009)(54906003)(316002)(478600001)(6486002)(8676002)(53546011)(5660300002)(66556008)(66476007)(66946007)(41300700001)(4326008)(26005)(6512007)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTBDQzdTUEx6UUlBT1FwVDkvdWpvZVRYU2NyK2ZtUXRld0l4MEp3UlVCb3l5?= =?utf-8?B?WVJpQlZNRTFSbGVpLzRLRklPMnZaRm1XTmJDcWNzRG1XS3pFQ1dmSTV6Lzlp?= =?utf-8?B?d0RLM3ZOS2tlVUYyaG5mQzNPYmlZeFhkdUR1UkFlQUx5YXZGRysrVS9sbFJt?= =?utf-8?B?OHB5c1VEbXNvem95TGN2dU5oMWptSmdReGRRK0laN2NESzNManBtYjVScGFw?= =?utf-8?B?aGpsZy9XdlZaN2Y2OWRTZ3FjdWxMdmpYMWF2NEVVVytLWGRHTzQrbS9QNi9n?= =?utf-8?B?Z1hkcGlNeWJUS0cyYW5rRnFkTTNiWkVmMGg1alIxWDdFN1p3Mm1rWHgycDRw?= =?utf-8?B?RGpVWW5nV3pmNS9jZWdjMUwzM3M1bjBwRUtzZmtBMmRmK1kvTTVWQkFRVlNW?= =?utf-8?B?N0lFNGMrR2lLRVltc0krSjFHcTExS3NpSnRocUZ5eU5pU2NiK3pZK2gvRFF4?= =?utf-8?B?RDlYOTU2a24xNHc1bHVBL3ArU1FIbmdDK25VL3J0bHFkUW1JRWpZQ2JhaG1q?= =?utf-8?B?ZkY4NlVCUU1NV2FEUmpmN1VnWlp2cmcwVGtJVlQ5dS81Rys1dDlVNEs1VXRn?= =?utf-8?B?dTlZQWtjUGczZlcyOTgxYUJuUVhrOTVVMVRMZ1dRNzBaTzlmQi9halJwVlRO?= =?utf-8?B?eEhpdWc2dGkyK2NoeFBFS1dWMmQwdGZtTWFDbjdLZ3RVcnpucFp2djlKcUY4?= =?utf-8?B?V3NrSG12c1RpOGk5bVhPQkJPakRUZm1DSFhKZitMd01MM0luMUZYVTcrbWRV?= =?utf-8?B?RCtkSFV0ZURHL01vTzJ3ZndFUk1FMVpLclJEcTlMVzI2clhLYnk1cG5OUExE?= =?utf-8?B?UnY1NGkyRmVEV0lKUWdRR2htbFNnRmVDajdoUmhoTmNMcUd6aG9VZE40bXlr?= =?utf-8?B?MUJQek5yREdmK0k4bVdBVm91eHBWSHAra1I4T2Y2QUNSU3J2SC9tUkFNUnZB?= =?utf-8?B?d1FzOGJ6Y3dwOG5TWVArcjVjRWFQVVJ1NTBBQlRScGx0b1QzcVJmRmhKVXZj?= =?utf-8?B?OVd0L1ZveGlEeG1lTG53STFlN2JtdmVDUkgwS09XSkRWS2lhVWhzYjlwWmI4?= =?utf-8?B?RXZ4ME1zRGFMVlJhOTBqNEU5Y01xMTVjM2l4ZnZsUUk2alJnZXlXVUtLMlpN?= =?utf-8?B?RldDT1BoOVBGenBmdkxoeXhRMWFRSlVxZXJ2U1FQUk5HQy9SNlZLUnRqcnVh?= =?utf-8?B?Z3cvMlE3a2VGcXZmS0JMaThmT3RkOStIcE1Dam1rdjhzTzZtVXJ0cFV4aEhz?= =?utf-8?B?WFFVTGFzeFljSmlxSXR5azFUVHBaN1hnS1FqK0ZCNFh2T0RFeGQ5U1FQOWVi?= =?utf-8?B?NlRHYVJERndqVTZ3bWxxMVpnc3J2T0IxMDBQYVFuWkZ2eXphOTQ2MVpWaU5N?= =?utf-8?B?OFl5MEh5dXEvTVM0RXE4U3dGV3VPQXFNVGNyNmVIclR2VloxQWxXcWxIWGZI?= =?utf-8?B?bjNPWWt2RDJBcSt5QnlHdUdkZHVGUHgyUU1rVjltWTRma1I1eENiWTF0Qk4y?= =?utf-8?B?ZzlPbVNrWDc0blFId1BpV1JXcEdzbS9lbUdCMVdpVDJVc1lEd3gwUTNYTGd1?= =?utf-8?B?RnRxWWkvaHBuN213cVIya2gxTWozTlEwNHpBNTZiSklGWm4rd3hIRThhK28w?= =?utf-8?B?NWQ5aTB2R3JJZThjOTVlLzZnUGFKSG55QVBMNi9DVldjU2N6aHkxYTlFMmRz?= =?utf-8?B?bEV0K0pTNnJWR01FbFcrZzhLWTNaVW9ITnBIcmhBaFJTdE9Bb3VHcHllVUxh?= =?utf-8?B?RUZjWlN1MjUyWk0xeFkxS1V2QWNSNWNTbzZQVk9penlGYXdFY2RaajlXako1?= =?utf-8?B?MVNycjBRYXVwS3NNcjlCNzVvdmMwMVBCT1k3NlhiSGEyd3dXKytyVzlzaTZp?= =?utf-8?B?eUFldGJMMVozbTRwbXpLcTh4M1lZaHZWd0VCVU11emdONmFnbHlRYnpLTnNm?= =?utf-8?B?cXhKN2FsVlB5Z1JJYVNRK0ttZXEyUWpJbFlFMGFLeTVLODRCZTkySndrRHdP?= =?utf-8?B?eTdiYzJjYVVVWmRsVEo0MVFMQTBuM2dXWXRiVm1Ca3RLc2hGeDBscWRMQ2d0?= =?utf-8?B?YlNlTmk4N0hsUXR6ZjFmMnpRSGxSN1haUXM4UHZ4L0c2cCszVmhvdWZzbm8x?= =?utf-8?Q?oM9+AQgrY9PhD22Mgvl8ttkgq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8474952d-8c59-44d7-53f8-08dac65a12af X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 16:05:39.0120 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I/BnQXlh2QPA043YsW0VRp6/f0/tSja43QkwrpQKHC3Ug8SC2YivcVsfO13gTq5k6mQ42llfDNgdfhCfHA3uTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7101 On 14.11.2022 13:30, Luca Fancellu wrote: >> On 14 Nov 2022, at 07:30, Jan Beulich wrote: >> On 11.11.2022 21:52, Stefano Stabellini wrote: >>> On Fri, 11 Nov 2022, Jan Beulich wrote: >>>> Did you consider the alternative approach of copying the tree, altering >>>> it (while or after copying), running the build there, pulling out the >>>> result files, and delete the entire copy? Such a model would likely get >>>> away without introducing surprising make rules. > > This approach does not work because the report will contain a path that is different from the source path and > some web based tools won’t be able to track back the origin of the finding. > > e.g. /path/to/xen/arch/arm/ is the original file, we run the analysis on /path/to2/xen/arch/arm/, > the finding is in /path/to2/xen/arch/arm/ but the source repository contains only /path/to/xen/arch/arm/ Simply run "sed" over the result? >>> Another, maybe simpler idea: what if the build step is not a dependency >>> of the analysis-* goals? >>> >>> Basically, the user is supposed to: >>> >>> 1) call analysis-parse-tags-* >>> 2) build Xen (in any way they like) >>> 3) call analysis-clean >> >> Well, that's exactly what I've been proposing, with the (optional) >> addition of a small (shell) script doing all of the three for ... >> >>> Making steps 1-3 into a single step is slightly more convenient for the >>> user but the downside is that dealing with build errors becomes >>> problematic. >>> >>> On the other hand, if we let the user call steps 1-3 by hand >>> individually, it is slightly less convenient for the user but they can >>> more easily deal with any build error and sophisticated build >>> configurations. >> >> ... convenience. > > For coverity and eclair, it makes sense, these tools doesn’t require much effort to be integrated, > they are built to intercept files, compilers, environment variables during the make run in a > transparent way. > > So the workflow is: > > 1) call analysis-parse-tags-* > 2) build Xen (in any way they like) > 3) call analysis-clean > > > If we think about cppcheck however, here the story changes, as it requires all these information > to be given as inputs, we have to do all the work the commercial tools do under the hood. > > The cppcheck workflow instead is: > > 1) call analysis-parse-tags-cppcheck > 2) generate cppcheck suppression list > 3) build Xen (and run cppcheck on built source files) > 4) collect and generate report > 5) call analysis-clean Which merely makes for a more involved (shell) script. > So let’s think about detaching the build stage from the previous stages, I think it is not very convenient > for the user, as during cppcheck analysis we build $(objtree)/include/generated/compiler-def.h, we build > $(objtree)/suppression-list.txt, so the user needs to build Xen where those files are created > (in-tree or out-of-tree) otherwise the analysis won’t work and that’s the first user requirement (stage #3). > > The most critical input to cppcheck is Xen’s $(CC), it comes from the build system in this serie, the user would > need to pass the correct one to cppcheck wrapper, together with cppcheck flags, and pass to Xen build stage #3 > the wrapper as CC, second user requirement. > > After the analysis, the user needs to run some scripts to put together the cppcheck report fragments > after its analysis, this step requires also the knowledge of were Xen is built, in-tree or out-of-tree, so > here the third user requirement (similar to the first one, but the stage is #4). > > In the end, we can see the user would not be able to call individually the targets if it is not mastering > the system, it’s too complex to have something working, we could create a script to handle these requirements, > but it would be complex as it would do the job of the make system, plus it needs to forward additional make arguments > to it as well (CROSS_COMPILE, XEN_TARGET_ARCH, in-tree or Out-of-tree build, ... for example). > > In this thread the message is that in case of errors, there will be some artifacts (.safparse, modified ) > and this is unexpected or surprising, but we are going to add a lot of complexity to handle something that needs > just documentation (in my opinion). > > If the community don’t agree that documentation is enough, a solution could be to provide a script that in case of > errors, calls automatically the analysis-clean target, analysis- will call also the build step in this case, > here some pseudocode: > > #!/bin/bash > set -e > > trap [call analysis-clean] EXIT > > [call analysis-] > > > This script needs however all the make arguments that we would have passed to make instead: > > ./script.sh --tool= [--dont-clean-on-err] -- CROSS_COMPILE=“[...]“ XEN_TARGET_ARCH=“[...]” [others...] Well, of course the suggested script would need to be passed overrides you'd otherwise pass with "make build" or alike. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 14 16:26:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 16:26:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443472.698012 (Exim 4.92) (envelope-from ) id 1oucHT-0002wL-FD; Mon, 14 Nov 2022 16:25:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443472.698012; Mon, 14 Nov 2022 16:25:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oucHT-0002wE-Cj; Mon, 14 Nov 2022 16:25:55 +0000 Received: by outflank-mailman (input) for mailman id 443472; Mon, 14 Nov 2022 16:25:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oucHR-0002vS-WE for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 16:25:54 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 00cb1b01-6439-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 17:25:52 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00cb1b01-6439-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668443152; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=EmRRNlGPHCoyom+uz6vH9tu3bzMfmb+Pg8n6Agr25vs=; b=SPDzUYG5daBvxgFonOIatnYYRvPAmiQDglHdTrCIejrZDb3BNFP3uMtg 5/f31C8PlQ0sRU7Cs8GefpJK4LW7txOTIltLoArXXMBcDapAWGh4/r87m AGF3/5P/IGpl8nL3c7yeT89a8yy0czU4ErZ5mETF21TD6mBWk+PKQ92iK g=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84803104 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:XYICz6BqyG7kzBVW/8njw5YqxClBgxIJ4kV8jS/XYbTApGt20GEGm GceWmmAPKmDZWemKYx/Oo2x90wAvJ+Gy9FmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpB4gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwoPc0A2hi2 sYicWowUBG/gLqQ0LyYc7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/AZQinOCulz/nfidRsl69rqsr+WnDigd21dABNfKFJozSHpwNwi50o EqZpHzdJEpBaeWF4gur/kiXufLWpn/CDdd6+LqQqacx3Qz7KnYoIB8LUVq2p9Gph0j4XMhQQ 2QW8Cczqak59GSwU8LwGRa/pRasoRo0S9dWVeog52ml0bHI6gyUAmwFSD9pa9E8ssIyAzsw2 Tehj97vQDBirrCRYXac7auP6yO/PzAPKm0PbjNCShEKi/HnvYo6yBzGSN1uFKqoptTvHHf7x DXihDczhvMYjcMN/6yh+BbMhDfEjpLEVBIv7wPbGGes9BpkZZWNbpatr1Pc6J59wJ2xFwfb+ iJewo7Hsb5IXcrleDGxrPslRqDq5f+pHwfm2ARSIZgd8GyL63CARNUFiN1hH3tBPsEBcD7vR UbcvwJN+ZNeVEeXgb9Lj5GZUJpzk/W5fTjxfrWNN4cVPMAtHOOS1Hs2DXN8yVwBh6TFfUsXH Z6AOfihAn8BYUiM5GrnHrxNuVPHK81X+I8yeXwZ5072uVZ9TCTPIVvgDLdpRr5R0U98iF+Jm +uzzuPTo/ifOcWnCsUtzaYdLEoRMV8wDo3spspce4are1Q4SDp/V6OPneh5KuSJepi5cc+Ro xmAtrJwkgKj1RUr1y3XApycVF8fdckm9i9qVcDdFV2px2Iice6SAFQ3LvMKkHhO3LIL8MOYu NFcI5vdX68fG2qYk9nfBLGkxLFfmN2QrVrmF0KYjPIXJvaMmyShFgfYQzbS IronPort-HdrOrdr: A9a23:DkePAqqh5zPRP7stCsF6ydkaV5rReYIsimQD101hICG9Evb0qy lhppQmPH7P+VIssRQb8+xoV5PufZqxz/BICOoqTNKftWvdyQiVxehZhOOP/9SJIUbDH4VmpM VdmsZFaeEZDTJB/LvHCAvTKadd/DFQmprY+ts3zB1WPH9Xg7kL1XYfNu4CeHcGPzWvA/ACZf yhz/sCnRWMU1INYP+2A3EUNtKz3eEixPrdEGc77wdM0nj3sQ+V X-IronPort-AV: E=Sophos;i="5.96,164,1665460800"; d="scan'208";a="84803104" Date: Mon, 14 Nov 2022 16:25:45 +0000 From: Anthony PERARD To: Luca Fancellu CC: , , , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Message-ID: References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221107104739.10404-2-luca.fancellu@arm.com> On Mon, Nov 07, 2022 at 10:47:36AM +0000, Luca Fancellu wrote: > xen/Makefile | 50 ++++++- Hi Luca, Could you write a shell script which would probably be easier to read/modify than this rather complicated looking set of Makefile rules? As I see it, a potential `analysis` shell script would have a single interaction with make, it would just have to run `make build CC=cppcheck-gcc` or other. Because I don't see how make is useful in this case. Or maybe you could explain how writing this in make help? Also non of this would work with out-of-tree builds, as you shouldn't make modification to the source tree. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Nov 14 17:16:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 17:16:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443489.698026 (Exim 4.92) (envelope-from ) id 1oud4Q-0000PE-7Q; Mon, 14 Nov 2022 17:16:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443489.698026; Mon, 14 Nov 2022 17:16:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oud4Q-0000P7-4i; Mon, 14 Nov 2022 17:16:30 +0000 Received: by outflank-mailman (input) for mailman id 443489; Mon, 14 Nov 2022 17:16:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oud4O-0000P1-Rw for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 17:16:28 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 11ae2f6d-6440-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 18:16:27 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11ae2f6d-6440-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668446187; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Pa7ckpP04crPbBq5AT1U8z1zjmHFl9RNWVfkrdBaLXA=; b=Bhiw7RXmU77vr2AmMWxb3kE3qydyk+U6DpOIHI18twCXUBCh8Dy7jNy/ LA/7IO9Fsrz2ES3t80Uz4bEGEyXWbBx1NIwzjGit6vS/gMrLetofh+xP+ 7+UxkNUfdsdjzh6/bxLxgTNH6Xgem+RnQyau6l90vFmW1uu4jIS94UlsL 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84785773 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:7wTbW6m8ma9lv7OPXx7n5JXo5gxhJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIZUTuHOKuJZGSkeNp1b9i/8U4OsJTXytRkSwJl+yw3RCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5QOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 fI8DxJdRBrAvuL166iDdfRlupwcIta+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsfYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9zhrH9 j+ZoD+R7hcyJeOOxmqc/HKQouL2tDOgYd4RSOWC+as/6LGU7jNKU0BHPbehmtG7l0q/VtR3O 0ESvC00osAay0GqCPL9UhuQqWSB+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/v2ARR/vbvTTmiSnp+Wpz6vPSkeLUcZeDQJCwAC5rHLhJw4h1ThR9BoHaqxk/X8AzS2y DePxAAUiq8Pl8cN2+Oe9ErenjO3jpHTS0g+4QC/dnm+8gpzaYqhZoqpwVvW9/BNKMCeVFbpg ZQfs5HAtqZUV8jLzXHTBrVWdF202xqbGDP4pnw/NZNizjTu0GSbQp1Z3GlBKlg8Z67oZgTVS EPUvApQ4rpaM32rcbJ7buqNNig68UTzPY+7D66JN7KidrA0LVbap382OSZ8yki3yCARfbcD1 YB3mCpGJVITEuxZwTW/XI/xOpd7l3lllQs/qX0WpilLMIZyhlbPGN/p03PUNIjVCZ9oRy2Lm +uzz+PQl31ivBTWO0E6Mec7dDjm10QTC5HssNBwfeWeOAdgE2xJI6aPn+N6JdA5wfgOzragE pSBtqhwkQeXuJE6AV/SNiALhE3HAP6TUk7XzQRzZA31ihDPkK6k7bsFdotfQFXU3LUL8BO1J tFbE/i97gNnE2SeomxEMcel9OSPtn2D3GqzAsZsWxBnF7YIeuAD0oSMktfHnMXWMheKiA== IronPort-HdrOrdr: A9a23:xI9YcqsusgssYXJ86LweVMSq7skDTtV00zEX/kB9WHVpmszxra GTddAgpHjJYVEqKRcdcLG7Sc29qBznmaKdjbN/AV7mZniehILKFvAG0WKB+UyCJ8SWzIc0vs 0MT0E9MqyTMbETt7eD3ODSKbYdKbe8npyVuQ== X-IronPort-AV: E=Sophos;i="5.96,164,1665460800"; d="scan'208";a="84785773" Date: Mon, 14 Nov 2022 17:16:20 +0000 From: Anthony PERARD To: Luca Fancellu CC: Jan Beulich , Stefano Stabellini , Bertrand Marquis , "Wei Chen" , Andrew Cooper , "George Dunlap" , Julien Grall , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Message-ID: References: <7d56c33d-4b03-9aa1-6abc-45a8ad41caca@suse.com> <2E0BFEFC-5BEE-4F8B-BD9E-94CB9A5B2BC9@arm.com> <9CE2A214-2D64-4BEC-A78B-393BF7AEDD9D@arm.com> <826eb0df-fb52-fa25-c908-977285a6ec8b@suse.com> <282F1A51-D143-4F23-BEF6-43648505E7D9@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <282F1A51-D143-4F23-BEF6-43648505E7D9@arm.com> On Mon, Nov 14, 2022 at 12:30:39PM +0000, Luca Fancellu wrote: > The cppcheck workflow instead is: > > 1) call analysis-parse-tags-cppcheck > 2) generate cppcheck suppression list > 3) build Xen (and run cppcheck on built source files) > 4) collect and generate report > 5) call analysis-clean > > So let’s think about detaching the build stage from the previous stages, I think it is not very convenient > for the user, as during cppcheck analysis we build $(objtree)/include/generated/compiler-def.h, we build > $(objtree)/suppression-list.txt, so the user needs to build Xen where those files are created > (in-tree or out-of-tree) otherwise the analysis won’t work and that’s the first user requirement (stage #3). > > The most critical input to cppcheck is Xen’s $(CC), it comes from the build system in this serie, the user would > need to pass the correct one to cppcheck wrapper, together with cppcheck flags, and pass to Xen build stage #3 > the wrapper as CC, second user requirement. You could add something like that to Makefile: export-variables: @echo "CC='$(CC)'" And if "the user" is a shell script, it could easily figure out what $CC is, without having to duplicate the Makefile's logic for it. > After the analysis, the user needs to run some scripts to put together the cppcheck report fragments > after its analysis, this step requires also the knowledge of were Xen is built, in-tree or out-of-tree, so > here the third user requirement (similar to the first one, but the stage is #4). Don't support out-of-tree, that would make things easier. I don't see how that would work anyway with the needed temporary changes to the source code. > In the end, we can see the user would not be able to call individually the targets if it is not mastering > the system, it’s too complex to have something working, we could create a script to handle these requirements, > but it would be complex as it would do the job of the make system, plus it needs to forward additional make arguments > to it as well (CROSS_COMPILE, XEN_TARGET_ARCH, in-tree or Out-of-tree build, ... for example). Well, instead of running `make X XEN_TARGET_ARCH=x86`, a script would be run as `./script XEN_TARGET_ARCH=x86`, so not much change. Then the script can easily run `make "$@"`. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Nov 14 17:56:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 17:56:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443499.698038 (Exim 4.92) (envelope-from ) id 1oudgv-0005Aw-52; Mon, 14 Nov 2022 17:56:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443499.698038; Mon, 14 Nov 2022 17:56:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oudgv-0005Ap-10; Mon, 14 Nov 2022 17:56:17 +0000 Received: by outflank-mailman (input) for mailman id 443499; Mon, 14 Nov 2022 17:56:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oudgt-0005Aj-85 for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 17:56:15 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9effcc69-6445-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 18:56:12 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9effcc69-6445-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668448572; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=q1UW1G+GWOusDk1Y3CJSi9N7nxIrZPltlgQZ4I/HidQ=; b=U5kQyhqyBXFl+3mcNy15L4zbO0fK7FFuMq2e031LqXDkdd7qV0aiA3xr NXvDNBAuI7ncWBG2Zy8Wr1IhNxrWF28piPu3voYnEW8Esp4PMI3u5XOpy /XoFY9vHtg647EpuQLKuM3QbnglGJHdcG7BZRVkydKCWyvr9xwio9uF9D I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85216251 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:HrlePq9bLJdxlvLEF+6IDrUDkX6TJUtcMsCJ2f8bNWPcYEJGY0x3m zdJXW2BaPvcN2akfo8jbIWw/UNQu8TTn4BgGwZsry88E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKkX5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklBt vkWAQ4BXiy42f242Y2HQbdXpv88eZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGM0Yn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZUIxB/G/ D+fl4j/KkAbEvm61mC8y3OxnNPonibXQKdDMpTto5aGh3XMnzdOWXX6T2CTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jYeVddQF+w1wBqQ0aeS6AGcbkAGRDNcbN0ttOctWCcnk FSOmrvBJTFpqqzTdnub+Z+dtzb0Mi8QRVLufgddE1FDuYO65thu0FSfFb6PDZJZkPX6WjT+6 g6GnBQF2aodlPE33PuA3WvY1mfESofyciY54QDeX2SA5wx/ZZK4a4HA1WU3/cqsP67CEADf4 SFsd9y2qblXUMrTzHDlrPAlRunB2hqTDNHLbbeD9bEF/i/lxXOsdJs4DNpWdBYwaZZsldMEj SbuVeJtCH17ZirCgUxfOdjZ5yEWIU/IS7zYugj8NIYmX3SIXFbvEeEHTRf4M5rRuEYti7ojH pyQbNyhC30XYYw+kmTmHLlBjeF3nXhvrY82eXwc5036uYdymVbPEetVWLdwRr1RAFy4TPX9r I8EapriJ+R3W+zieCjHmbP/3nhTRUXWxPne9aRqSwJ0ClM2QTh5UqOPmetJlk4Mt/09q9okN 0qVAidwoGcTT1WbQelWQhiPsI/SYKs= IronPort-HdrOrdr: A9a23:KjZkFKHsmv2EUy4apLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A== X-IronPort-AV: E=Sophos;i="5.96,164,1665460800"; d="scan'208";a="85216251" Date: Mon, 14 Nov 2022 17:56:06 +0000 From: Anthony PERARD To: Jim Fehlig CC: Jan Beulich , Henry Wang , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Andrew Cooper , xen-devel Subject: Re: vnuma_nodes missing pnode 0 Message-ID: References: <2046b5fb-2533-02fe-69e8-f46174cf825d@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Mon, Nov 14, 2022 at 08:53:17AM -0700, Jim Fehlig wrote: > On 11/14/22 01:18, Jan Beulich wrote: > > On 14.11.2022 07:43, Henry Wang wrote: > > > Sorry, missed Anthony (The toolstack maintainer). Also added him > > > to this thread. > > > > Indeed there's nothing x86-ish in here, it's all about data representation. > > It merely happens to be (for now) x86-specific data which is being dealt > > with. > > > > Internally I indicated to Jim that the way the code presently is generated > > it looks to me as if 0 was simply taken as the default for "pnode". What I > > don't know at all is whether the concept of any kind of default is actually > > valid in json representation of guest configs. > > 0 is definitely ignored in the generated libxl_vnode_info_gen_json() > function, which essentially has > > if (p->pnode) > format-json > > I took a quick peek at the generator, but being totally unfamiliar could not > spot a fix. I'm also not sure how such a fix could be detected for testing > purposes by libxl users like libvirt. I.e. how to detect a libxl that emits > `"pnode:" 0` in the json representation of libxl_domain_config object and > one that does not. Well, the missing "pnode: 0' in json isn't exactly a bug, it's been done on purpose, see https://xenbits.xen.org/gitweb/?p=xen.git;h=731233d64f6a7602c1ca297f7b67ec254 When the JSON is been reloaded into it's original struct, libxl_vnode_info, pnode will have the expected value, that is 0, because libxl_vnode_info_init() would have reset this field to 0. I don't think it's possible to change the generator to just have it generate '"pnode": 0', as if we make a change, it would have to be for all unsigned it, I think. Is it actually wanted to have all those in json, or is it just a case of looking like there's missing part? Also, I don't know if any part of libxl rely of this behavior, that is where default values are omitted from json output. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Nov 14 18:08:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 18:08:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443504.698049 (Exim 4.92) (envelope-from ) id 1oudsm-0006mi-68; Mon, 14 Nov 2022 18:08:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443504.698049; Mon, 14 Nov 2022 18:08:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oudsm-0006mb-3T; Mon, 14 Nov 2022 18:08:32 +0000 Received: by outflank-mailman (input) for mailman id 443504; Mon, 14 Nov 2022 18:08:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oudsk-0006mV-GV for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 18:08:30 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0610.outbound.protection.outlook.com [2a01:111:f400:fe0c::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 573063cc-6447-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 19:08:29 +0100 (CET) Received: from AM0PR04MB4899.eurprd04.prod.outlook.com (2603:10a6:208:c5::16) by DB8PR04MB6827.eurprd04.prod.outlook.com (2603:10a6:10:f8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Mon, 14 Nov 2022 18:08:27 +0000 Received: from AM0PR04MB4899.eurprd04.prod.outlook.com ([fe80::3342:8b15:bc9b:3d47]) by AM0PR04MB4899.eurprd04.prod.outlook.com ([fe80::3342:8b15:bc9b:3d47%7]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 18:08:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 573063cc-6447-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XMfhQ1BmCK8116ABR2FKuIJ2OLYAkNRBp3sH3BO1S8wCDyE4NVOTw5NpkQ8aPMtmXk8PJjvv3BT6yjlS7x7F6wrcCh2AyrmE6SHkqmiI9A48zhFxvC8pJg8q0N69DFljkzKKZWs7EYUt3rYIR5onVUvP5MVEvycDz21MaBm3tcHdsVf48CoQ5QWa0ZlkviBm+QqmFm/uJ0Mf10n1ahizkYN/q+ETHtxKvSHLJCkUgVP3tJ4PxQY5wmuzfszAtoqpR/JKNOWplqZrGcmnNZJ7sNeCg3Fcx0pAC/IePGUFYbwqb10nPJMp2Eu2m0y54cJMx/AlJCyWYeFDDPpa7hqPNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nWpWVQrC1DQaGImjsJWLYcGICoBgwfl7WlYrSk/35nc=; b=DhY4Iyr1t0jdDz2CYfAxMZViC6IkUQP3w6WRgegcmBCnUe3WF5cBFsz9+h7Lqi4DABT/Fa0R3VTm/eSw4mNtwwwnwiR0eHkJYff1XhOisKzmzrArV6woD5L6Iz7mJ6PBC1x+vzL90kK3seMhePF4g5cAPSfvX9qbqJY5XQzB54yHrz+azxJMUG962MD2UgR+dVj8vPnA6clDIgauhEcVeZc/+jMJDdDOCJJpQrpsX5g7TeG17dqAcC8HvdVE/bCSumvN8puaP+5ywf61nahfIn/Ann6MJEjIb1PCuKpi6SKzsS28AdQuZs7Bqj4iPI9oeZGAm29x6YY53+hlmc7AvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nWpWVQrC1DQaGImjsJWLYcGICoBgwfl7WlYrSk/35nc=; b=j4kWV3L12BvyKauq1h2qi1vLYytSKaMetGx7TRtUuI+nMgtjgLDWrwARADu96N8HnI+/yb7zOTwZy477f6A/2F1dhSxl/nLS/OQ1Wm0betkNjQs4PG9tqCLExfpACiLdiLBkKv/AJawkIsmgBDoWqTOq2yKkEakj/fB6h1zlzqzkf8t4m5XEMTtB4yFo+bcU+2KHVXaoAoyn1idcO0unL0C5T9vU5maNYCM11qhE5YqAYu5+x5dm7nS8vcRu3uzaeCYv5RqfV/Grt9Ju7rvzmT+AeLi6+vC9GkScC3IVWhNYHcEPxpNwtM1H6VXMRQ2wRHGlA6UR3Tmuu0f/Y8FSXA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <08424b48-3ce1-3e3a-857e-1a6d3cae3a1c@suse.com> Date: Mon, 14 Nov 2022 11:08:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: vnuma_nodes missing pnode 0 Content-Language: en-US To: Anthony PERARD Cc: Jan Beulich , Henry Wang , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , xen-devel References: <2046b5fb-2533-02fe-69e8-f46174cf825d@suse.com> From: Jim Fehlig In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0023.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::7) To AM0PR04MB4899.eurprd04.prod.outlook.com (2603:10a6:208:c5::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB4899:EE_|DB8PR04MB6827:EE_ X-MS-Office365-Filtering-Correlation-Id: 07e69bc4-bfb3-4e26-0187-08dac66b3a38 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P2zNJ8Fxslw/omSXdsMWwfSbcmwbMKNing9GIzrA7oIxwor7XqQ2bZZRwuQW9vVK1WzND/Owhzp2tkG/rIzCBEKZNo1Ff9BdE8RWvVW55jlzziJ7FaS96cbGbq4y3MYtHQcLmc8+nL9nH1OOMsnblqJyIKzK9T21AZlH6uMm25EnCC2nbLGRgc4Kws3eFA1CLxSqgV4c/u+YFs0sdvgURdhbxCvJBcOrLfzoYm7q1eeKc9fo5ZGeepxynBggSAMJTBVQuQV3w0W9tymfi1EzDTv0+JNY+BivrTwi+UTP8qnJHcAbEVCw1U5af2gK2OjTuHT2zUVt+QofFXROsW6A6cX7CUwifxOCFU9oUyjUIPA05eDmQs9bHFAMCoECwl9VLA93A/lYOq7NpMAhVVClLc7W5VU39WhmW1wcxZftZE1TXwYYCdXymA4IsT3/09rbnRnDn7z7C3OFQGgaO8Zv3MopQR0k6Kfwx2uvXH5zT/aYgBVKJlpT4976K/nLgRnlbKBAIbhE5pT+DFwTMYa/4IO5VAwE/LEN7ekNaH6ujVYshyxXq9dffjC4Fsg/EDmQEAr4dpkdqvFb9Y1XOThx/HmVF8Qea85na9TU1LJjkNoKmKQvFEiJEkPsS8IDFc5uZ3QsQDP7sd/bqB/WmHtdPpdN2V7/e2qwXndGxnSnYFtk1zskJtQ843scrr91GsvT+kStd7Lfdc7jBIg9hopeADce12ADomm1LJySFezB7pWk5IW31IeKZvT59NRKQevNE0Ra6csZzZBJii5hp8kZ9r1Tw1+E+aAS46H8c8bPu6ZrSdZFsbNc1KDtFHJyNOP0 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB4899.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(396003)(366004)(39860400002)(376002)(451199015)(83380400001)(53546011)(316002)(186003)(7116003)(41300700001)(31696002)(36756003)(8936002)(5660300002)(2616005)(2906002)(4326008)(26005)(8676002)(86362001)(6512007)(66476007)(66556008)(66946007)(38100700002)(31686004)(6506007)(66899015)(478600001)(966005)(6486002)(6666004)(54906003)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWJVK3NRWG8zWmlpcE1DYzk4Z3ZiV1lqeldjNDhXSUhuVWQ4bkRWakN6MUFC?= =?utf-8?B?K2g4TjRBMkYvUE9tYmRSZmJneDVDSHVqeFJEVC90MXhoK2Y2UjE0Vys4VWY2?= =?utf-8?B?ZCtlaWh0MTg3eW9aQmJ0V0JKY1RtRTF4SHIrMFd1S1ZSNUZWYlpjcG1NcHRJ?= =?utf-8?B?TmJBNW90NFF5YlJIRVRYU0pOcm0rMXVjN1pkU1hndlppR3Z0S3BqZ3dNTkZS?= =?utf-8?B?cEVZZVY2UHN1bHdGbHFlTnNmRTBEMkgrMDhzWm1TL3FDUEY5T29Qbmo2UjB1?= =?utf-8?B?R2sxOTRmNGdOQjBYRCtpQzYrb3Q3SkhxRzY1dTJQTmY4NGVKZXZ0UytFYzEw?= =?utf-8?B?aFZCbFdQQS9ta0tQRVFMQWFGckVJcjVadmFRTjJvUU15KzZMb3NTaWRteGo5?= =?utf-8?B?RUlnVjBhZzB5STRrQlo0ekdoWlh4Nk9wWXdUMjI3Z0IyemFJZDRDdFJxemd6?= =?utf-8?B?bGo4eElHazRLTnh5Nnd5V25UZ0kxWHBJNUV1VnNTVng0c29ncU1QNGFjblpL?= =?utf-8?B?VnZEb2M1SWNnRzZZc0VMYzg1MVhQSVl0SEJ5ZGhxbHdlQXp3Y3djcTQrc3pi?= =?utf-8?B?MlNjTDdReVdjZVVlc1Vad3RNdmNsSWI1NzNFYmwzNGtXdEwrVG96TVRmdHh2?= =?utf-8?B?YXRwZXJNVGRTYlpzRWdBL0ZHbmNUOS9QMEs5NEQ3SmsyQytpNnBCQzd3eHlO?= =?utf-8?B?R0dhWW5NU1A0ZDMzbStIVHlLdVVqMHdtVnlkK1ZxOGw5ZUhMSFJZQ09mQ0Jk?= =?utf-8?B?a0FNbDJrMG9lUlhRMjlSd2F4cFdLMFM3SUt4eGpMRlJVY2dwRnFhQWU4MEFz?= =?utf-8?B?OGRuQ2thTkVlemFJdzhMcXdtYWVJRWhXbGVkVHpsQ1F5L0pHYXZvR1FRTXJq?= =?utf-8?B?UEpQbERoc2xFM1JvREQzdENadnhTR3REVHl6VVhydy8yMHkzVzNYREN2aDgx?= =?utf-8?B?Vm8wWkFhY1k1clhCVnhrZ01lSDRnZmgrZUdJSHFqTElSVzRkS3UwTURnVUVP?= =?utf-8?B?OTdiUzV1V2tGYTVsSHdPVVFKWjc1WGRoT2JUekVENmo5TkhYLzgrTW5NbFQ4?= =?utf-8?B?SExQd1J0K0NleFB2d3B2enRYVFR1YTFaUCtJOWsrZXdzOGIvd29GNFNpdkpu?= =?utf-8?B?VEh5NVByR1Fzclk0cE0rTlY2dWdBbmo5YjB1NGlLTVgzemhWWkovR3FmcEpr?= =?utf-8?B?NlFJRzV5cmtnR3hmYXhiU0JxV2ZRelhibmVvVU5TcEZ0RjBLWW1GRldzc2Yz?= =?utf-8?B?R2VMblN1Yyt4bVVTR3RGdndSTnhDbjJOM2crQ1JIRTAyMEJVNjJlSC8vbkVo?= =?utf-8?B?TXRRdlB3YTU2T085aVpIVVd2NUF0TVBxRDZ0WFVwZXZwTVcwUDVXQTVwRSt2?= =?utf-8?B?M2hUVWt2OWwrejk4UDVkUERWNDlTbHpXN1BBYXllczAwRUNrcXlnSHNleFZa?= =?utf-8?B?OFkySXI3Z3BtY0tRWGVMMVNqRWJhSEljaElvSlN2L0c5V1oycWlYRmNzOXNJ?= =?utf-8?B?MGpxakw4Y3pWanhzMHlud1dTMm1tcml2ZGt3dzlXQ3JKeUdRWGhReXpucjRI?= =?utf-8?B?MHVneVBsQUI5M2RnczgwbnJMcnFRMGF1WDRGMXZYc0JhMFlCcVFiUEJNWFlH?= =?utf-8?B?SlBtWVBZYWl2bXExMk5QQlVQaWdDUU56ZURScGs3RkdOZHZjN0F6Sm1Daks5?= =?utf-8?B?c29UU0hXa1VBckVwakhZVFZ5K2tLcXNhUmRhb05pZWJRQ1pkYW15dlRjc0JY?= =?utf-8?B?WTl6R1ZObFkvUzZuaC9zdnhnZ21LdFVQMm1SMmR2UjVOMFl2ZmN1ckJCdGxo?= =?utf-8?B?Y3FxUzV5NkFKek1qZEFTVEZLeDl5bGZESUIzb3lUa0xZQncybDhoYnJ0WjhI?= =?utf-8?B?Z213RTN0ODNYM2dxckFrNlZoUWRhU0o2MThndkcrTkpSbTlRN0NVcThSenBJ?= =?utf-8?B?bHdYQ1c5aXdQbmowS2cwT1d1eWZFTkk0Z0NBQnh2ZFZRcXVoa0xNY1FFbVVm?= =?utf-8?B?VUZ3RHJ1SUdvQjgvNUM2Ni90emRWRHFjZkIvM0hQaHNwQVVlRU5IQkZmblN5?= =?utf-8?B?U1g0R2dTRXhGakYzZ2xFMmNUUkRUTVJ0a2NleTdNN2IxY04wYmxTTW9hb3ZR?= =?utf-8?Q?t279hm9d2+mDunepsbfVit8XT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07e69bc4-bfb3-4e26-0187-08dac66b3a38 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB4899.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 18:08:27.4395 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A4Teua3yCcV5kprelZLp+rrA7NluL9YXRCGUc1dlkdY1Pj76UjEhpF/AptACF1/vrxkhl9cpN5Cvuyy4z1wh4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6827 On 11/14/22 10:56, Anthony PERARD wrote: > On Mon, Nov 14, 2022 at 08:53:17AM -0700, Jim Fehlig wrote: >> On 11/14/22 01:18, Jan Beulich wrote: >>> On 14.11.2022 07:43, Henry Wang wrote: >>>> Sorry, missed Anthony (The toolstack maintainer). Also added him >>>> to this thread. >>> >>> Indeed there's nothing x86-ish in here, it's all about data representation. >>> It merely happens to be (for now) x86-specific data which is being dealt >>> with. >>> >>> Internally I indicated to Jim that the way the code presently is generated >>> it looks to me as if 0 was simply taken as the default for "pnode". What I >>> don't know at all is whether the concept of any kind of default is actually >>> valid in json representation of guest configs. >> >> 0 is definitely ignored in the generated libxl_vnode_info_gen_json() >> function, which essentially has >> >> if (p->pnode) >> format-json >> >> I took a quick peek at the generator, but being totally unfamiliar could not >> spot a fix. I'm also not sure how such a fix could be detected for testing >> purposes by libxl users like libvirt. I.e. how to detect a libxl that emits >> `"pnode:" 0` in the json representation of libxl_domain_config object and >> one that does not. > > Well, the missing "pnode: 0' in json isn't exactly a bug, it's been done > on purpose, see https://xenbits.xen.org/gitweb/?p=xen.git;h=731233d64f6a7602c1ca297f7b67ec254 > > When the JSON is been reloaded into it's original struct, > libxl_vnode_info, pnode will have the expected value, that is 0, because > libxl_vnode_info_init() would have reset this field to 0. > > I don't think it's possible to change the generator to just have it > generate '"pnode": 0', as if we make a change, it would have to be for > all unsigned it, I think. Which would likely cause lots of libvirt libxlxml2domconfig test failures. > Is it actually wanted to have all those in json, or is it just a case of > looking like there's missing part? The latter. ATM, libvirt only uses the json in its unit tests. No functionality is affected. I'm fine with the status quo if you are :-). Thanks, Jim From xen-devel-bounces@lists.xenproject.org Mon Nov 14 18:53:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 18:53:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443511.698060 (Exim 4.92) (envelope-from ) id 1oueZi-0004Id-84; Mon, 14 Nov 2022 18:52:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443511.698060; Mon, 14 Nov 2022 18:52:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueZi-0004IW-5M; Mon, 14 Nov 2022 18:52:54 +0000 Received: by outflank-mailman (input) for mailman id 443511; Mon, 14 Nov 2022 18:52:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueZg-0004IQ-Ew for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 18:52:52 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on20602.outbound.protection.outlook.com [2a01:111:f400:7e8b::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 88c16b7e-644d-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 19:52:50 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by SN7PR12MB7348.namprd12.prod.outlook.com (2603:10b6:806:29b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 18:52:46 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57%4]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 18:52:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88c16b7e-644d-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V4s/1LIMjtGDpyZNShAssITKgFPxU3Ir4ytXnw63ll2U/xvzZchl6+4u+Psmd+I4OZGoscdgG7jwVIH4qsn9Qf7vPjdOoKdj017SWjuDPgjZtN5xGelkAoDt2jfIC2MrXOSFFQo/CFwB+geGbuN2UsVP3F/4QBV+T06eNl5QLla0G6Ss+sukAxiwxe1q1fZ8R177vaxiqqa0TtVSoKdHIvXmkqo2qA3peWgMJMJWkGT8eY682i5e8UypO8/tR23+tcefKMAh1eLSgXZ3w88GWQ137vzfG41AyinkiiXm2IFnO+RPHGm6lwGbwCEdsPVBR3NEBQdO5X/g6oWEHQEixA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dQFWV1AW5IPthzY9LgpThqWkLLvMASjgxOJcwcV3N50=; b=Dphy/8RbFhSGJoO65mRwltj4+WjzJ4UXWRyPt/ay2seni+9bhpRIhcpDaC1AjYuZDTuthXCMyAOBRP1j1M7bI3ANqf7gv2OjNvJ1tSK+596aXDQ7TERyDNfcyC/rU5/DY+l0cUNCm1Uyn0E+1EIvqxzUAorfb0YylYPHg0Eg2VoK1DSJVRoTCMZuQYKgHXb07Oi1ilKQ1uDLLrhuecj6f1GWoatk9sc//XwvEijt46R8JcN/OAz1Qw+44WS9DqC9MYyWJQ5vGsxoAaQwd/nVKiUm3JaOQNmOwgOIbhjF9kEhpbCOz/I/9oj2iWuIX1qfRBL/InYTFRQg1ncRlB9qCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dQFWV1AW5IPthzY9LgpThqWkLLvMASjgxOJcwcV3N50=; b=X+CC1sALGKHGex4QtF8fWEwMXmB0nA05gdWkWfJMeSCGC7ziRFFaC6nXfzVlQUjXgjp0XYR0A0Gg6SNDSDxcrQyCSfOIAPiJIzfVI1uiUdPKzxtw5+bvXy7Yo93yYO9Sp3ZzJqikQnvBGFz3v12ibWc3aA6xcHbk6QaqvuQ4mD0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Mon, 14 Nov 2022 18:52:40 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , "Jiamei . Xie" References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-6-wei.chen@arm.com> From: Ayan Kumar Halder In-Reply-To: <20221104100741.2176307-6-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0549.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:319::18) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|SN7PR12MB7348:EE_ X-MS-Office365-Filtering-Correlation-Id: f34a0652-7151-4872-3aa1-08dac6716b81 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RnBj3XVsXNYGpYgDZDKVp9bR6fTKPoNYejw+/zj1xhKbPFHojcrWEhOA6BqPatn6tpUbbLYrp94XkXKgwbUeSa4Q+F6L9rQt5cFUU+LfgbcIM7WJjXlqQnj2uwyA3xdpSXtdR19SymxH2OrPDYx0xrHAJxaaGUopwk8OaF9eger+HHkoHaqd8eVcebzl3hkMCsOmXncIQ1rZFMYgH4VwlWUdpRcMkgviWMrwGYOailYLR2r6W3kbdpLmcFgPMJ0ypi9K6CR7fC22n1vs72+fCLO6l/vbL+4Rtzy0jz4t6CURB7QF2NWvDqMLU3fcXOdVkfN9FC6jK5BdpAfvF4dMDkTbuRJmsvJCn+vWJq7vjWb3L0FC5OlO6W6IC0hK9LPqL6BkeRkhqZVna8Gppi1gFwnVq2LiJrQdafzLcW/Fp5q0Kz67Sjcg7g5pPOQxchb7sSqljbrAZTIJSqNuoH8uT1+O2eYs6GBQpxufdIuJuEAo2OwwAxzzR/usKB4z7wXGjPZfMSaIO5kkeYZOSHSIGdQ+4vGMpZZ8pcLGSadINeK/m9XT1TlHtjX00CJi5QRmZXlfc80q3BoMm0uKO1rAe7gFlD9XyNc3iR7d3Tn1KP2ZFQO0LmVMSlsDQ2HRpYvFuqfIuEzN/+OcoKXobN3VbJ3qYygqVhKfFO4tue9U8WUdBrGVnYqIDwXjXQr2tqTyOzDCMNpApR83Zw/18HByYbLpZROlneu2LJU1A/ox9OYAoUE67QJ0rsImFi9rR7SWav3Y4vuKY6TbldE+9syxMiYz6q/iXbOnWP3ibsTx7Ek= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(346002)(136003)(396003)(376002)(451199015)(41300700001)(5660300002)(31696002)(8936002)(2906002)(83380400001)(26005)(6512007)(186003)(2616005)(38100700002)(316002)(54906003)(66476007)(66946007)(8676002)(66556008)(4326008)(6506007)(6666004)(6486002)(53546011)(478600001)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b21tTDdSNW04by91V0hLbnptUHhjMjA4YjNVcmlWelhqeXZuUVVzd2lXWGZX?= =?utf-8?B?YjdnejI1N1ZLWFVlNTB3Qm00MUI5aGl4cEZib1Y5TlVSbzkySlBrNzRXcUJZ?= =?utf-8?B?NnZVMUVjRStsOVVRL0F0RWNWeWRzOXZVbWttdjVqQjl3OGpBYVdUZXlsNmMv?= =?utf-8?B?SlRVVHJUOUdJOEVUMWh2MDU0SkZtNDlnWFZ1anR1b1NXaENERkZHZHYzaFFx?= =?utf-8?B?TDI5T2pDcFkrR2t4SlZFNHU1R09xL2lscHFXbGlObXZMSWF5a2VoTi9NRW8x?= =?utf-8?B?RFpaVFV3eTc1M1BLRndzWkM1K3E0Ky9TVm1lMUF2M0VPSFkxa3JPN21sQlBr?= =?utf-8?B?QUI2Y0RJQjVKNHZsZmphVnYxZ2VaanhTbzhZWFNFY2ZjdURoM09kUW1kcklp?= =?utf-8?B?em1lWU82YmJVdXdzdFUxY2JNa1B0S3ZjbGR6b2dPYlE0ZUduNmlpV2l3K3lP?= =?utf-8?B?NHp6YTRyTVdEYmgyeHBPRXNyWktkMDVOelZPSWNJbjJPRkVMNWtORTR5RnlJ?= =?utf-8?B?UjNHN3ZxNU5PK2hPZnpwK2FqZXpFVjR4UGpjeEpFaDZHdVFmM2ZzbzFSUHJH?= =?utf-8?B?YlR4dHVJOVpUcnBNOHp5bGxCakNrZm5QWndVVXlCM1VONTFnT2N6c0ZrT3pE?= =?utf-8?B?OGZhS2ZQUFYvQ3dQYTVnK2tzZjF0aHdoc1dDMjZrU05HcE5keUFqSWs3UnFM?= =?utf-8?B?NExhTzVMcmhqeWFINitTTzlHMklvelRKMGs1MHpRcmtBV21sRFFQQVpDblgx?= =?utf-8?B?Rm8wcU1SU3NicXYvTGFNWVUzRW5ob1pGK2tQN0pEWFdWNkZNd29JQkt2cnU4?= =?utf-8?B?Q3JybS9ZZlc4L1ZwdFJNaVVPUUYvQW5IZW5XMnl1Unpobzh3c1RGMjUwOUMv?= =?utf-8?B?cHFjcjFmbzl6RDU5M1FucHJ6KzRLa29iTmsxdjJzem1CYTlzVG8xRklURTBs?= =?utf-8?B?Si9YYmF4a05jM28rMVIwQzgrNktOcG9sdmhYNG1YSCtHTU1VdXc4ZEFMcTYy?= =?utf-8?B?dlFFeWhYdXFVa0c2bVBFb2ZFMmJXUmIzR29zOUF6NU9VWjFYbnhydlJ2dVNO?= =?utf-8?B?V0ROTjB6cXoySC9mZzlhcUtRcGJ0SUw3UklOZ3A4a3FqaDJVdk9oWWp2ekdQ?= =?utf-8?B?K3lJYkNWWUR4Z2svYUxXSEY1TVE0V0VZcmI4cnM0dDM3NnJUZUlCcEU2VFp1?= =?utf-8?B?Tm1SWnRDL3c3TGpYbTJyejI0eUlwam9QTlFoRDlqYU5YdkNKbm90Y1JVSVli?= =?utf-8?B?bGx6NDZ6VjZ0U1lrVVcvZlBhRGR4UnFhL2VFQ3BZSVJXYUJ2NktnK2RMOXJB?= =?utf-8?B?MkZlanZhZ2ZHWXFoN243WENGQkpzOEJMQkdCaHpFNVRBSE5iUTVBS3VBM3NY?= =?utf-8?B?S3ZmWU5SQmwvYzlDZG1IdnI3THBuR0Z2Y2JIa0FUK01Wd05yeU16azRCcWlZ?= =?utf-8?B?S2ZrRGpwb21KWWt1cDFYeE01b3RKTDl6bHAzK1o4MjFTZkp2MjNHT2dPcDcr?= =?utf-8?B?SnZpY2x5OS9TejM0NFoySjRRUmFiNmRvMy8wYnNuYnB4ZVFWNWQ4ZzJxYmZz?= =?utf-8?B?U3dReUQwWkNvV2UreUdGUzBuMlVUV1QxYmNURk4rUWpScFV6TFo4UzlSSHQ5?= =?utf-8?B?alE2VFB0THRHVExHOEFlUVVxaUFDZll0MHBwektyemRDVnlNVWxESjFDcWRt?= =?utf-8?B?OGsyczNmTmlLc0FjR1kzTlRORXhHSm1NL01vSGxRZi9sOTZvU1F0MkVwT1R0?= =?utf-8?B?cnZkT2laUE9CbStxYVFjeWdiS2VwSEJvMW5MQ2VYSlEwZ1BQUjFOKzN4YjYx?= =?utf-8?B?eVBLQjRvT3NLWnIyUk8zWVdFNTdhaGxqWVdJSG5lWGJmTWk4NWh3RUFvUHly?= =?utf-8?B?Zm5kZTREUkcxc05HQm9zZWxzSWR6SGx4K1FIS3JmQ24zU3d1VVpkRXgyV2lV?= =?utf-8?B?UGdReFJhUmRnK0EvMFljVG9LMkRWM0poYmJITHdLWHlmNEswTXozRDV1S0dX?= =?utf-8?B?RW1VQ3pZay83OTEwem52SXVOWkxEV3pwak1jN0FHZmNmSExMb2ZxdWdxb05U?= =?utf-8?B?ck0vQ1laZUJjbWx1bkJvSFI0ZFJpLzEzQmNIRWdGYzdHOTdhM2pyVmlYeVVI?= =?utf-8?Q?RJbRm+U4p+/EJvTFMXtz02C3q?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f34a0652-7151-4872-3aa1-08dac6716b81 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 18:52:46.6237 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1bdXO06sNXVS+OD0vYhVdf+P/LsEWJA4z7HSVcGCRV0mctoiUpcO+kntBTb/VJ5MFCNcz9JhbxheLAsKr0BfJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7348 Hi Wei, On 04/11/2022 10:07, Wei Chen wrote: > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > On Armv8-A, Xen has a fixed virtual start address (link address > too) for all Armv8-A platforms. In an MMU based system, Xen can > map its loaded address to this virtual start address. So, on > Armv8-A platforms, the Xen start address does not need to be > configurable. But on Armv8-R platforms, there is no MMU to map > loaded address to a fixed virtual address and different platforms > will have very different address space layout. So Xen cannot use > a fixed physical address on MPU based system and need to have it > configurable. > > So in this patch, we reuse the existing arm/platforms to store > Armv8-R platforms' parameters. And `XEN_START_ADDRESS` is one > kind of FVP BaseR platform's parameters. So we define default > `XEN_START_ADDRESS` for FVP BaseR in its platform file. > > We also introduce one Kconfig option for users to override the > default Xen start address of selected platform, if they think > the default address doesn't suit their scenarios. For this > Kconfig option, we use an unaligned address "0xffffffff" as the > default value to indicate that users haven't used a customized > Xen start address. > > And as we introduced Armv8-R platforms to Xen, that means the > existed Arm64 platforms should not be listed in Armv8-R platform > list, so we add !ARM_V8R dependency for these platforms. > > Signed-off-by: Wei Chen > Signed-off-by: Jiamei.Xie > --- > xen/arch/arm/Kconfig | 11 +++++++++++ > xen/arch/arm/include/asm/platforms/fvp_baser.h | 14 ++++++++++++++ > xen/arch/arm/platforms/Kconfig | 16 +++++++++++++--- > 3 files changed, 38 insertions(+), 3 deletions(-) > create mode 100644 xen/arch/arm/include/asm/platforms/fvp_baser.h > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index ad592367bd..ac276307d6 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -138,6 +138,17 @@ config TEE > This option enables generic TEE mediators support. It allows guests > to access real TEE via one of TEE mediators implemented in XEN. > > +config XEN_START_ADDRESS > + hex "Xen start address: keep default to use platform defined address" > + default 0xFFFFFFFF > + depends on HAS_MPU > + help > + This option allows to set the customized address at which Xen will be > + linked on MPU systems. This address must be aligned to a page size. > + Use 0xFFFFFFFF as the default value to indicate that user hasn't > + customized this address, and Xen use use the default value that has > + been defined in platform files. > + > source "arch/arm/tee/Kconfig" > > config STATIC_SHM > diff --git a/xen/arch/arm/include/asm/platforms/fvp_baser.h b/xen/arch/arm/include/asm/platforms/fvp_baser.h > new file mode 100644 > index 0000000000..9450a411a9 > --- /dev/null > +++ b/xen/arch/arm/include/asm/platforms/fvp_baser.h > @@ -0,0 +1,14 @@ > +#ifndef __ASM_ARM_PLATFORMS_FVP_BASER_H__ > +#define __ASM_ARM_PLATFORMS_FVP_BASER_H__ > + > +/* > + * 0xFFFFFFFF indicates users haven't customized XEN_START_ADDRESS, > + * we will use platform defined default address. > + */ > +#if CONFIG_XEN_START_ADDRESS == 0xFFFFFFFF > +#define XEN_START_ADDRESS 0x200000 > +#else > +#define XEN_START_ADDRESS CONFIG_XEN_START_ADDRESS > +#endif > + > +#endif /* __ASM_ARM_PLATFORMS_FVP_BASER_H__ */ > diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig > index c93a6b2756..0904793a0b 100644 > --- a/xen/arch/arm/platforms/Kconfig > +++ b/xen/arch/arm/platforms/Kconfig > @@ -1,6 +1,7 @@ > choice > prompt "Platform Support" > default ALL_PLAT > + default FVP_BASER if ARM_V8R I could not spot the patch which introduced ARM_V8R. Can you rename this to ARM64_V8R ? The reason being the underlying code is specific to R82 ie 64 bit V8R. - Ayan > ---help--- > Choose which hardware platform to enable in Xen. > > @@ -8,13 +9,14 @@ choice > > config ALL_PLAT > bool "All Platforms" > + depends on !ARM_V8R > ---help--- > Enable support for all available hardware platforms. It doesn't > automatically select any of the related drivers. > > config QEMU > bool "QEMU aarch virt machine support" > - depends on ARM_64 > + depends on ARM_64 && !ARM_V8R > select GICV3 > select HAS_PL011 > ---help--- > @@ -23,7 +25,7 @@ config QEMU > > config RCAR3 > bool "Renesas RCar3 support" > - depends on ARM_64 > + depends on ARM_64 && !ARM_V8R > select HAS_SCIF > select IPMMU_VMSA > ---help--- > @@ -31,14 +33,22 @@ config RCAR3 > > config MPSOC > bool "Xilinx Ultrascale+ MPSoC support" > - depends on ARM_64 > + depends on ARM_64 && !ARM_V8R > select HAS_CADENCE_UART > select ARM_SMMU > ---help--- > Enable all the required drivers for Xilinx Ultrascale+ MPSoC > > +config FVP_BASER > + bool "Fixed Virtual Platform BaseR support" > + depends on ARM_V8R > + help > + Enable platform specific configurations for Fixed Virtual > + Platform BaseR > + > config NO_PLAT > bool "No Platforms" > + depends on !ARM_V8R > ---help--- > Do not enable specific support for any platform. > > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Mon Nov 14 18:58:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 18:58:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443518.698101 (Exim 4.92) (envelope-from ) id 1oueev-0005Uw-Oh; Mon, 14 Nov 2022 18:58:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443518.698101; Mon, 14 Nov 2022 18:58:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueev-0005Pz-B8; Mon, 14 Nov 2022 18:58:17 +0000 Received: by outflank-mailman (input) for mailman id 443518; Mon, 14 Nov 2022 18:58:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueeu-0004ue-1t for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 18:58:16 +0000 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 486b2258-644e-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 19:58:12 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 10:58:09 -0800 Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 14 Nov 2022 10:58:00 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id C6A02B7; Mon, 14 Nov 2022 20:58:24 +0200 (EET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 486b2258-644e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668452292; x=1699988292; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=SgviM+szPWE2044JxOu+kP67kq5kn9HLyQETM9NFZ+0=; b=JHSQG6ACS3ppEqIAHtiCn+E4aYwFK8Q0VoKDsJ4/X6+U9kSs9rF0vzM8 qfUSWj808Or1iGiWkk0bBDAx+eK96iyOt5pTBCzq75pLfZvrsMWw41Pck +WSGzfzl/fl6CKqzWvFMaK6O5YtYzPj67yf/AEYlg+JbOwmtAOog5AZKK GE09GxEyOF6dAWKKDTylyEnTGZU4Rot9JC7IdlP0mJuySGzdD/DqcN7ck dfmJ3UUF6qtqnZVOSk0Gl6W+AVoTbc+Q9EYXGLqVME482SOqfT3J5+YVg HKfkmMvrqJzOPjtjj5IG2QP9Mvl7ee0v+okn7dl6+f8Vh9wjD3FxH+xdm w==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="376319562" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="376319562" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="638607288" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="638607288" From: Andy Shevchenko To: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Mika Westerberg , Andy Shevchenko , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH v3 1/4] PCI: Introduce pci_dev_for_each_resource() Date: Mon, 14 Nov 2022 20:58:19 +0200 Message-Id: <20221114185822.65038-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221114185822.65038-1-andriy.shevchenko@linux.intel.com> References: <20221114185822.65038-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mika Westerberg Instead of open-coding it everywhere introduce a tiny helper that can be used to iterate over each resource of a PCI device, and convert the most obvious users into it. While at it drop doubled empty line before pdev_sort_resources(). No functional changes intended. Suggested-by: Andy Shevchenko Signed-off-by: Mika Westerberg Signed-off-by: Andy Shevchenko --- .clang-format | 2 ++ arch/alpha/kernel/pci.c | 5 ++--- arch/arm/kernel/bios32.c | 16 +++++++--------- arch/mips/pci/pci-legacy.c | 3 +-- arch/powerpc/kernel/pci-common.c | 5 ++--- arch/sparc/kernel/leon_pci.c | 5 ++--- arch/sparc/kernel/pci.c | 10 ++++------ arch/sparc/kernel/pcic.c | 5 ++--- drivers/pci/remove.c | 5 ++--- drivers/pci/setup-bus.c | 26 ++++++++++---------------- drivers/pci/setup-res.c | 4 +--- drivers/pci/xen-pcifront.c | 4 +--- include/linux/pci.h | 11 +++++++++++ 13 files changed, 47 insertions(+), 54 deletions(-) diff --git a/.clang-format b/.clang-format index f98481a53ea8..08d579fea6cf 100644 --- a/.clang-format +++ b/.clang-format @@ -520,6 +520,8 @@ ForEachMacros: - 'of_property_for_each_string' - 'of_property_for_each_u32' - 'pci_bus_for_each_resource' + - 'pci_dev_for_each_resource' + - 'pci_dev_for_each_resource_p' - 'pci_doe_for_each_off' - 'pcl_for_each_chunk' - 'pcl_for_each_segment' diff --git a/arch/alpha/kernel/pci.c b/arch/alpha/kernel/pci.c index 64fbfb0763b2..4458eb7f44f0 100644 --- a/arch/alpha/kernel/pci.c +++ b/arch/alpha/kernel/pci.c @@ -288,11 +288,10 @@ pcibios_claim_one_bus(struct pci_bus *b) struct pci_bus *child_bus; list_for_each_entry(dev, &b->devices, bus_list) { + struct resource *r; int i; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *r = &dev->resource[i]; - + pci_dev_for_each_resource(dev, r, i) { if (r->parent || !r->start || !r->flags) continue; if (pci_has_flag(PCI_PROBE_ONLY) || diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c index e7ef2b5bea9c..5254734b23e6 100644 --- a/arch/arm/kernel/bios32.c +++ b/arch/arm/kernel/bios32.c @@ -142,15 +142,15 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_WINBOND2, PCI_DEVICE_ID_WINBOND2_89C940F, */ static void pci_fixup_dec21285(struct pci_dev *dev) { - int i; - if (dev->devfn == 0) { + struct resource *r; + dev->class &= 0xff; dev->class |= PCI_CLASS_BRIDGE_HOST << 8; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - dev->resource[i].start = 0; - dev->resource[i].end = 0; - dev->resource[i].flags = 0; + pci_dev_for_each_resource_p(dev, r) { + r->start = 0; + r->end = 0; + r->flags = 0; } } } @@ -162,13 +162,11 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_DEC, PCI_DEVICE_ID_DEC_21285, pci_fixup_d static void pci_fixup_ide_bases(struct pci_dev *dev) { struct resource *r; - int i; if ((dev->class >> 8) != PCI_CLASS_STORAGE_IDE) return; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - r = dev->resource + i; + pci_dev_for_each_resource_p(dev, r) { if ((r->start & ~0x80) == 0x374) { r->start |= 2; r->end = r->start; diff --git a/arch/mips/pci/pci-legacy.c b/arch/mips/pci/pci-legacy.c index 468722c8a5c6..ec2567f8efd8 100644 --- a/arch/mips/pci/pci-legacy.c +++ b/arch/mips/pci/pci-legacy.c @@ -249,12 +249,11 @@ static int pcibios_enable_resources(struct pci_dev *dev, int mask) pci_read_config_word(dev, PCI_COMMAND, &cmd); old_cmd = cmd; - for (idx = 0; idx < PCI_NUM_RESOURCES; idx++) { + pci_dev_for_each_resource(dev, r, idx) { /* Only set up the requested stuff */ if (!(mask & (1<resource[idx]; if (!(r->flags & (IORESOURCE_IO | IORESOURCE_MEM))) continue; if ((idx == PCI_ROM_RESOURCE) && diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c index d67cf79bf5d0..8ddcfa6bcb50 100644 --- a/arch/powerpc/kernel/pci-common.c +++ b/arch/powerpc/kernel/pci-common.c @@ -1452,11 +1452,10 @@ void pcibios_claim_one_bus(struct pci_bus *bus) struct pci_bus *child_bus; list_for_each_entry(dev, &bus->devices, bus_list) { + struct resource *r; int i; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *r = &dev->resource[i]; - + pci_dev_for_each_resource(dev, r, i) { if (r->parent || !r->start || !r->flags) continue; diff --git a/arch/sparc/kernel/leon_pci.c b/arch/sparc/kernel/leon_pci.c index e5e5ff6b9a5c..b6663a3fbae9 100644 --- a/arch/sparc/kernel/leon_pci.c +++ b/arch/sparc/kernel/leon_pci.c @@ -62,15 +62,14 @@ void leon_pci_init(struct platform_device *ofdev, struct leon_pci_info *info) int pcibios_enable_device(struct pci_dev *dev, int mask) { + struct resource *res; u16 cmd, oldcmd; int i; pci_read_config_word(dev, PCI_COMMAND, &cmd); oldcmd = cmd; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *res = &dev->resource[i]; - + pci_dev_for_each_resource(dev, res, i) { /* Only set up the requested stuff */ if (!(mask & (1<devices, bus_list) { + struct resource *r; int i; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *r = &dev->resource[i]; - + pci_dev_for_each_resource(dev, r, i) { if (r->parent || !r->start || !r->flags) continue; @@ -724,15 +723,14 @@ struct pci_bus *pci_scan_one_pbm(struct pci_pbm_info *pbm, int pcibios_enable_device(struct pci_dev *dev, int mask) { + struct resource *res; u16 cmd, oldcmd; int i; pci_read_config_word(dev, PCI_COMMAND, &cmd); oldcmd = cmd; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *res = &dev->resource[i]; - + pci_dev_for_each_resource(dev, res, i) { /* Only set up the requested stuff */ if (!(mask & (1<resource[i]; - + pci_dev_for_each_resource(dev, res, i) { /* Only set up the requested stuff */ if (!(mask & (1<resource + i; + pci_dev_for_each_resource_p(dev, res) { if (res->parent) release_resource(res); } diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index dfa490da728d..7ba5f1ca0e38 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -124,20 +124,17 @@ static resource_size_t get_res_add_align(struct list_head *head, return dev_res ? dev_res->min_align : 0; } - /* Sort resources by alignment */ static void pdev_sort_resources(struct pci_dev *dev, struct list_head *head) { + struct resource *r; int i; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *r; + pci_dev_for_each_resource(dev, r, i) { struct pci_dev_resource *dev_res, *tmp; resource_size_t r_align; struct list_head *n; - r = &dev->resource[i]; - if (r->flags & IORESOURCE_PCI_FIXED) continue; @@ -895,10 +892,9 @@ static void pbus_size_io(struct pci_bus *bus, resource_size_t min_size, min_align = window_alignment(bus, IORESOURCE_IO); list_for_each_entry(dev, &bus->devices, bus_list) { - int i; + struct resource *r; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *r = &dev->resource[i]; + pci_dev_for_each_resource_p(dev, r) { unsigned long r_size; if (r->parent || !(r->flags & IORESOURCE_IO)) @@ -1014,10 +1010,10 @@ static int pbus_size_mem(struct pci_bus *bus, unsigned long mask, size = 0; list_for_each_entry(dev, &bus->devices, bus_list) { + struct resource *r; int i; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - struct resource *r = &dev->resource[i]; + pci_dev_for_each_resource(dev, r, i) { resource_size_t r_size; if (r->parent || (r->flags & IORESOURCE_PCI_FIXED) || @@ -1358,11 +1354,10 @@ static void assign_fixed_resource_on_bus(struct pci_bus *b, struct resource *r) */ static void pdev_assign_fixed_resources(struct pci_dev *dev) { - int i; + struct resource *r; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { + pci_dev_for_each_resource_p(dev, r) { struct pci_bus *b; - struct resource *r = &dev->resource[i]; if (r->parent || !(r->flags & IORESOURCE_PCI_FIXED) || !(r->flags & (IORESOURCE_IO | IORESOURCE_MEM))) @@ -1845,13 +1840,12 @@ static void pci_bus_distribute_available_resources(struct pci_bus *bus, * peers of the upstream port. */ list_for_each_entry(dev, &bus->devices, bus_list) { - int i; + struct resource *dev_res; if (dev == bridge) continue; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - const struct resource *dev_res = &dev->resource[i]; + pci_dev_for_each_resource_p(dev, dev_res) { resource_size_t dev_sz; struct resource *b_res; diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c index b492e67c3d87..967f9a758923 100644 --- a/drivers/pci/setup-res.c +++ b/drivers/pci/setup-res.c @@ -484,12 +484,10 @@ int pci_enable_resources(struct pci_dev *dev, int mask) pci_read_config_word(dev, PCI_COMMAND, &cmd); old_cmd = cmd; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { + pci_dev_for_each_resource(dev, r, i) { if (!(mask & (1 << i))) continue; - r = &dev->resource[i]; - if (!(r->flags & (IORESOURCE_IO | IORESOURCE_MEM))) continue; if ((i == PCI_ROM_RESOURCE) && diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c index 7378e2f3e525..ce485ef59656 100644 --- a/drivers/pci/xen-pcifront.c +++ b/drivers/pci/xen-pcifront.c @@ -390,9 +390,7 @@ static int pcifront_claim_resource(struct pci_dev *dev, void *data) int i; struct resource *r; - for (i = 0; i < PCI_NUM_RESOURCES; i++) { - r = &dev->resource[i]; - + pci_dev_for_each_resource(dev, r, i) { if (!r->parent && r->start && r->flags) { dev_info(&pdev->xdev->dev, "claiming resource %s/%d\n", pci_name(dev), i); diff --git a/include/linux/pci.h b/include/linux/pci.h index 28af4414f789..010996c2801a 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1407,6 +1407,17 @@ int pci_request_selected_regions(struct pci_dev *, int, const char *); int pci_request_selected_regions_exclusive(struct pci_dev *, int, const char *); void pci_release_selected_regions(struct pci_dev *, int); +#define __pci_dev_for_each_resource(dev, res, __i, vartype) \ + for (vartype __i = 0; \ + res = &(dev)->resource[__i], __i < PCI_NUM_RESOURCES; \ + __i++) + +#define pci_dev_for_each_resource(dev, res, i) \ + __pci_dev_for_each_resource(dev, res, i, ) + +#define pci_dev_for_each_resource_p(dev, res) \ + __pci_dev_for_each_resource(dev, res, i, unsigned int) + /* drivers/pci/bus.c */ void pci_add_resource(struct list_head *resources, struct resource *res); void pci_add_resource_offset(struct list_head *resources, struct resource *res, -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 18:58:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 18:58:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443514.698071 (Exim 4.92) (envelope-from ) id 1oueet-0004uw-Sq; Mon, 14 Nov 2022 18:58:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443514.698071; Mon, 14 Nov 2022 18:58:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueet-0004up-P8; Mon, 14 Nov 2022 18:58:15 +0000 Received: by outflank-mailman (input) for mailman id 443514; Mon, 14 Nov 2022 18:58:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueer-0004uP-My for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 18:58:14 +0000 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46c81b66-644e-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 19:58:09 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 10:58:07 -0800 Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 14 Nov 2022 10:58:00 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id D3F58339; Mon, 14 Nov 2022 20:58:24 +0200 (EET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46c81b66-644e-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668452290; x=1699988290; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=numBEsV1q/Om3fxX1l7iCo0BjtXyl8aomr/TeEIcP9Q=; b=VSJqgRIb2g2/P9EZLQCDdEtfonV+JioxPyu8NIR7CsfQxfD0VYJQ6vr0 7SCkUuJuKz37JgoLVFZBYEiqFUgwtFF8uvlbnspXFA+mVVWHfkrG1yQxC EThb2KKs8hn2qzBsehlktSyIedAtz0S740GA/KPb1cF9nJ6F+hlZ/C/lY kBeFVM/OuXEIt5qRK6T+mpuyflERjqBOdLcg542HlSk28+5EMY5f6TQXQ 7pjsbqoMiIgTAQIyMJHbP9xAGp4H/Kp1xgz1LjUGQPfvjlkHioOpCxcPu L+lPC7Xb6GVgNv9OgeMrKUuR90fWJsXB4Dlw/B4iY+cTOsFxOo/ddhioZ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="295415986" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="295415986" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="638607275" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="638607275" From: Andy Shevchenko To: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Mika Westerberg , Andy Shevchenko , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH v3 2/4] PCI: Split pci_bus_for_each_resource_p() out of pci_bus_for_each_resource() Date: Mon, 14 Nov 2022 20:58:20 +0200 Message-Id: <20221114185822.65038-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221114185822.65038-1-andriy.shevchenko@linux.intel.com> References: <20221114185822.65038-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Refactor pci_bus_for_each_resource() in the same way as it's done in pci_dev_for_each_resource() case. This will allow to hide iterator inside the loop, where it's not used otherwise. No functional changes intended. Signed-off-by: Andy Shevchenko --- .clang-format | 1 + drivers/pci/bus.c | 7 +++---- drivers/pci/hotplug/shpchp_sysfs.c | 8 ++++---- drivers/pci/pci.c | 5 ++--- drivers/pci/probe.c | 2 +- drivers/pci/setup-bus.c | 10 ++++------ include/linux/pci.h | 14 ++++++++++---- 7 files changed, 25 insertions(+), 22 deletions(-) diff --git a/.clang-format b/.clang-format index 08d579fea6cf..b61fd8791346 100644 --- a/.clang-format +++ b/.clang-format @@ -520,6 +520,7 @@ ForEachMacros: - 'of_property_for_each_string' - 'of_property_for_each_u32' - 'pci_bus_for_each_resource' + - 'pci_bus_for_each_resource_p' - 'pci_dev_for_each_resource' - 'pci_dev_for_each_resource_p' - 'pci_doe_for_each_off' diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c index 3cef835b375f..fc8e9c11c5f2 100644 --- a/drivers/pci/bus.c +++ b/drivers/pci/bus.c @@ -161,13 +161,13 @@ static int pci_bus_alloc_from_region(struct pci_bus *bus, struct resource *res, void *alignf_data, struct pci_bus_region *region) { - int i, ret; struct resource *r, avail; resource_size_t max; + int ret; type_mask |= IORESOURCE_TYPE_BITS; - pci_bus_for_each_resource(bus, r, i) { + pci_bus_for_each_resource_p(bus, r) { resource_size_t min_used = min; if (!r) @@ -264,9 +264,8 @@ bool pci_bus_clip_resource(struct pci_dev *dev, int idx) struct resource *res = &dev->resource[idx]; struct resource orig_res = *res; struct resource *r; - int i; - pci_bus_for_each_resource(bus, r, i) { + pci_bus_for_each_resource_p(bus, r) { resource_size_t start, end; if (!r) diff --git a/drivers/pci/hotplug/shpchp_sysfs.c b/drivers/pci/hotplug/shpchp_sysfs.c index 64beed7a26be..ff04f0c5e7c3 100644 --- a/drivers/pci/hotplug/shpchp_sysfs.c +++ b/drivers/pci/hotplug/shpchp_sysfs.c @@ -24,16 +24,16 @@ static ssize_t show_ctrl(struct device *dev, struct device_attribute *attr, char *buf) { struct pci_dev *pdev; - int index, busnr; struct resource *res; struct pci_bus *bus; size_t len = 0; + int busnr; pdev = to_pci_dev(dev); bus = pdev->subordinate; len += sysfs_emit_at(buf, len, "Free resources: memory\n"); - pci_bus_for_each_resource(bus, res, index) { + pci_bus_for_each_resource_p(bus, res) { if (res && (res->flags & IORESOURCE_MEM) && !(res->flags & IORESOURCE_PREFETCH)) { len += sysfs_emit_at(buf, len, @@ -43,7 +43,7 @@ static ssize_t show_ctrl(struct device *dev, struct device_attribute *attr, char } } len += sysfs_emit_at(buf, len, "Free resources: prefetchable memory\n"); - pci_bus_for_each_resource(bus, res, index) { + pci_bus_for_each_resource_p(bus, res) { if (res && (res->flags & IORESOURCE_MEM) && (res->flags & IORESOURCE_PREFETCH)) { len += sysfs_emit_at(buf, len, @@ -53,7 +53,7 @@ static ssize_t show_ctrl(struct device *dev, struct device_attribute *attr, char } } len += sysfs_emit_at(buf, len, "Free resources: IO\n"); - pci_bus_for_each_resource(bus, res, index) { + pci_bus_for_each_resource_p(bus, res) { if (res && (res->flags & IORESOURCE_IO)) { len += sysfs_emit_at(buf, len, "start = %8.8llx, length = %8.8llx\n", diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 9f3cc829dfee..9cb9939f0e79 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -782,9 +782,8 @@ struct resource *pci_find_parent_resource(const struct pci_dev *dev, { const struct pci_bus *bus = dev->bus; struct resource *r; - int i; - pci_bus_for_each_resource(bus, r, i) { + pci_bus_for_each_resource_p(bus, r) { if (!r) continue; if (resource_contains(r, res)) { @@ -802,7 +801,7 @@ struct resource *pci_find_parent_resource(const struct pci_dev *dev, * be both a positively-decoded aperture and a * subtractively-decoded region that contain the BAR. * We want the positively-decoded one, so this depends - * on pci_bus_for_each_resource() giving us those + * on pci_bus_for_each_resource_p() giving us those * first. */ return r; diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 1e234189aff1..8ec59b895c60 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -533,7 +533,7 @@ void pci_read_bridge_bases(struct pci_bus *child) pci_read_bridge_mmio_pref(child); if (dev->transparent) { - pci_bus_for_each_resource(child->parent, res, i) { + pci_bus_for_each_resource_p(child->parent, res) { if (res && res->flags) { pci_bus_add_resource(child, res, PCI_SUBTRACTIVE_DECODE); diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index 7ba5f1ca0e38..1e9896eaf89c 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -770,9 +770,8 @@ static struct resource *find_bus_resource_of_type(struct pci_bus *bus, unsigned long type) { struct resource *r, *r_assigned = NULL; - int i; - pci_bus_for_each_resource(bus, r, i) { + pci_bus_for_each_resource_p(bus, r) { if (r == &ioport_resource || r == &iomem_resource) continue; if (r && (r->flags & type_mask) == type && !r->parent) @@ -1204,7 +1203,7 @@ void __pci_bus_size_bridges(struct pci_bus *bus, struct list_head *realloc_head) additional_mmio_pref_size = 0; struct resource *pref; struct pci_host_bridge *host; - int hdr_type, i, ret; + int hdr_type, ret; list_for_each_entry(dev, &bus->devices, bus_list) { struct pci_bus *b = dev->subordinate; @@ -1228,7 +1227,7 @@ void __pci_bus_size_bridges(struct pci_bus *bus, struct list_head *realloc_head) host = to_pci_host_bridge(bus->bridge); if (!host->size_windows) return; - pci_bus_for_each_resource(bus, pref, i) + pci_bus_for_each_resource_p(bus, pref) if (pref && (pref->flags & IORESOURCE_PREFETCH)) break; hdr_type = -1; /* Intentionally invalid - not a PCI device. */ @@ -1333,12 +1332,11 @@ EXPORT_SYMBOL(pci_bus_size_bridges); static void assign_fixed_resource_on_bus(struct pci_bus *b, struct resource *r) { - int i; struct resource *parent_r; unsigned long mask = IORESOURCE_IO | IORESOURCE_MEM | IORESOURCE_PREFETCH; - pci_bus_for_each_resource(b, parent_r, i) { + pci_bus_for_each_resource_p(b, parent_r) { if (!parent_r) continue; diff --git a/include/linux/pci.h b/include/linux/pci.h index 010996c2801a..7b2dcadfc457 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1433,10 +1433,16 @@ int devm_request_pci_bus_resources(struct device *dev, /* Temporary until new and working PCI SBR API in place */ int pci_bridge_secondary_bus_reset(struct pci_dev *dev); -#define pci_bus_for_each_resource(bus, res, i) \ - for (i = 0; \ - (res = pci_bus_resource_n(bus, i)) || i < PCI_BRIDGE_RESOURCE_NUM; \ - i++) +#define __pci_bus_for_each_resource(bus, res, __i, vartype) \ + for (vartype __i = 0; \ + res = pci_bus_resource_n(bus, __i), __i < PCI_BRIDGE_RESOURCE_NUM; \ + __i++) + +#define pci_bus_for_each_resource(bus, res, i) \ + __pci_bus_for_each_resource(bus, res, i, ) + +#define pci_bus_for_each_resource_p(bus, res) \ + __pci_bus_for_each_resource(bus, res, i, unsigned int) int __must_check pci_bus_alloc_resource(struct pci_bus *bus, struct resource *res, resource_size_t size, -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 18:58:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 18:58:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443516.698081 (Exim 4.92) (envelope-from ) id 1oueeu-00056C-F5; Mon, 14 Nov 2022 18:58:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443516.698081; Mon, 14 Nov 2022 18:58:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueeu-00054t-9s; Mon, 14 Nov 2022 18:58:16 +0000 Received: by outflank-mailman (input) for mailman id 443516; Mon, 14 Nov 2022 18:58:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueet-0004uP-3M for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 18:58:15 +0000 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a60fd36-644e-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 19:58:14 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 10:58:09 -0800 Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 14 Nov 2022 10:58:00 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id BAA212F3; Mon, 14 Nov 2022 20:58:24 +0200 (EET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a60fd36-644e-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668452294; x=1699988294; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=x6ggnXnghcO12tbT4wtQfhiqCsVpusNaj/2IGyQVVxI=; b=IM10jECloPmVSCbg7ParEby9o0yD3PknIZd/mY/nBkVE/4iDjQDjG2ov WBuML95fIkQcTEj83ZfUoiI3FDY1twhNlq/OoC3xwiVZ4pRcwLvlvy9n/ XmGd9dvL2Q/sDUXNR5lz/4mo6HWO1ElC3kMqJ25ZX3aqmGcNSGq/c74Yh 7QceVieRoAy8bxS8wo+bt7Si9rn8pPeyaDyd11tW12VUxXN4hS6t6L7GO Dl+47Oyj547YnXho76kowMVPjhZ8Stv0rEM9gkcgNpWJb4KsmoBAO+64R oQ0E31rLisMGbDFMBPtIbIpKaJubFMG70gAOF66LQBBClYOFUBTDAyd8d g==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="295416003" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="295416003" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="638607285" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="638607285" From: Andy Shevchenko To: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Mika Westerberg , Andy Shevchenko , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH v3 0/4] PCI: Add pci_dev_for_each_resource() helper and Date: Mon, 14 Nov 2022 20:58:18 +0200 Message-Id: <20221114185822.65038-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Provide two new helper macros to iterate over PCI device resources and convert users. Looking at it, refactor existing pci_bus_for_each_resource() and convert users accordingly. This applies on top of this patch Mika sent out earlier: https://lore.kernel.org/r/20221114115953.40236-1-mika.westerberg@linux.intel.com Changelog v3: - rebased on top of v2 by Mika, see above - added tag to pcmcia patch (Dominik) Changelog v2: - refactor to have two macros - refactor existing pci_bus_for_each_resource() in the same way and convert users Andy Shevchenko (3): PCI: Split pci_bus_for_each_resource_p() out of pci_bus_for_each_resource() EISA: Convert to use pci_bus_for_each_resource_p() pcmcia: Convert to use pci_bus_for_each_resource_p() Mika Westerberg (1): PCI: Introduce pci_dev_for_each_resource() .clang-format | 3 +++ arch/alpha/kernel/pci.c | 5 ++--- arch/arm/kernel/bios32.c | 16 ++++++------- arch/mips/pci/pci-legacy.c | 3 +-- arch/powerpc/kernel/pci-common.c | 5 ++--- arch/sparc/kernel/leon_pci.c | 5 ++--- arch/sparc/kernel/pci.c | 10 ++++----- arch/sparc/kernel/pcic.c | 5 ++--- drivers/eisa/pci_eisa.c | 4 ++-- drivers/pci/bus.c | 7 +++--- drivers/pci/hotplug/shpchp_sysfs.c | 8 +++---- drivers/pci/pci.c | 5 ++--- drivers/pci/probe.c | 2 +- drivers/pci/remove.c | 5 ++--- drivers/pci/setup-bus.c | 36 ++++++++++++------------------ drivers/pci/setup-res.c | 4 +--- drivers/pci/xen-pcifront.c | 4 +--- drivers/pcmcia/rsrc_nonstatic.c | 9 +++----- drivers/pcmcia/yenta_socket.c | 3 +-- include/linux/pci.h | 25 +++++++++++++++++---- 20 files changed, 78 insertions(+), 86 deletions(-) -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 18:58:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 18:58:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443517.698090 (Exim 4.92) (envelope-from ) id 1oueeu-0005Bs-Sb; Mon, 14 Nov 2022 18:58:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443517.698090; Mon, 14 Nov 2022 18:58:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueeu-0005AO-Lz; Mon, 14 Nov 2022 18:58:16 +0000 Received: by outflank-mailman (input) for mailman id 443517; Mon, 14 Nov 2022 18:58:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueet-0004ue-9K for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 18:58:15 +0000 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 48400cd8-644e-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 19:58:12 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 10:58:07 -0800 Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 14 Nov 2022 10:58:00 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id E1657346; Mon, 14 Nov 2022 20:58:24 +0200 (EET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48400cd8-644e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668452292; x=1699988292; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EaNuN468AX7oVVNzygbZKjeVdiuKUVO8jdpIxMpvwBE=; b=P5lylLczFWdt3wgH0tzVk+MLwe3rodaFgnK+V/FMEqBRctSACz5Z+hMQ vMeeybnRp7fFa9kKQnpu2Td7mN65RjEw48sqMWFaDyrm5+HcnFiJeUuyb wd4B4nh2gyI/TRAHmCvRQKDdJqHveplyKl5LrtBJzHKMjN/wNEAPnvaLe YHGX4HH0PLu9tasxsFzVy8nx/DslH8/oCpWxAnbO7IyD2Q2MjuDl02g0Z fdwCBcnDQw4Ln+Rv/5Ez/n27Fjy5JmL9qHsmU+fmYB+NrgeqXroxQydL8 z01dTrtwyAmt9NAW+f8tpCzHilISUY7llQW8a50QeO9LyNgk5oqi7z2+h Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="295415990" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="295415990" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="638607277" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="638607277" From: Andy Shevchenko To: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Mika Westerberg , Andy Shevchenko , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH v3 3/4] EISA: Convert to use pci_bus_for_each_resource_p() Date: Mon, 14 Nov 2022 20:58:21 +0200 Message-Id: <20221114185822.65038-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221114185822.65038-1-andriy.shevchenko@linux.intel.com> References: <20221114185822.65038-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The pci_bus_for_each_resource_p() hides the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Signed-off-by: Andy Shevchenko --- drivers/eisa/pci_eisa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/eisa/pci_eisa.c b/drivers/eisa/pci_eisa.c index 930c2332c3c4..907b86384396 100644 --- a/drivers/eisa/pci_eisa.c +++ b/drivers/eisa/pci_eisa.c @@ -20,8 +20,8 @@ static struct eisa_root_device pci_eisa_root; static int __init pci_eisa_init(struct pci_dev *pdev) { - int rc, i; struct resource *res, *bus_res = NULL; + int rc; if ((rc = pci_enable_device (pdev))) { dev_err(&pdev->dev, "Could not enable device\n"); @@ -38,7 +38,7 @@ static int __init pci_eisa_init(struct pci_dev *pdev) * eisa_root_register() can only deal with a single io port resource, * so we use the first valid io port resource. */ - pci_bus_for_each_resource(pdev->bus, res, i) + pci_bus_for_each_resource_p(pdev->bus, res) if (res && (res->flags & IORESOURCE_IO)) { bus_res = res; break; -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 18:58:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 18:58:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443515.698077 (Exim 4.92) (envelope-from ) id 1oueeu-0004yS-50; Mon, 14 Nov 2022 18:58:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443515.698077; Mon, 14 Nov 2022 18:58:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueeu-0004xQ-1B; Mon, 14 Nov 2022 18:58:16 +0000 Received: by outflank-mailman (input) for mailman id 443515; Mon, 14 Nov 2022 18:58:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouees-0004uP-HJ for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 18:58:14 +0000 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 49b6d320-644e-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 19:58:12 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 10:58:09 -0800 Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 14 Nov 2022 10:58:00 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id EECC2348; Mon, 14 Nov 2022 20:58:24 +0200 (EET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49b6d320-644e-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668452292; x=1699988292; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BZMLhTwKqFLidxOVtwWq081cCaNo7ow4HF5ovB57GGE=; b=aPyQYIOGt3ALpsf7qnIz8dkBQX8iT6ykijN7i68DddUhjbbh6GKYyYHT RnKsmwjQzBor8bmmNs4W8aeslrLwqg5ycjeJNQuAwqzOifVyfCtwYZzUU 9+ue3guDRbbjM5+RqbnzBQdZocdW7rF5jmHJxAa8pcJSN9MbS4vmYs4tA HtCK4Cqazr4wQSQymKyM64wzEFZ2xZJX0AKQ6h3j61FtfXI5n6626vA3W LMWCY5nIpBIt1H3J8BcME5H9/0u7ND8xT+Wo21JWDnz4dbVEaiFcrR/2e rbvs/8Dho1LjQX0qyxPzdnv9haMN/ChZdDOgu+w3RRseYMPlALNg5z+5F w==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="295415999" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="295415999" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="638607286" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="638607286" From: Andy Shevchenko To: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Mika Westerberg , Andy Shevchenko , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH v3 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p() Date: Mon, 14 Nov 2022 20:58:22 +0200 Message-Id: <20221114185822.65038-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221114185822.65038-1-andriy.shevchenko@linux.intel.com> References: <20221114185822.65038-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The pci_bus_for_each_resource_p() hides the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Signed-off-by: Andy Shevchenko Acked-by: Dominik Brodowski --- drivers/pcmcia/rsrc_nonstatic.c | 9 +++------ drivers/pcmcia/yenta_socket.c | 3 +-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c index ad1141fddb4c..9d92d4bb6239 100644 --- a/drivers/pcmcia/rsrc_nonstatic.c +++ b/drivers/pcmcia/rsrc_nonstatic.c @@ -934,7 +934,7 @@ static int adjust_io(struct pcmcia_socket *s, unsigned int action, unsigned long static int nonstatic_autoadd_resources(struct pcmcia_socket *s) { struct resource *res; - int i, done = 0; + int done = 0; if (!s->cb_dev || !s->cb_dev->bus) return -ENODEV; @@ -960,12 +960,9 @@ static int nonstatic_autoadd_resources(struct pcmcia_socket *s) */ if (s->cb_dev->bus->number == 0) return -EINVAL; - - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) { - res = s->cb_dev->bus->resource[i]; -#else - pci_bus_for_each_resource(s->cb_dev->bus, res, i) { #endif + + pci_bus_for_each_resource_p(s->cb_dev->bus, res) { if (!res) continue; diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c index 3966a6ceb1ac..b200f2b99a7a 100644 --- a/drivers/pcmcia/yenta_socket.c +++ b/drivers/pcmcia/yenta_socket.c @@ -673,9 +673,8 @@ static int yenta_search_res(struct yenta_socket *socket, struct resource *res, u32 min) { struct resource *root; - int i; - pci_bus_for_each_resource(socket->dev->bus, root, i) { + pci_bus_for_each_resource_p(socket->dev->bus, root) { if (!root) continue; -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 19:09:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 19:09:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443537.698126 (Exim 4.92) (envelope-from ) id 1oueq7-0000TO-Jp; Mon, 14 Nov 2022 19:09:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443537.698126; Mon, 14 Nov 2022 19:09:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueq7-0000TH-Gc; Mon, 14 Nov 2022 19:09:51 +0000 Received: by outflank-mailman (input) for mailman id 443537; Mon, 14 Nov 2022 19:09:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueq6-0000T7-IO; Mon, 14 Nov 2022 19:09:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueq6-0005et-EA; Mon, 14 Nov 2022 19:09:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oueq5-0006lG-SX; Mon, 14 Nov 2022 19:09:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oueq5-0004CD-Rz; Mon, 14 Nov 2022 19:09:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=A3V9Q0UaGG9bs0C6qPq7frWcZ/n3iTDLUNgtumdeIhg=; b=bmC0e4psp0KON/ThT5ySQaYFFp yuf1o5nY5VbEVe1MTRE2+y/vkBn8P0GCT7EqJTsytw1yP03iTEcvrrRYq0tGlnYGGA+eh6rHLxXc8 ggetvDCYcH0VbYtfjiaZaYBJO5m/M7vIp87sgSaQ8icDuyKeFnDSv5gEkSBb4LbTsgq0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174765: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-armhf-armhf-examine:host-install:broken:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=771a8acbb84145b943bd608ba376e104ebfa9664 X-Osstest-Versions-That: linux=b70bfeb98635040588883503d2760e0f46231491 From: osstest service owner Date: Mon, 14 Nov 2022 19:09:49 +0000 flight 174765 linux-5.4 real [real] flight 174771 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174765/ http://logs.test-lab.xenproject.org/osstest/logs/174771/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-examine 5 host-install broken pass in 174758 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174758 pass in 174765 test-armhf-armhf-libvirt-raw 13 guest-start fail in 174758 pass in 174765 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 174758 pass in 174771-retest test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 174758 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 174758 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 174758 test-armhf-armhf-libvirt-qcow2 13 guest-start fail pass in 174758 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 174758 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 174758 like 174540 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 174758 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 174758 never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 174758 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174540 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174540 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174540 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174540 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174540 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174540 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 771a8acbb84145b943bd608ba376e104ebfa9664 baseline version: linux b70bfeb98635040588883503d2760e0f46231491 Last test of basis 174540 2022-10-29 12:41:57 Z 16 days Failing since 174575 2022-11-01 18:42:39 Z 13 days 24 attempts Testing same since 174727 2022-11-10 22:13:32 Z 3 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: "Darrick J. Wong" Aaron Conole Abhinav Kumar Adrian Hunter Alexander Aring Alexander Stein Andrew Morton Anna Schumaker Anssi Hannula Ard Biesheuvel Arnaldo Carvalho de Melo Biju Das Brian Foster Brian Norris Carlos Llamas Chandan Babu R Chen Zhongjin Chen Zhou Chris Packham Christian A. Ehrhardt Chuhong Yuan Damien Le Moal Dan Carpenter Darrick J. Wong Darrick J. Wong Dave Chinner Dave Chinner David S. Miller David Sterba Dean Luick Demi Marie Obenour Dennis Dalessandro Dokyung Song Dongliang Mu Eric Dumazet Eric Sandeen Filipe Manana Florian Fainelli Gaosheng Cui Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Han Xu Hangyu Hua Hannu Hartikainen Hans Verkuil Heiko Carstens Heiko Stuebner Helge Deller Hyong Youb Kim Hyunwoo Kim Håkon Bugge Ilias Apalodimas Ilya Maximets Jacob Keller Jakub Kicinski Jan Beulich Jason A. Donenfeld Jason Gunthorpe Jeff Vanhoof Jens Axboe Jens Glathe Jim Mattson Jimmy Assarsson Jiri Kosina Johan Hovold John Veness Jon Hunter Jon Maloy Jonathan Cameron Jonathan Corbet Josh Poimboeuf Juergen Gross Julian Anastasov Justin Chen Kalle Valo Kan Liang Konrad Jankowski Kuniyuki Iwashima Kuogee Hsieh Leon Romanovsky Leon Romanovsky Li Qiang Linus Torvalds Linux Kernel Functional Testing Luiz Augusto von Dentz Luiz Capitulino Luís Henriques M. Vefa Bicakci Marc Kleine-Budde Marek Marczykowski-Górecki Mario Limonciello Martin K. Petersen Martin Tůma Masami Hiramatsu (Google) Mateusz Palczewski Mathias Nyman Matthew Ma Matti Vaittinen Mauro Carvalho Chehab Maxim Levitsky Maxim Mikityanskiy Meena Shanmugam Michal Hocko Michal Jaron Michal Simek Mike Kravetz Miklos Szeredi Miquel Raynal Nathan Huckleberry Neal Cardwell Nicolas Dichtel Oleksij Rempel Pablo Neira Ayuso Paolo Abeni Paolo Bonzini Paul E. McKenney Paul Moore Peter Zijlstra (Intel) Peter Zijlstra Rafael J. Wysocki Raju Rangoju Randy Dunlap Rasmus Villemoes Richard Weinberger Rik van Riel Saeed Mahameed Sakari Ailus Samuel Bailey Sascha Hauer Sasha Levin Serge Hallyn Sergey Shtylyov Shakeel Butt Shang XiaoJing Shreeya Patel Shuah Khan Slawomir Laba Stefan Schmidt Steven Rostedt (Google) Sudeep Holla Sudip Mukherjee Sylwester Dziedziuch Takashi Iwai Tariq Toukan Tejun Heo Theodore Ts'o Thinh Nguyen Tim Harvey Tom Lendacky Tomasz Moń Tony O'Brien Trond Myklebust Tvrtko Ursulin Uday Shankar Ulf Hansson Vasily Averin Vasily Gorbik Ville Syrjälä Vineet Gupta Vladimir Oltean Wei Yongjun Willy Tarreau Wolfram Sang Xin Long Yang Yingliang Ye Bin Yongqin Liu Yu Kuai Zhang Changzhong Zhang Qilong Zhang Xiaoxu Zheng Yejian Zhengchao Shao Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine fail test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-step test-armhf-armhf-examine host-install Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git b70bfeb98635..771a8acbb841 771a8acbb84145b943bd608ba376e104ebfa9664 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 19:20:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 19:20:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443547.698148 (Exim 4.92) (envelope-from ) id 1ouf0m-0003Fj-Tg; Mon, 14 Nov 2022 19:20:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443547.698148; Mon, 14 Nov 2022 19:20:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouf0m-0003Fc-Qf; Mon, 14 Nov 2022 19:20:52 +0000 Received: by outflank-mailman (input) for mailman id 443547; Mon, 14 Nov 2022 19:20:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouf0l-0003F1-Ab for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 19:20:51 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 70bd97cc-6451-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 20:20:48 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 9EF3D32009B0; Mon, 14 Nov 2022 14:20:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 14 Nov 2022 14:20:46 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Nov 2022 14:20:43 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70bd97cc-6451-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1668453645; x=1668540045; bh=oqI/+sgvZ2 OKVRaSTG42v6mrCeoTzSNksNPbobAHtyw=; b=nZQvOB/3uWzHry1FZf0mIgSsio TvpqbQFtXxVW9joxJ7lW/EuPyJU8PRYnedTs4mAqvG/tc5l1Pc1970/9Sbmg/t7p EZbllWG966ciU059asbn53Ip6E5nQhynPE7mvJUIsUC1sE5Fq/a7sbfEeozLuBaX InUaggTqErhrhpqDFMNyjV230YOSnrWTr2INMzE0wER/nUXhoDk0pFCTSGt8wh7A aRacxuWdLD6BxgGXfCh+q4OobrVRWwh+byCc0+yxwFJ291Mcqs/Ki2GebVEzzNvH jMjMEDVDqF/PytoU0LwsFEY/maS8b5g5gBgzr5yc7qs8mQGAdd/kYEKhNzLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1668453645; x= 1668540045; bh=oqI/+sgvZ2OKVRaSTG42v6mrCeoTzSNksNPbobAHtyw=; b=D 2P5sBpbEsNu6MaRLAFp5J8quqclpPDdJRkMM1LI903pFADdgAXtiEoVTcOPQ4wiZ otXWafF8iM8VcODK7xQr8K1sDHD0Tn2tT30tIcdEI4zpAWSONS/yhRA4nCi5M+SI ff+gcGkeMBKFvKLbcqJE2wfQ5BC6oY20wLOpmPyQRfJwmxeBoOE+1S9H9FRgpJtY MNFl+H44gOFYLbmjtngCof2icNN0cnIY8sE5HCYsA+ucYZYdXMTbs3KYwfQxuRGN T15Vv6pUYKJdLeOTNp/W3yJVX6QWzlfDA1iRFQGW5VT/7ICnw9WcV1IBk+RDneFa 4tLIoK+iUNeySmtbZYEtg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgedvgdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfeu udehgfdvfeehhedujeehfeduveeugefhkefhheelgeevudetueeiudfggfffnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org (open list:X86 Xen CPUs) Subject: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen Date: Mon, 14 Nov 2022 20:20:11 +0100 Message-Id: <20221114192011.1539233-2-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> References: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The /dev/mem is used for two purposes: - reading PCI_MSIX_ENTRY_CTRL_MASKBIT - reading Pending Bit Array (PBA) The first one was originally done because when Xen did not send all vector ctrl writes to the device model, so QEMU might have outdated old register value. This has been changed in Xen, so QEMU can now use its cached value of the register instead. The Pending Bit Array (PBA) handling is for the case where it lives on the same page as the MSI-X table itself. Xen has been extended to handle this case too (as well as other registers that may live on those pages), so QEMU handling is not necessary anymore. Removing /dev/mem access is useful to work within stubdomain, and necessary when dom0 kernel runs in lockdown mode. Signed-off-by: Marek Marczykowski-Górecki --- hw/xen/xen_pt.h | 1 - hw/xen/xen_pt_msi.c | 51 ++++----------------------------------------- 2 files changed, 4 insertions(+), 48 deletions(-) diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index e7c4316a7d..de4094e7ec 100644 --- a/hw/xen/xen_pt.h +++ b/hw/xen/xen_pt.h @@ -206,7 +206,6 @@ typedef struct XenPTMSIX { uint32_t table_offset_adjust; /* page align mmap */ uint64_t mmio_base_addr; MemoryRegion mmio; - void *phys_iomem_base; XenPTMSIXEntry msix_entry[]; } XenPTMSIX; diff --git a/hw/xen/xen_pt_msi.c b/hw/xen/xen_pt_msi.c index b71563f98a..a8a75dff66 100644 --- a/hw/xen/xen_pt_msi.c +++ b/hw/xen/xen_pt_msi.c @@ -460,15 +460,7 @@ static void pci_msix_write(void *opaque, hwaddr addr, entry->updated = true; } else if (msix->enabled && entry->updated && !(val & PCI_MSIX_ENTRY_CTRL_MASKBIT)) { - const volatile uint32_t *vec_ctrl; - - /* - * If Xen intercepts the mask bit access, entry->vec_ctrl may not be - * up-to-date. Read from hardware directly. - */ - vec_ctrl = s->msix->phys_iomem_base + entry_nr * PCI_MSIX_ENTRY_SIZE - + PCI_MSIX_ENTRY_VECTOR_CTRL; - xen_pt_msix_update_one(s, entry_nr, *vec_ctrl); + xen_pt_msix_update_one(s, entry_nr, entry->latch(VECTOR_CTRL)); } set_entry_value(entry, offset, val); @@ -493,7 +485,9 @@ static uint64_t pci_msix_read(void *opaque, hwaddr addr, return get_entry_value(&msix->msix_entry[entry_nr], offset); } else { /* Pending Bit Array (PBA) */ - return *(uint32_t *)(msix->phys_iomem_base + addr); + XEN_PT_LOG(&s->dev, "reading PBA, addr %#lx, offset %#lx\n", + addr, addr - msix->total_entries * PCI_MSIX_ENTRY_SIZE); + return 0xFFFFFFFF; } } @@ -529,7 +523,6 @@ int xen_pt_msix_init(XenPCIPassthroughState *s, uint32_t base) int i, total_entries, bar_index; XenHostPCIDevice *hd = &s->real_device; PCIDevice *d = &s->dev; - int fd = -1; XenPTMSIX *msix = NULL; int rc = 0; @@ -576,34 +569,6 @@ int xen_pt_msix_init(XenPCIPassthroughState *s, uint32_t base) msix->table_base = s->real_device.io_regions[bar_index].base_addr; XEN_PT_LOG(d, "get MSI-X table BAR base 0x%"PRIx64"\n", msix->table_base); - fd = open("/dev/mem", O_RDWR); - if (fd == -1) { - rc = -errno; - XEN_PT_ERR(d, "Can't open /dev/mem: %s\n", strerror(errno)); - goto error_out; - } - XEN_PT_LOG(d, "table_off = 0x%x, total_entries = %d\n", - table_off, total_entries); - msix->table_offset_adjust = table_off & 0x0fff; - msix->phys_iomem_base = - mmap(NULL, - total_entries * PCI_MSIX_ENTRY_SIZE + msix->table_offset_adjust, - PROT_READ, - MAP_SHARED | MAP_LOCKED, - fd, - msix->table_base + table_off - msix->table_offset_adjust); - close(fd); - if (msix->phys_iomem_base == MAP_FAILED) { - rc = -errno; - XEN_PT_ERR(d, "Can't map physical MSI-X table: %s\n", strerror(errno)); - goto error_out; - } - msix->phys_iomem_base = (char *)msix->phys_iomem_base - + msix->table_offset_adjust; - - XEN_PT_LOG(d, "mapping physical MSI-X table to %p\n", - msix->phys_iomem_base); - memory_region_add_subregion_overlap(&s->bar[bar_index], table_off, &msix->mmio, 2); /* Priority: pci default + 1 */ @@ -624,14 +589,6 @@ void xen_pt_msix_unmap(XenPCIPassthroughState *s) return; } - /* unmap the MSI-X memory mapped register area */ - if (msix->phys_iomem_base) { - XEN_PT_LOG(&s->dev, "unmapping physical MSI-X table from %p\n", - msix->phys_iomem_base); - munmap(msix->phys_iomem_base, msix->total_entries * PCI_MSIX_ENTRY_SIZE - + msix->table_offset_adjust); - } - memory_region_del_subregion(&s->bar[msix->bar_index], &msix->mmio); } -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 19:20:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 19:20:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443546.698137 (Exim 4.92) (envelope-from ) id 1ouf0j-0002zz-Mm; Mon, 14 Nov 2022 19:20:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443546.698137; Mon, 14 Nov 2022 19:20:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouf0j-0002zs-KC; Mon, 14 Nov 2022 19:20:49 +0000 Received: by outflank-mailman (input) for mailman id 443546; Mon, 14 Nov 2022 19:20:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouf0h-0002zm-Fn for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 19:20:47 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6f26e228-6451-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 20:20:45 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4306932009F4; Mon, 14 Nov 2022 14:20:42 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 14 Nov 2022 14:20:42 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Nov 2022 14:20:40 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f26e228-6451-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1668453641; x=1668540041; bh=GH/JWXPsdg09JGNt1E/t/7yRp8zml7s1JpL dNsT07i0=; b=l4ek2n98KvwRy1A3BfKCbpoIuRMQ0ZayIbq81LVAUPwAr0MegJW TFH2EcLlPSnEMPlP2HRVPD7w+h6P0vBlcAM/z9FzsXYtd9majPOdJVNgxKnCWlDh iu+Zrl5/UVL85jX3sczJ34YxLFzVAZmt4+r7/zQiQC9zktk9+o8NJomoAbLWzGRy O6VcqIrrOTJXKD1R0wweQw/S4nTQBcHh0ejQ3kZbtDG+Wh0QVVYyZPB2x2PobGut s58+3nDJ3ikrMxmAyvZ5SdvhI7X/gfE8af4ikVm9qahUq0qbS5YtVUIghTwtmu5S lmwU4Jnd0eG5igv5DNVcj7EuWRyIBpvOPLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1668453641; x=1668540041; bh=GH/JWXPsdg09J GNt1E/t/7yRp8zml7s1JpLdNsT07i0=; b=aNJtZykfI6WDSLw5FBqPaNH98ubt1 rixjr8H23RxZCqUmrGIqsBbs7MazMfVCno2aJBtHpKbTK8QWh9qtQdogTyZ2s1yw Gqo+mh7IC9gf1vzPysozfO5J6n5AB+zGgPekKxcJtZl264l9kSfozpo1NpNm7BbB c6yL9bqHtp47UViJ8Z+n1VeHijQx6pyjCnJMafWd4/Emx/LOZoOUHF2kbEbVC++e mSOqcBXTF0QQEImPD+CYKa9tNXaz8VGrlTgWxFqCjPU1Qjpix0DTEMiBc9KquA8B zhMrgVSD+AK9kOzjkW3MbZQwjrbNmIhnLv2sf5NjTDCFpQfHGV5iGL9yA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgedvgdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffogggtgfesthekredtredtjeenucfhrhhomhepofgrrhgvkhcu ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepleekhfdu leetleelleetteevfeefteffkeetteejheelgfegkeelgeehhfdthedvnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org (open list:X86 Xen CPUs) Subject: [PATCH 1/2] hw/xen/xen_pt: Call default handler only if no custom one is set Date: Mon, 14 Nov 2022 20:20:10 +0100 Message-Id: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Call pci_default_write_config() in xen_pt_pci_write_config() only for registers that do not have custom handler, and do that only after resolving them. This is important for two reasons: 1. XenPTRegInfo has ro_mask which needs to be enforced - Xen-specific hooks do that on their own (especially xen_pt_*_reg_write()). 2. Not setting value early allows the hooks to see the old value too. If it would be only about the first point, setting PCIDevice.wmask would probably be sufficient, but given the second point, restructure those writes. Signed-off-by: Marek Marczykowski-Górecki --- hw/xen/xen_pt.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 0ec7e52183..269bd26109 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -255,6 +255,7 @@ static void xen_pt_pci_write_config(PCIDevice *d, uint32_t addr, uint32_t find_addr = addr; XenPTRegInfo *reg = NULL; bool wp_flag = false; + uint32_t emul_mask = 0, write_val; if (xen_pt_pci_config_access_check(d, addr, len)) { return; @@ -310,7 +311,6 @@ static void xen_pt_pci_write_config(PCIDevice *d, uint32_t addr, } memory_region_transaction_begin(); - pci_default_write_config(d, addr, val, len); /* adjust the read and write value to appropriate CFC-CFF window */ read_val <<= (addr & 3) << 3; @@ -370,6 +370,8 @@ static void xen_pt_pci_write_config(PCIDevice *d, uint32_t addr, return; } + emul_mask |= ( (1 << (reg->size * 8) ) - 1 ) << ((find_addr & 3) * 8); + /* calculate next address to find */ emul_len -= reg->size; if (emul_len > 0) { @@ -396,6 +398,24 @@ static void xen_pt_pci_write_config(PCIDevice *d, uint32_t addr, /* need to shift back before passing them to xen_host_pci_set_block. */ val >>= (addr & 3) << 3; + /* store emulated registers that didn't have specific hooks */ + write_val = val; + for (index = 0; emul_mask; index += emul_len) { + emul_len = 0; + while (emul_mask & 0xff) { + emul_len++; + emul_mask >>= 8; + } + if (emul_len) { + uint32_t mask = ((1 << (emul_len * 8)) - 1); + pci_default_write_config(d, addr, write_val & mask, emul_len); + write_val >>= emul_len * 8; + } else { + emul_mask >>= 8; + write_val >>= 8; + } + } + memory_region_transaction_commit(); out: -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 19:21:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 19:21:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443551.698159 (Exim 4.92) (envelope-from ) id 1ouf1F-0003yB-6D; Mon, 14 Nov 2022 19:21:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443551.698159; Mon, 14 Nov 2022 19:21:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouf1F-0003y4-3D; Mon, 14 Nov 2022 19:21:21 +0000 Received: by outflank-mailman (input) for mailman id 443551; Mon, 14 Nov 2022 19:21:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouf1E-0003F1-78 for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 19:21:20 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 839dd65a-6451-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 20:21:19 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 51083320096E; Mon, 14 Nov 2022 14:21:17 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 14 Nov 2022 14:21:17 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Nov 2022 14:21:15 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 839dd65a-6451-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1668453676; x=1668540076; bh=nPfMqp058g7kRRkTy0PrtYx6pL+BIhReFJy JxLlMvDU=; b=adB/wBdxqn4/pY6JIFrxF6O1vOBh44yy4R4Dc2AZL08q4ws41M5 xI/6lI96evI9Zf3+P97qNAHGg5AwCEVE1ItUteABcYnD8ofDZ4G9EIakwcVYt23i qQaICE23Ct2ItuohBscfgzZ6yyN1DTSINqt//+E0pIL39xDPimxW+Y8apZi3fpYf FNBkBjgCanTFoEz7HbQYK9lrZyEDwfIA1ABy+wB3I4Hrw8DgE9KV1FiGbdgNghPc +NJ5J2Q0fM/wvH74TPNx1a4mvqI/AAPGyZ3Oc6ksm3JPgeRCzrAlZ1YPPpf8lva6 MoPezvGUMpsViTcfLaba83fEj5UFl+oPfqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1668453676; x=1668540076; bh=nPfMqp058g7kR RkTy0PrtYx6pL+BIhReFJyJxLlMvDU=; b=SD2laVW9Ax8rDvDZpjGg6HEw90BFA xWiAwbnB8WGQuLHNn22HG92VuL5ipHx4+A5lCz2SL8RUcHlCuR85GmwhyWn6nqRM WzI/rqpDaDyZVb9jfkvOkTiOmjisKchSKuGZKRu3HsDXtfdgv9/pGh+m/gAF/wxR vL7i0lYbFTOE3GEAD140RLIDpyn92Dz4bc/MKXfGcHib/68S1Hj+4U6wGFq2N1jL TL7PNZmEvTL+k86rqpTNJR8TKIubbDJRPsOiplAMF+v8IpzN7WSy3bJq9UhQcMbz LmfnYwVDOcVeFvFeq5TmekV8Y0L+hFC0P4st/naRROEXfK4iBNLlJ66fw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgedvgdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffogggtgfesthekredtredtjeenucfhrhhomhepofgrrhgvkhcu ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepleekhfdu leetleelleetteevfeefteffkeetteejheelgfegkeelgeehhfdthedvnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 1/2] x86/msi: passthrough all MSI-X vector ctrl writes to device model Date: Mon, 14 Nov 2022 20:20:59 +0100 Message-Id: <20221114192100.1539267-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit QEMU needs to know whether clearing maskbit of a vector is really clearing, or was already cleared before. Currently Xen sends only clearing that bit to the device model, but not setting it, so QEMU cannot detect it. Because of that, QEMU is working this around by checking via /dev/mem, but that isn't the proper approach. Give all necessary information to QEMU by passing all ctrl writes, including masking a vector. Signed-off-by: Marek Marczykowski-Górecki --- xen/arch/x86/hvm/vmsi.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c index 75f92885dc5e..ba4cf46dfe91 100644 --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -271,7 +271,8 @@ out: } static int msixtbl_write(struct vcpu *v, unsigned long address, - unsigned int len, unsigned long val) + unsigned int len, unsigned long val, + bool completion) { unsigned long offset; struct msixtbl_entry *entry; @@ -343,7 +344,7 @@ static int msixtbl_write(struct vcpu *v, unsigned long address, unlock: spin_unlock_irqrestore(&desc->lock, flags); - if ( len == 4 ) + if ( len == 4 && completion ) r = X86EMUL_OKAY; out: @@ -355,7 +356,7 @@ static int cf_check _msixtbl_write( const struct hvm_io_handler *handler, uint64_t address, uint32_t len, uint64_t val) { - return msixtbl_write(current, address, len, val); + return msixtbl_write(current, address, len, val, false); } static bool cf_check msixtbl_range( @@ -633,7 +634,7 @@ void msix_write_completion(struct vcpu *v) return; v->arch.hvm.hvm_io.msix_unmask_address = 0; - if ( msixtbl_write(v, ctrl_address, 4, 0) != X86EMUL_OKAY ) + if ( msixtbl_write(v, ctrl_address, 4, 0, true) != X86EMUL_OKAY ) gdprintk(XENLOG_WARNING, "MSI-X write completion failure\n"); } -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 19:21:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 19:21:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443552.698170 (Exim 4.92) (envelope-from ) id 1ouf1I-0004Gj-E3; Mon, 14 Nov 2022 19:21:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443552.698170; Mon, 14 Nov 2022 19:21:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouf1I-0004Gb-BH; Mon, 14 Nov 2022 19:21:24 +0000 Received: by outflank-mailman (input) for mailman id 443552; Mon, 14 Nov 2022 19:21:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouf1G-0002zm-ME for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 19:21:22 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 84ff66a9-6451-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 20:21:21 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id A67C332009FA; Mon, 14 Nov 2022 14:21:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 14 Nov 2022 14:21:20 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Nov 2022 14:21:18 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84ff66a9-6451-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1668453679; x=1668540079; bh=iC8thv4qLJ 7PkjWlqKqVMAcrz0XwAyc92QmmRYSHSqo=; b=DfNwMY2jrVVxMvhWOZDiHwPFCw Z6nNtugf72yWtJ9drXdixom2Gc6+QcrYmOI+XvwOxgn51o9lxuti5Qnq+GB3Pc/1 KrP9R3fylTRGXeE1HK38tBhl04RjsGtREI5N/uAaSf9WPCIEOAsDjgZnj3t7nmfZ wmhi77fZDMeO2RZVcDrZQNrVBpE7A3eHn+7/bLN3UvviJKjXpIwWf1is/7iteXWz aUOsWg28i1V9F9KdvZ801urx17Mg+nVbtrt7k6OC+c7tKW5Er7hFrUf2ibyFJzQN eFvxKimzDKYX3/YdjlQicxRJ2Q6qSk9vMZEciwBEBSRJPCD9SWTqdWT5IM1Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1668453679; x= 1668540079; bh=iC8thv4qLJ7PkjWlqKqVMAcrz0XwAyc92QmmRYSHSqo=; b=E MiT0XDkGlxu3+U2zuoZOOk7Eypuez6xQwfRO663ycRpyPNPYSkTfMABA6Vg2VJCh SlDIDclXEC43gQJt36KkziG/Yl1I9VzdfbaFFeuEKedEht5yy0JMzimGq99qctdF c0IH6keNPAluVm4GYkRAXPibsI83dIRwVmyvNCgbvuObsf+ZWQYMHbEIaIcrMBri zi0tPf62daDhGaaaoSxM0aVgL2Cz+N2sgycgLHZMhHRHuvYQlUKiec2F3sZxFT+z AvaQplrKnZnD5yofGyt22DsG5UItSarHgkF5sEStqew05q2bwS3Zvbjt7MAw1W/c B92MSy47bkakVleKTcmRg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgedvgdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfeu udehgfdvfeehhedujeehfeduveeugefhkefhheelgeevudetueeiudfggfffnecuvehluh hsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 2/2] x86/msi: Allow writes to registers on the same page as MSI-X table Date: Mon, 14 Nov 2022 20:21:00 +0100 Message-Id: <20221114192100.1539267-2-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221114192100.1539267-1-marmarek@invisiblethingslab.com> References: <20221114192100.1539267-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some devices (notably Intel Wifi 6 AX210 card) keep auxiliary registers on the same page as MSI-X table. Device model (especially one in stubdomain) cannot really handle those, as direct writes to that page is refused (page is on mmio_ro_ranges list). Instead, add internal ioreq server that handle those writes. This may be also used to read Pending Bit Array, if it lives on the same page, making QEMU not needing /dev/mem access at all (especially helpful with lockdown enabled in dom0). If PBA lives on another page, it can be (and will be) mapped to the guest directly. If PBA lives on the same page, forbid writes. Technically, writes outside of PBA could be allowed, but at this moment the precise location of PBA isn't saved. Signed-off-by: Marek Marczykowski-Górecki --- xen/arch/x86/hvm/vmsi.c | 135 +++++++++++++++++++++++++++++++++ xen/arch/x86/include/asm/msi.h | 1 + xen/arch/x86/msi.c | 21 +++++ 3 files changed, 157 insertions(+) diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c index ba4cf46dfe91..57cfcf70741e 100644 --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -428,6 +428,133 @@ static const struct hvm_io_ops msixtbl_mmio_ops = { .write = _msixtbl_write, }; +static void __iomem *msixtbl_page_handler_get_hwaddr( + const struct vcpu *v, + uint64_t address, + bool write) +{ + struct domain *d = v->domain; + struct pci_dev *pdev = NULL; + struct msixtbl_entry *entry; + void __iomem *ret = NULL; + uint64_t table_end_addr; + + rcu_read_lock(&msixtbl_rcu_lock); + /* + * Check if it's on the same page as the end of the MSI-X table, but + * outside of the table itself. + */ + list_for_each_entry( entry, &d->arch.hvm.msixtbl_list, list ) + if ( PFN_DOWN(address) == PFN_DOWN(entry->gtable + entry->table_len) && + address >= entry->gtable + entry->table_len ) + { + pdev = entry->pdev; + break; + } + rcu_read_unlock(&msixtbl_rcu_lock); + + if ( !pdev ) + return NULL; + + ASSERT( pdev->msix ); + + table_end_addr = (pdev->msix->table.first << PAGE_SHIFT) + + pdev->msix->nr_entries * PCI_MSIX_ENTRY_SIZE; + ASSERT( PFN_DOWN(table_end_addr) == pdev->msix->table.last ); + + /* If PBA lives on the same page too, forbid writes. */ + if ( write && pdev->msix->table.last == pdev->msix->pba.first ) + return NULL; + + if ( pdev->msix->last_table_page ) + ret = pdev->msix->last_table_page + (address & (PAGE_SIZE - 1)); + else + gdprintk(XENLOG_WARNING, + "MSI-X last_table_page not initialized for %04x:%02x:%02x.%u\n", + pdev->seg, + pdev->bus, + PCI_SLOT(pdev->devfn), + PCI_FUNC(pdev->devfn)); + + return ret; +} + +static bool cf_check msixtbl_page_accept( + const struct hvm_io_handler *handler, const ioreq_t *r) +{ + unsigned long addr = r->addr; + + ASSERT( r->type == IOREQ_TYPE_COPY ); + + return msixtbl_page_handler_get_hwaddr( + current, addr, r->dir == IOREQ_WRITE); +} + +static int cf_check msixtbl_page_read( + const struct hvm_io_handler *handler, + uint64_t address, uint32_t len, uint64_t *pval) +{ + void __iomem *hwaddr = msixtbl_page_handler_get_hwaddr( + current, address, false); + + if ( !hwaddr ) + return X86EMUL_UNHANDLEABLE; + + switch ( len ) { + case 1: + *pval = readb(hwaddr); + break; + case 2: + *pval = readw(hwaddr); + break; + case 4: + *pval = readl(hwaddr); + break; + case 8: + *pval = readq(hwaddr); + break; + default: + return X86EMUL_UNHANDLEABLE; + } + return X86EMUL_OKAY; +} + +static int cf_check msixtbl_page_write( + const struct hvm_io_handler *handler, + uint64_t address, uint32_t len, uint64_t val) +{ + void __iomem *hwaddr = msixtbl_page_handler_get_hwaddr( + current, address, true); + + if ( !hwaddr ) + return X86EMUL_UNHANDLEABLE; + + switch ( len ) { + case 1: + writeb(val, hwaddr); + break; + case 2: + writew(val, hwaddr); + break; + case 4: + writel(val, hwaddr); + break; + case 8: + writeq(val, hwaddr); + break; + default: + return X86EMUL_UNHANDLEABLE; + } + return X86EMUL_OKAY; + +} + +static const struct hvm_io_ops msixtbl_mmio_page_ops = { + .accept = msixtbl_page_accept, + .read = msixtbl_page_read, + .write = msixtbl_page_write, +}; + static void add_msixtbl_entry(struct domain *d, struct pci_dev *pdev, uint64_t gtable, @@ -583,6 +710,14 @@ void msixtbl_init(struct domain *d) handler->type = IOREQ_TYPE_COPY; handler->ops = &msixtbl_mmio_ops; } + + /* passthrough access to other registers on the same page */ + handler = hvm_next_io_handler(d); + if ( handler ) + { + handler->type = IOREQ_TYPE_COPY; + handler->ops = &msixtbl_mmio_page_ops; + } } void msixtbl_pt_cleanup(struct domain *d) diff --git a/xen/arch/x86/include/asm/msi.h b/xen/arch/x86/include/asm/msi.h index fe670895eed2..d4287140f04c 100644 --- a/xen/arch/x86/include/asm/msi.h +++ b/xen/arch/x86/include/asm/msi.h @@ -236,6 +236,7 @@ struct arch_msix { } table, pba; int table_refcnt[MAX_MSIX_TABLE_PAGES]; int table_idx[MAX_MSIX_TABLE_PAGES]; + void __iomem *last_table_page; spinlock_t table_lock; bool host_maskall, guest_maskall; domid_t warned; diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index d0bf63df1def..e7fe41f424d8 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -961,6 +961,21 @@ static int msix_capability_init(struct pci_dev *dev, domain_crash(d); /* XXX How to deal with existing mappings? */ } + + /* + * If the MSI-X table doesn't span full page(s), map the last page for + * passthrough accesses. + */ + if ( (msix->nr_entries * PCI_MSIX_ENTRY_SIZE) & (PAGE_SIZE - 1) ) + { + uint64_t entry_paddr = table_paddr + msix->nr_entries * PCI_MSIX_ENTRY_SIZE; + int idx = msix_get_fixmap(msix, table_paddr, entry_paddr); + + if ( idx >= 0 ) + msix->last_table_page = fix_to_virt(idx); + else + gprintk(XENLOG_ERR, "Failed to map last MSI-X table page: %d\n", idx); + } } WARN_ON(msix->table.first != (table_paddr >> PAGE_SHIFT)); ++msix->used_entries; @@ -1090,6 +1105,12 @@ static void _pci_cleanup_msix(struct arch_msix *msix) WARN(); msix->table.first = 0; msix->table.last = 0; + if ( msix->last_table_page ) + { + msix_put_fixmap(msix, + virt_to_fix((unsigned long)msix->last_table_page)); + msix->last_table_page = 0; + } if ( rangeset_remove_range(mmio_ro_ranges, msix->pba.first, msix->pba.last) ) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 19:40:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 19:40:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443568.698181 (Exim 4.92) (envelope-from ) id 1oufJL-0006s1-3l; Mon, 14 Nov 2022 19:40:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443568.698181; Mon, 14 Nov 2022 19:40:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oufJK-0006rL-Up; Mon, 14 Nov 2022 19:40:02 +0000 Received: by outflank-mailman (input) for mailman id 443568; Mon, 14 Nov 2022 19:40:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oufJJ-0006cc-Bx for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 19:40:01 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e82b18d-6454-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 20:39:59 +0100 (CET) Received: from mail-bn8nam12lp2169.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Nov 2022 14:39:53 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5610.namprd03.prod.outlook.com (2603:10b6:806:b2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 19:39:49 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8eca:f9cc:8bf5:83a6]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8eca:f9cc:8bf5:83a6%5]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 19:39:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e82b18d-6454-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668454799; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=7gWQsTtoviTYbO4eqLT38yq1u5IitY5vz9hOq+o1nnQ=; b=O0760g9nIn61Z9aTLQu/0v1/KTQoPOcDVrKJWI/210rOGY3E2953HXJq hvMb2ySGCqCgCdHTwTM0M0DS26d86aaVSaH9DNj+I+qN7cx0MScafguiq kRTnUwde0RQCCzW3/hJ5Eq0htZNva0poeVk8mlSzlYKQICkqgg6EiW17f k=; X-IronPort-RemoteIP: 104.47.55.169 X-IronPort-MID: 84797466 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:zoGjUKD3yj9EARVW/8viw5YqxClBgxIJ4kV8jS/XYbTApGh00DYHy jBJCGCOaK2LamvxfIxyOdyx9UwGvceEn9ZmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpB4gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwp9lGQmJU9 PEjETUWQQHdmv260rLic7w57igjBJGD0II3nFhFlGucJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+OxuvTm7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr+TwnKkBNxMfFG+3v1Rjnuy7GZKND1ITFLk/aKI0WqHcM0Kf iT4/QJr98De7neDS9DnWhSirX2svxgCWsFRGek39AGMzKXP5w+TQGMDS1ZpcdEjqYo6SCIn0 nePmNXmAyEpt6eaIVqG7audpz62PSkTLEcBaDUCQA9D5MPsyKkrhw/LZsZuFuiylNKdMSH9x XWGoTYzg50XjNUXzOOr8FbfmTWuq5PVCAkv6W3qsnmN6wp4YMuvYdyu4F2Ct/JYdt/HHx+Go WQOnNWY4KYWF5aRmSeRQeILWra0+/KCNz6aillqd3U8ywmQF7eYVdg4yFlDyI1BaJpslePBC KMLhT5s2Q== IronPort-HdrOrdr: A9a23:z1LX069tIWtKpQZSvVJuk+Hwdr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirCWekD+y77b+Mh6AmjMTSSlGz7sO+X XM11WR3NTjj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhn8lwqyY4xlerua+BQ4uvum5loGmM TF5z0gI8NwwXXMeXzdm2qi5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe F29lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQFo+dY7bWfHAbIcYa 5T5fLnlbBrmJShHinkV1xUsZiRt7IIb0+7qwY5y5eoOnNt7Q1EJgMjtbAidzE7hdIAotB/lp r52u4DrsAwcuYGKa16H+sPWs2xFyjERg/NKnubJRD9GLgAIG+lke+/3FwZ3pDcRHUz9upFpL 3RFFdD8WIicUPnDsODmJVN7xDWWW24GTDg0NtX6ZR1sqD1AOODC1zJdHk+18+75/kPCMzSXP i+fJpQHv/4NGPrXYJExRf3VZVeIWQXFMcVptE4UVSTpd+jEPyjisXLNPLIYLb9GzctXW3yRn MFQTjoPc1FqlumX3fp6SKhL08FunaPiK6YPJKqjNT7krJ9R7GkmjJl+WiR94WMNSBItLAwcQ 93PK7n+5nL11WLwQ== X-IronPort-AV: E=Sophos;i="5.96,164,1665460800"; d="scan'208";a="84797466" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LiyBj+etWIPIcMya8mv2nJzD2DDRIbS4NerLA2MbhRwC3+K2G85yShncCVVePtU66VrvcyKpxrye3ZtPUItYNwjV0xbi3PhzuOU3CWvstW6ORckDsP0AfQX7y6x7EmCwc5supw2+LBTQdqWqrjhkR7Z+5a1PdprL6qt1R/rs1dQ7hpkq6UYu4j+OR3u3Q3+ixtEWaUJJd2Q0+n2lauqSHkM2XljCjxbUnRysQdf11GrZsiAarzjIL1uhF5Tgto2UGWu7Dg/zubnrS2F7U1HiI3ib8G4P3lB8YXGRARy2rCh93V8/A2JGGNJ1yhganXlNZT3dEVAnsf9eHBuOeon2gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7gWQsTtoviTYbO4eqLT38yq1u5IitY5vz9hOq+o1nnQ=; b=YHNZ51IUlnKZFqXo/rpa7fZcpWkAlhUODLhHvQu+LrinOfMxlxEOLl4/cWf7u49hsI7K+97ELPJepkklHdEyL8hfrkHnlJ0pkKQW/kdBwTnQDV1iRR8QtKtNv0AA6GNWHZ3bQfSr3SpWTE5f5g8eC/sa/XDAzO4yLAHgadqsw8EdwyXLIEI6rLOnARR8zn/ehzaTBvmAQQDgG/ksOBOMK2I/uT/7dYK+1WNAQde0cRmUiOnBelOLKWp76SHexBR5R5R3+PM+nSYf6dNsXTCsx3sDeMuI2aQgpZg6/EL5tjm5Aaa63xCznkrruqkVz8FXBy+Ci4qHFRWmxiGvUEtbfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7gWQsTtoviTYbO4eqLT38yq1u5IitY5vz9hOq+o1nnQ=; b=uqdbSWuB/2BS8tB6eCendTE/VKhm4zlJCKD7cDwR360KKDfa0y+RrWNbpsFn+q7/fogar4MQeYxb4MTrzvg2/d9/Ox/myJOehSumNEdXjjk02s6rRARJDD2rJ88wnChgtzCAaD5qMyGFbWWPWTmPjniCDQW32BPt6uKcr4/MP28= From: Andrew Cooper To: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , "qemu-devel@nongnu.org" CC: Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen Thread-Topic: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen Thread-Index: AQHY+F5BmJFZlWQQDUevznp0C5ln9a4+0PkA Date: Mon, 14 Nov 2022 19:39:48 +0000 Message-ID: <5f2b496a-f1dc-aa45-9600-aa9e5bbede8e@citrix.com> References: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> <20221114192011.1539233-2-marmarek@invisiblethingslab.com> In-Reply-To: <20221114192011.1539233-2-marmarek@invisiblethingslab.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA0PR03MB5610:EE_ x-ms-office365-filtering-correlation-id: e6fd53ed-4e37-40e0-7f88-08dac677fdc9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Jrn2/T+NTZTKAkcxIjDsAUZr0hbzoEroykQNvpyhagrB8gvVtsFWQSXYPzIoGJ/iVHzM9u1mmwnoHcCiI6O4q3zS/J/1qbNLmgNYhpGELGHQ2yvUznho+qY0HxfAXE8vnfPNB0ql5ImpOWkkiZHsvxEtmBsXZDkyjlX+b//oRBfVFdAypGvGjahSYgSIWAWuFE+FVVnr0ZZbCpZVxtGGpJ1CzSIAEWD5ZIwSvxCdOTW1ykYRWzT3FXMIIXy93p+371evekCRmOBJ9VCcZNOdG1Ln3TkcFkHf2ZXK+aw0e4AqeYYE4JqC9Hr7zVRY3DysQgZgfqX7vSMO1Y9TGwpaLTPIwdtxJfhlgOY2Gtj+0pQqkUvaR7vc/SHH11oLCbvFoiD1wzOkE27AVC4CPE3PXLkp8xXb2Mja7UA4zO589zRtOfNrJfGLXaYJVZVg4jLlA95Qq5qhr5CBpcBRfkoe5pI/61NCYk0LQ6ZzFm+1k7QNbPTeyePokSqnQQZjP95LRAjsEADvfeCuq5tDZ+ktZVWJiOssU5hIKZnT8a9NdEa+f7eC8a66s+xXETS0r4kqjTlhotH+oqQTa7waLuMI6JNcwuz1KX4oDUc3a0Ik1VETEyardjPJwNBWNYtQvFfFTJoV7DDb74smbBty4ekaOEIFAEB5jd0XSPsB4OKCYcUmCr+zIo1EXw/4Y07AndmA/VZE8H8FITF5Hc9WzJ+gUpesHE+BWw40cebtB1n78H4aUQVq4CqANle+jd+yvrr5awHGYBBbiGefGlxarPiM9s0ah059ze0y07rX2YdwWCxqE8Nxw91guzmaxk5Ive/T x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(376002)(136003)(346002)(451199015)(26005)(5660300002)(31696002)(41300700001)(86362001)(8936002)(2906002)(2616005)(122000001)(83380400001)(186003)(6512007)(316002)(38100700002)(82960400001)(66946007)(91956017)(66574015)(110136005)(66556008)(66446008)(8676002)(4326008)(64756008)(66476007)(54906003)(6506007)(76116006)(6486002)(53546011)(71200400001)(478600001)(31686004)(38070700005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bDE1TE14azVyS2JJME1KM21IRDRmZ2pvMFNnWXhZN2VqTi9OY0RSUkc1SVVI?= =?utf-8?B?THNaQXVZL1lzdWMyejZtZzgyWHYvYldzWUFvc0NONjRMWVpWMEhLTGJwYXNJ?= =?utf-8?B?VzExdTAxQVhIQWpXU3M4UkRIdHRNeE83bGRtNmNtU1dmcGdKODBFeTk3MGxH?= =?utf-8?B?VFVlbjNpUmoraGQ2eHBKQ2ZDWGw4UDk0K2ZXcWVuKy9SZEx4OFVoRktQUkUx?= =?utf-8?B?cWZxUnpqM3MyNGNGWHJLZm12dlZ5WUk1bmErUUYzSEhyUFZVU3RGK0NSaXJ1?= =?utf-8?B?Z29na0RScnlVWlNPRldqSHV0UERpRXgwcTFDTzVTSk5nZ0NBNjJwcUlweVk5?= =?utf-8?B?bzVQR1ltL2hwcmRhcGtzeWsrZ2ZGOTVCaHZMVXE2S04va05Dbm4rYjFGMFlr?= =?utf-8?B?Ti9xNjNoQjJkTWoyQTQrY2UrNkhLYytvSWpud1ZnQnhWSmQwVmVEcGxmR1oy?= =?utf-8?B?alZIdk9KdStTb1NJczczVThra2pzMHBLcVB1blVyWkNIaVU0S0RmS3ZJTkx6?= =?utf-8?B?aVMxaFh6eWE0cnB4ZDZzbFNKVnFaOUUvQmt1RUxad1BWZDNQOHBLZ2dOU0Jy?= =?utf-8?B?WEo1bU4yUzlnMHhQbXZ2M0JHeTFQT1V3bGVlaTNjc3pMdGVVRmI3aFdEWC9w?= =?utf-8?B?ZlNxUHJSZGNmQVRuZ0wraTM0SHBEWDVYZ0RJQVgzR2VDUUtjd3JsUlJTZ3gx?= =?utf-8?B?N2FpN2QxV2F5WGN1ZW5TVUI1NFpiMWszWHZYNytKWXh5UHdDRkg4eWg5dmhF?= =?utf-8?B?cUpnK2pIemlBQTJGeG8wQXVuWitLZU43Qk1xR0czL0pJUGk3dnhGMk5DWjhr?= =?utf-8?B?RDRTU0tIcnY2dlRmbVQ0OU5mVHRPa1ozS0xaSW8wUmlFOWFEdFNQQmNaVDdo?= =?utf-8?B?OC9waVV6dFVYVlBzbFBndGZ1SEhiNVhZSXFDOCtYSHJPMnRsTFJPdWFiOEho?= =?utf-8?B?VXZrWEx5OVc5YjNaNTdPVHRBcDZwV3VCaU1RQ0grOTA4WG9yU1k5VWZaMDJU?= =?utf-8?B?YkFwOWtMVGowcTE3bjArUk93MkhtV1hSbEdwZXJjY1Z5cjAwWHhXeGg1aGZp?= =?utf-8?B?SVVDWVNhdUZBc1V6S1o0bXBKai9leU5YamI5NTJ3ZkliSXBiUU5nTkhoYm00?= =?utf-8?B?UXh3K0xmdEJHR1hUYVhBUWVaTU83WDc0NVdkalJXQ01WNkdyeERtQUl3QlZW?= =?utf-8?B?YXlHUmtoa1d5bU9vZFhTUGVlMjFWVG42cXR1RUJWcUJsTWF5YTY2UkllRkdN?= =?utf-8?B?WWVxSEFjRUgydVBrY2FwMDh3YVE3MmhaUnRFcyttS0FOSUZZb0dCL2NlOUxs?= =?utf-8?B?V1FlTDNiTXFFZ0Z3MHF1Y2R0SEtEcE0xOTNGRjl2SG92TkRFMzlaVDYzajBa?= =?utf-8?B?T3lYWnk3UmFZQWxMQzdsRGQ3U0hnVHpaazE3UlhoY1JXVE81anNXYld0Z0o5?= =?utf-8?B?SzNHOCtDZkpVYTVqd1VPaVp4a1BNNDlkOGRXWnhvTXNXeTVPMEh6aFlNSlU3?= =?utf-8?B?VTFBMlAwcFFFd0h3dXhCNWdEekV3dkRNQVZCbnBnVEQyaXJoZGxCRUdOMEtk?= =?utf-8?B?OTBJaGFzdGhpR3B0RDJ6WlFiVHlPUktQTXRManlXZHZkdFVzdzBpSktVRUtW?= =?utf-8?B?eFlyVzBqd3ZTeFUwVVBpZ1dhTGtZS1pCbDhGdWsyWXJqSkpUb2l3NG5saWto?= =?utf-8?B?Tjc2bE0xSW5Db1MvSGFESk5GUGoxZkFiY3AzcW45MlIvQkgyLzZzcWNZbGM1?= =?utf-8?B?VEhLVy9ZWHZLWDgrb0J0YnJzbTkxRERHN20rYm53NEVnd1hKK1pGYXZPTm52?= =?utf-8?B?S1ZOWnR1L1RSaEs2VXVFcm1sWFJ2NmRyeVltZEdJWkJkWG5hWG9ZSjVleEZJ?= =?utf-8?B?Snk4cjBkQzg2aHI2WmFEVk9YckJLWE1MdUdDNHBTQjFYVjBacTNJME5ERnZF?= =?utf-8?B?bkR2dDhldTRrOGlBS3BFSlNrU0FrNmhaRkFuYWRFYXg0RUJuY1dtd3BRMkt5?= =?utf-8?B?UkxPKzR5ZStFMEtjU2tkb1A5bG54T0ZxeE00QnJpaHNLak9ZRVJtNXgzME1S?= =?utf-8?B?N0JVNHoyRVhpVU13bWI2a2NuNUFGSnlpbUp1YUVkcXZSbjg3TlBvVEhmcTRF?= =?utf-8?Q?xG8dWWUTLAmEOjSOHK7K9369E?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Vqr4s6RYTSuslumP3wWKitZHnss2E7f8zNFKPU9OPMCrnwxAn2DcGZ+BKZUa2jJMov/7wRknRDjI69LAcUptQF2ObulqYjElY0dCJpa3Dw/C/3s/thpWXzCIO9OYKH/EvVHVxGDQ7nQQ/oEe1/I2JWKU7IozMDDlqSMT47529uw4sRfh2QGPfZP3rtoX2xC3JuArstkLf3kngNGuTGlDPkOav4PAWTXj2qlm/rrlHzF1IiyOHhFrcMBhpmG9C0UQEzjZboxxHeQLh9Z0H7FW9xvFATLZ/V5G8P1vAcce2DKD/UWvlxga7UzyvknbTZ+CdGT0aVaVpTt9FkgzRkVqN258Yb0x5D+jcZxLX/uwfQNmMuWuXWAAjCX1t2xwSC33oFZ5p+PyCWAkVcuPfvjrGxtNQiiuSrDQ9lLL8K10/ePMhkLDKpfmPzCm9UODLB0IzJSAZtd1DIOEGZOAMwYqgtjO51K66yYTgAigSOSnlVZra0WcHeALgS2ALiXyIaCxieSCw8we3BJveg/MjXpFIk4fMeF/z8RU1e24qwKJhKbwXkUXK8OebaiugADRploSPRRCM3eey5lq8BGRSEIrRvVGMrVvwzhr//rDFnYTHOGbjyY8ZLd3Jd+IyTRB8kqQJ/XviQgiAe8YgeGkSPbSlSOJD7BJpcgJLXEi+v9feKZrQaEXaidZ/OQgGqwIO6DBrkQLfD8pX2dBq6WoCNmUroo71pSquugvxygzzSnUW49aLGmxZHuj3k9vDvc/HKuFI+arjGwWRRZLDgsL1PIlBRIg26d7V17IhQBE5/0W9QBrLIfOfK/u3w0qJCszc4BC7UPbsvcm6Mnqz5ny/L1lXulWFFgoaK6yaJt/RiQdmqJlBV1emKiVua83nQUk+dsutHV4Qn30lu6AuiMSpFT51MNiRrSd9KYArUytetvbokE= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6fd53ed-4e37-40e0-7f88-08dac677fdc9 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 19:39:48.7439 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sd1Dcm1hyQF6R+dC+p453OOMjmvh0X96SlvBaqUc1VqkzjBLO7k92rML5Ct/Akods/r8NSyIhw9kt6R6lWnJeZzv8yXRuAI5v2RfIRHLhUc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5610 T24gMTQvMTEvMjAyMiAxOToyMCwgTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIHdyb3RlOg0K PiBUaGUgL2Rldi9tZW0gaXMgdXNlZCBmb3IgdHdvIHB1cnBvc2VzOg0KPiAgLSByZWFkaW5nIFBD SV9NU0lYX0VOVFJZX0NUUkxfTUFTS0JJVA0KPiAgLSByZWFkaW5nIFBlbmRpbmcgQml0IEFycmF5 IChQQkEpDQo+DQo+IFRoZSBmaXJzdCBvbmUgd2FzIG9yaWdpbmFsbHkgZG9uZSBiZWNhdXNlIHdo ZW4gWGVuIGRpZCBub3Qgc2VuZCBhbGwNCj4gdmVjdG9yIGN0cmwgd3JpdGVzIHRvIHRoZSBkZXZp Y2UgbW9kZWwsIHNvIFFFTVUgbWlnaHQgaGF2ZSBvdXRkYXRlZCBvbGQNCj4gcmVnaXN0ZXIgdmFs dWUuIFRoaXMgaGFzIGJlZW4gY2hhbmdlZCBpbiBYZW4sIHNvIFFFTVUgY2FuIG5vdyB1c2UgaXRz DQo+IGNhY2hlZCB2YWx1ZSBvZiB0aGUgcmVnaXN0ZXIgaW5zdGVhZC4NCj4NCj4gVGhlIFBlbmRp bmcgQml0IEFycmF5IChQQkEpIGhhbmRsaW5nIGlzIGZvciB0aGUgY2FzZSB3aGVyZSBpdCBsaXZl cyBvbg0KPiB0aGUgc2FtZSBwYWdlIGFzIHRoZSBNU0ktWCB0YWJsZSBpdHNlbGYuIFhlbiBoYXMg YmVlbiBleHRlbmRlZCB0byBoYW5kbGUNCj4gdGhpcyBjYXNlIHRvbyAoYXMgd2VsbCBhcyBvdGhl ciByZWdpc3RlcnMgdGhhdCBtYXkgbGl2ZSBvbiB0aG9zZSBwYWdlcyksDQo+IHNvIFFFTVUgaGFu ZGxpbmcgaXMgbm90IG5lY2Vzc2FyeSBhbnltb3JlLg0KPg0KPiBSZW1vdmluZyAvZGV2L21lbSBh Y2Nlc3MgaXMgdXNlZnVsIHRvIHdvcmsgd2l0aGluIHN0dWJkb21haW4sIGFuZA0KPiBuZWNlc3Nh cnkgd2hlbiBkb20wIGtlcm5lbCBydW5zIGluIGxvY2tkb3duIG1vZGUuDQo+DQo+IFNpZ25lZC1v ZmYtYnk6IE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSA8bWFybWFyZWtAaW52aXNpYmxldGhp bmdzbGFiLmNvbT4NCg0KVGhlIGNvbW1pdCBtZXNzYWdlIG91Z2h0IHRvIGdvIGZ1cnRoZXIuwqAg VXNpbmcgL2Rldi9tZW0gbGlrZSB0aGlzIGlzDQpidWdneSBhbnl3YXksIGJlY2F1c2UgaXQgaXMg dHJhcHBlZCBhbmQgZW11bGF0ZWQgYnkgWGVuIGluIHdoYXRldmVyDQpjb250ZXh0IFFlbXUgaXMg cnVubmluZy7CoCBRZW11IGNhbm5vdCBnZXQgdGhlIGFjdHVhbCBoYXJkd2FyZSB2YWx1ZSwgYW5k DQpldmVuIGlmIGl0IGNvdWxkLCBpdCB3b3VsZCBiZSByYWN5IHdpdGggdHJhbnNpZW50IG9wZXJh dGlvbnMgbmVlZGluZyB0bw0KbWFzayB0aGUgdmVjdG9yLg0KDQppLmUuIGl0J3Mgbm90IGp1c3Qg bmljZS10by1yZW1vdGUgLSBpdCdzIGZpeGluZyByZWFsIGNvcm5lciBjYXNlcy4NCg0KfkFuZHJl dw0K From xen-devel-bounces@lists.xenproject.org Mon Nov 14 21:40:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 21:40:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443578.698192 (Exim 4.92) (envelope-from ) id 1ouhBR-0003D2-H2; Mon, 14 Nov 2022 21:40:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443578.698192; Mon, 14 Nov 2022 21:40:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouhBR-0003Cv-DY; Mon, 14 Nov 2022 21:40:01 +0000 Received: by outflank-mailman (input) for mailman id 443578; Mon, 14 Nov 2022 21:40:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouhBQ-0003Cp-92 for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 21:40:00 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0d3562f-6464-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 22:39:57 +0100 (CET) Received: from mail-dm6nam10lp2106.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.106]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Nov 2022 16:39:53 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB5768.namprd03.prod.outlook.com (2603:10b6:510:43::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 21:39:51 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8eca:f9cc:8bf5:83a6]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8eca:f9cc:8bf5:83a6%5]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 21:39:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0d3562f-6464-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668461997; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=zq0RuLhePLvF8Xg/x4BQzr9TWL6VlQFUXzZ48ksxCro=; b=W/s+1l6nLqEJp2CbyHv9bHy6xlwXmXWwoPzmWMOaQStXUOLU7ip5AK9H kIoy62Ydt8xUdZcN4rXGwL1mO2REmX3/ahSCpzftl0vldKMygROhp6QM5 aclkWw9g+H4gh48jHt7UuQfc96/ik2zigRyrrihnnfwnsvrHNWPRt/pwD A=; X-IronPort-RemoteIP: 104.47.58.106 X-IronPort-MID: 84826916 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:SYiUIK7dmjkLWTXN+c8jXAxRtN7GchMFZxGqfqrLsTDasY5as4F+v mZMCmHVP//bamv8ftAnPYnl805XsZ/Vy9ZqSwto/301Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkS4AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m7 N0dChwWfjC6i+eQ5q2fWvhLlsYHM5y+VG8fkikIITDxK98DGMiGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnEooiOaF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJOROfmp6c06LGV7kATIz8GSEODm9OWpX+FfeN5N mA95TV7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OcWSDowx xm2ltXmLTV1tfueTnf13rWeoC62OCMVBXQffiJCRgwAi/HhvYUygxTnXttlVqmvgbXdAirsy jqHqCw/gbQ7jsMR0ai/u1fdjFqEuZzhXgMzoALNUQqYAhhRYYekY8mk7Abd5PMZdIKBFADZ4 j4DhtSU6/0IAdeVjiuRTe4RHbavofGYLDnbhl0pFJ4kn9iwx0OekUlryGkWDC9U3gwsIFcFv Ge7Vdtt2aJu IronPort-HdrOrdr: A9a23:w1oiAKg41OTHos0WpQ93eZVFJXBQXiAji2hC6mlwRA09TyX5ra 2TdTogtSMc6QxhPE3I/OrrBEDuexzhHPJOj7X5Xo3SOTUO2lHYT72KhLGKq1Hd8kXFndK1vp 0QEZSWZueQMbB75/yKnTVREbwbsaW6GHbDv5ag859vJzsaFZ2J921Ce2Gm+tUdfng8OXI+fq DsgPZvln6bVlk8SN+0PXUBV/irnaywqHq3CSR2fiLO8WO1/EuV1II= X-IronPort-AV: E=Sophos;i="5.96,164,1665460800"; d="scan'208";a="84826916" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JG0m/dRrG3WZo7S7cXrRkUwGLWuz/sT5k3WsvFvTR96h0TpDRk+B3APnSwKE7Q5ltvpCK04JFaaab8jYOeNO3gI6rLh/HuDMIH8SkCvUrPEvzpJV98KpT3a4TgZesBMTE6Ex3eAoxQM4QIKQwV+4BRsuHiL/XhnJQLE2twsUAwU4nrbUG89FEG9LBLKk0HuMZWYmo3uUcDf7oDrJJFkCJa0M2p/rdxsvwlCnPTLEq7XTfummrqxON91pcfS2U5lLS2AeU11wLrW4Kg4/EiG4SEt6yWzvc5+8iAxY0PXqE2kZglaLGbw+vQ/QUlzNqmncK1c9wfXSJnwwl+jJDTHpAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zq0RuLhePLvF8Xg/x4BQzr9TWL6VlQFUXzZ48ksxCro=; b=V0zTV4Cedyj/FjaYHbrakkn1BLCi3oKmGuQ7cr5Oj3Qx6ANjtWzN5oJLFl3rH4LAIGp7Y8+SKd0T2NWSt1AD/WibyUdSkkRu3Ot5WPQK6xqMCRvksxskXQn+8n3uXTKtApnqEfeQAn3NOyHL6I+8et+g9Vx9TeD8dlexqsVoyuXqB0H8g3b+2kPm00GRWfBOXsipnkvt/31Qqkv87rREkvVPP6zoTua/vC5KH8ThpHOCfxRHXijC8snpqukOiYyGUCMr+LwxPSBcvPL6n2fh4xf2dV3y+FUNB8WpLtOlCDDgHQwAQrk6OeTGS3EqNUzhGWUBkQY9RptoPcZcFASMjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zq0RuLhePLvF8Xg/x4BQzr9TWL6VlQFUXzZ48ksxCro=; b=AxEaoLnnhxu4NhDnqSsIhcYKP8DXW/jcRRJOVp5MmStOShmmBEpSUzJq9D8atARLaZaJVZWcrN8pNZ1aQ6YlH4HiGCHuYVMdTfFF+FDUTRvBldMsVUNl6p2D+OQ3cZk8GWRtObxijDIM5R5K58E8Viv78kxj9d+oXaa3V/cU29U= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: "Henry.Wang@arm.com" , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH for-4.17 v3 1/2] amd/virt_ssbd: set SSBD at vCPU context switch Thread-Topic: [PATCH for-4.17 v3 1/2] amd/virt_ssbd: set SSBD at vCPU context switch Thread-Index: AQHY76YmBe8QNIQ1KUWqToJPwoQsT64/A/IA Date: Mon, 14 Nov 2022 21:39:50 +0000 Message-ID: <544896d4-f9af-a4f9-cdcb-217d27ee94c3@citrix.com> References: <20221103170244.29270-1-roger.pau@citrix.com> <20221103170244.29270-2-roger.pau@citrix.com> In-Reply-To: <20221103170244.29270-2-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB5768:EE_ x-ms-office365-filtering-correlation-id: a9a99d49-046b-4869-053e-08dac688c293 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jaFUjR+I3oMo2HnNhoMNFqbm/3JTKW/HmrWeDRYdzXuvda20jF30zjS9cDmFx/E2ErRjfzM3zSSz+MZgnSVmgJV9UHmZi78976Yxt7A2JmxfqYNsdAa8bJkozNIzQ2L+mTMCSnpQ8H5t9zocih3NIR/yOf2fptF4+/EwM7Dv4KH8P59+BZDSf+YGfJ0jdxypXxMDYYQxnRbgeDNVIzs1nTZUDcS+zumUwPyEdEZMUFkTX3H0UP1YTD65SlV28LQlrtOzePvrfdsMP+1xrlLtAdkMp9JLBqNTYpOwzKOwxqtpXNQNmIl9FAJPWe9OSP5yKVQ4m5sS7A+PwMM/ffXNIUduiNlzvAOnWIOQg92i52Zm/CU6t0o9HLaIKaa3suy7PcfE+LYbsxfmEV1jLamFt/5nYf55jVSx+CKPRtns59XI3uqT3a+rcYOOHFyeKy+Rrj63J9OJ/0DQa3Ws/8VjGqkOuhIbL8Xfbmd2GpcKY2E6qksh7gTtKR3iaMRx9NyBLi8mOHxBR8R3VjoVBXg14Kd02QT2Xurhn35KStq+o/KUBq08epvZJmkYAmkDq1XJ7pP7Fh/zmm2lm4J04XIU0frQS7RtCY6HwGxW7BpRYdfCJLuH+7BN8c/ida25eUeRR/1Y8vnIkLNxMXUDHf3Z4Il2+dLDRLgPeNA95QbFr6r4L1HFWpJoVQXriNd0ulA39iEcWDXZfobWRr4gYWw6ESfNXmj+D13zB5elBOwZH2WKlPBgCciex1nPrEFfqMuZrvQoTtJCMOc4rhXX5jML4BgOEN2FhncmDeCOuODt1pAOIl+SKPeZmkVl86b2OF3knQ62+gembqF6aK6lcmAGlg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(366004)(39860400002)(376002)(451199015)(2906002)(4326008)(76116006)(6512007)(66946007)(8676002)(64756008)(66476007)(26005)(91956017)(316002)(66556008)(66446008)(53546011)(186003)(8936002)(41300700001)(6506007)(2616005)(36756003)(38100700002)(31696002)(82960400001)(86362001)(122000001)(38070700005)(83380400001)(5660300002)(71200400001)(478600001)(6486002)(31686004)(54906003)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NGFFUXlBNmNta2c5cUdHOG5XWVRWc0tXelV3eVBOMW8vdzdaS2FjZjdYb0ti?= =?utf-8?B?cXdhUDVWQjg3blpaOXN3ZG93c3QyMUduaVZzdy9LMVFyZ1pZSkhUK0QyNWVV?= =?utf-8?B?cWc4amRsejQ2NFM1S1BNczF4dUxFZHo2Q2g4MGMzME1mdHVnWnJZRXM5UkFB?= =?utf-8?B?TmV1bmh5SFg5a1ovUFd2R1RHblRFdkNNMGVmU2Q4V21xcHgxTGY0T01oZWU1?= =?utf-8?B?ZjRPdGdCaU9QRGt5azVVYjZCZkx0MDZXMWRDOVVYazFGU2ptS05iNmFpbVN1?= =?utf-8?B?SGFLQTc5QW5wV1ZlZ3g3NmgwUkNMV2JNZGpKTVdEM29BOEE1cTRPaWtzTjdp?= =?utf-8?B?RVdwZGovT1ZlVVRVQ3B1SHdxMENtNFkrQlYzOU81SmtDRDI4T0pPRkc3YmY0?= =?utf-8?B?K3lVZDhaN2FKYmhpZDFIWU5MMkZuVEZEeGdFUStSK0YvMDBsNWs5RkZwUjds?= =?utf-8?B?d1k4OU9xY1ljWTg2b25GaVJOMVp1bVVaM3RJRy9kWWpnRjZaMCtrZmhmMnFG?= =?utf-8?B?R1hrczJhWGdvc25kVjlsbHNqaFMwR25uS2g3RVVmSWYrMWl4SXgrcG96NmZD?= =?utf-8?B?cUt3dGEyQ0pqVFUvSXYrc3RScEx0WEwrbHREMnVZOU1jT2FyWTRzbmtITFo1?= =?utf-8?B?NnNTTTdIRnJ0OG9NWmN3SEtPSDF0QVpJMnRuNzVKRjJkTU9xdkIwZnN0cUhO?= =?utf-8?B?bFFaY245MUVaVml2RDRBUUcyaS95SjJFK1VGcGZIL0NJc1Izdm5Ud2QrbnhZ?= =?utf-8?B?NzUvMjRlSGFhVGkranZHdUpFUmRwUFFWRlU2RkJWWDJBNjJvUmNCS2tzQmpY?= =?utf-8?B?bjRxakJkSkJvQWg2VTVhWGlGQVMrM0tlMkx6cDR0Tk8yWnNHczhyalE0NXZr?= =?utf-8?B?SDY3dGdqZ0gyb1Zlbk1aeEJxUHZyMEdTK0FxTmwrL2h2M1IrZ0NxVEJ3Mkhy?= =?utf-8?B?d2RUM0JIVmVBeVBwZ09qSUdjMnpVMmNIU1hIM28rbEgxUGI2MnVaS1hkLy9P?= =?utf-8?B?R3F2Y2Y5T2hqbzJtNGZQTCttb3RoOXluSGl5a1pBcEY1RW8waEI2SGVucmlV?= =?utf-8?B?a21ab1Q0VnVNL3JNRUp3c2hLMnhTLzlEb3NhWWJOYTZUUmJuNHpyVWJ4Y3Yx?= =?utf-8?B?WlFtU1RkL0FKUFd3a2pKa0crdVNqN1d2M29hekdSQUVrc3c2UzVUcGdEcW1J?= =?utf-8?B?enQ2cm1HQmFIL21NYXBya0JFa3I4U1dWUnFVV2liQ08wLzBoVE91elZKNEN4?= =?utf-8?B?a3JNTWxoTjBlNjExNldmemVrbEx4dGhac3pLbDdKd3E5Y0dQKzZxaGRycFQ2?= =?utf-8?B?WC9XSktDbW51RXdzQnpET2wwb0pPOHZuUGJpOVNsajdnNlpxK3lBUDhlbks5?= =?utf-8?B?UGR1ck81S1dxZXMrNU4rVzFzR09YWHZ6VlhTREhPMHBYWUVBWEpNRlBsMi93?= =?utf-8?B?R2hYT21QeXlMTVRNRG9vMDZUQlR6ZjZQbWF2bFdDMjJ0YmZCc0NhY2Rjbmpj?= =?utf-8?B?VjBPV2J6aVFOOUdYNURWdmRHc3psNVNvNlBacldpRU1FK3lZdjladThLOGNL?= =?utf-8?B?L0M2c0FqNG92dzZXWFJDVVJIOFpFMzRiRVNIYkljTlpTbzBGd00zQytUbXFy?= =?utf-8?B?VzBlVFNxVERaNjdaQ2lOYjU5Z0QxSHNNZDdQV3lLcUpwdXg2YXdCdEM1ODY1?= =?utf-8?B?ZWF5d1ZUVm9zMHlPaytoZ3M3bUVHMWZvNUp2cVpiRHpRQmxIcGtkc3FVeitt?= =?utf-8?B?cno5UEJrdWgzR0hzaHhHbGRuc1VCZmp4S3hWY0FtaTRDU1lpei95REdNOUxs?= =?utf-8?B?VVczMFBNK2N0SFhsWVFHSGtzZFpBWFhmRkFrWTdVcDRHK2NXKzZJVFZGMUl4?= =?utf-8?B?MXFwZFBqS1liRXVJNnFNd3Y5Sm43OTVaeCs5QzNNcFF0d0NhY2cyU0JUVTY1?= =?utf-8?B?OUx4dVZlUmpLUUszWXhWN3FDTkw3UVNkNS96cndzTU5NTERDVEJKOGtnUk1D?= =?utf-8?B?bVdJR254bzIwMTVsUmhjbmo1VFRSZEtHS05VSjIvTlYyYzk4Z0FzdTBGayts?= =?utf-8?B?OGUvOW5CeEYxR0ZIeHdXNWIxcG1OR0RBeGR3ZDNxRHBPWXNBbEhvcC9qcy9E?= =?utf-8?Q?MYzFKVd1vSkr8XVb7n+rPk8lT?= Content-Type: text/plain; charset="utf-8" Content-ID: <7B3656C28E7B45408D11762B49D919AA@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TPoSuf5QKzuDCDSbIRptpv1knAb9Leb3rI8nzLT5HCsn6ccSHxpVBeVYONJxQYKTO4fQzawjkXl93tSinqLOr2B0qiXnSqcyW/Qs/UOLn41jWxhKjMgZm6P9CeXru44ctIGovxHBLOiSWmynDY0i/ESe53euO8PGHYYPGfBldgeCNp5uCRsp7xWFegQV0YiHSZvXSF1F6HiyIck+U5EpgCQQQenhnCE3l6YceqQ/l5VWSbsLTkPe5GH32oddnYvl5hpNuLyuBLd2xA8ejfR4G0GEdPBF9f/UEqC9MVqd7nQMpOr1nNl4ofJuGub6Qyx7NflhMwJ27YRmcr0rozbQOzv/FPP9LDxxamFbfFXMKTqZYaHn9U3/kVNkHACbXe2t9HoLmdL9UjWir0DY97OHzJgrk2J229MC6A+Eo6FnrydAItWD2sqqdVkQ6k8sHIJCn2/RKeh0WA/WqVZSXAtVZXkGz5LY3aV6cCoKp70j8q60jPy4Qk7l7FCu1UXR3e84yvatmOsctrt3Bz5YSbkjEU8MR6QT/7YVoLZnx6voA4rzILjn3mnEGWCkSo02L02bGJhEji1r6EdXC8eMkXsYBxHmdjG3Veooc747ieuI2VJy7OsrxozULAWEQehUA8VzGkGOHMjpLZ1GAcOkBIkKXGpkX67iE8voTC7sqHOberdV4Sp31iVWiT8pEgeRCbTmQh3DTaS3k5cKTxu/whFxdqW2IovYWloaaj9J6Py9ro8kvF2MJ89KshYC1u4Ae5pvjjiv2Wpj6ZwNtQgovdwkajJBTa7MXvYwhta6xXeEyb29ybV0cDxoZ1ukqMV+vPuj1PBLVrjVELlg7JVSAeuNxxofFlRQbbsK2pK+/APTPYh0J5VGNtQEI4nmHGq+LA8zbVLLGb2YpmmO/o72MXsm8g== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9a99d49-046b-4869-053e-08dac688c293 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 21:39:50.8300 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6Qqe2Pdm3n7uiaJzQOkSpm8p/pjnnwtQdF237WpEmWRFJgEFsxxL6o43JxojImoe8b3qq8DvoJXtdFngabWs8xXFg2+OcpY2N/b7SeauJyc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5768 T24gMDMvMTEvMjAyMiAxNzowMiwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBUaGUgY3VycmVu dCBsb2dpYyBmb3IgQU1EIFNTQkQgY29udGV4dCBzd2l0Y2hlcyBpdCBvbiBldmVyeQ0KPiB2bXtl bnRyeSxleGl0fSBpZiB0aGUgWGVuIGFuZCBndWVzdCBzZWxlY3Rpb25zIGRvbid0IG1hdGNoLiAg VGhpcyBpcw0KPiBleHBlbnNpdmUgd2hlbiBub3QgdXNpbmcgU1BFQ19DVFJMLCBhbmQgaGVuY2Ug c2hvdWxkIGJlIGF2b2lkZWQgYXMNCj4gbXVjaCBhcyBwb3NzaWJsZS4NCj4NCj4gV2hlbiBTU0JE IGlzIG5vdCBiZWluZyBzZXQgZnJvbSBTUEVDX0NUUkwgb24gQU1EIGRvbid0IGNvbnRleHQgc3dp dGNoDQo+IGF0IHZte2VudHJ5LGV4aXR9IGFuZCBpbnN0ZWFkIG9ubHkgY29udGV4dCBzd2l0Y2gg U1NCRCB3aGVuIHN3aXRjaGluZw0KPiB2Q1BVcy4gIFRoaXMgaGFzIHRoZSBzaWRlIGVmZmVjdCBv ZiBydW5uaW5nIFhlbiBjb2RlIHdpdGggdGhlIGd1ZXN0DQo+IHNlbGVjdGlvbiBvZiBTU0JELCB0 aGUgZG9jdW1lbnRhdGlvbiBpcyB1cGRhdGVkIHRvIG5vdGUgdGhpcyBiZWhhdmlvci4NCj4gQWxz byBub3RlIHRoYXQgdGhlbiB3aGVuIGBzc2JkYCBpcyBzZWxlY3RlZCBvbiB0aGUgY29tbWFuZCBs aW5lIGd1ZXN0DQo+IFNTQkQgc2VsZWN0aW9uIHdpbGwgbm90IGhhdmUgYW4gZWZmZWN0LCBhbmQg dGhlIGh5cGVydmlzb3Igd2lsbCBydW4NCj4gd2l0aCBTU0JEIHVuY29uZGl0aW9uYWxseSBlbmFi bGVkIHdoZW4gbm90IHVzaW5nIFNQRUNfQ1RSTCBpdHNlbGYuDQo+DQo+IFRoaXMgZml4ZXMgYW4g aXNzdWUgd2l0aCBydW5uaW5nIEMgY29kZSBpbiBhIEdJRj0wIHJlZ2lvbiwgdGhhdCdzDQo+IHBy b2JsZW1hdGljIHdoZW4gdXNpbmcgVUJTQU4gb3Igb3RoZXIgaW5zdHJ1bWVudGF0aW9uIHRlY2hu aXF1ZXMuDQoNClRoaXMgcGFyYWdyYXBoIG5lZWRzIHRvIGJlIGF0IHRoZSB0b3AsIGJlY2F1c2Ug aXQncyB0aGUgcmVhc29uIHdoeSB0aGlzDQppcyBhIGJsb2NrZXIgYnVnIGZvciA0LjE3LsKgIEV2 ZXJ5dGhpbmcgZWxzZSBpcyBkaXNjdXNzaW5nIHdoeSB3ZSB0YWtlDQp0aGUgYXBwcm9hY2ggd2Ug dGFrZS4NCg0KKGFuZCB0byBiZSBjbGVhciwgaXQncyBzbG93IGV2ZW4gd2l0aCBNU1JfU1BFQ19D VFJMLsKgIEl0J3MganVzdCB0aGF0IGl0cw0KYSB3aG9sZSBsb3QgbGVzcyBzbG93IHRoYW4gd2l0 aCB0aGUgTFNfQ0ZHIE1TUi4pDQoNCj4NCj4gQXMgYSByZXN1bHQgb2Ygbm8gbG9uZ2VyIHJ1bm5p bmcgdGhlIGNvZGUgdG8gc2V0IFNTQkQgaW4gYSBHSUY9MA0KPiByZWdpb24gdGhlIGxvY2tpbmcg b2YgYW1kX3NldF9sZWdhY3lfc3NiZCgpIGNhbiBiZSBkb25lIHVzaW5nIG5vcm1hbA0KPiBzcGlu bG9ja3MsIGFuZCBzb21lIG1vcmUgY2hlY2tzIGNhbiBiZSBhZGRlZCB0byBhc3N1cmUgaXQgd29y a3MgYXMNCj4gaW50ZW5kZWQuDQo+DQo+IEZpbmFsbHkgaXQncyBhbHNvIHdvcnRoIG5vdGljaW5n IHRoYXQgc2luY2UgdGhlIGd1ZXN0IFNTQkQgc2VsZWN0aW9uDQo+IGlzIG5vIGxvbmdlciBzZXQg b24gdm1lbnRyeSB0aGUgVklSVF9TUEVDX01TUiBoYW5kbGluZyBuZWVkcyB0bw0KPiBwcm9wYWdh dGUgdGhlIHZhbHVlIHRvIHRoZSBoYXJkd2FyZSBhcyBwYXJ0IG9mIGhhbmRsaW5nIHRoZSB3cm1z ci4NCj4NCj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJp eC5jb20+DQo+IC0tLQ0KPiBDaGFuZ2VzIHNpbmNlIHYyOg0KPiAgLSBGaXggY2FsbGluZyBzZXRf cmVnIHVuY29uZGl0aW9uYWxseS4NCj4gIC0gRml4IGNvbW1lbnQuDQo+ICAtIENhbGwgYW1kX3Nl dF9zc2JkKCkgZnJvbSBndWVzdF93cm1zcigpLg0KPg0KPiBDaGFuZ2VzIHNpbmNlIHYxOg0KPiAg LSBKdXN0IGNoZWNrIHZpcnRfc3BlY19jdHJsIHZhbHVlICE9IDAgb24gY29udGV4dCBzd2l0Y2gu DQo+ICAtIFJlbW92ZSBzdHJheSBhc20gbmV3bGluZS4NCj4gIC0gVXNlIHZhbCBpbiBzdm1fc2V0 X3JlZygpLg0KPiAgLSBGaXggc3R5bGUgaW4gYW1kLmMuDQo+ICAtIERvIG5vdCBjbGVhciBzc2Jk DQo+IC0tLQ0KPiAgZG9jcy9taXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jIHwgMTAgKysrLS0t DQo+ICB4ZW4vYXJjaC94ODYvY3B1L2FtZC5jICAgICAgICAgICAgfCA1NSArKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tDQo+ICB4ZW4vYXJjaC94ODYvaHZtL3N2bS9lbnRyeS5TICAgICAg fCAgNiAtLS0tDQo+ICB4ZW4vYXJjaC94ODYvaHZtL3N2bS9zdm0uYyAgICAgICAgfCA0NSArKysr KysrKysrLS0tLS0tLS0tLS0tLS0tDQo+ICB4ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vYW1kLmgg ICAgfCAgMiArLQ0KPiAgeGVuL2FyY2gveDg2L21zci5jICAgICAgICAgICAgICAgIHwgIDkgKysr KysNCg0KTmVlZCB0byBwYXRjaCBtc3IuaCBub3cgdGhhdCB0aGUgc2VtYW50aWNzIG9mIHZpcnRf c3BlY19jdHJsIGhhdmUgY2hhbmdlZC4NCg0KDQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv Y3B1L2FtZC5jIGIveGVuL2FyY2gveDg2L2NwdS9hbWQuYw0KPiBpbmRleCA5OGM1MmQwNjg2Li4w NWQ3MmM2NTAxIDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC94ODYvY3B1L2FtZC5jDQo+ICsrKyBi L3hlbi9hcmNoL3g4Ni9jcHUvYW1kLmMNCj4gPHNuaXA+DQo+ICt2b2lkIGFtZF9zZXRfc3NiZChi b29sIGVuYWJsZSkNCj4gK3sNCj4gKwlpZiAob3B0X3NzYmQpDQo+ICsJCS8qDQo+ICsJCSAqIEln bm9yZSBhdHRlbXB0cyB0byB0dXJuIG9mZiBTU0JELCBpdCdzIGhhcmRjb2RlZCBvbiB0aGUNCj4g KwkJICogY29tbWFuZCBsaW5lLg0KPiArCQkgKi8NCj4gKwkJcmV0dXJuOw0KPiArDQo+ICsJaWYg KGNwdV9oYXNfdmlydF9zc2JkKQ0KPiArCQl3cm1zcihNU1JfVklSVF9TUEVDX0NUUkwsIGVuYWJs ZSA/IFNQRUNfQ1RSTF9TU0JEIDogMCwgMCk7DQo+ICsJZWxzZSBpZiAoYW1kX2xlZ2FjeV9zc2Jk KQ0KPiArCQljb3JlX3NldF9sZWdhY3lfc3NiZChlbmFibGUpOw0KPiArCWVsc2UNCj4gKwkJQVNT RVJUX1VOUkVBQ0hBQkxFKCk7DQoNClRoaXMgYXNzZXJ0IGlzIHJlYWNoYWJsZSBvbiBGYW0xNCBh bmQgb2xkZXIsIEkgdGhpbmsuDQoNCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9odm0vc3Zt L3N2bS5jIGIveGVuL2FyY2gveDg2L2h2bS9zdm0vc3ZtLmMNCj4gaW5kZXggMWFlYWFiY2IxMy4u OGIxMDFkNGYyNyAxMDA2NDQNCj4gLS0tIGEveGVuL2FyY2gveDg2L2h2bS9zdm0vc3ZtLmMNCj4g KysrIGIveGVuL2FyY2gveDg2L2h2bS9zdm0vc3ZtLmMNCj4gQEAgLTk3Myw2ICs5NzMsMTYgQEAg c3RhdGljIHZvaWQgY2ZfY2hlY2sgc3ZtX2N0eHRfc3dpdGNoX2Zyb20oc3RydWN0IHZjcHUgKnYp DQo+ICANCj4gICAgICAvKiBSZXN1bWUgdXNlIG9mIElTVHMgbm93IHRoYXQgdGhlIGhvc3QgVFIg aXMgcmVpbnN0YXRlZC4gKi8NCj4gICAgICBlbmFibGVfZWFjaF9pc3QoaWR0X3RhYmxlc1tjcHVd KTsNCj4gKw0KPiArICAgIC8qDQo+ICsgICAgICogQ2xlYXIgcHJldmlvdXMgZ3Vlc3Qgc2VsZWN0 aW9uIG9mIFNTQkQgaWYgc2V0LiAgTm90ZSB0aGF0IFNQRUNfQ1RSTC5TU0JEDQo+ICsgICAgICog aXMgYWxyZWFkeSBjbGVhcmVkIGJ5IHN2bV92bWV4aXRfc3BlY19jdHJsLg0KPiArICAgICAqLw0K PiArICAgIGlmICggdi0+YXJjaC5tc3JzLT52aXJ0X3NwZWNfY3RybC5yYXcgJiBTUEVDX0NUUkxf U1NCRCApDQo+ICsgICAgew0KPiArICAgICAgICBBU1NFUlQodi0+ZG9tYWluLT5hcmNoLmNwdWlk LT5leHRkLnZpcnRfc3NiZCk7DQo+ICsgICAgICAgIGFtZF9zZXRfc3NiZChmYWxzZSk7DQo+ICsg ICAgfQ0KPiAgfQ0KPiAgDQo+ICBzdGF0aWMgdm9pZCBjZl9jaGVjayBzdm1fY3R4dF9zd2l0Y2hf dG8oc3RydWN0IHZjcHUgKnYpDQo+IEBAIC0xMDAwLDYgKzEwMTAsMTMgQEAgc3RhdGljIHZvaWQg Y2ZfY2hlY2sgc3ZtX2N0eHRfc3dpdGNoX3RvKHN0cnVjdCB2Y3B1ICp2KQ0KPiAgDQo+ICAgICAg aWYgKCBjcHVfaGFzX21zcl90c2NfYXV4ICkNCj4gICAgICAgICAgd3Jtc3JfdHNjX2F1eCh2LT5h cmNoLm1zcnMtPnRzY19hdXgpOw0KPiArDQo+ICsgICAgLyogTG9hZCBTU0JEIGlmIHNldCBieSB0 aGUgZ3Vlc3QuICovDQo+ICsgICAgaWYgKCB2LT5hcmNoLm1zcnMtPnZpcnRfc3BlY19jdHJsLnJh dyAmIFNQRUNfQ1RSTF9TU0JEICkNCj4gKyAgICB7DQo+ICsgICAgICAgIEFTU0VSVCh2LT5kb21h aW4tPmFyY2guY3B1aWQtPmV4dGQudmlydF9zc2JkKTsNCj4gKyAgICAgICAgYW1kX3NldF9zc2Jk KHRydWUpOw0KPiArICAgIH0NCg0KV2hpbGUgdGhpcyBmdW5jdGlvbnMsIGl0J3Mgc3RpbGwgYSBw ZXJmIHByb2JsZW0uwqAgWW91IG5vdyBmbGlwIHRoZSBiaXQNCnR3aWNlIHdoZW4gc3dpdGNoaW5n IGJldHdlZW4gdmNwdXMgd2l0aCBsZWdhY3kgU1NCRC4NCg0KVGhpcyB3b3VsZG4ndCBiZSBzbyBi YWQgaWYgeW91J2QgYWxzbyBmaXhlZCB0aGUgaW5uZXIgZnVuY3Rpb24gdG8gbm90IGRvDQphIHJl YWQvbW9kaWZ5L3dyaXRlIG9uIHRoZSB2ZXJ5IHNsb3cgTVNSLCBiZWNhdXNlIHRoZW4gd2UnZCBv bmx5IGJlDQp0b3VjaGluZyBpdCB0d2ljZSwgbm90IDQgdGltZXMuDQoNClRoaXMgaXNuJ3QgY3Jp dGljYWwgdG8gZml4IGZvciA0LjE3LCBidXQgd2lsbCBuZWVkIGFkZHJlc3NpbmcgaW4gZHVlIGNv dXJzZS4NCg0KSG93ZXZlciwgYXMgdGhlIHBhdGNoIGRvZXMgbmVlZCBhIHJlc3BpbiwgYW1kX3Nl dF9zc2JkKCkgaXMgdG9vDQpnZW5lcmljLsKgIEl0J3MgcHJldmlvdXMgbmFtZSwgYW1kX3NldF9s ZWdhY3lfc3NiZCgpLCB3YXMgbW9yZQ0KYXBwcm9wcmlhdGUsIGFzIGl0IGNsZWFybHkgaGlnaGxp Z2h0cyB0aGUgZmFjdCB0aGF0IGl0J3MgdGhlDQpub24tTVNSX1NQRUNfQ1RSTCBwYXRoLg0KDQp+ QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Mon Nov 14 21:44:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 21:44:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443582.698203 (Exim 4.92) (envelope-from ) id 1ouhFQ-0004oR-5P; Mon, 14 Nov 2022 21:44:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443582.698203; Mon, 14 Nov 2022 21:44:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouhFQ-0004oK-1e; Mon, 14 Nov 2022 21:44:08 +0000 Received: by outflank-mailman (input) for mailman id 443582; Mon, 14 Nov 2022 21:44:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouhFO-0004oB-1Q for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 21:44:06 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7448a6de-6465-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 22:44:04 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7448a6de-6465-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668462244; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=h2OAyHLea+exyEJ7uLsi7jSK7CEsyDrXg/IeWLpxi8w=; b=SQVeqwchNmM3xyiHd1MNQYCGMS8oalDUlmNWU7c15pRxnkF4446B7YZQ nssvQAloNyNjGECqeUmg9mNXuYcb/Q5N8subiKZeO3rNEkhrtohMVAR/i ir+P+uIjcGFUHfDcfrznkJaP0tHFJmvBXHKkaDfx0+xGfAgVvXBsjEAfA o=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85231925 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:GwXwXKOeKqD1i/zvrR2ul8FynXyQoLVcMsEvi/4bfWQNrUon1jcAz GoaCzrVbPyCZWf3ftlybYnk8kxTu8LRx9RhSgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5wBmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uVqXWdh/ vlAFDcqdVPfp8mm8Jy1ePY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w/N3wsYDUWUrsTILs4kP2lmT/UdDpApUjOjaE2/3LS3Ep6172F3N/9KoHQHpwExBvwS mTu/kCkGD0VNI2jyCPc+XaJ3snegHnKR9dHfFG/3qEz2wDCroAJMzUJUXOrrP//jVSxM/p/J koO62wRpK493EWxS5/2WBjQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceZxYny 1uIlNPBHiF0vfueTnf1y1uPhWrsY25PdzZEPHJaC1teizX+nG0tphHSEtBMG6vtstrSAnKs4 xuanAYwtapG2KbnyJ6H1VzAhjutoL3AQQg0+hjbUwqZ0+9pWGK2T9f2sAaGtJ6sOK7cFwDc5 yZcx6By+chUVfmweDqxrPLh9V1Dz9KMK3XijFFmBPHNHBz9qif4Lei8DNyTTXqF0/romxezP yc/WisLvve/2UdGiocpC79d8+xwkcDd+S3ND5g5rrNmO/CdjjOv8iB0flK31GvwikUqmqxXE c7FL5bwUC5LUfo6k2DeqwIhPVgDn35W+I8ubcqjk0TPPUS2ORZ5tovpwHPRN7tkvctoUS3e8 spFNtvi9vmseLSWX8QWmKZNRW03wY8TXM2u8pQJKLfZemKL2ggJUpfs/F/oQKQ994w9qwsC1 ivVtpNwoLYnuUD6FA== IronPort-HdrOrdr: A9a23:cdH5cKlX2axZGQUdl0mz8KSrYUjpDfIm3DAbv31ZSRFFG/Fxl6 iV88jzsiWE7Ar5OUtQ/OxoV5PgfZqxz/NICOoqTNWftWvd2FdARbsKheCJ/9SJIVyYygc378 ldmsZFZOEYdWIK7vrH3A== X-IronPort-AV: E=Sophos;i="5.96,164,1665460800"; d="scan'208";a="85231925" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Henry Wang Subject: [PATCH for-4.17] x86/spec-ctrl: Fill in whitepaper URL Date: Mon, 14 Nov 2022 21:43:58 +0000 Message-ID: <20221114214358.17611-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit ... now that we a link available. Fixes: 9deaf2d932f0 ("x86/spec-ctrl: Enable Zen2 chickenbit") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Henry Wang For 4.17(?) Seeing if I can sneak it in as just a documentation change, seeing as there are others outstanding. If not, it can go into 4.18 and get backported. --- xen/arch/x86/cpu/amd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index 05d72c6501ee..af46d7119bbe 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -827,7 +827,7 @@ void amd_set_ssbd(bool enable) * On Zen2 we offer this chicken (bit) on the altar of Speculation. * * Refer to the AMD Branch Type Confusion whitepaper: - * https://XXX + * https://www.amd.com/system/files/documents/technical-guidance-for-mitigating-branch-type-confusion.pdf * * Setting this unnamed bit supposedly causes prediction information on * non-branch instructions to be ignored. It is to be set unilaterally in -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 21:46:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 21:46:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443586.698214 (Exim 4.92) (envelope-from ) id 1ouhHk-0005QB-I3; Mon, 14 Nov 2022 21:46:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443586.698214; Mon, 14 Nov 2022 21:46:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouhHk-0005Q4-F7; Mon, 14 Nov 2022 21:46:32 +0000 Received: by outflank-mailman (input) for mailman id 443586; Mon, 14 Nov 2022 21:46:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouhHk-0005Py-0J for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 21:46:32 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cbf2f3ac-6465-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 22:46:30 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0690D60EF4; Mon, 14 Nov 2022 21:46:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6205C433C1; Mon, 14 Nov 2022 21:46:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbf2f3ac-6465-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668462388; bh=3GcDEeuAk8O0S4B39cMYJDrzzSSOnKsFT6Us8olDuog=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=YhfZhiXiFPyGeRmLe/OXyNCUV8TvuuWqiBCs3J7yH7Oc1Yjd/gIKdMmSn2Nupxgvz DCl9T7T2TSpXN3jrHxIMGdwwYOkWgLFB7LEBvpRScZeORCBlQ02Ujj9rt/Vtb4UTPM jLQenLb1EeFmT5CWrRvbc9IRPesgzYVAVS4pywy9165frNmXuQwcgDV+KdlAZPmLYW 0J0MehT5fKp1cZxr3mh/7hpbaIvZcd1PF+4CJVBwyHKqRWgSJNmYCi33cKK6RDtALH 7DQf7QXp+i/vL4wqXZhmcpah9r9rk91LI8JcBkqSld45Pgd9k9mgGe3Tllk9q26tMF aiHO83c1+INTw== Date: Mon, 14 Nov 2022 13:46:26 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Juergen Gross cc: linux-kernel@vger.kernel.org, Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Subject: Re: [PATCH] xen/platform-pci: use define instead of literal number In-Reply-To: <20221114142348.1499-1-jgross@suse.com> Message-ID: References: <20221114142348.1499-1-jgross@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 14 Nov 2022, Juergen Gross wrote: > Instead of "0x01" use the HVM_PARAM_CALLBACK_TYPE_PCI_INTX define from > the interface header in get_callback_via(). > > Signed-off-by: Juergen Gross Acked-by: Stefano Stabellini > --- > drivers/xen/platform-pci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c > index 18f0ed8b1f93..24a3de1b7b03 100644 > --- a/drivers/xen/platform-pci.c > +++ b/drivers/xen/platform-pci.c > @@ -54,7 +54,8 @@ static uint64_t get_callback_via(struct pci_dev *pdev) > pin = pdev->pin; > > /* We don't know the GSI. Specify the PCI INTx line instead. */ > - return ((uint64_t)0x01 << HVM_CALLBACK_VIA_TYPE_SHIFT) | /* PCI INTx identifier */ > + return ((uint64_t)HVM_PARAM_CALLBACK_TYPE_PCI_INTX << > + HVM_CALLBACK_VIA_TYPE_SHIFT) | > ((uint64_t)pci_domain_nr(pdev->bus) << 32) | > ((uint64_t)pdev->bus->number << 16) | > ((uint64_t)(pdev->devfn & 0xff) << 8) | > -- > 2.35.3 > From xen-devel-bounces@lists.xenproject.org Mon Nov 14 22:17:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 22:17:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443593.698225 (Exim 4.92) (envelope-from ) id 1ouhm2-0000nx-1G; Mon, 14 Nov 2022 22:17:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443593.698225; Mon, 14 Nov 2022 22:17:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouhm1-0000nq-Tm; Mon, 14 Nov 2022 22:17:49 +0000 Received: by outflank-mailman (input) for mailman id 443593; Mon, 14 Nov 2022 22:17:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouhm0-0000na-Bj; Mon, 14 Nov 2022 22:17:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouhm0-0001aE-6V; Mon, 14 Nov 2022 22:17:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouhlz-0006NU-Kn; Mon, 14 Nov 2022 22:17:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouhlz-0005eg-KM; Mon, 14 Nov 2022 22:17:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=97XrB4HFyHO8a7sLts7HJU0cGA6yBDZx7+K8YLkIIJk=; b=npRo25Ndee+qoZQ3WPkNRA58mt VKehsm/5zz0DiuYCRQgLDe+6O8oRLVxb6Hpujv1btiYzb0gVSsA6DJei86ZkDh/2VhBTqo93f8ib7 3uByztADUI4Wzg8HPlJKVSzKOOO53dOPlNFuTM9n/3vDuK177c0SExADpfmGdaDaLpbQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 174767: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0d39a6d1ae3df67e11548dedfc8e1923a9002fcd X-Osstest-Versions-That: xen=1dc6dccb1a8752f200ec2612b2bd091bbf88b231 From: osstest service owner Date: Mon, 14 Nov 2022 22:17:47 +0000 flight 174767 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174767/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174695 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174695 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174695 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174695 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174695 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174695 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174695 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174695 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174695 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174695 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174695 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174695 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen 0d39a6d1ae3df67e11548dedfc8e1923a9002fcd baseline version: xen 1dc6dccb1a8752f200ec2612b2bd091bbf88b231 Last test of basis 174695 2022-11-09 17:27:15 Z 5 days Testing same since 174767 2022-11-14 11:07:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Lindig Henry Wang Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 1dc6dccb1a..0d39a6d1ae 0d39a6d1ae3df67e11548dedfc8e1923a9002fcd -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 22:36:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 22:36:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443603.698240 (Exim 4.92) (envelope-from ) id 1oui3o-0003aJ-NO; Mon, 14 Nov 2022 22:36:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443603.698240; Mon, 14 Nov 2022 22:36:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oui3o-0003aC-K6; Mon, 14 Nov 2022 22:36:12 +0000 Received: by outflank-mailman (input) for mailman id 443603; Mon, 14 Nov 2022 22:36:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oui3n-0003a6-Gi for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 22:36:11 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bbe3a38a-646c-11ed-91b6-6bf2151ebd3b; Mon, 14 Nov 2022 23:36:09 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 41AC6B8125E; Mon, 14 Nov 2022 22:36:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D984BC433D6; Mon, 14 Nov 2022 22:36:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbe3a38a-646c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668465366; bh=Z3BXRUzMIcbQGkh2XTwvZGclXB44bJubeTeU5R/QAmM=; h=Date:From:To:cc:Subject:From; b=r97ggIkELYlSzgQuZHXiiOwjSTFBLQbNioxm3BEL5fOLaMD3Rmjh+O0xhQMpkcUwB L01wF97emsHhgihhp9CBab8TfP5yys2F9M2qK5tXBjmCjTcVdMqqx1YxJhz8bEnd6b fQvwTqUasklQlyWsnfevtCp2vxBlPpu5FtBjr350gLHnujjXVxnwgLnikzzJlxIzkj GXMX/TQUpZGxJMzW2aRyUeuaxzz1Z9RcT6fwPhsG7DCPvH2ZWDUwAxxIWsu/Gme4N4 JA2OKpv+8gYfgUrIwHLVwhYp+FoacKosdskq4DRp5vCopHN2Fp+nZU03ZXt6Jdt4L/ lYkezQTUcsPYA== Date: Mon, 14 Nov 2022 14:36:04 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: xen-devel@lists.xenproject.org cc: sstabellini@kernel.org, Andrew.Cooper3@citrix.com, Henry.Wang@arm.com, george.dunlap@citrix.com, jbeulich@suse.com, julien@xen.org, wl@xen.org Subject: [PATCH for-4.17] Introduce CC-BY-4.0 license under LICENSES/ Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII We use CC-BY-4.0 for many of the documents under docs/ so we should have a copy of the license. Signed-off-by: Stefano Stabellini --- LICENSES/CC-BY-4.0 | 410 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 410 insertions(+) create mode 100644 LICENSES/CC-BY-4.0 diff --git a/LICENSES/CC-BY-4.0 b/LICENSES/CC-BY-4.0 new file mode 100644 index 0000000000..869cad3d16 --- /dev/null +++ b/LICENSES/CC-BY-4.0 @@ -0,0 +1,410 @@ +Valid-License-Identifier: CC-BY-4.0 +SPDX-URL: https://spdx.org/licenses/CC-BY-4.0 +Usage-Guide: + Do NOT use this license for code, but it's acceptable for content like artwork + or documentation. When using it for the latter, it's best to use it together + with a GPL2 compatible license using "OR", as CC-BY-4.0 texts processed by + the kernel's build system might combine it with content taken from more + restrictive licenses. + To use the Creative Commons Attribution 4.0 International license put + the following SPDX tag/value pair into a comment according to the + placement guidelines in the licensing rules documentation: + SPDX-License-Identifier: CC-BY-4.0 +License-Text: + +Creative Commons Attribution 4.0 International + +======================================================================= + +Creative Commons Corporation ("Creative Commons") is not a law firm and +does not provide legal services or legal advice. Distribution of +Creative Commons public licenses does not create a lawyer-client or +other relationship. Creative Commons makes its licenses and related +information available on an "as-is" basis. Creative Commons gives no +warranties regarding its licenses, any material licensed under their +terms and conditions, or any related information. Creative Commons +disclaims all liability for damages resulting from their use to the +fullest extent possible. + +Using Creative Commons Public Licenses + +Creative Commons public licenses provide a standard set of terms and +conditions that creators and other rights holders may use to share +original works of authorship and other material subject to copyright +and certain other rights specified in the public license below. The +following considerations are for informational purposes only, are not +exhaustive, and do not form part of our licenses. + + Considerations for licensors: Our public licenses are + intended for use by those authorized to give the public + permission to use material in ways otherwise restricted by + copyright and certain other rights. Our licenses are + irrevocable. Licensors should read and understand the terms + and conditions of the license they choose before applying it. + Licensors should also secure all rights necessary before + applying our licenses so that the public can reuse the + material as expected. Licensors should clearly mark any + material not subject to the license. This includes other CC- + licensed material, or material used under an exception or + limitation to copyright. More considerations for licensors: + wiki.creativecommons.org/Considerations_for_licensors + + Considerations for the public: By using one of our public + licenses, a licensor grants the public permission to use the + licensed material under specified terms and conditions. If + the licensor's permission is not necessary for any reason--for + example, because of any applicable exception or limitation to + copyright--then that use is not regulated by the license. Our + licenses grant only permissions under copyright and certain + other rights that a licensor has authority to grant. Use of + the licensed material may still be restricted for other + reasons, including because others have copyright or other + rights in the material. A licensor may make special requests, + such as asking that all changes be marked or described. + Although not required by our licenses, you are encouraged to + respect those requests where reasonable. More considerations + for the public: + wiki.creativecommons.org/Considerations_for_licensees + +======================================================================= + +Creative Commons Attribution 4.0 International Public License + +By exercising the Licensed Rights (defined below), You accept and agree +to be bound by the terms and conditions of this Creative Commons +Attribution 4.0 International Public License ("Public License"). To the +extent this Public License may be interpreted as a contract, You are +granted the Licensed Rights in consideration of Your acceptance of +these terms and conditions, and the Licensor grants You such rights in +consideration of benefits the Licensor receives from making the +Licensed Material available under these terms and conditions. + + +Section 1 -- Definitions. + + a. Adapted Material means material subject to Copyright and Similar + Rights that is derived from or based upon the Licensed Material + and in which the Licensed Material is translated, altered, + arranged, transformed, or otherwise modified in a manner requiring + permission under the Copyright and Similar Rights held by the + Licensor. For purposes of this Public License, where the Licensed + Material is a musical work, performance, or sound recording, + Adapted Material is always produced where the Licensed Material is + synched in timed relation with a moving image. + + b. Adapter's License means the license You apply to Your Copyright + and Similar Rights in Your contributions to Adapted Material in + accordance with the terms and conditions of this Public License. + + c. Copyright and Similar Rights means copyright and/or similar rights + closely related to copyright including, without limitation, + performance, broadcast, sound recording, and Sui Generis Database + Rights, without regard to how the rights are labeled or + categorized. For purposes of this Public License, the rights + specified in Section 2(b)(1)-(2) are not Copyright and Similar + Rights. + + d. Effective Technological Measures means those measures that, in the + absence of proper authority, may not be circumvented under laws + fulfilling obligations under Article 11 of the WIPO Copyright + Treaty adopted on December 20, 1996, and/or similar international + agreements. + + e. Exceptions and Limitations means fair use, fair dealing, and/or + any other exception or limitation to Copyright and Similar Rights + that applies to Your use of the Licensed Material. + + f. Licensed Material means the artistic or literary work, database, + or other material to which the Licensor applied this Public + License. + + g. Licensed Rights means the rights granted to You subject to the + terms and conditions of this Public License, which are limited to + all Copyright and Similar Rights that apply to Your use of the + Licensed Material and that the Licensor has authority to license. + + h. Licensor means the individual(s) or entity(ies) granting rights + under this Public License. + + i. Share means to provide material to the public by any means or + process that requires permission under the Licensed Rights, such + as reproduction, public display, public performance, distribution, + dissemination, communication, or importation, and to make material + available to the public including in ways that members of the + public may access the material from a place and at a time + individually chosen by them. + + j. Sui Generis Database Rights means rights other than copyright + resulting from Directive 96/9/EC of the European Parliament and of + the Council of 11 March 1996 on the legal protection of databases, + as amended and/or succeeded, as well as other essentially + equivalent rights anywhere in the world. + + k. You means the individual or entity exercising the Licensed Rights + under this Public License. Your has a corresponding meaning. + + +Section 2 -- Scope. + + a. License grant. + + 1. Subject to the terms and conditions of this Public License, + the Licensor hereby grants You a worldwide, royalty-free, + non-sublicensable, non-exclusive, irrevocable license to + exercise the Licensed Rights in the Licensed Material to: + + a. reproduce and Share the Licensed Material, in whole or + in part; and + + b. produce, reproduce, and Share Adapted Material. + + 2. Exceptions and Limitations. For the avoidance of doubt, where + Exceptions and Limitations apply to Your use, this Public + License does not apply, and You do not need to comply with + its terms and conditions. + + 3. Term. The term of this Public License is specified in Section + 6(a). + + 4. Media and formats; technical modifications allowed. The + Licensor authorizes You to exercise the Licensed Rights in + all media and formats whether now known or hereafter created, + and to make technical modifications necessary to do so. The + Licensor waives and/or agrees not to assert any right or + authority to forbid You from making technical modifications + necessary to exercise the Licensed Rights, including + technical modifications necessary to circumvent Effective + Technological Measures. For purposes of this Public License, + simply making modifications authorized by this Section 2(a) + (4) never produces Adapted Material. + + 5. Downstream recipients. + + a. Offer from the Licensor -- Licensed Material. Every + recipient of the Licensed Material automatically + receives an offer from the Licensor to exercise the + Licensed Rights under the terms and conditions of this + Public License. + + b. No downstream restrictions. You may not offer or impose + any additional or different terms or conditions on, or + apply any Effective Technological Measures to, the + Licensed Material if doing so restricts exercise of the + Licensed Rights by any recipient of the Licensed + Material. + + 6. No endorsement. Nothing in this Public License constitutes or + may be construed as permission to assert or imply that You + are, or that Your use of the Licensed Material is, connected + with, or sponsored, endorsed, or granted official status by, + the Licensor or others designated to receive attribution as + provided in Section 3(a)(1)(A)(i). + + b. Other rights. + + 1. Moral rights, such as the right of integrity, are not + licensed under this Public License, nor are publicity, + privacy, and/or other similar personality rights; however, to + the extent possible, the Licensor waives and/or agrees not to + assert any such rights held by the Licensor to the limited + extent necessary to allow You to exercise the Licensed + Rights, but not otherwise. + + 2. Patent and trademark rights are not licensed under this + Public License. + + 3. To the extent possible, the Licensor waives any right to + collect royalties from You for the exercise of the Licensed + Rights, whether directly or through a collecting society + under any voluntary or waivable statutory or compulsory + licensing scheme. In all other cases the Licensor expressly + reserves any right to collect such royalties. + + +Section 3 -- License Conditions. + +Your exercise of the Licensed Rights is expressly made subject to the +following conditions. + + a. Attribution. + + 1. If You Share the Licensed Material (including in modified + form), You must: + + a. retain the following if it is supplied by the Licensor + with the Licensed Material: + + i. identification of the creator(s) of the Licensed + Material and any others designated to receive + attribution, in any reasonable manner requested by + the Licensor (including by pseudonym if + designated); + + ii. a copyright notice; + + iii. a notice that refers to this Public License; + + iv. a notice that refers to the disclaimer of + warranties; + + v. a URI or hyperlink to the Licensed Material to the + extent reasonably practicable; + + b. indicate if You modified the Licensed Material and + retain an indication of any previous modifications; and + + c. indicate the Licensed Material is licensed under this + Public License, and include the text of, or the URI or + hyperlink to, this Public License. + + 2. You may satisfy the conditions in Section 3(a)(1) in any + reasonable manner based on the medium, means, and context in + which You Share the Licensed Material. For example, it may be + reasonable to satisfy the conditions by providing a URI or + hyperlink to a resource that includes the required + information. + + 3. If requested by the Licensor, You must remove any of the + information required by Section 3(a)(1)(A) to the extent + reasonably practicable. + + 4. If You Share Adapted Material You produce, the Adapter's + License You apply must not prevent recipients of the Adapted + Material from complying with this Public License. + + +Section 4 -- Sui Generis Database Rights. + +Where the Licensed Rights include Sui Generis Database Rights that +apply to Your use of the Licensed Material: + + a. for the avoidance of doubt, Section 2(a)(1) grants You the right + to extract, reuse, reproduce, and Share all or a substantial + portion of the contents of the database; + + b. if You include all or a substantial portion of the database + contents in a database in which You have Sui Generis Database + Rights, then the database in which You have Sui Generis Database + Rights (but not its individual contents) is Adapted Material; and + + c. You must comply with the conditions in Section 3(a) if You Share + all or a substantial portion of the contents of the database. + +For the avoidance of doubt, this Section 4 supplements and does not +replace Your obligations under this Public License where the Licensed +Rights include other Copyright and Similar Rights. + + +Section 5 -- Disclaimer of Warranties and Limitation of Liability. + + a. UNLESS OTHERWISE SEPARATELY UNDERTAKEN BY THE LICENSOR, TO THE + EXTENT POSSIBLE, THE LICENSOR OFFERS THE LICENSED MATERIAL AS-IS + AND AS-AVAILABLE, AND MAKES NO REPRESENTATIONS OR WARRANTIES OF + ANY KIND CONCERNING THE LICENSED MATERIAL, WHETHER EXPRESS, + IMPLIED, STATUTORY, OR OTHER. THIS INCLUDES, WITHOUT LIMITATION, + WARRANTIES OF TITLE, MERCHANTABILITY, FITNESS FOR A PARTICULAR + PURPOSE, NON-INFRINGEMENT, ABSENCE OF LATENT OR OTHER DEFECTS, + ACCURACY, OR THE PRESENCE OR ABSENCE OF ERRORS, WHETHER OR NOT + KNOWN OR DISCOVERABLE. WHERE DISCLAIMERS OF WARRANTIES ARE NOT + ALLOWED IN FULL OR IN PART, THIS DISCLAIMER MAY NOT APPLY TO YOU. + + b. TO THE EXTENT POSSIBLE, IN NO EVENT WILL THE LICENSOR BE LIABLE + TO YOU ON ANY LEGAL THEORY (INCLUDING, WITHOUT LIMITATION, + NEGLIGENCE) OR OTHERWISE FOR ANY DIRECT, SPECIAL, INDIRECT, + INCIDENTAL, CONSEQUENTIAL, PUNITIVE, EXEMPLARY, OR OTHER LOSSES, + COSTS, EXPENSES, OR DAMAGES ARISING OUT OF THIS PUBLIC LICENSE OR + USE OF THE LICENSED MATERIAL, EVEN IF THE LICENSOR HAS BEEN + ADVISED OF THE POSSIBILITY OF SUCH LOSSES, COSTS, EXPENSES, OR + DAMAGES. WHERE A LIMITATION OF LIABILITY IS NOT ALLOWED IN FULL OR + IN PART, THIS LIMITATION MAY NOT APPLY TO YOU. + + c. The disclaimer of warranties and limitation of liability provided + above shall be interpreted in a manner that, to the extent + possible, most closely approximates an absolute disclaimer and + waiver of all liability. + + +Section 6 -- Term and Termination. + + a. This Public License applies for the term of the Copyright and + Similar Rights licensed here. However, if You fail to comply with + this Public License, then Your rights under this Public License + terminate automatically. + + b. Where Your right to use the Licensed Material has terminated under + Section 6(a), it reinstates: + + 1. automatically as of the date the violation is cured, provided + it is cured within 30 days of Your discovery of the + violation; or + + 2. upon express reinstatement by the Licensor. + + For the avoidance of doubt, this Section 6(b) does not affect any + right the Licensor may have to seek remedies for Your violations + of this Public License. + + c. For the avoidance of doubt, the Licensor may also offer the + Licensed Material under separate terms or conditions or stop + distributing the Licensed Material at any time; however, doing so + will not terminate this Public License. + + d. Sections 1, 5, 6, 7, and 8 survive termination of this Public + License. + + +Section 7 -- Other Terms and Conditions. + + a. The Licensor shall not be bound by any additional or different + terms or conditions communicated by You unless expressly agreed. + + b. Any arrangements, understandings, or agreements regarding the + Licensed Material not stated herein are separate from and + independent of the terms and conditions of this Public License. + + +Section 8 -- Interpretation. + + a. For the avoidance of doubt, this Public License does not, and + shall not be interpreted to, reduce, limit, restrict, or impose + conditions on any use of the Licensed Material that could lawfully + be made without permission under this Public License. + + b. To the extent possible, if any provision of this Public License is + deemed unenforceable, it shall be automatically reformed to the + minimum extent necessary to make it enforceable. If the provision + cannot be reformed, it shall be severed from this Public License + without affecting the enforceability of the remaining terms and + conditions. + + c. No term or condition of this Public License will be waived and no + failure to comply consented to unless expressly agreed to by the + Licensor. + + d. Nothing in this Public License constitutes or may be interpreted + as a limitation upon, or waiver of, any privileges and immunities + that apply to the Licensor or You, including from the legal + processes of any jurisdiction or authority. + + +======================================================================= + +Creative Commons is not a party to its public +licenses. Notwithstanding, Creative Commons may elect to apply one of +its public licenses to material it publishes and in those instances +will be considered the "Licensor." The text of the Creative Commons +public licenses is dedicated to the public domain under the CC0 Public +Domain Dedication. Except for the limited purpose of indicating that +material is shared under a Creative Commons public license or as +otherwise permitted by the Creative Commons policies published at +creativecommons.org/policies, Creative Commons does not authorize the +use of the trademark "Creative Commons" or any other trademark or logo +of Creative Commons without its prior written consent including, +without limitation, in connection with any unauthorized modifications +to any of its public licenses or any other arrangements, +understandings, or agreements concerning use of licensed material. For +the avoidance of doubt, this paragraph does not form part of the +public licenses. + +Creative Commons may be contacted at creativecommons.org. + -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 14 22:44:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 14 Nov 2022 22:44:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443607.698251 (Exim 4.92) (envelope-from ) id 1ouiBq-0005Ak-Gu; Mon, 14 Nov 2022 22:44:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443607.698251; Mon, 14 Nov 2022 22:44:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouiBq-0005Ad-Dy; Mon, 14 Nov 2022 22:44:30 +0000 Received: by outflank-mailman (input) for mailman id 443607; Mon, 14 Nov 2022 22:44:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouiBo-0005AX-K5 for xen-devel@lists.xenproject.org; Mon, 14 Nov 2022 22:44:28 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e304a4c4-646d-11ed-8fd2-01056ac49cbb; Mon, 14 Nov 2022 23:44:25 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id A759E3200A24; Mon, 14 Nov 2022 17:44:22 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 14 Nov 2022 17:44:23 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Nov 2022 17:44:20 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e304a4c4-646d-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668465862; x= 1668552262; bh=hZeDXWVW4X+rEFcbPsT5Xj71pcns2L2JSacJro9Jg94=; b=U HpzY4yRQasCw8TIt8OMqB91gejxa1lxs0yNbh0eiBWZ7HP7voC0Ocm/wEl8jVE41 t2qA9KdVrRL+LcSphFLoXUoKzen8IB4U9ny74MFo7Kqzv0ievuoKac8PfKJW2e07 AkCBxWR81c6Ri5FowNjaSXzBkzmisVDf9IeJZJBHrwrpbK6dnhCgjzbwiGQ+lw3H HKIwDfSAMzKtW26UPdhs+qEXD7SFP2eWukFIRpiyzf3As7TLLmAZUAytm7Qk0NV/ Msy0umW/tvLScQwO8HpL423vsHeVcnU0QU0IOYv1dD4jfJTkx+LEVPUFhKAYPIJC lfPlieb8xIn8DVX0RlhYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668465862; x=1668552262; bh=hZeDXWVW4X+rEFcbPsT5Xj71pcns 2L2JSacJro9Jg94=; b=B/tSB+kcuauRrOWrC6kLFk5120BXThIlk7A/ZZVr0JPU hDAuzc7t+M1KmQbA71b7KbyW3vaMgIO18pkr8SvOaXIEWhk6XYhypNuFModZaVWk 4oJIkCc7ZJjQuH3n/tTOlUU1PXjRO/cIuP0whXPMvUSmd69tKJyHrZu9RegAVyxB 3sGMb0KYJBly2SFnsAG4yDgVip1RbFXX8v+E0mGmSZ0KhMtBH5vDL5zfP3D0Ly+Y AXXvWaEPuFd7rMJ6uPerORgf2IA2/BiBMLdlGpEKhqAtJc/CHgwRWlRtRhBuiE3S IJwR1Eo4V18ifLO6RzvH+PGpmK1sDQv8Gh833vuHkA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgeefgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeiledu vdekjeeukefhffetgeefiefffeejjedvieejvdfgjeehteduvdekffduieenucffohhmrg hinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 14 Nov 2022 23:44:17 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: "qemu-devel@nongnu.org" , Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen Message-ID: References: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> <20221114192011.1539233-2-marmarek@invisiblethingslab.com> <5f2b496a-f1dc-aa45-9600-aa9e5bbede8e@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vN93UjOCOL/zDQFO" Content-Disposition: inline In-Reply-To: <5f2b496a-f1dc-aa45-9600-aa9e5bbede8e@citrix.com> --vN93UjOCOL/zDQFO Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 14 Nov 2022 23:44:17 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: "qemu-devel@nongnu.org" , Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen On Mon, Nov 14, 2022 at 07:39:48PM +0000, Andrew Cooper wrote: > On 14/11/2022 19:20, Marek Marczykowski-G=C3=B3recki wrote: > > The /dev/mem is used for two purposes: > > - reading PCI_MSIX_ENTRY_CTRL_MASKBIT > > - reading Pending Bit Array (PBA) > > > > The first one was originally done because when Xen did not send all > > vector ctrl writes to the device model, so QEMU might have outdated old > > register value. This has been changed in Xen, so QEMU can now use its > > cached value of the register instead. I should have noted that "has been changed in Xen" isn't fully accurate (yet). It refers to this patch: https://lore.kernel.org/xen-devel/20221114192100.1539267-2-marmarek@invisib= lethingslab.com/T/#u > > The Pending Bit Array (PBA) handling is for the case where it lives on > > the same page as the MSI-X table itself. Xen has been extended to handle > > this case too (as well as other registers that may live on those pages), > > so QEMU handling is not necessary anymore. > > > > Removing /dev/mem access is useful to work within stubdomain, and > > necessary when dom0 kernel runs in lockdown mode. > > > > Signed-off-by: Marek Marczykowski-G=C3=B3recki >=20 > The commit message ought to go further.=C2=A0 Using /dev/mem like this is > buggy anyway, because it is trapped and emulated by Xen in whatever > context Qemu is running.=C2=A0 Qemu cannot get the actual hardware value,= and > even if it could, it would be racy with transient operations needing to > mask the vector. >=20 > i.e. it's not just nice-to-remote - it's fixing real corner cases. Good point, I'll extend it. But for this to work, the Xen patch needs to go in first (which won't happen for 4.17). And also, upstream QEMU probably needs some way to detect whether Xen has the change or not - to work with older versions too. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --vN93UjOCOL/zDQFO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmNyxMEACgkQ24/THMrX 1yx2Bgf/Zxk3GrfD0HbIUYIAIcvvtzcL6qNrGbF+G7sTR7MXOoNLa/b9qBelAtMr d1Rh+y6I0ne1PTTPI2eExh9aNN88XX90ZlNqpjRgalmuRgIo7FYy/f1gJ2QGOpm/ iHMtcWzXPNE1Y/KS5dBcJy5NYugO9NDt+VHqJR5e6fzw+912cmgVTiF6ZTuXRRJE IbG5dBwTc991XrOTSSiiwyHFEOOwVuly43tr+/+zogbCt0Cs8P2/lcuwt7OT20kV UGsu9hhZzqeaitAr/MoBgxBhdN6fDb2RtJtFrrpY8N8YavbkJ+8raUpIiQ8lmT/I 3vwrKLYK6/RxEWmdzWZNLcCbgpHKSw== =hLSV -----END PGP SIGNATURE----- --vN93UjOCOL/zDQFO-- From xen-devel-bounces@lists.xenproject.org Tue Nov 15 00:15:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 00:15:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443617.698261 (Exim 4.92) (envelope-from ) id 1oujbw-0007cY-II; Tue, 15 Nov 2022 00:15:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443617.698261; Tue, 15 Nov 2022 00:15:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oujbw-0007cR-Fd; Tue, 15 Nov 2022 00:15:32 +0000 Received: by outflank-mailman (input) for mailman id 443617; Tue, 15 Nov 2022 00:15:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oujbu-0007cL-GC for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 00:15:30 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0602.outbound.protection.outlook.com [2a01:111:f400:fe0c::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9bc49086-647a-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 01:15:28 +0100 (CET) Received: from AS9PR06CA0123.eurprd06.prod.outlook.com (2603:10a6:20b:467::14) by DU0PR08MB7591.eurprd08.prod.outlook.com (2603:10a6:10:31d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Tue, 15 Nov 2022 00:15:23 +0000 Received: from AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:467:cafe::c7) by AS9PR06CA0123.outlook.office365.com (2603:10a6:20b:467::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Tue, 15 Nov 2022 00:15:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT028.mail.protection.outlook.com (100.127.140.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Tue, 15 Nov 2022 00:15:22 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Tue, 15 Nov 2022 00:15:22 +0000 Received: from bec860f9e116.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B93BF526-3274-4F33-8EB3-7303462C70C6.1; Tue, 15 Nov 2022 00:15:16 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bec860f9e116.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 15 Nov 2022 00:15:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM9PR08MB6001.eurprd08.prod.outlook.com (2603:10a6:20b:2d5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Tue, 15 Nov 2022 00:15:14 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Tue, 15 Nov 2022 00:15:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bc49086-647a-11ed-91b6-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GaREI0M4n6bsjM0cowxS+3EY4VxaYRPJ5gdLHX1GV5A01xXEM2k8hmAexrbh8s25iePhOJGa7huv6GVqiwFhrWA63l+BcYkXjPEJDa0gzBjBFhL4MTvgGRhCJrFCVgPyBmwO5V0Wk7yu+0OsHNaFRW+k9eyrAYGS0JVLJrz/6F1LxB7EwMkhVH0vQpLaTO2U8VkFbx7dKSkJe+nz2OE73SFGVk5kgbcHFZT+738vBM9AWr26L7eONeDNZ8QN1HNFMPfrPQJxS1WsXPt9Wb0Xjg+MTVBN7h4rrK19GyzvK6PMQ4/oZlJsHp1ffWRoivrJbwhEj8RJgXlAxYBigVBVeQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4hcXMIpNfJ8wp2ekFQdBDUUx11/JGJINTrge5UmT/jU=; b=J2i4UyF+OKFtTuC4LgFX/Xx0HAEAN6PZZJA/6+Jvky+wCspbqPIvaPihdNHU9HU+Lyaox+IPk9Zhxi7K0dmlgQfhjXyshooT0oy7yrcrSr7F/Lquc8Y1BEoO8klMubWa78g9PbWY1yzlu/JKTk24Pce2KGhlusqVBqPib7RkS/3wgkSsBUxRX2jWr3L+z08BHa7jXKetGIfov2hHupLB7+QOAqH3mhblCyu/8k9/XSYYQb4EVnvzJ5BCNkbix11EzlKUmTlJILNuGb7Oa6wLjFBnitZjvaW3gicDew3p/KdqUU5hHq/AXL7AMkqyawMpP7YU8FXWVtVwymlT9gradw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4hcXMIpNfJ8wp2ekFQdBDUUx11/JGJINTrge5UmT/jU=; b=GbieyVBGUI8F1m/TR2uOjnEwMc9KdknPaI8u3T893Q9QAMqqGDqLfDVp71B7M+pi4T3fiscDNclArCaITRHWRb9S5witAFJfK/Aj1iR94C7/vu2hzltXBrvDQ/3Xov3CAzYKde6FyOY1jmNrfdG6iEobVaRSaSwLdLJpI2syOd8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4AHPGr8WS0WQ2csVqgCtO4tOxHgP8yaCwg6Mf7NswTzlKp2EFN1tzpsVfAAh76Hrzjs90q6DvdTcc/gc5NQWYVj4YCp3Oce9L9SsWhcQR4+htxz3lNZK9EHQaaUSwY1EVQ03qAE3c0MQDW3HOkfEk+5e9jbkXT03Zl/iFojg5HL4kuUZ6rVYS85EGmk9hRM8Uiq9BwaBnuNC6/WOV3SXTDY27ZpF9pVB3mwHiGeIX/8TkBpGfZBSsMeR6oMUpX8SqsHa4I32lJWx72XrVIflurqimdV9cJb66/7ZYvVm4QOa7N2HyKALGZZuAxMUi23y4HzbpkUarY6ZPqnK8tiIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4hcXMIpNfJ8wp2ekFQdBDUUx11/JGJINTrge5UmT/jU=; b=W+7Hf6X5CSHtt4r5Mh7aHuiEc+yWbR/jtveZts473luECgZWzyEnyaW3qPM7czphkjDOwByPjZtnKS3QTqs/O+oYSrkT6IP5zwGZvdVcevSrLlM38VUkguZxGMdMkQvW6naxTFkAdFk4HquUEVzsOdJ7KRziCIyZNPKVdzwvjXjVkewGaW9CUmwSatHb2hY/406zOTbjVDlME+3OwM1jJ/7y2uRduatZfhHorPsNvDjyiEVmaPV5Q8FbtQZI6kqdD2vgSDe2q+ef3KlQt+VDLEPwNfj/o8TzIUG/BgfPCweGqQDnTpZeKGUwSCb+XlHu2G5ZVldgZh8tDFRjdcEggw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4hcXMIpNfJ8wp2ekFQdBDUUx11/JGJINTrge5UmT/jU=; b=GbieyVBGUI8F1m/TR2uOjnEwMc9KdknPaI8u3T893Q9QAMqqGDqLfDVp71B7M+pi4T3fiscDNclArCaITRHWRb9S5witAFJfK/Aj1iR94C7/vu2hzltXBrvDQ/3Xov3CAzYKde6FyOY1jmNrfdG6iEobVaRSaSwLdLJpI2syOd8= From: Henry Wang To: Stefano Stabellini , "xen-devel@lists.xenproject.org" CC: "Andrew.Cooper3@citrix.com" , "george.dunlap@citrix.com" , "jbeulich@suse.com" , "julien@xen.org" , "wl@xen.org" Subject: RE: [PATCH for-4.17] Introduce CC-BY-4.0 license under LICENSES/ Thread-Topic: [PATCH for-4.17] Introduce CC-BY-4.0 license under LICENSES/ Thread-Index: AQHY+HmFh024TYCxEE+Jzx5Npg+Pxq4/HXRA Date: Tue, 15 Nov 2022 00:15:14 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6E26464BE5430241AEB943FD9B67BC71.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM9PR08MB6001:EE_|AM7EUR03FT028:EE_|DU0PR08MB7591:EE_ X-MS-Office365-Filtering-Correlation-Id: 25f11724-b449-4447-0b98-08dac69e7cdf x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XTszWC5X6X4QrXx4coE4UemcVCienFzwn6QNEZ4+oqCL37iAyAFPRHtMwOU805pCM4+syuItKTwlCYscxs53urXU13+cGmucikY5lro2Bf41t3sskaNKutaNp0K8Tdl9htPRN8HklJWaU5rh+DPR2qXRGOPrTp2QY14iLWsp6xGKAj8LetrnNwpAGAGZ/UqhjqruKhgWTyr24+pj6im3VUfcS16joR7gkk/8Kexa7+26JkNRMlCTRkERtsXiicV7PGUasPC5f9Gj9gP3k3+8JcbLq+LDaXt1SKfb6Ch1kR/sWH1Ma1YRg+zgvYhqPeaC3y/3ju7WlTBYerTBLgWW6rSpccHUUnry+sJ2eVNQOLu9ev4azQJCxuHodKLt1EPtvXitM3+G7LhdZWQpscpbJRJZTBroB38KpPaf//+W3aJgUtMlxs2Yw7TIt7bnVPz3htfyBaehzAO7vGLkg+HnFwHtxkVOt/CStd2athikJ1nX2A/KYfxuQdSmjTwL4KbCxWx11WtBomRIC7IFe0U+U9PNEjltNOxGbfVFYBozdJy3BKhXlfBV/dLK3HncO1fsTiBLOWMBdrugreGXML2D/4KSZtkBiQP4fWJ9D/fxXqY2P7L4khBmhWmoq0KYVQbeyD/vzSa5omj6lD8djs4eOHJPAxN0DH9dnCJoVnotMk2oQ/mrmMC5pGcObnhnMQOStwbgHgSbGaSKPgBY+kFmIBH3s+gy/vHqecPiCKIIaI3xkHiFkmf+Vlhj13MNwahf0LF5GWwssClOx+Z8LDCBJQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199015)(4744005)(64756008)(76116006)(2906002)(9686003)(122000001)(478600001)(38070700005)(66946007)(86362001)(41300700001)(33656002)(5660300002)(52536014)(38100700002)(83380400001)(186003)(26005)(4326008)(54906003)(66446008)(6506007)(316002)(110136005)(66556008)(7696005)(8676002)(55016003)(71200400001)(66476007)(8936002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6001 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 34284c61-497c-4ae3-1f58-08dac69e7807 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dEKUQmizQjxrgPwM6JIAE2QQIpH8yqQ/eWHktsV0Mt5BRBqWwMddQJJ8fjJKN568XlNd2ljvWcTRN2c4xuRNsAbizDbkFDQcYlDndixZrX55rekMheVM29scjLQGuQsIL+AP9lNl4Tt8ZD8ukTrqHrmeMe4CDPBR0VzdywEPqg9vyKDokxTvKnviOMcuHnJiP1IQbHy6iwvwut1w8Y0SjDEqggo4R9kbkxMJwZwCfOfrgktGiWXotsQjbxlbCbk57CntGC8JoCAcORIlh4pyoBk4lTCuCQvehwHjaaV1mFK+50jrUHq0XNiM6ciEYpUJybAqlyHk6tXkrNK1Z1KmO5TvFoeRTE8zln6DEQXPQ6hVy53fzEmrMtNVsk8oUDmXIN/K/MOeTQmid9XJO3fTyLyuekqsRy3TBVNnCiEj9MecKSeY7pT20mHJZm1ixYQ2JYYUItvLVMSo/DVvlasVWyp7+XDYIHHr6bXRCckk4xO1C6Luhs5y6LzFe6RY8DjEtPWqqPtBeC9sS8vx0lO68mJRxv6Q3iecmMJpjxR+V/u2BHDsjkUIH9XPj/23kNb3deqzkHjyAPM1hFoy+soQmfbdhnItkhbdqDlKM3Vuo7+wm1zZg23U6NxUZ0iu+ZvO2LkORXxf7SOi6dEASkx+z/7SczTlf7uWVsRd+JPrF1pXpj5OIpLg02yFxEQ+o4Gpiwgvzrh5ytqPYzunWWdp9+0yhmaVac4FfVQUvgfJOMoloQlfbZlZ6j6M02o79yAhjQvDvOBBdsDIfX6yzPCB2g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199015)(40470700004)(46966006)(36840700001)(5660300002)(82310400005)(52536014)(4744005)(2906002)(8936002)(70206006)(4326008)(55016003)(41300700001)(70586007)(8676002)(36860700001)(33656002)(478600001)(81166007)(6506007)(54906003)(316002)(7696005)(110136005)(9686003)(26005)(40480700001)(83380400001)(336012)(186003)(86362001)(356005)(40460700003)(47076005)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 00:15:22.7846 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25f11724-b449-4447-0b98-08dac69e7cdf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7591 Hi Stefano, > -----Original Message----- > From: Stefano Stabellini > Subject: [PATCH for-4.17] Introduce CC-BY-4.0 license under LICENSES/ >=20 > We use CC-BY-4.0 for many of the documents under docs/ so we should > have > a copy of the license. >=20 > Signed-off-by: Stefano Stabellini Per the message in IRC, it would be good to keep the licenses complete, and also this is a zero risk patch, so: Release-acked-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Tue Nov 15 00:35:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 00:35:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443621.698273 (Exim 4.92) (envelope-from ) id 1oujvd-00024d-6F; Tue, 15 Nov 2022 00:35:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443621.698273; Tue, 15 Nov 2022 00:35:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oujvd-00024W-2a; Tue, 15 Nov 2022 00:35:53 +0000 Received: by outflank-mailman (input) for mailman id 443621; Tue, 15 Nov 2022 00:35:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oujvb-00024Q-Dk for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 00:35:51 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 70a7cc5f-647d-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 01:35:46 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70a7cc5f-647d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668472547; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=dB5poqfnJXe9UD8XFgdHm6aJCf0PrbVG5xzPeIDBfQU=; b=PWHPUDqZ7ezIlMEMJlIj1OlTVsygGrsJTWJh2tnPBm561NHfbCiStFt2 wsPaa5/l81T991rTLGYiHjPsO0msrrAM6CSUynphmVq5R1v53AYtGP87B qVspcN6c0ezkRtu9dTZj+fQ2PylnOVKXiECTu8ygZedHEnDVypsUkrewY Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85238916 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:5c+Sda2caWl8Fjj2WvbD5dhxkn2cJEfYwER7XKvMYLTBsI5bpzRRx 2IcCmHTPPjfa2LxfohwaNi18BgBuJSGzdZmSwZspC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVnOagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfE1lF2 L8lOBQxaT+PptKW5pzgeK5tr5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKkSbC/FMEg5/5JYWteGknHTgNRZfr0qYv/Ef6GnP1g1hlrPqNbI5f/TaGJ8OzhfB+ Aoq+UzkKCMqG9Cy8wGlqGOxrM2QhzOrXZg7QejQGvlC3wTImz175ActfUS/iem0jAi5Qd03A 2wZ/DA/65c78kODR8P4GRa/pRasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQI/ FKUm9LiBRR0raaYD3ma89+pQSiaYHZPazVYPGldEFVDs4KLTJwPYgznXO5oPe2InvnJHh784 gCqigZltfISpJtev0mkxmzvjzWpr5nPawc64ATLQ26ohj9EiJ6Zi5+AsgaCs6sZRGqNZhzY5 SVfxZDChAwbJcvV/BFhVtnhC11ACxytFDTHyWBiEJA6n9hG0y7yJNsAiN2SyaoADyrlRdMLS BWM0e+yzMUJVJdPUUOQS9zZNijS5fK8fekJr9iNBjeOC7AoHON9wAlgZFSLw0fmm1U2nKc0N P+zKJjyXSpHUfU/kmfpHY/xNIPHIQhnmwvuqW3TlUz7gdJymlbIIVv6DLd+Rr9gt/7VyOkk2 91eK9GL231ivB7WO0HqHE96BQ5iEEXX8rit95cILbfTelE5cIzjYteIqY4cl0Vet/w9vo/1E ruVAye0FHKXaaX7FDi3 IronPort-HdrOrdr: A9a23:jEnP3qpmjM7tnmTDldlKP98aV5oheYIsimQD101hICG8cqSj+P xG+85rsSMc6QxhPU3I9urgBEDtex7hHP1OkOss1NWZPDUO0VHAROoJ0WKL+UyGJ8SUzIBgPM lbH5SWcOeAbmRHsQ== X-IronPort-AV: E=Sophos;i="5.96,164,1665460800"; d="scan'208";a="85238916" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Henry Wang Subject: [PATCH for-4.17] x86/hvm: Revert per-domain APIC acceleration support Date: Tue, 15 Nov 2022 00:35:39 +0000 Message-ID: <20221115003539.19502-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisited in due course. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Henry Wang For 4.17. This fixes a release blocker. https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/694585857 --- docs/man/xl.cfg.5.pod.in | 15 --------------- docs/man/xl.conf.5.pod.in | 12 ------------ tools/golang/xenlight/helpers.gen.go | 16 ---------------- tools/golang/xenlight/types.gen.go | 4 ---- tools/include/libxl.h | 14 -------------- tools/libs/light/libxl.c | 3 --- tools/libs/light/libxl_arch.h | 4 ---- tools/libs/light/libxl_arm.c | 5 ----- tools/libs/light/libxl_types.idl | 4 ---- tools/libs/light/libxl_x86.c | 32 -------------------------------- tools/ocaml/libs/xc/xenctrl.ml | 6 +----- tools/ocaml/libs/xc/xenctrl.mli | 6 +----- tools/ocaml/libs/xc/xenctrl_stubs.c | 7 ++----- tools/xl/xl.c | 8 -------- tools/xl/xl.h | 2 -- tools/xl/xl_info.c | 6 ++---- tools/xl/xl_parse.c | 19 ------------------- xen/arch/x86/domain.c | 23 +---------------------- xen/arch/x86/hvm/hvm.c | 9 --------- xen/arch/x86/hvm/vmx/vmcs.c | 11 ----------- xen/arch/x86/hvm/vmx/vmx.c | 13 +++++++++---- xen/arch/x86/include/asm/hvm/domain.h | 6 ------ xen/arch/x86/include/asm/hvm/hvm.h | 10 ---------- xen/arch/x86/sysctl.c | 4 ---- xen/arch/x86/traps.c | 5 ++--- xen/include/public/arch-x86/xen.h | 4 +--- xen/include/public/sysctl.h | 7 ------- 27 files changed, 19 insertions(+), 236 deletions(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 31e58b73b0c9..ec444fb2ba79 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -1862,21 +1862,6 @@ firmware tables when using certain older guest Operating Systems. These tables have been superseded by newer constructs within the ACPI tables. -=item B - -B<(x86 only)> Enables or disables hardware assisted virtualization for -xAPIC. With this option enabled, a memory-mapped APIC access will be -decoded by hardware and either issue a more specific VM exit than just -a p2m fault, or altogether avoid a VM exit. The -default is settable via L. - -=item B - -B<(x86 only)> Enables or disables hardware assisted virtualization for -x2APIC. With this option enabled, certain accesses to MSR APIC -registers will avoid a VM exit into the hypervisor. The default is -settable via L. - =item B B<(x86 only)> Hides or exposes the No-eXecute capability. This allows a guest diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in index 95d136d1ea73..df20c08137bf 100644 --- a/docs/man/xl.conf.5.pod.in +++ b/docs/man/xl.conf.5.pod.in @@ -107,18 +107,6 @@ Sets the default value for the C domain config value. Default: maximum grant version supported by the hypervisor. -=item B - -If enabled, domains will use xAPIC hardware assisted virtualization by default. - -Default: enabled if supported. - -=item B - -If enabled, domains will use x2APIC hardware assisted virtualization by default. - -Default: enabled if supported. - =item B Configures the default hotplug script used by virtual network devices. diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index fa3cf2ab7658..cb1bdf9bdf41 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1120,12 +1120,6 @@ x.ArchArm.Vuart = VuartType(xc.arch_arm.vuart) if err := x.ArchX86.MsrRelaxed.fromC(&xc.arch_x86.msr_relaxed);err != nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } -if err := x.ArchX86.AssistedXapic.fromC(&xc.arch_x86.assisted_xapic);err != nil { -return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err) -} -if err := x.ArchX86.AssistedX2Apic.fromC(&xc.arch_x86.assisted_x2apic);err != nil { -return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err) -} x.Altp2M = Altp2MMode(xc.altp2m) x.VmtraceBufKb = int(xc.vmtrace_buf_kb) if err := x.Vpmu.fromC(&xc.vpmu);err != nil { @@ -1611,12 +1605,6 @@ xc.arch_arm.vuart = C.libxl_vuart_type(x.ArchArm.Vuart) if err := x.ArchX86.MsrRelaxed.toC(&xc.arch_x86.msr_relaxed); err != nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } -if err := x.ArchX86.AssistedXapic.toC(&xc.arch_x86.assisted_xapic); err != nil { -return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err) -} -if err := x.ArchX86.AssistedX2Apic.toC(&xc.arch_x86.assisted_x2apic); err != nil { -return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err) -} xc.altp2m = C.libxl_altp2m_mode(x.Altp2M) xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb) if err := x.Vpmu.toC(&xc.vpmu); err != nil { @@ -3405,8 +3393,6 @@ x.CapVmtrace = bool(xc.cap_vmtrace) x.CapVpmu = bool(xc.cap_vpmu) x.CapGnttabV1 = bool(xc.cap_gnttab_v1) x.CapGnttabV2 = bool(xc.cap_gnttab_v2) -x.CapAssistedXapic = bool(xc.cap_assisted_xapic) -x.CapAssistedX2Apic = bool(xc.cap_assisted_x2apic) return nil} @@ -3441,8 +3427,6 @@ xc.cap_vmtrace = C.bool(x.CapVmtrace) xc.cap_vpmu = C.bool(x.CapVpmu) xc.cap_gnttab_v1 = C.bool(x.CapGnttabV1) xc.cap_gnttab_v2 = C.bool(x.CapGnttabV2) -xc.cap_assisted_xapic = C.bool(x.CapAssistedXapic) -xc.cap_assisted_x2apic = C.bool(x.CapAssistedX2Apic) return nil } diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index a0be7ada8c63..871576fb0e23 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -534,8 +534,6 @@ Vuart VuartType } ArchX86 struct { MsrRelaxed Defbool -AssistedXapic Defbool -AssistedX2Apic Defbool } Altp2M Altp2MMode VmtraceBufKb int @@ -1036,8 +1034,6 @@ CapVmtrace bool CapVpmu bool CapGnttabV1 bool CapGnttabV2 bool -CapAssistedXapic bool -CapAssistedX2Apic bool } type Connectorinfo struct { diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 2321a648a59a..d652895075a0 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -536,20 +536,6 @@ #define LIBXL_HAVE_NIC_TRUSTED 1 /* - * LIBXL_HAVE_PHYSINFO_ASSISTED_APIC indicates that libxl_physinfo has - * cap_assisted_xapic and cap_assisted_x2apic fields, which indicates - * the availability of x{2}APIC hardware assisted virtualization. - */ -#define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1 - -/* - * LIBXL_HAVE_ASSISTED_APIC indicates that libxl_domain_build_info has - * assisted_xapic and assisted_x2apic fields for enabling hardware - * assisted virtualization for x{2}apic per domain. - */ -#define LIBXL_HAVE_ASSISTED_APIC 1 - -/* * LIBXL_HAVE_DEVICE_DISK_SPECIFICATION indicates that 'specification' and * 'transport' fields (of libxl_disk_specification and libxl_disk_transport * types respectively) are present in libxl_device_disk. diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c index 6d699951e291..a0bf7d186f69 100644 --- a/tools/libs/light/libxl.c +++ b/tools/libs/light/libxl.c @@ -15,7 +15,6 @@ #include "libxl_osdeps.h" #include "libxl_internal.h" -#include "libxl_arch.h" int libxl_ctx_alloc(libxl_ctx **pctx, int version, unsigned flags, xentoollog_logger * lg) @@ -411,8 +410,6 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo) physinfo->cap_gnttab_v2 = !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_gnttab_v2); - libxl__arch_get_physinfo(physinfo, &xcphysinfo); - GC_FREE; return 0; } diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h index 247cca130fc3..f88f11d6de1d 100644 --- a/tools/libs/light/libxl_arch.h +++ b/tools/libs/light/libxl_arch.h @@ -87,10 +87,6 @@ int libxl__arch_extra_memory(libxl__gc *gc, uint64_t *out); _hidden -void libxl__arch_get_physinfo(libxl_physinfo *physinfo, - const xc_physinfo_t *xcphysinfo); - -_hidden void libxl__arch_update_domain_config(libxl__gc *gc, libxl_domain_config *dst, const libxl_domain_config *src); diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 2a5e93c28403..2edeaa3de63d 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -1606,11 +1606,6 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, return rc; } -void libxl__arch_get_physinfo(libxl_physinfo *physinfo, - const xc_physinfo_t *xcphysinfo) -{ -} - void libxl__arch_update_domain_config(libxl__gc *gc, libxl_domain_config *dst, const libxl_domain_config *src) diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index d634f304cda2..9e3d33cb5a59 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -660,8 +660,6 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("vuart", libxl_vuart_type), ])), ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), - ("assisted_xapic", libxl_defbool), - ("assisted_x2apic", libxl_defbool), ])), # Alternate p2m is not bound to any architecture or guest type, as it is # supported by x86 HVM and ARM support is planned. @@ -1090,8 +1088,6 @@ libxl_physinfo = Struct("physinfo", [ ("cap_vpmu", bool), ("cap_gnttab_v1", bool), ("cap_gnttab_v2", bool), - ("cap_assisted_xapic", bool), - ("cap_assisted_x2apic", bool), ], dir=DIR_OUT) libxl_connectorinfo = Struct("connectorinfo", [ diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c index 7c5ee74443e5..e4717f6b5345 100644 --- a/tools/libs/light/libxl_x86.c +++ b/tools/libs/light/libxl_x86.c @@ -23,15 +23,6 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed)) config->arch.misc_flags |= XEN_X86_MSR_RELAXED; - if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV) - { - if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_xapic)) - config->arch.misc_flags |= XEN_X86_ASSISTED_XAPIC; - - if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_x2apic)) - config->arch.misc_flags |= XEN_X86_ASSISTED_X2APIC; - } - return 0; } @@ -835,18 +826,6 @@ int libxl__arch_domain_build_info_setdefault(libxl__gc *gc, libxl_defbool_setdefault(&b_info->acpi, true); libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false); - if (b_info->type != LIBXL_DOMAIN_TYPE_PV) { - libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic, - physinfo->cap_assisted_xapic); - libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic, - physinfo->cap_assisted_x2apic); - } - else if (!libxl_defbool_is_default(b_info->arch_x86.assisted_xapic) || - !libxl_defbool_is_default(b_info->arch_x86.assisted_x2apic)) { - LOG(ERROR, "Interrupt Controller Virtualization not supported for PV"); - return ERROR_INVAL; - } - return 0; } @@ -890,17 +869,6 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, return rc; } -void libxl__arch_get_physinfo(libxl_physinfo *physinfo, - const xc_physinfo_t *xcphysinfo) -{ - physinfo->cap_assisted_xapic = - !!(xcphysinfo->arch_capabilities & - XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC); - physinfo->cap_assisted_x2apic = - !!(xcphysinfo->arch_capabilities & - XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC); -} - void libxl__arch_update_domain_config(libxl__gc *gc, libxl_domain_config *dst, const libxl_domain_config *src) diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 28ed6422317c..83e39a861685 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -50,8 +50,6 @@ type x86_arch_emulation_flags = type x86_arch_misc_flags = | X86_MSR_RELAXED - | X86_ASSISTED_XAPIC - | X86_ASSISTED_X2APIC type xen_x86_arch_domainconfig = { @@ -132,9 +130,7 @@ type physinfo_cap_flag = type arm_physinfo_cap_flag -type x86_physinfo_cap_flag = - | CAP_X86_ASSISTED_XAPIC - | CAP_X86_ASSISTED_X2APIC +type x86_physinfo_cap_flag type arch_physinfo_cap_flags = | ARM of arm_physinfo_cap_flag list diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index c2076d60c970..5bf5f5dfea36 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -44,8 +44,6 @@ type x86_arch_emulation_flags = type x86_arch_misc_flags = | X86_MSR_RELAXED - | X86_ASSISTED_XAPIC - | X86_ASSISTED_X2APIC type xen_x86_arch_domainconfig = { emulation_flags: x86_arch_emulation_flags list; @@ -117,9 +115,7 @@ type physinfo_cap_flag = type arm_physinfo_cap_flag -type x86_physinfo_cap_flag = - | CAP_X86_ASSISTED_XAPIC - | CAP_X86_ASSISTED_X2APIC +type x86_physinfo_cap_flag type arch_physinfo_cap_flags = | ARM of arm_physinfo_cap_flag list diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index a8789d19be4b..f37848ae0bb3 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -241,7 +241,7 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config cfg.arch.misc_flags = ocaml_list_to_c_bitmap /* ! x86_arch_misc_flags X86_ none */ - /* ! XEN_X86_ XEN_X86_MISC_FLAGS_MAX max */ + /* ! XEN_X86_ XEN_X86_MSR_RELAXED all */ (VAL_MISC_FLAGS); #undef VAL_MISC_FLAGS @@ -748,10 +748,7 @@ CAMLprim value stub_xc_physinfo(value xch) Store_field(physinfo, 9, Val_int(c_physinfo.max_cpu_id + 1)); #if defined(__i386__) || defined(__x86_64__) - arch_cap_list = c_bitmap_to_ocaml_list - /* ! x86_physinfo_cap_flag CAP_X86_ none */ - /* ! XEN_SYSCTL_PHYSCAP_X86_ XEN_SYSCTL_PHYSCAP_X86_MAX max */ - (c_physinfo.arch_capabilities); + arch_cap_list = Tag_cons; arch_cap_flags_tag = 1; /* tag x86 */ #else diff --git a/tools/xl/xl.c b/tools/xl/xl.c index 31eb223309fb..2d1ec18ea30f 100644 --- a/tools/xl/xl.c +++ b/tools/xl/xl.c @@ -57,8 +57,6 @@ int max_grant_frames = -1; int max_maptrack_frames = -1; int max_grant_version = LIBXL_MAX_GRANT_DEFAULT; libxl_domid domid_policy = INVALID_DOMID; -int assisted_xapic = -1; -int assisted_x2apic = -1; xentoollog_level minmsglevel = minmsglevel_default; @@ -203,12 +201,6 @@ static void parse_global_config(const char *configfile, if (!xlu_cfg_get_long (config, "claim_mode", &l, 0)) claim_mode = l; - if (!xlu_cfg_get_long (config, "assisted_xapic", &l, 0)) - assisted_xapic = l; - - if (!xlu_cfg_get_long (config, "assisted_x2apic", &l, 0)) - assisted_x2apic = l; - xlu_cfg_replace_string (config, "remus.default.netbufscript", &default_remus_netbufscript, 0); xlu_cfg_replace_string (config, "colo.default.proxyscript", diff --git a/tools/xl/xl.h b/tools/xl/xl.h index 7c9aff6ad7a6..72538d6a8192 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -285,8 +285,6 @@ extern libxl_bitmap global_vm_affinity_mask; extern libxl_bitmap global_hvm_affinity_mask; extern libxl_bitmap global_pv_affinity_mask; extern libxl_domid domid_policy; -extern int assisted_xapic; -extern int assisted_x2apic; enum output_format { OUTPUT_FORMAT_JSON, diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c index 32052707548f..712b7638b013 100644 --- a/tools/xl/xl_info.c +++ b/tools/xl/xl_info.c @@ -210,7 +210,7 @@ static void output_physinfo(void) info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7] ); - maybe_printf("virt_caps :%s%s%s%s%s%s%s%s%s%s%s%s%s\n", + maybe_printf("virt_caps :%s%s%s%s%s%s%s%s%s%s%s\n", info.cap_pv ? " pv" : "", info.cap_hvm ? " hvm" : "", info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "", @@ -221,9 +221,7 @@ static void output_physinfo(void) info.cap_vmtrace ? " vmtrace" : "", info.cap_vpmu ? " vpmu" : "", info.cap_gnttab_v1 ? " gnttab-v1" : "", - info.cap_gnttab_v2 ? " gnttab-v2" : "", - info.cap_assisted_xapic ? " assisted_xapic" : "", - info.cap_assisted_x2apic ? " assisted_x2apic" : "" + info.cap_gnttab_v2 ? " gnttab-v2" : "" ); vinfo = libxl_get_version_info(ctx); diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 1b5381cef033..644ab8f8fd36 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2765,25 +2765,6 @@ void parse_config_data(const char *config_source, xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0); - if (b_info->type != LIBXL_DOMAIN_TYPE_PV) { - e = xlu_cfg_get_long(config, "assisted_xapic", &l , 0); - if (!e) - libxl_defbool_set(&b_info->arch_x86.assisted_xapic, l); - else if (e != ESRCH) - exit(1); - else if (assisted_xapic != -1) /* use global default if present */ - libxl_defbool_set(&b_info->arch_x86.assisted_xapic, assisted_xapic); - - e = xlu_cfg_get_long(config, "assisted_x2apic", &l, 0); - if (!e) - libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, l); - else if (e != ESRCH) - exit(1); - else if (assisted_x2apic != -1) /* use global default if present */ - libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, - assisted_x2apic); - } - xlu_cfg_destroy(config); } diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 79107dac6922..5a119eec3ac4 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -49,7 +49,6 @@ #include #include #include -#include #include #include #include @@ -619,8 +618,6 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) bool hvm = config->flags & XEN_DOMCTL_CDF_hvm; bool hap = config->flags & XEN_DOMCTL_CDF_hap; bool nested_virt = config->flags & XEN_DOMCTL_CDF_nested_virt; - bool assisted_xapic = config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC; - bool assisted_x2apic = config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC; unsigned int max_vcpus; if ( hvm ? !hvm_enabled : !IS_ENABLED(CONFIG_PV) ) @@ -687,31 +684,13 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) } } - if ( config->arch.misc_flags & ~(XEN_X86_MSR_RELAXED | - XEN_X86_ASSISTED_XAPIC | - XEN_X86_ASSISTED_X2APIC) ) + if ( config->arch.misc_flags & ~XEN_X86_MSR_RELAXED ) { dprintk(XENLOG_INFO, "Invalid arch misc flags %#x\n", config->arch.misc_flags); return -EINVAL; } - if ( (assisted_xapic || assisted_x2apic) && !hvm ) - { - dprintk(XENLOG_INFO, - "Interrupt Controller Virtualization not supported for PV\n"); - return -EINVAL; - } - - if ( (assisted_xapic && !assisted_xapic_available) || - (assisted_x2apic && !assisted_x2apic_available) ) - { - dprintk(XENLOG_INFO, - "Hardware assisted x%sAPIC requested but not available\n", - assisted_xapic && !assisted_xapic_available ? "" : "2"); - return -ENODEV; - } - return 0; } diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 15a9b34c5988..ae4368ec4b33 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -117,9 +117,6 @@ static const char __initconst warning_hvm_fep[] = static bool_t __initdata opt_altp2m_enabled = 0; boolean_param("altp2m", opt_altp2m_enabled); -bool __ro_after_init assisted_xapic_available; -bool __ro_after_init assisted_x2apic_available; - static int cf_check cpu_callback( struct notifier_block *nfb, unsigned long action, void *hcpu) { @@ -598,12 +595,6 @@ int hvm_domain_initialise(struct domain *d, INIT_LIST_HEAD(&d->arch.hvm.mmcfg_regions); INIT_LIST_HEAD(&d->arch.hvm.msix_tables); - d->arch.hvm.assisted_xapic = - config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC; - - d->arch.hvm.assisted_x2apic = - config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC; - rc = create_perdomain_mapping(d, PERDOMAIN_VIRT_START, 0, NULL, NULL); if ( rc ) goto fail; diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index a1aca1ec046c..84dbb88d33b7 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1134,10 +1134,6 @@ static int construct_vmcs(struct vcpu *v) __vmwrite(PLE_WINDOW, ple_window); } - if ( !has_assisted_xapic(d) ) - v->arch.hvm.vmx.secondary_exec_control &= - ~SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; - if ( cpu_has_vmx_secondary_exec_control ) __vmwrite(SECONDARY_VM_EXEC_CONTROL, v->arch.hvm.vmx.secondary_exec_control); @@ -2154,14 +2150,7 @@ int __init vmx_vmcs_init(void) ret = _vmx_cpu_up(true); if ( !ret ) - { - /* Check whether hardware supports accelerated xapic and x2apic. */ - assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses; - assisted_x2apic_available = cpu_has_vmx_virtualize_x2apic_mode && - (cpu_has_vmx_apic_reg_virt || - cpu_has_vmx_virtual_intr_delivery); register_keyhandler('v', vmcs_dump, "dump VT-x VMCSs", 1); - } return ret; } diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index e624b415c913..7c81b80710f9 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3405,11 +3405,16 @@ static void vmx_install_vlapic_mapping(struct vcpu *v) void vmx_vlapic_msr_changed(struct vcpu *v) { + int virtualize_x2apic_mode; struct vlapic *vlapic = vcpu_vlapic(v); unsigned int msr; - if ( !has_assisted_xapic(v->domain) && - !has_assisted_x2apic(v->domain) ) + virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt || + cpu_has_vmx_virtual_intr_delivery) && + cpu_has_vmx_virtualize_x2apic_mode ); + + if ( !cpu_has_vmx_virtualize_apic_accesses && + !virtualize_x2apic_mode ) return; vmx_vmcs_enter(v); @@ -3419,7 +3424,7 @@ void vmx_vlapic_msr_changed(struct vcpu *v) if ( !vlapic_hw_disabled(vlapic) && (vlapic_base_address(vlapic) == APIC_DEFAULT_PHYS_BASE) ) { - if ( has_assisted_x2apic(v->domain) && vlapic_x2apic_mode(vlapic) ) + if ( virtualize_x2apic_mode && vlapic_x2apic_mode(vlapic) ) { v->arch.hvm.vmx.secondary_exec_control |= SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE; @@ -3440,7 +3445,7 @@ void vmx_vlapic_msr_changed(struct vcpu *v) vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, VMX_MSR_W); } } - else if ( has_assisted_xapic(v->domain) ) + else v->arch.hvm.vmx.secondary_exec_control |= SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; } diff --git a/xen/arch/x86/include/asm/hvm/domain.h b/xen/arch/x86/include/asm/hvm/domain.h index 92bf53483c43..698455444ea8 100644 --- a/xen/arch/x86/include/asm/hvm/domain.h +++ b/xen/arch/x86/include/asm/hvm/domain.h @@ -117,12 +117,6 @@ struct hvm_domain { bool is_s3_suspended; - /* xAPIC hardware assisted virtualization. */ - bool assisted_xapic; - - /* x2APIC hardware assisted virtualization. */ - bool assisted_x2apic; - /* hypervisor intercepted msix table */ struct list_head msixtbl_list; diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index 66836122e8de..93254651f2f5 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -389,12 +389,6 @@ int hvm_get_param(struct domain *d, uint32_t index, uint64_t *value); #define hvm_tsc_scaling_ratio(d) \ ((d)->arch.hvm.tsc_scaling_ratio) -extern bool assisted_xapic_available; -extern bool assisted_x2apic_available; - -#define has_assisted_xapic(d) ((d)->arch.hvm.assisted_xapic) -#define has_assisted_x2apic(d) ((d)->arch.hvm.assisted_x2apic) - #define hvm_get_guest_time(v) hvm_get_guest_time_fixed(v, 0) #define hvm_paging_enabled(v) \ @@ -908,11 +902,7 @@ static inline void hvm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val) #define hvm_tsc_scaling_supported false #define hap_has_1gb false #define hap_has_2mb false -#define assisted_xapic_available false -#define assisted_x2apic_available false -#define has_assisted_xapic(d) ((void)(d), false) -#define has_assisted_x2apic(d) ((void)(d), false) #define hvm_paging_enabled(v) ((void)(v), false) #define hvm_wp_enabled(v) ((void)(v), false) #define hvm_pcid_enabled(v) ((void)(v), false) diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c index 716525f72f1e..f82abc248885 100644 --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -135,10 +135,6 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi) pi->capabilities |= XEN_SYSCTL_PHYSCAP_hap; if ( IS_ENABLED(CONFIG_SHADOW_PAGING) ) pi->capabilities |= XEN_SYSCTL_PHYSCAP_shadow; - if ( assisted_xapic_available ) - pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC; - if ( assisted_x2apic_available ) - pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC; } long arch_do_sysctl( diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 56e59896bfec..cade9e12f8fa 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1109,8 +1109,7 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, if ( !is_hvm_domain(d) || subleaf != 0 ) break; - if ( cpu_has_vmx_apic_reg_virt && - has_assisted_xapic(d) ) + if ( cpu_has_vmx_apic_reg_virt ) res->a |= XEN_HVM_CPUID_APIC_ACCESS_VIRT; /* @@ -1119,7 +1118,7 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, * and wrmsr in the guest will run without VMEXITs (see * vmx_vlapic_msr_changed()). */ - if ( has_assisted_x2apic(d) && + if ( cpu_has_vmx_virtualize_x2apic_mode && cpu_has_vmx_apic_reg_virt && cpu_has_vmx_virtual_intr_delivery ) res->a |= XEN_HVM_CPUID_X2APIC_VIRT; diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h index 546dd4496ac6..59e03310b810 100644 --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -317,13 +317,11 @@ struct xen_arch_domainconfig { * doesn't allow the guest to read or write to the underlying MSR. */ #define XEN_X86_MSR_RELAXED (1u << 0) -#define XEN_X86_ASSISTED_XAPIC (1u << 1) -#define XEN_X86_ASSISTED_X2APIC (1u << 2) uint32_t misc_flags; }; /* Max XEN_X86_* constant. Used for ABI checking. */ -#define XEN_X86_MISC_FLAGS_MAX XEN_X86_ASSISTED_X2APIC +#define XEN_X86_MISC_FLAGS_MAX XEN_X86_MSR_RELAXED #endif diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 567290672959..1dc44d101907 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -111,13 +111,6 @@ struct xen_sysctl_tbuf_op { /* Max XEN_SYSCTL_PHYSCAP_* constant. Used for ABI checking. */ #define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_gnttab_v2 -/* The platform supports x{2}apic hardware assisted emulation. */ -#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC (1u << 0) -#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC (1u << 1) - -/* Max XEN_SYSCTL_PHYSCAP_X86_* constant. Used for ABI checking. */ -#define XEN_SYSCTL_PHYSCAP_X86_MAX XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC - struct xen_sysctl_physinfo { uint32_t threads_per_core; uint32_t cores_per_socket; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 00:40:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 00:40:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443627.698284 (Exim 4.92) (envelope-from ) id 1ouk00-0003hF-R4; Tue, 15 Nov 2022 00:40:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443627.698284; Tue, 15 Nov 2022 00:40:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouk00-0003h8-O4; Tue, 15 Nov 2022 00:40:24 +0000 Received: by outflank-mailman (input) for mailman id 443627; Tue, 15 Nov 2022 00:40:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oujzz-0003h2-Du for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 00:40:23 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20602.outbound.protection.outlook.com [2a01:111:f400:7e1a::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 160302f6-647e-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 01:40:21 +0100 (CET) Received: from AS9PR06CA0362.eurprd06.prod.outlook.com (2603:10a6:20b:460::9) by DU0PR08MB7616.eurprd08.prod.outlook.com (2603:10a6:10:320::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Tue, 15 Nov 2022 00:40:19 +0000 Received: from AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:460:cafe::63) by AS9PR06CA0362.outlook.office365.com (2603:10a6:20b:460::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Tue, 15 Nov 2022 00:40:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT063.mail.protection.outlook.com (100.127.140.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Tue, 15 Nov 2022 00:40:18 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Tue, 15 Nov 2022 00:40:18 +0000 Received: from 79486938ea55.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 409E8DED-83F9-491A-A0DD-4AFFBD6174C3.1; Tue, 15 Nov 2022 00:40:12 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 79486938ea55.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 15 Nov 2022 00:40:12 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS2PR08MB8746.eurprd08.prod.outlook.com (2603:10a6:20b:55e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.5; Tue, 15 Nov 2022 00:40:01 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5813.009; Tue, 15 Nov 2022 00:40:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 160302f6-647e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kRUI563PByKNgVZQ6hhawLkv/phd1ZRgk6nY6/LP/XY=; b=4MzdNHnLNnliw2zJVqgiY5bAS9It8vXCMF0aLiOdpCmFcHpjbDbfAysUeXJ+uTmI5A0K+pfYwxPe9LFaf4Shb3uepvv2EDuizh4t1U2Jt9UfYN/QvrpH5a5paAAbv5RGfnj0cUtQW6D9xWIykvHHcpG018UmHD0bsSKqv6xmJCo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HQMVOka6xAOF71D/ZProgiNNgK2OzYLA9ZUpN2AlOGPEt3Th2Zimk7wPkmIgl36vLWXjBSAnTKOzsc1S7WuOHnHbi3amWDpBDNaaL4O1jRc/C9oNlKgaai7PWBUekm9tuC4GlSi5t0cMDEb4WFRmT51mnmQzFWfjQfGP5Ora10OoISTYzxd2UbjrJEKf/HTavaVqYNrA6oGBqU6PQLXu0ruZ4Eq92jTMHjfV3vkX+IXF7PG8l82gpKvfuJtfIS99CnslyMl/yIgnerv1h3msv1fmh0fpqB7cAcmaff6tieCam+vddEOMlNL3dswX9R07x6bUxo/P5CthSdJHruWYXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kRUI563PByKNgVZQ6hhawLkv/phd1ZRgk6nY6/LP/XY=; b=Udk69qm1y9MRmTPT438SVKaubUpHJJwK+Wr//cVUO9S+SPhdc0y0Cr36FmcuvAoWxc0KUw7oZ9+nH6/EHbgJrcGfR0uHfhvmRyfvM5qgeIoUalfDiGq/hKd7epZkIUANGvuQxTlRrqTldElVmRNCxlrYA/EXawpdQMUUIOQENIAW7oc0GpwKJhfMFnlZWTRjQquqvEhXx/99K7BSTy0dLpMwbKgJ2IW4lvgFYkIEUag/oUfSnlCb8Ch7SyWokf7EEOO7+b2ahHxLjdUvhQjseEwqQf3bt3KU4zplTFdq5etRpBvMP0wOGziZ8O+kqlT5j7dY8JdbY2DNaHjSa4U0MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kRUI563PByKNgVZQ6hhawLkv/phd1ZRgk6nY6/LP/XY=; b=4MzdNHnLNnliw2zJVqgiY5bAS9It8vXCMF0aLiOdpCmFcHpjbDbfAysUeXJ+uTmI5A0K+pfYwxPe9LFaf4Shb3uepvv2EDuizh4t1U2Jt9UfYN/QvrpH5a5paAAbv5RGfnj0cUtQW6D9xWIykvHHcpG018UmHD0bsSKqv6xmJCo= From: Henry Wang To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= CC: "xen-devel@lists.xenproject.org" , Jan Beulich Subject: RE: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release Thread-Topic: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release Thread-Index: AQHY9cAA3X9w+pjMxES5dLMt0fkbDa45tnoAgAABRRCAAAr5gIAAALlwgAVmWrA= Date: Tue, 15 Nov 2022 00:40:01 +0000 Message-ID: References: <20221111112208.451449-1-Henry.Wang@arm.com> <20221111112208.451449-3-Henry.Wang@arm.com> <4482952f-86a9-d232-6cf5-afa6523012dc@suse.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 2A35FD2AD4EA734CAFD60567F69444E4.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS2PR08MB8746:EE_|AM7EUR03FT063:EE_|DU0PR08MB7616:EE_ X-MS-Office365-Filtering-Correlation-Id: ac035ea4-d95c-4648-fdb6-08dac6a1f86b x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2j7s6ukhH8r5WJhMSRst2lTrXQ97yqVQW3+PWgY2g0tfjUscSPa41bXtCElwXJENbsDL7VM9c6N6rZZfK4+A62iyEwJt75WDMfcC+qX+7UqcB5Pvp8yyf73SSiOyRdsJ103/t9jJeqkuIp6BN76KDanpOelVLA7+rXjwl5s5cnbCgvgANAedBxAdC1tl6t5nkb0x3n6pM2BwX/NBJxeykPK3iRuKS/TYRrCKsRDH0hfQMZ9Ny31WMMZerTByuah0VtgwViyfVQikqHVyADuSAuUZkDup0DvWbBIue4PXW7NCel0AAeZLzKDwOsHcACTwbu+6xTxPtVhyjiv/85MD40tn0A6odyGTT5EuzJn1uktjddw9YZThY3SGVhM2hpC4HAM4qPhYdTk+NL8cbY11Vn9bNeLKjO0PAypohKoXuxcgjPvwUuvun3jfbmwud5DuYwL2A6O7iqkA7XLMM/jhS24hfueMRQe/13n4ybqXf59spoqYP7isZJQKJWUyCeRLxsnv2Gnqu1J2g5gtme8bQJPEaQcDY9Q/DuWzO1dSsygQ9BsfGbPIAqbZ2w0OW0g4vhuMv5QrFUOhlrHWtiVdaWUZSNlSiNXB8f6k3WHCwLfhjnuoCz+ArkSnnr5Wxx4Q5qucjor4skNuMZ18MzO7pN3mM5nHcUGeOiIwaQxb6sTI5KtXl1K6A+Ek0H5M3XRTLX98CotSxXYqMiYrtnFJvtMbJaOum9oYinfqrJJ5GtzrikF4Ws7QiZtBH+BTCt8p4ZlPzGwgRMjca+NjDtydiIw/CWYQBc/HhNos37TGDFChyaJGNKMS0QR7dCEd/lSmoewhWAPH/7WkMU+MUrWvaA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(451199015)(2906002)(66946007)(33656002)(76116006)(66556008)(316002)(66476007)(52536014)(5660300002)(86362001)(83380400001)(54906003)(8936002)(41300700001)(66446008)(64756008)(8676002)(4326008)(53546011)(6506007)(7696005)(26005)(9686003)(38070700005)(55016003)(186003)(122000001)(71200400001)(38100700002)(478600001)(6916009)(59356011)(219803003)(207903002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8746 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c8449e9e-036e-4a3f-c1b6-08dac6a1ee5b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RZesr63/p0QvjpyJBz3frK6P1TFglogjrb/NU//OonelY9tjpyTCpIBQXLRBCvxfaa904JwBZGeuE23mS6KhnbwC8uPDhXj2C70z70CdAqgdfZ14+yx9th+iSMr6Q7C18Kfp0h0xS+C2jh78ZO04274jxH13rxwuy4b482pPBwR2BbVhCT31WFlPgQSWNGIYYxam7QAKjlzrEv4ElO7Zivv8Wr73oU2/0xUJexoV6WidZV9iA2wyev752QllMgn6nvGnhywEgAalgDP32S3SVSUG6czdHj4ED9Qt8sykxxkuvFF7ha2qHtu0yNlSqdLJLtocoIiYq8DQ6kx73SZfU12GK8mzXVZtV0j1rA7kVyeW54rXCQtdjeJ0MMxJR3o5KHUm3TblwlBvh7Ty9qaeG3a6qKb0DGoXNm+de8hsOuybC6P0L9a3QDwgzsn+UFuwmKLV+iY3IfRvRWgvCK6yDo6pJpUXUFty1fSYUIALrutNTfF38FSE0Da+HiVxK+rF8jUNZKptUT9MBbArrEqFW+azX93+htjQc5CnQY0L/ZV68r4C77KgcMx0CGuQhvzvSixJqe+FtHfGxmRWBZ1hweAual9n48LP0ofA3SIRkcqdLivE4IbhUU3iIL/rz+t3kf9GK6Grsbc1E9TQj8AJq1YtPhTYBMieTD4FJ5pNoN0cvsUuJgYan7V1IuKVgdGnNTJNwX+nipj3SFLas8O4YZhG/0igmonBCXMRomNi0xWpTLZFcVkt2Xv8eDlIUQd2r7+8m9dMoTtXsxA4HE+mEqh81F+ZuhuodVnpDhgR4D1ZNvFhQN+SQud8u/0Xw0t314YAKg/1NdgWeYNikl2S6pSKx3IWKwjPClrDVHS4BU0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199015)(46966006)(40470700004)(36840700001)(6862004)(2906002)(8936002)(52536014)(5660300002)(8676002)(4326008)(70206006)(41300700001)(107886003)(53546011)(26005)(40460700003)(7696005)(9686003)(186003)(6506007)(478600001)(336012)(316002)(54906003)(33656002)(70586007)(36860700001)(82310400005)(82740400003)(40480700001)(356005)(83380400001)(47076005)(55016003)(81166007)(86362001)(59356011)(219803003)(207903002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 00:40:18.5582 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ac035ea4-d95c-4648-fdb6-08dac6a1f86b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7616 SGkgUm9nZXIsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gU3ViamVjdDogUkU6 IFtQQVRDSCAyLzNdIENIQU5HRUxPRzogQWRkIG1pc3NpbmcgZW50cmllcyBmb3Igd29yayBkdXJp bmcNCj4gdGhlIDQuMTcgcmVsZWFzZQ0KPiANCj4gSGkgSmFuLA0KPiANCj4gPiAtLS0tLU9yaWdp bmFsIE1lc3NhZ2UtLS0tLQ0KPiA+IE9uIDExLjExLjIwMjIgMTQ6NTgsIEhlbnJ5IFdhbmcgd3Jv dGU6DQo+ID4gPiBBbm90aGVyIHF1ZXN0aW9uIGZvciBhZGRpbmcgYW5vdGhlciBlbnRyeSBmb3Ig eDg2IHRoYXQgd29ydGggdG8NCj4gPiA+IGJyYWcgYWJvdXQgYSBsaXR0bGUgYml0OiBJIGRpZCBh bm90aGVyIGRpZyBpbnRvIHBhdGNod29yayBhbmQgZm91bmQgdGhhdA0KPiA+ID4gdGhpcyBbMV0g bWlnaHQgYmUgYSBnb29kIGNhbmRpZGF0ZS4gSUlVQyBfX3JvX2FmdGVyX2luaXQgaXMgYSBnb29k DQo+ID4gPiBmZWF0dXJlIHRoYXQgYm90aCB4ODYgYW5kIEFybSBoYXZlIGxldmVyYWdlZCBpbiBk aWZmZXJlbnQgbGV2ZWwgdG9kYXksDQo+ID4gPiBzbyBwcm9iYWJseSB0aGUgX19yb19hZnRlcl9p bml0IG1pZ2h0IHdvcnRoIGFuIGVudHJ5IGluIENIQU5HRUxPRy4NCj4gPiA+DQo+ID4gPiBIb3dl dmVyIEkgc2F3IHlvdXIgY29tbWVudHMgaW4gWzFdIHNvIEkgYW0gbm90IHJlYWxseSBzdXJlIGlm IHlvdSBhcmUNCj4gPiA+IGhhcHB5IHdpdGggdGhhdCwgbWF5YmUgd2UgbmVlZCB0byBjaGFuZ2Ug dGhlIHdvcmRpbmcgYSBsaXR0bGUgYml0IHRvDQo+ID4gPiByZW1vdmUgeW91ciBjb25jZXJuPyBX b3VsZCB5b3UgbWluZCBzaGFyaW5nIHNvbWUgdGhvdWdodHM/DQo+ID4NCj4gPiBNeSB2aWV3IGhh c24ndCBjaGFuZ2VkLCBidXQgaWYgQW5kcmV3IGFuZCBSb2dlciB0aGluayB0aGlzIHNob3VsZCBi ZQ0KPiA+IG1lbnRpb25lZCwNCj4gPiB0aGVuIEknbSBub3QgZ29pbmcgdG8gc3RhbmQgaW4gdGhl IHdheS4NCj4gDQo+IFRoYW5rcyBmb3IgdGhlIGNvbmZpcm1hdGlvbi4gSSB3aWxsIHdhaXQgZm9y IFJvZ2VyJ3MgYmFjayBvbiBuZXh0IE1vbmRheQ0KPiB0aGVuLg0KDQpTb3JyeSBJIGZvcmdvdCB0 byBhZGQgeW91IHRvIHRoZSB0aHJlYWQgaW4gbGFzdCBlbWFpbCwgY291bGQgeW91IHBsZWFzZSBz aGFyZQ0KWW91ciBvcGluaW9uIGFib3V0IHRoaXMgb25lPyBUaGFua3MuDQoNCktpbmQgcmVnYXJk cywNCkhlbnJ5DQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 15 02:53:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 02:53:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443634.698295 (Exim 4.92) (envelope-from ) id 1oum4G-0008W6-0w; Tue, 15 Nov 2022 02:52:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443634.698295; Tue, 15 Nov 2022 02:52:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4F-0008Vz-Ta; Tue, 15 Nov 2022 02:52:55 +0000 Received: by outflank-mailman (input) for mailman id 443634; Tue, 15 Nov 2022 02:52:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4E-0008Vs-7U for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 02:52:54 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 982235b4-6490-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 03:52:51 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BEE8B11FB; Mon, 14 Nov 2022 18:52:56 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1ECA93F73B; Mon, 14 Nov 2022 18:52:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 982235b4-6490-11ed-8fd2-01056ac49cbb From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH V1 00/13 for 4.17-post] Follow-up static shared memory Date: Tue, 15 Nov 2022 10:52:22 +0800 Message-Id: <20221115025235.1378931-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are some unsolving issues on current 4.17 static shared memory feature[1], including: - In order to avoid keeping growing 'membank', having the shared memory regions in a separate array is preferred. And shared memory region should have its own structure which would contain a pointer/index to the 'membank'. - Missing implementation on having the host address optional in "xen,shared-mem" property - Missing "xen,offset" feature, which is introduced in Linux DOC[2] After fixing all above issues, we'd like to make 'UNSUPPORTED' static shared memory feature 'SUPPORTED'. [1] https://lore.kernel.org/all/20220908135513.1800511-1-Penny.Zheng@arm.com/ [2] https://www.kernel.org/doc/Documentation/devicetree/bindings/reserved-memory/xen%2Cshared-memory.txt Penny Zheng (13): xen/arm: re-arrange the static shared memory region xen/arm: switch to use shm_membank as function parameter xen/arm: introduce allocate_domheap_memory and guest_physmap_memory xen/arm: expand shm_membank for unprovided host address xen/arm: allocate shared memory from heap when host address not provided xen/arm: assign shared memory to owner when host address not provided xen/arm: map shared memory to borrower when host address not provided xen/arm: use paddr_assigned to indicate whether host address is provided xen/arm: refine docs about static shared memory xen/arm: introduce "xen,offset" feature xen/arm: implement "xen,offset" feature when host address provided xen/arm: implement "xen,offset" feature when host address not provided xen: make static shared memory supported in SUPPORT.md SUPPORT.md | 2 +- docs/misc/arm/device-tree/booting.txt | 67 ++- xen/arch/arm/Kconfig | 2 +- xen/arch/arm/bootfdt.c | 137 ++++-- xen/arch/arm/domain_build.c | 614 +++++++++++++++++++++----- xen/arch/arm/include/asm/kernel.h | 2 +- xen/arch/arm/include/asm/setup.h | 31 +- 7 files changed, 685 insertions(+), 170 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 02:53:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 02:53:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443636.698317 (Exim 4.92) (envelope-from ) id 1oum4J-0000aP-K4; Tue, 15 Nov 2022 02:52:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443636.698317; Tue, 15 Nov 2022 02:52:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4J-0000aI-Gp; Tue, 15 Nov 2022 02:52:59 +0000 Received: by outflank-mailman (input) for mailman id 443636; Tue, 15 Nov 2022 02:52:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4I-0008Vs-A3 for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 02:52:58 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9bc7c197-6490-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 03:52:57 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E92E411FB; Mon, 14 Nov 2022 18:53:02 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1700F3F73B; Mon, 14 Nov 2022 18:52:53 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bc7c197-6490-11ed-8fd2-01056ac49cbb From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v1 02/13] xen/arm: switch to use shm_membank as function parameter Date: Tue, 15 Nov 2022 10:52:24 +0800 Message-Id: <20221115025235.1378931-3-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115025235.1378931-1-Penny.Zheng@arm.com> References: <20221115025235.1378931-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using multiple function parameters to deliver various shm-related info, like host physical address, SHMID, etc, and with the introduction of new struct "shm_membank", we could switch to use "shm_membank" as function parameter to replace them all, to make codes more clear and tidy. Signed-off-by: Penny Zheng --- xen/arch/arm/domain_build.c | 46 ++++++++++++++++++------------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index c0fd13f6ed..d2b9e60b5c 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -751,40 +751,31 @@ static void __init assign_static_memory_11(struct domain *d, } #ifdef CONFIG_STATIC_SHM -static int __init acquire_nr_borrower_domain(struct domain *d, - paddr_t pbase, paddr_t psize, - unsigned long *nr_borrowers) +static struct shm_membank * __init acquire_shm_membank(const char *shm_id) { unsigned int bank; /* Iterate static shared memory to find requested shm bank. */ for ( bank = 0 ; bank < bootinfo.shm_mem.nr_banks; bank++ ) - { - paddr_t bank_start = bootinfo.shm_mem.bank[bank].membank->start; - paddr_t bank_size = bootinfo.shm_mem.bank[bank].membank->size; - - if ( (pbase == bank_start) && (psize == bank_size) ) + if ( strcmp(shm_id, bootinfo.shm_mem.bank[bank].shm_id) == 0 ) break; - } if ( bank == bootinfo.shm_mem.nr_banks ) - return -ENOENT; - - *nr_borrowers = bootinfo.shm_mem.bank[bank].nr_shm_borrowers; + return NULL; - return 0; + return &bootinfo.shm_mem.bank[bank]; } /* * This function checks whether the static shared memory region is * already allocated to dom_io. */ -static bool __init is_shm_allocated_to_domio(paddr_t pbase) +static bool __init is_shm_allocated_to_domio(struct shm_membank *shm_membank) { struct page_info *page; struct domain *d; - page = maddr_to_page(pbase); + page = maddr_to_page(shm_membank->membank->start); d = page_get_owner_and_reference(page); if ( d == NULL ) return false; @@ -835,14 +826,17 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, } static int __init assign_shared_memory(struct domain *d, - uint32_t addr_cells, uint32_t size_cells, - paddr_t pbase, paddr_t psize, + struct shm_membank *shm_membank, paddr_t gbase) { mfn_t smfn; int ret = 0; unsigned long nr_pages, nr_borrowers, i; struct page_info *page; + paddr_t pbase, psize; + + pbase = shm_membank->membank->start; + psize = shm_membank->membank->size; printk("%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", d, pbase, pbase + psize); @@ -871,9 +865,7 @@ static int __init assign_shared_memory(struct domain *d, * Get the right amount of references per page, which is the number of * borrower domains. */ - ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); - if ( ret ) - return ret; + nr_borrowers = shm_membank->nr_shm_borrowers; /* * Instead of letting borrower domain get a page ref, we add as many @@ -941,6 +933,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, const char *role_str; const char *shm_id; bool owner_dom_io = true; + struct shm_membank *shm_membank; if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) continue; @@ -991,12 +984,20 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, } BUG_ON((strlen(shm_id) <= 0) || (strlen(shm_id) >= MAX_SHM_ID_LENGTH)); + shm_membank = acquire_shm_membank(shm_id); + if ( !shm_membank ) + { + printk("%pd: failed to acquire %s shared memory bank\n", + d, shm_id); + return -ENOENT; + } + /* * DOMID_IO is a fake domain and is not described in the Device-Tree. * Therefore when the owner of the shared region is DOMID_IO, we will * only find the borrowers. */ - if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || + if ( (owner_dom_io && !is_shm_allocated_to_domio(shm_membank)) || (!owner_dom_io && strcmp(role_str, "owner") == 0) ) { /* @@ -1004,8 +1005,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, * specified, so they should be assigned to dom_io. */ ret = assign_shared_memory(owner_dom_io ? dom_io : d, - addr_cells, size_cells, - pbase, psize, gbase); + shm_membank, gbase); if ( ret ) return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 02:53:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 02:53:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443637.698327 (Exim 4.92) (envelope-from ) id 1oum4M-0000se-Rs; Tue, 15 Nov 2022 02:53:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443637.698327; Tue, 15 Nov 2022 02:53:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4M-0000sV-Oi; Tue, 15 Nov 2022 02:53:02 +0000 Received: by outflank-mailman (input) for mailman id 443637; Tue, 15 Nov 2022 02:53:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4L-0000BJ-F9 for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 02:53:01 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 9da6ccbd-6490-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 03:53:00 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F65211FB; Mon, 14 Nov 2022 18:53:06 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2E60E3F73B; Mon, 14 Nov 2022 18:52:56 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9da6ccbd-6490-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v1 03/13] xen/arm: introduce allocate_domheap_memory and guest_physmap_memory Date: Tue, 15 Nov 2022 10:52:25 +0800 Message-Id: <20221115025235.1378931-4-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115025235.1378931-1-Penny.Zheng@arm.com> References: <20221115025235.1378931-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We split the codes of allocate_bank_memory into two parts, allocate_domheap_memory and guest_physmap_memory. One is about allocating guest RAM from heap, which could be re-used later for allocating static shared memory from heap when host address is not provided. The other is building up guest P2M mapping. Signed-off-by: Penny Zheng --- xen/arch/arm/domain_build.c | 93 +++++++++++++++++++++++++++---------- 1 file changed, 68 insertions(+), 25 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index d2b9e60b5c..92763e96fc 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -390,34 +390,18 @@ static void __init allocate_memory_11(struct domain *d, } } -static bool __init allocate_bank_memory(struct domain *d, - struct kernel_info *kinfo, - gfn_t sgfn, - paddr_t tot_size) +static bool __init allocate_domheap_memory(struct domain *d, + paddr_t tot_size, + struct meminfo *mem) { - int res; struct page_info *pg; - struct membank *bank; unsigned int max_order = ~0; - /* - * allocate_bank_memory can be called with a tot_size of zero for - * the second memory bank. It is not an error and we can safely - * avoid creating a zero-size memory bank. - */ - if ( tot_size == 0 ) - return true; - - bank = &kinfo->mem.bank[kinfo->mem.nr_banks]; - bank->start = gfn_to_gaddr(sgfn); - bank->size = tot_size; - while ( tot_size > 0 ) { unsigned int order = get_allocation_size(tot_size); order = min(max_order, order); - pg = alloc_domheap_pages(d, order, 0); if ( !pg ) { @@ -437,15 +421,74 @@ static bool __init allocate_bank_memory(struct domain *d, continue; } - res = guest_physmap_add_page(d, sgfn, page_to_mfn(pg), order); - if ( res ) - { - dprintk(XENLOG_ERR, "Failed map pages to DOMU: %d", res); + if ( mem->nr_banks == NR_MEM_BANKS ) return false; - } + + mem->bank[mem->nr_banks].start = mfn_to_maddr(page_to_mfn(pg)); + mem->bank[mem->nr_banks].size = 1UL << (PAGE_SHIFT + order); + mem->nr_banks++; + tot_size -= (1UL << (PAGE_SHIFT + order)); + } + + return true; +} + +static int __init guest_physmap_memory(struct domain *d, + const struct meminfo *mem, gfn_t sgfn) +{ + unsigned int i; + int res; + + for ( i = 0; i < mem->nr_banks; i++ ) + { + paddr_t size = mem->bank[i].size; + unsigned int order = get_order_from_bytes(size); + + /* Size must be power of two */ + BUG_ON(!size || (size & (size - 1))); + res = guest_physmap_add_page(d, sgfn, maddr_to_mfn(mem->bank[i].start), + order); + if ( res ) + return res; sgfn = gfn_add(sgfn, 1UL << order); - tot_size -= (1ULL << (PAGE_SHIFT + order)); + } + + return 0; +} + +static bool __init allocate_bank_memory(struct domain *d, + struct kernel_info *kinfo, + gfn_t sgfn, + paddr_t total_size) +{ + struct membank *bank; + struct meminfo host = {0}; + + /* + * allocate_bank_memory can be called with a total_size of zero for + * the second memory bank. It is not an error and we can safely + * avoid creating a zero-size memory bank. + */ + if ( total_size == 0 ) + return true; + + bank = &kinfo->mem.bank[kinfo->mem.nr_banks]; + bank->start = gfn_to_gaddr(sgfn); + bank->size = total_size; + + if ( !allocate_domheap_memory(d, total_size, &host) ) + { + printk(XENLOG_ERR "Failed to allocate (%"PRIpaddr"MB) pages to %pd\n", + total_size >> 20, d); + return false; + } + + if ( guest_physmap_memory(d, &host, sgfn) ) + { + printk(XENLOG_ERR "Failed to map (%"PRIpaddr"MB) pages to %pd\n", + total_size >> 20, d); + return false; } kinfo->mem.nr_banks++; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 02:53:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 02:53:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443638.698339 (Exim 4.92) (envelope-from ) id 1oum4Q-0001CE-3q; Tue, 15 Nov 2022 02:53:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443638.698339; Tue, 15 Nov 2022 02:53:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4Q-0001C3-0W; Tue, 15 Nov 2022 02:53:06 +0000 Received: by outflank-mailman (input) for mailman id 443638; Tue, 15 Nov 2022 02:53:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4O-0008Vs-GT for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 02:53:04 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9f775f60-6490-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 03:53:03 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2473F11FB; Mon, 14 Nov 2022 18:53:09 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 460DE3F73B; Mon, 14 Nov 2022 18:53:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f775f60-6490-11ed-8fd2-01056ac49cbb From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v1 04/13] xen/arm: expand shm_membank for unprovided host address Date: Tue, 15 Nov 2022 10:52:26 +0800 Message-Id: <20221115025235.1378931-5-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115025235.1378931-1-Penny.Zheng@arm.com> References: <20221115025235.1378931-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When host address is not provided in "xen,shared-mem", we let Xen automatically allocate requested static shared memory from heap, and it stands good chance of having multiple host memory banks allocated for the requested static shared memory as a result. Therefore current membank is not going to cover it. This commit introduces a new field "mem" to cover both scenarios. "struct membank" is used when host address is provided, whereas "struct meminfo" shall be used when host address not provided. Signed-off-by: Penny Zheng --- xen/arch/arm/bootfdt.c | 6 +++--- xen/arch/arm/domain_build.c | 16 ++++++++-------- xen/arch/arm/include/asm/setup.h | 17 ++++++++++++++++- 3 files changed, 27 insertions(+), 12 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index ccf281cd37..2f34a8ea83 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -458,8 +458,8 @@ static int __init process_shm_node(const void *fdt, int node, for ( i = 0; i < shm_mem->nr_banks; i++ ) { - paddr_t bank_start = shm_mem->bank[i].membank->start; - paddr_t bank_size = shm_mem->bank[i].membank->size; + paddr_t bank_start = shm_mem->bank[i].mem.bank->start; + paddr_t bank_size = shm_mem->bank[i].mem.bank->size; /* * Meet the following check: @@ -523,7 +523,7 @@ static int __init process_shm_node(const void *fdt, int node, mem->nr_banks++; safe_strcpy(shm_mem->bank[i].shm_id, shm_id); - shm_mem->bank[i].membank = membank; + shm_mem->bank[i].mem.bank = membank; shm_mem->nr_banks++; } else diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 92763e96fc..fbb196d8a4 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -818,7 +818,7 @@ static bool __init is_shm_allocated_to_domio(struct shm_membank *shm_membank) struct page_info *page; struct domain *d; - page = maddr_to_page(shm_membank->membank->start); + page = maddr_to_page(shm_membank->mem.bank->start); d = page_get_owner_and_reference(page); if ( d == NULL ) return false; @@ -878,8 +878,8 @@ static int __init assign_shared_memory(struct domain *d, struct page_info *page; paddr_t pbase, psize; - pbase = shm_membank->membank->start; - psize = shm_membank->membank->size; + pbase = shm_membank->mem.bank->start; + psize = shm_membank->mem.bank->size; printk("%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", d, pbase, pbase + psize); @@ -951,9 +951,9 @@ static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, if ( membank == NULL ) return -ENOMEM; - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].membank = membank; - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].membank->start = start; - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].membank->size = size; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].mem.bank = membank; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].mem.bank->start = start; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].mem.bank->size = size; safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, shm_id); kinfo->shm_mem.nr_banks++; @@ -1422,8 +1422,8 @@ static int __init make_shm_memory_node(const struct domain *d, for ( ; i < mem->nr_banks; i++ ) { - uint64_t start = mem->bank[i].membank->start; - uint64_t size = mem->bank[i].membank->size; + uint64_t start = mem->bank[i].mem.bank->start; + uint64_t size = mem->bank[i].mem.bank->size; /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ char buf[27]; const char compat[] = "xen,shared-memory-v1"; diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 2d4ae0f00a..c54ffc8a5b 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -60,7 +60,22 @@ struct meminfo { struct shm_membank { char shm_id[MAX_SHM_ID_LENGTH]; unsigned int nr_shm_borrowers; - struct membank *membank; + struct { + /* + * When host address is provided in "xen,shared-mem", then only one + * consistent host memory bank is behind each shared memory node. + */ + struct membank *bank; + struct { + /* + * When host address is not provided in "xen,shared-mem", then + * we let Xen allocate requested memory from heap, and a shared + * memory bank could be consisted of multiple host memory banks. + */ + struct meminfo *meminfo; + unsigned long total_size; + } banks; + } mem; }; struct shm_meminfo { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 02:53:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 02:53:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443635.698306 (Exim 4.92) (envelope-from ) id 1oum4I-0000Km-8P; Tue, 15 Nov 2022 02:52:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443635.698306; Tue, 15 Nov 2022 02:52:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4I-0000Kf-4I; Tue, 15 Nov 2022 02:52:58 +0000 Received: by outflank-mailman (input) for mailman id 443635; Tue, 15 Nov 2022 02:52:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4G-0000BJ-RK for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 02:52:56 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 99feff1e-6490-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 03:52:55 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D1B9913D5; Mon, 14 Nov 2022 18:52:59 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id F37B13F73B; Mon, 14 Nov 2022 18:52:50 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99feff1e-6490-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v1 01/13] xen/arm: re-arrange the static shared memory region Date: Tue, 15 Nov 2022 10:52:23 +0800 Message-Id: <20221115025235.1378931-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115025235.1378931-1-Penny.Zheng@arm.com> References: <20221115025235.1378931-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit re-arranges the static shared memory regions into a separate array shm_meminfo. And static shared memory region now would have its own structure 'shm_membank' to hold all shm-related members, like shm_id, etc, and a pointer to the normal memory bank 'membank'. This will avoid continuing to grow 'membank'. Signed-off-by: Penny Zheng --- xen/arch/arm/bootfdt.c | 40 +++++++++++++++++++------------ xen/arch/arm/domain_build.c | 35 ++++++++++++++++----------- xen/arch/arm/include/asm/kernel.h | 2 +- xen/arch/arm/include/asm/setup.h | 16 +++++++++---- 4 files changed, 59 insertions(+), 34 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 6014c0f852..ccf281cd37 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -384,6 +384,7 @@ static int __init process_shm_node(const void *fdt, int node, const __be32 *cell; paddr_t paddr, gaddr, size; struct meminfo *mem = &bootinfo.reserved_mem; + struct shm_meminfo *shm_mem = &bootinfo.shm_mem; unsigned int i; int len; bool owner = false; @@ -455,17 +456,21 @@ static int __init process_shm_node(const void *fdt, int node, return -EINVAL; } - for ( i = 0; i < mem->nr_banks; i++ ) + for ( i = 0; i < shm_mem->nr_banks; i++ ) { + paddr_t bank_start = shm_mem->bank[i].membank->start; + paddr_t bank_size = shm_mem->bank[i].membank->size; + /* * Meet the following check: * 1) The shm ID matches and the region exactly match * 2) The shm ID doesn't match and the region doesn't overlap * with an existing one */ - if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) + if ( paddr == bank_start && size == bank_size ) { - if ( strncmp(shm_id, mem->bank[i].shm_id, MAX_SHM_ID_LENGTH) == 0 ) + if ( strncmp(shm_id, + shm_mem->bank[i].shm_id, MAX_SHM_ID_LENGTH) == 0 ) break; else { @@ -477,17 +482,17 @@ static int __init process_shm_node(const void *fdt, int node, else { paddr_t end = paddr + size; - paddr_t bank_end = mem->bank[i].start + mem->bank[i].size; + paddr_t bank_end = bank_start + bank_size; - if ( (end <= paddr) || (bank_end <= mem->bank[i].start) ) + if ( (end <= paddr) || (bank_end <= bank_start) ) { printk("fdt: static shared memory region %s overflow\n", shm_id); return -EINVAL; } - if ( (end <= mem->bank[i].start) || (paddr >= bank_end) ) + if ( (end <= bank_start) || (paddr >= bank_end) ) { - if ( strcmp(shm_id, mem->bank[i].shm_id) != 0 ) + if ( strcmp(shm_id, shm_mem->bank[i].shm_id) != 0 ) continue; else { @@ -499,22 +504,27 @@ static int __init process_shm_node(const void *fdt, int node, else { printk("fdt: shared memory region overlap with an existing entry %#"PRIpaddr" - %#"PRIpaddr"\n", - mem->bank[i].start, bank_end); + bank_start, bank_end); return -EINVAL; } } } - if ( i == mem->nr_banks ) + if ( i == shm_mem->nr_banks ) { - if ( i < NR_MEM_BANKS ) + if ( (i < NR_MEM_BANKS) && (mem->nr_banks < NR_MEM_BANKS) ) { /* Static shared memory shall be reserved from any other use. */ - safe_strcpy(mem->bank[mem->nr_banks].shm_id, shm_id); - mem->bank[mem->nr_banks].start = paddr; - mem->bank[mem->nr_banks].size = size; - mem->bank[mem->nr_banks].type = MEMBANK_STATIC_DOMAIN; + struct membank *membank = &mem->bank[mem->nr_banks]; + + membank->start = paddr; + membank->size = size; + membank->type = MEMBANK_STATIC_DOMAIN; mem->nr_banks++; + + safe_strcpy(shm_mem->bank[i].shm_id, shm_id); + shm_mem->bank[i].membank = membank; + shm_mem->nr_banks++; } else { @@ -527,7 +537,7 @@ static int __init process_shm_node(const void *fdt, int node, * to calculate the reference count. */ if ( !owner ) - mem->bank[i].nr_shm_borrowers++; + shm_mem->bank[i].nr_shm_borrowers++; return 0; } diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index bd30d3798c..c0fd13f6ed 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -757,20 +757,20 @@ static int __init acquire_nr_borrower_domain(struct domain *d, { unsigned int bank; - /* Iterate reserved memory to find requested shm bank. */ - for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + /* Iterate static shared memory to find requested shm bank. */ + for ( bank = 0 ; bank < bootinfo.shm_mem.nr_banks; bank++ ) { - paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; - paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; + paddr_t bank_start = bootinfo.shm_mem.bank[bank].membank->start; + paddr_t bank_size = bootinfo.shm_mem.bank[bank].membank->size; if ( (pbase == bank_start) && (psize == bank_size) ) break; } - if ( bank == bootinfo.reserved_mem.nr_banks ) + if ( bank == bootinfo.shm_mem.nr_banks ) return -ENOENT; - *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_borrowers; + *nr_borrowers = bootinfo.shm_mem.bank[bank].nr_shm_borrowers; return 0; } @@ -907,11 +907,18 @@ static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, paddr_t start, paddr_t size, const char *shm_id) { + struct membank *membank; + if ( kinfo->shm_mem.nr_banks >= NR_MEM_BANKS ) return -ENOMEM; - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; + membank = xmalloc_bytes(sizeof(struct membank)); + if ( membank == NULL ) + return -ENOMEM; + + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].membank = membank; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].membank->start = start; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].membank->size = size; safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, shm_id); kinfo->shm_mem.nr_banks++; @@ -1355,7 +1362,7 @@ static int __init make_memory_node(const struct domain *d, static int __init make_shm_memory_node(const struct domain *d, void *fdt, int addrcells, int sizecells, - const struct meminfo *mem) + const struct shm_meminfo *mem) { unsigned int i = 0; int res = 0; @@ -1372,8 +1379,8 @@ static int __init make_shm_memory_node(const struct domain *d, for ( ; i < mem->nr_banks; i++ ) { - uint64_t start = mem->bank[i].start; - uint64_t size = mem->bank[i].size; + uint64_t start = mem->bank[i].membank->start; + uint64_t size = mem->bank[i].membank->size; /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ char buf[27]; const char compat[] = "xen,shared-memory-v1"; @@ -1382,7 +1389,7 @@ static int __init make_shm_memory_node(const struct domain *d, __be32 *cells; unsigned int len = (addrcells + sizecells) * sizeof(__be32); - snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, mem->bank[i].start); + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, start); res = fdt_begin_node(fdt, buf); if ( res ) return res; @@ -1426,7 +1433,7 @@ static int __init make_shm_memory_node(const struct domain *d, static int __init make_shm_memory_node(const struct domain *d, void *fdt, int addrcells, int sizecells, - const struct meminfo *mem) + const struct shm_meminfo *mem) { ASSERT_UNREACHABLE(); return -EOPNOTSUPP; @@ -1436,7 +1443,7 @@ static int __init make_shm_memory_node(const struct domain *d, static int __init make_resv_memory_node(const struct domain *d, void *fdt, int addrcells, int sizecells, - const struct meminfo *mem) + const struct shm_meminfo *mem) { int res = 0; /* Placeholder for reserved-memory\0 */ diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h index 5bb30c3f2f..f47ba9d619 100644 --- a/xen/arch/arm/include/asm/kernel.h +++ b/xen/arch/arm/include/asm/kernel.h @@ -38,7 +38,7 @@ struct kernel_info { void *fdt; /* flat device tree */ paddr_t unassigned_mem; /* RAM not (yet) assigned to a bank */ struct meminfo mem; - struct meminfo shm_mem; + struct shm_meminfo shm_mem; /* kernel entry point */ paddr_t entry; diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index fdbf68aadc..2d4ae0f00a 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -50,10 +50,6 @@ struct membank { paddr_t start; paddr_t size; enum membank_type type; -#ifdef CONFIG_STATIC_SHM - char shm_id[MAX_SHM_ID_LENGTH]; - unsigned int nr_shm_borrowers; -#endif }; struct meminfo { @@ -61,6 +57,17 @@ struct meminfo { struct membank bank[NR_MEM_BANKS]; }; +struct shm_membank { + char shm_id[MAX_SHM_ID_LENGTH]; + unsigned int nr_shm_borrowers; + struct membank *membank; +}; + +struct shm_meminfo { + unsigned int nr_banks; + struct shm_membank bank[NR_MEM_BANKS]; +}; + /* * The domU flag is set for kernels and ramdisks of "xen,domain" nodes. * The purpose of the domU flag is to avoid getting confused in @@ -105,6 +112,7 @@ struct bootinfo { struct meminfo acpi; #endif bool static_heap; + struct shm_meminfo shm_mem; }; struct map_range_data -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 02:53:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 02:53:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443639.698350 (Exim 4.92) (envelope-from ) id 1oum4S-0001WB-FT; Tue, 15 Nov 2022 02:53:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443639.698350; Tue, 15 Nov 2022 02:53:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4S-0001Vm-B3; Tue, 15 Nov 2022 02:53:08 +0000 Received: by outflank-mailman (input) for mailman id 443639; Tue, 15 Nov 2022 02:53:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4R-0008Vs-Mu for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 02:53:07 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a15477b6-6490-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 03:53:06 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3B75611FB; Mon, 14 Nov 2022 18:53:12 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5DBA03F73B; Mon, 14 Nov 2022 18:53:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a15477b6-6490-11ed-8fd2-01056ac49cbb From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v1 05/13] xen/arm: allocate shared memory from heap when host address not provided Date: Tue, 15 Nov 2022 10:52:27 +0800 Message-Id: <20221115025235.1378931-6-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115025235.1378931-1-Penny.Zheng@arm.com> References: <20221115025235.1378931-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit when host address is not provided in "xen,shared-mem", we let Xen allocate requested shared memory from heap, and once the shared memory is allocated, it will be marked as static(PGC_static), which means that it will be reserved as static memory, and will not go back to heap even on freeing. Signed-off-by: Penny Zheng --- xen/arch/arm/domain_build.c | 83 ++++++++++++++++++++++++++++++++++++- 1 file changed, 82 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index fbb196d8a4..3de96882a5 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -835,6 +835,72 @@ static bool __init is_shm_allocated_to_domio(struct shm_membank *shm_membank) return true; } +static int __init mark_shared_memory_static(struct shm_membank *shm_membank) +{ + unsigned int bank; + unsigned long i, nr_mfns; + struct page_info *pg; + struct meminfo *meminfo; + + BUG_ON(!shm_membank->mem.banks.meminfo); + meminfo = shm_membank->mem.banks.meminfo; + for ( bank = 0; bank < meminfo->nr_banks; bank++ ) + { + pg = mfn_to_page(maddr_to_mfn(meminfo->bank[bank].start)); + nr_mfns = PFN_DOWN(meminfo->bank[bank].size); + + for ( i = 0; i < nr_mfns; i++ ) + { + /* The page should be already allocated from heap. */ + if ( !pg[i].count_info & PGC_state_inuse ) + { + printk(XENLOG_ERR + "pg[%lu] MFN %"PRI_mfn" c=%#lx\n", + i, mfn_x(page_to_mfn(pg)) + i, pg[i].count_info); + goto fail; + } + + pg[i].count_info |= PGC_static; + } + } + + return 0; + + fail: + while ( bank >= 0 ) + { + while ( --i >= 0 ) + pg[i].count_info &= ~PGC_static; + i = PFN_DOWN(meminfo->bank[--bank].size); + } + + return -EINVAL; +} + +static int __init allocate_shared_memory(struct shm_membank *shm_membank, + paddr_t psize) +{ + struct meminfo *banks; + int ret; + + BUG_ON(shm_membank->mem.banks.meminfo != NULL); + + banks = xmalloc_bytes(sizeof(struct meminfo)); + if ( banks == NULL ) + return -ENOMEM; + shm_membank->mem.banks.meminfo = banks; + memset(shm_membank->mem.banks.meminfo, 0, sizeof(struct meminfo)); + + if ( !allocate_domheap_memory(NULL, psize, shm_membank->mem.banks.meminfo) ) + return -EINVAL; + + ret = mark_shared_memory_static(shm_membank); + if ( ret ) + return ret; + + return 0; +} + static mfn_t __init acquire_shared_memory_bank(struct domain *d, paddr_t pbase, paddr_t psize) { @@ -975,7 +1041,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, unsigned int i; const char *role_str; const char *shm_id; - bool owner_dom_io = true; + bool owner_dom_io = true, paddr_assigned = true; struct shm_membank *shm_membank; if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) @@ -1035,6 +1101,21 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, return -ENOENT; } + /* + * When host address is not provided in "xen,shared-mem", + * we let Xen allocate requested memory from heap at first domain. + */ + if ( !paddr_assigned && !shm_membank->mem.banks.meminfo ) + { + ret = allocate_shared_memory(shm_membank, psize); + if ( ret ) + { + printk("%pd: failed to allocate shared memory bank(%"PRIpaddr"MB) from heap: %d\n", + d, psize >> 20, ret); + return ret; + } + } + /* * DOMID_IO is a fake domain and is not described in the Device-Tree. * Therefore when the owner of the shared region is DOMID_IO, we will -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 02:53:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 02:53:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443640.698361 (Exim 4.92) (envelope-from ) id 1oum4V-0001tq-OQ; Tue, 15 Nov 2022 02:53:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443640.698361; Tue, 15 Nov 2022 02:53:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4V-0001te-Kp; Tue, 15 Nov 2022 02:53:11 +0000 Received: by outflank-mailman (input) for mailman id 443640; Tue, 15 Nov 2022 02:53:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4U-0000BJ-PQ for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 02:53:10 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a323f596-6490-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 03:53:09 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5309D11FB; Mon, 14 Nov 2022 18:53:15 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 74C063F73B; Mon, 14 Nov 2022 18:53:06 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a323f596-6490-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v1 06/13] xen/arm: assign shared memory to owner when host address not provided Date: Tue, 15 Nov 2022 10:52:28 +0800 Message-Id: <20221115025235.1378931-7-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115025235.1378931-1-Penny.Zheng@arm.com> References: <20221115025235.1378931-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With the introduction of new scenario where host address is not provided in "xen,shared-mem", the function "assign_shared_memory" shall be adapted to it too. Shared memory will already be allocated from heap, when calling "assign_shared_memory" with unprovided host address. So in "assign_shared_memory", we just need to assign these static shared pages to its owner domain using function "assign_pages", and add as many additional reference as the number of borrowers. Signed-off-by: Penny Zheng --- xen/arch/arm/domain_build.c | 160 ++++++++++++++++++++++++++++++------ 1 file changed, 133 insertions(+), 27 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3de96882a5..faf0784bb0 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -817,8 +817,12 @@ static bool __init is_shm_allocated_to_domio(struct shm_membank *shm_membank) { struct page_info *page; struct domain *d; + paddr_t pbase; - page = maddr_to_page(shm_membank->mem.bank->start); + pbase = shm_membank->mem.banks.meminfo ? + shm_membank->mem.banks.meminfo->bank[0].start : + shm_membank->mem.bank->start; + page = maddr_to_page(pbase); d = page_get_owner_and_reference(page); if ( d == NULL ) return false; @@ -907,6 +911,7 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, mfn_t smfn; unsigned long nr_pfns; int res; + struct page_info *page; /* * Pages of statically shared memory shall be included @@ -922,33 +927,82 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, d->max_pages += nr_pfns; smfn = maddr_to_mfn(pbase); - res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); - if ( res ) + page = mfn_to_page(smfn); + /* + * If page is allocated from heap as static shared memory, then we just + * assign it to the owner domain + */ + if ( page->count_info == (PGC_state_inuse | PGC_static) ) { - printk(XENLOG_ERR - "%pd: failed to acquire static memory: %d.\n", d, res); - d->max_pages -= nr_pfns; - return INVALID_MFN; + res = assign_pages(page, nr_pfns, d, 0); + if ( res ) + { + printk(XENLOG_ERR + "%pd: failed to assign static memory: %d.\n", d, res); + return INVALID_MFN; + } + } + else + { + res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); + if ( res ) + { + printk(XENLOG_ERR + "%pd: failed to acquire static memory: %d.\n", d, res); + d->max_pages -= nr_pfns; + return INVALID_MFN; + } } return smfn; } -static int __init assign_shared_memory(struct domain *d, - struct shm_membank *shm_membank, - paddr_t gbase) +static void __init remove_shared_memory_ref(struct page_info *page, + unsigned long nr_pages, + unsigned long nr_borrowers) { - mfn_t smfn; - int ret = 0; - unsigned long nr_pages, nr_borrowers, i; - struct page_info *page; - paddr_t pbase, psize; + while ( --nr_pages >= 0 ) + put_page_nr(page + nr_pages, nr_borrowers); +} - pbase = shm_membank->mem.bank->start; - psize = shm_membank->mem.bank->size; +static int __init add_shared_memory_ref(struct domain *d, struct page_info *page, + unsigned long nr_pages, + unsigned long nr_borrowers) +{ + unsigned int i; - printk("%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", - d, pbase, pbase + psize); + /* + * Instead of letting borrower domain get a page ref, we add as many + * additional reference as the number of borrowers when the owner + * is allocated, since there is a chance that owner is created + * after borrower. + * So if the borrower is created first, it will cause adding pages + * in the P2M without reference. + */ + for ( i = 0; i < nr_pages; i++ ) + { + if ( !get_page_nr(page + i, d, nr_borrowers) ) + { + printk(XENLOG_ERR + "Failed to add %lu references to page %"PRI_mfn".\n", + nr_borrowers, mfn_x(page_to_mfn(page)) + i); + goto fail; + } + } + return 0; + + fail: + remove_shared_memory_ref(page, i, nr_borrowers); + return -EINVAL; +} + +static int __init acquire_shared_memory(struct domain *d, + paddr_t pbase, paddr_t psize, + paddr_t gbase) +{ + mfn_t smfn; + int ret = 0; + unsigned long nr_pages; smfn = acquire_shared_memory_bank(d, pbase, psize); if ( mfn_eq(smfn, INVALID_MFN) ) @@ -970,6 +1024,44 @@ static int __init assign_shared_memory(struct domain *d, } } + return 0; +} + +static int __init assign_shared_memory(struct domain *d, + struct shm_membank *shm_membank, + paddr_t gbase) +{ + int ret = 0; + unsigned long nr_pages, nr_borrowers; + struct page_info *page; + unsigned int i; + struct meminfo *meminfo; + + /* Host address is not provided in "xen,shared-mem" */ + if ( shm_membank->mem.banks.meminfo ) + { + meminfo = shm_membank->mem.banks.meminfo; + for ( i = 0; i < meminfo->nr_banks; i++ ) + { + ret = acquire_shared_memory(d, + meminfo->bank[i].start, + meminfo->bank[i].size, + gbase); + if ( ret ) + return ret; + + gbase += meminfo->bank[i].size; + } + } + else + { + ret = acquire_shared_memory(d, + shm_membank->mem.bank->start, + shm_membank->mem.bank->size, gbase); + if ( ret ) + return ret; + } + /* * Get the right amount of references per page, which is the number of * borrower domains. @@ -984,23 +1076,37 @@ static int __init assign_shared_memory(struct domain *d, * So if the borrower is created first, it will cause adding pages * in the P2M without reference. */ - page = mfn_to_page(smfn); - for ( i = 0; i < nr_pages; i++ ) + if ( shm_membank->mem.banks.meminfo ) { - if ( !get_page_nr(page + i, d, nr_borrowers) ) + meminfo = shm_membank->mem.banks.meminfo; + for ( i = 0; i < meminfo->nr_banks; i++ ) { - printk(XENLOG_ERR - "Failed to add %lu references to page %"PRI_mfn".\n", - nr_borrowers, mfn_x(smfn) + i); - goto fail; + page = mfn_to_page(maddr_to_mfn(meminfo->bank[i].start)); + nr_pages = PFN_DOWN(meminfo->bank[i].size); + ret = add_shared_memory_ref(d, page, nr_pages, nr_borrowers); + if ( ret ) + goto fail; } } + else + { + page = mfn_to_page( + maddr_to_mfn(shm_membank->mem.bank->start)); + nr_pages = shm_membank->mem.bank->size >> PAGE_SHIFT; + ret = add_shared_memory_ref(d, page, nr_pages, nr_borrowers); + if ( ret ) + return ret; + } return 0; fail: while ( --i >= 0 ) - put_page_nr(page + i, nr_borrowers); + { + page = mfn_to_page(maddr_to_mfn(meminfo->bank[i].start)); + nr_pages = PFN_DOWN(meminfo->bank[i].size); + remove_shared_memory_ref(page, nr_pages, nr_borrowers); + } return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 02:53:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 02:53:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443642.698372 (Exim 4.92) (envelope-from ) id 1oum4Z-0002Q4-9I; Tue, 15 Nov 2022 02:53:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443642.698372; Tue, 15 Nov 2022 02:53:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4Z-0002Pl-4T; Tue, 15 Nov 2022 02:53:15 +0000 Received: by outflank-mailman (input) for mailman id 443642; Tue, 15 Nov 2022 02:53:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4X-0008Vs-QU for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 02:53:13 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a509e63a-6490-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 03:53:12 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 69FF711FB; Mon, 14 Nov 2022 18:53:18 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8C2373F73B; Mon, 14 Nov 2022 18:53:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a509e63a-6490-11ed-8fd2-01056ac49cbb From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v1 07/13] xen/arm: map shared memory to borrower when host address not provided Date: Tue, 15 Nov 2022 10:52:29 +0800 Message-Id: <20221115025235.1378931-8-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115025235.1378931-1-Penny.Zheng@arm.com> References: <20221115025235.1378931-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With the introduction of new scenario where host address is not provided in "xen,shared-mem", the function "map_regions_p2mt" for setting up P2M foreign mapping for borrower domain shall be adapted to it too. Here we implement a new helper "borrower_physmap_add_memory" to cover both scenarios. Signed-off-by: Penny Zheng --- xen/arch/arm/domain_build.c | 54 ++++++++++++++++++++++++++++++++++--- 1 file changed, 51 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index faf0784bb0..d0f7fc8fd7 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1110,6 +1110,51 @@ static int __init assign_shared_memory(struct domain *d, return ret; } +static int __init borrower_physmap_add_memory(struct domain *d, + struct shm_membank *shm_membank, + paddr_t gbase) +{ + int ret; + unsigned int i; + paddr_t start, size; + gfn_t sgfn; + struct meminfo *meminfo; + + /* Host address is not provided in "xen,shared-mem" */ + if ( shm_membank->mem.banks.meminfo ) + { + meminfo = shm_membank->mem.banks.meminfo; + for ( i = 0; i < meminfo->nr_banks; i++ ) + { + start = meminfo->bank[i].start; + size = meminfo->bank[i].size; + sgfn = _gfn(PFN_UP(gbase)); + + /* Set up P2M foreign mapping for borrower domain. */ + ret = map_regions_p2mt(d, sgfn, PFN_DOWN(size), _mfn(PFN_UP(start)), + p2m_map_foreign_rw); + if ( ret ) + return ret; + + sgfn = gfn_add(sgfn, PFN_DOWN(size)); + } + } + else + { + start = shm_membank->mem.bank->start; + size = shm_membank->mem.bank->size; + sgfn = _gfn(PFN_UP(gbase)); + + /* Set up P2M foreign mapping for borrower domain. */ + ret = map_regions_p2mt(d, sgfn, PFN_DOWN(size), _mfn(PFN_UP(start)), + p2m_map_foreign_rw); + if ( ret ) + return ret; + } + + return 0; +} + static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, paddr_t start, paddr_t size, const char *shm_id) @@ -1242,11 +1287,14 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) { - /* Set up P2M foreign mapping for borrower domain. */ - ret = map_regions_p2mt(d, _gfn(PFN_UP(gbase)), PFN_DOWN(psize), - _mfn(PFN_UP(pbase)), p2m_map_foreign_rw); + ret = borrower_physmap_add_memory(d, shm_membank, gbase); if ( ret ) + { + printk(XENLOG_ERR + "%pd: Failed to map foreign memory to borrower domain: %d", + d, ret); return ret; + } } /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 02:53:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 02:53:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443646.698383 (Exim 4.92) (envelope-from ) id 1oum4c-000336-Mq; Tue, 15 Nov 2022 02:53:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443646.698383; Tue, 15 Nov 2022 02:53:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4c-000324-IE; Tue, 15 Nov 2022 02:53:18 +0000 Received: by outflank-mailman (input) for mailman id 443646; Tue, 15 Nov 2022 02:53:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4b-0008Vs-5K for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 02:53:17 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a6e108b4-6490-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 03:53:15 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 81CFD13D5; Mon, 14 Nov 2022 18:53:21 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A383D3F73B; Mon, 14 Nov 2022 18:53:12 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6e108b4-6490-11ed-8fd2-01056ac49cbb From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v1 08/13] xen/arm: use paddr_assigned to indicate whether host address is provided Date: Tue, 15 Nov 2022 10:52:30 +0800 Message-Id: <20221115025235.1378931-9-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115025235.1378931-1-Penny.Zheng@arm.com> References: <20221115025235.1378931-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We use paddr_assigned to indicate whether host address is provided, by checking the length of "xen,shared-mem" property. And the shm matching criteria shall also be adapt to the new scenario, by adding when host address is not provided, if SHMID matches, the region size must exactly match too. Also, to make codes tidy and clear, we extract codes about parsing "xen,shared-mem" property from function "process_shm" and move them into a new helper "parse_shm_property". Signed-off-by: Penny Zheng --- xen/arch/arm/bootfdt.c | 87 +++++++++++++++++++-------- xen/arch/arm/domain_build.c | 114 +++++++++++++++++++++++++----------- 2 files changed, 141 insertions(+), 60 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 2f34a8ea83..efaf49fd56 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -387,7 +387,7 @@ static int __init process_shm_node(const void *fdt, int node, struct shm_meminfo *shm_mem = &bootinfo.shm_mem; unsigned int i; int len; - bool owner = false; + bool owner = false, paddr_assigned = true; const char *shm_id; if ( address_cells < 1 || size_cells < 1 ) @@ -428,7 +428,7 @@ static int __init process_shm_node(const void *fdt, int node, } /* - * xen,shared-mem = ; + * xen,shared-mem = , and paddr could be optional * Memory region starting from physical address #paddr of #size shall * be mapped to guest physical address #gaddr as static shared memory * region. @@ -439,16 +439,24 @@ static int __init process_shm_node(const void *fdt, int node, if ( len != dt_cells_to_size(address_cells + size_cells + address_cells) ) { + /* paddr is not provided in "xen,shared-mem" */ if ( len == dt_cells_to_size(size_cells + address_cells) ) - printk("fdt: host physical address must be chosen by users at the moment.\n"); - - printk("fdt: invalid `xen,shared-mem` property.\n"); - return -EINVAL; + paddr_assigned = false; + else + { + printk("fdt: invalid `xen,shared-mem` property.\n"); + return -EINVAL; + } } cell = (const __be32 *)prop->data; - device_tree_get_reg(&cell, address_cells, address_cells, &paddr, &gaddr); - size = dt_next_cell(size_cells, &cell); + if ( !paddr_assigned ) + device_tree_get_reg(&cell, address_cells, size_cells, &gaddr, &size); + else + { + device_tree_get_reg(&cell, address_cells, address_cells, &paddr, &gaddr); + size = dt_next_cell(size_cells, &cell); + } if ( !size ) { @@ -458,29 +466,45 @@ static int __init process_shm_node(const void *fdt, int node, for ( i = 0; i < shm_mem->nr_banks; i++ ) { - paddr_t bank_start = shm_mem->bank[i].mem.bank->start; - paddr_t bank_size = shm_mem->bank[i].mem.bank->size; - /* * Meet the following check: + * when host address is provided: * 1) The shm ID matches and the region exactly match * 2) The shm ID doesn't match and the region doesn't overlap * with an existing one + * when host address is not provided: + * 1) The shm ID matches and the region size exactly match */ - if ( paddr == bank_start && size == bank_size ) + if ( !paddr_assigned || (paddr == shm_mem->bank[i].mem.bank->start && + size == shm_mem->bank[i].mem.bank->size) ) { if ( strncmp(shm_id, shm_mem->bank[i].shm_id, MAX_SHM_ID_LENGTH) == 0 ) + { + if ( !paddr_assigned && + (size != shm_mem->bank[i].mem.banks.total_size) ) + { + printk("fdt: when host address is not provided, if xen,shm-id %s matches, size must stay the same too.\n", + shm_id); + return -EINVAL; + } + break; - else + } + else if ( paddr_assigned ) { printk("fdt: xen,shm-id %s does not match for all the nodes using the same region.\n", shm_id); return -EINVAL; } + + /* host address is not provided, and with different SHMID. */ + continue; } else { + paddr_t bank_start = shm_mem->bank[i].mem.bank->start; + paddr_t bank_size = shm_mem->bank[i].mem.bank->size; paddr_t end = paddr + size; paddr_t bank_end = bank_start + bank_size; @@ -512,26 +536,35 @@ static int __init process_shm_node(const void *fdt, int node, if ( i == shm_mem->nr_banks ) { - if ( (i < NR_MEM_BANKS) && (mem->nr_banks < NR_MEM_BANKS) ) + if ( i < NR_MEM_BANKS ) { - /* Static shared memory shall be reserved from any other use. */ - struct membank *membank = &mem->bank[mem->nr_banks]; + if ( !paddr_assigned ) + { + shm_mem->bank[i].mem.banks.total_size = size; + goto out; + } + else if ( mem->nr_banks < NR_MEM_BANKS ) + { + /* Static shared memory shall be reserved from any other use. */ + struct membank *membank = &mem->bank[mem->nr_banks]; - membank->start = paddr; - membank->size = size; - membank->type = MEMBANK_STATIC_DOMAIN; - mem->nr_banks++; + membank->start = paddr; + membank->size = size; + membank->type = MEMBANK_STATIC_DOMAIN; + mem->nr_banks++; + shm_mem->bank[i].mem.bank = membank; + } + else + goto fail; + out: safe_strcpy(shm_mem->bank[i].shm_id, shm_id); - shm_mem->bank[i].mem.bank = membank; shm_mem->nr_banks++; } else - { - printk("Warning: Max number of supported memory regions reached.\n"); - return -ENOSPC; - } + goto fail; } + /* * keep a count of the number of borrowers, which later may be used * to calculate the reference count. @@ -540,6 +573,10 @@ static int __init process_shm_node(const void *fdt, int node, shm_mem->bank[i].nr_shm_borrowers++; return 0; + + fail: + printk("Warning: Max number of supported memory regions reached.\n"); + return -ENOSPC; } #else static int __init process_shm_node(const void *fdt, int node, diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index d0f7fc8fd7..80d37245a8 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1177,6 +1177,81 @@ static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, return 0; } +static int __init parse_shm_property(struct domain *d, + const struct dt_device_node *shm_node, + bool *paddr_assigned, paddr_t *pbase, + paddr_t *gbase, paddr_t *psize) +{ + const struct dt_property *prop; + const __be32 *cells; + uint32_t len; + unsigned int i; + uint32_t addr_cells, size_cells; + + addr_cells = dt_n_addr_cells(shm_node); + size_cells = dt_n_size_cells(shm_node); + + /* xen,shared-mem = ; And pbase could be optional. */ + prop = dt_find_property(shm_node, "xen,shared-mem", &len); + BUG_ON(!prop); + cells = (const __be32 *)prop->value; + + if ( len != dt_cells_to_size(addr_cells + size_cells + addr_cells) ) + { + /* pbase is not provided in "xen,shared-mem" */ + if ( len == dt_cells_to_size(size_cells + addr_cells) ) + *paddr_assigned = false; + else + { + printk("fdt: invalid `xen,shared-mem` property.\n"); + return -EINVAL; + } + } + + if ( !*paddr_assigned ) + { + device_tree_get_reg(&cells, addr_cells, size_cells, gbase, psize); + goto out; + } + else + { + device_tree_get_reg(&cells, addr_cells, addr_cells, pbase, gbase); + *psize = dt_read_number(cells, size_cells); + } + + if ( !IS_ALIGNED(*pbase, PAGE_SIZE) ) + { + printk("%pd: physical address 0x%"PRIpaddr" is not suitably aligned.\n", + d, *pbase); + return -EINVAL; + } + + for ( i = 0; i < PFN_DOWN(*psize); i++ ) + if ( !mfn_valid(mfn_add(maddr_to_mfn(*pbase), i)) ) + { + printk("%pd: invalid physical address 0x%"PRI_mfn"\n", + d, mfn_x(mfn_add(maddr_to_mfn(*pbase), i))); + return -EINVAL; + } + + out: + if ( !IS_ALIGNED(*psize, PAGE_SIZE) ) + { + printk("%pd: size 0x%"PRIpaddr" is not suitably aligned\n", + d, *psize); + return -EINVAL; + } + + if ( !IS_ALIGNED(*gbase, PAGE_SIZE) ) + { + printk("%pd: guest address 0x%"PRIpaddr" is not suitably aligned.\n", + d, *gbase); + return -EINVAL; + } + + return 0; +} + static int __init process_shm(struct domain *d, struct kernel_info *kinfo, const struct dt_device_node *node) { @@ -1184,12 +1259,8 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, dt_for_each_child_node(node, shm_node) { - const struct dt_property *prop; - const __be32 *cells; - uint32_t addr_cells, size_cells; paddr_t gbase, pbase, psize; int ret = 0; - unsigned int i; const char *role_str; const char *shm_id; bool owner_dom_io = true, paddr_assigned = true; @@ -1198,37 +1269,10 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) continue; - /* - * xen,shared-mem = ; - * TODO: pbase is optional. - */ - addr_cells = dt_n_addr_cells(shm_node); - size_cells = dt_n_size_cells(shm_node); - prop = dt_find_property(shm_node, "xen,shared-mem", NULL); - BUG_ON(!prop); - cells = (const __be32 *)prop->value; - device_tree_get_reg(&cells, addr_cells, addr_cells, &pbase, &gbase); - psize = dt_read_number(cells, size_cells); - if ( !IS_ALIGNED(pbase, PAGE_SIZE) || !IS_ALIGNED(gbase, PAGE_SIZE) ) - { - printk("%pd: physical address 0x%"PRIpaddr", or guest address 0x%"PRIpaddr" is not suitably aligned.\n", - d, pbase, gbase); - return -EINVAL; - } - if ( !IS_ALIGNED(psize, PAGE_SIZE) ) - { - printk("%pd: size 0x%"PRIpaddr" is not suitably aligned\n", - d, psize); - return -EINVAL; - } - - for ( i = 0; i < PFN_DOWN(psize); i++ ) - if ( !mfn_valid(mfn_add(maddr_to_mfn(pbase), i)) ) - { - printk("%pd: invalid physical address 0x%"PRI_mfn"\n", - d, mfn_x(mfn_add(maddr_to_mfn(pbase), i))); - return -EINVAL; - } + ret = parse_shm_property(d, shm_node, &paddr_assigned, + &pbase, &gbase, &psize); + if ( ret ) + return ret; /* * "role" property is optional and if it is defined explicitly, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 02:53:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 02:53:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443651.698394 (Exim 4.92) (envelope-from ) id 1oum4f-0003Uk-V2; Tue, 15 Nov 2022 02:53:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443651.698394; Tue, 15 Nov 2022 02:53:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4f-0003UZ-Rm; Tue, 15 Nov 2022 02:53:21 +0000 Received: by outflank-mailman (input) for mailman id 443651; Tue, 15 Nov 2022 02:53:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4e-0000BJ-Lj for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 02:53:20 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a8baf10a-6490-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 03:53:19 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 98F4013D5; Mon, 14 Nov 2022 18:53:24 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BB42C3F73B; Mon, 14 Nov 2022 18:53:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8baf10a-6490-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v1 09/13] xen/arm: refine docs about static shared memory Date: Tue, 15 Nov 2022 10:52:31 +0800 Message-Id: <20221115025235.1378931-10-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115025235.1378931-1-Penny.Zheng@arm.com> References: <20221115025235.1378931-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit amends docs(booting.txt) to include the new scenario where host address is not provided in "xen,shared-mem" property, and we also add a new example to explain in details. We also fix some buggy info in the docs, like SHMID is "my-shared-mem-1", not "0x1". Signed-off-by: Penny Zheng --- docs/misc/arm/device-tree/booting.txt | 52 ++++++++++++++++++++------- 1 file changed, 39 insertions(+), 13 deletions(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 87eaa3e254..287898ef03 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -553,7 +553,7 @@ communication. An array takes a physical address, which is the base address of the shared memory region in host physical address space, a size, and a guest physical address, as the target address of the mapping. - e.g. xen,shared-mem = < [host physical address] [guest address] [size] > + e.g. xen,shared-mem = < [host physical address] [guest address] [size] >; It shall also meet the following criteria: 1) If the SHM ID matches with an existing region, the address range of the @@ -564,8 +564,8 @@ communication. The number of cells for the host address (and size) is the same as the guest pseudo-physical address and they are inherited from the parent node. - Host physical address is optional, when missing Xen decides the location - (currently unimplemented). + Host physical address is optional, when missing Xen decides the location. + e.g. xen,shared-mem = < [guest address] [size] > - role (Optional) @@ -592,7 +592,7 @@ chosen { role = "owner"; xen,shm-id = "my-shared-mem-0"; xen,shared-mem = <0x10000000 0x10000000 0x10000000>; - } + }; domU1 { compatible = "xen,domain"; @@ -603,25 +603,36 @@ chosen { vpl011; /* - * shared memory region identified as 0x0(xen,shm-id = <0x0>) - * is shared between Dom0 and DomU1. + * shared memory region "my-shared-mem-0" is shared + * between Dom0 and DomU1. */ domU1-shared-mem@10000000 { compatible = "xen,domain-shared-memory-v1"; role = "borrower"; xen,shm-id = "my-shared-mem-0"; xen,shared-mem = <0x10000000 0x50000000 0x10000000>; - } + }; /* - * shared memory region identified as 0x1(xen,shm-id = <0x1>) - * is shared between DomU1 and DomU2. + * shared memory region "my-shared-mem-1" is shared between + * DomU1 and DomU2. */ domU1-shared-mem@50000000 { compatible = "xen,domain-shared-memory-v1"; xen,shm-id = "my-shared-mem-1"; xen,shared-mem = <0x50000000 0x60000000 0x20000000>; - } + }; + + /* + * shared memory region "my-shared-mem-2" is shared between + * DomU1 and DomU2. + */ + domU1-shared-mem-2 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = "my-shared-mem-2"; + role = "owner"; + xen,shared-mem = <0x80000000 0x20000000>; + }; ...... @@ -635,14 +646,21 @@ chosen { cpus = <1>; /* - * shared memory region identified as 0x1(xen,shm-id = <0x1>) - * is shared between domU1 and domU2. + * shared memory region "my-shared-mem-1" is shared between + * domU1 and domU2. */ domU2-shared-mem@50000000 { compatible = "xen,domain-shared-memory-v1"; xen,shm-id = "my-shared-mem-1"; xen,shared-mem = <0x50000000 0x70000000 0x20000000>; - } + }; + + domU2-shared-mem-2 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = "my-shared-mem-2"; + role = "borrower"; + xen,shared-mem = <0x90000000 0x20000000>; + }; ...... }; @@ -662,3 +680,11 @@ shared between DomU1 and DomU2. It will get mapped at 0x60000000 in DomU1 guest physical address space, and at 0x70000000 in DomU2 guest physical address space. DomU1 and DomU2 are both the borrower domain, the owner domain is the default owner domain DOMID_IO. + +For the static shared memory region "my-shared-mem-2", since host physical +address is not provided by user, Xen will automatically allocate 512MB +from heap as static shared memory to be shared between DomU1 and DomU2. +The automatically allocated static shared memory will get mapped at +0x80000000 in DomU1 guest physical address space, and at 0x90000000 in DomU2 +guest physical address space. DomU1 is explicitly defined as the owner domain, +and DomU2 is the borrower domain. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 02:53:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 02:53:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443653.698405 (Exim 4.92) (envelope-from ) id 1oum4j-00045g-9d; Tue, 15 Nov 2022 02:53:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443653.698405; Tue, 15 Nov 2022 02:53:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4j-00045W-61; Tue, 15 Nov 2022 02:53:25 +0000 Received: by outflank-mailman (input) for mailman id 443653; Tue, 15 Nov 2022 02:53:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4i-0008Vs-1f for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 02:53:24 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id aa98c8b3-6490-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 03:53:22 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B0A2111FB; Mon, 14 Nov 2022 18:53:27 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D27413F73B; Mon, 14 Nov 2022 18:53:18 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa98c8b3-6490-11ed-8fd2-01056ac49cbb From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v1 10/13] xen/arm: introduce "xen,offset" feature Date: Tue, 15 Nov 2022 10:52:32 +0800 Message-Id: <20221115025235.1378931-11-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115025235.1378931-1-Penny.Zheng@arm.com> References: <20221115025235.1378931-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We introduce "xen,offset" to handle the case where memory from the owner is shared with multiple borrowers. Each borrower would have its own offset within the region shared by the owner. Add relative check when parsing static shared memory node, to make sure that "xen,offset" could be only provided in borrower domain, and the value must be smaller than size. And include according docs in booting.txt. Signed-off-by: Penny Zheng --- docs/misc/arm/device-tree/booting.txt | 19 ++++++++++++++-- xen/arch/arm/bootfdt.c | 32 ++++++++++++++++++++++++++- 2 files changed, 48 insertions(+), 3 deletions(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 287898ef03..183c41e3c2 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -577,6 +577,16 @@ communication. If not specified, the default value is "borrower" and owner is DOMID_IO, a system domain. +- xen,offset (Optional) + + A 64-bit integer specifying the offset within a shared memory region. + When "xen,offset" is provided, only partial shared memory will be + mapped to the borrower domain, starting at the offset and the size + being "size - offset". + + "xen,offset" could be only provided in borrower domain, and the value + must be smaller than size. + As an example: chosen { @@ -660,6 +670,7 @@ chosen { xen,shm-id = "my-shared-mem-2"; role = "borrower"; xen,shared-mem = <0x90000000 0x20000000>; + xen,offset = <0x0 0x10000000>; }; ...... @@ -686,5 +697,9 @@ address is not provided by user, Xen will automatically allocate 512MB from heap as static shared memory to be shared between DomU1 and DomU2. The automatically allocated static shared memory will get mapped at 0x80000000 in DomU1 guest physical address space, and at 0x90000000 in DomU2 -guest physical address space. DomU1 is explicitly defined as the owner domain, -and DomU2 is the borrower domain. +guest physical address space. +For borrower domain DomU2, only partial static shared memory region +"my-shared-mem-2" gets mapped, starting at offset 0x10000000 with size of +256MB. +DomU1 is explicitly defined as the owner domain, and DomU2 is the borrower +domain. diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index efaf49fd56..e642e72f30 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -380,7 +380,7 @@ static int __init process_domain_node(const void *fdt, int node, static int __init process_shm_node(const void *fdt, int node, uint32_t address_cells, uint32_t size_cells) { - const struct fdt_property *prop, *prop_id, *prop_role; + const struct fdt_property *prop, *prop_id, *prop_role, *prop_offset; const __be32 *cell; paddr_t paddr, gaddr, size; struct meminfo *mem = &bootinfo.reserved_mem; @@ -389,6 +389,7 @@ static int __init process_shm_node(const void *fdt, int node, int len; bool owner = false, paddr_assigned = true; const char *shm_id; + uint64_t offset; if ( address_cells < 1 || size_cells < 1 ) { @@ -464,6 +465,35 @@ static int __init process_shm_node(const void *fdt, int node, return -EINVAL; } + /* + * If "xen,offset" is provided, then only partial shared memory + * shall be mapped to borrower domain. The size will be + * "psize - offset". + * "xen,offset" is a 64-bit integer and an optional property + */ + prop_offset = fdt_get_property(fdt, node, "xen,offset", NULL); + if ( prop_offset ) + { + /* + * "xen,offset" could be only provided in borrower domain, + * and the offset must be smaller than size. + */ + if ( prop_role && !strcmp(prop_role->data, "owner") ) + { + printk("fdt: \"xen,offset\" could not be provided in owner domain\n"); + return -EINVAL; + } + + cell = (const __be32 *)prop_offset->data; + offset = dt_next_cell(2, &cell); + + if ( offset >= size ) + { + printk("fdt: invalid \"xen,offset\" value\n"); + return -EINVAL; + } + } + for ( i = 0; i < shm_mem->nr_banks; i++ ) { /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 03:00:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 03:00:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443684.698416 (Exim 4.92) (envelope-from ) id 1oumBf-0007Vd-Aj; Tue, 15 Nov 2022 03:00:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443684.698416; Tue, 15 Nov 2022 03:00:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oumBf-0007VQ-6k; Tue, 15 Nov 2022 03:00:35 +0000 Received: by outflank-mailman (input) for mailman id 443684; Tue, 15 Nov 2022 03:00:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4k-0000BJ-TG for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 02:53:27 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ac712f45-6490-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 03:53:25 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C902C11FB; Mon, 14 Nov 2022 18:53:30 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id EA06A3F73B; Mon, 14 Nov 2022 18:53:21 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac712f45-6490-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v1 11/13] xen/arm: implement "xen,offset" feature when host address provided Date: Tue, 15 Nov 2022 10:52:33 +0800 Message-Id: <20221115025235.1378931-12-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115025235.1378931-1-Penny.Zheng@arm.com> References: <20221115025235.1378931-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When host address is provided in "xen,shared-mem" property([pbase, gbase, psize]), it is easy to decide where to map to the borrower domain if "xen,offset" is also provided. The partially-shared region shall be starting at pbase + offset, and ending at pbase + size. Signed-off-by: Penny Zheng --- xen/arch/arm/domain_build.c | 30 +++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 80d37245a8..95600c640c 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1112,7 +1112,7 @@ static int __init assign_shared_memory(struct domain *d, static int __init borrower_physmap_add_memory(struct domain *d, struct shm_membank *shm_membank, - paddr_t gbase) + paddr_t gbase, paddr_t offset) { int ret; unsigned int i; @@ -1141,8 +1141,8 @@ static int __init borrower_physmap_add_memory(struct domain *d, } else { - start = shm_membank->mem.bank->start; - size = shm_membank->mem.bank->size; + start = shm_membank->mem.bank->start + offset; + size = shm_membank->mem.bank->size - offset; sgfn = _gfn(PFN_UP(gbase)); /* Set up P2M foreign mapping for borrower domain. */ @@ -1157,7 +1157,7 @@ static int __init borrower_physmap_add_memory(struct domain *d, static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, paddr_t start, paddr_t size, - const char *shm_id) + const char *shm_id, paddr_t offset) { struct membank *membank; @@ -1170,7 +1170,7 @@ static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].mem.bank = membank; kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].mem.bank->start = start; - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].mem.bank->size = size; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].mem.bank->size = size - offset; safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, shm_id); kinfo->shm_mem.nr_banks++; @@ -1265,6 +1265,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, const char *shm_id; bool owner_dom_io = true, paddr_assigned = true; struct shm_membank *shm_membank; + uint64_t offset = 0UL; if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) continue; @@ -1288,6 +1289,19 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, } BUG_ON((strlen(shm_id) <= 0) || (strlen(shm_id) >= MAX_SHM_ID_LENGTH)); + /* + * If "xen,offset" is provided, then only partial shared memory + * shall be mapped to borrower domain. + * "xen,offset" is a 64-bit integer and an optional property + */ + dt_property_read_u64(shm_node, "xen,offset", &offset); + if ( !IS_ALIGNED(offset, PAGE_SIZE) ) + { + printk("%pd: \"xen,offset\" 0x%lx is not suitably aligned\n", + d, offset); + return -EINVAL; + } + shm_membank = acquire_shm_membank(shm_id); if ( !shm_membank ) { @@ -1331,7 +1345,8 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) { - ret = borrower_physmap_add_memory(d, shm_membank, gbase); + ret = borrower_physmap_add_memory(d, shm_membank, gbase, + (paddr_t)offset); if ( ret ) { printk(XENLOG_ERR @@ -1345,7 +1360,8 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, * Record static shared memory region info for later setting * up shm-node in guest device tree. */ - ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); + ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id, + (paddr_t)offset); if ( ret ) return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 03:00:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 03:00:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443689.698427 (Exim 4.92) (envelope-from ) id 1oumBg-0007mQ-Hv; Tue, 15 Nov 2022 03:00:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443689.698427; Tue, 15 Nov 2022 03:00:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oumBg-0007mH-EC; Tue, 15 Nov 2022 03:00:36 +0000 Received: by outflank-mailman (input) for mailman id 443689; Tue, 15 Nov 2022 03:00:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4p-0000BJ-U2 for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 02:53:31 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ae41efa1-6490-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 03:53:28 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E07E911FB; Mon, 14 Nov 2022 18:53:33 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0E26B3F73B; Mon, 14 Nov 2022 18:53:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae41efa1-6490-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v1 12/13] xen/arm: implement "xen,offset" feature when host address not provided Date: Tue, 15 Nov 2022 10:52:34 +0800 Message-Id: <20221115025235.1378931-13-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115025235.1378931-1-Penny.Zheng@arm.com> References: <20221115025235.1378931-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When host address is not provided in "xen,shared-mem" property, shared memory region is allocated from heap by Xen. It is normally not contiguous and consisted of multiple memory blocks. Under above scenario, when "xen,offset" is also offered, we need to find at which memory block the offset locates, and the borrower memory map shall start at this block offset. Signed-off-by: Penny Zheng --- xen/arch/arm/domain_build.c | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 95600c640c..494f6aff2e 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -48,6 +48,10 @@ boolean_param("ext_regions", opt_ext_regions); static u64 __initdata dom0_mem; static bool __initdata dom0_mem_set; +#ifdef CONFIG_STATIC_SHM +static uint64_t __initdata allocated = 0UL; +#endif + static int __init parse_dom0_mem(const char *s) { dom0_mem_set = true; @@ -1110,6 +1114,26 @@ static int __init assign_shared_memory(struct domain *d, return ret; } +static bool __init find_anchor_offset(paddr_t *bank_start, paddr_t *bank_size, + uint64_t offset) +{ + uint64_t bank_offset; + + allocated += *bank_size; + if ( allocated <= offset ) + return false; + + /* Find the bank when offset locates */ + bank_offset = *bank_size - (allocated - offset); + *bank_start += bank_offset; + *bank_size = allocated - offset; + + /* Reset after finding the anchor */ + allocated = 0UL; + + return true; +} + static int __init borrower_physmap_add_memory(struct domain *d, struct shm_membank *shm_membank, paddr_t gbase, paddr_t offset) @@ -1123,12 +1147,17 @@ static int __init borrower_physmap_add_memory(struct domain *d, /* Host address is not provided in "xen,shared-mem" */ if ( shm_membank->mem.banks.meminfo ) { + bool found = false; meminfo = shm_membank->mem.banks.meminfo; + sgfn = _gfn(PFN_UP(gbase)); + for ( i = 0; i < meminfo->nr_banks; i++ ) { start = meminfo->bank[i].start; size = meminfo->bank[i].size; - sgfn = _gfn(PFN_UP(gbase)); + + if ( offset && !found ) + found = find_anchor_offset(&start, &size, offset); /* Set up P2M foreign mapping for borrower domain. */ ret = map_regions_p2mt(d, sgfn, PFN_DOWN(size), _mfn(PFN_UP(start)), -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 03:00:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 03:00:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443690.698433 (Exim 4.92) (envelope-from ) id 1oumBg-0007q7-Un; Tue, 15 Nov 2022 03:00:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443690.698433; Tue, 15 Nov 2022 03:00:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oumBg-0007pv-O6; Tue, 15 Nov 2022 03:00:36 +0000 Received: by outflank-mailman (input) for mailman id 443690; Tue, 15 Nov 2022 03:00:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oum4s-0000BJ-UM for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 02:53:34 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id b0baba22-6490-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 03:53:32 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 146CE11FB; Mon, 14 Nov 2022 18:53:38 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 25DE13F73B; Mon, 14 Nov 2022 18:53:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0baba22-6490-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v1 13/13] xen: make static shared memory supported in SUPPORT.md Date: Tue, 15 Nov 2022 10:52:35 +0800 Message-Id: <20221115025235.1378931-14-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115025235.1378931-1-Penny.Zheng@arm.com> References: <20221115025235.1378931-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit After patching previous commits, we could make feature of "static shared memory" supported in SUPPORT.md. Signed-off-by: Penny Zheng --- SUPPORT.md | 2 +- xen/arch/arm/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/SUPPORT.md b/SUPPORT.md index ab71464cf6..c9fe7daf56 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -316,7 +316,7 @@ Allow sharing of identical pages between guests Allow to statically set up shared memory on dom0less system, enabling domains to do shm-based communication - Status, ARM: Tech Preview + Status, ARM: Supported ### Memory Paging diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 52a05f704d..e0ea6e1762 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -141,7 +141,7 @@ config TEE source "arch/arm/tee/Kconfig" config STATIC_SHM - bool "Statically shared memory on a dom0less system" if UNSUPPORTED + bool "Statically shared memory on a dom0less system" depends on STATIC_MEMORY help This option enables statically shared memory on a dom0less system. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 03:08:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 03:08:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443707.698449 (Exim 4.92) (envelope-from ) id 1oumJX-0000uQ-NT; Tue, 15 Nov 2022 03:08:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443707.698449; Tue, 15 Nov 2022 03:08:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oumJX-0000uJ-JM; Tue, 15 Nov 2022 03:08:43 +0000 Received: by outflank-mailman (input) for mailman id 443707; Tue, 15 Nov 2022 03:08:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oumJV-0000u9-Ox; Tue, 15 Nov 2022 03:08:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oumJV-0007CP-M9; Tue, 15 Nov 2022 03:08:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oumJV-0000mS-6h; Tue, 15 Nov 2022 03:08:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oumJV-0007Os-6F; Tue, 15 Nov 2022 03:08:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qKm3HFygdQefYfzwcGev90/sK8bVXHJu6WXDVu3IDSw=; b=0yF6T6dR/GceRosP4NFxLLQtTE xemyTaguufjRHlUFiROjf8w60c+sj9C2v1422VOVO+26d1nrhE/DTClU54LQsRijAW+DkgrOYWhLQ cHsFv2xnfvdMD7C7949bqTW87GT+3OJe5W7Lbj2hCIvXcORPOllLQpw0K+TsQB3+OgMY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174769: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c805ceb0b26a643c7e47f01f2dbc50555d93cce8 X-Osstest-Versions-That: xen=17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 From: osstest service owner Date: Tue, 15 Nov 2022 03:08:41 +0000 flight 174769 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174769/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174762 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174762 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174762 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174762 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174762 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174762 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174762 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174762 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174762 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174762 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174762 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174762 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen c805ceb0b26a643c7e47f01f2dbc50555d93cce8 baseline version: xen 17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 Last test of basis 174762 2022-11-14 01:52:18 Z 1 days Testing same since 174769 2022-11-14 14:10:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Lindig Henry Wang Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 17dfc79ce9..c805ceb0b2 c805ceb0b26a643c7e47f01f2dbc50555d93cce8 -> master From xen-devel-bounces@lists.xenproject.org Tue Nov 15 05:13:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 05:13:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443717.698464 (Exim 4.92) (envelope-from ) id 1ouoFm-0007mG-Fk; Tue, 15 Nov 2022 05:12:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443717.698464; Tue, 15 Nov 2022 05:12:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouoFm-0007m9-CR; Tue, 15 Nov 2022 05:12:58 +0000 Received: by outflank-mailman (input) for mailman id 443717; Tue, 15 Nov 2022 05:12:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouoFl-0007lz-BF; Tue, 15 Nov 2022 05:12:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouoFl-00024q-8a; Tue, 15 Nov 2022 05:12:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouoFk-00064V-Mj; Tue, 15 Nov 2022 05:12:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouoFk-0001bu-MF; Tue, 15 Nov 2022 05:12:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hVS6P98dH281HXXvUSY195kBTg/Qpa5fUTNUohYHdhk=; b=FkvyJlyG023ihjKyAWUol06iZA waE+j8Nu3t0tsuXYeuEGKPS4gfLgSGiUGOy2U+rrKav07wuMvS/DgAGWsrl7CXrMQVfF+tNuavZgQ /x1h4gTzApAXpzUoPPZ/h0IEWWL2tZhjPmcLln4QVahA8To6ZmAAdQUf/kB6Ssw9o/30=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174770: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=094226ad94f471a9f19e8f8e7140a09c2625abaa X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 15 Nov 2022 05:12:56 +0000 flight 174770 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174770/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 094226ad94f471a9f19e8f8e7140a09c2625abaa baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 38 days Failing since 173470 2022-10-08 06:21:34 Z 37 days 62 attempts Testing same since 174764 2022-11-14 05:45:10 Z 0 days 2 attempts ------------------------------------------------------------ 1704 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 162127 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Nov 15 05:42:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 05:42:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443723.698474 (Exim 4.92) (envelope-from ) id 1ouoiC-0003Au-Na; Tue, 15 Nov 2022 05:42:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443723.698474; Tue, 15 Nov 2022 05:42:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouoiC-0003An-Ka; Tue, 15 Nov 2022 05:42:20 +0000 Received: by outflank-mailman (input) for mailman id 443723; Tue, 15 Nov 2022 05:42:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouoiB-0003Ah-85 for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 05:42:19 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20604.outbound.protection.outlook.com [2a01:111:f400:7e1b::604]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42acd2ee-64a8-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 06:42:17 +0100 (CET) Received: from FR3P281CA0186.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::13) by DB8PR08MB5306.eurprd08.prod.outlook.com (2603:10a6:10:117::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.5; Tue, 15 Nov 2022 05:42:13 +0000 Received: from VI1EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a4:cafe::3c) by FR3P281CA0186.outlook.office365.com (2603:10a6:d10:a4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Tue, 15 Nov 2022 05:42:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT012.mail.protection.outlook.com (100.127.145.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Tue, 15 Nov 2022 05:42:12 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Tue, 15 Nov 2022 05:42:12 +0000 Received: from 62078704a11a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0E44828C-8A6F-42D5-ADD4-20723F9B2040.1; Tue, 15 Nov 2022 05:42:06 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 62078704a11a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 15 Nov 2022 05:42:06 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Tue, 15 Nov 2022 05:42:05 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5834.007; Tue, 15 Nov 2022 05:42:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42acd2ee-64a8-11ed-8fd2-01056ac49cbb ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XYI6VlvVQxIfL5gXU9hov6LxcV9z3W3QPV0yCWQi92TATERE8YQL60SbgeH7/akO4UUw9Uzr7w9k8kfzrOAfxhQAdicXFtDzHf5LcVUxcYhXb1wNTjbi/IXOzPnNVpFB+9spwjGLWY1Zi5bw7bhmmywPQyKwVSkLUPQ6WxRYSTG0kbayjtXMGt1HnasrgUJeSaXFSfXnJftYRuKaM7s+vTgh3fUmI+hasEPHpDAaVvoykTYC+nDxroAjOeA8RXkN/8GkJSUFgD4oMe0WP+zO4q8OyyUynH0S+4k1c3xEYssvX5X8H/39iFUCQUOiXS0R41liGKARWMIe1zyFPcD9rg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=db7451ttiCh7dV5ZMLW0rg0RU7rzdaVSd+BOQ0ZTPEM=; b=m0qbDA4hE72JPi2xn61jAqPWRF2mNPrxSTFMj/fdTg1Z+Zbseo7n1D7XFzSFPxyOIt9bydqRAghh9/MA+BgImxT7X+D3Tb4mx+KxZ0z8CQMZ4DAgkDtpwdnQJ3/OwSu3ryFVo0yz/JEOJNUfe0OduialhGWTbFnK+DALR0fp+hZjz6qjTtgm/MCcIuLDNOgVVFP4Kw6bA6s409ud5qVSI35BU1BghYRJEdLHHQNrK8/xO15jU88SXiZbcSc+olFQN0rhRwB88dxyxA4PtUKp9RbzGGz+CoCwu0+tvdPb2f02m/73pwYuElIFUfc1NUNE6zC6CYbG2ToeTjFbm7gqNQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=db7451ttiCh7dV5ZMLW0rg0RU7rzdaVSd+BOQ0ZTPEM=; b=2Wew6a4+tHjMp3Hj2SuuVyq7mVdf1alYfoL+06YiPXVH0DkToA+lVzGphiGt8p1B9NLsExe6vdg12NbqTuI7RL/JyUdMLvNBySXJDsXY/9GjNEE1+C7pWdUzbwTbjBs++9tLy9yoRYui6gJHfhMwO+CPYMVI96OVbewIhtsC2P8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XnwGltIHX0Ajx0E31m47ZCyKeDdkiL+wXUGxM6J1by3TCDdCkU5bbOSoRWTeJkTL0csrBlvZIpzubE1aO2MFOFHEkJqg7sEdMexXThhAdIv2R9U4RM//qQq0kSsW76VRGLpPF4sItDtKj3YtCxG2LCtfVsXN+WiKDS+wZUo3UgKrR7C6VKG0PdoBqaQ5XKpHI5jsGTxidG4S1ZzOqRs8XaMIoUAdGbtouPCd6NjxCO6NYVCfWs+1K8yifK+hdPF6nPcuL/2HMbK1359kLvWew9+nmaTtdbwJQ2UB9nCWzBVMlT8QwIjqzUWVzS2o/Kk0aHvHwSw8XgKl+C/v+nFyLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=db7451ttiCh7dV5ZMLW0rg0RU7rzdaVSd+BOQ0ZTPEM=; b=BtQpgLmynE9n+lQhcHrUgKeSYH/1uoscchmm6kZE0hyRJwbxJorHiP1WtyTDeIJ7YeLbjXVZFuBQgeAaDBqP+NONYTnfIeVh9u96fEUQ0hcLAp7C/wOzzvXvCiqJmMfcpRcbqgv758dkGRU4gXpLFkilEfUPEk+MV2hWlvTiOPQv/W+Tu0Xrt7r40lRb35vY2zQDxHuirF8oynHZW06z6elQZ9qb2SId89etYtfNXMI7RVK9YIvSEujE382oefp17/gobXaMiahcZgHQmYw/lpcQVgTokgJdOL9o5UmuzVamjv84Y/EyxiGOydpDwh7BvyTQ7XiphAyt5y0e4MPyCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=db7451ttiCh7dV5ZMLW0rg0RU7rzdaVSd+BOQ0ZTPEM=; b=2Wew6a4+tHjMp3Hj2SuuVyq7mVdf1alYfoL+06YiPXVH0DkToA+lVzGphiGt8p1B9NLsExe6vdg12NbqTuI7RL/JyUdMLvNBySXJDsXY/9GjNEE1+C7pWdUzbwTbjBs++9tLy9yoRYui6gJHfhMwO+CPYMVI96OVbewIhtsC2P8= From: Wei Chen To: Ayan Kumar Halder , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jiamei Xie Subject: RE: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform Thread-Topic: [PATCH v6 05/11] xen/arm: define Xen start address for FVP BaseR platform Thread-Index: AQHY8DVkWYjGQuvcKkq0uEcag43TF64+1B8AgACyDEA= Date: Tue, 15 Nov 2022 05:42:05 +0000 Message-ID: References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-6-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 494239AF524BBC4091C55862EA06A8BC.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|AS8PR08MB6119:EE_|VI1EUR03FT012:EE_|DB8PR08MB5306:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c297a31-3382-48e7-94e3-08dac6cc254e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3YxFnavgaBWNP9RnMO9mqUxGjtovQo31+dMjyJyR9BUifOi9r0AOOrVJSbmfH6HzlJajCOY2AySPJbaJn/fWNTrJkNrkAMwwJIva0sC6hKbc276HCwEtiyUfOjUv72WXkCRuGMUa7fsq4shKCqL9mKCOizQmLyBRpvbulzWPZRZYvaH/6kLcPXT2YsqJe0QEa6za7ldNRcg6cg6I80ytSZRD9/LmiRp2EjJ7ATPNbDc/Ztug8ptHVzXvdmv7OxeEYpUh8cou6uk+DolzJr9xPULM5nj7UNY5au/cKybOt7EO6UEBE24HFJkUhjzl1QoX8jJswnLD+76kWJGyMBxWOyN6XtbdBfno/eYGOniJrpKvZUlcfo3FAuHjRHpjcCIWb5JewdlOLjz+lS5UyN3XfVedRgLfgzoQfd4vie8csOcZ1946mkiuGhfuqn9RhJXgNdQSZYrmRa6JFTCXttOI8AsOp//9zh7hedSlbrLRF93CzphcmKSlFbN3uSflRSasHs6Cw1vSWjVyA+vNLXpsW3UGj0aPI+oyU96tw9bvzvgTw8ERnblLreVNibCtlADxVWxUsH0w6FqqTzGlJDi7lFA9QfrF54R58NeYCTpM+F40XTi42P3qh74VAKA6saPCDu6H+HaVwEaVZBBDgiHAQO7pd8KkCUXTxdt/we1MSrh3dB6FPJMxYDITCEE0VcrpOGr5x/aX+G9sOnXJ995OYoCq31ZT5doopNMXvZh1kd0i4Wzs+NEUSsDW/4mUGd9QUclNfHSFd0FFbhNDNPBqFA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(396003)(346002)(376002)(136003)(451199015)(6506007)(7696005)(86362001)(55016003)(9686003)(54906003)(110136005)(38070700005)(478600001)(122000001)(71200400001)(38100700002)(186003)(2906002)(33656002)(83380400001)(8936002)(316002)(41300700001)(52536014)(66446008)(66476007)(64756008)(66556008)(66946007)(76116006)(8676002)(4326008)(5660300002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 15feb503-4deb-4a6d-351c-08dac6cc20bd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n7sOH6TjTmWJLpC46t3Bo3ZIYsMI0p6bcFYqcEuBezfrRgsMwXB5vS/knBp+4+WFOlehOzYy3N15b4AhdMqjATkRMKwsPPE1+IvU66kfdi048Ob0MRv7MDuBlcNH8NmEz4AmgdIQDf6z3sfLPtYuJbeAmS60Xe5k2yeZD4/a9XnHpD2HhiK3LuxH/OSNT5VKd9PolU3HHa5xJJCju/UfPewW0i22TQM2V8IeL/2X1mc6gUnxakXLRzETv//RedSR/4+AzM10SE6utmZZY1m4NZBiV8BMnz5Veji3IoyhyQrToJNXm7s5PGKI/AvclmqKA2Rw2FrwGJ7wYaSK64FlurIN88VlbwJEwNCd1OsoQMUCL+M6uX4vQCBp0R6waQiz6bzgbYV0TdndVCo72ZtEVvz3Skkn8jRaEV+2tUmwZVwi81828gldj6gUeyDGpKC/zgqKjfW1TuQJcvU7DWUfQh5abdsixpCj3vKX898vUmJDVEiyMlcYRdatAlvGKgFGxSQf5VhwXEtOcquvmuzW5c9u6HKd4R6DuQQ77EjE97CJ9f4LiShyIyWFqciTrl+CWMTRZJfHUPAUzzKVzK6lUYxYB9j6Sukaf6iY6fshCBo3VjvMqQutMRFSnco4crGj1FK9hj0O2PB7oMiRmvHsXmLpbWfGCcwzXU8GWgdTyitYKfJkf+kF1o7WjuSUz5re8S8YCRowTUvNsJRWAuMehxpQAwFp//aTV/NNfQ0ellK63HKOEg1zJSPv9D+l/b54BIMw/dKmNh0eoAfcJvyf3Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199015)(46966006)(36840700001)(40470700004)(36860700001)(83380400001)(86362001)(356005)(82740400003)(40460700003)(81166007)(2906002)(41300700001)(54906003)(5660300002)(52536014)(40480700001)(8936002)(7696005)(9686003)(6506007)(55016003)(8676002)(26005)(4326008)(316002)(47076005)(70586007)(478600001)(110136005)(70206006)(82310400005)(336012)(186003)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 05:42:12.6787 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4c297a31-3382-48e7-94e3-08dac6cc254e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5306 SGkgQXlhbiwNCg0KPiA+ICsNCj4gPiArI2VuZGlmIC8qIF9fQVNNX0FSTV9QTEFURk9STVNfRlZQ X0JBU0VSX0hfXyAqLw0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vcGxhdGZvcm1zL0tj b25maWcNCj4gYi94ZW4vYXJjaC9hcm0vcGxhdGZvcm1zL0tjb25maWcNCj4gPiBpbmRleCBjOTNh NmIyNzU2Li4wOTA0NzkzYTBiIDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9wbGF0Zm9y bXMvS2NvbmZpZw0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9wbGF0Zm9ybXMvS2NvbmZpZw0KPiA+ IEBAIC0xLDYgKzEsNyBAQA0KPiA+ICAgY2hvaWNlDQo+ID4gICAgICAgICAgcHJvbXB0ICJQbGF0 Zm9ybSBTdXBwb3J0Ig0KPiA+ICAgICAgICAgIGRlZmF1bHQgQUxMX1BMQVQNCj4gPiArICAgICAg IGRlZmF1bHQgRlZQX0JBU0VSIGlmIEFSTV9WOFINCj4gDQo+IEkgY291bGQgbm90IHNwb3QgdGhl IHBhdGNoIHdoaWNoIGludHJvZHVjZWQgQVJNX1Y4Ui4NCj4gDQoNClRoYXQgcGF0Y2ggaXMgbm90 IGluIHRoaXMgcGFydCwgaXQgd2lsbCBiZSB0aGUgbGFzdCBvbmUgb2YgTVBVIHN1cHBvcnQNCnBh dGNoIHNlcmllcy4gWW91IGNhbiBmaW5kIGl0IGdpdGxhYiBicmFuY2gncyBmdWxsIHNlcmllcy4N Cg0KPiBDYW4geW91IHJlbmFtZSB0aGlzIHRvIEFSTTY0X1Y4UiA/IFRoZSByZWFzb24gYmVpbmcg dGhlIHVuZGVybHlpbmcgY29kZQ0KPiBpcyBzcGVjaWZpYyB0byBSODIgaWUgNjQgYml0IFY4Ui4N Cj4gDQoNCkkgcmVuYW1lZCBBUk02NF9WOFIgKGluIFJGQyBwYXRjaCkgdG8gQVJNX1Y4UiBpcyBi ZWNhdXNlICJBcm02NCB2OHIiIGlzDQpub3QgYW4gb2ZmaWNpYWwgQXJtIGFyY2hpdGVjdHVyZSBu YW1lLiBUaGUgQXJtIG9mZmljaWFsIG5hbWUgaXMgQXJtdjgtUg0KQUFyY2gzMi9BQXJjaDY0LiBB bmQgY3VycmVudGx5LCBNUFUgd2lsbCBvbmx5IGJlIHNlbGVjdGVkIGJ5IEFybTY0LCBzbw0KY3Vy cmVudCBNUFUgY29kZSBjYW4gb25seSB3b3JrIGluIEFBcmNoNjQgc3RhdGUuIFdoZW4geW91J3Jl IHRyeWluZyB0bw0KZW5hYmxlIEFybXY4LVIgQUFyY2gzMiBsaWtlIFI1MiwgeW91IGNhbiByZW1v dmUgdGhpcyBsaW1pdGF0aW9uLCBhbmQgdXNlDQpDT05GSUdfQVJNNjQgb3IgQ09ORklHX0FSTTMy IHRvIGRpc3Rpbmd1aXNoIGNvZGUgYmV0d2VlbiByODIgYW5kIHI1MiBjb2RlLg0KDQpDaGVlcnMs DQpXZWkgQ2hlbg0KDQo+IC0gQXlhbg0KPiANCj4gPiAgICAgICAgICAtLS1oZWxwLS0tDQo+ID4g ICAgICAgICAgQ2hvb3NlIHdoaWNoIGhhcmR3YXJlIHBsYXRmb3JtIHRvIGVuYWJsZSBpbiBYZW4u DQo+ID4NCj4gPiBAQCAtOCwxMyArOSwxNCBAQCBjaG9pY2UNCj4gPg0KPiA+ICAgY29uZmlnIEFM TF9QTEFUDQo+ID4gICAgICAgICAgYm9vbCAiQWxsIFBsYXRmb3JtcyINCj4gPiArICAgICAgIGRl cGVuZHMgb24gIUFSTV9WOFINCj4gPiAgICAgICAgICAtLS1oZWxwLS0tDQo+ID4gICAgICAgICAg RW5hYmxlIHN1cHBvcnQgZm9yIGFsbCBhdmFpbGFibGUgaGFyZHdhcmUgcGxhdGZvcm1zLiBJdCBk b2Vzbid0DQo+ID4gICAgICAgICAgYXV0b21hdGljYWxseSBzZWxlY3QgYW55IG9mIHRoZSByZWxh dGVkIGRyaXZlcnMuDQo+ID4NCj4gPiAgIGNvbmZpZyBRRU1VDQo+ID4gICAgICAgICAgYm9vbCAi UUVNVSBhYXJjaCB2aXJ0IG1hY2hpbmUgc3VwcG9ydCINCj4gPiAtICAgICAgIGRlcGVuZHMgb24g QVJNXzY0DQo+ID4gKyAgICAgICBkZXBlbmRzIG9uIEFSTV82NCAmJiAhQVJNX1Y4Ug0KPiA+ICAg ICAgICAgIHNlbGVjdCBHSUNWMw0KPiA+ICAgICAgICAgIHNlbGVjdCBIQVNfUEwwMTENCj4gPiAg ICAgICAgICAtLS1oZWxwLS0tDQo+ID4gQEAgLTIzLDcgKzI1LDcgQEAgY29uZmlnIFFFTVUNCj4g Pg0KPiA+ICAgY29uZmlnIFJDQVIzDQo+ID4gICAgICAgICAgYm9vbCAiUmVuZXNhcyBSQ2FyMyBz dXBwb3J0Ig0KPiA+IC0gICAgICAgZGVwZW5kcyBvbiBBUk1fNjQNCj4gPiArICAgICAgIGRlcGVu ZHMgb24gQVJNXzY0ICYmICFBUk1fVjhSDQo+ID4gICAgICAgICAgc2VsZWN0IEhBU19TQ0lGDQo+ ID4gICAgICAgICAgc2VsZWN0IElQTU1VX1ZNU0ENCj4gPiAgICAgICAgICAtLS1oZWxwLS0tDQo+ ID4gQEAgLTMxLDE0ICszMywyMiBAQCBjb25maWcgUkNBUjMNCj4gPg0KPiA+ICAgY29uZmlnIE1Q U09DDQo+ID4gICAgICAgICAgYm9vbCAiWGlsaW54IFVsdHJhc2NhbGUrIE1QU29DIHN1cHBvcnQi DQo+ID4gLSAgICAgICBkZXBlbmRzIG9uIEFSTV82NA0KPiA+ICsgICAgICAgZGVwZW5kcyBvbiBB Uk1fNjQgJiYgIUFSTV9WOFINCj4gPiAgICAgICAgICBzZWxlY3QgSEFTX0NBREVOQ0VfVUFSVA0K PiA+ICAgICAgICAgIHNlbGVjdCBBUk1fU01NVQ0KPiA+ICAgICAgICAgIC0tLWhlbHAtLS0NCj4g PiAgICAgICAgICBFbmFibGUgYWxsIHRoZSByZXF1aXJlZCBkcml2ZXJzIGZvciBYaWxpbnggVWx0 cmFzY2FsZSsgTVBTb0MNCj4gPg0KPiA+ICtjb25maWcgRlZQX0JBU0VSDQo+ID4gKyAgICAgICBi b29sICJGaXhlZCBWaXJ0dWFsIFBsYXRmb3JtIEJhc2VSIHN1cHBvcnQiDQo+ID4gKyAgICAgICBk ZXBlbmRzIG9uIEFSTV9WOFINCj4gPiArICAgICAgIGhlbHANCj4gPiArICAgICAgICAgRW5hYmxl IHBsYXRmb3JtIHNwZWNpZmljIGNvbmZpZ3VyYXRpb25zIGZvciBGaXhlZCBWaXJ0dWFsDQo+ID4g KyAgICAgICAgIFBsYXRmb3JtIEJhc2VSDQo+ID4gKw0KPiA+ICAgY29uZmlnIE5PX1BMQVQNCj4g PiAgICAgICAgICBib29sICJObyBQbGF0Zm9ybXMiDQo+ID4gKyAgICAgICBkZXBlbmRzIG9uICFB Uk1fVjhSDQo+ID4gICAgICAgICAgLS0taGVscC0tLQ0KPiA+ICAgICAgICAgIERvIG5vdCBlbmFi bGUgc3BlY2lmaWMgc3VwcG9ydCBmb3IgYW55IHBsYXRmb3JtLg0KPiA+DQo+ID4gLS0NCj4gPiAy LjI1LjENCj4gPg0KPiA+DQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 15 06:58:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 06:58:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443773.698504 (Exim 4.92) (envelope-from ) id 1ouptu-0004Ej-JM; Tue, 15 Nov 2022 06:58:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443773.698504; Tue, 15 Nov 2022 06:58:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouptu-0004Ec-Fh; Tue, 15 Nov 2022 06:58:30 +0000 Received: by outflank-mailman (input) for mailman id 443773; Tue, 15 Nov 2022 06:58:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouptt-0004ES-8k for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 06:58:29 +0000 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [2607:f8b0:4864:20::b2a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7a422e5-64b2-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 07:58:27 +0100 (CET) Received: by mail-yb1-xb2a.google.com with SMTP id 136so519386ybn.1 for ; Mon, 14 Nov 2022 22:58:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7a422e5-64b2-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JJbf6CTTdmdKi2q8fRCrfv+2xLBLA+vZ/1LRWKN5m88=; b=fbbJIRPxLIIpKtIeu0ZOB7U8f4u79rsLWRJ2x5xtI8NvpqzttL84ls9MlVyCITGsaQ MIif2ZCRKTADjKJ05ZJn/QDpyybKokHr60cj5udWgJYXjWn3pDZw1eKf98s8NMvIID0T 4Uh4m8qU3zoHZJRQcOnT4PpIW6VQTTrsrRMkWltZFt5U00kyBLwPE6jJAGVwcSDSKk8E nTGpOg76xYpSDX5GFRqGLaSGz61Vr8J92zXBhZJrvG7LFfq2YyALALR0UMc5uKCAi95/ dDUY9egJjuRGJPoncXhbkn54/PC7dGX8sVserWRZkp7c5yVx3sfMo4nOO0sf1oIY+Z+W bCdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JJbf6CTTdmdKi2q8fRCrfv+2xLBLA+vZ/1LRWKN5m88=; b=NLKYwS5vElvY/HtWVe2Rc7WYKspbgtP7vV50l9MaCUITEBr6PP/f/IXiGOdaw0f/f/ QmJTyoCW/2KQCqpBlqVaphyOusx1/4Ky/fh6cOmd7QJ8D7uB+LGBO4yuPIHTpKX7vs2a mMRCA4KvZ4ldUQwPpWSqI/wwW/48ipJclkyrMVDHEXGiZdqnOBjmlxB0SLduOp2SD4sZ 5D/U8aiHtlRN8SP4hh//98/fk1W5ZDFKLp1hcJyOMOt0oxbcPnIGPvy16XeHnmYAmhA3 nX0ba7Tuln4pkSHRVutru8BDf0T+CMedWhhUrClA9Psa+c6SNptruC/cVpGUDaixItZt seZQ== X-Gm-Message-State: ANoB5pkoY40jFkQkPF6Nm3+ynibm1iCTsTFgBDCI0RLsIGellIZ7SRj0 /tonUro89ueEAeOUd8p5o8eQko+A7muQRu+2vZg= X-Google-Smtp-Source: AA0mqf4gVfgMSVAMNL3h39idvp38XmXaqF9WakCb+Ymxl3tXsiR2YZym9cX6x2EM5wrGC36pnnqn8ApgKdjZSZEQDyA= X-Received: by 2002:a25:c653:0:b0:6cb:2aeb:d5b5 with SMTP id k80-20020a25c653000000b006cb2aebd5b5mr16257986ybf.333.1668495506518; Mon, 14 Nov 2022 22:58:26 -0800 (PST) MIME-Version: 1.0 References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-3-Penny.Zheng@arm.com> In-Reply-To: <20221115025235.1378931-3-Penny.Zheng@arm.com> From: Jeungwoo Yoo Date: Tue, 15 Nov 2022 07:58:15 +0100 Message-ID: Subject: Re: [PATCH v1 02/13] xen/arm: switch to use shm_membank as function parameter To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Content-Type: text/plain; charset="UTF-8" Hello, Reading this patch, I found one place that can be improved. On 11/15/22 03:52, Penny Zheng wrote: > Instead of using multiple function parameters to deliver various shm-related > info, like host physical address, SHMID, etc, and with the introduction > of new struct "shm_membank", we could switch to use "shm_membank" as > function parameter to replace them all, to make codes more clear and > tidy. > > Signed-off-by: Penny Zheng > --- > xen/arch/arm/domain_build.c | 46 ++++++++++++++++++------------------- > 1 file changed, 23 insertions(+), 23 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index c0fd13f6ed..d2b9e60b5c 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -751,40 +751,31 @@ static void __init assign_static_memory_11(struct domain *d, > } > > #ifdef CONFIG_STATIC_SHM > -static int __init acquire_nr_borrower_domain(struct domain *d, > - paddr_t pbase, paddr_t psize, > - unsigned long *nr_borrowers) > +static struct shm_membank * __init acquire_shm_membank(const char *shm_id) > { > unsigned int bank; > > /* Iterate static shared memory to find requested shm bank. */ > for ( bank = 0 ; bank < bootinfo.shm_mem.nr_banks; bank++ ) > - { > - paddr_t bank_start = bootinfo.shm_mem.bank[bank].membank->start; > - paddr_t bank_size = bootinfo.shm_mem.bank[bank].membank->size; > - > - if ( (pbase == bank_start) && (psize == bank_size) ) > + if ( strcmp(shm_id, bootinfo.shm_mem.bank[bank].shm_id) == 0 ) The target shared memory is found and the bank can be returned directly here (return &bootinfo.shm_mem.bank[bank];). Therefore, the out-of-bounds condition check can be removed below. > break; > - } > > if ( bank == bootinfo.shm_mem.nr_banks ) This can be removed, but only return NULL because the target memory is not found. > - return -ENOENT; > - > - *nr_borrowers = bootinfo.shm_mem.bank[bank].nr_shm_borrowers; > + return NULL; > > - return 0; > + return &bootinfo.shm_mem.bank[bank]; > } > > /* > * This function checks whether the static shared memory region is > * already allocated to dom_io. > */ > -static bool __init is_shm_allocated_to_domio(paddr_t pbase) > +static bool __init is_shm_allocated_to_domio(struct shm_membank *shm_membank) > { > struct page_info *page; > struct domain *d; > > - page = maddr_to_page(pbase); > + page = maddr_to_page(shm_membank->membank->start); > d = page_get_owner_and_reference(page); > if ( d == NULL ) > return false; > @@ -835,14 +826,17 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, > } > > static int __init assign_shared_memory(struct domain *d, > - uint32_t addr_cells, uint32_t size_cells, > - paddr_t pbase, paddr_t psize, > + struct shm_membank *shm_membank, > paddr_t gbase) > { > mfn_t smfn; > int ret = 0; > unsigned long nr_pages, nr_borrowers, i; > struct page_info *page; > + paddr_t pbase, psize; > + > + pbase = shm_membank->membank->start; > + psize = shm_membank->membank->size; > > printk("%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", > d, pbase, pbase + psize); > @@ -871,9 +865,7 @@ static int __init assign_shared_memory(struct domain *d, > * Get the right amount of references per page, which is the number of > * borrower domains. > */ > - ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); > - if ( ret ) > - return ret; > + nr_borrowers = shm_membank->nr_shm_borrowers; > > /* > * Instead of letting borrower domain get a page ref, we add as many > @@ -941,6 +933,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > const char *role_str; > const char *shm_id; > bool owner_dom_io = true; > + struct shm_membank *shm_membank; > > if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) > continue; > @@ -991,12 +984,20 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > } > BUG_ON((strlen(shm_id) <= 0) || (strlen(shm_id) >= MAX_SHM_ID_LENGTH)); > > + shm_membank = acquire_shm_membank(shm_id); > + if ( !shm_membank ) > + { > + printk("%pd: failed to acquire %s shared memory bank\n", > + d, shm_id); > + return -ENOENT; > + } > + > /* > * DOMID_IO is a fake domain and is not described in the Device-Tree. > * Therefore when the owner of the shared region is DOMID_IO, we will > * only find the borrowers. > */ > - if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || > + if ( (owner_dom_io && !is_shm_allocated_to_domio(shm_membank)) || > (!owner_dom_io && strcmp(role_str, "owner") == 0) ) > { > /* > @@ -1004,8 +1005,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > * specified, so they should be assigned to dom_io. > */ > ret = assign_shared_memory(owner_dom_io ? dom_io : d, > - addr_cells, size_cells, > - pbase, psize, gbase); > + shm_membank, gbase); > if ( ret ) > return ret; > } From xen-devel-bounces@lists.xenproject.org Tue Nov 15 07:18:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 07:18:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443777.698515 (Exim 4.92) (envelope-from ) id 1ouqDI-0007Zl-76; Tue, 15 Nov 2022 07:18:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443777.698515; Tue, 15 Nov 2022 07:18:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouqDI-0007Ze-3T; Tue, 15 Nov 2022 07:18:32 +0000 Received: by outflank-mailman (input) for mailman id 443777; Tue, 15 Nov 2022 07:18:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouqDG-0007ZB-RU; Tue, 15 Nov 2022 07:18:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouqDG-0004oi-Nv; Tue, 15 Nov 2022 07:18:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouqDG-0005AE-4P; Tue, 15 Nov 2022 07:18:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouqDG-0008O8-3u; Tue, 15 Nov 2022 07:18:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nznCw4o/rxaAswbpXZ3AGfobQ3U3MfNyah9FhL35vF8=; b=jYG79+DRm8OAofeNg8TtQMy3Xd v6oo2T7ELApc2sS9y9f0CIbRVN/OEb6oApz3Vp5NVTVgwHdvlZfBr2qrHeRPFl7N61y2tLlTXGAWo gfSvBp9pZkwzLB9ZuJXgC38oKa+RFtT63/U/dIjkKO39w6kqhw3DrvrV4qefB9JdRZzE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174772: trouble: broken/fail/pass X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-arndale::broken:regression qemu-mainline:test-armhf-armhf-xl-arndale:host-install(5):broken:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=98f10f0e2613ba1ac2ad3f57a5174014f6dcb03d X-Osstest-Versions-That: qemuu=305f6f62d9d250a32cdf090ddcb7e3a5b26a342e From: osstest service owner Date: Tue, 15 Nov 2022 07:18:30 +0000 flight 174772 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174772/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale broken test-armhf-armhf-xl-arndale 5 host-install(5) broken REGR. vs. 174761 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174761 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174761 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174761 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174761 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174761 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174761 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174761 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174761 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 98f10f0e2613ba1ac2ad3f57a5174014f6dcb03d baseline version: qemuu 305f6f62d9d250a32cdf090ddcb7e3a5b26a342e Last test of basis 174761 2022-11-14 01:07:28 Z 1 days Testing same since 174772 2022-11-14 22:08:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jens Wiklander Peter Maydell Stefan Hajnoczi Vikram Garhwal jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale broken test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-arndale broken broken-step test-armhf-armhf-xl-arndale host-install(5) Not pushing. ------------------------------------------------------------ commit 98f10f0e2613ba1ac2ad3f57a5174014f6dcb03d Merge: 305f6f62d9 d9721f19cd Author: Stefan Hajnoczi Date: Mon Nov 14 13:31:17 2022 -0500 Merge tag 'pull-target-arm-20221114' of https://git.linaro.org/people/pmaydell/qemu-arm into staging target-arm queue: * hw/intc/arm_gicv3: fix prio masking on pmr write * MAINTAINERS: Update maintainer's email for Xilinx CAN # -----BEGIN PGP SIGNATURE----- # # iQJNBAABCAA3FiEE4aXFk81BneKOgxXPPCUl7RQ2DN4FAmNyY7cZHHBldGVyLm1h # eWRlbGxAbGluYXJvLm9yZwAKCRA8JSXtFDYM3mrBD/4mG6AMW4CGROWq3u3F8STK # 22uxpilhyBmPawBykUC8dYId8A0GjGqeJ5HRhYE/0ZKqlk9GtFBI4YHM8ccocozK # VdgKP7VvXNiBwjV2kQ3mdZnfXRnNWLTnGQd9Q/9EjU+FOBz4hsOoRh8rv+9t2inn # dtXV8wbLYQYHCgVPAwTP39DXzF0YQ5sAjVxbjC1lFE6k3pAcDvoGKKcWt9GOI5m1 # 5ImPgnVdunscqA9otvl56a03M5TbdH8KiAEARo3juFYYEHkl4qD2E2CK6On8wTIA # 7zeSoxvTDDYD6mcV/RwFuEcOr+YIFpxeGxes9PKpnYh8Dpx9YPeIYRsK5qTI7QUz # Ldbz9PnZE6DPaPsT67kzFnfx4se6q10d5wXaK8VsFBOZ4V9yYONaXlHiZbgpWn/K # jlbiJFtehCA0iS4D6YcoDTqL88M/RM5cbj/5tht8sxrl9HJ3r/hxdJ7W+zqpTg2j # 3TV+j9okLqyq/4RIFZbf5yVPFPMtF/FOIl95ZAHmvJYjC/L9yXRT6Y5EdKfZPwMe # 5FBjdly4gsUqNxFUfPByRVtaoelxjXi/+0wHXWZNw8Naco3yd7VMoqIRLDE4qhY5 # GfjF2Aai7PHiwb2VE+mIIfz+ldEk5XHFYlXBtUOwt8q2UUnmYsVqh8zFpTYLaDdY # RezkZM4yMYx38GPWCvAvlg== # =clh5 # -----END PGP SIGNATURE----- # gpg: Signature made Mon 14 Nov 2022 10:50:15 EST # gpg: using RSA key E1A5C593CD419DE28E8315CF3C2525ED14360CDE # gpg: issuer "peter.maydell@linaro.org" # gpg: Good signature from "Peter Maydell " [full] # gpg: aka "Peter Maydell " [full] # gpg: aka "Peter Maydell " [full] # gpg: aka "Peter Maydell " [unknown] # Primary key fingerprint: E1A5 C593 CD41 9DE2 8E83 15CF 3C25 25ED 1436 0CDE * tag 'pull-target-arm-20221114' of https://git.linaro.org/people/pmaydell/qemu-arm: hw/intc/arm_gicv3: fix prio masking on pmr write MAINTAINERS: Update maintainer's email for Xilinx CAN Signed-off-by: Stefan Hajnoczi commit d9721f19cd05a382f4f5a7093c80d1c4a8a1aa82 Author: Jens Wiklander Date: Mon Nov 14 15:10:58 2022 +0000 hw/intc/arm_gicv3: fix prio masking on pmr write With commit 39f29e599355 ("hw/intc/arm_gicv3: Use correct number of priority bits for the CPU") the number of priority bits was changed from the maximum value 8 to typically 5. As a consequence a few of the lowest bits in ICC_PMR_EL1 becomes RAZ/WI. However prior to this patch one of these bits was still used since the supplied priority value is masked before it's eventually right shifted with one bit. So the bit is not lost as one might expect when the register is read again. The Linux kernel depends on lowest valid bit to be reset to zero, see commit 33625282adaa ("irqchip/gic-v3: Probe for SCR_EL3 being clear before resetting AP0Rn") for details. So fix this by masking the priority value after it may have been right shifted by one bit. Cc: qemu-stable@nongnu.org Fixes: 39f29e599355 ("hw/intc/arm_gicv3: Use correct number of priority bits for the CPU") Signed-off-by: Jens Wiklander Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell commit 32bd99d02b4549d1007fb26b7301d26c55e3ba5a Author: Vikram Garhwal Date: Mon Nov 14 15:10:57 2022 +0000 MAINTAINERS: Update maintainer's email for Xilinx CAN Signed-off-by: Vikram Garhwal Reviewed-by: Francisco Iglesias Signed-off-by: Peter Maydell From xen-devel-bounces@lists.xenproject.org Tue Nov 15 07:54:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 07:54:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443790.698526 (Exim 4.92) (envelope-from ) id 1ouqlZ-00049f-2b; Tue, 15 Nov 2022 07:53:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443790.698526; Tue, 15 Nov 2022 07:53:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouqlY-00049Y-VZ; Tue, 15 Nov 2022 07:53:56 +0000 Received: by outflank-mailman (input) for mailman id 443790; Tue, 15 Nov 2022 07:53:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouqlW-00049S-Lx for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 07:53:55 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70052.outbound.protection.outlook.com [40.107.7.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a56f1437-64ba-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 08:53:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8974.eurprd04.prod.outlook.com (2603:10a6:102:20d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Tue, 15 Nov 2022 07:53:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Tue, 15 Nov 2022 07:53:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a56f1437-64ba-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Drh7SXiTG0azDADop78JrE1U+qkRnU45OvqAKAQXg+oZPYjQSv0OH3IKAgiMnxKu76rbgy+pmpJBPuaH3fhiahRobmxCGlPn5Ic/iFIIc7pCK4uk1i1daqlm+k176M4aYbs/Tj/T0ZAsYfeiurxb4tL4ICGGwIF/nMVPeMtIlzj+AccJRNChknrdhuji/otUe+BO7oJxzaFf/fBtGNXvUyAPLyxGJpJujLPowtl5nNgDxYey4YzMsj3/NxmhJscY+XUXSUspr3h3h2NaJqg4t4XjXnPxJT6x8SgyXKgqoBYM88MfxwU9kvjT0N5N1niQjf8zOG86P69TE3ZIwhRFRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8EXECTV9C6oDhySzkOcsb6G9UHw6CqFTXb5TGZTafo0=; b=GUE8YIBJHI6Cdo/PyGQSRTePj/zW/t8oS+KUMp6+o7AtzFmrPX6I4km/K+tU0D16dy7HBuqTVHef277u5lyTrQYHHopx3RdNb1FyiaHR5fuN/nKCzyJ5IiXMQC4X/UEjB7AnAoQ3bQLwXrIDl5MiIMbeNABa5gcb7TDTwU6nq4Dn51FLoEUESw6YJ9BXsTV4BQQFBEZ54OLX0yHxDD7onfemAoF5JwMwy2mC+hsbCCuJdHW1w6CQJ1ol5oUhvzG20c5dvjBAO/WOmTiIPD5ZzSxwEXVqY5pHwLzOj+rKKe69ItxMG2JTc98dzVMcw4NsqisVKuCCiuDxiFj/BLoG/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8EXECTV9C6oDhySzkOcsb6G9UHw6CqFTXb5TGZTafo0=; b=4lQtVddk1mTcoqSuxb963UXJoGCHWyQ5GfYCOQjAtBChHYcRg7GrIBT3yeNQh/mgY7yLN1ICr9KqFXlbV7GidtKbrLdKgjBbwykn7uM/FznP4jxpsD2+vczK+hEtyRXVxqLd5VwXmx/haXLqfU4wxRNRerRWcx9TgP+FXaSGcQreVgHCHW5w5p2PqkJU7TWWbEKkSEYWO7oEp2bR3nDkXB8FLtN8VGlgtC+hIVvo/Vte6zAjzCg21VMUiFZpMz0CwTBSX6hXcYyUAY3mSnOjJNbn6RBmFrQsvOlPSkOc0sKKA8UYbddJa+wZkf6wRZfQM60gl0bwWs3/oJHGucAfVg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <083341c0-8169-e422-e72e-8c83f7699959@suse.com> Date: Tue, 15 Nov 2022 08:53:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 6/9] xen/common: add cache coloring allocator for domains Content-Language: en-US To: Carlo Nonato Cc: marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Marco Solieri , xen-devel@lists.xenproject.org References: <20221022155120.7000-1-carlo.nonato@minervasys.tech> <20221022155120.7000-7-carlo.nonato@minervasys.tech> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0119.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8974:EE_ X-MS-Office365-Filtering-Correlation-Id: 61f40e0a-5c4c-48cd-7e33-08dac6de782a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dGw+1/Za4ds8CmLUrx1JoUgf28Nwp+HAF5rIho19f6tDCw8T6BHTqVjduYj4C/ebLSSmrK2DBnGI4XB8EST4UMw3w0zZaTz0/Nv/h4Hj9qPTDJxuyVixKEqZvpqsIV8A3t9AksbpJFc+fbdfCUKAE9OTn9YvOiXGEy6EsQVsF+1dvc2qbej5iLzQCyjQAJkJCKmGDgjjOMOB7jfmd0WnAQPwClEj5D0DwCLm2fT2qcs6+VA0KFzEtKxj9tJLu3H+u6dguIRr13kqDno5F6sMeoQfZlM+p6QHWWBTGu77AkfBv0vEfmbkAZZiMlBQtK+0B/AjhfxrxqOf8kOq3baSHXA2DvdpyNvpBzlhmG+GfHplQ4xTvIIs6DseKLcIUkhh+LQugK7VCF9nOD1BqLzBDbASunIxvCo8H/jUDSbqSOfQnEfg25VpOtRmhj9AWaTX76TCe4jD6H11e4+rNwKtWok7wkrei8SnGb7cAdLvGnOJpsnNrUIfYtQcnmvuOrBCZUZNnZz+6QA5ipQD8nDealBqjQVf6DJ//p4RWOePwJc/qONQLmqeOuIACB+MdL31DSZh3XuoUT8I0aJwze3xI2zWV561nSMjNGja6Y9DLUdJrYTimibqZ2KAqcNNbEmt8TKEZW/3acN3Z2vI/l2Tl0a7elb0AY7u2zzEaXWcP8+Wmdc7blfCaeSWFfj82zGC6xPCkne3dFCftZEue0gEnjoQMoa+Yh9xQmzBn+kdqXDhGDAtOrP+QroaUG7soI/NNA52mxa78ev9wQa6G3EGrIRDzw3nhzMnc3Izdsjcw8c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199015)(6666004)(186003)(2616005)(6916009)(4326008)(54906003)(6486002)(66556008)(2906002)(66946007)(36756003)(66476007)(8676002)(6512007)(8936002)(7416002)(38100700002)(26005)(86362001)(5660300002)(316002)(53546011)(6506007)(31696002)(31686004)(41300700001)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bE9NMEFjL0wzM3NhZHdyNSs3T0tXdGFsb2xzU0kxak9DdXFib2d4aVdTQnh3?= =?utf-8?B?VEVpSzlZSWIrd1drUFZ2TkF2R3VvL3ZqQU1DbEVYeHF4UFRpMmNOdzU1U0Ns?= =?utf-8?B?K29rcWdMeUV6S0xMZHJCRnRHL2J2RktiZmJoTWttVC8zem9MdHlBQXJieXdI?= =?utf-8?B?MjVvci9QNFVneEpoYTdFSnpjVHFlbEhSQ0pKSTUwa1NVY3pYanByaG9yZmMx?= =?utf-8?B?bmpSS1A4RXJ5V0J3MmVZY3pFTXcra0E4Yk8vakRJTTZldGlyUVhyN2EzbjlK?= =?utf-8?B?TnJSN1VtZEhmRi80dXlxWVZHYm5UbFpwTTRkYnd1bjhBQ3FRcGZVT1pyQXpw?= =?utf-8?B?bmF4aklLZnV2NWlTczZjeGZ6dGdGMUp3V1RuTm9rOHNFaWtRa2Z1eDZTbjgz?= =?utf-8?B?bFNKLzRUekxKM0M4dGpZUjd0b0hhUzZTWW93S3ZsQ3VBY3ROL1YzSlVvQmpW?= =?utf-8?B?Zk4vSUM5UlRNUGQ5anNGWXRBbjFXeG9zRUpCNHRUeDl5ejJhUVJHNmkvNSsv?= =?utf-8?B?WjlnczFwWFgzRWFySUhEODFFOGdwWm5ONmtDKzZKVUQxTnNjSUpyM2dsbDFl?= =?utf-8?B?aWF5eWNLb3d1cDcrY3oyMTdLQW51bC80Z3dqOFJZNHRaYUdGZGxtTHl2RElz?= =?utf-8?B?blU5b0RoWXdLamxaMzYxdDNPbHU4Um9LQzZmUmVkWjdmb0x6cFZBN2FGdUdB?= =?utf-8?B?ajFXZXUyQW1kSmdSQXoySlVseUsybkRaWDBpYnJtSnhJTEM5Y3RZdU1XT2k2?= =?utf-8?B?eDVYRUx0dFczdkFzbk03KzNSckpKcGg1ZjUrU2ZYUVExWE84aHBQNlhWL0JX?= =?utf-8?B?WGRscXBkUkVrMlhUYzBuNmhrZjdEWXppd2t1ZEc5bjNDQXh4SkRUZHJYRzda?= =?utf-8?B?Kzh6dFdxMG5lMHlhUWE0emZSWTNqT2xaU2ZGbnBKcDgwODJLbjJIVVV3a3lQ?= =?utf-8?B?V0NNc1lSSGNFbTZ6RWRBSUlTam4rUmFMb2xuVDZRUGM0RE5aRVVqQkpsRGZh?= =?utf-8?B?UXk4a2RTZW1XNHVPZEE3R0xsMm82VkJGaUtaZ0lSb1lpQVNGVCtyL1EvK1Ni?= =?utf-8?B?M3FEa1J0bEloYU52QmpZb1lFbE1tQXZybEVjcklBcWxIbmxKNFNvT0VDWC9F?= =?utf-8?B?MG9SMzRuWXBQTlkxMFpQb2xnM0REMjR4OUlqS3Z3ZHltRE9EVnNUeFg4RlJh?= =?utf-8?B?ZG9ZaXcxdEFUcTZlb0R4MnNZTUJQMmYycE52b0FTM1BFTGhYQTZiNnJrT3pG?= =?utf-8?B?aVJiWGZCMy9uTjlmUlBDWEhFQWNiZHdLdEFrWUJueTAydUZCTHhXSktabUZj?= =?utf-8?B?QkljNmRMM0w0Q014Y2RRdGFqMVYzL1hxU3Z5bit4ZzExUURKc3lHNnowWlVI?= =?utf-8?B?Z1FOUXBDZUIwb0JCbjZrUWZmUS9HdzE0aXRiZTM0YTV1WStqdU9INERZYkxS?= =?utf-8?B?enlSeE01OGd4RGliZTdwRlFXeURiTXc2ZWpuK1hwb2lCTG8wSHdPWWZRMjlC?= =?utf-8?B?djNvY3lFOU54UGxjSG5uVDE4ejBCR20vMEgwRVdxbmJsN3A1WlBzQmRLUktU?= =?utf-8?B?U2tMRTdFNkhRVXRtTGhzY05yb3hPK3k0cUR0SkJRLzZpV3hCcG1jMlM2dTRR?= =?utf-8?B?akkyTit3VWNqMGpZSVFrSXlEa2liU2ozY2ZzZ0dRLzNJMnJLdVVhbFRTYWtl?= =?utf-8?B?SzJSK1hEVmhsdERGSlQwcldqMFlYZTRZbEY5RFh6WVV6MzhadWdKaTBpZTc1?= =?utf-8?B?VEQ5NjZ1b2xBZmd5UFZsenRHSVdZZ2tnLzFjNm9hb3lqYmVQRmR6V045NkpS?= =?utf-8?B?RVlML0JxcHZVaEpjN1VvbW5JY052SlB4dUs2TkZ1dkU1bEkxc2xFaEZnckE4?= =?utf-8?B?RFdDMENObExTb2RGWSsrWGIxVktMTko0ZmNtL0lvRHRnbWIzdThHc05zSDR0?= =?utf-8?B?dGRGUHB6RFpKL3FiN0NUR3JOT0t3VFhNTUZSWnZNOW91TGlscCtWSC9JUUtz?= =?utf-8?B?OFFZOG94NnRZT0ZSRDFXWGNENml0WkV2MVF4bXllZnJTcmllcHlMZjVISzVM?= =?utf-8?B?di9VcUpiakl4MWpLRWw5MStzUjZadlo5TUdsOEIxZ0RGZ3IyVnBEdU1OMVc2?= =?utf-8?Q?mg89cgfIN4jeOh7lAnJjmHFj9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61f40e0a-5c4c-48cd-7e33-08dac6de782a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 07:53:22.8374 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m4Rico850OAsCdqisMkeMZZ7tpD402inlINh3VgDHMTAtcON37h0TLUF8fgjncOhCgEUIwDjKIghhQ5+yRJcRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8974 On 14.11.2022 16:04, Carlo Nonato wrote: > On Thu, Nov 10, 2022 at 5:47 PM Jan Beulich wrote: >> On 22.10.2022 17:51, Carlo Nonato wrote: >>> --- a/xen/arch/arm/p2m.c >>> +++ b/xen/arch/arm/p2m.c >>> @@ -661,7 +661,12 @@ static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry) >>> >>> ASSERT(!p2m_is_valid(*entry)); >>> >>> - page = alloc_domheap_page(NULL, 0); >>> + /* If cache coloring is enabled, p2m tables are allocated using the domain >>> + * coloring configuration to prevent cache interference. */ >>> + if ( IS_ENABLED(CONFIG_CACHE_COLORING) ) >>> + page = alloc_domheap_page(p2m->domain, MEMF_no_refcount); >> >> Are you sure you don't mean MEMF_no_owner (which implies MEMF_no_refcount) >> here? And then ... > > Yes. I've already fixed it in the v4 that I'm working on right now. > >>> + else >>> + page = alloc_domheap_page(NULL, 0); >> >> ... is it really necessary to keep the two cases separate? > > Not sure. I don't know the reason behind the original code. The difference becomes noticable in the NUMA case, which is only being worked on for Arm. Yet that means that converting the original call in a prereq patch, stating the NUMA effect as the justification, might be the way to go. (See commit a7596378e454, which introduces the flag.) >>> @@ -1926,24 +2106,49 @@ static unsigned long avail_heap_pages( >>> void __init end_boot_allocator(void) >>> { >>> unsigned int i; >>> + unsigned long buddy_pages; >>> >>> - /* Pages that are free now go to the domain sub-allocator. */ >>> - for ( i = 0; i < nr_bootmem_regions; i++ ) >>> + buddy_pages = PFN_DOWN(buddy_alloc_size); >> >> Any reason this can't be the initializer of the variable? > > Nope. The end_boot_allocator() changes are a bit messy. In v4 I'm doing > things more nicely, moving everything in init_color_heap_pages(). > >>> + if ( !IS_ENABLED(CONFIG_CACHE_COLORING) ) >>> { >>> - struct bootmem_region *r = &bootmem_region_list[i]; >>> - if ( (r->s < r->e) && >>> - (phys_to_nid(pfn_to_paddr(r->s)) == cpu_to_node(0)) ) >>> + /* Pages that are free now go to the domain sub-allocator. */ >>> + for ( i = 0; i < nr_bootmem_regions; i++ ) >>> { >>> - init_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s); >>> - r->e = r->s; >>> - break; >>> + struct bootmem_region *r = &bootmem_region_list[i]; >>> + if ( (r->s < r->e) && >> >> Even if you're only re-indenting the original code (which personally I'd >> prefer if it was avoided), please add the missing blank line between >> declaration and statement here. >> >>> + (phys_to_nid(pfn_to_paddr(r->s)) == cpu_to_node(0)) ) >>> + { >>> + init_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s); >>> + r->e = r->s; >>> + break; >>> + } >>> } >>> } >>> + >>> for ( i = nr_bootmem_regions; i-- > 0; ) >>> { >>> - struct bootmem_region *r = &bootmem_region_list[i]; >>> + struct bootmem_region *r; >>> + >>> + if ( IS_ENABLED(CONFIG_CACHE_COLORING) ) >>> + r = &bootmem_region_list[nr_bootmem_regions - i - 1]; >> >> If you want to handle things low-to-high, why don't you alter the >> earlier loop rather than skipping (and re-indenting) it? > > Yes, you're right. > >> However, >> considering that in alloc_color_heap_page() you prefer pages at >> higher addresses, I continue to find it odd that here you want to >> process low address pages first. > > It doesn't matter if alloc_color_heap_page() returns higher or lower > addresses. The important thing is to create a sorted list so that min or > max are easily found. Having a sorted list means that it's easier to insert > pages if their addresses are always increasing or always decreasing, so that > starting either from the head or from the tail, the position where to insert > is found in O(1). If regions are processed high-to-low but pages of each > region are instead low-to-high, the always-decreasing/always-increasing > property doesn't hold anymore and the linear search needs to be repeated > multiple times. This problem can be solved in many ways and doing > everything low-to-high is one solution. Of course. But please also put code churn in the set of a criteria to apply. Page lists are doubly linked, so it shouldn't matter whether you insert forwards or backwards. Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 15 08:14:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 08:14:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443798.698537 (Exim 4.92) (envelope-from ) id 1our5C-0007Sd-3T; Tue, 15 Nov 2022 08:14:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443798.698537; Tue, 15 Nov 2022 08:14:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1our5B-0007SW-VM; Tue, 15 Nov 2022 08:14:13 +0000 Received: by outflank-mailman (input) for mailman id 443798; Tue, 15 Nov 2022 08:14:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1our5A-0007SQ-Hm for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 08:14:12 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on20625.outbound.protection.outlook.com [2a01:111:f400:fe1b::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7b47b186-64bd-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 09:14:10 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7181.eurprd04.prod.outlook.com (2603:10a6:800:12a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Tue, 15 Nov 2022 08:14:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Tue, 15 Nov 2022 08:14:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b47b186-64bd-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T/jzgcsWRS1HAo8MtPx+A2fqU6DvjAtEa2LHJD4Wl0oLcaJKAbK5N0rCNN8w18O9K7hcATZmf/nyHOS+VFyn1koIr7IrbTK5cZStpm6E6lb7eEQmxHScXDM8O+/INYPXGPkV14ATkHeTOJ5wBEkJrzBt3V2IEwMMky0Hq/2it7PtComRk3kXcCBj5lZAeUtk+fWAhK8wbIJPIgL9PI+O0N+HTVsii1szrRDc24UPdiYkJ5OTqNQECvN+K57QdKUhTCVY43pHRwvT9F1QDoGgEd5M9HfhjknZisKYtipyqDxUL0cY8y0hL5/iAggBq4hWhaytfydUkrULkuAF1Ewyhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9HBNiTXovtNWiPwUqgQjYj2iqh2e87mFpE3f4n77bZ0=; b=OBjkt/3ylOpKPe2/OTSW2VOI8aPVbYvttA5DShNUym7eNdWAjZTnUg0KT8u82XIoucs45SJwM1Z6OToOXMbck832SRJDivVga0S4352XsdBPpPQDSULnnlrfLoyfBdR9ZGIScOJvyGxnL+Db/MDFiJTiZ2CgcQr2DbsESj+7bp43Fyjl9yINPNXefTT0r0wTh3pYqP6HMyDbeVlCkPr5ze/9PsFB5V10dYr3gXZ4WtOqIXSdtGgCxItsw1E63T1i9yNyERo9jil2U8BmC7i8Ecctwk/dShGgWKoDJCc9dBAlBzWQ5N9np9PhOTRNAtlnMVHhqN2CsOcuLf4aEqrnHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9HBNiTXovtNWiPwUqgQjYj2iqh2e87mFpE3f4n77bZ0=; b=JFD/cvXUr3T8C8RlxEbiQXuzSgt204gJFt8ZxX1rvZgf3QxDmGcDHe8DORzHW4gGImFVebAGpYXwc36YVsD6fjPvEFY9taAF6a/aZxqVLqZHCvy9jp29FXodYZPjgL+NaVDt6EBs0NF+cG3DoYvWDgOt0Wd7WmMOJRE1Inv+w1Mo8IEL3aF276DARhTEQen1Dj40Z9v7i2SvdZOfwd60PKnZ8VsbNgrH8GEq9BjgpuYCivzGe/0lnw1DoSBOkkg5+PTRhL9IQi4qZglYA7TBIfg/pRYSb6qRyYY/8BexrsfAinTV1wVhN1a3fEhfyBm1wPjiajSWxlvjS/oq8J6smw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 15 Nov 2022 09:14:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" , qemu-devel@nongnu.org References: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> <20221114192011.1539233-2-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20221114192011.1539233-2-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR04CA0063.eurprd04.prod.outlook.com (2603:10a6:20b:48b::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7181:EE_ X-MS-Office365-Filtering-Correlation-Id: cabe90a5-e738-4d3c-aa31-08dac6e15f0d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /TIlO/Qk/itCzAhXcqzmrVMV9Y6eSbBL4H9ktbuB2fn87e3pD0wALEFkxe/fjsGk9UVMjX2gOFn7uPHPc32CSLc+ArYnZa4SjyUR3dK2MZC8DG31pgqqn1kYJNJICZK6hK+yM5IPw09RKmXZmqQj5q/6neJR5eyYWh9FyG4qdWhi8zn/IelaBcZXRjM4o9AFGEoenpZqxTVBmww6b7+ybUyMDPvQ3wdzfaQHvb70OnrgRfhydJDYI1XSRn5a0CZEyqOhJozO+nUxbLvCIs+uIge16w/TzHyOyXipVoQTnjKnuQhugPR9NZK9pQXgvk87FcKwec2O9ogTUJOWSgGh+eWYhkiBGmD91bLT2L4eRLYwERIhj4L6wu2XFdXJxgLt9aBVrmh43PputeBGN3+frMvdHl/ETHHaeTI86hggDiVYCylQFtxaFGjSnL3NCAjhK48RPCBPehYLjQcG+jIb6m7H4vyyJKuFtpr311REDQiuqdIckVwEqJ8jt4FbhfvHI3rvktuLuxmVTHHGZr+VuBL6jiLKoKlJybyIfGyN24N1oLzzCrlk/051Ow4T5szrrzFjrMhCCjmBhfPomZZYGQDKH2gSa9/699EcDmXyzclswi815H/w/33CjTUaZUe4NJuSxbTpvfBkythkBN2i9EzzZ0IFqCm4KeEVpn68O0gNWcTFYZSYZAJwA+xyYtkvsCSRg9mhBf92Rcrmp1UHMLZtbGH3z3ymROMVfCpqwCGjIDFxljPhSFn7d9hLlHe01TVm9QQjZ8DcRiBhisilvA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(136003)(366004)(376002)(396003)(451199015)(478600001)(6486002)(6916009)(54906003)(31686004)(8676002)(4326008)(66476007)(66946007)(66556008)(26005)(41300700001)(86362001)(53546011)(36756003)(38100700002)(2616005)(186003)(8936002)(5660300002)(316002)(6506007)(4744005)(6512007)(2906002)(31696002)(66574015)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?allsMFQxcXJhcTRSK3lXMXRsRTMzQ0NmN0dOVVFIcnNESzRQZTY0M2FaUkNl?= =?utf-8?B?bjVWbEZUQ3NZNGJpUFJ1THlGWjNZaXVKVk5wZFRFNFQvR2ZqaDUyQUdXRzV0?= =?utf-8?B?OFhQQXcvREU1Z0puNVVqT0YrSHRWamU4UTYzcG5HSUt6ZTg0a1M3bUdkekFQ?= =?utf-8?B?YnppeHJZU1NUbGhxZ0tHTmRnSlV0TFZxSkU0UjdYVnFFMkpxZjgwQjR6NU5S?= =?utf-8?B?SEgyQjk1b29od1hzZzIxQmNRdzY0YjBLRmFrT0x6U2lTNGoyTjFjbjdNU3pM?= =?utf-8?B?SXl4S1gvd3paNiswZTZJUGs0WnF0QlMxdUx4RjdSZW02cUVBM082SnYzY1Ur?= =?utf-8?B?Rzlya0lwdkR6Z1hxdzJpVlF5cUFHdzhQK2ZvSDdibnFHckN0WG5PYUloSGVN?= =?utf-8?B?bDVFT2plTEMyRFJydnljQjZMTkhYazl3TXR3VjhQMjRNUi9jQm9hZVp3eEll?= =?utf-8?B?VUQrWmIxQlh4Y0R6QjcyMWpzbVNCZU9EUHVJQVl4bUVyajIzTFNKN3UvNFhW?= =?utf-8?B?UGhQUGY0RTlvditDd2kwWnZ2NnJYaFlYMDQ5L1Azb0tldlJWaHpVWE1FdCtk?= =?utf-8?B?WVVnaUhmc09MZFlpT3JNSVlVcm1EL2ZlZUIwMVNzZElQUC91ZUIxRlJNejd1?= =?utf-8?B?VXZNWFZ3WW1GdEFxOWFoRkNpN2xidEtzbzJidDVOT1lZNHQvTFVPUnBUNDV5?= =?utf-8?B?bDR2aWszbVpRbmx2RmhYcVJObm01ZXgzMXc2dk9GTHY2ZndVaGUzblhqL2Rr?= =?utf-8?B?VUZ3K00wWnE4Z0s3ZkczK2ZFdTZSSVVnMjlMaGU5M0RpM1duMnQ3dDFGSkpu?= =?utf-8?B?azFuNDZoVGhaaUxFd0puUWg0emdCTDhMQ1M2L1dpckg2MGllc1FlbXEvbXlQ?= =?utf-8?B?Zzg5b2VGaFdrNW1FbG82dGMxRTFIUHZkV1RwZ1lCdW1Mem0rTmVOWURnRHBQ?= =?utf-8?B?MkRCNVRxV2lrb2VoMkNaRHdXVkh5ZVFzelpmbEU0ZHJNKzBKVkN1RHNwOVBl?= =?utf-8?B?RERoUEphRDJmbTQ0UmNsa1cyOC9OT1hHMCtnUG5lWm1XTHphd3lPRElOVGIy?= =?utf-8?B?M21yVHozTG9Rb0o3WFYwZW9yNW1HSGFndThIdnJoS2NoTlgyb0h1blVYSy8z?= =?utf-8?B?YUxLbFc0UWt4TDg3M0phTmswczNvdG1yRUhQOEYvUDVmLzRWUUtUTTB1U1VI?= =?utf-8?B?cHlkdWFnN3grSmlVc295WS85TGxkTkZydVZhQUpHRWlNUXZVRkxWU1g4dHdo?= =?utf-8?B?RE5FRCtJTGhQQjRyUTNNUWdGWkNjeDR6N0RRNzZ0eUM4dmFveW8zNXJrdVor?= =?utf-8?B?bzRQZGpLaW4ySlp0MHd2aEhwR1Q4QUIrQVdmdjVKSTFHTkR0bFJ4RlVLNUpl?= =?utf-8?B?dk4raEVUeW9ORnZMdHdMRzFJS1MxM3dyaDk1UGV5N1Q2Z1NLajU3dHh6emRS?= =?utf-8?B?YWNVREFIVGt5U2VpYk15d3pML1ZKcmtuKzVUdW5WQlZQZERTbVczczlrdVI4?= =?utf-8?B?RDJhckhYZnMyamhKRS9mYzFhMDRFOFFWTloySEgwUzh2aDJ2MjV0bW9qa1BD?= =?utf-8?B?WUlrVVBUUHAxR1NQZjc3QXpKeFZMQ09iMG9MUE8yUmlPcTNxMTh0V3AwVUth?= =?utf-8?B?ZTB2cE9LNlJ4amRETkdjZnBpTFR3bHczb0JyMG10MEVTZUkzanlnbThTMFFZ?= =?utf-8?B?cHM2eG1DMmpXbzdra2w1ZWpHRkdwUUhrbU5YTHp6L1J4S2p0Wm4wWnRKRy85?= =?utf-8?B?ZDVBSlFRTjBOamllMk96YVQvL3laYjZscU5PaDVpbzVyQkg1OWRvSVFPakRI?= =?utf-8?B?WlZwaFo3K1dtRnNlQ1hxdDFmVVJ4WnNnYnlvSGdrUjJQZitFU2FLLzg2bFZZ?= =?utf-8?B?aDAvMmplSWdUcnNSaGR2V1RhZ2pyRFhuNHNuK25DWUhPWFlScU9SWkdXbmNZ?= =?utf-8?B?aHVpT21CRmF4YWxSdk9GbGdZZHhVeFJWaVhybHhvSk9YVG9kTVhTWkJVakkx?= =?utf-8?B?a2lWZE1OeFg0Q0NSSlZ2MXZyNWlHazVTaHBZZ1dtYTZaUVlma3hjbFlZR2NO?= =?utf-8?B?SFJsbHF0TVZhTjdRTk92TGlDNGNkSmIycjkyVUp2RkJ3T0dFN0I2dldQMXZp?= =?utf-8?Q?4aVcwTe6/b/lY7nmQzyngoHmn?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cabe90a5-e738-4d3c-aa31-08dac6e15f0d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 08:14:09.1956 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eejE3ONt/+Z19MDOdk6n4W+D9ie0rVwNh6s4OrLWCzDTMThlky0HykOyIBGhKjLOqmOc2gmdJ+Zw/S1AVtV+wQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7181 On 14.11.2022 20:20, Marek Marczykowski-Górecki wrote: > The /dev/mem is used for two purposes: > - reading PCI_MSIX_ENTRY_CTRL_MASKBIT > - reading Pending Bit Array (PBA) > > The first one was originally done because when Xen did not send all > vector ctrl writes to the device model, so QEMU might have outdated old > register value. This has been changed in Xen, so QEMU can now use its > cached value of the register instead. > > The Pending Bit Array (PBA) handling is for the case where it lives on > the same page as the MSI-X table itself. Xen has been extended to handle > this case too (as well as other registers that may live on those pages), > so QEMU handling is not necessary anymore. Don't you need to check for new enough Xen for both aspects? Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 15 08:18:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 08:18:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443801.698548 (Exim 4.92) (envelope-from ) id 1our9B-00084O-IK; Tue, 15 Nov 2022 08:18:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443801.698548; Tue, 15 Nov 2022 08:18:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1our9B-00084H-Fk; Tue, 15 Nov 2022 08:18:21 +0000 Received: by outflank-mailman (input) for mailman id 443801; Tue, 15 Nov 2022 08:18:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1our99-000847-Q7 for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 08:18:19 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20601.outbound.protection.outlook.com [2a01:111:f400:fe12::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e3c9640-64be-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 09:18:17 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7065.eurprd04.prod.outlook.com (2603:10a6:10:127::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Tue, 15 Nov 2022 08:18:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Tue, 15 Nov 2022 08:18:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e3c9640-64be-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H3VGKP3/qvSHQ7PGlzUoT8LFU+CDpyI+noDJe++8fJCeBGdkGSRjIFiPdtd11g3g8yswJMwDtiv9ZKT9Jv9US0DmFFx1TDaOxc4c1m0GT1Q2zXcbjpQ5pRz4ihNH+MTC98r+ufXwvpYAL8UvFVGpekwJXhdULuPzmBznNgryQ2CCS68bvODnp7Qke577P8HAINuzDXmw5D2vQU80V9hJo8j7PzPoZpPgbPStGpZgT5TNRGSc7OnNJ2hID/a7wLrug1HWUR4AXg4OmPP0BxyoxA7pocOFa5gWfDnVkkWLXxhGuYJD6Xev6xGk+TmKPGU+qeToM4x0aGoPjGfZHMZK3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QKe7cY5YBNTMfZzpP/m4oJkvkK8RzF4ZUEE1kAjnFPk=; b=BZd6bphX6OpTlO+hj37uwRowujVQtIyZi8TqWG9Xr4kfyFkb7J2V3DhUkbyTzO5BvoTgpSaetmz5vbpHB2HBx8bxjGfOqRORP/uxwH87f0u4gTEmBvUNXia2pxCvpADbEozBNdEjvyMkAq3wjlF3fJPIQGDyX0OK2Oi4uNFHkwbwHU2+Kge1rx/h0PTUPeSGnvM3HOCIV8K4ddYTiucVAvNHIiRRn7td9M27ji36h9LVeWjsaUT96JhyYozDUTe2+TC3O3vZ2xvM2uKMYAUXrT6OZYgrT51gueoYEhvyJwFxyTnoQJAczhIfd+ZSTOCSZnnIRaa1kAophBIYmoMPxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QKe7cY5YBNTMfZzpP/m4oJkvkK8RzF4ZUEE1kAjnFPk=; b=Kck/3HzqZNVDB2L58K+X/HjoSaruAP4+j0dOyhMaUk8KFPUzur2T/FP1/sO7U9hrppqdFcQOVg+eLLR/22CAQ9h8oVeLt3dV8Rpfp8UkvHjuv3S4Xyf7livXPJmqc/FGIir45mNQI6ARINC1VPX9SfoA6e8C+yQMGNez1jw1JzNhxxzfOkkEIgKqFT+/4kE6E7N1QwNqPzYw0UFYmo/hawnYBkQX+GNwLohbG7bvDKX3dgdJffhBK/UZR09jj/GTJUTfR8uAtL4oPiBih5aQSQzUXIAEoERxTCDuVIBuedl3B6dFzeqqz9xwMyLV8B4O9g+LPiTdEwYLu9vr8Y5s0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <780da682-806e-6ada-eadb-018579d0e808@suse.com> Date: Tue, 15 Nov 2022 09:18:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH for-4.17] x86/spec-ctrl: Fill in whitepaper URL Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel , Henry Wang References: <20221114214358.17611-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20221114214358.17611-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0469.eurprd06.prod.outlook.com (2603:10a6:20b:49a::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7065:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b072397-b2c2-42b4-af2f-08dac6e1f27d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1wH0HqJKhNfGVqhgUmSrNKOfEfmkv86ByR8pOi+cVS3ZWh778a64ePwZyl2t4xNnMbwEUq3PnGUFvLwF/3Q+Wzqtz+tjTD8V/ZhlpTqydEVjkykc6Pb7t8Zl/L5j2u39HgvbOjnQv2XiMpa0bGR22wzQpffTzOTKKCVoVcNtYNIpcZ4J9LrLogiR3X728+ZNwBkdeY0ihZudZZS8KNxYU83IE3bZy/8fWvOujnBU2gJDTib65k+JZgtx6jlBs3OolI5YbFg2XkG3LDHTqj0Q5QZ+PLfQhMOztJY+2gBi+py8+Ec1ggPiPMJ4ccx2JsdJjPGvEnRVFa8K2rmfC7YxOnutwhdgoNSBN/Gj/6jejSg7ychFpjfIIFNdW9y1J6w/l70Ykt4D7shG30PywG1zLeDviIErr8jKtlXkUGxkWZ7pQoxwpjX1yqYPAQIOWHdO63ouUmerZpc/bmbIGF3uUfbOE5+3umjThgYlSNVwK8OwXJe16pMV9lVIjyPN7VJtZPdDzq7cj2/cboqlvNozIXV7vWvsA8yvQaEJDpAoXOhYIIoNQmqL594Ws9aQ7Bu+pYFVfS/xOztnmSON9RRd+TzL/D58ebys0TC9TBDW13jBOqBKW/uVafoMww+wbDpVJPXv5e1HC5nPiuJ7kIYwHG2CJzLpJPQ+PNjBah38ZqS9D5SfCZygdz+Vx3A4BVdoRTRqamPf1cQ11TKYXj12CMGgzgauqjmRugOk7QwE3Nq+AoJ19nAGZISnClx/65zWDAYp/E2/EA3W6cV/cE28A27/N/W96/Sbhnie9n8O+rU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(376002)(346002)(39860400002)(136003)(451199015)(478600001)(31686004)(6506007)(6486002)(6916009)(54906003)(31696002)(53546011)(316002)(66476007)(66556008)(41300700001)(26005)(4326008)(66946007)(2616005)(5660300002)(186003)(2906002)(8936002)(36756003)(38100700002)(86362001)(8676002)(6512007)(558084003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmZkSGd2bjVKeE1VVTJidmtWMkk1RVNJUSs2YUZlZlVhQkVkMUJWK25pdFNF?= =?utf-8?B?L0ZVR2pTcmFuWnZTditpSWhyQzBWOFBKZDk5V1ZCTCtjRXdJRWlJNVYwQ2Jl?= =?utf-8?B?eDlxd243Zi9VYVlUSU53RE1keVNOVnBnRXN3QS9PUzFQWTV5MlRTVUtsQUp1?= =?utf-8?B?R3FtaHJMOHZEV3MwcHBrcFQzWkE0UlZqSGxzNnkybG4vUzJkZFFqdkJsdG9q?= =?utf-8?B?NFFQdnU3OWNaRHdSNGlUb1FKWGRpWTBrVm5Sc1BpcWtWWTRaRDBtTlBkMi9p?= =?utf-8?B?enIxQVcrSENGa0J5VDRqTEZiR2VvZFNoYUYyaGtua0IrUXprbkwzR0NZKzcw?= =?utf-8?B?RjdzSEpCZmc4WlNoZ3Y0c0hnRmxia0ZQRDlkaDNmVFYzRGR4NVhmY0Q5dTBx?= =?utf-8?B?YmdRdnhhOVZlN1R1cEFwdDlMTU9yZ0Q1VGlCVERLc0VqSmtHeEhOMEdFZTY3?= =?utf-8?B?S1R4Uy9nY215NVYya3lDdldmaFZYTHRYVkt2V0JQaElBVkVsZ2NuQWdoaHhF?= =?utf-8?B?VzUyLzdmK0JxUmxtb3ZlWkpUQjZheUUydUMrdDNQTVY3MmFRcWR4NDBySVlH?= =?utf-8?B?MFhzdS9IS3JLMEIzRjBSUVlaSk9jUEZCam9aTE4rMEtMNjFyZ2pzSzI5eXBQ?= =?utf-8?B?TElFM0R6L0VZdTFmc3l1eWRrL3NURWJ5QXNDZFVmQ1dWSjJjSVM3RS90a1Rs?= =?utf-8?B?Rkhtb2p1QzZWQTl2RzI5ZUg0L2R5MXA2K2pxOWZnZWUzdGpCc1E5YTc1WlhM?= =?utf-8?B?T1MwcURDUXA3S1VLZHJxc3pJVzJnMW5yaU5KTVJNeU5QbURpQXFBSW14ZklX?= =?utf-8?B?YmkzR1ZwdTVyVHJWOEVpNlJsNHFReFczUDRSTUpNbnhLcHNTWUZ0WlB1ODE1?= =?utf-8?B?c0p5YnZtMUxsLzg4dWlWSTg1SGJhcnRuck1ENFBUVk5YQ0xsdE5HTEtjbkJC?= =?utf-8?B?OUplckVTU1IzR2lQMXl0WUZscU16TnB0TUNaMm9KU0l1ZGhXM2RFL3hpeTdG?= =?utf-8?B?dUhwbUUrQTBmT1Y4MXJzc0lhaTFpR0h4QlR5TkJxZWdQaUUyVUwrZFFkY2Zq?= =?utf-8?B?K3FGbWFzTjVWNU0yK0xTTlQ5bDdkU0UzQllaL1U4QTVqTlc1bUhPTUk1QmhV?= =?utf-8?B?V0xGc09VTkVPQUJwRVEvQkRiYlNrQldEVWlvb1E5TVNQVzVka1lwaGJSWTN0?= =?utf-8?B?WUFySy9FQTRFbHZXOXlvbWYrR0UvRDQyd2xiTTJ0bEFsVDBzVlg5QnJuT1Vp?= =?utf-8?B?NG9QUXNNUXZYRWN1dWdtZHIrNm9UdFp4TWpmUllvSFZwQWVBeEVmdDVHd0Fr?= =?utf-8?B?TXJYd0tqYXJTWWZWcTRjemRHQVp1WVBMaUlCMVlqMEpqZFh3b0xGWU02dDhU?= =?utf-8?B?NjBmNFpFc2JtRit1YUE5N0JMVjFTSFRmMit1cThRYUNjenFjcUVUejJjMzJj?= =?utf-8?B?QmRuNnZiRGNyK2FQbXVtK1JBRlV3N0NzUnRFUTUxQ1BlQVczM2llcFphckx5?= =?utf-8?B?dHZMVm9pem5yUHF3UmZkVmtNN3NWQ3BHL2xRTnFSZHlFbVFoanB1UGpoZjBw?= =?utf-8?B?QUc2NlFBYUxPb2NEaUw0d1pOT0k5Rll5MkF3UGtWTzBRU2k4NEdoL0RBd2Jh?= =?utf-8?B?YmZWQkxaTUlBSFd4akFQNUhyYnBNYW1xb1JBSlREejNvYy9zTS9WVjZBVnFP?= =?utf-8?B?WGFUOUw1b1ljL2RjdEp1YzVEWkZZRGxWQmpUSy9zaFpwdFdpbFJ3OHZrUnhu?= =?utf-8?B?S3BZaWd3eFFRVENpSTVhWEdHTjRpdzZCbUVwMW54YzhyeTVNS3pmeVNsSHQx?= =?utf-8?B?SVNzUXVOMmI0dmdqU09ZMzNqdGViSTVSVmVFdmt2TGFaT2x6MDJSYm5KaWZD?= =?utf-8?B?RE42MUV1cDBVczlNcmZJVitCRXJyNkNteXcyaDJ4TGlBVkJFU3dYZ0tvaUlk?= =?utf-8?B?YzNmNFFrWHZsODdrc0RhZ2NnZ1lxY0pwK2wrR0VrNjMyZ2x4QjFFbkFQOGpm?= =?utf-8?B?cHVFUE1ZU1pBa1pBcUlLa00xVHFEcXp1WWpVLzB1eE1wcGNIRkV1bUVyb0g0?= =?utf-8?B?WVpBemo5RHhYNEtrcEtTdUVVS2xkSXcrZ1lqZ2hFRWFyNS9MNFJZTDFFOVln?= =?utf-8?Q?y9o39UquZPQ6U1rcdcB0uNkT5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b072397-b2c2-42b4-af2f-08dac6e1f27d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 08:18:16.6017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +cXWpwWriYsvpHKim2pemEBXEJB0ByNqCi/dkS2UUlxNcZ2nBdenwLcq+LIYk7/eo6RH/Kzrr7SsSaGZTfD0qQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7065 On 14.11.2022 22:43, Andrew Cooper wrote: > ... now that we a link available. > > Fixes: 9deaf2d932f0 ("x86/spec-ctrl: Enable Zen2 chickenbit") > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Nov 15 08:20:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 08:20:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443806.698558 (Exim 4.92) (envelope-from ) id 1ourBK-0001GV-1N; Tue, 15 Nov 2022 08:20:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443806.698558; Tue, 15 Nov 2022 08:20:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ourBJ-0001GO-V0; Tue, 15 Nov 2022 08:20:33 +0000 Received: by outflank-mailman (input) for mailman id 443806; Tue, 15 Nov 2022 08:20:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ourBI-0001GI-KE for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 08:20:32 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20616.outbound.protection.outlook.com [2a01:111:f400:7d00::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d8f4694-64be-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 09:20:30 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8530.eurprd04.prod.outlook.com (2603:10a6:20b:421::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Tue, 15 Nov 2022 08:20:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Tue, 15 Nov 2022 08:20:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d8f4694-64be-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n5L4dZ6qYj60G0j129Wqb0SvPT+WySyz7baDw0CcHAIsBUS4E38By588TfJeh2Zn9CS2cUEX1JhMBKLsmJIebcXGW3ufjhJvyasSydNSNCcuS4+9lb40ptFvLE94nHnBhhTnBiADzb3tZcpyLhBziuGPI4k4OpsXl3mNPX0DL/zIUogNiP+LREyUHZLYQAHRi40S9lLq5OLqZATlVChfGDfRPNFsaDK+rfDZVJixZ0rFJGBxysYANMOhnMkycRTPGPhrHll7ZNI+LhpexyGNElxPKJq7YXwZDSjK6tLY1j70Pl/tLyH0e83S6RBt1czvCBkPkOoS42zOf6YS3dsu/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6NrMQWQpsJWf84Jjz+ieaDYt3V1RLtE/GIc6r42vWaE=; b=Y8/DUcHiP9Ip7f2yyQAPkNH0eB74Khz/nzCU8oGjiZdUY9XbvQkQ2sNyYoVR75ZbB0MvCXpPZS8DJmPcPlg/dHrgewjN4VRlpCsVE16hHTpT4Jlg1pmxR8ecPmJevhRl2SYHZWe6WBawJ4wD1ec4z1hwtX3SGVeyGBlLpMEqcUXtTZaKjT/stBPm2jI++JG9aaIjwMduHJmiuPfF0Vp8co+/vb1LC+PKqZa/5M5dt0LkpxmL6THhrsF4KTrGIbhWXize8Bu1dqZxQlk2TQuUXint5fAoSfAsMJWdZdeJz3/JbchJmzZ3PfjQAz4pPzfhTEG9qf65u22kcck4BBP+Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6NrMQWQpsJWf84Jjz+ieaDYt3V1RLtE/GIc6r42vWaE=; b=1qLfCUqTqd20RoNVBtHseYY09hsHe91JQFBCoYuTG+BOVLlcD0zVT8FzkOjqQT1tsV7yJpwl2NUTsx8e/WVoRwv2xkFKmJARhVf36PALEthpIjcMYwnfAkiVCRqc4xzCkLSSE+i4gR2+hQWBAz727QOPMblXmSy1jomta7Idk6nf/kofn4X055Jgm+gIfItfYrg4ijXfCNvxsXSZWyWjhnjuL8AD70snARjNFF9nxoLVU21qHddsnyFiNt2LWUkDXAuh5MrvAKMu15uhBYpO5mAIbH50x72GurniwcQufydmf76eLURLMB949SBftti95B+0tTizrZFwl2ou6VXx6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <871defd6-be9b-4e6e-9347-3788265267ec@suse.com> Date: Tue, 15 Nov 2022 09:20:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [linux-5.4 test] 174765: tolerable FAIL - PUSHED Content-Language: en-US To: osstest service owner References: Cc: xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0136.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8530:EE_ X-MS-Office365-Filtering-Correlation-Id: 76146dd0-0a19-4cf4-6135-08dac6e2414b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ygqj9utIT5zPoPkyMezUYu2YEtkUGOnwfv5FwpJ4ZP2+Xi4h801qoPjhwz2p98SlztOICx8bDos1SGuDamMhS2WhPzRc5Kajf9LytaTbh7JoSAaIOoy5ppq05morP9tFM14qqX1OelHr75zwAQ7glvXZnnnIBVGYaxeaCztQj0V3o9e3klI6hVaLJXyVUMbEDk5Mu2cn8R3krXfKOpKoaCC4RTpTp+DTLY+gSr9ZW/DEqqUbHRsEvKqg2/AjCjBJ/J26NytsZZHJvQmPiy396W/MOZWKaGVqOh4bmhIABSATU+ysNWhmQ6sqjPVgil+d7wF8FrNr1J7Z3GxRPulhEie4sUN5em8DVWnA9L1NSet12O66fvk+qMFcElxpXL+eZ3CeHkFQQ368e14Y8hVOuP1Qsx9L31oSCLuHFKbL/xLm5YSmccdRfA5cDguJuTMgclVbPso96JnSRIY1AOJXxO0USNBLH3MCeiqpNBzL3CCwL55MY61k8Ip8lMM2LNDEw64q4cEbm8tDJP0m44Qapb/d23TSHUyqQzFyD6+CoYMJ4wKejcz1zlJmX3+BN3CFfmzb/bMev+wVPEkKjjxHGo3iOFwibMPKfsrMcFGga6l9q87TyjLhHOGV4CE0xLmk6fpuh25l4NFFMdiLZyn9W4niqsaExrEX0Pz9kilcH/7iLZXLGq2xePnvrisaAkwHhH7IwrI9Ym17zh5ukdSPBX84p3i+uaG2GBE7mUx3JJ483ps4zpKESurtwA1wjtXDKxpmGhzKrcZKCemTKS3VgCd2oHwIQZznGrf1b7vOxNc2kxj+R5tnk8Rm68LQcU0lRjXfPC89Q4EksExZxgcm51orvqm9Z2AezYanYhvYQ5U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(346002)(136003)(396003)(39860400002)(451199015)(31686004)(86362001)(31696002)(36756003)(2906002)(8936002)(38100700002)(83380400001)(2616005)(186003)(6916009)(316002)(478600001)(966005)(6486002)(53546011)(8676002)(66946007)(5660300002)(4326008)(41300700001)(66476007)(6506007)(66556008)(26005)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2xDUGhPSmg2dEtUZmpxZ0dZK1E5c2E1RnRXbEY3bStSMmw1MEZFNTVQTWFJ?= =?utf-8?B?NCtVek10angxdWV5SDRWcTk3L0N0d3lUdjRnK016eUJKVTljZE04RVFIQzFO?= =?utf-8?B?TC82SVJsOWFjUFEveTZVaDlaUllUdndkRG52TGlmSWR4b3R0Tnl3SHdYQ1Zn?= =?utf-8?B?ZndYNTgwekREOEozcjlrbTZNVElONDRwTnFOd1RvWU1zRjBMMVV5c3M5T2Fo?= =?utf-8?B?dmlQckZVREhPWnhYcDRGVVRTNUZUMDVHci9teFZSYkJoUmxSRkpSVG1kUVRT?= =?utf-8?B?bElKWm5uaVRsdUhNZ012M0twRlF0YjNQbm9xaHRWYi9iS0ozaDAwS04vOTA4?= =?utf-8?B?ekRjMWFQbTVnd3B0YTJjVWtsT0lqaytRZVZvemZuQURqdG1FRnBGekxjeU9N?= =?utf-8?B?ZTl5OFhGZUpUR2VXa1EzY2tHamtEVU1JeEJQRFRpUTNYM1MxU0U3c0RZTnFk?= =?utf-8?B?ODRuSXprT2E4VUN6bnV0RE12TjFYc1hQbitYMHhrdDUxckp4YkRweTJUVWEy?= =?utf-8?B?WS95VDEzeW5RWGk0QUpBTU43N1Z3MTk4Y3FGYjVTNkxKdElhdXEyWWFOL3JF?= =?utf-8?B?YnZIb0ZxdHo2cUN1RlBIYy9yMUVOcXpZN2F5SXZ4RWVBK2hCaS92OVl6S1Ez?= =?utf-8?B?b3dKdzNOdGFDK0Y5UjloMUxyZi84WE5hN0R6ZmE2SThrT0RmeGl4ZWx2SEhL?= =?utf-8?B?V29weHdFSW5GdmlwZHV1VURoU3U1cURpNkdBaWZZWEZnd1pYOE93N3ZHN1M1?= =?utf-8?B?MGNUM1JDcm9WUnl6N2dGS1Y4cFRYb2JPZ0p6S0V0dm5QU3JLWnQvWCtRSCsw?= =?utf-8?B?RSt5VzBzdlVHQW1JNHlQNXFVbmFWTUFoTXI3bks2RWxiK080UC9VbXdnOHp5?= =?utf-8?B?UDdabEFkU2tBRFdEaU5VZGRIbTBWci8vaGFYc0laYnJMNkdobEVSc2FEV1VX?= =?utf-8?B?bFQ4YndCZVliZ3k5L2NkOUtjWVVqdVRjampaaFN2cWVuL3FGN2RZWXRtWDJz?= =?utf-8?B?S3I5blVKYVlWZzVLdEhENFVPQzhmQWNKQ1FTWHFmN1AxSGxGSC9UblZmN3Jk?= =?utf-8?B?SEJUd1VYa25ibWpmTmZ2YXhqSjJKY0VUNWJlNnJhRHJ6a3JXeXF5dmRMNUVQ?= =?utf-8?B?VTV5bTRVcStib3loS3laTGtqK29JN3FvaVFCeCsxcURLNUwzTTVLSko1T1Aw?= =?utf-8?B?RitBTGNGUUl1c0tuT0Y3RFhOM3NPU0lBa21UblBFSkhWSksyV29tcm4wNlh0?= =?utf-8?B?bmxNZjdqWnJmR25GVmUvVzZCOEVveEttbld0bUxOK0hHWlZKQ1ZEalFvUmw0?= =?utf-8?B?azNjYVhrYkw4QWw0YzFNT2VkUzdBNmNlQ1NCNHJhWDJIWi9IcXlNNEJncW8z?= =?utf-8?B?Z0duVXh2T1V4akFmSWpWQjBFUVZ4ZjFzb3RaL0tpbnhuWUVwQnNEWTZ2WERo?= =?utf-8?B?K0FxcGJiSU1WdVkrK0VHemx5ZzZWTC9CQnVVaUdyLzB1cWZaVUc4Z0haekgx?= =?utf-8?B?eWVrUXI5SURBUHk0Q3V2SmRpQjZWUFBQVUhoUEVMRkJTN0NQS1Nyb3Zhb3Yv?= =?utf-8?B?VkY2OVJYT2dEYUtmdUZKdVJ3b1hwREx1V1dSSkZsUDY0dUIrSlZWQjY5UHJP?= =?utf-8?B?WDlDMkhKN0NFVXNEcFErV25zd1ZaWkNiMEZ1dzczcTlhY3lvYkh0TnRtOGVk?= =?utf-8?B?YUJyMjRaRXpiZ2R5VEVXSXNGN1V0cW1ZeGpxNlVIdVYzQkFPaFRueHpwV2Nx?= =?utf-8?B?WnQ4NEFtNHhON0FRK2IrL3hjaTdhRFZLK0o3Mk5VaHEwcHBxUDRxb3laUUlS?= =?utf-8?B?NnNZQmhkTElDYTIxMy8rbVRCbFo0VFhtbTNYYnJZVVpXNHBJRERIdWwrWXRJ?= =?utf-8?B?UmRLY3dIQ2haZnBjY2R2c1lycDNXd0tPdVVIYW93dWVwNldQSmRXR1JHY0wr?= =?utf-8?B?RWVvUEE0SVlUcExDVkU5Nk5lbTJnazJIbTg1Y0txOGMyWmxqYUZuenV1dTk1?= =?utf-8?B?aW03M3ZNWkl1WXNkbEZ0Q3VxaVBINTJ4bVc4N2FBZS93MWIxbzJTSHhEZnAv?= =?utf-8?B?YkdEUXB0VHluUXVPTSt4eXFNZFdhL2NTQ0grZGMwT1g3VWphZDBzQ253N3ph?= =?utf-8?Q?L8L8BydFtoC5N44YsSAj8LsXH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76146dd0-0a19-4cf4-6135-08dac6e2414b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 08:20:28.7651 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cRvcSks2UMKlqBuI0khaSojHWdZ6HOtNr8KWXXzxa2uxSBEQrthM8vr2CSLmEIJPn+Fe+Rf9sJEhFChg9DSqOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8530 On 14.11.2022 20:09, osstest service owner wrote: > flight 174765 linux-5.4 real [real] > flight 174771 linux-5.4 real-retest [real] > http://logs.test-lab.xenproject.org/osstest/logs/174765/ > http://logs.test-lab.xenproject.org/osstest/logs/174771/ > > Failures :-/ but no regressions. > > Tests which are failing intermittently (not blocking): > test-armhf-armhf-examine 5 host-install broken pass in 174758 > test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174758 pass in 174765 > test-armhf-armhf-libvirt-raw 13 guest-start fail in 174758 pass in 174765 > test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 174758 pass in 174771-retest > test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 174758 > test-armhf-armhf-xl-credit2 14 guest-start fail pass in 174758 > test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 174758 > test-armhf-armhf-libvirt-qcow2 13 guest-start fail pass in 174758 > test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 174758 Wow, that's an awful lot of recurring but not entirely "stable" failures. I wonder whether pushing in such a case is really warranted. Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 15 08:22:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 08:22:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443810.698570 (Exim 4.92) (envelope-from ) id 1ourCq-0001pG-Fb; Tue, 15 Nov 2022 08:22:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443810.698570; Tue, 15 Nov 2022 08:22:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ourCq-0001p9-BB; Tue, 15 Nov 2022 08:22:08 +0000 Received: by outflank-mailman (input) for mailman id 443810; Tue, 15 Nov 2022 08:22:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ourCp-0001p3-M7 for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 08:22:07 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20611.outbound.protection.outlook.com [2a01:111:f400:fe13::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9689c079-64be-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 09:22:05 +0100 (CET) Received: from DB9PR02CA0003.eurprd02.prod.outlook.com (2603:10a6:10:1d9::8) by DU0PR08MB8205.eurprd08.prod.outlook.com (2603:10a6:10:3b9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Tue, 15 Nov 2022 08:22:02 +0000 Received: from DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::1b) by DB9PR02CA0003.outlook.office365.com (2603:10a6:10:1d9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Tue, 15 Nov 2022 08:22:02 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT031.mail.protection.outlook.com (100.127.142.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Tue, 15 Nov 2022 08:22:02 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Tue, 15 Nov 2022 08:22:02 +0000 Received: from 64be351efc58.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0CAAD31E-BF0E-4F00-B712-53BAC1465370.1; Tue, 15 Nov 2022 08:21:51 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 64be351efc58.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 15 Nov 2022 08:21:51 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by GV1PR08MB8668.eurprd08.prod.outlook.com (2603:10a6:150:86::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Tue, 15 Nov 2022 08:21:48 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::b62d:6e04:1c26:6684%5]) with mapi id 15.20.5834.007; Tue, 15 Nov 2022 08:21:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9689c079-64be-11ed-91b6-6bf2151ebd3b ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FI/sR39bA1hnhzgdPp8tH+L9WZgmMiO3pYo1Kog+KG36nR+yCfVkdKNRw7hDO3ixYf4wbEbEKvORoQadOiRuDeDTHLPxyh8mbdOrQhxYeRNT5T4F+uchf+4api67PRSAH63YQ/++4K9GDw99uyb9zqsDNriMpW+kT18aSYNd3sfMEGrpJScXFNuz/XVU24V38OoGWfvCEPALOefFmWfos/+4MqRqsQQeOWA9eKy+TJg8ePsYiJ2YW2thaJc+XYlF8l7v70QHMFYkqNdco1YyeQdX5GrXN2u6ZEi02oshcX+9ILvg7kcqq3JXlg0x8FY+V5aAS5zPIM+gzmdu1I3WIg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HuN8PeRhwU2sDVpej8Ojp7v/QgD8TvryK79101JFIY4=; b=MoAcd+e6UHHKy1goFFznPdSebdC+i5Azkez8kQuU0kzBeo+5UvNfO6Ulx2xGa2gtRt9FB37LJP73zwSxHDFCYoHnexN1vOkBt7onbTIQjTQdcFJoe0qUG9bfoVvg3T6wx3v4bxjCnsNzJKjx67hTheccsq4MRaGjIST0DNhkEwRqGMsgvsEHeDWD2lvhupJqAtvjjJMV0mTC283lylpomZ2L6WQ0BaW6Z6pI/ayoLrpTJm7NOXhx3ymiZ0x527HtUEdm8NuiwTIqMfhszOEutztiVwinGVzKmOKLvIvtTnG4hvK5+hMBGjPjrg+cmXxhTIOpKgPvjO2ymP7wLM+bEA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HuN8PeRhwU2sDVpej8Ojp7v/QgD8TvryK79101JFIY4=; b=CMOkFWz2cnj4f2CPHQZjhy0GnFrnrv5GMiO8WmnpxPOX+JQt09zhFF0jPNt/2We3eHRczhL+s4GlopBi7icLorl8haO8m5brj/jh23Ta6c8qaIBlvQlATy0cnUIC+Tc+O5HDqxyfUETZO2femjI6uS1KCAIeNTbKhTPGm1+rtUs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 051da04accd6d662 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZkgjPh2mjnS6mOMiTqfpGqGttX96d2gr49dYpFddE0fUpkknUlE55LDFfSFWDPvNKRIr2drS4Ta/VbQfMTI9Vqoki8ih+3qi9Znu2t5d1oNNTr0fotjiC1/cIg8NMPNTSstCUUrGThQZnVDxUKpjB9uDf/bjz5lBdtFxT2tvJA6AWt+vct5b4VjvaqOru2jeE0f4rHx0o7EWSgMQnugTUHys8jRRoo5SKg0XdPI5xz+njtS5hRIbxx5n74QmyWCVX3+M/ivSF9j1XEBRXWm6LBOk5a7Q71vtiNLK1vABekjdqmNBOLhd+3PCAQXrhzl7+ABW6QzNg2OgIufVrDQeuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HuN8PeRhwU2sDVpej8Ojp7v/QgD8TvryK79101JFIY4=; b=bXt0BX1aZtjTfnwjW5/cBJvLngJGBJy0ColF8EWeDK8dnkidt5uFhYmLJlrmD8Cxn7tGkdy/3A2hotH4o4wDtNf4R7rt2UlbIAUugYPXPpaMKzG9GvT9yzGtB3wFV6VQ0QSMvwk/ubgxnC46vJrHIBM8VO/Tph/taLWbIt9u7HEDOZT+sT1nYiODvWxpHeSTERGJlIQMs/AYPrg/voOtehaRowJhDeukNTcfUTMOpuIEFUgZXpLSKeY6Vi5GaN4rpkZXWAw9U0ZEk7u5AZIAWx+ZUl6UwArMFkMY8/AkxZV32qOh0d/sTnmOdvPknoEyihpya8RsofKoLzSWtFWmcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HuN8PeRhwU2sDVpej8Ojp7v/QgD8TvryK79101JFIY4=; b=CMOkFWz2cnj4f2CPHQZjhy0GnFrnrv5GMiO8WmnpxPOX+JQt09zhFF0jPNt/2We3eHRczhL+s4GlopBi7icLorl8haO8m5brj/jh23Ta6c8qaIBlvQlATy0cnUIC+Tc+O5HDqxyfUETZO2femjI6uS1KCAIeNTbKhTPGm1+rtUs= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <6918f382-e818-dd37-4088-4d73613d72bd@arm.com> Date: Tue, 15 Nov 2022 16:21:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v6 03/11] xen/arm: disable EFI boot services for MPU systems Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: nd@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221104100741.2176307-1-wei.chen@arm.com> <20221104100741.2176307-4-wei.chen@arm.com> From: Wei Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR01CA0183.apcprd01.prod.exchangelabs.com (2603:1096:4:189::16) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAXPR08MB7420:EE_|GV1PR08MB8668:EE_|DBAEUR03FT031:EE_|DU0PR08MB8205:EE_ X-MS-Office365-Filtering-Correlation-Id: aa6b8130-6113-47c4-99f5-08dac6e27904 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: aTyvtD32dYlG9mLhlrSo1FrasqYFU445S3jqyk8X6yGLwGW12VuEf3NSFByzNz1Bsf/diW3zpd977s62FMUVvAoAhbzmQbXViYBLtW1T4DJzKAh3k5d3vX/CwRbtQHMuxEnBpXx04qr+jjs2dnkIL/SLnoy58mw3HU6M8uN23xYidcbJooPzYeoL6bIFIhFkIq+Sn2Qo8klAszZN6YLczOLyKpxWqs+1J2nJZ44Q5WUVOkWVlu8fdbcm6WqWNtwgdF+JlGEMb4gDilx9TROT1VdLWMYajQqqYn/Yafj3TiNgt9tiC+UQVQnAwJ4N+QKmTa/kZc6dOSbcTXe7DOVjOYWWmjlbu+iZDIQLTRG/o54GNVx0iJtrYHQuTRFZijXAhsbvzlR141NIEgOBcPosWA1SRkUO9HIvLLIk4lLFsk5ymKIv0BQkLG6ZC8V0jrEVRA3TBWngBDtlqOfEP3aNzQ5OIdBY5qBbzXzqZjMhuMoPxWg1Zym1fQEEy2Zwiyv+rBUIHJwyIMyJ7emZ1vXerUfXStsLxNcyybjXku0BMJ9+3idZrza+Rjjr/YUhlOPfYY3GNEB9PNlqXKFnER1sPef6FBMJoAPMCMiwjFWGdUgFEuYNYqsCUbxsa0USuTz/afVnGdW5/vdqOtNM4VGaAPL+oL73wK8fnbt+8yx3nNYnadAE0nqUx5UE9JUNQZ+FCW6Xnby9l4QrabY5D1KM7HkGj81oQB5TEYehOLmUUoX5f53ZlGEhESQlMS3o2ktlFprNI7kupjAzNMv4B0vGbXlI0/jXeeiUZymn3Ta/aLc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(396003)(346002)(39860400002)(136003)(451199015)(26005)(6512007)(31686004)(6666004)(6506007)(66556008)(4326008)(6486002)(38100700002)(316002)(8676002)(478600001)(66946007)(54906003)(41300700001)(66476007)(5660300002)(4744005)(31696002)(8936002)(2906002)(53546011)(86362001)(2616005)(186003)(36756003)(66899015)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8668 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2ab27712-2c3f-4116-f249-08dac6e270a0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5WLy56n7z6p8ERtqx5E8Uit6lI/XpqP3+bMRsxc3NYprTy1WshB3/XgVOSmMKmH9KAcP9xmtYJu/mrv9PB8he9yNkYDhrn43pJJqjbBm6Q8BAfYl/EIAZkDPM8mDK8AY3fThl8hGlQm9Gs8qG1D1k7Y/0O9ayrnVk6J7sJEbiKbFZCgf7ufZdgBbmhhMC1lptkeRdQkw1malkjW13oAAZxNBNCe/SM9+WaYTbOb//HHCtaFdOEqSrHNfzLJgakj1N0hwL0ptzkoSKfxyzNmqoMWLqGPPIYA27LWu5HeftXg6fn5C2qnlverc0HoZnpsJPOKwAM10r5DnyyKXGyvA1ZTw0x3pASQs030WZcmZEuJMprIlv2MU+Ca1XAr9tzluaUrYf+pV7eJSkBlg1M52gtcMseBRtbWIhX2i5vG3+gf7Liu5Cak5s1ptHh+3baNqbbZtvUyL18QmE3NP5AQgTGcHTOxj+DoNAtNojOaMZnYjzaets/MW2fQSIfnWPoxAd3dpifyFAXRYCdTE2sYucyEgD+Og7N84tMGAc38336KO6uHqNdDyAO0psn32T7jYZCaC9Mi6m/mF2XmRdCo9KEKglm6GcNgUdIs2j6Q0dN06n86Hi4Uunexd1PsmtlwnXo4gX7Rw1LtBGI0Xhpn/cisU/i6K17M8AyNsfykXOSCoBc59RkBufe8jB1lv+lM1VeV3rCMnC26OJC/uYjaFOFBFwdtqhSzrtzb4BMY2RhY+rFZAqorAGVK2dDxE8+cntSZse57oLDEHraJdd2ojeXzIxLcxIGBakAhOd7voxWM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199015)(36840700001)(40470700004)(46966006)(47076005)(31686004)(54906003)(316002)(66899015)(36756003)(53546011)(6506007)(107886003)(26005)(70586007)(6666004)(8676002)(4326008)(70206006)(8936002)(40460700003)(5660300002)(6512007)(4744005)(2906002)(478600001)(6486002)(336012)(40480700001)(2616005)(186003)(82310400005)(31696002)(356005)(36860700001)(41300700001)(86362001)(81166007)(82740400003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 08:22:02.1443 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa6b8130-6113-47c4-99f5-08dac6e27904 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8205 Hi Julien, On 2022/11/7 3:12, Julien Grall wrote: > Hi Wei, > > On 04/11/2022 10:07, Wei Chen wrote: >> Current EFI boot services support of Arm64 could not >> work well for Armv8-R64 system that only has MPU in >> EL2. That is because EFI boot services may need some >> relocation support or partial PIE/PIC support. > > I am a bit confused with argument. We have nothing in Xen today to deal > with relocation/partial PIE/PIC support. So what is the exact problem? > Is it because UEFI can load Xen anywwhere? > Sorry, I had missed this comment. Yes, you're right we had tried to boot Xen R82 Image from EFI loader, but it failed. UEFI loader will load Xen to a random address, which is not supported by Xen R82 now. Cheers, Wei Chen >> But these will not be supported in the initial stage of >> porting Xen to MPU systems. So in this patch, we >> disable EFI boot services support for Arm MPU systems. >> From xen-devel-bounces@lists.xenproject.org Tue Nov 15 08:50:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 08:50:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443815.698581 (Exim 4.92) (envelope-from ) id 1ourdq-0004pB-LK; Tue, 15 Nov 2022 08:50:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443815.698581; Tue, 15 Nov 2022 08:50:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ourdq-0004oK-GL; Tue, 15 Nov 2022 08:50:02 +0000 Received: by outflank-mailman (input) for mailman id 443815; Tue, 15 Nov 2022 08:50:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ourdp-0004g2-3y for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 08:50:01 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20618.outbound.protection.outlook.com [2a01:111:f400:7e1a::618]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7c1f8626-64c2-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 09:50:00 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7070.eurprd04.prod.outlook.com (2603:10a6:800:123::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Tue, 15 Nov 2022 08:49:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Tue, 15 Nov 2022 08:49:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c1f8626-64c2-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WoVcMxjNW/oXnILZwtc9XdP6lDZw/D02GG8IVuglUQGsOPU97vJtEiT2vZagD5OvBfS6671DQWkvTezXRXKmNNizdEu59fMcOpNk4FSTF6o6819cpWXRvad4p6X+VxIAvtK3sTf1u/x0uGd+RGrsL65lqR2W7UntJggMRHyr8ITqTvmFHQnFAhUQ1v6XvBYDDsl2SN7rn8AaEqe1YozpZUUgNyABTCDJPgtdpApeAkqk3djGWhHAbCP2b9Mv56lTBAFxuukwFL6tDthDdAlePcuD6tuxBxMofVgTqv33Nzk3Oux1CqQUAAcDFTxTKozU+79Pro9//p/sac5xkcrNxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ajTJahRJMsJVN3QrzMO6iR+RSTtLDPqN6VZN2tp9k8g=; b=S7JcQ5BZMrAnDqTlhlKjPe+cENXnmPBoIJyGO5qNgCzuWqvgktsK4i/qpUOab2e4rBlWYtQtlHZjPvI+KwyPRg3wfKV1ZnhWVtA7tVzNG3Oun7lQ8ALzM/6gn7a16BctkDBz/VjavQloHHcus4meCme/kUDqHpy+dWVhMLI5ZL4SGNGk9ruL1tr49CtZS1YU7+G23qtKbSXsU+qquRHQhhIAVXen9OAE0UiHRVvitIHptLVcbQCz2lIrLE6GN2xrE+mViNcOB+5UQun73lvVhowjxxTV843PYbzMG0IbnQ22ieUYLpzp/Lb9KGPNoBES7LTdK6wUFimX1/k1CNdeUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ajTJahRJMsJVN3QrzMO6iR+RSTtLDPqN6VZN2tp9k8g=; b=QPX2PutkSgXEfLWBLUIbZqDepQRjNRzzyrv8LpbIsE0wX++CywHCDu8HzmN/6jeSr/tddJs6EVz7z6V63uL7UNJb6hfygoblo+FzFeZVpgTkgRjT33vTJpiPlgQj+hJ3f/M0pD5wq90WK5sVai56fzoK3RrKJNiZTgBmCg0kYSCJTNL1+ILLhqk79Pm223D+t9glaxK/h5jAxw8LCFPWU5AvBmHUbx7juLXysbLAhE7h9IUzgfwFSBOKq2gtx85nC0MaqEpivCvOIHUbngBawTmohOJEV1JXvIFdygA9HZ1soDi3Nyi3FEoffM8cXaVjKQ3ie4gM/pAKYRaw/CEzUg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <29469c16-856c-bce7-c556-66622e349f1c@suse.com> Date: Tue, 15 Nov 2022 09:49:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH for-4.17] x86/hvm: Revert per-domain APIC acceleration support Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Henry Wang , Xen-devel References: <20221115003539.19502-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20221115003539.19502-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7070:EE_ X-MS-Office365-Filtering-Correlation-Id: d73dc139-04fc-4d63-4174-08dac6e65f96 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OnkbDMjXUniRXGF4LJjaHMSrDNo2R3taipSpvZZ3BG79sKdZoyqirMuSr72fto8Bm7Wdwj/W7p4+XesNqNIV45zuHVOKE0+1wMQzJAFwk028Pk8YOCs6o8HFx2Sn2tbUxVw6FfoyRKzMJZBPQIMwHK2an2+MCBry/xsKXLhMt72VHNQNkDAInQptNAjWQ/TtlTHB2lAIQaPnI2ZdOBqS38/K02h0eoBr1SW5//KklvxeDqhpVlQeG1+klPAOXm+1uedXkY9fmxRuBLIzhzOphG00IAjQYDXdi4XTjI9VmUHP2lOgbMWk0BnH5Zomepsckieix2hvUAQ7wN52EeDDKnmbk5BAxwBqKnvI4SLsmyKC3K0m1lIDMrMvoXApWIkvg2W9dIXYWQLYeiC+9cK3MGm4Oz4bKdDeLEmgtFJfuIDqD4EAENiXrv0Jy27BkcdXVwvx+18e2XHa6lZbBBa+SEo5F9hp20/CvV7NaRW7hWzdAu0BEgjUY9XYQkBIn1nshVzLAVFiT0/2Q4avhvJZ+y1ToUfAe17kgMWoaKY3XRTtpnhPiPZQ2W962pCHdOQkBF8vyd6zO5XV7g9xEhUb/7JwNuVNKtV3viZH9NYr9CA/9bMhIJ1MMqhIPisOv/4ARST7NiGapbZFN82Ml71a51SzbGaKVT5EO3OI0XrBXK+rkajBt+0xUyOiD/V87VS4rf15vTJq7bG76BJ+ih12jShqSuJTL4AdLaddGqTJg5+JptpS1IrTN4JY36mC4Dx0txupyAwxFPwObI68xcLwgBzMBGP9gq5kZUxMpw2fJaI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(39860400002)(376002)(136003)(366004)(451199015)(2906002)(31686004)(8936002)(41300700001)(5660300002)(478600001)(86362001)(66476007)(4326008)(316002)(66556008)(8676002)(66946007)(36756003)(31696002)(6916009)(54906003)(6486002)(38100700002)(2616005)(186003)(26005)(6506007)(53546011)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UU11Y1gzYlgvZjdOUDZYcGdsalZNTzRGOWNIYUtQcDg5Yko1ZmdraEljc2M2?= =?utf-8?B?cGFibm04aUZmU3lrQzlJeTBuL09GT1U0aE52NTUrMC9kNFVLY3IwbWU0YjR4?= =?utf-8?B?aTAzck4yM2IwVFlSSjRQRUc4NUJuMVZ4NXhUV0l2Q1h4Zzd4ak15TEpGa2sw?= =?utf-8?B?WmJkYlhaTDdVM0RmMUhicEwvYWhkVkZ0Y3d0RTBFWEpkeFZSd0VTMTdyazNJ?= =?utf-8?B?WVpYNVhzWklUYXg5eUlWeENxaGF5YUtadGJjTHJBU0ZDMVNrYzVCUHhDNXph?= =?utf-8?B?V2VXZ3BrU2JlVXIzaXZiN3FsQVlOUkw5VU0zWW9SdWoyQkNQMlBHeVk4NG9y?= =?utf-8?B?MktqK3RkVVNKRFI4S2hBb1FHM2pvd0Nsd0h0KzRtWmVlM0VZbXMrVGRVd2V1?= =?utf-8?B?Rlc4ZmVPaEFYeExESnI5QWNLYmcyMmtBUWg5a2NnYVdmWkhyUUVaSENWM0Vy?= =?utf-8?B?b0o1MExkRUtmZDdrUkZmUUpsbUZTenpKWldFOThUN3VBVHI0T2xFS1d5TzZ2?= =?utf-8?B?TmtnY3dVL2NMdEZvdWRubXJNYnhObGgwYTlEcWdIY3BaUW5zbVZSaGQyKytx?= =?utf-8?B?cVBJeTFyMXdkd05PS3BnMzZYeVRELzg3QkdYc3J2UTZqb2pZeTY4cVdCTENH?= =?utf-8?B?eVRWWkUycVBtKzAxbXFYUG5BZmlJTjI1RDRPZk13K2JHQnZ1ckIvQjFkY1NV?= =?utf-8?B?UlN6S2psVXZsbUtINTFBYUwyMVdGYWl5VnVnZ0N5ZGVyMDlFZGs2emthc0Zi?= =?utf-8?B?YUJ4S1JKK0NwV050RWJWU2orS1ZhVjZmY1ZUaHgvSC94VFRwUjBhb1IvREJ3?= =?utf-8?B?elM0S21EZXJwUG92Q3d5WmF6ZWptcWczTlVNSzVYNHA5cW9PdEJTeUlLQk5I?= =?utf-8?B?N2Q4aVhyZmt2a3JDaytJZi8zZ09TR1RuTWdWNzh0dk9ac1N3OVhOZS94b1p4?= =?utf-8?B?NHF6NnA2SmRwUmt6Njl3NHlzR0xiR3ozbm1nbm1kaENPT2VkbDM3TUs4ckhG?= =?utf-8?B?QnJlWVpkOGpSS0hMRHpkMi95U3Vvc2dmM1JZdmF0UzYyUjcwVUcrMVlEQ25F?= =?utf-8?B?T2hOQlAyT3RLMlpUUTk3MHg4STlyakQ0ZytxZHVzTmxub3FEWUZwdU1XQnlL?= =?utf-8?B?am5pQkZOdk9RRHpydGNnQlpHTUNsVDVyRXVRNHNBU2dTcE52OGFRZkpqbzlC?= =?utf-8?B?ZEVKMWZoVDZmZ2V0VW1BMmNRd1k0QWpaMVZIWm5iT2dXSU52em9UMTNnUmla?= =?utf-8?B?a0VncE4ybjZtc1h6WXJkUlViUC9PTmxsL0JrZlRTWWNkVUF0a2NWa0VyM0pQ?= =?utf-8?B?WUlUOXpjL2tqb1B4Y3FtcWhqb08yV2pnVWo2VHcvUFlLRjI3UTJVWStNR21s?= =?utf-8?B?cFdFbXEyc2dJK0FoOEFEOVFnclZEaUxnQ3FYRElHMHFhNTFiOGIwbjJXZDNn?= =?utf-8?B?M1ZTbVY5RkRpMmJjUElZUjFCN0VxYnZkU3AxRXM1bG42M203aStrdUNCMEtK?= =?utf-8?B?UXYxR3I1L1h0TGx1aDhnRVpGYW04Y1NVdGxJM09UbDV4N0lnQmI1L2VwOXZ5?= =?utf-8?B?ZldsVGZJVHMzS1lDSTFYUDdnR0RqYjRvbTdFMWl0d1hoa1FnL1p3OTRvZG5E?= =?utf-8?B?OHhpYTdCYksvbEw3QVNUcjB2bkxLOE5ncyt2Y0JzRnZEZGVTNWp6YlJxQ21G?= =?utf-8?B?MkhVTFBRd0ovTW1TMDJMQTVzRUtPRmlUK1VNdXY5YkhDWHZEU0NBSjdCYzNw?= =?utf-8?B?K2duQk5QSVV5SkU3eTFvK3ZtVFVGYjlDTjBxUkFCanZ6ek5DVzcwSWtTbjlU?= =?utf-8?B?Zk5PYnpKR3dPNVFDTTVkY1NzdXJxeG1ueWxCeW5iVWM4dHVwNHNXT2RaN0E2?= =?utf-8?B?T01hb1Z3NWxkamJ5a3p4TU1sK1h5OVN0c2p1RGNjV3IxK2JqQWtvUis5LzBa?= =?utf-8?B?ZDBRYjlaVmdkMkppOUNOQmdXMEh6ZjRKc2tZS1pZMFI2bzdzN2VGeE9HZFpW?= =?utf-8?B?anlVbEJOUVh2S0RaQXEzbS9GSkloMVB1d1c1SUY1Y3NNQ25tekZGbGxBbGZK?= =?utf-8?B?WExOUmREbjZsdjZwS1BLa1pGVTdRM3M2cDVwQW1acXp3RHFsZFJ6RitkSUJx?= =?utf-8?Q?J0BqLGCr8VydN8tyTk1rEezE4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d73dc139-04fc-4d63-4174-08dac6e65f96 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 08:49:57.5588 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tPRAwPOCrQN7pLIU3eSfKPjXweHIn9hKE2QyOv9FxNM+r0aEb2Bp7eVtcTFvT/Mvt2BsZMTgJNNnxzINLngx6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7070 On 15.11.2022 01:35, Andrew Cooper wrote: > I was really hoping to avoid this, but its now too late in the 4.17 freeze and > we still don't have working fixes. > > The in-Xen calculations for assistance capabilities are buggy. For the > avoidance of doubt, the original intention was to be able to control every > aspect of a APIC acceleration so we could comprehensively test Xen's support, > as it has proved to be buggy time and time again. > > Even after a protracted discussion on what the new API ought to mean, attempts > to apply it to the existing logic have been unsuccessful, proving that the > API/ABI is too complicated for most people to reason about. Like Roger I'm still having trouble seeing what ABI you're talking about here. Yes, there are internal handling issues, but that's hardly "ABI". And as Roger indicated before, anything domctl/sysctl isn't stable anyway. > This reverts most of: > 2ce11ce249a3981bac50914c6a90f681ad7a4222 > 6b2b9b3405092c3ad38d7342988a584b8efa674c plus (as per Fixes: tags) 399bcbf281bd936d1eff7f7d1054ab49115c3a44 0823d57d71c7023bea94d483f69f7b5e62820102 which I think want mentioning here as well despite, like stated for the main commits, parts are left in place. > leaving in place the non-APIC specific changes (minimal as they are). > > This takes us back to the behaviour of Xen 4.16 where APIC acceleration is > configured on a per system basis. > > This work will be revisited in due course. > > Signed-off-by: Andrew Cooper Provisional upon Roger not objecting (i.e. him at least remaining neutral), and preferably with the above remarks addressed: Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 15 09:34:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 09:34:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443835.698592 (Exim 4.92) (envelope-from ) id 1ousKV-0002OW-7p; Tue, 15 Nov 2022 09:34:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443835.698592; Tue, 15 Nov 2022 09:34:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ousKV-0002OP-40; Tue, 15 Nov 2022 09:34:07 +0000 Received: by outflank-mailman (input) for mailman id 443835; Tue, 15 Nov 2022 09:34:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ousKS-0002OJ-RK for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 09:34:05 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a1f070c7-64c8-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 10:34:02 +0100 (CET) Received: from mail-dm6nam10lp2100.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Nov 2022 04:33:53 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MN2PR03MB5008.namprd03.prod.outlook.com (2603:10b6:208:1ac::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Tue, 15 Nov 2022 09:33:48 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Tue, 15 Nov 2022 09:33:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1f070c7-64c8-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668504842; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=rba44OBv8le1XCLBmxa2PD5LR5wm6cl7dGMv8w1NbhE=; b=b4YzIZVytgR25kUxhngV592p051btc1R9EMGTfdup4Kfu/CmcgLo0p1L 7w+t0ZoYHuU/9wo/q+dDb760bOZ5eAQwpJFZ9N5wM/02eNxbz0gMJSQlv Q4RjqpVX0br6/1uLvC6UBNMZFRpMWcjXkDAHqMW2N9uU+W2Ra61988sFs I=; X-IronPort-RemoteIP: 104.47.58.100 X-IronPort-MID: 87373752 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:W8RYkK4PRC33weGQfw7L8AxRtOPGchMFZxGqfqrLsTDasY5as4F+v jQbUGuEMv7ZY2PxL9p1PNngoxgBvMfcn9VhQFE+/HxjHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkS4QeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m9 6AfGB8sUEy/2uPq+LK7csRmg9ghFZy+VG8fkikIITDxK98DGMiGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnEooiOCF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efwnikA91PTtVU8NZGnHiq5kE9NicPdl6Sj+GbgxGddM92f hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpSNEgrt5wejUs2 XeAhdavDjtq2JWXQ3+A8rafrRupJDMYa2QFYEcsTxYB4tTliJE+iFTIVNkLOLWuktT/FDX0w jaLhCsznbMeiYgMzarT1U/DqyKhoN7OVAFd2+nMdmes7wc8aIv7YYWtsADf9awZdN7fSUSdt n8ZncTY9PoJEZyGiC2KRqMKAa2t4PGGdjbbhDaDAqUcythkwFb7Fag43d20DB0B3hosEdMxX HLuhA== IronPort-HdrOrdr: A9a23:sjmEP6+4on1IaiBuChRuk+G4dr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpixBiSgSiu4LvaFQHd+hsFSTtAzZor7G CAymXCl++emsD+7iWZ+37Y7pxQltek4txfBPaUgsxQBiTwhh2ubIFBXaTHmDwuuumg5Hsjjd GJiRY9OMZY7W/XYwiO0FDQ8jil9Axrx27pyFeej3emicvlRAgiA84EoY5CaBPW52cpodk5ic twriqknqsSKSmFsDX25tDOWR0vvk2ooUA6mepWq3BES4MRZJJYsIRa1kJIF5UrGj789ekcYa BTJfCZwMwTXUKRbnjfsGUq6NuwXk4rFhPDeUQGstz96UkioFlJi28jgOAPlHYJ85wwD7Ne4f 7fD6hunLZSCucLcKNUHo46MIWKI12IZSiJHHOZIFzhGq1CEWnKsYTL7LI84/zvUIAUzaE1hI /KXDpjxCEPknrVeI2zNaBwg1PwqD3XZ0Wu9ige3ek0hlTEfsurDcXZI2pe1vdJoJ0kc7/msr iISdZr6sTYXBvT8LZyrnPDsqZpWAgjue0uy6IGsgG107X2A7yvkNDnW9DuA5eoOQoYewrEcw g+tX7IVYh90nw= X-IronPort-AV: E=Sophos;i="5.96,165,1665460800"; d="scan'208";a="87373752" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KmlJ0hjNJSipsC28jErdgmlv3WUSw+v7fgzxJ57E5iT3+FrBT4bT1vDB7at9rqVpnSvePZ6s8atQEzkNFftqwhhLu4Xtf1piiY4JLuOqYAudv7uiNKqwRn8oHTQQEZliU4nAXd0+6QVaOoOFNN8TZnXhNGuQ+f7fIf0yd98B1TL0tPFnc6SlFsPaKFc1mW4MwkfE3yMx4vXOdjgQYp3JiAAEDgvCzJvaL1r4ch0mMCyThRYMwJMPoWSXzudmHBNGXI9VJTMCmyoHL3roPB/0lG6jdUBQeXjxKVJL/FBF8qMn/2Mi80MffEiGX+dPmrUhe8hEZB4g28vyXTpDoOrtTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U4KnyjQJsRd5YmQNLDBBEZ5PEaDR0ErchjihpQI52bQ=; b=airLqyd3n9FHFe37qVmYR7vSSelTXd+i5Q9elNKf0KcZ9h+QyTPaxY1M4vC1pIbinBhFXjBpjfyxnoZ2ZBAe2E7YprZ3cQV7qnngSgdPFYhasbeP0+b8674Xpt/nosfvuLXLWl1s1aOYN1Qh5/Z33da7W0ElZ2F+LS4Vaj3Rnb0/auZ6l1gIBmg9v/gDD4I1LYQNYHKxfmsltd9I9/ua4XgCtuiwN4wDEGa/K6LbpKJR/1EcDePU+hZMvfbtPNHfxK0uLeoU0cEJhrxHH2ZAmJMlcVhSMRDlxV2VjpBc0Lrjj3qJeCue0gnJtXs0/ih8ZYxoxrmkO0WV0xsfl4N30Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U4KnyjQJsRd5YmQNLDBBEZ5PEaDR0ErchjihpQI52bQ=; b=M5lZbOYFPMJUvIP2HpkTEInET4ODel8VmbCVY8PHtCt3WY93sgRr37sYovaxeVHjgCJbrTFXRw6ydo4/IV9FHdiV2cS0pe6z+SWw+qd+EWznVgayyPTrX1EIYEo2seV/FluKqnCqu4fhcdr7N1d4yHWrOKphIPx9Tspzw/+Vvkk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 15 Nov 2022 10:33:40 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , "Henry.Wang@arm.com" , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH for-4.17 v3 1/2] amd/virt_ssbd: set SSBD at vCPU context switch Message-ID: References: <20221103170244.29270-1-roger.pau@citrix.com> <20221103170244.29270-2-roger.pau@citrix.com> <544896d4-f9af-a4f9-cdcb-217d27ee94c3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <544896d4-f9af-a4f9-cdcb-217d27ee94c3@citrix.com> X-ClientProxiedBy: LO2P265CA0102.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::18) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB5008:EE_ X-MS-Office365-Filtering-Correlation-Id: 47668fb2-5272-410f-31e7-08dac6ec7e60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pDcLARQ2XFBS4UicI9gKjzS3TUu7rS5aEJNF7ewz6nUDHTxMAp/Mcz81Tt9L/le5io1ED7cJEGtTQwHVWo0VRjviCYmAALeGwLEhZR2PH6cSN1Wd8GT97di1XKvB4FClsmxK6YAZpaQ1AnjKNmELuPS1dQPgdKks8vFyybgSSmcSNK7Y1QCSULIItHO6QRMTk2y0qiDIaRlrDB8IZlVbYjjMdKhlQXgxRzFPWpQZ7FobuQuePQ3HozBTljLWGWcVKRuDx5o4TqVYD+5NsbNY7aIcQOOrTU2jG3xWV3ZaZ4Uni/PnQTJEN2QMcS4pJ/6mdLmWfmgy7O0FTMYyIg7+s1r5M1VHBuUwjn2sihEOCWhUJUDevHlKNvAafAaTsye541zzeV3rx7tKD85TFFVAuCHbhZXSoyXzp5sQj7LK4xu91dsleLfYg/zqmX3LADNMWKyyxxBHX+CCXtFXnPb3lPsVRkiIjHTfDknf7cGXrBQTeJnRIvXevt7PGY/ptd4c7XA5RstC7hpWzr2+57CTFsxkvMzt9TVgaPTw0bRyiYnokKQ5ag01GBPpHpBN5hCrLe8IZtCl4kmDAmwO7+ZhtT2PXbB0nj9/C0mHDdXi9xZ5/yEPfhGu/kZydByg4dLlKBT0h5nloiJLMHHYCj8arHHNalQm9idXQS0a8sXPShohQqT1XyCtnk80MS0vv3dBvRQaRfKiZB+EMkHfCPu+gA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(346002)(136003)(366004)(376002)(396003)(39860400002)(451199015)(6486002)(66476007)(6636002)(316002)(66946007)(66556008)(33716001)(85182001)(86362001)(82960400001)(38100700002)(8676002)(6666004)(53546011)(6512007)(478600001)(186003)(9686003)(6506007)(26005)(41300700001)(2906002)(54906003)(83380400001)(4326008)(5660300002)(6862004)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlBKSmY0VVRiL2Z1YnJsQk5FUkM0M3hLZCtzQjYxR3NLYS8wRDJINTlYQTgy?= =?utf-8?B?RFU0YkQ4U1ZUTmRxQTJiNUs3cHVkSUZjNnFtSVFhWk5Ob1I0UThsM052eWky?= =?utf-8?B?M3NMMk9zUDlBblpnL05lQ0ZhN1N5L1p5MGJUQWtmTTZ6S1drTGVLUXRrQ2xt?= =?utf-8?B?b09YMHdLUS9Qdjc5RVhLNVkxZ3NraGM3NCtUWk9hbjl6ZXJrQ2ZYTTAra1Ni?= =?utf-8?B?WkpCeXBMTVRTaXM2RGNiRzRES2szSFdpcldvM3huZlhpc3dBY2tIUDdEQUdy?= =?utf-8?B?Q1RoU1hWbjllYVpqMmxtNG9xRUZ1V0ZidkYrQmR0L1RlSEVmOHl3ZVpLdk9Z?= =?utf-8?B?U25aZlNWVFpWc3RkYmd1c0FmcEJYSzNCMDdPRng5YUVTWm82T3o1YlhZd3NH?= =?utf-8?B?bGFMNlpRd2M0OFJTaDFIU2t4eEFnVUVnMDc4S3FFK0l4elBSNXFhR0g3MlNl?= =?utf-8?B?WDdwS3VnQWxKZmcvTHBzQ0dIRkwrT0p0S2t6QjZHOWY2a1UyUVhNWi93OUNy?= =?utf-8?B?M0tUTWNKVzA2ODBzcFdaeGV0NGYwWmU1Q0ZZcDZUZHdMeFBMT1h1eWZjdFBN?= =?utf-8?B?VmtoaE5tYVQ2QzJ6VmtMS1oxd3lyMWhDWklzdzk2Z1pFcWxvd2tpNjU0Q3d4?= =?utf-8?B?M05STHZzZnRNWEYyYVZ3MU9XUUw2VGo3VE96djZBK1pLekhaMy9kTENVTGVH?= =?utf-8?B?MEhmV0pteGZNcHRDT2IwME5xVXByNXpWZTAxSlc5cjhidVpRT1ZNdWhidTJh?= =?utf-8?B?OWFXNFR4UTNHKzdmMGxXMEU1aWo1WFRqOEJSZUFJbzBwMExPeEVLSDhWRXRP?= =?utf-8?B?KzA0YUdjN2hQOU5RU3c3TzlmUFlMdTdKQlRYU04vblJxRlhrVXVTWm5adWJD?= =?utf-8?B?ck90WXJlSFAwNGJwTFd1TUFmdVJ2ck1kNG1JTUFoUCs1OWEvbHl1RnZzSVhV?= =?utf-8?B?ZUdRZW51bm1JM0ZoV1B2WXUrSEJSOFA0TGpGd3ZVNkkybzVaYTVKN3I3cUNP?= =?utf-8?B?Z3RvMjVQd0wybXlDTkdEbTlsc3E3aTQyM0pHTnZzekFqZXUwTm03aGJLT04x?= =?utf-8?B?RHBjUTdqTFB1ZE0rbmVnYWx0blJia0JWeXZZaHBQQmRrMUdqVXkzZy9tNWFX?= =?utf-8?B?azNXRnBwenVuYVp4cWtrYXhFVlc2eWwwam92QnhJNGRTdDJVVWN4TzBzbG94?= =?utf-8?B?eUFBb3VSbWI1UTJWTG5abWZYRG5nZEg1MTc5WWJCY3BxUWZkZGVYVjRsaXJC?= =?utf-8?B?R3V4d2JuWTQ5SFZqTGs0dkNnaHpxcUF1eGZLczUzZjEwQkxhQU9wcEVEdm9W?= =?utf-8?B?eXo1TDJjZjhwUytsM3lHZWFzRDBaMjdNTE4xWWZVWHV2aWVkdEF3U1gwTnJt?= =?utf-8?B?YjE1bllJdGtxRU5MRWVuZFFwQnZsTDlTRG1OcjZDVWp6SUFvN2lQWmNrTmVR?= =?utf-8?B?bFA5azIrTVNHaHNvTXhGcEN6bFlYMytpUGpTMFNnMnVxS3VNU2FYZmx0cFZk?= =?utf-8?B?Y3JUSVhNUjNKNFJDWC82TEJiVkpPQjRRYVdGM04zMVJTZGRsM21tdWlWcGRC?= =?utf-8?B?SGZ2K2kxaXZFd2hnUEJzdHBVNU5xcUdBTE5DQm81ZmR4NksxeFlMaE1uckNB?= =?utf-8?B?VU5sOGY0dm5uVmlZZElLdm1IdGYrbzNMcVhVK3NFM1hvNVBYbjJWWG1KcmVM?= =?utf-8?B?cmFLSVo2RlJpQ0JnOTJRVVpvazFrbGRQMUNwR1JoZGoxZmJnaGR2UU53VjVt?= =?utf-8?B?SU0xdEdkaU5jcnpFdjYzeUp2em1YUXBOYUNxNnNlTjBNaEIrK2xSaTlvbUhm?= =?utf-8?B?czJvOXRsMHZMeXdvelh4aldidklpT3FQRWhpYTUrMVMxTVFMbWY3NjVXNWo4?= =?utf-8?B?Q2JZRTNDcFF4cm5hRUFBUVNDNW0zTTV5TWJSOEhqdDdwZHhKcWxiRmVrT3h6?= =?utf-8?B?MCtNcTBqa0xRVnl0WDA2b0NmYWxmN3BZUExXb2pJT2ZNRVlCRnRKaGw5OWlt?= =?utf-8?B?bjh3cjJDSmI4NDM3bjcyNUF3Q3dZTURhN2MrMldBUHlVRm0vcHh6dGdqQ2hw?= =?utf-8?B?d0dyL3BmcitsNnZOS080eUlBVU14TEFyYUd4YlFZc0pYblRvbCtoT3NJZ3Ja?= =?utf-8?Q?hrfFUN1w6Lm/R1ghz1bkw7hDt?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: x0Yx/6asVjf4LnD7rYa++JBAEVcZolajKODZm1P1eTS8z8MNz6meXpb0VgmJIUrjHAXuj7BRnElu2V8cRj5JxF3ci6m9Cq9f5b6gLwh/NRaSZPHfeQ8H4n/A87LCuagn4mSWkVV/FCdgGop06g6ad0rHdGWyx/MuuCHkBVPJ8DGzoobe8ISIyDTl6JUigagiTqrdjjNNyyWITSjtmBn+HVIj84JNXcHjhgQhaPHRq86CQ/YvwRPnRjEw+hXQSJjIQvK8u61626xzDJ7iXLuCprLx53gQ/atD/laqt3vBnYsGtbSluXq1Pc92ATDHa9//Af8ZfFxJn0jOvkoSN6cE/TGtlxv8TNjDg7W9q2NCX/aTJAcHxsrVO+oKIQAM3TAP9ad4kZHVKbnC53is2XWgS7oMjWToGfuw2pciDo/ha7n9jmM1bcmcHXQtNKQGyetZUlZQPLPR6cpaqp7SThQLQXijFo9Xp8Ai4azDlXc4R28vu9VOsB2uFtF+4c3Z84XTYrZFQaVOAPnYtQ5bV9e4FFI5xLe9k1Y2swHVtfC5ndaeygVRji7/3O8QrOui+lPwCf04ShSpqN+ptXwQzdu/8Wf8HdEdDuAlNLE6OIHJC65mFUK2PgJlcmeUxVrwAlfkqTPBJZgN7dI9dYbnejdKzJ15i9A3KHaIO4G7DyyumLj42B6UU8kodPr/OsXuz/SUemEpW9dM2f4wEuS0jYIIjHw32FyNMUwDQZWtC1/Ry5dVYHv/IVp1iolgW6DwrV2A1daQbrlFyunyriZ5Kb4EtjGlbG+BNTk7Y7VcQ3wN/3aBCFMml640NItlsVAWeL8/uKxHd/GDcheP63CWJyG8ndAAlaGEsN5Ca1huNqZlJWPRWsMWvTjgra9fXyr8gKeCTexY+szoyEkNneB3JglgaQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47668fb2-5272-410f-31e7-08dac6ec7e60 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 09:33:48.1797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y6jMCplQyzANz2aqUuFhOstEJdrVQTigQvkI87LC1DOwLKTNcJQrw78wO/WlGzt9k3+0O9dnzdb1QTypPAld0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5008 On Mon, Nov 14, 2022 at 09:39:50PM +0000, Andrew Cooper wrote: > On 03/11/2022 17:02, Roger Pau Monne wrote: > > The current logic for AMD SSBD context switches it on every > > vm{entry,exit} if the Xen and guest selections don't match. This is > > expensive when not using SPEC_CTRL, and hence should be avoided as > > much as possible. > > > > When SSBD is not being set from SPEC_CTRL on AMD don't context switch > > at vm{entry,exit} and instead only context switch SSBD when switching > > vCPUs. This has the side effect of running Xen code with the guest > > selection of SSBD, the documentation is updated to note this behavior. > > Also note that then when `ssbd` is selected on the command line guest > > SSBD selection will not have an effect, and the hypervisor will run > > with SSBD unconditionally enabled when not using SPEC_CTRL itself. > > > > This fixes an issue with running C code in a GIF=0 region, that's > > problematic when using UBSAN or other instrumentation techniques. > > This paragraph needs to be at the top, because it's the reason why this > is a blocker bug for 4.17.  Everything else is discussing why we take > the approach we take. Done. > (and to be clear, it's slow even with MSR_SPEC_CTRL.  It's just that its > a whole lot less slow than with the LS_CFG MSR.) > > > > > As a result of no longer running the code to set SSBD in a GIF=0 > > region the locking of amd_set_legacy_ssbd() can be done using normal > > spinlocks, and some more checks can be added to assure it works as > > intended. > > > > Finally it's also worth noticing that since the guest SSBD selection > > is no longer set on vmentry the VIRT_SPEC_MSR handling needs to > > propagate the value to the hardware as part of handling the wrmsr. > > > > Signed-off-by: Roger Pau Monné > > --- > > Changes since v2: > > - Fix calling set_reg unconditionally. > > - Fix comment. > > - Call amd_set_ssbd() from guest_wrmsr(). > > > > Changes since v1: > > - Just check virt_spec_ctrl value != 0 on context switch. > > - Remove stray asm newline. > > - Use val in svm_set_reg(). > > - Fix style in amd.c. > > - Do not clear ssbd > > --- > > docs/misc/xen-command-line.pandoc | 10 +++--- > > xen/arch/x86/cpu/amd.c | 55 +++++++++++++++++-------------- > > xen/arch/x86/hvm/svm/entry.S | 6 ---- > > xen/arch/x86/hvm/svm/svm.c | 45 ++++++++++--------------- > > xen/arch/x86/include/asm/amd.h | 2 +- > > xen/arch/x86/msr.c | 9 +++++ > > Need to patch msr.h now that the semantics of virt_spec_ctrl have changed. Sure, will adjust the comment there. > > > diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c > > index 98c52d0686..05d72c6501 100644 > > --- a/xen/arch/x86/cpu/amd.c > > +++ b/xen/arch/x86/cpu/amd.c > > > > +void amd_set_ssbd(bool enable) > > +{ > > + if (opt_ssbd) > > + /* > > + * Ignore attempts to turn off SSBD, it's hardcoded on the > > + * command line. > > + */ > > + return; > > + > > + if (cpu_has_virt_ssbd) > > + wrmsr(MSR_VIRT_SPEC_CTRL, enable ? SPEC_CTRL_SSBD : 0, 0); > > + else if (amd_legacy_ssbd) > > + core_set_legacy_ssbd(enable); > > + else > > + ASSERT_UNREACHABLE(); > > This assert is reachable on Fam14 and older, I think. Hm, I'm unsure how. Calls to this function are gated on the vCPU having virt_ssbd set in the CPUID policy, and that can only happen if there's a way to set SSBD. Can you elaborate on the path that you think can trigger this? As I would think that's the path that needs fixing, rather than removing the assert here. > > diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c > > index 1aeaabcb13..8b101d4f27 100644 > > --- a/xen/arch/x86/hvm/svm/svm.c > > +++ b/xen/arch/x86/hvm/svm/svm.c > > @@ -973,6 +973,16 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v) > > > > /* Resume use of ISTs now that the host TR is reinstated. */ > > enable_each_ist(idt_tables[cpu]); > > + > > + /* > > + * Clear previous guest selection of SSBD if set. Note that SPEC_CTRL.SSBD > > + * is already cleared by svm_vmexit_spec_ctrl. > > + */ > > + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) > > + { > > + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); > > + amd_set_ssbd(false); > > + } > > } > > > > static void cf_check svm_ctxt_switch_to(struct vcpu *v) > > @@ -1000,6 +1010,13 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v) > > > > if ( cpu_has_msr_tsc_aux ) > > wrmsr_tsc_aux(v->arch.msrs->tsc_aux); > > + > > + /* Load SSBD if set by the guest. */ > > + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) > > + { > > + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); > > + amd_set_ssbd(true); > > + } > > While this functions, it's still a perf problem.  You now flip the bit > twice when switching between vcpus with legacy SSBD. > > This wouldn't be so bad if you'd also fixed the inner function to not do > a read/modify/write on the very slow MSR, because then we'd only be > touching it twice, not 4 times. > > This isn't critical to fix for 4.17, but will need addressing in due course. Indeed. I know about this, but didn't consider it critical enough to fix in the current release status. > However, as the patch does need a respin, amd_set_ssbd() is too > generic.  It's previous name, amd_set_legacy_ssbd(), was more > appropriate, as it clearly highlights the fact that it's the > non-MSR_SPEC_CTRL path. Can adjust the function name, not a problem. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Nov 15 09:36:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 09:36:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443838.698602 (Exim 4.92) (envelope-from ) id 1ousMw-0002yH-Jv; Tue, 15 Nov 2022 09:36:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443838.698602; Tue, 15 Nov 2022 09:36:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ousMw-0002yA-HH; Tue, 15 Nov 2022 09:36:38 +0000 Received: by outflank-mailman (input) for mailman id 443838; Tue, 15 Nov 2022 09:36:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ousMv-0002y2-Vf for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 09:36:38 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20619.outbound.protection.outlook.com [2a01:111:f400:7e1b::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ff79bb9d-64c8-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 10:36:36 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7803.eurprd04.prod.outlook.com (2603:10a6:10:1e5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Tue, 15 Nov 2022 09:36:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Tue, 15 Nov 2022 09:36:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff79bb9d-64c8-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FAY3T2oPEogvFz96X0sA/uMDtqngOyuI+RlonT/rwe+lBTowyvblUnURvoEC0w4IevQyIw7usXm9n6F8QBCd52PJAHLUuKNxBHJhB76j7jwAqw4Vky2ZC4yJBLz9CGs2q2ZUvmh4u7eM12YPW8TDgBLnONEhDWnMy4eBgGh+/c5oRLvNKrxQeZRh1cL5o/MpgGTkmdtsBAX1WIWg4NA6mh5JFnXuCDgDMZwsgN/ZOQuX7jc3KISwUyC+W+spCEQ3P5cbWFQP6ZuZ6j19HioSWukPpqB6rIsVrLnmKid2+XKOLXpiqmbxYaKMBz0igQ12Dc04zXIfS/RSjrC1GUZ4TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yMwrRRmWSfJXnxj1Gshc70uBJANUspBSzid+TYEwV88=; b=M4Aguy0GPChlvJkt3tTG3kcIM1sRqGewb9WkuS77UlSwKhdecxVYilX2V8YQs+ddmkwS0+Ljrc3kn0lisCvqxf7VFTc2xCNcJzUrrmikp5V9MXujvHkANaJy6KhyFNE0ewyqnlaFxb6tM5+UWsCBNuo+NqqOwdIbOujf1ET5f/TFVT4T2hbBZtE5OI9Klj8UGZRS6dg74runOtV4jXuydhPhst+5rwX38yPp0pQr9HXNbv5tYA5Wqg9usF3XTr8ZwsAeWShq0fomsQysIo8kpHUTaLvAMa6qhq+IW1QQ+e3BGZ2YTBiwrHRA2lz9fqnFoTw2KMcaiR77CpnBMUX/kQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yMwrRRmWSfJXnxj1Gshc70uBJANUspBSzid+TYEwV88=; b=1qZWn3LzFDyAgcFnAG7iCzV+WMBIctu+LwhGxgEl7HzT2rdie3rfxnyHWtifapDwZw6JD8gcJuSHRbuWq9oKyTn+luIAUc9obd7Nxi6M/wJFXf4PZczeBDSflohVrwNNMYRY0NTyUHm8IHv8AANVGKQkCl92/NwyCTry7a5/DHbhXFlYoD2Cf4udheHaTzae6K4l4NQ59RmyLGSrj/t5sT+spH+xV5HYl2sT6qbQu+6gBqqPgyUQI47qoRNyYy6Je1kYqAlZy6XwX7dSWE/DLtKex4zdTYHSO0B5lY+lHvHUmJJOZOHzlaXROrkuKDGJ5ewuog2Mco8dUE2OXn0TKQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 15 Nov 2022 10:36:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/2] x86/msi: passthrough all MSI-X vector ctrl writes to device model Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20221114192100.1539267-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20221114192100.1539267-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0126.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7803:EE_ X-MS-Office365-Filtering-Correlation-Id: 42b12824-a954-4e8e-e03b-08dac6ece257 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iSaA3TgUaBBH4ylD4JQ/RWpw/705xFPD+ZGPLfd0MMDBo3yDSlOiFK9rfV2eE2yYRrxak7+Dmyk8gGQsfSkUNqzbP1LrKCX5xrI2EwzZFOEyxNjRP3+VOzavbXXtpvDOLLk/Bdcou/tWG3aPsvtpBDNTigvJTy4toI3bJOUfsp1e1fVv3pt3nhUHUMB/Ka9k+yj+LOyGhX0dYGGOF9YgpMTOquM1J1ku0X+TqNOQvGnWo+ZuaEQQ2cGXEPRKKITge9U+tiK8GCF1ck5alLxxae4ho2Qtnmu3BkkqjjET3MScgzm2hOlaHjEQd0eH7A24XIGXrCfKMSojof11jEKNV4u/AXyLdsJCJpL+2U7Dvrzk2hUG2KphheuSMlHyvYkUDlrpJV+aObB+7YK308h85aJ9kDzg0CJTN0lIpyfhhhhuNYVnyLr79TWMPlxk2P/aAehbRsqWx+BTOf66EAIEDQyY4m3pp6AFObvtWAKMOak2W75Ixsl7nFjBPIErsEVd9+WzII9iqBor2miM0bgHUJ3nUMBUDe/eOvPenbZci+To3CH/Z6x3H1OcL/uq8AO35FkPbEDMEIvP78raoO0Aa0JITu/vWpNQyU2o/bd6Qdf+/fAN2/XH2Jbnhi5+EyssQ0lSv+5HJ7HDE7laWJ12oTKeT5JTxOt6HcH6Pg4HsjLbWFI0ah0Z0wJRpGfruCkZO7zACSXLH3g33xLOu23iUAcF+JgWLgpM2MJUdz9TGNmlNqLh1NGmiBydPjwQCsq/uVCArtp/shGi0D/ghKp4V2mg/ECXAlVxtyBoZVBZJUk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(136003)(376002)(346002)(39860400002)(451199015)(41300700001)(5660300002)(66574015)(36756003)(4326008)(8936002)(6916009)(54906003)(66476007)(8676002)(2616005)(66946007)(66556008)(316002)(186003)(38100700002)(83380400001)(2906002)(31696002)(86362001)(478600001)(6506007)(6512007)(26005)(53546011)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXcwdEpVT2IvTzRaQzI5VHQ4cktwM0lDMjhPZkVjZGIzZTM4V3VMazJXcGgx?= =?utf-8?B?dzdiLzhNdERGVGRaK1pBcDkzaUhtUy9RVmRWelBKK1l4OTlHNDgwdHcwSUQ5?= =?utf-8?B?Q0llbkRBTnhKR2QzOENwMTI2elBmdkJRYm1wMk44NmJsOENOMWRoSkoyNTRu?= =?utf-8?B?TjBucmxwZStVS2ZtSU1SNU5YYStFaWVCeDY3c2pVZ1pIOEdJSC94dVRFY2FM?= =?utf-8?B?UmVaTm9MTEVXRTZKQ0tEN0d2TmRZRVUwcERRMC9ZSzdyK0JYaHhXR1R2TS9O?= =?utf-8?B?SU1RemNxb1FrQlJaV0M1QjMxZDUyajNNZk8zdG8rUVJWK3BLSldBRnJWeFlX?= =?utf-8?B?MjRGUWVBN3h3L2FaMFBNZU1JNFBlMXlXVFRBZkZLdkxrYTlON2NjckVCTE9B?= =?utf-8?B?cjQ1TEJHOTVLcE4yWUNlRDZ2aElqT1EvUXRxUnZZZ3lqNUlmakQwbDNWSkNP?= =?utf-8?B?dXhzL01wZzd2NWV5b2VZMWlDOGxlZG1TUjU3d2hmN013TFd3bXdDWHpObTlq?= =?utf-8?B?emZHS0dQOGszb2lzTWlZR09nMFNhMmU1RDBmNWI5dmlRNVpoT1FMZkthUVUw?= =?utf-8?B?SFFxTmY5N3NqbEhveGhxamd0dTRmejhrcmxGeHdqVmpoc0xreURDcGxTLzhv?= =?utf-8?B?VTQ4cndUZDMxbS9Ja3k4REg3bllpZjB5NWlQWGZpN0JWRzB0ZjZiT1hXVFJ4?= =?utf-8?B?bEtKNjFCNU9pb3ErZU53VVg5ZXBEdE1uajd0bndES3oyNzFwMllmQkJBNThj?= =?utf-8?B?bkNwNnYvSlBUWVJyWGdZNkJwLzkvbGdMaXBSNDZKcVhYajI2ZG1NVi82RjRs?= =?utf-8?B?TWNKMlZVUGp5bmlOODNtQy9hZk5lUEtFQ1NkamZOaTlqSk9PTGxRclJxcnhx?= =?utf-8?B?Ry9vMUxldjlWVyt4T2czdmx2RGlMRkk1WEpiV3NuTjVKcktmMXRDblFUbFlD?= =?utf-8?B?RGMzZWptTU15YzNjYjlUUm9nQXVlcDd2S20xSk42aTIvcXp2RktiRlprbkpV?= =?utf-8?B?QmhyVkxTSlU4WmJKRkNVNmpRc0JjR0I4MHhOOGN3Y21ZV2NMaGFvdFdKRzla?= =?utf-8?B?ZnlTQlgvVzg4TjFPQ3ZNaUpIb2trV2pSK2hGRW1PMUZRazI2MFZwVkxNTXhu?= =?utf-8?B?bURsc1VoZlVReFZ6T20zNlNBcyswRUtnc1k2OEZWSVpwMVM4c0FCUU5OOS81?= =?utf-8?B?SVlVUWgxM1RtaktDNTJXMlJxWk9OSVBNc2dLL2ZhK0oxa0hCVnowSXRTd05m?= =?utf-8?B?M2pQeWxpVng3dmlBeW4rY3VJblcydVU4Ti9JMVlJT2U0ZVdBU2pSYkZjOTQ4?= =?utf-8?B?U2s1MTU0VCs4Y05LM2paeVBPbzZ2dGxHalMzTTZUNGxlZlpoZmlkcEpmTjhW?= =?utf-8?B?a0NjRWo4Z01RN05qdXZQcy9mNjF0RGpNUnZpTHc3RDlCcEJhMVVSd1Vnc1By?= =?utf-8?B?Ylh1a3FVeit2bW1Jc3c2dWZpQ2VrWnRxM05iT2RGN25JZGJGQSs4YkNwSmhu?= =?utf-8?B?VFN6dURCTlo2U1JhL0txTTZKZC9lalg0VlpGQUdTdklUTTJPOUFVOWdFODBp?= =?utf-8?B?cllEdFkwU2RXalU1LzNsMEp2emhXdXB6bk1MNU5iaWVSNHp6ZldKdmp1Njky?= =?utf-8?B?S3QrT0l3RGpDS3g4dGNrSVBLdUROUmI0WHlNdFA1VmhyODF3clF4VHU0Zjcw?= =?utf-8?B?cTBNS0Q1dk9QS0JuTk83eXByeit2NlJTQUNmNU1tUGZTRFBlcElVa1E5WExQ?= =?utf-8?B?QnFJQ3ZxMjA3REd3am83SDFsMzRUQ2VZVEV6bldYTkcvVVZnbUw4M2MvYWNi?= =?utf-8?B?LzRyQVZmQmxHODQrSnVuTTdDT25UanluS3M2SmJ5cTQreVJ3S2x5eElHVEhl?= =?utf-8?B?VWppVk13VUhLNFRtbkwramtSMEwwVXFSdUFzNFZybVk0aUVtYjE3bU5qZ3pN?= =?utf-8?B?VjRiVHMrQ1d3cUdzc0h6WWtZamFZSXFzL1NUaGsrS01rOTdmUC9ZL0JhL2hh?= =?utf-8?B?S1ZwbUlDTVJBSGMyNEhxb2JqaHY5UXc3N2pYMko4YWV6ZXdCN3NRTUJjQVNs?= =?utf-8?B?anRGQnBDNStrRWdRNGVLYzFBVTNMM0FIMnR6TjVZQWZKWVlHYklOdWF6dWJq?= =?utf-8?Q?SMLQvL1XRF7l+S5Vqvs3qYouX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42b12824-a954-4e8e-e03b-08dac6ece257 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 09:36:33.9587 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pbN9X1L9n/P1cD45tZaE4pXCbHyxeklfoL/0/eMPDzgZxwutJKq4GHqdS5VoKLZVKC2dJoW06JzZmZpRZhg6sA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7803 On 14.11.2022 20:20, Marek Marczykowski-Górecki wrote: > QEMU needs to know whether clearing maskbit of a vector is really > clearing, or was already cleared before. Currently Xen sends only > clearing that bit to the device model, but not setting it, so QEMU > cannot detect it. Except for qword writes as it looks. Furthermore even clearing requests aren't sent if address/data are unchanged. If you agree, please add this here in some form for having a complete picture. > Because of that, QEMU is working this around by > checking via /dev/mem, but that isn't the proper approach. > > Give all necessary information to QEMU by passing all ctrl writes, > including masking a vector. Can we perhaps still avoid sending dword writes which don't change the mask bit? > --- a/xen/arch/x86/hvm/vmsi.c > +++ b/xen/arch/x86/hvm/vmsi.c > @@ -271,7 +271,8 @@ out: > } > > static int msixtbl_write(struct vcpu *v, unsigned long address, > - unsigned int len, unsigned long val) > + unsigned int len, unsigned long val, > + bool completion) > { I'd like to propose an alternative approach without an extra parameter: Have msix_write_completion() pass 0 for "len" and move the initial check if ( (len != 4 && len != 8) || (address & (len - 1)) ) return r; into _msixtbl_write(). Then ... > @@ -343,7 +344,7 @@ static int msixtbl_write(struct vcpu *v, unsigned long address, > > unlock: > spin_unlock_irqrestore(&desc->lock, flags); > - if ( len == 4 ) > + if ( len == 4 && completion ) > r = X86EMUL_OKAY; ... this could simply be "if ( !len )", seeing that even with your approach it could simply be "if ( completion )". Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 15 11:11:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 11:11:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443854.698614 (Exim 4.92) (envelope-from ) id 1outqf-0006LN-I1; Tue, 15 Nov 2022 11:11:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443854.698614; Tue, 15 Nov 2022 11:11:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1outqf-0006LG-F3; Tue, 15 Nov 2022 11:11:25 +0000 Received: by outflank-mailman (input) for mailman id 443854; Tue, 15 Nov 2022 11:11:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1outqe-0006L6-4M; Tue, 15 Nov 2022 11:11:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1outqd-00025U-PS; Tue, 15 Nov 2022 11:11:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1outqc-0000m6-VD; Tue, 15 Nov 2022 11:11:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1outqc-0008GV-T1; Tue, 15 Nov 2022 11:11:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=klMdIn87ujUOuuDErPpP+rV1ffMxRbBLw/pGPW/OR18=; b=3uTR2ysWvyHwiy6lJ4HZitIrBL t1kHMwcSE1jVltR4gcp+vde//oS6+lWCgWmOD+KFZ1m8liRMgj3vFKIvWeXQSgT9wKT99J6EfCLUZ oXpfFphQ0tJTSWdvxc5PciQwuxg/sQlBjJNtUIzaKdx3LTi7QmUBKXKsBSKGDfRxwJlI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174773: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-livepatch:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c805ceb0b26a643c7e47f01f2dbc50555d93cce8 X-Osstest-Versions-That: xen=c805ceb0b26a643c7e47f01f2dbc50555d93cce8 From: osstest service owner Date: Tue, 15 Nov 2022 11:11:22 +0000 flight 174773 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174773/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail pass in 174769 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail pass in 174769 test-amd64-i386-livepatch 7 xen-install fail pass in 174769 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174769 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174769 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174769 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174769 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174769 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174769 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174769 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174769 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174769 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174769 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174769 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174769 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen c805ceb0b26a643c7e47f01f2dbc50555d93cce8 baseline version: xen c805ceb0b26a643c7e47f01f2dbc50555d93cce8 Last test of basis 174773 2022-11-15 03:12:28 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch fail test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Nov 15 11:37:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 11:37:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443865.698626 (Exim 4.92) (envelope-from ) id 1ouuFc-0000jY-Ix; Tue, 15 Nov 2022 11:37:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443865.698626; Tue, 15 Nov 2022 11:37:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouuFc-0000jR-EO; Tue, 15 Nov 2022 11:37:12 +0000 Received: by outflank-mailman (input) for mailman id 443865; Tue, 15 Nov 2022 11:37:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouuFa-0000jG-4i for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 11:37:10 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d43e27c7-64d9-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 12:37:07 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A61C85C0106; Tue, 15 Nov 2022 06:37:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 15 Nov 2022 06:37:04 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Nov 2022 06:37:03 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d43e27c7-64d9-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668512224; x= 1668598624; bh=m1CLwNradEnDNB0ey88xxCnVPjobaJfDNrP5VudgiWI=; b=R nKn83SCH55P5hOoYOx/WiwwKEyzmOJLPv8OelQ++PE5RPpnJqhgPK+brhtcY0mM3 KwFYZz0qt43re+MYc+cvLFYkp2kiE25C3r/Bt0voZYZ+rirvXIJIpCzQVY/GnZkb LPttQN7oYkmcwXbJhm+jJvMJRAaveB3h4IC4av3DvJwY6n02QinrJcQ8Wg7w4iiG tEYN+ruYFi+q4h9kvy4bkfkWp6EM1RHYO3gqdjTBKPJjMt+CPed8Jyqj/u1uJAhU YjqrZppEc+LUSlws9w7KbXc6Jo4gnzX+z2ND5zI64M4nZz4RD0MuU+ZDarQ201Yq 4joFZ+SxFnLcebxk+C7nQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668512224; x=1668598624; bh=m1CLwNradEnDNB0ey88xxCnVPjob aJfDNrP5VudgiWI=; b=hD6+UtU9Qyw1FErV3XZJGsF+xnhmyuWeX7OrUBe4djYM jRJwLLFNBcrH8xqX7c5Hpb+HSmstlRpMA0CBmsjbZinANljrStLpIheTjX/jBMgx RuPBX+15e1lsQUsb+hEIP3l3HVi1Qapgq6vZ0O4QE8M2kxEhSjxq/cjkj7nlFgdH n4LBHWxF9eaMxEg1Z9TeRqmbEKblPnWahtGUPQZnUpb2c0oQO+UaofCgHStSBi68 +Su7+0AlBpUmFXM9KbvouFmEV5V/a+ksQMHIsERIwc0CjgVSp8LCDxNIEC8uzd6k ixNZAre2QUaQnBj0jhtscaks8MmCQRnbZdve/HccCw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgeeggdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 15 Nov 2022 12:37:00 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/2] x86/msi: passthrough all MSI-X vector ctrl writes to device model Message-ID: References: <20221114192100.1539267-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="P8r2+hJNBNAaLMGh" Content-Disposition: inline In-Reply-To: --P8r2+hJNBNAaLMGh Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 15 Nov 2022 12:37:00 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/2] x86/msi: passthrough all MSI-X vector ctrl writes to device model On Tue, Nov 15, 2022 at 10:36:32AM +0100, Jan Beulich wrote: > On 14.11.2022 20:20, Marek Marczykowski-G=C3=B3recki wrote: > > QEMU needs to know whether clearing maskbit of a vector is really > > clearing, or was already cleared before. Currently Xen sends only > > clearing that bit to the device model, but not setting it, so QEMU > > cannot detect it. >=20 > Except for qword writes as it looks. Furthermore even clearing > requests aren't sent if address/data are unchanged. If you agree, > please add this here in some form for having a complete picture. Ok. > > Because of that, QEMU is working this around by > > checking via /dev/mem, but that isn't the proper approach. > >=20 > > Give all necessary information to QEMU by passing all ctrl writes, > > including masking a vector. >=20 > Can we perhaps still avoid sending dword writes which don't change > the mask bit? Is it worth it? I don't think such writes are common (which I confirm observing debug log - every single write to maskbit Linux did was changing the value). The old value isn't readily available here. > > --- a/xen/arch/x86/hvm/vmsi.c > > +++ b/xen/arch/x86/hvm/vmsi.c > > @@ -271,7 +271,8 @@ out: > > } > > =20 > > static int msixtbl_write(struct vcpu *v, unsigned long address, > > - unsigned int len, unsigned long val) > > + unsigned int len, unsigned long val, > > + bool completion) > > { >=20 > I'd like to propose an alternative approach without an extra parameter: > Have msix_write_completion() pass 0 for "len" and move the initial > check >=20 > if ( (len !=3D 4 && len !=3D 8) || (address & (len - 1)) ) > return r; >=20 > into _msixtbl_write(). Then ... >=20 > > @@ -343,7 +344,7 @@ static int msixtbl_write(struct vcpu *v, unsigned l= ong address, > > =20 > > unlock: > > spin_unlock_irqrestore(&desc->lock, flags); > > - if ( len =3D=3D 4 ) > > + if ( len =3D=3D 4 && completion ) > > r =3D X86EMUL_OKAY; >=20 > ... this could simply be "if ( !len )", seeing that even with your > approach it could simply be "if ( completion )". I find such usage of magic len=3D0 confusing. It would change the meaning of "len" from "write length" to "write length, unless it's 0 - then write length is 4 and it's called from msix_write_completion. Is there any real value from avoiding extra parameter? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --P8r2+hJNBNAaLMGh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmNzedwACgkQ24/THMrX 1yygowf/XfqaqFOcXukozTtTshxvT8EPlrhvdDQ6GFohyf3a92clSd2QjgFhsImE 86Oo1pA/HCRQ1jno+y9XpHiLeJK6B9uB3CojkszXNrHvEREZA54dJwibbnKLc5aB WRoY6DD0QcRp+LJxWkYLg/jAU51okHmZn6tFM7vXXFyjiqvxa0GN+fOYuTSnwDxp EgDi0IYoLjbqU/JSLhap9iJD+5vkpWvknoqgnrkXhotqEdeXl8M0pGjMQI5TqzTy l6GSsnsVnfjLltMXif5Ptr9SilSpcX/Dk6sbrTuyJERmJYLAmZsbjNI0LOS0KoaC gZbBDR8EANJNqOiSWSb5OrReOhCygQ== =tZc0 -----END PGP SIGNATURE----- --P8r2+hJNBNAaLMGh-- From xen-devel-bounces@lists.xenproject.org Tue Nov 15 11:38:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 11:38:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443870.698636 (Exim 4.92) (envelope-from ) id 1ouuH5-0001L3-Vr; Tue, 15 Nov 2022 11:38:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443870.698636; Tue, 15 Nov 2022 11:38:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouuH5-0001Kw-Sk; Tue, 15 Nov 2022 11:38:43 +0000 Received: by outflank-mailman (input) for mailman id 443870; Tue, 15 Nov 2022 11:38:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouuH5-0001Kn-AQ for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 11:38:43 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0de5eb8a-64da-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 12:38:42 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 822635C0120; Tue, 15 Nov 2022 06:38:41 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 15 Nov 2022 06:38:41 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Nov 2022 06:38:40 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0de5eb8a-64da-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668512321; x= 1668598721; bh=Jxo4IkBy5DIaegqe/RAVUhtnEdJPJXh23XEzegecNQs=; b=l 5QT+DF59k9EAsNiskPsQEF486fgMzxSC7HHmyllCU+VhwfxJ/VRLHQJ3BH+7LST/ vXmJ0R5moNCc4PCUBkSgDDcFARE08NuzmCOrbp0ljqhPi7JmQwUmvC+DYS3eNicN NvQOadz2LdwfmhJ+D/qJphr3OH1kXcUUJk+/ns5qzECsSJr16cKmrvaAL4uagabH uekJSpO5Pfebox/y9XLK6mz3aDwl7N/zNHBlukthb2IF8JViNsQXifemNPv5Livu feagrwn2L3Y7aEaXeHMft1gFfUOEGLo10Ww0QAlz4DCtJJ2hqNSNRYczvVhMp4x9 84m0duEcVOoBKVy2XY9wA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668512321; x=1668598721; bh=Jxo4IkBy5DIaegqe/RAVUhtnEdJP JXh23XEzegecNQs=; b=sl/OykJkqXee2YpcNCgxo6NH1+bjCJIbqkW6Jj57hB1C 6QMPRsJ3psw+zXdCdFn3x/Tx4ox+Ew6A8hAbPpjNNrgV0AOoPZ22Q5arj3f8jQ9U +VZi27xpgEFFt4LZAtk8YYH0sLzjqT+jY0PrAfW8Odl6W6sIXOaxmh/3OUsHf2vW jiStlqkEg1c8ZOR9vXJxfobqGFZPvUbeY6OP+MRmnImTTa7uInvqqTMwnI048xkc DqVgFyMp66asHbFlo0jDP9Q+EZgPuZeQyi32YKq3P2YW8wdbkIk7+giGguy+a6fL yhUwyPrOrCA9mtx7dOGAbulgrXdpZd+1h2NXh+DW1Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgeeggdefudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 15 Nov 2022 12:38:37 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" , qemu-devel@nongnu.org Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen Message-ID: References: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> <20221114192011.1539233-2-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fP+2vUV7w+NDnUJ4" Content-Disposition: inline In-Reply-To: --fP+2vUV7w+NDnUJ4 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 15 Nov 2022 12:38:37 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" , qemu-devel@nongnu.org Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen On Tue, Nov 15, 2022 at 09:14:07AM +0100, Jan Beulich wrote: > On 14.11.2022 20:20, Marek Marczykowski-G=C3=B3recki wrote: > > The /dev/mem is used for two purposes: > > - reading PCI_MSIX_ENTRY_CTRL_MASKBIT > > - reading Pending Bit Array (PBA) > >=20 > > The first one was originally done because when Xen did not send all > > vector ctrl writes to the device model, so QEMU might have outdated old > > register value. This has been changed in Xen, so QEMU can now use its > > cached value of the register instead. > >=20 > > The Pending Bit Array (PBA) handling is for the case where it lives on > > the same page as the MSI-X table itself. Xen has been extended to handle > > this case too (as well as other registers that may live on those pages), > > so QEMU handling is not necessary anymore. >=20 > Don't you need to check for new enough Xen for both aspects? Yes, see my response to Andrew in the thread. I'm open for suggestions what to check specifically (Xen version directly?).=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --fP+2vUV7w+NDnUJ4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmNzej0ACgkQ24/THMrX 1ywIwQf/UFUun8P7OUjaX2Ec/IHmNYzkkRwq3iQjfLPLZBwaFQQptqOqE4wf6XLq YaBlINhTIW4WnYziauBQnANTna4e2guNyungBS+ELjXqziZJ0vY/yMtg0/Z0Ajy0 cGg9Rt6swEvK8GBqAo21juYlZcOgtq7LvisGWh2mRb6+xnT1m6Iiq9UurGomHIwk m8F5Q5dqV7gu3zS4C3AxaqHdttR1YcNmnpa5GrZYWt2MVpJ6LRChAKXRUXhlsqGP 180DHGlF5vVobPqMIOL9SBewp1X+kK0Qy9fN06hG+CAGvreZjBIVLMr7XmoGUQhG mZ1tumxTGC3+T/b4l3C814kUOSnA/w== =UW15 -----END PGP SIGNATURE----- --fP+2vUV7w+NDnUJ4-- From xen-devel-bounces@lists.xenproject.org Tue Nov 15 12:35:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 12:35:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443931.698665 (Exim 4.92) (envelope-from ) id 1ouv9y-0001Nk-TR; Tue, 15 Nov 2022 12:35:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443931.698665; Tue, 15 Nov 2022 12:35:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouv9y-0001Nd-Qi; Tue, 15 Nov 2022 12:35:26 +0000 Received: by outflank-mailman (input) for mailman id 443931; Tue, 15 Nov 2022 12:35:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouv9x-0001NX-Iq for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 12:35:25 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f7811cce-64e1-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 13:35:22 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Nov 2022 07:35:14 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB5520.namprd03.prod.outlook.com (2603:10b6:a03:282::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Tue, 15 Nov 2022 12:35:10 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Tue, 15 Nov 2022 12:35:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7811cce-64e1-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668515722; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=yx1qT6ADU6F03ua5VujyVXnrhoNLwEoV9OK8YImi7Vo=; b=WI8Pa7E/M99Y7GEgXqKaKmWL7IIpcMWgF3XKPMRocITL2+3vM8X/BRsE ilwkxAAve7mDm5R+6CkaPa7aJBfDk2AwnOuZQSFOkOqSxbdzEgDtIR7TD wxPA/DzfJfXeB66g/Vof1qPFF4nsKhyDFFh7lOlMINZgyWOvOw23QA2hk Q=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 83913977 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:bwG0G623EWEY9bNZ0/bD5fRwkn2cJEfYwER7XKvMYLTBsI5bp2YCn TBNUGnUafaLYmCmLYtzO4yz9U0FvpHRx9QwHgM4pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVnOKgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfWERRx OxCGio3cw2i3tvp2JaVEa5Rv5F2RCXrFNt3VnBI6xj8VK9ja7aTBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6Kkl0ZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r83b6WxnKkB+r+EpXk1cRA3WGi9lYeVgckXgG7h6G1rFWhDoc3x 0s8v3BGQbIJ3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsTDRMddgnv88eXiEx2 xmCmNaBLSNrmK2YTzSa7Lj8kN+pES0cLGtHbylUSwIAuoDnuNtq0EOJSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTN/Ni1CAgbQD0ct9EQ== IronPort-HdrOrdr: A9a23:tFwN9q110za2lXMZESbckQqjBcZxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjjfZq6z+8M3WBxB8baYOCCggeVxe5ZnO/fKlHbexEWldQtqJ uIDZIOb+EYZGIS5aia3ODRKadb/DDtytHMuQ6x9QYPcek8AJsQlDuRRzzrZnFedU1jP94UBZ Cc7s1Iq36JfmkWVN2yAj0oTvXOvNrCkbPheFojCwQ84AeDoDu04PqieiLolis2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv+/olbg9zoz/pEHYiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2e XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvHxUWDiXXujMTlTHZiYvAx875xQ1/80Q4Nrdt82K VE0yawsIdWNwrJmGDY68LTXx9nu0KoqT4JkPIVjVZYTYwCAYUh2rA3zQdwKtMtDSj64IcoHK 1HC9zd3u9fdRegY3XQrgBUsa+Rd0V2Oi3DblkJu8ST3TQTtmt+1VEkyMsWmWpF3I4hSrFfjt 60fphApfVrdIs7fKh9DOAOTY+cEWrWWy/BN2qUPBDOCLwHAXTQsJT6iY9Fqd1CQKZ4gqfapa 6xEW+x7QUJCgLT4Iy1rdd2Gyn2MSqAtW+H8LAc23B70oeMNIYDfxfzCmzGqPHQ3cn3MverJ8 pbB6gmfMMLVVGef7qh/zeOKaW6ekNuJfE9i5IcZ2+khP7tB8nDitH7GcyjVYYFVwxUEV/CPg == X-IronPort-AV: E=Sophos;i="5.96,165,1665460800"; d="scan'208";a="83913977" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RiALM4XeKf/SaOQ1OAHoP1VGRUif4Di0XX0MQ523JhiZl3is5V3JaITiVmz3k/6BfEpuzsqRQc2+P4a4+/311qquoa7zDhbvVI/BT2vgnkN7AfvUTkLszu9tDGFvLvn9NojdAVRXeQ0InrQLjCiwS/j1Sur0dc2iLEsRTk6abkPGAdrR53t2XM+cJgdv5iU+pYjLwgTLTLFcuKxF2W8IyhBRcsNbGQSia3hrckh68MeZxjFtlF1fW0zi6TIjJJYVDlMxF+tJBpb38HzvklNcI54cYz56j8Bp4l5wChRVj3vNRzjd50VGjaJ9JR6LzvuTFNv9G+zDqEa7MFAO99crSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8+kVssPldB61vaARpAydKDcBb+cwifH0pqEE8rmTf2Y=; b=YKgF4mEalHB4mWGrtkltIimtJ54/I95CHq1RTHBC6v5EHLvFt1Xu+vWmScSqZX3/dDChGqyWHOTiGbsZm0OKpOQgC4I9BNtLoUkf+6vm8hB2C0wdfgdx1WIldI/8mZ514wp/EhlRMexvrqjXsOk++79JKUiFKVc5XcGAh2gVRG2YyO2qFZC1GYONPyKa/I7Xxb7C72NmreCi9j6ZynXzA32/IN36zwSYu74A1Bs65r5h+4H4n1TYEmn7Qua+7tmZuE4VDnr2KDI4vk9IYIs3ecXnXwiiUXcmzl1i5RtqSD9jm5H6hwV0HdoP9tZsLBZcIK+LZpH/kcJGs2sipwaf3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8+kVssPldB61vaARpAydKDcBb+cwifH0pqEE8rmTf2Y=; b=drbGzl0Fx0DdepvsJ99DghUdp5Jo9BK+ML+uVEOR6+0L2QNVboYPDf++d2lZeQf7lxSHLe4r79ygm5yU7SOflZ+4U4EshQTXbfF/zWsTYQmOCH/OXZR+uy2t7JCEJryNd05ijFGCs7DD4SbZwfNzCY8xNSCL+9xKJuuNaMhA88c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH] x86/irq: do not release irq until all cleanup is done Date: Tue, 15 Nov 2022 13:35:00 +0100 Message-Id: <20221115123500.97114-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0106.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c3::9) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5520:EE_ X-MS-Office365-Filtering-Correlation-Id: 69bf5e86-c4aa-4651-7e4f-08dac705d53e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +nlb+6XFmoNoDL5QmhvZk8czHkYaXjlV+azb26Jo/c4QrY0guwqVEak5/taZZZCNK3zYUZhhX87ilqGFd/TxgVOlY8uQF5HmynWwM8zlmGeeKtZ8zr7ZfKPvkdAgBQvH6wHNvRjgjoIlGAsV7Vtg7bkBc8Pd3kkWzvOD/cZgrIx15thvefs+MRpb5wdgAjjMaKWWx1YxXQdOZi5UNJJneOwsaR5IF2POWgxwOR7W6lAybc+5tVvIJq66w5Q8HOypp6dT3bvIM0sdMJOqIPOjj7mDDw6Ej6TZfaukYTH42+efjt9V0by2BgGKBuecNugE6I6SmKEHmgCMy710jo2i2nMQZ8HN9KZZ+sS/3OXt4z/iQZEYBtvBAaIvi4HeiP4pZLPtnQUZB9zG3SuM6MLvLJmeId+XzbzGsFLS68FumFyniSPoDSUmrYtIkLtTq9ulUfmC1H8yoPj73bSgPQZtTR4vExWTEwIBHHyK9UFqvtMmnLp+0IVTGe/6AOLyomWCeLySWyJ5Wn/dLzN3tyHlDDcYSHKS9U2JcFlABL+cCO79eItbj+E1BUCgE5l65YvjOBIrKkThkwHi9WoddqSle/kVkQ2hP/t8mIPrP8q0OxpTHwHnRBD9xjJuNFHDMRQCgc1GshE1PxfohoRSa29ltgP1GwhpfO3Glv26ZqI/XKzc4cbk3qiYvYSyCmXnjx/ByfVMWXbiEjU6H/5VqiS3dw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(366004)(451199015)(6666004)(478600001)(6486002)(54906003)(6916009)(5660300002)(66556008)(8936002)(36756003)(6506007)(41300700001)(2616005)(1076003)(2906002)(66476007)(316002)(6512007)(26005)(8676002)(4326008)(66946007)(186003)(83380400001)(82960400001)(86362001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bk5yUU9rRjI4N0V3bElublI0bnhOR2lCaFE4NkxySjRmbVBvQ05BVVJEdWlI?= =?utf-8?B?UU1tVSt6c0d5OWMyUUZhUWwyL1owVkM1UzVneE0wTlZNTXV3OFNTRnRVUEdS?= =?utf-8?B?KzRCbElwaXhQL3BJSm9ZTzgyUVhOQk1QSFJjSUVaakEzQ0Vjd2JhSUdmd1R6?= =?utf-8?B?Z3pPMFB3d09zdGw1SWR6b2h2cThsNGNVYncrdDQ2ZVMyWjRoOHc4c1ZrUkRW?= =?utf-8?B?WnIzZGxNTkxKbCtIcmVidG9xZUt2WUIyeHZ3RFZ0M1d1Rzg5czdFNGp2VmFF?= =?utf-8?B?WGJCa0FpNUM0SXd1V0dyelNlSTlyQW1ONjJGZ2xRQUtlZCtpQVozdi9SVjE3?= =?utf-8?B?TG1lQ0Y0K3E1L1hBbWNlM2RSQ0xzdEg5Vm8xNWVydGREZjZFbGwzQmprb0RU?= =?utf-8?B?bDdBRVBHZG9KQm55T3N0Z0RPL2F4eE42WlowYmRkcm1JRE1BTkliVG11Y3Y4?= =?utf-8?B?MzVnMG5ZdzZ2MCtybXpxUFR5M0cyM2xXU1pPZE9pTTRzVFNCMEpRN0hiVXJ0?= =?utf-8?B?NmZ6QTE4cU1zQjEzRVU0ZW4yR2RWSWlUU1BNQzJLUUZRcEdrS05DeEdoZUcz?= =?utf-8?B?L1hkYnJValg3aVJXZkxteFM1RnN5aFFZS3E5b0N3S25Fc2xRNDAzTTJFYXNa?= =?utf-8?B?dUpqdy9VdXE3bEpSMjB1a0h2dlRyc2x1NzZqaCtlQU9BM0U0S0FYWnBrd1pC?= =?utf-8?B?ZWRtbEg1dHR5SjJ2K29tQ0F2Q09wRnBtZkdld0k3aitsa20zeU90MnpoYzg0?= =?utf-8?B?eVR2SFhKY2oydVVscGt0ZjdXdTY5eUdPSjZ5Z2RjM1Avdld4dmI0L0ZvTU8z?= =?utf-8?B?Z0NnQ3Vwdlh6emthV2djanFEbHJOdW9WM09hOVAwYXVFUHRwTWFtS25vcHNs?= =?utf-8?B?eWYwbVFLREZ6cndIYVp4aEZjc09wN3NDV0JOK0svZ2d3MjRSZmw2SVdwRm85?= =?utf-8?B?djVsck1RdjIwSXhrSmV0ZHhITUZab0w5eGV6TnpCUlBnRDVJVDA4N3JDbGkx?= =?utf-8?B?a1hMcURTQjdDTkpJZ1g1VzlFUWNiT1JySm1ISGxFN2V2YXIrUEd0Tm1rNXEx?= =?utf-8?B?c2pyWkhPQ3R5eHlyM3lKUGF1aHlCTVAyK0YxcEhhZEJuWU9nSU9pMzJMTU5a?= =?utf-8?B?WVVWNGNDQWJKVlQyaStqeUJjRFY1UmVuTlEyekVDTGpsamRWSU04VStzeFFN?= =?utf-8?B?UjFoUW91UGZFTkdSQTc4L0VzZkRRM0FjckgxbmQ0UndpRE1sckVUNW4rOWJ4?= =?utf-8?B?ckl6bklTM0FIc0FxbTg3OG5VU3E2TXMrYXdCTnJrcVhuWk1zQnZxdlA0YmNt?= =?utf-8?B?Rll0aEhFQ1FyZk5ZTkZuZ3RNQWxmd2dWNzJSTXNReXpCOUJTTlVpVDJIOWpE?= =?utf-8?B?UjEvdjhkRzJmL0IvdmNreFh6QlIweTVyVk5aQVJyMElYMEs1TkFiMlI5VEJ4?= =?utf-8?B?MGx4TWx5cWlRQXhpTHpMbS91MjdBTkJwTHZkM01mVUxpV3FXY25vRkFLUkYw?= =?utf-8?B?Rjd4SUZEUkkrQXUyTWhyUkhKOEN5TTBaSUV2UUtHWi92TEFCOVVoSVBCRzRn?= =?utf-8?B?YllmdFllL202N3dmRGNhV0YwYjNmV05KZnFSTjRaV21WbjFvNUJ4UEFwVWNK?= =?utf-8?B?REMzUzF4amcvTzFkVEcwaHFyK0lmRkNmUHA1cnduVVFmcU9KTUtFQWFKQmxv?= =?utf-8?B?eVBSWVF4QVk2WUdSb09KWU50cDJ1RkNkZU92WVYxdk0yYUQ4Q3VPS2hla1Bj?= =?utf-8?B?Mk1Vb0RNQXQ2amdRYThmMThlakYySHlvbmFLcXdIUlpja0NQVWl2SWRWZmsw?= =?utf-8?B?ZVJaNHF3eXNrajgvay8vT3c3dnZEVTlJaFRPTGtqMUNBNk9CNFJIWm9xOWM4?= =?utf-8?B?SU15bXZYT0xER0g0WWtyQUZCVytNaytOeWpJa2ZsYnZIU1M1WU9tYWJZbGdo?= =?utf-8?B?ZzNrdGdvamhIVVZPWlYxSE1ZNkxZZ3E3Vi9iTDJqbExocFg5N1pmNmtJVk5n?= =?utf-8?B?QjliTFVKS3JqcmxDdTFCSnJYalBaTkZOZ2xDWHRPZElrQTFLblpJRDVXS25F?= =?utf-8?B?TWVoNmpUSHBtdWpSNHZTTUFDbkFRVWtCcXkrNHRkc2pRWFptNi96V2FWaGx5?= =?utf-8?Q?FSnKrvVRV/ZmUVxW4UxOGJlLz?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: dCDYBSsTUaXIHAiGwmAyaB+iX/fv6nbtvDnzhhnMs+ABNdmaNZrT3I7ZOXVRxcFo6EfJ/ox6ouWg3TYddNXBpSIfs27w+u0n3bnxi4IRHfzVeUtmvP/xt74+QtrnHwL6ekzPub8qSK+grtQxLgWwfNooY6bTCgc0tRURmHt7jVYSuaOB6bu/t+ttIoT08nZBEI5xhfctn1Wb1PMN+H97NkL8LyZg+IJQGJE8IZHJmk+jmN/iwEweiuUYNTwUG372GjlcGbtj2xwkWLEw5nVQzVmBgqNqSnnffG0hHgAYmPpsDyXbvJH8WbykIWxJ6IbvvKGeR/sf5Nh97QGkzVEMU3jcXmzxDoWa9eAnfM0d6eP/MmQSR2h7L3U6mV18fwP2jysXk3ldKlF6l5zyzwKk5e3nbx3rMoWvLWN1dkqODOS+/JvfFE3t2HXidsb0WqfOOfnBIWAAyD2fkn65EQQh5+3mYF2YFpPRgoYM4d75RxrKl5KoAx9OiKM2TiFwjd1e88Yx1Afnnm/SrBNUVWOvtmZxv5wf3cwQIwuzQfWRav/uP0crW0/7gBAm8moyaqmEftKiqqjadSyEEEZPtkw04qZ8Nbz92bjVm1XBShr3f5d0gvGe4vUJm39J64RvH3DJl8j66Vi/tSHSj4wKM6BCwfj9y5fa0O+Bvu0IgjlCvKCKjfO4LvX++hMC6ng5wtTjZZ1f7E1ZmIzc4t75ywecEebWhwaPMzL+b0muTRj034Bc0m2IOeppFPmmc0X3VcuO+suMx5yIN3mGPQuqvpwgI53CqrX/de33BDOdM/JFMYYAVSIexDX2ZToBa9Y8VcaxhsqG80Xew4bUk+GJ5p/85w== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69bf5e86-c4aa-4651-7e4f-08dac705d53e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 12:35:10.0407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v4cVOcC92Rri2ACm4SMAYpvv0G9jd3hM5DfddfjstW1DpmNLSWCqk9vHvG+4lbXxGyJkaaP9fSEi/ZS9Il3+kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5520 Current code in _clear_irq_vector() will mark the irq as unused before doing the cleanup required when move_in_progress is true. This can lead to races in create_irq() if the function picks an irq desc that's been marked as unused but has move_in_progress set, as the call to assign_irq_vector() in that function can then fail with -EAGAIN. Prevent that by only marking irq descs as unused when all the cleanup has been done. While there also use write_atomic() when setting IRQ_UNUSED in _clear_irq_vector(). The check for move_in_progress cannot be removed from _assign_irq_vector(), as other users (io_apic_set_pci_routing() and ioapic_guest_write()) can still pass active irq descs to assign_irq_vector(). Signed-off-by: Roger Pau Monné --- I've only observed this race when using vPCI with a PVH dom0, so I assume other users of _{clear,assign}_irq_vector() are likely to already be mutually exclusive by means of other external locks. The path that triggered this race is using allocate_and_map_msi_pirq(), which will sadly drop the returned error code from create_irq() and just return EINVAL, that makes figuring out the issue more complicated, but fixing that error path should be done in a separate commit. --- xen/arch/x86/irq.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index cd0c8a30a8..15a78a44da 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -220,27 +220,27 @@ static void _clear_irq_vector(struct irq_desc *desc) clear_bit(vector, desc->arch.used_vectors); } - desc->arch.used = IRQ_UNUSED; - - trace_irq_mask(TRC_HW_IRQ_CLEAR_VECTOR, irq, vector, tmp_mask); + if ( unlikely(desc->arch.move_in_progress) ) + { + /* If we were in motion, also clear desc->arch.old_vector */ + old_vector = desc->arch.old_vector; + cpumask_and(tmp_mask, desc->arch.old_cpu_mask, &cpu_online_map); - if ( likely(!desc->arch.move_in_progress) ) - return; + for_each_cpu(cpu, tmp_mask) + { + ASSERT(per_cpu(vector_irq, cpu)[old_vector] == irq); + TRACE_3D(TRC_HW_IRQ_MOVE_FINISH, irq, old_vector, cpu); + per_cpu(vector_irq, cpu)[old_vector] = ~irq; + } - /* If we were in motion, also clear desc->arch.old_vector */ - old_vector = desc->arch.old_vector; - cpumask_and(tmp_mask, desc->arch.old_cpu_mask, &cpu_online_map); + release_old_vec(desc); - for_each_cpu(cpu, tmp_mask) - { - ASSERT(per_cpu(vector_irq, cpu)[old_vector] == irq); - TRACE_3D(TRC_HW_IRQ_MOVE_FINISH, irq, old_vector, cpu); - per_cpu(vector_irq, cpu)[old_vector] = ~irq; + desc->arch.move_in_progress = 0; } - release_old_vec(desc); + write_atomic(&desc->arch.used, IRQ_UNUSED); - desc->arch.move_in_progress = 0; + trace_irq_mask(TRC_HW_IRQ_CLEAR_VECTOR, irq, vector, tmp_mask); } void __init clear_irq_vector(int irq) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 12:45:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 12:45:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443934.698676 (Exim 4.92) (envelope-from ) id 1ouvJx-00033Z-Qt; Tue, 15 Nov 2022 12:45:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443934.698676; Tue, 15 Nov 2022 12:45:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouvJx-00033S-OG; Tue, 15 Nov 2022 12:45:45 +0000 Received: by outflank-mailman (input) for mailman id 443934; Tue, 15 Nov 2022 12:45:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouvJw-00033I-MB; Tue, 15 Nov 2022 12:45:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouvJw-00045K-KM; Tue, 15 Nov 2022 12:45:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouvJw-0008Tr-15; Tue, 15 Nov 2022 12:45:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouvJw-0007d6-0b; Tue, 15 Nov 2022 12:45:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wBKLDWFgIVC3RWM3dJb5FKMU2BER30nL36Hxl3ryRA8=; b=o0RdMMJTTq/Oq9VRdAxJ9MjB2X E0K0qLGbMR5kESAXk8G5HwPK+dm+DpbEqmeEwmRLK7Y6kIxwU19ZhQ+PFQVVNZA73mWcnSt354bWR /QxLa1eEx965Wu1A2aoDXr9cr64PmnI1w58yHcJKr11AUhy1HvflarhpCwaf4CpB5SPc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174775: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=539e851c5d66f86777b5698df939fe281095e823 X-Osstest-Versions-That: libvirt=e5d86975857f1ca5431a84c460adc5bd4a260795 From: osstest service owner Date: Tue, 15 Nov 2022 12:45:44 +0000 flight 174775 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174775/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174744 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174744 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174744 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt 539e851c5d66f86777b5698df939fe281095e823 baseline version: libvirt e5d86975857f1ca5431a84c460adc5bd4a260795 Last test of basis 174744 2022-11-12 04:19:00 Z 3 days Testing same since 174775 2022-11-15 04:20:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel P. Berrangé jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git e5d8697585..539e851c5d 539e851c5d66f86777b5698df939fe281095e823 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Nov 15 13:27:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 13:27:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443947.698697 (Exim 4.92) (envelope-from ) id 1ouvyW-0008JP-BO; Tue, 15 Nov 2022 13:27:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443947.698697; Tue, 15 Nov 2022 13:27:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouvyW-0008JI-8F; Tue, 15 Nov 2022 13:27:40 +0000 Received: by outflank-mailman (input) for mailman id 443947; Tue, 15 Nov 2022 13:27:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouvyU-00083Z-E2 for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 13:27:38 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 44c05f2f-64e9-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 14:27:36 +0100 (CET) Received: from mail-bn8nam12lp2170.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Nov 2022 08:27:31 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB6713.namprd03.prod.outlook.com (2603:10b6:a03:404::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Tue, 15 Nov 2022 13:27:30 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Tue, 15 Nov 2022 13:27:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44c05f2f-64e9-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668518856; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=S8vX3VCUDfWem5EKpM+BWQyIehCHdz/guxow4oRJrXI=; b=HBVXef6piPA0wW8Z850A9PqY8Pos2zxLYOJ66AAe0GTyXuI+xCwGVJri KWYebBqV/5Eu6bIjFK9KvKOImx4SKJ028kXIz1dVqnZ3U7LnKuoFDX9C7 CJlB9uFNcvvYYrw9lkfFP/tNhNFZ4OElWzoJWyr+5vGzcyr80jNP60+ds 0=; X-IronPort-RemoteIP: 104.47.55.170 X-IronPort-MID: 87387759 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:N9CVyqy49C4ex4wtv1V6t+fsxyrEfRIJ4+MujC+fZmUNrF6WrkVUz jNOWzuAP/2JY2Wnc48lYI+390JS78KHzN9kGQI4qSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPK0T5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVp23 KMKIwAUVUmK2fmnyrbqcrM02st2eaEHPKtH0p1h5RfwKK98BLrlE+DN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjWVlVMpuFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE1rCUzXykBdN6+LuQzP1hulGRm1EpMSIvDXanpsWwgBTgVIcKQ 6AT0m90xUQoz2S7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZh5MbsY38vA/QzMC3 0WM2djuAFRHsreYVHac/be8ti6pNG4eKmpqTS0ZSQoI5fHzrYd1iQjAJv54C7K8hNDxHTD2w hiJoTI4irFVitQEv42k+XjXjjTqoYLGJjPZ/S3SV2Ohqwl/NIisYtXy7UCBtKkYaoGEUlOGo X4I3dCE6/wDBo2MkyrLR/gRGLau5LCONzi0bUNTIqTNPg+FoxaLFb28KhkkTKu1Gq7ooQPUX XI= IronPort-HdrOrdr: A9a23:kka65az7cJ4Uo5TnwszBKrPxTOgkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scu9qBTnhORICOgqTMyftWzd1FdAQ7sSibcKrweBJ8S6zJ8l6U 4CSdkANDSPNykcsS+S2mDRfbcdKZu8gdiVbI/lvgtQpGpRGsRdBmlCe2Wm+hocfng6OXN1Lu vr2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJTIWGhI97wGKrDWwrJr3CQKR0BsyWy5Ghe5Kyx mOryXJooGY992rwB7V0GHeq7xQhdva09NGQOCcl8QPLT3oqwCwIKBsQaeLsjwZqPymrHwqjN 7PiRE9ONkb0QKbQkiF5T/WnyXw2jcn7HHvjXeenHvYuMT8ABY3EdBIi451egbQrxNIhqA17I t7m0ai87ZHBxLJmyrwo/DOShFRj0Kx5V4vi/QagXBzWZYXLJVRsYsc1kVIF4poJlOy1KkXVM 1VSO3M7vdfdl2XK1jfo2lU2dSpGk8+Gx+XK3Jyz/C94nxzpjRU3kEYzMsQkjMr75QmUaRJ4O zCL+BBiKxOZtV+V9MyOM4xBe+MTkDdSxPFN2yfZX79ErscBn7Lo5nrpJ0o+eCRfoASxpdaou WPbLphjx9zR6vSM7zM4HUSmSq9AllVHA6dhv223qIJ+4EVH9HQQGi+oFNHqbrTnxxQOLyeZx +JAuMnPxbSFxqRJW935XyOZ3ArEwh5bCQ0gKdOZ7vcmLO9FqTa8srmTd30GJ3BVR4ZZ0KXOA pxYNG0HrQM0nyW X-IronPort-AV: E=Sophos;i="5.96,166,1665460800"; d="scan'208";a="87387759" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fUBvsY8hI8yhc3glMmkhueuHC09cv+2q1kCVJ/bmnvLQ8W/g/Jtc6MgNh1wURARLoJxMLjGE+hypEsIz6BwxygpazxCYRyDSKa+k3O+dYMRUKOcpjss4zZDgo3lqjMwj5e/wvqjlvbaQ1DghV3b24A7hVGf3UtdxFB47cloH6HXzL/vJWHSkXeYiaMDYqyucY1W6yyYksNk5QY67/4d5LilL3v2C3fm4hT0RHE5LDvhAeKtbj/HiZOeWYSVhBWP0rHyvFAtU7p4NASkUH8wM6MRpmtoF5YGEWFxRraSodefKrL5ms0kodcDyScdsjOEy6Qafp0BpCO169YoqMxFjRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=llNWAbVbQKPHFmbKIFdwCSdHk/qh12AMcSXIl4F0egY=; b=mKKqZGfOML2N6UWR2Pq6outp39LHRc7WD3upsxZB6fextTwUkNBPMDFArmvF3S6d/XaDHyO2Yqh6RnvUcCclCET6ZTdlzNPG4sRlSYhy0W+j8Ww7Pwu4xSdJJZL+7cAxeR98FO1fxg72LnME+GVcLUbVzizSj/yBOSLJ69j47J0A003jEAAf4iFha65TzUvO5Ctf8I/lecoC1oaG+qEOSbWUS0qhFsjAR9YUbGt2Q31XPrH/uRS+eRZLJ2LoshaUKx4nzxXX4WyX3/kBIRXeKLlQQvgWE7//fkcwZvkQcAe2LpfcRp3pwO/UyVVmx4r+M0Q8y/TSTGIuPLys/7v1Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=llNWAbVbQKPHFmbKIFdwCSdHk/qh12AMcSXIl4F0egY=; b=BxvdMRCtCQEnnmX7J8H0UI5KO48C0/Jm2qX9/xeKCGGgWKzFlvnFTpPWr8DN9wwR4iDv4wg0SeWjltOypBf849ebmsL+n9MVHBhTPh3pW+kQCFvVwWoJKp7kD8g8GOkWQEBpmEC+fYHXftob8nYpR3DfL/JntlHRJOJVRU5WwHE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Roger Pau Monne , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH for-4.17 v4 1/2] amd/virt_ssbd: set SSBD at vCPU context switch Date: Tue, 15 Nov 2022 14:26:55 +0100 Message-Id: <20221115132657.97864-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221115132657.97864-1-roger.pau@citrix.com> References: <20221115132657.97864-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0020.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::16) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6713:EE_ X-MS-Office365-Filtering-Correlation-Id: 3521d0b6-1024-4075-e836-08dac70d2524 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yfuvDrP6VRYofAzjTqHSu51VBxskf0VogzFATNamuEXoxsueNPVRqZ2lPy3Ht3OSZpXgQhBxU/aQVBk1VGmFoHeZlRXDqtwoERhQhvttp3XPCnuRoxDqxyH9sS/z3wPWusEpJF8UL8SzGzpLU/04qnMIzyziM3JhtKpEQNu+BalTLERroplMvfEOnXKmZtEYRB7lRcBsOAl0/p5pTy09/MPB3XhMYKX6G4gZMI0/L0fQe7OrM7xFRW1ImramtMxcikizm+EhukRyJ3pMKpcTg/kELW74kSe8FM5NeCsrC/zSwYjLMCuA2b2JnD46wUzGPRBu6mgLlM3RqKfVXbLQyErgl7ktIW9pFXGMEeVfe8lgmvdyDmlInGidfF8HugzdhqGRDmtCvmnYoT7uTKNsDwQ21/e9ihS5153Wpc5lsdhveUndX2zXZ8Fl+uFERNThHFcRGSOzvW8Ck4OJFfuufHRk8+vkRDbA7Pk4hC3Y16wTJqcYriG0QKnM2k0ULwxXbpfWYwnjAPOfFVqOcQqdhAzCOG/mUURHutmd5f0iqtd20fYsfNOJspHYX0FORrmFm+PyWu2i+P3YcYlXf5NRGRNnxA0dceE9WWRLJu6NDkroSDM0+qwZcjv5RhLMdIWKU2q5TZxbi12whPLlWNwVmIp27QqfrDovOYGh8aFGIRiYbAOPSRgsYjwCkIeuLa6vRivrkd7r4oIQ+PcRscRIrA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(366004)(451199015)(82960400001)(2906002)(66946007)(66556008)(66476007)(38100700002)(5660300002)(36756003)(83380400001)(8936002)(30864003)(41300700001)(8676002)(4326008)(6666004)(478600001)(6506007)(6512007)(54906003)(26005)(2616005)(1076003)(6916009)(186003)(316002)(86362001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFl0VGhveDhoS3ZUanZpZFVNMUhaSHRmbHpRWDZ2aDdRRlVpeVJ2WGFlbUpM?= =?utf-8?B?M0pJZURZa2F6bzZKWEJyMFYrM0JpTEJOcVhvOGFIUmtQaEk4V3pQQk9taW1r?= =?utf-8?B?bVlYbDh4LzIxM2JQQjBBKzBlQzYySzNKVCtIRGFLdDgveCs4M1BBdTRHTktR?= =?utf-8?B?a25LVTdFcU1VQUUzTmFRd3AzcTB4Ynh3YlBWWXpkZmlwNUN1QjRuLzlMaEZj?= =?utf-8?B?QlBNYk9sUDEvTitOTzQvRXpOTHR6U29uMDVoeG4rSFZDZlk0U3U1TFo2VW56?= =?utf-8?B?T2pYR0dReTdUc0hMRFVnTFRsaDFIT0xCVDdmN09SRURLOTh2Q3NsUHpQd1RY?= =?utf-8?B?TTlDaVMxVnNhdVdnR3FYdE1NQjNPOWlZM3NhSTdXKzgvNmZQaFNWTDk2bkdw?= =?utf-8?B?TitreGdNVVg0SXNTZlJVWlpOZXZIVlVJNUZraTc0Yk5SaEFxNndobjlBRzh1?= =?utf-8?B?bXdEMjN4TUJ4cFI1SU4rNVlyMXU5K2k3bmp2bEFuTWpGaEhZZThIRFI5Ym0y?= =?utf-8?B?NTdKTmlNaFI4dk41OGhFKzdFQm5hSytxK3haQjN4dEVRNW9PQUF1UmY5V0dE?= =?utf-8?B?QW9rcXVIaTFaeGEyeWFtZllkLzMwK2hPRUE4eFFGOGM1dXZzQUUvQUlSNmhG?= =?utf-8?B?SnNwbWZKcmFsQVBnaFhFNWE3MWQrYXJOdmpaMm5pTTJoNFlDN0tKeUozbUJ3?= =?utf-8?B?Nmk5b2RvNG9vb2pqcDBRZTFZdUM0b2YxeHFmdmlCRVovVE94RnJ4L3JvWmpQ?= =?utf-8?B?eDlxWVk3Z21NWXpzMEV5Q0UvdVNXeTNmblE3ZXdhTUdMYVZuU1RUZ1Fpcytr?= =?utf-8?B?U1BndTlLcXR6MXRIaDRLcTFWeXVockc1U3NLWENnNnVFelNmaDFsVmhNd1VX?= =?utf-8?B?d0hsOXA0R2Z4eVdSWWVVdVk4NkZQRzYyT1ZCOUpDbHlQOFhvdEJNZDZUaEk4?= =?utf-8?B?YU9PRW9VK0tZSitNMFo3anN1cUxlR3N3ZGY0clY0aGJ5NTBQUnM3SFRzNE1J?= =?utf-8?B?TTEvQXJzeTRQb2NNL1lHekR6SldCQzFBVm1NSGhWbENnenNiOVpWVjFDZVBy?= =?utf-8?B?N0RHUzdMV1VrQStjblAvR3NqOG9BdGR3S0hhM0t5Tjh6WUQwRFJMcm9xM3lR?= =?utf-8?B?c25ONTVaVGRnZWd4empsZUthNEs3VHJmM2dCcXdYOUhrRW1vYlJnblBCRi9L?= =?utf-8?B?WEVpVWYxcVlvanJmMjd6SXk4a3ZJbEZJMWszWjlDN3RoWk1xTU9Zd3NabFUv?= =?utf-8?B?K2k5WlBna0RvWWJrNHhEWmZ6OTMrUmgwTWpGWjM4bkhPUm5aLzdSVkV2TjYx?= =?utf-8?B?TVpxTGFBL2p4K3gzYm9oZFNLaVFZRDhQUS9rYW9JdTlFc1B1a3FtRE0yNW1O?= =?utf-8?B?WXR1K0xxYkN3c3ByZ2lyb1R5eVY5S3lESFMvbmRoTk9NczcxNTJwVitkMnZR?= =?utf-8?B?MnUvSExRbUpwUFhSU2F5N3htc2lIQXRjbUR5Z2hjWGwrVHZWbXBmbGhQZDhp?= =?utf-8?B?V0pDbitqanJKV2JyYUZqVzhzYlpLS2VSMUd2cjBBaXk5MEZ0dFJKeXorWFY2?= =?utf-8?B?WTNYVmEvQjI3R0ZQbmFqdndzYTgvU2xzcWsrNUEzVG9ZcnU0eDNWQnNXYzBN?= =?utf-8?B?Mmo5ZjBDRkYyRVNBNjljLzFZRWlsRjN4dXJmcTR3NS9KVFQzTTBSSmMrMWxL?= =?utf-8?B?ZHZYWlRRS1hydW5odm5HRnhDZmNNRk4rbTFkZnczR05wY2JrSyt1ekEyYWIr?= =?utf-8?B?ZjlhSUNUZDVLZjdnK2NleTRUTXhMV1l2RlFXM0grcHhVLythcFE5OTA5bytw?= =?utf-8?B?UWpVbTZsWjBuSXdxTUYzdTgvb2psSWxSWUxhelh4K0VXTHByTmpCTGRjbmZp?= =?utf-8?B?V2d3cVlQRnNnRzJMdEgyeEFONXlvbHhBa0N1bG02S1VxYnZHYllMUjRDN0Fx?= =?utf-8?B?MXd1V3ozK2Y3a1hJMm9tSDBVQ1pxUS9CUW56akpDN2hmQlN2MTJmdVBuSXJk?= =?utf-8?B?TDJNRnNqRXorSjdqWjZiRktJaWdDNjhHb2VmdDJvdzV6ZnZ1UDlJcUp6bmtw?= =?utf-8?B?aGdqNVF2QjdYaTUrdkhJTkZoUE4vMXoyUEwxR3NydSs0M285YzduenpQWlhF?= =?utf-8?Q?pggldquZUJ6E3rpkYk5SA0nvd?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: f+Z+B5EMF0ePOQPp8NukjjBoADpHPiGBtgbnhP+wAz61bl5e0QasXgwC7HjARzTmE9BuGdloDZ5M/BiQQeubjbiRSvlZslBcj/eyz+juWI7d8s8E9sIKl50srFpTGwDf6e9zzemJSHO5OSsWh1sDr+Q5jFGW0tJySwoBy70zBudYTXX2O/fZtX7gBh2t9I5t6xNt086eEr/f1IUWfm1NyHUpRP6DCxNwH7GFO1ntwIhpkxMQFltjq3LmlsFRWbftO5Um3ECaqpqGvFeU0UxKuQFk4llLO/USaJmu+InzoaZUA48j18L9SDSoNxBPzx3q1aaE4xDT5HOz76Q2HNqhW/aQNEh06tsAqQCwtptUuiqyhuFrZA7Jt5oIccwuZtnsjqL7Xi9gUCa+XvP+UtS5tznxbR+90myf2Wz0jhSpf5xfUESb83pweu39LGOXDYLfNbqA3iONeGbd1edmtx6kjnS2Hi8C4RutMf/c6S9CebUWqD5ZVO9Bs486091VZTp4GbSFi/OfgSzljs7nJIl2kCElY3tsYGjZ0mCQ2L45vrzy6k7QUXm6APXZh2cVD1LGT4MpXxo8TnRthg38Z4ec+CbYQMDeTdfiUYGq2S/IkP1X/hCBhpsTmAJO/wEdkhSDYjwKRct2jFOIY0bmy40Tilt64gD1a7paTPfJQJbuu7vlZkca8doiEwLro3qmjOMWj0LDN+M2DegO9PpAm8JQNtEpHAnf80bdn/GUd9eDymtd3oCEvZWdf0MiPqeTPPtmdDsJFlw0kM14rT2facaPeVje0Yk/8tsQ6gunk8jL7MB0/EHMjcFhbc33hjEaqAwCUYxMDTjlLQgu/+5Axycesn5jb6IaPfNEK2UodZp2CGwscGaUeE4MPpmZcLyarDyXxDV/a9PBqDWtDT/MabUqhw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3521d0b6-1024-4075-e836-08dac70d2524 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 13:27:29.9587 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xGoCWf0xapzWKk6fgxEeP055HgzjysiZi5eTCyMB0gfybrGHSFeiKWN0fNsCjtee7zgqGvR8+YOmk4lqtSbX2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6713 This fixes an issue with running C code in a GIF=0 region, that's problematic when using UBSAN or other instrumentation techniques. The current logic for AMD SSBD context switches it on every vm{entry,exit} if the Xen and guest selections don't match. This is expensive when not using SPEC_CTRL, and hence should be avoided as much as possible. When SSBD is not being set from SPEC_CTRL on AMD don't context switch at vm{entry,exit} and instead only context switch SSBD when switching vCPUs. This has the side effect of running Xen code with the guest selection of SSBD, the documentation is updated to note this behavior. Also note that then when `ssbd` is selected on the command line guest SSBD selection will not have an effect, and the hypervisor will run with SSBD unconditionally enabled when not using SPEC_CTRL itself. As a result of no longer running the code to set SSBD in a GIF=0 region the locking of amd_set_legacy_ssbd() can be done using normal spinlocks, and some more checks can be added to assure it works as intended. Finally it's also worth noticing that since the guest SSBD selection is no longer set on vmentry the VIRT_SPEC_MSR handling needs to propagate the value to the hardware as part of handling the wrmsr. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Changes since v3: - Fix commit message order. - Remove msr.h comment about context switching virt_spec_ctrl. - s/amd_set_ssbd/amd_set_legacy_ssbd/. - Adjust comment about clearing SSBD in svm_ctxt_switch_from(). Changes since v2: - Fix calling set_reg unconditionally. - Fix comment. - Call amd_set_ssbd() from guest_wrmsr(). Changes since v1: - Just check virt_spec_ctrl value != 0 on context switch. - Remove stray asm newline. - Use val in svm_set_reg(). - Fix style in amd.c. - Do not clear ssbd --- docs/misc/xen-command-line.pandoc | 10 +++--- xen/arch/x86/cpu/amd.c | 55 +++++++++++++++++-------------- xen/arch/x86/hvm/svm/entry.S | 6 ---- xen/arch/x86/hvm/svm/svm.c | 45 ++++++++++--------------- xen/arch/x86/include/asm/msr.h | 3 +- xen/arch/x86/msr.c | 9 +++++ 6 files changed, 63 insertions(+), 65 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 0fbdcb574f..424b12cfb2 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -2372,10 +2372,12 @@ By default, Xen will use STIBP when IBRS is in use (IBRS implies STIBP), and when hardware hints recommend using it as a blanket setting. On hardware supporting SSBD (Speculative Store Bypass Disable), the `ssbd=` -option can be used to force or prevent Xen using the feature itself. On AMD -hardware, this is a global option applied at boot, and not virtualised for -guest use. On Intel hardware, the feature is virtualised for guests, -independently of Xen's choice of setting. +option can be used to force or prevent Xen using the feature itself. The +feature is virtualised for guests, independently of Xen's choice of setting. +On AMD hardware, disabling Xen SSBD usage on the command line (`ssbd=0` which +is the default value) can lead to Xen running with the guest SSBD selection +depending on hardware support, on the same hardware setting `ssbd=1` will +result in SSBD always being enabled, regardless of guest choice. On hardware supporting PSFD (Predictive Store Forwarding Disable), the `psfd=` option can be used to force or prevent Xen using the feature itself. By diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index 98c52d0686..a332087604 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -742,7 +742,7 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c) } static struct ssbd_ls_cfg { - bool locked; + spinlock_t lock; unsigned int count; } __cacheline_aligned *ssbd_ls_cfg; static unsigned int __ro_after_init ssbd_max_cores; @@ -753,7 +753,7 @@ bool __init amd_setup_legacy_ssbd(void) unsigned int i; if ((boot_cpu_data.x86 != 0x17 && boot_cpu_data.x86 != 0x18) || - boot_cpu_data.x86_num_siblings <= 1) + boot_cpu_data.x86_num_siblings <= 1 || opt_ssbd) return true; /* @@ -776,46 +776,51 @@ bool __init amd_setup_legacy_ssbd(void) if (!ssbd_ls_cfg) return false; - if (opt_ssbd) - for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++) - /* Set initial state, applies to any (hotplug) CPU. */ - ssbd_ls_cfg[i].count = boot_cpu_data.x86_num_siblings; + for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++) + spin_lock_init(&ssbd_ls_cfg[i].lock); return true; } -/* - * Executed from GIF==0 context: avoid using BUG/ASSERT or other functionality - * that relies on exceptions as those are not expected to run in GIF==0 - * context. - */ -void amd_set_legacy_ssbd(bool enable) +static void core_set_legacy_ssbd(bool enable) { const struct cpuinfo_x86 *c = ¤t_cpu_data; struct ssbd_ls_cfg *status; + unsigned long flags; if ((c->x86 != 0x17 && c->x86 != 0x18) || c->x86_num_siblings <= 1) { - set_legacy_ssbd(c, enable); + BUG_ON(!set_legacy_ssbd(c, enable)); return; } + BUG_ON(c->phys_proc_id >= AMD_FAM17H_MAX_SOCKETS); + BUG_ON(c->cpu_core_id >= ssbd_max_cores); status = &ssbd_ls_cfg[c->phys_proc_id * ssbd_max_cores + c->cpu_core_id]; - /* - * Open code a very simple spinlock: this function is used with GIF==0 - * and different IF values, so would trigger the checklock detector. - * Instead of trying to workaround the detector, use a very simple lock - * implementation: it's better to reduce the amount of code executed - * with GIF==0. - */ - while (test_and_set_bool(status->locked)) - cpu_relax(); + spin_lock_irqsave(&status->lock, flags); status->count += enable ? 1 : -1; + ASSERT(status->count <= c->x86_num_siblings); if (enable ? status->count == 1 : !status->count) - set_legacy_ssbd(c, enable); - barrier(); - write_atomic(&status->locked, false); + BUG_ON(!set_legacy_ssbd(c, enable)); + spin_unlock_irqrestore(&status->lock, flags); +} + +void amd_set_legacy_ssbd(bool enable) +{ + if (opt_ssbd) + /* + * Ignore attempts to turn off SSBD, it's hardcoded on the + * command line. + */ + return; + + if (cpu_has_virt_ssbd) + wrmsr(MSR_VIRT_SPEC_CTRL, enable ? SPEC_CTRL_SSBD : 0, 0); + else if (amd_legacy_ssbd) + core_set_legacy_ssbd(enable); + else + ASSERT_UNREACHABLE(); } /* diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S index a26589aa9a..981cd82e7c 100644 --- a/xen/arch/x86/hvm/svm/entry.S +++ b/xen/arch/x86/hvm/svm/entry.S @@ -59,9 +59,6 @@ __UNLIKELY_END(nsvm_hap) clgi - ALTERNATIVE "", STR(call vmentry_virt_spec_ctrl), \ - X86_FEATURE_VIRT_SC_MSR_HVM - /* WARNING! `ret`, `call *`, `jmp *` not safe beyond this point. */ /* SPEC_CTRL_EXIT_TO_SVM Req: b=curr %rsp=regs/cpuinfo, Clob: acd */ .macro svm_vmentry_spec_ctrl @@ -131,9 +128,6 @@ __UNLIKELY_END(nsvm_hap) ALTERNATIVE "", svm_vmexit_spec_ctrl, X86_FEATURE_SC_MSR_HVM /* WARNING! `ret`, `call *`, `jmp *` not safe before this point. */ - ALTERNATIVE "", STR(call vmexit_virt_spec_ctrl), \ - X86_FEATURE_VIRT_SC_MSR_HVM - /* * STGI is executed unconditionally, and is sufficiently serialising * to safely resolve any Spectre-v1 concerns in the above logic. diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 1aeaabcb13..fa73257203 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -973,6 +973,16 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v) /* Resume use of ISTs now that the host TR is reinstated. */ enable_each_ist(idt_tables[cpu]); + + /* + * Possibly clear previous guest selection of SSBD if set. Note that + * SPEC_CTRL.SSBD is already handled by svm_vmexit_spec_ctrl. + */ + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) + { + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); + amd_set_legacy_ssbd(false); + } } static void cf_check svm_ctxt_switch_to(struct vcpu *v) @@ -1000,6 +1010,13 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v) if ( cpu_has_msr_tsc_aux ) wrmsr_tsc_aux(v->arch.msrs->tsc_aux); + + /* Load SSBD if set by the guest. */ + if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD ) + { + ASSERT(v->domain->arch.cpuid->extd.virt_ssbd); + amd_set_legacy_ssbd(true); + } } static void noreturn cf_check svm_do_resume(void) @@ -3116,34 +3133,6 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) vmcb_set_vintr(vmcb, intr); } -/* Called with GIF=0. */ -void vmexit_virt_spec_ctrl(void) -{ - unsigned int val = opt_ssbd ? SPEC_CTRL_SSBD : 0; - - if ( val == current->arch.msrs->virt_spec_ctrl.raw ) - return; - - if ( cpu_has_virt_ssbd ) - wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); - else - amd_set_legacy_ssbd(val); -} - -/* Called with GIF=0. */ -void vmentry_virt_spec_ctrl(void) -{ - unsigned int val = current->arch.msrs->virt_spec_ctrl.raw; - - if ( val == (opt_ssbd ? SPEC_CTRL_SSBD : 0) ) - return; - - if ( cpu_has_virt_ssbd ) - wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); - else - amd_set_legacy_ssbd(val); -} - /* * Local variables: * mode: C diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index de18e90b2e..3eef1dfb98 100644 --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -378,8 +378,7 @@ struct vcpu_msrs /* * 0xc001011f - MSR_VIRT_SPEC_CTRL (if !X86_FEATURE_AMD_SSBD) * - * AMD only. Guest selected value, context switched on guest VM - * entry/exit. + * AMD only. Guest selected value. */ struct { uint32_t raw; diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 95416995a5..cf46b18aa6 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -24,6 +24,7 @@ #include #include +#include #include #include #include @@ -697,7 +698,15 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD; } else + { msrs->virt_spec_ctrl.raw = val & SPEC_CTRL_SSBD; + if ( v == curr ) + /* + * Propagate the value to hardware, as it won't be set on guest + * resume path. + */ + amd_set_legacy_ssbd(val & SPEC_CTRL_SSBD); + } break; case MSR_AMD64_DE_CFG: -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 13:27:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 13:27:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443948.698709 (Exim 4.92) (envelope-from ) id 1ouvyZ-000095-JD; Tue, 15 Nov 2022 13:27:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443948.698709; Tue, 15 Nov 2022 13:27:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouvyZ-00008w-Fr; Tue, 15 Nov 2022 13:27:43 +0000 Received: by outflank-mailman (input) for mailman id 443948; Tue, 15 Nov 2022 13:27:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouvyX-00083Z-FB for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 13:27:41 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 45be2609-64e9-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 14:27:39 +0100 (CET) Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Nov 2022 08:27:36 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB6713.namprd03.prod.outlook.com (2603:10b6:a03:404::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Tue, 15 Nov 2022 13:27:34 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Tue, 15 Nov 2022 13:27:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45be2609-64e9-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668518859; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=m0LCQ3pgEBmcqIxE+QCQbONxN6i33lfwBBBNYVosPS8=; b=FCI/63CQemdFCK+4QG7aN14CZIHoDoQy+TTqa6J8f3gNJTQ3G1yGxckb PLkSBIJlf3kgVgFVCfx6fOoyoNDGrJy9iFEChtb8j60TbLLyZOF4XsYsu eISTbnjkoXtX5XEDIbRubNEx89SoOrVhBO9yruPU4uG7fZ3bU0b/teJgE A=; X-IronPort-RemoteIP: 104.47.55.176 X-IronPort-MID: 84870987 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:WkXF2KjS3YWPsrPQgzRCNSJnX161UxEKZh0ujC45NGQN5FlHY01je htvXzuPbPnbMGT0fdsjb9nk8BwFvpGGyddmHAI4qHtjHigb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QaDzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQGBmonYg6cgNm0g/GJSuRjmNYfDNvkadZ3VnFIlVk1DN4AaLWaGeDgw48d2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEsluGybrI5efTTLSlRtlyfq W/cuXzwHzkRNcCFyCrD+XWp7gPKtXOnCN1KRe3nnhJsqGKZ10k8DBkUbgS6uf3lqWmSBvZZd 1NBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQGucksVHoV3 1mGt9rzAHpkt7j9YXCX+6qQrDiyETMINmJEbigBJSMa5/HzrYd1iQjAJuuPC4awh9zxXDv2k zaDqXFkg61J1JFVkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5 BAs8/VyJshUZX1RvERhmNkwIYw= IronPort-HdrOrdr: A9a23:r581paHdz+lU+gxspLqFiJLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LK90c67MAnhHP9OkPIs1NKZMDUO11HYSL2KgbGD/9SkIVyGygc/79 YeT0EBMqyWMbESt6+TjmiF+pQbsaG6GciT9JvjJhxWPGRXgs9bnmRE4lHxKDwKeOAKP+tOKL Osou584xawc3Ueacq2QlEDQuj4vtXO0L72fBIcABYjyQ+WyRel8qTzHRS01goXF2on+8ZpzU H11yjCoomzufCyzRHRk0fV8pRtgdPkjvdTGcCWjcARCzP0ziKlfp5oVbGutC085Muv9FEput /RpApIBbU511rhOkWO5Tf90Qjp1zgjr1fk1F+jmHPm5ej0XigzBcZtjZ9QNkKx0TtpgPhMlI Zwm06JvZteCh3N2Az7+tjzThlv0m65u2Arn+I/h2FWFaEedLhSh4oC+149KuZIIAvKrKQcVM V+BsDV4/hbNXuccnDip2FqhOehW3widy32N3Qqi4iw6Xx7jXp5x0wXyIg0hXEb7q8wTJFC+q DtLrlovKsmdL5ZUYtNQMM6BeenAG3ERhzBdEiIJ078Ka0BM3XR77bq/bQO4v2wcpBg9up8pH 34aiIZiYcOQTOsNSXXt6c7sCwlAV/NEQgF8/supqSQ4dbHNf/W2S7qciFdryLvmYRaPiThYY fCBHtnOY6cEYLQI/c54+SHYeg1FZA/arxghj9pYSP4nuv7bqvXi8f8TNH/YJLQLBdMYBKNPp JEZkm/GPl9 X-IronPort-AV: E=Sophos;i="5.96,166,1665460800"; d="scan'208";a="84870987" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i3MtDTsjz0AlGH7dMMkpDrCzIouYFYcUa8emqub+ITtdzX3S1R7x3vw2QjFAwySmkUt/vFeYRf8j8CFdilAdqmGQLS4iVOvVWl7EKIpSFWAVeBMb2iRWeeUbJSmemvM6lTSdBNRPpF6RjlpsaOkDpkd6wtBs2JpPMbxrcUOgv96da8kL9cgLgDR1l2uZFmeLX/+BxtobHboCxPOtzQ+zYC0qMjqkHTcQSn+sgOr3EiU86/MEjSwVGAln/iZsY6OJXCedmtX2EsY03XoVcQnKZT8bGBs4nNvMNTUaXYtuVZztmpi9kgDQatlcw6ZAsVRs8tTjPCmGWLL1OoY0lHZNdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZBqo2QiWYWkQZQXQeC7ooG/JWWPEbzacJedkLW/eU4A=; b=UYwZSjxJ/HQ3XqpJYJ4xYg8dogLuxt9xoRodDtugw3l/O9P51p15EtVy37tdpuFfQS0ZgKY4uS/wEY35hdypMuj0jghpKPTmCFgBnZhRoOcbvhAi965pgBe0zscxeD3r3P+xo/sge1wIcxhl/k/hV+WCCBjmGvFBkW8m0KqWQNDmFapmixbpJKMxVki/Hh5xURZtqQwz2NN83DxmfHw7ILIumu+pm8eIm3q0of5/fmDbloIX5mV2Zn/i3tq6UY6dX2JQeFwZBmSWe2qRq0KACcPKXgO0Gpb9DhuOJGVMpcRRKwe8LH48xbdLy8NtCUEumd/FZpgkOJqHnEq/k9m8GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZBqo2QiWYWkQZQXQeC7ooG/JWWPEbzacJedkLW/eU4A=; b=JJFfMDDw6uWec7GtWRvlKX00vILk3boSEbw5Qs4cL+CXHGne/uNIttxFyNmDUtb+2L9CNQ+fGbQbiUh+JbgBgumyFLgOtqeRCaIGmdAPeUiXxmpSF6lirumvjFsseO1n6vfLbzlUqBIGUwzM/BFoHv9sqWIf6v49yrDcg4MJn/Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH for-4.17 v4 2/2] amd: remove VIRT_SC_MSR_HVM synthetic feature Date: Tue, 15 Nov 2022 14:26:56 +0100 Message-Id: <20221115132657.97864-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221115132657.97864-1-roger.pau@citrix.com> References: <20221115132657.97864-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0512.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::18) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6713:EE_ X-MS-Office365-Filtering-Correlation-Id: f8c1b6ef-2f52-49ab-9772-08dac70d27e4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EHnMRbuw75xfQ9f2frehTFQky7hgmbR93eAHQnM4mcq5YJSupwGFPC00TB6WDipF9lUZuGNSKP+iuNNiFEKVKvDzmX1JN4kFgsMAKg4masZIYeo4RPPp1o6YtF17EWPvpVeA4ETyqLytajMDeusejW4gwnhOd9fjXnYjyfXVV0wHbnsk7RFGsMeAQIcy5l3vP+av4pYr2CbTpsYp9RWBPTqcxdFqZ6icxtXAbIkOU0ZVea2Mr682ZwvB4X8MKxePWm54rY4AEM1sMXPXumBMltngnV5wAWOXJepJubLB7iHrrcqGgDksvplKvXTyI/QmUkBqMrFdO2WY8vcM4nrhnGbvHyyZgeI6I92PeYLR5H4VVCT8DzjlE8QwgEXN54ile6nGsv8SGBA4bAqa/Ug+3JaimOVB3BMakZ7M2ub8zh6Hgxj1goDuATq3Ac0QRFQwU8OhDH3/Fm5ejowhJVYdYbAhfrruqZV1jr1bEGiDCQtW1wLB+3IZNSUmB7MJqTYwVj+cQ5cqaNm0g9LxCo5YFmabfQH0LK2f6UaQrfr1sDT6MZNWh+/W8OdMlUBwv8B7hCIb9E2s4SNkPNaqzsCwD6qAqEGX7EyBzambZapT5Xw0wLBpLL5zT7FynuXaGmhzqaD9S3F5eiaYg9ddXV7Ap193bFHfIc383imFud8XuH01qTOm99hdDd5UIa2ScnQ3HRmMBxRElboIPiAHze8oSg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(366004)(451199015)(82960400001)(2906002)(66946007)(66556008)(66476007)(38100700002)(5660300002)(36756003)(83380400001)(8936002)(41300700001)(8676002)(4326008)(6666004)(478600001)(6506007)(6512007)(54906003)(26005)(2616005)(1076003)(6916009)(186003)(316002)(86362001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3RJczEzUEYrL3hHY0wydWhZbTZHdHBHZ1NKdE4rczhDSm5ucERDR3phSnJQ?= =?utf-8?B?QWoxS0NmUVZaNVBGSGNvMTNMSzJHZ3JzMXZKM256ZE9EYmc3RlFyRUVkNDI3?= =?utf-8?B?NGpFamZaUkYyY21QK1N1cFBBUjBGcjM3MGd6U3E4RTU2b3d3S1A3aEJrby9B?= =?utf-8?B?c0o1TWNWY2xHQUM3VmhJZ3YranlFb3Z2dHdWc0NaZDJpR3Byc2loajVIUjhj?= =?utf-8?B?Nk4wa3ZBUTVxNklQWTFBNUtxMDY1TWd0QVlJZXh3SWZVZ3AvaStYUkg4bmxV?= =?utf-8?B?anpvcEkyM2tndmpDakhEUGtkYktnbWxqWVYweFhKdUhRaWRxT05KNk53Wkdi?= =?utf-8?B?eFB5emczWlNucVYwZFhKWWowSHVRYStidEVwaitYZStYall5R21HZUwyM2xN?= =?utf-8?B?M2FoSm9ZUEhQdjFOSVlRUithMDl4ai9WYWlnUGNkakJMSmtMcUhNRjlJaUEz?= =?utf-8?B?ZjdyUTNKK0xhNDdSNERta0dHd29Ha0xFOXVJeHMwT3hmWTAxMGhES1RHZ1JH?= =?utf-8?B?REpsNWhqejQ3U1pUdDBMckNObENDVmdlQ0xQdWo2YlBlR2pHeTFmR3pnSi80?= =?utf-8?B?TnpTMDlvdFluWTVGWUNyVVRXOVZxQUlHR0QzclR0LzBMOTdPNGY2SllkOTdG?= =?utf-8?B?YmFhTzAwUmk1NHBjc0Uzem5EeUE3QlBOai9STUxMOHlmdk42aysvZXVJTUFs?= =?utf-8?B?MEVhUkRiNlhyTXdBUkRBSXM5cHZVNVcrTStmOXpwQ01RUm1BR2ppaXM4RUt2?= =?utf-8?B?dUFBMi81MkNhUjJLVGxmbjd6OXpiWlZmNy9VU2U3RDk5RDFQTmwvRFViOHpQ?= =?utf-8?B?b2djSCtaRkxMOXJINDZUNGtXeTdRaU85dWlJVzYvU3RFVnBhdGhnOHhTMHJ3?= =?utf-8?B?bGlkLzNrTVhNbHRUbWNiOXRSZ1BCVVUrRVZwTEUrWGF2b0VhR1cramZUY1F6?= =?utf-8?B?aEM4ZVBkYWFnOVRLQnJoa0lrMVlGK3Vld2h6Z3E4N25RME84VDUwc2dtcTlC?= =?utf-8?B?RzdMaUVVNjlmYmNNY0dKOU9HanZSMmNtYlRnZVdHNXBFTS9saUVoRGtvMGQy?= =?utf-8?B?YXNaT0srWUN3NlpJR2hIbU5aWHJTNFhqR05IejNFME1jOGNDU2NZUUZYemdC?= =?utf-8?B?cHhBb0xOVm5DOEFFcm5PUUtyZjE0RWdoYlpSL1BWTER2eFY4cytFSHRFR3Vx?= =?utf-8?B?RWRwR3RGeEJKQ2RMTEliS01GeUJhWWNOcWw4QUtqOU5LVjlvWVR2TGRaWFdX?= =?utf-8?B?L0h2aE53ZXh2YjFwZkVqN2tud1FrV1ozY2FEajQ1akdxSytDd1llcTI1QUJo?= =?utf-8?B?S25YKzhNSTFuZS80NkVhV3QwcXVVQXB6VXA5NDRIYk5kc21jL1lPRGZzV3Zr?= =?utf-8?B?TVpsUUFIMjg4KzhUV3ZVbWE4WmhpZUhJZVI4cTJtMjg2NzJDdHdNM3QzT3dl?= =?utf-8?B?L2FLdTFjMzUxMlErVDBMR09tTUkvU3ZnOWRLelptby91MU12cElzR2JSNkcr?= =?utf-8?B?S1ZzYUk3TmoyMnpMRk5EYVdmQW0rMTRTcVl5b0s4djNCUnlJMkVPRndmbDhZ?= =?utf-8?B?eDZ0TzYyNUJLN1U3OXAvZHhqSVZzdlFZMExjZmVlbzU4bFFTTTFEeE1MWEJj?= =?utf-8?B?elI2akV1LzhRaEJ4RlgyU1Y0N1JqNTJCZkkyTS96cVFRbE0zWEFKQWtreUJU?= =?utf-8?B?dktLZTY1a016QUdlY3FEcmxjdUxhdGxVRlF3ZlgyY0JXYk9zd3JFU0tlSi9a?= =?utf-8?B?TSszZG5ScW9oSTVrT0FtZzhRZ1AydkNSS2h0eGxIcWExaUtVeWtHOENvOVZI?= =?utf-8?B?ejZsNlppUmVRYkZaOURySDAwRDhDdkhOUHhGVDVyMGs5NXVNV1hYWTd1WXlM?= =?utf-8?B?Ykdudi8yK0VUdEU2NzNrMG1oNDZvakpQUlJXU0p2dnF4bmxxTTRXUlc3cjU2?= =?utf-8?B?Y0NKNFVXNkJkN1Y3QmZpZWVPdjJpQyswME0rVHprbjAzcWcyOEJoZkpwR0Jr?= =?utf-8?B?Tkg5L05pN0tWSHFFcVVNZkRJN2pHUTU2UFA5N2ljOVBiNjZxM0x2SXdLcGRs?= =?utf-8?B?dThDS0dzODFmR2pQYWNtUm5rcUxGZ2Q4MGdjZGJLYTFEN3dsQUlnUHQyeXlJ?= =?utf-8?Q?fVK/SBUQK80uZDx1Gfgs0Xfx1?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: PfLftu1DsiVrjdnvtdKG0TU1RdLkV5qDrPP2dgVPRn2C3WQkQ4IxZGlh1W5PXa6oEZE2jF1ifrOh3rlxh0oj4a4Ot2Aw0lJtW1BCucztbQf0UT2lgjN8UK4bFBBTZIG3qqLlt0zGhw8Tlio04r+2X+1y4aaUztri/YGtzz+MGm42SzZhf7PF0pjEU6eGIdSHgh0HiMDyh0CqxCQzm1qTzw8l1zbLos6iwkYMNiFpOXsR7WZEQyZSbuwYxqGlX6M9tbqEEkBfHKJpw3QwWT2HNhEhV7tiVac824PMma2u6+8HW0qP/zBeEf/3lK/LL56FGFJuRmlDRDvt6c8qZ4VlAuioB1fgtww7eu0DjbaJXHnE7abXJP8UnoyXp5tAGfbQwK3oMdgGp6NZrM4pAq11hrUbqWxNUXE4z0J5XmA8wNAmRu9zTXiEqQAQhUFISkRv48I2XjozHqtGmeZrt4G1EMkgFnbjYWQurzChjOilA8mjOK9Tq/A/zuc75DEctIEXjPKWrQZwXb11z5Ci3wmIqs5fAWCDguqaw7rvX2SwVEv13eMLiI7zXwpWMiuE5pAvhjQ0DVA86qMuQhudi6enNBlPW8am4RmI9Y25EV0S3DC6hYp33O1wJYs8TCR+2i29lbIEl/fpl3NKzHWirUd9Dzlbu1d67i7xNcUPAVjU04Z28gmQJ8mhdRAJfsXLZXYbEA7OSAP7TO7WtfIg8yTpK52KeNjhak3kgt/YDuNwkKZqffgYmghAYO1VZsUCbn2romY2Ffd26N2kI0jRk+CCajNT5vLe8PTERJeVItD1I5s4iX7SqDX1q3QO/FLzvsJa9zz88GWaZX44dTSFVKs3YLRKLz4eaTyNkHu4Yg7BwnQ= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8c1b6ef-2f52-49ab-9772-08dac70d27e4 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 13:27:34.6953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6QmPzw/4AaajLG9wqwhkTQcPj4JRP4cxHQ36WmZ9d3HVKCp6UlwpfZCjIDUjhIDtm/4scoNLECGON79OBptdOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6713 Since the VIRT_SPEC_CTRL.SSBD selection is no longer context switched on vm{entry,exit} there's no need to use a synthetic feature bit for it anymore. Remove the bit and instead use a global variable. No functional change intended. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Release-acked-by: Henry Wang --- xen/arch/x86/cpu/amd.c | 1 + xen/arch/x86/cpuid.c | 9 +++++---- xen/arch/x86/include/asm/amd.h | 1 + xen/arch/x86/include/asm/cpufeatures.h | 2 +- xen/arch/x86/spec_ctrl.c | 8 ++++---- 5 files changed, 12 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index a332087604..9e3b9094d3 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -49,6 +49,7 @@ boolean_param("allow_unsafe", opt_allow_unsafe); /* Signal whether the ACPI C1E quirk is required. */ bool __read_mostly amd_acpi_c1e_quirk; bool __ro_after_init amd_legacy_ssbd; +bool __ro_after_init amd_virt_spec_ctrl; static inline int rdmsr_amd_safe(unsigned int msr, unsigned int *lo, unsigned int *hi) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 822f9ace10..acc2f606ce 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -3,6 +3,7 @@ #include #include #include +#include #include #include #include @@ -543,9 +544,9 @@ static void __init calculate_hvm_max_policy(void) /* * VIRT_SSBD is exposed in the default policy as a result of - * VIRT_SC_MSR_HVM being set, it also needs exposing in the max policy. + * amd_virt_spec_ctrl being set, it also needs exposing in the max policy. */ - if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) + if ( amd_virt_spec_ctrl ) __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); /* @@ -606,9 +607,9 @@ static void __init calculate_hvm_def_policy(void) /* * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus - * VIRT_SC_MSR_HVM is set. + * amd_virt_spec_ctrl is set. */ - if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) + if ( amd_virt_spec_ctrl ) __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); sanitise_featureset(hvm_featureset); diff --git a/xen/arch/x86/include/asm/amd.h b/xen/arch/x86/include/asm/amd.h index 6a42f68542..a975d3de26 100644 --- a/xen/arch/x86/include/asm/amd.h +++ b/xen/arch/x86/include/asm/amd.h @@ -152,6 +152,7 @@ extern bool amd_acpi_c1e_quirk; void amd_check_disable_c1e(unsigned int port, u8 value); extern bool amd_legacy_ssbd; +extern bool amd_virt_spec_ctrl; bool amd_setup_legacy_ssbd(void); void amd_set_legacy_ssbd(bool enable); diff --git a/xen/arch/x86/include/asm/cpufeatures.h b/xen/arch/x86/include/asm/cpufeatures.h index 3895de4faf..efd3a667ef 100644 --- a/xen/arch/x86/include/asm/cpufeatures.h +++ b/xen/arch/x86/include/asm/cpufeatures.h @@ -24,7 +24,7 @@ XEN_CPUFEATURE(APERFMPERF, X86_SYNTH( 8)) /* APERFMPERF */ XEN_CPUFEATURE(MFENCE_RDTSC, X86_SYNTH( 9)) /* MFENCE synchronizes RDTSC */ XEN_CPUFEATURE(XEN_SMEP, X86_SYNTH(10)) /* SMEP gets used by Xen itself */ XEN_CPUFEATURE(XEN_SMAP, X86_SYNTH(11)) /* SMAP gets used by Xen itself */ -XEN_CPUFEATURE(VIRT_SC_MSR_HVM, X86_SYNTH(12)) /* MSR_VIRT_SPEC_CTRL exposed to HVM */ +/* Bit 12 unused. */ XEN_CPUFEATURE(IND_THUNK_LFENCE, X86_SYNTH(13)) /* Use IND_THUNK_LFENCE */ XEN_CPUFEATURE(IND_THUNK_JMP, X86_SYNTH(14)) /* Use IND_THUNK_JMP */ XEN_CPUFEATURE(SC_NO_BRANCH_HARDEN, X86_SYNTH(15)) /* (Disable) Conditional branch hardening */ diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index 4e53056624..0b94af6b86 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -514,12 +514,12 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps) (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) || boot_cpu_has(X86_FEATURE_SC_RSB_HVM) || boot_cpu_has(X86_FEATURE_IBPB_ENTRY_HVM) || - boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) || + amd_virt_spec_ctrl || opt_eager_fpu || opt_md_clear_hvm) ? "" : " None", boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ? " MSR_SPEC_CTRL" : "", (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) || - boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM)) ? " MSR_VIRT_SPEC_CTRL" - : "", + amd_virt_spec_ctrl) ? " MSR_VIRT_SPEC_CTRL" + : "", boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ? " RSB" : "", opt_eager_fpu ? " EAGER_FPU" : "", opt_md_clear_hvm ? " MD_CLEAR" : "", @@ -1247,7 +1247,7 @@ void __init init_speculation_mitigations(void) /* Support VIRT_SPEC_CTRL.SSBD if AMD_SSBD is not available. */ if ( opt_msr_sc_hvm && !cpu_has_amd_ssbd && (cpu_has_virt_ssbd || (amd_legacy_ssbd && amd_setup_legacy_ssbd())) ) - setup_force_cpu_cap(X86_FEATURE_VIRT_SC_MSR_HVM); + amd_virt_spec_ctrl = true; /* Figure out default_xen_spec_ctrl. */ if ( has_spec_ctrl && ibrs ) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 13:27:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 13:27:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443946.698687 (Exim 4.92) (envelope-from ) id 1ouvyU-00083m-2W; Tue, 15 Nov 2022 13:27:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443946.698687; Tue, 15 Nov 2022 13:27:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouvyT-00083f-UB; Tue, 15 Nov 2022 13:27:37 +0000 Received: by outflank-mailman (input) for mailman id 443946; Tue, 15 Nov 2022 13:27:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouvyT-00083Z-4K for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 13:27:37 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 43515c48-64e9-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 14:27:35 +0100 (CET) Received: from mail-bn8nam12lp2177.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Nov 2022 08:27:27 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB6713.namprd03.prod.outlook.com (2603:10b6:a03:404::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Tue, 15 Nov 2022 13:27:24 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Tue, 15 Nov 2022 13:27:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43515c48-64e9-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668518855; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=o1c92K8E2/WuwVnA/VrVYjtQGgrD0onohOcw6L2hy44=; b=Jnv1Qt9YI022qS8RfIhrsLlcYpiT2JngVUY/spWdpA4b0eVPxk5rDRbL 0vAUJPc6nYyAiMHfcVGCy8tiCH7CvdPvDF1xGy5wz3iqj+ta/QrEZJ1ZU WhJbS0buDOyiZf6mBUKyeEXqY+URmTr7uQYgQMrTTtsFi77idQJpOORKu Q=; X-IronPort-RemoteIP: 104.47.55.177 X-IronPort-MID: 87387751 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ezhNUKLpqJdGSVWqFE+RCpQlxSXFcZb7ZxGr2PjKsXjdYENS1zJUy DZNXTyBPKyLamDxLdFwPtvkpx4BsMLSm4A3QVFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wVjPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5oD3AN7 Nw9BwsSZwqD1tuV5uLkVuNj05FLwMnDZOvzu1lG5BSAV7MMZ8CGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dqpTGMk2Sd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iLz3b+Qwn6iMG4UPL2UseVajAyf/EkeEDcVfF3ks/KDoHfrDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAkQzhbeZoZvck5bTUw0 xmCmNaBLT5lvaCRSHmd3qyJtj70Mi8QRUcAeCsFQA0t89Tl5oYpgXrnVc1/GaS4itn0HzDYw D2QqiU6wbIJgqYjyKGT7V3BxTW2qfD0ohUd4wzWWiev6FN/bYv8PYiwswGEsrBHMZqTSUSHs D4cgc+C4esSDJaL0iuQXOEKG7Lv7PGAWNHBvWNS81Aa32zF0xaekUp4u1mS+G8B3h44RALU IronPort-HdrOrdr: A9a23:T45pAK3MkF4i9fEyEAYzXQqjBcZxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjjfZq6z+8M3WBxB8baYOCCggeVxe5ZnO/fKlHbexEWldQtqJ uIDZIOb+EYZGIS5aia3ODRKadb/DDtytHMuQ6x9QYPcek8AJsQlDuRRzzrZnFedU1jP94UBZ Cc7s1Iq36JfmkWVN2yAj0oTvXOvNrCkbPheFojCwQ84AeDoDu04PqieiLolis2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv+/olbg9zoz/pEHYiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2e XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvHxUWDiXXujMTlTHZiYvAx875xQ1/80Q4Nrdt82K VE0yawsIdWNwrJmGDY68LTXx9nu0KoqT4JkPIVjVZYTYwCAYUh2rA3zQdwKtMtDSj64IcoHK 1HC9zd3u9fdRegY3XQrgBUsa+Rd0V2Oi3DblkJu8ST3TQTtmt+1VEkyMsWmWpF3I4hSrFfjt 60fphApfVrdIs7fKh9DOAOTY+cEWrWWy/BN2qUPBDOCLwHAXTQsJT6iY9Fqd1CQKZ4gqfapa 6xEW+x7QUJCgLT4Iy1rdd2Gyn2MSqAtW+H8LAc23B70oeMNIYDfxfzCmzGqPHQ3cn3MverJ8 pbB6gmfMMLVVGef7qh/zeOKaW6ekNuJfE9i5IcZ2+khP7tB8nDitH7GcyjVYYFVwxUEV/CPg == X-IronPort-AV: E=Sophos;i="5.96,166,1665460800"; d="scan'208";a="87387751" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ep2cp77bAW4Up775s3vWKUVIOIeW9RR9K102Hz45udGN7dB5Bg/1tbIwyoChpr0P201GE+HH22E5VOZanUd9zFZ3WRGETWNee1DQ1HNCOUWl6Le3aF+GMehw8ljKt3b+NZJ0VBSGPq2xirR6SqkFniF4dU54Tc65wxehm33Kzs0QQN6gBmk8Xlz3wBSS/qldBWPMXg+76evWBi9tdMGwrkZGqFEGo53TCoIQFkbIuJPtETUQabcCOgnkt+SjKpnLb5bIHhSxUM+WuMNkBZGjKTIM89duJiWhV10fMP5h9jh7YPJBPv2If2yk28cBlY0BH264MST3bNA4R2v+0dlhlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pkNy96xUO2/O5XKJY1CODRf7oTA7fVpbICttqPA7ERo=; b=in1rGBqZpTmSoGp5moZN+7vr7Va2+F/X84J7+2ZMC7ryTaq9/82+OjWQRGDGB4N4Sdm3M3h9jCIPwH9AoMYFbAJiag00AGshDlbGocgpu6b9Va03G03GiJ7jRJR31p6VRZAS8ZUmlpnrSiFnTwXRs29OfV9J4M2i8012VEbcluFXOI86a3xrFPABA19o5QvIcBqRgcl94PUPyc/sjWzwUL+zMbkPNwUGNOWhRgBqirTrq/6u7KrmJkQ8fQzMG6sKHhdYUG7zR/e8VJxd7bVxl/cEn9MdWp26yBjL9IDQhypKhPOKdOGef/R7tIA6qOaLQ6AbCiBOMiZrBzKW4DZLgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pkNy96xUO2/O5XKJY1CODRf7oTA7fVpbICttqPA7ERo=; b=vHZUb4d5m8xkT/LgoXZYu7FGCvqzIqGE/35ZUVG0VVWbuCeLlaoDuvNtLyEUXU+BJcDgVT5TPY2jmMHfZMeBhXThzksouh7u+VznqvVlgCsCnUGlJUsinOZX6cF0sPNLknP1uKe+r8gCZudYKEhuDwUn3QJh2uZWcEdaEMM4Jr8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Roger Pau Monne , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH for-4.17 v4 0/2] amd/virt_ssbd: refactoring and fixes Date: Tue, 15 Nov 2022 14:26:54 +0100 Message-Id: <20221115132657.97864-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0059.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::15) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6713:EE_ X-MS-Office365-Filtering-Correlation-Id: 83e2fd7c-6d33-48cf-9c88-08dac70d21d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yrSqsBexMSGl2xPnJTg9L4qlW7Yu67G9cXMRJr7zeFcePQA1rylfM9tLT4RYh5nDJWs50/KOyx1Jt/gAA4Os7VaEUexOdgh/e81CdXgOpGLudaF02kNK118v+GBG0FOKJEwM9PiLgtENIpmHLOVQkrTKTJIjzi6t0Qc2uTNT427pZrbvtMnv+7sY16LXAFzsfg+v/Y9TEq0l/n+W/gPN/KZSwK+my5BSbhCk2IsFrsOZyDR9FHBmnDFLoMfTyulu0qRA4p2gBNnvUU/j4qsf0M1dKcHIs1kAE4ytE7z51OkWyc+LZdM5xB94UZJ3v1ik/1yi9VGMrjtUWOIo5UDFjwRtCIxL8THCDb0P5TXAGGdxOyNRT1fToXzwDUonPM2j+PGuqtAApjouUZVM2/pA9CosHIiWKy640GUHoDgzXn5PpxWN2t9ilI8F1XgLQTwJt0ubP3d2CkO/NBg1fm/8v/xPUeZqlO9Xt2d7rketRscbccWYhB4JaJIPUTDdQgYgQPwHPhNl3HqY4Ud8eEzG2ybIDXD0CgT6my6DgNylwWynqa3WIYJtH2dZYvLlL6HVGplV7bUmSi5z50/NF7xncv0hQHU1dWTTwgiUhfN977ufR4VscF4V2cwbKfQQxSdfqRBDmGGFd6xwRpL/OFlZEmuBEAZQTKmC6+AXa5fZvh/dBmU/oo+ZSuu8NV6Jkx3MHD5sb4W+K2vaC/2OhEefaw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(366004)(451199015)(82960400001)(2906002)(66946007)(66556008)(66476007)(38100700002)(5660300002)(36756003)(83380400001)(8936002)(41300700001)(8676002)(4326008)(66899015)(6666004)(478600001)(6506007)(6512007)(54906003)(26005)(2616005)(1076003)(6916009)(186003)(316002)(86362001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlA0Y0QwZTg2TUs0aXlBelBnVzNHeWVwU1FPcnpVbE9HaVVkTjNSaE40dlZG?= =?utf-8?B?aWdiQTRaNmlXRkl4WGJVL3libVF6NGxYVjl2V3cvc080MVMvYVVvRFJOUCtP?= =?utf-8?B?ZnNrTnBBc00rTmQzTE5KUVJNUjdlRlE4SGxEOHp4cGRkWW11NzVzQ1N1cytN?= =?utf-8?B?cWFiSjA4cllYRk1CVXVlbGNsQTM2WG1EWHJ1bkxyVlpNRmRoMGFhU0tpOTBw?= =?utf-8?B?eUdFMHNHYVR6dUF2cncyOHpqQ0RaYzFZeVR4cWUyNTZ6RFBoQkRNSU5vMUY0?= =?utf-8?B?emdqTWNCdm0yMk1RV0VKMEtDR1ErSTlHdmFNWGhPQ2lUb2J5SGZLVThJVmZI?= =?utf-8?B?aDFnQjdIajlyMHppME9NWGhZNWFpcngxQS9BRXQ1aE5xNzhaN1JSb1hxZVp5?= =?utf-8?B?VElaeExFVzhSOXo0QTJMQ3NpK2dCM0xJcytramhuY3J5blUzSWZ3WFd2TzMw?= =?utf-8?B?WEltOUsrNnpiVEdDN2RXNkVyL25kREdjOEhvYW1ZR1RpUUF5QStvUGdYQ0JJ?= =?utf-8?B?TlhzRElOUWJ5K0hpUUYxZEVwQnhCMjlXQ09NZDhkZGdvaGgwNWtra2NCeFE2?= =?utf-8?B?d053cUJHdysxZk0yNzExSVA2cVRKdzNWd05kTVVBT0g2OTJhZVVIZjVaNmYv?= =?utf-8?B?YlpyS2krNzNWM1h5bXU1U0tZUDFsYUhGc3d4aVZUVHNnV1hYOGJ5MWFqVnp6?= =?utf-8?B?R1gvNlZYK2psbENzK1I0VUh2em5OWksyYndmck9lL1Y1Z3ZPM0dHdTdrSnhJ?= =?utf-8?B?MTUxcUNlS1M0ZUhpWmhGdm9LMEh1YmlyUUdPdnF2TUZUV0xmbzB1Y3pWVUxy?= =?utf-8?B?UEdUbDVCWGx6b0g4ejFmVjNEeEFweE93dS9BWC8vT0lSZERaZzJrdkpWdnpy?= =?utf-8?B?dUJQUkNkT0xQU3M3VFBKZVRXdWJlRUFJZ2l1eHJvUkFBaDk4UisreU1FR1Ju?= =?utf-8?B?UVNYbzVLeFhjRmVnTFNXSkc5SWY2alF0clJaRzlrU0xTSUJPMnExL1JNcHhl?= =?utf-8?B?T2ZieW5qQXBOMmZmMldKa1J1TXFTTTN6L0dmZzU2cVFBS2YvTTlRWFBtSjJR?= =?utf-8?B?b0J6ZzNOVUtwQW4vb2ZnRlZyVW9yWWlzak1ENXVFK3IzMkttVCtodlQ0SEFy?= =?utf-8?B?VzZJTDgvL3NvVldtcmtMR2U2Q0lhTlF6K3pnS2VNcnNVTCtVbkFibW1neFJ3?= =?utf-8?B?ajlvNGhzcEFIT3JQcDJ6c05pODB3MGFXbVpHbXpDTk94RjF2aGRuRk1oblo2?= =?utf-8?B?OWh5WFZjRGtKMHFsUnEyRFJId1M3bzB3ak5CZm1nSzhtbXZqcm1ybWdvS3I2?= =?utf-8?B?UWFNak5MYXRFbW54MjdOQ29SdW83ZjVkQU9ENlFnQkFKVHdTVFB4dmt2aEdO?= =?utf-8?B?N2o5MUtrcHFjZU56L0ZNcmFoZTdGNy9ON2xoL3JHSi92azhWc0gwQVNUVWZl?= =?utf-8?B?bnFla1VLME9ITENIREVSaCsvdHBxNit0aDJHRkZkQkJOU2lXaTlxSGo5RGJh?= =?utf-8?B?QVk2ajRDbVBDeXFBY3JOMUt1TytNSTNQRzBsbzB6bVZaKzBOcnlLOFJnV2d5?= =?utf-8?B?Q2FDNFNvY2hhL3FKV05pZEtYc0FSVFlaSmdPWlNVVXhabm9sT21BL0c0WmhK?= =?utf-8?B?bWlJYldhMkNTUDRSN0F2c1R5VzZoY3oyRGhjOFNvV2YvNUd1N283bUx5eXI4?= =?utf-8?B?Ukd0YWJTWEFrdmV5VS9Vd0JMUFRQaEZBT01xSWJjRFE4dTQ1S01SeWl6R0Zy?= =?utf-8?B?TVcwSW9mL3lRUWVGSUVSV0xSTkkzVUM2VVVmUGZaRXlIaU5FRWdrTkEzTFVM?= =?utf-8?B?ZWY5WS95MStZNmZqamM5MU9QUCtZK3dJM0VJbnNsVTYveWsvZU16bW5Ea0NQ?= =?utf-8?B?R2IrSHVoRFJoQ3AveHpTS2IzTi8yK2JVVnk3aTdjVmw0cmYxd3hiWEZUdzA0?= =?utf-8?B?SHA5VjZzOXVtTzAvQTFOTmVQQWVKcEFQSlJXa0I1ZVJ5czBXZ28zVTE2blZh?= =?utf-8?B?cnA0V2JzcXZxSHFjeENCV0xXdE5tWFJFUi8vTnZ3b3FKSFBTaHV3NUNFbXNl?= =?utf-8?B?dmJ6U1RXSXRIeTdwVWl0MGVDZEN0d2ZqTDNsQThhUCtQUmJ3ZHFtMW11TVp3?= =?utf-8?Q?t+k2MCwmpqME20fixkamNh7le?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: UqIiG3TzjUHUGPRHedCq0d8uMNeW881d3UJVd/QpIh/QawnR2lZnohKnVEWF10mWxK71jNpGxnKfFIPkkWOf4hpHXDBw/2QbNOZQb692rUYq7gHWMxLlbEpreueDSEff07EBfL/Subt5YMhlTRBgWRJ9xWRqbhFuGGz/PjI1QMPEY8wpsGDqC5GfNoR/RugrDwHJnfn/dJ1Sa3l2WAU5nptIclbcaYEl5Zg89IAqp+cW2H879Kp4hFDAlvXbWx29AgtN2qvLMmiUWCMdRvM3qjOH0js47oBadsYZVZh4TtgDCjIz0wVNtWcTeIo+iF4F8GtHaBQTlT8TyUEcoLHHQN4goVbW5dzFg3UWsUqwCwqHgC47slOoFNcekGj9mYqpHfvDx2JwPji5cj4JAAecjNJ7bam+bwr4HdqgyTVMXojXjJuApt1NhIH0DA0ZWPJk8LCO427fjdPBuRHoZg7VKGIKF1VoiAwGM4ZAc0+Kle9CxInu56iqneuBTDcVZLrwfb0HYaayCJ5mvwXGs19dIQDkE4mai6IcTSJH4SQPNow5YU5HyfXMKZv2xRpEGZ+RpFrsl73KTVc/LcXaJ9qL83gpuTY1notMo++Oo/RlcwYEzKhoJNIj6285lzt1jFE+hzmTOfuWOZcUdwYO2IQ7LasZlz2HitPfIoH1SdYrTMH6FAuAmStGoj2UNVmrDXIPxeZeiQFBWSVJIr/5AMUkEmepmrhkktusC0zTPFzX7mNbD+CyvbmYMyG7lKrQnBysGFKVQIkJN+TkEVZaMFN1LDaeb8CMGQXNYD0NTSLLpTBoVODqD78CxCRvNO0sZJeou5hWLDduqR+ezLGEohQOnc/irvYz2Om5B2sNJGnwshLRbAB2ZWsIBswbdV93QO/uZNIFxHUtWPaGuKdqhBZPFg== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83e2fd7c-6d33-48cf-9c88-08dac70d21d5 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 13:27:24.5151 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xw6I5U9c9chn6y56hNhCOl6NOkSrYsn1w05g7fdt7HlC2FBk95RRm9erO1wB/N9lrpqDlE+tGLc2hhAq9TZp4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6713 Hello, Just two patches remaining, and the last one is already Acked. First patch deals with moving the switching of SSBD from guest vm{entry,exit} to vCPU context switch, and lets Xen run with the guest SSBD selection under some circumstances by default. Andrew has expressed reservations to me privately with patch 2/2, but I'm still sending it so that comments can be made publicly (or the patch applied). Thanks, Roger. Roger Pau Monne (2): amd/virt_ssbd: set SSBD at vCPU context switch amd: remove VIRT_SC_MSR_HVM synthetic feature docs/misc/xen-command-line.pandoc | 10 +++-- xen/arch/x86/cpu/amd.c | 56 ++++++++++++++------------ xen/arch/x86/cpuid.c | 9 +++-- xen/arch/x86/hvm/svm/entry.S | 6 --- xen/arch/x86/hvm/svm/svm.c | 45 ++++++++------------- xen/arch/x86/include/asm/amd.h | 1 + xen/arch/x86/include/asm/cpufeatures.h | 2 +- xen/arch/x86/include/asm/msr.h | 3 +- xen/arch/x86/msr.c | 9 +++++ xen/arch/x86/spec_ctrl.c | 8 ++-- 10 files changed, 75 insertions(+), 74 deletions(-) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 13:55:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 13:55:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443964.698720 (Exim 4.92) (envelope-from ) id 1ouwOy-0004hp-UG; Tue, 15 Nov 2022 13:55:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443964.698720; Tue, 15 Nov 2022 13:55:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouwOy-0004hi-Qr; Tue, 15 Nov 2022 13:55:00 +0000 Received: by outflank-mailman (input) for mailman id 443964; Tue, 15 Nov 2022 13:54:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouwOx-0004hc-5O for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 13:54:59 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2062b.outbound.protection.outlook.com [2a01:111:f400:fe13::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1682ac7d-64ed-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 14:54:56 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8892.eurprd04.prod.outlook.com (2603:10a6:20b:40b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Tue, 15 Nov 2022 13:54:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Tue, 15 Nov 2022 13:54:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1682ac7d-64ed-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Za0UdlBAnpBQH3LEmDEeRo+OpbwAdp+bA6vRszx3U+Kp6oBeDGWfF2N4/ER7xBqREi++9sd4O1STFrGhe/3lu3inuTlqHeITutgNg+BaUap74edmEu3aY+qFVYIsSIUFRlE1S9FzPRbsreBFgooTzWtyOEt0TnguZvB7ue7M0wFoNXrdbPxarfhjnD+9sNLzVxaHl8xixsDXX213al+rzP5Z7fLlQhyxEIY+BrdBuWYieMFwNCAZkXHIgZPa+uoS0JPqUHJ3poSTXUDrAFyjaqWC3dD46MblGdbBicAl90FRU68LGT3sU/R16MJc9Zm0AiKKoyeZFpkflh3vlfPWGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WPeNs0adUYM5IX3QijtNNjDpvZ4xtF52CHiCnGvQ0+s=; b=Ql1s68bhLo5V3u+PAw9+4oYeRmt+pmrhuq4qXdLUaneWO8nd7PLlBr6zFwnJWjJV3HV+doG6O16M1leTJcqMIXx0iD6vY7ckzFUwhEuQIMTC4Z7hztegTfs13RnO8MUowK2Y/Pocm4LfEYIszGtjnIvTENODk19V7A8NA6nRanmkLDJuzRuxQQ/dS4HJDHk716RGAfeHPy2jgoH9aeMSL6dfyGefHsTEHPE1KLrjKH8KsmQv1fCdKgyxKPEa/pY7HicVxDCyVybOTCh7AFXEVSXfQeXqtAfFrPk5XJsD5u5ajOW3jHP/B5qcXquJHujOsN7I7JANXDF92tENU9fr2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WPeNs0adUYM5IX3QijtNNjDpvZ4xtF52CHiCnGvQ0+s=; b=qxyqZ7n4SEaFzPRGtnv/KAd4SN3y3vZyQsp8aRV7rKfYs8d6RvXAy3oP020O9l6y4SkMRPX/I0acZIl0aWJnihmMN+upEFaoXd56JZT3r20WsLyEaSShkr/YNKThEgyd/FdwuREMnGFViWXuX7NHrSs26uD74qWqBprxheyNMANoPb35ici/0DMps1NX4x0w8CNtVZjGSCBRME5qmySVLo4OdUh0QVTJgtMv1scTRJh6f9xmcV/B4zVXyRgfhp0VCohiQOPh0DPdac6q121XsCmd/BVWdkB9MMp3wJJUv92biVjfFHMrYSiTDq2ThUqweaV4roU2wlG+onG4i2stfQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9f0cbeb9-a3c7-930a-64b8-db5d75abe9da@suse.com> Date: Tue, 15 Nov 2022 14:54:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/2] x86/msi: passthrough all MSI-X vector ctrl writes to device model Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20221114192100.1539267-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8892:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c10bb10-5eec-4d3a-4761-08dac710f95c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CDl1z6v62tonGu6rrb7vvUZF+HwawRQW7KT9xGlO0BI9cp5zIKD64Ol25/XhePgTbwpgxB3/Uu9agAwtFuZkFweDDzad8G4O0t2nH6uxldKx0gnYb0gPglkFuY7OZHFuBTNF2QAz28BioELjsD3VE52hpefv+Y+KQkpILHD6g4kKbowUbFVOacigeyQ1WGczBPVyNJ7sCj2RYVsWH4NX/WX21mplgKZMjVThyBONmcYJzQJ5LErZv3IWu0r+UtR8hh3ri7LQS3L19HQppVvu26RdUIAkxgQS/KvydLvM/VAWzEbRqm6U4nCtkI2B0n3v8/n11GeAxCfFGNTgB5CslpQ3dDnGiQO2OR6AE2uLAhNvgeM5/vtMVlSgGaUJTeFjt8hp2ria0mXV1EZ9fNGY7Ncq0ITK9oy5y/6RSMmSLlHV1nVrlCUmOpjoYGxah/UWmz/HSg782Ll3fz2O/r9cMrC58hmzrRQsFHQZcpKBFpLIHRTE260abuW3GgZQ2wE/yx76gfQqvRMxp3aPpwIAHpyFSG+agBmoousHk18ZlOxhq3PKwIoafb5INIlIk+px4RkG/vMJnxdQIrQNOywDyUrON40EhSkvcArha+K1G0ttrCyhm5OHlqSnQJhka/wHUZwJrECtzubhdUJtGsPwl0YdO+oZAdGS2NEVuqbqtMFqkr4urEe/ab238RUqb9JaoiPMcdejd89ChZCnl7f11Ip831SjhUagl8FUXIq202tct0aUbw6XDg/uBZUWVeb2QGvfqfdqYmhzs5MZBsUCifLxdw6DH/E42KIvubXhP8U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(366004)(136003)(346002)(376002)(451199015)(31686004)(6506007)(53546011)(6666004)(26005)(6512007)(478600001)(36756003)(186003)(38100700002)(2906002)(54906003)(41300700001)(6486002)(31696002)(6916009)(86362001)(316002)(4326008)(8676002)(5660300002)(66556008)(66476007)(66946007)(2616005)(83380400001)(8936002)(66574015)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHRuVTd0TWkzK096d3hlbTNuZzQyd296cXpsNUVVWVR1RkNnU1E2bngzUGhv?= =?utf-8?B?VHV0Y1pxMWtWZzZ5V3h0WkZvZVhJZjNvVFhzZzFBYWgvemhpZk4wSTZSUkx2?= =?utf-8?B?aER2bGdTbmZTdjJINWE1TTlZM1RKQTNQc3YyaHhCU052a1dTdVNLUUNXN2lJ?= =?utf-8?B?UEdpNENVaTZVTDVXUnVIbGVqU3loaE9HVVVYcW1BZzdTWFV1aW1QTGoyOFJj?= =?utf-8?B?ckZBVHhldVNqK1lHMC9HL3VBY0JtSktTQjRydWxIaFdDRks2L29qci9PdDFh?= =?utf-8?B?LzNKUkRadExhNkxUdzJtVTlVM00ycEVhZmNWN3RZamR5Z0UrN05HUzltaHhY?= =?utf-8?B?Tkl2UjUrMGFDZmNiSlYvZHo5MDRqc0JGYzZHVStwRDJWdktXY2l4empYOWg1?= =?utf-8?B?bGpRNUZnaGZkQ2Zkd0RpeE5LMTZZaFl1dDBqKys3VGlBQnNpckFEWnVhWmNw?= =?utf-8?B?WWpyWnd1ZisreUx4QU9PRGg5VCtBdUovUjZpeVN6MzdUVWdRdjZHV0N3a1J5?= =?utf-8?B?V1dVak9TQzJQVk9wYkdnekpOZ1J4M1Z6QUVacW02UkF4aE1jdGc1Qk8wUmxo?= =?utf-8?B?L2ZQYnVWcTNNaVhpNS9jRTh4WEgwUVZRbjRPeVpreUIydk9lMUowMHZzYTRY?= =?utf-8?B?NWx5RkNHQTlsQkpLNllFZklQeTBoUFNMQldpSGNZdVI0SWMvZW5mYm1WL29F?= =?utf-8?B?SEF5UGtOVml2a3plU0VUWk43dTMrdlpoZkZsUzVxRE9LNHhQRVBWeEVzZ09K?= =?utf-8?B?YXFudmpmaG9hcXRHNW1VVnBlcTZYWlVGbXRudG10OHJkakl6aGd4S2pIMWFY?= =?utf-8?B?a08vTkNXZm5SRUwyc1lrelJDRTQrMTd4V1duMmt0S2QyZXYvT3MvdnMxT09O?= =?utf-8?B?TmxMNndyeTljaGFrQjdINkkyOGR6YUdockJWMld4akpGbkpaWFc5ZGFDbnBr?= =?utf-8?B?QVI0UWE5TzhrMmc3aVZZanovTUN6dlpNbXZDWWplV2RJZFRyeWdOK0FBdldJ?= =?utf-8?B?bnNPb3Q0alVRbFVjeWFueFBLR0hKTzNCcldYa0V1cVJDdThWZEVjRTE4aFVs?= =?utf-8?B?YVg1YnBuL1EvQnBoaFpiNDRzeW1lWDVjTzVGeFhKTU1FMk9Zc0RvZU5jSFNp?= =?utf-8?B?Qi9vK20zRnY4Y0RMRTVQS3F2Rnh5NFlxdFYzeVBEY01BS1E5MHl1bk1KVTVO?= =?utf-8?B?OEw0ZE9OZCtyRjU3STc1V1I2eXBVd0NEVUJZdWNtRmhRa2FnOHplNjdDWEdZ?= =?utf-8?B?MmFrei93MG5FNU9sQ2U5NVFUeVgvYWNqYVFmOWtYY0ZzR2lPc1NVTUxwazMv?= =?utf-8?B?RDdvRUF3bk5KYTlNMVpRTlZWN0FXUUtETWZ3UUxHZE9YUXNzNHhXVTAzTkZY?= =?utf-8?B?amxOSFpZS1BkTmlkUDRzUEk3L1JzUFRYWGx1ZUZYTUtYWkRDVWlUWWx6SXI2?= =?utf-8?B?VEFYOGJzYnBBOEF6SnI2d1BrUDNocmZqclZ6S1hNUkszanNqM29kTVNCVjdM?= =?utf-8?B?OVVVTjhkL0JzUVhqblVoVksxRGxzV0VUVUhMMVVhVFN5WmNWWVlNSGg2MHpJ?= =?utf-8?B?aFlWVTFVTHk1T2xjTThTRXBaZ2JYTytNQ2VWN0M0SDNpdGJ5RVN3L3d4eURi?= =?utf-8?B?bFlDL3M5YTBvL0dOekJ6RmNOUzdKejlTSlg4RDJWSHB5WVZPUnBRY1gvYTVY?= =?utf-8?B?eFo1WnBYL3hvUTZRbE5PZ1RxT2diTXBmMXcxVkZyK2p3ejVZVDExVGxNZ05Q?= =?utf-8?B?OWpyVmoyRUhqVmI1S2plUjV2WHdQU0lDT0plak5PeDhVeUcrd1hGaVp6WXVk?= =?utf-8?B?VVNCbnBjRm1YVmpacXdPenlOazNFOUxqUmZSUDluMW1wR2RZSWdIZUYzS1h2?= =?utf-8?B?NWVnc2wrU3c4K1J6K21SeW1sb2thZ0dIVUFEV0ZYM044bVFZbTVFTGovMEhC?= =?utf-8?B?eGRoNWxYSHRuTTh5RTNOTENSZ1RsVytFYjFxWVRneGtWbnNyQUhXNHZoQnZJ?= =?utf-8?B?MEM3ajdRYTRuQ1RQb1Rwcm5NVGllOUpZa01xVjZ3ME5KK0FmRHMzNUdvdXBj?= =?utf-8?B?ZVc2N0pkbVlFMm1pMUFqRFJaU1pnMmpDVExUKzdWa2NVNHczT3RKaUlrWkJN?= =?utf-8?Q?4R+aFVO7RCCvHilVhNEYab7sE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c10bb10-5eec-4d3a-4761-08dac710f95c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 13:54:54.4887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2231GIBIc9iRTtrenHi97XpetulnmpsOygCV7+TA8k4Ew3Xk9cKsyZp0RzbT5NFMLDMAboAAYVywsktTy/PRDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8892 On 15.11.2022 12:37, Marek Marczykowski-Górecki wrote: > On Tue, Nov 15, 2022 at 10:36:32AM +0100, Jan Beulich wrote: >> On 14.11.2022 20:20, Marek Marczykowski-Górecki wrote: >>> Give all necessary information to QEMU by passing all ctrl writes, >>> including masking a vector. >> >> Can we perhaps still avoid sending dword writes which don't change >> the mask bit? > > Is it worth it? I don't think such writes are common (which I confirm > observing debug log - every single write to maskbit Linux did was > changing the value). The old value isn't readily available here. For one a 2nd aspect would be Windows behavior. As you've seen in the hypervisor code somebody back at the time even thought accelerating reads was useful. I'm going from that rather than knowing for sure that such an optimization would help anywhere. >>> --- a/xen/arch/x86/hvm/vmsi.c >>> +++ b/xen/arch/x86/hvm/vmsi.c >>> @@ -271,7 +271,8 @@ out: >>> } >>> >>> static int msixtbl_write(struct vcpu *v, unsigned long address, >>> - unsigned int len, unsigned long val) >>> + unsigned int len, unsigned long val, >>> + bool completion) >>> { >> >> I'd like to propose an alternative approach without an extra parameter: >> Have msix_write_completion() pass 0 for "len" and move the initial >> check >> >> if ( (len != 4 && len != 8) || (address & (len - 1)) ) >> return r; >> >> into _msixtbl_write(). Then ... >> >>> @@ -343,7 +344,7 @@ static int msixtbl_write(struct vcpu *v, unsigned long address, >>> >>> unlock: >>> spin_unlock_irqrestore(&desc->lock, flags); >>> - if ( len == 4 ) >>> + if ( len == 4 && completion ) >>> r = X86EMUL_OKAY; >> >> ... this could simply be "if ( !len )", seeing that even with your >> approach it could simply be "if ( completion )". > > I find such usage of magic len=0 confusing. It would change the meaning > of "len" from "write length" to "write length, unless it's 0 - then > write length is 4 and it's called from msix_write_completion. > Is there any real value from avoiding extra parameter? Perhaps a matter of taste, but to me redundant parameters are odd at times as well - often I end up wondering in such cases why an extra parameter was introduced when things could easily be done with what was there. In the specific case here there's also the further aspect of you moving the function across the boundary of all arguments fitting in registers available for parameter passing (which of course only matters if the compiler decides to not inline the function at all call sites). Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 15 14:05:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 14:05:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.443970.698730 (Exim 4.92) (envelope-from ) id 1ouwZ7-0006T7-TQ; Tue, 15 Nov 2022 14:05:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 443970.698730; Tue, 15 Nov 2022 14:05:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouwZ7-0006T0-QG; Tue, 15 Nov 2022 14:05:29 +0000 Received: by outflank-mailman (input) for mailman id 443970; Tue, 15 Nov 2022 14:05:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouwZ6-0006St-H6 for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 14:05:28 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on061c.outbound.protection.outlook.com [2a01:111:f400:fe1f::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8e1ef257-64ee-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 15:05:27 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8898.eurprd04.prod.outlook.com (2603:10a6:20b:42d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.15; Tue, 15 Nov 2022 14:05:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Tue, 15 Nov 2022 14:05:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e1ef257-64ee-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JLGARLFu0OCksTqjfABCFLeyK7Gvl8w8BpZ7pxPhQbqFoIzmTCrOB7cGB7+773+ZJJvyZJefmH3g1hNnAwl2+3qdlLmr0g5KNd9vJ+vZgGvlitAg4XCZYkCMSEipYoKM4e8Czt6/KkTBNm/k35pCcrg5iEJ0Ir8bgqBMUdiztNzVcM+ob+GdrvX2xypRrrLWufwWXB6HFsYC0P2URwgq0X11mca13Vw3NHnHqWui6bdv4ZTCVsoKacXEHmgH1iS7igont8sSzNT8/dqkAMwms3MA54cNl8MGWZBeYjZJV34HplEhnLRVduPFpcBu4flrAkJip8RrR63VmJn0cgDoVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sDUWyWScZMXji1y9yEi0ju0eOiWvng1aTwJR6Pj7BFM=; b=JXNdaEAXSYJ0BoXckqbdApDtEVqscNItlzails6aTsocaNg5vcaGzn3EqmRTH+D3BZudlKCz8V10G5l1HmV7//jb1n3ruK10tCj5mr0ufPj8xpHuaJGLMXfxCDRG94vXCqHx/jr3MXLAyLwyFL7i7Aj7KyK6O+4uxy3VQ4gE7DfPQF2B27TaTWmrjgoN8EBUeC94OuJOWAjlPmxY5NtssNr9qo5h57fFVtKmVa4XWkwXO2loF4N9NbAPZNMNIqIpPiLR5sOnn6IVHmHMnUTzL8ya47OzCgsCS+pztThw1ioNjs3B1oM6eGlsNmJnOrLWBRBiwX2AZSExWM6KQxE6zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sDUWyWScZMXji1y9yEi0ju0eOiWvng1aTwJR6Pj7BFM=; b=NWxv5ALeC8uf8wT5YzTR8IOmzAIaLCgB0I7Nz2GaJn2kVd6J2W4sSS0+GD12DDM4WMZ50MbgImWABCNWSS6teCV66huAl/wpfyCWzQsM7HLp4bDKwsISlm1tyI8J2bF8tzvYwaAnHy2rJ5k+u1U7wbm9hrlxO4DiLFCFHcWk3ZV6cyIw3lfAy47HaPj5jm0yrPp1owrsz8vjbJzWOJZunqJOHjCAPVpAtgnEdfpnsky7U0lyjz232NK/j/+X9FlSKgS5quQPMdlti79Z9wyMXGCeqN0FIHgGhxRFdxeEsLJ/FrQKseMnq6bVfpNyah9JkBr2N1dSeuvoBy/qxMpDuw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <61bdb870-0169-26eb-3d2a-a3b167148b3c@suse.com> Date: Tue, 15 Nov 2022 15:05:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" , qemu-devel@nongnu.org References: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> <20221114192011.1539233-2-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0193.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8898:EE_ X-MS-Office365-Filtering-Correlation-Id: fdd35154-d48f-49d1-a124-08dac712708e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CB5tgRbkTMV8KwsnP5KZXlsy2JY5SpQocnYwpC4VlNeDu3L5N4IymIy6OaX0YKfH4k4Hh23F3s9xc6BwdRBZ5ZdYImmIfHSNlcOKAuDIEczgEkuH/D0UhpxsBbqxBGbuqmGsd27bwys8sIgaWLEqrR3FXRvstuhv5X+d3LOy6wf1jT6qW0ldTm8SMBlqgt1xKKYXSfz31qnoijhzs+gwNCEoGs48AgfvYdVAVxcv4nYjMJYzrPURjQMDe2ZDiea1bUhFR/n0rQ3zGZitx97+FkdgxQzXdaXxT+FyaYV/0OnKJvF91Trn7KzFFWQQ+IRD8nUZksjNaQexlXbxfn+yRPkWLduFzInt1MeZ3C/E5GHJ+agAuvMiWHYZDLuf48rNW/onN0c4dg7TNbRiCElPXegDogZc+sB57Bpa6fY7PRKRZA3w2JLLKmSVXXB+CrJCLKgnEIloR1wWNrUk9RkD2zYA+q4MqWgBai1Ajms8RJiz0ket+X/EDc5HowuFsh3g41x6Yr+/xfxG4o+IkJZc45qPFWJE9L8TA9JzAg+RqZvg5O4Q661J7clkrL3MACdbY18ONycGqRt/jVYwV/tJXGy9XPuT0lf5bQkiu4zO9c9HWFvxdUB3Bjt8kxfhGlDHvPJ6fDDH7YyHwahfeMYi4pDLzo8hbNxk1PiXUztG7onI0X+mh1Yitu/8amSagE+f7GzXRgOxbJZvfb41vKabVU89k+c/Nq17N4NdXzB/geo4KS3VXkgZfmhzqpJecuqPOld5Ll+PQymV+pAF+UhdrrbP2Py5LcHgNzqW400LdEY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(346002)(39860400002)(366004)(396003)(451199015)(478600001)(2906002)(53546011)(31686004)(6506007)(6486002)(6512007)(26005)(2616005)(41300700001)(186003)(8676002)(4326008)(36756003)(66574015)(66476007)(66946007)(66556008)(5660300002)(316002)(54906003)(6916009)(8936002)(86362001)(31696002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emRJLy9LcVM4Z0x4RUYyZWE4UjdEYTdveUEyYXpIYnV0VXZqckpIazhJbXh1?= =?utf-8?B?UWJhR0l3dVlOd1VSdnpwUkoxeTA0OGNDSTlxMk11ZHNobGhrRFE3ZlRFK2xH?= =?utf-8?B?NGNaMW1BNVcvNTN1NXlaaExROGlJOWxrNWVDd0Q4M281ZkQ4TkpwYkdKZzBw?= =?utf-8?B?OVE2Zi9hY1lHTlVZWFdmakVnSnVzcXFIRmJOS3J1UUUycTR6RCsySGIwZDFs?= =?utf-8?B?R2ZXdW5TTGRHS2JIeDVlZUtVVkVXeW0zd0dDQUJkS0JlM0RnNU5WWnpkbjRT?= =?utf-8?B?UTQyeGVMYWZ6ekhnaENwS2w4RHkvenpXNXRqNWRROThNSG0xYnpSdXNKV3U4?= =?utf-8?B?YWg1ZkUrNERLMGZSMVZBejVZQmdsNVMvNkpoZFJGN2hubkNmWUlhblI1eDI0?= =?utf-8?B?MnRSVzJFRkkvWmlCcWh2RDJTMll0bDRtVURJeThnTWlYL2ZvWXFML3cwc09a?= =?utf-8?B?QlkyRGlmQ2lrNmdWaUZwR2xXMXJVMEhzbHhVQVVlOERKOTU5bWVTYUlCRUo1?= =?utf-8?B?QVkrMDhzcDBKdHV2VjdrMjF2bFpqQnRmdFlvbEZVOExqZEpQTHdpYzdCQnJv?= =?utf-8?B?QmZadjk5WWZZWUVwMUU3T2F1dFM1Y2RRaWRVM1Z1VDc5WFpqVjhSUWxSRHU1?= =?utf-8?B?TXhpdXFYZzJ5a2pCQTNVTmRkK0tTNENzZTRpalVEeElmVHpuM2lQY3F0NXQ4?= =?utf-8?B?OGZCOEhkNXBsSnBoOURlZWhBcGxodFJXTTZ6QTd3SEl3bWo1MGFzZ1c4anpG?= =?utf-8?B?VlBEZTBxdlJHK2JsektzL2FYcVpsdW9xNllXeXFyVUpnSXZaSFpPUUp1YjZi?= =?utf-8?B?d2FKNjg3N0ttQ09lSFJDaEZDR21YclozMTcvdG5aZWNHNjZXSnpNUUlaZ2RH?= =?utf-8?B?SkJyd09sWWRVbk9HMkFBa1dUdFZpdkZBVFZ5cjhYRUpXZEVBaHNjUUJFNVBs?= =?utf-8?B?U1pMR1RyUGI0RGdMVG96TWZ4MzBoN0kwUE9tRHNONTAxOHNzYnFyTkJMZkxa?= =?utf-8?B?bEh3Ykc3R28xY3Y2ckF5RDN1bTgvZVl1U0c1QU1vcnIzZ2ZTV1dvVkVwUU0z?= =?utf-8?B?L0ptejVkRW03eVd3MXFoT3lJY2xiK3ZNVjhkSDJEVTRVOUUwU3dqTTEvN2R2?= =?utf-8?B?L3p3UTZlN1NoaXY3cTRJdHd0RndCblZtalV1N1hLQXpCS21DRE9MSUtiQWI0?= =?utf-8?B?eGVXcHZUNEpWYVBRbW1Qa2dGYTE2R05PQXZsRVhJUmxCZHNKeitlNnBvOTQx?= =?utf-8?B?cUtHTGFVcGtYeWowOUhGRjdwUXNOajB3Z1VocThyZDZ4emk1b2hBa2daVUdl?= =?utf-8?B?VTdyZ1VQenJnaWt0SzNnMTYwbm5pM1ptanVzaXM2QWdNQjB6Uk51NCszcGZL?= =?utf-8?B?UFBLZ3d1bzJXVUxxU3I4cnpwWnB1QWlJVmd4bmhnK3hLUkFTQlVtcXJjd2FE?= =?utf-8?B?SHFlQXlUNWxDaVVERy9FVmIrSCtEV1lDUEJFdEs3ZEoxZDArZDRmK3VvYWFw?= =?utf-8?B?a3BxQ0poTDZvZVV2eDFGNkxtSmtzejNuNE91M2dybzBISkt5ejVWUVpYYzRo?= =?utf-8?B?RGFKUUJtT3NKOHBiMTZzNDkzczFScWlnS0tEa09mNWFLaVN5K2RHWE5zWVVY?= =?utf-8?B?cFU1MXBlenpGWkRrUG5rVEtLbFBic2xjSVlpcStweEZkaVJTMUR6MTJqYzNK?= =?utf-8?B?R213eVNDUzEwdGVTa2xQdXMxODBzTDQzajZ1NHA1WWRsRnU3V1VUK0RDT2wv?= =?utf-8?B?eWgrYTBRUUd0UW50eVNybkVjT1hiTWQvNWpYRDg3eDJQN0NHSktRMHdicmtS?= =?utf-8?B?N01VbDl6KzdweXA1OWpCeG1zcHFKdENkTTQ3VkVmZ0xKdFV0Mkpib2ZSNkhz?= =?utf-8?B?MmQxVldlUVJmQ01ra3VibS91RkxKb250RzYrellrUTFOMlZMOGhqdlhOMk1h?= =?utf-8?B?RVpEVGhWclBPRzVDOFQ1aStrMm5kTk54OEN4MTBqMlpuSllCVG5Wd2tvd3Uw?= =?utf-8?B?NU5hdDZGbXdUN3Y0Qmk5RUFaellpTkpKYTRrWXZFNDVMcWQrZ0xQK3ZOUVE5?= =?utf-8?B?L0l5NC90Snd4RXFVYVByY2JtTDFvMWRIdW9sNTZJVGhvQ2orUHhST3oyUXB6?= =?utf-8?Q?9ce2v0KTerRdtfSNth+q220xm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdd35154-d48f-49d1-a124-08dac712708e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 14:05:23.9486 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hSKCUfyzE9OuGSG8LupydM0l/hATgP8SFqPba6154Refc5F6MH4uvl1VYw5i/U93CX2DNKyiuhHThSQqPNBLMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8898 On 15.11.2022 12:38, Marek Marczykowski-Górecki wrote: > On Tue, Nov 15, 2022 at 09:14:07AM +0100, Jan Beulich wrote: >> On 14.11.2022 20:20, Marek Marczykowski-Górecki wrote: >>> The /dev/mem is used for two purposes: >>> - reading PCI_MSIX_ENTRY_CTRL_MASKBIT >>> - reading Pending Bit Array (PBA) >>> >>> The first one was originally done because when Xen did not send all >>> vector ctrl writes to the device model, so QEMU might have outdated old >>> register value. This has been changed in Xen, so QEMU can now use its >>> cached value of the register instead. >>> >>> The Pending Bit Array (PBA) handling is for the case where it lives on >>> the same page as the MSI-X table itself. Xen has been extended to handle >>> this case too (as well as other registers that may live on those pages), >>> so QEMU handling is not necessary anymore. >> >> Don't you need to check for new enough Xen for both aspects? > > Yes, see my response to Andrew in the thread. I'm open for suggestions > what to check specifically (Xen version directly?). I guess we should first see what changes we (you) end up doing in Xen itself, and then decide whether to surface the new functionality in some kind of feature indicator. Generally I'd prefer to avoid version checks, because they don't fit very well with backports nor the (rare) need to revert something. But sometimes a feature can be probed easily without requiring an explicit feature indicator. Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 15 15:56:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 15:56:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444001.698747 (Exim 4.92) (envelope-from ) id 1ouyHt-0002Tm-Pa; Tue, 15 Nov 2022 15:55:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444001.698747; Tue, 15 Nov 2022 15:55:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouyHt-0002Tf-Ln; Tue, 15 Nov 2022 15:55:49 +0000 Received: by outflank-mailman (input) for mailman id 444001; Tue, 15 Nov 2022 15:55:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouyHt-0002TZ-2u for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 15:55:49 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f6f90f10-64fd-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 16:55:46 +0100 (CET) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-379-IoijgZNPNoCGDi6JSoRS-w-1; Tue, 15 Nov 2022 10:55:43 -0500 Received: by mail-ed1-f69.google.com with SMTP id w4-20020a05640234c400b004631f8923baso10264455edc.5 for ; Tue, 15 Nov 2022 07:55:43 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id b25-20020a17090630d900b0078d38cda2b1sm5602709ejb.202.2022.11.15.07.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 07:55:41 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6f90f10-64fd-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668527744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WPjmVSvbKB40CCR5+G61PkEf4Ba+oFIdDkT9Qj5RB98=; b=PIaAHZQ1AG3n9/vVQwLPA5nrdcAdsbwBaysva+ZfswmR/y4hQjZoC6UPcn8vaif2yTNJqj 6xGFX/QIzOih/oIBrmfLLeukbRQG/w6mMJ97+NoQ56d/WPolyNv4a+ErR1xTJmrihP+oSG L4fwn+P9dTwkvMTdcsss9GSDKem0PsA= X-MC-Unique: IoijgZNPNoCGDi6JSoRS-w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WPjmVSvbKB40CCR5+G61PkEf4Ba+oFIdDkT9Qj5RB98=; b=exOCRDT7wRz7cYyR0BGl1+8SGuKRXk+0FBSV10OKKLBqfGUK+WpCA0SRch+Pxy5gkV 7wY+XzmZRE+v+IqBNIwfdiLsAVuazP3eM3/b426PZgiwyyh3nhYJF2D+6IXIDlQdVaib FMjhs7YcXQIugHhDZcUKweqQ9yO1ZEvXozpYV30dfA0O6Y+AIaq6PgEW+CIH4fG25qHR +LqWcrmyv+lA8qvE4as6dfPb/AAgjxsAwrX3Xfs1mBQf7oAzKLsfy6C5ck4RwvzIoyCc 23I2cVVuAa+ZLgxoCc4C/2NAoEu71XhgfoCN1VuKQ6mrdgO+7G+wBv54N7oXzZeheQXE o3GQ== X-Gm-Message-State: ANoB5pnRCryMjs+OPPKCZjdiAFO54wUHDvoFZAqB53oR0qJ6+72n34uz bihRiZCVMQohDsNe0cEGg7OuCPy4QTlFORx7MP3DUG0F8SB38YjCtdrP0l87xG/hdKS8WlDU2zV 19wQ+fCvycFo/JaG3636PI6l8zAs= X-Received: by 2002:a50:fe13:0:b0:461:565e:8779 with SMTP id f19-20020a50fe13000000b00461565e8779mr15869000edt.387.1668527742097; Tue, 15 Nov 2022 07:55:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf62LnypI8+D6I1dwsExAn0tS+t62csKAA7KiPjW0+QdBxIexBU16E3VPnjUKKjLqOCYwTe88w== X-Received: by 2002:a50:fe13:0:b0:461:565e:8779 with SMTP id f19-20020a50fe13000000b00461565e8779mr15868982edt.387.1668527741895; Tue, 15 Nov 2022 07:55:41 -0800 (PST) Message-ID: <8f28a8dd-5a0c-c233-217c-0e610b830406@redhat.com> Date: Tue, 15 Nov 2022 16:55:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3] platform/x86: don't unconditionally attach Intel PMC when virtualized To: Roger Pau Monne , linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, jgross@suse.com, "David E . Box" , Rajneesh Bhardwaj , David E Box , Mark Gross , Andy Shevchenko , Srinivas Pandruvada , platform-driver-x86@vger.kernel.org References: <20221110163145.80374-1-roger.pau@citrix.com> From: Hans de Goede In-Reply-To: <20221110163145.80374-1-roger.pau@citrix.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, nl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, On 11/10/22 17:31, Roger Pau Monne wrote: > The current logic in the Intel PMC driver will forcefully attach it > when detecting any CPU on the intel_pmc_core_platform_ids array, > even if the matching ACPI device is not present. > > There's no checking in pmc_core_probe() to assert that the PMC device > is present, and hence on virtualized environments the PMC device > probes successfully, even if the underlying registers are not present. > Previous to 21ae43570940 the driver would check for the presence of a > specific PCI device, and that prevented the driver from attaching when > running virtualized. > > Fix by only forcefully attaching the PMC device when not running > virtualized. Note that virtualized platforms can still get the device > to load if the appropriate ACPI device is present on the tables > provided to the VM. > > Make an exception for the Xen initial domain, which does have full > hardware access, and hence can attach to the PMC if present. > > Fixes: 21ae43570940 ('platform/x86: intel_pmc_core: Substitute PCI with CPUID enumeration') > Signed-off-by: Roger Pau Monné > Acked-by: David E. Box Thank you for your patch, I've applied this patch to my fixes branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes Note it will show up in my fixes branch once I've pushed my local branch there, which might take a while. I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > --- > Changes since v2: > - Don't split condition line. > > Changes since v1: > - Use cpu_feature_enabled() instead of boot_cpu_has(). > --- > drivers/platform/x86/intel/pmc/pltdrv.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/platform/x86/intel/pmc/pltdrv.c b/drivers/platform/x86/intel/pmc/pltdrv.c > index 15ca8afdd973..ddfba38c2104 100644 > --- a/drivers/platform/x86/intel/pmc/pltdrv.c > +++ b/drivers/platform/x86/intel/pmc/pltdrv.c > @@ -18,6 +18,8 @@ > #include > #include > > +#include > + > static void intel_pmc_core_release(struct device *dev) > { > kfree(dev); > @@ -53,6 +55,13 @@ static int __init pmc_core_platform_init(void) > if (acpi_dev_present("INT33A1", NULL, -1)) > return -ENODEV; > > + /* > + * Skip forcefully attaching the device for VMs. Make an exception for > + * Xen dom0, which does have full hardware access. > + */ > + if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR) && !xen_initial_domain()) > + return -ENODEV; > + > if (!x86_match_cpu(intel_pmc_core_platform_ids)) > return -ENODEV; > From xen-devel-bounces@lists.xenproject.org Tue Nov 15 16:07:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 16:07:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444007.698758 (Exim 4.92) (envelope-from ) id 1ouyTb-0004kS-0A; Tue, 15 Nov 2022 16:07:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444007.698758; Tue, 15 Nov 2022 16:07:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouyTa-0004kL-SN; Tue, 15 Nov 2022 16:07:54 +0000 Received: by outflank-mailman (input) for mailman id 444007; Tue, 15 Nov 2022 16:07:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouyTa-0004kF-5l for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 16:07:54 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8bcdd04-64ff-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 17:07:53 +0100 (CET) Received: by mail-wr1-x42f.google.com with SMTP id y16so25076512wrt.12 for ; Tue, 15 Nov 2022 08:07:53 -0800 (PST) Received: from smtpclient.apple ([84.64.97.234]) by smtp.gmail.com with ESMTPSA id j7-20020a5d4527000000b00236545edc91sm12904953wra.76.2022.11.15.08.07.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Nov 2022 08:07:51 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8bcdd04-64ff-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=evqU5NxwEOKZXOOFVQccO+bZ5pmK9VYGjD7XGWQB68Y=; b=rIDv+FE6ErLNWmJfRUvwgpkqsnCMeAfi6QnN2gTrLw0ZY80H90CzVcW8AFllt9aKxJ gM3Mq2XsIlv/XrLFfXuOcNVnXrcPl7cNn26XCtz42DvbBBFLb4oPjOADmWTitxFaIwyT o2fy9gEAExmfeAJbrc4t9NuFbxnXf8gaLU6IANn0ViTch4BMTtxoN9H9nkpFYjyz1Kqu IwaGbP4E2ys3SGiJHnaZgmpUrZrm1ji3KluoEwVSUK2lsMWIkWhjjIuRhroJi96t0d3m ID/Hyx2R1yYcsRRprUG2YXCc/Qpor5x5miCt8CDBnuV9eH5NeuFHIgAnCZO5ZdhYaGDm 40/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=evqU5NxwEOKZXOOFVQccO+bZ5pmK9VYGjD7XGWQB68Y=; b=NRpAD9XkGVjgsqSVIlM2vDLIAFFsUvkKWM3+X1FZB1WE9ZPbqpa29bftzrl4P2QeKE Pg/UxbjmBD+QbaAghALjsBABIwaDngQJzInezmEH//xWbDwk4mDediSRa5zgJhEs+Jhb 6ithaUER+UTq30y6PN4PtQe+D1GWz0JqVGwbkh2E/w2H1kfdrEt4B+E8L23GMAETH7B7 8Uy5JPaiA+IiqvgrcgPu2kJRxVJWi+D+N3mN4He5Pq6tsXdt6Wp31i2GMkwqGB7Vpd7X sduet/0ExGfbe3Z3xgjVQBfHwNEtO75wTGjBUIWEeTPsGPAypmO+/wEH9x4+b5zfaWsn a28w== X-Gm-Message-State: ANoB5plk9C2mZEQ11ApKmnisPga87AricOeXI+ldE0g9iPwXbemyzZdl Lc/rlW2kK5//3PN5vfw1/D6ugA== X-Google-Smtp-Source: AA0mqf4o+Opd6iZHcIE3wpQuVYIag2P9ZEaQkNzJlDYHX3AmOp+vAgdalh05FTemyjJ/ijxekkwsug== X-Received: by 2002:adf:f209:0:b0:241:792e:237a with SMTP id p9-20020adff209000000b00241792e237amr9389879wro.511.1668528472439; Tue, 15 Nov 2022 08:07:52 -0800 (PST) From: Grant Likely Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_C69F1D2A-0C88-475B-AD2F-384D65B68652" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\)) Subject: Re: [XEN PATCH for-4.17 3/4] xen: Add licence header to device_tree_defs.h Date: Tue, 15 Nov 2022 16:07:40 +0000 In-Reply-To: Cc: Anthony PERARD , Xen developer discussion , Henry Wang , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Andrew Wafaa , Robert Booth To: Bertrand Marquis References: <20221102112854.49020-1-anthony.perard@citrix.com> <20221102112854.49020-4-anthony.perard@citrix.com> X-Mailer: Apple Mail (2.3731.200.110.1.12) --Apple-Mail=_C69F1D2A-0C88-475B-AD2F-384D65B68652 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Linaro approves the license change Acked-by: Grant Likely > > On 11 Nov 2022, at 13:51, Bertrand Marquis = wrote: >=20 > Hi, >=20 > +Grant Likely from Linaro. >=20 > In the following change, we need to change the license to MIT (from = GPL) of one of Xen public headers which has a Linaro copyright. >=20 > @Grant Likely: could you confirm that Linaro is agreeing for Xen = Project to do such a change ? >=20 > Kind regards > Bertrand Marquis >=20 >> On 2 Nov 2022, at 11:28, Anthony PERARD = wrote: >>=20 >> This header have been created by moving code from other part of the >> project and miss a licence header. The original source code was some >> version of GPL or LGPL but we intend to have the public header to be >> MIT so they can be included easily in other projects. >>=20 >> Part of device_tree_defs.h were moved from libxl_arm.c which is >> LGPL-2.1-only. And part were moved from device_tree.h that is >> GPL-2.0-only. >>=20 >> Part of the original code were added by Julien Grall @ Citrix with a >> Linaro "hat" in commits c3ba52a84dd8 and 405c167f0ec9 and >> 886f34045bf0. The other part were added by Ian Campbell @ Citrix, = with >> commit 0c64527e7fc9. >>=20 >> Resolves: xen-project/xen#35 >> Fixes: 1c898a9fec7e ("xen/arm: move a few DT related defines to = public/device_tree_defs.h") >> Reported-by: Andrew Cooper >> Signed-off-by: Anthony PERARD >> --- >>=20 >> Notes: >> Julian was working @citrix until 2015. >>=20 >> xen/include/public/device_tree_defs.h | 6 ++++++ >> 1 file changed, 6 insertions(+) >>=20 >> diff --git a/xen/include/public/device_tree_defs.h = b/xen/include/public/device_tree_defs.h >> index 228daafe81..9e80d0499d 100644 >> --- a/xen/include/public/device_tree_defs.h >> +++ b/xen/include/public/device_tree_defs.h >> @@ -1,3 +1,9 @@ >> +/* SPDX-License-Identifier: MIT */ >> +/* >> + * Copyright (c) 2013 Linaro Limited >> + * Copyright (c) 2015 Citrix Systems, Inc >> + */ >> + >> #ifndef __XEN_DEVICE_TREE_DEFS_H__ >> #define __XEN_DEVICE_TREE_DEFS_H__ >>=20 >> --=20 >> Anthony PERARD >>=20 >>=20 >=20 --Apple-Mail=_C69F1D2A-0C88-475B-AD2F-384D65B68652 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
Linaro = approves the license change

Acked-by: Grant = Likely <grant.likely@linaro.org>

On 11 = Nov 2022, at 13:51, Bertrand Marquis <Bertrand.Marquis@arm.com> = wrote:

Hi,

+Grant Likely = from Linaro.

In the following change, we need to change the = license to MIT (from GPL) of one of Xen public headers which has a = Linaro copyright.

@Grant Likely: could you confirm that Linaro is = agreeing for Xen Project to do such a change ?

Kind = regards
Bertrand Marquis

On 2 Nov = 2022, at 11:28, Anthony PERARD <anthony.perard@citrix.com> = wrote:

This header have been created by moving code from other = part of the
project and miss a licence header. The original source = code was some
version of GPL or LGPL but we intend to have the public = header to be
MIT so they can be included easily in other = projects.

Part of device_tree_defs.h were moved from libxl_arm.c = which is
LGPL-2.1-only. And part were moved from device_tree.h that = is
GPL-2.0-only.

Part of the original code were added by = Julien Grall @ Citrix with a
Linaro "hat" in commits c3ba52a84dd8 and = 405c167f0ec9 and
886f34045bf0. The other part were added by Ian = Campbell @ Citrix, with
commit 0c64527e7fc9.

Resolves: = xen-project/xen#35
Fixes: 1c898a9fec7e ("xen/arm: move a few DT = related defines to public/device_tree_defs.h")
Reported-by: Andrew = Cooper <Andrew.Cooper3@citrix.com>
Signed-off-by: Anthony = PERARD <anthony.perard@citrix.com>
---

Notes:
=   Julian was working @citrix until = 2015.

xen/include/public/device_tree_defs.h | 6 ++++++
1 file = changed, 6 insertions(+)

diff --git = a/xen/include/public/device_tree_defs.h = b/xen/include/public/device_tree_defs.h
index 228daafe81..9e80d0499d = 100644
--- a/xen/include/public/device_tree_defs.h
+++ = b/xen/include/public/device_tree_defs.h
@@ -1,3 +1,9 @@
+/* = SPDX-License-Identifier: MIT */
+/*
+ * Copyright (c) 2013 Linaro = Limited
+ * Copyright (c) 2015 Citrix Systems, Inc
+ = */
+
#ifndef __XEN_DEVICE_TREE_DEFS_H__
#define = __XEN_DEVICE_TREE_DEFS_H__

--
Anthony = PERARD




= --Apple-Mail=_C69F1D2A-0C88-475B-AD2F-384D65B68652-- From xen-devel-bounces@lists.xenproject.org Tue Nov 15 16:12:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 16:12:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444010.698769 (Exim 4.92) (envelope-from ) id 1ouyY2-0006Br-Gb; Tue, 15 Nov 2022 16:12:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444010.698769; Tue, 15 Nov 2022 16:12:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouyY2-0006Bk-DY; Tue, 15 Nov 2022 16:12:30 +0000 Received: by outflank-mailman (input) for mailman id 444010; Tue, 15 Nov 2022 16:12:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouyY0-0006Be-Lb for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 16:12:28 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4959b349-6500-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 17:12:26 +0100 (CET) Received: from mail-dm6nam12lp2172.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Nov 2022 11:12:19 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM4PR03MB5968.namprd03.prod.outlook.com (2603:10b6:5:38b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Tue, 15 Nov 2022 16:12:17 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Tue, 15 Nov 2022 16:12:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4959b349-6500-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668528746; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=v8GCrpAdrOkqukaSE7PdOYTuADv75JEodjgNPozj8Ac=; b=aapPH1tpf0Ca2fgKvcgw1HBrBvc1UgdrhWeLfp8vC+JJKa3nunVKv5we ywoJxWlrux+MxK0w1sT3hsBVSCJBykHoU8+kcydSyo7BFXCt/EwbMdDdP mWaRHs1in+gQc9qKfeexnwhV+LJHGFM3MFv2/SgqZr03L+JojStrBz9AR c=; X-IronPort-RemoteIP: 104.47.59.172 X-IronPort-MID: 84455575 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:9FifTqpzBh4Yk10BLTKOAqgOgiVeBmIrZBIvgKrLsJaIsI4StFCzt garIBnVOPaOZDbyetwjPoznpkJSvcKEmN9nQQdlpCgwFSsR9ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHziRNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABQhagCvutO0+7Llb+k9gNR7NfXqPLpK7xmMzRmBZRonabbqZvyQoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jemraYWPEjCJbZw9ckKwv GXJ8n6/GhgHHNee1SCE4jSngeqncSbTCN5OSeDlqaMCbFu7m34tUwwbX0OBhvDkhEGGWu5gM 3Qk0397xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnO0cSCEu1 1SJt8j0HjEpu7qQIVqC8p+EoDX0PjIaRUciaCkeXE066t/siIgpi1TESdMLLUKuptj8GDW1z zXUqiE73u8XlZRSiP/9+k3biTWxoJSPVhQy+gjcQmOi6EV+eZKhYIurr1Pc6J6sMbqkc7VIh 1Bc8+D20QzEJcrlePClKAnVIIyU2g== IronPort-HdrOrdr: A9a23:EAgq2KtJw4pRCzRyKInTTvcV7skCHIAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YaT0EcMqyNMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPHxXgspbnmNE42igYy9LrF4sP+tCKH PQ3LsxmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzI39QWUijusybjiVzyVxA0XXT9jyaortT GtqX2z2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuQFNzn2jQ6sRYJ5H5mPpio8ru2D4Esj1P PMvxAjFcJu7G65RBD8nTLdny3blBo+4X7rzlGVxVPlvMzCXTo/T+5Mn5hQfBf141cp+IgU6t MD40up875sST/QliX04NbFEzlsi0qPuHIn1coelWZWX4cyYKJY6aYf4ERWOpEdGz+S0vFQLM BeSOXnoNpGe1KTaH7U+kFp3dyXR3w2WiyLR0AT0/bloQR+rTRc9Q811cYflnAP+NYWUJ9f/d nJNaxuifVnUtIWRbgVPpZPfeKHTkj2BT7cOmObJlrqUIsdPWjWlpLx6LIpoMm3ZZ0zyocokp ipaiIViYcLQTOuNSSy5uwKzviUK1/NHggFi/suqqSRg4eMCoYCaka4ORITe8jJmYRtPiSUYY f3BHtsOY6TEYLfI/c34+TAYegtFZA/arxhhj9pYSP7nuv7bqvXi8f8TNH/YJLQLBdMYBKOPp JEZkm4GPl9 X-IronPort-AV: E=Sophos;i="5.96,166,1665460800"; d="scan'208";a="84455575" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mvt3qf5XhDkSCMHeKmWEowcRSSkmZi4Mstq5x3xfuLfC2JulGaEgeEBa+yktqI1BBe9ax4zDfozMtYaxN74fGVzwsgVFGU4K/MotMi8E/hmoj1clOebxEgTwbAarcQYgvUPMrDwJDwtOIk3vEMZqUMCpIwK/w36AEi72A2+QM3rp+l6VrpmUWnY1P+9gNAmKPZmLWPHLWbnzg7TCzAWjAouqtSiD7IwRS7zwNJyTU6zo2XXNW+CEv4cOOMCa2BEBySV5xW568FLg8x1g9PGWaNCxXMAzdg3VP5JFDTUX5+3wt8JWRdeENmPRH2FQsVHmbL6s3OLwG1uFuQWeGU2VEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dVs5NBjHeAMY0x46s4TBtb/ZqluXCirmz2KCHMrmTr0=; b=izNOfm/UpgeRPEcD8zh/fOE89/Aw20rL0Af7rsIBo+nbQhS6suGUFh2k7K0jOv+L5+11hXj0pHx1xve2gqe5+4DJKPq14cHr/osacHOKIL7miQiinkC0aVTR//cFdA5iVEg8HOjj/lwOgiYiMWv7fQVrWUb3Qosz9PhVZeqj91ubZ1iAtrvXPM3NV9XqFYZuMfA5j6Ibc1zBGu2S9NN8VqhoU1H7Vr0AEHLSWLOQHFQ9KdReGe2zHBX149dEEhRfpa/MrNDzW8wAU7oMi1XN72HVxZjJGGhrt1oZ9r+CVzVQSdO+asLQSG4mYQlvuo8/yvcI56SDTclZVQXZs99Asg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dVs5NBjHeAMY0x46s4TBtb/ZqluXCirmz2KCHMrmTr0=; b=vxEPxP9OtjKeuHlt9LmuYJTrUgTvk0SRytWFyK2nPf/t5SGRCKgfCYPbXq+lBXjvbm7M5uO2BQ54gWkmSD22PPNybAxox6TbMjvMMmr6snNt8MXb1+bk20Cc81dQPoe8uSwDbTqNr+PnRCzQNeDq6ZrUl6VwIrJ9ctHMfvRQ+s8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 15 Nov 2022 17:12:10 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Wei Liu , Henry Wang Subject: Re: [PATCH for-4.17] x86/hvm: Revert per-domain APIC acceleration support Message-ID: References: <20221115003539.19502-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221115003539.19502-1-andrew.cooper3@citrix.com> X-ClientProxiedBy: LO4P123CA0517.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::20) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM4PR03MB5968:EE_ X-MS-Office365-Filtering-Correlation-Id: 18b89f0f-fbe7-4b9b-f4a4-08dac7242a5b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5KlX11qOkAee9p0PVTdYsNhHobq04yS2+ZPcpUECpnoOrUZJqKFOF3M0QAIave5MiQ9phi/en3lvi9yfrVT5fCHxWwAyC/Fh3HAK/Eqgb8zRhjvqLCtPxFAGeawFlShzgPWfuDKZQ4cqcGuLuMADjY6q0J85IQzjcjSaApIfBnegMO2BL6wcmXzWk7ly5sLDf02wDgKgiCQu5XZQHLKSUkp6QLdTknCfJwntK9geqM1dk7uJp6THkb/z6gvnn8IZQXRn35KqPEr3zqDci7oJgIA7mBeH1gZHfMQZRkshyq/BGUjB4xfqTvGe2RB9KtT8cu1Qdph6KZ+HBGNIZSOUHnC/4s/ezj60TJ3a9tf3QRs0Aegca0WOw89VG/Gk9ybBIi7locHXdt1H1yO5jEo73qahT8QqwuQlVObmmiVwUzInTsw/D1JWf6R1LmO7wPnwie63H1TSVYoIrLwcPmBQDvM3OGwm47SM6Vsz73PkYJmw8ux0iWW+NSpBNtCLVevJq/Mcx/o8rbNtoPXofzQmRaFhtcbQbFzJ1bpr8VzONHo0sjGOVHIND3Vt9jZ7BlOTzSxIAUdSLCU8Iazgwp7m5rbasTjFMcYAzXr0KeAv1CuRUrEEl6SrdE2YVAjrMOleJiJNSMXxvthBykf6ALsorEBRB9dDpRDGT8WHhihQ4V1ppVju0ZMaLEZO+HkmAgvhK5VsM6Y4dKz5gas7ZxvEUw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(366004)(396003)(39860400002)(136003)(376002)(346002)(451199015)(5660300002)(41300700001)(2906002)(8676002)(66556008)(66946007)(66476007)(316002)(6486002)(4326008)(54906003)(6636002)(33716001)(6666004)(6506007)(86362001)(83380400001)(186003)(9686003)(478600001)(26005)(6512007)(8936002)(6862004)(82960400001)(85182001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEZPL3haL1JEa1lIbExaUkNEUHdGSmdJZTl6c2RmVU4rYUtWc05GTG1xeDlr?= =?utf-8?B?NnE4TTAyeEtMRGRMZENabURIN3hrYXBOTGthRWxPV2hNTG1ZdStZR09MWDNT?= =?utf-8?B?cmIxdmErOHByejZZZnhpWmcvSlJkS3UrVy9pUnVMRHlXcVR3L2grYlMxL0RX?= =?utf-8?B?YzVpaUtzSEs2U2JpTnhTNDFGNXFiWFpBMnc5c1lzSnlodkpSYzNtampvQVF1?= =?utf-8?B?Z3pIcFN0ZE9EOXdDaFpOYlE2S0NLNlJpcHVCdDRqUGZkQW9oVGx5NTM3OSsr?= =?utf-8?B?M2xGWTN2RUJKR1BRM29xc2QwWFVpaGtyNldiVEZaYlRHcVFzbWJOTW5Db3Vt?= =?utf-8?B?OXFFbjN3dmZtY1kyU1c4K3pYNXVuMWhkRHU4MURuWTJXcnJiWjFQWnhja2Y4?= =?utf-8?B?UHhJSDRBQWZPS0t2UWN2M2NPalUzN3IwTnZEcG4zOTlCb2hDVlFNU0VlSEEy?= =?utf-8?B?aDB0NnB0TWU2VExYRnRuWTlEcXJ2Y2E2NHF4YmZyNHkzM0lHWFdURWtBa29H?= =?utf-8?B?L1FWRFZMM3VBTzFtcjZmQVBuajZxTEFmSHU4cXQwM3BBemVQbWQzdzJRME1L?= =?utf-8?B?b3lySGhjZVE5d1Z5Ui9CNEplWWxsQUg0d1psR1htZHVhTGRuLzgxUEZiMVI0?= =?utf-8?B?UjdnK2xpbFF2bU5Xc0tnVERGSCs3RDNrc1g1K2lIQ0tjQ3hKS0Q2aXRsVzNn?= =?utf-8?B?RG1LaG84bmUxU0xLeEE1NEFGWkljR2NTdlZmL1RKOER2c3IybFY2SnNHeFJq?= =?utf-8?B?TVdHUFBDVXNxbFVTaXNZMmZWeVhpM0xvZytEaG1hUDluTEFYRGJ6Y3BqUUhY?= =?utf-8?B?eS9nWHY2LzlxODFRcGNRaGRORWlzUVd5V0xjYTZCbzV3cnFsdVpyNTUzeTFK?= =?utf-8?B?UGZDc2tNNVk1eWp2VkFxWllhbnJ5WmV6aUswZFU4dmMwODZjTllqc0ExRDJM?= =?utf-8?B?VjZUeUNwaWJZdHkyQWhTdFpWNitwM1ZrcG56K3JaUTJHbHB3WUpmV2pkeUdp?= =?utf-8?B?SEw4NmJWdFgvL1hRNkZ4cU1QWVhvZ1NpdVZzdktTc3h6YzFaRnY1aEN4R2V4?= =?utf-8?B?cUhLVHUyZTgwNUpYS2x0a0pjNkJPcDUwM2Z5bHJ5WjVjeDQ3QlZMRkFqZ2xR?= =?utf-8?B?ajJrS2NEUWJ2RnZOQnZXV3FQQTZ6R1B0ZXJTV1R4VDZYclRuNmFIZTN3cFBn?= =?utf-8?B?aWZnNlVCU3hCamhjZ0pRNVFlbUNlUTNleG1OR0pObmFwbWZReFZraHFkM2M2?= =?utf-8?B?UUtwZ0NsMjhDT2t6T0l4ZUFUZjMvQXJ3MUQrSnB6eWZ2ZVVQMjVGSVlnQXNH?= =?utf-8?B?cEdLYUJwUjI0bWNKKy9zSlRIYXFRSjRyc0Y5dktvZk1oV3lUT0FRSm5BUFBF?= =?utf-8?B?ME5ybk5qVS8vcGpVbWlWRGxmTWlkNk1jZG1hOFFXZlpabzJmYUkwVFppL1dn?= =?utf-8?B?TS9EWkpLMXdtcFBmdmw0UjJuV1ZoRnZ0TDJXRzF0V1VleEtNek1MTC9tdjhs?= =?utf-8?B?YzRVVHBma0JkdXVXdmtTNmVibm5XTFZ0UWRaT1g0SStpVTc2bHRBclQ0MjJj?= =?utf-8?B?K3FDbjhNcDNyMGEvRjlGdStnOWJxWCtaRTdkSXlWbXJ5T1JnOEpiR3AvWVdM?= =?utf-8?B?ck5rU2ZWMTNqVWF6ekF6SmVLcnF6OVBvZ3ErRU1PRmR2ZFFWSWtZT0RyVDY4?= =?utf-8?B?aDN3TElqQm9CelJTSCtOWmMySFRxaDcvQ0tiNTIzRVRPRTduZW5aSFdJTkdZ?= =?utf-8?B?SEFvQm1Pd0RzbU55cFRuWHBIbnBOOGZHMUxOcTNZMkFqWlZzclpxVWh3SGNY?= =?utf-8?B?MjZGSmdMMXlZT2NNcDdKOXlnNXBzSHU0UUc5eG9uYUx4VWZoMTRRY3pVMFNt?= =?utf-8?B?eXA3RlFVLzE5U1dlTjY2TWpjU2pTdEJZeFQxY054YW5IYXBMNmJZUFNQWVNC?= =?utf-8?B?Ni9QZ2wvRlJhR2YvSE13Tkdvek96VlpyOSttOWJieXFrWDZBdGovVGVqZXhT?= =?utf-8?B?WU5GOXJndWdDelhtU1NVM0J5RVc2YVFpdEF1TUxkTDJVN2pRcVVVejRrK3Z4?= =?utf-8?B?MUJiSWllRmxublk2VlZRRzhSa2Y2ejZLaXhxQi9iMGlnWEdaenkwck94cElI?= =?utf-8?Q?lZ3ispl1wsNDwr9ewqha7L1pp?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1PhR0KjHpBriUFuPPyckUiw1rvB/ATnef9HG9Zq3cQe9anVLFOA9DKAAXq7hWj43YVhsN66/+th5bsWbTz0+akrz7bOEhkEUEsFrm0LQ8enaph8UNE+1VtSyCryKgm3zwCBmd4jREnKNJeGh/7/ojcpYaiQ7rPgsnKAbWL7b/cU0AXKaTno4pEXx89tqWMNYlcjBtmnkrow26V7NX1sodBaP6Cf1xqUm7YxkD/pZlpYGn1CnNA9Ynt6PTQYiPylcC6M23mnP6Pe0C2oWpO+Oio8WPY+oleXCLMqenhPsHMVEZaPby1EIUE9nSw+odgajhLLFN9cNF/slPVP9Wwf9oBn+h3tSlG1do/LiLvRymBHR+rGCJf3Sq38hj2zHzzXvjep3SDgnbapAJkeX2iqErk85zhdkUArz9tvR3+laQ38ucwnzNj/a5rrs8fto0OAzwAPkdBfH7KvSqY7mo2BhXfsC4g9UOv2dbM/QZxWCuU6l0qFE4aMBRmzn7p8Q7youo0uGQzqgIzmO8zH0ojOkCtdRh4IGkXQ9igekyPsGLQMFB11AiWiQQaUY48Ut6EIWOzot2TixrE1EjnujQ8KqWsMwSBupNYJ5PQJWLSAnhch0p3lGHMQkTiF1vkemoo9r7CpQZMmSzck7VUtoY8Qp2QDjONm/YbMWCo+gBtTyDAP8LCDzIsseZLNDuRpTQwCqRMcy3SEG5q1wTRDVEqFU6Z7NB0lDTCpFYRSXNQ6giZtx1EuciBm8geEzmWeEZHEeGpdSGPS4mAKG/Tsyhvrp5wr+VcoTUyKlduMmP0dqe9Qni4V5qFic77HzlR2kfYoEBpSoUXuyHnZpGBb7azWQTXBBcht9N2UbPGtSdp/hu7M= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18b89f0f-fbe7-4b9b-f4a4-08dac7242a5b X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 16:12:17.1953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zpOz5R2Gjjyd/MZs3r6EPIdfePwg/ZQdsGwO3JGIp1wYvY6sue6yHqddI+/tDbpn4/RbSRDOpZ2PhKe9bklyTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5968 On Tue, Nov 15, 2022 at 12:35:39AM +0000, Andrew Cooper wrote: > I was really hoping to avoid this, but its now too late in the 4.17 freeze and > we still don't have working fixes. The fix I proposed still has some comments that have been unanswered, but at any rate thit is now far too late to try to get this fixed. FWIW that same fix was also posted to the security list way before hitting xen-devel. > The in-Xen calculations for assistance capabilities are buggy. For the > avoidance of doubt, the original intention was to be able to control every > aspect of a APIC acceleration so we could comprehensively test Xen's support, > as it has proved to be buggy time and time again. > > Even after a protracted discussion on what the new API ought to mean, attempts > to apply it to the existing logic have been unsuccessful, proving that the > API/ABI is too complicated for most people to reason about. Are you referring to the VMX hardware interface to setup the related APIC assistance flags, or the hypervisor interface to control those features? > This reverts most of: > 2ce11ce249a3981bac50914c6a90f681ad7a4222 > 6b2b9b3405092c3ad38d7342988a584b8efa674c > > leaving in place the non-APIC specific changes (minimal as they are). > > This takes us back to the behaviour of Xen 4.16 where APIC acceleration is > configured on a per system basis. > > This work will be revisited in due course. I certainly regret having been involved in attempting to fix this, and I have to admit I still don't understand what is broken with the current API/ABI. Do we want a flag to control the setting of the APIC register virtualization feature? Is the naming for the flag that we expose incorrect? Is the field where the flag gets set incorrect? There isn't that much to the current interface. In the previous reply to the fix however I got the (maybe incorrect) impression that current bugs in the implementation are used as a way to justify why the interface is broken, and that is not accurate. The interface and the implementation are two different things, and bugs in the implementation shouldn't automatically invalidate the interface without further reasoning. Also, for better or worse, the current domctl interface where all this is implemented is unstable, and hence we are allowed to make further changes as we implement more related features. > Signed-off-by: Andrew Cooper I'm not going to oppose to the revert, but as said above it is still not clean to me what is broken in the current approach apart from implementation bugs, hence it's unlikely for me to revisit this work, at least not until such uncertainty is solved. Regards, Roger. From xen-devel-bounces@lists.xenproject.org Tue Nov 15 16:21:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 16:21:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444016.698780 (Exim 4.92) (envelope-from ) id 1ouygv-0007wD-Cp; Tue, 15 Nov 2022 16:21:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444016.698780; Tue, 15 Nov 2022 16:21:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouygv-0007w6-A1; Tue, 15 Nov 2022 16:21:41 +0000 Received: by outflank-mailman (input) for mailman id 444016; Tue, 15 Nov 2022 16:21:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouygt-0007w0-VW for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 16:21:40 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 924d44d8-6501-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 17:21:38 +0100 (CET) Received: from mail-co1nam11lp2171.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Nov 2022 11:21:09 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by MW4PR03MB6990.namprd03.prod.outlook.com (2603:10b6:303:1b9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Tue, 15 Nov 2022 16:21:07 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860%5]) with mapi id 15.20.5813.018; Tue, 15 Nov 2022 16:21:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 924d44d8-6501-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668529297; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=MplvytQ/0P+vTrUB/Js1KPcOExHp+Rr+0ASILNrxPiI=; b=ffSyLTXvdfteqSCPu4OIpnmy5CNGqxV+MA7ZNRupGbBVTQyTH5hO63Se h8rl9qSaCbIx8xKmBVT44w0kiBu0Rg8yyIG78lSnilfJ5kgzjVTRiEkLN a0sgatfG6kOoPL67Rgm0RIK2kyZGNiFazos65R1aEHOM8rur5JlBBlQlQ M=; X-IronPort-RemoteIP: 104.47.56.171 X-IronPort-MID: 87407914 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5dTmB6sp5cfIxESxovUe76DwoOfnVGhfMUV32f8akzHdYApBsoF/q tZmKWnUOf6Damumf9x2boy28B5SvZCAzdJiGVA6/nozFCkS+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaHyiFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwCHMVVgGCue2P+b+edvJwnsgSEMixM9ZK0p1g5Wmx4fcOZ7nmGvyPzvgBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjv60b4O9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPO3nqqY10QTProAVIBoJbRimmtygsRGvUvtNF 2we3A08grdnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQK2 1mTjpXWDDpgmLSPTDSW8bL8hTG4NDURLGQCTTQZVgZD6N7myKksijrfQ9AlF7S65uAZAhn1y jGO6SM53rMaiJdS073hpA+exTWxupLOUwg5oB3NWX6o5R94Y4jjYJG07V/c7rBLK4PxokS9g UXoUvO2tIgmZaxhXgTcKAnRNNlFP8q4DQA= IronPort-HdrOrdr: A9a23:iSBmNaggI4hpBodSPWwMsHvpbHBQX/J23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu17h/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboXgTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp9KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wXh4SqbpXVd WGPvuso8q+QmnqKUwxeVMfmeBEa05DWituhHJy4vB9nQImx0yRhHFoufD31k1wiK7VDaM0p9 gse54Y6o2nBKUtHN1ALfZETs2tBmPXRxXQdGqUPFT8DakCf2nAspjt/dwOlaiXkbEzvewPca 76ISVlnH93f1irBdyF3ZVN/ByISGKhXS71wsUb45RioLXzSLfiLCXGETkV4oCdiuRaBteeV+ e4OZpQDfOmJWzyGZxR1wm7X5VJM3ERXMAcp95+UVOTpcDALJHsq4XgAb7uDauoFSxhVnL0A3 MFUjS2LMJc7lqzUnu9mxTVU2OFQD2KwXuxKtmuwwE+8vl/CmQXiHlltb2Q3LD6FRRS9qorYU B5PLTr1qumuGjexxe701lU X-IronPort-AV: E=Sophos;i="5.96,166,1665460800"; d="scan'208";a="87407914" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OOzUZuimBL5jn0Qe50rpZV+EPwGQIS+M37d4mhbKiGIlRuyCSusOUQ92Bnpu+1sVov2WLtq01vWN3RiytZmKx9R50cxicLniTdTMugk87jhf/Vh8VSRJokug+mi4cvdamSJX9nuVu26qHbKJNxyLtOrIRaKFZ/mXQJZDiPgArSY5Y22Ipm7NAoR0jav6KeonJX4DWCl8Klg8wUcqF82jKezgIEPPiVgn1QDG+BbecBFP+MR16JrcoRzctx6x7Xh+d2QkmTqeLXcJI9hAGsIMVXjsVmt2fdNhvtybkSJCx49rkNp55T6Pn2Hi6RWw9Gkmi69kirjTicxlK7UcnNQmAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MplvytQ/0P+vTrUB/Js1KPcOExHp+Rr+0ASILNrxPiI=; b=W/bfhsToHAPp1wPdavxEHqMOG5k1Jzp81IiW12M15N+UXq+7GT0a0xgi1E8XwzRL3T095oGJgW4BCMJgxUKSCfjpzOMA92cw17BqK4eaO4JEK/clh59f/JhbkoKZd+22fggoGpJDSHlmZDSptprlqOtboc8Gf8ze/n+wO7cj2eDXqmQ5oZ/aZPiFuYVqkJi3wTic8G1InyEEQSRfgrTWu3lpmF9x2yRiPLM1kqAhE2A+0rdX2O1reGIJuist7zEGeXx+BeupnY71cZh/O1yzW8NnXQzasWeqK+SE5IL5V4NY86/9/5Sj4tuedKul/KQBZWdPvGnKMUUd5O8DQp6wVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MplvytQ/0P+vTrUB/Js1KPcOExHp+Rr+0ASILNrxPiI=; b=d1STvG4cly0Iab097AFcD00KLu3lmYwPkIs3vvmZRG2QC1dornSXjoTehnJn6PHro/rlcpDuRl+cJeOemtmoiB5JcoOWbYKNHeRGXsS5HTYqdgoJkbhnkT6fYRJsadV741D893cBlCWehzZipNPGibE5yKom+ZS2PbAQ5eMXL14= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: "Henry.Wang@arm.com" , Jan Beulich , Wei Liu Subject: Re: [PATCH for-4.17 v4 2/2] amd: remove VIRT_SC_MSR_HVM synthetic feature Thread-Topic: [PATCH for-4.17 v4 2/2] amd: remove VIRT_SC_MSR_HVM synthetic feature Thread-Index: AQHY+PYG7JqnYiwdr0usZ0w09l5ina5AKpoA Date: Tue, 15 Nov 2022 16:21:07 +0000 Message-ID: References: <20221115132657.97864-1-roger.pau@citrix.com> <20221115132657.97864-3-roger.pau@citrix.com> In-Reply-To: <20221115132657.97864-3-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|MW4PR03MB6990:EE_ x-ms-office365-filtering-correlation-id: 5488ad63-6d53-43bb-04d1-08dac72566aa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WuD/xjXgSHKMp5V/lR31UgougEwdbR1p2kwOCXPjEG7+kX+h5K+AHOdL0b+aaCVpfNC5PgAOZpdkrdc+kX6MObI8WwsRaZc/25IIZN8jfAkiBSbJWgvKtABkLji0MVMWO3vsDEM8RBltdO9pUpGH5vIL1Pu1YxnMGxiBRS1LBNajL4u8GxWnsJWsZgXfJtQ94HLKhPlukyIFurBNmHGHQoacp+UHUy+jdnKNBI+9ZkmuVCqpV/aGQZD0yeK7s7XCVzo4ZysBHFtFoDHUfFK/mLaVFrPMdDBi6Ihs8TwuDbaAWKDw0EnsFVCGQtm7N31hTIU49OQ8wNkkRdlJhRG4vZvIKeX1+t5u/dWFbMRcvUhMx4hqbeg1TTFoh0odqh1eYy9Lrip4HXZc3nWfh/4jWB211ua54JpUyDQ6ukoiYFAfOzaHlLgheoJXSQm23RA931lpfplmgVkg9g5r9RKg5WISNhN6Le5ApI582i0HVzpOzqQXKLtMq3rQUrjycIBPT04avjGYN+yrdCUjRRKI7O0tKrYrjNfEF2JHMVOoGp3nilB9G1rYgPdSN/hf2IQp2yiQQhOj6HcJChnerf+vrLNmQPJKm2gMcdWD2h65zZmLxwuMEDO9aWJAWy+DUGmR1tomV8OtrG/89/+T3QxRbAWkqK7Pldk1zWPsgH4ByoR9TzQscPNmGHa5Ni7reFX6HM+RKVUBNtuZRdIahGPTSn/XjW2cHkis+wO6RkSYkYFf1amB2paQpFHubbLP+EuUidDmEzHuwYWnSRmAl9ZmNMUbGmvhZYOUunYPmep9MWTxgLPsP367ZP6Um1RbIgpV5B3AV1GjSdbjSUBej6IOhg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(366004)(376002)(39860400002)(451199015)(26005)(6512007)(2616005)(6506007)(186003)(53546011)(122000001)(38100700002)(82960400001)(5660300002)(2906002)(66556008)(54906003)(6486002)(71200400001)(110136005)(478600001)(41300700001)(66446008)(64756008)(4326008)(8676002)(8936002)(316002)(76116006)(91956017)(66946007)(66476007)(86362001)(38070700005)(36756003)(31696002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SFhCM1pPQmc1TVJPc1BVZU9sNTJLdUFxcGRwL0o2ZE9hd1hNR1p0OGlackEx?= =?utf-8?B?REhzbVFLb3VtTEZwenRzVkxEUGxkQ1haMkJobFVmNzd4SDE4cnRtUmw3TGxS?= =?utf-8?B?YzVETkgyYkZXbEd6QTI4WWFMZjB4MCtrZGdKSUlFY3ZiKzhEQm1wMW1lY1NZ?= =?utf-8?B?Nmcxd2QrL1JKWTNhcTAybVB0d0p5OXBOSzRmMFVFYjAvNGlYMVJFVzZDNXFs?= =?utf-8?B?SEVMZ1duenJxS1VDdE5Jbm45Z1NFUnpTY2pVWDI2MVVWczhzTzhkQlgwM2Fq?= =?utf-8?B?NXJyWVdPRG5aMm8vTVlhNm1mVi93WVBXdHRkdXA1OW9oZ0xMM284Z2xZSi92?= =?utf-8?B?SC9sdC95SnJGZlVJN2dMb0VmR0h6d3FQQTBKSTVYalE3bXAxVTgxSUFXd1dD?= =?utf-8?B?a2twZUZ4dXFXdVlON1J2NHc1RWErUU5ML1BhZ3AxVFJ6TDZkRlMrTG5kdDdt?= =?utf-8?B?aEgzY0IzbitCZlBqWjNjV3o1M29mVlFSVFd4VEZYSER0OUF4T0RVTS9LRFZ2?= =?utf-8?B?OEJBc3RNaTdUVWsrbmVTZGFXMGVlSzZuTmpXNHk0enB3bUc1ZHR4SEdoRlJ1?= =?utf-8?B?U1JFeDBjMlZkTUQxY3pINStLZTc0ZkJJcVE2UWREdEZZOU1wZkVjdWdRbmJW?= =?utf-8?B?R2tNTHYwcWxuYmlBeUs5S3ZNMWFmNHRMOGpwTGQrdkpuQ1dtdnpoL3dPYTFp?= =?utf-8?B?T1pObkpzWm83dGJTcnpEdHdMZjY0YkJjUDYvUnNjZklMaGZ0UE5ySW4zZEhy?= =?utf-8?B?UllmdWhnUkNkMDJ5M0FyWWgzUnNYeitlOWlsWVBuRisvREpLNkRXYmU2OVZR?= =?utf-8?B?NUZKU2pvWW9JcWVPbnNXcU5kazlkMHFQdTNkbjZFUEE1SzFFOHpWZzZvSmhP?= =?utf-8?B?QmVoQUdMUlZtMkxlekU0N21rcTBaQnA0WDdqQXlUd1IwZkFXYjNxcFd4Uiti?= =?utf-8?B?RHptVWN4Yy9nQVYxRG9BMVN4V1phbGxHMlF3UWVmNE9OaklFRmxZeExCekhL?= =?utf-8?B?YlRuZlkxeGNKbG1vbmdjbEMxakhwNUMwUmtSL1hmTnRzTGhKTkVNRS9LaUdT?= =?utf-8?B?T0tLQXJwckZuVkc2QjNWWmZScloyNUNsUitXcFVzTWo0MnZmeGw1SUdsUHk4?= =?utf-8?B?VkpCbDVFc3h3cXNtN0thUTk0L0NvVjBTamppajNOcWhFbU1tYUtlV2xJZkZG?= =?utf-8?B?UFg3TEQ2V3JDRUJ6Q2t4K3drQWdaOHNqaHhXRFpNY0RoeUw0bVgxNWJhYnk0?= =?utf-8?B?MmxkSnU1dDA4QWsrRzV4dGhXM2N4VEowaXVlQ3R6ZGc3V3NhQ05Sa2hsZnYz?= =?utf-8?B?N1F5SGszY3JtUS9DRFJvRmRvd0hGeU9vdS9ISmxCMHZpRE9yTU56dVpMcmZ0?= =?utf-8?B?UkE1U1hTaVllYk1wdTRhbDM3V0VLNVdJa0tHK0crMlpRTjVaQVBRcVFmRW5G?= =?utf-8?B?UERCNlMwVnd3UmNjNk9tbUNLaHlOKzNxYkYxRFovQlVSOFFPODgvQkpmeE1N?= =?utf-8?B?eDlKSHlTSEZaOHRod3duTFRtWCswYTdpbk9TVkFIR1piNlNPMU1DcVVoWnVi?= =?utf-8?B?Znp0aEtoS1lrK2NtbzdMNmxtc3loTlhESGtkVDcvV2EzakRHY2tLSkt5S2JZ?= =?utf-8?B?aWpDdmNBTnJEcnRNYThFc1dmaDZ2UEcyNzc3MUpZRzQyUUR5YlNGNmhlMEsw?= =?utf-8?B?QlRBNHM4SEhISHJNVFJBcFdRRXI2OVRsL1VxSkh1bmJGbStDUkVYc3NiUW56?= =?utf-8?B?QUxleVd0UkZuc29tcXArbjVLZjZYL2lLN01iZFJFdjQzY2E1K2Q5bGkvNW0r?= =?utf-8?B?UWFRMlRjODV3MU5MOVU0SnEyWkRDMER0SDM4ZUJXM3gweHh6cVlTUGhTZ1FV?= =?utf-8?B?SG5PSEdKS1ZuZmM1L3NRTFJVNE5PczhneXovQ2hCODFkcXd0QnlxSXFLTFox?= =?utf-8?B?YzVReEo4NkgxbmRLMEo1d1pnQkpuNzdpNzZjUHRZai9rN2NCcDVVRy94Skh0?= =?utf-8?B?eHhFMFBxVFM5ZVM5N1Nod0xTUHVWWmZaK1VuUnB4SmRENDRaSUt0bWFXZlkv?= =?utf-8?B?WEJYRUlHZkdjbFVSNGRsVXh3NDVsMmlOZW55MkF0d2huemxmOVVJaEZNYUdy?= =?utf-8?Q?fq3hL6PctvPCZbRYgJIcLQP2D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 7liFHl3ShKQBMIsLVI1kbvat51Na8f4+l9mWHbN226SG4sLia7DHwNsgCs+xSuPn6dETf1PwYdUp8artuNHDIs5eVtNnV5I8G2w1MiKeOgMhw89tOPs5R6R8gnXZXZcDGBVTSvZEpxln8exHAkuDTpKXSmYAuozXcNdb36BDXV8L/ks6kFCAx/VzkeUARckgAciuxC51E3/2eSdQW5udzJJi/vzi3ANKgGxEyt+rV88w7uyqgHUtaMvI4tfnWivKlz/sBKIWGZRKmEyB+vg50m+V5ZONK/AOQzwAOihocBl40mW+QTVVtf3hp20B3+LKxXZtveIytH6EQQDPX011qx04VdX8WxaPkhuFZR7v/LtEu/GpgDu3h8jAIxdkG0sYrPK4g4EmGZC9B+YPdaqM01Wfk2zwi9QMc5HcbobKSSZc2Lz8Hsrm/YeDScweS7kdOUAG2OkTtZQmQcMEtnm6cAx+QqvaWzIgL6qLiGOmVQ2fQr2xlo8H+QUKiHXgi1za9ZvL6T12fH0YVtKwpJPStd/9JtS0x0aeaKlXSvlxQnRCo6nQ/XTRee/OSPnjbJ2b8sTugit+K4lqFDm35rDdUMOfv8LSS5fL7TjKUJEmF7Ksu85zuDqffyaPUJT4wVe7EbutoAitsjE6z5sNLJEmiySWOGD6jbxvU3gaIiLEOYcOQY/fvgPUQZ0CDD4wGVj9A8Eor0utA5QSn5D89rvJzyvvro/aiXqLLTEKBW5KV30Vez03F41JbNbn1w/AkbF4ykx9gmZoOd5xpCUtCQvzwmEndt7ov6LcYafHKgBs2WJ86hlptZ8R8cgjNrCC5N64rmP9daxf0jg32igSio01p77vzlYyyDVvl13giWLsYSQ= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5488ad63-6d53-43bb-04d1-08dac72566aa X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2022 16:21:07.6326 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XbWfNz1E756ZaBQvATwx69bfXJzz9wkPWbY+3oAS9ozcrF3XZG5miUPMqHgUT5NFGP5nnHG8MPrg3lCNc6UVcf9uBzVE/PNTsLqk1N5+uI0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6990 T24gMTUvMTEvMjAyMiAxMzoyNiwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBTaW5jZSB0aGUg VklSVF9TUEVDX0NUUkwuU1NCRCBzZWxlY3Rpb24gaXMgbm8gbG9uZ2VyIGNvbnRleHQgc3dpdGNo ZWQNCj4gb24gdm17ZW50cnksZXhpdH0gdGhlcmUncyBubyBuZWVkIHRvIHVzZSBhIHN5bnRoZXRp YyBmZWF0dXJlIGJpdCBmb3INCj4gaXQgYW55bW9yZS4NCj4NCj4gUmVtb3ZlIHRoZSBiaXQgYW5k IGluc3RlYWQgdXNlIGEgZ2xvYmFsIHZhcmlhYmxlLg0KPg0KPiBObyBmdW5jdGlvbmFsIGNoYW5n ZSBpbnRlbmRlZC4NCj4NCj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIu cGF1QGNpdHJpeC5jb20+DQo+IFJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+DQo+IFJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNv bT4NCg0KVGhpcyBpcyBkZWZpbml0ZWx5IG5vdCBhcHByb3ByaWF0ZSBmb3IgNC4xNywgYnV0IGl0 J3MgYSBwZXJmb3JtYW5jZQ0KcmVncmVzc2lvbiBpbiBnZW5lcmFsLCBoZW5jZSBteSBmaXJtIGFu ZCByZXBlYXRlZCBvYmplY3Rpb24gdG8gdGhpcw0Kc3R5bGUgb2YgcGF0Y2guDQoNCkdlbmVyYWwg c3ludGhldGljIGJpdHMgaGF2ZSBleGlzdGVkIGZvciBzZXZlcmFsIGRlY2FkZXMgbG9uZ2VyIHRo YW4NCmFsdGVybmF0aXZlcy7CoCBJdCBoYXMgbmV2ZXIgZXZlciBiZWVuIGEgcnVsZSwgb3IgZXZl biBhIHJlY29tbWVuZGF0aW9uLA0KdG8gYWdncmVzc2l2ZWx5IHB1cmdlIHRoZSBub24tYWx0ZXJu YXRpdmUgYml0cywgYmVjYXVzZSBpdCdzIGEgcHJvdmFibHkNCmJhZCB0aGluZyB0byBkby4NCg0K DQpZb3UgYXJlIGF0dGVtcHRpbmcgYSBtaWNyby1vcHRpbWlzYXRpb24sIHRoYXQgd29uJ3QgcHJv ZHVjZSBhbnkNCmltcHJvdmVtZW50IGF0IGFsbCBpbiBjZW50dXJpZXMsIHdoaWxlLi4uDQoNCj4g ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9jcHUvYW1kLmMgYi94ZW4vYXJjaC94ODYvY3B1L2Ft ZC5jDQo+IGluZGV4IGEzMzIwODc2MDQuLjllM2I5MDk0ZDMgMTAwNjQ0DQo+IC0tLSBhL3hlbi9h cmNoL3g4Ni9jcHUvYW1kLmMNCj4gKysrIGIveGVuL2FyY2gveDg2L2NwdS9hbWQuYw0KPiBAQCAt NDksNiArNDksNyBAQCBib29sZWFuX3BhcmFtKCJhbGxvd191bnNhZmUiLCBvcHRfYWxsb3dfdW5z YWZlKTsNCj4gIC8qIFNpZ25hbCB3aGV0aGVyIHRoZSBBQ1BJIEMxRSBxdWlyayBpcyByZXF1aXJl ZC4gKi8NCj4gIGJvb2wgX19yZWFkX21vc3RseSBhbWRfYWNwaV9jMWVfcXVpcms7DQo+ICBib29s IF9fcm9fYWZ0ZXJfaW5pdCBhbWRfbGVnYWN5X3NzYmQ7DQo+ICtib29sIF9fcm9fYWZ0ZXJfaW5p dCBhbWRfdmlydF9zcGVjX2N0cmw7DQoNCi4uLiBhY3R1YWxseSBleHBlbmRpbmcgLnJvZGF0YSB3 aXRoIHNvbWV0aGluZyA4IHRpbWVzIGxlc3MgZWZmaWNpZW50bHkNCnBhY2tlZCwgYW5kIC4uLg0K DQo+ICANCj4gIHN0YXRpYyBpbmxpbmUgaW50IHJkbXNyX2FtZF9zYWZlKHVuc2lnbmVkIGludCBt c3IsIHVuc2lnbmVkIGludCAqbG8sDQo+ICAJCQkJIHVuc2lnbmVkIGludCAqaGkpDQo+IGRpZmYg LS1naXQgYS94ZW4vYXJjaC94ODYvY3B1aWQuYyBiL3hlbi9hcmNoL3g4Ni9jcHVpZC5jDQo+IGlu ZGV4IDgyMmY5YWNlMTAuLmFjYzJmNjA2Y2UgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9j cHVpZC5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9jcHVpZC5jDQo+IEBAIC0zLDYgKzMsNyBAQA0K PiAgI2luY2x1ZGUgPHhlbi9wYXJhbS5oPg0KPiAgI2luY2x1ZGUgPHhlbi9zY2hlZC5oPg0KPiAg I2luY2x1ZGUgPHhlbi9ub3NwZWMuaD4NCj4gKyNpbmNsdWRlIDxhc20vYW1kLmg+DQoNCi4uLiAo U3BlY2lmaWMgdG8gdGhpcyBpbnN0YW5jZSkgbWFraW5nIGxpZmUgaGFyZGVyIGZvciB0aGUgcGVv cGxlIHRyeWluZw0KdG8gbWFrZSBDT05GSUdfQU1EIHdvcmssIGFuZCAuLi4NCg0KPiBkaWZmIC0t Z2l0IGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jIGIveGVuL2FyY2gveDg2L3NwZWNfY3RybC5j DQo+IGluZGV4IDRlNTMwNTY2MjQuLjBiOTRhZjZiODYgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNo L3g4Ni9zcGVjX2N0cmwuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMNCj4gQEAg LTUxNCwxMiArNTE0LDEyIEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwcmludF9kZXRhaWxzKGVudW0g aW5kX3RodW5rIHRodW5rLCB1aW50NjRfdCBjYXBzKQ0KPiAgICAgICAgICAgICAoYm9vdF9jcHVf aGFzKFg4Nl9GRUFUVVJFX1NDX01TUl9IVk0pIHx8DQo+ICAgICAgICAgICAgICBib290X2NwdV9o YXMoWDg2X0ZFQVRVUkVfU0NfUlNCX0hWTSkgfHwNCj4gICAgICAgICAgICAgIGJvb3RfY3B1X2hh cyhYODZfRkVBVFVSRV9JQlBCX0VOVFJZX0hWTSkgfHwNCj4gLSAgICAgICAgICAgIGJvb3RfY3B1 X2hhcyhYODZfRkVBVFVSRV9WSVJUX1NDX01TUl9IVk0pIHx8DQo+ICsgICAgICAgICAgICBhbWRf dmlydF9zcGVjX2N0cmwgfHwNCg0KLi4uIGJyZWFraW5nIGFwYXJ0IGEgc2luZ2xlIFRFU1QgaW5z dHJ1Y3Rpb24sIHdoaWNoIG5vdCBvbmx5IGFkZHMgYW4NCmV4dHJhIGNvbmRpdGlvbmFsIG1lcmdl LCBidXQgbm93IGhpdHMgYW4gY29sZC1pc2ggY2FjaGUgbGluZSBldmVyeXdoZXJlDQppdCdzIHVz ZWQuDQoNCkNvdW50IGhvdyBtYW55IHN5bnRoZXRpYyBmZWF0dXJlIGJpdHMgaXQgd2lsbCBhY3R1 YWxseSB0YWtlIHRvIGNoYW5nZQ0KdGhlIHBlci1jcHUgZGF0YSBzaXplLCBhbmQgcmVhbGlzZSB0 aGF0LCB3aGVuIGl0IHdpbGwgdGFrZSBtb3JlIHRoYW4gMjAwDQp5ZWFycyBhdCB0aGUgY3VycmVu dCByYXRlIG9mIGFjY3VtdWxhdGlvbiwgYW55IGJlbGlldmUgdGhhdCB0aGlzIGlzIGFuDQppbXBy b3ZlbWVudCB0byBiZSBoYWQgZGlzYXBwZWFycy4NCg0KWWVzLCBpdCBpcyBvbmx5IGEgbWljcm8g cmVncmVzc2lvbiwgYnV0IHlvdSBuZWVkIGEgZmFyIGJldHRlcg0KanVzdGlmaWNhdGlvbiB0aGFu ICJ0aGVyZSBpcyBhIGdhaW4gb2YgNjQgYnl0ZXMgcGVyIENQVSB3aGljaCB3aWxsIGJlDQpub24t dGhlb3JldGljYWwgaW4gbW9yZSB0aGFuIDIwMCB5ZWFycyIgd2hlbiB0cmFkZWQgb2ZmIHZzIHRo ZSBhY3R1YWwNCjUxMiBieXRlcywgcGx1cyBleHRyYSBjb2RlIGJsb2F0IGJsb2F0LCBwbHVzIHJl ZHVjZWQgbG9jYWxpdHkgb2YgZGF0YQ0KdGhhdCB0aGlzICJpbXByb3ZlbWVudCIgZ2VudWluZWx5 IGNvc3RzIHRvZGF5Lg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 15 16:30:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 16:30:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444021.698791 (Exim 4.92) (envelope-from ) id 1ouyot-0000H1-DJ; Tue, 15 Nov 2022 16:29:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444021.698791; Tue, 15 Nov 2022 16:29:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouyot-0000Gu-9N; Tue, 15 Nov 2022 16:29:55 +0000 Received: by outflank-mailman (input) for mailman id 444021; Tue, 15 Nov 2022 16:29:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouyor-0000Gn-WF for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 16:29:54 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0621.outbound.protection.outlook.com [2a01:111:f400:fe0c::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bb0a8fa0-6502-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 17:29:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7894.eurprd04.prod.outlook.com (2603:10a6:20b:2aa::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Tue, 15 Nov 2022 16:29:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Tue, 15 Nov 2022 16:29:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb0a8fa0-6502-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UcxJuAIIMay5GurIqjnROmYhKTusSZ6lLTffaZJGOuUFnaAZYO4zjD1Yo1QiUkHn2bvynDd0czgg0RivmzlyWunxm3Cb0c/PoQutHlYz8uh2NaJordWPUyvyjWwhqIHZHtdV4xTyb9McGU08SKQwu/zHsF2/AZzzlBGvEwff3GYUW/65Z7uSThIzuL5Udue5HxFrJbj1jRG9ovaX2NIDDsOQaJF4TteW/ktyA2BDvWiPg7SFJ4IfKFvfZmAJDpz/EyEjPtJifR7XbxYhUduNsM4/zJjlTLLHZNHaFx1B/0oFATE1HHy1DE+8S2B6QbnNZZMVKCY6G9ng0afnAwb3lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d/ToeCBs/ctBpsv5DSunBI+ntKYk3f12ch8LB59ViBs=; b=cX7JuKkGB9KAxagfJ7/PFnI3349NEDOdlgsKhQSZOCM6JP0MDSf0DG6yDr69SjBvWN3bYOmZweqZVSmQtolh5cCsvKohmR/kdo1FJTjfJQ4oTO/QO4NfUd4sSHE5NJpLUsOotWZZIroeMtBb0COP9vo/ptiy/2et+D1xIhEH+jzWOJ8vvYCooK0n4JVhVB/cJTFUSU7wEjg3R33gBnRpZjWEz81dfzT9dyuvedFXORUu/gpIALtXX8iFKo5WpHHoiaWpRLEpVH9KXtupmCPIxeLaNSGzyB+VCu/a8iOtfp2cFP0HE7GIrbNBSsC4a9K6oytCBbLB2fUfeKuJ+Uo3fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d/ToeCBs/ctBpsv5DSunBI+ntKYk3f12ch8LB59ViBs=; b=jYFH4C9CYrokmtpLIcvA3OiRn44MF0svdPV/1FCudRCD86O9oaqt9Nz7cUUmncsHRC9FliItaMnsMsQXYK2aeEqwl/JMzhFffP5Hj2g5AjpRAmW8Wkat/BRySvEDdFKpCyQOK7EeLNkrB0fX1ogB13SBMlawOZWe+zumJXzHWhjrJCGSAJe3AZiybrmvcEsJNFjGWHOFcEFfD3cOURa3yh7uvXYqQjJMhX9vtOkLjKqw0ethWsiDxtEVZAHbmLfL5qpemezRo2fhfybL9oY3b3F3Zi05KpnpS8M8hFJEGGk8hFAG6O4lV/x1Y58FnvqANEeP8I7LXPMoHK7YUY6uMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6ba69073-3c58-2791-9572-c5c2e433db07@suse.com> Date: Tue, 15 Nov 2022 17:29:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] x86/irq: do not release irq until all cleanup is done Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20221115123500.97114-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20221115123500.97114-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0171.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7894:EE_ X-MS-Office365-Filtering-Correlation-Id: 741cd933-73c3-4a7d-e6fa-08dac7269d82 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iaGlWdkUn9tJYwsgkntsjrsMCFeSjKiCURdMKuMuVT3YCc+RwdStFraHIur/B65XlunZC2oT+dTZEiz4s6WT1kB9Ok79jvb8pDlEyioNoX85bvnPgJPjLA2bto/YNAg1ExQSi7qz8v8SEkl+rORkML+Y/cooL35sfEZajl2It0Sh4tEDyJWfDWqlLTKWrNUICkltI05JjGcUB+oa+lqCowNWNti0NrjxbpNxOMPWHRBeHxI8OZHgmSI60H/UKIvUtAM2SNKz3sdYMCiji1JiKtPk7xW1Q0oUa5Ri9kd9b84+F0lVOm2pQBcOSCo/NGBM8aIxb8DtNEsrkVyZyvXF34jxorCdGpD0/iAf8vZ/uQHfoTCd/l19AvuEIxDeelBnKtRy7pJVWTiuhVsVkgCx5bQN8wCXL7NB5zL6bQD7RyBRlI7BIihl4zDAcYCe+V60BZOXMGDfpwSgmyCF4MUPqgVHjY2Spn/W9fuELLbzVUPzajVWBEwu6do1/PdMXokWCC6CYz6+Qm9YuBKCkBFvNVTqr4W8+VJtZW+8L+eF3Sbtk1v50nMcGKCfQKjGzIAWEqb1mBuIbFKJGRWBiXEaggqA2N6LOIZxbz/Ujrfr5cRhVYWdjKRY5Ii/eEzMTiXBDS4xPNZQLN68XzfKvNxvtUP8lSUs3qH8u8u5b/9uJMaYHly8QRV8tJiQBLwT8SxSy7x/f4tSdJld/zoSGILL3R5IWd73YeImJ6E7EiE47kDg2CHLcfM4moeGTUZXnIJR7nArxRrc/VzZQLoCqHLEtxp8uhC5rPdZS4E2CfvLKYc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(346002)(136003)(39860400002)(366004)(451199015)(8676002)(316002)(41300700001)(31686004)(6916009)(66476007)(4326008)(38100700002)(66946007)(54906003)(66556008)(36756003)(2906002)(26005)(186003)(31696002)(478600001)(5660300002)(2616005)(53546011)(6512007)(6506007)(6486002)(86362001)(83380400001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0J3QWpOTXc2eEg1S0lIZkkrMEtkUjlRMEVibGRzUkIyK0lCcldkdFRYd0xk?= =?utf-8?B?cnVleEE1Z21NcUwzZ29Sc0ZzNWZkNzdaTktJQTkyMzJwOHNVamxheHArdXd2?= =?utf-8?B?QVp1aWUvVGVNYWx3c2pZTEVJZmxHMmVjRUJGSmNQRmtzM2dqZFR6V2VDT3dP?= =?utf-8?B?TCs2c0NJVzg3VHQxNU12VDVhV25DNjhRUVd0bDM3S2VwTUVuWDVuR3UxQW9J?= =?utf-8?B?U1h4dEw2aHdEMHNUa1RuVkpOY2pMOEN3RVg4ZFdGU05vTzhLYlBSU0NPU2pX?= =?utf-8?B?VTJldXlwQU1YUjUzcHp5UlV0WEtpUWR1elplNnAxdVppSW9telpZdXd6d2xL?= =?utf-8?B?YTRYSmUrYXZSdjkycXhBUFZZZXdHWHp1Q2VCUG9QbXdkRURBOE5pTGE4Z3pa?= =?utf-8?B?R3dsT3YxYmljMG9BcGsyMTZzY2RHTnFlQjRXZlgrUkFnSXVlc25idWs2T0tv?= =?utf-8?B?Q0lMTCtnMFpobHUvQnNWdk95MnhsZWd6czkzZXFIbERmcEpQREtYMTMxSHBW?= =?utf-8?B?TTNCRUM1Q0xKV3E0bml0NVNLRVUxZFQ0dXU5cVJDaGxRVkhKeE0wellhRFhR?= =?utf-8?B?MjJ0eThuT01oK2xycG82bmswWUpSZmZTY05xTXVxK1Y0R0V4UVYrNWVXeE9S?= =?utf-8?B?cW9veHg1NmhOUFRZcTMrSExCb2tVa2VRbU05RzdGVVlSUEtaTXZFblNveU5t?= =?utf-8?B?MU5VNnpQWitCVHNDZlRSWFpwcU1rNFhheGhYYm1HbWE5ZUpXUkdCRXNmYUxN?= =?utf-8?B?ZDQwMzMwcG5Da1N6N0hvMUFSZFZybXM3eEh5NE9yeENCT1F5YkpMWWJVMkdP?= =?utf-8?B?bjlyODhiV2xlMUpaME1tdy80VHU2V0x1V0VaNzlmQjNhajhYQVMrR1c2TU8y?= =?utf-8?B?VDh6eTZVVlQ0VXppU0wyVW1raDh4S2RUNEZvVGMxbmZSWjFROHp1TmhDQ3Fa?= =?utf-8?B?d0E2MU5sWVpBVzJBaUM1ak1VRk9pZEkxQ3dqT2czMGNmaGlEZWxRUkNqTDJ0?= =?utf-8?B?STNZM1lQR01PcjdCNmRudG1Va2JBVkkrblJNUGNVWE50Ry9GNnJ2UEJsbVRT?= =?utf-8?B?VXBtTlA2ZlFORXpjMVdMQnhKeW8ra1U5VjZXTkp1U3BFMGprbUliNkZoZXhu?= =?utf-8?B?TmZIbzIwUHpSYXI1cEVzbkk3Y2N1Wm53bVhubGU5am1TenY4bEJPVUVaMVpy?= =?utf-8?B?b2lyeHF3eFhNcEl5bWQ2cWp2TnJuRkhlRDY4UllNeWtuRnpQYjBDZG9SaTBn?= =?utf-8?B?akNkVDFKcEdYZFE3aGRKUWlQMUJ3ak5MOTNLZlBYaUIweWprcGVwVkkyNlpy?= =?utf-8?B?OWgreWl5RnhOa0tOQVpKWm42Qk1Gc2xZT0I3dGluS05vZTJ2K1dsZks1S3h4?= =?utf-8?B?WGJHYXliUmFMUmZKL3Fsem9VYXlIaURPQUlNVS9lT1Y4NXBHTDBXUXNEN21y?= =?utf-8?B?Q1JSNVFPbkJKbXJjcm5NdVcvVzBKamN5ZTNoa2R2R3BreVRnc2QxS1l0SWEy?= =?utf-8?B?WkQwWEhwbHNZQ3h3Z2ZzZ2IzZ2FsbXZramJ3R01WZitGSzZoSUJNUTU2Yjdr?= =?utf-8?B?cFI3aEZWYlMzTUtKdnZjTU96aHZtSTM5ZGFGN1lUOVNyYWJpYXc2UWV5KzYx?= =?utf-8?B?ZTZidWpWblY1c0dvNFZoZll0RWFxQUhjZlpkTG5sSzlWNUsybUs2MVgvbGhS?= =?utf-8?B?bXV0Z2w5c2d3T1pqQm9XUk9BVUhxZWwxWWNTM0R3KzhZc2tpVDk4a3JpWEY2?= =?utf-8?B?aGFpYy9ZaVZxQ3B5akJDeS80cmNmSXR1ZExWWU1QcmJ4L0dXZDhQcnNvMzMr?= =?utf-8?B?ekpLNW0zM2I5SlJ3NWErYlUxSS9iTlBZOSs2aFppWDdSQVpBa21vS3haSnlL?= =?utf-8?B?NTBoRUswS3ppUEVlQ0hIc2dIZUs1WE0wUDgxQ0dBRWV4NUVicGxRWWJsNVJt?= =?utf-8?B?SVRNY2phZkMydkU2dThPMEFZb1JWRklZc1BWZjJnenVQcEw3SGdLeS9mMmpY?= =?utf-8?B?Tk1jbWo5Z3JuK3o2TUMwUGV2YmRobjJOaEQvVkJXZ0Y4UWovd3BzdWpCbEo1?= =?utf-8?B?T0ZGbU1xWXpCM3J3Zkt1d2s4MGppQXJaeTBmS08zL205SEJxVHZqSjVQRmo3?= =?utf-8?Q?vcQuriLgPf/3gLlirmeIDxcsZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 741cd933-73c3-4a7d-e6fa-08dac7269d82 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 16:29:49.3976 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Bz1sb1+AoHvu51Ugbk6vQMt99kly12gp8h1mqyAA5p/RN0edFnNnQUowUbsy0Zeg2KMkm1uCXbIk8Uet4jmG1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7894 On 15.11.2022 13:35, Roger Pau Monne wrote: > --- a/xen/arch/x86/irq.c > +++ b/xen/arch/x86/irq.c > @@ -220,27 +220,27 @@ static void _clear_irq_vector(struct irq_desc *desc) > clear_bit(vector, desc->arch.used_vectors); > } > > - desc->arch.used = IRQ_UNUSED; > - > - trace_irq_mask(TRC_HW_IRQ_CLEAR_VECTOR, irq, vector, tmp_mask); The use of tmp_mask here was ... > + if ( unlikely(desc->arch.move_in_progress) ) > + { > + /* If we were in motion, also clear desc->arch.old_vector */ > + old_vector = desc->arch.old_vector; > + cpumask_and(tmp_mask, desc->arch.old_cpu_mask, &cpu_online_map); .. before the variable was updated here. Now you move it past this update (to the very end of the function). I wonder whether, to keep things simple in this change, it would be tolerable to leave the trace_irq_mask() invocation where it was, despite cleanup not having completed yet at that point. (The alternative would look to be to act directly on desc->arch.old_cpu_mask in the code you re-indent, leaving tmp_mask alone. I think that ought to be okay since nothing else should access that mask anymore. We could even avoid altering the field, by going from cpumask_and() to a cpu_online() check in the for_each_cpu() body.) > > - if ( likely(!desc->arch.move_in_progress) ) > - return; > + for_each_cpu(cpu, tmp_mask) > + { > + ASSERT(per_cpu(vector_irq, cpu)[old_vector] == irq); > + TRACE_3D(TRC_HW_IRQ_MOVE_FINISH, irq, old_vector, cpu); > + per_cpu(vector_irq, cpu)[old_vector] = ~irq; > + } > > - /* If we were in motion, also clear desc->arch.old_vector */ > - old_vector = desc->arch.old_vector; > - cpumask_and(tmp_mask, desc->arch.old_cpu_mask, &cpu_online_map); > + release_old_vec(desc); > > - for_each_cpu(cpu, tmp_mask) > - { > - ASSERT(per_cpu(vector_irq, cpu)[old_vector] == irq); > - TRACE_3D(TRC_HW_IRQ_MOVE_FINISH, irq, old_vector, cpu); > - per_cpu(vector_irq, cpu)[old_vector] = ~irq; > + desc->arch.move_in_progress = 0; > } > > - release_old_vec(desc); > + write_atomic(&desc->arch.used, IRQ_UNUSED); Now that there is an ordering requirement between these last two writes, I think you want to add smp_wmb() after the first one (still inside the inner scope). write_atomic() is only a volatile asm() (which the compiler may move under certain conditions) and an access through a volatile pointer (which isn't ordered with non-volatile memory accesses), but it is specifically not a memory barrier. Jan > - desc->arch.move_in_progress = 0; > + trace_irq_mask(TRC_HW_IRQ_CLEAR_VECTOR, irq, vector, tmp_mask); > } > > void __init clear_irq_vector(int irq) From xen-devel-bounces@lists.xenproject.org Tue Nov 15 16:45:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 16:45:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444025.698802 (Exim 4.92) (envelope-from ) id 1ouz3V-0002rL-N2; Tue, 15 Nov 2022 16:45:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444025.698802; Tue, 15 Nov 2022 16:45:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouz3V-0002rE-Jm; Tue, 15 Nov 2022 16:45:01 +0000 Received: by outflank-mailman (input) for mailman id 444025; Tue, 15 Nov 2022 16:45:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouz3U-0002r8-NO for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 16:45:00 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20610.outbound.protection.outlook.com [2a01:111:f400:fe13::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d7a64e82-6504-11ed-91b6-6bf2151ebd3b; Tue, 15 Nov 2022 17:44:59 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9219.eurprd04.prod.outlook.com (2603:10a6:102:222::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Tue, 15 Nov 2022 16:44:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Tue, 15 Nov 2022 16:44:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7a64e82-6504-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JO/O6lZlrfuDjIAm5UZSjvKP30SSgEi2Vw8xF1B3RmJSCv/p5/ll+ZYTJ8nyzg6hClwQ6R37choEjHQlRgNZHv1SAiyIv+7KTDkoUuALOEdeH4Xys918xY96nyZEEcuWzQTEWxmfSm4JAC03jxhaLmz431G8VQZnLf7Sn4H2Ql0rKSEXxrAsU/ztDX3Px8mJWS+Wkvd9fhhroHgY+vPp3VbK44jC5A2xjXUMtCmQnIB5ymS2eAhb0xjwPGzMIajvpkcC+tpITe/KrIIWuhx7K6i/EJ17+A2GgpJsR7q9OUtUjUHPWatVd8Slq3qKP0D962BicSRYwYwsJppw9SE6BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wGhslgKI/dGUIazKz+iL2ZtC2TcXPMBaZeUDTEtHdOo=; b=fIUYDZtxVyCcqgWqzNj7xcRcxok54CnLwQov7Cxvb3aLQSXU6iVGV3Y+PeqgaqKkgtGYzjS68Isjv8YmQkSB4bE1fiHKylYMTs/nrF/oB8FosIaHw19NELSZWPcVflb4wSGUaTF6GVnDU+N4PHAfsO508P/oEfnC/IJX85mwNNQvPdFYZcTOLpTXDtdi4IvnWw9j0ehMbQq0D3gS7fErzZHCUi/Vq1ZJJMTJkguiqaNc/dGDiEnwNO+c4h/0YgBKjmYEC3Z647GlXM97TG4KQXobpubiPLNPcuEC6KYboKR4/etituhxh0ypyTMamVrtt1gErkZFdazbjG/9sONgAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wGhslgKI/dGUIazKz+iL2ZtC2TcXPMBaZeUDTEtHdOo=; b=iLcFmFFOfCVlYE7h2K5LjdaF0QkZmo22i1vrLmCQaxDfq9hO/sZQTH0rIsV2RFsGxO1IIdxJfHJ9MqvjEDeb347ug2JfuM/ihNuAaRX4Rzya1SzLkc5aHMJO8K7pJkteH8NnHvcTT6yQBxKOj6pgn/TfrevBL0EYChhoQM9l64FnkaHqY/08sv6UffBNapmy10Z7kUdBSZl4Zshfg82VD4+uGLg4mJ8RC9eK9Jre3CDhcUQS7VMkyDpiIi2YQh+BtWpdKFqM+/SKEpCHkcoOAy32bKjMH0n6+gj9Gq3ljWrgpJwymohe/O2uCpyINv9/Bo0+5TpxHPRv7WY6D22iOA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5caf3930-ea8f-6e68-326f-93cca1fa210a@suse.com> Date: Tue, 15 Nov 2022 17:44:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH for-4.17 v4 2/2] amd: remove VIRT_SC_MSR_HVM synthetic feature Content-Language: en-US To: Andrew Cooper Cc: "Henry.Wang@arm.com" , Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <20221115132657.97864-1-roger.pau@citrix.com> <20221115132657.97864-3-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0114.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9219:EE_ X-MS-Office365-Filtering-Correlation-Id: b4ee4748-4d4a-4ae4-2de1-08dac728bb1b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j9vBlSaymn2GPpdN/ss6RvNg6gEmnU2Bpkmplj9NZysMZ+Rw/aVUDBmp0coWQuu+JZvPF5DjhJJVV4cp4C4LywNFdoe/33GZwCRUAp1Oljb0xF6CUgqDraT/ItZFgm5T2OyGzm5zMCnh/PNeYguo5gLjzEtnmd2+OOG0qvrBt71vyePwWi25n5D+EyBK4w1mBCvRyN11vmU6i1sQg/auE2IS2bv90sclHlSak35WSCEh6hMaqx7+cFqSGjrgcX2eEhJdwbSo9ECPpmdx5Kn31BItV9PmK+R/b9Y7aMCyifpKFqt74HyuggiA43PxuvzAnytTPCowxe4d/spmDJ94wwlDaq3B06+AQ0FUwkArJbZRSLmAkvIEqnvksWLKPcfCUk1KE6wF/goQp8dOIvcUyfFh7PaaReKUiINJWmgS59silCeO0vrqPqswPOBxkXWx97AM3gmPwSkeGgD19zfi1D34nkuEaJKNCfeewveLSM5t16rlgHdKEsZyEOVB026bvFYgay8W3zIWcThYD9AsO1UxdtYquUS+Z45v5nbGH6MYc2na5onu2Btw64BaFB/0Po7XSOfnkiGOMLWxQDzi+NaKXf5KPGXV/SpC3N16ZeXdvkFBIB158k1w+2pt38Dm8krWTM4NSI/5JPZvhWH2H8Y0/R3mR6qHcTLY7E3tlm80YuBrup+1hZWLhlGFU5AQZr4el4YKH+Rjo0g84UXUsmgtKpQUOsfcR05rfx5tU7TXy/Z8Rflx343AuMtYU7jPLR2lvo9wlFdf47VA2cJMSN88TH8ZuRM0lLQ9UN6pmPc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(396003)(376002)(39860400002)(136003)(451199015)(6506007)(2616005)(6512007)(186003)(26005)(53546011)(38100700002)(2906002)(5660300002)(54906003)(6486002)(66476007)(41300700001)(316002)(478600001)(8936002)(4326008)(8676002)(66946007)(6916009)(66556008)(36756003)(31696002)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzgveEVQSVFEcjFwYlBwdWl1OERvWVJERkpKVHRpZFUyNGtna0grVTBpTHBP?= =?utf-8?B?TnRDYkRlUE84Y1hXRmlOQzEweU9ZSi9odU9Eb1U2OWNXb2pFRDZmekp1Q3l0?= =?utf-8?B?WFl5b2ZaTXo0eEwwYjVlRlQ4UUNtVVlSZmRHa3pvcTJrOXpRcW1DeFpsZWRh?= =?utf-8?B?WllHZUNyNFFzekE2ampkOThtaGdFTTZYdjdoYjRxcnBaUUZJZnE4ak43UEIr?= =?utf-8?B?T1RWVE1qVnVJanVrYkFYRXpKaXptSGgrRUhQcG5zU3BZRU9palZGQWJZYWtH?= =?utf-8?B?U1NLZTN1ay9nZ1RPWVJLbllGV0RUOWVsV2tPU1lrL3piRnhWMC9MWWsxUXdz?= =?utf-8?B?Y2crRndWUm42TEEwNE5VUFF1Z2ticXpGYnlQdUFoRXR6TS9pbHZWRjJnbmdW?= =?utf-8?B?eVRDL0QraEdtR1FCZjc0WjdNV01mS0dpRUVsWjdpTy9vMGh1VFdWRkZXY0ZK?= =?utf-8?B?VDQxU1UxaEtCQTZJNWpUZTEvNGVLZVUvcW1GRi9xRG42enR6YVJvakhVd0xq?= =?utf-8?B?Mk43ekw4YUZkS1FDUG9Oa1FaSnFQam9tbHhVQy9rOHR0ZTlqZ0x4UStBZ3Iy?= =?utf-8?B?aitnc2V4aWV2QU9GaUxxS2laUHFCUVAvZ0pJLzlrZUZIaHhzSjBkM2ZKbmJv?= =?utf-8?B?TlpFbWtXSHo3SmF1dGxJaXJSd0VoTFhZMWlPWm9Nc1BFajd2b0NlTGh2NXlT?= =?utf-8?B?bVBiK3FtZk9IZXlaeERNbGlKUEFaaEJyTTBtajZuaEE4cnhMRDFPK1krRDNS?= =?utf-8?B?eWo2MkNMc3E3Y3N5dE5GRFRQdjdpTEV2L2xWaFg4L1VJeDJTUjZtNnVGZ2Fa?= =?utf-8?B?VWR3VTk3RlFVWUZaQys5cW5uQml4cFdocklocjZ0UE5yM2ZwZDNVaHFBWVdR?= =?utf-8?B?aG1mZXRhNmJkV2tLK3R5cDBVZzdhL3NoQzhKcndYbXZlSUlVRzhleGtoSysv?= =?utf-8?B?VFhOQ01iWVZncHhhb2JMUmk5aDlSZkFOU0owVUdRZmlWM0RBRW85OXNpL1dw?= =?utf-8?B?UEtJQnUzeEFQQ0tnSW9TdDRCRU1kbXRSYkZnWTZhZy84LzZEbXozS0ltS1Ra?= =?utf-8?B?WEJVSWZrb3BnZWRNR1o0cVlhdEQ0VHg0d0EzeVVXSHBqMno2cHo3andGbFdF?= =?utf-8?B?NmdlcjM4ZXNDZGE5S0JXZFNlbHdZVXFzKytxazE2YmdmMDRkK1N4aHVxVDFI?= =?utf-8?B?c2NOYXk2NlFaaGpLbTMzdnVrVHJFYW44SEhTd2k0MkFxQjdENEViUDdMQ3VL?= =?utf-8?B?SE1WWk1UYlpMN2N0WDZCbkJFNEFlVlNFcmdCdFhjT0dnOXNubU9ua1A2ZVJr?= =?utf-8?B?LzNDQWp1Tnc0VFBkZmpmcVZzTmNBcFhtQ1NKbUs4S09DWXlZQ1Y4NzhyWXpU?= =?utf-8?B?K1o4WnZrUUxVYVQ0c1ZUUnd0ZXVDTFo2Q3lGa1ViR0gyT1lOcFU4TzkyelpH?= =?utf-8?B?MGtVcEVqTms5czROdERYczNnWmRXd24zZk4rR2J4NGdXbzR3eUo3UHFwWWVt?= =?utf-8?B?QlZXc0lpKzB2dmJPWTM3NXVQQzl4SGhQSUsyZ2dnQlducXNmeTNKd01yYk0r?= =?utf-8?B?dC85dG11YVlISFBIYVFVSXZZNXNQMzRNMHFjVit6Qi9DYUpxQ3JUMVRWN21V?= =?utf-8?B?dXJscWo5bHRJWVFwMW1zamhMM1lGbURUU0JYS0NVc21sSUtzN2pvTERnTjA3?= =?utf-8?B?Sks5b1VNWExGSnNrUVd0b0ZneUhtZUM2VmtXM3hjem5EM1JUUnJ1TW0vclA0?= =?utf-8?B?YldRa3p6aCtKcTBoZ21PeGJUbzBzN2pZcVpac1h5RFdDd0ltQ1hOa05XZHhC?= =?utf-8?B?SUxoT0EzR0FYcFYyeE9ybDc5OE9hVVRVb0VTWVhXa3owUTh2ak5RUzRVUnJV?= =?utf-8?B?ME52R0ZlRFNFZ2Ryd3RHQVpnbFQzWHJQR0ZkcU1lc3N3T1pIY2Q4NUs2Rkxm?= =?utf-8?B?cll2QTNYUDBPd3V6TDhub0JMUTdnOUdjdFFEUisxVFNLeis4ODVhMkQ0R1ox?= =?utf-8?B?aUZjNlFUcDVqelgzZXI2RU9CdHJHM05xZmo2R0FTTDZUeDVpWnBzc001TVV1?= =?utf-8?B?Mi9PZy95bDZ4OXRkY0hPUSt6c3c0UnVnQ0ZGWVRIL21UOVpzME5OTWkvbjlF?= =?utf-8?Q?YsjUpEnpzrBZEEffZaw9m+EFe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4ee4748-4d4a-4ae4-2de1-08dac728bb1b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 16:44:57.9180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uV0zJUzEHrMOh4exFPQSvswR7rwKfPmnpvkR9OE1RLdCqjv2n4HXOzh0ggyWNkJVqPpwCwEfDpA6RHh//aFZCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9219 On 15.11.2022 17:21, Andrew Cooper wrote: > On 15/11/2022 13:26, Roger Pau Monne wrote: >> Since the VIRT_SPEC_CTRL.SSBD selection is no longer context switched >> on vm{entry,exit} there's no need to use a synthetic feature bit for >> it anymore. >> >> Remove the bit and instead use a global variable. >> >> No functional change intended. >> >> Signed-off-by: Roger Pau Monné >> Reviewed-by: Jan Beulich >> Release-acked-by: Henry Wang > > This is definitely not appropriate for 4.17, but it's a performance > regression in general, hence my firm and repeated objection to this > style of patch. > > General synthetic bits have existed for several decades longer than > alternatives.  It has never ever been a rule, or even a recommendation, > to aggressively purge the non-alternative bits, because it's a provably > bad thing to do. There we are again - you state something as bad without really saying why it is bad. My view is that synthetic bits were wrong to introduce when they don't stand a chance of being used in an alternative. I agree though that there's no strong need for this to make 4.17. It may end up making backports slightly easier, as no such bit existed in 4.16. > You are attempting a micro-optimisation, that won't produce any > improvement at all in centuries, while... > >> diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c >> index a332087604..9e3b9094d3 100644 >> --- a/xen/arch/x86/cpu/amd.c >> +++ b/xen/arch/x86/cpu/amd.c >> @@ -49,6 +49,7 @@ boolean_param("allow_unsafe", opt_allow_unsafe); >> /* Signal whether the ACPI C1E quirk is required. */ >> bool __read_mostly amd_acpi_c1e_quirk; >> bool __ro_after_init amd_legacy_ssbd; >> +bool __ro_after_init amd_virt_spec_ctrl; > > ... actually expending .rodata with something 8 times less efficiently > packed, and ... ... as long as you're talking of just a single CPU. The break-even is at 8 CPUs (8 bits used either way). >> --- a/xen/arch/x86/spec_ctrl.c >> +++ b/xen/arch/x86/spec_ctrl.c >> @@ -514,12 +514,12 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps) >> (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) || >> boot_cpu_has(X86_FEATURE_SC_RSB_HVM) || >> boot_cpu_has(X86_FEATURE_IBPB_ENTRY_HVM) || >> - boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) || >> + amd_virt_spec_ctrl || > > ... breaking apart a single TEST instruction, which not only adds an > extra conditional merge, but now hits an cold-ish cache line everywhere > it's used. > > Count how many synthetic feature bits it will actually take to change > the per-cpu data size, and realise that, when it will take more than 200 > years at the current rate of accumulation, any believe that this is an > improvement to be had disappears. > > Yes, it is only a micro regression, but you need a far better > justification than "there is a gain of 64 bytes per CPU which will be > non-theoretical in more than 200 years" when traded off vs the actual > 512 bytes, plus extra code bloat bloat, plus reduced locality of data > that this "improvement" genuinely costs today. I don't see Roger stating anything like this. I think we need to settle on at least halfway firm rules on when to use synthetic feature bits and when to use plain global booleans. Without that the tastes of the three of us are going to collide again every once in a while. Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 15 16:50:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 16:50:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444029.698813 (Exim 4.92) (envelope-from ) id 1ouz8l-0004QT-CF; Tue, 15 Nov 2022 16:50:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444029.698813; Tue, 15 Nov 2022 16:50:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouz8l-0004QM-7V; Tue, 15 Nov 2022 16:50:27 +0000 Received: by outflank-mailman (input) for mailman id 444029; Tue, 15 Nov 2022 16:50:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouz8k-0004QG-1F for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 16:50:26 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 982e225c-6505-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 17:50:23 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Nov 2022 11:50:13 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM6PR03MB5002.namprd03.prod.outlook.com (2603:10b6:5:1e8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Tue, 15 Nov 2022 16:50:09 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Tue, 15 Nov 2022 16:50:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 982e225c-6505-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668531024; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Z1ZprQ0FXh3OOGjxzpitGDNCt53FGhHo0sxU3IEOM6k=; b=eMc79v1niwGI9V5X12fBIGKn4t2zuaYl6r7dv5vhii6WkfW1L/bo0uOI w/oJI8Dp6khNug4BKPrti7tGvf6tWuyFEgljS2W2Iwc7ES5pJL/MqIsVh gE8Co+3zuEl55mRoDvu6eQWemgTKi4rpF7DrRnMM1opYQALwsKWMJIoSH U=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 83938697 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4JHRTaM/AxFo7L3vrR2WlsFynXyQoLVcMsEvi/4bfWQNrUok3mNTy 2EaDTuAPviJNmTzKY1zPoWxph8A6MSEm9RrGQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5wFmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rxlXF9wy MEeFBdOMReSpNKW4e2Ca9A506zPLOGzVG8ekldJ6GiASNwAEdXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PpxujaCpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+toin93b+RzHyTtIQ6FJekyq54sUOo9GERMRlIa2XiuPSClRvrMz5YA wlOksY0loAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLkgJSCRQLuMvssAeTCYvk FSOmrvBBzZirbmUQnK17aqPoHW5Pi19BXAGTT8JS00C+daLnW0ophfGT9ImGqjliNTwQGj02 2rT8nl4gKgPh8kW0an95UrAnz+nupnOSEgy+xnTWWWmqAh+YeZJerCV1LQS1t4YRK7xc7VLl CJsdxS2hAzWMaywqQ== IronPort-HdrOrdr: A9a23:EfuVp64Mlw6XZQrjrgPXwaiCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A30QaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oK+RSDljSh7Z/9Cly90g0FWz1C7L8++S yd+jaJrJmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjow4OyjhkQGhYaVmQvmnsCouqO+ixV42mJ 3nogsmPe5093TNF1vF6ifF6k3F6nID+nXiwViXjT/KptH4fiszD45kiZhCehXUxkI8tJUkuZ g7l16xht5yN1ftjS7979/HW1VDkVe1m2Mrlao2g2ZEWYUTRbdNpcg0/V9TEr0HACXmgbpXWd VGPYX53rJ7YFmaZ3fWsi1Gx8GtZG06GlO8Tk0LqqWuok1rtUE863Fd6N0Un38G+p54YYJD/f 74PqNhk6wLZtMKbIpmbd1xD/efOyjoe1bhIWiSKVPoGOUsIHTWsaP6570z+aWDZIEI9p0vg5 7MOWko+lLaQ3ieSfFm4ac7sSwkGA6GLHbQI4BlltREU4THNfvW2XbpciFqryOiy89vcPEzFc zDfK6+OMWTXVcGKbw5oTEWZKMiWEX2cPdlzurTCGj+1f7jG8nNitHxVsr1Cf7ELQsEM1mPcU frGgKDafl90g== X-IronPort-AV: E=Sophos;i="5.96,166,1665460800"; d="scan'208";a="83938697" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TDYfdX9K8q5j2U9REtwcCCVA6zqlJCqSYH+YHFeZbGXfANd1WrO8cQr4YdEKNgRk2Dof1o510dkjn3Nxi+pGhuJ6McEuIwNWvMntwYkAGuDIg7EwKHfDh9PhWZdKnU0MO+dt26O+aPNt+iJpM3plwNKIBg/6XIi1L57lS9KIL0u2Yq3DoJjklXCfHP4uAJhGuV7WUTJ6KQgURqW6dVhLBjr8U7OUJNJo5VlDoGzfsh7oa/a9Q5ZjqzSIB820aQXoBnD2uKkkCoX6jj/70CZB4uDc02PKq+1uXf52b14DL0q3adrXEik9Rooaml5+LbQx3a/MLhE8iscqtHK/m2RykA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tPYNm5w9ovo03eANqvdErtCYKxnc9sm041giFK3W+/w=; b=Swe4JlTT2NAhggkvtgTpHVGKMaWGK3tA9m4/kf9VTLCKRykVfpNtdi1OhwARz2GHtGUKx4u82jercCiKuFyGyv6mHSy+NYnJGY/xP/U2rYWUT51iq3UAC6UjKpkz0NvpRck56hDqIOYGA5iIScp/KNG6Yr+BajzUnC3PZ3hcGvQ2h4fPVTR6TCmCePCP64rOc15p8ihrwUxYTUENBJbbx5Yo4vBRTFmMchBcHyQ7fqaNMTUkWc4JitjcBx10nXgCCWqlUDAmddNj9eRXY3KPzJiko6Rc7FUV5fc6LXPapZqGsp4a3JcM6l0N70L7D7gUBngLAAORHubv2dBuc9nAGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tPYNm5w9ovo03eANqvdErtCYKxnc9sm041giFK3W+/w=; b=E/d+/1ivVjBZHYYrm2fvvXY13VHUnzvOmW8zShAzy6Y94BMcVeGdM0JDdlEJXh+EVZlB4wo9yH6Qx18Pz5ktacGdwUaNVe+nA+rzlItmHnoES7eB5qNJuyMY0w60F48iy0gFAk8HCOIyBM7gCEASD1BOy8HEBWGOBWyMXbYJnbI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 15 Nov 2022 17:50:02 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , "Henry.Wang@arm.com" , Jan Beulich , Wei Liu Subject: Re: [PATCH for-4.17 v4 2/2] amd: remove VIRT_SC_MSR_HVM synthetic feature Message-ID: References: <20221115132657.97864-1-roger.pau@citrix.com> <20221115132657.97864-3-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0103.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::19) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB5002:EE_ X-MS-Office365-Filtering-Correlation-Id: 18853936-986e-4962-f392-08dac7297460 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I+T2olSrYsyYw8kYUgn4eexrpugCdn5TvbL8XZ9cWrG6SDRyEQGizHFDtS2UF4rFyDh2ajzElPms9+H23sTPMx2qXLC7Rp/VtvXOXJr6ql77YISUVF06dzHQ1dfxyHQetL8TMR4ooYW84FLToL59vuTWnMmDGvTRe0PvGz7I4C54rBiDML6XVxpZWTzSB+WWqgsYDPeoZwc8+b1KUDZVOzYI1eApnkvewOxk7V7RHJs2seqYc8QuUnIMr5Xw9gElt7aXzlMkxYCq23Tze7exfw+8LAFPlvMFYz52Kq1BbnRf+pViEbqTQth0gmDHPs8p+0KPSgyq+GHZ++QpvvgQ31PXQyYybnfHJOdSVWeBDdlN06S3ZC/F0QWaxhj5MrFSrZfUZbf34mH3SUGbfwQ3nax1fHuln/uB7NUaBwNzrlV+gQPBxfc0QfE0R34KKn62F05m3yA+aUoxtJd8v7KaVbjOCqzfHbVil7PuvHm8p5eCYJ2NL9XMkg7k75BnYTPsotdmsZGskhwYTZFT17kFJforDf3SMBH/toxi/CRwed/pVQj4TE7DmVkeOwG2BN0QAvWjEl4CvoQ7BSjpy7RHKoBmzoK8A8jwg4XKGEn2L+akvBIwa4N9FBVeqhD6zNWlFdX/dyXA1omo3Az9XXTAGTKM4gR2BhBZufX/fzaV1DZix1Iui0qjOIocOLFp+M4NjHnRYyRfGrInuiYUyXpE3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(136003)(376002)(39860400002)(396003)(366004)(346002)(451199015)(6512007)(9686003)(26005)(54906003)(6636002)(66476007)(316002)(66946007)(4326008)(66556008)(85182001)(2906002)(186003)(8676002)(66899015)(86362001)(82960400001)(41300700001)(33716001)(6666004)(6486002)(478600001)(5660300002)(6506007)(83380400001)(38100700002)(8936002)(53546011)(6862004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUtHVWw2eGtuVUdFVFFYMTZSL0hEVDgwMW1malhDR3J2SmUyMU9IbmxjSnBC?= =?utf-8?B?aXVoWEdxVzNnOFRDbmVMVmxRc2dsS2Rud25mR2ZmOE5iUUx3MjY3VENxYTU5?= =?utf-8?B?MXhyVXFyQkg2bmZWMnJrOVBJbm5HM3l6VjBWTXZuOThXdVBZa2tvem5tYUV5?= =?utf-8?B?NUMrb2dYZ3NaZUZLa0czblpqRk1qcExnK3BDc1hXS21iWmFlOEpabFVMMEtS?= =?utf-8?B?WGxySXpnZ3NDRHNzVEZrY2g5OERFMDVndXZHeG1pblJVM2s0WEhWOWh4Njlx?= =?utf-8?B?Q3ZrQzFSazA3czdhTzE0cjhQY05hejRnaENFZGVyZ213dEhUcVhmRFNWOWZ6?= =?utf-8?B?VUE1NE5vOExmS0FZWnhoUERFRGVNb2Jia2JZNGZkellJeEZDQUVtTnJjQVpP?= =?utf-8?B?Y0EvMFlZZDVrWllpOFpjTFlUbTFpakZuQjZnZUIyNDJMUzFyMVY5bFQvbjNK?= =?utf-8?B?RWN2UURRMXBCOXRTaE5hUWRVZ3JqcDhEQ1R2VEdkaXJ1NzgzUU9pb0tQQ0ZO?= =?utf-8?B?VXNubjdnb01waGR4OEdrSVBKeFdvejFWVS9WMVYyR0NwVi9vTWVvaVBDT3V3?= =?utf-8?B?Rnc5cVpjUVlSQm5nQjl1U2lNT1BZaGc2NU51dzh5YTVtTGE2YjBhb3puSjQz?= =?utf-8?B?YTFOR1hVUE12ZFhFNGEwMXVUeUNjT2d3TFRPS01SRlpFQkNqdjYwd0E2R2xY?= =?utf-8?B?YVNxb1BHNGtQTll3bGZ0dmMvOS9ZY2V2eE0xaklhcmdvdi9FclVtOWg1VFpD?= =?utf-8?B?Wnp4NUlyc0NlZHZFdGJkT1hhNk85ck9mc1kyS3lCSHNUZjQxYUZkNUZjbTZF?= =?utf-8?B?bU92MitqZHl0K09IWjAxSGhFU1JhTy9EeUprTmFaTCt2U0dUSjFJWEc5NmNX?= =?utf-8?B?WnJiUlExL0ZNZHpFVjNrSHB6dDgyWTZhR293TXJLUzhyRXJRR1V1M0dHWEor?= =?utf-8?B?TEJWMkFNWWNIa1ViTGhwcmxBNkdRRG9Wek0zZDBDT1o2dUZmWFIxTWJZcENR?= =?utf-8?B?aUptc0hBL1ljM1NESHMwYlZYNTk4V3V4S2V3c0MrWlFHd2dqbmxEWkZ3ZG1X?= =?utf-8?B?c1RaNEsrQXc2OGlYZGxPZ0w5clltVzgyejJYT1pPTFEyMDB5QWIwSzVTZkhP?= =?utf-8?B?dVBCMi82MU1XRTJCZ1Fvak81b0hiay9YN2R4alVzaVhIVTY2NWJpaUszSk5v?= =?utf-8?B?aGcvL2xOQy8yMG9tOEM5ZW9ZTjVpUFMwRTk0ZlZVQ1htRTIyMjJlZU5HYWpa?= =?utf-8?B?SHpMejkzbXcwTFlpWXBRanhsc0JyRk1IVUxucUJlTW9oOWcwU0F5NkhmK29N?= =?utf-8?B?aENxdzJXZFRnWnYwMlp3UEJORWREN0o4UjlQOXhQaC9UalQ4a0hQRFprbDRn?= =?utf-8?B?Q3ArVTByRzczNTgybnBDZ1Y1WFh6RzR4S28wN0tiTmNYNE1FWGg3clk0UGhi?= =?utf-8?B?QXJuSENNMmZWSE9JVnM3UE9VTDh3d01GTFBCYUkvV1BRT2hxUWR4KzVTdG9M?= =?utf-8?B?ekh5cEpReXJrVy9GR3FzaVlDUWxuWTRmNkFQL3FOQ0xHS1kxMk5VS1QyenBJ?= =?utf-8?B?TitNRkxid2JPeTlxeHNpU3Q1eDMwZjFDcnJRdU04RjRXZC85TkZscnNWakZO?= =?utf-8?B?b0V3K3grOUJncGlHcmhxdHBvNEpzaDN6M2p2UVNQQXFIeEZzcTFoK1lmRDNW?= =?utf-8?B?NmNFdFhQRVBaeURHalNHN1dOSEJIT1k1VHl3TVNuVU1ZbUJybkZuam4ycmpt?= =?utf-8?B?ZGNncXlTR2NHK25zdkRUSTN3RVRWbTA2STB4VzFZa2lyTDdRNnR4TXFYQTV6?= =?utf-8?B?cVVWU1ZJTk9NYXp6OVk2UGlCOFlEMTl4MkJZUTRBYWc1K0Y3RnFKbTBvcnFu?= =?utf-8?B?bDIweDBhV1BpKzhpMmpOblIxYXVCSEgrL0k4aVZOWTVHQUtGRTJWcTkwaS9V?= =?utf-8?B?SnRpN1B3ejZXcjRGRks5Q1hvdDkwS2lDMHlDV1J2U3JnV05oTUtPdXpodGFn?= =?utf-8?B?WEtjTVQzWnBLVGxFQUlHOXEzUE44cU9DRTEzZlAxcEtzbFpERkpoUm1VVTd2?= =?utf-8?B?NVBERXlwZXpjODI4Q3pnSjlqdWgzL3hpV0pSdWZwcE96WXNJdDVNOXJiTTAr?= =?utf-8?Q?NykLYJ6zu/Tez7EMJlcHN3+Yu?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 3xv1zUXSYd8jMReWCbd+4ha2N1jQ8audg5+6jmU65fKj8iSTAEEWsRnsO+UiY//WIAl5+4pyK7jH6sfG24vL9NXnf67kKGlsPu0CTPlGuSUaWEPzluVbQvQOHllCziRPRmpXVWciG/9jJ/gZgKSrqa7xgWfwU9PFe33SptUn3y7Hx9oIbkgcW9UucxSSkfyPtPRmLo+58A8/L76hz8tBHHGDr+D6w7btscJdpp6e8ZlaLgalb2QwWs++cybMl9upZGyfIgmYkRI6B3rFx+mA++MpptTnv9vnVEH1dtl/0XDtWA+fwQP26jRLuDNDxjKa0Mt1mMNqgJ0dmzmNsVxB7q3bxBSySdl1qwM7oxIx4VdMB/Zf3D60AW0Y5xXwkCOtt1EsqQyJTFP0n0wDsQhdPOZVRzJ4+wNkRFUHZ9PE4uCK+UOgLV9uQaW57ZiMjgPKCc2WC/kOpxkaChk/kqj6F+WyHEVYrAhxbmGRvEzzNVzx1Wq9pSYzs9l6aTQMaGH8DFppwmejvavYavwmpxk7u1lJ+Z7s5jGUj1RM+ut1+6CQR+ejTTpDCK6y1jddn+uSr99kNKE/V4tW6BX1WIhGSwnThNucash5j7fZ60V16kbH+Cg3cyW7PPHFXwgFAj0Aj6JSPcgcLu62P8WmvLzrQ34sXfpTgb6szxvchLRM5XxswIoeAlfi+AFeSNbAy57ot1TJnWUzhdawiP+DqXILUIPIROOI1XiUdmM8vl0rfv9+YvzBBDuQW2EjN/retTTRNbZEhNIq69ce2BZXntSUqrjheXH2KhfLvodPhphlNZszhQ8le1ZMKlHU0iG+YO91Vn3WDzPBmEZhyaGjkM99p+NRaYiC1j7d88nWVS+aTdM= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18853936-986e-4962-f392-08dac7297460 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 16:50:08.9255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9mOVkB9ZxMyGugt3bfdXNOMJCrerTrx3X+Y4+74RBTiyoltJ/9IBihzi1zSE4ZJSUfEQq/kwOHNDz9rXIXueiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5002 On Tue, Nov 15, 2022 at 04:21:07PM +0000, Andrew Cooper wrote: > On 15/11/2022 13:26, Roger Pau Monne wrote: > > Since the VIRT_SPEC_CTRL.SSBD selection is no longer context switched > > on vm{entry,exit} there's no need to use a synthetic feature bit for > > it anymore. > > > > Remove the bit and instead use a global variable. > > > > No functional change intended. > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Jan Beulich > > Release-acked-by: Henry Wang > > This is definitely not appropriate for 4.17, but it's a performance > regression in general, hence my firm and repeated objection to this > style of patch. While I don't have any objections in deferring this past 4.17, none of the modified paths are performance sensitive AFAICT. > General synthetic bits have existed for several decades longer than > alternatives.  It has never ever been a rule, or even a recommendation, > to aggressively purge the non-alternative bits, because it's a provably > bad thing to do. > > > You are attempting a micro-optimisation, that won't produce any > improvement at all in centuries, while... Oh, I wasn't attempting any micro-optimizations TBH, just didn't see the need to keep this as a synthetic feature, and generally consider better to use a global variable because it's IMO easier to follow. > > diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c > > index a332087604..9e3b9094d3 100644 > > --- a/xen/arch/x86/cpu/amd.c > > +++ b/xen/arch/x86/cpu/amd.c > > @@ -49,6 +49,7 @@ boolean_param("allow_unsafe", opt_allow_unsafe); > > /* Signal whether the ACPI C1E quirk is required. */ > > bool __read_mostly amd_acpi_c1e_quirk; > > bool __ro_after_init amd_legacy_ssbd; > > +bool __ro_after_init amd_virt_spec_ctrl; > > ... actually expending .rodata with something 8 times less efficiently > packed, and ... > > > > > static inline int rdmsr_amd_safe(unsigned int msr, unsigned int *lo, > > unsigned int *hi) > > diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c > > index 822f9ace10..acc2f606ce 100644 > > --- a/xen/arch/x86/cpuid.c > > +++ b/xen/arch/x86/cpuid.c > > @@ -3,6 +3,7 @@ > > #include > > #include > > #include > > +#include > > ... (Specific to this instance) making life harder for the people trying > to make CONFIG_AMD work, and ... That's indeed a point, albeit I think adding a `#define amd_virt_spec_ctrl false` won't be the bigger of the problems when dealing with CONFIG_AMD, and will need to be done for other AMD specific variables anyway. > > diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c > > index 4e53056624..0b94af6b86 100644 > > --- a/xen/arch/x86/spec_ctrl.c > > +++ b/xen/arch/x86/spec_ctrl.c > > @@ -514,12 +514,12 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps) > > (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) || > > boot_cpu_has(X86_FEATURE_SC_RSB_HVM) || > > boot_cpu_has(X86_FEATURE_IBPB_ENTRY_HVM) || > > - boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) || > > + amd_virt_spec_ctrl || > > ... breaking apart a single TEST instruction, which not only adds an > extra conditional merge, but now hits an cold-ish cache line everywhere > it's used. Why does performance matter here? It's an init function that prints the speculation related settings to the screen, so that's likely to be many times slower that accessing a cold cache line. > Count how many synthetic feature bits it will actually take to change > the per-cpu data size, and realise that, when it will take more than 200 > years at the current rate of accumulation, any believe that this is an > improvement to be had disappears. > > Yes, it is only a micro regression, but you need a far better > justification than "there is a gain of 64 bytes per CPU which will be > non-theoretical in more than 200 years" when traded off vs the actual > 512 bytes, plus extra code bloat bloat, plus reduced locality of data > that this "improvement" genuinely costs today. I wasn't considering any of the above when proposing the change, my only motivation was that global variables are clearer to use than synthetic features, and I didn't see a need for a synthetic feature in this case. If we agree the above possible performance regressions are worth it I'm fine keeping it as-is. Now that I realize it amd_virt_spec_ctrl could even be plain __init. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Nov 15 17:04:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 17:04:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444037.698835 (Exim 4.92) (envelope-from ) id 1ouzMe-0006bN-0T; Tue, 15 Nov 2022 17:04:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444037.698835; Tue, 15 Nov 2022 17:04:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouzMd-0006bG-T7; Tue, 15 Nov 2022 17:04:47 +0000 Received: by outflank-mailman (input) for mailman id 444037; Tue, 15 Nov 2022 17:04:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouzMc-0006am-Gl for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 17:04:46 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 97b0048c-6507-11ed-8fd2-01056ac49cbb; Tue, 15 Nov 2022 18:04:42 +0100 (CET) Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Nov 2022 12:04:36 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SN4PR03MB6688.namprd03.prod.outlook.com (2603:10b6:806:21f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Tue, 15 Nov 2022 17:04:34 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Tue, 15 Nov 2022 17:04:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97b0048c-6507-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668531882; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=udfP5mVpfBNkOoLDBwBJ991OfPMFZZzQ0L+VJpNpRtc=; b=dm6PNoQ47lIoy3hVC7fBy5He6PFwX0ciTkr2Qs3H4YFFzKuCzXumshGc z2/vuRqCpJVd21Tg9z7e+8SsiELAoikcMSP5RHqSkAOj3n+w/f4gHc1nw XjeEwk16JxQPqOpIAPmo2UvPSQSvCOLiO1xZyZR9cLviZ8hszeDzzSerU A=; X-IronPort-RemoteIP: 104.47.55.173 X-IronPort-MID: 87413049 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5UW01qt3wnQEHGREVOdqf2l5K+fnVHFfMUV32f8akzHdYApBsoF/q tZmKWGHa/iJYmHwcotxbty19k4Fu5+HnIM1SAQ9rHpmFS0a+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaHyiFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwKw8AfhCz192MnomhbthJhuB6HODAM9ZK0p1g5Wmx4fcOZ7nmGv+Pz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjf60b4G9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAurB95LT+Xkp5aGhnWcyDMdUjBIa2CV+8nokRTkRfMHN xc9r39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLL5y6JC25CSSROAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9EIMZTSoNTA9A6d+zpog210jLVow6T/XzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQKzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:2/GFXKvRXeZTkGDdqlzNNyec7skCHIAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YaT0EcMqyNMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPHxXgspbnmNE42igYy9LrF4sP+tCKH PQ3LsxmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzI39QWUijusybjiVzyVxA0XXT9jyaortT GtqX2z2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuQFNzn2jQ6sRYJ5H5mPpio8ru2D4Esj1P PMvxAjFcJu7G65RBD8nTLdny3blBo+4X7rzlGVxVPlvMzCXTo/T+5Mn5hQfBf141cp+IgU6t MD40up875sST/QliX04NbFEzlsi0qPuHIn1coelWZWX4cyYKJY6aYf4ERWOpEdGz+S0vFQLM BeSOXnoNpGe1KTaH7U+kFp3dyXR3w2WiyLR0AT0/bloQR+rTRc9Q811cYflnAP+NYWUJ9f/d nJNaxuifVnUtIWRbgVPpZPfeKHTkj2BT7cOmObJlrqUIsdPWjWlpLx6LIpoMm3ZZ0zyocokp ipaiIViYcLQTOuNSSy5uwKzviUK1/NHggFi/suqqSRg4eMCoYCaka4ORITe8jJmYRtPiSUYY f3BHtsOY6TEYLfI/c34+TAYegtFZA/arxhhj9pYSP7nuv7bqvXi8f8TNH/YJLQLBdMYBKOPp JEZkm4GPl9 X-IronPort-AV: E=Sophos;i="5.96,166,1665460800"; d="scan'208";a="87413049" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S5kGh4jFeTXQihp26MUtMKzGhObvJY84YOYucRtumnGDOiH1kznQuNBzOpVVhh8FPd5riuoy00qZoTUQH7iTEt9m8TS5EcLaejGis44ZR2PH3Zp2DkjUAilyxPT+jsfbLepd+rPab/lXiW2ZlCCYJ4eD/nJ7ZIgDygpaMhe1zmtzDFA68Yt6UJ7E7rmyCSUaIZfCvcnBFDqicaGCFHetBvXSXHOLhpkZNolRwePEpr5QqrFm3gp80dTP+eNIIx3xlre9XRTQlQLM/eC9p7kLe7XE3MJpqWTT+rZ7cvPn44ey3qyF4Ae57DeAiUbrljjcVKnJoquEKJvdaOEnpsa1iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LM+DbkwcTP0ihV97RnOsi4nfOk3Q59+H/U4rqQjX5Qw=; b=U3qOefoZ0CMPCYL4wLiP/aDmpSF+VwsqJC8rUynUA/CcOVvTLoh5vI4zmdLQ0oIDwvGezYm0nPWMXPicfZO3Ank0tD/HNubXu5mYIpVpYPWfx/MW5dSfwc2KrqB1npm1hp1h4QhjIKZg+uEBOSQww13yYQ1GZ4735L07Dcc37b6R57eRKzilHO8WoR5vM/xV/GiYgUawYOipTckFgqCKP8FXXB61C0BfT2y9A2e/0rJ34pU04dLPZRO0tnDYBH1NUhRITQhR+PeL4nd3g3pgmWAgit0G8KhctmQVTsLlr9sdmZtoeBU9z+hmyrUzUlx02x04qHXuoLV1UTB3B8TejA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LM+DbkwcTP0ihV97RnOsi4nfOk3Q59+H/U4rqQjX5Qw=; b=Vci4yHh4drcV2aLmmzqHFK0ZbL3elXoCCn9z25LkNlQYPgZUWsos+vMGNmwsir94nydvfvt/aNwzjwz/Htq7Ywc5IwIGujt4ya4pLv/p2ZMMWGrir1IlgrV6mC7NSnCNnRGwMCSUqkC0GPKFkXyXYkOv6i5mnFsvGRyMCVJe8a4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 15 Nov 2022 18:04:28 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/irq: do not release irq until all cleanup is done Message-ID: References: <20221115123500.97114-1-roger.pau@citrix.com> <6ba69073-3c58-2791-9572-c5c2e433db07@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6ba69073-3c58-2791-9572-c5c2e433db07@suse.com> X-ClientProxiedBy: LO4P265CA0203.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::17) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SN4PR03MB6688:EE_ X-MS-Office365-Filtering-Correlation-Id: e7733b25-ef17-46de-79dd-08dac72b77f3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KiQ7ueNyLcmuKbPVMQp5ss3QjsfCwIzb5pLEzbLUX6w1P6tYF/CvK3UoqG5uzKocKydq+SIRn15Uh3l+B9hFTzXHRqTuLDD8y9OuQWM4v04bs0+B3NUAFlGIFKuVMwYSr/YMTLegGJB+QWYIm+53c8E3Z1XYg6a3zpP45x4hEK2JX7/Qb7R0IDHjpr6Bnsj0oPQW8kD5MNhu4vkiUI8xADflBLhSa0xhEnHYtrXBAolM9Oz5Ci+ZFs2yMfDPbOJ9juSOJ8Rmzfdq+GWjz/XK6WKS2adqOQYT+9EtDY4OaYmQ+uBL3LkloswIAdbwe1ayecyM4uOO9xZmSRSvZ3loJias5R6+zAZcODC8Y3Zh/u0Xfv3SN8fZw3gg/L+725wCPmLtJuL28GtTyzEyVTl0epcfcGDl9rqG+bCd5Vzvm0zjv+u19RfDCeUJppcPBagDMFEt3yFxjlGoDGEBkQ/5YMswA+FCPDHljxczj+S/EqYPpN8BqFkX2dlP/dVaB6r216iWzFviT1OG0B9cQin3vW8nIcef8zL426VZrSs8e7hnbCzD9WA02iizZaisEQs0O67PrX/aHBSULokXTmAW/egRJ1TpShMsS/dmPzQUTXBkzEvK4+V6XwmhnAJC4hxjvU6pZbiRRfwnLwy2r6ylA4h1go6hBJxVqMTvzURRVmxJ4wtYsFJ4GavpmZYGq8Dh5YnpZQHvU4Eh4UTWDArN1g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(376002)(366004)(136003)(396003)(346002)(39860400002)(451199015)(9686003)(6512007)(26005)(86362001)(38100700002)(66476007)(66946007)(66556008)(8676002)(4326008)(316002)(53546011)(478600001)(33716001)(5660300002)(186003)(82960400001)(2906002)(41300700001)(6486002)(8936002)(83380400001)(85182001)(6666004)(6506007)(6916009)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ek9uWTZ2Y05QODliWm9EMGtIS2RFejI0d0dtUXE4ZDJoR1BzZkpWMWdvbCtI?= =?utf-8?B?d1lPcUcyVWRwb1E4R3NMMm1nRSsrUFN4czhORlF1ZTM4czNieGlHNEZlSHpp?= =?utf-8?B?L25tcExXd3BmdUdpdTY5UG85Mktwd1lVbE91cVAraXZ4YkY2Yzl1QVJvYjF0?= =?utf-8?B?ZXhQV3ByTmJBZk9rNlUvQkVJek1SWHViNjlFYis5amFUQXZ1aVRzd1JaenY3?= =?utf-8?B?QmhJUGRmMVRGQmV2QlBNNyttRm5MNmIrbUxLTmxLYXhwQWY3UnZBRmZPOHJ1?= =?utf-8?B?cE1SRTlTWkZpMmJNeHhIbHNhMlY5cDN4c2FSb1NDaWFMNFhyeURwWTNkQVhZ?= =?utf-8?B?OU9sTTQ3ZUNGQ1lZSUcvYlRGSnFkMWxHSnF3YjdvSi95bTlxNDI0N2ZkNVAx?= =?utf-8?B?RkYxMXNKdUUycVdvdmk3V0lKVmhwS09kUWNsSTNDbUdoVWhudUlQYkxnWEZq?= =?utf-8?B?ZWZNVGROL3UzeEFpWHN0SDMvRHNkVFYydE9NRlVDL0dWY3owWTdGcWFUWlVB?= =?utf-8?B?Qk1zcGY1WHE3WXkzL2plZjVrYmtaZitsTnpBUkhkeDNDaC9HRkNLTEV4RlVW?= =?utf-8?B?ZlJBaE5aZGVOMWJ5MEhTVjVPRTN0d3FZMERVQWFqOFRtM0dsUkNkd0JzaGF6?= =?utf-8?B?R09YMEJSK1lRN1BHSEFuNGR2Y1NGUDY1bG9MbXdVZ01PQWxhR2lZaUZOamgx?= =?utf-8?B?eUFKcE9uLzZvMlZrcEVuQWtaK2tkTzgyLzVibE9PQ3N5ems3c1RpRHJFNkk1?= =?utf-8?B?RWJBdlpsenRRVzIxcVQ0Rjdib0w1RjZwUTBkRVErK2RQZXBTNmdGK2ZmNTd6?= =?utf-8?B?dHFVbEtNUzdLM1ZhL2ZCZFZGRmtHbVJuT3N0b2YzSE0rK3M0MGllM3ZUWngz?= =?utf-8?B?MEJkUjJ0bEtDQnNiMTJGdmt6RjBtYnVURlB4RGpDRXVqTTBEaGJCdDZ3bXMx?= =?utf-8?B?OFdHdzV1eW5RTWd2RTA2a01Cb0llaEhVbFRCQjdhQXhhdHVEZHVxMW84aXkw?= =?utf-8?B?aGFRUXpvVUNESWdjNGFDVEQxSTFEck8zK0l0VW1pdE5IUHRuaFcwTVlvM3ZG?= =?utf-8?B?ZDR0YUpBZ2d1Zmg4RUovREhHYkE2Q01qcWRjNUZjejZ5VWNlWVZ2Vk9HZ2RL?= =?utf-8?B?L21CMXZUNEV0NkNJWHhSWlFQNDFzUDB0NnYrdVpENzhIT2hpUUhVbWpyMHFT?= =?utf-8?B?d3JudEwreUV5Y2Y0QS9jTFBtL3pvUnlzQ1FTalhkbjVpdEZudTVSTmRmbnNr?= =?utf-8?B?L0YzYXBxVDVaSVc2NFJESjMxRmgyQW1EZi8rTjMyTEFwWENGeHpSWmFwT0F0?= =?utf-8?B?NGN0SUYwaG1EL0ttMXlrMFhCc3JTVmVsaFF2bStLYjVJMnl3eHQvcmR6dFJC?= =?utf-8?B?QzFQRkJNeDdCZWhHTzZoRmVFRXRkUk5CbW8xaG1tWnVhWHZaTjRCbVQzNVd6?= =?utf-8?B?cWtHdnB1Y3FGVU1EMW4xYXFubWNmWEZYVHNCSTkyUVlubE00bG9xSHdEWTFk?= =?utf-8?B?SGtDQ1dMWEYrSTBJNHpheWs4SmoyeW5SQ3JvM3RjWkp0OUt0dTRZbFFUR2l1?= =?utf-8?B?RGJjNUtRQXVpWm5uR0lzMEFQVlM2VHkyekU3TXJXaEhRMnA5ZUhpOGZXSkc2?= =?utf-8?B?WVJ5aG1TZ09zcUNISmNMV3dXZzRMcUFwYXBCY01oOE1qWE9yMlJnaE5RbG1Y?= =?utf-8?B?K0pQNkxmRVcrb2Q5MnpuL29QR05mUjBVekV4QWZZRTgyMTE3ajJUSVpvNS9I?= =?utf-8?B?QkVNdGYwRC9QT0pZMWVoV2VGaEJoVWNwOGZKSDNTanBHYUhpZVRBemkreWU2?= =?utf-8?B?QWxVSDA5M3dmbkpUeUR6UHZtRmU5NDRCUS9IK3JkNldHZUMyTTVKK3NPTnkx?= =?utf-8?B?THlZNko5M1oxWWxuWWlyZTNoTG1wQzQ1aXpKSEhJWUpHQXZSUm9Ma09lL0N4?= =?utf-8?B?d042bDdiUkhINmEyUlRtd3VKMDc0SEpIbTYreU5QbDdGblp1TDZ3ellZN3ND?= =?utf-8?B?eTQ2YUpKSUJSdXVYa3IvRUovY1BtTFE1VGpjdVJRUjNtdi9TbkhxdEg5M1BW?= =?utf-8?B?NHNSczY3Vmxpc282ZjAvd1c5Z1A5SkkvQ2Erd1JpVTVaQzFjdWtibSs1WndH?= =?utf-8?Q?s6bX7RHYewnjE98/R1sJpC2+X?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ODzMT/tD2kgT85zfTKLdGebr8dsQjirM/T/kQ3+TxRFhesLuWD8PeCl+254zh8RGodTJSyPxiAgZJl0Lsw+Wxd8I+wgkTsgKCrgbzI4PelPJTh0lwwgF4yskGXPtk34oN3Se9nEqnkDeZ3bHvbxSDrY7XvPWQX+/mIdUO2dAGuU/jYEN0Sk1uv+xxP5AuU9/sZ8lbICDq9CELmc1lW9I6eFTcDmSGZvcl8CoXaD6ydfd7hlU/xaZdQMvwEvq9qCg/O4G3apCjsEgD5gvKUU0l8sJl5pLimBQuHHx4/Czr+4p9/V7TkevEesW8VvWcKY0YvTcrwYO4LAr4JMRP+2rjsYLlmNaQ5Zwz/vLpDhRfQ00uai4cu7iUEkO9eI60jZeOGjDLW1Hi+p0g0Yl6wTW2OY7iWDcoWexpJ3Ks7PpJfXtLZaKMJMSZbga6HdnB3FOdZUB/6cd8LZHJ70sS2LAz8b8IjlszZHvkpv1fuVMySLKWDVIloYhAPi6//vBNEsN6Go9fiky0c1M2MXvhvKNXG5f6Me+rI4dEv+SUZoG6e+DyCLpdaGc8lkzrtudPUrEXX4a9ZiuSKGTYcYPfNhrM/2I/nnIXYoAhqa51CbXipxAFF/Wo1ancvCFL2uHsjMmeXJqqsCJi/WZC780eezLcFcL1wFq2YHaQ84kyQ8cUDIGCoCeTt7OcqdUegRtACwtycqcm39J/SAPuAgxNvfQyjESCFao7ZSJK3STDj6ISsGNBiI6ePamH2BAzZklQiBbeHxxC8Y46X0llkSa0bTUlSh3rV26+FFzTRjWQT+BaRen8uFxguIAWe5mQs8tfH6r3LYjtEukxkk7qK/RfLGp2Q== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7733b25-ef17-46de-79dd-08dac72b77f3 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 17:04:33.8968 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ofplXNLQtEieuG8zJhjiHndHMOKGVdBCfk200n/Iub0V/Ux3tR5lz0Gk6KPMtEen39pAY5CCzIn+i2xOWfh1BA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6688 On Tue, Nov 15, 2022 at 05:29:47PM +0100, Jan Beulich wrote: > On 15.11.2022 13:35, Roger Pau Monne wrote: > > --- a/xen/arch/x86/irq.c > > +++ b/xen/arch/x86/irq.c > > @@ -220,27 +220,27 @@ static void _clear_irq_vector(struct irq_desc *desc) > > clear_bit(vector, desc->arch.used_vectors); > > } > > > > - desc->arch.used = IRQ_UNUSED; > > - > > - trace_irq_mask(TRC_HW_IRQ_CLEAR_VECTOR, irq, vector, tmp_mask); > > The use of tmp_mask here was ... > > > + if ( unlikely(desc->arch.move_in_progress) ) > > + { > > + /* If we were in motion, also clear desc->arch.old_vector */ > > + old_vector = desc->arch.old_vector; > > + cpumask_and(tmp_mask, desc->arch.old_cpu_mask, &cpu_online_map); > > .. before the variable was updated here. Now you move it past this > update (to the very end of the function). I wonder whether, to keep > things simple in this change, it would be tolerable to leave the > trace_irq_mask() invocation where it was, despite cleanup not having > completed yet at that point. (The alternative would look to be to > act directly on desc->arch.old_cpu_mask in the code you re-indent, > leaving tmp_mask alone. I think that ought to be okay since nothing > else should access that mask anymore. We could even avoid altering > the field, by going from cpumask_and() to a cpu_online() check in > the for_each_cpu() body.) Hm, I was thinking we should print the old vector mask (since that's the one still in use because migration hasn't happened yet) but then we would also need to print the old vector instead of the new one, but maybe that's too much change given the current behavior. I think it's fine to set the trace here, before IRQ_UNUSED gets set (in fact it might be better, as then the trace should be more coherent). > > > > - if ( likely(!desc->arch.move_in_progress) ) > > - return; > > + for_each_cpu(cpu, tmp_mask) > > + { > > + ASSERT(per_cpu(vector_irq, cpu)[old_vector] == irq); > > + TRACE_3D(TRC_HW_IRQ_MOVE_FINISH, irq, old_vector, cpu); > > + per_cpu(vector_irq, cpu)[old_vector] = ~irq; > > + } > > > > - /* If we were in motion, also clear desc->arch.old_vector */ > > - old_vector = desc->arch.old_vector; > > - cpumask_and(tmp_mask, desc->arch.old_cpu_mask, &cpu_online_map); > > + release_old_vec(desc); > > > > - for_each_cpu(cpu, tmp_mask) > > - { > > - ASSERT(per_cpu(vector_irq, cpu)[old_vector] == irq); > > - TRACE_3D(TRC_HW_IRQ_MOVE_FINISH, irq, old_vector, cpu); > > - per_cpu(vector_irq, cpu)[old_vector] = ~irq; > > + desc->arch.move_in_progress = 0; > > } > > > > - release_old_vec(desc); > > + write_atomic(&desc->arch.used, IRQ_UNUSED); > > Now that there is an ordering requirement between these last two writes, > I think you want to add smp_wmb() after the first one (still inside the > inner scope). write_atomic() is only a volatile asm() (which the compiler > may move under certain conditions) and an access through a volatile > pointer (which isn't ordered with non-volatile memory accesses), but it > is specifically not a memory barrier. Right, sorry - I always get confused and assume that a volatile asm can't be reordered. I was about to add the write barrier but didn't do it because of the volatile in the asm. I would like to request a backport for this, but I think it's now too late for the patch to be accepted to 4.17. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Nov 15 17:04:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 17:04:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444034.698824 (Exim 4.92) (envelope-from ) id 1ouzML-0006I7-MZ; Tue, 15 Nov 2022 17:04:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444034.698824; Tue, 15 Nov 2022 17:04:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouzML-0006I0-Jh; Tue, 15 Nov 2022 17:04:29 +0000 Received: by outflank-mailman (input) for mailman id 444034; Tue, 15 Nov 2022 17:04:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouzMK-0006Hq-R3; Tue, 15 Nov 2022 17:04:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouzMK-0001yu-MA; Tue, 15 Nov 2022 17:04:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ouzMK-0001BU-5M; Tue, 15 Nov 2022 17:04:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ouzMK-0007kA-4r; Tue, 15 Nov 2022 17:04:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TDN8Em3r4ko78RdFZrp657w60YvG8G6hMSEdGdLgjis=; b=vKSNvSG7Pvbyb88WIGgJ8QKQkx 7KvP/i/9MdOvniMUjO/yE51JdVc3UEzkoEu7qiRJb0LhDkAS2gIfnGTn4weEiN9fAuG8k3A0TR7d/ /HIUWgCHp103lc/MjnpaZ1Tp1lVaKcVe1JywHdZnpqBRT3kS6NPbVHkl1io6CtTsNcCE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174776: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e01d50cbd6eece456843717a566a34e8b926cf0c X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 15 Nov 2022 17:04:28 +0000 flight 174776 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174776/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux e01d50cbd6eece456843717a566a34e8b926cf0c baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 38 days Failing since 173470 2022-10-08 06:21:34 Z 38 days 63 attempts Testing same since 174776 2022-11-15 05:17:35 Z 0 days 1 attempts ------------------------------------------------------------ 1705 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 162321 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Nov 15 18:04:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 18:04:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444049.698845 (Exim 4.92) (envelope-from ) id 1ov0Hn-0005w4-DK; Tue, 15 Nov 2022 18:03:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444049.698845; Tue, 15 Nov 2022 18:03:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov0Hn-0005vx-A1; Tue, 15 Nov 2022 18:03:51 +0000 Received: by outflank-mailman (input) for mailman id 444049; Tue, 15 Nov 2022 18:03:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov0Hl-0005vn-KA; Tue, 15 Nov 2022 18:03:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov0Hl-0003K9-FZ; Tue, 15 Nov 2022 18:03:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov0Hk-0002nB-Sx; Tue, 15 Nov 2022 18:03:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ov0Hk-0002TU-SW; Tue, 15 Nov 2022 18:03:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=E7J9sbnjrD770Ncfed/H/LSk3PkIM50da2n2UqllQGY=; b=2soxYWi5wisexmXDmWsI8w/IOD OXwyLMwhuyiGw5jmbjzIi4MshhX0SuRUNpXJV+/ZPROEdGto2HmE4kVOVv03ZG1QFH84r6DKIF+2i 2Tq2dSb6bHd6P6e8JFAyLWlFKRZCQ1tR3A12YByBy7L9R1x/OWkVZq9wwJ0Ukspq8XMg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174777: FAIL X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-arndale::broken:regression qemu-mainline:test-armhf-armhf-xl-arndale:host-install(5):broken:heisenbug qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=98f10f0e2613ba1ac2ad3f57a5174014f6dcb03d X-Osstest-Versions-That: qemuu=305f6f62d9d250a32cdf090ddcb7e3a5b26a342e From: osstest service owner Date: Tue, 15 Nov 2022 18:03:48 +0000 flight 174777 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174777/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale broken in 174772 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-arndale 5 host-install(5) broken in 174772 pass in 174777 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 174772 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174761 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174761 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174761 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174761 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174761 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174761 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174761 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174761 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 98f10f0e2613ba1ac2ad3f57a5174014f6dcb03d baseline version: qemuu 305f6f62d9d250a32cdf090ddcb7e3a5b26a342e Last test of basis 174761 2022-11-14 01:07:28 Z 1 days Testing same since 174772 2022-11-14 22:08:27 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Jens Wiklander Peter Maydell Stefan Hajnoczi Vikram Garhwal jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-arndale broken Not pushing. ------------------------------------------------------------ commit 98f10f0e2613ba1ac2ad3f57a5174014f6dcb03d Merge: 305f6f62d9 d9721f19cd Author: Stefan Hajnoczi Date: Mon Nov 14 13:31:17 2022 -0500 Merge tag 'pull-target-arm-20221114' of https://git.linaro.org/people/pmaydell/qemu-arm into staging target-arm queue: * hw/intc/arm_gicv3: fix prio masking on pmr write * MAINTAINERS: Update maintainer's email for Xilinx CAN # -----BEGIN PGP SIGNATURE----- # # iQJNBAABCAA3FiEE4aXFk81BneKOgxXPPCUl7RQ2DN4FAmNyY7cZHHBldGVyLm1h # eWRlbGxAbGluYXJvLm9yZwAKCRA8JSXtFDYM3mrBD/4mG6AMW4CGROWq3u3F8STK # 22uxpilhyBmPawBykUC8dYId8A0GjGqeJ5HRhYE/0ZKqlk9GtFBI4YHM8ccocozK # VdgKP7VvXNiBwjV2kQ3mdZnfXRnNWLTnGQd9Q/9EjU+FOBz4hsOoRh8rv+9t2inn # dtXV8wbLYQYHCgVPAwTP39DXzF0YQ5sAjVxbjC1lFE6k3pAcDvoGKKcWt9GOI5m1 # 5ImPgnVdunscqA9otvl56a03M5TbdH8KiAEARo3juFYYEHkl4qD2E2CK6On8wTIA # 7zeSoxvTDDYD6mcV/RwFuEcOr+YIFpxeGxes9PKpnYh8Dpx9YPeIYRsK5qTI7QUz # Ldbz9PnZE6DPaPsT67kzFnfx4se6q10d5wXaK8VsFBOZ4V9yYONaXlHiZbgpWn/K # jlbiJFtehCA0iS4D6YcoDTqL88M/RM5cbj/5tht8sxrl9HJ3r/hxdJ7W+zqpTg2j # 3TV+j9okLqyq/4RIFZbf5yVPFPMtF/FOIl95ZAHmvJYjC/L9yXRT6Y5EdKfZPwMe # 5FBjdly4gsUqNxFUfPByRVtaoelxjXi/+0wHXWZNw8Naco3yd7VMoqIRLDE4qhY5 # GfjF2Aai7PHiwb2VE+mIIfz+ldEk5XHFYlXBtUOwt8q2UUnmYsVqh8zFpTYLaDdY # RezkZM4yMYx38GPWCvAvlg== # =clh5 # -----END PGP SIGNATURE----- # gpg: Signature made Mon 14 Nov 2022 10:50:15 EST # gpg: using RSA key E1A5C593CD419DE28E8315CF3C2525ED14360CDE # gpg: issuer "peter.maydell@linaro.org" # gpg: Good signature from "Peter Maydell " [full] # gpg: aka "Peter Maydell " [full] # gpg: aka "Peter Maydell " [full] # gpg: aka "Peter Maydell " [unknown] # Primary key fingerprint: E1A5 C593 CD41 9DE2 8E83 15CF 3C25 25ED 1436 0CDE * tag 'pull-target-arm-20221114' of https://git.linaro.org/people/pmaydell/qemu-arm: hw/intc/arm_gicv3: fix prio masking on pmr write MAINTAINERS: Update maintainer's email for Xilinx CAN Signed-off-by: Stefan Hajnoczi commit d9721f19cd05a382f4f5a7093c80d1c4a8a1aa82 Author: Jens Wiklander Date: Mon Nov 14 15:10:58 2022 +0000 hw/intc/arm_gicv3: fix prio masking on pmr write With commit 39f29e599355 ("hw/intc/arm_gicv3: Use correct number of priority bits for the CPU") the number of priority bits was changed from the maximum value 8 to typically 5. As a consequence a few of the lowest bits in ICC_PMR_EL1 becomes RAZ/WI. However prior to this patch one of these bits was still used since the supplied priority value is masked before it's eventually right shifted with one bit. So the bit is not lost as one might expect when the register is read again. The Linux kernel depends on lowest valid bit to be reset to zero, see commit 33625282adaa ("irqchip/gic-v3: Probe for SCR_EL3 being clear before resetting AP0Rn") for details. So fix this by masking the priority value after it may have been right shifted by one bit. Cc: qemu-stable@nongnu.org Fixes: 39f29e599355 ("hw/intc/arm_gicv3: Use correct number of priority bits for the CPU") Signed-off-by: Jens Wiklander Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell commit 32bd99d02b4549d1007fb26b7301d26c55e3ba5a Author: Vikram Garhwal Date: Mon Nov 14 15:10:57 2022 +0000 MAINTAINERS: Update maintainer's email for Xilinx CAN Signed-off-by: Vikram Garhwal Reviewed-by: Francisco Iglesias Signed-off-by: Peter Maydell From xen-devel-bounces@lists.xenproject.org Tue Nov 15 20:41:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 20:41:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444059.698857 (Exim 4.92) (envelope-from ) id 1ov2k0-0007Zw-H8; Tue, 15 Nov 2022 20:41:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444059.698857; Tue, 15 Nov 2022 20:41:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov2k0-0007Zp-DO; Tue, 15 Nov 2022 20:41:08 +0000 Received: by outflank-mailman (input) for mailman id 444059; Tue, 15 Nov 2022 20:41:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov2jz-0007Zf-Mv; Tue, 15 Nov 2022 20:41:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov2jz-0006t1-Ja; Tue, 15 Nov 2022 20:41:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov2jz-0003h5-2A; Tue, 15 Nov 2022 20:41:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ov2jz-0004EX-1L; Tue, 15 Nov 2022 20:41:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=flQFd/KUy6B84HsDlZkq2j/6xcQa82qqaTDVd2Bpur8=; b=WlOEdihdJWnsY3vaYr5o/tH9Rp pqjBDxqnLWKRItCohXqT2ZiPO5JTlFOF/W2gxRTad5hW1Tini/Jgy8ai530n2UrzVfHky1fNY5VWb pjy6SGzRft9s29ZnlEsOMfK60fU1d69C1FDTY6oU8UGAFG4sWuXxWwH7H49a2TbVnhrA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 174778: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.15-testing:test-amd64-i386-libvirt:xen-install:fail:heisenbug xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a056387c532ce6e36a0fec60788d5a5b68f978be X-Osstest-Versions-That: xen=625efe28ab5309ab83f7826ed1de4966ede2f191 From: osstest service owner Date: Tue, 15 Nov 2022 20:41:07 +0000 flight 174778 xen-4.15-testing real [real] flight 174781 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174778/ http://logs.test-lab.xenproject.org/osstest/logs/174781/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt 7 xen-install fail pass in 174781-retest Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 15 migrate-support-check fail in 174781 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174690 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174690 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174690 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174690 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174690 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174690 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174690 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174690 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174690 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174690 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174690 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174690 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: xen a056387c532ce6e36a0fec60788d5a5b68f978be baseline version: xen 625efe28ab5309ab83f7826ed1de4966ede2f191 Last test of basis 174690 2022-11-09 11:46:20 Z 6 days Testing same since 174778 2022-11-15 08:06:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 625efe28ab..a056387c53 a056387c532ce6e36a0fec60788d5a5b68f978be -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Tue Nov 15 22:57:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 22:57:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444072.698871 (Exim 4.92) (envelope-from ) id 1ov4rK-00066c-EK; Tue, 15 Nov 2022 22:56:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444072.698871; Tue, 15 Nov 2022 22:56:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov4rK-00066V-BV; Tue, 15 Nov 2022 22:56:50 +0000 Received: by outflank-mailman (input) for mailman id 444072; Tue, 15 Nov 2022 22:56:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov4rI-00066P-Vf for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 22:56:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov4rI-0001Fh-F3; Tue, 15 Nov 2022 22:56:48 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ov4rI-0005Aa-74; Tue, 15 Nov 2022 22:56:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=fq4nNfBNqxj8n04a0kntCAL9h5BKL/74tHeb8x8CfeM=; b=ekgyROhEeXhyBDyEacmDBPWGIe y/+y7Yrfj+F2f+GQAp1/CrgroPiqq4P6j8QbjmaR5ufKX/+yx0LDT2Ka/+VDc+PXVsZxVelUbUE8c wN6DaqRCYlI3+4dXGugnlW8RWwC5vm4k7pGF+j4gsR6yL+x0D2hRa2Md2DpQg1wIiGwY=; Message-ID: Date: Tue, 15 Nov 2022 22:56:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/notifier: simplify using notifier_[to|from]_errno() To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Dario Faggioli References: <20221028114111.8150-1-jgross@suse.com> From: Julien Grall In-Reply-To: <20221028114111.8150-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 28/10/2022 12:41, Juergen Gross wrote: > Today all users of notifier_from_errno() and notifier_to_errno() are > Handling the success case the same way, by using > > !rc ? NOTIFY_DONE : notifier_from_errno(rc) > > or > > (notifier_rc == NOTIFY_DONE) ? 0 : notifier_to_errno(notifier_rc); > > Simplify the use cases by moving the handling of the success case into > the functions. > > Signed-off-by: Juergen Gross Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 15 23:10:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 23:10:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444077.698883 (Exim 4.92) (envelope-from ) id 1ov54v-0000QR-Ku; Tue, 15 Nov 2022 23:10:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444077.698883; Tue, 15 Nov 2022 23:10:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov54v-0000QK-I1; Tue, 15 Nov 2022 23:10:53 +0000 Received: by outflank-mailman (input) for mailman id 444077; Tue, 15 Nov 2022 23:10:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov54u-0000QE-7M for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 23:10:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov54t-0001Vl-PP; Tue, 15 Nov 2022 23:10:51 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ov54t-0005tx-JO; Tue, 15 Nov 2022 23:10:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=RuylqQiY+3kLe1H6S2G+Pmc4iWsnRlddUb5n4Sh++hY=; b=3LYLj6HIrvk0Do3YCbWX3f3Guh k94T5AKTQLgd/JD86UydaHOmdvF+mtQYixED+YKca3sVHFVF170unesKbJjCNfO+tfKAoKCadfqd6 0sVU29L30o63B53J2C8hEaBu1xEL2uFrx4KhLcc65DIEb9S3blrUz0TFzTbIBzXUrI+g=; Message-ID: Date: Tue, 15 Nov 2022 23:10:49 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> From: Julien Grall In-Reply-To: <20221024100536.12874-1-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 24/10/2022 11:05, Michal Orzel wrote: > Make use of the macros defined in asm/pl011-uart.h instead of hardcoding > the values. Also, take the opportunity to fix the file extension in a > top-level comment. > > No functional change intended. > > Signed-off-by: Michal Orzel With one comment below: Acked-by: Julien Grall > --- > xen/arch/arm/arm64/debug-pl011.inc | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/xen/arch/arm/arm64/debug-pl011.inc b/xen/arch/arm/arm64/debug-pl011.inc > index 1928a2e3ffbb..d82f2f1de197 100644 > --- a/xen/arch/arm/arm64/debug-pl011.inc > +++ b/xen/arch/arm/arm64/debug-pl011.inc > @@ -1,5 +1,5 @@ > /* > - * xen/arch/arm/arm64/debug-pl011.S > + * xen/arch/arm/arm64/debug-pl011.inc > * > * PL011 specific debug code > * > @@ -16,6 +16,8 @@ > * GNU General Public License for more details. > */ > > + #include > + > /* > * PL011 UART initialization > * xb: register which containts the UART base address > @@ -23,13 +25,13 @@ > */ > .macro early_uart_init xb, c > mov x\c, #(7372800 / CONFIG_EARLY_UART_PL011_BAUD_RATE % 16) > - strh w\c, [\xb, #0x28] /* -> UARTFBRD (Baud divisor fraction) */ > + strh w\c, [\xb, #FBRD] /* -> UARTFBRD (Baud divisor fraction) */ > mov x\c, #(7372800 / CONFIG_EARLY_UART_PL011_BAUD_RATE / 16) > - strh w\c, [\xb, #0x24] /* -> UARTIBRD (Baud divisor integer) */ > + strh w\c, [\xb, #IBRD] /* -> UARTIBRD (Baud divisor integer) */ > mov x\c, #0x60 /* 8n1 */ Can we introduce macro/define for 0x60? > - str w\c, [\xb, #0x2C] /* -> UARTLCR_H (Line control) */ > - ldr x\c, =0x00000301 /* RXE | TXE | UARTEN */ > - str w\c, [\xb, #0x30] /* -> UARTCR (Control Register) */ > + str w\c, [\xb, #LCR_H] /* -> UARTLCR_H (Line control) */ > + ldr x\c, =(RXE | TXE | UARTEN) > + str w\c, [\xb, #CR] /* -> UARTCR (Control Register) */ > .endm Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 15 23:16:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 23:16:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444081.698894 (Exim 4.92) (envelope-from ) id 1ov59t-00012k-8A; Tue, 15 Nov 2022 23:16:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444081.698894; Tue, 15 Nov 2022 23:16:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov59t-00012d-45; Tue, 15 Nov 2022 23:16:01 +0000 Received: by outflank-mailman (input) for mailman id 444081; Tue, 15 Nov 2022 23:15:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov59r-00012X-Oj for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 23:15:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov59r-0001ko-BL; Tue, 15 Nov 2022 23:15:59 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ov59r-00068T-4m; Tue, 15 Nov 2022 23:15:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ALaSgubVJlg+buTFa1b/+W8ptdoAfRjPbE2PkHujuuE=; b=TFFKUYfd5VyelQwCmN0H9oaQDq zi48Ng8C2cy+zBOtAHMTdttO+M3uZLIMV95EBHndrG+axrbbUhxCZb6xuKU/GkGQ6P6BcHoSAYrfY zi/4qhDcW9+EEMPQEeBelBKJfGdc5K07274JysO0UC9epUNAikF3vLciO4/TjGKw9Quo=; Message-ID: Date: Tue, 15 Nov 2022 23:15:57 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN v3 01/13] GICv3: Emulate GICD_IGRPMODR as RAZ / WI To: Bertrand Marquis , Ayan Kumar Halder Cc: Xen-devel , "sstabellini@kernel.org" , "stefanos@xilinx.com" , "Volodymyr_Babchuk@epam.com" , "michalo@amd.com" References: <20221024182518.65002-1-ayankuma@amd.com> <54C7F6D2-98C9-4976-92E4-3B46F82CCA20@arm.com> From: Julien Grall In-Reply-To: <54C7F6D2-98C9-4976-92E4-3B46F82CCA20@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 25/10/2022 08:36, Bertrand Marquis wrote: >> On 24 Oct 2022, at 19:25, Ayan Kumar Halder wrote: >> >> Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR is emulated >> as RAZ / WI for the guests as "GICD_CTLR.ARE_S==0" is true. >> Xen is currently supported to run in non-secure mode, so guests will run in >> non-secure mode only. >> >> Also, if Xen was supposed to run in secure mode with guests, the programming >> of the interrupts (ie whether it belongs to secure/non secure and group 0/1) >> will be done by Xen only. The guests will not be allowed to change this. > > Thanks a lot this description is a lot better. > >> >> Signed-off-by: Ayan Kumar Halder > Reviewed-by: Bertrand Marquis > > I do not think this is something for 4.17 so it will need to be on hold until staging reopens unless someone thinks otherwise ? I have pushed the patch to my branch for-next/4.18. I will merge it once the tree is re-opened. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 15 23:54:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 15 Nov 2022 23:54:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444085.698905 (Exim 4.92) (envelope-from ) id 1ov5l3-0005t7-44; Tue, 15 Nov 2022 23:54:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444085.698905; Tue, 15 Nov 2022 23:54:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov5l3-0005t0-0o; Tue, 15 Nov 2022 23:54:25 +0000 Received: by outflank-mailman (input) for mailman id 444085; Tue, 15 Nov 2022 23:54:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov5l1-0005su-EU for xen-devel@lists.xenproject.org; Tue, 15 Nov 2022 23:54:23 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d1e56e3c-6540-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 00:54:21 +0100 (CET) Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Nov 2022 18:54:12 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by SJ0PR03MB6390.namprd03.prod.outlook.com (2603:10b6:a03:396::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Tue, 15 Nov 2022 23:54:07 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860%5]) with mapi id 15.20.5813.018; Tue, 15 Nov 2022 23:54:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1e56e3c-6540-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668556461; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=f89u73OvTwvTvcI1Ez66c6lS5QgQuggKCFI6/Nh4TrU=; b=FSvhlr2CsTKJnoxnkhJctK39XoRhqaAPkxsm/jiMDJThFHeq4pvDTTdv XPYm15ESKGhrJzpAWNsABBszEiv+yrA0lyhXBDX4YQFlrdZWobNiqa2aH tPr302Hk+2OUAU0pH1yaiVnnBw/jwleEF1/fYVzR3Cp3SAr6AbcTKm/Lr A=; X-IronPort-RemoteIP: 104.47.55.171 X-IronPort-MID: 83965834 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FTmhwK7CekOVVkCZJwEQ5QxRtAbGchMFZxGqfqrLsTDasY5as4F+v mMZXT/SPP6KMTT3e4xybY6y9R9QuJGHmoAwSVY4ryFjHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkS4QeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m0 eQXdRwKaR26qqG22bmqdMtGvsAjBZy+VG8fkikIITDxK98DGMqGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooj+GF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJJRePlpqU26LGV7kw4Mh8GUAa2m+njkF+jReMAB VZT6jV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yyaUAHIVCAFIbtMOvdUzAzct0 zehgNfBFTFp9rqPRhq15rqS6D+/JyURBWsDfjMfCxsI5cH5p4M+hQ6JScxseJNZlfXwEDD0h jqM/C43guxJidZRjvriu1fanziru57FCBYv4RnaVX6k6QU/Y5O5Y4uv6h7Q6vMowJulc2Rtd UMsw6C2hN3ix7nU/MBRaI3hxI2U2ss= IronPort-HdrOrdr: A9a23:dEvzBK/Q37JMOKCDvUxuk+Hwdr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirCWekD+y77b+Mh6AmjMTSSlGz7sO+X XM11WR3NTjj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhn8lwqyY4xlerua+BQ4uvum5loGmM TF5z0gI8NwwXXMeXzdm2qi5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe F29lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQFo+dY7bWfHAbIcYa 5T5fLnlbBrmJShHinkV1xUsZiRt7IIb0+7qwY5y5eoOnNt7Q1EJgMjtbAidzE7hdIAotB/lp r52u4DrsAwcuYGKa16H+sPWs2xFyjERg/NKnubJRD9GLgAIG+lke+/3FwZ3pDcRHUz9upFpL 3RFFdD8WIicUPnDsODmJVN7xDWWW24GTDg0NtX6ZR1sqD1AOODC1zJdHk+18+75/kPCMzSXP i+fJpQHv/4NGPrXYJExRf3VZVeIWQXFMcVptE4UVSTpd+jEPyjisXLNPLIYLb9GzctXW3yRn MFQTjoPc1FqlumX3fp6SKhL08FunaPiK6YPJKqjNT7krJ9R7GkmjJl+WiR94WMNSBItLAwcQ 93PK7n+5nL11WLwQ== X-IronPort-AV: E=Sophos;i="5.96,167,1665460800"; d="scan'208";a="83965834" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R7E0rd+qmoQOVCC1srx5183XbLc+hZ4iaY5R/GJ+NnMB8Q2RzFmQaWgVHbV0I8Tf5sxDzLuHzQXT1A5BNtZ0qeaaw1buRO+dAQf0uXNhyLVlUvftzN75yjQpxG11POp4we551pMnGGKb2QOey3YaZzmRr88x3UbEQCDcUANR3ycTA6+gexDmffXYUNsiC7doFa+3CEO0VF4i4XTB9Kiq7WKkAkIGUEJffBLvUYuaQJnAcFJRIF/u5Lt/xUR9aB0rovP4bI0Z8MtvtXYAsVmV7dfoUUWvxvfBl22laDIBJ0k7fIfBTo27T7h4bHZSWZuLtoyt6D8/J0Ycze1SAMuUPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f89u73OvTwvTvcI1Ez66c6lS5QgQuggKCFI6/Nh4TrU=; b=mqaj5bYZeVjcFzzo5N/YarVfvjwfY6h7Zso4F/oi2lFN+QMTsQ9mvJk45Hooy+msz79theiUrWuB0QWFP8pb6+9X3lG+o9Fy6kt42pKCSnZkFO5lQoA2Eu/0lQ8YI1vjA+9r/taJmmRGEUnv5q4BNhVKGYQbE3OTTgRVgn6JiAv0e7H/GHf8FLHbUKv06VLaFDC9xsf/j4fIJdQney87MPs45+jm/NjEF3c1wpAW7WdF/hWU02f+Jtj4ivjzL8c7/paNt4mduWJAEb/e5rylDLG4WzkF4Hz0YNdzcJFVR9Y3YLnSoLyjSK5mjm4Q+UNVC+qmQUZRWNpOlN8hxQ4pFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f89u73OvTwvTvcI1Ez66c6lS5QgQuggKCFI6/Nh4TrU=; b=v/gKdiCK//0tPjSsukY1KTTiYryZ0VYUqifqcTnljxQdTDOjoODrsRQ2nKLKSv5h2Md3cIkHkwcDqGz87gFaxg7SPDVfY2XJGqRysOTdqxFqxPg3Bw6nGEUTfI/4ZZ/aqNnQdqatKPRUUlncRTJY0qjT9PCAG5sSzs/IXsuHSJg= From: Andrew Cooper To: Jan Beulich CC: "Henry.Wang@arm.com" , Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH for-4.17 v4 2/2] amd: remove VIRT_SC_MSR_HVM synthetic feature Thread-Topic: [PATCH for-4.17 v4 2/2] amd: remove VIRT_SC_MSR_HVM synthetic feature Thread-Index: AQHY+PYG7JqnYiwdr0usZ0w09l5ina5AKpoAgAAGqQCAAHfpgA== Date: Tue, 15 Nov 2022 23:54:07 +0000 Message-ID: <51e9dd3f-59fb-a112-baf7-f96c07800ee1@citrix.com> References: <20221115132657.97864-1-roger.pau@citrix.com> <20221115132657.97864-3-roger.pau@citrix.com> <5caf3930-ea8f-6e68-326f-93cca1fa210a@suse.com> In-Reply-To: <5caf3930-ea8f-6e68-326f-93cca1fa210a@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|SJ0PR03MB6390:EE_ x-ms-office365-filtering-correlation-id: f4dce970-fbe0-4b92-8c7d-08dac764af24 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ia4gcyYZvhHdTY+0ztqJ9WMPAcBfNPzqRTxtWO32nKXeLaq35Zy2qBniJPmi8aIDVDDvAPl99jYcXtwHxWTIKYoczoBTyeGIO2Aum/MdyLt1mITLDMkicNkdL5Csg+vXAD0OQxk8jDCoJCbGWp9bW2I+KiM4X+rjp3epjRq/06WDV4rUX6YxawB+/owg8l72C/TAvizLg6ZTi13j8JnwV6ToHRBC93mV3Ku58hCwVSY//znoTCyU7cTp9H1SLQCZxB1bRxHTvXzYkzrvxkyr8CgEYFf36iFT+xZEqE5N9X/OFtzGpCrS2l9Nuk+30qiyUlPBoVFVHCXmRxPfm+2OubN4eDrvzIxwhlI+KEpx5uiCBHk0rc27RaeRtCmT8tH1pr692MVZoKXHktrc4STN7tj9oaDKvkzPm0Mdn004hrEXgKNRDBgVkf1VLsi3BoNn9ySkRx5aXpI0vVMIa5TMk+O52HSFKUOQ5ZIbtaTi3r2DM/roakuY1jg4zifs20vo+osSPmX1GUEjzaMzZ3X/oPCN37wFUbEun+Onvo46Lj5dvgx1J7EL40V0Eaxpazn8jbk/XLFY871DPHU6TiAiMSZNpHO9ehzQDHrVO6/bRPTwotthqw633lujHYmZpzB0DaWA1mUh+hMg3eCtGLs5uKD/B772zpgCaLuPtJTtuI9HngD+645zW4QYY3UKO1yDemETl+JlGRMqU1DOkkxAQFnBjnAM1cutoWkEzztmf7lNDnrUX6THqHKac/h+rR6AxPrVQ/sZJtennnn00GIynXwcru2y2DfnV5J6/uCixMkiHJjysP2ONZSqYf8GqhQ8S9TOxn8B+/dYnHDMIS5OXA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(39860400002)(136003)(376002)(346002)(451199015)(31686004)(86362001)(31696002)(36756003)(2906002)(478600001)(122000001)(82960400001)(8936002)(38100700002)(38070700005)(186003)(2616005)(54906003)(6916009)(316002)(91956017)(5660300002)(6486002)(64756008)(76116006)(53546011)(66446008)(4326008)(41300700001)(8676002)(66946007)(26005)(6512007)(6506007)(66476007)(71200400001)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?clFibGdET2M0T3B6SkJlb3hIZWNxVTNsSUJXamhtZ2sySjRQNDRKQW9xeEls?= =?utf-8?B?dXZ4aDU5dlNGOE5GYUltMS9mbytmMXZhUllJVzYxcFlYTWFPUXp4UkN1b0VF?= =?utf-8?B?WXVYZVEvNGR6RWVpMi82TGdtelVWWm1FUnZlejE3Zys0RldFRVZwWlBvMC9K?= =?utf-8?B?SnlTYVhaNkY1aVpCN3BLcW9ZUThVR01wVnJhbi9ORkMrTGRSelVzd0tSMXlk?= =?utf-8?B?RTlXUERieTJIbTg5WTdMZG9pRHQvQk5JVHZRa3g3Kzdab2VaaDhHOG41SVAw?= =?utf-8?B?SzFIcllNM1NIR0RWemNYS1hvODIwMVViTW1PSXpyeXVtcXBaUU1wOUVEOWVH?= =?utf-8?B?Yi9lOUZNQVJCWWdkc3AzTWtxRjhDRVE0eXQvRDVndGVKczIzYlVucGNuZFBH?= =?utf-8?B?aVlUSmUxMk85Q1ZzZ082TWY3empPVmpsTVp2aGNlOE9ndUkxeHZtVmFmazAw?= =?utf-8?B?WjkyZm9OeXcrVFRNaEhPK1JneTJ5VDROT0VUMzF5bVBuc1VHeDdRdGp0ZDFO?= =?utf-8?B?bXhtVCtPY3FkUEFORG41ZUloWkk5cE1DY2xaU0Y2b1JNK0tiRGJibHo2M2xJ?= =?utf-8?B?Ri9mMHFXMWk1WnhpSmVqcTJKcHZzcUFHcHk5UkhXQkd4TzFMYjR2azh2d1NO?= =?utf-8?B?M3JEWkJ0M1F3bGdTbHpVRlhaS3duVFptTnYvcFpZaUxNUk1xcFFaMkF1UEp6?= =?utf-8?B?N1RybEE0Wk4zYmhpRG5MdzZrS3pOWjZpYi9UTzErTDY2R2ZRSTdJdEowQm1F?= =?utf-8?B?bkR5UVlQWUpiR1lsVzdGOVYzdU9aY2lWaG9NcUwrcC9tcTR4YjNXYVJBdVZj?= =?utf-8?B?RTVwQk5BRFF0Wk9yVXpVemR6NWhiU1ZKYmlaVUpFMW5YaWkwdGxaVCtkOHJU?= =?utf-8?B?NnEvKzNNVlRBQ3ZIenV6aGhWdUx6eXVtYVY5SmVZOHRkb1FDZzdjY2NaR3Ji?= =?utf-8?B?VVR5cWNKVml0N3VPVFl2QTdUeExFUnBpTERkemV6ZjY0Z2xiNUh6ZDI0Q1BV?= =?utf-8?B?UVdTNVdmVGt0NzhWdlRvS05CbG9ZRk54YkFvWUpLV2dQRFg3UWhKb0g1eEdl?= =?utf-8?B?Y21lb0N5cUhjU2loMTF5M09UVmZMY0ZIZTkxNTh4dUN6Q0NmdnZDSXhzTmVB?= =?utf-8?B?WFY4M1lTMGVvQ0FPQlAycHkrMURpR1dPaG1QVUpUZFpQazNQT0Rmdk5NRzFI?= =?utf-8?B?K1VWL25WcUhRWlp6UTZFVWpIdDBwaUt2bWhBcDkvOWtZblovME51a1lGL1o4?= =?utf-8?B?TlZSMG1ERHgvV3N4RnNZQWpjL1NsZmtCcDI3OWs3bGJNU2tOOGJwK3BlY0dV?= =?utf-8?B?VWlxam5FR1J6MGw5dWhiMkJYc0x3NCt3cmhUaSsrbklRMHF0VURyYi8wc2pF?= =?utf-8?B?T094c2xOaHFENzluM2pObW12VWJxMm5kbXV3bkhnakxEeTNzUlhwbTVjOFBT?= =?utf-8?B?bjBiRTFRcUNEcjdBdFhPbTFvUGVsRy8yNEZtcVVkOXBuZjh4ME42UGZ0eExN?= =?utf-8?B?a1k3bjZOTnJ1RHgyNlBLcXF5UEpsdFhUUi9iRnhRSlZYaWdreU5RcHFLaTVO?= =?utf-8?B?VklITklNYjlleEU2ZW4wYXdXZnhLTHQxQmhxYUx1bnNNVVJwVzU0WTBhSEg0?= =?utf-8?B?MHphV1lIZ250MUU0cnVFZkM3ZTBrR1l1SlJybEErUW1SOUJCNE4zTG53eEpY?= =?utf-8?B?TkYrVWRVN1FwcEM3MklFdXdob1RmUGxLOGlYT3JxcFJqeGY3cytTVTNIWUFS?= =?utf-8?B?UWUvTGlaMUs1OFZ5YWkwci9aejBqWXFZczlaaStFZDhUK0JnRmdYWnlkVUVW?= =?utf-8?B?WEV0ODJ0M0xOWURrZFUwQTloNzh2L2c0a0VBbW1adDg4Z2tVTDVXRWJ5b2Jh?= =?utf-8?B?TEkrT2I0TmpPRnREVGxPSktDc09NMEp3dy9iYnNVUlRibCtmYVpTaTU4bThS?= =?utf-8?B?NWR2RWl1OHdoMmd1MDVxWmFpeFpBd3ljMDJ0TWsrL1l3MUtDeEh1RnBORzJ1?= =?utf-8?B?Y3R6VDJMTVE5cU8reVJRcFdaQnIxTkoxMW0wZFVzMWh0Rk9wM0FwbXlnM2Ji?= =?utf-8?B?S3pDTVBZMVlCR1FyT2c2bkppR05SYTlrcVlXVUJIVWJJQUtNM3RraVRWQm02?= =?utf-8?Q?rZbmZEKCqQNlZ50513T7sxb4j?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LkxOnc7y3QAH5e/XOOYoTUBJJ9LwZ6OMqWDOOEFq8MhfIoRuhzBYrl7x4lxIURue8NpyA0Wdbc6oIjDAj9zERpq0tSn/cgc5SL6pzmSb5cOXJRjMfgqc+bkgraW24REDY2+y1oBeakQyFc6FIY6OxytpG/slRI2DiJo/a4Y4B/nEXEB10OoLLK7Bqik26YnRn9bmtiHmhG70dxTuSrUh5ZG4VAU0kY5ckGRsuxIGY4nRWlyRWuZomB3r6jKnGxBmsN69A/AGgGG9g5f596/hdO7XP4Wso1+UvpLsksft1ZYvp9E2X4HlDCU1uuLKXb5Fyz5jnxBKVkBXt5uXVE/D2AxKkuPuM0kQBIo2U/u9R9gcTOD+Hmzj91qFdrOk7c+RFuFkf5LWpDxAEEYc583SxzQHO22nfn7n+NaQJSyfFA8zVmY6lMoD/5IMtW0t/76xzN/POXYQOih89tfx2HhaiTy7EZgf0SzuRQIAG9ZsI2/tTslfILCs8ztDzScebJvG279TSKZCCyY742xjtMVKo1qob4h05+aOqX31CbLyEzqC8vEAJAJdZuQLKJ5zl3x+gwHtcWGZAQ04KkHxzcBiGRwOjMJ4xEgdmjy5zaoD49KgBmNwrvXkf4GMdUxo3gTPA/G8kc5CcLmFhRtAX5lqZM86dgiThrfZRo7qXbGSWvoGXiTjj9NARTpBZe61axLFNCZplPiIw0ZR3OLQ3q+M07VVmmJNJgNnF571HQ3xICW/diK8Wxhoxsg9aaI1MGAJmLvq9ELcm15nw3pWMUlfIsL9IFZXt0+37vtzRmpjNfpCw4uQ/lURXmlGk547KYKxfsQpmQGSXTVbBpRaKF341qNE9upw4ezDWO4cAMb748o= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4dce970-fbe0-4b92-8c7d-08dac764af24 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2022 23:54:07.5255 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: a72Em5XTVBYW21xWfGHXWcSa5lphix9WDtnUGOHbd2nHAsM2+vmNa5wzMD+BLDlKpmPHPpZRTBU5G4plKFjSzCaUx5QTuJ73WMO75+XbPAk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6390 T24gMTUvMTEvMjAyMiAxNjo0NCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE1LjExLjIwMjIg MTc6MjEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNS8xMS8yMDIyIDEzOjI2LCBSb2dl ciBQYXUgTW9ubmUgd3JvdGU6DQo+Pj4gU2luY2UgdGhlIFZJUlRfU1BFQ19DVFJMLlNTQkQgc2Vs ZWN0aW9uIGlzIG5vIGxvbmdlciBjb250ZXh0IHN3aXRjaGVkDQo+Pj4gb24gdm17ZW50cnksZXhp dH0gdGhlcmUncyBubyBuZWVkIHRvIHVzZSBhIHN5bnRoZXRpYyBmZWF0dXJlIGJpdCBmb3INCj4+ PiBpdCBhbnltb3JlLg0KPj4+DQo+Pj4gUmVtb3ZlIHRoZSBiaXQgYW5kIGluc3RlYWQgdXNlIGEg Z2xvYmFsIHZhcmlhYmxlLg0KPj4+DQo+Pj4gTm8gZnVuY3Rpb25hbCBjaGFuZ2UgaW50ZW5kZWQu DQo+Pj4NCj4+PiBTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0 cml4LmNvbT4NCj4+PiBSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t Pg0KPj4+IFJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4N Cj4+IFRoaXMgaXMgZGVmaW5pdGVseSBub3QgYXBwcm9wcmlhdGUgZm9yIDQuMTcsIGJ1dCBpdCdz IGEgcGVyZm9ybWFuY2UNCj4+IHJlZ3Jlc3Npb24gaW4gZ2VuZXJhbCwgaGVuY2UgbXkgZmlybSBh bmQgcmVwZWF0ZWQgb2JqZWN0aW9uIHRvIHRoaXMNCj4+IHN0eWxlIG9mIHBhdGNoLg0KPj4NCj4+ IEdlbmVyYWwgc3ludGhldGljIGJpdHMgaGF2ZSBleGlzdGVkIGZvciBzZXZlcmFsIGRlY2FkZXMg bG9uZ2VyIHRoYW4NCj4+IGFsdGVybmF0aXZlcy7CoCBJdCBoYXMgbmV2ZXIgZXZlciBiZWVuIGEg cnVsZSwgb3IgZXZlbiBhIHJlY29tbWVuZGF0aW9uLA0KPj4gdG8gYWdncmVzc2l2ZWx5IHB1cmdl IHRoZSBub24tYWx0ZXJuYXRpdmUgYml0cywgYmVjYXVzZSBpdCdzIGEgcHJvdmFibHkNCj4+IGJh ZCB0aGluZyB0byBkby4NCj4gVGhlcmUgd2UgYXJlIGFnYWluIC0geW91IHN0YXRlIHNvbWV0aGlu ZyBhcyBiYWQgd2l0aG91dCByZWFsbHkgc2F5aW5nDQo+IHdoeSBpdCBpcyBiYWQuDQoNCllvdSBt YXkgbm90IGFncmVlIHdpdGggdGhlIHJlYXNvbmluZywgYnV0IHlvdSBhcmUgbHlpbmcgdG8geW91 cnNlbGYsIGlmDQpuby1vbmUgZWxzZSwgYnkgY2xhaW1pbmcgdGhhdCBubyBqdXN0aWZpY2F0aW9u IHdhcyBwcmVzZW50ZWQuDQoNCg0KPiBNeSB2aWV3IGlzIHRoYXQgc3ludGhldGljIGJpdHMgd2Vy ZSB3cm9uZyB0byBpbnRyb2R1Y2UNCj4gd2hlbiB0aGV5IGRvbid0IHN0YW5kIGEgY2hhbmNlIG9m IGJlaW5nIHVzZWQgaW4gYW4gYWx0ZXJuYXRpdmUuDQoNCllvdXIgdmlldyBpcyBpbmNvbXBhdGli bGUgd2l0aCBhIGxpbmVhciBpbnRlcnByZXRhdGlvbiBvZiBoaXN0b3J5LCBhcw0KaGFzIGJlZW4g cG9pbnRlZCByZXBlYXRlZGx5IGJlZm9yZSBieSB0aGUgZmFjdCB0aGF0IDEvMyBvZiBYZW4ncw0K c3ludGhldGljIGZlYXR1cmVzIGZ1bGwgcHJlZGF0ZSB0aGUgaW50cm9kdWN0aW9uIG9mIGFsdGVy bmF0aXZlcy4NCg0KIkkgZG9uJ3QgbGlrZSB1c2luZyBzeW50aGV0aWMgYml0cyBpbiB0aGlzIHdh eSIgaXMgYSBwb2ludCBvZiB2aWV3LCBidXQNCmlzIG5vdCBzb21ldGhpbmcgdGhhdCBjb3VudGVy cyB0ZWNobmljYWwgcmVhc29uaW5nIGFib3V0IHRoZSB0cmFkZW9mZiBpbg0KcXVlc3Rpb24uDQoN Cj4NCj4gSSBhZ3JlZSB0aG91Z2ggdGhhdCB0aGVyZSdzIG5vIHN0cm9uZyBuZWVkIGZvciB0aGlz IHRvIG1ha2UgNC4xNy4gSXQNCj4gbWF5IGVuZCB1cCBtYWtpbmcgYmFja3BvcnRzIHNsaWdodGx5 IGVhc2llciwgYXMgbm8gc3VjaCBiaXQgZXhpc3RlZA0KPiBpbiA0LjE2Lg0KDQoqVGhpcyogaXMg YSBnb29kIGp1c3RpZmljYXRpb24gdG8gdGFrZSB0aGUgY2hhbmdlLg0KDQpFcXVhbGx5LCBSb2dl cidzIHN1YnNlcXVlbnQgb2JzZXJ2YXRpb24gdGhhdCBpdCBjYW4gYWN0dWFsbHkgbGl2ZSBpbg0K X19pbml0ZGF0YS4NCg0KPj4gWW91IGFyZSBhdHRlbXB0aW5nIGEgbWljcm8tb3B0aW1pc2F0aW9u LCB0aGF0IHdvbid0IHByb2R1Y2UgYW55DQo+PiBpbXByb3ZlbWVudCBhdCBhbGwgaW4gY2VudHVy aWVzLCB3aGlsZS4uLg0KPj4NCj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2NwdS9hbWQu YyBiL3hlbi9hcmNoL3g4Ni9jcHUvYW1kLmMNCj4+PiBpbmRleCBhMzMyMDg3NjA0Li45ZTNiOTA5 NGQzIDEwMDY0NA0KPj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9jcHUvYW1kLmMNCj4+PiArKysgYi94 ZW4vYXJjaC94ODYvY3B1L2FtZC5jDQo+Pj4gQEAgLTQ5LDYgKzQ5LDcgQEAgYm9vbGVhbl9wYXJh bSgiYWxsb3dfdW5zYWZlIiwgb3B0X2FsbG93X3Vuc2FmZSk7DQo+Pj4gIC8qIFNpZ25hbCB3aGV0 aGVyIHRoZSBBQ1BJIEMxRSBxdWlyayBpcyByZXF1aXJlZC4gKi8NCj4+PiAgYm9vbCBfX3JlYWRf bW9zdGx5IGFtZF9hY3BpX2MxZV9xdWlyazsNCj4+PiAgYm9vbCBfX3JvX2FmdGVyX2luaXQgYW1k X2xlZ2FjeV9zc2JkOw0KPj4+ICtib29sIF9fcm9fYWZ0ZXJfaW5pdCBhbWRfdmlydF9zcGVjX2N0 cmw7DQo+PiAuLi4gYWN0dWFsbHkgZXhwZW5kaW5nIC5yb2RhdGEgd2l0aCBzb21ldGhpbmcgOCB0 aW1lcyBsZXNzIGVmZmljaWVudGx5DQo+PiBwYWNrZWQsIGFuZCAuLi4NCj4gLi4uIGFzIGxvbmcg YXMgeW91J3JlIHRhbGtpbmcgb2YganVzdCBhIHNpbmdsZSBDUFUuIFRoZSBicmVhay1ldmVuIGlz DQo+IGF0IDggQ1BVcyAoOCBiaXRzIHVzZWQgZWl0aGVyIHdheSkuDQoNCkFuZCBzdGlsbCBpcnJl bGV2YW50IHdoZW4gdGhlIHNpemUgb2YgdGhlIHBlci1jcHUgZGF0YSBhcmVhIGRvZXNuJ3QNCmNo YW5nZSBmb3Igc2V2ZXJhbCBjZW50dXJpZXMgaW4gdGhlIGFyZ3VlZCBjYXNlLg0KDQo+IEkgdGhp bmsgd2UgbmVlZCB0byBzZXR0bGUgb24gYXQgbGVhc3QgaGFsZndheSBmaXJtIHJ1bGVzIG9uIHdo ZW4gdG8gdXNlDQo+IHN5bnRoZXRpYyBmZWF0dXJlIGJpdHMgYW5kIHdoZW4gdG8gdXNlIHBsYWlu IGdsb2JhbCBib29sZWFucy4gV2l0aG91dA0KPiB0aGF0IHRoZSB0YXN0ZXMgb2YgdGhlIHRocmVl IG9mIHVzIGFyZSBnb2luZyB0byBjb2xsaWRlIGFnYWluIGV2ZXJ5IG9uY2UNCj4gaW4gYSB3aGls ZS4NCg0KSXRzIHZlcnkgZWFzeS7CoCBBbGwgb3RoZXIgdGhpbmdzIGJlaW5nIGVxdWFsLCBzeW50 aGV0aWMgZmVhdHVyZXMgYXJlIHRoZQ0KbW9zdCBlZmZpY2llbnQgb3B0aW9uLg0KDQpJbiBtb3N0 IGNhc2VzLCB0aGluZ3MgYXJlbid0IGFsbCBlcXVhbCwgYW5kIGxpdGVyYWxseSBhbnkNCnRlY2hu aWNhbGx5LWNyZWRpYmxlIGp1c3RpZmljYXRpb24gd2lsbCBkby4NCg0KDQpJZiBhIHRyYWRlb2Zm IGRvZXNuJ3QgcGxhdXNpYmx5IHdvcmsgd2l0aGluIGEgZGVjYWRlLCB0aGVuIGl0J3MgcHJvYmFi bHkNCmEgd2FzdGUgb2YgdGltZSByYWlzaW5nLCBhbmQgZGVmaW5pdGVseSBub3QgYSBwb2ludCB0 byBsZWdpdGltYXRlbHkNCm9iamVjdCB3aXRoLsKgIEVzcGVjaWFsbHkgYXMgaW4gdGhlIHBhc3Qs IEkndmUgYWxyZWFkeSBnaXZlbiB5b3UgYW4NCmFsdGVybmF0aXZlIGNvdXJzZSBvZiBhY3Rpb24g d2hlcmUgdGhlIHN5bnRoZXRpYyBmZWF0dXJlcyBhcmVuJ3QgcGVyLWNwdS4uLg0KDQp+QW5kcmV3 DQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 16 00:27:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 00:27:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444093.698916 (Exim 4.92) (envelope-from ) id 1ov6HJ-0002C7-Td; Wed, 16 Nov 2022 00:27:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444093.698916; Wed, 16 Nov 2022 00:27:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov6HJ-0002C0-Qq; Wed, 16 Nov 2022 00:27:45 +0000 Received: by outflank-mailman (input) for mailman id 444093; Wed, 16 Nov 2022 00:27:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov6HI-0002Bu-5G for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 00:27:44 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7aa0401c-6545-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 01:27:41 +0100 (CET) Received: from mail-co1nam11lp2170.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Nov 2022 19:27:34 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by DM4PR03MB6858.namprd03.prod.outlook.com (2603:10b6:8:41::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 00:27:29 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860%5]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 00:27:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7aa0401c-6545-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668558461; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=bDY1n0zx5XrQfBGzlxZ1xOw4SH5C4MpYOVQornj6lmM=; b=CjU2SCSKfP8hJyaYr8b6IjPvDW8ZmF2MvL0Z6ZmWLkES0J14kUxgWhQh AKoaCgVGToNJXG/t/UF1WSh/McI9T+XGDu6NyGEj+I2+6FLKc0wnsuFqW XKZ+LbS+crQ+AQsssT0rP/BgppxO8TifohfAcRXbeIJPKsmK34E2C8XAs E=; X-IronPort-RemoteIP: 104.47.56.170 X-IronPort-MID: 87440676 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:HZYwA66qJJqrU111g7uXSgxRtN7GchMFZxGqfqrLsTDasY5as4F+v jBMDWmGb6uMamf1e4x+Povg90ID7JfUmt9mQAE5/itnHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkS4QeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m8 qdAJD0fVB66l9m03+q9F7Ro2dhkFZy+VG8fkikIITDxK98DGMmGaIKToNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Okkooj+CF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJNSOHgqKE06LGV7kdIAkUSZXCbnfuWlEi1cZVRe nEQ3wN7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OcWSDowx xm2ltXmLTV1tfueTnf13rWeoC62OCMVBXQffiJCRgwAi/HhvYUygxTnXttlVqmvgbXdAirsy jqHqCw/gbQ7jsMR0ai/u1fdjFqEuZzhXgMzoALNUQqYAhhRYYekY8mj7gHd5PMZdYKBFADe5 D4DhtSU6/0IAdeVjiuRTe4RHbavofGYLDnbhl0pFJ4kn9iwx0OekUlryGkWDC9U3gwsI1cFv Ge7Vdtt2aJu IronPort-HdrOrdr: A9a23:Q/A3XqvsRVrEU9YUD0hisTao7skCXoAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeF+aP3CB+R2zYZSndqza05+W bIvgTl7uH72svLiyP05iv21dB7idHhwtxMCIiljdUUECzljkKFdZlsQLqLuREyuaWK5EwxmN fBjh88N4BY6m/XfEuyvRzxsjOQngoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L gj5RPbi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZDIMu60vFjLA BdNrCa2B9kSyLdU5kfhBg3/DWYZAV2Iv5BeDlbhiXa6UkMoJkz9Tpk+CVWpAZ9yHt6cegF2w 2MCNUXqFkFJPVmEp5VFaMPR9C6BXfKRg+JOGWOIU7/HKVCIH7VrYXriY9Frd1CVaZ4u6faoq 6xJm9wpCo3YQbjGMeO1JpE/lTER3i8Ry3kzoVb64JisrPxSbL3OWnbIWpe2PeIsrEaGInWSv yzMJVZD7vqKnbvA59A20n7V4NJIXcTXcUJspIwWk6IoMjMNor239arOMr7Nf7oC3IpS2n/Cn wMUHz6I9hB9FmiXjvijB3YSxrWCzjCFFJLYd3nFsQoufsw39d3w3koYHyCl7G2ACwHtLAqd0 1jJ76imr+npACNjBT101k= X-IronPort-AV: E=Sophos;i="5.96,167,1665460800"; d="scan'208";a="87440676" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D3uluyybXsxoqMah8vfWsgxJNe6kmO78nbaNxpmnu2tHcmnLl5CBTxe5+TzZcntkyng5r1OHLvS6lgkW/Ot2mbqJ88NzrmEOBezWtTxCOmGp/mweyaMJ4mLkNLyk3P4uaFzKrbmDsZ/SWWELN5/w7mV7i3n+kXEMVVnevleVI1kDDMEvykGkci9uEGmytmJEYgnAHrmOhI4TyM4+warvHfFP0xum35vEJU3pWPIdWMsYhhJF2e8aklnT0kaSA9fFzsszhkdwDLXtqkNqEfcszNNkRosdhPLEu/kTHagBkvT/8QwLE3GsWhmTJNlysjIVCCGkzvEvgHd/tXLe+Qmx3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bDY1n0zx5XrQfBGzlxZ1xOw4SH5C4MpYOVQornj6lmM=; b=UjduwSwfdfu4pAkvtAzH05EQTnJodKwnEtJp/9p3Q/33eJCoZz3NQoSIVpPuaoZG8NPCXzeOHK3DSMqIcZr1y0Kc6ryxYDh1OfetdsyjeayYaDRiUJYBwKAndsq7WTBK/m9FJ11Xry3uJIWKbSuA0TTpsncqO1/XHGjOntsMhx3e7ZyDxQ9XavJqfRcYxN2w+E+9R7dzCFAcAuBoXhG15hqEUiOm5lNLNK1TUE9P4wJ+hAypEo5FPAXIbkk4Og85JG8tZasRir6GQyvgIeoQEVFK9o2h2pgxNrrvXobftNn+/50IY768OErEwzwKZLHZ0he8KfbtzVkLincsbDg6iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bDY1n0zx5XrQfBGzlxZ1xOw4SH5C4MpYOVQornj6lmM=; b=XzWxQlamHy2JG+l/wOe+mb+YMCInxmIBExueQOJTb5ISn29t2GsYDyUKPDRTAWInqfdC295qA4AQqbn21CdiSuXOqCaSLLgHauU9vv59MN9552bbRnjR59n+anWdksy6KgHdQJqorzS2Q2HgRIZRGDQs2xIvdF/lD1e+81+sAws= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: "Henry.Wang@arm.com" , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH for-4.17 v4 0/2] amd/virt_ssbd: refactoring and fixes Thread-Topic: [PATCH for-4.17 v4 0/2] amd/virt_ssbd: refactoring and fixes Thread-Index: AQHY+PYA4G97GRMYN0qVEBZj+Syg765Asn+A Date: Wed, 16 Nov 2022 00:27:29 +0000 Message-ID: <463e03d5-7a07-f26a-de24-13c4a12e8c20@citrix.com> References: <20221115132657.97864-1-roger.pau@citrix.com> In-Reply-To: <20221115132657.97864-1-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|DM4PR03MB6858:EE_ x-ms-office365-filtering-correlation-id: 46f5e98f-4022-485e-b91b-08dac769586f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jnirkrFlEFXg9k7CAXaNMhIjjqnP66TKhfogoQCoZvwyOlc6kq4ENdiGG1v9M0gvKufF2+1rKWeBbN27OOldVVqkX7fIqwo4TB1Qld5qCb2HvFonTBQ5Dega3YOzadTVHuppZZnf0wptiaqug+rXjS/IJL4UiHR0ib4POU1jUJq9nnMPO+2VrhI/d6G243rbuFozGtoCnvW39ulMqvAbVXEkIYpbfkEmKV+3y+vjQ2SccknOOSvIWHacKiimRrU1DhOpPIj/aa7WGXsRHFmO6j6Zj3Wue7Bja/JTrgoCtNxc08xHQ3kSos8voKnAclZKgMWXd9nywpvLZPrF1OCqshKNrYTHzI909llv6jpORiMFJuBgZieGZolgcmlKZmUG5NYLsp5e7xsa8raq1j13EvR5UZZCx+53jVeWOIPAMloM2j82/UgaSYNPQJRHJCTjrFQ8aTp6S3VlONneNvw0t/ZF1qI9nwXaLZ17Qp8/FWUIhwLSTWXcP+wVM1CFOj93kVHBBSuHBnExz8vKAtVnklOef1EajFgF5pMdO6YfCBe1fbcwdQYfcOOmjIH0Sz2oFcGyMVBVfLojZJnDrbf3Oj+Nz7e88zyNU0Sk1tfw2h0HbyBDi8HRo0lEL7PoI9v1RkXN9P/rL8VlZG8PLuKpppzrdjBk1nOvZxF6eP9LTFMlmG/M03GqHhXcYiKZxB9wbwz+e0ULfz87nOT6OtoJuVoxUHNxDBkIwLoFmvWju0UYrtcXkme6VW8PERpogdTzGBkBpQOFGrz1JW4Men+F8/P1GMvqUyF73eylmeZrs+HCgI9eTMxqLnsXcPCZQFY4soGW0XyN0N2I1TvA2fCDHg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(451199015)(6506007)(316002)(186003)(5660300002)(26005)(66946007)(66556008)(66476007)(66446008)(6512007)(4326008)(64756008)(8676002)(53546011)(38070700005)(31686004)(110136005)(36756003)(6486002)(478600001)(54906003)(76116006)(91956017)(8936002)(41300700001)(2616005)(2906002)(71200400001)(83380400001)(66899015)(86362001)(122000001)(82960400001)(38100700002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MXhoaVNoTTBRdUVLcHFxZElHTWczZ3JITVVCaWRVeFpzbUt0VkVtdS8yNlQw?= =?utf-8?B?ekhBY3hFM3dHT3BwZHp3cFNaUGNwNUV4MmR0d095dlNLZGFFaHMzRE4xejVo?= =?utf-8?B?cWRkZHNwSTJoeDIreHprSmVTazFxNUNiY2tMNUpldVpHSmZaNXdwcTBQVEdY?= =?utf-8?B?MkJMSTJVVHpOWmorWVhmK3RFR3RJTjIxNXF5YnRNMUhDNHA4YXRqSXFhMGZm?= =?utf-8?B?RzV3WU5ZS0U1b2dUa0ZmdDBadFRieDJKOXVjdWlYVmo4Z0VqR0ZUaEN4SjhS?= =?utf-8?B?WFNXN1h1S05ZNjAvanBwVVdYNmVkNTJuc2thb1dFWUQwVW1RYlFzNGllMDhI?= =?utf-8?B?ZnNiYVZKT0ljeThnWTBZQUdkWjNEcVZmVUZ6c1Y3RXM4WGNyaXRZdzM0L2Vs?= =?utf-8?B?cTA2WEd4UURXSm1ISnBJcXlKREZGQk5wRldkTlZvY0RBYW55M0YwMlhEUlVa?= =?utf-8?B?YnYvdlgzKzNkK3I4WmNkdFgwUW5xbE10ellKZU1Gc2dTOVQwNGdyWWRrRGd1?= =?utf-8?B?bE95ZDg5TEVuMW0vR0hURHpCYklOU1JwOHNxMG5nZ2FDdENscUs2c2FndEt4?= =?utf-8?B?WEhRL0VFR0Q4NmI5ZVlJemR2cHEvNXdWbTlTZWlBNVgzY1k3alhHVmFQYy8r?= =?utf-8?B?R0JWSm1XeWpHb2U3bFhUeHM5amVickNsRSsxdHp5WUIrUHZ5bGJaeFdlZVdj?= =?utf-8?B?ZmQ5Ti9Ka2dCTUpZdGtpTlNZZG5nUGNUbmE2b3B6TlVldlZvVmdhSHFmT2g0?= =?utf-8?B?TTZSemhxYjhCdGZzY2pYU2lQUnhaR0FDQllzbk81eTlWV3k3Z3h5RlkrZWhn?= =?utf-8?B?Rnd4SnMxNDkzUUlwSlhRUTA0YkZVMTd4bUJEU3B0RmJIdHFBb3pqZ1JXYzd0?= =?utf-8?B?cnIzS205NFVlQlVZN01JYVZUV0E4NktoekpDV09Wa0VKWW9pY2plWlhvdTNo?= =?utf-8?B?SnhKeEVOMmJrWVBRS3VObWs5aG54enA2a3crUmoydVRhRVk4cUdsYStvbDJ1?= =?utf-8?B?RzN1STVJalFZMmU4MGVidzNOdk9HWlRMWno1YWN4aEhmMUlQSHo4bkNXYUZz?= =?utf-8?B?Y2RkUDhLK3NQN21zbHlaUG01MkZuT0laNEQ3ZytJWE9KTm1RK0gwaVpYZi9L?= =?utf-8?B?d1p2S1dsNERIU2R6bkdDK2JQUXhMekJMbTVwNFZpaVV2ZWFUZVZFYzQvL2to?= =?utf-8?B?REh2QXdLZTNJc1I0enRid1J2R1dRRjFTUFdkeEFSV01DZEl3U0swUC9QY0th?= =?utf-8?B?MmhibGJwVGpyWkk5bHZvY0p1RDVYK05Tb0VLeWY3SHJoR29tMEEyVGtxblBQ?= =?utf-8?B?OWx3RUNhM2Z5Kys2Q21HK2FBcmVUZ2JhVU5HMW0yd3dyVFRRb3hNY0xMOVBO?= =?utf-8?B?SVdIRXRYNjd4bFlHMGxUbHhLcGVvZGt6aDJoalo1VmlwQWI2R3Zvb0ppRlVz?= =?utf-8?B?bVFqdkxxaXBlRUJoaGhadFQ3OUdzUE5VWHJPbExlRkhScUJadnZnWGRrTzhT?= =?utf-8?B?RkRzSGwvWERpODFCdURtMUdQdTR1S2xORHFKR0IrWWNyVGM4VmRTZjRRbXha?= =?utf-8?B?S25aYktSSVhsMzkxZFd1R2dmU0I2UFJvL0dHV3lnWVpDRUV6eUJ5TUowbGFH?= =?utf-8?B?NTdBektkQlJVRHZSRHhpeUZ1ZFJzOWtmZDNwQXZyVTlpSjNBeDU4enNnS0cr?= =?utf-8?B?WGxVendoNS95MHMzZit2SzUyZmw4UmltcHJGVjJPOGx5NEptN3B4SVF4eEJW?= =?utf-8?B?emRab1Rsb29HYklvdDNyZTFiRDN0WVJwc0c1SkVqZUlXK0tnbWhNNENCWFVz?= =?utf-8?B?eTBHbkNRWjkrTkI0QVNid3Z2dGVmU1JyWW16d1Q1TDc4M2FBZkJnbzFCKy9H?= =?utf-8?B?Wkt1bmY4NE5YeEV3eXBJelBMRTVEUFoyR3U5MU5SYnIxNXllSFQwcGFEV2xS?= =?utf-8?B?aXZwTjNiclk1MUNLNDhCb0ZXT043SDNSSW9iQUVEdDZuZUpobHFyNEJNYzFD?= =?utf-8?B?V0Z1ajhCQnZ0SFZHMDF1QS8vcFBCcEoyZjlvR3Z6T3pwMHRsRjlCdnBwZDY4?= =?utf-8?B?bzZ5ZjNnUEFUY2lDb21STjU4QUlQaFZ4RnA4VUkvYVIrQ0xSL3lWL3NmVGpO?= =?utf-8?Q?N0F/5Xwxy1+tgc6GCiJsEQgEI?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 3mDotj3bvELA49FXkrwoEWMOVBUnh/7mDM+jrZNmjwfv8hp57AyhVqxnnnlsPCM1wUj72zR2hmlYXnXx17NVg5yjqH4Kx8skczo37ePnhrjzc0iDenXKNIu7M7ut3xr/iHYQ0vhxHrk0tqaGTvrIYqygLTdXnBwIIKfK4wbRWSm0H5NEAqSB21W7whzagRBKeHo8AgKlLRVZSEDHqlx/QlxYWNOkNuJT8VRsrBBrT4V/gvj1arKJTmG4zVWW4HOP3guCuS5GbeAleWdV3b8CzFsvdzq62w4vIqOnTyevx99S4uYAGigJK+YFGMSVvbDQu4DyAt0uO97mAQx5/cCijlmSxdrUc7W/hjxb0/c+Eb5xEzs1mhvstQoqkhENPI+nuJCRAei/R846C4K+FvDq4GhbSSMPwIkP/hK47CjUkXD7DDvmlcC3hwoHVVE9yKHgwP7WBJVKFnu9DpShRAeDQNVcbKqkKmGS7gr5n50wW+Q6xytTDFskuq4wCeO2JOU77w/Oi2FdjXY/qOR5pZCE/CG9PAoLncTOakTJlaSUF3zR+dA3cLaUhCcUynUEaM9gGVsgCNmX2DljmcqNbl/o0syZ/FZd/j9di2EQHOCOd/2TxrEXSxRMV7+XkGhbv0pHEYjhCbvnZ6hTGaSlTzM5d/WXN+dKP8iFWmh7R/zWhpffDR/yIWU7Ou2UivDMinpH7VuEdbLAVD/bU3s4OG/eQJxByN2xXbEKoUkkUkTLCheXsn8ULjaJAmryr350fDAY24FQqj3WDMead3hDj5XIdneXx8n8uX+bPnrfvJGWMR98qzCYS+sTHI0oNP9J8J1ikmj6/jbtR+zWAPZFhJTuydc3Q4e6bk6aHqwIslwn7Lf9G15vnnBs+1DV919GHh15DoziPQhTAmQzpbzay9F+7A== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46f5e98f-4022-485e-b91b-08dac769586f X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 00:27:29.4931 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LMzpNsi4nHarbNwsrSwwYDxY2L+Y0thVETCUzTIWn1HWGoXr3fy7dVzvAx72Vs0T6FdN0WAmCbA67l8xjKSyEvlQINrbOZFhv7CMLzbu0iE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6858 T24gMTUvMTEvMjAyMiAxMzoyNiwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBIZWxsbywNCj4N Cj4gSnVzdCB0d28gcGF0Y2hlcyByZW1haW5pbmcsIGFuZCB0aGUgbGFzdCBvbmUgaXMgYWxyZWFk eSBBY2tlZC4NCj4NCj4gRmlyc3QgcGF0Y2ggZGVhbHMgd2l0aCBtb3ZpbmcgdGhlIHN3aXRjaGlu ZyBvZiBTU0JEIGZyb20gZ3Vlc3QNCj4gdm17ZW50cnksZXhpdH0gdG8gdkNQVSBjb250ZXh0IHN3 aXRjaCwgYW5kIGxldHMgWGVuIHJ1biB3aXRoIHRoZSBndWVzdA0KPiBTU0JEIHNlbGVjdGlvbiB1 bmRlciBzb21lIGNpcmN1bXN0YW5jZXMgYnkgZGVmYXVsdC4NCj4NCj4gQW5kcmV3IGhhcyBleHBy ZXNzZWQgcmVzZXJ2YXRpb25zIHRvIG1lIHByaXZhdGVseSB3aXRoIHBhdGNoIDIvMiwgYnV0DQo+ IEknbSBzdGlsbCBzZW5kaW5nIGl0IHNvIHRoYXQgY29tbWVudHMgY2FuIGJlIG1hZGUgcHVibGlj bHkgKG9yIHRoZSBwYXRjaA0KPiBhcHBsaWVkKS4NCj4NCj4gVGhhbmtzLCBSb2dlci4NCg0KVG8g YXZvaWQgYSBmdXJ0aGVyIHJvdW5kIHRyaXAsIEkndmUgY29tbWl0dGVkIHRoZXNlIHBhdGNoZXMg d2l0aCBzb21lDQptaW5vciBub24tZnVuY3Rpb25hbCBhZGp1c3RtZW50cy7CoCBJbiBwYXRjaCAx LCBhbiBleHBhbmRlZCBjb250ZXh0DQpzd2l0Y2hpbmcgY29tbWVudCwgYW5kIGluIHBhdGNoIDIs IGFuIGFkanVzdGVkIGNvbW1pdCBtZXNzYWdlIGFuZA0KbW92ZW1lbnQgaW50byBfX2luaXRkYXRh Lg0KDQpJJ3ZlIGFsc28gY2xvc2VkIG91dCAjOTAsIHdoaWNoIGNsb3NlcyBvbmUgb2YgdGhlIHJl bGVhc2UgYmxvY2tlcnMuDQoNCkFsbCBvdGhlciBidWdzIGNhbiB3YWl0IHVudGlsIDQuMTgsIGlu Y2x1ZGluZyB0aGUgdG90YWxseSBiaXphcnJlIG9uZQ0Kd2hlcmUgdXNpbmcgY3B1aWQ9Imhvc3Q6 dmlydC1zc2JkPTEiIGluIHRoZSB4bC5jZmcgZmlsZSBjYXVzZXMgSUJSUyB0bw0KYmVjb21lIGhp ZGRlbi7CoCBJIGNvbmZpcm1lZCB0aGlzIHdhcyBwcmUtZXhpc3RpbmcgYmVoYXZpb3VyLCBidXQg aGF2ZW4ndA0KaW52ZXN0aWdhdGVkIGZ1cnRoZXIuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 16 00:36:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 00:36:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444097.698927 (Exim 4.92) (envelope-from ) id 1ov6PC-0003qu-NP; Wed, 16 Nov 2022 00:35:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444097.698927; Wed, 16 Nov 2022 00:35:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov6PC-0003qn-KQ; Wed, 16 Nov 2022 00:35:54 +0000 Received: by outflank-mailman (input) for mailman id 444097; Wed, 16 Nov 2022 00:35:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov6PB-0003qh-DU for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 00:35:53 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20605.outbound.protection.outlook.com [2a01:111:f400:fe12::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9eb4e6de-6546-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 01:35:51 +0100 (CET) Received: from AS9PR06CA0359.eurprd06.prod.outlook.com (2603:10a6:20b:466::29) by DB5PR08MB10094.eurprd08.prod.outlook.com (2603:10a6:10:4a2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Wed, 16 Nov 2022 00:35:46 +0000 Received: from VI1EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:466:cafe::fe) by AS9PR06CA0359.outlook.office365.com (2603:10a6:20b:466::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Wed, 16 Nov 2022 00:35:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT056.mail.protection.outlook.com (100.127.144.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 00:35:45 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Wed, 16 Nov 2022 00:35:45 +0000 Received: from a5e6ea8206c3.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4E3A8B50-B141-418F-8B47-59A6B86E16A3.1; Wed, 16 Nov 2022 00:35:35 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a5e6ea8206c3.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 16 Nov 2022 00:35:35 +0000 Received: from GV2PR08MB8001.eurprd08.prod.outlook.com (2603:10a6:150:a9::12) by AS8PR08MB8350.eurprd08.prod.outlook.com (2603:10a6:20b:56c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Wed, 16 Nov 2022 00:35:32 +0000 Received: from GV2PR08MB8001.eurprd08.prod.outlook.com ([fe80::ac6e:a062:a5a3:8a3d]) by GV2PR08MB8001.eurprd08.prod.outlook.com ([fe80::ac6e:a062:a5a3:8a3d%5]) with mapi id 15.20.5813.013; Wed, 16 Nov 2022 00:35:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9eb4e6de-6546-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4GstJ0BQ3ftqubH7tb7ynFFzEiCgxfh4cUU4P/IiaQY=; b=f1blOmlgwxfGYfBYEpWkpsbNJK1BKCJOy6VBo+sPud8mKXAaNRtoBPYauHScBmvW3WJzQJ5COvkqwNQHUOgWP2WZwZxHtvIlpjdyrRMXIYg2wurPx1v7NFefba2/v1ew9pMyhN/be3fD8N9XVcKQghBJV71ubDnXxvnDgGGK8fs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AFFYVos+HNR5/f5BAuMKOaHA/PnXpwtKQjgbRWW0BnFNSUQ8LdIZ4E8NCX6pT4EF6FPttUbfSmGQ4P0URyCEoTI/PMT4bhoLlf+yTEoX7NWliz1r99EWsLrku0ysVrKiCfuhA4Eg/PK7SsnCtR7aku7YckoDiVqY2k2znmxEiLoxqNzLyny+eCMhyFG975Ai/F5zMaQdYVRe55jG9FnELtaknN7QkbPubXB8KQRCTLOhsJhW8iNnXmkmJU0Vc6iCDKrK4nEyhmHOqH8heHJ8Xk3gUIwe6TSjORcKhk22irayygqMEp2YJ2jhUQjtDUdgqLnVKesVANqtlremtiM/7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4GstJ0BQ3ftqubH7tb7ynFFzEiCgxfh4cUU4P/IiaQY=; b=CPekPaBe9niEEEmiZtYvtfr67BRFjYvgO8zBvDFNOfJlc0rFISWauuGUzQAy9rgh4hc0cbYpUg9r4h7AbazYUI9G/BDnmK5bJrDgGaCdjsWR3B9fjhkMbr4vsjuKuD71B1MOhNtbZW1eHKltXen4H75PK4YCh5q+ic/hzxY4n5w4g6xLVSA0FRkAuK2ViXr49MSF+8aQle5mouO2GTF/l2AevP4zrymeXADfIirXlh+qysYD641ApFwGVM7TVVwmGXXTuVu2qL1vgOrOwneqXK6+e+pojBZxP8X42JTr6RIOk9fQBQilL0LBhySLec51iBR3vJuDi+ghU2nlxwfdzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4GstJ0BQ3ftqubH7tb7ynFFzEiCgxfh4cUU4P/IiaQY=; b=f1blOmlgwxfGYfBYEpWkpsbNJK1BKCJOy6VBo+sPud8mKXAaNRtoBPYauHScBmvW3WJzQJ5COvkqwNQHUOgWP2WZwZxHtvIlpjdyrRMXIYg2wurPx1v7NFefba2/v1ew9pMyhN/be3fD8N9XVcKQghBJV71ubDnXxvnDgGGK8fs= From: Henry Wang To: Anthony PERARD , "xen-devel@lists.xenproject.org" CC: Wei Liu , Stefano Stabellini , George Dunlap , Julien Grall , Jan Beulich , Andrew Cooper , Bertrand Marquis , Petre Pircalabu , Alexandru Isaila , Tamas K Lengyel , Volodymyr Babchuk , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Juergen Gross , Paul Durrant , Christopher Clark Subject: RE: [XEN PATCH for-4.17 v2 0/6] Fixing some licences issue in public headers Thread-Topic: [XEN PATCH for-4.17 v2 0/6] Fixing some licences issue in public headers Thread-Index: AQHY73rCghjYe94nkUWe9AEw9k4cv65AxvZg Date: Wed, 16 Nov 2022 00:35:30 +0000 Message-ID: References: <20221103115204.49610-1-anthony.perard@citrix.com> In-Reply-To: <20221103115204.49610-1-anthony.perard@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C1D8312C94FD2540A2EECC56103BC50E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: GV2PR08MB8001:EE_|AS8PR08MB8350:EE_|VI1EUR03FT056:EE_|DB5PR08MB10094:EE_ X-MS-Office365-Filtering-Correlation-Id: d0915164-611c-4d9b-5a54-08dac76a804c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ANJR92Cd2YxjkRlPPvvt5Z0kOxcgvW1r3DrreFhOd70zttKpBERlmQNi4CZjt9A+Xn+280g8Mb+E1riSI0D2ezwVX7tToYqgpzVSHJePlnKBAJqvEIJay98so3GPCHqKZawRBle2x1GLqc4TPiGb2e4Ce/BFGuhq0hkDvO6qSag7rzNMV0bWknZuqxI7TUn5rybHJbew0P7sLzxotXQ7e6cs46xglt3thJYv5p+p5OlsHa0Ch996Pnht/LXxumtbbCiogR8gGmOm2AUgqcc4Gk1wKk+9j6Y5OPnwbWYw/SHTvY04/s09ddS3bJnOmPTbnChHw4E72BvqMdJrz2lwVXQ40cLc2DMd0hGRUu99oI1QbgFFt6WVR4s984+rQ2pC5QfNyhRA8zc02tQUSrBOR0smjFoQACAEbGTkBbXV3Sm1hmi2JvXofh+VdaY7kPm54PjPcp8gZFn1PTWpoGdMBUabGXb8LpAAl04yjxgTya89fRt7MomcSdQTyHtsvoe+8vBzjkCuHp72S+Ijc2uBcp2iIKx9K+JbCa2AJvaybPUiITVoPWLg9d3UZj5bYNJM3pXPB/AoFtn6yvl4mPhb6KY8y88woYPfrVVQ8jbsw0207EbVkMIYdcFjzRbN7aBCU6hZmo8cGiss9k/LxEtiPKkVf7T40deYtBkAaZ95bpcSeIf5PbFutO+gm3WwQQ5ILl5ecZdkX1uWJY8w4ZDdqNhVml3wComNuhDl1Mp6d4mlNGcx8aG36QThfS7e9Z/2KM38rKz6fp/3jGjEv+syLzzbcY+4keXdjGpLb0WUCme5IA4LkZQSIE1LkD04OI5nxEnKt0CsVcq4lSQW1Ps/vg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8001.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(366004)(346002)(376002)(396003)(451199015)(8936002)(52536014)(38070700005)(7696005)(86362001)(122000001)(33656002)(38100700002)(6506007)(71200400001)(5660300002)(2906002)(966005)(55016003)(83380400001)(66946007)(41300700001)(478600001)(186003)(8676002)(26005)(7416002)(4326008)(66556008)(64756008)(316002)(76116006)(66476007)(54906003)(9686003)(110136005)(66446008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8350 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e4f49235-f0e8-450b-ed8d-08dac76a7722 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EL0rNC9a45+14j1Beqznm5uymWnJdeetpZbmIEVCjd8kBOJLOBHvHH7WlALHxWbgpqdqSsk9pqv4YPB1SJ38aPixWeYnTTK20BgOMHyRquVaChL0mPXV+czE1O/d4uq0NebmOtpYjZsjPb+T28+sfbYZ9RfdVid+sDuKR8TB8plsGWO+4fHgiMIuRDOuF6/IJ/JElxLNKqi0h8tP2qp7+iW8TiWtHK4hp268gYNXJBGZWkV1VKhzcw1BiS2fiNCI1JYxfbqJzUToa/4jDO3w+lHCjNSp6uxmGuv1u98p/E0sRCYIQHhLjlr9AuLYdq6KXT/tdKyD3gvVtXyu981lxUrCJ4zv6D9hYXtLqngnnIQeOvhupC16QWIkwivrcEKHW6EQc92NBIkr/MwffwgjfiHCGbnxkmKn6j98GT0gRWqyCjArfeF94nlceAcq+V5m7JRsOuZh4+/KqvqwONkKoxJYKbyID0srAuTMRaV39lvTIoCPlXvqCWEMBOUyHuinbzhNcUhRB+mjVXI6zsJ9j9WOJlwGwhDWlO9ycXRbRDn4h7qBqpmEZyK8qUV8nEQPuP8kY3URh+shxsEug8vP9+pKV5ICcDN/jobhZVwDLMa0/Eg3p+re788v/yUKX0f/eWZbQ8ddm6tuf2V8roE5Pw89YFg03oYe/afUZ6VcqdhZjYd/oGgDgllse1X7kb+2Rf8SbjSULb+JI4VqZk3NncLJFF4x66rtuvp787rjK1gWr+gjdw0vRGv0HVcBORbnlxa1k1C1gbOmHISGR0COZaMLUsEcGOyJyEw3LnRzG7CLpikOfjjocfStMORcsL5++p3Z9gI39HavyaMpyrTJkw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199015)(46966006)(40470700004)(36840700001)(40460700003)(316002)(33656002)(2906002)(36860700001)(110136005)(336012)(186003)(966005)(47076005)(83380400001)(82310400005)(478600001)(55016003)(107886003)(9686003)(86362001)(82740400003)(40480700001)(356005)(6506007)(5660300002)(8936002)(70586007)(70206006)(81166007)(52536014)(4326008)(41300700001)(7696005)(54906003)(26005)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 00:35:45.7888 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d0915164-611c-4d9b-5a54-08dac76a804c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10094 Hi Anthony, > -----Original Message----- > From: Anthony PERARD > Subject: [XEN PATCH for-4.17 v2 0/6] Fixing some licences issue in public > headers >=20 > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git > br.licences-fix-public-headers-v2 >=20 > Hi, >=20 > Andrew pointed out some licences issue: >=20 > https://lore.kernel.org/xen-devel/b58f5340-d4fa-df9d-89de- > 6137005add77@citrix.com/T/#u > tracked here: https://gitlab.com/xen-project/xen/-/issues/35 >=20 > So I attempt to fix them with this series. >=20 > For 4.17: > This mostly change "documentation" so little risk for those patch, ex= cept > "xen-foreign: Capture licences from the input headers" which changes > "mkheader.py" which could generate broken headers. Yes, and I agree this series should go into the 4.17 to resolve one of the release blocker pointed out by Andrew: https://gitlab.com/xen-project/xen/-/issues/35 >=20 > Anthony PERARD (6): > xen: Add licence information to public/errno.h > xen: Used SPDX identifier in some public headers > tools/include/xen-foreign: Add SPDX identifier to generated headers > xen: Add licence header to device_tree_defs.h As Grant Likely from Linaro has confirmed the license change, for the whole series: Release-acked-by: Henry Wang Great thanks for taking care of this issue. Kind regards, Henry > Rework COPYING installed in /usr/include/xen/, due to several licences > xen: Used SPDX identifier in public headers >=20 > tools/include/Makefile | 1 - > xen/include/public/arch-arm.h | 19 +------------- > xen/include/public/arch-arm/hvm/save.h | 19 +------------- > xen/include/public/arch-arm/smccc.h | 19 +------------- > xen/include/public/arch-x86/cpufeatureset.h | 19 +------------- > xen/include/public/arch-x86/cpuid.h | 19 +------------- > xen/include/public/arch-x86/guest-acpi.h | 19 +------------- > xen/include/public/arch-x86/hvm/save.h | 19 +------------- > xen/include/public/arch-x86/hvm/start_info.h | 19 +------------- > xen/include/public/arch-x86/pmu.h | 19 +------------- > xen/include/public/arch-x86/xen-mca.h | 19 +------------- > xen/include/public/arch-x86/xen-x86_32.h | 19 +------------- > xen/include/public/arch-x86/xen-x86_64.h | 19 +------------- > xen/include/public/arch-x86/xen.h | 19 +------------- > xen/include/public/arch-x86_32.h | 19 +------------- > xen/include/public/arch-x86_64.h | 19 +------------- > xen/include/public/argo.h | 19 +------------- > xen/include/public/callback.h | 19 +------------- > xen/include/public/device_tree_defs.h | 6 +++++ > xen/include/public/dom0_ops.h | 19 +------------- > xen/include/public/domctl.h | 19 +------------- > xen/include/public/elfnote.h | 19 +------------- > xen/include/public/errno.h | 2 ++ > xen/include/public/event_channel.h | 19 +------------- > xen/include/public/features.h | 19 +------------- > xen/include/public/grant_table.h | 19 +------------- > xen/include/public/hvm/dm_op.h | 19 +------------- > xen/include/public/hvm/e820.h | 19 +------------- > xen/include/public/hvm/hvm_info_table.h | 19 +------------- > xen/include/public/hvm/hvm_op.h | 19 +------------- > xen/include/public/hvm/hvm_vcpu.h | 19 +------------- > xen/include/public/hvm/hvm_xs_strings.h | 19 +------------- > xen/include/public/hvm/ioreq.h | 19 +------------- > xen/include/public/hvm/params.h | 19 +------------- > xen/include/public/hvm/pvdrivers.h | 19 +------------- > xen/include/public/hvm/save.h | 19 +------------- > xen/include/public/hypfs.h | 19 +------------- > xen/include/public/io/9pfs.h | 19 +------------- > xen/include/public/io/blkif.h | 19 +------------- > xen/include/public/io/cameraif.h | 19 +------------- > xen/include/public/io/console.h | 19 +------------- > xen/include/public/io/displif.h | 19 +------------- > xen/include/public/io/fbif.h | 19 +------------- > xen/include/public/io/fsif.h | 19 +------------- > xen/include/public/io/kbdif.h | 19 +------------- > xen/include/public/io/libxenvchan.h | 19 +------------- > xen/include/public/io/netif.h | 19 +------------- > xen/include/public/io/pciif.h | 19 +------------- > xen/include/public/io/protocols.h | 19 +------------- > xen/include/public/io/pvcalls.h | 19 +------------- > xen/include/public/io/ring.h | 19 +------------- > xen/include/public/io/sndif.h | 19 +------------- > xen/include/public/io/tpmif.h | 19 +------------- > xen/include/public/io/usbif.h | 19 +------------- > xen/include/public/io/vscsiif.h | 19 +------------- > xen/include/public/io/xenbus.h | 19 +------------- > xen/include/public/io/xs_wire.h | 19 +------------- > xen/include/public/kexec.h | 19 +------------- > xen/include/public/memory.h | 19 +------------- > xen/include/public/nmi.h | 19 +------------- > xen/include/public/physdev.h | 19 +------------- > xen/include/public/platform.h | 19 +------------- > xen/include/public/pmu.h | 19 +------------- > xen/include/public/sched.h | 19 +------------- > xen/include/public/sysctl.h | 19 +------------- > xen/include/public/tmem.h | 19 +------------- > xen/include/public/trace.h | 19 +------------- > xen/include/public/vcpu.h | 19 +------------- > xen/include/public/version.h | 19 +------------- > xen/include/public/vm_event.h | 19 +------------- > xen/include/public/xen-compat.h | 19 +------------- > xen/include/public/xen.h | 19 +------------- > xen/include/public/xencomm.h | 19 +------------- > xen/include/public/xenoprof.h | 19 +------------- > xen/include/public/xsm/flask_op.h | 19 +------------- > tools/include/xen-foreign/mkheader.py | 23 ++++++++++++++--- > tools/include/xen/COPYING | 26 ++++++++++++++++++++ > 77 files changed, 125 insertions(+), 1301 deletions(-) > create mode 100644 tools/include/xen/COPYING >=20 > -- > Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Nov 16 00:37:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 00:37:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444101.698937 (Exim 4.92) (envelope-from ) id 1ov6Qf-0004Rn-6S; Wed, 16 Nov 2022 00:37:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444101.698937; Wed, 16 Nov 2022 00:37:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov6Qf-0004Rg-3V; Wed, 16 Nov 2022 00:37:25 +0000 Received: by outflank-mailman (input) for mailman id 444101; Wed, 16 Nov 2022 00:37:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov6Qd-0004RW-Nb for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 00:37:23 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062d.outbound.protection.outlook.com [2a01:111:f400:7e1b::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d5321d95-6546-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 01:37:22 +0100 (CET) Received: from AM6PR02CA0023.eurprd02.prod.outlook.com (2603:10a6:20b:6e::36) by PA4PR08MB6192.eurprd08.prod.outlook.com (2603:10a6:102:ea::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Wed, 16 Nov 2022 00:37:19 +0000 Received: from AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::f6) by AM6PR02CA0023.outlook.office365.com (2603:10a6:20b:6e::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Wed, 16 Nov 2022 00:37:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT022.mail.protection.outlook.com (100.127.140.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 00:37:18 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Wed, 16 Nov 2022 00:37:18 +0000 Received: from 21cec118e862.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 93439BDA-318D-47BB-B8CC-C65575B17556.1; Wed, 16 Nov 2022 00:37:07 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 21cec118e862.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 16 Nov 2022 00:37:07 +0000 Received: from GV2PR08MB8001.eurprd08.prod.outlook.com (2603:10a6:150:a9::12) by AS8PR08MB8350.eurprd08.prod.outlook.com (2603:10a6:20b:56c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Wed, 16 Nov 2022 00:37:05 +0000 Received: from GV2PR08MB8001.eurprd08.prod.outlook.com ([fe80::ac6e:a062:a5a3:8a3d]) by GV2PR08MB8001.eurprd08.prod.outlook.com ([fe80::ac6e:a062:a5a3:8a3d%5]) with mapi id 15.20.5813.013; Wed, 16 Nov 2022 00:37:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5321d95-6546-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y279gVXYpbJhNdMIIHzzVr/GAnGXY2OL9jCSn5hJi8k=; b=rWO98TYO7nhCe629+VsmLjLP7tfFITHTQTwqrzCEFlhd/5OPdheRRFx88OY5AVE2tincLf3UR2lQqBl0itpdDOp5t5qVTKFPRrOMYvEFfGxbFdZg6Mt6S73DPCF9/l++7QW+DtdgZs8ewBmh7uPzIatAFsErQxCA8M+WlSphciw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RlAxG7MZQ/9p1M4raDezew64ue2VVJegc2JjCyvTWuphWRSOX1ETVtZSgfflo43XNR7tK1ldpSmOxQ/7w8uf17tE3NAV87k7kCxN7Hgbntg0YrNxt9yMvP/vjNv2LVlQeaB2yDKyhW9zXvG6FR5fc8I9BJzUEM4LC159rFX56nzQLM6PXz3yJfq6NCPzC6fQ/6FQZ7L7BLlgx/IJWywmI6mpIatcETf1q9/RahYBauawrMAN/8eJ+wy5010eGp07AEhyxgZltyk98N3dUBrt8YOszoNJsbgMl+RuTLbhOL9X1D3LT1IVbc+Dkk9gPF5Hz6TCmpfrtPtoBsIkOTUHDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y279gVXYpbJhNdMIIHzzVr/GAnGXY2OL9jCSn5hJi8k=; b=N3BxKX+grB1O8nOFvdcjnbNIrX5Q/twiL8d0N5B/uszR2pQBU+ZmHNUZzDHdUFR7yN7pPzeRAo7x1E0x1RrHxtr6/K8hYEbPHiOf6H3ljs10fA8az/oC4upcdM3dkto2YsioO7rrC69u9debDyZFveb/cACB1FTJhX/hsGrFMB3dUvJR7YGJ/tJNi6r+Se/WuOQ2gfBL3Xt1FWjYrkC8pJu/WxqgY4aTfo89O5f6v/uJ27y9rVpy0b1Jl8jMC2er59CieoJ1dTP7mnPR6jTDWSabkUICbC40JCHEIvC5A0Zx4ZuIxNxO3V+ovUuSbQppIYy/jjF1vsOEY8h243H90A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y279gVXYpbJhNdMIIHzzVr/GAnGXY2OL9jCSn5hJi8k=; b=rWO98TYO7nhCe629+VsmLjLP7tfFITHTQTwqrzCEFlhd/5OPdheRRFx88OY5AVE2tincLf3UR2lQqBl0itpdDOp5t5qVTKFPRrOMYvEFfGxbFdZg6Mt6S73DPCF9/l++7QW+DtdgZs8ewBmh7uPzIatAFsErQxCA8M+WlSphciw= From: Henry Wang To: "grant.likely@linaro.org" , Bertrand Marquis CC: Anthony PERARD , Xen developer discussion , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Andrew Wafaa , Robert Booth Subject: RE: [XEN PATCH for-4.17 3/4] xen: Add licence header to device_tree_defs.h Thread-Topic: [XEN PATCH for-4.17 3/4] xen: Add licence header to device_tree_defs.h Thread-Index: AQHY7q5jhtRTV6uBfEqHQYoiBmmuwK45zBSAgAZvVACAAI3xIA== Date: Wed, 16 Nov 2022 00:37:05 +0000 Message-ID: References: <20221102112854.49020-1-anthony.perard@citrix.com> <20221102112854.49020-4-anthony.perard@citrix.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: CEA7F980A210F449B3AC2BCE0CB511A4.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: GV2PR08MB8001:EE_|AS8PR08MB8350:EE_|AM7EUR03FT022:EE_|PA4PR08MB6192:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d3baa36-a35e-4a0a-7af1-08dac76ab78a x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: B8KVI8eB+qKCb03QyB1fCjeuCuLoZGtRibqe0cpJ/zPGOIb9Kbnsd1TTPTBY95eX9VG2hYRhzo6udanHNxF7TjRRymrdCO58QAphJaHOkffgyvEZRfhSwx4eYFaIddAXci2Wzy0EURLbFeIdPZjwVh4ySkdG6JQxwU9uk07lUmiu4NlaXZXOcndMCNhixO3LmEXi6Xu7zffSYL4UElccVSwSDD/jqgKX5Fd2L9IGqNeYA8LSFrpucbA7U+0rANZBhRx/klwJ6UcF3ZQiQ0BkUPOoTOKgm6yxRsAi3VqK1ndxuLChD7TFIRMaLcL8Y3Gdq0ahmLF2fmTLNsDpfeXu21SQON13oRUnp3m81R27fXjpv76zLifWq7qe+ID3I2gPGcDoI5yrrQkYmeTvHJ2X4iVLX8AkZ2T9sUcqIHWPQrP5P5yMV0D3NbVy/krujhvCcJJFBcQhN0opvNGD7b1/4lMNfvMzqgJGYFvqZI5bpf5wEA3M4QapTho14Xo5zGg4BEL3Zyh1Jrz3PdhlNDETcuAuB8ksIsqsk4t9G7nthce+n+olPntuzeq6ti0x57fcinbYpfieBIEGCdLaTU5/nP0NJ2UGsNorHgoVf7NREj1Gts1RZmlfDxIsujs01MM1W7OUs3546rcMjqykHH1YUzG85ByzGUGm1M/OQduWMAdn5uYdl1hsz3pOPAdP1it/40NXU8tmy/KE3iCgOD+7hf8TH4K2342z2F1mBTgMTzQ1s2CkmkI+Hv0dSsyWJ72llmA4XjL+ksASi99cEdyLsA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8001.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(366004)(39860400002)(136003)(451199015)(122000001)(33656002)(38100700002)(6506007)(38070700005)(53546011)(86362001)(7696005)(26005)(8676002)(7416002)(4326008)(478600001)(6636002)(186003)(9686003)(54906003)(66476007)(66446008)(110136005)(66556008)(64756008)(76116006)(316002)(9326002)(55016003)(71200400001)(2906002)(5660300002)(41300700001)(66946007)(83380400001)(8936002)(52536014);DIR:OUT;SFP:1101; Content-Type: multipart/alternative; boundary="_000_GV2PR08MB800156DB2EA68819D1BF632392079GV2PR08MB8001eurp_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8350 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e84c7f1e-04c9-4611-5dad-08dac76aaf83 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hOtSTKHN0NK4vfQhkMy/tdduLxfiP3u/R+4Eg+QEorXaFCbxvCx8sYM2iPWL7k+FoqX3Dg3FDkf2/Y8IZ2uS0JWkoGMMbK3DMFHEFSCykErMnlE/leBbX4D4D9WF31e9O33q6St7FxS8WhMkBPV/luGh5Vcb7nI5L+1vw7sH0gzTZrz8BpHY3Chbu0VPYUr0zbQZO+4dSvIDykSMbs9NxcJ+rwN9Tpd0X5QDPYoNfwNdqm6fEf75RYgoq4uj7lw+6+9T0OY6AuM5a66THC2gJIxB7+ZgmD0lPTY0u19Ed6j58Hn9yzdcC4tC9MrzBSyC92ubeURIIx+ORCNChVVEs/m3QRc3sgaXmpeRHbBGbSZy9MxpSfL+D/6lXy3U+pxKdmfNLmqiBDgJrqa6HlJNqBCn/0Ss0zw7JABH/Kc+gnkVAPGTLFhVf7riu7GXuRWqUzsm0dQpaI2u1nhCxKPUW48FEdYOmlCAnc6JEnr8zg+iSfnOuin/HD6rvWUhUERhq3Mjt9ZTOEp+BJotpzSstDzh2O/tEUfWwORKKZHKQtekYr9hgxDhjPSXME7lxgv8ipZrH6ZrEVdbGBFvhCgGxqrCe2BgnmmM5gVuvSyC275CIVmzSFXq21Z+sBo+584wgP70OGrxldGuBAIHbda25ORXqx6kFIFFt+VtzVmU2Qg+ny5klqK56Dm6YeB5Bir4ri8Y18BJVbmNlt+mhAJRA90T5t13X718DCRNcw/0IqtbH2A1TWa6PLu8mq/pHBAhzZV/H+wLKK8V90kMUkMa3g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(136003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(478600001)(40480700001)(2906002)(9686003)(107886003)(26005)(7696005)(53546011)(6506007)(336012)(186003)(47076005)(8676002)(70206006)(54906003)(70586007)(4326008)(110136005)(5660300002)(40460700003)(356005)(316002)(82310400005)(6636002)(52536014)(41300700001)(9326002)(8936002)(83380400001)(86362001)(33656002)(55016003)(36860700001)(81166007)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 00:37:18.5332 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1d3baa36-a35e-4a0a-7af1-08dac76ab78a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6192 --_000_GV2PR08MB800156DB2EA68819D1BF632392079GV2PR08MB8001eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Grant, Great thanks for the confirmation! This would timely resolve one of the rel= ease blocker for the Xen 4.17 release :) Kind regards, Henry From: Grant Likely Sent: Wednesday, November 16, 2022 12:08 AM To: Bertrand Marquis Cc: Anthony PERARD ; Xen developer discussion ; Henry Wang ; Andrew Coo= per ; George Dunlap ; = Jan Beulich ; Julien Grall ; Stefano Sta= bellini ; Wei Liu ; Andrew Wafaa ; Robert Booth Subject: Re: [XEN PATCH for-4.17 3/4] xen: Add licence header to device_tre= e_defs.h Linaro approves the license change Acked-by: Grant Likely > On 11 Nov 2022, at 13:51, Bertrand Marquis > wrote: Hi, +Grant Likely from Linaro. In the following change, we need to change the license to MIT (from GPL) of= one of Xen public headers which has a Linaro copyright. @Grant Likely: could you confirm that Linaro is agreeing for Xen Project to= do such a change ? Kind regards Bertrand Marquis On 2 Nov 2022, at 11:28, Anthony PERARD > wrote: This header have been created by moving code from other part of the project and miss a licence header. The original source code was some version of GPL or LGPL but we intend to have the public header to be MIT so they can be included easily in other projects. Part of device_tree_defs.h were moved from libxl_arm.c which is LGPL-2.1-only. And part were moved from device_tree.h that is GPL-2.0-only. Part of the original code were added by Julien Grall @ Citrix with a Linaro "hat" in commits c3ba52a84dd8 and 405c167f0ec9 and 886f34045bf0. The other part were added by Ian Campbell @ Citrix, with commit 0c64527e7fc9. Resolves: xen-project/xen#35 Fixes: 1c898a9fec7e ("xen/arm: move a few DT related defines to public/devi= ce_tree_defs.h") Reported-by: Andrew Cooper > Signed-off-by: Anthony PERARD > --- Notes: Julian was working @citrix until 2015. xen/include/public/device_tree_defs.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/dev= ice_tree_defs.h index 228daafe81..9e80d0499d 100644 --- a/xen/include/public/device_tree_defs.h +++ b/xen/include/public/device_tree_defs.h @@ -1,3 +1,9 @@ +/* SPDX-License-Identifier: MIT */ +/* + * Copyright (c) 2013 Linaro Limited + * Copyright (c) 2015 Citrix Systems, Inc + */ + #ifndef __XEN_DEVICE_TREE_DEFS_H__ #define __XEN_DEVICE_TREE_DEFS_H__ -- Anthony PERARD --_000_GV2PR08MB800156DB2EA68819D1BF632392079GV2PR08MB8001eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Grant,

 

Great thanks for the confirmation! This would timely= resolve one of the release blocker for the Xen 4.17 release :)<= /p>

 

Kind regards,

Henry

 

From: Grant Likely <grant.likely@linaro.or= g>
Sent: Wednesday, November 16, 2022 12:08 AM
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>; Xen developer = discussion <xen-devel@lists.xenproject.org>; Henry Wang <Henry.Wan= g@arm.com>; Andrew Cooper <Andrew.Cooper3@citrix.com>; George Dunl= ap <george.dunlap@citrix.com>; Jan Beulich <jbeulich@suse.com>; Julien Grall <julien@xen.org>; Stefano Stabellini <sstabellini@ke= rnel.org>; Wei Liu <wl@xen.org>; Andrew Wafaa <Andrew.Wafaa@arm= .com>; Robert Booth <rob.booth@linaro.org>
Subject: Re: [XEN PATCH for-4.17 3/4] xen: Add licence header to dev= ice_tree_defs.h

 

Linaro approves the license change

 

Acked-by: Grant Likely <grant.likely@linaro.org>

 

On 11 Nov 2022, at 13:51, Bertrand Marquis <Bertrand.Marquis@arm.com> wro= te:

 

Hi,

+Grant Likely from Linaro.

In the following change, we need to change the license to MIT (from GPL) of= one of Xen public headers which has a Linaro copyright.

@Grant Likely: could you confirm that Linaro is agreeing for Xen Project to= do such a change ?

Kind regards
Bertrand Marquis


On 2 Nov 2022, at 11:= 28, Anthony PERARD <anthony= .perard@citrix.com> wrote:

This header have been created by moving code from other part of the
project and miss a licence header. The original source code was some
version of GPL or LGPL but we intend to have the public header to be
MIT so they can be included easily in other projects.

Part of device_tree_defs.h were moved from libxl_arm.c which is
LGPL-2.1-only. And part were moved from device_tree.h that is
GPL-2.0-only.

Part of the original code were added by Julien Grall @ Citrix with a
Linaro "hat" in commits c3ba52a84dd8 and 405c167f0ec9 and
886f34045bf0. The other part were added by Ian Campbell @ Citrix, with
commit 0c64527e7fc9.

Resolves: xen-project/xen#35
Fixes: 1c898a9fec7e ("xen/arm: move a few DT related defines to public= /device_tree_defs.h")
Reported-by: Andrew Cooper <Andrew.Cooper3@citrix.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
  Julian was working @citrix until 2015.

xen/include/public/device_tree_defs.h | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/dev= ice_tree_defs.h
index 228daafe81..9e80d0499d 100644
--- a/xen/include/public/device_tree_defs.h
+++ b/xen/include/public/device_tree_defs.h
@@ -1,3 +1,9 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright (c) 2013 Linaro Limited
+ * Copyright (c) 2015 Citrix Systems, Inc
+ */
+
#ifndef __XEN_DEVICE_TREE_DEFS_H__
#define __XEN_DEVICE_TREE_DEFS_H__

--
Anthony PERARD

 

 

--_000_GV2PR08MB800156DB2EA68819D1BF632392079GV2PR08MB8001eurp_-- From xen-devel-bounces@lists.xenproject.org Wed Nov 16 00:40:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 00:40:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444104.698949 (Exim 4.92) (envelope-from ) id 1ov6TG-0005jy-MB; Wed, 16 Nov 2022 00:40:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444104.698949; Wed, 16 Nov 2022 00:40:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov6TG-0005jr-Hm; Wed, 16 Nov 2022 00:40:06 +0000 Received: by outflank-mailman (input) for mailman id 444104; Wed, 16 Nov 2022 00:40:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov6TF-0005fH-EH; Wed, 16 Nov 2022 00:40:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov6TF-000425-Ax; Wed, 16 Nov 2022 00:40:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov6TE-0003NA-Ul; Wed, 16 Nov 2022 00:40:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ov6TE-0004PG-UJ; Wed, 16 Nov 2022 00:40:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MxHW4FqAoAbA4TkU/dTwOZ91OVqjYOwSiCtyxT0IIU8=; b=bef/Webw0ow7CC/DGx1Gq87Fnf /eU29BdhQ6KfYGAGVlXZ7ZP9G+T5WBM3yHKD39z93UKFp813vA+bu+Doyoo1H6VTPcsCeoDzDiprz 0cUj9JxOUgXD0am/P7pkRxPWt9Ddd3fr1mRG6ZtsKClNENhoFuvByuiOypkhMPvUGHgs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174779: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e01d50cbd6eece456843717a566a34e8b926cf0c X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 16 Nov 2022 00:40:04 +0000 flight 174779 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174779/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 build-arm64-pvops 6 kernel-build fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux e01d50cbd6eece456843717a566a34e8b926cf0c baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 39 days Failing since 173470 2022-10-08 06:21:34 Z 38 days 64 attempts Testing same since 174776 2022-11-15 05:17:35 Z 0 days 2 attempts ------------------------------------------------------------ 1705 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 162321 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Nov 16 01:19:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 01:19:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444113.698959 (Exim 4.92) (envelope-from ) id 1ov759-0008TO-LE; Wed, 16 Nov 2022 01:19:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444113.698959; Wed, 16 Nov 2022 01:19:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov759-0008TH-Ij; Wed, 16 Nov 2022 01:19:15 +0000 Received: by outflank-mailman (input) for mailman id 444113; Wed, 16 Nov 2022 01:19:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov757-0008TB-CB for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 01:19:13 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ac59791c-654c-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 02:19:11 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B2ED7612C5; Wed, 16 Nov 2022 01:19:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EBCCC433D6; Wed, 16 Nov 2022 01:19:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac59791c-654c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668561549; bh=JYQq041R94EZJjtnqoaotWOzKK3sbn68ph6ek3e+epc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=dR7xN2I9C4Z7SdQmj4C5SYLWzFO1k2DKXnA9acUAxa+oCiByOuwHFC7rIHoMbuImV I7W6aQ+b6ZPXqPrDWegtKEpgDihbDlcHZ8Hi9f/kgV8PGT9j/1LTOXLEzGcQlh8ooU uBsVtQ6N5c21kcoQHmURnA0aBCY/eWfj7arluuyrDnz9CwYYX7lWnAMG2NsKX4kRMH TTPJocyoox/a5x0YBfQnuZYmWA/nkOeRpIhpStCu6/UXh5n6Z15im4446jMqn4+shl PAVyMY+p7Wytdahba5iN0VAjA23Dgx37RfHnE424uQ6lF6oiRfvYx8hc6C8YGreiOp f9J7e2IaIQ90Q== Date: Tue, 15 Nov 2022 17:19:05 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: George Dunlap cc: Jan Beulich , Andrew Cooper , Roger Pau Monne , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony Perard , Xen-devel , George Dunlap Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool size In-Reply-To: Message-ID: References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-2-andrew.cooper3@citrix.com> <0f048bd2-d08c-8bd5-2a20-7e49e794c679@citrix.com> <8a8bc184-6237-ed24-8d9f-daa3c36df915@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-670147019-1668561549=:4020" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-670147019-1668561549=:4020 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 28 Oct 2022, George Dunlap wrote: > On Thu, Oct 27, 2022 at 8:12 AM Jan Beulich wrote: > On 26.10.2022 21:22, Andrew Cooper wrote: > > On 26/10/2022 14:42, Jan Beulich wrote: > >   > > paging isn't a great name.  While it's what we call the infrastructure > > in x86, it has nothing to do with paging things out to disk (the thing > > everyone associates the name with), nor the xenpaging infrastructure > > (Xen's version of what OS paging supposedly means). > > Okay, "paging" can be somewhat misleading. But "p2m" also doesn't fit > the use(s) on x86. Yet we'd like to use a name clearly better than the > previous (and yet more wrong/misleading) "shadow". I have to admit that > I can't think of any other sensible name, and among the ones discussed > I still think "paging" is the one coming closest despite the > generally different meaning of the word elsewhere. > > > Inside the world of operating systems / hypervisors, "paging" has always meant "things related to a pagetable"; this includes "paging out > to disk".  In fact, the latter already has a perfectly good name -- "swap" (e.g., swap file, swappiness, hypervisor swap). > > Grep for "paging" inside of Xen.  We have the paging lock, paging modes, nested paging, and so on.  There's absolutely no reason to start > thinking of "paging" as exclusively meaning "hypervisor swap". >   > [ A bunch of stuff about using bytes as a unit size] > > > This is going to be a reoccurring theme through fixing the ABIs.  Its > > one of a several areas where there is objectively one right answer, both > > in terms of ease of use, and compatibility to future circumstances. > > Well, I wouldn't say using whatever base granularity as a unit is > "objectively" less right. > > > Personally I don't think bytes or pages either have a particular advantage: > > * Using bytes >  - Advantage: Can always use the same number regardless of the underlying page size >  - Disadvantage: "Trap" where if you forget to check the page size, you might accidentally pass an invalid input.  Or to put it > differently, most "reasonable-looking" numbers are actually invalid (since most numbers aren't page-aligned)/ > * Using pages >  - Advantage: No need to check page alignment in HV, no accidentally invalid input >  - Disadvantage: Caller must check page size and do a shift on every call > > What would personally tip me one way or the other is consistency with other hypercalls.  If most of our hypercalls (or even most of our MM > hypercalls) use bytes, then I'd lean towards bytes.  Whereas if most of our hypercalls use pages, I'd lean towards pages. Joining the discussion late to try to move things forward. Let me premise that I don't have a strong feeling either way, but I think it would be clearer to use "bytes" instead of "pages" as argument. The reason is that with pages you are never sure of the actual granularity. Is it 4K? 16K? 64K? Especially considering that hypervisor pages can be of different size than guest pages. In theory you could have a situation where Xen uses 4K, Dom0 uses 16K and domU uses 64K, or any combination of the three. With bytes, at least you know the actual size. If we use "bytes" as argument, then it also makes sense not to use the word "pages" in the hypercall name. That said, any name would work and both bytes and pages would work, so I would leave it to the contributor who is doing the work to choose. --8323329-670147019-1668561549=:4020-- From xen-devel-bounces@lists.xenproject.org Wed Nov 16 01:38:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 01:38:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444118.698971 (Exim 4.92) (envelope-from ) id 1ov7NA-0002pr-5O; Wed, 16 Nov 2022 01:37:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444118.698971; Wed, 16 Nov 2022 01:37:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov7NA-0002pk-2T; Wed, 16 Nov 2022 01:37:52 +0000 Received: by outflank-mailman (input) for mailman id 444118; Wed, 16 Nov 2022 01:37:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov7N8-0002pe-Os for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 01:37:51 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 470c8cac-654f-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 02:37:48 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1AA30B818E0; Wed, 16 Nov 2022 01:37:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CC7CC433D6; Wed, 16 Nov 2022 01:37:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 470c8cac-654f-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668562666; bh=vHaCRRFbotSGOLE5yF/YKh3mcvMP8ASTAprw+xW1pY0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=DqfyctZt+fjQcYOAL8DwPWskWWCE5b9PEYDntbFBHbMi9tm2DkXLdppNGnc+LBKbj YcxdBNoUCR4rI9H+wUm/O8IWe3m77YkgNM+EYyQIUUcEPAjabuqbsvK4tVRFanmt9C 1F30saYAU6+Rtgr1O7P5b1Nla8BZziWoP4/esLKp+IbBEx2sXkhbp9Gg5TFUsh36ek F32aIfl4y00W+fu3y1sx6xc6KUE5RcACimoNIpgq5UBwuA9IIwLM29egHEr+JAZoWU MZLK6L4Zp9S8Bpllm4HqJFmL22aV3GEuW0lXgua5y1Ii1ZFfdanRB5oUhHFicjWARv GMJun86a6LU4w== Date: Tue, 15 Nov 2022 17:37:43 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Xen-devel , Xen Security Team , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony PERARD Subject: Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls In-Reply-To: <20221026102018.4144-4-andrew.cooper3@citrix.com> Message-ID: References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-4-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-202925017-1668562053=:4020" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-202925017-1668562053=:4020 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Wed, 26 Oct 2022, Andrew Cooper wrote: > This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits > of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. > > First of all, with ARM borrowing x86's implementation, the logic to set the > pool size should have been common, not duplicated. Introduce > libxl__domain_set_p2m_pool_size() as a shared implementation, and use it from > the ARM and x86 paths. It is left as an exercise to the reader to judge how > libxl/xl can reasonably function without the ability to query the pool size... > > Remove ARM's p2m_domctl() infrastructure now the functioanlity has been > replaced with a working and unit tested interface. > > This is part of XSA-409 / CVE-2022-33747. Genuine question: I can see this patch removes the implementation of XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION on ARM. It also switches libxl (both ARM and x86) to the new hypercall. Why keep the old hypercall (XEN_DOMCTL_shadow_op and XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION) implementation on x86 (not on ARM)? Is that because it was only recently implemented? And not actually present in any past Xen release? If so, please add a note about this in the commit message. Also, if that is the case, I think this patch series should go in 4.17. If it is too late to get it in before the release, then we should backport it to 4.17 as soon as possible. That's because ideally we want to keep the hypercall interface changes down to a minimum. > Signed-off-by: Andrew Cooper > --- > CC: Xen Security Team > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > CC: Stefano Stabellini > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Bertrand Marquis > CC: Henry Wang > CC: Anthony PERARD > --- > tools/libs/light/libxl_arm.c | 14 +---------- > tools/libs/light/libxl_dom.c | 19 ++++++++++++++ > tools/libs/light/libxl_internal.h | 3 +++ > tools/libs/light/libxl_x86.c | 15 ++--------- > xen/arch/arm/domctl.c | 53 --------------------------------------- > xen/arch/arm/include/asm/p2m.h | 1 - > xen/arch/arm/p2m.c | 8 ------ > 7 files changed, 25 insertions(+), 88 deletions(-) > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index 2a5e93c28403..2f5615263543 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -209,19 +209,7 @@ int libxl__arch_domain_create(libxl__gc *gc, > libxl__domain_build_state *state, > uint32_t domid) > { > - libxl_ctx *ctx = libxl__gc_owner(gc); > - unsigned int shadow_mb = DIV_ROUNDUP(d_config->b_info.shadow_memkb, 1024); > - > - int r = xc_shadow_control(ctx->xch, domid, > - XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, > - &shadow_mb, 0); > - if (r) { > - LOGED(ERROR, domid, > - "Failed to set %u MiB shadow allocation", shadow_mb); > - return ERROR_FAIL; > - } > - > - return 0; > + return libxl__domain_set_p2m_pool_size(gc, d_config, domid); > } > > int libxl__arch_extra_memory(libxl__gc *gc, > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c > index 2abaab439c4f..f93b221f1c1f 100644 > --- a/tools/libs/light/libxl_dom.c > +++ b/tools/libs/light/libxl_dom.c > @@ -1448,6 +1448,25 @@ int libxl_userdata_unlink(libxl_ctx *ctx, uint32_t domid, > return rc; > } > > +int libxl__domain_set_p2m_pool_size( > + libxl__gc *gc, libxl_domain_config *d_config, uint32_t domid) > +{ > + libxl_ctx *ctx = libxl__gc_owner(gc); > + uint64_t shadow_mem; > + > + shadow_mem = d_config->b_info.shadow_memkb; > + shadow_mem <<= 10; > + > + int r = xc_get_p2m_mempool_size(ctx->xch, domid, &shadow_mem); > + if (r) { > + LOGED(ERROR, domid, > + "Failed to set p2m pool size to %"PRIu64"kB", shadow_mem); > + return ERROR_FAIL; > + } > + > + return 0; > +} > + > /* > * Local variables: > * mode: C > diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h > index cb9e8b3b8b5a..f31164bc6c0d 100644 > --- a/tools/libs/light/libxl_internal.h > +++ b/tools/libs/light/libxl_internal.h > @@ -4864,6 +4864,9 @@ int libxl__is_domid_recent(libxl__gc *gc, uint32_t domid, bool *recent); > /* os-specific implementation of setresuid() */ > int libxl__setresuid(uid_t ruid, uid_t euid, uid_t suid); > > +_hidden int libxl__domain_set_p2m_pool_size( > + libxl__gc *gc, libxl_domain_config *d_config, uint32_t domid); > + > #endif > > /* > diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c > index 7c5ee74443e5..99aba51d05df 100644 > --- a/tools/libs/light/libxl_x86.c > +++ b/tools/libs/light/libxl_x86.c > @@ -538,20 +538,9 @@ int libxl__arch_domain_create(libxl__gc *gc, > xc_domain_set_time_offset(ctx->xch, domid, rtc_timeoffset); > > if (d_config->b_info.type != LIBXL_DOMAIN_TYPE_PV) { > - unsigned int shadow_mb = DIV_ROUNDUP(d_config->b_info.shadow_memkb, > - 1024); > - int r = xc_shadow_control(ctx->xch, domid, > - XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, > - &shadow_mb, 0); > - > - if (r) { > - LOGED(ERROR, domid, > - "Failed to set %u MiB %s allocation", > - shadow_mb, > - libxl_defbool_val(d_config->c_info.hap) ? "HAP" : "shadow"); > - ret = ERROR_FAIL; > + ret = libxl__domain_set_p2m_pool_size(gc, d_config, domid); > + if (ret) > goto out; > - } > } > > if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_PV && > diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c > index c8fdeb124084..1baf25c3d98b 100644 > --- a/xen/arch/arm/domctl.c > +++ b/xen/arch/arm/domctl.c > @@ -47,64 +47,11 @@ static int handle_vuart_init(struct domain *d, > return rc; > } > > -static long p2m_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, > - XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > -{ > - long rc; > - bool preempted = false; > - > - if ( unlikely(d == current->domain) ) > - { > - printk(XENLOG_ERR "Tried to do a p2m domctl op on itself.\n"); > - return -EINVAL; > - } > - > - if ( unlikely(d->is_dying) ) > - { > - printk(XENLOG_ERR "Tried to do a p2m domctl op on dying domain %u\n", > - d->domain_id); > - return -EINVAL; > - } > - > - switch ( sc->op ) > - { > - case XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION: > - { > - /* Allow and handle preemption */ > - spin_lock(&d->arch.paging.lock); > - rc = p2m_set_allocation(d, sc->mb << (20 - PAGE_SHIFT), &preempted); > - spin_unlock(&d->arch.paging.lock); > - > - if ( preempted ) > - /* Not finished. Set up to re-run the call. */ > - rc = hypercall_create_continuation(__HYPERVISOR_domctl, "h", > - u_domctl); > - else > - /* Finished. Return the new allocation. */ > - sc->mb = p2m_get_allocation(d); > - > - return rc; > - } > - case XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION: > - { > - sc->mb = p2m_get_allocation(d); > - return 0; > - } > - default: > - { > - printk(XENLOG_ERR "Bad p2m domctl op %u\n", sc->op); > - return -EINVAL; > - } > - } > -} > - > long arch_do_domctl(struct xen_domctl *domctl, struct domain *d, > XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > { > switch ( domctl->cmd ) > { > - case XEN_DOMCTL_shadow_op: > - return p2m_domctl(d, &domctl->u.shadow_op, u_domctl); > case XEN_DOMCTL_cacheflush: > { > gfn_t s = _gfn(domctl->u.cacheflush.start_pfn); > diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h > index c8f14d13c2c5..91df922e1c9f 100644 > --- a/xen/arch/arm/include/asm/p2m.h > +++ b/xen/arch/arm/include/asm/p2m.h > @@ -222,7 +222,6 @@ void p2m_restore_state(struct vcpu *n); > /* Print debugging/statistial info about a domain's p2m */ > void p2m_dump_info(struct domain *d); > > -unsigned int p2m_get_allocation(struct domain *d); > int p2m_set_allocation(struct domain *d, unsigned long pages, bool *preempted); > int p2m_teardown_allocation(struct domain *d); > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > index 4607cde6f0b8..92b678cf0d09 100644 > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -92,14 +92,6 @@ static void p2m_free_page(struct domain *d, struct page_info *pg) > spin_unlock(&d->arch.paging.lock); > } > > -/* Return the size of the pool, rounded up to the nearest MB */ > -unsigned int p2m_get_allocation(struct domain *d) > -{ > - unsigned long nr_pages = ACCESS_ONCE(d->arch.paging.p2m_total_pages); > - > - return ROUNDUP(nr_pages, 1 << (20 - PAGE_SHIFT)) >> (20 - PAGE_SHIFT); > -} > - > /* Return the size of the pool, in bytes. */ > int arch_get_p2m_mempool_size(struct domain *d, uint64_t *size) > { > -- > 2.11.0 > --8323329-202925017-1668562053=:4020-- From xen-devel-bounces@lists.xenproject.org Wed Nov 16 01:48:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 01:48:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444123.698982 (Exim 4.92) (envelope-from ) id 1ov7XY-0004WB-5W; Wed, 16 Nov 2022 01:48:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444123.698982; Wed, 16 Nov 2022 01:48:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov7XY-0004W4-19; Wed, 16 Nov 2022 01:48:36 +0000 Received: by outflank-mailman (input) for mailman id 444123; Wed, 16 Nov 2022 01:48:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov7XW-0004Vw-Et for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 01:48:34 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c602a7de-6550-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 02:48:32 +0100 (CET) Received: from mail-bn8nam12lp2175.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Nov 2022 20:48:24 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by CH0PR03MB5988.namprd03.prod.outlook.com (2603:10b6:610:e3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 01:48:17 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860%5]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 01:48:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c602a7de-6550-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668563312; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=z5mgmGSt1k6ofONfwu+a//Yc5uKeib2zz9aLXoaAEkA=; b=Q9mnzJ3KDXtyQM2hLdBhBHDreFPQh9SwL5PfROwdMRcFViCfxAc18tdi A42fSfq6IluJwTtbYHTswkRNGBnrDGLiWIWI9ywC8RfV89RUaQp0I8xKZ O3NA10BAvzB8gBm958J/d4E5q6y3dgELslmg5ScLarS1xDkBk+bjpeF47 k=; X-IronPort-RemoteIP: 104.47.55.175 X-IronPort-MID: 84491436 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:2dCvaa9YSw5IqW8BDt3qDrUDLn+TJUtcMsCJ2f8bNWPcYEJGY0x3z GccWzyCM/mIMWfwct1/OY23o0kFvsDcxoIwSFNrrSg8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKkW5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklR5 fU1Lj40RyuNqKHp5a2+Fdhni80seZyD0IM34hmMzBn/JNN/G9XpZfWP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUujdABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCN5OReTkraACbFu79148DhJHTXCA/9KzrRWyQOAYd 0wG9X97xUQ13AnxJjXnZDWju2KNtBMYX9tWEsU55RuLx66S5ByWbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hSi/MjUPLHMTTT8JS00C+daLiKMZgw/LT91jOLWoldCzEjb1q xiVqAAuirNVitQEv4254FTGjjSEtpXPCAkv6W3/YGWh6Q9oYZ+/UKah41Pb8PVoIZ6QSx+Ku 31ss8KT9vwUBJeB0imEWvwQHaqB7uyAdjbbhDZHP5Qn7SXrxHelcqhZ+jQ4L0BsWvvoYhfsa U7X/AlXtJlaOSLwabctOt3sTcM30aLnCNLpEOjOacZDaYRwcwnB+zxyYUmX3Cbml01EfbwDB Kp3uP2EVR4yYZmLBhLsLwvB+dfHHhwD+F4= IronPort-HdrOrdr: A9a23:50n9YqudRdGCr5MuW++Cq8xL7skCXoAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeF+aP3CB+R2zYZSndqza05+W bIvgTl7uH72svLiyP05iv21dB7idHhwtxMCIiljdUUECzljkKFdZlsQLqLuREyuaWK5EwxmN fBjh88N4BY6m/XfEuyvRzxsjOQngoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L gj5RPbi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZDIMu60vFjLA BdNrCa2B9kSyLdU5kfhBg3/DWYZAV2Iv5BeDlbhiXa6UkMoJkz9Tpk+CVWpAZ9yHt6cegF2w 2MCNUXqFkFJPVmEp5VFaMPR9C6BXfKRg+JOGWOIU7/HKVCIH7VrYXriY9Frd1CVaZ4u6faoq 6xJm9wpCo3YQbjGMeO1JpE/lTER3i8Ry3kzoVb64JisrPxSbL3OWnbIWpe2PeIsrEaGInWSv yzMJVZD7vqKnbvA59A20n7V4NJIXcTXcUJspIwWk6IoMjMNor239arOMr7Nf7oC3IpS2n/Cn wMUHz6I9hB9FmiXjvijB3YSxrWCzjCFFJLYd3nFsQoufsw39d3w3koYHyCl7G2ACwHtLAqd0 1jJ76imr+npACNjBT101k= X-IronPort-AV: E=Sophos;i="5.96,167,1665460800"; d="scan'208";a="84491436" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/yE3yFyF3OhC988IJ6lLfl5uTEbPTV74+EBzdNaPoVRjMO5+LjOD08pV5k7y6FD9U2fvIxlLnU5gv8c5i31vpEETyeB+ZIs569MXy9LcjUTm84Ig7bWhiAguOyxnfGz5zDQY10X/Ihvoc/YIPLrSh5Lz1pbs6VYnYHSLe7ZiWf78ejaRAV0cvxazbUwYMmsgfcm4B5nluFaHLp0MLEYuC35wCla0HjdAYntn8oyPoCPijSmHhR6hlNqtbjG+DYQFAiwflHbWjmNU+Ouuurjblje+bIim1c/SrFfzvkZbEEKoik7VRIanlFB38ePcwnZ72W+9dI8H/539AK8n3VN1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z5mgmGSt1k6ofONfwu+a//Yc5uKeib2zz9aLXoaAEkA=; b=lmweX52P5NegXgdsLXBKMGs2VHt3jToh9HKsCqducfMS0yhOZcWuTPYFzXIUFHCmXH+Ytn6iqIJYhbIFuMJfJzGtTJgHRk03PTq0vQhCuylgHi4atr2wD4SWsT7Qi1cuCLTsVUfgWe714VZs1ka31BIvq0dOdkeSikehm7j23KyUIgE3Q2SXmSt7jVcI1tQOONu9hzlhH605UG/eIG/hYNK0MHupJ0210V5QnDzWnd4hnzLizOdHYNGhFncOgfJHQyq/u4BpER6nEU3SuruI6IqxNDrK9EmfxbSZZ+8qal7MKcvP7P5MzLCAUMKfrug1sz1Riu8QIUdWVG1yuDv8dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z5mgmGSt1k6ofONfwu+a//Yc5uKeib2zz9aLXoaAEkA=; b=Wrjx3I0z75bE7foiMgeuBCkq6EYF5HzM58XjfnlNjCdbRlNLKBKlxJ+IW56e7cDazbY2ynnIQquboHDF5lGCzlBlSCJURF1kb0uGw7mlA9OnA3DV9Z4xomWp4rair0KeCOyVRYNpIX8adlTp/5Hr/H/qhV86p0MSa6wXBFKj7so= From: Andrew Cooper To: Stefano Stabellini CC: Xen-devel , Xen Security Team , Jan Beulich , Roger Pau Monne , Wei Liu , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony Perard Subject: Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls Thread-Topic: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls Thread-Index: AQHY6SSlXP4isouqyE+BbtcNRl5Xnq5A5cGAgAAC9IA= Date: Wed, 16 Nov 2022 01:48:17 +0000 Message-ID: References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-4-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|CH0PR03MB5988:EE_ x-ms-office365-filtering-correlation-id: d63dbe5d-9a19-442a-ff4a-08dac774a22c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U/5X/PNaKpSptF1t5ZxlVxj1oRHvIAe2JJ2B7YygxDUZGDlmh8qdLO02IL3Fg5khqtyLlqljSnDO9qMAOp2f0SBHQHYyvSP4xaF/azXBTXb40uhQT7tPkXf21KhKHXfLc0DNdLKhNksdDzbSxTpVsj4pgsUKHZT2dbyrg2Lbkz//VDKga0RixXe9e825YEW6xXGmUw5AXIThP+DRqlx/LO7FXiu4TKHT9a/UlVkJ2dFx+QcN3Uobe3m64fouXntD1OQMqOTVuHj6rR96etfFemprGJY+qhAY8f+vn9oF3QRk+9z0gOcr9m5h6E73qhoHI4wSyWx9FaWnAZog8sxE5sydAC7mRs3XR519zfIUlA4leSzYGMbEBGul6ksW3ghOUmNWjQBwDlfDWMMqMg+HqC5Pteuv1P0Bh7ufaXx5Yzvldk8WJte8WbUjY4gP+NpGzSLv5acUNJKWh0i8Zsh3p7lidI47rv4jX6de2h+L/0D/k3mYCfWnQd98k6beUMMGEXn7n/o0UN77Oe+WQHeZg7gbtnB8bwZt1EYELOThBzXSFeQsDT/IddzpUBIte4eNLQbZMnWMyuObRlyv5hvGl24UN24OX5njJ8lFsW1c/t4qMdTnCi+jnsDtIh5jGIDB0QQnxSu2CtPbYU0ZLnzpRLIrxDJHHleKWRNsJRxZu71+ZpWrx4KeKyC447gynUU3CEDBXlRN7KCJaqKNubK2u48AslV0621/XnVClipfRKki17dzSiph6hBG1+rX7ZsjiTSC5fGGsaizQqWCE+pFVHHzrlTfwS/NaIVcolfHrv8jn9AbNxMSYxRNEXE2msQuI82isGspYALWmMCGt0JaIA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(39860400002)(136003)(396003)(376002)(451199015)(71200400001)(478600001)(122000001)(6486002)(31686004)(107886003)(66899015)(54906003)(36756003)(4326008)(26005)(53546011)(316002)(6512007)(6916009)(186003)(64756008)(66476007)(66556008)(66946007)(2616005)(76116006)(8676002)(66446008)(91956017)(8936002)(41300700001)(38070700005)(38100700002)(82960400001)(5660300002)(31696002)(6506007)(83380400001)(86362001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WUttNFpCSEozT0JHL0Rqd1llclBTZkV4TW1aV2o1T2NJRFliQk5rTjZxNzNU?= =?utf-8?B?RjZwMWVZcEhQTWJoRjV0ZnkrYjFTd0RTcWdVL3o5emtqMVVEbytTSDZRWGFT?= =?utf-8?B?bXlFTitkZ21SZXZuUlNXOHk0MDArVnVXK1V4TEhiek5FSEhZMlZiLy82UC9Q?= =?utf-8?B?Q3hqT1M1ZTZLYXZuOE9lTVhPY3ozalpIV3B2ZitLREczdSs3YmpWa3hhQXdZ?= =?utf-8?B?SVZuMllabjVLcVo3Z2l5WUVwaXVJMW8rdUJzQXdKLzFwaWxsT3VsREZZZWRh?= =?utf-8?B?V1BhcmlZNEl1dWhaeTFvU2pkMXBSWUtyNlovQVhmd3lvK3ZVcXY3c2ozaE9t?= =?utf-8?B?ZFg3TDl1SGJIQUZrWWJkenBoWmZha1VMMjlpQ0pTN1RzRnJaOHVRdGdwTjJR?= =?utf-8?B?eFVQVVBXVUdWYmVSdFc2WTl2K1ROZ0tHTWkvMVFJaGZaSE5Cdjg3bUFPL1ZC?= =?utf-8?B?WHdEdkhWYmNmVFVsUGxGc21IV2tHMDM3eU9iNWoyS3VNV0dCU2s0akkvemEx?= =?utf-8?B?VEpoREhVdFF6elY5cm4va3duMTNNUlNPUktFRFNqYnhjNmpaMUM2T0loSzR0?= =?utf-8?B?UnBVc2I2Q1lkVFNkMnduSDhSUWdQQ0N3SWdUWE9UdnhTeTY4b3NXYjJZckR1?= =?utf-8?B?R0p0S2ovMnFORnorbVhrQWFPN21OQm9JdGptNjZKbUdiNldybVJKZGQrNkFh?= =?utf-8?B?dzVIRWlBTkM4Q21MYlBtdkx0alBnS21RUEptQXJOeWFRV2xEeHhwS0dLUFph?= =?utf-8?B?N1BNeEZSR0k5OC82WFRGUjg2aWluZkxUUm5SQUcweTBrRTFjMHRURHMzckJa?= =?utf-8?B?UEVFbGNPYlBlYjZxc1ovVVRRem9EUHdVZG1iaCs5VENTd05UYkl2ejg5MGFr?= =?utf-8?B?a1UzT3ZkZm1EMG5YWklrWXZkM0hIU0RNcG9YcGRndk5IaUdSR01POE03NlhN?= =?utf-8?B?dS9vcktIaU1aQnIwYXVmWTU5NldxblhpTjhMQ2Z6ZXpWS05qTXNweWV4djdt?= =?utf-8?B?dEl1MmxTbHllSnJMM3psZ0lGUHBPSlZ6a0dPZmlPeWtEN2FqbUFCVSt3eHdV?= =?utf-8?B?S0hQVnYzK0U1b3ZWdWJBY3JRbDN3N2pGV1hZL0NhUFhUaFFjeDREbHp0dzg0?= =?utf-8?B?ZlhSQkZaa2R2UnhMKys4YUJFRlZaKzZhd1Fxalp6aHZPbEtuenorTGh6WU5M?= =?utf-8?B?ZUlXUXVUNVptbUZGVzhSSVNwU2VtWFowY2gvTTNjQXFlMjJEcm51OWw5dUph?= =?utf-8?B?MTVyQnhpZUpBS0NvczhycmtENzBDd0dsNkkveW1VU2lXd1Z6RjZaVDM4dkxC?= =?utf-8?B?UTZ4NGlnWEVHMGVpMFJFTGxtSW5QQUdJQlBhdkQyVmhrNFVnZnhCUXZLM28y?= =?utf-8?B?MmptZzZiM2dNSGtXN09tVVdJcGpabFo0cUMwZlR4aHFiTXFUVW5tZmpsUWcz?= =?utf-8?B?eG9MelNZK0taT3kxTHVueUc5cGZXa01YS3gyY0lqT0Y5OGVyTkM2NGhXODZv?= =?utf-8?B?ZEF2bDNCcmhHdTVPYkIyK2VsejVxM2ExQWFSUGI3cExHMzlxeGVMejhhVG51?= =?utf-8?B?RkV1VzdDdU90MzI3eGZ6NTlkblFOTzBPclRnVU9MOTJ5NXFrQmZ3M3V6SXdH?= =?utf-8?B?UTJwVnJMSzRZZVdOVzNQRXU0L0g4QVRWNUdzenVQYStvcjNrR0xkTGFRaUVT?= =?utf-8?B?VXBSdlR3Z0hyV0NQRFJWREhqOGhkWS84Nko2SFVXT05OUkpabFQyOE42dEtM?= =?utf-8?B?Z1NtbHlZWCsxRlZ1QjYwdFZkYytIcGY5RE1naTNuVWkxZk5tLzFVa2xiUDJQ?= =?utf-8?B?MmhCS21FdXhvd3N3SmlGbUJpNks2QjdqdWVkVUI0bS93dlBsZ05hNmlMZHlB?= =?utf-8?B?Q1NXdk1lcStNakh2SzNvZ3dsTDZXd29WRkE0M3Q4TmppcjFlTEVlUVB4cm0v?= =?utf-8?B?WVNWaldqNEhLNjJOeEk5cCtFWEY2cld4ZTEvNnhEclNlSnhRK2ZYTmxubDkx?= =?utf-8?B?SER0Q3FySmpNMXE5VWpaSGxLZnR0SFAxd3BycDNLVWFnZjdQOEdwNVVyUGR6?= =?utf-8?B?SldnRTBmcFBqSHJ0N3JPbldWT0twNFpnTjZSQWpGNUdDMXZiK1RzUWRKcTEz?= =?utf-8?Q?Rv4DGYhDDbI7qnQJp2DGF30uF?= Content-Type: text/plain; charset="utf-8" Content-ID: <7E8DC918A532FE41905C7100D6C44D1C@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?eklnbkpFaXZOTlhLWXVhMkJxVU1LZjJJenBuZVlqV1lwNW5qdUEvUnFtcTkr?= =?utf-8?B?NCtVQ25KWldEWUFYTFBrK2trRFBINS9jRDdhMHdtK3lrNTBpSkYvS0dteTFo?= =?utf-8?B?cjgvNktieDEwSUJVOW1GRXcraHcwR0ROR2thbG8rNytzTWVjTERpVnJkcmlm?= =?utf-8?B?ZXVNUzhaV04yeHE4RmVleEdFMFpkM3d3Z1l0NUxzVXRlVzFUTFFqSEdKbmND?= =?utf-8?B?Y3lwSTBZeTRkK3pCVnJvMitMVE5BdEJEeU5HaHhnNEcwZldIdTdXZytCUWN5?= =?utf-8?B?YVkydFNPODR4QU1ENkhGdlZIc1M1Q0c3RVF2MExnRnllbDl0SmYyOElzZ1ZZ?= =?utf-8?B?NkgrUjJISERGckZ1M1NiZVFBYTVPS0xPR3FSV2JodFUxSnB0S3pjT3pyKzJi?= =?utf-8?B?WUM2bzRzZnRMYVphd3A0QnZPSlkySkczVHA1aVh4bXd0Q3pqTmlZRjh1Sk9u?= =?utf-8?B?UjBRN1RUaTdMaEZpYWZJa0xrc3YzWEJzbytiUys3OEFTN0ZVWmJyV1c4Y3pM?= =?utf-8?B?OGVJdWd0RTB2b0NLSUJuemZKOTZvS1diUGZuSDhyL1pBbGtRdGlEVktBeE9z?= =?utf-8?B?SmNzcjk2cmRtOUV6VnM5MW9kTllSNjFEbW02eTNTdHlLNU1Ed1k4VXdaMW5E?= =?utf-8?B?cEowQ1RpWkk1QTN0VTM1cUg2blBkN21iVEFGcWN1bkdVQ1ZQSWJVdFVTcVZN?= =?utf-8?B?bGlBZjcyZ3c5aW5HNmhuVGxFdzNiU285YWlSa0FJUHZwSVczd0JtYkx3Y3Fu?= =?utf-8?B?aFlOT0JFbW5QMTlYUXVDZTk5Z2xabzk3TEx0Q3ZCSDByNnpLL3lzWThtQWxi?= =?utf-8?B?b3FsVzFnNEdUajZGVjJzb3ZDeUZRSGVLWkxoT3BoZlQ5U1FERk52Mk94eHRY?= =?utf-8?B?bk4yb0x3VGRHanAveEpCMzdTc1prWks2OUFEU21kSXZEUjN1cWZDRzFDM24r?= =?utf-8?B?dGY3eWFuWUZpWUZkQ2FoSWJoMTM3OS8rSUp5ckh3RTQ1QVdoUmRWVGlodG1T?= =?utf-8?B?YWlXMXBybm1DOGVRbmpoKytoOXJtbjcxNDFZeGhCUmpyUDdOb3ZpUStzM2JK?= =?utf-8?B?b24zSVBnOWRUQWIzYldwS3VEdmVDMnk5NjgweDNSMlNpZmY2TVpHcGk2cVgz?= =?utf-8?B?UzJYbTlsR3hFakM1VUt6NDE0RWU5aklEdVhobzRVWUxaOHBlejlsQ2FMRDhp?= =?utf-8?B?MGt2UlUxYmRVcFlPSmY5WGJBeEJUSmtudW5tOTFkME9PQlA3ODhEaDVvMVZn?= =?utf-8?B?SnJNYXNHVDB4Tlh5TS9IQnhLdlBNZDhQNWVJVEpGQXhIcnlCUT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d63dbe5d-9a19-442a-ff4a-08dac774a22c X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 01:48:17.6713 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gbEgVPObb0EZGOK1ei2rZrOjjYuWaJ0SRB08ydMxq+KPKeGqT+mnxqi6pi7LfbzWcsoYDTYIPtO5SRap9EX/vIly49YL7s8zG/055jKgGeg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB5988 T24gMTYvMTEvMjAyMiAwMTozNywgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPiBPbiBXZWQs IDI2IE9jdCAyMDIyLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4gVGhpcyByZXZlcnRzIG1vc3Qg b2YgY29tbWl0IGNmMmE2OGQyZmZiYzNjZTk1ZTAxNDQ5ZDQ2MTgwYmRkYjEwZDI0YTAsIGFuZCBi aXRzDQo+PiBvZiBjYmVhNWExMTQ5Y2E3ZmQ0YjdjZGJmYTNlYzJlNGYxMDliNjAxZmY3Lg0KPj4N Cj4+IEZpcnN0IG9mIGFsbCwgd2l0aCBBUk0gYm9ycm93aW5nIHg4NidzIGltcGxlbWVudGF0aW9u LCB0aGUgbG9naWMgdG8gc2V0IHRoZQ0KPj4gcG9vbCBzaXplIHNob3VsZCBoYXZlIGJlZW4gY29t bW9uLCBub3QgZHVwbGljYXRlZC4gIEludHJvZHVjZQ0KPj4gbGlieGxfX2RvbWFpbl9zZXRfcDJt X3Bvb2xfc2l6ZSgpIGFzIGEgc2hhcmVkIGltcGxlbWVudGF0aW9uLCBhbmQgdXNlIGl0IGZyb20N Cj4+IHRoZSBBUk0gYW5kIHg4NiBwYXRocy4gIEl0IGlzIGxlZnQgYXMgYW4gZXhlcmNpc2UgdG8g dGhlIHJlYWRlciB0byBqdWRnZSBob3cNCj4+IGxpYnhsL3hsIGNhbiByZWFzb25hYmx5IGZ1bmN0 aW9uIHdpdGhvdXQgdGhlIGFiaWxpdHkgdG8gcXVlcnkgdGhlIHBvb2wgc2l6ZS4uLg0KPj4NCj4+ IFJlbW92ZSBBUk0ncyBwMm1fZG9tY3RsKCkgaW5mcmFzdHJ1Y3R1cmUgbm93IHRoZSBmdW5jdGlv YW5saXR5IGhhcyBiZWVuDQo+PiByZXBsYWNlZCB3aXRoIGEgd29ya2luZyBhbmQgdW5pdCB0ZXN0 ZWQgaW50ZXJmYWNlLg0KPj4NCj4+IFRoaXMgaXMgcGFydCBvZiBYU0EtNDA5IC8gQ1ZFLTIwMjIt MzM3NDcuDQo+IEdlbnVpbmUgcXVlc3Rpb246IEkgY2FuIHNlZSB0aGlzIHBhdGNoIHJlbW92ZXMg dGhlIGltcGxlbWVudGF0aW9uIG9mDQo+IFhFTl9ET01DVExfU0hBRE9XX09QX1NFVF9BTExPQ0FU SU9OIG9uIEFSTS4gSXQgYWxzbyBzd2l0Y2hlcyBsaWJ4bCAoYm90aA0KPiBBUk0gYW5kIHg4Nikg dG8gdGhlIG5ldyBoeXBlcmNhbGwuDQo+DQo+IFdoeSBrZWVwIHRoZSBvbGQgaHlwZXJjYWxsIChY RU5fRE9NQ1RMX3NoYWRvd19vcCBhbmQNCj4gWEVOX0RPTUNUTF9TSEFET1dfT1BfU0VUX0FMTE9D QVRJT04pIGltcGxlbWVudGF0aW9uIG9uIHg4NiAobm90IG9uIEFSTSk/DQo+DQo+IElzIHRoYXQg YmVjYXVzZSBpdCB3YXMgb25seSByZWNlbnRseSBpbXBsZW1lbnRlZD8gQW5kIG5vdCBhY3R1YWxs eQ0KPiBwcmVzZW50IGluIGFueSBwYXN0IFhlbiByZWxlYXNlPw0KPg0KPiBJZiBzbywgcGxlYXNl IGFkZCBhIG5vdGUgYWJvdXQgdGhpcyBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuIEFsc28sIGlmIHRo YXQNCj4gaXMgdGhlIGNhc2UsIEkgdGhpbmsgdGhpcyBwYXRjaCBzZXJpZXMgc2hvdWxkIGdvIGlu IDQuMTcuIElmIGl0IGlzIHRvbw0KPiBsYXRlIHRvIGdldCBpdCBpbiBiZWZvcmUgdGhlIHJlbGVh c2UsIHRoZW4gd2Ugc2hvdWxkIGJhY2twb3J0IGl0IHRvIDQuMTcNCj4gYXMgc29vbiBhcyBwb3Nz aWJsZS4gVGhhdCdzIGJlY2F1c2UgaWRlYWxseSB3ZSB3YW50IHRvIGtlZXAgdGhlDQo+IGh5cGVy Y2FsbCBpbnRlcmZhY2UgY2hhbmdlcyBkb3duIHRvIGEgbWluaW11bS4NCg0KT24gQVJNLCB0aGUg aHlwZXJjYWxsIGhhcyBleGlzdGVkIGZvciBhIGxpdHRsZSBvdmVyIDQgd2Vla3MsIGFuZCBpc24n dA0KaW4gYW55IHJlbGVhc2VkIHZlcnNpb24gb2YgWGVuICh5ZXQpLg0KDQpPbiB4ODYsIHRoZSBo eXBlcmNhbGwgaGFzIGV4aXN0ZWQgZm9yIG1vcmUgdGhhbiBhIGRlY2FkZSwgYW5kIGhhcyBrbm93 bg0Kb3V0LW9mLXRyZWUgdXNlcnMuwqAgSXQgbmVlZHMgdG8gYmUgZGVwcmVjYXRlZCBwcm9wZXJs eSwgd2hpY2ggaW4gdGhpcw0KY2FzZSBtZWFucyAicGhhc2VkIG91dCBpbiB0aGUgNC4xOCBjeWNs ZSBvbmNlIGtub3duIGNhbGxlcnMgaGF2ZSBiZWVuDQphZGFwdGVkIHRvIHRoZSBuZXcgaHlwZXJj YWxsIi4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Nov 16 02:00:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 02:00:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444129.698992 (Exim 4.92) (envelope-from ) id 1ov7jK-0007hp-9t; Wed, 16 Nov 2022 02:00:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444129.698992; Wed, 16 Nov 2022 02:00:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov7jK-0007hi-7D; Wed, 16 Nov 2022 02:00:46 +0000 Received: by outflank-mailman (input) for mailman id 444129; Wed, 16 Nov 2022 02:00:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov7jI-0007hc-LC for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 02:00:44 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 79e3ef25-6552-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 03:00:43 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A2B01B81BAD; Wed, 16 Nov 2022 02:00:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE7EBC433C1; Wed, 16 Nov 2022 02:00:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79e3ef25-6552-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668564040; bh=gGhOsOVID+DmGfCStSAGWv9CeEPHDvbjLJlX3XwWDe8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=vBghZ5Ig9AE0L3klUT8uzR57nf5CF5spkTA1UwyXaRmtPyZuk0GmA+OH74f6KhsxA qOTmyllQazO9wTqPq98j0DhPBrBjBO2Sx+WWL+yXr47tm32zyW7FM1vz52iV3bCnNH Lz3s6BVRfDYwOIVp0RI52RGDUyveSJgADA02arUG8Xm85VJnE8pDj1MhpbbEY3QY+7 LjUfwZcE+fzOgWEYN+uo7aMztvBMTY0OiNFOmC7mGL12GFi2H3sRx5AH0g2p6Tuyiz qaMiVj1ABKOSETG2vRQHRMw3rTXFvZf4HLiCzE9qxIYExJ3Y5AMTlyztyrqYSrKGjY KISIuMXlWTR0g== Date: Tue, 15 Nov 2022 18:00:37 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Stefano Stabellini , Xen-devel , Xen Security Team , Jan Beulich , Roger Pau Monne , Wei Liu , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony Perard Subject: Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls In-Reply-To: Message-ID: References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-4-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-429611521-1668564040=:4020" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-429611521-1668564040=:4020 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 16 Nov 2022, Andrew Cooper wrote: > On 16/11/2022 01:37, Stefano Stabellini wrote: > > On Wed, 26 Oct 2022, Andrew Cooper wrote: > >> This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits > >> of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. > >> > >> First of all, with ARM borrowing x86's implementation, the logic to set the > >> pool size should have been common, not duplicated. Introduce > >> libxl__domain_set_p2m_pool_size() as a shared implementation, and use it from > >> the ARM and x86 paths. It is left as an exercise to the reader to judge how > >> libxl/xl can reasonably function without the ability to query the pool size... > >> > >> Remove ARM's p2m_domctl() infrastructure now the functioanlity has been > >> replaced with a working and unit tested interface. > >> > >> This is part of XSA-409 / CVE-2022-33747. > > Genuine question: I can see this patch removes the implementation of > > XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION on ARM. It also switches libxl (both > > ARM and x86) to the new hypercall. > > > > Why keep the old hypercall (XEN_DOMCTL_shadow_op and > > XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION) implementation on x86 (not on ARM)? > > > > Is that because it was only recently implemented? And not actually > > present in any past Xen release? > > > > If so, please add a note about this in the commit message. Also, if that > > is the case, I think this patch series should go in 4.17. If it is too > > late to get it in before the release, then we should backport it to 4.17 > > as soon as possible. That's because ideally we want to keep the > > hypercall interface changes down to a minimum. > > On ARM, the hypercall has existed for a little over 4 weeks, and isn't > in any released version of Xen (yet). > > On x86, the hypercall has existed for more than a decade, and has known > out-of-tree users.  It needs to be deprecated properly, which in this > case means "phased out in the 4.18 cycle once known callers have been > adapted to the new hypercall". Understoon. Then I am in favor of getting all 4 patches in 4.17, either before the release or via backports. --8323329-429611521-1668564040=:4020-- From xen-devel-bounces@lists.xenproject.org Wed Nov 16 02:39:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 02:39:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444133.699004 (Exim 4.92) (envelope-from ) id 1ov8Kw-0003Hu-55; Wed, 16 Nov 2022 02:39:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444133.699004; Wed, 16 Nov 2022 02:39:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov8Kw-0003Hn-2A; Wed, 16 Nov 2022 02:39:38 +0000 Received: by outflank-mailman (input) for mailman id 444133; Wed, 16 Nov 2022 02:39:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov8Ku-0003Hh-JR for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 02:39:37 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20624.outbound.protection.outlook.com [2a01:111:f400:7e1b::624]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e6b363ea-6557-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 03:39:33 +0100 (CET) Received: from FR0P281CA0091.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::11) by DB4PR08MB9262.eurprd08.prod.outlook.com (2603:10a6:10:3f9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Wed, 16 Nov 2022 02:39:29 +0000 Received: from VI1EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a9:cafe::50) by FR0P281CA0091.outlook.office365.com (2603:10a6:d10:a9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Wed, 16 Nov 2022 02:39:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT059.mail.protection.outlook.com (100.127.144.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 02:39:28 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Wed, 16 Nov 2022 02:39:28 +0000 Received: from 90ac78ffd114.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B22D9BCC-492A-4779-9598-9DFF38B927C5.1; Wed, 16 Nov 2022 02:39:20 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 90ac78ffd114.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 16 Nov 2022 02:39:20 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM8PR08MB6483.eurprd08.prod.outlook.com (2603:10a6:20b:315::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Wed, 16 Nov 2022 02:39:15 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%7]) with mapi id 15.20.5834.007; Wed, 16 Nov 2022 02:39:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6b363ea-6557-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8PQtvfzn0B9EKD8B/cX14eepmMdB3LqMutpgoBx21Q8=; b=5Nn8xy9wgEJsxA+xu2xkSAsTGHUcwJ+i5fQku07Dp49oxMX51eHIW6YzV9WdS8LDfzsq/AUXlEUbALu89N58Ph/wWDiG7JhgJVZ31YyOva/RMr8m9TJheaFmQAmMSd6UlXtRABhHV+AYrfE9d/LW3eIcGJ/meiQlIoiGB2BB0LU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G558g/PsINp/YcXbFlu91LBe9QMekH+yUWZPScFeNqQzC51qaG0E6354f+ri7fQ6kLCJJtRyWVyWvwQ6vZmnMiKdUrIs36mLyUWyzs56KIqQdePhQumqqcN6kWscR9qOtGlTu1IjXWzGaaDJzCvgXqyL/bR9ULlGan50bGinnZoHEvAbkt3d7t5YmK274NjUNia1lLCvvmb8Zot+fo/fpWAANR6ftPxZt9icEwjmqRJnNjeXyQNTQQtLgBbmsDPVUmaV43iGs0uGAYXfhwHTK+90jt3AOpHBzvxlro2MpzFXVw9IiTN/zr81BITcebKB24QmCSD8Gl3e+DWEEF+OkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8PQtvfzn0B9EKD8B/cX14eepmMdB3LqMutpgoBx21Q8=; b=AMb/P0dgKfg4kyV/KwKX/yfdEYuylYfHyaHliwxdORVpO8Ic9rnVo8Z9LEJBguOOjjk6R3a6cAdAUsw5ef4n6KiOOxGP/FeRSPHitjljBKCXXYjCKqUusYZPRiLWu6NG9py+5dTAaASaVeDX/b7obBiRlxt77V+1LUVopkwT9L4OuQLAFnSOQDPzfVIpscAo2lzZJ1QBp2orA3C/btUo8XV7A04fOOvu57wYnHXr2aVnlrw8GeVXCK5AoNzw29sRaXVQvqe8K4rz6HWJ5Eqg9Z6XTW+qCcmci/qtfydC8MgFq7W+BorIrfklDAX54cvKEM2QlMWbW3knnMIbAlwasQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8PQtvfzn0B9EKD8B/cX14eepmMdB3LqMutpgoBx21Q8=; b=5Nn8xy9wgEJsxA+xu2xkSAsTGHUcwJ+i5fQku07Dp49oxMX51eHIW6YzV9WdS8LDfzsq/AUXlEUbALu89N58Ph/wWDiG7JhgJVZ31YyOva/RMr8m9TJheaFmQAmMSd6UlXtRABhHV+AYrfE9d/LW3eIcGJ/meiQlIoiGB2BB0LU= From: Henry Wang To: Stefano Stabellini , Andrew Cooper CC: Xen-devel , Xen Security Team , Jan Beulich , Roger Pau Monne , Wei Liu , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Anthony Perard Subject: RE: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls Thread-Topic: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls Thread-Index: AQHY6SSq6cLZ8k5bLkuflpP51dz+Ha5A5cGAgAAC9ICAAANygIAACOig Date: Wed, 16 Nov 2022 02:39:14 +0000 Message-ID: References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-4-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D1AE173D3C35E54BB9319CB9ABDD5AAB.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM8PR08MB6483:EE_|VI1EUR03FT059:EE_|DB4PR08MB9262:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d2e371b-12f3-4a0e-0d17-08dac77bc8d0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 61XS/uiEbOBP09k2Pv6C7Pg7oZ381zmSjecM/05lgF0VI4/VUbvhW4o5U+I+cqXczsOSKUGKgPh2/JYZtLFM6EGRONNiohv9dofO9G45JZ8YiOoTXpeQjxH6yHhqzti/lnSbbElDmxVAdSd4MNQ4elFboHbuzyoDMSUQQp5KFEuDhkBGuBa6t7yc19c45a7L42RLlbpy7qbWv5NEB/ZF2zVZCjk1Ae/iH5i49nFjzEOVcgWF4APaH2iBgIhAxMGcqMp4awCO7c3K2OcTRs0pGVGsUzl5LrwSke3S/Sn8ArEbiPQ32sH/VF64CRRbMGopK4gznP0a3gxqaIgvDhvx7BWFObqi1Zdjspf/p5qy1FCkcGT90GSAk2OJ64fF3G1OSl0D/PATOlHb8urcPP3XBQ7/LazeT709HIWm3rgO2C2BSMQIDYw7PLFLsLehhFQoC3uztgI4mqSi8S5uvQckjD7uZ3NxKiKq56QKCoJt9bJdJT84bEKO3CmqfcHDvux9hL2H/LcGBAsgVeqrCM5tA7gcxSpaapDe5ZgoFE2wvx+wR95LYSUQnDxspt+T2RjDl4RlnvdT4ZFZeqPtWtkGCh0TKtrH6gqS5e6yS81VjilWz5zc3cw7Tpv+hKzUMg9RGoJ8R6kvO5u5pRZJi7p2IiuQdpmPyoWYBNso9ZAGQkNpWrhkdweG9FEp5sXfiiDqvrn1GAJA01GXmNC9LSZDYqr3SVvWUlgZZhPwMeL4aICSdqKyxQFKTh1Rvj1aaAlxJ28Qx/jvlQwSKBAzW9ZdkA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(396003)(366004)(136003)(451199015)(2906002)(66899015)(5660300002)(33656002)(66946007)(66556008)(66446008)(64756008)(66476007)(41300700001)(76116006)(55016003)(86362001)(8936002)(53546011)(6506007)(7696005)(110136005)(38100700002)(83380400001)(122000001)(38070700005)(54906003)(7416002)(186003)(52536014)(4326008)(8676002)(26005)(9686003)(316002)(71200400001)(478600001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6483 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 64678193-b17f-4aad-ffe6-08dac77bc06d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FGzpwW15qA82Da9djOrnBbqDM5o7HgZh3opJztCdQqkMrPdfJOaV6pF/Y3zdCeQYdFfqruQwIyoUxzHaHM59wLDhBKYqnk+YNcjjYeo3aUsgcoSOjqXgXBjTygl90h43b9X3SD2lEo0szdOfdYMYfpLHzjPhK7Lny0JfMagrzYtvg0V+IKiQbFZqcwHUI8d6ztEORGcTMflMOufGi1d+z26lPLK1P02Uu5Zrg9a7NPzReeR0AyZtpK5t+MVVnwiL+IPTSboWaZxZdXEd9AEhyiqnx5j1d06r3F47c61E/UT1i8D/iOPMw9s9j9TM0ZtHhLHV3rQvAtBEiVc34aUAsajqMUX7xJJFYnkRQKV/6qSvvy3PyidUx+OsHQIgzOfR9tLyKUJ8+3wMpv1RQLmd/uBWn6KSZVDlWVthB146yWT7xhuHNR1k9rSIQb7QwGaBWx7i6E4Ey9y3vEZbaAhE+q0mBGooXYJbDfVlbTMqUJcC/Wn7z20ecyHs2IWCkRyfn/uXOnjbuSS6CCk+uAG4XC2ImwBgu41Z/SRj5qhFGGEgh3f9pGkP8sYbLImucTMn+E/BLmt6bqkaIHZlRVyGw+onc6WiSOBk3tbFo8qScQT5NiVR9vGadUEirfhrFIBY7+WeWL4djvpUe7B97eLNTdolR+JvFloRBNkIheEiCPPV/Df1WJ6LGO1L87b1sKWliwcw12KUaDCqFV3/SWfm/CiV4BIWOSxBqfzH0lw8g9QkP69+x7kDpZiHeBSttwUh3gf7wP/JUTG6QpSfE/ANRg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(136003)(346002)(376002)(451199015)(40470700004)(36840700001)(46966006)(7696005)(26005)(9686003)(6506007)(81166007)(478600001)(356005)(336012)(36860700001)(82740400003)(53546011)(107886003)(2906002)(41300700001)(54906003)(33656002)(40460700003)(186003)(110136005)(55016003)(40480700001)(316002)(52536014)(4326008)(8676002)(5660300002)(70206006)(70586007)(83380400001)(66899015)(86362001)(8936002)(47076005)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 02:39:28.8923 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d2e371b-12f3-4a0e-0d17-08dac77bc8d0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9262 SGkgQW5kcmV3IGFuZCBTdGVmYW5vLA0KDQpUaGFua3MgZm9yIHB1c2hpbmcgdGhpbmdzIGZvcndh cmQhDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogU3RlZmFubyBTdGFi ZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIDMv NF0geGVuL2FybSwgbGlieGw6IFJldmVydCBYRU5fRE9NQ1RMX3NoYWRvd19vcDsNCj4gdXNlIHAy bSBtZW1wb29sIGh5cGVyY2FsbHMNCj4gDQo+IE9uIFdlZCwgMTYgTm92IDIwMjIsIEFuZHJldyBD b29wZXIgd3JvdGU6DQo+ID4gT24gMTYvMTEvMjAyMiAwMTozNywgU3RlZmFubyBTdGFiZWxsaW5p IHdyb3RlOg0KPiA+ID4gT24gV2VkLCAyNiBPY3QgMjAyMiwgQW5kcmV3IENvb3BlciB3cm90ZToN Cj4gPiA+PiBUaGlzIHJldmVydHMgbW9zdCBvZiBjb21taXQNCj4gY2YyYTY4ZDJmZmJjM2NlOTVl MDE0NDlkNDYxODBiZGRiMTBkMjRhMCwgYW5kIGJpdHMNCj4gPiA+PiBvZiBjYmVhNWExMTQ5Y2E3 ZmQ0YjdjZGJmYTNlYzJlNGYxMDliNjAxZmY3Lg0KPiA+ID4+DQo+ID4gPj4gRmlyc3Qgb2YgYWxs LCB3aXRoIEFSTSBib3Jyb3dpbmcgeDg2J3MgaW1wbGVtZW50YXRpb24sIHRoZSBsb2dpYyB0byBz ZXQNCj4gdGhlDQo+ID4gPj4gcG9vbCBzaXplIHNob3VsZCBoYXZlIGJlZW4gY29tbW9uLCBub3Qg ZHVwbGljYXRlZC4gIEludHJvZHVjZQ0KPiA+ID4+IGxpYnhsX19kb21haW5fc2V0X3AybV9wb29s X3NpemUoKSBhcyBhIHNoYXJlZCBpbXBsZW1lbnRhdGlvbiwgYW5kDQo+IHVzZSBpdCBmcm9tDQo+ ID4gPj4gdGhlIEFSTSBhbmQgeDg2IHBhdGhzLiAgSXQgaXMgbGVmdCBhcyBhbiBleGVyY2lzZSB0 byB0aGUgcmVhZGVyIHRvIGp1ZGdlDQo+IGhvdw0KPiA+ID4+IGxpYnhsL3hsIGNhbiByZWFzb25h Ymx5IGZ1bmN0aW9uIHdpdGhvdXQgdGhlIGFiaWxpdHkgdG8gcXVlcnkgdGhlIHBvb2wNCj4gc2l6 ZS4uLg0KPiA+ID4+DQo+ID4gPj4gUmVtb3ZlIEFSTSdzIHAybV9kb21jdGwoKSBpbmZyYXN0cnVj dHVyZSBub3cgdGhlIGZ1bmN0aW9hbmxpdHkgaGFzDQo+IGJlZW4NCj4gPiA+PiByZXBsYWNlZCB3 aXRoIGEgd29ya2luZyBhbmQgdW5pdCB0ZXN0ZWQgaW50ZXJmYWNlLg0KPiA+ID4+DQo+ID4gPj4g VGhpcyBpcyBwYXJ0IG9mIFhTQS00MDkgLyBDVkUtMjAyMi0zMzc0Ny4NCj4gPiA+IEdlbnVpbmUg cXVlc3Rpb246IEkgY2FuIHNlZSB0aGlzIHBhdGNoIHJlbW92ZXMgdGhlIGltcGxlbWVudGF0aW9u IG9mDQo+ID4gPiBYRU5fRE9NQ1RMX1NIQURPV19PUF9TRVRfQUxMT0NBVElPTiBvbiBBUk0uIEl0 IGFsc28gc3dpdGNoZXMNCj4gbGlieGwgKGJvdGgNCj4gPiA+IEFSTSBhbmQgeDg2KSB0byB0aGUg bmV3IGh5cGVyY2FsbC4NCj4gPiA+DQo+ID4gPiBXaHkga2VlcCB0aGUgb2xkIGh5cGVyY2FsbCAo WEVOX0RPTUNUTF9zaGFkb3dfb3AgYW5kDQo+ID4gPiBYRU5fRE9NQ1RMX1NIQURPV19PUF9TRVRf QUxMT0NBVElPTikgaW1wbGVtZW50YXRpb24gb24geDg2DQo+IChub3Qgb24gQVJNKT8NCj4gPiA+ DQo+ID4gPiBJcyB0aGF0IGJlY2F1c2UgaXQgd2FzIG9ubHkgcmVjZW50bHkgaW1wbGVtZW50ZWQ/ IEFuZCBub3QgYWN0dWFsbHkNCj4gPiA+IHByZXNlbnQgaW4gYW55IHBhc3QgWGVuIHJlbGVhc2U/ DQo+ID4gPg0KPiA+ID4gSWYgc28sIHBsZWFzZSBhZGQgYSBub3RlIGFib3V0IHRoaXMgaW4gdGhl IGNvbW1pdCBtZXNzYWdlLiBBbHNvLCBpZiB0aGF0DQo+ID4gPiBpcyB0aGUgY2FzZSwgSSB0aGlu ayB0aGlzIHBhdGNoIHNlcmllcyBzaG91bGQgZ28gaW4gNC4xNy4gSWYgaXQgaXMgdG9vDQo+ID4g PiBsYXRlIHRvIGdldCBpdCBpbiBiZWZvcmUgdGhlIHJlbGVhc2UsIHRoZW4gd2Ugc2hvdWxkIGJh Y2twb3J0IGl0IHRvIDQuMTcNCj4gPiA+IGFzIHNvb24gYXMgcG9zc2libGUuIFRoYXQncyBiZWNh dXNlIGlkZWFsbHkgd2Ugd2FudCB0byBrZWVwIHRoZQ0KPiA+ID4gaHlwZXJjYWxsIGludGVyZmFj ZSBjaGFuZ2VzIGRvd24gdG8gYSBtaW5pbXVtLg0KPiA+DQo+ID4gT24gQVJNLCB0aGUgaHlwZXJj YWxsIGhhcyBleGlzdGVkIGZvciBhIGxpdHRsZSBvdmVyIDQgd2Vla3MsIGFuZCBpc24ndA0KPiA+ IGluIGFueSByZWxlYXNlZCB2ZXJzaW9uIG9mIFhlbiAoeWV0KS4NCj4gPg0KPiA+IE9uIHg4Niwg dGhlIGh5cGVyY2FsbCBoYXMgZXhpc3RlZCBmb3IgbW9yZSB0aGFuIGEgZGVjYWRlLCBhbmQgaGFz IGtub3duDQo+ID4gb3V0LW9mLXRyZWUgdXNlcnMuwqAgSXQgbmVlZHMgdG8gYmUgZGVwcmVjYXRl ZCBwcm9wZXJseSwgd2hpY2ggaW4gdGhpcw0KPiA+IGNhc2UgbWVhbnMgInBoYXNlZCBvdXQgaW4g dGhlIDQuMTggY3ljbGUgb25jZSBrbm93biBjYWxsZXJzIGhhdmUgYmVlbg0KPiA+IGFkYXB0ZWQg dG8gdGhlIG5ldyBoeXBlcmNhbGwiLg0KPiANCj4gVW5kZXJzdG9vbi4gVGhlbiBJIGFtIGluIGZh dm9yIG9mIGdldHRpbmcgYWxsIDQgcGF0Y2hlcyBpbiA0LjE3LCBlaXRoZXINCj4gYmVmb3JlIHRo ZSByZWxlYXNlIG9yIHZpYSBiYWNrcG9ydHMuDQoNClNvcnJ5IC0gdG9kYXkgaXQgdG9vayBtZSBh IGxpdHRsZSBiaXQgbG9uZ2VyIHRvIGdldCB0aGUgb2ZmaWNlLCBzbyBob3BlZnVsbHkNCkkgc3Rp bGwganVtcGVkIGludG8gZGlzY3Vzc2lvbiBvbiB0aW1lLg0KDQpBYm91dCB0aGlzIHNlcmllcywg SSBkb24ndCBoYXZlIHN0cm9uZyBvYmplY3Rpb24gdG8gdGFraW5nIGFsbCA0IHBhdGNoZXMsIHNv DQppZiB0aGlzIHNlcmllcyBjYW4gaGF2ZSBwcm9wZXIgcmV2aWV3L2FncmVlbWVudHMgYnkgdGhp cyB3ZWVrZW5kLCBmZWVsIGZyZWUNCnRvIGFkZCBteSByZWxlYXNlLWFjayBmb3IgdGhlIHBhdGNo ZXMuDQoNCkhvd2V2ZXIsIGlmIHdlIGNhbm5vdCBzb3J0IG91dCBhbGwgNCBwYXRjaGVzLCBJIHRo aW5rIGF0IGxlYXN0IHBhdGNoICM0IHNob3VsZA0KZ28gaW50byA0LjE3ICh3aXRoIGEgY29tbWl0 IG1lc3NhZ2UgYWRqdXN0bWVudCkuIFRoZSBwYXRjaCAjNCBhbHJlYWR5IGhhcw0KcHJvcGVyIHRh Z3MgZnJvbSBBcm0gbWFpbnRhaW5lciBhbmQgbWUuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 16 03:40:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 03:40:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444138.699015 (Exim 4.92) (envelope-from ) id 1ov9Ht-0003Ga-E4; Wed, 16 Nov 2022 03:40:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444138.699015; Wed, 16 Nov 2022 03:40:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov9Ht-0003GT-Ad; Wed, 16 Nov 2022 03:40:33 +0000 Received: by outflank-mailman (input) for mailman id 444138; Wed, 16 Nov 2022 03:40:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov9Hr-0003GJ-Ts; Wed, 16 Nov 2022 03:40:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov9Hr-0006fv-OL; Wed, 16 Nov 2022 03:40:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov9Hr-0000w1-G2; Wed, 16 Nov 2022 03:40:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ov9Hr-0005Zr-Eu; Wed, 16 Nov 2022 03:40:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NTYNmneLEyRk/C4yScAboI4wBYG0wwO8dVeVn/lSOyA=; b=iSGDj7LDa0pUWGH2HUSFoPT29d 64tRCW+zwD7Tc2bdHrza5VMr/E+NLOjli8kI6wvqeyzueoJ9ZBOJ0NeHuJ4rZuFtFu084plFyQbf/ HhJudAH+zQIYHM0N11wl2BrSZdw7a1FC95UmHDekO1M3Lcn5zHUfFYIr6pUJu8lHNp+s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174782: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=aa717d803eb5442c0ab9c6f078b6ff2078092bae X-Osstest-Versions-That: xen=c805ceb0b26a643c7e47f01f2dbc50555d93cce8 From: osstest service owner Date: Wed, 16 Nov 2022 03:40:31 +0000 flight 174782 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174782/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen aa717d803eb5442c0ab9c6f078b6ff2078092bae baseline version: xen c805ceb0b26a643c7e47f01f2dbc50555d93cce8 Last test of basis 174766 2022-11-14 11:04:24 Z 1 days Testing same since 174782 2022-11-16 00:03:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c805ceb0b2..aa717d803e aa717d803eb5442c0ab9c6f078b6ff2078092bae -> smoke From xen-devel-bounces@lists.xenproject.org Wed Nov 16 04:03:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 04:03:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444144.699026 (Exim 4.92) (envelope-from ) id 1ov9dp-0006CX-9M; Wed, 16 Nov 2022 04:03:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444144.699026; Wed, 16 Nov 2022 04:03:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov9dp-0006CQ-58; Wed, 16 Nov 2022 04:03:13 +0000 Received: by outflank-mailman (input) for mailman id 444144; Wed, 16 Nov 2022 04:03:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ov9dn-0006CK-EA for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 04:03:11 +0000 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94fc1fad-6563-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 05:03:10 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id r61-20020a17090a43c300b00212f4e9cccdso1078993pjg.5 for ; Tue, 15 Nov 2022 20:03:10 -0800 (PST) Received: from rocinante (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id nl8-20020a17090b384800b0020d48bc6661sm390550pjb.31.2022.11.15.20.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 20:03:08 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94fc1fad-6563-11ed-8fd2-01056ac49cbb X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1zIzDKHHVNaVurdU/es7VrrKvHMyE/kDIQtf0pEpjIw=; b=m06WN6cB7tRh9lZXBZz3lPallw7ZqYqu1EKs46S5gxo6Hf4D7ZwHmZlRuGsQzNd56o JHQs6JGHRU0ypTPWH+tkIAa/NYZ5d7EVq0mZXZHmWjuZ9sKUPnjGyYTjZhm+NSwUXs9A hmvhou/DG7PGO9m8cGh7ekMZ4U8l7+UPQaawYXQZ4QjXw5M2vOTTiYxN286VpF1efG5M Y8elOZvZfa3vg2PGxRIv6/bzNCb4agZJaPMAyUuewNDezpbKt797NdzpG7bswvlt89bj W1ueWNp8PjvHP29f5FFKGgejn1Uballf0dyCzph/H51dSPQ1N+7G/oN/G74ofvalueNh FjoA== X-Gm-Message-State: ANoB5pnZOZziBBhB4MXFmKJZiPzpEzokxiCZkVh+xa9Uxtrlt8vXlbHd mlTI4iQu4xOri2yI4BsWB1w= X-Google-Smtp-Source: AA0mqf6hyhoq112sIKQo2v/k51nNvfWIgxwNBEvlAx1Pthk/+MTebE7MSfBKsrWrQE5FLsqcaK8YIQ== X-Received: by 2002:a17:90a:3f89:b0:217:90e0:3f8c with SMTP id m9-20020a17090a3f8900b0021790e03f8cmr1687555pjc.192.1668571388739; Tue, 15 Nov 2022 20:03:08 -0800 (PST) Date: Wed, 16 Nov 2022 13:03:01 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Andy Shevchenko Cc: =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Mika Westerberg , Michael Ellerman , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Pali =?utf-8?B?Um9ow6Fy?= , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v3 0/4] PCI: Add pci_dev_for_each_resource() helper and Message-ID: References: <20221114185822.65038-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221114185822.65038-1-andriy.shevchenko@linux.intel.com> Hello, > Provide two new helper macros to iterate over PCI device resources and > convert users. > > Looking at it, refactor existing pci_bus_for_each_resource() and convert > users accordingly. > > This applies on top of this patch Mika sent out earlier: > https://lore.kernel.org/r/20221114115953.40236-1-mika.westerberg@linux.intel.com > > Changelog v3: > - rebased on top of v2 by Mika, see above > - added tag to pcmcia patch (Dominik) [...] Thank you Andy for all the improvements and Mika for the idea! For the whole series: Reviewed-by: Krzysztof Wilczyński Looks very nice! Krzysztof From xen-devel-bounces@lists.xenproject.org Wed Nov 16 04:27:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 04:27:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444150.699037 (Exim 4.92) (envelope-from ) id 1ovA10-0000jP-8A; Wed, 16 Nov 2022 04:27:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444150.699037; Wed, 16 Nov 2022 04:27:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovA10-0000jI-4z; Wed, 16 Nov 2022 04:27:10 +0000 Received: by outflank-mailman (input) for mailman id 444150; Wed, 16 Nov 2022 04:27:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovA0y-0000j7-Ul for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 04:27:08 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id edae9900-6566-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 05:27:07 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6916F13D5; Tue, 15 Nov 2022 20:27:12 -0800 (PST) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 81C843F663; Tue, 15 Nov 2022 20:26:54 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: edae9900-6566-11ed-8fd2-01056ac49cbb From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Jan Beulich , Andrew Cooper , Christopher Clark , Nathan Studer , Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Doug Goldstein , Juergen Gross , Dario Faggioli , Elena Ufimtseva , George Dunlap , Nick Rosbrook , Lukasz Hawrylko , "Daniel P . Smith" , =?UTF-8?q?Mateusz=20M=C3=B3wka?= , Kevin Tian , Jun Nakajima , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Anthony Perard , Bob Eshleman , Alistair Francis , Connor Davis , Meng Xu , Samuel Thibault , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Daniel De Graaf , Quan Xu , Community Manager Subject: [PATCH v2 0/3] Populate entries for 4.17 Date: Wed, 16 Nov 2022 04:26:31 +0000 Message-Id: <20221116042634.50948-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hello, The following changes are preparation work for the 4.17 release. Also collecting the changelog changes happened during the 4.17 dev phase. This is my first pass at the log for the release, it's likely missing more entries. I'm Ccing all maintainers in this cover letter and also in patch #1 for further feedback on missing items. Thanks, Henry v1 -> v2: - Pick other changelog patches happened during the 4.17 dev phase. - Correct wording for two x86 entries (clock frequency calibration and SPR & ADL support) following Jan's suggestion. - Add missing Arm entries from Oleksandr. - Add missing i.MX entry following Stefano's suggestion. Andrew Cooper (1): Changelog: Add __ro_after_init and CET Henry Wang (2): CHANGELOG: Add missing entries for work during the 4.17 release CHANGELOG: Start new "unstable" section CHANGELOG.md | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 16 04:27:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 04:27:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444152.699047 (Exim 4.92) (envelope-from ) id 1ovA1I-00015O-GC; Wed, 16 Nov 2022 04:27:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444152.699047; Wed, 16 Nov 2022 04:27:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovA1I-00015H-DX; Wed, 16 Nov 2022 04:27:28 +0000 Received: by outflank-mailman (input) for mailman id 444152; Wed, 16 Nov 2022 04:27:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovA1H-0000j7-Es for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 04:27:27 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id f8eae229-6566-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 05:27:25 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5ECC013D5; Tue, 15 Nov 2022 20:27:31 -0800 (PST) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7B5AC3F663; Tue, 15 Nov 2022 20:27:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8eae229-6566-11ed-8fd2-01056ac49cbb From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Jan Beulich , Andrew Cooper , Christopher Clark , Nathan Studer , Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Doug Goldstein , Juergen Gross , Dario Faggioli , Elena Ufimtseva , George Dunlap , Nick Rosbrook , Lukasz Hawrylko , "Daniel P . Smith" , =?UTF-8?q?Mateusz=20M=C3=B3wka?= , Kevin Tian , Jun Nakajima , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Anthony Perard , Bob Eshleman , Alistair Francis , Connor Davis , Meng Xu , Samuel Thibault , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Daniel De Graaf , Quan Xu , Community Manager Subject: [PATCH v2 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Date: Wed, 16 Nov 2022 04:26:32 +0000 Message-Id: <20221116042634.50948-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221116042634.50948-1-Henry.Wang@arm.com> References: <20221116042634.50948-1-Henry.Wang@arm.com> Signed-off-by: Henry Wang --- v1 -> v2: - Correct wording for two x86 entries (clock frequency calibration and SPR & ADL support) following Jan's suggestion. - Add missing Arm entries from Oleksandr. - Add missing i.MX entry following Stefano's suggestion. --- CHANGELOG.md | 32 ++++++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index adbbb216fa..4f58a82602 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,16 +4,44 @@ Notable changes to Xen will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) -## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD +## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2022-11-?? ### Changed - On x86 "vga=current" can now be used together with GrUB2's gfxpayload setting. Note that this requires use of "multiboot2" (and "module2") as the GrUB commands loading Xen. + - The "gnttab" option now has a new command line sub-option for disabling the + GNTTABOP_transfer functionality. + - The x86 MCE command line option info is now updated. ### Added / support upgraded + - Out-of-tree builds for the hypervisor now supported. + - The project has officially adopted 4 directives and 24 rules of MISRA-C, + added MISRA-C checker build integration, and defined how to document + deviations. - IOMMU superpage support on x86, affecting PV guests as well as HVM/PVH ones when they don't share page tables with the CPU (HAP / EPT / NPT). - - Support VIRT_SSBD feature for HVM guests on AMD. + - Support VIRT_SSBD feature for HVM guests on AMD and MSR_SPEC_CTRL feature for + SVM guests. + - Improved TSC, CPU, and APIC clock frequency calibration on x86. + - Add mwait-idle support for SPR and ADL on x86. + - Extend security support for hosts to 12 TiB of memory on x86. + - Add command line option to set cpuid parameters for dom0 at boot time on x86. + - Improved static configuration options on Arm. + - cpupools can be specified at boot using device tree on Arm. + - It is possible to use PV drivers with dom0less guests, allowing statically + booted dom0less guests with PV devices. + - On Arm, p2m structures are now allocated out of a pool of memory set aside at + domain creation. + - Improved mitigations against Spectre-BHB on Arm. + - Support VirtIO-MMIO devices in toolstack on Arm. + - Allow setting the number of CPUs to activate at runtime from command line + option on Arm. + - Grant-table support on Arm was improved and hardened by implementing + "simplified M2P-like approach for the xenheap pages" + - Add Renesas R-Car Gen4 IPMMU-VMSA support on Arm. + - Add i.MX lpuart and i.MX8QM initial support on Arm. + - Improved toolstack build system. + - Add Xue - console over USB 3 Debug Capability. ### Removed / support downgraded - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 16 04:27:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 04:27:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444153.699058 (Exim 4.92) (envelope-from ) id 1ovA1Q-0001QH-Ni; Wed, 16 Nov 2022 04:27:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444153.699058; Wed, 16 Nov 2022 04:27:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovA1Q-0001Q8-L7; Wed, 16 Nov 2022 04:27:36 +0000 Received: by outflank-mailman (input) for mailman id 444153; Wed, 16 Nov 2022 04:27:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovA1P-0001PM-Iu for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 04:27:35 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id fdb8fff5-6566-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 05:27:34 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F8CE13D5; Tue, 15 Nov 2022 20:27:39 -0800 (PST) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id F0C0D3F663; Tue, 15 Nov 2022 20:27:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdb8fff5-6566-11ed-91b6-6bf2151ebd3b From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Henry Wang , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Community Manager Subject: [PATCH v2 2/3] Changelog: Add __ro_after_init and CET Date: Wed, 16 Nov 2022 04:26:33 +0000 Message-Id: <20221116042634.50948-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221116042634.50948-1-Henry.Wang@arm.com> References: <20221116042634.50948-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Andrew Cooper Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné --- v1 -> v2: - Include this patch in the series --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4f58a82602..7418fc9326 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,7 +22,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) when they don't share page tables with the CPU (HAP / EPT / NPT). - Support VIRT_SSBD feature for HVM guests on AMD and MSR_SPEC_CTRL feature for SVM guests. + - __ro_after_init support on x86, for marking data as immutable after boot. - Improved TSC, CPU, and APIC clock frequency calibration on x86. + - Support for Xen using x86 Control Flow Enforcement technology for its own + protection. Both Shadow Stacks (ROP protection) and Indirect Branch + Tracking (COP/JOP protection). - Add mwait-idle support for SPR and ADL on x86. - Extend security support for hosts to 12 TiB of memory on x86. - Add command line option to set cpuid parameters for dom0 at boot time on x86. -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 16 04:27:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 04:27:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444154.699070 (Exim 4.92) (envelope-from ) id 1ovA1U-0001oZ-1G; Wed, 16 Nov 2022 04:27:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444154.699070; Wed, 16 Nov 2022 04:27:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovA1T-0001oS-ST; Wed, 16 Nov 2022 04:27:39 +0000 Received: by outflank-mailman (input) for mailman id 444154; Wed, 16 Nov 2022 04:27:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovA1S-0001PM-9V for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 04:27:38 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ff630800-6566-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 05:27:36 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4BBD513D5; Tue, 15 Nov 2022 20:27:42 -0800 (PST) Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com [10.169.212.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A4B523F663; Tue, 15 Nov 2022 20:27:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff630800-6566-11ed-91b6-6bf2151ebd3b From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Community Manager Subject: [PATCH v2 3/3] CHANGELOG: Start new "unstable" section Date: Wed, 16 Nov 2022 04:26:34 +0000 Message-Id: <20221116042634.50948-4-Henry.Wang@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221116042634.50948-1-Henry.Wang@arm.com> References: <20221116042634.50948-1-Henry.Wang@arm.com> Signed-off-by: Henry Wang Acked-by: Julien Grall --- v1 -> v2: - Add Julien's Acked-by. --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7418fc9326..014652a63b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ Notable changes to Xen will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) +## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD + ## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2022-11-?? ### Changed -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 16 04:56:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 04:56:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444170.699082 (Exim 4.92) (envelope-from ) id 1ovATJ-0006u3-97; Wed, 16 Nov 2022 04:56:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444170.699082; Wed, 16 Nov 2022 04:56:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovATJ-0006tw-3w; Wed, 16 Nov 2022 04:56:25 +0000 Received: by outflank-mailman (input) for mailman id 444170; Wed, 16 Nov 2022 04:56:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovATI-0006tm-3o; Wed, 16 Nov 2022 04:56:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovATH-0000UZ-W8; Wed, 16 Nov 2022 04:56:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovATH-0005NQ-K6; Wed, 16 Nov 2022 04:56:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovATH-0008Pg-JD; Wed, 16 Nov 2022 04:56:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Jz5+RzdwNvP3Uz5j+QSIls9YCuHWkstmzMorT/Q16AQ=; b=Y+hbsgtVPRkF6GhE46K2+Ykoo8 g3Ph1QY2v5SYJdh/oqkRamg+XE5+/CU6G05Ey8A01LsQW5SIcN2cVKay04qZ9dQLjlW+cV8UYnUVO Pr4gZLfUJte88dROVRw8EvS1bCzu17lrRXPCBAl20MH3g1eyQTC3GN5HFrg1N8mcnFFQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174780: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=bb00d0aa620e821cc2fbf2e0c5de45a8c957626c X-Osstest-Versions-That: qemuu=305f6f62d9d250a32cdf090ddcb7e3a5b26a342e From: osstest service owner Date: Wed, 16 Nov 2022 04:56:23 +0000 flight 174780 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174780/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174761 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174761 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174761 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174761 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174761 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174761 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174761 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174761 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu bb00d0aa620e821cc2fbf2e0c5de45a8c957626c baseline version: qemuu 305f6f62d9d250a32cdf090ddcb7e3a5b26a342e Last test of basis 174761 2022-11-14 01:07:28 Z 2 days Failing since 174772 2022-11-14 22:08:27 Z 1 days 3 attempts Testing same since 174780 2022-11-15 18:10:12 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alberto Faria Hanna Reitz Jens Wiklander Kevin Wolf Peter Maydell Stefan Hajnoczi Vikram Garhwal jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 305f6f62d9..bb00d0aa62 bb00d0aa620e821cc2fbf2e0c5de45a8c957626c -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Nov 16 06:48:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 06:48:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444178.699091 (Exim 4.92) (envelope-from ) id 1ovCDf-0003Xw-G4; Wed, 16 Nov 2022 06:48:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444178.699091; Wed, 16 Nov 2022 06:48:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovCDf-0003Xp-DW; Wed, 16 Nov 2022 06:48:23 +0000 Received: by outflank-mailman (input) for mailman id 444178; Wed, 16 Nov 2022 06:48:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovCDd-0003Xf-VQ; Wed, 16 Nov 2022 06:48:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovCDd-0003JC-Th; Wed, 16 Nov 2022 06:48:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovCDd-000404-3K; Wed, 16 Nov 2022 06:48:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovCDd-0003qR-2r; Wed, 16 Nov 2022 06:48:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qYWyRtFutwPhaU+Pn/E42yAft6gOPYd0YHVGFC3e1EY=; b=kE9RojKaHI1f4xfhEguh9rksVe AnexNw7G+OAL9Va8C3W9q796MLpnDgxYUPtimX4TVA/EVvg4nQVUVfND9yWhg/iEf8CsZssKR6vy0 PWrPPAGsVMZPRV+fvLbi5VNDFdAuVaKGQplqdSHb5//HvbtAU5luGFlE1Wn28RwaUqbw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174786: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2a98e98f96d1aafddf8869db5e2382d0ddaae01a X-Osstest-Versions-That: xen=aa717d803eb5442c0ab9c6f078b6ff2078092bae From: osstest service owner Date: Wed, 16 Nov 2022 06:48:21 +0000 flight 174786 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174786/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 2a98e98f96d1aafddf8869db5e2382d0ddaae01a baseline version: xen aa717d803eb5442c0ab9c6f078b6ff2078092bae Last test of basis 174782 2022-11-16 00:03:14 Z 0 days Testing same since 174786 2022-11-16 04:02:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Roger Pau Monne Roger Pau Monné Stefano Stabellini Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git aa717d803e..2a98e98f96 2a98e98f96d1aafddf8869db5e2382d0ddaae01a -> smoke From xen-devel-bounces@lists.xenproject.org Wed Nov 16 07:41:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 07:41:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444186.699103 (Exim 4.92) (envelope-from ) id 1ovD2q-0002B7-Cf; Wed, 16 Nov 2022 07:41:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444186.699103; Wed, 16 Nov 2022 07:41:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovD2q-0002B0-9Q; Wed, 16 Nov 2022 07:41:16 +0000 Received: by outflank-mailman (input) for mailman id 444186; Wed, 16 Nov 2022 07:41:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovD2o-0002Au-Bd for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 07:41:14 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20613.outbound.protection.outlook.com [2a01:111:f400:7d00::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0aab2408-6582-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 08:41:13 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7148.eurprd04.prod.outlook.com (2603:10a6:10:12d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 16 Nov 2022 07:41:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 07:41:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0aab2408-6582-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eBUyS26uiOmPdR6NoHjGu6/Wtx9mh+9rLUEH3jf1PNZ/f3CIsVXMNVGRfSOnyMrrpTTwU3hTVFE/X3AODzL9XbkMsjWcJAHVlO6ZGP4wIEFE/JYZHS7v/gjYuATvz2iWT9S1RQyyDRb9/eMzC/cqc/OK89v7RokHO2YKbhDXjMPMmE8BIs0ahEPGcy4+WT3doSYFxkrvum6K4xgoLKs4/B0+l+bsP/fhA4i8YYZMl4JA35mayfMLgmwosEIC6NTGJCdlWlnz0D/nonG6UcM57T2GfDlR+KAHC4gkr+U0fPqf1aTo/MHO+3XLk1RRsxVrhYL2CzJoYViZ0y/RN2CZKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KRH2bjytmN4B/NCNdiqn+zEgoQ38Kq4POE9O7rRLD+c=; b=Wh04Qj+uMx0k2um1h64eb2LSRRRP4FE1mMHhu80+vlOyATawXF1wUYCdtwodtNUeWrCnglcYHc3DNgaljPURma/urh4859h5hNDHYZj9UTkrgSXxpCw3IgHIzwibQo5dHBK8BllIohNQOR44uuiggA0ZSYFpW2sOxJEU6kKiSTJVbVKjsdWI7M5ICSvMN8YaZ2kbFrjC6YDwolAdmKJoMV8Qif89T9lcjammhpIyGtNBXlCuT0Fop5eFSNQu/C/PKvkDxj4GMZA+se37Okhogn5KGC+TvqGfvQG+NkZzk5cuVoW99II5iHybdlzStfSE8lbuHFaAAPN9mTldLVw7Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KRH2bjytmN4B/NCNdiqn+zEgoQ38Kq4POE9O7rRLD+c=; b=5JD+r5yfBwOJiiGqt5yq2Hm2fAzYL6HLzDHaG7SgCmj1Czs3NjnXO+C80miWJqB9a0hyzLhfTlOtN8zMpcmeAcO3n9/5GLICqdI2GQouujQYV7XTxGTqIyVoOIDZuauuXsgO8dZq9m6VDUe5F3zTn4znAZKLLRQPtsK1YOZIpfV0rMRVH4sC55OuABiYofTVzT74s6xKUedNGAcBfK2Dklbr2TC9Qcu6KXWK4678f0xYvY6i9oXXfq1LvXj8p54/esf1jFvkfnlU0NleZQi5IaSUtfxrjgIjuHcccM66Wurq7KTrfhgqrznfsrio4xmwWD9s33LD6QMLm217bgS/ZA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 16 Nov 2022 08:41:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH for-4.17 v4 2/2] amd: remove VIRT_SC_MSR_HVM synthetic feature Content-Language: en-US To: Andrew Cooper Cc: "Henry.Wang@arm.com" , Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <20221115132657.97864-1-roger.pau@citrix.com> <20221115132657.97864-3-roger.pau@citrix.com> <5caf3930-ea8f-6e68-326f-93cca1fa210a@suse.com> <51e9dd3f-59fb-a112-baf7-f96c07800ee1@citrix.com> From: Jan Beulich In-Reply-To: <51e9dd3f-59fb-a112-baf7-f96c07800ee1@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P193CA0046.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7148:EE_ X-MS-Office365-Filtering-Correlation-Id: d90ef8a4-459c-4f73-fca2-08dac7a5ecdc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S85Dfrjc6LOVijjigeGLWDOb7fSK9AkhLAXF13+3JP/6/v4sdwXG+gt10uz3cm3T3xF784qC3zFmMI5ixLGCx7dfjt4OjNbRn+iDqhzCRqCxMyEAlH7ZhhZrIbusE+MPZhV7b1DWHrwZbgx4NM/ufjvmspxo5NFeWjHdEUEGBAPMfqKq4CRlce2qQEC8IRHA5m50VE5gtdW8aHo29eG0ALq/2dw0us0SYQ/Zsm2WcYypHBmpwm0gkGO4pcRe9F1MCGNzDodgXile22d0DTUlODWrlfeRBKmZSsgbcVoBRbUeFd6e5uD3sxuEuCUJgXVc6adqn7ldmFhGmiUa9ArxwOceU00Z9lFqwngXGsf3uEoU2Qp7zHMPIZMg3QkbNGb61UeL6vfRo+ZL9b8yTFWAHwBSmnO61KjOiZU+RKKwGOICOyUX2kNvULww8Z4Ou5gsmfrpdvn64aDkyLZuThIjY2cISDhonRJFiGIPWrw7fZ30ICIDZ9sW1VuH0ADXXzdaaGbNpj1p1uLHD+crdnFfU7BA7x4kRhKvUw1HSA6OCgybcdt4bM+eIdyM6qwfaels1lSRWkCHppCkI7WbIIaMCD4FYNIWXsyGrhuFlLpSWEmKiFxmrdT6yC34xBTMH4GvjuFSI+ME5w58WEnaZKwszrHmMlaCWmCaVf1rQu0ynXLvUl1Da0t9j23QRnCwwGZfeda2t5kuicEzZwX0l+KmOJSsK7zpZxmMf44ke6FoMUgb0RKduWT/rTchzBlHmUL0RYNQaXtDccbtnMDZoXHE75lkQbkuy5aJYk29COu2nsk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39860400002)(346002)(366004)(396003)(451199015)(53546011)(6506007)(26005)(4744005)(31696002)(36756003)(6486002)(2906002)(86362001)(478600001)(186003)(6512007)(2616005)(38100700002)(66899015)(54906003)(41300700001)(316002)(4326008)(31686004)(6916009)(8676002)(66556008)(66946007)(66476007)(8936002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2xQRjZ0S2dTekpWKzg1dXZlSG1oZlpqSkZTTnFDc29ua081N29PU2Y3Sys0?= =?utf-8?B?ZTJSM3lJMXNoNUh3OFhVTTRFVVB4MXJqTWI2elRvU0hYQ3d6amgwMWU4NDRP?= =?utf-8?B?V2c5amVQTlJkTU5rTkVyL1FFZ2NvQWV3amdPK01yMVVPcVp0TVBMYmdOYm5Q?= =?utf-8?B?S21ENkR1ZkJBUXQ1d3lDc3dHb2p1dkd5VkgvelI5aUxTQkQ5M1BmYTZNOG94?= =?utf-8?B?RDg4cnl6N0RtNEVtY0FYM201bTdZMnUwamNNUzZRUHNLOVFUcStnTnBDb2kr?= =?utf-8?B?VXhLcnp6KzlxcGJuSE1JYkFWL3lETnRYU294YUxCcVhVbWZkalNsdTlXWE42?= =?utf-8?B?NXcraVFPZ2lyR0pqSGROS2dSWDRTLzY3dUdHTVQ2YThOZTNOQXQvT3cvQUZY?= =?utf-8?B?bGt2YUZreUFpZFBxcnpqcjJERStpZGhHM3VpVkF4WTVhRzJtWEtSZitWV3Vy?= =?utf-8?B?eHZUSTE5S0Q3RlhpZTdXNGFwQ3VRa3c5UWxtMjZYSEd2eHFxc0ZDd0sxbUt6?= =?utf-8?B?OFhETnlJU004MW1yRGp4TWJiVnJ1SXo3anNZYzM0eWxqbG45ZG8rK2YzUEsv?= =?utf-8?B?dVI1aDBKZjZkbkVBVk0rVlVqVjdMR05TYjBISWQydzlpeGc5SXkvbWdqZUFD?= =?utf-8?B?SlZCbUFjUW1COXJvREw0dWlPMjRVb2M4dUd2T1hxNU9tWHdvc2RpNlpiRzB2?= =?utf-8?B?TExodFEvQm1rNkJXb0VYcXovbGo3T3ZvTHhDSEc1cnl1QnNhS1AvVlg3QmJK?= =?utf-8?B?Zm4zaHVoTnpuYnpuRjRMYkFKbjlISEtDR2Z0bDk0MjJnZ25jTWs3a0YyZU1D?= =?utf-8?B?bUF4Y1dqbitWbDh0VkNzTjhHU1dxVmpIYmNkbllLajh1QkdBQXdoVStQM01u?= =?utf-8?B?MXAzOW55S2tCcFVseGpwYldjOFdadm8xVlVzRTFJTlMwWllTU2d6Nnl6d3Jv?= =?utf-8?B?bEhlRTdaUmZiZVphRHUzN0hEWk0rZVlrZko2bFkzYWJJcEYvTG1uYlZYdTZ0?= =?utf-8?B?M3ZOTTlQL1RSMWt0VXpVRzYyT0NxbXRYS1BYYTRnQ0V3OEc3TG5QclN2MW5j?= =?utf-8?B?d1F6RkVSU01mWXpjampZZXB4S2VNbzZBUjBoUUY0Y2g4dEYwMHQrbkxuOHVP?= =?utf-8?B?YUU1ZUtxaXppeWR2YTZyVHBMWGZHNFdQRG1vYUJ5ZGZHWHA4d0ZUNmttOUlD?= =?utf-8?B?d2d2VDIrQXNjNHBkZ0dsNC9JRHJhRE11dCtEYmhXa1hQdS95S1ppWGJQbXZ2?= =?utf-8?B?RjVRN2x5Q0Y0RzhJZ3NreVkrUDU0LzZNRUY2R3NoUlhjUm4zM2ZRdVp2L1k2?= =?utf-8?B?N0IrRnhnRk84by9CdnpRSENBVmNlMk15VFpWSk1seUZpWm1kcDZubFhQNFFB?= =?utf-8?B?NllXZWc1ck5BZ2NURXg3eWhYWjhOMWVMSk43NGJEZjB2am9SU0VrYlgrcDFp?= =?utf-8?B?bndsVS9FWDdubGt6OVZ5cjR2RGtQdGYxNjhqelFoamtLOWcxSDhyUHJydlIx?= =?utf-8?B?QmJud2s1UCsyNG42NkZGcm12a0MxRlE3YnNsbDhZbVdja2lPcUN3OWJDUmJD?= =?utf-8?B?bVl6REY0UWlkNWRpOCtrNTkwSEthYjc3V1lxellNSFBXZWpIaFlSVXdwTGo1?= =?utf-8?B?Y0ZPdklqM2ljUlVWTTBMNlprclFCUjRYWUQxcGZYWHM3N2EyUkZpbjFZSWlw?= =?utf-8?B?TnZrM1I2MFd0SE8yU0ZQSjJ5dUJleEZ6S01jbHFVWlRseUtCd0dlekQ1MURM?= =?utf-8?B?Z2pjRnMvTDJWR0Mvc0tEZUU3aUpmVU41SnJnbHRUdmliRXJPTklzODd3QnF1?= =?utf-8?B?K1ZlZEtXckp2NWFiTWZHK3RYREdGbTJMWTE0aVc3ekFybTVtYndEVmRNa1Zl?= =?utf-8?B?ZVdOYXBvY2lkdHNIc2VHdVBnbW1PSDZmTWRhY09zSzcyM2RBOXJraVZnWFFJ?= =?utf-8?B?VVpIaXlML1l1dGgveXNjcU5ndUh2OW8wT1N4VHVFUnlKb2UzM240TlcvTU96?= =?utf-8?B?bVpSbGNydHpsM0N6YTQ5LzZWdkNZRG4rMGw5b2xVc25xSG1qc1hTWVRMMDVt?= =?utf-8?B?d1FtbUFWcnZpR3lHbHU0bjhaM1RrVTFjbzRIbkFqTzBOeFZYNFhrY1Q1UWF5?= =?utf-8?Q?evKIwFEb6UoZ831ERanUhjBir?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d90ef8a4-459c-4f73-fca2-08dac7a5ecdc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 07:41:08.5814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u0FixmsEAlzTIDMEiXmObvdsOLL5Q0IQLBpTmZaKyGRvAdc4V9H9St9NKS4t/AsLCX27FGlFBjJRMU7aT96/yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7148 On 16.11.2022 00:54, Andrew Cooper wrote: > On 15/11/2022 16:44, Jan Beulich wrote: >> I think we need to settle on at least halfway firm rules on when to use >> synthetic feature bits and when to use plain global booleans. Without >> that the tastes of the three of us are going to collide again every once >> in a while. > > Its very easy.  All other things being equal, synthetic features are the > most efficient option. See Roger's better wording of "why use a more complicated construct when a simple one will do". Yes, generated code may be better in certain cases, but no, we don't always judge by that aspect alone. Source simplicity is an important criteria, which at other times I recall you also weighing higher than the performance of resulting code (especially when dealing with performance aspects when they don't really matter at most/all use sites of whichever construct). Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 16 07:58:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 07:58:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444190.699113 (Exim 4.92) (envelope-from ) id 1ovDIr-00049F-Ov; Wed, 16 Nov 2022 07:57:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444190.699113; Wed, 16 Nov 2022 07:57:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDIr-000496-MG; Wed, 16 Nov 2022 07:57:49 +0000 Received: by outflank-mailman (input) for mailman id 444190; Wed, 16 Nov 2022 07:57:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDIr-00048x-9c for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 07:57:49 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130072.outbound.protection.outlook.com [40.107.13.72]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5be08e2d-6584-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 08:57:47 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7565.eurprd04.prod.outlook.com (2603:10a6:102:e7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Wed, 16 Nov 2022 07:57:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 07:57:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5be08e2d-6584-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f9D8Kl3/8Jpq0B+1UsIK5C+/sTbJB7bsUKhvLYlk7FaQ9OmaGqx+dde7m6hwZ5bX/rG2nJ37QpjI7ykp78fUMmvtw9pGHoZ7SRHDAYorjx/150sA+bFBThTWQYhYBvlTlia1n2/neysnLn7vi9PG1erx3N/Z+j7I4oh1cHtwr1/qDNhQKeUSNqzmQBFDT48PbeYaxFsMQ38uwwawcSAPVdxi3tu8fdIcNHxpuHNmA2FKFDht8dRfLL3w1p+u+3f3LdhPk3vQa7sa8Sx5Jv+0+qX9Fb51sT1NI2fecTxbp9o/7Fz13WhiBEwshCXBfvtyFPZud49sTfGiTWwImg9waA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XVkwyC+eRQLDywllsp3E9HaxtsG+K13gAnQMERM73Fo=; b=dvB2WmmOONKx5R7mUFj0FLxD+7iuyhnWkq14V8I+vTpvixi6M8q/KUlaps0vVegESxpUrJXmQ1vhVGBKIBIHcuSLC25Ixrcic/sn0lq2pgfzrMFsbw+7sO9O3GbzPEFMqUnheYToFpurwtmijXz6Z916wCYont3UfuJWFeBc+re6rztVjCS02V5/77lAAyIekRa+lmDzqfKF46gDhmXqJVHekBANK/IN37QFQBjsoFGEkzg7bwLngMCvc5L9MR4f531EfdQchhuo8I1DCh0f8SY1pMv0GCi6J53k8krESPHvn2fPaaXPESfonulsNxYK1diFvYb9s2Ef6jHfO3nn/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XVkwyC+eRQLDywllsp3E9HaxtsG+K13gAnQMERM73Fo=; b=nNoETIBVXT2kzH3a/LeRkMrgz69xo+nSXybY3XsFWhUwxVf904evIslCGBkeoAaMZ++bkSBgxA9bpJWOcWMmaTjCaVuZMwQHz8bVCRy8hRwFzAk5w0DB8bmr3C6v0TmwVT3KnplFNu09we5hm4OenCz6SSj3/S/ePhbQ4AvMY2aIiNOfJjzIhgHaHOCIGT8EQJekuZD5UEksYTcB4GNYRMrK3c3oYbwlKRaY4wFoEEBF9FWPJV9DyHAf0xVyXpKmZfA6W5s5zMhIYR+vKk5VaenhTf7Dw523pPKk0St3t4y5MAf5VCvSxZh8aPZLHMal5nT5yk8FJYouwgKtlY6ttA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7e3b7b5c-26d5-26b7-31b2-91813464b4dc@suse.com> Date: Wed, 16 Nov 2022 08:57:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] x86/irq: do not release irq until all cleanup is done Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20221115123500.97114-1-roger.pau@citrix.com> <6ba69073-3c58-2791-9572-c5c2e433db07@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0107.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7565:EE_ X-MS-Office365-Filtering-Correlation-Id: 06fbd940-2f1d-4ef3-2d4e-08dac7a82eaf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xxNPOV3rCS8/rYPsm4L9raXcg/GurBdfBjUxBDJwyZuXT5+xtKNs8qcwfcTnbGogtwpFIjVGV6BiQ3Txi7pH6J2VzLxo3CovrGGPdQ3rHU1a73rCOiDW7BwWAnQ2kTNN4qBnmBera1kFII1gfcmOFb5fxP9R407DMK0vviT9+zY4ye6f1D0EDGdcaP3er69Q8iLmnInSTW3DlqMmBJ/Yp9fOw7QLDYL8jaGNrxVe1kqfZUjCKVQk40FaqwmLrGo86zjX9IpH+uI5fCS73nnb+/Y5dbrBJak3PIwie+QqIynJ7FEK184Qt+1RQa/YxbkHZsQaCViTNkj8s+yHJcf2oyYG9nkl5TpsIyvJzlbUH6oMupBZOUq0W/fpiRPBL5IqpTFMq8QWTNtxJrvLsO7lGQjA+i1nUiIYjNRR6Cb9LuaWAx738NZ99K3WhslwwQazhHqt/p0HdaXiVHsESiERJ/PPo9h0haZZSSuqAHsZCT7tQ4aNEytA7Io60WGCGCk66HQW0PnSAM3ytdixv55qIVQ6ts5H4bS+jtZnsuoIRGQtuc6ayngn6NW0QvlepIPBIWKJPBTmJBKHttQDGwyhONxS35RmhcSZZNwI2XZfIzytNZ0z45PSnPkaeafHNfarf/jJaXP4K0vtFZrizxTRdfHxzCDNAu58iAVJyhLHgJjqQ0CkB1iqH/8+xv13sm+La+cLRk/6SpGuRtbLaaUed/b/+H2+Jg4c43yhn+5A/isVKaHnBEXYZhDkLwqE8Zj6V1ehIpBknfWnO5knoVAr5nt0AvSLHwTt9BISfoDSKs8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(396003)(136003)(346002)(366004)(451199015)(36756003)(31696002)(86362001)(558084003)(38100700002)(6486002)(31686004)(66556008)(6512007)(66946007)(26005)(66476007)(53546011)(316002)(6916009)(2906002)(6506007)(83380400001)(41300700001)(54906003)(8676002)(4326008)(186003)(478600001)(5660300002)(2616005)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFdpcThxSUU3RVZ3R0JEU09ncmk0czZsc1JDam8yaFI4eTNFTzVTcFpqOVRY?= =?utf-8?B?VGoxanBKN1FxZU5xZHQrclFvRDdob21udFhSa2hBbk91ajEwTHV4SDBJNS9Z?= =?utf-8?B?R0doeUpwWk12R2pCVDFtSXBKcWdxVTYySlluanM4VEhLT0JTb21VazBUTDZQ?= =?utf-8?B?NjByUm4vS21hYU1kZEdIRDRJRHFULysxQlV4RWNkdjRpWkY0QlJVNDQzZDY4?= =?utf-8?B?Q3RiVHZrTlBzQ2JZc2RySGNnYjJsTlhldFFaaW1TaDZ4ckwyVXBOM2dhSGJs?= =?utf-8?B?QktpaU5XM3RVRGxmS3dtdU5yOHZTUGtiRE1hZm1wV0xSVXdOTEZBUHY1RGlr?= =?utf-8?B?SFYxNlkvaC9Cd2MwaFRzdDlKbUFqcWhLTHFLMTBCaks5Z1l2U1JPczlrZ04r?= =?utf-8?B?ajE0cVo3NnNQV0tvalEwc2hRNmVob2h0N1dmbE10Qi9XUjJpQm9IdDVRb1ZU?= =?utf-8?B?N0d3MU9NSWR2STZIeTZ5T3FpU2IrRGUxM04zM3N0Ym1CazZxUjNWMGxPb0h5?= =?utf-8?B?ME1VYXB1bTBhMzVYdUJrSk85aWxhdWFuK3ZCWXZPc0tWTXR4cXh3MSsvWjlC?= =?utf-8?B?OTZxaklJZjVyQ210VzhveHlhTFpZaW1rOWIvZmhxc29mQ1QzY3dSZkdFSy9s?= =?utf-8?B?N3p5d2d6L1drcTJlcWtIQkh6Y3IwWWYvTm1XYURqTnB1d1R3K2JxVFYxTWhY?= =?utf-8?B?b1lMSFA5ZnBvNHBiczFTTmliNy9NVVJJUzhocG94MlJmaEVXMGltdG9jRGVZ?= =?utf-8?B?U2tScHQzc2xqS09PNmNlMUM5TW1aRitlR2doWnhvdHM2bmlCMG1ELzdBcnh6?= =?utf-8?B?YVplakEvZnNqNGRUVFEwbWkrOTVjR3JlbHo0bGJwYWlKUks1K3k3ai91dUh0?= =?utf-8?B?SWRvYjNhbER0aWk2cGg4YjBlQ2Zrb2F1Z01PYmJsTy8wMXZMNDFGNDdLYjlG?= =?utf-8?B?ZnN3Ym9OY2E0R2wybXVaUE4rRU84U1FHck1xRmlVS3ZtY0hPQU5VeEZlY1Ru?= =?utf-8?B?VE9lTHVJaXJ1UERONUlYa3ZwU2dhZndKa3lMWnJja091L0dIanFHczBXWmE3?= =?utf-8?B?c2YzUnRFK2oranlMdEtIVm1XU3IzUmo5ZS9yMTlteWgxZ0dmZFJ3ZFMzcmgx?= =?utf-8?B?WFQwUERmODBNcU5VRTg4SEpmM2pHdE05NzJEVE0zZWQ5TmFtak5jNW40THh1?= =?utf-8?B?ckt5UkZoMkMvSG9NT2hLLzBUbzdjeXlIU0c3SUY1NWdIa0RGZjQ2c21CTE4w?= =?utf-8?B?SDJCVEN5R2FUNGdoU29rV3lWdlNhSEx5ckhQTFoxdVgzN29KWk1lVDNTL1BK?= =?utf-8?B?TVB3WTIxYVp1bHpQdDVXZm9MREYzT2VudXdodUxwZGdHTTlEZlRoRXQ1aFJB?= =?utf-8?B?RWJsUlJ4VUdJRjZaYmdpTHNFUWJ2S2s3TmIwOXYwQ2E2a0pSSGpDVVBqcEtz?= =?utf-8?B?R1R3QXY2RSs4bjdpYzBvbzlQQk9hSUZTZTJOdENENzUvWnVNekUwZHdaTkRM?= =?utf-8?B?c2gxQkNpaUw2T0hvWnQzVUxHN3lEUDYrNUluZlRQTVltZEtGdGxjMU02U1gv?= =?utf-8?B?Qkg5eVhHQmM0VEdKUi9kOHJBTm55a2J3czJvYXdlckYyUVVIOUp0c1BhMmVa?= =?utf-8?B?Ulo4Ykg0K0NGZ0pWYUZHc1M2ekM4dk14MnFtU3IvK2xHNGVPTHBLKzVCaThJ?= =?utf-8?B?aW5zaWZWcC94ZStsblV1NHRJbmIwdzBZeXpUR1dDVHhLOWhxN2EzckV3cnY1?= =?utf-8?B?b3ppQk9USGEvd2Nmc0huNithbWJINDRjQS9rZW4rTmhRV0I0NXRyMll1eUxr?= =?utf-8?B?bGNLL2MvdHNEN0ExREM2a1ZFSXlpVitJb3JUdk5DeXZEQm9NNzVuN3plS0Nv?= =?utf-8?B?RnVwellCNWV4UnpHUHFYMG5PZk9pSVdCTnMyajBwd1ljMUlsdVlJRXN4VUpp?= =?utf-8?B?dVpxbENZTmxTMy9peVc4TG5Yc25FNVdLOVNzNm8zZXJqRDl2dEhkZ2JzdE13?= =?utf-8?B?Q0tlZUl4NmM4VTdtZEdiQyswWkVmU2w5eXFDL3k4NXp6V3BGTHQzZ1U3N3dv?= =?utf-8?B?aXJDaTZWOE9aNXE2aGdGd3RnVHA0d0YzRDFwWlNnR3NNWEd1WkxaTlNLY0lj?= =?utf-8?Q?J2hzR9I2DOK1Yp3Pn4Zgi/e6l?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06fbd940-2f1d-4ef3-2d4e-08dac7a82eaf X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 07:57:17.9730 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LWQZHxTX0Ob4TOBHNwdevLg3y2aWZUhCLzaKOP7+Eaz+rIwr/+FQAmgAs9v34iezb1tb6QPoAGYAjcJSHEZ2rQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7565 On 15.11.2022 18:04, Roger Pau Monné wrote: > I would like to request a backport for this, but I think it's now too > late for the patch to be accepted to 4.17. Yes, I certainly was intending to queue this up once it went in. I agree it's not critical enough to still slip into 4.17.0, though. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 16 08:05:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 08:05:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444197.699125 (Exim 4.92) (envelope-from ) id 1ovDQX-0006Mg-VY; Wed, 16 Nov 2022 08:05:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444197.699125; Wed, 16 Nov 2022 08:05:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDQX-0006MZ-SC; Wed, 16 Nov 2022 08:05:45 +0000 Received: by outflank-mailman (input) for mailman id 444197; Wed, 16 Nov 2022 08:05:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDQW-0006MT-4A for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 08:05:44 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2060f.outbound.protection.outlook.com [2a01:111:f400:7ea9::60f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 761af832-6585-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 09:05:41 +0100 (CET) Received: from DS7PR03CA0204.namprd03.prod.outlook.com (2603:10b6:5:3b6::29) by MN0PR12MB5763.namprd12.prod.outlook.com (2603:10b6:208:376::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 08:05:38 +0000 Received: from DM6NAM11FT014.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b6:cafe::91) by DS7PR03CA0204.outlook.office365.com (2603:10b6:5:3b6::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18 via Frontend Transport; Wed, 16 Nov 2022 08:05:38 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT014.mail.protection.outlook.com (10.13.173.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 08:05:37 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 16 Nov 2022 02:05:37 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 16 Nov 2022 02:05:36 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 16 Nov 2022 02:05:35 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 761af832-6585-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mJ+onLxfyreeqpzFJO31ZNqGpwj6QHEeUZjneG7qMmFQiEFpIVGfYqq3g3ICsTLnKztVo5AmwWBjx9vj2T+NEtNGqZRqAF56UmPCUnJjXJkXxQusyEmGJLji1MHRVQunWXgpzQ94LscwtR5I9Vs7Sr/J3Uolas6Fvn4B1zTRwse53r0QuvZGFkq39TlwcjMZS+ZVug28iVhqMromAkLHNRrgu9W+Lgor3ez/9kiPmJZgwPcxK4gZAGocT/GxS1DMI1FxPMc2H+Fqjck4NA4zalYOIaM2/aFWRvcnfCj2l3OHMAaBc0tEd+mMiChmmRneuGm//6nE4SQntgkCiWa6yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w+CQIaOUaKAQN/pAJ34lGE1EUSECEdRiBdCEXK6uM6A=; b=gnKOmT/SwqFC6B2xf/2vSF9iRGbHV7lW5Xj9FbJvLNnh3DZAwDOmfy1qvoT6CzHsiqutB5eKKKVTVB20N5+3+G96O6l6klDWGSEnaZX2QTpR2sVilpC97hzC6w4u1l9vvLXwDWL4XWKivnvRVnuPTS9VQxOcXWNFfjMmQpvpcyb9eTTflLh21o6J9mK80sAnEArQD2uF9ZgvODiBWJaJiBZsdHfUhK5+63LHdTZFSvt+5s50gDggOPDpW0u1N/CXQQGC50tTEXXPlNOX2s10XsL2JDUc1hM7MBgXlrjGNZ+mjHYetMLZ/cw6MCxlTAcmcmpJ9JKA7K4otH7iH3NZ+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w+CQIaOUaKAQN/pAJ34lGE1EUSECEdRiBdCEXK6uM6A=; b=KghjNzk8xSqRJS1FKZbzQ+VgL8vqrxrXkSW49qGS9wnPeWMkxqpSr5OPtKKUS4qQEkl/7GxbUbUcZq3yhOunK0K5cgFCYOgmdDoV5MftWhAoH2tjbXKQQRdDOlUpKe4nDg1AXGP2cU3f4RnfErIjTUHv0AxEUwWowvRvES3dU7g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Wed, 16 Nov 2022 09:05:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT014:EE_|MN0PR12MB5763:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ffa877d-8781-4910-2339-08dac7a958ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kfwBe0tU7TY19WdxweSNjVoGAVrKanzBJH5wL/R1v5w28Ax6YArq8cnyGfobRhOipjJbQyndsQn3F58qbbUUIiC+aknGYeD4xl6HgzQ5VNHHUucVbJ+M/o54hT+MjOY1BkVI5aC9uPt5B1GOCn79j2II50BTw16GW/BdleSxYtXztQZxsDkXhVs/G8E5X6vdUN4C5HiI5ODkHYxbi+i8S+ZWKJDvpbq6Ugt0HZa0UC3qdfPfWwrDlq3fw1HBwKginDeCtBL0k/mqx5IIhRFkgD0hL2qYvrMIchVDtXnC64HoNeluusAqFucsm3/i4Dpnpaes3PvXUeasITGeO8HrTh1tcz3k9WfN3v2uyELBYtvCiD2nvNXk2WonPv2ObxcGxScq5YfhMa1h8IpUFER+UGcakr751w7yUvl5j9kVZKNAer2ZtACAYh3L5/YGtTlU1QpQQIt5OQL6IhI74wvL1DKxxm6DrYdORD0r4vsZ/AJT2R2/gLr2OKynEMTf15gu2Mk/ca0ZfDKjhHfjxrD/zUaquhnbOEz0L0JNNmgj1xuvvQnJ7pNA6Qm/VXFiaYyIRVzLOWHu24hgfeQjOGvQ6Z/14oH73fumCQEniaUqWQnaX4WWsiAcP5Dp7Fb0UrorpS9yrp9vtR7LCeqUxDvxDZ4d2kAmVVrga+ld8jRRDB29TKMPs159DpC7l4luf1bUyQcBGsECAgIMw2op87RJzZED0WWNxRBlXQ3hCWcF4Q8GWhpcqFJZYqC/dQSd7eI6k9NUOmLm4jFSzvKKGL32f6S25jJ4/YH+aKVIC4iDvycJ0Jq3hkPoAnrj1U84bORWI3hFM1K6WGXsQ8iUr4lKmg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(346002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(36756003)(478600001)(70586007)(70206006)(4326008)(54906003)(316002)(16576012)(110136005)(36860700001)(8676002)(83380400001)(82740400003)(81166007)(40480700001)(26005)(86362001)(6666004)(53546011)(31696002)(47076005)(356005)(82310400005)(426003)(336012)(40460700003)(186003)(2616005)(8936002)(44832011)(5660300002)(2906002)(31686004)(41300700001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 08:05:37.6707 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7ffa877d-8781-4910-2339-08dac7a958ad X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT014.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5763 Hi Julien, On 16/11/2022 00:10, Julien Grall wrote: > > > Hi Michal, > > On 24/10/2022 11:05, Michal Orzel wrote: >> Make use of the macros defined in asm/pl011-uart.h instead of hardcoding >> the values. Also, take the opportunity to fix the file extension in a >> top-level comment. >> >> No functional change intended. >> >> Signed-off-by: Michal Orzel > > With one comment below: > > Acked-by: Julien Grall > >> --- >> xen/arch/arm/arm64/debug-pl011.inc | 20 +++++++++++--------- >> 1 file changed, 11 insertions(+), 9 deletions(-) >> >> diff --git a/xen/arch/arm/arm64/debug-pl011.inc b/xen/arch/arm/arm64/debug-pl011.inc >> index 1928a2e3ffbb..d82f2f1de197 100644 >> --- a/xen/arch/arm/arm64/debug-pl011.inc >> +++ b/xen/arch/arm/arm64/debug-pl011.inc >> @@ -1,5 +1,5 @@ >> /* >> - * xen/arch/arm/arm64/debug-pl011.S >> + * xen/arch/arm/arm64/debug-pl011.inc >> * >> * PL011 specific debug code >> * >> @@ -16,6 +16,8 @@ >> * GNU General Public License for more details. >> */ >> >> + #include >> + >> /* >> * PL011 UART initialization >> * xb: register which containts the UART base address >> @@ -23,13 +25,13 @@ >> */ >> .macro early_uart_init xb, c >> mov x\c, #(7372800 / CONFIG_EARLY_UART_PL011_BAUD_RATE % 16) >> - strh w\c, [\xb, #0x28] /* -> UARTFBRD (Baud divisor fraction) */ >> + strh w\c, [\xb, #FBRD] /* -> UARTFBRD (Baud divisor fraction) */ >> mov x\c, #(7372800 / CONFIG_EARLY_UART_PL011_BAUD_RATE / 16) >> - strh w\c, [\xb, #0x24] /* -> UARTIBRD (Baud divisor integer) */ >> + strh w\c, [\xb, #IBRD] /* -> UARTIBRD (Baud divisor integer) */ >> mov x\c, #0x60 /* 8n1 */ > > Can we introduce macro/define for 0x60? We could but I think this should not be part of this patch. The reason being, the arm32 code also uses hardcoded 0x60 so it should be changed as well. I can create a prerequisite patch introducing the macro and changing the arm32 code first unless you prefer to have everything in a single patch. As for the macro itself, because 8n1 only requires setting bits for WLEN (1 stop bit and no parity are 0 by default), we can do the following in pl011-uart.h: #define WLEN_8 0x60 and use it in the pl011-debug files (+ there is a question whether we should define WLEN_7-5 for completeness). > >> - str w\c, [\xb, #0x2C] /* -> UARTLCR_H (Line control) */ >> - ldr x\c, =0x00000301 /* RXE | TXE | UARTEN */ >> - str w\c, [\xb, #0x30] /* -> UARTCR (Control Register) */ >> + str w\c, [\xb, #LCR_H] /* -> UARTLCR_H (Line control) */ >> + ldr x\c, =(RXE | TXE | UARTEN) >> + str w\c, [\xb, #CR] /* -> UARTCR (Control Register) */ >> .endm > > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 16 08:10:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 08:10:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444202.699135 (Exim 4.92) (envelope-from ) id 1ovDVU-00084L-Lc; Wed, 16 Nov 2022 08:10:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444202.699135; Wed, 16 Nov 2022 08:10:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDVU-00084E-J3; Wed, 16 Nov 2022 08:10:52 +0000 Received: by outflank-mailman (input) for mailman id 444202; Wed, 16 Nov 2022 08:10:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDVS-000848-Pk for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 08:10:50 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20609.outbound.protection.outlook.com [2a01:111:f400:fe13::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e224e7c-6586-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 09:10:49 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8794.eurprd04.prod.outlook.com (2603:10a6:20b:409::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.15; Wed, 16 Nov 2022 08:10:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 08:10:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e224e7c-6586-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G51QF2FuPCpN34evqYCSNQXCeG9yAu85nKKAgJPkG7AHpYnxCLP1c0ZqGkjbt61Rzz1HGHhXGcppoS0KZvOOIOQo0jEMWshfvjpk6yeDU/uT4aXJn+ch0qxF3SNQJmpJcUdOCNCdAeU2WKZX4Ke96soEHoc6dTr8keI+3lCI81zCjncTsJKgKJgFVr2PWdRxCTmBl7N3qlHae1rnoxRk60vm7SeUsy5PXNj/hefS50gYlMQ9YiuPow6kYjTP2FKdthCaK1XrIbu2UjXRohGKbwlGn8oSlBFodDALr7uifSSGCCLIaw5r/jt+EZNGcnbPGleUXoZhQ2lRhAKBR15vgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cKzEfSxDSkCZhPYsUR73ssviqzn23fsjghILg9A887o=; b=WjNu6RFY9G6VMt854ElzxdslM3CZKyKP0qBaSZVbBwp/Iq6SFkXHS9yDYi8ZvEABymY7DreHq8T7xrhj5r8dRS2W5g94yeU+mXX2/DZw/3JyrYCZUzhSg8wexBbbH1TkYzZmKdHG05X/G0RIJPjas6j/Uxvp57ODRXLNfXfrVHjI7v2W4fpoSmSy/fw8zk7wyzJJl2984YtC7lASDjW0BajpIjcHBuClccD5WoJ5kcWOYZsq+ceNmCohwmXE19IE03yjA2OMcdY32GqIyqZW7ygRVOrk/4PcjCpgObYzxWQJtUqsYbWG8mAvTtFW8dOUH/xyRZVEPjwKQ9B6hXJaBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cKzEfSxDSkCZhPYsUR73ssviqzn23fsjghILg9A887o=; b=2sIFeAbjddSxdn+gmLx+DPLjw5bQTDgkbZqOmUkXx3KvT1HytAlcGb95VTfMDTkY3RiGQJVFUZ6ljvx635GIbjyzNld3SFkgehMCabQB32dlplr3uGK0TYjBSTw1n4LMD+pbIM/EOJ4R5r8blQPw7cYx83LWC77SbfH+oPrbHY7NKIbn2ovE0/3hUJ9On9T7UBL2f0LRHJo0gJsf6/akCSwlV5zELAAxYsrZq/R+6wzz8IdcafeX+c/3uCbgd2QRD5jSupG0aPqvcLyqDENPJyYUe8cDhy/YI8UOw/yWDWygRdpfOUL/04AT87vcBTCDvG9D36S2iulit4gPGlRDWA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <42e76560-24ab-7830-5a24-a3366dfbba36@suse.com> Date: Wed, 16 Nov 2022 09:10:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 3/3] CHANGELOG: Start new "unstable" section Content-Language: en-US To: Henry Wang Cc: Community Manager , xen-devel@lists.xenproject.org References: <20221116042634.50948-1-Henry.Wang@arm.com> <20221116042634.50948-4-Henry.Wang@arm.com> From: Jan Beulich In-Reply-To: <20221116042634.50948-4-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0046.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8794:EE_ X-MS-Office365-Filtering-Correlation-Id: 559d729c-dc15-41b8-aef3-08dac7aa115b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PFGXbRcvqjKXdA0whtqaAgHVC50XssPFQgfyunZi3zWIxYLz1NEthrQy2e/3xflZiGx1bgZQfbncegCjC5ZWPIRKaYM5XW6oadI9kkPDFIfgtf/1rOMoU0i9p4Mithn6cOlHQH5QeH8TvhDZdFZ/ri6aWSJhb4pqEbq0CHgPDrShOc/m6j5g3wLJvlHGyZ2SDqBO7OKFOxwPTO/SrrSPnt4zRVqIOtRrN4f+VNw5aNJml3Q6yeGQQg8xzxsjSUM7jSn5Htaki7OpZw3tBUqRr+Ji+t9N3OIAcjdUWSe5MNQ3jUrhOgGEUtZD22BUfXgLUUIRnj3+gCrTmUgUeqMoX75o+TXEx5X8ir4f6L7+hyhGh4NeAEAZeteFaiK4T41cmgOSyp0LG6y0ziGEolv4uN9aKW3NpcB1tyJFiB7JPDBN6/vVl14op+nBDowpMRtWgzaKSr6OyM7sLqSIgd/hftudTqs3Bhd+/CjSd/d7x67q7Kf8r19RbVQPd9lCuPOwehbi1UN155DBwO1tPd4kGBkHE8jSOAGNCLuyEWtPeGv0+zxMF/x0viWAsTJ2eC/XAwTkRnHxkEPiCFDUKlUMFU15u0bd59+Zba4rcXFWSv7T6n1RdYiHy4ikazvVox5YPtp/1sdns9REzbH3gww9Y5dxHW6bCFQwcxPPXRkty5QWWRq9uHrjIW6ZwZcE/nD0lsbZor8FLOf3Xv17SvheHAjnUvPk7VcdCSAUawkKbGH3dxk6m5hzAnkhBp61Kf8fXLjBgxPN1TiEfQp6X29dlIAM9nn8WXo97OeCVWROzKaYWALbtQehivAWymtKZU6/thqE+NCqCpNW1rt6B3MjdQcXzhlDekpgjg5wTghU0mv+HtN93rnLnoDmib7kkU2Le9sUuKQg8+BhhWYda0vfiA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(396003)(136003)(376002)(451199015)(38100700002)(31686004)(36756003)(86362001)(31696002)(8936002)(5660300002)(4744005)(2906002)(186003)(2616005)(316002)(6916009)(41300700001)(4326008)(8676002)(26005)(478600001)(66556008)(66946007)(6506007)(6512007)(66476007)(53546011)(6486002)(59356011)(207903002)(219803003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWtvSktZcDJDK3pEajlRSmI4Tk1lMG10UG5xMU5mOWxIWm5XcWsyOVRpUlNV?= =?utf-8?B?Y3hVbkpSZjV2aDNEYWtLZmNrWEpmeXpwQnZJMzRMelNVZlhObVhaZ2xQcTV6?= =?utf-8?B?N0g4OGRBRTdFTmJLNjgyU1FDai9ES2h1aGxnSjE5U3hUanJhOFdqZy9hUThl?= =?utf-8?B?TVY1L1VwenFIWlVMclF6a3lmYXBsbUpveEhITTNidG1GbXo2SHUwbi9CT3F0?= =?utf-8?B?eW5TVTQ0anhsVTVkUEZYMTFxcW9TdUpUOU0wZFQwVDkzaFZhWDl5RjZNS0V0?= =?utf-8?B?VktQUzdYcGtNLzBiQ3MzSnhRR29hazFPdUxWS2RxVXg3NXVoaGpnRjljSjNi?= =?utf-8?B?VENxYTdvZnJXRE1SeVpTT1poU1dSTXdCdmtQQVpoS2dPb2FrbWFCOXJ2Q0lF?= =?utf-8?B?cHV4VHVrSFE2eE82Ym81QW55MnhYWSt2dGJCY3h3cGdkeVEvSWNGcWNVSmpC?= =?utf-8?B?MXBza3JMdWtrSTJJMnlUeHMyZ0Y1VWJQRTQ2STU0NUUxcXVsR2ZyRW5TcHJK?= =?utf-8?B?Z3luZ1R1RTBSYmN6bDBsUnJmMkZiYWZkRFZWNFVVOEVJaHNtdHpUb3RQZWZp?= =?utf-8?B?b1Ftbkl1a0VVRHRiZWdVVjJ1dXlhQmpMZ2lnRkk4MjhjelpMVEhDR2lkeTY2?= =?utf-8?B?QXRDdTUrYTJRWGZMdkxBdXpRRHNpaVNjVlRwbDMwRHc0OW9DNkt2UnRzcWxL?= =?utf-8?B?ZVVUUjArK3IrNm1HUDJQaHBmcHh1N01QdEVMZDRYdVd5aGJ3aHdBSnNDL1E1?= =?utf-8?B?amhEL0JvZ3pCclpmSXBqYXBsVmJDcTZsdDYzcnlnWnFTb2NBRldTazRQN3N6?= =?utf-8?B?WWtzejZZTnEzM2kwSUl6VmtFZTNjUHJuOVhxamdXWGxyU2NubktFVzFWRlFi?= =?utf-8?B?enljaVpSbEFNOHdZTmFoTkVqMWVRdGVMUDBPWDRLUW9RSWdRMUtMdVJVNlB0?= =?utf-8?B?TUxZN0lDZGFuRHpHcnVnZE8rV0kxOTRTTUZqQzhId3BUSVhGZm9SSVFpNUZK?= =?utf-8?B?VlFzazFRRmxPb1lIeklxcHVUY212MWpDbUEyQi84dTlXcjNhMHovYkp3TXVa?= =?utf-8?B?Rmxjd2oyZEorMStXTmpXK3ZVMFN3cUhEV3lPUlo0eTU0UzZFa0xkOTN3QXNk?= =?utf-8?B?YTBHSWZIb0tzMEF6SnhrbEpCTTlNdU1HSWxrTGZJMDdOcWJVclVKMU15Y3ph?= =?utf-8?B?OURkRzl0Q29tWUpEMkVjTm55VitlOHQwUEd5bkJXVzVqZHNPYW83a3FDbTdB?= =?utf-8?B?N3NpWmFtcURZd0FNZEpmQlFiQk5ib2hqVWtGTUhSZVhhYXQrdUhOT0RGQXVs?= =?utf-8?B?aUZPVzZyTzBuaTR5Z1FGWGJzWER1SklBNVZkaTJDQ3B4Zks2cVBMQnpuV1hM?= =?utf-8?B?YXlPekMrRTZxOE54elpWYisyVFNJWG93ZkNvaWJLOWg1cEJwck44SXF5S2cv?= =?utf-8?B?cHc2UUNwVzhiMGlCTHl1QVBJc2E5RzlkTzRjREJCd2FmUXJTQWt2d1h2RDJo?= =?utf-8?B?Z3lWeG8ycC9sTUtPMTlldUFBYnBBZVc2dWg5d0gzaTYzblRvN3RPTUIwdXQv?= =?utf-8?B?MzBqbG50Mml6ZTBHWExuQWR1cGlBTS9Fc0FpcHBtQ2M0NlpTbE1tcUkwL2RW?= =?utf-8?B?akhNN3QwV2hHNEtmOTZoSkN3RHhXRExVNG85UHlWazBGSjg5MEFESGFKUTdo?= =?utf-8?B?V0FJNnZMRVdZSHlnbCtGVFRPeVBDc0R2d2MrQXp2MzZuWDR5dzNUQmhnb2Vh?= =?utf-8?B?c1JGQU1nbllsRGlBdjR0ZitpdC9Td2hoTGFOUWg3YmpyOTNXNFdkRURWUTFr?= =?utf-8?B?U2xrbWNmZkx1QnJOTmVKQXlGaittTU9zOVdhWEtxY3NHWW9wTkNLK3A2QnRq?= =?utf-8?B?bUhLMTgrb3ozSTlZRXVRS3loRnNqT3VvOXdIcU52dWp1WE5pTmZzaTk5M1ZY?= =?utf-8?B?MnBGRlkwRVYxTjFpLzlSNXpwcytadlp1MUcrN2FYYzI2U0FBRTAzazNSeGY4?= =?utf-8?B?Z0pJMWJGQnQ2M2JUbURRTGFLck80K1JUcWN2YnhaeGNSSG5VV1lVcm5aNG1m?= =?utf-8?B?N2xtcEU4dGRtM2VocUJ4THI0akV4bkVEYmIyWS80U2JnZjRoU2VJbEhKSWp4?= =?utf-8?Q?k4R07S4uYs/x0zvgL5smB6qcs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 559d729c-dc15-41b8-aef3-08dac7aa115b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 08:10:47.8279 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aG5/fSCsG3RLjL4F221r/yyqwNObnYDg90PO3EKBF6avRM5YRbCH+CFz2bYRUDdJazqmrbHtZ7gXYAlX+aSnqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8794 On 16.11.2022 05:26, Henry Wang wrote: > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -4,6 +4,8 @@ Notable changes to Xen will be documented in this file. > > The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > > +## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD > + > ## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2022-11-?? Since the adjustment to the 4.17 entry is (I expect) going to appear only after branching, and hence perhaps only on the branch, wouldn't this addition of a new "unstable" entry be the right time to also adjust the 4.17 entry? Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 16 08:12:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 08:12:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444205.699147 (Exim 4.92) (envelope-from ) id 1ovDWy-0000An-36; Wed, 16 Nov 2022 08:12:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444205.699147; Wed, 16 Nov 2022 08:12:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDWx-0000Ag-Uk; Wed, 16 Nov 2022 08:12:23 +0000 Received: by outflank-mailman (input) for mailman id 444205; Wed, 16 Nov 2022 08:12:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDWx-0000Aa-3U for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 08:12:23 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7d00::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 652fef1b-6586-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 09:12:22 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8794.eurprd04.prod.outlook.com (2603:10a6:20b:409::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.15; Wed, 16 Nov 2022 08:12:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 08:12:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 652fef1b-6586-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EzzUJ2i4ZBqWyGPXqLlPYf6mT7NtB76k25dqIhQMHe2uQGtb/YNedHjA+JxAfsWj9Y0GCJpRDeJxN9W/Ywz/CtO5cONRwIOF5TJCdboAyStmSKP/gjMlmDDvcdM62qv/m2E0DnffQuzR7n0LkXhjK3Z/mMBYGigF7B3hV7wgh+06GplzaKFzSxYy2uMDnNCFflOkABrqOT6zbAm8Hcp/rUmPbHhoT6c3fB94HDOXQFmIfQBSReEpIPzi5CZOady3FK/7QuIzqaqEDCEPHrcWaDmrjwt9ccFag5nd/vcjNOkLyywB+/ZaIxDGyNzHWu81qONg52ENgRY3CZKqtN+hAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h8QCqOixMy/CPArvEcKWaNmev7Du6l3kdyG5pKJstIs=; b=WNsEo/DjzoVYbc3ilDFAbYilgNVS1LcPS8P1J/8gKzC9D2tYEPP5sBT4k4Ladlj+WPrtRqsxjW1zt3woRulNJodRZPb9YeW3Yuqjl68sK7NSSOOnwA3IevQS+zpxhpLvzwW9JA2gsstqdKIZBByyd6F/Tu4dc9Ji9OzGBj4XeCD4jQRyAeW+9MSwNyvOd96uN5/nYKnMDOmIBa9YdkbZIWWOe/ilp1sEnhnvNlF4dIihOGkHejXNUVrKlXZAMdZLXqc1XJXOfL32rJW7PINW3Dqt7hctwhz4W1XNLryI78ifB21rSN/JIFSKJ1bn9yvstFPxBlVb6YymcMMFgY+g1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h8QCqOixMy/CPArvEcKWaNmev7Du6l3kdyG5pKJstIs=; b=2Ycq4mMxjEB62UwO2B9nwng4E34nVKy0PzC2jWncv1dEoZVknDB6k52+kAQmXuSl5XF1zc6dICPkhJc6YJValzUeY1mh/jvnBKgQ0fuP3IGqOYiX+jvR5e2YoYw401HLOx3EZM4LBCVlU1ZjgVxze3R27MwBE5zZd9CS8BXhMeEmQpou0tYCQ1UXXFMvKum0Mq68wqLBpV5HCy6b65pgnBAYMNvKgQofBk2PYia23jlf3Ffq//8pC1Guh5CJvZT80VibA75Fbg2KAcuWVNtkaWhR3ZRWjr4mSZtV7wEnhB2LZ7GXjAlS2PIuct5NioL6JAnv+c15cOdbG2CNLi+AYg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 16 Nov 2022 09:12:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN PATCH for-4.17 v2 1/6] xen: Add licence information to public/errno.h Content-Language: en-US To: Anthony PERARD Cc: Wei Liu , Stefano Stabellini , George Dunlap , Julien Grall , Henry Wang , Andrew Cooper , xen-devel@lists.xenproject.org References: <20221103115204.49610-1-anthony.perard@citrix.com> <20221103115204.49610-2-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: <20221103115204.49610-2-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0506.eurprd06.prod.outlook.com (2603:10a6:20b:49b::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8794:EE_ X-MS-Office365-Filtering-Correlation-Id: 86232029-c8c9-485f-df40-08dac7aa484f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q7bSCzF5Gwctz3CdzbpLJ5EHdbqiwwBA5JeLorlh5iLD+V4AaSbxDX7zdKCJ2buerqhlKnLD0wY6NRPzRV0SiMmDRYzbOul5QxbmRNaDSqXXoxH1kL485orXFo8DLEigDpkoh24bGfQeBaAeW6JhohcMoNOOrG877gSHLxm3YbcxyxThghIzuMjMTebg4xpZQjOguwd+eZLlERgt5LmoyNXrEwphCWaN4mVcxpzEV5tK3kJG/BroZcp9ecOnesctacGYd75laVIHBRzuSSjJgmfa2m2aqTGHn3A5e5KJ0+6LBwe7p3qt952eCCngoG/3Lg1UDzI+jC9mZO/0vph5EopqVsTzdZiuR/84RtD/LaNphZabYdBRhfcz4v2HfdZsXPh8YJHw+KTXimM/6jRxzT+6r6E2+9FP7NqwZMb72DI8DVij+DXt8pDqfHYBQLCBPDlH44Yw6k/7fJXbki13hvK+MWqwA3JXZfPjS9EcjLJl8bKvvgg/A5i+5nS9ioJYF1cpjtSiEXMdtcD6uOylLBhHGgHgZqTWrDd13d4e51sAVlcAVb8LalzDoATy07PuGy2GQaZNrTYZKC4pLcetTGeWS7wHz6XxPd+QgXMVvm7/1fbj4Mp9bjSHcT2rKQAAQBZbABhH+JDAnl9BUECCAkFKjpIokJ5zl2cDqPsglpIe0KpsTpZNOF6QCZCSZhCDZmn/nptU92suYzof5Z1BL4cRRiQbBtUT+Z7U1vNwWOw82doI6Sn/ywf9TcGgp8hULGzdf1ZMtpTXoXPvfIS9X95hOhC6FSDQb9PTjDtDQwk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(396003)(136003)(376002)(451199015)(38100700002)(31686004)(36756003)(558084003)(86362001)(31696002)(8936002)(5660300002)(2906002)(186003)(2616005)(54906003)(316002)(6916009)(41300700001)(4326008)(8676002)(26005)(478600001)(66556008)(66946007)(6506007)(6512007)(66476007)(53546011)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QStDR1hPcWVOeFJOKzVjMnkrNE51Z2ZoZjNrdXlyd2dFd0YwMnM3ZDZmMDl2?= =?utf-8?B?bkRCdGpZaFkwUWhwWXg3K3FrTU9LbDFKZnZPN0ZRa0ZMazVqaTlKemlWanlB?= =?utf-8?B?RnZXTHpQUzFxNDlhYW1WZm5iVUtpMmtBZmNwS2hkaU9VV2dURW44eTVWWExZ?= =?utf-8?B?RkRiZ0VhNUw3cjA4Mk9CU2F5VTBTQjdtZk5EYmprWU44MFZDQjRHZ3RPMjFy?= =?utf-8?B?M2FLeEV2TkdPNE53dXJQUWxrOXZkN080NDRxZmxZZy9KL0t3VVhJVWFseVkz?= =?utf-8?B?c3ZIT0FaTkNxT0RiZE1TeU9CdWV2aWdRMGxxNHArR1lhRlU5UytmQnlKdDR1?= =?utf-8?B?Y1hTNk5CSGNvLzN4WTZRanNvZElVRnVuUzVOLzhyUjRaNEl1UmRESG9nMURW?= =?utf-8?B?dThhRlhNaTdXbnM3RWg2bzZVbVptMkF2Qms0ZlU3SWNzdmw4eFYvZytEa2lH?= =?utf-8?B?ckhHSVlyTDErbkpQb3dBeXJVR0liT0Q1SG0rcnVFRHBsRXRaSk52VlB3QjIv?= =?utf-8?B?T1dkUEg1S1NTRE9YaGJnY09sNVNoQ05LMHpJNjRtbHRMSk1JbHZUOWxXMStr?= =?utf-8?B?Sk8vVDRLV1pLZVRFZk91NnV1K2s4NDJEOWhJZTJ2andHWDNJT2JlSUZQOFZE?= =?utf-8?B?ZmlsTjB6OTJuQWlaeVdkMXdmN2ZxbWQyQzNBeWhPWTNhS0R4OXVQMTAzZ09l?= =?utf-8?B?RitmZ1Y4N21IUFo4WnYzM3M0aUUxSkZrWlM3RzBHb0YvUitXRStabVJMUGpo?= =?utf-8?B?eUljSjZUWTVONnU0TUU2UERDZ0FFTWNCU1ZXck5XdkVNVk5rR1JyZU1uUUUz?= =?utf-8?B?VTZwSVhRaWxKbzh2d2w4TDlacG5JN3FJZk1veFdreldiMGFUK1pwYVdrMXZw?= =?utf-8?B?T0tZNSt1WXlvVTRvdm5INGNmdVpLaFNJVjN4VG4wQnRWMm5KUUtleTMvUmJE?= =?utf-8?B?WXRQbVgybndjVWl5QS9lbG1rYmgyN2NFVjA1ZStNS0Qyb2MxTm92MWs5bnpL?= =?utf-8?B?aEJYWUd1YjJvNllNRUJNcE85N2FvRUw0VHNzK2phU0xRT2FWaU5TQUNMdHli?= =?utf-8?B?YTIxWTZYYmZLaUc1VHZrSnFBQWRPeUQwSVFsc1R5a001Z2EzWW1wU2F2UnB1?= =?utf-8?B?eG1oay9BOW95Q1FoUDRtd3krUTZ1ZGJaOExyVUt4ZFc1cVlDZERoQzQ1VTRS?= =?utf-8?B?RmZTK3UxZGIvbXJOQWdDTUZGSFNVWE5JYWNMWG1wRXp4L2lRQmt1c2dBN3Uv?= =?utf-8?B?ZEF4blYrcllwMFU2eWtrUm1XRlVacS92dlhWeUFjSGlNSVR1Y1dJdHNiSWpa?= =?utf-8?B?UUdxanorM2pyKzZkWnpWcFh1aGhxWEVCS2cwcXJDaC9Ib0RGWHJpZlFCN2xU?= =?utf-8?B?ZHBuWEcweEFVcGJEQ0dQbUdCME8wRXpFYlU4bmE3d0FlNlRyU3gzVHpLcmYz?= =?utf-8?B?TXRRbWxOc2ZJZ282ek55UVBFNmE3WTgyRm54SzZjWGJTd2o3YlJTcjN2eldS?= =?utf-8?B?WHlrWUI1YWxVTnhqek93R3htZnFIUVNWNytsYlY0M2NlMWo1akMwbG9EWVBH?= =?utf-8?B?UVdLWTB0cUlZbWtENzhZc0dwY2Q5MXlTMzJ0YmZRTmpPQjRHNVZCU1ZTakts?= =?utf-8?B?emlPTkZRemIzRjM1VnhDL2lkcWhYaUVoYnpBUHdqL2VqZ1JpdUhrT2JRNFpl?= =?utf-8?B?bU1LdWd6MmQwc2Z0ejdrbmlseTVUV24ranlOWHlwVWQ5bStjUy9SS3A2T1da?= =?utf-8?B?SVNxS01ySXRJSElxbGpQTmpBMjlFeEk0b1d6VFZUQlpUWkE4ZWFXMGJZT3BM?= =?utf-8?B?dEtqNkFXWEtvdWNZL1REb2puVkFVaUdtSXJyVXFpVHFLcXMrR1k3RS80eXEw?= =?utf-8?B?ZzlQRWRoKzBvQ3JscUVuOXRJRDhZQjlkMXYyZjU5b29Vem05NmhGeEUxK25U?= =?utf-8?B?RWtMQUNXRTNnblZ2MnZwOFE3VDg0c1dINDdLUUhoSkJ1d1UrVk5PSmpYcGxY?= =?utf-8?B?MXFMbFFCbHBDWjZ4MnVZWEgvV2c2MkxHN0NtdnZLMTU3bzFwdnAwRGUvMnJK?= =?utf-8?B?TXBSb3BFWHBYQi9XTVNiWW9SVENadGhwRy9XMlluSW1xOHpPOWF5cFI4ekd6?= =?utf-8?Q?b9rQjM51KfTG7svomIJLb8YaG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86232029-c8c9-485f-df40-08dac7aa484f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 08:12:20.0564 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vcBUVQ/LSUUKt3YcvvlxRONxbD6TtkCi3fnGyXKJ+C+Zxg8M1obhzdh2fbdHLwvl7cuX0ehFPpBaFg94IC1t5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8794 On 03.11.2022 12:51, Anthony PERARD wrote: > Fixes: 81f559e97974 ("make error codes a formal part of the ABI") > Reported-by: Andrew Cooper > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Nov 16 08:12:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 08:12:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444207.699158 (Exim 4.92) (envelope-from ) id 1ovDXJ-0000c0-9p; Wed, 16 Nov 2022 08:12:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444207.699158; Wed, 16 Nov 2022 08:12:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDXJ-0000bt-75; Wed, 16 Nov 2022 08:12:45 +0000 Received: by outflank-mailman (input) for mailman id 444207; Wed, 16 Nov 2022 08:12:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDXI-0000aM-At for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 08:12:44 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on061f.outbound.protection.outlook.com [2a01:111:f400:fe06::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 71db5e5f-6586-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 09:12:43 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8794.eurprd04.prod.outlook.com (2603:10a6:20b:409::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.15; Wed, 16 Nov 2022 08:12:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 08:12:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71db5e5f-6586-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UnZjYBM8ffucMUfJKo1Y/vbGa0DQx13EkiaYKZ3WW8pueecVuIitkHVoNFA96oX+Uox7nLju/y3PFcY3h7Kac8TT7EE/s+6lzqd7/SzLsMfsJ3aot1WBCYBEILT8enQ9fPC/bxMzJIKUkh1R93SOxtErq2X/vXnWmQG+slYpxMffWqFWKk0+7ywlobwrXZphzVRkZ/BieLOGnfWF/z9Raepfu0Gmupwqpx9MbdMG+QVWRdBl1PqG2ZBOeiBmh2d2+M+ejTYM81SJEx77JnSwDylTbPwctg0U4eK5rWRpIZgMhW7L5TRbB0Vg5JfnBE3pDS7cks/FK4mwR7pelE11JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jqgolSxYtVGhdN06ntmkpJuIbIH+m4ZtlHmJSCb0w4A=; b=MJxnmKFgy+BildsrjbFOPixhSV7LP3hm43tpFm1TAV2MUPs/vTEA/P3zlUiwQuT+spT6lkumpfGX8nDY5oe5FpnpFS9+DJ2i4DoswyLnTVD2T9W9o7GHy4E/uZKkT+QhwXPQ1WAgivAOkd9fhonE5Z8qzmtXzmKkGxlMfVmVIxTAzE81NL9e/d+xySOfMQselGoHuQhUBEhGivFfqSdql96DvOn6V1PFTcdoCnrmudff25uy8QY/SwWpgaCtXS/IgaV0BMRQ3XddN1vL40w3LaHFRLyjqRcL8NVVyGE3jXc8dbOLRszs1vXo/C8sVpUpTsDOEXeaYwxGy8Rhcr/e4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jqgolSxYtVGhdN06ntmkpJuIbIH+m4ZtlHmJSCb0w4A=; b=ObB9qsWVINMgQ6r1ivqumkcscIzyFM/YJcDFfDcWWJNvOQ1GLtatj4LHIM1GNFs8NCFCJ6v+73NDp2o9uJrBx37kCLlf7DHMN+BuyI8mudRv3wJDbaByJ+wgOQOGbWIiAdxCx0qWaValEQ6eGo1djr3L1fkgjraRAhC6h1z9ydni8TXdBn3Z354rdw84K85RbNLJVKNGnk7N04kpmUn7QkulgZ7JTygJ+45G0RzZD1V5stzbCkzRhb5lGiiv9u2OLTcO56U42T9UBo4hKj9XFXqOQEqM8ZoN0adRkgCvv7JRmBEvZZ/R72CW1LxQXYkhyujhsTFXuUbyNrUEAVWI7w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 16 Nov 2022 09:12:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN PATCH for-4.17 v2 2/6] xen: Used SPDX identifier in some public headers Content-Language: en-US To: Anthony PERARD Cc: Wei Liu , Stefano Stabellini , George Dunlap , Julien Grall , Henry Wang , Andrew Cooper , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20221103115204.49610-1-anthony.perard@citrix.com> <20221103115204.49610-3-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: <20221103115204.49610-3-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0499.eurprd06.prod.outlook.com (2603:10a6:20b:49b::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8794:EE_ X-MS-Office365-Filtering-Correlation-Id: f605043c-5642-40c3-4bde-08dac7aa553f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b1erEgLcZtDUazontavK14rtfUc/w5cDwN2/gaPeoPNswDtAYPuMcQhyssr3DZNfnu5oBf5UbufFLRgIR6w5woETtX/kWmQhwUyc5+wh+ZkNTMaRzYXPhdRq3ficrkxN+ZotWoFUt0FhN8QJGq0yfpT1YLNZTpvI+gSntOPkehy4nfCV9C2GU1aFpeXefSybGr9RQcpiDH2SZ1WDgFZ9HqemVuwM7vJFbdzhruBXUEeOxh/htYAU1eJg4BLFkFC6d1vJx3x8sO8lJ88etkGie3WpoURcVYdur6OI62I44mUyC14mSBFZSjHLdazbO8H37Cwh1w4mct0ZoCaEhkZAV9YZkIm5ef7Nnr5+2ya/iu5LCh+ZcYx1BdkQfdZCAHEA9oFtw+Ohf7mBIc+Lcg6PsIeLu0QSdLhCirzoErmeSXguZMBBX+L3o2NvKo1t8ZDIzvmOiZkGlLOG5yOIAgBnsO2/tnmntdcmAZ++i08Wvoxs7cUjucEAhD3Q2GWKENLZl4IfPVjnVTTc77RPG15JOh3N+KRNWA5rvsGjA867yn9doJLuG+GQZ+gSMco5JFu0UxjzwsGrwG8MVOxc+eOvdHCaBUOkq0JIbhU616jCZyc/qqV/CUIXbYzCkJ6jaiL6PfFxHPcEW9l3mhrM4n32sESBY2bO/+bn/5nvCUIwQohb+KOHGpOcvzfWfAjRtGSnGeX+1UZH6Wma4vQzXKa36QLwhRc+X5r1y545lPUz/ylqYI1ad4qnqgu2RghvTp8FeXs/j0GINYFt+H2KBV35wxTeS/oz4d1jNAq4kcY5SC1ivVJYCpg4IA0OPRjOlQwS X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(396003)(136003)(376002)(451199015)(38100700002)(31686004)(36756003)(86362001)(31696002)(8936002)(7416002)(5660300002)(4744005)(2906002)(186003)(2616005)(54906003)(316002)(6916009)(41300700001)(4326008)(8676002)(26005)(478600001)(66556008)(66946007)(6506007)(6512007)(66476007)(53546011)(966005)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTI5R0g5WXE3bFZMMWF6YzI4eUtoSGFhOE4vSE45QmE3cXNPMXB4bk9INVlV?= =?utf-8?B?a29iZDg2SmhQY2xPcVJtWmMzSFlOMEdWL250UUZtN0laLzNkTkRvUTVPNWg1?= =?utf-8?B?VXZkMWh0amJEY2E5d0JCNEFHZ0YyWVY1RzUwSEhET2pjcm1BbGZjKzBFTUg0?= =?utf-8?B?Z3pMbWZ0ZU91R00yaFYyWS9SWnJSOVRGM3FiY2hRRmFiWHpZR1JBM1dhR0dB?= =?utf-8?B?Nno5WlVrVktFL2dVSEZDak82eVVINng2dGFoTkI5NVdzb21CeDB4azlIYTZj?= =?utf-8?B?VFdIKzA3WC9YZVFhajVFbXFYMzhpOEpoRFRuKzV6OWVMYzhUTmw5aWJBRUxB?= =?utf-8?B?em9XS0wyT2pYV0tmUkcvbmlNL2Q3TzhWRE9kbFoxcVRxWU9yQklITWlVREpF?= =?utf-8?B?dGN3MGU1UHhvQTlSSGpHQTJad1o3UFBPM0FqWUpNSVBSbk1mdHZKSFRyTko3?= =?utf-8?B?YldWMFA1bDFxTXN2bklOQVJHZTdvY0xoTEtSbCswZEI1U0ptQ3ZnNHI1Z1My?= =?utf-8?B?YllzbDhZR2lheVhQUXBYZ1JVNCtlMHNTVFdNYjg0SG1LK0Y1cmdxa3UvWlpr?= =?utf-8?B?TndYejBmYnJiRXdOMi90K3JCbmUrVno0VVV1WG1ScFI4UHZidDVZV25iVmRU?= =?utf-8?B?cWNSNlQ2NXQ1M25md1hkNlBWUmdQWUZoZE16R3kzOTBhYUlDQ2N2Z2hoZzVn?= =?utf-8?B?MFhNcDM0enZGV2NYRnBvMXlHTUcvZzFHUDFud2l0R3YwckFKOWxFWnJwa1lQ?= =?utf-8?B?bXozNmg4dnkxQW5pR3ZxcDBqWUJwRWZleUxhUVQ3R1crRnM5U3RQS3J6MkRv?= =?utf-8?B?L2U3QmpkendSQXJIYXRwaWIvQlkySE44VXJhS2t0T0VEMGI3QnQvakN4V3dP?= =?utf-8?B?OXd2dWVCS1V0UStkRDl5cHZzeW5GN0xWNG4wazVqa3Y0eWpOT3Juc3o4S0J6?= =?utf-8?B?d054cEhWUnk0b0pVL3lhblY1ajRaYVVXcmhOdFNpS29DVEZ4SGcxZzU0dzFM?= =?utf-8?B?dkp2c1BLYkcxbjNVdVN4dnM3UHY1bC95Q2JzbHFXdXpCVUROcHpDeTk5VHFC?= =?utf-8?B?Q3FVSk5zYm9OSjkxalRqM2tqd01sRitwUXNRaWJGTWxBVGliZk5hcVR1Ukc1?= =?utf-8?B?Qm15eUwydEJFUVJ3b1JKOVUydVUrUDVQYmQyOVJaTTFXbEVFKzh1UXhFNU01?= =?utf-8?B?QVcrTWViMktSSXJPci9aVEhXQXNxN2lFbW9mSzF1bzMvNUJnNmNQMHNGMzB2?= =?utf-8?B?ekNJR1RKbDN2ZFZ4ajZDbm00L0Y1ZHZMVSt1RG93YXhCM2hUZEFHKzNBSmpP?= =?utf-8?B?d2dHWDUyQmlzbENiSWUzS3A0eGlXZDhEa2RLelM0RVNMU1FlWkREMTVScGMv?= =?utf-8?B?RFBpSnVKYlQ2d1d1RHdTd0FPRDRKeWRLYzdheGxMNS9ONkFwbTJ4U3F3L0Jt?= =?utf-8?B?LzZ1RHpLSFJSdWVrL3dFdEp4RkNyT2JDUENsQVJPcmVoVDZmY05JdFJOOXBn?= =?utf-8?B?cllOTDBhMWkxV0FRV0V5MHRCc0FnOHVDelhTT21ST0UwNnJGOTdFck1aVGdD?= =?utf-8?B?UVFtTHdkY0NUK0FOVlI0MkJsSytGNG93cVd3dElRUkV4SGpJWHdHdlR3WURY?= =?utf-8?B?Uy9LZ09QN1ZKUmQ5TTRJamdrc2paeENTcWVEalFjL0lWc2tmV1lWdjBLTTlk?= =?utf-8?B?K0JnelVvQlh1bWlTSnl4bTUxcUJ0YW5ROStvT1A0VDVJWE5pOE1peEkrNitU?= =?utf-8?B?dkhYUWQxdExhYWV4VGxmSzY3VSswUUhSK2dUeHo2NHoxd3dnMjFvL0traFNP?= =?utf-8?B?RlJKY2lZellKekptNHJqZG4zZ3A1ZFk3TDI0Y0dERlVlS0d0ZnVLSFpyVlFJ?= =?utf-8?B?YnBxNW5BVTdkS1g3T1VCRkEwb0JCWFQ0QWJTSll4cXVEVzlzbi9UNEVzWXY2?= =?utf-8?B?ajNOUDVkN3l0OUV3SUJlbkI2WWFsbFdOVWFoWHlreCswUzI3dXpMZDQrcW9a?= =?utf-8?B?eGk0Rys4WHJ6WUxBTkp1b2ZKUlRJV1BOTUdNblJiTEd2NHV3S0ROQ2xlTkFZ?= =?utf-8?B?Q0dscVBicVBpRmVoWDFEbmhWWDRkdEgzTDluMGJZcVlmQTFjK24yWWNvWklz?= =?utf-8?Q?BZDTeewTuLBHCiKMGMhUk0+L4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f605043c-5642-40c3-4bde-08dac7aa553f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 08:12:41.8363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vsJ5vzkxPUyte9h0giwmgCMnIlCVkQWFgltDOQEPJ+KvuMINDef1awmxcLt17TmsEyIJDg+8yUW+rigG+w21ZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8794 On 03.11.2022 12:52, Anthony PERARD wrote: > The script "tools/include/xen-foreign/mkheader.py" is going to do a > sanity check on the licences of those headers. To ease this, we will > replace the verbatim copy of the MIT licence by its SPDX identifier > equivalent. > > The text of the licence has been check to be the same as the one at > https://spdx.org/licenses/MIT.html, except we don't have "(including > the next paragraph)". The text is also the same as the one in > "xen/include/public/COPYING". > > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Nov 16 08:13:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 08:13:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444212.699169 (Exim 4.92) (envelope-from ) id 1ovDYM-0001K7-O6; Wed, 16 Nov 2022 08:13:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444212.699169; Wed, 16 Nov 2022 08:13:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDYM-0001K0-LH; Wed, 16 Nov 2022 08:13:50 +0000 Received: by outflank-mailman (input) for mailman id 444212; Wed, 16 Nov 2022 08:13:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDYL-0001Jq-Ip for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 08:13:49 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0625.outbound.protection.outlook.com [2a01:111:f400:fe0c::625]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 97934d8a-6586-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 09:13:48 +0100 (CET) Received: from AM6PR04CA0064.eurprd04.prod.outlook.com (2603:10a6:20b:f0::41) by AM9PR08MB6659.eurprd08.prod.outlook.com (2603:10a6:20b:30a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Wed, 16 Nov 2022 08:13:34 +0000 Received: from VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:f0:cafe::e3) by AM6PR04CA0064.outlook.office365.com (2603:10a6:20b:f0::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Wed, 16 Nov 2022 08:13:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT065.mail.protection.outlook.com (100.127.144.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 08:13:33 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Wed, 16 Nov 2022 08:13:33 +0000 Received: from a41d0287b470.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F0A1DCDF-E87F-4AA1-BA24-12E9F2498084.1; Wed, 16 Nov 2022 08:13:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a41d0287b470.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 16 Nov 2022 08:13:27 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VE1PR08MB5694.eurprd08.prod.outlook.com (2603:10a6:800:1a3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Wed, 16 Nov 2022 08:13:25 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%7]) with mapi id 15.20.5834.007; Wed, 16 Nov 2022 08:13:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97934d8a-6586-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FHeC7yao2e0KNT+Zv2ShcnlZtanRjcgGypJsMDNr1tA=; b=HfFgrx3Nrd2T0M7Pd1J4Depr3PKu/NHyxh5NPaMhzEcm68g95TzahZcCIqTb0t194FV+U5De3okM02TI5pLyMt/zUkCWIBzv74PMJnbvDWir+L7CnA3Eks7VfDfZ5rHMZZI/5ABAj9uNjwTHokBxYdRskh/LObrR03JUbLZJTvo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fo6xglX9NPQGCP1uYDwseIsxs5Sej0rSdxOAtUzN+l88n+8mS3LV2v9RJ/bELAuJqqmG1WaAgptFxeXu4r/pcdj03Lam6rK3SyizsqkV9QYK+g9IODP8680jUeNP9Ny2XtZ7fjFvgbDZPem4m7X8g2iUP07T9Zvq1EwRws6UcApaXIO/8QZb1lwaXqDTUQIGrjQDSEYYbT59d9zgt6XygRbH4I9+/F6hIaMzywzyqt+8dHp+IFvCp3+dCk2rcqA8NSO6Be9CgaGQClEcG/4L6N9jU4PyXjDjQ53ALd9tgR+8gR++5K46poJWq82KShwOING2mZ9sjJGWZfKAKLgaHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FHeC7yao2e0KNT+Zv2ShcnlZtanRjcgGypJsMDNr1tA=; b=YlI9rQAQmB9tYlHTnes7Nbe4KdxifnR5ZhCBCeRtBz301qa6qaUZ216qpMKq8zR0k8pPJuUTrMFWvxuYUJi2hauvK3/8ncGJ0u6DK/+jfo7ozqgbDM/dY++vo+BtUKkzHbZAYfXzewoXxAdS8AdB3rRSO7GDkjrGwl4IS14LI9tvCNXT3My14102w4NFboOlzZS9xOZf5Gbj3UZcnUH8Bti9QVN5IlEku5ZESmzcir8NdS9ZjN9/X+pOHfENM9RwZdfKe+ZJIrgIPj4r+Zx8A8whpBbVr65GRIU/w+IfCbbEtMqx1MImIeET3QnC8DIdhM+Dg6QoO0N74NX2EPBsXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FHeC7yao2e0KNT+Zv2ShcnlZtanRjcgGypJsMDNr1tA=; b=HfFgrx3Nrd2T0M7Pd1J4Depr3PKu/NHyxh5NPaMhzEcm68g95TzahZcCIqTb0t194FV+U5De3okM02TI5pLyMt/zUkCWIBzv74PMJnbvDWir+L7CnA3Eks7VfDfZ5rHMZZI/5ABAj9uNjwTHokBxYdRskh/LObrR03JUbLZJTvo= From: Henry Wang To: Jan Beulich CC: Community Manager , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 3/3] CHANGELOG: Start new "unstable" section Thread-Topic: [PATCH v2 3/3] CHANGELOG: Start new "unstable" section Thread-Index: AQHY+XPK/7/ExkLZf024jHMZJQ3zXq5BMvQAgAAAKHA= Date: Wed, 16 Nov 2022 08:13:24 +0000 Message-ID: References: <20221116042634.50948-1-Henry.Wang@arm.com> <20221116042634.50948-4-Henry.Wang@arm.com> <42e76560-24ab-7830-5a24-a3366dfbba36@suse.com> In-Reply-To: <42e76560-24ab-7830-5a24-a3366dfbba36@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F5DC703203C694468DCE0FC8808AF147.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|VE1PR08MB5694:EE_|VI1EUR03FT065:EE_|AM9PR08MB6659:EE_ X-MS-Office365-Filtering-Correlation-Id: f2c76834-d5ac-4fbe-7213-08dac7aa7492 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wQketwjAyN42Z+E9pFqw1wJ8gMBOLRpRo957xs/mZzTY/R5n7y2esSNABRpFysYi8uG+ciVS7+VUYgcbnZd1YH4Dt/Zm1OGibGpCEAyl/641lBn2OrGzkCW5jMzHvBkOOXWnDD1eZOF93orYQnOxe/D6GEAf4Joj3DrOBPdIMq38EpBGtoOHElyDdomC5ZoVpVPIfT9u3XMY86PRmjUvqD6hbFjERistID3RrfEPan58G7bnoXXrCK+H/PHglzhJIIpCLyguxoif8zaztlam7VC/Ec29/X0gx+LBUCkmKqaDtuHApOkR66Lr5Qg560H9kGIPcJyGwjICpZABkDWvx5kDzLJbuC5kdQSZ7iJNT45jJlI46ik7RNmqRnKAmMoJN+RachnPQ6Xl6TI9jGv8AOGVnQOjnGAIpYcM3Q76Q+1tFxnHVwlc0lJWkFQs4SywX19yj2zRn6oNxIRJCM3FRDFluauRlTNl2zjrRzebUXc9ZfZWlrUKvbLIcDZVtDYHA+BfGpEMkRrl0sBvpCsH3Ybts1f5F8RjxYysllTiTPqRbXzDMh3+mmEBxYvfYiXRvEgNHcpLryW/xg3Zw6Bg62AHQK+35b6wudtnkC6P9iQuf99uD+bmTF44PrVBN2m7FxKdfGrD6AMDCSXUCgZididmRBL3XNvfnNoX9Bb/q3mQiaxw9gtETe4Ka70WwXe/S2Ct7mVHXE7hKVNRwMTogq6h1VvBOGAj2s7mVwXo3mV/0ycSRhdvLHteWNViRMbbB8fgbvNzZdoqH/Fp2/XpN0ujQOBFm2pvm/2d92dfDEopLxot/IwgMpHzMe5zsghKcqHjgvlQ+Hluc+5pWWXd1Xjmw5mIjRGefchuggH5d3aU7wwd2d8+a7H/CYgvu93R4e92JTdzGdHoVJF6rjLyd9g38iyskAwx12VkKT90FIg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(39860400002)(346002)(376002)(451199015)(66946007)(5660300002)(316002)(54906003)(66476007)(8676002)(186003)(64756008)(76116006)(66556008)(66446008)(4326008)(6916009)(122000001)(38100700002)(38070700005)(83380400001)(41300700001)(52536014)(8936002)(4744005)(55016003)(86362001)(33656002)(2906002)(9686003)(7696005)(478600001)(26005)(71200400001)(6506007)(53546011)(59356011)(219803003)(207903002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5694 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 23b71367-4b7c-4457-8f25-08dac7aa6efe X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8cAFJefiUE/u7iKCnsRMu5wDsiQDvKaKla2aUxEnGWuQ7SJsytvidveHBrxkVMOqx76Sh1OYcJeCGNQogGVt2NxMNEqdLvWdCVI7VFsb/dwsh4C4uKCP+xOa9oU+JY84BdoEXmTpKdQuGJc6x5VK/WXDBFLDLYIDMywvzqtk6SBJcxQdE9CStOYgufAzYqG2w79RV2Yl+KlWvll2yKtGdBcrUaHL/SvPi0GVJdJjQPW+ZsmahzWL6ZjX1btzkv8SRxNcAp+YQmCIeqSFEDX657pUZf1lSItGbLnKO6Rie9ml1sruhvyIgviio2l7UZkPqisi7W+igHyrlRPgRWQno8fRuEJtPADkSi//fgRl4L+QOclCqwAERK68yxZ9xSnxprPCfhkuTum9ZIviEO9K/pK4pptP+ynKOHrR1tNZxAfjWJvk/5cAVitYSWPjj2KzH5wt2wmP05/ye3cmXwgIPvf77qgNMWM+zyIOSlQ1mErhMmp4aaffHDhGp3NeIB6C+QJquTrXLRZETjWDXHSDVoY3o0Tj/58W6DVx2lKBH8fV3saqBrbqDsTSoroODYIhELL/TZIXQXhe+XNpqmSS7zyCLS/feS4SewsPLHyQ1WAhmDM1TQiXH3qpE9a/hU14eT8+WckLBOLZ5U48JuC1GMZxYkUmCfTdWAPxo0SN+2cETqrPsmL3a38r90LQgnFTVXJQZFCEkbOoCF3qzB0iiJ0PbE9bNyOnWUWuubiy3sITwIZYduO0pgmIO5Fu56Ku4bKgDJlB0tt1Bbc+G4rF4OcthcXoxjI6XNe3A3KyXFhVOjd5sDcKMjrqWRgn8Y6B6NBM0sGz+2fuh55Urr5ON3qhT9xXsUaFIxXIzDeiLbLuziDWe2htnaKyRI4HigS1kHsO6tDjQ55b9iLKiGBqMh3kFkCG3JBRrvmDFhdGk0Y= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(376002)(136003)(451199015)(46966006)(36840700001)(40470700004)(53546011)(7696005)(6506007)(55016003)(9686003)(26005)(86362001)(54906003)(40480700001)(478600001)(36860700001)(82310400005)(47076005)(82740400003)(81166007)(40460700003)(186003)(336012)(2906002)(356005)(83380400001)(33656002)(6862004)(4744005)(8936002)(316002)(41300700001)(8676002)(52536014)(70206006)(70586007)(4326008)(5660300002)(59356011)(219803003)(207903002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 08:13:33.9375 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f2c76834-d5ac-4fbe-7213-08dac7aa7492 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6659 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAzLzNdIENI QU5HRUxPRzogU3RhcnQgbmV3ICJ1bnN0YWJsZSIgc2VjdGlvbg0KPiANCj4gT24gMTYuMTEuMjAy MiAwNToyNiwgSGVucnkgV2FuZyB3cm90ZToNCj4gPiAtLS0gYS9DSEFOR0VMT0cubWQNCj4gPiAr KysgYi9DSEFOR0VMT0cubWQNCj4gPiBAQCAtNCw2ICs0LDggQEAgTm90YWJsZSBjaGFuZ2VzIHRv IFhlbiB3aWxsIGJlIGRvY3VtZW50ZWQgaW4gdGhpcyBmaWxlLg0KPiA+DQo+ID4gIFRoZSBmb3Jt YXQgaXMgYmFzZWQgb24gW0tlZXAgYQ0KPiBDaGFuZ2Vsb2ddKGh0dHBzOi8va2VlcGFjaGFuZ2Vs b2cuY29tL2VuLzEuMC4wLykNCj4gPg0KPiA+ICsjIyBbdW5zdGFibGUNCj4gVU5SRUxFQVNFRF0o aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zaG9ydGxvZztoPXN0 YWdpbg0KPiBnKSAtIFRCRA0KPiA+ICsNCj4gPiAgIyMNCj4gWzQuMTcuMF0oaHR0cHM6Ly94ZW5i aXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1zaG9ydGxvZztoPXN0YWdpbmcpIC0NCj4g MjAyMi0xMS0/Pw0KPiANCj4gU2luY2UgdGhlIGFkanVzdG1lbnQgdG8gdGhlIDQuMTcgZW50cnkg aXMgKEkgZXhwZWN0KSBnb2luZyB0byBhcHBlYXIgb25seQ0KPiBhZnRlciBicmFuY2hpbmcsIGFu ZCBoZW5jZSBwZXJoYXBzIG9ubHkgb24gdGhlIGJyYW5jaCwgd291bGRuJ3QgdGhpcw0KPiBhZGRp dGlvbiBvZiBhIG5ldyAidW5zdGFibGUiIGVudHJ5IGJlIHRoZSByaWdodCB0aW1lIHRvIGFsc28g YWRqdXN0IHRoZQ0KPiA0LjE3IGVudHJ5Pw0KDQpPaCwgeWVzIHRoaXMgaXMgYSB2ZXJ5IGdvb2Qg cG9pbnQgLSB0aGFuayB5b3UuIEkgd2lsbCBmaXggdGhhdCBpbiB2MyBvZiB0aGlzIHBhdGNoLg0K DQpLaW5kIHJlZ2FyZHMsDQpIZW5yeSANCg0KPiANCj4gSmFuDQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 16 08:16:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 08:16:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444216.699180 (Exim 4.92) (envelope-from ) id 1ovDaZ-0001yL-5f; Wed, 16 Nov 2022 08:16:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444216.699180; Wed, 16 Nov 2022 08:16:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDaZ-0001yE-2U; Wed, 16 Nov 2022 08:16:07 +0000 Received: by outflank-mailman (input) for mailman id 444216; Wed, 16 Nov 2022 08:16:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDaX-0001y4-9i for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 08:16:05 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062f.outbound.protection.outlook.com [2a01:111:f400:7e1a::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e9aca8ac-6586-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 09:16:04 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7703.eurprd04.prod.outlook.com (2603:10a6:20b:23c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Wed, 16 Nov 2022 08:16:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 08:16:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9aca8ac-6586-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hTt9NqpbDUf6oTYL0Wl6S1rwwaKYD17e7e3VJJvZNKS4FAQTI4GNfsU4qMINcSKnPy1QM1uGhzes/WOGEAPiZuUPFRLPcTyaH8qVBBJvRYgzuoEYbP2GucvQIND9BSpAZByhJxqXPUDfgiw9THJt2Y04mHGz8AUQD3Smx3aJJhJJy/Q5kW3MTrhaHKttAtjLLpJfDSruUwpoV3SQGKluj8UVYRNBKk8Ji0j/w7G6IRj0MDfk2StKE//6qQrpAluyDqX9lSA7ct3ZEPQZ6kV978OBnArtSPsKopT6L9ufQ4yNzE6N1lG2htb6ke4dzhroCsPJEc6TM7VITggqMto+HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=haJQbwwmOnI81hOD0BK1IhK6XybQnX+fwjiaKfKbmUQ=; b=mm/UKvlkuBXNaMBjZSRimUz94l2/ov37NdYQpywr6kaojxUZDPnZbddCeWg3wRIXJ76NS4YCJ+okBTKYuQW3ztn2nxb61qzXoFCDF0E9PbCsXkKypl8gL7HZJ0mC57p3rZMtoz7PbQsjJbsgpN7k3W6RE0yE9wJhNJ/I1MBzuKLRU0Pg0ekWeQpXSe1GIZ2fcoqyP87fC6FyPTmeKpeM8EfLYYXRGA17Xbh+oPAKMiyULB7pm8zpfn0DEKjSrKgGXk7t5hniRYmE0ytYH9iS2440F1Fl6G1z+IPUP5ft2LdOy9rhpoa5VSviT39Pnuys+PLEbFyoF8GuNXZCmGN21A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=haJQbwwmOnI81hOD0BK1IhK6XybQnX+fwjiaKfKbmUQ=; b=I/Du0Zwh1JVeXLwj4dKnWFBiGqRyQ3fiPIvilINTZMrencZJz2Sl6TpN0+hjN41BBNBLg9k5bQ54ffja5Wwnd/hpwnaYv1AKA9oL8oEunehU266JYoWWx5rrbk1BYJEez/R+4ijXsGQ/L7ZAQsyFwQgEtMy+WGa/0ag2LtOptyQcFvH6JeNUJDaN1ifNKU89bmPmxzzoUazmVdfpHpU0SgXHfb12m7iNGGEw9ukrfjpLcEwiN6ZvqEGWOhrS+X4m7OUdUSSrFy8vXVQ3KHPl2WzEO6gFaybeETkEDs5xgkWo3LI7RIsGcwUPLdlJSVQG2qW0VTE7oTi1OlqPmUauyg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8efda654-c13b-2e8e-445a-ee537f1054c2@suse.com> Date: Wed, 16 Nov 2022 09:15:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN PATCH for-4.17 v2 6/6] xen: Used SPDX identifier in public headers Content-Language: en-US To: Anthony PERARD Cc: Wei Liu , Stefano Stabellini , George Dunlap , Julien Grall , Henry Wang , Andrew Cooper , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Christopher Clark , Paul Durrant , Juergen Gross , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , xen-devel@lists.xenproject.org References: <20221103115204.49610-1-anthony.perard@citrix.com> <20221103115204.49610-7-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: <20221103115204.49610-7-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0200.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7703:EE_ X-MS-Office365-Filtering-Correlation-Id: cef11ead-7710-405b-d06b-08dac7aacbef X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WzXMZZ/Kw129S5N9r8AbybGgWd4QYMtHI7P3VrmaBLi5fieD8jFJLPwbbPf6oZ7ircNsKtWpr3/ZhRE775Cfme7EDqnJbs1uqlAJchp5sFwHJW7aGU7wwvi+oragQ0OaiO6c18pdFM8CdJnZOtvRVo0o+GehUFmeO2RnsNkCpLkRDbGHA6/LEQMj2TzxdShOvB1tzVZ7MXvFdR3hJku2PL2paKUTRo6yc/vGxku+QioHv6+QrzrjjI9T9Lk9mUUdGi1/PTSvdvyX0Ll2+CvuO+aTKt36XIKTlyC82LAgXVYG/g1+vwLx4GntPdJ5cy3bfd0Re92wM23b39SkvZOYQ/WPaUzabpsl+jra/Fnl7Uc1UoOqjFQ8Sv5nCtlNKu1GtyG3euSYOPf5i4zNJm0IE/A2RFU0GJSeuabmSnyxGsmT/O1u4Tj/zt7p9ToO9u+lfPOZo506+zU99ywfdTU6shIUCcBN+2/rtiPUT8DQLYiLKE0l2U1vQmZObfvQRrkYkUhsDW5KeI7iK4K8ZJgjssHigXMavxVPGxHd5beZZe8BRqKnYJTCPstaik7XA+siLlQRUaxFbqU/0jmYDIoQdfbcVKy6gdzbEa+pZHlIhhUmclrPzpybDrCdir5kM9sdyl/YTuLP7mH9eCb8zNH6QCrsZOJFFuySa+fU83YcQu4nORYAU8189jC1BpF5mN1uFcZE/yOhO4KLqRHROqbgJeZet6dhGt68XzP2mZA+lonNmKoViXXBgfpfYOx9+KYEouyKeqTSgVijuVvNOyx+LQVjyqG9zXvPuhYnlPBIrLdX6MCoYOd+4pKANkIeiTpm X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(396003)(39860400002)(366004)(136003)(451199015)(478600001)(2906002)(6666004)(53546011)(31686004)(6486002)(6506007)(966005)(6512007)(26005)(2616005)(36756003)(186003)(8676002)(4326008)(66946007)(66556008)(66476007)(316002)(5660300002)(6916009)(41300700001)(54906003)(4744005)(8936002)(7416002)(86362001)(31696002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djI0TDZlU2xjdEVCNzFEb1p3MXJPS2VteHpHWXdqZnRPa21OY1hnaGh3d0py?= =?utf-8?B?YURic09CZGF0OVMrWWRZblFzMkw0Y3NyTkppVVJ1NE1kdytJYmV5QStjTHZX?= =?utf-8?B?d3hQak1odDNwdGQ5RmkyaXNoWTJTazFGbTY2RjdIZmJVbW90L01IVDB4SG9G?= =?utf-8?B?SFpjRzRQUDRRZkUxOWt2b2VzbGNsck5CQU9QNmJybWRzeGFnU0dlcG1tcmMr?= =?utf-8?B?cjF0eDdoYzZ6S1QxMWtZQ3FvZUFUUFRIdkFqRHE1UFkyaUJrRjFLdmtVdEF0?= =?utf-8?B?eTY5clZuRmNJTDg3dGM5TmFSazdGYklpVmlvci8yV2lybm5qV3l0U3gxOHJU?= =?utf-8?B?M0Z4US95NFZCVlE0d1U4R09DSjE3bTZPTlVHYWYyT3kzNmk2QTFIT21weG1R?= =?utf-8?B?dEdlWS9lcmk2OXBIOW53WnNjMmlXcDBEQlJPYjQ0V25pZDJyMzNkUVhJVTR1?= =?utf-8?B?cGx5UGtzclZJTEszWElqcGZpTkxabGdrcmR1Q2dvelF5bDVBZmVsZEp1bmNU?= =?utf-8?B?YXNrdWxDeVJheEN4eitTM0U0dWdOdWlNNnV4Ukd6Z0ozL21GNmhJdTBNSHBG?= =?utf-8?B?YjdhMDJVbXY5ZkxUUGFpUGxyU2xuSkVUdUhKSEYveGtyRjY5NWRJU0F3NGlm?= =?utf-8?B?bnpYWkRpcFNxeXhRUXZqbXFYYVRka2VscDYvSjBYM2FUak9rK0JMUzFQdSs4?= =?utf-8?B?a29INGNEcmE4V1ZjeVR4bGVIU2pUSTE1MFpQSDc0M2JjNWQ1dmhheU5YY0Zh?= =?utf-8?B?MUN1NE9meWhLelVQS1ZuYWozR0tzcFJPUTBYSTdtazhudmZQcHd0aEtpS3M3?= =?utf-8?B?cXRUL1FiU3JDeC9JQ0VxNXhFNHh2M1BrSktRbktHdGJzcndlODNxV3JiMXVs?= =?utf-8?B?dlJiMWIrNVRUSTZsTVYrRVIrb3NpdW0rQ2kra3pPdUtwYXNwbXV2TUg0bWVM?= =?utf-8?B?MXFkZWVIUm5jL1ZiSVRBTmdaa0llMnoyem8yemdETUUvNmsxRXBWWi92bVhj?= =?utf-8?B?bjZ6NjN0Zm9RV1lWdFFHRVdIQU5YakpjNmVGRC9QUnplNEdQb1pqdUVuNldH?= =?utf-8?B?T240MWJwcHAxeFFDQ1o2bVA3bDdLczBwbU85S2pUMmRUK2dWQ2tIcnhhcTFZ?= =?utf-8?B?QVhBZkd5RFVmc05wdmZLODA0d05TU01vQmIzY0RpalJRNGIwTjMyVEp5V2hn?= =?utf-8?B?Y2JySEt4Z2xpQS9lS1QvczJ0bDJoWWw5ZVdncXNrUWJvZWRtUnRTTjlyQ1FO?= =?utf-8?B?UnhZOVpicHpwWXhSTHBZSklQVk1uL0xYODBJQjUyUXBmQy9mVmptcEhacjVB?= =?utf-8?B?dWp3QXN4MkFvSGhYdHJPblF3TnZjd2pjQk9mS2xuQ2d4Qm90RHdFTlY1aE1V?= =?utf-8?B?QnYyR3RKOUxTOEVUeEk3cWQ3bFk2QjR5NnJUeUNyekhvZVRCeUxQZlVIZkJw?= =?utf-8?B?eGRHYjhyZ1NRTkxsZXgyeXJUbkVJZUZsdmNNZitHRWM1bWJYSklrR3ZjaDdy?= =?utf-8?B?azEvM29Jek5kTVZ6UmdzR2dsTUFBaHVVdDlNOVFXY3I3TThkN3BVOFJhWWdK?= =?utf-8?B?WWwvd2Q1enE3N2hVY3lRL2Y0Rm9wdG11RjljNG5rS1RiWEp4cnRDZWRuR0NZ?= =?utf-8?B?QnUrVGt4dlhjQzNkWElNaE9vUW9ZYy9lcnozMm9MN3NrNWY3VW5USE45cTN6?= =?utf-8?B?SUZnaXlRM3ZXYUFHeEp1dDViZDVjdEVZVkpNVzNLV0t6RkdWV3ZLdXN3UjBX?= =?utf-8?B?YjVJKzRrQ0llNFM0TnVNVEVBdDRLL0tJNnJwdFlNdW94cXlyYVAvMDgzVXEv?= =?utf-8?B?RWM2RytQNnEySjgreVJGVldoV1lETUtZQTZ5bGdsN1BjcDZYbFNMMDVkVm5z?= =?utf-8?B?MC9JY2pLeEoxSlVVSWo2eFBleDJlNHNEd3Z3MG4vaTR3dmhjdXV1ZEFSWmtZ?= =?utf-8?B?dGhLZXY0cXViTm9hbUFiNS85TUxXSTNNMEtYMFZvNWNlQUt5Mzc5VWx6cG5M?= =?utf-8?B?a0pnZnNGak13aGFQMGlhYW42WkdyaHFocEp3eGdFNDZ6a3FBclZYd0lCRmgy?= =?utf-8?B?TDVDaTJSb2VqQzQ4UWRVZXRPaFdxbTZiSHFuYVZCenZGaGNoZVc0MkpFd1RO?= =?utf-8?Q?GP/GSbt52DdIuArssp11PAqPP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cef11ead-7710-405b-d06b-08dac7aacbef X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 08:16:01.2923 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wcum+00qqUOsGaekXoBa8U7KTARUTG2CtGrJa5yJ1drf5VpoJ96IeXGgZYQjBNWIFAqz4bKdX3t3DZldup6K0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7703 On 03.11.2022 12:52, Anthony PERARD wrote: > The text of the licence has been check to be the same as the one at > https://spdx.org/licenses/MIT.html, except we don't have "(including > the next paragraph)". > > Mecanical change done with a script. > > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Nov 16 08:27:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 08:27:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444223.699191 (Exim 4.92) (envelope-from ) id 1ovDlb-0003hY-5r; Wed, 16 Nov 2022 08:27:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444223.699191; Wed, 16 Nov 2022 08:27:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDlb-0003hR-2o; Wed, 16 Nov 2022 08:27:31 +0000 Received: by outflank-mailman (input) for mailman id 444223; Wed, 16 Nov 2022 08:27:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDla-0003hL-32 for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 08:27:30 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130077.outbound.protection.outlook.com [40.107.13.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 81a98aef-6588-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 09:27:28 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8651.eurprd04.prod.outlook.com (2603:10a6:20b:43e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Wed, 16 Nov 2022 08:27:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 08:27:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81a98aef-6588-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V1ohmuKgWOBw4uLj60NtPVaE0iThQzfSQ8BVuG8z6fam6ZcP3i5qvJ1I0jRl5CXDCtTqnWKwEZ9m+D1Zsd9BFSU34HpiNDaDlamA6/E+aTrj7+2PPvWdoTfvvcHHVdL0WixsFI37a/NzqsefpDTt0LAX0GOBvq8EtQ3kJHMCAetrNVgrn6ZkjbHjdXHC4IvoAAHQ/48rWzTHFsBYcIPsst4XZg7UHft9BEyUalmRGaCHZeMKuAdGf036mI0EQLe6BvQLNQzQf0d1O1ZSybnaBWj+O3MR2brttaoD68z3lTbX9AfCJzUSlELZkfIzS97HX+kvtL7+VN8BwoVnLsko8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LLGdDMOOC/ygyuSi8a2hmVUDtBb5YksZXW/kX2+p4DM=; b=GjqKVibOT1lIWq5tNnEIC+LaHPgGdgLpUHFeXA5FIiXglltVyv/kKI9Q7dlWwtqPeOb32SRxc1ih4vYFC/7goTXPcRPMlRmEBeqKqR9Yt+ATCacoAP+cs+o6zUlqYK7me+zaPWT5Lt4BztKM0Fn0FKUDHHiC+xLUWzFMuEUGdQQB/ktFw7KIWlva/k4rL+xv4g8bfQXreJN0d5h6+aSbmOUVao/V5dT4CfOFB523kLLbOWBwyXv+6HjXn3vUVPqibh0/NKDwWD7NrylWgG7WHQ4JLTsNO+7nYs6l+5+OBcs6EvpQLNHQSXvZOTuvic28OMTT/It86Y/zWhtONhCusA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LLGdDMOOC/ygyuSi8a2hmVUDtBb5YksZXW/kX2+p4DM=; b=TX+ApB/cT7QJSgp0XIHf8RljuS+MYcpNR+st2yukcR+3oeqSF7JHcmEd74EVqwsXCuehqcSCuVMhFFqn+zQvPn3STlBGRbbjbBy15rqWbGpQIbocHUhJ6vRZ4IkqVtixKUh1dkGPEOKiBCFLTFHhtymumtkIW54BgBd6mYyUb2U6ljtOPrCy+Kank/IikI9mbY5V8RT26qqYG3AVAeqx1T1WwY6YghAM8kXsIyqO5DQS61nfw7OUDb3VNspD+D3PfEf8q4BnLIAEZPt8Q5/KEQQ85HN8v+n2YLd8PwtPDKtnRd+YxEId7gCqLyjNqP6+uJKaelTAlJQVBOf40HXQJg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9896fb80-351d-2f4c-f672-ab55f436899c@suse.com> Date: Wed, 16 Nov 2022 09:26:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool size Content-Language: en-US To: Stefano Stabellini Cc: Andrew Cooper , Roger Pau Monne , Wei Liu , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony Perard , Xen-devel , George Dunlap , George Dunlap References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-2-andrew.cooper3@citrix.com> <0f048bd2-d08c-8bd5-2a20-7e49e794c679@citrix.com> <8a8bc184-6237-ed24-8d9f-daa3c36df915@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0153.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8651:EE_ X-MS-Office365-Filtering-Correlation-Id: 84e5454f-67aa-4d60-c56e-08dac7ac54fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DKXqy5RYaB02JtSe/h2+Sv/ceEadwb3Q91WQRI+96Q0TEjodou4yRp0Cs3D96UBhaDmJtMckRvjIZCJNDQtNlW4vUyU8o9pSZ7vPxXZll76rN0+yMjNYU4sEEHY5GfLcsm2ASvPmZRY8+fiJ6SZGfNHINhPizuIVa2hc0Yz8asscu9hWOpSAWABvVKUzzH8i3FUpTdpR+Uer42uHJmAm+EyAiOA/b4mfaRE4dsVvjXORcXnlkA8foIxblXZ3GMqTL/JIiAfbv0AhIhws8gR3VQ/cxNyWEBQdWp8JrV0xf1P8bmllvKINqJV1fDh332tEyIA9n+X3zbU+aQN9lT+YKyhQWoOq7AFSslUoe9Z/PX1tCd97jTGqeyFlLJ2fT8oIdoRD5FLKcUR0kvTMOKlboGweR9dVMpPrYbvFs/av85NvbMzvJjq39wYLR1dYfwp4A4VAmIGsKVsDFeoYa1e18m2HADQAcHlonMah4u9V2Qgpa9CNlu1iWVy1iZPI8wv53x85Zfudl53qu3GesVKgsp8uZVdBlbqM3FGxN2/uRMAlzqPDThLRqQ6JQB37cSy5TlWaUnDbR/y5LWtsGT8iBNxDfvky9n7OvBznD4zUjvQnjdIujmMUjZRSzJjjionqCg6UFDNC50xa9scYCnVZhW4zb4ghX2FG3tH+4+Q4Co63tvpdETCZ/3xk6JHbUam+VFQkHa9aUSdIqRXox6P5toGyZzIv/0WWBJ+hyxXHGuLSF97SmrnXKnqqywF5uJefoowa5K1n91eU6QkWwh5wX8qVnS6hRGWulWJfjN8grZ0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(39860400002)(346002)(396003)(136003)(451199015)(186003)(26005)(6506007)(6512007)(36756003)(86362001)(2616005)(41300700001)(66946007)(66556008)(66476007)(8676002)(4326008)(53546011)(83380400001)(6486002)(31696002)(478600001)(6916009)(54906003)(316002)(38100700002)(31686004)(2906002)(5660300002)(7416002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEh2VDE5S1JPNHM4N2ZGRWlXLzc4S1UxalU3RWNqUUVvZHVzVXFRZ2ZuckFq?= =?utf-8?B?VUNKdXR4clZOMDFyTXoweUNjNUowSXdIWUdONndKZTFHNlRMSEdHZ3pBMVQ5?= =?utf-8?B?VlN2dWFteXJyeFhFa3NzTHhwY0dpWUVYVHVINDg2Wm1pUU5LU3dwNm1vKy9z?= =?utf-8?B?bytZT29QWUdhRjBReVo2aFZScVN0bEFSUXM4SG5pT3FJcXEza0VMODJJaEtV?= =?utf-8?B?MXI5WkQrQmRwMDQ4TjVjTENBNEJheDBxN211ek5Zb2ljVUR2TjU3YlZqRFo3?= =?utf-8?B?Ykd2Z3hQY3VpeXZ0eHFjVVlIUGFXS2c4RHBaTkllZ2E3VnV2YnRmMDFJU3F4?= =?utf-8?B?ZUMwMitSVldVZG1iQlRUamNqdkZNVG1Td3FBVmZudUJzUXlBdldKaEdQS0tX?= =?utf-8?B?NERkYWF1bFdMZkRRbFJiTE5GRWpWRWppVmdXVGtsSUlzcWp5VXUvMXFrbWhJ?= =?utf-8?B?QnhPdHBTYXlGYkVtQXRKLzVmT1dyV0pOQUtGa1dUOWRzZEppZTlZZnkzZUlD?= =?utf-8?B?SkVaTVUzS3dyRkI2OWRMVUc1emllcVpRWlJsSDRrUTdoMTJ2Q0Z0TmdTREVt?= =?utf-8?B?Zkc0QmJRRFViMHVpamUxZDdMeFRZOGQrWHRmeEhvd3VxbHR3ajAxTVkrdEtv?= =?utf-8?B?UGpSeVlEK1hlOENlaG1pdXU3NDd3dU9xRngyZmhoZ0dITVVSbGY0MjVxZXdJ?= =?utf-8?B?S1NZM0hObkJzMDdPdmRXMUIzVmEzRlNyUkU4cEZHZXprWjlmYTI1MHAzZ0RF?= =?utf-8?B?RnE2ZW1rdkdIbjNPYXg2OVE5QjEzcWRXVE5xcUY1SUlWaXp3eVNJYlVmQzJm?= =?utf-8?B?eWdwZDBPa3M1NU9UaSt2Ry9WWm9RSHVBd2QrNVVBTzNxdHgxd3JPb2s1RWp0?= =?utf-8?B?QXNlSzRiM0M3b0hjOGlkRXpyRUszSFpOVm84QVhGcC9XWXI5RENhb2k1ZDRh?= =?utf-8?B?d2lPbFpRUGVJak14YXoxSFFFQmxDcU16ZU9oQk82SUlERWJJZFkvOXgzWVFl?= =?utf-8?B?QmkyODErVXV2L0xXUTBiTzJxQjh4T0I1eVJhZTVJaGRBSUVSRVlSUW1ETTFq?= =?utf-8?B?MDNUZEtKanNRc2dNT24xeVEzdDNXZ3pEeGhveGpSVnk5OWQvdHh4VTRQYWxT?= =?utf-8?B?d3lkeTM2dHZLUHIwQkJNVXQ5Y3dmbHlCQ1RlZEdVUHp0OWRMellLU0xYUmdp?= =?utf-8?B?QVF0RXJkK21qcG1VcFRwN0NrcDBTb28yclNzWkZsNm0xbG44Skc3ZmZ1Mmxr?= =?utf-8?B?dzlzY2lJZXlrOHdnMG5nUXg2b0NIdlVaTDU4NTRZdmlwZHlHdXp2Ym1NeHpM?= =?utf-8?B?TFZPZGhlRHk5NldRNDl2bnhIcnF3TGZ2YXV5cWpaWnhZbE8yaFV5UWxTY2lq?= =?utf-8?B?SXJ1SGg1YXZaaXdqMWVpbnJhOTQ3SVYweWpsZUU0a0JNTUlBb3RhTGZGZWN6?= =?utf-8?B?NDg1T0dmN2ptYm9jd0pJUXFqOUd4WHg5TWc3REVMMFFONEJBcVRmZ1pMOGlp?= =?utf-8?B?MkZodS9IRzdwU1VYSStBUGhhUms3RXQxQ0NVYVlTQ2NIWUJTSmJJZER5OFdz?= =?utf-8?B?NFFWd0ZjRGxPcEFJWTdkL3hMaVNoVjFIMFpVTVFLQ2FCT2MvKzhzWTZyd0Fl?= =?utf-8?B?amJLWlR4OW1QMGxDUHJ4UmMwQUVubGR1UERoK1NLbHJ6UDRhWjFYdmZGRkMv?= =?utf-8?B?ZjgrMkxtTnRtVmVQZGkxZ09RV3lqcWhmemlqRjB2akkvQytkdmdRNzlac1Qv?= =?utf-8?B?MTNpWXVleTRLL0k1L3h2ejFhVVAzTUllODJXdDlHWEFMUGlEVVUxR2JoWXIx?= =?utf-8?B?bTBRT1FMbUN0TUZuUFpvelZlNTFxTDdSWE14NEFFRUhaRDg1c29wNEUvTHJo?= =?utf-8?B?MWc1cTVuR0h1alB3QitPMWFBUCs0cWVIS01UbmpRRENkYnA1VUdTTGxmbVl2?= =?utf-8?B?RWhGZ0h2TER1anRRZGN2OWpmK3ptYVFqdStmMlFBSTRyQVRYZ21qYjF0TEN0?= =?utf-8?B?cHBuUFpGWUxwckRHcDQ3N0k5N2Mza0d2WmRDVXJ4OU5jazEvYlZZajk4SWl0?= =?utf-8?B?SmN4UzJteWZFYjc4N0craExmUS8rWGp6MWhRNU5aM2FPM0RraEg2TmwwNjlW?= =?utf-8?Q?D8CJ1pt4ouvnPEnI4EqIPx4KH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84e5454f-67aa-4d60-c56e-08dac7ac54fe X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 08:27:00.2037 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0GmoTqIATvw0Up3C3hhPBKbhjeAGMw/Qiedhvp5/z2ruvpG6w0SPpur9qG9WlNGM+KTfD3kP30mhn81RW+1d3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8651 On 16.11.2022 02:19, Stefano Stabellini wrote: > On Fri, 28 Oct 2022, George Dunlap wrote: >> On Thu, Oct 27, 2022 at 8:12 AM Jan Beulich wrote: >> On 26.10.2022 21:22, Andrew Cooper wrote: >> > On 26/10/2022 14:42, Jan Beulich wrote: >> >>   >> > paging isn't a great name.  While it's what we call the infrastructure >> > in x86, it has nothing to do with paging things out to disk (the thing >> > everyone associates the name with), nor the xenpaging infrastructure >> > (Xen's version of what OS paging supposedly means). >> >> Okay, "paging" can be somewhat misleading. But "p2m" also doesn't fit >> the use(s) on x86. Yet we'd like to use a name clearly better than the >> previous (and yet more wrong/misleading) "shadow". I have to admit that >> I can't think of any other sensible name, and among the ones discussed >> I still think "paging" is the one coming closest despite the >> generally different meaning of the word elsewhere. >> >> >> Inside the world of operating systems / hypervisors, "paging" has always meant "things related to a pagetable"; this includes "paging out >> to disk".  In fact, the latter already has a perfectly good name -- "swap" (e.g., swap file, swappiness, hypervisor swap). >> >> Grep for "paging" inside of Xen.  We have the paging lock, paging modes, nested paging, and so on.  There's absolutely no reason to start >> thinking of "paging" as exclusively meaning "hypervisor swap". >>   >> [ A bunch of stuff about using bytes as a unit size] >> >> > This is going to be a reoccurring theme through fixing the ABIs.  Its >> > one of a several areas where there is objectively one right answer, both >> > in terms of ease of use, and compatibility to future circumstances. >> >> Well, I wouldn't say using whatever base granularity as a unit is >> "objectively" less right. >> >> >> Personally I don't think bytes or pages either have a particular advantage: >> >> * Using bytes >>  - Advantage: Can always use the same number regardless of the underlying page size >>  - Disadvantage: "Trap" where if you forget to check the page size, you might accidentally pass an invalid input.  Or to put it >> differently, most "reasonable-looking" numbers are actually invalid (since most numbers aren't page-aligned)/ >> * Using pages >>  - Advantage: No need to check page alignment in HV, no accidentally invalid input >>  - Disadvantage: Caller must check page size and do a shift on every call >> >> What would personally tip me one way or the other is consistency with other hypercalls.  If most of our hypercalls (or even most of our MM >> hypercalls) use bytes, then I'd lean towards bytes.  Whereas if most of our hypercalls use pages, I'd lean towards pages. > > > Joining the discussion late to try to move things forward. > > Let me premise that I don't have a strong feeling either way, but I > think it would be clearer to use "bytes" instead of "pages" as argument. > The reason is that with pages you are never sure of the actual > granularity. Is it 4K? 16K? 64K? Especially considering that hypervisor > pages can be of different size than guest pages. In theory you could > have a situation where Xen uses 4K, Dom0 uses 16K and domU uses 64K, or > any combination of the three. With bytes, at least you know the actual > size. > > If we use "bytes" as argument, then it also makes sense not to use the > word "pages" in the hypercall name. > > That said, any name would work and both bytes and pages would work, so > I would leave it to the contributor who is doing the work to choose. FAOD: There was no suggestion to use "pages" in the name; it was "paging" which was suggested. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 16 08:30:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 08:30:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444227.699201 (Exim 4.92) (envelope-from ) id 1ovDoX-0005MW-MM; Wed, 16 Nov 2022 08:30:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444227.699201; Wed, 16 Nov 2022 08:30:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDoX-0005MP-Jb; Wed, 16 Nov 2022 08:30:33 +0000 Received: by outflank-mailman (input) for mailman id 444227; Wed, 16 Nov 2022 08:30:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovDoW-0005MH-PJ for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 08:30:32 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20602.outbound.protection.outlook.com [2a01:111:f400:7e1b::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ee755946-6588-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 09:30:31 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8285.eurprd04.prod.outlook.com (2603:10a6:102:1ca::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Wed, 16 Nov 2022 08:30:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 08:30:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee755946-6588-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OxXVvesUrhHZptnZprLajL28HGnNUSIHVODaPS9ofiHLEzYb4VPcZpY8tXvihxnc6LOwXntTmumc6JJgDtJy3cpeHXTH8Ha9FJNADS7q0x0wON0R9erL2JVjdDbwX9ILZOsSZkCxpeMYyI+DNPzb33VXiuvk6fh1pPPDeyRFyzqvgJ46CxnYYh9jKvdth2RUzhhywlY3F7WxIRaVfmSDdZtwbmEqNKHjoCjQJBOOVOYW4Ba/EgcGXW5exgc9JOw+nNRgXyLCI4g5o454PDr38kMEgd87qNyKEgqDS5C1LIB4tdiLjFWf7acRLoXzWqKP0A+hqmBSy3kW45z3ZK9Ctg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=axfFSnyJbvDY2gZir/ghgWEVvgbEK5iHpnHlwOsHUo8=; b=fhuemvKauGQTCnEkCQ5kF6NKHrBRE8EabVppS+K2t9eGyLB6CH/ef1sN8nSzyJOaIt9WMKQOzWoOQoyNdiHnWC4hWgQCOSGAc+FqGYInEB1nGKIuBmqJb0VDeQ8/CR6JbwtKXqDONkX1lUJIFz1hH5jfZBxz9c+taWv0rJCVX+XtWcS6WacghSN5l0CvMmy/FSHegQmXoFIaSYrTqHqfUn+RszP8FsAA9XTbVCptlJXpE3wxKvx30tpHjKA8boLnRgHYmPTgizRa+cLZSbf1AbSDJRtpdvw84Dj6xhuaztU2n95TtJLaBx/4U74YjyEr2gwQn5iy+9nZ2FVI7hQ4Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=axfFSnyJbvDY2gZir/ghgWEVvgbEK5iHpnHlwOsHUo8=; b=sISmMYVFgkfa1DT/Bk+8oxGfNQmcY0unh+0NYLkT19PkdbZ3XLCOp1dNMMCd0TSRHa8atKQwxzIxdAZcFZ4xsvw/os/CIGF9rjjkP2EoxvKHI9S6mRPIMcVHRWTnmESilOIIrtVR0Q0/27UtsIC1eL+B+DNU57tfZ+BpuM+5/0T5L+UicCe4SPLnSDyaJwHQRvPZ2krt5WnFOB7uexyv1fEdgx4jCkBGlwK4jM5LMRLCtJL9HHoSOa/7LLCh+dHp4Fn+CVAeD1JjFBJNnZahh2lGSCau7pzN/2mYuQGZkNOjn2DbdDy4eCcdVok16QBQEUBq5CM6bggv7x4L5yqGnQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 16 Nov 2022 09:30:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls Content-Language: en-US To: Stefano Stabellini Cc: Xen-devel , Xen Security Team , Roger Pau Monne , Wei Liu , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony Perard , Andrew Cooper References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-4-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0138.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8285:EE_ X-MS-Office365-Filtering-Correlation-Id: a717398c-f985-4c05-b8e0-08dac7acd164 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yapd4lU6IRVbgK41rUqYa3XYDv/PHZUi2OacKTgRxEDVcUurBVnAs3JboF6tLPyzEGkrpMLkz9NiDdSgc0zPxtm5+3STapy1yxglh6SscoEwpouaS+qo0PI8cvKcSjjHBigFsnchUseg+6BiheLCEgTV6nIuUccXr+OTl0MXjgbV3XfLzEnJpkzkDWondpEVgtbryV9W0aqioop/RtxXkd4+UOF9ie0QgqUFW2VhgdnTBMzJ4mphNqVIAaGk2L5IBTaNpQnAY5MfqM/wPgGtN/BpMSnL0swM3D6+s+BOs86vpzkI86HJJJFhvZb5Iben7zFlQi3k14M1kf6eKMJxAmqKTJvVgxq+riQY0DKqCCNiuzdxN8lO2L+d9dIW0ocOnPMG1P7hhexJJCFuL6ZyIKB3nEYAF40UVo2b4FGYaj06ugHyWMUoXyw4bGJFOzkIOIFaaPJKxSl3+pOvD7O1vymgPk1WhPT2AtM32YABbMYaIO5Bd48CzAk1UWRwkuLiuIOAbLPyr0YW4cnn9ZetK9PV6OQj+s5XE4TRAbRXH/HtWNYm378lzcx2ehG68Cx8ivZcmTkXSZywNneOIpXSF3wVn4HFVvrtzYDVfRWuOI0Q+U7hIJeK+c4jv6e5j+E1u6RnY6Bk5NWZ19zDghS09fl74Ur/i5MsjtGq0OJOj/SIhyqH9Vh+rYewf7WxB5rRn9WMyXuG/hWBQ02LXT4WnwrEXzCBZQUtMjtgR0dqXySHi8gseWWjT/weGSZT+TexQnK9KCDEkX8RjuBcpGEJq65E2OQ1Ln4BbwDPgZJqzmc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(346002)(376002)(136003)(39860400002)(451199015)(2906002)(6486002)(66899015)(31686004)(8936002)(7416002)(36756003)(5660300002)(86362001)(8676002)(4326008)(66556008)(66946007)(66476007)(38100700002)(316002)(6916009)(54906003)(31696002)(478600001)(83380400001)(2616005)(41300700001)(186003)(6512007)(53546011)(6506007)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlhxT1g2SklWamNCTUVWeDN1ZUFTSlpiWFdQVHIxR2hFQ0FnM0FhbVBHclg0?= =?utf-8?B?Rit6NG5qNk9UWkszeVlxaFlWZ1RNRlpFSXd4WDViNmNOczZZdXdCd0dYWUdX?= =?utf-8?B?RHB5UkEyTHpYWEdNTkQwemtrcndyaWNEQkVrZFA3dDZuYVViQnpOUmtFeUtB?= =?utf-8?B?QXd4TXc5U3pITzVXdDhqWEI5SFZmKzc4Y0ZCSWIwb0ZrWDFjRFdlUzJ1Ynpu?= =?utf-8?B?U2EvNkMrdlRmekFsYjg5M2ptM2c1Z0xoUzVYUFY4ZXJ0M1RBcVovb0hjTUF4?= =?utf-8?B?d0Z5M1hKZTNxU2VGUHltQnk2SWc0cjVGUkhQYmx0VHJDenc4UzNGZVVPVzZE?= =?utf-8?B?Q0tXbkFMTWlFR1VWd1hOSVhEQkVpM1VXcG5BVUFqT0h2YXJadHQ1N3ZuNFpm?= =?utf-8?B?MFZ5RnVZSUxNUVpQTnlSWllQNlIzR0lCbDBrNTJGUlB3N0hEOVQ2eEhpdE1U?= =?utf-8?B?N1A0NlpyY0lmL3Y2QXRDRElXVnI1bSs2NGxyQ3lUL3BiRUVWaWlGbWFaRU4z?= =?utf-8?B?bVk2cjN3cjlWSlVWdkNkblBwVlBrY2V0NE0wajhLcllNTmlHWDBIS1ZqK2c1?= =?utf-8?B?SmtFRU9ZaHRJdEcwNnkwekQ2TkJXVGZ3Rjl4UTZsYTJNWWY3cS8zcDJXYjc1?= =?utf-8?B?UFJ6OW9xcXFmRnQvZWMrMzZpcENNejBOOEIzWjdFdDJxbWxIOEFvQnpsVXVE?= =?utf-8?B?WnJkQmhLaWh0bFFocG5NTXNDNXg2UnV0TXNrcHJrWHZ1WWNibktraVp5ZEhp?= =?utf-8?B?QzRWSjBCVnl2dDJNNGNXOWp2TEFLRC9DTm8rdjZXNDlML25oY2hOcWJaSW5Q?= =?utf-8?B?UkZqNnV4ZUllR2NRa1FDYVNYOFZFZnY3TlJJcnhXUGZncDlJbDdwVFJZdXZZ?= =?utf-8?B?SkRkblcwek9ISW1CZVVqMlVzTDR5d21hY3VaN2lBMGZ5dGhaLzRSUU52NDJ5?= =?utf-8?B?c2FQUGRac2JDeXhNYWU5ZnZaODZIbTdtY0ZYV2ZKQ2RzRTFXSVljblZiRnh2?= =?utf-8?B?UFk5Y240SmlyS01qNnpvd01uT0xQSHJrL2pNMmNHZEVaSDV0eHNQRUg5aUxk?= =?utf-8?B?U25EZ0x0OWY4eE5OdmdETGVPbllHVXBOU1EvZ2FWNWhWMmFxRzh6cW03emVR?= =?utf-8?B?Y1BvOXJxS1hxZHByVFZodE93NnBzZWM4UzN2WThJd1hMdXdpNGxtdDFJZG0z?= =?utf-8?B?dmZ0eGx2UFRjYnVVcCtVVnVCNHpIYmRjbDAxVVdKand2YmRlOTVibXpQdkVD?= =?utf-8?B?M2YzWnVzTGM1Y0NJYkhFS01zdStUejFxNS9seWNnTHBPblQxTTR1MWNyNTVL?= =?utf-8?B?SkVsTW9sR1BsbjdlYW54d0FWNnlweTZBY1ZJcUNuVXdzQWJweDdXYVZQY0Zn?= =?utf-8?B?RlFONjlpS01pSkNqQTAwb2FSVS9QblRqa01DNHlSQm1BQU0vdkZsc0J4ZTlI?= =?utf-8?B?Y05vUUpoVHJZLzZRaXQwUGFqQTNOcCtONnduenBuSTd5MGU5RDJrZ05CZ2tE?= =?utf-8?B?MHgzR29HbWVJTVhPTGpDc3R4b3VESng4UG9ydG1HY0NoVWZBd1NOYzc3K2ll?= =?utf-8?B?UFpmNVZkU0xPc3JKYStlZkltdXVvMUVxU0ZPWVNBMS9mUkk3bjEyd1VMUi8w?= =?utf-8?B?N2lTSW1JSEVWVEQ4NldkVEF0S2tYSERPNWt2aU1rWWdnK1dEOGNTYWpuOXdQ?= =?utf-8?B?QnpuSFR2UXNEZmRwZXdUdTZMcVhKT0pNY2NCMVhnV3UyYnFGbDVHMU1BSGdR?= =?utf-8?B?aHZMUEVsUnJXTE0wREs2SVRSODN4dk5ZOHdVMC9ZeTVDZGVYeEVoUmplcGNH?= =?utf-8?B?dmdWeTFpdENDaktsbU94dUkraTRUdi9yUml4dlpTMEQ0NytpT0owS2lpKy9w?= =?utf-8?B?NzJtbVAxWXJkaFFyR0x3cTdDeUpscER5RGdPMXdsSXkxazFkc1k5Mmp1c0ZN?= =?utf-8?B?ZHVoeStJWFlqaDB3T1RBanNUUk92VkYzWWwzV3orRWVLSUlBbjNCT2g3cUd0?= =?utf-8?B?dWUrVDQ4VnZEbGJ2c1pDQytaQ1ZlTjF6cnliVS95OGw1Mk9xNTVxZnNYODFJ?= =?utf-8?B?NHdpTitkaDF2Njl3OUdMVENxOFdCbTVXaDdoQlY3UEFEeW4zUHZFOTAzZFEr?= =?utf-8?Q?Ngkpu4Q71mdJTdR238Y8w/9sW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a717398c-f985-4c05-b8e0-08dac7acd164 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 08:30:28.8625 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0BXNhuJeG3GmEweJZXtXWsfiTzg2r6mmnHt7p0X0JTuJa1q0wuGiUmzH6tG47j17U4n7vBEL6I8LkYCoZdVgKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8285 On 16.11.2022 03:00, Stefano Stabellini wrote: > On Wed, 16 Nov 2022, Andrew Cooper wrote: >> On 16/11/2022 01:37, Stefano Stabellini wrote: >>> On Wed, 26 Oct 2022, Andrew Cooper wrote: >>>> This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits >>>> of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. >>>> >>>> First of all, with ARM borrowing x86's implementation, the logic to set the >>>> pool size should have been common, not duplicated. Introduce >>>> libxl__domain_set_p2m_pool_size() as a shared implementation, and use it from >>>> the ARM and x86 paths. It is left as an exercise to the reader to judge how >>>> libxl/xl can reasonably function without the ability to query the pool size... >>>> >>>> Remove ARM's p2m_domctl() infrastructure now the functioanlity has been >>>> replaced with a working and unit tested interface. >>>> >>>> This is part of XSA-409 / CVE-2022-33747. >>> Genuine question: I can see this patch removes the implementation of >>> XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION on ARM. It also switches libxl (both >>> ARM and x86) to the new hypercall. >>> >>> Why keep the old hypercall (XEN_DOMCTL_shadow_op and >>> XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION) implementation on x86 (not on ARM)? >>> >>> Is that because it was only recently implemented? And not actually >>> present in any past Xen release? >>> >>> If so, please add a note about this in the commit message. Also, if that >>> is the case, I think this patch series should go in 4.17. If it is too >>> late to get it in before the release, then we should backport it to 4.17 >>> as soon as possible. That's because ideally we want to keep the >>> hypercall interface changes down to a minimum. >> >> On ARM, the hypercall has existed for a little over 4 weeks, and isn't >> in any released version of Xen (yet). >> >> On x86, the hypercall has existed for more than a decade, and has known >> out-of-tree users.  It needs to be deprecated properly, which in this >> case means "phased out in the 4.18 cycle once known callers have been >> adapted to the new hypercall". > > Understoon. Then I am in favor of getting all 4 patches in 4.17, either > before the release or via backports. Removing something from the domctl interface generally requires bumping the interface version, so some extra care may need applying if such an interface change was to be backported to any stable branch. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 16 08:54:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 08:54:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444232.699212 (Exim 4.92) (envelope-from ) id 1ovEBp-0008FO-JA; Wed, 16 Nov 2022 08:54:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444232.699212; Wed, 16 Nov 2022 08:54:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovEBp-0008FH-GU; Wed, 16 Nov 2022 08:54:37 +0000 Received: by outflank-mailman (input) for mailman id 444232; Wed, 16 Nov 2022 08:54:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovEBo-0008FB-37 for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 08:54:36 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2060d.outbound.protection.outlook.com [2a01:111:f400:fe5a::60d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 49d47e8b-658c-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 09:54:34 +0100 (CET) Received: from MW4PR03CA0191.namprd03.prod.outlook.com (2603:10b6:303:b8::16) by CH0PR12MB5300.namprd12.prod.outlook.com (2603:10b6:610:d7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 08:54:30 +0000 Received: from CO1NAM11FT034.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b8:cafe::ac) by MW4PR03CA0191.outlook.office365.com (2603:10b6:303:b8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Wed, 16 Nov 2022 08:54:30 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT034.mail.protection.outlook.com (10.13.174.248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 08:54:28 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 16 Nov 2022 02:54:26 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 16 Nov 2022 02:54:26 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 16 Nov 2022 02:54:25 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49d47e8b-658c-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MDcRJm6cFB/bZEV1nyqTTQndPkAb09INwNsSElhv8KNAMsmLwMMP48oNPGtbIiAv6/ROQL40mEaRVh5LwMjb/AGrp4jXn6z/gEZ7A3EioT9xemBjnAL3uBwylar+CaSAdCOl1S1HJG8ZKDgv3Lryu7zEId44FvF9qa5kv4+n7rEyYkEFdnIpsNLyY8oRj2Mfyxq6bBSWj+3TS6jnddiNzVbHz3Mq0nfP78bpd8TRwwRMKqRHRb/uQZ3e9w5M3va1BMbt9y38MXt7WJLC/C5/FhuW1TkrEvrF6CHOYTjFG9nVDa+4a4ojLvr2+gQCO73e8U/7oj5fr44qWOe7dimnDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ONISQ8ezoJflHfDnx3dfBWiAhcXDYNCcsPRLwe3lQM4=; b=jEz/MLGd5F3OaPueM9yLzUxb2vSASBTVU+juMkALnKwhTzAHtNcc54LPtcjtW+tnMUl5ySjWcY7d0mU/NPYnhu5q4vj0AcXNpVbgL3lHuH+Mhg+BUwMO0vmOEM44kKeDf28pkQbWvE3wCFq/tz4jq5+WzZcnS1aG+HhQ42fjjN7H7DWAgULb2h+VGy+7VKymAA7YSJT0HpgxrBwlSew1vVJwqhVF4NMFwdfwsB3Lf3Aoj/VTbjWxvkXItIuW448zam5rBFhZUSKWO55AEKVLOHueq8d0jOxJJywLxsCBpsATSFms19Ri13kLm9VCH3/l1YZoffMzCgl3r6x9HZdtCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ONISQ8ezoJflHfDnx3dfBWiAhcXDYNCcsPRLwe3lQM4=; b=WkglTATLoui1dzn5yH4oQ+bZTjtuzsf0KASkpZzz5LsRynU8D21JZTmIVEGteJ0hr9HQB8f9r9UJtKTTWQrdbYtsI9g22pAnCv3tomAjprs9fxgyXkBaIkSJ83fmv9O5ku4bc8sBQpKSzsnY79iWlve0JtNW1gZpF/VSCXTHVlE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: , Michal Orzel Subject: [ImageBuilder] Do not set #xen,static-mem-{address/size}-cells Date: Wed, 16 Nov 2022 09:54:17 +0100 Message-ID: <20221116085417.3159-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT034:EE_|CH0PR12MB5300:EE_ X-MS-Office365-Filtering-Correlation-Id: 321ecb25-cfcd-4f76-af51-08dac7b02bef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NyBMIBIdyNHCKka7jzIThKTfFRDKeDLXwZcbYViQZ5PmEGN0dwfKe+1/KfqCAfy3ErYBzl6kFNIe6nZdRn35aMYJx2Pas9uCA93nF29csVJ4sS4zX9Xp8+c0Y9Kpo1XTwW3F9PfQeG/bECBGp3wPwPGN1IMvFA4SGJVfwdaWR00RZpMOp/+JZAykn38aJ0KcECkKUUALqxLZ++HU+3urYOb6FzYOyGYLHkk8jUdovsAmhdsVONFTD1ZW+kQOjZj11affg2d0LB+wq+pItaYgXfMvfGMBvTLFSkHuO5zPYaRpTjU+rSS1ssEkvWJeQ6Yu3hoJil3TjNYUUzWJOP0FQ/DLnMGwwizHn5V6Fsw0zzYyOhSDy3hPmUNqHB2Oml8N7grP0iOks2k+XacymeUrwHEK6kkkhsZ8MFysyoW7efoTFKUWjehT+URGZBXJKuwxOwPEq1JZPMuE4MHkRQKc/EUPJw36Semi59manIos9EBtplrwWNhL146gnLOonxP1IYWcIy0LDX/r23HkGrdJtEyOyPbkMmja0EQdM6ecrVvhRBBLIKN/qxyawjxWtwxSio9/NpOzav3iCoO3M0S5ReKmj1cjvTZ0nkvAjucj4MO+XiBIOPnyzF6x7v++NXjhX4TLTiRVg45ZgN9inZdbBL+b7aQP/gMVfBxtciYIKmKZ1o4XNU1ZYipetfy3Ii64LqujNe5dwG7cI5ZwffP9/LJbzZNGeHPjsCyl0G5zSHdD4E5ruxWXjijemvXYJR+AHNy14Pv7cOVd+9bXAsBU8DDqyRok0iX3vs8G48QinMo= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199015)(36840700001)(46966006)(40470700004)(82740400003)(36860700001)(82310400005)(356005)(81166007)(86362001)(6666004)(40480700001)(5660300002)(478600001)(8936002)(316002)(4326008)(8676002)(41300700001)(70206006)(54906003)(6916009)(70586007)(47076005)(426003)(336012)(2616005)(83380400001)(186003)(2906002)(40460700003)(44832011)(1076003)(26005)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 08:54:28.9927 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 321ecb25-cfcd-4f76-af51-08dac7b02bef X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT034.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5300 Xen commit 942ac5fc15ec ("xen/arm, device-tree: Make static-mem use #{address,size}-cells") dropped these custom properties in favor of reusing regular #{address/size}-cells from the chosen node for the xen,static-mem property. Reflect this change in ImageBuilder. Signed-off-by: Michal Orzel --- The master branch of ImageBuilder should reflect the current status of Xen. Apart from that, we might want to come up with some versioning system in ImageBuilder, because commits like this one are breaking the backwards compatibility. --- scripts/uboot-script-gen | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen index 0ef89b680348..7e5cc080407e 100755 --- a/scripts/uboot-script-gen +++ b/scripts/uboot-script-gen @@ -181,9 +181,6 @@ function add_device_tree_static_mem() local cells=() local val - dt_set "$path" "#xen,static-mem-address-cells" "hex" "0x2" - dt_set "$path" "#xen,static-mem-size-cells" "hex" "0x2" - for val in ${regions[@]} do cells+=("$(printf "0x%x 0x%x" $(($val >> 32)) $(($val & ((1 << 32) - 1))))") -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 16 09:21:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 09:21:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444237.699224 (Exim 4.92) (envelope-from ) id 1ovEbc-0003mu-Np; Wed, 16 Nov 2022 09:21:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444237.699224; Wed, 16 Nov 2022 09:21:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovEbc-0003mn-KN; Wed, 16 Nov 2022 09:21:16 +0000 Received: by outflank-mailman (input) for mailman id 444237; Wed, 16 Nov 2022 09:21:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovEba-0003mg-Do for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 09:21:14 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20624.outbound.protection.outlook.com [2a01:111:f400:7e89::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 027bcebd-6590-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 10:21:11 +0100 (CET) Received: from BN9PR03CA0191.namprd03.prod.outlook.com (2603:10b6:408:f9::16) by DM4PR12MB5182.namprd12.prod.outlook.com (2603:10b6:5:395::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Wed, 16 Nov 2022 09:21:07 +0000 Received: from BN8NAM11FT112.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f9:cafe::ed) by BN9PR03CA0191.outlook.office365.com (2603:10b6:408:f9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Wed, 16 Nov 2022 09:21:07 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT112.mail.protection.outlook.com (10.13.176.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 09:21:06 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 16 Nov 2022 03:21:05 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 16 Nov 2022 03:20:42 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 16 Nov 2022 03:20:41 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 027bcebd-6590-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mTNkVwe4HgFYv3qipJJbk6BUjQOXudIDzI0uaf1Pcpu6nORoQnVfuHLNsEGpL01Xp52uC/Udx76CnSijSm/ou39ce3PG4xb10SqYQg36raGy2VDVgDatTDHlNqNlH6sVxPvKoQZlihScPqPvOoQyf4nrJ8Qer8JSU0Vob0MfNNih1LHuIqPAfxov4Y0lgzdujeeRTe5+pkAI3j9z3qWbnYQJQpchiJoXol2PSNcCjVkdp9q1OWlDF+0eaSsyxFaPnUP8E3VSpdy7nL5eA0+Tl2jwz+MRIhiEcbx+ECCZK+Je7DsBSBDyndor7mhhMqsQ58A7V2bROn+t8NsdGEaB2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yOwDmJvCjiDYiJNfQiLc7IvHjVQ6McFOol/qyIJ4h+E=; b=MG0Eoq7nLamc19thMXIh64YoVrnqMNhRw1rc6Q5Vzc/9VBYdKTSoKXjTWpBfdQJMa7+TVOmjdtIyHIqEaGH7UZW/Eiyw7BkRMmTt9gdCrv/aIrzISbmUyFlOIPH1uMMJf7P4y5g32V+6flb5h3Hci8/jdceagY0M8vqMdA4p9gjKiqDy4BcMKXiuDlwxJpPstV6W5HRy75ECgpiDiQBl24vxhKgefYWQf4Gq96GOEDWXMyCJwLstjuimyfnqq9GBAPebR3vTkSu3Tda5Ps6YMdBeZMNw2DtvfuWIKxPRzrK3/ZQCW+B82SKqRfUqi5dFFPDqSpCPTW8rS6YKvcc3oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yOwDmJvCjiDYiJNfQiLc7IvHjVQ6McFOol/qyIJ4h+E=; b=n+CgrxODPapRFWCjoRJ+w0I5i7F2h1J96T2OTqglQ7VIG5CDRWhtajpJOcqWIPnvGHtRvGW8BrFBcu8Xz25wfwDJ+1pAu0GqzCzCd69bozMtnClHtmOkuY1fTm0SdWFbowLIPq5bWhdoqOgnUap2tpsPbzz6v3D+HTO578jjOrM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu Subject: [RFC] docs/misra: List files in Xen originated from external sources Date: Wed, 16 Nov 2022 10:20:32 +0100 Message-ID: <20221116092032.4423-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT112:EE_|DM4PR12MB5182:EE_ X-MS-Office365-Filtering-Correlation-Id: 791fbbbe-3b95-4860-600e-08dac7b3e451 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XnwL4otAVl3iNQUP/tyNSsn18JWLuHzs8fbp4msHFN33k3ag40lESmIh6TiG+/ZMPyPG1k4RYcnseOZ7SYaHVZrUnubLJ2vexMZ7UWLNd3/2HpSryqxsgL3uP6vOdyP2Rfn/gYRGUGUWH6ksWf6Pze1IhbeBb/f1GE2tqoDYks8wsh/P9MEv/azW7jYvABEmjSviR61RGSYB/JgG9tKBtTgGSvwS9cTDk/mHGMo0pdPXzcnOGmYffT/ci2DeYK/VF+SXBU3PbtxPWKI/tTKRS02Bk8IXS8MSBnYWfSqNV+aZn1MScJvlsr/SGPUyi4qB68CUz+CvlbbuVqWmqV35gBkzdS2Be5W2vfrsNSDrnRUMVvBhKCPy/P/F8XNZpfym4h5RK6/Te+ivUT/6XeWgB7a10JDIuwHC4hulSWAjzvycBwAjnc9exG+HyfZH/+QIXhqkAzzEeDE7faMoYhle9AZ3JphcBe8zOw2gV6EuROM8U/P/MO7/E/9PptjzaZ8/t0BIDZ1uxO9+UsTI8dZHVGrwTODWIAXaXm6RgdyGL8tPy47Cnvy+5r4AoMUiZhUoL8JQbo3VYeXvnLks8+lr10sHDadbQmzb00VibSDA/bwjES7hUQgzufBzlYzIaU0cvWIU3SOd19mhtX0G734XosyoqaMT0WS0FsHa0o/PYoRZP2iFc07pxLEPt1I6506/v7W5WLx2/ym7gbEFnOWt4sYARGzx7yM3AFC70VP5gldpWw7M2bMOnZiHSCXTEEBLU5h8EkBpkcgNJ/aQwAQm8gLX+/BtALc/41ioHaQFiQq0VRqyjkB604ZCLb5D9yTWRejR3u5Tkox3NjuIUTtBiQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(346002)(396003)(451199015)(46966006)(36840700001)(40470700004)(83380400001)(36860700001)(2906002)(36756003)(40460700003)(41300700001)(70206006)(8676002)(2616005)(40480700001)(82310400005)(70586007)(86362001)(82740400003)(54906003)(6916009)(356005)(81166007)(186003)(5660300002)(1076003)(336012)(44832011)(47076005)(426003)(4326008)(966005)(26005)(8936002)(316002)(6666004)(478600001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 09:21:06.9645 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 791fbbbe-3b95-4860-600e-08dac7b3e451 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT112.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5182 Add a file with a table listing files in the Xen codebase that originated from external sources (e.g. Linux kernel). This is done in order to improve traceability, help with the review process and act as a base for listing files to exclude from MISRA checkers. Signed-off-by: Michal Orzel --- Some time ago, together with Stefano, we shared a spreadsheet [1] to gather a feedback about external files in Xen. This RFC patch is moving this discussion to the mailing list to gather some more comments. The main request for the maintainers is to check if there are any files missing, check for the correctness of the already populated entries and decide what to do with the entries with a question mark. [1] https://cryptpad.fr/sheet/#/2/sheet/edit/G5WWo5TI71n58OLEG9TCu95j/ --- docs/misra/external-files.txt | 70 +++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 docs/misra/external-files.txt diff --git a/docs/misra/external-files.txt b/docs/misra/external-files.txt new file mode 100644 index 000000000000..69ff233da456 --- /dev/null +++ b/docs/misra/external-files.txt @@ -0,0 +1,70 @@ +External files in Xen +===================== + +The following table lists files present in the Xen codebase that originated +from external sources e.g. Linux kernel. The purpose of this table is to: + - keep track of the external files in the Xen codebase, + - help with the review process (e.g. changes done to the files that did not + diverge, shall be first submitted to the external projects and then + backported to Xen), + - act as a base for listing files to exclude from MISRA checkers. + +NOTES: +1) The files shall be listed in alphabetical order. +2) The origin of the files derived from the projects other than Linux, shall + be specified within the () placed next to the path. +3) The table shall be updated when importing new files from external projects. +4) At the moment, only the source files are listed in the table. + +| Relative path to xen/ | Diverged from | Subject to | +| | origin? [Y/N] | backports? [Y/N] | ++-------------------------------------------+---------------+------------------+ +| arch/arm/arm64/cpufeature.c | N | Y | +| arch/arm/arm64/insn.c | N | Y | +| arch/arm/arm64/lib/find_next_bit.c | N | Y | +| arch/x86/acpi/boot.c | Y | ? | +| arch/x86/acpi/lib.c | ? | ? | +| arch/x86/cpu/mcheck/mce-apei.c | N | Y | +| arch/x86/cpu/mcheck/non-fatal.c | ? | Y | +| arch/x86/cpu/mtrr/* | Y | N | +| arch/x86/cpu/amd.c | Y | N | +| arch/x86/cpu/centaur.c | Y | N | +| arch/x86/cpu/common.c | Y | N | +| arch/x86/cpu/hygon.c | Y | N | +| arch/x86/cpu/intel_cacheinfo.c | Y | Y | +| arch/x86/cpu/intel.c | Y | N | +| arch/x86/cpu/mwait-idle.c | Y | Y | +| arch/x86/genapic/* | Y | N | +| arch/x86/x86_64/mmconf-fam10h.c | N | Y | +| arch/x86/dmi_scan.c | Y | ? | +| arch/x86/mpparse.c | Y | ? | +| arch/x86/srat.c | Y | N | +| common/libfdt/* (libfdt) | N | Y | +| common/lz4/decompress.c | N | Y | +| common/ubsan/ubsan.c | Y | Y | +| common/xz/* | N | Y | +| common/zstd/* | N | Y | +| common/bitmap.c | N | Y | +| common/bunzip2.c | N | Y | +| common/earlycpio.c | N | Y | +| common/inflate.c | N | Y | +| common/radix-tree.c | N | Y | +| common/un*.c | N | Y | +| crypto/rijndael.c (OpenBSD) | N | Y | +| crypto/vmac.c (public domain) | N | Y | +| drivers/acpi/apei/* | N | Y | +| drivers/acpi/tables/* | N | Y | +| drivers/acpi/utilities/* | N | Y | +| drivers/acpi/hwregs.c | N | Y | +| drivers/acpi/numa.c | ? | Y | +| drivers/acpi/osl.c | Y | Y | +| drivers/acpi/reboot.c | N | Y | +| drivers/acpi/tables.c | ? | Y | +| drivers/passthrough/arm/smmu.c | Y | N | +| drivers/passthrough/arm/smmu-v3.c | Y | N | +| lib/list-sort.c | N | Y | +| lib/mem*.c | N | Y | +| lib/rbtree.c | N | Y | +| lib/str*.c | N | Y | +| lib/xxhash32.c | N | Y | +| lib/xxhash64.c | N | Y | -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 16 09:54:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 09:54:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444242.699235 (Exim 4.92) (envelope-from ) id 1ovF7M-0007qi-Cy; Wed, 16 Nov 2022 09:54:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444242.699235; Wed, 16 Nov 2022 09:54:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovF7M-0007qb-9H; Wed, 16 Nov 2022 09:54:04 +0000 Received: by outflank-mailman (input) for mailman id 444242; Wed, 16 Nov 2022 09:54:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovF7L-0007qV-Ct for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 09:54:03 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 97742e07-6594-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 10:54:01 +0100 (CET) Received: from mail-bn8nam12lp2174.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Nov 2022 04:53:56 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by CO3PR03MB6759.namprd03.prod.outlook.com (2603:10b6:303:179::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 09:53:52 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Wed, 16 Nov 2022 09:53:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97742e07-6594-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668592441; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=XYWPmw1RL4CgnVWmb7qGvK1guTZhy/u0zr6RLiVdNeE=; b=YAEw2sOIA1aT++OnkIzi6TSaL1ToKUgOQYb66s6Rv8oUS4+lKb8rHwBV DhbkRBQcghx69LL7SBhi7FGaQAxcz/cnsSxUbDsi/cUBqgUX7f19duCch BrCJkvGucmqGbDJLoczghpMvKjIxhmFpJlif+sFPxGmsjk9TH3u2XEcw/ M=; X-IronPort-RemoteIP: 104.47.55.174 X-IronPort-MID: 84946636 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:rKFgu6y9H0n1MMxD5356t+fsxyrEfRIJ4+MujC+fZmUNrF6WrkUBx zRLWD+PPquCMTOme9EkbYW0pE4BsZbRzIJhSwVl/iAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPK4T5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KU0V+ c4HBXMsVwG8tsSZ75eZF8hQu8t2eaEHPKtH0p1h5RfwKK98BLrlE+DN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjWVlVMtuFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE1rOewX2lA9x6+LuQ8dItkXOr1DcpEUdIDXyBu6SbmBCjVIcKQ 6AT0m90xUQoz2S7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZh5MbsY38vA/QzMC3 0WM2djuAFRHsreYVHac/be8ti6pNG4eKmpqTS0ZSQoI5fHzrYd1iQjAJv54C7K8hNDxHTD2w hiJoTI4irFVitQEv42k+XjXjjTqoYLGJjPZ/S3SV2Ohqwl/NIisYtXy7UCBtKkcaoGEUlOGo X4I3dCE6/wDBo2MkyrLR/gRGLau5LCONzi0bUNTIqTNPg+FoxaLFb28KhkkTKu1Gq7ooQPUX XI= IronPort-HdrOrdr: A9a23:RDkJF6k8f1yvpIkErReT1oaXVdTpDfI33DAbv31ZSRFFG/FwWf rPoB1773LJYVMqMk3I9urwWpVoLUmzyXcX2+Us1MmZLWrbUQKTRekI0WKI+VLd8kPFl9Jg6Q == X-IronPort-AV: E=Sophos;i="5.96,167,1665460800"; d="scan'208";a="84946636" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ReoFBBtCN2r44imbOccYO9cSQIBY8HAZSCtfuUNiEr/XoI+Zzxd7M6xr87NPDioeJOsXWx1ECaJAIx4GuUlBm6vFNfDEdvoQ33ipIFebFq58+bSoyKt+xN9HhVNdZYsBAgIEEHCQxJLsLTJxqiGBlGXRtbmm7TyvTBVxF9fKtoasZHxoXXLqWrsMuIwedVHJ3v8sK7C9+jtfbaPVI9uOnVci7IBsCH7auPAQ2oTUUgNhKJgpe6wRSFW2qRWedVPyqAaIp2QQYoWqFmMIJxAiFZrD+cuGbUgmpbgkllmLuPpKqXr/8q/58N+Ai+2oSe5SpJpV11hrjnDEHC3zvPQVQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p7xp8/z9qJ1911Wz8xxNNdV/aliKN4iBFIKwbEU197w=; b=J/Du+snAwg2SQpGTbc/B16Pb5aZdsL68kpPIy9qxRwYm/R54qhUpQ3Qu6Pm8U0g7A8bv4WyCPQSKBTy1S2PmF25GEONgMpP17YLOtccwV/jHjRELJcPfENKNEezT2dVEiJfeltqnropnoOG+ApU8adfMa5cBy9vb9Jae8UDba3JM0LNNEviUZ+X0WBNnRDddMqXPzlAN/7wUp7Bdj5QTaNOiZUiKQFnCkRJBq0finr33Q+hJg+1NYTELd4lVnO17QaVjrK4g5Xd0H3ZfcFFk4tZdjZ3DzWL/vH2jFBFu9l/3a9fHe7Y3ucG+9MUfaLn3wLtkWUXgJQo1f4WikNWYtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p7xp8/z9qJ1911Wz8xxNNdV/aliKN4iBFIKwbEU197w=; b=FwWub7AuFTUXUCMnKoHU+jbi2mugJ47LWBajS0tV2bV5oUeQ921gKc8KfjURNk5ZBIesUydBn/bIoTwz11Cgfh5TdqGB+TPvN5r3k3jSVADJfpLBxW3cgS6h2eh5xor1NztEEmPWcl4WqcdQPcsi4RuSBgImMtC9j2iCUzg+MkQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 16 Nov 2022 10:53:44 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , "Henry.Wang@arm.com" , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH for-4.17 v4 0/2] amd/virt_ssbd: refactoring and fixes Message-ID: References: <20221115132657.97864-1-roger.pau@citrix.com> <463e03d5-7a07-f26a-de24-13c4a12e8c20@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <463e03d5-7a07-f26a-de24-13c4a12e8c20@citrix.com> X-ClientProxiedBy: LO4P265CA0079.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::12) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|CO3PR03MB6759:EE_ X-MS-Office365-Filtering-Correlation-Id: 7698159e-501e-4918-4656-08dac7b87694 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kMhXh82NGvyx3cRaOQi4ezYwH0ptN0OlD7na2Jk7pLfXrbA4bDCfVxhl07cTwt3w2HixMchCMeSRXZxK+/glizyTZmbuTfDEmTsWGJTYjrlmCqLcOIpVcFmdNT1klJM5gTifZwz1lCdnLBVZxyZDuf/1y3Jj/wIqrF9QlE+yvF+q1jBuxrdqFUJv/WnCBjcPQKc6TEeiIVhMJe5IbIuZMLWqGEkuQfMZoTz2BuQ/lV82UdC3Sb+eX0ChayTok0UnE18553oyqRJcQaWBo+pp8Ifyh+VxJvONfSa60yYPw+EYV6UuysuxfJ5Yn1iA/dQp9bUXlWSdGInQ8a7I2UmnGHinCFezBfSLi1qK2ElU88rbzFCOUDVuyVocUALYYxdq4i0sBcDVvF3yDeDt08z3w1iltXCTddTtYvF6BtFQupdYIFNQUj1tV+aTNGSKTgo1m3B02oGNozs2vGozinpBGQARz2uUZAJbIYA/BRvS135wD+zZ0XQ+rL+nE98LT79BuJL3uP8IO4Th1U0oNnimijWL12ymUPZXY/01xeoxao+6onAhhpgnBlSm/ysh4TrO7bs59XAmdq15kB676Ehqk/fG7a6xe/0T3mouo71whdhL8Th9WDdKjO3iaSEPN1YHFdPHohuLrIYRPUwWDn8cyw4Hf1Mw9s2HCl3Lm9hN7CfUs638jfOpl+l85YtCD3v5bsyQpy0jbsHbVTxNU8xh0w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(366004)(39860400002)(396003)(376002)(136003)(346002)(451199015)(9686003)(6512007)(82960400001)(86362001)(38100700002)(66946007)(66556008)(8676002)(4326008)(26005)(41300700001)(2906002)(186003)(478600001)(5660300002)(83380400001)(85182001)(6862004)(6486002)(8936002)(33716001)(6666004)(66476007)(66899015)(54906003)(6636002)(316002)(6506007)(53546011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGlyckUyMWFnUGhubHNwQk5samVDbEd2M3J5dy96SjRXMXdCL1FFR1J6dUV5?= =?utf-8?B?a2dMQjZUbzhTVE5hK3Q5c3FENEw5b3NXZHoxY0pWdU9QL2hhZVdYMk5UaFMx?= =?utf-8?B?NVR5QXBMNFg5cXJTbHpiZ3duV1M0ZUc0L0hMQlFwNUwrdmNDNlhJUUVObG5U?= =?utf-8?B?ZExtTnJFTDYwcm1CYm9US3FzMTB5RGl3ZXV0M3E1NjRJbHVORXhvL3Zla1di?= =?utf-8?B?VnowaVVjQjlsb2FpSVdTOXg3clBjVzBHUXJhNmVyK0JuSkU2WUIrTkR6VGFm?= =?utf-8?B?ZjVweWFsbEJJcFdzaGpUbXBpUmZDb054TTZEZmdKMk4ydkltSTdBM0hGSndQ?= =?utf-8?B?NDhhRVJNZU5CUTNHU1lXZUs1aEZvamRJdnJReHhvdE9IRjVOTlhMOFNkVS9P?= =?utf-8?B?d0x4VjZPYktyQXNKTjdiQXF0bUpLWk53YUZlaDZibUt1V1NubFZiVFJ6cjJa?= =?utf-8?B?eWpUY2FHeWhPV3hIOXM5b2g2M0J3QXFvYkRhNDE2ZzFXZExTODhkbVR3eVJT?= =?utf-8?B?clM4SHZ0RGcyTnpuOW80b0RTRFpGTlQxRVRPYXg0NEw3MlpBcG1rcTlEMWM5?= =?utf-8?B?cHFOMjgrY2o2V3dGUkk5OGVlRitXbkpoSnFrejhKdTNkS2RjOHNjMEFmNnJK?= =?utf-8?B?SGpaaWYxZEcrMmV1a2FLd0hjdkdTanV6NWhDM01yd0VsOXdxT0E1TGVmUW43?= =?utf-8?B?RzQ1aG5nYlZIQkMweXBFcjROUkUzbmtKRklndHcrZzUyOTNxMTBTV3Y4VUQr?= =?utf-8?B?WnRuZFFYTTJrSU1EdzI2RGh6V3pSelpEdkVOWUlaalNPR3VzdlVkZDA2TjRQ?= =?utf-8?B?Rmx6cUxjUzJhK1hFeWJzRys3N1czaUh5ajR6N1pqSHNBZklBbnA2SWxhUlhh?= =?utf-8?B?YVNacUlQUE1qbDlFekRybWhVTXFHVi9LTU56d3JqdjhmRWtXZ09RU2JDN1RN?= =?utf-8?B?Sk5GNmhYVFNZMWw0VTdDR1Y2NkEvYk1PRlZpdjRaS1AyMGRuNk5kTDdOdjZ6?= =?utf-8?B?Q2tQb0J2OFUrd3VEZkFMaVY1SEtKeVNadWoyY0IxUXB0TDhjQWxwTHdVSTg5?= =?utf-8?B?WklwRGVBamFZaFJlbkJ3a1RoU2FrNnhiR09HdlhwcHVIWXd5QlJaWEs1d2Vk?= =?utf-8?B?d2NzZmJYZSs4Vk1OZ0Z1TElERHd0Q05ubnAreURuRkgvM3dCTlZweHdDTGxL?= =?utf-8?B?QzdSNmlWWHBiK01iMm80VUJyRW5HRkh4dVlkMldSWGRTekRJeEJ4M0tsVGt6?= =?utf-8?B?SjlzT05tVU1DSGxzYlI5VGFsOWZ4NHpjaUdZeEhKYmN0RStIUjh2TEltV2pi?= =?utf-8?B?alBDUnZnNkdNQ3lLZ2tYc1BSYkdod3MrQ3Y1TVZ1S1VzYUtKZXJuaGxjS1NW?= =?utf-8?B?RDNUUUZNWUhQME96VXFYUmtJUlYyUHcvWmp1TCtGcWNsUlY0VWt1L0ZINXMv?= =?utf-8?B?QXloQnZDZXVJZkJNMGg3akFCbjBDS1doSjc1M21QenVHVTAxd1JkMndVSWFk?= =?utf-8?B?RGYyeHBGRmF5ZWgwWWkyVERoM2N1MTFsMlltdTJrTGFZZExLUGVXVEhKNWkw?= =?utf-8?B?TERqNWxYbW1VUVRkS1dhQ2lKSG9CSXZMMEJ1MlRwdzlIS1U5UWh5S283TE5N?= =?utf-8?B?S0w1cWJsTVA1RE5FSTJOVDRDYmpZQnNiQWNySnN1WXUxSXByZjhXbHhFY1M1?= =?utf-8?B?cmtEdWQ5UzlMSWdZZHdDUm1JOGlIbVVydlpOTXpYd3JPcVRmR3VoWjFBM21E?= =?utf-8?B?MU92amNKVjFLeVFyZXFpUFkxZGZ4eldkaFkveXRKZTV2cnNrUnJ3VS80RFFX?= =?utf-8?B?dHFuQ0pmQXFIQ0g0bzJpMTB6ZEM3eWdDV3NEVSs0U2RQT0gvaU5HL0hBeFJQ?= =?utf-8?B?R1dSMW5vdzc3c09BVnhoVUlUSzRMK1hsb3pobnc0djV0NzhlaXdyY2hGWHRu?= =?utf-8?B?YTl4cFJlWEhiUURabHNjWHlpMHlqYUFxNU5abE9PWkZ6NXZ4Y3hFNkI2SXc3?= =?utf-8?B?Szl3VXJlNVkxSm03M1FqMXNsSlY1TktpUitFSDFnV3NhSW5FblQ0ei80TGtC?= =?utf-8?B?YXc1LzRiWTNvSi9ka3I3MW82cm5Fdy9Qa0dDVXNHUVNjcGtLdFZPeHVlVGZp?= =?utf-8?Q?1YTla3IWmVU940U8h2BoZcrfs?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: tK1j9UP+RCmHZgF0nGGTInlr+XgsEYYCJRATiHJkxyu0C0Zzn/op87jDLI1ay6gDqlc5UICtRZEcfNAKpBZ7uuvKCE2kwWDV9jTc/ftSwVPKDEMZd9pHw/BaGH9RdcCfayWuV3pWG4tXf/wNgEqTIluSo/mS7SyRu28o64phlkhLOETQEgCwID7E+mpatOnW987KgwsdibTG0sPz2YWQT6mK3b4BL2W8RjmesTMoj48UxN+1IRGp11WGTWshzoCC/x0+++01YLMuTJrUBHpKdra7OaV9lzSLlZ0UT/NPHWrtLb8SdhiYOpDve198YqeOzQTKi2S26DZLsKensFLNmrFw3lDNTdiUJ9+7uyzzjiDPLpPjagXyIkj8VmXWSiYRH7TwcKoLbf1TBECEuqWwxnQ7na0Jut+YRAZEvxQXCtLlSl6/388hDEqHnqJTvZTxnc48bYLTZsYE8fiHUw8n94b339IRkmEEbiH7ZPUorSNffF3JoCRODG7dj1I5Tcg5E7Vz2uKQIGcRHeqsTA0FAuOuydJ3ELUx+fKGWpXbmPxbuSUW0BMtPCflidg+keCeaQtRVpA42diYJZkNFZzzDX3mNH977ch/G2z0R5NcvSaSFIgGcAfLmjnElpLuS55vqYAVReFZN6HWPETNgnrtKCQE47NPOql7K4Jy3257cUAYid6PCrlzcew1lDzs+C8PxvB+N28zbLElY5J77hDXIhxZjfJLgPsohWLQdRjQPQNaTv36ErURjEKuvoycmyCXP064RE8zU2pshz4K/q0hRCn/1GOxN/QSKaz1I3fr+tIirmsr2vWqYVV+u+SXdOOGS2NWv94yh5wWjLCz/aeP6D70nqDC9hEzR3irAFrgp06RgssSOmofTnL+6JjoABy2zDJ4hsLYg78PJqiHEEMwJg== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7698159e-501e-4918-4656-08dac7b87694 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 09:53:52.3070 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NR03p8aFXzhHsO0835Mnks7V+Smi8i0Yh/pbojlOV0Om4K050DKqshPChmugTftm3kOw7Ld4IPdC6p3a0R5hCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6759 On Wed, Nov 16, 2022 at 12:27:29AM +0000, Andrew Cooper wrote: > On 15/11/2022 13:26, Roger Pau Monne wrote: > > Hello, > > > > Just two patches remaining, and the last one is already Acked. > > > > First patch deals with moving the switching of SSBD from guest > > vm{entry,exit} to vCPU context switch, and lets Xen run with the guest > > SSBD selection under some circumstances by default. > > > > Andrew has expressed reservations to me privately with patch 2/2, but > > I'm still sending it so that comments can be made publicly (or the patch > > applied). > > > > Thanks, Roger. > > To avoid a further round trip, I've committed these patches with some > minor non-functional adjustments.  In patch 1, an expanded context > switching comment, and in patch 2, an adjusted commit message and > movement into __initdata. FWIW, I didn't expand the comment in patch 1 because I though it was likely to get out of sync. > I've also closed out #90, which closes one of the release blockers. > > All other bugs can wait until 4.18, including the totally bizarre one > where using cpuid="host:virt-ssbd=1" in the xl.cfg file causes IBRS to > become hidden.  I confirmed this was pre-existing behaviour, but haven't > investigated further. Hm, I don't seem to be able to use cpuid="host:virt-ssbd=1", I get: # xl create -c tests/virt-spec/test-hvm32-virt-spec.cfg Parsing config from tests/virt-spec/test-hvm32-virt-spec.cfg while parsing CPUID string: "host:virt-ssbd=1": error: first word must be "host" However using cpuid=["0x80000008:ebx=xxxxxx1xxxxxxxxxxxxxxxxxxxxxxxxx"] does work and I can see both virt-ssbd and ibrs present in the guest CPUID on an EPYC 7543P (Milan). Regards, Roger. From xen-devel-bounces@lists.xenproject.org Wed Nov 16 10:12:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 10:12:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444246.699246 (Exim 4.92) (envelope-from ) id 1ovFP1-0002KX-Tt; Wed, 16 Nov 2022 10:12:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444246.699246; Wed, 16 Nov 2022 10:12:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovFP1-0002KQ-QQ; Wed, 16 Nov 2022 10:12:19 +0000 Received: by outflank-mailman (input) for mailman id 444246; Wed, 16 Nov 2022 10:12:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovFP0-0002KK-25 for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 10:12:18 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23a01dc9-6597-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 11:12:16 +0100 (CET) Received: from mail-mw2nam10lp2108.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Nov 2022 05:12:08 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB6272.namprd03.prod.outlook.com (2603:10b6:a03:3aa::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 10:12:06 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Wed, 16 Nov 2022 10:12:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23a01dc9-6597-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668593535; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=U0QYsZ/ZQSzBDfIueljtW82soAW7bSRi6m2TaKuC6xM=; b=L+Yg/p9RiOa2mDV/I67Mz6PStgmYa1q8mZx36VHMZOePdMBSeiKe4WCs LkRap0ZKA4bC3oE4ALpJ7lqwG8TrYDULDedSil/hvJiov6qt6kKQf74H1 Ey7JfLVlbxr1TEDsFj+WhfNK6qZ0EGpcvJMjrkkokNxrMIpu7Zda8pdgl Y=; X-IronPort-RemoteIP: 104.47.55.108 X-IronPort-MID: 87465033 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:nipK3K/BG7y7ZIxOq6EUDrUDs3+TJUtcMsCJ2f8bNWPcYEJGY0x3z DYdDT2CM/vcZGv9Lot0aoixpE0Cu5HdmN82GwU9rXo8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKkV5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkVy dgKeQxWaivSpNyNmpW8Ve41h8cKeZyD0IM34hmMzBn/JNN/GdXmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUpgNABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prr+QwX2mANlJfFG+3vBax3qh734TNAwXdkLi+KeXjBKzA80Kf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwCGAzLDFpTmQAGcsRyRELtchsaceWjgCx lKP2dTzClRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85i8jVf5mGa+xy9jqQzf5x mnSqDBk3u1Dy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDEhAzSJflhTBCwfdg= IronPort-HdrOrdr: A9a23:UgEgPKFrPjjRYl2UpLqFiJLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH PQ3LswmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzI39QWUijusybjiVzyVxA0XXT9jyaortT GtqX2y2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuQFNzn2jQ6sRYJ5H5mPpio8ru2D4Esj1P PMvxAjFcJu7G65RBD/nTLdny3blBo+4X7rzlGVxVPlvMzCXTo/T+5Mn5hQfBf141cp+IgU6t MC40up875sST/QliX04NbFEzlsi0qPuHIn1coelWZWX4cyYKJY6aYf4ERWOpEdGz+S0vFvLM BeSOXnoNpGe1KTaH7U+kFp3dyXR3w2WiyLR0AT0/blpgR+rTRc9Q811cYflnAP+NYWUJ9f/d nJNaxuifVnUtIWRbgVPpZOfeKHTkj2BT7cOmObJlrqUIsdPWjWlpLx6LIpoMm3ZZ0zyocokp ipaiIWiYcLQTOvNSSy5uwJzviUK1/NHwgFi/suq6SRg4eMBYYCaka4ORUTe8jJmYRsPiSUYY f2BHtsOY6SEYLfI/c24+TAYegiFZA/arxghj9pYSP4nuv7bqvXi8f8TNH/YJLQLBdMYBKNPp JEZkm/GPl9 X-IronPort-AV: E=Sophos;i="5.96,167,1665460800"; d="scan'208";a="87465033" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lrbBSs2q75RyI89TXL4DWPqunhtvpRw2dLW8h47XZAHeUy7VGATsYS30uu90D3+faB7R3e3QJqywvpHoIdZIRZ1nLL6M7jKWiTNi+qXm7FLPTkILCCxh6ke5rtm3DxEYvNW+zAU8Q9V7Eq2R7EhyPC7R50l8xoBIo+dJ5EXRNtFPjQXYc7QOeyl1lcDFrxq1qmNsK6Hc7eiJ1gjRd3sCAqnb/uwCWgi+nCajNo2VnoK3glr/l6QlS9ief3bcpuEJ+GYPcX3O6/jEDJ7u5JgC2us0zuCzUfiqD8W29ed6XFcyxx6N+ZbvrkTsMw8+fq8080fWtVjszPdJM0j4MuSnzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ysUtD3/HfB56CR1xkTIbrxesjOsMXC8HAnE4JLjOLI=; b=AI0YB/h19Mjik2pQGLnWshpvHiEu9OAA2RDhJ7jp+9KfoDa3N2GkiiX7B6HLuIU+P5Jsdxcg+82U4tVi7yORujqsHGM5xlZxd3vIoE6LFnvs2cOA7anUI0Z13P24rf2Pqwl44fJ+593c17N4d3TxxxARh25gpQvuR7VO37aZjq6zZwXqUacV7xJ46PtgtJUfp/wZPsRqyvMEVozMT4xgCBSbPiJ2ejX8qSDAWW7ghsv0+NEVXumLGQsElFoE0yE+PmHRDIzuj7BJ4Wb3shT0+PCz2d+7W9v+duJhhO/boILDEH441Ipj5apN4oBvtzGXa0SP6hgjh9sK1GwRkvQThw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ysUtD3/HfB56CR1xkTIbrxesjOsMXC8HAnE4JLjOLI=; b=afG0Ful+iOIbRKETn8JmP4QmXuioypRi5mKQneHrjLXD+7CtKqSmoBSNqN32PIkEDw8gaegJuMlXDJrFbbTuuwtlN0RNpcGWfLoEgkDdV4p16KL/81aThbViZS7MezCSqmZ/Bh9nJY+dk5IMLNlrjggVnAPeWtKnGNv1h3+rIcU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 16 Nov 2022 11:11:56 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , "Henry.Wang@arm.com" , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH for-4.17 v4 2/2] amd: remove VIRT_SC_MSR_HVM synthetic feature Message-ID: References: <20221115132657.97864-1-roger.pau@citrix.com> <20221115132657.97864-3-roger.pau@citrix.com> <5caf3930-ea8f-6e68-326f-93cca1fa210a@suse.com> <51e9dd3f-59fb-a112-baf7-f96c07800ee1@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0246.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::17) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6272:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f88017e-05a7-4d95-ffd0-08dac7bb0141 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g/DAG0yAmLcHYXpiQ9eNMwjNFInlBeForl1Hlwl3Om+ClGcoSnmS8kedaqhqdAT3+/UwjYYMK2OQJmn6sHEbhBQlzsvt3C0Zyjv7MEB4m/1Hcv0hSVxWRwEtWn9LnPx0EIvg8+QiygO1hHOESDGLJmWMAA297d0hJvKHO9LkptArrRGUHPR2wOodGtmWHFYiAL611SO2YGngvhWbZ9ntdD0ehywulP38BB/KgFvg1LnMGBgMj/j9VBZKzZ9f/MnK7oL2w6GBwP8b3gvWvLyLH/lHa3zxOQkBjPw63ta+CXTvnNWSMHLIKWUNgG4ZuhbGLxouz8QehXvAYdq6OwiuZkWdGG2OK2jXEJ6YSWrNsYG8YqxDn5oFOVdKYL4GRth5P/wEeLofpFJ3Q6sn+E3pKz6KZcozRd7hLlC3Rz2JKNnpHrCd2u5Rkcqlar6qw7B/RfuJJTGQzeMNZ5ai80yIk1zJgl+qthNpvVtn/FFIGcFuyY4KzH0D+/8GHi04zTbLNPKaDBGvhyt7VpheKtPIhX7dF4mReNrp8Zdv1IvWzePMMoyFcINkf0Q9VKUQqkGHO97DCL0vIPk7pjNttQaHRvlP0WmUSh84OmO3MHGyAIDEaqVAJaHxIv0A4dI8l7oAcfPzCkLah7k31fhIQLQun/Xh64DMmS0zXuDhBM9gmKTGTNLTq0N8mGJlSoAPNEhJ+6k9qj06vwy0geRYNyrBlw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(39860400002)(346002)(136003)(396003)(376002)(366004)(451199015)(38100700002)(54906003)(6506007)(6916009)(53546011)(2906002)(316002)(41300700001)(8936002)(186003)(85182001)(86362001)(5660300002)(9686003)(26005)(6512007)(82960400001)(66556008)(66476007)(33716001)(8676002)(66946007)(4326008)(66899015)(478600001)(6486002)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yk84aGs2YWFyNTNzK3oxMTFRWXdjcWJwUURRTVI4WjVQbyt1SW42MWExaGh4?= =?utf-8?B?ZnpvTHFHM3ZJMFprQzVkeWsrQUhJVWJiVWZXOXRwMFI0dHBZai9Xd0NyRzE4?= =?utf-8?B?T0s0c0ppNnlWZnFGZFZhU2Z3RHZlQm0wYmpNOWN3anZVMjlKem5TWHYyVEs0?= =?utf-8?B?YzlzV0l6QU1VNERLSXh4MWsxWlBnWVhjeUUyeXJwR1dEVW1QdlRLL2k3QTdy?= =?utf-8?B?MDJxZzVDeHZoSFFqcWNBMVMwMGtmOTRFaEtLZkdJckxCcWYrSmgvd0tGUTRq?= =?utf-8?B?MHhNTHNOWkNQNTRWcUpRcm56R1ludUYxQUU3U1ZpdWNmM0FYeXd3aDBNdlZN?= =?utf-8?B?UFhFckJPY3AwS0RhYkpzaWNpTFhlalY3b2VEeUJOMm9FdXcwOEhsbXloRHls?= =?utf-8?B?QUpPK2RxakkzTzUzdVJITzRrMCtrNllsWER4cGRXcm9keXYvQ3c4K2hab25W?= =?utf-8?B?L3pwcXpRcFRmZWFHSVVxV3l4Z0QzQzB2VmZ4QmJFM3hFMXNlRThLTU9oWkZv?= =?utf-8?B?LzRyTDdGSnluSEc0aHJEdnRTcTNiYVllTXh1SFczczlTSlV1UG80bm9wN2I1?= =?utf-8?B?aTlmQTRDVDU0OU1MU3FSeEZCZk1tRnlLeENRaFYzWk9sL0NQemc5Q0ptdlNP?= =?utf-8?B?ODFuN3BMOUZrY2JaZ3pzN0RWT0JRQ25EclJrdDM1UEZrWW1jZFBrRzlxQnRO?= =?utf-8?B?eUlmS05wNk9LTUFMVFdwUTJDVDQxd0E5dS9nNUw1NkVyaEQ5U1lvRjRIOGJ1?= =?utf-8?B?UFFWTFFYb3YvMDVyUWx6ZXhCVmVtRkNvMUtvQzgybE5LZ0lkckJqb3RkSDVi?= =?utf-8?B?YzJ6Y0dYQVBVZVRJYkJWdnF2aUFHcFZFS1BpTXY2TDk5MExaRXJBK2l4c2Q4?= =?utf-8?B?bzg1S0FHdnVtWEFSNm1kOXhMVXU3MndZRm1uTFd5Zm1qeFZlWC9XZFRFQlU0?= =?utf-8?B?U1MzdU1IZjFOWktvenQ2T3dPQjAyVC9vbkV6M3FKTkRldVMxcjArbHg3RGli?= =?utf-8?B?L3krZEZmb1dpMDdSaEN5d3lhWjFNRHdMc1RyRlptQ21FYWJudU5LVy9lbERa?= =?utf-8?B?L0lDeHlleE16eXZ5bTQ2QnJFd09NZmhQaHVvRmY5QTFkV1g3T2F3emQ0RzF3?= =?utf-8?B?YVl2NFh2MTd1dGVQdkFGa1dsV1AwMHBEcDl1aG13cS9ySW9kbTEwUy8xSjNp?= =?utf-8?B?dTZjRnd2SnMzZm9VN2VmV3ZaZkExS2RoU1ZORVR0NzlXMkN0K0xhaE5MZFk2?= =?utf-8?B?RUdtQjhCOGVYSklRZkQrd2lBeEhxZ3hjU1VCYytQZVFEeTdNSWdmZndTbXJD?= =?utf-8?B?b1lCak9relk5N05yNklPdjZUd1hha01rRFQxTko4Y2tSUi8vL01BeXc3NHZx?= =?utf-8?B?VzJIS3Q2ekkzUm4zVFJpUFY5TkpWMTNIKy9Zc2dQejhLdjNNNG9ETlNFRUVV?= =?utf-8?B?WkJiME4vbW1OZENrR0hJQnVOcFh3L1BhSmpCQUQ3cENLYTBiR2VrdDBYQW13?= =?utf-8?B?TmlQKy94ZXFHWDg5UDhwWmdrSExXL3Z0S3kzdGhnWGUvV25hemM4Vyt5M1Rl?= =?utf-8?B?UFA1Rm1IazVya0t4SGJZak9VbmUrUWVtN0hSdkpSWi9TNHNrNHpxWjAvTGJW?= =?utf-8?B?eWh6MHZ0TGZTcGN4TkoyMDN1Z3Y4TVc2M3lmdmFISElEektodjhBYVZkWnUx?= =?utf-8?B?MVBFN1g5U25lbmhFRDdsa0oxK1NwR2lwN3g3cCtzUE9FOGhLS25vb09kQjRX?= =?utf-8?B?L1FyeHF5N016YmU0QW01R2F1TzVaNGF5dUxHa1VhaForWDBZOVBzN0FzeUhW?= =?utf-8?B?QURpRFB0R0JOVnNFNnhSQ0JraWwzc0prQXlKSDdLVFdBdWdxN1o1WGdVazRQ?= =?utf-8?B?MUtiSjdreWlnV2xEdDI3TXQrbzNVTEFKalV6bzkxRlFJL000Rjdibzc1ckJQ?= =?utf-8?B?NllvWEpyOFEyNWsvYmlVVDNSWWZFQ1FuQ0ovN2dYSWVYelZmbXlmSzd6RFN5?= =?utf-8?B?QW93dkk0V0lYbThmcW55MUs5S2RYQ0MyK1FQSy80VTFkcGVoNWVnVWYzR3Zo?= =?utf-8?B?VkVkOXVDQmx5R01uSmIxcDh5VXJ1ZExmM3A5eStjeDhrWnk4YURZK0d1d3B5?= =?utf-8?B?REx1NmpPK2tuU3ZiZmhRcVROdHlreldBNFNMOTJQd0dnalRXZXRZM3BrMFhU?= =?utf-8?B?enc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: eSgiBGCOzZWiiPNockNedswWpfMvAfU+yoWgVit//7fBMhNNlHc9YLQqlE/50vzEo/2e+iNidGcZrCoE/lNAKMc2BlZMHdCI7PQ8e6Rw3mVSzYdQmnnjerGcfzlYJq0+Mz1CJWNeH5uCSyeItn6ypCG8ivFJ0CNE/lPbNnRdTFE8KkAt0XO+ZFyejBJklL8OEbkmCtBUzpepa+/UeD04/pivGZuzCZKCBsS0EG565/aTtyO/zJA178HOh/3do7nu9n+5xas50FBiRwV5ge3v1OCetVgUxdWuNm63W9EHX6xV6rASnXCxcUuioqpCmzBhlBbR2vHCglBZp4mNtouQggLoFBfVC1YUeyXhNMxAbuHFjFyRxiMEGlRRQqYMBsr0Z50Y0vnhh7kKvSPyIIKhJXFiYL9P8p6Hs8uHP6fy+Y+3zl+7WnAd/urn2V1BnpWf1M55rSQr7n/npXN57RFuzVfpaBB5FNrzhei0j1PckiiBuc78fQXRDsAnRCU3j2ORB+/sCYMoZpjxfbe4e3H/W/qP+igZfrgv6AkNMsXtmw36GU2TL0vVgfI5TVu1dmAFSQ6IZueK//6en0tVfEasPDrKFRh00K7hu1TpQrCL0tnG0Gu+vCXl98uoEFpIxcczbHTOI41zAtTFQkbmHccQPSDmKu1ixt43vXi0pqHfEuLobbrFHHmPetw+IY2ro425Vss1tetGmHcwQ7NQqxf9kQoWW/ng2FkJ5kbhHRaIeZapat2HUBOd2/l5nQGTCGfZj4/qYjYXa9SiFQDDjYyl57KLPF5PTtsa37eKY0gadyl9POrK9suKr1UC/FaOlp5M+uhy4Rs5W1KhZdcx+r+ab5nspGtVBmMZXF6QknOWCMs= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f88017e-05a7-4d95-ffd0-08dac7bb0141 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 10:12:05.9741 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oZZdyi07QjxNGgwAAl5ppg0xINlhuGfAEpDRHm1yFEsGYRL3jufDx0P7/xVT1xRKRiZcAgvGWfAUqrog6oRuaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6272 On Wed, Nov 16, 2022 at 08:41:06AM +0100, Jan Beulich wrote: > On 16.11.2022 00:54, Andrew Cooper wrote: > > On 15/11/2022 16:44, Jan Beulich wrote: > >> I think we need to settle on at least halfway firm rules on when to use > >> synthetic feature bits and when to use plain global booleans. Without > >> that the tastes of the three of us are going to collide again every once > >> in a while. > > > > Its very easy.  All other things being equal, synthetic features are the > > most efficient option. > > See Roger's better wording of "why use a more complicated construct when > a simple one will do". Yes, generated code may be better in certain cases, > but no, we don't always judge by that aspect alone. Source simplicity is > an important criteria, which at other times I recall you also weighing > higher than the performance of resulting code (especially when dealing > with performance aspects when they don't really matter at most/all use > sites of whichever construct). I think it would be easier if we can discuss this in one of our x86 related meetings. It's still unclear to me why a synthetic feature would be preferred rather than a global variable in most cases (like the one here, even if the variable didn't end up having the __init attribute). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Nov 16 10:40:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 10:40:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444251.699257 (Exim 4.92) (envelope-from ) id 1ovFqR-0006Hv-4X; Wed, 16 Nov 2022 10:40:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444251.699257; Wed, 16 Nov 2022 10:40:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovFqR-0006Ho-1x; Wed, 16 Nov 2022 10:40:39 +0000 Received: by outflank-mailman (input) for mailman id 444251; Wed, 16 Nov 2022 10:40:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovFqP-0006Hb-GB; Wed, 16 Nov 2022 10:40:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovFqP-0000O0-CV; Wed, 16 Nov 2022 10:40:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovFqO-0008AB-Rv; Wed, 16 Nov 2022 10:40:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovFqO-00072G-RS; Wed, 16 Nov 2022 10:40:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0LDVr2SiyOEBdIUSYKSYCWFyLzVUraSYQQp4fe7yBkY=; b=pnM01ql0oD7lehD1pogqf8mLuu mlxIARts95je0Djqq/8/utN80hgqyivrW6MjNESWlGZ9KmeQkipJ2xcvRc0YJiK+SYe6Are37MOrj hQWnu9sznejJovEgsRnPYioVazi9OqxCgQXAdwcFnODaRO1w5M7fJbW7LdO7zGQANJMc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174785: all pass - PUSHED X-Osstest-Versions-This: ovmf=93629f2c7cf05ebc0f458eacc42a33147096f9d1 X-Osstest-Versions-That: ovmf=0cb30c3f5e9b2be5157224afdf75fa16bc09b9c7 From: osstest service owner Date: Wed, 16 Nov 2022 10:40:36 +0000 flight 174785 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174785/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 93629f2c7cf05ebc0f458eacc42a33147096f9d1 baseline version: ovmf 0cb30c3f5e9b2be5157224afdf75fa16bc09b9c7 Last test of basis 174763 2022-11-14 05:14:03 Z 2 days Testing same since 174785 2022-11-16 01:55:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Pierre Gondois jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 0cb30c3f5e..93629f2c7c 93629f2c7cf05ebc0f458eacc42a33147096f9d1 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Nov 16 11:09:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 11:09:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444258.699267 (Exim 4.92) (envelope-from ) id 1ovGIg-0000tK-Hn; Wed, 16 Nov 2022 11:09:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444258.699267; Wed, 16 Nov 2022 11:09:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovGIg-0000tD-FF; Wed, 16 Nov 2022 11:09:50 +0000 Received: by outflank-mailman (input) for mailman id 444258; Wed, 16 Nov 2022 11:09:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovGIf-0000t7-W6 for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 11:09:49 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 2e75d619-659f-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 12:09:47 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 008D81477; Wed, 16 Nov 2022 03:09:53 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A9EE93F663; Wed, 16 Nov 2022 03:09:45 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e75d619-659f-11ed-8fd2-01056ac49cbb Date: Wed, 16 Nov 2022 11:09:42 +0000 From: Andre Przywara To: Stefano Stabellini Cc: Michal Orzel , Jiamei Xie , "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , "julien@xen.org" Subject: Re: Xen Arm vpl011 UART will cause segmentation fault in Linux guest Message-ID: <20221116110942.3faf952f@donnerap.cambridge.arm.com> In-Reply-To: References: <00764fe2-f78a-e5db-cb16-903ad1a5ec03@amd.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 10 Nov 2022 12:32:49 -0800 (PST) Stefano Stabellini wrote: Hi, > On Wed, 9 Nov 2022, Michal Orzel wrote: > > Hi Jiamei, > >=20 > > On 09/11/2022 09:25, Jiamei Xie wrote: =20 > > >=20 > > >=20 > > > Hi Michal=EF=BC=8C > > >=20 > > > Below log can be got when stating the linux guest. It says 9c09 is sb= sa. And 9c09 is also output > > > in bootlogd error message: > > > Serial: AMBA PL011 UART driver > > > 9c0b0000.uart: ttyAMA0 at MMIO 0x9c0b0000 (irq =3D 12, base_baud =3D = 0) is a PL011 rev2 > > > printk: console [ttyAMA0] enabled > > > 9c090000.sbsa-uart: ttyAMA1 at MMIO 0x9c090000 (irq =3D 15, base_baud= =3D 0) is a SBSA > > > =20 > >=20 > > Xen behavior is correct and this would be Linux fault to try to write t= o DMACR for SBSA UART device. > > DMACR is just an example. If you try to program e.g. the baudrate (thro= ugh LCR) for VPL011 it will > > also result in injecting abort into the guest. Should Xen support it? N= o. The reason why is that > > it is not spec compliant operation. SBSA specification directly specifi= es what registers are exposed. > > If Linux tries to write to some of the none-spec compliant registers - = it is its fault. =20 >=20 > Yeah, we need to fix Linux. Yes, it's a bug in Linux, and nobody noticed because most SBSA UARTs are actual PL011s, just not with everything wired up and the clocks fixed. But while you can take pride all day in Xen having a perfect spec-compliant implementation - and you would be right - you have to face the reality that existing Linux kernels will crash. So we will add the one-liner in Linux that fixes that issue, and this will probably be backported to stable kernels, but you will still encounter kernels without the fix in the wild. So I wonder if you should consider to just implement the other PL011 registers as RAZ/WI? That would be spec compliant as well (since an actual PL011 is also a spec-compliant SBSA-UART), but would work either way. Of course you don't need to implement the DMA or baudrate functionality, but at least not be nasty and trap on those register accesses. Cheers, Andre > FYI this is not the first bug in Linux affecting the sbsa-uart driver: > the issue is that the pl011 driver and the sbsa-uart driver share the > same code in Linux so it happens sometimes that a pl011-only feature > creeps into the sbsa-uart driver by mistake. >=20 >=20 > > >> -----Original Message----- > > >> From: Michal Orzel > > >> Sent: Wednesday, November 9, 2022 3:40 PM > > >> To: Jiamei Xie ; xen-devel@lists.xenproject.org > > >> Cc: Wei Chen ; Bertrand Marquis > > >> ; julien@xen.org; sstabellini@kernel.org > > >> Subject: Re: Xen Arm vpl011 UART will cause segmentation fault in Li= nux > > >> guest > > >> > > >> Hi Jiamei, > > >> > > >> On 09/11/2022 08:20, Jiamei Xie wrote: =20 > > >>> > > >>> > > >>> Hi all, > > >>> > > >>> When the guest kernel enables DMA engine with =20 > > >> "CONFIG_DMA_ENGINE=3Dy", Linux AMBA PL011 driver will access PL011 > > >> DMACR register. But this register have not been supported by vpl011 = of Xen. > > >> Xen will inject a data abort into guest, this will cause segmentatio= n fault of > > >> guest with the below message: > > >> I am quite confused. > > >> VPL011 implements SBSA UART which only implements some subset of PL0= 11 > > >> operations (SBSA UART is not PL011). > > >> According to spec (SBSA ver. 6.0), the SBSA_UART does not support DMA > > >> features so Xen code is fine. > > >> When Xen exposes vpl011 device to a guest, this device has "arm,sbsa= -uart" > > >> compatible and not "uart-pl011". > > >> Linux driver "amba-pl011.c" should see this compatible and assign pr= oper > > >> operations (sbsa_uart_pops instead of amba_pl011_pops) that do not e= nable > > >> DMA. > > >> Maybe the issue is with your configuration? > > >> > > >> ~Michal > > >> =20 > > >>> Unhandled fault at 0xffffffc00944d048 > > >>> Mem abort info: > > >>> ESR =3D 0x96000000 > > >>> EC =3D 0x25: DABT (current EL), IL =3D 32 bits > > >>> SET =3D 0, FnV =3D 0 > > >>> EA =3D 0, S1PTW =3D 0 > > >>> FSC =3D 0x00: ttbr address size fault > > >>> Data abort info: > > >>> ISV =3D 0, ISS =3D 0x00000000 > > >>> CM =3D 0, WnR =3D 0 > > >>> swapper pgtable: 4k pages, 39-bit VAs, pgdp=3D0000000020e2e000 > > >>> [ffffffc00944d048] pgd=3D100000003ffff803, p4d=3D100000003ffff803, = =20 > > >> pud=3D100000003ffff803, pmd=3D100000003fffa803, pte=3D006800009c090f= 13 =20 > > >>> Internal error: ttbr address size fault: 96000000 [#1] PREEMPT SMP > > >>> Modules linked in: > > >>> CPU: 0 PID: 132 Comm: bootlogd Not tainted 5.15.44-yocto-standard #1 > > >>> pstate: 604000c5 (nZCv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=3D--) > > >>> pc : pl011_stop_rx+0x70/0x80 > > >>> lr : uart_tty_port_shutdown+0x44/0x110 > > >>> sp : ffffffc00999bba0 > > >>> x29: ffffffc00999bba0 x28: ffffff80234ac380 x27: ffffff8022f5d000 > > >>> x26: 0000000000000000 x25: 0000000045585401 x24: 0000000000000000 > > >>> x23: ffffff8021ba4660 x22: 0000000000000001 x21: ffffff8021a0e2a0 > > >>> x20: ffffff802198f880 x19: ffffff8021a0e1a0 x18: 0000000000000000 > > >>> x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 > > >>> x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 > > >>> x11: 0000000000000000 x10: 0000000000000000 x9 : ffffffc00871ba14 > > >>> x8 : ffffffc0099de260 x7 : ffffff8021a0e318 x6 : 0000000000000003 > > >>> x5 : ffffffc009315f20 x4 : ffffffc00944d038 x3 : 0000000000000000 > > >>> x2 : ffffffc00944d048 x1 : 0000000000000000 x0 : 0000000000000048 > > >>> Call trace: > > >>> pl011_stop_rx+0x70/0x80 > > >>> tty_port_shutdown+0x7c/0xb4 > > >>> tty_port_close+0x60/0xcc > > >>> uart_close+0x34/0x8c > > >>> tty_release+0x144/0x4c0 > > >>> __fput+0x78/0x220 > > >>> ____fput+0x1c/0x30 > > >>> task_work_run+0x88/0xc0 > > >>> do_notify_resume+0x8d0/0x123c > > >>> el0_svc+0xa8/0xc0 > > >>> el0t_64_sync_handler+0xa4/0x130 > > >>> el0t_64_sync+0x1a0/0x1a4 > > >>> Code: b9000083 b901f001 794038a0 8b000042 (b9000041) > > >>> ---[ end trace 83dd93df15c3216f ]--- > > >>> note: bootlogd[132] exited with preempt_count 1 > > >>> /etc/rcS.d/S07bootlogd: line 47: 132 Segmentation fault start-stop-= =20 > > >> daemon =20 > > >>> In Xen, vpl011_mmio_write doesn't handle DMACR . And kernel doesn't= =20 > > >> check if pl011_write executes sucessfully in pl011_dma_rx_stop . So = such > > >> segmentation fault occurs. =20 > > >>> static inline void pl011_dma_rx_stop(struct uart_amba_port *uap) > > >>> { > > >>> /* FIXME. Just disable the DMA enable */ > > >>> uap->dmacr &=3D ~UART011_RXDMAE; > > >>> pl011_write(uap->dmacr, uap, REG_DMACR); > > >>> } > > >>> > > >>> I think we should prevent such segmentation fault. We have checked = the =20 > > >> PL011 spec, it seems there is not any register bit can indicate DMA = support > > >> status of PL011. We might have two options: =20 > > >>> 1. Option#1 is to add DMA support for vpl011, but this is not trivi= al. > > >>> 2. Option#2 is to ignore the write to DMACR, and return 0 for DMACR= read =20 > > >> in vpl011. But this option need co-work with kernel, because current= Linux > > >> PL011 driver assume the write operation will never be failed, and wi= ll not > > >> fallback to no-DMA mode, when Xen return 0 for DMA enabled bit in DM= ACR. =20 > > >>> > > >>> How do you think about it? Any suggestion about it is welcome. Tha= nks. > > >>> > > >>> Best wishes > > >>> Jiamei Xie > > >>> =20 > > =20 From xen-devel-bounces@lists.xenproject.org Wed Nov 16 11:29:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 11:29:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444263.699278 (Exim 4.92) (envelope-from ) id 1ovGbE-0003jm-4B; Wed, 16 Nov 2022 11:29:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444263.699278; Wed, 16 Nov 2022 11:29:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovGbE-0003jf-1T; Wed, 16 Nov 2022 11:29:00 +0000 Received: by outflank-mailman (input) for mailman id 444263; Wed, 16 Nov 2022 11:28:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovGbD-0003jZ-4e for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 11:28:59 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20624.outbound.protection.outlook.com [2a01:111:f400:7e1b::624]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dc1db4f7-65a1-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 12:28:57 +0100 (CET) Received: from FR3P281CA0198.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::20) by GV2PR08MB8319.eurprd08.prod.outlook.com (2603:10a6:150:b5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Wed, 16 Nov 2022 11:28:54 +0000 Received: from VI1EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a5:cafe::56) by FR3P281CA0198.outlook.office365.com (2603:10a6:d10:a5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Wed, 16 Nov 2022 11:28:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT031.mail.protection.outlook.com (100.127.144.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 11:28:54 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Wed, 16 Nov 2022 11:28:53 +0000 Received: from fd6b90dfea7d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D0496274-C3AD-46B6-B7B1-6032BC9B673D.1; Wed, 16 Nov 2022 11:28:47 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fd6b90dfea7d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 16 Nov 2022 11:28:47 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAXPR08MB6333.eurprd08.prod.outlook.com (2603:10a6:102:15b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8; Wed, 16 Nov 2022 11:28:46 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%7]) with mapi id 15.20.5834.007; Wed, 16 Nov 2022 11:28:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc1db4f7-65a1-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qbm9MgyO+1iy9mSZzdDFuFTFGBBD4tlpyWTfCKXxgNQ=; b=d0GzbecN/CNHHsv/fQY6u3D0ZClWxIePwbg3jFH5B0QBaoFAsqMx6cW7VXgw3dOtLBkOTL4JQiseOK7YIdoz2+LWW16uybMeyY1Sgizt1Rbz7fT0ZYEc7gsUW8WpaIlAJ4yQ5vgjRVPUnZjQg6vCLKZI23ksYqjew9zN9/O1kkI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ai2fB9zuLBCEX2kMOpyN15QgtoY+IuNOa4gbGI1g6O6hrWdG9+QbEDRFicwjWNlHBYGVeztWr7Mqgy5HwVQbUN21QvvHOpIfsWwlbd0plgIABcsC46Nmeat+pKilVEWOyQ/kHPD6rGNSQpDsqpUlSrlt72Yyht6hehL5zu2QndiOT0hXJfWfR3ZHFxeW37/LKLLiH2dmkOG5xwaJbMlTl/VMLcuw8bDfTuby6NB7f3+UnXU1C8SHJqCchSLLS/EXYrrjJavGiNyVflL8/9uT5Kgk3YHfC8fW1XKajJ17PjfcjA2oqeod7RDxjUG9ijQqUioMKzbK+nkYRaoWWYaeMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qbm9MgyO+1iy9mSZzdDFuFTFGBBD4tlpyWTfCKXxgNQ=; b=blpEB8hNEIFge2GYOOUq5vdAr2KwuKEXbRwVYHgkKVaoxAwhZZ3MdpTUG9joV/YJGBYEgZa0WLjWFJBL8RVLf4ffe1EoM75uzjL/w/1iKx+snO/Jre3FR/I3vn5OQ8kiSu1v6y1QD8lnyAQTipY7XWi7M6RCA/liVv/X+UPxZNbt3my34UYaqjtu8e2L6o3Z7pHE74IoI2RJ9IFsKR8f5eRwlpnl0eh3aLA2rS5i3UZSE8qiVvWXtNmusOXb7V/PgSwETA/y6fXrk4AKbsk106ADVapFjjGv5tIbLrNlxiuIj37LzlJTLd2zv1hvLLiOAoAYKopkrc2+7msFfo4M3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qbm9MgyO+1iy9mSZzdDFuFTFGBBD4tlpyWTfCKXxgNQ=; b=d0GzbecN/CNHHsv/fQY6u3D0ZClWxIePwbg3jFH5B0QBaoFAsqMx6cW7VXgw3dOtLBkOTL4JQiseOK7YIdoz2+LWW16uybMeyY1Sgizt1Rbz7fT0ZYEc7gsUW8WpaIlAJ4yQ5vgjRVPUnZjQg6vCLKZI23ksYqjew9zN9/O1kkI= From: Henry Wang To: Jan Beulich , Andrew Cooper CC: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , Xen-devel Subject: RE: [PATCH for-4.17] x86/spec-ctrl: Fill in whitepaper URL Thread-Topic: [PATCH for-4.17] x86/spec-ctrl: Fill in whitepaper URL Thread-Index: AQHY+HJMoGDeJbhqNEaV7yqbAICZiK4/pLgAgAHGmUA= Date: Wed, 16 Nov 2022 11:28:45 +0000 Message-ID: References: <20221114214358.17611-1-andrew.cooper3@citrix.com> <780da682-806e-6ada-eadb-018579d0e808@suse.com> In-Reply-To: <780da682-806e-6ada-eadb-018579d0e808@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 596C5BE9EEB1854395198CC428E9C209.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAXPR08MB6333:EE_|VI1EUR03FT031:EE_|GV2PR08MB8319:EE_ X-MS-Office365-Filtering-Correlation-Id: 55314d24-a645-4181-f3b5-08dac7c5be53 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XicCHzbOLLyHECu44R8K8QBXhERoBvIGtGZk/VALN67e78QRdAm3nqr8YVl/kpZtIX4pGZ8frfSaFd3BKd8hr2G62N7u+20pCf9kF9exxEg5xG3oWQQ+dtCiQlXmL0Ssbs5Ogn3OUwmrzjqjhk78cLXElzet3B/cztYtidNhUgrVmnyiZTk2df76S0Gp3BBu52l3X6eySIMULwp5DCl5JrYTQ2YZdFhjOOGkX6sWBha7iBZ16SDlR10ggbVStoCXe5a6Dk3my1YAZTodeF9TAhaOZEphnsHbQqIwwQ2bAEZ4rX1tZaWcFPfOKATaU5waNRh8QO3CucnpvP5qLMR/pBIRwQG7kS5tIz+/KLm0MFKXwxXylXeapfQqxCAHxLMGBGX//Cz3zdlocxMvViBdwfS11Ba9Sjp1JeuMc6JGBQfsbtMrT26Atao/pW1Tp1BBluGQwAcxCj8ee9uuHWirhkX7biRZfgJZw0JYqxcVv0QEY6iCqPlLo/niWwhORBHknVzXzPZjCO/x/SdgpjDXOiU7t4VTnEBdK3vyny0DUwWViLqK+r8V0ZRyZfFKepmTbKSNgzw/0DiKtMQ8rArkQk8RditmzNAjoHk5+7wUq7kX1fuk3xFKL5wbJm+JJVto/wdKfj7zep9MxyZ1I0YLOk27t/A27rH9XjsEUBrD2bFp/eIUZWZrBwTc+aqvj7JYYXg32ZKvvIWkMro62x7/X8PlhdbghtULLGerk7nSQrKqDNxwnk/0NXUuIqcyKb/mrpsL5ScewUJuaT0JFxnvjQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(366004)(346002)(376002)(451199015)(86362001)(4326008)(8676002)(33656002)(55016003)(41300700001)(186003)(66476007)(66556008)(66446008)(66946007)(76116006)(4744005)(8936002)(52536014)(2906002)(5660300002)(9686003)(110136005)(26005)(7696005)(71200400001)(478600001)(54906003)(6506007)(316002)(38100700002)(64756008)(122000001)(53546011)(38070700005)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6333 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6e7a99fb-d2e7-47ee-632b-08dac7c5b8fc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KpD+CJru4Wm1Pht2OzTQJ7OgpqssF1AUOQjfLpumzkUrFuAIEin+RbQG18FscbOUW5MKqsBqItcZe8Miv9UVrzYHcNhU/yluJYkbJ433eLcQK6fIg/Qejy9fIVk3104tBn+AQUFzMAbiS72j4fS4s5uLJxP3zBfDrIuMMsQ5+AEVh05de89c4+eh8jfK3xNCZm8dVF3g9LY3LhmJPgJesCw2P12Xx/UMeQBsKABmFo/SMYzmG6LYdg+tG6p1goZGfzLPauPImuIYUMpTQFi37q3fh/+JdbMPwvwu4oiczVfGLyxDJE4wbz59j/vjBnlkX04WrJ671ft8iaQ4OSbw5MTrUs04kEAis9mASX7FUba+YRUa43UNNxLBT2EiFIQOSGEf8vjKIRboDvAOJbiFG+DCintgSXPA/46yOE7qckc0eKZTU0cxS2HOtkzLmWaAKsmAnCIIjm+jn6yM+BntfOstfD5NrLOHWfeR0WF569prrPFZHoE9Yw5gtnmeKHsw/4V2qeHmraDTSpcYpysxG0Z0sOrTWMgRKtwLOxmL2GLH8zogiy08Jkj090DHx9r1uJ3lQSGhFxqHC6UV8pYa4CD4ifkEQQaPkg2KlRRCoCaFv0LB2LAFixlHJVOsEwKfjYLC5nnhDNcrT2536GNZ2uHNz+b9s5n4BaEbPrPEjh09r/a4unLlYJojfmogIPNAkBTtEwEUexOFV1c8J+iLwQZeZYpjqjPrsEyKnZWcYZuThqg6mMJ270u5dTT5C1Bby6gbX67zSoOWx42grbxHYg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(36840700001)(46966006)(40470700004)(5660300002)(52536014)(8936002)(4744005)(2906002)(41300700001)(356005)(33656002)(316002)(110136005)(54906003)(8676002)(36860700001)(4326008)(83380400001)(478600001)(70586007)(70206006)(47076005)(55016003)(82310400005)(40460700003)(336012)(186003)(81166007)(40480700001)(7696005)(53546011)(26005)(6506007)(9686003)(86362001)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 11:28:54.0910 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55314d24-a645-4181-f3b5-08dac7c5be53 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8319 SGkgQW5kcmV3LA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBC ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCBmb3ItNC4x N10geDg2L3NwZWMtY3RybDogRmlsbCBpbiB3aGl0ZXBhcGVyIFVSTA0KPiANCj4gT24gMTQuMTEu MjAyMiAyMjo0MywgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gPiAuLi4gbm93IHRoYXQgd2UgYSBs aW5rIGF2YWlsYWJsZS4NCj4gPg0KPiA+IEZpeGVzOiA5ZGVhZjJkOTMyZjAgKCJ4ODYvc3BlYy1j dHJsOiBFbmFibGUgWmVuMiBjaGlja2VuYml0IikNCj4gPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcg Q29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiANCj4gQWNrZWQtYnk6IEphbiBC ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KUmVsZWFzZS1hY2tpbmcgdGhpcyBzZWVpbmcg c2Npc3NvcnMgbGluZSBjb21tZW50IGZyb20gdGhlIG9yaWdpbmFsDQpwYXRjaCAiSWYgbm90LCBp dCBjYW4gZ28gaW50byA0LjE4IGFuZCBnZXQgYmFja3BvcnRlZC4iLiBIb3BlZnVsbHkNCnRoaXMg cmVsZWFzZS1hY2sgd2lsbCBvZmZsb2FkIHNvbWUgbWFpbnRlbmFuY2UvYmFja3BvcnQgZWZmb3J0 IGZvcg0KeDg2IG1haW50YWluZXJzLg0KDQpSZWxlYXNlLWFja2VkLWJ5OiBIZW5yeSBXYW5nIDxI ZW5yeS5XYW5nQGFybS5jb20+DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 16 11:35:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 11:35:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444267.699290 (Exim 4.92) (envelope-from ) id 1ovGhM-0005PY-QN; Wed, 16 Nov 2022 11:35:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444267.699290; Wed, 16 Nov 2022 11:35:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovGhM-0005PR-Na; Wed, 16 Nov 2022 11:35:20 +0000 Received: by outflank-mailman (input) for mailman id 444267; Wed, 16 Nov 2022 11:35:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovGhL-0005PH-3h; Wed, 16 Nov 2022 11:35:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovGhK-0001aZ-Vz; Wed, 16 Nov 2022 11:35:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovGhK-0001RI-J4; Wed, 16 Nov 2022 11:35:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovGhK-0001TS-Ia; Wed, 16 Nov 2022 11:35:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Hk8NBoGLKr26p1kwSJNdka0cxdyNohyTva8c2ZVm6uM=; b=khxxFRo30ilY9UkYstLFpwF5Mj ymEWFiE5IAuPgA92u4rm3bW4h0ZWCWswRvtifYC1Nb45tEt7KZ1nyMAZQj3PCe8CRxkvUEqHmHKmg fL5z50l70wjtQUQ66HkJMiTjeGP9ET8TsFCsKBDrIAlPfjtVj8zOcZ2yLSWfZnKkzbm8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174783: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=59d0d52c30d4991ac4b329f049cc37118e00f5b0 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 16 Nov 2022 11:35:18 +0000 flight 174783 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174783/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 59d0d52c30d4991ac4b329f049cc37118e00f5b0 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 39 days Failing since 173470 2022-10-08 06:21:34 Z 39 days 65 attempts Testing same since 174783 2022-11-16 01:10:10 Z 0 days 1 attempts ------------------------------------------------------------ 1706 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 162594 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Nov 16 11:42:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 11:42:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444274.699302 (Exim 4.92) (envelope-from ) id 1ovGnc-00078d-Mz; Wed, 16 Nov 2022 11:41:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444274.699302; Wed, 16 Nov 2022 11:41:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovGnc-00078W-Hl; Wed, 16 Nov 2022 11:41:48 +0000 Received: by outflank-mailman (input) for mailman id 444274; Wed, 16 Nov 2022 11:41:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovGna-00078Q-CV for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 11:41:46 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a34a77ce-65a3-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 12:41:43 +0100 (CET) Received: from mail-bn7nam10lp2105.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Nov 2022 06:41:36 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by DM4PR03MB6997.namprd03.prod.outlook.com (2603:10b6:8:42::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Wed, 16 Nov 2022 11:41:33 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860%5]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 11:41:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a34a77ce-65a3-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668598903; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=0GQYNXHK42E8YwJZDQuJ3dZr4sVEb1T9VwXr3ouvMdc=; b=cgz1cRXf6BRZkuYKdwuX2p8NI/5eWWuS8OPE1NFPIQaKG3VVBXSOEX1V XuhwTe84U1CKKO5ej/rUM0sbnHeC8nUU1N+3QKu9bZYrMPccx8Fo3Qxbq 2j/Ju9csGp1ykTD4IAkh7T1zW9xjguLtdPKxuPM1w0RJqJD9ttL4jXs3L c=; X-IronPort-RemoteIP: 104.47.70.105 X-IronPort-MID: 84518218 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:fMJRZaBgK2blSRVW/xfiw5YqxClBgxIJ4kV8jS/XYbTApDl2hDQAx mBKCG6POfyMamX3co10Yd/loUNQsJbXz4RmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpB4ARnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwy8doQlxz8 +YiCC0uVkGdgvuRh++eVbw57igjBJGD0II3nFhFlGmcJ9B5BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK/exuuzW7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr+TwHqrAttCfFG+3qc3g1jN/349MhoLRUPiham0jGWbUfsKf iT4/QJr98De7neDbtT7RQz+n3eCsTYVQd8WGOo/gCmPwKfJ5weSBkAfUyVMLtchsaceWjgCx lKP2dTzClRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85i8jVf5mGa+xy9fzRjf5x mnSqDBk3u1Oy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg= IronPort-HdrOrdr: A9a23:u0meYqsUTEVq1Br+ILGjn4VK7skCXoAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeF+aP3CB+R2zYZSndqza05+W bIvgTl7uH72svLiyP05iv21dB7idHhwtxMCIiljdUUECzljkKFdZlsQLqLuREyuaWK5EwxmN fBjh88N4BY6m/XfEuyvRzxsjOQngoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L gj5RPbi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZDIMu60vFjLA BdNrCa2B9kSyLdU5kfhBg3/DWYZAV2Iv5BeDlbhiXa6UkMoJkz9Tpk+CVWpAZ9yHt6cegF2w 2MCNUXqFkFJPVmEp5VFaMPR9C6BXfKRg+JOGWOIU7/HKVCIH7VrYXriY9Frd1CVaZ4u6faoq 6xJm9wpCo3YQbjGMeO1JpE/lTER3i8Ry3kzoVb64JisrPxSbL3OWnbIWpe2PeIsrEaGInWSv yzMJVZD7vqKnbvA59A20n7V4NJIXcTXcUJspIwWk6IoMjMNor239arOMr7Nf7oC3IpS2n/Cn wMUHz6I9hB9FmiXjvijB3YSxrWCzjCFFJLYd3nFsQoufsw39d3w3koYHyCl7G2ACwHtLAqd0 1jJ76imr+npACNjBT101k= X-IronPort-AV: E=Sophos;i="5.96,167,1665460800"; d="scan'208";a="84518218" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OF248NJTOSve8giP5PojGku29WpvepGNAZsPZ2JV2eA1rLzM9MsEWmFaoE0wXxV997jtr2yO0+D6jru2yPZrSGY49e918V4t0Ia8Sbj3s7iK+/Ql2NNviK/tCQfygDrj+0bpU6n+zefR3U3KFyYmBC0OPfrnBScMdwbdS+5KtykvSQZdKxCnR6EZSqSaTYeMMrXHA01qQ1k5koiflSqG0FhfzKfVk9OTt9lVAJRhS7BYwkj4m0WXX2ewL9/scLE1xfUuykp/I0o62BZR3SlB6YVlu5MKRkzGaaJ4Y79GgtJ4ExtYPvjJeOVzZxL0xQ1PvH8dVLJonqyFabcrw//K0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0GQYNXHK42E8YwJZDQuJ3dZr4sVEb1T9VwXr3ouvMdc=; b=K46h1FerEnXIVwZI33aGYE1+1PMTo2s4jW7HXPVB1GX3TOnfyGeAKO22UoqNmSPR6OqXCGN9QxQa7jfHDM5PfLyuAKTyXFJdU16XC6zDUNzZak+25RvPsB0cBN+gmUHLgfsUsnWx71eQVKdcapsj5AVz+ZP7YPu8VGH2WndO349NJdpZFfF1ilhthJaH1vf/VuyIr8oPt93mmld4kXyoDj+x5JJGMdnaBRcnB6YxAMg9NjhahYGU36lwzhKd7zlVIzvZ/AA/JVSU/5IYhaF42s1Uvl6VZlsh25ElVO68LEAGhUXPKanA/yMUGdDmUV6ZOBOpdz+3OvcF5QFNDvpVow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0GQYNXHK42E8YwJZDQuJ3dZr4sVEb1T9VwXr3ouvMdc=; b=ji3JE9PIdPQo5mEK1hxFHhAs87k2oDxgt3g16XQAUSBA0LPJ4I9sZ27JNKUeTUEypr/ISOM4xO3wf67sy64bz1yAezh9D0zfp1Uk+/N5OGfGOnsGnk+Kf+Lm9caCJTinAoM5Pf8U3QzoWejpYUHTjIUzjliRaRQlvYujaG/3ikM= From: Andrew Cooper To: Henry Wang , Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH for-4.17] x86/spec-ctrl: Fill in whitepaper URL Thread-Topic: [PATCH for-4.17] x86/spec-ctrl: Fill in whitepaper URL Thread-Index: AQHY+HI5MxstOuNgcUuBZdmquEvEpa4/pLgAgAHHkICAAAOTgA== Date: Wed, 16 Nov 2022 11:41:33 +0000 Message-ID: <3d47369e-c4f4-be4b-3695-c9df831adaf9@citrix.com> References: <20221114214358.17611-1-andrew.cooper3@citrix.com> <780da682-806e-6ada-eadb-018579d0e808@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|DM4PR03MB6997:EE_ x-ms-office365-filtering-correlation-id: 6464c57b-5094-4461-be7e-08dac7c782f3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lRi6yEnYxRvN6hnEVz/tF3UB+3k4didAk4B0+WtW0O7bgcILTw3tfrGvfoZc+mWmNewsc27Sac+MB/bqN1W8/feBsWo8AvJbXZWjFbjYSD0S1v79Rxaivj7sbWXKvewN0wenaNdCWv6xIxCS31vxiVv4qZMHsWMZ+SU+bQkF8UJS7ACXB6wPdhN1f3rNeGcwK4IBtYrGlOiE48+w3PszS1FDE7ledHb+G+GN4BhHDEkzqXQkPBPqWZHexP9+t7b0BtJUMd+GDO4HVZ87hJMHFCEPXJBKNemuw+NPlRaGll8rxYaX3kFsRIhdcmPivnzg6hkPIrhUy1tSyCdNWkYTkiVkrtVwtdqQDSALJZAJti4MjWx7riDfUmkhEvQWBfqKDzXxF8xkUkkEj7/B8jCUT/p5/PlH2VvYvGOV+b3IWYm6xMt+QeJ59m+5M946ByzQyZSUT2hLTpVEAHDlA4jCmqG5NsxMqnqR3fTiE4sLkpf9jwRU4rKXovGVRep4UnS8zR06HilY7n4Eckq9Z/4tz92L0seA3PDZPV1DMHTCYZEEoz/Y8pVSZ4IO5+UEK97jgLiMBr+/Y3HsyatK6/0qhv0WbHJJfvTzX718swne9aWr3rQwDjyUlC89eN35vI5uqKIg3JPAwUGU4xTQqxwPz/nKO+M817vw2ylGpMj8LcoGxgaXzDR34mCzylveIwm1fbUlJDVN70vwHdKjgI3T917Zq6oRg5bVUGeMK39Cv+BliaCHuVVCRMMzyqbT1ibLCBQq9NtRlqRH+2BPjMbvM+10fs9B3guHD1pBKRB++W+1PLkJsFSD8CYRFUs+RGQwIB9nYuYpP2Xmu+IakUAgDA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(366004)(376002)(346002)(136003)(451199015)(36756003)(31686004)(86362001)(31696002)(2906002)(478600001)(82960400001)(122000001)(4744005)(38100700002)(8936002)(38070700005)(83380400001)(186003)(2616005)(54906003)(110136005)(316002)(91956017)(5660300002)(53546011)(6486002)(6506007)(66476007)(64756008)(66446008)(4326008)(6512007)(66946007)(76116006)(8676002)(26005)(41300700001)(71200400001)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UUhZeStqZm90T1lsY0RIYWwyc1ZGMTVPc3hDdlRiZ09sMEdGZTh3bzA0VXh6?= =?utf-8?B?R1NlS1lIbVExM0FieTR5Nll6WWtFTlVCbTZJbGphVlYzU0xiUnloZlVMOFF5?= =?utf-8?B?cGlDYjJFUjFLeUs2Zk84MlhsQ2F1eFk0QVNFRDk4blRBZDVUOHZJZ2lhcE5p?= =?utf-8?B?d0E3YXlDRng1eWljRTV6TFZpZkV0THNBVDIrUTNob2xSZ2swT0NHQ3VZSW5G?= =?utf-8?B?Q2FhaDZKSFhMVGpGZWlKR0V1aEtmWjFwVjJrSDZBOXFpR0g3ZlQ4UGY2d2dB?= =?utf-8?B?aGRvVDlxMi9hVEw4cTNjbjMwdlRhTE11QkVzS1ZaNHNPWjVHd2d5K2Jmak5Q?= =?utf-8?B?NHpEa1YzeU5GeUd2bjlqUThRRnlOckFWaEJIT2cxdmplZEVLNDJXT0JuZHdD?= =?utf-8?B?Nm1xR1FpeUlXYW9uT2FEUGhhQS9iMnc5blBjMDkyL2tRcUFOdzJtZGtGZW10?= =?utf-8?B?ZlJ6U2RieWVZelcvOVY4UnJycmQ0Z3dPc21abzd4QVpZRGc2TkZMbnV1VG9C?= =?utf-8?B?VzNmV1RQWGU5TGxmamlNU3pNRVN5aTFBbjRBTXcxdXBTUDA5Z0JLT2pQREhh?= =?utf-8?B?a3RHS25wQW4wMDJxMy9la2tSZDh2VDRoTy9XVkNPNjR1dlpzTUtJUkdtampF?= =?utf-8?B?UldEZUdGYzNHYlRRcFZJM3pEK1Q4U0tPeGczTHVEMmVMR0wvV09MMVA4TFNh?= =?utf-8?B?dW1YVFZVOE5KRHNseC8vblhQbVBkV2k5UlVWeEZKRnRMWFgyT1ErWk5iSm5Y?= =?utf-8?B?NkZaTStkaFJkclVpR2RxWkFMZVU5SUhCdnRtR0g3TUkzSU9qbE5aYndOQ044?= =?utf-8?B?aHVaMUdnc0svQnlmNWxuY2dFSlBTdXdRajJzclQ0c2plbVZnaDgvNHlsOHdF?= =?utf-8?B?Y3NhRnRma1V1Sml1Z0tMbTAvRTNJTVBHdTV4VUhxSElOenpRNWFTWDlZT0Ri?= =?utf-8?B?NEdRMFRuNXN1WmN5WXYramVsbHVWS0tsRGFOVjJUVUtnSGNGdGJubzBaTFJ2?= =?utf-8?B?L1A4Rk5YZE5Eai9HMW4waFk4RkkyQzZyWHI1MjNxMzRvT2VQSHRZdmxORXJj?= =?utf-8?B?Y1RYN3JLR2NRMGh1U3h6c3dEbHpvOGlSMno2WXVoL1Z5bERsNzlKcUZDcXR6?= =?utf-8?B?ZVBRbzhwWDVRMWdGSkR2c01ma0N2d2gwZjBaTWsxZGQ4Y0pCdTlGQjNBQXFS?= =?utf-8?B?djZudFFwSXZ1Ymw5azJIMzgzSjJsQk82MGdtNnV4WFV2UkdDUy9NNXAwRyta?= =?utf-8?B?OTdaamlTNGYwWEVHR1lpM1FQcjlURUNuby8yWHhpd09ybitScUw4cCtydEJT?= =?utf-8?B?cjR4TG15OE01bjhWYmFueGNyTG9Od1Q3aWdzSVQralE1RXI2eTExdGJabGNx?= =?utf-8?B?N2JnZzk0OUlCbVEreXI0amlwQUpYVTE4U2t2V3hETlUrZ0ZGRGZVOVFUZTBr?= =?utf-8?B?MThmSTJuZGlTNkVuVG5zVmtkV2w0WGFUNU9EM29zdEdxNTcwbU1HMXJxaGNu?= =?utf-8?B?R1FzRkNibFRvMjY3T1p5U2pMdmdVaUx2dFkwVms0a1N2QUFMMTBnaHpFVGZB?= =?utf-8?B?V0p0dEljckJEQ3hKaXBTQzRRNHpUc1NRdFVvaDJnMUp5WnFuTGM1V0RhMy9y?= =?utf-8?B?cG1scXJWcXlZNyswUEFzZ2NhcGNTYi9aQ051V1UxQnNRRk9qVmQ2aE9WbHEx?= =?utf-8?B?UW4wQmtnODlSdzBzTWhwd1ZVRkhaNTl0L09ZTTdJa2wzZzVVdTMzKzYxSFBK?= =?utf-8?B?d3lSWkRZUjdlVmNjSzVtblZFZ3hNU24xVkRNYW14TGxTNlFuaHZXTURPTjhm?= =?utf-8?B?ZThYdlFKTnE2RVM5cGkyNzVVL215OUtlRjEvUFNKbW9GLytKQy81a25LcktK?= =?utf-8?B?Y0s0b2JCYUVLSW9vOUxhaXl0dmltKy83ZEVtQVZVSFdKZ1lsYWZWcUNLenhi?= =?utf-8?B?ZTdGc3RjdkF3SWN3QzQ2SnB2d1NBS1hXQnJhQnpzNUdmRXkrOUxWSzJsUi81?= =?utf-8?B?YTNkK0pvNmJNc2x6cUFtWHJ6cWtXUXFPZHJZQ0VYWmZlYWs4S3RFaFZ0dUZk?= =?utf-8?B?VzdzL28wRmNybFRMS1k0NklOSjY5WmR2V1J6MzRPb3p2ZFE0M1phY0ZFMW03?= =?utf-8?Q?HxVdavkhMGLdnb0+QEw7QKFFi?= Content-Type: text/plain; charset="utf-8" Content-ID: <7479A6C0626F414EA0A21C088B1BDB88@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: yUD2EaOV9CEVK/E8YwtN50WkISzTCsGLVdqGhebi2Itdr4So8Mks9TLz4GLc05zFJVIsXmi3xNDAgEsll39fPZN055/36w0/6FhNT3bCDc8iOPa6JRyOgGTJSE7Wju52KoXtls6oGAtyVm9dSwGRdoMX7nzHdePTQpNmSltB6CO7DlEYjeRpq3DxwnUYUdJIf6aEnUrAgXOO1hWeaBYMuusBX+j10wFAhBRujTxS0zsCNfkq2mbZU7KEiYqYJ2vQc8RvkbDS/DnHo8/zqGdDARG1tXinUV6aIHMTpthENakjzzVkc0DGSsLhr2k8QryJCfCS8wwjQWkOd87Txgp6VRgKAmJEDqv5yykwFmmHrgNLnsJWPNs8JsjocRlecPLH/Hnu5LQGlaaUm/x0CzhehBi9UYBlkw8Q+vU7AZhFC4FO60hwJOZ8fWFaCYE/HweP5x1D/ozQpOiJ4FccZ9tWDYPfQ0fwOPbMBOee2Jfauv9zQ/3iGGltPiUrn9qIDoY7dcQ71jHh+6g+rkrQpCbx861ez3DrBsuaoBXaZTBCdZkKPQq/qserYAOaUS5fchvPX6yKnfko8tSGDMXUFqX8nZBcKGCYdtFHXj9LZLCqsVbYw+JuKT4utxpZwPRxfH72dGwz9eftXqtXFMX4Q9Z9MPD8h6vQL/EeiVgrXexFhEwOwqdELAuKp/2oYVg6CH42iws+H/Kp4T81lNic2REP4Z798TYDwT/kxWZzy0PeCIbYS2i4TT0An+ZA/2KVrpQf5uf4eXNEubKm/RGlmcC+vPFDRHVSCJ1u30WvbFfQn/nsexsi3ydsq81oEuAG3GBnuNC+j9J+gS57c99g0+emyKN3MWSV7+JUCpM6QWNor1k= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6464c57b-5094-4461-be7e-08dac7c782f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 11:41:33.5152 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MBmINBesqpyG22a9ib1BsKOc8W+lCbu7cvHWBopWNV1C/GQkbxSFSnq8NVgi/L6OZnN8Wv746mhIi3S9dyTH5UQhws/hS8//smEYKUxBfqI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6997 T24gMTYvMTEvMjAyMiAxMToyOCwgSGVucnkgV2FuZyB3cm90ZToNCj4gSGkgQW5kcmV3LA0KPg0K Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4+IEZyb206IEphbiBCZXVsaWNoIDxqYmV1 bGljaEBzdXNlLmNvbT4NCj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggZm9yLTQuMTddIHg4Ni9zcGVj LWN0cmw6IEZpbGwgaW4gd2hpdGVwYXBlciBVUkwNCj4+DQo+PiBPbiAxNC4xMS4yMDIyIDIyOjQz LCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4+IC4uLiBub3cgdGhhdCB3ZSBhIGxpbmsgYXZhaWxh YmxlLg0KPj4+DQo+Pj4gRml4ZXM6IDlkZWFmMmQ5MzJmMCAoIng4Ni9zcGVjLWN0cmw6IEVuYWJs ZSBaZW4yIGNoaWNrZW5iaXQiKQ0KPj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFu ZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+PiBBY2tlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPg0KPiBSZWxlYXNlLWFja2luZyB0aGlzIHNlZWluZyBzY2lzc29ycyBsaW5l IGNvbW1lbnQgZnJvbSB0aGUgb3JpZ2luYWwNCj4gcGF0Y2ggIklmIG5vdCwgaXQgY2FuIGdvIGlu dG8gNC4xOCBhbmQgZ2V0IGJhY2twb3J0ZWQuIi4gSG9wZWZ1bGx5DQo+IHRoaXMgcmVsZWFzZS1h Y2sgd2lsbCBvZmZsb2FkIHNvbWUgbWFpbnRlbmFuY2UvYmFja3BvcnQgZWZmb3J0IGZvcg0KPiB4 ODYgbWFpbnRhaW5lcnMuDQo+DQo+IFJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5 LldhbmdAYXJtLmNvbT4NCg0KVGhhbmtzLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 16 12:01:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 12:01:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444282.699311 (Exim 4.92) (envelope-from ) id 1ovH6B-0001gv-CU; Wed, 16 Nov 2022 12:00:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444282.699311; Wed, 16 Nov 2022 12:00:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovH6B-0001go-9f; Wed, 16 Nov 2022 12:00:59 +0000 Received: by outflank-mailman (input) for mailman id 444282; Wed, 16 Nov 2022 12:00:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovH6A-0001gf-HQ for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 12:00:58 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5442f264-65a6-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 13:00:57 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BE7B11F920; Wed, 16 Nov 2022 12:00:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 958F5134CE; Wed, 16 Nov 2022 12:00:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id udgsI/jQdGMmfAAAMHmgww (envelope-from ); Wed, 16 Nov 2022 12:00:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5442f264-65a6-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1668600056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TaAYGyrK+gIkH4bFpXR1icxkafDb9eg/FxEUQ9skTfs=; b=SOtoES5Q5ipivJ35qSqTxfv5+AoEThrnnoou+X6m6xTHbdx+vgUMXn3AdSOX+DDuTMSZYZ xtKuWmoSxGRceSkOn/CPK4OXP0zsj2gYpnIJAS6Q4wVexRs6McRVEMsFZSifBKyADXrC65 33z0+a3A44nNJCREnmrTDKMc7M2v3oM= From: Juergen Gross To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: [GIT PULL] xen: branch for v6.1-rc6 Date: Wed, 16 Nov 2022 13:00:55 +0100 Message-Id: <20221116120055.4299-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.1-rc6-tag xen: branch for v6.1-rc6 It contains two trivial cleanups, and 3 simple fixes. Thanks. Juergen arch/x86/xen/enlighten_pv.c | 3 ++- arch/x86/xen/setup.c | 3 ++- drivers/xen/pcpu.c | 2 +- drivers/xen/platform-pci.c | 10 +++++++--- drivers/xen/xen-pciback/conf_space_capability.c | 9 ++++++--- 5 files changed, 18 insertions(+), 9 deletions(-) Christophe JAILLET (1): x86/xen: Use kstrtobool() instead of strtobool() Juergen Gross (1): xen/platform-pci: use define instead of literal number Marek Marczykowski-Górecki (1): xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKALL too Yang Yingliang (1): xen/pcpu: fix possible memory leak in register_pcpu() ruanjinjie (1): xen/platform-pci: add missing free_irq() in error path From xen-devel-bounces@lists.xenproject.org Wed Nov 16 12:21:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 12:21:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444287.699322 (Exim 4.92) (envelope-from ) id 1ovHQ8-0004XM-1y; Wed, 16 Nov 2022 12:21:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444287.699322; Wed, 16 Nov 2022 12:21:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovHQ7-0004XF-VC; Wed, 16 Nov 2022 12:21:35 +0000 Received: by outflank-mailman (input) for mailman id 444287; Wed, 16 Nov 2022 12:21:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovHQ6-0004X9-Cv for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 12:21:34 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3347b39c-65a9-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 13:21:32 +0100 (CET) Received: from mail-mw2nam12lp2049.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Nov 2022 07:21:29 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MW4PR03MB6922.namprd03.prod.outlook.com (2603:10b6:303:1b9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Wed, 16 Nov 2022 12:21:25 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Wed, 16 Nov 2022 12:21:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3347b39c-65a9-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668601292; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=gbJg46Owb4LRu9L8x32QNFnfvyM2Z6HugNVpo+DEoLg=; b=cqBR4ccPuIgX1DVSoHyqwwKrG1YcjZbo31NPHz8GsUMxjMog6S6GIU8n RXziDRjJyiY6zSIRXNJBxIE8NtaijTWggdnJsxMrdUEF9bImd5kpOqiT9 1WDPB35BX8MxX92DErvcGNX5xbNeVZHffYagu9XOSHOb6YyZSjF1Uao6j c=; X-IronPort-RemoteIP: 104.47.66.49 X-IronPort-MID: 84932978 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jmMVCaihVsOWwgiDdFuueSUGX161RBEKZh0ujC45NGQN5FlHY01je htvUGzXPvbcMGr2Ko9xPI61pEtX6pPVzNZlGVY9+yo9Fngb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QaAzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQbEBERSUzY2t6L/6Obe8BO2u4AIJDSadZ3VnFIlVk1DN4AaLWaGeDv2oUd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilIvluS8WDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnzX+qA9hDS+3QGvhCnmOiyXEzVxcvf2C2iKa2l3SkfPEOJ BlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQN4sudIyRDcq/ kSUhN6vDjtq2JWKTVqN+7HSqim9URX5NkcHbC4ACA4aud/qpdhpigqVFooyVqmoktfyBDf8h SiQqzQzjKkSishN0Lin+VfAgHSnoZ2hohMJ2zg7l1mNtmtRDLNJraTygbQHxZ6s9Lqkc2Q= IronPort-HdrOrdr: A9a23:bHo+jatDTlA9N5prwtnE9VpO7skCAoAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBHhHPlOkPEs1NaZLXDbUQ6TQL2KgrGSpwEIdxefygc/79 YcT0EBMqyWMbESt6+TjmiF+r4bsaO6GcuT9ILjJhlWPGJXg/YK1XYDNu/XKDwDeCB2Qb4CUL aM7MtOoDStPVwRc8SAH3EAG8TTutHRk5riQBgeQzoq8hOHgz+E4KPzV0Hw5GZXbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7hGhdf7zdNHJcqUzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iEnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjXuVm2Hqr8DVTC8zT5Mpv/MuTjLpr24b+P1s2q NC2GyU87JREBP7hSz4o/zFTQtjmEaYqWcr1cQTk3tce40Db6I5l/1pwGplVLM7WA7q4oEuF+ djSOna+fZtaFufK0vUu2F+qebcLUgbL1OjeAwvq8aV2z9ZkDRS1E0D3vESmX8G6dYUV4REz/ 6sCNUlqJh+CustKY5tDuYIRsW6TkbXRwjXDW6UKVP7UIkaJnP2rYLt6rld3pDmRHUx9up9pH 39aiIYiYZrEHieSfFmnac7uCwleV/NEggEkapllttEUr6VfsuaDcTMciFtryKamYRgPiTqYY fOBHtoOY6dEYKXI/cu4+TfYeghFZBMarxhhv8LH3Szn+nsFqrG8sTmTde7HsudLd9jYBK1Pk c+ X-IronPort-AV: E=Sophos;i="5.96,167,1665460800"; d="scan'208";a="84932978" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XpBVgqQwULCPefJ5P29hQi8rbPHtR1TV+ZCVgNrhCSK92hWuMIE2Jhz7FzncSXyEi8matPwS93g7AqI5UTwGuElt22Agd81yVctbGwsMx+OyB2oWOMP5dW0INeV3cYsgjFX7/CmDwM5QNRXHWnq+ACH8zgFHI7szG2IXMpg5MUzJ5KOCVnjKHzxerpsVIpIz/LDc6XeBQgt7RY6ssKmHyDf2xyF85Z8MwNqwHbt4BTEKNza97I++k1s9Wqb4Hm261W1fvyorlWMZBT9fTrN9U6zaI0t1iRIp3MTUNSPPsEgFCJgHYOycnjlIUytm7D9bp7QOD2RB1w2H+3dNkYT+LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H0GHGNTLWnzPh0GtHLDMx3fr+H1OyOCnHcmXOA+Mh5Y=; b=cDiKXgfdmo5pR0gAPQkuHxXqvCvgAEk7TEskk2X5EIFgaHEV1PTBkKrKGxBMQcq/SCf+4JzYpgHW1c8DDyWP3pWXTfWcm5luZK/xCE2HmCVn4ytR7MWG9RHJVytzyU5ZKdgrTBlrLhqA1yPy3avLK7XGiMDpSjLo5gXpIL8oNCxt1w7fiaKjaMNuEBv90ojaB0ppnu0S1K1Jus7COMoyedil3i27JB2QrlTn7SGGDrJvpHSK0UqqwLl81olHIbnLU9mKTpe2EPRDemRRqhsBNKoNc+drxEQ7I1yZ2e8rAOt3vAWRFsjxDbs2e1QI+guimOuyg02YQhg4Hf/58M4E4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H0GHGNTLWnzPh0GtHLDMx3fr+H1OyOCnHcmXOA+Mh5Y=; b=bWxgeg2HBeH1f7Mji9u5W5mCKbQjC2GdO3bzmJV2Gj+RCZC/90wA8rpYsdT7l0kXp3xM/FZhN927LSfkMcr+HYOAELPefBU7ARSo+WGG0uktVGg0P5hp0AdVEISDXdLmpiymC3hxw8jf1DiAqg/cto0os6jFGbvWLzJw802cc+0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v2] x86/irq: do not release irq until all cleanup is done Date: Wed, 16 Nov 2022 13:21:14 +0100 Message-Id: <20221116122114.5260-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0531.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::15) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6922:EE_ X-MS-Office365-Filtering-Correlation-Id: 3229656e-1a59-4a20-288e-08dac7cd1334 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KKMbAZ5V/dmwuSBPKw4r7Ktm2JygOEBg2WeHjjgpndmKv+F/xg4V2KmTv8mviPZMi1WUIQbPFBmT8vWQUwMmIajMwSx9zv7oqBo+dUBvlAmyVI+0ysv/pLqyBiqak2mCuU3UOkD4Y4uXFlVhS1lx3KJnb/ZUjgrmJHM0Et3K8zIZ++7Rkgq92TdVIff191AZe1o47BWZf6eMnc8aWyQhYEnToJMam0SGUilmZ9BLppezVeAHeJYc4PpkELSJ637v2G/wTptU84WlFDV5Hs5xCeufcF0PUSO/YyLbkBiwobfExxmFSD6oO6aIosmNPFJZ0ZYOGYBdous+hJIhmsE0Mq5lxJH6LEv0j/eH12pfOp+IuAQZ05g5F3CBn7QHNQ1in0ZOL60c6A9lkhjZ0bmA78pFmDbKuDw6/cSXev2GxFjmUdTDc+/uA4ClxDy2kXFt42rlTfz4YoRU5hdFjVhmRV1boIJ3ZKzpKa4uljM9qMm/QhMaD7S2IqAhaG8l7D/N3i/vCNDvj32H72AQ7CZmVU3UMxlQEQQzZPOphdva1/9aiJMwOiuoEtoo9hY+zovya3Ce6uhTXZ8RFAA9OINKZ1JqxWvKE2yfnOnAzwDPvimeI/bUjRNA4QvlMJiivEDCOYVVYukxCV4DwF7IjnabLN9Fwe9GrZr/+zqpHXuNlV9rpo7aMByIqwYRZkrps2i4ZUzTmjyWdTnYOxKspsHXlA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(366004)(136003)(396003)(346002)(451199015)(6486002)(478600001)(6666004)(6506007)(6916009)(54906003)(66946007)(66556008)(66476007)(26005)(316002)(6512007)(8676002)(4326008)(8936002)(36756003)(2616005)(186003)(1076003)(5660300002)(2906002)(83380400001)(38100700002)(82960400001)(86362001)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0NGeVF5NWs2WVhlNXJTVE1yUEUzNEZ3VWkxcG54aFpUZUptbnp4eDhPcFoz?= =?utf-8?B?NEp4aEd3UWNVSlV2MVc0UjByWm0wekFMRk8rcStBeS80bXl2V0o0RlpBOTg4?= =?utf-8?B?ekp0UnhjMXBZQWU1dmlPQlpmSEJpaGFMWmxpUDRtbTFBQ3U2bmFMbUQ1OEVQ?= =?utf-8?B?cURiL0x5SXJQYlhYNUJDNnNpallMWWErdk1aQVBrbnBYRUNMRDlEM1dQL2ZB?= =?utf-8?B?U3hNQTJjc2NwSzNBcms2azBLL3NSMjhPOU5TdVI2TUI3QkxpWjE3VG1STklI?= =?utf-8?B?QmlzYTJRYVZvU3BiSXh2TWlXNVZ1UTR0dnVneFJuVW9UUkVDS0trQkNlUXNv?= =?utf-8?B?RHdzOWJsbUZpblhEaHJOQnZ2dFdDSmlKblBTSjZxcDNheWxtZjlEaDFGaUtI?= =?utf-8?B?eldTUG5yNlNoSjBYTTRtK1UydCt6emlLU3hud2JXbmxmNW4wSmVxaGxjTVFn?= =?utf-8?B?V3BqSlEyaG5KZzNIeWk1V0drQjVhYnBuMDhiNWNBZFE2V0pKQUNJZDlGYXAv?= =?utf-8?B?YnFLYzRFWUJrUGd5Z2RIS2J3b2l2dWFtY1M1VUtLNjNQZmpuUlRPY2dHeXNm?= =?utf-8?B?eXVpM1FvZnhzYmRaczBJbzFwaGRKT0ZnaHp5aVFtd1dXQ25yci9RdHVHZ3B3?= =?utf-8?B?VU51OC9xandCTHlYS3o1aEtaR3ZZN2NLR0RZMzZnNElvVThxVkhTVUpSMDlB?= =?utf-8?B?WXVyTWlXMmJNRERuYlgyNjBXNU5iNFpGL0tZL2dwQ204ME9ucHI4NHNOckpt?= =?utf-8?B?WGRyc0FLeWQrSlpYL1lPSmNDVmlHcnJwenJkWFVZcE51aU5DLzdWWjlFNXlv?= =?utf-8?B?Sm5OUG9rUmFRZlV5WTEwOXkyam9pMXYvWWJOR1Q0RjNsVWgxTWljYzl1SkJt?= =?utf-8?B?Q0FJUElkb0tRMUoxODBmd0dLajJVQTFrV09tRkxCZFdSVGFBb0dZb1U4VnVy?= =?utf-8?B?QWxCVHdhck1EU29GcEZYRGtYYmY2dUc3R01EODhTaE1oYXY4S0JycUdOS1FV?= =?utf-8?B?MEtRMk14Ri9GWFZuSzExL0ZSeE5nSXJ4Z3luYUdEeVFGeHQ4MXVhOWFURnJP?= =?utf-8?B?U0Ryek1YV3NzVnZZR0l1VjdhVExKb2FpV3l6cjE1Ylc3Y0NUMUZaeFhNRmVw?= =?utf-8?B?YTVDclBkaDR6MVgvNmd1Uk1RQ1F3T2pybFRvUS9SaEN1ZXFYeUtQblp1Ly9u?= =?utf-8?B?TW5LemZERVVaQUJyeWZBV0ozMmN5S3c4YkNKV2NjckE5bkxpcmduV0l3eUFV?= =?utf-8?B?OFJkTWdKS2R6V01wUDZGVVRHd244cllna2RheUdUcWtHZlNDRWlGMHM2cXNz?= =?utf-8?B?ZlNtenFhUjZYYnZpMDR4bTFGYlJNcy9xUDJ0TjR1bzZ1b1V4VVZZOG5ITHMy?= =?utf-8?B?SWFKeGVMV3RPM21rYTlVYWlkTXFNWUtVbVJPUGNkcG40N2pKMFZxR25aSGgy?= =?utf-8?B?RVl0SUlmWnhjNFM5WGh0TW9HcUF0ZzVsMGlDUmhHeXRKNFNqdkgwTXp4RHVs?= =?utf-8?B?Z2gzVDRhOTl5bkV5QVVEM0ZtRUlXeWdCYndjNG1kMWtFQ05xSUZiS1hQUlM0?= =?utf-8?B?ek1jN1RraCt0ZUJaRU5aT1VvQjdRNnd0aS9rTnRuSmt3YTRIWTJzSWhSNzJY?= =?utf-8?B?RnE1ODBob1p1MHZneEVqcUU2NWZwQWNRU2tHZjVicjRicUROVXRPOG1FNTNz?= =?utf-8?B?SjhuQ3VWMCs5UVo0eXhNekVuZk5PUHV5OWN1THpnbndhbThxaGk3ZVV0ekU5?= =?utf-8?B?RXAxWlltaWtxanE3eFozblZLRk1DQVBiai9tL2xxVXVBTmlMNmZEMUpmcVVh?= =?utf-8?B?MkNLYk1LQzlENlZLYytMeThpMWVFNlhna3BKaUVMMzNDRXV2YjV5bzU3RGFi?= =?utf-8?B?dmkza0s0djM2YzBwNXhsWmhIa1JLTWkxdy9GZTNRQ2FsL0tkNnV6SG93WjIy?= =?utf-8?B?SFRzV0xYS2NtTXdSN2szYVlHUFRKZmRBc3hvazg0L0JoVGZxTHZlM1Z6OXFS?= =?utf-8?B?YldRZWh3N1NUZG1FdkJNbCtQV2hrc2UxeHR3cUNNaDdtaFBwVGptTGpoODIr?= =?utf-8?B?NG9ocE16WXd3UlNxMzg5TnQrRTQ4aUJuUEs4YTQwazNoSm5INVhGMHc3aTZx?= =?utf-8?Q?kfkEj0+Y3ROWlw+ZB0EAQ9mCu?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: nYg5Jq2xTiuBB/yNEzBd1gcg6HpeO3+ZmnVBsVtDZzcidbPmteiX510gsz/NlNAnwAD89aMTXOL8cly64O0dVdLXMxFj7G8TAXnQiT+rtamZJRUX2ttsolFLdfgkOVVKPnlnqurit2Cr5/SfKrh0RgF0fp6iCqztI+ml0EvzQ1KezyVYjz8/iIaNQgqrwXMIPukceePD3tRt+ngI78TvHgHmBtt8NIGX98tBRnRjhJnv/cDTlDX42GbH4vMBrtXtMojogsKWomh7n6Oi1WA45ZtEST44/yRbPimFzC7t1t0kJYbxexGarF4j+9lXNoeE9iaZJHX0BWKagZL3k05BgDsCIJ0T8dlo0Gk/hnAhwAG7vW3GET9KDURdcnDl17HdkKMsTiQOK7ub2P+TIL3AdiFBS20PIcT3zUpTx/cwsTovyYrW7RedsiAjCsb3r4g6GqsALKMKQwrVi/NxGUSmTK18FM8M9hny44X5wHF89dmTp7ywtm4ch4WKP4nCxVUSU71osKZJGNUBPm29xfkPFX+FG5QV7yHmn5FRIpDEQ0hIw9Ienph8nBuI2Xc3K7IaTEjrKevb1tJgacBR4/KaRVmiZPvqHTvRTsmnB6LvvLfCv0CkaQrja3qulqedvvLqgY7GUvGwvV03hRP5ag/N4wbCIMrxNhNdmyzxQdg4IKxCYIIGsAqjrYNabU110An22qSW9khqGBjbMS4flJIjDDfCK0CgMl3xrPEyxtmX2CXbYHEOBfQ3H7tieRGJGtccp6q/nb+ixd1beeLzuhVFzHSz6TSHS8uDxAjS9C3i2xX5t87NFy+GNI4d/cAVwlTu+DKo1wq1oNfz+xq9KVRRrQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3229656e-1a59-4a20-288e-08dac7cd1334 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 12:21:24.9202 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JslXGUR3i9xfST9+MWoG7w9YUWXSaMtauytY1RAhylHLKihjVSmALqfXVuKo7INcmiB8aXNbpWUvqoHNh5zZ0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6922 Current code in _clear_irq_vector() will mark the irq as unused before doing the cleanup required when move_in_progress is true. This can lead to races in create_irq() if the function picks an irq desc that's been marked as unused but has move_in_progress set, as the call to assign_irq_vector() in that function can then fail with -EAGAIN. Prevent that by only marking irq descs as unused when all the cleanup has been done. While there also use write_atomic() when setting IRQ_UNUSED in _clear_irq_vector() and add a barrier in order to prevent the setting of IRQ_UNUSED getting reordered by the compiler. The check for move_in_progress cannot be removed from _assign_irq_vector(), as other users (io_apic_set_pci_routing() and ioapic_guest_write()) can still pass active irq descs to assign_irq_vector(). Note the trace point is not moved and is now set before the irq is marked as unused. This is done so that the CPU mask provided in the trace point is the one belonging to the current vector, not the old one. Signed-off-by: Roger Pau Monné --- Changes since v1: - Leave the trace point at the same place (before freeing old vector). - Add a (write) barrier before the IRQ_UNUSED write. --- I've only observed this race when using vPCI with a PVH dom0, so I assume other users of _{clear,assign}_irq_vector() are likely to already be mutually exclusive by means of other external locks. The path that triggered this race is using allocate_and_map_msi_pirq(), which will sadly drop the returned error code from create_irq() and just return EINVAL, that makes figuring out the issue more complicated, but fixing that error path should be done in a separate commit. --- xen/arch/x86/irq.c | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index cd0c8a30a8..20150b1c7f 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -220,27 +220,28 @@ static void _clear_irq_vector(struct irq_desc *desc) clear_bit(vector, desc->arch.used_vectors); } - desc->arch.used = IRQ_UNUSED; - trace_irq_mask(TRC_HW_IRQ_CLEAR_VECTOR, irq, vector, tmp_mask); - if ( likely(!desc->arch.move_in_progress) ) - return; + if ( unlikely(desc->arch.move_in_progress) ) + { + /* If we were in motion, also clear desc->arch.old_vector */ + old_vector = desc->arch.old_vector; + cpumask_and(tmp_mask, desc->arch.old_cpu_mask, &cpu_online_map); - /* If we were in motion, also clear desc->arch.old_vector */ - old_vector = desc->arch.old_vector; - cpumask_and(tmp_mask, desc->arch.old_cpu_mask, &cpu_online_map); + for_each_cpu(cpu, tmp_mask) + { + ASSERT(per_cpu(vector_irq, cpu)[old_vector] == irq); + TRACE_3D(TRC_HW_IRQ_MOVE_FINISH, irq, old_vector, cpu); + per_cpu(vector_irq, cpu)[old_vector] = ~irq; + } - for_each_cpu(cpu, tmp_mask) - { - ASSERT(per_cpu(vector_irq, cpu)[old_vector] == irq); - TRACE_3D(TRC_HW_IRQ_MOVE_FINISH, irq, old_vector, cpu); - per_cpu(vector_irq, cpu)[old_vector] = ~irq; - } + release_old_vec(desc); - release_old_vec(desc); + desc->arch.move_in_progress = 0; + } - desc->arch.move_in_progress = 0; + smp_wmb(); + write_atomic(&desc->arch.used, IRQ_UNUSED); } void __init clear_irq_vector(int irq) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Wed Nov 16 12:46:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 12:46:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444291.699334 (Exim 4.92) (envelope-from ) id 1ovHoB-0007T9-26; Wed, 16 Nov 2022 12:46:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444291.699334; Wed, 16 Nov 2022 12:46:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovHoA-0007T2-UX; Wed, 16 Nov 2022 12:46:26 +0000 Received: by outflank-mailman (input) for mailman id 444291; Wed, 16 Nov 2022 12:46:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovHo8-0007Sw-VP for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 12:46:25 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0611.outbound.protection.outlook.com [2a01:111:f400:fe0e::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ac06818a-65ac-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 13:46:21 +0100 (CET) Received: from DB6PR0301CA0098.eurprd03.prod.outlook.com (2603:10a6:6:30::45) by VE1PR08MB5775.eurprd08.prod.outlook.com (2603:10a6:800:1a0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8; Wed, 16 Nov 2022 12:46:19 +0000 Received: from DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::71) by DB6PR0301CA0098.outlook.office365.com (2603:10a6:6:30::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Wed, 16 Nov 2022 12:46:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT046.mail.protection.outlook.com (100.127.142.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 12:46:18 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Wed, 16 Nov 2022 12:46:18 +0000 Received: from 908ce9058240.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A29A6911-F06E-4817-A108-11D6E13AAF22.1; Wed, 16 Nov 2022 12:46:08 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 908ce9058240.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 16 Nov 2022 12:46:08 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11) by AS2PR08MB10128.eurprd08.prod.outlook.com (2603:10a6:20b:644::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Wed, 16 Nov 2022 12:46:03 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f]) by AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f%3]) with mapi id 15.20.5834.006; Wed, 16 Nov 2022 12:46:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac06818a-65ac-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+dLhTdJBSaGlTC9SPbG4miWt1tmd9z3Pv/nDZiX0/JU=; b=xcrdmTA8WhUkWzGX0smlkZChGUwCGYroe/GDvTQ4yjqYH45dfGOnM9HdWaPxUlIZAhm9qfSsi99PnG9e9A/qoZySaetvQjEI4r5E4aOT7GiPo9334BRg4A5HhRt2QhgqJLKNK3a9PJBNCpHUPktgn0gV0ai8Yd8Dw9VplyRA/YU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 4529cfbc7e71ccb1 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e/OGiet2Vd/5Nk4cRQLDy7qY3BYVoHtrX7b4chBg7vBXXhyBvBDiYR/1YTHnV4Bp0fdUGaq60FTeyVaKbSH3tkD9uAWILFOfrzBdxSUdrZjtbXQxUt2m6ys0fomzyUslyyh5uLMUwU+PGYi8pzBdeUyfyOLceG2xxNbQHuWfcVXTSb8RwbN2byO5yGDrbpBKeU1DxNWlA5/ngMhWWeVVawKqmO90AxzIWdtFd4PwUT5cWKLFxtLPwy78pGkdaQJzUPz9cVc52d+I4yf6ecqRfGdX+DNIxkN+Tz821HpoZ2qJsJhBhCAdbK+IJ3BokcANd724XxdsAXsr8MJzrn6e0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+dLhTdJBSaGlTC9SPbG4miWt1tmd9z3Pv/nDZiX0/JU=; b=kCOoraC8rkqd08H5wmd44AUwARfKlf/rRyWzgk4cMvPNMiPv25Vgz9ZpmeUJz8iyXyCYaBObnEyYmXqNxoGomkUpb0u5BGc4vT14caY63Va0bjTRiNj9RoQd47krCWmWdg39KKp+I2vJ9q81WVV+3AhTekbOzBZErYFifzbhKB5xe07qweOSJyXdvP5a+4ZTNKNT3+XzezPH9ibXyrjl1XqUi+HuZj1wf8tDF5zwXcrixqIIgD1zsa3ujtbnnBH7ffUbJ95HBzVnEqOj4mbbUEQkJsnAT5EDXByDP9Ckj/Mcmwz06AxHcEDyr6OgCThpeZTvImijpqPAPLx4lEFGZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+dLhTdJBSaGlTC9SPbG4miWt1tmd9z3Pv/nDZiX0/JU=; b=xcrdmTA8WhUkWzGX0smlkZChGUwCGYroe/GDvTQ4yjqYH45dfGOnM9HdWaPxUlIZAhm9qfSsi99PnG9e9A/qoZySaetvQjEI4r5E4aOT7GiPo9334BRg4A5HhRt2QhgqJLKNK3a9PJBNCpHUPktgn0gV0ai8Yd8Dw9VplyRA/YU= From: Jiamei Xie To: Jiamei Xie , Stefano Stabellini , Michal Orzel CC: "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , "julien@xen.org" Subject: RE: Xen Arm vpl011 UART will cause segmentation fault in Linux guest Thread-Topic: Xen Arm vpl011 UART will cause segmentation fault in Linux guest Thread-Index: Adj0C3U97KqJOGXWTaWwFEv08mPlLwAAvb+AAAFgduAAAlWjgABJlSiAABB0itABDLR9UA== Date: Wed, 16 Nov 2022 12:46:03 +0000 Message-ID: References: <00764fe2-f78a-e5db-cb16-903ad1a5ec03@amd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 2F0EE120B6997D46B744967F00500474.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7696:EE_|AS2PR08MB10128:EE_|DBAEUR03FT046:EE_|VE1PR08MB5775:EE_ X-MS-Office365-Filtering-Correlation-Id: 947bb86a-922c-4856-fbba-08dac7d08eab x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ii9Q5iJAHlpKZ0A8KxHPGLcygbpVuneBijuNqdSzPdit3aE4BBIjA451sApEjRiN7H0Tb/yBufI3rTAezSQj4JNUUYbJRwy2E6IYeLPkuSBdi03c9gWCvocd6dlheg2PWuFPVo9aO9z9v4lDky8AqTsubgin/D/ah7qg4AYiGTaEWyewdCXROz6niCmh7f55Tt0XskEfox0MmLYlkTINK/pS6G3VRbT1Ao8QR450nE3D+oQ15QJodz8VzG8vxSNahP8ILc4eJeLyk2PQIjezDCGiahKlXcJ0oH0KAAW5xVf1hoFRlt5TTsQoqYEQAzMszoTiNZO/1qZgpgdSPo++0eXmTigChctP/vFQihMq+mCoEqbzb7hrjfZoI1G/VtOET7Zoz0fK+0evIkUV8SdNcCkHb232yuk8APKda/MSE6n58JX19F/rn/dX98UDe6uSjpR1r8rv6juXcEyXEFzFpk9uHtLAfMe5Tl3ZD/rwTAOAFbwF8pLhyJpujvoutG80qICznsCg/AYwYKAOIA076L2KNucjCoJSytRrwi2tk1DVVhQVdGxBo5dtuJshc6E+9UDBzZcTAT+3e2BIM65rK7lkWYJiYV5qjiY7Sx5Caxk+PaWclFnhD1MEUIh2SSM7g0WEUli2Ufzr1Z4oaGbkN5MsIP+TCJfQNFkPGibWbfzyRnSFgigQn4VaNKY4lD93A6LJB6RrBdNr61DBd9UluwqwNxlLW8H0ADOY+L9qjEafD0/wv0YWWBBrWIf+F3FDSVOM+8ItJYoXw++BTXzWvQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(39860400002)(396003)(376002)(346002)(451199015)(41300700001)(52536014)(4326008)(66446008)(64756008)(66476007)(66556008)(5660300002)(38100700002)(76116006)(122000001)(71200400001)(7696005)(6506007)(26005)(53546011)(66946007)(478600001)(8676002)(110136005)(186003)(316002)(55016003)(45080400002)(54906003)(86362001)(9686003)(33656002)(8936002)(2906002)(66899015)(38070700005)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10128 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1afcb09a-c395-44b6-ada7-08dac7d085be X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JEpM76Pi2SeYpXt/n1jH8ZcOFbFPeRLYTTdnUPanLomhVaqKs2Z2tjbFZ5OvE13FNQxG6LtnjHXbL31svnu7Wqy/8CaX0xnmFo2KITvUKo2IWdCp7vdo6wp8VGapo7PbmWQulYBA5+Py0uUdFEZ22RWMHoSsgDIZyxnISO+7pPwi8/utPwY6PXtKGZuUR1Au7otVHl/zvgDhe9yTZbE8ql7CklDqRrswyn9jllSpTI17Ku3ci8TzECjXc7B7/DomKXWjzWkb3uh9CfOtMmF09+WEV5wq7mWsQAEm2zVZw6K77MACndO1+m/zpfQCCk3p4rogFcN1CvF42sPzO4H37YxbgHsUTwuGiu/15RrqjO9I81MVtM6qW4hCMjP9+/VzfDYoOTH+qvFBGw9Uh+2I+l7fNPfKRF79uZ/WNT8rq4yPZYEtMlH7FNMG7lQ3OuzN6+/Oe+KCVRJW+/r7opchoWW6m8fkwSrdulOSih1Q05nrXj+8vVz+Fwjdo02pFrv5LRrJCNHFPcJop3uwJb6AfUwlXyO625NcfxvqUuEE5BWDEZY6MNWXJcDByPzZCBwp80ItQvx0hV+Hp5p7zHRPaI1eMHjqRVWqpzqqKOL4gQpBrNahM+bIvARtlm+WScUz/tP1luP7NQwCoehREE6xZfTtIR2EUIkxgkn1uGHra9TMGHW3lvPdX/lWktxVaz8Rj9izAPYhpsjt1JTk/UegmPbH2CG3Lajj9Usr2wNZtrseFhKg2idtX5Pm/QukvdHB4cImnyKJ1/K88RivjQ0dDQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199015)(40470700004)(46966006)(36840700001)(81166007)(66899015)(356005)(2906002)(40480700001)(8936002)(5660300002)(55016003)(52536014)(4326008)(70586007)(8676002)(53546011)(41300700001)(83380400001)(336012)(186003)(6506007)(70206006)(7696005)(9686003)(26005)(82310400005)(47076005)(86362001)(36860700001)(54906003)(316002)(478600001)(45080400002)(40460700003)(110136005)(82740400003)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 12:46:18.7107 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 947bb86a-922c-4856-fbba-08dac7d08eab X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5775 SGkNCiANCiBJIGhhdmUgd3JvdGUgYSBrZXJuZWwgcGF0Y2ggdG8gZml4IHRoaXMuIEFuZCBJIGhh dmUgdGVzdGVkLiBJdCB3aWxsIG5vdCBoYXZlIHNlZ21lbnRhdGlvbiBmYXVsdC4NCg0KQmVzdCB3 aXNoZXMNCkppYW1laSBYaWUNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9t OiBYZW4tZGV2ZWwgPHhlbi1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBC ZWhhbGYgT2YNCj4gSmlhbWVpIFhpZQ0KPiBTZW50OiBGcmlkYXksIE5vdmVtYmVyIDExLCAyMDIy IDEyOjMxIFBNDQo+IFRvOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5v cmc+OyBNaWNoYWwgT3J6ZWwNCj4gPG1pY2hhbC5vcnplbEBhbWQuY29tPg0KPiBDYzogeGVuLWRl dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47DQo+ IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IGp1bGllbkB4ZW4u b3JnDQo+IFN1YmplY3Q6IFJFOiBYZW4gQXJtIHZwbDAxMSBVQVJUIHdpbGwgY2F1c2Ugc2VnbWVu dGF0aW9uIGZhdWx0IGluIExpbnV4DQo+IGd1ZXN0DQo+IA0KPiBIaQ0KPiANCj4gPiAtLS0tLU9y aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+IEZyb206IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4NCj4gPiBTZW50OiBGcmlkYXksIE5vdmVtYmVyIDExLCAyMDIyIDQ6 MzMgQU0NCj4gPiBUbzogTWljaGFsIE9yemVsIDxtaWNoYWwub3J6ZWxAYW1kLmNvbT4NCj4gPiBD YzogSmlhbWVpIFhpZSA8SmlhbWVpLlhpZUBhcm0uY29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnOyBXZWkNCj4gPiBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgQmVydHJhbmQgTWFy cXVpcw0KPiA+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBqdWxpZW5AeGVuLm9yZzsgc3N0 YWJlbGxpbmlAa2VybmVsLm9yZw0KPiA+IFN1YmplY3Q6IFJlOiBYZW4gQXJtIHZwbDAxMSBVQVJU IHdpbGwgY2F1c2Ugc2VnbWVudGF0aW9uIGZhdWx0IGluIExpbnV4DQo+ID4gZ3Vlc3QNCj4gPg0K PiA+IE9uIFdlZCwgOSBOb3YgMjAyMiwgTWljaGFsIE9yemVsIHdyb3RlOg0KPiA+ID4gSGkgSmlh bWVpLA0KPiA+ID4NCj4gPiA+IE9uIDA5LzExLzIwMjIgMDk6MjUsIEppYW1laSBYaWUgd3JvdGU6 DQo+ID4gPiA+DQo+ID4gPiA+DQo+ID4gPiA+IEhpIE1pY2hhbO+8jA0KPiA+ID4gPg0KPiA+ID4g PiBCZWxvdyBsb2cgY2FuIGJlIGdvdCB3aGVuIHN0YXRpbmcgdGhlIGxpbnV4IGd1ZXN0LiBJdCBz YXlzIDljMDkgaXMgc2JzYS4NCj4gPiBBbmQgOWMwOSBpcyBhbHNvIG91dHB1dA0KPiA+ID4gPiAg aW4gYm9vdGxvZ2QgZXJyb3IgbWVzc2FnZToNCj4gPiA+ID4gU2VyaWFsOiBBTUJBIFBMMDExIFVB UlQgZHJpdmVyDQo+ID4gPiA+IDljMGIwMDAwLnVhcnQ6IHR0eUFNQTAgYXQgTU1JTyAweDljMGIw MDAwIChpcnEgPSAxMiwgYmFzZV9iYXVkID0gMCkNCj4gPiBpcyBhIFBMMDExIHJldjINCj4gPiA+ ID4gcHJpbnRrOiBjb25zb2xlIFt0dHlBTUEwXSBlbmFibGVkDQo+ID4gPiA+IDljMDkwMDAwLnNi c2EtdWFydDogdHR5QU1BMSBhdCBNTUlPIDB4OWMwOTAwMDAgKGlycSA9IDE1LCBiYXNlX2JhdWQN Cj4gPiA9IDApIGlzIGEgU0JTQQ0KPiA+ID4gPg0KPiA+ID4NCj4gPiA+IFhlbiBiZWhhdmlvciBp cyBjb3JyZWN0IGFuZCB0aGlzIHdvdWxkIGJlIExpbnV4IGZhdWx0IHRvIHRyeSB0byB3cml0ZSB0 bw0KPiA+IERNQUNSIGZvciBTQlNBIFVBUlQgZGV2aWNlLg0KPiA+ID4gRE1BQ1IgaXMganVzdCBh biBleGFtcGxlLiBJZiB5b3UgdHJ5IHRvIHByb2dyYW0gZS5nLiB0aGUgYmF1ZHJhdGUNCj4gKHRo cm91Z2gNCj4gPiBMQ1IpIGZvciBWUEwwMTEgaXQgd2lsbA0KPiA+ID4gYWxzbyByZXN1bHQgaW4g aW5qZWN0aW5nIGFib3J0IGludG8gdGhlIGd1ZXN0LiBTaG91bGQgWGVuIHN1cHBvcnQgaXQ/IE5v Lg0KPiBUaGUNCj4gPiByZWFzb24gd2h5IGlzIHRoYXQNCj4gPiA+IGl0IGlzIG5vdCBzcGVjIGNv bXBsaWFudCBvcGVyYXRpb24uIFNCU0Egc3BlY2lmaWNhdGlvbiBkaXJlY3RseSBzcGVjaWZpZXMN Cj4gPiB3aGF0IHJlZ2lzdGVycyBhcmUgZXhwb3NlZC4NCj4gPiA+IElmIExpbnV4IHRyaWVzIHRv IHdyaXRlIHRvIHNvbWUgb2YgdGhlIG5vbmUtc3BlYyBjb21wbGlhbnQgcmVnaXN0ZXJzIC0gaXQg aXMNCj4gaXRzDQo+ID4gZmF1bHQuDQo+ID4NCj4gPiBZZWFoLCB3ZSBuZWVkIHRvIGZpeCBMaW51 eC4NCj4gPg0KPiA+IEZZSSB0aGlzIGlzIG5vdCB0aGUgZmlyc3QgYnVnIGluIExpbnV4IGFmZmVj dGluZyB0aGUgc2JzYS11YXJ0IGRyaXZlcjoNCj4gPiB0aGUgaXNzdWUgaXMgdGhhdCB0aGUgcGww MTEgZHJpdmVyIGFuZCB0aGUgc2JzYS11YXJ0IGRyaXZlciBzaGFyZSB0aGUNCj4gPiBzYW1lIGNv ZGUgaW4gTGludXggc28gaXQgaGFwcGVucyBzb21ldGltZXMgdGhhdCBhIHBsMDExLW9ubHkgZmVh dHVyZQ0KPiA+IGNyZWVwcyBpbnRvIHRoZSBzYnNhLXVhcnQgZHJpdmVyIGJ5IG1pc3Rha2UuDQo+ IA0KPiBUaGFua3MgZm9yIHlvdXIgY29uZmlybSBhYm91dCB0aGlzLiBJbiB0aGF0IGNhc2UsIEkg d2lsbCBjaGVjayB0aGUgTGludXggY29kZSB0bw0KPiBzZWUgd2h5IHRoaXMgaGFwcGVucyBhbmQg aG93IHRvIGZpeCBpdC4NCj4gDQo+IEJlc3Qgd2lzaGVzDQo+IEppYW1laSBYaWUNCj4gPg0KPiA+ DQo+ID4gPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gPj4gRnJvbTogTWlj aGFsIE9yemVsIDxtaWNoYWwub3J6ZWxAYW1kLmNvbT4NCj4gPiA+ID4+IFNlbnQ6IFdlZG5lc2Rh eSwgTm92ZW1iZXIgOSwgMjAyMiAzOjQwIFBNDQo+ID4gPiA+PiBUbzogSmlhbWVpIFhpZSA8Smlh bWVpLlhpZUBhcm0uY29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+ID4gPiA+ PiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBCZXJ0cmFuZCBNYXJxdWlzDQo+ID4g PiA+PiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsganVsaWVuQHhlbi5vcmc7DQo+IHNzdGFi ZWxsaW5pQGtlcm5lbC5vcmcNCj4gPiA+ID4+IFN1YmplY3Q6IFJlOiBYZW4gQXJtIHZwbDAxMSBV QVJUIHdpbGwgY2F1c2Ugc2VnbWVudGF0aW9uIGZhdWx0IGluDQo+IExpbnV4DQo+ID4gPiA+PiBn dWVzdA0KPiA+ID4gPj4NCj4gPiA+ID4+IEhpIEppYW1laSwNCj4gPiA+ID4+DQo+ID4gPiA+PiBP biAwOS8xMS8yMDIyIDA4OjIwLCBKaWFtZWkgWGllIHdyb3RlOg0KPiA+ID4gPj4+DQo+ID4gPiA+ Pj4NCj4gPiA+ID4+PiBIaSBhbGwsDQo+ID4gPiA+Pj4NCj4gPiA+ID4+PiBXaGVuIHRoZSBndWVz dCBrZXJuZWwgZW5hYmxlcyBETUEgZW5naW5lIHdpdGgNCj4gPiA+ID4+ICJDT05GSUdfRE1BX0VO R0lORT15IiwgTGludXggQU1CQSBQTDAxMSBkcml2ZXIgd2lsbCBhY2Nlc3MNCj4gUEwwMTENCj4g PiA+ID4+IERNQUNSIHJlZ2lzdGVyLiBCdXQgdGhpcyByZWdpc3RlciBoYXZlIG5vdCBiZWVuIHN1 cHBvcnRlZCBieSB2cGwwMTENCj4gb2YNCj4gPiBYZW4uDQo+ID4gPiA+PiBYZW4gd2lsbCBpbmpl Y3QgYSBkYXRhIGFib3J0IGludG8gZ3Vlc3QsIHRoaXMgd2lsbCBjYXVzZSBzZWdtZW50YXRpb24N Cj4gZmF1bHQNCj4gPiBvZg0KPiA+ID4gPj4gZ3Vlc3Qgd2l0aCB0aGUgYmVsb3cgbWVzc2FnZToN Cj4gPiA+ID4+IEkgYW0gcXVpdGUgY29uZnVzZWQuDQo+ID4gPiA+PiBWUEwwMTEgaW1wbGVtZW50 cyBTQlNBIFVBUlQgd2hpY2ggb25seSBpbXBsZW1lbnRzIHNvbWUgc3Vic2V0DQo+IG9mDQo+ID4g UEwwMTENCj4gPiA+ID4+IG9wZXJhdGlvbnMgKFNCU0EgVUFSVCBpcyBub3QgUEwwMTEpLg0KPiA+ ID4gPj4gQWNjb3JkaW5nIHRvIHNwZWMgKFNCU0EgdmVyLiA2LjApLCB0aGUgU0JTQV9VQVJUIGRv ZXMgbm90IHN1cHBvcnQNCj4gPiBETUENCj4gPiA+ID4+IGZlYXR1cmVzIHNvIFhlbiBjb2RlIGlz IGZpbmUuDQo+ID4gPiA+PiBXaGVuIFhlbiBleHBvc2VzIHZwbDAxMSBkZXZpY2UgdG8gYSBndWVz dCwgdGhpcyBkZXZpY2UgaGFzDQo+ICJhcm0sc2JzYS0NCj4gPiB1YXJ0Ig0KPiA+ID4gPj4gY29t cGF0aWJsZSBhbmQgbm90ICJ1YXJ0LXBsMDExIi4NCj4gPiA+ID4+IExpbnV4IGRyaXZlciAiYW1i YS1wbDAxMS5jIiBzaG91bGQgc2VlIHRoaXMgY29tcGF0aWJsZSBhbmQgYXNzaWduDQo+ID4gcHJv cGVyDQo+ID4gPiA+PiBvcGVyYXRpb25zIChzYnNhX3VhcnRfcG9wcyBpbnN0ZWFkIG9mIGFtYmFf cGwwMTFfcG9wcykgdGhhdCBkbyBub3QNCj4gPiBlbmFibGUNCj4gPiA+ID4+IERNQS4NCj4gPiA+ ID4+IE1heWJlIHRoZSBpc3N1ZSBpcyB3aXRoIHlvdXIgY29uZmlndXJhdGlvbj8NCj4gPiA+ID4+ DQo+ID4gPiA+PiB+TWljaGFsDQo+ID4gPiA+Pg0KPiA+ID4gPj4+IFVuaGFuZGxlZCBmYXVsdCBh dCAweGZmZmZmZmMwMDk0NGQwNDgNCj4gPiA+ID4+PiBNZW0gYWJvcnQgaW5mbzoNCj4gPiA+ID4+ PiBFU1IgPSAweDk2MDAwMDAwDQo+ID4gPiA+Pj4gRUMgPSAweDI1OiBEQUJUIChjdXJyZW50IEVM KSwgSUwgPSAzMiBiaXRzDQo+ID4gPiA+Pj4gU0VUID0gMCwgRm5WID0gMA0KPiA+ID4gPj4+IEVB ID0gMCwgUzFQVFcgPSAwDQo+ID4gPiA+Pj4gRlNDID0gMHgwMDogdHRiciBhZGRyZXNzIHNpemUg ZmF1bHQNCj4gPiA+ID4+PiBEYXRhIGFib3J0IGluZm86DQo+ID4gPiA+Pj4gSVNWID0gMCwgSVNT ID0gMHgwMDAwMDAwMA0KPiA+ID4gPj4+IENNID0gMCwgV25SID0gMA0KPiA+ID4gPj4+IHN3YXBw ZXIgcGd0YWJsZTogNGsgcGFnZXMsIDM5LWJpdCBWQXMsIHBnZHA9MDAwMDAwMDAyMGUyZTAwMA0K PiA+ID4gPj4+IFtmZmZmZmZjMDA5NDRkMDQ4XSBwZ2Q9MTAwMDAwMDAzZmZmZjgwMywgcDRkPTEw MDAwMDAwM2ZmZmY4MDMsDQo+ID4gPiA+PiBwdWQ9MTAwMDAwMDAzZmZmZjgwMywgcG1kPTEwMDAw MDAwM2ZmZmE4MDMsDQo+ID4gcHRlPTAwNjgwMDAwOWMwOTBmMTMNCj4gPiA+ID4+PiBJbnRlcm5h bCBlcnJvcjogdHRiciBhZGRyZXNzIHNpemUgZmF1bHQ6IDk2MDAwMDAwIFsjMV0gUFJFRU1QVCBT TVANCj4gPiA+ID4+PiBNb2R1bGVzIGxpbmtlZCBpbjoNCj4gPiA+ID4+PiBDUFU6IDAgUElEOiAx MzIgQ29tbTogYm9vdGxvZ2QgTm90IHRhaW50ZWQgNS4xNS40NC15b2N0by1zdGFuZGFyZA0KPiA+ ICMxDQo+ID4gPiA+Pj4gcHN0YXRlOiA2MDQwMDBjNSAoblpDdiBkYUlGICtQQU4gLVVBTyAtVENP IC1ESVQgLVNTQlMgQlRZUEU9LS0pDQo+ID4gPiA+Pj4gcGMgOiBwbDAxMV9zdG9wX3J4KzB4NzAv MHg4MA0KPiA+ID4gPj4+IGxyIDogdWFydF90dHlfcG9ydF9zaHV0ZG93bisweDQ0LzB4MTEwDQo+ ID4gPiA+Pj4gc3AgOiBmZmZmZmZjMDA5OTliYmEwDQo+ID4gPiA+Pj4geDI5OiBmZmZmZmZjMDA5 OTliYmEwIHgyODogZmZmZmZmODAyMzRhYzM4MCB4Mjc6IGZmZmZmZjgwMjJmNWQwMDANCj4gPiA+ ID4+PiB4MjY6IDAwMDAwMDAwMDAwMDAwMDAgeDI1OiAwMDAwMDAwMDQ1NTg1NDAxIHgyNDoNCj4g PiAwMDAwMDAwMDAwMDAwMDAwDQo+ID4gPiA+Pj4geDIzOiBmZmZmZmY4MDIxYmE0NjYwIHgyMjog MDAwMDAwMDAwMDAwMDAwMSB4MjE6IGZmZmZmZjgwMjFhMGUyYTANCj4gPiA+ID4+PiB4MjA6IGZm ZmZmZjgwMjE5OGY4ODAgeDE5OiBmZmZmZmY4MDIxYTBlMWEwIHgxODogMDAwMDAwMDAwMDAwMDAw MA0KPiA+ID4gPj4+IHgxNzogMDAwMDAwMDAwMDAwMDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMDAg eDE1Og0KPiA+IDAwMDAwMDAwMDAwMDAwMDANCj4gPiA+ID4+PiB4MTQ6IDAwMDAwMDAwMDAwMDAw MDAgeDEzOiAwMDAwMDAwMDAwMDAwMDAwIHgxMjoNCj4gPiAwMDAwMDAwMDAwMDAwMDAwDQo+ID4g PiA+Pj4geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDAwMDAwMDAwMCB4OSA6DQo+ ID4gZmZmZmZmYzAwODcxYmExNA0KPiA+ID4gPj4+IHg4IDogZmZmZmZmYzAwOTlkZTI2MCB4NyA6 IGZmZmZmZjgwMjFhMGUzMTggeDYgOiAwMDAwMDAwMDAwMDAwMDAzDQo+ID4gPiA+Pj4geDUgOiBm ZmZmZmZjMDA5MzE1ZjIwIHg0IDogZmZmZmZmYzAwOTQ0ZDAzOCB4MyA6IDAwMDAwMDAwMDAwMDAw MDANCj4gPiA+ID4+PiB4MiA6IGZmZmZmZmMwMDk0NGQwNDggeDEgOiAwMDAwMDAwMDAwMDAwMDAw IHgwIDogMDAwMDAwMDAwMDAwMDA0OA0KPiA+ID4gPj4+IENhbGwgdHJhY2U6DQo+ID4gPiA+Pj4g cGwwMTFfc3RvcF9yeCsweDcwLzB4ODANCj4gPiA+ID4+PiB0dHlfcG9ydF9zaHV0ZG93bisweDdj LzB4YjQNCj4gPiA+ID4+PiB0dHlfcG9ydF9jbG9zZSsweDYwLzB4Y2MNCj4gPiA+ID4+PiB1YXJ0 X2Nsb3NlKzB4MzQvMHg4Yw0KPiA+ID4gPj4+IHR0eV9yZWxlYXNlKzB4MTQ0LzB4NGMwDQo+ID4g PiA+Pj4gX19mcHV0KzB4NzgvMHgyMjANCj4gPiA+ID4+PiBfX19fZnB1dCsweDFjLzB4MzANCj4g PiA+ID4+PiB0YXNrX3dvcmtfcnVuKzB4ODgvMHhjMA0KPiA+ID4gPj4+IGRvX25vdGlmeV9yZXN1 bWUrMHg4ZDAvMHgxMjNjDQo+ID4gPiA+Pj4gZWwwX3N2YysweGE4LzB4YzANCj4gPiA+ID4+PiBl bDB0XzY0X3N5bmNfaGFuZGxlcisweGE0LzB4MTMwDQo+ID4gPiA+Pj4gZWwwdF82NF9zeW5jKzB4 MWEwLzB4MWE0DQo+ID4gPiA+Pj4gQ29kZTogYjkwMDAwODMgYjkwMWYwMDEgNzk0MDM4YTAgOGIw MDAwNDIgKGI5MDAwMDQxKQ0KPiA+ID4gPj4+IC0tLVsgZW5kIHRyYWNlIDgzZGQ5M2RmMTVjMzIx NmYgXS0tLQ0KPiA+ID4gPj4+IG5vdGU6IGJvb3Rsb2dkWzEzMl0gZXhpdGVkIHdpdGggcHJlZW1w dF9jb3VudCAxDQo+ID4gPiA+Pj4gL2V0Yy9yY1MuZC9TMDdib290bG9nZDogbGluZSA0NzogMTMy IFNlZ21lbnRhdGlvbiBmYXVsdCBzdGFydC1zdG9wLQ0KPiA+ID4gPj4gZGFlbW9uDQo+ID4gPiA+ Pj4gSW4gWGVuLCB2cGwwMTFfbW1pb193cml0ZSBkb2Vzbid0IGhhbmRsZSBETUFDUiAuIEFuZCBr ZXJuZWwNCj4gZG9lc24ndA0KPiA+ID4gPj4gY2hlY2sgaWYgcGwwMTFfd3JpdGUgZXhlY3V0ZXMg c3VjZXNzZnVsbHkgaW4gcGwwMTFfZG1hX3J4X3N0b3AgLiBTbw0KPiA+IHN1Y2gNCj4gPiA+ID4+ IHNlZ21lbnRhdGlvbiBmYXVsdCBvY2N1cnMuDQo+ID4gPiA+Pj4gc3RhdGljIGlubGluZSB2b2lk IHBsMDExX2RtYV9yeF9zdG9wKHN0cnVjdCB1YXJ0X2FtYmFfcG9ydCAqdWFwKQ0KPiA+ID4gPj4+ IHsNCj4gPiA+ID4+PiAgICAgICAgIC8qIEZJWE1FLiAgSnVzdCBkaXNhYmxlIHRoZSBETUEgZW5h YmxlICovDQo+ID4gPiA+Pj4gICAgICAgICB1YXAtPmRtYWNyICY9IH5VQVJUMDExX1JYRE1BRTsN Cj4gPiA+ID4+PiAgICAgICAgIHBsMDExX3dyaXRlKHVhcC0+ZG1hY3IsIHVhcCwgUkVHX0RNQUNS KTsNCj4gPiA+ID4+PiB9DQo+ID4gPiA+Pj4NCj4gPiA+ID4+PiBJIHRoaW5rIHdlIHNob3VsZCBw cmV2ZW50IHN1Y2ggc2VnbWVudGF0aW9uIGZhdWx0LiBXZSBoYXZlIGNoZWNrZWQNCj4gPiB0aGUN Cj4gPiA+ID4+IFBMMDExIHNwZWMsIGl0IHNlZW1zIHRoZXJlIGlzIG5vdCBhbnkgcmVnaXN0ZXIg Yml0IGNhbiBpbmRpY2F0ZSBETUENCj4gPiBzdXBwb3J0DQo+ID4gPiA+PiBzdGF0dXMgb2YgUEww MTEuIFdlIG1pZ2h0IGhhdmUgdHdvIG9wdGlvbnM6DQo+ID4gPiA+Pj4gMS4gT3B0aW9uIzEgaXMg dG8gYWRkIERNQSBzdXBwb3J0IGZvciB2cGwwMTEsIGJ1dCB0aGlzIGlzIG5vdCB0cml2aWFsLg0K PiA+ID4gPj4+IDIuIE9wdGlvbiMyIGlzIHRvIGlnbm9yZSB0aGUgd3JpdGUgdG8gRE1BQ1IsIGFu ZCByZXR1cm4gMCBmb3IgRE1BQ1INCj4gPiByZWFkDQo+ID4gPiA+PiBpbiB2cGwwMTEuIEJ1dCB0 aGlzIG9wdGlvbiBuZWVkIGNvLXdvcmsgd2l0aCBrZXJuZWwsIGJlY2F1c2UgY3VycmVudA0KPiA+ IExpbnV4DQo+ID4gPiA+PiBQTDAxMSBkcml2ZXIgYXNzdW1lIHRoZSB3cml0ZSBvcGVyYXRpb24g d2lsbCBuZXZlciBiZSBmYWlsZWQsIGFuZCB3aWxsDQo+ID4gbm90DQo+ID4gPiA+PiBmYWxsYmFj ayB0byBuby1ETUEgbW9kZSwgd2hlbiBYZW4gcmV0dXJuIDAgZm9yIERNQSBlbmFibGVkIGJpdCBp bg0KPiA+IERNQUNSLg0KPiA+ID4gPj4+DQo+ID4gPiA+Pj4gSG93IGRvIHlvdSB0aGluayBhYm91 dCBpdD8gIEFueSBzdWdnZXN0aW9uIGFib3V0IGl0IGlzIHdlbGNvbWUuDQo+ID4gVGhhbmtzLg0K PiA+ID4gPj4+DQo+ID4gPiA+Pj4gQmVzdCB3aXNoZXMNCj4gPiA+ID4+PiBKaWFtZWkgWGllDQo+ ID4gPiA+Pj4NCj4gPiA+DQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 16 12:52:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 12:52:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444296.699345 (Exim 4.92) (envelope-from ) id 1ovHte-0000ki-Pf; Wed, 16 Nov 2022 12:52:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444296.699345; Wed, 16 Nov 2022 12:52:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovHte-0000kb-Mh; Wed, 16 Nov 2022 12:52:06 +0000 Received: by outflank-mailman (input) for mailman id 444296; Wed, 16 Nov 2022 12:52:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovHtd-0000kU-6C for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 12:52:05 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7d00::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 76eff203-65ad-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 13:52:03 +0100 (CET) Received: from DU2PR04CA0199.eurprd04.prod.outlook.com (2603:10a6:10:28d::24) by DBBPR08MB5994.eurprd08.prod.outlook.com (2603:10a6:10:20d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Wed, 16 Nov 2022 12:51:59 +0000 Received: from DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28d:cafe::f0) by DU2PR04CA0199.outlook.office365.com (2603:10a6:10:28d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Wed, 16 Nov 2022 12:51:59 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT063.mail.protection.outlook.com (100.127.142.255) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 12:51:58 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Wed, 16 Nov 2022 12:51:57 +0000 Received: from aacabcca56a2.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 57BCD4D4-3568-4EBE-81FF-40A5BC849036.1; Wed, 16 Nov 2022 12:51:50 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id aacabcca56a2.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 16 Nov 2022 12:51:50 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11) by PAWPR08MB9615.eurprd08.prod.outlook.com (2603:10a6:102:2ef::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Wed, 16 Nov 2022 12:51:49 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f]) by AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f%3]) with mapi id 15.20.5834.006; Wed, 16 Nov 2022 12:51:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76eff203-65ad-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CgG7Hs30J41ow980CHBHNC/SBBfJKaHAMumY/hquiHA=; b=RWbqkz8FKdUmt+yXxQLGNt45tzBGMytB5peAFp5wSHjwBvvDR5LgqTDb2k4ZSw2PP6MgWIPgEW3NthrBxZngE76S56wfG0f57Hb8arvWyewScUmdFCGKUxw26xQ+w1qWvL7NEqC0PgFdmDg+iv5ILM8dhRNbWaqrf1o1oASvSqg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: c070c99e14787ec7 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KqKLn5kkzhEM82LOjR+v2/8lyedCjt2pAsAhdCfiepiPsjrKxSb4/a576lqoWSJsoovNbtCas+uFXasBTk/DCewU6NxJjpi3i5MIDCdSVkOgK4HzntVLYrXLTDDEBvIchiVWpWznFLosuki6BBbU0RlcfdkmVgt0jbbjqf13AGc92ptznfgAJ8i5/jn9ZYvrM2jJ3I1V4l2C2b3S4ZKayITB4bNu6UfeviEp46iINjTEFdxEiXh/nrpXUROsgyWDD7gEfILKeybeETswqkLzgupmiPUp5n4RaF3/30i5PpkWsxbamPxTHLBbf4OvEVPU6LpaUmo8+5+nJFBcgdTMUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CgG7Hs30J41ow980CHBHNC/SBBfJKaHAMumY/hquiHA=; b=XBEop0y8CTX6WqI5BHVf3AYjdB65s4IgvfIgoUY3063sw/ReVYCgj+LgECoLsv3rSjMktd7JrZp2aDNeeXMU0zWpAzLH/++wOHrJCpFz6foTJqr0w8S9Gc0Lx3S3rnucHjMTRDOY2F2HNbI0I1wZvtQIXysnHkid8rmL0UUtsjXAFJiUGCGkjCkUDQ0KSApfFF6V3s9eNQcgitHjdgatOm/29yYS4mlgajLfZyKVw7qwIkOQxNPbVu3oQ9Ve2O3AED3JBxh60zd/0ELToMTSmkXK6RYcTDyU05l4NKE/HxUs67i6A+lJSRPNgNBH101s5L3ICaKoimeLvpDhwiiTRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CgG7Hs30J41ow980CHBHNC/SBBfJKaHAMumY/hquiHA=; b=RWbqkz8FKdUmt+yXxQLGNt45tzBGMytB5peAFp5wSHjwBvvDR5LgqTDb2k4ZSw2PP6MgWIPgEW3NthrBxZngE76S56wfG0f57Hb8arvWyewScUmdFCGKUxw26xQ+w1qWvL7NEqC0PgFdmDg+iv5ILM8dhRNbWaqrf1o1oASvSqg= From: Jiamei Xie To: Stefano Stabellini , Michal Orzel CC: "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , "julien@xen.org" Subject: RE: Xen Arm vpl011 UART will cause segmentation fault in Linux guest Thread-Topic: Xen Arm vpl011 UART will cause segmentation fault in Linux guest Thread-Index: Adj0C3U97KqJOGXWTaWwFEv08mPlLwAAvb+AAAFgduAAAlWjgABJlSiAABB0itABDLR9UAAAZywg Date: Wed, 16 Nov 2022 12:51:49 +0000 Message-ID: References: <00764fe2-f78a-e5db-cb16-903ad1a5ec03@amd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 09BCABEE4F02F94083AF189F8DBEAE6A.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7696:EE_|PAWPR08MB9615:EE_|DBAEUR03FT063:EE_|DBBPR08MB5994:EE_ X-MS-Office365-Filtering-Correlation-Id: 94e35ca8-72a6-40e1-5962-08dac7d15921 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: iWlp6W0Ezxzr1c0KVmz+m4wskj+1NPJwDrto5bJ+m0brRmhfUdjH3jrZ0m9T5IGpPNi+ZT4UI/l3Z8yoN/SCEbOuj5+XN1J8yAZpUPnmGSOOrmZGtUHv/Kpu/Y+zmy1GrLpnhVpLjBLpPzeCgvCf6MJhuEIB8iy/K2VzOrWpmkee/Or2wMkM+HCq9mSzTpPGYhpBjiODsi/uWCYA5XX+4MrLyvCgmZ9PdaSmpaLRiMZxacpzxR2rTAOdImU+n3vhm/Q9pbWOOe8HWOTddlCUfSbRI57brp54tkpwSprtFUIKSTfWNvpZ3aYCSD3QPVsBlPAbcRBzY/KgL6c1ekIX/Y2tbsFcyvGbCMBJowNkurNDrGFYCIyLguJA4u7y1vUZ5GOlEq51m7Fnuoo+w03mrVa4xorUxAhRECVQRz3h/+j2XmcpoGOfxUgbWB8CfooBrzXtmTo1fu1RMpnCWzaZyAvs0856ja3xP74o66Bh/T65Ha+zx8iuYnDUQWioWtpmI2EAepKUYCFdTV7HckRp41X00L2JGEK8Rq8Gcj//Cp002gS0SBtGXcu3fQ9OPSCygXOGzsolb7YMyuJ/TXBl0CElSsX+G5GWYwSpgOQUWcEAjHXJj/3tQpaMv/0FCR1Bm3VXE+VxWAZDIHu1S89Qsqni1NGv1WbCAPXYn1OUB7UJrlhN7/iXnqLH5MsyaxUgiU/xEm0JAZzfXmvq3k0cpr9OlOxLSjEfKnypY+Prg6kk9Crj/hwJrKSHxYEeE9Qp+/hgFG/iLcLaSpSKaJJmOA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(136003)(366004)(451199015)(66556008)(66476007)(66446008)(64756008)(66946007)(76116006)(33656002)(8676002)(4326008)(8936002)(52536014)(83380400001)(41300700001)(5660300002)(2940100002)(122000001)(53546011)(9686003)(186003)(26005)(55016003)(7696005)(38070700005)(71200400001)(478600001)(54906003)(316002)(86362001)(110136005)(6506007)(38100700002)(45080400002)(66899015)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9615 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2cf48826-2337-43a5-8907-08dac7d153dd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6jZT3wMjPKjYwp8+FZso7aM/4+9oqMz2x82ViAIUbWte/URhdfHhCsvFbp8wNiuz9YUGsnKXFnY6ogK8zMdj6+2nwyO6SMhOCz3QoaFQYzDz1da+O3aC/1dYsJoea84f0PTXL6yH0jddtyOJb2rTB9M+jNmhzecp6PyWudpDenPyWMrRf7oXjSNgSGBNTbbMosSoREVUxFRMItSzRDZzC6y0tYtqDfHkte4ZazotISrI3Jn+2Fof8J8ynodN6FEEF2mvvUWKGXlbxHiyQkdJqVewud9UEBa4QvJzmqN2vyCMG7xvRaTKZH7gEshw3z3PS3rzKM7a2+Sro2xRMtj8rR4hh9V5StbfVKuuxEYdO42xbY7aZ+uLgg8AaOUpOu1QVvBBXiFGUj9P5RWCVMrnE1IY3N74s7ESsHcOrMQuic+8lAW8C17xYdnP7Uyw2R2BoqnzLqsLbVABLxTytwiuy4XhaGTDXDQD2cL79v53U33jrZr/zsFBgsdvPeUiaMotsGrmyd63KWbP2wBHgzZ1qrQO3l3g9v3b0hejYhnLQK9gTKHx98D2oJevQVike10ekxAreN9EkHfyWDhYv9m2JGtMP4WOrHnSYZM5NTu4FFU6Ubq1kXp+uZdgc/JrjUEFrqr7JJMTei4GRTo5WodzFzUfMPZXJmEHW39h2c5brI3XRp7vHIyiWyH9H7SZvDTa84/wv1sW1f5xjKwSBpVjVroUe53QZFL0+2k09A5PM5w2EoIhzogfhbRWB6QmR5PJZgFCckcLUNC0mOXtfEwa8A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199015)(36840700001)(46966006)(40470700004)(40460700003)(4326008)(2906002)(54906003)(45080400002)(316002)(110136005)(70206006)(8936002)(8676002)(52536014)(70586007)(66899015)(53546011)(2940100002)(478600001)(336012)(33656002)(186003)(47076005)(83380400001)(55016003)(356005)(36860700001)(86362001)(81166007)(40480700001)(82310400005)(41300700001)(5660300002)(6506007)(26005)(7696005)(9686003)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 12:51:58.3796 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94e35ca8-72a6-40e1-5962-08dac7d15921 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5994 SGkNCg0KIEkgYWxzbyB3cm90ZSBhIHBhdGNoIHRvIG1ha2UgeGVuIGlnbm9yZSB0aGUgRE1BQ1Ig d3JpdGUgYW5kIHRlc3RlZCBpdC4gSXQgYWxzbyBjYW4gZml4IHRoaXMgc2VnbWVudGF0aW9uIGZh dWx0IGlzc3VlLg0KDQpCZXN0IHdpc2hlcw0KSmlhbWVpIFhpZQ0KDQo+IC0tLS0tT3JpZ2luYWwg TWVzc2FnZS0tLS0tDQo+IEZyb206IEppYW1laSBYaWUgPEppYW1laS5YaWVAYXJtLmNvbT4NCj4g U2VudDogV2VkbmVzZGF5LCBOb3ZlbWJlciAxNiwgMjAyMiA4OjQ2IFBNDQo+IFRvOiBKaWFtZWkg WGllIDxKaWFtZWkuWGllQGFybS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHNzdGFiZWxs aW5pQGtlcm5lbC5vcmc+OyBNaWNoYWwgT3J6ZWwgPG1pY2hhbC5vcnplbEBhbWQuY29tPg0KPiBD YzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJt LmNvbT47DQo+IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IGp1 bGllbkB4ZW4ub3JnDQo+IFN1YmplY3Q6IFJFOiBYZW4gQXJtIHZwbDAxMSBVQVJUIHdpbGwgY2F1 c2Ugc2VnbWVudGF0aW9uIGZhdWx0IGluIExpbnV4DQo+IGd1ZXN0DQo+IA0KPiBIaQ0KPiANCj4g IEkgaGF2ZSB3cm90ZSBhIGtlcm5lbCBwYXRjaCB0byBmaXggdGhpcy4gQW5kIEkgaGF2ZSB0ZXN0 ZWQuIEl0IHdpbGwgbm90IGhhdmUNCj4gc2VnbWVudGF0aW9uIGZhdWx0Lg0KPiANCj4gQmVzdCB3 aXNoZXMNCj4gSmlhbWVpIFhpZQ0KPiANCj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0K PiA+IEZyb206IFhlbi1kZXZlbCA8eGVuLWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5v cmc+IE9uIEJlaGFsZiBPZg0KPiA+IEppYW1laSBYaWUNCj4gPiBTZW50OiBGcmlkYXksIE5vdmVt YmVyIDExLCAyMDIyIDEyOjMxIFBNDQo+ID4gVG86IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz47IE1pY2hhbCBPcnplbA0KPiA+IDxtaWNoYWwub3J6ZWxAYW1kLmNv bT4NCj4gPiBDYzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBXZWkgQ2hlbiA8V2Vp LkNoZW5AYXJtLmNvbT47DQo+ID4gQmVydHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bh cm0uY29tPjsganVsaWVuQHhlbi5vcmcNCj4gPiBTdWJqZWN0OiBSRTogWGVuIEFybSB2cGwwMTEg VUFSVCB3aWxsIGNhdXNlIHNlZ21lbnRhdGlvbiBmYXVsdCBpbiBMaW51eA0KPiA+IGd1ZXN0DQo+ ID4NCj4gPiBIaQ0KPiA+DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4g RnJvbTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiA+ID4g U2VudDogRnJpZGF5LCBOb3ZlbWJlciAxMSwgMjAyMiA0OjMzIEFNDQo+ID4gPiBUbzogTWljaGFs IE9yemVsIDxtaWNoYWwub3J6ZWxAYW1kLmNvbT4NCj4gPiA+IENjOiBKaWFtZWkgWGllIDxKaWFt ZWkuWGllQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7DQo+IFdlaQ0K PiA+ID4gQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IEJlcnRyYW5kIE1hcnF1aXMNCj4gPiA+IDxC ZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBqdWxpZW5AeGVuLm9yZzsgc3N0YWJlbGxpbmlAa2Vy bmVsLm9yZw0KPiA+ID4gU3ViamVjdDogUmU6IFhlbiBBcm0gdnBsMDExIFVBUlQgd2lsbCBjYXVz ZSBzZWdtZW50YXRpb24gZmF1bHQgaW4gTGludXgNCj4gPiA+IGd1ZXN0DQo+ID4gPg0KPiA+ID4g T24gV2VkLCA5IE5vdiAyMDIyLCBNaWNoYWwgT3J6ZWwgd3JvdGU6DQo+ID4gPiA+IEhpIEppYW1l aSwNCj4gPiA+ID4NCj4gPiA+ID4gT24gMDkvMTEvMjAyMiAwOToyNSwgSmlhbWVpIFhpZSB3cm90 ZToNCj4gPiA+ID4gPg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gSGkgTWljaGFs77yMDQo+ID4gPiA+ ID4NCj4gPiA+ID4gPiBCZWxvdyBsb2cgY2FuIGJlIGdvdCB3aGVuIHN0YXRpbmcgdGhlIGxpbnV4 IGd1ZXN0LiBJdCBzYXlzIDljMDkgaXMgc2JzYS4NCj4gPiA+IEFuZCA5YzA5IGlzIGFsc28gb3V0 cHV0DQo+ID4gPiA+ID4gIGluIGJvb3Rsb2dkIGVycm9yIG1lc3NhZ2U6DQo+ID4gPiA+ID4gU2Vy aWFsOiBBTUJBIFBMMDExIFVBUlQgZHJpdmVyDQo+ID4gPiA+ID4gOWMwYjAwMDAudWFydDogdHR5 QU1BMCBhdCBNTUlPIDB4OWMwYjAwMDAgKGlycSA9IDEyLCBiYXNlX2JhdWQgPSAwKQ0KPiA+ID4g aXMgYSBQTDAxMSByZXYyDQo+ID4gPiA+ID4gcHJpbnRrOiBjb25zb2xlIFt0dHlBTUEwXSBlbmFi bGVkDQo+ID4gPiA+ID4gOWMwOTAwMDAuc2JzYS11YXJ0OiB0dHlBTUExIGF0IE1NSU8gMHg5YzA5 MDAwMCAoaXJxID0gMTUsDQo+IGJhc2VfYmF1ZA0KPiA+ID4gPSAwKSBpcyBhIFNCU0ENCj4gPiA+ ID4gPg0KPiA+ID4gPg0KPiA+ID4gPiBYZW4gYmVoYXZpb3IgaXMgY29ycmVjdCBhbmQgdGhpcyB3 b3VsZCBiZSBMaW51eCBmYXVsdCB0byB0cnkgdG8gd3JpdGUgdG8NCj4gPiA+IERNQUNSIGZvciBT QlNBIFVBUlQgZGV2aWNlLg0KPiA+ID4gPiBETUFDUiBpcyBqdXN0IGFuIGV4YW1wbGUuIElmIHlv dSB0cnkgdG8gcHJvZ3JhbSBlLmcuIHRoZSBiYXVkcmF0ZQ0KPiA+ICh0aHJvdWdoDQo+ID4gPiBM Q1IpIGZvciBWUEwwMTEgaXQgd2lsbA0KPiA+ID4gPiBhbHNvIHJlc3VsdCBpbiBpbmplY3Rpbmcg YWJvcnQgaW50byB0aGUgZ3Vlc3QuIFNob3VsZCBYZW4gc3VwcG9ydCBpdD8gTm8uDQo+ID4gVGhl DQo+ID4gPiByZWFzb24gd2h5IGlzIHRoYXQNCj4gPiA+ID4gaXQgaXMgbm90IHNwZWMgY29tcGxp YW50IG9wZXJhdGlvbi4gU0JTQSBzcGVjaWZpY2F0aW9uIGRpcmVjdGx5IHNwZWNpZmllcw0KPiA+ ID4gd2hhdCByZWdpc3RlcnMgYXJlIGV4cG9zZWQuDQo+ID4gPiA+IElmIExpbnV4IHRyaWVzIHRv IHdyaXRlIHRvIHNvbWUgb2YgdGhlIG5vbmUtc3BlYyBjb21wbGlhbnQgcmVnaXN0ZXJzIC0gaXQg aXMNCj4gPiBpdHMNCj4gPiA+IGZhdWx0Lg0KPiA+ID4NCj4gPiA+IFllYWgsIHdlIG5lZWQgdG8g Zml4IExpbnV4Lg0KPiA+ID4NCj4gPiA+IEZZSSB0aGlzIGlzIG5vdCB0aGUgZmlyc3QgYnVnIGlu IExpbnV4IGFmZmVjdGluZyB0aGUgc2JzYS11YXJ0IGRyaXZlcjoNCj4gPiA+IHRoZSBpc3N1ZSBp cyB0aGF0IHRoZSBwbDAxMSBkcml2ZXIgYW5kIHRoZSBzYnNhLXVhcnQgZHJpdmVyIHNoYXJlIHRo ZQ0KPiA+ID4gc2FtZSBjb2RlIGluIExpbnV4IHNvIGl0IGhhcHBlbnMgc29tZXRpbWVzIHRoYXQg YSBwbDAxMS1vbmx5IGZlYXR1cmUNCj4gPiA+IGNyZWVwcyBpbnRvIHRoZSBzYnNhLXVhcnQgZHJp dmVyIGJ5IG1pc3Rha2UuDQo+ID4NCj4gPiBUaGFua3MgZm9yIHlvdXIgY29uZmlybSBhYm91dCB0 aGlzLiBJbiB0aGF0IGNhc2UsIEkgd2lsbCBjaGVjayB0aGUgTGludXggY29kZQ0KPiB0bw0KPiA+ IHNlZSB3aHkgdGhpcyBoYXBwZW5zIGFuZCBob3cgdG8gZml4IGl0Lg0KPiA+DQo+ID4gQmVzdCB3 aXNoZXMNCj4gPiBKaWFtZWkgWGllDQo+ID4gPg0KPiA+ID4NCj4gPiA+ID4gPj4gLS0tLS1Pcmln aW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+ID4gPj4gRnJvbTogTWljaGFsIE9yemVsIDxtaWNoYWwu b3J6ZWxAYW1kLmNvbT4NCj4gPiA+ID4gPj4gU2VudDogV2VkbmVzZGF5LCBOb3ZlbWJlciA5LCAy MDIyIDM6NDAgUE0NCj4gPiA+ID4gPj4gVG86IEppYW1laSBYaWUgPEppYW1laS5YaWVAYXJtLmNv bT47IHhlbi0NCj4gZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gPiA+ID4gPj4gQ2M6IFdl aSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgQmVydHJhbmQgTWFycXVpcw0KPiA+ID4gPiA+PiA8 QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsganVsaWVuQHhlbi5vcmc7DQo+ID4gc3N0YWJlbGxp bmlAa2VybmVsLm9yZw0KPiA+ID4gPiA+PiBTdWJqZWN0OiBSZTogWGVuIEFybSB2cGwwMTEgVUFS VCB3aWxsIGNhdXNlIHNlZ21lbnRhdGlvbiBmYXVsdCBpbg0KPiA+IExpbnV4DQo+ID4gPiA+ID4+ IGd1ZXN0DQo+ID4gPiA+ID4+DQo+ID4gPiA+ID4+IEhpIEppYW1laSwNCj4gPiA+ID4gPj4NCj4g PiA+ID4gPj4gT24gMDkvMTEvMjAyMiAwODoyMCwgSmlhbWVpIFhpZSB3cm90ZToNCj4gPiA+ID4g Pj4+DQo+ID4gPiA+ID4+Pg0KPiA+ID4gPiA+Pj4gSGkgYWxsLA0KPiA+ID4gPiA+Pj4NCj4gPiA+ ID4gPj4+IFdoZW4gdGhlIGd1ZXN0IGtlcm5lbCBlbmFibGVzIERNQSBlbmdpbmUgd2l0aA0KPiA+ ID4gPiA+PiAiQ09ORklHX0RNQV9FTkdJTkU9eSIsIExpbnV4IEFNQkEgUEwwMTEgZHJpdmVyIHdp bGwgYWNjZXNzDQo+ID4gUEwwMTENCj4gPiA+ID4gPj4gRE1BQ1IgcmVnaXN0ZXIuIEJ1dCB0aGlz IHJlZ2lzdGVyIGhhdmUgbm90IGJlZW4gc3VwcG9ydGVkIGJ5DQo+IHZwbDAxMQ0KPiA+IG9mDQo+ ID4gPiBYZW4uDQo+ID4gPiA+ID4+IFhlbiB3aWxsIGluamVjdCBhIGRhdGEgYWJvcnQgaW50byBn dWVzdCwgdGhpcyB3aWxsIGNhdXNlIHNlZ21lbnRhdGlvbg0KPiA+IGZhdWx0DQo+ID4gPiBvZg0K PiA+ID4gPiA+PiBndWVzdCB3aXRoIHRoZSBiZWxvdyBtZXNzYWdlOg0KPiA+ID4gPiA+PiBJIGFt IHF1aXRlIGNvbmZ1c2VkLg0KPiA+ID4gPiA+PiBWUEwwMTEgaW1wbGVtZW50cyBTQlNBIFVBUlQg d2hpY2ggb25seSBpbXBsZW1lbnRzIHNvbWUgc3Vic2V0DQo+ID4gb2YNCj4gPiA+IFBMMDExDQo+ ID4gPiA+ID4+IG9wZXJhdGlvbnMgKFNCU0EgVUFSVCBpcyBub3QgUEwwMTEpLg0KPiA+ID4gPiA+ PiBBY2NvcmRpbmcgdG8gc3BlYyAoU0JTQSB2ZXIuIDYuMCksIHRoZSBTQlNBX1VBUlQgZG9lcyBu b3Qgc3VwcG9ydA0KPiA+ID4gRE1BDQo+ID4gPiA+ID4+IGZlYXR1cmVzIHNvIFhlbiBjb2RlIGlz IGZpbmUuDQo+ID4gPiA+ID4+IFdoZW4gWGVuIGV4cG9zZXMgdnBsMDExIGRldmljZSB0byBhIGd1 ZXN0LCB0aGlzIGRldmljZSBoYXMNCj4gPiAiYXJtLHNic2EtDQo+ID4gPiB1YXJ0Ig0KPiA+ID4g PiA+PiBjb21wYXRpYmxlIGFuZCBub3QgInVhcnQtcGwwMTEiLg0KPiA+ID4gPiA+PiBMaW51eCBk cml2ZXIgImFtYmEtcGwwMTEuYyIgc2hvdWxkIHNlZSB0aGlzIGNvbXBhdGlibGUgYW5kIGFzc2ln bg0KPiA+ID4gcHJvcGVyDQo+ID4gPiA+ID4+IG9wZXJhdGlvbnMgKHNic2FfdWFydF9wb3BzIGlu c3RlYWQgb2YgYW1iYV9wbDAxMV9wb3BzKSB0aGF0IGRvDQo+IG5vdA0KPiA+ID4gZW5hYmxlDQo+ ID4gPiA+ID4+IERNQS4NCj4gPiA+ID4gPj4gTWF5YmUgdGhlIGlzc3VlIGlzIHdpdGggeW91ciBj b25maWd1cmF0aW9uPw0KPiA+ID4gPiA+Pg0KPiA+ID4gPiA+PiB+TWljaGFsDQo+ID4gPiA+ID4+ DQo+ID4gPiA+ID4+PiBVbmhhbmRsZWQgZmF1bHQgYXQgMHhmZmZmZmZjMDA5NDRkMDQ4DQo+ID4g PiA+ID4+PiBNZW0gYWJvcnQgaW5mbzoNCj4gPiA+ID4gPj4+IEVTUiA9IDB4OTYwMDAwMDANCj4g PiA+ID4gPj4+IEVDID0gMHgyNTogREFCVCAoY3VycmVudCBFTCksIElMID0gMzIgYml0cw0KPiA+ ID4gPiA+Pj4gU0VUID0gMCwgRm5WID0gMA0KPiA+ID4gPiA+Pj4gRUEgPSAwLCBTMVBUVyA9IDAN Cj4gPiA+ID4gPj4+IEZTQyA9IDB4MDA6IHR0YnIgYWRkcmVzcyBzaXplIGZhdWx0DQo+ID4gPiA+ ID4+PiBEYXRhIGFib3J0IGluZm86DQo+ID4gPiA+ID4+PiBJU1YgPSAwLCBJU1MgPSAweDAwMDAw MDAwDQo+ID4gPiA+ID4+PiBDTSA9IDAsIFduUiA9IDANCj4gPiA+ID4gPj4+IHN3YXBwZXIgcGd0 YWJsZTogNGsgcGFnZXMsIDM5LWJpdCBWQXMsIHBnZHA9MDAwMDAwMDAyMGUyZTAwMA0KPiA+ID4g PiA+Pj4gW2ZmZmZmZmMwMDk0NGQwNDhdIHBnZD0xMDAwMDAwMDNmZmZmODAzLCBwNGQ9MTAwMDAw MDAzZmZmZjgwMywNCj4gPiA+ID4gPj4gcHVkPTEwMDAwMDAwM2ZmZmY4MDMsIHBtZD0xMDAwMDAw MDNmZmZhODAzLA0KPiA+ID4gcHRlPTAwNjgwMDAwOWMwOTBmMTMNCj4gPiA+ID4gPj4+IEludGVy bmFsIGVycm9yOiB0dGJyIGFkZHJlc3Mgc2l6ZSBmYXVsdDogOTYwMDAwMDAgWyMxXSBQUkVFTVBU IFNNUA0KPiA+ID4gPiA+Pj4gTW9kdWxlcyBsaW5rZWQgaW46DQo+ID4gPiA+ID4+PiBDUFU6IDAg UElEOiAxMzIgQ29tbTogYm9vdGxvZ2QgTm90IHRhaW50ZWQgNS4xNS40NC15b2N0by0NCj4gc3Rh bmRhcmQNCj4gPiA+ICMxDQo+ID4gPiA+ID4+PiBwc3RhdGU6IDYwNDAwMGM1IChuWkN2IGRhSUYg K1BBTiAtVUFPIC1UQ08gLURJVCAtU1NCUyBCVFlQRT0tLSkNCj4gPiA+ID4gPj4+IHBjIDogcGww MTFfc3RvcF9yeCsweDcwLzB4ODANCj4gPiA+ID4gPj4+IGxyIDogdWFydF90dHlfcG9ydF9zaHV0 ZG93bisweDQ0LzB4MTEwDQo+ID4gPiA+ID4+PiBzcCA6IGZmZmZmZmMwMDk5OWJiYTANCj4gPiA+ ID4gPj4+IHgyOTogZmZmZmZmYzAwOTk5YmJhMCB4Mjg6IGZmZmZmZjgwMjM0YWMzODAgeDI3OiBm ZmZmZmY4MDIyZjVkMDAwDQo+ID4gPiA+ID4+PiB4MjY6IDAwMDAwMDAwMDAwMDAwMDAgeDI1OiAw MDAwMDAwMDQ1NTg1NDAxIHgyNDoNCj4gPiA+IDAwMDAwMDAwMDAwMDAwMDANCj4gPiA+ID4gPj4+ IHgyMzogZmZmZmZmODAyMWJhNDY2MCB4MjI6IDAwMDAwMDAwMDAwMDAwMDEgeDIxOiBmZmZmZmY4 MDIxYTBlMmEwDQo+ID4gPiA+ID4+PiB4MjA6IGZmZmZmZjgwMjE5OGY4ODAgeDE5OiBmZmZmZmY4 MDIxYTBlMWEwIHgxODogMDAwMDAwMDAwMDAwMDAwMA0KPiA+ID4gPiA+Pj4geDE3OiAwMDAwMDAw MDAwMDAwMDAwIHgxNjogMDAwMDAwMDAwMDAwMDAwMCB4MTU6DQo+ID4gPiAwMDAwMDAwMDAwMDAw MDAwDQo+ID4gPiA+ID4+PiB4MTQ6IDAwMDAwMDAwMDAwMDAwMDAgeDEzOiAwMDAwMDAwMDAwMDAw MDAwIHgxMjoNCj4gPiA+IDAwMDAwMDAwMDAwMDAwMDANCj4gPiA+ID4gPj4+IHgxMTogMDAwMDAw MDAwMDAwMDAwMCB4MTA6IDAwMDAwMDAwMDAwMDAwMDAgeDkgOg0KPiA+ID4gZmZmZmZmYzAwODcx YmExNA0KPiA+ID4gPiA+Pj4geDggOiBmZmZmZmZjMDA5OWRlMjYwIHg3IDogZmZmZmZmODAyMWEw ZTMxOCB4NiA6IDAwMDAwMDAwMDAwMDAwMDMNCj4gPiA+ID4gPj4+IHg1IDogZmZmZmZmYzAwOTMx NWYyMCB4NCA6IGZmZmZmZmMwMDk0NGQwMzggeDMgOiAwMDAwMDAwMDAwMDAwMDAwDQo+ID4gPiA+ ID4+PiB4MiA6IGZmZmZmZmMwMDk0NGQwNDggeDEgOiAwMDAwMDAwMDAwMDAwMDAwIHgwIDogMDAw MDAwMDAwMDAwMDA0OA0KPiA+ID4gPiA+Pj4gQ2FsbCB0cmFjZToNCj4gPiA+ID4gPj4+IHBsMDEx X3N0b3BfcngrMHg3MC8weDgwDQo+ID4gPiA+ID4+PiB0dHlfcG9ydF9zaHV0ZG93bisweDdjLzB4 YjQNCj4gPiA+ID4gPj4+IHR0eV9wb3J0X2Nsb3NlKzB4NjAvMHhjYw0KPiA+ID4gPiA+Pj4gdWFy dF9jbG9zZSsweDM0LzB4OGMNCj4gPiA+ID4gPj4+IHR0eV9yZWxlYXNlKzB4MTQ0LzB4NGMwDQo+ ID4gPiA+ID4+PiBfX2ZwdXQrMHg3OC8weDIyMA0KPiA+ID4gPiA+Pj4gX19fX2ZwdXQrMHgxYy8w eDMwDQo+ID4gPiA+ID4+PiB0YXNrX3dvcmtfcnVuKzB4ODgvMHhjMA0KPiA+ID4gPiA+Pj4gZG9f bm90aWZ5X3Jlc3VtZSsweDhkMC8weDEyM2MNCj4gPiA+ID4gPj4+IGVsMF9zdmMrMHhhOC8weGMw DQo+ID4gPiA+ID4+PiBlbDB0XzY0X3N5bmNfaGFuZGxlcisweGE0LzB4MTMwDQo+ID4gPiA+ID4+ PiBlbDB0XzY0X3N5bmMrMHgxYTAvMHgxYTQNCj4gPiA+ID4gPj4+IENvZGU6IGI5MDAwMDgzIGI5 MDFmMDAxIDc5NDAzOGEwIDhiMDAwMDQyIChiOTAwMDA0MSkNCj4gPiA+ID4gPj4+IC0tLVsgZW5k IHRyYWNlIDgzZGQ5M2RmMTVjMzIxNmYgXS0tLQ0KPiA+ID4gPiA+Pj4gbm90ZTogYm9vdGxvZ2Rb MTMyXSBleGl0ZWQgd2l0aCBwcmVlbXB0X2NvdW50IDENCj4gPiA+ID4gPj4+IC9ldGMvcmNTLmQv UzA3Ym9vdGxvZ2Q6IGxpbmUgNDc6IDEzMiBTZWdtZW50YXRpb24gZmF1bHQgc3RhcnQtc3RvcC0N Cj4gPiA+ID4gPj4gZGFlbW9uDQo+ID4gPiA+ID4+PiBJbiBYZW4sIHZwbDAxMV9tbWlvX3dyaXRl IGRvZXNuJ3QgaGFuZGxlIERNQUNSIC4gQW5kIGtlcm5lbA0KPiA+IGRvZXNuJ3QNCj4gPiA+ID4g Pj4gY2hlY2sgaWYgcGwwMTFfd3JpdGUgZXhlY3V0ZXMgc3VjZXNzZnVsbHkgaW4gcGwwMTFfZG1h X3J4X3N0b3AgLiBTbw0KPiA+ID4gc3VjaA0KPiA+ID4gPiA+PiBzZWdtZW50YXRpb24gZmF1bHQg b2NjdXJzLg0KPiA+ID4gPiA+Pj4gc3RhdGljIGlubGluZSB2b2lkIHBsMDExX2RtYV9yeF9zdG9w KHN0cnVjdCB1YXJ0X2FtYmFfcG9ydCAqdWFwKQ0KPiA+ID4gPiA+Pj4gew0KPiA+ID4gPiA+Pj4g ICAgICAgICAvKiBGSVhNRS4gIEp1c3QgZGlzYWJsZSB0aGUgRE1BIGVuYWJsZSAqLw0KPiA+ID4g PiA+Pj4gICAgICAgICB1YXAtPmRtYWNyICY9IH5VQVJUMDExX1JYRE1BRTsNCj4gPiA+ID4gPj4+ ICAgICAgICAgcGwwMTFfd3JpdGUodWFwLT5kbWFjciwgdWFwLCBSRUdfRE1BQ1IpOw0KPiA+ID4g PiA+Pj4gfQ0KPiA+ID4gPiA+Pj4NCj4gPiA+ID4gPj4+IEkgdGhpbmsgd2Ugc2hvdWxkIHByZXZl bnQgc3VjaCBzZWdtZW50YXRpb24gZmF1bHQuIFdlIGhhdmUNCj4gY2hlY2tlZA0KPiA+ID4gdGhl DQo+ID4gPiA+ID4+IFBMMDExIHNwZWMsIGl0IHNlZW1zIHRoZXJlIGlzIG5vdCBhbnkgcmVnaXN0 ZXIgYml0IGNhbiBpbmRpY2F0ZSBETUENCj4gPiA+IHN1cHBvcnQNCj4gPiA+ID4gPj4gc3RhdHVz IG9mIFBMMDExLiBXZSBtaWdodCBoYXZlIHR3byBvcHRpb25zOg0KPiA+ID4gPiA+Pj4gMS4gT3B0 aW9uIzEgaXMgdG8gYWRkIERNQSBzdXBwb3J0IGZvciB2cGwwMTEsIGJ1dCB0aGlzIGlzIG5vdCB0 cml2aWFsLg0KPiA+ID4gPiA+Pj4gMi4gT3B0aW9uIzIgaXMgdG8gaWdub3JlIHRoZSB3cml0ZSB0 byBETUFDUiwgYW5kIHJldHVybiAwIGZvcg0KPiBETUFDUg0KPiA+ID4gcmVhZA0KPiA+ID4gPiA+ PiBpbiB2cGwwMTEuIEJ1dCB0aGlzIG9wdGlvbiBuZWVkIGNvLXdvcmsgd2l0aCBrZXJuZWwsIGJl Y2F1c2UgY3VycmVudA0KPiA+ID4gTGludXgNCj4gPiA+ID4gPj4gUEwwMTEgZHJpdmVyIGFzc3Vt ZSB0aGUgd3JpdGUgb3BlcmF0aW9uIHdpbGwgbmV2ZXIgYmUgZmFpbGVkLCBhbmQgd2lsbA0KPiA+ ID4gbm90DQo+ID4gPiA+ID4+IGZhbGxiYWNrIHRvIG5vLURNQSBtb2RlLCB3aGVuIFhlbiByZXR1 cm4gMCBmb3IgRE1BIGVuYWJsZWQgYml0IGluDQo+ID4gPiBETUFDUi4NCj4gPiA+ID4gPj4+DQo+ ID4gPiA+ID4+PiBIb3cgZG8geW91IHRoaW5rIGFib3V0IGl0PyAgQW55IHN1Z2dlc3Rpb24gYWJv dXQgaXQgaXMgd2VsY29tZS4NCj4gPiA+IFRoYW5rcy4NCj4gPiA+ID4gPj4+DQo+ID4gPiA+ID4+ PiBCZXN0IHdpc2hlcw0KPiA+ID4gPiA+Pj4gSmlhbWVpIFhpZQ0KPiA+ID4gPiA+Pj4NCj4gPiA+ ID4NCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 16 13:42:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 13:42:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444301.699356 (Exim 4.92) (envelope-from ) id 1ovIfw-00077B-BM; Wed, 16 Nov 2022 13:42:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444301.699356; Wed, 16 Nov 2022 13:42:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovIfw-000774-7z; Wed, 16 Nov 2022 13:42:00 +0000 Received: by outflank-mailman (input) for mailman id 444301; Wed, 16 Nov 2022 13:41:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovIfu-00076y-RE for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 13:41:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovIfu-0004QB-Fg; Wed, 16 Nov 2022 13:41:58 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.95.151.56]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ovIfu-0007eO-8C; Wed, 16 Nov 2022 13:41:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=GRUEMJJFWuGr9j2bSk/cxM/+xlkZKeIimE9qKYdvMZU=; b=ck1dIaRMgvIKWr71WQZlNBiCrm IFAhUtqh+3VbJ/Fpn8vSPfymAC0T/VKr3QchgT3kcg6jAbnh4KuoJ6ze8xhOpr83Y1AjWNWDVtHoH qPuocm0Fv9GVFMQpK9YPRiHfg94xt26iDymX4PvNkKINGddOv6FUYAjJwa9AjGA16ZVQ=; Message-ID: <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> Date: Wed, 16 Nov 2022 13:41:55 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> Content-Language: en-US From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16/11/2022 08:05, Michal Orzel wrote: > On 16/11/2022 00:10, Julien Grall wrote: >> >> >> Hi Michal, >> >> On 24/10/2022 11:05, Michal Orzel wrote: >>> Make use of the macros defined in asm/pl011-uart.h instead of hardcoding >>> the values. Also, take the opportunity to fix the file extension in a >>> top-level comment. >>> >>> No functional change intended. >>> >>> Signed-off-by: Michal Orzel >> >> With one comment below: >> >> Acked-by: Julien Grall >> >>> --- >>> xen/arch/arm/arm64/debug-pl011.inc | 20 +++++++++++--------- >>> 1 file changed, 11 insertions(+), 9 deletions(-) >>> >>> diff --git a/xen/arch/arm/arm64/debug-pl011.inc b/xen/arch/arm/arm64/debug-pl011.inc >>> index 1928a2e3ffbb..d82f2f1de197 100644 >>> --- a/xen/arch/arm/arm64/debug-pl011.inc >>> +++ b/xen/arch/arm/arm64/debug-pl011.inc >>> @@ -1,5 +1,5 @@ >>> /* >>> - * xen/arch/arm/arm64/debug-pl011.S >>> + * xen/arch/arm/arm64/debug-pl011.inc >>> * >>> * PL011 specific debug code >>> * >>> @@ -16,6 +16,8 @@ >>> * GNU General Public License for more details. >>> */ >>> >>> + #include >>> + >>> /* >>> * PL011 UART initialization >>> * xb: register which containts the UART base address >>> @@ -23,13 +25,13 @@ >>> */ >>> .macro early_uart_init xb, c >>> mov x\c, #(7372800 / CONFIG_EARLY_UART_PL011_BAUD_RATE % 16) >>> - strh w\c, [\xb, #0x28] /* -> UARTFBRD (Baud divisor fraction) */ >>> + strh w\c, [\xb, #FBRD] /* -> UARTFBRD (Baud divisor fraction) */ >>> mov x\c, #(7372800 / CONFIG_EARLY_UART_PL011_BAUD_RATE / 16) >>> - strh w\c, [\xb, #0x24] /* -> UARTIBRD (Baud divisor integer) */ >>> + strh w\c, [\xb, #IBRD] /* -> UARTIBRD (Baud divisor integer) */ >>> mov x\c, #0x60 /* 8n1 */ >> >> Can we introduce macro/define for 0x60? > We could but I think this should not be part of this patch. > The reason being, the arm32 code also uses hardcoded 0x60 so it should be changed as well. > I can create a prerequisite patch introducing the macro and changing the arm32 code first unless you prefer to have everything in a single patch. I am fine with either prerequisite or a follow-up to define a macro and use it in both arm32/arm64. > > As for the macro itself, because 8n1 only requires setting bits for WLEN (1 stop bit and no parity are 0 by default), we can do > the following in pl011-uart.h: > #define WLEN_8 0x60 I think it would be clearer and easier to check the spec if the value is (_AC(0x3, U) << 5). > and use it in the pl011-debug files (+ there is a question whether we should define WLEN_7-5 for completeness). I would not define WLEN_7-5. That said, I wonder if we really need to set the baud rate & co here? AFAICT the runtime driver never touch them. The reasoning is the firmware is responsible to configure the serial. Therefore, I would consider to drop the code (setting UARTCR might still be necessary). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 16 13:56:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 13:56:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444305.699366 (Exim 4.92) (envelope-from ) id 1ovItT-0000TQ-GL; Wed, 16 Nov 2022 13:55:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444305.699366; Wed, 16 Nov 2022 13:55:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovItT-0000TJ-DO; Wed, 16 Nov 2022 13:55:59 +0000 Received: by outflank-mailman (input) for mailman id 444305; Wed, 16 Nov 2022 13:55:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovItS-0000T9-Np; Wed, 16 Nov 2022 13:55:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovItS-0004eH-Jb; Wed, 16 Nov 2022 13:55:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovItR-0008G4-VC; Wed, 16 Nov 2022 13:55:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovItR-000205-UX; Wed, 16 Nov 2022 13:55:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QjB7MYXbFQm0G+2xHa50ipLvx39sxob8Sbm98BBJu+g=; b=SKre59iuEudfMdb1Nue3PRZCEc xW/jyec5SOaCEq46D00GqoR0Y+Qd0G57ezOokO4x0eYOzMI21A+znqVd+9yFA7mbf9VRNr2FVPs32 7ZSBGOh5v9ZECcPDiljVxMJrpmHapIm/2bwHJyn8EDAcy0Ummw5x1gs5k0xWMv0b65/A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174784: trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-credit1::broken:regression xen-unstable:test-amd64-amd64-xl-credit1:host-install(5):broken:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-i386-livepatch:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c805ceb0b26a643c7e47f01f2dbc50555d93cce8 X-Osstest-Versions-That: xen=c805ceb0b26a643c7e47f01f2dbc50555d93cce8 From: osstest service owner Date: Wed, 16 Nov 2022 13:55:57 +0000 flight 174784 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174784/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 broken Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-credit1 5 host-install(5) broken pass in 174773 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail in 174773 pass in 174784 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail in 174773 pass in 174784 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 174773 Tests which did not succeed, but are not blocking: test-amd64-i386-livepatch 7 xen-install fail like 174773 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174773 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174773 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174773 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174773 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174773 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174773 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174773 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174773 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174773 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174773 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174773 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174773 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen c805ceb0b26a643c7e47f01f2dbc50555d93cce8 baseline version: xen c805ceb0b26a643c7e47f01f2dbc50555d93cce8 Last test of basis 174784 2022-11-16 01:53:17 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 broken test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch fail test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-credit1 broken broken-step test-amd64-amd64-xl-credit1 host-install(5) Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed Nov 16 14:42:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 14:42:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444313.699377 (Exim 4.92) (envelope-from ) id 1ovJcY-0006sE-1m; Wed, 16 Nov 2022 14:42:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444313.699377; Wed, 16 Nov 2022 14:42:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovJcX-0006s7-VH; Wed, 16 Nov 2022 14:42:33 +0000 Received: by outflank-mailman (input) for mailman id 444313; Wed, 16 Nov 2022 14:42:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovJcW-0006rx-Hm; Wed, 16 Nov 2022 14:42:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovJcW-0005lr-EJ; Wed, 16 Nov 2022 14:42:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovJcV-0001Ew-VA; Wed, 16 Nov 2022 14:42:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovJcV-0001HV-Uj; Wed, 16 Nov 2022 14:42:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ng9FjGYP/61MMOAZg/tiIcweY4Tm5gqfo9uUf56z+dQ=; b=2WksxHbkkdcXatPKOFJWwgN9yu w3DRNIBtcrcR3UZe9M7xp67MV6AYNuPGN8wctBXqwfDgC66alsqwUPn9YgSt+ZhwoT/vW3WFh6VFO QKVBkBNhSCmvLMjpy6IdqCSZXo3eMZBa2Z0iVJ07C3tWJ3NVErqrju8zZRp0lU/mepXA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174787: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=cd94d891fb4b5cdda229f58b1dee261d5514082b X-Osstest-Versions-That: libvirt=539e851c5d66f86777b5698df939fe281095e823 From: osstest service owner Date: Wed, 16 Nov 2022 14:42:31 +0000 flight 174787 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174787/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174775 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174775 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174775 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt cd94d891fb4b5cdda229f58b1dee261d5514082b baseline version: libvirt 539e851c5d66f86777b5698df939fe281095e823 Last test of basis 174775 2022-11-15 04:20:16 Z 1 days Testing same since 174787 2022-11-16 04:18:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Daniel P. Berrangé Martin Kletzander Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 539e851c5d..cd94d891fb cd94d891fb4b5cdda229f58b1dee261d5514082b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Nov 16 14:46:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 14:46:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444318.699389 (Exim 4.92) (envelope-from ) id 1ovJg6-0007UK-JM; Wed, 16 Nov 2022 14:46:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444318.699389; Wed, 16 Nov 2022 14:46:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovJg6-0007UD-Ey; Wed, 16 Nov 2022 14:46:14 +0000 Received: by outflank-mailman (input) for mailman id 444318; Wed, 16 Nov 2022 14:46:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovJg4-0007U5-Sz for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 14:46:13 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2062e.outbound.protection.outlook.com [2a01:111:f400:7e8d::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 69164726-65bd-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 15:46:11 +0100 (CET) Received: from DS7PR03CA0127.namprd03.prod.outlook.com (2603:10b6:5:3b4::12) by BY5PR12MB4918.namprd12.prod.outlook.com (2603:10b6:a03:1df::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 14:46:07 +0000 Received: from DM6NAM11FT074.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b4:cafe::17) by DS7PR03CA0127.outlook.office365.com (2603:10b6:5:3b4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19 via Frontend Transport; Wed, 16 Nov 2022 14:46:07 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT074.mail.protection.outlook.com (10.13.173.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 14:46:06 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 16 Nov 2022 08:46:05 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 16 Nov 2022 06:45:59 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 16 Nov 2022 08:45:58 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69164726-65bd-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BDtHfUQbc+TD7SK9VigXUsFa/69dQS0wM2UulAklN21dHHRVue0+q3BgTrlj8Zf2JAQ2MFeX3VIaaQcNvDUoqW40f3pwPe/W1UBEa6JmdXdFPUWZXQqLsDwXSkKy1c6n9m0er4rgWFk6jjd31KglZw1n6mV/HCNkmjI9j82lHuVAOM34V8PAZFRGqG8/wpB2169oJAhGHuM2vqw+PK2eHtmML4vReKU2yTPxca+FX8hU8aBToNrVWH8q2PD+orxwfwgS1umpEAdxAoUmUWNAylw39KX+oTtmbBqK2hb5+yDT9pQZKVGbF6woyiQkn84T6g1z3u5jGJXqznKv0aK8Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w2kg0mYJ/BV+np7FuvaiEUyqoTrcgnnJ+v1rzQy5YkI=; b=BqHOOtRh2GRBCr9ye11/t+csNfuHj6hmgaHEYqDx0SgqW2pPNRQykpQB9IpZRkUJ2WCtNU4O4hoQllw+kqgmndqjgycnnh8Y0Z8CHNIr7EgYew2uMsXVJ6G6pJBT2dFu+K+i2yqJSsAxbq2dScwlyufTCwHhdqZB7N8VTL4uFZDDqnzL/SlBR4NyNVtzrozSK6TsSo+nb5qRRnNhYIKifsYXcXZJjF9w4ECSRkNFZN1bz5KgSXPcs1MqxsiQCngzqmWyywHUpkr0q1rbs3oHUSVleOtD+/QqRhfvp8Lmq6ZHCLDUOR49y00Rd8Sm9+JT1r+EQaQ6gBT04gJc3hlRKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w2kg0mYJ/BV+np7FuvaiEUyqoTrcgnnJ+v1rzQy5YkI=; b=i5JzYDQXiKbBmmGal4CS2/3lMgSBhMM6GFkDze5iuDRhBhAdIlWPMsmnZvl7Y4A4wiTaPGEz1RIg3tOiDIYPQWp94JLmfz/L8fCbsQV2HSEC8chjlDSzFJRc8884/ahbRwveFRJp8TjhKe9oBk2skoCloUaEjnce9NCgdPqGFLg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> Date: Wed, 16 Nov 2022 15:45:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Content-Language: en-US To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> From: Michal Orzel In-Reply-To: <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT074:EE_|BY5PR12MB4918:EE_ X-MS-Office365-Filtering-Correlation-Id: ae339b5f-9eac-447e-ad59-08dac7e14afd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iLRg+BCT1RsJ+Ckf05ErhH2NddKCh0UXa6aguoOzfZ36y4DK9TeabpRo09AvDztqrvM5uaDO2ZH2B76ETPv/2HM7EWGUZXlgiFQ2u1NRVq28pT8DoHq5pQrcUdvAM/4efBVPgsq49eCiM9uVxmCp+lDBNusoAahUVwSKHzViS8W6SaNR7pBAeQ4CX62GYv0DqYD9KBennpY8EVXa1OmSxpX4XuAHe0+YfVDtBGeIY6+7lJaAGcKaGOoOLMe34wSVXSQ/zG9+4m5qS/l0fgGpIcIt712inNVbkjPrCuIsuQqYBQD31NDGtOGXjMr3RTpHd1GX9uSei0inVdoUgs0ZkTKbe+AhplmM1OWoIdVdabilPaKi5+IuwzQN1CeGg1qz1UAHRpG3Ef1lYIyt/6cUGDwTF5c6G6sD1gC2ZwVkDvgEG8EwPyALJGKrQpr6Er0qVXr9S9D3FsNdJdG20QdOZYn4n1J0vaMwJeS2TqXx2E7jowvemMDrBmk5wFGTNLexxsKZwZ0wm6o4FCxCc8WKIwYV+96m+z78DznPOqjqk4qVg3wSlPhTskNQr54JgdcVZObTMDec+A6iRr1i5a3Z6PyJUtSwv2/VM1zaNN/jr2M5Vsd3ToizXgz5bZ8ocOeJLS5aLeQkMAlfnSNQU4mxEsVuJgxDqta4LF5S3TL3Zj5umXvT89XdwoMIbyzs6d4FQcYZvju0rerBwlnsHRgEZL/ih80zm30KVLOyzDS1+iZ4hLGcpncUUSkgYNebHcjvNkRJMk2mE6iEteSA4Cp1zmhHzwpX1fOPRuq1VC2+MooD/cdqUYkTs2m8gcpPmSzqwOXsTBjyTYkFnWOrW6WdoQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199015)(40470700004)(46966006)(36840700001)(53546011)(40460700003)(4326008)(44832011)(8676002)(356005)(426003)(26005)(186003)(336012)(2616005)(81166007)(70586007)(70206006)(47076005)(54906003)(86362001)(83380400001)(82740400003)(316002)(36756003)(16576012)(110136005)(82310400005)(2906002)(8936002)(31696002)(478600001)(31686004)(40480700001)(41300700001)(36860700001)(5660300002)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 14:46:06.5273 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ae339b5f-9eac-447e-ad59-08dac7e14afd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT074.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4918 Hi Julien, On 16/11/2022 14:41, Julien Grall wrote: > > > On 16/11/2022 08:05, Michal Orzel wrote: >> On 16/11/2022 00:10, Julien Grall wrote: >>> >>> >>> Hi Michal, >>> >>> On 24/10/2022 11:05, Michal Orzel wrote: >>>> Make use of the macros defined in asm/pl011-uart.h instead of hardcoding >>>> the values. Also, take the opportunity to fix the file extension in a >>>> top-level comment. >>>> >>>> No functional change intended. >>>> >>>> Signed-off-by: Michal Orzel >>> >>> With one comment below: >>> >>> Acked-by: Julien Grall >>> >>>> --- >>>> xen/arch/arm/arm64/debug-pl011.inc | 20 +++++++++++--------- >>>> 1 file changed, 11 insertions(+), 9 deletions(-) >>>> >>>> diff --git a/xen/arch/arm/arm64/debug-pl011.inc b/xen/arch/arm/arm64/debug-pl011.inc >>>> index 1928a2e3ffbb..d82f2f1de197 100644 >>>> --- a/xen/arch/arm/arm64/debug-pl011.inc >>>> +++ b/xen/arch/arm/arm64/debug-pl011.inc >>>> @@ -1,5 +1,5 @@ >>>> /* >>>> - * xen/arch/arm/arm64/debug-pl011.S >>>> + * xen/arch/arm/arm64/debug-pl011.inc >>>> * >>>> * PL011 specific debug code >>>> * >>>> @@ -16,6 +16,8 @@ >>>> * GNU General Public License for more details. >>>> */ >>>> >>>> + #include >>>> + >>>> /* >>>> * PL011 UART initialization >>>> * xb: register which containts the UART base address >>>> @@ -23,13 +25,13 @@ >>>> */ >>>> .macro early_uart_init xb, c >>>> mov x\c, #(7372800 / CONFIG_EARLY_UART_PL011_BAUD_RATE % 16) >>>> - strh w\c, [\xb, #0x28] /* -> UARTFBRD (Baud divisor fraction) */ >>>> + strh w\c, [\xb, #FBRD] /* -> UARTFBRD (Baud divisor fraction) */ >>>> mov x\c, #(7372800 / CONFIG_EARLY_UART_PL011_BAUD_RATE / 16) >>>> - strh w\c, [\xb, #0x24] /* -> UARTIBRD (Baud divisor integer) */ >>>> + strh w\c, [\xb, #IBRD] /* -> UARTIBRD (Baud divisor integer) */ >>>> mov x\c, #0x60 /* 8n1 */ >>> >>> Can we introduce macro/define for 0x60? >> We could but I think this should not be part of this patch. >> The reason being, the arm32 code also uses hardcoded 0x60 so it should be changed as well. >> I can create a prerequisite patch introducing the macro and changing the arm32 code first unless you prefer to have everything in a single patch. > > I am fine with either prerequisite or a follow-up to define a macro and > use it in both arm32/arm64. I would then prefer to add a follow-up patch as this one is already acked and created for a different reason. > >> >> As for the macro itself, because 8n1 only requires setting bits for WLEN (1 stop bit and no parity are 0 by default), we can do >> the following in pl011-uart.h: >> #define WLEN_8 0x60 > > I think it would be clearer and easier to check the spec if the value is > (_AC(0x3, U) << 5). sounds good. > >> and use it in the pl011-debug files (+ there is a question whether we should define WLEN_7-5 for completeness). > > I would not define WLEN_7-5. That said, I wonder if we really need to > set the baud rate & co here? > > AFAICT the runtime driver never touch them. The reasoning is the > firmware is responsible to configure the serial. Therefore, I would > consider to drop the code (setting UARTCR might still be necessary). I do not really agree because the current behavior was done on purpose. At the moment early_uart_init is called only if EARLY_UART_PL011_BAUD_RATE is set to a value != 0. This is done in order to have flexibility to either stick to what firmware/bootloader configured or to change this configuration by specifying the EARLY_UART_PL011_BAUD_RATE (useful when you do not know what the firmware configured). > > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 16 15:00:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 15:00:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444323.699400 (Exim 4.92) (envelope-from ) id 1ovJta-0001eu-PP; Wed, 16 Nov 2022 15:00:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444323.699400; Wed, 16 Nov 2022 15:00:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovJta-0001en-La; Wed, 16 Nov 2022 15:00:10 +0000 Received: by outflank-mailman (input) for mailman id 444323; Wed, 16 Nov 2022 15:00:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovJtY-0001eh-Do for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 15:00:08 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 59acc602-65bf-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 16:00:05 +0100 (CET) Received: from mail-dm6nam11lp2176.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Nov 2022 10:00:02 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by SJ0PR03MB6551.namprd03.prod.outlook.com (2603:10b6:a03:38f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Wed, 16 Nov 2022 15:00:00 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860%5]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 14:59:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59acc602-65bf-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668610805; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=FvknJ0yAruidXDMf8KU8J9heSHlajwBLWf4Q6KG4qyA=; b=FevAxHH2Z2isTcXBcb8Sc6T5kAQyg9EkKh60gIXjLHF7Rh7/N2zmud8M yeZ8i4CpHQ8yE8FXE29VasTykvwa3qnqdx2FTboou+ebF7eGZW2UFw7Wx VaeKBW+PQL+uR65EH+OvBa6c6y0ERk8F7MBv1pPZTV/AWTFm3X8KiWMzd Q=; X-IronPort-RemoteIP: 104.47.57.176 X-IronPort-MID: 84946054 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:UsTdOqKAqJGD8HnyFE+RN5QlxSXFcZb7ZxGr2PjKsXjdYENShmACz 2UaCDjSOKuIYmHxfI11PNiy9h5VvJaBnIc2GwJlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wVgPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5XWGdq0 MIoNAoBb02Z3MKQ0vGfZ9Zz05FLwMnDZOvzu1lG5BSAVLMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dopTGMkmSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzX+qBNxKSeHQGvhCiQO85EsDJSMsdEaaoameyV+seOpiE hlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQMMinN87Q3otz FDht8jyGTVlvbmRSHSc3rSZtzW/PW4SN2BqTS0ZSQoI5fHzrYd1iQjAJv5hGqOoitz+GRnr3 iuH6iM5gt07rcMNzbT9wlnBjBqlvJ2PRQkwjjg7RUqg5wJ9IYKgOYqh7AGC6e4addnHCF6co HIDhs6SqvgUCo2AnzCMR+NLG6y14/GCM3vXhlsH84QdyglBMkWLJeh4iAyS7m8zWirYUVcFu HPuhD4= IronPort-HdrOrdr: A9a23:rLhC+KGn4eMBa819pLqFwJLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oK+RSDljSh7Z/9Cly90g0FWz1C7L8++S yd+jaJp5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjow4OyjhkQGhYaVmQvmnsCouqO+ixV42mJ 3nogsmPe5093TNF1vF7yfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqA+7I t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1cwKoVKuZEIMvJ0vFhLA BcNrCb2B+QSyLCU5nthBgq/DVrZAVqIv7JeDlYhiXf6UkqoJkw9Tpl+CVYpAZByHt1ceg72w yPWJ4Y641mX4sYa7lwC/wGRtbyAmvRQQjUOGbXOlj/ErobUki94qIfzY9Fk91CQqZ4uqcaid DEShdVpGQyc0XhBYmH24BK6AnERCG4US72ws9T6pBlsvmkLYCbehGrWRQriY+tsv8fCsrUV7 K6P49XGebqKS/rFZxS1wPzVpFOIT0VUdETuNw8R1WSy/i7YrHCp6jearLeNbDtGTErVif2BW YCRiH6IIFa4kWiShbD8WzssrPWCznCFL5LYdvnFrIoufkw36V3w3gooEX84N2XIjtftaFzdF diIdrc49GGmVU= X-IronPort-AV: E=Sophos;i="5.96,167,1665460800"; d="scan'208";a="84946054" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DN6rAATPpdYNa/80HUX+NrS+z26ekqC4fVB4nwRcPFNo4qICOY+Mf16d4rUiww4Ii0T+FnhqVtVc7zHmzj5spyOE51YCFsH2K2+xwQPjaLxKxaHI7y6s3ct/vP/BnygxGdx+sPjy0f7WYZWqwV86Cej4aJRmbFZuGOCsn5E+mo1Ssv2ky+fHuXNS8BtxFTrVXFtotCz6g4VNLboT/VIjXt6mdm8bha9N9hc+dD+A9NcPcpgIuxo+Crd0HJ/n2GDZjn4zKBOKAEqBB2QNZ5+s2NIGIsAfYutS7CvUAWx/uUvGEUr0BYe2x2lYvTabvVb38fBJFL5yRIXUsu/gFxWDmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FvknJ0yAruidXDMf8KU8J9heSHlajwBLWf4Q6KG4qyA=; b=N1w7lDvs0nSTb9ir4de2yv3YwS6qikXK0z/geriVb7ZUqLzJNVIf3vk7rSa4mosYtMV66vcVp6b+FJtOtOgTHKA7TiCXqG4+Y6nu+YYDMEyKWidXOnPDLFmO2KEbebPfa8sQ9Kkv+3/uRIdIeQnxzXqSDuqFYB4nkBY58UpoDqfrM5zHGyRRwfCQ2sYXmYCn9WlTqEtk7+GcjDkBgHIqooD89MV/piLJTDXlEEZ7wiI0/3wkgHUkfRbcxzaRpcsatCw1Myto58p6pkcOPbbuE32KCIYX3NVgAlLVhSL8fazVIvtt/MVzLLpUGmqMv5g/feAd30mwJiKSyhPXVWAiiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FvknJ0yAruidXDMf8KU8J9heSHlajwBLWf4Q6KG4qyA=; b=JoTGefVARSoWgzjYkiq/xMK0S7OVBhPvKC8fLHfa/h/vCU9mBdNcA7+RVr2YTmWLaB8S6GN4JVacnT9G35ZI7U3rbGjdHbzFe9vgWCZnVwryiAIj5TNLjOEM+kiV7d0vlhr6cxm3hAVp33z5lpFvKcC/s5PFmMOZkw10FiA1RSg= From: Andrew Cooper To: Anthony Perard , "xen-devel@lists.xenproject.org" CC: Wei Liu , Stefano Stabellini , George Dunlap , Julien Grall , Jan Beulich , Henry Wang Subject: Re: [XEN PATCH for-4.17 v2 3/6] tools/include/xen-foreign: Add SPDX identifier to generated headers Thread-Topic: [XEN PATCH for-4.17 v2 3/6] tools/include/xen-foreign: Add SPDX identifier to generated headers Thread-Index: AQHY73rFw2EypUFm0USU279+Ma36zq5BuTuA Date: Wed, 16 Nov 2022 14:59:59 +0000 Message-ID: <79a61107-6cec-a927-12e8-44b25478bb74@citrix.com> References: <20221103115204.49610-1-anthony.perard@citrix.com> <20221103115204.49610-4-anthony.perard@citrix.com> In-Reply-To: <20221103115204.49610-4-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|SJ0PR03MB6551:EE_ x-ms-office365-filtering-correlation-id: 20841b1e-9476-427a-65e7-08dac7e33baa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ufVrztGFUjkER+qrV9pDt++7dRGLGfqTF+wnM2ihyB6WnRK6hH+HeLDhnKcN2uANHPTk7tFRGnR2RGo8fzfk6dxLc5O1GGyJmbC2VLl2pkBxGNcoaHbl8TlsRHT3NlT74kXAbIFC4W8KehoB+RLSCc3ru0DNePXkjv17RvwH2f9rkTCjRzjs4hp1c9xvbNmARwuzsi4KkzkjdeBeEzHHzjqfQ9LU/UyEVfNhtL12i6f+ICvz121l2oi488cNsyGR4ABtxb89JfdrORYuIE+TLeKSwX5ErBth6PbhcRKAQ8bgYbLloD1HaSQ7muB9Ma/++VZrBbSLTRj4Vsox87Qa4vqRwWx24senbOqeLgLkzozRraaxpnijCnvvbAjR7UdvpNBoG1+dP9t+QnY84vAHOvLLoMWGhPr7ZZHkI7N1u8fed/z886iQIxrXr0f0+BVt8TR+oQbJWNAYTCBmFmiNuurJfBYAg6Ayrws3NOyqpjHqxKN7BMOtiVp6pKqO7iwsCcmd1cfwF7dS7b6fk01KH/qclvBYR4kApC1xqoPzLQ5cDOAylyHXHxI89NLrKvwXPbfhLlSvD/gR6cNkM9CgR3d3sWPn5R5Hkvd9zzAli5UNR/v5zW/x8T5Lzh2W/SDWcNfNd3rjKTeCoeOT6DUn0R68SuPHM50AeWWuwcWFVgNQ3zbmQzoTxUJMuw6/CkbexSH8q4yrZT3xoCXhR3FURL7U8PmDTIvagj2EGg5aYOZdXAQkpnc+s/65RSxwyMlXN8+Na5Yos6cTNSiIfjjecdrKkCrDlMk3efyRbpN2/AtSKmZMAONbsUrEWMHbPNFz0/wbdxyGfFeQiJ+utULYPE22Zu70aNkB0sIW5baHX/I= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(136003)(376002)(396003)(346002)(451199015)(84970400001)(36756003)(41300700001)(54906003)(8676002)(53546011)(76116006)(91956017)(66556008)(66446008)(4326008)(66476007)(186003)(6486002)(71200400001)(86362001)(2616005)(66946007)(31696002)(478600001)(316002)(110136005)(26005)(6506007)(6512007)(64756008)(82960400001)(38070700005)(31686004)(2906002)(122000001)(8936002)(5660300002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QjE0SWN4WHBLbTV1NHlxNlg4S0VGZlpEM096TDU4cGs0TC9ORnhXVE0vZFd1?= =?utf-8?B?S0lEL3NVdEdHQTdsNHFJeUFLYlJBOFkxWXc1NS9McW80algzeUY1WXJ3aDgz?= =?utf-8?B?QWYyeWJrRmR2enZPU0UxU3BES01lckxnQzZYSldmQS9ZRUZKU0grSVlNc0hu?= =?utf-8?B?L0JzL0x5RUZ2YXJydnlkYzNyWnJGa0ZjYzl1SnhESVNpS2JFVGV5SE11WUd6?= =?utf-8?B?NjZqQXpSTnRTVjJoa0krMDI2NGFlSUZ6Y1k5dzVDSkJzWSs3eFZaZWVMcDhW?= =?utf-8?B?OWsrR0MvNmg5dkdVbDVIc0hkc2Z1R1g3RmdTSDF6L0Qza3h3bGRDYmRuUXJV?= =?utf-8?B?YTkrZGF2Q09TN2dDbm5PWS9YTUgrTUFLMGsvTEJjaDN2UGMrSTBGVCtUWVRz?= =?utf-8?B?VDIvb0NBNmhXNllDYzFJNTZXYzJMR2Q5eUx6T1NzcUo3UisyWkJEYWlacS9G?= =?utf-8?B?V3UySW4vTlcrdGlSVnBQeHk2eVlUK0lMUUJ0U3VkRy9GdHlVaDh1TDYxdFl2?= =?utf-8?B?VW9KRHFsckJ1S3NTVlZIVWNvRnlDNGFlTWhEZWQzbzUydWxMaGloUGpodDRO?= =?utf-8?B?MmpKYmtXNlh1VHlVNnFCcDBabHBUdXdPOUtxOU0zYkx5VXNzK3V0dUNlZUJu?= =?utf-8?B?bkpha2FyVFBEMG5lM2Z4bFhqeGl6QmorN1duNFVxbzVRNWRiSmlXWEYrVENX?= =?utf-8?B?aFNnNlVLWEd0VjRZb1hmTnJyYkFXUEZQTm02azN3Z3ZBUGdFV1R2UmhYdG8x?= =?utf-8?B?N3BDNmU0U29EWUtBOFp6c3lIbzd1Y2d0dElkNG5qS21NTk1aOW1QSDVpeFV4?= =?utf-8?B?R0tnM0d3L0p5c3VMOHl5Qk9xSGNvbVFDbU9xMHNPSE9QRG14UnErWTJiMWJj?= =?utf-8?B?dkFSU2dJWkpRM1BEWUg1V1pLRld3RkJoamhTbTNjWVU5dnBUeFo0Z0d3V25I?= =?utf-8?B?cWx3N0dwSW5OdFJxMUlxWmMrc2ZVYVZjc3UxL3RjVHJYME52THcxeThHQVJW?= =?utf-8?B?OW1MaFFFZDgvOE9nZnZ0dVUrK2s4NjA3eXZLUytkNG1GMmFseTB0dWRyZ05Q?= =?utf-8?B?djBpOTNEdG5YUXVqNDZidnBMN05ndTd5MWFxdTdsS0Q3NjF0eFVBWUc2Nmhn?= =?utf-8?B?UGtEM3JsYUxKMSsreC90UGxBb3VnMU1hUVZTWFBnWG5lWjNtL2NwczVwTHAr?= =?utf-8?B?bjZQTEtCdHNibGs2VUY4cWdvSjM3bUlKU3pQVmFBalVXQjVKSkpyd3FLcGQ2?= =?utf-8?B?bWNpU281T216NS8vRXE1dnVWKzBiTllsYkR6ajZPa0RRdzNJSkJSekJqTFFy?= =?utf-8?B?YjBqU2J4aUV6cDFPR3VmZUNjTkVDOVF2UitpT1hoUkhKeE5BL2d1OXdwREpD?= =?utf-8?B?WmVFZlhzN25oSm5KSFp3b2ViOVlsWWVuM01LMFZmaTZTWUpjYVhEVjJxQzl6?= =?utf-8?B?OENZUS9zbXlaZHV5Y2VqMkFUWUJlNUlrTUdBOEtWUGRxaDV1Qm0zdUc0SzRU?= =?utf-8?B?S29ubUVWek54ZkFRdWJybksranZvUGtkRFhvcERjS1dvOTE4M1FHdjM5RVJm?= =?utf-8?B?ZUVsa2RnQTJzOTlyMmpGYU1GeTBGZTVwb1FVa1I3a1c1NnprWlJJNXhhMUNu?= =?utf-8?B?SkwxTFJNeXJqWmJYbFFuVmx5MjViTmNxNGx5VERzZWowaEkwb3c3V29SQ3U4?= =?utf-8?B?UFhySTBkQXNjViszUlM5U0hIWUdCTVMvVE5TWW1UbFFWQUFUNDF5SEdQM1FD?= =?utf-8?B?V0djcDYwcW9ZbWxjZ2dRb3dCcFhNdmVsNU52K0dQbjRqeGJxYVEybnpXbzNV?= =?utf-8?B?bFZqQWs0YUJucE9xdjJCZUo4N2dlenJ5cmcvamZaS3NaMTNvaGdMY2VHSGFD?= =?utf-8?B?aFBIMU1kaVRHOWs4WDZSejg3R2xTZjRscXlxTHpiN0VDaEhRWGY5RFRuazYv?= =?utf-8?B?Rnh1RGxBYWFqTGdHQjY0d3dVblVKQWZpemJtU1hkS0k4N0RBckxMTFovYXY3?= =?utf-8?B?bWlET1RLZ05WeTZtaEkxcWlIQ3JRKzA4ZVlGREhibytTQUJudGtXTklQNVNz?= =?utf-8?B?VmhaYlE5RWZWY2ZuTlEzV2d6MHJyQmtKNkNPT2VXZ2YvVTlHT3lxZGtNMVBy?= =?utf-8?Q?TE2C4pai+/z5CrAxeDrl7XZu/?= Content-Type: text/plain; charset="utf-8" Content-ID: <1CE78DED7A029147BAE154B08A914EA7@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: wzSR5vDucf78sTvsDjO4cugIrGCkWwxgsl/v7HJ2EgFyeLFLVw+fuJlOqStPWWbK9VhXjQzPRoCc9wjs6rWMCYgS6rR0r/UFJTglmUTBU4h/ZWKZGjnucxudarGdZzv+y+4DAqtI/SUKF6nOlAc5KezJnDewKpf/BETx+H6ZzU+ZbpM8sKdizoDFgBg0F/rQ63S8729jxOaOur02WOQ8DvcItOrPRYVntAux+SsGs/n5C1f98oFFD/mUVE24ZowpDPjq3aPW3SF0j9g6V+tUQnDl7D5ZUDJ4H4eFF07bXe74PtxJxUxcdvhi2TLFMWlIxVZRqB+0KagWaRhj9fdWHrN1G/D7XNperUqtKHfQeb9rpy0EqS6zEA/Y7cMEBLboI1vm5vHGOC4e42WdD8/A2vtKizZk8HZK7FHmmNcn7C/1IiHI0bMVlzi2ahT9bjS1awsVFm8rXW6vGEG2WVMg5WwQloIvJtJKzBv9MKUg3qc52dAqhQAdZYNj+BLwY519FNi793PuSLPB0Su6bnDz+f0jWX7oCvelXBWWd4GuWdCggfoHyCSQ4i0ZfKg4Kr24Qt/FCeA7C1Kl5bKBoomCkliro8PmG6F4tDR+e1q/5Ly0J3rPaEjw968jR5kzsuHKqFGsX3JnEC+1KyANOZNKlO3bea4AetNvjuaYqmd36KHGBESCxNqawp8pX2H5nv/DhEIcFIHEBG2SNFfXYKlKf7rMc0LuVGfLB/CfkaH0ZhNU7GHzZgSyiZWeztyycoh3d6RBjhAemRhlKaZSS43YPF43GQ3VSl2XobRK5yfeKwLhnxX7ueqEajbnx2A8xLsQaB884sZ5xld7+rZ8jKaT2QrkykP/Cn1Ydcu1q01lyNYzt34ep9p//1s4B2et0jyuHwXJEKUtbmXJ/NeuRuPJbA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20841b1e-9476-427a-65e7-08dac7e33baa X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 14:59:59.8248 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qeH4lDa8bnnW1eL0XRw0da8heYp0TJ2Ws8PBFfju/TXzxBz13zdAdW/TDNjRm4H5KI5Zgq+XxXnQozLac9vLL/RMxA9EAMfXV1p6SZmJvUw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6551 T24gMDMvMTEvMjAyMiAxMTo1MiwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IGRpZmYgLS1naXQg YS90b29scy9pbmNsdWRlL3hlbi1mb3JlaWduL21raGVhZGVyLnB5IGIvdG9vbHMvaW5jbHVkZS94 ZW4tZm9yZWlnbi9ta2hlYWRlci5weQ0KPiBpbmRleCBmYjI2OGYwZGNlLi5lYzhhMzIxMzk1IDEw MDY0NA0KPiAtLS0gYS90b29scy9pbmNsdWRlL3hlbi1mb3JlaWduL21raGVhZGVyLnB5DQo+ICsr KyBiL3Rvb2xzL2luY2x1ZGUveGVuLWZvcmVpZ24vbWtoZWFkZXIucHkNCj4gQEAgLTEsNSArMSw2 IEBADQo+ICAjIS91c3IvYmluL3B5dGhvbg0KPiAgDQo+ICtmcm9tIF9fZnV0dXJlX18gaW1wb3J0 IHByaW50X2Z1bmN0aW9uDQo+ICBpbXBvcnQgc3lzLCByZTsNCj4gIGZyb20gc3RydWN0cyBpbXBv cnQgdW5pb25zLCBzdHJ1Y3RzLCBkZWZpbmVzOw0KPiAgDQo+IEBAIC0xMTQsMjMgKzExNSwzNyBA QCBpbnB1dCAgPSAiIjsNCj4gIG91dHB1dCA9ICIiOw0KPiAgZmlsZWlkID0gcmUuc3ViKCJbLS5d IiwgIl8iLCAiX19GT1JFSUdOXyVzX18iICUgb3V0ZmlsZS51cHBlcigpKTsNCj4gIA0KPiAtIyBy ZWFkIGlucHV0IGhlYWRlciBmaWxlcw0KPiAgZm9yIG5hbWUgaW4gaW5maWxlczoNCj4gICAgICBm ID0gb3BlbihuYW1lLCAiciIpOw0KPiArICAgICMgQ2hlY2sgdGhlIGxpY2VuY2Ugb2YgdGhlIGlu cHV0IGZpbGUsIG9ubHkgU1BEWCBpZGVudGlmaWVyIGlzIGFjY2VwdGVkIGJ5DQo+ICsgICAgIyB0 aGlzIHNjcmlwdC4NCj4gKyAgICBsaW5lID0gZi5yZWFkbGluZSgpDQo+ICsgICAgaWYgbm90IGxp bmUgPT0gIi8qIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBNSVQgKi9cbiI6DQoNCiE9DQoNCj4g KyAgICAgICAgcHJpbnQoIiVzOiBFcnJvcjogJXMgaXMgbWlzc2luZyBTUERYIGlkZW50aWZpZXIi ICUgKHN5cy5hcmd2WzBdLCBuYW1lKSwgZmlsZT1zeXMuc3RkZXJyKQ0KDQpJJ3ZlIHJld29ya2Vk IHRoaXMgYSBsaXR0bGUgdG8gcHJvdmlkZSBtb3JlIGluZm9ybWF0aW9uIGluIHRoZSBjYXNlIHRo YXQNCnNvbWV0aGluZyBhY3R1YWxseSBnb2VzIHdyb25nLg0KDQp4ZW4uZ2l0L3Rvb2xzL2luY2x1 ZGUveGVuLWZvcmVpZ24kIG1ha2UgYWxsDQpweXRob24zIG1raGVhZGVyLnB5IGFybTMyIGFybTMy LmgudG1wDQovbG9jYWwveGVuLmdpdC90b29scy9pbmNsdWRlL3hlbi1mb3JlaWduLy4uLy4uLy4u L3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQovbG9jYWwveGVuLmdpdC90b29scy9pbmNs dWRlL3hlbi1mb3JlaWduLy4uLy4uLy4uL3hlbi9pbmNsdWRlL3B1YmxpYy94ZW4uaA0KbWtoZWFk ZXIucHkNCi9sb2NhbC94ZW4uZ2l0L3Rvb2xzL2luY2x1ZGUveGVuLWZvcmVpZ24vLi4vLi4vLi4v eGVuL2luY2x1ZGUvcHVibGljL3hlbi5oOg0KRXJyb3I6IE1pc3Npbmcgb3IgdW5leHBlY3RlZCBT UERYIHRhZyAnLyogU1BEWC1MaWNlbnMtSWRlbnRpZmllcjogTUlUICovJw0KTWFrZWZpbGU6Mjk6 IHJlY2lwZSBmb3IgdGFyZ2V0ICdhcm0zMi5oJyBmYWlsZWQNCm1ha2U6ICoqKiBbYXJtMzIuaF0g RXJyb3IgMQ0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 16 15:02:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 15:02:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444327.699411 (Exim 4.92) (envelope-from ) id 1ovJvS-0002Xc-9p; Wed, 16 Nov 2022 15:02:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444327.699411; Wed, 16 Nov 2022 15:02:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovJvS-0002XV-5r; Wed, 16 Nov 2022 15:02:06 +0000 Received: by outflank-mailman (input) for mailman id 444327; Wed, 16 Nov 2022 15:02:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovJvR-0002XG-GN for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 15:02:05 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a070d20d-65bf-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 16:02:03 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a070d20d-65bf-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668610923; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HvPry1rW0ptZIe4HprQkZ4xldI44Bjk872FTp8DAsP4=; b=QGAY6f8npf1q43gLyBf/ZELL0i543sqRO9Z3Pd90W8FNzLsfyKlLhXGS xTdbEAH81aCVnYO1oejZstsBCR/NlCcQgd48ZpgrqsUD16lW0DKPyskBt ptEeDHh6/HVHUtiWZFu3m+Q/8tqGEvI1FMCtSD37snCVO7+WNp4L0THlu M=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84012303 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:/mblvKIK7P6OFrH2FE+R4pUlxSXFcZb7ZxGr2PjKsXjdYENS02FRy mIdWG/Sb/aONDP2L9BwPoy+oUhVvZ6BmtNhGlNlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wVgPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4sITpI7 ftCIwwkQSizrrOK/+LnDdJz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUozWHZwPxR7Dz o7A12rfPh4kLf6N8GGM6izrpM7Bpge4abtHQdVU8dY12QbOlwT/EiY+V0a/oPS/ol6zXZRYM UN80igkoLU29UerZsLgRBD+q3mB1jY8VtxKAqsF4QeC4qPO5kCSAW1sZi5MbpkqudE7QRQu1 0SVhJX5CDp3qrqXRHmBsLCOoluaJiw9PWIEIygeQmMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz Fi3QDMW3utJy5RRjuPioA6B02nESoX1ohAdvSWMWHqitAhFTaGdV6X51WeLsbF7M9PMJrWeh 0Qsl8+b5eEIKJiCki2RXekAdI2UC+a53C702gA2QcR4n9i50zv6JN0LvmkiTKt8GpxcEQIFd nM/ru+4CHV7GHKxJZF6bIuqYyjB5fixTI+1Phw4gzcnX3SQSONl1HswDaJz9zq3+KTJrU3YE cnzTCpUJSxGYZmLNRLvLwrduJdyrszE+UvdRIrg0zOs2qeEaXieRN8taQXQPr1is/nV8VuKq L6z0vdmLD0GDoXDjtT/q9ZPfTjm01BmbXwJlyCnXrHaeVc3cI3QI/TQ3akga+RYc1d9z4/1E 7DUchEw9WcTclWddl7SNS49NOuyNXu9xFpiVRER0Z+T8yBLSe6SAG03LfPboZFPGDRf8MNJ IronPort-HdrOrdr: A9a23:qMtkR6Dvj7pNEaflHemu55DYdb4zR+YMi2TC1yhKKCC9Vvbo8P xG/c5rsSMc5wx8ZJhNo7+90ey7MBXhHP1OkOws1NWZLWrbUQKTRekIh+bfKn/bak/DH4ZmpN 5dmsNFaOEYY2IVsfrH X-IronPort-AV: E=Sophos;i="5.96,167,1665460800"; d="scan'208";a="84012303" Date: Wed, 16 Nov 2022 15:01:43 +0000 From: Anthony PERARD To: CC: Wei Liu , Stefano Stabellini , "George Dunlap" , Julien Grall , Jan Beulich , Henry Wang , Andrew Cooper Subject: Re: [XEN PATCH for-4.17 v2 5/6] Rework COPYING installed in /usr/include/xen/, due to several licences Message-ID: References: <20221103115204.49610-1-anthony.perard@citrix.com> <20221103115204.49610-6-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221103115204.49610-6-anthony.perard@citrix.com> On Thu, Nov 03, 2022 at 11:52:03AM +0000, Anthony PERARD wrote: > The notice in the COPYING file in "xen/include/public/COPYING" doesn't > really apply to the files that ultimately are been install at > "/usr/include/xen". The issue are headers in the "sys/" subdirectory > that comes from other projects such as Linux or FreeBSD. > > The main issue is that there are two headers that have a different > licence than the MIT licence: > > - xen-sys/Linux/gntalloc.h (installed as "sys/gntalloc.h") is public > domain. > - xen-sys/FreeBSD/gntdev.h (installed as "sys/gntdev.h") is BSD-2. > > To clarify this, we'll install a COPYING file with a different notice. > > Reported-by: Andrew Cooper > Signed-off-by: Anthony PERARD > --- So the COPYING file is currently listed to be "ignored" by git (at least when untracked) and that seems to bother someone or something. So I guess an extra hunk to this patch is wanted: diff --git a/.gitignore b/.gitignore index 418bdfaebf..4eb602480a 100644 --- a/.gitignore +++ b/.gitignore @@ -195,6 +195,7 @@ tools/hotplug/NetBSD/rc.d/xendriverdomain tools/include/acpi tools/include/_libxl*.h tools/include/xen/* +!tools/include/xen/COPYING tools/include/xen-xsm/* tools/include/xen-foreign/*.(c|h|size) tools/include/xen-foreign/checker Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Nov 16 15:27:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 15:27:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444335.699422 (Exim 4.92) (envelope-from ) id 1ovKJh-0005VH-9u; Wed, 16 Nov 2022 15:27:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444335.699422; Wed, 16 Nov 2022 15:27:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovKJh-0005VA-5I; Wed, 16 Nov 2022 15:27:09 +0000 Received: by outflank-mailman (input) for mailman id 444335; Wed, 16 Nov 2022 15:27:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovKJf-0005V4-H9 for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 15:27:07 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1fdff963-65c3-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 16:27:06 +0100 (CET) Received: from mail-co1nam11lp2177.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Nov 2022 10:26:52 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by MW5PR03MB7008.namprd03.prod.outlook.com (2603:10b6:303:1ab::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Wed, 16 Nov 2022 15:26:49 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860%5]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 15:26:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1fdff963-65c3-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668612426; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=5qvE2/yZGFCn28tmqkqGx9hXU6pc2poFPRL+ZATTm2w=; b=DPwQNlecmvWU+G64pEi/ixYTI1ZanLaTByuFwBbztIAbVvxMYRa6qfoB ad1PsD3voqVh/PbN/QxP5tnwXonxon8J5/gZaX9vrDKwiAxzssUGMudSl Fu+GQbc5RM9FzbVhI+9RClKzTrvLhDFAcVS/Dkq1BgTbzb9dgZ4vTTNGR w=; X-IronPort-RemoteIP: 104.47.56.177 X-IronPort-MID: 84536199 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:aOISWaJ681eXBPRdFE+RN5QlxSXFcZb7ZxGr2PjKsXjdYENS1WEAy DMcXT+PPfuMamr8Ltx1boyzpx4Ev5CEy9ExSVdlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wVgPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5NPF9N/ +MJOAoHazfdieiJ0om4cPlV05FLwMnDZOvzu1lG5BSAVLMNZsmGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dppTGMk2Sd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzX+mA9xLRezQGvhC2FbU/2xMMB4vcRicr6ift1GAUdNjJ BlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQMMinN87Q3otz FDht8jyGTVlvbmRSHSc3rSZtzW/PW4SN2BqTS0ZSQoI5fHzrYd1iQjAJv5hGqOoitz+GRnr3 iuH6iM5gt07rcMNzbT9wlnBjBqlvJ2PRQkwjjg7RUqg5wJ9IYWiPoqh7AGC6e4addnGCF6co HIDhs6SqvgUCo2AnzCMR+NLG6y14/GCM3vXhlsH84QdyglBMkWLJeh4iAyS7m8wWirYUVcFu HPuhD4= IronPort-HdrOrdr: A9a23:DFUMqKDeN+UiT6HlHeiEsseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzI39QWUijusybjiVzyVxA0XXT9jyaortT GtqX252oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuQFNzn2jQ6sRYJ5H5mPpio8ru2D4Esj1P PMvxAjFcJu7G65RBD6nTLdny3blBo+4X7rzlGVxVH5p9bieT48A81dwapEbxrw8SMbzZJB+Z MO+1jcm4tcDBvGkii4zcPPTQtWmk29pmdnufIPjkZYTZAVZNZq3M4iFQJuYdI99RDBmcca+d pVfYfhDTFtAAqnhkXizy1SKRqXLywO91m9MxM/U4euokVrdThCvjclLYok7zc9HdsGOud5D6 6vCNUWqJheCsARdq5zH+EHXI++DXHMWwvFNCaILU3gD7xvAQOFl3fb2sRD2AiRQu1/8LIi3J DaFF9Iv287fEzjTcWIwZ1Q6xjIBGGwRy7kxM1S74Vw/uSUfsuhDQSTDFQ118ewqfQWBcPWH/ 61JZJNGvfmaW/jA5xA0QHyU4RbbXMeTMoWsNAmXE/mmLOCFqT68ujANPrDLrvkFjgpHmv5H3 sYRTD2YN5N60i6M0WI9CQ5m0mdD3AX0agAY5QypdJjubTlHrc8wjQ9mBC++tyBLyFEv+g/YF Z+SYmX4J+GmQ== X-IronPort-AV: E=Sophos;i="5.96,167,1665460800"; d="scan'208";a="84536199" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fDevdKvUHOBKgmkk7m5mTnxnO2IDaPFbX/CVU9MYeQsFqJSeg82vR/I3Vsn2bFjLVUnObGgnbJYsg8ntpkkmCsdduIN9ahno08R4qI+1rvzLK/8tYuUshNQkiZbWIIBdhM3Idn+Iiny0cxeBvRNRCZxmwt7fMr6a/5PdwMjMQzogUJ+myJHCPfO1foCFypIoXxMq7xDp1HqME2fpYcGBPGwJs6q/i0CXX3pmaDJFPZET2MvYYS4isUQdE8uPL2t3G/Ffo6kujLHtR5RDo7ZM6SIywl8aVWa3Z374kdefDvDX+GCODu2cBjgnrRdlHSVA042Y4xJuzxZ5SJB+a0BNhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5qvE2/yZGFCn28tmqkqGx9hXU6pc2poFPRL+ZATTm2w=; b=AryvJCg3D3dhC5k3sZkuWBCn3VKZBamOz7KgV3z7Hc3AakRTZ0V84hIT9vJwuX6B5YqRAEoPmm2WeqDUPyyjTiDgt/EKxEjZn9E1wo5kgevWdaWmjHc69mwqwVIqcwL2cAE9GgzkBMqXDS4QV+GA9iy0ZuSgnDcu9Ny7a/anrQ57i0/xMukziOfnpPqh2xmmYTXA6QcxTFjWdyySnt1xNlgGzLVUjE6c+21LEiR4bV/N8AM7XKV4Di+JMAr1QZeoEZJ0jK7zMCzYndaNGH0Pf0e9PCLlpPSMyKc5Cipb/VgnDHZ70UUy1IU/MxzCueaT+C9AgvDO4MnxK+c/upo6Jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5qvE2/yZGFCn28tmqkqGx9hXU6pc2poFPRL+ZATTm2w=; b=hqGP1xoPHO51SYDev9/o1tp4r//dmL6w8KIbBOZ8xU35489bRFjDSaR4eKPeotvHUfr35qgwnV67meP5qHhoihvhQsOK2tU187pzAwdjn7Heq/Vpi5YGauv86lRXKfNV8a3E59hMhmV9s9naaflx8Sii408Msqo5SDNeX9wzfdE= From: Andrew Cooper To: Anthony Perard , "xen-devel@lists.xenproject.org" CC: Wei Liu , Stefano Stabellini , George Dunlap , Julien Grall , Jan Beulich , Henry Wang Subject: Re: [XEN PATCH for-4.17 v2 5/6] Rework COPYING installed in /usr/include/xen/, due to several licences Thread-Topic: [XEN PATCH for-4.17 v2 5/6] Rework COPYING installed in /usr/include/xen/, due to several licences Thread-Index: AQHY73rOgdQ+1dfJGU6Fms0w6mCdf65BwLkA Date: Wed, 16 Nov 2022 15:26:48 +0000 Message-ID: References: <20221103115204.49610-1-anthony.perard@citrix.com> <20221103115204.49610-6-anthony.perard@citrix.com> In-Reply-To: <20221103115204.49610-6-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|MW5PR03MB7008:EE_ x-ms-office365-filtering-correlation-id: 3fbf2eb5-3314-498a-fa14-08dac7e6faca x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m7moKWxQXxcGyHnpKqZPAMJOqmIfZsK6Mk6Rf81IRX/FJJUloi7E+RAj7nUJG+JWrcF4kL9kIDDk6m2XBgOhL213MYE6cyXqHFnqKmIoX6EYnXgNumwyZnFPGw05DXGTpoE9Iok3b3b8lfWTjP3Iq3avTipVCgzmg2phMyr5wDFxgXFq0WntNIgudRoBXDN0BPvAefBkZtXVTJWkEB2B/0mTSM2Jc4tfqPP9ipwNLTyTV+x4Q+tcx3di8nYqC+q6odsql/nb4dpWeEi4Ya/Xqn6+S1GiE3sj0CcBIzmmxclM1Pt745gEsS2ay6+zeV2cjJLlWFMi1CHlf/t3qem/2JizBOGkj6dnTsnDvqLVBYc43E791/z6YwloBRQGstoxEw3ATjmSQ/8HB3E4ck87NwM2RzZfYw+od3cBMNmWLxt74k6MHIX4kzIFZ+X3RMEOvYgO3ZBTA0XGBxvgQOIR9STqhVEHwxuAGSsVDd9yS7kPAKO7yky78UmuRQoev0yYbfPxn6/2nkUbLKXF/jPW/XhT27zqnMJBy07Nplqh+kWVYHiYXV/8Jqf+2e8WBopAmcwjPTVqDSnNNM5bLv2xpEJuNSYY5nfg7oJuspxbz7lCQAC5S9GUT+cIPRtKz7i3IOmsdvod82k667iXpezJqhg8MrzBWYj2v3YBqHj4qVpZzTrEG4R3N7uwWvEilYSLs6V0Vyxwr+ctX/JrwFRL5w4a2owelSx+BVHt1lHFtP4nHqWPqMYnF111xvtXH5ta+5dBPAG8almyI649sC5bMtgo2gjOFo5DvATcBRhBXHcUz8TIt3+rNF98fASud6uzOZw2fjmExRil2EUAsLlA6Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(396003)(39860400002)(376002)(346002)(451199015)(8936002)(4744005)(2906002)(5660300002)(31686004)(41300700001)(54906003)(8676002)(76116006)(91956017)(4326008)(71200400001)(66946007)(82960400001)(478600001)(66476007)(66556008)(66446008)(316002)(6486002)(36756003)(186003)(26005)(86362001)(6506007)(53546011)(31696002)(2616005)(6512007)(110136005)(38070700005)(83380400001)(64756008)(38100700002)(122000001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SXBrbFUxTFlZQmlXNVRTWThIY2dKVDRHSWViWDdmSGtaSGp4WFhDY0RCN0VH?= =?utf-8?B?MDBaQ01mOTFOVmtya3FuSkNmZ3lIY2YvMFF5LytGaDBLZXIvekpuRitXdTA5?= =?utf-8?B?U3F0OUVmREF1YW9iUFFkZUdqRGV3Umx0TTJBWVBzUW0xQnhTV0VUYUE3cFBx?= =?utf-8?B?amR2NnhyRGt6WXU4R0cwc0lOUE5yZWtNQWtlc0JqcGVHNW9XYlZ1Z0dKSUZq?= =?utf-8?B?SzNWc3orM1pNMGpoS3l3SEx3QlBNN1FabEtjenFKY0t2RXQ3ckxtMXFwUFJI?= =?utf-8?B?RWU4VG4rUUxRSTVCTUZjMnBGVHlRdkVTOGFMSnVZYTFaQWV0ZGU5M1BMcnlX?= =?utf-8?B?ZW9IRTA5N09zNE5CS3FWNXdvNXZWQXBGYXVWNHFaNWFXOTgvclFtVmNjZlJn?= =?utf-8?B?SFRYSXhUbWJ5d1kvSndwTnZZcXBJMkZ3MTFyUlpOcnFFdkcwMXFmRkI4OWpY?= =?utf-8?B?ZFlDR1RaY3lobEM5OTdXMWg5bGdKa0tzTGxtWkdubDBtc0NwZXNOS1krS2tI?= =?utf-8?B?a1pzWmdZTThLeWhMcDBhMU9hR2R0WTZibW9YdzBUU3M4TlVUV3oyTTB0YU5F?= =?utf-8?B?VG45ZjdBdFFYQi9ZUllkZHdUblU2OEpxMVlOTWRkVUk0V1I0US9rRFhTeEVX?= =?utf-8?B?Z3NVbGpuanNzNVZnaDhwSEZ6Z0JuQVQyUXQ0TG9vTk9lVnNhdTJqR2taRFVX?= =?utf-8?B?alJtRk41WkgyZ1J0ODZBRjRYMUN6bHBVZGtjeWkvNFVuVk45VGViREdnZE9L?= =?utf-8?B?anJsK0JmTjBVL0J1ZCtUM1RVRlFUKzBMT1htSU14ME5qaHJmUFJITXE0U3Iz?= =?utf-8?B?RG5hYTlJQlVLYUdGUUpuanREN1pYaFltdmpWdEJ4TlB1RjNzbXkvekp3cjJu?= =?utf-8?B?ZmQ4T0JFOVI1dVZ0RWtqd0c4bkk5ZkdnYktEL2xGZk1KMS9qU3BCYjc0MWNY?= =?utf-8?B?UFNibjhlZjBmTWRIT3ZrOFNPTWhQR2xESm5KL2JVdmhleEhhS1piTzhaeHd2?= =?utf-8?B?Y0V4bWtpd2JDY3dSbkpJMDFTUy96UHhscEQyTkl0Z0lBRmZHUTdKNkRDZ0RE?= =?utf-8?B?dVpHd1oybDJSbTdiTGpWejdISUhVK3VNZVoxMVVNZjFlUmVkRFJoNTExN0k2?= =?utf-8?B?ZEIybXI4Y1RvdnNUQkREdWpXOEIrdTZlSFZPa2Nja25uNmxXRkdEQ2J1cm0y?= =?utf-8?B?VHlXbVFmUkk5ZCtVanZIMzVYdmthTkxGNENhQVBEQ282eURxUkJMSEUrMGwr?= =?utf-8?B?WTAxQXNOM2FqZ1YyL2NtS0Fjc3l6VFNtRnlvZXZxZWMyNnFKeEJuNWlUb0d0?= =?utf-8?B?Q1Rnb3JRNHVUSWgxaHdZRjBTVWtlVE1QSkVkanhzZ3RmdkFSU3J5cHRCTVhu?= =?utf-8?B?QzA3ei9yZG1kMVpGakJleER1cFdSenMySWVVN09HNE9sTE9oMHhadFgrVVJp?= =?utf-8?B?dHlORHg2K0V1SEt2VWVGakpYc2tHYU1oUkhpeUpZbDRRVkhUcGRrL2Z0anVp?= =?utf-8?B?aDBsY0RNbFN3MVBNQ1orYmlObEhYQTRzdjJOdUc4bTFaaVFob3IybXVyQnVJ?= =?utf-8?B?T3c0ZDFJS1V0cXJOY0xjY1F5U3lETWRZUDJaZE9rOElEeStSRjB0eXhZbmZv?= =?utf-8?B?MVhaVTZtL2Q3Z1Z3UmlEMmVERm03b2RHMy9obnFaTUlZRFU3YTVDaU1WdEh4?= =?utf-8?B?S2pvVG1pem90SVNQdUJheThrZVp2L2RPb2VsVUh3YkdyWnNuMUwzT2o2c2U0?= =?utf-8?B?WVRidjN2VXZhTmZjSUhrMjlVSi9sRVUyQXVZNHVCd05Ddmw2WTQvaHVLQld4?= =?utf-8?B?WnpDeG5aMzVhWDlIS3ptMlpjQlVwNHVINCtpbTNWZG5jcGRWVW5xL2hxaldq?= =?utf-8?B?RVFFWXl1K3kxaE1FbUhOVlF1R0FSbVc2cGdMMVJxZlNxQm1DdCtYTjIvVTlH?= =?utf-8?B?QWNST1g5bWJUTjV4Z2Myb2krVFlqT3dpMFpGcmd2QUVXMGZyOG9iUEJZbVp5?= =?utf-8?B?bUx4dHd1TkhmRFVRZHd2OFFCR2JnblFFSTEzU25HYkVPM2ZQOUlnbmgzcmtQ?= =?utf-8?B?L3JaR216RHBUL05WMnY5U0REdU14ZlFkYlR2R25vUXJvRXV2b3dHZmdSRlpt?= =?utf-8?Q?pN6whNsS3xohYpn7Cs4ijiPPQ?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: yZ8qE7WwCs1IIIseRLCUdbj/nqg9IJdkUUcVkHrGDMdFzLswbjVSzPDGySaXl/jiINBHUrRhsgSu2jFF4V3vnOZmK3UtgoJ8icFUm2XtvR5iEAiqkE+x95wG7+y2yyB8YtpaSQwEewXsTSwfiJn5n1UNjdvrIOEzeYyG07zdkzB7bPgPZNM9zEmKgDXl5Y5pztOq5AUFkD+u89mMxpX8pkmb4vdppHCANbnoFL62bsAa+9CtEkrGwrrnaMX9+GiXgvpD86XDscBLjsP0+BMx4u5vecrsaJwB5xDmIx7hWJV3zBOWOD9Zt6nGYEUkjaJaXlW01fkvXFsgbHQ5M3M04evdSrzcJn9Uj1EZH2O8MT0EFzQ2whgaTLQ7t876denqHyGMQQVvzM2KgsdCtPdPE3ZPL4fBD84s8votCoBK7vj1aQq/f0SNXNomgIXaMasM5MLNbOmFxJwVR+fVdVdkR/t+pCK8SUj+sZdvcDIxHx6gXqmizMuoGC5sR+Ph1wfsqL8QiCQGufu/qU6ExuccTkL6T59x2RBN7XyPMIuUpFRtcxZEaeU27bs1Oi7ODbkw6n66elluQyvWIlSYX2DP4pbzTGVaaiQLnfNQ2ECgYfoOtJbW5D9tTy0lOirmncPfWdO46ExZ7xdEPiW0rnA1uCW36mi+YHHjd8JecvW4NhBl90NBbiqQ4ElkmSMCLLOLxIRPTQc8Q54vdQE3xCsnoc6S05bDN07LbxOuF4YEXXOAHUIounRT9huucaEFlbKT37hUrJEa/GJiRmc4JFf0U9rbTfTSUCizDK7fw85jpe8I/5l5PSHjP4mYYOO/qrQBt4pccbIL/HXX3knwIvo4LzLOGmWm4Dw7aJnuj1EJtwIOEeQZY+mvIgHPOxHv8CbVMfJbMMnAqGzEJiqMzNJasw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fbf2eb5-3314-498a-fa14-08dac7e6faca X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 15:26:48.9889 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +mBWA57l8bWM67+DD2CMAAZn6dCl94OLoA1XQob3V/oQP2p1QD7Bv+2U44/MsGtGb5M0WNiFgLGb2c7dDpIH5wdXM5ZmeNJ1GmeLt3xppi0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR03MB7008 T24gMDMvMTEvMjAyMiAxMTo1MiwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IGRpZmYgLS1naXQg YS90b29scy9pbmNsdWRlL3hlbi9DT1BZSU5HIGIvdG9vbHMvaW5jbHVkZS94ZW4vQ09QWUlORw0K PiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiBpbmRleCAwMDAwMDAwMDAwLi5mZTNmOWI3NTU3DQo+ IC0tLSAvZGV2L251bGwNCj4gKysrIGIvdG9vbHMvaW5jbHVkZS94ZW4vQ09QWUlORw0KPiBAQCAt MCwwICsxLDI2IEBADQo+ICtYRU4gTk9USUNFDQo+ICs9PT09PT09PT09DQo+ICsNCj4gK1RoaXMg bGljZW5jZSBhcHBsaWVzIHRvIGFsbCBmaWxlcyB3aXRoaW4gdGhpcyBzdWJkaXJlY3RvcnkgKCIv dXNyL2luY2x1ZGUveGVuIikNCg0KVGhpcyB3YW50cyB0byBiZSAkaW5jbHVkZWRpciwgd2hpY2gg bWVhbnMgdGhlIGZpbGUgbmVlZHMgdG8gYmUNCkNPUFlJTkcuaW4gYW5kIHByb2Nlc3NlZCBieSAu L2NvbmZpZ3VyZQ0KDQpJJ2xsIHNlZSBhYm91dCBzcGlubmluZyBhIG5ldyBwYXRjaC4NCg0KfkFu ZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Nov 16 15:56:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 15:56:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444339.699432 (Exim 4.92) (envelope-from ) id 1ovKm7-00016Y-HI; Wed, 16 Nov 2022 15:56:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444339.699432; Wed, 16 Nov 2022 15:56:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovKm7-00016R-EJ; Wed, 16 Nov 2022 15:56:31 +0000 Received: by outflank-mailman (input) for mailman id 444339; Wed, 16 Nov 2022 15:56:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovKm6-00016L-7h for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 15:56:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovKm5-0007Io-0N; Wed, 16 Nov 2022 15:56:29 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.13.29]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ovKm4-0004Xd-O9; Wed, 16 Nov 2022 15:56:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=DPQcueX9NLjbdpT9PJdSJkME1J5QliSfuooAzXE/UYw=; b=PhtG8i1tlRZ7hbEWixuIsQBf6q gi1sopr+mC4qWCE9R8yIsv7UEBntjrLn3mYjSkGeLg04jNtZ7/I279WiUIhA6Ul0jjYI5fpRqGKKS OtKJHd65IugqWWhabJ8JRtIb8zAeygYI6RA6cz6RrCB8oA+tq57FiUoex5VEQlCziim4=; Message-ID: <0400b2d8-6f2c-6406-d966-64ed5720688c@xen.org> Date: Wed, 16 Nov 2022 15:56:26 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> From: Julien Grall In-Reply-To: <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16/11/2022 14:45, Michal Orzel wrote: > Hi Julien, Hi Michal, >> >>> and use it in the pl011-debug files (+ there is a question whether we should define WLEN_7-5 for completeness). >> >> I would not define WLEN_7-5. That said, I wonder if we really need to >> set the baud rate & co here? >> >> AFAICT the runtime driver never touch them. The reasoning is the >> firmware is responsible to configure the serial. Therefore, I would >> consider to drop the code (setting UARTCR might still be necessary). > I do not really agree because the current behavior was done on purpose. EARLY_UART_PL011_BAUD_RATE is only used for very early debugging (this is protected by CONFIG_DEBUG and CONFIG_EXPERT). This is not a production ready code. > At the moment early_uart_init is called only if EARLY_UART_PL011_BAUD_RATE is set to a value != 0. > This is done in order to have flexibility to either stick to what firmware/bootloader configured or to change this > configuration by specifying the EARLY_UART_PL011_BAUD_RATE (useful when you do not know what > the firmware configured). The chances are that you want to use the baud rate that was configured by the firmware. Otherwise, you would need to change the configuration of minicom (or whatever you used) to get proper output for the firmware and then Xen. Furthermore, as I wrote before, the runtime driver doesn't configure the baud rate. This was removed in Xen 4.7 (see commit 2048e17ca9df "drivers/pl011: Don't configure baudrate") because it was buggy and this code is not simple. So it makes no sense to configure the baud rate when using early printk but not the runtime driver. So we have two choices: 1) Remove the baud rate setting in the early uart code 2) Support the baud rate in the runtime driver I strongly prefer 1 so far because there are not any practical use to have a different baud rate for Xen and the firmware. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 16 16:37:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 16:37:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444345.699444 (Exim 4.92) (envelope-from ) id 1ovLPR-0006qi-Ma; Wed, 16 Nov 2022 16:37:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444345.699444; Wed, 16 Nov 2022 16:37:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovLPR-0006qb-Il; Wed, 16 Nov 2022 16:37:09 +0000 Received: by outflank-mailman (input) for mailman id 444345; Wed, 16 Nov 2022 16:37:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovLPQ-0006qV-ME for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 16:37:08 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e70143f9-65cc-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 17:37:06 +0100 (CET) Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Nov 2022 11:37:00 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by SN4PR03MB6687.namprd03.prod.outlook.com (2603:10b6:806:21e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 16:36:58 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860%5]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 16:36:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e70143f9-65cc-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668616626; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=zbw9Px42LxjFB4IqGWtiqW+qJGi0zpfiyeXbEKAjx2Q=; b=SlO4UO8UGe9qeiLRJt/HxmEB7TTY8ZoFmurvcdfflf+tO1Sg2hs+H/FR q/5OJrCPlJiaSJ/Y9kKXMlPGevN6CAHwg43QlkOm/3mirnAls2DLcZN1v D7fNxecqWGXQMAYB3jAJUNISUwo4T30HLA2nhIeaN1+hMHyNJZdyw/ZHz A=; X-IronPort-RemoteIP: 104.47.55.171 X-IronPort-MID: 87496799 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:BDmO8Kh4PTam8HJ2Y81px0BKX161hhEKZh0ujC45NGQN5FlHY01je htvWmrVM/mOMDT3f4p/aN+z8RgB6pLcnYQ2TQQ5qnhgE3wb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QaAzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQxcw0SVEymhd6/+7GkYNB018YOcZLCadZ3VnFIlVk1DN4AaLWaGeDgw48d2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEsluGyabI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6ROLkp6A10Qz7Kmo7BBkrBXzlptiC0FePVcMFK hc9o3oCsv1nnKCsZpynN/Gim1aUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebSMu/ k+EmZXuHzMHmKaOVXuX+7OQrDWzESsYN2kPYWkDVwRty9v+pIA+iDrfQ9AlF7S65vX3Ezztx zGBrAAlmq4ey8UM0s2T3V3BmSPqmZHPQSY8/ACRVWWghj6Vf6agbo2srFLdvfBJKd/DSkHb5 Sdd3c+D8OoJEJeB0jSXR/kAF62o4PDDNyDAhVloHN8q8DHFF2OfQL28KQpWfC9BWvvosxezC KMPkWu9PKNuAUY= IronPort-HdrOrdr: A9a23:UuenOK2Igaw3kW0RAW3o6wqjBZpxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LoSK05KX8Gx242A5bdz9U278t/U XMjgS8v8yYwrCG4y6Z81WWw4VdmdPnxNcGLMuQivINIjGpphe0aJ9nU7iiuilwhO208l4lnP TFvh9lFcVu7HH6eH2zvHLWqkfd+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ g7nF6xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklUqvoXRiKrbzPIt MeS/0018wmN29yqEqp51WH9ebcGkjb2C32GnTq9PbliAS+10oJsnfwjPZv4kvosqhNC6Wsrt 60TJiB3tt1P7ArRLM4C+EbTcStDGvRBRrKLWKJOFziULoKInTXtvfMkfwIDcyRCes1JaEJ6e L8eUIdsXR3d1PlCMWI0pEO+hfRQH+lVTCozs1F/ZB2trD1WbKuaES4ORsTutrlp+9aDtzQWv 61Np4TC/j/LXH2EYIM2wHlQZFdJXQXTcVQsNcmXFCFpN7NN+TRx6TmWeeWIKCoHScvW2v5DH dGVD/vJN9Y5kTuQXP8iAi5YQKYRqU+x+MELEH3xZlh9GFWDPw8juE8syXI2uibbTtfr6cxYE xyZLv6j6LTnxjFwVr1 X-IronPort-AV: E=Sophos;i="5.96,169,1665460800"; d="scan'208";a="87496799" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V9rBgKCfCFdUjZi/gFEJyejaidmzp8GzKiV5foPdCLSM2GvfTA7Z7jAJGlFY1NnHcH/0oEfCzX2erpOd4Xs3VF5wREhBeWvkNbwUzHC43snq8Mu/3G019UW9Ci8cxztV0uiljpcJCw74IbWjug1DjOTRSOGkH+bKbvVSZWfmaohrVb3qxC0QZ6UGle9C07p3/8EbkwoauCfCKsBIUy6ggk0rZqV4z7qlhhvCsfHUf5SY09qs/lOIl6IS64aXCWhZ95upkzS6zfs2kUW7KZCqIqs/P/6GNWHc/e7G7J1hXS1QJ8cLL7+zWQeWVp+Dwsey/waEzcsZ9PvAvUneYud9Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zbw9Px42LxjFB4IqGWtiqW+qJGi0zpfiyeXbEKAjx2Q=; b=Qktq5Q0G9QN9N3eaCJy+MDE/2p9JsbKPGgaDfUt46+RdNl09gFd0x2HHbdlfif9c9p0tUhkwHoci1QDoD1aNJQGqFd6MWuQsuNMBP5CkthgXSIVXPj7ZFzlG82HK0bM1Rff5QQHgseCqADchpaDt3P3An7teS7cPexn6gmaL5JB/62692dWPWEru7ZWq2f9XZFDkM05eDl5SKt7n+cC/tHXmStogyZG5UznIWc7PQo+Msnnj2aPdwLONVpz64eHwVsi658uTCDMGV9subYkMUB6P8QjH2Fz/ScVMTRZpMJK0iSzR8/g4JyXHmwJxNDM2wgWBmY9sBdqB0vMkNA0s6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zbw9Px42LxjFB4IqGWtiqW+qJGi0zpfiyeXbEKAjx2Q=; b=rXmZ3tFIovNo8hEVK80bc/CuUetGDObmHl5i6gDep4A5S1gAY/QgdfU8EL71++EN18efKamShIFMB12w8rtb33ADE1wPNhIOBq4T9FTbqc+xXy3kmuXaf0C8xhrbCtBplRY5VEUB/OjoiE0iZ0mBRRQjYptXzMchb717Bw85R4Q= From: Andrew Cooper To: Anthony Perard , "xen-devel@lists.xenproject.org" CC: Wei Liu , Stefano Stabellini , George Dunlap , Julien Grall , Jan Beulich , Henry Wang Subject: Re: [XEN PATCH for-4.17 v2 5/6] Rework COPYING installed in /usr/include/xen/, due to several licences Thread-Topic: [XEN PATCH for-4.17 v2 5/6] Rework COPYING installed in /usr/include/xen/, due to several licences Thread-Index: AQHY73rOgdQ+1dfJGU6Fms0w6mCdf65BwLkAgAATmoA= Date: Wed, 16 Nov 2022 16:36:58 +0000 Message-ID: <80e6cfe8-1089-15f2-b294-11c9c3af763a@citrix.com> References: <20221103115204.49610-1-anthony.perard@citrix.com> <20221103115204.49610-6-anthony.perard@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|SN4PR03MB6687:EE_ x-ms-office365-filtering-correlation-id: 45b635df-1ddd-43ef-d97c-08dac7f0c796 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xrjSlvVOKYOnucb5aP1Y+hn6ahp8jCw0U5OwOUr4z4H8M/1/BZx8cFBM7BAi1tg0a6+4WuI5oBBgEg3UYQNo2EOyqm68+b5CAxf68OZ9Ps5mUOgTcKWlbftWb+DqxEDPnC7sT/enmXholk/khWcKVygazgXTe5f1FnHLED5/t/xqedQTWyUg9eHfB4qPHcVBG3w2Z/ObAO1RCiUf18PR9/eZPUIoC9svmidmxTuNWeXmUtgzZJwfnXXYwh8B/4DUxkQplOsa0JapvHwnsuxM2aZ5cCfwGI7ZNuHP6/tKbnvJDl0Uqq3Ah+Yv5SNpVFtP/ZBSBoOFRKTSfWWHipBCB9Pzch4rE/6/giZbeIUscuxooELmaTv4jJKG2nALIEzaBGwqGljvjssIbVhmflQzn3MMPy+BVxUd6XFEHWDy5VDZaDW8RKpFoKleFtYP9v6rUqUnAOVwdzSac8h68zMZlFuxaZvBL1M5q4Nwe7EQFW7bq5cTh+Z1Dj07Xv4iw51FiTZeIvQIRhVp4FsViJ6oSQJcKZcV+NpG2KazfhYwsaFCI1KCjTMD4MEyvSsdAHKYI/KA/5BRMgLt4FtVYNiKwO+jELyI9vfuyqzYklLjtzjZcRqD2nUfab5kfkUYRuVc9Q8+CpxBuGYvrWvoJB6m85VWJay34ZLFQQHWCcb9kzDf0TlGrWUVumpl38Dyi5Bj7vKXz5Dc74aJpoZolyiNOTyLV40i/G20xJl4Dyzt/xhp+CNwPzRBhwssH45B7xKqPKToxNxM9uWGDJVCt8k+bGzMjNPLpy84dhUJr+iXaT3dy+YrBQvTChkjMnSq5AZj09MpysSmHUI8xHQpIUc2Rw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(366004)(376002)(39860400002)(451199015)(36756003)(31686004)(122000001)(38070700005)(38100700002)(4744005)(2906002)(41300700001)(83380400001)(31696002)(86362001)(66476007)(64756008)(8676002)(316002)(66446008)(71200400001)(91956017)(76116006)(4326008)(6512007)(26005)(66946007)(66556008)(110136005)(6486002)(54906003)(186003)(82960400001)(8936002)(5660300002)(478600001)(53546011)(6506007)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q3lQcllOZk9qN2lSUHpabHU0TElGOFRLVlBSbEdnVXRKY2t1Z0x5dDIwa0h4?= =?utf-8?B?UW5xOFRjVG1xQ3A2cHJMcXBaY2hlTitGZzl6ekNwbzFtVitBa2NBc2Z3UnRp?= =?utf-8?B?NHNzeE9Hb2o4aEdyd2JNK2RGakdrSzYyalNEZkVwSkM5aXZ3NUxLL1h4a0JT?= =?utf-8?B?bFhpSk5LeXVvcDNGVFAzZ2ZVM1MxaTFNWkw0MHYzVkJrcEFsR2VadTh0RjFY?= =?utf-8?B?QnFpbmhsRHlZZnNGVkdHWlZXSVhaSUpDenBmWDdYWHQ1emNYRU5jYjVMLzUw?= =?utf-8?B?cUtweVh1SzRNQndDblVWQmVHbVBFQTFwaGhBVVFobUZLSmhuZWNDZGhKT1li?= =?utf-8?B?VThtMWhVajg3T1VnUk9USnMwMGhJQzM0K1BOUktncWpMMVUwV0MrbVQ3Y1Ey?= =?utf-8?B?T05NSWxQQWppS2NjNWNkT0VTRXRjYm9QQUpicGR0Qis2L1ZYZkR1S3YvWTNt?= =?utf-8?B?eVNheW12cEVlejQ4L2V0WHFrMWJRZUdtN3Q4UGJCR0JNT2JnSGJ1NXFWQWk4?= =?utf-8?B?ZkI0Z24rVWFCanc5SFBCbXQ2Yy8wWERVdmdGb2hHUDdnYURsMUhLTWQ3Q0dy?= =?utf-8?B?eUZkYWJHb0tDM1duWFpJNmViczM4OUt0NkVHdkhvVzEranFjQzN3U3d1R1pX?= =?utf-8?B?RnZLd2ZaRXZBZjdzRlczclFOSG9XQW9ZSFFheFpZZ0VzSHJkcGEvVDIxQ2ho?= =?utf-8?B?TEZCelBtS2lGMU5jbW1VYUQ4S3ppRjRVV3QvamxmdDY4T1E1Y1l0YWh3NVBY?= =?utf-8?B?VU5ubzZTVDBaaFBPSW5KVmMxb1ZJajhIaHliRzNlWEdOOE1XM1dncDR0NytI?= =?utf-8?B?djM2VmhMOWdmM01mU2NMajUxMHQzV3ZvTWJJRG55Y2MrMU5hZTM0cEQ5VzVF?= =?utf-8?B?RXFyamtBbnYvRjlVdGV4cUFueGh6aUJzU0RwTjZlYUlLV0NFSVN1bEl4Z2Jk?= =?utf-8?B?MDVlc0svaFMzc1RhdHp0Q0dWdlNRT2Z1eTllcGhnMlllQXRadnlIS1k1aHFT?= =?utf-8?B?K21jUWJCeGpGOW1JVXg0K213VFJZNkZtSzQ2c3JHRkF4dHFPUG9hRXBIWXkr?= =?utf-8?B?UkdPZHJNNFltVFJYV0NhVVAveHpJd3BRaGppV0gvRmxndzh6TStid3FEN25R?= =?utf-8?B?a1VUOEdQbG83YnU4SmlxSCtBVCtLY2ZROWJsSGl0TlhFV01vT2lZWmg2aHVW?= =?utf-8?B?b2xOdVVDNm1OdVZWa3YyOUYxVHlCZVYvUFJwRmE5MG9kMHh3QUkxZnRQOWx4?= =?utf-8?B?NVR6REt3d3RYajUzb0dMN1JtMDNwYm9jdVhnRldZQlZkNnRYdStJUDc0aEha?= =?utf-8?B?bTJkYVF4d1hLcno5VVZ6eVhzTkRIN0s2dmpwM1dPSWtrbGQ5RDZxQXkwREt6?= =?utf-8?B?RkVONkQrSlJidHlPMFVTaVJvY08rR1JJU1UzSXJjNStEZzQ2WWFVNmZpRUR2?= =?utf-8?B?NmREYXp0T3BzOEZ5bG04WEQ1UFE5bFVrK0ZBVWV2Wmt6UHJ5enZOS1VBVHJo?= =?utf-8?B?cnJhTlJ6S2xtZUJFaWpIbGlPdEN0SjM4NkRJZDQ3cUloY2J6ckkyUU1Damtz?= =?utf-8?B?TFJINWFEd0MvcGJ1OUxobTdMcHcyeWl3TGplL3V4ZU5nbUlIUDhQMnZqWGJ5?= =?utf-8?B?RFBIRjFSL0FKUXo4YXI5ZjlJWXJQYm42TW1iTFp4cnlEbGJkKzVCL1JlNWdt?= =?utf-8?B?Y3hDUmU5R1FJWXVQTkZCM0Y3WU1SSFRSeXlBclAxMlhFd05LZVFIRkVscjdn?= =?utf-8?B?aDZQVm1lVGs1UUpNRmY5QmZ2K2ZsUWQ0QVhQeE5YMkpacW9vYjBvMnVyTEpL?= =?utf-8?B?VnphdEZabkdBOEJHc1RiUkE0K1ZHSFpEdGFnOFQzUEFDZVllZ1NUbWN0bHFM?= =?utf-8?B?SWlZUXFJdGlFbTZnUTBRZFdMcWNwdU0xV1NxNzdJcWhEeFFGUWJWK2tXdlRj?= =?utf-8?B?VzZCVDRSNklMdlBtRnlqRDlWVkd5VTRGUjI2SFRrLzZvNTJtVDg2d09pZmo4?= =?utf-8?B?RTAxQXNDTGpicXFMZUdPN2xpMHRiVUtDL2ptVGR4K3FDWXBldGx3S3VSaW9p?= =?utf-8?B?NW1YaEZqNzkvSFJsS2FER1ZRTVQvVHBobVBBS21WbE04emw1SjVHWDRDbS9J?= =?utf-8?Q?YgwcU1aEY5hpzLtMwK2gHfUWT?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: iOV3wOElaMaLIGmS5Lm6hXF4JB01zM+CNtq1LV+mZDNtW9MBjskjXlE12h/nsRn0KI/9Ctr/QMvNbAeTwLaCKccEOFdtx9J1SrJ3Bt4d6v2tjsDqNN2JQi+0tr+XkXURNwIKKRrCw2kcLDko3k2KnQ0zhm8jixkjWpr2uwS3KtSpSCiQuQTS65MckkcGIdi2GrKgLwgo+4oc35zBmPPIu7I8pUx0mit70JRIR9TiTQAW7XuJ4zdzOvh+DBt5OGTYQ266mA9KEk77BuPzpPmZTvdhgaWPnzPLdNii6PeVjLF8acrEHL1yDkDylaGyZFalkre9yiIaHpmsXXEWhrrW40gCEiXHSZbU+m9eZTdhKA3mCD50piqmIJdyDAxiAnGJH+VSNK1xVqoGabThtx2Xks5DZ3OeEaWcpIDI/CTyY9VnzKGaZpdm4r4DRl6v1SvEVeA44b3wpEW3rPWxGaPMSidMg4T9w/VHnA7lATZlOJXQj/0Ag8JRBzSijylE5J9+t5aiIS7Cm13Zz6ZP9MWKwsqjnT3f4D83J6XetHMyh7BydMUb2gG6ZMzn7BObBYxkhO3nDTprYM9FVYj5fKTDSE7K9Fh3TU8UFAjiWm6qddTJqofsdxbdAuvBmP+sffa+XfxWg/Px1QzEJHxm9/dcg8GvgyhSXUuw0zCOL94T3mMThO/nDMwP9u+F+0rXd5mBdR1NtzaLnQ/b96gYETppJj7AaG3MNKdBDRhsA88R0hBZvXZM7mfOC+7+NcJOie15YuLsqLxqekgLZ1tkbyTCPAlFsADVK2x4H83Kmd6T2XFPOI60SdJeUdgyqGewlh/e+jm3RRgR00ryS5zM7sSAwBccsdLBlhET+cs16bNOxWvDGcejpWbhxlZNARZ7je8Gdb5jBOGdBoOkF5CFthbJ9w== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45b635df-1ddd-43ef-d97c-08dac7f0c796 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 16:36:58.0664 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fQIj79TxMc9A2GRVw7sFDhftb/0E/gwSJffyD3AZt0l5HXWwTMXdVHgwXRkGmS9Ct/6MV04MB+x7/Tu9R+RsTo3/idV34tRxuPSIAr/u7LI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6687 T24gMTYvMTEvMjAyMiAxNToyNiwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMDMvMTEvMjAy MiAxMTo1MiwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvaW5j bHVkZS94ZW4vQ09QWUlORyBiL3Rvb2xzL2luY2x1ZGUveGVuL0NPUFlJTkcNCj4+IG5ldyBmaWxl IG1vZGUgMTAwNjQ0DQo+PiBpbmRleCAwMDAwMDAwMDAwLi5mZTNmOWI3NTU3DQo+PiAtLS0gL2Rl di9udWxsDQo+PiArKysgYi90b29scy9pbmNsdWRlL3hlbi9DT1BZSU5HDQo+PiBAQCAtMCwwICsx LDI2IEBADQo+PiArWEVOIE5PVElDRQ0KPj4gKz09PT09PT09PT0NCj4+ICsNCj4+ICtUaGlzIGxp Y2VuY2UgYXBwbGllcyB0byBhbGwgZmlsZXMgd2l0aGluIHRoaXMgc3ViZGlyZWN0b3J5ICgiL3Vz ci9pbmNsdWRlL3hlbiIpDQo+IFRoaXMgd2FudHMgdG8gYmUgJGluY2x1ZGVkaXIsIHdoaWNoIG1l YW5zIHRoZSBmaWxlIG5lZWRzIHRvIGJlDQo+IENPUFlJTkcuaW4gYW5kIHByb2Nlc3NlZCBieSAu L2NvbmZpZ3VyZQ0KPg0KPiBJJ2xsIHNlZSBhYm91dCBzcGlubmluZyBhIG5ldyBwYXRjaC4NCg0K RkFPRCwgSSd2ZSBkaXNjYXJkZWQgdGhpcyBwbGFuLsKgIEFudGhvbnkgcG9pbnRzIG91dCB0aGF0 ICRpbmNsdWRlZGlyDQp1c2VzIGEgc2hlbGwgdmFyaWFibGUgc28gY2FuJ3QgYmUgcHJvY2Vzc2Vk IGJ5IC4vY29uZmlndXJlLg0KDQpJZiBhbnlvbmUgYWN0dWFsbHkgbm90aWNlcywgd2UgY2FuIHJl dmlzaXQgZml4aW5nIGl0IHdoZW4gd2UncmUgbm90IGluDQpzZXZlcmUgY29kZSBmcmVlemUuDQoN Cn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 16 16:42:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 16:42:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444349.699455 (Exim 4.92) (envelope-from ) id 1ovLUf-00008n-D9; Wed, 16 Nov 2022 16:42:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444349.699455; Wed, 16 Nov 2022 16:42:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovLUf-00008g-9p; Wed, 16 Nov 2022 16:42:33 +0000 Received: by outflank-mailman (input) for mailman id 444349; Wed, 16 Nov 2022 16:42:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovLUe-00008a-4I for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 16:42:32 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8454c21-65cd-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 17:42:30 +0100 (CET) Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Nov 2022 11:42:27 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MW4PR03MB6459.namprd03.prod.outlook.com (2603:10b6:303:122::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Wed, 16 Nov 2022 16:42:23 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Wed, 16 Nov 2022 16:42:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8454c21-65cd-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668616949; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=OA2UOlmEK0jhWbsT7GVJWWYil+xhxHaqWbkLy+dxszc=; b=gXsE5MG70VsLELGHgdIjkOaU8dt08T/KOoxr5FopZZXBKhOEqYA6p4w+ zspSnaCrrX5BZD68Q+oJLa9nKVDrP/TD5O2BDMby3glCoYSu84iguAiub /MsQ7+scbClaFkJFG1F5U1K72ndDRWRLgs6H024d6AxMaXjbuVBXwSl09 o=; X-IronPort-RemoteIP: 104.47.66.44 X-IronPort-MID: 87497199 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:X4kcq60PncS+gHjB0/bD5fdwkn2cJEfYwER7XKvMYLTBsI5bpzcOy mAcXm2Ea/fbazfxfop2YI+29R4H68WHzoBjQFY+pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVnO6gR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfE2Vg+ /w+LT83chm4q/rtnZ24Fvl2mZF2RCXrFNt3VnBI6xj8VKxjZK+ZBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxpvS6PkGSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iLz2r6QxHKqMG4UPOyY9fVBokGv/WUoODI9VFDjkfaFlVHrDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAGRDNcbN0ttOctWCcnk FSOmrvBGjhHoLCTD3WH+d+pQSiaPCEUKSoHenUCRA5cud37+tlv0lTIU8ppF7OzgpvtAzbsz juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslRPuZJu6TABYDn0Mt9 IronPort-HdrOrdr: A9a23:sMDnXqixb2LVCl4n5Tb2EX8EU3BQX6523DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK/yXcT2/hoAV7CZniehILMFu1fBOTZslnd8kHFltK1tp 0QDpSWdueAamSS5PySiGfYLz9J+qj8zEnCv5a6854Cd3AIV0k2hD0JcTpzX3cGMDVuNN4cLt 6x98BHrz2vdTA+adm6PGAMW6zutsDGj5XvZD8BHloC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy zoggb57qKsv7WSzQLd7Xba69B7icbs0dxKAe2Lk4wwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O86isIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRu9jWH4qcL0aTomA44Z7LgpBCfx2g4FhpVRwa hL12WWu95+Cg7Bpj3045ztWwtxnkS5jHI+mao4jmBZU6EZdLhNxLZvi399IdMlJmbX+YonGO 5hAIX14+tXS0qTazTjsmxm0LWXLwcONybDZnJHlt2e0jBQknw85VAf3tYjknAJ8494Y4VY5s zfW54Y2I1mf4szV+ZQFe0BScy4BijmWhTXKl+fJlzhCeUuJ2/NkZjq+784jdvaNaDg9KFC1q gpbWko9FLbIynVeI2zNdxwg1rwqVyGLHvQIpo03ek7hlX+LICbQRFrBmpe0fdImM9vfPEza8 zDRK6+PMWTUlcGYbw5uTEWe6MiW0X2A/dlz+oTahapnv/hDLHMm6jyTMvzTYCdYArMHFmPSU c+YA== X-IronPort-AV: E=Sophos;i="5.96,169,1665460800"; d="scan'208";a="87497199" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FXZpNs3dEAqCL4OVsYaTDmbg9RqX2OX3kEB3FIiDHpELblIyeBd55rm/oU2G6wsM1rzBWs8kpspAUL+e94V4Rv+XiMGv1sz9aXEPWis2Pbu+KM9ZTubJkXgjk6hfqtVM9xnUn/DUx16l9AG+PX1VyQ/CWQEH18IeN1cF/4dVamsua+KSl5stBYeMMI1yZxvWQPysk4ncIwpkRsukiqEVulYg3Fgq2+TlSx/YzXezwZcLcDsHD1dKkq0vw7N5/xYdvvZIaEDqMemfWkQPVhUV7VWPR8G7X1YNUAMqzTXCXTCsXUBW5DtUIvodbsZNNkXP+KZgqctQX5NfAH7YsNm86Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UFM5IxYv79F1URZqdOEl6KHRKVswx03RtDforc8iMsw=; b=SnzpgapDV34Qrdq04llGxCjAb4thEal0l3q9ji1ohBDUiF03l4aAr5813X6OASdM9YlVsIfhOQnNaHr3QTv1rfE4W3k9NzXzDAhv3dGUD7S7vIqNNkCmED2hfPDql5ZvsSBoi4aTRJ52LM5tcUsIx5ID3HYnOSmLVX80Obuhz/O/0bNQPhwFKupz4wblz+gAmZyfgzQ3VOsIdvXPK5YeAR9x7g3a+jQOnkUbnMYnpEi66JorKVFWTNu3w3dUaWEQaqeUdebhCfSwvxW7PcfCeJdczkej/1bAK2zu5xzSTkMyBTCWaM19klDMUOK20D+rzlwate1b68bHSZ1hY6TN4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UFM5IxYv79F1URZqdOEl6KHRKVswx03RtDforc8iMsw=; b=OMIHJL2YP0LdqShSRXMAbpoJhkYgnYhjzDfe6I/p+rMr+rXi+2TdgkyCn70x28EliY23dVgrAdU6lEQYgcyzriHCN4BR+V7D3Ylbo2JrhDiHpjkrIkVQ2P1qIe6m1fINUxq+FtA7tdnoh8ZQAUAKyGBkblb+c8L9f5/bD4kvqOk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0 Date: Wed, 16 Nov 2022 17:42:16 +0100 Message-Id: <20221116164216.7220-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0364.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::9) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6459:EE_ X-MS-Office365-Filtering-Correlation-Id: ed775fcd-fe09-4301-f07e-08dac7f18933 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X7tJmPJ8QTMiVdpgdBB+2K1wc8fwHZFdjl37V5D9h1M65TWyrHwwVU13zdaC/8C28gBJxIcTZEtOV2oTkdQXRlV/E//VJSK/JU7gZmZ1mLg+Vz0p9779qCdPg57ibj4STgFLr3rN6CRAjRl3AWUp+ihdZGVEgwk0ZaloNVO5uksVOYuKXEc0L47b/lbEOZGjMJurKdXhdOCtap+0YaIPPUSNQdNlab3p/BLdYdF32Tgn8HiMrOxqVs3pIbF9/Q+11XDqdl+SeqGsh5zoRagoD1ApE6C39Crg0VbVaKi9/oiV3graAtUX3NanHrAM5JCWKimBoRzdG7K4rdxHLnzwakKUX0K+mnUy83hO6U9x39hTy9OKRQgSjsdIArGuCHf7FDCtCaKLJIYk7GhWhx3nfmD++DWZMjVTX7HII6QMo/rn9lrFXgp03G6aLcRXfjAAXo9Z03yl5kuhCNSjm5r75GXCXIT0FBmzofgH7KVzrrJJRcoAvvs5mX4WCj+96SYiwMaZOxNL5aUi70y/8X9fezOdPTwJKKzD+e1IzpgGniGzgEhRcZ2SQt0ukfGLzzGVlVvGeT+GXg+mOsUlJ6aH+t6v1K7SuO7E1FQ4ZjpFmrDqvVluvBrUxCbw9TNUqcFb7Q5fbr+aeAv6Y4FUVEQrXPZ898l23ztfAhKW7QBnduUc+MhJHkk1BvCfN2/XBlo30+6lBhhCttyKyLUzyui8Wg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(366004)(346002)(39860400002)(136003)(451199015)(83380400001)(2906002)(8936002)(82960400001)(478600001)(38100700002)(186003)(5660300002)(6486002)(1076003)(2616005)(6916009)(54906003)(316002)(8676002)(66556008)(86362001)(66946007)(4326008)(6512007)(26005)(6506007)(66476007)(6666004)(41300700001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWVvdkRSYVp4TTJYbmV5M3ZFejJ4TE1jL1pqTnRjOWVaSjRoUEdabzFUMTRP?= =?utf-8?B?cjMyNXJJdDFjN0lMUXpZY2s3RWtQcGZRRXFqY0hBMkw4Ukdsd1BWM2RBLzdK?= =?utf-8?B?eWZWeWJwWTdzTGxkN2JjQlg4aEp6cXBhOUlDNnFVYU9VVGJZZWRyZGZ0Y3BS?= =?utf-8?B?UGJ6WmxUZ2twSCtndHlSNUJQMEZHVlVGZGdZTmVSaTlUNFVUZzYrWEk5N1Vp?= =?utf-8?B?N2JHRnN6Q3hEZXdLeGVDYXJtNTlveW1MR1JEaFBHUHRmNkpocU4raEJ4OUd5?= =?utf-8?B?OU53enRyNTVSTGkyTVNNcHlKbmhCTVo5ajErR2xZdHVtQk1pdEwvUlM2aDJ0?= =?utf-8?B?ZVNTUCtwMkVBTk02dXAyWkw5TjR6R29IajNJbVBxUXdkRmN4MnBxVUxHTS9D?= =?utf-8?B?ZnArRjZEM2c4cHZXbmV4ODJkS1V6aTNabjM2VkowRXorL2Y4cjlJNkh3NzQ5?= =?utf-8?B?QWxldG5SbTU3Rm90dkFrMU9GR1Mzd05iaXR0UkpMRDFrUTMvZGVvWTN4Mk5F?= =?utf-8?B?YU5jdUJXRVhJN1JtdEpnbFJQVG5iM2V0aGlhaWsxeWg5TEdidXM3RWJKeGgx?= =?utf-8?B?eEpNU2RkWVZ6UHpINHlJdVpFZk9KYXlZd2ZvU0FLcExhRE1qUVhicy9LU3BJ?= =?utf-8?B?MDhQT2dHWkVSWUFZQXlOcTRPZ3BudFJCaERQVkJ6MHRIaGxLbGpyRE1xWndy?= =?utf-8?B?UWthcmRNcyt4REdzZ2JiUTJ6Z2pUemx1cndkcUZZdytRRmVmNU5QUWJ4NnpU?= =?utf-8?B?eE9CR0lzWUNSOFZ3SDNIUHBxMCtJS2l5YmJnR3l0OHB2c0FJOUtZWk5tb1M4?= =?utf-8?B?ZVY0RWFkazBKVGtKR3BkZUFNUUtPWGRISk5nZFlaQlVSQ1hBd2tIWG9GRjkr?= =?utf-8?B?YzFCdk5ueGtReXFwWDFQV1lIK0dnYmEwVFhtamNzNzJlak1RZ0d1WFRoS0oy?= =?utf-8?B?clRmeTc1TXZIejJNSzhzaU9oaG9jUjFsMzk0b0dmV09WcjkxRk56bXgwMXpC?= =?utf-8?B?NXNNeWtaNkQ1KzdBVFMzM3A1ODZYQ2l5US81NlpXSUlvWGwvOGVEbTAxZkhs?= =?utf-8?B?RTZXemVaYmcwT2VWZmhBWjBMRzEvZnN1R1NUNjU2a2dmVWlCOFV1QnhseTY4?= =?utf-8?B?Q09Qc3Z2NUFJemFaeVYzUnQrTTNaN0dlNDJBQ1VneDFTcjBiY2MzVnlGZmZo?= =?utf-8?B?bXBxTWFhWmxMZWlLa2hpMkJjbFFaSFF5MWJFY29XZGE1aHZRczFPVGtiZElN?= =?utf-8?B?V3V0YWF1QVhUdDc5dkpxMWNSMC9PYWJUd1RDU0F5VjErdVJMdjR1aDdhazln?= =?utf-8?B?alNXcXpKamM5YUdmWmp4Tks2MEZ4OW9lNXpDS1IzdERXVEZMVUVZZU45bnlI?= =?utf-8?B?dGt4cjJnMXQ2cEJjYXh4OEpxcStxUDgvckViQldUOGRmeDNFdkhaTGYzdW5E?= =?utf-8?B?cEtCWS8zQ1RTRXA3d2o1NjBweFZLazQyL2pJNGpDcTgzMGVJYm1IekNtOUpn?= =?utf-8?B?SHZtb09Hd2RJMlA1cW8rVUp3TXVDYi9kNTV1ejY0L0dIZzJ6d050RXQ3UFdR?= =?utf-8?B?WlAyNjY2NzBJY240dC91VGFGK0hrUGJWMkxaRnVHMUdwSkxydUoycUJkemFC?= =?utf-8?B?WnBNem5ad3N1UFdJbGJYaENpTWhhT2huU1hWSTdlbWw4d1lVYVVJWHVDNm9R?= =?utf-8?B?STVmRFoyYlJMbVhHZVJYVEJlZDZxdlpCZEVTek84STFUcnBRb2Z6cXBHNVVQ?= =?utf-8?B?Zy9ORlR2RlBhNjlXRFpLWE50ZTZrTnpZTWhNSCtHTlp2WnlSYnlQbEt3TDdp?= =?utf-8?B?bGZvVWhxdml0Uk9XK2EwN3ZkWlNJdHFQYlhrNiswaWF2M29aQ3l2VVZoTGc3?= =?utf-8?B?dER6NFlhd3FETlFibjhiS3pGQjFFL041aE0zNUJxWW9sZ2gvR0VFQ2prRC8w?= =?utf-8?B?ZVJrWEgySDJuRFN1UXB2UWhDRHNpNU4yNkdpK0gwU1dGOFRadVQwSVZaRUZv?= =?utf-8?B?cWpKd3k1WDl5ZHcvMDRPUDJtdnBXZVVTTUZzUGF6WVp4S082K3lVUFJkT0ds?= =?utf-8?B?MUhReXhQbE9rc0FGdmtnRnU3T1dxeWsrWUdsckQ5eTFiSkdBVERtcUJrOFBo?= =?utf-8?Q?Dd67ViO11Cay7zW6p3NkYw4s5?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 9J/g1hLBJJspCvMwQXAXsWy5Ze9PCLbZ2Fcv1qlquS1GcOHd5a5CYOIrC2GNlQqYvYcKwOIlslf5iqWpLfIwgduzZTMH1rSwxyAtpdgUHoI2lFp3MfpfOJ2WRZW4yPcujwj8H5rgveMcSY2iSOM+xqL3pWI+Rsni70C1eA1nogTgVZst4dlFjrPzz0rOLhszEwLwBewD/NPhjrOc2CoFTRUprFxOkxsl4EtLLXHXX6KX5XphYaGsRyUe0l9SB5jiHe6tlDwPaOAyHZoGNCkNISPC7h05cpIcZy2ocuZ5TeuJgnXvNJyu/fGGNsFlZpQ2B7OY2hNhfvi1M9vFetfcCx+ypxG4xydygjzQE1iaRpdCmN03wzMp+2jsuS2b4ULdpbjpbCr+3RA5LGEkEw6ITwsYI9HsB+GjTmW8SwioH4RAFW3II7tl1jGs8r+SWsCCtIPnR7FOoU//V/7iLZ+Z7DD9R7F+V13i6ueXOrag9T5+vKIQcEFYbb7/4s3JTWyA16CojOUELts/R1sRs8amafkRR6xZskd3qcDjnY76Lez+1dPOyLZWsS9CNuCpCliyFEk+nNghg8AAbuBgarHtcHVIM8TF5JEkPYw3Nm4dW34F3R3xC9eU5+YDRi3KugqTYL+gVi26ZjpCDH/vdoji/T2H/J0VKfAeXM7bHpl/0mkv1onPfESKCAtqqfzahLfu1yXQYu2/69KwmuZR+QpVGvIVWVp7H6Ig/0a31f4gOCn7HxVzvGmxciABIJfAz9gss4uEyR/2MoLR5ZDyiDSUHmFsXuvrCRxGiALIKoCu0Zxi/HBEZXIVy4ipK+6f7ebiT5tZFM/hCGnwoMu0xpvnZw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed775fcd-fe09-4301-f07e-08dac7f18933 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 16:42:23.3180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PPk6UnnvlZAoLNGsZ40K621HH3WsnOVPvKS29xyXwM/KeLqPs8gFC2SJ/ojpSivOQlxSBzgjNOWGzSmZ/T5C/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6459 Currently Xen will passthrough any Local APIC NMI Structure found in the native ACPI MADT table to a PVH dom0. This is wrong because PVH doesn't have access to the physical local APIC, and instead gets an emulated local APIC by Xen, that doesn't have the LINT0 or LINT1 pins wired to anything. Furthermore the ACPI Processor UIDs used in the APIC NMI Structures are likely to not match the ones generated by Xen for the Local x2APIC Structures, creating confusion to dom0. Fix this by removing the logic to passthrough the Local APIC NMI Structure for PVH dom0. Fixes: 1d74282c45 ('x86: setup PVHv2 Dom0 ACPI tables') Signed-off-by: Roger Pau Monné --- xen/arch/x86/hvm/dom0_build.c | 34 +--------------------------------- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index 307edc6a8c..d44de7f2b2 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -58,9 +58,6 @@ static unsigned int __initdata acpi_intr_overrides; static struct acpi_madt_interrupt_override __initdata *intsrcovr; -static unsigned int __initdata acpi_nmi_sources; -static struct acpi_madt_nmi_source __initdata *nmisrc; - static unsigned int __initdata order_stats[MAX_ORDER + 1]; static void __init print_order_stats(const struct domain *d) @@ -763,25 +760,6 @@ static int __init cf_check acpi_set_intr_ovr( return 0; } -static int __init cf_check acpi_count_nmi_src( - struct acpi_subtable_header *header, const unsigned long end) -{ - acpi_nmi_sources++; - return 0; -} - -static int __init cf_check acpi_set_nmi_src( - struct acpi_subtable_header *header, const unsigned long end) -{ - const struct acpi_madt_nmi_source *src = - container_of(header, struct acpi_madt_nmi_source, header); - - *nmisrc = *src; - nmisrc++; - - return 0; -} - static int __init pvh_setup_acpi_madt(struct domain *d, paddr_t *addr) { struct acpi_table_madt *madt; @@ -797,16 +775,11 @@ static int __init pvh_setup_acpi_madt(struct domain *d, paddr_t *addr) acpi_table_parse_madt(ACPI_MADT_TYPE_INTERRUPT_OVERRIDE, acpi_count_intr_ovr, UINT_MAX); - /* Count number of NMI sources in the MADT. */ - acpi_table_parse_madt(ACPI_MADT_TYPE_NMI_SOURCE, acpi_count_nmi_src, - UINT_MAX); - max_vcpus = dom0_max_vcpus(); /* Calculate the size of the crafted MADT. */ size = sizeof(*madt); size += sizeof(*io_apic) * nr_ioapics; size += sizeof(*intsrcovr) * acpi_intr_overrides; - size += sizeof(*nmisrc) * acpi_nmi_sources; size += sizeof(*x2apic) * max_vcpus; madt = xzalloc_bytes(size); @@ -862,12 +835,7 @@ static int __init pvh_setup_acpi_madt(struct domain *d, paddr_t *addr) acpi_table_parse_madt(ACPI_MADT_TYPE_INTERRUPT_OVERRIDE, acpi_set_intr_ovr, acpi_intr_overrides); - /* Setup NMI sources. */ - nmisrc = (void *)intsrcovr; - acpi_table_parse_madt(ACPI_MADT_TYPE_NMI_SOURCE, acpi_set_nmi_src, - acpi_nmi_sources); - - ASSERT(((void *)nmisrc - (void *)madt) == size); + ASSERT(((void *)intsrcovr - (void *)madt) == size); madt->header.length = size; /* * Calling acpi_tb_checksum here is a layering violation, but -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Wed Nov 16 16:46:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 16:46:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444353.699466 (Exim 4.92) (envelope-from ) id 1ovLY7-0000lW-Rt; Wed, 16 Nov 2022 16:46:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444353.699466; Wed, 16 Nov 2022 16:46:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovLY7-0000lP-P6; Wed, 16 Nov 2022 16:46:07 +0000 Received: by outflank-mailman (input) for mailman id 444353; Wed, 16 Nov 2022 16:46:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovLY6-0000lF-PK; Wed, 16 Nov 2022 16:46:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovLY6-0000Ww-Ma; Wed, 16 Nov 2022 16:46:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovLY6-0007U4-0P; Wed, 16 Nov 2022 16:46:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovLY5-0002Gs-WB; Wed, 16 Nov 2022 16:46:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5HzqGlLOHnHVRP2sk0tez9cjtH5Ko3Rr/VFYRgYdNdw=; b=PHK+z+tuTOmpNmYTe/pMJpDfEq 25u5Lo2sUIjSFW1zh/Q7izoq0s649xKzk/zQ6WY3NUP0MNyDsMyZAFCHs7p3rUhWIx5xKxQaINHuH 44KbnQc6XdE0imrcr9Fjp1QH1gkZMYjx+f/DZj7Kb0vTv/O3J3PmHLbgzlgnBOaIABAY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174788: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-arm64-arm64-xl-vhd:guest-start.2:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=2c8311241d1f7377bb4ff76064b1d1fe15166413 X-Osstest-Versions-That: qemuu=bb00d0aa620e821cc2fbf2e0c5de45a8c957626c From: osstest service owner Date: Wed, 16 Nov 2022 16:46:05 +0000 flight 174788 qemu-mainline real [real] flight 174792 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174788/ http://logs.test-lab.xenproject.org/osstest/logs/174792/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-vhd 18 guest-start.2 fail pass in 174792-retest test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 174792-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174780 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174780 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174780 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174780 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174780 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174780 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174780 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174780 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 2c8311241d1f7377bb4ff76064b1d1fe15166413 baseline version: qemuu bb00d0aa620e821cc2fbf2e0c5de45a8c957626c Last test of basis 174780 2022-11-15 18:10:12 Z 0 days Testing same since 174788 2022-11-16 04:59:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Paolo Bonzini Richard Henderson Stefan Hajnoczi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git bb00d0aa62..2c8311241d 2c8311241d1f7377bb4ff76064b1d1fe15166413 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Nov 16 16:57:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 16:57:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444361.699476 (Exim 4.92) (envelope-from ) id 1ovLiW-0002Ys-0Y; Wed, 16 Nov 2022 16:56:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444361.699476; Wed, 16 Nov 2022 16:56:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovLiV-0002Yl-U7; Wed, 16 Nov 2022 16:56:51 +0000 Received: by outflank-mailman (input) for mailman id 444361; Wed, 16 Nov 2022 16:56:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovLiU-0002Yf-85 for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 16:56:50 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a781e36f-65cf-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 17:56:48 +0100 (CET) Received: from mail-mw2nam10lp2108.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Nov 2022 11:56:44 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by SA2PR03MB5882.namprd03.prod.outlook.com (2603:10b6:806:118::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Wed, 16 Nov 2022 16:56:41 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860%5]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 16:56:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a781e36f-65cf-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668617808; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=JdrdXiH1ABEZhHd7nlJNLMPNFakmbMyUruAfXnFfDlY=; b=HY9X1Olo911FOMqGwp67Ww0gXMPuKTQHamVbiJXTAVikFzLof/K7K9qN AHh/K0m0TVOVxx4ow2mkxdQOYDSpARa19kY9CcjwP0SIUmtdqrcKsRey5 6cdF+bwcAT94JBd6Bpk8SkoqADE+YTCUe6TEKc9x/uPzyqhv4zH5SbZrO 8=; X-IronPort-RemoteIP: 104.47.55.108 X-IronPort-MID: 85383849 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:JMwIZKsT9sPOcuE0Q0WOVA6G8ufnVHRfMUV32f8akzHdYApBsoF/q tZmKWqPb/fZYWb2KdsgYNy28kJU656An9FkS1M5+H08F3wU+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaHySFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwKHMSNE6onPKK6YmmEfNGv54yNJPOFdZK0p1g5Wmx4fcOZ7nmGv2PwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjf60aIq9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPO3lra4x0AHCroAVIAwbd0XrpdSEtnKVR4gcK X4PpnoynadnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQo3 FKUm9LiBRR0raaYD3ma89+8sjeaKSUTa2gYakc5oRAt5tDipMQ2kUjJR9M6SKqt1IStSXf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxodu51knHpU KA4pvWj IronPort-HdrOrdr: A9a23:RilM8ay2DX/4/v/sGw84KrPxBOgkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2jnC6l87nzFjmfx1M7XylUybkv3G DZm0ihj5/T8s2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHBmxulf4NoXpyFpXQQrPu04Fgnvd HQq1MLPth16VnWYmapyCGdlTXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t MJ40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIWLH5AJlO+1GkUKp goMCju3ocRTbpcVQGBgoBb+q3pYp30JGbffqFNgL3P79EcpgEF86JR/r1iop5HzuN8d3AM3Z W7Dkwj/os+MfM+fOZzAvwMTtCwDXGISRXQMHiKKVCiD60fPWnRwqSHqYndydvaD6Dg9qFC7q jpQRddryo/akjuAcqB0NlC9Q3MWny0WXDoxttF75Z0t7XgTP6zWBfzA2wGgo+lubESE8fbU/ G8NNZfBOLiN3LnHcJM0xflU5dfJHECWIkeu8o9WViJvsXXQ7ea/tDzYbLWPv7gADwkUmTwDj 8KWyXyPtxJ6gSxVnrxkHHqKgfQk4zEjOdN+YThjpsuIdI2R/xxWyAu+CSEz9DOLyFeuaore0 Y7KK/7k8qA1BuLwVo= X-IronPort-AV: E=Sophos;i="5.96,169,1665460800"; d="scan'208";a="85383849" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CKpx6zG9f1FsLEbjTDhc5FmxSCec03qMek85z1vcqvhoiwdS2pzVrlIEWEAHrYrwZDeSo8KP/qp5l2sb3QFXY+qWBjFhj1Nb7jSdIHtLMWrc+39W7QnVCQjT6ZIQv1O3mjc7fxtqcvZokjMVchBIzXm68topbAd8nsDkTG/rU9eMNjp3Vcq1ZDabqntccRrayolV6havVOe/c+v2UHlol3JWe+3YMyKwdAaUShRF2ynaBX94lchr0blcM3fFp12e+8tBGFaf8UsD0OvGC7M+4718f0WHX5tuLwb37HVNyDekW2e6mCJshXF5ILmF6I1hnmV080EyLZoRan8RtTiTng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JdrdXiH1ABEZhHd7nlJNLMPNFakmbMyUruAfXnFfDlY=; b=N1h8em5vAIZTSFSShKwWg0uxPYdP14ADiZsYUqT1yJHLUWKZWfBq49yGljQUL9X8en75Hga3scDv4v7PFHJdogxRuW4wxAG6Zb5iFJaTf//n0hGSIh6dtFykXjRSmTcV7NT9FL9CTBEAlyEB5DTcOhAHlx94TpfLBj4fQNiRxg4cqYVs3UzurgAn5dkUvUfkQ878ff06+FGIXL777HdjJdcfTQR4gdlaWdqc0uisCz5DUYgsgYN9miKp0s3zcKzziXK0xss7Lzm+1DZJY7C4EABu+C5gpHNxoAf+27PYD/4WJJLyn6mZYa94Dik6bj7mMS+Ng+7r4STVo9Rn5Db9Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JdrdXiH1ABEZhHd7nlJNLMPNFakmbMyUruAfXnFfDlY=; b=Mk7+t5N0z/z/o5DBnGdzKkKwFhFixRq4hoHtP6UrLmu/OYvfVis8ajkFLVJnva/8JiHAMkpwzyObJo50r42aKcsXnzk6qmYR883KfshlZGvrUOn/KETqQs396sL4hZu7/EIWsqQaKIldxl2Hgt2Fu91U42+orL3SAI2bZmqMdIU= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Wei Liu Subject: Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0 Thread-Topic: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0 Thread-Index: AQHY+dppI/YDqtuG9Eua4T+BrggU9K5BxRYA Date: Wed, 16 Nov 2022 16:56:41 +0000 Message-ID: References: <20221116164216.7220-1-roger.pau@citrix.com> In-Reply-To: <20221116164216.7220-1-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|SA2PR03MB5882:EE_ x-ms-office365-filtering-correlation-id: e0164719-7ee0-410b-5f9c-08dac7f388c0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Kt17SaLRg/1y2zZM1WfBozWjCxcUnny8A2SIWubXbWcI226efnOOuR/Aj93P7FMb8IG3vy0F3WfNY4+MlMKvj8SyEbdRcaZpBqi3dBkT06w88GgObwN9bljQiThwtv3y0kt6gezKjr5Qz9RJyQrwzveC48AVJSpP9gO6z+ptSRakzvQGXVuD0I23iGMWXt4G/c77nsmnwW0enhtSQZJHArmk0mvua801fTMfr5Xj01hqh5svJJrfeWogb0hMVaV3CoL9acypFy5AxbcGvVYfoGpbi0waPnan7zBx32yjuNbqCCXxUMXMHa32SQhUlNUDMQOuGIMwYtC1AVBNveTGNjHyw2W5XKdxOzwG1G1oOuoieyGedVNPLXOcYzO7TEQQNrJcAhTpHh7B7Xix2bkDkKYT8d+wuF+SEwhEnWfGKzwEtJt4rRxUPAXM+QKshSp4KhhrhQhigQXShnfcauy57NCfdgNGpbOyVDDVFE+htdjvcNCsWZXuSF87l4zBsV6GZ3neRIIdOhPqua5X8JruBEz9e9Hh86lmxdG+z3dYv1/7MmTmSC9A/wDSH4ju6bFcVcXYK8rY0Rz/Gr7RFmruUIegPUE2JML+5kc22FbmT2QW5W53sbNt3HGmhhUUS9kGcvAtp0DH1Ou3qr+70gBAQgwX4weZIBIcjKBSPru6uzEM4EQgDIaWx7hhqT33MDdAKHCW0t/ZUMWqd0Q+qS9dq5CFAL18I3inWrVqUmqdaPquPSxbgqnxCGUPue0j9wyjDn8VVZ7BdYMtaTzQHLjAXIR1830dSo/t6l3emZN5Do2KO8JbI7Fzkc9OQ82uao8lg+rHVDU4A1q1FeO6fVrNIg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(376002)(396003)(136003)(346002)(451199015)(6506007)(186003)(26005)(6512007)(36756003)(71200400001)(86362001)(2616005)(41300700001)(66946007)(66556008)(4326008)(91956017)(66446008)(66476007)(64756008)(53546011)(8676002)(83380400001)(6486002)(31696002)(110136005)(316002)(478600001)(54906003)(82960400001)(38100700002)(31686004)(2906002)(38070700005)(76116006)(5660300002)(122000001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZFhrQ21iRTdKRmdKRW1LR2NZREVaVDBHaFFNa2toK3pjV2UrMnhOdG00RkEz?= =?utf-8?B?Tmg3RzNUSHRiakt0UDNYMHk3THFJWkxDQlBRakU4K01qL0RmY3NrdUE5anl4?= =?utf-8?B?b3dYOGorZHdjVWxTZWhBcm9zSUZ4QW1zNGExWHlXQUM1K2diTmdBS3hVRUtz?= =?utf-8?B?K3RyOW1UK2pxYS9NeXoyaW8xOEErdzUxSzkycDAvM2pwNUcyelJWdnpKL0ZC?= =?utf-8?B?ckNXWUF6R3VOWEYwaVRkVXloMzcreFY5RXA1L3M0ME1EcXJ1YXA2N1N0Mmk3?= =?utf-8?B?dDVMQnR4WXczTnlIay9aQU9QRW9WeUdHWmNXcGw2WC95em9rWFR0dWZQOGdt?= =?utf-8?B?K0RtU3R0K29tSjNvQzBEdzdTYmxUTnJHdmNmT3NUTXd1VE5QdjlvTFBqWWdL?= =?utf-8?B?NFZjZ1lkTE5XZHNrREtrUW9EYU02QzQ5a0RGQmN3U0RBaUFSR0pod1o4ZmhY?= =?utf-8?B?eHIzR294YTE1K2hQbmlDS3dJTGRJTFZRWDNJSEp6cW1iL0Q1QTlIRGZWMXl2?= =?utf-8?B?eGpEYlk2dnlxalZyQ0VaV01rdXdtQ2s5emF6V2ttcXR2MDBWOVVMcHdiN0VF?= =?utf-8?B?dTVsendGVGFDVk9xMjVvNFdkSmtBa2tmVEY1dmpGZ0o5UjE2aEg3eVVPT2ZO?= =?utf-8?B?YWd1VFF4c3ZldlYyZzVndHhxMFl4bEVHZmJ2SU9rZWJFUmRtZE0wS0o1Nlg4?= =?utf-8?B?VldnK2FzU0JrWmVKdHpKdU5WN1pkRzcxc3BsdVdocHhsbjB0bklhUlJ0ZUM0?= =?utf-8?B?U3gxRTk2UDJZa0RWMVYzQjdUUVIwczhNbmc4WlF2RzNyRGl2UGoyNDMwdTZL?= =?utf-8?B?czZ0QStKM1U5NXZtb2p4NVByTEZuZE9pbWh0ckQrRUtkRm9ZMzFRa0xKT01k?= =?utf-8?B?d0g0SjNrd3pGN1M0Z3J3ZnNzRTlaQzhyR1Bub3RiSXBpZDhQN1ZaUWZRa3Na?= =?utf-8?B?cXNVVWJUcG8wSEt3dTh6b3VwMGJYYUxwZFFjcUM1OEJDVUJ0N3FOWFV1NGJY?= =?utf-8?B?QjBoZmVXRDVQWU13QlhjWnBZNlJxUWxqTytmTUtBQ0h4YlBXNnc4S2E2cXZG?= =?utf-8?B?S1Q5UkdQK0FzbXgxbE9YTFNTWXVoWnhMZ0xEY2p2dFFVUEFXQUYvdUFwaFBC?= =?utf-8?B?eHlmZkRmTnlVU0lDa2gwNmpiUFY0UnBLc0xjNG40WVdzMDhSTUs4cUZoWWQ3?= =?utf-8?B?Yy91NExiRXFGOW5BSUROZTg0d2FVcERBOHFya1FOWU8vN1RKZHhpYkdxeXc3?= =?utf-8?B?VXZwY1oxSHJwOWozcGV4QXZocjJmYWpiMXNVeGh0TWFRT0t6VmJNc0dzSXBQ?= =?utf-8?B?elkwK0FiQTBScmJKWk9HT25yUzdaMERUOVlFNDY0ZnJiTGl4R3RjbGtZT2Jy?= =?utf-8?B?d3RaRExYRE55R28vekk0VHZyRUpNUGlNOUkwamxtRHExaC80c2I2bW1RMUVx?= =?utf-8?B?RUV2Rkpmbk9NTTlCRHZaUlFDYnc1RFc0YStYM0VXc3p6Uy8yZ3BRNURGbU5H?= =?utf-8?B?Rk1jSDFvdWl0QzR4akRhU2pxNENGNEtUY0J6dk5KT0wwNFhqaDVQcDh4M2k2?= =?utf-8?B?SmV0UnZMb1VwSzRvS3dWTVhtSWNyZ3RTQ01WSmZ0OVdhMEJ2UVJPTHRQWnNU?= =?utf-8?B?K1hqSm90M2k3bWRXSEY1Snl3QkZSMWN4Rk9uL1p2aFF0QnE0Z2xhRmN0UGtt?= =?utf-8?B?UjRYUFpTMUxGeVRwVkh0RjJWbVFaVlVuV0tYaHBaWjJ6a1RCcGRCQnR6aW8r?= =?utf-8?B?Qm9DY3I1Q1BhejNxR2N2UXlQVUloSmROWkhTOTJSWGhXbGxwUGRLWHQ1RGZH?= =?utf-8?B?MFpjOUZuY2V6VlVDcFVWRzdxYnFiMmRoYlBRSWo4eU9jcUVoaGNDNXpUY1Ft?= =?utf-8?B?UEZTZzQwa29zZHdWTDJXS1pWQnI5cE1Pd0dSWDBQOG9CeUxJWWhoUWpiSHlq?= =?utf-8?B?RUxiQTY4bmJNUVA3anpnSEk0VHZKWU5CT2hzMUduckdncHhrNXI5bzdsSkhw?= =?utf-8?B?S3VMSHBlN3hsYzJvRy9PVmN2OW5ZV0RpSll2STRXM0NaT2xxUDQ3cmc3NlFQ?= =?utf-8?B?K0VWUEEwWEtkYUJCUDUvN0pVdU5Db0hNSi8xQlNKY294b3NnbEhBRFQxd3Rp?= =?utf-8?Q?7YuYiAVpMdyhJHDnNwT3Ijwew?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /kg+tNb5zyivXyoF9sajohgSJzdxUVvy7eJHOq6TV/Hs4xQxe/LACHPtlb/M0i6Lzg7eQxB0Z3qDLfN3kUAUYcbXVIr/ieX2vK39DRSj4UA6FfCkKwRgVmxzjpyR+seZ3avWtARStX+dEy19QH+e2/Xc5zb8Vub8DewMQZG/SZdqBOB4uo6hKiNSMnb16MM0tcUj/hEW4g52iUVshzfFXDAg1w9l/oLfSWucXiW3mtk96rF7Ms7TF5/jxJlOxCpHxQcLWguoCC5/4+Dr+jgQCc4t1whser1nSK6ao8vnDxEr/TOUrOGEvAVwW9wvpYlHLhtmY2cWidRafPpZTfb5lf0BDNzqIfrCypvGQ4Pff2avipPfmP/6WIUZbihm9ByddoKKNdgn9oZ3Jsu2h5cdY3sZ9ghO/Avw/vQCqI4T9GCg5zppkGZfGpdmAhTd32RJUH6ZCzkprOoPuPZSrmcQnLGY0Vl+nJI5/1pBlBhByb+tifKBtk7DCi7Xs6NfIUcmxwvXMntwauhG9XHGqoJKf9jVTbDO2S3entQmmrbqPGoB2aDqA9LiguUlRqzgYQqkzD/CcXrFGOlgkbqRm8e7ZfNEZTVqfBIGWpaGV/LyFEETTrnQz2w/Lb6r+Tczb4S4ycyftvU/eWSHwjhxZDU4MhktnmfV5dBZtQ8hcLhXYkGlka6wdp5XghD/kWqf1OtXhCf29qzApv0Zjd2rEB+gs4pu5LMyyFm3ysX3Y+EuGQPpyDH6MfKFOPlK0s/M+cAoMd5egoD51sbLPIzIqWROipZhWEr+IrZSxk28/wN7IeuZft5YPGR1l/y2mPiVbcLw6h8DoSMAIDqgdSf4SgMK5w== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0164719-7ee0-410b-5f9c-08dac7f388c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 16:56:41.1166 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jDU7dUH8wa3ieGQOVt8V7I4kIWRsFKFRPwA0IUk4n9Ed4HJsNrR5CYu9o0gTmfzJ3mE6ak9Kxag6c9JiXCgQjPe5tibihDbjIFgf0fAKfAI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5882 T24gMTYvMTEvMjAyMiAxNjo0MiwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBDdXJyZW50bHkg WGVuIHdpbGwgcGFzc3Rocm91Z2ggYW55IExvY2FsIEFQSUMgTk1JIFN0cnVjdHVyZSBmb3VuZCBp bg0KPiB0aGUgbmF0aXZlIEFDUEkgTUFEVCB0YWJsZSB0byBhIFBWSCBkb20wLiAgVGhpcyBpcyB3 cm9uZyBiZWNhdXNlIFBWSA0KPiBkb2Vzbid0IGhhdmUgYWNjZXNzIHRvIHRoZSBwaHlzaWNhbCBs b2NhbCBBUElDLCBhbmQgaW5zdGVhZCBnZXRzIGFuDQo+IGVtdWxhdGVkIGxvY2FsIEFQSUMgYnkg WGVuLCB0aGF0IGRvZXNuJ3QgaGF2ZSB0aGUgTElOVDAgb3IgTElOVDENCj4gcGlucyB3aXJlZCB0 byBhbnl0aGluZy4gIEZ1cnRoZXJtb3JlIHRoZSBBQ1BJIFByb2Nlc3NvciBVSURzIHVzZWQgaW4N Cj4gdGhlIEFQSUMgTk1JIFN0cnVjdHVyZXMgYXJlIGxpa2VseSB0byBub3QgbWF0Y2ggdGhlIG9u ZXMgZ2VuZXJhdGVkIGJ5DQo+IFhlbiBmb3IgdGhlIExvY2FsIHgyQVBJQyBTdHJ1Y3R1cmVzLCBj cmVhdGluZyBjb25mdXNpb24gdG8gZG9tMC4NCj4NCj4gRml4IHRoaXMgYnkgcmVtb3ZpbmcgdGhl IGxvZ2ljIHRvIHBhc3N0aHJvdWdoIHRoZSBMb2NhbCBBUElDIE5NSQ0KPiBTdHJ1Y3R1cmUgZm9y IFBWSCBkb20wLg0KPg0KPiBGaXhlczogMWQ3NDI4MmM0NSAoJ3g4Njogc2V0dXAgUFZIdjIgRG9t MCBBQ1BJIHRhYmxlcycpDQo+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2Vy LnBhdUBjaXRyaXguY29tPg0KDQpZZWFoLCB0aGF0IHdhcyBuZXZlciBnb2luZyB0byB3b3JrIGNv cnJlY3RseS4NCg0KVGhhdCBzYWlkLCBJJ20gbm90IGNlcnRhaW4gd2UgY2FuIGdldCBhd2F5IHdp dGggZGlzY2FyZGluZyB0aGVtIGVpdGhlci7CoA0KU29tZSBzeXN0ZW1zIHJlYWxseSBkbyB1c2Ug RXh0SU5UIGluIElPLUFQSUMgZW50cmllcywgYW5kIGRvbTAgaXMNCmNhcGFibGUgb2YgY29uZmln dXJpbmcgdGhpcyBpZiBpdCB0aGlua3MgaXQgd2FudHMgdmlydHVhbCB3aXJlIG1vZGUuDQoNCklz IGRvbTAgbGlrZWx5IHRvIGdldCBtb3JlIG9yIGxlc3MgY29uZnVzZWQgd2l0aCB0aGUgTEFQSUMg bm90DQpkZWZhdWx0aW5nIHRvIHJlZ3VsYXIgeDg2IG5vcm1zP8KgIChUaGUgYW5zd2VyIHRvIHRo aXMgcXVlc3Rpb24gaXMNCndoZXRoZXIgd2Ugc2hvdWxkIGZha2UgdXAgdXAgYW4gTk1JIHN0cnVj dHVyZSBmb3IgZWFjaCB2Q1BVLikNCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Nov 16 17:15:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 17:15:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444365.699487 (Exim 4.92) (envelope-from ) id 1ovM0h-0005TZ-Gs; Wed, 16 Nov 2022 17:15:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444365.699487; Wed, 16 Nov 2022 17:15:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovM0h-0005TS-EJ; Wed, 16 Nov 2022 17:15:39 +0000 Received: by outflank-mailman (input) for mailman id 444365; Wed, 16 Nov 2022 17:15:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovM0g-0005TF-7O; Wed, 16 Nov 2022 17:15:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovM0g-0001Bt-0Q; Wed, 16 Nov 2022 17:15:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovM0f-0000oO-NM; Wed, 16 Nov 2022 17:15:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovM0f-00079M-Mz; Wed, 16 Nov 2022 17:15:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=q7TuOo4THKTU1jSafatCaz4ND4G7erC8mmPLJbsLf+E=; b=sZczqFBcwjYOiIBEnokEKPCpyU 7GYeV2S4bhIsDIfiGzP3ZU0wek8osha9qi603fvuBJBYbzchcX0S2v0Gm3sohnVXMfiRGiYp3spQq VfETBGuRM8TTpHMUXRTgjViWU2AzHlbjhKHUUWetUeZg3d28I/+oLTpPR5T+E2bXZ4m0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174790: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=764146ed8a7a44034c3efe658333993ca250d69a X-Osstest-Versions-That: xen=2a98e98f96d1aafddf8869db5e2382d0ddaae01a From: osstest service owner Date: Wed, 16 Nov 2022 17:15:37 +0000 flight 174790 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174790/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 764146ed8a7a44034c3efe658333993ca250d69a baseline version: xen 2a98e98f96d1aafddf8869db5e2382d0ddaae01a Last test of basis 174786 2022-11-16 04:02:03 Z 0 days Testing same since 174790 2022-11-16 13:02:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2a98e98f96..764146ed8a 764146ed8a7a44034c3efe658333993ca250d69a -> smoke From xen-devel-bounces@lists.xenproject.org Wed Nov 16 17:26:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 17:26:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444371.699499 (Exim 4.92) (envelope-from ) id 1ovMAs-0007Do-GL; Wed, 16 Nov 2022 17:26:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444371.699499; Wed, 16 Nov 2022 17:26:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovMAs-0007Dh-DY; Wed, 16 Nov 2022 17:26:10 +0000 Received: by outflank-mailman (input) for mailman id 444371; Wed, 16 Nov 2022 17:26:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovMAr-0007Db-70 for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 17:26:09 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c04a081f-65d3-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 18:26:07 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Nov 2022 12:26:04 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by PH0PR03MB7020.namprd03.prod.outlook.com (2603:10b6:510:160::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.24; Wed, 16 Nov 2022 17:26:02 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Wed, 16 Nov 2022 17:26:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c04a081f-65d3-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668619567; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=rw2h9kMsOW3zNiGwzAQX9ietUjV35aFbVgcjxLKbQ7U=; b=PDtCFBIyhyEwifZD8+cwQWku6r4VQPFHx0MdCg4AvQJXUM65IDlPWQN7 tJ21tTZ7X7IUu2qgGs/I9w0U7EHM0QoUBXH+V8JSmHmLJjz1IIZESU5Uu r6ICN59j8BU4rwTq/bAE1/3DG9wvjx4cen7etcyeqfUf9boJoGRoe9M9H I=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 85386777 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:stl5+K+1nNz2GMQbAfBnDrUDp3+TJUtcMsCJ2f8bNWPcYEJGY0x3x jMcXG2FbKzYNmGkLt51bdiyp0pUscCHnYAySgNk+yE8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKkV5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkJ7 O4/Fw9cSyqtgtm6m4KqQ+xhhf4aeZyD0IM34hmMzBn/JNN/GNXpZfWP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUvgNABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prr+SxnOlB91NfFG+3uxEgAGYx1IpMhQxa1ShhduJoX+VdesKf iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZDYtE7sM49RRQxy 0SE2djuAFRHr7m9WX+bsLCOoluP1TM9KGYDYWoOS1sD6ty6+YUr1EuRHpBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPuRENXCzAS58Ebuk IronPort-HdrOrdr: A9a23:XsUXcK/xF4iRj+Ag9uNuk+G4dr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpixBiSgSiu4LvaFQHd+hsFSTtAzZor7G CAymXCl++emsD+7iWZ+37Y7pxQltek4txfBPaUgsxQBiTwhh2ubIFBXaTHmDwuuumg5Hsjjd GJiRY9OMZY7W/XYwiO0FDQ8jil9Axrx27pyFeej3emicvlRAgiA84EoY5CaBPW52cpodk5ic twriqknqsSKSmFsDX25tDOWR0vvk2ooUA6mepWq3BES4MRZJJYsIRa1kJIF5UrGj789ekcYa BTJfCZwMwTXUKRbnjfsGUq6NuwXk4rFhPDeUQGstz96UkioFlJi28jgOAPlHYJ85wwD7Ne4f 7fD6hunLZSCucLcKNUHo46MIWKI12IZSiJHHOZIFzhGq1CEWnKsYTL7LI84/zvUIAUzaE1hI /KXDpjxCEPknrVeI2zNaBwg1PwqD3XZ0Wu9ige3ek0hlTEfsurDcXZI2pe1vdJoJ0kc7/msr iISdZr6sTYXBvT8LZyrnPDsqZpWAgjue0uy6IGsgG107X2A7yvkNDnW9DuA5eoOQoYewrEcw g+tX7IVYh90nw= X-IronPort-AV: E=Sophos;i="5.96,169,1665460800"; d="scan'208";a="85386777" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A8JlAUDiZ0iBgOIn3UH5xEmWgJKNgnWXmQEtcCHa5LoX7iPRudyN2oE0Dh+uKWiuqkrfCctLczZLnnR9IYA6arF9EOlawPZrenq63eylmBHyiJTKbgXC0TZ8XDW5JKhC4HB1n4KaVWBF1aOh92Ab0FN9nuoctXf8bIy+o4hsdhfZWgNFmdi3yHy6aKE/fEm3V1LsJg06D556bMTbQ8/c560WXbQUmY57BQsLs2q0Z6KCLsGCaHafByuVxeEZ908PtSX4GZPBfaWXG9EjgD4rJlGt/6nWiXsPWmQHOYGAEfudkjp/II30SWlNCsU05AVZMh29S+bAgfbdasvq4+QpXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yz7hkhekNE3b2a/JxCJWetaum+jFhYX2mO+5SiLTx/0=; b=nn6ZY2xmFih0JJMwIwxgye+utVkkfvJxvj/VGRHH7w3JRB0wrF45gckDbUW+BNZrbOUeGqb1ieqcI+B+aj65kDJWE/bX7Yoe+rnh5qJqcexrODGa36j7kg6Sc35EIg9Gk3uDD5TaoWeBSXiTrKrL9zrGDJnfhDrUECn/fOGI1+Rq+xYrJqxNbXjcjfeifdz48YK9uSBlYJvHBEZUn5CK5OObnlHr5htbcAZoPKzJQYpcXxGCScI5N4ToDwrVm1NjJmqLvk71J4Dfm+J3IzUnpCMhKcg739oiiacaym3rsDaRyu7x3P7l/oZ2GH4udLb63I/I095BHiQLX4v4igPzIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yz7hkhekNE3b2a/JxCJWetaum+jFhYX2mO+5SiLTx/0=; b=Lb61XfqDiG9h1p22LAWEM5aDUKKAwnp2CV4soFY2SIb/t1SHDbVFqc9GbDeAU7NpqXidIbVdo0AQoc17ItUynQRpZ7KiWnd1Tz6p+Z5vdi63EJr8e5vlpIHy56fOUrnjcjJmq7xrd0ozB+LZzYgXaIZPy/SrB0Gjd0lD0c2CzB4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 16 Nov 2022 18:25:52 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Jan Beulich , Wei Liu Subject: Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0 Message-ID: References: <20221116164216.7220-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: PR2PR09CA0011.eurprd09.prod.outlook.com (2603:10a6:101:16::23) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB7020:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a5ea5ef-b344-42b1-21ce-08dac7f79fcd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vJR8EPL2rZBZAFq+3aCdKfeVly6XX6sfNMncIwqy6AbN3WYWgbuDD/W4IATWk+2J54VN/iBlgSN64t5IIwGBkjoEZTVo3qTnTDbYOFirvQtobnbn/Vj6lkFocgOI++VbILl3sMqWz9mOmHpLNdIcy5RZYj2JiPaetPgG+6twmSSSXpc7y9iuP3/waAv7We0Yt1jt1LKChV2Prym3b9LI0SyHy2CFRk5DvhbihHmbPk7nmY0StJYK7jo+oVv1cjjX39Xfqp6ycc9fpfvvVrWd5hwQPO8fUkULsMqv2nzcMPDa8djtKipEHmdY7QNs1PgNbfNn/tjjpDtyL44DPOq535FKM+S8ydOL07/06iEEdhn08OzeUmfZnT1bAc9BOLKDjVI+jvCeCxV64BvkcIDg977S3kB4tZ4IEC8z8sGcisWH5wcnua+XHw/PJpLz+IQxljQ1Xijx4L4fIN9USj7Hub1XsMvPHmRQmgrwlDxpA5hOQ6Vt2n7QBlZOjHYw9X6NISVIXt56xRSTwmJWSMnQRfEQN+u24N1cvQbhhrAPnazRDy9sMmLPahFvgy82Anh1HMIjTkzYHzBIUIb4JBkLkw9yjzppC2hekmWAce7RekeUK/mR9N/DF8H1SDi4gWTWnWSnZXSqMK21c1zY1A6Vt+wC6oPgtv4iW+ChRJ5SI1p1XXqS5G+VM1THRDyezuGElmY7JpLFCtY7SKQAGSB6ng== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(376002)(346002)(396003)(366004)(39860400002)(136003)(451199015)(41300700001)(6486002)(8676002)(478600001)(316002)(33716001)(66946007)(66476007)(85182001)(4326008)(6636002)(6666004)(38100700002)(53546011)(82960400001)(6506007)(6512007)(83380400001)(5660300002)(66556008)(186003)(54906003)(86362001)(9686003)(2906002)(66899015)(26005)(8936002)(6862004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWQvZXRXZ2dRWDR3Q3pOUml6dVhsMzdablo4WSszRy8xZTJ5U2swZ1hwZUZq?= =?utf-8?B?T0IzWkFkb0U4L2gwcGFFM01aVjFXQzlJVHZNZnQwSnhnQmlBbENUNVdoSWFC?= =?utf-8?B?SWR5UmxNRWZlTVk0NEs3b1QyZXBUTWxwL0NPNjF3ZEdZakp0VFVlS3AwSUlE?= =?utf-8?B?NjIyUlhqQ2hvQ2phZ3huUytSblpITWFpMFMwZkZQVEJmWTBvQnVHb2d2MHMx?= =?utf-8?B?aTl1aVI4a3E5ZUY2OWxSOUl4RERzSVpSVG1IREl3UzhGeXdkSW9QeUhJdUpa?= =?utf-8?B?Mi9uYzYzL3hDOEp2ZUFqY0hoYWNBUEhBeEw4SHRKSzdhVFBJR0FVSjl3Ukl2?= =?utf-8?B?VmFvN0hDaktGQnBaYm1UcExBVU9FMlV0NGcxVmdBbEhFa3NvVkxoRFIydUFD?= =?utf-8?B?NnZjNFV2Z0ZmYzhYdFlZOEZROVBXSDFUL1NIa0MyZ2xMNkNzMlh4VFcxSmFB?= =?utf-8?B?ZjUyWXlHZE9ZTy8ydkJuN1g2NXdGR2xwQVk1SnVWblpSa1hkU3JFK1ZkckNj?= =?utf-8?B?cjcvSTF4RWhDcUluNWhzbG1SbkRRWFl2NnV5aHZVSnVsTHdpS0hWVWlVbnFT?= =?utf-8?B?MGFzZlZkM3F5VVZtSlAvU2NGb0ovTVB4WTJzRmRsZ0xMT3NKeTR6SWM3YVRL?= =?utf-8?B?TjY5aU5MeVZVZS9RYnRwQlhGajJMZHpHTU5tQ0NxLzc0ZlRJNU5rWkY5aUpv?= =?utf-8?B?M3ZsOTZmSFAvVnF3Y1RsWWJKallyajg1NktNQWtxL2tmOVVyTS9SejExQzU5?= =?utf-8?B?dERyR2VoRzRqblAxdGY1Q2NaR0diSXZRYVQ1Tm9nQURRTmp1ZWFzNnJOSnBD?= =?utf-8?B?Y1RzN04zT2o5eDZzUmZoK3AvNVpHdGNPTG1KNlFteEN4K0x0VzEya2lnNHps?= =?utf-8?B?Q0xCcDZ6aGEwbjBReXJSZDdsVXZUd3BIQmtBa01PQzN6TWpnVlArTkU3NjBU?= =?utf-8?B?bUUxdW02ZVd1VWJkV0ZlK3U2eHlibXp6RGo0bFRWclZjbHl0TUVUdVVDQzR2?= =?utf-8?B?SDJ4ZWZRWmxjeHpXWFVlZ0JIV2M2d0x1a3VTK1JDQ21Na1c2YXVGVDZCVU0r?= =?utf-8?B?STBGNEFOYzcyd0hNZkVERGVsU3FXdkMvejhjTUtySUZETCtBd0c0UlMxOUkw?= =?utf-8?B?ZExWWmdKREFIbllRQTVYTEdnYnd4K1llR3VPbTlFVUkvU0hWZ3Y4SmdxYVlS?= =?utf-8?B?VHE4bFRmRHZoMzJnOURia2o2dnlBSkpFS216SmNuaVA2bk0wVTdFeHZ2TU1E?= =?utf-8?B?NnRaYmlQNStGV0xteEo0akVyVmNhYVZ0enp5SUV4d3lEUGNhSW9QUWxMbDZR?= =?utf-8?B?MzNadHdDamZHRVF0K2lXYVoxY01lSnpJdEhmbmwvRlhsVUNtQTd3RmlWK1NH?= =?utf-8?B?YUJSOXV1dHhGd2R2cTBCVENSNkRzb1NuM3JJNEFMR2hjd2p0VnppT2tGRUU2?= =?utf-8?B?azQ5cE9sQTZ6VCtTMGtraXRmUWdpQlNvZCtyUTQxdGlSMnFWSXVFM3laQ1k5?= =?utf-8?B?MjBSYWJPajJFRXliajNWUUNtZVdhRG9zMFJjb3ZGVEcydVhPMzBEenlQYXJL?= =?utf-8?B?K1EyYU9aUlBTMSt4dTFxRVMrTFFrZ0VjK2JwZUpreEg3MElZcU14NnVKeWwz?= =?utf-8?B?dmoxUnY1RUxUVkEvZjM3amJ0MFgzb0pON2VxREQ5bk9DQitTZlUzMjIreUpK?= =?utf-8?B?c3dsRUZVQUsyTmRrY3gzcnljc0VIWE83OXBaQ0puUHVlZnkzekpsbExyZGF5?= =?utf-8?B?NjAvZUhOZHQva3c2QXE0T2lnOFZlcWpMOW83dStSaEhrQTV0SFN0RllHbmNv?= =?utf-8?B?QnRTQjRZVm1GV20rcnZXUjQxOE9QeTRlMTFnMDJia08xZ1BxWXJvNWNWMVNG?= =?utf-8?B?eXFYRjhUMDMrMjlBaE0vK2htTXVnWEFxWXhCUWFzdXppZXlpOXMxeVRvV2J1?= =?utf-8?B?bjcyNjUveGcrZWY5K1RhdDgzK0E1VnFZckx6K0hlLzAydk9FRGRNMWErQjZp?= =?utf-8?B?eTJ4ZlBUQ3RFaHVUdUVBRlVmck44MVdnTUIvUVFsS09yN1Q2QmkyRVA3ZWwx?= =?utf-8?B?emFCSjhHdGJoTk5hNSs5WW1rcTdBQ1ROQ3pFc2lyZnl6N0xGUDJ6ampxc081?= =?utf-8?Q?yLjtFn5dAfAiNO/3bUWBm+4I7?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 4nQ9PPQhrf/CRUihenNQhFarRp9cnYHwsOFCZ/u2jtN8CcMtzeBucgJQoSCxzTNmGHxWHHkJs/BsuRoIsMD/qiwEnYQmbikCoWe6ZkUeRuY0bBWP/g1geB6LWMj98QCgYXIsKcWrPZMx1BYVZIPxUI5JjaUIbOpSavsXmnGksie+yMicSqrMnHQY8vQFfyRQ9H0D7ULTZsoAHW28LWK9NJeq+JbgrE05nAKSM+h1nmQLWslJsZEiIyjr7MTZJ5OkgVWjUG+cJ0fmvYMTFGfrss7xwFBIic+FHanb27XaeNpeYaQ3kmQe5rSUZTozM5EzwrLVsJr8asH/T/gJC6HXjhPYifeiZJku9O+Bt+V9HP8Q2VK39ObQ3i43rd27e5QKej436t4gwfIEiAU1I+Bd9SRPqOkS+E8+2jUlqi21p8td8lvJfMHO9U+kmjWa6sHGuTUD2TzyOJkZMNNABTFULdBZHOuU2WO5NK2A/DjaS0esaxrEsWldhqebDi0F7ZnNUrfnuyfVGSG5Fo0DVQ3owcCa9EbOU3xDfebU1Z6SzaJOAuQL27ntPZdqnwhNMnxRu4a+6Q2LbVpEp7hQs0/wGqC+mKLEZNcJfYzyimOw943kB1we9T9xXb1HZ7mkMQz6s54QahKG/e+Nkxd5BTjDonRLPyA+5J4PTbkbj5Jzgrjb5fWwUTkrG9rp8UxR2sQq9k/OZN1JznyBumT7IBb77pNiE78+lsBKbwZHuiNDFg0HdslF9GjCvcUhGX7XSvhF7C5Gov/oQnMHKsnUOUYodSXE+FCe4kldYtwvxC4cv27eCsCMSDVw68sGp4Q7SpLCxSn7qvODJQK5nS7mBN0Vjg== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a5ea5ef-b344-42b1-21ce-08dac7f79fcd X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 17:26:01.8411 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bYl+PLWzeyB4PFXqJSC5mm1IIQtpxuW1yqoXpG5eycXJJ8zCfCg4DFqVDOXNnkieJx/Mv0G2CrF/RBp8of7Npw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB7020 On Wed, Nov 16, 2022 at 04:56:41PM +0000, Andrew Cooper wrote: > On 16/11/2022 16:42, Roger Pau Monne wrote: > > Currently Xen will passthrough any Local APIC NMI Structure found in > > the native ACPI MADT table to a PVH dom0. This is wrong because PVH > > doesn't have access to the physical local APIC, and instead gets an > > emulated local APIC by Xen, that doesn't have the LINT0 or LINT1 > > pins wired to anything. Furthermore the ACPI Processor UIDs used in > > the APIC NMI Structures are likely to not match the ones generated by > > Xen for the Local x2APIC Structures, creating confusion to dom0. > > > > Fix this by removing the logic to passthrough the Local APIC NMI > > Structure for PVH dom0. > > > > Fixes: 1d74282c45 ('x86: setup PVHv2 Dom0 ACPI tables') > > Signed-off-by: Roger Pau Monné > > Yeah, that was never going to work correctly. > > That said, I'm not certain we can get away with discarding them either.  > Some systems really do use ExtINT in IO-APIC entries, and dom0 is > capable of configuring this if it thinks it wants virtual wire mode. But the MADT entries discussed here (Local APIC NMI Structure) deal exclusively with the LAPIC LINT# pins, not IO-APIC pins. Interrupt Source Override Structure on the MADT are the ones that deal with IO-APIC pins, and those we do forward them to dom0 and are setup correctly (because they don't reference any Processor UID at all). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Nov 16 18:05:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 18:05:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444376.699510 (Exim 4.92) (envelope-from ) id 1ovMn5-0004B4-MU; Wed, 16 Nov 2022 18:05:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444376.699510; Wed, 16 Nov 2022 18:05:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovMn5-0004Ax-Jc; Wed, 16 Nov 2022 18:05:39 +0000 Received: by outflank-mailman (input) for mailman id 444376; Wed, 16 Nov 2022 18:05:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovMn3-0004Ao-DK for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 18:05:37 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on20614.outbound.protection.outlook.com [2a01:111:f400:7eb2::614]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 43886eca-65d9-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 19:05:35 +0100 (CET) Received: from BL1PR13CA0223.namprd13.prod.outlook.com (2603:10b6:208:2bf::18) by BY5PR12MB4998.namprd12.prod.outlook.com (2603:10b6:a03:1d4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Wed, 16 Nov 2022 18:05:30 +0000 Received: from BL02EPF0000EE3C.namprd05.prod.outlook.com (2603:10b6:208:2bf:cafe::8) by BL1PR13CA0223.outlook.office365.com (2603:10b6:208:2bf::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 18:05:30 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BL02EPF0000EE3C.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.11 via Frontend Transport; Wed, 16 Nov 2022 18:05:29 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 16 Nov 2022 12:05:29 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 16 Nov 2022 12:05:28 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43886eca-65d9-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fl5IrFFJTRxzoyjkoMtZjHt3+wDmXnY1aP+fuOM62RwlUYHIQ4hZN/aPFRkDBgYWLnJ8quP88uOCynAQNLo3usU7eC1UhvKkf+ZzMN7JipeBedJWxYvwMzZDN/Ws1NyRZNB1NgXhc9jNjTKSlrASJuFe+Iql6VcfoMayJtg4xopclCslfwt89uwt7WTVWPWL2TC9s4MKakiWE64RGXGdMvmINbVhqkqvzK3NA6BFI+ZRlnvFc7RkKKfNUFQzffRrsu1G1y1jNjaoXZv79fFv1YerzhOSHGdJCzeB7cGmqOQ8e1yKJRYa+bO1jKabiC3yMXfF1rY5Fxc9HPRfT59/0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YVPexwz1Mws6BNPqUDPpquCfnmsJJUMECnX7rTydxYs=; b=eH9ePeUxolmOQ0rjedG82mYWOZlCbLAybAT8tYSwMVKakTwnPFrOcF/jdd26bm0HcJYPzjWg8+UyVollB+16jZT0ppSOZcN5U+bzKg7LQ77xrmpbkWGMH9057+kVDlOHABuwAs3Flt/H495pwfTeQgoDc9M2Hm7icawTnzqBOmo6ySyaUekj692nhvyRVmqXbUK9hATx4oQpelpJ2MCPU+7M9YlAl0VznZJW0/7RY8wQG5/yFftRDJMBT4k712A/ak0+BjjBI3Rq6oom6Ts4na6tDFwduQR6jyC8y+k6mR3bjbIUrotrapfJOz6Br9/AI9wxxrnCgA2uTOo16GOIAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YVPexwz1Mws6BNPqUDPpquCfnmsJJUMECnX7rTydxYs=; b=iDOHbU3RJ5KDo0ISQJBtEPdJQIJjYHhNSMkhOv3PBgFy+t+qKNAthvyWaMM7R3IK8ItcIJJfNQ2HC8WXrnUh5PLY5wznAQ2O3rXuOdsjnUfaBeHSR8HWzRmWQgApxlzQa3QzGyYd7tfBId+EqLPw0Bna66lfd6l3mpotTPBPUmQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <350afafd-821c-1a05-13cb-1704d3a61bfc@amd.com> Date: Wed, 16 Nov 2022 19:05:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Content-Language: en-US To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> <0400b2d8-6f2c-6406-d966-64ed5720688c@xen.org> From: Michal Orzel In-Reply-To: <0400b2d8-6f2c-6406-d966-64ed5720688c@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0000EE3C:EE_|BY5PR12MB4998:EE_ X-MS-Office365-Filtering-Correlation-Id: d08b678f-ad85-4826-fabe-08dac7fd25b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BiG4sRpqIdPvX+efSJYOtLTYRPP/2JIk6mh2eHNMKgysPHkGY+fnpKke/hofDnJcUpuyJlgj7nV22kJmIWGYA4MYOjcERS4I0hck09HtXc7UJ/Y1u3uCuNs49q9wK5Shgh2EL+RPveRTZ0ixKxyk5781KZaKs+U7Ke/zhnZgOGt390/KZm2q/1cljLywpRzFKgdAQLIvUU3n3l7gBisG+WekdNOKG0ng5YsaVwmKRoJbn1iBBFwWbiOQlietS82QEeYLvCTWxsVeHrAidLiHSHNXcY+R4LNXfSapzCpjvqbNdZPHSFx4WwJaNnoE1mGFbnOevSc4KKmzTblxNveSTxt7xOtGgM1Fa7OOnYzZHZA8pWdP4F3AB3NKp19LTAxfsbPOTWjwzdBrZdeBVCkALjdCaXrP1EusR09wv08ZiEpbxG2zR7EcOMqhVum6r+Ui6usXBdr34WnCJpKLA0DXodrYMFv7EyEuChTFMD8rYVShks85DWFTAs+Qbcxcfl6ob8DMxvaPxB16kVfaS5nCYn5IEKA4v/b7lxUhcKUtqieJVpD4r7KRtAfy0NVTSpRA24uu7m5z93cJzEvuSs/iUtiwniaevTT+npR5Dqq62FV/kq+0RaGwkP9C1yu2QTmm57scHvhLshdh3hlQy+H9qilp6PIStFkPw20FLDMEKDWSpIGZWhqGfEsg8mFeiA7y3GfHQFKbK6hWnsLwJ2Rkv0KX4NY0dpSTUr1R11w/ID/mBLRZb1OApJTdIzk9Gk/vP/bpSQlnMytkh2VQ0etArU3jVV7KTA380nfhhQq0knZw6cnFs6lFtA8vILXFLvyEMV0T6H1DHZJlgBQDRMHMnA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199015)(46966006)(40470700004)(36840700001)(36756003)(31686004)(86362001)(31696002)(83380400001)(36860700001)(40480700001)(40460700003)(5660300002)(2906002)(44832011)(426003)(356005)(2616005)(186003)(53546011)(110136005)(81166007)(47076005)(82740400003)(336012)(26005)(82310400005)(41300700001)(70586007)(316002)(16576012)(70206006)(478600001)(4326008)(54906003)(8676002)(8936002)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 18:05:29.9436 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d08b678f-ad85-4826-fabe-08dac7fd25b6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0000EE3C.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4998 Hi Julien, On 16/11/2022 16:56, Julien Grall wrote: > > > On 16/11/2022 14:45, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >>> >>>> and use it in the pl011-debug files (+ there is a question whether we should define WLEN_7-5 for completeness). >>> >>> I would not define WLEN_7-5. That said, I wonder if we really need to >>> set the baud rate & co here? >>> >>> AFAICT the runtime driver never touch them. The reasoning is the >>> firmware is responsible to configure the serial. Therefore, I would >>> consider to drop the code (setting UARTCR might still be necessary). >> I do not really agree because the current behavior was done on purpose. > > EARLY_UART_PL011_BAUD_RATE is only used for very early debugging (this > is protected by CONFIG_DEBUG and CONFIG_EXPERT). This is not a > production ready code. I am fully aware of it. I just found it useful but I understand the global reasoning. > >> At the moment early_uart_init is called only if EARLY_UART_PL011_BAUD_RATE is set to a value != 0. >> This is done in order to have flexibility to either stick to what firmware/bootloader configured or to change this >> configuration by specifying the EARLY_UART_PL011_BAUD_RATE (useful when you do not know what >> the firmware configured). > The chances are that you want to use the baud rate that was configured > by the firmware. Otherwise, you would need to change the configuration > of minicom (or whatever you used) to get proper output for the firmware > and then Xen. > > Furthermore, as I wrote before, the runtime driver doesn't configure the > baud rate. This was removed in Xen 4.7 (see commit 2048e17ca9df > "drivers/pl011: Don't configure baudrate") because it was buggy and this > code is not simple. > > So it makes no sense to configure the baud rate when using early printk > but not the runtime driver. Ok, so we will get rid of EARLY_UART_PL011_BAUD_RATE config and setting the bd in the early uart code. Now, what about setting "8n1"? The runtime driver sets them as well as the early code. It can also be set to a different value from the firmware (unlikely but it can happen I think). In any case, if we decide to do what the runtime driver does, I reckon setting LCR_H should be kept in early code. > > So we have two choices: > 1) Remove the baud rate setting in the early uart code > 2) Support the baud rate in the runtime driver > > I strongly prefer 1 so far because there are not any practical use to > have a different baud rate for Xen and the firmware. > > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 16 18:15:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 18:15:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444380.699521 (Exim 4.92) (envelope-from ) id 1ovMwA-0005sT-JN; Wed, 16 Nov 2022 18:15:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444380.699521; Wed, 16 Nov 2022 18:15:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovMwA-0005sM-F6; Wed, 16 Nov 2022 18:15:02 +0000 Received: by outflank-mailman (input) for mailman id 444380; Wed, 16 Nov 2022 18:15:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovMw8-0005sG-FV for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 18:15:00 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 93515e2f-65da-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 19:14:58 +0100 (CET) Received: from mail-bn1nam02lp2045.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Nov 2022 13:14:48 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by CO1PR03MB5666.namprd03.prod.outlook.com (2603:10b6:303:9c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Wed, 16 Nov 2022 18:14:46 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860%5]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 18:14:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93515e2f-65da-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668622498; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=g+hRlQytNeCZeQzkEk5yFfWTEVJr/nGEkP1sfutSjtE=; b=h84Zq3usNeyPsOmsLxzocNtGMXp4FqfZKxcclDGxohUcw41Y4QP60G58 14LKHtYZf4kTDjtdIpwAahFvU0RhrBQIu92M2cxRHWkBsumQkWH30Ptb7 6dJMPzInsDx4to/frIHAf9C0H8WW5Jc5KDWMfBJ7oFb/aIQEIVddGTrN0 Y=; X-IronPort-RemoteIP: 104.47.51.45 X-IronPort-MID: 84550894 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:9gU8z6sqr+rmCAyw9EUxdDUXvefnVGlfMUV32f8akzHdYApBsoF/q tZmKWuGPf6LazSjL49wOYTi8UwFu8KAmtNkGVQ5qCozFi1E+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaHySFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwNz0NKRqjltmK/o2RVfRu19oeAOn6FdZK0p1g5Wmx4fcOZ7nmG/+Pz/kBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osif6xbbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6ROHlq6Y60QH7Kmo7Mzw6aGWyucmDyUuEQeBCN nAk2y4jsv1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xGWwsXjNHLts8u6ceZTEsz E7PoNrvChRmqrjTQnWYnp+EoDX3NSULIGsqYS4fURBD89TluJs0jB/EUpBkCqHdszHuMTT5w jTPpi5ngbwW1ZQPz//joQ2BhC+wrJ/USAJz/h/QQm+u8gJ+YsiiepCs7l/Yq/1HKe51U2W8g ZTNoODGhMhmMH1HvHXlrDkldF1x28u4DQ== IronPort-HdrOrdr: A9a23:fZedW61OsgmhGUxBy99/oAqjBZpxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LoSK05KX8Gx242A5bdz9U278t/U XMjgS8v8yYwrCG4y6Z81WWw4VdmdPnxNcGLMuQivINIjGpphe0aJ9nU7iiuilwhO208l4lnP TFvh9lFcVu7HH6eH2zvHLWqkfd+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ g7nF6xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklUqvoXRiKrbzPIt MeS/0018wmN29yqEqp51WH9ebcGkjb2C32GnTq9PbliAS+10oJsnfwjPZv4kvosqhNC6Wsrt 60TJiB3tt1P7ArRLM4C+EbTcStDGvRBRrKLWKJOFziULoKInTXtvfMkfwIDcyRCes1JaEJ6e L8eUIdsXR3d1PlCMWI0pEO+hfRQH+lVTCozs1F/ZB2trD1WbKuaES4ORsTutrlp+9aDtzQWv 61Np4TC/j/LXH2EYIM2wHlQZFdJXQXTcVQsNcmXFCFpN7NN+TRx6TmWeeWIKCoHScvW2v5DH dGVD/vJN9Y5kTuQXP8iAi5YQKYRqU+x+MELEH3xZlh9GFWDPw8juE8syXI2uibbTtfr6cxYE xyZLv6j6LTnxjFwVr1 X-IronPort-AV: E=Sophos;i="5.96,169,1665460800"; d="scan'208";a="84550894" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JBUSmWqV88oFV5CpUi39w7j5Fb/iJEhkwYQzi4FtqiKLT8BKotP0VaMHzqU+IU2XNQBST8BFzEci71/tZ469vMTtccESoGT1YfHAM6vFQaS0u7hQi8o1lxIbAeIu4IhrrECjQsYsHGMqHoNgis/SD4vfjmCLHzxYIC3fuKRToecp5Wmga/ni+zBSgdfedlpJ/7tYEDPZ7BzwGprUWl93GoqKoPMYRTDxVEMDyNun7lDjbS7YrbGn/A+s1CF/NXT7m4DpFcfVZpNOl8XvR5yaAeT7jzpL9g5SV5tPL84p4YyayGVUh7Fnq2BEko5XNjPbXCJkF9oZ3sTNWESTK7oIbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g+hRlQytNeCZeQzkEk5yFfWTEVJr/nGEkP1sfutSjtE=; b=nEoy/f7ZGmwIPRza5Li7WxP07XTMBa1JlqKPIEuvXEvkpQhlUBEdypEnSqXcLINaAAaEjWqhEsRI5vBRLw6J1vYzHgPD+01eaJSQLfNzQbb5gTlzkJzZLnGdWLFMPKX+iDaEqf58NLlonq+YvDbj37jv+K2wHVNnmHHeklCxb+NLtYgEJ7w2pCmYmsU+PgvZFFxL3Qes6LfvUPqf/fcm5y5V/OTjKv7haydALX6ED9MUVSQzSLVUh9j83RNE4qdVA+pUMm/9/EU4YYy7CnKq27yXuhUnd7T9PMPpXzyQdy0kf9yaI9P2id7XvkryPuHz5h0AsNM+i7pEDg4MmW3wXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g+hRlQytNeCZeQzkEk5yFfWTEVJr/nGEkP1sfutSjtE=; b=Lz0TbvvqMMc9KBQK/q8sup059Js/EEFc3DEvg6rX5HM9VTekRfl5ifUHwctpXRnp9fE8TCEXjXibsyYpSaurGGowFc+E++1MwED7xKq7Sap8rnGg2H3Vgprkq4u9ZbtdhTyolVceuS7MDCQc8laS68exyeIsW0MH9AAVbIUIKF4= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Henry Wang , Xen-devel Subject: Re: [PATCH for-4.17] x86/hvm: Revert per-domain APIC acceleration support Thread-Topic: [PATCH for-4.17] x86/hvm: Revert per-domain APIC acceleration support Thread-Index: AQHY+Io3ygoaE+gKUU+QEYfs8WRTZ64/rWQAgAIwI4A= Date: Wed, 16 Nov 2022 18:14:46 +0000 Message-ID: <2334ba7c-d744-c1ca-8f67-b2013e9c5fe4@citrix.com> References: <20221115003539.19502-1-andrew.cooper3@citrix.com> <29469c16-856c-bce7-c556-66622e349f1c@suse.com> In-Reply-To: <29469c16-856c-bce7-c556-66622e349f1c@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|CO1PR03MB5666:EE_ x-ms-office365-filtering-correlation-id: ca452f7a-947e-412f-9064-08dac7fe7133 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: so8JZBqRH+EjuNno5sBmtfivInkNHQ1HHnsbfx+0PkhSU3ABjMaVZoABBHUvUr34tdwI4QA9VJIjmU0wS4+oXI/WglrftZRiFjQgTLBFjBUEaf6P+3l92MiKgSbDvL28cgxhTaGx5ALXUxS8yjDVv9uDYRTiWxUgG5xaMvixZP04URnELRS5ZUkW0pArdgS/xmsA4xkE00vhtKfROAL/BrLeH3WB6/UYm9kTI14F7a4gM7m9C+v+6Jq8dlss3kHt7ZkmCmFj+Y+3HtYwwtVRLMKmeDazdkBrfzVZX8iaSxI9H4604MNnC8K7KWjfQwDlhnR56Xm9iZo0yDqDcH8fXyc/Qh4qJeypn29BjCfvh5BiEvR5W0lCpUXuSXtH5D6RCB0nXRaVDyEBvdDaWJG1ke8dSsu6jLb0vNiCKR+JCp8nDSJfygeLwm5DMnWmd9/HTErXxndPrwpGPtGSOzY+dQD8V+n4TbzoQb6kw8CZnL8qtL0Mx+ieh3aArQNMnq1Wuy4iXvne3EdyOD7hsCM+O00nVfHMDh5vDHH1m/+yQ1pVEkWHzfgD4RdWspQBeR+CAXhJlmlWuEQWcggCle0DtgIK1qvqrEzwMP1KnhQscvt/mXWlTUxtujrtt7+jHqs3WxN/F0/P0ZKv0dQcyIG4VuWKrgdmp5zsOt9qn8xg2nX9NH60V7WxBuxqh67iiI3HHfQnqtlRUxq8/Yek/3bmopnPUxLvTr0tvFBO7lda9yVu0WXbDCUtpILnQfkblvmkkGu+mMaYpaXxoOfH2H8JcPkC0oQ8L/Rx0EUAe/qRr04smV4jIU07bRchNDOSwobudT2xcSfDvE/15dTBLETC4g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(396003)(376002)(136003)(366004)(451199015)(38100700002)(82960400001)(31686004)(122000001)(36756003)(316002)(91956017)(66556008)(66946007)(66476007)(6916009)(8676002)(66446008)(64756008)(76116006)(54906003)(41300700001)(6512007)(5660300002)(71200400001)(2906002)(2616005)(4326008)(8936002)(6486002)(86362001)(31696002)(38070700005)(26005)(6506007)(478600001)(53546011)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bXpmaWQ3UXExOTl6eWl3c0RFQ0MwZ25iMVQ5b3NWWTU3U1I0ZElYelo0S2hj?= =?utf-8?B?RXhhQ1NOUlRQa1VTejVPUUVza0FHL3NBSDBZMTNaYnRWVEtQK2h0YThrNDZu?= =?utf-8?B?dlVsK0ZtT20vUVhFR2VFUVhnM3VORjEyNk5jai9NeWxzcWt6aXRMM1NsR05I?= =?utf-8?B?eWNtMjVlR1kwL3BUeTlqaWhsQll4Zm8vRFB6ODNpaHlya3VFTkQ2Q0NpS3lH?= =?utf-8?B?cnBCYXZNYW1NNUxlSW9OaGtFZWI5Um1BOE5UNTZxUjdBSUt5TVpUYTJFdHls?= =?utf-8?B?UmoyQWt1ek1qWFZmWXc5M2xMdVJzSUoyc2xmbWhKQjR6RGpQOTVzOTBOVWVr?= =?utf-8?B?b04ycE5XTzlxazV6My9EUURvWEZnTUM0OC82eTdyd2JpVUtvb1NqK2dreGU3?= =?utf-8?B?RmJxM2ZWbkl0ZzBBRkpHZWpQUWQ2c1Y3M2VXUnc1VWRGZE5qazg1eE1SeVJK?= =?utf-8?B?Q0ZHS0VkbUpZZWVkb0xSTkVKZnk1M0FRSkVxYkM0N1I5Q2VZRDFtNDM3ejdr?= =?utf-8?B?cGpnenRaQlBVZFZaUHUyOERWWHNmRFhla3VYYTBCdzN1V0FBL0VNM2RrSk1E?= =?utf-8?B?T3pjeGdTNWxlRFdqWmoxSzdXQ2tzWDJELzhqLy9wNEF1dmRqb2syN011MWxp?= =?utf-8?B?YkE3cWo4SWZ4M1djK0dUcVR6Sm9GdThXMk5qNU5sZEI1bjVESjZySnRpb3dY?= =?utf-8?B?Z0tjbCszam5uNVI4TGNhbmNjMTN0SGsxU1hnRHYwT0JYeEFwNjFjTkszeVh6?= =?utf-8?B?TGIwVVNPWE9YRG9Ld3MwSXRvaGoyMEcrcXlYWlMxZG9jZk1TZkdzOGpKZDBx?= =?utf-8?B?TnVXUzErZXhlUjdpNUF5ZEM2Wk9zZ1Z0cVRBd0RielRHdXVGSFc0VU9CcjlQ?= =?utf-8?B?a0RkRkF4bTkwbTBVVEI4KzdoQlVnREU5a0o0ZGh4d01aNCszd1FhWjNJbjdy?= =?utf-8?B?VTlMTjNlWEI2SkxPTnlIem8rOXZ1T2x5V3ozcWtYZHA5M080WXFuWXNVSjNJ?= =?utf-8?B?L0xOTWoxQ1JzT29RN0o0MmNidnVKOHZsWldEQ3l5K25SNTc2dDJSMjIxMkJ0?= =?utf-8?B?U1ZKRkJXWTExdzk5enFOZ0FreTBmdWJRZHFDNlVrWDg1TzhzZzliR29iUVh6?= =?utf-8?B?amVaRk1XVXU5bmRrZkNVZDNCNFhxb1RYSWtXbGhybXV2bG01YUppbzRYbnVY?= =?utf-8?B?U0k1dE5XdmRRbm1US1g0TUdDS2g2ZFF1U1YzUk9obm9LbXZScktLQzNkRTVS?= =?utf-8?B?cnBsdHYxaWY2RVVMbTVVTzZJSk1yUXNBaFp5S2pNY083K01YbXZldEFoS3Na?= =?utf-8?B?Yk9zMXdoMTlxcVNzMlVGa0gvVkVTTlladmQwUEh1QXo2a25ObXltbHhvYlY1?= =?utf-8?B?ZDNqck41WGpZcGJ4enVlY1NHNVc0d3U1d1V0S0dTSHROUm9EeXRRNHVWQ21j?= =?utf-8?B?TFhZMGViajhkZEVNZHVhY0EyREtaQkUrc0F0RVkrdWVXZlgyQ2xFSG45cmk3?= =?utf-8?B?bU12UFhnQUxodFczc3pDM0xMNm1sWTF4YXM5SmhvNUxYb2hPOEZKVG1TYWUv?= =?utf-8?B?OG5NZUNoczJTcnBSdkVSU000LzNYVGxnd1V1dy9HVnA3aWYrNEZFc2kwR05X?= =?utf-8?B?dzE1Q295YWt0em43OTUvRFlTK0ZrK2pDMEd4dGM0SEdVNThFYVZhQUN4U1dJ?= =?utf-8?B?UjJRQUtVb1ZrRnN3dUJBeWpDMWhzTjFjR0cyWEk5QUc5R3dpRSsvQklPN3dG?= =?utf-8?B?OHRLWkZuZXFCNXVtTU5IN2g5b3h0Snlua1BoUFpUNUpObk9mZU90M1c3ZGhG?= =?utf-8?B?NXREYjUzRi9EVVRLN0MrOWRLbm5wQStlWkU2ditwQW0wT1d4U1BMSXEyYUlk?= =?utf-8?B?R0prZnJzSUd1SnNnd3FlODRyRFMyMmpCSkhqdnVDanY0REQvWUU3dFVpclZW?= =?utf-8?B?NERyWkUxeUhFdGd5TExwaXg0ZXR2U1poaFF1Q0k1eFZQTkJWR3VTNU1xK2hI?= =?utf-8?B?Qms4ZlhPcmVXdWk0Q1E0Yk9YU0t2aTluOW1Md05kUkV6N05RV0pSVFhUbjlQ?= =?utf-8?B?a3NMdTI5c3RCMUFlbWFKUDN6WGE2cEo5RlhnZjBQYnRPMVFvV2FNMEpJM2Qy?= =?utf-8?B?SjFSSExaVjhZUXl6OHNGTFJFQk9GQW1WMklqbDlVSUM0NkluMWQ1TDZJRFJw?= =?utf-8?B?L3c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <912C80D9CBB66D459946E261A1D105C0@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: wPWIRw7Bt8u9mfB/oYG5uj5keiVx+sZ/EgQRQcyaoCwmmOMsfD4wLUOs40rge+MG4sdcDd1YExaN2nxGcc8HfO59op4DGAWXrNJIHgvdY/veMgpzmjNu+iYt68hX/1lc9jHOdc3iSGasO4RivRK1sbmD990YDjzHu7S01kef4buCXVtFiSE3FxB5yCSr2827G+oVwKVUagaPxJfvauwuFOLohuaru0UUpuwJIGnGCVESNEBfPXuvarVHwX5ovgY034TouStglvL79VvlE4t18cgEx5dHsU8k1gaas/st5PtjlntotreoaM/bQDWdelUE7bIQaqvK8Czts2ImAdUPa1D4WObFvjnXmkouB3NO4MnJ+6HENk3LnquV9Tr+QJdc31OMdlwzdxRJ9mxIFgR2wb3ubokPKx6R1g22VpAmAT7hzjepDt6whMUaAmJRoKDSJRY9sJrK5KaYooZoE8qrlll+tjOOdadhS79q0mMeZ5ThOEhTPCg7R73pX8IERDyXvaQvsA6aExIfh/IKTIVr7ImE4swGi/QoQBeKdRqmGiQMYA29aF5vaxte3RQX2vsw//1DI2kZyLHTAzq/3nuEXKzkagatxTNh/1Ov/D3LzFdg7MqBFzTWrMaSSpr5o5a8rQnvwdeefWZ0oLd8jv4tA6FSnno5hqTxVb13r9cBx26hqV04EQEJH+/y0eQp9yr9QohTVlbF96ogPKSLq623ugB/bCX5LRpAwokwXvg7f4QOI4Uai67cv489DQgd1dJ+UZBOSNuL4uT75U+4J/72t6KC8p83/Sgzm95Xbvzmtuq0363GeT3ilGs7c5zVruTN8pAbQdap+RH07d/EYCBfuvcWCuqejW6ldWQmnfc4XFA= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca452f7a-947e-412f-9064-08dac7fe7133 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 18:14:46.0703 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BRf8y9V74DZj0of0GTslfuRd1q6T8x8qSOC0tuz0ljDiQY7QnKkHQYs5SnXEdQ0sjmwHwxloHYkkqqcsWKZKUx3nkC09GL4D7hKKUVYVeG0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5666 T24gMTUvMTEvMjAyMiAwODo0OSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE1LjExLjIwMjIg MDE6MzUsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBJIHdhcyByZWFsbHkgaG9waW5nIHRvIGF2 b2lkIHRoaXMsIGJ1dCBpdHMgbm93IHRvbyBsYXRlIGluIHRoZSA0LjE3IGZyZWV6ZSBhbmQNCj4+ IHdlIHN0aWxsIGRvbid0IGhhdmUgd29ya2luZyBmaXhlcy4NCj4+DQo+PiBUaGUgaW4tWGVuIGNh bGN1bGF0aW9ucyBmb3IgYXNzaXN0YW5jZSBjYXBhYmlsaXRpZXMgYXJlIGJ1Z2d5LiAgRm9yIHRo ZQ0KPj4gYXZvaWRhbmNlIG9mIGRvdWJ0LCB0aGUgb3JpZ2luYWwgaW50ZW50aW9uIHdhcyB0byBi ZSBhYmxlIHRvIGNvbnRyb2wgZXZlcnkNCj4+IGFzcGVjdCBvZiBhIEFQSUMgYWNjZWxlcmF0aW9u IHNvIHdlIGNvdWxkIGNvbXByZWhlbnNpdmVseSB0ZXN0IFhlbidzIHN1cHBvcnQsDQo+PiBhcyBp dCBoYXMgcHJvdmVkIHRvIGJlIGJ1Z2d5IHRpbWUgYW5kIHRpbWUgYWdhaW4uDQo+Pg0KPj4gRXZl biBhZnRlciBhIHByb3RyYWN0ZWQgZGlzY3Vzc2lvbiBvbiB3aGF0IHRoZSBuZXcgQVBJIG91Z2h0 IHRvIG1lYW4sIGF0dGVtcHRzDQo+PiB0byBhcHBseSBpdCB0byB0aGUgZXhpc3RpbmcgbG9naWMg aGF2ZSBiZWVuIHVuc3VjY2Vzc2Z1bCwgcHJvdmluZyB0aGF0IHRoZQ0KPj4gQVBJL0FCSSBpcyB0 b28gY29tcGxpY2F0ZWQgZm9yIG1vc3QgcGVvcGxlIHRvIHJlYXNvbiBhYm91dC4NCj4gTGlrZSBS b2dlciBJJ20gc3RpbGwgaGF2aW5nIHRyb3VibGUgc2VlaW5nIHdoYXQgQUJJIHlvdSdyZSB0YWxr aW5nDQo+IGFib3V0IGhlcmUuIFllcywgdGhlcmUgYXJlIGludGVybmFsIGhhbmRsaW5nIGlzc3Vl cywgYnV0IHRoYXQncyBoYXJkbHkNCj4gIkFCSSIuIEFuZCBhcyBSb2dlciBpbmRpY2F0ZWQgYmVm b3JlLCBhbnl0aGluZyBkb21jdGwvc3lzY3RsIGlzbid0DQo+IHN0YWJsZSBhbnl3YXkuDQoNCkl0 IGFic29sdXRlbHkgaXMgc3RhYmxlIHdoZW4gaXQgaXQgZXh0ZW5kcyBiZXlvbmQgZG9tY3RsL3N5 c2N0bCBpbnRvIHRoZQ0KbGlieGwgQVBJLCB0d28gZGlmZmVyZW50IHhsIGNvbmZpZyBmaWxlcywg YW5kIFhlbiBjb21tYW5kIGxpbmUgKGZvciBQVkgNCmRvbTApLg0KDQpkb21jdGwvc3lzY3RsIGFy ZSB0aGUgdmVyeSBsZWFzdCBvZiB0aGUgcHJvYmxlbS4NCg0KPj4gVGhpcyByZXZlcnRzIG1vc3Qg b2Y6DQo+PiAgIDJjZTExY2UyNDlhMzk4MWJhYzUwOTE0YzZhOTBmNjgxYWQ3YTQyMjINCj4+ICAg NmIyYjliMzQwNTA5MmMzYWQzOGQ3MzQyOTg4YTU4NGI4ZWZhNjc0Yw0KPiBwbHVzIChhcyBwZXIg Rml4ZXM6IHRhZ3MpDQo+DQo+IDM5OWJjYmYyODFiZDkzNmQxZWZmN2Y3ZDEwNTRhYjQ5MTE1YzNh NDQNCj4gMDgyM2Q1N2Q3MWM3MDIzYmVhOTRkNDgzZjY5ZjdiNWU2MjgyMDEwMg0KPg0KPiB3aGlj aCBJIHRoaW5rIHdhbnQgbWVudGlvbmluZyBoZXJlIGFzIHdlbGwgZGVzcGl0ZSwgbGlrZSBzdGF0 ZWQgZm9yIHRoZQ0KPiBtYWluIGNvbW1pdHMsIHBhcnRzIGFyZSBsZWZ0IGluIHBsYWNlLg0KPg0K Pj4gbGVhdmluZyBpbiBwbGFjZSB0aGUgbm9uLUFQSUMgc3BlY2lmaWMgY2hhbmdlcyAobWluaW1h bCBhcyB0aGV5IGFyZSkuDQo+Pg0KPj4gVGhpcyB0YWtlcyB1cyBiYWNrIHRvIHRoZSBiZWhhdmlv dXIgb2YgWGVuIDQuMTYgd2hlcmUgQVBJQyBhY2NlbGVyYXRpb24gaXMNCj4+IGNvbmZpZ3VyZWQg b24gYSBwZXIgc3lzdGVtIGJhc2lzLg0KPj4NCj4+IFRoaXMgd29yayB3aWxsIGJlIHJldmlzaXRl ZCBpbiBkdWUgY291cnNlLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFu ZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+IFByb3Zpc2lvbmFsIHVwb24gUm9nZXIgbm90IG9i amVjdGluZyAoaS5lLiBoaW0gYXQgbGVhc3QgcmVtYWluaW5nDQo+IG5ldXRyYWwpLCBhbmQgcHJl ZmVyYWJseSB3aXRoIHRoZSBhYm92ZSByZW1hcmtzIGFkZHJlc3NlZDoNCj4gQWNrZWQtYnk6IEph biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KVGhhbmtzLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 16 18:37:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 18:37:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444384.699532 (Exim 4.92) (envelope-from ) id 1ovNHY-0000OG-DU; Wed, 16 Nov 2022 18:37:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444384.699532; Wed, 16 Nov 2022 18:37:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovNHY-0000O9-AV; Wed, 16 Nov 2022 18:37:08 +0000 Received: by outflank-mailman (input) for mailman id 444384; Wed, 16 Nov 2022 18:37:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovNHX-0000O3-JX for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 18:37:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovNHX-0002tb-38; Wed, 16 Nov 2022 18:37:07 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.13.29]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ovNHW-0007SC-Rh; Wed, 16 Nov 2022 18:37:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=yFbTu5tpknRiV3uO3Ck/TG/4lqnA5v7fBAbFu1rRGrs=; b=pTpeh5ICg9sNIiml17ehMoLHME OBb5wwOixtFrlvaGAhLpELA4/YeqNdYYHL0tBR0XK9rS16XvSUBNXEYacnS/F1HxZxGut8+LMqrTP plM5GMO1SQphqUftDnq5PUTFidcjWuH+KhTV02Wz4HxRa2i9xU5IbwXVVYB3n/a2Ydyc=; Message-ID: <84710d96-c473-fa41-d847-2b109dfb49c9@xen.org> Date: Wed, 16 Nov 2022 18:37:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> <0400b2d8-6f2c-6406-d966-64ed5720688c@xen.org> <350afafd-821c-1a05-13cb-1704d3a61bfc@amd.com> From: Julien Grall In-Reply-To: <350afafd-821c-1a05-13cb-1704d3a61bfc@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 16/11/2022 18:05, Michal Orzel wrote: > On 16/11/2022 16:56, Julien Grall wrote: >> >> >> On 16/11/2022 14:45, Michal Orzel wrote: >>> Hi Julien, >> >> Hi Michal, >> >>>> >>>>> and use it in the pl011-debug files (+ there is a question whether we should define WLEN_7-5 for completeness). >>>> >>>> I would not define WLEN_7-5. That said, I wonder if we really need to >>>> set the baud rate & co here? >>>> >>>> AFAICT the runtime driver never touch them. The reasoning is the >>>> firmware is responsible to configure the serial. Therefore, I would >>>> consider to drop the code (setting UARTCR might still be necessary). >>> I do not really agree because the current behavior was done on purpose. >> >> EARLY_UART_PL011_BAUD_RATE is only used for very early debugging (this >> is protected by CONFIG_DEBUG and CONFIG_EXPERT). This is not a >> production ready code. > I am fully aware of it. I just found it useful but I understand the global reasoning. > >> >>> At the moment early_uart_init is called only if EARLY_UART_PL011_BAUD_RATE is set to a value != 0. >>> This is done in order to have flexibility to either stick to what firmware/bootloader configured or to change this >>> configuration by specifying the EARLY_UART_PL011_BAUD_RATE (useful when you do not know what >>> the firmware configured). >> The chances are that you want to use the baud rate that was configured >> by the firmware. Otherwise, you would need to change the configuration >> of minicom (or whatever you used) to get proper output for the firmware >> and then Xen. >> >> Furthermore, as I wrote before, the runtime driver doesn't configure the >> baud rate. This was removed in Xen 4.7 (see commit 2048e17ca9df >> "drivers/pl011: Don't configure baudrate") because it was buggy and this >> code is not simple. >> >> So it makes no sense to configure the baud rate when using early printk >> but not the runtime driver. > Ok, so we will get rid of EARLY_UART_PL011_BAUD_RATE config and setting the bd > in the early uart code. Now, what about setting "8n1"? The runtime driver sets them > as well as the early code. It can also be set to a different value from the firmware > (unlikely but it can happen I think). In any case, if we decide to do what the runtime driver > does, I reckon setting LCR_H should be kept in early code. Good question. I think, you would end up with the same issue I mentioned above if the firmware and Xen have different line control registers (tools like minicom/screen would ask for it). So I am on the fence here. In one way, it seems pointless keep it. But on the other hand, Xen has always set it. So I have no data to prove this will be fine everywhere. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 16 18:51:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 18:51:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444389.699543 (Exim 4.92) (envelope-from ) id 1ovNVQ-0003Id-NQ; Wed, 16 Nov 2022 18:51:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444389.699543; Wed, 16 Nov 2022 18:51:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovNVQ-0003IW-Kd; Wed, 16 Nov 2022 18:51:28 +0000 Received: by outflank-mailman (input) for mailman id 444389; Wed, 16 Nov 2022 18:51:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovNVP-0003IQ-7r for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 18:51:27 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id abddb04a-65df-11ed-91b6-6bf2151ebd3b; Wed, 16 Nov 2022 19:51:25 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DDB36B81DA8; Wed, 16 Nov 2022 18:51:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 9C673C433D6; Wed, 16 Nov 2022 18:51:23 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 8011EE21EFD; Wed, 16 Nov 2022 18:51:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abddb04a-65df-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668624683; bh=Ix65TQWZ4DpjbScvYzV559zitmw6e2Fr+crZYEqU9vU=; h=Subject:From:In-Reply-To:References:Date:To:Cc:From; b=CImTd82z0bEtf8pkWKBANxbBU3MPuIwCtromsO3gBx4MZ8AsWWIjxJMpcKNL9Itd9 oIfv6jGQQ87JqZZvGtBgTV3O8g2+ukgLzoKud0IJYEMKolxZ2c8py01HinLofd+H0i AvSXZzqTuUnklVzguBOTtxgFlvyo1jTI+hJH8GPvkaus4/KsXMA+tfr67BvMc0ELF8 i9P1hgCXzfOBc6abb5wJkkIj6IvoQOqfCzUAI4d/njFC1GQo2YXKupa46rrjpRWC0e UFfKtqwLChPckbxM5JuE/EYuSdT976v8JonLLAjudT7tfmtNN1y2NtT5v0KL+rLXh4 9rM4o6E4n3VMw== Subject: Re: [GIT PULL] xen: branch for v6.1-rc6 From: pr-tracker-bot@kernel.org In-Reply-To: <20221116120055.4299-1-jgross@suse.com> References: <20221116120055.4299-1-jgross@suse.com> X-PR-Tracked-List-Id: Xen developer discussion X-PR-Tracked-Message-Id: <20221116120055.4299-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.1-rc6-tag X-PR-Tracked-Commit-Id: 4abb77fc5531381484477cac95913336c97176b7 X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: cc675d22e422442f6d230654a55a5fc5682ea018 Message-Id: <166862468351.19828.7207830520981155384.pr-tracker-bot@kernel.org> Date: Wed, 16 Nov 2022 18:51:23 +0000 To: Juergen Gross Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org The pull request you sent on Wed, 16 Nov 2022 13:00:55 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.1-rc6-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/cc675d22e422442f6d230654a55a5fc5682ea018 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Wed Nov 16 19:15:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 19:15:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444395.699554 (Exim 4.92) (envelope-from ) id 1ovNsn-0006Hm-Jn; Wed, 16 Nov 2022 19:15:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444395.699554; Wed, 16 Nov 2022 19:15:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovNsn-0006Hf-Gc; Wed, 16 Nov 2022 19:15:37 +0000 Received: by outflank-mailman (input) for mailman id 444395; Wed, 16 Nov 2022 19:15:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovNsm-0006HZ-5r for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 19:15:36 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0be2eefa-65e3-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 20:15:35 +0100 (CET) Received: by mail-ed1-x52c.google.com with SMTP id 21so28093281edv.3 for ; Wed, 16 Nov 2022 11:15:35 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0be2eefa-65e3-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=L9qI+icUfecGM5aEXi1wLqFbcmy/8kfIaJ2CdGEr+qY=; b=pp08S/M4nd8Tjj7HnvOL2k/2yxOseTicNANPQqj1LsB2RCtM7K68HZcK4ruJ7zBLaa 2V4rHUU4qtKg76l7LaozxgXlyZHzu5LCIMvzEFQIYf4u/nT7v+GKTYjATzrAf/mgV21B p6ySG1lTvBwzIx/vFU+FuKpYKSK6R+zqW77J227TMq0Jj8sLb/2+zoh29YhE+NExG2NN BUJR3I5ZaYWEOGdh6j8tpUMUx/iVagV9hcdqJZYvCqRculJiFlagl1vU8pF4dSFfeLnX tNvlVGOt1oMuWbe0kqQmgJupRO3VNz8UTg79zAVm9nwTn2JxykxnRCeYxWWQSAhvex57 K61g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L9qI+icUfecGM5aEXi1wLqFbcmy/8kfIaJ2CdGEr+qY=; b=5DaaHXqzx9fEccU1ZBrT9nLKW57Ot1ecm9H2IcNCk/a22N5YFuzwFTqWKgUoed4z3b w4sy6dCbeDSVIzTNfEQWS7E72tJqdhwxx4hltPje2MQBU+RcLOFnAJ+/yu0O5xtXk6I8 Xgruk3lz2Ph8/9r0nG760InjfaBjZdSTOqPoU84PNnhnMhyz7GzaAZbqcQwCo+25bG9a EazXmq3JtT5xyCpDqFvf6CcBKF33g+F2Fu4ZVNXJ21GXTxOWg0lTduUDA25NHXD6PiKb KBZl6i/Q0vhMWgibx7EwTJwaZMfLFdOMJfIJJLKL8d6P6eCt9EUG/badqAXwyucpNu7p CcWA== X-Gm-Message-State: ANoB5pkNeQPg0Fmb4SJ0cmhABS9JLq8mtLH+jMihnLxp/r1atk2mpySl nmt8U1xDeUU2vHbO3KLUPGs0jrQY+/MAdyRYVCI= X-Google-Smtp-Source: AA0mqf460KZmOzPdB65VsL8WstVQNNL/kkGB4YpwZ1HtXGdIP15UNObEbaawGu1MRfPB5+lI836EXhqkCxAOgiIZPO8= X-Received: by 2002:a05:6402:229b:b0:457:d794:f5ee with SMTP id cw27-20020a056402229b00b00457d794f5eemr20852477edb.227.1668626134584; Wed, 16 Nov 2022 11:15:34 -0800 (PST) MIME-Version: 1.0 References: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> <20221114192011.1539233-2-marmarek@invisiblethingslab.com> In-Reply-To: <20221114192011.1539233-2-marmarek@invisiblethingslab.com> From: Jason Andryuk Date: Wed, 16 Nov 2022 14:15:22 -0500 Message-ID: Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Nov 14, 2022 at 2:21 PM Marek Marczykowski-G=C3=B3recki wrote: > > The /dev/mem is used for two purposes: > - reading PCI_MSIX_ENTRY_CTRL_MASKBIT > - reading Pending Bit Array (PBA) > > The first one was originally done because when Xen did not send all > vector ctrl writes to the device model, so QEMU might have outdated old > register value. This has been changed in Xen, so QEMU can now use its > cached value of the register instead. > > The Pending Bit Array (PBA) handling is for the case where it lives on > the same page as the MSI-X table itself. Xen has been extended to handle > this case too (as well as other registers that may live on those pages), > so QEMU handling is not necessary anymore. > > Removing /dev/mem access is useful to work within stubdomain, and > necessary when dom0 kernel runs in lockdown mode. > > Signed-off-by: Marek Marczykowski-G=C3=B3recki I put the Xen, QEMU, and xen-pciback patches into OpenXT and gave a little test. When pci_permissive=3D0, iwlwifi fails to load its firmware. With pci_permissive=3D1, it looks like MSI-X is enabled. (I previously included your libxl allow_interrupt_control patch - that seemed to get regular MSIs working prior to the MSI-X patches.) I also removed the OpenXT equivalent of 0005-Disable-MSI-X-caps.patch. I am testing with Linux 5.4.y, so that could be another factor. One strange thing is the lspci output. Dom0 shows MSI-X enabled. Meanwhile NDVM (sys-net) does not show the MSI-X capability. If you `hexdump -C /sys/bus/pci/devices/$dev/config` you can see MSI-X enabled, but you also see that the MSI capability has 00 as the next pointer, so lspci stops parsing. MSI cap stubdom: 00000040 10 00 92 00 c0 0e 00 00 10 0c 10 00 00 00 00 00 |..............= ..| 0x41 -> next 0x00 MSI cap dom0: 00000040 10 80 92 00 c0 0e 00 10 10 0c 10 00 00 00 00 00 |..............= ..| 0x41 -> next 0x80 MSI-X: 00000080 11 00 0f 80 00 20 00 00 00 30 00 00 00 00 00 00 AFAIU, the value 0x80 at offset 0x83 is MSI-X Enabled. I had a boot where assignment failed with the hypervisor printing: d12: assign (0000:00:14.3) failed (-16) Rebooting the laptop seemed to clear that. Regards, Jason From xen-devel-bounces@lists.xenproject.org Wed Nov 16 20:41:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 20:41:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444400.699565 (Exim 4.92) (envelope-from ) id 1ovPDi-0000ZQ-Jv; Wed, 16 Nov 2022 20:41:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444400.699565; Wed, 16 Nov 2022 20:41:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovPDi-0000ZJ-GP; Wed, 16 Nov 2022 20:41:18 +0000 Received: by outflank-mailman (input) for mailman id 444400; Wed, 16 Nov 2022 20:41:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovPDh-0000Z9-Ck; Wed, 16 Nov 2022 20:41:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovPDh-0005m3-9z; Wed, 16 Nov 2022 20:41:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovPDg-0008DR-PN; Wed, 16 Nov 2022 20:41:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovPDg-0007Qs-Os; Wed, 16 Nov 2022 20:41:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=R4C3RGi4u3WXMEFaBf2kxhbqeJoy7CBBQf0sAYPeQyU=; b=1dvyPAYQw5/uAqgixEDplJ6+XQ 1lDG9IQbPPN0bhqosmaqvPc84j+f0mMGHqtIqrLFL2OQrLPZsViZD0yWl1YeEEldqKh2P1WZwTB7k 5JbN4xUpqwJ5Jbz7IGd5HklzOhLLM4Dyc7DluuBvEz1BkSTTKaC7eEh04BWbukgD5lKc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174793: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f5d56f4b253072264efc0fece698a91779e362f5 X-Osstest-Versions-That: xen=764146ed8a7a44034c3efe658333993ca250d69a From: osstest service owner Date: Wed, 16 Nov 2022 20:41:16 +0000 flight 174793 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174793/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen f5d56f4b253072264efc0fece698a91779e362f5 baseline version: xen 764146ed8a7a44034c3efe658333993ca250d69a Last test of basis 174790 2022-11-16 13:02:02 Z 0 days Testing same since 174793 2022-11-16 18:03:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Andrew Cooper [Citrix relicensing] Anthony PERARD Grant Likely [Linaro relicensing] Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 764146ed8a..f5d56f4b25 f5d56f4b253072264efc0fece698a91779e362f5 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Nov 16 20:48:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 20:48:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444406.699576 (Exim 4.92) (envelope-from ) id 1ovPKn-0001D1-CB; Wed, 16 Nov 2022 20:48:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444406.699576; Wed, 16 Nov 2022 20:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovPKn-0001Cu-8D; Wed, 16 Nov 2022 20:48:37 +0000 Received: by outflank-mailman (input) for mailman id 444406; Wed, 16 Nov 2022 20:48:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovPKm-0001Ck-5O; Wed, 16 Nov 2022 20:48:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovPKm-0005sw-2o; Wed, 16 Nov 2022 20:48:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovPKl-00009N-Og; Wed, 16 Nov 2022 20:48:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovPKl-0008SX-OD; Wed, 16 Nov 2022 20:48:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iDvfFFzzlpO5aZJ6DzBQ7+Shmf4COyQV6i780xh8Nm0=; b=HSLVGABL03NrRAlpKB8mGOBYi9 kl+D2V9WY8X2tX6/9EPgUgx0nnAeLF7BBZP3m2aQW9Gv/OFuj5yCnNSSm6UQL6glp34rDNk47KGs0 cVSQK958FxwJQ2btVlYv5uQTt7hHywItWnUyII0dnecXvMN1dJA0I+RcWCMXJDwfUEJA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174789: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=59d0d52c30d4991ac4b329f049cc37118e00f5b0 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 16 Nov 2022 20:48:35 +0000 flight 174789 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174789/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 build-arm64-pvops 6 kernel-build fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 59d0d52c30d4991ac4b329f049cc37118e00f5b0 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 40 days Failing since 173470 2022-10-08 06:21:34 Z 39 days 66 attempts Testing same since 174783 2022-11-16 01:10:10 Z 0 days 2 attempts ------------------------------------------------------------ 1706 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 162594 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Nov 16 21:40:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 21:40:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444412.699587 (Exim 4.92) (envelope-from ) id 1ovQ8k-0008VH-1w; Wed, 16 Nov 2022 21:40:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444412.699587; Wed, 16 Nov 2022 21:40:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovQ8j-0008VA-VD; Wed, 16 Nov 2022 21:40:13 +0000 Received: by outflank-mailman (input) for mailman id 444412; Wed, 16 Nov 2022 21:40:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovQ8i-0008TX-F3 for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 21:40:12 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e1b3d5c-65f7-11ed-8fd2-01056ac49cbb; Wed, 16 Nov 2022 22:40:10 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DE3CD5C01F3; Wed, 16 Nov 2022 16:40:08 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 16 Nov 2022 16:40:08 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 16 Nov 2022 16:40:07 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e1b3d5c-65f7-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668634808; x= 1668721208; bh=79ymK68beQa1zK3znI/v+JsysT5CmM/aDYWh63Kes/Y=; b=k 4ti1iaeVYjYjuhHhZPofLTGWtawGjZuRyt7PNO4RR9xygMfmad9gvPj5SPMtxbaT JcB3GcfEWl5XTPiav65bg+qjCx5r6auFTfdDw5+uXhDOeTsvnTVwGKwU9q8AT1Ea XpNsPzD/zbhM3XYsgT046QwVNEdxewkMlEXhrq6s6sQB0NuEcU4ARXJhSILL6ztk eo74yOU3NYLPybAiJmq9LqA+xF5i8wQtH9lwYkb6yUYjjq+9v9KqEGIHMSRSLUxw zr07a9iYTdSVdfqwC0SyV9rke1ZilcMgtTXrs16+MmzUlEy75g8O0/a5Aw758c6L ZcM1nMUXwU+yW2GL68RPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668634808; x=1668721208; bh=79ymK68beQa1zK3znI/v+JsysT5C mM/aDYWh63Kes/Y=; b=X6rOSiE+RkQHmcK9nrlMTCoDlA0yXXFgVzw3CsfeMfk1 CMv+cioEgXjGTiq/gHKJn2H2Q4K/6Doxkb++G8JfdRUTWsMESQY0UpMZ+EeHwrSr DilplfZRAOIsXbwVLUN6Q9LfmQdJsMO0i5jUYeqSJiwPu35lZa9EkJ7dygMd8wqA o/wpIkTTJwEXR0QLFzuITr7iOxoN7Jy6smMSro5NrdmWMqw3or9F0Vl1BUQhzb70 cjYpgVuR78Rf0Vs+6jW4Ofg/R9mRoWjyQov4qzQrOXgE/hcYyuJzhoHPqZXCvOZW +3iP0IrOUZfIhghLRNms+Odlplpz9IAY0g9Hn1hDfw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgeeigdduhedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepueek teetgefggfekudehteegieeljeejieeihfejgeevhfetgffgteeuteetueetnecuffhomh grihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Wed, 16 Nov 2022 22:40:02 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jason Andryuk Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen Message-ID: References: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> <20221114192011.1539233-2-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pdecqJYtKVupcCRx" Content-Disposition: inline In-Reply-To: --pdecqJYtKVupcCRx Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 16 Nov 2022 22:40:02 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jason Andryuk Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen On Wed, Nov 16, 2022 at 02:15:22PM -0500, Jason Andryuk wrote: > On Mon, Nov 14, 2022 at 2:21 PM Marek Marczykowski-G=C3=B3recki > wrote: > > > > The /dev/mem is used for two purposes: > > - reading PCI_MSIX_ENTRY_CTRL_MASKBIT > > - reading Pending Bit Array (PBA) > > > > The first one was originally done because when Xen did not send all > > vector ctrl writes to the device model, so QEMU might have outdated old > > register value. This has been changed in Xen, so QEMU can now use its > > cached value of the register instead. > > > > The Pending Bit Array (PBA) handling is for the case where it lives on > > the same page as the MSI-X table itself. Xen has been extended to handle > > this case too (as well as other registers that may live on those pages), > > so QEMU handling is not necessary anymore. > > > > Removing /dev/mem access is useful to work within stubdomain, and > > necessary when dom0 kernel runs in lockdown mode. > > > > Signed-off-by: Marek Marczykowski-G=C3=B3recki >=20 > I put the Xen, QEMU, and xen-pciback patches into OpenXT and gave a > little test. When pci_permissive=3D0, iwlwifi fails to load its > firmware. With pci_permissive=3D1, it looks like MSI-X is enabled. (I > previously included your libxl allow_interrupt_control patch - that > seemed to get regular MSIs working prior to the MSI-X patches.) I > also removed the OpenXT equivalent of 0005-Disable-MSI-X-caps.patch. > I am testing with Linux 5.4.y, so that could be another factor. Can you confirm the allow_interrupt_control is set by libxl? Also, vanilla 5.4 doesn't have the allow_interrupt_control patch at all, and you may have an earlier version that had "allow_msi_enable" as the sysfs file name. > One strange thing is the lspci output. Dom0 shows MSI-X enabled. > Meanwhile NDVM (sys-net) does not show the MSI-X capability. If you > `hexdump -C /sys/bus/pci/devices/$dev/config` you can see MSI-X > enabled, but you also see that the MSI capability has 00 as the next > pointer, so lspci stops parsing. This 00 value is written by Linux[1] (sic!) and then qemu incorrectly allowing the write and happily emulating that zero. The other qemu patch in this series ought to fix that (as in: properly refuse the write), do you have it included? [1] https://github.com/torvalds/linux/blob/master/drivers/net/wireless/inte= l/iwlwifi/pcie/drv.c#L1721 > MSI cap stubdom: > 00000040 10 00 92 00 c0 0e 00 00 10 0c 10 00 00 00 00 00 |............= =2E...| > 0x41 -> next 0x00 > MSI cap dom0: > 00000040 10 80 92 00 c0 0e 00 10 10 0c 10 00 00 00 00 00 |............= =2E...| > 0x41 -> next 0x80 >=20 > MSI-X: > 00000080 11 00 0f 80 00 20 00 00 00 30 00 00 00 00 00 00 >=20 > AFAIU, the value 0x80 at offset 0x83 is MSI-X Enabled. >=20 > I had a boot where assignment failed with the hypervisor printing: > d12: assign (0000:00:14.3) failed (-16) > Rebooting the laptop seemed to clear that. Zombie of previous domain? Not set as "assignable" first? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --pdecqJYtKVupcCRx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN1WLIACgkQ24/THMrX 1yxXpQf/Tpxw6IVza7ILJAFIjQbfpFFDHNbiSAVS03xF88K3crKqKmPaJ+fKvBSZ ntFetwY/Paz4/V3dFWv7ly5f6K3E1K4B0kYlBoYBCmZwv5NW8G+CYfOigr2J9mQn 9nYW0Dsn0UXVZklEUey6J/UA7C7byU6lKuVSseXfj8BpkH8+9fZMPKvokLEiszol NLBpy2k11M7JFdlILZ4JhcTdZPhnN6Etr41jjud1hg2boPxfIdwH3FtAx33fkda5 3Y/BTMd8m4nigEiLBDwFIjJnuPwrF5ST2dGU2qWZEN8hen6QJ+2NGgRCMSk4ZVmW VT+8gJzGM2n5XXi7T1oVqvGoXysnVw== =cMsU -----END PGP SIGNATURE----- --pdecqJYtKVupcCRx-- From xen-devel-bounces@lists.xenproject.org Wed Nov 16 23:42:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 23:42:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444418.699598 (Exim 4.92) (envelope-from ) id 1ovS2R-0006l8-TV; Wed, 16 Nov 2022 23:41:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444418.699598; Wed, 16 Nov 2022 23:41:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovS2R-0006l1-QS; Wed, 16 Nov 2022 23:41:51 +0000 Received: by outflank-mailman (input) for mailman id 444418; Wed, 16 Nov 2022 23:41:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovS2Q-0006kr-7A for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 23:41:50 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3a94d2c3-6608-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 00:41:46 +0100 (CET) Received: from mail-dm6nam11lp2174.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Nov 2022 18:41:40 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6133.namprd03.prod.outlook.com (2603:10b6:208:308::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 23:41:38 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%5]) with mapi id 15.20.5813.019; Wed, 16 Nov 2022 23:41:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a94d2c3-6608-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668642106; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=5L0eP4LUzgRdHGLpOYPVmIL/y/XtitB74DVmbauyVJY=; b=DIpAY/OBv6ZNQUndnrXWJ2HLQLcvASJN+udxWvAI9aRSmUy8Y+EwbTuC 6zWPUFKLsBGZzbDle46pm7oOofidXW5kGfpWbL7j6TQ8ytmF3WZkFb4Od 0vih29Lm99iJHhTjzwJmL0X6Y9oe19ZTEcbr2LN0eYQz1eWAL0KQ7Mrqx c=; X-IronPort-RemoteIP: 104.47.57.174 X-IronPort-MID: 84049320 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:WKSknakY1tJpzwsquXvB+4Ho5gwvJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIXUWqAbq2Ca2GjL4t3YYnk8B4CuMDQnYJkGgM/qSpkESMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5QGGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 foHCyIOfx6Tvbrs346hadBpm8QcPfC+aevzulk4pd3YJdAPZMmaBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVM3ieexWDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapCSOXkp6Uw2DV/wEQ/NS0SBGWDhMWhoXThUNZhd G4ZyzUh+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6CHXQNRDNFbN0gtec1SCYs2 1vPmMnmbRR/vbvQRX+D+7O8qTKpJTNTPWIEfTUDTwYO/5/kuo5bpgnCRct5EbKkps34H3f32 T/ihDc6r6Uei4gMzarT1VLahzOhoLDZQwhz4R/YNkqb6Qd+aJ+gdpafw1HR5vZdL66UVlCE+ nMDnqC25u0UEYuEkiDLRewXBayo/N6MKjiaillqd7EB+jK36jicdIZfyDhkIQFiNcNsRNPyS ErauAcU6JoNOnKvNPZze9joVJhsyrX8H9P4UPySdsBJfpV6aA6A+mdpeFKU2Gfu1kMrlMnTJ KumTCplNl5CYYwP8dZ8b751PWMDrszm+V7ueA== IronPort-HdrOrdr: A9a23:x5toxqtaWqNsNufEo2AeSDTN7skCXoAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeF+aP3CB+R2zYZSndqza05+W bIvgTl7uH72svLiyP05iv21dB7idHhwtxMCIiljdUUECzljkKFdZlsQLqLuREyuaWK5EwxmN fBjh88N4BY6m/XfEuyvRzxsjOQngoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L gj5RPbi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZDIMu60vFjLA BdNrCa2B9kSyLdU5kfhBg3/DWYZAV2Iv5BeDlbhiXa6UkMoJkz9Tpk+CVWpAZ9yHt6cegF2w 2MCNUXqFkFJPVmEp5VFaMPR9C6BXfKRg+JOGWOIU7/HKVCIH7VrYXriY9Frd1CVaZ4u6faoq 6xJm9wpCo3YQbjGMeO1JpE/lTER3i8Ry3kzoVb64JisrPxSbL3OWnbIWpe2PeIsrEaGInWSv yzMJVZD7vqKnbvA59A20n7V4NJIXcTXcUJspIwWk6IoMjMNor239arOMr7Nf7oC3IpS2n/Cn wMUHz6I9hB9FmiXjvijB3YSxrWCzjCFFJLYd3nFsQoufsw39d3w3koYHyCl7G2ACwHtLAqd0 1jJ76imr+npACNjBT101k= X-IronPort-AV: E=Sophos;i="5.96,169,1665460800"; d="scan'208";a="84049320" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ggy0hrotj9r1ugSuoC7iOsrrekO7zEb3l4dHVO1iDFNj2wnCt+XhazkOuarNatMgIOQJOA9fPkeQBb2SvM981q6BpvOWJ6ofKli2b9kzl9P+jhrbcMOazf3y/xw2WCV48UA30ZUHX6OKyLAiqp1PSkzHTeIb6OPPLyjJwkIv8LMgScd/Xfm1fqYI9eazoaOiN5QTqtJDQpty/FK8Z5Gv+EOigu3ccBrspxLyq5EGo9u1wr8WmCe6vjh/zXuRCb2J8OZn5wozrygVEm6d9aIzP0lOFLBP5aUZl6dSXyNmCfLA7kNiVQsrj6ngz4F8hN8F/qP7OxVY38w3jQshl2g8EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5L0eP4LUzgRdHGLpOYPVmIL/y/XtitB74DVmbauyVJY=; b=JQ4I2pDVdjs4NrKkV++RsYXGYEYItpmZvnaiYyBYtAmpNf3EZ1YYTwSKEFVORrkVkGiwmTynyyv2+QGgDRiWuwUcchJvIeVYS7BngJ75lBHXcCYL0NSfdfdFfGwtyOeFHZMxl9wPK/uuKUhX0d8qY+0N7sBaKYub1H4KR+9n+I7GZQBau3N/PAzbx5/QNoY7TiUUA3vAJR6iapav8wtJXoJXFcSZThMo+T8Nee5lTpDP+i8k1P1IbZzvBQHBQsiYOah7PY2d/duaPyeXpGbA/UoH5EIzR3qEc4iCIIJAoZQTSIh5aopYCOeuIwXMB6w4J4QKphHOBDp9BR2nl6M0YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5L0eP4LUzgRdHGLpOYPVmIL/y/XtitB74DVmbauyVJY=; b=NM2lL3wBCit6AjyTqirVmJuGm66M5Tl9l98N3mT5/AVZG0bkrKmTl61Zj/XPPax8l8zImIN8fPt93PsEydK8CX2s5RMye2KXjgRzax+qGEDBGA4FffZWklApu0i4zE4Pz/0RwEVLHSwIuCns9aomXGQ7etEgs+K9L8iW5p1RG2Y= From: Andrew Cooper To: Jan Beulich , Stefano Stabellini CC: Xen-devel , Xen Security Team , Roger Pau Monne , Wei Liu , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony Perard Subject: Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls Thread-Topic: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls Thread-Index: AQHY6SSlXP4isouqyE+BbtcNRl5Xnq5A5cGAgAAC9ICAAANygIAAbOuAgAD+lIA= Date: Wed, 16 Nov 2022 23:41:37 +0000 Message-ID: <269f4e70-07c2-5cf6-f42e-6f98e2ce70dd@citrix.com> References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-4-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BL1PR03MB6133:EE_ x-ms-office365-filtering-correlation-id: 48978556-f8d3-4767-54d4-08dac82c1ad2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OZGQY1rIaEcNVk2KPnjW+vgoSXu6yLLnamVolq15mPRoca9hvqYE+KP7OVcwL5sW5kIrTmgvvtAIutL2OrH8rSBnx3jST6sn5LmyoqFoTA1sDmexN23SxAh40XgCntdaC2CO5orySiw2lsNoV0tIRx/kz45UDzW1tcMMZ7Uv+XHA6NOt2bRjpzWmMpsZt9eUrVNEmCn2Ckw/OoenMxBt12YXOHgJwpHOY4vki24hhTDD3itzG41up6i66jM9kBIA2q8h+SpDlAtlleKSaGa/tzbEVeJMnJlBcrL/c6yFAjpp3Mbh771QlucSTA0DZXqgXEXkuy1hiAmnLC2Lob0gDd3EpUGlTScFDcur/4HVoeDm1Mu0wLRfRu2Uz9Ntpl0JYD+I1f8k/lZFqJ/hKRCoE9hMNCPLmqYxWbkjzlVEP+fYXEgvoWBuSPzHxVIgw14QY5G4TIpcCh1M2oSQBRR5MGZJRCCMqIOh8zNpbOrmD8ZoJjmuw+02q95TUE9tGhVfkpq0mvHFgVRQ1tboy8lW5uG/RMxFsEjBISHBYWj8yIwq127s+4h5QTh7qN4F2x4QAL8TypeY77LERHQXNWQzw6qXUaV0VSyG7lG9cnPdJA40ngaqH/NL1oEv4UqlgRkIosb01zpPJ80smsIUVu7lsGa3USHWdAt05x3vH1MWOwks/UoL6Q/kk1kXvrL2upmYDdruBqhNXinnD3zAjllVlAa6qTBj5osJDUnWstc02pL/YNyXFGgotwIbaX6PoGN3ey0oyHn4NuZxbC3PHCSUd++nAKtQSOrgfrck/6YvP3ysPbtcvdAB5FX9fAWhdWuA33LB2M28+EDhuQVWhypyIA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(366004)(376002)(451199015)(36756003)(76116006)(66556008)(66446008)(26005)(64756008)(66476007)(91956017)(66946007)(8676002)(6512007)(4326008)(316002)(54906003)(6506007)(110136005)(5660300002)(41300700001)(186003)(2906002)(8936002)(53546011)(86362001)(31696002)(2616005)(83380400001)(6486002)(71200400001)(31686004)(82960400001)(66899015)(38100700002)(38070700005)(107886003)(478600001)(122000001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NDA0OGlxMHBSdHpnK0d5WTNKTWRwbmRCUnVyUm1Oa0s4QUNnK3ZSMWYweCtr?= =?utf-8?B?RWowcExUVVZ6NWVVV1ArR0VldXJVdDhIMC9ZbC8vNm5ERFYrVTF5dDFSdlJH?= =?utf-8?B?b0YxcXkreThaaUJsZnVEbFJrRTV1aElpVDYwTlh5T3RudUlESExjbmRtcUJQ?= =?utf-8?B?TkQ1ZGxRR3puNGVQTEN1ZldySC92c0ZaTzFOc3YxL3NQNmlPcVdZbUNXTkxv?= =?utf-8?B?T1RNZGJoZFg0Z2JtcU13clpPVlY3Z3VsSDNqWW5lN2RvUC84cFI5R3V5Vkda?= =?utf-8?B?NDhML1FOZGVLYTJYK2N3OVV2Tm1rcDdTMW9CVG9sRzEySG1oc2ZZRHh4M2pu?= =?utf-8?B?Rkd1YmtJQ2Rpb0ZrNE84RmFnejkxU3Zkc0hxaXNHTVlIYVpqYkFvQU4xQXZi?= =?utf-8?B?WUlWVnNrd3RrTU1oNzJZcU4zWGZ6dHN4U2N5RGxxQzNleUpqcFlPVkgvbGxm?= =?utf-8?B?Yjd3L1hiNHp4ZFhyK09KS3luYWdPWDJWQW5NNVZGNUJkM2tFYXl5cHlJNGMv?= =?utf-8?B?SldObFEvNENGMUtFdlRwSVdWVkRHN1Q3cnVJYzc3SlRUZXlMME5aamdUSzZl?= =?utf-8?B?cmo4M0lPT1VmcHBrSE5Pa25WUVQ3bnNFK3dqSUszVlloMURFV1FrODNYSFpP?= =?utf-8?B?RHQ4ai9hV1lGVzZVS1dmQzFtQW1EYTFlNitlQzRFZlRUTlJ3RDhMSTFSMVlF?= =?utf-8?B?TnU5VDJQenhEdDdYU3M2TTVDSlJNcmNtbUNNRzZvby9tdW8waHB5Qm1ndkpE?= =?utf-8?B?WEdLUEZ3OWlQdG9EcmRFTXFiMS9rNWNuWDZiL2ZzVmRIVGdleFpjVUxTLzlZ?= =?utf-8?B?TmZBOEFIVzB6azFMci9JNkpMK29oUnhPTU11THh0cWY2dFEwZGJLRGVMTk1y?= =?utf-8?B?TXhXZ0lJY2N3RWk2Z2doS2NhUUpsUFZBemZ0WUxZMFV6c2FqOTN6bW1ESXVn?= =?utf-8?B?ZGl2UXV1OXdiNnFydjhTMzdoNVhDQ3J1NUF1VmQ1QkNCOEVPOEJpcEo4WTJ2?= =?utf-8?B?MVdZQ0FhdVpkSUw3RTZEY3l5YmlUQ0oxMzhoMnlUeURieUc1V0xHZzZyelNk?= =?utf-8?B?cTRPNDh1dmhIL1UxVkpzUVJuR3RibE1kV002SEttc01TZVdySXRnblYxY1dO?= =?utf-8?B?U2NrWm5RczZYZWhQS2FkQnB1aFdIcGZmKzBWZVgweHpOVHNzU3R4ekVMOTZw?= =?utf-8?B?dXFYNWNiTWxzRms0OE1lV3VtckRFeXF2bDg0aU5veGhUTzVWWkxER3U3dVRB?= =?utf-8?B?a0tUN1pIRWNzOUoyQXFEQXJTQ1pqTFI4dWVtUE5uUFNUZ0ZGOUF3MUdpM01E?= =?utf-8?B?WmkzNXJOdTI5VEU1YVpxZmdid29jMlpBTkRxWENuQlJ0V2FtUFEwTkdONWFL?= =?utf-8?B?OUtWbnZFUDAzL2wxVG5ybDIvR2VRRHBsTmh5akJobFZ3Y1A0cXJjelUvait2?= =?utf-8?B?UHdhcjQ2TEVITEJsMTR2RkthNWFyZ25WODFPeXpqV2luUDZLd1ZRWFBFUC82?= =?utf-8?B?TnF0UW4zUDhnSGZBeWpZdHIrUHJ4MVlTdU53VDhpck5hVkVKbU1xUzFNaXhs?= =?utf-8?B?ZExHRnI2TTVnY0NndFFjaUsvQ1JRMUFIUlRydnk1bi9XREhOb2gwcEFOVWtM?= =?utf-8?B?eWRzZk0rMThjTWdXdWJ3a2YvYXRwODBaajhtR2l6SUJTaFNNSzJQbjFIZDBW?= =?utf-8?B?UVVZSGFJUkYvZWNveVhvMm5uY29saXRmZGFTTGUvVUNKQTczc2ZadFFxWldj?= =?utf-8?B?dFJBeHdxV3M5S29MMVJVQThPZlhpeS9LQXhHcXh5RmhmcXN4Q2FoZE81d3dq?= =?utf-8?B?WG9ZS0pLb1JTNEljN1FLdDZTd0RqRGIxanFIMUtweGt5THI3ZjkrYk5xZGJw?= =?utf-8?B?YzY1VzlzSmRHNDJMc0s0TG1tOC9QNXBYaXZPN3VaZDZ1UzFrT2ttZkpuVEFa?= =?utf-8?B?cms5b1I5bkhXZFRGdHNaOWVPTmhjeXlJZmx3MkdicUdWUm05dW8vNGhQcEFq?= =?utf-8?B?YnNmV0RyODM0N1preTRKVDdhb1cxaWpsSkxKQlRCUjFYR25RUVlZMzhPSXhl?= =?utf-8?B?RHp1M1ZSVHJrZDB3WENuLzJxUElmNkdHYTExOWpFY1ozaXJkSnBNWkY3OVlF?= =?utf-8?B?dFlsM3lHekNHUmhreEZiUmxsaGZ0cStDbE95T2F6eVVUUjhQQytUSmkvMUZG?= =?utf-8?B?eFE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <15D60AB6EE7C444C98D401B6C4C905FF@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?bFNrenZvNU5peHlaY3dGUFRVK0FXMDh3cWJmRWFuMERZMGJIczdkY2FWdW04?= =?utf-8?B?bzFkdThWMkM1SmtzdzcvTm5JU1ZuQnJDV29PR3o5cnB0VVlWR0JEQy9NWVpE?= =?utf-8?B?UG11RnphVk8vYmp5VFlRV1pzYlNzVnhwdFhrcVFMb3AyQ05PWlRONDBRalc3?= =?utf-8?B?UW1hM2dIUlpVSno5NGFxakZIa09Pa0kxYU9xc1RTL1NwendDdjVBTW5vZkhO?= =?utf-8?B?ZGpHRWRwd2VrY2tYR25yYUIyMHQ4eUNsTjZmWFNFVjJZN2ZGdm5OYm1wb0dz?= =?utf-8?B?aEtBQVRyd3hxSDFVYmFVeWdhMjM0elFmVTJzVHJwTkpndE9CRG5VNEVPUTNM?= =?utf-8?B?eG54NDJjazRxWnl3MXpDTFBrOFdtb0lrSHhmUjRYZ1VlNzJOTVNIbUVIV1Uv?= =?utf-8?B?ZFNyTHFiWHMxWCtWcC9ucUg4NFlGMlR0d3ZpVUFXQkRSQXMwQjg1aVFPYlpK?= =?utf-8?B?eGI0dFBsRTZpL3VLTVBoZnJCWGxMVmUzSVhTL0Mra2pBSWQwTGZ2eEdHOFpN?= =?utf-8?B?R3V1STZaQVlxOGhwUFE3c29JZWRWY3VUbFdlMnlmMUpwYVA0bTVJb0IvTFdC?= =?utf-8?B?KzZWaUFYU3R6aVBuZzY5Z1E1VWR3SnpxQXdENVlyS2lQTldVYXJscEhvVE9a?= =?utf-8?B?Vnp4ZXd4Sld3SldQUHFvNC9sM2c5ckk3UHFQU1ZvQ0l6b1NoVy82bkJjUFE3?= =?utf-8?B?VkxHKy9aNWFvblRwMWRjdGVSeXNtbXVQZ2NITG5hV0VNaFBjQTZzRjZIaWp3?= =?utf-8?B?VzlJTTRKOWZ2LzlNOHRhQnNWZVpDL1FUOVZJY1pOamN3dGtKalpySUVYQ3V0?= =?utf-8?B?cHJ3ZlJ3NEp5WU9FNFk2UW50cU44a1liY2hzUmN1VVdIcjIrTGNCdFJpb1dh?= =?utf-8?B?S2QyUmNibFJVQkVySWNwT3hCNWM1WmJLY0VWM0FuM3o0WStUa1lycXRocnI0?= =?utf-8?B?cFlxazViaDFqMEpDbjlsWEs5RTNsYkpCMXRHRVNUaG5DRmxtZTR5VENuT2FC?= =?utf-8?B?QWd0aWtaNTlvWFBWOWpMOFJQL291VGNIRnpRcGxnOVl4b0lLcGxsT2Y4YU1J?= =?utf-8?B?c1dPTTVtSFRFeXZwYmp6a3F4Mno0bEtieFJ6ZFd4T0NVWlNsYUMvcjR5T25K?= =?utf-8?B?R3BORUIrYVg5dVVtVTFPWlZ0dUYxaDhROERYdEVDY0swelNIZlVQUzErOUJV?= =?utf-8?B?OE1EUi9GTjNXeGl4anRHTTBybTgxK1crT3NudUFiQXhIK0YxdVFKM2ZMSlBZ?= =?utf-8?B?Zzl5bFFuRHFhZ29qQ3MvSzhVT3BidW1zN0NaSUpPZCt2bllQUT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48978556-f8d3-4767-54d4-08dac82c1ad2 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 23:41:37.9829 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vHYiPllO3mGYCRZRQLbnhuS5sXQ4YasbNyoSj5qT29cO6EcwMTnQh6PgRwiQyEMWeziGfFp3IVkhF3wXGapnUNmD/JepfhZIKoCQx119rcg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6133 T24gMTYvMTEvMjAyMiAwODozMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE2LjExLjIwMjIg MDM6MDAsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4+IE9uIFdlZCwgMTYgTm92IDIwMjIs IEFuZHJldyBDb29wZXIgd3JvdGU6DQo+Pj4gT24gMTYvMTEvMjAyMiAwMTozNywgU3RlZmFubyBT dGFiZWxsaW5pIHdyb3RlOg0KPj4+PiBPbiBXZWQsIDI2IE9jdCAyMDIyLCBBbmRyZXcgQ29vcGVy IHdyb3RlOg0KPj4+Pj4gVGhpcyByZXZlcnRzIG1vc3Qgb2YgY29tbWl0IGNmMmE2OGQyZmZiYzNj ZTk1ZTAxNDQ5ZDQ2MTgwYmRkYjEwZDI0YTAsIGFuZCBiaXRzDQo+Pj4+PiBvZiBjYmVhNWExMTQ5 Y2E3ZmQ0YjdjZGJmYTNlYzJlNGYxMDliNjAxZmY3Lg0KPj4+Pj4NCj4+Pj4+IEZpcnN0IG9mIGFs bCwgd2l0aCBBUk0gYm9ycm93aW5nIHg4NidzIGltcGxlbWVudGF0aW9uLCB0aGUgbG9naWMgdG8g c2V0IHRoZQ0KPj4+Pj4gcG9vbCBzaXplIHNob3VsZCBoYXZlIGJlZW4gY29tbW9uLCBub3QgZHVw bGljYXRlZC4gIEludHJvZHVjZQ0KPj4+Pj4gbGlieGxfX2RvbWFpbl9zZXRfcDJtX3Bvb2xfc2l6 ZSgpIGFzIGEgc2hhcmVkIGltcGxlbWVudGF0aW9uLCBhbmQgdXNlIGl0IGZyb20NCj4+Pj4+IHRo ZSBBUk0gYW5kIHg4NiBwYXRocy4gIEl0IGlzIGxlZnQgYXMgYW4gZXhlcmNpc2UgdG8gdGhlIHJl YWRlciB0byBqdWRnZSBob3cNCj4+Pj4+IGxpYnhsL3hsIGNhbiByZWFzb25hYmx5IGZ1bmN0aW9u IHdpdGhvdXQgdGhlIGFiaWxpdHkgdG8gcXVlcnkgdGhlIHBvb2wgc2l6ZS4uLg0KPj4+Pj4NCj4+ Pj4+IFJlbW92ZSBBUk0ncyBwMm1fZG9tY3RsKCkgaW5mcmFzdHJ1Y3R1cmUgbm93IHRoZSBmdW5j dGlvYW5saXR5IGhhcyBiZWVuDQo+Pj4+PiByZXBsYWNlZCB3aXRoIGEgd29ya2luZyBhbmQgdW5p dCB0ZXN0ZWQgaW50ZXJmYWNlLg0KPj4+Pj4NCj4+Pj4+IFRoaXMgaXMgcGFydCBvZiBYU0EtNDA5 IC8gQ1ZFLTIwMjItMzM3NDcuDQo+Pj4+IEdlbnVpbmUgcXVlc3Rpb246IEkgY2FuIHNlZSB0aGlz IHBhdGNoIHJlbW92ZXMgdGhlIGltcGxlbWVudGF0aW9uIG9mDQo+Pj4+IFhFTl9ET01DVExfU0hB RE9XX09QX1NFVF9BTExPQ0FUSU9OIG9uIEFSTS4gSXQgYWxzbyBzd2l0Y2hlcyBsaWJ4bCAoYm90 aA0KPj4+PiBBUk0gYW5kIHg4NikgdG8gdGhlIG5ldyBoeXBlcmNhbGwuDQo+Pj4+DQo+Pj4+IFdo eSBrZWVwIHRoZSBvbGQgaHlwZXJjYWxsIChYRU5fRE9NQ1RMX3NoYWRvd19vcCBhbmQNCj4+Pj4g WEVOX0RPTUNUTF9TSEFET1dfT1BfU0VUX0FMTE9DQVRJT04pIGltcGxlbWVudGF0aW9uIG9uIHg4 NiAobm90IG9uIEFSTSk/DQo+Pj4+DQo+Pj4+IElzIHRoYXQgYmVjYXVzZSBpdCB3YXMgb25seSBy ZWNlbnRseSBpbXBsZW1lbnRlZD8gQW5kIG5vdCBhY3R1YWxseQ0KPj4+PiBwcmVzZW50IGluIGFu eSBwYXN0IFhlbiByZWxlYXNlPw0KPj4+Pg0KPj4+PiBJZiBzbywgcGxlYXNlIGFkZCBhIG5vdGUg YWJvdXQgdGhpcyBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuIEFsc28sIGlmIHRoYXQNCj4+Pj4gaXMg dGhlIGNhc2UsIEkgdGhpbmsgdGhpcyBwYXRjaCBzZXJpZXMgc2hvdWxkIGdvIGluIDQuMTcuIElm IGl0IGlzIHRvbw0KPj4+PiBsYXRlIHRvIGdldCBpdCBpbiBiZWZvcmUgdGhlIHJlbGVhc2UsIHRo ZW4gd2Ugc2hvdWxkIGJhY2twb3J0IGl0IHRvIDQuMTcNCj4+Pj4gYXMgc29vbiBhcyBwb3NzaWJs ZS4gVGhhdCdzIGJlY2F1c2UgaWRlYWxseSB3ZSB3YW50IHRvIGtlZXAgdGhlDQo+Pj4+IGh5cGVy Y2FsbCBpbnRlcmZhY2UgY2hhbmdlcyBkb3duIHRvIGEgbWluaW11bS4NCj4+PiBPbiBBUk0sIHRo ZSBoeXBlcmNhbGwgaGFzIGV4aXN0ZWQgZm9yIGEgbGl0dGxlIG92ZXIgNCB3ZWVrcywgYW5kIGlz bid0DQo+Pj4gaW4gYW55IHJlbGVhc2VkIHZlcnNpb24gb2YgWGVuICh5ZXQpLg0KPj4+DQo+Pj4g T24geDg2LCB0aGUgaHlwZXJjYWxsIGhhcyBleGlzdGVkIGZvciBtb3JlIHRoYW4gYSBkZWNhZGUs IGFuZCBoYXMga25vd24NCj4+PiBvdXQtb2YtdHJlZSB1c2Vycy7CoCBJdCBuZWVkcyB0byBiZSBk ZXByZWNhdGVkIHByb3Blcmx5LCB3aGljaCBpbiB0aGlzDQo+Pj4gY2FzZSBtZWFucyAicGhhc2Vk IG91dCBpbiB0aGUgNC4xOCBjeWNsZSBvbmNlIGtub3duIGNhbGxlcnMgaGF2ZSBiZWVuDQo+Pj4g YWRhcHRlZCB0byB0aGUgbmV3IGh5cGVyY2FsbCIuDQo+PiBVbmRlcnN0b29uLiBUaGVuIEkgYW0g aW4gZmF2b3Igb2YgZ2V0dGluZyBhbGwgNCBwYXRjaGVzIGluIDQuMTcsIGVpdGhlcg0KPj4gYmVm b3JlIHRoZSByZWxlYXNlIG9yIHZpYSBiYWNrcG9ydHMuDQo+IFJlbW92aW5nIHNvbWV0aGluZyBm cm9tIHRoZSBkb21jdGwgaW50ZXJmYWNlIGdlbmVyYWxseSByZXF1aXJlcyBidW1waW5nDQo+IHRo ZSBpbnRlcmZhY2UgdmVyc2lvbiwgc28gc29tZSBleHRyYSBjYXJlIG1heSBuZWVkIGFwcGx5aW5n IGlmIHN1Y2ggYW4NCj4gaW50ZXJmYWNlIGNoYW5nZSB3YXMgdG8gYmUgYmFja3BvcnRlZCB0byBh bnkgc3RhYmxlIGJyYW5jaC4NCg0KVG8gYmUgY2xlYXIsIEkgaGF2ZSBubyBwbGFucyB0byByZW1v dmUgdGhlIHg4NiAib2xkZXIiIGludGVyZmFjZSBpbiB0aGlzDQpwYXRjaCBzZXJpZXMuwqAgSXQg d2lsbCBkZWZpbml0ZWx5IGJyZWFrIG91dCBvZiB0cmVlIHVzZXJzLg0KDQpJbiB0aGUgNC4xOCB0 aW1lZnJhbWUsIHdlIGNhbiBzZWUgYWJvdXQgcmV0aXJpbmcgdGhlIG9sZGVyIGh5cGVyY2FsbHMs DQpidXQgYXMgYSBub24tYmFja3BvcnRhYmxlIGNoYW5nZS4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Nov 16 23:45:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 23:45:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444421.699609 (Exim 4.92) (envelope-from ) id 1ovS5U-0007Kz-Cy; Wed, 16 Nov 2022 23:45:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444421.699609; Wed, 16 Nov 2022 23:45:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovS5U-0007Ks-9f; Wed, 16 Nov 2022 23:45:00 +0000 Received: by outflank-mailman (input) for mailman id 444421; Wed, 16 Nov 2022 23:44:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovS5T-0007Kk-QP for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 23:44:59 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae0851cf-6608-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 00:44:58 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CEF98B81EB5; Wed, 16 Nov 2022 23:44:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BF7FC433D6; Wed, 16 Nov 2022 23:44:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae0851cf-6608-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668642296; bh=N6ORxvoqpLlPF+vi1Z30o+QmC7ixZSazQMJBh9/x+RM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tdhsGzCqvin69+gC0BzHQkRCjEKD8dqf+456/1XtaksymzZjq1PryWWAc6J7xBpVY zIU2gWzo4PkKqzL4yjsJsLm5UHXKBg7D4nbjpEFbDGzda69KcGTqmAB1LC6I7Zqdp8 EZcW7tf6C2kLKTEc/v2n6Ya67ThvzhkGoEFhlSR5WXR4B1o9cAxTkJpnnter9ku7ze mFPswup6w01I5JiqLa4qzyCBkhGBkGbTVa1o7tKx8m0tKBM4po9HcXvefmRtOkB/87 xUsDN1DId8dRQ1CLvNb5RO2vEoB1bnUE82aK2qPmtMNmWGHXb4vtfbLZFeC4SHmkFf IIx3DLs31BwgQ== Date: Wed, 16 Nov 2022 15:44:53 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Jan Beulich , Stefano Stabellini , Xen-devel , Xen Security Team , Roger Pau Monne , Wei Liu , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony Perard Subject: Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls In-Reply-To: <269f4e70-07c2-5cf6-f42e-6f98e2ce70dd@citrix.com> Message-ID: References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-4-andrew.cooper3@citrix.com> <269f4e70-07c2-5cf6-f42e-6f98e2ce70dd@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1495097037-1668642218=:4020" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1495097037-1668642218=:4020 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Wed, 16 Nov 2022, Andrew Cooper wrote: > On 16/11/2022 08:30, Jan Beulich wrote: > > On 16.11.2022 03:00, Stefano Stabellini wrote: > >> On Wed, 16 Nov 2022, Andrew Cooper wrote: > >>> On 16/11/2022 01:37, Stefano Stabellini wrote: > >>>> On Wed, 26 Oct 2022, Andrew Cooper wrote: > >>>>> This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits > >>>>> of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. > >>>>> > >>>>> First of all, with ARM borrowing x86's implementation, the logic to set the > >>>>> pool size should have been common, not duplicated. Introduce > >>>>> libxl__domain_set_p2m_pool_size() as a shared implementation, and use it from > >>>>> the ARM and x86 paths. It is left as an exercise to the reader to judge how > >>>>> libxl/xl can reasonably function without the ability to query the pool size... > >>>>> > >>>>> Remove ARM's p2m_domctl() infrastructure now the functioanlity has been > >>>>> replaced with a working and unit tested interface. > >>>>> > >>>>> This is part of XSA-409 / CVE-2022-33747. > >>>> Genuine question: I can see this patch removes the implementation of > >>>> XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION on ARM. It also switches libxl (both > >>>> ARM and x86) to the new hypercall. > >>>> > >>>> Why keep the old hypercall (XEN_DOMCTL_shadow_op and > >>>> XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION) implementation on x86 (not on ARM)? > >>>> > >>>> Is that because it was only recently implemented? And not actually > >>>> present in any past Xen release? > >>>> > >>>> If so, please add a note about this in the commit message. Also, if that > >>>> is the case, I think this patch series should go in 4.17. If it is too > >>>> late to get it in before the release, then we should backport it to 4.17 > >>>> as soon as possible. That's because ideally we want to keep the > >>>> hypercall interface changes down to a minimum. > >>> On ARM, the hypercall has existed for a little over 4 weeks, and isn't > >>> in any released version of Xen (yet). > >>> > >>> On x86, the hypercall has existed for more than a decade, and has known > >>> out-of-tree users.  It needs to be deprecated properly, which in this > >>> case means "phased out in the 4.18 cycle once known callers have been > >>> adapted to the new hypercall". > >> Understoon. Then I am in favor of getting all 4 patches in 4.17, either > >> before the release or via backports. > > Removing something from the domctl interface generally requires bumping > > the interface version, so some extra care may need applying if such an > > interface change was to be backported to any stable branch. > > To be clear, I have no plans to remove the x86 "older" interface in this > patch series.  It will definitely break out of tree users. > > In the 4.18 timeframe, we can see about retiring the older hypercalls, > but as a non-backportable change. For ARM, given that XEN_DOMCTL_shadow_op has not been enabled for long, maybe we can get away without bumping the interface version? --8323329-1495097037-1668642218=:4020-- From xen-devel-bounces@lists.xenproject.org Wed Nov 16 23:52:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 23:52:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444426.699620 (Exim 4.92) (envelope-from ) id 1ovSCF-0000f0-2X; Wed, 16 Nov 2022 23:51:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444426.699620; Wed, 16 Nov 2022 23:51:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovSCE-0000et-W9; Wed, 16 Nov 2022 23:51:58 +0000 Received: by outflank-mailman (input) for mailman id 444426; Wed, 16 Nov 2022 23:51:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovSCE-0000en-6b for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 23:51:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovSC4-0001n3-1n; Wed, 16 Nov 2022 23:51:48 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ovSC3-0002nk-RU; Wed, 16 Nov 2022 23:51:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Vck3wzYrPUmcOloZJeqWop495rMArVD8XXqEHlY6zGM=; b=kQLO0M/EvutGbgwPeot677xb/M roE+ZwNNdMtWD2a/RWgKFuoAYf2Ro0+UVdnT5oCXszPwsQ/lGcuY/0YY6ZjUx0maHtkaivtMYFSeu OO+7PzhYOt6jFuegYx7AVpoFs/27Bn0f0KhRkpPn5lcAE13C/uFeQ7emRSmyqejaMUEA=; Message-ID: Date: Wed, 16 Nov 2022 23:51:44 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls To: Stefano Stabellini , Andrew Cooper Cc: Jan Beulich , Xen-devel , Xen Security Team , Roger Pau Monne , Wei Liu , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony Perard References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-4-andrew.cooper3@citrix.com> <269f4e70-07c2-5cf6-f42e-6f98e2ce70dd@citrix.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 16/11/2022 23:44, Stefano Stabellini wrote: > On Wed, 16 Nov 2022, Andrew Cooper wrote: >> On 16/11/2022 08:30, Jan Beulich wrote: >>> On 16.11.2022 03:00, Stefano Stabellini wrote: >>>> On Wed, 16 Nov 2022, Andrew Cooper wrote: >>>>> On 16/11/2022 01:37, Stefano Stabellini wrote: >>>>>> On Wed, 26 Oct 2022, Andrew Cooper wrote: >>>>>>> This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits >>>>>>> of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. >>>>>>> >>>>>>> First of all, with ARM borrowing x86's implementation, the logic to set the >>>>>>> pool size should have been common, not duplicated. Introduce >>>>>>> libxl__domain_set_p2m_pool_size() as a shared implementation, and use it from >>>>>>> the ARM and x86 paths. It is left as an exercise to the reader to judge how >>>>>>> libxl/xl can reasonably function without the ability to query the pool size... >>>>>>> >>>>>>> Remove ARM's p2m_domctl() infrastructure now the functioanlity has been >>>>>>> replaced with a working and unit tested interface. >>>>>>> >>>>>>> This is part of XSA-409 / CVE-2022-33747. >>>>>> Genuine question: I can see this patch removes the implementation of >>>>>> XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION on ARM. It also switches libxl (both >>>>>> ARM and x86) to the new hypercall. >>>>>> >>>>>> Why keep the old hypercall (XEN_DOMCTL_shadow_op and >>>>>> XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION) implementation on x86 (not on ARM)? >>>>>> >>>>>> Is that because it was only recently implemented? And not actually >>>>>> present in any past Xen release? >>>>>> >>>>>> If so, please add a note about this in the commit message. Also, if that >>>>>> is the case, I think this patch series should go in 4.17. If it is too >>>>>> late to get it in before the release, then we should backport it to 4.17 >>>>>> as soon as possible. That's because ideally we want to keep the >>>>>> hypercall interface changes down to a minimum. >>>>> On ARM, the hypercall has existed for a little over 4 weeks, and isn't >>>>> in any released version of Xen (yet). >>>>> >>>>> On x86, the hypercall has existed for more than a decade, and has known >>>>> out-of-tree users.  It needs to be deprecated properly, which in this >>>>> case means "phased out in the 4.18 cycle once known callers have been >>>>> adapted to the new hypercall". >>>> Understoon. Then I am in favor of getting all 4 patches in 4.17, either >>>> before the release or via backports. >>> Removing something from the domctl interface generally requires bumping >>> the interface version, so some extra care may need applying if such an >>> interface change was to be backported to any stable branch. >> >> To be clear, I have no plans to remove the x86 "older" interface in this >> patch series.  It will definitely break out of tree users. >> >> In the 4.18 timeframe, we can see about retiring the older hypercalls, >> but as a non-backportable change. > > For ARM, given that XEN_DOMCTL_shadow_op has not been enabled for long, > maybe we can get away without bumping the interface version? IMHO how long it was out doesn't matter. Once we do a release, we should avoid changing the interface in minor version. This is because a user may start to rely on it and we don't want to break them for minor releases. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 16 23:54:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 23:54:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444430.699631 (Exim 4.92) (envelope-from ) id 1ovSEi-0001HZ-HI; Wed, 16 Nov 2022 23:54:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444430.699631; Wed, 16 Nov 2022 23:54:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovSEi-0001HS-Em; Wed, 16 Nov 2022 23:54:32 +0000 Received: by outflank-mailman (input) for mailman id 444430; Wed, 16 Nov 2022 23:54:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovSEh-0001HM-3h for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 23:54:31 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 016fdd3a-660a-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 00:54:28 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 51BCE62045; Wed, 16 Nov 2022 23:54:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FB28C4314A; Wed, 16 Nov 2022 23:54:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 016fdd3a-660a-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668642867; bh=wWhTRD1qe9L8lizifxAIYwdgPyfG4JQYzGwz3JubiLk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=I0FxVmS92pr3ogC68NqJESacdqRuMTSkKorFOrmnGsudjbmVRR0hry0v+cK82/FAw vzNItCGDPIWkMVRMB/gBYr/tDbTFdWLUwe4mc9YjRS+hJ1N0dEc5ot/gUnqzHJYWwt tKzz/Dm7mA314+7RVLxJonJVEAnoWwy9IsGnD3xYgFQNGm18TzP99RwrLRQHlMMM9v T1xMJYB/401HB1PlMbwKmuvqiEeHf8nWUYE8dk8Ws5yOVdrP49+P3xTuChx0Tkuwca XnwmvySmTCDKMG1UkPuXHFPlUXZqDanXGNbVnNV64eKsdiPDCLock5ZcPudbVCXVXx o5VVD/lKp1g3Q== Date: Wed, 16 Nov 2022 15:54:24 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andre Przywara cc: Stefano Stabellini , Michal Orzel , Jiamei Xie , "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , "julien@xen.org" Subject: Re: Xen Arm vpl011 UART will cause segmentation fault in Linux guest In-Reply-To: <20221116110942.3faf952f@donnerap.cambridge.arm.com> Message-ID: References: <00764fe2-f78a-e5db-cb16-903ad1a5ec03@amd.com> <20221116110942.3faf952f@donnerap.cambridge.arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-564832753-1668642867=:4020" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-564832753-1668642867=:4020 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 16 Nov 2022, Andre Przywara wrote: > On Thu, 10 Nov 2022 12:32:49 -0800 (PST) > Stefano Stabellini wrote: > > On Wed, 9 Nov 2022, Michal Orzel wrote: > > > Hi Jiamei, > > > > > > On 09/11/2022 09:25, Jiamei Xie wrote: > > > > > > > > > > > > Hi Michal， > > > > > > > > Below log can be got when stating the linux guest. It says 9c09 is sbsa. And 9c09 is also output > > > > in bootlogd error message: > > > > Serial: AMBA PL011 UART driver > > > > 9c0b0000.uart: ttyAMA0 at MMIO 0x9c0b0000 (irq = 12, base_baud = 0) is a PL011 rev2 > > > > printk: console [ttyAMA0] enabled > > > > 9c090000.sbsa-uart: ttyAMA1 at MMIO 0x9c090000 (irq = 15, base_baud = 0) is a SBSA > > > > > > > > > > Xen behavior is correct and this would be Linux fault to try to write to DMACR for SBSA UART device. > > > DMACR is just an example. If you try to program e.g. the baudrate (through LCR) for VPL011 it will > > > also result in injecting abort into the guest. Should Xen support it? No. The reason why is that > > > it is not spec compliant operation. SBSA specification directly specifies what registers are exposed. > > > If Linux tries to write to some of the none-spec compliant registers - it is its fault. > > > > Yeah, we need to fix Linux. > > Yes, it's a bug in Linux, and nobody noticed because most SBSA UARTs are > actual PL011s, just not with everything wired up and the clocks fixed. > > But while you can take pride all day in Xen having a perfect > spec-compliant implementation - and you would be right - you have to face > the reality that existing Linux kernels will crash. > So we will add the one-liner in Linux that fixes that issue, and this will > probably be backported to stable kernels, but you will still encounter > kernels without the fix in the wild. > So I wonder if you should consider to just implement the other PL011 > registers as RAZ/WI? That would be spec compliant as well (since an actual > PL011 is also a spec-compliant SBSA-UART), but would work either way. Of > course you don't need to implement the DMA or baudrate functionality, but > at least not be nasty and trap on those register accesses. I think this is one of those cases where we should do both: - we should fix Linux, because that is a bug in Linux - we should improve Xen to make this class of issues less likely to show up in the future So I think implementing the other PL011 registers as RAZ/WI is a good improvement we could have in Xen. --8323329-564832753-1668642867=:4020-- From xen-devel-bounces@lists.xenproject.org Wed Nov 16 23:56:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 16 Nov 2022 23:56:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444434.699641 (Exim 4.92) (envelope-from ) id 1ovSGv-0001sP-Tg; Wed, 16 Nov 2022 23:56:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444434.699641; Wed, 16 Nov 2022 23:56:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovSGv-0001sI-Qw; Wed, 16 Nov 2022 23:56:49 +0000 Received: by outflank-mailman (input) for mailman id 444434; Wed, 16 Nov 2022 23:56:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovSGu-0001sC-5Z for xen-devel@lists.xenproject.org; Wed, 16 Nov 2022 23:56:48 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 544fc8e6-660a-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 00:56:46 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4C86DB81F0B; Wed, 16 Nov 2022 23:56:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9170AC433B5; Wed, 16 Nov 2022 23:56:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 544fc8e6-660a-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668643005; bh=Xf8T652sVPj0jAYuKh8bXfXq7wUmyp3rwTJL7Q86wms=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=NNzknhzHjOardbDEACaWSMf/2Dg9eFeHUqG/A9KFhCHB4c4ZKZqKKIocKoPqmPNpU Kt7AvyF0qPsciDJalIHUgS6yb3YMO3zjdUx1KH84Epvx368Sg0gPpflasIc9ZY0H+J vf2mUYsUw87enHR2t2K77oFNtEIPyC0/UzJvAfzIFM99hetDcO5z5azUNzVc7qQ3f1 JGXekwJaygVmQUm0+S8lOKnbXXKy774thxULxekpOjwo9IRsSGYAbuZ21TYvWuX2nk CgSpgSYWHbkHbarhgjJ1UL9cdgcW5xxI69U6wYemXAM2siog8vUA38+4+U8d869FXp VVkor+0aWtyEg== Date: Wed, 16 Nov 2022 15:56:42 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , Andrew Cooper , Jan Beulich , Xen-devel , Xen Security Team , Roger Pau Monne , Wei Liu , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony Perard Subject: Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls In-Reply-To: Message-ID: References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-4-andrew.cooper3@citrix.com> <269f4e70-07c2-5cf6-f42e-6f98e2ce70dd@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1621048945-1668643005=:4020" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1621048945-1668643005=:4020 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 16 Nov 2022, Julien Grall wrote: > On 16/11/2022 23:44, Stefano Stabellini wrote: > > On Wed, 16 Nov 2022, Andrew Cooper wrote: > > > On 16/11/2022 08:30, Jan Beulich wrote: > > > > On 16.11.2022 03:00, Stefano Stabellini wrote: > > > > > On Wed, 16 Nov 2022, Andrew Cooper wrote: > > > > > > On 16/11/2022 01:37, Stefano Stabellini wrote: > > > > > > > On Wed, 26 Oct 2022, Andrew Cooper wrote: > > > > > > > > This reverts most of commit > > > > > > > > cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits > > > > > > > > of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. > > > > > > > > > > > > > > > > First of all, with ARM borrowing x86's implementation, the logic > > > > > > > > to set the > > > > > > > > pool size should have been common, not duplicated. Introduce > > > > > > > > libxl__domain_set_p2m_pool_size() as a shared implementation, > > > > > > > > and use it from > > > > > > > > the ARM and x86 paths. It is left as an exercise to the reader > > > > > > > > to judge how > > > > > > > > libxl/xl can reasonably function without the ability to query > > > > > > > > the pool size... > > > > > > > > > > > > > > > > Remove ARM's p2m_domctl() infrastructure now the functioanlity > > > > > > > > has been > > > > > > > > replaced with a working and unit tested interface. > > > > > > > > > > > > > > > > This is part of XSA-409 / CVE-2022-33747. > > > > > > > Genuine question: I can see this patch removes the implementation > > > > > > > of > > > > > > > XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION on ARM. It also switches libxl > > > > > > > (both > > > > > > > ARM and x86) to the new hypercall. > > > > > > > > > > > > > > Why keep the old hypercall (XEN_DOMCTL_shadow_op and > > > > > > > XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION) implementation on x86 (not on > > > > > > > ARM)? > > > > > > > > > > > > > > Is that because it was only recently implemented? And not actually > > > > > > > present in any past Xen release? > > > > > > > > > > > > > > If so, please add a note about this in the commit message. Also, > > > > > > > if that > > > > > > > is the case, I think this patch series should go in 4.17. If it is > > > > > > > too > > > > > > > late to get it in before the release, then we should backport it > > > > > > > to 4.17 > > > > > > > as soon as possible. That's because ideally we want to keep the > > > > > > > hypercall interface changes down to a minimum. > > > > > > On ARM, the hypercall has existed for a little over 4 weeks, and > > > > > > isn't > > > > > > in any released version of Xen (yet). > > > > > > > > > > > > On x86, the hypercall has existed for more than a decade, and has > > > > > > known > > > > > > out-of-tree users.  It needs to be deprecated properly, which in > > > > > > this > > > > > > case means "phased out in the 4.18 cycle once known callers have > > > > > > been > > > > > > adapted to the new hypercall". > > > > > Understoon. Then I am in favor of getting all 4 patches in 4.17, > > > > > either > > > > > before the release or via backports. > > > > Removing something from the domctl interface generally requires bumping > > > > the interface version, so some extra care may need applying if such an > > > > interface change was to be backported to any stable branch. > > > > > > To be clear, I have no plans to remove the x86 "older" interface in this > > > patch series.  It will definitely break out of tree users. > > > > > > In the 4.18 timeframe, we can see about retiring the older hypercalls, > > > but as a non-backportable change. > > > > For ARM, given that XEN_DOMCTL_shadow_op has not been enabled for long, > > maybe we can get away without bumping the interface version? > > IMHO how long it was out doesn't matter. Once we do a release, we should avoid > changing the interface in minor version. > > This is because a user may start to rely on it and we don't want to break them > for minor releases. We haven't released 4.17 yet, so I take you are referring to a stable minor release, right? --8323329-1621048945-1668643005=:4020-- From xen-devel-bounces@lists.xenproject.org Thu Nov 17 00:26:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 00:26:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444439.699653 (Exim 4.92) (envelope-from ) id 1ovSj8-0006bj-0o; Thu, 17 Nov 2022 00:25:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444439.699653; Thu, 17 Nov 2022 00:25:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovSj7-0006bc-Tm; Thu, 17 Nov 2022 00:25:57 +0000 Received: by outflank-mailman (input) for mailman id 444439; Thu, 17 Nov 2022 00:25:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovSj6-0006bG-Af for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 00:25:56 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 65d638c7-660e-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 01:25:55 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B8D2CB81F6C; Thu, 17 Nov 2022 00:25:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4351C433C1; Thu, 17 Nov 2022 00:25:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65d638c7-660e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668644752; bh=gSc4ImvW0k6TUo5yDYBWMl7ZWJJRvNGwdcKiYg787OE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=NHboADJ/EvbaxIu1BEPkpKglOrTW0/+wNl0c0L0lkcxa2qAZbtTM2DRhQASOuvjP6 NX7MqTT7bIzVDMghk5LE0lfBpzkOfH6RMehWbLyV/AFhJz3ZLKE/mRNnet7yg1BhoG TtIbYiTz+U7eIkrnA4XIguD6/pMSROruQBXxMfYk1Vyf+vKDtHuv6SLdc0ttF2Ijnh kLeNKrneX2pwuEn2o11yg0BORPuZh7KdiZX9ZxviFpthWoD7sN3WtFppf/aPSxOZaI Dl91lbk0Xpq9S8LL6bU+efSQaZ9/whQiHTVjfJfMpytAJvlOv/6n7ow8Npi6D5BhcH BtgmpsN/JqWRg== Date: Wed, 16 Nov 2022 16:25:50 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: Re: [ImageBuilder] Do not set #xen,static-mem-{address/size}-cells In-Reply-To: <20221116085417.3159-1-michal.orzel@amd.com> Message-ID: References: <20221116085417.3159-1-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 16 Nov 2022, Michal Orzel wrote: > Xen commit 942ac5fc15ec ("xen/arm, device-tree: Make static-mem > use #{address,size}-cells") dropped these custom properties in favor of > reusing regular #{address/size}-cells from the chosen node for the > xen,static-mem property. Reflect this change in ImageBuilder. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > The master branch of ImageBuilder should reflect the current status of Xen. > Apart from that, we might want to come up with some versioning system in > ImageBuilder, because commits like this one are breaking the backwards > compatibility. Agreed > --- > scripts/uboot-script-gen | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen > index 0ef89b680348..7e5cc080407e 100755 > --- a/scripts/uboot-script-gen > +++ b/scripts/uboot-script-gen > @@ -181,9 +181,6 @@ function add_device_tree_static_mem() > local cells=() > local val > > - dt_set "$path" "#xen,static-mem-address-cells" "hex" "0x2" > - dt_set "$path" "#xen,static-mem-size-cells" "hex" "0x2" > - > for val in ${regions[@]} > do > cells+=("$(printf "0x%x 0x%x" $(($val >> 32)) $(($val & ((1 << 32) - 1))))") > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Nov 17 00:33:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 00:33:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444443.699664 (Exim 4.92) (envelope-from ) id 1ovSq1-0008Il-Op; Thu, 17 Nov 2022 00:33:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444443.699664; Thu, 17 Nov 2022 00:33:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovSq1-0008Ie-Ls; Thu, 17 Nov 2022 00:33:05 +0000 Received: by outflank-mailman (input) for mailman id 444443; Thu, 17 Nov 2022 00:33:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovSq0-0008IY-TH for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 00:33:05 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060b.outbound.protection.outlook.com [2a01:111:f400:fe0e::60b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 649a5065-660f-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 01:33:02 +0100 (CET) Received: from AS9PR06CA0242.eurprd06.prod.outlook.com (2603:10a6:20b:45f::10) by DU0PR08MB8254.eurprd08.prod.outlook.com (2603:10a6:10:412::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Thu, 17 Nov 2022 00:33:00 +0000 Received: from AM7EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45f:cafe::e1) by AS9PR06CA0242.outlook.office365.com (2603:10a6:20b:45f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Thu, 17 Nov 2022 00:33:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT062.mail.protection.outlook.com (100.127.140.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 00:32:59 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Thu, 17 Nov 2022 00:32:59 +0000 Received: from fe5cf1dfd153.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B51DE658-5D37-4FA5-BD8D-C9C7648D60B7.1; Thu, 17 Nov 2022 00:32:52 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fe5cf1dfd153.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 17 Nov 2022 00:32:52 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB8978.eurprd08.prod.outlook.com (2603:10a6:10:466::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8; Thu, 17 Nov 2022 00:32:50 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%7]) with mapi id 15.20.5834.007; Thu, 17 Nov 2022 00:32:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 649a5065-660f-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vV6VPE4BZmIDvtYs4TXWlmWPqM9X2XIBhF6qETb7avE=; b=c1FrXatlp6ufvEOREZDB27CgWqJmnMGdJLVctO1DKJFV87e4JXUETEegRpDt+ihiQOtpAGastg3imAR5WNZkyTcKAEw0zBo/FOM16TTlUGMnqvjxqXK1ReEv+yj7wXXESoyTZeyoudhTu22U2XFO+1FrcZFyfOwwAgSAUbqHOwE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AhGL/6W4ldOs2zUDojasDT2iKPIVqk72YXySXCvQamzCeMfvHSM3XwW7v2OXeRGJWYA6GFWafwDtEjTaYgVRftMjigJ1ynWC+9rwY5ulUsXLGQ0MP/OmUABSTiupYPKMKoKOeBKn3FfakCHIwoVPsSWMhio71Epwl27nYr8QrSD7TfjVhiB+HMTAvFKy8eLRVzaOdKOrvIGBQMk+MDSBQbiOgD9KYnA/dfUIbwiphsmVwv++yiYuD1Oy6CGfIQJll9JZ/rRLK/Qm7BZUJZRXcr9cRgkb5LWjOsm6PKPJRVbMacIpjomLNN3c98BYwmbtIl93oCImaRTXkr1wOJwjvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vV6VPE4BZmIDvtYs4TXWlmWPqM9X2XIBhF6qETb7avE=; b=Oh15qD4qcExsJKOo+iBJNDkgndqotTv0an5hDruRHREr2tynvEpMnHgG4SBH+uG+WGJBb0DaOKOoWSqNBW7kAVFMcH84BIhkTFN+NRhMQl6lR/usiuAC8XQwIfcCg+hXtnM8KtXPfAd70zeHVUnHIV+NfMUTD3UrDJm3QANnMWjE/1rmiTvH9yDMmkgLhwVdlsVL3JQPjx9f0IQt/4MmixzIl4uy6OjRfR5NbvOCekbd+z3nH/sVINlE/a1Zfjxg/cUORdoZXls0H1g2P9BavMjQ2TWZ03joqwk+7Ixa9AHbEDWLDdlnk2+rPzp/Tkc3PM0Vdsz+uMJ2f0jxsJH8fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vV6VPE4BZmIDvtYs4TXWlmWPqM9X2XIBhF6qETb7avE=; b=c1FrXatlp6ufvEOREZDB27CgWqJmnMGdJLVctO1DKJFV87e4JXUETEegRpDt+ihiQOtpAGastg3imAR5WNZkyTcKAEw0zBo/FOM16TTlUGMnqvjxqXK1ReEv+yj7wXXESoyTZeyoudhTu22U2XFO+1FrcZFyfOwwAgSAUbqHOwE= From: Henry Wang To: Andrew Cooper , Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: RE: [PATCH for-4.17] x86/hvm: Revert per-domain APIC acceleration support Thread-Topic: [PATCH for-4.17] x86/hvm: Revert per-domain APIC acceleration support Thread-Index: AQHY+Io5SsSPwLQd50Ssx9qPxKXw6q4/rWQAgAIwJACAAGmBEA== Date: Thu, 17 Nov 2022 00:32:50 +0000 Message-ID: References: <20221115003539.19502-1-andrew.cooper3@citrix.com> <29469c16-856c-bce7-c556-66622e349f1c@suse.com> <2334ba7c-d744-c1ca-8f67-b2013e9c5fe4@citrix.com> In-Reply-To: <2334ba7c-d744-c1ca-8f67-b2013e9c5fe4@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A0A92095E3A37747A62DD842BD9AB497.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DU0PR08MB8978:EE_|AM7EUR03FT062:EE_|DU0PR08MB8254:EE_ X-MS-Office365-Filtering-Correlation-Id: 21f7cd1d-bab0-44be-c354-08dac8334781 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: g5YuA1QXIRzslmShASxC2tSxuMSFcBxI3YJHSrTH4ofyMrmLcF8cBd0k3cVgBiilsON22j0sE6R97tXrJ1dut1uGQhlQt4+9IVrm0QEdbufaLIl70W9ALeEmadZfzeSZVaKIL1/YY49wMcV+n7qW3SdLFEvyPXC8PVuJRkexAVArAro3gjEia9loPXhHRX3T9wT45YmXRzuk+D2yVeUyptC+kKorsX+YSBC6PnMa6WY0nib6L4iaTejmy28B7745iSRCAZp+a9L9BXpapAjK9sKavk3c4mqRhpa7avsa/Cx0s2yzC7NnoXGWL+R3gb7dMA0QypSIo7j5kZgEbEAmH8GJ7JVgm5xHASMLhRU1kkIy+Pyoh8FQTU8eBde3eNYfPhurXNNONuBaC1IYv/L6tKtvNTkZGJ+WVAhKilEF4/K7CWmtKdsZxZGv9sY4vonx0cnYYqAOdeBMy0OD/cpNuvhM/s5P14TXtjKnAbbp0EyjJ21zLnEag+wV5IWhdo0AwkUMFCzgaRSMIp7UOKJajkqNHenXxoIb+zKghTg31WLb2pjNxMdWVvLEa+Qn9AAwJc+yIz7IVXIHzn6mrcyIiAtADmMeCHWS/KmMtHKknmXdmHR1835lV0FlHMaRWGS80xH5ycBKMllHyUb1ikIdm0griPMz+Ylu2LqxufbaFkJ3QYw3XwqRIWBRE73uZqS+5tolD3d8wvjBvZJjDi4fRe/gVyB4GFNako6pxOna5Hcwe3feoMJQxV+I980LjfnvE2VDTu+FAVu+JjBZviIPVQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(39860400002)(366004)(396003)(451199015)(33656002)(38100700002)(86362001)(2906002)(4744005)(8676002)(8936002)(4326008)(122000001)(83380400001)(66556008)(38070700005)(110136005)(316002)(41300700001)(76116006)(186003)(54906003)(66946007)(478600001)(66446008)(66476007)(5660300002)(52536014)(64756008)(9686003)(26005)(7696005)(71200400001)(6506007)(55016003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8978 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7bf778e4-04be-47c9-8cfd-08dac8334249 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m72Uvp7O0dRAZKXtlVv3vf8dYaLXdktpCXLxlWjZVhLJ7aUi851boOawwijcR+DpFZbjSe1Eo+gibEn2XmYIOXIOa6h2jKDauX3LIyGq5yfLoqiTQYUPVy/5WdPRTe7Q/qKLOlj99u2qL9v1PH6ugxIl/4GYQL8FKtVqYu1Mc11vvlixhLEmNyQDwz/q7H73WQEy8/4fuK0DPnyFjgaqtlGlIgjKANcGrzd/D2iRgpBWQinj85Y5B2DClZRCX4DIa1ktPhbUEazsA5UNpDKsoF7rG3Ca/yznI6nTu2sXnst02/FvAY0lH66ECVZ2AL5zSeeudp1YIyCngnez4NfJxd9G6FbRMH0pWNRaJnVvqBuBxjf2Rs0SFG42v8lxUsIUXR1HioXRAzlkVMHoHRKrOaR9vEOQQ/Yl/162B4S3aEnE7TUd2NW7BwfeCNyW8RCH6Oq104YxKdvkZKQc2umlFht0MnW3RDgaPXVs3BccDwKsaxpRdgfzR/3miHVljtjOeqrxMsHg2syAlye46QiX6mFY8onyT8kklqg7hLXs5sS0k/cisQiaid7OMBh6eNPMBlrPDmhEYXER2mmPBWpGU1QI6CrgY6w0LJasu33vRKDaYJmtee3GA/y3V4b6LBrSAtZxszpRLZoJXcRiouJZWiFGb0LOEtf8DBBZIj9Ywc/BMogqLA1BRLZKOnFylCtJGtl/gQibyytg2iUgbDPJ2R5NdPzK7A2cCORwNmo4SwhI41+iI1BEQBtAVWYt5V4OWNfV/vxU2XB1M04WGU5frQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(136003)(346002)(451199015)(46966006)(40470700004)(36840700001)(186003)(83380400001)(6506007)(26005)(9686003)(82310400005)(7696005)(478600001)(40460700003)(36860700001)(86362001)(336012)(82740400003)(55016003)(40480700001)(81166007)(52536014)(33656002)(356005)(8936002)(41300700001)(2906002)(5660300002)(47076005)(110136005)(4744005)(54906003)(4326008)(8676002)(316002)(70586007)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 00:32:59.4295 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21f7cd1d-bab0-44be-c354-08dac8334781 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8254 SGkgQW5kcmV3LA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEFuZHJl dyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggZm9yLTQuMTddIHg4Ni9odm06IFJldmVydCBwZXItZG9tYWluIEFQSUMgYWNjZWxlcmF0aW9u DQo+IHN1cHBvcnQNCj4gDQo+ID4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJl dy5jb29wZXIzQGNpdHJpeC5jb20+DQo+ID4gUHJvdmlzaW9uYWwgdXBvbiBSb2dlciBub3Qgb2Jq ZWN0aW5nIChpLmUuIGhpbSBhdCBsZWFzdCByZW1haW5pbmcNCj4gPiBuZXV0cmFsKSwgYW5kIHBy ZWZlcmFibHkgd2l0aCB0aGUgYWJvdmUgcmVtYXJrcyBhZGRyZXNzZWQ6DQo+ID4gQWNrZWQtYnk6 IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gDQo+IFRoYW5rcy4NCg0KUmVsZWFz ZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KDQpLaW5kIHJlZ2Fy ZHMsDQpIZW5yeQ0KDQoNCj4gDQo+IH5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Thu Nov 17 01:08:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 01:08:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444449.699675 (Exim 4.92) (envelope-from ) id 1ovTO6-0002Pj-GN; Thu, 17 Nov 2022 01:08:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444449.699675; Thu, 17 Nov 2022 01:08:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovTO6-0002Pc-Db; Thu, 17 Nov 2022 01:08:18 +0000 Received: by outflank-mailman (input) for mailman id 444449; Thu, 17 Nov 2022 01:08:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovTO4-0002PW-Ky for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 01:08:16 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4eafe633-6614-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 02:08:14 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4eafe633-6614-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668647294; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=QJ8hGZ4Ye+I5hxPTrLz98D7mYk7LDq2GMg+RVVLl3jU=; b=UIVpMG6YPCE7OqnaimGgIARXWY7BPKOD/UgS5PsxkmVNISoufaVSaHjH 2ofCRJx88k2BvcWWPfQijdDIWDJeSMLFGe1X1TMR/3m5q2kL7Nrr5Rmh8 Ep1KJQ7/R2Hl77pIV8ZefHBPIsuBVBuYvJYvF9qILmizxXKMcaJp8V7Mt A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84052645 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:ianH3q/BP0FyARKyKMR5DrUDdH6TJUtcMsCJ2f8bNWPcYEJGY0x3z TZODW6EOfbcZ2T3ettyOoi0pkJT6MOAzN43TAI9+Xg8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKkV5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklk8 c04GjEXKSmOpMmK2O2Fa/tp3MMKeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGM0Yn1lQ/UfrSmM+BgHXlfiIeg1WSvactuEDYzRBr0airO93QEjCPbZUJxhvC+ D6bl4j/KiobF8ajyyC5y3GDufPipBmhVtMiCoTto5aGh3XMnzdOWXX6T2CTn/69jUKvXsNFH GYd8CEusKsa+VSiS5/2WBjQiHyZuh8RXfJAHut87xuCooLe7hyFHGECQnhEYcY/qc4tbTUw0 xmCmNaBLRxitqeED02U8Li8pCm3fyMSKAcqfjQYRAEI593ipoAbjR/VSNtnVqmvgbXdCTz2h jyHsiU6r7ESltIQkbW2+0jdhDChrYSPSRQ6ji31dG+46gJyZKa+epelr1Pc6J5oM4KxXlSH+ n8elKCjAPsmVM/X0nbXGaNUQe/vt63t3CDgbUBHNZ0Q1was4TmacKN73CkhGmZ7N5wDUGq8C KPMgj956JhWNXqsSKZ4ZYOtFsgnpZTd+cTZuuP8NYQXPMUoHOOT1GQ3PBPLgTix+KQ5uftnU ap3Z/pAGprz5U5P6DOtD9kQ3rYwrszV7TOCHMurp/hLPFf3WZJ0dVvnGAHQBgzaxPneyOkwz zq4H5Xi9vmneLeiChQ7CKZKRb3KRFBibXwMl+RZd/SYPi1tE3w7BvnazNsJItI7z/oPzbuXp C/iACe0LWYTY1WccG1mjVg6NtvSsWtX9ypnbUTAw371s5TcXWpfxPhGLMZmFVXW3Odi0eR1X 5E4lzaoW5xyp/Wu02p1UKQRW6QyLkXx21PQZHvNjfpWV8cIejElM+TMJmPHnBTixALt3Sfii 9VMDj/mfKc= IronPort-HdrOrdr: A9a23:QZRXVKCka5GbtL3lHemm55DYdb4zR+YMi2TC1yhKJiC9Ffbo8/ xG/c5rsCMc5wxxZJhNo7290cq7MBHhHPxOgbX5VI3KNGKNhILBFvAE0WKI+VPd8kPFmtK1rZ 0QEJRDNA== X-IronPort-AV: E=Sophos;i="5.96,169,1665460800"; d="scan'208";a="84052645" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony PERARD Subject: [PATCH for-4.17 0/4] XSA-409 fixes Date: Thu, 17 Nov 2022 01:08:00 +0000 Message-ID: <20221117010804.9384-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit For 4.17, and backport to all stable releases. Patch 2 doesn't technically need backporting, but it's safe and I'm dis-enclined to forgo testing in older releases. See patches for changelogs. Andrew Cooper (4): xen: Introduce non-broken hypercalls for the paging mempool size tools/tests: Unit test for paging mempool size xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls xen/arm: Correct the p2m pool size calculations tools/include/xenctrl.h | 3 + tools/libs/ctrl/xc_domain.c | 29 ++++ tools/libs/light/libxl_arm.c | 14 +- tools/libs/light/libxl_dom.c | 19 +++ tools/libs/light/libxl_internal.h | 3 + tools/libs/light/libxl_x86.c | 15 +- tools/tests/Makefile | 1 + tools/tests/paging-mempool/.gitignore | 1 + tools/tests/paging-mempool/Makefile | 42 ++++++ tools/tests/paging-mempool/test-paging-mempool.c | 181 +++++++++++++++++++++++ xen/arch/arm/domctl.c | 53 ------- xen/arch/arm/include/asm/p2m.h | 1 - xen/arch/arm/p2m.c | 32 ++-- xen/arch/x86/include/asm/hap.h | 1 + xen/arch/x86/include/asm/shadow.h | 4 + xen/arch/x86/mm/hap/hap.c | 11 ++ xen/arch/x86/mm/paging.c | 43 ++++++ xen/arch/x86/mm/shadow/common.c | 11 ++ xen/common/domctl.c | 14 ++ xen/include/public/domctl.h | 24 ++- xen/include/xen/domain.h | 3 + 21 files changed, 415 insertions(+), 90 deletions(-) create mode 100644 tools/tests/paging-mempool/.gitignore create mode 100644 tools/tests/paging-mempool/Makefile create mode 100644 tools/tests/paging-mempool/test-paging-mempool.c -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 17 01:08:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 01:08:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444451.699690 (Exim 4.92) (envelope-from ) id 1ovTOD-0002jG-0f; Thu, 17 Nov 2022 01:08:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444451.699690; Thu, 17 Nov 2022 01:08:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovTOC-0002ii-TI; Thu, 17 Nov 2022 01:08:24 +0000 Received: by outflank-mailman (input) for mailman id 444451; Thu, 17 Nov 2022 01:08:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovTOB-0002f1-Cd for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 01:08:23 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 51beb88b-6614-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 02:08:19 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51beb88b-6614-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668647299; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5f7lo/vfS1azSCVrGCLN6cgm1Xi1cZ6LYp1mvu+q1ws=; b=CaNKTYg0hgx2kyfMfcaooQDgzoLlssrL3LLBc75kiFksISnCUSvsVLC1 Eh88vOSYgR2WmvMKq35Aqso2ElvxteQXaa3WoUkSf6P7hwQSQ45Nxc0Rs OkwQeUl794r6sRY4ZPP/a+jsjAKzCjNOZ02Bp4F5TO/2l7MBJiBVRdx0k g=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84572755 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:UDwTsKxHphyhu4Ikavx6t+fDxirEfRIJ4+MujC+fZmUNrF6WrkUAy GodD2HSOfmIYGvxL9B+bI3g9EwH6sOBnYJjTAVq/CAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPK4T5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVtz9 KQ/IwxQVQug2ryKmZidQ/Qyg/12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiFZkIwRzH+ z+uE2LRCVIoLOa80xq5/H+yufaTuAXaV74rG+jtnhJtqALKnTFCYPEMbnOFpv2+hl+7SshoA UUe8SozroA/7EWuCNL6WnWQomOAvxMac8pdFas98g7l4qDZ+RqDD24ICDtIcsU7tdQeTCYvk FSOmrvBJTFpqqzTdnub+Z+dtzb0Mi8QRUcZfjMNRwYB59jloakwgwjJQ9IlF7S65vXlFDe1z z2UoSwWg7QIkdVNx6i95UrAgT+nut7OVAFdzif9U3+h7wh5TJW4fIHu4l/ehd5fKK6JQ1/Hu 2IL8/Vy98hXU8vLznbUBrxQQvf5vJ5pLQEwn3ZVIph50D+RpkW4Xt0O3GhUAk50bMM9LGqBj FDohStd45paPX2PZKBxYp6sB8lC8ZUMBegJRdiPMIMQP8EZmBuvuXg3OBXOhzyFfF0Ey/lXB HuNTSq74Z/244xDxSH+eeoS2KRDKssWlTKKHsCTI/hKPNOjiJ+ppVUtagXmggMRtvnsTODpH zF3aaO3J+13CrGWX8Uu2dd7wJBjBSFT6WrKg8JWbPWfBQFtBXssDfTcqZt4JdI1wf4OyriSo C7nMqO99LYZrSaeQeltQik9AI4DoL4l9S5rVcDSFQvAN4cfjXaHs/5EKspfkUgP/+1/1/9kJ 8TpiO3Zasmii13vpVwgUHUKhNw4JU711FzVbkJIolEXJvZdeuAAwfe8FiOHycXEJnPfWRcWy 1F46j7mfA== IronPort-HdrOrdr: A9a23:/oB0iqp3Mhf7wlVGfsVBRUcaV5oteYIsimQD101hICG8cqSj+P xG+85rsyMc6QxhP03I9urgBEDtex7hHNtOkOss1NSZLW3bUQmTTL2KhLGKq1aLJ8S9zJ856U 4JSdkGNDSaNzZHZKjBjDVQa+xQo+W6zA== X-IronPort-AV: E=Sophos;i="5.96,169,1665460800"; d="scan'208";a="84572755" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony PERARD Subject: [PATCH 1/4] xen: Introduce non-broken hypercalls for the paging mempool size Date: Thu, 17 Nov 2022 01:08:01 +0000 Message-ID: <20221117010804.9384-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221117010804.9384-1-andrew.cooper3@citrix.com> References: <20221117010804.9384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Release-acked-by: Henry Wang --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Henry Wang CC: Anthony PERARD v2: * s/p2m/paging/ * Fix overflow-before-widen in ARM's arch_get_p2m_mempool_size() * Fix overflow-before-widen in both {hap,shadow}_get_allocation_bytes() * Leave a TODO about x86/PV, drop assertion. * Check for long->int truncation in x86's arch_set_paging_mempool_size() Future TODOs: * x86 shadow still rounds up. This is buggy as it's a simultaneous equation with tot_pages which varies over time with ballooning. * x86 PV is weird. There are no toolstack interact with the shadow pool size, but the "shadow" pool it does come into existence when logdirty (or pv-l1tf) when first enabled. * The shadow+hap logic is in desperate need of deduping. --- tools/include/xenctrl.h | 3 +++ tools/libs/ctrl/xc_domain.c | 29 ++++++++++++++++++++++++++ xen/arch/arm/p2m.c | 26 +++++++++++++++++++++++ xen/arch/x86/include/asm/hap.h | 1 + xen/arch/x86/include/asm/shadow.h | 4 ++++ xen/arch/x86/mm/hap/hap.c | 11 ++++++++++ xen/arch/x86/mm/paging.c | 43 +++++++++++++++++++++++++++++++++++++++ xen/arch/x86/mm/shadow/common.c | 11 ++++++++++ xen/common/domctl.c | 14 +++++++++++++ xen/include/public/domctl.h | 24 +++++++++++++++++++++- xen/include/xen/domain.h | 3 +++ 11 files changed, 168 insertions(+), 1 deletion(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 0c8b4c3aa7a5..23037874d3d5 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -893,6 +893,9 @@ long long xc_logdirty_control(xc_interface *xch, unsigned int mode, xc_shadow_op_stats_t *stats); +int xc_get_paging_mempool_size(xc_interface *xch, uint32_t domid, uint64_t *size); +int xc_set_paging_mempool_size(xc_interface *xch, uint32_t domid, uint64_t size); + int xc_sched_credit_domain_set(xc_interface *xch, uint32_t domid, struct xen_domctl_sched_credit *sdom); diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c index 14c0420c35be..e939d0715739 100644 --- a/tools/libs/ctrl/xc_domain.c +++ b/tools/libs/ctrl/xc_domain.c @@ -706,6 +706,35 @@ long long xc_logdirty_control(xc_interface *xch, return (rc == 0) ? domctl.u.shadow_op.pages : rc; } +int xc_get_paging_mempool_size(xc_interface *xch, uint32_t domid, uint64_t *size) +{ + int rc; + struct xen_domctl domctl = { + .cmd = XEN_DOMCTL_get_paging_mempool_size, + .domain = domid, + }; + + rc = do_domctl(xch, &domctl); + if ( rc ) + return rc; + + *size = domctl.u.paging_mempool.size; + return 0; +} + +int xc_set_paging_mempool_size(xc_interface *xch, uint32_t domid, uint64_t size) +{ + struct xen_domctl domctl = { + .cmd = XEN_DOMCTL_set_paging_mempool_size, + .domain = domid, + .u.paging_mempool = { + .size = size, + }, + }; + + return do_domctl(xch, &domctl); +} + int xc_domain_setmaxmem(xc_interface *xch, uint32_t domid, uint64_t max_memkb) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 94d3b60b1387..8c1972e58227 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -100,6 +100,13 @@ unsigned int p2m_get_allocation(struct domain *d) return ROUNDUP(nr_pages, 1 << (20 - PAGE_SHIFT)) >> (20 - PAGE_SHIFT); } +/* Return the size of the pool, in bytes. */ +int arch_get_paging_mempool_size(struct domain *d, uint64_t *size) +{ + *size = (uint64_t)ACCESS_ONCE(d->arch.paging.p2m_total_pages) << PAGE_SHIFT; + return 0; +} + /* * Set the pool of pages to the required number of pages. * Returns 0 for success, non-zero for failure. @@ -157,6 +164,25 @@ int p2m_set_allocation(struct domain *d, unsigned long pages, bool *preempted) return 0; } +int arch_set_paging_mempool_size(struct domain *d, uint64_t size) +{ + unsigned long pages = size >> PAGE_SHIFT; + bool preempted = false; + int rc; + + if ( (size & ~PAGE_MASK) || /* Non page-sized request? */ + pages != (size >> PAGE_SHIFT) ) /* 32-bit overflow? */ + return -EINVAL; + + spin_lock(&d->arch.paging.lock); + rc = p2m_set_allocation(d, pages, &preempted); + spin_unlock(&d->arch.paging.lock); + + ASSERT(preempted == (rc == -ERESTART)); + + return rc; +} + int p2m_teardown_allocation(struct domain *d) { int ret = 0; diff --git a/xen/arch/x86/include/asm/hap.h b/xen/arch/x86/include/asm/hap.h index 90dece29deca..14d2f212dab9 100644 --- a/xen/arch/x86/include/asm/hap.h +++ b/xen/arch/x86/include/asm/hap.h @@ -47,6 +47,7 @@ int hap_track_dirty_vram(struct domain *d, extern const struct paging_mode *hap_paging_get_mode(struct vcpu *); int hap_set_allocation(struct domain *d, unsigned int pages, bool *preempted); unsigned int hap_get_allocation(struct domain *d); +int hap_get_allocation_bytes(struct domain *d, uint64_t *size); #endif /* XEN_HAP_H */ diff --git a/xen/arch/x86/include/asm/shadow.h b/xen/arch/x86/include/asm/shadow.h index 1365fe480518..dad876d29499 100644 --- a/xen/arch/x86/include/asm/shadow.h +++ b/xen/arch/x86/include/asm/shadow.h @@ -97,6 +97,8 @@ void shadow_blow_tables_per_domain(struct domain *d); int shadow_set_allocation(struct domain *d, unsigned int pages, bool *preempted); +int shadow_get_allocation_bytes(struct domain *d, uint64_t *size); + #else /* !CONFIG_SHADOW_PAGING */ #define shadow_vcpu_teardown(v) ASSERT(is_pv_vcpu(v)) @@ -108,6 +110,8 @@ int shadow_set_allocation(struct domain *d, unsigned int pages, ({ ASSERT_UNREACHABLE(); -EOPNOTSUPP; }) #define shadow_set_allocation(d, pages, preempted) \ ({ ASSERT_UNREACHABLE(); -EOPNOTSUPP; }) +#define shadow_get_allocation_bytes(d, size) \ + ({ ASSERT_UNREACHABLE(); -EOPNOTSUPP; }) static inline void sh_remove_shadows(struct domain *d, mfn_t gmfn, int fast, int all) {} diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c index f809ea9aa6ae..0fc1b1d9aced 100644 --- a/xen/arch/x86/mm/hap/hap.c +++ b/xen/arch/x86/mm/hap/hap.c @@ -345,6 +345,17 @@ unsigned int hap_get_allocation(struct domain *d) + ((pg & ((1 << (20 - PAGE_SHIFT)) - 1)) ? 1 : 0)); } +int hap_get_allocation_bytes(struct domain *d, uint64_t *size) +{ + unsigned long pages = d->arch.paging.hap.total_pages; + + pages += d->arch.paging.hap.p2m_pages; + + *size = pages << PAGE_SHIFT; + + return 0; +} + /* Set the pool of pages to the required number of pages. * Returns 0 for success, non-zero for failure. */ int hap_set_allocation(struct domain *d, unsigned int pages, bool *preempted) diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c index 3a355eee9ca3..8d579fa9a3e8 100644 --- a/xen/arch/x86/mm/paging.c +++ b/xen/arch/x86/mm/paging.c @@ -977,6 +977,49 @@ int __init paging_set_allocation(struct domain *d, unsigned int pages, } #endif +int arch_get_paging_mempool_size(struct domain *d, uint64_t *size) +{ + int rc; + + if ( is_pv_domain(d) ) /* TODO: Relax in due course */ + return -EOPNOTSUPP; + + if ( hap_enabled(d) ) + rc = hap_get_allocation_bytes(d, size); + else + rc = shadow_get_allocation_bytes(d, size); + + return rc; +} + +int arch_set_paging_mempool_size(struct domain *d, uint64_t size) +{ + unsigned long pages = size >> PAGE_SHIFT; + bool preempted = false; + int rc; + + if ( is_pv_domain(d) ) /* TODO: Relax in due course */ + return -EOPNOTSUPP; + + if ( size & ~PAGE_MASK || /* Non page-sized request? */ + pages != (unsigned int)pages ) /* Overflow $X_set_allocation()? */ + return -EINVAL; + + paging_lock(d); + if ( hap_enabled(d) ) + rc = hap_set_allocation(d, pages, &preempted); + else + rc = shadow_set_allocation(d, pages, &preempted); + paging_unlock(d); + + /* + * TODO: Adjust $X_set_allocation() so this is true. + ASSERT(preempted == (rc == -ERESTART)); + */ + + return preempted ? -ERESTART : rc; +} + /* * Local variables: * mode: C diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c index badfd53c6b23..a8404f97f668 100644 --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1427,6 +1427,17 @@ static unsigned int shadow_get_allocation(struct domain *d) + ((pg & ((1 << (20 - PAGE_SHIFT)) - 1)) ? 1 : 0)); } +int shadow_get_allocation_bytes(struct domain *d, uint64_t *size) +{ + unsigned long pages = d->arch.paging.shadow.total_pages; + + pages += d->arch.paging.shadow.p2m_pages; + + *size = pages << PAGE_SHIFT; + + return 0; +} + /**************************************************************************/ /* Hash table for storing the guest->shadow mappings. * The table itself is an array of pointers to shadows; the shadows are then diff --git a/xen/common/domctl.c b/xen/common/domctl.c index 69fb9abd346f..ad71ad8a4cc5 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -874,6 +874,20 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) ret = iommu_do_domctl(op, d, u_domctl); break; + case XEN_DOMCTL_get_paging_mempool_size: + ret = arch_get_paging_mempool_size(d, &op->u.paging_mempool.size); + if ( !ret ) + copyback = 1; + break; + + case XEN_DOMCTL_set_paging_mempool_size: + ret = arch_set_paging_mempool_size(d, op->u.paging_mempool.size); + + if ( ret == -ERESTART ) + ret = hypercall_create_continuation( + __HYPERVISOR_domctl, "h", u_domctl); + break; + default: ret = arch_do_domctl(op, d, u_domctl); break; diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index b2ae839c3632..d4072761791a 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -214,7 +214,10 @@ struct xen_domctl_getpageframeinfo3 { /* Return the bitmap but do not modify internal copy. */ #define XEN_DOMCTL_SHADOW_OP_PEEK 12 -/* Memory allocation accessors. */ +/* + * Memory allocation accessors. These APIs are broken and will be removed. + * Use XEN_DOMCTL_{get,set}_paging_mempool_size instead. + */ #define XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION 30 #define XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION 31 @@ -946,6 +949,22 @@ struct xen_domctl_cacheflush { xen_pfn_t start_pfn, nr_pfns; }; +/* + * XEN_DOMCTL_get_paging_mempool_size / XEN_DOMCTL_set_paging_mempool_size. + * + * Get or set the paging memory pool size. The size is in bytes. + * + * This is a dedicated pool of memory for Xen to use while managing the guest, + * typically containing pagetables. As such, there is an implementation + * specific minimum granularity. + * + * The set operation can fail mid-way through the request (e.g. Xen running + * out of memory, no free memory to reclaim from the pool, etc.). + */ +struct xen_domctl_paging_mempool { + uint64_aligned_t size; /* IN/OUT. Size in bytes. */ +}; + #if defined(__i386__) || defined(__x86_64__) struct xen_domctl_vcpu_msr { uint32_t index; @@ -1274,6 +1293,8 @@ struct xen_domctl { #define XEN_DOMCTL_get_cpu_policy 82 #define XEN_DOMCTL_set_cpu_policy 83 #define XEN_DOMCTL_vmtrace_op 84 +#define XEN_DOMCTL_get_paging_mempool_size 85 +#define XEN_DOMCTL_set_paging_mempool_size 86 #define XEN_DOMCTL_gdbsx_guestmemio 1000 #define XEN_DOMCTL_gdbsx_pausevcpu 1001 #define XEN_DOMCTL_gdbsx_unpausevcpu 1002 @@ -1335,6 +1356,7 @@ struct xen_domctl { struct xen_domctl_psr_alloc psr_alloc; struct xen_domctl_vuart_op vuart_op; struct xen_domctl_vmtrace_op vmtrace_op; + struct xen_domctl_paging_mempool paging_mempool; uint8_t pad[128]; } u; }; diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index 2c8116afba27..0de9cbc1696d 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -98,6 +98,9 @@ void arch_get_info_guest(struct vcpu *, vcpu_guest_context_u); int arch_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg); int default_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg); +int arch_get_paging_mempool_size(struct domain *d, uint64_t *size /* bytes */); +int arch_set_paging_mempool_size(struct domain *d, uint64_t size /* bytes */); + int domain_relinquish_resources(struct domain *d); void dump_pageframe_info(struct domain *d); -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 17 01:08:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 01:08:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444450.699686 (Exim 4.92) (envelope-from ) id 1ovTOC-0002gD-OU; Thu, 17 Nov 2022 01:08:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444450.699686; Thu, 17 Nov 2022 01:08:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovTOC-0002g5-Kf; Thu, 17 Nov 2022 01:08:24 +0000 Received: by outflank-mailman (input) for mailman id 444450; Thu, 17 Nov 2022 01:08:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovTOB-0002PW-5O for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 01:08:23 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52e7fc15-6614-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 02:08:21 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52e7fc15-6614-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668647301; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=J0y9Rl8v0F76CgtxLvCCWe9CUZTAHzzgMbNWoK/a9vE=; b=OvXO2HkbONE1Z0hDSGHAk9F8NJLr+vNru3KFPSn2JFeBjB4MYeYkEVaW zp1vzB3HE1oNrTFpU0lsXQlx3Au8LjqHPNrGWCQxwvZ8NYVvCGtAYM+5E nBMeM92YVLRYJtmPje9UYnEar3FpUnD5j+vAifaK19pGB4BX2G3Mn1P6U U=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84987027 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:vdvjfaw2//tgc/iI9od6t+fDxirEfRIJ4+MujC+fZmUNrF6WrkVUy GsaXzzTMviMamL3Kd10a4S1/UMHvpTUzYNkSgE4rSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPK4T5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVFB9 /YnMS1XVz2ohueKy6qYRvk2lNt2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiFZkEzhnA/ D2uE2LRJTsmGv6Dyyi57FGy2uzOlg/GSpMpC+jtnhJtqALKnTFCYPEMbnOFpv2+hl+7SshoA UUe8SozroA/7EWuCNL6WnWQomOAvxMac8pdFas98g7l4orZ5RyIQFcNSDFpYcYj8sQxQFQC3 FKTg8ngAzAptbSPUG+c7Z+dtzb0Mi8QRUcgTyIZSQoO4/H4vZo+yBnIS75LAKOzy9H4Bzz06 zSLtzQlwaUei9YR0Ke29kyBhCijzrDSVRI87AjTWmOj7yt6aZSjaoju7kLUhd5fKK6JQ1/Hu 2IL8/Vy98hXU8vLznbUBrxQQvf5vJ5pLQEwn3ZfEJsryC2woUeOVoFV3DpmB0t5aNQbLGqBj FDohStd45paPX2PZKBxYp6sB8lC8ZUMBegJRdiPMIMQP8EZmBuvuXg3OBXOhzyFfF0Ey/lXB HuNTSq74Z/244xDxSH+eeoS2KRDKssWlTKKHsCTI/hKPNOjiJ+ppVUtagXmggMRtvnsTODpH zF3aaO3J+13CrGWX8Uu2dd7wJBjBSFT6WrKg8JWbPWfBQFtBXssDfTcqZt4JdI1wf4OyriSo C7nMqO99LYZrSaeQeltQik9AI4DoL4l9S5rVcDSFQvAN4cfjXaHs/5EKspfkUgP/+1/1/9kJ 8TpiO3Zasmii13vpVwgUHUKhNw4JU711FzVbkJIolEXJvZdeuAAwfe8FiOHycXEJnDfWRcWy 1F46j7mfA== IronPort-HdrOrdr: A9a23:2vkR16qalYKO2lisAt5vTZgaV5oTeYIsimQD101hICG8cqSj+f xG+85rrCMc6QxhPk3I9urhBEDtex/hHNtOkOws1NSZLW7bUQmTXeJfBOLZqlWKcUDDH6xmpM NdmsBFeaXN5DNB7PoSjjPWLz9Z+qjkzJyV X-IronPort-AV: E=Sophos;i="5.96,169,1665460800"; d="scan'208";a="84987027" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony PERARD Subject: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls Date: Thu, 17 Nov 2022 01:08:03 +0000 Message-ID: <20221117010804.9384-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221117010804.9384-1-andrew.cooper3@citrix.com> References: <20221117010804.9384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_p2m_pool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Release-acked-by: Henry Wang --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Henry Wang CC: Anthony PERARD v2: * s/p2m/paging/ * Fix get/set typo in libxl__domain_set_p2m_pool_size() --- tools/libs/light/libxl_arm.c | 14 +---------- tools/libs/light/libxl_dom.c | 19 ++++++++++++++ tools/libs/light/libxl_internal.h | 3 +++ tools/libs/light/libxl_x86.c | 15 ++--------- xen/arch/arm/domctl.c | 53 --------------------------------------- xen/arch/arm/include/asm/p2m.h | 1 - xen/arch/arm/p2m.c | 8 ------ 7 files changed, 25 insertions(+), 88 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 2a5e93c28403..2f5615263543 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -209,19 +209,7 @@ int libxl__arch_domain_create(libxl__gc *gc, libxl__domain_build_state *state, uint32_t domid) { - libxl_ctx *ctx = libxl__gc_owner(gc); - unsigned int shadow_mb = DIV_ROUNDUP(d_config->b_info.shadow_memkb, 1024); - - int r = xc_shadow_control(ctx->xch, domid, - XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, - &shadow_mb, 0); - if (r) { - LOGED(ERROR, domid, - "Failed to set %u MiB shadow allocation", shadow_mb); - return ERROR_FAIL; - } - - return 0; + return libxl__domain_set_p2m_pool_size(gc, d_config, domid); } int libxl__arch_extra_memory(libxl__gc *gc, diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c index 2abaab439c4f..f8f7b7e81837 100644 --- a/tools/libs/light/libxl_dom.c +++ b/tools/libs/light/libxl_dom.c @@ -1448,6 +1448,25 @@ int libxl_userdata_unlink(libxl_ctx *ctx, uint32_t domid, return rc; } +int libxl__domain_set_p2m_pool_size( + libxl__gc *gc, libxl_domain_config *d_config, uint32_t domid) +{ + libxl_ctx *ctx = libxl__gc_owner(gc); + uint64_t shadow_mem; + + shadow_mem = d_config->b_info.shadow_memkb; + shadow_mem <<= 10; + + int r = xc_set_paging_mempool_size(ctx->xch, domid, shadow_mem); + if (r) { + LOGED(ERROR, domid, + "Failed to set paging mempool size to %"PRIu64"kB", shadow_mem); + return ERROR_FAIL; + } + + return 0; +} + /* * Local variables: * mode: C diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index cb9e8b3b8b5a..f31164bc6c0d 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -4864,6 +4864,9 @@ int libxl__is_domid_recent(libxl__gc *gc, uint32_t domid, bool *recent); /* os-specific implementation of setresuid() */ int libxl__setresuid(uid_t ruid, uid_t euid, uid_t suid); +_hidden int libxl__domain_set_p2m_pool_size( + libxl__gc *gc, libxl_domain_config *d_config, uint32_t domid); + #endif /* diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c index 7c5ee74443e5..99aba51d05df 100644 --- a/tools/libs/light/libxl_x86.c +++ b/tools/libs/light/libxl_x86.c @@ -538,20 +538,9 @@ int libxl__arch_domain_create(libxl__gc *gc, xc_domain_set_time_offset(ctx->xch, domid, rtc_timeoffset); if (d_config->b_info.type != LIBXL_DOMAIN_TYPE_PV) { - unsigned int shadow_mb = DIV_ROUNDUP(d_config->b_info.shadow_memkb, - 1024); - int r = xc_shadow_control(ctx->xch, domid, - XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, - &shadow_mb, 0); - - if (r) { - LOGED(ERROR, domid, - "Failed to set %u MiB %s allocation", - shadow_mb, - libxl_defbool_val(d_config->c_info.hap) ? "HAP" : "shadow"); - ret = ERROR_FAIL; + ret = libxl__domain_set_p2m_pool_size(gc, d_config, domid); + if (ret) goto out; - } } if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_PV && diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c index c8fdeb124084..1baf25c3d98b 100644 --- a/xen/arch/arm/domctl.c +++ b/xen/arch/arm/domctl.c @@ -47,64 +47,11 @@ static int handle_vuart_init(struct domain *d, return rc; } -static long p2m_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, - XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) -{ - long rc; - bool preempted = false; - - if ( unlikely(d == current->domain) ) - { - printk(XENLOG_ERR "Tried to do a p2m domctl op on itself.\n"); - return -EINVAL; - } - - if ( unlikely(d->is_dying) ) - { - printk(XENLOG_ERR "Tried to do a p2m domctl op on dying domain %u\n", - d->domain_id); - return -EINVAL; - } - - switch ( sc->op ) - { - case XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION: - { - /* Allow and handle preemption */ - spin_lock(&d->arch.paging.lock); - rc = p2m_set_allocation(d, sc->mb << (20 - PAGE_SHIFT), &preempted); - spin_unlock(&d->arch.paging.lock); - - if ( preempted ) - /* Not finished. Set up to re-run the call. */ - rc = hypercall_create_continuation(__HYPERVISOR_domctl, "h", - u_domctl); - else - /* Finished. Return the new allocation. */ - sc->mb = p2m_get_allocation(d); - - return rc; - } - case XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION: - { - sc->mb = p2m_get_allocation(d); - return 0; - } - default: - { - printk(XENLOG_ERR "Bad p2m domctl op %u\n", sc->op); - return -EINVAL; - } - } -} - long arch_do_domctl(struct xen_domctl *domctl, struct domain *d, XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) { switch ( domctl->cmd ) { - case XEN_DOMCTL_shadow_op: - return p2m_domctl(d, &domctl->u.shadow_op, u_domctl); case XEN_DOMCTL_cacheflush: { gfn_t s = _gfn(domctl->u.cacheflush.start_pfn); diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h index c8f14d13c2c5..91df922e1c9f 100644 --- a/xen/arch/arm/include/asm/p2m.h +++ b/xen/arch/arm/include/asm/p2m.h @@ -222,7 +222,6 @@ void p2m_restore_state(struct vcpu *n); /* Print debugging/statistial info about a domain's p2m */ void p2m_dump_info(struct domain *d); -unsigned int p2m_get_allocation(struct domain *d); int p2m_set_allocation(struct domain *d, unsigned long pages, bool *preempted); int p2m_teardown_allocation(struct domain *d); diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 8c1972e58227..b2f7e8d804aa 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -92,14 +92,6 @@ static void p2m_free_page(struct domain *d, struct page_info *pg) spin_unlock(&d->arch.paging.lock); } -/* Return the size of the pool, rounded up to the nearest MB */ -unsigned int p2m_get_allocation(struct domain *d) -{ - unsigned long nr_pages = ACCESS_ONCE(d->arch.paging.p2m_total_pages); - - return ROUNDUP(nr_pages, 1 << (20 - PAGE_SHIFT)) >> (20 - PAGE_SHIFT); -} - /* Return the size of the pool, in bytes. */ int arch_get_paging_mempool_size(struct domain *d, uint64_t *size) { -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 17 01:08:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 01:08:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444452.699700 (Exim 4.92) (envelope-from ) id 1ovTOD-0002vD-Kh; Thu, 17 Nov 2022 01:08:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444452.699700; Thu, 17 Nov 2022 01:08:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovTOD-0002s7-Bx; Thu, 17 Nov 2022 01:08:25 +0000 Received: by outflank-mailman (input) for mailman id 444452; Thu, 17 Nov 2022 01:08:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovTOC-0002PW-CP for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 01:08:24 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 544abed0-6614-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 02:08:23 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 544abed0-6614-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668647303; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ap2hp5WICNPWbnbtbccI6RyBgntjwRWIPNLozuORhLE=; b=KWMGzipBweGURFunZZOb4n5S9B7QG//zgxiZVcIz6KPuo0KrHW6McnnV qrtzBhmZjDuMKuU88mkCDlnvfWszZTgCop/xreKKxYZoC74SMxk1Vi8vR /8pB1fN6xWuSAHodwBVLwHxAUnuluDG0BaNEZQE8XQObGT7wIjDmZ6aQp w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85008573 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:HVS5KKLuDOayhK8qFE+RJZUlxSXFcZb7ZxGr2PjKsXjdYENS1TYCz mMYCzqDbP3YNmfzKt13YYWz8EsOvp+Dz4QxGgJlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wVgPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4uJ1of7 flJEww0Ywygn8Sn35+mVbJV05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLoXmuuyi2a5WDpfsF+P/oI84nTJzRw327/oWDbQUozXHZ0FwxnDz o7A1zjfEwAFOIy88AqI2W2vqbfVxQ31RqtHQdVU8dY12QbOlwT/EiY+a1y/pvWoj1+kbPhWI UcU5ykGoLA78QqgSdyVdx+lpH+JuDYMVtwWFPc1gCmHx7DI+Q+fCi4BRyRYdd09nMYsQHoh0 Vrht/PkAyZ+9oKcT321/62R6zi1PEA9NnQebCUJSQ8E5djLo4wpiB/LCNF5H8adntDzXD393 T2OhCw/nKkIy94G0b2h+lLKiC7qoYLGJiYXzAjKWmOu7itieZWoIYev7DDz8vJoPIufCF6bs xA5d9O2tb5US8vXzWrUHbtLTOrBC+u53CP02HhUToEkpg+RwnO/Xph28S5TOVgyC5NREdP2W 3P7tQRU7Z5VGXKla65rfo68Y/gXIbjc+cfNDa6NMIcXCnRlXErepXw1OxbMt4z4uBJ0+ZzTL 6t3ZipF4ZwyLa18hAS7SO4GuVPA7nBvnDiDLXwXIvnO7FZ/WJJ3Ye1bWLdtRrpjhE9hnOky2 4g3Cidy408DONASmwGOmWPTRHhTRZTBObj4qtZMasmIKRd8FWcqBpf5mO1/K9I/xPgKzLmXp BlRv3O0LnKk3BUrzi3TNBhehE7HB84j/RrXwwRxVbpX55TTSdn2t/pOH3fGVbIm6PZi3ZZJo wotIq297zUmYmqvxgnxmrGt9t04KkX13lPm0ujMSGFXQqOMjjfhorfMFjYDPgFXZsZrnaPSe 4Gd6z4= IronPort-HdrOrdr: A9a23:q8GjOK5QtxsrF6uzNgPXwM7XdLJyesId70hD6qhwISY7TiX+rb HJoB17726StN9/YhAdcLy7VZVoBEmsl6KdgrNhWYtKPjOHhILAFugLhuHfKn/bakjDH4ZmpN 5dmsNFZuEYY2IXsS+D2njaL+od X-IronPort-AV: E=Sophos;i="5.96,169,1665460800"; d="scan'208";a="85008573" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony PERARD Subject: [PATCH 4/4] xen/arm: Correct the p2m pool size calculations Date: Thu, 17 Nov 2022 01:08:04 +0000 Message-ID: <20221117010804.9384-5-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221117010804.9384-1-andrew.cooper3@citrix.com> References: <20221117010804.9384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Henry Wang CC: Anthony PERARD --- xen/arch/arm/p2m.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index b2f7e8d804aa..9bc5443d9e8a 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -72,7 +72,6 @@ static struct page_info *p2m_alloc_page(struct domain *d) spin_unlock(&d->arch.paging.lock); return NULL; } - d->arch.paging.p2m_total_pages--; } spin_unlock(&d->arch.paging.lock); @@ -85,10 +84,7 @@ static void p2m_free_page(struct domain *d, struct page_info *pg) if ( is_hardware_domain(d) ) free_domheap_page(pg); else - { - d->arch.paging.p2m_total_pages++; page_list_add_tail(pg, &d->arch.paging.p2m_freelist); - } spin_unlock(&d->arch.paging.lock); } -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 17 01:08:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 01:08:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444453.699718 (Exim 4.92) (envelope-from ) id 1ovTOQ-0003sl-ST; Thu, 17 Nov 2022 01:08:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444453.699718; Thu, 17 Nov 2022 01:08:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovTOQ-0003sU-Od; Thu, 17 Nov 2022 01:08:38 +0000 Received: by outflank-mailman (input) for mailman id 444453; Thu, 17 Nov 2022 01:08:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovTOO-0002PW-Kd for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 01:08:36 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5b64a19f-6614-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 02:08:35 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b64a19f-6614-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668647315; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LGNXYRbqu08/x18C0o33vlfzJWuGN3UVgv27ZYimOA4=; b=MDxUSFVXro9+EaaZhXO//XMg3+sYibSmj/lZgtU0wUJCPle1AXhW57v2 rxDS8SFfgPQPGVv+Y/Le602iQY3O4huZJH3VsZoB+/xqTuUVuorfsWULG AMLJ4shL7x7wPPGwrm+dYJKpZXIkCra/fvd8ifYVE3t/wwlOzo9pLClYv E=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85413939 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:WvCOHaDjMoFcAhVW/97jw5YqxClBgxIJ4kV8jS/XYbTApDtx0TEHm GUdD2+BMqqOMDCkfN4ja9vk8U9TsJHSydI2QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpB4ARlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwyMMsHCIR1 NokdGoddzyKg+GE7qyZc7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/IZQyhuq3wFL4dCVVsgm9rqsr+WnDigd21dABNfKFJ4DTHpQOzy50o ErW32SiAQoAGeW9lzPUqm+JvNDCmzjSDdd6+LqQqacx3Qz7KnYoICMRUVy3sPyokHmUUthUK 1EX0ic2pK10/0uuJvH/Qhm5rXisrhMaHd1KHIUSyAyL0LuS3A+fCUANVDsHY9sj3Oc8SCY2z FaPk5XsDCZ2rbyOYXuH8/GfqjbaEQo/IHIGZCQEZRAY+NSlq4Y25jrfQ9AmHKOrg9ndHTDr3 yvMvCU4n68Uj8MAy+O851+vqym3upHDQwox5wPWdmGo9AV0YMiifYPAwUffxeZNKsCeVFbpg ZQfs5HAtqZUV8jLzXHTBrVWdF202xqbGA/52kMsQLgHy2j362ePdIRT0h9gBn48Z67oZgTVS EPUvApQ4rpaM32rcbJ7buqNNig68UTzPY+7D66JN7KidrA0LVbap382OSZ8yki3yCARfbcD1 YB3mCpGJVITEuxZwTW/XI/xOpd7l3lllQs/qX0WpilLMIZyhlbPF9/p03PUNIjVCZ9oRy2Lm +uzz+PQl31ivBTWO0E6Mec7dDjm10QTC5HssNBwfeWeOAdgE2xJI6aPn+N/Idc5wP4Lyb2gE pSBtqlwkwOXaZrvcFviV5yeQOm3AcYXQYwTYETAwmpEK1B8ON3yvc/zhrM8fKU99fwL8BKHZ 6BtRihBa9wRIgn6F8M1PcOs9tIzKk/67e9MVgL8CAUCk1dbb1Sh0rfZksHHrXJm4vaf3Sfmn 4Cd6w== IronPort-HdrOrdr: A9a23:/VcpnKFuJTZcwOcmpLqE0MeALOsnbusQ8zAXP0AYc3Jom6uj5r mTdZUgpHnJYVkqOE3I9ertBEDEewK4yXcX2/h3AV7BZniEhILAFugLhuGO/9SjIVybygc079 YZT0EUMrzN5DZB4voSmDPIceod/A== X-IronPort-AV: E=Sophos;i="5.96,169,1665460800"; d="scan'208";a="85413939" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony PERARD Subject: [PATCH 2/4] tools/tests: Unit test for paging mempool size Date: Thu, 17 Nov 2022 01:08:02 +0000 Message-ID: <20221117010804.9384-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221117010804.9384-1-andrew.cooper3@citrix.com> References: <20221117010804.9384-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Release-acked-by: Henry Wang --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: Henry Wang CC: Anthony PERARD x86 Shadow is complicated because of how it behaves for PV guests, and because of how it forms a simultaneous equation with tot_pages. This will require more work to untangle. v2: * s/p2m/paging/ * Fix CFLAGS_libxenforeginmemory typo --- tools/tests/Makefile | 1 + tools/tests/paging-mempool/.gitignore | 1 + tools/tests/paging-mempool/Makefile | 42 ++++++ tools/tests/paging-mempool/test-paging-mempool.c | 181 +++++++++++++++++++++++ 4 files changed, 225 insertions(+) create mode 100644 tools/tests/paging-mempool/.gitignore create mode 100644 tools/tests/paging-mempool/Makefile create mode 100644 tools/tests/paging-mempool/test-paging-mempool.c diff --git a/tools/tests/Makefile b/tools/tests/Makefile index d99146d56a64..1319c3a9d88c 100644 --- a/tools/tests/Makefile +++ b/tools/tests/Makefile @@ -11,6 +11,7 @@ endif SUBDIRS-y += xenstore SUBDIRS-y += depriv SUBDIRS-y += vpci +SUBDIRS-y += paging-mempool .PHONY: all clean install distclean uninstall all clean distclean install uninstall: %: subdirs-% diff --git a/tools/tests/paging-mempool/.gitignore b/tools/tests/paging-mempool/.gitignore new file mode 100644 index 000000000000..2f9305b7cc07 --- /dev/null +++ b/tools/tests/paging-mempool/.gitignore @@ -0,0 +1 @@ +test-paging-mempool diff --git a/tools/tests/paging-mempool/Makefile b/tools/tests/paging-mempool/Makefile new file mode 100644 index 000000000000..5d49497710e0 --- /dev/null +++ b/tools/tests/paging-mempool/Makefile @@ -0,0 +1,42 @@ +XEN_ROOT = $(CURDIR)/../../.. +include $(XEN_ROOT)/tools/Rules.mk + +TARGET := test-paging-mempool + +.PHONY: all +all: $(TARGET) + +.PHONY: clean +clean: + $(RM) -- *.o $(TARGET) $(DEPS_RM) + +.PHONY: distclean +distclean: clean + $(RM) -- *~ + +.PHONY: install +install: all + $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN) + $(INSTALL_PROG) $(TARGET) $(DESTDIR)$(LIBEXEC_BIN) + +.PHONY: uninstall +uninstall: + $(RM) -- $(DESTDIR)$(LIBEXEC_BIN)/$(TARGET) + +CFLAGS += $(CFLAGS_xeninclude) +CFLAGS += $(CFLAGS_libxenctrl) +CFLAGS += $(CFLAGS_libxenforeignmemory) +CFLAGS += $(CFLAGS_libxengnttab) +CFLAGS += $(APPEND_CFLAGS) + +LDFLAGS += $(LDLIBS_libxenctrl) +LDFLAGS += $(LDLIBS_libxenforeignmemory) +LDFLAGS += $(LDLIBS_libxengnttab) +LDFLAGS += $(APPEND_LDFLAGS) + +%.o: Makefile + +$(TARGET): test-paging-mempool.o + $(CC) -o $@ $< $(LDFLAGS) + +-include $(DEPS_INCLUDE) diff --git a/tools/tests/paging-mempool/test-paging-mempool.c b/tools/tests/paging-mempool/test-paging-mempool.c new file mode 100644 index 000000000000..942a2fde19c7 --- /dev/null +++ b/tools/tests/paging-mempool/test-paging-mempool.c @@ -0,0 +1,181 @@ +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include + +static unsigned int nr_failures; +#define fail(fmt, ...) \ +({ \ + nr_failures++; \ + (void)printf(fmt, ##__VA_ARGS__); \ +}) + +static xc_interface *xch; +static uint32_t domid; + +static struct xen_domctl_createdomain create = { + .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, + .max_vcpus = 1, + .max_grant_frames = 1, + .grant_opts = XEN_DOMCTL_GRANT_version(1), + + .arch = { +#if defined(__x86_64__) || defined(__i386__) + .emulation_flags = XEN_X86_EMU_LAPIC, +#endif + }, +}; + +static uint64_t default_mempool_size_bytes = +#if defined(__x86_64__) || defined(__i386__) + 256 << 12; /* Only x86 HAP for now. x86 Shadow needs more work. */ +#elif defined (__arm__) || defined(__aarch64__) + 16 << 12; +#endif + +static void run_tests(void) +{ + xen_pfn_t physmap[] = { 0 }; + uint64_t size_bytes, old_size_bytes; + int rc; + + printf("Test default mempool size\n"); + + rc = xc_get_paging_mempool_size(xch, domid, &size_bytes); + if ( rc ) + return fail(" Fail: get mempool size: %d - %s\n", + errno, strerror(errno)); + + printf("mempool size %"PRIu64" bytes (%"PRIu64"kB, %"PRIu64"MB)\n", + size_bytes, size_bytes >> 10, size_bytes >> 20); + + + /* + * Check that the domain has the expected default allocation size. This + * will fail if the logic in Xen is altered without an equivelent + * adjustment here. + */ + if ( size_bytes != default_mempool_size_bytes ) + return fail(" Fail: size %"PRIu64" != expected size %"PRIu64"\n", + size_bytes, default_mempool_size_bytes); + + + printf("Test that allocate doesn't alter pool size\n"); + + /* + * Populate the domain with some RAM. This will cause more of the mempool + * to be used. + */ + old_size_bytes = size_bytes; + + rc = xc_domain_setmaxmem(xch, domid, -1); + if ( rc ) + return fail(" Fail: setmaxmem: : %d - %s\n", + errno, strerror(errno)); + + rc = xc_domain_populate_physmap_exact(xch, domid, 1, 0, 0, physmap); + if ( rc ) + return fail(" Fail: populate physmap: %d - %s\n", + errno, strerror(errno)); + + /* + * Re-get the p2m size. Should not have changed as a consequence of + * populate physmap. + */ + rc = xc_get_paging_mempool_size(xch, domid, &size_bytes); + if ( rc ) + return fail(" Fail: get mempool size: %d - %s\n", + errno, strerror(errno)); + + if ( old_size_bytes != size_bytes ) + return fail(" Fail: mempool size changed %"PRIu64" => %"PRIu64"\n", + old_size_bytes, size_bytes); + + + + printf("Test bad set size\n"); + + /* + * Check that setting a non-page size results in failure. + */ + rc = xc_set_paging_mempool_size(xch, domid, size_bytes + 1); + if ( rc != -1 || errno != EINVAL ) + return fail(" Fail: Bad set size: expected -1/EINVAL, got %d/%d - %s\n", + rc, errno, strerror(errno)); + + + printf("Test very large set size\n"); + + /* + * Check that setting a large P2M size succeeds. This is expecting to + * trigger continuations. + */ + rc = xc_set_paging_mempool_size(xch, domid, 64 << 20); + if ( rc ) + return fail(" Fail: Set size 64MB: %d - %s\n", + errno, strerror(errno)); + + + /* + * Check that the reported size matches what set consumed. + */ + rc = xc_get_paging_mempool_size(xch, domid, &size_bytes); + if ( rc ) + return fail(" Fail: get p2m mempool size: %d - %s\n", + errno, strerror(errno)); + + if ( size_bytes != 64 << 20 ) + return fail(" Fail: expected mempool size %u, got %"PRIu64"\n", + 64 << 20, size_bytes); +} + +int main(int argc, char **argv) +{ + int rc; + + printf("Paging mempool tests\n"); + + xch = xc_interface_open(NULL, NULL, 0); + + if ( !xch ) + err(1, "xc_interface_open"); + + rc = xc_domain_create(xch, &domid, &create); + if ( rc ) + { + if ( errno == EINVAL || errno == EOPNOTSUPP ) + printf(" Skip: %d - %s\n", errno, strerror(errno)); + else + fail(" Domain create failure: %d - %s\n", + errno, strerror(errno)); + goto out; + } + + printf(" Created d%u\n", domid); + + run_tests(); + + rc = xc_domain_destroy(xch, domid); + if ( rc ) + fail(" Failed to destroy domain: %d - %s\n", + errno, strerror(errno)); + out: + return !!nr_failures; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 17 02:09:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 02:09:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444475.699730 (Exim 4.92) (envelope-from ) id 1ovUKq-0004WB-7d; Thu, 17 Nov 2022 02:09:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444475.699730; Thu, 17 Nov 2022 02:09:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovUKq-0004W4-3f; Thu, 17 Nov 2022 02:09:00 +0000 Received: by outflank-mailman (input) for mailman id 444475; Thu, 17 Nov 2022 02:08:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovUKo-0004Vf-5d for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 02:08:58 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c9368a22-661c-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 03:08:55 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 75D3762056; Thu, 17 Nov 2022 02:08:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AB05C433C1; Thu, 17 Nov 2022 02:08:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9368a22-661c-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668650932; bh=E5J2oCWjL5upj0kxVy125vURFslPgRDuNAy1T7C5oRw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=DaSUxyjuCFxtwYQ/ijAcWveF/H+lUQvJu+puOMNQbLcR8eA55WBkEU9iR4T/KJ9wR LajliDDwSsA6qSTnjNANBT8k/DpKHYxdaLyZEMexYZJuoohQc/vHVxycHESzzMZok8 dzcPKL/YBUF4TN5C7g2etsb7Qd/7q+R109nCJDGxsuHHT/Lo+oOIe1MZS0H8dBU/UR ITI4QfaEW952J1voamoDg1bZ8OwIwVVmK/gWfSz15yQ8kFnT5cQ053cLVx0+Am+/3V +jh5gASC9ZKFo4TVUIspFRTH5CMnDwaYwFoR0vMlkm77yYHsZgEENJjrE5paPo9VZr Kk8AdIsJGWObQ== Date: Wed, 16 Nov 2022 18:08:49 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Xen-devel , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony PERARD Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the paging mempool size In-Reply-To: <20221117010804.9384-2-andrew.cooper3@citrix.com> Message-ID: References: <20221117010804.9384-1-andrew.cooper3@citrix.com> <20221117010804.9384-2-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-872934346-1668650932=:4020" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-872934346-1668650932=:4020 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 17 Nov 2022, Andrew Cooper wrote: > The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: > > * All set_allocation() flavours have an overflow-before-widen bug when > calculating "sc->mb << (20 - PAGE_SHIFT)". > * All flavours have a granularity of 1M. This was tolerable when the size of > the pool could only be set at the same granularity, but is broken now that > ARM has a 16-page stopgap allocation in use. > * All get_allocation() flavours round up, and in particular turn 0 into 1, > meaning the get op returns junk before a successful set op. > * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, > despite the pool size being a domain property. > * Even the hypercall names are long-obsolete. > > Implement a better interface, which can be first used to unit test the > behaviour, and subsequently correct a broken implementation. The old > interface will be retired in due course. > > The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to > more easily support multiple page granularities. > > This is part of XSA-409 / CVE-2022-33747. > > Signed-off-by: Andrew Cooper > Release-acked-by: Henry Wang ARM side: Reviewed-by: Stefano Stabellini > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > CC: Stefano Stabellini > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Bertrand Marquis > CC: Henry Wang > CC: Anthony PERARD > > v2: > * s/p2m/paging/ > * Fix overflow-before-widen in ARM's arch_get_p2m_mempool_size() > * Fix overflow-before-widen in both {hap,shadow}_get_allocation_bytes() > * Leave a TODO about x86/PV, drop assertion. > * Check for long->int truncation in x86's arch_set_paging_mempool_size() > > Future TODOs: > * x86 shadow still rounds up. This is buggy as it's a simultaneous equation > with tot_pages which varies over time with ballooning. > * x86 PV is weird. There are no toolstack interact with the shadow pool > size, but the "shadow" pool it does come into existence when logdirty (or > pv-l1tf) when first enabled. > * The shadow+hap logic is in desperate need of deduping. > --- > tools/include/xenctrl.h | 3 +++ > tools/libs/ctrl/xc_domain.c | 29 ++++++++++++++++++++++++++ > xen/arch/arm/p2m.c | 26 +++++++++++++++++++++++ > xen/arch/x86/include/asm/hap.h | 1 + > xen/arch/x86/include/asm/shadow.h | 4 ++++ > xen/arch/x86/mm/hap/hap.c | 11 ++++++++++ > xen/arch/x86/mm/paging.c | 43 +++++++++++++++++++++++++++++++++++++++ > xen/arch/x86/mm/shadow/common.c | 11 ++++++++++ > xen/common/domctl.c | 14 +++++++++++++ > xen/include/public/domctl.h | 24 +++++++++++++++++++++- > xen/include/xen/domain.h | 3 +++ > 11 files changed, 168 insertions(+), 1 deletion(-) > > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h > index 0c8b4c3aa7a5..23037874d3d5 100644 > --- a/tools/include/xenctrl.h > +++ b/tools/include/xenctrl.h > @@ -893,6 +893,9 @@ long long xc_logdirty_control(xc_interface *xch, > unsigned int mode, > xc_shadow_op_stats_t *stats); > > +int xc_get_paging_mempool_size(xc_interface *xch, uint32_t domid, uint64_t *size); > +int xc_set_paging_mempool_size(xc_interface *xch, uint32_t domid, uint64_t size); > + > int xc_sched_credit_domain_set(xc_interface *xch, > uint32_t domid, > struct xen_domctl_sched_credit *sdom); > diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c > index 14c0420c35be..e939d0715739 100644 > --- a/tools/libs/ctrl/xc_domain.c > +++ b/tools/libs/ctrl/xc_domain.c > @@ -706,6 +706,35 @@ long long xc_logdirty_control(xc_interface *xch, > return (rc == 0) ? domctl.u.shadow_op.pages : rc; > } > > +int xc_get_paging_mempool_size(xc_interface *xch, uint32_t domid, uint64_t *size) > +{ > + int rc; > + struct xen_domctl domctl = { > + .cmd = XEN_DOMCTL_get_paging_mempool_size, > + .domain = domid, > + }; > + > + rc = do_domctl(xch, &domctl); > + if ( rc ) > + return rc; > + > + *size = domctl.u.paging_mempool.size; > + return 0; > +} > + > +int xc_set_paging_mempool_size(xc_interface *xch, uint32_t domid, uint64_t size) > +{ > + struct xen_domctl domctl = { > + .cmd = XEN_DOMCTL_set_paging_mempool_size, > + .domain = domid, > + .u.paging_mempool = { > + .size = size, > + }, > + }; > + > + return do_domctl(xch, &domctl); > +} > + > int xc_domain_setmaxmem(xc_interface *xch, > uint32_t domid, > uint64_t max_memkb) > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > index 94d3b60b1387..8c1972e58227 100644 > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -100,6 +100,13 @@ unsigned int p2m_get_allocation(struct domain *d) > return ROUNDUP(nr_pages, 1 << (20 - PAGE_SHIFT)) >> (20 - PAGE_SHIFT); > } > > +/* Return the size of the pool, in bytes. */ > +int arch_get_paging_mempool_size(struct domain *d, uint64_t *size) > +{ > + *size = (uint64_t)ACCESS_ONCE(d->arch.paging.p2m_total_pages) << PAGE_SHIFT; > + return 0; > +} > + > /* > * Set the pool of pages to the required number of pages. > * Returns 0 for success, non-zero for failure. > @@ -157,6 +164,25 @@ int p2m_set_allocation(struct domain *d, unsigned long pages, bool *preempted) > return 0; > } > > +int arch_set_paging_mempool_size(struct domain *d, uint64_t size) > +{ > + unsigned long pages = size >> PAGE_SHIFT; > + bool preempted = false; > + int rc; > + > + if ( (size & ~PAGE_MASK) || /* Non page-sized request? */ > + pages != (size >> PAGE_SHIFT) ) /* 32-bit overflow? */ > + return -EINVAL; > + > + spin_lock(&d->arch.paging.lock); > + rc = p2m_set_allocation(d, pages, &preempted); > + spin_unlock(&d->arch.paging.lock); > + > + ASSERT(preempted == (rc == -ERESTART)); > + > + return rc; > +} > + > int p2m_teardown_allocation(struct domain *d) > { > int ret = 0; > diff --git a/xen/arch/x86/include/asm/hap.h b/xen/arch/x86/include/asm/hap.h > index 90dece29deca..14d2f212dab9 100644 > --- a/xen/arch/x86/include/asm/hap.h > +++ b/xen/arch/x86/include/asm/hap.h > @@ -47,6 +47,7 @@ int hap_track_dirty_vram(struct domain *d, > extern const struct paging_mode *hap_paging_get_mode(struct vcpu *); > int hap_set_allocation(struct domain *d, unsigned int pages, bool *preempted); > unsigned int hap_get_allocation(struct domain *d); > +int hap_get_allocation_bytes(struct domain *d, uint64_t *size); > > #endif /* XEN_HAP_H */ > > diff --git a/xen/arch/x86/include/asm/shadow.h b/xen/arch/x86/include/asm/shadow.h > index 1365fe480518..dad876d29499 100644 > --- a/xen/arch/x86/include/asm/shadow.h > +++ b/xen/arch/x86/include/asm/shadow.h > @@ -97,6 +97,8 @@ void shadow_blow_tables_per_domain(struct domain *d); > int shadow_set_allocation(struct domain *d, unsigned int pages, > bool *preempted); > > +int shadow_get_allocation_bytes(struct domain *d, uint64_t *size); > + > #else /* !CONFIG_SHADOW_PAGING */ > > #define shadow_vcpu_teardown(v) ASSERT(is_pv_vcpu(v)) > @@ -108,6 +110,8 @@ int shadow_set_allocation(struct domain *d, unsigned int pages, > ({ ASSERT_UNREACHABLE(); -EOPNOTSUPP; }) > #define shadow_set_allocation(d, pages, preempted) \ > ({ ASSERT_UNREACHABLE(); -EOPNOTSUPP; }) > +#define shadow_get_allocation_bytes(d, size) \ > + ({ ASSERT_UNREACHABLE(); -EOPNOTSUPP; }) > > static inline void sh_remove_shadows(struct domain *d, mfn_t gmfn, > int fast, int all) {} > diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c > index f809ea9aa6ae..0fc1b1d9aced 100644 > --- a/xen/arch/x86/mm/hap/hap.c > +++ b/xen/arch/x86/mm/hap/hap.c > @@ -345,6 +345,17 @@ unsigned int hap_get_allocation(struct domain *d) > + ((pg & ((1 << (20 - PAGE_SHIFT)) - 1)) ? 1 : 0)); > } > > +int hap_get_allocation_bytes(struct domain *d, uint64_t *size) > +{ > + unsigned long pages = d->arch.paging.hap.total_pages; > + > + pages += d->arch.paging.hap.p2m_pages; > + > + *size = pages << PAGE_SHIFT; > + > + return 0; > +} > + > /* Set the pool of pages to the required number of pages. > * Returns 0 for success, non-zero for failure. */ > int hap_set_allocation(struct domain *d, unsigned int pages, bool *preempted) > diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c > index 3a355eee9ca3..8d579fa9a3e8 100644 > --- a/xen/arch/x86/mm/paging.c > +++ b/xen/arch/x86/mm/paging.c > @@ -977,6 +977,49 @@ int __init paging_set_allocation(struct domain *d, unsigned int pages, > } > #endif > > +int arch_get_paging_mempool_size(struct domain *d, uint64_t *size) > +{ > + int rc; > + > + if ( is_pv_domain(d) ) /* TODO: Relax in due course */ > + return -EOPNOTSUPP; > + > + if ( hap_enabled(d) ) > + rc = hap_get_allocation_bytes(d, size); > + else > + rc = shadow_get_allocation_bytes(d, size); > + > + return rc; > +} > + > +int arch_set_paging_mempool_size(struct domain *d, uint64_t size) > +{ > + unsigned long pages = size >> PAGE_SHIFT; > + bool preempted = false; > + int rc; > + > + if ( is_pv_domain(d) ) /* TODO: Relax in due course */ > + return -EOPNOTSUPP; > + > + if ( size & ~PAGE_MASK || /* Non page-sized request? */ > + pages != (unsigned int)pages ) /* Overflow $X_set_allocation()? */ > + return -EINVAL; > + > + paging_lock(d); > + if ( hap_enabled(d) ) > + rc = hap_set_allocation(d, pages, &preempted); > + else > + rc = shadow_set_allocation(d, pages, &preempted); > + paging_unlock(d); > + > + /* > + * TODO: Adjust $X_set_allocation() so this is true. > + ASSERT(preempted == (rc == -ERESTART)); > + */ > + > + return preempted ? -ERESTART : rc; > +} > + > /* > * Local variables: > * mode: C > diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c > index badfd53c6b23..a8404f97f668 100644 > --- a/xen/arch/x86/mm/shadow/common.c > +++ b/xen/arch/x86/mm/shadow/common.c > @@ -1427,6 +1427,17 @@ static unsigned int shadow_get_allocation(struct domain *d) > + ((pg & ((1 << (20 - PAGE_SHIFT)) - 1)) ? 1 : 0)); > } > > +int shadow_get_allocation_bytes(struct domain *d, uint64_t *size) > +{ > + unsigned long pages = d->arch.paging.shadow.total_pages; > + > + pages += d->arch.paging.shadow.p2m_pages; > + > + *size = pages << PAGE_SHIFT; > + > + return 0; > +} > + > /**************************************************************************/ > /* Hash table for storing the guest->shadow mappings. > * The table itself is an array of pointers to shadows; the shadows are then > diff --git a/xen/common/domctl.c b/xen/common/domctl.c > index 69fb9abd346f..ad71ad8a4cc5 100644 > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -874,6 +874,20 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > ret = iommu_do_domctl(op, d, u_domctl); > break; > > + case XEN_DOMCTL_get_paging_mempool_size: > + ret = arch_get_paging_mempool_size(d, &op->u.paging_mempool.size); > + if ( !ret ) > + copyback = 1; > + break; > + > + case XEN_DOMCTL_set_paging_mempool_size: > + ret = arch_set_paging_mempool_size(d, op->u.paging_mempool.size); > + > + if ( ret == -ERESTART ) > + ret = hypercall_create_continuation( > + __HYPERVISOR_domctl, "h", u_domctl); > + break; > + > default: > ret = arch_do_domctl(op, d, u_domctl); > break; > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h > index b2ae839c3632..d4072761791a 100644 > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -214,7 +214,10 @@ struct xen_domctl_getpageframeinfo3 { > /* Return the bitmap but do not modify internal copy. */ > #define XEN_DOMCTL_SHADOW_OP_PEEK 12 > > -/* Memory allocation accessors. */ > +/* > + * Memory allocation accessors. These APIs are broken and will be removed. > + * Use XEN_DOMCTL_{get,set}_paging_mempool_size instead. > + */ > #define XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION 30 > #define XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION 31 > > @@ -946,6 +949,22 @@ struct xen_domctl_cacheflush { > xen_pfn_t start_pfn, nr_pfns; > }; > > +/* > + * XEN_DOMCTL_get_paging_mempool_size / XEN_DOMCTL_set_paging_mempool_size. > + * > + * Get or set the paging memory pool size. The size is in bytes. > + * > + * This is a dedicated pool of memory for Xen to use while managing the guest, > + * typically containing pagetables. As such, there is an implementation > + * specific minimum granularity. > + * > + * The set operation can fail mid-way through the request (e.g. Xen running > + * out of memory, no free memory to reclaim from the pool, etc.). > + */ > +struct xen_domctl_paging_mempool { > + uint64_aligned_t size; /* IN/OUT. Size in bytes. */ > +}; > + > #if defined(__i386__) || defined(__x86_64__) > struct xen_domctl_vcpu_msr { > uint32_t index; > @@ -1274,6 +1293,8 @@ struct xen_domctl { > #define XEN_DOMCTL_get_cpu_policy 82 > #define XEN_DOMCTL_set_cpu_policy 83 > #define XEN_DOMCTL_vmtrace_op 84 > +#define XEN_DOMCTL_get_paging_mempool_size 85 > +#define XEN_DOMCTL_set_paging_mempool_size 86 > #define XEN_DOMCTL_gdbsx_guestmemio 1000 > #define XEN_DOMCTL_gdbsx_pausevcpu 1001 > #define XEN_DOMCTL_gdbsx_unpausevcpu 1002 > @@ -1335,6 +1356,7 @@ struct xen_domctl { > struct xen_domctl_psr_alloc psr_alloc; > struct xen_domctl_vuart_op vuart_op; > struct xen_domctl_vmtrace_op vmtrace_op; > + struct xen_domctl_paging_mempool paging_mempool; > uint8_t pad[128]; > } u; > }; > diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h > index 2c8116afba27..0de9cbc1696d 100644 > --- a/xen/include/xen/domain.h > +++ b/xen/include/xen/domain.h > @@ -98,6 +98,9 @@ void arch_get_info_guest(struct vcpu *, vcpu_guest_context_u); > int arch_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg); > int default_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg); > > +int arch_get_paging_mempool_size(struct domain *d, uint64_t *size /* bytes */); > +int arch_set_paging_mempool_size(struct domain *d, uint64_t size /* bytes */); > + > int domain_relinquish_resources(struct domain *d); > > void dump_pageframe_info(struct domain *d); > -- > 2.11.0 > --8323329-872934346-1668650932=:4020-- From xen-devel-bounces@lists.xenproject.org Thu Nov 17 02:12:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 02:12:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444479.699741 (Exim 4.92) (envelope-from ) id 1ovUOa-0006FJ-Rw; Thu, 17 Nov 2022 02:12:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444479.699741; Thu, 17 Nov 2022 02:12:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovUOa-0006FC-PE; Thu, 17 Nov 2022 02:12:52 +0000 Received: by outflank-mailman (input) for mailman id 444479; Thu, 17 Nov 2022 02:12:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovUOZ-0006F6-TR for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 02:12:51 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5515d5be-661d-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 03:12:50 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 38CC8CE1D30; Thu, 17 Nov 2022 02:12:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F689C433D7; Thu, 17 Nov 2022 02:12:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5515d5be-661d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668651165; bh=hBdHoivtfVVeSZj8hyq3nxHJX6wKOCcBqdQ9kS6B7ug=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=vOtOjgcmBr7VHnpnTOiLhJZUwSkO7xKHdtaperUewh6IGcYrEGa18YHx8C1lgGlcu dsCNpqgVk72PiyzEO/DgYQeTaBjKGoPqTPBi2BJXdVWxhbv5+JSh2jQB9SQ98MAwrv Npf9PlqXBJTBJgf+K6dwFr2XKfpTwF3UEvQW2WwL2+hQfk1OHRfKM3MT8iVr4hVuJV npSWYtIFnBsRDT6imnU7HEQOKG9c5TvS28o24J8/YSIkgvGPk8fdhJ0z/HAZw+dYjH vTDwd/3pFwgYSm7lNF7YzU8aceWFHFfNklixkkEoZgIJ3HAsV2Gcodb0fdR3egNd6g fM33pwnwHhEgg== Date: Wed, 16 Nov 2022 18:12:42 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Xen-devel , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony PERARD Subject: Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls In-Reply-To: <20221117010804.9384-4-andrew.cooper3@citrix.com> Message-ID: References: <20221117010804.9384-1-andrew.cooper3@citrix.com> <20221117010804.9384-4-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1008032645-1668651165=:4020" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1008032645-1668651165=:4020 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 17 Nov 2022, Andrew Cooper wrote: > This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits > of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. > > First of all, with ARM borrowing x86's implementation, the logic to set the > pool size should have been common, not duplicated. Introduce > libxl__domain_set_p2m_pool_size() as a shared implementation, and use it from > the ARM and x86 paths. It is left as an exercise to the reader to judge how > libxl/xl can reasonably function without the ability to query the pool size... > > Remove ARM's p2m_domctl() infrastructure now the functioanlity has been > replaced with a working and unit tested interface. > > This is part of XSA-409 / CVE-2022-33747. > > Signed-off-by: Andrew Cooper > Release-acked-by: Henry Wang Reviewed-by: Stefano Stabellini > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > CC: Stefano Stabellini > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Bertrand Marquis > CC: Henry Wang > CC: Anthony PERARD > > v2: > * s/p2m/paging/ > * Fix get/set typo in libxl__domain_set_p2m_pool_size() > --- > tools/libs/light/libxl_arm.c | 14 +---------- > tools/libs/light/libxl_dom.c | 19 ++++++++++++++ > tools/libs/light/libxl_internal.h | 3 +++ > tools/libs/light/libxl_x86.c | 15 ++--------- > xen/arch/arm/domctl.c | 53 --------------------------------------- > xen/arch/arm/include/asm/p2m.h | 1 - > xen/arch/arm/p2m.c | 8 ------ > 7 files changed, 25 insertions(+), 88 deletions(-) > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index 2a5e93c28403..2f5615263543 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -209,19 +209,7 @@ int libxl__arch_domain_create(libxl__gc *gc, > libxl__domain_build_state *state, > uint32_t domid) > { > - libxl_ctx *ctx = libxl__gc_owner(gc); > - unsigned int shadow_mb = DIV_ROUNDUP(d_config->b_info.shadow_memkb, 1024); > - > - int r = xc_shadow_control(ctx->xch, domid, > - XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, > - &shadow_mb, 0); > - if (r) { > - LOGED(ERROR, domid, > - "Failed to set %u MiB shadow allocation", shadow_mb); > - return ERROR_FAIL; > - } > - > - return 0; > + return libxl__domain_set_p2m_pool_size(gc, d_config, domid); > } > > int libxl__arch_extra_memory(libxl__gc *gc, > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c > index 2abaab439c4f..f8f7b7e81837 100644 > --- a/tools/libs/light/libxl_dom.c > +++ b/tools/libs/light/libxl_dom.c > @@ -1448,6 +1448,25 @@ int libxl_userdata_unlink(libxl_ctx *ctx, uint32_t domid, > return rc; > } > > +int libxl__domain_set_p2m_pool_size( > + libxl__gc *gc, libxl_domain_config *d_config, uint32_t domid) > +{ > + libxl_ctx *ctx = libxl__gc_owner(gc); > + uint64_t shadow_mem; > + > + shadow_mem = d_config->b_info.shadow_memkb; > + shadow_mem <<= 10; > + > + int r = xc_set_paging_mempool_size(ctx->xch, domid, shadow_mem); > + if (r) { > + LOGED(ERROR, domid, > + "Failed to set paging mempool size to %"PRIu64"kB", shadow_mem); > + return ERROR_FAIL; > + } > + > + return 0; > +} > + > /* > * Local variables: > * mode: C > diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h > index cb9e8b3b8b5a..f31164bc6c0d 100644 > --- a/tools/libs/light/libxl_internal.h > +++ b/tools/libs/light/libxl_internal.h > @@ -4864,6 +4864,9 @@ int libxl__is_domid_recent(libxl__gc *gc, uint32_t domid, bool *recent); > /* os-specific implementation of setresuid() */ > int libxl__setresuid(uid_t ruid, uid_t euid, uid_t suid); > > +_hidden int libxl__domain_set_p2m_pool_size( > + libxl__gc *gc, libxl_domain_config *d_config, uint32_t domid); > + > #endif > > /* > diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c > index 7c5ee74443e5..99aba51d05df 100644 > --- a/tools/libs/light/libxl_x86.c > +++ b/tools/libs/light/libxl_x86.c > @@ -538,20 +538,9 @@ int libxl__arch_domain_create(libxl__gc *gc, > xc_domain_set_time_offset(ctx->xch, domid, rtc_timeoffset); > > if (d_config->b_info.type != LIBXL_DOMAIN_TYPE_PV) { > - unsigned int shadow_mb = DIV_ROUNDUP(d_config->b_info.shadow_memkb, > - 1024); > - int r = xc_shadow_control(ctx->xch, domid, > - XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION, > - &shadow_mb, 0); > - > - if (r) { > - LOGED(ERROR, domid, > - "Failed to set %u MiB %s allocation", > - shadow_mb, > - libxl_defbool_val(d_config->c_info.hap) ? "HAP" : "shadow"); > - ret = ERROR_FAIL; > + ret = libxl__domain_set_p2m_pool_size(gc, d_config, domid); > + if (ret) > goto out; > - } > } > > if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_PV && > diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c > index c8fdeb124084..1baf25c3d98b 100644 > --- a/xen/arch/arm/domctl.c > +++ b/xen/arch/arm/domctl.c > @@ -47,64 +47,11 @@ static int handle_vuart_init(struct domain *d, > return rc; > } > > -static long p2m_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, > - XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > -{ > - long rc; > - bool preempted = false; > - > - if ( unlikely(d == current->domain) ) > - { > - printk(XENLOG_ERR "Tried to do a p2m domctl op on itself.\n"); > - return -EINVAL; > - } > - > - if ( unlikely(d->is_dying) ) > - { > - printk(XENLOG_ERR "Tried to do a p2m domctl op on dying domain %u\n", > - d->domain_id); > - return -EINVAL; > - } > - > - switch ( sc->op ) > - { > - case XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION: > - { > - /* Allow and handle preemption */ > - spin_lock(&d->arch.paging.lock); > - rc = p2m_set_allocation(d, sc->mb << (20 - PAGE_SHIFT), &preempted); > - spin_unlock(&d->arch.paging.lock); > - > - if ( preempted ) > - /* Not finished. Set up to re-run the call. */ > - rc = hypercall_create_continuation(__HYPERVISOR_domctl, "h", > - u_domctl); > - else > - /* Finished. Return the new allocation. */ > - sc->mb = p2m_get_allocation(d); > - > - return rc; > - } > - case XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION: > - { > - sc->mb = p2m_get_allocation(d); > - return 0; > - } > - default: > - { > - printk(XENLOG_ERR "Bad p2m domctl op %u\n", sc->op); > - return -EINVAL; > - } > - } > -} > - > long arch_do_domctl(struct xen_domctl *domctl, struct domain *d, > XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > { > switch ( domctl->cmd ) > { > - case XEN_DOMCTL_shadow_op: > - return p2m_domctl(d, &domctl->u.shadow_op, u_domctl); > case XEN_DOMCTL_cacheflush: > { > gfn_t s = _gfn(domctl->u.cacheflush.start_pfn); > diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h > index c8f14d13c2c5..91df922e1c9f 100644 > --- a/xen/arch/arm/include/asm/p2m.h > +++ b/xen/arch/arm/include/asm/p2m.h > @@ -222,7 +222,6 @@ void p2m_restore_state(struct vcpu *n); > /* Print debugging/statistial info about a domain's p2m */ > void p2m_dump_info(struct domain *d); > > -unsigned int p2m_get_allocation(struct domain *d); > int p2m_set_allocation(struct domain *d, unsigned long pages, bool *preempted); > int p2m_teardown_allocation(struct domain *d); > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > index 8c1972e58227..b2f7e8d804aa 100644 > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -92,14 +92,6 @@ static void p2m_free_page(struct domain *d, struct page_info *pg) > spin_unlock(&d->arch.paging.lock); > } > > -/* Return the size of the pool, rounded up to the nearest MB */ > -unsigned int p2m_get_allocation(struct domain *d) > -{ > - unsigned long nr_pages = ACCESS_ONCE(d->arch.paging.p2m_total_pages); > - > - return ROUNDUP(nr_pages, 1 << (20 - PAGE_SHIFT)) >> (20 - PAGE_SHIFT); > -} > - > /* Return the size of the pool, in bytes. */ > int arch_get_paging_mempool_size(struct domain *d, uint64_t *size) > { > -- > 2.11.0 > --8323329-1008032645-1668651165=:4020-- From xen-devel-bounces@lists.xenproject.org Thu Nov 17 03:01:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 03:01:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444489.699767 (Exim 4.92) (envelope-from ) id 1ovV97-0004sr-Nq; Thu, 17 Nov 2022 03:00:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444489.699767; Thu, 17 Nov 2022 03:00:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovV97-0004sk-KL; Thu, 17 Nov 2022 03:00:57 +0000 Received: by outflank-mailman (input) for mailman id 444489; Thu, 17 Nov 2022 03:00:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovV96-0004sa-L5; Thu, 17 Nov 2022 03:00:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovV96-0005Ie-IU; Thu, 17 Nov 2022 03:00:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovV95-0004X0-Ug; Thu, 17 Nov 2022 03:00:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovV95-0000xy-UB; Thu, 17 Nov 2022 03:00:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=P3jUnswty3JllHBFgGIn9xNRiipI629yj+/9iT7hn4Y=; b=D1YPxQ1WfaJEiheaSXVax0iAww I7dw7uigeYxuou7qdHc3ZWisljfBJ12BTokYP/rgjLraAcA4aIoXeABddkli6rLW1hin1CUH20MjW P7t/Tk5MY5l5AtWAPGOFvsDUk0kTJv2Lb2ikjAdFIu2ZaRveQyTnBgEQjXMfhRP8DKUQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174791: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2a98e98f96d1aafddf8869db5e2382d0ddaae01a X-Osstest-Versions-That: xen=c805ceb0b26a643c7e47f01f2dbc50555d93cce8 From: osstest service owner Date: Thu, 17 Nov 2022 03:00:55 +0000 flight 174791 xen-unstable real [real] flight 174795 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174791/ http://logs.test-lab.xenproject.org/osstest/logs/174795/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail pass in 174795-retest test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 174795-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174784 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174784 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174784 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174784 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174784 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174784 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174784 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174784 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174784 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174784 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174784 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174784 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 2a98e98f96d1aafddf8869db5e2382d0ddaae01a baseline version: xen c805ceb0b26a643c7e47f01f2dbc50555d93cce8 Last test of basis 174784 2022-11-16 01:53:17 Z 1 days Testing same since 174791 2022-11-16 14:08:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Ayan Kumar Halder Julien Grall Roger Pau Monne Roger Pau Monné Stefano Stabellini Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c805ceb0b2..2a98e98f96 2a98e98f96d1aafddf8869db5e2382d0ddaae01a -> master From xen-devel-bounces@lists.xenproject.org Thu Nov 17 03:34:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 03:34:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444496.699778 (Exim 4.92) (envelope-from ) id 1ovVfX-0000iV-D5; Thu, 17 Nov 2022 03:34:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444496.699778; Thu, 17 Nov 2022 03:34:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovVfX-0000iO-AT; Thu, 17 Nov 2022 03:34:27 +0000 Received: by outflank-mailman (input) for mailman id 444496; Thu, 17 Nov 2022 03:34:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovVfV-0000iI-JW for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 03:34:25 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b917021e-6628-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 04:34:22 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 8D6325C06F9; Wed, 16 Nov 2022 22:34:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 16 Nov 2022 22:34:20 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 16 Nov 2022 22:34:19 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b917021e-6628-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668656060; x= 1668742460; bh=TH05ILBPwe8tBTdP7Cj/QBp3IowitpnIIDPyVRIDFWM=; b=d IA5s2AMgk/x1gBRF1o7xKjeg6E0CQHG2f750FdKuYpjVR8tr9q9nI7PsjdowuJbG yGqetQLKNuTrfnKKzZJriF5j+BEWXcqkZST1gTVJEUBoF2RTv2j4MFWxTve2LTkZ 0udtmwtF2QnSgfoU0Mjs2RYDQgTS/whJyCq3y+3hgTtd2Y/ZLjBC/OUt8cVTZWYx WqLPOfkRrm3GczFHe1CBs20NRfUZpnVsB4X76s8WetGaJoQcI8D+Sswp+cQmqDFR hF7RPJT34Apwf7iuG7zZdMbkqQ3ucRP+mWPBPgZnHjC8ytlKj82tiFygiZIoBNMp JbZV4Qa8SnqU0a4lVswbw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668656060; x=1668742460; bh=TH05ILBPwe8tBTdP7Cj/QBp3Iowi tpnIIDPyVRIDFWM=; b=KOAYLja97UdP7gV2M9Aes6D2uqSCfFk3U+tA6LGo4OyW xs6YHn0aaJBHbafO3qyUfbZSARM7ZyqA3eVoWdodihlYkcukezz/Q0/o845eoRhg o2tTinWkSiyhOHopRx4iIXi/r8GPlGICXbOw4PMFCBUTmIsYQNjL0ZWdO72PhKud B5kLvu+9sT6x+866yUDAXhq28vv8BzFkq1GYRsYE+1MaC0YnGF2Dk/mp2HyP+S82 +CPwOCaFCZowJU6he9i5SzC1vVecRlddYD9PJVJ2tuj57wYqMOgomnAZRVRZwlYK sbLCwx3lPh+e7Q1iso2Y/o+46SJ2idJJe+hgxJmJBg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgeejgdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeukeet teeggffgkeduheetgeeileejjeeiiefhjeegvefhtefggfetueetteeuteenucffohhmrg hinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 17 Nov 2022 04:34:16 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jason Andryuk , Jan Beulich Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen Message-ID: References: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> <20221114192011.1539233-2-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qOI1HV1LMdZNtJDX" Content-Disposition: inline In-Reply-To: --qOI1HV1LMdZNtJDX Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 17 Nov 2022 04:34:16 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jason Andryuk , Jan Beulich Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen On Wed, Nov 16, 2022 at 10:40:02PM +0100, Marek Marczykowski-G=C3=B3recki w= rote: > On Wed, Nov 16, 2022 at 02:15:22PM -0500, Jason Andryuk wrote: > > On Mon, Nov 14, 2022 at 2:21 PM Marek Marczykowski-G=C3=B3recki > > wrote: > > > > > > The /dev/mem is used for two purposes: > > > - reading PCI_MSIX_ENTRY_CTRL_MASKBIT > > > - reading Pending Bit Array (PBA) > > > > > > The first one was originally done because when Xen did not send all > > > vector ctrl writes to the device model, so QEMU might have outdated o= ld > > > register value. This has been changed in Xen, so QEMU can now use its > > > cached value of the register instead. > > > > > > The Pending Bit Array (PBA) handling is for the case where it lives on > > > the same page as the MSI-X table itself. Xen has been extended to han= dle > > > this case too (as well as other registers that may live on those page= s), > > > so QEMU handling is not necessary anymore. > > > > > > Removing /dev/mem access is useful to work within stubdomain, and > > > necessary when dom0 kernel runs in lockdown mode. > > > > > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > >=20 > > I put the Xen, QEMU, and xen-pciback patches into OpenXT and gave a > > little test. When pci_permissive=3D0, iwlwifi fails to load its > > firmware. With pci_permissive=3D1, it looks like MSI-X is enabled. (I > > previously included your libxl allow_interrupt_control patch - that > > seemed to get regular MSIs working prior to the MSI-X patches.) I > > also removed the OpenXT equivalent of 0005-Disable-MSI-X-caps.patch. > > I am testing with Linux 5.4.y, so that could be another factor. >=20 > Can you confirm the allow_interrupt_control is set by libxl? Also, > vanilla 5.4 doesn't have the allow_interrupt_control patch at all, and you > may have an earlier version that had "allow_msi_enable" as the sysfs > file name. Ok, I found what is wrong. Enabling MSI-X is refused, because INTx isn't disabled at this point yet. And apparently I was testing this with permissive=3D1... Linux does this: https://github.com/torvalds/linux/blob/master/drivers/pci/msi/msi.c#L611 In short: 1. Enable MSI-X with MASKALL=3D1 2. Setup MSI-X table 3. Disable INTx 4. Set MASKALL=3D0 This patch on top should fix this: ----8<---- diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xen/= xen-pciback/conf_space_capability.c index 097316a74126..f4c4381de76e 100644 --- a/drivers/xen/xen-pciback/conf_space_capability.c +++ b/drivers/xen/xen-pciback/conf_space_capability.c @@ -235,7 +235,7 @@ static int msi_msix_flags_write(struct pci_dev *dev, in= t offset, u16 new_value, (new_value ^ old_value) & ~field_config->allowed_bits) return PCIBIOS_SET_FAILED; =20 - if (new_value & field_config->enable_bit) { + if ((new_value & field_config->allowed_bits) =3D=3D field_config->enable_= bit) { /* don't allow enabling together with other interrupt types */ int int_type =3D xen_pcibk_get_interrupt_type(dev); =20 ----8<---- Jan, is the above safe? It should prevent clearing MASKALL if INTx isn't disabled, unless I missed something? But also, it will allow enabling MSI-X with MASKALL=3D1 together with MSI, which I'm not sure if should be allowed. Alternatively to the above patch, I could allow specifically setting MSIX_FLAGS_ENABLE + MSIX_FLAGS_MASKALL while INTx isn't disabled as a single exception, but at this point I'm not sure if some other driver or OS wouldn't approach this in yet another way. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --qOI1HV1LMdZNtJDX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN1q7gACgkQ24/THMrX 1ywCHgf/eFD4v0mHu7zDeEjNqpy7ruZDsO1VURVpIVBsZTWgermGsVQTa0HcGIYI fRKvp8PaiBIr5SoevJkQTaHAOSSBeaUfxZwgnk1EYxSc5lJE/7hvxCgZr06e9rPj +In5sInNwcGgHB51qewFcrooQ/hb4R0ZACz8gKgG2Pw2jXPlm8qbYv9LYNd8O6T/ u6pFLUVYHNKNn6kzSBtNcXN68XsLj6ShNWK6cGwMx17WWEUP/xipa89qHp28Rw57 rA26wGE3SP0w/KxW7vIXf5eUpNksO5I60gF39jbwcMrEfUkFKpIJhPlr3G/T3LMJ vnKO1m4JEyqi40d4PZ80KnPxgSOT4w== =ffu+ -----END PGP SIGNATURE----- --qOI1HV1LMdZNtJDX-- From xen-devel-bounces@lists.xenproject.org Thu Nov 17 03:36:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 03:36:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444500.699790 (Exim 4.92) (envelope-from ) id 1ovVh3-0001H3-Oh; Thu, 17 Nov 2022 03:36:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444500.699790; Thu, 17 Nov 2022 03:36:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovVh3-0001Gw-LI; Thu, 17 Nov 2022 03:36:01 +0000 Received: by outflank-mailman (input) for mailman id 444500; Thu, 17 Nov 2022 03:36:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovVh2-0001Gm-GW; Thu, 17 Nov 2022 03:36:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovVh2-0005zh-Em; Thu, 17 Nov 2022 03:36:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovVh1-0005Q4-VN; Thu, 17 Nov 2022 03:36:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovVh1-0000J8-V2; Thu, 17 Nov 2022 03:35:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ldn0PscbxAtvAVl3TetJoE4feODR6bRMhxf0vBAND6c=; b=GqM04g/sNYsOD9GAkT4CW0eZZ+ Z4L3PU0xqgJQUqQahc4m8volTNatMQiNy75gfiBAPAXcYi/+rBpeNS+UsnBwquGf9Qzu7/YW+e0iz D6dzIaQC+4TQLLQk54lxk5lTx9bSSiyLwj/9XVVxeguUvRqHEQu3w/5JsoafsJJ3PAzU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174796: all pass - PUSHED X-Osstest-Versions-This: ovmf=fff6d81270b57ee786ea18ad74f43149b9f03494 X-Osstest-Versions-That: ovmf=93629f2c7cf05ebc0f458eacc42a33147096f9d1 From: osstest service owner Date: Thu, 17 Nov 2022 03:35:59 +0000 flight 174796 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174796/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf fff6d81270b57ee786ea18ad74f43149b9f03494 baseline version: ovmf 93629f2c7cf05ebc0f458eacc42a33147096f9d1 Last test of basis 174785 2022-11-16 01:55:55 Z 1 days Testing same since 174796 2022-11-17 01:55:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 93629f2c7c..fff6d81270 fff6d81270b57ee786ea18ad74f43149b9f03494 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Nov 17 05:13:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 05:13:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444507.699801 (Exim 4.92) (envelope-from ) id 1ovXCw-00063N-Oi; Thu, 17 Nov 2022 05:13:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444507.699801; Thu, 17 Nov 2022 05:13:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovXCw-00063G-KI; Thu, 17 Nov 2022 05:13:02 +0000 Received: by outflank-mailman (input) for mailman id 444507; Thu, 17 Nov 2022 05:13:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovXCv-000636-Qd; Thu, 17 Nov 2022 05:13:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovXCv-0000Fa-Of; Thu, 17 Nov 2022 05:13:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovXCv-0001hT-5S; Thu, 17 Nov 2022 05:13:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovXCv-0000FA-4z; Thu, 17 Nov 2022 05:13:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fk8XUu3X1oQX6TZXISNLyF8W45qJJVHvGak5JWm7SkM=; b=N4o/9j11riTUxr0CrNHgm2yZm/ sy1WwzatDOhT4CgxNz4Acu40/ZiIqPtC6yDidvi0F21PI52OtIdAfQbIKd91GORM5i9J2VMQmN2AZ ppAmNAFawpHqtKivi1Y3lC+uggY+rWHqGBzFSHkfN7Kdg0ZdeLPzNEjy8AAxPu78rD8A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174794: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=cc675d22e422442f6d230654a55a5fc5682ea018 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 17 Nov 2022 05:13:01 +0000 flight 174794 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174794/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux cc675d22e422442f6d230654a55a5fc5682ea018 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 40 days Failing since 173470 2022-10-08 06:21:34 Z 39 days 67 attempts Testing same since 174794 2022-11-16 21:11:27 Z 0 days 1 attempts ------------------------------------------------------------ 1714 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 163145 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Nov 17 08:05:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 08:05:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444561.699830 (Exim 4.92) (envelope-from ) id 1ovZtb-0003aW-Is; Thu, 17 Nov 2022 08:05:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444561.699830; Thu, 17 Nov 2022 08:05:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovZtb-0003aP-Fe; Thu, 17 Nov 2022 08:05:15 +0000 Received: by outflank-mailman (input) for mailman id 444561; Thu, 17 Nov 2022 08:05:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovZtZ-0003a5-Q9 for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 08:05:13 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70083.outbound.protection.outlook.com [40.107.7.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8f0d837c-664e-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 09:05:12 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7512.eurprd04.prod.outlook.com (2603:10a6:20b:29e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 08:04:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 08:04:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f0d837c-664e-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UVtSU9oyzIg5xWOx+Ixg+YJlx0Pl2y+zuo1Ag6iyFDXxPCchr3L1Dqt+TPPD8tyqYUv63HPYtmRPvCHcbAXuBA3DpmN5eHBq400jRP68TDELBFdfYl/gwTWo6FehgZHLdebN/pg5RhBIyTmZktRklAGdE7Vf7H5olsjEMezJQaiGW481cQZ/zRB8/SJ6d2VPh5lozJsn7sQvz+3a7BT3VVRzZ/5iH4YPS0AEwgmhAfuXtPpXhlMIT62MRESdzS8ZPdQdkGUWEow0ZBhnyQ7OcKF9sFl0h05ds2Axb5sXSUDFQlK+OgZBczUnC8+wzZuAFT/z9HCwCzndtdI4Ec+Qnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RmJ7NlLjFIgEz8MPJs2nNMlsimgFsnOr/vd2T0Lnkng=; b=WqC4RySg0cRJcTovDWNp9J1GqPKopB7J8qYo8SIyEn2cXo8Amn89l+VcVpZY04bqqhE80+X2tvnIpGkmu+lMil56IdDLpp4cjeMTFE/FWpNY3RarmORBrRvBzWR3kFjgWG5OQXpZ6AAJfiu3T+b+ulplgnfLO5tHuyhqHltM686ZIdqv+RPs4EWSmQEy9kKGeBQw/xUwDoC7vi9Zst5q0dWf4bZ6DxhVCHgFi1gvY5vXDKTY77Lwt0UR3v1nsvMmYySPkY93tFwV6iU+WtYHrANI+gDnU31JCjGUSHYK5bRYlV8gdpMKaelt1tSN9m/QWaRTwz04bGLLuv/RRwG/uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RmJ7NlLjFIgEz8MPJs2nNMlsimgFsnOr/vd2T0Lnkng=; b=TEucqcZ6U1OehAXLYKBuwLAElEdUUJsu2pU3tr0HoetvicCSs5PoVjl94JQ+Ov/oXUpsUZqTM5QwNFA0nBWyr/T0sLNRQXD4M5eMNa7+kp2QGqYWqmQh7WJTuMuAsIt5fRxtAQRCWKtaPdxRM+gGln4fg55HDKEKNUhhaPeOuqj3yJe+8qebIaiv7cTWMrRudZIlbC4zDJByT8WGB6jR4tt/7Ww7F9Xsg61dYcggUBmMEg2Y8E8MXRs3iOV4LTbXI2vKvQMNqgsupXINBL4O1IypTkoUbYfvUinpQlLc54JuKPZGq8TalYxCYjaei29NHCU3iUmDKxQmmPORc0X6fA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1443e924-5b53-9ee0-00fb-4d790d404b08@suse.com> Date: Thu, 17 Nov 2022 09:04:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" , Jason Andryuk References: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> <20221114192011.1539233-2-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0053.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7512:EE_ X-MS-Office365-Filtering-Correlation-Id: efef1481-c059-41a1-7917-08dac872621a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CtNnW0AssGTZLRN5igRC2+7AKg3NaV/5dR3uMD5WMpsp3bY+BLLIQD7c/X1kGRRBXGEWsGFJCIoF3Zhj+aZiDCURcdPrz4JkAsUdim9oOjvzaTNf1MH34CNIFheripyY/C0HAb5poMUWU+ls+qhN6Gn+1dAfLp/U5ViwLPm4QNc3AquvoR3NXx3Qv2SSWjeSljK4NoYrDLFAi4gzFMN7KMAgJ2xpnhaCvsxpW35Wdrfa5oRVQiEygzspmM9UojtWBymJZFUXRPsY3RNExPlV8MacFn/NDykmwAc+/MwxIMpbrgHJPFxDFiC4WxHDl3m0zkSwA1OoWi+lkRwuvqGMalwaZsbVtuN/bOgc5yz5ubtjay5ckLvDVxAUj5tm7l8pBty6HQQkbXTt6XenctmJoTS1tkokXpqVW1avZiGOym2VHE3Bq5zBPhN8dSYb5eVTun632TTH7tjcdgkGy1fIsvus2exGuTQWka/SwFGdFqJCTwQoyjSBO7T9GzFIiBrS0FBFXpPBsCTf9ZB1RcG+CMwhAhZbBtzQtzUs694x08E4PSopQ1Dqaxwp8d9q0C3s1Ayuy+MrVwOhA348DLJQS4yf76M4PtP3OlXTJWwOB8LKP76rinVLqg8okUxh+34mitqsUuHYxZ0pnIk1c1eyk6bIOIc3FBgE3lMpIJFpratxurAc2p3HhvffO4sV3eiO94v7JN+7EJKuL+gqipGI+shzgTCcNZ2jcovSDZD39vX33KUVj1g5ykGZXZ2FE2Ql X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(396003)(376002)(346002)(39860400002)(451199015)(186003)(5660300002)(53546011)(316002)(6506007)(54906003)(6916009)(41300700001)(2616005)(8936002)(26005)(6512007)(4326008)(8676002)(66946007)(66556008)(66476007)(36756003)(38100700002)(2906002)(83380400001)(66574015)(31696002)(86362001)(478600001)(966005)(31686004)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHJKZ1V5WWt3WTliS1dlK3gwTzVtOTlTOFdMSHpIQ1FxSUhnVGVLWDZFcUN2?= =?utf-8?B?NEM4Zms5Y25RUkZ3TXVtN09nMFFOS1FNV21BVlhFWmNhUERyWVRkMkRyVXE2?= =?utf-8?B?TmdzTWFhTU5ZWlc5aTJyK0NRV0tLY2VxRndQMXdhMkc2TklFZlpPTTZjWG9v?= =?utf-8?B?aCtHUFBEMWtWb2dsam5Canlvb1IrQWJydHZ4WGJBZmpCTnRZWUdJQjBSeFVX?= =?utf-8?B?QkVBbHdLT3FZdHRjd2pxMDcrYTllUWNUc0F3R0pGNUtmOW1EeURTdUlUbnIv?= =?utf-8?B?aG1aRGdmRlRYdkc2WlBtSDZZM1lxSVMrSmtjM2pTdjMrcGJ4UVM5Mk8xVTQx?= =?utf-8?B?ZHBRYkVmaXR0L29mcTZqb2FjcjhIeWpLUkJBa2toOWN1bjluaVFqRWtJM3dw?= =?utf-8?B?dVMrMm0zTFhFOExUbDlWNk5Ob0lFSFpQRzRNdm92OEt2a1pvbWtDam9EVmt2?= =?utf-8?B?QXh2NTM1N1VyVVdDaU1VYmNJV1BpVy8zekFQeHphNU13d1FiaWJXWTdXS01P?= =?utf-8?B?bzVoSkFOellndEdGOE9sVHNDOTlCWXZnT2NsOVdUSTRCYkNFOVVCcG9aVi9y?= =?utf-8?B?b0o0ZmN1eU9lOSs4b3ZwczA2OW1jUTRjNG9lUVE0RjB0L3hLZ2ovdDU3NjFO?= =?utf-8?B?WmZYemVRZWx3Q0J5a0I3MVJSTHcxNmtGN2E5dm5EVG12NFZ1YXBOSVRlOW1t?= =?utf-8?B?T2tkTW5udklReWUzbGFxdlZNSFRCMkFtajhERktQd2NxUGdEbE8xNENNSnYx?= =?utf-8?B?clNtMERITE9lcERHaE1lQ1Zrdjg1cTZDMFp6ZytwQ2d6QkNXK2hTK2dqQmZ4?= =?utf-8?B?VXZseHdIUFRtNTN4bDJCTDJTeHVGQmUyK0hBakNFUnJMc0hzQmVTTGRsQ1Vh?= =?utf-8?B?ZUlvSmxCVm1UM0dBMlpUdjBJaWxDSEwzSEw4R3VCVGg3QVBpWmM2ZmdBc2FX?= =?utf-8?B?R3FId0wvR0RyV0xsamJZVVpvOER2WVRlZTZLVDRWN2pvRXl4MDZPQmlZNENJ?= =?utf-8?B?aS9hSGZtU25taTNPTnN4T3Q4d1RUd0VjcGxTQVR5cHVKQjdMU1pQaldQZTR4?= =?utf-8?B?VDUzSFpLYkIxR3A0S0ZRKzlQU3JpWG1yYlBoYzBUbDNkZGZoZ0xDeWxYRHVL?= =?utf-8?B?eC9HQlJOVlZRNnNobGRDRVJOdzFLVFkyREVEV2M5QVJ2L291OHBFMWxaMFYv?= =?utf-8?B?ZDVXOFNzNEcvbWhwK2tjMWRSOXZPMFA4WkhERzZTSUhJNW9WWEY4L2JUakoy?= =?utf-8?B?ek5FMVZQM090VHk1VFhaZG45U0YvODAwNE1UemtURHZ2WDViWnFaTmlhR1c4?= =?utf-8?B?dkRoemd6RWgyQTVzTTV3QTlwQVloeXNva3JDY0dUaXhyejMrUmRqOCtIZzI0?= =?utf-8?B?UjIvSEc2NHdZU0xIZnFqTFFLNWFtb3IvSTBqbTExSXFKeTZTdy82MlBObE1L?= =?utf-8?B?MEdYUGxRKzBRZ3hBSjJJRGVQVG93WXZ6dUZDUW1WcTdnUW9wR1NMeFpwQWhB?= =?utf-8?B?MlJ5bVlqMis1bmsrNVBOend4ZnY3d3hUc0xOWWRnNU9LVjFvT3RmUzNNRUtx?= =?utf-8?B?aWtFRlFMWTBWelpjSk4xWlU0c1BiY0pVNHg4Mi9nV2NWT0tJVFN1TlNHcXM3?= =?utf-8?B?VkZsL2FreWNlMVpDRXEwbGROL1d2Y2VQS0N4ZFR4cnlFVUNLcXNQL1hxLzlH?= =?utf-8?B?OVN6blZZeE4xWVpFaVpoNzFuWUlkTm1FV3lJdnNLM0Z1dE9mSmNmNVVvQ0Jk?= =?utf-8?B?K09PMjlGaFdQZlpXOEEwcU55NklFUFozdC94MnNibFlzL000YUUvS0pGYS96?= =?utf-8?B?ckRjVk5ENGhJclRESkU1M3ZuS3owMTRrRFFZYTFlUEZweVJ1cWFXTVFEZ2pJ?= =?utf-8?B?dWNiSGpLL2hMTzBzSDdXUCttUWZmT3ZJWnZkcHJpczYva040K0lUSXMrOGdw?= =?utf-8?B?SHlzUnViT1p1VHNvcDlNV0UzN1Z2OGttNmJvVnhobFZZMmVSMzZmVkE2SlNx?= =?utf-8?B?ZHZEdW9TZ1MwYWlweks3RnNCZk1pVnJuVjRnR2VUSHBoNXc5Zk5HZTNWMXpY?= =?utf-8?B?OVQ5T3lNNzVOSHJ6Yi93eTc4SjJ1WkZ6VGxCd2VoWWZISlM2bWFuOEhha2ho?= =?utf-8?Q?rr+cmWVSn24IarKlmZJ/45zg+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: efef1481-c059-41a1-7917-08dac872621a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 08:04:42.5950 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kJqJ3IBJ8bvOuhWsyS0VNkVfK84L1WHUj1LswRvhSW7xrc8n5ogngu/dK+22727Cb99uHiawrnMRajCf1mmYXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7512 On 17.11.2022 04:34, Marek Marczykowski-Górecki wrote: > Ok, I found what is wrong. Enabling MSI-X is refused, because INTx isn't > disabled at this point yet. And apparently I was testing this with > permissive=1... > > Linux does this: > https://github.com/torvalds/linux/blob/master/drivers/pci/msi/msi.c#L611 > In short: > 1. Enable MSI-X with MASKALL=1 > 2. Setup MSI-X table > 3. Disable INTx > 4. Set MASKALL=0 > > This patch on top should fix this: > ----8<---- > diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xen/xen-pciback/conf_space_capability.c > index 097316a74126..f4c4381de76e 100644 > --- a/drivers/xen/xen-pciback/conf_space_capability.c > +++ b/drivers/xen/xen-pciback/conf_space_capability.c > @@ -235,7 +235,7 @@ static int msi_msix_flags_write(struct pci_dev *dev, int offset, u16 new_value, > (new_value ^ old_value) & ~field_config->allowed_bits) > return PCIBIOS_SET_FAILED; > > - if (new_value & field_config->enable_bit) { > + if ((new_value & field_config->allowed_bits) == field_config->enable_bit) { > /* don't allow enabling together with other interrupt types */ > int int_type = xen_pcibk_get_interrupt_type(dev); > > ----8<---- > > Jan, is the above safe? It should prevent clearing MASKALL if INTx isn't > disabled, unless I missed something? But also, it will allow enabling > MSI-X with MASKALL=1 together with MSI, which I'm not sure if should be > allowed. While it would probably be okay with what we have now (after your earlier patch introducing allowed_bits), it's likely not going to be correct once further bits would be added to allowed_bits (which clearly is going to be wanted sooner or later, e.g. for multi-vector MSI). Hence I think ... > Alternatively to the above patch, I could allow specifically setting > MSIX_FLAGS_ENABLE + MSIX_FLAGS_MASKALL while INTx isn't disabled as a > single exception, ... this is the way to go, and ... > but at this point I'm not sure if some other driver or > OS wouldn't approach this in yet another way. ... I guess we need to further add exceptions as needed - the one further approach I could see is to keep all entry's mask bits set until setting "INTx disable", without using MASKALL. I'd like to note though that the PCI spec has no such exception. It, however, also doesn't mandate setting "INTx disable" - that's merely a workaround for flawed hardware afaik. (In Xen we also only cross check MSI and MSI-X. IOW we rely on Dom0 anyway when it comes to driving "INTx disable".) Therefore in the end pciback looks to be going too far in enforcing such dependencies. Thinking of this - what about making the change in xen_pcibk_get_interrupt_type() instead, setting INTERRUPT_TYPE_MSIX only when MASKALL is clear (alongside ENABLE being set)? This would then also cover command_write(). Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 17 08:18:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 08:18:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444566.699840 (Exim 4.92) (envelope-from ) id 1ova6T-0005Qq-Ru; Thu, 17 Nov 2022 08:18:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444566.699840; Thu, 17 Nov 2022 08:18:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ova6T-0005Qj-PJ; Thu, 17 Nov 2022 08:18:33 +0000 Received: by outflank-mailman (input) for mailman id 444566; Thu, 17 Nov 2022 08:18:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ova6T-0005Qd-0h for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 08:18:33 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20630.outbound.protection.outlook.com [2a01:111:f400:7e1b::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a75e3e6-6650-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 09:18:29 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9649.eurprd04.prod.outlook.com (2603:10a6:20b:4cc::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Thu, 17 Nov 2022 08:18:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 08:18:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a75e3e6-6650-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nIBtvIRW560ljuuPyLHWVChTk20MJmUp2lj9cs2MWz2kbGPbUSZnXmf6tU/CLP5pamP9W2cgjBT7sjnYXxQMReOhuGfQHdePy/H3lvFIYdUQGPibR9bQi/rNXaNyLyFw1ZYYU+qQZYGfAWaQcwysmSuKnfcxYsI3GHbkHJsREDr3hjEmWJGnm+tdZjPQHZOHl1QQ3GKa5NnKDhg7qs+prLQwOY+SbXRrpfloDpS0ysPDCOsoojrJVvSDH2MHC6RFGkOsOM5aeBZtNiWhs3KTbZ7dH3HFa39ucOUHwEJ+Colncea2JUdgozTc+Uu7DW4SW4dj1qDWzyG702zzEPWfXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YV6QUFEY9vlzYTTsEbqFIs+0kvYepxwj+YmoHgkufPM=; b=mofRmUUYLvW6tKTpb0NWIO7h/cfom8Rq7FFTciuPoUMIidsyYuwPFhV9zpBgOxwJLeKFzivJ+/YE8SswVPsXyrERdqGtYXxU7FGukIb9YBUMk36dM4mJxQHUwQ8SY+tfL9Wiyommws6R9iGCX0+yiMhsgNfdvdn1WBpbGfmBdlbHyM8CeeREmIarqlrrTZCkDU0tzEaNRfYv8nUngGtikYjSeD2wHVJbPwlZMLenHdAGmqRszKVhQKBfe4cjeMDz3HfPe/K0Iqcm10TeaKVTVOgj+2dwr4ZR4CAPnrTzWgVBBqEB8GdXgJD6Wql/G7kEP4ZIqMb8IhMWfO759bybVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YV6QUFEY9vlzYTTsEbqFIs+0kvYepxwj+YmoHgkufPM=; b=uROWZ04Nc0bciUzDh0fMJxL0zl88CkmqhKWSwVvFEJQL0VSSjPTOnwaBG1Q62OtVAcCRKHZxfEeqpRvpE1888Ec9M6h/RTCbpWzzDTdDBYnOglKjwMKgU2ht28tyAy8XArUD52O9J5XbJUZybsNKfKOvQHRNj1o0XDrbR9Ob5yJA/Q2Uk4kjw6iHek5glGjnYvGLEy0Nrm/oZzbDiF+YmblfVkBi+rvJP7rYXr3mxmHh4HzsQE6ysUGwKIdNTURGzC8T1qB6ix1SsFB4fmCGH2I8AE83r1ddXpNcNpk+y8X8cVhF3+WNoqexBuauWuE1OU9NYrCyFjpuKPeP9jmOog== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0e2e79fc-efe0-501b-e80e-c98748c9babe@suse.com> Date: Thu, 17 Nov 2022 09:18:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls Content-Language: en-US To: Andrew Cooper Cc: Xen-devel , Xen Security Team , Roger Pau Monne , Wei Liu , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony Perard , Stefano Stabellini References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-4-andrew.cooper3@citrix.com> <269f4e70-07c2-5cf6-f42e-6f98e2ce70dd@citrix.com> From: Jan Beulich In-Reply-To: <269f4e70-07c2-5cf6-f42e-6f98e2ce70dd@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0024.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9649:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c111cf3-c539-42ef-17db-08dac8744dec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lXyaJ9zf9s0gCkKZoo08MdGSjPPiBDyHCtA/IpehU2EOHXdkZO4tdk3K51XyPU/SXap9g3lfKhy0Zf7M3vo9EYmcKN97ALO8UlKe05lkT+/74t4obKz1iE15dTgbJV47LtdMBY82eTwnmvp7xvjNL6B8r7ManMoAk/KgdCfqmepyOpTPF9tI/xHtfEMKAg+ggrzOWE44ZHLV7V+ijcoDnLNoOf/oS62b5BnbnCQk6lxgfShitFRj/78VtwEmy1t/1nGW8LH5+7ofOT7uTGcKlaKiAtYobHUq733/9JgXwZopaZZpbGm9U0hEgdbvmqu8sn9krDgGxnxBGuxy5Rk630q0byn6CtH489LenFCsjlI564BDKmA9dfEL6VDwqxvJrGfW8Vl7oPi/RU5k9thN+oAdyTn0Zo0tTQDzGgHMUMlq8Jr0wFvJckgHERvPU05rZ6svnUf/wJoyEt3CqSnpm7ABmpDGHUwtlLj239Ar/+wF3I/k9qXTk7Y9V17JLvx+1+/KKcXTQUmGuSnCOtVxKyt809KphXpB092rfrzamHF27uBKeEEtBCr4iGG51bxdOkf7vby2cAmkTqJb0fcoF8pHt/4Q0SY1MwoHHRLcjYUeHVNZ2KuhB1S1APq8+W9ldjBTHWi46hSeG1PkOdT/8wuEMi1bHFstNAuB4eLVLW4Tw+BZq4CEsYJLp30adqFRgl/+gQuIcwTnTL9bt4MOSDpchiVam3SAz16v2TO2Jps= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(396003)(346002)(376002)(136003)(451199015)(53546011)(6512007)(6506007)(86362001)(54906003)(6486002)(6916009)(36756003)(26005)(478600001)(38100700002)(31696002)(2616005)(2906002)(186003)(83380400001)(7416002)(8936002)(316002)(31686004)(41300700001)(8676002)(66476007)(66556008)(4326008)(66899015)(5660300002)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emc0bng0Z1pzZjlvL2RSWXNRTDlxeGdxVHR4SG92ZFlNZUh6eCttQ0NVT3hw?= =?utf-8?B?SUlHV3ptZ3c3VFFsTk5wL3FTRU1nY3dGcHVOcGxnR2ZjS2RhU1FiTGJnbmhx?= =?utf-8?B?SmFpa0VlcGtoWGpPbTE0MnZDZ0Y1bDNJZmlXcWE5elZsVDYzY3hTc2VHSHhl?= =?utf-8?B?L0ZVS2FvZ0lRV1Buc1NjVE5GSUlVRDRxOHBhbHhqc3ZOLzUwT1U0RU5lSTda?= =?utf-8?B?VHM0d1JDcUJ5UHdEcHRXUk8wSGhTTDhpeEJwMVhMUCtvUlhtMy9EcTZEYjY3?= =?utf-8?B?YnZTbStNaDNueXIvMW43OG9td1Rtb0V2SEdhem1LdEdyYnBCUXJtQW1ESVgy?= =?utf-8?B?L0xnTXkxT2svelVvVXVZSklRWGtYNXZYbWRMYkoyQkRxQmpMallRZG5EVXRJ?= =?utf-8?B?NklVTThjUTU3RUVwb0h0WnBWZmlsOXc3cWppL0ZNTGMvazdOK3hMWG91K3R5?= =?utf-8?B?bG1PWUNQTlhQUVhTeUZUOXMwU2RBdW82Q2lUTm56akNmVnY0cWJzRGdkNmRi?= =?utf-8?B?WThvMWN2czRWUFhUejVpQUkvMmtoMTFvSUZxWndqRGFvbGdtQUZ5ZS9nQnJh?= =?utf-8?B?dldRZEZwZ2QvdWRZbFI0Z2xpN3RKblZZNDdaeTRSYUg2d1lxK3M0TW1OZEhs?= =?utf-8?B?eWFLQ0M5MWhUbFBNdGVYdGxkRFM1cmhWRzJpbm5iQWdIWnRTcXVxMVhpUDNN?= =?utf-8?B?aHFXbFRqdGpzMWRQUnYvNDRGRWV4VmRkdWs3VkdyZGJwcnJmV3lTRXE1T0VF?= =?utf-8?B?SlNteVZiYUVPOEpzb0piTFhzbVR5bEpVL0xnSXo3ekpnUzdoclNKYWpScGZ4?= =?utf-8?B?QmpUV003RDhrS09kUFBWWEpoYVpnZXNPS3dTOWJPRFg0cUVraGRIQ0xpMFUw?= =?utf-8?B?TG96clJnSEpRMzBYempOaklSeG8rb3d6bFJrUEdIMlJkY0FOeHRXd0dneUJs?= =?utf-8?B?VVNoektmU1lGSEU5aml3Z084SW04M2xBc3VZWHdoby9uZjBsTjlDRGhPdklS?= =?utf-8?B?N3ZZN1RwR21qZkVxSTJocWtwTkp1OUdTRDY1WGFsbmJCc2ZibDhLM1Z1eUNF?= =?utf-8?B?QzYrVUZpRkNkREpWa0s5M0NHOE5TbkVsekNqRHhHZEFpNWdMMmJtTllvUGZZ?= =?utf-8?B?QXdteWdFTGZWdCtFY2RPT2cxTGFQSEhDd1hTQTNrVmZURlZNY1RjcmFDdDB6?= =?utf-8?B?THV0L0gzdjFYSFhHd3ZZVm9jazNRUnFuenJzdkJHMU9xRUJ0YWsvdmJCS1JV?= =?utf-8?B?d1QrYXhPM0poaUNGQlFNK1BOdzZWek5zK1ZLY0RHQmlxWkZCUXB2Y3dNOWdn?= =?utf-8?B?MTBLTVUxYzBHZ08xZGpuRE5NMEV5RS80NDlLeTYydmtFdTBLM2wzdmQySGlS?= =?utf-8?B?d2IwaEczZFNTNTJodldkSDVZZTRpSExlYVk0Z0NoS08ybmVYcFQ0UXpaNDl0?= =?utf-8?B?bnlGcnRrTnZDWXYyYmhsdzNweXNHaWRBcGpxcGJwZE5NQ3l0YmJaaE81dGtI?= =?utf-8?B?QlJybTVkYmQzd29YNHlrVWJzeG96WlJraDdKaWhTcnp3cjhVSExkN1Uwc2pw?= =?utf-8?B?bXVXaU94RExDYzkwOGVkOGUwclF6eWx2RmtuSnZXVS9nZGw1UGVaYk92Z3RS?= =?utf-8?B?Ymw3eDNxd2JiSU9zcTdkZ1RRK2dZNnk2ajlPS2t2SnhNNmcyMmJRRnJyaGFY?= =?utf-8?B?c2Q4Q2VPNXFycG1Sa3NSRldUNzQ2QlJ2VE5QQTVpOHowVytuVTlNblVqK21i?= =?utf-8?B?NDdPWEpMKzZxSUU1MUVHbmJXeVRWaG5xWkVmNnZnUTdsOWlkYXJMN2JhMXE4?= =?utf-8?B?TmhlZE42QjJIaGY3aTU3S3JYbUNOR3ZNZnlOSU5NVUo1a2VCS3Q2MVNDL1NV?= =?utf-8?B?TDFsVnd6eHVjRmRaUG5Rc1QxT1R2WVoxQUV6eExMTGs1d0tlVW1XQUk1R1dq?= =?utf-8?B?OU1Bd1BtVTdhNFNRZnNpbURoNExKOHJCT3FFRXBOVmhQYzc2YTZKc1NScWw3?= =?utf-8?B?WjJ1azBXOHgrUzlUVW9pNUx1Rm1RTUx4NXhFaGRGL2dZMkZHcnBEMmhkMkJV?= =?utf-8?B?eTErVFhYRVpFdHE1NnpxQ0ZCYmxta01tOXpoM0N4WlpndkVidWE4TFBqSTRH?= =?utf-8?Q?5tQtMJ62bV8w+iJ/Syb8dHQwD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c111cf3-c539-42ef-17db-08dac8744dec X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 08:18:27.6988 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bFp/IRNCtBHCTmcan4/8dN/brxRGDOyAwhH3Qt7/lI6f37SzVFw/jXoFlFfztHzMFnfkIpGmnMxvmA1+YjWyVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9649 On 17.11.2022 00:41, Andrew Cooper wrote: > On 16/11/2022 08:30, Jan Beulich wrote: >> On 16.11.2022 03:00, Stefano Stabellini wrote: >>> On Wed, 16 Nov 2022, Andrew Cooper wrote: >>>> On 16/11/2022 01:37, Stefano Stabellini wrote: >>>>> On Wed, 26 Oct 2022, Andrew Cooper wrote: >>>>>> This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits >>>>>> of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. >>>>>> >>>>>> First of all, with ARM borrowing x86's implementation, the logic to set the >>>>>> pool size should have been common, not duplicated. Introduce >>>>>> libxl__domain_set_p2m_pool_size() as a shared implementation, and use it from >>>>>> the ARM and x86 paths. It is left as an exercise to the reader to judge how >>>>>> libxl/xl can reasonably function without the ability to query the pool size... >>>>>> >>>>>> Remove ARM's p2m_domctl() infrastructure now the functioanlity has been >>>>>> replaced with a working and unit tested interface. >>>>>> >>>>>> This is part of XSA-409 / CVE-2022-33747. >>>>> Genuine question: I can see this patch removes the implementation of >>>>> XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION on ARM. It also switches libxl (both >>>>> ARM and x86) to the new hypercall. >>>>> >>>>> Why keep the old hypercall (XEN_DOMCTL_shadow_op and >>>>> XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION) implementation on x86 (not on ARM)? >>>>> >>>>> Is that because it was only recently implemented? And not actually >>>>> present in any past Xen release? >>>>> >>>>> If so, please add a note about this in the commit message. Also, if that >>>>> is the case, I think this patch series should go in 4.17. If it is too >>>>> late to get it in before the release, then we should backport it to 4.17 >>>>> as soon as possible. That's because ideally we want to keep the >>>>> hypercall interface changes down to a minimum. >>>> On ARM, the hypercall has existed for a little over 4 weeks, and isn't >>>> in any released version of Xen (yet). >>>> >>>> On x86, the hypercall has existed for more than a decade, and has known >>>> out-of-tree users.  It needs to be deprecated properly, which in this >>>> case means "phased out in the 4.18 cycle once known callers have been >>>> adapted to the new hypercall". >>> Understoon. Then I am in favor of getting all 4 patches in 4.17, either >>> before the release or via backports. >> Removing something from the domctl interface generally requires bumping >> the interface version, so some extra care may need applying if such an >> interface change was to be backported to any stable branch. > > To be clear, I have no plans to remove the x86 "older" interface in this > patch series.  It will definitely break out of tree users. > > In the 4.18 timeframe, we can see about retiring the older hypercalls, > but as a non-backportable change. Sure, but I was referring to the (pretty new) Arm incarnation thereof. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 17 08:24:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 08:24:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444795.699852 (Exim 4.92) (envelope-from ) id 1ovaCS-0007VI-Fr; Thu, 17 Nov 2022 08:24:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444795.699852; Thu, 17 Nov 2022 08:24:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovaCS-0007VB-DB; Thu, 17 Nov 2022 08:24:44 +0000 Received: by outflank-mailman (input) for mailman id 444795; Thu, 17 Nov 2022 08:24:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovaCR-0007V5-JC for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 08:24:43 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0609.outbound.protection.outlook.com [2a01:111:f400:fe0e::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 48cce6c2-6651-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 09:24:42 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7604.eurprd04.prod.outlook.com (2603:10a6:20b:287::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 08:24:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 08:24:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48cce6c2-6651-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mgBc/R2+7/l86KuQAC2TdSRsrCf4QYrK72HTHf0wU/NFUryoc0c8kRjjGEaAB7TNZQ//AduENRQlFDtx9Z2oPIgV6ONDMH3vLme9gStlmEVMFEeWxP5hBFIBSBZGsdieGQxuLLeNJyQVjhuO3qxRBowX71F+2xS/msvsxjUgefyzzTfkV91VZMDTE7F1DGD0A/8rvD0mtNNi4SSscmTW1xy4GgJNuu7foPX4FlOhAZ8efj9fM0jFYZBUF7FzSqcWdJSdhNhNbhpS+kHqyInAK2n++vkinqzoXqNtCIG1RMU2s3Q7WARLsfHhTmNQmR5467Rw4xL2NTk8tf0s+B7ApA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H5QUOWx2yaIUU2v4e2qHioxPLN1Ucatf7wWz4lH5g7c=; b=nQJjJril9gtVGsB1+A7pXfRlbrpIhcV02DsUSdJuQohhH9eHX/r2ZYghLUYcervkhoHey4qPiEU8sDwXp4HhwK0t13FfnIZE2nu9f7yKtvvjvR/y0vSk6Kq6ws7XUkdDHy7fPMPJJdDArWbeKUXD7xZiO5u0pI+PbvpHEG+smSQpFIzwJpTlYGN90ed4CUnEQBrM3UHiBYC/UNS1yCupQZQ5y+CauHR48t7nLp0T4dU1J4iFUx3ok4WwqX2hzdXWfSJZE2QWOGHRmE1jFXnrvmQ6YBXiA7ZboO43BnqW0yROOHVzXn9UPAzGoWC9gzb9uHa6gJZ8a6boYs+DPi/ycw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H5QUOWx2yaIUU2v4e2qHioxPLN1Ucatf7wWz4lH5g7c=; b=Ry+J4U9jwiCbIZjVqEkOomYmXiT6Ptpbpaxdu5Gc9/niiK9SUnGtlsO3X+/JlV+oke51cSEq3BSYYxql5WHdzE4SQ1Kprbtx3k3YZqEzTE+ApIuzGfhmyffuge8Z4LOIqxwdiyCzf9tSE7bSu5ANi2qDOms3dTkVsitvbFCRtBvJxyYxeVF665kc9V2mNgpKEtJ+mHh8VWRdK9M9IRVjrKbtpzUuy8voAKweypkLq1cWOozDKqQmGdxrCt+VNcebQdRpw3+yyarxX7twcXq7Xtm0UAH1MVuVq/0DgA2mfoQ+dQr5DBygeK/GBkKxHJTiHelUI2WoG7am2G+OzM8k4w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 17 Nov 2022 09:24:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH for-4.17] x86/hvm: Revert per-domain APIC acceleration support Content-Language: en-US To: Andrew Cooper Cc: Roger Pau Monne , Wei Liu , Henry Wang , Xen-devel References: <20221115003539.19502-1-andrew.cooper3@citrix.com> <29469c16-856c-bce7-c556-66622e349f1c@suse.com> <2334ba7c-d744-c1ca-8f67-b2013e9c5fe4@citrix.com> From: Jan Beulich In-Reply-To: <2334ba7c-d744-c1ca-8f67-b2013e9c5fe4@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7604:EE_ X-MS-Office365-Filtering-Correlation-Id: f6415377-46f9-4589-875b-08dac8752b16 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lQ/27qKMIu7O1zCmXrtEki4defnJ3IMTk5O+yj/a5aSawhUlH130/zkj+LYP6vIreuo3nWZ6VoByFQt4qKGlCWkw++bdJ81fqzbaYnLwzSIrVS7bg4pTKNGh2oglgCCGefPrDG4PiG2dSbcV6K5UQjRXfFovEIn4CJYhq0sAT0iQqeFHHPG4FCj3o/jydya+8tlViB4G8kGIpo13ieJSGwKNDvP/U7zjXp4Y84sqZMxzHkfO8hKAbO/peftXKbtNF229tJJ23UkVjUR6euTVuUKwYhrIGJ400PWwmuXN6+6BBF33zJ97uW4squUDu/a4olZMuSk6A6JkP+CQmslFBU6YjTEiNiWDodXMfRlkQnCJD7Mjqt1P5v+bFhrLE1YkhK7LWCyVN/rQtbCPa/frELoiS2Us4jQ11H+P215IX45au7oz9S7CxQd/xJkZXJNIGcoK1MVznCAz4AuwkYYPkUaVADCzy2aotWypRK+MB4esYguO00F6+r8z8yjdGhkFg8+ievWUQUvjE7UQyrs+luwdxxBu99+VFreNTXOqupW3JGHX+y9G+f+YOOSWVsOXti1vI3udjfkP7/6ZZqdiKUhBIG9PEWjysEDCtU0jtk+8qhmZZuX2KlH3ffKiTLf1dW0+YpKY1Fk46UR7tuRH4VloudhdU8Z8TU5OpcdOmstx0ymivecMuHxjzGJm3A7+eS0H/87mnnLo7Dd9OXRAUt8cTLS7NQhpJw6sQhP4Nho= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(39860400002)(346002)(136003)(396003)(451199015)(86362001)(38100700002)(31696002)(6506007)(53546011)(26005)(6512007)(186003)(2616005)(54906003)(6916009)(8936002)(8676002)(6486002)(66476007)(66556008)(5660300002)(4326008)(41300700001)(36756003)(66946007)(478600001)(316002)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WndDWVlDTklQSDFBblgyc3l1dkFxem9GTU11a0wwNTlJSVF1L3lqRE1JckNO?= =?utf-8?B?NnkzODBqRVZ3T3prcEVqUDRTM3UyMXgvUm9WVThLZy9JUU03VFczak5lMUVB?= =?utf-8?B?ZzNvZ0swZUEveWtqeWRQN1pWVm5DU1N5NEhWRS9CTG5nZnprUExFT0dOcW1k?= =?utf-8?B?Sk1UK09qVC8reWJ5LzZFMzhNUGhEM1R1TDNaT2FZKzRPQWhOOHlhWnRZVjNo?= =?utf-8?B?V1ZOSm5uWEtWeXU0bmVzK0hxZDRGb2Y5YXNVNURtY0dOQVg1ZWtrQTBrbnRG?= =?utf-8?B?YTdiWWRKQnFsYngrNm1EUG4wTUtOU2x4UkRIeUsxM1hITUJ4MHhXcC84QWZH?= =?utf-8?B?TWV3ckEwNmR3dW02NnRkN0NtVUk5UUNSem9TMjFVUlFSUzMxTms2cmJBQWVo?= =?utf-8?B?dVhENGVkRmdNalVVOVEyc2NOU3RGNXVIaGQ4WHZCUmNvTHZNTWtOYmVQbXhW?= =?utf-8?B?cHdZdXQzbHBWemRYeUxac1l2M3E5WUJFNjg2b0t4S3QxaEhVRTNCa0ppNkU4?= =?utf-8?B?QlVTYlJDMHdSR2FBc0RqODJpZENMWE1IVDVIeVNtS3BSSjdvSWNrT2dyMVd0?= =?utf-8?B?M1g3WU5zMk1BdGxnTnBvcUswOVg4cFJBeDZJREFDT3pmdTJYWjF5Z2hJeC8y?= =?utf-8?B?MUIyMm4yV2FlVi9MQnVEUVZzUnNWdDNBWkpTLzZ4ajhQaGVVUGdqV2hxbXNQ?= =?utf-8?B?OEpQZ1hndjFOYjJ3OHJTRmx5ZVVWKzlHQjQxbms0anF0TkFPOU5hYWtJa0ZT?= =?utf-8?B?cFZxcXUyQWt3bVBub01rWjM4ZlZzQzFVQm5NMlJrSHNBZllyV0RtZ05sd3dk?= =?utf-8?B?MUR6Y3ZTWWNNRlZ5WlFHM2FmK2VYNUVvMXNhdURVV1RDakRlMHNLMytWa0xn?= =?utf-8?B?T2c3WW9RUjJIWStjYWx5L2RLQTR0ME92TlVBUm9vd3ZHdVhjS250SU40UXls?= =?utf-8?B?VkwydEdUT3JqamFrMVlEdzFXdTJrNjJKb0NXTWN5aVRiUTZvNlBYNEl4SE53?= =?utf-8?B?NGk2ZWJlSk5vL21wRzZkRGtLM250UE1FdTVVWkhMSFIyaU11OFdwMXB3WG5R?= =?utf-8?B?WU1Vekw3eW5JdVh2eDZSN1NYRUFuR3NiQ2xQbHdyWE5tU3M3S3gvN1NUc3dq?= =?utf-8?B?endQOG03VmlJamxOU2lWdEVGOVNyWFFXYmJBZzFKWEY0dHcxWmhXNTRxMkp5?= =?utf-8?B?ZnhWY0M5d2xFLzBkM2VPMTNTODZnYVVPUENuNkxxME5xb3p2ZVhXL0NUbit1?= =?utf-8?B?Nm15ODFUVEROK0FuMEtyTjNmY0pQZ0k1RmNsRWdpSDVaN09HUlZPcXkwVGFG?= =?utf-8?B?bjlvRWg1cnRzTEZFYmpzWFpCeW4zVUcwWE5KQU10UEo4QUVNWUwrejlPN05a?= =?utf-8?B?eHpVbUQ2TkhhOXNVbXAyVjBuZTRpa0Rhb3dnU1J6MU1MVVVYTWhKZ3pvQ3Ev?= =?utf-8?B?OUNzcVR3QnZ0NndpcUo0RW5ibFppTnpBSDdiNEkwWXBtNXVvcTNFczdMZlha?= =?utf-8?B?dTVBUjk4NGxLUEY0L0N6NFQvL2tIcmdHU3puL0N5eDZCLzZhSEcvcm9nVzNB?= =?utf-8?B?S2pncmtrSmZubjE1NHhBNzk4WTZuamJaRlZZSS9xeWx4YXplQ0lSOWRPS2FC?= =?utf-8?B?N2tHWXdidGJLRG5wa3k2TDRMd3hqY3dtd2h2MklBTzBBeUZkSktHMXJFRDNO?= =?utf-8?B?Tk1QU1RFdmhMRHJleEZVOEphTnFBTDl4TGlyaXBCVjFyR1d3SkE1bEdnS1Q5?= =?utf-8?B?bzZrY2xoRHZYVFN6RHVGTlk4S21hNndWdHI5ekZTNlhxYitqb2x2ZXMzYm1K?= =?utf-8?B?WStZb2ErTjJWc0kzVFBVMU9iRmVLRGM2WDB2cW1KZDZnMVFmMCt0TWJjSHJ2?= =?utf-8?B?dTRGQXprbkFpYkFBQWpQNlBoRTA5YTJwRTN4R3lQWjhFdGlmeG9ySWwydzRV?= =?utf-8?B?azZUVldWK3lZeWZ5dVhsc3pjSzNDeGdpdU5IZ2lNVVQ0RXBnMnYwZWdoTyt3?= =?utf-8?B?UDlGc2VETDVRL09iREJrK2NKNHBTNEgweVdRcCtTem02R0FCbFNEK1FQNEds?= =?utf-8?B?SEV6dE1hSld4UzJKQjN6bjdCdXhqM0lHaXNIeWZ0RUpYdUtJNFYvN056K1VY?= =?utf-8?Q?qsz1eWaVST8Vdl1oU1Zy7Mi/v?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6415377-46f9-4589-875b-08dac8752b16 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 08:24:38.7221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lvZT5Q+6HpMgTfyolAauECGYtjAufdJESEkqWb3tnSc7nLTwDGHhqKgLoCKzHEuPXkYKulUA0fS4rM2N3xu5+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7604 On 16.11.2022 19:14, Andrew Cooper wrote: > On 15/11/2022 08:49, Jan Beulich wrote: >> On 15.11.2022 01:35, Andrew Cooper wrote: >>> I was really hoping to avoid this, but its now too late in the 4.17 freeze and >>> we still don't have working fixes. >>> >>> The in-Xen calculations for assistance capabilities are buggy. For the >>> avoidance of doubt, the original intention was to be able to control every >>> aspect of a APIC acceleration so we could comprehensively test Xen's support, >>> as it has proved to be buggy time and time again. >>> >>> Even after a protracted discussion on what the new API ought to mean, attempts >>> to apply it to the existing logic have been unsuccessful, proving that the >>> API/ABI is too complicated for most people to reason about. >> Like Roger I'm still having trouble seeing what ABI you're talking >> about here. Yes, there are internal handling issues, but that's hardly >> "ABI". And as Roger indicated before, anything domctl/sysctl isn't >> stable anyway. > > It absolutely is stable when it it extends beyond domctl/sysctl into the > libxl API, two different xl config files, and Xen command line (for PVH > dom0). > > domctl/sysctl are the very least of the problem. Which still leaves open which "ABI" you've been referring to. As Roger and I have said - it doesn't look as if we couldn't change the meaning we internally assign to what libxl has started to expose (and what the Xen command line option simply mirrors). Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 17 08:34:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 08:34:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444799.699863 (Exim 4.92) (envelope-from ) id 1ovaLy-0000fD-D7; Thu, 17 Nov 2022 08:34:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444799.699863; Thu, 17 Nov 2022 08:34:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovaLy-0000f6-AA; Thu, 17 Nov 2022 08:34:34 +0000 Received: by outflank-mailman (input) for mailman id 444799; Thu, 17 Nov 2022 08:34:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovaLw-0000f0-P8 for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 08:34:32 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20616.outbound.protection.outlook.com [2a01:111:f400:7e88::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6aec699-6652-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 09:34:30 +0100 (CET) Received: from DM6PR02CA0114.namprd02.prod.outlook.com (2603:10b6:5:1b4::16) by PH7PR12MB6812.namprd12.prod.outlook.com (2603:10b6:510:1b6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Thu, 17 Nov 2022 08:34:26 +0000 Received: from DM6NAM11FT114.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1b4:cafe::b5) by DM6PR02CA0114.outlook.office365.com (2603:10b6:5:1b4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 08:34:25 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT114.mail.protection.outlook.com (10.13.172.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 08:34:25 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 02:34:21 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 00:34:06 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 17 Nov 2022 02:34:05 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6aec699-6652-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hdzCeQXWxTHV1nq7C9MhEMZRBKKnXxAOYd416t9DeVrfdpJF86odmNFfWBmUfqqPbqdJVLiC1trDX3n4sU17gLEG7MKojeQHHNOENQqauFUdScfayQGf3yV9w9Uq12oUODrGnnL3dxBXMSIcf2ze4NZ8ZAqpKvJD/uW/UKQoepXRI0CLacNJQqOE0cwX0iQ0snscJpIhSUturhzLmTrfmtmLBKt39tmOxLyeFRq+o4pzfjWjT4VxCYCLOrwz34j0a1NXQnghySx6Uf3NlFBoDz9T8/LPt7DXoZcsiJaS1VtbPAjuOZ5lxltO+1uokCbMP1+BZidbtB4++Yd4404QWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tzOEbdn0xBg0ivQIQOKUgjDWPTyiibqvuwEaJmwY3Tg=; b=QyagpDsZXludAfYaukqLys4yyUhHqqw+krhxqa3tJSesGS7NFL8tnhO5rxvnx5rG6i46wpRJb1/+MrfLTudfpcCsfwcSBojns62XGJr1I8+hpYhUuk8fcIe6DJn5WDwpCetgRuyiI0vBcI62Pvopu6U5pBqnCnqW40EZB2G6HxU9QyNm5/E5Pt2iV/G7xmdC7AvbInGMlRWGj5Ka4LDBbvWkFZyKDwBmkDQ7eFb77WmTv8UQwT1gInRl45WkoK9dqbYKIAKB2Va+kQblrtNc238cV42xTJ5Vyj+ZGKU0OTditGkoaSn5Cp/8TPrUMnlLL7L20F8WBnoDZJ3MHgmvsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tzOEbdn0xBg0ivQIQOKUgjDWPTyiibqvuwEaJmwY3Tg=; b=5ubRvRmAGccKuAmEiuXtQo1mSEEkpvtXCJ+z/3fOePIKAEy42xgXYH9eswmSyiP1s/hCV5b3NYYQQ5FTHewj9s+0oZtoWBzy2n607RXjxabKESCkahYoM/9CT/B5iegLikRDjQvwWetjyXVF/4wWVAxj7GbLoZjQ5I9paNrwUjk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <85f4f42b-b1ee-36bf-5ba9-21b1047351cf@amd.com> Date: Thu, 17 Nov 2022 09:34:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> <0400b2d8-6f2c-6406-d966-64ed5720688c@xen.org> <350afafd-821c-1a05-13cb-1704d3a61bfc@amd.com> <84710d96-c473-fa41-d847-2b109dfb49c9@xen.org> Content-Language: en-US From: Michal Orzel In-Reply-To: <84710d96-c473-fa41-d847-2b109dfb49c9@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT114:EE_|PH7PR12MB6812:EE_ X-MS-Office365-Filtering-Correlation-Id: d4fdf15c-c5a3-49ab-85b2-08dac87688ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ur6BNWcCrtC7GIoVcINAnSBVnqoaNvlj04k+Rj4kFUJmfCtv57nc1NSC8f2cSPqgdPnTrK4kUW/tERhLrTqyywVF2SYGq7fvK96G+UCWuCYZsOcdt5Vz+Ymoy2pZpj2Gpq0yMifaRMSzlrZE6dsqVlWEIq9Q2tB+SYy/NWbR3Yjx+Q5wGebHnte2sk1XcdA+qU35naO3He2m9XnRoHhhWCcAjc2a1t6GTtoouHDr3oD7ALKjRrFVltbzt4WDSlFa6n/4M/KJLKvYn1p4rRMTdIzIbHBUHYir1e6cA0iy6eXLRHVbMSg50ThlwK1wYOhzTnKsdanYZL/NvhokhXXDf2A4OgAFwTavNjDC/9PUBG6vrlmkMqAEUunt5oQgOHwI4CwiX4FQjdXpQMw34oXofBqQQW3nBjFkvokWa/alEIsxOhz/3I04zjw7ZdG2oHWVLrqUJJhp2iEVr4uMnnVeEwWdf2lWvOqOOYJ0je6eJ75ZsNzgxOHA7bi0N2pmUtePCxaei1adpRxmfQidfb/uh+crYykadhQfXPr7AZS7dJ2L/8mNyNhvWFUPln1O7UXHXoOJw84D3xS+KLcd4FaOau/YcmojwvbV2YaGwgx+3k8NxZvuSNPuRGFi4A/T3sQAhYmRIh5fZ5K96muiG19FAzM13s5aoYU7d2svz4OYUwNJzqiUoPFd/EzgjYcMXugeHktPSr6BNXgqRw/jVDkL7bLhnx09y5R4igBtxiBC8fTHYmo7q96Z4i32nHVjeBO0rOupL23delBiHIkRvzpy1w== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199015)(46966006)(40470700004)(36840700001)(36756003)(31686004)(31696002)(86362001)(81166007)(82740400003)(82310400005)(36860700001)(356005)(186003)(83380400001)(54906003)(2616005)(110136005)(426003)(47076005)(2906002)(26005)(44832011)(40460700003)(53546011)(478600001)(8936002)(5660300002)(336012)(70586007)(40480700001)(70206006)(16576012)(316002)(41300700001)(8676002)(4326008)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 08:34:25.4660 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4fdf15c-c5a3-49ab-85b2-08dac87688ef X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT114.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6812 Hi Julien, On 16/11/2022 19:37, Julien Grall wrote: > > > Hi Michal, > > On 16/11/2022 18:05, Michal Orzel wrote: >> On 16/11/2022 16:56, Julien Grall wrote: >>> >>> >>> On 16/11/2022 14:45, Michal Orzel wrote: >>>> Hi Julien, >>> >>> Hi Michal, >>> >>>>> >>>>>> and use it in the pl011-debug files (+ there is a question whether we should define WLEN_7-5 for completeness). >>>>> >>>>> I would not define WLEN_7-5. That said, I wonder if we really need to >>>>> set the baud rate & co here? >>>>> >>>>> AFAICT the runtime driver never touch them. The reasoning is the >>>>> firmware is responsible to configure the serial. Therefore, I would >>>>> consider to drop the code (setting UARTCR might still be necessary). >>>> I do not really agree because the current behavior was done on purpose. >>> >>> EARLY_UART_PL011_BAUD_RATE is only used for very early debugging (this >>> is protected by CONFIG_DEBUG and CONFIG_EXPERT). This is not a >>> production ready code. >> I am fully aware of it. I just found it useful but I understand the global reasoning. >> >>> >>>> At the moment early_uart_init is called only if EARLY_UART_PL011_BAUD_RATE is set to a value != 0. >>>> This is done in order to have flexibility to either stick to what firmware/bootloader configured or to change this >>>> configuration by specifying the EARLY_UART_PL011_BAUD_RATE (useful when you do not know what >>>> the firmware configured). >>> The chances are that you want to use the baud rate that was configured >>> by the firmware. Otherwise, you would need to change the configuration >>> of minicom (or whatever you used) to get proper output for the firmware >>> and then Xen. >>> >>> Furthermore, as I wrote before, the runtime driver doesn't configure the >>> baud rate. This was removed in Xen 4.7 (see commit 2048e17ca9df >>> "drivers/pl011: Don't configure baudrate") because it was buggy and this >>> code is not simple. >>> >>> So it makes no sense to configure the baud rate when using early printk >>> but not the runtime driver. >> Ok, so we will get rid of EARLY_UART_PL011_BAUD_RATE config and setting the bd >> in the early uart code. Now, what about setting "8n1"? The runtime driver sets them >> as well as the early code. It can also be set to a different value from the firmware >> (unlikely but it can happen I think). In any case, if we decide to do what the runtime driver >> does, I reckon setting LCR_H should be kept in early code. > > Good question. I think, you would end up with the same issue I mentioned > above if the firmware and Xen have different line control registers > (tools like minicom/screen would ask for it). > > So I am on the fence here. In one way, it seems pointless keep it. But > on the other hand, Xen has always set it. So I have no data to prove > this will be fine everywhere. If we are relying on the firmware[1] to configure the baud rate, it is not very wise not to rely on it to configure the LCR. Looking at the other serial drivers in Xen, we have a real mismatch in what is being configured. Some of the drivers (omap, imx), apart from setting 8n1 also set the baud rate explicitly to 115200 and almost all of them do set 8n1. In that case we will not benefit too much from fixing just pl011. On the other hand, Xen follows the zImage/Image protocols for ARM [2] which do not state that serial port initializing is something mandatory. This could indicate that the firmware does not really need to configure the serial. [1] It is not stated anywhere in our docs. [2] BTW: our docs/misc/arm/booting contains invalid links to the kernel docs. I guess this wants to be fixed. > > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Thu Nov 17 09:13:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 09:13:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444806.699874 (Exim 4.92) (envelope-from ) id 1ovaxN-0005RZ-C7; Thu, 17 Nov 2022 09:13:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444806.699874; Thu, 17 Nov 2022 09:13:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovaxN-0005RS-90; Thu, 17 Nov 2022 09:13:13 +0000 Received: by outflank-mailman (input) for mailman id 444806; Thu, 17 Nov 2022 09:13:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovaxL-0005RM-R0 for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 09:13:11 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20625.outbound.protection.outlook.com [2a01:111:f400:fe12::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e11b4ea-6658-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 10:13:10 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9117.eurprd04.prod.outlook.com (2603:10a6:150:24::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Thu, 17 Nov 2022 09:13:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 09:13:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e11b4ea-6658-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eg7Uhtdk5SQMnBSaqv5ku6ZYEbmg3GKqL2kyKbcTjoBermrXMXr1PP1lj9kkEJlE4JJqkaPl5ZRZMEKcfUufBHR+7S07hRWd5eqGU5pLBC6dlsk1Gih+cuMe1u8GkPVVbhQZWzoWoOd0QJ3Wt2SpTcJx0iVoWGALtG9bPDKVscEEv+/AL25sk7CYvNIWTiZViuHerBhgzG01xfcNROuNQ2EJd29B34ysDmBM0rR0BKEAgnDaViW0dwsAFwz+okgAfhI3+rzPeuxGm5Kw+FngQ+gJizAjA/Z8+SXplRMVsMw2pLrTfu78PSKc0v3gwNtGabuXhmVg4b96RmZljQOVGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pUSfZFcPU8crlb93Lfga+nPUB1wmyzPdS0J2wO3SQFE=; b=WcLu6jvvl/U0Ti6YGU9VcB6szuClJ7BJJbb8dMKrJ5OQ2ZGPoAfvEam7i1/JFevMP9ozD/4cllVtJTuvadQwOc7XUUOtubEkn0mltQEc9MCuxNVuFHskcuc/twVQK8+EevtynbnErGKw1DOpP9rv9PuxL5GgAGKNAqoe2f0+LZfaf3k2Na/5vyTVgnoqSWlRIEg3Fld3mV37g/3MVrAmaeP/HjSVJezF8+QMyKfoKICXKta12D++mHvxXjYrjsf+0swWeuob1f1NPGGxNsVAPZ+2UMZ6Oc0N866lXScoaVLnXMYdzN8PQijQu+wPv/sws63/cdDEhtbFSU/zTNOXZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pUSfZFcPU8crlb93Lfga+nPUB1wmyzPdS0J2wO3SQFE=; b=OQeKomEAgR2UaMedty4R4VsU/jZRU76vRVeZ1K9u/w4SWihxWCEsmMxZ5/hKqy9uTXXCY3Go+0D4Dtiqu85oQaT9HIAHYEZdzEAVqfl3jrSmcq8I8Tp2Er8OO6/228/HTGn+2HhWDpe6OumiLImbOMy2VmU7bSd3I66Y8i9ftYgtOfeJHdO2YwK1QjQHKk3+HzlU4RQCmd51K+e4MEuqb50HFQf4L3m7ptbbEV4x0ndva8/apAQmRMF+rkMxngV3VcgbG21lXPIPOM3dKUb0+hYe43Wb2befyhM3sQy1DvIFzCwR0xq+kVTomXV16WvcA2s/Vr8N5C1RGaO2kbPdCQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <21476683-445f-fcb0-7a01-46d454039519@suse.com> Date: Thu, 17 Nov 2022 10:13:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2] x86/irq: do not release irq until all cleanup is done Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20221116122114.5260-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20221116122114.5260-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0048.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9117:EE_ X-MS-Office365-Filtering-Correlation-Id: f474a74c-904a-4e1c-fea6-08dac87bf03b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AKNhP7L8gW4JM9ueNCqWKpPQ7YQJu4gE0+OBHSvFM5pt7oK/IkGzrQd+Dm2Fts9B33FnWGhMDBqeTRUsH5Zb02NQK0EE/mn2SzFBCUSmTrHrVo+m/bpGhDVPGfY6Rl6rHMhe6RO4NRGHMZS0pcmde5AXlf04+LNMGBjOSSzGr0ciqtwsJFBIbMobNcQLnemZXfknrtfw71wItltcnQNkWfZUDAMRVJpAG6yXlL9s9CJlJI6aYQGwRDbIR+IJUvduq+DKd8p6WZDVcOXTUXUL/E7nPJWt72LMJgo5HUoUMQLa0YOt8FutnQ39YHfaSadLMeB3YbMauOA+9Zw0gZ9jUZA42+q9+dH55L1QjIPuRuFL5Hn4fFe8IcxXyQpZPYJdHl1KJmb/zCFx0J9+8NH4jt4APoYBouw8+ud0wcy3gI1/sdhNqNN30f4LVpa47XHA8Dhx/fmbIgSlenqMIOz4e1R2g158AGYfieOEYpMLN5I6otRrQ0Ysb4rtIb+0ddCNlIUVNOU6N8a49qmXJOee5uOuGspfhhmqxJqnZ4FrDCH2GwX9HhPIOoVPKH8miop6IQuWI9Aa1iOiscEjLzJhrtWKmsiq2PvSIHZoxwkJ5IJGKOUd0870wVgQqhWHicPGWul2HHkZR6+Bk9JsljQi+DvDhHXpQwjxffOtdVxBnXy+1oLnmWtfG/NO+3M42nqF41ugKVPGN5Mi4xe+L8NSzH7eQjVsv9D5TDTpKc4cpcU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(366004)(39860400002)(136003)(396003)(451199015)(66476007)(316002)(54906003)(2616005)(478600001)(36756003)(186003)(53546011)(26005)(6506007)(6486002)(6512007)(38100700002)(6916009)(83380400001)(31696002)(86362001)(66946007)(4326008)(8936002)(5660300002)(2906002)(8676002)(41300700001)(31686004)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1NLbzFwKzZVUTBidng1TVZ1TXNGOFBRQUNOL0Z2bmNMYThZRVdZYVR4WmZm?= =?utf-8?B?R0VkcC9yOFR1WGRHZVpwazJyTmpXdjgyNGZPcFF4aDA1VnpQZEdNTERpd1Vi?= =?utf-8?B?UjhiUFArQ2NxMDhyME1QOFZzMm9ZcW9LNTBubFNIVkZDZlBMMzhDdzVadFgz?= =?utf-8?B?elVMVkQrb0hoSnptQ0lxZFcvVVZ5OFBEWjBIMEV2YTJKZXg4QkJ3TC9ERlZw?= =?utf-8?B?RlNNZ0xOMjZoL242aDRxZnNTS0VwK0g0alRTRExqcWJjRFdaMjFBZWFoYUdK?= =?utf-8?B?RzNrcVpvQUJaTmp6TUZnTWQ3bHZxNDRBcCs3WkFtUkphb3JmUUdvcDVvNDhN?= =?utf-8?B?VEZubVpxNTFHaUxhbFpHL0Z1WWVVcHVGZGU2OFZZVlgrVFBHdUorQ0tmdjNa?= =?utf-8?B?ZEljTkV5MDRXOWpQUnpiby85c3ptdXEreXYxb3Fqb0RmZGJ5ZUZmZVNCejZP?= =?utf-8?B?WEk4dnZWL1ZGK2FkdStzc2hPcXVZU1lPUi9hRmEzQjFoZ2l6WFVuRmNxWWhS?= =?utf-8?B?TVR1ak9WQlhESy9yYzJ4ZEZmK3c1bHdsQitJaTBhdnNMNmZWcFdtWXdJYXNI?= =?utf-8?B?S0xyYWdRTnhWdWJHUm9ZbTBrZm5TVWhWR2R4enMrR0dKS2huK0hqS0Flc25P?= =?utf-8?B?TC9uVUtIdlpxZ01vRmxUMkRpNlpiV2dLM1BiMUk3bjhjaXlWb2RucHZFSUhM?= =?utf-8?B?eHZPelN4a09CWDc1VUdEcExBTXZzSWRCTXNDSGlmV0MvQjRCM3ZDZzlvSEx6?= =?utf-8?B?RU5aeko2aWQ5aWV3bGRVbDFXbmVMSDhiREExZmx6a0ZNdmg1a2pYd1B2UmJL?= =?utf-8?B?MjFQMjc5V0xoYmE2TnIxRk1YbE1DT09OcERLbnZzckVUcTdISHIrcE16bHl1?= =?utf-8?B?NEtHVXhldHhUN2RtVEJHQ3A4QmJJVlVBcTRMQ1lsUHVudnRiVGdHRkxOaWc3?= =?utf-8?B?NFBTQVUvbG9kNzJrUTVmQlZCMzI4S1lPNXRhTklUVmxXUUtYdk1KdEhuZTh1?= =?utf-8?B?dkRRL2ZlU0YxZnJ6cHljc1JFQzZSamdkUGFYdXRDOUluRXhod0V1K1VISU5w?= =?utf-8?B?NEo5L2dlcUZJRXo5anFKZUgwVEtrS1FkellwUzByQ2hOd2hIRDd4M1RtVmJY?= =?utf-8?B?REs4WFd4ell0anhvTnhVeVltRHlWd3ZuUER1b3JjZmlEcnlHRUErTml4Wisw?= =?utf-8?B?RG9ZSFFDUTAyZ3grQnh5cC9qbEFTQmtpSkt4U2dMV29ydU9vdXAvTEVPRTJH?= =?utf-8?B?dTc4S1Z1cmJ6WVdXdWVBeWlUOUNxS1hQOG9ZZEIxVVBEeEc4SkU2cy9WWHJB?= =?utf-8?B?ZmZtVDFtVXVoZVpobUtYbTVqZ2VnZXN6TlpBNHdtYTZIN0lJaGZuZlV0T2lR?= =?utf-8?B?bVZEZmkwMjJqdGZPblZJRWpNd0QvSUErTGI5bjV6ZjZsa2hCRGNIUEpNVTdq?= =?utf-8?B?MHRudlhjZWI1ckFtblYrRW1rTnYyM1FFVUdZYTl0VmZvdW1oV2VCYUtDaUpo?= =?utf-8?B?bVhCdkl0ZnBPQlo3a0ViTnYwdy9lUlorMG11d2R4bXNhQjVpYU5HUkRjVzIy?= =?utf-8?B?T2tocHlKWHlydi81YVI0TWNJSmVoemNldWxPWkFML3JmM1pNbUJEWW4zZmVF?= =?utf-8?B?UTBhWVU5SXJjQkxjOGl6VHNZeEwrVzNIZ1E0WkNKTWJzZkp3dS9tNXp4UGMw?= =?utf-8?B?emkxa2puTy9kSFhtRzZrRFdPT1EyU2tLWmp3ZWE1RXQ5emg3SzMyMUh2QVVs?= =?utf-8?B?WnVHQTJSY2dJTTQ1eEcyZmdIb0Ivbk8zNDlWZmtCMENidW53RktXQmRBUXdU?= =?utf-8?B?K2wwcHNYOHN6eW9KdkVna3Awb2MwNVNVNlpERGJ2eU9kNnB2ZjRwTEd5eXpI?= =?utf-8?B?dGNiRTFtNXZCV28ram5iL1VFcisydDA3c3BzS1F3eXdwV0sxLzlORnpteUh2?= =?utf-8?B?dWJ3cm1OWUNFV1paMys4VUtjOWE0cW1vdlV6eVlEck0zSE00anBlZEdnd2Nk?= =?utf-8?B?OWYxWlFNOTVCN3NsUkdpT0ZvRmRtTHplbkhYNWNvOE5QMHBvU1FYQXBuTnFt?= =?utf-8?B?ZG5uRWlOWTQwVTBtNlhpN2t1NERQZ0ZzZHNmSER4YkJFanVGVDVsRkU1ZWJ4?= =?utf-8?Q?OVIHCVhEbKKBjgPUZHno8goh8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f474a74c-904a-4e1c-fea6-08dac87bf03b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 09:13:06.4592 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N7Skeb2LucvbL+ideVw/4lgHoa97N3mDj0jzCt9q1JK4VCf3uzdCpDU6jd/TEscMvD0y+5qMIMLlrqhZOtckPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9117 On 16.11.2022 13:21, Roger Pau Monne wrote: > Current code in _clear_irq_vector() will mark the irq as unused before > doing the cleanup required when move_in_progress is true. > > This can lead to races in create_irq() if the function picks an irq > desc that's been marked as unused but has move_in_progress set, as the > call to assign_irq_vector() in that function can then fail with > -EAGAIN. > > Prevent that by only marking irq descs as unused when all the cleanup > has been done. While there also use write_atomic() when setting > IRQ_UNUSED in _clear_irq_vector() and add a barrier in order to > prevent the setting of IRQ_UNUSED getting reordered by the compiler. > > The check for move_in_progress cannot be removed from > _assign_irq_vector(), as other users (io_apic_set_pci_routing() and > ioapic_guest_write()) can still pass active irq descs to > assign_irq_vector(). > > Note the trace point is not moved and is now set before the irq is > marked as unused. This is done so that the CPU mask provided in the > trace point is the one belonging to the current vector, not the old > one. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Thu Nov 17 09:27:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 09:27:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444811.699888 (Exim 4.92) (envelope-from ) id 1ovbBS-00077a-LA; Thu, 17 Nov 2022 09:27:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444811.699888; Thu, 17 Nov 2022 09:27:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbBS-00077T-Ho; Thu, 17 Nov 2022 09:27:46 +0000 Received: by outflank-mailman (input) for mailman id 444811; Thu, 17 Nov 2022 09:27:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbBR-00077N-Mg for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 09:27:45 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20603.outbound.protection.outlook.com [2a01:111:f400:7e1b::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 176f5a7b-665a-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 10:27:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7940.eurprd04.prod.outlook.com (2603:10a6:20b:240::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 09:27:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 09:27:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 176f5a7b-665a-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ky8uqcKQPFaAXClqnl3xcZ1Q2SlKn+qu3sOXpCMSmaGQ0iwUhQhKI09tWj8uVlwtBKSSab4m0yGfUxw4b/MOdqbV3DX7l3jaHXZ8/xGM3B8J8Nhht+V9ECkyZaX3uEFbIu18ZaroK31cx82T4xk4XhY2f7+Pdk0HuQvk2aaVertMFYrBkelHpPgb733q7vEQPm4cooGtVjvq55U4x1IZtINdfjQGTSkAu2PTNgw5d/nlfDy8I6ckmHhV29hGeq3Sdz4CvS6FfDSi1CxBNcQM8jiUj+8bRPQ6OKNFMuMRS9ymi1ZdgUm+cgVZKL9XMW4XpbvDuWtVn8kHXkFFznAhNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TVo5WaeRDymC7yCopczXUzOTLCa5bghCYDb5eD8uuBk=; b=E8rt2nkxDI/xcwy1TOsGb9Pg78QT6gwE9yTxZ3lO4/IdJtkADPIjj2H163cqUGJ81eDcKJsz4PZHTbi33KMWTV4zig22UAl56nQrN9retnSLAt5bA72vRT2OOPDPuLoxzq3BdEXU2ySHyjNrrwcSnKnYRhauO6EgPw7fUz34K+pJzhnbe/vMQuNBj8eowcE8G4v5ssmGwJLwEtL9IsyFZCN4/A7t2+sZjQR5Kr8ilTym/fF3BDDYNYshCGH7Bdi9AbqMU8TANG9oyBrYX3ph/cP8qgDJGa81IuE1QJh/FCVaIVdtZn2TiwhtkKBg9/ljkXWFcWtxiZhvjQHhObsm/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TVo5WaeRDymC7yCopczXUzOTLCa5bghCYDb5eD8uuBk=; b=e8FrbSRKJpHGy79lxu3Aygpm8EjZWT3wxGG0fEgY2aXpW6abI314s+Cn+kWM+i5ia1SWDvu2CdkyoF/Xq07XKu/sb/384hpocIqKJlqAjrF3EBTO9LgaCR4h/UVlKAMadOmVrgyIU1C5w3ZMtSEQ3b0Tnd5uKNt6bIsoDY/zWsnhrMn9S6Ou5goox5uDE34OK3GKbJMdP/acX66/B5vasY3+j2gLCuDnTDGFm2uGTTo7KnowIhtGmaFc8ozAjEhcclcP8K4K0G5XjRu4d7OfAYVXPsNuFLi0WKxU4LFDNyCDjyGhIxwjNO0puwSyBfPCX/qZB8GN0b1jK1f6qV6Frg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9b559146-11d8-f848-d6fa-baed7e0fa06f@suse.com> Date: Thu, 17 Nov 2022 10:27:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0 Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20221116164216.7220-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20221116164216.7220-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0136.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7940:EE_ X-MS-Office365-Filtering-Correlation-Id: cf591427-0159-42d7-d7ec-08dac87dfad4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yqshM2rslEXoZfFipMXa7TM8wcJgCoJHtedlhmrR1AKd3yNRU/GiY3ZRoTlj7d2HPNqhE86E7BhBHNNS4vY+o2SOy+LUb3BWziPST+SkcOGdabu5Bh4OQxkkUn0+i27XRXYqMKy9VVPV56pXsWElQieu2JUZ5N5o3PnSR/TwGy08YWKji0Q0Q2Zsz4sGEZKUV4GO9xTdXZ8lZhgVmUxUxKkWZQkh4h7NgQQaCkCORn5qPY7nsDTIT/e04zjeksrO7j3yINTFzoQR2Ib5NtRs0QeJMNBu0TqaBGaigSkraaVntLA/5O/4IjLLNmnTJzgxmzfGKbciyJrv9/Qz6vEkGFu5sqJ/9eKyDX28f5ZsMgWksDwiSKx1IvmEuPlgq9z1Ev824pQjiFfBNqCE/9bR2zsmslb1Az6ct6jd4SaezIrBjTPePUX1n4NVOzoeq7mC12SmwMy1Wdj20jAZy+9n9iQd7cD+y4eAtljDrs27+1NhFlXIshEJoNv2kvB0Vr85eh/NU9yNS/9Ou1FVEvlhg5ydUixPlJGtYBLyDa3NeJeNBl7NtaLfee5D6zrnMkqEOxhSFZZQTHZol45bOO5Oz0pJ3v7HLZbBPJevkcNZXyQDpLIz9/s30blWa0BdMQZzBe4Cef5i1uxX+WODO4Bu+2TmnVLdtPojyYtdr0LGKRywpVqH8uMmAxobPLpxssfuYueO6iP1VLhcztQGPnj35jPsCsgmBjuHSflaSozXQTk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(136003)(366004)(39860400002)(396003)(451199015)(86362001)(31696002)(2616005)(66556008)(66946007)(66476007)(41300700001)(5660300002)(4744005)(8676002)(4326008)(478600001)(186003)(26005)(316002)(6486002)(6512007)(53546011)(6916009)(36756003)(54906003)(83380400001)(6506007)(8936002)(38100700002)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjFmUG5aWEJXNGUveUFrRHJaT0IyNm5RRkU1M1pjS2VWWmZwLzdYRVVNamFi?= =?utf-8?B?YnpVZHJzY1dIenNrOHJRVFg3TnFSTTdGR2FyYWZndTNTRndPM3BqSi9zWEVm?= =?utf-8?B?ZWJkbXBuTlg5dGlGZGREYkM5NmdMT3oyeUtLcFhFY2JFbTRxM3dYWFNKVitP?= =?utf-8?B?bTQwM01sWnZPU2tFb1FvUlVHNVVldyszczJDQ1ZnTllRVE1zYW9jUGRnMWdi?= =?utf-8?B?RXd5WmhUWDFYTFVyczZKbmswZ1RmY0w5VFE3bkNLeTZHYWRUNFRsb1daRHdJ?= =?utf-8?B?U1A3cllSSTVPbzlOWnNBb1BxUmVVdmxaczVlNlZBRFc4SDllY3NsZXFaZFE2?= =?utf-8?B?NFplNnA5cEt0aGtMa2N2SFQ2MFRaOVlSZW5MampiU1JmTGNlOHVPR1llZFlz?= =?utf-8?B?SHNBV3dvbERSd2VleXFoRmhpeE9PVW9DVlQ2dEtEb0pqNWVuRXFGblFYTmNC?= =?utf-8?B?VGJSQmdCRDgrUFBWZElZYnVIWjE0RGZ6emw1eE9vS2NRdHR3RnIyREFUdmtB?= =?utf-8?B?ODYrZ1JGb0Vud0xyM2VMaGFiUnBTY1VkOWN5SytrVHJzOVNSUGpydXJGalp3?= =?utf-8?B?Y1ZISHJRa09PUGlGOEp1YlVaMkZUcUdCN0M1K2ZIRzYxQlFGK1lldUlQR2Y4?= =?utf-8?B?MXVHWlFId01JL0M4VUFXUENQWTh5d0tsV1VsUGZNejlUQzN4OUVEenJqc2xK?= =?utf-8?B?SW5CcCtCR01iMmMzRGxaMkJ3bmczbTZmekNJYUxKZDMwWWFJSjdpRHhiQWRC?= =?utf-8?B?VUN1WUxlbS9LV05NRjJ5QklzTUJQNUpCemZ2bUVJMGVwNXpGZ2ZqRnVobXAx?= =?utf-8?B?VGYzWHlNU3ZXaE9NbzNkK3h0WkV2cUdCVVlPb0lPZFZHSzNxSHgya3pJYzFx?= =?utf-8?B?eVRTMmJ0aTFaYmNTYjhGaEhpQmZDVFFKSVBhLzZ5V1VBRW51YkdmQm4zZ2hl?= =?utf-8?B?K3g3RDZYc3hWcno0bXVmYUt4c1dtSW81SkNOVnpqbFBSNWorOEd5eERkRlJu?= =?utf-8?B?MW1NWXNITVpBWUs1bFJKS3RpZXBFL1RNMmd1eEpKYU5WTVZVdDVxQ0V2Wk4z?= =?utf-8?B?OXFKSVZ1b1d1dlZkZ0w5ckNvVS9vTGZZWU45bUFBenJjbWFGL1VEWVN2UndI?= =?utf-8?B?eDVtSkFjSUg0Z0sweVJJOGxDQ21KcEVJOElzSWpGQWY5SkVRUmxRQTJwWXBz?= =?utf-8?B?NUNqSE5xa2VYcmUwdkVab1UwVXdSSU5yTTUzVmhpZENSNk52VXAreUtjUFo1?= =?utf-8?B?YjZKYkhFMFUwWEJaWUFtRm0xbXI4UmxNTG9oTFlMZkpnZmlYblkyWWFqbitE?= =?utf-8?B?M0ExL3BhTDQ4eEgrNDFIY2syWm5xTHZvd1hPK1J1SHhaNkl2My80N0QvY3VF?= =?utf-8?B?WjRaaDNERnBNL3VUQUo5Z2tjT3BCK2FwdUtyN25hUGQ2d0QyU2xBS09yWTBE?= =?utf-8?B?cmgzb1U5bjhtbFFaWmQvdmM2eWIrMk5qWFRrM1NIYVJ4M3RiTDYyY2wxcGxI?= =?utf-8?B?VnlWSzh0NHhhVC82di9nSkh0Z0dzZ2MyWmFWcUFNMVYwaXJKNWNkNE5yZ3ho?= =?utf-8?B?ZkgyYlh2M0NDUUdReFQ1ZS91aGNkWlN5czRkYzJCTnhybHA4ZWVwNDNtNFdw?= =?utf-8?B?VHRhbTBON1Z5TXVaT2c0MVdHdjZleTBlRUE5eDFhN2RsdWhEWEVEa0RXTTlq?= =?utf-8?B?N2FMcElyUDhpNVNzZU9aaUpVR3F4VVM4a3VjdkxFUGRKZlNZT1l2Szh5R1pl?= =?utf-8?B?M2xmVWJVdWsxb1ZONWNqU2NTUnNHN0FxOWJMZkpGUUUzdS9hWXk2cUhVOXFN?= =?utf-8?B?eWxrdFd3M1FVaDMwUGJ3Z2NKYWpmSnFIcHZkNGlQdnhuWFdqWFZ0MGI1VUx3?= =?utf-8?B?MHdzdkxqV0xmSkNJb0NuZnk4Z2hGK3R5WldWTDNUS0VXYXdja3JoQXIxSGFl?= =?utf-8?B?OHYwK0NWSmxLVnkvYVRkc0lic3lxbUpnKzN6andjQmVncitQU3h0WGRBbmdr?= =?utf-8?B?ZmYyZzhWVisyR0VVVGxaV1dNc3JsOEFWSzlMbWd5aXdidzBJRmw3MzRueWlp?= =?utf-8?B?ck5ZNHBzRWhha2RySW91QkswMXYzZ3p2dCt1M3dSSFYxcmhqcHNKbFZRbjd2?= =?utf-8?Q?H7NQAtLt/dXHYSwltWLZbpOt+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf591427-0159-42d7-d7ec-08dac87dfad4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 09:27:43.2316 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BaDbJ1ilvfekdJz3VSN0seCgs2scOAOP9ecc3ojG+UyK1DBhxxfW4+lcdGzen6QmJwde9WKoQlpOH7U+42cnPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7940 On 16.11.2022 17:42, Roger Pau Monne wrote: > Currently Xen will passthrough any Local APIC NMI Structure found in > the native ACPI MADT table to a PVH dom0. This is wrong because PVH > doesn't have access to the physical local APIC, and instead gets an > emulated local APIC by Xen, that doesn't have the LINT0 or LINT1 > pins wired to anything. Furthermore the ACPI Processor UIDs used in > the APIC NMI Structures are likely to not match the ones generated by > Xen for the Local x2APIC Structures, creating confusion to dom0. Plus we should have passed through Local x2APIC NMI Structures then as well. > Fix this by removing the logic to passthrough the Local APIC NMI > Structure for PVH dom0. > > Fixes: 1d74282c45 ('x86: setup PVHv2 Dom0 ACPI tables') > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich albeit with the implied ack in there provisional upon Andrew accepting your response to his reply. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 17 09:29:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 09:29:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444816.699899 (Exim 4.92) (envelope-from ) id 1ovbDA-0007fp-W7; Thu, 17 Nov 2022 09:29:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444816.699899; Thu, 17 Nov 2022 09:29:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbDA-0007fi-Ss; Thu, 17 Nov 2022 09:29:32 +0000 Received: by outflank-mailman (input) for mailman id 444816; Thu, 17 Nov 2022 09:29:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbD9-0007fa-PY for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 09:29:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbD9-0006En-CL; Thu, 17 Nov 2022 09:29:31 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.7.117]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ovbD9-0000dH-5s; Thu, 17 Nov 2022 09:29:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=NXvCIXwKm5qyx6kWPp043oS0rkyzN44t1tWw2RAuqF8=; b=OoVsCGKAMVa5NzoCAfDDrIBWpX 7UP5zsnLWhOREAqTg+TMnU3el9CDcF3hoZU1dmyO0trZOtrpmV8W8sPEuukNm7WWVhAD/8sFruLEJ m5Or+INHb1+x1q3u7ZYTc9pfLQOoiZKkuhlgJcgRkuPi/CBGRa1wx41aus7p/81AH1/Q=; Message-ID: <7d3f9021-d608-9e8f-9593-1099d7bd2003@xen.org> Date: Thu, 17 Nov 2022 09:29:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> <0400b2d8-6f2c-6406-d966-64ed5720688c@xen.org> <350afafd-821c-1a05-13cb-1704d3a61bfc@amd.com> <84710d96-c473-fa41-d847-2b109dfb49c9@xen.org> <85f4f42b-b1ee-36bf-5ba9-21b1047351cf@amd.com> From: Julien Grall In-Reply-To: <85f4f42b-b1ee-36bf-5ba9-21b1047351cf@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/11/2022 08:34, Michal Orzel wrote: > Hi Julien, > > On 16/11/2022 19:37, Julien Grall wrote: >> >> >> Hi Michal, >> >> On 16/11/2022 18:05, Michal Orzel wrote: >>> On 16/11/2022 16:56, Julien Grall wrote: >>>> >>>> >>>> On 16/11/2022 14:45, Michal Orzel wrote: >>>>> Hi Julien, >>>> >>>> Hi Michal, >>>> >>>>>> >>>>>>> and use it in the pl011-debug files (+ there is a question whether we should define WLEN_7-5 for completeness). >>>>>> >>>>>> I would not define WLEN_7-5. That said, I wonder if we really need to >>>>>> set the baud rate & co here? >>>>>> >>>>>> AFAICT the runtime driver never touch them. The reasoning is the >>>>>> firmware is responsible to configure the serial. Therefore, I would >>>>>> consider to drop the code (setting UARTCR might still be necessary). >>>>> I do not really agree because the current behavior was done on purpose. >>>> >>>> EARLY_UART_PL011_BAUD_RATE is only used for very early debugging (this >>>> is protected by CONFIG_DEBUG and CONFIG_EXPERT). This is not a >>>> production ready code. >>> I am fully aware of it. I just found it useful but I understand the global reasoning. >>> >>>> >>>>> At the moment early_uart_init is called only if EARLY_UART_PL011_BAUD_RATE is set to a value != 0. >>>>> This is done in order to have flexibility to either stick to what firmware/bootloader configured or to change this >>>>> configuration by specifying the EARLY_UART_PL011_BAUD_RATE (useful when you do not know what >>>>> the firmware configured). >>>> The chances are that you want to use the baud rate that was configured >>>> by the firmware. Otherwise, you would need to change the configuration >>>> of minicom (or whatever you used) to get proper output for the firmware >>>> and then Xen. >>>> >>>> Furthermore, as I wrote before, the runtime driver doesn't configure the >>>> baud rate. This was removed in Xen 4.7 (see commit 2048e17ca9df >>>> "drivers/pl011: Don't configure baudrate") because it was buggy and this >>>> code is not simple. >>>> >>>> So it makes no sense to configure the baud rate when using early printk >>>> but not the runtime driver. >>> Ok, so we will get rid of EARLY_UART_PL011_BAUD_RATE config and setting the bd >>> in the early uart code. Now, what about setting "8n1"? The runtime driver sets them >>> as well as the early code. It can also be set to a different value from the firmware >>> (unlikely but it can happen I think). In any case, if we decide to do what the runtime driver >>> does, I reckon setting LCR_H should be kept in early code. >> >> Good question. I think, you would end up with the same issue I mentioned >> above if the firmware and Xen have different line control registers >> (tools like minicom/screen would ask for it). >> >> So I am on the fence here. In one way, it seems pointless keep it. But >> on the other hand, Xen has always set it. So I have no data to prove >> this will be fine everywhere. > If we are relying on the firmware[1] to configure the baud rate, it is not very wise > not to rely on it to configure the LCR. Looking at the other serial drivers in Xen, > we have a real mismatch in what is being configured. Some of the drivers (omap, imx), > apart from setting 8n1 also set the baud rate explicitly to 115200 and almost all of them > do set 8n1. In that case we will not benefit too much from fixing just pl011. It is not great that Xen hardcode the baud rate (I can't remember whether there was a reason), but I don't think the consistency is necessary here (see more below). > > On the other hand, Xen follows the zImage/Image protocols for ARM [2] which do not > state that serial port initializing is something mandatory. This could indicate that > the firmware does not really need to configure the serial. The firmware doesn't need to configure the serial and yes in theory Xen should configure the baud rate and parity based on the firmware table. However, this is a trade off between complexity and benefits. The patch I mentioned earlier has been removed nearly 6 years ago and I haven't seen anyone reporting any issues. Hence why I think for the PL011 it is not worth looking [3] at the baud rate and instead removing it completely in the early PL011 code as well. That said, if you feel strongly adding support for baud rate then I will be happy to review the patch. > > [1] It is not stated anywhere in our docs. Our docs are not perfect. Patches are welcomed for improvement. Although, I think the statement should only be for driver where we don't set the baud rate. For the others, we should leave it as is unless you can prove this is not necessary (we don't want to break existing setup). > > [2] BTW: our docs/misc/arm/booting contains invalid links to the kernel docs. I guess > this wants to be fixed. Patches are welcomed. [3] I do have a large list of more critical bugs that I will be happy to share if you are looking for improving Xen. -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Nov 17 09:40:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 09:40:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444822.699910 (Exim 4.92) (envelope-from ) id 1ovbNN-0001a8-VU; Thu, 17 Nov 2022 09:40:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444822.699910; Thu, 17 Nov 2022 09:40:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbNN-0001Zv-QE; Thu, 17 Nov 2022 09:40:05 +0000 Received: by outflank-mailman (input) for mailman id 444822; Thu, 17 Nov 2022 09:40:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbNM-0001D0-2E for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 09:40:04 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id cf6a3cb0-665b-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 10:40:03 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 99971150C; Thu, 17 Nov 2022 01:40:08 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 982EB3F73B; Thu, 17 Nov 2022 01:40:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf6a3cb0-665b-11ed-8fd2-01056ac49cbb From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: michal.orzel@amd.com, Doug Goldstein , Stefano Stabellini Subject: [PATCH v4 0/3] Yocto Gitlab CI Date: Thu, 17 Nov 2022 09:39:48 +0000 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series is a first attempt to check if we could use Yocto in gitlab ci to build and run xen on qemu for arm, arm64 and x86. The first patch is introducing a container template from which container files can be generated for all combinations we want to support (qemu arm, arm64 and x86 targets and hosts x86_64 and arm64). It is also introducing a generic build script (build-yocto.sh) that is used to create, build and run a Yocto project. The second patch is adding a way to easily clean locally created containers. The third patch is introducing some gitlab CI templates and jobs so that we can test a Xen source tree in gitlab-CI using Yocto. This has been tested on a x86 host machine and on an arm host machine (with mk_dsdt.c fix). Changes in v4: - rework the container generation to support multiple hosts - rework the container generation to use a single template for all docker files (make process is generating the docker files). Changes in v3: - limit number of jobs in yocto - do not copy build script inside container - add patch from Michal to create gitlab jobs Changes in v2: - remove gitignore patch which was merged - add a --dump-log support in build-yocto.sh script and use it during container creation to see the error logs. Bertrand Marquis (2): automation: Create Yocto docker images automation: Add a clean rule for containers Michal Orzel (1): automation: Add CI test jobs for Yocto automation/build/Makefile | 26 +- automation/build/yocto/build-yocto.sh | 349 +++++++++++++++++++++ automation/build/yocto/yocto.dockerfile.in | 114 +++++++ automation/build/yocto/yocto.inc | 41 +++ automation/gitlab-ci/test.yaml | 43 +++ 5 files changed, 571 insertions(+), 2 deletions(-) create mode 100755 automation/build/yocto/build-yocto.sh create mode 100644 automation/build/yocto/yocto.dockerfile.in create mode 100644 automation/build/yocto/yocto.inc -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 17 09:40:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 09:40:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444827.699921 (Exim 4.92) (envelope-from ) id 1ovbO1-0002Nn-A3; Thu, 17 Nov 2022 09:40:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444827.699921; Thu, 17 Nov 2022 09:40:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbO1-0002Ng-7H; Thu, 17 Nov 2022 09:40:45 +0000 Received: by outflank-mailman (input) for mailman id 444827; Thu, 17 Nov 2022 09:40:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbNy-0001D0-QA for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 09:40:43 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id e6c6e6c4-665b-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 10:40:42 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BDD4113D5; Thu, 17 Nov 2022 01:40:47 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A2AB53F73B; Thu, 17 Nov 2022 01:40:40 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6c6e6c4-665b-11ed-8fd2-01056ac49cbb From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: michal.orzel@amd.com, Doug Goldstein , Stefano Stabellini Subject: [PATCH v4 1/3] automation: Create Yocto docker images Date: Thu, 17 Nov 2022 09:39:49 +0000 Message-Id: <6d48a0f83324d2f42597d43c41ce72d6d80150e6.1668677493.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add containers suitable to run yocto kirkstone build based on ubuntu 22.04. It contains all packages required by Yocto and a checkout of the layers required to build Xen with Yocto. Add a generic docker image template to be used to automatically generate docker files for different configurations: - specific yocto version - different targets (qemu arm, arm64 and x86) - different host platforms (x86 or arm64) During a call to 'make all', only the images for the current host platform will be generated. If needed, images for an other host platform can be generated manually by calling the right make target (see make help). Add a build script to build and run xen on qemu using Yocto. The script supports arm32, arm64 and x86_64 and checks that dom0 is properly booting. At this stage this does not run any guest on top of dom0. The script is to be executed in one of the docker images to build and run a system using a Xen source tree. Signed-off-by: Bertrand Marquis --- Changes in v4: - Rework the system to have one dockerfile template from which make will generate the required dockerfiles for the wanted configuration - add support for different host architectures - Merge the generation system into one single dockerfile - Merge patches 1 and 2 in a single patch - Introduce CONTAINERS_EXTRA to have extra containers not built by default (for those not used by CI but useful to users) Changes in v3: - limit number of jobs in yocto by default to 8 and add --num-jobs option to the script to set a custom number of jobs - do not copy anymore the build-yocto.sh script inside the main image so that the current one in the repository is used when running Changes in v2: - add a --dump-log command line option to build-yocto.sh script to dump the logs if an error occurs. Changes in v1: - add --image command line argument to build-yocto.sh to allow building something different than xen-image-minimal. - modify dockerfile to have one layer per line and make it easier to add other. I kept the for loop to keep the number of docker steps lower - update commit message to warn that no guest are tested. - fix build-yocto script to properly return with an error if expect script ends up in timeout or EOF. --- automation/build/Makefile | 14 +- automation/build/yocto/build-yocto.sh | 349 +++++++++++++++++++++ automation/build/yocto/yocto.dockerfile.in | 114 +++++++ automation/build/yocto/yocto.inc | 41 +++ 4 files changed, 516 insertions(+), 2 deletions(-) create mode 100755 automation/build/yocto/build-yocto.sh create mode 100644 automation/build/yocto/yocto.dockerfile.in create mode 100644 automation/build/yocto/yocto.inc diff --git a/automation/build/Makefile b/automation/build/Makefile index a4b2b85178cf..72a5335baec1 100644 --- a/automation/build/Makefile +++ b/automation/build/Makefile @@ -1,13 +1,18 @@ # the base of where these containers will appear REGISTRY := registry.gitlab.com/xen-project/xen -CONTAINERS = $(subst .dockerfile,,$(wildcard */*.dockerfile)) +CONTAINERS = $(filter-out yocto/%,$(subst .dockerfile,,$(wildcard */*.dockerfile))) +CONTAINERS_EXTRA = DOCKER_CMD ?= docker +include yocto/yocto.inc + help: @echo "Builds containers for building Xen based on different distros" @echo "To build one run 'make DISTRO/VERSION'. Available containers:" @$(foreach file,$(sort $(CONTAINERS)),echo ${file};) + @echo "Extra containers (not built using make all):" + @$(foreach file,$(sort $(CONTAINERS_EXTRA)),echo ${file};) @echo "To push container builds, set the env var PUSH" %: %.dockerfile ## Builds containers @@ -16,5 +21,10 @@ help: $(DOCKER_CMD) push $(REGISTRY)/$(@D):$(@F); \ fi -.PHONY: all +.PHONY: all clean all: $(CONTAINERS) + +# Remove generated dockerfiles for yocto +clean: + rm -f yocto/*.dockerfiles + diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh new file mode 100755 index 000000000000..d0c93dfaffe0 --- /dev/null +++ b/automation/build/yocto/build-yocto.sh @@ -0,0 +1,349 @@ +#!/bin/bash +# +# Yocto meta virtualization build and run script +# +# This script is building Yocto xen-image-minimal for qemu targets and run +# them using runqemu inside yocto to check that dom0 is booting properly +# The build is using a local xen source tree so that specific patches can be +# tested. +# In order to optimize the build time, a build cache is used so that only xen +# packages and its dependencies are rebuilt (qemu and final image mainly). +# + +# Directories +YOCTODIR="$HOME/yocto-layers" +CACHEDIR="$HOME/yocto-cache" +LOGDIR="$HOME/logs" +XENDIR="$HOME/xen" +BUILDDIR="$HOME/build" + +# what yocto bsp we support +TARGET_SUPPORTED="qemuarm qemuarm64 qemux86-64" +VERBOSE="n" +TARGETLIST="" +BUILDJOBS="8" + +# actions to do +do_clean="n" +do_build="y" +do_run="y" +do_localsrc="n" +do_dump="n" +build_result=0 + +# layers to include in the project +build_layerlist="poky/meta poky/meta-poky poky/meta-yocto-bsp \ + meta-openembedded/meta-oe meta-openembedded/meta-python \ + meta-openembedded/meta-filesystems \ + meta-openembedded/meta-networking meta-virtualization" + +# yocto image to build +build_image="xen-image-minimal" + +function print_progress() { + echo -n "$(date +%T) $*" +} + +function run_task() { + local task_name="$1" + local task_target="$2" + + task_log="${task_name//project_}-${task_target}" + + mkdir -p "${LOGDIR}" + print_progress + echo -n "${task_name//project_} ${task_target}: " + if [ "${VERBOSE}" = "n" ]; then + $@ > "${LOGDIR}/${task_log}.log" 2>&1 + else + $@ 2>&1 | tee "${LOGDIR}/${task_log}.log" + fi + + if [ ${?} -ne 0 ]; then + echo "Error" + build_result=$((build_result+1)) + if [ "${do_dump}" = "y" ]; then + echo + echo "############ LOGS-START ############" + cat "${LOGDIR}/${task_log}.log" + echo "############ LOGS-END ############" + echo + fi + return 1 + else + echo "OK" + return 0 + fi +} + +function project_create() { + target="${1:?}" + destdir="${BUILDDIR}/${target}" + + ( + # init yocto project + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" + + # add needed layers + for layer in ${build_layerlist}; do + bitbake-layers add-layer ${YOCTODIR}/${layer} || exit 1 + done + ) || return 1 + + # customize project configuration + cat <> "${destdir}/conf/local.conf" +# Yocto BSP +MACHINE = "${target}" + +# Use local cache to reuse previous builds results +SSTATE_DIR = "${CACHEDIR}/sstate-cache" +DL_DIR = "${CACHEDIR}/downloads" + +# Enable xen and virtualization +DISTRO_FEATURES = " virtualization xen ipv4" + +# Speed up run by not generating ssh host keys +IMAGE_INSTALL:append:pn-xen-image-minimal = " ssh-pregen-hostkeys" + +# Save some disk space +INHERIT += "rm_work" + +# Reduce number of jobs +BB_NUMBER_THREADS="${BUILDJOBS}" + +EOF + + if [ "${do_localsrc}" = "y" ]; then + XENVERS=$(grep -e "^XEN_REL" \ + "${YOCTODIR}"/meta-virtualization/recipes-extended/xen/xen_*.bb \ + 2> /dev/null | tr -d ' ' | tr -d '?' | tr -d '"' \ + | sed -e "s/.*=//" | sort -V | tail -n 1) + + XENBASE=$(dirname "$(realpath -m "${XENDIR}")") + XENSUB=$(basename "$(realpath -m "${XENDIR}")") + + cat <> "${destdir}/conf/local.conf" +# Use local sources for xen and xen-tools +FILESEXTRAPATHS:prepend:pn-xen := "${XENBASE}:" +FILESEXTRAPATHS:prepend:pn-xen-tools := "${XENBASE}:" + +SRC_URI:pn-xen = "file://${XENSUB}/;subdir=local-xen/" +SRC_URI:pn-xen-tools = "file://${XENSUB}/;subdir=local-xen/" + +PREFERRED_VERSION:pn-xen = "${XENVERS}%" +PREFERRED_VERSION:pn-xen-tools = "${XENVERS}%" + +S:pn-xen = "\${WORKDIR}/local-xen/${XENSUB}" +S:pn-xen-tools = "\${WORKDIR}/local-xen/${XENSUB}" + +SRCREV:pn-xen = "\${AUTOREV}" +SRCREV:pn-xen-tools = "\${AUTOREV}" + +SRCPV:pn-xen = "1" +SRCPV:pn-xen-tools = "1" + +# Disable all QA errors as the recipe is not up to date with changes in Xen +# when we use local sources +ERROR_QA:pn-xen = "arch" +ERROR_QA:pn-xen-tools = "arch" + +EOF + fi +} + +function project_build() { + target="${1:?}" + destdir="${BUILDDIR}/${target}" + + ( + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" + + bitbake "${build_image}" || exit 1 + ) || return 1 +} + +function project_clean() { + target="${1:?}" + destdir="${BUILDDIR}/${target}" + + rm -rf "${destdir}" +} + +function project_run() { + target="${1:?}" + destdir="${BUILDDIR}/${target}" + ( + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" > /dev/null 2>&1 + + /usr/bin/expect < $$@ + cat $$< | \ + sed -e "s,##YOCTOVERSION##,$(1),g" | \ + sed -e "s,##YOCTOTARGET##,$(2),g" | \ + sed -e "s,##DOCKERPLAT##,$(3)/,g" > $$@ + +endef + +$(eval $(foreach vers,$(YOCTO_VERSION),\ + $(foreach tar,$(YOCTO_TARGETS),\ + $(foreach hst,$(YOCTO_HOSTS),\ + $(call GEN_DOCKER,$(vers),$(tar),$(hst),$(if $(filter amd64,$(hst)),,-$(hst))))))) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 17 09:40:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 09:40:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444828.699926 (Exim 4.92) (envelope-from ) id 1ovbO1-0002Qo-Lr; Thu, 17 Nov 2022 09:40:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444828.699926; Thu, 17 Nov 2022 09:40:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbO1-0002PW-EN; Thu, 17 Nov 2022 09:40:45 +0000 Received: by outflank-mailman (input) for mailman id 444828; Thu, 17 Nov 2022 09:40:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbNz-0001D0-QU for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 09:40:43 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id e74c36f9-665b-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 10:40:42 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A247B1477; Thu, 17 Nov 2022 01:40:48 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A08ED3F73B; Thu, 17 Nov 2022 01:40:41 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e74c36f9-665b-11ed-8fd2-01056ac49cbb From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: michal.orzel@amd.com, Doug Goldstein , Stefano Stabellini Subject: [PATCH v4 2/3] automation: Add a clean rule for containers Date: Thu, 17 Nov 2022 09:39:50 +0000 Message-Id: <3a127e836d744fbb2954690293ee47d2c0c899e2.1668677493.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add make clean support to remove the containers from the local docker registry: - make clean: remove all images - clean-yocto/kirkstone-qemuarm: remove yocto kirkstone for qemuarm image Signed-off-by: Bertrand Marquis --- Changes in v4: - also generate clean rule for CONTAINERS_EXTRA Changes in v3: - none Changes in v2: - none Changes in v1: - patch added --- automation/build/Makefile | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/automation/build/Makefile b/automation/build/Makefile index 72a5335baec1..5b5f10c63ea4 100644 --- a/automation/build/Makefile +++ b/automation/build/Makefile @@ -28,3 +28,15 @@ all: $(CONTAINERS) clean: rm -f yocto/*.dockerfiles +define CLEAN_RULE +.PHONY: clean-$(1) +clean-$(1): +ifneq ($$(shell docker image ls -q $(REGISTRY)/$(subst /,:,$(1))),) + docker image rm $(REGISTRY)/$(subst /,:,$(1)) +endif + +clean: clean-$(1) + +endef + +$(eval $(foreach img,$(CONTAINERS) $(CONTAINERS_EXTRA),$(call CLEAN_RULE,$(img)))) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 17 09:40:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 09:40:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444830.699943 (Exim 4.92) (envelope-from ) id 1ovbO2-0002qi-U4; Thu, 17 Nov 2022 09:40:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444830.699943; Thu, 17 Nov 2022 09:40:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbO2-0002pQ-Mn; Thu, 17 Nov 2022 09:40:46 +0000 Received: by outflank-mailman (input) for mailman id 444830; Thu, 17 Nov 2022 09:40:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbO1-0002Nb-T0 for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 09:40:45 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id e7c4693f-665b-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 10:40:44 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 857B1150C; Thu, 17 Nov 2022 01:40:49 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 85A663F73B; Thu, 17 Nov 2022 01:40:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7c4693f-665b-11ed-91b6-6bf2151ebd3b From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: michal.orzel@amd.com, Doug Goldstein , Stefano Stabellini Subject: [PATCH v4 3/3] automation: Add CI test jobs for Yocto Date: Thu, 17 Nov 2022 09:39:51 +0000 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Michal Orzel Populate test jobs for Yocto based tests using the provided containers. Due to the size restrictions, it is currently not possible to split the build and run tasks, therefore everything is done in a single step. Test jobs for the supported Yocto targets are generic to avoid the necessity to add new ones after each Yocto release. The only thing required to be changed after updating the containers is the variable YOCTO_VERSION stored in a .yocto-test template. The .yocto-test-arm64 template is to be used for jobs running on an arm64 hardware and .yocto-test-x86-64 for x86. Current jobs are using the arm64 version (x86 templates are here as a provision). Signed-off-by: Michal Orzel Signed-off-by: Bertrand Marquis --- Changes in v4: - add .yocto-test for arm64 and x86 - make yocto jobs use arm64 version Changes in v3: - patch added --- automation/gitlab-ci/test.yaml | 43 ++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index c7e0078e04f1..6ce2fd63eee6 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -54,6 +54,33 @@ tags: - x86_64 +.yocto-test: + extends: .test-jobs-common + script: + - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` ${YOCTO_BOARD} + variables: + YOCTO_VERSION: kirkstone + CONTAINER: yocto:${YOCTO_VERSION}-${YOCTO_BOARD}-${YOCTO_HOST} + artifacts: + paths: + - 'logs/*' + when: always + needs: [] + +.yocto-test-arm64: + extends: .yocto-test + variables: + YOCTO_HOST: arm64v8 + tags: + - arm64 + +.yocto-test-x86-64: + extends: .yocto-test + variables: + YOCTO_HOST: amd64 + tags: + - x86_64 + # Test jobs build-each-commit-gcc: extends: .test-jobs-common @@ -188,3 +215,19 @@ qemu-smoke-x86-64-clang-pvh: - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE} needs: - debian-unstable-clang-debug + +# Yocto test jobs +yocto-qemuarm64: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemuarm64 + +yocto-qemuarm: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemuarm + +yocto-qemux86-64: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemux86-64 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 17 09:45:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 09:45:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444845.699958 (Exim 4.92) (envelope-from ) id 1ovbSB-0004Af-EF; Thu, 17 Nov 2022 09:45:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444845.699958; Thu, 17 Nov 2022 09:45:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbSB-0004AY-Az; Thu, 17 Nov 2022 09:45:03 +0000 Received: by outflank-mailman (input) for mailman id 444845; Thu, 17 Nov 2022 09:45:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbS9-00049F-SZ for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 09:45:02 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70087.outbound.protection.outlook.com [40.107.7.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 812168f2-665c-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 10:45:01 +0100 (CET) Received: from FR0P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::19) by DB9PR08MB8737.eurprd08.prod.outlook.com (2603:10a6:10:3d3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8; Thu, 17 Nov 2022 09:44:30 +0000 Received: from VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:97:cafe::aa) by FR0P281CA0121.outlook.office365.com (2603:10a6:d10:97::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Thu, 17 Nov 2022 09:44:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT017.mail.protection.outlook.com (100.127.145.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 09:44:29 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Thu, 17 Nov 2022 09:44:29 +0000 Received: from 68a3a1bcdd7a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E08089F8-4572-4814-A0C6-C2DEE646CF74.1; Thu, 17 Nov 2022 09:44:21 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 68a3a1bcdd7a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 17 Nov 2022 09:44:21 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAXPR08MB7599.eurprd08.prod.outlook.com (2603:10a6:102:23e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Thu, 17 Nov 2022 09:44:19 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5834.007; Thu, 17 Nov 2022 09:44:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 812168f2-665c-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EvOHN851l9nyTxZHtmYzdovTbpofZYB29vUZJUcFe7I=; b=Zg9yfN9pddMcJEAravU0rsPefCV9fIZdaDcFw4rOp7b/InyFwMA3ioxayUJV1GLg/pAmGb4U7lEzsLVzwFvhFcOkxxwDuggESo0vZ1pUGj6AuLZJPfw0dhzTFvp4PS0styUZ5RKUYdAgObxL7d70Z80POgsDhM+rB4P6se3YE+Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a07e3cbb7cb1d576 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nhc53RIcR812cpM94RpWtXFx/XAwVXR5MaGwxU6szVsZmceiaOguQ5t6sjdIW+wu3kiKACYLr3RLEBa3dKvYfPF6DCAmUqf1SaHz9pnEUrVYx9/GSrqns2EliRLinPjTPtTiyXX4dRV8RHFwouuzmK878xWKToxzErgvyesGIyc+vMfU2/XGtdJX4Q0tUZM0CxUOJCjVAz5p5WNW1n/b//Dwz3D0241uGyG9iYukhnzGYnvHEqiHgDF4QQJmM3Az6oBrzVcKOUwx9FrRA/VxCb18hawIIZk2RsmI0Xg5CzJ85c8uKws4iyHsIikg0Ollf/TsLuoWGVEcDBkQjd0HVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EvOHN851l9nyTxZHtmYzdovTbpofZYB29vUZJUcFe7I=; b=MFh5GyRLRelLEj4VUyDe242u2ws8+QvSSZYlSof7xnZQigdQu0PziixdxhQrX5ubuc1+P1ZByuWVbpGptLJd28amvCunAlaVIOupDTj+4rb3YP1HnzuDEYK5401P0myLdnk5lVhri388imbeGo5LzHshdnG2s3vsBb6zI/OgJ8npr11mEQvmuweoVI5tsByTbi9MftPDQX/9GKPs7S6cq/k2qJ7qzG6JL1bKcdVHzEhR7/rOWhFDo2u9ZhtBPSYFUth34OdHXcl4Ylgmc59XbT/gTV/5BKSHLIZoDcTkZNDNTjDnNvO4KZaeJbW2OUpgyJxioN3UwW5Gq0ANRcmUpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EvOHN851l9nyTxZHtmYzdovTbpofZYB29vUZJUcFe7I=; b=Zg9yfN9pddMcJEAravU0rsPefCV9fIZdaDcFw4rOp7b/InyFwMA3ioxayUJV1GLg/pAmGb4U7lEzsLVzwFvhFcOkxxwDuggESo0vZ1pUGj6AuLZJPfw0dhzTFvp4PS0styUZ5RKUYdAgObxL7d70Z80POgsDhM+rB4P6se3YE+Q= From: Bertrand Marquis To: Julien Grall CC: Michal Orzel , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Thread-Topic: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Thread-Index: AQHY55A0LevsoY2L90OFIBLiUlnr6K5Av9+AgACVYoCAAF4AgIAAEeUAgAATsACAACQMgIAACNUAgADp3YCAAA96gIAABCQA Date: Thu, 17 Nov 2022 09:44:19 +0000 Message-ID: References: <20221024100536.12874-1-michal.orzel@amd.com> <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> <0400b2d8-6f2c-6406-d966-64ed5720688c@xen.org> <350afafd-821c-1a05-13cb-1704d3a61bfc@amd.com> <84710d96-c473-fa41-d847-2b109dfb49c9@xen.org> <85f4f42b-b1ee-36bf-5ba9-21b1047351cf@amd.com> <7d3f9021-d608-9e8f-9593-1099d7bd2003@xen.org> In-Reply-To: <7d3f9021-d608-9e8f-9593-1099d7bd2003@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|PAXPR08MB7599:EE_|VI1EUR03FT017:EE_|DB9PR08MB8737:EE_ X-MS-Office365-Filtering-Correlation-Id: 52ed3d3e-b663-48ab-27d9-08dac88052e6 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bLLunQ9dwWlJvw35HIqkQp1oYbifbmbRILRvlZi7No7r7uAY2UjBS7hXZteugUbSrQ7P93IaTV9uEC5GTE7bL20tiLPMFj55ifLoxd3axdjb3lxR+8qh9ZvT6foSErqSt248clks9lpTWa0MtQMJCD/fo0rPvg+jN61YpGjGzC4lT1SxM+ieCFTKW5gtHNU/no0OA/yLOMnVh6YJSKyhUOAp8bkantc7SVNIynneHH26mU0tzDL4vrxDVKAE5oY4mbYDbv0uac4j9POBN5fSIWiI4CR3F2jJOR3b5lQZHx7T8GcL7j0fQ9xZ7WM0MjD7GC56BzR/0/uc97YHd+2W6PyD4mDPSV97GBV5mobcGSRC4lyHQJ88gDAG0UnVfHt8dHG/GMmYKdjiBsTcgRAtnJgO9OrfDUlEO+WGczSDlM9rwTGrT3p2p05Vl473G8RRjQW5avLvksmK6JokcewHURe5dtmDFOMDaNOwT9JYoaIeUk9+jBombPyPjnoHHL5fiQnwW+NNny9eoSpOdntyiP0CN/XglQGbYOu3nBg1Frl7IWDDURsFLqXFoRmWCFasu/PCgg1zt8e/ndBu6dIFO2SXbE7pweFkT0ay9bq5foqiab9y/IgCDXuNGDjgq2CSP1paSJyWhyvbYefhLalCiojqZOeV9CqvmmvasauVGW5pPfnPI7q0uYTnPb4Cukupbzlv3EeWW4UslAYmKdgyeAbbV8Pk7mdYuXE/c20s2Hs= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(366004)(346002)(396003)(451199015)(33656002)(186003)(5660300002)(316002)(6506007)(54906003)(6916009)(53546011)(26005)(6512007)(91956017)(36756003)(41300700001)(2616005)(8936002)(4326008)(8676002)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(122000001)(38100700002)(38070700005)(2906002)(83380400001)(86362001)(478600001)(66899015)(71200400001)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7599 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 87ccd4d6-5645-4090-27f4-08dac8804c91 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VE90ksha+qyZQV9B+81NMoQuYbffzU6weXrbJysfB3enIOnCNJP5CNbC00lJ2amNWTDfP4vHB6jJQsoLw3/zOhcIwcMn5Ty3X5hvvFB54f/EKESVna2FPVeIvNo0Hgb6oPQoTU1IcZA7D7KIizLQgU4eHiR3QTzymgFS8vo183byrPFyQfoMw3oY7ww+80gV4AN9rm8R0uPZCk8sQKZJyoJ/el6I/4YjHTm8hXu3AgyT9iUKQH2mB+Pz+Xo62PaiShoM+pxpyT+Yzr2E6jX/rtPh0t2/0b+1wzPKmoTTz+scYJ/BpNWKvSikcNdSvfOXTyW7tx50z6iRjCYdkJuM5docZpLT/I06EEAsZD3czxQwGETanc8HxR52B8Lm/X3hrifCwNfBS9HV/0Ep14QtGaQFToOnenZ4AxUdtGShrxvzDvVtCIGBSh35qQ6ax3cQn63Lz3q7xwA6MPhdQpLw6HuiGQKv9dEzi2Xp30la5qAvk0T7QBGn9r+T1kLuQFwxD88H57dtv4ZOWbb1wDc/L2hD5bR9+B0Ra8js7c7nLvV81rwBQ2UkFyy3XoA6M96rPdQ44HArvvHEOXGKRyfzQ0JhwiVCw86KGxjmAmZp4jA4fimlNxK7/hsnyvAVXxNi2m2ieOiVj8KTTyvZhGuzzw63ONRpo4U2Y8k+fOYp20HEsr7tFXCQPHKBrnVs77WoXGisTCCrby0fnIPf3yoTrQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199015)(36840700001)(40470700004)(46966006)(36756003)(83380400001)(2906002)(86362001)(336012)(82310400005)(316002)(40480700001)(186003)(2616005)(47076005)(66899015)(41300700001)(5660300002)(8936002)(6862004)(356005)(8676002)(70206006)(70586007)(81166007)(40460700003)(82740400003)(33656002)(6486002)(478600001)(36860700001)(6506007)(6512007)(53546011)(4326008)(54906003)(107886003)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 09:44:29.6968 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52ed3d3e-b663-48ab-27d9-08dac88052e6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8737 SGksDQoNCj4gT24gMTcgTm92IDIwMjIsIGF0IDA5OjI5LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4 ZW4ub3JnPiB3cm90ZToNCj4gDQo+IA0KPiANCj4gT24gMTcvMTEvMjAyMiAwODozNCwgTWljaGFs IE9yemVsIHdyb3RlOg0KPj4gSGkgSnVsaWVuLA0KPj4gT24gMTYvMTEvMjAyMiAxOTozNywgSnVs aWVuIEdyYWxsIHdyb3RlOg0KPj4+IA0KPj4+IA0KPj4+IEhpIE1pY2hhbCwNCj4+PiANCj4+PiBP biAxNi8xMS8yMDIyIDE4OjA1LCBNaWNoYWwgT3J6ZWwgd3JvdGU6DQo+Pj4+IE9uIDE2LzExLzIw MjIgMTY6NTYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+Pj4+IA0KPj4+Pj4gDQo+Pj4+PiBPbiAx Ni8xMS8yMDIyIDE0OjQ1LCBNaWNoYWwgT3J6ZWwgd3JvdGU6DQo+Pj4+Pj4gSGkgSnVsaWVuLA0K Pj4+Pj4gDQo+Pj4+PiBIaSBNaWNoYWwsDQo+Pj4+PiANCj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBhbmQg dXNlIGl0IGluIHRoZSBwbDAxMS1kZWJ1ZyBmaWxlcyAoKyB0aGVyZSBpcyBhIHF1ZXN0aW9uIHdo ZXRoZXIgd2Ugc2hvdWxkIGRlZmluZSBXTEVOXzctNSBmb3IgY29tcGxldGVuZXNzKS4NCj4+Pj4+ Pj4gDQo+Pj4+Pj4+IEkgd291bGQgbm90IGRlZmluZSBXTEVOXzctNS4gVGhhdCBzYWlkLCBJIHdv bmRlciBpZiB3ZSByZWFsbHkgbmVlZCB0bw0KPj4+Pj4+PiBzZXQgdGhlIGJhdWQgcmF0ZSAmIGNv IGhlcmU/DQo+Pj4+Pj4+IA0KPj4+Pj4+PiBBRkFJQ1QgdGhlIHJ1bnRpbWUgZHJpdmVyIG5ldmVy IHRvdWNoIHRoZW0uIFRoZSByZWFzb25pbmcgaXMgdGhlDQo+Pj4+Pj4+IGZpcm13YXJlIGlzIHJl c3BvbnNpYmxlIHRvIGNvbmZpZ3VyZSB0aGUgc2VyaWFsLiBUaGVyZWZvcmUsIEkgd291bGQNCj4+ Pj4+Pj4gY29uc2lkZXIgdG8gZHJvcCB0aGUgY29kZSAoc2V0dGluZyBVQVJUQ1IgbWlnaHQgc3Rp bGwgYmUgbmVjZXNzYXJ5KS4NCj4+Pj4+PiBJIGRvIG5vdCByZWFsbHkgYWdyZWUgYmVjYXVzZSB0 aGUgY3VycmVudCBiZWhhdmlvciB3YXMgZG9uZSBvbiBwdXJwb3NlLg0KPj4+Pj4gDQo+Pj4+PiBF QVJMWV9VQVJUX1BMMDExX0JBVURfUkFURSBpcyBvbmx5IHVzZWQgZm9yIHZlcnkgZWFybHkgZGVi dWdnaW5nICh0aGlzDQo+Pj4+PiBpcyBwcm90ZWN0ZWQgYnkgQ09ORklHX0RFQlVHIGFuZCBDT05G SUdfRVhQRVJUKS4gVGhpcyBpcyBub3QgYQ0KPj4+Pj4gcHJvZHVjdGlvbiByZWFkeSBjb2RlLg0K Pj4+PiBJIGFtIGZ1bGx5IGF3YXJlIG9mIGl0LiBJIGp1c3QgZm91bmQgaXQgdXNlZnVsIGJ1dCBJ IHVuZGVyc3RhbmQgdGhlIGdsb2JhbCByZWFzb25pbmcuDQo+Pj4+IA0KPj4+Pj4gDQo+Pj4+Pj4g QXQgdGhlIG1vbWVudCBlYXJseV91YXJ0X2luaXQgaXMgY2FsbGVkIG9ubHkgaWYgRUFSTFlfVUFS VF9QTDAxMV9CQVVEX1JBVEUgaXMgc2V0IHRvIGEgdmFsdWUgIT0gMC4NCj4+Pj4+PiBUaGlzIGlz IGRvbmUgaW4gb3JkZXIgdG8gaGF2ZSBmbGV4aWJpbGl0eSB0byBlaXRoZXIgc3RpY2sgdG8gd2hh dCBmaXJtd2FyZS9ib290bG9hZGVyIGNvbmZpZ3VyZWQgb3IgdG8gY2hhbmdlIHRoaXMNCj4+Pj4+ PiBjb25maWd1cmF0aW9uIGJ5IHNwZWNpZnlpbmcgdGhlIEVBUkxZX1VBUlRfUEwwMTFfQkFVRF9S QVRFICh1c2VmdWwgd2hlbiB5b3UgZG8gbm90IGtub3cgd2hhdA0KPj4+Pj4+IHRoZSBmaXJtd2Fy ZSBjb25maWd1cmVkKS4NCj4+Pj4+IFRoZSBjaGFuY2VzIGFyZSB0aGF0IHlvdSB3YW50IHRvIHVz ZSB0aGUgYmF1ZCByYXRlIHRoYXQgd2FzIGNvbmZpZ3VyZWQNCj4+Pj4+IGJ5IHRoZSBmaXJtd2Fy ZS4gT3RoZXJ3aXNlLCB5b3Ugd291bGQgbmVlZCB0byBjaGFuZ2UgdGhlIGNvbmZpZ3VyYXRpb24N Cj4+Pj4+IG9mIG1pbmljb20gKG9yIHdoYXRldmVyIHlvdSB1c2VkKSB0byBnZXQgcHJvcGVyIG91 dHB1dCBmb3IgdGhlIGZpcm13YXJlDQo+Pj4+PiBhbmQgdGhlbiBYZW4uDQo+Pj4+PiANCj4+Pj4+ IEZ1cnRoZXJtb3JlLCBhcyBJIHdyb3RlIGJlZm9yZSwgdGhlIHJ1bnRpbWUgZHJpdmVyIGRvZXNu J3QgY29uZmlndXJlIHRoZQ0KPj4+Pj4gYmF1ZCByYXRlLiBUaGlzIHdhcyByZW1vdmVkIGluIFhl biA0LjcgKHNlZSBjb21taXQgMjA0OGUxN2NhOWRmDQo+Pj4+PiAiZHJpdmVycy9wbDAxMTogRG9u J3QgY29uZmlndXJlIGJhdWRyYXRlIikgYmVjYXVzZSBpdCB3YXMgYnVnZ3kgYW5kIHRoaXMNCj4+ Pj4+IGNvZGUgaXMgbm90IHNpbXBsZS4NCj4+Pj4+IA0KPj4+Pj4gU28gaXQgbWFrZXMgbm8gc2Vu c2UgdG8gY29uZmlndXJlIHRoZSBiYXVkIHJhdGUgd2hlbiB1c2luZyBlYXJseSBwcmludGsNCj4+ Pj4+IGJ1dCBub3QgdGhlIHJ1bnRpbWUgZHJpdmVyLg0KPj4+PiBPaywgc28gd2Ugd2lsbCBnZXQg cmlkIG9mIEVBUkxZX1VBUlRfUEwwMTFfQkFVRF9SQVRFIGNvbmZpZyBhbmQgc2V0dGluZyB0aGUg YmQNCj4+Pj4gaW4gdGhlIGVhcmx5IHVhcnQgY29kZS4gTm93LCB3aGF0IGFib3V0IHNldHRpbmcg IjhuMSI/IFRoZSBydW50aW1lIGRyaXZlciBzZXRzIHRoZW0NCj4+Pj4gYXMgd2VsbCBhcyB0aGUg ZWFybHkgY29kZS4gSXQgY2FuIGFsc28gYmUgc2V0IHRvIGEgZGlmZmVyZW50IHZhbHVlIGZyb20g dGhlIGZpcm13YXJlDQo+Pj4+ICh1bmxpa2VseSBidXQgaXQgY2FuIGhhcHBlbiBJIHRoaW5rKS4g SW4gYW55IGNhc2UsIGlmIHdlIGRlY2lkZSB0byBkbyB3aGF0IHRoZSBydW50aW1lIGRyaXZlcg0K Pj4+PiBkb2VzLCBJIHJlY2tvbiBzZXR0aW5nIExDUl9IIHNob3VsZCBiZSBrZXB0IGluIGVhcmx5 IGNvZGUuDQo+Pj4gDQo+Pj4gR29vZCBxdWVzdGlvbi4gSSB0aGluaywgeW91IHdvdWxkIGVuZCB1 cCB3aXRoIHRoZSBzYW1lIGlzc3VlIEkgbWVudGlvbmVkDQo+Pj4gYWJvdmUgaWYgdGhlIGZpcm13 YXJlIGFuZCBYZW4gaGF2ZSBkaWZmZXJlbnQgbGluZSBjb250cm9sIHJlZ2lzdGVycw0KPj4+ICh0 b29scyBsaWtlIG1pbmljb20vc2NyZWVuIHdvdWxkIGFzayBmb3IgaXQpLg0KPj4+IA0KPj4+IFNv IEkgYW0gb24gdGhlIGZlbmNlIGhlcmUuIEluIG9uZSB3YXksIGl0IHNlZW1zIHBvaW50bGVzcyBr ZWVwIGl0LiBCdXQNCj4+PiBvbiB0aGUgb3RoZXIgaGFuZCwgWGVuIGhhcyBhbHdheXMgc2V0IGl0 LiBTbyBJIGhhdmUgbm8gZGF0YSB0byBwcm92ZQ0KPj4+IHRoaXMgd2lsbCBiZSBmaW5lIGV2ZXJ5 d2hlcmUuDQo+PiBJZiB3ZSBhcmUgcmVseWluZyBvbiB0aGUgZmlybXdhcmVbMV0gdG8gY29uZmln dXJlIHRoZSBiYXVkIHJhdGUsIGl0IGlzIG5vdCB2ZXJ5IHdpc2UNCj4+IG5vdCB0byByZWx5IG9u IGl0IHRvIGNvbmZpZ3VyZSB0aGUgTENSLiBMb29raW5nIGF0IHRoZSBvdGhlciBzZXJpYWwgZHJp dmVycyBpbiBYZW4sDQo+PiB3ZSBoYXZlIGEgcmVhbCBtaXNtYXRjaCBpbiB3aGF0IGlzIGJlaW5n IGNvbmZpZ3VyZWQuIFNvbWUgb2YgdGhlIGRyaXZlcnMgKG9tYXAsIGlteCksDQo+PiBhcGFydCBm cm9tIHNldHRpbmcgOG4xIGFsc28gc2V0IHRoZSBiYXVkIHJhdGUgZXhwbGljaXRseSB0byAxMTUy MDAgYW5kIGFsbW9zdCBhbGwgb2YgdGhlbQ0KPj4gZG8gc2V0IDhuMS4gSW4gdGhhdCBjYXNlIHdl IHdpbGwgbm90IGJlbmVmaXQgdG9vIG11Y2ggZnJvbSBmaXhpbmcganVzdCBwbDAxMS4NCj4gSXQg aXMgbm90IGdyZWF0IHRoYXQgWGVuIGhhcmRjb2RlIHRoZSBiYXVkIHJhdGUgKEkgY2FuJ3QgcmVt ZW1iZXIgd2hldGhlciB0aGVyZSB3YXMgYSByZWFzb24pLCBidXQgSSBkb24ndCB0aGluayB0aGUg Y29uc2lzdGVuY3kgaXMgbmVjZXNzYXJ5IGhlcmUgKHNlZSBtb3JlIGJlbG93KS4NCj4gDQo+PiBP biB0aGUgb3RoZXIgaGFuZCwgWGVuIGZvbGxvd3MgdGhlIHpJbWFnZS9JbWFnZSBwcm90b2NvbHMg Zm9yIEFSTSBbMl0gd2hpY2ggZG8gbm90DQo+PiBzdGF0ZSB0aGF0IHNlcmlhbCBwb3J0IGluaXRp YWxpemluZyBpcyBzb21ldGhpbmcgbWFuZGF0b3J5LiBUaGlzIGNvdWxkIGluZGljYXRlIHRoYXQN Cj4+IHRoZSBmaXJtd2FyZSBkb2VzIG5vdCByZWFsbHkgbmVlZCB0byBjb25maWd1cmUgdGhlIHNl cmlhbC4NCj4gDQo+IFRoZSBmaXJtd2FyZSBkb2Vzbid0IG5lZWQgdG8gY29uZmlndXJlIHRoZSBz ZXJpYWwgYW5kIHllcyBpbiB0aGVvcnkgWGVuIHNob3VsZCBjb25maWd1cmUgdGhlIGJhdWQgcmF0 ZSBhbmQgcGFyaXR5IGJhc2VkIG9uIHRoZSBmaXJtd2FyZSB0YWJsZS4NCj4gDQo+IEhvd2V2ZXIs IHRoaXMgaXMgYSB0cmFkZSBvZmYgYmV0d2VlbiBjb21wbGV4aXR5IGFuZCBiZW5lZml0cy4gVGhl IHBhdGNoIEkgbWVudGlvbmVkIGVhcmxpZXIgaGFzIGJlZW4gcmVtb3ZlZCBuZWFybHkgNiB5ZWFy cyBhZ28gYW5kIEkgaGF2ZW4ndCBzZWVuIGFueW9uZSByZXBvcnRpbmcgYW55IGlzc3Vlcy4NCj4g DQo+IEhlbmNlIHdoeSBJIHRoaW5rIGZvciB0aGUgUEwwMTEgaXQgaXMgbm90IHdvcnRoIGxvb2tp bmcgWzNdIGF0IHRoZSBiYXVkIHJhdGUgYW5kIGluc3RlYWQgcmVtb3ZpbmcgaXQgY29tcGxldGVs eSBpbiB0aGUgZWFybHkgUEwwMTEgY29kZSBhcyB3ZWxsLg0KPiANCj4gVGhhdCBzYWlkLCBpZiB5 b3UgZmVlbCBzdHJvbmdseSBhZGRpbmcgc3VwcG9ydCBmb3IgYmF1ZCByYXRlIHRoZW4gSSB3aWxs IGJlIGhhcHB5IHRvIHJldmlldyB0aGUgcGF0Y2guDQoNCkp1c3Qgb25lIHJlbWFyayBoZXJlOiBJ biBzb21lIGNhc2VzIHRoZSBmaXJtd2FyZSBtaWdodCB1c2UgYSBkaWZmZXJlbnQgY29uc29sZSB0 aGFuIHRoZSBzZXJpYWwgb25lIChmb3IgZXhhbXBsZSBhIGdyYXBoaWNhbCBvbmUpIGFuZCBYZW4g Y291bGQgYmUgdGhlIGZpcnN0IHRvIHVzZSB0aGUgc2VyaWFsIGNvbnNvbGUuDQpTbyB0aGVyZSBt aWdodCBiZSBjYXNlcyB3aGVyZSBpZiB3ZSBkbyBub3Qgc2V0IGEgZGVmYXVsdCB2YWx1ZSwgdGhl IGNvbnNvbGUgd2lsbCBub3QgYmUgY29uZmlndXJlZCBhdCBhbGwuDQoNCkkgdGhpbmsgdGhlIGJl c3Qgc29sdXRpb24gaGVyZSB3b3VsZCBiZSB0byBoYXZlIGEgQ09ORklHIHNldHRpbmcgc28gdGhh dCBzb21lb25lIGNvbXBpbGluZyBYZW4gY291bGQgY2hvb3NlIGJldHdlZW4g4oCca2VlcGluZyBm aXJtd2FyZSBjb25maWfigJ0gb3Ig4oCcZm9yY2UgYSBjb25maWfigJ0uDQoNCkNoZWVycw0KQmVy dHJhbmQNCg0KPiANCj4+IFsxXSBJdCBpcyBub3Qgc3RhdGVkIGFueXdoZXJlIGluIG91ciBkb2Nz Lg0KPiANCj4gT3VyIGRvY3MgYXJlIG5vdCBwZXJmZWN0LiBQYXRjaGVzIGFyZSB3ZWxjb21lZCBm b3IgaW1wcm92ZW1lbnQuIEFsdGhvdWdoLCBJIHRoaW5rIHRoZSBzdGF0ZW1lbnQgc2hvdWxkIG9u bHkgYmUgZm9yIGRyaXZlciB3aGVyZSB3ZSBkb24ndCBzZXQgdGhlIGJhdWQgcmF0ZS4gRm9yIHRo ZSBvdGhlcnMsIHdlIHNob3VsZCBsZWF2ZSBpdCBhcyBpcyB1bmxlc3MgeW91IGNhbiBwcm92ZSB0 aGlzIGlzIG5vdCBuZWNlc3NhcnkgKHdlIGRvbid0IHdhbnQgdG8gYnJlYWsgZXhpc3Rpbmcgc2V0 dXApLg0KPiANCj4+IFsyXSBCVFc6IG91ciBkb2NzL21pc2MvYXJtL2Jvb3RpbmcgY29udGFpbnMg aW52YWxpZCBsaW5rcyB0byB0aGUga2VybmVsIGRvY3MuIEkgZ3Vlc3MNCj4+IHRoaXMgd2FudHMg dG8gYmUgZml4ZWQuDQo+IA0KPiBQYXRjaGVzIGFyZSB3ZWxjb21lZC4NCj4gDQo+IFszXSBJIGRv IGhhdmUgYSBsYXJnZSBsaXN0IG9mIG1vcmUgY3JpdGljYWwgYnVncyB0aGF0IEkgd2lsbCBiZSBo YXBweSB0byBzaGFyZSBpZiB5b3UgYXJlIGxvb2tpbmcgZm9yIGltcHJvdmluZyBYZW4uDQo+IA0K PiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Nov 17 09:50:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 09:50:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444857.699968 (Exim 4.92) (envelope-from ) id 1ovbXm-0005rN-6g; Thu, 17 Nov 2022 09:50:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444857.699968; Thu, 17 Nov 2022 09:50:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbXm-0005rG-3X; Thu, 17 Nov 2022 09:50:50 +0000 Received: by outflank-mailman (input) for mailman id 444857; Thu, 17 Nov 2022 09:50:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbXl-0005rA-4u for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 09:50:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbXj-0006my-Ec; Thu, 17 Nov 2022 09:50:47 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.7.117]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ovbXj-0001XB-7T; Thu, 17 Nov 2022 09:50:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=FVKmokPh+0XQzqjmL1pikevi9+vfwl7ud2tvH6JdKFM=; b=vDSeYWDV7U3jp/i6uNs00r6H36 ASAUkeja20p781MtqFmxa3GFffkJlcBLAxowR4aD2s12tVIjhFvKLx69cqeGmN8Kqvxr3L9GlmmG7 wpFjOv1A62lHhbQa3vP+mCfhd3MfGiUjya6xdeFjh3iqYWuFS9XTGYVBsW5gZ3nziZi8=; Message-ID: <1d8b51e1-a296-f40c-6eda-bab54dac915f@xen.org> Date: Thu, 17 Nov 2022 09:50:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Content-Language: en-US To: Bertrand Marquis Cc: Michal Orzel , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> <0400b2d8-6f2c-6406-d966-64ed5720688c@xen.org> <350afafd-821c-1a05-13cb-1704d3a61bfc@amd.com> <84710d96-c473-fa41-d847-2b109dfb49c9@xen.org> <85f4f42b-b1ee-36bf-5ba9-21b1047351cf@amd.com> <7d3f9021-d608-9e8f-9593-1099d7bd2003@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 17/11/2022 09:44, Bertrand Marquis wrote: > Hi, > >> On 17 Nov 2022, at 09:29, Julien Grall wrote: >> >> >> >> On 17/11/2022 08:34, Michal Orzel wrote: >>> Hi Julien, >>> On 16/11/2022 19:37, Julien Grall wrote: >>>> >>>> >>>> Hi Michal, >>>> >>>> On 16/11/2022 18:05, Michal Orzel wrote: >>>>> On 16/11/2022 16:56, Julien Grall wrote: >>>>>> >>>>>> >>>>>> On 16/11/2022 14:45, Michal Orzel wrote: >>>>>>> Hi Julien, >>>>>> >>>>>> Hi Michal, >>>>>> >>>>>>>> >>>>>>>>> and use it in the pl011-debug files (+ there is a question whether we should define WLEN_7-5 for completeness). >>>>>>>> >>>>>>>> I would not define WLEN_7-5. That said, I wonder if we really need to >>>>>>>> set the baud rate & co here? >>>>>>>> >>>>>>>> AFAICT the runtime driver never touch them. The reasoning is the >>>>>>>> firmware is responsible to configure the serial. Therefore, I would >>>>>>>> consider to drop the code (setting UARTCR might still be necessary). >>>>>>> I do not really agree because the current behavior was done on purpose. >>>>>> >>>>>> EARLY_UART_PL011_BAUD_RATE is only used for very early debugging (this >>>>>> is protected by CONFIG_DEBUG and CONFIG_EXPERT). This is not a >>>>>> production ready code. >>>>> I am fully aware of it. I just found it useful but I understand the global reasoning. >>>>> >>>>>> >>>>>>> At the moment early_uart_init is called only if EARLY_UART_PL011_BAUD_RATE is set to a value != 0. >>>>>>> This is done in order to have flexibility to either stick to what firmware/bootloader configured or to change this >>>>>>> configuration by specifying the EARLY_UART_PL011_BAUD_RATE (useful when you do not know what >>>>>>> the firmware configured). >>>>>> The chances are that you want to use the baud rate that was configured >>>>>> by the firmware. Otherwise, you would need to change the configuration >>>>>> of minicom (or whatever you used) to get proper output for the firmware >>>>>> and then Xen. >>>>>> >>>>>> Furthermore, as I wrote before, the runtime driver doesn't configure the >>>>>> baud rate. This was removed in Xen 4.7 (see commit 2048e17ca9df >>>>>> "drivers/pl011: Don't configure baudrate") because it was buggy and this >>>>>> code is not simple. >>>>>> >>>>>> So it makes no sense to configure the baud rate when using early printk >>>>>> but not the runtime driver. >>>>> Ok, so we will get rid of EARLY_UART_PL011_BAUD_RATE config and setting the bd >>>>> in the early uart code. Now, what about setting "8n1"? The runtime driver sets them >>>>> as well as the early code. It can also be set to a different value from the firmware >>>>> (unlikely but it can happen I think). In any case, if we decide to do what the runtime driver >>>>> does, I reckon setting LCR_H should be kept in early code. >>>> >>>> Good question. I think, you would end up with the same issue I mentioned >>>> above if the firmware and Xen have different line control registers >>>> (tools like minicom/screen would ask for it). >>>> >>>> So I am on the fence here. In one way, it seems pointless keep it. But >>>> on the other hand, Xen has always set it. So I have no data to prove >>>> this will be fine everywhere. >>> If we are relying on the firmware[1] to configure the baud rate, it is not very wise >>> not to rely on it to configure the LCR. Looking at the other serial drivers in Xen, >>> we have a real mismatch in what is being configured. Some of the drivers (omap, imx), >>> apart from setting 8n1 also set the baud rate explicitly to 115200 and almost all of them >>> do set 8n1. In that case we will not benefit too much from fixing just pl011. >> It is not great that Xen hardcode the baud rate (I can't remember whether there was a reason), but I don't think the consistency is necessary here (see more below). >> >>> On the other hand, Xen follows the zImage/Image protocols for ARM [2] which do not >>> state that serial port initializing is something mandatory. This could indicate that >>> the firmware does not really need to configure the serial. >> >> The firmware doesn't need to configure the serial and yes in theory Xen should configure the baud rate and parity based on the firmware table. >> >> However, this is a trade off between complexity and benefits. The patch I mentioned earlier has been removed nearly 6 years ago and I haven't seen anyone reporting any issues. >> >> Hence why I think for the PL011 it is not worth looking [3] at the baud rate and instead removing it completely in the early PL011 code as well. >> >> That said, if you feel strongly adding support for baud rate then I will be happy to review the patch. > > Just one remark here: In some cases the firmware might use a different console than the serial one (for example a graphical one) and Xen could be the first to use the serial console. > So there might be cases where if we do not set a default value, the console will not be configured at all. Fair point. > > I think the best solution here would be to have a CONFIG setting so that someone compiling Xen could choose between “keeping firmware config” or “force a config”. I don't like the idea of the CONFIG to force the baud rate at runtime. If you want to give the choice to the user, then this should be read from the firmware tables. In fact, the information should already be there. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Nov 17 09:54:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 09:54:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444863.699980 (Exim 4.92) (envelope-from ) id 1ovbay-0006Se-La; Thu, 17 Nov 2022 09:54:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444863.699980; Thu, 17 Nov 2022 09:54:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbay-0006SX-In; Thu, 17 Nov 2022 09:54:08 +0000 Received: by outflank-mailman (input) for mailman id 444863; Thu, 17 Nov 2022 09:54:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbax-0006SM-7b for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 09:54:07 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eae::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c4d0a866-665d-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 10:54:04 +0100 (CET) Received: from BN0PR04CA0044.namprd04.prod.outlook.com (2603:10b6:408:e8::19) by DS7PR12MB6007.namprd12.prod.outlook.com (2603:10b6:8:7e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Thu, 17 Nov 2022 09:54:02 +0000 Received: from BN8NAM11FT096.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e8:cafe::fb) by BN0PR04CA0044.outlook.office365.com (2603:10b6:408:e8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 09:54:02 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT096.mail.protection.outlook.com (10.13.177.195) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 09:54:01 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 03:54:01 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 01:53:51 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 17 Nov 2022 03:53:50 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4d0a866-665d-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=daoI7dQuBBuFNJbvMkhAXX8uB0Ofj1dD2CwQPsOKRqzdV2nO0kTJAVszYQFtKjwiQhHG62+jhx81s0P5tQQE5ddza0rAQd4xM3+rxiegB//KCLFlVfIMOISesQk7HqIk114TuGtCzkCgB+Fuwvp6WLClvjb8NqLX9VOITrwrxpRspRGbshN7b/QMLR0F8CFBFY/Hf40NcxTQjVaV9yywPPyHTkPEhJKNG2LI10baOuy80HTJZDPLVfaYs4fVRCiuf6ItBD8pty+sN86pQjYCFnZnxAyFyHmLmKBXAitZ8GJb5kARLsg3B32mljXAs9htlBozsbpOA0V/3JRbwnQ2FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ulrMRcfEuS4gXjhz1N7SHoZG+aLZM7wwvMdeJXbNHak=; b=LTh+QLHqYQd+SIM1L1nXItarfYemfAzzHOHLtR2nz1+AAvcle63H5KnNpwZ2eQbsTIWVpmbCX1o7R8CXvfxrJJOHOG1xucY6D4HlCNyXNYHo8pbJRdxrBJdZFyEXOkMv5oBIenfsHA0qQoYPO6iqIL3D1Ve8sFpQBxddgN0MS3ffJsIKl6vmTx/JQ681o9dcsRxjuyt+8xmmFpHOCRXEglraM8d6BhqmN99K8Z6sVC4MWf0DRPiaYG1mYN5AEOvFE2dh4mokeH1NJ68OcqyBlx9Duc+B9onrMNp1EzkCq8rwyejrKTEJgIlU5xIcoYV3tkhdGqXajwCnrTpE1m4gvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ulrMRcfEuS4gXjhz1N7SHoZG+aLZM7wwvMdeJXbNHak=; b=c53J5jWcjPz+nwzbZ77yTyfhswoQOTkEbaJqiaozvbYEIKlM4zDHo7T6vW/Gwo81cv5WPSavFNo/XHsgedarX5yzvyxTlB4780Fg8eP7XZ3L6h856VfE+TjUgbwS6VwJZ4ufuL8p6VyN0g7Cwc+TvVLFXj3kltl6BtH8ZZ6p3PA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Thu, 17 Nov 2022 10:53:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Content-Language: en-US To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> <0400b2d8-6f2c-6406-d966-64ed5720688c@xen.org> <350afafd-821c-1a05-13cb-1704d3a61bfc@amd.com> <84710d96-c473-fa41-d847-2b109dfb49c9@xen.org> <85f4f42b-b1ee-36bf-5ba9-21b1047351cf@amd.com> <7d3f9021-d608-9e8f-9593-1099d7bd2003@xen.org> From: Michal Orzel In-Reply-To: <7d3f9021-d608-9e8f-9593-1099d7bd2003@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT096:EE_|DS7PR12MB6007:EE_ X-MS-Office365-Filtering-Correlation-Id: 9daee2d9-dbaa-4fa0-8b96-08dac881a7cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: igzQorjBMLENfQYXN5o5pQxTfjz5fv02YQRNLiHVjn5zX8kuDTpg0UVM7cIu8RfVmxI2pAIJTK516eNFarmjqc7JvVNzZ2hkSV9vQKe4bcmXQ+zyLBrIekuW1XpsAgk+cPNDjnHTfkrAbTC/WoEHDYVIBxXRPpVyuPAPDhWe8olQLfH+j+lEDECnsTcNhvXwRSZYMrfZDyrLi9q0BaH7k9/eKi1SFCFaDAWeoXzDXPuSZlrydQXfFsWBUTUgMoii2NvvcH1liV675jDVTyji5MtL0wsu9bd+L38jzoIWSDODgHym82FAflQO8teM8rmnezAh+ayAQrvWIOlQYKn6j0ZfCIS+Ift9O8IF0z5p00zH8LUBaXpDY01xUDG5+EF8lH4/GOFpHq+N+4Wr84HMJYF6E1yubBm142ubSIhev6O+0czVgi/BgHuY8oEqUrFsFheaDSjA/H5UR13L3FAf6Wzs3IlD5+HeJwu6RThK10xJ7XFfkIbx/nXAx+juTRYclYepxmFKpc6azOw/si5JiM8yJJ3k9mkMwzzLhTzkOEJM4yAXlvKhCYi3XPaaywh0GfHBYTV0z5FPdYip7xw9PeudELhKAomKjZJGB2Isz3CkrpfwgB/l5mHT9NoJv/qL2bE92g0+jmVj/iaWMnnhT4vqLq/v5iAEv0Tnc1Rcr5uv67jLv+6MFJ02VKbSEbd+7qOMgTLHEzBGEFWQqgjKAd99BPd2458MV2S9IOr3J+HHHWCLHq0nJcjxvG95UTyI+iskOpLIi0TWfPfT2Eb9k2DvyTF+Wqk6oKYqpCqLct8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199015)(36840700001)(40470700004)(46966006)(36860700001)(82310400005)(40480700001)(36756003)(31696002)(86362001)(82740400003)(356005)(81166007)(54906003)(66899015)(31686004)(16576012)(53546011)(110136005)(316002)(966005)(478600001)(336012)(5660300002)(426003)(47076005)(44832011)(40460700003)(2616005)(186003)(8936002)(83380400001)(2906002)(70206006)(8676002)(4326008)(70586007)(26005)(41300700001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 09:54:01.7610 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9daee2d9-dbaa-4fa0-8b96-08dac881a7cf X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT096.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6007 Hi Julien, On 17/11/2022 10:29, Julien Grall wrote: > > > On 17/11/2022 08:34, Michal Orzel wrote: >> Hi Julien, >> >> On 16/11/2022 19:37, Julien Grall wrote: >>> >>> >>> Hi Michal, >>> >>> On 16/11/2022 18:05, Michal Orzel wrote: >>>> On 16/11/2022 16:56, Julien Grall wrote: >>>>> >>>>> >>>>> On 16/11/2022 14:45, Michal Orzel wrote: >>>>>> Hi Julien, >>>>> >>>>> Hi Michal, >>>>> >>>>>>> >>>>>>>> and use it in the pl011-debug files (+ there is a question whether we should define WLEN_7-5 for completeness). >>>>>>> >>>>>>> I would not define WLEN_7-5. That said, I wonder if we really need to >>>>>>> set the baud rate & co here? >>>>>>> >>>>>>> AFAICT the runtime driver never touch them. The reasoning is the >>>>>>> firmware is responsible to configure the serial. Therefore, I would >>>>>>> consider to drop the code (setting UARTCR might still be necessary). >>>>>> I do not really agree because the current behavior was done on purpose. >>>>> >>>>> EARLY_UART_PL011_BAUD_RATE is only used for very early debugging (this >>>>> is protected by CONFIG_DEBUG and CONFIG_EXPERT). This is not a >>>>> production ready code. >>>> I am fully aware of it. I just found it useful but I understand the global reasoning. >>>> >>>>> >>>>>> At the moment early_uart_init is called only if EARLY_UART_PL011_BAUD_RATE is set to a value != 0. >>>>>> This is done in order to have flexibility to either stick to what firmware/bootloader configured or to change this >>>>>> configuration by specifying the EARLY_UART_PL011_BAUD_RATE (useful when you do not know what >>>>>> the firmware configured). >>>>> The chances are that you want to use the baud rate that was configured >>>>> by the firmware. Otherwise, you would need to change the configuration >>>>> of minicom (or whatever you used) to get proper output for the firmware >>>>> and then Xen. >>>>> >>>>> Furthermore, as I wrote before, the runtime driver doesn't configure the >>>>> baud rate. This was removed in Xen 4.7 (see commit 2048e17ca9df >>>>> "drivers/pl011: Don't configure baudrate") because it was buggy and this >>>>> code is not simple. >>>>> >>>>> So it makes no sense to configure the baud rate when using early printk >>>>> but not the runtime driver. >>>> Ok, so we will get rid of EARLY_UART_PL011_BAUD_RATE config and setting the bd >>>> in the early uart code. Now, what about setting "8n1"? The runtime driver sets them >>>> as well as the early code. It can also be set to a different value from the firmware >>>> (unlikely but it can happen I think). In any case, if we decide to do what the runtime driver >>>> does, I reckon setting LCR_H should be kept in early code. >>> >>> Good question. I think, you would end up with the same issue I mentioned >>> above if the firmware and Xen have different line control registers >>> (tools like minicom/screen would ask for it). >>> >>> So I am on the fence here. In one way, it seems pointless keep it. But >>> on the other hand, Xen has always set it. So I have no data to prove >>> this will be fine everywhere. >> If we are relying on the firmware[1] to configure the baud rate, it is not very wise >> not to rely on it to configure the LCR. Looking at the other serial drivers in Xen, >> we have a real mismatch in what is being configured. Some of the drivers (omap, imx), >> apart from setting 8n1 also set the baud rate explicitly to 115200 and almost all of them >> do set 8n1. In that case we will not benefit too much from fixing just pl011. > It is not great that Xen hardcode the baud rate (I can't remember > whether there was a reason), but I don't think the consistency is > necessary here (see more below). > >> >> On the other hand, Xen follows the zImage/Image protocols for ARM [2] which do not >> state that serial port initializing is something mandatory. This could indicate that >> the firmware does not really need to configure the serial. > > The firmware doesn't need to configure the serial and yes in theory Xen > should configure the baud rate and parity based on the firmware table. > > However, this is a trade off between complexity and benefits. The patch > I mentioned earlier has been removed nearly 6 years ago and I haven't > seen anyone reporting any issues. > > Hence why I think for the PL011 it is not worth looking [3] at the baud > rate and instead removing it completely in the early PL011 code as well. > > That said, if you feel strongly adding support for baud rate then I will > be happy to review the patch. I'm not in favor of this approach either. That said, I will prepare patches to remove CONFIG_EARLY_UART_PL011_BAUD_RATE and its usage in early printk code as we agreed earlier. As for the LCR setting, I will keep it in early printk code to maintain the same behavior as runtime driver who sets them. > >> >> [1] It is not stated anywhere in our docs. > > Our docs are not perfect. Patches are welcomed for improvement. > Although, I think the statement should only be for driver where we don't > set the baud rate. For the others, we should leave it as is unless you > can prove this is not necessary (we don't want to break existing setup). > >> >> [2] BTW: our docs/misc/arm/booting contains invalid links to the kernel docs. I guess >> this wants to be fixed. > > Patches are welcomed. > > [3] I do have a large list of more critical bugs that I will be happy to > share if you are looking for improving Xen. That is cool and such list would be great for everyone having some spare time (+ newcomers). Taking the opportunity of having a GitLab CI epics, I think it is worth adding such work items here: https://gitlab.com/groups/xen-project/-/epics?state=opened&page=1&sort=start_date_desc > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Thu Nov 17 10:03:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 10:03:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444869.699991 (Exim 4.92) (envelope-from ) id 1ovbjt-00088k-Hw; Thu, 17 Nov 2022 10:03:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444869.699991; Thu, 17 Nov 2022 10:03:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbjt-00088d-EY; Thu, 17 Nov 2022 10:03:21 +0000 Received: by outflank-mailman (input) for mailman id 444869; Thu, 17 Nov 2022 10:03:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbjs-00088X-Ci for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 10:03:20 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20611.outbound.protection.outlook.com [2a01:111:f400:7e1b::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0f572d4e-665f-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 11:03:18 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7928.eurprd04.prod.outlook.com (2603:10a6:20b:2af::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Thu, 17 Nov 2022 10:03:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 10:03:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f572d4e-665f-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CHIXE+7fiLfhtSNuQIzn7eD8twolVwcsi3c2Ri9MsfWcdC4IdEl4eH/UN2pzgC/4GVDyOKwtH0ZuR7L9RODHr1Ywgq5DOCbgiNyELnR8ov6TwF/scULNC0gcHzhXlg3Z3mccd2ltFsrZMvUho3O2E/E35dvQ4X9IgAUVyxxxA20+Eiu8JXHfuyky+tA5nI5M5gDkY2u2YIwHwekm5GvX8yNjPsAuli4WJ32NGWJk3gRzfGUkTjsfOqXIaWatqgH3CqCxAOFgxyhER9HniLoIFvRtRbqO6AJvPO9VJ9wQdXEmhUzntIC/M0to3naiwR95QvJKrBeov3ofHfzqs5LGSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nuNei5qwv6o/7msBDuVlcfNyV0O3NJszWiyVcHWKmx4=; b=Uk5aoSHKYojyVOxZLRjo9P8M5fx48U1XC0JOxv9IOSaiNI6JxmEsDS8O9ewY8ag0FWYEO/RcnTetyVm2OJadcuH/23eaqs/gdY5LMKUn7EXRxI6oNgYUkycBaRAnbdibwduykR6F92iOPRhKljmb0u30RcS6itWnvDq5MIKSOa114cEyPP+2dj60SrMcvgRucpGR9mITpRePCSKSU17qJd7vlcWNDT8ea4ipSVNbWLoQR3H7W3EaD1fKSuH9bJkMBSDveKssoJ1U1TcdRwkwGRW+Q+tT+odB1uQ57fATsaXGiYyw0bcremMAM7fae4OUNvn2x8z/5qCFgvJGYCIjWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nuNei5qwv6o/7msBDuVlcfNyV0O3NJszWiyVcHWKmx4=; b=aSy3wG/JXA2VUyuwRgdwleP073A7OhYuOQLK/DSmCnKk/2Pe1wg/hI2mkYwv9tS1JUuvQb96GL2kp7LXATrONk6lFVMyeIM/i0ZLXKUTZkdjoELgFnjFxiq+LMtwShG/CMbR/+NxcXro73TNJNEJO8H2SeMJGUj4smZhdNEfO8jXerU/SqlHZWl+62XKmVZB79ZVDlboY7jZIw36CpsEPg56B6nIIoOd3lpCSS5274IXQZadlQMWy1NjI1rdONOwOZfY3Z9up6vi2ol9+094nRjzs2Qc0E/6d2A52lYhifI6XCGQiBUgnNLRp33FDL5pwcmw+VcVE6aBKNdrPnVN4A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <93736488-8e0c-282a-2e5f-db0cf9419183@suse.com> Date: Thu, 17 Nov 2022 11:03:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFC] docs/misra: List files in Xen originated from external sources Content-Language: en-US To: Michal Orzel Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20221116092032.4423-1-michal.orzel@amd.com> From: Jan Beulich In-Reply-To: <20221116092032.4423-1-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7928:EE_ X-MS-Office365-Filtering-Correlation-Id: 6594b289-4975-4774-262b-08dac882f2eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AGEdzP0CKfdTCuDmLx+veJwz75yGfko/rmS1NektElC9pAcDUlnuZOAIzpaGc3qDjT4YI9jODdIYZfCqciE99SsHaYrBR0qrmRpSZNV0W2b/4YqtxMBAno6wFU9PL1urnrcnvJqIlcYvsqiwrNwrqQv3TXSiNhATjI8pp+BYFnZh92825xPMyeT1pGnl8atyjn8AFVgcgHSvLOFnRwWeOnhpR9pS66noJ9Hzx/CUbUQFilLtZbXokIgHbIca1Wz/SY59Gxqi2AeIJviSSRJVIJkaygRQIxWdGc4YbqkawlIlhl4j+PxvkRFT+Q5Jhe5Dp4EAnrMfqHfV5TtskislqUAvdjL5PQ68VUpivSN0p3V2qYS9xKMVMDG0zBF+ylJ6Tu0ae8OMKCgiGhgrfKdawvlxadY81f6OE7pBp9qCCXmFsACOkzWjdoHJv5Ol0qcneTZ12d/fvJdLu6OKRd2uH5ZbbATwceuKreKuNQY4kaY1bY/1HW3BYmiO+cA1Z7oASQB3gkVEYE0iUSJ3M60Bxpi9f/xq4yxUk3q7mU8WynC+XZSKzvauiXjVJxG3mUzUq61eJhvZ/7GgpoUQnsPdsJ2NLQLsrc4MUXLJUWIghntcGUvusEPnzdHQkcoCF/mKmrjSFqZSsQAfBDHH/tnzGSGpcMeJPzvMLUy5S9LhyTCkH4/brDurM5zuMyMe0uEv6l9jwl2oRgZ49BeEl8ArJolzYMXFkM5501w7UpppvmI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(136003)(376002)(366004)(346002)(451199015)(66556008)(4326008)(66946007)(8676002)(316002)(66476007)(6916009)(31696002)(8936002)(86362001)(36756003)(41300700001)(5660300002)(478600001)(2616005)(186003)(53546011)(6512007)(26005)(6506007)(54906003)(38100700002)(6486002)(83380400001)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmRVckkycStOVlNwOHpYWGtCNThBS1AzTHJJbERSY0NZMWMyYlFFYnQrV2xI?= =?utf-8?B?SnFoaURlcitaUWhWWlB2YVlIOXFiRVhLQklnYU1IdkQzQWpSbHd3MWplcm1W?= =?utf-8?B?c2V1NkxzSTJNaEZCL2hobVFhNjNvSWRiR3hzTCtHOTJGS2RRSVNab3lHZTVV?= =?utf-8?B?UkdHNXFkOFdKT2R5YU9hMEpWR09BUnBPa2RqSUtPcUIwaUlEclhEQ3NXRnpB?= =?utf-8?B?ZWdISHVOT0x6ZFJucVhNN1diUUw4NnRIUnZEcU93R29wNk91YkNWMEVoZnFO?= =?utf-8?B?djI2ZW9hU0RPMmo5MG9WTzFjVXVPWE9xU0QvVE94cmxoTERIMDFua3RsL0Fh?= =?utf-8?B?RThwcUNpbUJDRU9sdGVmQlFOSENydktTU0dDRHVkSUhwUmhFV2JMU3pSSkhQ?= =?utf-8?B?VHdIc2JHRitudGN2WDFZM3pSdlAyWllZNXhJaWlTN0R2TXEyMW9ZVlI5ZkVl?= =?utf-8?B?aG9qcU9xOU4wajhFelU1YVhtWFNKOEVmSGNMTm9rVjFOM3l1QXJzMGx4WkZX?= =?utf-8?B?TWtHRW4vMUE2b2pLMXFSNHJDYytwa0tYVXBhNUJHUE5DYkVjUGpocU15bHAr?= =?utf-8?B?TmpiQ3NYNUxpbkZTOFBLaWtLTUNEVTVVV0V4TzZRNmg3QTE4WW0vUlg2K1ZV?= =?utf-8?B?ME1mcGlCeTRqa3BDaUsxRkh5RWl5SHRVTG5rT21sbm50dUY1OVNKQ2YwZ1A1?= =?utf-8?B?d1k0bHdzNExDMHNSOTVXTEpnZGxxZUFzY1JCUUxkWnIyNm01cUI5RVVQUjEy?= =?utf-8?B?bmxtUW5YZTRoKzhSN3c2aVdKOG5ORDhIVEtwRUh1OWs2b0dRbVRxTElUZ2ox?= =?utf-8?B?RUxIQlBTakxMdTZMTlF6WnQ0YTRnY2VCbDVub09yL28vSStXRTBXalFFWnZw?= =?utf-8?B?aktLdmRDZ3lkajAvV3AwTWF2ejBtQzRaK0JuOVpoS2NFbTN6aGtZS1VpQkNu?= =?utf-8?B?eXBVNjJBcVYxZGsrYzEzVXdPVTZQK2J2dzc1VlFVRzJxdGFndjdqSFdUQUVt?= =?utf-8?B?YkZSY0tWWjVNd2JzTytLZlBxbjVRWEJyeXo0bW5WTWl5dTZUemtzQkVpLy9z?= =?utf-8?B?OGxRNlFDYXAyNHd6Skk4b2ZheDJjVHpkMFFRMkN1YjRXNkZYWEpvK1VSdWJE?= =?utf-8?B?Z2xteHFhdVFiY1FwbW9OOUF1Y21hV2drNEM5Qld0c0VoODV6dE1sU21GQ0JU?= =?utf-8?B?SDQ5QmlkdmVrRDdtN3VodXRxRmh6OTEzeDY3VHRJam5MSzh6LzVoOWE0SFZl?= =?utf-8?B?Yko0VXZWRVk1amJuWGRGQjFCU04rYkxhNmxkT3hQVC9RaHpPN09wTGhRcGlV?= =?utf-8?B?VHFuNy9BTUoxMmc1dThldjBNSHQydFJCWHQ0WTN3YzVrYlBLNFNSODlTaXdV?= =?utf-8?B?NWN3eTczQmROYlNCQlFOOVltNlQySUxWR3hweEdMZy81NGMxRklQblpmc1BZ?= =?utf-8?B?aGFCeS9POFJUdmdid3MzTVVCaEZQcTFIbzEzL0p6eDBNVTBhMy9pNG9lN1Vp?= =?utf-8?B?RTdHbWFLQW9CR3lYMzd0QTNVaEd4aTc0SG92djdDb3p1c1VPeTJBQ0ZseXJU?= =?utf-8?B?c1U0MGc3U21xcmFVV2x1KzVSdjgwZmFmcXllNkI4aWVDU3B6RzVkYy9XdTlq?= =?utf-8?B?RXQ5Wll1OFV5Z0UzU1NJMk1LanBsRmwwNGloTnpNK216dWwxQ2JxT3ZMTEJK?= =?utf-8?B?V01WRjVYVFN1NDIyWmUxZzdaR0Ixa1lNRnFXbEJHZy9XZW9UbnM1Qmd6RXFJ?= =?utf-8?B?MERyQWY0bGhpTVUyUE1wQ295REM2ZmRTRXlYQUxCbEx3YnVtcHhhOEhudWJV?= =?utf-8?B?REphS1RtOE81YUp4cnhMYXFGZDd1Y1J2MzlmVnlDemlnMTFuQk5yam80dVFs?= =?utf-8?B?eVkwcDU3TUs4YTYrZDYzeVBIMHRoTExZQUNnM3JtOHhvTUh6Vkd4aURxeVRj?= =?utf-8?B?ejBKaDI2L1g5ckVYQnc0eC9JcVJRUWFrcEFYUnpZdGs2OEpobXV2aGNId3cr?= =?utf-8?B?Y01kVXJBUFEvYVluYVVmcXBHdDd2bDNhWFNqVHpkZGtiUklOOXFZcm9acUZw?= =?utf-8?B?bEpIRzhsSmRMdGpOM3lqd1l3c1RXU2d4eEtNalRudVNyYlN0ZzJJbUxub1dX?= =?utf-8?Q?uAyFQuHGizqK8UXy9RXvCPoJN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6594b289-4975-4774-262b-08dac882f2eb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 10:03:17.4397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LEChEuX+5QtojGNDu1eKKWxs27sx+JCrd9OlXkkDS2fneTmoPkoPK8wDpv6ZxdcAhBeLecaz6UIs+xsTzMar1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7928 On 16.11.2022 10:20, Michal Orzel wrote: > --- /dev/null > +++ b/docs/misra/external-files.txt > @@ -0,0 +1,70 @@ > +External files in Xen > +===================== > + > +The following table lists files present in the Xen codebase that originated > +from external sources e.g. Linux kernel. The purpose of this table is to: > + - keep track of the external files in the Xen codebase, > + - help with the review process (e.g. changes done to the files that did not > + diverge, shall be first submitted to the external projects and then > + backported to Xen), > + - act as a base for listing files to exclude from MISRA checkers. > + > +NOTES: > +1) The files shall be listed in alphabetical order. But then you don't? > +2) The origin of the files derived from the projects other than Linux, shall > + be specified within the () placed next to the path. Might it be more generally useful to have another column, then not only stating the project but also the path it lives at there (or lived at the time of cloning)? > +3) The table shall be updated when importing new files from external projects. > +4) At the moment, only the source files are listed in the table. > + > +| Relative path to xen/ | Diverged from | Subject to | > +| | origin? [Y/N] | backports? [Y/N] | > ++-------------------------------------------+---------------+------------------+ > +| arch/arm/arm64/cpufeature.c | N | Y | > +| arch/arm/arm64/insn.c | N | Y | > +| arch/arm/arm64/lib/find_next_bit.c | N | Y | > +| arch/x86/acpi/boot.c | Y | ? | > +| arch/x86/acpi/lib.c | ? | ? | This was simply split off from boot.c, which I'd be inclined to take to mean Y in the "diverged" column. In the backports column I'd prefer to keep ? for both, or any other indicator taken to mean "maybe / uncertain". What about arch/x86/acpi/cpufreq/* and other stuff in arch/x86/acpi/? > +| arch/x86/cpu/mcheck/mce-apei.c | N | Y | > +| arch/x86/cpu/mcheck/non-fatal.c | ? | Y | Even before disappearing in 2.6.32 the file was different from Linux'es, simply because we don't have anything like schedule_delayed_work(). So it's pretty clearly Y for "diverged". > +| arch/x86/cpu/mtrr/* | Y | N | > +| arch/x86/cpu/amd.c | Y | N | > +| arch/x86/cpu/centaur.c | Y | N | > +| arch/x86/cpu/common.c | Y | N | > +| arch/x86/cpu/hygon.c | Y | N | > +| arch/x86/cpu/intel_cacheinfo.c | Y | Y | > +| arch/x86/cpu/intel.c | Y | N | > +| arch/x86/cpu/mwait-idle.c | Y | Y | > +| arch/x86/genapic/* | Y | N | > +| arch/x86/x86_64/mmconf-fam10h.c | N | Y | > +| arch/x86/dmi_scan.c | Y | ? | > +| arch/x86/mpparse.c | Y | ? | Like above I'd like to keep ? (or alike) here, as neither Y nor N are fully accurate. > +| arch/x86/srat.c | Y | N | What about common/cpu.c? > +| common/libfdt/* (libfdt) | N | Y | > +| common/lz4/decompress.c | N | Y | > +| common/ubsan/ubsan.c | Y | Y | > +| common/xz/* | N | Y | > +| common/zstd/* | N | Y | > +| common/bitmap.c | N | Y | > +| common/bunzip2.c | N | Y | > +| common/earlycpio.c | N | Y | > +| common/inflate.c | N | Y | What about common/notifier.c? > +| common/radix-tree.c | N | Y | What about common/rcupdate.c? (Stopping at this in this regard: It's unclear by what criteria you have gone. Even as simple an indicator as "Copyright (C) ... Linus Torvalds" was apparently not used. Similarly mentioning criteria for considering a file "diverged" would be very helpful to spell out, even if there's likely some fuzziness involved there.) > +| common/un*.c | N | Y | > +| crypto/rijndael.c (OpenBSD) | N | Y | > +| crypto/vmac.c (public domain) | N | Y | > +| drivers/acpi/apei/* | N | Y | I'm not sure of the N here. > +| drivers/acpi/tables/* | N | Y | > +| drivers/acpi/utilities/* | N | Y | > +| drivers/acpi/hwregs.c | N | Y | > +| drivers/acpi/numa.c | ? | Y | Y > +| drivers/acpi/osl.c | Y | Y | > +| drivers/acpi/reboot.c | N | Y | > +| drivers/acpi/tables.c | ? | Y | Y What about drivers/cpufreq/*, drivers/char/ehci-dbgp.c, drivers/char/xhci-dbc.c, and drivers/video/font*? What about some of the stuff under tools/, especially tools/kconfig/? Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 17 10:11:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 10:11:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444877.700010 (Exim 4.92) (envelope-from ) id 1ovbrb-0001Ps-IZ; Thu, 17 Nov 2022 10:11:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444877.700010; Thu, 17 Nov 2022 10:11:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbrb-0001Pl-Fq; Thu, 17 Nov 2022 10:11:19 +0000 Received: by outflank-mailman (input) for mailman id 444877; Thu, 17 Nov 2022 10:11:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbra-0001PP-48; Thu, 17 Nov 2022 10:11:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbra-0007Nm-1u; Thu, 17 Nov 2022 10:11:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbrZ-00014w-EA; Thu, 17 Nov 2022 10:11:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovbrZ-0005uN-Di; Thu, 17 Nov 2022 10:11:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yp2smzMSeRF8M+h74JgsQZwQnR3QxfsBEwS47lK92uk=; b=TquBuSex7hmw/+hBXZAl5oPMrE 8irZR4Rb5RHFXzti2HXoUyxziQS7pgpg/q/RNOOZxTJDi6nCrqJZCx2DGx35kE/qhxGjpNBQGiITZ KBrN7bQRCUH17v9KxZ7p/M5xxG/tbscghzA0EqCdBsbjdiktIs0br5q1i2Ub7re+lE84=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174797: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f5d56f4b253072264efc0fece698a91779e362f5 X-Osstest-Versions-That: xen=2a98e98f96d1aafddf8869db5e2382d0ddaae01a From: osstest service owner Date: Thu, 17 Nov 2022 10:11:17 +0000 flight 174797 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174797/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174791 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174791 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174791 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174791 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174791 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174791 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174791 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174791 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174791 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174791 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174791 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174791 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen f5d56f4b253072264efc0fece698a91779e362f5 baseline version: xen 2a98e98f96d1aafddf8869db5e2382d0ddaae01a Last test of basis 174791 2022-11-16 14:08:25 Z 0 days Testing same since 174797 2022-11-17 03:03:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Andrew Cooper [Citrix relicensing] Anthony PERARD Grant Likely [Linaro relicensing] Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2a98e98f96..f5d56f4b25 f5d56f4b253072264efc0fece698a91779e362f5 -> master From xen-devel-bounces@lists.xenproject.org Thu Nov 17 10:11:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 10:11:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444884.700033 (Exim 4.92) (envelope-from ) id 1ovbs1-0001wg-11; Thu, 17 Nov 2022 10:11:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444884.700033; Thu, 17 Nov 2022 10:11:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbs0-0001wG-U4; Thu, 17 Nov 2022 10:11:44 +0000 Received: by outflank-mailman (input) for mailman id 444884; Thu, 17 Nov 2022 10:11:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbrz-0001vj-2M for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 10:11:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbry-0007Oc-MN; Thu, 17 Nov 2022 10:11:42 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.7.117]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ovbry-0002Vm-F8; Thu, 17 Nov 2022 10:11:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=+lE1OfH2Wa6yVgvUbxDsqQGAdIYuuPNt91zLs8IG17k=; b=mYpYUjgyYohWDLFbm+XJwsGUYD 1TGNKKWcKO6Ptc13Awc2Dq9jBSzlSPNaOuIZZqIqlByKrGWnC5eEkeTYR0OG2OP8jCDxVpjANg3Hj 1kezAfkbNJaYbAJ69QhJgxnxGvz/S3OROhTgZHkPeXFCQ055YUPckuXFsQdOAEMyiVcw=; Message-ID: <51fdb064-682e-b995-5171-ba23f75bc760@xen.org> Date: Thu, 17 Nov 2022 10:11:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> <0400b2d8-6f2c-6406-d966-64ed5720688c@xen.org> <350afafd-821c-1a05-13cb-1704d3a61bfc@amd.com> <84710d96-c473-fa41-d847-2b109dfb49c9@xen.org> <85f4f42b-b1ee-36bf-5ba9-21b1047351cf@amd.com> <7d3f9021-d608-9e8f-9593-1099d7bd2003@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 17/11/2022 09:53, Michal Orzel wrote: > On 17/11/2022 10:29, Julien Grall wrote: >> >> >> On 17/11/2022 08:34, Michal Orzel wrote: >>> Hi Julien, >>> >>> On 16/11/2022 19:37, Julien Grall wrote: >>>> >>>> >>>> Hi Michal, >>>> >>>> On 16/11/2022 18:05, Michal Orzel wrote: >>>>> On 16/11/2022 16:56, Julien Grall wrote: >>>>>> >>>>>> >>>>>> On 16/11/2022 14:45, Michal Orzel wrote: >>>>>>> Hi Julien, >>>>>> >>>>>> Hi Michal, >>>>>> >>>>>>>> >>>>>>>>> and use it in the pl011-debug files (+ there is a question whether we should define WLEN_7-5 for completeness). >>>>>>>> >>>>>>>> I would not define WLEN_7-5. That said, I wonder if we really need to >>>>>>>> set the baud rate & co here? >>>>>>>> >>>>>>>> AFAICT the runtime driver never touch them. The reasoning is the >>>>>>>> firmware is responsible to configure the serial. Therefore, I would >>>>>>>> consider to drop the code (setting UARTCR might still be necessary). >>>>>>> I do not really agree because the current behavior was done on purpose. >>>>>> >>>>>> EARLY_UART_PL011_BAUD_RATE is only used for very early debugging (this >>>>>> is protected by CONFIG_DEBUG and CONFIG_EXPERT). This is not a >>>>>> production ready code. >>>>> I am fully aware of it. I just found it useful but I understand the global reasoning. >>>>> >>>>>> >>>>>>> At the moment early_uart_init is called only if EARLY_UART_PL011_BAUD_RATE is set to a value != 0. >>>>>>> This is done in order to have flexibility to either stick to what firmware/bootloader configured or to change this >>>>>>> configuration by specifying the EARLY_UART_PL011_BAUD_RATE (useful when you do not know what >>>>>>> the firmware configured). >>>>>> The chances are that you want to use the baud rate that was configured >>>>>> by the firmware. Otherwise, you would need to change the configuration >>>>>> of minicom (or whatever you used) to get proper output for the firmware >>>>>> and then Xen. >>>>>> >>>>>> Furthermore, as I wrote before, the runtime driver doesn't configure the >>>>>> baud rate. This was removed in Xen 4.7 (see commit 2048e17ca9df >>>>>> "drivers/pl011: Don't configure baudrate") because it was buggy and this >>>>>> code is not simple. >>>>>> >>>>>> So it makes no sense to configure the baud rate when using early printk >>>>>> but not the runtime driver. >>>>> Ok, so we will get rid of EARLY_UART_PL011_BAUD_RATE config and setting the bd >>>>> in the early uart code. Now, what about setting "8n1"? The runtime driver sets them >>>>> as well as the early code. It can also be set to a different value from the firmware >>>>> (unlikely but it can happen I think). In any case, if we decide to do what the runtime driver >>>>> does, I reckon setting LCR_H should be kept in early code. >>>> >>>> Good question. I think, you would end up with the same issue I mentioned >>>> above if the firmware and Xen have different line control registers >>>> (tools like minicom/screen would ask for it). >>>> >>>> So I am on the fence here. In one way, it seems pointless keep it. But >>>> on the other hand, Xen has always set it. So I have no data to prove >>>> this will be fine everywhere. >>> If we are relying on the firmware[1] to configure the baud rate, it is not very wise >>> not to rely on it to configure the LCR. Looking at the other serial drivers in Xen, >>> we have a real mismatch in what is being configured. Some of the drivers (omap, imx), >>> apart from setting 8n1 also set the baud rate explicitly to 115200 and almost all of them >>> do set 8n1. In that case we will not benefit too much from fixing just pl011. >> It is not great that Xen hardcode the baud rate (I can't remember >> whether there was a reason), but I don't think the consistency is >> necessary here (see more below). >> >>> >>> On the other hand, Xen follows the zImage/Image protocols for ARM [2] which do not >>> state that serial port initializing is something mandatory. This could indicate that >>> the firmware does not really need to configure the serial. >> >> The firmware doesn't need to configure the serial and yes in theory Xen >> should configure the baud rate and parity based on the firmware table. >> >> However, this is a trade off between complexity and benefits. The patch >> I mentioned earlier has been removed nearly 6 years ago and I haven't >> seen anyone reporting any issues. >> >> Hence why I think for the PL011 it is not worth looking [3] at the baud >> rate and instead removing it completely in the early PL011 code as well. >> >> That said, if you feel strongly adding support for baud rate then I will >> be happy to review the patch. > I'm not in favor of this approach either. That said, I will prepare patches to remove > CONFIG_EARLY_UART_PL011_BAUD_RATE and its usage in early printk code as we agreed earlier. > As for the LCR setting, I will keep it in early printk code to maintain the same behavior as > runtime driver who sets them. > >> >>> >>> [1] It is not stated anywhere in our docs. >> >> Our docs are not perfect. Patches are welcomed for improvement. >> Although, I think the statement should only be for driver where we don't >> set the baud rate. For the others, we should leave it as is unless you >> can prove this is not necessary (we don't want to break existing setup). >> >>> >>> [2] BTW: our docs/misc/arm/booting contains invalid links to the kernel docs. I guess >>> this wants to be fixed. >> >> Patches are welcomed. >> >> [3] I do have a large list of more critical bugs that I will be happy to >> share if you are looking for improving Xen. > That is cool and such list would be great for everyone having some spare time (+ newcomers). > Taking the opportunity of having a GitLab CI epics, I think it is worth adding such work items here: > https://gitlab.com/groups/xen-project/-/epics?state=opened&page=1&sort=start_date_desc I already have a Trello board I created a few years ago when I left Arm [1] with 30+ issues. I have another 30+ in my private board. I can try to clean-up the one I have in my private board. But I will need some help for transfer everything to gitlab. Cheers, [1] https://trello.com/invite/b/L54vXoqM/ATTI99c86a2718dec17b3b08f0de35fb3b5bC8729E45/xen -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Nov 17 10:18:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 10:18:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444895.700052 (Exim 4.92) (envelope-from ) id 1ovbym-0002wj-7S; Thu, 17 Nov 2022 10:18:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444895.700052; Thu, 17 Nov 2022 10:18:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbym-0002wc-3A; Thu, 17 Nov 2022 10:18:44 +0000 Received: by outflank-mailman (input) for mailman id 444895; Thu, 17 Nov 2022 10:18:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovbyl-0002wW-3k for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 10:18:43 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060c.outbound.protection.outlook.com [2a01:111:f400:7e1a::60c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 35676020-6661-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 11:18:41 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8207.eurprd04.prod.outlook.com (2603:10a6:102:1cd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 10:18:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 10:18:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35676020-6661-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P41FUvF7Wd6+X9KN1373kifOoTouAi/sjT9X6Tys3Z8qKoKE+6uMYkqKS27fzhHvCeSb9HRu2NvHIcQJjkhxV8xUjDZVJViPQRZRV0UfBO73NieZxudGNuzJdioSuAzOQaQKzZcYHbm5gpklffHyMk1iIAQ7aXWsWzzXq9NNXumZKEyfVm4dAcOJmklT5lTp7BlQWRKoZt53pLCfoCMn1fIMD1n358ZDegfbiCqOzakbirllq195dPD2bzQnYtxymcIGLwS2sw13vYFhsqvha2oHypPGF77GcBnxDWKI5ryy7WAULNu0biyTAcK9vRu4svV7ohtTa0DGvXTS7bwTfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tvy92WkXe45I9oOXd1L/urf2YeCxtLaQ1nwyO/wJ8Qw=; b=FpCuNWe1M6rXA+Q0J8Bdl+x97NkUSb4rP/CFbhxZIGy6jZz8IRWBAu/MvjBh3hUvZoTWtgsGeBH7oM2yD2n9vJsvCfJyOLuioAK8H+pMJM7Cdmcp4T3rnceI49dlpBGfBd3E+hCSWGdlMaHlcD/Ih7MHAbdB0sByrnCP7yNX6IHghLJSAwsnuB2UD1PXpR7YE7HhRIrJrvpjY95P9gPSOtcGAurMBmizWNgKD4AiwVxOXUBw6FgIjZ3gjWgAI5wwcfiYSPuiC43Thz7EhAFlS8UJFwyJ7EbhSRYooTiMAoAp6Y6v1IwzArtS6g7VesA7eijTVrzxEoKRO8E28dGwiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tvy92WkXe45I9oOXd1L/urf2YeCxtLaQ1nwyO/wJ8Qw=; b=1A3/eZ8arD4aEhVo4uQ2meK3FvhI2xDej1rDjQb+bKRHN5ql1GvKTMxXxKseGHZoXBSkX05cuc72yX2ZNnJj2WLpUJap8djhAiW6wOefLauueW3QnivHIPcblp2GuIv5FHqN6UNYCfhqG3Fuyut9iqNBkUShtzIU096evtsS6jpoenVIsiOfSiwpaLf90PbbLbto0V3xqpYPWZKpNtA+gxJjofXLe+NWuvPiovnAM86vSpdY/NLXTqdo5CCj/PI/HNGATBxjqHZmGvIBsKp8UIFfP4xSni1zyDMRVL3HPrxdNMprigevYY68b7FS0vTn5HryqyvcMLsPglImWyTUvQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <50b643b9-0347-4587-0c32-7af018485911@suse.com> Date: Thu, 17 Nov 2022 11:18:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the paging mempool size Content-Language: en-US To: Andrew Cooper , Xen-devel Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony PERARD References: <20221117010804.9384-1-andrew.cooper3@citrix.com> <20221117010804.9384-2-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20221117010804.9384-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8207:EE_ X-MS-Office365-Filtering-Correlation-Id: 4bf2bc80-a71d-464a-60ca-08dac88518b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZvhvCJz4LdRQYiyw696tERAImq6FtXQ5gmNclaugWYvwHEP0JVetow/1Q3kPxk5+lcDLRDiPa0PQEtx+lpkpp+vWE/Wf7efWcGFf6aKRIGzO6P9tuIlj1BXlJqC6nKpKL002aQLNSMaEAFvDhuG2zmB4qq8fL8kRUQ130LNQHp/Y77a5H39ARzQGcy/8sD9jZLGzLFQEmYBgESGXccSbACnpE6gpyqonus69wXVr6iDF5+D6zNXoFaqn9aED8NqCBbMKIOAjnUVNiWHqsKfhdnWZ/YOemjcWLozCR+b/6POUgrh0h8ZwXExFo1FgQbBe+2oPKDR0AYaeRtC2BxxIszQFX7R67eOagUWSax4ta66GAXttVCV7FrfGqi+PB2jLrdo8caBD0PjKCq6UFtur207ZA4D3ulHk/NrWStVfk1petXhqpdXHOX4AeWC0pjIuWsbR0VidQmgWqqMS7mbaHp2B27Ygm4Dw4RX4Gde7Z2amhoEJeUqtFzaAzCtdnsw9Zy4H/SIfhfg0/DW+9VjswPfCc5cfZrWZIiVY+l8RPqXZ1U8so57JlfRabty7trCNGmQMN3nLpRsAdNwVhEppBhCGFnhb+8RI1aRjQx/7edDN5j8GBTRI0KSrT/2Iyi1YmmbfOJVoEklEhnrHi2HpEZyNMMjygHspv9k7QMZnarrKejwKufewB7w8GrwPotTd2QSLPXmTobgVO0+m7X/bbAY6GNMFmyiiE4d8upDoj1I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(396003)(366004)(136003)(376002)(451199015)(186003)(7416002)(5660300002)(6506007)(110136005)(316002)(54906003)(53546011)(41300700001)(2616005)(8936002)(6512007)(26005)(66946007)(66556008)(66476007)(36756003)(8676002)(4326008)(38100700002)(2906002)(83380400001)(86362001)(31696002)(478600001)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmY1bFRBeVRyQjRRdlo5YUxJb0dNNkpjSlEwZi8xZ3oxenorN3M4aU54ZTgr?= =?utf-8?B?YStKa2dmd09jQmFRNnVKMFd2aXVhOTN1OE5SdlZ6NDJiU0FMOER2VTMrTFEw?= =?utf-8?B?dDdPT3A2cnJSM1MyWnNkckxzcmNzUEIwTFRFOXI4YVVPcHNLYVluWXZOT1BR?= =?utf-8?B?THdvTjNpVG9LRi9CMlRobnVMOHNaUm12U0hsYVNtenBhb0wxS0tuN2tmNU1J?= =?utf-8?B?RURibHI4U1EybEQxQTRVcGs5QVU4aGRUaU5YK2VMVU9scmxBZ0ZDek9ab2ly?= =?utf-8?B?clJvMkloeVBGeUlYWGw2TVgydEsreEEyTVRFLzFERDBNTlExUzJTY3dwVWM2?= =?utf-8?B?ZnhIWlJsUGpQTHR4Z21lcUFyRlVrY3RSV1FsMndzOTd5YkcyUXltWFFOTVox?= =?utf-8?B?YXhJSS9uRVVNTGl2T2xDVitDZjdTbEFUU3lVdnRKbHIrUEtUT1hkN3pQWVB4?= =?utf-8?B?ZUZDQTYyUk0zdmdZZzV6Z2RvUWRvTDV4Sm8zTUtxbi9QbmhKM0h5MnQwdmdX?= =?utf-8?B?UEg1VVJ5U0FReVpFTDl0RFBCMmNUenZUcjNiNkFsc2VJdWJsT2pyODBjS0hJ?= =?utf-8?B?NDdwZkJKRmZ2V2tmTDNESUZEd2ZNSUhiaUlEdmN0ZXEzTTd3TUI0YVZOeTVN?= =?utf-8?B?MGdreU1hNGs4bjJhRzZRMEZIZnk1dm9aZDcrQkliQWE4dUpIaXVCeXNGK2VO?= =?utf-8?B?K2NoSG5CTy9UZUE4QjhPUWRhajllbkVEYm1adnRMYlJ5cUFKNXZBNGZJT0Jh?= =?utf-8?B?VTl2UkpBM1FKWHMxSHlocFBLLzRoVXdFK1lnUlRwNldUSzNRc0F6WC9RNlQ0?= =?utf-8?B?bUF5OWlXSWZqS1prb2dHTStPVzFPU2s5b0VsTmxpZXBkeVp3dHM4TmpQS2Ny?= =?utf-8?B?RE9rUk9qdlRWZlNXVUpIclBpQ2MxRDdsSEhjUDVQN3Y5LzZtZ255SUdpbngv?= =?utf-8?B?M1BDOW4zNUZoMVNpaXZDdThTQ2RWdm9yT3R2UDNXN2p1Vll6MkgxenRuTTMw?= =?utf-8?B?SVlYV1FpVDB5b0wzRDBHaHZkYmwxYTlQWFRFWVJuZGNCbVRXUVdDTDJiNktx?= =?utf-8?B?TVV2Q3ZEdzlPczdjSFluVmhUUTBpbXJDY1A1dXYrYmh1Zi8rK2hLOUZGc3hS?= =?utf-8?B?bVhHdjhmdklueWxHak5KZ1BWOVExb3FSeVlzaDVYZHk3bURLR2IzVU5qcG0y?= =?utf-8?B?UDhvNy9NcFJzTXlyTjNaN2JVVm9uREd6SUZxMHpaaUtCV2sreGwwL2pvSWFK?= =?utf-8?B?THNpajQxWGJKeVFhUlo5djR6T2d4L2RGNjFHYXlkNCtJaWlqRlAwZHg3dTVZ?= =?utf-8?B?Q0hiYjg1d0tCelJ4b0V6dUpvN3BiNlpPK1hCQkNmS3VpdDZEazFDVHNaU2dw?= =?utf-8?B?UWdXKzBDNDFtN0FxVnZtZFJBRzRleU05Z0JpVE13dkNaM3A5L1ZHWUpyLzYv?= =?utf-8?B?eWtUMU4raEY0c3JxWDVhMkFwK3cyQVVhV21HS04zbk5maGJpM3ZSNU5hbmJV?= =?utf-8?B?UUZlaUwya0F1WnBJWVVLSU55aVMvTzdJbFlpZEJXQTVVd3llS1VWTkRGRlNs?= =?utf-8?B?eEkvTmhaeTltcFl1TmZtVmkycDlvb3Ntbjg2RTRxUkpRVE9hQWdmU3hNeDRQ?= =?utf-8?B?cUovZWs2UUE2VHJVYkxVSDJoQkJKSVZkS3NIUFc0NG9mMzhXRUhxVUZKeGt2?= =?utf-8?B?dGd1RUFRUXpBM2U2MEdkRHM0WU5zelgweGpDSC9LcG9qbXVyMnlSc3N4bVhX?= =?utf-8?B?Q1ZpU0NIcHp5SCtmb0h1Ti8vRnJuemlndFVITzZKdDRjVjFDZVlXK3FRTUtW?= =?utf-8?B?bVNNbDM4ZnlSRWcwUGRCZmZqMk8xYnR5LzlqcE5lNldtSFZnSmxPa29uVGQ0?= =?utf-8?B?OFduejhsTk9nY3NQTnpGVUsxQzk2Wjk3RTJmVERGaWcyV1VWNHk4MGVQQ1Rm?= =?utf-8?B?dVQ4dVNPYmc1MG1BdytybnJlbEt1TU1GZ2JEYTBvYVdKTENseU5QNzBiTzZp?= =?utf-8?B?NzBUNHNqWmRXWXBUeDE4R1p1SVBSOWFKeHNpVEVCK1kva2lQZDJma0x2V0Jp?= =?utf-8?B?eXNGQ0NOQk4vdUwyTm5MUUtYalVqWXVwL2RjTDNLQnZKWXFuMkF5b0s1US9M?= =?utf-8?Q?Zcaqv9+6oDAuNRYxOx56N1yvc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4bf2bc80-a71d-464a-60ca-08dac88518b5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 10:18:39.8810 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2PD7nsOss+DLJmDhhKC8wVXMzqS2g7uGMDJqa9Ip4KCUoQbBss+bg8WA5WaVxy9wRuTvMtrY+B5mJe02SwuVhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8207 On 17.11.2022 02:08, Andrew Cooper wrote: > The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: > > * All set_allocation() flavours have an overflow-before-widen bug when > calculating "sc->mb << (20 - PAGE_SHIFT)". > * All flavours have a granularity of 1M. This was tolerable when the size of > the pool could only be set at the same granularity, but is broken now that > ARM has a 16-page stopgap allocation in use. > * All get_allocation() flavours round up, and in particular turn 0 into 1, > meaning the get op returns junk before a successful set op. > * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, > despite the pool size being a domain property. > * Even the hypercall names are long-obsolete. > > Implement a better interface, which can be first used to unit test the > behaviour, and subsequently correct a broken implementation. The old > interface will be retired in due course. > > The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to > more easily support multiple page granularities. > > This is part of XSA-409 / CVE-2022-33747. While I'm not convinced of this attribution, ... > Signed-off-by: Andrew Cooper > Release-acked-by: Henry Wang Reviewed-by: Jan Beulich # hypervisor albeit with remarks: > --- a/xen/arch/x86/mm/paging.c > +++ b/xen/arch/x86/mm/paging.c > @@ -977,6 +977,49 @@ int __init paging_set_allocation(struct domain *d, unsigned int pages, > } > #endif > > +int arch_get_paging_mempool_size(struct domain *d, uint64_t *size) > +{ > + int rc; > + > + if ( is_pv_domain(d) ) /* TODO: Relax in due course */ > + return -EOPNOTSUPP; I guess this is merely for symmetry with ... > +int arch_set_paging_mempool_size(struct domain *d, uint64_t size) > +{ > + unsigned long pages = size >> PAGE_SHIFT; > + bool preempted = false; > + int rc; > + > + if ( is_pv_domain(d) ) /* TODO: Relax in due course */ > + return -EOPNOTSUPP; ... this, since otherwise "get" ought to be fine for PV? > @@ -946,6 +949,22 @@ struct xen_domctl_cacheflush { > xen_pfn_t start_pfn, nr_pfns; > }; > > +/* > + * XEN_DOMCTL_get_paging_mempool_size / XEN_DOMCTL_set_paging_mempool_size. > + * > + * Get or set the paging memory pool size. The size is in bytes. > + * > + * This is a dedicated pool of memory for Xen to use while managing the guest, > + * typically containing pagetables. As such, there is an implementation > + * specific minimum granularity. > + * > + * The set operation can fail mid-way through the request (e.g. Xen running > + * out of memory, no free memory to reclaim from the pool, etc.). > + */ > +struct xen_domctl_paging_mempool { > + uint64_aligned_t size; /* IN/OUT. Size in bytes. */ While likely people will correctly infer what is meant, strictly speaking this is wrong: The field is IN for "set" and OUT for "get". Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 17 10:20:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 10:20:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444898.700063 (Exim 4.92) (envelope-from ) id 1ovc0Q-0004Rw-HE; Thu, 17 Nov 2022 10:20:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444898.700063; Thu, 17 Nov 2022 10:20:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovc0Q-0004Rp-EM; Thu, 17 Nov 2022 10:20:26 +0000 Received: by outflank-mailman (input) for mailman id 444898; Thu, 17 Nov 2022 10:20:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovc0P-0004Rh-2H for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 10:20:25 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061f.outbound.protection.outlook.com [2a01:111:f400:7e1b::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 727f724b-6661-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 11:20:23 +0100 (CET) Received: from DB6P195CA0002.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::12) by AM0PR08MB5362.eurprd08.prod.outlook.com (2603:10a6:208:180::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8; Thu, 17 Nov 2022 10:20:12 +0000 Received: from DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::56) by DB6P195CA0002.outlook.office365.com (2603:10a6:4:cb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 10:20:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT060.mail.protection.outlook.com (100.127.142.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 10:20:12 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Thu, 17 Nov 2022 10:20:12 +0000 Received: from 35092e57e288.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F823479F-F2B8-45C5-AD00-4502E89A9DC5.1; Thu, 17 Nov 2022 10:20:04 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 35092e57e288.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 17 Nov 2022 10:20:04 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM8PR08MB6498.eurprd08.prod.outlook.com (2603:10a6:20b:364::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Thu, 17 Nov 2022 10:20:02 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5834.007; Thu, 17 Nov 2022 10:20:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 727f724b-6661-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9m0uTBehi+zPsqi5jId/NAKX92nGp2NMwLzNmZ+Girk=; b=z/3yToptXc7R0Sh1LDzsMjXXwr8dBz53fRWTOPDt66hlp/4rZkbydAmtdmZn/oCVLh7TMws7JUNVxFlDgzDJbh1RpzHkqWFqowu9RLn9FaODleav2n0xxN7T8ZC32Dfdtpkg6n6+2FRVr37Ugmxi6eG4+XLbCNRTx6Y5kwOEgc0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 98f4c26d21629d47 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ug54etEbZq3NDcVv1hD9ghug1hcmlXRAO6WxbxWUlaz1Bs6ggdwdThL/qmPopTqI0EeYMYWBJnl8KTyCGpH/Jqjb4jhUieNH5H4UEH5rpTfvDsL3OVud9KDlXQCpn42qhNgudx4E57y8HOi0jUlukR+xGSDCFB3KLdJ7cOU4vMIEIc2ERDIqwgsjlEh2mt5j8sdcr+ONgJTFX/pZRggRzY0fyNIL0RmPYxExK/xmXjZq1oEpZXR5sa1K5hOiFqNM8SbeJPwIwVCGY4MRXy6pyCWfb4OWqYs/jFn/wSNi21PuAxWVOJ08I2NpoUZGwu5CVBYSc06fAwK2OKgQuvlUvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9m0uTBehi+zPsqi5jId/NAKX92nGp2NMwLzNmZ+Girk=; b=hXdbd5bX6x6Ghn57+L6DQyb9/0qZkmeMrG3+nfB4fhgCrwT5Z/4pqg/SRWK00QXtZP21sjb8GtEdS27kbAcpG6P8/UXGdOibDBAR6jYTMLW1RAdQnoYXAx5oXgTyZnrqsN6txXgb7SpJCouqlCr9iIhh9MFxcmlspraMRD/lqhHm6HtbUGsOFqFH+0qrs9/yIJF+71924APqogq+4OzxigS6mj7v/dlD50Vs3+nl8tcgtOWATFGsjzDIBGYNHAv5Vd3+bIwvT9Hnh2PGCpahQIiqSutpjLpzVw76WEyg5BGKyzZGr0/rCrK6P0esXcm06ujCZFhvGBsCxb6C0xPKog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9m0uTBehi+zPsqi5jId/NAKX92nGp2NMwLzNmZ+Girk=; b=z/3yToptXc7R0Sh1LDzsMjXXwr8dBz53fRWTOPDt66hlp/4rZkbydAmtdmZn/oCVLh7TMws7JUNVxFlDgzDJbh1RpzHkqWFqowu9RLn9FaODleav2n0xxN7T8ZC32Dfdtpkg6n6+2FRVr37Ugmxi6eG4+XLbCNRTx6Y5kwOEgc0= From: Bertrand Marquis To: Julien Grall CC: Michal Orzel , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Thread-Topic: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Thread-Index: AQHY55A0LevsoY2L90OFIBLiUlnr6K5Av9+AgACVYoCAAF4AgIAAEeUAgAATsACAACQMgIAACNUAgADp3YCAAA96gIAABs2AgAAE/ACAAAJXAA== Date: Thu, 17 Nov 2022 10:20:02 +0000 Message-ID: <8AD88FC3-ABED-4B70-9DC5-351C265A7BD8@arm.com> References: <20221024100536.12874-1-michal.orzel@amd.com> <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> <0400b2d8-6f2c-6406-d966-64ed5720688c@xen.org> <350afafd-821c-1a05-13cb-1704d3a61bfc@amd.com> <84710d96-c473-fa41-d847-2b109dfb49c9@xen.org> <85f4f42b-b1ee-36bf-5ba9-21b1047351cf@amd.com> <7d3f9021-d608-9e8f-9593-1099d7bd2003@xen.org> <51fdb064-682e-b995-5171-ba23f75bc760@xen.org> In-Reply-To: <51fdb064-682e-b995-5171-ba23f75bc760@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AM8PR08MB6498:EE_|DBAEUR03FT060:EE_|AM0PR08MB5362:EE_ X-MS-Office365-Filtering-Correlation-Id: bf06b1ff-61cb-4b81-3fdb-08dac8854fd8 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3CreNUJQkFRpWcHdnZdD2xspd2p6+jX8SKhfrIh87zpa8d0++YT3QcQhKMmivRmA2LG4PeztXsugYs1tcQuZnXYtuaL6OeMj5POVIOdWrV2GrMTa00RCun7JG4J5flS6MM4LXnc3vzvBNlR/MkndhtGxgzQ/pPEnWGJIEBnaZB6DBcDfdmKJEyg9NVSsud7+WYj8yJzCGI/s8MLJaw4TND3MscyOzqA2JQyQnwbalWXxtIhZZ7LXaeKIWJDjH5BmP9/2t7TvI/YPIBG0/FvY0G7U1VDpvI4upEyjoQopcSFSh5gCpwbzs56K7SdBCN4a3dN7iT/Dc3C0Y6OZ9tlBNIBWEfoSK1ADvLk7Nh7y6QnFG5x9OEUL+HmU8n8Nbc87X9b3pGUfFDOiZr07KiU/D7KBKGLQHLbs7g1m56yyFgQuBIil3JPWTIuE1J0fwqusLgF7zYY25Nis6U2RceJJuPD8UO1WJbFevi9YAHvYakacsYCot6RhmINQGcJ5ECI+apxPEvW/5DtR8nCGqMlUqtFAX9sRuaSRqxfo9VUCCzO24V5RyA7rY7wL50WclXC6BpQZNGZFDKTQrgndX0vQWEW6nM7UdBOJ+eRWhYutf+yyVCJSqkgdXj0wld2PTc60ZDCcJq7YKfLJk7o0A9HYe7+N0iJMR8Ftv1GfD+ULwpct9oMzrQRE8d62GOHnwCTmbImWvvq9y8qEHx/OphQluHh5IdsM84IvBQ+K8JkVrosc+2MGrjkBbVJ4GYEkVeTj X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(39860400002)(396003)(376002)(136003)(451199015)(6486002)(6512007)(478600001)(966005)(2906002)(66899015)(71200400001)(26005)(53546011)(6506007)(41300700001)(91956017)(4326008)(8676002)(186003)(54906003)(122000001)(66946007)(66476007)(66446008)(66556008)(64756008)(76116006)(5660300002)(36756003)(6916009)(316002)(8936002)(83380400001)(33656002)(2616005)(86362001)(38070700005)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <5A9D79E7161A6F4ABAC0F27F271117E2@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6498 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ce837316-2af6-4014-0eef-08dac8854a09 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 713NHal0x8hrHnBc3OrLSI+KiR+jIZYfnH2NHGuj8ApVH5xFgRR2NsNg5YrKlVotpzuQd7CSQnbWzcEAskBatrcV4d/dTvWfe6RZuTy+oZtLPepprPjY+wkg+PpS6Id5aFSx4M4xVWmW3pEf/1L1Mt+EDIz5Gm4K34G9/rO80FWQktVROkGYXywPUVq4HRtwNvi/qZuEkvAxtyFMeMggHi8k1Mt0+vvC4PljlR7Ll7zMQYyJrliDn5vJYhzaRyPLg8GW/N4TGIcDgx8HZOLmlnmPIu2suHJdQaFXVZ4IVGNSQcz502sID5nJGaYWpz2qPqeqYOIIYnj/EuDskd8Yqoligtps2Ko3JoTJ86Oh98hZowgjnm+fMjCyTGAIG9w0hEOnQS4XE7KTUkinuNVB1TY4Uy1FDCgIQksV7Ygj7yhgN0MI1rTuAKt0Pm12RiFZGwT82w+YWfl8TTlsTrtOc+Yl/q1zhDcMkUFo5cJE8nXWjNWAoY42mGU0Y6/sTsiiWg2k9+uM/aLjkEpB71OtMl/c/CqK3hJKjmeOr+Oco//QKkh4iH/KMdHO8ohNtiPFSvayFhcqHVYxjRXwKwaRjVFQrv6VOQx3eUixF5UxW6GhaKeSCiA10hBQxx7wbeUKuyig9pMsN8Z0CKNb4goZDRhzbPTmW0nSbpvbhQakqIDG4kYB8WDYKIWNaWtKhaT3KKU9b2FnZNuW71NvCKrf0YPS9/di03KvHP9KE41K19c= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(107886003)(26005)(478600001)(66899015)(53546011)(6506007)(6512007)(186003)(336012)(2616005)(47076005)(54906003)(36756003)(316002)(8676002)(41300700001)(70586007)(40460700003)(83380400001)(4326008)(70206006)(6486002)(966005)(40480700001)(33656002)(8936002)(6862004)(2906002)(36860700001)(356005)(5660300002)(86362001)(81166007)(82740400003)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 10:20:12.1968 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bf06b1ff-61cb-4b81-3fdb-08dac8854fd8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5362 Hi Julien, > On 17 Nov 2022, at 10:11, Julien Grall wrote: >=20 > Hi, >=20 > On 17/11/2022 09:53, Michal Orzel wrote: >> On 17/11/2022 10:29, Julien Grall wrote: >>>=20 >>>=20 >>> On 17/11/2022 08:34, Michal Orzel wrote: >>>> Hi Julien, >>>>=20 >>>> On 16/11/2022 19:37, Julien Grall wrote: >>>>>=20 >>>>>=20 >>>>> Hi Michal, >>>>>=20 >>>>> On 16/11/2022 18:05, Michal Orzel wrote: >>>>>> On 16/11/2022 16:56, Julien Grall wrote: >>>>>>>=20 >>>>>>>=20 >>>>>>> On 16/11/2022 14:45, Michal Orzel wrote: >>>>>>>> Hi Julien, >>>>>>>=20 >>>>>>> Hi Michal, >>>>>>>=20 >>>>>>>>>=20 >>>>>>>>>> and use it in the pl011-debug files (+ there is a question wheth= er we should define WLEN_7-5 for completeness). >>>>>>>>>=20 >>>>>>>>> I would not define WLEN_7-5. That said, I wonder if we really nee= d to >>>>>>>>> set the baud rate & co here? >>>>>>>>>=20 >>>>>>>>> AFAICT the runtime driver never touch them. The reasoning is the >>>>>>>>> firmware is responsible to configure the serial. Therefore, I wou= ld >>>>>>>>> consider to drop the code (setting UARTCR might still be necessar= y). >>>>>>>> I do not really agree because the current behavior was done on pur= pose. >>>>>>>=20 >>>>>>> EARLY_UART_PL011_BAUD_RATE is only used for very early debugging (t= his >>>>>>> is protected by CONFIG_DEBUG and CONFIG_EXPERT). This is not a >>>>>>> production ready code. >>>>>> I am fully aware of it. I just found it useful but I understand the = global reasoning. >>>>>>=20 >>>>>>>=20 >>>>>>>> At the moment early_uart_init is called only if EARLY_UART_PL011_B= AUD_RATE is set to a value !=3D 0. >>>>>>>> This is done in order to have flexibility to either stick to what = firmware/bootloader configured or to change this >>>>>>>> configuration by specifying the EARLY_UART_PL011_BAUD_RATE (useful= when you do not know what >>>>>>>> the firmware configured). >>>>>>> The chances are that you want to use the baud rate that was configu= red >>>>>>> by the firmware. Otherwise, you would need to change the configurat= ion >>>>>>> of minicom (or whatever you used) to get proper output for the firm= ware >>>>>>> and then Xen. >>>>>>>=20 >>>>>>> Furthermore, as I wrote before, the runtime driver doesn't configur= e the >>>>>>> baud rate. This was removed in Xen 4.7 (see commit 2048e17ca9df >>>>>>> "drivers/pl011: Don't configure baudrate") because it was buggy and= this >>>>>>> code is not simple. >>>>>>>=20 >>>>>>> So it makes no sense to configure the baud rate when using early pr= intk >>>>>>> but not the runtime driver. >>>>>> Ok, so we will get rid of EARLY_UART_PL011_BAUD_RATE config and sett= ing the bd >>>>>> in the early uart code. Now, what about setting "8n1"? The runtime d= river sets them >>>>>> as well as the early code. It can also be set to a different value f= rom the firmware >>>>>> (unlikely but it can happen I think). In any case, if we decide to d= o what the runtime driver >>>>>> does, I reckon setting LCR_H should be kept in early code. >>>>>=20 >>>>> Good question. I think, you would end up with the same issue I mentio= ned >>>>> above if the firmware and Xen have different line control registers >>>>> (tools like minicom/screen would ask for it). >>>>>=20 >>>>> So I am on the fence here. In one way, it seems pointless keep it. Bu= t >>>>> on the other hand, Xen has always set it. So I have no data to prove >>>>> this will be fine everywhere. >>>> If we are relying on the firmware[1] to configure the baud rate, it is= not very wise >>>> not to rely on it to configure the LCR. Looking at the other serial dr= ivers in Xen, >>>> we have a real mismatch in what is being configured. Some of the drive= rs (omap, imx), >>>> apart from setting 8n1 also set the baud rate explicitly to 115200 and= almost all of them >>>> do set 8n1. In that case we will not benefit too much from fixing just= pl011. >>> It is not great that Xen hardcode the baud rate (I can't remember >>> whether there was a reason), but I don't think the consistency is >>> necessary here (see more below). >>>=20 >>>>=20 >>>> On the other hand, Xen follows the zImage/Image protocols for ARM [2] = which do not >>>> state that serial port initializing is something mandatory. This could= indicate that >>>> the firmware does not really need to configure the serial. >>>=20 >>> The firmware doesn't need to configure the serial and yes in theory Xen >>> should configure the baud rate and parity based on the firmware table. >>>=20 >>> However, this is a trade off between complexity and benefits. The patch >>> I mentioned earlier has been removed nearly 6 years ago and I haven't >>> seen anyone reporting any issues. >>>=20 >>> Hence why I think for the PL011 it is not worth looking [3] at the baud >>> rate and instead removing it completely in the early PL011 code as well= . >>>=20 >>> That said, if you feel strongly adding support for baud rate then I wil= l >>> be happy to review the patch. >> I'm not in favor of this approach either. That said, I will prepare patc= hes to remove >> CONFIG_EARLY_UART_PL011_BAUD_RATE and its usage in early printk code as = we agreed earlier. >> As for the LCR setting, I will keep it in early printk code to maintain = the same behavior as >> runtime driver who sets them. >>>=20 >>>>=20 >>>> [1] It is not stated anywhere in our docs. >>>=20 >>> Our docs are not perfect. Patches are welcomed for improvement. >>> Although, I think the statement should only be for driver where we don'= t >>> set the baud rate. For the others, we should leave it as is unless you >>> can prove this is not necessary (we don't want to break existing setup)= . >>>=20 >>>>=20 >>>> [2] BTW: our docs/misc/arm/booting contains invalid links to the kerne= l docs. I guess >>>> this wants to be fixed. >>>=20 >>> Patches are welcomed. >>>=20 >>> [3] I do have a large list of more critical bugs that I will be happy t= o >>> share if you are looking for improving Xen. >> That is cool and such list would be great for everyone having some spare= time (+ newcomers). >> Taking the opportunity of having a GitLab CI epics, I think it is worth = adding such work items here: >> https://gitlab.com/groups/xen-project/-/epics?state=3Dopened&page=3D1&so= rt=3Dstart_date_desc >=20 > I already have a Trello board I created a few years ago when I left Arm [= 1] with 30+ issues. I have another 30+ in my private board. >=20 > I can try to clean-up the one I have in my private board. But I will need= some help for transfer everything to gitlab. Do not hesitate to ping me if you want some help on that :-) Cheers Bertrand >=20 > Cheers, >=20 > [1] https://trello.com/invite/b/L54vXoqM/ATTI99c86a2718dec17b3b08f0de35fb= 3b5bC8729E45/xen >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Nov 17 10:23:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 10:23:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444905.700074 (Exim 4.92) (envelope-from ) id 1ovc3E-00056f-3v; Thu, 17 Nov 2022 10:23:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444905.700074; Thu, 17 Nov 2022 10:23:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovc3E-00056Y-0E; Thu, 17 Nov 2022 10:23:20 +0000 Received: by outflank-mailman (input) for mailman id 444905; Thu, 17 Nov 2022 10:23:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovc3C-00056O-Pd; Thu, 17 Nov 2022 10:23:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovc3C-0007bN-Lp; Thu, 17 Nov 2022 10:23:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovc3C-0001L2-9B; Thu, 17 Nov 2022 10:23:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovc3C-0000A2-8i; Thu, 17 Nov 2022 10:23:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mS0mK8kRWBhiY+ZQqviRN63m3rzPwFxnLZ6LriTdO8A=; b=cHMv29hhk460jJAHT2fJJOT6LX rrbhj6ppdAphWh94RtLXS35ZigkqqHIaGVeRxZZwz3ro0qIslr9gM1MMcPmXNkO082tlgm3YDqFsJ kfDXbxpYm4m5fV1R9T1mPokC4fPnyV7dwM5QoC0P+rc+Ka897/tVAn6YMNi6oX0KF8cQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174798: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=d5ae0cd17827e8d2b26b0165a46ab0ebe6d7ce21 X-Osstest-Versions-That: libvirt=cd94d891fb4b5cdda229f58b1dee261d5514082b From: osstest service owner Date: Thu, 17 Nov 2022 10:23:18 +0000 flight 174798 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174798/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174787 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174787 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174787 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt d5ae0cd17827e8d2b26b0165a46ab0ebe6d7ce21 baseline version: libvirt cd94d891fb4b5cdda229f58b1dee261d5514082b Last test of basis 174787 2022-11-16 04:18:54 Z 1 days Testing same since 174798 2022-11-17 04:18:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Eric Garver Erik Skultety Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git cd94d891fb..d5ae0cd178 d5ae0cd17827e8d2b26b0165a46ab0ebe6d7ce21 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Nov 17 10:23:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 10:23:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444909.700084 (Exim 4.92) (envelope-from ) id 1ovc3h-0005bM-Bc; Thu, 17 Nov 2022 10:23:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444909.700084; Thu, 17 Nov 2022 10:23:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovc3h-0005bF-8y; Thu, 17 Nov 2022 10:23:49 +0000 Received: by outflank-mailman (input) for mailman id 444909; Thu, 17 Nov 2022 10:23:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovc3g-0005aw-Hi for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 10:23:48 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea4f1cef-6661-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 11:23:46 +0100 (CET) Received: from mail-mw2nam10lp2104.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 Nov 2022 05:23:40 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM6PR03MB4924.namprd03.prod.outlook.com (2603:10b6:5:1f2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Thu, 17 Nov 2022 10:23:39 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Thu, 17 Nov 2022 10:23:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea4f1cef-6661-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668680626; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/syP4OBlaE71vp3weC4d9I7lEi/MilJAmugblPo3HyI=; b=AkFwB9V0XYjZ0XmOpNZ/RBScr6LDby9mg3ZSOBdzLWe4HP5W1QR2XJO0 shNYalbTSnIo77NHWCJKj7oA1CG9Fj81zy8sj9EsMSRAttmrJermCcBuc 6921mfvrB58t5WiGl0lOL64cPVa/eFRVnbS5PBAQ+CHyNBK7AC0T7KKDp A=; X-IronPort-RemoteIP: 104.47.55.104 X-IronPort-MID: 87555056 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:vDhWJqBUAFE5kRVW/w7iw5YqxClBgxIJ4kV8jS/XYbTApGhwgTYAn 2JMD2GFbvyCYGvzL9l1Oovi8E4Dv8DdydBmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpB4QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw/O8wAzxB+ NwjLg8hRUmkpb2s2ZS4Vbw57igjBJGD0II3nFhFlGmcKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+OxuuzS7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLVrS/x27eSw0sXXqotT4OG09RSg2fO11VUBDpRXAaAjuuQ3xvWt9V3b hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JPF8Uq5QfLzbDbiy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU331y1uPhTa7OCxQKHBYYyYBFFMB+4O6+N11iQ/TRNF+FqLzlsfyBTz73 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxloRiFKND2Bw1WXm0A== IronPort-HdrOrdr: A9a23:O2qQnam3Ia/S2j+MrFLyr2in10jpDfNMiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH7KGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu1Xh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboX0Twk6n7WXdrWrooMT/Sj5/I81dhbhBeh+cz0Y7ptlz3I 9Cwmrc7vNsfFv9tRW4w+KNewBhl0Kyr3ZnuekPj0ZHWY9bTLNKt4QQ8G5cDZ9FNiPn74IMFv VoEajnlb9rWGLfS0qcknhkwdSqUHh2NhCaQnIassjQ6DRSlGAR9Tps+OUv2lM7sL4tQZhN4O rJdo5ykqtVc8MQZaVhQM8cXMqeEAX2MFzxGVPXBW6iOLAMOnrLpZKyyq4y/vuWdJsBy4Z3sI jdUWlfqXU5dyvVeIKzNaVwg1DwqViGLHfQIpk03ek6hlS8fsumDcS7ciFuryP6yM9vR/EyWJ 6ISeBr6rHYXC/T8L1yrn3DsqlpWAcjufIuy6cGsnK107b2w97Rx5vmWceWAobROhAZfU66Kk c/fVHIVbZ9BwaQKzLFvCQ= X-IronPort-AV: E=Sophos;i="5.96,171,1665460800"; d="scan'208";a="87555056" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IgQsa86kYP4+MldEeS5qwXpnX9xp9SqsRJNh2WZvNDM+X8iyBrMsz31z6F+qvw0XkI7eYAEF9Lsbx+H8apJ36T5OHtl/JPci5hBkPkgT11YUJCURBYBsu5PCVK511LlLdermnfne0sERHPgNfXprsI3DB1XtjXyx5kwUbOzM8H6tQIn2XZxmx5UfzVpf2mxnD6Vq75JoV51riW2lnwlNXRUA2WN2m7KQJrZYxjwa1zgPHFdX7VQOQPVM4dZ5lYcmLKXXgQ0DkJKytferQs15/en43kCTXihEYwN2j4hsFuGuSTxyUSlA89+0/Me+8Alg/rxQS+7teraI4edsJuHmUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1+CUtBcibqspFiL78oEpMfHbMCUtnnB6OiY+vXqjO74=; b=mxDkyorFUT5ZNdYZulugGgKrEJMs0JOevLgGL2eL0IZYJNd++PTbt8+E/zm6OjGlX09SQgvHJvx+6liVhlswSBIzPpT5HMHc6+eRq6OzXbHot+1A2z7/yWw4FzpHcHDVPZKPLcZDjZmmTm98MKZLCPKeGU0Z2rf6yPS05yI6kruEOuHo8QREZWiD0byMGBPVLeqh5vF6d1ilkmbANwzFB5x7ClWyP6zxi4UvsOJqNw+85/wViPoxNXuirauyPpnbLZiht/8gsYpVzyfMBVdZnh6BXSS/q4O2pXtQMnri4nRASjtiJOcwOE57iifVn34u9D57Qi1R5s+7Q9x5/CvDgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1+CUtBcibqspFiL78oEpMfHbMCUtnnB6OiY+vXqjO74=; b=tDtzmRb+Mz2sR63WRCJm8TNlXp/FeAu14TFHapopXBgarL9Zi4UgyahIFHBdKht/pqNaudVd//34MywhUfvt+M9aTwTmaqlduvx2ncXpLdfU/GkTtrPILA4wHcaJWOJNceMyZidY+ijuYRPUM+xO/GbgGlBOlTVBuRgCrb2hTv8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 17 Nov 2022 11:23:32 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0 Message-ID: References: <20221116164216.7220-1-roger.pau@citrix.com> <9b559146-11d8-f848-d6fa-baed7e0fa06f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9b559146-11d8-f848-d6fa-baed7e0fa06f@suse.com> X-ClientProxiedBy: LO4P123CA0282.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::17) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB4924:EE_ X-MS-Office365-Filtering-Correlation-Id: 65d07453-69d5-4a47-9142-08dac885cae1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0uQW1Zz2ZOJfcR9rcgKu+FxqHfzczU/MDXBJ7FiFPm8UH+9zmmrOJhJZ1OAcquLDN6wlfW9XsEDTCbQZwnaJGTcXIGIFy+8gnaq16B1X97Uarx5TzGUSUXw0xuSAGQxwt02osJydd5PPU3T6Z+05tGeHwxpMA95uy9+ofz83HFrCa1z1g27U/hBfoAVZ+6ZRkdPrny2dwgtuimvCo+t5VNW0Q8TczEuBidiXj/yu2gwY64tn7tKUIPtbGbmocTm+Zg08/bfalHxiqvOwko4GA9nS3gFeeuxTlAcQCRY+P5/VO7Cya7S4Sq+Uykp1zKn8nGa69VdtycC0ibdGXJ7190NOPUkdOjEdWifwgL+HWJVBzZ9pM8reppOQMRj9hKJ4wz4Ml86X7VriKrFq0b0BOVfu63oAkViUtTNqgZ9byTt9bRSjilLzfKF9o+oV15zU8scqXi7fnHttEULHcggM9c6bbdZm5dHeVGKBExrAG0jwSrc4Rb+C54wiz7pIjLnAHQUr6mpi9+3J1Ab1ENaK0VGKu7vnPeEFautGFsjugpmrNbSogGkKpi/PV0Namf4xrO2l5l/HDs4Y7AD1RFH9UOEJQQ23eWa/CopwioHXJlWEPnGzDeHUXRXU/co6F6qE3lYdmnsYFllsx+r9bUQ9tA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(346002)(396003)(39860400002)(136003)(376002)(366004)(451199015)(82960400001)(2906002)(66476007)(8676002)(4326008)(38100700002)(5660300002)(8936002)(83380400001)(86362001)(66946007)(316002)(6916009)(186003)(54906003)(478600001)(85182001)(6486002)(33716001)(66556008)(41300700001)(9686003)(26005)(6666004)(6506007)(6512007)(53546011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3JqQVRqNUVaajhxam9LV3V2Q3F2dUpmd2ZqZEpwRWZxMldFemJQenNGeUQ5?= =?utf-8?B?YVlQZStaVlVHeXVRVkJJb0FHT3lIdGVlYU1TMldQQ3Vxb294SUc5K2xLQ2lw?= =?utf-8?B?eE9ycHhoVnRGc2IrWWE3ZDQxQU5zeUpNbmRGR1V6cE5GU2ZQRHdJd0lPMnAy?= =?utf-8?B?NG1tcXR4enBDS2w5NWZnbGgvTzNUZnJRaFFYcXFtTEViT1UwS0pzUkVXNW13?= =?utf-8?B?RUFjeVptdG1xU0N0bHl1djlNWXJpMjVtdFFESE5JQ0hWb3dKanNrc3VBRk82?= =?utf-8?B?NGQ0QzdwN1pPVzlSZzJLQTQwendtQmVCa0ZvbFdDTzVlVTN6SlpKVndWUmwx?= =?utf-8?B?azc4dHArMkJzZWJreU9lM0EydHdjWHpxa2ZCSW1XS1RxNUtJTFlIcU1iditM?= =?utf-8?B?RXN2UExtNmw4eEdzUGd6M2RMUlF2MHlycDV0M3RSdmw3UVZMWmZ2UFd4THJp?= =?utf-8?B?WXV0U1dJZmVKcE1CZFpwM0N5NGZSMy9BWnRPK0ZsTDBkYitHcGFyQ3EvU0lF?= =?utf-8?B?eUhQRGR2SUpJVmZHNHMwR01yYlRWZm94UmF1a0xSbVcxR1V4ZnpTV213U001?= =?utf-8?B?SzJ1NHVMREVldVplUVFHdmg4blBUZzhNSFpvV1pOUWt3Z2s5cTVuZWFQTVdq?= =?utf-8?B?bSt5L3ZycFVxWU93V1VVU2taL3VZZTZWQXpPY2dQdFplanhEcmc0L0ZIcDRX?= =?utf-8?B?Y1BuQlBkSXRja21sbGZLODNnbWN6Umx1WW9jdk0wTnJjcjJjTm5TL2Z4VjBs?= =?utf-8?B?U2NuT0VPMUZUbmVHSjlIZlY3aXJvZkxKNjQ2cGZoOHJQa0VIRHpaN09aMUVN?= =?utf-8?B?TVpFTEFVamhqTnh6R3BMOFNGZWNBd0M4cllYWllJZW02RGJuejAyWjFGVTEz?= =?utf-8?B?anZpNmhRVlZqUWJhTGFxY2t6MVhsZ3o3VWhWSzBmWEUwMndESnMxZ2pPUXE1?= =?utf-8?B?cjBaTWFoTEpFUGdkMXU1UnIxTklpNmRNTkNtMEptTlY3OXJBZmFrQ2pnSVJ5?= =?utf-8?B?VDM2UnlUMGdweGFpYXZpL2t0YlNrOUozVWNYNmFSSTFQQmMwYjdMR28ycVpI?= =?utf-8?B?VGs1anNmYUFsYjFhL3VlaDI4SjI5dXViWjBMdTdnbVBia0xUL21zNUZYRS9O?= =?utf-8?B?b1dTVzZ5WVg2eWJSbUtOWS9ZU1d3L1FDTmNsTGorUGthS3crUGVBZmNzSkoz?= =?utf-8?B?TFRwYnpEc3BWLytMNStzQ2pSVmJoaEtad3B0UTJPMVpReHpQN0l1NEhTZS8v?= =?utf-8?B?c1d0aTlkNFErUGxYak1FcXhWbGJNYWtvOUtWLzVHK0dqR3ZVZU4vYWNBR3dq?= =?utf-8?B?Y01yQ1JRY0hIRjY5VW9vbkdjVE9uSVlPL2pFWWVRMGtRZTdvZjFQaE1kMXc0?= =?utf-8?B?TnVpZnFyRFhZYzJhTmNINUhIV3o5b1J0WDRYRWxIUVpzNGlHVWFxdXFhSUpL?= =?utf-8?B?eWQ1WS9mRzV1NllYVHgvcS9lY1Z0YmRYbDNDOUZINE1jMHFGOHUvRnJwUjlN?= =?utf-8?B?R3UyUHRjRjFkNUUrTXNkSHh3N1ZUcHVHSmtxa1BGSmdpRXJkU2VlanN1NWlq?= =?utf-8?B?eWVnSHNlRFFpOGQ3Qy9GY1pBM0g5d2szWklFbVNpL2pwQUg3UllhdkwzWEpH?= =?utf-8?B?MG1tYlRnSnFEWGtCNVJ0eWF0R3lyU0VPb3ZPMEZ4bHY3bUs5RS9JUlpCbEV3?= =?utf-8?B?VjRTaVhNRnFXbVh2TkxOREZaMUREY05Ya0UvY05YeUJ2czUyQUorN3RCSmxH?= =?utf-8?B?SEoramt5dVVibVhKVmE1dUdDemVKYlErZGlqSWdpWG90ckxldnEwVktSSW5P?= =?utf-8?B?MFN3K2VMazBTOFdubGwydE9OVmxST3VYTnB6MHBrdkNSalVRYVZwUzAwaUNz?= =?utf-8?B?b1ZETXA5RTEyeU1lMlpxd3ZWeWxlMVBOMTcrUkhJWkxxTTZqZVkwWEppYXhx?= =?utf-8?B?c1AzTlFvYmIwSHFOSHNYYSs4T2M4eDAxb0gvTC8ySVAwTHdhaW5KTXJMcVRi?= =?utf-8?B?WkxPNnhwd3dpV2JORW1HMTdEbFFCRDY1R2xQOCtpN09FUklnR0U2akJKTk1Z?= =?utf-8?B?b2JES2FvRHhCR0grQUtjZ0tMUXNKNFgwSUhuUjdTV1FGWnVHaktFcVBVekZi?= =?utf-8?Q?ZbQUDhNu7G2nTZNnNWCL0aLEd?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2SJNE7WstJMEfbnZzgL0OTdniwSJ9RqibntxZilgez0q/PrNHUTdMCaWcIuAsY2sRUPsan0MNaDrS1J6+hbyN16rNzmWesdGQvpRXHJwtuv09v6AJhTtAMJ56/mNWYmStaHGmJl34dKMwe/i2vq83LSpXrj1htPSNTFHE5CUSbVxTjYFuDDI15bfIl/cKEDcNVFxoalCSgzrgeacz6PniSgNPyG8ocmohkc/VcTTUa1P79kC1oB8prYNKfQ2UrCZOk1X1Kc9Sv9uGaLqgYSVhWKJeWWhbll8MMXQVBZ8PSNidjjdH3Ys1sIWW4sjjhk3WEywtw1u/qNuhYDO6eeFYEB/nyt6xE3iVplSO9Leb4E5EetnIYKRfKaL3lj26eUW6dCYBF7c37r1VPgmIU1NB2skJGPYQ9MvHAIzycwrVvp0gx8IlXgRJL1kVb65qnsHzniZP2Ngf6w4jgfa7rKCDIIOPRBJw1okk1XBANMeQEaDedk084783mVMLXMm5aGAuTscHJeCnLmIPQtKpnRHGBw+jNSS9/JoBR2+JuQKqxO7XkhFFU7jTiN2IR7qjPt3rSttj16cpEEn0lsjrxVm6zPZVbAYsa6pq3e2Y/vOxStrHUUO0Pqm/SZLmCsYevtt1ta2FSbn5jJmDSSwTjYvU8B261o3leIhTk+nQZM7NjSv85u/EnpHyCRpIOVTrRsey2Bs/qouO+jIk58+4IraXlMOvcGXcYqce90oaPXmHNH3gnmGhrCEMOVPln8pyRS6NVYi55DAN+kbe3oxU3K8kjlro7eHabP3JkCSff5AOnM4CLtMHVXbtNVS74xQDhZt1lY3URBFP5Z8nr0MdyF4NA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65d07453-69d5-4a47-9142-08dac885cae1 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 10:23:38.9613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TudR5/+n6FN4JtQcVBjAS3p/YmWEgyjCETj3U+zUda/g3S2ypZQ5OAiIcceAEboK9lCd8475jQsqYIj9BaTRLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4924 On Thu, Nov 17, 2022 at 10:27:41AM +0100, Jan Beulich wrote: > On 16.11.2022 17:42, Roger Pau Monne wrote: > > Currently Xen will passthrough any Local APIC NMI Structure found in > > the native ACPI MADT table to a PVH dom0. This is wrong because PVH > > doesn't have access to the physical local APIC, and instead gets an > > emulated local APIC by Xen, that doesn't have the LINT0 or LINT1 > > pins wired to anything. Furthermore the ACPI Processor UIDs used in > > the APIC NMI Structures are likely to not match the ones generated by > > Xen for the Local x2APIC Structures, creating confusion to dom0. > > Plus we should have passed through Local x2APIC NMI Structures then as > well. Sadly this is not possible for PVH dom0, Linux will use the ACPI Processor UID as vCPU ID in hypercalls, so if the UIDs don't start at 0 and are sequential Linux will panic during boot because vCPU operations will fail. > > Fix this by removing the logic to passthrough the Local APIC NMI > > Structure for PVH dom0. > > > > Fixes: 1d74282c45 ('x86: setup PVHv2 Dom0 ACPI tables') > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Jan Beulich > albeit with the implied ack in there provisional upon Andrew accepting > your response to his reply. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Nov 17 10:39:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 10:39:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444918.700096 (Exim 4.92) (envelope-from ) id 1ovcJ5-0007NI-N6; Thu, 17 Nov 2022 10:39:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444918.700096; Thu, 17 Nov 2022 10:39:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovcJ5-0007NB-KN; Thu, 17 Nov 2022 10:39:43 +0000 Received: by outflank-mailman (input) for mailman id 444918; Thu, 17 Nov 2022 10:39:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovcJ4-0007N4-Of for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 10:39:43 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eae::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 22c97234-6664-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 11:39:39 +0100 (CET) Received: from BN0PR07CA0002.namprd07.prod.outlook.com (2603:10b6:408:141::17) by DS7PR12MB5789.namprd12.prod.outlook.com (2603:10b6:8:74::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Thu, 17 Nov 2022 10:39:36 +0000 Received: from BN8NAM11FT080.eop-nam11.prod.protection.outlook.com (2603:10b6:408:141:cafe::7b) by BN0PR07CA0002.outlook.office365.com (2603:10b6:408:141::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 10:39:35 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT080.mail.protection.outlook.com (10.13.176.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 10:39:35 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 04:39:32 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 17 Nov 2022 04:39:30 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22c97234-6664-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f6M7nKOofwzq5nVfbvEP5DuE0UFWlLMBIYPUm5YXw9l5Ca9jyqddkvSB9Xn+gPb5D7wqyHBGdOW4kUMdwpaiqc1S9jz+gqL67nybN4a2Ak5eUSo/0AJkUa6Gy1RMjn7JBwPxx5bC1GAacp7UgBS4DuuVBXEFnzkrmtpnsvJF+nwnDHKOhx9YaM6kkHYV29L9Gle4q/8anIIV4nSo8Px2puqp1D2B8B19NSMftYmcqJ+o+o4Wqi+GdttjzMtRZBvSRzuZj0BWL9xf3ihVGwJNBlJR5tv+pRAwvzhT/ARx88hpRZGk59PM/2VLo48KtgyMrsnMVFXzX+fn43B3qEy1CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LuxTjbKrXMrnKu2qwzdm1ntnv45oJ8eilotKOMhWu4w=; b=dnbzcQfPJZy+CLT5AJs3uNyg/oCEjZ0A6KT/Vyff9SwUotBOKuqI58A1ez2sF7v95zHBCL5RJ3z2gzpLcIT+NQXXEnXZrlObQBhnak6T83xW+OGUu5fMYLTeSOviEHbaKjY68sTOE+WIYVhlT4p1adTs+K/AgBmzJceZ9GGcNrg/ZC1SWaElz5T5dxMASL8tJtKGiQ7xdqFrkz7IfLmL83tYGzwV7iNY0XAWgzYgKAfWT2E9UKFqER2aB50SZUNOomC4Y2wrN70uyjAJofer1ycqf8pWiDooOkho/ad/taTYPie8UomsU4gD9tLPZt5yqsRGH3CKsyG1fBYyqd5XpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LuxTjbKrXMrnKu2qwzdm1ntnv45oJ8eilotKOMhWu4w=; b=ozE/jXXAXAoP0Bh1ITREVvsb2z83zAtMIdGYvZ+rTlPoxYGMXaFAaoLsoEeqLl2SBvFMIkrKUlODkAnOIQzPqjgnAyr7MZyOWob8BHHP91ws0b1c+RCFe7NhhajED5QTXnOjixXcwXA22fbL84O7pGCk3S0mrLUpAu5mgw3fMdQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <88a04b63-04ba-ef03-771d-1f2d11ea8549@amd.com> Date: Thu, 17 Nov 2022 11:39:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFC] docs/misra: List files in Xen originated from external sources Content-Language: en-US To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , References: <20221116092032.4423-1-michal.orzel@amd.com> <93736488-8e0c-282a-2e5f-db0cf9419183@suse.com> From: Michal Orzel In-Reply-To: <93736488-8e0c-282a-2e5f-db0cf9419183@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT080:EE_|DS7PR12MB5789:EE_ X-MS-Office365-Filtering-Correlation-Id: 73f70a25-e870-40de-b7bd-08dac888054b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LJQT75uVG6ngfcUQB7HLWsen93jD38hMrmz5eEGjmGt+iUVjgmwd7iD8LZP35ftVuoJlz7+9h/iOc85bi2pH7oR9RWziueinHTgC4dJmDQtVi583rHSiIcNB4btkWbplotPmq39Yg4N1JZmUFkrJT6SpC0mHdN8KSnIUQh9loWF22BJVCyircMjaUIyU3j0FfZitC4Jg5VWKEa/IWzFM6QU+CuPc2hGn1kxW10yf41trEYVyhS7hWfl+X4g++BgeqJJlddUG8F62L7nnrWB93D6vldRWCt/0yCf24BFu8WukedJ+S+eRshbD9FrZ5V5bVrbWdvpOFV1TYQgpIBHZJ/IuesivtZdhCsqnM4cLeezY4Lb0KfSetXRWVLf99XOF8DsPdGxnRFeQqNWdxTX8SiCuVGTEIPpcEEvqckXpurt4rAZwbkU1imWZtfH+/rwMcPhIa0kes86mgstbmyjJTb/R5D16sYsQeXsC9D5R0h7AzBFtuZXz+TYvd9A0xLO2Zl3gC/WJxCrqjgNn99QzvX0uxeyARPBdqvRhwWFmHUY6umVyN7SHDaKQ/+wuXSXjfkv058ehBMiasC5NXHLbZStftFwethZVHm2bvdNwsa1N57wabRQy5sSt+pNmQ+ow1S9qgFUwYCVcWy3EsOOQTkVBKdCPhCY1pGNC2AW056Sx0W8gTHBlDgMWIv3OzusSfLwaGKMzMjktmIaVZHRORiNsfpcsu5ivq414x959xaDDlVmiMT6uHhZfHmSPpHmTZPePty4RXbo8cxcFYeXsMQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199015)(40470700004)(36840700001)(46966006)(5660300002)(44832011)(40480700001)(31686004)(4326008)(41300700001)(70586007)(70206006)(16576012)(8676002)(316002)(6916009)(31696002)(83380400001)(54906003)(82310400005)(40460700003)(2906002)(478600001)(36756003)(356005)(86362001)(81166007)(82740400003)(426003)(186003)(53546011)(336012)(2616005)(8936002)(47076005)(26005)(36860700001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 10:39:35.5833 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73f70a25-e870-40de-b7bd-08dac888054b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT080.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5789 Hi Jan, Thanks for looking at it. On 17/11/2022 11:03, Jan Beulich wrote: > > > On 16.11.2022 10:20, Michal Orzel wrote: >> --- /dev/null >> +++ b/docs/misra/external-files.txt >> @@ -0,0 +1,70 @@ >> +External files in Xen >> +===================== >> + >> +The following table lists files present in the Xen codebase that originated >> +from external sources e.g. Linux kernel. The purpose of this table is to: >> + - keep track of the external files in the Xen codebase, >> + - help with the review process (e.g. changes done to the files that did not >> + diverge, shall be first submitted to the external projects and then >> + backported to Xen), >> + - act as a base for listing files to exclude from MISRA checkers. >> + >> +NOTES: >> +1) The files shall be listed in alphabetical order. > > But then you don't? True, it is alphabetical order with directories having a precedence. > >> +2) The origin of the files derived from the projects other than Linux, shall >> + be specified within the () placed next to the path. > > Might it be more generally useful to have another column, then not only > stating the project but also the path it lives at there (or lived at the > time of cloning)? We though about it. Would be a good idea but can be quite challenging for files that appeared in Xen before switching to git (difficult to establish the time of cloning in such cases). > >> +3) The table shall be updated when importing new files from external projects. >> +4) At the moment, only the source files are listed in the table. >> + >> +| Relative path to xen/ | Diverged from | Subject to | >> +| | origin? [Y/N] | backports? [Y/N] | >> ++-------------------------------------------+---------------+------------------+ >> +| arch/arm/arm64/cpufeature.c | N | Y | >> +| arch/arm/arm64/insn.c | N | Y | >> +| arch/arm/arm64/lib/find_next_bit.c | N | Y | >> +| arch/x86/acpi/boot.c | Y | ? | >> +| arch/x86/acpi/lib.c | ? | ? | > > This was simply split off from boot.c, which I'd be inclined to take to > mean Y in the "diverged" column. In the backports column I'd prefer to > keep ? for both, or any other indicator taken to mean "maybe / uncertain". > > What about arch/x86/acpi/cpufreq/* and other stuff in arch/x86/acpi/? > >> +| arch/x86/cpu/mcheck/mce-apei.c | N | Y | >> +| arch/x86/cpu/mcheck/non-fatal.c | ? | Y | > > Even before disappearing in 2.6.32 the file was different from Linux'es, > simply because we don't have anything like schedule_delayed_work(). So > it's pretty clearly Y for "diverged". > >> +| arch/x86/cpu/mtrr/* | Y | N | >> +| arch/x86/cpu/amd.c | Y | N | >> +| arch/x86/cpu/centaur.c | Y | N | >> +| arch/x86/cpu/common.c | Y | N | >> +| arch/x86/cpu/hygon.c | Y | N | >> +| arch/x86/cpu/intel_cacheinfo.c | Y | Y | >> +| arch/x86/cpu/intel.c | Y | N | >> +| arch/x86/cpu/mwait-idle.c | Y | Y | >> +| arch/x86/genapic/* | Y | N | >> +| arch/x86/x86_64/mmconf-fam10h.c | N | Y | >> +| arch/x86/dmi_scan.c | Y | ? | >> +| arch/x86/mpparse.c | Y | ? | > > Like above I'd like to keep ? (or alike) here, as neither Y nor N are > fully accurate. > >> +| arch/x86/srat.c | Y | N | > > What about common/cpu.c? > >> +| common/libfdt/* (libfdt) | N | Y | >> +| common/lz4/decompress.c | N | Y | >> +| common/ubsan/ubsan.c | Y | Y | >> +| common/xz/* | N | Y | >> +| common/zstd/* | N | Y | >> +| common/bitmap.c | N | Y | >> +| common/bunzip2.c | N | Y | >> +| common/earlycpio.c | N | Y | >> +| common/inflate.c | N | Y | > > What about common/notifier.c? > >> +| common/radix-tree.c | N | Y | > > What about common/rcupdate.c? (Stopping at this in this regard: > It's unclear by what criteria you have gone. Even as simple an > indicator as "Copyright (C) ... Linus Torvalds" was apparently not Please see [1] > used. Similarly mentioning criteria for considering a file > "diverged" would be very helpful to spell out, even if there's > likely some fuzziness involved there.) We would need to pre-define some criteria to avoid having a long justifications. Any ideas? > >> +| common/un*.c | N | Y | >> +| crypto/rijndael.c (OpenBSD) | N | Y | >> +| crypto/vmac.c (public domain) | N | Y | >> +| drivers/acpi/apei/* | N | Y | > > I'm not sure of the N here. > >> +| drivers/acpi/tables/* | N | Y | >> +| drivers/acpi/utilities/* | N | Y | >> +| drivers/acpi/hwregs.c | N | Y | >> +| drivers/acpi/numa.c | ? | Y | > > Y > >> +| drivers/acpi/osl.c | Y | Y | >> +| drivers/acpi/reboot.c | N | Y | >> +| drivers/acpi/tables.c | ? | Y | > > Y > > What about drivers/cpufreq/*, drivers/char/ehci-dbgp.c, > drivers/char/xhci-dbc.c, and drivers/video/font*? What about some of > the stuff under tools/, especially tools/kconfig/? [1] For the first shot, the criteria was to list files using different coding style than Xen, especially the ones using tabs instead of spaces. As I indicated before, the list may not be completed, hence a gentle ask to list the missing ones. Some of the files you mentioned use Xen coding style + there is no information in the git history that they originated from external sources. This is why, the maintainers who are the addressee of this RFC should have a better knowledge of the origin of such files. As for the files under tools/, FWICS they are being filtered-out from MISRA checks, hence I did not list them. > > Jan ~Michal From xen-devel-bounces@lists.xenproject.org Thu Nov 17 10:40:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 10:40:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444923.700111 (Exim 4.92) (envelope-from ) id 1ovcJQ-0008FX-6J; Thu, 17 Nov 2022 10:40:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444923.700111; Thu, 17 Nov 2022 10:40:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovcJQ-0008Eg-1j; Thu, 17 Nov 2022 10:40:04 +0000 Received: by outflank-mailman (input) for mailman id 444923; Thu, 17 Nov 2022 10:40:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovcJO-0007ch-RS for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 10:40:02 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0611.outbound.protection.outlook.com [2a01:111:f400:fe0c::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3020b5c8-6664-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 11:40:01 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8521.eurprd04.prod.outlook.com (2603:10a6:20b:430::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 10:39:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 10:39:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3020b5c8-6664-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cH++qI5O/3vot6Izply7klumLRLgqkT7n1aWmg0OD3MSCuYSkKZRp711TV/VnLOPPznvDQwVh1ofA6FG1mbdob4Bw3ZXHh26QA2e/fczz60msnT+noUKkHCjY/NoGOAvT4BzcKI/xD0NmdB/Uy0kdc9/yOVTL/NBGjAVJyP7PoayBvDoKOVgH2poRTR7oqegn4AZEcakcW8DyS4tb5qIkbCB8Z3LONI26+xtks0uo7hxrcPPV5KRlovAkEsyqIi3+w9oKL+/G2IgffYL5J9eNb8McGktkVXkCoVHA/CIihH0Ndybea0RCgQMmfwLa1G9ZZCbf378jOE5mFR4XbNi5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hAvRLOg6w4mmvcA3i5mjaJkjOWFpZznd38q0eTok1IY=; b=lhEJCBuMQKa1TiZg68Z3R/bpzCkS7JCbMp/3ifNmRa0sIp7xyFXk/rNR3hTl6n24xFjoLSYE7jEA3ddkBEzBH6ZUqyfrs9FlqhujliwC6ei9vorcuMy/FcHWoIiqlK++bRAt9e4YFtVieWSGtherNtDVcfHfbQXLX11v+LbcZg9yIhvUvFIXXud+OsKtIVojccOTWJqkrBEySwfZ+WuSpNK1JZF8Hx9HLGvSiFxmzvq0bkPqJdu6rVQzskqQBZwIPUiG4ozXpH7QkeTPgf+lgbGPJJfTWlW4AwBvqVDPbSc1ifWt3cQOr+oaWHU6wmx0Ytmtt9/XddeGqrBbGcS/aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hAvRLOg6w4mmvcA3i5mjaJkjOWFpZznd38q0eTok1IY=; b=C8DOqCVOmBCx7vHxkiEpqJZdpYO/L4zRID4ENg4AsTyBwMOkEWb/RpYMqKQFYJfLIT+IFhnLTXB0XwU5UWZX2CBzwWemAQjjZBVVkWIUpuPObmT8J6KlNe8Mqv4VnnCi4H8VkirrQl6wVurSRIUpwErsYwjpwGHjNciU1CrJmtqWXRBX4m6MS0k2qzq57aFbgCGJWUXo2rQaRXws+w71Qay0EggCCR0mMYzc3tYTnDK/DNu/51fiYGE9IeISncPMHQpMpXcn0qUoLiP3bzkKLz0O9V6lToQ3K3yY7JokA2UBoDJ6Y2f19n4mPnMJQOYzKtvMRRR4lAd8AEtRKPkJRQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3ede581f-3393-9290-b929-6c28450b007a@suse.com> Date: Thu, 17 Nov 2022 11:39:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/4] tools/tests: Unit test for paging mempool size Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony PERARD , Xen-devel References: <20221117010804.9384-1-andrew.cooper3@citrix.com> <20221117010804.9384-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20221117010804.9384-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0105.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8521:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e399993-647f-45b5-b373-08dac8881375 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RADNTdcV35PJIMTQANJgaAbrGVaR9Lwc77yYKy9rlDNM+m7niwzMtKIxhM1e3VQf8q62NTcUHMI8IoILFb5CSVs8UvxGjQ2+1ha+ShoUnxUFu7ZH67qVf8Fv1abHuo6Z4pSBsFbzJuAOrhj6q8bb2Iy0z8q85QyQZfQwklfzEecZzOQSmnUwhhjC6JhcfEoCpRx90nFvl7JRXvU54gJwRvD+0hRN4zc3NztQGlrGzo0qVc5cxPcYQo8ckDIBa8HXm3XKTCvvaOM8QaGVmFrq9Zu/bsqnbOSK0p7bBXc+AgVkJIBHi3pJjTBgWtE7Z6gR3NHtlhMYlOoygk0TmgevGCwkrvsCfRzRJzPXOMvX7y8s+PGvIm0kXMC6qpiyDBlP1AxtE4/52h2WD9rP+Zb70kGmCFQBC3+0iHOPLfcyR2o0x2cCH0Juo3gIqF460bPTWg7mtZvemqyzKqRGTMr2I3+Ma6loh8va9HHNdnLUXGwOQpAJ7goqPDZp+qcbFEVffZ075xkFLTb5UbCuvsJuWo2F5GACmWcdMb9aCdjAeOU94ocBMwF3VUMMMuVFdP6+m5sEjys697aV+ZvFlIktTOJl2S5drvgkXsjAvmwyOe2pLB8tBptdpm16IOeqOkpFSKrLPvLOeQQk5nRhIIr2ALBi9BEWSfIMUfxu3vtRAzx0JGonEoJJzuAfU8xhfWXaPzbTDi29SsOu01IbAr1ekc7edZjK3+nShK9BDEjnmkg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(376002)(396003)(136003)(366004)(451199015)(478600001)(54906003)(6486002)(6916009)(8676002)(83380400001)(31686004)(38100700002)(26005)(66946007)(66476007)(66556008)(86362001)(41300700001)(36756003)(6506007)(186003)(8936002)(5660300002)(53546011)(2616005)(7416002)(6512007)(316002)(2906002)(31696002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlFmcXVZV2hnODRROXBJMkJ2RW9kellwK3ZSWFJSTUt3TTQ3OFhUeHhzMUk5?= =?utf-8?B?ODJGR1BTOXU2VThmMlljWkNhYTNhUmlmRnRUb3dBdGVZQzJpVEtTaVNmYldK?= =?utf-8?B?NGNxQndod0F1M2xhY1E0bE1pQ2lCczhLbkFnbUpXSkZxVTVGVzc2bkNnYnBZ?= =?utf-8?B?OWpmaVAzcEJXVjdGNjZMM3A0RTd2OE4yN3l3K0F3b0R0dUNMTkswd2pTdWhD?= =?utf-8?B?aDRKYmtGRzBFWHlsWlhwbVpGUFNzTFR5cmloQzRXeGxrUVpuYlBYYVQvSWU1?= =?utf-8?B?L2JJUm1tTStVamUxcHZRWGRRK1J3YzRlZEdHQVY1aHNoRmdoVGJKTjNqaU5a?= =?utf-8?B?SXZmc2o5RjNkenp6MHhOZ3pKYzBpekJyRUp3U0tCeDRYODlNVXN2VEIvM0Zl?= =?utf-8?B?eDJwMXdDeGFldWRFdW53a1hLQmQvUzVIVDk2cWltOXQvdjErZTJMcDhmK0tL?= =?utf-8?B?UHNOQ1R4MDN4UTBjZmxMTFNnOExCbFRpYU5XOTVKVzRyRkthbGozWmdEWWxG?= =?utf-8?B?ZHJkNzFHdVpJeDdjVkJIbmY4M1NqamY4RGRZcndqMVJhQ2o3ZTB6Y1JaQnQ5?= =?utf-8?B?NFd5MG84R1d0bDBpYW5oRm9oajRUTjFUN3kvSnRaUGJzZEVsUVZXNThqdEdP?= =?utf-8?B?L1FwYzZDTENRdDlUVFZRQ0xHU2VmQ2xaYlRyZzB6c1F1dnhNZkVDWWF0WWV2?= =?utf-8?B?OGpwU3hXKzAvNUFUZ2pmY1daTHJWNDJzNVZENVZEcFRWVlMxajF5eFFqMXpl?= =?utf-8?B?R1pmNUl0U1FNakxaWUw0UTFvMTdlQ2tWU3ZPWHltTlk5VmQ2QXZGTC9oVTBx?= =?utf-8?B?UXNUb2N1QVo2ckp1TXJmWEI2L0NNanhJUThSYXZFek1EWjJoQmFiQm11TWFP?= =?utf-8?B?eGZqaDVadjB1eGxhL2NWaGJYb21VSnFFS21seGczVGxTYUVlS0prL0pSVjRO?= =?utf-8?B?Sko1Z0V6S1NBTTBJYnJJanYyYzZMYURLbjhwT1Y5SlFMaUI1UzNvSGJVRkNo?= =?utf-8?B?bHZZSnRQK2ZaMTZMTDJNcCtxZ1ZhSDZtdjZrcHIxd1J1a2FES3ZmZEg5SjdG?= =?utf-8?B?TUxMamtWcFNRcjZPM1lvNTgyK3o5MnNuckZGK2o1ZnNManhpV004SFlheE9s?= =?utf-8?B?R001dG1hOUdpaVY3Wi9Fb0JLMExXUTUyQlVCV1kxN290SGZUWTlXZUgwVjc3?= =?utf-8?B?L0ZuQ3hXNURZUDVESzRPVS9CNHFPalMxRWZuK0NYOUQ1d3NPSW5zRnM3UWVi?= =?utf-8?B?cC9JcFZQWUhsNXlSMXVrTU5xZ1VwV1BmMkhvYXliZTVpUS90bUkrOFhRQVkr?= =?utf-8?B?WUZ1bTF4ODV0cXZIWjhhSjYvMDRvZmVUZGlXc3RCL2dheC95VXJzdml2Mkw4?= =?utf-8?B?TGVxV3N4bTE2bENLOXQxWFYvVTdqR2tyTXpqYmplNGJhOXhtNEtzQ2ZOTjhs?= =?utf-8?B?TTVVSFZiaVpHSU5FaWJtVnZtclZaSW1idElTYmtZVk1HREQxRVc2ekdHMWpY?= =?utf-8?B?VU5mWmhrZHF2bWZWdEZiS1VKUWFXcVJ0bXlyZDhKT2tnRmlGektmUk4reWwz?= =?utf-8?B?amVSR2pCWW8vTHI5cTRLWG5TV3I3RmxhM2diVHFYQ05LSXk2UHN4ZEFmMW55?= =?utf-8?B?aHVBUFBPVHpMdk1pOXhBL1ZnK3c2RlJxN1U2ZGt0R1YrTXRqNEt3QjJNbGo2?= =?utf-8?B?MXIwMEpVZlluNUpKMjg3bWJKMVFaSVgvdktjZkdPU25qZ1d2dlpsNi9oTnNO?= =?utf-8?B?VVhhS2c2UDV5TkRrRHp5NFdlamVya1VNdjhxUHlYa05RMzd4dE1ycHpxMjJ0?= =?utf-8?B?S2M3THh4OFFyYUt6VVBWRjNCdEZkamppa3hjaC9CUnMxSVNRRjk5N0ZvQ241?= =?utf-8?B?bUwwWWkyQ3VHaDFrK3I1OERUUTZBOFFLeXJwTGkvQ3U1NzRoN3AzeWQ4TnNq?= =?utf-8?B?VU13VWhRcWQ5VXJ3SWUyN1VGbngzb0JGalhBczgxbFpLZmNWMGU1TTFjM2Y3?= =?utf-8?B?cEZFeCt4UDg0ME1DMFQ1ZEVrcHpiU1FIaXRRV1FmYTNXdGF4SXpPZHZmNGtR?= =?utf-8?B?MEVWbVBlMmtuV0VERGV6bWtXMzIzOXI4TENFaDA0am5QZ1M2QXRkbkFlbDlR?= =?utf-8?Q?VoSo94HLYTOssHBf+DAmmMj/K?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e399993-647f-45b5-b373-08dac8881375 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 10:39:59.5028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eCjKLREaanEjHGe5G5FvL5q+gvitjeiPN21fOTgFp8+YgEeozsXgzwRQtQlpyCkS/uuG4LOR7TQ0LX0bI/qGIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8521 On 17.11.2022 02:08, Andrew Cooper wrote: > Exercise some basic functionality of the new > xc_{get,set}_paging_mempool_size() hypercalls. > > This passes on x86, but fails currently on ARM. ARM will be fixed up in > future patches. > > This is part of XSA-409 / CVE-2022-33747. > > Signed-off-by: Andrew Cooper > Release-acked-by: Henry Wang Acked-by: Jan Beulich (if this counts anything, since as it stands the new stuff all falls under tool stack maintainership) > --- /dev/null > +++ b/tools/tests/paging-mempool/test-paging-mempool.c > @@ -0,0 +1,181 @@ > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > + > +static unsigned int nr_failures; > +#define fail(fmt, ...) \ > +({ \ > + nr_failures++; \ > + (void)printf(fmt, ##__VA_ARGS__); \ > +}) > + > +static xc_interface *xch; > +static uint32_t domid; > + > +static struct xen_domctl_createdomain create = { > + .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, I understand that it is accepted that this test will thus fail when run on HAP-incapable hardware (including when run with Xen itself running on top of another hypervisor not surfacing HAP capabilities)? Oh, I notice you're actually translating EINVAL and EOPNOTSUPP failures into "skip". That'll probably do, albeit personally I consider skipping when EINVAL (which we use all over the place) as a overly relaxed. > +static void run_tests(void) > +{ > + xen_pfn_t physmap[] = { 0 }; I have to admit that I'm uncertain whether Arm (or other architectures that Xen is being planned to be ported to) have constraints which may cause populating of GFN 0 to fail. > + uint64_t size_bytes, old_size_bytes; > + int rc; > + > + printf("Test default mempool size\n"); > + > + rc = xc_get_paging_mempool_size(xch, domid, &size_bytes); > + if ( rc ) > + return fail(" Fail: get mempool size: %d - %s\n", > + errno, strerror(errno)); > + > + printf("mempool size %"PRIu64" bytes (%"PRIu64"kB, %"PRIu64"MB)\n", > + size_bytes, size_bytes >> 10, size_bytes >> 20); > + > + > + /* > + * Check that the domain has the expected default allocation size. This > + * will fail if the logic in Xen is altered without an equivelent Nit: equivalent > + * adjustment here. > + */ > + if ( size_bytes != default_mempool_size_bytes ) > + return fail(" Fail: size %"PRIu64" != expected size %"PRIu64"\n", > + size_bytes, default_mempool_size_bytes); > + > + > + printf("Test that allocate doesn't alter pool size\n"); > + > + /* > + * Populate the domain with some RAM. This will cause more of the mempool > + * to be used. > + */ > + old_size_bytes = size_bytes; > + > + rc = xc_domain_setmaxmem(xch, domid, -1); > + if ( rc ) > + return fail(" Fail: setmaxmem: : %d - %s\n", > + errno, strerror(errno)); > + > + rc = xc_domain_populate_physmap_exact(xch, domid, 1, 0, 0, physmap); > + if ( rc ) > + return fail(" Fail: populate physmap: %d - %s\n", > + errno, strerror(errno)); > + > + /* > + * Re-get the p2m size. Should not have changed as a consequence of > + * populate physmap. > + */ > + rc = xc_get_paging_mempool_size(xch, domid, &size_bytes); > + if ( rc ) > + return fail(" Fail: get mempool size: %d - %s\n", > + errno, strerror(errno)); > + > + if ( old_size_bytes != size_bytes ) > + return fail(" Fail: mempool size changed %"PRIu64" => %"PRIu64"\n", > + old_size_bytes, size_bytes); > + > + > + > + printf("Test bad set size\n"); > + > + /* > + * Check that setting a non-page size results in failure. > + */ > + rc = xc_set_paging_mempool_size(xch, domid, size_bytes + 1); > + if ( rc != -1 || errno != EINVAL ) > + return fail(" Fail: Bad set size: expected -1/EINVAL, got %d/%d - %s\n", > + rc, errno, strerror(errno)); > + > + > + printf("Test very large set size\n"); Maybe drop "very", as 64M isn't all that much (and would, in particular, not expose any 32-bit truncation issues)? Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 17 11:00:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 11:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444937.700122 (Exim 4.92) (envelope-from ) id 1ovcdC-0003HQ-LN; Thu, 17 Nov 2022 11:00:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444937.700122; Thu, 17 Nov 2022 11:00:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovcdC-0003HJ-Hb; Thu, 17 Nov 2022 11:00:30 +0000 Received: by outflank-mailman (input) for mailman id 444937; Thu, 17 Nov 2022 11:00:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovcdB-0003HC-0Z for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 11:00:29 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060c.outbound.protection.outlook.com [2a01:111:f400:fe0e::60c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0af55324-6667-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 12:00:27 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7169.eurprd04.prod.outlook.com (2603:10a6:208:19a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 11:00:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 11:00:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0af55324-6667-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z9yhTOWOm0bVfgWe5GH3eyM4Zj7xnTvROdy2+FNMdeVwdt3gRgZzm7CWu3KCceHvx1lMDr5+aXW/zFKxXK1vHMrReuvjzMKX5GSZYl+NZ50CZ1RxMgSih4IgynhHGCzDyN2mnjG95/fjq9G2/8m1D6DTgqJ1MXw2bO/oTWdllDb3X6ROTHDYWsPKZ9oqiLDEtLJ9mTjrbohj/vtgS7r6L5iIxK55XVsEflEQSzFzEXXgBYkBMu3btRv9mc6YB9Lym3kKUuFS3Idl9ox8NodHBZ2lYS3x+xwJrGtXsb2m0Xh7Y8kf0dXvKywx8hyShLj3rs9e69aZ9pgCf72J3E49wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jasQHcIxN6EHMhwqWyfdrKJiQeUrsfV8YGhcHfUEZzc=; b=jQPkXT/9l7uAkrDi/g7+D5HWchXSF9k55UgAk9T/BJ1y0mDo/KDijvi/BsgrG5HmOh1wYxjH8ZJ1I0SR6MJxYkulVCdK6gE9yH74Z8eupFjal7cnWuKymrhB7tVxuuYSZjSxfPbCc8TOgcbCEWDs/qxNSzwoE3Zug+/9YMasdu/HLXVC8XZ6V4VRyVVqJC5HhSZ6tlX7XNXjNwY7WhQjgbFDyQbgXSP/2awdF0wwADUSVuX4fndU3H7CQZezEA6QtxsIsw21CGKpIGe36j+bMQmaNQqQ2MivHsVihD0rfAW9qov6hlKZNtC7K3hkEf3rseIBZ6pNCqDHNIFBLVnYbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jasQHcIxN6EHMhwqWyfdrKJiQeUrsfV8YGhcHfUEZzc=; b=Wq/DTmWU3tEGIFni7ZLgqdELAhrTReT1GD2Y5sw4T0RSvjGfHOdD2tiAWUzR/ExaA9JNUFkGOsKFNAIEjGOWHujpxKyPyNLrmy5ojA7sfQIGcsArpsRFDMHAqHC1pXVWFRrjBNEVwqiEsifvcEqaLN2bx7eqIbGzs3UFj7dYk+Qe80MYotV2qap7qydQ3JrzGMlhVREzua6mZZEov4NrD1slqueD0bNHX9ak1rLMiaiV0uiiZh4XZqpG3jBZczfld4H9DOcspvCPnwib04MfIUD4SOhEX7sPCY2wmrfTpXVckC8zndwUG7pvBwWmmdfNmi7lD7avB/vDXSq40QXhUQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 17 Nov 2022 12:00:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFC] docs/misra: List files in Xen originated from external sources Content-Language: en-US To: Michal Orzel Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20221116092032.4423-1-michal.orzel@amd.com> <93736488-8e0c-282a-2e5f-db0cf9419183@suse.com> <88a04b63-04ba-ef03-771d-1f2d11ea8549@amd.com> From: Jan Beulich In-Reply-To: <88a04b63-04ba-ef03-771d-1f2d11ea8549@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0055.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7169:EE_ X-MS-Office365-Filtering-Correlation-Id: de9bac01-a9a6-4ec1-94df-08dac88aedec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vh+whbaI/j0SZkeruhHiaYCO7yZcSJ558+tv/TkDEwHOYjCM7QXFEc9C5wfwukVR4/GkESvqcSiYdNMValoobh2atnomNQjPX7Q/6qDX9DhDnTCpxx5+eTQPFwK5rUdHp7lbWIOlxY/aaLKiBzWzeZQXu6iOwR3knd5OXnp+CT73tnQiTw6hdKJNlNJGdL7M1Q3wDi6AwLLba+8JyPr3BH4k3Xjyj7mz1T/8rkEpW0E+URNweKlfyzRIuUKZBciB32P/bH+CAXokVVcLtDMhl1kD90AeuM3pRQ2GTlPp7Xr25I5AbKHBc5axtnOTq34sc7xte/uIT8Lo9cwBGvoOiAO6BxmXqydgGP81A6nhTHgSX31qww9RoBpldl6JjUQtZKP+Bu8LYtmvtIReyfyqIr612Q/XWpcZHGckr/abeb21ruZdJ4kJLIfKr6QXVi+kXCLnva/dp3w5kMz7euQtYZmlEtF767Wg10ZEyHc4xQhaymrHnFTD5MDN5qf8zQNkZrGz4c89aOXjo3EPHPYQ7dwITB10dBABvquGohRKhfo596jhwOBozRLCYOvNnlMqn5ohraqYNkhaxdYpav7IuNJjRmd3ZdoOGMtIwA5JXl+wr1ukBSxeiebMrhhZlxrY27Zw41cv6dNZw//FlZbtIGTtTkBBwfmui2vvhbsly2gsE/FoHQdXTFhr3ntXRg4XG8QgPuBN2r2b9VrbbYWRlNfkWq452JZFVMcSX4DsV24= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(39860400002)(366004)(376002)(346002)(451199015)(31686004)(2906002)(66556008)(5660300002)(66476007)(41300700001)(8936002)(83380400001)(31696002)(4326008)(8676002)(86362001)(66946007)(316002)(2616005)(6916009)(54906003)(36756003)(186003)(26005)(6512007)(38100700002)(6486002)(6506007)(478600001)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MndIaE5pSlU1bXBoSFhFdlhzd3c2cC9Ic1UrVXA2OFE2ODVaUGZrNnpKeGVk?= =?utf-8?B?THBiRjRKR0hIQlJkenhzbWZyclo3Z1g5ODJLRHVpSGZqeHBGNEhleFZSaHVa?= =?utf-8?B?RTlQYUZWTFdRaVRyWmxWMDl2NDNDSTlBeEF6a2MxZXBTZVlVeUdYZlR3L1ht?= =?utf-8?B?bnh4K1VYSjR6NXFmT3I3WHVkWHAxTzA3K29neWlYZElwSnhsZ0Y5ODJJL2JP?= =?utf-8?B?OWovNEpwZWc2am5MUHZ3NGVaVHFoczU1ZmNndHk5UkdmRnpWd3hJRHlsUG1H?= =?utf-8?B?dFJaa1dESnE3U1ZpeGZEbHhlZlJPY284aTJueDdhQldVc1hVYy9ZdjgrZktk?= =?utf-8?B?UHphS1QzblJKVjg4Z1FNamZUS2xWTGIyeDNqYytna05Rand1c2dmUmN2SEV1?= =?utf-8?B?aDNlcENGL3hUT05Xd3VReVc5OXdIYXUyUldtdHR0L3YxaGo3UG9icFFqQmVJ?= =?utf-8?B?ZjhuZFowUlNpazZGaE02cnpicGtsc0c4WVQ1YWdnRnRkN1dGQmZzSHYwUUxM?= =?utf-8?B?bzdEMEl1RnN0Z2o2akZua3RkdXZhRm5aajlaS004bi9ISWtUeTdaZnZZT0Vo?= =?utf-8?B?Y3JiUHkySldsWGNZZkFkcnRqK2RhTytVTENoaEkrVWNXTzRLRXB4Qi83R3cx?= =?utf-8?B?NHFQMm9tMTRqalQ5TEZTdlhPOHZGeHY3QTdOdm5VNUc4ZFFLNW4yUk81a2ow?= =?utf-8?B?T1dsVWVDd0dIQU9DeDRkaXNFZjkwSUZzS2paK2lrcmovU251ekNwQmVWRGdV?= =?utf-8?B?Qyt6YTdJekR0T0xsdmdRTmF6d2RQbm4vTGg2a0szYWZ3SWRyY2pLRFdDYyts?= =?utf-8?B?MWc2c0J6RzJtd044QWJjQWNtTC9iOFdETW5ZQjVYbFBUN3hSZHIzb0lSajZI?= =?utf-8?B?bWFneml6ZEp2bk9TQ1oxZ3crZUJSM2ZuNEwrL0F1RUl3RUdmbmUzT0pQWUpK?= =?utf-8?B?WlV2N00rN1FQQjJoZ0U2eXgyYlp4Y0dUNUkrV1pQZmhBeTlIdUVab0ExQjVB?= =?utf-8?B?WUhwVmZjMWJlWFZMdERIOU5oZmg0VUdxeVZHVXF2Z1lTbitHUGRnblZ0ZExO?= =?utf-8?B?dlV0TnJmNHJjTC9IZmVBTDBvMGVqTnpYa2g5OHkzc0NaTk1VWWc4MXNNRG9I?= =?utf-8?B?WTd0bW9tSXFHTmtHQTNLU0IzTmp2WFZuNS9RaVRtV01xR080WVFwUmJCU0I5?= =?utf-8?B?c09uRW5SVjNNMGUreHl4MzF0WWU5dFFZanNKNEZEaXJxNVhnQllSSE5OZ0NL?= =?utf-8?B?TTg4aUdpNERxMm1lZHhCWmxBV2NOTUdvWXJsRzY5MW84Z0ZDalZOaGZaMWRl?= =?utf-8?B?Z2xEdFNteTAwS0dTclI3MXVUL1E5bWtnYmhpUmJ5TmRncmV4QS9yOVlxRkpG?= =?utf-8?B?UXVWOHdmR292bHhUUjZwZ2RpdFZhWGVzc2hNVWU2R05zd2RQNHRaa3oyZTBu?= =?utf-8?B?Rk15NnNGb3ZwTGI0b2RJK3lTYXhXMHhyTm5TWGthSEYvajEyaWVYVkpLbC9R?= =?utf-8?B?eFJGRGlHNnhDaEJpWkhsOENQQUtZMUs2M3F5M0RjYlcxTDd2a1VwQ21IVlky?= =?utf-8?B?U3F0TWdheGhFdDlMWG5aekxFNlA4WHJSYXloeUtBS1ozb2sza3A2L2h0dVFL?= =?utf-8?B?ZVd5MGZjTVMwaXJUeUJEL28yMnVOTkpFc2lvQUNUWGFOSUV5Sk16allFdFFI?= =?utf-8?B?ckFLV05xTmM5WUpOM0dDSVlzUWlHUzFQeHY2Y2lVYjdPRWd2RUkxZWpKNVNo?= =?utf-8?B?bkNKMjA5ZDI4ZmZ0emFIVzdWcVJtZE54K09Rc0JrVEd0VitscXFqenlaMmIz?= =?utf-8?B?S3dhbUd3c2JldW1JMU1INjYyS1NjZlNWVXNwbzM4bm11d2Q3R1JYQ0JUTEp6?= =?utf-8?B?UzVJYll4VjRGNjNCU0c2dFhoY0t2Q0hscU84Y3BPVWU3SFl3UHNONjdncFVF?= =?utf-8?B?QXVSS09WOVBES0N3aklFZDZmMGZpY3hHOUt6bm5uK25GY3I0Sm1WM1RKTDJK?= =?utf-8?B?OHdLYnpWVkxjRGhqUmprZFpzeHFYR0pqNEE3TWpuTE1PRTZNalVwUmVaUytj?= =?utf-8?B?UTYwcFpUUStaZ1F0OUFNbzAyTzZoTXpBalZxaWhYN1I4SFdzTU1WNFVGK1d4?= =?utf-8?Q?EL78gx5XLFYmm87ZFUVUW2G3g?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: de9bac01-a9a6-4ec1-94df-08dac88aedec X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 11:00:25.0187 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: miG5L13WuX1SLQiZG4eUryW3tlnxVUeiYPDnSUHELwAWsafOvrE8IpmARJjDzk4eSBGJ9x0SVKyLKU8ubW+bxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7169 On 17.11.2022 11:39, Michal Orzel wrote: > On 17/11/2022 11:03, Jan Beulich wrote: >> On 16.11.2022 10:20, Michal Orzel wrote: >>> --- /dev/null >>> +++ b/docs/misra/external-files.txt >>> @@ -0,0 +1,70 @@ >>> +External files in Xen >>> +===================== >>> + >>> +The following table lists files present in the Xen codebase that originated >>> +from external sources e.g. Linux kernel. The purpose of this table is to: >>> + - keep track of the external files in the Xen codebase, >>> + - help with the review process (e.g. changes done to the files that did not >>> + diverge, shall be first submitted to the external projects and then >>> + backported to Xen), >>> + - act as a base for listing files to exclude from MISRA checkers. >>> + >>> +NOTES: >>> +1) The files shall be listed in alphabetical order. >> >> But then you don't? > True, it is alphabetical order with directories having a precedence. Which is kind of surprising and, at least for me, confusing. >>> +2) The origin of the files derived from the projects other than Linux, shall >>> + be specified within the () placed next to the path. >> >> Might it be more generally useful to have another column, then not only >> stating the project but also the path it lives at there (or lived at the >> time of cloning)? > We though about it. Would be a good idea but can be quite challenging for files > that appeared in Xen before switching to git (difficult to establish the time of cloning in such cases). > >> >>> +3) The table shall be updated when importing new files from external projects. >>> +4) At the moment, only the source files are listed in the table. >>> + >>> +| Relative path to xen/ | Diverged from | Subject to | >>> +| | origin? [Y/N] | backports? [Y/N] | >>> ++-------------------------------------------+---------------+------------------+ >>> +| arch/arm/arm64/cpufeature.c | N | Y | >>> +| arch/arm/arm64/insn.c | N | Y | >>> +| arch/arm/arm64/lib/find_next_bit.c | N | Y | >>> +| arch/x86/acpi/boot.c | Y | ? | >>> +| arch/x86/acpi/lib.c | ? | ? | >> >> This was simply split off from boot.c, which I'd be inclined to take to >> mean Y in the "diverged" column. In the backports column I'd prefer to >> keep ? for both, or any other indicator taken to mean "maybe / uncertain". >> >> What about arch/x86/acpi/cpufreq/* and other stuff in arch/x86/acpi/? >> >>> +| arch/x86/cpu/mcheck/mce-apei.c | N | Y | >>> +| arch/x86/cpu/mcheck/non-fatal.c | ? | Y | >> >> Even before disappearing in 2.6.32 the file was different from Linux'es, >> simply because we don't have anything like schedule_delayed_work(). So >> it's pretty clearly Y for "diverged". >> >>> +| arch/x86/cpu/mtrr/* | Y | N | >>> +| arch/x86/cpu/amd.c | Y | N | >>> +| arch/x86/cpu/centaur.c | Y | N | >>> +| arch/x86/cpu/common.c | Y | N | >>> +| arch/x86/cpu/hygon.c | Y | N | >>> +| arch/x86/cpu/intel_cacheinfo.c | Y | Y | >>> +| arch/x86/cpu/intel.c | Y | N | >>> +| arch/x86/cpu/mwait-idle.c | Y | Y | >>> +| arch/x86/genapic/* | Y | N | >>> +| arch/x86/x86_64/mmconf-fam10h.c | N | Y | >>> +| arch/x86/dmi_scan.c | Y | ? | >>> +| arch/x86/mpparse.c | Y | ? | >> >> Like above I'd like to keep ? (or alike) here, as neither Y nor N are >> fully accurate. >> >>> +| arch/x86/srat.c | Y | N | >> >> What about common/cpu.c? >> >>> +| common/libfdt/* (libfdt) | N | Y | >>> +| common/lz4/decompress.c | N | Y | >>> +| common/ubsan/ubsan.c | Y | Y | >>> +| common/xz/* | N | Y | >>> +| common/zstd/* | N | Y | >>> +| common/bitmap.c | N | Y | >>> +| common/bunzip2.c | N | Y | >>> +| common/earlycpio.c | N | Y | >>> +| common/inflate.c | N | Y | >> >> What about common/notifier.c? >> >>> +| common/radix-tree.c | N | Y | >> >> What about common/rcupdate.c? (Stopping at this in this regard: >> It's unclear by what criteria you have gone. Even as simple an >> indicator as "Copyright (C) ... Linus Torvalds" was apparently not > Please see [1] > >> used. Similarly mentioning criteria for considering a file >> "diverged" would be very helpful to spell out, even if there's >> likely some fuzziness involved there.) > > We would need to pre-define some criteria to avoid having a long justifications. > Any ideas? Well, changing just #include-s to fit Xen's model shouldn't count as divergence. But coding style conversion already may. I'm afraid criteria here depend very much on the purpose, and hence I don't feel qualified to suggest any. >>> +| common/un*.c | N | Y | >>> +| crypto/rijndael.c (OpenBSD) | N | Y | >>> +| crypto/vmac.c (public domain) | N | Y | >>> +| drivers/acpi/apei/* | N | Y | >> >> I'm not sure of the N here. >> >>> +| drivers/acpi/tables/* | N | Y | >>> +| drivers/acpi/utilities/* | N | Y | >>> +| drivers/acpi/hwregs.c | N | Y | >>> +| drivers/acpi/numa.c | ? | Y | >> >> Y >> >>> +| drivers/acpi/osl.c | Y | Y | >>> +| drivers/acpi/reboot.c | N | Y | >>> +| drivers/acpi/tables.c | ? | Y | >> >> Y >> >> What about drivers/cpufreq/*, drivers/char/ehci-dbgp.c, >> drivers/char/xhci-dbc.c, and drivers/video/font*? What about some of >> the stuff under tools/, especially tools/kconfig/? > > [1] > For the first shot, the criteria was to list files using different coding style than Xen, > especially the ones using tabs instead of spaces. As I indicated before, the list may not be > completed, hence a gentle ask to list the missing ones. Some of the files you mentioned > use Xen coding style + there is no information in the git history that they originated from > external sources. This is why, the maintainers who are the addressee of this RFC should have > a better knowledge of the origin of such files. Hmm. Please forgive me being blunt, but to me this then looks like offloading work to people who shouldn't be required to invest meaningful amounts of time. But maybe that's just me viewing it this way ... Yet this is particularly relevant if ... > As for the files under tools/, FWICS they are being filtered-out from MISRA checks, hence I > did not list them. ... the goal here then indeed is use for MISRA alone. I did e.g. ask whether it wouldn't be worthwhile to more precisely describe the origin of files because at some point in the past it was also proposed to arrange for some more automatic monitoring of changes being applied at their origins for files we have cloned. Which obviously first of all requires establishing an association between our files and their origins. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 17 11:02:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 11:02:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444942.700133 (Exim 4.92) (envelope-from ) id 1ovcfS-0003uX-6f; Thu, 17 Nov 2022 11:02:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444942.700133; Thu, 17 Nov 2022 11:02:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovcfS-0003uQ-2M; Thu, 17 Nov 2022 11:02:50 +0000 Received: by outflank-mailman (input) for mailman id 444942; Thu, 17 Nov 2022 11:02:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovcfQ-0003u9-RU for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 11:02:48 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2062e.outbound.protection.outlook.com [2a01:111:f400:fe1b::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5df7e22a-6667-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 12:02:47 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6952.eurprd04.prod.outlook.com (2603:10a6:20b:107::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 11:02:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 11:02:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5df7e22a-6667-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WTtxOlwebTgCSRc+0bk5TEGtt3zwLJZZ+X+SaOv6rfQIDpHnE2hZe7k6wyRyUyWZizVnz0DfoAEHEsLoudusQfK5lPTqGbNSNe51JLEJKzvHZPqolttcOT6JLg6vcnsKnUvS4NUE7MvyAESDpjAwej6tAVxqiR/PjlGTdQciyFOzKGc8J2U+1t6hdajtwTv2uFujrAX2mPP2JriciqLO6DPyPY0ZMI+LLdCw+HKq7VwjTiqvnwro9BMPt/410ng1P1C17OFCgtjhzrYJx8RmefmP/6+Jv6Ew3HFwmh/zw0vx+TnyIACFv1QlS4CjcHisUBMAPQlQk2G/C0SoNR65AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=enzpmgm+Wx2zaDFOlTJh3Vae26JcCCV25docySovQK8=; b=NZUvasErmmNFS7MRqrUiE4n0rrpXXSeBDQOsTfEzavwkO2riVtf7wNTjqEtGYc8BR/4cAlLKIT9c9jlv6xsHqn++XjOcH+bqbU3gaRfnDnRjkbvG8cYM9x4n+lamWeAhNW4EHHhh0uOj4kjFrWUFJg2r7KBz07MFzSJIzFYCF+q+vHxUG9RtytqVKX99ALY4to0oa2v0vWyUuxaJ5yk/Fc81VjN3Tt2Fv7YNV0b//kQQYLfAtAbT5xhQeJJ9uG7aY070zpjlmgxrrVP71Z3hPJF3K88QtUdeKGDQdY6tLvvrk/XE7QUyPiB5oth6oipAnVO/vwq7qVTJvTqZM5ofoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=enzpmgm+Wx2zaDFOlTJh3Vae26JcCCV25docySovQK8=; b=cRxghlbvPvJzTaXD1ZvPdCbRF8yQ1mqiEERCdLEUMf9FYx1VMoaL10Di7+WFT4gzuL3gxyefWvkpML8NLKhgHF2JAKkXr/RrEDuyYw7rz3fc5/IV77y3sKOATZ4H9IOCdfHaraLFI54WGMuL/8VpLkV8fh3/H4tcu/tpXdy+lmW/dLdrkzO2H8507zn+RqJjrnxlIi1blT7vkDOkhdmrVhi87NKRYDyWk2FXGc0iZ+zHpk1hjEfmxngFB3/cBToMa5rRWbOkkukaYeSH2G69ZpMJxMHw/Xb7NtSv55nPEOMrmv/3IgEulqtO3dLQ2hV/rr6bwRRjZZD9I/W7J4l22w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <487ab146-825d-37f7-ead8-a510b0c4d6b1@suse.com> Date: Thu, 17 Nov 2022 12:02:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 From: Jan Beulich Subject: Xen 4.15.4 released To: xen-announce@lists.xenproject.org Cc: "xen-devel@lists.xenproject.org" Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0032.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6952:EE_ X-MS-Office365-Filtering-Correlation-Id: ef8ba820-9410-44df-633b-08dac88b4137 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qAopv+CGxvEhc0yVEN6T4zvn3fZ/IlnrSXHYuBYT/2zcH7y8Xsv5Nnegi8+r9wLu2jzfAJB68ieP6d0ruulf+heXSaGrsjfHySCn/dFehDnjdxGpn2n+u0bIIywOOJWEDgBX7yzBNI+B6xc3ehjSj/cnE1Bt0pYUbNKC7CmZfmRQJqIQ4Zyhn6bd5SW2V5opTGiLykLkhd035kKs8z69QxsNfGOW2XzZZhR5u7MhwsrsERpNcTq+d1Rwk5HN6OkWZ9YDMtX6myUwvVDGCOYOs4rPEDNriofnyS+zIg0xHcXXUdXRlrbzcjm74UQn1vYzDp+/onjpwnYirzO98uNoJO0HKbx2Exb5lZihrQk6MfSBfxUF8xxxFiLUqbEvsVO2/LytbviJCkfkmitMYQx9ZTvIXCpWYnryw5DroWOCtLKq5NIUY41hhRZG1KHwIAP4YX0JF3dx/PyNjT0TWpKsHc17Cx7Iby67cxfBdE5Bkn3tjUSHamzPdXK3H0KC8xWysOnW8HHsy3eduolm91DBGpC3H1zc1/7Q9XLR7Bk4SK9AMu2123R1wWBFeR4vgp9iIWbI+kUn82hIS4yEfQ5gukK7gQEQaQaG+deduTzKHDGhm4y8yaBlbI2Xhy883CwXSfOIOYo19ls8/o/f2iipPfJBYP1m1D5nTzg9EfDrJ5z7aBC70yXvqzk9EFksj6jWZLDPWs8c2wnsOybiVz/vTSZUXgFIaZy+wQGHdE2xTAJiJkt6RHI+heISUz+5a3zr X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(366004)(136003)(39860400002)(396003)(451199015)(7116003)(4326008)(83380400001)(31696002)(66476007)(86362001)(8676002)(2616005)(450100002)(66946007)(66556008)(4744005)(5660300002)(8936002)(41300700001)(186003)(26005)(38100700002)(6512007)(36756003)(966005)(6486002)(478600001)(6506007)(316002)(6916009)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzhBN2VKOTZ6Z3FTQUpBcWhlUTkvd2FpcEcxLytIT1hEU2M3OTZqT0U5WkMz?= =?utf-8?B?YVpzdlV0bEtUV1lSVC8zRldUTWprNTRWYXVybjJrY082a3VydW05dzhweE85?= =?utf-8?B?emlZczF1blFOaVJqZkNLYUF3VWZJYXg3bFdnNVZZcFpaUUhPektqa1ZnQnFp?= =?utf-8?B?d2gzUkNrWkJUOFFHc0t0Qi92NnVsZjNrLzdNU2t4T2x1Y1h0M1hJdXo4VlNj?= =?utf-8?B?WVFoRWFGUzUzVjFtU0VRQWJZamVmeUZCb1MvblN2eUcvem1ocXduZjNmcjFv?= =?utf-8?B?ZjlBS3d4RFdpUEhiYUM1ZzF3MUxUN21MZGRtS3dUdHVWQ3dFOHQvK0Ywdzl4?= =?utf-8?B?OXFlMDZUUzJTKzNjVEwzR09SUHgyLzY2UTlWMFRPTElpeUlrYytlNWVKMUlV?= =?utf-8?B?cjhhWlZnM3g2YlBWb2h4OGZSQlNEcG1USWxndXpSdm5QeDJpY3Z1b1FuSnlH?= =?utf-8?B?ZWp3RldNS3plYUpWdkpNZ0J5V25Db2VnVGVnVkVpVk10OVFCOURvTzVFcDhK?= =?utf-8?B?Ukx3T3Y0MEprbXpjc3RBT1V5QUlLc1NoYkFleXo5UVVFa1l3cFV5aERGUkF4?= =?utf-8?B?NWY4M2xwbUFmMUpnaitFRnJhblN3aFkrdEltVDJsbk1Bc0tOeFQyMm5LU1Nl?= =?utf-8?B?aEk1ZG1hOThJdHVxaWhWSHR4WTNSWmhiYnQ3YmNhK2RaZ3pMS2lnc0crVDhj?= =?utf-8?B?Zjh6UkI4bVVVZ3ZLdGRhN1ZxeEN4QjQ3Q0JUdXBKa2dhdk9vNCtYbnQ3Sm81?= =?utf-8?B?N0VmWDdYcXFOcU5LRFBlZnhwUG15MVI2V3RNUDRsY0lNVUJXd1lOeVhLYzRq?= =?utf-8?B?eGFCeU1DTzN6OVE5RmtpTHlJYnp3cmROT0hIWmUzU09heW9DU3ZxdVdqK3Nm?= =?utf-8?B?enBHUjlzdXIwdHRwNDltb3lQRS9SRzYyYSt1S25uQWdPMFBYRVB3M2NTbzA4?= =?utf-8?B?dkdqeDhWdkZnYTk5dkUzS1FJTWZXSk85dmZDTzdwWFpVV3BNeXRrK3VyR3Bj?= =?utf-8?B?YnE4UlpIS1k5UDdPc2lxUWRKaFFMaUpwRG1ZME15WUJlTU5sSW1iSHR5Q1F3?= =?utf-8?B?TVh4alNtQzJyMU5vRFlyRGQ1aUpLWDJSSmxWS1YyMEY1YU5SQmxXMDNZMnVV?= =?utf-8?B?dHdWVnozbGFZdCsxcGN0QlNqb3lFdzhDYllRUk90c202QUZoTkJEMXlwNkY3?= =?utf-8?B?T0dRM3NPOHp2ZXBsVGFOdC9sd0FqSUtablJ2bFdySFlmQld0ZW91NTUyT3R1?= =?utf-8?B?NTdXUmlFL3pKbGxQZDhrUEhocHVHREdTcjRZUjllVHZPd3RFa3VuRGVxcnBj?= =?utf-8?B?dFg0ZVZhN1JpbnlONnRYdm5CdlgyN0tzY2dYampPL0l3Vi9SYmF6K2ZzOEdp?= =?utf-8?B?dXdDWVF4dlNSOXhLNDFFVzc4SHZVaklEdGtsMkdlTUhkZjNmVDRyeHBjeEUv?= =?utf-8?B?NmMvdUNGcWpad0RmcE51VTRrWWpObCtacDZNWHdkQ0pFUU90em8zZUw5YlBt?= =?utf-8?B?aWJ2WE1pNkN3bUVYZGlVbnJjQk5YSThLVFh2cy9ydG5ycmRhcCtXQ3I4V05Q?= =?utf-8?B?bUpGcE10ZFJhK251eUppOENhaEpuOHFycFVjdzhlZHh5cUtQU2JwMTJDQ2Jk?= =?utf-8?B?SndPOTkrTmp0K1VuT3BZdjNQU3hIcHlPTlEvd01uVE1udkYvcEI1dWJpZFRW?= =?utf-8?B?VHlxMzVaamp1Sjk5Mmo5VTV2SHRhaFVTRkxxODFvUjBSZHFpdFdxYTRRVklO?= =?utf-8?B?Qzc5T1NtNVp1NXgvL0hHTXM2L2hNenhnUEFrOHZCWklqaEtqakRDVi8yUnNq?= =?utf-8?B?R2JPc3BqYktDd0ZFT3hnUjQwY0lBZGNNMC9uYUdPMWNWaDZFRm5xUXRoSmps?= =?utf-8?B?bGU2L0duZ2l2ZHBPK0YyUkFVYkJUOERYbDllaTZucWxwbnhBZ20wMnlSSC83?= =?utf-8?B?emFLR0dBV0pSZjFaa1pKRjJkd0V3ckk5Yk9HR3d1UGpvem1tWlJyQzBMMjM1?= =?utf-8?B?MUhtWnlvcVRNV1pMVWdPdWhldnBoKzFoV3Z5cXoxYzNNcVpmRHNvaEhIM3hW?= =?utf-8?B?eHMwYjlqamhqYjdxaXRjeFRuOVhOSEc5T1dqK2k4UGtSZkRtRmJvUFp2L2Y1?= =?utf-8?Q?qizIh41FJJeURYjKxF7EWphSq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef8ba820-9410-44df-633b-08dac88b4137 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 11:02:44.8067 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IGFohuTIDR2TtOhF16w8vcj+giC9FKcoR2tXzqjlemY/x+8vyPodshOtTiOCdKS+Ewv6wdHlSh5ECFbPi72RzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6952 All, we're pleased to announce the release of Xen 4.15.4. This is available immediately from its git repository http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.15 (tag RELEASE-4.15.4) or from the XenProject download page https://xenproject.org/downloads/xen-project-archives/xen-project-4-15-series/xen-project-4-15-4/ (where a list of changes can also be found). We recommend all users of the 4.15 stable series to update to this final Xen Project coordinated point release from this branch. Regards, Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 17 11:05:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 11:05:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.444976.700158 (Exim 4.92) (envelope-from ) id 1ovciF-0005HK-Ud; Thu, 17 Nov 2022 11:05:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 444976.700158; Thu, 17 Nov 2022 11:05:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovciF-0005HD-RE; Thu, 17 Nov 2022 11:05:43 +0000 Received: by outflank-mailman (input) for mailman id 444976; Thu, 17 Nov 2022 11:05:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovciE-0005Gv-BB for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 11:05:42 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20626.outbound.protection.outlook.com [2a01:111:f400:7d00::626]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c4639b1b-6667-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 12:05:38 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8964.eurprd04.prod.outlook.com (2603:10a6:20b:42f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 11:05:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 11:05:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4639b1b-6667-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bqseZaqo3AWopjD7rTyhHm8S60fhlx78pXk/DFuZ9WSoB7oodZPjPoTL+TSWCwK/CdQp4QzKJK/H0T8dmnVtecNKkgtHUI1jTEfqcUrSAJu1ySdFczbamsPALoT8QdfiqxIgTXeqW7jI3wXoJWAPeozX8fUCy6rBBGGm5fMvdbfw7d9RsaauP+1/0NO1zjyb/n0+dmNOa1Ymg8FtXmWN412Xqkb7d+7ErIQMlg2BLTA/i/4BLVwQY31E7UAhyq4vS7FjzKxbhR0LG8MbE1TnimIgYOZbefp9/4puGCXzbnfwYInjA2fzEj51cRmPZVfLsNXnK6bFdKXOk9de/sCa1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZOPem5wlv44zkGOeFPMl74oN24xthUeEZJcqZUxn0jY=; b=LCRZ62GkrIdOnS0iBsNO3juu0wedKpjGNIyhLrWoSl0iIcrOvsCtUGnLtQA8Dm0rOwU3kblPbKvY2++Brk3eh/MfGajFl9E8WI+qd8gnW9Prymi2zJDVsetimmyCRRr6bArFZkWC4QtapYOdYYLe+s7PivoziHqdiEHBcyZPYFp9uysatbLtCO3t5OUnrgVeKDpJoeo2pX4epy9c756m9jlVKoJfsieer8aVdJGj/9mPKtt1FO0UkHk5pmTkv6aIxhJOTBh7mqZLOCDt1D2wzFuutpQzFR5bKXODKduCa7J55QXoTLJ4TLjg7Obnlvy8o1yA90kO7u2YCHO0f4Xpxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZOPem5wlv44zkGOeFPMl74oN24xthUeEZJcqZUxn0jY=; b=sXXSJyt9kClN8WLJGGF4DF+qkJPuLWeNNUAPGpZVdWecJVUG23eRkUig8mt1QudUlq0/ynth84EHikZBwuEetxQ8fDPPgoVSGnIi530VsLjZujkdSBgOEcUmWddOR32v8dHezBJr/VmImr2y581wkYsyUKVnyrCU03oluVXkdavovgeEEdlao8yC3+k+co55zPtUAvPogbmKVL7R1pqGSGledvxaHe9401wPnBXTvC/nbRKbSUNYdRTORpRoKRByptFr5irIXakz3SlQh+7uYIxqJQlHI3nV3ft1lCXzVe4naZfscqaw4sbEGqq3i7IdRR8DCJ+G/mEZ4ld4QHciBQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8a59fe37-bded-24f5-a2dd-108f84f2c434@suse.com> Date: Thu, 17 Nov 2022 12:05:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20221116164216.7220-1-roger.pau@citrix.com> <9b559146-11d8-f848-d6fa-baed7e0fa06f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8964:EE_ X-MS-Office365-Filtering-Correlation-Id: 18541070-c601-4964-930f-08dac88ba83b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1TE99X7OyV9iFNdpWDBXA+6Laomu1w5HkR8Hz/IwRWx4lOE2zsUFb84ufjftE91UHBHYL4cznVMoKdXo5XNawC0Uq+m2AIC7U4dZyraau9mNXEajTIZR1b3BaJGZheWvz3s4SZ6NJBYIVj8dkoI50URxIoK85V5jsBq1DRtTAvyXLdFACcsD23MQ/4MA1V9sAzBmSaMjpI6SMgUbH8Ddzpv7LTZTUDsolwVgQQR/02bUawddLwdBdIBFD0BbKWgHg5UIltCnx/R2/WV0NSH/UKMzxbm/I18DJ5yEpQyAZv1sxwYwJ2mI31kK4foVLpdMIxsq3/x7DEZkl8epekhz57dae/+meanHOt26RRSeFNuqAbfcks4486xfDJkC6gp+BnUkLUPzmb5Q5jZvallKQAbCFKXxhaghdDx7h0MBONYBE9n20QWldlMLDnUiC6N+FOAtPG+Sf1h2YMJLHgbNyYhHOC0n7qySrXuoatnHBhVYKlTZ2kHU1dl2Zw+L9Jsex+elreOlZQaym8AtcOGD3ofZF9yIlHes37is2tgp3SBLSIFet4+TzJDvBAjJIqo6YsJFH0tdaArj/8h7a5+MQatb6hFyhr45KP86lbLtMhXowxMMSgxTteFYPFM4XibrLBoeJjQrLsDbQubhZ7FD2D6D7I+G5xoj8xiC+QFcpLIkjIdgOHj1ANvxhzvn/QFI4cv1FhVzmLQfnw+wknugCCAmedXWxUFJ9Ourhpo66+c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(136003)(366004)(396003)(346002)(451199015)(6486002)(31696002)(86362001)(83380400001)(38100700002)(53546011)(5660300002)(8936002)(66476007)(41300700001)(8676002)(66946007)(66556008)(4326008)(6506007)(6512007)(316002)(26005)(186003)(2616005)(54906003)(2906002)(478600001)(36756003)(31686004)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmFCWGF5dFhCWG8zdHo5SXIwRmtodmlQdmNrVUlXNHo1azZXMmU3bmhGTjBK?= =?utf-8?B?K204cnkxSFAvVVZNZTUvbERuTG8rVTdqa0YxWmhEK2RMN3RNZzV0Unk4ZWR4?= =?utf-8?B?RTRFUW9mZzFXN1NOSEJ6WEkvblJHSHNiZW5YYjZPcjBnOXN1cmN1WUI5eWdx?= =?utf-8?B?QllsN2FIZkV6QldVcjVYdlBxeWZ1NzVFeGdXQkpaVzJlaWs0dm50em1kSEdq?= =?utf-8?B?TVVDK3p2OGN2MmZGMi95WWR6a0Zob1JVMnpVWFVPYWJ4RTlsMEhYNFg3Ulo3?= =?utf-8?B?dmRGR1hhSDJVT2JROUtVUXBpSDRHVWt0QW8wS2IweXVFL29oN21vbU1tR2Fy?= =?utf-8?B?Z2NFaXgrSmhUdEt5WkEzeGI0bXRhQXNIbFFrUVpEdHBTbWJOSUpSeGU1L0lr?= =?utf-8?B?RTd0MWFiRU15WWJDeXlHTFlTcnBHUmcyL1pkSjVZZ1lFMlA4Vk1hN1ZLai9l?= =?utf-8?B?NWd2bmZoSUppYlFzVFNFRHRGdHU4TFZ2emI3bWN1WTQrNlBSOVJjS29VblRu?= =?utf-8?B?RUc0UWh2eWRVT0tnemVMSCsvQlB2eU5HcE85clU1YWkvM0ZPU1RsVXBKc3Vu?= =?utf-8?B?ZFpPTUFyckJlU2ZzTVZNaFFKUjc3U1F5TittV09hWTIzdWIxNnFuL2xUTGdF?= =?utf-8?B?Mm0wbFNuS3ZqWk5jOGp2SVVmZjRWSHlUUHQ4enpSU3pUNUZ4TW1uTUd1Qk9r?= =?utf-8?B?aUhyZlNkeE1NcmdPenFNNHA4OFVqdlIrQXFBOXYzdGJvcGh1N2lEeWVobFgx?= =?utf-8?B?dGpjWldza01YTlg1Sk1ubHVsRmx6eEJON1poM0F0MmRBRjFUNk1BMWR1S1ow?= =?utf-8?B?R2ovczNraUN3V0lUQWtlakgwVHN5UmdUVVZjU3lsUHhQUEg4N1dJYzFTR2lB?= =?utf-8?B?VlR1RHJMSlpIbUZwL3BHTlFGZVArTzIwT1FUS1dxMnJJRjltWERnWmlLSzIr?= =?utf-8?B?UkJiK3diQjNpYmdUN3VJMXZOSGhPUEh0NkRWN1h4S1NTWXBKTk5ZSjI5YTM2?= =?utf-8?B?c0s0NU9pdUFMYTRBYnFDMjhQOFNiQ2lvUGgyLzNiT2M0bnU0OFkzcUlLVmxP?= =?utf-8?B?STlDbWNlQlQ3WnY5NzhsbGVHYXNjUXRXR2RHM0FkWHdDSkdGbHRTNmlUWVlT?= =?utf-8?B?aUY5OE5LL2p3K1VnWUI0anZsRWhuWDNrdzZwNkNpbUhwcUU1ZUZveXlHMlp5?= =?utf-8?B?aThqakFKUWg1YmtsdTNwMTJVZE9mTy9XYnI3cm9QYU5VNUsvMzhKd0ptNjhx?= =?utf-8?B?dk9tZ1FpL0x5TjNPUDhsS2dHZGhpNzUyVFlYMVVpaGRKR1l6V2RVdkFjaU03?= =?utf-8?B?cjd5UlpPL0M5a3Y3ZDRnUXNTdTl0YU5DVGNyOXFCMXZYYVM3eEh4SFcxT2lh?= =?utf-8?B?dzRwRlhPZ2t2c2pqNzllNGIrTjJuTU8xbWE1aGZCWjR3cnBDaU4rRG9aMnkz?= =?utf-8?B?bWxtY3YwdmZRd0pmeHVFWjgzN0wyZG1jdUZSYVRsR09vYTA2RGJTV3V2RWtx?= =?utf-8?B?YzV5Wi9TOWFqd1FVTGdlMm40SFd5bDdBMWU0N0hnVk90elJlUnJqMDVxQXA2?= =?utf-8?B?dERUTThKVXdzOG9FY1BnV3U4R3ZNTVVUMGQ0amtrajhucGFDRG1mdWNrWUUr?= =?utf-8?B?U0l2c0xpVjUyU1MxdHRLNlU2S2dpQkM5YWN3QVdhbURJQlRqUDA3OEFjeGpS?= =?utf-8?B?YU05cXlyZnlwUStha3NBWXhGQzRiS1I0azA2Nm5mQkx1YjhFZ0JlQ2JhSS9Q?= =?utf-8?B?dllXeTJ3cURocXZBdjZXVEc3M01vcGpQQk92MlRZeWFRV1gyRVdkYkZGbzdE?= =?utf-8?B?V2llRklKWWhWQ0s4Zm1VdlJEc2FaQUp4N1NBNm1GbWZBdmJrbVE1NS9xb252?= =?utf-8?B?aEo5QmF2Y2NDaDVPREY5T3o3My9WbllXZytMVDhleEhsQ1lVOWFlTGdWYWZN?= =?utf-8?B?RDVlSVNYamNVbGFJQklxZDZBMmY5SGVFM0pPZElEVFNNQlVndFFWdmt2N3Fx?= =?utf-8?B?QU5RWjFlRWhBTHc2dnE1aGF6ZTROVDExNmh6VTBVaUpnbjFNSzBMQ1Y3bldv?= =?utf-8?B?cEU5eVQxWFlzQml5ZjFFTlRBUlBacXlhOGNoSGtQYnFOeVVubTRsL2tYeWp6?= =?utf-8?Q?VHEdHzA3sCrlAfv1PB+cOtBUE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18541070-c601-4964-930f-08dac88ba83b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 11:05:37.5926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B8OFJmDAW19upn6mWj0mNnyT7/+4zSMJ0izP3IQC76juh1r9sdp11M3nf5rscx9q1/OvuCPLGru+BJswHChj7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8964 On 17.11.2022 11:23, Roger Pau Monné wrote: > On Thu, Nov 17, 2022 at 10:27:41AM +0100, Jan Beulich wrote: >> On 16.11.2022 17:42, Roger Pau Monne wrote: >>> Currently Xen will passthrough any Local APIC NMI Structure found in >>> the native ACPI MADT table to a PVH dom0. This is wrong because PVH >>> doesn't have access to the physical local APIC, and instead gets an >>> emulated local APIC by Xen, that doesn't have the LINT0 or LINT1 >>> pins wired to anything. Furthermore the ACPI Processor UIDs used in >>> the APIC NMI Structures are likely to not match the ones generated by >>> Xen for the Local x2APIC Structures, creating confusion to dom0. >> >> Plus we should have passed through Local x2APIC NMI Structures then as >> well. > > Sadly this is not possible for PVH dom0, Linux will use the ACPI > Processor UID as vCPU ID in hypercalls, so if the UIDs don't start at > 0 and are sequential Linux will panic during boot because vCPU > operations will fail. Sure - I was merely hinting at the original attempt having been incomplete (besides being flawed as per the description here). Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 17 11:15:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 11:15:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445117.700169 (Exim 4.92) (envelope-from ) id 1ovcru-0007QL-8s; Thu, 17 Nov 2022 11:15:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445117.700169; Thu, 17 Nov 2022 11:15:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovcru-0007QE-60; Thu, 17 Nov 2022 11:15:42 +0000 Received: by outflank-mailman (input) for mailman id 445117; Thu, 17 Nov 2022 11:15:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovcrs-0007Q8-8k for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 11:15:40 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23d378db-6669-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 12:15:28 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 8C9E35C0760; Thu, 17 Nov 2022 06:15:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 17 Nov 2022 06:15:36 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Nov 2022 06:15:35 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23d378db-6669-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668683736; x= 1668770136; bh=fRC9zntwG89J7/RUbd4ryrJLykigctEhig3DEmAzbqk=; b=C AGag0iPzG1x4VKKK2AvuzKLpmPJ7eEr9cN2CTY3nBaypDZ79RqslS4Ih99Kr6doi MXodUbw0hufmd6s0SsEQs2GVFD2up+DFiIPNiGk3YqU3I0AOix3gesMNLlLyzHYm lWlavYJMCxS/uK3lRjCwILSP/5lB1xcbuCd+NDmPF5H21gsEjeG+iHr2rSTo15zP Truy0W8pz6dqlUUu9zYpbsSRM80e6UMOeBG2bWdDA0K2XGoYyiflDwJuIp3C5Xq5 S59iVHeWU1WjYuRucQUqC1POA8rIXEgDuWChHQ6bpYHXklUCS8n6Pm9NTAXegHt0 XtcWdeGsNgJ1jYOzq3QaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668683736; x=1668770136; bh=fRC9zntwG89J7/RUbd4ryrJLykig ctEhig3DEmAzbqk=; b=RS/LCuRXwyq+8kQc6o7zNJklNM/JE755mOJLIvxD25wh zN1UlKlA5KA+SAy5BIQjNmOHlIz7yO/eHyqYq45h1YDemwIPQvhRtAAtgWDxSoDK pcSU8QKyKONVZP8pToWYt2BSaTpsOdAkS0D/9l9EHOLLuGMBP8V7yP021b+5CtRg +l6nUle7PVoFFBhEFD8dIQdeTmtXqbfIMxCC9dfrmmD3tqhlM6u7ZHbdzT2dEp5Y +hG8Y7mHOvyIBSgVdkBojKBRBLlY0eZz5pJUlpJL51Tx+xDCrVZU8fItPu95cevP ncig8foWEE9TgnV0L5Sd7r5t2INBX44TQLmMiP/ddQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgeekgddvgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeukeet teeggffgkeduheetgeeileejjeeiiefhjeegvefhtefggfetueetteeuteenucffohhmrg hinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 17 Nov 2022 12:15:30 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" , Jason Andryuk Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen Message-ID: References: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> <20221114192011.1539233-2-marmarek@invisiblethingslab.com> <1443e924-5b53-9ee0-00fb-4d790d404b08@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fJdg5cbyRovzVsoQ" Content-Disposition: inline In-Reply-To: <1443e924-5b53-9ee0-00fb-4d790d404b08@suse.com> --fJdg5cbyRovzVsoQ Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 17 Nov 2022 12:15:30 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" , Jason Andryuk Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen On Thu, Nov 17, 2022 at 09:04:40AM +0100, Jan Beulich wrote: > On 17.11.2022 04:34, Marek Marczykowski-G=C3=B3recki wrote: > > Ok, I found what is wrong. Enabling MSI-X is refused, because INTx isn't > > disabled at this point yet. And apparently I was testing this with > > permissive=3D1... > >=20 > > Linux does this: > > https://github.com/torvalds/linux/blob/master/drivers/pci/msi/msi.c#L611 > > In short: > > 1. Enable MSI-X with MASKALL=3D1 > > 2. Setup MSI-X table > > 3. Disable INTx > > 4. Set MASKALL=3D0 > >=20 > > This patch on top should fix this: > > ----8<---- > > diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/= xen/xen-pciback/conf_space_capability.c > > index 097316a74126..f4c4381de76e 100644 > > --- a/drivers/xen/xen-pciback/conf_space_capability.c > > +++ b/drivers/xen/xen-pciback/conf_space_capability.c > > @@ -235,7 +235,7 @@ static int msi_msix_flags_write(struct pci_dev *dev= , int offset, u16 new_value, > > (new_value ^ old_value) & ~field_config->allowed_bits) > > return PCIBIOS_SET_FAILED; > > =20 > > - if (new_value & field_config->enable_bit) { > > + if ((new_value & field_config->allowed_bits) =3D=3D field_config->ena= ble_bit) { > > /* don't allow enabling together with other interrupt types */ > > int int_type =3D xen_pcibk_get_interrupt_type(dev); > > =20 > > ----8<---- > >=20 > > Jan, is the above safe? It should prevent clearing MASKALL if INTx isn't > > disabled, unless I missed something? But also, it will allow enabling > > MSI-X with MASKALL=3D1 together with MSI, which I'm not sure if should = be > > allowed. >=20 > While it would probably be okay with what we have now (after your earlier > patch introducing allowed_bits), it's likely not going to be correct once > further bits would be added to allowed_bits (which clearly is going to be > wanted sooner or later, e.g. for multi-vector MSI). Hence I think ... >=20 > > Alternatively to the above patch, I could allow specifically setting > > MSIX_FLAGS_ENABLE + MSIX_FLAGS_MASKALL while INTx isn't disabled as a > > single exception, >=20 > ... this is the way to go, and ... Ok, I'll go this way then. > > but at this point I'm not sure if some other driver or > > OS wouldn't approach this in yet another way. >=20 > ... I guess we need to further add exceptions as needed - the one further > approach I could see is to keep all entry's mask bits set until setting > "INTx disable", without using MASKALL. >=20 > I'd like to note though that the PCI spec has no such exception. It, > however, also doesn't mandate setting "INTx disable" - that's merely a > workaround for flawed hardware afaik. (In Xen we also only cross check > MSI and MSI-X. IOW we rely on Dom0 anyway when it comes to driving > "INTx disable".) Therefore in the end pciback looks to be going too far > in enforcing such dependencies. >=20 > Thinking of this - what about making the change in > xen_pcibk_get_interrupt_type() instead, setting INTERRUPT_TYPE_MSIX only > when MASKALL is clear (alongside ENABLE being set)? This would then also > cover command_write(). That may be a good idea, but wouldn't cover the case here: xen_pcibk_get_interrupt_type() at this time returns INTERRUPT_TYPE_INTX only, and setting MSIX_FLAGS_ENABLE is prevented. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --fJdg5cbyRovzVsoQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN2F9MACgkQ24/THMrX 1ywedAf/dOdpvHMdqxqZIURx2tzub79X1LxTrSa9mqH/9utKQj2xrBX2UAjQ53pi 3q4t9afEFRzYKqGTolbTmY+YGHDEKNFfHxN4UMo97V3qD89WsaKTtL02YRf8FgXn A5qIicth/fwYhP1XSHuTTc9JGGi0+b1i0eULWDM6Kv9nqJCmPXQgxoNKv9Y3/n8w cBYBhuII6SPgHnaFsFmpcra7XfGoOUF8fz0zh99/f0v+M/Q1oASezM4Bq1EylM8u bJa9MyRaIhOH1CB1tzZVCRHFpH1ifoXFQNck8jFuaa0DTVTMOV4rWD7ncFvfRJ3d cpn/DJ2kgMrr9tjAAaXnwK2DTxDK0A== =Xa69 -----END PGP SIGNATURE----- --fJdg5cbyRovzVsoQ-- From xen-devel-bounces@lists.xenproject.org Thu Nov 17 11:35:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 11:35:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445130.700180 (Exim 4.92) (envelope-from ) id 1ovdB1-0001jj-D6; Thu, 17 Nov 2022 11:35:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445130.700180; Thu, 17 Nov 2022 11:35:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovdB1-0001jc-AR; Thu, 17 Nov 2022 11:35:27 +0000 Received: by outflank-mailman (input) for mailman id 445130; Thu, 17 Nov 2022 11:35:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovdB0-0001jW-JK for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 11:35:26 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e6b65580-666b-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 12:35:15 +0100 (CET) Received: from mail-dm6nam11lp2177.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 Nov 2022 06:35:16 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6873.namprd03.prod.outlook.com (2603:10b6:a03:438::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Thu, 17 Nov 2022 11:35:14 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%5]) with mapi id 15.20.5813.020; Thu, 17 Nov 2022 11:35:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6b65580-666b-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668684924; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=ZSaoL3foRwDHJ84aHiU2WU2nhqVi4vluKK2+KvEBuUo=; b=JTjgl4sD6LbE1SUgGVUccpP7NB+EG7jVkPNqiYYrjXkTOr4rWxwT24qQ GAlLvVC8lEmPS9uKh7IQJWRcbmqMF2h+TKvgwQRAsRzvxYEF+DCxTuV0Y mVH8lZPhEPhN9CjLjlASrbL0/pKT1ytb75MTvkJk39JEa9X3KqHNH7haU I=; X-IronPort-RemoteIP: 104.47.57.177 X-IronPort-MID: 84603650 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:+Hkk+6ry4GaVDU2wucsjAgNUwxdeBmI6ZBIvgKrLsJaIsI4StFCzt garIBmHa6qMNGf0etwnaYu1/B5SvsPVn4RlHQY6rC42HnhG+ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHziZNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAA0GPxHYuM6/+4ucSNV1h/8HJZfPEIxK7xmMzRmBZRonabbqZvyToPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeeraYWKEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXoqqAy2wPOngT/DjUnc0rrseTginKlfMwYB RQ3vTUCtpELoRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LRQ62 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBscOcey9zqoYV2gheRSN9mSfexloesRm62x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBNzxooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:o1KPBKnpSVWxlcQg0Sn3uWDmwanpDfMEiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJLqDhSC2R8acjVXhZMv63 LMnQDV7riq96jT8G6c60bjq7Bt3PfxwNpKA8KBzuATNzXXkw6tIKhxRrGYuzgxgee3rHInis PFrRsMN9l6r1nRYma2ix3w3BSI6kdh11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza NixQuixtlqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bWDHAcEcYa xT5fPnlbFrmGChHjbkV65UsYWRt0EIb1O7q445y5SoOnZt7StEJgAjtbEidz87he4Aot9/lq T52+1T5c9zpoV9V9MDOM4RBcSwEWDDWhTKLSabJknmDrgOPzbXp4fw+6hd3pDiRHUk9upEpH 36aiIviUciP0b1TcGe1pxC9R7ABG27QDT208lbo5x0oKf1SrbnOTCKDAlGqbrqn9wPRsnAH/ qjMpNfBPHuaWPoBIZSxgX7H51fM2MXXsEZsssyH1iOvsXIIIv3sfGzSoeaGJP9VTI/Hm/vCH oKWzb+YM1G80CwQ3f9xAPcXnv8E3aPia6Y0JKqitT75LJ9RbGk6DJl+GhRzvv7WQFqo+gxYF Z0Jq/hn+eyuXS2lFy4nVlUBg== X-IronPort-AV: E=Sophos;i="5.96,171,1665460800"; d="scan'208";a="84603650" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ezp230hIbmlqW5vT6ku98JfkKEXeenfSmcTQH+VGFi0qBcrI71MqQmaIZ3rik/KH/VLNaX4F3Ie8EPOxNSlqx1E9pJjmzcfvWWXgY7G2Wu+EI2sohjHY+O/2GUHr4MIg6uNwOOUAMvfYNI3dGwA7efZU5G3R3q/oKKEID1DlODz8fheA0Lffqrz+QQO8O/7rHh+3bbwb2Vcr3EVM7rRo3Gk37xg+XMPSXxboSDyCxotve9eeVmhc52BAO0yDYxg5Z6m1hw2Np8mSgCA43HdRLZ33M7MgQ0SPYoxOPdFTLItvOFbMZ0K5HKK3ivm2zNpLUfukBJGeveudfJFm8hmUWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZSaoL3foRwDHJ84aHiU2WU2nhqVi4vluKK2+KvEBuUo=; b=HVDJbscpWISEtRs+kg70XDV3zBcxdB+Qu6dgfDFgGakuVq3A7R6zdMF4xx96a3LNAUTKTf0ynbzeVOvLI1oMPZ6IHqY2GWgxwYFdNImIuljlJKcK0zN7blCQrNYimJ/z+7qMUxi/zMBqfSpmeTMlpntjw7gCDO4zz+8Pj7ycm7iUlXU154il4IWpthoHabfnpMxZ9+O40AvMEC0+YNVrtDj0OVw5DArmNuXP64kAlnnYSDSatpyrfk4Bd9DvCJl4XW6UbhU3cmQe1QipdIOND96eC2D2Bmgl44oNe93Yev9qzRzWJ9P7pnI+g3wTpqYSlNLT9xzJnV/GNm6U5nop/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZSaoL3foRwDHJ84aHiU2WU2nhqVi4vluKK2+KvEBuUo=; b=ufA8yvxPOLPfytHO1ceJZlx2rgTp/ZDQX4jdvUcYsoBHVi+4QF7z1aMXCG/D6w7dgW421O8YhLVQzXr2jSS+OsFH1KIr8Z7C9JtdGPQfySPgxu97vcjEVCebWj16JTbYG5YUtocYwrtAAM02ETSz0HwW4e2zt9oxYU52TVt7WUo= From: Andrew Cooper To: Jan Beulich , Roger Pau Monne CC: Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0 Thread-Topic: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0 Thread-Index: AQHY+dppI/YDqtuG9Eua4T+BrggU9K5C2fmAgAAjooA= Date: Thu, 17 Nov 2022 11:35:13 +0000 Message-ID: <0a5fd907-a822-4ea5-5f5e-4cbe8ec2816a@citrix.com> References: <20221116164216.7220-1-roger.pau@citrix.com> <9b559146-11d8-f848-d6fa-baed7e0fa06f@suse.com> In-Reply-To: <9b559146-11d8-f848-d6fa-baed7e0fa06f@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6873:EE_ x-ms-office365-filtering-correlation-id: 24893500-a086-44dd-5efa-08dac88fcb11 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vbg8VdknIj9UTdTk+IH9jm/Red35Zxs5S5T5B8//TsFi+L9XO/RZmbPaJ1Ty9QyzzJF2GctRxPB0Yd6xJf/lcQAS+etRzqHSn4VzWlqExDLyWP6mEJSV0GITQ3yJ49BY8qw7CRtNr9KvDDVUrOAPiNtN1FZOoBQPjLUk0n4YUmLBYVsYPXgvAwOiS32L3dqcAJZfZO/uzXOOY3rnLAnmsOkX17OV8+m+W+p5RZG9gKytpXA1RgvYupZwBHF1s71OXsB4HENOjIKEpYMzpx+bEp7wI2/vWW5zA4vwYLsP6ss7gutA5jbkt5xYhu7CAfYRpUOmy6z1wDcs09fpYKE8n4FFtCU0YO3Iiw/K/uoififGuHMbqbceh5NmCUWSbcMLYZ7B+g50JFvt12kqKFv9p00z7G/m17RPpXOa6/yu9MOEzvPZsQgKSWYqqjgB4919D2rt/5VMVfp6IHrroNLdAWnR15G7UpNiV8QgyIqvWkfijpQ/5258h4M97Psk+PUEb/hZcVLkTPr/kkVKTa5ZR+5iqbE18YXmqUZurOoWur2o0uWQ7YlEGpl7w78YPMLGZ2+NoEydpiy2w33kveqIEuzrXhlbnhxP2PVnXyPC5w/KVWG7YcZLgYcmFqHYckaf8kA4P0RkXqczQh/AwxCDRITbmvdKlVO7MK5dwhW7VIrUZjdZuzSQL3x0n9m79gJR7oVKdV93ti36iF4sVwY40G0e7Yk/T45Z5frnUbT14799XwkM+Z9UepcC/hcZr9Tz4Wzq/LPmg+sPcZ5qmA/tIg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(136003)(396003)(366004)(451199015)(122000001)(83380400001)(31696002)(86362001)(38100700002)(82960400001)(8936002)(38070700005)(2906002)(4326008)(41300700001)(64756008)(66446008)(5660300002)(66946007)(66476007)(6512007)(71200400001)(26005)(6506007)(53546011)(2616005)(186003)(76116006)(91956017)(54906003)(316002)(8676002)(6636002)(478600001)(6486002)(66556008)(110136005)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TjlJTlJaU2xDR2N0RnJ1T0Y3ZWw5STkrVWxiU0FYWkRlRURmK3dtdS9WNGRk?= =?utf-8?B?VWNwVFZPSnZZaHdCN2tXd2dUY0FxV1lCNnJZTUlNMFB5czdIVW1jZFdvdjY1?= =?utf-8?B?cjdZRUtOdVI0T0taak54R0NBSnR1VXZPMWZQT1I3NzROckNCZFN1UzVMSFJV?= =?utf-8?B?aGNkVFl5MHduK0YrZk16UXZRR04rTHdMWFMrbExwd04xN2NGOGtLVk9LYXJQ?= =?utf-8?B?ZnkzRS8xcFdvb0NiRFhOcGY2MllkUS9wSGd4a2NERHBkbzJkODNLcXJWSkxF?= =?utf-8?B?eXdHRkRJY2ZaTDlwLzJEc05rcGdaWnptWWxObTlTblZ4R1BSeXdDazNSZ3h2?= =?utf-8?B?MDNHYVJtbzI0NWFwcmV2T1hkYU03STVpS0djWi94UDZ1SHRSaW9XTnpMRlZk?= =?utf-8?B?MDlsY2YyWFN5MnVtdElrMFlNcXJDMXlNL24yREJIZVlXY20zb3pJaEpGUlZI?= =?utf-8?B?d1BJbWdrRnpUNUlhQkZqM2tpZVNZVmpzVWFaWWVjQTFkT1dzTVN2OUhyaEJy?= =?utf-8?B?M1hmbnJMVzVtZGNyMGJnemZ6VUZJZTBEaEwxWHVTMlRtcDd0QUVLT3BiQ3p5?= =?utf-8?B?SlJjY2xHc2ZFOGdzMFpVbER4WjhkSWdtb2NYL1NJZE1nSjFPM3JidW1hZUd6?= =?utf-8?B?UmMwQXVQblZVWVV5SWFlR0VQc1JJcHhlT1FDYW9OaUZkQkR2RWtFUE5MS3VR?= =?utf-8?B?R0ljMzgrZ3pzTHRtd0NXcTNVc3VlWkQ3RWZRTW1mZVhxMTl5Zm9pZzZkMWxK?= =?utf-8?B?bUdFbURzbkEwRXdoRzg0SmdBRk1hNzJId0owZHpxQVA1MkxOQThXMThsUkFE?= =?utf-8?B?ZTAreHFHdTRpZE1SUjNnN1g3S1NmMUgwVnlhZG02RkhSdjkvK0syNFB4eXVV?= =?utf-8?B?clhRbTZaNUt3aDU0Z1FmZkM1VjI5V0sxVGdHckNRTzFSeTN4bk1TdWJHMGda?= =?utf-8?B?cEV2YlNJc3lMZXpJRXlPei9BRG1ud2MyYlRyWjFmZVUvaUJzZC8rRmxpbkx4?= =?utf-8?B?R0ZvakZrRCtXZnphdDRGcU1KSldCQVpQQXBueGtjT2FFNytLamhhN0ZRc1NB?= =?utf-8?B?NmZRcnUzc1RoOHoyeFdWWjBGMTRZTlFCUDR5c1JqYlBCUVNGcHF6b0JOVSth?= =?utf-8?B?eG9jQzZuWXdhcmxxUmloOU9mV3NiSjJOVkJ5dmt3aTZvSFBFQWdGSmhqTkxW?= =?utf-8?B?WUV5eFU1Y2RacXg2a3FDK1FDczg2MDdpWDk4UU1rZVA3UzBSd0h2VVFLR2lQ?= =?utf-8?B?ZnpBd1N5MTEvYVVYdE0xZDFmMlBFMExQbytsd1Y5MjJQNW81T24rVGFGSVVF?= =?utf-8?B?VWFMQjZqUDdOYTdlbkw5aDZYeUI3ZjR1QlBzU2dxUHBScVlQTkdHNXNNOU81?= =?utf-8?B?MFd3YllhQlZDRlhwUGFlSFR0TXdjSERWVHVqL0tzSmhBQXZCMkJsVDFQYWxr?= =?utf-8?B?Q3NmOHAvYU1qZkdOWURiaThoZFZmckprREhpd2JZVjJFcGhlSmJoaHFZK3VR?= =?utf-8?B?YlYzWkYxcWd1cEdHZDJvd1BkNkgxYlhIaEl6Q1RibEpBSDdjdUViTXRzZy83?= =?utf-8?B?SDZnTWxGVE5iNDU3K2dZT1BmbmExdCtnV1M4cjMwcDBHTXdpaXhaTmROZEpN?= =?utf-8?B?dDV2Wk1IdUJBNTI5OGRQeEY1LzN3REtoTEhQRWI2ZENaaWpKbnVLMkg4UUNh?= =?utf-8?B?Tk9rOHJLdFI4dUFoMlJhZXMxL0R4RUZWN1RTcTZGdUlWeDVISVh2M1RPRGdm?= =?utf-8?B?U1czREpVTjh1Uy93MWF3bVZEVm5qZUdUZzhFYVE3QzN1UVJjNFV6TzY3TVpx?= =?utf-8?B?WnJyNU8xRGlDSzEyVGJnb1BQeGVlZ09USFU0SGg5ajNqeXNOTnUvM3E4Mko4?= =?utf-8?B?Q2I4cFlBcjJicEdoU01XZlVqTjRMNWxNVCtnblNWSVVxUitNUURKalpCMmht?= =?utf-8?B?MndXQkNqYk9laWtPL3BnL2M4WEZCZm8rSWlHRkJqYWQ3N0ZxTFJtaHBpMU95?= =?utf-8?B?UUlSVU0ya3QwdUZ5S01Bb0pHREJ1UHYzakx5NDlBcHBYODkxaWUvc2swTkdP?= =?utf-8?B?bFBLbkFueFYvYzJ2OUlsNHFPVVZoY281WU4xekpCRWJ3S1JJM3kvOUxVaWUv?= =?utf-8?Q?19nDCAsGwSlHQvCU7DWjZHpSW?= Content-Type: text/plain; charset="utf-8" Content-ID: <215703AF9A9DDA4885BE6E052B740B1A@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: XzOc/rAfvcHETQ81OIAvOwCDb0ERPN0PA52iPB5ebboxkIH5UVXBgoyFJ4UlPog5rpqGqE7KvRb8OTzYLtr9jN8ZCbIRxKbPo+GqqKtiPt9zQapmCvxMBipMyp0Rgfju3k0VV52NwyLbJYhDNGM7dlTQP8SqS9BQfxObY+XcUWCHUPS4pmhm8ZNweKJygFhc3Kp4y90Y5D+npJNwKT9IJ+hi36bRI5oRyFZp5EIWYoyCpNA01qvPnlFks3xG5NSsYjPqncqmJvc0NXVL+Xyms3GzN20A6ct4EzV4eK3nXhpUB+NZTAeOkD7rvkAo0XxgPQyIj/ZJSPC+GYC237QsRHeG7pTBg63HY3+ZayzkGaDRPqHDMv4gHR+w3EOIo5l3pOAoRzivJPCATG/dwIjW5oCMv6ncsTrrR2c0dcsGYIPet0H7Jf8Fy/hGKbgqXmBe6ya+OzoS9+GBfwamssVv588Ncxjx+/0E6x8eTuRWGvJKUAmkusWcgqg5r3MVYzdFdAWQFEZjU5Iq5uQy0PvUrYoAey+qegzJIqG5epHHKebjoos0a9EFLpoz2wJ31BRrKamKbRVEqo7KK3yER7ZpyTlAfEuqqH1/2+uZYU5+YXHkmxy55PDEiJF5dsuW/c/SkQO+YM9dtggH4CHrYl5BzwHMl1Mfh1DhdNGSKZbKDLsz3Pf/WmJN+XCGPXXhR99HuGYm0viLdN22SSFIDRqLabLJULFSmUEs9HqAb9iTHihvFvoSTrwnmyv0KXDI92Spr3xe/WnFinLPQpOfXJ4cAMWtGoorP3GCoeRA6hGD2flvGIuCaVpeVDDmPu904I5eOSG4uPUjmj/nO8DXo15pCQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24893500-a086-44dd-5efa-08dac88fcb11 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2022 11:35:13.8513 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: laVeFPvdr2JtIp1klM8/X785Xl2lwHo/4xLvtE7sdHiX547SjA6Pq98raznD3QcQ90EWPSyivX4iDaWKAAdKEpq3X/t0tUZRhbjZL50N1a4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6873 T24gMTcvMTEvMjAyMiAwOToyNywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE2LjExLjIwMjIg MTc6NDIsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToNCj4+IEN1cnJlbnRseSBYZW4gd2lsbCBwYXNz dGhyb3VnaCBhbnkgTG9jYWwgQVBJQyBOTUkgU3RydWN0dXJlIGZvdW5kIGluDQo+PiB0aGUgbmF0 aXZlIEFDUEkgTUFEVCB0YWJsZSB0byBhIFBWSCBkb20wLiAgVGhpcyBpcyB3cm9uZyBiZWNhdXNl IFBWSA0KPj4gZG9lc24ndCBoYXZlIGFjY2VzcyB0byB0aGUgcGh5c2ljYWwgbG9jYWwgQVBJQywg YW5kIGluc3RlYWQgZ2V0cyBhbg0KPj4gZW11bGF0ZWQgbG9jYWwgQVBJQyBieSBYZW4sIHRoYXQg ZG9lc24ndCBoYXZlIHRoZSBMSU5UMCBvciBMSU5UMQ0KPj4gcGlucyB3aXJlZCB0byBhbnl0aGlu Zy4gIEZ1cnRoZXJtb3JlIHRoZSBBQ1BJIFByb2Nlc3NvciBVSURzIHVzZWQgaW4NCj4+IHRoZSBB UElDIE5NSSBTdHJ1Y3R1cmVzIGFyZSBsaWtlbHkgdG8gbm90IG1hdGNoIHRoZSBvbmVzIGdlbmVy YXRlZCBieQ0KPj4gWGVuIGZvciB0aGUgTG9jYWwgeDJBUElDIFN0cnVjdHVyZXMsIGNyZWF0aW5n IGNvbmZ1c2lvbiB0byBkb20wLg0KPiBQbHVzIHdlIHNob3VsZCBoYXZlIHBhc3NlZCB0aHJvdWdo IExvY2FsIHgyQVBJQyBOTUkgU3RydWN0dXJlcyB0aGVuIGFzDQo+IHdlbGwuDQo+DQo+PiBGaXgg dGhpcyBieSByZW1vdmluZyB0aGUgbG9naWMgdG8gcGFzc3Rocm91Z2ggdGhlIExvY2FsIEFQSUMg Tk1JDQo+PiBTdHJ1Y3R1cmUgZm9yIFBWSCBkb20wLg0KPj4NCj4+IEZpeGVzOiAxZDc0MjgyYzQ1 ICgneDg2OiBzZXR1cCBQVkh2MiBEb20wIEFDUEkgdGFibGVzJykNCj4+IFNpZ25lZC1vZmYtYnk6 IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiBSZXZpZXdlZC1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBhbGJlaXQgd2l0aCB0aGUgaW1wbGll ZCBhY2sgaW4gdGhlcmUgcHJvdmlzaW9uYWwgdXBvbiBBbmRyZXcgYWNjZXB0aW5nDQo+IHlvdXIg cmVzcG9uc2UgdG8gaGlzIHJlcGx5Lg0KDQpJJ20gY29uZmlkZW50IHRoYXQgcmVtb3ZpbmcgdGhp cyBjb2RlIGlzIGJldHRlciB0aGFuIGxlYXZpbmcgaXQgcHJlc2VudCwNCnNvIEkgZG9uJ3QgaGF2 ZSBhbiBpc3N1ZSB3aXRoIHRoZSBwYXRjaCBnb2luZyBpbiBsaWtlIHRoaXMuDQoNCg0KQnV0LCBh dCB0aGUgbW9tZW50LCBJJ20gbm90IGNvbnZpbmNlZCB0aGF0IHRoaXMgaXMgdGhlIGVuZCBvZiB0 aGUNCm5lY2Vzc2FyeSBjaGFuZ2VzLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Thu Nov 17 11:41:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 11:41:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445135.700191 (Exim 4.92) (envelope-from ) id 1ovdHD-0003Hz-36; Thu, 17 Nov 2022 11:41:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445135.700191; Thu, 17 Nov 2022 11:41:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovdHD-0003Hs-01; Thu, 17 Nov 2022 11:41:51 +0000 Received: by outflank-mailman (input) for mailman id 445135; Thu, 17 Nov 2022 11:41:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovdHB-0003Hm-4F for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 11:41:49 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cec1fbf2-666c-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 12:41:43 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A48665C018F; Thu, 17 Nov 2022 06:41:42 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 17 Nov 2022 06:41:42 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Nov 2022 06:41:41 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cec1fbf2-666c-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1668685302; x=1668771702; bh=5Hp8B5ibzq9PE++sS2FmCLXLWnvRx0WKWkG DICvery8=; b=XLW2Y5LlGasq5/yW0AGCXIhwRQR01dr8Gg1ST7fCFUblQ/xp/Gs jGNz+xLMRbE4DtNzzfAGroV8+fgobWBJcjz8GNR4XpiaRtNuVjfHFta1iYUCwTtX N5m1fyR+LAhTZwh4llPsC3tFMR1xHYZ6Zk4IWxyB/6lNS0nRdSdKDJvpZBI2cq2R g6WbNhn+HCHP4x38xNOy3h3iQHYhjlRL72TBFjYgj/+m485nRdeShySBHIa2Qmjx GHhUFup7JtwPergDM38yApBR/QLtikhd8drBPuZ/GqILARp2HZ4Bxr3+t8Q60FRO HiEIKSE/uy/Gaa95atWIs7ltOID2r3xuiGg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1668685302; x=1668771702; bh=5Hp8B5ibzq9PE ++sS2FmCLXLWnvRx0WKWkGDICvery8=; b=t86OowYVgnKExhpiOft5nF5yLOuXL Ky7yp6hRfOzqzZ69nls2SqCmFZflynB5w3puHMW4ZO7c7h2HcoeuIjf/wO+f+c07 hAzwacA3IKTp92kFEjbBSD74oXHop3J2PRFxK6vaz5ZJIhISi9tN8knGiauvKOPz RIs0EfWtvMBcxcdIQY7DY3A0g9DHLC2jwKxvOF8gMxbnVsmZwGpHQ8ZB0k/dJe8/ +w+3wrb2Jaa7Dg+uWICnNe0Bc8zVyE2GFBWauAkI0u1b6pvOifyvOpf0kOJ+ruLw pFNxgzUOZDQvOJT8fOGLIS6eh8ilqNwD2QjF0k4vk1Khjykc4KVHQjDKg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgeekgddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffogggtgfesthekredtredtjeenucfhrhhomhepofgrrhgvkhcu ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepleekhfdu leetleelleetteevfeefteffkeetteejheelgfegkeelgeehhfdthedvnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR INTERFACE) Subject: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared Date: Thu, 17 Nov 2022 12:41:17 +0100 Message-Id: <20221117114122.1588338-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until the table is filled. Then it disables INTx just before clearing MASKALL bit. Currently this approach is rejected by xen-pciback. Allow setting PCI_MSIX_FLAGS_ENABLE while INTx is still enabled as long as PCI_MSIX_FLAGS_MASKALL is set too. Fixes: 5e29500eba2a ("xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKALL too") Signed-off-by: Marek Marczykowski-Górecki --- drivers/xen/xen-pciback/conf_space.c | 2 +- drivers/xen/xen-pciback/conf_space_capability.c | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/xen/xen-pciback/conf_space.c b/drivers/xen/xen-pciback/conf_space.c index 059de92aea7d..e8923bffc175 100644 --- a/drivers/xen/xen-pciback/conf_space.c +++ b/drivers/xen/xen-pciback/conf_space.c @@ -313,7 +313,7 @@ int xen_pcibk_get_interrupt_type(struct pci_dev *dev) &val); if (err) return err; - if (val & PCI_MSIX_FLAGS_ENABLE) + if (val & PCI_MSIX_FLAGS_ENABLE && !(val & PCI_MSIX_FLAGS_MASKALL)) ret |= INTERRUPT_TYPE_MSIX; } return ret ?: INTERRUPT_TYPE_NONE; diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xen/xen-pciback/conf_space_capability.c index 097316a74126..5c851f916ebc 100644 --- a/drivers/xen/xen-pciback/conf_space_capability.c +++ b/drivers/xen/xen-pciback/conf_space_capability.c @@ -242,6 +242,10 @@ static int msi_msix_flags_write(struct pci_dev *dev, int offset, u16 new_value, if (int_type == INTERRUPT_TYPE_NONE || int_type == field_config->int_type) goto write; + if (int_type == INTERRUPT_TYPE_INTX && + field_config->int_type == INTERRUPT_TYPE_MSIX && + (new_value & PCI_MSIX_FLAGS_MASKALL)) + goto write; return PCIBIOS_SET_FAILED; } -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Thu Nov 17 12:29:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 12:29:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445174.700202 (Exim 4.92) (envelope-from ) id 1ove0l-00005E-8O; Thu, 17 Nov 2022 12:28:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445174.700202; Thu, 17 Nov 2022 12:28:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ove0l-000057-5U; Thu, 17 Nov 2022 12:28:55 +0000 Received: by outflank-mailman (input) for mailman id 445174; Thu, 17 Nov 2022 12:28:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ove0j-0008VW-QD for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 12:28:54 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 63fd69aa-6673-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 13:28:52 +0100 (CET) Received: from mail-dm6nam10lp2105.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 Nov 2022 07:28:48 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6395.namprd03.prod.outlook.com (2603:10b6:303:122::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Thu, 17 Nov 2022 12:28:47 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%5]) with mapi id 15.20.5813.020; Thu, 17 Nov 2022 12:28:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63fd69aa-6673-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668688131; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=o1Of7SasIvL4zjj/d+LU0bHmOfJWM7Blc34WEI87rO8=; b=F+A+GwIX+j0MjLtnVXFeXSiC28uwlAjo7+OTB22WlOEb+Wnjae7Ja7GG 2k33ou2i8pyi9DSycIZHNSge9dfDChCQkoR0tAAwX8H5n4NxqOlLslfn8 /ND73E3qbBfG5S94069x3re9kkADvEDjRztEN6HXOElxtIJYHwN1I7l10 c=; X-IronPort-RemoteIP: 104.47.58.105 X-IronPort-MID: 85021016 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:sZzEqq2Agk5okDwm8PbD5WBwkn2cJEfYwER7XKvMYLTBsI5bpzZRy WQXX2iDbKmIY2Wkeoonaojg9RsOu5HdyN82GlFvpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVnOqgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfLSZU+ tc9EW40UR2hwOe5/LGcFsNBr5F2RCXrFNt3VnBI6xj8VK5jbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6KlFEZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXOmANhLTOTmnhJsqGyRz2M4BEYRbweipeeL0kGsZ8pnK nVBr0LCqoB3riRHVOLVWhSipXeesx00WtxOEvY74gWA1qrV5QmCAmEOCDVGbbQOsM4wWCxv1 VKTmd7tLSJgvafTSn+H8LqQ6zSoNkA9L2AYYjQfZRAY+NSlq4Y25jrUVcpqGqOxitzzGBnzz iqMoSx4gK8c5eYM06i45lnBjyibuonSTgU16wPUWUqo9gp8IoWiYuSA61LW8PJBJ4axVUSas T4PnM32xPADC9SBmTKARM0JHaq1/LCVPTvEm1ltEpI9sTO39BaLYY9U8Bl6JUF0LtwDfz75J kPe0T69/7dWNXquKKNyPYS4Dp1yybC6TIy4EPfJctBJf559Mhed+z1jblKR2Garl1UwlaY4O tGQdsPE4WsmNJmLBQGeH481uYLHDAhnrY8PbfgXFyia7Ic= IronPort-HdrOrdr: A9a23:x9MIZ6ljuVx2X2z7NV8e/lmEMFLpDfMEiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJLqDhSC2R8acjVXhZMv63 LMnQDV7riq96jT8G6c60bjq7Bt3PfxwNpKA8KBzuATNzXXkw6tIKhxRrGYuzgxgee3rHInis PFrRsMN9l6r1nRYma2ix3w3BSI6kdh11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza NixQuixtlqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bWDHAcEcYa xT5fPnlbFrmGChHjbkV65UsYWRt0EIb1O7q445y5SoOnZt7StEJgAjtbEidz87he4Aot9/lq T52+1T5c9zpoV9V9MDOM4RBcSwEWDDWhTKLSabJknmDrgOPzbXp4fw+6hd3pDiRHUk9upEpH 36aiIviUciP0b1TcGe1pxC9R7ABG27QDT208lbo5x0oKf1SrbnOTCKDAlGqbrqn9wPRsnAH/ qjMpNfBPHuaWPoBIZSxgX7H51fM2MXXsEZsssyH1iOvsXIIIv3sfGzSoeaGJP9VTI/Hm/vCH oKWzb+YM1G80CwQ3f9xAPcXnv8E3aPia6Y0JKqitT75LJ9RbGk6DJl+GhRzvv7WQFqo+gxYF Z0Jq/hn+eyuXS2lFy4nVlUBg== X-IronPort-AV: E=Sophos;i="5.96,171,1665460800"; d="scan'208";a="85021016" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hky2llobSglHuLR2C+eV8cHUIuC8wfLG1FD9LeIQrYtrNLUXvHj5U4bMNS8Gl1lWltNEVsUSKaXQrPh6RzqB1iqSBL/yh4JsIRkR0h7//3qy2MgZY4VNC/RLwECUTZamoRX4rmzfZ1SP7qKDxEdffEyWlVd1Q1axvY+40Svx0gPOLzsNYPKNzZV/p8Npkh0bLjrC3DocW9MzEnFVW1QRpZ2MbuGU3KfIUHr1bfH0Ka6XwnJtPChjxlCyUvc51TIHd9AvseXx3CvGhyM7qPJQzZQRGaagPKue4qghj4aQYh5H42bNIO5wiu/xQ/nGBnSIe4CQxsiMK0Ftk1IbvrADyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o1Of7SasIvL4zjj/d+LU0bHmOfJWM7Blc34WEI87rO8=; b=gX8iHtN9vx/feTu8TPUcU5sgMiqK9F/3WXE02gaKJAgAbFKzsw6GlEu7B7/jM7kK7UJlsSDZsGwLdnuNWN25Gu3PB2R4BcF8N/MXtpzPA+JZWNzLdy5lvV+0PN1R6iy/Q5ERfCcVOWNWLuF09LtOJkL9hZ0P7w6qaFTEpgTyV5qCt1JhQOLjgAf346Rx/GERn03DQeE93LLCdUuJGNVwMq38V/HfUM4DH4Ne/gcgTL5vsU8JEIsrcbiAbqdGKwLVYIIBaMulTvGA6OnC1+Y7+y+fEojy0IZ6Lq0HpKFRoItBo2zS+nEy/yoxpC7fjBMHnyvfxpUZ2gDNbhbfZcvJkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o1Of7SasIvL4zjj/d+LU0bHmOfJWM7Blc34WEI87rO8=; b=FY4Hjzhrk6ih1XOMCpeRESpzMreYmIpKZwSepyL9Eykftk4OOBEqgmagC4wbZvutwcsm83KODlBuWG+oxMElXVcK6G+Zt0G7o49IP3SEHoo11F9mHB9qpoATHT/Matix7QQqsxk//GYAxxYxBRFLSlGBC22DO9gOJEK7f2Vh5wo= From: Andrew Cooper To: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , "linux-kernel@vger.kernel.org" CC: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" , Thomas Gleixner Subject: Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared Thread-Topic: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared Thread-Index: AQHY+nmitCFszY02+EavJ4U+R9Py8K5DC1MA Date: Thu, 17 Nov 2022 12:28:46 +0000 Message-ID: References: <20221117114122.1588338-1-marmarek@invisiblethingslab.com> In-Reply-To: <20221117114122.1588338-1-marmarek@invisiblethingslab.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MW4PR03MB6395:EE_ x-ms-office365-filtering-correlation-id: 9ea922b8-1b9c-4624-5c59-08dac8974621 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a6aXv1yVbkkbZ+OIk6YalTjkFUitW0wbYEQ3AhDUqTx0hDf1+0OqM/IvAjlYCTz2O5YmW3nTj6MnhID4LPytlEXn2nxwbiqBqSE3isddC3e0jZ6Aik8LOxQAumbjGngqPeNc2Z9HXbiuOhYZ9Z4WwFiMKGmnc8TpZoFodxFMd+rY2VfbPKQzIYgKDuck901hKUiAGtTjsrXIIK/TaypggddGFsvZaZ2X2NZa9cbrEY6/Iq7bTjUPWOmzAZ04jDyOTjw9AwLgAcD9n2UTjZKNHAbD25I66JULNjurQ0blGK/jM7dMDUtWeXbTCY1/g//l8/mXRIijs/bDFWaMBpb2+35xKerD7mBVILu50kHhUSIKGG/2rizuf1+B52I0u1dI76QY8oapJihBJDZjCmX0SztiWfkeRsd74MGSSLvVjmc8R9taJcEC4Wl3gz0p61hoRhFspRVE7OY6s3ejKsP0aklWW+AHVlQLMjc7ulZ0LSRiZMoS6aH4bd6eHaV/Kne8g7npcl/gkHF+BG3Dk6aSnBCX1xPxh8odyHa8c66ytXKSfbV4Wa4BaT5g4eigzvq4X8APXB24NwIelT9R44rAHbxWgZpgg+1eqT09wEPsGTq35AKOjztGk0TmwOE7VtUKtb64oB2RlAoSIBbPSAtooZCyPe2EGOPsugeoiqjerTl46+N9Pc24dmYOOTrOrGU/Bgy8AEN5UY1DwFrqmOargHNvFtus1OzM9fL/0S5Ka6j5TSzUfelb02EDLkwAXeWna1vOAUWDVRCIAf31g4vhqA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(136003)(376002)(366004)(451199015)(2616005)(64756008)(86362001)(31696002)(4326008)(186003)(8676002)(76116006)(66476007)(66946007)(8936002)(66446008)(91956017)(66556008)(478600001)(5660300002)(36756003)(41300700001)(6486002)(6512007)(6506007)(71200400001)(110136005)(26005)(66574015)(54906003)(4744005)(122000001)(316002)(53546011)(82960400001)(38070700005)(38100700002)(83380400001)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aTF5bTNnT2dWRWNTTjlhck5JNXdiandrMFN1R1NVN3hKOGJYOTJHR3hwNnY0?= =?utf-8?B?R0JxcEZ4WEdNeWhCeCszSTFOYTMwZ3kzSXhqRnFSWFNncmNrK1ZCdnU2SUh0?= =?utf-8?B?Qjd5dUw2U1EwSzFhRFNoRzk5Tm1jTjFNUWYzZFZVS3hZZEZuNllXSU1uNm9U?= =?utf-8?B?eE9IRHk2UFRRRHJhL1YyL0RoN3kzL2hFZnN2UTk0c05HM1pQZXpiTVI2bHhj?= =?utf-8?B?QlJnYnlCRk9mTzkrbWxzM0x2RXRpMjJ6NGYybHdRTlNNR0Q0SkY1OWdYNFlP?= =?utf-8?B?clJNVU9na3YrTnRYd0sybElhRTdZbmxUazZJV244RnRtUzhzbE9QMzY3dXN3?= =?utf-8?B?UzlJZlhVdy95b3R6dHBycWsrRkcrOERYb1ZsYzBpVVRyTDROOWQ1ZkxhWVhz?= =?utf-8?B?b1hzei81UUJ4V1dnWit4ajRNY2hxQk1WVDMwaVhRNFI0cmd5bC9UbnFVdHUy?= =?utf-8?B?WHh6R2twTUF2bDVrT1h5M0lEa2IzUlNtV1hBOFlBS2ljRnBkL2RoaEFObk92?= =?utf-8?B?dHFiVjRONzhQVUVkRGttblhBZHl4N1dXcTNDWXhzMEhWcFB3bUVJTGZlc21V?= =?utf-8?B?WTZ4SnBqN2MwOU9HMjRldlhsMGFoM1ZFUWlpaVhzSGhJQkNaTEsrY3dtcEth?= =?utf-8?B?TzFzNHJZTDVzeXJnZit0UGU2TGxXcm5tOGw3MWVrTVBnZEphNzh0bUxmSXps?= =?utf-8?B?bG8rR0Qvd0s3R2hvc0FMWDltZC94eG5MODZJRCtxZGZIYysvN1UrcjJJV1N3?= =?utf-8?B?enk1eFFWUUdTMk9WOUF4ZFJMRVZDVFNCVDhjM2ZpL2pNWXNzWEVkU1ViM3RW?= =?utf-8?B?MkZudTJYMGhDRzljY1RrVlZibXI2d2tLL0RvNWcwMVB2cCtJSU15M0JwYjdB?= =?utf-8?B?L01VNFdWbG9nWXN1VGVxK1IxdWVBeHJ4YTBsQU9aZzl2WUFoSmVkYW9nZ21G?= =?utf-8?B?YzhyRWlNa1Qxd0JNSTdFbUNzTDBCMHFicmUxOHMvQmFNS2lxWGtVVHBHTHky?= =?utf-8?B?aUZFM2R4NzlMYnJlYzcwa2VKS2k1RlkwNXNXR2t5S3JhNmlQS1I4NzhEKzVN?= =?utf-8?B?bDA4THlFd3FvTnVBR2pGTkdPcVhmMmNZMkRtVmF3aEkxYm1maXNDck9WaXZ1?= =?utf-8?B?ZGozK2dDOENYeGpaRnBwTVpNQ1ZubE0vcG9hTVVxMzRqNEFEeWszaHoySUpp?= =?utf-8?B?NnROYUk5dm5qQWVIYndiTVI0RG15T2dPcGF1WWVaMHViai9NckordlNEcWVi?= =?utf-8?B?V3hyRnk2dEhLU1Q5Z3k3emFOUVk2TVJHYnhScUUzL05NZ0VCMnN4N2t6ajdZ?= =?utf-8?B?cnVQdE13T20xWFhTdW1qc2pPZ0djclhRaHFMbDAzdTBGUVFXQ3hxZTJBVVFQ?= =?utf-8?B?NzN4V2p2dFFuSE5Panc1U0NKaGxSWXgrbmVoc1J0djQ4M3NXUFVYVjNFZGZE?= =?utf-8?B?WDBUaXVQWlQ1MHhMS1RINFZ2WmZhaWUraHNlRGdOL3dtYW1LQjEvZlhzMWtX?= =?utf-8?B?N2xiNjRpNU1PZkg4Szd5Vmw5a2ROZVR6c1JJais1dGlWNjFyU0NLaUlrL0Vw?= =?utf-8?B?aVUrR0dEZmJsZlFGRDBJbGwyejVTcVdBY3l1TW1jaUxhZjVzbGlhUFExeFJs?= =?utf-8?B?bXMrWVpkMkhvUC9lbXE2YUpFR3Q4dm41OHFLNlA5Y1l1Q2pSUzRjRzBGbWFJ?= =?utf-8?B?clY2WFZjS1J2blpLRnlGcDN6dXBROFAyUUdsLzZXRmVyQkNvamloUjI1NXhn?= =?utf-8?B?ME15eENiV1V5Sk5LMTFXOUkzcnVieHFrSHVvcEJZNStwc1VTRmV0RjRJTE1l?= =?utf-8?B?YkxScGs3emUvZVpXUnhsUEprZDlsYnBYWDkzdjQzYy9IZmI4VWw5K2FxeFRI?= =?utf-8?B?Vnp2S1VzWUxnb1hMcXo5OG5PVGhxT0ZqMEs5WlVsWXRBMlBCVzNNRUd1d1I1?= =?utf-8?B?T2tCS0hma0hpM2ltYjZERDkwbCtEaXFSYnI0QW5pcXY1UTE5T0lvSzNaejJ1?= =?utf-8?B?QzBuUHcxY3RzcitoUm16ckdRQStVd2cweXd5QnBOV3A2OXpWQzdQSjR4WjNY?= =?utf-8?B?aC9IRW5qOTVtZlZxZFR6Q3FWaDdDQ1U3RVBtRXJPTWd2WGQyS0NYRXRGYis2?= =?utf-8?B?THJnSktncHFmRUNyNzlUeUxHQ3FvNnU0TE5Wb2pXRXpFTktacnpFdmNPM3Ns?= =?utf-8?B?ZlE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?dk11Q0YvQmpReWdYd3QxWncxSllpUUxtUmZMS3BhdjB3ZlJVQU8ydFpvaXpy?= =?utf-8?B?alREL01wQWtBbXBKRURIWlQ5VnU2OTJjQnJEM1F6OVU4WGJBckl5Y3RXQWxy?= =?utf-8?B?U1ljZVJHM0ZTWlVZTnhEcXFsbTY3QzNESnRKMHY1T2ZJY3llL1ZxOVJ3TXIy?= =?utf-8?B?clpIa21hWWlhSWVhL3pka1g3eGNnMExlSmEraW5HS3plUDM1VjZTcTVaREYw?= =?utf-8?B?T1ZoK1hQSDZtSEJJL3drWjdoTXZ6Zkx5WTlSWENTOVNscGp0QXNlQXlyWm85?= =?utf-8?B?YmhVK3FleXBNK2pTcVNEcHlXY3RpYklsOTFObjZyeHFOaytONXUrUVBSdmtR?= =?utf-8?B?MTI3ZkJZSlR4WlllY1M0Z0RpZ0tPUDJYZ1FaODNVUzlmZG1hZUV0bEI1Tzgz?= =?utf-8?B?b1VmWEhZbytEQlZUWS9jRkcwbkpwV1ZsWlVDWFVCNWFMSGtrQTRpSFZBa1Fa?= =?utf-8?B?ZzY4TElDVERLQUdDVExoUks0TDJCVG5DWm1QRkYxL3RJZTI2MENYWGdyQlJp?= =?utf-8?B?RnVJNUl4MUlQZVZVMlRFd2NUV2lkQS9pQWpZVGxVMmdMNzlrQzRPUEFFRWxk?= =?utf-8?B?RWo2aS9DcDU4MllVQk83WEV6RmxnN2pXMFNtZFJUbnZHL1RsTkdaZnBWMDZa?= =?utf-8?B?V3k2S0dnZEptTGlpY2lJeXpWcGJhbFIvU3MxY1RQdEdPcnBsQzZoaUtQdVZa?= =?utf-8?B?OWE0bzFqOHhwVmZiZkF3OVY0VnpKOFFmOVlpSlUxbWpMcG5GckZ0aDNvcm56?= =?utf-8?B?MUxoSEJUSURTM2pZVmRON1RONS9oRmFvYkFZV0E5dlBvQUxYQlU3a3VyUGl1?= =?utf-8?B?cVlxNHd2UDhwR0ZqTVVLQmdwZFBSUFdaQ0svQzY0SVhPMDZ0bG1mQ09mNngr?= =?utf-8?B?TDhiOGFQSDFEczVqUHRFcjdKZHE1cngxdXFmQWFldXMyODBKQURYQW1ya3dh?= =?utf-8?B?Y3NzUGFNa1pHSVo2anVRelE3WHYwTUt5RGYyNy9YbFQzbnVsSE4zVGFPQjBv?= =?utf-8?B?dFdqSXYyL21jZmpBR0tWcmIxdjJ2RnZaRW41bTdtdU83NWkwdjhaazZtSENz?= =?utf-8?B?MEVMQWJRM3BrMzRUdzZrb2x4UU83ZnNYSXI1REtEQnBYRXF1WjB3UnRhM2pP?= =?utf-8?B?UGpuRHdIOHRzd2MyZXZkVVdZd0NxdWIxMGw4RHdiajQwbi9aemNKaUJnZkN4?= =?utf-8?B?MmdIRXpESVVrTlpxbnJzbHFTODZEY1dUZ3pnZFM0MDQ2VUV0OVJ6S3Q5ZWdz?= =?utf-8?B?b2V6Q1BLeFZtTnZiR1ZkM0puTW5FUUlpQy9oMUNYNjhoSHFqaUNoZHBURDRo?= =?utf-8?B?blJZdCt1amdVUGI3Unh2WTUvTzJhQ24vR2hoVlkyR0M4MllkbjNQaFlWNE91?= =?utf-8?B?NXN6OGZVWGduTHc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ea922b8-1b9c-4624-5c59-08dac8974621 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2022 12:28:46.7929 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E3myUmIeg/AE+qTIpAdc39HKto8w5oDvuDmM/wWlIifvP9mbA/PzklK7z2UFxcyR3snkfOA8Byo3na+U/ZmZLFegt3xIZZi2xOG4VZe24Ek= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6395 T24gMTcvMTEvMjAyMiAxMTo0MSwgTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIHdyb3RlOg0K PiBMaW51eCBlbmFibGVzIE1TSS1YIGJlZm9yZSBkaXNhYmxpbmcgSU5UeCwgYnV0IGtlZXBzIE1T SS1YIG1hc2tlZCB1bnRpbA0KPiB0aGUgdGFibGUgaXMgZmlsbGVkLiBUaGVuIGl0IGRpc2FibGVz IElOVHgganVzdCBiZWZvcmUgY2xlYXJpbmcgTUFTS0FMTA0KPiBiaXQuIEN1cnJlbnRseSB0aGlz IGFwcHJvYWNoIGlzIHJlamVjdGVkIGJ5IHhlbi1wY2liYWNrLg0KPiBBbGxvdyBzZXR0aW5nIFBD SV9NU0lYX0ZMQUdTX0VOQUJMRSB3aGlsZSBJTlR4IGlzIHN0aWxsIGVuYWJsZWQgYXMgbG9uZw0K PiBhcyBQQ0lfTVNJWF9GTEFHU19NQVNLQUxMIGlzIHNldCB0b28uDQo+DQo+IEZpeGVzOiA1ZTI5 NTAwZWJhMmEgKCJ4ZW4tcGNpYmFjazogQWxsb3cgc2V0dGluZyBQQ0lfTVNJWF9GTEFHU19NQVNL QUxMIHRvbyIpDQo+IFNpZ25lZC1vZmYtYnk6IE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSA8 bWFybWFyZWtAaW52aXNpYmxldGhpbmdzbGFiLmNvbT4NCg0KVGhlIFBDSSBzcGVjIHN0YXRlcyB0 aGF0IGRldmljZXMgYXJlIG5vdCBwZXJtaXR0ZWQgdG8gdXNlIElOVHggd2hlbiBNU0kNCm9yIE1T SS1YIGlzIGVuYWJsZWQuwqAgVGhlIG1hc2sgc3RhdHVzIGhhcyBubyBsZWdpdGltYXRlIGJlYXJp bmcgb24gaXJxIHR5cGUuDQoNCklOVHhfRElTQUJMRSBleGlzdHMgYXMgYSBib2RnZSB0byBtZWFu ICJJTlR4IG5vdCBwZXJtaXR0ZWQgZXZlbiB3aGVuDQpuZWl0aGVyIE1TSSBub3IgTVNJLVggYXJl IGVuYWJsZWQiLCBhbmQgZXhpc3RzIGJlY2F1c2UgaW4gc29tZSBjYXNlLA0KdHJhbnNpZW50bHkg ZGlzYWJsaW5nIE1TSSBpcyB0aGUgb25seSBzYWZlIHdheSB0byB1cGRhdGUgdGhlIGRlc2NyaXB0 b3IuDQoNCg0KSSBjYW4gYmVsaWV2ZSB0aGF0IHRoaXMgY2hhbmdlIGZpeGVzIGEgYW4gaXNzdWUs IGJ1dCB0aGUgbG9naWMgc3VyZWx5DQpjYW5ub3QgYmUgY29ycmVjdCBvdmVyYWxsLg0KDQp+QW5k cmV3DQo= From xen-devel-bounces@lists.xenproject.org Thu Nov 17 12:53:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 12:53:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445184.700212 (Exim 4.92) (envelope-from ) id 1oveOK-0003l3-6q; Thu, 17 Nov 2022 12:53:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445184.700212; Thu, 17 Nov 2022 12:53:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oveOK-0003kw-4C; Thu, 17 Nov 2022 12:53:16 +0000 Received: by outflank-mailman (input) for mailman id 445184; Thu, 17 Nov 2022 12:53:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oveOI-0003kq-N5 for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 12:53:15 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20611.outbound.protection.outlook.com [2a01:111:f400:fe5a::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ca923a79-6676-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 13:53:12 +0100 (CET) Received: from MW4PR04CA0218.namprd04.prod.outlook.com (2603:10b6:303:87::13) by CH0PR12MB5091.namprd12.prod.outlook.com (2603:10b6:610:be::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Thu, 17 Nov 2022 12:53:08 +0000 Received: from CO1NAM11FT011.eop-nam11.prod.protection.outlook.com (2603:10b6:303:87:cafe::3f) by MW4PR04CA0218.outlook.office365.com (2603:10b6:303:87::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 12:53:08 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT011.mail.protection.outlook.com (10.13.175.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 12:53:07 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 06:53:05 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 04:53:05 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 17 Nov 2022 06:53:04 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca923a79-6676-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L7MIluPC2N1tEe/rw0xbwLePG+rGOF5EP+f9rVVxG+9IxET/w1FrMgbZ9FSv9hMyhfj/3bGdB8dJWPx2qyXicK+G41Tf2WYcYJ+fWHFb+Fl+KOD5REYjwbSbHPGvwx9qcD9lX309gL6ZX3AYjO7Lx8MEUPnGnY0YQqFpETSpBUpbamIr4DZxhTWUEslb47llGV/pq4S/UABc54dGxc8zzxJOtlEf2cdUzTyr+vaNr/TpIit1BMxiIoB2p9J+AQ6Kt1TKLtAUxWdAsC2eE36uE0qRd0+B21FOpG3Rau2B50fCpj6mLYdCrFpGsHTRk4S+cDz+1Q8kz4V3WB9dxRknkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uxaueBbt+ug6bZg7jAtJPvJ/n/hUBpII6MXs3vj6wFk=; b=eV17p+JUk2j2uhpM3cnXL2j6/IwKwMgTRRiLN/ekm6qnblolJHODeEcPOnGX6aehfuKu91ys/b1bFNKtbxhlybQErm5AKuzlFdYkhEKNJ6yssqFHdyVZDADE0Z6j22dunUt65hn/HjkUrZnLMi+ThhXnHmbwVFLQQAJCZK28Dls2TJNe2mCH70LZqXbCj0IzyC4EZZ3NcgJY4j4gCBdwikGZIITA0KJB5GQIkktEndWGegYvhdvcMMK2dSRWZAPV4E0oiY7qVu1WqmXjRDnDxQYXcjgwLXP8MkWn45csdXr9f30YepWnexdvS3nesAMhVAL3iz+r6HZdqmre6heLGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uxaueBbt+ug6bZg7jAtJPvJ/n/hUBpII6MXs3vj6wFk=; b=krAfZNhwMNITBz//Or3NPq665QDiv5SwwCuBszmvkqCm/Lz9/WmSgpDkrlTg+Pj3FImqkg2Y3MSJP8FDfFKD2GK+Epm96Lr76PPWoNXn8xHmHvIWsIMytAnf0WFxa/i0wiM7dbHkNzHdNh2hVwameXO5Bz5K09U9+Jeeadcrimw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Thu, 17 Nov 2022 13:52:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Content-Language: en-US From: Michal Orzel To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> <0400b2d8-6f2c-6406-d966-64ed5720688c@xen.org> <350afafd-821c-1a05-13cb-1704d3a61bfc@amd.com> <84710d96-c473-fa41-d847-2b109dfb49c9@xen.org> <85f4f42b-b1ee-36bf-5ba9-21b1047351cf@amd.com> <7d3f9021-d608-9e8f-9593-1099d7bd2003@xen.org> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT011:EE_|CH0PR12MB5091:EE_ X-MS-Office365-Filtering-Correlation-Id: c0658657-9e4f-4de6-247c-08dac89aad1d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iQNBLH9gES1TozQCR6A/uWPsPn/8TBq4H1gu/u6YvaAADUQV3Nno7womSyKCrXcQ0JP8OMWvAfrkWGQHwCMYsPHufO3Ew/xMr9zu/ByEqL3rpnSqnSuVcGqFodPuYVYmkiQho5LMAwGZR+LpGhwzc5iiLE7NLdI/hiCb6iVLabt3CDQjAPipKmgotKP75L2W9256gqLP9GNRZu2nYrxRaS0xs/hKnqoz59Bnr3lYYIpnfRwR3lMK1IAaOLj+qieWpHQgge3ixiigRYFBKLeD4oMWuDqB47qv2YhG5diHqaO+m5fzNIOn7KYQ9sEbg1BuIM6KpVXbFEU8KYQv7pFe6qXsdUUVN+GeD4xU1sG3pDQ/uFtphQgABLv8j6uuo1nDaKnVpEq4NVUM/wjufRsPDvgXAye3awttZ5tWdXHePw2pxsyg+ZUn6l14HJiiVimQXrmlCnefnTCGhFXl6ddFvfS4v9D5X5SEQB66Ak+I5pW8gHhpZ+63fnnOUMa3D0ukLTwy6dWGzvG9d01IdMuLDkx4DmShNjOtgKlfBs9F9DAMF/yR3wRe7gF1p2luaW7iSxmnYi+2kgom+yRwvJB8iYeUJbo0QMcMGtm2TpQew5zTAr0KhMx4xIzpLRWfwJ9GmD67RyguMOiHoo7bq0LwiS29HGw2qQv4c1YArm/usGAV4AValiFqAE+5ckTEttmcD9zK/AfTuaPS9BhrrmcoCVqccHbrYS/LWFiOcJzXA48NU24PUBgx02Zpg78SmoU7oKn6Hd6DemN7VrJ182sXj9XA59fzn1LwnZpumxl2jgU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(376002)(396003)(451199015)(46966006)(40470700004)(36840700001)(86362001)(31696002)(82310400005)(40460700003)(36756003)(40480700001)(356005)(41300700001)(2616005)(70206006)(70586007)(4326008)(8676002)(44832011)(426003)(186003)(8936002)(47076005)(336012)(5660300002)(45080400002)(6666004)(478600001)(966005)(316002)(16576012)(26005)(54906003)(110136005)(53546011)(82740400003)(81166007)(83380400001)(2906002)(36860700001)(66899015)(31686004)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 12:53:07.9827 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0658657-9e4f-4de6-247c-08dac89aad1d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT011.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5091 On 17/11/2022 10:53, Michal Orzel wrote: > > > Hi Julien, > > On 17/11/2022 10:29, Julien Grall wrote: >> >> >> On 17/11/2022 08:34, Michal Orzel wrote: >>> Hi Julien, >>> >>> On 16/11/2022 19:37, Julien Grall wrote: >>>> >>>> >>>> Hi Michal, >>>> >>>> On 16/11/2022 18:05, Michal Orzel wrote: >>>>> On 16/11/2022 16:56, Julien Grall wrote: >>>>>> >>>>>> >>>>>> On 16/11/2022 14:45, Michal Orzel wrote: >>>>>>> Hi Julien, >>>>>> >>>>>> Hi Michal, >>>>>> >>>>>>>> >>>>>>>>> and use it in the pl011-debug files (+ there is a question whether we should define WLEN_7-5 for completeness). >>>>>>>> >>>>>>>> I would not define WLEN_7-5. That said, I wonder if we really need to >>>>>>>> set the baud rate & co here? >>>>>>>> >>>>>>>> AFAICT the runtime driver never touch them. The reasoning is the >>>>>>>> firmware is responsible to configure the serial. Therefore, I would >>>>>>>> consider to drop the code (setting UARTCR might still be necessary). >>>>>>> I do not really agree because the current behavior was done on purpose. >>>>>> >>>>>> EARLY_UART_PL011_BAUD_RATE is only used for very early debugging (this >>>>>> is protected by CONFIG_DEBUG and CONFIG_EXPERT). This is not a >>>>>> production ready code. >>>>> I am fully aware of it. I just found it useful but I understand the global reasoning. >>>>> >>>>>> >>>>>>> At the moment early_uart_init is called only if EARLY_UART_PL011_BAUD_RATE is set to a value != 0. >>>>>>> This is done in order to have flexibility to either stick to what firmware/bootloader configured or to change this >>>>>>> configuration by specifying the EARLY_UART_PL011_BAUD_RATE (useful when you do not know what >>>>>>> the firmware configured). >>>>>> The chances are that you want to use the baud rate that was configured >>>>>> by the firmware. Otherwise, you would need to change the configuration >>>>>> of minicom (or whatever you used) to get proper output for the firmware >>>>>> and then Xen. >>>>>> >>>>>> Furthermore, as I wrote before, the runtime driver doesn't configure the >>>>>> baud rate. This was removed in Xen 4.7 (see commit 2048e17ca9df >>>>>> "drivers/pl011: Don't configure baudrate") because it was buggy and this >>>>>> code is not simple. >>>>>> >>>>>> So it makes no sense to configure the baud rate when using early printk >>>>>> but not the runtime driver. >>>>> Ok, so we will get rid of EARLY_UART_PL011_BAUD_RATE config and setting the bd >>>>> in the early uart code. Now, what about setting "8n1"? The runtime driver sets them >>>>> as well as the early code. It can also be set to a different value from the firmware >>>>> (unlikely but it can happen I think). In any case, if we decide to do what the runtime driver >>>>> does, I reckon setting LCR_H should be kept in early code. >>>> >>>> Good question. I think, you would end up with the same issue I mentioned >>>> above if the firmware and Xen have different line control registers >>>> (tools like minicom/screen would ask for it). >>>> >>>> So I am on the fence here. In one way, it seems pointless keep it. But >>>> on the other hand, Xen has always set it. So I have no data to prove >>>> this will be fine everywhere. >>> If we are relying on the firmware[1] to configure the baud rate, it is not very wise >>> not to rely on it to configure the LCR. Looking at the other serial drivers in Xen, >>> we have a real mismatch in what is being configured. Some of the drivers (omap, imx), >>> apart from setting 8n1 also set the baud rate explicitly to 115200 and almost all of them >>> do set 8n1. In that case we will not benefit too much from fixing just pl011. >> It is not great that Xen hardcode the baud rate (I can't remember >> whether there was a reason), but I don't think the consistency is >> necessary here (see more below). >> >>> >>> On the other hand, Xen follows the zImage/Image protocols for ARM [2] which do not >>> state that serial port initializing is something mandatory. This could indicate that >>> the firmware does not really need to configure the serial. >> >> The firmware doesn't need to configure the serial and yes in theory Xen >> should configure the baud rate and parity based on the firmware table. >> >> However, this is a trade off between complexity and benefits. The patch >> I mentioned earlier has been removed nearly 6 years ago and I haven't >> seen anyone reporting any issues. >> >> Hence why I think for the PL011 it is not worth looking [3] at the baud >> rate and instead removing it completely in the early PL011 code as well. >> >> That said, if you feel strongly adding support for baud rate then I will >> be happy to review the patch. > I'm not in favor of this approach either. That said, I will prepare patches to remove > CONFIG_EARLY_UART_PL011_BAUD_RATE and its usage in early printk code as we agreed earlier. > As for the LCR setting, I will keep it in early printk code to maintain the same behavior as > runtime driver who sets them. Actually, there is one more thing to consider. early_uart_init, even though it also sets LCR apart from the baud rate, is called when CONFIG_EARLY_UART_INIT is set. The latter depends on EARLY_UART_PL011 && EARLY_UART_PL011_BAUD_RATE != 0. If we remove EARLY_UART_PL011_BAUD_RATE, we need to decide when do we want early_uart_init to be called. It is defined only for pl011 (it is also defined for meson but this is an unreachable code, as EARLY_UART_PL011 is 0 for meson), so we have the following options: 1. Redefine CONFIG_EARLY_UART_INIT to be CONFIG_EARLY_UART_PL011_INIT and mark it as n by default 2. Keep CONFIG_EARLY_UART_INIT so that future drivers can use it (?) and mark it as n by default 2. Completely remove early_uart_init > >> >>> >>> [1] It is not stated anywhere in our docs. >> >> Our docs are not perfect. Patches are welcomed for improvement. >> Although, I think the statement should only be for driver where we don't >> set the baud rate. For the others, we should leave it as is unless you >> can prove this is not necessary (we don't want to break existing setup). >> >>> >>> [2] BTW: our docs/misc/arm/booting contains invalid links to the kernel docs. I guess >>> this wants to be fixed. >> >> Patches are welcomed. >> >> [3] I do have a large list of more critical bugs that I will be happy to >> share if you are looking for improving Xen. > That is cool and such list would be great for everyone having some spare time (+ newcomers). > Taking the opportunity of having a GitLab CI epics, I think it is worth adding such work items here: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fgroups%2Fxen-project%2F-%2Fepics%3Fstate%3Dopened%26page%3D1%26sort%3Dstart_date_desc&data=05%7C01%7Cmichal.orzel%40amd.com%7Ce2f65ddb895243bdb9cc08dac881acba%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638042756535884326%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5Hf%2BXW3nogjzasoTQ821OPAjJLJVVofyGpb0LNxRAto%3D&reserved=0 > >> >> -- >> Julien Grall > > ~Michal > ~Michal From xen-devel-bounces@lists.xenproject.org Thu Nov 17 12:55:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 12:55:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445189.700224 (Exim 4.92) (envelope-from ) id 1oveQA-0004M3-Kh; Thu, 17 Nov 2022 12:55:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445189.700224; Thu, 17 Nov 2022 12:55:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oveQA-0004Lw-I1; Thu, 17 Nov 2022 12:55:10 +0000 Received: by outflank-mailman (input) for mailman id 445189; Thu, 17 Nov 2022 12:55:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oveQ9-0004Lq-6f for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 12:55:09 +0000 Received: from smarthost01b.sbp.mail.zen.net.uk (smarthost01b.sbp.mail.zen.net.uk [212.23.1.3]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 101a46e2-6677-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 13:55:08 +0100 (CET) Received: from [82.70.146.41] (helo=pear.davidvrabel.org.uk) by smarthost01b.sbp.mail.zen.net.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oveQ0-0003J5-PK; Thu, 17 Nov 2022 12:55:00 +0000 Received: from apple.davidvrabel.org.uk ([82.70.146.43]) by pear.davidvrabel.org.uk with esmtp (Exim 4.94.2) (envelope-from ) id 1ovePr-001FlP-Bo; Thu, 17 Nov 2022 12:55:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 101a46e2-6677-11ed-8fd2-01056ac49cbb Message-ID: <0afe3f35-1b25-d1c6-89bb-8dae7a4070e9@cantab.net> Date: Thu, 17 Nov 2022 12:54:51 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-GB To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , linux-kernel@vger.kernel.org Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" References: <20221117114122.1588338-1-marmarek@invisiblethingslab.com> From: David Vrabel In-Reply-To: <20221117114122.1588338-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 82.70.146.43 X-SA-Exim-Mail-From: dvrabel@cantab.net X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pear.davidvrabel.org.uk X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_SOFTFAIL autolearn=ham autolearn_force=no version=3.4.6 Subject: Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on pear.davidvrabel.org.uk) X-Originating-smarthost01b-IP: [82.70.146.41] Feedback-ID: 82.70.146.41 On 17/11/2022 11:41, Marek Marczykowski-Górecki wrote: > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until > the table is filled. Then it disables INTx just before clearing MASKALL > bit. Currently this approach is rejected by xen-pciback. > Allow setting PCI_MSIX_FLAGS_ENABLE while INTx is still enabled as long > as PCI_MSIX_FLAGS_MASKALL is set too. The use of MSI-X interrupts is conditional on only the MSI-X Enable bit. Setting MSI-X Enable effectively overrides the Interrupt Disable bit in the Command register. PCIe 6.0.1 section 7.7.2.2. "MSI-X Enable ... is prohibited from using INTx interrupts (if implemented)." And there is similar wording for MSI Enable. I think you need to shuffle the checks for MSI/MSI-X in xen_pcibk_get_interrupt_type() so they are _before_ the check of the Interrupt Disable bit in the Command register. David From xen-devel-bounces@lists.xenproject.org Thu Nov 17 13:06:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 13:06:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445196.700235 (Exim 4.92) (envelope-from ) id 1oveap-000643-LK; Thu, 17 Nov 2022 13:06:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445196.700235; Thu, 17 Nov 2022 13:06:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oveap-00063w-IV; Thu, 17 Nov 2022 13:06:11 +0000 Received: by outflank-mailman (input) for mailman id 445196; Thu, 17 Nov 2022 13:06:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oveao-00063q-8S for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 13:06:10 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20604.outbound.protection.outlook.com [2a01:111:f400:fe5a::604]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 99624f45-6678-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 14:06:08 +0100 (CET) Received: from BN1PR13CA0021.namprd13.prod.outlook.com (2603:10b6:408:e2::26) by CH0PR12MB5187.namprd12.prod.outlook.com (2603:10b6:610:ba::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Thu, 17 Nov 2022 13:06:04 +0000 Received: from BN8NAM11FT106.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e2:cafe::98) by BN1PR13CA0021.outlook.office365.com (2603:10b6:408:e2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Thu, 17 Nov 2022 13:06:04 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT106.mail.protection.outlook.com (10.13.177.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 13:06:04 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 07:06:03 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 05:05:40 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 17 Nov 2022 07:05:39 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99624f45-6678-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kXzks3lMZ4BYKyxSYfT1foBNzIrqKzPIvY0pEaTIfro4mW4G49gAyk46SGiAPruU04BX9eXWweQxIpF4J3Jy8H4YXHZDkmk+NE0mX/NSBblpmn/prGcVjXiUFfFFrfbEX0opq9X9NCQK6Oie7/+b4Y5DJ6hf3R8TLIqI92WjzDfV1MUS7+9FK4AbyB4WYVBFyjVr/gClaJOXsnzG2BtWRKPEsxeWIeZxjGByldkfMUIMoqy2Et5hLf1bu7cg9vDEmCiuhOWgd+ZwMlZytNxGqowUsdiJrm/6dKF1HTO+NccaMqIb91DlxpNaTtcbqSBz9s8hfzVaR648o38VIskfBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=96I7PSRm2B+Z95pqijb32Ianubegkj8KGU9ZttwGcyY=; b=RPeOZC0gSCtkDV9Sfn1aMGSR5R+SMC4dcFLmmQDAf6YQDlPjy1PJK7KrT+hve8sQMNtY5oRThpWy539JeloqntnDqfUEpwxLWVnIkgpCG/Tp1yeOjPLrSsob+GKX9Yu6RkUE0unA3I5bOwg8nBolnEGqvkkcs6wyXo9DZMuASCTxdEFr4rjFkB6sDPXUUMyDCIu9mGKFd5J2F43+idkIDW+FDbpok/VTDpD7FZfKBmgeD8Om8+8mYeHsSdcHH90eix+bXHq9LV/E+muflYTCnYfTm3Gj95QaY90AoCSuHZleB3cGJ68SHaIXYRwVDguLZNSlODGkBhYCDoiyMavxuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=96I7PSRm2B+Z95pqijb32Ianubegkj8KGU9ZttwGcyY=; b=Mip9bQL369iQqQT2JQ2EoeEktYwZkV9+sZkBHvSL0dQhfKl+D1Xt5T8YS3GVwEZG168v6HkkIbCDJ07xlk6S1eBfcpUqfbZNPlpsltJSu4e3iSTCizKlSCQZW3cM71HvoH3Fe+BimrwErQLYJQF35hpMxx3oOAtJgNzZGqpx//c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Thu, 17 Nov 2022 14:05:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN v3 01/12] xen/Arm: vGICv3: Sysreg emulation is applicable for AArch64 only Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-2-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20221111141739.2872-2-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT106:EE_|CH0PR12MB5187:EE_ X-MS-Office365-Filtering-Correlation-Id: 143f803e-21b2-4969-09cd-08dac89c7be8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hGULb64sqSxL0hPyiDyeX/puRIgP+8jmFjnulV5EaQeeumSSDEJibWJaY0lAhv3dWK7jT+2IjQUwmaeIJYFTWXXmcInM9AVNbFxteyH3rraEI6vQUE9S43CjMMKNP5kyHrUaGB6t8VZj3K/Hor2J8zk9FlMjqKqNZd/g9uouzpxTvGw1YE7XKP5uZtHKVDmlZSMHGYbRY2N/llSFEqcHiP5Sb/ZyCOlfDeH4Evcnl71kMHZZlG6bZ0S5Pw3RO3jkpUWvNiba9797zxEdqaSKXZ6QN0xsIpFU6Xp1cqfOm4+hM6FjR0mNvzju+So5/G2mnlwOkAoa7W9psyAuvxjotB0yW+02joCyKLLBA/bY9fIyGSrx2D4QC3lmtgYKytPZA+ZCxkfILruyMhrJKD0eD6ytdSXNsSrZerGV05y48M6+Q/B3ZwWd56J1rpdBDo1iPRMoJPrkjKPk4WhycT/r02HZSFvmKF9B2zJ1bY1tymFUeOrK/s4LZ3nReTjpUfQbzBhkHhzTiqFS7mGP5g1cvKwtnYmxff3zh/CE4TXJ5Q4nhK1fsuytVRhf/b2S9+1LlBALLDGssxWBoXCJHfpOwkx416usahBNByRd9qn83ugPegeKtYrc/2vjsE/xANlYIevM2YL0qDAjC2Pm0EvsoO/Vd93oQIGnh5A/Ty5bc8gwJYqnuzljewhqNCwXxrjSPqWHNjmy58zptg5MUdFhbENK1uha/8jZ+nyD3F03omSAzMAUaqeBNpQvL6UDNloXoml0oT33f129BBLU02Qq/A== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199015)(36840700001)(46966006)(40470700004)(31696002)(16576012)(26005)(316002)(82740400003)(36756003)(356005)(86362001)(47076005)(44832011)(4744005)(336012)(40480700001)(426003)(36860700001)(2906002)(40460700003)(186003)(70206006)(2616005)(70586007)(41300700001)(4326008)(8936002)(5660300002)(8676002)(478600001)(31686004)(82310400005)(54906003)(110136005)(81166007)(53546011)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 13:06:04.5135 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 143f803e-21b2-4969-09cd-08dac89c7be8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT106.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5187 Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: > Sysreg emulation is 64-bit specific, so guard the calls to > vgic_v3_emulate_sysreg() as well as the function itself with > "#ifdef CONFIG_ARM_64". > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu Nov 17 13:12:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 13:12:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445201.700245 (Exim 4.92) (envelope-from ) id 1ovegN-0007Zx-9Q; Thu, 17 Nov 2022 13:11:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445201.700245; Thu, 17 Nov 2022 13:11:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovegN-0007Zq-6m; Thu, 17 Nov 2022 13:11:55 +0000 Received: by outflank-mailman (input) for mailman id 445201; Thu, 17 Nov 2022 13:11:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovegM-0007Zk-5A for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 13:11:54 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20601.outbound.protection.outlook.com [2a01:111:f400:fe5b::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 66ce4df1-6679-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 14:11:53 +0100 (CET) Received: from BN9PR03CA0486.namprd03.prod.outlook.com (2603:10b6:408:130::11) by MW3PR12MB4475.namprd12.prod.outlook.com (2603:10b6:303:55::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Thu, 17 Nov 2022 13:11:49 +0000 Received: from BN8NAM11FT069.eop-nam11.prod.protection.outlook.com (2603:10b6:408:130:cafe::2f) by BN9PR03CA0486.outlook.office365.com (2603:10b6:408:130::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 13:11:48 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT069.mail.protection.outlook.com (10.13.176.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 13:11:48 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 07:11:47 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 07:11:32 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 17 Nov 2022 07:11:30 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66ce4df1-6679-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JSehw+2Ba7klzG5TMNU8jooxQ4HtjGJCGgPYBmA2OUsTFF4ulC4vF6mTX1UO2A5t3xdbhGdC1Zp3FoTBR85/Q6fp5Oq8MIlTKUWHaLRAZOY1rNA08pmvkqX9ppjmYE9EL2koElJGPD2K9wCQL3RbvUnIM+LEEX5XBj1OGtW7FGLLRLsNqiIXwqVLKHbrahZzHKqYD2o4Kcv+DPKbW9BRkCm70traNRnSCsvg5JHrM5JVhmUPd7tFTXUNDVtGL8bIAY5RTcxbVOIqEf0s8F10G8ThAYvr3NO967ni13p6jNSeqB8qbbJ+5Hnfn9gbe28Q5dePdAhzULIIoXJmPpALzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kArmuR4bkKjuBcxB9hMbzYDZ5JaDT15JSnR6qov3KQk=; b=OJUrLA8Q3WtFfxUo7yh3TXi/aCVB45BBCvk3qavtynyRFVekhLLXyeO7bvVVaFSWramEM8Ht1OX3LvD78SY4vr92BaXywOBFO/bqWNgBqDNcEBaOWfpIKcxc4HjLMuGBJurSjTK3UVUBVnzbMuOoQvdzVB7j8evoz3PxB0rdFCF4hxl9bI0PJw32W442oalasQSw9ynlCyVhHSZCcKPGEmTgC2KxAO4Wu0OEjhwG0p2y0YBoBY9ZIaI4mOA9pbSnjhMWvC1/UjnYjcJRbO69ZGdnXCD0ASNlWPTpVyfpF0LCUGE1lLqRqHWWQiqAhzDFyLq2sDXnRjUBY1QWn3kDHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kArmuR4bkKjuBcxB9hMbzYDZ5JaDT15JSnR6qov3KQk=; b=cGnkul4XvVBuMorKDFHwZz20CLzRygQEv1cW5+DtQ0IA6xn2ss2226tQIsGvO7xqQ3qREM9S14mqz3HWNaEtokYkvF+nLIDF0cRYvI6358Re5j/n72/s/KXTHA5icE5sW8po8AxQZtt8BbAFMxxaThFIv2U/QhGhDiZ/OR0V8Po= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Thu, 17 Nov 2022 14:11:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN v3 03/12] xen/Arm: vreg: Support vreg_reg64_* helpers on AArch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-4-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20221111141739.2872-4-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT069:EE_|MW3PR12MB4475:EE_ X-MS-Office365-Filtering-Correlation-Id: 11c03cdf-51ca-4442-1abe-08dac89d48f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ljvKtJhpuye3u+eoMjPiEv+da6CF+TLAXF04Zz+7JLDxYhWoa88xBSQBdI7sTz0Ss7y4bHEMlAio+6o0FbHlXMvBqBIqz9ZhtKBkTVxZKiHFtP7q1+MtJcUHshBB0/MTFPChYtiNYeb9yr0xNEOtOl2GvXxRreubY2HY9sp8y3uVvORFB1Hfx0clC9dV//+6OUtnzASAtVeJdy+SCCX47OloWWj8YUgMY2euB4D0yQwno+dfKhnMud5fPUhqZu+OAVErqs947kZZ7dNjyG79lYSGYtC/7cor8grvDJvTus5QWqLORERYGkJPY4wt+nan96bc0kzcu03G7MARrNXfavrtGF6sPY81uF8BCy7Qp7YkOd1SSp0q6TGW5QWcF6Omnj0E4rOqwUnrr4pQfSp+ORNjpjwPw7Y2T676yucGRyPShc53iOqRFlk1JCWc+YOc0c5EEiLyYWuG7JUC7blaDm8LoNpxRSF01vNWA7m8qGEMyGIxh8knRcwSEbkbmkiWMIKidQS6zlhWexm0fxVylYVhe7pRDIK0A6oqaJ+LRpFr7aA1ro+kk5+xA6xUNcRR4kei/Wn7nX1SC5QbxzftbW316GFbFkRhpzEV9W5UC4cTtsUbEWspph8NmTtw3ltTKcuPhmIxPxMpfVo3jWPCucsKKRJ3JUt60dYcBllLAfVFSpFVvgnRRYDQ0u26BMY0G4q8Areej7w10Ow4Ucc6NgO9OXtC963f6nTuYJhwvBDxxvDKIBtH4C1OFVqvvgE4YewTuaAhSO/7vT1dDT13gQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(376002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(5660300002)(44832011)(4744005)(8936002)(41300700001)(31686004)(2906002)(16576012)(316002)(54906003)(70206006)(70586007)(36756003)(4326008)(110136005)(478600001)(8676002)(53546011)(26005)(86362001)(426003)(47076005)(82310400005)(83380400001)(356005)(81166007)(40480700001)(36860700001)(31696002)(40460700003)(2616005)(186003)(336012)(82740400003)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 13:11:48.5739 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11c03cdf-51ca-4442-1abe-08dac89d48f9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT069.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4475 Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: > In some situations (e.g. GICR_TYPER), the hypervior may need to emulate > 64bit registers in AArch32 mode. In such situations, the hypervisor may > need to read/modify the lower or upper 32 bits of the 64 bit register. > > In AArch32, 'unsigned long' is 32 bits. Thus, we cannot use it for 64 bit > registers. > > While we could replace 'unsigned long' by 'uint64_t', it is not entirely clear > whether a 32-bit compiler would not allocate register for the upper 32-bit. > Therefore fold vreg_reg_* helper in the size specific one and use the > appropriate type based on the size requested. > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu Nov 17 13:13:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 13:13:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445205.700257 (Exim 4.92) (envelope-from ) id 1oveho-0008An-JP; Thu, 17 Nov 2022 13:13:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445205.700257; Thu, 17 Nov 2022 13:13:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oveho-0008Ag-Gp; Thu, 17 Nov 2022 13:13:24 +0000 Received: by outflank-mailman (input) for mailman id 445205; Thu, 17 Nov 2022 13:13:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovehm-0008Aa-Qy for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 13:13:23 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9808c6bd-6679-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 14:13:20 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id ACC613200B37; Thu, 17 Nov 2022 08:13:12 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 17 Nov 2022 08:13:13 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Nov 2022 08:13:10 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9808c6bd-6679-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668690792; x= 1668777192; bh=nEhR7pMCw3FhT/lMNgCiEBfKk2fj+LcGrS37oNxSJro=; b=t YiS7Q2KpFt+zCX59+TZBrjYf3nUm7hq3hXo+1j8FQ3xm6WoiMN9V5Dfag6tBG9hn UoF3q4WD1QIUOZgkKYQB82uYsUKm037Sie+6sg8Lsv39PBoSZxAKvlc8A2O7j0ft gIfmdu+SQvPDO57ZMVcBDQY9UaV0m+iGPHFb7tEFC7ohunegdyD07fncHQlzMlEl O8SNj+va7/zco4xudc4RNh1lB2H1jLABhjSDs2Peo0XTwehLaC/Ngm2oKVhHftrQ Z7gds+bUnWfD0Kaq9VhgV51hz3Flg6zMUoHnFUDnQlgbI85DU/3/Z0srylLXVjPm xqiKIHan8hS4dvGmOuzCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668690792; x=1668777192; bh=nEhR7pMCw3FhT/lMNgCiEBfKk2fj +LcGrS37oNxSJro=; b=XWumqYaEWqMNBnVsg/ykzRMnmY/VHi7Ba6GO8ga97YO9 6oIJn3AKEiB5l/hoiCUjLqbMus7TQE2TePOAoIJgPrD6D7hkbHeLnWq54hSJXqhx 7O54uKBSwJCJABBAWQGkFDwBGozq5C0RHt5oRq9iIIUQ0InWVLP6FbYKgvEWoRc2 uluFz+l4vAFpNURNtQjDlQf8u40cjJo2DEHnWSDj0yUwjat3rgReHGYhf04itPMK MkCDwczeWfw03FCDhyF+IxUaCGIenmbKTjNjGU388uWPd6G2aDCeULaDPhpUmILT bo02ylNhpgjGHu9d5odBcU59EhoO5ADQ1TB6AkerTA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgeekgdegkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 17 Nov 2022 14:13:04 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: David Vrabel Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Subject: Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared Message-ID: References: <20221117114122.1588338-1-marmarek@invisiblethingslab.com> <0afe3f35-1b25-d1c6-89bb-8dae7a4070e9@cantab.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QOL0n3NG2/pM9Yw2" Content-Disposition: inline In-Reply-To: <0afe3f35-1b25-d1c6-89bb-8dae7a4070e9@cantab.net> --QOL0n3NG2/pM9Yw2 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 17 Nov 2022 14:13:04 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: David Vrabel Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Subject: Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared On Thu, Nov 17, 2022 at 12:54:51PM +0000, David Vrabel wrote: > On 17/11/2022 11:41, Marek Marczykowski-G=C3=B3recki wrote: > > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until > > the table is filled. Then it disables INTx just before clearing MASKALL > > bit. Currently this approach is rejected by xen-pciback. > > Allow setting PCI_MSIX_FLAGS_ENABLE while INTx is still enabled as long > > as PCI_MSIX_FLAGS_MASKALL is set too. >=20 > The use of MSI-X interrupts is conditional on only the MSI-X Enable bit. > Setting MSI-X Enable effectively overrides the Interrupt Disable bit in t= he > Command register. That means the second chunk of the patch may even drop the '(new_value & PCI_MSIX_FLAGS_MASKALL)' part, right?=20 > PCIe 6.0.1 section 7.7.2.2. "MSI-X Enable ... is prohibited from using IN= Tx > interrupts (if implemented)." And there is similar wording for MSI Enable. And this would mean the 'field_config->int_type =3D=3D INTERRUPT_TYPE_MSIX' part isn't necessary either. Jan in another thread pointed out that disabling INTx explicitly is still a useful workaround for a flawed hardware. But if that isn't mandated by the spec, maybe it doesn't need to be enforced by pciback either? > I think you need to shuffle the checks for MSI/MSI-X in > xen_pcibk_get_interrupt_type() so they are _before_ the check of the > Interrupt Disable bit in the Command register. Note the xen_pcibk_get_interrupt_type() returns a bitmask of enabled types. It seems it should consider INTx only if both MSI and MSI-X are disabled. I'll make the adjustment. But this alone, won't cover enabling part, as INTx is the only one active at the time. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --QOL0n3NG2/pM9Yw2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN2M2MACgkQ24/THMrX 1yy7Xgf/VXm1tljAkL14zb63jld+ZWk8SJp3bJmR29my72LkJSDRptt56K2JKUo7 Morpduk3y63d4eOWbR1QQ+Ms3fXXn6anDTweGWq3wChZZu1v4ZwWcUD1tZNBpIk2 b1dDJOIJyYBYaVN084X874y6Lt1sh8OKzbwzCB0smNtsTNSxFMUKEwTqAOLpYOxg 2QYhy3zzvrDEQPgMzCSMJV5kcJSXl8+Tkpt2RYVBu6y9VuatGYnlOSI66p/bH4t7 0i/QrAUZc7FgYWkH8gzr3M6kcOzRfHy44Ye1IS78/7Z387M3qwyLnLnS8dcuMxuX mTpZ640102hfSbQzQAT9HMY8E7PN7Q== =2Ltr -----END PGP SIGNATURE----- --QOL0n3NG2/pM9Yw2-- From xen-devel-bounces@lists.xenproject.org Thu Nov 17 13:33:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 13:33:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445212.700268 (Exim 4.92) (envelope-from ) id 1ovf1a-0002QJ-6M; Thu, 17 Nov 2022 13:33:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445212.700268; Thu, 17 Nov 2022 13:33:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovf1a-0002QC-3W; Thu, 17 Nov 2022 13:33:50 +0000 Received: by outflank-mailman (input) for mailman id 445212; Thu, 17 Nov 2022 13:33:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovf1Z-0002Q6-3o for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 13:33:49 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70059.outbound.protection.outlook.com [40.107.7.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 76e459a4-667c-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 14:33:47 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7971.eurprd04.prod.outlook.com (2603:10a6:20b:234::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 13:33:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 13:33:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76e459a4-667c-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d+qBLtn03a0+ndnHWxB90txpYFAiWylJqiOBvX/6oEQ2CIAGudvmD2D+L1lTgnCF4+J4DfIBgnKvxruHtCGDnOq8j/ChPLNmFNbRPaCALFaiVxjAtK6SIgAWT2Xwot6lcNeJ80X9C72nvGKOa5r4IAzf96TWNFp5BXL+Pwy4hWOvn+q3yFtSBu1xebkCcAQaJwQO4PV+Rl7XJJaPMieuWtT3Y69l5FY6nt+Rj3ih0n+GvK5NoxnnP2s1344CkzETK77S4uJ8be0f1qQSh9+NnDDFxHb+pndWfQqr/7HBWREs4gwhcczulrS51+aYL8R/T2kdzcYPjbVQgV5nyl0QfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9ogx26bF65DqYPWtbZlo99oztsooSlTMopXO4O6WJnE=; b=eL/2/9+G7Hl//x8eIWIGwk5P47F3NihfEfyEwW8uKSH4dVGtZ5/9y4AflHykHkKUsN5YlQJe8Tkuli9HGgY7Xz3LbPo+pkaGBEUSE5JDSkEZo5YMsxl+2BmcIfivFK9QH0jCMXls2X55qnJyKD1SnwXfOTpO8ABzynKQau9YPeYnSpeH40xcsE79U2M2YphrtSTeEvWeSnDJ4WbT+PZCot3qeNpXAu+9mNLJ/R/rK/qJcavYKHepUucALe6FcJQin7DuIA9ZLUljcSCUAvt2S4vXVckBXyIaiHS400gXeTGD9SogL9JwdJ/P69zUJh5V5kbB5Rjo6JbmZA8oEiuPAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ogx26bF65DqYPWtbZlo99oztsooSlTMopXO4O6WJnE=; b=V7NaT7apK8kVaIDtdtiBjUmHCZJsrPjcAUZB5myGIn8oIZcVC/RnJ2ExgqbOXvF56YddOou1U6WJGxhOPubQgLUkyI8UtHwmtAnc0is9Bvk2wIAdZ8E9SJHltWgl8UT9gNKDTJn0yCe6VsEVrTRfJQ9tJtcPj9/tmn65iQJLTrWLCHN0E6xiIKyuU810o6zNjGTFOyZnHwGZhbhu3fXYK9rSzjGpGib7vjd6DmSq9jm9e50RaJOVdWMITegdmLllSq2qQrkKqX78HxR4+gAOLvAo26APz64xR8L8e29HZxVThLfGW79GxbPRMcsQvPruA51BbYLm1jsqnd7BmT9VgQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 17 Nov 2022 14:33:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , "moderated list:XEN HYPERVISOR INTERFACE" , David Vrabel References: <20221117114122.1588338-1-marmarek@invisiblethingslab.com> <0afe3f35-1b25-d1c6-89bb-8dae7a4070e9@cantab.net> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7971:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d888d9b-49b7-4b55-6932-08dac8a0493b X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eR0Nsdkf6UPFGVUWIopx/RwdcHK6zHtnpNFUD4cGaGmAh3M5SHQhu29/aQdTk7x6jHhHUwmXF90DBrjca5r4Yp3bOKbmb4EVtyCvK2LHZ/wv9DVFnxE8PLkAHj9C+PeCUED8FbgZCEAT/A+lOqrAgUCkoYFgb39i2rXs1cW4r4VGQxu95aS0uzqQ2RdXJUmfzG5ykJxB4t7bEvxTIIZvUG6EkOGAhuVq6o+YqpyU5MJ/7w/9kRzmoiyVJ2puhpiGnJn6IPd6gOU9WPQGnTE75QH2mBBWh6KmVDCfmwiGsoVGP6BaC/gghzUefADAbCHyQZgUTe5JgmTxVqOCYGRfDWG9rVq5rEiA1MsogvvWQtmnBREXlMXPYTsMH6nhrW9ikJOjo9CcMukUbKFajW5wzsSZc2mLRy+avNT2yHeC9R644CjuycpyIgjM77ZVPSeugeV7OeQ9tn0YzmlRVDw0moHFCS93ZSu49dV428Zta+8mmHM2WJhA9iDrxjDRDlFZWliNEvnwGebx7PcPgwGDhl3X4S84NKjAgOf2QUQ9k0s+eYkeZVYAxvUfXhzbE5vZHkLGET5HNEQfQ3H7cczREsihQrQmYnrhjcbn+7RvEopQjPKalnr82IrkVFyMlixxRt5WHTQK72iE6O5VqWfHGUWsOJBgQdictFWEGuZ2C8JkdCdLJB6pgRjHWZm6O1+WePs9qXl/kUbMeeAEKCsdh7FU7YNIRm+L24i8I2aoBr8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(136003)(366004)(346002)(451199015)(2906002)(38100700002)(53546011)(26005)(2616005)(4326008)(8676002)(31696002)(66556008)(66476007)(6916009)(54906003)(66946007)(6506007)(36756003)(6512007)(186003)(31686004)(316002)(5660300002)(86362001)(41300700001)(478600001)(8936002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnVnSUVPam5kTFJFTzBYY1pkTTdLbnNBTndOQjJ2a1Fxa2ZvOUtsQXRxeXRn?= =?utf-8?B?dVNwYm5hc2l5b0kvS2YxUmhwNFYyRHNKcEVabnNCRjIxa0xQb1o4MzRjNGhV?= =?utf-8?B?N2pIZXNaR0t6OHZuVERCeHppN3EzRWttRzRieCtHTk1mYTY5bENmY1dCekp1?= =?utf-8?B?TUdBUkJUeGJydW5zd0Rwd3ZDdVNITis2NG9UbTFMRzJtelU0V2xuQ0VXN3hs?= =?utf-8?B?cXlnY1ZqcXBQaXZ2YWxmYWgxZkVybXZoSE1Fdy91KzcwUGQ0YTMwM2VnajNv?= =?utf-8?B?Ly9vdXlUN1Rwd3VVVnM2NDFHazNLQzk1U21tdmM2Y1hkTXIxcUlIdzBNWlBR?= =?utf-8?B?ZStiaVVrZTVDN2FPaVY5Y3JoYVBWaHFBWEliem90QXpVcE9IQ3h3YWxVbTFK?= =?utf-8?B?L1pJazRGSVBaVVZaZXBhSFJUcnl6M1BVR1dPZko0VFoxTUc5ZmJJRWJEekhC?= =?utf-8?B?eHliU0lKVzcyYzVUVGNDcS9FQUlwVHE0Q2xYTGo3Tkl0eExVNWxaa3I3K0My?= =?utf-8?B?TmsxZVJzU1RDb2xyUk5rejlobVJSOGFtY0NUeU10aFdYQ1ZTWmRQbVdCOW40?= =?utf-8?B?R3VWdTg4eG5Zd2ZCYjB0QlFreGpnUWM2T295N1Y0T1FnZ2VaRGVvM1VZT3d6?= =?utf-8?B?YnRtUnBrODViQ3RYN0Rwb1E5MDRVS2JwNUF0VENSNkVKQ1o3cGNTZDhxWTUw?= =?utf-8?B?T1VXdFVzU0V2elhYWHVQQTFsYytlUnR2YXVrUEJxWEJGRmtNTDM2MUJhVVBt?= =?utf-8?B?VlY5blBsSUxZWW8xbFlTYnZ2TjlXRnhtaGhIUU4zQnBLbjJSVTdUcU01eXJJ?= =?utf-8?B?WHZXakVlM3E4OE5NblJjZlFjd002T3hIYnpkN3pYdDNIZzhsMEs4WG9mMTJx?= =?utf-8?B?T2svZ3RjOFRZNEdlaEp6MW1seWk4eTVOVml1d2VQRDlEendsNGE3TjNJQkd2?= =?utf-8?B?RjVxc0pjVFZ5ZGdydU1UMUkvdE01U2RXaWNYcUZmM3pIazcxU0FtWXJoMHc3?= =?utf-8?B?N1RremxCNmlUVFprUXZuWEN5UmxBL29TSEV0Rm0wTytaWENtQmJYNWlWLzBS?= =?utf-8?B?MXI1TDRRSVhJK1gyaWpZa3RYUkNjd1lVbjFGNEZVWVJnb0RSQ1BKSklmVmRR?= =?utf-8?B?UTcwKzgyWUxDanBldEVPWEdZUFplUU9aM3BoVUxBMVZWWVA5S2IyVDVpRDZw?= =?utf-8?B?QVcxUFRxVUI2U29wSjBCNC9iNHBDNHc1aW91NkNnQTNNRkFhckVsU1VwcWhN?= =?utf-8?B?SEcvRGx3T0FlVU9LNkhMVmt6WEFEYTJzOE1PQml0cXdFZTd0Zk50T0VVbnR4?= =?utf-8?B?T0JNTlV6bmYvamMrTDlJa2lHVHg4bGphVllZVnpMS0lGSC9ENmp4TW9uT3Jl?= =?utf-8?B?T2RhU1BNdzBJOVBFYjBmdXhMTG9uTDBJb3JRdGdFbU1rQTQ1YmZqQVhRem53?= =?utf-8?B?ekNZdGF0TmR3eFhiNTc0SzRYK3JTUnFhZVZiblByaGhNVjBKTHRNYVQvNFFh?= =?utf-8?B?NVN2OTF3Qnd1bnZhdC9JbnNqa2NPWUltdHlDSThzYi9CRjFwbVU2WS9Mc0Yv?= =?utf-8?B?QXZ5M28yc0tlT3hmNTh5aXljb21Eam5GRHMrYlFxaXoxakxBY0psTXJYZWgr?= =?utf-8?B?RjlaeVpBN0xhWktWQ25Na25EMk5vbit1VHQrZWY5dUt5SXNXQzlwd0pxMmlX?= =?utf-8?B?NENKZk12L2k5ZWZzYjFEUDRVc1k3alpwVStwcHdRWHFYbTUvYW0wWmlEbDlu?= =?utf-8?B?bUNJeDM5cHVkdVlTMzVWUE4rb2FzNkFEeUpXS3AzSDl6akh3eWl3aUNySFF0?= =?utf-8?B?RzV2Q0hlN2s3aXhVREFSQWRyaW95N3Era25qYjd5d2F2UjNZaklaM3F6bVho?= =?utf-8?B?UUp6UHR4YjhUSjFhVEE3NFowcnRiNzl1c1Z1TEJ4a1VPampDN1JZdFJ2a0tu?= =?utf-8?B?YmQxdTVPNDQvR0NMNEhHczhCZ3NTVGE2enk2bndPVTdubzFtNXJyaGxpc3Vl?= =?utf-8?B?S0MyYWFNblNpRFJmd0V0b1E3NFJmeFlvbHpEYUVuN1JwMmJxZE9yTWkyelF1?= =?utf-8?B?T1kwbUlNWkorTzhpREZXVGtoUW02RDVXNHB4ZHpkeVE2bVB6cEJhU1AzK1Nz?= =?utf-8?Q?cXz1tHgZwogKylfA5X6kEy998?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d888d9b-49b7-4b55-6932-08dac8a0493b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 13:33:17.6080 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 99vQkEgnb4jXBL1nbHzBLeD5edeAbb9R79vb7m2f5urie7131cN70xSgcOzXkOBNgEIUJeCC8Pbz5agHX29Xcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7971 On 17.11.2022 14:13, Marek Marczykowski-Górecki wrote: > On Thu, Nov 17, 2022 at 12:54:51PM +0000, David Vrabel wrote: >> On 17/11/2022 11:41, Marek Marczykowski-Górecki wrote: >>> Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until >>> the table is filled. Then it disables INTx just before clearing MASKALL >>> bit. Currently this approach is rejected by xen-pciback. >>> Allow setting PCI_MSIX_FLAGS_ENABLE while INTx is still enabled as long >>> as PCI_MSIX_FLAGS_MASKALL is set too. >> >> The use of MSI-X interrupts is conditional on only the MSI-X Enable bit. >> Setting MSI-X Enable effectively overrides the Interrupt Disable bit in the >> Command register. > > That means the second chunk of the patch may even drop the '(new_value & > PCI_MSIX_FLAGS_MASKALL)' part, right? > >> PCIe 6.0.1 section 7.7.2.2. "MSI-X Enable ... is prohibited from using INTx >> interrupts (if implemented)." And there is similar wording for MSI Enable. > > And this would mean the 'field_config->int_type == INTERRUPT_TYPE_MSIX' > part isn't necessary either. > > Jan in another thread pointed out that disabling INTx explicitly is > still a useful workaround for a flawed hardware. But if that isn't > mandated by the spec, maybe it doesn't need to be enforced by pciback > either? Well, allowing a device to go into a mode exhibiting undefined behavior is what we ought to prevent when it comes to a DomU doing so vs overall host safety. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 17 13:40:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 13:40:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445218.700279 (Exim 4.92) (envelope-from ) id 1ovf7n-0003wQ-0J; Thu, 17 Nov 2022 13:40:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445218.700279; Thu, 17 Nov 2022 13:40:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovf7m-0003wJ-TX; Thu, 17 Nov 2022 13:40:14 +0000 Received: by outflank-mailman (input) for mailman id 445218; Thu, 17 Nov 2022 13:40:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovf7l-0003vR-GT for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 13:40:13 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20611.outbound.protection.outlook.com [2a01:111:f400:fe59::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5af6855a-667d-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 14:40:11 +0100 (CET) Received: from MW3PR06CA0023.namprd06.prod.outlook.com (2603:10b6:303:2a::28) by SA1PR12MB7038.namprd12.prod.outlook.com (2603:10b6:806:24d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Thu, 17 Nov 2022 13:40:07 +0000 Received: from CO1NAM11FT065.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2a:cafe::98) by MW3PR06CA0023.outlook.office365.com (2603:10b6:303:2a::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Thu, 17 Nov 2022 13:40:07 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT065.mail.protection.outlook.com (10.13.174.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 13:40:06 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 07:40:05 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 05:40:05 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 17 Nov 2022 07:40:03 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5af6855a-667d-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aSqRTt4fmQ4iCaITyfhpXRna5vOA2XSigjLfYTfyCZm5Y+vFFVx6SelbcJGV8WqcEU+egGNLgC07ex4iDufTm5LZcxkVdsZt28hmHW48IWTILxzzL4kz0j4xYAgyfcCk73xbNY8brcqVDnxTQaTcR4UirVB+DfS60GEmpsihIi0W4HSqYKQ3D8BNfYXlRaGxcQVOYEYNzKwNaE9SWc0EhubbUxZEYRuOh+MGeLFZx7q9HrNc8cb4sH0rt/4sh7zh3JDS76xZ/Pmd2+XQkX2t5X+qqPH5pnAw6Vs9VVi8kFEYY7cd/BnVid8bfQuNzzitwrzubv3SJVbcdBcZnpiYrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=avVnQD7ww8knOGhKoIuyVz3Zx0k6lSvfIXELF6snUSk=; b=GO6l0BEZYg3TS4IuTD3WJjlxi546Cz8S33DuEcvzrCEsjUPftQQYakmCX6IFu7XURlD++ezBEM0xVyXfPPt3vHVrDcS/l6mtYEcm6c0AWjZEGtSW8nmaC/Edx5NfRtvAerT5/qHF8kuVEQUMq0SH0bnczejU3jY6jotZiztqmtsY9obZ1rC12LlojkxnAnkVZBipQcXHTGqqouPLO3BOz1RxZR3Oru9UB+4msuoGtQRp+ISJrafv3/tgyCKSQoPuiEfNON2BQ56bdtNIfuhT2oTdM4an7i8OuYtUZjgND1DmWZjObaP1uEMDa/1NNnO2xPr0Iv7BkUnARLNk4OiXIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=avVnQD7ww8knOGhKoIuyVz3Zx0k6lSvfIXELF6snUSk=; b=dzxjj7u3NUJIuaG/pPn9py6l5Q+4WSpgql+aHFY+VElGwgwz/UfOPUHyOmBe75nLWBASij4Q3ma3PxSDvYV1T8PRTk6T3twwya3vv611VXgj3LtOGD9v16j6KSDNFTDrffhqSExwdkgbqeBRqz4kfVTjYcSw7rk12voh3TFa420= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <8086e3ac-445b-17a1-bba3-078024ab2579@amd.com> Date: Thu, 17 Nov 2022 14:39:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN v3 02/12] xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-3-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20221111141739.2872-3-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT065:EE_|SA1PR12MB7038:EE_ X-MS-Office365-Filtering-Correlation-Id: c1f91bbd-4557-4295-0ba2-08dac8a13d44 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kd847PcTmHTcgYCedmoZL69g9uKE/q81Pnz4qwgE9dXQmU9+owkXPTJohzKCrk9qLigKikAXGSLcCHblBlkMnUrY8TsHJncrFz5EoY6CZHUe/1YJ2P8x6pCKc6XJKPPpCHgsKvcTGARzM3QQv5LxunxhQ4pt1VTjL42SUx0s40MxP0Gxtg/pFVc5w/XXIqPdiqJUOeH+cizWAf16RPckL+g9m9AhMn8cNFrbtUpZT1jlFA3E66TP4nxbEKDllzrRRjR3ME8s5xu8xDrkehwNJ6uAzSzTlKyJfMzAu7/O77lsmy8/flh3tO5l9U+8Wc9eisDBit5H0FCjELnU7hP7waA93swjyoQwuX9M/3aZJDZc2FoeOPWFR343SO+eb9Qbjup01qw5kdj3nNXr5gXGoZS2eKN4P5hC+uSiOqVQhLtGyW+RT5q7E8IJjxVQUzM/B+2ilpz0FEBdPchqgK4gXtfFTvFwSZqNawo8c0z1K6pcoRVQwNq2bOtJj1F2skmTyrV9vGG+0OfUE0fHeyftmI+jG2UUai9+W8H29ojNcEtJaYRLVNzbwQZr+WuFAel35+AXOvPSGghOpwPL/6mk6pFgqW4KGiH3bsRC4nOwfhK6QvuDaZt7QA7PAdohxenFNpr7BsZ2Vxjaek1PCdJIadH1nzAv4ngEdaqriTlL44yTsB+/3OUhZAIEPK+jpgjWgYLDFrquGfrckmp1fLxK5dfyP0qAoYGHkEIozjrZvk7iIwp8NugdGdVybbdzud3Ff568nhCCFmZGKKrpFV2Lgg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(376002)(136003)(451199015)(36840700001)(40470700004)(46966006)(16576012)(316002)(70586007)(70206006)(4326008)(8676002)(6666004)(336012)(26005)(426003)(53546011)(47076005)(2616005)(478600001)(81166007)(54906003)(110136005)(356005)(36756003)(82310400005)(82740400003)(31686004)(186003)(2906002)(44832011)(31696002)(40480700001)(36860700001)(40460700003)(8936002)(4744005)(5660300002)(83380400001)(41300700001)(86362001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 13:40:06.8099 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c1f91bbd-4557-4295-0ba2-08dac8a13d44 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT065.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7038 Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: > Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169 > Affinity level 3 is not present in AArch32. > Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106, > Affinity level 3 is not present in Armv7 (ie arm32). > Thus, any access to affinity level 3 needs to be guarded within > "ifdef CONFIG_ARM_64". > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel although, IMO the commit msg does not reflect the change (i.e. you do nothing related to accessing MPIDR, but instead you are just not taking the Aff3 into account for AArch32). Also, I'm not sure why you used VMPIDR and not MPIDR. ~Michal From xen-devel-bounces@lists.xenproject.org Thu Nov 17 13:43:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 13:43:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445222.700290 (Exim 4.92) (envelope-from ) id 1ovfAc-0004f4-Ei; Thu, 17 Nov 2022 13:43:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445222.700290; Thu, 17 Nov 2022 13:43:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovfAc-0004ex-Bl; Thu, 17 Nov 2022 13:43:10 +0000 Received: by outflank-mailman (input) for mailman id 445222; Thu, 17 Nov 2022 13:43:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovfAb-0004er-Dw for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 13:43:09 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20630.outbound.protection.outlook.com [2a01:111:f400:7e1a::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c4bd42f1-667d-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 14:43:08 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7334.eurprd04.prod.outlook.com (2603:10a6:10:1aa::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 13:43:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 13:43:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4bd42f1-667d-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NKo2wddXWEr3NtdBocU7IAnWj/AjFb+f1NOomQ8d/pxiewZVKmHBomgx72KA4xH9t7CqGGwX4gw+Em/t7Q4AUUh+xIaHGpvJlOKKo+/imBKUKXYLMnWDjKmp4QNkUmbwQ0tC2UgY46WiPWEhy59oPqYougEsv/MrQzaLTLp9u7cAQFwMgYwYYJOkEEUp0pt2PyxQ0p6yPOVW9q8eYDBWNBhGYR60JJOEc9mkahLsAaxXrteHPaSI1fcnv5zj13r/F2xyzpde8cwi6UBV/AjTnbYRJpavIkVE4hleCvw2H4r3TT/iDuiiiSZC3SD1Bis1d3heCYqtgDLkdqqJ3R+5rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8BdQr5hmwXN65YhynlS5KUnisl+BNxZqEDvcJQUzAEk=; b=kO5ixbaokZtU89YWyUa7Nwu8EDz4RuM+OoM4GZA2ii3Mcs1HHlaSTdf4I0LN0gRIZwhIkv9o591o2Sx7gQ8CJ1aFjMZBq6e/3f9dENng8tFZoqaYR3fqNemfza0oIGUT2AjpkwYw37ei0bxCosAGEok4VWgxudU1al6d3vT3JDcOHZbMw0cNvwCvX3fjx+LHVAl851oOu8KdvUHBwtkVMUdtFan5Qi5hqA2Sx7Sa/xnlF1oUnEseJrI7etbv3aoz4X+6Wf9Gg2pYwDrTLuOPNejIHz48t7ZCydwS0b+9WgkMP2nDUR8j9oWe4LdFWkg5A5h5bPTDC3cd57H6AciMyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8BdQr5hmwXN65YhynlS5KUnisl+BNxZqEDvcJQUzAEk=; b=zQlSXhTF2lQH/wTrqmHXoI6W/23xc1vMq5zdITwkeiAJEXzdY3uxsvcX67V9/LDrSxSIhvyh5MAEarIfCV/pmC9avpR2BWwyEdcL/0cMcp7y7jo/OPMEsHvmKy0Rp11oTQ7ryQMQxXTZnLWcu+JYO2X1ORrx9A6UxHpGf16iXR8OvroSQ9hD0LZP2UT11bvN0TQIRlwFmC68WImeaLfn/rOujaBLZdlX4mnfru4PEgMU5pCw1YR4144aXOoLIk8KFZMALIxpW2NAoLesCh46WSpm/omkqcByQi29mZNLzfYtM45bwqh6Cme5ipx+nkyi3FUz3vnDoJUfEIs2SVU1Mg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1d3324da-16d2-2230-2fb4-433ef6acfc3e@suse.com> Date: Thu, 17 Nov 2022 14:43:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared Content-Language: en-US To: Andrew Cooper Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , "moderated list:XEN HYPERVISOR INTERFACE" , Thomas Gleixner , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , "linux-kernel@vger.kernel.org" References: <20221117114122.1588338-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0179.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7334:EE_ X-MS-Office365-Filtering-Correlation-Id: 856033f3-3f3a-4a2c-5d55-08dac8a1a80c X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l4VSoyjaDYgNtCO7dp6MKQs3CqEpyxR1jVrIJnFUUBlyBAyTT7KMNvFl6FNKv6+Rf/O2vHBSphPX6C3QD4MftjYvdhQHMEidRhuZ4zAl2CnBy3PdLMUV6vZCNpVjSAfmIQ21oX3LqlLumkLfTU1zxIWRU7ufcprxvPCl+vgYWWbkg2TRg+ORWd2nXcLTuAHPqc8/8TewJZbgOmNnQ/sWk5rBobBfcZqYEOqZatQouvskt6jUOIanZCWHJflrkA3zfz72q+J19ubVQGAQBsMrdMAuphpZlr9feURkxNGaIienR9lexc+LcaVzvdeBRrrXopsCohQ6F90UJ8vGW532JMgaD7o4zRSO70vORsq6J64E2MX+THVHFuOvSzkzV9WN4kJoz+m1C2f+4wKRrqpIC1wjSUgCFkYN3xOdb69o+iSHw2u4fn/1WiPMhaZKtEVAgdFU6danbyF43nAyRMAPxpbadUeCFMsp0tZtfMnM5gKUT4D4RkRWaMXx4E6sDubAH/ciMvdJx8iUHZkVozIXZCB4vlmuQBBfcdNVcU5V42a3Smpp1kN+5Rn38ak5WHLnk7JvB29mlMERrHUa/ybkXZTlzuGysLVFNeG/2meGgB22dmhUWk0lYhn2BIWsxfPnKg1wKvf7ggGRxnEI266+/Zr5jGN65fO7c3jmZHPQ0MSOIxj3I81fEWZLFPIwWRyy+ntEw7+9Ql5tXarxZyJYkjKBAhwf0/LBiCwtELe4JtM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(366004)(136003)(39860400002)(346002)(451199015)(31686004)(2906002)(83380400001)(36756003)(41300700001)(2616005)(31696002)(86362001)(38100700002)(6506007)(6512007)(53546011)(6916009)(54906003)(26005)(8936002)(186003)(5660300002)(8676002)(66476007)(4326008)(66946007)(66556008)(66574015)(6486002)(316002)(478600001)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3kzOTRMYmZ2dTBrTWVEL1MxZ0xLQWtOcXoxeVhOZ3VFMWhyTVBqUjVkck96?= =?utf-8?B?cklSV2twc0swSElQbGFuYTR6QzRaTkNRcjNWN3hDQzJkZHNXQ1RlakdHWFhs?= =?utf-8?B?akJRRnRYb0tRY0c2a0ZRcjlxTld4aDR2OHpucEdyaG9SbS9lc0Yza2grU3hK?= =?utf-8?B?MnpaeXNnVitxSG9qNzlEeFVJdnhpQmFoeGFHRWhEZjUydExvV05sZU5aOTR5?= =?utf-8?B?bXJCT3N2djFlSzVJaVZjTmd2b2lUbG9NYVdPdjRMZllDaHFnZkxNd3c2bGl0?= =?utf-8?B?WjYvNzNSK1l2VkNSbDN0MUtZeWs0QnB3NU05NXV6aS9iMlpPV1Z2WEJMR2d4?= =?utf-8?B?SW56TU5XL2pHOVlackFpMk4zUkpqYnRnM3QyWEVseHVIWUp4YXNKeUhaQTRW?= =?utf-8?B?TjlTK3EzaHZxQlZMRit5Vis4QXVMNkgydEJHREdqNEFtRFZGSC9NZitGb0VH?= =?utf-8?B?Nm9HVXlzL1l3SENvajBVenhmTHVjOEd2cFRJWm1acWFTWFhDT1h1NjFlNFVD?= =?utf-8?B?NjFzZ3pwTkxrRHZZWE1NNWFzSldHR2FYbEJ5SmRFVllzWHRndW5ON3BUak1U?= =?utf-8?B?c0lYOTlDdlRKMUtFODNTdldTZHJDKzlaWUx0RUgvZThrdmJvSTFKb1JKVlZ0?= =?utf-8?B?S1VEOTRIMUwwK2V2UFZwYWRLNHc5endmU1lTWlVaU29OV09CMUR4YitiTXlE?= =?utf-8?B?d1hYUlMwQmpMaVZTcGNndUJDWmVURDZqMnVzd04ycEZLRzlsbDZ6ODkwMDBJ?= =?utf-8?B?SGdPT1c2cUhvVi9aVk9uTnQ4NWFncDZQeFUxcGg0YTZMdTZoMzZ5Z2xjdmtF?= =?utf-8?B?RW9YcklkTnYxRWpUZ0lwWFVyNmJWeXRZUHdLMUJBa2w0UmFIS0pNcDFFM3Zn?= =?utf-8?B?aTdvWGVsa3ljWG5YTUUwSEFwRFo1WDdtRFFQa0l0eDhNbXFIY3BVLzlWdDNp?= =?utf-8?B?Qk0xZWJoU1lpV0Z2L3dhSmw0SEUraXplR3dHRm84ZENIUUVIYUVlWExobDgz?= =?utf-8?B?UVRjRXN4QWtmS3d3QStZTXk1aDFnM1hnMFNSSWd0WHUxemdyaXZsRXM4OXg1?= =?utf-8?B?M0RuMjlJcFQzSnVuMU9FR25EZHpPcjVteTFtQnJOdGRTWHdDZktwNzVhaTBi?= =?utf-8?B?QjIxSU5xRE9VT0JXYmZKQzFzS1BBb2ovMXdwbDlQUmpCVU1nWXdHQ3UyZXFI?= =?utf-8?B?Wnl4aVV4SjI1ZmJUMStmd3cyalZRelh2Mm1oTEZsQnRyR2VpbGRPeG5zY0x3?= =?utf-8?B?cHY5cjZjZUNZYlgyZEhuMCtWV3NnZWdJQ2VkS1BMV0kzVkNxTndKN0ZDQjYv?= =?utf-8?B?N3VhcnB3NTRhdE5kQXV5N255U3RmVGwxN3JZbVlhU1JBZmNnN3NubitHTVVI?= =?utf-8?B?MXF5NURBY3hKUHp2d0x5QkFFVDh4dG5TclVzZXlnazdFRFpJYzM4RVI5dWlC?= =?utf-8?B?UEhvcUVmaXFIaFRJcjBvU2tBd3VCZjNOaXp4b0xnWFEvRnVPdC9FdTRJMkJm?= =?utf-8?B?Wm5nREJleHh4R1E5N01BUE9NR3VEU3FOZkpzQUwrWTUvZXNWaXhXZjRXQzM0?= =?utf-8?B?Vm5pZU1RelRCUmEyYnRlOFF6TTVFNkhFZWNLaVVvN296ZGVsbTl2OXdVY01L?= =?utf-8?B?L25FcDdGUnVOYzBrQ29lOEtBckxtZklJeHBVTXY0WmNOeFpQODNUK3JQcnAw?= =?utf-8?B?WVZ4YTR0TjJhb0hZeUd1enJVcGRFTjNBWmN5THZtc09HQi9ydTFrdnJNMDFG?= =?utf-8?B?Q1VxSkRXaHJxMHVJbVJVMytseUtQU0N2Z2JDWTR2elBJclU1Z0cxNFFYZ09v?= =?utf-8?B?ZXNRYUNSMEJmVTlVQkVaQ1M0TFp6VDBmTlRRazl3a2JHcUE0SEFXVTB4bCs5?= =?utf-8?B?RDRlcUxoOUt3ZVdTMlFvckI3U1dFVkxVcUVXNU9XVVVWRkFjY0ZGZFZaMEFX?= =?utf-8?B?K1VMZDJlZG9MSXFOM1AvVDZtaFB2MkZMZGRTODVWamlhMUNtcG91aXpFWk1h?= =?utf-8?B?RHZXakl6QWwxT0c2SVpDajJqdzRyb210VG16NVd2My9oam5GSEwyN25ZaFFV?= =?utf-8?B?ZDNqRDJPZ1k3eUs0dWxjVHhTYk5Td3FWbklzVitRS0xycHhvN1p1QmZHYjJj?= =?utf-8?Q?BI/50KFvYg45D18bIEYBkVf3I?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 856033f3-3f3a-4a2c-5d55-08dac8a1a80c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 13:43:06.1800 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +aj4HkC60nOhpuqg3vX/MkgCg3AXfY4oP14v7QkWx5Ve6tQ8xHI7NF+iQJ0PSikT1jz/yIuYGooC2nonZkG7oA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7334 On 17.11.2022 13:28, Andrew Cooper wrote: > On 17/11/2022 11:41, Marek Marczykowski-Górecki wrote: >> Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until >> the table is filled. Then it disables INTx just before clearing MASKALL >> bit. Currently this approach is rejected by xen-pciback. >> Allow setting PCI_MSIX_FLAGS_ENABLE while INTx is still enabled as long >> as PCI_MSIX_FLAGS_MASKALL is set too. >> >> Fixes: 5e29500eba2a ("xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKALL too") >> Signed-off-by: Marek Marczykowski-Górecki > > The PCI spec states that devices are not permitted to use INTx when MSI > or MSI-X is enabled.  The mask status has no legitimate bearing on irq type. > > INTx_DISABLE exists as a bodge to mean "INTx not permitted even when > neither MSI nor MSI-X are enabled", and exists because in some case, > transiently disabling MSI is the only safe way to update the descriptor. > > > I can believe that this change fixes a an issue, but the logic surely > cannot be correct overall. Question then is - what can we do without altering the sequence of steps Linux (and likely other OSes) take? Imo Marek's proposal is the least bad option, because everything else would be more intrusive or wouldn't take effect for existing released kernel versions running in guests. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 17 13:46:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 13:46:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445227.700301 (Exim 4.92) (envelope-from ) id 1ovfDM-0005Gb-SZ; Thu, 17 Nov 2022 13:46:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445227.700301; Thu, 17 Nov 2022 13:46:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovfDM-0005GU-Ps; Thu, 17 Nov 2022 13:46:00 +0000 Received: by outflank-mailman (input) for mailman id 445227; Thu, 17 Nov 2022 13:45:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovfDL-0005GO-Gu for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 13:45:59 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2062a.outbound.protection.outlook.com [2a01:111:f400:7e83::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 296453d8-667e-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 14:45:57 +0100 (CET) Received: from DS7PR03CA0217.namprd03.prod.outlook.com (2603:10b6:5:3ba::12) by MN0PR12MB5812.namprd12.prod.outlook.com (2603:10b6:208:378::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Thu, 17 Nov 2022 13:45:54 +0000 Received: from DM6NAM11FT039.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3ba:cafe::49) by DS7PR03CA0217.outlook.office365.com (2603:10b6:5:3ba::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 13:45:53 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT039.mail.protection.outlook.com (10.13.172.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 13:45:53 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 07:45:53 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 17 Nov 2022 07:45:51 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 296453d8-667e-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BqPM8M8BAcoxsvfgmN1n05XAxjj79lY/Txu3SgFADYNIGrBRYZl0QgG0LXxDdtw1Uq0fIKwWhYD3Lk3FQcqKhJC3TpvxPkjCFKT+fG5h5z4GcS8Q/Dry1QqLc/RRVT013OddJr43MSR51CsvvnmWtAKHESb1vFYX4VD5PY6Lz5JDC2MFex+Zberlh1IM784HtaASj9tLhYcXTlMqAJ+O755pW3kenE4iMp3c51DW/sxN3MDmdpAYldEOp1IFlGUPrvWJPi7J6lRYOyvr92lsJF/NNMNCgLvMTUHXpZKsS99Q3ffMi3166xUB7Tmm6XMP7sb8J4Fa9Zw7Xt8Kl+NTBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8BAk/TnPe3gIY2QdjrinC/eQ4kYJI22yvxAgwDf6BJw=; b=oT0FfSfRAFpsWe+Mkry7gjJdsUCeicKp24Z6oOnoooqKUI1HDsGGujX0YHswk8a7zbCx1N5o66BUSl8gQgVcHHbMQo07etncxMPZsVTCl/w9EIpMzEZyEMDnRkpMRSvvAFm5jajHL8rTzjeBN/hk6SnRVhRn5rEZ9hy/UwXNfJuDyouJYLXaqnHxqhm1lglRyaW+dduyriPlQrGVXa09Gno7r31O6uDrahds6HMP46dxWLhRoOvtrCRhF8v4ROs1o6mO/m+oKGTEsuXVPtjWiS4U6JfOwnrWO+zvpgFra4yGMknt+a6ij9vZjj2bbMlz/83dXFP1Dp6zoESbxeqoYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8BAk/TnPe3gIY2QdjrinC/eQ4kYJI22yvxAgwDf6BJw=; b=F9IEX9k4nvQKJr0KveEZ4K1LzBzzdX7emaUi6gKdnE548MZOIZADQfX/YqFWMTXcZO8qQcMMoB8iJz2fVZKnDJ+hSA8zG9yZQUpnyrmjsNfgYWgerWekx/ukEgr80sLs8d1rjsgBv6Socl00qZytwNMlIvjqSFqaLuN5q1996GQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <6c3ecded-7e98-2fc9-dc92-fcb6117922f2@amd.com> Date: Thu, 17 Nov 2022 14:45:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN v3 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-5-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20221111141739.2872-5-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT039:EE_|MN0PR12MB5812:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ee7cda7-d0eb-41f6-b417-08dac8a20c02 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GVnMZ5IikYIto9wXcYk4QWSj7Bdz2tmH4OIOvqeUwyl9DZ+71B2E4iY9v38fGcUDjsSohkQ9U+2hZG5dQnFeL/dwBFcY5IX2MshcafcaEjSKbT0rEbZUwDL8/Xg0ZO47/1RpQZj0O7spHngVb0WAsr8hnatYZsqyu0i1WIiIscV0hzdNJXBf9PaPKJvTKhk5Wfbfs2JMqmr9hPvn/QEuc2RcFfnAX2vdtOEBglptIxRAtMgdXNRDgfFSxkDRMFp8qrhRiPkrqkc4LmnaIlGabX6EpaMEDECdw1msy4aMitZsdJwblkdzxa8bQ4qc6Hafy81JUP06iYRHuEsgSNZ9fkP6LR5d6yB1LoRcqh3xosKxNKYQiQNKRSy77iqntYL4uNvMJhH4Kj8bOHbWv48+Nsrz087MrkFBmouFIRNEYWOUz0ZJJuVYlBZBcnJ704J3ogx/ya0LUj/6Re/Wxo5KllunSkk2+gmHn4VOpfLU49KtzEjlqmpm2Vkho7WgowSD/Lam74nQCtji8goYPfV6CU6ovwPTiKVN9BhV5W5lZBb/i38Wm0+N51kf9OzRCc7AnHLViy5taBdeprR1/ANimGfqod4WrALkp5zKNDyxnTuEWAL+W6mY6EUSK8QgIQ1vTmmOctv8uth1zFTnhXpXkk5ckLbUuyPfXR5s9pL0Fr0DzCvucKrZy1t5JXLEsaYs3gAWyZvvf/XlhE539bRuf+9vVdYCQH5tRUPPnzs7MyXefvsEv/43U3aW0NdSppR9KgSBXns8Ad2PbQeKpO5DYw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(136003)(396003)(451199015)(36840700001)(40470700004)(46966006)(8676002)(70586007)(82310400005)(70206006)(4326008)(83380400001)(36756003)(36860700001)(4744005)(44832011)(41300700001)(81166007)(82740400003)(356005)(40480700001)(8936002)(426003)(53546011)(47076005)(186003)(2616005)(336012)(26005)(478600001)(54906003)(86362001)(316002)(31696002)(110136005)(16576012)(5660300002)(40460700003)(2906002)(31686004)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 13:45:53.7482 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1ee7cda7-d0eb-41f6-b417-08dac8a20c02 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT039.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5812 Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: > > > Refer ARM DDI 0487I.a ID081822, G8-9650, G8.2.113 > Aff3 does not exist on AArch32. > Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106 > Aff3 does not exist on Armv7 (ie arm32). > > Thus, access to aff3 have been contained within "#ifdef CONFIG_ARM_64". s/have been contained within/has been protected with/ > Also, v->arch.vmpidr is a 32 bit register on AArch32. So, we have copied it to s/copied/assigned/ > 'uint64_t vmpidr' to perform the shifts. > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu Nov 17 13:51:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 13:51:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445233.700312 (Exim 4.92) (envelope-from ) id 1ovfID-0006jZ-F0; Thu, 17 Nov 2022 13:51:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445233.700312; Thu, 17 Nov 2022 13:51:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovfID-0006jS-CG; Thu, 17 Nov 2022 13:51:01 +0000 Received: by outflank-mailman (input) for mailman id 445233; Thu, 17 Nov 2022 13:50:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovfIB-0006jM-Ox for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 13:50:59 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0603.outbound.protection.outlook.com [2a01:111:f400:fe0c::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dd3269d3-667e-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 14:50:58 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7155.eurprd04.prod.outlook.com (2603:10a6:208:194::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 13:50:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 13:50:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd3269d3-667e-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BNJYR4jFZLCKUtbiJCUI8wPYiEKN1GX6hsyvrp/OaKlul5/3Di3+K2KICvvcp1b/h/wokkTxaRMLR++tSFjsMb5ee199aJMYPKWjxgqVcRBiXGaDfOo/UzsmgzCD3nWZyWqunfZRtGW4reJbqh5zUQnL2d3KqKT5TctOiE/5XMffb3ioHD4WFNyoFXaYyKFE0NCvjtMz59UiKM2kagXqQ8m3dbZufmVXJLVcss+oq8EFXLkEyPe75dOloFSXFyGxhB9uz7mGxjoMxghjkc1iQogY8orxovrLr5NwY8Yr0FDMuBsEppUnX3bKsWgNdi/E1Okc04h35yNTDrUkJN3/Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ofcvnwf3QX63P3Nn/kkg3fokokcoLmhBk0ljKAKcG9g=; b=hgUHuK7E11P4v/fowOTTFqdaNfasDj9qnGwRqI+CHzlZzJGib+/Ge07zCUSR70+QOVMKf3vTn9C1DMwlBbZswoU/dthGSK/EaymLFsiKz+02hsZI04ysbln8qkAt29eK2JOomDCgF2mliqiwIW8Ny/rSJCaDBTqKIZ4iHMrxuMOfuw3BdzgK+aBEwBd1LbktueZnpe0XLmAlyLcgjK/TfL0/rStkcejMBL0WT8WHrO7YBmCW4DzOpxoCBhWU7/5B5m0xGqPOxbOVvDjlhzmx0r3Y+icFH5rzoVZTv0RvEzG3JDsWRDAOHKbQm/u1uFPTqLsjE7HUQZH4CctYDaa8+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ofcvnwf3QX63P3Nn/kkg3fokokcoLmhBk0ljKAKcG9g=; b=Br2QLOit8nUSd7DPIEkOlFIUHp6y7Gu7Xqg7NfHLAsZs1OdQDl18WFRkuImDrffoH/cBLsUGa7N6LHyMhlKcay08wLUXVeMGXIXBCnKbCPXTQghGgwMI/gEF4JfXwfKomkfYC/GSBDZ3h5AKWudLM2O/qvBiShbmtg+yZ8X/jpnHVsG8gez1ZKrV3/8lAjizqxkoPvvWSsICJkrgFff2vvotuheAqSxNmxFjzXKFUpuw3YjRGnqZYxI083fqiDRDLlKHbEoEK3Heyryk5lwyWKB0r4sts+wkNtf1j7G9mApgp4gwyBkScVyY0QYDwlSU2bKkvxACq1UsM04WCU2Tbg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7a2b77af-1348-bf2a-f50f-dbccd8e2e74d@suse.com> Date: Thu, 17 Nov 2022 14:50:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , "moderated list:XEN HYPERVISOR INTERFACE" , linux-kernel@vger.kernel.org References: <20221117114122.1588338-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20221117114122.1588338-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0004.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7155:EE_ X-MS-Office365-Filtering-Correlation-Id: a6243986-29bf-4910-b1a8-08dac8a2c086 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Uy4rQPPVUEcvC7JSnu0TqZxPtMXVudXq1jeDLMKbDUsHIlqFXzY3f/kXN1qAGinNYUEgaRjjkBeHltIZIMlDKsjB2Dkcrfr2d11h35YxEbJbIMj6pfG8nZksgOLlVAHvTzPEPIaGnMeASs+ydp5eQPB7Yyqp2/srXAMm2CvpHP+0GFAzB0RGD14pu3gReNYdkEJ5oBbBRCy5xa3xFzESz44NMph9F8bDJBeBX27CrNfSzAB4UFO+X8u5epJ+2WNyU62PP4/NpkNNAc2jbctFuh3hmCLtSXIFHEy1Q6B+ETHkz6LLX+TrJjdf0ACOP3Gvlh2lT2bQEG++zabl4xodKN15tLteV8lxZczwJPugBaR+9ok1ONcmS2D7wfqwybacB2dVhQpu5cGSSenkyIRJoWPkd40iWRz83UwxESIN/ukLlp/23Ame3EUkC0f04QmQAWg0+p7xTwECT2vXPzRRb56BBiymUq9oJ6fMkV0S3+wvVrj9MjvZt/7SgcR5SK+OUA72iMF2BdOqz2Js1HCEn8pfOuQzEvibHAohBlQkmbrUNJ+lN4yRPXK2aSdDWX4DWbfRH2cmPRxaDS2rNVrouUUDkllSk6+cD4ph6l4b5vr7tqpayz0DI0PFT720k+hj3fOeugdznjo8FbliJg+Wz2Px3gtBYSvrA1VqpgQU3QF/olVYP88B1pSl5ybRYcHGc1xThkQGRSXzD0xTNDJi2cRFP7Q+CiHkt7eT+9XLD8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199015)(31696002)(86362001)(36756003)(41300700001)(2616005)(66946007)(66556008)(66476007)(4326008)(8676002)(8936002)(5660300002)(478600001)(6486002)(316002)(6512007)(26005)(6916009)(54906003)(53546011)(38100700002)(186003)(6506007)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjVYTDQ0OGVyMlljbmpibFlvSkNBSGFCTTF5eXhvVlNTbTZWK0xCZG5uM04x?= =?utf-8?B?emp6KzZrNlZSUUhTdmZBVXBNMnhzZXNrb0Y5Q0NENmVwTlNkRE9kVjRLdXl1?= =?utf-8?B?MFNPb0tqWm9abmFlYmZTdnBWd3pZd1pDU0ova1M4YWFiVThxc201aFhicC9R?= =?utf-8?B?cTBLaloyOWFwMVo1bWlKWVBUNEhZcWQraGhDNUhsZWgySUJzRWNhNTVqaStQ?= =?utf-8?B?YWtYdU12cUxYczlOZkNlc0FMMUQ1UlBlbmRvZDRWd0tQc29ubUhvY29tMVh4?= =?utf-8?B?Q2lCakxsd3VxY1REV3p5eXJIdkQ4K1VVQXlEbm1LRncrcExuMi95Sndyd2ll?= =?utf-8?B?ODBzSG9WQjlISVJEdkpmR2N5UXRkVFdFNFRRTTIyVEpQanA5MUl4T0I2b0pZ?= =?utf-8?B?cHpXRk8rbGh3OCs1VGx0bFFaYUllR05ObUlaQlJxWkplNk9LQjlUUzd2RDVt?= =?utf-8?B?VEdJVllreDdPcXBFUmI5WWdpallvOVM4MWhMSWZNU0F3QjRMbjNZbVhweW9O?= =?utf-8?B?NnVLcFlxTmhKalpFOVpYbmc5dVgvVkN5WjZxcGg3amJZSUd5aFdVUHRsMUI4?= =?utf-8?B?MmpscnVURlNYVnVxYUdBTE90RkhrU1Iza1RiTkZseEZuTmFSVVFFdjdQcmU2?= =?utf-8?B?QTEwWlV5Si9NMlJOeTdTdlJrUmVLRnlaZi9mUU56STc3bGVPMXVTM2Eyb1dM?= =?utf-8?B?VWNHOVJ2KzRhZ1phTnV4R3h3dXZIdlNBR1RTOW1TYjdQQlo0bzRQR1FsczhV?= =?utf-8?B?TGZlOEo1UUlrcUk0bzhDVVF1dHZia0syM3J3KzE4VmlGQkF4Y1kySFVQTE9C?= =?utf-8?B?SXlqbzI2SmxocGtOcHUvdG84cWRQcUtVMFc3NFk3RXdvbGxHNkJ3dEZsZ2NZ?= =?utf-8?B?TE45S0xqaFZLOEtNMDNkdFBaWXU0bVNpUnkwaFRLSWdrcE5XRmpKOExEUzZ0?= =?utf-8?B?WjRnbGFIOWpXTk1WNHVxY0p3NlptRVJsSnQ5MEtOcDhMUlJ2d2Vqa3ZXbGc4?= =?utf-8?B?T1ZhMkpVMk4yOU9Gazk4RDJibGNRNWI3bTExckVSZTc4dXBSYmxRUWJwVm0y?= =?utf-8?B?cisvMzRkUVQrOFk4M0xqbm5iRkFrRjlhNEhqMDJkcitlUHFZaXI0Ly9sKyt5?= =?utf-8?B?WHdHMExjTCtVZzlDMHlJRkppMm0yMGNZWDFLY0RXazNTTUpQRjdTclhaT1J4?= =?utf-8?B?ZEkwTWxlWnZNbzFvSUJPSXVXRlBhYTAycjU4NXNtRXg2ZVI0U1FkL0ROMW5H?= =?utf-8?B?RmhuNjQ4R0NZWFFVZmtreTBQQUk4TW1QdFVzMDRiekR2MUhGQnRvcTRpVi85?= =?utf-8?B?dUpzMVQ2SnYrYXpGUTN5VDRNY2NXYzYwZXk1Kyt3NmJFRlZsaWtiWjRaVXdH?= =?utf-8?B?TmhtaDNmdGMzR1RlTys2b3Z6U2VRbm9wUW43VjdQK0VCVUhCR0ZiWjVMc01z?= =?utf-8?B?cUJ3S280MWgxZWlqcXprRUFoU3dmNk9KMW5Ic1FoTStmRGh0b1VObFpkdDkr?= =?utf-8?B?S3EvN05FT0V4ZnZEeDl0RTAvOTJEYVNaWjF1d2IwS3pVeGRTSXNEaEU2Rm1X?= =?utf-8?B?SCszOHR6OENQWEVJaHg4Skh3R3dNTU5tRTJ3MXRaSmxPQ0lpZmtwODM2VjFn?= =?utf-8?B?UnEwc2UwSFJVZlJ2N2FrT0hjYTREL1h5eWFQdy9MK0ZlZUc5ZlB3T1M1bS9Z?= =?utf-8?B?dDFRQkJ6V1E0dXV4MWdpTVR3NWEvMFBwQmE4Rzl1ZXR3UFB1QURVc3ByVVNj?= =?utf-8?B?L3VXZW5ZVnN6Yk9kTlVyb0VNcHdYekNPRG5hSXVDMUFDaG05TG42Q2xaYm1D?= =?utf-8?B?aW14WnBDL01WVkZkdjY0QTBPdFVVTHErWVNOck1zdkVEdzlXdzJycm1VOEJZ?= =?utf-8?B?dnA3VVBwY1RIcmMvVFZYeUNZaEM1eHU3a3ZUQzgvU2s5WitIbG11Zk9SeFln?= =?utf-8?B?alROYjFLZkp3YTl4RjNYS3BOUkdNOEplVU1qYlhRRjFYZ1p6VERiNWtOanMz?= =?utf-8?B?MmJObWhDOTNYMUJ4SWY5WHZHeXVZc2kxVHB0TmR6bUlpMGNlTXU3SDhrL2t3?= =?utf-8?B?TEdjQkxncEJuTHdLc09UZHZKSnlmNnk2a3pnS3lPWmMyQnlheHdsbkZqT1Ur?= =?utf-8?Q?z+fWDPa8DmiBAooOsb3iEPWQ5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6243986-29bf-4910-b1a8-08dac8a2c086 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 13:50:56.8062 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zi3eohJgDgQSLd0k0zShI1Q3Bps+fasvh11YL5WPvrLblkSrWm4E7AkzKo5Ge6y00R3MswW0DTfsekOlHM43jQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7155 On 17.11.2022 12:41, Marek Marczykowski-Górecki wrote: > --- a/drivers/xen/xen-pciback/conf_space.c > +++ b/drivers/xen/xen-pciback/conf_space.c > @@ -313,7 +313,7 @@ int xen_pcibk_get_interrupt_type(struct pci_dev *dev) > &val); > if (err) > return err; > - if (val & PCI_MSIX_FLAGS_ENABLE) > + if (val & PCI_MSIX_FLAGS_ENABLE && !(val & PCI_MSIX_FLAGS_MASKALL)) > ret |= INTERRUPT_TYPE_MSIX; > } > return ret ?: INTERRUPT_TYPE_NONE; Considering Andrew's reply, maybe it wasn't a good suggestion to change the code here. If, however, you/we decide to keep the change, then please add another pair of parentheses around the operands of the left hand &. If the change was to be dropped again, I think ... > --- a/drivers/xen/xen-pciback/conf_space_capability.c > +++ b/drivers/xen/xen-pciback/conf_space_capability.c > @@ -242,6 +242,10 @@ static int msi_msix_flags_write(struct pci_dev *dev, int offset, u16 new_value, > if (int_type == INTERRUPT_TYPE_NONE || > int_type == field_config->int_type) > goto write; > + if (int_type == INTERRUPT_TYPE_INTX && ... this would need extending to also cover the INTX|MSIX case (i.e. if a second such write made it here when the enable+maskall bits are already set). Jan > + field_config->int_type == INTERRUPT_TYPE_MSIX && > + (new_value & PCI_MSIX_FLAGS_MASKALL)) > + goto write; > return PCIBIOS_SET_FAILED; > } > From xen-devel-bounces@lists.xenproject.org Thu Nov 17 14:08:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 14:08:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445239.700322 (Exim 4.92) (envelope-from ) id 1ovfYu-0000Ew-1p; Thu, 17 Nov 2022 14:08:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445239.700322; Thu, 17 Nov 2022 14:08:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovfYt-0000Ep-VN; Thu, 17 Nov 2022 14:08:15 +0000 Received: by outflank-mailman (input) for mailman id 445239; Thu, 17 Nov 2022 14:08:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovfYr-0000Eg-Tf for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 14:08:13 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 43fdcc76-6681-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 15:08:11 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43fdcc76-6681-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668694091; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YKHpP6lW34JfMJYVx9EtDiHz3wiqsWRfcLv69bvn/DY=; b=RgEyz7ekIjmNkrOG+A+Zc0petcv7bOlw7VKkun24NLUkGnbjgoO8676F 304KKdqyfBr909sos/QBjdDXAp2JSfQJTiee6MiYUVLYUdxpTn6XdMgS7 vL4Xi+ey/DmpRhsQHYlsLickjpFzqDp5WAedJIxhNL2s5Z5StcsuRPXSf I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85029151 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:vMwkW6CxvfwgsRVW/97jw5YqxClBgxIJ4kV8jS/XYbTApGkmhGZRz zQfW2GHPfiMazT2LtB0b47g8BxVvJbQmNNgQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpB4QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5/9vLUdPz /oiLBM2fCKCmM29kJm4Y7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/AZQinOCulz/nfidRsl69rqsr+WnDigd21dABNfKFJ4TQFJwIxy50o Err3XrdPE5GKeez0D6GwkChl77Ptnj0Ddd6+LqQqacx3Qz7KnYoIB8LUVq2p9Gph0j4XMhQQ 2QP4TYnp6U28E2tT/H+Uge+rXrCuQQTM/JuFOk95BCI27DjyQ+TDWgZTRZMcNUj8sQxQFQC9 lKPhcKvOjVpv5WcU3fb/bCRxRu4NDIJN2YEaWkBRBEc/tj4iIgpi1TESdMLOL64iJj5FC/9x xiOrTMinPMDgMgTzaK58FvbxTW2qfDhbCQ4+wHWVWKN9R5iaciuYInAwUffxeZNKsCeVFbpg ZQfs5HAtqZUV8jLzXHTBrVWdF202xqbGCDFmXJJHqMnzTCOwGyRfJ9/62FVJ248Z67oZgTVS EPUvApQ4rpaM32rcbJ7buqNNig68UTzPY+7D66JN7KidrA0LVbap382OSZ8yki3yCARfbcD1 YB3mCpGJVITEuxZwTW/XI/xOpd7l3lllQs/qX0WpilLMIZyhlbPF9/p03PUNIjVCZ9oRy2Lm +uzz+PQl31ivBTWO0E6Mec7dDjm10QTC5HssNBwfeWeOAdgE2xJI6aPn+N/Idc5wP4Lyb2gE pSBtqlwkwOXaZrvcFviV5yeQOm3AcYXQYwTYETAwmpEK1B8ON3yvc/zhrM8fKU99fwL8BKHZ 6BtRihBa9wRIgn6F8M1N8ih8tM/KU/z32pj/UONOVACQnKpfCSRkveMQ+cl3HBm4vaf3Sfmn 4Cd6w== IronPort-HdrOrdr: A9a23:XbrnQawkNawxqmJC51o+KrPwLL1zdoMgy1knxilNoRw8SKKlfu SV7ZAmPH7P+VMssR4b9OxoVJPtfZqYz+8T3WBzB8bBYOCFgguVxehZhOOIqQEIWReOldK1vZ 0QFZSWY+eQMbEVt6nH3DU= X-IronPort-AV: E=Sophos;i="5.96,171,1665460800"; d="scan'208";a="85029151" Date: Thu, 17 Nov 2022 14:07:59 +0000 From: Anthony PERARD To: Andrew Cooper CC: Xen-devel , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang Subject: Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls Message-ID: References: <20221117010804.9384-1-andrew.cooper3@citrix.com> <20221117010804.9384-4-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221117010804.9384-4-andrew.cooper3@citrix.com> On Thu, Nov 17, 2022 at 01:08:03AM +0000, Andrew Cooper wrote: > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c > index 2abaab439c4f..f8f7b7e81837 100644 > --- a/tools/libs/light/libxl_dom.c > +++ b/tools/libs/light/libxl_dom.c > @@ -1448,6 +1448,25 @@ int libxl_userdata_unlink(libxl_ctx *ctx, uint32_t domid, > return rc; > } > > +int libxl__domain_set_p2m_pool_size( > + libxl__gc *gc, libxl_domain_config *d_config, uint32_t domid) > +{ > + libxl_ctx *ctx = libxl__gc_owner(gc); > + uint64_t shadow_mem; > + > + shadow_mem = d_config->b_info.shadow_memkb; > + shadow_mem <<= 10; > + > + int r = xc_set_paging_mempool_size(ctx->xch, domid, shadow_mem); Nit: 'ctx' could be replace by using the macro 'CTX', without having to declare a local ctx variable. With or without this changed, patch looks fine: Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 17 14:10:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 14:10:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445243.700334 (Exim 4.92) (envelope-from ) id 1ovfay-0001ei-DF; Thu, 17 Nov 2022 14:10:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445243.700334; Thu, 17 Nov 2022 14:10:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovfay-0001eb-AT; Thu, 17 Nov 2022 14:10:24 +0000 Received: by outflank-mailman (input) for mailman id 445243; Thu, 17 Nov 2022 14:10:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovfax-0001eV-T2 for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 14:10:23 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 91c02177-6681-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 15:10:21 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91c02177-6681-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668694221; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=NbBL91ryQ3jGTOa6OG3JK7kUICBAy7tmxRa0YCaTLEE=; b=UogpPJc9cdwfEWmYhf3o6C3ZrUGAPXPpBdbkLV1IXyHsVpjhV7nE5PIJ 1WTKzHWmz2hHwfj8dmDbviKMEhWe2j2liVmgJcv4nkOjegjzvQP6rFUjc t3kIeDlnDsreV8TaLv14xYH1Ej662x50VkjBj0M74hQzlZYtMqzUZW8op M=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84614549 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:xUV/yKL52nx9KfIpFE+RJpUlxSXFcZb7ZxGr2PjKsXjdYENS0WRRy DEaDDvTMqrbYmejet4lPI7i8U0FvZ6Gx4BnSgFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wVhPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c53WVwW8 L8VMgsqTRDTp+Cm/YP8c+Bj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUozWG5wJwxrJz o7A13zIAQAhO/yf8DaA6nT22NLUoyHVV41HQdVU8dY12QbOlwT/EiY+V0a/oPS/ol6zXZRYM UN80jE1saE4+UivT9/8dx61uniJulgbQdU4O9M97AaB26/F+TGzD2IPTiNCQNE+vcpwTjsvv nepktXzFHpQubuaYXuH8/GfqjbaESIYN3MYbCkICw4M+cD+oZobhwjKCN1kFcadntDzXD393 T2OhCw/nKkIy94G0b2h+lLKiC7qoYLGJiYXzAjKWmOu7itieZWoIYev7DDz8vJoPIufCF6bs xA5d9O2tb5US8vXzWrUHbtLTOrBC+u53CP0gQZSR5xi+i6W3F2jLaBS8AxPY35gPZNREdP2W 3P7tQRU7Z5VGXKla65rfo68Y/gXIbjc+cfNDa6NMIcXCnRlXErepXw1OxbMt4z4uBJ0+ZzTL 6t3ZipF4ZwyLa18hAS7SO4GuVPA7nBvnDiDLXwXIvnO7FZ/WJJ3Ye1bWLdtRrpjhE9hnOky2 4g3Cidy408DONASmwGOmWPTRHhTRZTBObj4qtZMasmIKRd8FWcqBpf5mO1/K9I/xPgKzLmXp BlRv3O0LnKk3BUrzi3TNBhehE7HB84j/RrXwwRxVbpX55TTSdn2t/pOH3fGVbIm6PZi3ZZJo wotIq297zUmYmqvxgnxmrGn/dA8K0n23lrUV8dnCRBmF6Ndq8Xy0oeMVmPSGOMmVEJbaeNWT 2Wc6z7m IronPort-HdrOrdr: A9a23:DmDCm6FWL5ODQ/5UpLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5 uIGJIeNDSfNzdHsfo= X-IronPort-AV: E=Sophos;i="5.96,171,1665460800"; d="scan'208";a="84614549" Date: Thu, 17 Nov 2022 14:10:02 +0000 From: Anthony PERARD To: Andrew Cooper CC: Xen-devel , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the paging mempool size Message-ID: References: <20221117010804.9384-1-andrew.cooper3@citrix.com> <20221117010804.9384-2-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221117010804.9384-2-andrew.cooper3@citrix.com> On Thu, Nov 17, 2022 at 01:08:01AM +0000, Andrew Cooper wrote: > The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: > > * All set_allocation() flavours have an overflow-before-widen bug when > calculating "sc->mb << (20 - PAGE_SHIFT)". > * All flavours have a granularity of 1M. This was tolerable when the size of > the pool could only be set at the same granularity, but is broken now that > ARM has a 16-page stopgap allocation in use. > * All get_allocation() flavours round up, and in particular turn 0 into 1, > meaning the get op returns junk before a successful set op. > * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, > despite the pool size being a domain property. > * Even the hypercall names are long-obsolete. > > Implement a better interface, which can be first used to unit test the > behaviour, and subsequently correct a broken implementation. The old > interface will be retired in due course. > > The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to > more easily support multiple page granularities. > > This is part of XSA-409 / CVE-2022-33747. > > Signed-off-by: Andrew Cooper > Release-acked-by: Henry Wang Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 17 14:20:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 14:20:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445251.700344 (Exim 4.92) (envelope-from ) id 1ovfl7-0003PU-BQ; Thu, 17 Nov 2022 14:20:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445251.700344; Thu, 17 Nov 2022 14:20:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovfl7-0003PN-8r; Thu, 17 Nov 2022 14:20:53 +0000 Received: by outflank-mailman (input) for mailman id 445251; Thu, 17 Nov 2022 14:20:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovfl6-0003PH-Cl for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 14:20:52 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0870d475-6683-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 15:20:50 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0870d475-6683-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668694850; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FnX4fENahDu3/FW9ByIAJzGevrB1DCRjbffI84bZ13g=; b=EhCGVeFj/td7S2uOXIT8z+hmYEScgztYK1YacwliOof7C8lVrgxCHWYb 8Qj4rOF9no/mUjAkXb9GBLImkBJ1560avR/iGk4eyslOiuOQUdX02OTeN YlWa/qSwh3J1ZzBfxXkyOjFUys0xjhCCZsIQvLXkkJ/yL9aSQO85bCUha E=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85458562 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:q86T663DieaoKe5iTfbD5SRxkn2cJEfYwER7XKvMYLTBsI5bp2ADz DZOUGnUM/ffazOnf4x/bYvg8E4CsJSGz4Q1QVE6pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVnOqgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfDXsX0 eMeDRE0RFOyt8an0ay3S9djv5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKkSbC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TaGJkIzhvG/ Aoq+UzIXQNHBe2YzQaB0SiIqsTMuX6iZqgNQejQGvlC3wTImz175ActfWW8pf61m0uvQeV1I kYf+jcthaUq/UntRd74NzW6vXqFsxg0S9dWVeog52ml6qfS+RffOWECQRZIctlgv8gzLRQg2 0WVhdrvCXpquaeMVHOG3r6OqHW5Pi19BU0oaDIATAAFy8L+u4x1hRXKJv5zHajwgtDrFDXYx zGRsDN4l7gVldQM1aiw4RbAmT3EjoPSUgc/6wHTX2SkxgB0foioY8qv81ezxelEBJaUSB+Gp ndspiSFxLlQV9fXznXLGbhTWuHyjxqYDNHCqVJ1Rr0+8RGMwlTgTLB08SBgKEZXPf9RLFcFf 3TvkQ9W4ZZSOl6jYql2f5+9BqwW8ETwKTj2fquKN4QTO/CdYCfCpXgzPhDIgwgBhWB2yckC1 YGnndFA5JrwIYBu13KISugUytfHLQhulDqIFfgXI/lKuIdyhUJ5q59fbjNijchjtstoRTk5F P4BX/ZmMz0FDIXDjtD/qOb+7TkidBDX/6zepc1NbfKkKQF7AmwnAPK56ep/Jdw7xf8Jyb2Wo SvVtqpkJLzX3iSvxeKiMy4LVV8Sdcwn8SJT0dIEYD5EJETPka7wtfxCJvPbjJEs9fB5zO4cc hX2U5zoPxmOIxyZkwkggW7V9t0+Kkv22FnWZUJIolEXJvZdeuAAwfe8FiOHycXEJnPfWRcWy 1F46j7mfA== IronPort-HdrOrdr: A9a23:eFIadqHGF+qYrM3GpLqE6seALOsnbusQ8zAXP0AYc31om+ij5q eTdZUgpHvJYVkqNE3I9eruBEDEewK7yXcX2/h1AV7BZniEhILAFugLhuGO/9SjIVydygc079 YYT0EUMr3N5DZB4/rH3A== X-IronPort-AV: E=Sophos;i="5.96,171,1665460800"; d="scan'208";a="85458562" Date: Thu, 17 Nov 2022 14:20:37 +0000 From: Anthony PERARD To: Andrew Cooper CC: Xen-devel , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang Subject: Re: [PATCH 2/4] tools/tests: Unit test for paging mempool size Message-ID: References: <20221117010804.9384-1-andrew.cooper3@citrix.com> <20221117010804.9384-3-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221117010804.9384-3-andrew.cooper3@citrix.com> On Thu, Nov 17, 2022 at 01:08:02AM +0000, Andrew Cooper wrote: > Exercise some basic functionality of the new > xc_{get,set}_paging_mempool_size() hypercalls. > > This passes on x86, but fails currently on ARM. ARM will be fixed up in > future patches. > > This is part of XSA-409 / CVE-2022-33747. > > Signed-off-by: Andrew Cooper > Release-acked-by: Henry Wang Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 17 14:32:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 14:32:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445257.700356 (Exim 4.92) (envelope-from ) id 1ovfw4-00051z-CP; Thu, 17 Nov 2022 14:32:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445257.700356; Thu, 17 Nov 2022 14:32:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovfw4-00051s-9W; Thu, 17 Nov 2022 14:32:12 +0000 Received: by outflank-mailman (input) for mailman id 445257; Thu, 17 Nov 2022 14:32:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovfw3-00051m-7o for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 14:32:11 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9cd53776-6684-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 15:32:08 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 50CE532010D8; Thu, 17 Nov 2022 09:32:05 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 17 Nov 2022 09:32:05 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Nov 2022 09:32:03 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cd53776-6684-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668695524; x= 1668781924; bh=VDHNMVouOnbd2BIm6kQ/z4TnyWsucBlyWGHOxBu8DFc=; b=E xXLDel3Fni8lmKAgawxSh3Z/oU3G+BKkylnFPFTNvljw2oJj5RzS1q8bnkZsyGBI QJaAfOorKyEC8U7vaBpmiZtXTF2Q0sC1Ngb9HSZObf7SkqYxiclVjQnFjQqOx0fp DWxCiOjd/3grLfgNnJDJ2H2ZQwWaicyUT/ZGv0Q5IhNijwhqoSqifVMHU9LTSCku 1qGRPP0r1vGy102p/gelD15r232vUMXF/zBsARjAWpGp/aTkBDncBIheWZ+fNgZv dQzgAAMJt4mq54SR/fvqAvwpy8aUMC5rCYVTBg3Ps7Gn4uKOraU01pLOH5hbVOXs smx6OxgeaxDU71cFLFhDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668695524; x=1668781924; bh=VDHNMVouOnbd2BIm6kQ/z4TnyWsu cBlyWGHOxBu8DFc=; b=lyK9mBhvya9ZvHyklUFqMDr5JZTcBk3uqUDidtaFZDnZ hqzLy5dnc9xJUQrmsni0UNCUo5k5E6jr6DTtq0nSD98qlP+r3LCiHD23uIoykxbo jD/0Dp4/jj5Zfs7aL+xfpuMwHPFf7CEuFOTgxzCv1pNPyvbqUGcctrI4NNZrjcqs hiA0WQ2rt0oQbXXkhoXj7rvuKs56gLLLYA+VG/LL6NIDQ4QL2b09pirYcrTYQ0lg EbDAJ/LnRQoC6gp3mz961h5+XWOhn54bDSJLtVjko0DNBVRi1OykYmRyCf/HIWEj POxo1vlvnmIrKie2ZeL+c8vLglcduSppGxcKCKkp7Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgeekgdeigecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 17 Nov 2022 15:32:00 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , "moderated list:XEN HYPERVISOR INTERFACE" , David Vrabel Subject: Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared Message-ID: References: <20221117114122.1588338-1-marmarek@invisiblethingslab.com> <0afe3f35-1b25-d1c6-89bb-8dae7a4070e9@cantab.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hsWQDkJqLvEsIMcB" Content-Disposition: inline In-Reply-To: --hsWQDkJqLvEsIMcB Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 17 Nov 2022 15:32:00 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , "moderated list:XEN HYPERVISOR INTERFACE" , David Vrabel Subject: Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared On Thu, Nov 17, 2022 at 02:33:16PM +0100, Jan Beulich wrote: > On 17.11.2022 14:13, Marek Marczykowski-G=C3=B3recki wrote: > > On Thu, Nov 17, 2022 at 12:54:51PM +0000, David Vrabel wrote: > >> On 17/11/2022 11:41, Marek Marczykowski-G=C3=B3recki wrote: > >>> Linux enables MSI-X before disabling INTx, but keeps MSI-X masked unt= il > >>> the table is filled. Then it disables INTx just before clearing MASKA= LL > >>> bit. Currently this approach is rejected by xen-pciback. > >>> Allow setting PCI_MSIX_FLAGS_ENABLE while INTx is still enabled as lo= ng > >>> as PCI_MSIX_FLAGS_MASKALL is set too. > >> > >> The use of MSI-X interrupts is conditional on only the MSI-X Enable bi= t. > >> Setting MSI-X Enable effectively overrides the Interrupt Disable bit i= n the > >> Command register. > >=20 > > That means the second chunk of the patch may even drop the '(new_value & > > PCI_MSIX_FLAGS_MASKALL)' part, right?=20 > >=20 > >> PCIe 6.0.1 section 7.7.2.2. "MSI-X Enable ... is prohibited from using= INTx > >> interrupts (if implemented)." And there is similar wording for MSI Ena= ble. > >=20 > > And this would mean the 'field_config->int_type =3D=3D INTERRUPT_TYPE_M= SIX' > > part isn't necessary either. > >=20 > > Jan in another thread pointed out that disabling INTx explicitly is > > still a useful workaround for a flawed hardware. But if that isn't > > mandated by the spec, maybe it doesn't need to be enforced by pciback > > either? >=20 > Well, allowing a device to go into a mode exhibiting undefined behavior > is what we ought to prevent when it comes to a DomU doing so vs overall > host safety. If the spec prohibits using INTx if MSI/MSI-X is enabled (regardless of PCI_COMMAND_INTX_DISABLE bit), then well-behaving device should be fine (we aren't hitting undefined behavior). As for buggy device, it wouldn't be much different from a device ignoring PCI_COMMAND_INTX_DISABLE completely, no (besides the latter being probably much less probable bug)? If the above is assumption is correct, it seems such device may not function correctly without extra workarounds (which are in the driver interest to apply), but should not affect overall host safety (as in: beyond the guest having that device assigned). I think pciback should only enforce what's necessary to prevent one guest hurting others (or the hypervisor), but it doesn't need to prevent guest hurting itself. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --hsWQDkJqLvEsIMcB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN2ReEACgkQ24/THMrX 1yzzUQf/fRtFToxRDSo67Ei2SnzYd3QNLi4bA/SAL/6aFptPOlDlc9x5/3vcxPdP 9XXxKSV8XCpz1Ujxbq8jc2F04SBoQOblw8gOvxXzxLx8OF7r0wslheBBKCnd9p4L K75QUIBMp7FPdG5zZNlE0uEeDZXfZQEQWUe3ZkI3DwQEA0pNge2TQcFboJYCgo7u jFKA2HUoGKdIHXyOrq32dQA3MIQHGbKuOlh7amutgfjSGVHhf7mKWlicmrac1Xvg J51tmZU6hTUm/XXN9/NHqVCcPpC+umlxfAWi6wDcsUrS4upTT36fh3XWD3PO6twk XYA18LE0FTW2NIsUbImeFTak0mp2tw== =ahAp -----END PGP SIGNATURE----- --hsWQDkJqLvEsIMcB-- From xen-devel-bounces@lists.xenproject.org Thu Nov 17 15:11:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 15:11:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445263.700366 (Exim 4.92) (envelope-from ) id 1ovgXX-0001Sn-7g; Thu, 17 Nov 2022 15:10:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445263.700366; Thu, 17 Nov 2022 15:10:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovgXX-0001Sg-52; Thu, 17 Nov 2022 15:10:55 +0000 Received: by outflank-mailman (input) for mailman id 445263; Thu, 17 Nov 2022 15:10:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovgXV-0001SW-BE; Thu, 17 Nov 2022 15:10:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovgXV-0005UR-8k; Thu, 17 Nov 2022 15:10:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovgXU-0007a1-PB; Thu, 17 Nov 2022 15:10:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovgXU-0005Q1-Oi; Thu, 17 Nov 2022 15:10:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HrXye7nGasJmJEyh14uwFiKbv3+XU2CLTAeRb+dvOmo=; b=bVy3rUobjH9JEq+xv9TpVb4S85 BXdSt9LAp2++DETwUGzONd40vKUIfI5DT74Zf096Q7k/fY1pJ+gKQsDfxT52Iqkynj5sEVIxDbzCL 3d0GgSQU5tK2mp9gPtQVa/l5ttYGAAS8C+6d+VZm5Hrokb3cOODFGw2c+TSs3Hw//h2Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174799: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=cc675d22e422442f6d230654a55a5fc5682ea018 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 17 Nov 2022 15:10:52 +0000 flight 174799 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174799/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux cc675d22e422442f6d230654a55a5fc5682ea018 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 40 days Failing since 173470 2022-10-08 06:21:34 Z 40 days 68 attempts Testing same since 174794 2022-11-16 21:11:27 Z 0 days 2 attempts ------------------------------------------------------------ 1714 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 163145 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Nov 17 15:38:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 15:38:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445271.700377 (Exim 4.92) (envelope-from ) id 1ovgyR-0004JD-K9; Thu, 17 Nov 2022 15:38:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445271.700377; Thu, 17 Nov 2022 15:38:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovgyR-0004J6-HD; Thu, 17 Nov 2022 15:38:43 +0000 Received: by outflank-mailman (input) for mailman id 445271; Thu, 17 Nov 2022 15:38:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovgyP-0004J0-Nt for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 15:38:41 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70082.outbound.protection.outlook.com [40.107.7.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e8ee8482-668d-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 16:38:40 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8159.eurprd04.prod.outlook.com (2603:10a6:102:1c1::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 15:38:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 15:38:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8ee8482-668d-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j7nb6k9ojcELdvct2t0v4iswcJqYNJuoDqs3kvSvfX6yRDNqql8SKhw/Df0NOcfVsH4KzYvCSl4QAFKXs2oUecOa2mqL0/O17PFjOqj6wzw5fnxQHG7vD7vnEJDiJd4yh0rZmzZ2BWjZhy8RftByTMhBUp69Ln4Evfj1buiSyvnxBjPjFcoa2ZkZvjr8Ek9yK4msmGyFkFRnxowpb6TUSQDWA9zwBVnpVs8maAKV5Kx2lLmitz4Y1RwXYChY4YrueQUMzacdmGnUYkRtDf1vwrFdhfM5aZi+zE//dWUgwNMNI0aCZax66VUkcqO1NvTBchIa0htSmQlNoWdSfYFhcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nf2ZhOc393Vbq7veFfSkuaozHPcfKNKg6DK+3VET304=; b=fBGaEXdEDMngqMaiVhopIPPgQvkdf7FDdkfQW03bJ9FZgROBfDyu+rYlvWxfQEpRukiHWw+3C80p2nRONG2l7nOWLdE8W6xtCSj2o5j2zOGMhqNZQOoCnXlAEd/ANftucABFlSq0XMYd0n4/vuIOb/+JGuJDY9v6Z9XoGgt55jLOKhUsOGSIQ9Ez1ljKuATYnJMfrlHfcyvMPAaxytiVA6bquD34bazxEB2vSSRE5u5Es76odRIvT7z5D/WbfOGX6qbXG6tffRwNTRxqGCfhwnUl3+t5ZxZak2nTysnQgv71fuUenTOBrmvvYwQ//TDdfzZjjxFBTi3KSVtyi+ineQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nf2ZhOc393Vbq7veFfSkuaozHPcfKNKg6DK+3VET304=; b=5PyzYfQSzI7pTX7gHD1+ktkeua6hoXL1XNuLG+brE0e7fPONqi1jYl9YJsPr9+d9MVEBao7Fzfak7dRQba+h7DvdK75qwCwIs5OA5vabCdDacsruCny43s8KeZJuGKwEOECxAcmayPm9OqtQWEsu3Jc8gumvAIlCY2gzohM0kHquEGW5Z0cIq7OSVtJPjfTuAk+YK54q1z9J/Adkn+Y5mzoJRlnrhx92Z/IUezR/x4Pf0nRB5lLXNeUoCM3EwF+hJzEc2YUGvuDXNnm/5K0LMbkaN0zGm62NNAtlgSpy0lAohuuRsbqbJA/nVTrCeym0x/DN3IoUd/BltFGM8nfkpg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4e961ee5-2b4e-721a-9406-9dde7ba5e672@suse.com> Date: Thu, 17 Nov 2022 16:38:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v8 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20221114063451.473711-1-wei.chen@arm.com> <20221114063451.473711-6-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20221114063451.473711-6-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0144.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8159:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f8d2391-9305-403f-8439-08dac8b1ba9c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /I51+8kCdYWkZ8gSsOLKbo9qCCvehca+9HHVObkoVU+vcEENO0bxZ2G2ZBwbKDueieKWsK2RT5vZuhokT6qaYk2May59h+Y+l0jsCnzrWM+Prqt0JwsgxP9g/YEbeqRkgfeex0RjbyvSVM+fFi+JLKYIgKjA8dvWDs90x5ubCy/DWUch0yyBxwxAOnKfO5xb6utRJ3I/4Ea/z9s8UDDgp8C4Y4zywOINEvhUrkR8zmZXLKxM+xWMo14QAiQa9DJZEUHy1BralhRNkMTq7jcI2beIgExY/qpniV06wDgOreD2BL2ZmVz388OM4IZ7i7sjvAm0blEjmdGEww32btDpXMxrmvQ0n4hWsmgPTO7NhSekoeKzWxBwkfnTjsQVbhY3/mb8pMTeaihWYFyXRjfGV2c6+uzBIY2M5QVgo/O9NMDkCv/DnbVXc3mkY+kpsbglDnbtrKz3Q3BaYYAzcCODMtY9c77u5uqgQ4AfJtpk+RtBSDsLxve1jx70Yi19UhqQvC4i/CFmhY3DwsSyBmsXenyD6Dh6YHzkBvWdxYfK2CudIfUSFz868JW1RGDN4M4/agYeDC7mxaOZurdq81w9J5rc3RWWOP5HvYSddFyPAa30bwrKpS372ctZerf+bKCxDZ7WYBSj2gGtPeCXhwnIbAk9RJ1Zo1v+Bxwx6U8z7sHebMZzkDyPsHMMapHpRcwI+A8mxYz48PU2k/OXlBq8Vi61wOYjAwoU5NxTQzWu7qA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(136003)(366004)(39860400002)(376002)(451199015)(478600001)(31686004)(6486002)(6666004)(41300700001)(8936002)(2616005)(66946007)(4326008)(66476007)(36756003)(66556008)(8676002)(26005)(6512007)(54906003)(5660300002)(186003)(6916009)(6506007)(316002)(53546011)(83380400001)(2906002)(31696002)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFI3NEVseVd4V2lxVjg3ZWk3NUtCVkE1QU9HVGhRaEkwZFVtUytrRHFIQURS?= =?utf-8?B?QXNJaFZ6RERaazFOMGprVDdoY05va2NxeUNRWTRMbWNjTjVYc3ZObmt3MDdV?= =?utf-8?B?aGZneDBHN29OeTIwVGE0dm9NbWVYRm8xU2E4NnhtU1BPV3RUV3d6VVdrbHhi?= =?utf-8?B?aHo1b3h4MnhoTGVlMlZkU1BGU1ZOM3R4V0F3L3IrR1Jhdm5hMVVJR0haeFJx?= =?utf-8?B?czhlT0VORWV2ZGNaaWF0bDVzMzh4dU1zNEo1b0c5VEROOXlveHRTb3hQb0Zi?= =?utf-8?B?WXAzU01vUWNLK1Q0bEZxR2dMVHdCMG5TUXFsa3BUTDdhaXVBQlJDRFFQY3Fp?= =?utf-8?B?QVVsYWV4SG0yUE1CRlM1UHU4elR6ejVxRS9VRFBSRnU4R1N1cE9WZnlveEVE?= =?utf-8?B?NG40T2pOQjFJaERnblpzOHdBdTNHSTFtTW03ZGRSV2U1cG82UTM4eHhSUXVY?= =?utf-8?B?UkwxajlqU0xES05PaGFxcG1YdjJaalJxVHNqYzI2aU93MXJmYTBZamlSc3Mr?= =?utf-8?B?K3R1Zm1YcVpHYWtMTDFoWE8rK2h1SFd0N29CRjI2OGZTczBvV2ZBdzZ2MEV0?= =?utf-8?B?ajluNnZLNlczdVNkTE45RWgyUTJ4ZGpNaGZMcmluQldoYkRKNXpOaWc1SUdI?= =?utf-8?B?amg2dnVWYTQ1MTE2TmJhaEhvbFRIa1BrYlEzVktUZ2s1aWdYWDdMSnBhejJv?= =?utf-8?B?cFRyY3dEb1JlaW1vLzJwbkdPb3V3MVVUckptRmh0QWk2WFRtK1dLNFRnQVps?= =?utf-8?B?UmFKMFVucnpzNTd0S0VLV2doYU1qZXdZRVUzbEhnN3dERW56LzFxRk9tVEl5?= =?utf-8?B?MWlZUk9vbTBETGZWVExYYm90U24yQ0tpSzV5UkhGdlA2dVZ2dlpWbUFQVlFw?= =?utf-8?B?ZjJUV25GMEN0M25BMjVXL25qcGxvOWM1TjFRR0ltN2ZmOWJOc1ZsTkhPajZ0?= =?utf-8?B?UzFkRk1ac2xwYTA3QWtMN2cvbUFMVC9sWm5Gd3NCZ3RUTVZIc2VFMGQzM2cr?= =?utf-8?B?N2src2tpRDdiR2dXMnJjT1pXREFlSCtFOW5uNWdvWWVSREhkMG5vOW9MZ2tm?= =?utf-8?B?ZWU1UFRoQ2xTWVF1OHk5N3d1NEw2TWRINngxb3dGUmwxV3FnamlSWENHR3RH?= =?utf-8?B?YXNzYitSdzBYUFJoQ1NnOGJydnJ0ME1nMG5TZldid1cybDU1NE5la0J4MzFt?= =?utf-8?B?cnk5YmpWYVlzTHNyMkVLS3FYVzNRN1o5OGI3Y0JaNXNZL1hsQTRGU3Jqc1ZJ?= =?utf-8?B?Vm12Y3g1a3dqSTlDRWlUNDNZY2FHQThETjNQTmh2b2hDbm1Gd0xWV0pjTWc1?= =?utf-8?B?OFRQWWc2TEhocDNUaWpyWVdEVTVVYUNVai84b0kwYTc0ajZmbHAxQXB6Kzh6?= =?utf-8?B?L3BLSmdXYWRYd1YwakozV21uV1NtMUl6aldxWTV2Y1piRVd1cVRmcnJoZm0y?= =?utf-8?B?S2lwQVVGSXA0bWIybkdkZElhQXk1cEVOdmkyUE5LeVFkNC9CckZZT0hrTnZT?= =?utf-8?B?SmZpTnlWTUdBSnBBZzEvQnFGR0FxOWF5bE94RGsyVk5pVGM1S01YVTNjaUNj?= =?utf-8?B?L0plMU4xYk9pSmJaVXNTTnVVOEhSemM5cndZcGhZaXUvR0RXZ2p3QzNHYTFG?= =?utf-8?B?VlBJR0xWa0xKNHk4REdJcDlBTWRqZEYrWlpMR0ZJSldvbkdRcHNJOFVSaDc0?= =?utf-8?B?WFBQaXJIVnVXck1YaWJLN1lvb2xTUEdaVTlOeVlURXNkYXFIZmVCR2VlZzRJ?= =?utf-8?B?Z2gxVDF0MUtpVnJHeFNxcmZnQjhLd2xDSXIvOFRiRjVRNXROam9BMGdoKzZV?= =?utf-8?B?VnZJWE8vVU5MdXV3NUkzMW1Yc1RaMzlvZ3hzV3VPNXd2ZEpOaHp1UVArK2Zu?= =?utf-8?B?L3QwekF3V3ZITlFhT1JPZUJFeGpzL0V0bjhsNWtOeDNHbGlhblZQeUtuUnpD?= =?utf-8?B?cHFKdndoVlhjZUEwTnRzTjAyU04zY29TRkxpQjR0ZklkSUUzZjZycFlDbjMz?= =?utf-8?B?eGxocUU1NTRrUTljamxNcWkrRS9iTnRqejJZTjV1eDdia2w2Z2JVQnhKRU1F?= =?utf-8?B?eFpmb2s5RXg2dlN2dFpXT1d0NTl0TFI4WGZaSmZMejViN05haThubG5jd2ZD?= =?utf-8?Q?w1VckmYwBCGhvO2H8ilkyEUl+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f8d2391-9305-403f-8439-08dac8b1ba9c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 15:38:10.8181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: onZqJeqtA6KrdvRK6/LFGkMFrQmFTN/Mgw608z3ZuvR+15fIGN8/+E09V2AB8McrAd5HR4cfSa/SORZk4OLDyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8159 On 14.11.2022 07:34, Wei Chen wrote: > x86 has implemented a set of codes to process NUMA nodes. These > codes will parse NUMA memory and processor information from > ACPI SRAT table. But except some ACPI specific codes, most > of the process code like memory blocks validation, node memory > range updates and some sanity check can be reused by other > NUMA implementation. > > So in this patch, we move some variables and related functions > for NUMA memory and processor to common as library. At the > same time, numa_set_processor_nodes_parsed has been introduced > for ACPI specific code to update processor parsing results. > With this helper, we can reuse most of NUMA memory affinity init > code from ACPI. As bad_srat and node_to_pxm functions have been > used in common code to do architectural fallback and node to > architectural node info translation. But it doesn't make sense > to reuse the functions names in common code, we have rename them > to neutral names as well. > > PXM is an ACPI specific item, we can't use it in common code > directly. As an alternative, we extend the parameters of > numa_update_node_memblks. The caller can pass the PXM as print > messages' prefix or as architectural node id. The use of "prefix" here must have been stale for a while, perhaps resulting from an incomplete re-write of what was here earlier on? > -static int __init nodes_cover_memory(void) > -{ > - unsigned int i; > - > - for (i = 0; ; i++) { > - int err; > - unsigned int j; > - bool found; > - paddr_t start, end; > - > - /* Try to loop memory map from index 0 to end to get RAM ranges. */ > - err = arch_get_ram_range(i, &start, &end); > - > - /* Reached the end of the memory map? */ > - if (err == -ENOENT) > - break; > - > - /* Skip non-RAM entries. */ > - if (err) > - continue; > - > - do { > - found = false; > - for_each_node_mask(j, memory_nodes_parsed) > - if (start < nodes[j].end > - && end > nodes[j].start) { > - if (start >= nodes[j].start) { > - start = nodes[j].end; > - found = true; > - } > - if (end <= nodes[j].end) { > - end = nodes[j].start; > - found = true; > - } > - } > - } while (found && start < end); > - > - if (start < end) { > - printk(KERN_ERR "NUMA: No NODE for RAM range: " > - "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); > - return 0; > - } > - } > - return 1; > + numa_fw_nid_name = "PXM"; I guess this can't go without a comment, now that we have ... > + if (!numa_update_node_memblks(node, pxm, ma->base_address, ma->length, > + ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) > + numa_fw_bad(); > } > > void __init acpi_numa_arch_fixup(void) {} > @@ -534,6 +295,7 @@ void __init srat_parse_regions(paddr_t addr) > acpi_table_parse(ACPI_SIG_SRAT, acpi_parse_srat)) > return; > > + numa_fw_nid_name = "PXM"; ... this as well. Otherwise someone may spot the redundancy and either propose to drop one, or it'll take them quite a bit of time to figure why both are there. I thought this would go without saying, so I'm sorry for not making this explicit earlier on. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 17 15:52:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 15:52:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445276.700388 (Exim 4.92) (envelope-from ) id 1ovhBN-0006uq-PI; Thu, 17 Nov 2022 15:52:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445276.700388; Thu, 17 Nov 2022 15:52:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovhBN-0006uj-MZ; Thu, 17 Nov 2022 15:52:05 +0000 Received: by outflank-mailman (input) for mailman id 445276; Thu, 17 Nov 2022 15:52:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovhBM-0006ud-Hd for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 15:52:04 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c6376c15-668f-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 16:52:02 +0100 (CET) Received: from mail-dm6nam11lp2168.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 Nov 2022 10:51:59 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB4942.namprd03.prod.outlook.com (2603:10b6:208:1ad::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Thu, 17 Nov 2022 15:51:57 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%5]) with mapi id 15.20.5813.020; Thu, 17 Nov 2022 15:51:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6376c15-668f-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668700322; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Qt3K/tjGsrID4OSRWP2dbdWOP4OJdeeWOzH3yLoSS00=; b=gkjT0pVulQZF3lBj/U967HDeMRR6dmxteIWp5avoTqZqWcPF+65ngVqS ygvp6yeAtOEyN0cx5HZWXE8MKaLi9emMtTILJ/5pCuZiibMAsTqQ+e2lK +KHJoNxnV2hAgFBJmdyP7Y56PT7N3uGJqqndxIgEx9XlL+Fge0sSUuEc9 s=; X-IronPort-RemoteIP: 104.47.57.168 X-IronPort-MID: 85468200 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5AISw6B/xfhmvxVW/7Xiw5YqxClBgxIJ4kV8jS/XYbTApDN33mQCy WMWXmrUOvqCa2P3f9BzbdmzpBxT75/WmINnQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpB4QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw3PhlO1kN9 tYhDCkJRTaxluW6/I6wRbw57igjBJGD0II3nFhFlGicIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+uxuvTi7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr+SwX2rAtpKfFG+3tlnnnyVwkETMxZIVQPmub6Yh3ejCs0Kf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHr7m9WX+bsLCOoluaIjMJJGUPYSsFSwot4NT5pow3yBXVQb5LErOxj9DzMSH9x XaNtidWr4sUickHxqCq52ftijinpoXKZgMt7wCRVWWghitzaZS5fYWu5R7e5OxZMYeCZlCbu T4PnM32xMADC4uc0hOERuolFausof2CNVXhbUVHGpAg83Gh/iCldIUJuTVmfh43YoADZCPjZ 1LVtUVJ/phPMXC2bKhxJYWsF8AtyqumHtPgPhzJUudzjlFKXFfv1ElTiYS4hQgBTGBEfXkDB Kqm IronPort-HdrOrdr: A9a23:t01IF6qIObXlVvfHh1HGMjkaV5sDLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcItKLzOWwldAS7sSobcKogeQUREWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZa6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyR+49bLgFBCc/xEGFxdC260r/2 TpmxHwovzLiYD79jbsk0voq7hGktrozdVOQOSKl8guMz3pziq4eYh7XLWGnTYt5MWi8kwjnt Xgqwope+5z93TSVGeopgaF4Xiv7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twriGknqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYdU99WPBmcUa+d tVfYbhDcVtABWnhrfizzBSKemXLzAO99G9MxA/U4KuomNrdTtCvjYlLYQk7ws9HdQGOtl5Dq 3/Q9pVfPsldL5oUYttQOgGWse5EWrLXFbFN3+TO03uEOUdN2vKsIOf2sR92AiGQu1+8HIJou W2bHpI8WopP07+A8yH25NGthjLXWWmRDzojsVT/YJwtLHwTKfidXTrciFkr+Kw5/EERsHLUf e6P5xbR/flMGv1AI5MmwnzQYNbJ3USWNAc/tw7R1WNqMTWLZCCjJ2STN/DYL72VTo0UGL2BX UOGDD1OcVb90iuHmT1hRDAMkmdDnAXPagAZZQy09Jju7TlbLc8wzT9oW7Jlv2jOHlFrrE8el d4Lffujr67zFPGj1r10w== X-IronPort-AV: E=Sophos;i="5.96,171,1665460800"; d="scan'208";a="85468200" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iPEQI7Hc5FEg0+GsKiLb/vO83z7pILkxuV1yoBA6YzhVzAQPXYXTP5MdqgDfbhtF4xwt8GY0HMFID1JbpLUeDlcfZl1bp+RStWHDW9AgaF+pcqFbS3GwIF9dHQM7UsYdEztjwhTVCtNaA3Mq8oDfImpGrXjt4EfNAaZpxjbvNzjS6oQJeEMq0gM5MPyZShUp943EmN2YkslxjvKQP1u4/tueNaqYAG888N+L0G6YYAJ0nlvYX8s+2BduX4tQ9BgvM0VTSOiBBiaD5JUgWYCg2S6FfSwjzIA0OITg6qvIKaa33TBcKgQV8PbkVE+ozMb2otRCUcFfIpDGK0doUDFz6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qt3K/tjGsrID4OSRWP2dbdWOP4OJdeeWOzH3yLoSS00=; b=AksSWj7f2tPSvvA9mYPTHqfykbCvv+MyhGxr/8HDXboInwSGLJKUoNFTzAEJOdbWuKTndIRhtMa9zSKu3dH9cnkY/j/ToNOBKWyud+RSL25ANpX6q/o9eWewz/MYf7vBPjECFxwicG6cPRg9gVqEjB/ztPlue1daFA/37V4278z03+Jiey56FEc9CZ4XTiFxoruuJsY8x8lCyd9SjXybAPV3i7dgV0BDIYt+g1xmK44r0RT/qgMUV8ebTH6UAlJkKHzwmU7vYwRu4CRhW6c6KXFieVgcm6fRwsDELimBzUZD7BCX9oIzvHWBRI/36ySVej0JPS865GHQNfbSFxlTrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qt3K/tjGsrID4OSRWP2dbdWOP4OJdeeWOzH3yLoSS00=; b=sBzAoCn3nUnAWtR9juoAko5+yTb1Prg2ssGND+5iDCE6TvFmpy1aOiosdSG92hHrvbPbdbU/JZC/0eVT9U2yDc4yebWP7DHlOcDCfQxqQPNzuKRC0hFsyoxaWP1ullzBw2RIooifwuluZlvqc2F7FN+mepZdUZJapkkvO6v4DiE= From: Andrew Cooper To: Jan Beulich , Xen-devel CC: Roger Pau Monne , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony Perard Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the paging mempool size Thread-Topic: [PATCH 1/4] xen: Introduce non-broken hypercalls for the paging mempool size Thread-Index: AQHY+iEUvJBYB0FmNEu7gTGG+j5kxa5C56gAgABdHwA= Date: Thu, 17 Nov 2022 15:51:56 +0000 Message-ID: <8ca3efae-6ee2-a13a-5a1e-4810cf48ff66@citrix.com> References: <20221117010804.9384-1-andrew.cooper3@citrix.com> <20221117010804.9384-2-andrew.cooper3@citrix.com> <50b643b9-0347-4587-0c32-7af018485911@suse.com> In-Reply-To: <50b643b9-0347-4587-0c32-7af018485911@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB4942:EE_ x-ms-office365-filtering-correlation-id: 43f6a1c1-cf81-4c7c-1a93-08dac8b3a80a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fPqlmf2nbg/BOxE0aC1rRp+1xpBx9VSM73lWhf5lPt0o8gOvK+3jO9DQpW7cmAz2DCYjTtjAunxyXwNY5rNu/tq3U1Sz3jfwHa4D7bG8KCqpKVF+cd/i913fgR+szCZWFgjL2ECL1v+j7e8AjdtMnEy6StQ8XXYSwLzQ5ghkbNkw82tLuJMcCNUeQ0zCMair5JXGab4/AYiJRGwXDbpg0oVsJVt3VJxjAdpp93yqRMP87Lur/BhAkLoAlS9gK7h1KXS+r++93DofqOCqOq385eC4hj3Dtg+n0cU8mHnRBaxiDtp8n+UzrWM8o++XeWQl+IgvyM8GdXOxWqnQUyMslpsqCBPxNVwT0CfU3pblMbGzTn994tk1WyNJuEhDrti1Lw0cvIF6lF+GPjgCNnmI3NN2oIn/5qll/+K2LFIn2umTgKaHJCtXleURLKQUuf/FxClWVzeIwUrQ6H5cUZegRNyqbgNY1n4loILtH9XBOEKpz8H6sTgcPUbDYwaCRWlJXp7PwQZDi03058Jviy8maSRBpPl3iBXS9rTDnfLkfRqQE8goLolJwTfeV8UYZRrBBU2olZ7ywruBSM68l482fap5xpIxQTFrnG0xCtZeGbtY2g5rDx6OfB8740S6szE2oSUmKWrhsa5DHboH/fq+FI8DMzl8wX7HBLuNgADhdSihUvP5bl+7518Nhcm+UfDH/svr6RLygYzyd8EqlP/1M/4Y7ZF9sKBT1048NVVxlkfdMLmXyTr8SQAeoSrGrhwUjxt/cxgTJSSgHI2gZr+cIQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(39860400002)(366004)(451199015)(31686004)(8676002)(41300700001)(91956017)(8936002)(5660300002)(64756008)(4326008)(66946007)(76116006)(66556008)(66476007)(66446008)(54906003)(316002)(71200400001)(110136005)(38070700005)(6486002)(122000001)(478600001)(107886003)(26005)(36756003)(6512007)(6506007)(86362001)(31696002)(2906002)(2616005)(38100700002)(186003)(82960400001)(53546011)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZWFseW9US0tOUU8valpCMXpQdWFwbjBYRkkvVVZjQlVaZ3RLZnc0dkRyNkY0?= =?utf-8?B?RFdXZkFlbXZLNTFUTk1ucTVCcEc3VEtnUng0OXVhNTF1STZDVjVvN3Bsbk1j?= =?utf-8?B?eS9KR1FvRzh4YzdweFAzV1B3WXR1ZHRDcjNCbGhZMUN0dW5MNjdQNHJuOWZx?= =?utf-8?B?TTRFckdlQWpTNEloV0M1Y0lpazJlalBnM2FhdERNNEhhUlJQbU1BUFNpcnc0?= =?utf-8?B?c2VQQXFXZmgyc2tsRmh2UHpMS0lsdFBHeFN6NXE4a0dSWUc4a29CeDJOSlNL?= =?utf-8?B?QXkrOWU2dlUvbEJZdHBQWjBiZzlqL1E1RzVOS2dLdDF3VE96NElPOU0vbzIx?= =?utf-8?B?cG1VWFZzYnZnRnVQOFZTelZESG9VcmtLZzJKZ2ZRN3RkUGxBam9hT1dUYlhN?= =?utf-8?B?RE5OUHFpRm92ejNHMU9hOHZHOEdtRHlQOEtPUUF4elk3S2RadlZXaXBmNFNz?= =?utf-8?B?SkZlOGh6NlY3T1ZSeXpZcSs5Y0dyWGRDRi90S1dDekEyWGU4ZHhwN2N5clVv?= =?utf-8?B?MWhVaGZaRHZEcFA4cC90b09FYzBjWVN6aUZwRDVyMjlWNTdtcW96SmREZFBt?= =?utf-8?B?VGdRMGdPOGFQSEI5YTU2UE5EZFZSc0YyU01TY0tqdWNha0NaSXFFZDlLWDRx?= =?utf-8?B?UlhmcXhVY2g3M2dYU2JSVXFCSlFTdTlseHk1RTNyRDA1OCtQeURKWTFoUU1S?= =?utf-8?B?SzlWVWtJSkJXcERIdnk0UmJ4eFJEbmdta0JSeHAwKzhGZjlwZDBuRnoydElL?= =?utf-8?B?ZVh0NzR2ZjRYcENJSTJneHVzNDJoRUpLTk1WTWhMbkMva3FnYUFzSHpwMmZr?= =?utf-8?B?RkZQMlBIaHpCd2Y5N0tuWVR1K2Jpb3lta1FldXN4NjNRN2l5Z1V6NjdjY2I0?= =?utf-8?B?U3RKU0I4M0M1bEMvTGVHb3Y5WTNhQ21TdUFkdXZUUFFuS1VFa0hiL2h2MEVG?= =?utf-8?B?TTltZXdwT2loNnZwcHpNVCtmcVI3ZERGZWJJSTkvWEVhaGNmcjZ2TTc4QnFL?= =?utf-8?B?Wk1ERGY4VEY3Y1lMTlM1SVNRQm9Dc0xUWmlpNW12L1ZDbFBCMEw1eWlnK2xM?= =?utf-8?B?cUhzSTMvT0hJQ0ZEc0NPVDJPR2FYKzJqbzBYREQ2aUcvRWZXQlhlZS91Y2FZ?= =?utf-8?B?UTRpS2dOekthb0xSL3RFTk0ram14R1UrZ0dmY3JOSDYwRDAzY0Mxek8yMnlZ?= =?utf-8?B?WUNONGpzZ29JazNZcHNDU2lNSHlONVpyUVBwQTBtOEFXUVowUG1RN3lMdWhF?= =?utf-8?B?ZjJlSE5NMUFPY011T0tseXA3Vit3QXorT3NXUUd0N1JmK0tYc3Q4aFhtM3Nz?= =?utf-8?B?S1ZTeE1adTZIMzRBblI5NHp3bUFTVEJadVBXWEY3dlY3SnZGV0U5Qlg5UnhY?= =?utf-8?B?OEFTSEVBS0gwZC9VZVZiMlRkQ2xtc0FyR3VDaitXSnRRREJJdjhUcXpGZG5q?= =?utf-8?B?TWpoSzVCR3pja2krTXZaMW9zV2RlRHpkUDZ2ME0xWUNPNlRSOWNTYmpNZFNH?= =?utf-8?B?MHh4eFdOeDhUcEQyL3JrNWt1eml4U05Wdkx4YkVQakJMYWE1dEpCc3pWWi9H?= =?utf-8?B?WWFJWTVuZTJMS0dySDYyRk4rVlpRV0w5bU02RU16Q0xINFBuVFJHbzBzQWtX?= =?utf-8?B?aktRUllOeStlTHlvNmFmOWZHMVFPREdBc2RCSlgyRUFaYlF2cFpNNngreHJD?= =?utf-8?B?KzBXSVY5NXRGSEpQVE5GVE43aXJGaXowSzB6WnJYMVdIc2c2QTlydkFmTEdG?= =?utf-8?B?eURHRWNlWER4MGd4S3JGcGJ1ellyTkZVM3orWVR0T093QlQzRnRuZE1UVVRx?= =?utf-8?B?Q25JQkxnMTRZaWFQMlFUdkgrb3ZMQWMvOUdsSjA3Rk83NytEdkhzaVkyQk1u?= =?utf-8?B?cnJmSnJ0dmwxNjN5dlczbjgyT0RMNEU0RnphVm1nZzRweW04N21FWkFlNlRR?= =?utf-8?B?K3JPUHNMZG54T2JXWm5RajMwMVhsVGlmZ2VndFQzaUxpVDZKMEllS0Q3Z2VQ?= =?utf-8?B?TExGYXJCdHAzVjJoaXlqa0NCZk9STHB3VisyUDh5RWJZZXQrZ3A3SEhZMkhu?= =?utf-8?B?QVVJdENFQ0JyZHM4R0tyWlFGdkVkZWwxbGlSRW4rUW9DNEdPeUxmSllQV1Ay?= =?utf-8?Q?CFny8EAycNoJCvPLSd+RmugaZ?= Content-Type: text/plain; charset="utf-8" Content-ID: <9FDAE8DBE6498247A26C208D2048AE86@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?MGFyMUVaK2dYcVFBekxQWnhqMk4rVnBqZlQvaXBXOUMyMzNLRGFPQ3Fkallt?= =?utf-8?B?d3JMa1RDbEVnVXBSSy9GcXlwVzNWNXh0NUFreHV0L08rRjhTL3h0TlF3b2Zi?= =?utf-8?B?OFVVcDc5RTViM3lFMTBTd1FMZ3FuYk9PTXBJajJWQk1Wak0xY2w4VUVGYXla?= =?utf-8?B?cFhISkJjSk1tN1UzME9FTXRweTQ1V014Vk5lRXJ6bzJlc2hqM3pGZDcxeFlF?= =?utf-8?B?YVZHb2VCbVNua1FMSThxMkxndi9iaEo2MFB1MkdXZTJUeHU4OTNaUEhUOE41?= =?utf-8?B?bXdJd0taUU9UN0dHV2M3WkFiWkdOUStPTlFHWS84SWlROHhjMWIyaEs1dG5S?= =?utf-8?B?bjVmUEtuTjZkUllxMVRGVzhLYzdjUWxMSTk1L1l6YnBDRFg5WXlWcWpJK2Jk?= =?utf-8?B?R0ZISlRUazVnTlliZXB6MjlETHNlOVhPWTFvUWFsdjRQYmVoZmd3QU9hUkNS?= =?utf-8?B?RllGN2Y1T3ozWExVWGN0K251KzhLWEkzc2p2SWlQaG1sSXZ5WHp6V1J3a3Fk?= =?utf-8?B?dHJKZTNqMmNmODFCUzdVanNlQlNGdlNiM3gwS1NBRHBNTnB2aFQ4VCtNZ2xx?= =?utf-8?B?TThmblhXN0VGMTIwTnRMWVJiVXhWS0JzTG1GZXhtS3VyVDRrVVJaOUMxWFd1?= =?utf-8?B?dkMwSER1RTYyZHM4di9YL0Q1UzNXT09XQkhZS2hmRFpxNGFCSGFtVzUzS0lR?= =?utf-8?B?cUtrSVBUM1FCZ0M1d0Mxc25Ed3JVSkNCeU9nSTIzVXpFV0Mzb0l3cTI4dHYy?= =?utf-8?B?U0hhSkRUU2dMQjBaK2Iza3NaOHduZkxRRGRUY3RSbWpXZXV3OTcyQWpZMnB5?= =?utf-8?B?OHo5dmwrVy9xQmZmNjBlRUlWbGZHZVdrSTd6ZXFQL1RxUFlVTm4rOThBSFlI?= =?utf-8?B?QXZWSFRXajNVd1EydE1MVms4cVRnOEpWeDI1RXo3dER1amgxTCtiY3ltcDhZ?= =?utf-8?B?dlV1d3JZVmdoQUJkR2txTXlzK1loTWVCb1hSNzVYY0FPS2ZXMTlMYUZLbE54?= =?utf-8?B?U2hNOVpob2EvUS9XSjFsVnRiWG85bk94TDdUYUdwNVJNRlhES1ozSG9Qckwy?= =?utf-8?B?OEVwOEJjRHpPVks1SEt4SjV0dkpHSEdaWjVJK2hjSDVBZXoremZPYUtQVVEv?= =?utf-8?B?V3djQk5Pb292d29qRVJxK0FvKzlJdkpzdVdScmpOR2JnSnJPMmlvZXpNUktB?= =?utf-8?B?eXVsWEg1ZWdUKzZFYWlqVXlYVkw4UTF2aWh6Ly9KN1RhVVN5TVB1YUhxQWh5?= =?utf-8?Q?FSe/yuDuS6wjhk0?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43f6a1c1-cf81-4c7c-1a93-08dac8b3a80a X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2022 15:51:56.9657 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Z5n5C4S94wYkCY6eCVlbL5IxCpvuoujDVo2ap3Fq+peUItLXC6+3jp/uMjrhC7ULhj/PLwH6En/ioa1z+R7iPjw9aFvQsIarkmUXJXlh37c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4942 T24gMTcvMTEvMjAyMiAxMDoxOCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE3LjExLjIwMjIg MDI6MDgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBUaGUgZXhpc3RpbmcgWEVOX0RPTUNUTF9T SEFET1dfT1Bfe0dFVCxTRVR9X0FMTE9DQVRJT04gaGF2ZSBwcm9ibGVtczoNCj4+DQo+PiAgKiBB bGwgc2V0X2FsbG9jYXRpb24oKSBmbGF2b3VycyBoYXZlIGFuIG92ZXJmbG93LWJlZm9yZS13aWRl biBidWcgd2hlbg0KPj4gICAgY2FsY3VsYXRpbmcgInNjLT5tYiA8PCAoMjAgLSBQQUdFX1NISUZU KSIuDQo+PiAgKiBBbGwgZmxhdm91cnMgaGF2ZSBhIGdyYW51bGFyaXR5IG9mIDFNLiAgVGhpcyB3 YXMgdG9sZXJhYmxlIHdoZW4gdGhlIHNpemUgb2YNCj4+ICAgIHRoZSBwb29sIGNvdWxkIG9ubHkg YmUgc2V0IGF0IHRoZSBzYW1lIGdyYW51bGFyaXR5LCBidXQgaXMgYnJva2VuIG5vdyB0aGF0DQo+ PiAgICBBUk0gaGFzIGEgMTYtcGFnZSBzdG9wZ2FwIGFsbG9jYXRpb24gaW4gdXNlLg0KPj4gICog QWxsIGdldF9hbGxvY2F0aW9uKCkgZmxhdm91cnMgcm91bmQgdXAsIGFuZCBpbiBwYXJ0aWN1bGFy IHR1cm4gMCBpbnRvIDEsDQo+PiAgICBtZWFuaW5nIHRoZSBnZXQgb3AgcmV0dXJucyBqdW5rIGJl Zm9yZSBhIHN1Y2Nlc3NmdWwgc2V0IG9wLg0KPj4gICogVGhlIHg4NiBmbGF2b3VycyByZWplY3Qg dGhlIGh5cGVyY2FsbHMgYmVmb3JlIHRoZSBWTSBoYXMgdkNQVXMgYWxsb2NhdGVkLA0KPj4gICAg ZGVzcGl0ZSB0aGUgcG9vbCBzaXplIGJlaW5nIGEgZG9tYWluIHByb3BlcnR5Lg0KPj4gICogRXZl biB0aGUgaHlwZXJjYWxsIG5hbWVzIGFyZSBsb25nLW9ic29sZXRlLg0KPj4NCj4+IEltcGxlbWVu dCBhIGJldHRlciBpbnRlcmZhY2UsIHdoaWNoIGNhbiBiZSBmaXJzdCB1c2VkIHRvIHVuaXQgdGVz dCB0aGUNCj4+IGJlaGF2aW91ciwgYW5kIHN1YnNlcXVlbnRseSBjb3JyZWN0IGEgYnJva2VuIGlt cGxlbWVudGF0aW9uLiAgVGhlIG9sZA0KPj4gaW50ZXJmYWNlIHdpbGwgYmUgcmV0aXJlZCBpbiBk dWUgY291cnNlLg0KPj4NCj4+IFRoZSB1bml0IG9mIGJ5dGVzIChhcyBvcHBvc2VkIHBhZ2VzKSBp cyBhIGRlbGliZXJhdGUgQVBJL0FCSSBpbXByb3ZlbWVudCB0bw0KPj4gbW9yZSBlYXNpbHkgc3Vw cG9ydCBtdWx0aXBsZSBwYWdlIGdyYW51bGFyaXRpZXMuDQo+Pg0KPj4gVGhpcyBpcyBwYXJ0IG9m IFhTQS00MDkgLyBDVkUtMjAyMi0zMzc0Ny4NCj4gV2hpbGUgSSdtIG5vdCBjb252aW5jZWQgb2Yg dGhpcyBhdHRyaWJ1dGlvbiwgLi4uDQoNCkkgdGhpbmsgdGhpcyB2ZXJ5IG11Y2ggZGVwZW5kcyBv biBob3cgY3JpdGljYWwgdGhlIHVuaXQgdGVzdCBpcyBkZWVtZWQuDQoNCklmIHRoaXMgd2FzIGRv bmUgdGhlIGZpcnN0IHRpbWUgYXJvdW5kLCBpdCB3b3VsZCBhbGwgaGF2ZSBoYWQNCmF0dHJpYnV0 aW9uLsKgIFdlJ3JlIG9uIHRoZSAzcmQgc2V0IG9mIGZpeGVzLCBhbmQgdGhlIHVuaXQgdGVzdCBp cyBhIGtleQ0KanVzdGlmaWNhdGlvbiBvZiB0aGUgc2FmZXR5IG9mIHRoZSBmaXguDQoNCj4+IFNp Z25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+ PiBSZWxlYXNlLWFja2VkLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+IFJl dmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ICMgaHlwZXJ2aXNvcg0K DQpUaGFua3MuDQoNCj4gYWxiZWl0IHdpdGggcmVtYXJrczoNCj4NCj4+IC0tLSBhL3hlbi9hcmNo L3g4Ni9tbS9wYWdpbmcuYw0KPj4gKysrIGIveGVuL2FyY2gveDg2L21tL3BhZ2luZy5jDQo+PiBA QCAtOTc3LDYgKzk3Nyw0OSBAQCBpbnQgX19pbml0IHBhZ2luZ19zZXRfYWxsb2NhdGlvbihzdHJ1 Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBpbnQgcGFnZXMsDQo+PiAgfQ0KPj4gICNlbmRpZg0KPj4g IA0KPj4gK2ludCBhcmNoX2dldF9wYWdpbmdfbWVtcG9vbF9zaXplKHN0cnVjdCBkb21haW4gKmQs IHVpbnQ2NF90ICpzaXplKQ0KPj4gK3sNCj4+ICsgICAgaW50IHJjOw0KPj4gKw0KPj4gKyAgICBp ZiAoIGlzX3B2X2RvbWFpbihkKSApICAgICAgICAgICAgICAgICAvKiBUT0RPOiBSZWxheCBpbiBk dWUgY291cnNlICovDQo+PiArICAgICAgICByZXR1cm4gLUVPUE5PVFNVUFA7DQo+IEkgZ3Vlc3Mg dGhpcyBpcyBtZXJlbHkgZm9yIHN5bW1ldHJ5IHdpdGggLi4uDQo+DQo+PiAraW50IGFyY2hfc2V0 X3BhZ2luZ19tZW1wb29sX3NpemUoc3RydWN0IGRvbWFpbiAqZCwgdWludDY0X3Qgc2l6ZSkNCj4+ ICt7DQo+PiArICAgIHVuc2lnbmVkIGxvbmcgcGFnZXMgPSBzaXplID4+IFBBR0VfU0hJRlQ7DQo+ PiArICAgIGJvb2wgcHJlZW1wdGVkID0gZmFsc2U7DQo+PiArICAgIGludCByYzsNCj4+ICsNCj4+ ICsgICAgaWYgKCBpc19wdl9kb21haW4oZCkgKSAgICAgICAgICAgICAgICAgLyogVE9ETzogUmVs YXggaW4gZHVlIGNvdXJzZSAqLw0KPj4gKyAgICAgICAgcmV0dXJuIC1FT1BOT1RTVVBQOw0KPiAu Li4gdGhpcywgc2luY2Ugb3RoZXJ3aXNlICJnZXQiIG91Z2h0IHRvIGJlIGZpbmUgZm9yIFBWPw0K DQpJdHMgdGhlIHNhZmVzdCBjb3Vyc2Ugb2YgYWN0aW9uLCBnaXZlbiBvdGhlciBrbm93biBpc3N1 ZXMgd2l0aCBQVi7CoA0KVGhlcmUncyBubyBuZWVkIGZvciBhIHdvcmtpbmcgZ2V0IHdpdGhvdXQg YSB3b3JraW5nIHNldC4NCg0KPg0KPj4gQEAgLTk0Niw2ICs5NDksMjIgQEAgc3RydWN0IHhlbl9k b21jdGxfY2FjaGVmbHVzaCB7DQo+PiAgICAgIHhlbl9wZm5fdCBzdGFydF9wZm4sIG5yX3BmbnM7 DQo+PiAgfTsNCj4+ICANCj4+ICsvKg0KPj4gKyAqIFhFTl9ET01DVExfZ2V0X3BhZ2luZ19tZW1w b29sX3NpemUgLyBYRU5fRE9NQ1RMX3NldF9wYWdpbmdfbWVtcG9vbF9zaXplLg0KPj4gKyAqDQo+ PiArICogR2V0IG9yIHNldCB0aGUgcGFnaW5nIG1lbW9yeSBwb29sIHNpemUuICBUaGUgc2l6ZSBp cyBpbiBieXRlcy4NCj4+ICsgKg0KPj4gKyAqIFRoaXMgaXMgYSBkZWRpY2F0ZWQgcG9vbCBvZiBt ZW1vcnkgZm9yIFhlbiB0byB1c2Ugd2hpbGUgbWFuYWdpbmcgdGhlIGd1ZXN0LA0KPj4gKyAqIHR5 cGljYWxseSBjb250YWluaW5nIHBhZ2V0YWJsZXMuICBBcyBzdWNoLCB0aGVyZSBpcyBhbiBpbXBs ZW1lbnRhdGlvbg0KPj4gKyAqIHNwZWNpZmljIG1pbmltdW0gZ3JhbnVsYXJpdHkuDQo+PiArICoN Cj4+ICsgKiBUaGUgc2V0IG9wZXJhdGlvbiBjYW4gZmFpbCBtaWQtd2F5IHRocm91Z2ggdGhlIHJl cXVlc3QgKGUuZy4gWGVuIHJ1bm5pbmcNCj4+ICsgKiBvdXQgb2YgbWVtb3J5LCBubyBmcmVlIG1l bW9yeSB0byByZWNsYWltIGZyb20gdGhlIHBvb2wsIGV0Yy4pLg0KPj4gKyAqLw0KPj4gK3N0cnVj dCB4ZW5fZG9tY3RsX3BhZ2luZ19tZW1wb29sIHsNCj4+ICsgICAgdWludDY0X2FsaWduZWRfdCBz aXplOyAvKiBJTi9PVVQuICBTaXplIGluIGJ5dGVzLiAqLw0KPiBXaGlsZSBsaWtlbHkgcGVvcGxl IHdpbGwgY29ycmVjdGx5IGluZmVyIHdoYXQgaXMgbWVhbnQsIHN0cmljdGx5IHNwZWFraW5nDQo+ IHRoaXMgaXMgd3Jvbmc6IFRoZSBmaWVsZCBpcyBJTiBmb3IgInNldCIgYW5kIE9VVCBmb3IgImdl dCIuDQoNCkknbGwgZHJvcCB0aGVtLCB0byByZWR1Y2UgYW55IHBvc3NpYmxlIGNvbmZ1c2lvbi7C oCBBcyB5b3Ugc2F5LCB0aGUNCm1lYW5pbmcgaXMgZW50aXJlbHkgY2xlYXIuDQoNCn5BbmRyZXcN Cg== From xen-devel-bounces@lists.xenproject.org Thu Nov 17 16:17:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 16:17:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445284.700422 (Exim 4.92) (envelope-from ) id 1ovhZm-0002JO-DT; Thu, 17 Nov 2022 16:17:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445284.700422; Thu, 17 Nov 2022 16:17:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovhZm-0002JC-AR; Thu, 17 Nov 2022 16:17:18 +0000 Received: by outflank-mailman (input) for mailman id 445284; Thu, 17 Nov 2022 16:17:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovhZk-0001oH-8v for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 16:17:16 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20604.outbound.protection.outlook.com [2a01:111:f400:fe59::604]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a046145-6693-11ed-8fd2-01056ac49cbb; Thu, 17 Nov 2022 17:17:12 +0100 (CET) Received: from BN9PR03CA0493.namprd03.prod.outlook.com (2603:10b6:408:130::18) by BL1PR12MB5031.namprd12.prod.outlook.com (2603:10b6:208:31a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Thu, 17 Nov 2022 16:17:07 +0000 Received: from BN8NAM11FT111.eop-nam11.prod.protection.outlook.com (2603:10b6:408:130:cafe::aa) by BN9PR03CA0493.outlook.office365.com (2603:10b6:408:130::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 16:17:07 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT111.mail.protection.outlook.com (10.13.177.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 16:17:06 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 10:17:06 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 17 Nov 2022 10:17:05 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a046145-6693-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f7nR48rhnYLYGrcszkpBk0h3w6i2BytVskAKjreitIN/THhGTa+PpK1WodqXckRPFYNm5BPylqRhJfoLLCBrM94gGc+DvjSvmp/xe4g1UG2qcpDBcOWd0Qf71aT97ATUrE5uccWReTz8ivZJZiNyXITViDETvEMvLWeQdZ5XrGydddv8ZYF/K81RQcl5CtF68AHFGufneeYWp23K3FCu5dhEinLqOh4n9NTl5oHFBBKeQ4lDjHk1RdlIPxdd8xcr/J+8ke0TI2n1/YBuODEXIufjoof4GWkT+uVMjmmUf8ff2oYQ6htnyCoSKRre+WXxsh56ObxtRaT6n21Rolbb4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RW7thljiMKal3UEr0R4gYV8ZGNjwhwvXXRVE7RI0io0=; b=FkvioHhzGavfBHt2cYZ8JDPgoB8lzqlnhVFCaQXZwwPbnH7aHYpsrhWeG3pFL3HvpeJ4yPAnq4YFj0dnBW6AmueHg1YQ4F4FrLqMUlOEstasLsU2vm4EEz7uzd4MhAPYiY1SsDx79cQ+jA3dA2k97e6k8XQW00zPuA6O47C+8E1MDrCSbjkleiZp0F/FCr2APWXu+1GMBpQGijliqI+W9ekiF0BmAK0W1yElceNoCphR8+/mJjQnhfh5P6ImdwmyVuwUkcNOWSqmbf+Rh1/dn3TYSfo8S0yIjFiFEOQ1ZyRsgi01mkR7p0GmrCYdsRZbwhf2semKnRoYPD1fbeiCUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RW7thljiMKal3UEr0R4gYV8ZGNjwhwvXXRVE7RI0io0=; b=P+nklj0vT49SWo1DhL1R5DdeIPEWmYPqnl3EEosnw43X2L0IZt+dC3/nHkoPjZrhHoP2LHzJWFJsV6bzLH3TaNaPM07SXxHqBFOml/nED0HSWIF/oLbccv3/Jp4xyhmohYa3jilVfbfvRbCHnL3N0KoX3s2tOt94C3Tlx32SjkY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 0/2] CI improvements Date: Thu, 17 Nov 2022 17:16:41 +0100 Message-ID: <20221117161643.3351-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT111:EE_|BL1PR12MB5031:EE_ X-MS-Office365-Filtering-Correlation-Id: cb3cabea-b4a6-4d09-c984-08dac8b72be9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9hjzd1k3o8QP8RDqO5ApkFXM97jKbJ6gfYvx/1S6gCyG4UN3u+G/lX1oyKz0TjFOoAS8ZdtYLmmWVqgEatbFslAdOI0D1HWIzIt5zJghf6EYlsgYVZvDf46dfsuBibJ4lgnBl3vNZPMA7TdAgMYPIYR6hQC18zaN210alWmqiTK/KftNgm13swp7InjAdfhMs7LII7xzyV27548nUB8BfQrWp6dnSBdXWeF8y4MPPNZduuzV1c1bdRi41ZPBsZyaUuAQvRP8KHLOY2LDEcB6mNScxYFuU/8PKMBBjjEwjreN+8J6rr5zxiS2I68DAgUvJz/fbk7WhA11y73SedMXW9SLTfjJvC/WK2rJpD8LLd4ohLrpSiJNvBVMJulOs1KatveK1jpr8arua0WKoSy+o0n22WORMCzh0DcAGxXakaVRgUwDbOjVLzTByiTDomF10phxwWBf50fHgpvQMu8cAxZeNUzOp0bDQPk0q2uH2tPi/T4ttGRyOpyYtn6jBIfdCSBhiBh6W5cp55sDxe/ioIp9BhZyOoIMl74LKiPJEiB8H4lNvkuZ8h7BUFoK4L6cGed2tTkcbDMSpKSEdLMWMJwVCc+YeGCZaAcAvqwvUwJNAkjbKVh5xKgVOLD+MOB5gTLcT4vaRONZMb/zmWP7BkErQrkMuiYZUToA9as7Bf6ux3akJw8E9yEWYqKLAweeF6nmMqddvA9NI9r0ndnazpjsBcaHKbCkokq7btxsu2VgUsLv4nFmqxujGoWqYsDUbdcyYHG1c3sNQZL0yT8Wpg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199015)(46966006)(40470700004)(36840700001)(26005)(82740400003)(82310400005)(356005)(36860700001)(83380400001)(81166007)(86362001)(40480700001)(966005)(478600001)(5660300002)(316002)(8676002)(6916009)(4326008)(4744005)(6666004)(41300700001)(70206006)(54906003)(8936002)(70586007)(47076005)(426003)(40460700003)(336012)(2906002)(2616005)(44832011)(186003)(1076003)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 16:17:06.7189 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb3cabea-b4a6-4d09-c984-08dac8b72be9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT111.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5031 This patch series moves the installation of packages at runtime from the test scripts into the respective containers. This series is based on the CI next branch: https://gitlab.com/xen-project/people/sstabellini/xen/-/tree/next Michal Orzel (2): automation: Install packages required by tests in containers automation: Remove installation of packages from test scripts automation/build/debian/stretch.dockerfile | 3 +++ automation/build/debian/unstable-arm64v8.dockerfile | 7 +++++++ automation/scripts/qemu-alpine-x86_64.sh | 4 ---- automation/scripts/qemu-smoke-dom0-arm32.sh | 8 -------- automation/scripts/qemu-smoke-dom0-arm64.sh | 9 --------- automation/scripts/qemu-smoke-dom0less-arm64.sh | 9 --------- 6 files changed, 10 insertions(+), 30 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 17 16:17:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 16:17:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445283.700406 (Exim 4.92) (envelope-from ) id 1ovhZk-0001rt-8a; Thu, 17 Nov 2022 16:17:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445283.700406; Thu, 17 Nov 2022 16:17:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovhZk-0001qu-2s; Thu, 17 Nov 2022 16:17:16 +0000 Received: by outflank-mailman (input) for mailman id 445283; Thu, 17 Nov 2022 16:17:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovhZj-0001oG-6c for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 16:17:15 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20631.outbound.protection.outlook.com [2a01:111:f400:7eaa::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4b6020ac-6693-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 17:17:14 +0100 (CET) Received: from DM6PR02CA0136.namprd02.prod.outlook.com (2603:10b6:5:1b4::38) by MW4PR12MB6900.namprd12.prod.outlook.com (2603:10b6:303:207::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Thu, 17 Nov 2022 16:17:10 +0000 Received: from DS1PEPF0000E640.namprd02.prod.outlook.com (2603:10b6:5:1b4:cafe::3e) by DM6PR02CA0136.outlook.office365.com (2603:10b6:5:1b4::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 16:17:10 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF0000E640.mail.protection.outlook.com (10.167.17.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.11 via Frontend Transport; Thu, 17 Nov 2022 16:17:09 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 10:17:07 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 10:17:07 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 17 Nov 2022 10:17:06 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b6020ac-6693-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jhdjIXyWJIe9I8YepD6KBql5zVqA+Jg0kASJ6viWmy3Gq3v1IDBCCe6yLh9OKpI9vBSnuD3J6Qo9cekBpQam8e0QvbwPv1c55f7v1vacU6d4raESyiRR8tLRVgDhoBuCIXgVaTesm0K/fb7zXEw5sZuwA9lwO0thDzZrx8uDohWorrMuGu11PPfSeREtgOBiLV1+7Umdi2kIvVes0uBs302Dx5/p9I0Kuc/Gb3mIvn2HCwi8JQfAfHyXwQAWKnuLDvM/7EpRVkrsLgKV0s5Qpe38MBCRoksMelf18f7lOsVEJ9K510/gx/9NPqtz4ApCU0/mu7H7CFDD1/3fi/4lJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vWv10e40OF9Taz123R7TXGCwIFoVSKUwP5lR9GD++mo=; b=RbI5IfRwKOCTXroz79XmOaH6W2piymZnDM+vszePTkU9xcYtoRFsw4qj06lRBKX95vW3cPANQJPywSF3WTmnEC3oDKDjh7SO3RUYX6RRKB9wHqWEf/CykLI+hUK4cyPwAO3VYl+iWlKF57inmXauAz2XXiz+Z5p8ReOcZDifvW71ThNSrsTYYA6g3m086cM6qf8FvQYjV67ZiEnmi4640UtX2L53I5wRR1Bd9kEB5NLR4++06bwhLNSSCG0EvKPnwVC3tkKYH+YMX8BaWrgq2aLqN+88ZtfHE+EL2JKqd1D6jKflYzafora6vWphm95hzUgq+epc9kwDXHH2sP5Huw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vWv10e40OF9Taz123R7TXGCwIFoVSKUwP5lR9GD++mo=; b=cuW7M1gqIpMENWwfL1YGXm5yrQWo/H4FWfi7whuSunl6CmshJWc68B4ue2bJIjl9/dPoRm1RpLW6dWYPTloIIyo2E68TxQEEk1/yU4dS6HVVS5xy8bIo3L2olObf2U4Cob2ygCugzupNSfCG19kJKBydedmK8eAxwMMZA9dB4Oc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 1/2] automation: Install packages required by tests in containers Date: Thu, 17 Nov 2022 17:16:42 +0100 Message-ID: <20221117161643.3351-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221117161643.3351-1-michal.orzel@amd.com> References: <20221117161643.3351-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E640:EE_|MW4PR12MB6900:EE_ X-MS-Office365-Filtering-Correlation-Id: 4cce6a79-beac-47c9-0afe-08dac8b72dd2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3o8A7PosccTmPcoW2prHh94+dcqaaHFIWxdDxoRyVQaXwBV1uXTlJXSVaVk4zqGT16gldVCgjJwpS06QfdnGKUeiy5Z5fx8iQOtOKgnio5JNTGvPGIsHwzOL+rKcBM5JYnzHq2/enlGH0a8vh1KYEQmay2o7JX4QemmsExbwEx2/jgNGiyZbAown2KRWMFDtsBC5bE8Z7M+L0hO31hFZQW2aMbsc/Yd/CSQDCdjPXlzqDdrZtz/BzWDYyvpAhebLKcGLvJRVQNvlT4xNaJumwXFYx0ASfHw9wSb6QMbQ+8RwPoPqt6hlNlyLt618vxae891NstHjgd6AN6AOM4KqJyV2T9aO3H0Op6pUSVBsosVEb2mRMS/Hz9N9scGbMwcU2uEAYy+huqm4zc5KiDj54nN2ZxHjRFuDQqJMrCQTyIzScFnFeVFq7HKlJ3Jkk3jC7SVzjV7OPbHiNJyD0zwUvaq0QF2AIo8sApU+66MD43mNe+DImeHYzUKO/D2teQ5mrwvtD0JHmtDYzeFVe2bAQAg7APq2MY66JWKxktj3RpRLUvDUBLYK/iAuXvs5uq/5YPb/1O7y8AZqvOUi61G99pZzIrrdZe7p1o5k2E/mutdq4bZxJRKvNyS7ASaV9ZOT8llQhl6L08BsU5hLhCvPpz3B9ZUTQ4k3x0Ha0gMvJEqFnwgBNQ0gZAif9SQ3ZHL3sK5CwU/Ap7nP3QXSXtUE6YiqR32XZbosu+GbPKgdTl0= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(376002)(346002)(451199015)(40470700004)(46966006)(36840700001)(70206006)(2906002)(8936002)(81166007)(36860700001)(82740400003)(36756003)(70586007)(44832011)(356005)(4326008)(40460700003)(8676002)(41300700001)(83380400001)(5660300002)(478600001)(40480700001)(6666004)(26005)(186003)(426003)(1076003)(86362001)(54906003)(2616005)(82310400005)(47076005)(316002)(336012)(6916009)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 16:17:09.8875 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4cce6a79-beac-47c9-0afe-08dac8b72dd2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E640.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6900 Installation of additional packages from the test scripts when running the tests has some drawbacks. It is slower than cloning containers and can fail due to some network issues (apparently it often happens on x86 rackspace). This patch is adding the packages required by the tests to be installed when building the containers. >From qemu-alpine-x86_64.sh into debian:stretch: - cpio, - busybox-static. >From qemu-smoke-*-{arm,arm64}.sh into debian:unstable-arm64v8: - u-boot-qemu, - u-boot-tools, - device-tree-compiler, - curl, - cpio, - busybox-static. The follow-up patch will remove installation of these packages from the test scripts. This is done in order not to break the CI in-between. Signed-off-by: Michal Orzel --- automation/build/debian/stretch.dockerfile | 3 +++ automation/build/debian/unstable-arm64v8.dockerfile | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/automation/build/debian/stretch.dockerfile b/automation/build/debian/stretch.dockerfile index da6aa874dd70..30fcc5288dee 100644 --- a/automation/build/debian/stretch.dockerfile +++ b/automation/build/debian/stretch.dockerfile @@ -49,6 +49,9 @@ RUN apt-get update && \ apt-transport-https \ # for test phase, qemu-smoke-* jobs qemu-system-x86 \ + # for test phase, qemu-alpine-* jobs + cpio \ + busybox-static \ && \ apt-get autoremove -y && \ apt-get clean && \ diff --git a/automation/build/debian/unstable-arm64v8.dockerfile b/automation/build/debian/unstable-arm64v8.dockerfile index 5c73458d9d19..0080c22ba21f 100644 --- a/automation/build/debian/unstable-arm64v8.dockerfile +++ b/automation/build/debian/unstable-arm64v8.dockerfile @@ -43,6 +43,13 @@ RUN apt-get update && \ wget \ git \ nasm \ + # for test phase, qemu-smoke-* jobs + u-boot-qemu \ + u-boot-tools \ + device-tree-compiler \ + curl \ + cpio \ + busybox-static \ && \ apt-get autoremove -y && \ apt-get clean && \ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 17 16:17:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 16:17:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445282.700401 (Exim 4.92) (envelope-from ) id 1ovhZk-0001oc-0P; Thu, 17 Nov 2022 16:17:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445282.700401; Thu, 17 Nov 2022 16:17:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovhZj-0001oV-S2; Thu, 17 Nov 2022 16:17:15 +0000 Received: by outflank-mailman (input) for mailman id 445282; Thu, 17 Nov 2022 16:17:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovhZi-0001oG-GF for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 16:17:14 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20601.outbound.protection.outlook.com [2a01:111:f400:fe5b::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4aad52d7-6693-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 17:17:12 +0100 (CET) Received: from BN7PR06CA0070.namprd06.prod.outlook.com (2603:10b6:408:34::47) by IA1PR12MB6625.namprd12.prod.outlook.com (2603:10b6:208:3a3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Thu, 17 Nov 2022 16:17:09 +0000 Received: from BN8NAM11FT093.eop-nam11.prod.protection.outlook.com (2603:10b6:408:34:cafe::b3) by BN7PR06CA0070.outlook.office365.com (2603:10b6:408:34::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 16:17:09 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT093.mail.protection.outlook.com (10.13.177.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 16:17:09 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 10:17:09 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 10:17:08 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 17 Nov 2022 10:17:07 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4aad52d7-6693-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YlXfzg68BpxYKEWuMM7SvbZQiPQWAt7f15r6nyxApd01MYgAuWFbtg2Hq0LzISManbC61JRuO6ZFttSXPU4ah8un0u2xQrPNVgbiWNzI9day22lg1l0R6wBzK1S4uBGQBNRQ3B3CIskDXVow/IhOpvDlAEqpgU3WbuBt9L/LN2btUiOiQ6kPMr4/WbIK3MKHiQ+AAQRGc6uHx0zbSNqzIIYbj8fPdSnyhbDF9+Kjz+xa/MtifuPIYhq6DulHsYpUBi1/CdoumhfwPlLJasMGAUO7pCsNihNQw/1lKN8hu96Yl/AFYPbAwMgg4Qi1ECYxNASw3bCRWia53bLHp6Ozzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PykDC6RlR5P0Fh4XODBld9/bS/82sULTw8zRdzeWUZk=; b=QgGbgk5Uak9NK6L/7S06bZiFfb20vlVVlKNKRL2Krq1ZF8cCX0lABQLaENsHQ8ECX5ciwoRMkndqeBN7RtYX7BGNgEIikIJxau0he/eIz+ZjnZqsbaCyfUqA1WjZeuoB5QHmE8MJaB/KQYF6ElnY7WFPb/Nk3GzzRMSBkwf+AnHuUBQAVoJd6QLyxe5LVeMunMjfw2HegZr7TTFF367cy+feEBB+wIS3GfBf/jHXqlNgzfJOJd7/H8d7wmsBgMofyZkujaSQcJuPrw+gZOs+HyGT1s0Hqb7GaEk5AI0EWYcxKYhTHF5GG9NlNm8Aniad82u6p/ARNteMIAy4JWEf5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PykDC6RlR5P0Fh4XODBld9/bS/82sULTw8zRdzeWUZk=; b=nEj5/X003KXT+4ZmITI0LTUtGeWxEN7F+LJUQhqwswsH9BCqR8c3gG07gY+TnH0EJTAcIWxcQopWxe0FkLIJ+rurugciIn1Wr9+8dYqQeaBBM2xyfCZBHpJFKQLTeJ82dID81NaypwUVmmsw/FzP9aCz0ugigaYSZlqu9VuvkN4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 2/2] automation: Remove installation of packages from test scripts Date: Thu, 17 Nov 2022 17:16:43 +0100 Message-ID: <20221117161643.3351-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221117161643.3351-1-michal.orzel@amd.com> References: <20221117161643.3351-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT093:EE_|IA1PR12MB6625:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e54a16e-779b-474d-edaf-08dac8b72d88 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TTx8PD3pf3artX4Uy3kyCBy0fOzWYJC8h63n4Xs8o5f74V2iGCjPFg4QehzXIjBovBj/CtSonQjzSO3jRg0YI9CLC5B05FfeGvasgI7NzK8wiuYCQXNWbhhLSVldzcLEAQ9YB2fg1uQ5lKgQEjxMWYRCzD7RQlfIfhVCJlg5qMRwO9YF309Hita36tvqopPOEGNhbwPxC0z/3Fra10i6oPh8kz1ManWAUZlFtpgcL/ID7n1P0ifXJ5zob2i+FZk7lGB7+YrC5p3NdeQ5n542j59Y4l9au867GAINvBbZxWd476Z90Vlx7zTL7JVS2kbtZgATGSuSba4xv/WZysgouVAXoa9OpVgd1aebNQzCVkrwI/zLPz17uwycl00m1mHcSgi3kVcdm2/4xiKnJ/puc8aoTs3cDhJIiqzccOkKbxVQJKZnXc8YsFMkUtCXwh5T+vFhL3h5ryZ9DWymX28qM4Ki5+19rAe4HeePCyf+Qn+whPCrg/zwiBkXXbB2ReAA052gEoQIO3HL2te+FRCNfS0I/HSq1ST9RlntwaLxhIk9PkXiRcWFJZhVEbZBZIKIU+VAoTE0tRPUgIHVWbDl7DRoZmqDvz7qGWA22fJvuEVLaGsLdpN+9giCYBl9rmbiGHiuefErwyF0eYa/lQ2BcAjU3Nxd4+3Zpj02KDgcLHMyqFBDpHPdFOq2GOakkXUFX7xYP9aaYCy+SgolwDMWFIXqKb4NFmdn8Y/IW4wlZHPaukbuDCjpNUkcugaUCEQTwuiCqldzqOwkkQkalp+BOeyCIwEQScr729199OEGwfX7A8322Rzo+LvZ+C7joraKiiab+SlBIMJ8xe18hD/D1w== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(136003)(451199015)(36840700001)(40470700004)(46966006)(82740400003)(2906002)(4326008)(81166007)(356005)(8936002)(86362001)(36860700001)(83380400001)(70586007)(316002)(1076003)(6916009)(54906003)(426003)(186003)(2616005)(336012)(36756003)(966005)(47076005)(478600001)(40480700001)(44832011)(8676002)(41300700001)(82310400005)(40460700003)(5660300002)(26005)(6666004)(70206006)(1910800001)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 16:17:09.4396 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e54a16e-779b-474d-edaf-08dac8b72d88 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT093.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6625 Now, when these packages are already installed in the respective containers, we can remove them from the test scripts. Signed-off-by: Michal Orzel --- automation/scripts/qemu-alpine-x86_64.sh | 4 ---- automation/scripts/qemu-smoke-dom0-arm32.sh | 8 -------- automation/scripts/qemu-smoke-dom0-arm64.sh | 9 --------- automation/scripts/qemu-smoke-dom0less-arm64.sh | 9 --------- 4 files changed, 30 deletions(-) diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scripts/qemu-alpine-x86_64.sh index 2e9625109c56..8c8d0b0cd759 100755 --- a/automation/scripts/qemu-alpine-x86_64.sh +++ b/automation/scripts/qemu-alpine-x86_64.sh @@ -2,10 +2,6 @@ set -ex -apt-get -qy update -apt-get -qy install --no-install-recommends cpio \ - busybox-static - # DomU Busybox cd binaries mkdir -p initrd diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh index ef19b988c2c4..98e4d481f65c 100755 --- a/automation/scripts/qemu-smoke-dom0-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh @@ -2,14 +2,6 @@ set -ex -export DEBIAN_FRONTEND=noninteractive -apt-get -qy update -apt-get -qy install --no-install-recommends u-boot-qemu \ - u-boot-tools \ - device-tree-compiler \ - curl \ - cpio - cd binaries # Use the kernel from Debian curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz diff --git a/automation/scripts/qemu-smoke-dom0-arm64.sh b/automation/scripts/qemu-smoke-dom0-arm64.sh index 9004c537e325..0bf5cfdc61f9 100755 --- a/automation/scripts/qemu-smoke-dom0-arm64.sh +++ b/automation/scripts/qemu-smoke-dom0-arm64.sh @@ -2,15 +2,6 @@ set -ex -export DEBIAN_FRONTEND=noninteractive -apt-get -qy update -apt-get -qy install --no-install-recommends u-boot-qemu \ - u-boot-tools \ - device-tree-compiler \ - cpio \ - curl \ - busybox-static - # DomU Busybox cd binaries mkdir -p initrd diff --git a/automation/scripts/qemu-smoke-dom0less-arm64.sh b/automation/scripts/qemu-smoke-dom0less-arm64.sh index 933209e2e01e..2b59346fdcfd 100755 --- a/automation/scripts/qemu-smoke-dom0less-arm64.sh +++ b/automation/scripts/qemu-smoke-dom0less-arm64.sh @@ -38,15 +38,6 @@ fi " fi -export DEBIAN_FRONTEND=noninteractive -apt-get -qy update -apt-get -qy install --no-install-recommends u-boot-qemu \ - u-boot-tools \ - device-tree-compiler \ - busybox-static \ - cpio \ - curl - # XXX QEMU looks for "efi-virtio.rom" even if it is unneeded curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom ./binaries/qemu-system-aarch64 \ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 17 16:27:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 16:27:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445297.700433 (Exim 4.92) (envelope-from ) id 1ovhjN-0004ZL-BA; Thu, 17 Nov 2022 16:27:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445297.700433; Thu, 17 Nov 2022 16:27:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovhjN-0004ZE-8H; Thu, 17 Nov 2022 16:27:13 +0000 Received: by outflank-mailman (input) for mailman id 445297; Thu, 17 Nov 2022 16:27:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovhjM-0004Z8-NG for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 16:27:12 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae79982f-6694-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 17:27:10 +0100 (CET) Received: from mail-co1nam11lp2176.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 Nov 2022 11:27:07 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB5970.namprd03.prod.outlook.com (2603:10b6:610:e1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Thu, 17 Nov 2022 16:27:03 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%5]) with mapi id 15.20.5813.020; Thu, 17 Nov 2022 16:27:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae79982f-6694-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668702430; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=LKhgxxwXJyatr88HgRHYL0lQJr/bi+Lp3jg4QI2ewKw=; b=ND7n3i6txLz7sxjvrWqaz9YNhrCiykA1sFoyeTqzqwcS1K0aQJCr36gQ KLNBZk29W/J3f4xnH0QPy3Ti7FRRSpl+vyD1F943Vf+ltLDEBK7FpX8/M Uu+2PJ0aQqEVUFDePRMWTDnPXUANPkO+CwhP4D1GJ6vjQMDRG3Nr0LdgD s=; X-IronPort-RemoteIP: 104.47.56.176 X-IronPort-MID: 85067423 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ojIJDaNioPZZ2ubvrR05lsFynXyQoLVcMsEvi/4bfWQNrUp21zJTy WoZCmmHbKuDZTT0KdkkaIS0/U0OsMDczIdhQAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5wNmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vpqOFBz+ fcxEQ4MXkyFq/qrmqKCYMA506zPLOGzVG8ekldJ6GiASN0BGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PRxujeNpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8efwHulB95IT9VU8NYwhUfJ+ysaKScQclmxuaO20lS9QoJmf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmSzoLE7gDfAXILJhZac8AvvsIyQT0s1 3eKksnvCDgpt6eaIVqf67OVoDWaKSUTa2gYakcscwwB5NXypZApuTjGRN1jDa2dg8X8HHf7x DXihCIznakJhMgHkaCy50nagimEr4LMCAUy423/fm+j9BI/W4ejaKSh812d5vFFRK6JQ1/Es HUalsy26OEVEYrLhCGLWP8KHryi+7CCKjK0vLJ0N5wo9jDo8Hn6e4lVuWh6PB0wbZhCfiL1a kjOvw8X/IVUIHahca5wZcS2Ftguyq/jU9/iU5g4c+ZzX3S4TyfflAkGWKJa9zmFfJQE+U3nB aqmTA== IronPort-HdrOrdr: A9a23:Z8kjoKpu//yuAUwvXHyB7vUaV5sDLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcItKLzOWwldAS7sSobcKogeQUREWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZa6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyR+49bLgFBCc/xEGFxdC260r/2 TpmxHwovzLiYD79jbsk0voq7hGktrozdVOQOSKl8guMz3pziq4eYh7XLWGnTYt5MWi8kwjnt Xgqwope+5z93TSVGeopgaF4Xiv7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twriGknqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYdU99WPBmcUa+d tVfYbhDcVtABWnhrfizzBSKemXLzAO99G9MxA/U4KuomNrdTtCvjYlLYQk7ws9HdQGOtl5Dq 3/Q9pVfPsldL5oUYttQOgGWse5EWrLXFbFN3+TO03uEOUdN2vKsIOf2sR92AiGQu1+8HIJou W2bHpI8WopP07+A8yH25NGthjLXWWmRDzojsVT/YJwtLHwTKfidXTrciFkr+Kw5/EERsHLUf e6P5xbR/flMGv1AI5MmwnzQYNbJ3USWNAc/tw7R1WNqMTWLZCCjJ2STN/DYL72VTo0UGL2BX UOGDD1OcVb90iuHmT1hRDAMkmdDnAXPagAZZQy09Jju7TlbLc8wzT9oW7Jlv2jOHlFrrE8el d4Lffujr67zFPGj1r10w== X-IronPort-AV: E=Sophos;i="5.96,171,1665460800"; d="scan'208";a="85067423" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KknGO1sQA0zWS8jPlW/WpxKCchYs90/DR30i12YwFD/liUqZebtSMloLfeR0/CHcRA/8rizOzppmQ9/QbLnB1aRvRyt+v325tYwzVIgheI3pOh1SLeOdIZhWDBsn2/SPSDa35CZXx3odGd5fUtkkol2Nnyi3k0fDr6agXYch6ybabBK8qF/7rO0PEPcl+H3rBK7Lk8eTQCBL677cHaIlCpABVSpDNtmVkXau/BhmpHy9hg0z/UBPF6Qoqo1GIL3iZPBzirN8cSyZxwCyp10dx8/61WK5/NKI9FQEa0S2lYlZmWPs8YwFS/XtoVVFTpgjyaicC8AFQ1tKLWYYbkuoBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LKhgxxwXJyatr88HgRHYL0lQJr/bi+Lp3jg4QI2ewKw=; b=LgzWOa4yJwtJ/ufbSqXnuQyIm7Tg7jlGyhuHt7E+Luc5o4ymfFrv8TE8vJZ1WYSxZxhcJvgl44KllpnDhYNtCa5b6YHVa+DHH4HYUY0KwFT7T8gJBPrEh9VbrHZ3UUvS3fpP9OlOHhm2WY8F1WY7SOnXsUB5Ju1dC2dPplu/+js1xdlN+pCFIsEf4kdK61VJrcnchwDahHsm0Ddc8zk7wRCTx4JvbpPZYDL3N3mxcbAh1MmaSM42bAr6TDp6czq2LP6BXfunUMrCJ5Q32L4ToW0YAFvDdFOCU7q3QItiSK+YulHSMEAEShrs694l6SgscpncYdVjWk/1YlMWt18flg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LKhgxxwXJyatr88HgRHYL0lQJr/bi+Lp3jg4QI2ewKw=; b=Tp1tP4n0buchxuhA7MUTw4a0D87zC47jcS1+xHI8lFQzx/uX/Z9dqjXfEopk3KRW1DwAYEK59NCuuCQaxxmqriuAxcmiU3H5VTh4+qjXOGJwfbKX2mdwKxyVCyYZjvDgbd71bCQUvJvrjVN0UkwsxyJ8Y7hosI6tikfAWOpRGHc= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Henry Wang , Anthony Perard , Xen-devel Subject: Re: [PATCH 2/4] tools/tests: Unit test for paging mempool size Thread-Topic: [PATCH 2/4] tools/tests: Unit test for paging mempool size Thread-Index: AQHY+iEU7bRDKRjfo06qF2T8yB0IDa5C7Z4AgABg+AA= Date: Thu, 17 Nov 2022 16:27:03 +0000 Message-ID: References: <20221117010804.9384-1-andrew.cooper3@citrix.com> <20221117010804.9384-3-andrew.cooper3@citrix.com> <3ede581f-3393-9290-b929-6c28450b007a@suse.com> In-Reply-To: <3ede581f-3393-9290-b929-6c28450b007a@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CH0PR03MB5970:EE_ x-ms-office365-filtering-correlation-id: f44a9b4c-f2cc-480e-deda-08dac8b88f65 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LRvhFdJ8ts5UvN/A6W1KBLSyOcreS8iEpxmCPXh8kD64LMe6HCWOB2sSEUo9M185wR4Dpb8uPMID1UEpC8JecB18LwnzeCIedVJCQWuiW5P/PR0fCrBI272BtUccB1cRaPktkcPSptv9TklOdJzr4wvMsp7CtK2EISmSVIuwGES3lAs+zSNusRsKsv0TKKodU46N+aZJ9Srrq4gfiBfYGBvlsYETwCW/HyvoH9uf1t7f4Mm4oTIYg+k7drOoIdEEM1EUzoYsJkPpRtj8opkBl89OuTCq3iJYOfTudyBKxEvd0AbFvYdsdVcheILZTS9KqiMLg/zQ1XqkxAuYBgzNCMwB5RZm/y8jihW+3/8uvElqxR4/VxiGdcdwY+EL0ERh3KCKey2CDn8n6j3MXKvb8r3pY0aRlifdTk74P1p8TW50SDY7sJQDd196o/GjCFvgwxbiq55ArWzVEzL3bVkVjCcDMOrjIJ88/wOVjdnF8465xztROzADG6dgkr4TKDyzU7PFRUc52Mxb5AlPm6rVhIe92POQ+0BPOm8c59f1CffDGCvxkh9uevXe4vrdlEtbZxiS/0Au7sOLOkUWwum7EaLLcH1pRbBdxGR1+VigxBYwKMFXkbmjsLj0psqbgjH6MJguCfw6d9eG5jmgG+nBqor6sR4aDDocQ0jWAnhRUgnR8HF2FCQqIaw/iYs04FTfWn8txt4aAos2RfW8/B10ZSvuh88MsacF6XHlKTBoZExOErHFVCvsMzzblxo1eBhQRscSQW7cy1mdKO4d40aahA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(366004)(136003)(451199015)(36756003)(31686004)(2906002)(66556008)(5660300002)(41300700001)(8936002)(66476007)(4326008)(83380400001)(66946007)(64756008)(66446008)(76116006)(86362001)(31696002)(8676002)(91956017)(38070700005)(316002)(6916009)(186003)(71200400001)(54906003)(6486002)(2616005)(122000001)(82960400001)(6512007)(26005)(38100700002)(6506007)(53546011)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cENiMUh1UlBWbUp4UkttK1B6UjRXeWxvMXgzb0lQbE9QdWRQcnRULzFFa003?= =?utf-8?B?Z1Z4RG5qYWpVcUVqUmJSZlZOWElWNEErZTl1MkJjbUJOWjcvWnJEOVhUZ1U2?= =?utf-8?B?NjgzUjk3L2tJK3l4VWpTdDdaa0RzRjA2TUNHaGpzYzl2T2x2S3VFZzBkVWtk?= =?utf-8?B?d09xb2FjeDVQdld4ekhESW9PeGMvRkoxRlRIQXpaTERRb3ZLQS9Na1RWNFRv?= =?utf-8?B?cjJEQndNRXZSemgwS0RRVGx6Rm9rT08rTW9qWUg5bWdSakVaRk5kWXViWVN1?= =?utf-8?B?blYxdXRJREdlbzlXRjBxc29JaTBzSmN5ZnNJK3krVVp5WGlmbytzREJJVTdx?= =?utf-8?B?NWRHNVQ1Yk5ITzl6RUxoT2JGNUJ4ZVVHYmZVL1JCbFFvdlhyYjFsRkRMbU0y?= =?utf-8?B?dXk4M0xJOGREK0taNmxaVytPaVhtQ0J1c2Y3ZG1SdHNHNWJKZVRnQncxVmdl?= =?utf-8?B?ZEFIdmR5bkh6SDA0TjVEWnNPaDRFUFk3bmg1WjRGaHVyK1NvUDF2b0pFbXZu?= =?utf-8?B?NndSR1c1UllQVFp2eE1wNFNyUTA1dVRRcTQ5ZGlVT01tVmJ5NXBHRU9SU1Qr?= =?utf-8?B?bzRtczVNc1Y1ZTM3NTNxcW55RG5abjZvaXVJYkltUm1OUkVmRm0zdGppdit4?= =?utf-8?B?dU1VZHFlQkx1V1V3Q1VBNkw2TFQ5T1VFVzNhd1J5NWZWRktPNnplb2xHbG11?= =?utf-8?B?YWpqQTAyOE5MVzFRdE5CWTlqN1c0RWI4cjVmcG9oSTNJVzYyMWRsU3hoKzlx?= =?utf-8?B?M3dudmhCTzlKRnhHaCtSZk5XUTlESng2dFM3dTVDNzdiV3JZdFRpUG1tb3Fa?= =?utf-8?B?RXYyR1F2eGk5bWxzcFA4bi9xcE5BTmZQaFVJOUFBUjNSQ093bmRiWk4zVEdL?= =?utf-8?B?SVBNTTJwakVxaXpVSjRiL1NCWGtVLzdUbmJHRjExR3d4eWJYbHVzS0xVRDd3?= =?utf-8?B?aGU4cWxsVnpVOXJrT3l1ZFdXbFE1eVV4anhFR3V4cFYzbURLd2M4MXJLVElU?= =?utf-8?B?RDI2enFtT0ZFekUxT1NWeGxzNlUyMUZvd0h6Y3Z0dk9XQVRGL0l4K2EvSkNW?= =?utf-8?B?VDljd29UeVRWZzUvWGdQdTRMTmtpYUhCUER5WWtEdEM2VHBYcXhQN1dDSE1w?= =?utf-8?B?WWx1bzNzNUl6ajNtZFJpTCtKZjcvQTExVnNpQkRRQUxHQjVjOTJHRHlzTSs1?= =?utf-8?B?cUI4OThNdXNudk1Mejc1cW1JTVVtREpNZ1BRY2hkVjRSMXJPdHBqVm1qQThW?= =?utf-8?B?YkJ4UHg1OC85NXpqb2traW9LeVFmdlAwQ1E3R3hNSkxVeHFJYmxtZWR2bGU3?= =?utf-8?B?Mlp0Q0dGVWtQKysyQXd4bHN4NzFmQnoxbk4rS1d6emxNbjFFV1ZISlF6VEdG?= =?utf-8?B?QVRDOUtyVkpFalQ2d3VIU3B1QTFCZ3RvL2RHMVc5Qjk3dkxDRTJqRXJzRXIz?= =?utf-8?B?ZWRQalp6S2g2eUZEVUNxYytLYXNFU3U1SjR3NWJHbzF5MTBXVHpPb25pQmNZ?= =?utf-8?B?RlA0MnNHUWpjenh3bCtGNjJ4UVJTa0pUNHBjZ3VVbStLcVl4dWFCdnh5K1NN?= =?utf-8?B?R3d4VERtenpMTFFTS3VnTW1BeWVaQU1EanQxOW5tbGI3d3ora1REUGx6anp1?= =?utf-8?B?Zkg4Q0JLQkNPdzNWQkE4MHR2V1BndXFNSEJOUGU4SVUrem0wVjJlR1lUeU41?= =?utf-8?B?b250dEp3QlZuaGh3aTRaWXd3UEJ2MGJYVGx3RSt3TVVxdWRXM090YU51QlVu?= =?utf-8?B?WmhOYjh2WTU3SUhBVzBrZWpQU0lGR3JYbkNrK1o1STNGOVhwd2g5dWdYL2RJ?= =?utf-8?B?Z3lHMVJhM2RhUDdsQTdONmV6KytROW9IZ3JFSnlxMktjSDNnbkFiMzBGdXcy?= =?utf-8?B?K2FrVTVDaDZqR3M2S2E0azdSYkJzS0UvZGh1Qi83QjZwZFEzLytvbEVSaWVC?= =?utf-8?B?b3RhalA4UDlHczBhZk90Rkh4Q093alRTdkhidkJsMy9PVlE4N0pIYlVBU21l?= =?utf-8?B?TjJRcjVhNGQ2czl0TjFiZXVUejJ1M2s5Ullxc2wvNzZGUlZldW5zRjJZK0w2?= =?utf-8?B?SWpTZU42RFJDUk14bTZYbWVkZzVlemtqRkdkVlhjSEZXcTk2V3g2dnNTM2JW?= =?utf-8?Q?yG1ueQSv7ad+C6pZ/tRxLBUfB?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?d04vYTBocWtMd29Bb0hmWFl2S0xNOFZJMXJRL3hsMVkzbDBSaHRiQ1ZtaU1k?= =?utf-8?B?U1NBVnpQQWdUNlY2bGdzM0FPNWRYdlM4Vnh3czZIaWxoSWpJN2l6cEdtdS9u?= =?utf-8?B?THpSc1lnL2xMSmFIZ3VEUkF5bGxaamdxTEhxYVAzTExoQVM2QVpCcFVXMDBv?= =?utf-8?B?dEZDZVBFYlJIV25uYUh4YTUyTnBQWDZLY2hzenJZZjdOUGNLQlp5amZxOC8r?= =?utf-8?B?Tk5FTUs0WGdiZ1BsaDJNMlZhOXF1cTVTS3F3WjJZRVhEaEl6ZkkwcTZvKzdN?= =?utf-8?B?UjU1YnRyZGNuYkdPS1BZVDFPdENDNFhEZGJxTlFGZEpHS2plWmFtd3Zla2Uw?= =?utf-8?B?cGJaZXkzU0dRQVJ1UWFGQXMyMHU0bDk5YnNHWE40Q0Rvb1NTZHBtYjZWRTBF?= =?utf-8?B?Y0t2eUE1R1ozYlUwNXJwRGowcTF4UVBUckIva05TcTVxdGIvMTdrdXJ6by9F?= =?utf-8?B?bk1TQ1JiZk1nYkdJQ1VLOG5FMjNORHhYR1JRVzZlNnJUcm1Oc3hzckZSVlNy?= =?utf-8?B?YndEdEZ5cnhLNjZuaWpQdkpRY3VoTDY4bHhDOWE3elRvRE12UGlNUCtWVXQv?= =?utf-8?B?UVpmZDdBbzJGWlVjVmdtMTU1bk1kenZwdy9aU3oyc1ROUU0wVlFtQ1o4cWFy?= =?utf-8?B?R0pIOERRVXpYdmVJbGF6ZnM3UXBreWVQYnhZWm80ZEYzcFc2ajZzcUE0bGts?= =?utf-8?B?WVVpRERNRjYyMjl6SWc1MFI4QU1ZN2xYMEg0ZS8ydm1zWFVOaW40dkpVSEgr?= =?utf-8?B?a1pva1pJaWFTeVJnalFqdHFZNW5HVHFtQi95ZzJFNGZzNUc0Vk5Jc1hPem9P?= =?utf-8?B?bFc4dzhEdWpFbUxuL3ZtdkZlcUhSMWF4UmZYQTgvL3VubjdqOHNOQStzTDdE?= =?utf-8?B?SkQrQXFZOGwycWp5Nk5sY1NobkI1b2k4YklCWTF3SGtZTFpldzV4TGZLTTd2?= =?utf-8?B?TVBITFZZU2VvVlRNS1F4L3ZwYlJUdHBZaUc1Qk5LQ05TNlFDaVZoZUFkYXhr?= =?utf-8?B?WXVPbnNRVXoydVBkOGp4em82VkNTT0JnTGpMa2dvYnBqdDlWSXRvUkY5bzgx?= =?utf-8?B?T0hTMlRZemV4UCtZSi9udG5ZdkV5b0xkZkR3WXoyZytBSEFSM1cxTXJDMWJ4?= =?utf-8?B?ZWJhQjNhcTNIM2hQNE14aDVnT0p5TWRiUTZrQVdFblBaZEQ2L2F5SFZ6bWI2?= =?utf-8?B?dUJXUkFCbTdHcEN6WVZhbW5uZnpWZEx4aGpQTmRLbXUrTVV2VC9JWXBnbVRj?= =?utf-8?Q?e77uCR0PnWUmv5P?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f44a9b4c-f2cc-480e-deda-08dac8b88f65 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2022 16:27:03.1546 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Zk2bxI2j/rlVlNYQ4HJcDrjC01LbU187VAu4RW22DPODzlnj1jMAQcmXOv2k51C6osgMTBnO9whnfxgfUWtAzq4lTMeXHY1knoiEFycHY/Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB5970 T24gMTcvMTEvMjAyMiAxMDozOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE3LjExLjIwMjIg MDI6MDgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBFeGVyY2lzZSBzb21lIGJhc2ljIGZ1bmN0 aW9uYWxpdHkgb2YgdGhlIG5ldw0KPj4geGNfe2dldCxzZXR9X3BhZ2luZ19tZW1wb29sX3NpemUo KSBoeXBlcmNhbGxzLg0KPj4NCj4+IFRoaXMgcGFzc2VzIG9uIHg4NiwgYnV0IGZhaWxzIGN1cnJl bnRseSBvbiBBUk0uICBBUk0gd2lsbCBiZSBmaXhlZCB1cCBpbg0KPj4gZnV0dXJlIHBhdGNoZXMu DQo+Pg0KPj4gVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDkgLyBDVkUtMjAyMi0zMzc0Ny4NCj4+DQo+ PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29t Pg0KPj4gUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0K PiBBY2tlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpUaGFua3MuDQoN Cj4gKGlmIHRoaXMgY291bnRzIGFueXRoaW5nLCBzaW5jZSBhcyBpdCBzdGFuZHMgdGhlIG5ldyBz dHVmZiBhbGwgZmFsbHMNCj4gdW5kZXIgdG9vbCBzdGFjayBtYWludGFpbmVyc2hpcCkNCg0KSSBk byBpbnRlbmQgdG8gZ2l2ZSBpdCBpdHMgb3duIHNlY3Rpb24gaW4gZHVlIGNvdXJzZSwgYnV0IHRo aXMgZmFsbHMNCnZlcnkgbXVjaCBpbnRvICJUaGUgUmVzdCIgYXQgdGhlIG1vbWVudC4NCg0KPj4g LS0tIC9kZXYvbnVsbA0KPj4gKysrIGIvdG9vbHMvdGVzdHMvcGFnaW5nLW1lbXBvb2wvdGVzdC1w YWdpbmctbWVtcG9vbC5jDQo+PiBAQCAtMCwwICsxLDE4MSBAQA0KPj4gKyNpbmNsdWRlIDxlcnIu aD4NCj4+ICsjaW5jbHVkZSA8ZXJybm8uaD4NCj4+ICsjaW5jbHVkZSA8aW50dHlwZXMuaD4NCj4+ ICsjaW5jbHVkZSA8c3RkaW8uaD4NCj4+ICsjaW5jbHVkZSA8c3RyaW5nLmg+DQo+PiArI2luY2x1 ZGUgPHN5cy9tbWFuLmg+DQo+PiArDQo+PiArI2luY2x1ZGUgPHhlbmN0cmwuaD4NCj4+ICsjaW5j bHVkZSA8eGVuZm9yZWlnbm1lbW9yeS5oPg0KPj4gKyNpbmNsdWRlIDx4ZW5nbnR0YWIuaD4NCj4+ ICsjaW5jbHVkZSA8eGVuLXRvb2xzL2xpYnMuaD4NCj4+ICsNCj4+ICtzdGF0aWMgdW5zaWduZWQg aW50IG5yX2ZhaWx1cmVzOw0KPj4gKyNkZWZpbmUgZmFpbChmbXQsIC4uLikgICAgICAgICAgICAg ICAgICAgICAgICAgIFwNCj4+ICsoeyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBcDQo+PiArICAgIG5yX2ZhaWx1cmVzKys7ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXA0KPj4gKyAgICAodm9pZClwcmludGYoZm10LCAjI19fVkFfQVJHU19fKTsgICAg ICAgICAgIFwNCj4+ICt9KQ0KPj4gKw0KPj4gK3N0YXRpYyB4Y19pbnRlcmZhY2UgKnhjaDsNCj4+ ICtzdGF0aWMgdWludDMyX3QgZG9taWQ7DQo+PiArDQo+PiArc3RhdGljIHN0cnVjdCB4ZW5fZG9t Y3RsX2NyZWF0ZWRvbWFpbiBjcmVhdGUgPSB7DQo+PiArICAgIC5mbGFncyA9IFhFTl9ET01DVExf Q0RGX2h2bSB8IFhFTl9ET01DVExfQ0RGX2hhcCwNCj4gSSB1bmRlcnN0YW5kIHRoYXQgaXQgaXMg YWNjZXB0ZWQgdGhhdCB0aGlzIHRlc3Qgd2lsbCB0aHVzIGZhaWwgd2hlbiBydW4NCj4gb24gSEFQ LWluY2FwYWJsZSBoYXJkd2FyZSAoaW5jbHVkaW5nIHdoZW4gcnVuIHdpdGggWGVuIGl0c2VsZiBy dW5uaW5nIG9uDQo+IHRvcCBvZiBhbm90aGVyIGh5cGVydmlzb3Igbm90IHN1cmZhY2luZyBIQVAg Y2FwYWJpbGl0aWVzKT8gT2gsIEkgbm90aWNlDQo+IHlvdSdyZSBhY3R1YWxseSB0cmFuc2xhdGlu ZyBFSU5WQUwgYW5kIEVPUE5PVFNVUFAgZmFpbHVyZXMgaW50byAic2tpcCIuDQo+IFRoYXQnbGwg cHJvYmFibHkgZG8sIGFsYmVpdCBwZXJzb25hbGx5IEkgY29uc2lkZXIgc2tpcHBpbmcgd2hlbiBF SU5WQUwNCj4gKHdoaWNoIHdlIHVzZSBhbGwgb3ZlciB0aGUgcGxhY2UpIGFzIGEgb3Zlcmx5IHJl bGF4ZWQuDQoNCkNoZWNraW5nIGNhcGFiaWxpdGllcyBuZWVkcyB0byBoYXBwZW4gYW55d2F5IHRv IGdldCBQViBhbmQgSFZNIFNoYWRvdw0Kc3VwcG9ydCB3b3JraW5nLg0KDQpCdXQgdGhpcyB3aWxs IGRvIGZvciBub3cuDQoNCj4+ICtzdGF0aWMgdm9pZCBydW5fdGVzdHModm9pZCkNCj4+ICt7DQo+ PiArICAgIHhlbl9wZm5fdCBwaHlzbWFwW10gPSB7IDAgfTsNCj4gSSBoYXZlIHRvIGFkbWl0IHRo YXQgSSdtIHVuY2VydGFpbiB3aGV0aGVyIEFybSAob3Igb3RoZXIgYXJjaGl0ZWN0dXJlcw0KPiB0 aGF0IFhlbiBpcyBiZWluZyBwbGFubmVkIHRvIGJlIHBvcnRlZCB0bykgaGF2ZSBjb25zdHJhaW50 cyB3aGljaCBtYXkNCj4gY2F1c2UgcG9wdWxhdGluZyBvZiBHRk4gMCB0byBmYWlsLg0KDQpNZWNo YW5pY2FsbHksIG5vLsKgIHg4NiBQViBpcyBhbiBlbnRpcmVseSBhcmJpdHJhcnkgbWFwcGluZywg d2hpbGUgYWxsDQpIVk0gbW9kZXMgKHg4NiBhbmQgQVJNKSBhcmUganVzdCBmaWxsaW5nIGluIGEg Z3Vlc3QgcGh5c2ljYWwgLT4gInNvbWUNClJBTSIgbWFwcGluZyBpbiBhIHBhZ2V0YWJsZSBzdHJ1 Y3R1cmUuDQoNCkxvZ2ljYWxseSwgSSBob3BlIHRoYXQgQ0RGX2RpcmVjdG1hcCBvbiBBUk0gY2hl Y2tzIGZvciBhbiBhbGlhcyB0byBhDQpyZWFsIFJBTSBibG9jaywgYnV0IHRoaXMgY2FwYWJpbGl0 eSBpc24ndCBldmVuIGV4cG9zZWQgdG8gdGhlIHRvb2xzdGFjay4NCg0KDQpBbmQgbm93IEkndmUg bG9va2VkIGF0IHRoaXMsIGV3d3d3LsKgIFdlJ3ZlIGdvdDoNCg0KZC0+b3B0aW9ucyB3aGljaCBo b2xkcyBjb25maWctPmZsYWdzLCBET01DVExfQ0RGXyoNCmQtPmNkZiB3aGljaCBob2xkcyB0aGUg bG9jYWwgJ2ZsYWdzJyBwYXJhbWV0ZXIsIENGRF8qDQpkLT5pc19wcml2aWxlZ2VkIHdoaWNoIGhv bGRzICdmbGFncyAmIENERl9wcml2aWxlZ2VkJyBhbmQgd2FzIG5ldmVyDQpjbGVhbmVkIHVwIHdo ZW4gZC0+Y2RmIHdhcyBpbnRyb2R1Y2VkLg0KDQpUaGlzIGlzIHVubmVjZXNzYXJpbHkgY29uZnVz aW5nIHRvIGZvbGxvdy7CoCBZZXQgbW9yZSBmb3IgdGhlIGNsZWFudXAgcGlsZS4NCg0KPj4gKyAg ICB1aW50NjRfdCBzaXplX2J5dGVzLCBvbGRfc2l6ZV9ieXRlczsNCj4+ICsgICAgaW50IHJjOw0K Pj4gKw0KPj4gKyAgICBwcmludGYoIlRlc3QgZGVmYXVsdCBtZW1wb29sIHNpemVcbiIpOw0KPj4g Kw0KPj4gKyAgICByYyA9IHhjX2dldF9wYWdpbmdfbWVtcG9vbF9zaXplKHhjaCwgZG9taWQsICZz aXplX2J5dGVzKTsNCj4+ICsgICAgaWYgKCByYyApDQo+PiArICAgICAgICByZXR1cm4gZmFpbCgi ICBGYWlsOiBnZXQgbWVtcG9vbCBzaXplOiAlZCAtICVzXG4iLA0KPj4gKyAgICAgICAgICAgICAg ICAgICAgZXJybm8sIHN0cmVycm9yKGVycm5vKSk7DQo+PiArDQo+PiArICAgIHByaW50ZigibWVt cG9vbCBzaXplICUiUFJJdTY0IiBieXRlcyAoJSJQUkl1NjQia0IsICUiUFJJdTY0Ik1CKVxuIiwN Cj4+ICsgICAgICAgICAgIHNpemVfYnl0ZXMsIHNpemVfYnl0ZXMgPj4gMTAsIHNpemVfYnl0ZXMg Pj4gMjApOw0KPj4gKw0KPj4gKw0KPj4gKyAgICAvKg0KPj4gKyAgICAgKiBDaGVjayB0aGF0IHRo ZSBkb21haW4gaGFzIHRoZSBleHBlY3RlZCBkZWZhdWx0IGFsbG9jYXRpb24gc2l6ZS4gIFRoaXMN Cj4+ICsgICAgICogd2lsbCBmYWlsIGlmIHRoZSBsb2dpYyBpbiBYZW4gaXMgYWx0ZXJlZCB3aXRo b3V0IGFuIGVxdWl2ZWxlbnQNCj4gTml0OiBlcXVpdmFsZW50DQoNCkZpeGVkLg0KDQo+DQo+PiAr ICAgICAqIGFkanVzdG1lbnQgaGVyZS4NCj4+ICsgICAgICovDQo+PiArICAgIGlmICggc2l6ZV9i eXRlcyAhPSBkZWZhdWx0X21lbXBvb2xfc2l6ZV9ieXRlcyApDQo+PiArICAgICAgICByZXR1cm4g ZmFpbCgiICBGYWlsOiBzaXplICUiUFJJdTY0IiAhPSBleHBlY3RlZCBzaXplICUiUFJJdTY0Ilxu IiwNCj4+ICsgICAgICAgICAgICAgICAgICAgIHNpemVfYnl0ZXMsIGRlZmF1bHRfbWVtcG9vbF9z aXplX2J5dGVzKTsNCj4+ICsNCj4+ICsNCj4+ICsgICAgcHJpbnRmKCJUZXN0IHRoYXQgYWxsb2Nh dGUgZG9lc24ndCBhbHRlciBwb29sIHNpemVcbiIpOw0KPj4gKw0KPj4gKyAgICAvKg0KPj4gKyAg ICAgKiBQb3B1bGF0ZSB0aGUgZG9tYWluIHdpdGggc29tZSBSQU0uICBUaGlzIHdpbGwgY2F1c2Ug bW9yZSBvZiB0aGUgbWVtcG9vbA0KPj4gKyAgICAgKiB0byBiZSB1c2VkLg0KPj4gKyAgICAgKi8N Cj4+ICsgICAgb2xkX3NpemVfYnl0ZXMgPSBzaXplX2J5dGVzOw0KPj4gKw0KPj4gKyAgICByYyA9 IHhjX2RvbWFpbl9zZXRtYXhtZW0oeGNoLCBkb21pZCwgLTEpOw0KPj4gKyAgICBpZiAoIHJjICkN Cj4+ICsgICAgICAgIHJldHVybiBmYWlsKCIgIEZhaWw6IHNldG1heG1lbTogOiAlZCAtICVzXG4i LA0KPj4gKyAgICAgICAgICAgICAgICAgICAgZXJybm8sIHN0cmVycm9yKGVycm5vKSk7DQo+PiAr DQo+PiArICAgIHJjID0geGNfZG9tYWluX3BvcHVsYXRlX3BoeXNtYXBfZXhhY3QoeGNoLCBkb21p ZCwgMSwgMCwgMCwgcGh5c21hcCk7DQo+PiArICAgIGlmICggcmMgKQ0KPj4gKyAgICAgICAgcmV0 dXJuIGZhaWwoIiAgRmFpbDogcG9wdWxhdGUgcGh5c21hcDogJWQgLSAlc1xuIiwNCj4+ICsgICAg ICAgICAgICAgICAgICAgIGVycm5vLCBzdHJlcnJvcihlcnJubykpOw0KPj4gKw0KPj4gKyAgICAv Kg0KPj4gKyAgICAgKiBSZS1nZXQgdGhlIHAybSBzaXplLiAgU2hvdWxkIG5vdCBoYXZlIGNoYW5n ZWQgYXMgYSBjb25zZXF1ZW5jZSBvZg0KPj4gKyAgICAgKiBwb3B1bGF0ZSBwaHlzbWFwLg0KPj4g KyAgICAgKi8NCj4+ICsgICAgcmMgPSB4Y19nZXRfcGFnaW5nX21lbXBvb2xfc2l6ZSh4Y2gsIGRv bWlkLCAmc2l6ZV9ieXRlcyk7DQo+PiArICAgIGlmICggcmMgKQ0KPj4gKyAgICAgICAgcmV0dXJu IGZhaWwoIiAgRmFpbDogZ2V0IG1lbXBvb2wgc2l6ZTogJWQgLSAlc1xuIiwNCj4+ICsgICAgICAg ICAgICAgICAgICAgIGVycm5vLCBzdHJlcnJvcihlcnJubykpOw0KPj4gKw0KPj4gKyAgICBpZiAo IG9sZF9zaXplX2J5dGVzICE9IHNpemVfYnl0ZXMgKQ0KPj4gKyAgICAgICAgcmV0dXJuIGZhaWwo IiAgRmFpbDogbWVtcG9vbCBzaXplIGNoYW5nZWQgJSJQUkl1NjQiID0+ICUiUFJJdTY0IlxuIiwN Cj4+ICsgICAgICAgICAgICAgICAgICAgIG9sZF9zaXplX2J5dGVzLCBzaXplX2J5dGVzKTsNCj4+ ICsNCj4+ICsNCj4+ICsNCj4+ICsgICAgcHJpbnRmKCJUZXN0IGJhZCBzZXQgc2l6ZVxuIik7DQo+ PiArDQo+PiArICAgIC8qDQo+PiArICAgICAqIENoZWNrIHRoYXQgc2V0dGluZyBhIG5vbi1wYWdl IHNpemUgcmVzdWx0cyBpbiBmYWlsdXJlLg0KPj4gKyAgICAgKi8NCj4+ICsgICAgcmMgPSB4Y19z ZXRfcGFnaW5nX21lbXBvb2xfc2l6ZSh4Y2gsIGRvbWlkLCBzaXplX2J5dGVzICsgMSk7DQo+PiAr ICAgIGlmICggcmMgIT0gLTEgfHwgZXJybm8gIT0gRUlOVkFMICkNCj4+ICsgICAgICAgIHJldHVy biBmYWlsKCIgIEZhaWw6IEJhZCBzZXQgc2l6ZTogZXhwZWN0ZWQgLTEvRUlOVkFMLCBnb3QgJWQv JWQgLSAlc1xuIiwNCj4+ICsgICAgICAgICAgICAgICAgICAgIHJjLCBlcnJubywgc3RyZXJyb3Io ZXJybm8pKTsNCj4+ICsNCj4+ICsNCj4+ICsgICAgcHJpbnRmKCJUZXN0IHZlcnkgbGFyZ2Ugc2V0 IHNpemVcbiIpOw0KPiBNYXliZSBkcm9wICJ2ZXJ5IiwgYXMgNjRNIGlzbid0IGFsbCB0aGF0IG11 Y2ggKGFuZCB3b3VsZCwgaW4gcGFydGljdWxhciwNCj4gbm90IGV4cG9zZSBhbnkgMzItYml0IHRy dW5jYXRpb24gaXNzdWVzKT8NCg0KSG1tIHllYWguwqAgVGhhdCB3YXMgcmF0aGVyIHN0YWxlLg0K DQpJJ3ZlIHN3aXRjaGVkIHRvICJUZXN0IHNldCBjb250aW51YXRpb25cbiIgc2VlaW5nIGFzIHRo YXQncyB0aGUgcHVycG9zZQ0Kb2YgdGhlIHRlc3QuwqAgNjRNIGlzIGFuIGludGVybmFsIGRldGFp bCB3aGljaCBvdWdodCB0byBiZSBzbWFsbCBlbm91Z2gNCnRvIHdvcmsgcmVsaWFibHkgZXZlcnl3 aGVyZSwgYnV0IGxhcmdlIGVub3VnaCB0byBjYXVzZSBhIGNvbnRpbnVhdGlvbi4NCg0KfkFuZHJl dw0K From xen-devel-bounces@lists.xenproject.org Thu Nov 17 16:34:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 16:34:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445304.700443 (Exim 4.92) (envelope-from ) id 1ovhqd-0006Cr-7D; Thu, 17 Nov 2022 16:34:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445304.700443; Thu, 17 Nov 2022 16:34:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovhqd-0006Ck-4S; Thu, 17 Nov 2022 16:34:43 +0000 Received: by outflank-mailman (input) for mailman id 445304; Thu, 17 Nov 2022 16:34:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovhqc-0006Ce-3e for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 16:34:42 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on061f.outbound.protection.outlook.com [2a01:111:f400:fe06::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bb719363-6695-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 17:34:40 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9574.eurprd04.prod.outlook.com (2603:10a6:20b:4fc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 16:34:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 16:34:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb719363-6695-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A6kLP7lS2IuAHEP7WHtXt1G+awjYY/ct1xcCQIiIVAtvgmeVKkyjBm3D6toZKq8HHjaLgDPZziiOT9xZxFchjtjtra+ZpKhWWg1TFLVDoFkIyK2hIG+SZtY8nk2ZyC5NdHqxcGlA1xhr1vpK/+ZLmYZGlidKiqz+BjOfGxLwNNvZTA/ZA5ZI5/J0H5xQFdGmTygBQswEKyMr5DcWUhPuiDmx4hClbohmUSOp7tBGYAT5UdHEU7TIRHL5SuH4DZSiX+mDIyxXWQd/kagI8OmZKb9P50UMSvoYMafW1YxQS21C+1JvTI5PMG5ECK195aYTxk0UF+G9ZjNNrdLMryrOiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UKBTGsj+MVzS9O6jND3KpysaYaMH3oCjLdcjdJhFBy8=; b=eebEEIIBKvjsOlDJCqi2kBsIjNcNtQWhZPooGnYbTnu8sCGUv9ydd9SgGMNilmKLwIdkpRzzfC25IvKUACO85QSs9uL6RCrb2CfGO9NLR0Cle4/KF+iuBezCkWzfJEIR+Dnrcf1cIPhpvxFKDOmTQ07yM69879mYxmLhSNGqWbA0UYS7safvE/Dz4wNolj7TdNWdrzTOtsT2MOthCg8t0U+ynX//O2WFsoelI/eDp/7hTbdJpoA61EjBSh0txd3RcUaKQ4o5tThY438wL3+RwRIJJLySJzcR1tKSg3JsnQe48QGXvV8dohVEr7kAne/aYOLHHYY/al9gYawpkqTX4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UKBTGsj+MVzS9O6jND3KpysaYaMH3oCjLdcjdJhFBy8=; b=hBuijunpyvusXKO7q+c4ED6EJI8cdpNkvSBqg72CqFduIO1CfwKM4qI37RA8qS8RYgLuKD5bld3Ipi+EepOwU5zTCb0l9P3UCPOsECeMCsTDe5mHyuaNb3oXGF4KsxxcrPo8lV4Bp0MuRUU9DcTkJmUNm5SYtIxvN7vBEmMpHdpcw4xI1wzvL3r5bzXY/xZ8kxFNGtJ7Q05fD44BOh4N2rDCoRdoTBHa3j625MsFkUPiNcqthJsvc8q/a0NF8MJgzSvnZhGMWzZi4J5dbbm7N5HGfSs5RVAyX/tuT9iwQs237MJm7LOQrbajOyBkZgPrnc1NcKbUyZUv0RP6g+x3BA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <15138618-5cb0-8304-a56b-cb787e187772@suse.com> Date: Thu, 17 Nov 2022 17:34:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/2] x86/msi: Allow writes to registers on the same page as MSI-X table Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20221114192100.1539267-1-marmarek@invisiblethingslab.com> <20221114192100.1539267-2-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20221114192100.1539267-2-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0094.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9574:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a96d224-5455-4704-1b30-08dac8b99e51 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lDpajbHNo+yDi3dbtEedhTN9azhHIznvEoPZTEgVqUICQ1SMb8QXNVmUZ3uXQqFMzRifNjwNF1NGZTSfKtfzowbAkkglvkJInNZMvQKiVM+MNYzPZ7jln4Rl6z1DE91o2ahMkYDo2HuKFIqmNpGk1Sm4wXwypjY9J0Ia9V2z21lMSLBfWacQLs+tpD8yYI15qGlMor1+bz/wIylKPmFk47+z/mq1SiOMtc73M4gKHXSLQBujIDwNduFHGnpuZdEiLWK+TEGzzTYIPWJ2w4F6xWVHUttdjqVQh8hLIoAvNxCYfnusGgoaaOS7kzqj83AZdLDkDoHxWPjl3DcNzsQYftor51Ark5okFMmGD2rQ2feOSOEcq6jdJBzhc4mIETe1Czn+SW7d7LMFRolZMKIpVKeaznfbzSv++uYeEm3muSpqVAlprYeRvH/NoLevFJjjhPjhZhy/w1q6r8eZmQ0gzdBb+CTGrk1QmlOn/QJ1272tfV3JhLwoYDHMRdVJetg39Fq3A/al7Bc4z+irJx/HYkdZ0mhwTz09C5QYrfa1wa3ZZlkROXEkf6RsOz85h+CO7jhm845AdYlYHC/odcR3qVuNOTLdihIZefTxhdtl1l+yNn0PBTFG0g03tVNkNRu2R47jqBgNrV/+7OplVCf1lwkvF/kJjuIOkzZyVVL4/gHA7uM8nr1AfeVjKLgC5vpSABOKm7s6VYL6P3pkIaLtuGzqUfLxhfBca6Xar53XfeGfpZFNEPd26NsdRRICL4Ye X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(366004)(346002)(136003)(39860400002)(451199015)(478600001)(66899015)(6506007)(31686004)(54906003)(6916009)(6486002)(36756003)(186003)(2616005)(41300700001)(8676002)(316002)(6512007)(53546011)(4326008)(66556008)(66476007)(66946007)(5660300002)(26005)(8936002)(86362001)(83380400001)(2906002)(66574015)(38100700002)(31696002)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzhpaVJjYmFnMkpia2RIZmFZMGdaZWRHTjdQVGlKV3lGWks0V0hVc0ZTam04?= =?utf-8?B?ajNTVlJRRC9YbkVTTXJVNVhMRStOeUtBdVZ1MTVOdU82NXNFZmR3NTE0SVRE?= =?utf-8?B?cnFEdDJpK2xzMnR0QVhxV1NTazNsTTJuV3FyYlJIZjNEdENhT052QUo0aUh5?= =?utf-8?B?TTg2UUZub3VhUHJzZTUwSmQ1cUpXZnJrc0pnMytTbzhybWJ5WW9heXhONjJW?= =?utf-8?B?UmZnM0M2TnQ0eGE0WDd6WUpGWUFINGlYcW9xTTVveUhielhPcnpqYitQQXhi?= =?utf-8?B?S1JFdE9rekFnbXZ6cXI1MWw2UGQvT0pFbzMrYWwvcWpWb1F3WXZkQ2l1amYr?= =?utf-8?B?QUVrVk0xZGdIalY5bTBDNGd6MlBkVVBYQmdLTlJ6WG1VNnVzTzhZaTNzK0Fq?= =?utf-8?B?QzRpTXQySEhUMXNyc3VuanFiRU40TFhlRWI2T1lEZU4wMEJtWGV5ZS96V2xO?= =?utf-8?B?YU8yVGFCc3FKbTRmZHlmODBLZkhUK0M0cGVMWmptbDFiclI1R09OSUtPaFUx?= =?utf-8?B?V3lVTndHeVQrU2pRSmdic0VzNWVQVTRHZ25Ia2tXZXhvT29IdFh1dnNPOXFM?= =?utf-8?B?OEVWZms3Z2lUSGo2Kzd5QUtLODVCNlI0ajhYb0Z1RHNSQnZSVzNmc3MvU0lV?= =?utf-8?B?KzFHdEtTcDd4M0dMMzIweVFjb25yNzhoNUx5bS93dXI4UHN1TjF0eG10UUNH?= =?utf-8?B?OW03UE5vYjVsNXRXNE14MDZOZFJuMVlFUWlMQnBXSVVRZzlkaG5yNUVwK3Q5?= =?utf-8?B?OXVKakNmVFVGZ1J0VmtIY3NkVk4zbllMamFMdzYra05rZ2QwL3JSU0pmQzdE?= =?utf-8?B?TnhpZmJZa1NwUitya1VjNkg1NytBWkRrZjZhZUR6Q1JOcEZOUEQxbzRrSFhl?= =?utf-8?B?RWt3djZQbllXNnRnY2UxYlZBZlB3MFEwdWllamFGbDV4R01jdFRKRWN1TWdJ?= =?utf-8?B?YkNlRHh6VW5jZW96cjlFRGs2MU1CaFJ4aFY0V3NJbDdhNzN4bnJwT1BHbDF4?= =?utf-8?B?L3hOZDgzcHgxQWMzT1NmTzRNTk5kbk9OY0x6VFhZRVRRTXZHdUpqVGtWQXhs?= =?utf-8?B?WmVVQVZySGJEY0pIQWw3L1ZzTzl5UlZxd1Y5Y3VIR1lrTnRxVlBLMHBaR0Zk?= =?utf-8?B?TXprNExxaVY1MkxKa0ZxRFhRenJpUUtVUFZmZFBQdVU4WUNvZHFrV1gzV08v?= =?utf-8?B?czJrZUZGdE1hT05vazRCcHhjZVNXTU5UYXJmNGVVaUM1QnlYS0g0RG9IRFd3?= =?utf-8?B?eW40YnV4QVBvdXdaQjlDQVNhZ1NNYkx2T1ZmbkN1cEd3SUhqRHpqbmFvaDNF?= =?utf-8?B?dVJwSXpMaVZFZW1aNC9RaW1tYVlxWENOaHVHVCt1eVFPemtVTEFpTG1tamg2?= =?utf-8?B?aEZGSzFSb1JvV0J6QzdyVFlrYTRvNE1pVHF6TG1pMVdZVWFJMG1Xa3V3TWV4?= =?utf-8?B?YkhhcFVJdlozV2RnQm1lQXpYcUJEUUx1bERPbUtEcFJ4RmgxVzVqZjRVbUR1?= =?utf-8?B?ZkhMcjkwUHdIeStCMU03REFCMUlkT1lGYTBDQndTdXlKcWN1THluWUxERSsw?= =?utf-8?B?TDdRcXo5WEpaT3JlU2FHUU8xNXJTTG5SZ3Z2azg4YmZCV01CMGdsaHl1SWlt?= =?utf-8?B?T3ZmVUZReUh5UlJibjJwL2Y0ckdHaEkyYVkwcUIxT1pXeTVicnN0b3B0TCtF?= =?utf-8?B?NFhzWG81YnZiMExXRisxVENPNG80NTIxVDNyV3Y4ZkszMndQRFhOU0wvRSt0?= =?utf-8?B?eVc0bURRd0N4RUJEZGtINEhiYnNhSDZJMlZIWk1Hd0xUOGZ2dzVDZzdEdkRC?= =?utf-8?B?R3pRaE9BME41L3ZWUTVCZVJSS2hLRzFxS0dWMWZIYmJ4ZnNPSjJMekErbTdp?= =?utf-8?B?bmNLd0VYNGRIUE5yQjhhU1hmN295Ym5XazA5cmJldEN6QnJ5NW1UQU45Z0Zp?= =?utf-8?B?MzBCeWM4TDJMMEQzbUhMMEVBTnRsa3JITWRKbnk3VCt2clRjcTNaREIyNnE4?= =?utf-8?B?NWhOM2FGS3ZSajlQcCtrYzB0ZEx1V2N1V3hjaG5IakJwbUJJeG4yNGYyOHMy?= =?utf-8?B?YURJNk9MWUNLSURLT2tJV3YwSC9NejFSRVRnMEtMSVA3MTZGU25EbFpTMnJo?= =?utf-8?Q?AWGwHFbkQes9Pfl9/gM51vL1L?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a96d224-5455-4704-1b30-08dac8b99e51 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 16:34:37.7904 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oyl8k47wyQcx2eYCRYyS5qGDvRhmAa+Pvk/ZKJlnSfQW7XbFB91G0O1JH3lgn8+RY+yiCrjgyw3EBUd1XohCbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9574 On 14.11.2022 20:21, Marek Marczykowski-Górecki wrote: > Some devices (notably Intel Wifi 6 AX210 card) keep auxiliary registers > on the same page as MSI-X table. Device model (especially one in > stubdomain) cannot really handle those, as direct writes to that page is > refused (page is on mmio_ro_ranges list). Instead, add internal ioreq > server that handle those writes. > > This may be also used to read Pending Bit Array, if it lives on the same "may" sounds as if this would be future work, yet ... > page, making QEMU not needing /dev/mem access at all (especially helpful > with lockdown enabled in dom0). If PBA lives on another page, it can be > (and will be) mapped to the guest directly. > If PBA lives on the same page, forbid writes. ... here you say you actually handle the case (because otherwise you wouldn't need to distinguish writes from reads). It is only ... > Technically, writes outside > of PBA could be allowed, but at this moment the precise location of PBA > isn't saved. ... this part which right now you don't handle. I have to admit that I'm not convinced we should take such a partial implementation, especially if there's nothing recorded in the log (making it harder to tell whether something not working is because of this implementation restriction or some other issue). > --- a/xen/arch/x86/hvm/vmsi.c > +++ b/xen/arch/x86/hvm/vmsi.c > @@ -428,6 +428,133 @@ static const struct hvm_io_ops msixtbl_mmio_ops = { > .write = _msixtbl_write, > }; > > +static void __iomem *msixtbl_page_handler_get_hwaddr( > + const struct vcpu *v, > + uint64_t address, > + bool write) These want to be indented just like ... > +{ > + struct domain *d = v->domain; > + struct pci_dev *pdev = NULL; > + struct msixtbl_entry *entry; > + void __iomem *ret = NULL; > + uint64_t table_end_addr; ... function scope local variables. Also: Pointer-to-const for the first three local variables? And maybe omit "ret", which is effectively used just once (as you could use "return" at the point where you assign to it). Also you don't further use v afaics, so maybe have the callers pass in const struct domain * right away? > + rcu_read_lock(&msixtbl_rcu_lock); > + /* > + * Check if it's on the same page as the end of the MSI-X table, but > + * outside of the table itself. > + */ > + list_for_each_entry( entry, &d->arch.hvm.msixtbl_list, list ) > + if ( PFN_DOWN(address) == PFN_DOWN(entry->gtable + entry->table_len) && > + address >= entry->gtable + entry->table_len ) > + { > + pdev = entry->pdev; > + break; > + } > + rcu_read_unlock(&msixtbl_rcu_lock); > + > + if ( !pdev ) > + return NULL; > + > + ASSERT( pdev->msix ); Style: ASSERT is not a (pseudo-)keyword and hence should not have blanks immediately inside the parentheses. (More instances further down.) > + table_end_addr = (pdev->msix->table.first << PAGE_SHIFT) + > + pdev->msix->nr_entries * PCI_MSIX_ENTRY_SIZE; > + ASSERT( PFN_DOWN(table_end_addr) == pdev->msix->table.last ); What are you trying to catch here? I ask because the local variable exists just for this checking afaics. > + /* If PBA lives on the same page too, forbid writes. */ > + if ( write && pdev->msix->table.last == pdev->msix->pba.first ) > + return NULL; > + > + if ( pdev->msix->last_table_page ) > + ret = pdev->msix->last_table_page + (address & (PAGE_SIZE - 1)); > + else > + gdprintk(XENLOG_WARNING, > + "MSI-X last_table_page not initialized for %04x:%02x:%02x.%u\n", > + pdev->seg, > + pdev->bus, > + PCI_SLOT(pdev->devfn), > + PCI_FUNC(pdev->devfn)); > + Please use %pp. > +static bool cf_check msixtbl_page_accept( > + const struct hvm_io_handler *handler, const ioreq_t *r) > +{ > + unsigned long addr = r->addr; Any particular reason for having this local variable, which is used ... > + ASSERT( r->type == IOREQ_TYPE_COPY ); > + > + return msixtbl_page_handler_get_hwaddr( > + current, addr, r->dir == IOREQ_WRITE); > +} ... exactly once? > +static int cf_check msixtbl_page_read( > + const struct hvm_io_handler *handler, > + uint64_t address, uint32_t len, uint64_t *pval) > +{ > + void __iomem *hwaddr = msixtbl_page_handler_get_hwaddr( > + current, address, false); > + > + if ( !hwaddr ) > + return X86EMUL_UNHANDLEABLE; > + > + switch ( len ) { Style: Brace on its own line please and ... > + case 1: > + *pval = readb(hwaddr); > + break; > + case 2: > + *pval = readw(hwaddr); > + break; > + case 4: > + *pval = readl(hwaddr); > + break; > + case 8: > + *pval = readq(hwaddr); > + break; > + default: > + return X86EMUL_UNHANDLEABLE; ... the body un-indented by a level. As to operation I'm unconvinced that carrying out misaligned accesses here is generally safe. If we find devices really needing such, we may need to think about ways to deal with them without putting at risk everyone else. At the very least you need to make sure you don't access beyond the end of the page. > --- a/xen/arch/x86/msi.c > +++ b/xen/arch/x86/msi.c > @@ -961,6 +961,21 @@ static int msix_capability_init(struct pci_dev *dev, > domain_crash(d); > /* XXX How to deal with existing mappings? */ > } > + > + /* > + * If the MSI-X table doesn't span full page(s), map the last page for > + * passthrough accesses. > + */ > + if ( (msix->nr_entries * PCI_MSIX_ENTRY_SIZE) & (PAGE_SIZE - 1) ) > + { > + uint64_t entry_paddr = table_paddr + msix->nr_entries * PCI_MSIX_ENTRY_SIZE; > + int idx = msix_get_fixmap(msix, table_paddr, entry_paddr); > + > + if ( idx >= 0 ) > + msix->last_table_page = fix_to_virt(idx); > + else > + gprintk(XENLOG_ERR, "Failed to map last MSI-X table page: %d\n", idx); > + } Could we avoid the extra work if there's only less than one page's worth of entries for a device? But then again maybe not worth any extra code, as the same mapping will be re-used anyway due to the refcounting that's being used. Makes me think of another aspect though: Don't we also need to handle stuff living on the same page as the start of the table, if that doesn't start at a page boundary? > @@ -1090,6 +1105,12 @@ static void _pci_cleanup_msix(struct arch_msix *msix) > WARN(); > msix->table.first = 0; > msix->table.last = 0; > + if ( msix->last_table_page ) > + { > + msix_put_fixmap(msix, > + virt_to_fix((unsigned long)msix->last_table_page)); > + msix->last_table_page = 0; To set a pointer please use NULL. Overall it looks like you're dealing with the issue for HVM only. You will want to express this in the title, perhaps by using x86/hvm: as the prefix. But then the question of course is whether this couldn't be dealt with in/from mmio_ro_emulated_write(), which handles both HVM and PV. Which in turn raises the question: Do you need to handle reads in the new code in the first place? Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 17 17:30:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 17:30:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445309.700455 (Exim 4.92) (envelope-from ) id 1oviht-0003ik-Bg; Thu, 17 Nov 2022 17:29:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445309.700455; Thu, 17 Nov 2022 17:29:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oviht-0003id-8y; Thu, 17 Nov 2022 17:29:45 +0000 Received: by outflank-mailman (input) for mailman id 445309; Thu, 17 Nov 2022 17:29:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovihr-0003iX-Uc for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 17:29:44 +0000 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [2a00:1450:4864:20::52f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b8fa621-669d-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 18:29:42 +0100 (CET) Received: by mail-ed1-x52f.google.com with SMTP id s5so3531312edc.12 for ; Thu, 17 Nov 2022 09:29:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b8fa621-669d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TB5FFKRpQ7rnDeXlHhmH631sUw/6iJ8VNXXhcQXAT5M=; b=g8wW3qSpWDpCyE6eXNfSLmHqp4ZvYuiGEl4RFpc5fppbP/Azb2L/g126PdCr2yDVn6 F5Z6/qxn7Jmy6csPxI7pT2DRmjvSpIGpftKe21UyXdsOVtdqhaun0RzEDjrtQ1AgafaD GHsG/mPHxjY5cGUuBi/67OeV5iB2FKyQ7aDMdYA7fUe3YXEGMBs+FXizhFB1pROMN1hQ igbkoh6mfcbwqajkQIQH0IuqCznyek9ul+dn3KyBcO+dSfLblTZDiftJjHL1nhHROals 0flgjYRWE5xGIz1Gd958MyTEk+fEXOETruMzN81HapkNI+o7C0cBT+1ZcBegJabDuhn3 KtzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TB5FFKRpQ7rnDeXlHhmH631sUw/6iJ8VNXXhcQXAT5M=; b=c2CenqQTQ0ix1XV90VPh2xQ/DD0WxDWlObqK5oivHL1Zvu5M4PQqK0LfEy9+lrUIuc Fp6JRldnNHkjInyPszFlDZ+ccDDxv8F6kgOWsprcQCVrHE/ySRIU+7/LVvJJKeMh6gQJ RBVJk2rd8r5ikhJa+7alBz3tMdVuQHh2FlBBohVJq/UhNYYMVomEm8XLJ4bY9BfaZFfE 6VIFIUDFV1pEqPUATHmx1ItZQWb4lCgHWdNrtH3uUifrpCMWHyHMnEee9D4fQ0JFauSe 5ySsZ31GuIj0EErN1TtHhlU/omOVePuvS42EaKzxRRqVsE2W2wHjMYRgUaeoxaYHWmle t+Gw== X-Gm-Message-State: ANoB5plECKsh69Sg1txv9x4P8fu8vAH4Sohw8ULe0qLvHwf0QwN6B00J jLanORD6DfrlkBuW0U/P+cr3kpoLnV8e/6ti+0U= X-Google-Smtp-Source: AA0mqf6KaqVpH+ImDPySUJ23DCoYBB0J1GBgFFOvIG7NYpCP4vdBtBO1aWsAJh8lAZRX+SqcYKI1CFpCifxU1WRsb9w= X-Received: by 2002:a05:6402:541a:b0:463:be84:5283 with SMTP id ev26-20020a056402541a00b00463be845283mr3037015edb.7.1668706181480; Thu, 17 Nov 2022 09:29:41 -0800 (PST) MIME-Version: 1.0 References: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> <20221114192011.1539233-2-marmarek@invisiblethingslab.com> In-Reply-To: From: Jason Andryuk Date: Thu, 17 Nov 2022 12:29:29 -0500 Message-ID: Subject: Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: Jan Beulich , qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:X86 Xen CPUs" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Nov 16, 2022 at 10:34 PM Marek Marczykowski-G=C3=B3recki wrote: > > On Wed, Nov 16, 2022 at 10:40:02PM +0100, Marek Marczykowski-G=C3=B3recki= wrote: > > On Wed, Nov 16, 2022 at 02:15:22PM -0500, Jason Andryuk wrote: > > > On Mon, Nov 14, 2022 at 2:21 PM Marek Marczykowski-G=C3=B3recki > > > wrote: > > > > > > > > The /dev/mem is used for two purposes: > > > > - reading PCI_MSIX_ENTRY_CTRL_MASKBIT > > > > - reading Pending Bit Array (PBA) > > > > > > > > The first one was originally done because when Xen did not send all > > > > vector ctrl writes to the device model, so QEMU might have outdated= old > > > > register value. This has been changed in Xen, so QEMU can now use i= ts > > > > cached value of the register instead. > > > > > > > > The Pending Bit Array (PBA) handling is for the case where it lives= on > > > > the same page as the MSI-X table itself. Xen has been extended to h= andle > > > > this case too (as well as other registers that may live on those pa= ges), > > > > so QEMU handling is not necessary anymore. > > > > > > > > Removing /dev/mem access is useful to work within stubdomain, and > > > > necessary when dom0 kernel runs in lockdown mode. > > > > > > > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > > > > > > I put the Xen, QEMU, and xen-pciback patches into OpenXT and gave a > > > little test. When pci_permissive=3D0, iwlwifi fails to load its > > > firmware. With pci_permissive=3D1, it looks like MSI-X is enabled. (= I > > > previously included your libxl allow_interrupt_control patch - that > > > seemed to get regular MSIs working prior to the MSI-X patches.) I > > > also removed the OpenXT equivalent of 0005-Disable-MSI-X-caps.patch. > > > I am testing with Linux 5.4.y, so that could be another factor. > > > > Can you confirm the allow_interrupt_control is set by libxl? Also, > > vanilla 5.4 doesn't have the allow_interrupt_control patch at all, and = you > > may have an earlier version that had "allow_msi_enable" as the sysfs > > file name. I backported allow_interrupt_control to 5.4 and that is set properly. > Ok, I found what is wrong. Enabling MSI-X is refused, because INTx isn't > disabled at this point yet. And apparently I was testing this with > permissive=3D1... > > Linux does this: > https://github.com/torvalds/linux/blob/master/drivers/pci/msi/msi.c#L611 > In short: > 1. Enable MSI-X with MASKALL=3D1 > 2. Setup MSI-X table > 3. Disable INTx > 4. Set MASKALL=3D0 > > This patch on top should fix this: > ----8<---- > diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xe= n/xen-pciback/conf_space_capability.c > index 097316a74126..f4c4381de76e 100644 > --- a/drivers/xen/xen-pciback/conf_space_capability.c > +++ b/drivers/xen/xen-pciback/conf_space_capability.c > @@ -235,7 +235,7 @@ static int msi_msix_flags_write(struct pci_dev *dev, = int offset, u16 new_value, > (new_value ^ old_value) & ~field_config->allowed_bits) > return PCIBIOS_SET_FAILED; > > - if (new_value & field_config->enable_bit) { > + if ((new_value & field_config->allowed_bits) =3D=3D field_config-= >enable_bit) { > /* don't allow enabling together with other interrupt typ= es */ > int int_type =3D xen_pcibk_get_interrupt_type(dev); > > ----8<---- FWIW, I can confirm this allows enabling MSI-X with permissive=3D0 for me. Thanks, Jason From xen-devel-bounces@lists.xenproject.org Thu Nov 17 17:32:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 17:32:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445313.700466 (Exim 4.92) (envelope-from ) id 1ovik5-0005ET-Po; Thu, 17 Nov 2022 17:32:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445313.700466; Thu, 17 Nov 2022 17:32:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovik5-0005EK-LN; Thu, 17 Nov 2022 17:32:01 +0000 Received: by outflank-mailman (input) for mailman id 445313; Thu, 17 Nov 2022 17:31:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovik3-0005EC-3Z for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 17:31:59 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b9f5e6b0-669d-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 18:31:56 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 0A4A53200AAF; Thu, 17 Nov 2022 12:31:51 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 17 Nov 2022 12:31:52 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Nov 2022 12:31:50 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9f5e6b0-669d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668706311; x= 1668792711; bh=9CXAbQhD2xKtfBYKhEglWorCMZdwciiY+cXUjSUioGQ=; b=m NzmzTMFqllmJRiaUjq8gYFFcHuYMVlbpnM9DULo45KbRjottg5PdmGPK1cKaw8ZH DUR2nz3zbto1Regnxuw9Gw5aW4RlTdUo2NFqEatkt+J8oNARRkO5AJFWFXXgME8a qcN9WyydR3MxJsAFPmFIED0QV1H7KBguzD87VITsdHo51+SyjF55nvXb4Q+v5rs5 5YJi3a+865ZxzE91Sfxirpv9N/qdepZC3qOHMO+O1ATlMKhfioF1wgQxE9omwzX4 NTJHtbSmUzLa0hasOSUS5+qtRvDJudSPDJdN6cSwMTJyiTpOkv268ai/C/Cuc7+0 T4WYm1RBTsAKRKBYzHm7g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668706311; x=1668792711; bh=9CXAbQhD2xKtfBYKhEglWorCMZdw ciiY+cXUjSUioGQ=; b=R4gKKhQ8ySctosg1i7niH9oIP9uju5a6H6x+8O5YYQYd aJue6YPpTlmHAkoJu/gd9pd2yl1Tr08pVkAgM7xQgZyw5k0e/Sbg0QiVDEiSRGRI 9uByL5XfVoRs2uiE9KaSWpWJbE88WI9S63hDYRSRTenqiyiV2UBcqsZ8Wx05qrYl 9yEo6RpIa8vuXCNGNAPN4xIf/E0sHDuhWa2YXe3VSI17vxibFIAq5D+1uVLnJFHu furXiO3MBcx9nrHkpfa5TS7T+T8v8qByO4PMD0wVmvVnDNbyeHizJcgjcZxkQFl7 +R8RC1/rkbBpoc82j+at+SD2iyCei4M6QAH7FKTttg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgeekgdellecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 17 Nov 2022 18:31:44 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/2] x86/msi: Allow writes to registers on the same page as MSI-X table Message-ID: References: <20221114192100.1539267-1-marmarek@invisiblethingslab.com> <20221114192100.1539267-2-marmarek@invisiblethingslab.com> <15138618-5cb0-8304-a56b-cb787e187772@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DHyxoT84A3Hd42vl" Content-Disposition: inline In-Reply-To: <15138618-5cb0-8304-a56b-cb787e187772@suse.com> --DHyxoT84A3Hd42vl Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 17 Nov 2022 18:31:44 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/2] x86/msi: Allow writes to registers on the same page as MSI-X table On Thu, Nov 17, 2022 at 05:34:36PM +0100, Jan Beulich wrote: > On 14.11.2022 20:21, Marek Marczykowski-G=C3=B3recki wrote: > > Some devices (notably Intel Wifi 6 AX210 card) keep auxiliary registers > > on the same page as MSI-X table. Device model (especially one in > > stubdomain) cannot really handle those, as direct writes to that page is > > refused (page is on mmio_ro_ranges list). Instead, add internal ioreq > > server that handle those writes. > >=20 > > This may be also used to read Pending Bit Array, if it lives on the same >=20 > "may" sounds as if this would be future work, yet ... I was meaning it applies only if it shares the page, but indeed it should be "will". > > page, making QEMU not needing /dev/mem access at all (especially helpful > > with lockdown enabled in dom0). If PBA lives on another page, it can be > > (and will be) mapped to the guest directly. > > If PBA lives on the same page, forbid writes. >=20 > ... here you say you actually handle the case (because otherwise you > wouldn't need to distinguish writes from reads). It is only ... >=20 > > Technically, writes outside > > of PBA could be allowed, but at this moment the precise location of PBA > > isn't saved. >=20 > ... this part which right now you don't handle. I have to admit that I'm > not convinced we should take such a partial implementation, especially > if there's nothing recorded in the log (making it harder to tell whether > something not working is because of this implementation restriction or > some other issue). For this, I need to save exact offset to PBA. I can extend the patch for that case too. > > --- a/xen/arch/x86/hvm/vmsi.c > > +++ b/xen/arch/x86/hvm/vmsi.c > > @@ -428,6 +428,133 @@ static const struct hvm_io_ops msixtbl_mmio_ops = =3D { > > .write =3D _msixtbl_write, > > }; > > =20 > > +static void __iomem *msixtbl_page_handler_get_hwaddr( > > + const struct vcpu *v, > > + uint64_t address, > > + bool write) >=20 > These want to be indented just like ... >=20 > > +{ > > + struct domain *d =3D v->domain; > > + struct pci_dev *pdev =3D NULL; > > + struct msixtbl_entry *entry; > > + void __iomem *ret =3D NULL; > > + uint64_t table_end_addr; >=20 > ... function scope local variables. >=20 > Also: Pointer-to-const for the first three local variables? And maybe > omit "ret", which is effectively used just once (as you could use > "return" at the point where you assign to it). Also you don't further > use v afaics, so maybe have the callers pass in const struct domain * > right away? Makes sense indeed. > > + rcu_read_lock(&msixtbl_rcu_lock); > > + /* > > + * Check if it's on the same page as the end of the MSI-X table, b= ut > > + * outside of the table itself. > > + */ > > + list_for_each_entry( entry, &d->arch.hvm.msixtbl_list, list ) > > + if ( PFN_DOWN(address) =3D=3D PFN_DOWN(entry->gtable + entry->= table_len) && > > + address >=3D entry->gtable + entry->table_len ) > > + { > > + pdev =3D entry->pdev; > > + break; > > + } > > + rcu_read_unlock(&msixtbl_rcu_lock); > > + > > + if ( !pdev ) > > + return NULL; > > + > > + ASSERT( pdev->msix ); >=20 > Style: ASSERT is not a (pseudo-)keyword and hence should not have > blanks immediately inside the parentheses. (More instances further > down.) Ok. > > + table_end_addr =3D (pdev->msix->table.first << PAGE_SHIFT) + > > + pdev->msix->nr_entries * PCI_MSIX_ENTRY_SIZE; > > + ASSERT( PFN_DOWN(table_end_addr) =3D=3D pdev->msix->table.last ); >=20 > What are you trying to catch here? I ask because the local variable > exists just for this checking afaics. This is a double check if pdev->msix->table.last value is correct, because I have two ways of calculating the address. Now, that I've written this sentence, I see the way table_end_addr is calculated is wrong, as it ignores table table not starting at the page boundary. I'll remove both above lines. > > + /* If PBA lives on the same page too, forbid writes. */ > > + if ( write && pdev->msix->table.last =3D=3D pdev->msix->pba.first ) > > + return NULL; > > + > > + if ( pdev->msix->last_table_page ) > > + ret =3D pdev->msix->last_table_page + (address & (PAGE_SIZE - = 1)); > > + else > > + gdprintk(XENLOG_WARNING, > > + "MSI-X last_table_page not initialized for %04x:%02x:= %02x.%u\n", > > + pdev->seg, > > + pdev->bus, > > + PCI_SLOT(pdev->devfn), > > + PCI_FUNC(pdev->devfn)); > > + >=20 > Please use %pp. Ok. > > +static bool cf_check msixtbl_page_accept( > > + const struct hvm_io_handler *handler, const ioreq_t *r) > > +{ > > + unsigned long addr =3D r->addr; >=20 > Any particular reason for having this local variable, which is used ... >=20 > > + ASSERT( r->type =3D=3D IOREQ_TYPE_COPY ); > > + > > + return msixtbl_page_handler_get_hwaddr( > > + current, addr, r->dir =3D=3D IOREQ_WRITE); > > +} >=20 > ... exactly once? Ok, will reduce. > > +static int cf_check msixtbl_page_read( > > + const struct hvm_io_handler *handler, > > + uint64_t address, uint32_t len, uint64_t *pval) > > +{ > > + void __iomem *hwaddr =3D msixtbl_page_handler_get_hwaddr( > > + current, address, false); > > + > > + if ( !hwaddr ) > > + return X86EMUL_UNHANDLEABLE; > > + > > + switch ( len ) { >=20 > Style: Brace on its own line please and ... >=20 > > + case 1: > > + *pval =3D readb(hwaddr); > > + break; > > + case 2: > > + *pval =3D readw(hwaddr); > > + break; > > + case 4: > > + *pval =3D readl(hwaddr); > > + break; > > + case 8: > > + *pval =3D readq(hwaddr); > > + break; > > + default: > > + return X86EMUL_UNHANDLEABLE; >=20 > ... the body un-indented by a level. Ok. > As to operation I'm unconvinced that carrying out misaligned accesses > here is generally safe. If we find devices really needing such, we > may need to think about ways to deal with them without putting at > risk everyone else. At the very least you need to make sure you don't > access beyond the end of the page. Right. > > --- a/xen/arch/x86/msi.c > > +++ b/xen/arch/x86/msi.c > > @@ -961,6 +961,21 @@ static int msix_capability_init(struct pci_dev *de= v, > > domain_crash(d); > > /* XXX How to deal with existing mappings? */ > > } > > + > > + /* > > + * If the MSI-X table doesn't span full page(s), map the last = page for > > + * passthrough accesses. > > + */ > > + if ( (msix->nr_entries * PCI_MSIX_ENTRY_SIZE) & (PAGE_SIZE - 1= ) ) > > + { > > + uint64_t entry_paddr =3D table_paddr + msix->nr_entries * = PCI_MSIX_ENTRY_SIZE; > > + int idx =3D msix_get_fixmap(msix, table_paddr, entry_paddr= ); > > + > > + if ( idx >=3D 0 ) > > + msix->last_table_page =3D fix_to_virt(idx); > > + else > > + gprintk(XENLOG_ERR, "Failed to map last MSI-X table pa= ge: %d\n", idx); > > + } >=20 > Could we avoid the extra work if there's only less than one page's > worth of entries for a device? But then again maybe not worth any > extra code, as the same mapping will be re-used anyway due to the > refcounting that's being used. I was considering that, but decided against exactly because of msix_get_fixmap() reusing existing mappings. > Makes me think of another aspect though: Don't we also need to > handle stuff living on the same page as the start of the table, if > that doesn't start at a page boundary? I have considered that, but decided against given every single device I tried have MSI-X table at the page boundary. But if you prefer, I can add such handling too (will require adding another variable to the arch_msix structure - to store the fixmap location). > > @@ -1090,6 +1105,12 @@ static void _pci_cleanup_msix(struct arch_msix *= msix) > > WARN(); > > msix->table.first =3D 0; > > msix->table.last =3D 0; > > + if ( msix->last_table_page ) > > + { > > + msix_put_fixmap(msix, > > + virt_to_fix((unsigned long)msix->last_tabl= e_page)); > > + msix->last_table_page =3D 0; >=20 > To set a pointer please use NULL. Ok. > Overall it looks like you're dealing with the issue for HVM only. > You will want to express this in the title, perhaps by using x86/hvm: > as the prefix. But then the question of course is whether this couldn't > be dealt with in/from mmio_ro_emulated_write(), which handles both HVM > and PV.=20 The issue is correlating BAR mapping location with guest's view. Writable BAR areas are mapped (by qemu) via xc_domain_memory_mapping(), but that fails for read-only pages (and indeed, qemu doesn't attempt to do that for the pages with the MSI-X table). Lacking that, I need to use msixtbl_entry->gtable, which is HVM-only thing. In fact there is another corner case I don't handle here: guest accessing those registers when MSI-X is disabled. In that case, there is no related msixtbl_entry, so I can't correlate the access, but the page(s) is still read-only, so direct mapping would fail. In practice, such access will trap into qemu, which will complain "Should not read/write BAR through QEMU". I have seen this happening several times when developing the series (due to bugs in my patches), but I haven't found any case where it would happen with the final patch version. In fact, I have considered handling this whole thing via qemu (as it knows better where BAR live from the guest PoV), but stubdomain still don't have write access to that pages, so that would need to be trapped (for the second time) by Xen anyway. For the PV case, I think this extra translation wouldn't be necessary as BAR are mapped at their actual location, right? But then, it makes it rather different implementation (separate feature), than just having a common one for PV and HVM. > Which in turn raises the question: Do you need to handle reads > in the new code in the first place? The page not being mapped is also the reason why I do need to handle reads too. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --DHyxoT84A3Hd42vl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN2cAEACgkQ24/THMrX 1ywnTQf+Ipskn0MWsi0X7smmsFLkiKj7ZTlx7xQbu/I+Mh4V4BHWNGKbQp34KDUq f+P2KHC74BvWqxazB6jeudsq/Jj5iUHVlSYyoaQHf7KnP7BRrREW6rFgLGI8pHsU maFc0rdSeWWeXQo1UBpApt7tYVVGFd1uF2fgPyr/wze6AEOnBMabEnYuGFsvMBP3 s4orePiHheyT5VCeBGhezrNROplp3k8ZU1NAeFcYM+BdiNM98eXfTjcEQBNL8Ftp 63xiKsoRVkOg18bczDjtJCPnLCGp02D/QGi1NF87swqRwpwfzz2aGKX/r26/6Q37 QQH/8yU7RRnby89IyZOPI5DdulttPg== =qVZP -----END PGP SIGNATURE----- --DHyxoT84A3Hd42vl-- From xen-devel-bounces@lists.xenproject.org Thu Nov 17 20:18:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 20:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445349.700495 (Exim 4.92) (envelope-from ) id 1ovlLZ-00079p-2e; Thu, 17 Nov 2022 20:18:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445349.700495; Thu, 17 Nov 2022 20:18:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovlLY-00079g-WC; Thu, 17 Nov 2022 20:18:52 +0000 Received: by outflank-mailman (input) for mailman id 445349; Thu, 17 Nov 2022 20:18:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovlLX-00079U-RY for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 20:18:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovlLX-0004Rr-95; Thu, 17 Nov 2022 20:18:51 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ovlLW-0006sC-Ro; Thu, 17 Nov 2022 20:18:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=Wcin6zP534n1Zak79zV8aoBnBuK2bieJUUrTXY2uxk8=; b=TcAwwwmDoI8ihsvoUfWZgW4oAp mD8amRzpOqZl11O3JQdxjgsnT7e6CFtLd3cLarmNKYW1hx8McDleOEvLnRH8mudyWEfMyZL2k9Pop cij9zOs/Hq0iNUvn//5xPL3GOCIxbhjRKKeybisComlLXU0raDjmDBcvPtmcSLGv69KU=; Message-ID: <8624949e-6198-1aa3-152f-4294534d6d86@xen.org> Date: Thu, 17 Nov 2022 20:18:48 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 To: Luca Fancellu Cc: Xen-devel , "marco.solieri@minervasys.tech" , "lucmiccio@gmail.com" , "carlo.nonato@minervasys.tech" , Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221022150422.17707-1-julien@xen.org> <20221022150422.17707-5-julien@xen.org> From: Julien Grall Subject: Re: [RFC v2 04/12] xen/arm32: head: Remove restriction where to load Xen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Luca, On 25/10/2022 12:56, Luca Fancellu wrote: > > >> On 22 Oct 2022, at 16:04, Julien Grall wrote: >> >> From: Julien Grall >> >> At the moment, bootloaders can load Xen anywhere in memory but the >> region 2MB - 4MB. While I am not aware of any issue, we have no way >> to tell the bootloader to avoid that region. >> >> In addition to that, in the future, Xen may grow over 2MB if we >> enable feature like UBSAN or GCOV. To avoid widening the restriction >> on the load address, it would be better to get rid of it. >> >> When the identity mapping is clashing with the Xen runtime mapping, >> we need an extra indirection to be able to replace the identity >> mapping with the Xen runtime mapping. >> >> Reserve a new memory region that will be used to temporarily map Xen. >> For convenience, the new area is re-using the same first slot as the >> domheap which is used for per-cpu temporary mapping after a CPU has >> booted. >> >> Furthermore, directly map boot_second (which cover Xen and more) >> to the temporary area. This will avoid to allocate an extra page-table >> for the second-level and will helpful for follow-up patches (we will >> want to use the fixmap whilst in the temporary mapping). >> >> Lastly, some part of the code now needs to know whether the temporary >> mapping was created. So reserve r12 to store this information. >> >> Signed-off-by: Julien Grall >> ---- >> >> Changes in v2: >> - Patch added >> --- > > Hi Julien, > > I’m hitting an assert with this one, tested on qemu and fvp: Thanks for testing the series! > > Xen 4.17-rc > (XEN) Xen version 4.17-rc (user@hostname) (arm-poky-linux-gnueabi-gcc (GCC) 11.3.0) debug=y Tue Oct 25 10:51:06 UTC 2022 > (XEN) Latest ChangeSet: > (XEN) build-id: ab143b13f4394ced5331d6ff1cedebdb2ffadc07 > (XEN) Processor: 412fc0f1: "ARM Limited", variant: 0x2, part 0xc0f,rev 0x1 > (XEN) 32-bit Execution: > (XEN) Processor Features: 00001131:00011001 > (XEN) Instruction Sets: AArch32 A32 Thumb Thumb-2 ThumbEE Jazelle > (XEN) Extensions: GenericTimer > (XEN) Debug Features: 02010555 > (XEN) Auxiliary Features: 00000000 > (XEN) Memory Model Features: 10201105 20000000 > (XEN) 01240000 02102211 > (XEN) ISA Features: 02101110 13112111 21232041 > (XEN) 11112131 10011142 00000000 > (XEN) Using SMC Calling Convention v1.0 > (XEN) Using PSCI v0.2 > (XEN) SMP: Allowing 4 CPUs > (XEN) Generic Timer IRQ: phys=30 hyp=26 virt=27 Freq: 62500 KHz > (XEN) GICv2m extension register frame: > (XEN) gic_v2m_addr=0000000008020000 > (XEN) gic_v2m_size=0000000000001000 > (XEN) gic_v2m_spi_base=80 > (XEN) gic_v2m_num_spis=64 > (XEN) GICv2 initialization: > (XEN) gic_dist_addr=0000000008000000 > (XEN) gic_cpu_addr=0000000008010000 > (XEN) gic_hyp_addr=0000000008030000 > (XEN) gic_vcpu_addr=0000000008040000 > (XEN) gic_maintenance_irq=25 > (XEN) GICv2: 288 lines, 4 cpus (IID 00000000). > (XEN) XSM Framework v1.0.1 initialized > (XEN) Initialising XSM SILO mode > (XEN) Using scheduler: SMP Credit Scheduler rev2 (credit2) > (XEN) Initializing Credit2 scheduler > (XEN) load_precision_shift: 18 > (XEN) load_window_shift: 30 > (XEN) underload_balance_tolerance: 0 > (XEN) overload_balance_tolerance: -3 > (XEN) runqueues arrangement: socket > (XEN) cap enforcement granularity: 10ms > (XEN) load tracking window length 1073741824 ns > (XEN) Allocated console ring of 32 KiB. > (XEN) VFP implementer 0x41 architecture 4 part 0x30 variant 0xf rev 0x0 > (XEN) CPU0: Guest atomics will try 1 times before pausing the domain > (XEN) Bringing up CPU1 > (XEN) Assertion '!lpae_is_valid(*entry)' failed at arch/arm/domain_page.c:69 So this is asserting because, so far, for secondary CPUs, we are copying the content of the CPU0 root table to the secondary CPU root table and then update the entry. So the entry would logical be valid. This is fine to be valid because the root able is not yet live. I have follow-up patches (not yet sent) where the root table for secondary CPUs would also be live. I probably mistakenly tested with those patches. Anyway, the ASSERT() here doesn't make sense in the context of this patch because we are still switching the CPU0 root table. So I will drop the ASSERT() for now. I will re-introduce it in a follow-up series. Before I send a new version, do you have any comments for the rest of the patches? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Nov 17 21:10:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 21:10:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445372.700506 (Exim 4.92) (envelope-from ) id 1ovm9p-0005pX-TV; Thu, 17 Nov 2022 21:10:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445372.700506; Thu, 17 Nov 2022 21:10:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovm9p-0005pQ-Qp; Thu, 17 Nov 2022 21:10:49 +0000 Received: by outflank-mailman (input) for mailman id 445372; Thu, 17 Nov 2022 21:10:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovm9o-0005pK-Hp for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 21:10:48 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4c3eac72-66bc-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 22:10:45 +0100 (CET) Received: from mail-co1nam11lp2174.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 Nov 2022 16:10:42 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6156.namprd03.prod.outlook.com (2603:10b6:408:101::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Thu, 17 Nov 2022 21:10:40 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%5]) with mapi id 15.20.5813.020; Thu, 17 Nov 2022 21:10:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c3eac72-66bc-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668719446; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=mMgjMMPXSq4VaDnBKjB8rA5B1BQ/8FfFZmXBNw1LA4I=; b=MDpzx05WrNJeK0HLL8e07J0DzTYErwwzQQpjyPrNkfSQekiJtF4NBEcH 6BvLCFdxU5so8yFBhp/ipBFNpRjDUG8Bhg9hnghrIx6f4gTWtJUk2k5xB 4dsA0WhqBVUeUYmuu+kIK8KQ0P/+o+loL4PO30sQfSIwWuuasy7yGyIWB M=; X-IronPort-RemoteIP: 104.47.56.174 X-IronPort-MID: 85089702 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ZLGAfKpfM3A0i6okvXxzdwafllJeBmImZBIvgKrLsJaIsI4StFCzt garIBnSbvvYYmD9eIt0bYi/oUNX68WBydQ3QQM/+CE2E3hA9ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHziZNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAGEwZSyTisaH/IiYbfU3ncQcKeLIH5xK7xmMzRmBZRonabbqZvyToPR/hXI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jearaYWJEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXoq6Y60QLLnAT/DjUuSEaLp8eBtXeEUvhZd R0++3MfsqotoRnDot7VGkfQTGS/lg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC9 HWEgtfoDjxHq6CORDSW8bL8hSy2ETgYKykFfyBsZSsI5cPy5r46iB3nR8xmVqWyi7XI9SrYx jmLqG01gOwVhMtSjqGjpwmY33Sru4TDSRMz6kPPRGW54whlZYmjIYu19Vzc6vUGJ4GcJrWcg EU5dwGlxLhmJfmweOalG43hwJnBCy65DQDh IronPort-HdrOrdr: A9a23:VQaoK64CUfQhH1NSQgPXweCCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpixBiSgSiu4LvaFQHd+hsFSTtAzZor7G CAymXCl+SemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQBiTwhh2ubIFBXaTHmDwuuumg5Hsjjd GJiRY9OMZY7W/XYwiO0FXQ8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMk5 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvvn+9Ua1wWR4S2rpXV9 WGP/usosq+tmnqNkwxi1MfhOBEmE5DRituDHJy4fB9mAIm4UyRh3FouPD32E1wtK7VAqM0md gteM5T5c5zZ95TYqRnCOgbR8yrTmTLXBLXKWqXZU/qDacdJhv22tfKCZgOlZaXkaYzve0PsY WEVEkduX85ekroB8HL1JpX8grVSGH4WTj20MlR65Vwp7W5HdPQQGa+YUFrl9Hlr+QUA8XdVf r2MJVKA+X7JW+rHYpSxQXxV5RbNHFbWswIvdQwXU6Iv6vwW8XXn/2edOyWKKvmED4iVG+6Cn wfXCLrLMEF9UyvUm+QummkZ5osQD2LwXtdKtmowwFI8vl9CmRliHlktX2poseWNDZFrqs6OE NjPbKPqNLImVWL X-IronPort-AV: E=Sophos;i="5.96,172,1665460800"; d="scan'208";a="85089702" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fYUaEoTHZMwJETwnMAFIsildNTOmNmBeTyvbahIx9fmXwCgFh9Yt3+GgeZCfpFdC0BiJV9BSewqPY6li7vhEpxQojhpjocy6cSOfKnB9d+IxdAiiT3PgfbkUfLzSxsWd8hxEugOjWo5Dzn221Wo6T8ClMKZ5S1kxheSAJoW6Q+T2+YTMZAorsrNYPOnlWbkNUt09Rl7dJOEv0im66udwKigWQbFtrSSwcEYq2KinFjxIlwXacHZ7Uduhhux1tN/3KGZ0YeOvCLbbWkL4nVb5VeIFoCyeBIytUglK4BthRca3BWYOPWDBrKERvngc6AdodW8CQKhReVEJqPcOZd9xXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mMgjMMPXSq4VaDnBKjB8rA5B1BQ/8FfFZmXBNw1LA4I=; b=m155e77oY3f3pDlflOCBn7BCWF4J0CNQxeeKgEXV38DZ1o72RAS74lq+/UcdWiIVb31U3f7z0d8DSlRolf2qSeRwa8m2qNRoCo9VY4RSkXxT6mA+ZmrMWgRaJAkXE3uZSV7e1N4zmb8Y0HWbYttmN+DYlYMtWZryT85pveUGdAjAGyQZtyvUTS0c7K65sdu6Jfd0vItt+wTl7H0sBw2mpGplPNun4c8UpClDAGFuoFzohpHAVf+qI294UbSujGj4eqzBuhV48r37IvPdd8YUkYTGCIkAgO7UoH5yHQY9cQ2DslqprP+1z4gMfDbpm6NTv4uh36RpUf2tqM1tTZ3/JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mMgjMMPXSq4VaDnBKjB8rA5B1BQ/8FfFZmXBNw1LA4I=; b=aUy0H4JRHAUvrf9Q7sTs0YTD07nDZ6zVS2lpamn3hoIPb8dGwPbsRnGKH18TeE6b1RV/YE79LbTTbwBJTq4EP6Xx9Jv9mF6KlmEFlfOt83CA1zQMR5pypIte/uXGNv+tYa6TYdaehaNqasoLu4IXRUCWpTFBVw5YxWMWXgMUf10= From: Andrew Cooper To: Roger Pau Monne CC: Xen-devel , Jan Beulich , Wei Liu , Henry Wang Subject: Re: [PATCH for-4.17] x86/hvm: Revert per-domain APIC acceleration support Thread-Topic: [PATCH for-4.17] x86/hvm: Revert per-domain APIC acceleration support Thread-Index: AQHY+Io3ygoaE+gKUU+QEYfs8WRTZ65AKPMAgAN4DoA= Date: Thu, 17 Nov 2022 21:10:39 +0000 Message-ID: References: <20221115003539.19502-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BN9PR03MB6156:EE_ x-ms-office365-filtering-correlation-id: 44eee01b-f5d0-4268-4514-08dac8e02df6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: p0ocC/XCO/cj1G9MCB0nVKgOk1vmuewzXCO3wdKXF9lRl4HYD+jrHqHSxV2nqmwgZwJc/r5aqfZTKnBlnXRYC1Jv29WNdiib3KQogEr68GfGSfByxjdYQ+TynMQIvfBdFG2HRqF5/db7drfSwLrgtLw5wFiT8ic53DdkwXF2sw7+JBwryFGhLG2t0WZqGiEkwFZ6z6ei66/01QH8o6aJor+EC9S56dwGE4QU6sCiW1sE6xw6dJJJiFm3d4QIjRoavvPBUIgmAB3J8/LaJNoD7ZiMi5f6GCJ6IXzXdGkpT5rh/fTbICbZ2E2Zz1SuyUVj6CzyfjxQKY6toJKnBOOd9NYoSRoC+te4DSy5aOivaAeqCvQb77gGheMO3pPhnuIiygtSvIrSMk44QZNTNqRXW4Ns1x49E7hmfaIOzZsJ3rzL+Fu8HvFJ8H4TQlrN3brGLSX3FpfYnzYRyE9UVh3/be9KRhtn0chVoTi1NpxTXzAZvksAgQtwsAX7j4BSuTt1xhuMSDugxndLQvzzpdcq9Th9CV82IMedja/OOVtI4pGv9Hvtmlz0QKcKzApWMRUumPe6e8qAFyLS9BLpxhglL0L2yQaHZ6p2i4wD83OAT6THzgRIvAApEtHYNajkhA50HzuquthmPPqDJEJgWb7aPZo5SIGG2gnOacEX9m949PR8aMQaeaeQzGp3RuMcAUV1y8J267zMQlB1nv1hJpE4HH7WCi4g78D1KpY3yDgrtHFuuYcnutuB/VF7epsGcNWT22KQfW5SCyhS98l20B9Hwg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199015)(31686004)(71200400001)(66476007)(478600001)(6486002)(83380400001)(38070700005)(86362001)(31696002)(6862004)(8936002)(5660300002)(36756003)(2906002)(8676002)(64756008)(76116006)(6506007)(4326008)(66556008)(66946007)(41300700001)(91956017)(66446008)(53546011)(122000001)(82960400001)(38100700002)(6512007)(54906003)(26005)(6636002)(186003)(316002)(37006003)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZnVpRWc4Wk94bERVdGR0aC9QZU9POUF1Vng4bWVJYVN0NW1CMFFYWFZINzJp?= =?utf-8?B?ZlZWNGhZMzdwczBLWGF3SUUvNkxCbGFidmljQ29kd0FZRlBrL2ZRblFRSEVl?= =?utf-8?B?eTlnd0lUbytjWnQrZlpyRjVyMHhJWEtBMnIxR0RWV0dpMlN5ZnZPSHpRQXhm?= =?utf-8?B?UnBkTWRzSExNeDNVZ0pNakZiUXQvbUhia0VXZlJsT0NaK2FzT0V6R2ZFWUNZ?= =?utf-8?B?U1BSSkswNytPd1hLd1p3VTZuRkVLejRwUjBuM2FHRmJBaDVUcnBLd3NCK1NU?= =?utf-8?B?OFZiRm9FeEtocWUvOTg3bUlvcGs1Tk5SWE9oWS9GeVU2ZFNid1BUL2R6bmho?= =?utf-8?B?N1B4THVXZnNDMVNncDBvb2hqTXp1TXNMWVYyMjNVNG1lUFZEeDJyUmhWNHdS?= =?utf-8?B?cUJSTEUzUmE5ZDd2T3lYN29lejU1VGRUN0c4RlJFRUd1UFBYKzI3TUVXOHA5?= =?utf-8?B?ZU5RYURTNXdneG50bXlMT05qVE05Z2ZYQlI5WFdyd1UxQndxQUFXQTZqUjE2?= =?utf-8?B?bnRoa1BTc0dlQXd3VFpVc082aVZlQkQ5ZXl6eklCKzU2UTNEV1NPTGtTOFlE?= =?utf-8?B?WGNVM1FNMW5KdDRxSlQyNkgzSXpGRUhOSHYyQmw3UTNBbUNaWkgwYUVzRUo5?= =?utf-8?B?TTNKNDRKbkpxbHR1MVRsZlFCNjZQWVpPK1JRSjJWbHNFVDFnUGFNWEtVblVO?= =?utf-8?B?eEhQNEFHT2JCQmdEWDc1QjlVWkliRWd6dVB1YlpRNXNmREdvaEdmOWdjTFlO?= =?utf-8?B?NUgydTlPamRoa2I2MkNwd2UzMHVwUDdnR2NGb25NMzNUYVludGF2VzdMem8r?= =?utf-8?B?Vkw4WHpSeWZPMGtsQ0l1QXJ1ejZjZFN0ZmhKS3VXMlM2QVhpRUZHdEsxTm1N?= =?utf-8?B?TnlGZEIwVUZXSXRoQXNiRVdpejd0c1gyS3dYSVdsVnpWUGJ5OVd3TVRhSTE5?= =?utf-8?B?TkdVUGNGdlRTTDVNZ0NYeDVRRWtocW9nVUJmcyt2RE1SMXVxdnRXaDArOGxa?= =?utf-8?B?bi9MZUxjaEJBMHZYcmYyOXZoUDVxOE9wb2liUm1pa2N1Z09zTnoySldDYnM0?= =?utf-8?B?QWs1MTgvVmxaanpMZXBWcXRvQWF3aXdVZTdQaGZYS0p3VDdJUnIvRURMTDdE?= =?utf-8?B?Vi9weStsbU9NWThpN1g5a1gzVUZJYjJuWlF2Wm90eGs2eDBMelc3SUF0NnRC?= =?utf-8?B?aWhXNlhpRFYzaGNxRldGaVZ1S3dYZk1uZURKaHptcXJ5UkJZNnoxZllwdnhx?= =?utf-8?B?dk8zaXRMc1o4R1poZ3U1ZEhiU0kzbG14WFhvT0Z0eXF2VnQ3Q0FOV1FtelBI?= =?utf-8?B?Ty9qY3BkM1UrMExncUE0NUVSNDNydnphL3RwNHV0Q1o1aUFybUtoUTdvYWxU?= =?utf-8?B?MzRIQ2ZFNkZvYlNpQW42UG4vb0hLa3VHUGY5WTFkdlhCN29qTTZBTHQwUlpV?= =?utf-8?B?cG1vektCdXFNOHB5VG9EMUM3VTJQRnQzSlE3cXFpNExmcnRHZFFWMzcrYldl?= =?utf-8?B?ODdBcktKb3U2bGxvSjhqTXFyT2swS2lzTjFsek9NSlFKN2J2Wngvd2h0YlRP?= =?utf-8?B?TktsQTBtbnhLVVU4T25SdGZDRVhmU1MzQU5abDNieFBiWGQ1cC9OTTVTRFFM?= =?utf-8?B?WDExL2tmcHUwb0p2YTJUZzB0Y2hhaG5qUk5yV2xqQ0dxR3FYcTdwcGNRS2Zn?= =?utf-8?B?UENrZUkrNVFGZGQrZWhLNjRiZmpnQXpPRTRLVHlzci9aMW9BY1Y3S0VvTnlE?= =?utf-8?B?WkVOSlhTTUFucm9DYW9XQXY1Qi9HS2xXNmlKU1ZqMWpGZEZjNFNZQ0ZPNElN?= =?utf-8?B?UW9lbGJqVWYvOXNhaFI4MEhJWGtIazgzQStKTUY0U0lIaXlMbUJ2SVZKMWE4?= =?utf-8?B?eDVjRWYxcGQxYnh6c2ZjTHZReThOZEhIY3pGQkZTcWdPa0o0MG9Jak5VT0lU?= =?utf-8?B?MGh1QkVYak1Md3BzNFZWZXZMWG55WXZuSklBRUlFdDRBT3RXVGp4ZThvOVNj?= =?utf-8?B?OThDQ21VL3lPM2dMMUFqTEFFM2tEV05BYTFlU3llZlMzTjhIT0hsbTQvbFMy?= =?utf-8?B?b2NPT3UvUEJYckVnajM5RVVRNThNcDJFU1JNLzZxR2hLMFY4NnEwM3JTQkV6?= =?utf-8?Q?pAH7UxWOeh8eQrW+Il0frZHKH?= Content-Type: text/plain; charset="utf-8" Content-ID: <89B03C350742B94EA2F83AE30B910398@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZtDGqvqEC5eZY2S6Y0D3cwcp4K2fvlkvlqZ7ijwNxkRtdmsSKo21Bq44GoPDN30agELuH8ncfKjOZQ3JvHv2BwE6vE5R/A1e7koj7jXOotR8LGdmbiQ7YQMFkMDQNex9OnRZ5U7S5gtaXdirrZm74IhMMgWB1hIoYMQ3edLxnCiYmVLuVj9gpu3OZaKfXQyHPkZqYXYt/Dc3F3T0ZxNRhPXrNwBAdbKQadjWSu+5e3gaGFRRcBEwknM5L1ehe1LwXyPDd1+4roDccYvtsgTcLSwnyj3vc96QHVIhH95D6KGJs1VjR91jFABBr8PAHm6yXQkh+Ds3a4I+yugpuROsVDqkk/8c+Qay+OSgfq2Y40W781js3fiL4pmE5j/zUwInWeHh/d5S5MEmlx63mDqOCurvtRrb+HaZ8vaS7BkiqaYzR91PCFAKmyCqIbZ267neR64Uyo+E7+nA/wCKj8Wy0reYgAu7HSXbjzw6GseQHH4wB8Iwnqj8R/w1dxrlBEB5slPn0PQ69zYTRYrV0fdlKn3uB86T6Yz0xpW+6GvQwThy14MwUMQEKtqrUaie+OO6AImc/kVUfv34rCS4sPbv1Sll+8ccI2JuQ21ViBSIrITUEoUhzqxFzfeqlnh4GBA0EbbotGup9hfIXhJ8J7MGo+oCThRLV09MjTfFdYJ3Bi6LBS23WYp6sIB75dlP9dBxB/9/jJYGZ+zkknSHfPqERpyxREltFJHpq411ZgfPFZWjX0LeKNw+nnLqGsilrFvEvyUWPruTQ9O0SD/aKJH+C2rJJCqLymmgntTrA+9KqCAApsxKt48/4VLGJYKxXNQUZQeNCIb9/HXVEIfGDhnbOE76TUh7oyfLBjILz80SBaI= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44eee01b-f5d0-4268-4514-08dac8e02df6 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2022 21:10:39.5065 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b2KpPmi/46UYW5/iaCTcBwTdNof1KKAzqxnQI5WfcyJxAzV3GyRoNaeHbqMN59JCkELQWjrVu4FYFklr+oGBtGWbcg/8W1azTiWswdHmJo0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6156 T24gMTUvMTEvMjAyMiAxNjoxMiwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBPbiBUdWUsIE5v diAxNSwgMjAyMiBhdCAxMjozNTozOUFNICswMDAwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4g SSB3YXMgcmVhbGx5IGhvcGluZyB0byBhdm9pZCB0aGlzLCBidXQgaXRzIG5vdyB0b28gbGF0ZSBp biB0aGUgNC4xNyBmcmVlemUgYW5kDQo+PiB3ZSBzdGlsbCBkb24ndCBoYXZlIHdvcmtpbmcgZml4 ZXMuDQo+IFRoZSBmaXggSSBwcm9wb3NlZCBzdGlsbCBoYXMgc29tZSBjb21tZW50cyB0aGF0IGhh dmUgYmVlbiB1bmFuc3dlcmVkLA0KPiBidXQgYXQgYW55IHJhdGUgdGhpdCBpcyBub3cgZmFyIHRv byBsYXRlIHRvIHRyeSB0byBnZXQgdGhpcyBmaXhlZC4NCj4NCj4gRldJVyB0aGF0IHNhbWUgZml4 IHdhcyBhbHNvIHBvc3RlZCB0byB0aGUgc2VjdXJpdHkgbGlzdCB3YXkgYmVmb3JlDQo+IGhpdHRp bmcgeGVuLWRldmVsLg0KPg0KPj4gVGhlIGluLVhlbiBjYWxjdWxhdGlvbnMgZm9yIGFzc2lzdGFu Y2UgY2FwYWJpbGl0aWVzIGFyZSBidWdneS4gIEZvciB0aGUNCj4+IGF2b2lkYW5jZSBvZiBkb3Vi dCwgdGhlIG9yaWdpbmFsIGludGVudGlvbiB3YXMgdG8gYmUgYWJsZSB0byBjb250cm9sIGV2ZXJ5 DQo+PiBhc3BlY3Qgb2YgYSBBUElDIGFjY2VsZXJhdGlvbiBzbyB3ZSBjb3VsZCBjb21wcmVoZW5z aXZlbHkgdGVzdCBYZW4ncyBzdXBwb3J0LA0KPj4gYXMgaXQgaGFzIHByb3ZlZCB0byBiZSBidWdn eSB0aW1lIGFuZCB0aW1lIGFnYWluLg0KPj4NCj4+IEV2ZW4gYWZ0ZXIgYSBwcm90cmFjdGVkIGRp c2N1c3Npb24gb24gd2hhdCB0aGUgbmV3IEFQSSBvdWdodCB0byBtZWFuLCBhdHRlbXB0cw0KPj4g dG8gYXBwbHkgaXQgdG8gdGhlIGV4aXN0aW5nIGxvZ2ljIGhhdmUgYmVlbiB1bnN1Y2Nlc3NmdWws IHByb3ZpbmcgdGhhdCB0aGUNCj4+IEFQSS9BQkkgaXMgdG9vIGNvbXBsaWNhdGVkIGZvciBtb3N0 IHBlb3BsZSB0byByZWFzb24gYWJvdXQuDQo+IEFyZSB5b3UgcmVmZXJyaW5nIHRvIHRoZSBWTVgg aGFyZHdhcmUgaW50ZXJmYWNlIHRvIHNldHVwIHRoZSByZWxhdGVkDQo+IEFQSUMgYXNzaXN0YW5j ZSBmbGFncywgb3IgdGhlIGh5cGVydmlzb3IgaW50ZXJmYWNlIHRvIGNvbnRyb2wgdGhvc2UNCj4g ZmVhdHVyZXM/DQo+DQo+PiBUaGlzIHJldmVydHMgbW9zdCBvZjoNCj4+ICAgMmNlMTFjZTI0OWEz OTgxYmFjNTA5MTRjNmE5MGY2ODFhZDdhNDIyMg0KPj4gICA2YjJiOWIzNDA1MDkyYzNhZDM4ZDcz NDI5ODhhNTg0YjhlZmE2NzRjDQo+Pg0KPj4gbGVhdmluZyBpbiBwbGFjZSB0aGUgbm9uLUFQSUMg c3BlY2lmaWMgY2hhbmdlcyAobWluaW1hbCBhcyB0aGV5IGFyZSkuDQo+Pg0KPj4gVGhpcyB0YWtl cyB1cyBiYWNrIHRvIHRoZSBiZWhhdmlvdXIgb2YgWGVuIDQuMTYgd2hlcmUgQVBJQyBhY2NlbGVy YXRpb24gaXMNCj4+IGNvbmZpZ3VyZWQgb24gYSBwZXIgc3lzdGVtIGJhc2lzLg0KPj4NCj4+IFRo aXMgd29yayB3aWxsIGJlIHJldmlzaXRlZCBpbiBkdWUgY291cnNlLg0KPiBJIGNlcnRhaW5seSBy ZWdyZXQgaGF2aW5nIGJlZW4gaW52b2x2ZWQgaW4gYXR0ZW1wdGluZyB0byBmaXggdGhpcywgYW5k DQo+IEkgaGF2ZSB0byBhZG1pdCBJIHN0aWxsIGRvbid0IHVuZGVyc3RhbmQgd2hhdCBpcyBicm9r ZW4gd2l0aCB0aGUNCj4gY3VycmVudCBBUEkvQUJJLg0KPg0KPiBEbyB3ZSB3YW50IGEgZmxhZyB0 byBjb250cm9sIHRoZSBzZXR0aW5nIG9mIHRoZSBBUElDIHJlZ2lzdGVyDQo+IHZpcnR1YWxpemF0 aW9uIGZlYXR1cmU/DQo+DQo+IElzIHRoZSBuYW1pbmcgZm9yIHRoZSBmbGFnIHRoYXQgd2UgZXhw b3NlIGluY29ycmVjdD8NCj4NCj4gSXMgdGhlIGZpZWxkIHdoZXJlIHRoZSBmbGFnIGdldHMgc2V0 IGluY29ycmVjdD8NCj4NCj4gVGhlcmUgaXNuJ3QgdGhhdCBtdWNoIHRvIHRoZSBjdXJyZW50IGlu dGVyZmFjZS4NCj4NCj4gSW4gdGhlIHByZXZpb3VzIHJlcGx5IHRvIHRoZSBmaXggaG93ZXZlciBJ IGdvdCB0aGUgKG1heWJlIGluY29ycmVjdCkNCj4gaW1wcmVzc2lvbiB0aGF0IGN1cnJlbnQgYnVn cyBpbiB0aGUgaW1wbGVtZW50YXRpb24gYXJlIHVzZWQgYXMgYSB3YXkNCj4gdG8ganVzdGlmeSB3 aHkgdGhlIGludGVyZmFjZSBpcyBicm9rZW4sIGFuZCB0aGF0IGlzIG5vdCBhY2N1cmF0ZS4gIFRo ZQ0KPiBpbnRlcmZhY2UgYW5kIHRoZSBpbXBsZW1lbnRhdGlvbiBhcmUgdHdvIGRpZmZlcmVudCB0 aGluZ3MsIGFuZCBidWdzDQo+IGluIHRoZSBpbXBsZW1lbnRhdGlvbiBzaG91bGRuJ3QgYXV0b21h dGljYWxseSBpbnZhbGlkYXRlIHRoZQ0KPiBpbnRlcmZhY2Ugd2l0aG91dCBmdXJ0aGVyIHJlYXNv bmluZy4NCg0KVGhlIGZhY3QgeW91IHN0aWxsIGhhdmUgdGhlc2UgcXVlc3Rpb25zIGRlbW9uc3Ry YXRlcyB0aGUgcG9pbnQgSSdtDQp0cnlpbmcgdG8gbWFrZS4NCg0KVGhlIGFuc3dlciBpcyBpbiB0 aGUgd3JpdHRlbiBkZXNjcmlwdGlvbiBvZiBob3cgdGhlIGludGVyZmFjZSBpcw0KaW50ZW5kZWQg dG8gYmVoYXZlLsKgIFRoZSBmYWN0IHRoZXJlIGlzbid0IG9uZSBpcyB0aGUgZmlyc3QgcHJvYmxl bS4NCg0KDQpUaGlzIGVtYWlsIGhhcyB0YWtlbiBhIGxvbmcgdGltZSB0byB3cml0ZS7CoCBJJ20g bm90IHRyeWluZyB0byBjcml0aWNpc2U7DQp0aGlzIGlzIHJlYWxseSByZWFsbHkgY29tcGxpY2F0 ZWQgc3R1ZmYsIGJ1dCBJIGZlZWwgYSBjaGFuZ2UgaW4NCmV4cGVjdGF0aW9ucyBpcyBuZWNlc3Nh cnkuDQoNCg0KVGhlcmUgYXJlIGRlZmluaXRlbHkgaW1wbGVtZW50YXRpb24gaXNzdWVzLsKgIFdl J3JlIGFsbCBhZ3JlZWQgaGVyZS4NCg0KSWYgdGhlIGltcGxlbWVudGF0aW9uIGlzc3VlcyBjb3Vs ZCBiZSBmaXhlZCBwZXJmZWN0bHksIHRoZW4gd2UgYXJlIHN0aWxsDQpsZWZ0IHdpdGggYW4gaW50 ZXJmYWNlIHdoaWNoIGlzIGluY29tcGxldGUgKGxhY2tpbmcgYSBUUFIgY29udHJvbCksIGFuZA0K aW1wcmVjaXNlLg0KDQoiSnVzdCBpbmNvbXBsZXRlIiB3b3VsZCBiZSBlbnRpcmVseSBmaW5lLsKg IFdvcmsgY291bGQgY29udGludWUgaW4gNC4xOA0KdG8gZmlsbCBpbiB0aGUgbWlzc2luZyBwaWVj ZXMuDQoNCkJ1dCAiYWNjZWxlcmF0ZWQgeHssMn1hcGljIiBpcyBhbWJpZ3VvdXM7IE5vdGUgaG93 IG11Y2ggdGltZSB3YXMgc3BlbnQNCmJ5IHVzIHRyeWluZyB0byBmaWd1cmUgb3V0IHdoYXQgaXQg b3VnaHQgdG8gbWVhbiwgYW5kIGRlc3BpdGUgY29taW5nIHRvDQphIHRlbnRhdGl2ZSBhZ3JlZW1l bnQsIEkgaGF2ZSB0cmllZCBhbmQgZmFpbGVkIHRvIG1ha2UgYSBjb3JyZWN0DQpjb3JyZWN0aW9u IHRvIHRoZSBpbXBsZW1lbnRhdGlvbiwgYW5kIHNvIGhhdmUgeW91Lg0KDQpXZSBhcmUgdGhlIGV4 cGVydHMgaW4gdGhpcyBhcmVhIGFuZCB3aGVuIHdlLCB3aG8gdGhpbmsgd2UgdW5kZXJzdGFuZCB0 aGUNCmNvbXBsZXhpdHksIGNhbm5vdCBnZXQgaXQgY29ycmVjdCwgaG93IG9uIGVhcnRoIGRvIHlv dSBleHBlY3QgZW5kIHVzZXJzDQp0byBjb3BlIHdpdGggdGhlIHNhbWUgaW50ZXJmYWNlPw0KDQoN ClByb2JsZW1zIHBpbGluZyB1cCBpbiB0aGUgd2F5IHRoZXNlIGhhdmUgaXMgYSB0ZWxsLXRhbGUg c2lnbiB0aGF0DQp0aGVyZSdzIGEgYmlnZ2VyIGlzc3VlIGF0IHBsYXkuwqAgUGFydCBvZiB0aGUg cmVzcG9uc2liaWxpdGllcyBvZiBiZWluZyBhDQptYWludGFpbmVyIGlzIGtub3dpbmcgd2hlbiB0 byB0YWtlIGEgc3RlcCBiYWNrLCByZS1ldmFsdWF0ZSB0aGluZ3MsDQphc2tpbmcgImlzIHRoaXMg cmVhbGx5IHRoZSByaWdodCBjb3Vyc2Ugb2YgYWN0aW9uPyIsIGFuZCBzb21ldGltZXMgdGhpcw0K aW52b2x2ZXMgYWRtaXR0aW5nIGZhaWx1cmUsIGFuZCB0cnlpbmcgdG8gZmlndXJlIG91dCBob3cg dG8gbWluaW1pc2UgdGhlDQpjb2xsYXRlcmFsIGRhbWFnZS4NCg0KSW4gdGhpcyBjYXNlLCBJJ20g c3RhdGluZyAtIHVzaW5nIHRoZSBwdWJsaWMgcmVjb3JkIG9mIGNoYW5nZXMgYW5kDQphdHRlbXB0 cyBpbiB0aGlzIGFyZWEgYXMganVzdGlmaWNhdGlvbiAtIHRoYXQgdGhlIGNvbXBsZXhpdHkgaXMg dGhlDQptYWpvciBwcm9ibGVtLCBidXQgaXQgaXMgYmVpbmcgY29tcG91bmRlZCBieSB0aGUgYW1i aWd1aXR5IGluIHRoZQ0KaW50ZXJmYWNlLsKgIEkgZGVzcGVyYXRlbHkgZGlkIHdhbnQgdG8gYXZv aWQgYSBmdWxsIHJldmVyc2lvbiwgYnV0IGl0IGlzDQp0aGUgb25seSByZXNwb25zaWJsZSBjb3Vy c2Ugb2YgYWN0aW9uIGF0IHRoaXMganVuY3R1cmUuDQoNCg0KWW91IG1heSBvciBtYXkgbm90IGFn cmVlIHdpdGggbXkgcmVhc29uaW5nIGhlcmUsIGJ1dCB5b3UgaGF2ZSB0byBjb25jZWRlDQp0aGF0 IHRoZXJlIGlzIGEgcHJvYmxlbSBhbmQgdGhhdCBvdXIgY3VycmVudCBhdHRlbXB0cyB0byBhZGRy ZXNzIGl0IGFyZQ0Kbm90IHdvcmtpbmcuDQoNCkFzIGZhciBhcyBuZXh0IHN0ZXBzIGdvLCBJIGhh dmUgYSBwbGFuIGFuZCBpdCBpbnZvbHZlcyBkb2luZyBub3RoaW5nDQp1bnRpbCB3ZSBoYXZlIGEg bmV3IHNwaGlueCBkb2MgYWdyZWVkIHVwb24gYW5kIGNoZWNrZWQgaW50byB0aGUgdHJlZSwNCmZy b20gd2hpY2ggd2UgY2FuIGJ1aWxkIGEgc2hhcmVkIHVuZGVyc3RhbmRpbmcgb2YgdGhlIGNvbXBs ZXhpdGllcyBpbnZvbHZlZC4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Thu Nov 17 21:15:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 21:15:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445377.700517 (Exim 4.92) (envelope-from ) id 1ovmEN-0006S3-HE; Thu, 17 Nov 2022 21:15:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445377.700517; Thu, 17 Nov 2022 21:15:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovmEN-0006Rw-Cz; Thu, 17 Nov 2022 21:15:31 +0000 Received: by outflank-mailman (input) for mailman id 445377; Thu, 17 Nov 2022 21:15:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovmEM-0006Rq-Kw for xen-devel@lists.xenproject.org; Thu, 17 Nov 2022 21:15:30 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f560a905-66bc-11ed-91b6-6bf2151ebd3b; Thu, 17 Nov 2022 22:15:28 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2BC586223F; Thu, 17 Nov 2022 21:15:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D438CC433D6; Thu, 17 Nov 2022 21:15:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f560a905-66bc-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668719727; bh=OQRwmVxkj8+xV9QXETJbtDq3lnn5kzpCXHkLI6zBNZ4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=mxpHC4OBwIKdyO5Mli+7yXX40gASm77+uqjBaHBaTGsz6Z/e7KiUHLeSoctxSFkZ1 3m82aiKTYET27DIX3s7XteZ2Ut1li3ZTM1qaPTaU7e4PO6EidkKMigH07iDz5+nddr bOaxAIDkFQtI+6MK+05ppO54P3RORo7yeg1DmKK2GnnV19ur0B/ed0wdZDk913wzyq oaCVtz0GR1X5J0IjNZXrccciGe/lzcQOFNHe75FLzyfhCWnkZX7d7rKDe4wC9LYm86 NcbXlC8SIj3TtrZ2E+9DpQyFkES2B1tQHOnY2epw6K7cKosXzGvyfykdap9QxzlbTZ RTuWoN9iAW8Sg== Date: Thu, 17 Nov 2022 13:15:24 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Michal Orzel , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [RFC] docs/misra: List files in Xen originated from external sources In-Reply-To: Message-ID: References: <20221116092032.4423-1-michal.orzel@amd.com> <93736488-8e0c-282a-2e5f-db0cf9419183@suse.com> <88a04b63-04ba-ef03-771d-1f2d11ea8549@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 17 Nov 2022, Jan Beulich wrote: > On 17.11.2022 11:39, Michal Orzel wrote: > > On 17/11/2022 11:03, Jan Beulich wrote: > >> On 16.11.2022 10:20, Michal Orzel wrote: > >>> --- /dev/null > >>> +++ b/docs/misra/external-files.txt > >>> @@ -0,0 +1,70 @@ > >>> +External files in Xen > >>> +===================== > >>> + > >>> +The following table lists files present in the Xen codebase that originated > >>> +from external sources e.g. Linux kernel. The purpose of this table is to: > >>> + - keep track of the external files in the Xen codebase, > >>> + - help with the review process (e.g. changes done to the files that did not > >>> + diverge, shall be first submitted to the external projects and then > >>> + backported to Xen), > >>> + - act as a base for listing files to exclude from MISRA checkers. > >>> + > >>> +NOTES: > >>> +1) The files shall be listed in alphabetical order. > >> > >> But then you don't? > > True, it is alphabetical order with directories having a precedence. > > Which is kind of surprising and, at least for me, confusing. > > >>> +2) The origin of the files derived from the projects other than Linux, shall > >>> + be specified within the () placed next to the path. > >> > >> Might it be more generally useful to have another column, then not only > >> stating the project but also the path it lives at there (or lived at the > >> time of cloning)? > > We though about it. Would be a good idea but can be quite challenging for files > > that appeared in Xen before switching to git (difficult to establish the time of cloning in such cases). > > > >> > >>> +3) The table shall be updated when importing new files from external projects. > >>> +4) At the moment, only the source files are listed in the table. > >>> + > >>> +| Relative path to xen/ | Diverged from | Subject to | > >>> +| | origin? [Y/N] | backports? [Y/N] | > >>> ++-------------------------------------------+---------------+------------------+ > >>> +| arch/arm/arm64/cpufeature.c | N | Y | > >>> +| arch/arm/arm64/insn.c | N | Y | > >>> +| arch/arm/arm64/lib/find_next_bit.c | N | Y | > >>> +| arch/x86/acpi/boot.c | Y | ? | > >>> +| arch/x86/acpi/lib.c | ? | ? | > >> > >> This was simply split off from boot.c, which I'd be inclined to take to > >> mean Y in the "diverged" column. In the backports column I'd prefer to > >> keep ? for both, or any other indicator taken to mean "maybe / uncertain". > >> > >> What about arch/x86/acpi/cpufreq/* and other stuff in arch/x86/acpi/? > >> > >>> +| arch/x86/cpu/mcheck/mce-apei.c | N | Y | > >>> +| arch/x86/cpu/mcheck/non-fatal.c | ? | Y | > >> > >> Even before disappearing in 2.6.32 the file was different from Linux'es, > >> simply because we don't have anything like schedule_delayed_work(). So > >> it's pretty clearly Y for "diverged". > >> > >>> +| arch/x86/cpu/mtrr/* | Y | N | > >>> +| arch/x86/cpu/amd.c | Y | N | > >>> +| arch/x86/cpu/centaur.c | Y | N | > >>> +| arch/x86/cpu/common.c | Y | N | > >>> +| arch/x86/cpu/hygon.c | Y | N | > >>> +| arch/x86/cpu/intel_cacheinfo.c | Y | Y | > >>> +| arch/x86/cpu/intel.c | Y | N | > >>> +| arch/x86/cpu/mwait-idle.c | Y | Y | > >>> +| arch/x86/genapic/* | Y | N | > >>> +| arch/x86/x86_64/mmconf-fam10h.c | N | Y | > >>> +| arch/x86/dmi_scan.c | Y | ? | > >>> +| arch/x86/mpparse.c | Y | ? | > >> > >> Like above I'd like to keep ? (or alike) here, as neither Y nor N are > >> fully accurate. > >> > >>> +| arch/x86/srat.c | Y | N | > >> > >> What about common/cpu.c? > >> > >>> +| common/libfdt/* (libfdt) | N | Y | > >>> +| common/lz4/decompress.c | N | Y | > >>> +| common/ubsan/ubsan.c | Y | Y | > >>> +| common/xz/* | N | Y | > >>> +| common/zstd/* | N | Y | > >>> +| common/bitmap.c | N | Y | > >>> +| common/bunzip2.c | N | Y | > >>> +| common/earlycpio.c | N | Y | > >>> +| common/inflate.c | N | Y | > >> > >> What about common/notifier.c? > >> > >>> +| common/radix-tree.c | N | Y | > >> > >> What about common/rcupdate.c? (Stopping at this in this regard: > >> It's unclear by what criteria you have gone. Even as simple an > >> indicator as "Copyright (C) ... Linus Torvalds" was apparently not > > Please see [1] > > > >> used. Similarly mentioning criteria for considering a file > >> "diverged" would be very helpful to spell out, even if there's > >> likely some fuzziness involved there.) > > > > We would need to pre-define some criteria to avoid having a long justifications. > > Any ideas? > > Well, changing just #include-s to fit Xen's model shouldn't count as > divergence. But coding style conversion already may. I'm afraid > criteria here depend very much on the purpose, and hence I don't > feel qualified to suggest any. Hi Jan, These two columns are not for MISRA's benefit. They are for our own benefit as maintainers of this code. We can define them the way we want to. MISRA doesn't allow us to make any exceptions to our coding guidelines for files originating from external sources (unless they are a proper library we link against, I don't think that even libfdt qualifies from what I understand.) We'll have to figure out what to do about that, but it is not something this patch is trying to solve. It is just trying to identify the external files. So the two columns are just for us as maintainers. It is only to help us, not to help with MISRA or with safety. So if you think we should word the first column differently, or even remove the first column entirely, we could. Maybe a better criteria for the first column would be: "do we accept changes to this file?" (direct changes, not backports) > >>> +| common/un*.c | N | Y | > >>> +| crypto/rijndael.c (OpenBSD) | N | Y | > >>> +| crypto/vmac.c (public domain) | N | Y | > >>> +| drivers/acpi/apei/* | N | Y | > >> > >> I'm not sure of the N here. > >> > >>> +| drivers/acpi/tables/* | N | Y | > >>> +| drivers/acpi/utilities/* | N | Y | > >>> +| drivers/acpi/hwregs.c | N | Y | > >>> +| drivers/acpi/numa.c | ? | Y | > >> > >> Y > >> > >>> +| drivers/acpi/osl.c | Y | Y | > >>> +| drivers/acpi/reboot.c | N | Y | > >>> +| drivers/acpi/tables.c | ? | Y | > >> > >> Y > >> > >> What about drivers/cpufreq/*, drivers/char/ehci-dbgp.c, > >> drivers/char/xhci-dbc.c, and drivers/video/font*? What about some of > >> the stuff under tools/, especially tools/kconfig/? > > > > [1] > > For the first shot, the criteria was to list files using different coding style than Xen, > > especially the ones using tabs instead of spaces. As I indicated before, the list may not be > > completed, hence a gentle ask to list the missing ones. Some of the files you mentioned > > use Xen coding style + there is no information in the git history that they originated from > > external sources. This is why, the maintainers who are the addressee of this RFC should have > > a better knowledge of the origin of such files. > > Hmm. Please forgive me being blunt, but to me this then looks like > offloading work to people who shouldn't be required to invest > meaningful amounts of time. But maybe that's just me viewing it this > way ... Yet this is particularly relevant if ... > > > As for the files under tools/, FWICS they are being filtered-out from MISRA checks, hence I > > did not list them. > > ... the goal here then indeed is use for MISRA alone. I did e.g. ask > whether it wouldn't be worthwhile to more precisely describe the > origin of files because at some point in the past it was also > proposed to arrange for some more automatic monitoring of changes > being applied at their origins for files we have cloned. Which > obviously first of all requires establishing an association between > our files and their origins. One of the goals has certainly to do with MISRA, but I think we would want to know which files are not conforming to the Xen coding style and coding guidelines anyway? For example, we need it to automate coding style checks for new patches with scripts like checkpatch. And you are right, also adding the origin of the files to help with backports and monitoring is a great idea. On the extra work: some of us in the community have been around for a long time. Without having to do any research, there are things you might remember on top of your head. If you don't remember, that's fine and we can try to do some investigation/archeology. From xen-devel-bounces@lists.xenproject.org Thu Nov 17 23:10:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 23:10:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445384.700528 (Exim 4.92) (envelope-from ) id 1ovo1p-00032C-HR; Thu, 17 Nov 2022 23:10:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445384.700528; Thu, 17 Nov 2022 23:10:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovo1p-000325-EP; Thu, 17 Nov 2022 23:10:41 +0000 Received: by outflank-mailman (input) for mailman id 445384; Thu, 17 Nov 2022 23:10:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovo1n-00031v-KQ; Thu, 17 Nov 2022 23:10:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovo1n-00083i-H0; Thu, 17 Nov 2022 23:10:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovo1n-0007py-0E; Thu, 17 Nov 2022 23:10:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovo1m-0005zz-Vl; Thu, 17 Nov 2022 23:10:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8W1BjgPdYOu1x7JKutnLSOcaoFnvn2yD3BVqWda9cmo=; b=34RftK5RTBBBWvAlQgaTjNONsp bDPKICrWFokOqqJ6fmM6IbclTnLqgw07ZdXcwi3acJ2NnL3eeezarFd5EH7Zq50uhO4JevnK8IzF7 xgY1AujPeJeYGt+9EHBRNZc7dlJ/ANMxLxtW1njMqlr7i6rhYeg38zNEPses/7C+UEi0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174804: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=cc675d22e422442f6d230654a55a5fc5682ea018 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 17 Nov 2022 23:10:38 +0000 flight 174804 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174804/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux cc675d22e422442f6d230654a55a5fc5682ea018 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 41 days Failing since 173470 2022-10-08 06:21:34 Z 40 days 69 attempts Testing same since 174794 2022-11-16 21:11:27 Z 1 days 3 attempts ------------------------------------------------------------ 1714 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 163145 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Nov 17 23:39:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 17 Nov 2022 23:39:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445391.700539 (Exim 4.92) (envelope-from ) id 1ovoTk-0005qh-Pr; Thu, 17 Nov 2022 23:39:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445391.700539; Thu, 17 Nov 2022 23:39:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovoTk-0005qa-ML; Thu, 17 Nov 2022 23:39:32 +0000 Received: by outflank-mailman (input) for mailman id 445391; Thu, 17 Nov 2022 23:39:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovoTj-0005qQ-Mo; Thu, 17 Nov 2022 23:39:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovoTj-0000Ez-L6; Thu, 17 Nov 2022 23:39:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovoTj-0001C9-5o; Thu, 17 Nov 2022 23:39:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovoTj-0000SA-5M; Thu, 17 Nov 2022 23:39:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LcY+Vx9U5qxgFrUWjS3O5R3B4sF4R2WiuzJlHt5syRw=; b=Y0kS6Nn9ePijwGQtgUQuaIOJmR 08baTC4UHbau5T1Lytsbpcd92WP0j76hZ2nwPHACXX8g4R0pI/AnyRITlBNPYLi0AED+PSMlRJ9/t UJIdJN27Vje74MsFI+oK3XHVVeqVrJ6IHt30BTrvRGbfQ1N6lA7D+RtWB7R/Ya7bTK28=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174806: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=db8fa01c61db0317a9ee947925226234c65d48e8 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Thu, 17 Nov 2022 23:39:31 +0000 flight 174806 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174806/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen db8fa01c61db0317a9ee947925226234c65d48e8 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174793 2022-11-16 18:03:31 Z 1 days Testing same since 174806 2022-11-17 20:01:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f5d56f4b25..db8fa01c61 db8fa01c61db0317a9ee947925226234c65d48e8 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Nov 18 02:00:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 02:00:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445403.700550 (Exim 4.92) (envelope-from ) id 1ovqgJ-0004hN-DC; Fri, 18 Nov 2022 02:00:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445403.700550; Fri, 18 Nov 2022 02:00:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovqgJ-0004hF-7Q; Fri, 18 Nov 2022 02:00:39 +0000 Received: by outflank-mailman (input) for mailman id 445403; Fri, 18 Nov 2022 02:00:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovqgI-0004h6-Ti for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 02:00:38 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ca46a538-66e4-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 03:00:35 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07F7823A; Thu, 17 Nov 2022 18:00:41 -0800 (PST) Received: from a015971.shanghai.arm.com (unknown [10.169.188.104]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 54A3A3F587; Thu, 17 Nov 2022 18:00:32 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca46a538-66e4-11ed-91b6-6bf2151ebd3b From: Jiamei Xie To: xen-devel@lists.xenproject.org Cc: Jiamei Xie , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Wei Chen Subject: Date: Fri, 18 Nov 2022 10:00:13 +0800 Message-Id: <20221118020013.125987-1-jiamei.xie@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Date: Thu, 17 Nov 2022 11:07:12 +0800 Subject: [PATCH] xen/arm: vpl011: Make access to DMACR write-ignore When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", Linux SBSA PL011 driver will access PL011 DMACR register in some functions. As chapter "B Generic UART" in "ARM Server Base System Architecture"[1] documentation describes, SBSA UART doesn't support DMA. In current code, when the kernel tries to access DMACR register, Xen will inject a data abort: Unhandled fault at 0xffffffc00944d048 Mem abort info: ESR = 0x96000000 EC = 0x25: DABT (current EL), IL = 32 bits SET = 0, FnV = 0 EA = 0, S1PTW = 0 FSC = 0x00: ttbr address size fault Data abort info: ISV = 0, ISS = 0x00000000 CM = 0, WnR = 0 swapper pgtable: 4k pages, 39-bit VAs, pgdp=0000000020e2e000 [ffffffc00944d048] pgd=100000003ffff803, p4d=100000003ffff803, pud=100000003ffff803, pmd=100000003fffa803, pte=006800009c090f13 Internal error: ttbr address size fault: 96000000 [#1] PREEMPT SMP ... Call trace: pl011_stop_rx+0x70/0x80 tty_port_shutdown+0x7c/0xb4 tty_port_close+0x60/0xcc uart_close+0x34/0x8c tty_release+0x144/0x4c0 __fput+0x78/0x220 ____fput+0x1c/0x30 task_work_run+0x88/0xc0 do_notify_resume+0x8d0/0x123c el0_svc+0xa8/0xc0 el0t_64_sync_handler+0xa4/0x130 el0t_64_sync+0x1a0/0x1a4 Code: b9000083 b901f001 794038a0 8b000042 (b9000041) ---[ end trace 83dd93df15c3216f ]--- note: bootlogd[132] exited with preempt_count 1 /etc/rcS.d/S07bootlogd: line 47: 132 Segmentation fault start-stop-daemon As discussed in [2], this commit makes the access to DMACR register write-ignore as an improvement. [1] https://developer.arm.com/documentation/den0094/c/?lang=en [2] https://lore.kernel.org/xen-devel/alpine.DEB.2.22.394.2211161552420.4020@ubuntu-linux-20-04-desktop/ Signed-off-by: Jiamei Xie --- xen/arch/arm/vpl011.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c index 43522d48fd..80d00b3052 100644 --- a/xen/arch/arm/vpl011.c +++ b/xen/arch/arm/vpl011.c @@ -463,6 +463,7 @@ static int vpl011_mmio_write(struct vcpu *v, case FR: case RIS: case MIS: + case DMACR: goto write_ignore; case IMSC: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 02:18:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 02:18:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445409.700560 (Exim 4.92) (envelope-from ) id 1ovqxy-0006Pv-Qx; Fri, 18 Nov 2022 02:18:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445409.700560; Fri, 18 Nov 2022 02:18:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovqxy-0006Po-O4; Fri, 18 Nov 2022 02:18:54 +0000 Received: by outflank-mailman (input) for mailman id 445409; Fri, 18 Nov 2022 02:18:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovqxx-0006Pi-Pg for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 02:18:53 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0602.outbound.protection.outlook.com [2a01:111:f400:fe02::602]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5775aed0-66e7-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 03:18:51 +0100 (CET) Received: from AS9PR06CA0117.eurprd06.prod.outlook.com (2603:10a6:20b:465::32) by DB9PR08MB9755.eurprd08.prod.outlook.com (2603:10a6:10:460::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.8; Fri, 18 Nov 2022 02:18:45 +0000 Received: from AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:465:cafe::23) by AS9PR06CA0117.outlook.office365.com (2603:10a6:20b:465::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 02:18:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT041.mail.protection.outlook.com (100.127.140.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 02:18:44 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Fri, 18 Nov 2022 02:18:44 +0000 Received: from 2ae82c93cf3e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 877ACF9B-A579-45AD-95BC-9E20087563DE.1; Fri, 18 Nov 2022 02:18:34 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2ae82c93cf3e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 02:18:34 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11) by AS2PR08MB8384.eurprd08.prod.outlook.com (2603:10a6:20b:55b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Fri, 18 Nov 2022 02:18:32 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f]) by AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f%3]) with mapi id 15.20.5834.006; Fri, 18 Nov 2022 02:18:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5775aed0-66e7-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XeKNsZd81dK3Efc+eP7a7vE9dsG/vOzNlEbgxtLeZgU=; b=AQlHsj71kz0EB1BHrhwIE9uiW1T1ccfRXKWLYgb/RwQIzo4rMN69sK8giwX4oFAuKcEsWpKsKkdpPcdhZLEt8zAUR+suX7Hxc+bECwYwKcxRWhV08pp1N1OwHl0ELFRA0aptMmiI/8jPG40bseSowwNvi0Tnko3Ynvh4vGWFL+Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bBAELTvCjT3tWE1UAD7hXF9vlTh44Pd7G7KmYirS5HienXlCmKEfcA1HSxZo6mEvYmCdaHS9zlkPZkcg/wTftygq21tMknMZmnrgwbixCCgXVchfAMu0YLsOIb5W33e0Zkb3AP2MlPQozyPMeg/V7nlKUKgnCaiZXUen83YmQd9XA7WuNuwQDvBH4Zr5ydzOTss6rUgqWayN03PZz/QHK86fNsO8lgCdkbIb+X5MUTUZoeyZyV0CBzUMwGj6PqF4hyte2SNKS5Bbqx0aKaRB3fadrYT0S4miAG8Q8EGXObPq9pZhjKrPfNjNfJv7cyGYmh0TMHMX7S/Y2dBauEk6bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XeKNsZd81dK3Efc+eP7a7vE9dsG/vOzNlEbgxtLeZgU=; b=VtwmfWOiiq26dAy00JpEpb+Do4n47x8OvqEvmfcFgbVvPG8C2q0VtWmuI2wyimoZ939Q1gl0J6YlOxBAX+ppIeGzzjOz4AqjNmnVeqtYf4uNinj0PyP5h1bN3D6LNUOL8p+ICGR6KZ8i/bjGRUYSds7qRkGFRNBJJyfwuS3kX0MnMLWpKtFTD9zcWjyKZG4FSg/DA4o4+D8mif/xYSmaZVbv0JivNm6Xen1pSqD5ljawJKM+zMQ4Hl9eiu4Fby66kcz5N5uqK96olPwxqFIBJkiJ08jQY57IqfSRgMZKmbVvoNSVd2phYpJ/DZGqjtZa5QMZH7NyO6JLGhmVJu2j0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XeKNsZd81dK3Efc+eP7a7vE9dsG/vOzNlEbgxtLeZgU=; b=AQlHsj71kz0EB1BHrhwIE9uiW1T1ccfRXKWLYgb/RwQIzo4rMN69sK8giwX4oFAuKcEsWpKsKkdpPcdhZLEt8zAUR+suX7Hxc+bECwYwKcxRWhV08pp1N1OwHl0ELFRA0aptMmiI/8jPG40bseSowwNvi0Tnko3Ynvh4vGWFL+Q= From: Jiamei Xie To: Jiamei Xie , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Wei Chen Subject: RE: [PATCH] xen/arm: vpl011: Make access to DMACR write-ignore Thread-Topic: [PATCH] xen/arm: vpl011: Make access to DMACR write-ignore Thread-Index: AQHY+vGVwMcRKiwWvE6rnRakCwDYs65D8jVg Date: Fri, 18 Nov 2022 02:18:31 +0000 Message-ID: References: <20221118020013.125987-1-jiamei.xie@arm.com> In-Reply-To: <20221118020013.125987-1-jiamei.xie@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 31FE5BE7F1144C4DBB2007BD0320A0FD.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7696:EE_|AS2PR08MB8384:EE_|AM7EUR03FT041:EE_|DB9PR08MB9755:EE_ X-MS-Office365-Filtering-Correlation-Id: f41cf04d-dd1f-43f0-10eb-08dac90b381d x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DQT1MDDURIvulH3adK18cF6atKsVIku6PCuEDyIQyvSfqAr22MszPhUtiTF67dee49zT7lLSRnv8PlVDmmJGYDQirXoZyRT3pY1XfJ2MCH4cwd+ccSLW5R9zvsb/A8MZsqq+LPY8yxJeFEBLy6+E6wB7ZbTbQnw2+LYAaRTGicUCjbuNXcZ2i22/Zu8njpiFo0ffUxpxR5zbFv43yyauS9RznUCkbrRPamceVL3jXt3ZltMuPOfGBDKi2SFJYVgvyNrelZfn5OuUUxnwilY4skiNUcWUd68ozOtnrO54YfXq2ukHx4eRaqn2kbTySDli0V2tZmn1/LndN214X1b1oOelEsEMSL21ZPCrE8kVBnqIoI5DjU6GrSyfhcrD38M+nSupqtKr2/lhlmJ1983ccf9J0S+6gLfxTh4BWABQM22rz6130o7PiOQDaKARCzD5qUg/tdMBKbdaymFXoTeQgUoLoE6st9BokFwf5V2AhY0Ardy74Y+8pSZC7YFD6mHB6k4PnDyDd39dwCh9EfHcH1DT8vBEMG9dDc64izwatCx0PdhAYuIfD+Hm9/CCvJ0mHu0FTWfVl5l49m+/SRaEAHBWbdNX3AxkgFvX+gJpWELzuwE+2oeCeEqgyxth0agqcuSQkL1+FZ398YdaF7/ZSaBhwzVV2lxHwoHhJQ7x9EzrWvz956HxVPxNaIa/Yaq1SiadCAx/Iu4i1+3Xe3ddSoCEoBNLGkZDSXnPvfHDhbEg3T3Vwcc+DSUZqDZHCrcNeanG1tRRm0aTHuoe7WEfqA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(366004)(136003)(396003)(451199015)(7696005)(9686003)(478600001)(26005)(53546011)(6506007)(71200400001)(66476007)(66556008)(110136005)(66446008)(186003)(54906003)(41300700001)(76116006)(66946007)(64756008)(4326008)(8676002)(316002)(83380400001)(966005)(33656002)(5660300002)(8936002)(38100700002)(55016003)(52536014)(2906002)(86362001)(122000001)(38070700005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8384 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: da068da2-9724-45e3-fbdf-08dac90b3068 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j5IAgqr9zmxjj3kN3i8cTuJn9fwvDY/NBj3bP7DPs2CinlteznxM1KxO35ljsfWxnp3ubH06gD4HhXdksZOWaMAxmY1A7d066a7dGqESA0BDa/QNnJpKJTvBzGlvVTcBojZ+bC+uncbKYL4uU2v+LseoeBoWomm2PRfDGSjMahL6OxGtgZVr1h+AeD7D9jPPSAtmbU/K96nHKjS2+gUVmOfTGRLm1DDnYh/C9ZXkjFe0UTTSpmgjp8pMu9wCV+lY8k6JA78rMfvo2sRywxZ+TAA3jwJfoZdAYjrVC0zggs9BK2JjIQXE8nN7ouBc4q3hS82mwdz7tSfjrb6ZuXrZ6CYXjMovspdBPApY0X2qA430IfyFuzBcGhFttgdlBT7P4sr5KdlI9YQPOZ+AXWf417VUgDstAmlX0M60uecxA98qtQ/oFBfJQMkcjsBzTfdmeJr+QhGBw0gS2ya9S2c1PbniXIE9Mrkb5ajWt8Ia0LUhrDMWv8QuLDiEC0H02fcumnJ23RAQeKh09H60rGgw2OWq/USR+EMvFNRd1lHDSapdRN2+HG47fuKXybbY/sMtUDiEM/DgpCM542viy9AzhEAVZba3wMGnNrDdldkrN2KXdTYv7UNidbpujg8ElsbslGimS6WWcRaP6Emeg+d0w9jqcqye0qwUrvSX0XLY1S0zx8zEs/e4sseLqk49SkvDuaRXHtF/06++xhuYPJijEMHgGj1g/9/M7GoCcR0eoQOcB4eYbkluiNNmNDlJxxODz1uD+ylTnUljMXO1NSxXUA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(376002)(396003)(451199015)(36840700001)(40470700004)(46966006)(81166007)(82310400005)(41300700001)(356005)(4326008)(70586007)(8676002)(52536014)(36860700001)(83380400001)(40480700001)(8936002)(316002)(7696005)(6506007)(478600001)(9686003)(86362001)(33656002)(966005)(26005)(54906003)(47076005)(55016003)(186003)(2906002)(336012)(5660300002)(70206006)(82740400003)(53546011)(40460700003)(110136005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 02:18:44.8973 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f41cf04d-dd1f-43f0-10eb-08dac90b381d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9755 Hi=20 Sorry there is no subject in the last email. So add in this one. Best wishes Jiamei Xie > -----Original Message----- > From: Jiamei Xie > Sent: Friday, November 18, 2022 10:00 AM > To: xen-devel@lists.xenproject.org > Cc: Jiamei Xie ; Stefano Stabellini > ; Julien Grall ; Bertrand Marquis > ; Volodymyr Babchuk > ; Wei Chen > Subject: >=20 > Date: Thu, 17 Nov 2022 11:07:12 +0800 > Subject: [PATCH] xen/arm: vpl011: Make access to DMACR write-ignore >=20 > When the guest kernel enables DMA engine with > "CONFIG_DMA_ENGINE=3Dy", > Linux SBSA PL011 driver will access PL011 DMACR register in some > functions. As chapter "B Generic UART" in "ARM Server Base System > Architecture"[1] documentation describes, SBSA UART doesn't support > DMA. In current code, when the kernel tries to access DMACR register, > Xen will inject a data abort: > Unhandled fault at 0xffffffc00944d048 > Mem abort info: > ESR =3D 0x96000000 > EC =3D 0x25: DABT (current EL), IL =3D 32 bits > SET =3D 0, FnV =3D 0 > EA =3D 0, S1PTW =3D 0 > FSC =3D 0x00: ttbr address size fault > Data abort info: > ISV =3D 0, ISS =3D 0x00000000 > CM =3D 0, WnR =3D 0 > swapper pgtable: 4k pages, 39-bit VAs, pgdp=3D0000000020e2e000 > [ffffffc00944d048] pgd=3D100000003ffff803, p4d=3D100000003ffff803, > pud=3D100000003ffff803, pmd=3D100000003fffa803, pte=3D006800009c090f13 > Internal error: ttbr address size fault: 96000000 [#1] PREEMPT SMP > ... > Call trace: > pl011_stop_rx+0x70/0x80 > tty_port_shutdown+0x7c/0xb4 > tty_port_close+0x60/0xcc > uart_close+0x34/0x8c > tty_release+0x144/0x4c0 > __fput+0x78/0x220 > ____fput+0x1c/0x30 > task_work_run+0x88/0xc0 > do_notify_resume+0x8d0/0x123c > el0_svc+0xa8/0xc0 > el0t_64_sync_handler+0xa4/0x130 > el0t_64_sync+0x1a0/0x1a4 > Code: b9000083 b901f001 794038a0 8b000042 (b9000041) > ---[ end trace 83dd93df15c3216f ]--- > note: bootlogd[132] exited with preempt_count 1 > /etc/rcS.d/S07bootlogd: line 47: 132 Segmentation fault start-stop-daemon >=20 > As discussed in [2], this commit makes the access to DMACR register > write-ignore as an improvement. >=20 > [1] https://developer.arm.com/documentation/den0094/c/?lang=3Den > [2] https://lore.kernel.org/xen- > devel/alpine.DEB.2.22.394.2211161552420.4020@ubuntu-linux-20-04- > desktop/ >=20 > Signed-off-by: Jiamei Xie > --- > xen/arch/arm/vpl011.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c > index 43522d48fd..80d00b3052 100644 > --- a/xen/arch/arm/vpl011.c > +++ b/xen/arch/arm/vpl011.c > @@ -463,6 +463,7 @@ static int vpl011_mmio_write(struct vcpu *v, > case FR: > case RIS: > case MIS: > + case DMACR: > goto write_ignore; >=20 > case IMSC: > -- > 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 02:36:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 02:36:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445415.700571 (Exim 4.92) (envelope-from ) id 1ovrET-0000ig-CJ; Fri, 18 Nov 2022 02:35:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445415.700571; Fri, 18 Nov 2022 02:35:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovrET-0000iZ-9l; Fri, 18 Nov 2022 02:35:57 +0000 Received: by outflank-mailman (input) for mailman id 445415; Fri, 18 Nov 2022 02:35:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovrER-0000iT-GH for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 02:35:55 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b7ffdda5-66e9-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 03:35:53 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 321B6320005D; Thu, 17 Nov 2022 21:35:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 17 Nov 2022 21:35:50 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Nov 2022 21:35:48 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7ffdda5-66e9-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1668738949; x=1668825349; bh=iXS5rnNN6KGyRE2PJSOSu9Q5tR9SxGRz/NB oxnHnE3o=; b=L3k1ECDbPMHp6Av60+4MBAOrax9uhhonBcOHlRj9ixsjSLE+vUY P46kjBipf/utAb0pXW3HKd4JUCaKZf0EDQRC4wVZxtHN1CUX8TuCWjzQCq1moxqy wMBb+rhTbTyFTXWGxUtwtry0wUHqh/PlWfnOIKT4NQll1PH4lRQz1OOLNO6HwBUM T1OEqBPtsPxMeZpNmLNst4uThX8b3wr29YhBw9Tw90Mx3HoCCVPb0ZEgdZYsJOXx 4jYvvMxRCSB6HBBQVe2y+Hl9gIi5l0aCOzMQvBzJgmuGnHUNZr9xBLFYGISjLtjT o/k6B5f+QBRBd8kv5uw2IbuQVY8pES6IMig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1668738949; x=1668825349; bh=iXS5rnNN6KGyR E2PJSOSu9Q5tR9SxGRz/NBoxnHnE3o=; b=l/wqCKL7HkibTjVT9rTeM96zNNg9i bUrp7eu4RoKTTWCmBp6GJKX+tMoKdvUsCkr80t0Y1u4hX2jNTfzxSd8SKf8ENDuc He9kmBbOEC8cyl2ZVZoD9Hfk4nk8E09RYr87FLtVl7OHq8RbSR97EcptVTI7Pu7U YMGPf34RwoM5R+vqgOonA5mtVv4pf/2VB9Rt/83rmYEk2yRgTpDqWN9J7tP9ewoM Npm97cs1YjrVquZZqMDshBmKI2m1mTUQUCzPIyMmqsznC9E0qU7VvEHMhN0/2U2G qiKTzte/ZcrNAkCP5mumX/od61/+wJDaNTd/J49MLnXZWcRfiVJZPL+mg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgeelgdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffogggtgfesthekredtredtjeenucfhrhhomhepofgrrhgvkhcu ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepleekhfdu leetleelleetteevfeefteffkeetteejheelgfegkeelgeehhfdthedvnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR INTERFACE) Subject: [PATCH v2] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled Date: Fri, 18 Nov 2022 03:35:30 +0100 Message-Id: <20221118023535.1903459-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until the table is filled. Then it disables INTx just before clearing MASKALL bit. Currently this approach is rejected by xen-pciback. According to the PCIe spec, device cannot use INTx when MSI/MSI-X is enabled. Change the logic to consider INTx disabled if MSI/MSI-X is enabled. This applies to two places: checking currently enabled interrupts type, and transition to MSI/MSI-X - where INTx would be implicitly disabled. Fixes: 5e29500eba2a ("xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKALL too") Signed-off-by: Marek Marczykowski-Górecki --- drivers/xen/xen-pciback/conf_space.c | 19 +++++++++++++------ .../xen/xen-pciback/conf_space_capability.c | 3 ++- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/xen/xen-pciback/conf_space.c b/drivers/xen/xen-pciback/conf_space.c index 059de92aea7d..d47eee6c5143 100644 --- a/drivers/xen/xen-pciback/conf_space.c +++ b/drivers/xen/xen-pciback/conf_space.c @@ -288,12 +288,6 @@ int xen_pcibk_get_interrupt_type(struct pci_dev *dev) u16 val; int ret = 0; - err = pci_read_config_word(dev, PCI_COMMAND, &val); - if (err) - return err; - if (!(val & PCI_COMMAND_INTX_DISABLE)) - ret |= INTERRUPT_TYPE_INTX; - /* * Do not trust dev->msi(x)_enabled here, as enabling could be done * bypassing the pci_*msi* functions, by the qemu. @@ -316,6 +310,19 @@ int xen_pcibk_get_interrupt_type(struct pci_dev *dev) if (val & PCI_MSIX_FLAGS_ENABLE) ret |= INTERRUPT_TYPE_MSIX; } + + /* + * PCIe spec says device cannot use INTx if MSI/MSI-X is enabled, + * so check for INTx only when both are disabled. + */ + if (!ret) { + err = pci_read_config_word(dev, PCI_COMMAND, &val); + if (err) + return err; + if (!(val & PCI_COMMAND_INTX_DISABLE)) + ret |= INTERRUPT_TYPE_INTX; + } + return ret ?: INTERRUPT_TYPE_NONE; } diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xen/xen-pciback/conf_space_capability.c index 097316a74126..eb4c1af44f5c 100644 --- a/drivers/xen/xen-pciback/conf_space_capability.c +++ b/drivers/xen/xen-pciback/conf_space_capability.c @@ -236,10 +236,11 @@ static int msi_msix_flags_write(struct pci_dev *dev, int offset, u16 new_value, return PCIBIOS_SET_FAILED; if (new_value & field_config->enable_bit) { - /* don't allow enabling together with other interrupt types */ + /* don't allow enabling together with other interrupt type */ int int_type = xen_pcibk_get_interrupt_type(dev); if (int_type == INTERRUPT_TYPE_NONE || + int_type == INTERRUPT_TYPE_INTX || int_type == field_config->int_type) goto write; return PCIBIOS_SET_FAILED; -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 04:28:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 04:28:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445421.700583 (Exim 4.92) (envelope-from ) id 1ovszV-0004go-9V; Fri, 18 Nov 2022 04:28:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445421.700583; Fri, 18 Nov 2022 04:28:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovszV-0004gh-6A; Fri, 18 Nov 2022 04:28:37 +0000 Received: by outflank-mailman (input) for mailman id 445421; Fri, 18 Nov 2022 04:28:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovszT-0004gV-6A; Fri, 18 Nov 2022 04:28:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovszS-00069G-V3; Fri, 18 Nov 2022 04:28:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovszS-0000BM-IL; Fri, 18 Nov 2022 04:28:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovszS-0006y8-Fq; Fri, 18 Nov 2022 04:28:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5jmUNvV2b5s1smZKSJGe60d0ONN/Kc/b+GulBnQB/Uc=; b=gToIm7XxTauZhuRwuXokM8EmRV EJB1MfWVoCPuBYXi4SIR10dYlY+q92ljmHmwdyVa1tTZi/2hirrWdGU4/jcXro/smbqOLDS7aBuR8 U/ZeyqDif7oqOHiT1rMXeAksF/TjjiiTAdRNLTuvR0Ep9RwbhYTC3GdN2nQhDyNTWWak=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174807: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=a082fab9d259473a9d5d53307cf83b1223301181 X-Osstest-Versions-That: qemuu=2c8311241d1f7377bb4ff76064b1d1fe15166413 From: osstest service owner Date: Fri, 18 Nov 2022 04:28:34 +0000 flight 174807 qemu-mainline real [real] flight 174810 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174807/ http://logs.test-lab.xenproject.org/osstest/logs/174810/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 174810-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174788 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174788 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174788 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174788 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 174788 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174788 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174788 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174788 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174788 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu a082fab9d259473a9d5d53307cf83b1223301181 baseline version: qemuu 2c8311241d1f7377bb4ff76064b1d1fe15166413 Last test of basis 174788 2022-11-16 04:59:05 Z 1 days Testing same since 174807 2022-11-17 20:37:12 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ani Sinha Daniel Henrique Barboza Daniel P. Berrangé Kowshik Jois B S Stefan Hajnoczi Thomas Huth Vaibhav Jain jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 2c8311241d..a082fab9d2 a082fab9d259473a9d5d53307cf83b1223301181 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Nov 18 07:20:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 07:20:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445442.700594 (Exim 4.92) (envelope-from ) id 1ovvfj-00086c-Br; Fri, 18 Nov 2022 07:20:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445442.700594; Fri, 18 Nov 2022 07:20:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovvfj-00086V-8m; Fri, 18 Nov 2022 07:20:23 +0000 Received: by outflank-mailman (input) for mailman id 445442; Fri, 18 Nov 2022 07:20:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovvfh-0007xL-L2 for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 07:20:21 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0608.outbound.protection.outlook.com [2a01:111:f400:fe0c::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 74b36ab6-6711-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 08:20:19 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7064.eurprd04.prod.outlook.com (2603:10a6:20b:118::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 18 Nov 2022 07:20:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 07:20:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74b36ab6-6711-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S0gwI8u69DMsmJEz6MQetvhd2WaOUfYcnSPZAsKnGtvbjBrytgiS4zaRO9cCLbyjpDrc7p7KlQQggzGQrckOs/w7g3LnauJTQkNzQh/yUDGJ6PuwRsE9hZWyQS/TEQzvrwMF1GdyQdmg6hJeahrScU/Zg+nyAwXw5w9rioa1LwgVfLSG1X2Bmtq18oBW+Km5IJ6+eAiBqRwIJAWBNYPEnGwDHbheXm9wP15zKJIzDE92TPlYix/HzYxpLm9FzrKFd3KRI99q/RTIgfumQ/G5nIBFKA2juv3fa0aD+yA7dRNk6EC97ildWgI8lROmol+syBbkfGa2Zo4SXM92vMTl9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1mb2x508X+9y63QKlaQN5o+Rq3EAdZFCsk4rNaOj5IE=; b=dmz0tZ2hzgIqi2a/GlY5zAwgJuAlFuBPv1D/Ov2+R2hAXUSrTtepSMCwsDInq0s8U3yL9xRp9M4PBdNIRRjmcctsa2u9+CVfTqHTPbCW+qcI4JlFNHxf6jI0kcF7hK8gfNIofsBeFaCeTc37J1U2lkBLHBUf+c5B2jsrT6pmG24TH8xlGhuVWeISEqi5NYj0PC1+WFJaqu562zgaZFG7mzcLhVmahXmNt+dIEGP289TSZsuRu6D+/SgshIyShzNzy//74Jn22a/z7hdmbPZ7We36FOCMTXN6oWQYmKbk/loTRCp7H7FNhYz2u07C97HRTARfHceUYZzqNlhkRKAhGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1mb2x508X+9y63QKlaQN5o+Rq3EAdZFCsk4rNaOj5IE=; b=mGf50q62sGaV8C+sEZ9wY+h1PjCVUxKh99QOqmKCDMmqjH0Y+mZy9uCT1Mic7Zo2lkuP0KZZEA2ULGxfNf4B0yqIRhrwUJx42f2FUFOM86OVnM02d/7nLz9ygyP/Njh2I00IAAiSWV16GPCg3Bfllfd2UyRnj3P3XTLYmyvNQzPQ2ROlFNVMSKJODGPuvFUDmQDQArimTc4Zw3JuyIt084GME/TGunZtveJuAE+D8xl4kGFSSfw6yFmOJPUwuSlm61DqEvETWWDH+bo9Udoe9QGDfX5/KLh9MyCOEy0wq9lH2nsWsOzanRkmBCyyRnH1kgLxBLWhg3JR3AHmpTvGsQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 18 Nov 2022 08:20:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/2] x86/msi: Allow writes to registers on the same page as MSI-X table To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20221114192100.1539267-1-marmarek@invisiblethingslab.com> <20221114192100.1539267-2-marmarek@invisiblethingslab.com> <15138618-5cb0-8304-a56b-cb787e187772@suse.com> Content-Language: en-US From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0050.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7064:EE_ X-MS-Office365-Filtering-Correlation-Id: 5182fecf-3d1b-4e99-c5f9-08dac9355722 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cRiwDJNAWpdjs0jL7bVflWwpLjfvH+WTkzay5kAQrIPAJnaYsSKmaqQoq/xWBc3NJXtjEdwHvMsb1VdtBf4OaoVOyXFQLt1klImxx5DLudTHseoR4aZTHHK2PI9K2bvHYoPugE69vxwN8vGDkqk5T/RnhJ9/DN/ur8Smj6Xof6ef0Pp+EQ5mjnw2RtSAuEvJiQb2Ecg2fmdjgWHcX96t726r2v5zY04V2YnMwImTG3Tgqbr4fPxZ3hTqY86STqFHn6ih12AR5AUEuYQr5y4wrDuLtG9OJU5a45wB78pLiyNNYtHb+qHR5PY1ziw1+3ehqQ1fb5Vhv1rTttRVQSZ8vSk8y7x5hVxwh7UmvAuldItTV1Fdq2gFmWVo8gbgA4z1EZAlLUjuk5daS4pAlNgkba1GIgd68HJbGnHkvvDVzZV8rDZNjDAwHWSb/LBrQoV8EWAFeesEtgg0BXAW36PeR3ELljza5tjU8Z9wHqbsTLm3mUyD1funr+DT4Z9gihpyKymTiYGc7r8VE8sw+57euf9bX2PRI79z57ie5HHu9+N7L5uPW8iQEECef0kfu4NFrl4J6Rs5AiWnhJO/Qkq4X7CGA15d83kEiwWfEgWuWWhoj+UU7XBdw+BueOob/4dUGB/WbLLrk1p/v+ZBUfWIAi5H1DdpdbQtQmDE/pO/FAXwrrzE79eXCJCMuchQOslVtniQlA1Gw4so4b7XzQvAEy8ScZbUGaPr9+CLoM/Go9ns+fIByvA0KHFsvkPGSpBy X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(376002)(136003)(346002)(396003)(451199015)(31686004)(2906002)(83380400001)(66899015)(36756003)(41300700001)(2616005)(8936002)(86362001)(31696002)(66556008)(38100700002)(6512007)(6506007)(6916009)(53546011)(54906003)(26005)(186003)(5660300002)(66476007)(66946007)(8676002)(66574015)(4326008)(316002)(6486002)(478600001)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cll3OFQ3U05xNStPZ1ZObldWYWh3THBRbDNnUG5YS2NWdENZLy9kbHZHM3lN?= =?utf-8?B?ckk4NTJxTm5PNGp4YTJrZHNiL2J3NjZ6OW1HL3VsWGtPemdMN293UTdVdkRr?= =?utf-8?B?QWJicWVBMUlsdGhlYVhLeTlVU3dOQzA3QStYTy9jOTVNTnlMc2doektsTmFm?= =?utf-8?B?dCtGRlVNajB4R0YvSWRxMkN3ZkhGNVRXWml1Z3RzM0VVZ0VKSzVhUDNBOS9O?= =?utf-8?B?YzNmM2MxK3JSS2VJa0lvWXNtN0ZWdUtDb25pSmpMVDBWVHFueE5CMFN1TnNC?= =?utf-8?B?Q0wwT1VrRXovZkFxSGVYRU5vM3YzSEg4MFhRMng1M1JDZ1QwVVB4dXNaa2E0?= =?utf-8?B?ZmUxSjY5SERodDJoUks3clBBSTdsSWhDN2I5cFZXbVVHeWdMOXNITUs2UHRF?= =?utf-8?B?QndZOUJVZjRoV0xPNmlENi9kZEdCdzhYWTIvOXVXbmdQMmtNdUR2RjZWWk5i?= =?utf-8?B?VmRxcUhQVlhzcXltbFFlTW0wdlFZNjJoUDR3YUZta1hTVmxESVdzVjkzczFG?= =?utf-8?B?NU9oWTI4bnJsQU94OHZvTWs2d0VESXcvZnMwVmsvTUZoODZneFFFU0RIaEtD?= =?utf-8?B?QUpjdEpsanM5RlExRkFTNXZVUWpWa3pKcEd2UW9oTUV4d3BHU2w2SkNNbmFZ?= =?utf-8?B?YkxTWXJMZnArUUx0UStaMjdYdnlsWGkxOWRvTm1LckJqWnlHMzZSVWxxMDQ0?= =?utf-8?B?V3FWOEdMdGF2MWZ2VmZ4d1NrdXJnYnp2YWI5NlFLYkE2bHhYbDZiK3l0aXZI?= =?utf-8?B?U3RQVVZ6d3BRc0FsdDNwMTh4WG45RWliVm16NTdBN1dwY0RCK2RGUm43TUNK?= =?utf-8?B?M2lqeWpqZEVucWZvclpGZlYzNnZkTitvd0t1NUIydEN2RFRyU0xiQjFEMDZU?= =?utf-8?B?dTZuZnRSN2FCRkhzS3NpNmxnbll2K0JKeFV2R2UyckN4VmRhU0sxWkFZNlV0?= =?utf-8?B?NE84QWNWN2IyS09BSVp4MWQwdWJqRjBCbkdzTERjSDBPdWpaekFCd083UlM5?= =?utf-8?B?VWFzK1BsWmZ4K1NQWHN6TUUvdWtDcnBzWFQySzVhMDFYWCtUUnZwcWhOUEw4?= =?utf-8?B?M3lvYWI1ME1EbWdQZUR4RGtDZVJWV0JtbzNFd1JpeEJSeS9kRGNiVC81RXN0?= =?utf-8?B?RHo4RU5FODVsRDkxNHZ2Q0NvUDVRcHdna3N2Z241Rkx0ck5IOE5BQ0QxV0tM?= =?utf-8?B?N1NKRUs3dzJSTHNQMk52UFNQcXpCbnArK1F2UGVDTENsbk1tUmp4cklMUVM2?= =?utf-8?B?R24vZkZKTThNSmpQMHdLM2dNcDNnSlBLdkxJNy94WkFLOXJoZjNaeVIwQXgw?= =?utf-8?B?RzA0M3hjQ2Y4TkVsQ1VlSHJNd045T21LWGwxYmRJdTVvL0ZCM3M1MStGRUtH?= =?utf-8?B?US9YVm5zZVNuZWFaV1RrWVJPb3c1N3JtdUMwQ3lxNXQwd1FrZ3NtMlBkcG8z?= =?utf-8?B?dWN5N3IrL0hLVDFZR3QzU2x1QXpkL3V0RnBHSytJREdEcWludnFVTFJlWmVH?= =?utf-8?B?SG9vS0VkT3lJcE8rK3RxbnlFeHNTaUtpVjdwaHlIbzh3NjE2aHVlUUM5Qy9T?= =?utf-8?B?VkkzQmFITVJvOFMvcTl6WFRXZXVMeGNDUEhNZk1aL01XZVhzOUtMbzdoSUlG?= =?utf-8?B?akVyRm4rMUllQm9hRFIrYnNkdG9aeWlxMGNCNUVRemk1REt4RXRoRG12a3JE?= =?utf-8?B?SFVEMVptaFdHUHpuNGg2ZDhwY0JOMXN6YnJYanpKbU9CQmQ0WlFPbVppMXJJ?= =?utf-8?B?b1l5TUtzY2NVeHBQcnNFUXF3ZEVaTWhwSURTMXVsLzNLV2xKa21GT0tzdmli?= =?utf-8?B?ak9KMllEZGVldEFrdEE5WFpBenVMKyt5OHpqQU1hQUFpWHJXRG40NGtGc3RT?= =?utf-8?B?T2d0OEFGaWExeDN0dDJKUHlXYW5IQjdjdlpUQ3dOYW10RGUxYUFPcmVPdVpE?= =?utf-8?B?TlFnTXVXbGsxVEFYNXJ5VGZOYXJscGV4V0dLU0hNWlAyajZnUWVNeXpnd1Q3?= =?utf-8?B?YTN4dlFOTEI1V2xFRkVyUDZoTkExRG56VjVnd3lheXV0NnJwbWRFclo1Y0Fh?= =?utf-8?B?QjZUUGVrMzN3K3RJQW1IWTFVSHNpZkFiSWRGZ0xqOXh3bW5idzlldmFPc1JC?= =?utf-8?Q?iWPfG6SEfTrHmZWnfY5MoROEO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5182fecf-3d1b-4e99-c5f9-08dac9355722 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 07:20:16.0255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x5PcWGOOm4UsaWGXkoqeTOYJLETwBapeZn71ydEGj6TM/d6pZ1s7XrImpb4dmDwpcU4lyawUKlEiUo1RR/ONCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7064 On 17.11.2022 18:31, Marek Marczykowski-Górecki wrote: > On Thu, Nov 17, 2022 at 05:34:36PM +0100, Jan Beulich wrote: >> On 14.11.2022 20:21, Marek Marczykowski-Górecki wrote: >>> --- a/xen/arch/x86/msi.c >>> +++ b/xen/arch/x86/msi.c >>> @@ -961,6 +961,21 @@ static int msix_capability_init(struct pci_dev *dev, >>> domain_crash(d); >>> /* XXX How to deal with existing mappings? */ >>> } >>> + >>> + /* >>> + * If the MSI-X table doesn't span full page(s), map the last page for >>> + * passthrough accesses. >>> + */ >>> + if ( (msix->nr_entries * PCI_MSIX_ENTRY_SIZE) & (PAGE_SIZE - 1) ) >>> + { >>> + uint64_t entry_paddr = table_paddr + msix->nr_entries * PCI_MSIX_ENTRY_SIZE; >>> + int idx = msix_get_fixmap(msix, table_paddr, entry_paddr); >>> + >>> + if ( idx >= 0 ) >>> + msix->last_table_page = fix_to_virt(idx); >>> + else >>> + gprintk(XENLOG_ERR, "Failed to map last MSI-X table page: %d\n", idx); >>> + } >> >> Could we avoid the extra work if there's only less than one page's >> worth of entries for a device? But then again maybe not worth any >> extra code, as the same mapping will be re-used anyway due to the >> refcounting that's being used. > > I was considering that, but decided against exactly because of > msix_get_fixmap() reusing existing mappings. > >> Makes me think of another aspect though: Don't we also need to >> handle stuff living on the same page as the start of the table, if >> that doesn't start at a page boundary? > > I have considered that, but decided against given every single device I > tried have MSI-X table at the page boundary. But if you prefer, I can > add such handling too (will require adding another variable to the > arch_msix structure - to store the fixmap location). To limit growth of the struct, please at least consider storing the fixmap indexes instead of full pointers. >>> @@ -1090,6 +1105,12 @@ static void _pci_cleanup_msix(struct arch_msix *msix) >>> WARN(); >>> msix->table.first = 0; >>> msix->table.last = 0; >>> + if ( msix->last_table_page ) >>> + { >>> + msix_put_fixmap(msix, >>> + virt_to_fix((unsigned long)msix->last_table_page)); >>> + msix->last_table_page = 0; >> >> To set a pointer please use NULL. > > Ok. > >> Overall it looks like you're dealing with the issue for HVM only. >> You will want to express this in the title, perhaps by using x86/hvm: >> as the prefix. But then the question of course is whether this couldn't >> be dealt with in/from mmio_ro_emulated_write(), which handles both HVM >> and PV. > > The issue is correlating BAR mapping location with guest's view. > Writable BAR areas are mapped (by qemu) via xc_domain_memory_mapping(), but > that fails for read-only pages (and indeed, qemu doesn't attempt to do > that for the pages with the MSI-X table). Lacking that, I need to use > msixtbl_entry->gtable, which is HVM-only thing. > > In fact there is another corner case I don't handle here: guest > accessing those registers when MSI-X is disabled. In that case, there is > no related msixtbl_entry, so I can't correlate the access, but the > page(s) is still read-only, so direct mapping would fail. In practice, > such access will trap into qemu, which will complain "Should not > read/write BAR through QEMU". I have seen this happening several times > when developing the series (due to bugs in my patches), but I haven't > found any case where it would happen with the final patch version. > In fact, I have considered handling this whole thing via qemu (as it > knows better where BAR live from the guest PoV), but stubdomain still > don't have write access to that pages, so that would need to be trapped > (for the second time) by Xen anyway. > > For the PV case, I think this extra translation wouldn't be necessary as > BAR are mapped at their actual location, right? I think so, yes. > But then, it makes it > rather different implementation (separate feature), than just having a > common one for PV and HVM. It would be different, yes, and if - as you explain above - there are technical reasons why it cannot be shared, then so be it. Mentioning this in the description may be worthwhile, or else the same question may be asked again (even by me, in case I forget part of the discussion by the time I look at a particular future version). >> Which in turn raises the question: Do you need to handle reads >> in the new code in the first place? > > The page not being mapped is also the reason why I do need to handle > reads too. Just for my own clarity: You mean "not mapped to qemu" here? Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 18 07:24:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 07:24:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445448.700605 (Exim 4.92) (envelope-from ) id 1ovvjS-0000JH-0T; Fri, 18 Nov 2022 07:24:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445448.700605; Fri, 18 Nov 2022 07:24:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovvjR-0000JA-SW; Fri, 18 Nov 2022 07:24:13 +0000 Received: by outflank-mailman (input) for mailman id 445448; Fri, 18 Nov 2022 07:24:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovvjR-0000J4-0m for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 07:24:13 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060a.outbound.protection.outlook.com [2a01:111:f400:7d00::60a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fe6bbaf6-6711-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 08:24:10 +0100 (CET) Received: from DB6PR0402CA0010.eurprd04.prod.outlook.com (2603:10a6:4:91::20) by AS8PR08MB6229.eurprd08.prod.outlook.com (2603:10a6:20b:295::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.8; Fri, 18 Nov 2022 07:23:59 +0000 Received: from DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:91:cafe::b8) by DB6PR0402CA0010.outlook.office365.com (2603:10a6:4:91::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Fri, 18 Nov 2022 07:23:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT019.mail.protection.outlook.com (100.127.142.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 07:23:58 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Fri, 18 Nov 2022 07:23:58 +0000 Received: from 3390b3204ecb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C681113F-00C2-46B5-A530-4F516327FBEC.1; Fri, 18 Nov 2022 07:23:51 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3390b3204ecb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 07:23:51 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by PAVPR08MB9083.eurprd08.prod.outlook.com (2603:10a6:102:325::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.8; Fri, 18 Nov 2022 07:23:49 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::f1f:9833:4db3:45a5]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::f1f:9833:4db3:45a5%5]) with mapi id 15.20.5857.008; Fri, 18 Nov 2022 07:23:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe6bbaf6-6711-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Njh4Ebq0MieMmAh+x0JIcpyOp86UX3Tu/y5PfSFeCHA=; b=MFO5r4LIc4knEBedY3bPb5FB6x4tYZZaBygxXw6DynUGiU6U0qOxMurw0KjLXYkiMsqz+wwNnKtME0cERxA/1ZhrW7HZEIhls71C2enuaK9uGDqeFqskUn0gEakdMjL0rr6Qi4rdIa3YC1eq2II3qESlPJLU9jYuTlzGFrTE+LU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O1pAEocPjQGvTFIw1SclwIdYz3XEQCOdj1lIzB9J4yy3s1XKvIYJF8FQjI6R9yABOBW39YILWyzPj+Q+GMgi0mILVJxRL7sbXRYgmkMI6MHspjGWlaCeXL49E4dIEXZ/r10WBgbALiXb+lW/sJsvrFacfZG0Beb2Oo1hE2yBHJlYjNYImsif5qBxuMp2JT0kuxn7ylq2RbWS2bW5TCoAq8f9HVPRJhDFXzy9zhcZiSE68j5Nejr9b0PXLl7JW+HNfPtx1ASoWMhV1+O8khsoiv53ifiILyHH4wSwe+xYeN8je+ce5l55OL8qLqVAegx0BRUnErbk5JY6KJ9IGyhCig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Njh4Ebq0MieMmAh+x0JIcpyOp86UX3Tu/y5PfSFeCHA=; b=QacOTd6b7kwLHhCBuutAMn1/N+PuB1KA+wvw5j60NZiCNtM7viTJBifBg9m21DRmtf3htXN0gDPyMWXPhGWMO+7YqFYCe5KC9FZFwnkjfhry5xLOJgTFynEiERPgCWnAQyuT/n0dI+f4ZcigfXD0Gupd9DmrLPb8AAsJE1gG9m5zZC5MWTeoLgL1ynASC03UFv7AegdKeIJrlwZf5X7xxtdk4Bq6x1fKKsC+k6boDGccSfgbNzldtZ6JVEvCMazYfBwKu0EaUUR7HzekbsNoNLRlBJ2HsVgR+wcy4vyLQjAJM+55FIU1nwAl0g63txMfDQTpV3HzaEbILXc4wLkawQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Njh4Ebq0MieMmAh+x0JIcpyOp86UX3Tu/y5PfSFeCHA=; b=MFO5r4LIc4knEBedY3bPb5FB6x4tYZZaBygxXw6DynUGiU6U0qOxMurw0KjLXYkiMsqz+wwNnKtME0cERxA/1ZhrW7HZEIhls71C2enuaK9uGDqeFqskUn0gEakdMjL0rr6Qi4rdIa3YC1eq2II3qESlPJLU9jYuTlzGFrTE+LU= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v8 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common Thread-Topic: [PATCH v8 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common Thread-Index: AQHY9/NJEyK+3mrs5EOr3Uxa6OTCSq5DRUeAgAEC0+A= Date: Fri, 18 Nov 2022 07:23:49 +0000 Message-ID: References: <20221114063451.473711-1-wei.chen@arm.com> <20221114063451.473711-6-wei.chen@arm.com> <4e961ee5-2b4e-721a-9406-9dde7ba5e672@suse.com> In-Reply-To: <4e961ee5-2b4e-721a-9406-9dde7ba5e672@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4B190D9D5272844C89EE8236B5E56ACA.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|PAVPR08MB9083:EE_|DBAEUR03FT019:EE_|AS8PR08MB6229:EE_ X-MS-Office365-Filtering-Correlation-Id: fb00cdc1-0892-4613-5d7f-08dac935dbdc x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lmqsTE+YDA2ROq3+32tvzCA6IksP9L0UvQ5Dm7bjs3vwe93QurIB1mYw8lU3j5yxrZWU7p070ilzrGjdycZDbGnyp1+t9ffb4LC0gAqYTlcL0uTr5brqYSKccS2xBIzHAWtDFT9kP149AmY6+eUAxAknqKFmB5XpUlrokZYa/UKioVtOgXNEfMQrC9gWxhF6uF9MwjnrCoA3mqDsKUjkeoCSZVIEl8YA+/pzffHRKlmSJfPK0VRIX5zoHbaPo4hKb7CmGrml8peWq2dnCsr+I+BS3iPYQPAGI9XtaPb6Wq9A2xynZQZWvfsmAGHwF/np8AbG9jzI+fqMZ61S+D4TdI3P8TW4uuhJGtDY0sBG6i4iNsJrZXR32dv4fDRZMPJsoDrrKCAGcuGU5JNtrB+CyZ5VO6DdlvmEO4gR28rWlCYM8vw1GMV7JiEKDY9jWg+WBBsJJpC3tm/wS1E/y+nvrd0IHJL+EEgW1aq4hsXrxT1wcLVyb7SLTdzYzULizXmk2AJNbJEwRZ+zHbhw+F99B1Xy2LzhLWKMDvDeaIDRk5ziW92C10C1hOx1EeuOhf5rr3GXWFWlsE0yp1+i6fhZZ8GZoweezQ+yUxU8aZWsz0hIU6qCuJ2ORAck7ak5GU2Q6uXhpea5q0iWjlPF3qFdkA7HKEQTIy+Y2j3TbAZijfoC7hBGVVlgfZFkIeYGjp1aB+QjZgn6GVKoPkDURG64GA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(366004)(376002)(396003)(39860400002)(451199015)(2906002)(86362001)(26005)(71200400001)(6506007)(7696005)(9686003)(52536014)(66946007)(64756008)(76116006)(5660300002)(66476007)(8936002)(66446008)(4326008)(8676002)(66556008)(41300700001)(33656002)(55016003)(316002)(6916009)(38070700005)(478600001)(38100700002)(122000001)(83380400001)(54906003)(186003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9083 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: eee93844-7fe1-4f91-312d-08dac935d687 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FkPYAobq5CchxrVtiIaAwxqU6klb0cS4n0sWUtq4YRpMciIy/yfSdzOGZsGn9FyEP0EMAiW1OpF9W46+5bYZ51PmpL2LxUjYlQRjW+jdtUMnfmZhbkIXyqexHLW/C/eZmgvQZcQiViBSCFwqq7vwbbn0nzJc7qwiaF5r3PDckMAEyuciPRiC9+WkNJr1dT0x3kdGVlWALC4WoIuIL2Iw0BsiiDbpChTUCZRUj5S6VQkGfN6w2udEPOE8Ou/tn2bNw85+A764o6YdJ601f+WK1jDckBsgFjh429UoqLUpuEOPsAkzAYydN60BVvLG6Onif4saxmeAmCNiWfWIgM6TiuAaAoNdDPYR6mR+KE3Ah6UcDqJx7EaVOfk6eOSxcuwdwO2YVCSQaIi+Sj9YFnmkTOPhKm+1ustrpgHq2ERchIXy6r36do5zNAJDTrmrFLXW1T+HOhmZdTkdSgMzA+qqdkRbDkroLWQKBCFQkPr3jow6adC3dd/UFjEH2ejqoeGHELfsBtmJvRiKMyJJqTvD92Mb0LddTDMwz49lMnDMCktsfkFk1Kas61HZjpNprpmJdgNk69FsTdetMLM7NVAvcJb9pUIrYpwbA6X2HOo/0pmw2zqbnS//8oSeefxIDMyVIJWXIy04Wiyjd1+R1Nn7RoYUmbmT8IxT7hi92B4JStzDwfqJSyjySlh4x0pKwNQXW1xEGS+GjzAmwTHBViiDdw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(396003)(451199015)(40470700004)(36840700001)(46966006)(5660300002)(52536014)(82740400003)(8676002)(4326008)(40460700003)(70586007)(36860700001)(70206006)(47076005)(336012)(8936002)(186003)(40480700001)(33656002)(55016003)(2906002)(54906003)(316002)(6862004)(83380400001)(26005)(6506007)(7696005)(86362001)(9686003)(41300700001)(82310400005)(81166007)(478600001)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 07:23:58.5448 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fb00cdc1-0892-4613-5d7f-08dac935dbdc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6229 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gdG8gcmV1c2UgdGhl IGZ1bmN0aW9ucyBuYW1lcyBpbiBjb21tb24gY29kZSwgd2UgaGF2ZSByZW5hbWUgdGhlbQ0KPiA+ IHRvIG5ldXRyYWwgbmFtZXMgYXMgd2VsbC4NCj4gPg0KPiA+IFBYTSBpcyBhbiBBQ1BJIHNwZWNp ZmljIGl0ZW0sIHdlIGNhbid0IHVzZSBpdCBpbiBjb21tb24gY29kZQ0KPiA+IGRpcmVjdGx5LiBB cyBhbiBhbHRlcm5hdGl2ZSwgd2UgZXh0ZW5kIHRoZSBwYXJhbWV0ZXJzIG9mDQo+ID4gbnVtYV91 cGRhdGVfbm9kZV9tZW1ibGtzLiBUaGUgY2FsbGVyIGNhbiBwYXNzIHRoZSBQWE0gYXMgcHJpbnQN Cj4gPiBtZXNzYWdlcycgcHJlZml4IG9yIGFzIGFyY2hpdGVjdHVyYWwgbm9kZSBpZC4NCj4gDQo+ IFRoZSB1c2Ugb2YgInByZWZpeCIgaGVyZSBtdXN0IGhhdmUgYmVlbiBzdGFsZSBmb3IgYSB3aGls ZSwgcGVyaGFwcw0KPiByZXN1bHRpbmcgZnJvbSBhbiBpbmNvbXBsZXRlIHJlLXdyaXRlIG9mIHdo YXQgd2FzIGhlcmUgZWFybGllciBvbj8NCj4gDQoNClllcywgSSBmb3Jnb3QgdG8gdXBkYXRlIHRo aXMgZGVzY3JpcHRpb24gd2hlbiB3ZSdyZSBjaGFuZ2luZyB0aGUNCm1ldGhvZCBmcm9tIGV4dGVu ZGluZyBwYXJhbWV0ZXIgdG8gdXNlIG51bWFfZndfbmlkX25hbWUuIEkgd2lsbA0KY29ycmVjdCBp dC4NCg0KPiA+IC1zdGF0aWMgaW50IF9faW5pdCBub2Rlc19jb3Zlcl9tZW1vcnkodm9pZCkNCj4g PiAtew0KPiA+IC0JdW5zaWduZWQgaW50IGk7DQo+ID4gLQ0KPiA+IC0JZm9yIChpID0gMDsgOyBp KyspIHsNCj4gPiAtCQkJCX0NCj4gPiAtCQl9IHdoaWxlIChmb3VuZCAmJiBzdGFydCA8IGVuZCk7 DQo+ID4gLQ0KPiA+IC0JCWlmIChzdGFydCA8IGVuZCkgew0KPiA+IC0JCQlwcmludGsoS0VSTl9F UlIgIk5VTUE6IE5vIE5PREUgZm9yIFJBTSByYW5nZTogIg0KPiA+IC0JCQkJIlslIlBSSXBhZGRy IiwgJSJQUklwYWRkciJdXG4iLCBzdGFydCwgZW5kIC0gMSk7DQo+ID4gLQkJCXJldHVybiAwOw0K PiA+IC0JCX0NCj4gPiAtCX0NCj4gPiAtCXJldHVybiAxOw0KPiA+ICsJbnVtYV9md19uaWRfbmFt ZSA9ICJQWE0iOw0KPiANCj4gSSBndWVzcyB0aGlzIGNhbid0IGdvIHdpdGhvdXQgYSBjb21tZW50 LCBub3cgdGhhdCB3ZSBoYXZlIC4uLg0KPiANCg0KT2ssIGhvdyBhYm91dCBmb2xsb3dpbmcgY29t bWVudDoNCiAgICAgIC8qDQogICAgICAgKiBJbiBhbiBleHRyZW1lbHkgdW5saWtlbHkgY2FzZSwg c3JhdF9wYXJzZV9yZWdpb25zIG1pZ2h0IG5vdA0KICAgICAgICogYmUgY2FsbGVkLiBTbyBzZXQg IlBYTSIgYmVmb3JlIHRoZSBmaXJzdCBjYWxsZXIgdG8gdXNlIGl0IHRvDQogICAgICAgKiBtYWtl IGl0IG1vcmUgc2FmZS4NCiAgICAgICAqLw0KQW5kIC4uLg0KDQo+ID4gKwlpZiAoIW51bWFfdXBk YXRlX25vZGVfbWVtYmxrcyhub2RlLCBweG0sIG1hLT5iYXNlX2FkZHJlc3MsIG1hLQ0KPiA+bGVu Z3RoLA0KPiA+ICsJCQkJICAgICAgbWEtPmZsYWdzICYgQUNQSV9TUkFUX01FTV9IT1RfUExVR0dB QkxFKSkNCj4gPiArCQludW1hX2Z3X2JhZCgpOw0KPiA+ICB9DQo+ID4NCj4gPiAgdm9pZCBfX2lu aXQgYWNwaV9udW1hX2FyY2hfZml4dXAodm9pZCkge30NCj4gPiBAQCAtNTM0LDYgKzI5NSw3IEBA IHZvaWQgX19pbml0IHNyYXRfcGFyc2VfcmVnaW9ucyhwYWRkcl90IGFkZHIpDQo+ID4gIAkgICAg YWNwaV90YWJsZV9wYXJzZShBQ1BJX1NJR19TUkFULCBhY3BpX3BhcnNlX3NyYXQpKQ0KPiA+ICAJ CXJldHVybjsNCj4gPg0KPiA+ICsJbnVtYV9md19uaWRfbmFtZSA9ICJQWE0iOw0KPiANCj4gLi4u IHRoaXMgYXMgd2VsbC4gT3RoZXJ3aXNlIHNvbWVvbmUgbWF5IHNwb3QgdGhlIHJlZHVuZGFuY3kg YW5kIGVpdGhlcg0KPiBwcm9wb3NlIHRvIGRyb3Agb25lLCBvciBpdCdsbCB0YWtlIHRoZW0gcXVp dGUgYSBiaXQgb2YgdGltZSB0byBmaWd1cmUNCj4gd2h5IGJvdGggYXJlIHRoZXJlLiBJIHRob3Vn aHQgdGhpcyB3b3VsZCBnbyB3aXRob3V0IHNheWluZywgc28gSSdtDQo+IHNvcnJ5IGZvciBub3Qg bWFraW5nIHRoaXMgZXhwbGljaXQgZWFybGllciBvbi4NCg0KLi4uDQogICAgICAvKiBTZXQgIlBY TSIgYXMgZWFybGllciBhcyB3ZSBjYW4gZm9yIHRob3NlIGZ1bmN0aW9ucyB3aWxsIHVzZSBpdC4g Ki8NCj4gPiArCW51bWFfZndfbmlkX25hbWUgPSAiUFhNIjsNCg0KQ2hlZXJzLA0KV2VpIENoZW4N Cg0KPiANCj4gSmFuDQo= From xen-devel-bounces@lists.xenproject.org Fri Nov 18 07:36:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 07:36:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445454.700615 (Exim 4.92) (envelope-from ) id 1ovvvC-000205-2Z; Fri, 18 Nov 2022 07:36:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445454.700615; Fri, 18 Nov 2022 07:36:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovvvB-0001zy-WB; Fri, 18 Nov 2022 07:36:21 +0000 Received: by outflank-mailman (input) for mailman id 445454; Fri, 18 Nov 2022 07:36:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovvvA-0001zs-OJ for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 07:36:20 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20629.outbound.protection.outlook.com [2a01:111:f400:7eaf::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b0b73c0c-6713-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 08:36:19 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9399.eurprd04.prod.outlook.com (2603:10a6:102:2b3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Fri, 18 Nov 2022 07:36:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 07:36:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0b73c0c-6713-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PoaP9uPeYmhPMDFdL6l5oGbwhJJYjnLOsODq0wDV4SmYq7wvZrk9nNHyjPsAFTAS5XpnKSVT4OR46aZntMsYLOrdwyBjzLYSajHZhokA8nVm5jZF5nb/sFT6/sxalJfv5dwS6+sN4T1iXZjeJNFAwFUQTiYwTZwcdaGHvNkYhQ36DkwdKcHDgyR4Aiir5KJ849m5z+zao4gEFvlVr5jIlzgwffTCbsRU94l/79uwbZmniSmbhLMGcqwaLzaA5olVIPqO2IarlCxfEdaUF/Ytxxd2Og8/yMcyguNyg9mzHmAXwPrK5IrYIzbG2LOVx/GWysN7gPrHpZ6vQlsNeptS1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Z7ea5Z9iV01gyTI2NFbO5Cm6k11JK+P6Gpe9r0UKkI=; b=hRsslaxYLfTz/AiEJ6fNPdqdS4lb6XGwlOKJs4BhNX6mKb00ZCWDIuj4sYfh30r9EuOEva5j/Q/1eJGZmbi5VW1BuP/HT9fcffeflPuA4SAefPp5FCJM+iAzdKKcHLEltPiOw1w4eTEAkrm/ko6zUmcCbbafGHqJWX8Gnp5QQG4Y+BJ0mSLsmIz/Kf0+P41Y5su5XvNXeeyaFuQMoQtDjOKJki5nc0yvwk9a4xwye4r8dvKdiiA6oS2dvOQwWgQe9Ga1/bS5Gmuhd9QZKuJgZfHSQic3YkXbDn4UEeVBP09bm6Htsiw0eipspIU624OpRNAcK3WjISZNa6kxpN4wLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Z7ea5Z9iV01gyTI2NFbO5Cm6k11JK+P6Gpe9r0UKkI=; b=41mU+9hbuH6PfFvJz1A7QAdexvH3kryAy6RkKRg//nj8abLZ5UkVyntAtuhIm5sYX2Temj38iIcIY4jaMJw9clzlq9gBdEzgKE9Zsdn9mdK3uPWjEz1zQppTgU56XBof7SSw97t7f+0NKorlC8ssVSqFTQJ54KWEPvAb7QmcBDifcYFCGjcmIm8aQKppb5zs4YZYKdZ5zj/HhkrXkrmpvem5CYr9thJCyYC2Vh/ok0Txx6W1oiwX55G2nZLS8zPK8yOwkT/JCWZ5sT3cR3v2UQeSMvznVkVXw1zfRP5FsN8wbk0iXTAEIHzJPZcUvCK4IYwODsWERMKwTQaD2TOlww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <93b6385c-63c8-1b5a-13c0-838f7c03ccce@suse.com> Date: Fri, 18 Nov 2022 08:36:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , "moderated list:XEN HYPERVISOR INTERFACE" , linux-kernel@vger.kernel.org References: <20221118023535.1903459-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20221118023535.1903459-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0008.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9399:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d6756e5-a830-456c-81b7-08dac937939c X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EmQ+ElxE5F1iSFxtSUZ2pPMw5gUUGC4m3grdujQSGBke2IOSZnuhwXt9gtxGiuT3MoehnUY+j2iq5UiTdIxhmXpTkRF16OABBjVj9Fa/ynnQTSxNqaLZOEGrukyVS6OrHrGeg/ICeT4Y6/yW0guNdfZGdlU0dhvWjj35we3nOI/klTFsEavmaSCuieMbGetAZO5eDREYgvnUfmCWYcRW5sodB+7onnndvRnMuw8sZkGc/tZd6PUpyTXXZnkz9IdXGqx9+VwomNIimDen/OfEUQpHXkxczmG28ert8r5NL47Q22DsmhovowmE3Mwq3jo1YaQLOLj2XSVvQ5MXnVgELxk+GG2Nmv3wU+exInlnX6tJHJ+lpA1Z/HfheR9Ibdzb+EncOiZ6mDBF/ePOXSEujaxLbxeA46cABSStY5N3Mh3AWbFw8mTqy/8KKtHmwDV8S2oXMMrkfueGq4uKktZPcEXUDdLpVL0j2yea3FKQ99EjoteomxefCnZDg3Aw9xxhlCb20pDEfmHBGobJhdefHKQbsM+ZzZwYl3tVbegaDzvWNu9eRfP8xZXdJR0ReMLM/LbIbEFbi5RqUT2hM2IXTQjLz+hSOOen0i3HnJd+0DtohEXOOxk197tpGbmfZoibC3wqNntEqaOHW8gqsuyzJT8bkrorPOmv/lkGEg4C2ABPdX2L2cNMHMf84PLjMT3PMC7P5CF/veQQs9QOClTAvSb06ZR9e4jl7yZP82Tc0qY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(346002)(376002)(136003)(366004)(451199015)(6486002)(478600001)(31696002)(2616005)(38100700002)(86362001)(36756003)(6916009)(2906002)(53546011)(6506007)(83380400001)(316002)(54906003)(41300700001)(66476007)(31686004)(26005)(66556008)(6512007)(66946007)(5660300002)(186003)(8936002)(4326008)(8676002)(66574015)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elgybnhhUGtzeGF1aURNemxZTWlNWXVKVXZDcTg4RVI3aFY5S2tzZ0g4Mllu?= =?utf-8?B?VVJIbFFVWXI0Vks1WndIbFB5dEd6MFRsYjF3K0haSTRiWDFuem5ZTFVFNXlZ?= =?utf-8?B?M2JNNzhzWGpTaXZGSHZhRFRRS0Z6NVBTd2JiMERKUUlQT0dWcStQS012VWVa?= =?utf-8?B?NzBlUmMvVjlvRW45TytjSFZHWm0rbGZadHlrZHpoeStZWUsycUhMeG4wR3U4?= =?utf-8?B?WkpwUVI0aXZiRk51UmlmM3B4NEYrRitTMVVkeVhrM0ZMalZSdGhzSCtTL3pB?= =?utf-8?B?ei9MYTErTm16cGhHRTlIZmIrSXRwVy94N0VwZFJTMlRCWVd6dml4VlhlbUpa?= =?utf-8?B?b3RJK2lScWhvS2tvRC9qZ1dMbmc0dTF2UWt6MWRpZkFjVUFsYjdrdU4yZWtw?= =?utf-8?B?WlF3ckVhcHArKytHTW1Ec0FGaHFFNUFxNGFQc2FCMjlPVDRwS0Jra093Snpn?= =?utf-8?B?R0FYMk4vMjkrQ1lIMElEYnVhSm5KZjVqdTlRNWRDQVNUTkNYSFlOeUJuYXZR?= =?utf-8?B?QTk1MDcxT08zOEhQRFI4RldZbEw0WFdkWjlPc0pWNGxWVVkwcVBqaHlrenIw?= =?utf-8?B?OVZrc0JKOEM0RHZ5TS9QZUlENGRuaVErd0c0b1BKNDhhOGNSSmdnNmljUXMw?= =?utf-8?B?ZytJNkdYRTNkNzN4cWFlTkRLTzBKRGtuTWRxQjJBMUFDemYxR2dTcVg0WHRN?= =?utf-8?B?blpwWTVpbkRrUEJXVHlhektDN1VvL2M4eGJ6VWVoU2NsMkFsN1o4a25vS3Bp?= =?utf-8?B?MGFFUVdCd1YvQ08vQVc3RHVJV2R3bTJINVJOVUs0N00wd3FlcjNOQnhXa0lp?= =?utf-8?B?ajA4TFFLNjBwWUNUOG0zL0REYUsxZ2UwYzhPYXBIbFJFdmJ3RFVVZHk3MUJI?= =?utf-8?B?TiszbnNUWDFRQVhqKzlUZ0ZaL1l3R20vdWQzNnZnQk0vZlZObzVndjFmaDBM?= =?utf-8?B?aGNHMlBXSWlzT0RoLzlseEdVQ1dVYmsvVnRLN2UxVVYwSzBIWEkrUkJCNDRP?= =?utf-8?B?VEc2OTJGY0htaWZHckpwUDFTeTFvcFZpRWQvNkZMOExHMHNhR1VJTkFKN1g3?= =?utf-8?B?R3hsc3p1d05mYjhIS0hjUm9DR1A5UlBiVWY3M2dXT3NQZ0xVbVIxZjgzNGpU?= =?utf-8?B?bWh5emFtUnFMSnYzTEFrY3RqMytjMjlEQUV0SVJQYng0RWdPNkNobkJyVDRF?= =?utf-8?B?Ym5yV0drck5VYkdiYldZV1BrUUtzcGs1OHhDcVlIYmtvVG4vUTZVU1NmdDYx?= =?utf-8?B?QkxhQzdkUnFkMGs1cCtSSncxVEhaTVFpdys4WDBiY1NMZ1A2ZEdvQ3dTZG5u?= =?utf-8?B?UURmZVkxM09DSWo5R3RFV0gyaUlGRjFEZ3V0d2s0MTdtK2hjWjNiSVl6MHlk?= =?utf-8?B?cmlBQ3Z2V09yQVJPZXRoeHNJTnlqSDYzTk9BZDBXQzNRNFYrcHhONTJPZktv?= =?utf-8?B?UWJwTlk4d3dod25WeFRTQlVWbkpKaERxdkhwNHRSOXhLWVRWdU83UXBlS291?= =?utf-8?B?NkphUzMxZlZkZHUwSTlDR0haMFRKZDY1NndHeldrMHBnK0lDNFJzNm5HUWE4?= =?utf-8?B?bHVqR2dtNW8vZ2JrM1VEVnh6RUs2LzN3eDJTOWJxL2Zkd2c4eXBjeGRaTzJU?= =?utf-8?B?NmNwVzFUeElNMXRjR0s3ZCswRzYwQlBlbHFOVXhPMEkrUWdwVXJZbW1DTm9E?= =?utf-8?B?RUt6TFFNVUF3NUFTUGJZVW1ab3B6R3JpNU52Wmo3NTJFdXBsK2tUVnRCdnBX?= =?utf-8?B?d2lJN2NSYzBPM3dsUU1HcGVPRERJWmJKTG94eVpvNTFMZ0tCdG0vNzNVM2l2?= =?utf-8?B?QzNWZm9oUm5LbTlPNWkwNThZazBpTUFWb0pjeW1HWmhVbGNUbERhaWZkNmpu?= =?utf-8?B?WVRjb2FZRkFsNzNzTTRXMTdLN1RYS2xNNU1vclBBVlYzWndpWjFHYklDOUFa?= =?utf-8?B?NGtpZHV4OCttZnFYMldlcVFZWTVSandROWk3RlBYdzV2QSt5T2ZPUVBlV1hq?= =?utf-8?B?V3NJZDNhUTVVcDJLM1lWMVpYRXhtKzlXKzlEYkpoMUhrUkdaZ2JZVnl4NnFU?= =?utf-8?B?ZGhxUDVyWStnanptSE81eEFZL1BMUWFSOWYreE5vK1lrWDVyb003RlJkUjZ6?= =?utf-8?Q?RMYhinBjZV524DQ8JWIPLDB7S?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d6756e5-a830-456c-81b7-08dac937939c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 07:36:16.4332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PxLuRRb99Rc75IQpwOHLu1jYS9ct5eRBzYk3H4PnpCo2oDtwiOFtLm6QHR704UFsCnI3WWF7xX7ROtMmADVhNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9399 On 18.11.2022 03:35, Marek Marczykowski-Górecki wrote: > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until > the table is filled. Then it disables INTx just before clearing MASKALL > bit. Currently this approach is rejected by xen-pciback. > According to the PCIe spec, device cannot use INTx when MSI/MSI-X is > enabled. Similarly the spec doesn't allow using MSI and MSI-X at the same time. Before your change xen_pcibk_get_interrupt_type() is consistent for all three forms of interrupt delivery; imo it also wants to be consistent after your change. This effectively would mean setting only one bit at a time (or using an enum right away), but then the question is what order you do the checks in. IOW I think the change to the function is wrong. Furthermore it looks to me as if you're making msi_msix_flags_write() inconsistent with command_write() - you'd now want to also permit clearing "INTx disable" when MSI or MSI-X are enabled. Which, I think, would simply mean allowing the domain unconditional control of the bit (as long as allow_interrupt_control is set of course). Especially with these further changes I'm afraid at least for now I view this as moving in the wrong direction. My view might change in particular if the description made more clear what was wrong with the original change (476878e4b2be ["xen-pciback: optionally allow interrupt enable flag writes"]), or perhaps the discussion having led to the form which was committed in the end. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 18 07:42:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 07:42:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445460.700627 (Exim 4.92) (envelope-from ) id 1ovw0c-0003Yp-Nd; Fri, 18 Nov 2022 07:41:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445460.700627; Fri, 18 Nov 2022 07:41:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovw0c-0003Yi-Jj; Fri, 18 Nov 2022 07:41:58 +0000 Received: by outflank-mailman (input) for mailman id 445460; Fri, 18 Nov 2022 07:41:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovw0a-0003Yc-P7 for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 07:41:56 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20629.outbound.protection.outlook.com [2a01:111:f400:7eaa::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7816b087-6714-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 08:41:54 +0100 (CET) Received: from DM6PR02CA0037.namprd02.prod.outlook.com (2603:10b6:5:177::14) by PH7PR12MB7212.namprd12.prod.outlook.com (2603:10b6:510:207::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 18 Nov 2022 07:41:51 +0000 Received: from DS1PEPF0000B074.namprd05.prod.outlook.com (2603:10b6:5:177:cafe::db) by DM6PR02CA0037.outlook.office365.com (2603:10b6:5:177::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 07:41:50 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF0000B074.mail.protection.outlook.com (10.167.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 07:41:48 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 01:41:47 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 23:41:45 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 01:41:44 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7816b087-6714-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KCzZg6YHylYkQMPyV0OtXm5U+CRExY23a855H1LzhbuSDxYvpioFYLGoLZgY0RTV4Ye0N0pOTLeKeONAl3jvD6/PYX2SikRjYi/xlaXg0XqGN9/D4Ln9NYIpNx3mesGOrWYm96pZ7bW2LHxgjGDoTFwQxLEQJa9wKuR/AQbnYwwpmaJI1TKyRqJHoJhBN/jRytpDBo7SPEG3K2WCkZd4nktxuORBRHVjUxt976tPu0YVJI95Ab5oNVfkvuPH84PF+hyPM1A3N0MpTii1UVa2WSGV/fHb/eeuMreSk6PfeChm2DxUQAiV/FbPpGzDGmv7XKppOA5360O0u9c7MeIaKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ksGVRKNoRoyjmTJxebrKBZRAtlNnHdoeymssGWOX+W4=; b=UM2au9DDFm8IxBoqZT3hSvCdEZYNkZXOWDnqRYcSuWeL9OOifhsWyBtPsgrKNsgc6mwQZNk92dEoPpx4StAN14Lza1Q41Nq5NMsdZP0l5qRvYCxut02KsAV6i4+Ux00XXm9clP1cAE1dtNKSToep3wLHYpPmC7TSzNigIdxeXDEmjB/XoULp2ckDj7cxEb4PBhphTwsxVuV4EZgECL2FWOIec0uguQ5bv3vS8GQ/LClVkv9NgofohVREeD2QSmL7vOeAEvrcx6qY8AKUuqo+UEXJCqHw+hITCXDsZaQIs1CblFTcxjmNVRvrzjLFTpOQ+YoFFLFOwlEZiI3hf0YeTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ksGVRKNoRoyjmTJxebrKBZRAtlNnHdoeymssGWOX+W4=; b=e1oHUoxPtkkffJyqrpta1lLDgI5rPvoT7+nvZh8r+9sy3ZuiNNfNLXMyI2bBzW2Hc8pKjLH3mVvvg2kKU28KaGmmfVxlnU2fbBvk41UnUsfrTgo0c28eZoh80yoMACVY+hWS7aRs1AD52HHkHhSKC8UobmDlgQV1mFd7TRKQ/z8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Fri, 18 Nov 2022 08:41:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: vpl011: Make access to DMACR write-ignore To: Jiamei Xie , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , "Volodymyr Babchuk" , Wei Chen References: <20221118020013.125987-1-jiamei.xie@arm.com> Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000B074:EE_|PH7PR12MB7212:EE_ X-MS-Office365-Filtering-Correlation-Id: 275a69fa-d243-45aa-1663-08dac93859c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g6TMJ+cEUClA9MDpm4CgfSefBuDbyMOky4ZLFQIjnxageWHnH4C/mK1qQTLVjZIF85hnMiYMEjOZwDJQtdq5F+up4xE+bVElIWc/inArR570RpHl/CKlsKuIXa7f5i6SRiMUNRe2NuDdAegP+Xl6QcSKUbev6zfEhlXnVTjL49T1wsRtZxiodryY2eZ/QL+6mFqMa54c2A+5cC6L2J2xFFbroQ2IyXEXOojxL/mkP4Oc9G2RTOtRS+mGsL/LMR4qtjKWTrhWTNx+0y1CyQO/ch6WZoHS4Hh9Kf+Zc/m1+I1IDckxrf06KEyGlcqVal/c9cA5MD7KXqWNkO1ySYgIHqC9vHeq3JkEQslfOqbxYWsEZpN7j53Q/ii5AD/ylEXjyhyg6UqAfVhtkQyynEkDpi+H9hqhmKF9mWkopGaBA7QwV8ZP1VJ/8mVGJHByKGWotfDT82jM0psyDa3Ki39OHnZ0t2+++qI+wsiYcyg+npFq0+irTgryDveC8fF88NrcMANA89CePsCtbUd1PjmKKLPjIEwpe+vXgLy2NFzvsESlWonKzn/1Iz/9cXEM2v5fzOSHGm2NTOvE4k22z6AxIvXSys/KH/nKDJ/tQYidbYEQtsUfjVSajleWx1c45Zj4IaIZWsCGFx22iDYZfNjYQ3i5WmVeZJQnezxFcGFmBfnR/6VvHEigcelDzCta3G9vI1JAo8JTpoRaB5AC86GLKkdAJQGEUcT6XgwhVEEgM2Z6DHEvNb3hqJUC3SgiLZML2L9ThfFtDN0MP1golZy/Rw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(39860400002)(376002)(451199015)(40470700004)(46966006)(36840700001)(82740400003)(36860700001)(110136005)(82310400005)(54906003)(36756003)(40480700001)(426003)(186003)(4744005)(2906002)(26005)(44832011)(31696002)(16576012)(316002)(70586007)(8676002)(5660300002)(70206006)(41300700001)(2616005)(356005)(31686004)(81166007)(4326008)(86362001)(53546011)(8936002)(40460700003)(478600001)(47076005)(336012)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 07:41:48.7005 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 275a69fa-d243-45aa-1663-08dac93859c5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000B074.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7212 Hi Jiamei, On 18/11/2022 03:18, Jiamei Xie wrote: > > > Hi > > Sorry there is no subject in the last email. So add in this one. I would consider re-pushing this patch(although please wait for some comments). The reason being, a patch without a subject is not picked by patchwork/b4 or other tools used to grab a patch. ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 18 07:43:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 07:43:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445465.700638 (Exim 4.92) (envelope-from ) id 1ovw1n-0004AI-5J; Fri, 18 Nov 2022 07:43:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445465.700638; Fri, 18 Nov 2022 07:43:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovw1n-0004AB-1O; Fri, 18 Nov 2022 07:43:11 +0000 Received: by outflank-mailman (input) for mailman id 445465; Fri, 18 Nov 2022 07:43:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovw1l-00049w-1o for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 07:43:09 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on060a.outbound.protection.outlook.com [2a01:111:f400:fe0c::60a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a4976361-6714-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 08:43:08 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7612.eurprd04.prod.outlook.com (2603:10a6:10:202::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Fri, 18 Nov 2022 07:43:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 07:43:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4976361-6714-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q6MpMPRRhRaTbbbKypSNQJ9JFAyHp13gk9MCpGwfGHN8LYk+4f5F4tuJ9W0jnNnut8prSRi/2lYsGGbjpG8lzlXCyw2wLfReRnM1f4j8MPEEUXRuwhMukN9ldKC+KmmvwNuhLNJ5ZjHLSONBAWmqgmZOIdIG2JMUjNjHTMQe9hem1rdQ0r8uPNizFr0U3yBu+/HIkA7U46ckK57x5u4KVg5QjjM7bR4T7eBIBaNe10onxCmiWg8DUgW0FRZmjkB/XVjwvGAZXvk81Jz1gRbaCtzbT6aIDqNOmFy4/+KHXsVUKhFqdsQgZzjgkD4doslH5tCuvydIxAPReQawOHDDLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MZrinOzMZNiUyNurxX6HSXi6VoMFVYsjaHSFMxw1KPs=; b=BOkHjbxgCaKskkpndPgNZSC/qPYiNZrRHTkVHjPphYBXg4mJ9SCMmKZiLdsN5oi8jRvxLIVOonlnW3Zc8rLWrap8Hy+auJdPYeHVo9nhaaospqvEOmN2I0lIz4V8nFXwChVIzXCys3v0+DOQ5qizPKea9+2gLUbY7ggw1vuTiY3+Qf5nh83yZjaUVeO6Cc7vsKvzCw8zEueA8ESE9qWAXm4jGPXbDwOQxR/MeYt1Ou2oYof4rd3EMf1HlKoPj/PxKP5pMNl8Rdy7RFBhA+M42MrvXZaXd81ZhhDxFXoO0nsjIChPjk6VtzZY47JZyzB9QAHOgTec/ZFpi/B8s3uQ2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MZrinOzMZNiUyNurxX6HSXi6VoMFVYsjaHSFMxw1KPs=; b=3nQQ8dvliVJJYB1fJInRl1FKRkZtmibRck+LyqeIWAKM6SWKeGUQkiPrMMI8yU72dO4GbFmurcdd1OgxGkZc1cdWO1au1htkMtblldNt4Zr37x6vIrhz/ooixaMI4XO0rW8JlFRcDjOGNHkcjkMxDljHsrF3gRXEXKVCUTPtPGre+4ufGPvkfDoTCoBWcydb9FL5CTlav+2OEJ6SSwMHHBCky558zeFje4noAOm9iU308sCMKbltd6zJAp57M5U7Eu9BcOUKuU/GcZ+GV96cCbXl7kKs/AOJF0AxmcC2fxc8g+8PRkvMKDHLA5Svm+4dbjk/GTlMrRcEBJP3Gxz8Xg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8aeffc16-b56c-eabd-afc4-521ce6daabd4@suse.com> Date: Fri, 18 Nov 2022 08:43:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v8 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <20221114063451.473711-1-wei.chen@arm.com> <20221114063451.473711-6-wei.chen@arm.com> <4e961ee5-2b4e-721a-9406-9dde7ba5e672@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0014.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7612:EE_ X-MS-Office365-Filtering-Correlation-Id: 64b2cb72-36fb-4cfe-56d8-08dac938875c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m4MRxJ9nWWaNry24dBEKZ2N6bs/Fe9RkrhPHtu6dCNG3lztz8UxnMf6wtI6VJr7vT4d9Gh1bRJOhhXVij8fuamANVvZdlPDaS1OC4Ll9+ON88lllOMs875czbVAGv2WWxsyzX/3gc7zFx/TmSWF1lwWqVVquV5rr70gnOr1ouRdRjmAcBgB4dPy455TUd6luFj7utMqW7ABdIipf6Fjsv3HKL/XPq9GOYJpQ3DKYswVI7sttSJN08t6Fhun/FkT4mhtoj7vAQRfKpVE8a0/fBGR82HDn/35IgZcposbI53oNoevHHUVzKLQp+GYx4gd/FFCTyj8fYSs5RBhBwjT/yRiikOb4AIEdKAGDw9fuCCvqdoDacu8dkihFNvUEZfXy5D8UYPrjdcAdTSLyKzjDqLvRAkGo9SVN/5t/IWMfqr05Uvsi8R2u/h53shZYAck2m3Xzai/YSV6nQVjQIjIKGDDM6GQoM8RKrm2chJTnwwLap9oSw3+igWszieeG+XU6CggnbWqwzxQfVb7HtrcOpKY2HHrtbXL0yJJ3XcrnwOTtHUJBoNMd+ioVHjSJSXd4U1pgzuCLliQPe+FR1EU/0/XDtp2kBgHK/Vmgtap6sIj1y37b+rIyD5lR8JL2aaS2d83ET0lkk88bhyp+iJHh8b/m4yjFAw3CvP9ZKu75SNR1+yip5iOF4nYCLexpT6sQ75P6BM/ynNjDawJcG4/j1jXgHcrj14DiR7N3BE0cdIU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(376002)(136003)(39860400002)(366004)(451199015)(86362001)(31696002)(41300700001)(8936002)(2616005)(4326008)(66946007)(8676002)(66476007)(186003)(5660300002)(478600001)(316002)(6486002)(53546011)(6506007)(6916009)(54906003)(38100700002)(66556008)(6512007)(26005)(2906002)(36756003)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzZNTHZQUWRtSFFCbStBcmpSd1oyb1VLTysxbFRtUWxSaUkwbzlsUUZnSVJi?= =?utf-8?B?YkY3SGZOYzlTUm53VzRZbE1QY3FjdDBqbnZZU1lBRHFvQ1VXQ01Rd2RvVzUy?= =?utf-8?B?UzNHMExDVDVaTW9TK2QwaGw3T242V3ZEUEc1S2FkS2VFbndhSFVhL2FGaHNh?= =?utf-8?B?V0FzSEpjSkVKWkphTG1CTE5XdXFVam1qcGx5aTgvS3VhNXA3bXU3UlJRaGtH?= =?utf-8?B?VHZ6U0cvcElsMVIyNVRWQStldW03TDg2VEIzeG9qelFTa0xTYzdEVkw0YThE?= =?utf-8?B?U29vaS9PUGxDajdnODZaSDNCdFhMdllwUUgzTEV1TllqUVQvaUZSQnRDcHlz?= =?utf-8?B?RzExSkxJaFFjTnFYVlV2RjF4UlpleDFyQUlGZStFMW5GMXl1RDdleXgyOWdt?= =?utf-8?B?QnErTnJMcGVGS0pkd1QxL3A5TUJnMU1ZcXA2TzNJWVd3QVVwazNsN096T0hs?= =?utf-8?B?a1VUa0RXN1AwSVdOSjJsUm16UHplNWNxYWR1Y204ejFJN1RRbXY1aDRqMUNO?= =?utf-8?B?eFpYS1pPOWV0M3RLVnp5dmE4SExMOFpLaWkxU2pVRC9xOE9ZSldjM3doREp6?= =?utf-8?B?c3d1RU9reHRXc3JobXc5YmZMTEZBOEJSNFoxNEJJQ3d4THVwR0xBRjhOa2Ft?= =?utf-8?B?RkFIc1VBMGlkUFlkTmpydXdudzYzb0R5SnpzcEJUZ2NCV3FxMWNQSytFZE9Q?= =?utf-8?B?Tm5EVEMyVHhRSk1nWnhiV2Fod2M0ZnlLeTUwUDlwbEMxS3F5MXZVQTJyc0N1?= =?utf-8?B?Ni9PZzhTazhMNzBQckpOU054UzdoTG1PWEN1NVpRMm9GUUxYYm5HSGFBNE5m?= =?utf-8?B?Tm9VeFdxNFNYRThudWJoTHN3RHQ1YjFFNmFWNU12c3hkMWV5d2VHK1NFRnl4?= =?utf-8?B?ZUszU0QxSGh1VDMvelRuTDl6T0pGNVMxemhObTVSNkYyWjNBVHFyVUI2VU5L?= =?utf-8?B?QlltdlZDWGNCNU9UdDRHNXZxbnBJUnl0aVU3ZmpzZnBuWE4rYStLYmJIRHgv?= =?utf-8?B?cnJodG1JWlZ0QUJXbnZEMVFHK3hZR2pDeGswNnpXMXM5L3pSYTdoU2YxYzNT?= =?utf-8?B?OCtsVFlwRDBEUWxmUVVXWjZWZjhvZ2RYaW8vb2lOZFoxUnovbW1CSnJYUnFT?= =?utf-8?B?UDhXeHY1Q2grMVREWGt1Z0pLam83L1BPNXU2NThnZ0JsTTBuVGJ1ZmRlNHdn?= =?utf-8?B?eHZmaUpwcmtoeXZYK1NTbmx2em01TkRuWGhwUXVES1dpYS9zRmwxUytIbkdC?= =?utf-8?B?YWkwakpCVkNJbnhrVFozTEc5WUNoWDVJWWYyK0xJcy8wa1VJNmlIMVZOc3c3?= =?utf-8?B?RDFnS2wzeHBWZlArcitlbUtuVURHdEc3bWZKc05ud1U0NVp1NXhKZFNGUEJT?= =?utf-8?B?YTFCQ3FTTUxSaWcvQXI0QVY2YWdPZlo4UXpWUU1xKzh2Nnk1ZnIwaTJHSDRp?= =?utf-8?B?QjZHT1JSM0k2MGhEaVNsYjMyZ1U4VWVKME1qclRlZ2xDWU0vYW5tK0hDYWZt?= =?utf-8?B?b1dJdSs5ZE85V2liZDI4ZXVxRFhtT2NMOEVxRExOSmZCOTFLcEkzUEVLbisz?= =?utf-8?B?QW5iYXhSSjlJQzhod000UUdqUDB3UzZjSUE2RFM0QS9wQlA5NCtNTFE1aTBC?= =?utf-8?B?MEtSSERzcjZ5RFdjc0hGUElza2M2YjZPTE5PeTRmdFAya2d4M3hkV2d4cTBm?= =?utf-8?B?VW5qVkZSVml0Nmh3bFFhU2hLUnhEL3NzRXl2eXVHcDNpT0NQZTNwOGZiSlha?= =?utf-8?B?UjVCazQvTHpqYkxDV0pwdytCcm9ncTBmTHFkUDZmbVA3Ty9RQ0dZUTZqOENY?= =?utf-8?B?L1l1YXBPdEpBR3BGNlZOZW9BYXhReENJVTRVcnpDczl6eVVPRytrMllra3hX?= =?utf-8?B?b00zQnJYNXhHdnZuUGl0N0VhK2VCbHd2R2dlSnpMR0t0eXlhNmZYekhBR3hv?= =?utf-8?B?MEZIRkdQZU5PdmxML09nY3padDdyVkdEbGpOaW9pc3pGbkYxdnZ4WDBsYnk4?= =?utf-8?B?Um9LOTB4YlhnOVpyRmNUeTNhVURkT0EzdTFJSnhoVlZ4cmF1MTNVUml0QXVw?= =?utf-8?B?WVJVNGt2VUdlSkZ2OENhTCtGYjdBUk8xNnpOdURlT0hEOE9HVW10MEtGc2xC?= =?utf-8?Q?RtM2N5PwnhZeLOvz/FDqp2VKg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64b2cb72-36fb-4cfe-56d8-08dac938875c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 07:43:05.3767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wMR4VYEUU4UuOzMZAo3Jisnu4SYepFbFq9PM/qfw0kWfnEsGfnoMVlaODoeO99t7sqdzIw/lhb1Q/mTZyAWYkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7612 On 18.11.2022 08:23, Wei Chen wrote: >>> -static int __init nodes_cover_memory(void) >>> -{ >>> - unsigned int i; >>> - >>> - for (i = 0; ; i++) { >>> - } >>> - } while (found && start < end); >>> - >>> - if (start < end) { >>> - printk(KERN_ERR "NUMA: No NODE for RAM range: " >>> - "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); >>> - return 0; >>> - } >>> - } >>> - return 1; >>> + numa_fw_nid_name = "PXM"; >> >> I guess this can't go without a comment, now that we have ... >> > > Ok, how about following comment: > /* > * In an extremely unlikely case, srat_parse_regions might not > * be called. So set "PXM" before the first caller to use it to > * make it more safe. > */ Largely okay, but "first caller" looks wrong here (without further attribution I would read it as meaning "caller of the function we're in", which makes no sense). Hence I'd make the 2nd sentence just "So set the variable here just in case." > And ... > >>> + if (!numa_update_node_memblks(node, pxm, ma->base_address, ma- >>> length, >>> + ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) >>> + numa_fw_bad(); >>> } >>> >>> void __init acpi_numa_arch_fixup(void) {} >>> @@ -534,6 +295,7 @@ void __init srat_parse_regions(paddr_t addr) >>> acpi_table_parse(ACPI_SIG_SRAT, acpi_parse_srat)) >>> return; >>> >>> + numa_fw_nid_name = "PXM"; >> >> ... this as well. Otherwise someone may spot the redundancy and either >> propose to drop one, or it'll take them quite a bit of time to figure >> why both are there. I thought this would go without saying, so I'm >> sorry for not making this explicit earlier on. > > ... > /* Set "PXM" as earlier as we can for those functions will use it. */ >>> + numa_fw_nid_name = "PXM"; Just 'Set "PXM" as early as feasible'? ("can" would be wrong, because in principle we could of course set it earlier. Yet we want to keep the setting within the present flow of setup, and without introducing a layering violation.) Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 18 07:47:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 07:47:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445471.700650 (Exim 4.92) (envelope-from ) id 1ovw62-0004oL-MN; Fri, 18 Nov 2022 07:47:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445471.700650; Fri, 18 Nov 2022 07:47:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovw62-0004oE-Hm; Fri, 18 Nov 2022 07:47:34 +0000 Received: by outflank-mailman (input) for mailman id 445471; Fri, 18 Nov 2022 07:47:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovw61-0004o8-IU for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 07:47:33 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20606.outbound.protection.outlook.com [2a01:111:f400:7eaa::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4153ba51-6715-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 08:47:32 +0100 (CET) Received: from DM6PR07CA0101.namprd07.prod.outlook.com (2603:10b6:5:337::34) by CY5PR12MB6407.namprd12.prod.outlook.com (2603:10b6:930:3c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Fri, 18 Nov 2022 07:47:28 +0000 Received: from DM6NAM11FT040.eop-nam11.prod.protection.outlook.com (2603:10b6:5:337:cafe::75) by DM6PR07CA0101.outlook.office365.com (2603:10b6:5:337::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 07:47:28 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT040.mail.protection.outlook.com (10.13.173.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 07:47:28 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 01:47:23 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 01:47:12 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 01:47:11 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4153ba51-6715-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FtOpJValP4sB6n2WAsPOKbpVDuknkScdWzIwuZ0WYkD5uml0ED0fc3du6NV068lZLV0MpUlqGPt99/ikIzioAiQOw3nDRPWXvKMxqI+W18zlZjcGcwSvhhfhO/evKF2/duEbn2tZjQT4EaxGIjb/prT6G9Wd4Jut9UWQo4xTiCX8kSQ9ryR1qUu9m5jAyq7LexU+qakZ37p9UQaavVAl7Z0C6nh3/6mc64T0C+a+3cXXdtEw4IuSndv0jbsltYA13N2LiOs15GItvE6cffyKnJnF770PZ9yT0FHLXD8/9oRcvuaWQuabudn1S6SWxS3juQkYEe419OJBW8SK2b8gQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hpnl5HQqsYsQeVyDXJirh+n0BeNPRVw8yA0yyvu2868=; b=a8A/muahaWzIPY4FlWlwPH7sZPH1wkIKouGqOC3OgcoIeeOnFAW+mKU9c7oHuOnT8g6CRDM3tT5/uPRjlVnwCCbsFrTPvAFwxns2iUJmCW7T4Kiaso+rAX+I+RP1XDqtc2DLW6YkFCQlQttGOrxsGEGbMWPEDagadaNciMuKUyZdgcf7N4mgZ06kn2cbfE4EbM3SHcZ31A6BtKoU1Or2RrekxEbVARf51yWhFAbPXeVNeANOcDfNSjLJ4i9kzpmjyQDQdzB8yB98Hhsqae5+MONVg667E/I7D/JGdN/05Gd3IC7ZdRGCaO0y2YglG/MrCGyW9G7qWiMYL8s7pO25sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hpnl5HQqsYsQeVyDXJirh+n0BeNPRVw8yA0yyvu2868=; b=c4lsy8i26Ob11gC2tLaLnwFfolOWiVsr4/tjwUXsFUhxDaGXoJddIPMXe/K6LrJlqfgXnQEt8c1CQqhJQHIfWSwVUF4shYvxb+d2Y1j/cWp/Q3VHzOrv+WXjjaIpXziVnaKWB/tZiou3PTtgbVH4gD69U9RK7A1+Y3xVamU0rRI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <647f254d-0af6-ea2c-f15e-bcab5a611a98@amd.com> Date: Fri, 18 Nov 2022 08:47:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Content-Language: en-US To: Jiamei Xie , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , "Volodymyr Babchuk" , Wei Chen References: <20221118020013.125987-1-jiamei.xie@arm.com> From: Michal Orzel In-Reply-To: <20221118020013.125987-1-jiamei.xie@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT040:EE_|CY5PR12MB6407:EE_ X-MS-Office365-Filtering-Correlation-Id: af107f6e-cfc6-4828-8d7a-08dac939245f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hx5DJWifNtFsLgYfl5fN+r2XIjg4YUwdStiHc5niu7GErfmmMwseMVGFOnHgqP58JxcpGTrQj+3gdEMDaSVw1EI83SySeqqTXBZDqQOllIs4Jen3IR5gXbc10xoshf4HE8m14fWDj50bmXNtEGi1Rr3l/18+lOmIHh++xU91SLNNT3cAApxxdRyrQ7c/Y4mLmTMCfRSdr0DCafRuoCKeZkKtNABVxUPHu6LkF3x8plpM2TsHDf5TIjMgE0EHoqpqmcf0mG2iS08Uh1W2R9gjQIMpBL5ne8jCvVL6LDHWJJZY8EtJ7tz44hNwKG7tozoEQLc0e3TrgyErAv7XE6kwb/sFpUOxZxI/7ltu0c0Fb3ZTdeyr+UfLR37ebsmOXE3o/YtXpUmrr6dUskbxAXpoIbbkZQ4RL2IXu7H9iuNZVrrPZOoxK7Ekdldd2mAQzxd52dx+P3Yx/MQoCQ1KxVfPV4/okeG8oZTbkwlzdEL941QuIl9+PEPig0FjfU5Q8HEslOPiwrAXeM9CQQPp4gOKEitKmF8Fzv6tiXEc3aUoFzLpfR9rnSy+/YKygIO+biMuNN4rpNZnsPYbwze3/ouWp5ANqaL5lt5RIHT6CRttPa/kuJrhise9ZEOUTxF9Y2akM37/ImEcCebsoTw2ewLoG3J0kFQl7B1yI7gteSrNMelwF/OJjdprhPIocf6JmvBFCckZ5EtDN20/scmyQQsWiVNGnn2Tzv1kWpe8OaalcCzsHanTwDGalN+DSP/goAC3vZK8l9OOlSnOSFPo5gn5+/m+u24o0h+Skfsf6MyNvstokfb3qNvy0YtQA6Yx6Gp10QDn70DrRorXOuQlh0gHdA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(39860400002)(396003)(451199015)(36840700001)(40470700004)(46966006)(31686004)(40460700003)(36756003)(82310400005)(31696002)(86362001)(3480700007)(81166007)(82740400003)(40480700001)(336012)(36860700001)(356005)(53546011)(47076005)(426003)(83380400001)(186003)(2616005)(26005)(316002)(8676002)(110136005)(478600001)(2906002)(41300700001)(7116003)(16576012)(54906003)(5660300002)(70586007)(966005)(4326008)(44832011)(8936002)(70206006)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 07:47:28.6126 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af107f6e-cfc6-4828-8d7a-08dac939245f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT040.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6407 Hi Jimaei, On 18/11/2022 03:00, Jiamei Xie wrote: > > > Date: Thu, 17 Nov 2022 11:07:12 +0800 > Subject: [PATCH] xen/arm: vpl011: Make access to DMACR write-ignore > > When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", > Linux SBSA PL011 driver will access PL011 DMACR register in some > functions. As chapter "B Generic UART" in "ARM Server Base System > Architecture"[1] documentation describes, SBSA UART doesn't support > DMA. In current code, when the kernel tries to access DMACR register, > Xen will inject a data abort: > Unhandled fault at 0xffffffc00944d048 > Mem abort info: > ESR = 0x96000000 > EC = 0x25: DABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > FSC = 0x00: ttbr address size fault > Data abort info: > ISV = 0, ISS = 0x00000000 > CM = 0, WnR = 0 > swapper pgtable: 4k pages, 39-bit VAs, pgdp=0000000020e2e000 > [ffffffc00944d048] pgd=100000003ffff803, p4d=100000003ffff803, pud=100000003ffff803, pmd=100000003fffa803, pte=006800009c090f13 > Internal error: ttbr address size fault: 96000000 [#1] PREEMPT SMP > ... > Call trace: > pl011_stop_rx+0x70/0x80 > tty_port_shutdown+0x7c/0xb4 > tty_port_close+0x60/0xcc > uart_close+0x34/0x8c > tty_release+0x144/0x4c0 > __fput+0x78/0x220 > ____fput+0x1c/0x30 > task_work_run+0x88/0xc0 > do_notify_resume+0x8d0/0x123c > el0_svc+0xa8/0xc0 > el0t_64_sync_handler+0xa4/0x130 > el0t_64_sync+0x1a0/0x1a4 > Code: b9000083 b901f001 794038a0 8b000042 (b9000041) > ---[ end trace 83dd93df15c3216f ]--- > note: bootlogd[132] exited with preempt_count 1 > /etc/rcS.d/S07bootlogd: line 47: 132 Segmentation fault start-stop-daemon > > As discussed in [2], this commit makes the access to DMACR register > write-ignore as an improvement. As discussed earlier, if we decide to improve vpl011 (for now only Stefano shared his opinion), then we need to mark *all* the PL011 registers that are not part of SBSA ar RAZ/WI. So handling DMACR and only for writes is not beneficial (it is only fixing current Linux issue, but what we really want is to improve the code in general). > > [1] https://developer.arm.com/documentation/den0094/c/?lang=en > [2] https://lore.kernel.org/xen-devel/alpine.DEB.2.22.394.2211161552420.4020@ubuntu-linux-20-04-desktop/ > > Signed-off-by: Jiamei Xie > --- > xen/arch/arm/vpl011.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c > index 43522d48fd..80d00b3052 100644 > --- a/xen/arch/arm/vpl011.c > +++ b/xen/arch/arm/vpl011.c > @@ -463,6 +463,7 @@ static int vpl011_mmio_write(struct vcpu *v, > case FR: > case RIS: > case MIS: > + case DMACR: > goto write_ignore; > > case IMSC: > -- > 2.25.1 > > ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 18 08:35:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 08:35:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445486.700660 (Exim 4.92) (envelope-from ) id 1ovwqI-0002nv-FI; Fri, 18 Nov 2022 08:35:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445486.700660; Fri, 18 Nov 2022 08:35:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovwqI-0002no-CU; Fri, 18 Nov 2022 08:35:22 +0000 Received: by outflank-mailman (input) for mailman id 445486; Fri, 18 Nov 2022 08:35:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovwqG-0002ni-OV for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 08:35:21 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20630.outbound.protection.outlook.com [2a01:111:f400:7eaf::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eca2a962-671b-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 09:35:19 +0100 (CET) Received: from DB9PR06CA0015.eurprd06.prod.outlook.com (2603:10a6:10:1db::20) by VE1PR08MB5663.eurprd08.prod.outlook.com (2603:10a6:800:1a4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.8; Fri, 18 Nov 2022 08:35:11 +0000 Received: from DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1db:cafe::d5) by DB9PR06CA0015.outlook.office365.com (2603:10a6:10:1db::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 08:35:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT041.mail.protection.outlook.com (100.127.142.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 08:35:10 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Fri, 18 Nov 2022 08:35:10 +0000 Received: from 304967566076.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6CE536D8-7FB3-40F3-B373-7542C27BD48B.1; Fri, 18 Nov 2022 08:34:59 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 304967566076.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 08:34:59 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11) by DBAPR08MB5831.eurprd08.prod.outlook.com (2603:10a6:10:1a8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 08:34:53 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f]) by AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f%3]) with mapi id 15.20.5834.006; Fri, 18 Nov 2022 08:34:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eca2a962-671b-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cFSG4MkciGbr4aNQsH1DMi4AeBS0ZN3LvgHSVbUhh1w=; b=YhOtD1hRGYWfsjwz7ng9nkBr4U28KrQ98MM8ei5AaO68VqJXtp2PskCiZIPAUTM8xNq2QDI2hq51l6wVZt0jOr/mfvNLHtC+iCf4+9w3xV+pO7w8PAQoqlLKhlvuQrhd+Kf1v8F5betgDhqb9sF30JwpOFXeFU/Kr+7jmif9jR4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JcqYOpo5PEVtuzyiP1G55hz2bBxkKB/sfKuRnitX0XZ34qvFzoxEK62LxBGn+Pr00JJw9GrhLGqmd7D0DDuPu9BM2P/LRURCUZqQN4yYgwgesVbdap7LtZsMArHBayG1SaCHka2GZwsfo63zEcyEGnuuC2TTutPXeYPeDE6oFppdL2+uYNojJV1mITY8u1SWN6hWb+7pIeTfp3syUmgDsGZDnIp4Qp1gpirGSka5/kXBjpDujmL22KIZKnxkDpRHZbPjO518Gvr8x4mOwyYPhHdVPzCuKs+dVEI/WpL2uxpvnsZMj51Qbpuz2Wrgp1F55OnwBKJEdNYDj6YHdjpqgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cFSG4MkciGbr4aNQsH1DMi4AeBS0ZN3LvgHSVbUhh1w=; b=A19h0FXTi3lhFAZ4vggsxO3GpcD6dx7nMC5BJ6ql6KUyxqyrfffT/X8Q24TQ0wjVrj+Jr+Ya3tXl5jGaNu8nPLrA+pVul0uVD4y6ZmxOybfx/ZTSyDIGe1dA8w0SI9neTSzc9LEMtkjVAEJ2+EGzJRdRRtRl0kcqberqkqjQN35/IrqevztZvMcvXJP+HCdOC3JB4N7bWZWtuhv6hos5Zb2rZrC+BzbifhF+zcBJuQnXHkJn8EOa+Ag1SGNGlbNNrWza5A6VEaHRKz8KBUszanGITcYFJK81yEsQUpFSpV07e7uLCJNXADCYxDGi6HIMdIhsa52fkRjzBXUi9LmGLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cFSG4MkciGbr4aNQsH1DMi4AeBS0ZN3LvgHSVbUhh1w=; b=YhOtD1hRGYWfsjwz7ng9nkBr4U28KrQ98MM8ei5AaO68VqJXtp2PskCiZIPAUTM8xNq2QDI2hq51l6wVZt0jOr/mfvNLHtC+iCf4+9w3xV+pO7w8PAQoqlLKhlvuQrhd+Kf1v8F5betgDhqb9sF30JwpOFXeFU/Kr+7jmif9jR4= From: Jiamei Xie To: Michal Orzel , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Wei Chen Subject: RE: [PATCH] xen/arm: vpl011: Make access to DMACR write-ignore Thread-Topic: [PATCH] xen/arm: vpl011: Make access to DMACR write-ignore Thread-Index: AQHY+vGVwMcRKiwWvE6rnRakCwDYs65D8jVggABaT4CAAA4LcA== Date: Fri, 18 Nov 2022 08:34:53 +0000 Message-ID: References: <20221118020013.125987-1-jiamei.xie@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 561D6B2A5DB82340A8A320AEAA0F9E25.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7696:EE_|DBAPR08MB5831:EE_|DBAEUR03FT041:EE_|VE1PR08MB5663:EE_ X-MS-Office365-Filtering-Correlation-Id: ec05a832-6339-4f88-ba02-08dac93fce42 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: I5uARwfV1evLnMzawjm7rbbASSbeu+j6PEFH35rk/ccX1EDE/FstUFbDyOpNxknehoA9pu8COjoXdpWVahltlAi5l4GCDpKbuQ1/jwKXxVcOUVAGMELMoTU8tUr5x5U/y110He5gQMhG6Vg/N8BVcoemJuw/Gu5AqIT3Wecyl+TvbKHiMfelqV2tlBe0L6xiT3wB+AcodsXiIz8Au8qC39mI6WVM/Io3q5eAU4TBOEY4g0zEj7EGX5L3J0ku77NrmHdD5L7rgrH1D4JRdTGLJSxycbm4aaZcUWCpO6ZaTFYaVEmBJ4N4jh0yqlSsh0GF8rbl6PqHZ1J3XGgPgbZhuOs0FOpNvZPoC5/6ddwhDGqsstZdAIztbO9cNhlHY6zjVrdgsDbhTp0iw1apjfDFxZoLnDR0waAvJcrsFlcAajKdNx4eLtMcohwaalthDXXvi4JfT9MOD43rBejG7tnqXw0YohT3pQ4Ex7dXmqaoBzGeLjsG1BCUhm6BGvH/iUH4jFd5BQqyph05+qHDFXwaRTrQgweeAUrw3y9YmOSOXEEA/qwizS/VRJYCJ8+2SjP0whbfv+GxZcNXPUI4tQiyDjpNscvb1C/xmZ+JDPKcwZ8GdlZjSAkBCohPWiKy+e1QijGiUT3i3sneIH5TR1002VYbR6UKZ1nsFWb8sSIkMEL38srwEYDkITjMvUXt01XYbjWPBPrGhu3zRERPiz+nCg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(366004)(396003)(39860400002)(346002)(451199015)(33656002)(38100700002)(66946007)(8936002)(2906002)(4326008)(38070700005)(4744005)(86362001)(122000001)(83380400001)(54906003)(316002)(186003)(110136005)(64756008)(478600001)(52536014)(76116006)(5660300002)(8676002)(66556008)(41300700001)(66446008)(66476007)(9686003)(7696005)(53546011)(26005)(71200400001)(55016003)(6506007);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5831 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7afd9f3d-fd2b-4c01-0fbf-08dac93fc404 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XqTAq8jaxuscRhDhQNyoMLNgS9hHuEFYKoxu9SzLEYCUnTCogGf0ENAqFE0r+6GVz5tDQ9RMZ0eZOj7NIz1Lk4XQm5EK0ql2Ll8NFLPy+wOde60A65cFHUu23MmeHnWclPt5PLYSSINA5vi4IKQx07SJd0TqkFwdnyaAY9gPD/goXXg5L9tDznPUka7tCIL0BHf4SEKT0AC7XG1kMlVyYay8fj7s54iBB4KkKjVemj0FJY7EOLgrXhpi3ga+bIINvNwJVG9BYf2XEcVMEoz983S6eOXxP3L4M95k+PhcROMFnofRZwzfkp+/QO/uZ9Uo8IUMnbIEz5tExKIYESX7/4PToTcq63BfSc6jR1dWcumJOd9OZTo9BF/+dANe5cd4AreQVn6kMU8YeFq6NY58muxkVGGFvMj8fiO6RjxJMmHwEP14gcmCnYfZmXh1ocAAOJ7TRD8PY4xhfm9VHaO+HyhGODFF3qsyuA719cJk16QD30PVkP/CcSe4j7lnQqjWMXE/vItMK3MZQA1YLiHFyzJ2VxRJ+88bBIuUNPeeEkVuNi61w+2mIrnNh4vEOVfJZgiWSbF7E+4+sb8GFc+qCtLg3VDwKAi65pESGcUDjR9ySu3r7nynsQlBmm1T0gQ2oZoX0hImN++On8t532XBTLl2ePeJr7ZlJeYjId5Z6G8v1hltPG1NklPGYRwNxmkd3bSNmsyVMNrFNoP5kjCaIg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199015)(36840700001)(46966006)(40470700004)(53546011)(82310400005)(86362001)(6506007)(7696005)(9686003)(26005)(478600001)(54906003)(110136005)(316002)(40460700003)(186003)(47076005)(336012)(356005)(81166007)(8676002)(70206006)(70586007)(4326008)(41300700001)(40480700001)(8936002)(55016003)(52536014)(4744005)(5660300002)(33656002)(36860700001)(2906002)(82740400003)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 08:35:10.6792 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ec05a832-6339-4f88-ba02-08dac93fce42 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5663 SGkgTWljaGFs77yMDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogTWlj aGFsIE9yemVsIDxtaWNoYWwub3J6ZWxAYW1kLmNvbT4NCj4gU2VudDogRnJpZGF5LCBOb3ZlbWJl ciAxOCwgMjAyMiAzOjQyIFBNDQo+IFRvOiBKaWFtZWkgWGllIDxKaWFtZWkuWGllQGFybS5jb20+ OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gQ2M6IFN0ZWZhbm8gU3RhYmVsbGlu aSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+ Ow0KPiBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBWb2xvZHlt eXIgQmFiY2h1aw0KPiA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+OyBXZWkgQ2hlbiA8V2Vp LkNoZW5AYXJtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSF0geGVuL2FybTogdnBsMDExOiBN YWtlIGFjY2VzcyB0byBETUFDUiB3cml0ZS1pZ25vcmUNCj4gDQo+IEhpIEppYW1laSwNCj4gDQo+ IE9uIDE4LzExLzIwMjIgMDM6MTgsIEppYW1laSBYaWUgd3JvdGU6DQo+ID4NCj4gPg0KPiA+IEhp DQo+ID4NCj4gPiBTb3JyeSB0aGVyZSBpcyBubyBzdWJqZWN0IGluIHRoZSAgbGFzdCBlbWFpbC4g U28gYWRkIGluIHRoaXMgb25lLg0KPiBJIHdvdWxkIGNvbnNpZGVyIHJlLXB1c2hpbmcgdGhpcyBw YXRjaChhbHRob3VnaCBwbGVhc2Ugd2FpdCBmb3Igc29tZQ0KPiBjb21tZW50cykuDQo+IFRoZSBy ZWFzb24gYmVpbmcsIGEgcGF0Y2ggd2l0aG91dCBhIHN1YmplY3QgaXMgbm90IHBpY2tlZCBieSBw YXRjaHdvcmsvYjQgb3INCj4gb3RoZXINCj4gdG9vbHMgdXNlZCB0byBncmFiIGEgcGF0Y2guDQpH b3QgaXQsIHRoYW5rcyENCg0KQmVzdCB3aXNoZXMNCkppYW1laSBYaWUNCg0KDQo+IA0KPiB+TWlj aGFsDQoNCg== From xen-devel-bounces@lists.xenproject.org Fri Nov 18 08:53:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 08:53:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445494.700671 (Exim 4.92) (envelope-from ) id 1ovx7k-0005WS-2s; Fri, 18 Nov 2022 08:53:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445494.700671; Fri, 18 Nov 2022 08:53:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovx7j-0005WL-Vs; Fri, 18 Nov 2022 08:53:23 +0000 Received: by outflank-mailman (input) for mailman id 445494; Fri, 18 Nov 2022 08:53:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovx7i-0005WD-Ir for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 08:53:23 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20624.outbound.protection.outlook.com [2a01:111:f400:7e8a::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 721ce830-671e-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 09:53:19 +0100 (CET) Received: from BN9P222CA0003.NAMP222.PROD.OUTLOOK.COM (2603:10b6:408:10c::8) by SN7PR12MB6690.namprd12.prod.outlook.com (2603:10b6:806:272::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Fri, 18 Nov 2022 08:53:16 +0000 Received: from BL02EPF0000C402.namprd05.prod.outlook.com (2603:10b6:408:10c:cafe::6d) by BN9P222CA0003.outlook.office365.com (2603:10b6:408:10c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 08:53:16 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0000C402.mail.protection.outlook.com (10.167.241.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 08:53:14 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 02:53:14 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 02:53:09 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 721ce830-671e-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YW74CBKz9q2PULbXpNIzKVf9LNyymMQZNx4P7IweS36Uo94xVKWI0USRpiae6TV0pjHjz0nBtK5eYK4IvvDFUUREHXt0+1NXaTUp/Ku53lREy1pJPU+NUcoNYkloH3yT+EVc7OzELqj1jkqOpcVHWOZEO/eMuJE7wBAhZtlxzrAsk8TJXMdcnvY2a9ufux/B+J53PaRb9Vloda8tihWZ3uqHveaGv9Fgxnov/oT2rO3nNsvUiWcxGYJMZOHS7z57ByJbnvlwIDLcWtJMmlh177U5WlKCfuHxScljcDZBITwY9HDtKUV/Xh3oA5PYZyZYRNVgvbq0VPzmnfT+l4MeNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=16cFksNDdMSBBWTW4A9NVEIxCll2RCqB1/c4Vyb7GO8=; b=ZlOxydkrKxhf0rjDnHLlM0SpEqzq0wZE1gjQ/qEqdnjPiLUPQd2OR5fDFp3fBjOjsQrKbr7ztZtnkS4rcJJ5mroGt7YwZnlwRPx2Pgrt/9s0I3vBy1ib5EFETKLNRgp/PHiodMf5ruxQUD/2YKb1zv4IzaZMtSm44XaAKTCakL00AMV0t5FwzaDPDsUvle/GmvKE57+S7usmEuLDkzTL5c/xiPBKvf8PTJ+HtLf2ZG/U0rnFC4Jgr/xB1mZazKcKGwQPncsNpk1rnclzCC3eg2b7EHF9Q9zxmFaApwB8UgdZkw8JrM1j8ZX8FaWUV+xMUFkLP2VgZPbZsSJpRLE88A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=16cFksNDdMSBBWTW4A9NVEIxCll2RCqB1/c4Vyb7GO8=; b=ZdJDMFqQTy7BFpmy0LFwGFAMQKo8KHusCQirijTvKsUWPX7W5H4+MJIYQugbKkkFPKSnq8yQSULp1lXOp1GraRXZI7JNtCWZMocaaETyHlf3nGMxq4dNBg7cpYCvhMXU3+nlasdNWaymcUVXKEP+XClE/QQEAhCn59053v8Q3Kk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <60ff35c3-0b3a-7c9f-edf5-0639056570d7@amd.com> Date: Fri, 18 Nov 2022 09:53:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 1/3] automation: Create Yocto docker images Content-Language: en-US To: Bertrand Marquis , CC: Doug Goldstein , Stefano Stabellini References: <6d48a0f83324d2f42597d43c41ce72d6d80150e6.1668677493.git.bertrand.marquis@arm.com> From: Michal Orzel In-Reply-To: <6d48a0f83324d2f42597d43c41ce72d6d80150e6.1668677493.git.bertrand.marquis@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0000C402:EE_|SN7PR12MB6690:EE_ X-MS-Office365-Filtering-Correlation-Id: d11daa66-ec0d-4468-35b8-08dac9425486 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sVmtCfkBeNHN/jSJskDf2qa1Axz0STg2KRu+hmvPI/VTz26t6b7sNdho9GEDcQSbbVHih60CUFhAKI72NPvkIUpZllGpkG5Tk73HCA6+jPmBlvj5ujUIZNUfkD95IQcji3irQ/7vmWKPWbChfVxgQ8ME2a+KKEIhsYzG79WWvFOrtPypp/DqLviGieAY3V7q31wakD6lPDAlZ/EHn2xhspsYgjIseNheC0LsJR4ga0RlDMLuZIsoUq9Aldu42hlyTYGxK39GloWxBDpfn51Nev4xlv7eQQRAXqfjWyBepgTPILA+sdSq6bC42093jcVVjBd4PF/xLxM9nZbM7W4fnMbmx/Voqzj4G9ilWxEh0NVo9Ns483jWFqpEt5dlE16pz/v3VubMlReJ/sdkvRoO67OvgpZW2VP1Q7/yZm/YfgUzEhgxCmJG2EwW3gVXExz+vaia269D0Ek+Kw1O9u1SyXaG8Z2z1ZlBWcsg7CPKG/ESS4j6zwfQuiG86uGbn6xTNGYYvLYaWScElq7I2IEJC3bbn09KN3UJ2a9Cr6mCE2t5rIgK2uBj1nrKaDTdZ3uzZh30Iw6g1dE3WhF2bBRV/UF9TrvTeA03CLzZApVYY7J+KY5nArJnnrUkILEJEXzhCNoFUCrBNMDIsmL2XtNnKwHZK04/PHFNHV/QED484jOHpq1DN2Y/inRReXp8G1P2OGKOrVcZXG/+Aqe7SIn5NWZpfJeqwWAmDG1sVAmfDXy/ZO0d4jpRYaKBQSBpNhzEUEHligGKxzpo2V9a/7NOZOB3odZYgOYuHghx98G2KoFxxl8WW79Up4nIL0UJRc0hLNfIHGTbljbtM+IAHjMVkg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(31696002)(316002)(53546011)(36860700001)(16576012)(8936002)(2616005)(186003)(82310400005)(8676002)(966005)(84970400001)(70586007)(70206006)(4326008)(5660300002)(54906003)(40480700001)(44832011)(81166007)(83380400001)(26005)(40460700003)(110136005)(36756003)(356005)(426003)(82740400003)(478600001)(31686004)(336012)(86362001)(2906002)(30864003)(47076005)(41300700001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 08:53:14.8983 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d11daa66-ec0d-4468-35b8-08dac9425486 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0000C402.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6690 Hi Bertrand, Just, some minor comments. On 17/11/2022 10:39, Bertrand Marquis wrote: > > > Add containers suitable to run yocto kirkstone build based on ubuntu > 22.04. It contains all packages required by Yocto and a checkout of the > layers required to build Xen with Yocto. > > Add a generic docker image template to be used to automatically generate > docker files for different configurations: > - specific yocto version > - different targets (qemu arm, arm64 and x86) > - different host platforms (x86 or arm64) > > During a call to 'make all', only the images for the current host > platform will be generated. This looks like a stale comment. The reason being, in the new version, by default we build the images for the architectures expected by the CI and its runners to match the current workflow. > If needed, images for an other host platform can be generated manually > by calling the right make target (see make help). > > Add a build script to build and run xen on qemu using Yocto. > The script supports arm32, arm64 and x86_64 and checks that dom0 is > properly booting. At this stage this does not run any guest on top of > dom0. The script is to be executed in one of the docker images to build > and run a system using a Xen source tree. > > Signed-off-by: Bertrand Marquis > --- > Changes in v4: > - Rework the system to have one dockerfile template from which make will > generate the required dockerfiles for the wanted configuration That is great. > - add support for different host architectures > - Merge the generation system into one single dockerfile > - Merge patches 1 and 2 in a single patch > - Introduce CONTAINERS_EXTRA to have extra containers not built by > default (for those not used by CI but useful to users) > Changes in v3: > - limit number of jobs in yocto by default to 8 and add --num-jobs > option to the script to set a custom number of jobs > - do not copy anymore the build-yocto.sh script inside the main image so > that the current one in the repository is used when running > Changes in v2: > - add a --dump-log command line option to build-yocto.sh script to dump > the logs if an error occurs. > Changes in v1: > - add --image command line argument to build-yocto.sh to allow building > something different than xen-image-minimal. > - modify dockerfile to have one layer per line and make it easier to add > other. I kept the for loop to keep the number of docker steps lower > - update commit message to warn that no guest are tested. > - fix build-yocto script to properly return with an error if expect > script ends up in timeout or EOF. > --- > automation/build/Makefile | 14 +- > automation/build/yocto/build-yocto.sh | 349 +++++++++++++++++++++ > automation/build/yocto/yocto.dockerfile.in | 114 +++++++ > automation/build/yocto/yocto.inc | 41 +++ > 4 files changed, 516 insertions(+), 2 deletions(-) > create mode 100755 automation/build/yocto/build-yocto.sh > create mode 100644 automation/build/yocto/yocto.dockerfile.in > create mode 100644 automation/build/yocto/yocto.inc > > diff --git a/automation/build/Makefile b/automation/build/Makefile > index a4b2b85178cf..72a5335baec1 100644 > --- a/automation/build/Makefile > +++ b/automation/build/Makefile > @@ -1,13 +1,18 @@ > > # the base of where these containers will appear > REGISTRY := registry.gitlab.com/xen-project/xen > -CONTAINERS = $(subst .dockerfile,,$(wildcard */*.dockerfile)) > +CONTAINERS = $(filter-out yocto/%,$(subst .dockerfile,,$(wildcard */*.dockerfile))) > +CONTAINERS_EXTRA = > DOCKER_CMD ?= docker > > +include yocto/yocto.inc > + > help: > @echo "Builds containers for building Xen based on different distros" > @echo "To build one run 'make DISTRO/VERSION'. Available containers:" > @$(foreach file,$(sort $(CONTAINERS)),echo ${file};) > + @echo "Extra containers (not built using make all):" > + @$(foreach file,$(sort $(CONTAINERS_EXTRA)),echo ${file};) > @echo "To push container builds, set the env var PUSH" > > %: %.dockerfile ## Builds containers > @@ -16,5 +21,10 @@ help: > $(DOCKER_CMD) push $(REGISTRY)/$(@D):$(@F); \ > fi > > -.PHONY: all > +.PHONY: all clean > all: $(CONTAINERS) > + > +# Remove generated dockerfiles for yocto > +clean: > + rm -f yocto/*.dockerfiles Are these files needed after make is completed? If not, maybe to avoid having some untracked files in the tree, they could be removed after make is done? > + > diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh > new file mode 100755 > index 000000000000..d0c93dfaffe0 > --- /dev/null > +++ b/automation/build/yocto/build-yocto.sh > @@ -0,0 +1,349 @@ > +#!/bin/bash > +# > +# Yocto meta virtualization build and run script > +# > +# This script is building Yocto xen-image-minimal for qemu targets and run > +# them using runqemu inside yocto to check that dom0 is booting properly Missing dot at the end of a sentence. > +# The build is using a local xen source tree so that specific patches can be > +# tested. > +# In order to optimize the build time, a build cache is used so that only xen > +# packages and its dependencies are rebuilt (qemu and final image mainly). > +# > + > +# Directories > +YOCTODIR="$HOME/yocto-layers" > +CACHEDIR="$HOME/yocto-cache" > +LOGDIR="$HOME/logs" > +XENDIR="$HOME/xen" > +BUILDDIR="$HOME/build" > + > +# what yocto bsp we support > +TARGET_SUPPORTED="qemuarm qemuarm64 qemux86-64" > +VERBOSE="n" > +TARGETLIST="" > +BUILDJOBS="8" > + > +# actions to do > +do_clean="n" > +do_build="y" > +do_run="y" > +do_localsrc="n" > +do_dump="n" > +build_result=0 > + > +# layers to include in the project > +build_layerlist="poky/meta poky/meta-poky poky/meta-yocto-bsp \ > + meta-openembedded/meta-oe meta-openembedded/meta-python \ > + meta-openembedded/meta-filesystems \ > + meta-openembedded/meta-networking meta-virtualization" > + > +# yocto image to build > +build_image="xen-image-minimal" > + > +function print_progress() { > + echo -n "$(date +%T) $*" > +} > + > +function run_task() { > + local task_name="$1" > + local task_target="$2" > + > + task_log="${task_name//project_}-${task_target}" > + > + mkdir -p "${LOGDIR}" > + print_progress > + echo -n "${task_name//project_} ${task_target}: " > + if [ "${VERBOSE}" = "n" ]; then > + $@ > "${LOGDIR}/${task_log}.log" 2>&1 > + else > + $@ 2>&1 | tee "${LOGDIR}/${task_log}.log" > + fi > + > + if [ ${?} -ne 0 ]; then > + echo "Error" > + build_result=$((build_result+1)) > + if [ "${do_dump}" = "y" ]; then > + echo > + echo "############ LOGS-START ############" > + cat "${LOGDIR}/${task_log}.log" > + echo "############ LOGS-END ############" > + echo > + fi > + return 1 > + else > + echo "OK" > + return 0 > + fi > +} > + > +function project_create() { > + target="${1:?}" > + destdir="${BUILDDIR}/${target}" > + > + ( > + # init yocto project > + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" > + > + # add needed layers > + for layer in ${build_layerlist}; do > + bitbake-layers add-layer ${YOCTODIR}/${layer} || exit 1 > + done > + ) || return 1 > + > + # customize project configuration > + cat <> "${destdir}/conf/local.conf" > +# Yocto BSP > +MACHINE = "${target}" > + > +# Use local cache to reuse previous builds results > +SSTATE_DIR = "${CACHEDIR}/sstate-cache" > +DL_DIR = "${CACHEDIR}/downloads" > + > +# Enable xen and virtualization > +DISTRO_FEATURES = " virtualization xen ipv4" > + > +# Speed up run by not generating ssh host keys > +IMAGE_INSTALL:append:pn-xen-image-minimal = " ssh-pregen-hostkeys" > + > +# Save some disk space > +INHERIT += "rm_work" > + > +# Reduce number of jobs > +BB_NUMBER_THREADS="${BUILDJOBS}" > + > +EOF > + > + if [ "${do_localsrc}" = "y" ]; then > + XENVERS=$(grep -e "^XEN_REL" \ > + "${YOCTODIR}"/meta-virtualization/recipes-extended/xen/xen_*.bb \ > + 2> /dev/null | tr -d ' ' | tr -d '?' | tr -d '"' \ > + | sed -e "s/.*=//" | sort -V | tail -n 1) > + > + XENBASE=$(dirname "$(realpath -m "${XENDIR}")") > + XENSUB=$(basename "$(realpath -m "${XENDIR}")") > + > + cat <> "${destdir}/conf/local.conf" > +# Use local sources for xen and xen-tools > +FILESEXTRAPATHS:prepend:pn-xen := "${XENBASE}:" > +FILESEXTRAPATHS:prepend:pn-xen-tools := "${XENBASE}:" > + > +SRC_URI:pn-xen = "file://${XENSUB}/;subdir=local-xen/" > +SRC_URI:pn-xen-tools = "file://${XENSUB}/;subdir=local-xen/" > + > +PREFERRED_VERSION:pn-xen = "${XENVERS}%" > +PREFERRED_VERSION:pn-xen-tools = "${XENVERS}%" > + > +S:pn-xen = "\${WORKDIR}/local-xen/${XENSUB}" > +S:pn-xen-tools = "\${WORKDIR}/local-xen/${XENSUB}" > + > +SRCREV:pn-xen = "\${AUTOREV}" > +SRCREV:pn-xen-tools = "\${AUTOREV}" > + > +SRCPV:pn-xen = "1" > +SRCPV:pn-xen-tools = "1" > + > +# Disable all QA errors as the recipe is not up to date with changes in Xen > +# when we use local sources > +ERROR_QA:pn-xen = "arch" > +ERROR_QA:pn-xen-tools = "arch" > + > +EOF > + fi > +} > + > +function project_build() { > + target="${1:?}" > + destdir="${BUILDDIR}/${target}" > + > + ( > + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" > + > + bitbake "${build_image}" || exit 1 > + ) || return 1 > +} > + > +function project_clean() { > + target="${1:?}" > + destdir="${BUILDDIR}/${target}" > + > + rm -rf "${destdir}" > +} > + > +function project_run() { > + target="${1:?}" > + destdir="${BUILDDIR}/${target}" > + ( > + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" > /dev/null 2>&1 > + > + /usr/bin/expect < +set timeout 100 > +spawn bash -c "runqemu serialstdio nographic slirp" > + > +expect_after { > + -re "(.*)\r" { > + exp_continue > + } > + timeout {send_user "ERROR-Timeout!\n"; exit 1} > + eof {send_user "ERROR-EOF!\n"; exit 1} > +} > + > +# wait initial login > +expect -re ".* login: " > +send "root\r" > +expect -re "root@.*# " > + > +EOF > + exit $? > + ) || return 1 > +} > + > +function help() { > + cat < +Usage: ${0} [TARGET1] [TARGET2] > + > +This script is build the yocto xen-image-minimal for different qemu targets > +and is running it after. > +Without any target specified, all supported targets are done. > + > +Options: > + -h, --help Print this help > + -v, --verbose Verbose build > + --list-target List supported targets > + --clean Clean existing project before starting > + --no-build Do not build (to run an already built project) > + --no-run Do not run > + --num-jobs=NUM Define the number of parallel jobs in Yocto. > + Default: ${BUILDJOBS} > + --dump-log On error, dump the logs on the console > + --image=IMG Yocto image or package to build > + Default: xen-image-minimal > + --xen-dir=DIR path to xen hypervisor source tree > + if not provide, normal yocto version of xen is built > + Default: ${XENDIR} > + --out-dir=DIR directory where to create the projectss > + Default: ${BUILDDIR} > + --log-dir=DIR directory to store logs > + Default: ${LOGDIR} > + --cache-dir=DIR directory where to take and store build cache > + Default: ${CACHEDIR} > + --layer-dir=DIR directory containing the checkout of yocto layers > + Default: ${YOCTODIR} > +EOF > +} > + > +for OPTION in "$@" > +do > + case ${OPTION} in > + -h|--help) > + help > + exit 0 > + ;; > + -v|--verbose) > + VERBOSE="y" > + ;; > + --list-targets) > + echo "${TARGET_SUPPORTED}" > + exit 0 > + ;; > + --clean) > + do_clean="y" > + ;; > + --no-build) > + do_build="n" > + ;; > + --no-run) > + do_run="n" > + ;; > + --dump-log) > + do_dump="y" > + ;; > + --num-jobs=*) > + BUILDJOBS="${OPTION#*=}" > + ;; > + --image=*) > + build_image="${OPTION#*=}" > + ;; > + --xen-dir=*) > + XENDIR="${OPTION#*=}" > + if [ ! -e "${XENDIR}/xen/Makefile" ]; then > + echo "No Xen source tree in ${XENDIR}" > + exit 1 > + fi > + do_localsrc="y" > + ;; > + --out-dir=*) > + BUILDDIR="${OPTION#*=}" > + ;; > + --log-dir=*) > + LOGDIR="${OPTION#*=}" > + ;; > + --cache-dir=*) > + CACHEDIR="${OPTION#*=}" > + ;; > + --layer-dir=*) > + YOCTODIR="${OPTION#*=}" > + ;; > + --*) > + echo "Invalid option ${OPTION}" > + help > + exit 1 > + ;; > + *) > + if echo "${TARGET_SUPPORTED}" | grep -q -w "${OPTION}"; then > + TARGETLIST="${TARGETLIST} ${OPTION}" > + else > + echo "Unsupported target ${OPTION}" > + exit 1 > + fi > + ;; > + esac > +done > + > +# if no target is specified build all targets > +if [ -z "${TARGETLIST}" ]; then > + TARGETLIST="${TARGET_SUPPORTED}" > +fi > + > +mkdir -p "${CACHEDIR}" > +mkdir -p "${LOGDIR}" > +mkdir -p "${BUILDDIR}" > + > +# Make sure we have an absolute path > +YOCTODIR=$(realpath -m "${YOCTODIR}") > +CACHEDIR=$(realpath -m "${CACHEDIR}") > +BUILDDIR=$(realpath -m "${BUILDDIR}") > +LOGDIR=$(realpath -m "${LOGDIR}") > +if [ "${do_localsrc}" = "y" ]; then > + XENDIR=$(realpath -m "${XENDIR}") > +fi > + > +# Check that we have all the layers we need > +for f in ${build_layerlist}; do > + if [ ! -f "${YOCTODIR}/${f}/conf/layer.conf" ]; then > + echo "Layer ${f} missing in ${YOCTODIR}" > + exit 1 > + fi > +done > + > +for f in ${TARGETLIST}; do > + if [ "${do_clean}" = "y" ]; then > + run_task project_clean ${f} > + fi > + if [ ! -f ${BUILDDIR}/${f}/conf/local.conf ]; then > + run_task project_create ${f} > + fi > + if [ -f ${BUILDDIR}/${f}/conf/local.conf ]; then > + if [ "${do_build}" = "y" ]; then > + run_task project_build ${f} > + fi > + if [ "${do_run}" = "y" ]; then > + run_task project_run ${f} > + fi > + > + fi > +done > + > +print_progress "Build Complete (${build_result} errors)" > +echo > +exit ${build_result} > + > diff --git a/automation/build/yocto/yocto.dockerfile.in b/automation/build/yocto/yocto.dockerfile.in > new file mode 100644 > index 000000000000..5350bb2b87b7 > --- /dev/null > +++ b/automation/build/yocto/yocto.dockerfile.in > @@ -0,0 +1,114 @@ > +# Docker file to create an environment to build yocto with virtualization > +# > +# Arguments that can be passed during image creation using --build-arg: > +# "host_uid=$(id -u)": to use current user uid for build user in the image > +# "host_gid=$(id -g)": to use current user gid for build user in the image > +# "ubuntu_version=VERS": to select the ubuntu version number Is is the case, that this dockerfile and the packages installed will work on any version of ubuntu we will pass here? If not, maybe we should just stick to 22.04 and not give the user the opportunity to change this. > + > +# Use standard ubuntu minimal > +ARG ubuntu_version=22.04 > +From ##DOCKERPLAT##ubuntu:$ubuntu_version AS base > +LABEL maintainer.name="The Xen Project " \ > + maintainer.email="xen-devel@lists.xenproject.org" > + > +ENV DEBIAN_FRONTEND=noninteractive > + > +# Install minimal ubuntu requirements for yocto and other tools we need > +# See https://docs.yoctoproject.org/4.0.1/brief-yoctoprojectqs/index.html#build-host-packages > +RUN apt-get update && \ > + apt-get --quiet --yes install \ > + gawk \ > + wget \ > + git \ > + diffstat \ > + unzip \ > + texinfo \ > + gcc \ > + build-essential \ > + chrpath \ > + socat \ > + cpio \ > + python3 \ > + python3-pip \ > + python3-pexpect \ > + xz-utils \ > + debianutils \ > + iputils-ping \ > + python3-git \ > + python3-jinja2 \ > + libegl1-mesa \ > + libsdl1.2-dev \ > + python3-subunit \ > + mesa-common-dev \ > + zstd \ > + liblz4-tool \ > + file \ > + vim \ > + bison \ > + expect \ > + locales \ > + liblz4-tool \ > + zstd \ > + openssl \ > + libssl3 \ > + ca-certificates \ > + && \ > + apt-get autoremove -y && \ > + apt-get clean && \ > + rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* > + > +# Use bash as shell > +RUN rm /bin/sh && ln -s bash /bin/sh > + > +# Fix local for yocto > +RUN locale-gen en_US.UTF-8 && update-locale LC_ALL=en_US.UTF-8 \ > + LANG=en_US.UTF-8 > +ENV LANG en_US.UTF-8 > +ENV LC_ALL en_US.UTF-8 > + > +# Create a user for the build (we don't want to build as root) > +ENV USER_NAME docker-build > +ARG host_uid=1000 > +ARG host_gid=1000 > +RUN groupadd -g $host_gid $USER_NAME && \ > + useradd -g $host_gid -m -s /bin/bash -u $host_uid $USER_NAME > + > +# Switch to our user instead of root and start in its home > +USER $USER_NAME > +WORKDIR /home/$USER_NAME > + > +# Create needed directories > +RUN mkdir -p /home/$USER_NAME/yocto-layers \ > + /home/$USER_NAME/yocto-cache \ > + /home/$USER_NAME/logs \ > + /home/$USER_NAME/bin \ > + /home/$USER_NAME/xen && \ > + chown $USER_NAME.$USER_NAME /home/$USER_NAME/* > + > +# clone yocto repositories we need > +RUN for rep in \ > + https://github.com/openembedded/meta-openembedded \ > + https://git.yoctoproject.org/poky \ > + https://git.yoctoproject.org/meta-virtualization \ > + ; do \ > + git -C /home/$USER_NAME/yocto-layers \ > + clone -b ##YOCTOVERSION## --single-branch $rep; \ > + done > + > +# The builder stage is building an initial cache state that we include in the > +# final image > +From base AS builder > + > +# This step can take one to several hours depending on your download bandwith > +# and the speed of your computer > +COPY ./build-yocto.sh / > +RUN /build-yocto.sh --dump-log ##YOCTOTARGET## > + > +From base > + > +# Only copy the cache status > +COPY --from=builder /home/$USER_NAME/yocto-cache /home/$USER_NAME/yocto-cache/. > + > +LABEL maintainer.name="The Xen Project " \ > + maintainer.email="xen-devel@lists.xenproject.org" > + > diff --git a/automation/build/yocto/yocto.inc b/automation/build/yocto/yocto.inc > new file mode 100644 > index 000000000000..04076bc8d174 > --- /dev/null > +++ b/automation/build/yocto/yocto.inc > @@ -0,0 +1,41 @@ > +# This makefile generates the docker files for Yocto builds > +# The containers for the current architecture are the one built using make all > +# To build containers for a different architecture, you need to call make for > +# the image you want explicitely Could you please add a dot at the end of each sentence above. This will improve readability. > +# The containers are named this way: > +# YOCTOVERSION-TARGET for x86_64 hosts > +# YOCTOVERSION-TARGET-arm64v8 for arm64 hosts > + > +# Yocto versions we are currently using > +YOCTO_VERSION = kirkstone > + > +# Yocto BSPs we want to build for > +YOCTO_TARGETS = qemuarm64 qemuarm qemux86-64 > + > +# Supported Host platforms (host architecture specific ones) To avoid mismatch \wrt platform vs architecture I would stick to the latter one. In the docker world, arm64v8 is an architecture whereas linux/arm64/v8 is a platform. > +YOCTO_HOSTS = amd64 arm64v8 > + > +# Architecture we want to use in gitlab CI (depends on runners arch) > +CI_ARCH = arm64v8 > + > +define GEN_DOCKER > +# Make all is generating what we want in the CI > +ifeq ($(CI_ARCH),$(3)) > +CONTAINERS += yocto/$(1)-$(2)$(4) > +else > +CONTAINERS_EXTRA += yocto/$(1)-$(2)$(4) > +endif > + > +yocto/$(1)-$(2)$(4).dockerfile: yocto/yocto.dockerfile.in > + echo > $$@ > + cat $$< | \ > + sed -e "s,##YOCTOVERSION##,$(1),g" | \ > + sed -e "s,##YOCTOTARGET##,$(2),g" | \ > + sed -e "s,##DOCKERPLAT##,$(3)/,g" > $$@ > + > +endef > + > +$(eval $(foreach vers,$(YOCTO_VERSION),\ > + $(foreach tar,$(YOCTO_TARGETS),\ > + $(foreach hst,$(YOCTO_HOSTS),\ > + $(call GEN_DOCKER,$(vers),$(tar),$(hst),$(if $(filter amd64,$(hst)),,-$(hst))))))) This could be aligned under first foreach. Also I think there is no need to try to shorten the version,target,host. > -- > 2.25.1 > ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 18 08:59:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 08:59:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445498.700682 (Exim 4.92) (envelope-from ) id 1ovxDE-0006AK-NM; Fri, 18 Nov 2022 08:59:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445498.700682; Fri, 18 Nov 2022 08:59:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovxDE-0006AD-K0; Fri, 18 Nov 2022 08:59:04 +0000 Received: by outflank-mailman (input) for mailman id 445498; Fri, 18 Nov 2022 08:59:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovxDD-0006A7-Mo for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 08:59:03 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eaa::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3e32b77d-671f-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 09:59:01 +0100 (CET) Received: from BN0PR07CA0017.namprd07.prod.outlook.com (2603:10b6:408:141::31) by BL3PR12MB6523.namprd12.prod.outlook.com (2603:10b6:208:3bf::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Fri, 18 Nov 2022 08:58:57 +0000 Received: from BN8NAM11FT064.eop-nam11.prod.protection.outlook.com (2603:10b6:408:141:cafe::fa) by BN0PR07CA0017.outlook.office365.com (2603:10b6:408:141::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 08:58:57 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT064.mail.protection.outlook.com (10.13.176.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 08:58:57 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 02:58:57 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 02:58:56 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e32b77d-671f-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LKJWz8ZBM/dzmJNrBECU4pxv7QL9K89lRamHne6O3pk3MjWhfGlVOWIBjM2Rp/JuSrGgVeeiPOfLu1AmppDcRVnHzb4YdbMSDhgP7x2wyQM4Tny6pcgcn5bp5nlHAEmo/2zPadWM0EH8XYVNpGc+cpxRBU4c2O97Mdhjt+R5U9/ZwQAcxcR0l3d5pPS5mt+g9ogzJvYW7e/iNELCiWzPIVMB905yylo2uJXCdtDSJq0Bk3N18pOvOD82be/snslYuwnVvGRaywbA63gnP+g3askGjA2XhZM2rPHtRxP+A5QtG4+fKY2sA9IiGxoqj0wfyY7OWB/klO4WX8CfXZcxhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bsMGNa8Ypjffr4ofXhsaDP269QpbB6DEbUFgt0QAfX0=; b=h8cuS/kMlKIbNSsrbgdGaRnVjH/7oQkwWNWAX+hMDhoSLRv5g7EkAB4olK8GTTzDFqKS0vGdr4qp2Oul+YLGUiY0mfahSyouHwqvFsNZ5xmEmMjMvC518klZfzqJPZ1ednqxKlq7ii/YCb7Y4bX6uLpBfA7Kam88O86S6JaWnqGj23KcXq62FZlLM8IiFpx2AAdtyIhWDCdZXLI560wVvOOxF2TQbygGDsiyZQlR7VMncM9LN2qFRwobGJy+osZLJE8cT6C00lFld/4Q7nJZgiaipTds+dzeeZTjFHi2nGk7hkK8dwV2IQK01vwtRpmP/MRlCIsAofN//DRow3P4Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bsMGNa8Ypjffr4ofXhsaDP269QpbB6DEbUFgt0QAfX0=; b=G1qK6uphJNMBQvH/GwIzWDKRh8TTSHW7NVmBIWaBMchZrw7WT7lbfVfFaFkT+U2GaXupk9VsL1yPYkgK+ctJmXcjDjumO260bPRZ4je4fZVyeTXagZA20GPDbMC9XFZ0Co1HxMLwQ4VsBrXnUdxRGHZMQzPTBX7meOZLZWOmpYQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Fri, 18 Nov 2022 09:58:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 2/3] automation: Add a clean rule for containers Content-Language: en-US To: Bertrand Marquis , CC: Doug Goldstein , Stefano Stabellini References: <3a127e836d744fbb2954690293ee47d2c0c899e2.1668677493.git.bertrand.marquis@arm.com> From: Michal Orzel In-Reply-To: <3a127e836d744fbb2954690293ee47d2c0c899e2.1668677493.git.bertrand.marquis@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT064:EE_|BL3PR12MB6523:EE_ X-MS-Office365-Filtering-Correlation-Id: 69aac28a-6d59-47c8-3907-08dac9432096 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mPwav3ey1dUl45EHLvAYA3Y0v12VfQZGfG5mvVjqVQUkcESrF9eXTd6yLYCWj2jDRBJYHHMWimRinatrBACgbcjnu6L/OdYkQ9aEUEAi1/kPow/IcWIMoYzC6i+REzo7HGPLK2lF4TWgZxErRRz/Pu5roO2AJrcQQ1jEpnVX3ItwwV8xUQ5eQLh4NuaPp6JCoElWCt+YjcTdTn+sZQNR6qWzcwuj6+lhIucotz7ExCotxQk32X19kAbcrgVf3c33aYxeBpqnaoiYSJ8zyqkGhl/P49b/6fwyj5qODXX/2Ak9UOH5I2RQErY4wVPMLG2byxzICpNDbZEGdvC+ZOmt/YYhbDRqm/l/UhwKnB5OV+vnK0jlmwF02oNBxZNEbGAssMfRq+xBkxGpPfOcoihJYsBwDJOXLyi5yDj3XOJMW7bCgNFj4WHMQXVCsvqD+EqKP6XtT/yay9d7dteFrcE8024Z2f9AAGDUbXPyKdOSw++oIP+5AR7zBz0WQG1mKZA56f0uvQrludItRDgOfYNUxyWCiPyv3kpfSdNfffOa4bQbWGxY4BYJOGgx900sfkVrXKNzObQ/VC9hvGHNuWmMPsoYB2PMbYvZQ17099BDbPCHeA+7hn40xS/2/6rvL4TtmVD8LkMAzHXTzsAefxcOphf9qlxVfYqH7EtHRL0i6dYPfU4tHYBo9KID3wpxr9EQIK/8rz2oWScN3LaxttfN4q+D/nJs4rzUjlk7jPJJ3EIAAfktdHpFg54v6O4hPOw8cFnGBoqd4zYxCnJqAnjgeA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199015)(40470700004)(36840700001)(46966006)(82740400003)(31696002)(356005)(36860700001)(82310400005)(41300700001)(81166007)(86362001)(8676002)(16576012)(40480700001)(478600001)(5660300002)(4744005)(316002)(8936002)(70586007)(70206006)(4326008)(110136005)(54906003)(2906002)(26005)(44832011)(186003)(2616005)(336012)(40460700003)(53546011)(47076005)(426003)(31686004)(36756003)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 08:58:57.2585 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69aac28a-6d59-47c8-3907-08dac9432096 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT064.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6523 Hi Bertrand, On 17/11/2022 10:39, Bertrand Marquis wrote: > > > Add make clean support to remove the containers from the local docker > registry: I have to say that I am a bit scared of adding a clean rule. make clean is something that can easily sneak into this directory and can remove the yocto images that we had to spent several hours to build. The accidental clean can have severe consequences :) In any case, if we want to add such possibility I would stick to calling always: make clean- and remove the option to call "make clean" to remove all the images. ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 18 09:02:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 09:02:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445504.700693 (Exim 4.92) (envelope-from ) id 1ovxGr-0007oU-Bs; Fri, 18 Nov 2022 09:02:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445504.700693; Fri, 18 Nov 2022 09:02:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovxGr-0007oN-7j; Fri, 18 Nov 2022 09:02:49 +0000 Received: by outflank-mailman (input) for mailman id 445504; Fri, 18 Nov 2022 09:02:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovxGp-0007oD-LI for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 09:02:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovxGp-0004dr-67; Fri, 18 Nov 2022 09:02:47 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[10.85.33.185]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ovxGo-0003hK-Uy; Fri, 18 Nov 2022 09:02:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=fNipC4p7+64jqKHpA0sK+fqI67xo6vHno8aq1XrXGTE=; b=ezjODNjL6XdcAs1AOp+DSpxSHm cHZTJKgwbW3J5cxEGqQ+u5BaYnc/JhR1jcMTs0Rrt9GNLlmHMxzZyw7qL0AMMkZwZ51tpYcwsDGgJ Vg6CQ6FXBy9lTSUQwnet5ZZkrCugX0Kks5RBOheVuiL9xrDjfVm1GZJySDxUvkovAorg=; Message-ID: <00538b43-fe66-5817-c9c9-738421441e85@xen.org> Date: Fri, 18 Nov 2022 09:02:44 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Content-Language: en-US To: Michal Orzel , Jiamei Xie , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Wei Chen References: <20221118020013.125987-1-jiamei.xie@arm.com> <647f254d-0af6-ea2c-f15e-bcab5a611a98@amd.com> From: Julien Grall In-Reply-To: <647f254d-0af6-ea2c-f15e-bcab5a611a98@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/11/2022 07:47, Michal Orzel wrote: > On 18/11/2022 03:00, Jiamei Xie wrote: >> >> >> Date: Thu, 17 Nov 2022 11:07:12 +0800 >> Subject: [PATCH] xen/arm: vpl011: Make access to DMACR write-ignore >> >> When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", >> Linux SBSA PL011 driver will access PL011 DMACR register in some >> functions. As chapter "B Generic UART" in "ARM Server Base System >> Architecture"[1] documentation describes, SBSA UART doesn't support >> DMA. In current code, when the kernel tries to access DMACR register, >> Xen will inject a data abort: >> Unhandled fault at 0xffffffc00944d048 >> Mem abort info: >> ESR = 0x96000000 >> EC = 0x25: DABT (current EL), IL = 32 bits >> SET = 0, FnV = 0 >> EA = 0, S1PTW = 0 >> FSC = 0x00: ttbr address size fault >> Data abort info: >> ISV = 0, ISS = 0x00000000 >> CM = 0, WnR = 0 >> swapper pgtable: 4k pages, 39-bit VAs, pgdp=0000000020e2e000 >> [ffffffc00944d048] pgd=100000003ffff803, p4d=100000003ffff803, pud=100000003ffff803, pmd=100000003fffa803, pte=006800009c090f13 >> Internal error: ttbr address size fault: 96000000 [#1] PREEMPT SMP >> ... >> Call trace: >> pl011_stop_rx+0x70/0x80 >> tty_port_shutdown+0x7c/0xb4 >> tty_port_close+0x60/0xcc >> uart_close+0x34/0x8c >> tty_release+0x144/0x4c0 >> __fput+0x78/0x220 >> ____fput+0x1c/0x30 >> task_work_run+0x88/0xc0 >> do_notify_resume+0x8d0/0x123c >> el0_svc+0xa8/0xc0 >> el0t_64_sync_handler+0xa4/0x130 >> el0t_64_sync+0x1a0/0x1a4 >> Code: b9000083 b901f001 794038a0 8b000042 (b9000041) >> ---[ end trace 83dd93df15c3216f ]--- >> note: bootlogd[132] exited with preempt_count 1 >> /etc/rcS.d/S07bootlogd: line 47: 132 Segmentation fault start-stop-daemon >> >> As discussed in [2], this commit makes the access to DMACR register >> write-ignore as an improvement. > As discussed earlier, if we decide to improve vpl011 (for now only Stefano shared his opinion), > then we need to mark *all* the PL011 registers that are not part of SBSA ar RAZ/WI. I would be fine to that. But I would like us to print a message using XENLOG_G_DEBUG to catch any OS that would touch those registers. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Nov 18 09:40:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 09:40:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445514.700704 (Exim 4.92) (envelope-from ) id 1ovxrL-0004dI-6S; Fri, 18 Nov 2022 09:40:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445514.700704; Fri, 18 Nov 2022 09:40:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovxrL-0004dB-22; Fri, 18 Nov 2022 09:40:31 +0000 Received: by outflank-mailman (input) for mailman id 445514; Fri, 18 Nov 2022 09:40:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovxrJ-0004bY-8V; Fri, 18 Nov 2022 09:40:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovxrJ-0005PD-4h; Fri, 18 Nov 2022 09:40:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovxrI-0001VD-N0; Fri, 18 Nov 2022 09:40:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovxrI-0000Lh-MZ; Fri, 18 Nov 2022 09:40:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MbwLge6FhkrwOXpSwaHL8tCXIjvJ1W6RvkZLmXNIcjo=; b=PwxXqYr0ds6a2Uu2I9znNA95xk 4yP1KO49OdkTMvP1ukmDtLC+MoyfWT1Q27KBFKQU2Njn7E/fjdqBmTBxFK6W8qwg6wN+f3NA0Mx3I 2pK0EnReorodmhNimxRe1GYZIbzN0JzUoS2Zs0VCq1DgV/APzvCPpF0ui3tnRdT2rhHc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174808: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=84368d882b9688bfac77ce48d33b1e20a4e4a787 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Fri, 18 Nov 2022 09:40:28 +0000 flight 174808 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174808/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 84368d882b9688bfac77ce48d33b1e20a4e4a787 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 41 days Failing since 173470 2022-10-08 06:21:34 Z 41 days 70 attempts Testing same since 174808 2022-11-17 23:41:39 Z 0 days 1 attempts ------------------------------------------------------------ 1749 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 165602 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Nov 18 09:59:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 09:59:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445522.700715 (Exim 4.92) (envelope-from ) id 1ovy99-0006Ms-Mo; Fri, 18 Nov 2022 09:58:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445522.700715; Fri, 18 Nov 2022 09:58:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovy99-0006Ml-Jq; Fri, 18 Nov 2022 09:58:55 +0000 Received: by outflank-mailman (input) for mailman id 445522; Fri, 18 Nov 2022 09:58:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovy97-0006Me-OU for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 09:58:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovy97-0005ps-Di; Fri, 18 Nov 2022 09:58:53 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[10.85.33.185]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ovy97-0005nm-7K; Fri, 18 Nov 2022 09:58:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=pgOnutzCEjD73SlbhW4fUYcAhT7mrHZCL+LhiRkk0iQ=; b=uqJuhq5tCzeiAa9N+fMbORX+Ve lxrGvXu5MwST8xVoowG3jOUBOLgnJ8NaeoMxhW55VlYlzx+F/dOShL2BUgtC/ithfLbapuLvnluP5 gtFEVVO1LwAVfmeOkWA/syu1Ss+Lg5jPdoVH5to/5kNp5MTcjCUxqhXZ0dxu/6kLLd6Y=; Message-ID: <6404753f-e349-747e-3f4a-5401021e05ce@xen.org> Date: Fri, 18 Nov 2022 09:58:51 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> <0400b2d8-6f2c-6406-d966-64ed5720688c@xen.org> <350afafd-821c-1a05-13cb-1704d3a61bfc@amd.com> <84710d96-c473-fa41-d847-2b109dfb49c9@xen.org> <85f4f42b-b1ee-36bf-5ba9-21b1047351cf@amd.com> <7d3f9021-d608-9e8f-9593-1099d7bd2003@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/11/2022 12:52, Michal Orzel wrote: > > > On 17/11/2022 10:53, Michal Orzel wrote: >> >> >> Hi Julien, >> >> On 17/11/2022 10:29, Julien Grall wrote: >>> >>> >>> On 17/11/2022 08:34, Michal Orzel wrote: >>>> Hi Julien, >>>> >>>> On 16/11/2022 19:37, Julien Grall wrote: >>>>> >>>>> >>>>> Hi Michal, >>>>> >>>>> On 16/11/2022 18:05, Michal Orzel wrote: >>>>>> On 16/11/2022 16:56, Julien Grall wrote: >>>>>>> >>>>>>> >>>>>>> On 16/11/2022 14:45, Michal Orzel wrote: >>>>>>>> Hi Julien, >>>>>>> >>>>>>> Hi Michal, >>>>>>> >>>>>>>>> >>>>>>>>>> and use it in the pl011-debug files (+ there is a question whether we should define WLEN_7-5 for completeness). >>>>>>>>> >>>>>>>>> I would not define WLEN_7-5. That said, I wonder if we really need to >>>>>>>>> set the baud rate & co here? >>>>>>>>> >>>>>>>>> AFAICT the runtime driver never touch them. The reasoning is the >>>>>>>>> firmware is responsible to configure the serial. Therefore, I would >>>>>>>>> consider to drop the code (setting UARTCR might still be necessary). >>>>>>>> I do not really agree because the current behavior was done on purpose. >>>>>>> >>>>>>> EARLY_UART_PL011_BAUD_RATE is only used for very early debugging (this >>>>>>> is protected by CONFIG_DEBUG and CONFIG_EXPERT). This is not a >>>>>>> production ready code. >>>>>> I am fully aware of it. I just found it useful but I understand the global reasoning. >>>>>> >>>>>>> >>>>>>>> At the moment early_uart_init is called only if EARLY_UART_PL011_BAUD_RATE is set to a value != 0. >>>>>>>> This is done in order to have flexibility to either stick to what firmware/bootloader configured or to change this >>>>>>>> configuration by specifying the EARLY_UART_PL011_BAUD_RATE (useful when you do not know what >>>>>>>> the firmware configured). >>>>>>> The chances are that you want to use the baud rate that was configured >>>>>>> by the firmware. Otherwise, you would need to change the configuration >>>>>>> of minicom (or whatever you used) to get proper output for the firmware >>>>>>> and then Xen. >>>>>>> >>>>>>> Furthermore, as I wrote before, the runtime driver doesn't configure the >>>>>>> baud rate. This was removed in Xen 4.7 (see commit 2048e17ca9df >>>>>>> "drivers/pl011: Don't configure baudrate") because it was buggy and this >>>>>>> code is not simple. >>>>>>> >>>>>>> So it makes no sense to configure the baud rate when using early printk >>>>>>> but not the runtime driver. >>>>>> Ok, so we will get rid of EARLY_UART_PL011_BAUD_RATE config and setting the bd >>>>>> in the early uart code. Now, what about setting "8n1"? The runtime driver sets them >>>>>> as well as the early code. It can also be set to a different value from the firmware >>>>>> (unlikely but it can happen I think). In any case, if we decide to do what the runtime driver >>>>>> does, I reckon setting LCR_H should be kept in early code. >>>>> >>>>> Good question. I think, you would end up with the same issue I mentioned >>>>> above if the firmware and Xen have different line control registers >>>>> (tools like minicom/screen would ask for it). >>>>> >>>>> So I am on the fence here. In one way, it seems pointless keep it. But >>>>> on the other hand, Xen has always set it. So I have no data to prove >>>>> this will be fine everywhere. >>>> If we are relying on the firmware[1] to configure the baud rate, it is not very wise >>>> not to rely on it to configure the LCR. Looking at the other serial drivers in Xen, >>>> we have a real mismatch in what is being configured. Some of the drivers (omap, imx), >>>> apart from setting 8n1 also set the baud rate explicitly to 115200 and almost all of them >>>> do set 8n1. In that case we will not benefit too much from fixing just pl011. >>> It is not great that Xen hardcode the baud rate (I can't remember >>> whether there was a reason), but I don't think the consistency is >>> necessary here (see more below). >>> >>>> >>>> On the other hand, Xen follows the zImage/Image protocols for ARM [2] which do not >>>> state that serial port initializing is something mandatory. This could indicate that >>>> the firmware does not really need to configure the serial. >>> >>> The firmware doesn't need to configure the serial and yes in theory Xen >>> should configure the baud rate and parity based on the firmware table. >>> >>> However, this is a trade off between complexity and benefits. The patch >>> I mentioned earlier has been removed nearly 6 years ago and I haven't >>> seen anyone reporting any issues. >>> >>> Hence why I think for the PL011 it is not worth looking [3] at the baud >>> rate and instead removing it completely in the early PL011 code as well. >>> >>> That said, if you feel strongly adding support for baud rate then I will >>> be happy to review the patch. >> I'm not in favor of this approach either. That said, I will prepare patches to remove >> CONFIG_EARLY_UART_PL011_BAUD_RATE and its usage in early printk code as we agreed earlier. >> As for the LCR setting, I will keep it in early printk code to maintain the same behavior as >> runtime driver who sets them. > Actually, there is one more thing to consider. > early_uart_init, even though it also sets LCR apart from the baud rate, is called when CONFIG_EARLY_UART_INIT is set. > The latter depends on EARLY_UART_PL011 && EARLY_UART_PL011_BAUD_RATE != 0. > If we remove EARLY_UART_PL011_BAUD_RATE, we need to decide when do we want early_uart_init to be called. It is defined only for pl011 > (it is also defined for meson but this is an unreachable code, as EARLY_UART_PL011 is 0 for meson), so we have the following options: Good spot. I am not sure why the function was defined for Meson if it does nothing. I would drop it but keep the comment explaining why we don't have the helper. > 2. Keep CONFIG_EARLY_UART_INIT so that future drivers can use it (?) and mark it as n by default Based on the discussion with Bertrand, I would keep CONFIG_EARLY_UART_INIT in case someone wants to use a different UART for Xen and the firmware output. Also, I would like to revise my opinion from earlier. I now think we should keep the baud rate part in early PL011 code even this means inconsistency between the early and runtime driver. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Nov 18 10:13:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 10:13:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445534.700729 (Exim 4.92) (envelope-from ) id 1ovyN1-0000gn-V1; Fri, 18 Nov 2022 10:13:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445534.700729; Fri, 18 Nov 2022 10:13:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovyN1-0000gg-SM; Fri, 18 Nov 2022 10:13:15 +0000 Received: by outflank-mailman (input) for mailman id 445534; Fri, 18 Nov 2022 10:13:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovyN0-0000ga-BC for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 10:13:14 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20600.outbound.protection.outlook.com [2a01:111:f400:7eae::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 96739a35-6729-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 11:13:03 +0100 (CET) Received: from DS7PR06CA0009.namprd06.prod.outlook.com (2603:10b6:8:2a::28) by CY8PR12MB7196.namprd12.prod.outlook.com (2603:10b6:930:58::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Fri, 18 Nov 2022 10:13:08 +0000 Received: from DM6NAM11FT039.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2a:cafe::cb) by DS7PR06CA0009.outlook.office365.com (2603:10b6:8:2a::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 10:13:08 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT039.mail.protection.outlook.com (10.13.172.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:13:08 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 04:13:07 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 04:13:07 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 04:13:05 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96739a35-6729-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K0POlbBdLHSua6ADdJLVyrLI2lFzBzhArj4ZC0aYp5vQ9vJ8KFT+JYm/dBan/Bv1BviN+hztGjBQAAfCLOtVGRycuYOj0A8+hGOGsRrL56gAiSCItc+M2wwPg0aqU5RozEk3BzLikrkA3Ew/TM19pu8ad6F/dtIrVrqkikSB2eqzHzihqQqItVOEwh+T+KA5JxDCaMphqielq5d4k31CAsWdfCi5X0PpBfL6dnLmQe/+16XT4lWi9js8C5JYuitgkYIxhGA3X3TUee4jjAJuid1qjtZAi0TeQpaouBSwkLbg43a0OgFSq7GnO//y+4MMgt5GsqekiUfdWBnFJpN+Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EvkDk37POQCRMuwcqA2E8cEKwVKsCsBW7vme/lhT5hA=; b=Y2k+RRu29gFhIAUgfPajCcfbJY+Ij4ftEUjnL+borAJ4vcVC1tLUsU0GE1Tv2dpZBBE1SmEnxAKll5IWAHO0sg0tX07X+jhz6f6ePaOoK1OxarM0N+l+fTnHHfsx5e1ajRPKiH5cu35vpqW54lNoVfbv72AuTU7gdEUN4li4JGOP7o1fWHwIKKYtX7eefbAIHuTnmNW6kzUidhM5Go/9jvRYaR6+slqbJJdvRwUSNohayb7QTfUu3mKlAyNWO1RkOqNQaYD05y9+diH8ZC9vpiEyFXVDwa3mom781hQLVWjfdmGR5BTw1+dslkmRcpgIkY5YleW4Hbbm5hsodJI47w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EvkDk37POQCRMuwcqA2E8cEKwVKsCsBW7vme/lhT5hA=; b=p2HYL8SwXbtY3vclOEvuybeJ1QZtoh9vTKswncAc2pl+TmkhOp1qXS0MxXKzt8HRxrVQvAL0d0TYRG0Vf6P/I9X9WRnlq7ih6NMCn8TAMVMlBOlRQnYUkhx1tfL1CHiJScshHNiIuNuaxDe7l0JNablww78h23uBYcWa+XBQcxI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <2ff90b23-519d-7645-9140-9e150e985147@amd.com> Date: Fri, 18 Nov 2022 11:13:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN v3 07/12] xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-8-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20221111141739.2872-8-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT039:EE_|CY8PR12MB7196:EE_ X-MS-Office365-Filtering-Correlation-Id: 44b86d56-4698-4559-c245-08dac94d7d98 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b2a/+VvaPqWLyKOOKzdtRPOiT+bx9AHUlOS+y9udL3eNRikLezjkAc1EpLkiVuVgDrdHKlTqCwYHzs+6KEkJ7oAbksFzpPgI2EuBv+0UW7QJ8C9wEMglViKui9KhQFQR/DWDnEWBH1Btpm01PAguFxi4MnYPUrNWtwgNKYCqa9DKQbM7qMyhP0fN6dzQDehDTxKvRPGHv/dZcMS3+EvCLgQKHDntnJwa5bhmRKNvvnxLH4GR3uxJ0y4WQuUEdL+aglCoj7Wbw+5W0md3EPSLX6Xa1OuRunC3P7KBDa9QSWMTsMJkbdeG2TQzJi/sXZyC4lIGBvvELz3Ix2ynX3He0HkWldLUiHlZva2nnlAGBNUb0Hp/riII4iLfddYdEmOo441YPu4CLzA9qsIzAs8SgRYHgGIfGLaiW7b1bNB6fn1S1IOV7W6+4tpihIaVHJrIPU0ySOaGWqVbtvdCSvYMU2PNcVHHzXVwWR0MXncQ0rcS/bXkp2mn5ky3ukYaWlC7BmgtW5UzbmgKiSmFntHvVrZKudOlDbw+QyvDDFdjC4QvBsH9e+pICUmk4WgE/2xdzSbtV0P15xhLSvlPBTmJjGKXsL7CstwoOFVUx1GII9l5Vr3ERBesublFO7jY/dTepdpecw5KfbM7iP8pQfxKhqndJ0JrxAfWt+aozaOP/CvTaJYxcCK/YA/k0AiNo9HimxTWOX03gu8nQV8vK0aL7woq9O1slitf3fLN08LDl11h8GqMz2QV4K9WM2F6EHr7zQl5ifjepS6qMKKyQRnXbA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199015)(46966006)(36840700001)(40470700004)(478600001)(31686004)(54906003)(41300700001)(70206006)(8676002)(4326008)(2906002)(26005)(70586007)(47076005)(110136005)(2616005)(83380400001)(44832011)(336012)(30864003)(5660300002)(8936002)(426003)(186003)(86362001)(31696002)(36860700001)(316002)(16576012)(356005)(82310400005)(53546011)(81166007)(40480700001)(36756003)(82740400003)(40460700003)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 10:13:08.2393 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 44b86d56-4698-4559-c245-08dac94d7d98 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT039.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7196 Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: > Refer "Arm IHI 0069H ID020922", 12.4.6, Interrupt Controller List Registers > > AArch64 System register ICH_LR_EL2 bits [31:0] are architecturally > mapped to AArch32 System register ICH_LR[31:0]. > AArch64 System register ICH_LR_EL2 bits [63:32] are architecturally > mapped to AArch32 System register ICH_LRC[31:0]. > > Defined ICH_LR<0...15>_EL2 and ICH_LRC<0...15>_EL2 for AArch32. > For AArch32, the link register is stored as :- > (((uint64_t) ICH_LRC<0...15>_EL2) << 32) | ICH_LR<0...15>_EL2 > > Also, ICR_LR macros need to be modified as ULL is 64 bits for AArch32 and > AArch64. > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from :- > v1 - 1. Moved the coproc register definitions to asm/cpregs.h. > 2. Use GENMASK(31, 0) to represent 0xFFFFFFFF > 3. Use READ_CP32()/WRITE_CP32() instead of READ_SYSREG()/WRITE_SYSREG(). > 4. Multi-line macro definitions should be enclosed within ({ }). > > v2 - 1. Use WRITE_SYSREG_LR(V, R) to make it consistent with before. > 2. Defined the register alias. > 3. Style issues. > > xen/arch/arm/gic-v3.c | 132 +++++++++++------------ > xen/arch/arm/include/asm/arm32/sysregs.h | 19 ++++ > xen/arch/arm/include/asm/arm64/sysregs.h | 4 + > xen/arch/arm/include/asm/cpregs.h | 75 +++++++++++++ > xen/arch/arm/include/asm/gic_v3_defs.h | 6 +- > 5 files changed, 167 insertions(+), 69 deletions(-) > > diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c > index 64a76307dd..4722bb4daf 100644 > --- a/xen/arch/arm/gic-v3.c > +++ b/xen/arch/arm/gic-v3.c > @@ -73,37 +73,37 @@ static inline void gicv3_save_lrs(struct vcpu *v) > switch ( gicv3_info.nr_lrs ) > { > case 16: > - v->arch.gic.v3.lr[15] = READ_SYSREG(ICH_LR15_EL2); > + v->arch.gic.v3.lr[15] = READ_SYSREG_LR(15); > case 15: > - v->arch.gic.v3.lr[14] = READ_SYSREG(ICH_LR14_EL2); > + v->arch.gic.v3.lr[14] = READ_SYSREG_LR(14); > case 14: > - v->arch.gic.v3.lr[13] = READ_SYSREG(ICH_LR13_EL2); > + v->arch.gic.v3.lr[13] = READ_SYSREG_LR(13); > case 13: > - v->arch.gic.v3.lr[12] = READ_SYSREG(ICH_LR12_EL2); > + v->arch.gic.v3.lr[12] = READ_SYSREG_LR(12); > case 12: > - v->arch.gic.v3.lr[11] = READ_SYSREG(ICH_LR11_EL2); > + v->arch.gic.v3.lr[11] = READ_SYSREG_LR(11); > case 11: > - v->arch.gic.v3.lr[10] = READ_SYSREG(ICH_LR10_EL2); > + v->arch.gic.v3.lr[10] = READ_SYSREG_LR(10); > case 10: > - v->arch.gic.v3.lr[9] = READ_SYSREG(ICH_LR9_EL2); > + v->arch.gic.v3.lr[9] = READ_SYSREG_LR(9); > case 9: > - v->arch.gic.v3.lr[8] = READ_SYSREG(ICH_LR8_EL2); > + v->arch.gic.v3.lr[8] = READ_SYSREG_LR(8); > case 8: > - v->arch.gic.v3.lr[7] = READ_SYSREG(ICH_LR7_EL2); > + v->arch.gic.v3.lr[7] = READ_SYSREG_LR(7); > case 7: > - v->arch.gic.v3.lr[6] = READ_SYSREG(ICH_LR6_EL2); > + v->arch.gic.v3.lr[6] = READ_SYSREG_LR(6); > case 6: > - v->arch.gic.v3.lr[5] = READ_SYSREG(ICH_LR5_EL2); > + v->arch.gic.v3.lr[5] = READ_SYSREG_LR(5); > case 5: > - v->arch.gic.v3.lr[4] = READ_SYSREG(ICH_LR4_EL2); > + v->arch.gic.v3.lr[4] = READ_SYSREG_LR(4); > case 4: > - v->arch.gic.v3.lr[3] = READ_SYSREG(ICH_LR3_EL2); > + v->arch.gic.v3.lr[3] = READ_SYSREG_LR(3); > case 3: > - v->arch.gic.v3.lr[2] = READ_SYSREG(ICH_LR2_EL2); > + v->arch.gic.v3.lr[2] = READ_SYSREG_LR(2); > case 2: > - v->arch.gic.v3.lr[1] = READ_SYSREG(ICH_LR1_EL2); > + v->arch.gic.v3.lr[1] = READ_SYSREG_LR(1); > case 1: > - v->arch.gic.v3.lr[0] = READ_SYSREG(ICH_LR0_EL2); > + v->arch.gic.v3.lr[0] = READ_SYSREG_LR(0); > break; > default: > BUG(); > @@ -120,37 +120,37 @@ static inline void gicv3_restore_lrs(const struct vcpu *v) > switch ( gicv3_info.nr_lrs ) > { > case 16: > - WRITE_SYSREG(v->arch.gic.v3.lr[15], ICH_LR15_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[15], 15); > case 15: > - WRITE_SYSREG(v->arch.gic.v3.lr[14], ICH_LR14_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[14], 14); > case 14: > - WRITE_SYSREG(v->arch.gic.v3.lr[13], ICH_LR13_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[13], 13); > case 13: > - WRITE_SYSREG(v->arch.gic.v3.lr[12], ICH_LR12_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[12], 12); > case 12: > - WRITE_SYSREG(v->arch.gic.v3.lr[11], ICH_LR11_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[11], 11); > case 11: > - WRITE_SYSREG(v->arch.gic.v3.lr[10], ICH_LR10_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[10], 10); > case 10: > - WRITE_SYSREG(v->arch.gic.v3.lr[9], ICH_LR9_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[9], 9); > case 9: > - WRITE_SYSREG(v->arch.gic.v3.lr[8], ICH_LR8_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[8], 8); > case 8: > - WRITE_SYSREG(v->arch.gic.v3.lr[7], ICH_LR7_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[7], 7); > case 7: > - WRITE_SYSREG(v->arch.gic.v3.lr[6], ICH_LR6_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[6], 6); > case 6: > - WRITE_SYSREG(v->arch.gic.v3.lr[5], ICH_LR5_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[5], 5); > case 5: > - WRITE_SYSREG(v->arch.gic.v3.lr[4], ICH_LR4_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[4], 4); > case 4: > - WRITE_SYSREG(v->arch.gic.v3.lr[3], ICH_LR3_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[3], 3); > case 3: > - WRITE_SYSREG(v->arch.gic.v3.lr[2], ICH_LR2_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[2], 2); > case 2: > - WRITE_SYSREG(v->arch.gic.v3.lr[1], ICH_LR1_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[1], 1); > case 1: > - WRITE_SYSREG(v->arch.gic.v3.lr[0], ICH_LR0_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[0], 0); > break; > default: > BUG(); > @@ -161,22 +161,22 @@ static uint64_t gicv3_ich_read_lr(int lr) > { > switch ( lr ) > { > - case 0: return READ_SYSREG(ICH_LR0_EL2); > - case 1: return READ_SYSREG(ICH_LR1_EL2); > - case 2: return READ_SYSREG(ICH_LR2_EL2); > - case 3: return READ_SYSREG(ICH_LR3_EL2); > - case 4: return READ_SYSREG(ICH_LR4_EL2); > - case 5: return READ_SYSREG(ICH_LR5_EL2); > - case 6: return READ_SYSREG(ICH_LR6_EL2); > - case 7: return READ_SYSREG(ICH_LR7_EL2); > - case 8: return READ_SYSREG(ICH_LR8_EL2); > - case 9: return READ_SYSREG(ICH_LR9_EL2); > - case 10: return READ_SYSREG(ICH_LR10_EL2); > - case 11: return READ_SYSREG(ICH_LR11_EL2); > - case 12: return READ_SYSREG(ICH_LR12_EL2); > - case 13: return READ_SYSREG(ICH_LR13_EL2); > - case 14: return READ_SYSREG(ICH_LR14_EL2); > - case 15: return READ_SYSREG(ICH_LR15_EL2); > + case 0: return READ_SYSREG_LR(0); > + case 1: return READ_SYSREG_LR(1); > + case 2: return READ_SYSREG_LR(2); > + case 3: return READ_SYSREG_LR(3); > + case 4: return READ_SYSREG_LR(4); > + case 5: return READ_SYSREG_LR(5); > + case 6: return READ_SYSREG_LR(6); > + case 7: return READ_SYSREG_LR(7); > + case 8: return READ_SYSREG_LR(8); > + case 9: return READ_SYSREG_LR(9); > + case 10: return READ_SYSREG_LR(10); > + case 11: return READ_SYSREG_LR(11); > + case 12: return READ_SYSREG_LR(12); > + case 13: return READ_SYSREG_LR(13); > + case 14: return READ_SYSREG_LR(14); > + case 15: return READ_SYSREG_LR(15); > default: > BUG(); > } > @@ -187,52 +187,52 @@ static void gicv3_ich_write_lr(int lr, uint64_t val) > switch ( lr ) > { > case 0: > - WRITE_SYSREG(val, ICH_LR0_EL2); > + WRITE_SYSREG_LR(val, 0); > break; > case 1: > - WRITE_SYSREG(val, ICH_LR1_EL2); > + WRITE_SYSREG_LR(val, 1); > break; > case 2: > - WRITE_SYSREG(val, ICH_LR2_EL2); > + WRITE_SYSREG_LR(val, 2); > break; > case 3: > - WRITE_SYSREG(val, ICH_LR3_EL2); > + WRITE_SYSREG_LR(val, 3); > break; > case 4: > - WRITE_SYSREG(val, ICH_LR4_EL2); > + WRITE_SYSREG_LR(val, 4); > break; > case 5: > - WRITE_SYSREG(val, ICH_LR5_EL2); > + WRITE_SYSREG_LR(val, 5); > break; > case 6: > - WRITE_SYSREG(val, ICH_LR6_EL2); > + WRITE_SYSREG_LR(val, 6); > break; > case 7: > - WRITE_SYSREG(val, ICH_LR7_EL2); > + WRITE_SYSREG_LR(val, 7); > break; > case 8: > - WRITE_SYSREG(val, ICH_LR8_EL2); > + WRITE_SYSREG_LR(val, 8); > break; > case 9: > - WRITE_SYSREG(val, ICH_LR9_EL2); > + WRITE_SYSREG_LR(val, 9); > break; > case 10: > - WRITE_SYSREG(val, ICH_LR10_EL2); > + WRITE_SYSREG_LR(val, 10); > break; > case 11: > - WRITE_SYSREG(val, ICH_LR11_EL2); > + WRITE_SYSREG_LR(val, 11); > break; > case 12: > - WRITE_SYSREG(val, ICH_LR12_EL2); > + WRITE_SYSREG_LR(val, 12); > break; > case 13: > - WRITE_SYSREG(val, ICH_LR13_EL2); > + WRITE_SYSREG_LR(val, 13); > break; > case 14: > - WRITE_SYSREG(val, ICH_LR14_EL2); > + WRITE_SYSREG_LR(val, 14); > break; > case 15: > - WRITE_SYSREG(val, ICH_LR15_EL2); > + WRITE_SYSREG_LR(val, 15); > break; > default: > return; > @@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v) > if ( v == current ) > { > for ( i = 0; i < gicv3_info.nr_lrs; i++ ) > - printk(" HW_LR[%d]=%lx\n", i, gicv3_ich_read_lr(i)); > + printk(" HW_LR[%d]=%llx\n", i, gicv3_ich_read_lr(i)); > } > else > { > for ( i = 0; i < gicv3_info.nr_lrs; i++ ) > - printk(" VCPU_LR[%d]=%lx\n", i, v->arch.gic.v3.lr[i]); > + printk(" VCPU_LR[%d]=%llx\n", i, v->arch.gic.v3.lr[i]); > } > } > > diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h > index 6841d5de43..31ad7eaefb 100644 > --- a/xen/arch/arm/include/asm/arm32/sysregs.h > +++ b/xen/arch/arm/include/asm/arm32/sysregs.h > @@ -62,6 +62,25 @@ > #define READ_SYSREG(R...) READ_SYSREG32(R) > #define WRITE_SYSREG(V, R...) WRITE_SYSREG32(V, R) > > +/* Wrappers for accessing interrupt controller list registers. */ > +#define ICH_LR_REG(index) ICH_LR ## index ## _EL2 > +#define ICH_LRC_REG(index) ICH_LRC ## index ## _EL2 > + > +#define READ_SYSREG_LR(index) ({ \ > + uint64_t _val; \ > + uint32_t _lrc = READ_CP32(ICH_LRC_REG(index)); \ > + uint32_t _lr = READ_CP32(ICH_LR_REG(index)); \ > + \ > + _val = ((uint64_t) _lrc << 32) | _lr; \ > + _val; \ > +}) > + > +#define WRITE_SYSREG_LR(V, index) ({ \ Didn't we agree on using lower case version? This upper case V looks a bit odd here... > + uint64_t _val = (V); \ > + WRITE_CP32(_val & GENMASK(31, 0), ICH_LR_REG(index)); \ > + WRITE_CP32(_val >> 32, ICH_LRC_REG(index)); \ > +}) > + > /* MVFR2 is not defined on ARMv7 */ > #define MVFR2_MAYBE_UNDEFINED > > diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h > index 54670084c3..b72a6ea3b0 100644 > --- a/xen/arch/arm/include/asm/arm64/sysregs.h > +++ b/xen/arch/arm/include/asm/arm64/sysregs.h > @@ -472,6 +472,10 @@ > #define READ_SYSREG(name) READ_SYSREG64(name) > #define WRITE_SYSREG(v, name) WRITE_SYSREG64(v, name) > > +/* Wrappers for accessing interrupt controller list registers. */ > +#define ICH_LR_REG(index) ICH_LR ## index ## _EL2 > +#define WRITE_SYSREG_LR(V, index) WRITE_SYSREG(V, ICH_LR_REG(index)) and here. > +#define READ_SYSREG_LR(index) READ_SYSREG(ICH_LR_REG(index)) Before you added a new code block there was an empty line here. Could you please add it? > #endif /* _ASM_ARM_ARM64_SYSREGS_H */ > > /* > diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h > index 6daf2b1a30..242dabaea8 100644 > --- a/xen/arch/arm/include/asm/cpregs.h > +++ b/xen/arch/arm/include/asm/cpregs.h > @@ -259,6 +259,49 @@ > #define VBAR p15,0,c12,c0,0 /* Vector Base Address Register */ > #define HVBAR p15,4,c12,c0,0 /* Hyp. Vector Base Address Register */ Here the value of HVBAR... > > +/* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ > +#define ___CP32(coproc, opc1, crn, crm, opc2) coproc, opc1, crn, crm, opc2 > +#define __LR0(x) ___CP32(p15, 4, c12, c12, x) > +#define __LR8(x) ___CP32(p15, 4, c12, c13, x) > + > +#define ICH_LR0 __LR0(0) > +#define ICH_LR1 __LR0(1) > +#define ICH_LR2 __LR0(2) > +#define ICH_LR3 __LR0(3) > +#define ICH_LR4 __LR0(4) > +#define ICH_LR5 __LR0(5) > +#define ICH_LR6 __LR0(6) > +#define ICH_LR7 __LR0(7) > +#define ICH_LR8 __LR8(0) > +#define ICH_LR9 __LR8(1) > +#define ICH_LR10 __LR8(2) > +#define ICH_LR11 __LR8(3) > +#define ICH_LR12 __LR8(4) > +#define ICH_LR13 __LR8(5) > +#define ICH_LR14 __LR8(6) > +#define ICH_LR15 __LR8(7) > + > +/* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ > +#define __LRC0(x) ___CP32(p15, 4, c12, c14, x) > +#define __LRC8(x) ___CP32(p15, 4, c12, c15, x) > + > +#define ICH_LRC0 __LRC0(0) > +#define ICH_LRC1 __LRC0(1) > +#define ICH_LRC2 __LRC0(2) > +#define ICH_LRC3 __LRC0(3) > +#define ICH_LRC4 __LRC0(4) > +#define ICH_LRC5 __LRC0(5) > +#define ICH_LRC6 __LRC0(6) > +#define ICH_LRC7 __LRC0(7) > +#define ICH_LRC8 __LRC8(0) > +#define ICH_LRC9 __LRC8(1) > +#define ICH_LRC10 __LRC8(2) > +#define ICH_LRC11 __LRC8(3) > +#define ICH_LRC12 __LRC8(4) > +#define ICH_LRC13 __LRC8(5) > +#define ICH_LRC14 __LRC8(6) > +#define ICH_LRC15 __LRC8(7) > + > /* CP15 CR13: */ > #define FCSEIDR p15,0,c13,c0,0 /* FCSE Process ID Register */ is aligned to the value of FCSEIDR. So I'm not sure why you cannot align your code block to it. Generally a new code block can have its own alignement, but here you did insert it into something aligned which no longer is after your change. > #define CONTEXTIDR p15,0,c13,c0,1 /* Context ID Register */ > @@ -317,6 +360,38 @@ > #define HCR_EL2 HCR > #define HPFAR_EL2 HPFAR > #define HSTR_EL2 HSTR > +#define ICH_LR0_EL2 ICH_LR0 > +#define ICH_LR1_EL2 ICH_LR1 > +#define ICH_LR2_EL2 ICH_LR2 > +#define ICH_LR3_EL2 ICH_LR3 > +#define ICH_LR4_EL2 ICH_LR4 > +#define ICH_LR5_EL2 ICH_LR5 > +#define ICH_LR6_EL2 ICH_LR6 > +#define ICH_LR7_EL2 ICH_LR7 > +#define ICH_LR8_EL2 ICH_LR8 > +#define ICH_LR9_EL2 ICH_LR9 > +#define ICH_LR10_EL2 ICH_LR10 > +#define ICH_LR11_EL2 ICH_LR11 > +#define ICH_LR12_EL2 ICH_LR12 > +#define ICH_LR13_EL2 ICH_LR13 > +#define ICH_LR14_EL2 ICH_LR14 > +#define ICH_LR15_EL2 ICH_LR15 > +#define ICH_LRC0_EL2 ICH_LRC0 > +#define ICH_LRC1_EL2 ICH_LRC1 > +#define ICH_LRC2_EL2 ICH_LRC2 > +#define ICH_LRC3_EL2 ICH_LRC3 > +#define ICH_LRC4_EL2 ICH_LRC4 > +#define ICH_LRC5_EL2 ICH_LRC5 > +#define ICH_LRC6_EL2 ICH_LRC6 > +#define ICH_LRC7_EL2 ICH_LRC7 > +#define ICH_LRC8_EL2 ICH_LRC8 > +#define ICH_LRC9_EL2 ICH_LRC9 > +#define ICH_LRC10_EL2 ICH_LRC10 > +#define ICH_LRC11_EL2 ICH_LRC11 > +#define ICH_LRC12_EL2 ICH_LRC12 > +#define ICH_LRC13_EL2 ICH_LRC13 > +#define ICH_LRC14_EL2 ICH_LRC14 > +#define ICH_LRC15_EL2 ICH_LRC15 > #define ID_AFR0_EL1 ID_AFR0 > #define ID_DFR0_EL1 ID_DFR0 > #define ID_DFR1_EL1 ID_DFR1 > diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h > index 48a1bc401e..743ebb20fd 100644 > --- a/xen/arch/arm/include/asm/gic_v3_defs.h > +++ b/xen/arch/arm/include/asm/gic_v3_defs.h > @@ -185,9 +185,9 @@ > #define ICH_LR_HW_SHIFT 61 > #define ICH_LR_GRP_MASK 0x1 > #define ICH_LR_GRP_SHIFT 60 > -#define ICH_LR_MAINTENANCE_IRQ (1UL<<41) > -#define ICH_LR_GRP1 (1UL<<60) > -#define ICH_LR_HW (1UL<<61) > +#define ICH_LR_MAINTENANCE_IRQ (1ULL << 41) > +#define ICH_LR_GRP1 (1ULL << 60) > +#define ICH_LR_HW (1ULL << 61) > > #define ICH_VTR_NRLRGS 0x3f > #define ICH_VTR_PRIBITS_MASK 0x7 ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 18 10:22:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 10:22:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445541.700741 (Exim 4.92) (envelope-from ) id 1ovyVO-0002NR-UY; Fri, 18 Nov 2022 10:21:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445541.700741; Fri, 18 Nov 2022 10:21:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovyVO-0002NK-Qr; Fri, 18 Nov 2022 10:21:54 +0000 Received: by outflank-mailman (input) for mailman id 445541; Fri, 18 Nov 2022 10:21:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovyVN-0002NA-As; Fri, 18 Nov 2022 10:21:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovyVN-0006Sw-6I; Fri, 18 Nov 2022 10:21:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovyVM-0002SV-JW; Fri, 18 Nov 2022 10:21:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ovyVM-0004Lp-J5; Fri, 18 Nov 2022 10:21:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3o1ANCHiC0nI3Ni4d4pFLdfDl5sEpQPc3E73Sg8Almk=; b=dfibzJwh5x/jS7Gob0Pjx0I2dv C8w3IiX4vmHrsq/soc4scqtRhban61OeHV9nGu3Y3hHwR8RjKWxbUfBBS/FCZ3k6viv65TA21twbk uL3ioIktcSvy59wwNrSM8mE05gh82/K8Cs7GZlV8NzKpMcaoVhm1/nEo0ZnmZazxjLGA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174809: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict::broken:regression xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:host-install(5):broken:regression xen-unstable:test-amd64-amd64-xl-credit2:guest-localmigrate/x10:fail:regression xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=db8fa01c61db0317a9ee947925226234c65d48e8 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Fri, 18 Nov 2022 10:21:52 +0000 flight 174809 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174809/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 5 host-install(5) broken REGR. vs. 174797 test-amd64-amd64-xl-credit2 20 guest-localmigrate/x10 fail REGR. vs. 174797 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 174797 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen db8fa01c61db0317a9ee947925226234c65d48e8 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 1 days Testing same since 174809 2022-11-18 00:06:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken broken-step test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict host-install(5) Not pushing. ------------------------------------------------------------ commit db8fa01c61db0317a9ee947925226234c65d48e8 Author: Andrew Cooper Date: Thu Oct 20 12:14:30 2022 +0100 xen/arm: Correct the p2m pool size calculations Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit bd87315a603bf25e869e6293f7db7b1024d67999 Author: Andrew Cooper Date: Thu Oct 20 12:13:46 2022 +0100 tools/tests: Unit test for paging mempool size Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit 22b20bd98c025e06525410e3ab3494d5e63489f7 Author: Andrew Cooper Date: Fri Oct 21 14:13:00 2022 +0100 xen: Introduce non-broken hypercalls for the paging mempool size The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 Author: Andrew Cooper Date: Mon Nov 14 21:47:59 2022 +0000 x86/hvm: Revert per-domain APIC acceleration support I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisted in due course. Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Fixes: 6b2b9b340509 ("x86: report Interrupt Controller Virtualization capabilities") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Nov 18 10:27:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 10:27:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445548.700752 (Exim 4.92) (envelope-from ) id 1ovyac-00030O-IW; Fri, 18 Nov 2022 10:27:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445548.700752; Fri, 18 Nov 2022 10:27:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovyac-00030H-Fo; Fri, 18 Nov 2022 10:27:18 +0000 Received: by outflank-mailman (input) for mailman id 445548; Fri, 18 Nov 2022 10:27:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovyab-00030B-Fa for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 10:27:17 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20618.outbound.protection.outlook.com [2a01:111:f400:7eaa::618]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 91c7d655-672b-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 11:27:15 +0100 (CET) Received: from MW4PR03CA0303.namprd03.prod.outlook.com (2603:10b6:303:dd::8) by DM4PR12MB6085.namprd12.prod.outlook.com (2603:10b6:8:b3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Fri, 18 Nov 2022 10:27:10 +0000 Received: from CO1NAM11FT027.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dd:cafe::d4) by MW4PR03CA0303.outlook.office365.com (2603:10b6:303:dd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 10:27:10 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT027.mail.protection.outlook.com (10.13.174.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:27:10 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 04:27:06 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 02:26:33 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 04:26:32 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91c7d655-672b-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KSiiMhEaU8BsonlGFjv12lhi6+JpqneamrVoFHj6qD4xntaub8vguIdV5FM27avIZW/qeKZNWD4ClzDeeDtIsB8wZad081Sa+J/7wyNavmhsnX9d6OWEnGJ8WATfrQ+wj6ut+JGgq5aSiBjlgLOPzcRw2BQJfxxhgjuZOM3BcnJIeDNRtUvgIPmL97NJ5AoUF0I2xhF3DTQGDWdHaZXnjQ//uk+ail8wyePqJEUYpbpaFPOQ5BYmKsFdzAkHWKAihDHwf2uos5mOJxbQxpHIn90sUPRm7W9AdYp9TiCYnYtf0w5Ru57tNY8AnjaR+nvtMs4kqnCb4CcL/DGv+zdJeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iJjmWiEow2PR6f/vKo4vBn5MG8D2eskjhTFiIWhpN4g=; b=Gntpj9L6TFKwU7CqsUBOiTlIy3HaApQHNGYNDJNEM42cVcWK+J0rETUCskYrCNmFwUIU7rMF2FBANj+Tt9ft/2CFip4KmAxGxEvaBO6IlHxlS7eGCX0bSbVIcmsi4R/r24U6/4rjrD4Bql+seVat3Nk04/ijXUU7ueXRi0wFDvbApm/llmwmcafk+qZT9I4+UxWKCfcI0FnaKOoZvJTQ9qUZatuZFY3+9+M4kPIY/5i26tRkWC7NJ5txP31SvUjZO9CubAQgJ1eMtOYLvv3wJC/Eud1G+WzRVVcqNXpttetkRHd4Bt1q0hHGtORZSY2BB/9aYOqF2Y5osLN6VLQyig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iJjmWiEow2PR6f/vKo4vBn5MG8D2eskjhTFiIWhpN4g=; b=JGmstStLeKJO7BzFCxuygH0qI40rG0/Ul8NHy6MVyQMzU3hEUNZgyFmF5zEsUArPt7ANWlkRqNTRAOleWQwQJuxPMgVxMAWhmn9iAbkzxl+anKueKKNMeofZuOhvQl9VrFqlxWF9xY/q6TjFcqhL6U5WYP0DsOw2zw9nrH3W2fA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <2e7659bd-d2ee-3484-3f17-fb62d51cdaaf@amd.com> Date: Fri, 18 Nov 2022 11:26:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Content-Language: en-US To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221024100536.12874-1-michal.orzel@amd.com> <653bdfb0-2926-531b-bb56-d0797fbf3877@xen.org> <60cf8d8e-e4d6-2c8b-50ba-ab6c3fe7d84c@amd.com> <0400b2d8-6f2c-6406-d966-64ed5720688c@xen.org> <350afafd-821c-1a05-13cb-1704d3a61bfc@amd.com> <84710d96-c473-fa41-d847-2b109dfb49c9@xen.org> <85f4f42b-b1ee-36bf-5ba9-21b1047351cf@amd.com> <7d3f9021-d608-9e8f-9593-1099d7bd2003@xen.org> <6404753f-e349-747e-3f4a-5401021e05ce@xen.org> From: Michal Orzel In-Reply-To: <6404753f-e349-747e-3f4a-5401021e05ce@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT027:EE_|DM4PR12MB6085:EE_ X-MS-Office365-Filtering-Correlation-Id: b98cf8c4-ea40-4be7-b79a-08dac94f7370 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7xMBkZaNdY3/GsqhL6tGahYz0kITe4YtvMFWLkP2cFMu97I+HmkZaRS7CdODZUqiIE50TwZnG2xalkUpL5U9E6wEhsVbJsIVccUdpxjujr55VDUesN/MuqBcg7BRXv6EJ3Yxw0KZpYmMGpQiN82+OgmQHZl+W954LjDotQqPw50Af8HWs7a/sxuPni+XdZlKM2N3uJTXlBGU/DdW1kVM/pFLcPefyNuVR0hnOOLNVUkshQvnsDsRQ8Nu4rwFBlvDi2qk4SCqBumtwVgscnSMqyoJWz0Ed1B2PuNWiyuAmE3+5R0CB+qLjQmvMVbtBdUqcyVmxJenGTXg9J2i0WdMDDHMXJ4Yb535n0C9YASU/iynYdIBTryEhQlntZ4kOY3+wcjUDNYTyOVoL8xUjASKQZErIxTj0wz+oF1u9gPdKttSgBITYhMojNA66xMiNxorxczMqwePzuGjWYFG3XT7pGT/bdFiNeY4MuFuZEpRyfEZkbXNeOGlR7qXuLeQf3y0Bv39dOWPIr4kSN4YE33lgIDAxX23zSAosxYqCV31L8fYD/eg8KjLIMUP5hHfmoWgc9PjDo2X6PcbsZblGCyKKdSTEcj+e0tSKIo7fHYkgalRFjTdjxaPI+iesIABVIGmHKDRIVyabOJzXqNdb0flj0gecNsNz29GGWoyK7ztROcEKyxJas4HRXEZ8S0DJBQhDDJQ+NwmPEGbu0Mnnq6FlPJbYFoKWrh/EYf6qV7Bearxon22u2P3qrDfaheLv4W1BCYU0si7C9nNWTDtuTYjc41gGtuTto8rjfd5VS/RzVSuVAAt48UHn42xA5sJzA11 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199015)(40470700004)(36840700001)(46966006)(82310400005)(31696002)(86362001)(36756003)(40460700003)(70586007)(186003)(41300700001)(2616005)(70206006)(44832011)(47076005)(8676002)(336012)(5660300002)(426003)(4326008)(8936002)(6666004)(478600001)(316002)(40480700001)(16576012)(356005)(54906003)(110136005)(53546011)(82740400003)(26005)(81166007)(2906002)(36860700001)(31686004)(83380400001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 10:27:10.0994 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b98cf8c4-ea40-4be7-b79a-08dac94f7370 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT027.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6085 Hi Julien, On 18/11/2022 10:58, Julien Grall wrote: > > > On 17/11/2022 12:52, Michal Orzel wrote: >> >> >> On 17/11/2022 10:53, Michal Orzel wrote: >>> >>> >>> Hi Julien, >>> >>> On 17/11/2022 10:29, Julien Grall wrote: >>>> >>>> >>>> On 17/11/2022 08:34, Michal Orzel wrote: >>>>> Hi Julien, >>>>> >>>>> On 16/11/2022 19:37, Julien Grall wrote: >>>>>> >>>>>> >>>>>> Hi Michal, >>>>>> >>>>>> On 16/11/2022 18:05, Michal Orzel wrote: >>>>>>> On 16/11/2022 16:56, Julien Grall wrote: >>>>>>>> >>>>>>>> >>>>>>>> On 16/11/2022 14:45, Michal Orzel wrote: >>>>>>>>> Hi Julien, >>>>>>>> >>>>>>>> Hi Michal, >>>>>>>> >>>>>>>>>> >>>>>>>>>>> and use it in the pl011-debug files (+ there is a question whether we should define WLEN_7-5 for completeness). >>>>>>>>>> >>>>>>>>>> I would not define WLEN_7-5. That said, I wonder if we really need to >>>>>>>>>> set the baud rate & co here? >>>>>>>>>> >>>>>>>>>> AFAICT the runtime driver never touch them. The reasoning is the >>>>>>>>>> firmware is responsible to configure the serial. Therefore, I would >>>>>>>>>> consider to drop the code (setting UARTCR might still be necessary). >>>>>>>>> I do not really agree because the current behavior was done on purpose. >>>>>>>> >>>>>>>> EARLY_UART_PL011_BAUD_RATE is only used for very early debugging (this >>>>>>>> is protected by CONFIG_DEBUG and CONFIG_EXPERT). This is not a >>>>>>>> production ready code. >>>>>>> I am fully aware of it. I just found it useful but I understand the global reasoning. >>>>>>> >>>>>>>> >>>>>>>>> At the moment early_uart_init is called only if EARLY_UART_PL011_BAUD_RATE is set to a value != 0. >>>>>>>>> This is done in order to have flexibility to either stick to what firmware/bootloader configured or to change this >>>>>>>>> configuration by specifying the EARLY_UART_PL011_BAUD_RATE (useful when you do not know what >>>>>>>>> the firmware configured). >>>>>>>> The chances are that you want to use the baud rate that was configured >>>>>>>> by the firmware. Otherwise, you would need to change the configuration >>>>>>>> of minicom (or whatever you used) to get proper output for the firmware >>>>>>>> and then Xen. >>>>>>>> >>>>>>>> Furthermore, as I wrote before, the runtime driver doesn't configure the >>>>>>>> baud rate. This was removed in Xen 4.7 (see commit 2048e17ca9df >>>>>>>> "drivers/pl011: Don't configure baudrate") because it was buggy and this >>>>>>>> code is not simple. >>>>>>>> >>>>>>>> So it makes no sense to configure the baud rate when using early printk >>>>>>>> but not the runtime driver. >>>>>>> Ok, so we will get rid of EARLY_UART_PL011_BAUD_RATE config and setting the bd >>>>>>> in the early uart code. Now, what about setting "8n1"? The runtime driver sets them >>>>>>> as well as the early code. It can also be set to a different value from the firmware >>>>>>> (unlikely but it can happen I think). In any case, if we decide to do what the runtime driver >>>>>>> does, I reckon setting LCR_H should be kept in early code. >>>>>> >>>>>> Good question. I think, you would end up with the same issue I mentioned >>>>>> above if the firmware and Xen have different line control registers >>>>>> (tools like minicom/screen would ask for it). >>>>>> >>>>>> So I am on the fence here. In one way, it seems pointless keep it. But >>>>>> on the other hand, Xen has always set it. So I have no data to prove >>>>>> this will be fine everywhere. >>>>> If we are relying on the firmware[1] to configure the baud rate, it is not very wise >>>>> not to rely on it to configure the LCR. Looking at the other serial drivers in Xen, >>>>> we have a real mismatch in what is being configured. Some of the drivers (omap, imx), >>>>> apart from setting 8n1 also set the baud rate explicitly to 115200 and almost all of them >>>>> do set 8n1. In that case we will not benefit too much from fixing just pl011. >>>> It is not great that Xen hardcode the baud rate (I can't remember >>>> whether there was a reason), but I don't think the consistency is >>>> necessary here (see more below). >>>> >>>>> >>>>> On the other hand, Xen follows the zImage/Image protocols for ARM [2] which do not >>>>> state that serial port initializing is something mandatory. This could indicate that >>>>> the firmware does not really need to configure the serial. >>>> >>>> The firmware doesn't need to configure the serial and yes in theory Xen >>>> should configure the baud rate and parity based on the firmware table. >>>> >>>> However, this is a trade off between complexity and benefits. The patch >>>> I mentioned earlier has been removed nearly 6 years ago and I haven't >>>> seen anyone reporting any issues. >>>> >>>> Hence why I think for the PL011 it is not worth looking [3] at the baud >>>> rate and instead removing it completely in the early PL011 code as well. >>>> >>>> That said, if you feel strongly adding support for baud rate then I will >>>> be happy to review the patch. >>> I'm not in favor of this approach either. That said, I will prepare patches to remove >>> CONFIG_EARLY_UART_PL011_BAUD_RATE and its usage in early printk code as we agreed earlier. >>> As for the LCR setting, I will keep it in early printk code to maintain the same behavior as >>> runtime driver who sets them. >> Actually, there is one more thing to consider. >> early_uart_init, even though it also sets LCR apart from the baud rate, is called when CONFIG_EARLY_UART_INIT is set. >> The latter depends on EARLY_UART_PL011 && EARLY_UART_PL011_BAUD_RATE != 0. >> If we remove EARLY_UART_PL011_BAUD_RATE, we need to decide when do we want early_uart_init to be called. It is defined only for pl011 >> (it is also defined for meson but this is an unreachable code, as EARLY_UART_PL011 is 0 for meson), so we have the following options: > > Good spot. I am not sure why the function was defined for Meson if it > does nothing. I would drop it but keep the comment explaining why we > don't have the helper. Hmm, other drivers do not have such a comment but I can leave it there if you want. Although, it should then be slightly modified to avoid ambiguity after removing macro: /* * No need for early_uart_init, as UART has already been initialized * by Firmware, for instance by TF-A. */ > >> 2. Keep CONFIG_EARLY_UART_INIT so that future drivers can use it (?) and mark it as n by default > > Based on the discussion with Bertrand, I would keep > CONFIG_EARLY_UART_INIT in case someone wants to use a different UART for > Xen and the firmware output. > > Also, I would like to revise my opinion from earlier. I now think we > should keep the baud rate part in early PL011 code even this means > inconsistency between the early and runtime driver. Ok, in this case I will just create a series containing this patch without any modifications, the meson fix + macro for 8n1 to be used in early code as agreed earlier. > > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 18 10:32:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 10:32:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445555.700763 (Exim 4.92) (envelope-from ) id 1ovyfB-0004d1-88; Fri, 18 Nov 2022 10:32:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445555.700763; Fri, 18 Nov 2022 10:32:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovyfB-0004cu-5P; Fri, 18 Nov 2022 10:32:01 +0000 Received: by outflank-mailman (input) for mailman id 445555; Fri, 18 Nov 2022 10:31:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovyf9-0004co-L1 for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 10:31:59 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70083.outbound.protection.outlook.com [40.107.7.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 35f4608f-672c-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 11:31:50 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7551.eurprd04.prod.outlook.com (2603:10a6:102:e9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Fri, 18 Nov 2022 10:31:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 10:31:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35f4608f-672c-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XlmrzwobKb2nRm1TyXPlhkHdclgdwdPJ2rUbxVCofkVzTb8836q0+pyuZr3ge4HrKgl0DSDINhy0HZbMQAydPCMn2/I0+ZdyGJmFKKhO6rvcxkcjIWGSMt3uP8GiA2D9uqPQwRB5N55zfw/DPxdF3XmzRlY0MrNlw9GLuvI29rjCSyPP9hm8G8rTsI4zi/G4yNHJp0EDjCoBwnW6MUP7sbSyank7ct+jLhvi5tZ3TrTZoAoAoWB/wPfWoS/WVy96J9QLbFPG+8BmBBl3fE0hjFP89tAizrZsX6/adxua0Hm+22yT2+sVIArAThquHknC0lo2zgLJYGtKAxY8lk3plg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/4843PEKfZVz9As49dWM3d43kFfV2jNSzREIg8Ev5iw=; b=AeCLcKzsp2h741xRaOUz7HlHvSpGX4Vr9uxXkCYynOIIqegYdfoFtkR+sF5DPV0ZGohMxP/DSbYnicI9sChRTvUjEAU2OMtTGubLNieqXAuV6zDjx67mVVD9s6qc+xsxw9AmtOfWkKp6eYFbIEwBZ9Umi1squt/94DtdnyZngDr9LgGTCLCDGUZl88YcM3EmUdbRCdeAyrRMI/vKr3EDUww+aB8598q3Wh6/1uLrrosrj36lf5bpMtudry25Kj9HRPpktHTuO90OPJLNTka6POLesRxImGYBwrCfIGTNobXGGK/xQhodHn43Jf+L8G2gEJ9qTSfDjv8TD6Cip4XMzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/4843PEKfZVz9As49dWM3d43kFfV2jNSzREIg8Ev5iw=; b=bNE9JpbQdpGGvucXntkMR78M6FawfdOk1bqK1whmOPT1Zh1cYRIW8QrE7RqBbEa1ULoWzJ2VDymqMa1W6bPetA+QHHZUc6YetIZHIJhVS3PsUkspmi1LBvFN9l8qe4vJpFq6a/v46GuAadOi4yHfEYz/0L4u3E69CdGdEJpbINecGncTThSpI80MndT9Kt+qlqBTC2PpJK2eaVEOrm1Pz14B27F5bJ8Ul6fBZNIE5h2rx3FZhDIqtJpQIYUQxvF3QWwOxD1TiKtFkdWlawkA06V0LdGO9hO1Lt7DU+JZAm6V4dq+tLG91yGwEYGwJ7uXBjUMeBZrqaMcE4OOI0YR8Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 18 Nov 2022 11:31:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant From: Jan Beulich Subject: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7551:EE_ X-MS-Office365-Filtering-Correlation-Id: e5c1e7db-86d1-444b-6d5d-08dac9500df1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: au/URv5ffAdLEBmvnqBX7bh6mhD4dp23RZp4qckylcDS1loOst5lfSDDYqu/c5kYP7s6witB3f9sx0R8u+C8a6FvJPnESwOuXKFp5WrWeHU7hAieY2lYKF2zMlmuXqzoVVUQT8wgCG8jpZr/iITilcoDg0yO54h3CMPdz1az+/OuikkxkW1GaCIqcmJwRuqnZULsGiDORVlwdpgRv3T/djvhKuKmIWRtb8o9kIJ2azq02hvtP/3NhLfjFT6VLijkUmfi+U+/2hLojIi+KLy8qRZ91bofjVbsFkGQI4PkW+DSDeZo6ue7fsQPaBXOOPd7G5PKd+5ikis6B6bBK7szvBXRaYH6jtjOpPrUE1abymQogDbOpuTjpvm2mGX1iyarlE8/cFIqLV7Rb4WMYaUSyovYaKR5sO9mfac/IQLjepuiJ3HwAEBMeC3xdaC+cPP1fMmmLXKkYsrMIQBDbPJwOnnbvzYB8kr3lW56GiIgHHK67rws05I+B2Cieuzg3lvgUf7N9De0zTXjh64E/1FJLkm7wmDR5osBLkEEvhD1bIoX63BxPcDZCAQaUHmw4nmpgQM9Lus5fUJ+4s/mgW1/zRaM6tem8/7GZ5/kRUw5N4blNELy4/i1mrJRTQ+ZAppJ8lWyLUYH0FBdoYPjZt0rDxuCQzqVgeGLpntu6PAVnKgfjPuGQj+8CHaFGvj3KPjGPwjDBR4z56zMyeuftCOaPxtuxZIF9eFUpB6NRZDzUDM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(396003)(376002)(346002)(366004)(451199015)(86362001)(31696002)(83380400001)(66946007)(38100700002)(8936002)(2906002)(4326008)(41300700001)(6916009)(66476007)(26005)(66556008)(6506007)(6512007)(186003)(2616005)(8676002)(316002)(54906003)(478600001)(5660300002)(6486002)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d25Ia1ZrVFpwL2hERW50TDBCRjNqWlhrdTZDWVVrQURWOHpMN1dDb2ZoWTkv?= =?utf-8?B?RU5CT2EzV1Y5Q2IvTVNQUEY1M3RLMExrdEd1VUFRS0xaQXRsd1p4WEd0R0tM?= =?utf-8?B?dzJ4K2liNEhtRko0anVsamllWHY5RWswYzdjRStZcTdjckxBQWxTa1FrTnlz?= =?utf-8?B?OGpNTXlYcTNwNjVQNnNWRURkZTFxZU8vSHZKM09raWQ5T3g2R3ZvdUFpOVlj?= =?utf-8?B?M2dEOElmdlFMMFlMTGJRQW02RlBRVVhtRmJublV0UXpjWTJ0SGd0YkFySkR2?= =?utf-8?B?U1M5Vzk3VWpqMitScnlXR2JVaUF3ZUE5OWVrMm56Zm9MMUVadzNxUnNmSEF6?= =?utf-8?B?TWhYZzdGWlpzWUxLZEkwdkdocmVmT05nK0NENVplSUxiL0JoYXppdzAwdWtV?= =?utf-8?B?eDhMUUMxWUszZUd2cE1WM3pGd3M1THZTV1J1SExLY0tEUnlyV1JrYXpMcUJR?= =?utf-8?B?bGpSU0tybWxuS1AxbEhIcUYrMmY5ZUI2ZUxzYWJ1amlSczE2c2hnRzR4SjA4?= =?utf-8?B?VktQS3NnNWtKZnFxSXhwSlljK1Z6NHcrdWp2MSs4VjhyK1BPOEVhVm1lWVg0?= =?utf-8?B?aXgzSUNwbHpqUHNqbHZ5Q3BQL0xnZ3BoaWphdVlrS3NOTXBvYmxoUmNvWi8v?= =?utf-8?B?ZEJSemc5VEZXckI1Z2pxczRFWUJGY1p2U2RvTThCS2R4OVdiMVM5VVdOc1FK?= =?utf-8?B?QjdlbXA5dUFRUVdKT1ZxNXg3Nm1zdGZmZGNxOWRqa0JUV1B0VWxPUkFkU0pO?= =?utf-8?B?WGpjZlQ5eTdUVWNzWUVHYmpnRXdOV1BTZXloTHdLRXhHTG10V0ZRWU93NnFt?= =?utf-8?B?dXYvR0dMaU12bmJYbzhYbUhOcGJiUlRtMElkSjg0bTgyckR0OW5HS2xKbE41?= =?utf-8?B?cFAxTTNCb1g3TXB1YTg0RzFqZEd2U3lJTStkR2F1Vy8zZGVYbElEcEN0MXFz?= =?utf-8?B?dFl3aEJRbXVQK1BiMUJhenJIblhVWWhlcVA3MElSdldYQnNXYm1zbzhRQzhm?= =?utf-8?B?QzJ5M09id2ZXd2RTMjdKTUlGUnNGS0VPNS9xNm5LMnltN3JyNDRzOWxVdXB5?= =?utf-8?B?eURyRHJlV3R5djVzejJRWWhmc0Y2RWVjcy91T05zYTZyT3dYZXFmN1lzNEhD?= =?utf-8?B?OFZ0ZjcvOTI3SEtheUluVUIzZ0ljMDhpWHBjekRWblMrQVl1aW91M2xxN1N6?= =?utf-8?B?TmVVd05RNEVSK25NdmdEUytCVWtVY241bEsxcS8vYmozSmtIdEkxUTZ0VENX?= =?utf-8?B?TjdtVllqaHJ1RDZXRHJtTlJiTU9CUkxQcnZPYUZweDBaRDQrb0tpcndPVVBW?= =?utf-8?B?ZDg3dmoreDVCTk5IZ0VkNzdFeUJoemN4Q1pUYmtSbU12WmZkbzRNMy9Ud0o3?= =?utf-8?B?K2dNenhob0lqRVU1S1ZmNEhmbDVLYmNFdDZVajVuV0lISTBKQi9OWlZSOHBm?= =?utf-8?B?WDd6Skg3bUMwdlAzdWo0cVpJZVd0VEtQYmI5MGorVVk0NDQyRE1jeUpvTHhL?= =?utf-8?B?Sy9GWHNMQmVreGNzOXF6SmxMSE1sa01sNkZDWlRWNE9ncHlhcTIzOG5xRWhu?= =?utf-8?B?bUhhZm9PbHJ1YmV2STdMbVQ0dmExN3lrbmFnekFRRmdkWkxsQmg0dlJXMHVE?= =?utf-8?B?SVpHZE9TV0RlMitCK2JKTm93QkhpS0tnakFrSXR4Nm82NlpRaFpGTmMvK2VT?= =?utf-8?B?akJsU0YxZk1YUXBlbUp0eVJmeWtVTGlnTThrWDRxK2ZNdFdSTC8yeUs4UUcr?= =?utf-8?B?eGVFVFl4TUtieTgxeDFPWHNMOU1xSFpEb2NLQ2FxVTZ6RWlncktjUTE5bjZY?= =?utf-8?B?b1FaZFMwc2RKdkJBOGlZd2RETXBjQ2FmUzZyN2R4cUUvSFdUNlhqazhKMGcw?= =?utf-8?B?NDNQazJBMG1uL3U3WUl0eHRTaUtFV01Zb3NvZ1JJVkI2dDNlNm1ycU83Vm4z?= =?utf-8?B?bUVObjdSR3VneGJtbGZlMFRWektlcnZML2pES0Q1Zmt1WTU0cjZmY1l5cUNJ?= =?utf-8?B?U0FaTEk5WEEzMWdKeW9oZzJRTjVDZWFqK0J5U0J6VjhYVzVrdmYvSStQZG1u?= =?utf-8?B?eE1vVWE2TXB6QnkzOWdlU2oxeUljU3Y5TjhQNTY5OXhURmYyOFRtOU84bTRH?= =?utf-8?Q?xwjhrnwqQA5SDS/WTmxXXzAiR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5c1e7db-86d1-444b-6d5d-08dac9500df1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 10:31:29.6245 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rCluhwvBhQhB574tVLsdXHOWta8aekrryrhIMYzf+w1yVSYqmdn7cxJSrzopuEWACSqkg5ifbdDf5CspXBDQEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7551 Linux'es relatively new use of HVMOP_set_evtchn_upcall_vector has exposed a problem with the marking of the respective vector as pending: For quite some time Linux has been checking whether any stale ISR or IRR bits would still be set while preparing the LAPIC for use. This check is now triggering on the upcall vector, as the registration, at least for APs, happens before the LAPIC is actually enabled. In software-disabled state an LAPIC would not accept any interrupt requests and hence no IRR bit would newly become set while in this state. As a result it is also wrong for us to mark the upcall vector as having a pending request when the vLAPIC is in this state. To compensate for the "enabled" check added to the assertion logic, add logic to (conditionally) mark the upcall vector as having a request pending at the time the LAPIC is being software-enabled by the guest. Fixes: 7b5b8ca7dffd ("x86/upcall: inject a spurious event after setting upcall vector") Signed-off-by: Jan Beulich --- Don't one or both of the Viridian uses of vlapic_set_irq() need similar guarding? Is it actually necessary for hvmop_set_evtchn_upcall_vector() and hvm_set_callback_via() to call hvm_assert_evtchn_irq() when evtchn_upcall_pending is false? --- a/xen/arch/x86/hvm/irq.c +++ b/xen/arch/x86/hvm/irq.c @@ -321,9 +321,10 @@ void hvm_assert_evtchn_irq(struct vcpu * if ( v->arch.hvm.evtchn_upcall_vector != 0 ) { - uint8_t vector = v->arch.hvm.evtchn_upcall_vector; + struct vlapic *vlapic = vcpu_vlapic(v); - vlapic_set_irq(vcpu_vlapic(v), vector, 0); + if ( vlapic_enabled(vlapic) ) + vlapic_set_irq(vlapic, v->arch.hvm.evtchn_upcall_vector, 0); } else if ( is_hvm_pv_evtchn_domain(v->domain) ) vcpu_kick(v); --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -829,6 +829,9 @@ void vlapic_reg_write(struct vcpu *v, un { vlapic->hw.disabled &= ~VLAPIC_SW_DISABLED; pt_may_unmask_irq(vlapic_domain(vlapic), &vlapic->pt); + if ( v->arch.hvm.evtchn_upcall_vector && + vcpu_info(v, evtchn_upcall_pending) ) + vlapic_set_irq(vlapic, v->arch.hvm.evtchn_upcall_vector, 0); } break; From xen-devel-bounces@lists.xenproject.org Fri Nov 18 10:45:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 10:45:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445561.700774 (Exim 4.92) (envelope-from ) id 1ovysR-0006J3-Ct; Fri, 18 Nov 2022 10:45:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445561.700774; Fri, 18 Nov 2022 10:45:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovysR-0006Iw-AE; Fri, 18 Nov 2022 10:45:43 +0000 Received: by outflank-mailman (input) for mailman id 445561; Fri, 18 Nov 2022 10:45:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovysP-0006Il-Vt for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 10:45:42 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20601.outbound.protection.outlook.com [2a01:111:f400:7e1a::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2381c934-672e-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 11:45:38 +0100 (CET) Received: from AS8PR04CA0086.eurprd04.prod.outlook.com (2603:10a6:20b:313::31) by AS8PR08MB6135.eurprd08.prod.outlook.com (2603:10a6:20b:29f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 10:45:36 +0000 Received: from AM7EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:313:cafe::a3) by AS8PR04CA0086.outlook.office365.com (2603:10a6:20b:313::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 10:45:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT035.mail.protection.outlook.com (100.127.141.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:45:36 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Fri, 18 Nov 2022 10:45:35 +0000 Received: from 512672730ec5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 17EFD73E-CDBF-4268-A296-41C05B7ED42B.1; Fri, 18 Nov 2022 10:45:29 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 512672730ec5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 10:45:29 +0000 Received: from AS9PR06CA0199.eurprd06.prod.outlook.com (2603:10a6:20b:45d::18) by GV1PR08MB8282.eurprd08.prod.outlook.com (2603:10a6:150:a3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Fri, 18 Nov 2022 10:45:25 +0000 Received: from VI1EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45d:cafe::9c) by AS9PR06CA0199.outlook.office365.com (2603:10a6:20b:45d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Fri, 18 Nov 2022 10:45:25 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT043.mail.protection.outlook.com (100.127.145.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:45:25 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 18 Nov 2022 10:45:14 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Fri, 18 Nov 2022 10:45:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2381c934-672e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h3/p1nqS41EbjHPQPygremo0ETj4Qsi4txZRseA7A4M=; b=NxwfLHI9bVp6stCHiCksFe275s1jpunLFqV3y6w7d7NDoiMB+b8VAt1F+kv+KNir0FsqSdYq1iZ6z1mL78jhnVbRyqFv4jMKdikfixb9J0ba3FobL1KsZg6XwIJ9eFCODLJIbCXqCUHol2EkiaFTe6GpAJ3FD8yk0xyQZvFBk88= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8ab75544f7eb704a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fWayiA9LFuzUYGMjvbcodlSgdARBkUPZmNIOYSL9aiZeTdDTEb2p2a3B4GLw/VlkcRILn7vtJLvQ+6SD9/RyjXMRBKBAIvtgFNVcckH0H1v7SZ3Sz/bMVoqLwauhMSl4Z/xI+0xjAOuuLRSQOz1/+VQ8GqxM61BaJCe6hFR3xB9USN3mrYLtv4yvnp/s6WlUY/r9acSy/VzQCX2GVDiyWj7NY6vDDWYBsGP8xdxkKGiZuPNf2tt/s8f+Sz71OdNNgijQq4PFDBsesLSdJWMNx8pO9m/19UIDLbaHBREJQFd98oIyoUKZgay3d8AJGyDaFsxvINRP5aw2XieET37U+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h3/p1nqS41EbjHPQPygremo0ETj4Qsi4txZRseA7A4M=; b=Leq6UVYioYtp7mUSz/aJ/yyTU8pzyrzlYbgGKaUC1DWtsIateLxSORSZJEW1iJr9wEfE1HfmXJ3pYV4dG2X+rnzLgo9InniZRXNF/04z/MPsGH0xJeM4Vn4MqZ2G/rkw21ebxDdSR4efLTnk2K3xIhlGUgOUIWe9MpFArtnVgN7oZBPuTKQ9q48hrUtTUip2g9QeqKtdR2ZxqYVyHW2lFsnxiWoAHONUPxReZ/JSUgnAbsMlF0j8hN1i4HFMz3nFQHHuzoy34cIMbgN06rgczZstOhtWBasyt8gTOuMETKDRMIdvoZcbE2OYrhTec99YcvQv0AAuatPHU2JKHhvC3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h3/p1nqS41EbjHPQPygremo0ETj4Qsi4txZRseA7A4M=; b=NxwfLHI9bVp6stCHiCksFe275s1jpunLFqV3y6w7d7NDoiMB+b8VAt1F+kv+KNir0FsqSdYq1iZ6z1mL78jhnVbRyqFv4jMKdikfixb9J0ba3FobL1KsZg6XwIJ9eFCODLJIbCXqCUHol2EkiaFTe6GpAJ3FD8yk0xyQZvFBk88= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v9 0/6] Device tree based NUMA support for Arm - Part#2 Date: Fri, 18 Nov 2022 18:45:02 +0800 Message-ID: <20221118104508.768274-1-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT043:EE_|GV1PR08MB8282:EE_|AM7EUR03FT035:EE_|AS8PR08MB6135:EE_ X-MS-Office365-Filtering-Correlation-Id: a0141c61-a652-4aaa-6303-08dac952069b x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1FxuQrTFvi6gM5VZn8Axqe56JEZs1v68YWv5vOepK73r35OOBrqeH0l9F+ebEzA2Mj5ZgI5jaAfavW4CbfCTAxsAa3+sVcu6VjnQNbExiLDyKOIETa4BuNut6d+9eCFbLqyjk7NTqWSf+bOUIwzNk6biAx648EIFnTJDTj+uRHr9ibaaBJD9Vl8c/qcV6psWfBmaZYsJalPdhMwM4otj5m/t07NwVw0slqFQpMXHsYsQrdCYNXeRnS7g33uMxEHGX+ORxhPNWykw0AMaMxZGQyx+JAq0SeNOSEmrlUSFWHc+VM5Ibb9I9AR0+eo8+qQPhnGt+uJqt4nPadpVEwvaJLfrDF0Q7qsSHxfGeiho1KSs+sYdoM4Q1ZnQNlE0+seUAyW1IkT8dJs3mghj+Zee4mp3wToMxskIt5Ggz6D9Tk9zB2Iyg0vxNaruFuNKuuEbfwf25CB9LfmS8CU2NqFv+ZO1S2jLS6g9mN6oHT7wv3A+E8snN6dTz8a2Ad5vNQXmsZNMC00mxJrN47k2QdDvVRTlGf2NBTrLj+GC6rHIV2mdgdB7cB6jUf0SeXdlsm5O81dFW/TFO+mBI+wa2NLO0YgPFjySLjjixkVLmUHNp18Adw6FIK4XcV5fBlCRTxJGWCZgF0KuVtsyZaqk5NUo61ByxGq9mtd+QKzVSNpy4JRrreaKndAMo0cxDPCsTKLWm2HWYg3WVNX+mIdF2z1dtrTusNujOHqEwo+oqk80JaLvyIkYLCtmlGpj0FSyId6ubcqOVbOjSfy0sqbXj5aP7AoCuZ9cWlb+wgvLZQFOIp3kIK2rnVARDTBJG0jQP3Ot X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(376002)(39850400004)(451199015)(40470700004)(36840700001)(46966006)(26005)(6666004)(7696005)(2906002)(82310400005)(5660300002)(44832011)(81166007)(356005)(47076005)(966005)(336012)(426003)(1076003)(2616005)(186003)(70206006)(36756003)(83380400001)(70586007)(478600001)(8676002)(40480700001)(40460700003)(54906003)(316002)(8936002)(41300700001)(4326008)(86362001)(82740400003)(6916009)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8282 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dbc08d06-fe27-4de1-3ed7-08dac952001d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pN84wKvdq1F9A0V3YC9tqFMFE9WXkdQ4aGTPCDnTpOBCL72+SF6d425odNPpc3H363eRMjzDDWtGUuGx5V2CO8BclAsxKPvUTJDKz/Ne9tJDXTPcmucO2d7Q4u+YANBC/LzqyZXofa7k/NxhrzVqXfUXDrdxFOJvs+dtpmRzvZyi5SuecXOWAMLgVe6v8r7ieI1WgLeblRGSjfNYBP6zepauD8fmJIKC/AgYtL/cYflCHEysRPQ/cGEPbIPMLoAmRtXYDZhNYJFGAmQsfxNKoK3dfzeNWC6IWKRGcIw6H5U4cE4SolyUfv9KNmRFG8VmVbg9qY1CFwd8ArFS9pHOcQ78na4nChCk9CgmBBqMoQzK3Gx13XvWH5c37V/OUi4Ks4g/z5SzR+0pK5W/RuSMZckV1Mkvk+gZF9bbzFq6TMQlGTzwGc7i8xSmMvsl6TZkRQS9J6Qi0ACfHD7PlQGOTVCOGW1ESNAmuOcfAjw5bumpJgpk3FNetNHBpLJBW9+X7NOm64uCoYEYF+3CU8t6tJIUFKhPi1VTHcmbguu4HjjgpYybYkE3Kro3KI3W6+i44xtWm2Jzswygn48y3gjTXf1saHIWOK7awYrrtXxkXxfuM4wMKfMMLiY3s7VtQANyxCa7dRO7n90v6s5eRL+u0S+giLcDWosRFYzZatJZ6EdzO1sIjJHTSTPcSBs7JHk+g7hkQI90BePYUc0V+sOHJs+QOrWJiEjTIcVwjg2fQ00B2aMi8Bd8fQPrc5Xic/G3zhuH25BEhWNrRbMufy7d5w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(136003)(451199015)(36840700001)(46966006)(40470700004)(426003)(186003)(336012)(2616005)(1076003)(81166007)(47076005)(82740400003)(2906002)(26005)(107886003)(7696005)(6666004)(36860700001)(83380400001)(478600001)(6916009)(966005)(54906003)(316002)(5660300002)(44832011)(70586007)(8936002)(86362001)(41300700001)(8676002)(40460700003)(70206006)(4326008)(82310400005)(36756003)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 10:45:36.0913 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a0141c61-a652-4aaa-6303-08dac952069b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6135 (The Arm device tree based NUMA support patch set contains 35 patches. In order to make stuff easier for reviewers, I split them into 3 parts: 1. Preparation. I have re-sorted the patch series. And moved independent patches to the head of the series - merged in [1] 2. Move generically usable code from x86 to common - this series. 3. Add new code to support Arm. This series only contains the second part patches. As the whole NUMA series has been reviewed for 1 round in [2], so this series would be v9) Xen memory allocation and scheduler modules are NUMA aware. But actually, on x86 has implemented the architecture APIs to support NUMA. Arm was providing a set of fake architecture APIs to make it compatible with NUMA awared memory allocation and scheduler. Arm system was working well as a single node NUMA system with these fake APIs, because we didn't have multiple nodes NUMA system on Arm. But in recent years, more and more Arm devices support multiple nodes NUMA system. So now we have a new problem. When Xen is running on these Arm devices, Xen still treat them as single node SMP systems. The NUMA affinity capability of Xen memory allocation and scheduler becomes meaningless. Because they rely on input data that does not reflect real NUMA layout. Xen still think the access time for all of the memory is the same for all CPUs. However, Xen may allocate memory to a VM from different NUMA nodes with different access speeds. This difference can be amplified in workloads inside VM, causing performance instability and timeouts. So in this patch series, we implement a set of NUMA API to use device tree to describe the NUMA layout. We reuse most of the code of x86 NUMA to create and maintain the mapping between memory and CPU, create the matrix between any two NUMA nodes. Except ACPI and some x86 specified code, we have moved other code to common. In next stage, when we implement ACPI based NUMA for Arm64, we may move the ACPI NUMA code to common too, but in current stage, we keep it as x86 only. This patch serires has been tested and booted well on one Arm64 NUMA machine and one HPE x86 NUMA machine. [1] https://lists.xenproject.org/archives/html/xen-devel/2022-06/msg00499.html [2] https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg01903.html --- v8 ->v9: 1. Remove incorrect description in patch#5's commit log. 2. Add code comments for the places to set numa_fw_nid_name. v7 -> v8: 1. Change "of shift too small" to "or shift too small". 2. Add numa_fw_nid_name setting in srat_parse_regions after acpi_table_parse succeeded. v6 -> v7: 1. Restore %d for nodeid_t in dump_numa. 2. Use sizeof(page_num_node) for page_num_node size in memset. 3. Add description for using min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift when only one node is in the system. 4. Use %pd for domain print in dump_numa. 5. Add __init for arch_numa_unavailable. 6. Use __ro_after_init for mem_hotplug. 7. Use "???" instead of "NONAME" for unset numa_fw_nid_name. 8. Fix code-style. v5 -> v6: 1. Revert arch_numa_broken to arch_numa_disabled, as acpi_numa can be set to -1 by users. So acpi_numa < 0 does not mean a broken firmware. 2. Replace numa_scan_node to numa_process_nodes in commit log. 3. Limit the scope of page_num_node, vnuma and page of numa_setup function. 4. Use memset to init page_num_node instead of for_each_online_node. 5. Use %u instead of %d for nodeid_t and j in numa_setup print messages. 6. Use min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift when only one node is in the system. 7. Drop the marco: node_to_first_cpu(node) 8. Use arch_numa_unavailable to replace arch_numa_disabled for acpi_numa <= 0. 9. Remove Kconfig for HAS_NUMA_NODE_FWID. 10. Use numa_fw_nid_name for NUMA implementation to set their fw NUMA node name for print messages. v4 -> v5: 1. Use arch_numa_broken instead of arch_numa_disabled for acpi_numa < 0 check. Because arch_numa_disabled might include acpi_numa < 0 (init failed) and acpi_numa == 0 (no data or data no init) cases. 2. Use nodeid_t instead of uint8_t for memnodemap. 3. Restore to use typeof(*memnodemap) for _memnodemap, this will avoid the further adjustments for _memnodemap's type. 4. Use __ro_after_init for numa_off. 5. Use pointer-to-const for proper function parameters. 6. Use unsigned int for variables that are not realy used for node ID. 7. Fix code comments code-style and adjust the length. 8. Fix code-styles. 9. Rename numa_scan_nodes to numa_process_nodes. 10. Defer introduce arch_numa_disabled for acpi_numa <= 0. And remove the paramter init_as_disable of arch_numa_disabled. 11. Fix typo "expandsion". 12. Fix Indentation for l1tf_safe_maddr. 13. Remove double blank lines. 14. Add a space between for_each_node_mask and '('. Add a space page_list_for_each and '('. 15. Use bool for nodes_cover_memory return value. 16. Use a plain "int ret" to record compute_hash_shift return value. 17. Add a blank line before the function's main "return". 18. Add new Kconfig option HAS_NUMA_NODE_FWID to common/Kconfig. v3 -> v4: 1. Add init_as_disable as arch_numa_disabled parameter in the patche where use it. 2. Drop unnecessary "else" from arch_numa_setup, and fix its indentation. 3. Restore compute_hash_shift's return value to int. 4. Remove unnecessary parentheses for macros. 5. Use unsigned int for proper variables. 6. Fix some code-style. 7. Move arch_get_ram_range function comment to header file. 8. Use bool for found, and add a new "err" for the return value of arch_get_ram_range. 9. Use -ENODATA instead of -EINVAL for non-RAM type ranges. 10. Use bool as return value for functions that only return 0/1 or 0/-EINVAL. 11. Move mem_hotplug to a proper place in mm.h 12. Remove useless "size" in numa_scan_nodes. 13. Add CONFIG_HAS_NUMA_NODE_FWID to gate print the mapping between node id and architectural node id (fw node id). v2 -> v3: 1. Drop enumeration of numa status. 2. Use helpers to get/update acpi_numa. 3. Insert spaces among parameters of strncmp in numa_setup. 4. Drop helpers to access mem_hotplug. Export mem_hotplug for all arch. 5. Remove acpi.h from common/numa.c. 6. Rename acpi_scan_nodes to numa_scan_nodes. 7. Replace u8 by uint8_t for memnodemap. 8. Use unsigned int for memnode_shift and adjust related functions (compute_hash_shift, populate_memnodemap) to use correct types for return values or parameters. 9. Use nodeid_t for nodeid and node numbers. 10. Use __read_mostly and __ro_after_init for appropriate variables. 11. Adjust the __read_mostly and __initdata location for some variables. 12. Convert from plain int to unsigned for cpuid and other proper 13. Remove unnecessary change items in history. 14. Rename arch_get_memory_map to arch_get_ram_range. 15. Use -ENOENT instead of -ENODEV to indicate end of memory map. 16. Add description to code comment that arch_get_ram_range returns RAM range in [start, end) format. 17. Rename bad_srat to numa_fw_bad. 18. Rename node_to_pxm to numa_node_to_arch_nid. 19. Merge patch#7 and #8 into patch#6. 20. Move NR_NODE_MEMBLKS from x86/acpi.h to common/numa.h 22. Use 2-64 for node range. v1 -> v2: 1. Refine the commit messages of several patches. 2. Merge v1 patch#9,10 into one patch. Introduce the new functions in the same patch that this patch will be used first time. 3. Fold if ( end > mem_hotplug ) to mem_hotplug_update_boundary, in this case, we can drop mem_hotplug_boundary. 4. Remove fw_numa, use enumeration to replace numa_off and acpi_numa. 5. Correct return value of srat_disabled. 6. Introduce numa_enabled_with_firmware. 7. Refine the justification of using !node_data[nid].node_spanned_pages. 8. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. 9. Adjust the conditional express for ASSERT. 10. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86. 11. Use conditional macro to gate MAX_NUMNODES for other architectures. 12. Use arch_get_memory_map to replace arch_get_memory_bank_range and arch_get_memory_bank_number. 13. Remove the !start || !end check, because caller guarantee these two pointers will not be NULL. 14. Add code comment for numa_update_node_memblks to explain: Assumes all memory regions belonging to a single node are in one chunk. Holes between them will be included in the node. 15. Merge this single patch instead of serval patches to move x86 SRAT code to common. 16. Export node_to_pxm to keep pxm information in NUMA scan nodes error messages. 17. Change the code style to target file's Xen code-style. 18. Adjust some __init and __initdata for some functions and variables. 19. Replace CONFIG_ACPI_NUMA by CONFIG_NUMA. Replace "SRAT" texts. 20. Turn numa_scan_nodes to static. 21. Change NR_NUMA_NODES upper bound from 4095 to 255. Wei Chen (6): xen/x86: Provide helpers for common code to access acpi_numa xen/x86: move generically usable NUMA code from x86 to common xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid xen/x86: use arch_get_ram_range to get information from E820 map xen/x86: move NUMA process nodes nodes code from x86 to common xen: introduce a Kconfig option to configure NUMA nodes number xen/arch/Kconfig | 11 + xen/arch/x86/include/asm/acpi.h | 2 - xen/arch/x86/include/asm/mm.h | 2 - xen/arch/x86/include/asm/numa.h | 61 +-- xen/arch/x86/include/asm/setup.h | 1 - xen/arch/x86/mm.c | 2 - xen/arch/x86/numa.c | 441 +---------------- xen/arch/x86/smpboot.c | 2 +- xen/arch/x86/srat.c | 337 ++----------- xen/common/Makefile | 1 + xen/common/numa.c | 803 +++++++++++++++++++++++++++++++ xen/common/page_alloc.c | 2 + xen/include/xen/mm.h | 2 + xen/include/xen/numa.h | 96 +++- 14 files changed, 964 insertions(+), 799 deletions(-) create mode 100644 xen/common/numa.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 10:45:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 10:45:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445564.700806 (Exim 4.92) (envelope-from ) id 1ovysX-00076T-Hz; Fri, 18 Nov 2022 10:45:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445564.700806; Fri, 18 Nov 2022 10:45:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovysX-00076M-Eu; Fri, 18 Nov 2022 10:45:49 +0000 Received: by outflank-mailman (input) for mailman id 445564; Fri, 18 Nov 2022 10:45:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovysW-0006Il-1F for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 10:45:48 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20628.outbound.protection.outlook.com [2a01:111:f400:fe1a::628]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 28bb13a9-672e-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 11:45:47 +0100 (CET) Received: from DB6PR0301CA0088.eurprd03.prod.outlook.com (2603:10a6:6:30::35) by AM7PR08MB5429.eurprd08.prod.outlook.com (2603:10a6:20b:107::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 10:45:40 +0000 Received: from DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::b) by DB6PR0301CA0088.outlook.office365.com (2603:10a6:6:30::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 10:45:40 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT040.mail.protection.outlook.com (100.127.142.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:45:40 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Fri, 18 Nov 2022 10:45:40 +0000 Received: from e3a20634adf0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DA6E12D7-70B0-4910-B3C3-49F863636645.1; Fri, 18 Nov 2022 10:45:33 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e3a20634adf0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 10:45:33 +0000 Received: from FR3P281CA0145.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::8) by AM9PR08MB6258.eurprd08.prod.outlook.com (2603:10a6:20b:287::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 10:45:31 +0000 Received: from VI1EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:95:cafe::e2) by FR3P281CA0145.outlook.office365.com (2603:10a6:d10:95::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 10:45:31 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT015.mail.protection.outlook.com (100.127.144.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:45:31 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 18 Nov 2022 10:45:24 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 18 Nov 2022 10:45:24 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Fri, 18 Nov 2022 10:45:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28bb13a9-672e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cZdzCTYPCRdEijtzlPbxujpvQi5i4DcA5OYYtuNHtTA=; b=36KCODnxdQIUd6vS/M5g5EvmQUhnOkHBhWp1gz5em/Qt2fJZGdA4bIG44xf8Do7kQCYQdsLeuwXRdQ10JSqjliTFUaHQw2PNG7nr32imrIIsOf6JTeTE6FszvsxRqjKoRiCtp2BXYloEmHRt6jSagS24L7mpttz1df6+VcS/Bxw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 68940c93ce4c54ac X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TOhPf3MiTjcAS4jEqV0YfupikNa2uTomaapC7QayCvCirsBR/VK7TqpLGweO26fAEOybIrMr1sQCGktkqgsQhTS7IDxILNU03K8HYLhusUIjZiLrKczznOfw9x7pATGZ/voP2OabsvtW1NR8xYoudvam2Exi34G3aYeunbnS4ZFwu+2BGw+CVHTc1plAakUqFZq0tnV6uTgVs40ESjQ34qCbh2jtwGQlObFTIkSV483oDxiZAd9xi1wqhYEDWll4ttuCWls2xMC7sSvMkez3Wo4efZB7o++nv68y0uk3zt4uWnD+vC+bjqrQ9lCr59InQIsk9p9i32wmKbR7WLI9oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cZdzCTYPCRdEijtzlPbxujpvQi5i4DcA5OYYtuNHtTA=; b=Xi5oZyIgVWjGLqPYYPUUsM9FCXf1qVZ8HUWVaXVv592NTCDpxgyGjtIqu2RF+aCKwqLQaZIQiEyePNo680JZv3eYueSA+6fSTB3DJl4mUsfczrAlUgzakjVbEyRtf/AsQ10WJQr6MQyMbB5wqW9omw+1gb99tFxhM4rk+0Liy5MLydwgmyB1FsKQ8OvRlXFQSW754uji4tOeRdqoWvR/hAxTt5Vhx6zu42uzYh5fDhqhj/c2ukGez63r5v+D7kmINXdZZ1zvjcy9j6vK7Y8Q8jem5juf6X9XmAUHvEYPfxVpDPOLn7DH7DvGmXKIXxH3l7yHRDLDO8Zit/YwrvpOhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cZdzCTYPCRdEijtzlPbxujpvQi5i4DcA5OYYtuNHtTA=; b=36KCODnxdQIUd6vS/M5g5EvmQUhnOkHBhWp1gz5em/Qt2fJZGdA4bIG44xf8Do7kQCYQdsLeuwXRdQ10JSqjliTFUaHQw2PNG7nr32imrIIsOf6JTeTE6FszvsxRqjKoRiCtp2BXYloEmHRt6jSagS24L7mpttz1df6+VcS/Bxw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu , Jiamei Xie Subject: [PATCH v9 3/6] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid Date: Fri, 18 Nov 2022 18:45:05 +0800 Message-ID: <20221118104508.768274-4-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221118104508.768274-1-wei.chen@arm.com> References: <20221118104508.768274-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT015:EE_|AM9PR08MB6258:EE_|DBAEUR03FT040:EE_|AM7PR08MB5429:EE_ X-MS-Office365-Filtering-Correlation-Id: 33e28034-a03a-4168-02a9-08dac9520915 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: E5xqWbLvAnn3Vd2pP0lTxuXaIuhCakLKm1XGAHYGj8VFbaQkh/c01f9SxL9zqO8rCpRWQP1pChaLHXuVWOW7Duh/33iOlqHEn7QjO2Ph8e0WQtNfjmybYMLbzfJwF1YJ1kuu4bH4orCAPbPIoYoxkL2ts3euoIwUI198VI1/n13IJf3rphIDInq8cTdT4fh4AF/Xw2o8fX/MN1xxGEOVPGLwBa1JX6q1f9I1v4vYR2XF6gYM4zXYDFap65KuHM0/SvxxPhPNokOoCf8PDUM6sGi/uLjFsi8KfS5BLF1RPwwuHvJvhB9DWGJ4OnqZXaWiOMqosFZOGowFvoeGa3RSEbCNs6gLGsLLcR0JKlNCvuOnebTsQXYTlO6YedhPzXaYxV/9Z0Bw6c4vk0KKwu06p+h45NN0TDTX9Q6tr+BH7O8ABZmbzupKfug7osoA8FbAFDwucdiHBrcuOVPAKZmjPGqh4Ax1Jti0dpSnK5MDPpGeNDP0NKgb0J35xciQPH2AsTnTGhYKSVyMI1O+R1gnIPyVtu4rnE2Cldfuo75KyPCW1n3jGWO3fMsrq4c9Rog3g2vkNEOIKiBhVIAkk141rNIrCoyyU8k+eLTAIhi8l1+y8QQld8IAxg/zInfrD26vY3RYG+Ik+sCNj2RTkfUqwrRmcOYqedIpoZn4voPDxx+Fuyoo7YKn06L/ZISbBBYz2KBkqCREBS/CxngSyII84hFGFkAJbLuW5XMb67VFawg= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(6916009)(356005)(82310400005)(44832011)(316002)(82740400003)(47076005)(426003)(36756003)(40480700001)(54906003)(186003)(36860700001)(8936002)(2906002)(1076003)(8676002)(83380400001)(70206006)(5660300002)(41300700001)(70586007)(4326008)(336012)(86362001)(2616005)(40460700003)(6666004)(7696005)(26005)(81166007)(478600001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6258 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8721e258-1031-40d2-8ba0-08dac95203ec X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pAbFxshUfxsJ2ofJjy7KQhwxrBPChiInqhsL3B33EnhicnpHzcRgskMGRiLmKcagvhdHzliZf62z0FCBZTFDVxQ/5CZr9i/E+RSFX0wwQq1YQVVjN2B3Xc9kF0i4kNyP3barzj/2LaiT7dcXrHsZf3OgLFHvspIW+qu5FkyEyjea/07RxE9YJkRHbIQmUdTe0L5p9FceCu725GrOWa4CDrR/t3irqUS2dwUv1G2nPgxFp1l7xQBVybROWW4tpNJbK3OpHkwSvrDEevN+s9drBvBSqUllNanTWCzsAAuN8Di/d1u6ed5cEHd60rxofzAnou8oe5I9PSptiNBw/tA+RmYVsvYd3DNTWVftCqiVu59RrG9V5apUd0Z2w53WHRgadcVcN+cb2gr1vyxeqdwO+zCDmoU9i04v65h1G6QCupjC4medjhXTD/VIXtiJjdJZ7PE9GMSqcGDcsHW1shF+1K2kJq9wXky3WjUKTpy4zUxXglDCMIbhtzVij2sYPZH8cHy4ov4YBXoJFibUrxjDvnYdrDFG1eNWWLGAdkmhjv+7x6o3Muj3nh50Lpx2jEi+cR+i4qrzgdxhtxcz474TpIDxEcvWcmiFoow8U9uoiGjboygH+h3dg7u5BQqshr/vLzkF/EAFpOL6ABKF8YJ9x0vuE6vId650XRd1gqCLcA9DhazalJlXUA3Kh86Xc8LwKojVAA7WFFO/97ZkLFfO4A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(39850400004)(451199015)(40470700004)(36840700001)(46966006)(81166007)(41300700001)(82310400005)(4326008)(40480700001)(8676002)(70586007)(44832011)(36860700001)(83380400001)(8936002)(316002)(7696005)(6666004)(6916009)(478600001)(86362001)(26005)(54906003)(47076005)(186003)(336012)(2906002)(2616005)(426003)(1076003)(5660300002)(36756003)(82740400003)(70206006)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 10:45:40.3219 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 33e28034-a03a-4168-02a9-08dac9520915 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5429 VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This results in two lines of error-checking code in phys_to_nid that is not actually working and causing two compilation errors: 1. error: "MAX_NUMNODES" undeclared (first use in this function). This is because in the common header file, "MAX_NUMNODES" is defined after the common header file includes the ARCH header file, where phys_to_nid has attempted to use "MAX_NUMNODES". This error was resolved after we moved the phys_to_nid from x86 ARCH header file to common header file. 2. error: wrong type argument to unary exclamation mark. This is because, the error-checking code contains !node_data[nid]. But node_data is a data structure variable, it's not a pointer. So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to enable the two lines of error-checking code. And fix the left compilation errors by replacing !node_data[nid] to !node_data[nid].node_spanned_pages. Although NUMA allows one node can only have CPUs but without any memory. And node with 0 bytes of memory might have an entry in memnodemap[] theoretically. But that doesn't mean phys_to_nid can find any valid address from a node with 0 bytes memory. Signed-off-by: Wei Chen Tested-by: Jiamei Xie Acked-by: Jan Beulich --- v8 -> v9: 1. No change. v7 -> v8: 1. No change. v6 -> v7: 1. No change. v5 -> v6: 1. No change. v4 -> v5: 1. No change. v3 -> v4: 1. No change. v2 -> v3: 1. Remove unnecessary change items in history. 2. Add Acked-by. v1 -> v2: 1. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. 2. Adjust the conditional express for ASSERT. 3. Refine the justification of using !node_data[nid].node_spanned_pages. --- xen/include/xen/numa.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 5b3877344b..04556f3a6f 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -35,8 +35,6 @@ struct node { extern int compute_hash_shift(const struct node *nodes, unsigned int numnodes, const nodeid_t *nodeids); -#define VIRTUAL_BUG_ON(x) - extern bool numa_off; extern void numa_add_cpu(unsigned int cpu); @@ -69,9 +67,9 @@ extern struct node_data node_data[]; static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) { nodeid_t nid; - VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); + ASSERT((paddr_to_pdx(addr) >> memnode_shift) < memnodemapsize); nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; - VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); + ASSERT(nid < MAX_NUMNODES && node_data[nid].node_spanned_pages); return nid; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 10:45:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 10:45:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445563.700796 (Exim 4.92) (envelope-from ) id 1ovysV-0006oc-5R; Fri, 18 Nov 2022 10:45:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445563.700796; Fri, 18 Nov 2022 10:45:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovysV-0006oV-1b; Fri, 18 Nov 2022 10:45:47 +0000 Received: by outflank-mailman (input) for mailman id 445563; Fri, 18 Nov 2022 10:45:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovysT-0006R2-04 for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 10:45:45 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20622.outbound.protection.outlook.com [2a01:111:f400:7e1b::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 21399c53-672e-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 11:45:34 +0100 (CET) Received: from AM6PR10CA0069.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::46) by VI1PR08MB9984.eurprd08.prod.outlook.com (2603:10a6:800:1c7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Fri, 18 Nov 2022 10:45:38 +0000 Received: from AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:80:cafe::5a) by AM6PR10CA0069.outlook.office365.com (2603:10a6:209:80::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 10:45:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT024.mail.protection.outlook.com (100.127.140.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:45:37 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Fri, 18 Nov 2022 10:45:37 +0000 Received: from 12f38b6ab8ce.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 142453EE-88AA-4242-A3D0-BE195FC8BD56.1; Fri, 18 Nov 2022 10:45:30 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 12f38b6ab8ce.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 10:45:30 +0000 Received: from AM6P194CA0044.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::21) by AM9PR08MB6020.eurprd08.prod.outlook.com (2603:10a6:20b:2d6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.8; Fri, 18 Nov 2022 10:45:28 +0000 Received: from AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:84:cafe::83) by AM6P194CA0044.outlook.office365.com (2603:10a6:209:84::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 10:45:28 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT051.mail.protection.outlook.com (100.127.140.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:45:28 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 18 Nov 2022 10:45:27 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Fri, 18 Nov 2022 10:45:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21399c53-672e-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2wQ8/FZBsYtn+E4uyHcWiQeWkJ4kxRPSI3oqXiHsNW8=; b=h3GAD3I/ZzAFvDzcrb68L2+B6vKGtmEo9Y7ywnqmLHXIv42qhNKsJBPc3pWqNKNjn4bHJFJ44AHuTUQy+2Sxfb/sQq6LCEM7UjkAtYfdER0iAX4tNqlbWg1Ljuir2XY+1ygnGBscXPplAtvhDtsU/L5bKQ4zGfT6NWeCRLCgvC0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: ce6e84f24473665c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m7hJM/s2p8/2b4e6bGUl1QVvwH4A1qQac8ew2EOfQMrCaEtWXeMsmnIpoimPhPun5GvSeczT+m1NE9C2q/rJ/i+mobhm1Ye7YsHxkmqwkEJ3JJfvR5lHJfnqXQytYNlzzXiVSaepPCYwdUMfCCc4WD37V0qmrVfn3ope19LkYKzbtqOSpm3ownYDnHLb3jc3yeArCgSQr0xRZchiTzq0Bph54rmUAwqKxyB3plFyrwi61IrQXNiECNQCnXZ//qW69FyS2QG7SQpfLZ2E3HabAgNCQZuXMnI5pqtu06FcHG4GJpSRoAaVQGKJhuMVylALKz1ldVsd4LNbBQMi6+x4zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2wQ8/FZBsYtn+E4uyHcWiQeWkJ4kxRPSI3oqXiHsNW8=; b=FbiXuRPBscn1NIaAeyT6z0J/8lCJ0W5UutTGTUln2tzOK7qcXJ1yP8RjG03bf8M4sc5q49/0cX+dTZgU3nJ50nt3LJTZpPHInVHPSYLTU/FlHaF/txVdUsVvy1xPzFPGKgTBCcNTA6sgv7Q7boCQf1S7tL0lAe7W0QpmyXuMdmLUEYaMftACkZ06QJLg97ph/QW1VlhhXr1xM7v47TASWtG6iZQ32RweL7WoQTdU4oeIyHjiEjtF92Psf6DB6D9ujlWf/FcUGZAgpbLBapKo+Ww/639a/ChT5iJSCFf7l+yuzNg15tTdrcoxxkfUtmtSTFXCWmcLr2RQXFI2bD//EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2wQ8/FZBsYtn+E4uyHcWiQeWkJ4kxRPSI3oqXiHsNW8=; b=h3GAD3I/ZzAFvDzcrb68L2+B6vKGtmEo9Y7ywnqmLHXIv42qhNKsJBPc3pWqNKNjn4bHJFJ44AHuTUQy+2Sxfb/sQq6LCEM7UjkAtYfdER0iAX4tNqlbWg1Ljuir2XY+1ygnGBscXPplAtvhDtsU/L5bKQ4zGfT6NWeCRLCgvC0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v9 4/6] xen/x86: use arch_get_ram_range to get information from E820 map Date: Fri, 18 Nov 2022 18:45:06 +0800 Message-ID: <20221118104508.768274-5-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221118104508.768274-1-wei.chen@arm.com> References: <20221118104508.768274-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT051:EE_|AM9PR08MB6020:EE_|AM7EUR03FT024:EE_|VI1PR08MB9984:EE_ X-MS-Office365-Filtering-Correlation-Id: 52de9e07-dcee-4dde-30dc-08dac95207b9 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Q5feJxiPUYUxysp6wFC8qVKhHHK/s6qWlkQda+v7udtPMnaYnFOcqYCSWbKdY3ES8+UUMJd035MGv7GfqpmsFPtmMNbK3hYDNF6W5ACn/rWP+76miTwjyGcd4YXvBtYAqbXvev6GKMDiw4FYpv6+Gnl3IBzDLdNqIVGdOws7bxVXZTULMK05nDPx/CGVcRIFfaYOO1KlsFd+Lig3LYZCFQhgxUqfjuXhuZGP4u3VfTUMhjLqGKGElaijC3yUroaaB87y9UvsCTkyegEN4urBCm6BWKcNbiQDZVV4ElH8u6bHSnrtLH4FKRUyHKusvp1iAPybOxa0KJ9KeY6Du9BpJanZ1cSySmbM1H8gHwjw2wysb2DXCC/fsL9eYiDi7Ph4JLB23MAh//BoJW1Zz3iTioav+Vha3dm7/Q7QIwsM8qXkZQFeV8rdnEs2M/d62y5x9Mru88HYPYz0UZtfJp4bkU1Dt4sa6PnySgDArkrOp5IJyGjYFJVEshs+n4wwNXiYknT6SMscQfYZQZuU4+wEef5hCpJLLMjErSNi/jUTzjhIoQQk8UdmGGa2ZSYpu9ViJrVRCRIexOGYmM7/PuwYv255AVy8itgD1pqZNkUlUbp2jvSLm9LaYaTyWcWLld2C5vN/AJ/zpX/fyFVeXd5Vpj3LfrbEFnyUDSkOjZ5DSFpnj1cnXkdNYAlU+UJSQ6I/4ZIGCJU24Mpm0IAKQeYdNOeqWOLDNwBmLsNQTioiCuM= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(136003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(83380400001)(86362001)(40460700003)(7696005)(6666004)(26005)(478600001)(356005)(81166007)(36756003)(40480700001)(70586007)(82310400005)(36860700001)(336012)(186003)(2616005)(1076003)(426003)(47076005)(8936002)(70206006)(44832011)(41300700001)(82740400003)(8676002)(316002)(5660300002)(4326008)(54906003)(6916009)(2906002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6020 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4ce3f9f0-9fa5-4ed6-28f9-08dac952021e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1yizkIegv7EIu1eebYVFE3nX8Fm/nJF8nWrEyBhdqUlKvjCYzGH3J23mhHiyU3LrSZFkR+r4wYqVC8xbkTWslrXEWQhc3UTexuSZsGaxtcdGd4UeTxj0kTH6NRkRWaIX7wuoaMy+96hjQNtKaeBXekELBhEZm8aosZN5STJ5ADEHYVSDlkux5Wso8r8lCqxRvyJnpID81Y7Eetdup0IVq1l8GuBxDvoVWQu6CLMS/GimszR9u/lL/zjlht42K8MU4cOHo1sDHB9/eOawdFEfHZuHpIGOqmJu6ZkhWIBA5mLWOUDCyrLnHfxDrmFl3RNz/z78Bel62stQTBNIYU+h4jd4m+lDEGAg0c39yzpYOF0OjBowp8a5dRbqgamUPdoSjnQhi8xHx5gauF1APIRKvx2pm13aSbbmx98SrX9yYQI/uEkHZc2rw4Csgw5MVp2ql4J5LhrBLaDFYDIagPvwu/PJtvbhA9Vatnpy4eVgoeGIT9thNs3saOk0Uh3DwEq6L7zx3QxtmQjZkf1X0s8ivLrxIDwBkPE5YydoUd+Cspgtxpn0gutID6AoucxHTeKeuVRWZvik5UTDdGIwxQT3lRyXwy+sbgUlOBvOtjrc6my7yNI2j4Ot94W7z4bxMIGMRiVLpY1HWDDiSKDEw88qua/p/PkcGp6ncDPhdgTLxLIxnl9tEyw3Hwv8+rFaIx2eor6HtA4l1phy8Yz9abYOUg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39850400004)(136003)(376002)(396003)(451199015)(40470700004)(46966006)(36840700001)(36756003)(8936002)(36860700001)(7696005)(40480700001)(86362001)(81166007)(82740400003)(40460700003)(8676002)(6666004)(47076005)(2906002)(426003)(5660300002)(41300700001)(83380400001)(2616005)(82310400005)(107886003)(44832011)(478600001)(1076003)(26005)(186003)(4326008)(336012)(70206006)(70586007)(54906003)(6916009)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 10:45:37.9799 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52de9e07-dcee-4dde-30dc-08dac95207b9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB9984 The sanity check of nodes_cover_memory is also a requirement of other architectures that support NUMA. But now, the code of nodes_cover_memory is tied to the x86 E820. In this case, we introduce arch_get_ram_range to decouple architecture specific memory map from this function. This means, other architectures like Arm can also use it to check its node and memory coverage from bootmem info. Depends arch_get_ram_range, we make nodes_cover_memory become architecture independent. We also use neutral words to replace SRAT and E820 in the print message of this function. This will to make the massage seems more common. As arch_get_ram_range use unsigned int for index, we also adjust the index in nodes_cover_memory from int to unsigned int. Signed-off-by: Wei Chen Reviewed-by: Jan Beulich --- v8 -> v9: 1. No change. v7 -> v8: 1. No change. v6 -> v7: 1. No change. v5 -> v6: 1. No change. v4 -> v5: 1. Add Rb. 2. Adjust the code comments. v3 -> v4: 1. Move function comment to header file. 2. Use bool for found, and add a new "err" for the return value of arch_get_ram_range. 3. Use -ENODATA instead of -EINVAL for non-RAM type ranges. v2 -> v3: 1. Rename arch_get_memory_map to arch_get_ram_range. 2. Use -ENOENT instead of -ENODEV to indicate end of memory map. 3. Add description to code comment that arch_get_ram_range returns RAM range in [start, end) format. v1 -> v2: 1. Use arch_get_memory_map to replace arch_get_memory_bank_range and arch_get_memory_bank_number. 2. Remove the !start || !end check, because caller guarantee these two pointers will not be NULL. --- xen/arch/x86/numa.c | 15 +++++++++++++++ xen/arch/x86/srat.c | 30 ++++++++++++++++++------------ xen/include/xen/numa.h | 13 +++++++++++++ 3 files changed, 46 insertions(+), 12 deletions(-) diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 90b2a22591..fa8caaa084 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -9,6 +9,7 @@ #include #include #include +#include #ifndef Dprintk #define Dprintk(x...) @@ -93,3 +94,17 @@ unsigned int __init arch_get_dma_bitsize(void) flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1) + PAGE_SHIFT, 32); } + +int __init arch_get_ram_range(unsigned int idx, paddr_t *start, paddr_t *end) +{ + if ( idx >= e820.nr_map ) + return -ENOENT; + + if ( e820.map[idx].type != E820_RAM ) + return -ENODATA; + + *start = e820.map[idx].addr; + *end = *start + e820.map[idx].size; + + return 0; +} diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index ce507dac9e..1a108a34c6 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -452,37 +452,43 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) Make sure the PXMs cover all memory. */ static int __init nodes_cover_memory(void) { - int i; + unsigned int i; - for (i = 0; i < e820.nr_map; i++) { - int j, found; + for (i = 0; ; i++) { + int err; + unsigned int j; + bool found; paddr_t start, end; - if (e820.map[i].type != E820_RAM) { - continue; - } + /* Try to loop memory map from index 0 to end to get RAM ranges. */ + err = arch_get_ram_range(i, &start, &end); - start = e820.map[i].addr; - end = e820.map[i].addr + e820.map[i].size; + /* Reached the end of the memory map? */ + if (err == -ENOENT) + break; + + /* Skip non-RAM entries. */ + if (err) + continue; do { - found = 0; + found = false; for_each_node_mask(j, memory_nodes_parsed) if (start < nodes[j].end && end > nodes[j].start) { if (start >= nodes[j].start) { start = nodes[j].end; - found = 1; + found = true; } if (end <= nodes[j].end) { end = nodes[j].start; - found = 1; + found = true; } } } while (found && start < end); if (start < end) { - printk(KERN_ERR "SRAT: No PXM for e820 range: " + printk(KERN_ERR "NUMA: No NODE for RAM range: " "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); return 0; } diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 04556f3a6f..9da0e7d555 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -80,6 +80,19 @@ static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) #define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ NODE_DATA(nid)->node_spanned_pages) +/* + * This function provides the ability for caller to get one RAM entry + * from architectural memory map by index. + * + * This function will return zero if it can return a proper RAM entry. + * Otherwise it will return -ENOENT for out of scope index, or other + * error codes, e.g. return -ENODATA for non-RAM type memory entry. + * + * Note: the range is exclusive at the end, e.g. [*start, *end). + */ +extern int arch_get_ram_range(unsigned int idx, + paddr_t *start, paddr_t *end); + #endif #endif /* _XEN_NUMA_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 10:45:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 10:45:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445562.700779 (Exim 4.92) (envelope-from ) id 1ovysR-0006MQ-Lp; Fri, 18 Nov 2022 10:45:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445562.700779; Fri, 18 Nov 2022 10:45:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovysR-0006Lq-HI; Fri, 18 Nov 2022 10:45:43 +0000 Received: by outflank-mailman (input) for mailman id 445562; Fri, 18 Nov 2022 10:45:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovysQ-0006Il-OS for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 10:45:42 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060d.outbound.protection.outlook.com [2a01:111:f400:7d00::60d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2519d8d8-672e-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 11:45:41 +0100 (CET) Received: from AS9PR05CA0005.eurprd05.prod.outlook.com (2603:10a6:20b:488::12) by GVXPR08MB7821.eurprd08.prod.outlook.com (2603:10a6:150:4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Fri, 18 Nov 2022 10:45:38 +0000 Received: from AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:488:cafe::84) by AS9PR05CA0005.outlook.office365.com (2603:10a6:20b:488::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Fri, 18 Nov 2022 10:45:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT006.mail.protection.outlook.com (100.127.141.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:45:38 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Fri, 18 Nov 2022 10:45:37 +0000 Received: from 74e5848c6914.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4DE39858-FB57-467E-9ABF-829731D5494E.1; Fri, 18 Nov 2022 10:45:30 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 74e5848c6914.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 10:45:30 +0000 Received: from FR3P281CA0136.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::9) by DB4PR08MB9312.eurprd08.prod.outlook.com (2603:10a6:10:3f4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Fri, 18 Nov 2022 10:45:28 +0000 Received: from VI1EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:95:cafe::eb) by FR3P281CA0136.outlook.office365.com (2603:10a6:d10:95::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Fri, 18 Nov 2022 10:45:28 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT015.mail.protection.outlook.com (100.127.144.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:45:27 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 18 Nov 2022 10:45:16 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Fri, 18 Nov 2022 10:45:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2519d8d8-672e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zPDBV9XWmcg+tmJ+qaggSEwwP7UYQrtfJrIfAn/ghm8=; b=gYpMeoi0cAV8S5MEdr2i0zEw2ONGil2iKvajFMMX8o1Ty9L7aWYU+GmCGKffP0cKd6+WL5dJHeIzZMeFYQi+zNWnYZWyj1JzIYxvuFuAtUJQqNen0X4H5hRhhSonVtCAEZ5DrBTooD5yl11aB9u6GPpMZQgH/zMFHE6ohhUYs1k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 761e9207070253d9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cbsOpHSk60d4zwAv4sREGs6gsp5u516P6BDfuTSrVbygwoDbpclj87i1aBYo8glKU3k8X6oL/Om8WPzel+Gg/3EQMmWk2VYoYQwmdKJwqziIyZ7VTnDX6qqpOmeJa1Wj1rsR0GUeGvSIZgrIMDOWMa+Tk8yFbZSOQLZLCuIo8wsJBhKB74kMaNYgjULIVvo8+llPoopnZFCvkTu/8euqHV0oVRs/QwiNF93YXZx4Qv7jMVHolsU/M2giwV6nrgFp5CCkx/1NXLxgaQb2Anr/2fRJFnfXiyL7zGb3oyb2sYk3XOpQ30pQjH9jQGbUIy20WSuuOeEWNyd6/Y3pMxOOmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zPDBV9XWmcg+tmJ+qaggSEwwP7UYQrtfJrIfAn/ghm8=; b=dtH4bsC2F7By9VmmRqd0p0GMNFDgpnWVGepIVGA2li+Bc8ZzpVko7YPH2B+Q2CSkZVB5NZe6zo3UREC/zEaxPMtjOTl3/2pQI1xDswYEZt8JtBtsPeYVCdhjJRXRHBGCUsg3jFDgKpq05zuLme+6TSicJqEn6cX6yT+rT2mppoBc1yuxXPWNOKy28A+3Qu0Xwkknx4rWrr7Pe1AssT+mvcF0LNRGO2izUyoVfQB+OsoIQe1iUKnYvRJvlFPaHw1lO4bWxMe3CpduTFzIS7Go5oF7mXeA9+TCu951OkyADoHFZ5bNay2mo8LpVtA7wYIEi59zlqB7LgDNSPraPxR2ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zPDBV9XWmcg+tmJ+qaggSEwwP7UYQrtfJrIfAn/ghm8=; b=gYpMeoi0cAV8S5MEdr2i0zEw2ONGil2iKvajFMMX8o1Ty9L7aWYU+GmCGKffP0cKd6+WL5dJHeIzZMeFYQi+zNWnYZWyj1JzIYxvuFuAtUJQqNen0X4H5hRhhSonVtCAEZ5DrBTooD5yl11aB9u6GPpMZQgH/zMFHE6ohhUYs1k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v9 1/6] xen/x86: Provide helpers for common code to access acpi_numa Date: Fri, 18 Nov 2022 18:45:03 +0800 Message-ID: <20221118104508.768274-2-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221118104508.768274-1-wei.chen@arm.com> References: <20221118104508.768274-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT015:EE_|DB4PR08MB9312:EE_|AM7EUR03FT006:EE_|GVXPR08MB7821:EE_ X-MS-Office365-Filtering-Correlation-Id: c1b50885-3619-4c03-a583-08dac95207c9 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XmcoCAlg8GIEFiR1CKMlavwkryiNGS0Sbm1nUTR2DFdM3czxnAusa5jdbOwjJ/c0lbk+P8bYCjDktfQEtkp6Y/E7WL7LnrcoPsWJnp31ccYJzGTcg6orVe0jzotnQxtrasMPYD1uBjozFIOw7IYG751le6HHp7RYcMRBcsuETOpflBuuzwgW3+wfwOiS1eAxs73wuNjAr4DYF7eyfkshZCdU1FtZGDrP5I2uYqYZyVx+gdUWhh1kdHI41fKnPVgRophDN70uIajivfaU+W9xhSyF6au/1k4pdLx3eRFT19ieS9exhVQQHdZpR/5VrLPePSA0WWoQ2VA8s+FvDvtj/z0clHdZ/BD4Na4pr9F771FR3V2SGX5zCjOI/WaVV7SEIdsdFOAV4d2qfyYjF7MadmmEKp5gwBgUD1mzTi/o0W0Oap26S1IIrQK+HKHm6haz35VcZCnElS8SKPYseSnH29NaZk33+77NsYqVjaYO7P90tX06MUqIEqx3BZk7OdRIMPU/GFtsagijXCFqFrpfj0BEICChFSVIHcRCCVRl/efpzSBMX/0bXl0HKT1fl7f/2k4h+bxDKWg4HllGwUuXYsuN0pZ9dtPxgX11kRnVJY1xa9uL30sLdbuz1jWSRwsjl9sXj2YE6Pu8gFEGQikcGVD7kzzVPaeObZKpgjI+FIKDLWzTKdzrpzIGAntPBU4L1NpgHQkgv63O0TlDwNveBwi8JZaB3lYW1M0VgFL6hrA= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39850400004)(136003)(396003)(376002)(346002)(451199015)(46966006)(40470700004)(36840700001)(36756003)(82740400003)(44832011)(356005)(81166007)(2906002)(36860700001)(426003)(83380400001)(47076005)(86362001)(41300700001)(40460700003)(70586007)(4326008)(26005)(8676002)(70206006)(186003)(316002)(6916009)(54906003)(336012)(40480700001)(8936002)(478600001)(5660300002)(7696005)(2616005)(6666004)(82310400005)(1076003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9312 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 48f56b80-f14d-4b6a-056a-08dac9520170 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KfZnQCnawTvhzOhrzFwCsYQDmX++EdtTuwnOrtC7kZXsxhyo6j5hrZxGMrunk9iVFydWO+Il7qIy79pT19nrCTesfD20E3b/GAkj+S/6eyXsG0Y9QWQvOhdVt+BKXtC1Jmxad0TL/r3+V/sLjEZOW0m1YVPZkzVJLifRYSrl7xpRzXGVxrZp43gBkXOWym2h0rN6ssQCpa0HRGuELRVsF/2W8/X8kUS3wSAT2bjz6GO7ecUz4tS/E6UrLIlz6QPRX/rWafLfnhII6Jk02D73e2/TtR35j5/cvQ9A54l9xw+UR2r4eurB2x54kXCuzfpNTWqeMEFZSoPoBicocf/Bu5JiUZMCX+vBN3N26xoqjpS2xXWgWVkE6TrssuAn4bduKqjRgjTZtJZqwzONJjdKAz6d77GoVlOB/nItU9T9aEpjZqOSPYza8VGYlN77xNUufvBkoy7gJajeMAedWHi1enNUKbIdMPvOLQM3IbRJG4acPscfRyXKmzDN+L6MctoRbh6YPjND1UCgLWKHGlHnYGigpel/TtXHA7Gb92X4Azr2fSBa9n3GlcKwH+T22Rr3H1vldxDU3Xj9zbMGNAhoDEgds0JgBBV9sSu+zTNA7+BYNDEhMsdYozUiix5dt12VcL6MPA9NrjBsbTUe5RNSb+8RTedu8/yhSrFJPJCyGDoCflfz/GSjwNHw/E+JdKil0S0Xi7s96Mbe9VQ0aWNkaw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199015)(46966006)(40470700004)(36840700001)(26005)(40480700001)(478600001)(6666004)(7696005)(6916009)(2616005)(86362001)(47076005)(54906003)(426003)(186003)(316002)(1076003)(336012)(82310400005)(2906002)(70586007)(82740400003)(36756003)(8936002)(36860700001)(81166007)(70206006)(83380400001)(5660300002)(41300700001)(4326008)(44832011)(40460700003)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 10:45:38.1034 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c1b50885-3619-4c03-a583-08dac95207c9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7821 acpi_numa is a specific NUMA switch for ACPI NUMA implementation. Other NUMA implementation may not need this switch. But this switch is not only used by ACPI code, it is also used directly in some general NUMA logic code. So far this hasn't caused any problem because Xen only has x86 implementing ACPI NUMA, but now Arm is implementing device tree based NUMA. Accesssing acpi_numa directly in some functions will be a block of reusing NUMA common code. It is also difficult for us to replace it with a new generic switch, because it is hard to prove that the new switch states can guarantee the original code will work correctly. So in this patch, we provide two helpers for common code to update and get states of acpi_numa. And other new NUMA implementations just need to provide the same helpers for common code. In this case, the generic NUMA logic code can be reused by all NUMA implementations. Signed-off-by: Wei Chen Reviewed-by: Jan Beulich --- v8 -> v9: 1. No change. v7 -> v8: 1. No change. v6 -> v7: 1. Add Rb. v5 -> v6: 1. Revert arch_numa_broken to arch_numa_disabled, as acpi_numa can be set to -1 by users. So acpi_numa < 0 does not mean a broken firmware. v4 -> v5: 1. Use arch_numa_broken instead of arch_numa_disabled for acpi_numa < 0 check. Because arch_numa_disabled might include acpi_numa < 0 (init failed) and acpi_numa == 0 (no data or data no init) cases. v3 -> v4: 1. Drop parameter from arch_numa_disabled, the parameter will be introduced in later patch where use it. 2. Drop unnecessary "else" from arch_numa_setup, and fix its indentation. v2 -> v3: 1. Drop enumeration of numa status. 2. Use helpers to get/update acpi_numa. 3. Insert spaces among parameters of strncmp in numa_setup. v1 -> v2: 1. Remove fw_numa. 2. Use enumeration to replace numa_off and acpi_numa. 3. Correct return value of srat_disabled. 4. Introduce numa_enabled_with_firmware. --- xen/arch/x86/include/asm/numa.h | 5 +++-- xen/arch/x86/numa.c | 38 ++++++++++++++++++++++----------- 2 files changed, 28 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index c32ccffde3..237f2c6dbf 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -32,8 +32,9 @@ extern void numa_add_cpu(int cpu); extern void numa_init_array(void); extern bool numa_off; - -extern int srat_disabled(void); +extern int arch_numa_setup(const char *opt); +extern bool arch_numa_disabled(void); +extern bool srat_disabled(void); extern void numa_set_node(int cpu, nodeid_t node); extern nodeid_t setup_node(unsigned int pxm); extern void srat_detect_node(int cpu); diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 322157fab7..1c3198445d 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -50,9 +50,28 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; bool numa_off; s8 acpi_numa = 0; -int srat_disabled(void) +int __init arch_numa_setup(const char *opt) { - return numa_off || acpi_numa < 0; +#ifdef CONFIG_ACPI_NUMA + if ( !strncmp(opt, "noacpi", 6) ) + { + numa_off = false; + acpi_numa = -1; + return 0; + } +#endif + + return -EINVAL; +} + +bool arch_numa_disabled(void) +{ + return acpi_numa < 0; +} + +bool srat_disabled(void) +{ + return numa_off || arch_numa_disabled(); } /* @@ -294,28 +313,21 @@ void numa_set_node(int cpu, nodeid_t node) /* [numa=off] */ static int __init cf_check numa_setup(const char *opt) { - if ( !strncmp(opt,"off",3) ) + if ( !strncmp(opt, "off", 3) ) numa_off = true; - else if ( !strncmp(opt,"on",2) ) + else if ( !strncmp(opt, "on", 2) ) numa_off = false; #ifdef CONFIG_NUMA_EMU else if ( !strncmp(opt, "fake=", 5) ) { numa_off = false; - numa_fake = simple_strtoul(opt+5,NULL,0); + numa_fake = simple_strtoul(opt + 5, NULL, 0); if ( numa_fake >= MAX_NUMNODES ) numa_fake = MAX_NUMNODES; } -#endif -#ifdef CONFIG_ACPI_NUMA - else if ( !strncmp(opt,"noacpi",6) ) - { - numa_off = false; - acpi_numa = -1; - } #endif else - return -EINVAL; + return arch_numa_setup(opt); return 0; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 10:45:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 10:45:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445565.700818 (Exim 4.92) (envelope-from ) id 1ovysa-0007Qm-Rb; Fri, 18 Nov 2022 10:45:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445565.700818; Fri, 18 Nov 2022 10:45:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovysa-0007Qd-O9; Fri, 18 Nov 2022 10:45:52 +0000 Received: by outflank-mailman (input) for mailman id 445565; Fri, 18 Nov 2022 10:45:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovysZ-0006R2-6s for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 10:45:51 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060c.outbound.protection.outlook.com [2a01:111:f400:7d00::60c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 25bd905d-672e-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 11:45:42 +0100 (CET) Received: from AS8PR04CA0183.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::8) by AS2PR08MB9545.eurprd08.prod.outlook.com (2603:10a6:20b:60e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Fri, 18 Nov 2022 10:45:45 +0000 Received: from AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f3:cafe::88) by AS8PR04CA0183.outlook.office365.com (2603:10a6:20b:2f3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 10:45:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT004.mail.protection.outlook.com (100.127.140.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:45:45 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Fri, 18 Nov 2022 10:45:45 +0000 Received: from 1aa20f94f073.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5FE67FEF-AEF8-4105-8EA3-FB23F0FCEF6D.1; Fri, 18 Nov 2022 10:45:38 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1aa20f94f073.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 10:45:38 +0000 Received: from AS9PR01CA0029.eurprd01.prod.exchangelabs.com (2603:10a6:20b:542::10) by AS8PR08MB8086.eurprd08.prod.outlook.com (2603:10a6:20b:54b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.5; Fri, 18 Nov 2022 10:45:37 +0000 Received: from AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:542:cafe::5f) by AS9PR01CA0029.outlook.office365.com (2603:10a6:20b:542::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 10:45:37 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT027.mail.protection.outlook.com (100.127.140.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:45:35 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 18 Nov 2022 10:45:34 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Fri, 18 Nov 2022 10:45:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25bd905d-672e-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a0uINGRHJ9MGqTaLt9vxK7vqJLpO9hspJ13faxPvkX8=; b=KZB+rO6qL2vIA1yK4i9ScdXQT4P62w8QE94PwLgPzJswBXwHpRGz5PXDdlZvRyo6RjvPp/rF31uRTl8XR7jzKHZG78FberPVJiSmVMd75U4jp9OQb/lQE5yDBFSZ948WSBIy9sM+7Z+KQrn7xvjuhfL5hj5GsWVrw8k2zT7GJJc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 538d1a37e0c8e672 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dNgfrgVlccsY/UpgCDbPW3Y24JX6qTRII3hJ/e+7uj1EPMgbSaVVxyQlhQ3fOjL/BeEJT62sciQjhG27AgI3OVHbd1jBUNHv/nbWly+wn9TxXxjwmaXP1xipZcYMPTF55xz3bwYeoh+y3z7hAwGaQsVhdubL4fEk8GlXbr+oojaMvpH4drS4u9zShnxVSAeD2TCvVmFRgbFdnthmGBQ2j7B9iPSPekDvBbGFmIN2Oe1jr1zwBjCv7s80IFcPtSUKU7ck3+fT47RQnl2USi1Ye+hYHaawo4vbcGjepaG/Ydu3L/RHn552AXH5mmp9UKnddnfbIfIljCpaWO5H2I7qaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a0uINGRHJ9MGqTaLt9vxK7vqJLpO9hspJ13faxPvkX8=; b=jVJEkBztxYU9iJEdvoeHKWzbQy75U8YOTAXkH2vAVq9ah1210U1vi/hXd76/7CgiNPWAJOJ6Zs3S64o6B3vu0NbMxdcLfLrK5yWDSsEz1VhgoVc99MwmL3TNicDcMsQK8CD7c17FhIjy4qdFQViI4NvJC/jHX9LJQyA2N8CYG73hLoQkVghEPjW+/eoFLbgb7AdP4t/gqqsu+nPllqqEsxl5dXdgCSwxM8EDvdyQvAEp3d1Rmr1Y4SoqCDmH+CKLXMOz9uQNJbEnPFTCQVZBZmD8TC0Ov15Pbbhvnfk5agfs7xhmmE0rlwKVQzVPuKIKtQ4GB1XwAE8Ci5zrE2fsZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a0uINGRHJ9MGqTaLt9vxK7vqJLpO9hspJ13faxPvkX8=; b=KZB+rO6qL2vIA1yK4i9ScdXQT4P62w8QE94PwLgPzJswBXwHpRGz5PXDdlZvRyo6RjvPp/rF31uRTl8XR7jzKHZG78FberPVJiSmVMd75U4jp9OQb/lQE5yDBFSZ948WSBIy9sM+7Z+KQrn7xvjuhfL5hj5GsWVrw8k2zT7GJJc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v9 6/6] xen: introduce a Kconfig option to configure NUMA nodes number Date: Fri, 18 Nov 2022 18:45:08 +0800 Message-ID: <20221118104508.768274-7-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221118104508.768274-1-wei.chen@arm.com> References: <20221118104508.768274-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT027:EE_|AS8PR08MB8086:EE_|AM7EUR03FT004:EE_|AS2PR08MB9545:EE_ X-MS-Office365-Filtering-Correlation-Id: db18db0f-67eb-4c59-61a5-08dac9520c3d x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eoNakGpJXW9D4YYAXEMwJW4+Afx624h/WS6ylokZrAnx0wQZea1PUiQkNJC5VA+bnnQbJywLxV59DQO74TaC3PWyACrmYxBF3164EFpuUomaRkQ5HEIX97zm71j0Og46U8u9ei9d3c68lnKgN3G4LDn9zBcsqAEsbUg1k6aNzk8vG3xs3REjKtOu3Zwa6iXCYENVjElHc6y5uangSyNk/uiqLVaZ1+RRhBpnqpk4DkmQSSSwLNy66oMmNhFlphIV0pVacuogUS1AVc0j3GP5pesngPUnJ7TFnu5ZUet/bQxeifOduiz/61wpLyUB7Sfw0FqNLBTFUfVbPsgkDNtWmayJ6f5q6qaG9v1vEowNdHngfiuKtYieGXFM7tRIpzAbRFCu4cWN5FHiGZsa8u+OMJMjZcbdmU7bYONK64FmbGKST6k+Zod8TkEGcBd9uPA9Qg1t5Jxw42L1F82n28Vof7twl3FxiwAxmJZr7DY5xjuuUw70kXYRpXeyzWGT0vliMXSwjiCVPU0oOsz+Iz4sCBKJ1LkUVXNo17R/pc05zcxSbKypKe/wTqCxdR4GudgjCYP7RBdEEkDe6MOVmnelzcxmd251GKHMciPfCdR74eOf9RDB8bwED3wwaxPgPZOxUCtlnX4weFLXqaKq+igNHcdUdJVZ/0OTmYE84zL5Lxfx5WuxmyIff/grDHBGbgHSEPsWyAS2+YWBcCfznxcpNF5HpVgJBfw1hHKVK2VCLtw= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199015)(46966006)(40470700004)(36840700001)(36860700001)(54906003)(8936002)(5660300002)(6916009)(86362001)(316002)(2906002)(81166007)(82740400003)(83380400001)(41300700001)(426003)(82310400005)(6666004)(7696005)(26005)(356005)(44832011)(70586007)(47076005)(4326008)(1076003)(478600001)(186003)(40480700001)(336012)(2616005)(70206006)(36756003)(40460700003)(8676002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8086 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f9fa8ad5-0fc8-48b8-e817-08dac9520672 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0w5jLCUy/XwmD2ILznR4gjFvUh9w6RdS7cHwpg4vq7IA1m1IqBaZ4QMECePn2pdj1OhJtGunJNgpGac+z6w9e7iEOnbh03nhe6fh+DMy952gQSeyV8Uzp20bXSAICcu5UZFD/ISKmAq90opNjY3haGSlYR8LDktabLytGdTgHaBKMPBz1RYg35SAhacu+MkkJcUYVYG6QHR96lXyyyj1AHlemZiF+YUJW205i3DS+or36LuVRMG+ozYjnjezSSHk7QKaZNiMR50zhdbyqye6ksv9OdnWIpdKL1IqdwcSVCOKs+/6348QH5MkPYjE6f/jggm2jWAlOTQPPZ2FP6hK+zAj08T98s2FQkbSntHh2uC/AdqlRkK8mrEEFPzfXRMDEohuh1PBdz0zgsCMFtn8gPcIQslqwCsr065Qct7Ae38xfnTFCl7fDsvGHeQa3ahSL/VWHORWjItIKVB0bB2j1BbVTCtUaxYzChaV2y5mRP47C2FK1cqIwtca0VknuW+ReP8AhUWkUioJoFv1xoXZW6puUVqTh+u1fW7o5a2Esk0xb/9rvJcH9GAvZpn7bL19vOCbUw0SU7H8IAsRte3SdDi6CgHLkG7eiTqZ9h9iRQWgzaDXhe4wlxO7qkoT5QjoWpVo4xtQUpbUnof8XjJxwd29rYq0n+fjdVVPLVfnMYDzvLwpX3pzV7aJZ30UBLrLY6oj54t3257W5x5YsZem/A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(136003)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(2906002)(8936002)(5660300002)(8676002)(44832011)(4326008)(70206006)(70586007)(41300700001)(40480700001)(6916009)(54906003)(36860700001)(6666004)(7696005)(107886003)(26005)(478600001)(86362001)(47076005)(81166007)(316002)(1076003)(336012)(2616005)(83380400001)(82310400005)(82740400003)(426003)(186003)(36756003)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 10:45:45.5728 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db18db0f-67eb-4c59-61a5-08dac9520c3d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9545 Currently the maximum number of NUMA nodes is a hardcoded value. This provides little flexibility unless changing the code. Introduce a new Kconfig option to change the maximum number of NUMA nodes conveniently. Also considering that not all architectures support NUMA, this Kconfig option is only visible on NUMA enabled architectures. Architectures not supporting NUMA still use 1 for MAX_NUMNODES. As NODES_SHIFT is currently unused, we're taking this opportunity to remove it. Signed-off-by: Wei Chen Acked-by: Jan Beulich --- v8 -> v9: 1. No change. v7 -> v8: 1. No change. v6 -> v7: 1. No change. v5 -> v6: 1. No change. v4 -> v5: 1. No change. v3 -> v4: 1. Update the commit log to follow Jan's suggestion. 2. Add Ack-by. v2 -> v3: 1. Fix indent. 2. Use 2-64 for node range. v1 -> v2: 1. Add NODES_SHIFT remove message in commit log 2. Change NR_NUMA_NODES upper bound from 4095 to 255. --- xen/arch/Kconfig | 11 +++++++++++ xen/arch/x86/include/asm/numa.h | 2 -- xen/include/xen/numa.h | 11 ++++++----- 3 files changed, 17 insertions(+), 7 deletions(-) diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig index f16eb0df43..7028f7b74f 100644 --- a/xen/arch/Kconfig +++ b/xen/arch/Kconfig @@ -17,3 +17,14 @@ config NR_CPUS For CPU cores which support Simultaneous Multi-Threading or similar technologies, this the number of logical threads which Xen will support. + +config NR_NUMA_NODES + int "Maximum number of NUMA nodes supported" + range 2 64 + default "64" + depends on NUMA + help + Controls the build-time size of various arrays and bitmaps + associated with multiple-nodes management. It is the upper bound of + the number of NUMA nodes that the scheduler, memory allocation and + other NUMA-aware components can handle. diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 2ca3475271..7866afa408 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -3,8 +3,6 @@ #include -#define NODES_SHIFT 6 - typedef u8 nodeid_t; extern int srat_rev; diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 04ecaf7769..71a5f837b3 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -3,14 +3,15 @@ #include -#ifndef NODES_SHIFT -#define NODES_SHIFT 0 -#endif - #define NUMA_NO_NODE 0xFF #define NUMA_NO_DISTANCE 0xFF -#define MAX_NUMNODES (1 << NODES_SHIFT) +#ifdef CONFIG_NR_NUMA_NODES +#define MAX_NUMNODES CONFIG_NR_NUMA_NODES +#else +#define MAX_NUMNODES 1 +#endif + #define NR_NODE_MEMBLKS (MAX_NUMNODES * 2) #define vcpu_to_node(v) (cpu_to_node((v)->processor)) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 10:45:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 10:45:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445566.700829 (Exim 4.92) (envelope-from ) id 1ovysc-0007il-5S; Fri, 18 Nov 2022 10:45:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445566.700829; Fri, 18 Nov 2022 10:45:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovysc-0007hf-0n; Fri, 18 Nov 2022 10:45:54 +0000 Received: by outflank-mailman (input) for mailman id 445566; Fri, 18 Nov 2022 10:45:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovysa-0006Il-9P for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 10:45:52 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0617.outbound.protection.outlook.com [2a01:111:f400:fe0c::617]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2a8cc51b-672e-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 11:45:50 +0100 (CET) Received: from DU2PR04CA0216.eurprd04.prod.outlook.com (2603:10a6:10:2b1::11) by DB9PR08MB6505.eurprd08.prod.outlook.com (2603:10a6:10:23e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 10:45:45 +0000 Received: from DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b1:cafe::2b) by DU2PR04CA0216.outlook.office365.com (2603:10a6:10:2b1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13 via Frontend Transport; Fri, 18 Nov 2022 10:45:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT023.mail.protection.outlook.com (100.127.142.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:45:44 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Fri, 18 Nov 2022 10:45:44 +0000 Received: from 165182cd3568.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 93DA0F33-148C-48EA-872E-E52E8153D64D.1; Fri, 18 Nov 2022 10:45:37 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 165182cd3568.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 10:45:37 +0000 Received: from AM6P194CA0036.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::49) by PAXPR08MB6557.eurprd08.prod.outlook.com (2603:10a6:102:de::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 10:45:34 +0000 Received: from AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:90:cafe::c5) by AM6P194CA0036.outlook.office365.com (2603:10a6:209:90::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 10:45:34 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT005.mail.protection.outlook.com (100.127.140.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:45:33 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 18 Nov 2022 10:45:31 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Fri, 18 Nov 2022 10:45:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a8cc51b-672e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6DCak0YJtenRHku7K8L/gHsRORPfDEtl/CMn+1huSvk=; b=bgTHYGxPBjA7swnttxbhY8ZXp+ah9uxm6N9OPetzcUld5IMfeUbY6svEzcWdhyXpoIe02Ndvx7R07sT9JOJTnRMnVGOLrozcWEwjDC46A9sNcEJBh1CPXAX0nNFdA4uJQ4gjfQn2lhQ+TB2wBFooikEHWy7Vevh2GuXvZeuvDCs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 53401273d3e89ba8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eJMtcncqWlnjHNUfw98IlHW8p/8VSDSJYEw5d4P/TOqTKCvxq2YLTDKPFhuOYsUTR2qEhfqG5erk5Ey+Wjtugen6Uv5MXtiEL5Dg/tnoU/s9lDMLc/nESngEYnxUY97Rk1nY/Cbi3Yq6aBL9fswx8KaluAeEidtVDM2ZjlTJtx3i9iPQSqO7Pr8cOWxHAwYdfVw15O2we5JfPBl9gemCD6uaJ3sQwFg8tzzQOptjiNtf6SM0B8x7B5nlozZgH9bxkKfTxo+fPsxXfa9FPYhn5qgOcOBtX69WZ2rSJurgPoqXoe4qleNhRwifIFz9NOG1KwbMrAWAMjUTjp3xknbZDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6DCak0YJtenRHku7K8L/gHsRORPfDEtl/CMn+1huSvk=; b=bGnS3q7cl7EHCcSUJXQRa8KLX82BChHPHMEMuFHcvMSuS/Lc5VuRujVfuNSH0Mc4FRAiZt8DbVB1t6MVvrWVDistZ6XhemYkdMxTvfnahEybt9IYtNKK58jmhNnTuYHy8SN9BNwfRsWOvUfdOUxJCTv1nYfYmgk8rDMrQZO7c2S0SROGmAEOQRTKxGW7nHII0h/R+M/swRxCWHC83aWmrbR3FhvK1BBODVa46BiU/zIRuWdyT5ZJ5644odaB8+V3HcQA3dot037wAnH5NboQjbWhiv4odE1iGOS9XsEcoCyU45M3lkBaqi10jsajVcBQ5amyXvNOYJpSo9dV2Cyy0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6DCak0YJtenRHku7K8L/gHsRORPfDEtl/CMn+1huSvk=; b=bgTHYGxPBjA7swnttxbhY8ZXp+ah9uxm6N9OPetzcUld5IMfeUbY6svEzcWdhyXpoIe02Ndvx7R07sT9JOJTnRMnVGOLrozcWEwjDC46A9sNcEJBh1CPXAX0nNFdA4uJQ4gjfQn2lhQ+TB2wBFooikEHWy7Vevh2GuXvZeuvDCs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v9 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common Date: Fri, 18 Nov 2022 18:45:07 +0800 Message-ID: <20221118104508.768274-6-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221118104508.768274-1-wei.chen@arm.com> References: <20221118104508.768274-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT005:EE_|PAXPR08MB6557:EE_|DBAEUR03FT023:EE_|DB9PR08MB6505:EE_ X-MS-Office365-Filtering-Correlation-Id: f9793fb4-c197-41ee-7f2a-08dac9520bc8 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mr6SKWk0souSxL2jv8fg2E25Rjq81WqI3m7uOMaDVZ5yVrUfL2eNfUigA2ci+8kiKlht7sUee2VoQ/D6M6ajJAwVMI2itGeHYQoA8ASgpzg9MzbrM/p9NpLiFaOXvrArSi6cD6MMtMp0ZD7xYwzM2Njcg/Uk+2JeaJekG3Y+vUED1/N6e11wJ0fonAuWZ3q6yezqSaukFf+dODMkN0fB0C/1ZSkhFYAdVdLY42maIJOVKtPkvIOJa9gd5wUWYUTBQydtdf4WTRMgzTfR/yXCUu7/4RyfbMIeQpZ3mDKkFnQHefKoDYmkLdj7mfyLYH6W17KwHif9IgfDiEgD2tQVLMszFHVzc+jK8MzZ62/UNFjW73AHtyOZtDlWsnO4AdR/xPwEQzOe5tV+PgIurkQEFUjr+97tscARPY7pChHpZx1C3pBonHCf4KzKUmCusX/hzOsIBz9vLB5B88psy28kPm9WCiALmU7k2HZ//KkwbBKgpVntlGNEPGa96EKxyILhRBGafUN9cnLYRRHqdM/Vw0UU7J7mEQ66tUAkALgGpV/ahSgc9juDAOVv90QS9UYRsTxVRLIeVWbcvwqeZp0jxnxSGTPfXTXW3pyUgQzIG4ZMJgMIr1lVsQ8lr/29tcTU2rw4Ll8qGhojRACc7ldBsOwuPKYtuN62DUBbjGVaemTK3SVM0RI2nAhVt9TBpF3rZcnNU1pgwwM9vlvLAf6NRBrWHUCrld9PJUrbcXrFH4A= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(136003)(376002)(451199015)(46966006)(40470700004)(36840700001)(86362001)(83380400001)(36860700001)(70586007)(356005)(82740400003)(81166007)(8936002)(40480700001)(2906002)(4326008)(41300700001)(40460700003)(82310400005)(6916009)(44832011)(26005)(30864003)(7696005)(70206006)(6666004)(186003)(336012)(36756003)(2616005)(8676002)(1076003)(316002)(426003)(54906003)(47076005)(478600001)(5660300002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6557 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1861b5e6-a87a-4d06-0abe-08dac9520512 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5JbfMcTpdGw41gTZ4KPba+Dc9DsWzHBMqDv19jb8cJGR9/PfqtiPQvNnI5/J1U15GSkPMTdhWEGhelCYCNWlKfnvjdm/UxcBQpTciUy+3hLhny19xeHp1kEIgFFaGh8KywV+N+PL7h4JGNfP6PzvyMqljvUlMx2qAxpE5hn1uZvYtvIzbb9eFj70YyJoZGKYnKnLLXTVcn0rB8C2TamyfCq9KzdHWWgttBRZpukwpKTrE64drLnYWFTQ4L1l97fKlwf7PTB3mbDm2RaXDYJRlTs+93dGMI7r3LFe4rpjJbKtlk2Sy2cxR7lHV0lWgL2FPHFv/BYEETmICTFbYgRXB0X35yemaPx7cFfSud4e877zq4Jz7o1cRznnobRtwsMUTYfsPwTxcuse3Z3Bf+R8R1zmUTC3VGJdN18AjrN/bUB1WavWKpW72XbmG5nkOI1oK5JQJClkUcmcGc0rB7p0NvA5GdzWbpj4z8wGWNioczi0TDHXQWjB3CfCsEx+YrZ5b/o2IZUzx0oFn3ubLeXy6ywklj1PP3Ypu1x7XmjuoM/5Jny6qMfs3gavMJ5onif5fyzcNKe9uKl8W3uW7hjTF/XTMWbiiIuaffIkvNIHOyVLY34FxFmhuNgAfaY4fMjvgZIsssj2TsfQ/zvkx17SUuv1O7VyNBgp5zpHMeeXVMPEXLIlpd0bCMcv536MCFHAPkDbZwMGRNBs2RlnGSOSwA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199015)(46966006)(36840700001)(40470700004)(40480700001)(82310400005)(36756003)(2616005)(186003)(336012)(1076003)(47076005)(54906003)(426003)(107886003)(83380400001)(26005)(7696005)(2906002)(86362001)(478600001)(6666004)(70206006)(6916009)(8676002)(5660300002)(70586007)(4326008)(36860700001)(30864003)(40460700003)(44832011)(82740400003)(316002)(8936002)(81166007)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 10:45:44.8380 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9793fb4-c197-41ee-7f2a-08dac9520bc8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6505 x86 has implemented a set of codes to process NUMA nodes. These codes will parse NUMA memory and processor information from ACPI SRAT table. But except some ACPI specific codes, most of the process code like memory blocks validation, node memory range updates and some sanity check can be reused by other NUMA implementation. So in this patch, we move some variables and related functions for NUMA memory and processor to common as library. At the same time, numa_set_processor_nodes_parsed has been introduced for ACPI specific code to update processor parsing results. With this helper, we can reuse most of NUMA memory affinity init code from ACPI. As bad_srat and node_to_pxm functions have been used in common code to do architectural fallback and node to architectural node info translation. But it doesn't make sense to reuse the functions names in common code, we have rename them to neutral names as well. PXM is an ACPI specific item, we can't use it in common code directly. So we introduced an numa_fw_nid_name for each NUMA implementation to set their specific firmware NUMA node name. In this case, we do not need to retain a lot of per-arch code but still can print architectural log messages for different NUMA implementations. A default value "???" will be set to indicate an unset numa_fw_nid_name. mem_hotplug is accessed by common code if memory hotplug is activated. Even if this is only supported by x86, export the variable so that other architectures could support it in the future. As asm/acpi.h has been removed from common/numa.c, we have to move NR_NODE_MEMBLKS from asm/acpi.h to xen/numa.h in this patch as well. Signed-off-by: Wei Chen --- v8 -> v9: 1. Remove incrrect description from commit log. 2. Add code comments for the places to set numa_fw_nid_name. v7 -> v8: 1. Add numa_fw_nid_name setting in srat_parse_regions after acpi_table_parse succeeded. v6 -> v7: 1. Add __init for arch_numa_unavailable. 2. Use __ro_after_init for mem_hotplug. 3. Use "???" instead of "NONAME" for unset numa_fw_nid_name. 4. Fix code-style. v5 -> v6: 1. Fix code-style. 2. Use arch_numa_unavailable to replace arch_numa_disabled for acpi_numa <= 0. 3. Remove Kconfig for HAS_NUMA_NODE_FWID. 4. Use numa_fw_nid_name for NUMA implementation to set their fw NUMA node name for print messages. v4 -> v5: 1. Introduce arch_numa_disabled for acpi_numa <= 0 in this patch. 2. Remove the paramter init_as_disable of arch_numa_disabled. 3. Fix typo "expandsion". 4. Add const to proper varibales. 5. Fix Indentation for l1tf_safe_maddr. 6. Remove double blank lines. 7. Add a space between for_each_node_mask and '('. Add a space page_list_for_each and '('. 8. Use bool for nodes_cover_memory return value. 9. Use a plain "int ret" to record compute_hash_shift return value. 10. Add a blank line before the function's main "return". 11. Add new Kconfig option HAS_NUMA_NODE_FWID to common/Kconfig. v3 -> v4: 1. Use bool as return value for functions that only return 0/1 or 0/-EINVAL. 2. Move mem_hotplug to a proper place in mm.h 3. Remove useless "size" in numa_scan_nodes. 4. Use unsigned int or const for proper variables. 5. Fix code-style. 6. Add init_as_disable as arch_numa_disabled parameter. 7. Add CONFIG_HAS_NUMA_NODE_FWID to gate print the mapping between node id and architectural node id (fw node id). v2 -> v3: 1. Add __ro_after_init to proper variables. 2. Rename bad_srat to numa_fw_bad. 3. Rename node_to_pxm to numa_node_to_arch_nid. 4. Merge patch#7 and #8 into this patch. 5. Correct int to unsigned int in proper places. 6. Move NR_NODE_MEMBLKS from x86/acpi.h to common/numa.h 7. Drop helpers to access mem_hotplug, we export mem_hotplug from x86/mm.c to common/page_alloc.c v1 -> v2: 1. Add code comment for numa_update_node_memblks to explain: Assumes all memory regions belonging to a single node are in one chunk. Holes between them will be included in the node. 2. Merge this single patch instead of serval patches to move x86 SRAT code to common. 3. Export node_to_pxm to keep pxm information in NUMA scan nodes error messages. 4. Change the code style to target file's Xen code-style. 5. Adjust some __init and __initdata for some functions and variables. 6. Merge two patches into this patch: 1. replace CONFIG_ACPI_NUMA by CONFIG_NUMA. 2. replace "SRAT" texts. 7. Turn numa_scan_nodes to static. --- xen/arch/x86/include/asm/acpi.h | 1 - xen/arch/x86/include/asm/mm.h | 2 - xen/arch/x86/include/asm/numa.h | 3 +- xen/arch/x86/mm.c | 2 - xen/arch/x86/numa.c | 5 + xen/arch/x86/srat.c | 337 +++---------------------------- xen/common/numa.c | 341 +++++++++++++++++++++++++++++++- xen/common/page_alloc.c | 2 + xen/include/xen/mm.h | 2 + xen/include/xen/numa.h | 10 +- 10 files changed, 386 insertions(+), 319 deletions(-) diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h index 5c2dd5da2d..c453450a74 100644 --- a/xen/arch/x86/include/asm/acpi.h +++ b/xen/arch/x86/include/asm/acpi.h @@ -102,7 +102,6 @@ extern unsigned long acpi_wakeup_address; #define ARCH_HAS_POWER_INIT 1 extern s8 acpi_numa; -#define NR_NODE_MEMBLKS (MAX_NUMNODES*2) extern struct acpi_sleep_info acpi_sinfo; #define acpi_video_flags bootsym(video_flags) diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h index d723c7c38f..2c5f856067 100644 --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -456,8 +456,6 @@ static inline int get_page_and_type(struct page_info *page, ASSERT(((_p)->count_info & PGC_count_mask) != 0); \ ASSERT(page_get_owner(_p) == (_d)) -extern paddr_t mem_hotplug; - /****************************************************************************** * With shadow pagetables, the different kinds of address start * to get get confusing. diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 6c87942d43..2ca3475271 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -10,6 +10,7 @@ typedef u8 nodeid_t; extern int srat_rev; extern nodeid_t pxm_to_node(unsigned int pxm); +extern unsigned int numa_node_to_arch_nid(nodeid_t n); #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) @@ -22,8 +23,6 @@ extern void init_cpu_to_node(void); #define arch_want_default_dmazone() (num_online_nodes() > 1) -extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); - void srat_parse_regions(paddr_t addr); extern u8 __node_distance(nodeid_t a, nodeid_t b); unsigned int arch_get_dma_bitsize(void); diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index db1817b691..68f9989e1f 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -157,8 +157,6 @@ l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) l1_fixmap_x[L1_PAGETABLE_ENTRIES]; -paddr_t __read_mostly mem_hotplug; - /* Frame table size in pages. */ unsigned long max_page; unsigned long total_pages; diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index fa8caaa084..4b0b297c7e 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -46,6 +46,11 @@ bool arch_numa_disabled(void) return acpi_numa < 0; } +bool __init arch_numa_unavailable(void) +{ + return acpi_numa <= 0; +} + /* * Setup early cpu_to_node. * diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index 1a108a34c6..56749ddca5 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -24,10 +24,6 @@ static struct acpi_table_slit *__read_mostly acpi_slit; -static nodemask_t memory_nodes_parsed __initdata; -static nodemask_t processor_nodes_parsed __initdata; -static struct node nodes[MAX_NUMNODES] __initdata; - struct pxm2node { unsigned pxm; nodeid_t node; @@ -35,19 +31,6 @@ struct pxm2node { static struct pxm2node __read_mostly pxm2node[MAX_NUMNODES] = { [0 ... MAX_NUMNODES - 1] = {.node = NUMA_NO_NODE} }; -static unsigned node_to_pxm(nodeid_t n); - -static int num_node_memblks; -static struct node node_memblk_range[NR_NODE_MEMBLKS]; -static nodeid_t memblk_nodeid[NR_NODE_MEMBLKS]; -static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS); - -enum conflicts { - NO_CONFLICT, - OVERLAP, - INTERLEAVE, -}; - static inline bool node_found(unsigned idx, unsigned pxm) { return ((pxm2node[idx].pxm == pxm) && @@ -110,78 +93,7 @@ nodeid_t setup_node(unsigned pxm) return node; } -int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node) -{ - int i; - - for (i = 0; i < num_node_memblks; i++) { - struct node *nd = &node_memblk_range[i]; - - if (nd->start <= start && nd->end >= end && - memblk_nodeid[i] == node) - return 1; - } - - return 0; -} - -static -enum conflicts __init conflicting_memblks(nodeid_t nid, paddr_t start, - paddr_t end, paddr_t nd_start, - paddr_t nd_end, unsigned int *mblkid) -{ - unsigned int i; - - /* - * Scan all recorded nodes' memory blocks to check conflicts: - * Overlap or interleave. - */ - for (i = 0; i < num_node_memblks; i++) { - struct node *nd = &node_memblk_range[i]; - - *mblkid = i; - - /* Skip 0 bytes node memory block. */ - if (nd->start == nd->end) - continue; - /* - * Use memblk range to check memblk overlaps, include the - * self-overlap case. As nd's range is non-empty, the special - * case "nd->end == end && nd->start == start" also can be covered. - */ - if (nd->end > start && nd->start < end) - return OVERLAP; - - /* - * Use node memory range to check whether new range contains - * memory from other nodes - interleave check. We just need - * to check full contains situation. Because overlaps have - * been checked above. - */ - if (nid != memblk_nodeid[i] && - nd->start >= nd_start && nd->end <= nd_end) - return INTERLEAVE; - } - - return NO_CONFLICT; -} - -static __init void cutoff_node(int i, paddr_t start, paddr_t end) -{ - struct node *nd = &nodes[i]; - if (nd->start < start) { - nd->start = start; - if (nd->end < nd->start) - nd->start = nd->end; - } - if (nd->end > end) { - nd->end = end; - if (nd->start > nd->end) - nd->start = nd->end; - } -} - -static __init void bad_srat(void) +void __init numa_fw_bad(void) { int i; printk(KERN_ERR "SRAT: SRAT not used.\n"); @@ -241,7 +153,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) if (numa_disabled()) return; if (pa->header.length < sizeof(struct acpi_srat_x2apic_cpu_affinity)) { - bad_srat(); + numa_fw_bad(); return; } if (!(pa->flags & ACPI_SRAT_CPU_ENABLED)) @@ -254,12 +166,12 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) pxm = pa->proximity_domain; node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_fw_bad(); return; } apicid_to_node[pa->apic_id] = node; - node_set(node, processor_nodes_parsed); + numa_set_processor_nodes_parsed(node); acpi_numa = 1; if (opt_acpi_verbose) @@ -277,7 +189,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) if (numa_disabled()) return; if (pa->header.length != sizeof(struct acpi_srat_cpu_affinity)) { - bad_srat(); + numa_fw_bad(); return; } if (!(pa->flags & ACPI_SRAT_CPU_ENABLED)) @@ -290,11 +202,11 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) } node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_fw_bad(); return; } apicid_to_node[pa->apic_id] = node; - node_set(node, processor_nodes_parsed); + numa_set_processor_nodes_parsed(node); acpi_numa = 1; if (opt_acpi_verbose) @@ -306,33 +218,27 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) void __init acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) { - struct node *nd; - paddr_t nd_start, nd_end; - paddr_t start, end; unsigned pxm; nodeid_t node; - unsigned int i; - bool next = false; if (numa_disabled()) return; if (ma->header.length != sizeof(struct acpi_srat_mem_affinity)) { - bad_srat(); + numa_fw_bad(); return; } if (!(ma->flags & ACPI_SRAT_MEM_ENABLED)) return; - start = ma->base_address; - end = start + ma->length; /* Supplement the heuristics in l1tf_calculations(). */ - l1tf_safe_maddr = max(l1tf_safe_maddr, ROUNDUP(end, PAGE_SIZE)); + l1tf_safe_maddr = max(l1tf_safe_maddr, + ROUNDUP(ma->base_address + ma->length, + PAGE_SIZE)); - if (num_node_memblks >= NR_NODE_MEMBLKS) - { + if (!numa_memblks_available()) { dprintk(XENLOG_WARNING, - "Too many numa entry, try bigger NR_NODE_MEMBLKS \n"); - bad_srat(); + "Too many numa entries, try bigger NR_NODE_MEMBLKS!\n"); + numa_fw_bad(); return; } @@ -341,159 +247,18 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) pxm &= 0xff; node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_fw_bad(); return; } /* - * For the node that already has some memory blocks, we will - * expand the node memory range temporarily to check memory - * interleaves with other nodes. We will not use this node - * temp memory range to check overlaps, because it will mask - * the overlaps in same node. - * - * Node with 0 bytes memory doesn't need this expandsion. + * In an extremely unlikely case, srat_parse_regions might not + * be called. So set the variable here just in case. */ - nd_start = start; - nd_end = end; - nd = &nodes[node]; - if (nd->start != nd->end) { - if (nd_start > nd->start) - nd_start = nd->start; - - if (nd_end < nd->end) - nd_end = nd->end; - } - - /* It is fine to add this area to the nodes data it will be used later*/ - switch (conflicting_memblks(node, start, end, nd_start, nd_end, &i)) { - case OVERLAP: - if (memblk_nodeid[i] == node) { - bool mismatch = !(ma->flags & - ACPI_SRAT_MEM_HOT_PLUGGABLE) != - !test_bit(i, memblk_hotplug); - - printk("%sSRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n", - mismatch ? KERN_ERR : KERN_WARNING, pxm, start, - end - 1, node_memblk_range[i].start, - node_memblk_range[i].end - 1); - if (mismatch) { - bad_srat(); - return; - } - break; - } - - printk(KERN_ERR - "SRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with PXM %u [%"PRIpaddr", %"PRIpaddr"]\n", - pxm, start, end - 1, node_to_pxm(memblk_nodeid[i]), - node_memblk_range[i].start, - node_memblk_range[i].end - 1); - bad_srat(); - return; - - case INTERLEAVE: - printk(KERN_ERR - "SRAT： PXM %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with PXM %u memblk [%"PRIpaddr", %"PRIpaddr"]\n", - pxm, nd_start, nd_end - 1, node_to_pxm(memblk_nodeid[i]), - node_memblk_range[i].start, node_memblk_range[i].end - 1); - bad_srat(); - return; - - case NO_CONFLICT: - break; - } - - if (!(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) { - node_set(node, memory_nodes_parsed); - nd->start = nd_start; - nd->end = nd_end; - } - - printk(KERN_INFO "SRAT: Node %u PXM %u [%"PRIpaddr", %"PRIpaddr"]%s\n", - node, pxm, start, end - 1, - ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); - - /* Keep node_memblk_range[] sorted by address. */ - for (i = 0; i < num_node_memblks; ++i) - if (node_memblk_range[i].start > start || - (node_memblk_range[i].start == start && - node_memblk_range[i].end > end)) - break; - - memmove(&node_memblk_range[i + 1], &node_memblk_range[i], - (num_node_memblks - i) * sizeof(*node_memblk_range)); - node_memblk_range[i].start = start; - node_memblk_range[i].end = end; - - memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i], - (num_node_memblks - i) * sizeof(*memblk_nodeid)); - memblk_nodeid[i] = node; - - if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) { - next = true; - if (end > mem_hotplug) - mem_hotplug = end; - } - for (; i <= num_node_memblks; ++i) { - bool prev = next; - - next = test_bit(i, memblk_hotplug); - if (prev) - __set_bit(i, memblk_hotplug); - else - __clear_bit(i, memblk_hotplug); - } - - num_node_memblks++; -} - -/* Sanity check to catch more bad SRATs (they are amazingly common). - Make sure the PXMs cover all memory. */ -static int __init nodes_cover_memory(void) -{ - unsigned int i; - - for (i = 0; ; i++) { - int err; - unsigned int j; - bool found; - paddr_t start, end; - - /* Try to loop memory map from index 0 to end to get RAM ranges. */ - err = arch_get_ram_range(i, &start, &end); - - /* Reached the end of the memory map? */ - if (err == -ENOENT) - break; - - /* Skip non-RAM entries. */ - if (err) - continue; - - do { - found = false; - for_each_node_mask(j, memory_nodes_parsed) - if (start < nodes[j].end - && end > nodes[j].start) { - if (start >= nodes[j].start) { - start = nodes[j].end; - found = true; - } - if (end <= nodes[j].end) { - end = nodes[j].start; - found = true; - } - } - } while (found && start < end); - - if (start < end) { - printk(KERN_ERR "NUMA: No NODE for RAM range: " - "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); - return 0; - } - } - return 1; + numa_fw_nid_name = "PXM"; + if (!numa_update_node_memblks(node, pxm, ma->base_address, ma->length, + ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) + numa_fw_bad(); } void __init acpi_numa_arch_fixup(void) {} @@ -534,6 +299,8 @@ void __init srat_parse_regions(paddr_t addr) acpi_table_parse(ACPI_SIG_SRAT, acpi_parse_srat)) return; + /* Set "PXM" as early as feasible. */ + numa_fw_nid_name = "PXM"; srat_region_mask = pdx_init_mask(addr); acpi_table_parse_srat(ACPI_SRAT_TYPE_MEMORY_AFFINITY, srat_parse_region, 0); @@ -549,59 +316,9 @@ void __init srat_parse_regions(paddr_t addr) pfn_pdx_hole_setup(mask >> PAGE_SHIFT); } -/* Use discovered information to actually set up the nodes. */ -int __init numa_process_nodes(paddr_t start, paddr_t end) -{ - int i; - nodemask_t all_nodes_parsed; - - /* First clean up the node list */ - for (i = 0; i < MAX_NUMNODES; i++) - cutoff_node(i, start, end); - - if (acpi_numa <= 0) - return -1; - - if (!nodes_cover_memory()) { - bad_srat(); - return -1; - } - - memnode_shift = compute_hash_shift(node_memblk_range, num_node_memblks, - memblk_nodeid); - - if (memnode_shift < 0) { - printk(KERN_ERR - "SRAT: No NUMA node hash function found. Contact maintainer\n"); - bad_srat(); - return -1; - } - - nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed); - - /* Finally register nodes */ - for_each_node_mask(i, all_nodes_parsed) - { - uint64_t size = nodes[i].end - nodes[i].start; - - if ( size == 0 ) - printk(KERN_INFO "SRAT: node %u has no memory\n", i); - - setup_node_bootmem(i, nodes[i].start, nodes[i].end); - } - for (i = 0; i < nr_cpu_ids; i++) { - if (cpu_to_node[i] == NUMA_NO_NODE) - continue; - if (!nodemask_test(cpu_to_node[i], &processor_nodes_parsed)) - numa_set_node(i, NUMA_NO_NODE); - } - numa_init_array(); - return 0; -} - -static unsigned node_to_pxm(nodeid_t n) +unsigned int numa_node_to_arch_nid(nodeid_t n) { - unsigned i; + unsigned int i; if ((n < ARRAY_SIZE(pxm2node)) && (pxm2node[n].node == n)) return pxm2node[n].pxm; @@ -618,8 +335,8 @@ u8 __node_distance(nodeid_t a, nodeid_t b) if (!acpi_slit) return a == b ? 10 : 20; - index = acpi_slit->locality_count * node_to_pxm(a); - slit_val = acpi_slit->entry[index + node_to_pxm(b)]; + index = acpi_slit->locality_count * numa_node_to_arch_nid(a); + slit_val = acpi_slit->entry[index + numa_node_to_arch_nid(b)]; /* ACPI defines 0xff as an unreachable node and 0-9 are undefined */ if ((slit_val == 0xff) || (slit_val <= 9)) diff --git a/xen/common/numa.c b/xen/common/numa.c index a135154c3e..4948b21fbe 100644 --- a/xen/common/numa.c +++ b/xen/common/numa.c @@ -13,6 +13,21 @@ #include #include +static nodemask_t __initdata processor_nodes_parsed; +static nodemask_t __initdata memory_nodes_parsed; +static struct node __initdata nodes[MAX_NUMNODES]; + +static unsigned int __ro_after_init num_node_memblks; +static struct node __ro_after_init node_memblk_range[NR_NODE_MEMBLKS]; +static nodeid_t __ro_after_init memblk_nodeid[NR_NODE_MEMBLKS]; +static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS); + +enum conflicts { + NO_CONFLICT, + OVERLAP, + INTERLEAVE, +}; + struct node_data __ro_after_init node_data[MAX_NUMNODES]; /* Mapping from pdx to node id */ @@ -31,11 +46,335 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; bool __ro_after_init numa_off; +const char *__ro_after_init numa_fw_nid_name = "???"; + bool numa_disabled(void) { return numa_off || arch_numa_disabled(); } +void __init numa_set_processor_nodes_parsed(nodeid_t node) +{ + node_set(node, processor_nodes_parsed); +} + +bool valid_numa_range(paddr_t start, paddr_t end, nodeid_t node) +{ + unsigned int i; + + for ( i = 0; i < num_node_memblks; i++ ) + { + const struct node *nd = &node_memblk_range[i]; + + if ( nd->start <= start && nd->end >= end && + memblk_nodeid[i] == node ) + return true; + } + + return false; +} + +static enum conflicts __init conflicting_memblks( + nodeid_t nid, paddr_t start, paddr_t end, paddr_t nd_start, + paddr_t nd_end, unsigned int *mblkid) +{ + unsigned int i; + + /* + * Scan all recorded nodes' memory blocks to check conflicts: + * Overlap or interleave. + */ + for ( i = 0; i < num_node_memblks; i++ ) + { + const struct node *nd = &node_memblk_range[i]; + + *mblkid = i; + + /* Skip 0 bytes node memory block. */ + if ( nd->start == nd->end ) + continue; + /* + * Use memblk range to check memblk overlaps, include the + * self-overlap case. As nd's range is non-empty, the special + * case "nd->end == end && nd->start == start" also can be covered. + */ + if ( nd->end > start && nd->start < end ) + return OVERLAP; + + /* + * Use node memory range to check whether new range contains + * memory from other nodes - interleave check. We just need + * to check full contains situation. Because overlaps have + * been checked above. + */ + if ( nid != memblk_nodeid[i] && + nd->start >= nd_start && nd->end <= nd_end ) + return INTERLEAVE; + } + + return NO_CONFLICT; +} + +static void __init cutoff_node(nodeid_t i, paddr_t start, paddr_t end) +{ + struct node *nd = &nodes[i]; + + if ( nd->start < start ) + { + nd->start = start; + if ( nd->end < nd->start ) + nd->start = nd->end; + } + + if ( nd->end > end ) + { + nd->end = end; + if ( nd->start > nd->end ) + nd->start = nd->end; + } +} + +bool __init numa_memblks_available(void) +{ + return num_node_memblks < NR_NODE_MEMBLKS; +} + +/* + * This function will be called by NUMA memory affinity initialization to + * update NUMA node's memory range. In this function, we assume all memory + * regions belonging to a single node are in one chunk. Holes (or MMIO + * ranges) between them will be included in the node. + * + * So in numa_update_node_memblks, if there are multiple banks for each + * node, start and end are stretched to cover the holes between them, and + * it works as long as memory banks of different NUMA nodes don't interleave. + */ +bool __init numa_update_node_memblks(nodeid_t node, unsigned int arch_nid, + paddr_t start, paddr_t size, bool hotplug) +{ + unsigned int i; + bool next = false; + paddr_t end = start + size; + paddr_t nd_start = start; + paddr_t nd_end = end; + struct node *nd = &nodes[node]; + + /* + * For the node that already has some memory blocks, we will + * expand the node memory range temporarily to check memory + * interleaves with other nodes. We will not use this node + * temp memory range to check overlaps, because it will mask + * the overlaps in same node. + * + * Node with 0 bytes memory doesn't need this expansion. + */ + if ( nd->start != nd->end ) + { + if ( nd_start > nd->start ) + nd_start = nd->start; + + if ( nd_end < nd->end ) + nd_end = nd->end; + } + + /* It is fine to add this area to the nodes data it will be used later */ + switch ( conflicting_memblks(node, start, end, nd_start, nd_end, &i) ) + { + case OVERLAP: + if ( memblk_nodeid[i] == node ) + { + bool mismatch = !hotplug != !test_bit(i, memblk_hotplug); + + printk("%sNUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n", + mismatch ? KERN_ERR : KERN_WARNING, numa_fw_nid_name, + arch_nid, start, end - 1, + node_memblk_range[i].start, node_memblk_range[i].end - 1); + if ( mismatch ) + return false; + break; + } + + printk(KERN_ERR + "NUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with %s %u [%"PRIpaddr", %"PRIpaddr"]\n", + numa_fw_nid_name, arch_nid, start, end - 1, numa_fw_nid_name, + numa_node_to_arch_nid(memblk_nodeid[i]), + node_memblk_range[i].start, node_memblk_range[i].end - 1); + return false; + + case INTERLEAVE: + printk(KERN_ERR + "NUMA： %s %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with %s %u memblk [%"PRIpaddr", %"PRIpaddr"]\n", + numa_fw_nid_name, arch_nid, nd_start, nd_end - 1, + numa_fw_nid_name, numa_node_to_arch_nid(memblk_nodeid[i]), + node_memblk_range[i].start, node_memblk_range[i].end - 1); + return false; + + case NO_CONFLICT: + break; + } + + if ( !hotplug ) + { + node_set(node, memory_nodes_parsed); + nd->start = nd_start; + nd->end = nd_end; + } + + printk(KERN_INFO "NUMA: Node %u %s %u [%"PRIpaddr", %"PRIpaddr"]%s\n", + node, numa_fw_nid_name, arch_nid, start, end - 1, + hotplug ? " (hotplug)" : ""); + + /* Keep node_memblk_range[] sorted by address. */ + for ( i = 0; i < num_node_memblks; ++i ) + if ( node_memblk_range[i].start > start || + (node_memblk_range[i].start == start && + node_memblk_range[i].end > end) ) + break; + + memmove(&node_memblk_range[i + 1], &node_memblk_range[i], + (num_node_memblks - i) * sizeof(*node_memblk_range)); + node_memblk_range[i].start = start; + node_memblk_range[i].end = end; + + memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i], + (num_node_memblks - i) * sizeof(*memblk_nodeid)); + memblk_nodeid[i] = node; + + if ( hotplug ) + { + next = true; + if ( end > mem_hotplug ) + mem_hotplug = end; + } + + for ( ; i <= num_node_memblks; ++i ) + { + bool prev = next; + + next = test_bit(i, memblk_hotplug); + if ( prev ) + __set_bit(i, memblk_hotplug); + else + __clear_bit(i, memblk_hotplug); + } + + num_node_memblks++; + + return true; +} + +/* + * Sanity check to catch more bad SRATs (they are amazingly common). + * Make sure the PXMs cover all memory. + */ +static bool __init nodes_cover_memory(void) +{ + unsigned int i; + + for ( i = 0; ; i++ ) + { + int err; + unsigned int j; + bool found; + paddr_t start, end; + + /* Try to loop memory map from index 0 to end to get RAM ranges. */ + err = arch_get_ram_range(i, &start, &end); + + /* Reached the end of the memory map? */ + if ( err == -ENOENT ) + break; + + /* Skip non-RAM entries. */ + if ( err ) + continue; + + do { + found = false; + for_each_node_mask ( j, memory_nodes_parsed ) + if ( start < nodes[j].end && end > nodes[j].start ) + { + if ( start >= nodes[j].start ) + { + start = nodes[j].end; + found = true; + } + + if ( end <= nodes[j].end ) + { + end = nodes[j].start; + found = true; + } + } + } while ( found && start < end ); + + if ( start < end ) + { + printk(KERN_ERR "NUMA: No node for RAM range: " + "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); + return false; + } + } + + return true; +} + +/* Use discovered information to actually set up the nodes. */ +static bool __init numa_process_nodes(paddr_t start, paddr_t end) +{ + int ret; + unsigned int i; + nodemask_t all_nodes_parsed; + + /* First clean up the node list */ + for ( i = 0; i < MAX_NUMNODES; i++ ) + cutoff_node(i, start, end); + + /* When numa is on and has data, we can start to process numa nodes. */ + if ( arch_numa_unavailable() ) + return false; + + if ( !nodes_cover_memory() ) + { + numa_fw_bad(); + return false; + } + + ret = compute_hash_shift(node_memblk_range, num_node_memblks, + memblk_nodeid); + if ( ret < 0 ) + { + printk(KERN_ERR + "NUMA: No NUMA node hash function found. Contact maintainer\n"); + numa_fw_bad(); + return false; + } + memnode_shift = ret; + + nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed); + + /* Finally register nodes */ + for_each_node_mask ( i, all_nodes_parsed ) + { + if ( nodes[i].end == nodes[i].start ) + printk(KERN_INFO "NUMA: node %u has no memory\n", i); + + setup_node_bootmem(i, nodes[i].start, nodes[i].end); + } + + for ( i = 0; i < nr_cpu_ids; i++ ) + { + if ( cpu_to_node[i] == NUMA_NO_NODE ) + continue; + if ( !nodemask_test(cpu_to_node[i], &processor_nodes_parsed) ) + numa_set_node(i, NUMA_NO_NODE); + } + + numa_init_array(); + + return true; +} + /* * Given a shift value, try to populate memnodemap[] * Returns : @@ -261,7 +600,7 @@ void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) #endif #ifdef CONFIG_NUMA - if ( !numa_off && !numa_process_nodes(start, end) ) + if ( !numa_off && numa_process_nodes(start, end) ) return; #endif diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 62afb07bc6..07df36d475 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -159,6 +159,8 @@ #define PGT_TYPE_INFO_INITIALIZER 0 #endif +paddr_t __ro_after_init mem_hotplug; + /* * Comma-separated list of hexadecimal page numbers containing bad bytes. * e.g. 'badpage=0x3f45,0x8a321'. diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index a925028ab3..9d14aed74b 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -147,6 +147,8 @@ int assign_page( /* Dump info to serial console */ void arch_dump_shared_mem_info(void); +extern paddr_t mem_hotplug; + /* * Extra fault info types which are used to further describe * the source of an access violation. diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 9da0e7d555..04ecaf7769 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -11,6 +11,7 @@ #define NUMA_NO_DISTANCE 0xFF #define MAX_NUMNODES (1 << NODES_SHIFT) +#define NR_NODE_MEMBLKS (MAX_NUMNODES * 2) #define vcpu_to_node(v) (cpu_to_node((v)->processor)) @@ -36,14 +37,16 @@ extern int compute_hash_shift(const struct node *nodes, unsigned int numnodes, const nodeid_t *nodeids); extern bool numa_off; +extern const char *numa_fw_nid_name; extern void numa_add_cpu(unsigned int cpu); extern void numa_init_array(void); extern void numa_set_node(unsigned int cpu, nodeid_t node); extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); -extern int numa_process_nodes(paddr_t start, paddr_t end); +extern void numa_fw_bad(void); extern int arch_numa_setup(const char *opt); +extern bool arch_numa_unavailable(void); extern bool arch_numa_disabled(void); extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); @@ -92,6 +95,11 @@ static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) */ extern int arch_get_ram_range(unsigned int idx, paddr_t *start, paddr_t *end); +extern bool valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); +extern bool numa_memblks_available(void); +extern bool numa_update_node_memblks(nodeid_t node, unsigned int arch_nid, + paddr_t start, paddr_t size, bool hotplug); +extern void numa_set_processor_nodes_parsed(nodeid_t node); #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 10:45:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 10:45:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445568.700840 (Exim 4.92) (envelope-from ) id 1ovysh-0008BN-LT; Fri, 18 Nov 2022 10:45:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445568.700840; Fri, 18 Nov 2022 10:45:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovysh-0008B5-Gr; Fri, 18 Nov 2022 10:45:59 +0000 Received: by outflank-mailman (input) for mailman id 445568; Fri, 18 Nov 2022 10:45:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovysf-0006R2-H0 for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 10:45:58 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20602.outbound.protection.outlook.com [2a01:111:f400:7e1a::602]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 28845b50-672e-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 11:45:46 +0100 (CET) Received: from AM6P191CA0034.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::47) by AM9PR08MB6164.eurprd08.prod.outlook.com (2603:10a6:20b:287::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.8; Fri, 18 Nov 2022 10:45:49 +0000 Received: from AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8b:cafe::89) by AM6P191CA0034.outlook.office365.com (2603:10a6:209:8b::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 10:45:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT041.mail.protection.outlook.com (100.127.140.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:45:49 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Fri, 18 Nov 2022 10:45:48 +0000 Received: from a36fd8b09b5b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 78C014BE-4453-40A7-974F-8BAE98B7C0D3.1; Fri, 18 Nov 2022 10:45:41 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a36fd8b09b5b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 10:45:41 +0000 Received: from FR3P281CA0146.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::18) by AM8PR08MB6449.eurprd08.prod.outlook.com (2603:10a6:20b:364::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8; Fri, 18 Nov 2022 10:45:30 +0000 Received: from VI1EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:95:cafe::a5) by FR3P281CA0146.outlook.office365.com (2603:10a6:d10:95::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18 via Frontend Transport; Fri, 18 Nov 2022 10:45:30 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT015.mail.protection.outlook.com (100.127.144.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 10:45:30 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 18 Nov 2022 10:45:20 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Fri, 18 Nov 2022 10:45:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28845b50-672e-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TvHCs77zTKjeJCRttCK5jTM1WRW48h5RjGDiyWGaZqM=; b=D8WHmA9BcFu+Tlt5sILvC2wDqGxDUrNfNr6b+Dy+z2WckjKsyZlTzaZK6arz3PjGlz6mvWF1FNerc63VShxOpBWdq3zykzDJ8+MoQRb7kal+TD/6IZgh5qWf3jiB/aC/APlOdVMdBN/E+EgyKEhX03RVpjVysyOwyVbsm4Dtl2Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 55a5b162c61f6222 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=inHTS0E1ROt4ix3wImrljxvDQpsHWO4cugzuKHxm8ABjL9roXhcpua5FtsoJ9508BCa8wIkSLLzRAj93rS2C4SiWqM6DMi8LTTQewEdvrMARXwkfS17UwtQsdQ+UmL6N9mwDW1tDkR7CIYNEh19IlWQbALRKWXpqhay8u8IQUWhpphdqSTSW8W8HwEasii+vFXGOXqHLyc8zKaeAbBkje8ct8BsKLfuVpNnb1wbLIFMdl0JF2+wXjOn+pzMTWpXSL26v0qDCR7rc13rL3MrbIPwDbEbaeT8hthXQlgLVmAvA9G7llj5iFI/qKU6a4VBgagHogidla6ZdefrzBO7SDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TvHCs77zTKjeJCRttCK5jTM1WRW48h5RjGDiyWGaZqM=; b=LQJ4YBSqnsDU8HCg/lVfQwF2axAd9F9s+FXL1mUBb3ypbmICKR4P03eOx13uwTRUSzXZJQexoZTm8+zleKni6GFKhALf2jTG47ZE/Yk6TugN9oAQKt2eaM3FO6gluTHxdXF9qd3aq2/Ljd95gsDCqN5GYh8BImGr/5/ffEeusuL0dW3eLx79LvEG39yfqhnEMXEGoK0tlV/axjxf+KpBYXl4jHQqN9ZYJm6ASjQBfyCkHRod7g0X7s93IpfjSr4gWC/0QyCbdVPjyTyYk5Yq9Rscj2oPDGK8GYm95p/rSJqOlFuK176sAswvic6h3VqDUOk5qkiuah1drNjJDx/FMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TvHCs77zTKjeJCRttCK5jTM1WRW48h5RjGDiyWGaZqM=; b=D8WHmA9BcFu+Tlt5sILvC2wDqGxDUrNfNr6b+Dy+z2WckjKsyZlTzaZK6arz3PjGlz6mvWF1FNerc63VShxOpBWdq3zykzDJ8+MoQRb7kal+TD/6IZgh5qWf3jiB/aC/APlOdVMdBN/E+EgyKEhX03RVpjVysyOwyVbsm4Dtl2Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v9 2/6] xen/x86: move generically usable NUMA code from x86 to common Date: Fri, 18 Nov 2022 18:45:04 +0800 Message-ID: <20221118104508.768274-3-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221118104508.768274-1-wei.chen@arm.com> References: <20221118104508.768274-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT015:EE_|AM8PR08MB6449:EE_|AM7EUR03FT041:EE_|AM9PR08MB6164:EE_ X-MS-Office365-Filtering-Correlation-Id: 3472fa8b-54ee-4ec2-2a04-08dac9520e5c x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: orCV2S6pIt1+SlDo1gxet6kHJGCoMfSflOGKJS/M9b6wVqL9wYTOeKDQOiXzaA3pQES9++Vho5zMh2q5gH/DUJgM26yHHTdgQSU0Lfmv6kP+lzorVMo27C4DI+4696OjnSkqnJG6w6Ruv5TMZRpbhddpvjnzo+NrSDxBn3FNb4nYxMBHoETnXsl9NPTSi0pxNMT1B6Sy4NbgEXX20QCCNcKYG1J0RGpUOah1mAIHo2N6KN1XFlfcY2MmLn6IdpSqIgBsKb8loHk5p2ruBnQa/k5gK8CbWYWRW8t7URbgwVgrSNv1vTrECXYglbH9KHhXWFHyZFcdkDbIZAU4ZAkL0cm4na6ECUdTM05WqJlGXv0DbfM+qPbdJ8w6GVk0damTmpmp4Smp6SVHUhFi37Rc5Fr8Ed0eQ7cy6lLfm/NAdEJg+F20s+n2ipbVw5MTo1abFytF3XXdG3iYR4Vol0F+RJfe3g6s25pGvqF5N+CuIqQPwSD39aAE6daU3tx9CSKSOwS8fR2cI1vABXjiJzvKmYnK3SogP3+02TnsZL+RnhxydhH2Yf5uDiLQ2Ur+0GJuyaha5ENj0it9yJcCAdXHqg/sqwlyFJkFr14kbOMXD6KueXHeVFAjeBQC4NCVpNH1kkSfTJXvFdFxNjodLJbEKSJ3HwAHjRSBhAMIysp7PDn5m21jeiSpxh31Bv8i1t68/YP89iIAP8MV2Wj4+3cQFx51QSUDGMTV8gjCLZJnQbpTrMnZRu1mOVM8V+ogv78S X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(376002)(396003)(451199015)(40470700004)(46966006)(36840700001)(40460700003)(36756003)(2616005)(81166007)(6916009)(356005)(316002)(54906003)(40480700001)(6666004)(41300700001)(7696005)(82310400005)(26005)(70206006)(8676002)(4326008)(426003)(86362001)(70586007)(47076005)(83380400001)(2906002)(30864003)(186003)(5660300002)(44832011)(336012)(82740400003)(8936002)(1076003)(36860700001)(478600001)(21314003)(36900700001)(579004);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6449 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 05dc9b1d-d8f2-4f75-c127-08dac952031a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2GcICMKnxLqeI47rCADDgF+OSuBJ9J2RNaS4ogZ5Uwh5HbMRP+6KtBIlHVFF/VgvSXJwWESK47EBpsQHcxH+sqHUwDLjHiOPE6X+MyvwQYsQ27FZQfoKOk/YApzkI1bwe7OqH0L5UuHH0c3UfgCI8g1W7/tx6FLw1LnC5+Z/DEkdSieXnurBtCOZlYI2hal+4nJyYBCLtOxy55cGBH8vfoMrFspglctDYOcV3Gn81bS9m8aAyq7/3Q6GP6M6IiTdWG2TbCxaIC47FD+75fhaXCtsbDnpPXATbPh7n4cIe/+uoPZrQ9uIH7V75W+xJy7L8hI3cqkhulEm67J3ZfL8R0A8Q8bCJS0SWzd/Cm+iriE0sjGk7YMdXRzGO/A71I84sdW3BgMjpHCNhmFLQ1ePjYonWeUxIWvG53EnrH0ei3gs2wU+A8adQlXVR04dAwCxduZV4K1LZp0K+Nft4Hk7gY+8fIP1dGhO5sUVFauh91aveNbHdV8otAX8a6T3H3CfQ0LX0NKPXLdJzV1e3ubBn7IiAW7dp2Q00A0nCCMHNSvosXNf7Z4b3Dlf41R928twzA0j5Zr12AIGs7BHwardORP+k7er+k06YeDv9+5165eeF1DaCmFfttSXVf36C8KRyzVZ4WxmKHK994iH1eaulK0eM8GtPpLn3Mx63Ax7Se/8JSb+88yKN1NoroJvXVbY9pzXK+53vO6R4x4n0g658YWcr9yw0rvm/xLr4CWg37DCrKt9Xy7SU9+9+YoeHrJA+1+p3lW8N6AIjQbijcAq9g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199015)(40470700004)(46966006)(36840700001)(8936002)(44832011)(30864003)(5660300002)(4326008)(8676002)(70586007)(41300700001)(54906003)(70206006)(316002)(6916009)(26005)(2906002)(478600001)(36756003)(186003)(1076003)(2616005)(47076005)(6666004)(7696005)(336012)(426003)(107886003)(36860700001)(82310400005)(40480700001)(40460700003)(83380400001)(81166007)(82740400003)(86362001)(21314003)(579004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 10:45:49.0987 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3472fa8b-54ee-4ec2-2a04-08dac9520e5c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6164 There are some codes in x86/numa.c can be shared by common architectures to implememnt NUMA support. Just like some variables and functions to check and store NUMA memory map. And some variables and functions to do NUMA initialization. In this patch, we move them to common/numa.c and xen/numa.h and use the CONFIG_NUMA to gate them for non-NUMA supported architectures. As the target header file is Xen-style, so we trim some spaces and replace tabs for the codes that has been moved to xen/numa.h at the same time. As acpi_scan_nodes has been used in a common function, it doesn't make sense to use acpi_xxx in common code, so we rename it to numa_process_nodes in this patch too. After that if we still use CONFIG_ACPI_NUMA in to gate numa_process_nodes in numa_initmem_init, that doesn't make sense. As CONFIG_NUMA will be selected by CONFIG_ACPI_NUMA for x86. So, we replace CONFIG_ACPI_NUMA by CONFIG_NUMA to gate numa_process_nodes. As arch_numa_disabled has been implememnted for ACPI NUMA, we can rename srat_disabled to numa_disabled and move it to common code as well. The macro node_to_first_cpu(node) hasn't been used anywhere, so we drop it in this patch too. Because some architectures allow to use all 64 physical address bits, but some architectures are not (like Arm64 allows 52, 48 bits). In this case, we use min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift when only one node is in the system in this patch too. Signed-off-by: Wei Chen Reviewed-by: Jan Beulich --- v8 -> v9: 1. No change. v7 -> v8: 1. Add Rb. 2. Change "of shift too small" to "or shift too small". v6 -> v7: 1. Restore %d for nodeid_t in dump_numa. 2. Use sizeof(page_num_node) for page_num_node size in memset. 3. Add description for using min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift when only one node is in the system. 4. Use %pd for domain print. v5 -> v6: 1. Replace numa_scan_node to numa_process_nodes in commit log. 2. Limit the scope of page_num_node, vnuma and page of numa_setup function. 3. Use memset to init page_num_node instead of for_each_online_node. 4. Use %u instead of %d for nodeid_t and j in numa_setup print messages. 5. Use min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift when only one node is in the system. 6. Drop the marco: node_to_first_cpu(node) v4 -> v5: 1. Use nodeid_t instead of uint8_t for memnodemap. 2. Restore to use typeof(*memnodemap) for _memnodemap, this will avoid the further adjustments for _memnodemap's type. 3. Use __ro_after_init for numa_off. 4. Use pointer-to-const for proper function parameters. 5. Use unsigned int for variables that are not realy used for node ID. 6. Fix code comments code-style and adjust the length. 7. Fix code-styles. 8. Rename numa_scan_nodes to numa_process_nodes. 9. Use a plain "int ret" to record compute_hash_shift return value. v3 -> v4: 1. Restore compute_hash_shift's return value to int. 2. Remove unnecessary parentheses for macros. 3. Use unsigned int for proper variables. 4. Fix some code-style. v2 -> v3: 1. Remove acpi.h from common/numa.c. 2. Rename acpi_scan_nodes to numa_scan_nodes. 3. Replace u8 by uint8_t for memnodemap. 4. Use unsigned int for memnode_shift and adjust related functions (compute_hash_shift, populate_memnodemap) to use correct types for return values or parameters. 5. Use nodeid_t for nodeid and node numbers. 6. Use __read_mostly and __ro_after_init for appropriate variables. 7. Adjust the __read_mostly and __initdata location for some variables. 8. convert from plain int to unsigned for cpuid and other proper variables. 9. Use __attribute_pure__ instead of __attribute__((pure)). 10. Replace CONFIG_ACPI_NUMA by CONFIG_NUMA in numa_initmem_init. 11. Add const for some functions' parameters. 12. Move srat_disabled to common code with new name numa_disabled. 13. Fix some spaces code-style for numa_emulation. 14. Change from int to unsigned int for numa_fake. v1 -> v2: 1. New patch in v2. --- xen/arch/x86/include/asm/acpi.h | 1 - xen/arch/x86/include/asm/numa.h | 57 +--- xen/arch/x86/include/asm/setup.h | 1 - xen/arch/x86/numa.c | 433 +--------------------------- xen/arch/x86/smpboot.c | 2 +- xen/arch/x86/srat.c | 10 +- xen/common/Makefile | 1 + xen/common/numa.c | 464 +++++++++++++++++++++++++++++++ xen/include/xen/numa.h | 66 +++++ 9 files changed, 539 insertions(+), 496 deletions(-) create mode 100644 xen/common/numa.c diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h index 9a9cc4c240..5c2dd5da2d 100644 --- a/xen/arch/x86/include/asm/acpi.h +++ b/xen/arch/x86/include/asm/acpi.h @@ -102,7 +102,6 @@ extern unsigned long acpi_wakeup_address; #define ARCH_HAS_POWER_INIT 1 extern s8 acpi_numa; -extern int acpi_scan_nodes(u64 start, u64 end); #define NR_NODE_MEMBLKS (MAX_NUMNODES*2) extern struct acpi_sleep_info acpi_sinfo; diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 237f2c6dbf..6c87942d43 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -9,72 +9,17 @@ typedef u8 nodeid_t; extern int srat_rev; -extern nodeid_t cpu_to_node[NR_CPUS]; -extern cpumask_t node_to_cpumask[]; - -#define cpu_to_node(cpu) (cpu_to_node[cpu]) -#define parent_node(node) (node) -#define node_to_first_cpu(node) (__ffs(node_to_cpumask[node])) -#define node_to_cpumask(node) (node_to_cpumask[node]) - -struct node { - paddr_t start, end; -}; - -extern int compute_hash_shift(struct node *nodes, int numnodes, - nodeid_t *nodeids); extern nodeid_t pxm_to_node(unsigned int pxm); #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) -#define VIRTUAL_BUG_ON(x) -extern void numa_add_cpu(int cpu); -extern void numa_init_array(void); -extern bool numa_off; - -extern int arch_numa_setup(const char *opt); -extern bool arch_numa_disabled(void); -extern bool srat_disabled(void); -extern void numa_set_node(int cpu, nodeid_t node); +extern bool numa_disabled(void); extern nodeid_t setup_node(unsigned int pxm); extern void srat_detect_node(int cpu); -extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); extern nodeid_t apicid_to_node[]; extern void init_cpu_to_node(void); -static inline void clear_node_cpumask(int cpu) -{ - cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); -} - -/* Simple perfect hash to map pdx to node numbers */ -extern int memnode_shift; -extern unsigned long memnodemapsize; -extern u8 *memnodemap; - -struct node_data { - unsigned long node_start_pfn; - unsigned long node_spanned_pages; -}; - -extern struct node_data node_data[]; - -static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) -{ - nodeid_t nid; - VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); - nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; - VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); - return nid; -} - -#define NODE_DATA(nid) (&(node_data[nid])) - -#define node_start_pfn(nid) (NODE_DATA(nid)->node_start_pfn) -#define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages) -#define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ - NODE_DATA(nid)->node_spanned_pages) #define arch_want_default_dmazone() (num_online_nodes() > 1) extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 21037b7f31..ae470ea12f 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -20,7 +20,6 @@ void early_time_init(void); void set_nr_cpu_ids(unsigned int max_cpus); -void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); void arch_init_memory(void); void subarch_init_memory(void); diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 1c3198445d..90b2a22591 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -4,20 +4,11 @@ * Adapted for Xen: Ryan Harper */ -#include -#include #include -#include +#include #include #include -#include -#include -#include -#include -#include #include -#include -#include #ifndef Dprintk #define Dprintk(x...) @@ -26,28 +17,13 @@ /* from proto.h */ #define round_up(x,y) ((((x)+(y))-1) & (~((y)-1))) -struct node_data node_data[MAX_NUMNODES]; - -/* Mapping from pdx to node id */ -int memnode_shift; -static typeof(*memnodemap) _memnodemap[64]; -unsigned long memnodemapsize; -u8 *memnodemap; - -nodeid_t cpu_to_node[NR_CPUS] __read_mostly = { - [0 ... NR_CPUS-1] = NUMA_NO_NODE -}; /* * Keep BIOS's CPU2node information, should not be used for memory allocaion */ nodeid_t apicid_to_node[MAX_LOCAL_APIC] = { [0 ... MAX_LOCAL_APIC-1] = NUMA_NO_NODE }; -cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly; -nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; - -bool numa_off; s8 acpi_numa = 0; int __init arch_numa_setup(const char *opt) @@ -69,270 +45,6 @@ bool arch_numa_disabled(void) return acpi_numa < 0; } -bool srat_disabled(void) -{ - return numa_off || arch_numa_disabled(); -} - -/* - * Given a shift value, try to populate memnodemap[] - * Returns : - * 1 if OK - * 0 if memnodmap[] too small (of shift too small) - * -1 if node overlap or lost ram (shift too big) - */ -static int __init populate_memnodemap(const struct node *nodes, - int numnodes, int shift, nodeid_t *nodeids) -{ - int i, res = -1; - - memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap)); - for ( i = 0; i < numnodes; i++ ) - { - unsigned long spdx = paddr_to_pdx(nodes[i].start); - unsigned long epdx = paddr_to_pdx(nodes[i].end - 1); - - if ( spdx > epdx ) - continue; - if ( (epdx >> shift) >= memnodemapsize ) - return 0; - do { - if ( memnodemap[spdx >> shift] != NUMA_NO_NODE && - (!nodeids || memnodemap[spdx >> shift] != nodeids[i]) ) - return -1; - - if ( !nodeids ) - memnodemap[spdx >> shift] = i; - else - memnodemap[spdx >> shift] = nodeids[i]; - - spdx += (1UL << shift); - } while ( spdx <= epdx ); - res = 1; - } - - return res; -} - -static int __init allocate_cachealigned_memnodemap(void) -{ - unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap)); - unsigned long mfn = mfn_x(alloc_boot_pages(size, 1)); - - memnodemap = mfn_to_virt(mfn); - mfn <<= PAGE_SHIFT; - size <<= PAGE_SHIFT; - printk(KERN_DEBUG "NUMA: Allocated memnodemap from %lx - %lx\n", - mfn, mfn + size); - memnodemapsize = size / sizeof(*memnodemap); - - return 0; -} - -/* - * The LSB of all start addresses in the node map is the value of the - * maximum possible shift. - */ -static int __init extract_lsb_from_nodes(const struct node *nodes, - int numnodes, const nodeid_t *nodeids) -{ - int i, nodes_used = 0; - unsigned long spdx, epdx; - unsigned long bitfield = 0, memtop = 0; - - for ( i = 0; i < numnodes; i++ ) - { - spdx = paddr_to_pdx(nodes[i].start); - epdx = paddr_to_pdx(nodes[i].end - 1) + 1; - if ( spdx >= epdx ) - continue; - if ( i && (!nodeids || nodeids[i - 1] != nodeids[i]) ) - bitfield |= spdx; - if ( !i || !nodeids || nodeids[i - 1] != nodeids[i] ) - nodes_used++; - if ( epdx > memtop ) - memtop = epdx; - } - if ( nodes_used <= 1 ) - i = BITS_PER_LONG - 1; - else - i = find_first_bit(&bitfield, sizeof(unsigned long)*8); - memnodemapsize = ((memtop - 1) >> i) + 1; - return i; -} - -int __init compute_hash_shift(struct node *nodes, int numnodes, - nodeid_t *nodeids) -{ - int shift; - - shift = extract_lsb_from_nodes(nodes, numnodes, nodeids); - if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) ) - memnodemap = _memnodemap; - else if ( allocate_cachealigned_memnodemap() ) - return -1; - printk(KERN_DEBUG "NUMA: Using %d for the hash shift.\n", shift); - - if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 ) - { - printk(KERN_INFO "Your memory is not aligned you need to " - "rebuild your hypervisor with a bigger NODEMAPSIZE " - "shift=%d\n", shift); - return -1; - } - - return shift; -} -/* initialize NODE_DATA given nodeid and start/end */ -void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end) -{ - unsigned long start_pfn = paddr_to_pfn(start); - unsigned long end_pfn = paddr_to_pfn(end); - - NODE_DATA(nodeid)->node_start_pfn = start_pfn; - NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn; - - node_set_online(nodeid); -} - -void __init numa_init_array(void) -{ - int rr, i; - - /* There are unfortunately some poorly designed mainboards around - that only connect memory to a single CPU. This breaks the 1:1 cpu->node - mapping. To avoid this fill in the mapping for all possible - CPUs, as the number of CPUs is not known yet. - We round robin the existing nodes. */ - rr = first_node(node_online_map); - for ( i = 0; i < nr_cpu_ids; i++ ) - { - if ( cpu_to_node[i] != NUMA_NO_NODE ) - continue; - numa_set_node(i, rr); - rr = cycle_node(rr, node_online_map); - } -} - -#ifdef CONFIG_NUMA_EMU -static int numa_fake __initdata = 0; - -/* Numa emulation */ -static int __init numa_emulation(unsigned long start_pfn, - unsigned long end_pfn) -{ - int i; - struct node nodes[MAX_NUMNODES]; - uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake; - - /* Kludge needed for the hash function */ - if ( hweight64(sz) > 1 ) - { - u64 x = 1; - while ( (x << 1) < sz ) - x <<= 1; - if ( x < sz/2 ) - printk(KERN_ERR "Numa emulation unbalanced. Complain to maintainer\n"); - sz = x; - } - - memset(&nodes,0,sizeof(nodes)); - for ( i = 0; i < numa_fake; i++ ) - { - nodes[i].start = pfn_to_paddr(start_pfn) + i * sz; - if ( i == numa_fake - 1 ) - sz = pfn_to_paddr(end_pfn) - nodes[i].start; - nodes[i].end = nodes[i].start + sz; - printk(KERN_INFO "Faking node %d at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n", - i, - nodes[i].start, nodes[i].end, - (nodes[i].end - nodes[i].start) >> 20); - node_set_online(i); - } - memnode_shift = compute_hash_shift(nodes, numa_fake, NULL); - if ( memnode_shift < 0 ) - { - memnode_shift = 0; - printk(KERN_ERR "No NUMA hash function found. Emulation disabled.\n"); - return -1; - } - for_each_online_node ( i ) - setup_node_bootmem(i, nodes[i].start, nodes[i].end); - numa_init_array(); - - return 0; -} -#endif - -void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) -{ - int i; - paddr_t start = pfn_to_paddr(start_pfn); - paddr_t end = pfn_to_paddr(end_pfn); - -#ifdef CONFIG_NUMA_EMU - if ( numa_fake && !numa_emulation(start_pfn, end_pfn) ) - return; -#endif - -#ifdef CONFIG_ACPI_NUMA - if ( !numa_off && !acpi_scan_nodes(start, end) ) - return; -#endif - - printk(KERN_INFO "%s\n", - numa_off ? "NUMA turned off" : "No NUMA configuration found"); - - printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n", - start, end); - /* setup dummy node covering all memory */ - memnode_shift = BITS_PER_LONG - 1; - memnodemap = _memnodemap; - /* Dummy node only uses 1 slot in reality */ - memnodemap[0] = 0; - memnodemapsize = 1; - - nodes_clear(node_online_map); - node_set_online(0); - for ( i = 0; i < nr_cpu_ids; i++ ) - numa_set_node(i, 0); - cpumask_copy(&node_to_cpumask[0], cpumask_of(0)); - setup_node_bootmem(0, start, end); -} - -void numa_add_cpu(int cpu) -{ - cpumask_set_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); -} - -void numa_set_node(int cpu, nodeid_t node) -{ - cpu_to_node[cpu] = node; -} - -/* [numa=off] */ -static int __init cf_check numa_setup(const char *opt) -{ - if ( !strncmp(opt, "off", 3) ) - numa_off = true; - else if ( !strncmp(opt, "on", 2) ) - numa_off = false; -#ifdef CONFIG_NUMA_EMU - else if ( !strncmp(opt, "fake=", 5) ) - { - numa_off = false; - numa_fake = simple_strtoul(opt + 5, NULL, 0); - if ( numa_fake >= MAX_NUMNODES ) - numa_fake = MAX_NUMNODES; - } -#endif - else - return arch_numa_setup(opt); - - return 0; -} -custom_param("numa", numa_setup); - /* * Setup early cpu_to_node. * @@ -381,146 +93,3 @@ unsigned int __init arch_get_dma_bitsize(void) flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1) + PAGE_SHIFT, 32); } - -static void cf_check dump_numa(unsigned char key) -{ - s_time_t now = NOW(); - unsigned int i, j, n; - struct domain *d; - struct page_info *page; - unsigned int page_num_node[MAX_NUMNODES]; - const struct vnuma_info *vnuma; - - printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, - now); - - for_each_online_node ( i ) - { - paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); - - printk("NODE%u start->%lu size->%lu free->%lu\n", - i, node_start_pfn(i), node_spanned_pages(i), - avail_node_heap_pages(i)); - /* sanity check phys_to_nid() */ - if ( phys_to_nid(pa) != i ) - printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n", - pa, phys_to_nid(pa), i); - } - - j = cpumask_first(&cpu_online_map); - n = 0; - for_each_online_cpu ( i ) - { - if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] ) - { - if ( n > 1 ) - printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); - else - printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); - j = i; - n = 1; - } - else - ++n; - } - if ( n > 1 ) - printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); - else - printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); - - rcu_read_lock(&domlist_read_lock); - - printk("Memory location of each domain:\n"); - for_each_domain ( d ) - { - process_pending_softirqs(); - - printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d)); - - for_each_online_node ( i ) - page_num_node[i] = 0; - - spin_lock(&d->page_alloc_lock); - page_list_for_each(page, &d->page_list) - { - i = phys_to_nid(page_to_maddr(page)); - page_num_node[i]++; - } - spin_unlock(&d->page_alloc_lock); - - for_each_online_node ( i ) - printk(" Node %u: %u\n", i, page_num_node[i]); - - if ( !read_trylock(&d->vnuma_rwlock) ) - continue; - - if ( !d->vnuma ) - { - read_unlock(&d->vnuma_rwlock); - continue; - } - - vnuma = d->vnuma; - printk(" %u vnodes, %u vcpus, guest physical layout:\n", - vnuma->nr_vnodes, d->max_vcpus); - for ( i = 0; i < vnuma->nr_vnodes; i++ ) - { - unsigned int start_cpu = ~0U; - - if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE ) - printk(" %3u: pnode ???,", i); - else - printk(" %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]); - - printk(" vcpus "); - - for ( j = 0; j < d->max_vcpus; j++ ) - { - if ( !(j & 0x3f) ) - process_pending_softirqs(); - - if ( vnuma->vcpu_to_vnode[j] == i ) - { - if ( start_cpu == ~0U ) - { - printk("%d", j); - start_cpu = j; - } - } - else if ( start_cpu != ~0U ) - { - if ( j - 1 != start_cpu ) - printk("-%d ", j - 1); - else - printk(" "); - start_cpu = ~0U; - } - } - - if ( start_cpu != ~0U && start_cpu != j - 1 ) - printk("-%d", j - 1); - - printk("\n"); - - for ( j = 0; j < vnuma->nr_vmemranges; j++ ) - { - if ( vnuma->vmemrange[j].nid == i ) - printk(" %016"PRIx64" - %016"PRIx64"\n", - vnuma->vmemrange[j].start, - vnuma->vmemrange[j].end); - } - } - - read_unlock(&d->vnuma_rwlock); - } - - rcu_read_unlock(&domlist_read_lock); -} - -static int __init cf_check register_numa_trigger(void) -{ - register_keyhandler('u', dump_numa, "dump NUMA info", 1); - return 0; -} -__initcall(register_numa_trigger); - diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index b46fd9ab18..9df08e9366 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -1350,7 +1350,7 @@ int cpu_add(uint32_t apic_id, uint32_t acpi_id, uint32_t pxm) x86_acpiid_to_apicid[acpi_id] = apic_id; - if ( !srat_disabled() ) + if ( !numa_disabled() ) { nodeid_t node = setup_node(pxm); diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index fbcd8749c4..ce507dac9e 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -238,7 +238,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) unsigned pxm; nodeid_t node; - if (srat_disabled()) + if (numa_disabled()) return; if (pa->header.length < sizeof(struct acpi_srat_x2apic_cpu_affinity)) { bad_srat(); @@ -274,7 +274,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) unsigned pxm; nodeid_t node; - if (srat_disabled()) + if (numa_disabled()) return; if (pa->header.length != sizeof(struct acpi_srat_cpu_affinity)) { bad_srat(); @@ -314,7 +314,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) unsigned int i; bool next = false; - if (srat_disabled()) + if (numa_disabled()) return; if (ma->header.length != sizeof(struct acpi_srat_mem_affinity)) { bad_srat(); @@ -543,8 +543,8 @@ void __init srat_parse_regions(paddr_t addr) pfn_pdx_hole_setup(mask >> PAGE_SHIFT); } -/* Use the information discovered above to actually set up the nodes. */ -int __init acpi_scan_nodes(paddr_t start, paddr_t end) +/* Use discovered information to actually set up the nodes. */ +int __init numa_process_nodes(paddr_t start, paddr_t end) { int i; nodemask_t all_nodes_parsed; diff --git a/xen/common/Makefile b/xen/common/Makefile index 3baf83d527..9a3a12b12d 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -26,6 +26,7 @@ obj-$(CONFIG_MEM_ACCESS) += mem_access.o obj-y += memory.o obj-y += multicall.o obj-y += notifier.o +obj-$(CONFIG_NUMA) += numa.o obj-y += page_alloc.o obj-$(CONFIG_HAS_PDX) += pdx.o obj-$(CONFIG_PERF_COUNTERS) += perfc.o diff --git a/xen/common/numa.c b/xen/common/numa.c new file mode 100644 index 0000000000..a135154c3e --- /dev/null +++ b/xen/common/numa.c @@ -0,0 +1,464 @@ +/* + * Generic VM initialization for NUMA setups. + * Copyright 2002,2003 Andi Kleen, SuSE Labs. + * Adapted for Xen: Ryan Harper + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +struct node_data __ro_after_init node_data[MAX_NUMNODES]; + +/* Mapping from pdx to node id */ +unsigned int __ro_after_init memnode_shift; +unsigned long __ro_after_init memnodemapsize; +nodeid_t *__ro_after_init memnodemap; +static typeof(*memnodemap) __ro_after_init _memnodemap[64]; + +nodeid_t __read_mostly cpu_to_node[NR_CPUS] = { + [0 ... NR_CPUS-1] = NUMA_NO_NODE +}; + +cpumask_t __read_mostly node_to_cpumask[MAX_NUMNODES]; + +nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; + +bool __ro_after_init numa_off; + +bool numa_disabled(void) +{ + return numa_off || arch_numa_disabled(); +} + +/* + * Given a shift value, try to populate memnodemap[] + * Returns : + * 1 if OK + * 0 if memnodmap[] too small (or shift too small) + * -1 if node overlap or lost ram (shift too big) + */ +static int __init populate_memnodemap(const struct node *nodes, + unsigned int numnodes, unsigned int shift, + const nodeid_t *nodeids) +{ + unsigned int i; + int res = -1; + + memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap)); + + for ( i = 0; i < numnodes; i++ ) + { + unsigned long spdx = paddr_to_pdx(nodes[i].start); + unsigned long epdx = paddr_to_pdx(nodes[i].end - 1); + + if ( spdx > epdx ) + continue; + + if ( (epdx >> shift) >= memnodemapsize ) + return 0; + + do { + if ( memnodemap[spdx >> shift] != NUMA_NO_NODE && + (!nodeids || memnodemap[spdx >> shift] != nodeids[i]) ) + return -1; + + if ( !nodeids ) + memnodemap[spdx >> shift] = i; + else + memnodemap[spdx >> shift] = nodeids[i]; + + spdx += (1UL << shift); + } while ( spdx <= epdx ); + + res = 1; + } + + return res; +} + +static int __init allocate_cachealigned_memnodemap(void) +{ + unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap)); + unsigned long mfn = mfn_x(alloc_boot_pages(size, 1)); + + memnodemap = mfn_to_virt(mfn); + mfn <<= PAGE_SHIFT; + size <<= PAGE_SHIFT; + printk(KERN_DEBUG "NUMA: Allocated memnodemap from %lx - %lx\n", + mfn, mfn + size); + memnodemapsize = size / sizeof(*memnodemap); + + return 0; +} + +/* + * The LSB of all start addresses in the node map is the value of the + * maximum possible shift. + */ +static unsigned int __init extract_lsb_from_nodes(const struct node *nodes, + nodeid_t numnodes, + const nodeid_t *nodeids) +{ + unsigned int i, nodes_used = 0; + unsigned long bitfield = 0, memtop = 0; + + for ( i = 0; i < numnodes; i++ ) + { + unsigned long spdx = paddr_to_pdx(nodes[i].start); + unsigned long epdx = paddr_to_pdx(nodes[i].end - 1) + 1; + + if ( spdx >= epdx ) + continue; + + if ( i && (!nodeids || nodeids[i - 1] != nodeids[i]) ) + bitfield |= spdx; + + if ( !i || !nodeids || nodeids[i - 1] != nodeids[i] ) + nodes_used++; + + if ( epdx > memtop ) + memtop = epdx; + } + + if ( nodes_used <= 1 ) + i = min(PADDR_BITS, BITS_PER_LONG - 1); + else + i = find_first_bit(&bitfield, sizeof(unsigned long) * 8); + + memnodemapsize = ((memtop - 1) >> i) + 1; + + return i; +} + +int __init compute_hash_shift(const struct node *nodes, + unsigned int numnodes, const nodeid_t *nodeids) +{ + unsigned int shift = extract_lsb_from_nodes(nodes, numnodes, nodeids); + + if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) ) + memnodemap = _memnodemap; + else if ( allocate_cachealigned_memnodemap() ) + return -1; + + printk(KERN_DEBUG "NUMA: Using %u for the hash shift\n", shift); + + if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 ) + { + printk(KERN_INFO "Your memory is not aligned you need to " + "rebuild your hypervisor with a bigger NODEMAPSIZE " + "shift=%u\n", shift); + return -1; + } + + return shift; +} + +/* Initialize NODE_DATA given nodeid and start/end */ +void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end) +{ + unsigned long start_pfn = paddr_to_pfn(start); + unsigned long end_pfn = paddr_to_pfn(end); + + NODE_DATA(nodeid)->node_start_pfn = start_pfn; + NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn; + + node_set_online(nodeid); +} + +void __init numa_init_array(void) +{ + unsigned int i; + nodeid_t rr; + + /* + * There are unfortunately some poorly designed mainboards + * around that only connect memory to a single CPU. This + * breaks the 1:1 cpu->node mapping. To avoid this fill in + * the mapping for all possible CPUs, as the number of CPUs + * is not known yet. We round robin the existing nodes. + */ + rr = first_node(node_online_map); + for ( i = 0; i < nr_cpu_ids; i++ ) + { + if ( cpu_to_node[i] != NUMA_NO_NODE ) + continue; + numa_set_node(i, rr); + rr = cycle_node(rr, node_online_map); + } +} + +#ifdef CONFIG_NUMA_EMU +static unsigned int __initdata numa_fake; + +/* Numa emulation */ +static int __init numa_emulation(unsigned long start_pfn, + unsigned long end_pfn) +{ + int ret; + unsigned int i; + struct node nodes[MAX_NUMNODES]; + uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake; + + /* Kludge needed for the hash function */ + if ( hweight64(sz) > 1 ) + { + uint64_t x = 1; + + while ( (x << 1) < sz ) + x <<= 1; + if ( x < sz / 2 ) + printk(KERN_ERR "Numa emulation unbalanced. Complain to maintainer\n"); + sz = x; + } + + memset(&nodes, 0, sizeof(nodes)); + for ( i = 0; i < numa_fake; i++ ) + { + nodes[i].start = pfn_to_paddr(start_pfn) + i * sz; + + if ( i == numa_fake - 1 ) + sz = pfn_to_paddr(end_pfn) - nodes[i].start; + + nodes[i].end = nodes[i].start + sz; + printk(KERN_INFO "Faking node %u at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n", + i, nodes[i].start, nodes[i].end, + (nodes[i].end - nodes[i].start) >> 20); + node_set_online(i); + } + + ret = compute_hash_shift(nodes, numa_fake, NULL); + if ( ret < 0 ) + { + printk(KERN_ERR "No NUMA hash function found. Emulation disabled.\n"); + return -1; + } + memnode_shift = ret; + + for_each_online_node ( i ) + setup_node_bootmem(i, nodes[i].start, nodes[i].end); + + numa_init_array(); + + return 0; +} +#endif + +void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) +{ + unsigned int i; + paddr_t start = pfn_to_paddr(start_pfn); + paddr_t end = pfn_to_paddr(end_pfn); + +#ifdef CONFIG_NUMA_EMU + if ( numa_fake && !numa_emulation(start_pfn, end_pfn) ) + return; +#endif + +#ifdef CONFIG_NUMA + if ( !numa_off && !numa_process_nodes(start, end) ) + return; +#endif + + printk(KERN_INFO "%s\n", + numa_off ? "NUMA turned off" : "No NUMA configuration found"); + + printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n", + start, end); + + /* Setup dummy node covering all memory */ + memnode_shift = BITS_PER_LONG - 1; + memnodemap = _memnodemap; + + /* Dummy node only uses 1 slot in reality */ + memnodemap[0] = 0; + memnodemapsize = 1; + + nodes_clear(node_online_map); + node_set_online(0); + for ( i = 0; i < nr_cpu_ids; i++ ) + numa_set_node(i, 0); + + cpumask_copy(&node_to_cpumask[0], cpumask_of(0)); + setup_node_bootmem(0, start, end); +} + +void numa_add_cpu(unsigned int cpu) +{ + cpumask_set_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); +} + +void numa_set_node(unsigned int cpu, nodeid_t node) +{ + cpu_to_node[cpu] = node; +} + +/* [numa=off] */ +static int __init cf_check numa_setup(const char *opt) +{ + if ( !strncmp(opt, "off", 3) ) + numa_off = true; + else if ( !strncmp(opt, "on", 2) ) + numa_off = false; +#ifdef CONFIG_NUMA_EMU + else if ( !strncmp(opt, "fake=", 5) ) + { + numa_off = false; + numa_fake = simple_strtoul(opt + 5, NULL, 0); + if ( numa_fake >= MAX_NUMNODES ) + numa_fake = MAX_NUMNODES; + } +#endif + else + return arch_numa_setup(opt); + + return 0; +} +custom_param("numa", numa_setup); + +static void cf_check dump_numa(unsigned char key) +{ + s_time_t now = NOW(); + unsigned int i, j, n; + struct domain *d; + + printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, + now); + + for_each_online_node ( i ) + { + paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); + + printk("NODE%u start->%lu size->%lu free->%lu\n", + i, node_start_pfn(i), node_spanned_pages(i), + avail_node_heap_pages(i)); + /* Sanity check phys_to_nid() */ + if ( phys_to_nid(pa) != i ) + printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n", + pa, phys_to_nid(pa), i); + } + + j = cpumask_first(&cpu_online_map); + n = 0; + for_each_online_cpu ( i ) + { + if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] ) + { + if ( n > 1 ) + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); + else + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); + j = i; + n = 1; + } + else + ++n; + } + if ( n > 1 ) + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); + else + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); + + rcu_read_lock(&domlist_read_lock); + + printk("Memory location of each domain:\n"); + for_each_domain ( d ) + { + const struct page_info *page; + unsigned int page_num_node[MAX_NUMNODES]; + const struct vnuma_info *vnuma; + + process_pending_softirqs(); + + printk("%pd (total: %u):\n", d, domain_tot_pages(d)); + + memset(page_num_node, 0, sizeof(page_num_node)); + + spin_lock(&d->page_alloc_lock); + page_list_for_each ( page, &d->page_list ) + { + i = phys_to_nid(page_to_maddr(page)); + page_num_node[i]++; + } + spin_unlock(&d->page_alloc_lock); + + for_each_online_node ( i ) + printk(" Node %u: %u\n", i, page_num_node[i]); + + if ( !read_trylock(&d->vnuma_rwlock) ) + continue; + + if ( !d->vnuma ) + { + read_unlock(&d->vnuma_rwlock); + continue; + } + + vnuma = d->vnuma; + printk(" %u vnodes, %u vcpus, guest physical layout:\n", + vnuma->nr_vnodes, d->max_vcpus); + for ( i = 0; i < vnuma->nr_vnodes; i++ ) + { + unsigned int start_cpu = ~0U; + + if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE ) + printk(" %3u: pnode ???,", i); + else + printk(" %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]); + + printk(" vcpus "); + + for ( j = 0; j < d->max_vcpus; j++ ) + { + if ( !(j & 0x3f) ) + process_pending_softirqs(); + + if ( vnuma->vcpu_to_vnode[j] == i ) + { + if ( start_cpu == ~0U ) + { + printk("%u", j); + start_cpu = j; + } + } + else if ( start_cpu != ~0U ) + { + if ( j - 1 != start_cpu ) + printk("-%u ", j - 1); + else + printk(" "); + start_cpu = ~0U; + } + } + + if ( start_cpu != ~0U && start_cpu != j - 1 ) + printk("-%u", j - 1); + + printk("\n"); + + for ( j = 0; j < vnuma->nr_vmemranges; j++ ) + { + if ( vnuma->vmemrange[j].nid == i ) + printk(" %016"PRIx64" - %016"PRIx64"\n", + vnuma->vmemrange[j].start, + vnuma->vmemrange[j].end); + } + } + + read_unlock(&d->vnuma_rwlock); + } + + rcu_read_unlock(&domlist_read_lock); +} + +static int __init cf_check register_numa_trigger(void) +{ + register_keyhandler('u', dump_numa, "dump NUMA info", 1); + return 0; +} +__initcall(register_numa_trigger); diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 7aef1a88dc..5b3877344b 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -18,4 +18,70 @@ (((d)->vcpu != NULL && (d)->vcpu[0] != NULL) \ ? vcpu_to_node((d)->vcpu[0]) : NUMA_NO_NODE) +/* The following content can be used when NUMA feature is enabled */ +#ifdef CONFIG_NUMA + +extern nodeid_t cpu_to_node[NR_CPUS]; +extern cpumask_t node_to_cpumask[]; + +#define cpu_to_node(cpu) cpu_to_node[cpu] +#define parent_node(node) (node) +#define node_to_cpumask(node) node_to_cpumask[node] + +struct node { + paddr_t start, end; +}; + +extern int compute_hash_shift(const struct node *nodes, + unsigned int numnodes, const nodeid_t *nodeids); + +#define VIRTUAL_BUG_ON(x) + +extern bool numa_off; + +extern void numa_add_cpu(unsigned int cpu); +extern void numa_init_array(void); +extern void numa_set_node(unsigned int cpu, nodeid_t node); +extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); +extern int numa_process_nodes(paddr_t start, paddr_t end); + +extern int arch_numa_setup(const char *opt); +extern bool arch_numa_disabled(void); +extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); + +static inline void clear_node_cpumask(unsigned int cpu) +{ + cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); +} + +/* Simple perfect hash to map pdx to node numbers */ +extern unsigned int memnode_shift; +extern unsigned long memnodemapsize; +extern uint8_t *memnodemap; + +struct node_data { + unsigned long node_start_pfn; + unsigned long node_spanned_pages; +}; + +extern struct node_data node_data[]; + +static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr) +{ + nodeid_t nid; + VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); + nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; + VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); + return nid; +} + +#define NODE_DATA(nid) (&node_data[nid]) + +#define node_start_pfn(nid) (NODE_DATA(nid)->node_start_pfn) +#define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages) +#define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ + NODE_DATA(nid)->node_spanned_pages) + +#endif + #endif /* _XEN_NUMA_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 11:45:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 11:45:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445612.700851 (Exim 4.92) (envelope-from ) id 1ovznp-0008VH-CK; Fri, 18 Nov 2022 11:45:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445612.700851; Fri, 18 Nov 2022 11:45:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovznp-0008VA-8s; Fri, 18 Nov 2022 11:45:01 +0000 Received: by outflank-mailman (input) for mailman id 445612; Fri, 18 Nov 2022 11:45:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovzno-0008V4-37 for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 11:45:00 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70082.outbound.protection.outlook.com [40.107.7.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 691a1e63-6736-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 12:44:51 +0100 (CET) Received: from AS9PR06CA0515.eurprd06.prod.outlook.com (2603:10a6:20b:49d::7) by VE1PR08MB5824.eurprd08.prod.outlook.com (2603:10a6:800:1a8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8; Fri, 18 Nov 2022 11:44:28 +0000 Received: from AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49d:cafe::b2) by AS9PR06CA0515.outlook.office365.com (2603:10a6:20b:49d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 11:44:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT031.mail.protection.outlook.com (100.127.140.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 11:44:27 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Fri, 18 Nov 2022 11:44:27 +0000 Received: from 951bd58bf012.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6629B0DE-B02A-4891-8A66-72F2F3299746.1; Fri, 18 Nov 2022 11:44:20 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 951bd58bf012.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 11:44:20 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB8825.eurprd08.prod.outlook.com (2603:10a6:20b:5bc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Fri, 18 Nov 2022 11:44:17 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5834.007; Fri, 18 Nov 2022 11:44:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 691a1e63-6736-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VDPKGLZmllVr3pElvD+q+zqHx8J57C5DchCRyEh/0+U=; b=JfMrXTcFI8NSr5reph2IBkCAKVoZtYljSq4JO9VtdzdLjc9ToFvoecL5qWVqYV5pGSjJmcxz8McgUPAJV0oJJaR+OFHIbhFpkv9bzi0jvwvnIvvZOBCqea4GL8urDbjzgBefAHiPmOTz4WlYZScdw36QL+fI7JlJ8pfvsJCscF0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: c71a98d436106409 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mfXf7j+zY/I0QPf5WXrZO1A9alg7k6/oclFrx18h4ErjUI/BBJRMZ7PuvA41LYNTpaloFpQHPZV5qAb7YTV7oI5tA9RRr5WpxUdl1nssinqH3crL/od5f3IiFjYVjpa9SaAR4fHjSt7YgBbuEHWHWi7JeK4HEvkov7gHCKjMpMsebO2MF5G+lgLB6fR/j1kgDBsB56i6nos5Vagb82Z7qR3AScp0fIbg5oOxNCF22n+m/mVJITfsD5SXjyB7vyw6sg417cfY+fPHTHp46LebKKF9l2Xzl7uiGmHyuZ6WqUJA3wUoz/PqWk8KWKwugjv3AB7e1Mz+kup1tQ6R745qEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VDPKGLZmllVr3pElvD+q+zqHx8J57C5DchCRyEh/0+U=; b=eZfMbDG5DKsfjYpD+PefDjb+EHjCiZgGIRtX/5F2UZb01cXVss+mZEwjSQXS6HvkBleuiXF7Lo476LWBLgNbXxr44ivBN/k+SGTwEWLmxXTBi1FHI76JgU4cdMbd7jrZl4u31iBakeNrlQni/+FzgT7b3LtxmiorI6OeZ/ZMnL2592ZJNnC2gvEjl3+b4qAHjQVFPIf18XfQtnAgmvM8oicocCX7+sxTmdokS139meG6XeQ6ZShWRoLwOYExkCeCCPFvGnqzF8mLbwObi+Thxty7NzwnGbyGKjanvNHT8GUDL5ltKPf1hUwKMFD/u1pgues8ymmYWeYsU1gDwvFYUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VDPKGLZmllVr3pElvD+q+zqHx8J57C5DchCRyEh/0+U=; b=JfMrXTcFI8NSr5reph2IBkCAKVoZtYljSq4JO9VtdzdLjc9ToFvoecL5qWVqYV5pGSjJmcxz8McgUPAJV0oJJaR+OFHIbhFpkv9bzi0jvwvnIvvZOBCqea4GL8urDbjzgBefAHiPmOTz4WlYZScdw36QL+fI7JlJ8pfvsJCscF0= From: Bertrand Marquis To: Michal Orzel CC: "xen-devel@lists.xenproject.org" , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v4 1/3] automation: Create Yocto docker images Thread-Topic: [PATCH v4 1/3] automation: Create Yocto docker images Thread-Index: AQHY+mjC+0nxqx9t9k+ZuMYOtPDJka5EYYoAgAAv0YA= Date: Fri, 18 Nov 2022 11:44:17 +0000 Message-ID: References: <6d48a0f83324d2f42597d43c41ce72d6d80150e6.1668677493.git.bertrand.marquis@arm.com> <60ff35c3-0b3a-7c9f-edf5-0639056570d7@amd.com> In-Reply-To: <60ff35c3-0b3a-7c9f-edf5-0639056570d7@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS8PR08MB8825:EE_|AM7EUR03FT031:EE_|VE1PR08MB5824:EE_ X-MS-Office365-Filtering-Correlation-Id: 85cbb1ea-4081-4885-9c06-08dac95a3f7e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: UitSPTdggz1Wdp6Gdz5PCm29Zu4EK7PDT7qZS1cmEmlLKaWAQP+Gzot04asuas60LY8BYQiGnDX49+9QBHFBMtcTviniNNAncXCs1nzGGmm1LQEQr8DVN/B6aaYxec68DoJmYw/qHYvXNisiDcI0Cr1a7RP15AgEms8sBKq5nsFq5+tdL56/uJntL6Tgi+iMGMHn1gP4nMpSVJ72VgfIIfnZKhb7+eypHMFm+ywzHLflD+kTL8T4xlAcBlzqb7epKOJThgYDRXLj79G10jYuXrToTkaXVQpqbmGD5Lu+EhBrjGgiG0lixUT3uQ+6azCKj00woWHGdghBnfSonlNL/iQJ38mgdIZWP0cusx2hkN+TJq5bTjwIi2llZYa+jXJUbOFIP2xh5xG2BisRwKq2B0i7iWLPjXAAM+v1XenAKwE86jWv2RGMf7ozX4qXvrFT67ABJO7I3u99/rQ7pGaEOv6AKpxvG7ay9qq2iuDuIH8W6Po177mudgvgJqAtB14zes82KJhh3hVjtfmPBOCK2MbvoQmEFPhXkNN91oMDyB7SC3Gwz2IIFVVBoweffZ+xroEo6THracv2R9vdz7nqE4LOpkmcUVQWpparG6DwZ7gaoreA6JJoV2JEKaCoxmeHjFcg2pPUHz1W/E/5IJyWzYmpfY3/hKGZPaJ/uKCvRPBbiF+z5iDXBJLyJRaeCdzINJ1eOYzYRXHid5n7gS54KCc9AZiHixqZeufL6Mxoyg8plcgwXVFJuyyjqz8YShWaKCWASFuNxQ/PFHdsBGFB7LGWjZb8OF78/NdglIy3AXk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(366004)(376002)(396003)(136003)(451199015)(66946007)(76116006)(64756008)(66446008)(66476007)(53546011)(38100700002)(6506007)(2906002)(26005)(6512007)(36756003)(66556008)(4326008)(8676002)(122000001)(966005)(91956017)(86362001)(6916009)(33656002)(6486002)(54906003)(38070700005)(186003)(83380400001)(478600001)(30864003)(8936002)(84970400001)(316002)(41300700001)(71200400001)(2616005)(5660300002)(45980500001)(579004);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <4EBC7E03D3639242B924C9F19A9F758F@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8825 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 76bd50d4-56d5-43cd-bd38-08dac95a3964 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JmicZCD9s/a/lAKCezrGnHXnDkyH956wqSDo6JQRwYeiO/rD+VojYJTGyQn90KTqxgpyUshKcvZo9dZy7NG+JqZg2WeGUq66MU8n3YpZEixlN54KegqwAmHtMtz+tuICMtoPxkqo7BHzdpllcz4d8WrH2zwLea+z4kA85sVoJERrIY5fIBLGa1HcDkojrIn9fqW5VqiUCimWflHImT/oj1Q2EuVS/nJ8GQq80f9T9MFVm9M0QqwK/jLoVIn7PjMJ9hSRI9DSGlO693vEbNYyUVhjJjrTlqU/W3HKG96yrNrTI3pn+whg8YUhk/YDSsx2Jm5sUPgZXYo+VzWusOlWF96z26gXpR5gJDnZ0cAQ13HKjkwKrB7P/yuQY6wd104pDqPCqoZ4wrAsXza6SZ2TeaZli3BJc+wCK0pdVGNy+Z3dJJbmY1noRDUdoG0IZmX8IRwIhNibYC9XUtiZ5PDZOUcabXgBH352qcqEXd+yE26Dd5pCOcbnCg1H4Hks61g3805KBnKQKrslVDFGbIHajXUw8Lrz+PH+uOk2epSdkE0DSTL8xLEsTrHG4TpGOvcTnyHCn1iUXK4M3p3+61P0uBnTiIIPR0VXcuCX/xRuDt847cdqgQ34a+dfsmGv3AQeMgQOruPT4MH26n8TbMv/LcYZpTvXuKrp/BrJ0dt8gykiliu5TkZbyx6MkXcJfLxEKnYVVjXoDekZM/ofAg62tmriSAix/pDeMNc5o2x98SlzxTG5w5rT0Q6Ift0c+cWwPOdo+ZH2AjWOdSE6ysh/Qg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199015)(40470700004)(46966006)(36840700001)(83380400001)(70206006)(86362001)(8676002)(36756003)(81166007)(70586007)(5660300002)(41300700001)(316002)(356005)(33656002)(40480700001)(4326008)(478600001)(54906003)(82740400003)(36860700001)(40460700003)(53546011)(6486002)(186003)(336012)(2616005)(966005)(6512007)(107886003)(26005)(6506007)(82310400005)(47076005)(6862004)(8936002)(2906002)(30864003)(84970400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 11:44:27.5067 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85cbb1ea-4081-4885-9c06-08dac95a3f7e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5824 SGkgTWljaGFsLA0KDQo+IE9uIDE4IE5vdiAyMDIyLCBhdCAwODo1MywgTWljaGFsIE9yemVsIDxt aWNoYWwub3J6ZWxAYW1kLmNvbT4gd3JvdGU6DQo+IA0KPiBIaSBCZXJ0cmFuZCwNCj4gDQo+IEp1 c3QsIHNvbWUgbWlub3IgY29tbWVudHMuDQo+IA0KPiBPbiAxNy8xMS8yMDIyIDEwOjM5LCBCZXJ0 cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gDQo+PiANCj4+IEFkZCBjb250YWluZXJzIHN1aXRhYmxl IHRvIHJ1biB5b2N0byBraXJrc3RvbmUgYnVpbGQgYmFzZWQgb24gdWJ1bnR1DQo+PiAyMi4wNC4g SXQgY29udGFpbnMgYWxsIHBhY2thZ2VzIHJlcXVpcmVkIGJ5IFlvY3RvIGFuZCBhIGNoZWNrb3V0 IG9mIHRoZQ0KPj4gbGF5ZXJzIHJlcXVpcmVkIHRvIGJ1aWxkIFhlbiB3aXRoIFlvY3RvLg0KPj4g DQo+PiBBZGQgYSBnZW5lcmljIGRvY2tlciBpbWFnZSB0ZW1wbGF0ZSB0byBiZSB1c2VkIHRvIGF1 dG9tYXRpY2FsbHkgZ2VuZXJhdGUNCj4+IGRvY2tlciBmaWxlcyBmb3IgZGlmZmVyZW50IGNvbmZp Z3VyYXRpb25zOg0KPj4gLSBzcGVjaWZpYyB5b2N0byB2ZXJzaW9uDQo+PiAtIGRpZmZlcmVudCB0 YXJnZXRzIChxZW11IGFybSwgYXJtNjQgYW5kIHg4NikNCj4+IC0gZGlmZmVyZW50IGhvc3QgcGxh dGZvcm1zICh4ODYgb3IgYXJtNjQpDQo+PiANCj4+IER1cmluZyBhIGNhbGwgdG8gJ21ha2UgYWxs Jywgb25seSB0aGUgaW1hZ2VzIGZvciB0aGUgY3VycmVudCBob3N0DQo+PiBwbGF0Zm9ybSB3aWxs IGJlIGdlbmVyYXRlZC4NCj4gVGhpcyBsb29rcyBsaWtlIGEgc3RhbGUgY29tbWVudC4gVGhlIHJl YXNvbiBiZWluZywgaW4gdGhlIG5ldyB2ZXJzaW9uLCBieSBkZWZhdWx0DQo+IHdlIGJ1aWxkIHRo ZSBpbWFnZXMgZm9yIHRoZSBhcmNoaXRlY3R1cmVzIGV4cGVjdGVkIGJ5IHRoZSBDSSBhbmQgaXRz IHJ1bm5lcnMNCj4gdG8gbWF0Y2ggdGhlIGN1cnJlbnQgd29ya2Zsb3cuDQoNClJpZ2h0IEkgd2ls bCBmaXggdGhlIGNvbW1pdCBtZXNzYWdlLg0KDQo+IA0KPj4gSWYgbmVlZGVkLCBpbWFnZXMgZm9y IGFuIG90aGVyIGhvc3QgcGxhdGZvcm0gY2FuIGJlIGdlbmVyYXRlZCBtYW51YWxseQ0KPj4gYnkg Y2FsbGluZyB0aGUgcmlnaHQgbWFrZSB0YXJnZXQgKHNlZSBtYWtlIGhlbHApLg0KPj4gDQo+PiBB ZGQgYSBidWlsZCBzY3JpcHQgdG8gYnVpbGQgYW5kIHJ1biB4ZW4gb24gcWVtdSB1c2luZyBZb2N0 by4NCj4+IFRoZSBzY3JpcHQgc3VwcG9ydHMgYXJtMzIsIGFybTY0IGFuZCB4ODZfNjQgYW5kIGNo ZWNrcyB0aGF0IGRvbTAgaXMNCj4+IHByb3Blcmx5IGJvb3RpbmcuIEF0IHRoaXMgc3RhZ2UgdGhp cyBkb2VzIG5vdCBydW4gYW55IGd1ZXN0IG9uIHRvcCBvZg0KPj4gZG9tMC4gVGhlIHNjcmlwdCBp cyB0byBiZSBleGVjdXRlZCBpbiBvbmUgb2YgdGhlIGRvY2tlciBpbWFnZXMgdG8gYnVpbGQNCj4+ IGFuZCBydW4gYSBzeXN0ZW0gdXNpbmcgYSBYZW4gc291cmNlIHRyZWUuDQo+PiANCj4+IFNpZ25l ZC1vZmYtYnk6IEJlcnRyYW5kIE1hcnF1aXMgPGJlcnRyYW5kLm1hcnF1aXNAYXJtLmNvbT4NCj4+ IC0tLQ0KPj4gQ2hhbmdlcyBpbiB2NDoNCj4+IC0gUmV3b3JrIHRoZSBzeXN0ZW0gdG8gaGF2ZSBv bmUgZG9ja2VyZmlsZSB0ZW1wbGF0ZSBmcm9tIHdoaWNoIG1ha2Ugd2lsbA0KPj4gZ2VuZXJhdGUg dGhlIHJlcXVpcmVkIGRvY2tlcmZpbGVzIGZvciB0aGUgd2FudGVkIGNvbmZpZ3VyYXRpb24NCj4g VGhhdCBpcyBncmVhdC4NCg0KVGhhbmtzIDotKQ0KPiANCj4+IC0gYWRkIHN1cHBvcnQgZm9yIGRp ZmZlcmVudCBob3N0IGFyY2hpdGVjdHVyZXMNCj4+IC0gTWVyZ2UgdGhlIGdlbmVyYXRpb24gc3lz dGVtIGludG8gb25lIHNpbmdsZSBkb2NrZXJmaWxlDQo+PiAtIE1lcmdlIHBhdGNoZXMgMSBhbmQg MiBpbiBhIHNpbmdsZSBwYXRjaA0KPj4gLSBJbnRyb2R1Y2UgQ09OVEFJTkVSU19FWFRSQSB0byBo YXZlIGV4dHJhIGNvbnRhaW5lcnMgbm90IGJ1aWx0IGJ5DQo+PiBkZWZhdWx0IChmb3IgdGhvc2Ug bm90IHVzZWQgYnkgQ0kgYnV0IHVzZWZ1bCB0byB1c2VycykNCj4+IENoYW5nZXMgaW4gdjM6DQo+ PiAtIGxpbWl0IG51bWJlciBvZiBqb2JzIGluIHlvY3RvIGJ5IGRlZmF1bHQgdG8gOCBhbmQgYWRk IC0tbnVtLWpvYnMNCj4+IG9wdGlvbiB0byB0aGUgc2NyaXB0IHRvIHNldCBhIGN1c3RvbSBudW1i ZXIgb2Ygam9icw0KPj4gLSBkbyBub3QgY29weSBhbnltb3JlIHRoZSBidWlsZC15b2N0by5zaCBz Y3JpcHQgaW5zaWRlIHRoZSBtYWluIGltYWdlIHNvDQo+PiB0aGF0IHRoZSBjdXJyZW50IG9uZSBp biB0aGUgcmVwb3NpdG9yeSBpcyB1c2VkIHdoZW4gcnVubmluZw0KPj4gQ2hhbmdlcyBpbiB2MjoN Cj4+IC0gYWRkIGEgLS1kdW1wLWxvZyBjb21tYW5kIGxpbmUgb3B0aW9uIHRvIGJ1aWxkLXlvY3Rv LnNoIHNjcmlwdCB0byBkdW1wDQo+PiB0aGUgbG9ncyBpZiBhbiBlcnJvciBvY2N1cnMuDQo+PiBD aGFuZ2VzIGluIHYxOg0KPj4gLSBhZGQgLS1pbWFnZSBjb21tYW5kIGxpbmUgYXJndW1lbnQgdG8g YnVpbGQteW9jdG8uc2ggdG8gYWxsb3cgYnVpbGRpbmcNCj4+IHNvbWV0aGluZyBkaWZmZXJlbnQg dGhhbiB4ZW4taW1hZ2UtbWluaW1hbC4NCj4+IC0gbW9kaWZ5IGRvY2tlcmZpbGUgdG8gaGF2ZSBv bmUgbGF5ZXIgcGVyIGxpbmUgYW5kIG1ha2UgaXQgZWFzaWVyIHRvIGFkZA0KPj4gb3RoZXIuIEkg a2VwdCB0aGUgZm9yIGxvb3AgdG8ga2VlcCB0aGUgbnVtYmVyIG9mIGRvY2tlciBzdGVwcyBsb3dl cg0KPj4gLSB1cGRhdGUgY29tbWl0IG1lc3NhZ2UgdG8gd2FybiB0aGF0IG5vIGd1ZXN0IGFyZSB0 ZXN0ZWQuDQo+PiAtIGZpeCBidWlsZC15b2N0byBzY3JpcHQgdG8gcHJvcGVybHkgcmV0dXJuIHdp dGggYW4gZXJyb3IgaWYgZXhwZWN0DQo+PiBzY3JpcHQgZW5kcyB1cCBpbiB0aW1lb3V0IG9yIEVP Ri4NCj4+IC0tLQ0KPj4gYXV0b21hdGlvbi9idWlsZC9NYWtlZmlsZSAgICAgICAgICAgICAgICAg IHwgIDE0ICstDQo+PiBhdXRvbWF0aW9uL2J1aWxkL3lvY3RvL2J1aWxkLXlvY3RvLnNoICAgICAg fCAzNDkgKysrKysrKysrKysrKysrKysrKysrDQo+PiBhdXRvbWF0aW9uL2J1aWxkL3lvY3RvL3lv Y3RvLmRvY2tlcmZpbGUuaW4gfCAxMTQgKysrKysrKw0KPj4gYXV0b21hdGlvbi9idWlsZC95b2N0 by95b2N0by5pbmMgICAgICAgICAgIHwgIDQxICsrKw0KPj4gNCBmaWxlcyBjaGFuZ2VkLCA1MTYg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4+IGNyZWF0ZSBtb2RlIDEwMDc1NSBhdXRv bWF0aW9uL2J1aWxkL3lvY3RvL2J1aWxkLXlvY3RvLnNoDQo+PiBjcmVhdGUgbW9kZSAxMDA2NDQg YXV0b21hdGlvbi9idWlsZC95b2N0by95b2N0by5kb2NrZXJmaWxlLmluDQo+PiBjcmVhdGUgbW9k ZSAxMDA2NDQgYXV0b21hdGlvbi9idWlsZC95b2N0by95b2N0by5pbmMNCj4+IA0KPj4gZGlmZiAt LWdpdCBhL2F1dG9tYXRpb24vYnVpbGQvTWFrZWZpbGUgYi9hdXRvbWF0aW9uL2J1aWxkL01ha2Vm aWxlDQo+PiBpbmRleCBhNGIyYjg1MTc4Y2YuLjcyYTUzMzViYWVjMSAxMDA2NDQNCj4+IC0tLSBh L2F1dG9tYXRpb24vYnVpbGQvTWFrZWZpbGUNCj4+ICsrKyBiL2F1dG9tYXRpb24vYnVpbGQvTWFr ZWZpbGUNCj4+IEBAIC0xLDEzICsxLDE4IEBADQo+PiANCj4+ICMgdGhlIGJhc2Ugb2Ygd2hlcmUg dGhlc2UgY29udGFpbmVycyB3aWxsIGFwcGVhcg0KPj4gUkVHSVNUUlkgOj0gcmVnaXN0cnkuZ2l0 bGFiLmNvbS94ZW4tcHJvamVjdC94ZW4NCj4+IC1DT05UQUlORVJTID0gJChzdWJzdCAuZG9ja2Vy ZmlsZSwsJCh3aWxkY2FyZCAqLyouZG9ja2VyZmlsZSkpDQo+PiArQ09OVEFJTkVSUyA9ICQoZmls dGVyLW91dCB5b2N0by8lLCQoc3Vic3QgLmRvY2tlcmZpbGUsLCQod2lsZGNhcmQgKi8qLmRvY2tl cmZpbGUpKSkNCj4+ICtDT05UQUlORVJTX0VYVFJBID0NCj4+IERPQ0tFUl9DTUQgPz0gZG9ja2Vy DQo+PiANCj4+ICtpbmNsdWRlIHlvY3RvL3lvY3RvLmluYw0KPj4gKw0KPj4gaGVscDoNCj4+ICAg ICAgICBAZWNobyAiQnVpbGRzIGNvbnRhaW5lcnMgZm9yIGJ1aWxkaW5nIFhlbiBiYXNlZCBvbiBk aWZmZXJlbnQgZGlzdHJvcyINCj4+ICAgICAgICBAZWNobyAiVG8gYnVpbGQgb25lIHJ1biAnbWFr ZSBESVNUUk8vVkVSU0lPTicuIEF2YWlsYWJsZSBjb250YWluZXJzOiINCj4+ICAgICAgICBAJChm b3JlYWNoIGZpbGUsJChzb3J0ICQoQ09OVEFJTkVSUykpLGVjaG8gJHtmaWxlfTspDQo+PiArICAg ICAgIEBlY2hvICJFeHRyYSBjb250YWluZXJzIChub3QgYnVpbHQgdXNpbmcgbWFrZSBhbGwpOiIN Cj4+ICsgICAgICAgQCQoZm9yZWFjaCBmaWxlLCQoc29ydCAkKENPTlRBSU5FUlNfRVhUUkEpKSxl Y2hvICR7ZmlsZX07KQ0KPj4gICAgICAgIEBlY2hvICJUbyBwdXNoIGNvbnRhaW5lciBidWlsZHMs IHNldCB0aGUgZW52IHZhciBQVVNIIg0KPj4gDQo+PiAlOiAlLmRvY2tlcmZpbGUgIyMgQnVpbGRz IGNvbnRhaW5lcnMNCj4+IEBAIC0xNiw1ICsyMSwxMCBAQCBoZWxwOg0KPj4gICAgICAgICAgICAg ICAgJChET0NLRVJfQ01EKSBwdXNoICQoUkVHSVNUUlkpLyQoQEQpOiQoQEYpOyBcDQo+PiAgICAg ICAgZmkNCj4+IA0KPj4gLS5QSE9OWTogYWxsDQo+PiArLlBIT05ZOiBhbGwgY2xlYW4NCj4+IGFs bDogJChDT05UQUlORVJTKQ0KPj4gKw0KPj4gKyMgUmVtb3ZlIGdlbmVyYXRlZCBkb2NrZXJmaWxl cyBmb3IgeW9jdG8NCj4+ICtjbGVhbjoNCj4+ICsgICAgICAgcm0gLWYgeW9jdG8vKi5kb2NrZXJm aWxlcw0KPiBBcmUgdGhlc2UgZmlsZXMgbmVlZGVkIGFmdGVyIG1ha2UgaXMgY29tcGxldGVkPw0K PiBJZiBub3QsIG1heWJlIHRvIGF2b2lkIGhhdmluZyBzb21lIHVudHJhY2tlZCBmaWxlcyBpbiB0 aGUgdHJlZSwgdGhleSBjb3VsZCBiZSByZW1vdmVkIGFmdGVyIG1ha2UgaXMgZG9uZT8NCg0KSSBk byBub3QgYWdyZWUgaGVyZSwgb24gbWlnaHQgd2FudCB0byBpbnNwZWN0IHRob3NlIGZpbGVzIHRv IGNoZWNrLg0KQ2xlYW5pbmcgZHVyaW5nIG1ha2UgY2xlYW4gaXMgbW9yZSBzdGFuZGFyZC4NCg0K QWxzbyB0aG9zZSBhcmUgaW50ZXJtZWRpYXRlIGZpbGVzIHNvIG1ha2Ugc2hvdWxkL2NvdWxkIGNs ZWFuIHRoZW0gYXV0b21hdGljYWxseS4NCkkgd2lsbCBtYWtlIGEgdHJ5IHRvIGZsYWcgdGhlbSBp bnRlcm1lZGlhdGUgaWYgbm90IGhhbmRsZWQgYXV0b21hdGljYWxseSBhbHJlYWR5IGJ1dCBJIHdp bGwgc3RpbGwga2VlcCB0aGlzIGhlcmUuDQoNCj4gDQo+PiArDQo+PiBkaWZmIC0tZ2l0IGEvYXV0 b21hdGlvbi9idWlsZC95b2N0by9idWlsZC15b2N0by5zaCBiL2F1dG9tYXRpb24vYnVpbGQveW9j dG8vYnVpbGQteW9jdG8uc2gNCj4+IG5ldyBmaWxlIG1vZGUgMTAwNzU1DQo+PiBpbmRleCAwMDAw MDAwMDAwMDAuLmQwYzkzZGZhZmZlMA0KPj4gLS0tIC9kZXYvbnVsbA0KPj4gKysrIGIvYXV0b21h dGlvbi9idWlsZC95b2N0by9idWlsZC15b2N0by5zaA0KPj4gQEAgLTAsMCArMSwzNDkgQEANCj4+ ICsjIS9iaW4vYmFzaA0KPj4gKyMNCj4+ICsjIFlvY3RvIG1ldGEgdmlydHVhbGl6YXRpb24gYnVp bGQgYW5kIHJ1biBzY3JpcHQNCj4+ICsjDQo+PiArIyBUaGlzIHNjcmlwdCBpcyBidWlsZGluZyBZ b2N0byB4ZW4taW1hZ2UtbWluaW1hbCBmb3IgcWVtdSB0YXJnZXRzIGFuZCBydW4NCj4+ICsjIHRo ZW0gdXNpbmcgcnVucWVtdSBpbnNpZGUgeW9jdG8gdG8gY2hlY2sgdGhhdCBkb20wIGlzIGJvb3Rp bmcgcHJvcGVybHkNCj4gTWlzc2luZyBkb3QgYXQgdGhlIGVuZCBvZiBhIHNlbnRlbmNlLg0KDQpX aWxsIGZpeA0KDQo+IA0KPj4gKyMgVGhlIGJ1aWxkIGlzIHVzaW5nIGEgbG9jYWwgeGVuIHNvdXJj ZSB0cmVlIHNvIHRoYXQgc3BlY2lmaWMgcGF0Y2hlcyBjYW4gYmUNCj4+ICsjIHRlc3RlZC4NCj4+ ICsjIEluIG9yZGVyIHRvIG9wdGltaXplIHRoZSBidWlsZCB0aW1lLCBhIGJ1aWxkIGNhY2hlIGlz IHVzZWQgc28gdGhhdCBvbmx5IHhlbg0KPj4gKyMgcGFja2FnZXMgYW5kIGl0cyBkZXBlbmRlbmNp ZXMgYXJlIHJlYnVpbHQgKHFlbXUgYW5kIGZpbmFsIGltYWdlIG1haW5seSkuDQo+PiArIw0KPj4g Kw0KPj4gKyMgRGlyZWN0b3JpZXMNCj4+ICtZT0NUT0RJUj0iJEhPTUUveW9jdG8tbGF5ZXJzIg0K Pj4gK0NBQ0hFRElSPSIkSE9NRS95b2N0by1jYWNoZSINCj4+ICtMT0dESVI9IiRIT01FL2xvZ3Mi DQo+PiArWEVORElSPSIkSE9NRS94ZW4iDQo+PiArQlVJTERESVI9IiRIT01FL2J1aWxkIg0KPj4g Kw0KPj4gKyMgd2hhdCB5b2N0byBic3Agd2Ugc3VwcG9ydA0KPj4gK1RBUkdFVF9TVVBQT1JURUQ9 InFlbXVhcm0gcWVtdWFybTY0IHFlbXV4ODYtNjQiDQo+PiArVkVSQk9TRT0ibiINCj4+ICtUQVJH RVRMSVNUPSIiDQo+PiArQlVJTERKT0JTPSI4Ig0KPj4gKw0KPj4gKyMgYWN0aW9ucyB0byBkbw0K Pj4gK2RvX2NsZWFuPSJuIg0KPj4gK2RvX2J1aWxkPSJ5Ig0KPj4gK2RvX3J1bj0ieSINCj4+ICtk b19sb2NhbHNyYz0ibiINCj4+ICtkb19kdW1wPSJuIg0KPj4gK2J1aWxkX3Jlc3VsdD0wDQo+PiAr DQo+PiArIyBsYXllcnMgdG8gaW5jbHVkZSBpbiB0aGUgcHJvamVjdA0KPj4gK2J1aWxkX2xheWVy bGlzdD0icG9reS9tZXRhIHBva3kvbWV0YS1wb2t5IHBva3kvbWV0YS15b2N0by1ic3AgXA0KPj4g KyAgICAgICAgICAgICAgICAgbWV0YS1vcGVuZW1iZWRkZWQvbWV0YS1vZSBtZXRhLW9wZW5lbWJl ZGRlZC9tZXRhLXB5dGhvbiBcDQo+PiArICAgICAgICAgICAgICAgICBtZXRhLW9wZW5lbWJlZGRl ZC9tZXRhLWZpbGVzeXN0ZW1zIFwNCj4+ICsgICAgICAgICAgICAgICAgIG1ldGEtb3BlbmVtYmVk ZGVkL21ldGEtbmV0d29ya2luZyBtZXRhLXZpcnR1YWxpemF0aW9uIg0KPj4gKw0KPj4gKyMgeW9j dG8gaW1hZ2UgdG8gYnVpbGQNCj4+ICtidWlsZF9pbWFnZT0ieGVuLWltYWdlLW1pbmltYWwiDQo+ PiArDQo+PiArZnVuY3Rpb24gcHJpbnRfcHJvZ3Jlc3MoKSB7DQo+PiArICAgIGVjaG8gLW4gIiQo ZGF0ZSArJVQpICQqIg0KPj4gK30NCj4+ICsNCj4+ICtmdW5jdGlvbiBydW5fdGFzaygpIHsNCj4+ ICsgICAgbG9jYWwgdGFza19uYW1lPSIkMSINCj4+ICsgICAgbG9jYWwgdGFza190YXJnZXQ9IiQy Ig0KPj4gKw0KPj4gKyAgICB0YXNrX2xvZz0iJHt0YXNrX25hbWUvL3Byb2plY3RffS0ke3Rhc2tf dGFyZ2V0fSINCj4+ICsNCj4+ICsgICAgbWtkaXIgLXAgIiR7TE9HRElSfSINCj4+ICsgICAgcHJp bnRfcHJvZ3Jlc3MNCj4+ICsgICAgZWNobyAtbiAiJHt0YXNrX25hbWUvL3Byb2plY3RffSAke3Rh c2tfdGFyZ2V0fTogIg0KPj4gKyAgICBpZiBbICIke1ZFUkJPU0V9IiA9ICJuIiBdOyB0aGVuDQo+ PiArICAgICAgICAkQCA+ICIke0xPR0RJUn0vJHt0YXNrX2xvZ30ubG9nIiAyPiYxDQo+PiArICAg IGVsc2UNCj4+ICsgICAgICAgICRAIDI+JjEgfCB0ZWUgIiR7TE9HRElSfS8ke3Rhc2tfbG9nfS5s b2ciDQo+PiArICAgIGZpDQo+PiArDQo+PiArICAgIGlmIFsgJHs/fSAtbmUgMCBdOyB0aGVuDQo+ PiArICAgICAgICBlY2hvICJFcnJvciINCj4+ICsgICAgICAgIGJ1aWxkX3Jlc3VsdD0kKChidWls ZF9yZXN1bHQrMSkpDQo+PiArICAgICAgICBpZiBbICIke2RvX2R1bXB9IiA9ICJ5IiBdOyB0aGVu DQo+PiArICAgICAgICAgICAgZWNobw0KPj4gKyAgICAgICAgICAgIGVjaG8gIiMjIyMjIyMjIyMj IyBMT0dTLVNUQVJUICMjIyMjIyMjIyMjIyINCj4+ICsgICAgICAgICAgICBjYXQgIiR7TE9HRElS fS8ke3Rhc2tfbG9nfS5sb2ciDQo+PiArICAgICAgICAgICAgZWNobyAiIyMjIyMjIyMjIyMjICBM T0dTLUVORCAgIyMjIyMjIyMjIyMjIg0KPj4gKyAgICAgICAgICAgIGVjaG8NCj4+ICsgICAgICAg IGZpDQo+PiArICAgICAgICByZXR1cm4gMQ0KPj4gKyAgICBlbHNlDQo+PiArICAgICAgICBlY2hv ICJPSyINCj4+ICsgICAgICAgIHJldHVybiAwDQo+PiArICAgIGZpDQo+PiArfQ0KPj4gKw0KPj4g K2Z1bmN0aW9uIHByb2plY3RfY3JlYXRlKCkgew0KPj4gKyAgICB0YXJnZXQ9IiR7MTo/fSINCj4+ ICsgICAgZGVzdGRpcj0iJHtCVUlMRERJUn0vJHt0YXJnZXR9Ig0KPj4gKw0KPj4gKyAgICAoDQo+ PiArICAgICAgICAjIGluaXQgeW9jdG8gcHJvamVjdA0KPj4gKyAgICAgICAgc291cmNlICR7WU9D VE9ESVJ9L3Bva3kvb2UtaW5pdC1idWlsZC1lbnYgIiR7ZGVzdGRpcn0iDQo+PiArDQo+PiArICAg ICAgICAjIGFkZCBuZWVkZWQgbGF5ZXJzDQo+PiArICAgICAgICBmb3IgbGF5ZXIgaW4gJHtidWls ZF9sYXllcmxpc3R9OyBkbw0KPj4gKyAgICAgICAgICAgIGJpdGJha2UtbGF5ZXJzIGFkZC1sYXll ciAke1lPQ1RPRElSfS8ke2xheWVyfSB8fCBleGl0IDENCj4+ICsgICAgICAgIGRvbmUNCj4+ICsg ICAgKSB8fCByZXR1cm4gMQ0KPj4gKw0KPj4gKyAgICAjIGN1c3RvbWl6ZSBwcm9qZWN0IGNvbmZp Z3VyYXRpb24NCj4+ICsgICAgY2F0IDw8RU9GID4+ICIke2Rlc3RkaXJ9L2NvbmYvbG9jYWwuY29u ZiINCj4+ICsjIFlvY3RvIEJTUA0KPj4gK01BQ0hJTkUgPSAiJHt0YXJnZXR9Ig0KPj4gKw0KPj4g KyMgVXNlIGxvY2FsIGNhY2hlIHRvIHJldXNlIHByZXZpb3VzIGJ1aWxkcyByZXN1bHRzDQo+PiAr U1NUQVRFX0RJUiA9ICIke0NBQ0hFRElSfS9zc3RhdGUtY2FjaGUiDQo+PiArRExfRElSID0gIiR7 Q0FDSEVESVJ9L2Rvd25sb2FkcyINCj4+ICsNCj4+ICsjIEVuYWJsZSB4ZW4gYW5kIHZpcnR1YWxp emF0aW9uDQo+PiArRElTVFJPX0ZFQVRVUkVTID0gIiB2aXJ0dWFsaXphdGlvbiB4ZW4gaXB2NCIN Cj4+ICsNCj4+ICsjIFNwZWVkIHVwIHJ1biBieSBub3QgZ2VuZXJhdGluZyBzc2ggaG9zdCBrZXlz DQo+PiArSU1BR0VfSU5TVEFMTDphcHBlbmQ6cG4teGVuLWltYWdlLW1pbmltYWwgPSAiIHNzaC1w cmVnZW4taG9zdGtleXMiDQo+PiArDQo+PiArIyBTYXZlIHNvbWUgZGlzayBzcGFjZQ0KPj4gK0lO SEVSSVQgKz0gInJtX3dvcmsiDQo+PiArDQo+PiArIyBSZWR1Y2UgbnVtYmVyIG9mIGpvYnMNCj4+ ICtCQl9OVU1CRVJfVEhSRUFEUz0iJHtCVUlMREpPQlN9Ig0KPj4gKw0KPj4gK0VPRg0KPj4gKw0K Pj4gKyAgICBpZiBbICIke2RvX2xvY2Fsc3JjfSIgPSAieSIgXTsgdGhlbg0KPj4gKyAgICAgICAg WEVOVkVSUz0kKGdyZXAgLWUgIl5YRU5fUkVMIiBcDQo+PiArICAgICAgICAgICAgIiR7WU9DVE9E SVJ9Ii9tZXRhLXZpcnR1YWxpemF0aW9uL3JlY2lwZXMtZXh0ZW5kZWQveGVuL3hlbl8qLmJiIFwN Cj4+ICsgICAgICAgICAgICAyPiAvZGV2L251bGwgfCB0ciAtZCAnICcgfCB0ciAtZCAnPycgfCB0 ciAtZCAnIicgXA0KPj4gKyAgICAgICAgICAgIHwgc2VkIC1lICJzLy4qPS8vIiB8IHNvcnQgLVYg fCB0YWlsIC1uIDEpDQo+PiArDQo+PiArICAgICAgICBYRU5CQVNFPSQoZGlybmFtZSAiJChyZWFs cGF0aCAtbSAiJHtYRU5ESVJ9IikiKQ0KPj4gKyAgICAgICAgWEVOU1VCPSQoYmFzZW5hbWUgIiQo cmVhbHBhdGggLW0gIiR7WEVORElSfSIpIikNCj4+ICsNCj4+ICsgICAgICAgIGNhdCA8PEVPRiA+ PiAiJHtkZXN0ZGlyfS9jb25mL2xvY2FsLmNvbmYiDQo+PiArIyBVc2UgbG9jYWwgc291cmNlcyBm b3IgeGVuIGFuZCB4ZW4tdG9vbHMNCj4+ICtGSUxFU0VYVFJBUEFUSFM6cHJlcGVuZDpwbi14ZW4g Oj0gIiR7WEVOQkFTRX06Ig0KPj4gK0ZJTEVTRVhUUkFQQVRIUzpwcmVwZW5kOnBuLXhlbi10b29s cyA6PSAiJHtYRU5CQVNFfToiDQo+PiArDQo+PiArU1JDX1VSSTpwbi14ZW4gPSAiZmlsZTovLyR7 WEVOU1VCfS87c3ViZGlyPWxvY2FsLXhlbi8iDQo+PiArU1JDX1VSSTpwbi14ZW4tdG9vbHMgPSAi ZmlsZTovLyR7WEVOU1VCfS87c3ViZGlyPWxvY2FsLXhlbi8iDQo+PiArDQo+PiArUFJFRkVSUkVE X1ZFUlNJT046cG4teGVuID0gIiR7WEVOVkVSU30lIg0KPj4gK1BSRUZFUlJFRF9WRVJTSU9OOnBu LXhlbi10b29scyA9ICIke1hFTlZFUlN9JSINCj4+ICsNCj4+ICtTOnBuLXhlbiA9ICJcJHtXT1JL RElSfS9sb2NhbC14ZW4vJHtYRU5TVUJ9Ig0KPj4gK1M6cG4teGVuLXRvb2xzID0gIlwke1dPUktE SVJ9L2xvY2FsLXhlbi8ke1hFTlNVQn0iDQo+PiArDQo+PiArU1JDUkVWOnBuLXhlbiA9ICJcJHtB VVRPUkVWfSINCj4+ICtTUkNSRVY6cG4teGVuLXRvb2xzID0gIlwke0FVVE9SRVZ9Ig0KPj4gKw0K Pj4gK1NSQ1BWOnBuLXhlbiA9ICIxIg0KPj4gK1NSQ1BWOnBuLXhlbi10b29scyA9ICIxIg0KPj4g Kw0KPj4gKyMgRGlzYWJsZSBhbGwgUUEgZXJyb3JzIGFzIHRoZSByZWNpcGUgaXMgbm90IHVwIHRv IGRhdGUgd2l0aCBjaGFuZ2VzIGluIFhlbg0KPj4gKyMgd2hlbiB3ZSB1c2UgbG9jYWwgc291cmNl cw0KPj4gK0VSUk9SX1FBOnBuLXhlbiA9ICJhcmNoIg0KPj4gK0VSUk9SX1FBOnBuLXhlbi10b29s cyA9ICJhcmNoIg0KPj4gKw0KPj4gK0VPRg0KPj4gKyAgICBmaQ0KPj4gK30NCj4+ICsNCj4+ICtm dW5jdGlvbiBwcm9qZWN0X2J1aWxkKCkgew0KPj4gKyAgICB0YXJnZXQ9IiR7MTo/fSINCj4+ICsg ICAgZGVzdGRpcj0iJHtCVUlMRERJUn0vJHt0YXJnZXR9Ig0KPj4gKw0KPj4gKyAgICAoDQo+PiAr ICAgICAgICBzb3VyY2UgJHtZT0NUT0RJUn0vcG9reS9vZS1pbml0LWJ1aWxkLWVudiAiJHtkZXN0 ZGlyfSINCj4+ICsNCj4+ICsgICAgICAgIGJpdGJha2UgIiR7YnVpbGRfaW1hZ2V9IiB8fCBleGl0 IDENCj4+ICsgICAgKSB8fCByZXR1cm4gMQ0KPj4gK30NCj4+ICsNCj4+ICtmdW5jdGlvbiBwcm9q ZWN0X2NsZWFuKCkgew0KPj4gKyAgICB0YXJnZXQ9IiR7MTo/fSINCj4+ICsgICAgZGVzdGRpcj0i JHtCVUlMRERJUn0vJHt0YXJnZXR9Ig0KPj4gKw0KPj4gKyAgICBybSAtcmYgIiR7ZGVzdGRpcn0i DQo+PiArfQ0KPj4gKw0KPj4gK2Z1bmN0aW9uIHByb2plY3RfcnVuKCkgew0KPj4gKyAgICB0YXJn ZXQ9IiR7MTo/fSINCj4+ICsgICAgZGVzdGRpcj0iJHtCVUlMRERJUn0vJHt0YXJnZXR9Ig0KPj4g KyAgICAoDQo+PiArICAgICAgICBzb3VyY2UgJHtZT0NUT0RJUn0vcG9reS9vZS1pbml0LWJ1aWxk LWVudiAiJHtkZXN0ZGlyfSIgPiAvZGV2L251bGwgMj4mMQ0KPj4gKw0KPj4gKyAgICAgICAgL3Vz ci9iaW4vZXhwZWN0IDw8RU9GDQo+PiArc2V0IHRpbWVvdXQgMTAwDQo+PiArc3Bhd24gYmFzaCAt YyAicnVucWVtdSBzZXJpYWxzdGRpbyBub2dyYXBoaWMgc2xpcnAiDQo+PiArDQo+PiArZXhwZWN0 X2FmdGVyIHsNCj4+ICsgICAgLXJlICIoLiopXHIiIHsNCj4+ICsgICAgICAgIGV4cF9jb250aW51 ZQ0KPj4gKyAgICB9DQo+PiArICAgIHRpbWVvdXQge3NlbmRfdXNlciAiRVJST1ItVGltZW91dCFc biI7IGV4aXQgMX0NCj4+ICsgICAgZW9mIHtzZW5kX3VzZXIgIkVSUk9SLUVPRiFcbiI7IGV4aXQg MX0NCj4+ICt9DQo+PiArDQo+PiArIyB3YWl0IGluaXRpYWwgbG9naW4NCj4+ICtleHBlY3QgLXJl ICIuKiBsb2dpbjogIg0KPj4gK3NlbmQgInJvb3RcciINCj4+ICtleHBlY3QgLXJlICJyb290QC4q IyAiDQo+PiArDQo+PiArRU9GDQo+PiArICAgIGV4aXQgJD8NCj4+ICsgICAgKSB8fCByZXR1cm4g MQ0KPj4gK30NCj4+ICsNCj4+ICtmdW5jdGlvbiBoZWxwKCkgew0KPj4gKyAgICBjYXQgPDxFT0YN Cj4+ICtVc2FnZTogJHswfSBbVEFSR0VUMV0gW1RBUkdFVDJdDQo+PiArDQo+PiArVGhpcyBzY3Jp cHQgaXMgYnVpbGQgdGhlIHlvY3RvIHhlbi1pbWFnZS1taW5pbWFsIGZvciBkaWZmZXJlbnQgcWVt dSB0YXJnZXRzDQo+PiArYW5kIGlzIHJ1bm5pbmcgaXQgYWZ0ZXIuDQo+PiArV2l0aG91dCBhbnkg dGFyZ2V0IHNwZWNpZmllZCwgYWxsIHN1cHBvcnRlZCB0YXJnZXRzIGFyZSBkb25lLg0KPj4gKw0K Pj4gK09wdGlvbnM6DQo+PiArICAtaCwgLS1oZWxwICAgICAgIFByaW50IHRoaXMgaGVscA0KPj4g KyAgLXYsIC0tdmVyYm9zZSAgICBWZXJib3NlIGJ1aWxkDQo+PiArICAtLWxpc3QtdGFyZ2V0ICAg IExpc3Qgc3VwcG9ydGVkIHRhcmdldHMNCj4+ICsgIC0tY2xlYW4gICAgICAgICAgQ2xlYW4gZXhp c3RpbmcgcHJvamVjdCBiZWZvcmUgc3RhcnRpbmcNCj4+ICsgIC0tbm8tYnVpbGQgICAgICAgRG8g bm90IGJ1aWxkICh0byBydW4gYW4gYWxyZWFkeSBidWlsdCBwcm9qZWN0KQ0KPj4gKyAgLS1uby1y dW4gICAgICAgICBEbyBub3QgcnVuDQo+PiArICAtLW51bS1qb2JzPU5VTSAgIERlZmluZSB0aGUg bnVtYmVyIG9mIHBhcmFsbGVsIGpvYnMgaW4gWW9jdG8uDQo+PiArICAgICAgICAgICAgICAgICAg IERlZmF1bHQ6ICR7QlVJTERKT0JTfQ0KPj4gKyAgLS1kdW1wLWxvZyAgICAgICBPbiBlcnJvciwg ZHVtcCB0aGUgbG9ncyBvbiB0aGUgY29uc29sZQ0KPj4gKyAgLS1pbWFnZT1JTUcgICAgICBZb2N0 byBpbWFnZSBvciBwYWNrYWdlIHRvIGJ1aWxkDQo+PiArICAgICAgICAgICAgICAgICAgIERlZmF1 bHQ6IHhlbi1pbWFnZS1taW5pbWFsDQo+PiArICAtLXhlbi1kaXI9RElSICAgIHBhdGggdG8geGVu IGh5cGVydmlzb3Igc291cmNlIHRyZWUNCj4+ICsgICAgICAgICAgICAgICAgICAgaWYgbm90IHBy b3ZpZGUsIG5vcm1hbCB5b2N0byB2ZXJzaW9uIG9mIHhlbiBpcyBidWlsdA0KPj4gKyAgICAgICAg ICAgICAgICAgICBEZWZhdWx0OiAke1hFTkRJUn0NCj4+ICsgIC0tb3V0LWRpcj1ESVIgICAgZGly ZWN0b3J5IHdoZXJlIHRvIGNyZWF0ZSB0aGUgcHJvamVjdHNzDQo+PiArICAgICAgICAgICAgICAg ICAgIERlZmF1bHQ6ICR7QlVJTERESVJ9DQo+PiArICAtLWxvZy1kaXI9RElSICAgIGRpcmVjdG9y eSB0byBzdG9yZSBsb2dzDQo+PiArICAgICAgICAgICAgICAgICAgIERlZmF1bHQ6ICR7TE9HRElS fQ0KPj4gKyAgLS1jYWNoZS1kaXI9RElSICBkaXJlY3Rvcnkgd2hlcmUgdG8gdGFrZSBhbmQgc3Rv cmUgYnVpbGQgY2FjaGUNCj4+ICsgICAgICAgICAgICAgICAgICAgRGVmYXVsdDogJHtDQUNIRURJ Un0NCj4+ICsgIC0tbGF5ZXItZGlyPURJUiAgZGlyZWN0b3J5IGNvbnRhaW5pbmcgdGhlIGNoZWNr b3V0IG9mIHlvY3RvIGxheWVycw0KPj4gKyAgICAgICAgICAgICAgICAgICBEZWZhdWx0OiAke1lP Q1RPRElSfQ0KPj4gK0VPRg0KPj4gK30NCj4+ICsNCj4+ICtmb3IgT1BUSU9OIGluICIkQCINCj4+ ICtkbw0KPj4gKyAgICBjYXNlICR7T1BUSU9OfSBpbg0KPj4gKyAgICAgICAgLWh8LS1oZWxwKQ0K Pj4gKyAgICAgICAgICAgIGhlbHANCj4+ICsgICAgICAgICAgICBleGl0IDANCj4+ICsgICAgICAg ICAgICA7Ow0KPj4gKyAgICAgICAgLXZ8LS12ZXJib3NlKQ0KPj4gKyAgICAgICAgICAgIFZFUkJP U0U9InkiDQo+PiArICAgICAgICAgICAgOzsNCj4+ICsgICAgICAgIC0tbGlzdC10YXJnZXRzKQ0K Pj4gKyAgICAgICAgICAgIGVjaG8gIiR7VEFSR0VUX1NVUFBPUlRFRH0iDQo+PiArICAgICAgICAg ICAgZXhpdCAwDQo+PiArICAgICAgICAgICAgOzsNCj4+ICsgICAgICAgIC0tY2xlYW4pDQo+PiAr ICAgICAgICAgICAgZG9fY2xlYW49InkiDQo+PiArICAgICAgICAgICAgOzsNCj4+ICsgICAgICAg IC0tbm8tYnVpbGQpDQo+PiArICAgICAgICAgICAgZG9fYnVpbGQ9Im4iDQo+PiArICAgICAgICAg ICAgOzsNCj4+ICsgICAgICAgIC0tbm8tcnVuKQ0KPj4gKyAgICAgICAgICAgIGRvX3J1bj0ibiIN Cj4+ICsgICAgICAgICAgICA7Ow0KPj4gKyAgICAgICAgLS1kdW1wLWxvZykNCj4+ICsgICAgICAg ICAgICBkb19kdW1wPSJ5Ig0KPj4gKyAgICAgICAgICAgIDs7DQo+PiArICAgICAgICAtLW51bS1q b2JzPSopDQo+PiArICAgICAgICAgICAgQlVJTERKT0JTPSIke09QVElPTiMqPX0iDQo+PiArICAg ICAgICAgICAgOzsNCj4+ICsgICAgICAgIC0taW1hZ2U9KikNCj4+ICsgICAgICAgICAgICBidWls ZF9pbWFnZT0iJHtPUFRJT04jKj19Ig0KPj4gKyAgICAgICAgICAgIDs7DQo+PiArICAgICAgICAt LXhlbi1kaXI9KikNCj4+ICsgICAgICAgICAgICBYRU5ESVI9IiR7T1BUSU9OIyo9fSINCj4+ICsg ICAgICAgICAgICBpZiBbICEgLWUgIiR7WEVORElSfS94ZW4vTWFrZWZpbGUiIF07IHRoZW4NCj4+ ICsgICAgICAgICAgICAgICAgZWNobyAiTm8gWGVuIHNvdXJjZSB0cmVlIGluICR7WEVORElSfSIN Cj4+ICsgICAgICAgICAgICAgICAgZXhpdCAxDQo+PiArICAgICAgICAgICAgZmkNCj4+ICsgICAg ICAgICAgICBkb19sb2NhbHNyYz0ieSINCj4+ICsgICAgICAgICAgICA7Ow0KPj4gKyAgICAgICAg LS1vdXQtZGlyPSopDQo+PiArICAgICAgICAgICAgQlVJTERESVI9IiR7T1BUSU9OIyo9fSINCj4+ ICsgICAgICAgICAgICA7Ow0KPj4gKyAgICAgICAgLS1sb2ctZGlyPSopDQo+PiArICAgICAgICAg ICAgTE9HRElSPSIke09QVElPTiMqPX0iDQo+PiArICAgICAgICAgICAgOzsNCj4+ICsgICAgICAg IC0tY2FjaGUtZGlyPSopDQo+PiArICAgICAgICAgICAgQ0FDSEVESVI9IiR7T1BUSU9OIyo9fSIN Cj4+ICsgICAgICAgICAgICA7Ow0KPj4gKyAgICAgICAgLS1sYXllci1kaXI9KikNCj4+ICsgICAg ICAgICAgICBZT0NUT0RJUj0iJHtPUFRJT04jKj19Ig0KPj4gKyAgICAgICAgICAgIDs7DQo+PiAr ICAgICAgICAtLSopDQo+PiArICAgICAgICAgICAgZWNobyAiSW52YWxpZCBvcHRpb24gJHtPUFRJ T059Ig0KPj4gKyAgICAgICAgICAgIGhlbHANCj4+ICsgICAgICAgICAgICBleGl0IDENCj4+ICsg ICAgICAgICAgICA7Ow0KPj4gKyAgICAgICAgKikNCj4+ICsgICAgICAgICAgICBpZiBlY2hvICIk e1RBUkdFVF9TVVBQT1JURUR9IiB8IGdyZXAgLXEgLXcgIiR7T1BUSU9OfSI7IHRoZW4NCj4+ICsg ICAgICAgICAgICAgICAgVEFSR0VUTElTVD0iJHtUQVJHRVRMSVNUfSAke09QVElPTn0iDQo+PiAr ICAgICAgICAgICAgZWxzZQ0KPj4gKyAgICAgICAgICAgICAgICBlY2hvICJVbnN1cHBvcnRlZCB0 YXJnZXQgJHtPUFRJT059Ig0KPj4gKyAgICAgICAgICAgICAgICBleGl0IDENCj4+ICsgICAgICAg ICAgICBmaQ0KPj4gKyAgICAgICAgICAgIDs7DQo+PiArICAgIGVzYWMNCj4+ICtkb25lDQo+PiAr DQo+PiArIyBpZiBubyB0YXJnZXQgaXMgc3BlY2lmaWVkIGJ1aWxkIGFsbCB0YXJnZXRzDQo+PiAr aWYgWyAteiAiJHtUQVJHRVRMSVNUfSIgXTsgdGhlbg0KPj4gKyAgICBUQVJHRVRMSVNUPSIke1RB UkdFVF9TVVBQT1JURUR9Ig0KPj4gK2ZpDQo+PiArDQo+PiArbWtkaXIgLXAgIiR7Q0FDSEVESVJ9 Ig0KPj4gK21rZGlyIC1wICIke0xPR0RJUn0iDQo+PiArbWtkaXIgLXAgIiR7QlVJTERESVJ9Ig0K Pj4gKw0KPj4gKyMgTWFrZSBzdXJlIHdlIGhhdmUgYW4gYWJzb2x1dGUgcGF0aA0KPj4gK1lPQ1RP RElSPSQocmVhbHBhdGggLW0gIiR7WU9DVE9ESVJ9IikNCj4+ICtDQUNIRURJUj0kKHJlYWxwYXRo IC1tICIke0NBQ0hFRElSfSIpDQo+PiArQlVJTERESVI9JChyZWFscGF0aCAtbSAiJHtCVUlMRERJ Un0iKQ0KPj4gK0xPR0RJUj0kKHJlYWxwYXRoIC1tICIke0xPR0RJUn0iKQ0KPj4gK2lmIFsgIiR7 ZG9fbG9jYWxzcmN9IiA9ICJ5IiBdOyB0aGVuDQo+PiArICAgIFhFTkRJUj0kKHJlYWxwYXRoIC1t ICIke1hFTkRJUn0iKQ0KPj4gK2ZpDQo+PiArDQo+PiArIyBDaGVjayB0aGF0IHdlIGhhdmUgYWxs IHRoZSBsYXllcnMgd2UgbmVlZA0KPj4gK2ZvciBmIGluICR7YnVpbGRfbGF5ZXJsaXN0fTsgZG8N Cj4+ICsgICAgaWYgWyAhIC1mICIke1lPQ1RPRElSfS8ke2Z9L2NvbmYvbGF5ZXIuY29uZiIgXTsg dGhlbg0KPj4gKyAgICAgICAgZWNobyAiTGF5ZXIgJHtmfSBtaXNzaW5nIGluICR7WU9DVE9ESVJ9 Ig0KPj4gKyAgICAgICAgZXhpdCAxDQo+PiArICAgIGZpDQo+PiArZG9uZQ0KPj4gKw0KPj4gK2Zv ciBmIGluICR7VEFSR0VUTElTVH07IGRvDQo+PiArICAgIGlmIFsgIiR7ZG9fY2xlYW59IiA9ICJ5 IiBdOyB0aGVuDQo+PiArICAgICAgICBydW5fdGFzayBwcm9qZWN0X2NsZWFuICR7Zn0NCj4+ICsg ICAgZmkNCj4+ICsgICAgaWYgWyAhIC1mICR7QlVJTERESVJ9LyR7Zn0vY29uZi9sb2NhbC5jb25m IF07IHRoZW4NCj4+ICsgICAgICAgIHJ1bl90YXNrIHByb2plY3RfY3JlYXRlICR7Zn0NCj4+ICsg ICAgZmkNCj4+ICsgICAgaWYgWyAtZiAke0JVSUxERElSfS8ke2Z9L2NvbmYvbG9jYWwuY29uZiBd OyB0aGVuDQo+PiArICAgICAgICBpZiBbICIke2RvX2J1aWxkfSIgPSAieSIgXTsgdGhlbg0KPj4g KyAgICAgICAgICAgIHJ1bl90YXNrIHByb2plY3RfYnVpbGQgJHtmfQ0KPj4gKyAgICAgICAgZmkN Cj4+ICsgICAgICAgIGlmIFsgIiR7ZG9fcnVufSIgPSAieSIgXTsgdGhlbg0KPj4gKyAgICAgICAg ICAgIHJ1bl90YXNrIHByb2plY3RfcnVuICR7Zn0NCj4+ICsgICAgICAgIGZpDQo+PiArDQo+PiAr ICAgIGZpDQo+PiArZG9uZQ0KPj4gKw0KPj4gK3ByaW50X3Byb2dyZXNzICJCdWlsZCBDb21wbGV0 ZSAoJHtidWlsZF9yZXN1bHR9IGVycm9ycykiDQo+PiArZWNobw0KPj4gK2V4aXQgJHtidWlsZF9y ZXN1bHR9DQo+PiArDQo+PiBkaWZmIC0tZ2l0IGEvYXV0b21hdGlvbi9idWlsZC95b2N0by95b2N0 by5kb2NrZXJmaWxlLmluIGIvYXV0b21hdGlvbi9idWlsZC95b2N0by95b2N0by5kb2NrZXJmaWxl LmluDQo+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPj4gaW5kZXggMDAwMDAwMDAwMDAwLi41MzUw YmIyYjg3YjcNCj4+IC0tLSAvZGV2L251bGwNCj4+ICsrKyBiL2F1dG9tYXRpb24vYnVpbGQveW9j dG8veW9jdG8uZG9ja2VyZmlsZS5pbg0KPj4gQEAgLTAsMCArMSwxMTQgQEANCj4+ICsjIERvY2tl ciBmaWxlIHRvIGNyZWF0ZSBhbiBlbnZpcm9ubWVudCB0byBidWlsZCB5b2N0byB3aXRoIHZpcnR1 YWxpemF0aW9uDQo+PiArIw0KPj4gKyMgQXJndW1lbnRzIHRoYXQgY2FuIGJlIHBhc3NlZCBkdXJp bmcgaW1hZ2UgY3JlYXRpb24gdXNpbmcgLS1idWlsZC1hcmc6DQo+PiArIyAiaG9zdF91aWQ9JChp ZCAtdSkiOiB0byB1c2UgY3VycmVudCB1c2VyIHVpZCBmb3IgYnVpbGQgdXNlciBpbiB0aGUgaW1h Z2UNCj4+ICsjICJob3N0X2dpZD0kKGlkIC1nKSI6IHRvIHVzZSBjdXJyZW50IHVzZXIgZ2lkIGZv ciBidWlsZCB1c2VyIGluIHRoZSBpbWFnZQ0KPj4gKyMgInVidW50dV92ZXJzaW9uPVZFUlMiOiB0 byBzZWxlY3QgdGhlIHVidW50dSB2ZXJzaW9uIG51bWJlcg0KPiBJcyBpcyB0aGUgY2FzZSwgdGhh dCB0aGlzIGRvY2tlcmZpbGUgYW5kIHRoZSBwYWNrYWdlcyBpbnN0YWxsZWQgd2lsbCB3b3JrIG9u IGFueQ0KPiB2ZXJzaW9uIG9mIHVidW50dSB3ZSB3aWxsIHBhc3MgaGVyZT8gSWYgbm90LCBtYXli ZSB3ZSBzaG91bGQganVzdCBzdGljayB0byAyMi4wNCBhbmQNCj4gbm90IGdpdmUgdGhlIHVzZXIg dGhlIG9wcG9ydHVuaXR5IHRvIGNoYW5nZSB0aGlzLg0KDQpUaGVyZSBpcyBubyBzdXBwb3J0IHJp Z2h0IG5vdyB0byBidWlsZCBmb3IgYSBkaWZmZXJlbnQgdmVyc2lvbiBvZiB1YnVudHUgd2l0aG91 dA0KbW9kaWZ5aW5nIHRoZSBkb2NrZXIgZmlsZS4gSSBrZXB0IHRoYXQgYXMgYXJndW1lbnQgaGVy ZSBiZWNhdXNlIHRoZSBnZW5lcmF0ZWQNCmZpbGUvY29udGFpbmVyIGRvZXMgbm90IGNvbnRhaW4g YW4gdWJ1bnR1IHZlcnNpb24gaW4gaXRzIG5hbWUgc28gY2hhbmdpbmcgdGhlDQp2YWx1ZSBoZXJl IGluIHRoZSBmdXR1cmUgd2lsbCBtYWtlIGl0IGNsZWFyZXIuDQoNCkkgYW0gb2sgdG8gcmVtb3Zl IHRoZSB2YXJpYWJsZSBhbmQgZGlyZWN0bHkgdXNlIHRoZSB2YWx1ZSBpZiB5b3UgdGhpbmsgdGhp cyBpcyBuZWNlc3NhcnkuDQoNCj4gDQo+PiArDQo+PiArIyBVc2Ugc3RhbmRhcmQgdWJ1bnR1IG1p bmltYWwNCj4+ICtBUkcgdWJ1bnR1X3ZlcnNpb249MjIuMDQNCj4+ICtGcm9tICMjRE9DS0VSUExB VCMjdWJ1bnR1OiR1YnVudHVfdmVyc2lvbiBBUyBiYXNlDQo+PiArTEFCRUwgbWFpbnRhaW5lci5u YW1lPSJUaGUgWGVuIFByb2plY3QgIiBcDQo+PiArICAgICAgbWFpbnRhaW5lci5lbWFpbD0ieGVu LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnIg0KPj4gKw0KPj4gK0VOViBERUJJQU5fRlJPTlRF TkQ9bm9uaW50ZXJhY3RpdmUNCj4+ICsNCj4+ICsjIEluc3RhbGwgbWluaW1hbCB1YnVudHUgcmVx dWlyZW1lbnRzIGZvciB5b2N0byBhbmQgb3RoZXIgdG9vbHMgd2UgbmVlZA0KPj4gKyMgU2VlIGh0 dHBzOi8vZG9jcy55b2N0b3Byb2plY3Qub3JnLzQuMC4xL2JyaWVmLXlvY3RvcHJvamVjdHFzL2lu ZGV4Lmh0bWwjYnVpbGQtaG9zdC1wYWNrYWdlcw0KPj4gK1JVTiBhcHQtZ2V0IHVwZGF0ZSAmJiBc DQo+PiArICAgIGFwdC1nZXQgLS1xdWlldCAtLXllcyBpbnN0YWxsIFwNCj4+ICsgICAgICAgIGdh d2sgXA0KPj4gKyAgICAgICAgd2dldCBcDQo+PiArICAgICAgICBnaXQgXA0KPj4gKyAgICAgICAg ZGlmZnN0YXQgXA0KPj4gKyAgICAgICAgdW56aXAgXA0KPj4gKyAgICAgICAgdGV4aW5mbyBcDQo+ PiArICAgICAgICBnY2MgXA0KPj4gKyAgICAgICAgYnVpbGQtZXNzZW50aWFsIFwNCj4+ICsgICAg ICAgIGNocnBhdGggXA0KPj4gKyAgICAgICAgc29jYXQgXA0KPj4gKyAgICAgICAgY3BpbyBcDQo+ PiArICAgICAgICBweXRob24zIFwNCj4+ICsgICAgICAgIHB5dGhvbjMtcGlwIFwNCj4+ICsgICAg ICAgIHB5dGhvbjMtcGV4cGVjdCBcDQo+PiArICAgICAgICB4ei11dGlscyBcDQo+PiArICAgICAg ICBkZWJpYW51dGlscyBcDQo+PiArICAgICAgICBpcHV0aWxzLXBpbmcgXA0KPj4gKyAgICAgICAg cHl0aG9uMy1naXQgXA0KPj4gKyAgICAgICAgcHl0aG9uMy1qaW5qYTIgXA0KPj4gKyAgICAgICAg bGliZWdsMS1tZXNhIFwNCj4+ICsgICAgICAgIGxpYnNkbDEuMi1kZXYgXA0KPj4gKyAgICAgICAg cHl0aG9uMy1zdWJ1bml0IFwNCj4+ICsgICAgICAgIG1lc2EtY29tbW9uLWRldiBcDQo+PiArICAg ICAgICB6c3RkIFwNCj4+ICsgICAgICAgIGxpYmx6NC10b29sIFwNCj4+ICsgICAgICAgIGZpbGUg XA0KPj4gKyAgICAgICAgdmltIFwNCj4+ICsgICAgICAgIGJpc29uIFwNCj4+ICsgICAgICAgIGV4 cGVjdCBcDQo+PiArICAgICAgICBsb2NhbGVzIFwNCj4+ICsgICAgICAgIGxpYmx6NC10b29sIFwN Cj4+ICsgICAgICAgIHpzdGQgXA0KPj4gKyAgICAgICAgb3BlbnNzbCBcDQo+PiArICAgICAgICBs aWJzc2wzIFwNCj4+ICsgICAgICAgIGNhLWNlcnRpZmljYXRlcyBcDQo+PiArICAgICAgICAmJiBc DQo+PiArICAgICAgICBhcHQtZ2V0IGF1dG9yZW1vdmUgLXkgJiYgXA0KPj4gKyAgICAgICAgYXB0 LWdldCBjbGVhbiAmJiBcDQo+PiArICAgICAgICBybSAtcmYgL3Zhci9saWIvYXB0L2xpc3RzKiAv dG1wLyogL3Zhci90bXAvKg0KPj4gKw0KPj4gKyMgVXNlIGJhc2ggYXMgc2hlbGwNCj4+ICtSVU4g cm0gL2Jpbi9zaCAmJiBsbiAtcyBiYXNoIC9iaW4vc2gNCj4+ICsNCj4+ICsjIEZpeCBsb2NhbCBm b3IgeW9jdG8NCj4+ICtSVU4gbG9jYWxlLWdlbiBlbl9VUy5VVEYtOCAmJiB1cGRhdGUtbG9jYWxl IExDX0FMTD1lbl9VUy5VVEYtOCBcDQo+PiArICAgIExBTkc9ZW5fVVMuVVRGLTgNCj4+ICtFTlYg TEFORyBlbl9VUy5VVEYtOA0KPj4gK0VOViBMQ19BTEwgZW5fVVMuVVRGLTgNCj4+ICsNCj4+ICsj IENyZWF0ZSBhIHVzZXIgZm9yIHRoZSBidWlsZCAod2UgZG9uJ3Qgd2FudCB0byBidWlsZCBhcyBy b290KQ0KPj4gK0VOViBVU0VSX05BTUUgZG9ja2VyLWJ1aWxkDQo+PiArQVJHIGhvc3RfdWlkPTEw MDANCj4+ICtBUkcgaG9zdF9naWQ9MTAwMA0KPj4gK1JVTiBncm91cGFkZCAtZyAkaG9zdF9naWQg JFVTRVJfTkFNRSAmJiBcDQo+PiArICAgIHVzZXJhZGQgLWcgJGhvc3RfZ2lkIC1tIC1zIC9iaW4v YmFzaCAtdSAkaG9zdF91aWQgJFVTRVJfTkFNRQ0KPj4gKw0KPj4gKyMgU3dpdGNoIHRvIG91ciB1 c2VyIGluc3RlYWQgb2Ygcm9vdCBhbmQgc3RhcnQgaW4gaXRzIGhvbWUNCj4+ICtVU0VSICRVU0VS X05BTUUNCj4+ICtXT1JLRElSIC9ob21lLyRVU0VSX05BTUUNCj4+ICsNCj4+ICsjIENyZWF0ZSBu ZWVkZWQgZGlyZWN0b3JpZXMNCj4+ICtSVU4gbWtkaXIgLXAgL2hvbWUvJFVTRVJfTkFNRS95b2N0 by1sYXllcnMgXA0KPj4gKyAgICAgICAgICAgICAvaG9tZS8kVVNFUl9OQU1FL3lvY3RvLWNhY2hl IFwNCj4+ICsgICAgICAgICAgICAgL2hvbWUvJFVTRVJfTkFNRS9sb2dzIFwNCj4+ICsgICAgICAg ICAgICAgL2hvbWUvJFVTRVJfTkFNRS9iaW4gXA0KPj4gKyAgICAgICAgICAgICAvaG9tZS8kVVNF Ul9OQU1FL3hlbiAmJiBcDQo+PiArICAgIGNob3duICRVU0VSX05BTUUuJFVTRVJfTkFNRSAvaG9t ZS8kVVNFUl9OQU1FLyoNCj4+ICsNCj4+ICsjIGNsb25lIHlvY3RvIHJlcG9zaXRvcmllcyB3ZSBu ZWVkDQo+PiArUlVOIGZvciByZXAgaW4gXA0KPj4gKyAgICAgICAgICAgICAgICBodHRwczovL2dp dGh1Yi5jb20vb3BlbmVtYmVkZGVkL21ldGEtb3BlbmVtYmVkZGVkIFwNCj4+ICsgICAgICAgICAg ICAgICAgaHR0cHM6Ly9naXQueW9jdG9wcm9qZWN0Lm9yZy9wb2t5IFwNCj4+ICsgICAgICAgICAg ICAgICAgaHR0cHM6Ly9naXQueW9jdG9wcm9qZWN0Lm9yZy9tZXRhLXZpcnR1YWxpemF0aW9uIFwN Cj4+ICsgICAgICAgICAgICA7IGRvIFwNCj4+ICsgICAgICAgIGdpdCAtQyAvaG9tZS8kVVNFUl9O QU1FL3lvY3RvLWxheWVycyBcDQo+PiArICAgICAgICAgICAgY2xvbmUgLWIgIyNZT0NUT1ZFUlNJ T04jIyAtLXNpbmdsZS1icmFuY2ggJHJlcDsgXA0KPj4gKyAgICBkb25lDQo+PiArDQo+PiArIyBU aGUgYnVpbGRlciBzdGFnZSBpcyBidWlsZGluZyBhbiBpbml0aWFsIGNhY2hlIHN0YXRlIHRoYXQg d2UgaW5jbHVkZSBpbiB0aGUNCj4+ICsjIGZpbmFsIGltYWdlDQo+PiArRnJvbSBiYXNlIEFTIGJ1 aWxkZXINCj4+ICsNCj4+ICsjIFRoaXMgc3RlcCBjYW4gdGFrZSBvbmUgdG8gc2V2ZXJhbCBob3Vy cyBkZXBlbmRpbmcgb24geW91ciBkb3dubG9hZCBiYW5kd2l0aA0KPj4gKyMgYW5kIHRoZSBzcGVl ZCBvZiB5b3VyIGNvbXB1dGVyDQo+PiArQ09QWSAuL2J1aWxkLXlvY3RvLnNoIC8NCj4+ICtSVU4g L2J1aWxkLXlvY3RvLnNoIC0tZHVtcC1sb2cgIyNZT0NUT1RBUkdFVCMjDQo+PiArDQo+PiArRnJv bSBiYXNlDQo+PiArDQo+PiArIyBPbmx5IGNvcHkgdGhlIGNhY2hlIHN0YXR1cw0KPj4gK0NPUFkg LS1mcm9tPWJ1aWxkZXIgL2hvbWUvJFVTRVJfTkFNRS95b2N0by1jYWNoZSAvaG9tZS8kVVNFUl9O QU1FL3lvY3RvLWNhY2hlLy4NCj4+ICsNCj4+ICtMQUJFTCBtYWludGFpbmVyLm5hbWU9IlRoZSBY ZW4gUHJvamVjdCAiIFwNCj4+ICsgICAgICBtYWludGFpbmVyLmVtYWlsPSJ4ZW4tZGV2ZWxAbGlz dHMueGVucHJvamVjdC5vcmciDQo+PiArDQo+PiBkaWZmIC0tZ2l0IGEvYXV0b21hdGlvbi9idWls ZC95b2N0by95b2N0by5pbmMgYi9hdXRvbWF0aW9uL2J1aWxkL3lvY3RvL3lvY3RvLmluYw0KPj4g bmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4+IGluZGV4IDAwMDAwMDAwMDAwMC4uMDQwNzZiYzhkMTc0 DQo+PiAtLS0gL2Rldi9udWxsDQo+PiArKysgYi9hdXRvbWF0aW9uL2J1aWxkL3lvY3RvL3lvY3Rv LmluYw0KPj4gQEAgLTAsMCArMSw0MSBAQA0KPj4gKyMgVGhpcyBtYWtlZmlsZSBnZW5lcmF0ZXMg dGhlIGRvY2tlciBmaWxlcyBmb3IgWW9jdG8gYnVpbGRzDQo+PiArIyBUaGUgY29udGFpbmVycyBm b3IgdGhlIGN1cnJlbnQgYXJjaGl0ZWN0dXJlIGFyZSB0aGUgb25lIGJ1aWx0IHVzaW5nIG1ha2Ug YWxsDQo+PiArIyBUbyBidWlsZCBjb250YWluZXJzIGZvciBhIGRpZmZlcmVudCBhcmNoaXRlY3R1 cmUsIHlvdSBuZWVkIHRvIGNhbGwgbWFrZSBmb3INCj4+ICsjIHRoZSBpbWFnZSB5b3Ugd2FudCBl eHBsaWNpdGVseQ0KPiBDb3VsZCB5b3UgcGxlYXNlIGFkZCBhIGRvdCBhdCB0aGUgZW5kIG9mIGVh Y2ggc2VudGVuY2UgYWJvdmUuIFRoaXMgd2lsbCBpbXByb3ZlIHJlYWRhYmlsaXR5Lg0KDQpZZXMg d2lsbCBkby4NCg0KPiANCj4+ICsjIFRoZSBjb250YWluZXJzIGFyZSBuYW1lZCB0aGlzIHdheToN Cj4+ICsjIFlPQ1RPVkVSU0lPTi1UQVJHRVQgZm9yIHg4Nl82NCBob3N0cw0KPj4gKyMgWU9DVE9W RVJTSU9OLVRBUkdFVC1hcm02NHY4IGZvciBhcm02NCBob3N0cw0KPj4gKw0KPj4gKyMgWW9jdG8g dmVyc2lvbnMgd2UgYXJlIGN1cnJlbnRseSB1c2luZw0KPj4gK1lPQ1RPX1ZFUlNJT04gPSBraXJr c3RvbmUNCj4+ICsNCj4+ICsjIFlvY3RvIEJTUHMgd2Ugd2FudCB0byBidWlsZCBmb3INCj4+ICtZ T0NUT19UQVJHRVRTID0gcWVtdWFybTY0IHFlbXVhcm0gcWVtdXg4Ni02NA0KPj4gKw0KPj4gKyMg U3VwcG9ydGVkIEhvc3QgcGxhdGZvcm1zIChob3N0IGFyY2hpdGVjdHVyZSBzcGVjaWZpYyBvbmVz KQ0KPiBUbyBhdm9pZCBtaXNtYXRjaCBcd3J0IHBsYXRmb3JtIHZzIGFyY2hpdGVjdHVyZSBJIHdv dWxkIHN0aWNrIHRvIHRoZSBsYXR0ZXIgb25lLg0KPiBJbiB0aGUgZG9ja2VyIHdvcmxkLCBhcm02 NHY4IGlzIGFuIGFyY2hpdGVjdHVyZSB3aGVyZWFzIGxpbnV4L2FybTY0L3Y4IGlzIGEgcGxhdGZv cm0uDQoNClNvICJ5b2N0byB0YXJnZXTigJ0gYW5kIOKAnGNvbnRhaW5lciBwbGF0Zm9ybeKAnSA/ DQoNCj4gDQo+PiArWU9DVE9fSE9TVFMgPSBhbWQ2NCBhcm02NHY4DQo+PiArDQo+PiArIyBBcmNo aXRlY3R1cmUgd2Ugd2FudCB0byB1c2UgaW4gZ2l0bGFiIENJIChkZXBlbmRzIG9uIHJ1bm5lcnMg YXJjaCkNCj4+ICtDSV9BUkNIID0gYXJtNjR2OA0KPj4gKw0KPj4gK2RlZmluZSBHRU5fRE9DS0VS DQo+PiArIyBNYWtlIGFsbCBpcyBnZW5lcmF0aW5nIHdoYXQgd2Ugd2FudCBpbiB0aGUgQ0kNCj4+ ICtpZmVxICgkKENJX0FSQ0gpLCQoMykpDQo+PiArQ09OVEFJTkVSUyArPSB5b2N0by8kKDEpLSQo MikkKDQpDQo+PiArZWxzZQ0KPj4gK0NPTlRBSU5FUlNfRVhUUkEgKz0geW9jdG8vJCgxKS0kKDIp JCg0KQ0KPj4gK2VuZGlmDQo+PiArDQo+PiAreW9jdG8vJCgxKS0kKDIpJCg0KS5kb2NrZXJmaWxl OiB5b2N0by95b2N0by5kb2NrZXJmaWxlLmluDQo+PiArICAgICAgIGVjaG8gPiAkJEANCj4+ICsg ICAgICAgY2F0ICQkPCB8IFwNCj4+ICsgICAgICAgICAgIHNlZCAtZSAicywjI1lPQ1RPVkVSU0lP TiMjLCQoMSksZyIgfCBcDQo+PiArICAgICAgICAgICBzZWQgLWUgInMsIyNZT0NUT1RBUkdFVCMj LCQoMiksZyIgfCBcDQo+PiArICAgICAgICAgICBzZWQgLWUgInMsIyNET0NLRVJQTEFUIyMsJCgz KS8sZyIgPiAkJEANCj4+ICsNCj4+ICtlbmRlZg0KPj4gKw0KPj4gKyQoZXZhbCAkKGZvcmVhY2gg dmVycywkKFlPQ1RPX1ZFUlNJT04pLFwNCj4+ICsgICAgJChmb3JlYWNoIHRhciwkKFlPQ1RPX1RB UkdFVFMpLFwNCj4+ICsgICAgJChmb3JlYWNoIGhzdCwkKFlPQ1RPX0hPU1RTKSxcDQo+PiArICAg ICQoY2FsbCBHRU5fRE9DS0VSLCQodmVycyksJCh0YXIpLCQoaHN0KSwkKGlmICQoZmlsdGVyIGFt ZDY0LCQoaHN0KSksLC0kKGhzdCkpKSkpKSkNCj4gVGhpcyBjb3VsZCBiZSBhbGlnbmVkIHVuZGVy IGZpcnN0IGZvcmVhY2guIEFsc28gSSB0aGluayB0aGVyZSBpcyBubyBuZWVkIHRvIHRyeSB0byBz aG9ydGVuIHRoZSB2ZXJzaW9uLHRhcmdldCxob3N0Lg0KDQpUaGlzIGlzIHNvbWV0aGluZyB5b3Ug cmVxdWVzdGVkIG1lIGluIG9yZGVyIHRvIGhhdmUgY29udGFpbmVyIG5hbWVzIGZvciB5b2N0byBj b2hlcmVudA0Kd2l0aCBvdGhlciB4ZW4gY29udGFpbmVycyAoaWUgb25seSBoYXZlIHRoZSAtYXJt NjR2OCBzdWZmaXggZm9yIGFybSkuDQoNCkRvIHlvdSB3YW50IG1lIHRvIHJldmVydCB0aGlzIGFu ZCBoYXZlIG5hbWVzIGNvbnRhaW5pbmcgdGhlIGFtZDY0IHN1ZmZpeCA/DQoNClRoYW5rcyBmb3Ig dGhlIHJldmlldw0KDQpDaGVlcnMNCkJlcnRyYW5kDQoNCj4gDQo+PiAtLQ0KPj4gMi4yNS4xDQo+ PiANCj4gDQo+IH5NaWNoYWwNCg0K From xen-devel-bounces@lists.xenproject.org Fri Nov 18 11:46:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 11:46:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445619.700879 (Exim 4.92) (envelope-from ) id 1ovzpc-00012i-Gu; Fri, 18 Nov 2022 11:46:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445619.700879; Fri, 18 Nov 2022 11:46:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovzpc-00011w-CT; Fri, 18 Nov 2022 11:46:52 +0000 Received: by outflank-mailman (input) for mailman id 445619; Fri, 18 Nov 2022 11:46:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovzpb-0000xU-Iw for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 11:46:51 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20630.outbound.protection.outlook.com [2a01:111:f400:fe5b::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id af16e647-6736-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 12:46:49 +0100 (CET) Received: from BN0PR04CA0153.namprd04.prod.outlook.com (2603:10b6:408:eb::8) by CH0PR12MB5058.namprd12.prod.outlook.com (2603:10b6:610:e1::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 11:46:46 +0000 Received: from BN8NAM11FT095.eop-nam11.prod.protection.outlook.com (2603:10b6:408:eb:cafe::53) by BN0PR04CA0153.outlook.office365.com (2603:10b6:408:eb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 11:46:46 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT095.mail.protection.outlook.com (10.13.176.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 11:46:44 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 05:46:44 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 05:46:07 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 05:46:05 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af16e647-6736-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D6dSACjMvHcoDfSOd7uN2KwloXX3sZ6QNv+WWwNAXGIBZ41ycS94ghmKPVILN8OpiQKvKDyyYKzPbea+gJ2+VVqm/qTLic8gO5GYGDcoAjldR2UR7SbY1t6aIVPkZzhZ4MiEGrT04r9g1rmNyIJJJyA3T+gmZSl9tBA2nI6HJTgYPzZ/JktQf3W6PQSyl6gA0vHOgoW7iHkzc4v7aHQE8VQ8EHner0CgPRQkRr3DrphjcIKk7zQy1FF2byyI9GdOWFksCpelaKzStmCohuy+IMTk20jwKz1GiFmv0XQDmOJvqebr+QztKnbvjqmLkt8wBuLwsZvNhb4CjDRbaBC7xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WCabUovbIK/LcTCWyof1xhmRsubFjNLqtDEaA0izGK8=; b=DBMxWf6SAREXzrIt0XLTORldGyYzm/q7+sM2Bnw70HEdVps7DR7i9ntHLkBdTmlLxexiDmGLA3JizCxraV044IsZPUje+BdgwzPJs34vmuiI37YDWuHs/Faj86s1nUF3T7IeVauN3auW93ZHJmzKyzrxgd4xZqmcaEofKYE6LIemDEq5tBkDwsnAlHRu+OABdV6LFh94wZOOeDeq7l+GAzpBA0X1QmpqzecOD4YuSOZ7cIN42SIBjtSV5HghvhdiVweMNOZHooU8Z2BDpvhm497yZW+Y6P777MVaEFH3op/s1Uo36TBq4bfFbo900af0DqkbmSZUxBBXBmcuI+/S6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WCabUovbIK/LcTCWyof1xhmRsubFjNLqtDEaA0izGK8=; b=a6Xe14efqJAOV/uGQozIDPXCokB/ZbbO7j7g1t7OU+qXv32kcBWQ6o2b1kFkOLhnvQ/JKuV8RVHf9rmvQmz88dF0SvpKq/mY1E+BcOIkepzDjwxcJd6gL7XpPs82KWPf55S7teCQhIm35GutbsdyVzP7UeNG89wCij/NH6tlIIg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] docs/misc/arm: Update references to Linux kernel docs Date: Fri, 18 Nov 2022 12:45:54 +0100 Message-ID: <20221118114554.20696-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT095:EE_|CH0PR12MB5058:EE_ X-MS-Office365-Filtering-Correlation-Id: 55514897-b243-4a99-2213-08dac95a914f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +K+Mc8xL6doJJJT4C+t2Tfnh2iZ38Gyo6fZu8FYNSeDJ132aMrWvk/0JdSMgN/6YNGc8ojhvJf6HPA3gd7816TJVMcFO/F3l0LXSYOuAMc9rWrwkc4060PUvYCp1qSwFAl3pFCCYkenPY4TandB4EfQGQ+eBeNXEK3QVFZkbhRcRg2LUDm64vyzjNC1OluvRU13avSon26V5SwO6z1gm/9vc3GS/lySnWASdksBa/UIUtGIzb2M6KGmBAC3X+OZP359kZ/0gJ1DHz4oJfJU5Glkr01sJD2zLcCmLas8TB3JHSfyYNsOSuI1sHID5N6geSu09bLylYCyxA50CC46iyojnVbVBQgIWHDYqGjFV44eze8EoidEduJxQyJD9UYHI1I2SGL0DXfIyiLGEa2z28EVw8Sz6nB/p121AttLC0Nc044dOA2Sf06fItj4pYSjyzrXiY68QWX4KlS7buOxKVZu484RToUUne9DlFW42LK1Rde7ILrJmNjjlQg7/iMAhd0tkV9m56OykKcwv0oYZXA7vhn9NRmgvVunM6AQLOissAV9qz45ethFKQnMXnv8SY4TVKdGMm6gIlvdMdjIZi0HKBvWnQnC98el7Z5oFdzOyvBL4robm89Zlcr3zJZZvTPAgIFJ7aoaAKm90Uev9Dyz0ATPRSTlomwhzf19gubIRlC3nnSelmzJQ/XlIc/CntlMwd4uVqt2h/a74Flh0sK2NXXggIl0b9ambHWnw/K9meP/Ha/qMiMvcFkWcno3kTWDmFKOzMZqSEwI90WYuRYiDei7O6BW7vxztEsLSQ1UNSirthvJcxEVK8QHk99va X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(376002)(136003)(451199015)(40470700004)(46966006)(36840700001)(478600001)(316002)(2906002)(26005)(6916009)(54906003)(70206006)(8676002)(70586007)(4326008)(41300700001)(2616005)(966005)(5660300002)(8936002)(186003)(1076003)(44832011)(47076005)(336012)(83380400001)(19625735003)(426003)(36860700001)(36756003)(86362001)(40480700001)(82310400005)(82740400003)(6666004)(40460700003)(81166007)(356005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 11:46:44.7999 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55514897-b243-4a99-2213-08dac95a914f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT095.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5058 Some time ago, Linux switched the format of docs to ReST and the format of device-tree bindings to json-schema. Signed-off-by: Michal Orzel --- docs/misc/arm/booting.txt | 8 ++++---- docs/misc/arm/passthrough.txt | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/misc/arm/booting.txt b/docs/misc/arm/booting.txt index d3f6ce4755f6..3e0c03e06596 100644 --- a/docs/misc/arm/booting.txt +++ b/docs/misc/arm/booting.txt @@ -34,8 +34,8 @@ Xen relies on some settings the firmware has to configure in EL3 before starting * The bit SCR_EL3.HCE (resp. SCR.HCE for 32-bit ARM) must be set to 1. -[1] linux/Documentation/arm/Booting -Latest version: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm/Booting +[1] linux/Documentation/arm/booting.rst +Latest version: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm/booting.rst -[2] linux/Documentation/arm64/booting.txt -Latest version: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm64/booting.txt +[2] linux/Documentation/arm64/booting.rst +Latest version: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm64/booting.rst diff --git a/docs/misc/arm/passthrough.txt b/docs/misc/arm/passthrough.txt index 219d1cca571b..4f0a024818a2 100644 --- a/docs/misc/arm/passthrough.txt +++ b/docs/misc/arm/passthrough.txt @@ -71,8 +71,8 @@ Please refer to your platform docs for the MMIO ranges and interrupts. They can also be calculated from the original device tree (not recommended). You can read about the "interrupts" property format in the device tree bindings of the interrupt controller of your platform. For -example, in the case of GICv2 see [arm,gic.txt]; in the case of GICv3 -see [arm,gic-v3.txt] in the Linux repository. For both GICv2 and GICv3 +example, in the case of GICv2 see [arm,gic.yaml]; in the case of GICv3 +see [arm,gic-v3.yaml] in the Linux repository. For both GICv2 and GICv3 the "interrupts" property format is the same: the first cell is the interrupt type, and the second cell is the interrupt number. Given that SPI numbers start from 32, in this example 80 + 32 = 112. @@ -187,6 +187,6 @@ assign a network card to a dom0-less guest on Xilinx Ultrascale+ MPSoC: }; -[arm,gic.txt]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt -[arm,gic-v3.txt]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt +[arm,gic.yaml]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml +[arm,gic-v3.yaml]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml [xl.cfg]: https://xenbits.xen.org/docs/unstable/man/xl.cfg.5.html -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 11:46:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 11:46:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445618.700873 (Exim 4.92) (envelope-from ) id 1ovzpc-0000yK-4S; Fri, 18 Nov 2022 11:46:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445618.700873; Fri, 18 Nov 2022 11:46:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovzpc-0000yD-15; Fri, 18 Nov 2022 11:46:52 +0000 Received: by outflank-mailman (input) for mailman id 445618; Fri, 18 Nov 2022 11:46:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovzpa-0000h4-Us for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 11:46:51 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20630.outbound.protection.outlook.com [2a01:111:f400:fe5b::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa95d275-6736-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 12:46:42 +0100 (CET) Received: from BN9PR03CA0169.namprd03.prod.outlook.com (2603:10b6:408:f4::24) by PH8PR12MB6723.namprd12.prod.outlook.com (2603:10b6:510:1ce::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Fri, 18 Nov 2022 11:46:46 +0000 Received: from BN8NAM11FT005.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f4:cafe::3e) by BN9PR03CA0169.outlook.office365.com (2603:10b6:408:f4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 11:46:45 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT005.mail.protection.outlook.com (10.13.176.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 11:46:45 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 05:46:44 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 03:46:37 -0800 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 05:46:36 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa95d275-6736-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U7e/q7N9E6KrBG5KRZAtP6ajhNCSnEA4vVie7Hlrdc2UWhAw8MQPaWBLGElTjN3xtTNU8sTdm6STP0af5/H1Z+QWzWlf+68CZxpoUsE0Q8QW7GP60lb+MyluSOFzWFJsleuXPZf9RvZSEyBPDGjm+1x5giW3rqkDU0rCOl4Tx9umeKDY0Ffuwr5imntY6EmLBEbhoLbd+G68s6S2GsSFtP2xd8ihnIdQEgMrv4bZExAEHwP7dOM9rUD7FCTwDe9XYzSHhakmIEe6PMwSj5Gd8y9kOK2/ByaU6ZiEgu5KnBj4LgYW/J1MZO9+TfUcPmmpgM4xwjIAuZEkwmWOd6IAxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mljmr6w6YFyY1nsQNJffwUBvk7mfAY2MBuN66UsplmA=; b=H+B5SP9mUXEGN2H3I5nuKPdAmfxdPGdoy5ctMx0l+g3EATDWezeQdu/JlR9DjW4eYybzBPpm+yEJhkBPrbe4fBUD/v3JRZIqflmjupys8eWUcoxEP5srzIEKdYkYWrAvuzKmL4PAJm57xBosuRQuEgW785BPek907f8tfkR93DQxeX3fVMJW5OnSWlajV6P9yQSD+SJ98feFUIPB+SacWQmCf4SkDX7z+xcQOOF06Qd/wwqDnmX61sGaDaUO9G3xKSeU8mtOSwiMNnWvWlHSrJOkNuK1V135ofnrI7UrxJGSzbKN0g0zZ6K3sSKEoOSrmNGSohxnyutxcejiz8OHdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mljmr6w6YFyY1nsQNJffwUBvk7mfAY2MBuN66UsplmA=; b=G1/1bZRrUg+ZI7LpOY5FGIENu03rkRW5bJSZp2WBl/Fx328p0hjTpLT6nVfuRQ3IjFiGl1EQYEgx17lw0LzyUOxd0JI2AYWc1lx4S6DGI+fI3U4Uu+EauOuXB+BPYBrQ6jggnz2x2/vmAvLtEcVBMc5J7LE41K4JNj65xxvR4lU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 1/3] xen/arm: Drop early_uart_init macro from debug-meson.inc Date: Fri, 18 Nov 2022 12:46:16 +0100 Message-ID: <20221118114618.20754-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221118114618.20754-1-michal.orzel@amd.com> References: <20221118114618.20754-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT005:EE_|PH8PR12MB6723:EE_ X-MS-Office365-Filtering-Correlation-Id: 88f6f17a-6641-4e71-4d5c-08dac95a91c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HSsOzed7LukJXNSRm1HmxGogaM08uhyORH4nUeb7I+okBxTtuGbnJfNJhJOOJGvUG3tGFR1xxYRkOBpV2QPBZOwu461Yo6e2mS+lhNGuoawskSH4/j0lekoSgFJ9/k4pEaYEV77ZHp6kr4CjqlJ2hI+lRWBclyZXMkg1ddcbjFqeBsZ5cHdKPIlnWOyCZ/IA9WTG9+jlyy5X74i6ucsKW8oZ+ZpVzJLLK3symBflX8n6au4KhfRKllrlJ2wI1psDeNHI+syq6ScHNggRfkw7F1yczoggy++tOX/XaXp45hUtQ9En2G/rr6JBdnk6L+mmO2cUaILY4MNiZrosCXYahccSOrI0shw3eoGS9NnTQNiaiRfATo58i9wqvXeS5DXCqcXcTEa0A5mGpOw2d0U+GI7tWyI9uRITrckF6px8CnVJTFYRQHCe+WaK3l1lLFa55sMH41MIBabQuc/kVv8wMcTlS4R4HeUiLD0aSo2+grA5Gyrct7SXUjq0hTv0vJApx1jE80ptMANxVk1d6y9j0/KjhKhZKglFGunHwhmhfLX/3sxxijQ3zY5eNrRxgWoDe/GcQolSbJHg7n8J3aKM+lkOYZROjVqN5HfoXGEbWGtjd68jkPZj1jWJBTw9lvlvf0lvqQj109mA5G/THWjsRMkEvHgUv2gvAUGwFhHmP+DqS6Z6R+DBSNUlCp1n0iJdK83P6tsJ3pXCRROretVOUwDEal0QyIDqDLtUQfxr/bE= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(36860700001)(40480700001)(86362001)(36756003)(40460700003)(81166007)(356005)(82740400003)(82310400005)(26005)(6666004)(6916009)(54906003)(44832011)(4744005)(8936002)(336012)(47076005)(186003)(1076003)(5660300002)(83380400001)(426003)(2906002)(8676002)(4326008)(70586007)(316002)(478600001)(2616005)(70206006)(41300700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 11:46:45.5875 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88f6f17a-6641-4e71-4d5c-08dac95a91c7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT005.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6723 early_uart_init macro is only used if CONFIG_EARLY_UART_INIT is set. This config option depends on EARLY_UART_PL011, so there is no point in defining it for MESON, especially if it is empty. Remove it and adapt the existing comment. Signed-off-by: Michal Orzel --- xen/arch/arm/arm64/debug-meson.inc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/arm64/debug-meson.inc b/xen/arch/arm/arm64/debug-meson.inc index e1a8fa8ab9c4..e65e1ccde482 100644 --- a/xen/arch/arm/arm64/debug-meson.inc +++ b/xen/arch/arm/arm64/debug-meson.inc @@ -23,9 +23,10 @@ #define AML_UART_TX_FIFO_FULL 21 -.macro early_uart_init xb, c -/* Uart has already been initialized by Firmware, for instance by TF-A */ -.endm +/* + * No need for early_uart_init, as UART has already been initialized + * by Firmware, for instance by TF-A. + */ /* * MESON UART wait UART to be ready to transmit -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 11:46:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 11:46:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445620.700895 (Exim 4.92) (envelope-from ) id 1ovzpf-0001XO-U4; Fri, 18 Nov 2022 11:46:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445620.700895; Fri, 18 Nov 2022 11:46:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovzpf-0001XF-QK; Fri, 18 Nov 2022 11:46:55 +0000 Received: by outflank-mailman (input) for mailman id 445620; Fri, 18 Nov 2022 11:46:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovzpe-0000h4-9v for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 11:46:54 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on20602.outbound.protection.outlook.com [2a01:111:f400:7eb2::602]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ac8b951a-6736-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 12:46:45 +0100 (CET) Received: from BN0PR04CA0173.namprd04.prod.outlook.com (2603:10b6:408:eb::28) by DM8PR12MB5414.namprd12.prod.outlook.com (2603:10b6:8:3e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 11:46:47 +0000 Received: from BN8NAM11FT095.eop-nam11.prod.protection.outlook.com (2603:10b6:408:eb:cafe::d4) by BN0PR04CA0173.outlook.office365.com (2603:10b6:408:eb::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 11:46:47 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT095.mail.protection.outlook.com (10.13.176.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 11:46:47 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 05:46:45 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 03:46:36 -0800 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 05:46:35 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac8b951a-6736-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mhpX5Q3hHPKSqTwefrWXTlpxiQc2JzLbfZsC3cLyVMPJCS/dT9DlVGaEH1+nRykMNI/Kef1mULbiCrbxL6vVZQCJ7fNJ6a7oWJLSzIIVcain9yxtWXh7VJYg7TQy7iUqGZ6N5L5Ebm/Sk2sNJ29mDBC4/TlIU8sion4dPM7m5roebZeMnbibnbjM3Wq+fwdNHRjMeBjm9smhR1buT8sRdOblk3TAHrKW4AtjLQ1dBY4JG8fdkYQuUkjpkCIvIGRvhipVn/uo0D3tCYHfWbyDEiXw+L76rNatVe7C5TdPTfJiTgGSq5LyjkfjkZpHuwXBtMQeKhsGe4hn/DJBCAxD0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i9KnuJkP21+QZx681R7RotNsZmP72uq/NRP3ENsO2ho=; b=NVrIUG5Hx+3EoAN4UTrHf3Kn4Tn5zfYNdS1chYy1d7EMFqgKu44EQf+V43QF81svoyE/2CVd7hIspyfsTkR+O5+LL/xJ/W9dOuhOVLaJh1xeRbH3uxH2YzlPiEyD39BswYDxL/CtnkcA8jjlcblPySZdowvKoy+u5r/57GFq58jzK8PZtA47rWeXcP3NkuQG6h3DcHnNOMzs4ILzprmk71SzKgu0wNxQwDd7J8x9ER+NUZg8JJg7rCOK8WRZEu4BrU9Kkudc9HnbHOoRvUqsW0bZXo7gDDyxCInkPIBcYQofcShnlVsd3lqKx8fkaoUaLBNUkQmPnu9s+FReW1Vy8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i9KnuJkP21+QZx681R7RotNsZmP72uq/NRP3ENsO2ho=; b=Vd5wOAAXos2Gnci50Wd/uO7IW3U7Wh1DICMzk1tjsWpBDP03d7urVRgDkWs4BfyFV1tK1zd486BTq18vkBYJuOuicAprsDiKZVyeeUCJL80p0jaxazDooHlgMCqysb3uxBnmo8YETzs/2CqDxMdDNJBAnGM3ayASXhYjsx4xdE0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 0/3] Early printk code cleanup Date: Fri, 18 Nov 2022 12:46:15 +0100 Message-ID: <20221118114618.20754-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT095:EE_|DM8PR12MB5414:EE_ X-MS-Office365-Filtering-Correlation-Id: 84d4718d-2f90-4b6e-a328-08dac95a92fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rtK2GVtnTxI9gpVodZngrKF1BghG6asdbTQx6m107WeGOu7+kOO2DQC9n8/of5NQyY8A5FsRL/fjgVo9ioGAH1Tp8w2wTLX2qsPP+aennpXkjf+VG1PVxcxA9v+fQe6ZUW75C0eyuddu0YdsukQzU/ZOV/uKOez9Ml4MsdeukNxvWfz371oZ4w3DTGLEgT4TguvKKIWxhbvvbNx3mvv/UHyhLfRphcjm0YbsJdg2+YEbcGSjIL3iYLD453OHrNELvaoJhW8WmLYJ3bNgq2UM8rCemqqnLZ45oAYwu+UV9w/WuiD5vHtEaOcU9HCTR3RbkozbCdWs/lTMmP6Igc8Dq+0KvHfkvD8wyWUFWSCZtTtND2nm49FjqohqsQPqxW/wrDRP5oIb39YnvLlqQ2gkaUU12sMxfsdehHsBR2grU7set2NcgbVZU4vKGHG0CAdIZx0SVvnWlRI0dIiPz6rc3ddGQNCVivntOZ8e2611k3SK3Wvbqu/yoWeTcrFpW5dRgU0sQNlp5UxYnYhqQYMuy7PQUVmLY/0I7dUQonavS0DIQ2WT2OzgQaLmsFqXuEDZVvHnqoMrLt4tmh5HbbdnEmFLJrtGfmFAxigqLo6BzjwNR1k8fFHRy1ge2nPnft3CqLxAIV8apbGovVvY796CvAYOkiBYtDTBeG25/1fVvoS1WnZIELXd9HWcJKTTOL6SFNmY6cWjeHE77QvImTxYmTUpt1pOtVJ9+mZEFc9N6EY= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(136003)(376002)(451199015)(46966006)(36840700001)(40470700004)(36756003)(82740400003)(86362001)(2906002)(44832011)(4326008)(8676002)(8936002)(81166007)(356005)(6916009)(4744005)(36860700001)(83380400001)(54906003)(336012)(1076003)(426003)(186003)(2616005)(47076005)(478600001)(40480700001)(70206006)(70586007)(5660300002)(82310400005)(316002)(41300700001)(6666004)(40460700003)(26005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 11:46:47.6435 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 84d4718d-2f90-4b6e-a328-08dac95a92fe X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT095.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5414 This patch series performs simple early printk code cleanup around PL011. No functional changes has been made. Michal Orzel (3): xen/arm: Drop early_uart_init macro from debug-meson.inc xen/arm: debug-pl011.inc: Use macros instead of hardcoded values xen/arm: Define WLEN_8 macro and use it in debug-pl011 xen/arch/arm/arm32/debug-pl011.inc | 2 +- xen/arch/arm/arm64/debug-meson.inc | 7 ++++--- xen/arch/arm/arm64/debug-pl011.inc | 22 ++++++++++++---------- xen/arch/arm/include/asm/pl011-uart.h | 1 + 4 files changed, 18 insertions(+), 14 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 11:46:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 11:46:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445617.700861 (Exim 4.92) (envelope-from ) id 1ovzpY-0000hL-SQ; Fri, 18 Nov 2022 11:46:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445617.700861; Fri, 18 Nov 2022 11:46:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovzpY-0000hE-Pk; Fri, 18 Nov 2022 11:46:48 +0000 Received: by outflank-mailman (input) for mailman id 445617; Fri, 18 Nov 2022 11:46:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovzpX-0000h4-4a for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 11:46:47 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20603.outbound.protection.outlook.com [2a01:111:f400:7e88::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a7a206c2-6736-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 12:46:35 +0100 (CET) Received: from BN0PR04CA0184.namprd04.prod.outlook.com (2603:10b6:408:e9::9) by PH8PR12MB6865.namprd12.prod.outlook.com (2603:10b6:510:1c8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 11:46:40 +0000 Received: from BN8NAM11FT108.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e9:cafe::d4) by BN0PR04CA0184.outlook.office365.com (2603:10b6:408:e9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 11:46:40 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT108.mail.protection.outlook.com (10.13.176.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 11:46:40 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 05:46:39 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 05:46:38 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7a206c2-6736-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eezJC3BFbL/+SXrGTOSCReSCmJzQJJFld35SSbMfGpG3ceWahRo7Wr7JrmONts4DjGrEAIg0dHJCjYnauhgDHlbL7oSPXrbUkX7Foir6JYB1kpgwW1JY4mxCQhI9SrEjOgcnJzDPzsCPXb8m1sSVlOVgvGNqMnyyiCsKS9GwhKAoLyVifPtluljmegygf+VF/P9uDexvfLBG3hJHsP5yn2MgtKbwm7iuD1pi4PHIXkw9jCJshXGI8U50/hOEQpyZAun9R/srLSe+o1wwC139y6L9PVJLdYeeYODEdpisTDB8Rr84JiKLkVJkAfANSWY1BIrJnX4xY+Hx2AcS43aMmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+M+4H7JP9TPokpt207QPaKodTXJurywMQrtxzR4L+NM=; b=fpq9OTChNNsDJ9pK1AOz1JeT0vHcd5itbBoDprjk9P9DHpdgJOOPSHzc9+WxccvXA6JSOn6f7bfj+KeiJy+1twWGmrZV3Ez8v7UsJp+OcvrHXmPvEF0HdDm3ZZ1PV0Pe0AIxFpkfSAhp65dQEWd+iaSrh3za2pHhAxAQ1X4Iv2m3cB0rb4aOF4Jw5/3HAifAXLOuamz0hKWOvcOmtD6BjPL/5KaMzPbIDS4oySOlp0qXKYQZNZD358lPPekoweXs6rUz9LabXH1C9qSvHe1oS2VLCWD6HtE401sD3WWG8KOtrBQm3sJ84+Pcq7/2yQZ5BBFph0G9Ir0Z/Tc9Mt3DKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+M+4H7JP9TPokpt207QPaKodTXJurywMQrtxzR4L+NM=; b=f0bqYLDx0NIAzf18YVjniYL+Lc+2ExZqGjR1xBtICbm8JRg3xq5zLkAcUJZx0iXckT+GqD9iyDv9hMM7E0sXQ/5TKLiJUSxnClS2SxiqiYwvpfuhVvT5nOc4Llanl5NqiWXX9Z/lIPMqp8XWfdcHBLvtno9qN9bshq26ghCdJ5Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Luca Fancellu , Julien Grall Subject: [PATCH 2/3] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values Date: Fri, 18 Nov 2022 12:46:17 +0100 Message-ID: <20221118114618.20754-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221118114618.20754-1-michal.orzel@amd.com> References: <20221118114618.20754-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT108:EE_|PH8PR12MB6865:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f95dd7c-98b6-44ff-3b18-08dac95a8e96 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OFz061r2jyiVH/8HU7QvV5MCbQWNt8JUUyPL7MGrMRIY/W+nzjFcFOK4Lg7JwzpSCBua46fmbHcXei9PxfnG5X0pDsjC6g+/P+a88UmyH2OpOxJc6UhqtJTMGUa9vCY07GwcShwZTFq12U3ulT+2C6YBi4hjtFnBJOdJxYTUF9CfrCqpWxzNAgy/gXs/YBBj8N3WF4CemQhBBUsyi6hDl+zh9NLWw5gy6yogfynB0hKNQDluoW2gA/+bF1FTn4X9dBmlxArTsFDFSNOVziX5j7Cihm3PmJkNcvLRGYG4KQg0NmotmDbLfsmHuQIwVpmQMhtYKTFn3Mq0mEKCQodkTTnY/XNNDk8Kk+jzagLWsSLHxaQua5jqe38Ua6/2lLlFtd6m3U1GeiF+ly2nixmMddUDkskp5q/BMw3bq+u8211xlKitStrBMddrYAZMaRjSc6P8jTohwamwa40zCJLSZ4kFjbOzX5wSrwum4EgySO/3M2rYpqDtz5kQ7AW8IPZk4jf/r5c8z+5JCz1sMOPn5MhN03FwavK54mZhy6z7wHh5VDVsA4QpmyRWV9Hmtxfakz359Li4y/LGT8xoTvkTZw4QiPLthFYc2BzEQhEV4XKFya334gHakQ4m2PaFEk1Epb/ASLAIP+6ChlQXZUT4OE3B+8u4+9LfzgZMYEMF/9YmuDtarngM1fLO71xqe+IGuL0ljMAxHRZZaqtcJM3Ec3vWLzOJGhhWxvz4UcAUgpQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(376002)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(54906003)(478600001)(47076005)(316002)(70586007)(6666004)(26005)(70206006)(6916009)(41300700001)(4326008)(8676002)(8936002)(1076003)(2616005)(44832011)(5660300002)(336012)(186003)(2906002)(83380400001)(426003)(36860700001)(40480700001)(82310400005)(36756003)(86362001)(40460700003)(82740400003)(81166007)(356005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 11:46:40.2171 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9f95dd7c-98b6-44ff-3b18-08dac95a8e96 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT108.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6865 Make use of the macros defined in asm/pl011-uart.h instead of hardcoding the values. Also, take the opportunity to fix the file extension in a top-level comment. No functional change intended. Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu Acked-by: Julien Grall --- This patch has already been reviewed/acked when pushed as a standalone one. Added to the series for ease of merging. --- xen/arch/arm/arm64/debug-pl011.inc | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/arm64/debug-pl011.inc b/xen/arch/arm/arm64/debug-pl011.inc index 1928a2e3ffbb..d82f2f1de197 100644 --- a/xen/arch/arm/arm64/debug-pl011.inc +++ b/xen/arch/arm/arm64/debug-pl011.inc @@ -1,5 +1,5 @@ /* - * xen/arch/arm/arm64/debug-pl011.S + * xen/arch/arm/arm64/debug-pl011.inc * * PL011 specific debug code * @@ -16,6 +16,8 @@ * GNU General Public License for more details. */ + #include + /* * PL011 UART initialization * xb: register which containts the UART base address @@ -23,13 +25,13 @@ */ .macro early_uart_init xb, c mov x\c, #(7372800 / CONFIG_EARLY_UART_PL011_BAUD_RATE % 16) - strh w\c, [\xb, #0x28] /* -> UARTFBRD (Baud divisor fraction) */ + strh w\c, [\xb, #FBRD] /* -> UARTFBRD (Baud divisor fraction) */ mov x\c, #(7372800 / CONFIG_EARLY_UART_PL011_BAUD_RATE / 16) - strh w\c, [\xb, #0x24] /* -> UARTIBRD (Baud divisor integer) */ + strh w\c, [\xb, #IBRD] /* -> UARTIBRD (Baud divisor integer) */ mov x\c, #0x60 /* 8n1 */ - str w\c, [\xb, #0x2C] /* -> UARTLCR_H (Line control) */ - ldr x\c, =0x00000301 /* RXE | TXE | UARTEN */ - str w\c, [\xb, #0x30] /* -> UARTCR (Control Register) */ + str w\c, [\xb, #LCR_H] /* -> UARTLCR_H (Line control) */ + ldr x\c, =(RXE | TXE | UARTEN) + str w\c, [\xb, #CR] /* -> UARTCR (Control Register) */ .endm /* @@ -39,8 +41,8 @@ */ .macro early_uart_ready xb, c 1: - ldrh w\c, [\xb, #0x18] /* <- UARTFR (Flag register) */ - tst w\c, #0x8 /* Check BUSY bit */ + ldrh w\c, [\xb, #FR] /* <- UARTFR (Flag register) */ + tst w\c, #BUSY /* Check BUSY bit */ b.ne 1b /* Wait for the UART to be ready */ .endm @@ -50,7 +52,7 @@ * wt: register which contains the character to transmit */ .macro early_uart_transmit xb, wt - strb \wt, [\xb] /* -> UARTDR (Data Register) */ + strb \wt, [\xb, #DR] /* -> UARTDR (Data Register) */ .endm /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 11:47:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 11:47:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445629.700905 (Exim 4.92) (envelope-from ) id 1ovzq4-0002jQ-6A; Fri, 18 Nov 2022 11:47:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445629.700905; Fri, 18 Nov 2022 11:47:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovzq4-0002jJ-2g; Fri, 18 Nov 2022 11:47:20 +0000 Received: by outflank-mailman (input) for mailman id 445629; Fri, 18 Nov 2022 11:47:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovzq2-0000xU-Oh for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 11:47:18 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20603.outbound.protection.outlook.com [2a01:111:f400:7eab::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bf4cae0c-6736-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 12:47:17 +0100 (CET) Received: from BN0PR04CA0167.namprd04.prod.outlook.com (2603:10b6:408:eb::22) by BL1PR12MB5126.namprd12.prod.outlook.com (2603:10b6:208:312::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 11:47:14 +0000 Received: from BN8NAM11FT095.eop-nam11.prod.protection.outlook.com (2603:10b6:408:eb:cafe::1e) by BN0PR04CA0167.outlook.office365.com (2603:10b6:408:eb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 11:47:13 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT095.mail.protection.outlook.com (10.13.176.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 11:47:13 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 05:46:45 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 05:46:41 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 05:46:40 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf4cae0c-6736-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DNslExaHwLxCIlRRrIFAKZ+bOJn4Hpf+eBD+YsBKEhvDji2q7K+u2l9ita1Ndex5n1KBttfFkWKisg2Mzpqbj1jzoOwog2xXNTDC6rQ+wid/pJpUa6plE2V281Kbk6+IAXFFooD23WC/CcX+6Q+KB3hdZI3Y70a+vWsWX67fe5nXHOWdo1+rKQhBEngnsr2eE8xG8GejgRFTjEuTcWAnakdf/DKjbM7DVJKJQHexm4jijAtl6+lwReCKIJRJC03lkwheYL42b96DvIGUvtOjht3FIDca4KXFJinOzeLjpEqfHawSnPfEAOOymGgnLKR9o+UsH/3YFKvSB3bb1FFjIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BLyLFkVOT6VDwHO40q+5e8h3AFqIk0VudNJgD0mykWM=; b=XZuUah50qEbm4QeldakUYzzKCQqa56wNge18j0Bb5/nYQqXWr3KszLEdTcF2bUsDbTqw+ODTig8liViSWl+51xtg+fjB9WhdA63ZxVCjQrvD3rPUOdqKlUl4rcjUMWVv6aKs1293ilWVuA8/byh8STC7fzlSdopHkdX6eICBJVPKdyAJW0jTA0aBxMNPFDciA/nr8QOeeoZ4eNyqgy/FADoAJPBOuSC2J9uRRSK+opotKZzjoMpWZDcHar8VikRgXNFyjt2m28P47dJyGy0BZDo4rFOcUR4KSs6IcDlNI9cUcACCTTaQ3Yq0zziPmQCV2RHP2sgnSPxfnaia8cN0UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BLyLFkVOT6VDwHO40q+5e8h3AFqIk0VudNJgD0mykWM=; b=T8dZRVKMp/Sy1P5Mb0g3zDY2qYxxoD/zzHc2shJLTLiF8AZxfndRIKEBKAKdTNTQgqxwO9khZ/ecZ8isi8LqJYSnemYefhKCHUKjJ52FuITt7P+PBP0aclSFIOmhfFXr44TnkdZUzngL7T5Rj0AUoSZJclinXSSfkLDEsQbnU2U= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 3/3] xen/arm: Define WLEN_8 macro and use it in debug-pl011 Date: Fri, 18 Nov 2022 12:46:18 +0100 Message-ID: <20221118114618.20754-4-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221118114618.20754-1-michal.orzel@amd.com> References: <20221118114618.20754-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT095:EE_|BL1PR12MB5126:EE_ X-MS-Office365-Filtering-Correlation-Id: 85675678-a091-4d4a-4e0d-08dac95aa2a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pNksFMQiXPYjvVMFm33YJBM7/WKHf8VoBaEal+lXK6vZ1h9PHbeSs+xTVZ+U1+CfnwYBpkccvRw3nLx9yd9I/ieHA9NHtIcsF8tBuIOPjZpTt0Cz5qN/H84JnTWDt3OSR5GxShWZ/VLEsunKeSUNLtXL+ho/gdT0DtXDIs7sY2bE0FyQby2AxV27lgDjNyxCORd1pL06a741OBgONz/JZOhLH6jTe47S7BL85gnV0+6KPCs+u/vQHNjwVhSDThD2c7KKZ2QrIVhAMltwTjXXTBNIY9IMQOY8sVOkwIojGOtO6VdEv1zKS//uxYHwwDeRQX0I+UzGDovrpxozZMMNUbWn95lYWC2N/xPGApDvXTmNNpnC9PSWwHGAHn9mutjOOhu2c4L0K12+fv1G23TXtB7aYKog41USGwIHC268GVCfZVD6NBUNpRsJ4gfncfI7271mcg5gbBHgQuFNUDxWdwtWNoP0fcoJZBjnmZADcyZXVPQQqoxAONIqgAEQpEyALW5zjc9Tgbgcf/E1q1sdSxrAd3l53OyFs8fgOV8F4/RdibCvzbpfd2QzTL8lD93yC7VPfHOlCSE0TmtS6wmZh+9r1OfrvXntzHRl3UTDSjzyqhNkXPVrea92In0aurIy/p0pH+JcRlL9OoyEOSIiwX48zy0JVgoT1/SoDAkmn2p2cwdHOE2XBb/q8CRglyS6REK+MHY8R/dIA90gEQwC6rgQsQQxZ+P16laihcD+06E= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(376002)(136003)(451199015)(46966006)(36840700001)(40470700004)(41300700001)(36756003)(2616005)(36860700001)(1076003)(86362001)(2906002)(5660300002)(44832011)(336012)(426003)(83380400001)(186003)(8936002)(82740400003)(40460700003)(82310400005)(40480700001)(356005)(81166007)(47076005)(26005)(316002)(54906003)(6916009)(478600001)(6666004)(70586007)(70206006)(4326008)(8676002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 11:47:13.8769 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85675678-a091-4d4a-4e0d-08dac95aa2a6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT095.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5126 At the moment, early printk code for pl011 uses a hardcoded value for 8n1 LCR configuration. Define and use macro WLEN_8 for that purpose (no parity and 1 stop bit are defined as 0). Signed-off-by: Michal Orzel --- xen/arch/arm/arm32/debug-pl011.inc | 2 +- xen/arch/arm/arm64/debug-pl011.inc | 2 +- xen/arch/arm/include/asm/pl011-uart.h | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/arm32/debug-pl011.inc b/xen/arch/arm/arm32/debug-pl011.inc index 214f68dc95bd..c527f1d4424d 100644 --- a/xen/arch/arm/arm32/debug-pl011.inc +++ b/xen/arch/arm/arm32/debug-pl011.inc @@ -29,7 +29,7 @@ str \rc, [\rb, #FBRD] /* -> UARTFBRD (Baud divisor fraction) */ mov \rc, #(7372800 / CONFIG_EARLY_UART_PL011_BAUD_RATE / 16) str \rc, [\rb, #IBRD] /* -> UARTIBRD (Baud divisor integer) */ - mov \rc, #0x60 /* 8n1 */ + mov \rc, #WLEN_8 /* 8n1 */ str \rc, [\rb, #LCR_H] /* -> UARTLCR_H (Line control) */ ldr \rc, =(RXE | TXE | UARTEN) /* RXE | TXE | UARTEN */ str \rc, [\rb, #CR] /* -> UARTCR (Control Register) */ diff --git a/xen/arch/arm/arm64/debug-pl011.inc b/xen/arch/arm/arm64/debug-pl011.inc index d82f2f1de197..6d60e78c8ba3 100644 --- a/xen/arch/arm/arm64/debug-pl011.inc +++ b/xen/arch/arm/arm64/debug-pl011.inc @@ -28,7 +28,7 @@ strh w\c, [\xb, #FBRD] /* -> UARTFBRD (Baud divisor fraction) */ mov x\c, #(7372800 / CONFIG_EARLY_UART_PL011_BAUD_RATE / 16) strh w\c, [\xb, #IBRD] /* -> UARTIBRD (Baud divisor integer) */ - mov x\c, #0x60 /* 8n1 */ + mov x\c, #WLEN_8 /* 8n1 */ str w\c, [\xb, #LCR_H] /* -> UARTLCR_H (Line control) */ ldr x\c, =(RXE | TXE | UARTEN) str w\c, [\xb, #CR] /* -> UARTCR (Control Register) */ diff --git a/xen/arch/arm/include/asm/pl011-uart.h b/xen/arch/arm/include/asm/pl011-uart.h index 57e9ec73ac19..5bb563ec0814 100644 --- a/xen/arch/arm/include/asm/pl011-uart.h +++ b/xen/arch/arm/include/asm/pl011-uart.h @@ -55,6 +55,7 @@ /* LCR_H bits */ #define SPS (1<<7) /* Stick parity select */ +#define WLEN_8 (_AC(0x3, U) << 5) /* 8 bits word length */ #define FEN (1<<4) /* FIFO enable */ #define STP2 (1<<3) /* Two stop bits select */ #define EPS (1<<2) /* Even parity select */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 11:54:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 11:54:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445645.700917 (Exim 4.92) (envelope-from ) id 1ovzx7-0004fI-Sc; Fri, 18 Nov 2022 11:54:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445645.700917; Fri, 18 Nov 2022 11:54:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovzx7-0004fB-Pt; Fri, 18 Nov 2022 11:54:37 +0000 Received: by outflank-mailman (input) for mailman id 445645; Fri, 18 Nov 2022 11:54:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ovzx6-0004f5-8f for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 11:54:36 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2060f.outbound.protection.outlook.com [2a01:111:f400:7ea9::60f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c3c69a8a-6737-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 12:54:33 +0100 (CET) Received: from DS7PR07CA0024.namprd07.prod.outlook.com (2603:10b6:5:3af::6) by SA1PR12MB5615.namprd12.prod.outlook.com (2603:10b6:806:229::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Fri, 18 Nov 2022 11:54:29 +0000 Received: from DM6NAM11FT011.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3af:cafe::31) by DS7PR07CA0024.outlook.office365.com (2603:10b6:5:3af::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 11:54:29 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT011.mail.protection.outlook.com (10.13.172.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 11:54:29 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 05:54:27 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 03:54:13 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 05:54:13 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3c69a8a-6737-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kYh4sbx56I8ltotLkd4EjICHx9SK77RA4wsBGGe8Ig1ZzT0fzfU51mpO2qhqjswcs3GmXuyx7wj9DXryFtNFs+XXmLm5/YTfj2ox4lhNcfYjYpt7NXv5WPoBkheLvLO1/1vuRS5MMhCpiO+fQgm72HDxKL9M5M77ApDLfAHfRNf467tu4mThE7QKM9mxSO/alC+GQwlXLdJ9t2YW4LQbuyZHNFaEJjoM5oJJb5YJPnsD4YnLpbfTPRvP5b4I5Q6fPEqNzquu4XAcVTaZ33t42IODBW4nyRJwUGNHmxGe8umndXrEfvaMaULJYU/paGS5qWvfPXkMR9HJTx558b3TUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MHeY02Uor8a+jFLjLXF4b+MgmGw/wpZxA3vetYBSEIk=; b=Wq8mWoMSgmthLp0MqRQnihkeutpgBl/HL1FKUMNhlnQ4oQRyuzaj7V2eTK0qVJcXys11AXuSvAMehfxq7w21GuymkauflPhlkpLXqs7sX217q9h0krZMU9bPw3DW1DYcKtTUavv87z3foss1nJllg9AHilZnqS6BndQqeOJIxfpBhGzetYsnnRa72/RNAUAWH1Vfx9qvyEjT4z0n7jIBd3cKYfl+YUERFV6BgzIiovfoXW1PTHhlNEtgE3gMY6EWhsqM2eCXEGW7+QaID+4DrKSmP5OpxCbI4COEDwadznjCa5s+pKZl8NBIRY5RuW1nI4BC85Yd0SF/hT9jKXcCoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MHeY02Uor8a+jFLjLXF4b+MgmGw/wpZxA3vetYBSEIk=; b=vES/YKUdtAkf6f1UCUFOfSFgAzww9wUmGT/9eZz3qaaC51eTI1OBYMaNZE/+3n6CgLMBTQUIMLQgFmvuJEgkFNymAuIMAKQvb/bqPff8pLjlQ5IuOmyfzENnPg0S3W4swP+OHW4sXuJOfx9fnZsO/QUz/jja/qzllISKAtbHsi4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Fri, 18 Nov 2022 12:54:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 1/3] automation: Create Yocto docker images Content-Language: en-US To: Bertrand Marquis CC: "xen-devel@lists.xenproject.org" , "Doug Goldstein" , Stefano Stabellini References: <6d48a0f83324d2f42597d43c41ce72d6d80150e6.1668677493.git.bertrand.marquis@arm.com> <60ff35c3-0b3a-7c9f-edf5-0639056570d7@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT011:EE_|SA1PR12MB5615:EE_ X-MS-Office365-Filtering-Correlation-Id: 3bed2187-3759-48b1-be28-08dac95ba615 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gIL81sjP5pFL5RYvLchnC5Z36BFyuLJx1OGhl+eFwGweRAkEzRzSRDxxP+Wf9WFtY4pq62VyOn2QUaFQdwum8DmUaFgqIh010bpS3LVN1to1VT8qpy4psnbQCtKOEnOipYrOrJVHdO/jvAJnJbLh7pa3cLCC8a3IPOMLN+WN/5g3QDCv+L4WYFK10hw4m0ys4cKEsrwiZzJ7NhRC2uqgQ2RRFpLc3y4MBaQWUO6UlIV5/X+l/A9+vUkdmEBDaC/G9ApyRa4jP6w2aCgvCuMBah7VGnBjyeC/jTw5ciNAKdI4GaPBZc1FBpssD5+6vEA/B6qNyiosMikXJ6TQvr3rj9qBdLb5yUyxpsn8TABupFNGn6oVHlT9XDL91xJnrj3Bw6TR6p8kcfbOWVuvcZy6UHBleTDWP3cLqbj3aWM7a6i7M+/Q4sT2FiWMWMrXfMbd2PyvNInqUqoLGK3qdsBHHiv5+P2cKNulTvfR77q9ROxZlq2cpgpUYyzk3zknjlnNvJIGozJziheF33dhfaZWpuGZ7/lJKagT0RysAWXE3qOyj09TSNyGbKpBZ3w2EW1Kly/mEXAMGfl8ugfMMsp9FAUHSGfMc5uX0UEk3ApGBq4tGl8opM1oS1CEoTIBhaB/tet317Ex4Iu13aM8TlMXTbQSdDuwyFq/gNQhueyoCsVorkSQGihkw/70d669NT6dJsgqAKoiQBLKFrNM7WL3mV5XBromhzrjPtOmhHwJqvyTf2mfAAOGhHd00sg86CN/CWoJcZHFI8r2jt89sQFY2a1wGntWwls/sc2ltLWwt+NYWHxkf7gHjEoOV9LKmvb50b1MuUIc5vTsw1J6uHIsUg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199015)(40470700004)(46966006)(36840700001)(31686004)(84970400001)(36756003)(82740400003)(966005)(82310400005)(40480700001)(478600001)(40460700003)(86362001)(81166007)(356005)(83380400001)(36860700001)(31696002)(426003)(44832011)(53546011)(2906002)(30864003)(47076005)(336012)(186003)(4326008)(70206006)(70586007)(54906003)(8676002)(5660300002)(2616005)(8936002)(45080400002)(41300700001)(16576012)(26005)(316002)(6916009)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 11:54:29.1058 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3bed2187-3759-48b1-be28-08dac95ba615 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT011.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5615 Hi Bertrand, On 18/11/2022 12:44, Bertrand Marquis wrote: > > > Hi Michal, > >> On 18 Nov 2022, at 08:53, Michal Orzel wrote: >> >> Hi Bertrand, >> >> Just, some minor comments. >> >> On 17/11/2022 10:39, Bertrand Marquis wrote: >>> >>> >>> Add containers suitable to run yocto kirkstone build based on ubuntu >>> 22.04. It contains all packages required by Yocto and a checkout of the >>> layers required to build Xen with Yocto. >>> >>> Add a generic docker image template to be used to automatically generate >>> docker files for different configurations: >>> - specific yocto version >>> - different targets (qemu arm, arm64 and x86) >>> - different host platforms (x86 or arm64) >>> >>> During a call to 'make all', only the images for the current host >>> platform will be generated. >> This looks like a stale comment. The reason being, in the new version, by default >> we build the images for the architectures expected by the CI and its runners >> to match the current workflow. > > Right I will fix the commit message. > >> >>> If needed, images for an other host platform can be generated manually >>> by calling the right make target (see make help). >>> >>> Add a build script to build and run xen on qemu using Yocto. >>> The script supports arm32, arm64 and x86_64 and checks that dom0 is >>> properly booting. At this stage this does not run any guest on top of >>> dom0. The script is to be executed in one of the docker images to build >>> and run a system using a Xen source tree. >>> >>> Signed-off-by: Bertrand Marquis >>> --- >>> Changes in v4: >>> - Rework the system to have one dockerfile template from which make will >>> generate the required dockerfiles for the wanted configuration >> That is great. > > Thanks :-) >> >>> - add support for different host architectures >>> - Merge the generation system into one single dockerfile >>> - Merge patches 1 and 2 in a single patch >>> - Introduce CONTAINERS_EXTRA to have extra containers not built by >>> default (for those not used by CI but useful to users) >>> Changes in v3: >>> - limit number of jobs in yocto by default to 8 and add --num-jobs >>> option to the script to set a custom number of jobs >>> - do not copy anymore the build-yocto.sh script inside the main image so >>> that the current one in the repository is used when running >>> Changes in v2: >>> - add a --dump-log command line option to build-yocto.sh script to dump >>> the logs if an error occurs. >>> Changes in v1: >>> - add --image command line argument to build-yocto.sh to allow building >>> something different than xen-image-minimal. >>> - modify dockerfile to have one layer per line and make it easier to add >>> other. I kept the for loop to keep the number of docker steps lower >>> - update commit message to warn that no guest are tested. >>> - fix build-yocto script to properly return with an error if expect >>> script ends up in timeout or EOF. >>> --- >>> automation/build/Makefile | 14 +- >>> automation/build/yocto/build-yocto.sh | 349 +++++++++++++++++++++ >>> automation/build/yocto/yocto.dockerfile.in | 114 +++++++ >>> automation/build/yocto/yocto.inc | 41 +++ >>> 4 files changed, 516 insertions(+), 2 deletions(-) >>> create mode 100755 automation/build/yocto/build-yocto.sh >>> create mode 100644 automation/build/yocto/yocto.dockerfile.in >>> create mode 100644 automation/build/yocto/yocto.inc >>> >>> diff --git a/automation/build/Makefile b/automation/build/Makefile >>> index a4b2b85178cf..72a5335baec1 100644 >>> --- a/automation/build/Makefile >>> +++ b/automation/build/Makefile >>> @@ -1,13 +1,18 @@ >>> >>> # the base of where these containers will appear >>> REGISTRY := registry.gitlab.com/xen-project/xen >>> -CONTAINERS = $(subst .dockerfile,,$(wildcard */*.dockerfile)) >>> +CONTAINERS = $(filter-out yocto/%,$(subst .dockerfile,,$(wildcard */*.dockerfile))) >>> +CONTAINERS_EXTRA = >>> DOCKER_CMD ?= docker >>> >>> +include yocto/yocto.inc >>> + >>> help: >>> @echo "Builds containers for building Xen based on different distros" >>> @echo "To build one run 'make DISTRO/VERSION'. Available containers:" >>> @$(foreach file,$(sort $(CONTAINERS)),echo ${file};) >>> + @echo "Extra containers (not built using make all):" >>> + @$(foreach file,$(sort $(CONTAINERS_EXTRA)),echo ${file};) >>> @echo "To push container builds, set the env var PUSH" >>> >>> %: %.dockerfile ## Builds containers >>> @@ -16,5 +21,10 @@ help: >>> $(DOCKER_CMD) push $(REGISTRY)/$(@D):$(@F); \ >>> fi >>> >>> -.PHONY: all >>> +.PHONY: all clean >>> all: $(CONTAINERS) >>> + >>> +# Remove generated dockerfiles for yocto >>> +clean: >>> + rm -f yocto/*.dockerfiles >> Are these files needed after make is completed? >> If not, maybe to avoid having some untracked files in the tree, they could be removed after make is done? > > I do not agree here, on might want to inspect those files to check. > Cleaning during make clean is more standard. > > Also those are intermediate files so make should/could clean them automatically. > I will make a try to flag them intermediate if not handled automatically already but I will still keep this here. > It is ok for me. I just raised a concern :) >> >>> + >>> diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh >>> new file mode 100755 >>> index 000000000000..d0c93dfaffe0 >>> --- /dev/null >>> +++ b/automation/build/yocto/build-yocto.sh >>> @@ -0,0 +1,349 @@ >>> +#!/bin/bash >>> +# >>> +# Yocto meta virtualization build and run script >>> +# >>> +# This script is building Yocto xen-image-minimal for qemu targets and run >>> +# them using runqemu inside yocto to check that dom0 is booting properly >> Missing dot at the end of a sentence. > > Will fix > >> >>> +# The build is using a local xen source tree so that specific patches can be >>> +# tested. >>> +# In order to optimize the build time, a build cache is used so that only xen >>> +# packages and its dependencies are rebuilt (qemu and final image mainly). >>> +# >>> + >>> +# Directories >>> +YOCTODIR="$HOME/yocto-layers" >>> +CACHEDIR="$HOME/yocto-cache" >>> +LOGDIR="$HOME/logs" >>> +XENDIR="$HOME/xen" >>> +BUILDDIR="$HOME/build" >>> + >>> +# what yocto bsp we support >>> +TARGET_SUPPORTED="qemuarm qemuarm64 qemux86-64" >>> +VERBOSE="n" >>> +TARGETLIST="" >>> +BUILDJOBS="8" >>> + >>> +# actions to do >>> +do_clean="n" >>> +do_build="y" >>> +do_run="y" >>> +do_localsrc="n" >>> +do_dump="n" >>> +build_result=0 >>> + >>> +# layers to include in the project >>> +build_layerlist="poky/meta poky/meta-poky poky/meta-yocto-bsp \ >>> + meta-openembedded/meta-oe meta-openembedded/meta-python \ >>> + meta-openembedded/meta-filesystems \ >>> + meta-openembedded/meta-networking meta-virtualization" >>> + >>> +# yocto image to build >>> +build_image="xen-image-minimal" >>> + >>> +function print_progress() { >>> + echo -n "$(date +%T) $*" >>> +} >>> + >>> +function run_task() { >>> + local task_name="$1" >>> + local task_target="$2" >>> + >>> + task_log="${task_name//project_}-${task_target}" >>> + >>> + mkdir -p "${LOGDIR}" >>> + print_progress >>> + echo -n "${task_name//project_} ${task_target}: " >>> + if [ "${VERBOSE}" = "n" ]; then >>> + $@ > "${LOGDIR}/${task_log}.log" 2>&1 >>> + else >>> + $@ 2>&1 | tee "${LOGDIR}/${task_log}.log" >>> + fi >>> + >>> + if [ ${?} -ne 0 ]; then >>> + echo "Error" >>> + build_result=$((build_result+1)) >>> + if [ "${do_dump}" = "y" ]; then >>> + echo >>> + echo "############ LOGS-START ############" >>> + cat "${LOGDIR}/${task_log}.log" >>> + echo "############ LOGS-END ############" >>> + echo >>> + fi >>> + return 1 >>> + else >>> + echo "OK" >>> + return 0 >>> + fi >>> +} >>> + >>> +function project_create() { >>> + target="${1:?}" >>> + destdir="${BUILDDIR}/${target}" >>> + >>> + ( >>> + # init yocto project >>> + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" >>> + >>> + # add needed layers >>> + for layer in ${build_layerlist}; do >>> + bitbake-layers add-layer ${YOCTODIR}/${layer} || exit 1 >>> + done >>> + ) || return 1 >>> + >>> + # customize project configuration >>> + cat <> "${destdir}/conf/local.conf" >>> +# Yocto BSP >>> +MACHINE = "${target}" >>> + >>> +# Use local cache to reuse previous builds results >>> +SSTATE_DIR = "${CACHEDIR}/sstate-cache" >>> +DL_DIR = "${CACHEDIR}/downloads" >>> + >>> +# Enable xen and virtualization >>> +DISTRO_FEATURES = " virtualization xen ipv4" >>> + >>> +# Speed up run by not generating ssh host keys >>> +IMAGE_INSTALL:append:pn-xen-image-minimal = " ssh-pregen-hostkeys" >>> + >>> +# Save some disk space >>> +INHERIT += "rm_work" >>> + >>> +# Reduce number of jobs >>> +BB_NUMBER_THREADS="${BUILDJOBS}" >>> + >>> +EOF >>> + >>> + if [ "${do_localsrc}" = "y" ]; then >>> + XENVERS=$(grep -e "^XEN_REL" \ >>> + "${YOCTODIR}"/meta-virtualization/recipes-extended/xen/xen_*.bb \ >>> + 2> /dev/null | tr -d ' ' | tr -d '?' | tr -d '"' \ >>> + | sed -e "s/.*=//" | sort -V | tail -n 1) >>> + >>> + XENBASE=$(dirname "$(realpath -m "${XENDIR}")") >>> + XENSUB=$(basename "$(realpath -m "${XENDIR}")") >>> + >>> + cat <> "${destdir}/conf/local.conf" >>> +# Use local sources for xen and xen-tools >>> +FILESEXTRAPATHS:prepend:pn-xen := "${XENBASE}:" >>> +FILESEXTRAPATHS:prepend:pn-xen-tools := "${XENBASE}:" >>> + >>> +SRC_URI:pn-xen = "file://${XENSUB}/;subdir=local-xen/" >>> +SRC_URI:pn-xen-tools = "file://${XENSUB}/;subdir=local-xen/" >>> + >>> +PREFERRED_VERSION:pn-xen = "${XENVERS}%" >>> +PREFERRED_VERSION:pn-xen-tools = "${XENVERS}%" >>> + >>> +S:pn-xen = "\${WORKDIR}/local-xen/${XENSUB}" >>> +S:pn-xen-tools = "\${WORKDIR}/local-xen/${XENSUB}" >>> + >>> +SRCREV:pn-xen = "\${AUTOREV}" >>> +SRCREV:pn-xen-tools = "\${AUTOREV}" >>> + >>> +SRCPV:pn-xen = "1" >>> +SRCPV:pn-xen-tools = "1" >>> + >>> +# Disable all QA errors as the recipe is not up to date with changes in Xen >>> +# when we use local sources >>> +ERROR_QA:pn-xen = "arch" >>> +ERROR_QA:pn-xen-tools = "arch" >>> + >>> +EOF >>> + fi >>> +} >>> + >>> +function project_build() { >>> + target="${1:?}" >>> + destdir="${BUILDDIR}/${target}" >>> + >>> + ( >>> + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" >>> + >>> + bitbake "${build_image}" || exit 1 >>> + ) || return 1 >>> +} >>> + >>> +function project_clean() { >>> + target="${1:?}" >>> + destdir="${BUILDDIR}/${target}" >>> + >>> + rm -rf "${destdir}" >>> +} >>> + >>> +function project_run() { >>> + target="${1:?}" >>> + destdir="${BUILDDIR}/${target}" >>> + ( >>> + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" > /dev/null 2>&1 >>> + >>> + /usr/bin/expect <>> +set timeout 100 >>> +spawn bash -c "runqemu serialstdio nographic slirp" >>> + >>> +expect_after { >>> + -re "(.*)\r" { >>> + exp_continue >>> + } >>> + timeout {send_user "ERROR-Timeout!\n"; exit 1} >>> + eof {send_user "ERROR-EOF!\n"; exit 1} >>> +} >>> + >>> +# wait initial login >>> +expect -re ".* login: " >>> +send "root\r" >>> +expect -re "root@.*# " >>> + >>> +EOF >>> + exit $? >>> + ) || return 1 >>> +} >>> + >>> +function help() { >>> + cat <>> +Usage: ${0} [TARGET1] [TARGET2] >>> + >>> +This script is build the yocto xen-image-minimal for different qemu targets >>> +and is running it after. >>> +Without any target specified, all supported targets are done. >>> + >>> +Options: >>> + -h, --help Print this help >>> + -v, --verbose Verbose build >>> + --list-target List supported targets >>> + --clean Clean existing project before starting >>> + --no-build Do not build (to run an already built project) >>> + --no-run Do not run >>> + --num-jobs=NUM Define the number of parallel jobs in Yocto. >>> + Default: ${BUILDJOBS} >>> + --dump-log On error, dump the logs on the console >>> + --image=IMG Yocto image or package to build >>> + Default: xen-image-minimal >>> + --xen-dir=DIR path to xen hypervisor source tree >>> + if not provide, normal yocto version of xen is built >>> + Default: ${XENDIR} >>> + --out-dir=DIR directory where to create the projectss >>> + Default: ${BUILDDIR} >>> + --log-dir=DIR directory to store logs >>> + Default: ${LOGDIR} >>> + --cache-dir=DIR directory where to take and store build cache >>> + Default: ${CACHEDIR} >>> + --layer-dir=DIR directory containing the checkout of yocto layers >>> + Default: ${YOCTODIR} >>> +EOF >>> +} >>> + >>> +for OPTION in "$@" >>> +do >>> + case ${OPTION} in >>> + -h|--help) >>> + help >>> + exit 0 >>> + ;; >>> + -v|--verbose) >>> + VERBOSE="y" >>> + ;; >>> + --list-targets) >>> + echo "${TARGET_SUPPORTED}" >>> + exit 0 >>> + ;; >>> + --clean) >>> + do_clean="y" >>> + ;; >>> + --no-build) >>> + do_build="n" >>> + ;; >>> + --no-run) >>> + do_run="n" >>> + ;; >>> + --dump-log) >>> + do_dump="y" >>> + ;; >>> + --num-jobs=*) >>> + BUILDJOBS="${OPTION#*=}" >>> + ;; >>> + --image=*) >>> + build_image="${OPTION#*=}" >>> + ;; >>> + --xen-dir=*) >>> + XENDIR="${OPTION#*=}" >>> + if [ ! -e "${XENDIR}/xen/Makefile" ]; then >>> + echo "No Xen source tree in ${XENDIR}" >>> + exit 1 >>> + fi >>> + do_localsrc="y" >>> + ;; >>> + --out-dir=*) >>> + BUILDDIR="${OPTION#*=}" >>> + ;; >>> + --log-dir=*) >>> + LOGDIR="${OPTION#*=}" >>> + ;; >>> + --cache-dir=*) >>> + CACHEDIR="${OPTION#*=}" >>> + ;; >>> + --layer-dir=*) >>> + YOCTODIR="${OPTION#*=}" >>> + ;; >>> + --*) >>> + echo "Invalid option ${OPTION}" >>> + help >>> + exit 1 >>> + ;; >>> + *) >>> + if echo "${TARGET_SUPPORTED}" | grep -q -w "${OPTION}"; then >>> + TARGETLIST="${TARGETLIST} ${OPTION}" >>> + else >>> + echo "Unsupported target ${OPTION}" >>> + exit 1 >>> + fi >>> + ;; >>> + esac >>> +done >>> + >>> +# if no target is specified build all targets >>> +if [ -z "${TARGETLIST}" ]; then >>> + TARGETLIST="${TARGET_SUPPORTED}" >>> +fi >>> + >>> +mkdir -p "${CACHEDIR}" >>> +mkdir -p "${LOGDIR}" >>> +mkdir -p "${BUILDDIR}" >>> + >>> +# Make sure we have an absolute path >>> +YOCTODIR=$(realpath -m "${YOCTODIR}") >>> +CACHEDIR=$(realpath -m "${CACHEDIR}") >>> +BUILDDIR=$(realpath -m "${BUILDDIR}") >>> +LOGDIR=$(realpath -m "${LOGDIR}") >>> +if [ "${do_localsrc}" = "y" ]; then >>> + XENDIR=$(realpath -m "${XENDIR}") >>> +fi >>> + >>> +# Check that we have all the layers we need >>> +for f in ${build_layerlist}; do >>> + if [ ! -f "${YOCTODIR}/${f}/conf/layer.conf" ]; then >>> + echo "Layer ${f} missing in ${YOCTODIR}" >>> + exit 1 >>> + fi >>> +done >>> + >>> +for f in ${TARGETLIST}; do >>> + if [ "${do_clean}" = "y" ]; then >>> + run_task project_clean ${f} >>> + fi >>> + if [ ! -f ${BUILDDIR}/${f}/conf/local.conf ]; then >>> + run_task project_create ${f} >>> + fi >>> + if [ -f ${BUILDDIR}/${f}/conf/local.conf ]; then >>> + if [ "${do_build}" = "y" ]; then >>> + run_task project_build ${f} >>> + fi >>> + if [ "${do_run}" = "y" ]; then >>> + run_task project_run ${f} >>> + fi >>> + >>> + fi >>> +done >>> + >>> +print_progress "Build Complete (${build_result} errors)" >>> +echo >>> +exit ${build_result} >>> + >>> diff --git a/automation/build/yocto/yocto.dockerfile.in b/automation/build/yocto/yocto.dockerfile.in >>> new file mode 100644 >>> index 000000000000..5350bb2b87b7 >>> --- /dev/null >>> +++ b/automation/build/yocto/yocto.dockerfile.in >>> @@ -0,0 +1,114 @@ >>> +# Docker file to create an environment to build yocto with virtualization >>> +# >>> +# Arguments that can be passed during image creation using --build-arg: >>> +# "host_uid=$(id -u)": to use current user uid for build user in the image >>> +# "host_gid=$(id -g)": to use current user gid for build user in the image >>> +# "ubuntu_version=VERS": to select the ubuntu version number >> Is is the case, that this dockerfile and the packages installed will work on any >> version of ubuntu we will pass here? If not, maybe we should just stick to 22.04 and >> not give the user the opportunity to change this. > > There is no support right now to build for a different version of ubuntu without > modifying the docker file. I kept that as argument here because the generated > file/container does not contain an ubuntu version in its name so changing the > value here in the future will make it clearer. Ok. > > I am ok to remove the variable and directly use the value if you think this is necessary. No need. > >> >>> + >>> +# Use standard ubuntu minimal >>> +ARG ubuntu_version=22.04 >>> +From ##DOCKERPLAT##ubuntu:$ubuntu_version AS base >>> +LABEL maintainer.name="The Xen Project " \ >>> + maintainer.email="xen-devel@lists.xenproject.org" >>> + >>> +ENV DEBIAN_FRONTEND=noninteractive >>> + >>> +# Install minimal ubuntu requirements for yocto and other tools we need >>> +# See https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.yoctoproject.org%2F4.0.1%2Fbrief-yoctoprojectqs%2Findex.html%23build-host-packages&data=05%7C01%7Cmichal.orzel%40amd.com%7Cd5eca08f965d4fd1a99508dac95a41e7%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638043686755292322%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=D%2FAe%2FCUo2%2FWcvJAXjRW4vW9z4pwWcUEOhe1TdlozECw%3D&reserved=0 >>> +RUN apt-get update && \ >>> + apt-get --quiet --yes install \ >>> + gawk \ >>> + wget \ >>> + git \ >>> + diffstat \ >>> + unzip \ >>> + texinfo \ >>> + gcc \ >>> + build-essential \ >>> + chrpath \ >>> + socat \ >>> + cpio \ >>> + python3 \ >>> + python3-pip \ >>> + python3-pexpect \ >>> + xz-utils \ >>> + debianutils \ >>> + iputils-ping \ >>> + python3-git \ >>> + python3-jinja2 \ >>> + libegl1-mesa \ >>> + libsdl1.2-dev \ >>> + python3-subunit \ >>> + mesa-common-dev \ >>> + zstd \ >>> + liblz4-tool \ >>> + file \ >>> + vim \ >>> + bison \ >>> + expect \ >>> + locales \ >>> + liblz4-tool \ >>> + zstd \ >>> + openssl \ >>> + libssl3 \ >>> + ca-certificates \ >>> + && \ >>> + apt-get autoremove -y && \ >>> + apt-get clean && \ >>> + rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* >>> + >>> +# Use bash as shell >>> +RUN rm /bin/sh && ln -s bash /bin/sh >>> + >>> +# Fix local for yocto >>> +RUN locale-gen en_US.UTF-8 && update-locale LC_ALL=en_US.UTF-8 \ >>> + LANG=en_US.UTF-8 >>> +ENV LANG en_US.UTF-8 >>> +ENV LC_ALL en_US.UTF-8 >>> + >>> +# Create a user for the build (we don't want to build as root) >>> +ENV USER_NAME docker-build >>> +ARG host_uid=1000 >>> +ARG host_gid=1000 >>> +RUN groupadd -g $host_gid $USER_NAME && \ >>> + useradd -g $host_gid -m -s /bin/bash -u $host_uid $USER_NAME >>> + >>> +# Switch to our user instead of root and start in its home >>> +USER $USER_NAME >>> +WORKDIR /home/$USER_NAME >>> + >>> +# Create needed directories >>> +RUN mkdir -p /home/$USER_NAME/yocto-layers \ >>> + /home/$USER_NAME/yocto-cache \ >>> + /home/$USER_NAME/logs \ >>> + /home/$USER_NAME/bin \ >>> + /home/$USER_NAME/xen && \ >>> + chown $USER_NAME.$USER_NAME /home/$USER_NAME/* >>> + >>> +# clone yocto repositories we need >>> +RUN for rep in \ >>> + https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenembedded%2Fmeta-openembedded&data=05%7C01%7Cmichal.orzel%40amd.com%7Cd5eca08f965d4fd1a99508dac95a41e7%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638043686755292322%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5IB%2BO9M0DU3D7hN7q9Ft9OivqfmTVKuOVKgFWuElUu4%3D&reserved=0 \ >>> + https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.yoctoproject.org%2Fpoky&data=05%7C01%7Cmichal.orzel%40amd.com%7Cd5eca08f965d4fd1a99508dac95a41e7%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638043686755448030%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fMRgTFNrjR5athu9kXSNXAL%2FeN2RwO%2Bu6CZxCbhesyU%3D&reserved=0 \ >>> + https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.yoctoproject.org%2Fmeta-virtualization&data=05%7C01%7Cmichal.orzel%40amd.com%7Cd5eca08f965d4fd1a99508dac95a41e7%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638043686755448030%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=J6JQP3Ibn2WaD1cTtduC4T%2BbnNWlUHmFPXrLsIe1CSw%3D&reserved=0 \ >>> + ; do \ >>> + git -C /home/$USER_NAME/yocto-layers \ >>> + clone -b ##YOCTOVERSION## --single-branch $rep; \ >>> + done >>> + >>> +# The builder stage is building an initial cache state that we include in the >>> +# final image >>> +From base AS builder >>> + >>> +# This step can take one to several hours depending on your download bandwith >>> +# and the speed of your computer >>> +COPY ./build-yocto.sh / >>> +RUN /build-yocto.sh --dump-log ##YOCTOTARGET## >>> + >>> +From base >>> + >>> +# Only copy the cache status >>> +COPY --from=builder /home/$USER_NAME/yocto-cache /home/$USER_NAME/yocto-cache/. >>> + >>> +LABEL maintainer.name="The Xen Project " \ >>> + maintainer.email="xen-devel@lists.xenproject.org" >>> + >>> diff --git a/automation/build/yocto/yocto.inc b/automation/build/yocto/yocto.inc >>> new file mode 100644 >>> index 000000000000..04076bc8d174 >>> --- /dev/null >>> +++ b/automation/build/yocto/yocto.inc >>> @@ -0,0 +1,41 @@ >>> +# This makefile generates the docker files for Yocto builds >>> +# The containers for the current architecture are the one built using make all >>> +# To build containers for a different architecture, you need to call make for >>> +# the image you want explicitely >> Could you please add a dot at the end of each sentence above. This will improve readability. > > Yes will do. > >> >>> +# The containers are named this way: >>> +# YOCTOVERSION-TARGET for x86_64 hosts >>> +# YOCTOVERSION-TARGET-arm64v8 for arm64 hosts >>> + >>> +# Yocto versions we are currently using >>> +YOCTO_VERSION = kirkstone >>> + >>> +# Yocto BSPs we want to build for >>> +YOCTO_TARGETS = qemuarm64 qemuarm qemux86-64 >>> + >>> +# Supported Host platforms (host architecture specific ones) >> To avoid mismatch \wrt platform vs architecture I would stick to the latter one. >> In the docker world, arm64v8 is an architecture whereas linux/arm64/v8 is a platform. > > So "yocto target” and “container platform” ? container architecture > >> >>> +YOCTO_HOSTS = amd64 arm64v8 >>> + >>> +# Architecture we want to use in gitlab CI (depends on runners arch) >>> +CI_ARCH = arm64v8 >>> + >>> +define GEN_DOCKER >>> +# Make all is generating what we want in the CI >>> +ifeq ($(CI_ARCH),$(3)) >>> +CONTAINERS += yocto/$(1)-$(2)$(4) >>> +else >>> +CONTAINERS_EXTRA += yocto/$(1)-$(2)$(4) >>> +endif >>> + >>> +yocto/$(1)-$(2)$(4).dockerfile: yocto/yocto.dockerfile.in >>> + echo > $$@ >>> + cat $$< | \ >>> + sed -e "s,##YOCTOVERSION##,$(1),g" | \ >>> + sed -e "s,##YOCTOTARGET##,$(2),g" | \ >>> + sed -e "s,##DOCKERPLAT##,$(3)/,g" > $$@ >>> + >>> +endef >>> + >>> +$(eval $(foreach vers,$(YOCTO_VERSION),\ >>> + $(foreach tar,$(YOCTO_TARGETS),\ >>> + $(foreach hst,$(YOCTO_HOSTS),\ >>> + $(call GEN_DOCKER,$(vers),$(tar),$(hst),$(if $(filter amd64,$(hst)),,-$(hst))))))) >> This could be aligned under first foreach. Also I think there is no need to try to shorten the version,target,host. > > This is something you requested me in order to have container names for yocto coherent > with other xen containers (ie only have the -arm64v8 suffix for arm). > > Do you want me to revert this and have names containing the amd64 suffix ? This is not what I meant. I just wanted to use the full words like target,host,version instead of tar,hst,vers and for the "foreach" to be aligned. > > Thanks for the review > > Cheers > Bertrand > >> >>> -- >>> 2.25.1 >>> >> >> ~Michal > ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 18 12:06:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 12:06:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445661.700928 (Exim 4.92) (envelope-from ) id 1ow08z-0006bb-Au; Fri, 18 Nov 2022 12:06:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445661.700928; Fri, 18 Nov 2022 12:06:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow08z-0006bU-80; Fri, 18 Nov 2022 12:06:53 +0000 Received: by outflank-mailman (input) for mailman id 445661; Fri, 18 Nov 2022 12:06:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow08x-0006bO-KE for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 12:06:51 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7a16d3d1-6739-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 13:06:49 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 259B53200BD7; Fri, 18 Nov 2022 07:06:46 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 18 Nov 2022 07:06:46 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Nov 2022 07:06:44 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a16d3d1-6739-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668773205; x= 1668859605; bh=ydnYLE9kWkKbVKA7VcOBz6ftKnIEHWq5ebRsQGBa77M=; b=v CXzY4V9EBhmPlwF255kCUVOdVBfGYtP6jGCEJofaskheLLC8AQcjPnzLQksZv6my 6prA2+iVgl8Wa52DU+GLeiTQ5VdgS8eDWuYDul7caz86h7wXAOa7RNyDCVqVs1TN qvcAWercASnX7Fxc+tu0712obxhZjorL4vbHYPrYTcSbP6PKm+8tSj084nwT52B8 3fbOigkpcq7XTwk6zumDgN14UHY7PhyfG54ya0LpR3YSKIpcMQnDtPc7+GNq2b9Z C80YuFHcaO6qtdmMUSHQvXb7qj2js6i+jDn/shGwH1sYr1WZUSgl31DeXb2GFHQC hBZ+Zxrw73VvFCPJeVV/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668773205; x=1668859605; bh=ydnYLE9kWkKbVKA7VcOBz6ftKnIE HWq5ebRsQGBa77M=; b=XBjbxJ6SY3MISmD6rxxEY+iF90CsE999B97YS6oIiBNs s5G2aJiv2PXhi7SIQUTRPkOMsW6Lf7rCFtWHX4foagzvr+4EAAeNOPJlEREJv9O4 cTyFtDaOkndbQS1TA8bW9WMmGbL38aMr7+4yWXXU8qnIIh3gG46h6Ep7xgdD8CPt q5nit12IflT/UIKH9704rmLgu+FIuP/iwXNZBCU83SD9PmoZY7P+VrCX1XCyhlol 54MKNoia5RBaK9iL1hfeocNpXPA24/6Fm/zG0KDJBtu5lI4f2cpk7+ZnP/seZIcu wbxwNmsMPrel4Tr1Fb8Sw/JCwB9xx0Q+VCuZQjfAfg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrhedtgdefhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Fri, 18 Nov 2022 13:06:41 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , "moderated list:XEN HYPERVISOR INTERFACE" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled Message-ID: References: <20221118023535.1903459-1-marmarek@invisiblethingslab.com> <93b6385c-63c8-1b5a-13c0-838f7c03ccce@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JWeX+CTKflPH5119" Content-Disposition: inline In-Reply-To: <93b6385c-63c8-1b5a-13c0-838f7c03ccce@suse.com> --JWeX+CTKflPH5119 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 18 Nov 2022 13:06:41 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , "moderated list:XEN HYPERVISOR INTERFACE" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled On Fri, Nov 18, 2022 at 08:36:14AM +0100, Jan Beulich wrote: > On 18.11.2022 03:35, Marek Marczykowski-G=C3=B3recki wrote: > > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until > > the table is filled. Then it disables INTx just before clearing MASKALL > > bit. Currently this approach is rejected by xen-pciback. > > According to the PCIe spec, device cannot use INTx when MSI/MSI-X is > > enabled. >=20 > Similarly the spec doesn't allow using MSI and MSI-X at the same time. > Before your change xen_pcibk_get_interrupt_type() is consistent for all > three forms of interrupt delivery; imo it also wants to be consistent > after your change. This effectively would mean setting only one bit at > a time (or using an enum right away), but then the question is what > order you do the checks in. IOW I think the change to the function is > wrong. IIUC the difference is that enabling MSI or MSI-X implicitly disables INTx, while enabling both MSI and MSI-X is UB. This means that MSI active and PCI_COMMAND_INTX_DISABLE bit not set means "only MSI is active" - which the function now properly reports. Both MSI and MSI-X active at the same time means a bug somewhere else and the current code allows only to disable one of them in such case. I could replace this with BUG_ON, or simply assume such bug doesn't exist and ignore this case, if you prefer. > Furthermore it looks to me as if you're making msi_msix_flags_write() > inconsistent with command_write() - you'd now want to also permit > clearing "INTx disable" when MSI or MSI-X are enabled. Which, I think, > would simply mean allowing the domain unconditional control of the bit > (as long as allow_interrupt_control is set of course). I think your are correct. > Especially with these further changes I'm afraid at least for now I > view this as moving in the wrong direction. My view might change in > particular if the description made more clear what was wrong with the > original change (476878e4b2be ["xen-pciback: optionally allow interrupt > enable flag writes"]), or perhaps the discussion having led to the form > which was committed in the end. I'm afraid I don't understand why you think it's the wrong direction. Can you clarify?=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --JWeX+CTKflPH5119 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN3dVEACgkQ24/THMrX 1yyy8gf9HRwcAZpH1zguX0WqxWEGwW9uPdCzHaQ7diDesElifkVgwuOwz5hYHqm/ j+xXskWFao2c3a5AFnAiW34jAXSEOtTZ/eciJeBZdoXZ/IeN5zKF26h2jAHTdnOw HWMTRMkM9VGdtVACLtdDFXCPPKK8k9xLcwz5JI6jHbcqT6r2jFbPn1RdciFzV6iu SygWCBxRpjUzVmNY/HZPlPSAIYhWwlf1VwwICGivvW2HKhswNEqygpZwEY3qoDgt 13jhh794GUzq/2NDO5Nunz+maILbYRY3kfa/d1ImOEnvoIo+3nekvY2sG9CE/gJO diXfejb4cPwYCw+i3UZOSMSM8T6I/A== =xexH -----END PGP SIGNATURE----- --JWeX+CTKflPH5119-- From xen-devel-bounces@lists.xenproject.org Fri Nov 18 12:20:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 12:20:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445667.700939 (Exim 4.92) (envelope-from ) id 1ow0Lk-0000HN-Hd; Fri, 18 Nov 2022 12:20:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445667.700939; Fri, 18 Nov 2022 12:20:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0Lk-0000H7-DQ; Fri, 18 Nov 2022 12:20:04 +0000 Received: by outflank-mailman (input) for mailman id 445667; Fri, 18 Nov 2022 12:20:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0Li-0008Kc-TS for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 12:20:02 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5228ed3b-673b-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 13:20:00 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 28C463200C05; Fri, 18 Nov 2022 07:19:58 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 18 Nov 2022 07:19:58 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Nov 2022 07:19:56 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5228ed3b-673b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668773997; x= 1668860397; bh=iSvtC9+L0nNeMjsqo3aw2P2BV9TWCeGKsRvhhRZP+aY=; b=T yewhoAq51qYRBPPNQ+6c53Guc+5DPzuO12hTBFmzno0fwFlrgemX+H2rIuICZril CNF9lSVHq3ba3oXZUH4EvAAivoVng/EOTmBMxVDVNNnvzoz1RMHn7Q89oxxqASU/ u+8cfF4XN46jfgFSWk8WKJecU/1duwwW8KP+YOIXgi7BybkiVV5HnCTm345tTXR1 WQwYEHQmsprKW9m2ORGWPxYV25KZ+V8po30x4AUaqovaDoL4D7EItvH8oJ2K/d6T WwM+8NRb822HZGDyYaIE8v+OKY0lwRGrl9FXqWZlhoJLLTGIFemb1DoIv/f+OPie h74tzNCymN1swz80E1ARw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668773997; x=1668860397; bh=iSvtC9+L0nNeMjsqo3aw2P2BV9TW CeGKsRvhhRZP+aY=; b=Av4Al2j1m8m9NLGtPWA+6zQrJtaODUlwsJC9Ibm4IjT/ HRxP6Lj3SFYHKYXkM9fZRecFFuJynfBWZnJgXDkYNbdAx7jHfbtzg/y49MNYgPZg E+9PEj/ScKXdO6Vdcmw+s6vfLGvjewrTIWJl2FlW/AzcSL1i+zkL6xuFYUFyLsjz PLoFpxORSVQBZjt7kLYoHmzRazvbOhObuB/uREcY9hnG/8XMuA12r4OsiIiB//J4 0pqPWT4/5LJHqtLpTr2iWhmD9LZXPqWHqAhEdKjfTvEb5XeH14XDwXh54iutgj6T n8NGR3pzIcn4w2TK1/PXSaxNofbYwn/yEptCojfuFA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrhedtgdeflecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Fri, 18 Nov 2022 13:19:53 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/2] x86/msi: Allow writes to registers on the same page as MSI-X table Message-ID: References: <20221114192100.1539267-1-marmarek@invisiblethingslab.com> <20221114192100.1539267-2-marmarek@invisiblethingslab.com> <15138618-5cb0-8304-a56b-cb787e187772@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SYnEHPhPt8JfjktG" Content-Disposition: inline In-Reply-To: --SYnEHPhPt8JfjktG Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 18 Nov 2022 13:19:53 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/2] x86/msi: Allow writes to registers on the same page as MSI-X table On Fri, Nov 18, 2022 at 08:20:14AM +0100, Jan Beulich wrote: > On 17.11.2022 18:31, Marek Marczykowski-G=C3=B3recki wrote: > > On Thu, Nov 17, 2022 at 05:34:36PM +0100, Jan Beulich wrote: > >> On 14.11.2022 20:21, Marek Marczykowski-G=C3=B3recki wrote: > >>> --- a/xen/arch/x86/msi.c > >>> +++ b/xen/arch/x86/msi.c > >>> @@ -961,6 +961,21 @@ static int msix_capability_init(struct pci_dev *= dev, > >>> domain_crash(d); > >>> /* XXX How to deal with existing mappings? */ > >>> } > >>> + > >>> + /* > >>> + * If the MSI-X table doesn't span full page(s), map the las= t page for > >>> + * passthrough accesses. > >>> + */ > >>> + if ( (msix->nr_entries * PCI_MSIX_ENTRY_SIZE) & (PAGE_SIZE -= 1) ) > >>> + { > >>> + uint64_t entry_paddr =3D table_paddr + msix->nr_entries = * PCI_MSIX_ENTRY_SIZE; > >>> + int idx =3D msix_get_fixmap(msix, table_paddr, entry_pad= dr); > >>> + > >>> + if ( idx >=3D 0 ) > >>> + msix->last_table_page =3D fix_to_virt(idx); > >>> + else > >>> + gprintk(XENLOG_ERR, "Failed to map last MSI-X table = page: %d\n", idx); > >>> + } > >> > >> Could we avoid the extra work if there's only less than one page's > >> worth of entries for a device? But then again maybe not worth any > >> extra code, as the same mapping will be re-used anyway due to the > >> refcounting that's being used. > >=20 > > I was considering that, but decided against exactly because of > > msix_get_fixmap() reusing existing mappings. > >=20 > >> Makes me think of another aspect though: Don't we also need to > >> handle stuff living on the same page as the start of the table, if > >> that doesn't start at a page boundary? > >=20 > > I have considered that, but decided against given every single device I > > tried have MSI-X table at the page boundary. But if you prefer, I can > > add such handling too (will require adding another variable to the > > arch_msix structure - to store the fixmap location). >=20 > To limit growth of the struct, please at least consider storing the fixmap > indexes instead of full pointers. Ok. > >>> @@ -1090,6 +1105,12 @@ static void _pci_cleanup_msix(struct arch_msix= *msix) > >>> WARN(); > >>> msix->table.first =3D 0; > >>> msix->table.last =3D 0; > >>> + if ( msix->last_table_page ) > >>> + { > >>> + msix_put_fixmap(msix, > >>> + virt_to_fix((unsigned long)msix->last_ta= ble_page)); > >>> + msix->last_table_page =3D 0; > >> > >> To set a pointer please use NULL. > >=20 > > Ok. > >=20 > >> Overall it looks like you're dealing with the issue for HVM only. > >> You will want to express this in the title, perhaps by using x86/hvm: > >> as the prefix. But then the question of course is whether this couldn't > >> be dealt with in/from mmio_ro_emulated_write(), which handles both HVM > >> and PV.=20 > >=20 > > The issue is correlating BAR mapping location with guest's view. > > Writable BAR areas are mapped (by qemu) via xc_domain_memory_mapping(),= but > > that fails for read-only pages (and indeed, qemu doesn't attempt to do > > that for the pages with the MSI-X table). Lacking that, I need to use > > msixtbl_entry->gtable, which is HVM-only thing. > >=20 > > In fact there is another corner case I don't handle here: guest > > accessing those registers when MSI-X is disabled. In that case, there is > > no related msixtbl_entry, so I can't correlate the access, but the > > page(s) is still read-only, so direct mapping would fail. In practice, > > such access will trap into qemu, which will complain "Should not > > read/write BAR through QEMU". I have seen this happening several times > > when developing the series (due to bugs in my patches), but I haven't > > found any case where it would happen with the final patch version. > > In fact, I have considered handling this whole thing via qemu (as it > > knows better where BAR live from the guest PoV), but stubdomain still > > don't have write access to that pages, so that would need to be trapped > > (for the second time) by Xen anyway. > >=20 > > For the PV case, I think this extra translation wouldn't be necessary as > > BAR are mapped at their actual location, right? >=20 > I think so, yes. >=20 > > But then, it makes it > > rather different implementation (separate feature), than just having a > > common one for PV and HVM. >=20 > It would be different, yes, and if - as you explain above - there are > technical reasons why it cannot be shared, then so be it. Mentioning > this in the description may be worthwhile, or else the same question > may be asked again (even by me, in case I forget part of the discussion > by the time I look at a particular future version). Ok, I'll extend the commit message. > >> Which in turn raises the question: Do you need to handle reads > >> in the new code in the first place? > >=20 > > The page not being mapped is also the reason why I do need to handle > > reads too. >=20 > Just for my own clarity: You mean "not mapped to qemu" here? No, to the HVM domain (in p2m). Xen (outside of MSI-X specific code for HVM) doesn't know where those reads should be from. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --SYnEHPhPt8JfjktG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN3eGkACgkQ24/THMrX 1yxmsgf9HBYVECbngHhti/dCGQVxhEiVTP17KAmcb/TactXFS0LB3Pjzih4nErLk aDT1362UI/HP4Czj81iAcTMDVoXMM/P2m2B5QfAjD+7vlOae2rWtZ5PK+Ua+e/Iv Vl7dciGlF9Q6+gTzZkHrDJ16wbZdTCfAz1N+VK4e0Pl8OaieHU1DUVKI8bTHm7RY E+5T4W5mQdbqhuxGkqOEnTyldfV7rbKQFSp8n1XTvozUL6PDxsg7ABH+yWpwan9j DVHws3SlIQ7NRsYCns4ZasmEHwiNbWvzTWhJ0KlAhAqzrBymAUTLXFP7sz1GlESB oY8TRMut8vz4tJW3n24Rr6bATnoOOg== =FnA0 -----END PGP SIGNATURE----- --SYnEHPhPt8JfjktG-- From xen-devel-bounces@lists.xenproject.org Fri Nov 18 12:27:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 12:27:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445674.700949 (Exim 4.92) (envelope-from ) id 1ow0SS-0001Ta-7Z; Fri, 18 Nov 2022 12:27:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445674.700949; Fri, 18 Nov 2022 12:27:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0SS-0001TT-4a; Fri, 18 Nov 2022 12:27:00 +0000 Received: by outflank-mailman (input) for mailman id 445674; Fri, 18 Nov 2022 12:26:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0SR-0001TN-KR for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 12:26:59 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20608.outbound.protection.outlook.com [2a01:111:f400:7e8a::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a8a663c-673c-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 13:26:57 +0100 (CET) Received: from MW4PR04CA0134.namprd04.prod.outlook.com (2603:10b6:303:84::19) by SA1PR12MB7101.namprd12.prod.outlook.com (2603:10b6:806:29d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Fri, 18 Nov 2022 12:26:54 +0000 Received: from CO1NAM11FT114.eop-nam11.prod.protection.outlook.com (2603:10b6:303:84:cafe::4b) by MW4PR04CA0134.outlook.office365.com (2603:10b6:303:84::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Fri, 18 Nov 2022 12:26:54 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT114.mail.protection.outlook.com (10.13.174.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 12:26:53 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 06:26:51 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 06:26:50 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a8a663c-673c-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AiflTBViyqM7MYFr/uyW2XbypgNtVxMpDbZEQSkCxNIA+kIwsjPVGpB/RKrAUJSBwYgtMKYiPP0CDaqbttShUUebBByNjtb7QTwBtxHudoCPPkySbEHQlMC+ynQPJo7GGNeJ27PGlO0hG0EhWqSp/P6uzF9iKV93GApZvl/oNJiC//AjmAT0CVLUr/XynJELLMMsW+LbHJW7UIU/G4TLtRoLQdsfMnSSuwOiW3xlnW2nz9sD4cu+yuowGC9n6+ZNjI1j8/TYkkbP5IIF1sMdNiUDkXATv/FGXh6yrkKc78DB9pBLt/X8jcGSGoaXAHGOolS9gdw5/NucdQX3BiM5cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f38sHVwwDBo2274oknHPzAXruJunsQYCI4+9TLMWY38=; b=igLrgvcBe9iB/A+9qniZtN1idUfrgVHuaGxqNBoJEjgFsC2/pN0tAyVlwErVp5Lx+TQk6M5guBe7LkvOf6PVBXqnWVepasZnHy5UYdRhe42aBX94bs/PYAkl9rLaBBYtCbcrIfpC+Z1wa5a5nXPs/mQh8yhflvF2Su45995nNQFknqlqHOapcfrf9HsJ5bW/+Ha9vWEURxPaImBtnpKB0ugq4SmdccHVsRyUCLybHHztBUZFSPuPvd5Mn0lyq+Jb6tgUmY+/Wm7+VXMkxuegPmJAnxHlrXgKSDX8kmPBy7nP/75nV4D0wyRYRlblTYoDCOSHs3BIBJFcOlpAVL4HoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f38sHVwwDBo2274oknHPzAXruJunsQYCI4+9TLMWY38=; b=DCjVqhwdPMif/abwTT5hVTvhOQQ/+HhsIKPNPOIKCiwSgkqjidx1a0MFjijcfBdG6B3YQLUO1F6HbFRM5bDAmx9f2q8IsBx6XWH/coLZyUoIiyjxn86sppr2kXnMxTW/4lSRgol/MQ79s0Oux4fqM3ipX8dflG9d7fVaoBCyrQE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <4c9d45a3-1bfc-3f4a-de37-2c3a894439f8@amd.com> Date: Fri, 18 Nov 2022 13:26:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN v3 08/12] xen/Arm: GICv3: Define ICH_AP0R and ICH_AP1R for AArch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-9-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20221111141739.2872-9-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT114:EE_|SA1PR12MB7101:EE_ X-MS-Office365-Filtering-Correlation-Id: 6152a1a9-0616-4924-9b1d-08dac9602d0d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kYM91TVkVZrg6dGMrM4n6ecmCgnYRC2fm0/gjjKe/CqOdZX6SsUMHVKgky4rBJ50oxecAEG7dmiUfTNkaWDHKp3DVj6Dw3w8VWB+jnuB4iS3DWivoSWOI+EjoTjDTq7/s7sMYrlby5rc8D6VoScZBDkE3Gpsv+/oCnqv63wYnKkFFFyxNHYOIzkHEp4Rzj7+xPZKrwaEAMIa8a9qPtQlV6iDZPqG3jzbv3FplHWZFjUnUAquKtQGVzHjV1bZLuHzcVJnFt16F8yvzQnR1JbCsg87xDhAUnjSnBwr8+DsEtjKV/gDzZXFliIj/UaytRrQsBnoQUA4hEEyW/dCfLmor+5ghPfFYGvhb6niYKngPIipYnX+RoTrAITXx25cQqdkEI0A+RLI7OCBpZWranFqhC619gqLlwYNSmlATtmhSAtraM3n3QXxCHBhk6rjbhQZJHFDbQlk8BbS9kbUCOt74SCoWKnZ/TDSabvKPGmLE42gMJ3enIwBK1oYgWsd5dVIVB6J+cSXuwgeIQ30N85eMBj2ov8TR79ufa7nJTFRYGohBOZbI/pe/Be0F/bnPcuBc6RLcaXjUdtz3i2MPehnerIPdqfyqEIz7ABfdZRPX0qJx9bldYLQ2o0FZW1X3qeIF4h9S9h6uGVgP3a7O64ypcTpm49ZbmiddPiIv1dhYF/FjZS8HWTToJdGzz0cpEbJgbyaYXvCG+rIfiaDhiNL00fZwX5YLl4VlaQ68+GVqk0Go+79ftAta80XsrY/GsQ/a3aVsqCFwu2tMmzCp6KnTA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(396003)(39860400002)(346002)(451199015)(36840700001)(40470700004)(46966006)(31686004)(81166007)(70586007)(356005)(82740400003)(2906002)(4326008)(8936002)(40480700001)(86362001)(36860700001)(31696002)(83380400001)(316002)(8676002)(426003)(54906003)(336012)(186003)(2616005)(36756003)(16576012)(47076005)(478600001)(5660300002)(110136005)(26005)(44832011)(41300700001)(82310400005)(40460700003)(53546011)(70206006)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 12:26:53.4537 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6152a1a9-0616-4924-9b1d-08dac9602d0d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT114.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7101 Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: > Adapt save_aprn_regs()/restore_aprn_regs() for AArch32. > > For which we have defined the following registers:- > 1. Interrupt Controller Hyp Active Priorities Group0 Registers 0-3 > 2. Interrupt Controller Hyp Active Priorities Group1 Registers 0-3 > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from :- > v1 - 1. Moved coproc register definition to asm/cpregs.h. > > v2 - 1. Defined register alias. > 2. Style issues. > 3. Dropped R-b and Ack. > > xen/arch/arm/include/asm/cpregs.h | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h > index 242dabaea8..5331ec3448 100644 > --- a/xen/arch/arm/include/asm/cpregs.h > +++ b/xen/arch/arm/include/asm/cpregs.h > @@ -259,6 +259,26 @@ > #define VBAR p15,0,c12,c0,0 /* Vector Base Address Register */ > #define HVBAR p15,4,c12,c0,0 /* Hyp. Vector Base Address Register */ > > +/* > + * CP15 CR12: Interrupt Controller Hyp Active Priorities Group 0 Registers, > + * n = 0 - 3 > + */ > +#define __AP0Rx(x) ___CP32(p15, 4, c12, c8, x) You are using a macro ___CP32 here but it is defined somewhere down the file. So I think you need to make a change so that the definition appears before use. > +#define ICH_AP0R0 __AP0Rx(0) > +#define ICH_AP0R1 __AP0Rx(1) > +#define ICH_AP0R2 __AP0Rx(2) > +#define ICH_AP0R3 __AP0Rx(3) > + > +/* > + * CP15 CR12: Interrupt Controller Hyp Active Priorities Group 1 Registers, > + * n = 0 - 3 > + */ > +#define __AP1Rx(x) ___CP32(p15, 4, c12, c9, x) > +#define ICH_AP1R0 __AP1Rx(0) > +#define ICH_AP1R1 __AP1Rx(1) > +#define ICH_AP1R2 __AP1Rx(2) > +#define ICH_AP1R3 __AP1Rx(3) > + > /* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ > #define ___CP32(coproc, opc1, crn, crm, opc2) coproc, opc1, crn, crm, opc2 > #define __LR0(x) ___CP32(p15, 4, c12, c12, x) > @@ -360,6 +380,14 @@ > #define HCR_EL2 HCR > #define HPFAR_EL2 HPFAR > #define HSTR_EL2 HSTR > +#define ICH_AP0R0_EL2 ICH_AP0R0 > +#define ICH_AP0R1_EL2 ICH_AP0R1 > +#define ICH_AP0R2_EL2 ICH_AP0R2 > +#define ICH_AP0R3_EL2 ICH_AP0R3 > +#define ICH_AP1R0_EL2 ICH_AP1R0 > +#define ICH_AP1R1_EL2 ICH_AP1R1 > +#define ICH_AP1R2_EL2 ICH_AP1R2 > +#define ICH_AP1R3_EL2 ICH_AP1R3 > #define ICH_LR0_EL2 ICH_LR0 > #define ICH_LR1_EL2 ICH_LR1 > #define ICH_LR2_EL2 ICH_LR2 ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 18 12:27:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 12:27:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445679.700961 (Exim 4.92) (envelope-from ) id 1ow0TK-00022h-O0; Fri, 18 Nov 2022 12:27:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445679.700961; Fri, 18 Nov 2022 12:27:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0TK-00022a-Ks; Fri, 18 Nov 2022 12:27:54 +0000 Received: by outflank-mailman (input) for mailman id 445679; Fri, 18 Nov 2022 12:27:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0TJ-0001TN-Kq for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 12:27:53 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2060d.outbound.protection.outlook.com [2a01:111:f400:fe13::60d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6bd068c7-673c-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 13:27:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7800.eurprd04.prod.outlook.com (2603:10a6:20b:2a6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Fri, 18 Nov 2022 12:27:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 12:27:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bd068c7-673c-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BggZgnZScM4svskQ0+XMGCex6DkTUgle3sz9b2BMVmfe4YyuK9wIubFsaRArhQdYT6jq5ZOn9S72SmL1LLsEkddBmYPvHgmtspsDY8Thnv0sRG7F9dvdGepTZlO2zP8Suq8aFucQa6kjasfrHSxAR/A0nYUiDI0ydgyFx/fyH8r3wZGX+/mugUleId0HIDXa1IiP33+KsYYZsxOZg3o67XQflK4UZxL4RJ7SXrmIrda4z6JNzFmfTu5defHPxbSuzMFjBqFSpsJBtwGiN5Ho46vgWHqL/j8/wXB/UYPz8hrpfFmjpRKq5fIY/EuOcaThnUUdLp+kIqQoW+tSNXIGoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=62WL9D3+1ncBlxOPaYn3Ys0suKxJNg14U5FxAy8SQk4=; b=cOpiCXp/ciRRXch0y0aU/Vnr4hoL6qa0wzdL0a7XBJWbeeB9shxJ5wI+uYlSvmdTxJPfjV73yMGlKYdFt+ARkEUGgXutX6vJtENlIBZgI978zPgNzNFLvuxy+dFrCuT2YCiFegqQ+uh2tuwsH+BP11msETtEFH30EPNPEwVLIRmbJ5uu1Tu6bNKG/Ffzo0txj8durcEr5ks5oBozJfBrPTJFSWfFBh/9+2TEqC7fALOjx90YOy29bRXlss3+J4fDsQEpaDIiMbt11mopxdqUeh9mZD3au2zVvoR3vNziylNjlmubP3UJho4T4Yk9ZzwidAQdyrDPEvUNNlBLu/SKxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=62WL9D3+1ncBlxOPaYn3Ys0suKxJNg14U5FxAy8SQk4=; b=13O5RYeyrdpb2g1C7TjS0cE38IAT0NMTnFbiuuAfgGsoM4+MSX96vghqvVkeqIsubAvF7p8cDlMu77+c7oBxAVpfMHohm9u38/lpcXntqT0PRfk7O+Qldk5dlqPXaMjcg2DSf6qnVY+m+FEqBi9WzK9XdW2E26yWjtvFhnBmcvzdrnxG5rGcB9huO10Pfjb2FHHcGdtTv4vUke1bOdM1oPfWqhzH8Hv8QsdXIJQOYq0GRYcbPwoqpamJ7y0KP9yfdrMWRj37tVeDSB+2b/HKuRC6zTMaG6SVwoU+u4PO6al/GQLePd8KA2Zgp1ykKJS/8gry/yJxqnVHBIwQApVsbA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 18 Nov 2022 13:27:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , "moderated list:XEN HYPERVISOR INTERFACE" , linux-kernel@vger.kernel.org References: <20221118023535.1903459-1-marmarek@invisiblethingslab.com> <93b6385c-63c8-1b5a-13c0-838f7c03ccce@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7800:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d0089fa-893f-4081-5f54-08dac9604f14 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sEKbnPUWfuHm3Q7yunTw5PAqcpxZ2S7QhwKtDE2eAwzQ7CcQSNOir8nwDr74XgFnMiV/rGFRTr3nfQZGdyLN1pOTLMI1cNkIiD4p5Aomby84hVvVLHg6di8MlCOzAs6AOtH7SruccRwZ0WTcOPxfKzeWGHkdvkNMirZ4ltziFiYT3bjkdUrEydLNvibL1y+0rf3dPZuzjbu77f6XLcK8EaIgLR7zr2emvUEnW4RGzzE5dA4H5QIqfCSInHFo5Jqtml8ZIhTbF3W5tYh8jZLtySmVHWHs6qT8fpvq+k+fKYwSivPRbKCYTO2ZuaqpJC/ovC5akQDSNyu6picmVhD6Dy1kqUiZwYxzCPKs4qa4Bvjm2kFDn9z7E38qL8EFunAjBKgDuOcoXxmQ8A7LO0WKOEzgIN7CJDHWlZ8yqdS9S1OA5cyA3oEkLKV0BrJ/8rqY0npZw6Xh54SYzGtoy79bS7SWvnol7LhdcpQPWTvCW6msg2zw+57FW3jdOp8reiHwHp//rHmzAJ+KTA1BjExfFOYx1epgNQ4BoBX4t+7VJegD7Sac8BshFj/OhBU/D+lUQfo9nzYkIela/1wwvPWkwlCM9ows0azwN/LLU8XQmzDZw93gHcmQKipdSAtheCQro5sJ2qEVjr8XDs997JrHsxgKL6jTR60CNXPaJlxoX351p13xg+eNpi5ts5zLrGz4GrKnsL4Iz9BQE38+AUlotf1K13CSZQumzKvcSAdcnh4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(136003)(396003)(39860400002)(346002)(451199015)(31686004)(38100700002)(66946007)(2906002)(4326008)(8936002)(86362001)(31696002)(83380400001)(316002)(8676002)(54906003)(186003)(2616005)(36756003)(6486002)(66574015)(478600001)(5660300002)(66476007)(26005)(66556008)(41300700001)(6916009)(6506007)(6512007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEIwSXNlNFBlaFVPbHpEZTBZVjRnWmRiNVVlcnlrdmxYcktDWXNTU1BRRW5E?= =?utf-8?B?T0xGTFlVQ2psMjBkQTJPM2VFZWpGeTBFd25mTW43ejhnU250dEN4VkpmTzB6?= =?utf-8?B?UVp3YVlEaHBxcGh0NW9YakZDZzFxMmxRenJ2RFJIUzBNMGlVZVR6S3FYME9C?= =?utf-8?B?V2VBb0xWMFp5Tk5TZXBUK0tlVHJ0THB5Y0ZpREZGMnJsNy9LdmY0bU95NHN6?= =?utf-8?B?Zm51emlwVGlIWjlValdCd1R4RXVEOVFHZEV3eS9pdVdYaVN5dUlsczhPSHdY?= =?utf-8?B?bHN0MUhOY01OdHI5WXVWYnBHM25UOGxySHRvSHdYd3JZMHB1TWNUQk1MakF4?= =?utf-8?B?MGFCdVVYdHdCZnVrNHhBbU11TlFnZENpSDBLVGdpdTZ4UzlFeUxNc1QzeGl6?= =?utf-8?B?U3FXTlJLTEdFcGZwQnA2eHVROEc5QzRrVUhvYWVxSVJsY3dnMXZoV1gvOFgx?= =?utf-8?B?MG1SYUViT1BHVkExbjhPZHFmQ2F1aVJpdWpCSUxodnAzRmlMcDBUUVNhWG9V?= =?utf-8?B?VG5rZUtsN3pwV0JRaCtHUTVNN3JCQlRNdUZrS3NXUGRFUjBGR3RzWGpqQ213?= =?utf-8?B?TG51VzRIU1Q3Zk1vdDFlbERTOCsrakgzV0tBRlowSStGQmthMkh2WWdZT1ZZ?= =?utf-8?B?TWxOZUlGSUhpL29zelk0eWUrcFBRelN2eEw2cXlDK2RmQ3pQVWlPdGExVi91?= =?utf-8?B?OEUvL2h6bVluZUh6c0laNngreHJ4bzF3S3MzdnVhOXdtVWVDV3BnVkhVaTVE?= =?utf-8?B?S2hwclVhbGJUMFJsVDVZRUJoNXZ6enFRbCt4RWM3ZUQ0L2h2YUlJbXhxTnEv?= =?utf-8?B?SW45WGRvRG9VSHVCb09OUmN4bk9PbHRSRGJ1bEloUitQOVE1aWdDcE1rZ0Iv?= =?utf-8?B?THFiTzI1Ykp1ZlFvK3dzek1NNzNVVk9JYUR1WDRLdnBBZUpFNW9tTkhYS09w?= =?utf-8?B?WEFUeW5GRS84cDY2dVlMRXJtcFBBeG5nTTRvVjkrSlpTNGdwdU1XK2Y5MFBj?= =?utf-8?B?UitDdWx4aHEya2FITmNKd0Rpb2ZuTG95S0oyRDE2Tzc1NXNJeWhRTXBqOFVT?= =?utf-8?B?R2hhdVo2dmlPVzlKdjlLSjFxd1VqUXdiSkpFM1V5dGpHb2lTTEVkUCsxeldy?= =?utf-8?B?TFZNd1NjWlN1dXlUNGxDWkg5RW0rUG1UY0pzM3JGdWV2YWlPOUl6TjJJOGFy?= =?utf-8?B?VmNPQU0vcFJVOERHVWg0Vm94Vi9YNXZRQjQvZ3NkaVQ5UVFoeDZhcmFwUFZU?= =?utf-8?B?OHM3a2ZFRXBsV01UeDRqZ3ZzWStETkxaaksvd3NIVzlhVWd5T3hGUy9uZDJD?= =?utf-8?B?eXNqdjk0MUttM3RxTFJ1QjJYcFBhOU1IVE5INkl4VldCVUY4R3MvZUoxSWhK?= =?utf-8?B?QnlxZWM1TkxSQjA2Yk95djQ0V1o5WlM5bVlBS0ZZVGo2d2NqVFZ4emJwT1FH?= =?utf-8?B?dURlUmhHQ1E0UGxmdi9UdTlNSjdsTDJXMTFqajdoUDhKOEdIYXc5YjVFelJT?= =?utf-8?B?UC90R1lwek1vUGJNSmtZaEE5TE5TcGhYT01sZml1SlJaeGJuYXY2WVdHank0?= =?utf-8?B?OG13c3lacTRTRWgwaFhtOG9yRFFTMTk5RFlCbzdLSi9yMFhsUThqNzczNXRm?= =?utf-8?B?NnpDcXlUU3krekdjYm1uUjFIYVVpK0hCZ0M0NnZWM3AvTHMwcXFMbVUrbU1t?= =?utf-8?B?SHdUU2t2YVFmamN5VDVlenhEWStraXdMR3I5RjFWV3htYnZrdVZndnluWjBN?= =?utf-8?B?ajM2eUl3NldsbnZvL253NUgwZjUrcHRHRU5ORWhiczFITTlDTUJTUnJ6bHNa?= =?utf-8?B?WmRxZ2N6RXdFVnFRNVYzbWVHVkQxMXorY2o5M0VQQklNT2NaWnJLVU5TcXdu?= =?utf-8?B?d1B1MWVxS3g2V2lDQnhxRUkzQ2I2eGJkejdLT1VJaVJuam1UbVcvbnFiRzZi?= =?utf-8?B?eXc4QTJRSlRtcVdiNy9lcEh4YlhxcUVxT3l2RVFHSWtQMVpvRGJxTVM3Q2hp?= =?utf-8?B?ZDNSY1pIUW5PSnlteW1iTGRLcyt1ZjJTc0wyOWlXMnc0WFgzL0VkNFBnUktR?= =?utf-8?B?cHJrWWhIcmg2UWVKdStHSEhxRU8vWXVtZE9sdUNMWXRUZ2V5cDlEdlVoaWtQ?= =?utf-8?Q?/EQB3ifp2fElO+6NtLNK/KjqN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d0089fa-893f-4081-5f54-08dac9604f14 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 12:27:50.8375 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wfZKIA9MKuFRHwhiLh3oIQ+senolfnhNkiFywootz90IEdT+K/0k78KoEcypVZC71A/LWHSU81TMKwH7eTRP3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7800 On 18.11.2022 13:06, Marek Marczykowski-Górecki wrote: > On Fri, Nov 18, 2022 at 08:36:14AM +0100, Jan Beulich wrote: >> On 18.11.2022 03:35, Marek Marczykowski-Górecki wrote: >>> Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until >>> the table is filled. Then it disables INTx just before clearing MASKALL >>> bit. Currently this approach is rejected by xen-pciback. >>> According to the PCIe spec, device cannot use INTx when MSI/MSI-X is >>> enabled. >> >> Similarly the spec doesn't allow using MSI and MSI-X at the same time. >> Before your change xen_pcibk_get_interrupt_type() is consistent for all >> three forms of interrupt delivery; imo it also wants to be consistent >> after your change. This effectively would mean setting only one bit at >> a time (or using an enum right away), but then the question is what >> order you do the checks in. IOW I think the change to the function is >> wrong. > > IIUC the difference is that enabling MSI or MSI-X implicitly disables > INTx, while enabling both MSI and MSI-X is UB. This means that MSI > active and PCI_COMMAND_INTX_DISABLE bit not set means "only MSI is > active" - which the function now properly reports. Hmm, yes, this is perhaps a good way to look at it. > Both MSI and MSI-X active at the same time means a bug somewhere else > and the current code allows only to disable one of them in such case. I > could replace this with BUG_ON, or simply assume such bug doesn't exist > and ignore this case, if you prefer. BUG_ON() would imply this state cannot be reached no matter what is requested from outside of the kernel. I'm not sure that's true here, so keeping that aspect unchanged is probably fine (and with the above I then take back my "wrong" from the earlier reply. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 18 12:31:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 12:31:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445685.700971 (Exim 4.92) (envelope-from ) id 1ow0Wi-0003gM-64; Fri, 18 Nov 2022 12:31:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445685.700971; Fri, 18 Nov 2022 12:31:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0Wi-0003gF-3V; Fri, 18 Nov 2022 12:31:24 +0000 Received: by outflank-mailman (input) for mailman id 445685; Fri, 18 Nov 2022 12:31:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0Wg-0003g9-9N for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 12:31:22 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e82c801f-673c-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 13:31:21 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B12D322638; Fri, 18 Nov 2022 12:31:20 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7E5CD1345B; Fri, 18 Nov 2022 12:31:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1JBtHRh7d2MJCwAAMHmgww (envelope-from ); Fri, 18 Nov 2022 12:31:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e82c801f-673c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1668774680; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jsX2YHFa1g562+NVwBhz1DAgpbN2aWZJ8UbIyhfdKlk=; b=R2+Ek2HNoB9WYTGYI2q2+g2IpJKd/hsab2uUj3uhEYuIGhXtYzP2BmJSgFFJkC8Jnr79rG bVqDoX8uUy1VX4xar4p/Pn4mTk/kVgSrgBoPpdIN52r1W7g262EoxALfYYxX58QOFkzko4 rjItdN5S1aPV9PTIwiv7yWCEI7Nratw= Message-ID: Date: Fri, 18 Nov 2022 13:31:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------cC7yRuRpFun3ITprNeAFYLdZ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------cC7yRuRpFun3ITprNeAFYLdZ Content-Type: multipart/mixed; boundary="------------O3hSBdtzYTgg03q05z2IzBZb"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant Message-ID: Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled References: In-Reply-To: --------------O3hSBdtzYTgg03q05z2IzBZb Content-Type: multipart/mixed; boundary="------------u3bGQotOolJEWpCswRpv1FFn" --------------u3bGQotOolJEWpCswRpv1FFn Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTguMTEuMjIgMTE6MzEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBMaW51eCdlcyByZWxh dGl2ZWx5IG5ldyB1c2Ugb2YgSFZNT1Bfc2V0X2V2dGNobl91cGNhbGxfdmVjdG9yIGhhcw0K PiBleHBvc2VkIGEgcHJvYmxlbSB3aXRoIHRoZSBtYXJraW5nIG9mIHRoZSByZXNwZWN0aXZl IHZlY3RvciBhcw0KPiBwZW5kaW5nOiBGb3IgcXVpdGUgc29tZSB0aW1lIExpbnV4IGhhcyBi ZWVuIGNoZWNraW5nIHdoZXRoZXIgYW55IHN0YWxlDQo+IElTUiBvciBJUlIgYml0cyB3b3Vs ZCBzdGlsbCBiZSBzZXQgd2hpbGUgcHJlcGFyaW5nIHRoZSBMQVBJQyBmb3IgdXNlLg0KPiBU aGlzIGNoZWNrIGlzIG5vdyB0cmlnZ2VyaW5nIG9uIHRoZSB1cGNhbGwgdmVjdG9yLCBhcyB0 aGUgcmVnaXN0cmF0aW9uLA0KPiBhdCBsZWFzdCBmb3IgQVBzLCBoYXBwZW5zIGJlZm9yZSB0 aGUgTEFQSUMgaXMgYWN0dWFsbHkgZW5hYmxlZC4NCj4gDQo+IEluIHNvZnR3YXJlLWRpc2Fi bGVkIHN0YXRlIGFuIExBUElDIHdvdWxkIG5vdCBhY2NlcHQgYW55IGludGVycnVwdA0KPiBy ZXF1ZXN0cyBhbmQgaGVuY2Ugbm8gSVJSIGJpdCB3b3VsZCBuZXdseSBiZWNvbWUgc2V0IHdo aWxlIGluIHRoaXMNCj4gc3RhdGUuIEFzIGEgcmVzdWx0IGl0IGlzIGFsc28gd3JvbmcgZm9y IHVzIHRvIG1hcmsgdGhlIHVwY2FsbCB2ZWN0b3IgYXMNCj4gaGF2aW5nIGEgcGVuZGluZyBy ZXF1ZXN0IHdoZW4gdGhlIHZMQVBJQyBpcyBpbiB0aGlzIHN0YXRlLg0KPiANCj4gVG8gY29t cGVuc2F0ZSBmb3IgdGhlICJlbmFibGVkIiBjaGVjayBhZGRlZCB0byB0aGUgYXNzZXJ0aW9u IGxvZ2ljLCBhZGQNCj4gbG9naWMgdG8gKGNvbmRpdGlvbmFsbHkpIG1hcmsgdGhlIHVwY2Fs bCB2ZWN0b3IgYXMgaGF2aW5nIGEgcmVxdWVzdA0KPiBwZW5kaW5nIGF0IHRoZSB0aW1lIHRo ZSBMQVBJQyBpcyBiZWluZyBzb2Z0d2FyZS1lbmFibGVkIGJ5IHRoZSBndWVzdC4NCj4gDQo+ IEZpeGVzOiA3YjViOGNhN2RmZmQgKCJ4ODYvdXBjYWxsOiBpbmplY3QgYSBzcHVyaW91cyBl dmVudCBhZnRlciBzZXR0aW5nIHVwY2FsbCB2ZWN0b3IiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBK YW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNClJldmlld2VkLWJ5OiBKdWVyZ2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0KDQo= --------------u3bGQotOolJEWpCswRpv1FFn Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------u3bGQotOolJEWpCswRpv1FFn-- --------------O3hSBdtzYTgg03q05z2IzBZb-- --------------cC7yRuRpFun3ITprNeAFYLdZ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmN3excFAwAAAAAACgkQsN6d1ii/Ey9D vQf+Pwt/pOCZEsWZxv64NJAw8UANWjWp6Ss/nz2StTqgPhTVscEKXqwaBgMYZ1BnnoSSiOsDS7II X7Ztvt4nZwX0iaUW4veBlOnZA4J3WYzboHgDk5tbG/Sfwlu82BRq+M6JXvLfpuwH3cXFMIa5Z2OB P44x04eZYYEuVdN2TmD7fdc+vVJdkQ3rmPqQ9oldUVMpe7JhSByjSsqTosyncCmcGb0yVwyLsRGO KUKHQJ88EHRlufGxSCCkTjUcmtgJbFdkrC45jdD/G6bzPRHpQFZzWLExWj1wimlPQFGrliM0JXhi BP7IowzKnyyP96uVjlgOWxPLlRy6CG2Xf5ngSETnNA== =pbrh -----END PGP SIGNATURE----- --------------cC7yRuRpFun3ITprNeAFYLdZ-- From xen-devel-bounces@lists.xenproject.org Fri Nov 18 12:33:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 12:33:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445689.700983 (Exim 4.92) (envelope-from ) id 1ow0Ye-0004F8-IB; Fri, 18 Nov 2022 12:33:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445689.700983; Fri, 18 Nov 2022 12:33:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0Ye-0004F1-Es; Fri, 18 Nov 2022 12:33:24 +0000 Received: by outflank-mailman (input) for mailman id 445689; Fri, 18 Nov 2022 12:33:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0Yc-0004Er-Bn for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 12:33:22 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2e3a7e09-673d-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 13:33:20 +0100 (CET) Received: from mail-bn7nam10lp2102.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Nov 2022 07:33:02 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by CO6PR03MB6228.namprd03.prod.outlook.com (2603:10b6:5:35c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Fri, 18 Nov 2022 12:33:00 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860%5]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 12:33:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e3a7e09-673d-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668774800; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=zL55OUZT4Sr4OkWMRHz8kqZ0mKqRB9gitDIWm5zUuEI=; b=aQMMevKB1BAx0XLcS8m1Kt36aO9jrX+kdn0N7xUZtw8XzTFzmbh5x/Mo L/6zI1GKdHgHcExiOVTg523S/TgpIiK+oandGKQsroboyR/QgayseDP21 3bcv491mcbque6xzm2cLEKb2QIVAi6y7iJOQ6HwG5kZF9w5nmyTUEdDeK U=; X-IronPort-RemoteIP: 104.47.70.102 X-IronPort-MID: 87651584 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:dskmgap76krcykSpT184FB3EtTteBmIoZBIvgKrLsJaIsI4StFCzt garIBnTa/qCY2Gkco9wb4qwoU8Av8OBz4MwSwY++CxkECtG+JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzilNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAGspQRDSvruw+bKmcM41qMkaffb7I7pK7xmMzRmBZRonabbqZvySoPV+g3I3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+CraYKPEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXoqaA32QDDmgT/DjUmT3jimdzi1HWCQslEK GIPoDIEtbc9oRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hSy2ETgYKykFfyBsZRMM/t3LsIw1yBXVQb5e/LWdi9T0HXT6x W+MpS1n37EL15dTjeO84EzNhC+qqt7RVAkp6w7LX2WjqARkeIqiYI/u4l/ehRpdELukopC6l CBss6CjAComXPlhSATlrD0xIYyU IronPort-HdrOrdr: A9a23:2Cb2B6FyAVNG4blzpLqFwJLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oK+RSDljSh7Z/9Cly90g0FWz1C7L8++S yd+jaJp5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjow4OyjhkQGhYaVmQvmnsCouqO+ixV42mJ 3nogsmPe5093TNF1vF7yfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqA+7I t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1cwKoVKuZEIMvJ0vFhLA BcNrCb2B+QSyLCU5nthBgq/DVrZAVqIv7JeDlYhiXf6UkqoJkw9Tpl+CVYpAZByHt1ceg72w yPWJ4Y641mX4sYa7lwC/wGRtbyAmvRQQjUOGbXOlj/ErobUki94qIfzY9Fk91CQqZ4uqcaid DEShdVpGQyc0XhBYmH24BK6AnERCG4US72ws9T6pBlsvmkLYCbehGrWRQriY+tsv8fCsrUV7 K6P49XGebqKS/rFZxS1wPzVpFOIT0VUdETuNw8R1WSy/i7YrHCp6jearLeNbDtGTErVif2BW YCRiH6IIFa4kWiShbD8WzssrPWCznCFL5LYdvnFrIoufkw36V3w3gooEX84N2XIjtftaFzdF diIdrc49GGmVU= X-IronPort-AV: E=Sophos;i="5.96,174,1665460800"; d="scan'208";a="87651584" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dlf0CX2djrbbYInKr2uS/VolwbkKcSAbI9OXEBgCbqhMS2TMV717P5dZlChLhZyB7VlWb/K7OEc/rpslkCVVtQAVofNnWHkoZS52AkG/RHQpwc9m76+RFena05VxzyE92SM9bWwY4VhY3reeUqivo8hsEp508f/BSKbzZVi9Wjbj9BBi6pjpM2raMg7q4vUTcRZTKqvgNN1OU1cbmF1WT1p/pPcvbY84p8TZGz+KzHXpMZRrpct1891xaratRSaUTbJtgeJcSAHsTO8W7622niCJ70xYSABt8ElWaTkp9YAtCP7o6mJy7xOgnD3tvkoAVI9caYJxicifWl0hglHlPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zL55OUZT4Sr4OkWMRHz8kqZ0mKqRB9gitDIWm5zUuEI=; b=lJE3gOXpQ39M5bKUl7/3zUoCmhhoMyz1+Poi45YfCBVShUZoJc0tCqDntsNQHNxQSw5hMVi61RrXWvpHi7RTtdOiCSx5/ZzqV9Uw78ZcdH9avJPMebbcOyoNRwH0dDt+Uca4F2aIdjNMHg1CRUgpG3pgkheaCsafh3U6YDkyu19qubcHhLD2yray+BNsLknAx75OyAFL6GAjZamNyXbE3mv6i5RLcRwXZtjBgYf7laVmII09VyBgCXCBnBMTm3s7kA2LJzAw+BU2wSuxM8N9ndD31hvkE9KbeDkYM51JXIwjmTWc8rtUg64lkR+JLzU19lrV+MsFJzYmJ7hdjB3qIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zL55OUZT4Sr4OkWMRHz8kqZ0mKqRB9gitDIWm5zUuEI=; b=WoZwLN4Do9x2/UEOKCUeMVk2W5uDGi4IxTMJfgFKEb1aeuNzDHMfjZxpHc0NuwlMeqaJV+xoy1XwJ6coRZ9/Eel+V9y7MQ2mS48MDStqTRRFisa8luCDlcjKFYkJfEZtnkPXeykePG5zpYi0EAgcyyQJyz2LeNMJACPP+Krjt9o= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , Paul Durrant Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Thread-Topic: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Thread-Index: AQHY+zjv47cM7GZ23kWVhiI/91aGOa5EnVaA Date: Fri, 18 Nov 2022 12:33:00 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|CO6PR03MB6228:EE_ x-ms-office365-filtering-correlation-id: 0e3b0f27-8d98-40c3-f739-08dac961079b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: abBK+S9ukSgxXJIRHbpk9jO+7r9GUw0Q+9dCb6FJabxoK8SOE53tmeJNtZdu0tzbPT8MFpOKmppS8cvVe7rNOsxFroeczA1FBbRSerCU/pu1cuVhMAehr9vtnQViZvrlgk9hOfAXwYGiGZDl1P+uht7bnwlmhGDd87HQGAT2gjovJHnYOtPkQHzLAfly+wyl/xpbkIsYI63I5PK0mixbR5I0gsYJq1JpZ48Rfjqq1aSQS67RPiEampth3CcpXG+u8T0YeITxVCvYVGDwn8ZqFigYUag8y2eH9HOnQRay+TDn6Mdv+MZHuw1GMyZ6fTYj6XzwJqWJm7WKzVzR07VGb1F0kpjFFv41Q4WTyL5VDLtRaMOIkmQp/BsZW3RL6t9HPeOBevIvlaSPzzEoZUTnSXwiIxRr+6HHWJopwJBPwhu8sjRN1oDUZLfeg+PVCy1/sR2JGrpX5YIBeeUHs2+MBOi0MZAAV2PlzEXLNhvrdUOdjVNe3+Ab2lMhPAVgG5pip60hC5zZ+bdFvDrWdn5LA128XHJkZDmRdiv7Blpj7jx05a9DBgfxGO7qzExWN4BMbSk/Pgt3iYXg6KtSc66uxutEGMijj8LNy9ZTTDuW4aB5bPEaQbWGRY2pK7SI1poscaZMZeLNPuo3a2jDSyx2rjfpt7FiQjZ1boyS5F3ymns/zRuiLT59PEk5LqHbrg4vQbs6d2ktBpvlJ9qy5MUnRjBnwxxQ6I2lvUe1eYMPBesSDD1ZbOk+3a53XkpHqqCI5VaKuflidueBiDXR+zNqyg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(376002)(396003)(136003)(39860400002)(451199015)(71200400001)(478600001)(31686004)(6486002)(8676002)(26005)(66476007)(8936002)(4326008)(66946007)(64756008)(36756003)(66446008)(66556008)(76116006)(6512007)(91956017)(186003)(5660300002)(110136005)(53546011)(6506007)(316002)(54906003)(2616005)(2906002)(83380400001)(82960400001)(86362001)(31696002)(122000001)(38070700005)(41300700001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SkRDSkN5LzRNK0NraGswVzNxbWxLajhYYkZwTU9IQTB6bk0xN1JpTHl5bVk5?= =?utf-8?B?dmtzdWcyRVRzbFRzaWlQZlJBWFdBRVZjQjFqSEg5emFXZUZCRnI1UDE0SDk3?= =?utf-8?B?NGErc3NzSW1KOTJHdHh5QVh1YmZJcm91WUppaU5UemhraWJROWd1UUx1enhR?= =?utf-8?B?Y1RxWXpkYnhBS1JLeWR2QUJZTnNsMmJjZGxwVU9hT3FaUWFmV1h4eFJtbUZF?= =?utf-8?B?Tkt2eFpZOE5BMC96cFlMZDVicmVaazNZMkh2emF3QTRBNW9hS1NHWTNrNkVv?= =?utf-8?B?Z1A5RExnM01KWVl5anEyZ3JHaVdqOVlSSW9xWlNMdmpZMjU2VlptRFp0U2pE?= =?utf-8?B?eEpibHVmcTBRYXhQQUhrQjNtaVlMVmxuRERkRUl6M0ZXeVE1a2RUR0JZQjcr?= =?utf-8?B?QmRsSnhsWURSZnJTTkJGeVdGYWtxeHZEVjk2RURXbm5xdEJ5bWlFcllZTWtB?= =?utf-8?B?a3pjMm1Md1JVVWswa2h4REdtejlReC9sZFBPZzg2UkZQRFMzMERmR1JuNDdE?= =?utf-8?B?L3lVNUNuQjFFN1NSMnUzMlpmSjJsY1lkRXBJb0hmMlhsL2ZEZm9rSVd0VnpE?= =?utf-8?B?djBJbU0rNjFmQkMxNkJEY2MxUFM5UnJtbkYxSHJPamJVU2tvZmFxelNKeFlO?= =?utf-8?B?eHROOTQyaVppSkh3WW9yYVBvdkxsc05BUjg1SWdnWVJ1VllOWU5uNlBGSzFl?= =?utf-8?B?VWFWbVVZNCtrdDFRL0RQQU5xV3NscmppVFRndTN5YzkxOE1ycjM1Z0plMGx3?= =?utf-8?B?eDNER0g3Tlh2QURGd2FHV0MvZnNla3Nkc25lb3ZiNkNMRkFPcHhWek9CdXNS?= =?utf-8?B?WStOS3p1b3p6aHZMZERHS1BzK0xPekxxQW5HaVpyL0RiWTJ0T05vL3Z3TW1m?= =?utf-8?B?amhhOVNkVS9DSXVTMUF3V0dIZU9sdEZSZ0RZSWtnR3M5N0psYVFETWF0R3lM?= =?utf-8?B?YjNBWW1zNUR0RGdySnc2WFQ3VEhhRGIxbmV2aGE1eFpvT0x5QXJqdUZOTnFj?= =?utf-8?B?Y2p6cGk3NWNqUnZVNU9aRy9HNGxXek9OOVFzM1Q0ajFoOHZyd2ZhTDJFdDhK?= =?utf-8?B?VktrRS8vYWptWjZ2S3N0cWMvdnlCTU1yRXFCaFpXRzlFZ1ZlL3VtWnFkd0F4?= =?utf-8?B?TXVLeW9FSFphemRFT1QyREZ3d3VucjJ5cURjUEs2S3FsVW5ZYXh5aXNKa0ZY?= =?utf-8?B?dHBhRlJrZi8xVVBSY3BPT0lPTit5VGlQejNLZGgvOTdOZlk1anBWUkdBVFRv?= =?utf-8?B?dXE5MzdFbVVGeU1kOFoyU0htWHd0ay9nMm43aWU3NC90QmhwS3UzbzVsbndW?= =?utf-8?B?THhqWlZ1aUw1dTJMM25vWVlnMmtKUVgrcWN5RmhCNFpHRVVqMGFGeU4vYjF0?= =?utf-8?B?eTJ6c0ptL1hPRnB4U1dYNHplWWtScmtTYTFBUHA5UmQ1WVE3Wk9vaTFqNWNN?= =?utf-8?B?R2dtNFdtSWFmQU1acFdhbEl5dVNTYy91Q0tUNkZleXNVQlBjNUp6MitUUVFG?= =?utf-8?B?SFdvR3R1ZStyQ1VocnRNNTZQMGdCRG03NEFrcE5KMVJCMzRRMVRPc0gyNmx1?= =?utf-8?B?ZklYZUtSNzJ2Mll3cWdjaS96dytiUkZ4cVJHMXlMSHdBdFJVZ0xtM3llUTI1?= =?utf-8?B?bTdkVURKZG9CaERhaGxoY08yYzRpQTFJU1Y0UkZTZGJ6bzFVVnhBeU9BU2dT?= =?utf-8?B?b25wZkdvcjM4LytpRGlrNVlWVmk0bUZHa2RsYlpHekVKTVBLMUYxTDJXU3NL?= =?utf-8?B?dUQwOEtsaXkvK3JkK0UvQ2VZbTRLSkROL2lLbFZwRE5XMGxpWmdFQzdHY1ZO?= =?utf-8?B?dzVwQk8rQjJRMzFqSXVXMUJZb2llOFkzYlZvNWo5UjJYS3dYNk1RL1NSeDJU?= =?utf-8?B?NFVjdzBWN1NucEdyRHQvb2tFYWdVWU5UNTlaeGhKb3QxemFBQTE5TFVHSUN4?= =?utf-8?B?RFdQSk50RVppR0NIOUx1K3NzWmtGUFhxQlZ5d3ZwQjJ1Y3JEb2lTOHBTcHR6?= =?utf-8?B?N2ZTQnh2dzBNY29WSHAwTnBZN2tseHVWTmRha3Vzd3QvT1NHN3VpK0xJS1lN?= =?utf-8?B?YmRRVlZ2dHhDM0tvRG8vN1FLbjdnbm5mYkM2TjFPNDVmdTJQNTdBODUxVjJy?= =?utf-8?Q?8yGFIStdtRJS3hpcOJRmWIte5?= Content-Type: text/plain; charset="utf-8" Content-ID: <64093F0D7C283C44AE97534053BF191D@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /Lf7U4EeO70lQr/eETPF43BLw3c1IttMKXsXFd9PrTtUmco+4x0rXgFLxGliJTRNJmyrQ6SvPTRl3jMTgA7YpHWey7NsywFn1mTrBYXOtVWXeyCGx+QAUCsa3ALKgz9TNulqXuIr7XtAOuvSl4q3gGCIhCmMG+I8OiF26K/+S88k7NS6XIDtzP2nTYwcDLoGbgNtxdJoZwH8RauHtekgp1qewhafngA2rjN6wGstPxKmffbQm7HWCQSJhyknaGuAjdEecxTBBx0EW/zEyXreeLEUapGbrzvu0gSbUt5LES8+rUDg92zG/840p52GnU8WGALK6XmCIWUfrj+Ej2yESrGb8UolxVD7ZArT3nHQGXHchMInDN929+O9S+Qj1+Va0ndD4Q7ldL9VYEFQTLeNoPNq0Y367mxfqKm2Cz45Y8uD67xBq0KFIEuh/fMDd/CzuG1PQ3vjcK02AqQpluQ75GXrEdHATzGLW9nUXr6QjTAR8dYwfagVOueyhYb0S4vTSbzCvZrlMfabQLmeGemKECYhO1FDItjg81fHJppa3KRC2md/VZ76pKUe5UgrEJBAiBsTfljKFKgNkUJ+cPEMdg9j1rAdX/TKCKhWekkum1/WxTckDp1g5NEnle/CAknogatGsKV7cfUj7cR+foZVNRnEZaYeS8OPQihscDfBpTIbbFLZCPlaA/3Y9vr9wvyS6AslOJdjNbgGJlqV+wuWrHGxY7C3J2dv8ToYH4z324YoShJ/M5mesG8t3QRZGCrorsOF9tswgfhtUFJhSGd14P8TvAYhw1Z17xzOPs9/V1FVX9Z0ZeizRUJPezu70NHBgvNePpyV7Qmv2taPGfHDML5t4zzZZLp8H4SLoL0k8u8= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e3b0f27-8d98-40c3-f739-08dac961079b X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2022 12:33:00.2394 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JanA6pzShuOc0IJ5X4sdmKpzdU98EgclQzAmlO6Xsrv+JKFDgutg59yeDAE+E4rwzF4aD/20TKxceyzRZNjDmmZVOpNPjIZPWYuT2BiufG0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR03MB6228 T24gMTgvMTEvMjAyMiAxMDozMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IExpbnV4J2VzIHJlbGF0 aXZlbHkgbmV3IHVzZSBvZiBIVk1PUF9zZXRfZXZ0Y2huX3VwY2FsbF92ZWN0b3IgaGFzDQo+IGV4 cG9zZWQgYSBwcm9ibGVtIHdpdGggdGhlIG1hcmtpbmcgb2YgdGhlIHJlc3BlY3RpdmUgdmVjdG9y IGFzDQo+IHBlbmRpbmc6IEZvciBxdWl0ZSBzb21lIHRpbWUgTGludXggaGFzIGJlZW4gY2hlY2tp bmcgd2hldGhlciBhbnkgc3RhbGUNCj4gSVNSIG9yIElSUiBiaXRzIHdvdWxkIHN0aWxsIGJlIHNl dCB3aGlsZSBwcmVwYXJpbmcgdGhlIExBUElDIGZvciB1c2UuDQo+IFRoaXMgY2hlY2sgaXMgbm93 IHRyaWdnZXJpbmcgb24gdGhlIHVwY2FsbCB2ZWN0b3IsIGFzIHRoZSByZWdpc3RyYXRpb24sDQo+ IGF0IGxlYXN0IGZvciBBUHMsIGhhcHBlbnMgYmVmb3JlIHRoZSBMQVBJQyBpcyBhY3R1YWxseSBl bmFibGVkLg0KPg0KPiBJbiBzb2Z0d2FyZS1kaXNhYmxlZCBzdGF0ZSBhbiBMQVBJQyB3b3VsZCBu b3QgYWNjZXB0IGFueSBpbnRlcnJ1cHQNCj4gcmVxdWVzdHMgYW5kIGhlbmNlIG5vIElSUiBiaXQg d291bGQgbmV3bHkgYmVjb21lIHNldCB3aGlsZSBpbiB0aGlzDQo+IHN0YXRlLiBBcyBhIHJlc3Vs dCBpdCBpcyBhbHNvIHdyb25nIGZvciB1cyB0byBtYXJrIHRoZSB1cGNhbGwgdmVjdG9yIGFzDQo+ IGhhdmluZyBhIHBlbmRpbmcgcmVxdWVzdCB3aGVuIHRoZSB2TEFQSUMgaXMgaW4gdGhpcyBzdGF0 ZS4NCg0KSSBhZ3JlZSB3aXRoIHRoaXMuDQoNCj4gVG8gY29tcGVuc2F0ZSBmb3IgdGhlICJlbmFi bGVkIiBjaGVjayBhZGRlZCB0byB0aGUgYXNzZXJ0aW9uIGxvZ2ljLCBhZGQNCj4gbG9naWMgdG8g KGNvbmRpdGlvbmFsbHkpIG1hcmsgdGhlIHVwY2FsbCB2ZWN0b3IgYXMgaGF2aW5nIGEgcmVxdWVz dA0KPiBwZW5kaW5nIGF0IHRoZSB0aW1lIHRoZSBMQVBJQyBpcyBiZWluZyBzb2Z0d2FyZS1lbmFi bGVkIGJ5IHRoZSBndWVzdC4NCg0KQnV0IHRoaXMsIEkgZG9uJ3QgdGhpbmsgaXMgYXBwcm9wcmlh dGUuDQoNClRoZSBwb2ludCBvZiByYWlzaW5nIG9uIGVuYWJsZSBpcyBhbGxlZ2VkbHkgdG8gd29y ayBhcm91bmQgc2V0dXAgcmFjZQ0KY29uZGl0aW9ucy7CoCBJJ20gdW5jb252aW5jZWQgYnkgdGhp cyByZWFzb25pbmcsIGJ1dCBpdCBpcyB3aGF0IGl0IGlzLA0KYW5kIHRoZSBzdGF0ZWQgYmVoYXZp b3VyIGlzIHRvIHJhaXNlIHRoZXJlIGFuZCB0aGVuLg0KDQpJZiBhIGd1ZXN0IGVuYWJsZXMgZXZ0 Y2huIHdoaWxlIHRoZSBMQVBJQyBpcyBkaXNhYmxlZCwgdGhlbiB0aGUNCmludGVycnVwdCBpcyBs b3N0LsKgIExpa2UgZXZlcnkgb3RoZXIgaW50ZXJydXB0IGluIGFuIHg4NiBzeXN0ZW0uDQoNCkkg ZG9uJ3QgdGhpbmsgdGhlcmUgaXMgYW55IGNyZWRpYmxlIHdheSBhIGd1ZXN0IGtlcm5lbCBhdXRo b3IgY2FuIGV4cGVjdA0KdGhlIHdlaXJkIGV2dGNobiBlZGdlY2FzZSB0byB3YWl0IGZvciBhbiBh cmJpdHJhcnkgcG9pbnQgaW4gdGhlIGZ1dHVyZSwNCmFuZCBpdCdzIGEgY29ybmVyIGNhc2UgdGhh dCBJIHRoaW5rIGlzIHdvcnRoIG5vdCBrZWVwaW5nLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri Nov 18 12:33:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 12:33:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445692.700994 (Exim 4.92) (envelope-from ) id 1ow0Yx-0004fN-UZ; Fri, 18 Nov 2022 12:33:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445692.700994; Fri, 18 Nov 2022 12:33:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0Yx-0004fG-Rl; Fri, 18 Nov 2022 12:33:43 +0000 Received: by outflank-mailman (input) for mailman id 445692; Fri, 18 Nov 2022 12:33:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0Yx-0004eu-Da for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 12:33:43 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on061b.outbound.protection.outlook.com [2a01:111:f400:fe0e::61b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c534490-673d-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 13:33:42 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7542.eurprd04.prod.outlook.com (2603:10a6:20b:299::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 18 Nov 2022 12:33:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 12:33:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c534490-673d-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cpw8GUIZY5wICsc80KaP52YExrBcVIKDZiOhLNo/Ch9PDNdpGz0PhDx27T/jFqsgDNecW8w9mBCyCmDiRdH1WDFo2EFxOR9PS95jWXQnFbv5TNOHC1mtgf8Dt74qxufhTholsuBhpDIewIgWtW9O0aYJex5Yvi32J9gkNY0JzUGya++FbZVmpiCXraJhK78rC+nBNCeqgUiWiWTAc9RS0YceVoT/IZDdxwqrsqZArgwR7kJeBUl5b3PZfY8yHFSBDgzRILi+j15wJkO7Hd0zPLz+qIo+mRHokt/lvF6MVHxMVBdSIexMGZY0Kcbn6hrdUxucsIeY0SSXzvZ2TX91Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4RoYC2/PD+8f5/Drcc6saJIflqzzbsLV/xm7Y1nUgtg=; b=mnjUMoeCg9jQSAZo6YPmDTcZRbVQPA1wQDlLf+gPveZg5smru75zqsSI9QaHt1S8G1qDBjo2psTTDQJXpeYjxtb7oIvfYCNGke6Yiloofg/tk4NRLzK/YOfl7e3bCRvnFV7yX6llgqC7QXCjCmMHZ4BnvbAhq1kD4otWp+94PKrdatZEKONItOWIpBUQnw8zcfW8oaWEs8Ipe+7YK2Gs504eRS/TXCqbVWhCncqWaw8Lseef3F2fFj7vmk1MlqGipkSjkFWnF3Yhm4ua7T8paDzXQnHi47wmL6QYHRcdUtHBeU/Ufdy03F7ferHtqDOEUjNwGfbU3E9JM/4RlgYnHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4RoYC2/PD+8f5/Drcc6saJIflqzzbsLV/xm7Y1nUgtg=; b=4FsPR+nfGaRAE/C6kK3Mphw6XBMQpEh6ZrB99dm5HqlfwWbdkCclok3t8CtbIDJEzBVk/x4Put+rSEztotiNIo07mx9XZ5hwTWm+ItvhWU1+NnPvyitYYGNJzB9jC2VwGmq5rKx67xUMvuu7KJmJfipGBl5MZ2rlsJhc2UBNWTtL4OUaUt0icWibF6cNLfvFIGHzRPHq6BuTZARwx9QZmT/vq3NdtUmn5ZQS+X8rUVWuJ+cm358nrmmhkV5DtuxgpoLORC9+Mwewqmy1LDy416WYRw2ZfFM62qa9/FMhQpiQqIpihoyvN+J7DyHajTENgiWzeqWo8C0O/xg4s06N1Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9d034957-822c-74ba-9aea-0944cc456870@suse.com> Date: Fri, 18 Nov 2022 13:33:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/2] x86/msi: Allow writes to registers on the same page as MSI-X table Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20221114192100.1539267-1-marmarek@invisiblethingslab.com> <20221114192100.1539267-2-marmarek@invisiblethingslab.com> <15138618-5cb0-8304-a56b-cb787e187772@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7542:EE_ X-MS-Office365-Filtering-Correlation-Id: 423dceee-9ecd-49a5-ab44-08dac9611f9b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VXI3lhtxezT00TqomrMD8T7HUkTVOUEP/eocRud/WtR9BOd7Xgeq2BoaK/JIBIs5RuR9lUclLkPf5Co5D9+MzJsftvhsM/jAAnbr8nZ70RruRMdkkJsfgfSxo7bL6B8V4CMl3KJKDsumKWK9XUXBPJ7LTeh0g9hoZ1R2MaqU5va7vkg83CEQHB4wV11Q6cxCPpppr4yrt6woOMKXvXqwwbzQ0wYG+QsKwvvRQ1P7lBgRwWacIX/dy0FB8dkpPLypE6Cw4p1OIOL/FeLq2kXNY+G9VYSx4MvLTOV3ic+/1bkOdSE76v5XlPGZ2s1nqtqOyziKuDaZ4zH0AOhgSsezmN1co3ptdx25o/wMD/RjcDu3YCTv3x+DU7QbgdC7DHyO6//OQXwNrVaDq79iIgGnub8MrmB5L1hAG22ukjX6CR6aO+1FyvbwfPjo/JVsrxQDdq212yBjv8cqskwduIXwZKnQ09WpPegc4MPultZopnPuFRBjh2dzwvum3ViFBuqIXxGHJue2G4irbu+eJP0i62Qz7h/AFKy1I+MRNtW5uBV5AfVsSV07mtOOzVD98Gf0V33YHiFKRpo3i6flgPfK+u1radLJsnt9XKZLttrHV35hbgPrDuaa0Z5R1/aKi9MuEUkPGxZE+xh/TrnZAfTW8Ai7laa22jfYKa6DkU2W6EKKVaRTe1vW/Q3UO4O7R7p7SKokNBG9ZA7dlsuY1lJ+DeTatzzXUNXz5U10Afsjcyw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(396003)(346002)(366004)(376002)(451199015)(8676002)(26005)(4326008)(66476007)(66556008)(36756003)(6512007)(66946007)(2906002)(186003)(38100700002)(478600001)(53546011)(6486002)(86362001)(6506007)(2616005)(316002)(31696002)(54906003)(6916009)(8936002)(41300700001)(5660300002)(31686004)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NktWdzg1bnMzSXBOeTdoaWhDNGxFN3U3ZlFiS21nQ1U3czJSS1lGSGdWdHEz?= =?utf-8?B?OE9ac2kyaGM2cS9EY29UbWMwYlpISytrN2JVRFpYY3h1Y21EdWdGcU1BQXB6?= =?utf-8?B?SnRJU2NNamVIelVqcktiVTcvM3VPVVIyMWFFdkI1Vjk5QmFTTUZoZmNPYUFE?= =?utf-8?B?Umd2a0dMUnZyWDBFUjBPekZjbHFRYXlRNTBGa3Q0bGxIdkNPMTNzcStkMUJl?= =?utf-8?B?eUVsMllyRGdrV3J1K0tpSXhSV0FkVERNa0cyaUdXcm5ZNlc4ak9YNkZlSzNu?= =?utf-8?B?Y0RiY1RzLzRUZHhNWlZpZXNyNW1NSUZMY1BPUk1Fc3pndWdQYUw3N2lMQTVO?= =?utf-8?B?Z3VZcGkxMUt4NXRmdHhTVEtSblZ0UHFSaGlKOGFybU5qbGJTRDFpWEhPeTU5?= =?utf-8?B?dS8rZkpTU2NnVDlNMERlZHIzV2JYWXl1WUFsYUpoam1tRUJtM0pHcHlBdWJl?= =?utf-8?B?dHNubXpVS3d3OFFoeHVUa3VLT09zNzNBeUtCNkRkcUpwZWI3SXV6Z3BtNzUz?= =?utf-8?B?eUgwVjV3amhHNnFDQndOd0QwTU90Ym9YeUpraExoSldnRXFkeHB3c2g0M0pq?= =?utf-8?B?TTdWV0hmeHZLN0crTlUwdHJ3S0ZmNjVGMFpteEhmYUpKWVNsei9PcG9zSkho?= =?utf-8?B?QVJ6ZWxEVUhXejlmRDkySXcwY0REeEdSUnpBbldCRjRqa2c5ZE0wSmovd1Uz?= =?utf-8?B?aXNldEVZTnozb2EyTUVNWmFmMFZBQmZRcWhuY0N3MUhUNEJoRFhQaGp5RmFJ?= =?utf-8?B?bmFFc3B4NU51M24vekRMd3B0dFdSSnc4ajUxZ2JIVHFEaWNFUVpTQXNiYVR4?= =?utf-8?B?UCtocTlsdmdjbWVGR09wTkNNNDJLYjc5Y3Vib0xzK2s2YXcvN09ZeSsvUXcy?= =?utf-8?B?NWd2aEsvRUtmZVRDWTRPSTdYQkt4Y2g1U0tEYmwvS25ZV3c1eHl6SmpXNUxy?= =?utf-8?B?RUdDZWFsMDExclhUSk1kdmJ5bytzZ0k0cmdrK0ovSEJOOGZkbEZLSFpHNjQz?= =?utf-8?B?OWduU0FjYzB0NjlVenVoUGQrbnNjaFpkditkU0U2ejV5Z3dyV1orcGdqc0Rp?= =?utf-8?B?UFZIa3FiTk5IaDB0QURPb3RtT0p1c1FadFdUcWFEbWlibUMySWJKVEovYitD?= =?utf-8?B?UnpPZEorcDNxWCttSTh2QmNMd1l6WmtMU2JvemtmMzVYL3I4d2R6bmVCbGtE?= =?utf-8?B?aDB4NWJiSStJMUw5akVreUZzVytOSCtlYWRRUzd5WHNvMjJoM0RTYnQwMzR2?= =?utf-8?B?dDA5bUlYWUZsQXN3MXdMWHBDU1FjSDFOL1lnMlY4MFpHVHpMZFFFWE0wUXdm?= =?utf-8?B?aGZ6Q3JQQUJWbGtsR2psRExYL1FlVGE1TVZNWmZjMlNBMDUrWUpZajBreGVu?= =?utf-8?B?ajJVaGJ3RzFUL045eUd1MXVUUGN3Nmk3dHNXeUVySW03bkhYak82OFJRL0c5?= =?utf-8?B?YkVHSlM2cFJQM3crcVJiRG56d1JhMytDeDNmbGFwM2xJOG0zZHhRc3RIUlFJ?= =?utf-8?B?MUZ0OXhiaDdNamZ1OEtpRzlWdFo5aWU2TFBmbk9BMzhmbjFlcDdUd25xd2tZ?= =?utf-8?B?TWFkUjJscjkzUVUvdWpIa3ljODlpT3U3Wk4zL0dLTWdwbVhSc2NNMnJCdlZN?= =?utf-8?B?UGVkRERQMDJDdTlDYk5vSkdUNmFkU2doUGZ5MXpUdVE5L0dIdE1JcnBsWmVs?= =?utf-8?B?LzRoMVJ1RFcwakJscVZ0b1JHbWRmblhPdzhRaDdtaGR3WTc1ZVgwQ2F4bnR6?= =?utf-8?B?YTFlZFpwbGlJZy9PSkxaZkZZa1VyanlTaFJhRkxROUhoZ2NKR3NrZFR4QXVr?= =?utf-8?B?WFhUVGkrdVZQelhTTXovZ0kyRnV0Rm9WR3ZDeEVlV2xiZDhnMFFKQldLU2pw?= =?utf-8?B?TWJJYmc1NHVsT3ZHS1ozdy8rMGVRZGRlazZUQjZoUGxJSURXZ010S2ZYRlNm?= =?utf-8?B?QVpsYXd2Y3JRcDl0YmhYaU9MODByTkFmTkhvak9takFZb3UxM3lRS3ZOQWNV?= =?utf-8?B?TVc1MFpzeHphcXhpM1JONzJBRW5TRGN4RTc0U0FVeHptVkZFbkRmcU9MK00v?= =?utf-8?B?a2N0a0tFbk5pNHV4SmhXM3kyN2RBYVJQa3YyN0lwWmxNSFBZcmRTN21lclpK?= =?utf-8?Q?UfQRKCIIvjIY4wk0SnfYPV5Lw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 423dceee-9ecd-49a5-ab44-08dac9611f9b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 12:33:40.6434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bzYxj6lcFScOkc1SU4v743JZCkNqI1pnKEHg2l7ItefxmAHKWs+FdT4VIjAr0ZDM7emxoXSOjVMrF8G6jrJCnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7542 On 18.11.2022 13:19, Marek Marczykowski-Górecki wrote: > On Fri, Nov 18, 2022 at 08:20:14AM +0100, Jan Beulich wrote: >> On 17.11.2022 18:31, Marek Marczykowski-Górecki wrote: >>> On Thu, Nov 17, 2022 at 05:34:36PM +0100, Jan Beulich wrote: >>>> Which in turn raises the question: Do you need to handle reads >>>> in the new code in the first place? >>> >>> The page not being mapped is also the reason why I do need to handle >>> reads too. >> >> Just for my own clarity: You mean "not mapped to qemu" here? > > No, to the HVM domain (in p2m). Xen (outside of MSI-X specific code for > HVM) doesn't know where those reads should be from. Hmm, I was expecting them to be mapped r/o to the guest, but perhaps I'm misremembering. Clearly both ept_p2m_type_to_flags() and p2m_type_to_flags() take mmio_ro_ranges into consideration, which is what I was basing my understanding on (without having looked at other places in detail). Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 18 12:36:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 12:36:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445699.701005 (Exim 4.92) (envelope-from ) id 1ow0bS-0005SN-A5; Fri, 18 Nov 2022 12:36:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445699.701005; Fri, 18 Nov 2022 12:36:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0bS-0005SG-7P; Fri, 18 Nov 2022 12:36:18 +0000 Received: by outflank-mailman (input) for mailman id 445699; Fri, 18 Nov 2022 12:36:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0bR-0005S4-1q; Fri, 18 Nov 2022 12:36:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0bQ-0000xX-Vx; Fri, 18 Nov 2022 12:36:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0bQ-0000cl-I3; Fri, 18 Nov 2022 12:36:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ow0bQ-0002TB-Hb; Fri, 18 Nov 2022 12:36:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+TpmNY6ZIqXiOFdJIbCyLsAD4LYZ8TVsxIj3eyJ2c20=; b=sjIRN34KbQSxhw+3WNkJzn+YoZ v9+rbdL4sChzh+4QBIPfzAtKEfEjU1dMYwMzBgOvc6pusgs3nGYxRT1rgpFoopXzZ6e92OeK88y0b 0DDJljIxEFkO7PVeC1JA3z78pr8seg5prXgzBzz8G7lOtlewc27PARjh1HbAu3blCJ5U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174811: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=0be7d0f1cb257260758e38ffafcef5d2e0b43b86 X-Osstest-Versions-That: libvirt=d5ae0cd17827e8d2b26b0165a46ab0ebe6d7ce21 From: osstest service owner Date: Fri, 18 Nov 2022 12:36:16 +0000 flight 174811 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174811/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174798 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174798 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174798 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 0be7d0f1cb257260758e38ffafcef5d2e0b43b86 baseline version: libvirt d5ae0cd17827e8d2b26b0165a46ab0ebe6d7ce21 Last test of basis 174798 2022-11-17 04:18:51 Z 1 days Testing same since 174811 2022-11-18 04:20:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Cédric Bosdonnat jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git d5ae0cd178..0be7d0f1cb 0be7d0f1cb257260758e38ffafcef5d2e0b43b86 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Nov 18 12:39:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 12:39:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445707.701016 (Exim 4.92) (envelope-from ) id 1ow0ep-00064Y-RF; Fri, 18 Nov 2022 12:39:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445707.701016; Fri, 18 Nov 2022 12:39:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0ep-00064R-Mh; Fri, 18 Nov 2022 12:39:47 +0000 Received: by outflank-mailman (input) for mailman id 445707; Fri, 18 Nov 2022 12:39:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0eo-00064J-Sr for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 12:39:46 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 13e4cc9d-673e-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 13:39:45 +0100 (CET) Received: from mail-mw2nam10lp2108.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Nov 2022 07:39:38 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB5615.namprd03.prod.outlook.com (2603:10b6:a03:27a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Fri, 18 Nov 2022 12:39:36 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Fri, 18 Nov 2022 12:39:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13e4cc9d-673e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668775185; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=H7K4Aag3vTDVp4J51MMe8lRqvROnZ9FLKKtdV0iEWII=; b=dHHmHqI6caRZtSOgmDeoXwo1YEBwTDSrRohyC6fVNePW2ED5CtHWOBTB BfDqKrROVe0Td9oxdaUweZwWZkJfg3A8GBApaw7a7i2drEg1BbZk0sBIJ mpkJkmKaxlpVkwpxVEp4odx9eb9qsYasF1EioGPGYjGUkbjX8Q1WAyzi2 c=; X-IronPort-RemoteIP: 104.47.55.108 X-IronPort-MID: 84169468 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:qI3Y/qz6lx11bg1l9LJ6t+cQxyrEfRIJ4+MujC+fZmUNrF6WrkUPz mIdDzqHb66NYWP3f9okaYuzo01XupWBy99rQFRrrSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPKAT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KV4R2 qMWOBAjVTOoqd+qnYirS8J+htt2eaEHPKtH0p1h5RfwKK9+BLX8GeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjWVlVQhuFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE1rOWw3KnBtJ6+LuQ5udErHe87UovFSI1UWrlhOO/gWOxcocKQ 6AT0m90xUQoz2S7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZjxLZcEitcQ2bSc3z VLPlNTsbRRwtJWFRHTb8a2bxQ5eIgAQJG4GICobFw0M5oC7pJlp10qfCNF+DKSyk9v5Xynqx CyHpzQ/gLNVitMX06K8/hbMhDfESoX1czPZLz7/BgqNhj6Vrqb8D2B0wTA3Ncp9Ebs= IronPort-HdrOrdr: A9a23:dLVQa6kdwWYOotC6X7vYvZ+D2wLpDfNYiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0msl6KdhrNhRYtKPTOWwVdASbsP0WKM+UyFJ8STzI5gPM RbAtVD4aPLfD9HZK/BiWHXcurIqOP3ipxA7t2uqkuFIzsaCJ2JuGxCe32m+wBNNX17LKt8MK DZyttMpjKmd3hSRsOnBkMdV+yGi8zXmIngaRsmAQdizAWVlzun5JPzDhDdh34lInty6IZn1V KAvx3y562lvf3+4hjA11XL55ATtMr9xsBFDMmsjNFQDjn3kA6naKloRrXHljEop+OE7kosjb D30l4dFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdpXf4u8T2SB8zFsIE3OtiA23kwntlmOs5/L NA3mqfuZYSJRTcnB7l79yNcx1xjEK7rVcrjOZWpX1CVok1bqNXsOUkjTRoOaZFOBi/xJEsEe FoAs2ZzPFKcWmCZ3SchWVryMzEZAVBIj62Bmw5/uCF2Tlfm350i2ECwtYEo3sG/JUhD7FZ+u XtKM1T5f1zZ/5TSZg4KPYKQMOxBGCIawnLKniuLVPuE7xCE27RqqTw/K4+6IiRCdE1JaMJ6d r8uW5jxC8PkxqEM7zP4HQLyGGGfIyFZ0Wj9ikEjKIJ+YEVR9LQQF2+oR4V4omdSs4kc7Pmss aISe5r6sDYXBTT8P5yrmvDsrlpWAsjuZ4uy6MGcmPLhP73AavXkcGeWMrvBdPWYEcZsyXEcz A+YAQ= X-IronPort-AV: E=Sophos;i="5.96,174,1665460800"; d="scan'208";a="84169468" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QseS7O1jqjNPJLVZXLx/1wgIgj55Vt8cphBoRnTn+tLzn4cT9BPhcvx9iiwRRJzt+VValYAl3cELn6E+iKnd0OPl0ni75Uz28JOswUrak+X9Eigbl4la3ua9RhHVZ3wbjrLaLH8mYHCtNZOlvVCxO2Kcg3terHqZGCPD+d6NK+z2i0n1/Glb0Phe0VsvDjgVC8oFxi/qktYYphwLP81dYWrKTjvcI1RIq50mBaARn1+b5tb9f33VWA8WnyKD66D781ti/IVt2MaQeFWdB7cLHGL6adTW5wAk4EOa8BkXSIHJMJ2RZtApJzh2dyGm2ELYA1iLixeo9gMAo0wLENV3ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QTllUH44jeX1Wx8iB86t1yMrqhZaOSZxHAOwvvW+GxA=; b=kKwKQ73yu+hoAiTpBRHIm26UbPLKJPc6zUwtrIuwM5k9javkJ6TG0V8yx1CClMArmi4nKWuCRD34RC7RCFi1N2Px+k69i8/h0ZEYkzcwHQuBWbwOPwbEDuUR7WkxVaa3OLh8eEIUzRljbJSmcm93326iEsJrPsmlEPKBHG+Z0OcMOqkIllkqyJrvCicSTFdTITx+zCWQ86agc3FmqusyPq62dK7JeDx0Y+dMZsA4L1tNU3SYFTtb0s8nihA+vwXjusgZeexv52p2NQZdtdFIDsZ1e6vWwzPJtRHoCNEPJG8HJEaL+NQ3H8313KpjnbHGp5vt92jTij5Ln2SsyEfbEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QTllUH44jeX1Wx8iB86t1yMrqhZaOSZxHAOwvvW+GxA=; b=wnYA3zZBsMrSPsMvbwCVEB94wnkEmECEQhV/U5sAKCFh2/eg1CEv8TSOoMmoa4qQUjAy6ZDtyJW5PfI69mWannMi9N+AAQZXPXFv4h8ZIOyXLrbgGOYWBMhmx4nRQop62uhHIxafvyZwqTJJpnmX9n4xFgS+9Rg4Q5AhBdo8vsQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH] efifb: ignore frame buffer with physical address 0 Date: Fri, 18 Nov 2022 13:39:25 +0100 Message-Id: <20221118123925.25363-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO3P123CA0008.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::13) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5615:EE_ X-MS-Office365-Filtering-Correlation-Id: 69b68b86-f713-4901-de66-08dac961f30d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QQ2d0SwFbeEBiTLW52+VOH4FktC7rqZCKOiwpu+5C01KqJpskVsy4notnwQ5FCepEDKwiOwIQ7nTfqoVXlq1UrD8aeyYHsKHabgDWXHjHK2T0BUVWx1ZIiew7dquRkBrOgTAekoKL+lREL4PaIuIZ+dVuFHppAsKVn9fWqywh0WQxFHBsbrfwdfN+F8QWcUxFOdvWPJVXq+sGgQqoyCvrfVBhJ9UVL5oshpDJVBx26L0R6Pdl5WMwfkEvQS+8FV1oH6Mh5sfP0py4WXl89GKfBsdOi5Cwdm8wZpM8kBjw4b1ulB3gfJodVfQ2Wqkxs9QexWZ1Kws0FltF5jxRFLTqn7cOOKxiFgyv7z64LeyalMXgohscqA7ijgA311XbLm+242zYGvjuGZM2T8z7zKGGkWjnZJovFmehAWvfzo1ZGN2hHY7E1uyysAmmeAADO7d3g2WTpNdtpOAeGfl6LK4nA0qFvSErzV2ANBdjjs+XWcZ9qGV1UjtHAq4iqhCbKtGrgqIRrIbGdy51oGQ1lYNs1+1lLWdkMkGA+2pvLuieHhS10tT1nnPbD/lFJoWCn4o22JfOtVwJ5gg6QBuLm39XZcp8T56Is/m/NsrTGxYD/Wj4Ie0OW59DwYYZbjDXkYGr28k11+k0gQyFK/NiFiZXA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(39860400002)(346002)(376002)(451199015)(6666004)(6506007)(6916009)(2906002)(54906003)(6512007)(26005)(66556008)(66476007)(66946007)(8676002)(41300700001)(186003)(1076003)(4326008)(2616005)(5660300002)(8936002)(6486002)(478600001)(83380400001)(86362001)(316002)(82960400001)(36756003)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzJLZE53Wjh6d0h4OFN1d0RmUVRiSFlaVk55ZFIxODVXYzk0Q0xIYmZCTUk4?= =?utf-8?B?OXlIV2dYUFVxR2pTNFNVSTh3VXhvVk9LSXI4UVJQWWJiQnZBMWhpLzBvNHZG?= =?utf-8?B?TC9FZmZSanM0Kzlub2ducHkxVHV5MHhzT1lmdzNwZTRLazJLSGVRbVk3ZXR4?= =?utf-8?B?VVYycjM1Vk5xaXNNYWl6S2lRbWNzTlBNWkhmSG5GbmlKZ0k3bmxQdE1KVncw?= =?utf-8?B?Z1NGNVZaTjJJd2VtdnZ6V1NEUkdUbUVUckkzYjdZRHNwaHV5U24waUtaRWU1?= =?utf-8?B?VVBxbnJ4M1VnN1hDd0VVekRGbm5KYnFWbHUwWnJUbXRPQ3JWY2N0YUFFOExD?= =?utf-8?B?MDZocm9LSi9oYXEwRmZnU2JyTlk3RVZQUjB0VUJyVUhwcUZwSnRXeEFuSmVx?= =?utf-8?B?RDltL2RheldjMFNkWXVwOHRlT2JLNnhySEVGbWFZSjlqdURDQnI5VFROWDJz?= =?utf-8?B?Wm9mVzNrZklMM21OdmlBZnI2VjkxSWt3YlRRMXVUekNrcTR5b21GTUZIUUY0?= =?utf-8?B?UytwdXJ5RXhnR1ZOTmIvSkFqY005QUR2RjQ2c3FFUTRzVlREVzAzZzlmcHZt?= =?utf-8?B?SnFOTkl1ZmRDMDhERy92eXRYdmc3UlVZanVidGEwUDYyMGMxMFV5WG92Yjd2?= =?utf-8?B?U2IrSm5MaFN6cUJqVW03OUpwWEFTcTdGNnhxbmV1dDJoT29QNmtpaWUveXZT?= =?utf-8?B?RVNLb3RhemFVSlN2OG9saUg1bFNGWmlKQWpQMkNCdjNjMkRqRSsrOGRaZFhX?= =?utf-8?B?cHNNMzlBL1FzY0RVMXFzVU5nQUdkQ1FoYkE3TGc1aHlleWNGOTQ0NlBES3NN?= =?utf-8?B?bEJEM0F2TmJIbVpGREltZEVCK3RiQjlkZWlKbERFT05YWitDVk5pQUkzaXUw?= =?utf-8?B?WVBkN1dkMmM2ZzdUT0pnQWhlZHBxRG42MW84citZM3kxZWk3SGx1YkZWejhI?= =?utf-8?B?VzlialA2UUhqYjltK0Y3SjU5Slc5S0ZVNUpOdnNpcnpxb1k2WFQ1UUpRZTYx?= =?utf-8?B?NHZsSTB1WFUzMmc4NGhiK0JKNFJJbm1IbjF4TUloN1I5N09BQmpLKzVNQzAv?= =?utf-8?B?bWhIZDUvMG1NMVRkWU9JSTlnYXYwc3RHZWgzdk1rU3I2YTlhQmZjTnlYNENo?= =?utf-8?B?U3FwamxkV2FjYzRzTWxEVUZXNlJkQWpBL0E1c0hDWThrUjIrM1RwL0tSVlBQ?= =?utf-8?B?b3N4YVRFc2FubzZ4STFYWUJ0QU4rU2tpL0E0bGVYdjZURXpIWi91YTh5Nmlj?= =?utf-8?B?a2x1RGhwMmgwMkFMM1E3UEVadFNBdXdxM1lvcDNoWnFqMUJJQVpHUjVjSkR5?= =?utf-8?B?TWNuZStSSDRyS0FjZ3E4S3R2ZHpDRG1kNE1xUnRQd2dMRW9sOWROT3BnR2l3?= =?utf-8?B?Mnk5a3c1WVJTL3BXaGFpUmNyVnBuSlpuL2Z4ZFhoRnZJUzVOWGU1cXBLSHBZ?= =?utf-8?B?TkNlLzlIUXhCbGh0eFgyYnU1eHdNZWhvQ0E3bTNMNU5GMDlKK3ZFbUk1RDlK?= =?utf-8?B?R1BkbEEzT0RyMGp5Q1RaMTlPU3VLZjRhZ1VKRlM5UDJwN3Y1M3FjR2JjUmVn?= =?utf-8?B?Um9SQVRKQkhNaExYZzBPQ21KSEFxODYwQlJUOVd3a0RwWDEyMGIrUWpZaDNT?= =?utf-8?B?L1BlcmMvQ2NvTzVERk94TTYxZTh3TWhiUzZjRnFlZHRnbStmRlZQemd5aFhG?= =?utf-8?B?Y0R6QWJkMTM4WFJiVE8wUHpxSzE3a0Y0S1k5R1B2dmhPWUVTdGQ2VGwxaTZp?= =?utf-8?B?T2YyMi9DVXBrcVByRWxzTVdleEpNYTJaclZjbDhpSXBpRTloUkQxaUM1bm5n?= =?utf-8?B?TFF3Q3N0WVJCWi85SHNkc28vSjhicFZuTWw1M2pIeTh4aXhiTWY0c2tPVHoz?= =?utf-8?B?V2ZWajZ5dDZpVWtBRGxOb09pM05xR2MvVDhEZGh2eDI4WjFCZFhKbzFaaWhk?= =?utf-8?B?ZWUvMm9KdEpCTU1xc2xLendWdnZESHlsTEpxQmF1aUY2ZUJ0Szc3cktIL1F3?= =?utf-8?B?SGxJNjRHdG5CU0YycHJJQ2M1c2J1WStEWVFHWjEzT2RhZEFIOW1ySHRpdDFm?= =?utf-8?B?cFFabWxpUkJUeUVzaVZPKzZuSGNGNzRwWWRMR2NFemRIeVJDKzlIaUJlZ0xQ?= =?utf-8?Q?c097H8FN0ZaGKARBz6nT/zGen?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: y5PHSdeAPpH/DnzP3cr322OkoMa+UK40K3ddSg+KW5vdaOfeyVYT3zcg9B5HMmS8JxtnllzmtfXlDexugi9Vf0r08DmfU+BLmTeor61L7TJ4nv3g/VMBpeadSR83yW5Scsj8npd5JTpFaGUUnTtKlQ4q8W5SnV04lbDin0SMj9YZGE9ZPcbpIsZoag/FdVYzJagNRQpH716USWyR62XUJ/51ptXGMppSAABU5+gMM2fqvbZSnZl2gzZyGvCs8cPf6QBygokOOGU7yMYeimilKIkfuA7UWyFcw6Q1JnKyNaY3icELc+uav1nb5N/yFdu4i4cJ6AIvTENYIReDyjPEMSRAxz8UoXGQhpeF+So7wIkLD4nUO2fG3PpulVHun8ZG4zYS1ZRKhO6qeN3nUWiHa+zt0fe68spKf2o2796we8nMZ3CPsiRyEtZ/ps93bhrhLV3LTnjPGexrs44DTgsE+AOAaUViEbTqcW7MRQe5ZUeOtn4WpmxM4lmkL014aEOAkrY5iqtP6W/CU4INBJZVV2BrJ5q5NL6oCIY563qzxDjMlW0uVTZ9i+e9fSyoMiN2wo9MwCyqVCG1rum+RmHbOVCDjzRsYfkjxg4yCJAXTCBZP7cqdTYsbLSfaRlJiJDePyUyWVmeTflsXG7p5OHgjUCJYA/qQ4hYyMcHzpHPdRRJ2f8ZQnVzQRsAWF6xWVTPbZZCgO2elNCulPsYcxXaN64aLOB1o/4F3AuZSQVWHH923XUvDzYJ3P1m7mnjDlxVibj3fIOklZwaKEHb3wB/+A26VmaDlN8Ka/1cQ8pF0CE4k0A31onQ7e/ta5NhFWHfggYUt0cGiK9YcKRK5JlY3Q== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69b68b86-f713-4901-de66-08dac961f30d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 12:39:36.1085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8sfV7Ta31B3SIJEg698R67CkTY+b1FNrJbOYKyMzIql2VCoeXvwmdlNSGtx1V9gEEXDb8algHwLKKN2sHWhaOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5615 On one of my boxes when the HDMI cable is not plugged in the FrameBufferBase of the EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE structure is set to 0 by the firmware (while some of the other fields looking plausible). Such (bogus address) ends up mapped in vesa_init(), and since it overlaps with a RAM region the whole system goes down pretty badly, see: (XEN) vesafb: framebuffer at 0x0000000000000000, mapped to 0xffff82c000201000, using 35209k, total 35209k (XEN) vesafb: mode is 0x37557x32, linelength=960, font 8x16 (XEN) vesafb: Truecolor: size=8:8:8:8, shift=24:0:8:16 (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) �ERROR: Class:0; Subclass:0; Operation: 0 ERROR: No ConOut ERROR: No ConIn Do like Linux and prevent using the EFI Frame Buffer if the base address is 0. This is inline with the logic in Linuxes fb_base_is_valid() function at drivers/video/fbdev/efifb.c v6.0.9. See also Linux commit 133bb070e94ab41d750c6f2160c8843e46f11b78 for further reference. Signed-off-by: Roger Pau Monné --- Other options would be doing the check in vesa_init(), but that would also then apply to other framebuffers and won't be strictly limited to the EFI fb. We could also check in vesa_init() whether the framebuffer overlaps with any RAM region, but I think that should be in addition to the change done here. --- xen/arch/x86/efi/efi-boot.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index e82ac9daa7..a68091d82a 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -552,7 +552,7 @@ static void __init efi_arch_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, bpp = 0; break; } - if ( bpp > 0 ) + if ( bpp > 0 && gop->Mode->FrameBufferBase ) { vga_console_info.video_type = XEN_VGATYPE_EFI_LFB; vga_console_info.u.vesa_lfb.gbl_caps = 2; /* possibly non-VGA */ -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 12:43:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 12:43:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445714.701026 (Exim 4.92) (envelope-from ) id 1ow0iT-0007if-DJ; Fri, 18 Nov 2022 12:43:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445714.701026; Fri, 18 Nov 2022 12:43:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0iT-0007iY-AY; Fri, 18 Nov 2022 12:43:33 +0000 Received: by outflank-mailman (input) for mailman id 445714; Fri, 18 Nov 2022 12:43:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0iR-0007iS-P3 for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 12:43:31 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2060a.outbound.protection.outlook.com [2a01:111:f400:7eab::60a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 99c226f3-673e-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 13:43:30 +0100 (CET) Received: from DM6PR02CA0114.namprd02.prod.outlook.com (2603:10b6:5:1b4::16) by IA1PR12MB7591.namprd12.prod.outlook.com (2603:10b6:208:429::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Fri, 18 Nov 2022 12:43:25 +0000 Received: from DM6NAM11FT092.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1b4:cafe::89) by DM6PR02CA0114.outlook.office365.com (2603:10b6:5:1b4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 12:43:25 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT092.mail.protection.outlook.com (10.13.173.44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 12:43:25 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 06:43:12 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 06:43:10 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99c226f3-673e-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gA84QPDRhFSb8ZplyooW0/i0LVGjAiKfwgd5wMtkMOmojQzcf1zYJXl3nsCDK3/v3DdC9G4hRMRrVvzs02ApsYtgQ2GYcOS5MUmIqkuWffyXLe6kzmNOj5yNgI8G5TjDCBFFD8M6pEck9KCxxKfnBfMNHFykEH8b4Z3sIZ76WZkyJut4tTrM3MWPM+zM0KOz49Tf2cnHTe1t4kQBRDJYitiN/hoomi9yBulBwTscd8RMJ/3/+Sq1kRdHZit8CB0hLDROt4VMV/lz56C+U66e9/Zr2LjMEicVuEXKYRS239LxwGeqnkhrgMrsK12n2TGu9nI2JweVvh7ZtwwH6MO4Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+9rSvhOcXJ6YHnpdkdwryOWPpoPQgOUUVm9FL/XaUVI=; b=mX5IAfMxXmGLsxFTpidGJ/GFJuOKXCgS4cizkJ+AugqSQwkswliU4BTDbqnCwvjEu3Q86aWcWWB6NwWFnsRilB4PAlPnDYy0tT5X+ZLxncgyxP8iM8enRjYDlGODDakkfAHhmeVREtx3Dju9pwpfLUtYs69ocHgEzz3cO5hKSRvNqY8+44PjF8CFyH8Zpc5+ptkIEp8bHT+RmEAIZ/yPkwkToRBCRdhlmypypto6GtHm7jPa9W4Ehp83UtSL8q0ShBA8BjapuNJnb5UnP6j0YiZcS4gR/YH4oVR9Zhh2ys0MwsSP2XolGMhh5Sk2GvdPrsY1NXj+O4ZtbCU814KtGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+9rSvhOcXJ6YHnpdkdwryOWPpoPQgOUUVm9FL/XaUVI=; b=D1V03QuRbQDCGyexMNPx+1dT7GOcsrZGIrCBM6mT90bGOnC18TYfjZfDEJ561OTFFQVHGNrwIQz/adK2Jtgo+DZyFDTtW7uMyLJ/bj+owk4T/ilMJgYQP1dVWpu4rcomHNxUsNf3PhBKTiU4SfFCCVqg4hMoEARBgzzaV0LSLj8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Fri, 18 Nov 2022 13:43:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN v3 09/12] xen/Arm: GICv3: Define remaining GIC registers for AArch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-10-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20221111141739.2872-10-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT092:EE_|IA1PR12MB7591:EE_ X-MS-Office365-Filtering-Correlation-Id: 98e00f03-55ee-44b5-e478-08dac9627c08 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U07NjOx9YP6c+l/iZKPQCmfemTDelcMEDU11w0NWxmDT/532KOM8N9i62/e+CeZjRFPZswxyTcOwLqgNHli8GfTvTzdul1i9oN4bT9yGL2IXPWuB9CDbW54/nYoXO/H7nsOVgNavZBHciRZ4cJ1aUGqA9LiY74EYBRHy9KFSmAeTHQL8llJXAsd6BqxPa619bty9yBluJU3q850h/tDqd2UJVWnEZklyArybiOyuvwCU+PX6oPEK+/EP6qVDeJZmgq+soTjNSc3lo2+qVo19/3Aa+rJ2DybDqm8QXLOfqdvTwpoEPUOxqswZ8w5cMekzc7izktD8Pht2vhKzOdsrThiAcYsa79fP1riSjuM6MOGWqsB/T4PrfSS+Vsk53WJFkK64G5qWXIA58970POwwCKxTHsyaolef3wbWbr1GoWv0SUVRfpO2wD4xE09Cb9dSIJCHKZw07SF2V8P5wJqcSrk092BoOxHSzDhs1kWC5CYFYJYlYGp1UGiTVxR9SpgjelHkKak3pJYkFQUy6uDN8YN+lf9/OuZQZW1POaUKUKVgkeQpJTOLiKPVCaUmQNn5O44OkovM20Wyjox+w6oe/R8ogRg00iPXD6F497imbRFGCFLrFFj6evzXYXLrMfpsWHCeyC/7UgXxBIl0t86dYEvxRfZN6fqw1MdGZEkqB1zIFu2j+8FY1+LX0lQ5n8VO7E1O+UXdHaL40tOcHxB9KBkjXFG2KDDqGUEXlO08JH1R35EkejsLk8V1MzWZJAsyiMnLUp4ebEDLMLE8YkMyEw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(136003)(346002)(451199015)(46966006)(40470700004)(36840700001)(54906003)(110136005)(31686004)(53546011)(44832011)(26005)(316002)(478600001)(70586007)(8676002)(4326008)(41300700001)(2616005)(70206006)(186003)(47076005)(8936002)(336012)(426003)(2906002)(5660300002)(83380400001)(36860700001)(86362001)(36756003)(31696002)(40480700001)(82310400005)(16576012)(40460700003)(356005)(82740400003)(81166007)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 12:43:25.0500 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 98e00f03-55ee-44b5-e478-08dac9627c08 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT092.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7591 Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: > Define missing assembly aliases for GIC registers on arm32, taking the ones > defined already for arm64 as a base. Aliases are defined according to the > GIC Architecture Specification ARM IHI 0069H. > > Defined the following registers:- > 1. Interrupt Controller Interrupt Priority Mask Register > 2. Interrupt Controller System Register Enable register > 3. Interrupt Controller Deactivate Interrupt Register > 4. Interrupt Controller End Of Interrupt Register 1 > 5. Interrupt Controller Interrupt Acknowledge Register 1 > 6. Interrupt Controller Binary Point Register 1 > 7. Interrupt Controller Control Register > 8. Interrupt Controller Interrupt Group 1 Enable register > 9. Interrupt Controller Maintenance Interrupt State Register > 10. Interrupt Controller End of Interrupt Status Register > 11. Interrupt Controller Empty List Register Status Register > 12. Interrupt Controller Virtual Machine Control Register > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from :- > v1 - 1. Moved coproc regs definition to asm/cpregs.h > > v2 - 1. Defined register alias. > 2. Style issues. > 3. Defined ELSR, MISR, EISR to make it consistent with AArch64. > > xen/arch/arm/include/asm/cpregs.h | 32 +++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h > index 5331ec3448..0fc606fe99 100644 > --- a/xen/arch/arm/include/asm/cpregs.h > +++ b/xen/arch/arm/include/asm/cpregs.h > @@ -161,6 +161,7 @@ > #define DACR p15,0,c3,c0,0 /* Domain Access Control Register */ > > /* CP15 CR4: */ > +#define ICC_PMR p15,0,c4,c6,0 /* Interrupt Priority Mask Register */ > > /* CP15 CR5: Fault Status Registers */ > #define DFSR p15,0,c5,c0,0 /* Data Fault Status Register */ > @@ -254,6 +255,8 @@ > > /* CP15 CR12: */ > #define ICC_SGI1R p15,0,c12 /* Interrupt Controller SGI Group 1 */ > +#define ICC_DIR p15,0,c12,c11,1 /* Interrupt Controller Deactivate Interrupt Register */ > +#define ICC_SRE_L1 p15,0,c12,c12,5 /* Interrupt Controller System Register Enable register */ There is no such register. It should be ICC_SRE. Also it looks like these are not placed in the correct order. ICC_SRE with its assembly alias should be placed... > #define ICC_ASGI1R p15,1,c12 /* Interrupt Controller Alias SGI Group 1 Register */ > #define ICC_SGI0R p15,2,c12 /* Interrupt Controller SGI Group 0 */ > #define VBAR p15,0,c12,c0,0 /* Vector Base Address Register */ > @@ -279,6 +282,19 @@ > #define ICH_AP1R2 __AP1Rx(2) > #define ICH_AP1R3 __AP1Rx(3) > > +#define ICC_IAR1 p15,0,c12,c12,0 /* Interrupt Controller Interrupt Acknowledge Register 1 */ > +#define ICC_EOIR1 p15,0,c12,c12,1 /* Interrupt Controller End Of Interrupt Register 1 */ > +#define ICC_BPR1 p15,0,c12,c12,3 /* Interrupt Controller Binary Point Register 1 */ > +#define ICC_CTLR p15,0,c12,c12,4 /* Interrupt Controller Control Register */ here... > +#define ICC_IGRPEN1 p15,0,c12,c12,7 /* Interrupt Controller Interrupt Group 1 Enable register */ > +#define ICC_SRE p15,4,c12,c9,5 /* Interrupt Controller Hyp System Register Enable register */ This one should be ICC_HSRE. > +#define ICH_HCR p15,4,c12,c11,0 /* Interrupt Controller Hyp Control Register */ > +#define ICH_VTR p15,4,c12,c11,1 /* Interrupt Controller VGIC Type Register */ > +#define ICH_MISR p15,4,c12,c11,2 /* Interrupt Controller Maintenance Interrupt State Register */ > +#define ICH_EISR p15,4,c12,c11,3 /* Interrupt Controller End of Interrupt Status Register */ > +#define ICH_ELRSR p15,4,c12,c11,5 /* Interrupt Controller Empty List Register Status Register */ > +#define ICH_VMCR p15,4,c12,c11,7 /* Interrupt Controller Virtual Machine Control Register */ > + > /* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ > #define ___CP32(coproc, opc1, crn, crm, opc2) coproc, opc1, crn, crm, opc2 > #define __LR0(x) ___CP32(p15, 4, c12, c12, x) > @@ -380,6 +396,15 @@ > #define HCR_EL2 HCR > #define HPFAR_EL2 HPFAR > #define HSTR_EL2 HSTR > +#define ICC_BPR1_EL1 ICC_BPR1 > +#define ICC_CTLR_EL1 ICC_CTLR > +#define ICC_DIR_EL1 ICC_DIR > +#define ICC_EOIR1_EL1 ICC_EOIR1 > +#define ICC_IGRPEN1_EL1 ICC_IGRPEN1 > +#define ICC_PMR_EL1 ICC_PMR > +#define ICC_SGI1R_EL1 ICC_SGI1R > +#define ICC_SRE_EL1 ICC_SRE_L1 This should be: #define ICC_SRE_EL1 ICC_SRE > +#define ICC_SRE_EL2 ICC_SRE This should be: #define ICC_SRE_EL2 ICC_HSRE > #define ICH_AP0R0_EL2 ICH_AP0R0 > #define ICH_AP0R1_EL2 ICH_AP0R1 > #define ICH_AP0R2_EL2 ICH_AP0R2 > @@ -388,6 +413,10 @@ > #define ICH_AP1R1_EL2 ICH_AP1R1 > #define ICH_AP1R2_EL2 ICH_AP1R2 > #define ICH_AP1R3_EL2 ICH_AP1R3 > +#define ICH_EISR_EL2 ICH_EISR > +#define ICH_ELRSR_EL2 ICH_ELRSR > +#define ICH_HCR_EL2 ICH_HCR > +#define ICC_IAR1_EL1 ICC_IAR1 > #define ICH_LR0_EL2 ICH_LR0 > #define ICH_LR1_EL2 ICH_LR1 > #define ICH_LR2_EL2 ICH_LR2 > @@ -420,6 +449,9 @@ > #define ICH_LRC13_EL2 ICH_LRC13 > #define ICH_LRC14_EL2 ICH_LRC14 > #define ICH_LRC15_EL2 ICH_LRC15 > +#define ICH_MISR_EL2 ICH_MISR > +#define ICH_VMCR_EL2 ICH_VMCR > +#define ICH_VTR_EL2 ICH_VTR > #define ID_AFR0_EL1 ID_AFR0 > #define ID_DFR0_EL1 ID_DFR0 > #define ID_DFR1_EL1 ID_DFR1 ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 18 12:52:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 12:52:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445720.701038 (Exim 4.92) (envelope-from ) id 1ow0qr-0000wR-71; Fri, 18 Nov 2022 12:52:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445720.701038; Fri, 18 Nov 2022 12:52:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0qr-0000wK-3h; Fri, 18 Nov 2022 12:52:13 +0000 Received: by outflank-mailman (input) for mailman id 445720; Fri, 18 Nov 2022 12:52:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0qp-0000w9-82 for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 12:52:11 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ceb74989-673f-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 13:52:08 +0100 (CET) Received: from mail-mw2nam04lp2169.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Nov 2022 07:52:05 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB6568.namprd03.prod.outlook.com (2603:10b6:a03:389::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Fri, 18 Nov 2022 12:52:03 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Fri, 18 Nov 2022 12:52:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ceb74989-673f-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668775927; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Agxby2pijlhMwYVGLa8pxS5eMWT5TtI/GCBc+Zr0uoU=; b=NDHCibeu9nDbA8Cq7UFI7YrPBa+4fbKFBJsc4WtOD5LMAf6+Pb0j+/nw XfvtPc/biJtt8/8BaH1DVnAi0fwm5p0r9t4AwBITR8WpAM8wx5bu6aEY/ Q08qW1SXXZOV94YmE9MZVoN2tgQRfnxRLWUlwP6FTbukJ0dG+Pk6gPiH8 g=; X-IronPort-RemoteIP: 104.47.73.169 X-IronPort-MID: 84169992 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:DLyTkaO8AtH/WtXvrR2QlsFynXyQoLVcMsEvi/4bfWQNrUp2gmQPz GEcD2iEbPaPMzTzL992b9m2pkoPsZDVzddlHQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5wxmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0tZdP21Ux NEmE2gERD+Djf+Yh5Wma+Y506zPLOGzVG8ekldJ6GmFSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vFxujaCpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+toi712L6ezHmTtIQ6DL6h2dFyx2Wv7DZMDh0ScHiCpNX+hRvrMz5YA wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/v2ARR/vbvTTmiSnp+MpC62ETgYKykFfyBscOcey9zqoYV2iw2VSN9mSPKxloesR2C2x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBN/xooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:6fg7XKlbx3tJpjDd7Yh13ioAF7npDfNMiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH7KGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu1Xh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboX0Twk6n7WXdrWrooMT/Sj5/I81dhbhBeh+cz0Y7ptlz3I 9Cwmrc7vNsfFv9tRW4w+KNewBhl0Kyr3ZnuekPj0ZHWY9bTLNKt4QQ8G5cDZ9FNiPn74IMFv VoEajnlb9rWGLfS0qcknhkwdSqUHh2NhCaQnIassjQ6DRSlGAR9Tps+OUv2lM7sL4tQZhN4O rJdo5ykqtVc8MQZaVhQM8cXMqeEAX2MFzxGVPXBW6iOLAMOnrLpZKyyq4y/vuWdJsBy4Z3sI jdUWlfqXU5dyvVeIKzNaVwg1DwqViGLHfQIpk03ek6hlS8fsumDcS7ciFuryP6yM9vR/EyWJ 6ISeBr6rHYXC/T8L1yrn3DsqlpWAcjufIuy6cGsnK107b2w97Rx5vmWceWAobROhAZfU66Kk c/fVHIVbZ9BwaQKzLFvCQ= X-IronPort-AV: E=Sophos;i="5.96,174,1665460800"; d="scan'208";a="84169992" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ix/BDmO+mWR6tWqBelzifYh1yEB5Npb7j0x1zlM+RH71VJ/Cj8DYD8yg85jnxQmV/Bx8btcyVezPA4bEIOtlaFs3AlExTnafARexBqKx0Ykha2VVbqDXTBdTMi8voFcAYRDWkFexbwhTIIrJp1a6/Z0aF80wulHlQ5a6SHFlTe4sQb+FjqA7HL8SE5WRuPlDblbLZ4hAJuvpTQglYyTv79jCvRF4NZJUKdruEle8hfaPEZhYMDpYBZBpfy/HnJ6DRkKXVnouhQe/cyr8FFWDzHkTtakrQvHpUYIhvL/4xEodpW8fOSAZyU3PgFleRosuIod0hh/TWcVjtS2aHeCd/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b8RNHA89uM0j2X61JYjokoiSPQ3LqYMtOeXQ5jYT2Xk=; b=lXMcCAZkp1mf9evurSi+ckfbHZJE5iyK2bFR6eKKkHhz0+dJr3Ne6zN/BiCXyd/9bptdAntShlEekJlT4Xiaoa0CoVYItdzTrLkYUG5AHBKnsyIOckWhswK5bTk+GChuII3Dki2J+Ga53hvJ+82BQI354i33p9TlyR4IPBK4g9b+bSgzNC0MjWCqJDkvsbc3jCEwCmhKf7gq8hsuC6j8bekJXR7/qQ15cy1MWQq2evSHr2u++256RaI69nbh5and3lGK0CaSqYKHXoz3wNZ0XOwzObIkd6LQasx59ZkYRsSgRNskXmswy+XOwC28SyR1c8fmW4SIlHejY2zFJkP7Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b8RNHA89uM0j2X61JYjokoiSPQ3LqYMtOeXQ5jYT2Xk=; b=FS/e4YjOAiELcbwda82hOYSS1kiDo9BimpfvGTuz0Gsj2yC2z5HPYOvAyn7ASgol9P7naSRFSVcmlpn04vgExWOn0rwa2/kqpwps3MI+awlzhIVhD9bnn8jGvIvh1Zyg1pshL7OAtJePLxUVnRM5eDRfbsWrnWl4Jf2fbzzWikw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 18 Nov 2022 13:51:56 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Jan Beulich , "xen-devel@lists.xenproject.org" , Wei Liu , Paul Durrant Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0576.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::23) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6568:EE_ X-MS-Office365-Filtering-Correlation-Id: 07b8caec-df8a-49ee-e110-08dac963afe9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HGacEQl/g04ZGv+LhCJ5jqxTEIi1j8wGtGtz8oA0QVANlaBLTexy/vv/1qqBfuzN6JaBZPzAUsv5jZpaxRPNSD2GwF1TH9YMpY1KlaN9/S2OY3YS4mAzkpzx0NPgQpc6iBnL2jkyAJa4hbDjx63qyVEjL9DIe8Z0FTnDbA6k7HKdXWzexFa9vtQYzXbVi67Yuu5Qp8v/vBCpi7N/MfTx7ZSQMb7xuWRBCXESALPxSNwZShdAPh8BYE3HUFDXGVBekI/p93B5fX2cdHzD0sOTgm8lJrVrxMHama821DEK2hSv5ExdvRrxksauNEViM+7W7zNKmNAP4trIotbux+X7tdGHvverMmfYdl76IlFiNbZQnE722GA+hjv+dRCcsXCHcXOSVKjSp1NfxBaZqFR4qNXJbUEyF258BGwcdj3Td1WTxAStmc5FmrhLU9wYkkEW18mlYPatJZbE+sL8FZPmQcAuGrJVbevufSyLddEaTfs1/7sRKJV2j21QI0MVuoMnkH/m6k8C9ZQLJV95QGCmzxXA4iZxUGw8UYtTj94cyRErLuFwF8WZDI4PVhtKmfajzVXR7z0GCmyt/kv9bKjlfj0L9LHO2JEUiKCkjnsmv6lg8sIef0nJhSK2m3Gxa+hawqp8CEmK0sWjcPE7WiGLP39HJIc0YB5NM7pud7yCjkmfHRmvOg/jIbwYSEWqXrN+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(376002)(396003)(366004)(346002)(136003)(39860400002)(451199015)(6666004)(54906003)(6506007)(5660300002)(8936002)(186003)(8676002)(85182001)(6636002)(6862004)(82960400001)(9686003)(53546011)(66476007)(83380400001)(38100700002)(66556008)(86362001)(66946007)(41300700001)(4326008)(6486002)(26005)(33716001)(2906002)(478600001)(6512007)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2RFVElndXJZSXYrTzBheWlaeW4zMkhkQnpBdnFrU1VuL0lNczlCVHc3STFz?= =?utf-8?B?aDg4OCtNMnFhZFVJWHNpOHlGR3FnMklMVTdKVEw1cUlSOUxKOVZHZ0hocXMr?= =?utf-8?B?Qzhid1VlTmVObnY1NllzRTBzeUExeU5QVytkZEs3N0c5REZkTzR3cEloTytK?= =?utf-8?B?Q1dvV2lHbjlqQy9PMXIwZEdRbElMd2k0SXhwQUlLTzlvU0hOb3hZYUNFdWtL?= =?utf-8?B?RDVuMzU4ZHJCQkhTUHZxTjZIb3BtMWtMbnRyVWJUUVVaNmc1TzcvejQyeHpP?= =?utf-8?B?Z2pGTVQyUktWczJ5OXI1am9CZEVuVUpjVU9IQU5yeWV5czd5SHU5YkNUM3BJ?= =?utf-8?B?c3lKK2tDQ1hFVXJmcGxkRDZzSElka0hOaCsvaWlKcFhlbXdoQlVReGhFTFNO?= =?utf-8?B?ZDhIc1VXRGMwdUYwWTl6VUloQ05OUnBHN0tJVEx3eG85bFJWQXRwejdHalhJ?= =?utf-8?B?bFBraExTQmp3dzBDcU9MTTd2WDlXVEo4OWNjZXpXN3VXTk52NlpTeFlwOWJU?= =?utf-8?B?TTZNbWR1YlV1bWtLbHFTYVJEcCtWQmxWK09DUEFvbWxEbmVkbFhvbEtCdmwz?= =?utf-8?B?eW5FaDdVdVlkWEUzaFhDNDRVbWRCTlkwUjVQU0ZLckJYRG1sbXVCZFRHK0x3?= =?utf-8?B?My8zbHUvME5oZXEwVEZpZnJQME1KZVZIdFZ3eXErMG42WERkSGF3UlpGVkFV?= =?utf-8?B?V2NhbEFCOVI1TnJDU0dSOXRTdW1BMXpiN1diNTBZRGdiMlV4M20xMWFLZmJY?= =?utf-8?B?bmtPTnYrOVZIWjdvZzFUQUFMTkdZQzY1aC93RlFEcXJkMmMxU0hEeUdpVnZD?= =?utf-8?B?WjJWaVNYUExNbnBlWEc0QkxBMVFQSEprall6dGVMQlpzV1laWDA5S1RoL2xS?= =?utf-8?B?NHlqd094M1ViVlRCOXFGVmlWeG5NRXN1OVg2L3duYnFRaFhWKy9mTXVGeTJO?= =?utf-8?B?U2dNNERiQXh4S1k2R1E1VGgwbXdMcGN5Zm9iYXVYNEZaWjIxcVR6MC9sTHY3?= =?utf-8?B?RWNxdy9xS3BjclBvd2QwcGRVbnM5VWxpYnNNcTU1UU9UUWNSSnJQcHc5TERG?= =?utf-8?B?MlE3N3NZQ00wWjRLbnlGam9KSDNYd2o3S2NLbFRPeEdCdGM0bTFpTVozWnlH?= =?utf-8?B?d0kwYVJubEZvdFJUZFZLSEEwamJmeW4yR25Tcnl0YjNOZnZxdGw3MmFUeGph?= =?utf-8?B?cWJjQ2JTck5qbVAxT3ZQQTJPZ3JBMWpCUCtBRmZ6dFVzM3RQZ2U4MTRwUm42?= =?utf-8?B?SWVaQ0M4ZHV5dGIzaUx6eTR0Q3RVbncxeHVvOUJxZy9sdStmcmM3RTZtUGE0?= =?utf-8?B?bXZ1UUZQSFlSZ3VLZGRnSXpzYS9yVVlqbTlUcWJ0WEgyVjB3SjIzM2JjaFdW?= =?utf-8?B?czFWTnJuMUJJOXNEU3N3YWE5cDR1S2xJNWxRM0RSczhOMGhRTWloS2xlbXM4?= =?utf-8?B?eXp0VHhpYUIrNG54SGREc1JiVGd4OFFEbjJheUFOZ2xHb1FGOG9DUWEvUUgv?= =?utf-8?B?blFlRy9qTFNLY2FXKzJ2ZkRQdTBQWTJMQkVHdFpxajBncWl3WTVVQUZSa0wy?= =?utf-8?B?Mk1CU21zdU9lVzAzZjB3L3I4VlFDSVQrQnBqeWwzbDZNaWlkVE9BSDRYN0Uw?= =?utf-8?B?dXdaSkEvM3UyZmpWN1ZWQlNaQlZkZjdQTTdkWVJLdEtLS3dYbVo4U1pqTGl1?= =?utf-8?B?bVplNEJjTVV6a0E5VXlsTlVjVDY0a1prNm1BMHRaeXovNExYSXFKeFlTTmp3?= =?utf-8?B?cHI1VDYwS3JtV3k0dFVhdm10dWgxMWpINmNacHc4QjdqWVdoSTFuc3p4RklF?= =?utf-8?B?TCtCUVVhYlBINUVNOTZyTk5YR05oWndObjBZTkJ1TTQvOGxtM0ppVG55TlNz?= =?utf-8?B?WVZRTDdrdldQZkwrV1ptL3RYNUZlQTdMVTJlbm0yVGVNbjdRcUpWQmJqdGdQ?= =?utf-8?B?NXRxYnN2Q3FoelRQSWFjM1RXbks0K3RQeXhOU21TdWRvb1F0T2JBcnMvb1VO?= =?utf-8?B?Sk1sVmU1bTdSUkRrRTZMVUhzUzcveTQ5cTUzWHJvU3JPWkhvdmlHQUkwMmxx?= =?utf-8?B?cGp5YXNjZ01zZ0FZeDVVQkRyQkZVSU5XMkdYTnQ0Q2UyMnBJUDVaZkVLS0dp?= =?utf-8?Q?Lf8zQPFQnEHnKUOnn7CKGFkW0?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DuyFrii1p+PLmLyNqZA0yOjV/KAEP2I1N9cB4Za0YwUcaEcoBzfs+CbLAfC8/iTXe8K+aISSxdL7XdrrL88iXgRncVXWNPCkCur5L/KqLTu+3bRLsSVB+wygL27D9ZDXlQ9WVRogudkxcnwf4YyNYVKIiCSATTyg+4LM9Tx4VPQ0nxbN0njTljhitrwFiM2UNGUbs4cnFejJyAH9o+5xtLIrDzCNoUr33pfM2Hs3X9uZCMxWRaXs73cBRe3In7fiVtj2Aa/VsDLybCFkw1f+h9MRD5rB3rc/D0hQ7dmuQwtOUfOGsmORu4MIlEqwopA1I+odDK3hX2BqeCuPGxVc0/kCE38fyr0KdTzeDkaokZxNjwFfVzDTop8Fx0sNH0jcTlCq8e6LGE0cxiSz4BsWOTzEvy6xVhNW9RPJAZz/U0vQH2VnzYJ+Cl6e+xZHj+kS4QAPYE7V3hTpVoNghLJvrXUjzaFQRFdidBy60D47noUiZ+4ClK7RSxzPBFCd5tALDCz6V74AxcnplIisTzvWvk+OwdSGXezFrzrmNKS77Ai9LbKhH3NFmyzLGla4oE30Qoouq6a4LHj75fHU+XWGl8gbfyUwRYH8J6d6SqkBy02O9rnUkCoIq+LLfZLaQ/xPQWA1qJGYh8l7lhJF7glDoj5zTedYrEmtXP8pmIkRIQZAVULKeyCz1opKI5upYcWmujU7bkEufBAavJKnY7aRGvRvChaj40tR056Y+eh0NoG6adfLTTUGpjRA+AHB7AT1Gcfpb8/ioJq0v1+AiJCYgMAszEOH2pjHfmZAQkKZ+ddDOKg1ssyfhJnaXuF2L86SVmVfHq3E4cxVOaqxvgFBV6szzeLReHjcAx+q19sH9Tg= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07b8caec-df8a-49ee-e110-08dac963afe9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 12:52:01.9627 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gEwC30MJ4hXeuGqNRxlc8OY8utmQsEiEq+iFiM8oOM3SUPUKT6Nq9WptOqkRQOm9uzZXReBGkZXDOYgWZRzlJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6568 On Fri, Nov 18, 2022 at 12:33:00PM +0000, Andrew Cooper wrote: > On 18/11/2022 10:31, Jan Beulich wrote: > > Linux'es relatively new use of HVMOP_set_evtchn_upcall_vector has > > exposed a problem with the marking of the respective vector as > > pending: For quite some time Linux has been checking whether any stale > > ISR or IRR bits would still be set while preparing the LAPIC for use. > > This check is now triggering on the upcall vector, as the registration, > > at least for APs, happens before the LAPIC is actually enabled. > > > > In software-disabled state an LAPIC would not accept any interrupt > > requests and hence no IRR bit would newly become set while in this > > state. As a result it is also wrong for us to mark the upcall vector as > > having a pending request when the vLAPIC is in this state. > > I agree with this. > > > To compensate for the "enabled" check added to the assertion logic, add > > logic to (conditionally) mark the upcall vector as having a request > > pending at the time the LAPIC is being software-enabled by the guest. > > But this, I don't think is appropriate. > > The point of raising on enable is allegedly to work around setup race > conditions.  I'm unconvinced by this reasoning, but it is what it is, > and the stated behaviour is to raise there and then. > > If a guest enables evtchn while the LAPIC is disabled, then the > interrupt is lost.  Like every other interrupt in an x86 system. > > I don't think there is any credible way a guest kernel author can expect > the weird evtchn edgecase to wait for an arbitrary point in the future, > and it's a corner case that I think is worth not keeping. We would then need some kind of fix in order to clear evtchn_upcall_pending, because having that set without an interrupt pending on the vLAPIC will result in no further event channel callback interrupts being injected (see vcpu_mark_events_pending()). Maybe we want to change vcpu_mark_events_pending() so that it always tries to inject the vector even if evtchn_upcall_pending is already set by calling hvm_assert_evtchn_irq() unconditionally? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Nov 18 12:54:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 12:54:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445724.701049 (Exim 4.92) (envelope-from ) id 1ow0tD-0001Uy-Jm; Fri, 18 Nov 2022 12:54:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445724.701049; Fri, 18 Nov 2022 12:54:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0tD-0001Ur-Gl; Fri, 18 Nov 2022 12:54:39 +0000 Received: by outflank-mailman (input) for mailman id 445724; Fri, 18 Nov 2022 12:54:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0tB-0001Uk-E7 for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 12:54:37 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2061b.outbound.protection.outlook.com [2a01:111:f400:fe13::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 27c26095-6740-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 13:54:36 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7414.eurprd04.prod.outlook.com (2603:10a6:10:1a0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 12:54:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 12:54:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27c26095-6740-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AqE8m1xTIuyiDV7kzXvO5NF8ijJ7bcEuK5JfhssCzelAAWjZGjEp4EBG5q9/R1Pwj19lRW+4UnjZUOo/kTjR/0/YtV871UZ66elkMOKVyLKx6ZPcIS3X0mwcHgJknvqgHq7GenbM+FGF7vSHUXsJjuNJ51c9QTodcVqxD8vbB2clpQXV/6oexn1qfKVBlSv91TZK14ZyKNIbjaTxoynsYwqqXhHRd/vgZ8ZKfM/AwQMCH1UEuwJWwq1LHzKoE9FFdfES5+FLSS5PLkIewOQpCMe1X111ISBccl3sEkA3bJtZviMNBzN+mh9fDquf8QuI352lszAI2oLHKT7UJVtlSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ynITNQOy2MSdBMw6TKLXqzziVJ/84QzYmF6GpKMCjJs=; b=niJWk1Vjap6q2eF/8aeo5kZmTUBRzBLgOazG09cvhqNVq2F4/qrvonB/dXpqvu7gRQ8NFYbLkQDCyEz2lLKlkkfeF59kdgpnD+23Y7wfjjWphMja5GjeHYjZjbnL4sO0bDOMMaNMoSdqgVlHS9FIFbcpRM2HsMNrqE9LNZ4oLbDWPMBeWhEIuz+WwlO2GUvl1zXJZi7rJ1NepoKo/pnZdp8RxYL1ROLmqpz6R+4AgxUG2fTXX2lw0AVfH4+Xyj7fFvT68lHqbv0tBuRw2GU6vewWZaOagge2tfcdQK5H1V1kfmIYBMm4tDGjtV2wmQkz2VTzkr4HZ7eaNf8exOMbBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ynITNQOy2MSdBMw6TKLXqzziVJ/84QzYmF6GpKMCjJs=; b=jWrIfYjVftkEoa2gDLxukSmUbs64ZeVyjdYLL0zn8s1EwOHYch01zI78xZl4kV9r9E6nnuowRNVKtco/eDOblsl1COjOPaUVxoB4e9v9Imt7s4xqVlq+bCKoRPa2lNJdyUhpcw7kIeRp41VMHumJEUSbW5rdGqmJKRPp4CVTqci84GXGOlm9hqZrR/VJyrwohhDgpU+EtLVw4B79Vz/XKCuZBucKPVvSqxthMQbAK2h/nq59oG3QByYdQ2AmfSKIOZI0+bV9TynksG0Hfv/5oz4wY5fpGZbhqG+Lw2LzK4I/WIW4ioOIzWH+17eEmd1BnqFjvE26gQY2e0Z/iMcMqg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> Date: Fri, 18 Nov 2022 13:54:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , Paul Durrant , "xen-devel@lists.xenproject.org" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7414:EE_ X-MS-Office365-Filtering-Correlation-Id: e8bf0d77-174d-42a7-2ff1-08dac9640b35 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wy8tn2FxNi3ZuQ87y9hF1+a1WpuPqqcLiUNzCJ3qG0xgTknu70rzETw35O1WSngwC+Oe8Vq/uVb7Qehs37wSc47M2bT4nXsDJgELz4ueEf3TG6WVQJeZ4icwyiToQ4Hj2xUJotRZaJ8QEVs92/P9VDTLY/N/WQgXqSveF8sPHnMAZ+qC/TP3eDkm8ipGrto3qfB1gzmvg0bF7zEefGhsFG1SCeOlG+QDSTksiC5N831ncIkIjpjlgJwxtD02xCuSe65D4UimIzX0vpFbRcBpUBYNForOLFCTzNkZTFxspbiloVLxdAn5Oye5ShVqX8+f83M5tm0YqIZRbzOYuO1Ybqud9TiUPWk1jIEuiliM1zRyE/iGVQro158W+ac4hTxf7HsIE0UkmvHqv4rqNkNlppOuSrqgFk9h9D4fAOcCMb6wAdiOVtBGFMf0r3EnF62Y53n0SazEIijVTMUWHHQiBFYSaZPrz6JRuHum4TSMiZqzR4fJ4u1hDkp7UxuXJedZmCkEALv50A/T8ihWctOrW1QJWERcr61qsMYjUbJ8M0cdu+klRxGckgaWmAt3Q5slZPjIn2AWprLjMIMJ/T+FSQfUEXLQ8TPcewvBxBRLobT69ShdLHa4Bc1i90/KJjba/eb2Z8Ptb8Enq8KZAvGFxZTLYv2vf1HVDvSojc/KKuWtQXXi5k+wnm14zAv9vyBxMj6RLiOUnx5huAjecHw5TGuFeZPYrUH2fcDFqYNMIPU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(39860400002)(366004)(346002)(396003)(451199015)(316002)(31686004)(6512007)(26005)(8676002)(4326008)(66556008)(66476007)(66946007)(478600001)(54906003)(6916009)(53546011)(6486002)(6506007)(5660300002)(8936002)(31696002)(83380400001)(186003)(41300700001)(36756003)(2616005)(2906002)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1d6UTBLZWROZW1NN0tCanlPRGltRmpmcjluTmJEOFFrb1lPaHcxM1dJWWNj?= =?utf-8?B?d2lSMDFLMUtkU2VHa2owcTlPRVBBQ1Ywa3lwSWd2aXhaYytaQmJFRlQ5MWRW?= =?utf-8?B?MkhmcnN3UmF0cjNVaWtTR2YrcUVSdVdwZ3dDU2thMlE3RERpdXV1ZlRsRUxG?= =?utf-8?B?cEk4Q1AyTmhlUWdZUlM1NVVnN25rRU03TG12akFkQnlRMnVtdmhlemgzU2tv?= =?utf-8?B?cTdqS09NK0x1dDQ4ZjhDOEpBOFhKMGc1ZFU2c3Rja011YVNRRmFhWDFEZE5I?= =?utf-8?B?VFpjZWVQS1A0K1B6cnA5VEI3YUZpN3dXRnl3WEZjYVBGNDVDS2xod0VPVURE?= =?utf-8?B?UmxWSWhuS0c2VWJUb1NIV01saWpLYkNvdnMzQlZMTHlMRmRKc3VuRDZPSXZl?= =?utf-8?B?dnNKclNWUjVQOUNMZmY1VDUzS2Q1ZHNaLzdaMDhhaDV3R1hrTzVXZ0h1Vmo1?= =?utf-8?B?M1BQdVlrbzc2aEZpbnpDMHBWRkdBVlh3TU1VTlk4UkF2Wis1S05BWGM1Yjg0?= =?utf-8?B?c0NRNW01U3ZYaGU1a2hEYTdVRWRIVHpxeUFhL1B1ZERMYkpyaVVMcGFjdGlZ?= =?utf-8?B?bFJLeENxL0pjTlVITWxxWVNFMFFlZGlPTFZGZTZkdXk2LzVRWC9QTG5SZFph?= =?utf-8?B?RUFtdG8weGhPSU9MdWcwMy9LdUpHSXpJQ3RZaFJwM1RYTy9jQWdHdURzVk1j?= =?utf-8?B?d055OWVueWN6S0RaTjh3SGdxM3BEcFAxalo2SGV5MlpkZ2hSQWhqZSsrTkRq?= =?utf-8?B?Rnp2WStDZWRrbVFGT0VsR2FqMjJCWDlLVjRLU2FFb2QzcEpvTXJSdnpod3k3?= =?utf-8?B?ZC9DcU41TjIvbEVRTXFsWmIxb3c1SEQyMStiWkxrTHZDMy8walU5TzdCQlJL?= =?utf-8?B?VTJvUDBXaHpRSTRnNHhZOCttYW1WMHlCY2JHaCthUWFyaTBIdHAydUhYUUg0?= =?utf-8?B?MUl4R3dkUDhXaHBEWWY4VEFLU2lJbWhZeXVDWWErSVI4S0ptdWdCUXY4N2Ix?= =?utf-8?B?elBIOXA5WjUxdGZpRXhnbkRhK3lTMW1kUlZoRnFGNXloSlVTdXA0TXJKNmFl?= =?utf-8?B?QW96d0lwQWhOeC94T054aGxnTE5SZWpITTJyd1FzUmVpR3BGUE1oT0hBcFM0?= =?utf-8?B?ZmxDaWhWZFNrNElQK0dTWEFWcmpRb0sySTF4Q0Z6UGx2ZmExck9TRGZhQU9T?= =?utf-8?B?N3lVU1dKQnJqTUxRdzVKL0F3WU11dmpSVE4wcm9zZmdGaXZyYjNwVnBjNXZa?= =?utf-8?B?bGlmUFU3LzJXZzJtZjB3WWdMMUR4aFBlUmhuM2lMTU1VR29YVjFzb1pNR0RQ?= =?utf-8?B?anhoSDhXVzJNOFU2dHlmb0lESld5cVNLR0hNNTIrUk54VkJwYTdvdGNjNCtk?= =?utf-8?B?My9udDBMZWlVWDkvMmxkMkY2ZzN1K2lEbmhjSDZhWi9zVGdCTlZvV3B3MitZ?= =?utf-8?B?cDExb1VBNElEN2JRRkVVTkdqT1AvUXBjaUQ4SDhrVGVhSVVDOWlJUXlseWor?= =?utf-8?B?ZGx6VnM4NFE4cnRxYzJRZUR1ZzRJa3BJU3ozb1dZWVB3dkJiRVRIUHFHYm0r?= =?utf-8?B?cG1XUjZlMEh6R1JpNS9HWVp5R29DMWZMTE8vWXNJV0J5OURKUlMraFlYQ2JP?= =?utf-8?B?bWZKb1ZFTElRTlBicEszOFpFSHFzc1NZcjQ3UFpGMkZpazNRcllPdTZkVVZq?= =?utf-8?B?ZTJZSHU5bVd3TERDbXpBeVFwbGZWNFVWUXNTS2tCSTdmZnVCWXhObElrMkYy?= =?utf-8?B?T1kxc3NYck5YelVuZlc1MWhlYnh4OWVFRFhQV3djWk9aVENQd1BBb1hrS1Ni?= =?utf-8?B?dTJBNTVodTJQVFArYm1TeGJxOG5RcjR5dER5NHo5ZkN3UTE2c1VydUovZmov?= =?utf-8?B?WHNodVRwRlU1NUJ2engvRTcxeFo4OTk2TXNvQ3dLZERqanQvbUQ4M1k5djBC?= =?utf-8?B?OUlhSTA2MDRnVmFLY1VlbHRhbjFPd3d6TlBCRmhPSzJubnEvQUo0SGRBd0x0?= =?utf-8?B?cTV6aHR2d0tEajZaK1pJN0FTaCs5c0pqZE1XYUJ3U2VrTVpqcUFuTmRvM3N3?= =?utf-8?B?WldLM0hPdTFZQkxNbDM3RXpZOW9CUVlseHVXTElWUGFqTHpURlpkWTRoWkkz?= =?utf-8?Q?yZq7GYN8LCAtmxB9W6cXHszs9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8bf0d77-174d-42a7-2ff1-08dac9640b35 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 12:54:34.9387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jw1wS2tcCmltqvPWNAG8NcGThquJHIsc8S2jNev2sidmFfr12wvl7nwaB9R33aIs42EhdQSdlyucoGLQ+mcHjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7414 On 18.11.2022 13:33, Andrew Cooper wrote: > On 18/11/2022 10:31, Jan Beulich wrote: >> Linux'es relatively new use of HVMOP_set_evtchn_upcall_vector has >> exposed a problem with the marking of the respective vector as >> pending: For quite some time Linux has been checking whether any stale >> ISR or IRR bits would still be set while preparing the LAPIC for use. >> This check is now triggering on the upcall vector, as the registration, >> at least for APs, happens before the LAPIC is actually enabled. >> >> In software-disabled state an LAPIC would not accept any interrupt >> requests and hence no IRR bit would newly become set while in this >> state. As a result it is also wrong for us to mark the upcall vector as >> having a pending request when the vLAPIC is in this state. > > I agree with this. > >> To compensate for the "enabled" check added to the assertion logic, add >> logic to (conditionally) mark the upcall vector as having a request >> pending at the time the LAPIC is being software-enabled by the guest. > > But this, I don't think is appropriate. > > The point of raising on enable is allegedly to work around setup race > conditions.  I'm unconvinced by this reasoning, but it is what it is, > and the stated behaviour is to raise there and then. > > If a guest enables evtchn while the LAPIC is disabled, then the > interrupt is lost.  Like every other interrupt in an x86 system. Edge triggered ones you mean, I suppose, but yes. > I don't think there is any credible way a guest kernel author can expect > the weird evtchn edgecase to wait for an arbitrary point in the future, > and it's a corner case that I think is worth not keeping. Well - did you look at 7b5b8ca7dffd ("x86/upcall: inject a spurious event after setting upcall vector"), referenced by the Fixes: tag? The issue is that with evtchn_upcall_pending once set, there would never again be a notification. So if what you say is to be the model we follow, then that earlier change was perhaps wrong as well. Instead it should then have been a guest change (as also implicit from your reply) to clear evtchn_upcall_pending after vCPU info registration (there) or LAPIC enabling (here), perhaps by way of "manually" invoking the handling of that pending event, or by issuing a self-IPI with that vector. Especially the LAPIC enabling case would then be yet another Xen-specific on a guest code path which better wouldn't have to be aware of Xen. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 18 12:59:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 12:59:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445731.701059 (Exim 4.92) (envelope-from ) id 1ow0xl-0002Co-8p; Fri, 18 Nov 2022 12:59:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445731.701059; Fri, 18 Nov 2022 12:59:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0xl-0002CO-5Z; Fri, 18 Nov 2022 12:59:21 +0000 Received: by outflank-mailman (input) for mailman id 445731; Fri, 18 Nov 2022 12:59:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0xk-0002CI-4v for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 12:59:20 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20621.outbound.protection.outlook.com [2a01:111:f400:fe59::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf60853b-6740-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 13:59:18 +0100 (CET) Received: from BN9PR03CA0074.namprd03.prod.outlook.com (2603:10b6:408:fc::19) by IA1PR12MB6233.namprd12.prod.outlook.com (2603:10b6:208:3e7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 12:59:14 +0000 Received: from BN8NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fc:cafe::51) by BN9PR03CA0074.outlook.office365.com (2603:10b6:408:fc::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 12:59:14 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT068.mail.protection.outlook.com (10.13.177.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 12:59:14 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 06:59:13 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 18 Nov 2022 04:58:16 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 18 Nov 2022 06:58:14 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf60853b-6740-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JyM3+vhgjqgTaUd8xsFypVdBmUfiF4VuOhCYEoEW/UIzVi3F8oyxgd1G0uBKnSmcJ0jwov0LCD9sebAEnFcol3oWUSxyDgT8c1b0u6KRoX1Rp+8v5vDiIcUHHQOpfBI2VMPkxcwGPZs0nXN7Hd0uvuwtajsD3hzE6yP58JTiFPd+sjn+huQi1NiotPIMmxZI3XE9qIXUK6l/AYmvYpLVakBAB2wfAFGpV/cSWllOWyvp5UxVQv3xxI+ZVGPeLxmaPtkHrNzmlqvR7p29IaPxCncKxtZICAfPtam7CGRDyB0DHOaKtPeE1veaF6GeQtiZmxx27/VYKMjaACJgRTc3VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+9Gwi04Kd3N+fiPfOQAsJErAbjp8tegdtG/SBTivV+A=; b=noGQHnSX6Ts8O3sZpOb5l920NE48THM2Oin6kHUo4EHAsB82gIN0jfvv+zMNEbsM8s56iBx9nPZ+vkiYzxgj7frduYf1MZlPdGRsMZ3FsPnWgJO2Xd5npm7n/cFAFbAvby26IphIKeYUT2kjlJqZaIq3FYfnPrwmHY4pl8mjIshGyYj2kBSYvWxNboUr8be5d6YBF7glYprQPGD9tJ+fGQiSoceUvWgPywJkOGoDqIYjk25Sjfjglrx1MimorQLmOwMBd+LBmTLMnNFJkhYLjWYm80HwFmTe1Hxb0I/x2OAcJ+cZeNtrYp69hrVqLRiOIXKy2M5QQhn/NN5vbVKK7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+9Gwi04Kd3N+fiPfOQAsJErAbjp8tegdtG/SBTivV+A=; b=S5BzpKNnjracQXafwWcqqehRA6mOGvrEAVfr1c4MHprNQGkZhJoSDxlr5AVuNkOuGeSfMXGCZYFkODpeMLTEMogVeyr+Nj/6KExGgPsvb2VvQqwiza2t4xknbTNsjXTZA1ewfCkuot3nz8usabwYWOw8yfzlOCh0Bxqp5zZMzEw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <1ae42d38-51e5-2dad-1e15-872022c234ad@amd.com> Date: Fri, 18 Nov 2022 13:58:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN v3 10/12] xen/Arm: GICv3: Use ULL instead of UL for 64bits Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-11-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20221111141739.2872-11-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT068:EE_|IA1PR12MB6233:EE_ X-MS-Office365-Filtering-Correlation-Id: e0e8761b-96a0-4cf6-8f38-08dac964b1b4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SRKnR+xQdQ+wIeGQ2/VzCPbjyPzbY2z7lr8jn4Q34KcSUpUmFBkDs+iK8uZxvpU/0SHZ4mHI+Udpifgh86NU4bjV38CeiYpuiv4XvWtFIVJCl76i5RDUAhAdOMkajVsrZ6UW7vbjOwI9qsmfhdr8/BWtKlojKg9RCTxDfdRAuR7ng399QJ3Nkt2MqSRbJCZbA/vqhwl00sX2QcmoVjs/WmWUDwjmkV6FwOz/zdAgYy8CGiw6MtrIqvPNPNLEf2iveRuPjlXuHmlq61FAwsRoKyPbUgBWa7Rsrr3/8u3WOEE92UFknhbg0dLwVFwDeLiLVU5mCdH/rUAZEremqLPpVTkzywVYGFpFTHVTkM+9QhbV6O7jNcrcYYrHxB0UxRH5GqRQvksBlNztp1IKzQRZTBXFVPm9br3nEXBhAv3yE3RWOm7VV+6H2MP32I68WmWOOQ/X8BXQ5RwDCZ+9y9af8Jsq9FHE3m4AYfZarwNB5D7X4l77xCM1mMRvYKCmVK2UqCl6Ns9rhzCdXoXoN5XRrNTNKnHVApybcxxTMA1fxUM/nSjR1JHBQC2aVR1xd3eCYdK3G8Ce+M5RrPAAqA9UFA1l4Fc7eWxRUYnGdnHz5Wfz5vSkJKi8DPKJLfmH/lcb3a2HqI1SBcJb3OJ0j32TGLuRidBVKmICvvNmyhCjk1kGoUsqAb79kNuvfwlI5cAxvFvz74wGeT5wbY/KaiFQ591OggpNubG2QW9o8pTK1UBsWFSqda8wRrZKTzgJGCnoUNfxoAQLUPbqHiZBryNNaw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199015)(36840700001)(40470700004)(46966006)(478600001)(31686004)(82740400003)(36860700001)(81166007)(41300700001)(356005)(83380400001)(426003)(47076005)(2906002)(82310400005)(336012)(26005)(36756003)(31696002)(186003)(44832011)(54906003)(53546011)(110136005)(316002)(2616005)(8936002)(16576012)(86362001)(40460700003)(70206006)(70586007)(40480700001)(5660300002)(8676002)(4326008)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 12:59:14.0409 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e0e8761b-96a0-4cf6-8f38-08dac964b1b4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6233 Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: > "unsigned long long" is defined as 64 bits on AArch64 and AArch32 > Thus, one should this instead of "unsigned long" which is 32 bits > on AArch32. > > Also use 'PRIx64' instead of 'lx' or 'llx' to print uint64_t. > > Signed-off-by: Ayan Kumar Halder > --- > > Changed from :- > v1 - 1. Replace PRIu64 with PRIx64 so that the values are printed in hex as > desired. > 2. Use ULL in GITS_BASER_RO_MASK as MMIO registers are always unsigned. > > v2 - 1. Removed changes to ITS and LPI as they are not supported for AArch32. > > xen/arch/arm/gic-v3.c | 4 ++-- > xen/arch/arm/include/asm/gic_v3_defs.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c > index 4722bb4daf..6457e7033c 100644 > --- a/xen/arch/arm/gic-v3.c > +++ b/xen/arch/arm/gic-v3.c > @@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v) > if ( v == current ) > { > for ( i = 0; i < gicv3_info.nr_lrs; i++ ) > - printk(" HW_LR[%d]=%llx\n", i, gicv3_ich_read_lr(i)); > + printk(" HW_LR[%d]=%" PRIx64 "\n", i, gicv3_ich_read_lr(i)); > } > else > { > for ( i = 0; i < gicv3_info.nr_lrs; i++ ) > - printk(" VCPU_LR[%d]=%llx\n", i, v->arch.gic.v3.lr[i]); > + printk(" VCPU_LR[%d]=%" PRIx64 "\n", i, v->arch.gic.v3.lr[i]); You changed these specifiers to be llx in patch no.7 so such a change (using PRIx64) should be done in that patch. Generally there is no need for a patch to fix something that you introduced earlier in the series. It should be done in one step. Having said that... > } > } > > diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h > index 743ebb20fd..227533868f 100644 > --- a/xen/arch/arm/include/asm/gic_v3_defs.h > +++ b/xen/arch/arm/include/asm/gic_v3_defs.h > @@ -195,7 +195,7 @@ > > #define ICH_SGI_IRQMODE_SHIFT 40 > #define ICH_SGI_IRQMODE_MASK 0x1 > -#define ICH_SGI_TARGET_OTHERS 1UL > +#define ICH_SGI_TARGET_OTHERS 1ULL > #define ICH_SGI_TARGET_LIST 0 > #define ICH_SGI_IRQ_SHIFT 24 > #define ICH_SGI_IRQ_MASK 0xf adding a patch for just this macro is not very useful and you could take the opportunity to modify it in any of your patches. ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 18 13:00:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 13:00:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445735.701071 (Exim 4.92) (envelope-from ) id 1ow0yu-0003iQ-Ie; Fri, 18 Nov 2022 13:00:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445735.701071; Fri, 18 Nov 2022 13:00:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0yu-0003iJ-G0; Fri, 18 Nov 2022 13:00:32 +0000 Received: by outflank-mailman (input) for mailman id 445735; Fri, 18 Nov 2022 13:00:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow0ys-0003iB-VS for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 13:00:30 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f9f18eea-6740-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 14:00:29 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 449653200C19; Fri, 18 Nov 2022 08:00:27 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 18 Nov 2022 08:00:27 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Nov 2022 08:00:25 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9f18eea-6740-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668776426; x= 1668862826; bh=4EHC9MKw629pycdLTqwfH+QKLCKS3aENIW6Fnu+Z/Ms=; b=H WCTJ1p7Ur0q1kOZOuKVB8DYeMDH7nSRlIewqZN0yWF33pZTrDjkUnyQsckgzwlMu 9xnBAybNi8LlLq4l5M3ayfkRukXi7fTdpdd+g2jjKBG8QZqevACN2ODXqptyfiE6 2GO1Agd7LcWh1hh7+v8/COEjzDtxDWOlgpvXoAg4IhC2+Q882Qa1nYkkJHQigX5U eDG5Tl+ErH38JtfAcL6CNbkTjY4Z/WqnY4GZr5ZPcygj7bvLGUw2lD5wlhqvlEof JE6ofFJCbvln5ar2DpNIiz7Z2euA/JnJ01XzPivmLNg6fXLg3qZMbqLunur+nbe9 WDd06l20aSQrPkVUONj9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668776426; x=1668862826; bh=4EHC9MKw629pycdLTqwfH+QKLCKS 3aENIW6Fnu+Z/Ms=; b=EPoZ8lQFM7WnkD2kn0+DJaKIC/I4Doa5nNO8dv9j1wpe lAUBu58kfgh1TEe3UUUl3PagVLy8pilWuqq69VerOFyVzjsb8iNKnzTEJKQBISwV OeGnDRbNAxAparwTpuK+VZ3VrDc3UVAioRNtWOdVv9kCa5qkYfKGEEg6gZ1OpFKg XrIiIqGnkSurdZRAp7p0BKNo2wfDg/is2w7q4398LIbm53PaPpz8WLJxAiB8R/58 xooGdbXh71IqjXJ6kD+vBkI2UQZ4Hr171Uo11dzx+yn17EL95+fqlgp2aYwqKdAH npDYSs4PfHsOMsUCTqv607FyWarOQgf/GlKQbw55+g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrhedtgdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Fri, 18 Nov 2022 14:00:23 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/2] x86/msi: Allow writes to registers on the same page as MSI-X table Message-ID: References: <20221114192100.1539267-1-marmarek@invisiblethingslab.com> <20221114192100.1539267-2-marmarek@invisiblethingslab.com> <15138618-5cb0-8304-a56b-cb787e187772@suse.com> <9d034957-822c-74ba-9aea-0944cc456870@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GusqaJC/8lAeSwP9" Content-Disposition: inline In-Reply-To: <9d034957-822c-74ba-9aea-0944cc456870@suse.com> --GusqaJC/8lAeSwP9 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 18 Nov 2022 14:00:23 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/2] x86/msi: Allow writes to registers on the same page as MSI-X table On Fri, Nov 18, 2022 at 01:33:39PM +0100, Jan Beulich wrote: > On 18.11.2022 13:19, Marek Marczykowski-G=C3=B3recki wrote: > > On Fri, Nov 18, 2022 at 08:20:14AM +0100, Jan Beulich wrote: > >> On 17.11.2022 18:31, Marek Marczykowski-G=C3=B3recki wrote: > >>> On Thu, Nov 17, 2022 at 05:34:36PM +0100, Jan Beulich wrote: > >>>> Which in turn raises the question: Do you need to handle reads > >>>> in the new code in the first place? > >>> > >>> The page not being mapped is also the reason why I do need to handle > >>> reads too. > >> > >> Just for my own clarity: You mean "not mapped to qemu" here? > >=20 > > No, to the HVM domain (in p2m). Xen (outside of MSI-X specific code for > > HVM) doesn't know where those reads should be from. >=20 > Hmm, I was expecting them to be mapped r/o to the guest, but perhaps I'm > misremembering. Clearly both ept_p2m_type_to_flags() and > p2m_type_to_flags() take mmio_ro_ranges into consideration, which is > what I was basing my understanding on (without having looked at other > places in detail). Qemu doesn't map the page (using xc_domain_memory_mapping()) where MSI-X table lives. I tried to modify this part, but it resulted in EPT violation on write attempt (and my emulation code wasn't called at all). --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --GusqaJC/8lAeSwP9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN3gecACgkQ24/THMrX 1yz9yQf/QS1FJclofzjtQVr6ZaCqzuNX4dMjEJKWEjojyd4EvPlWBZ2qs+IDtKjS hEAn+pfKe/2y089giG+Dh5wvZwnONZobxeQ14Vg2jTeV7rIgSG5SVmPhZkfU4KIQ 1ABhPg+EAdRXklbCb6SoIWSYcLHRg44VsYURuMrazXbT3/VKGhT5eLd6xgc1LttK 2P1gy4J76x1rLGoPF5YMCMpD19tczQcQdKWtGMoZFI9d/Lu6YlntHwllf+AUkShe CbMrauSkNajQrqOt6vCDifavzJur6khROYRVV8FEypgy+FTgWgkIbeWWYB2dbDlu uwS1bzatLFE3SnW42Fyqyfdr0IAxtA== =eYPR -----END PGP SIGNATURE----- --GusqaJC/8lAeSwP9-- From xen-devel-bounces@lists.xenproject.org Fri Nov 18 13:04:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 13:04:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445743.701081 (Exim 4.92) (envelope-from ) id 1ow131-0004OT-34; Fri, 18 Nov 2022 13:04:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445743.701081; Fri, 18 Nov 2022 13:04:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow131-0004OM-0G; Fri, 18 Nov 2022 13:04:47 +0000 Received: by outflank-mailman (input) for mailman id 445743; Fri, 18 Nov 2022 13:04:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow12z-0004OG-Kx for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 13:04:45 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20624.outbound.protection.outlook.com [2a01:111:f400:7e1a::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9241450d-6741-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 14:04:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8218.eurprd04.prod.outlook.com (2603:10a6:10:24a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 13:04:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 13:04:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9241450d-6741-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HawpZIVSqHL36vPume5E1DjIWvXsc5hJxoFE+au7uUmtc0+B/GC5FIqnfn4sx8U65xyCoTNFDYCQLVKOQx0Z6Bg+oVO7Jinlao34oVgOvdaRWUL+DmWpVsRIp1kHJ1LE0yK04ji7wnsaQAnPPt6SEMFdbzpyKWu3mImyttVC5wfpXYdPNyYSnckzGhAQI0klloCmSYPlBLAjpLyF/D8m7hWhGLyr0zDvZEOlEfaOTc3KB1syBMKThjsG7Q0K+t/M+mZIQ5I9Pb8kukg9ufko+vrNuWAUux3Gdc/QoaMvlMqfLdyzoYwWF9Ss19z43eIhbG4KLZfHufgPIldradzJMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JDMxY7Qucnf0dQdZtGjTa9VTDvqXuaXH7mTj8w423DQ=; b=HoIiDrqjpPfjQoS55LldzMucCHQ4sAGxRAs23gowj3HyHfkORnddehjYguPEiGMkYUv4ripr7KjAZIo+Dk3gEv0MnnMalLM/5/imlMaHCySK1m41m0dORinh02vgkGDVRbp/FdTe/8LEIGLeipOSEzpXJKobEFmyiqWCRWTs2uVPA8NSGqGxMRF0/TmPZba6oiUEQ3tF5haaSwGg6Bw3sTzGqQc6MXDraqG0qgQBvXKPRy5qtsLPg8+vxgUmm2E1oPXVhTlylymR8jITWudftcsvvDvdLA+zF2Cxac3ap7iF9mecSRxha6FJFubsZit5Ker0GYTs1VSbI8hqi2FbdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JDMxY7Qucnf0dQdZtGjTa9VTDvqXuaXH7mTj8w423DQ=; b=hzYYNT0BpUto6cK2o/bPpH8CwZ9lGFZxdpuVlIHsGd+Hk2mNGmpvS62h+BznjryZ/LKxruYcsttwnXxMqCnnaOG3l2fFgt0AcSG7bHcikZ/7IrKt6mue0uDH6boRQUUJ4glOXNxlcJdiJ1rgbhF//eewR3yDOJnkHvm2qBKyJUWnbbwvaa47ArI8kj+IU53RtMD5tPXOWVVCIhEDjhXc96EEAxiWyAjD4x3Xz/DqBRsbMoHQw03OBRbgKTfx+adsnTlFaa9U5CsqRpMFgmXkSnQj8g3FsRfWsbO+Xpl0XKyxc/zxcwgvC83F0klSEWWCUWgD+R0llV2Q9haqpEKCvg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 18 Nov 2022 14:04:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] efifb: ignore frame buffer with physical address 0 Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20221118123925.25363-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20221118123925.25363-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0140.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8218:EE_ X-MS-Office365-Filtering-Correlation-Id: d0d5d2a1-5e1b-452a-c07d-08dac9657575 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fc/w64UA/pLSsLmV2loCTgDG45uvC6OADvo8g0Uwe5lKqTwoVeUmbulR1Dg2X5XAzckPL1+2YtkKgLLJeQJlUi9KkbyT7+XhSWhmleCmWABYSAFNOjkIzdXJWlj2EcuqJrdmD1THWSDxfuyc9rZZv+ZSGO03w/iuOpZpGpSjLd53t1MoFovaWDdIAW8ug0sagE37H55homr1Hl1bVLC8zcegaiJNoMIHHyjZXxVdJ+FmOh4XOQpVsTwtN2QTZdeuxaYjGxk1DtgsXCPXYjZYGSUG+2GfGb8zZxrarNDawZMoPMDjB8pp3MHLLWbfKicqnWcb+4lMxYGuTVSQvw1Y0Wy0gBY4Lbho3JuBcWaVUipFU/a1I1F8ppUnvvWpXifgnU1d0dC+Zt3ahOl4ZVR2kpopf/CmharAOcAESizu82SXJgDM18K3cIVKsruVF7QwzKv63vyIzu9wxSKmJutCUK9YAv3LRDLKS8Ja4JecjKi1RQm9hYhUw1R+c7tnf/NnbewdpnW2KfqxacwMizhq6JBOIP6vZSbcXfC9JmcNGBpn8tID2ZkhhWMAZiTX52OoQWJ1og8l8Tfw1NOAFGnIUz5lI+jH48D5LNPAW5Noy2x9nOYEtsl5YoqCzJgHBBfE4R0V2K1EBl1dbZZbfo/W/Vg+11HWVpWGqhaF9wHUbUmXbKoMAdZyIDaKh1DiQwPmykJFpCibh9JR+g0cX2EHyTGztwVVMuuJfTFrIEoNvcs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(366004)(376002)(396003)(346002)(451199015)(2906002)(26005)(53546011)(54906003)(6916009)(316002)(8936002)(186003)(2616005)(36756003)(5660300002)(4326008)(66556008)(8676002)(66946007)(66476007)(6512007)(41300700001)(31696002)(38100700002)(31686004)(86362001)(6486002)(478600001)(83380400001)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHpXbGkrT2NnY3NRNjlITjQ3WnFIbHluOUZOQkJJTC9EUUR2T21JUHdvV0xD?= =?utf-8?B?QXptUkJmK3ExT3hIT2plcjI2cXJoTDh5Yk5lV2hkMU5UK2R4MW9JMzZTdEVP?= =?utf-8?B?dDV0ZDNpMVphaVlKZEIvdGRzcE52ODNqWmE0bHlFRE8ySlV1KzZrS0RkbjNi?= =?utf-8?B?WUhwVmNFeVlvb0tTSSs5cHlOb3dQTXRlK2dNL0w0L0hVZ0F6ZWZ4ckxzYkFT?= =?utf-8?B?eTJqZm1GS2V0TVlETk1YRjM2TXhmZ3pFT3dyWVlJRXFkS1NScHoxVzMxTGhS?= =?utf-8?B?Qnk0SWNqN1BTQnZXcUNJOXJBL2dmbzhsYlkyc09EWDFVL1EydUtKTUY4Tk9x?= =?utf-8?B?NW5Ha25lR0daeXhiMG9obGZlUU05RmRDUVFZeG5JMEtoRmhvMXdZUzVEMjJl?= =?utf-8?B?SWRuZ3lVeXlVWStONlRFeS80RVlNWjh3dWU3UlJ0Qlh2aW5MNlZGaHRIM3ZG?= =?utf-8?B?V3ZJd0hnbjR2cEFWbWQrNDlWR0VnbU9wUG5wNSt4LzQwTzgyWkgzS1h6VHlw?= =?utf-8?B?UmZra1djZGNZczRUYm50QWEwZnZxRWV6VWxHTjNSV0FiUkZ3b0EvdGhIVTFr?= =?utf-8?B?VlRQYWpVaDZ3SHRuK0FKa040WXRoRmVWdjNJcWQ3RTM5QVZEVlI5YzQweEJR?= =?utf-8?B?MGtyU1RLQkVQbFlSZTllckh5THpEQ0lCUEc2TXhSVWl6Wm96SzI5b1g3R0lV?= =?utf-8?B?YkpBeXhWT1pxaTRZOFlyNndsQXptOTJzRGVRVENPYThYdUZPcW54NFFWbC9E?= =?utf-8?B?K1pXaERUVXRhUDRtKzJOYjIxTkV2bW93a09HRFZCaVVIUXZSS0RVU0lkcG9n?= =?utf-8?B?S3ljZ0M5anpYc2tJQzAzR2hIbTZDbm10VGxaMjBlNlZLR3d5S1o1NjYvYnJY?= =?utf-8?B?MEFnTnZuUmFNc2NsU0lRRjY0Vk4zN2tvcWdUSmxPZXNLUlZpSEFCTTRkdGRo?= =?utf-8?B?L01aY2EzblovQ3dhZE1WRlpuSWtVUTdjS1IzeVRkVnVCMWUvRUxnVStLdG1B?= =?utf-8?B?eGh5NStrdlA4Mm1hUGh2ZjlEYm1tRTgxUFdBL0V6dDZKdDhuSE13TFRUOU4x?= =?utf-8?B?c2t0bTFmcmVhNGFpRlM3NndvTDJnS2lIT3pCNEFkK1A5cFpQWWJJdmFVMEVT?= =?utf-8?B?eXRuUlU4dzBnd2JCamFXaXBKOVh5bEFHc1l1QzVCZlpQcFNXL1JKVDQxTTJO?= =?utf-8?B?ZjRjdnBzcWx3a1dzV01ZNDl0d3hKUkdVT1VjYWhsenY3U1llaklwZ0czQUZC?= =?utf-8?B?cE1sdnBBK0hwQm1UOXdhcm5GSXR6UDRONjZHNHhZRVFHejRIandWeFBRNGJQ?= =?utf-8?B?MWZQakhGeGpHa1VuZWt0NlppRzJvUDBqZ2llSm9URnR4bDNuRE4zdUFqOWJu?= =?utf-8?B?Vi9iNU1CWFdPVjE3YWtldytSczFXVXMrWURoUHp3ZE9aQ0U1YmU1b1l4QzR1?= =?utf-8?B?S1BXdktOUEwvQzV6OGxHVWtJWGt2QWI5QUZlSE5BT3Z5b2lsS2x6bzk3QldF?= =?utf-8?B?MHZNdzIxdWxNS0ZiQXNuc2VvZmlxZ2pmN3ZnejhkQ2ZMM2xpbkZXNVNQWmRL?= =?utf-8?B?anpXUzlWSFdqRWpTdmxNbURKQy9NWVJob1BsTkN1bGwyanlaNmpXUzZFblBv?= =?utf-8?B?ZTN1eWRmSmErUWtBTklLMWdYWlRXdkliZzJyRzkwU0lERmFiM0FvNlNKWHB3?= =?utf-8?B?OUVaZUdzSjlSdDVzck5iRTVqV2NMWlVLSkI2Z1JraVZaMW5yZ2UvMHRnK3c0?= =?utf-8?B?NU5FUkFUYmFLWHhFSXZGYVNSMUErdWlyQnphY3pFVm1EL1gzNHlBTlJ0cXY1?= =?utf-8?B?TXp2SWx1b0FyYWJYQ1l6bCtwWVRRSlBSaDV1Yk8ybkxTVHh1L0UvQ2J1bmdQ?= =?utf-8?B?VWlua3lCZzNxMk9WaVZSa3I0aXZoV05vYmsxVWI4K29DU0pwdUFNTkN6dUg5?= =?utf-8?B?WkVOWWd5RG5FbDFmelJna0pWSGR5VmRraGhRUjl6S3FJTG9zR0Y2dGVoM2lC?= =?utf-8?B?aXRUNGY0WmF4STZMQnpEK3MzUWdOL3J2R01lSkhZWmE0bDZSUmF5RkhVMDRh?= =?utf-8?B?WldXRHF1ZW5hK3pqbHBUdFNrd0tFVlhob2hKZm16NTh0dWFHbFVoOFFkTGRs?= =?utf-8?Q?fjhR05L6fFyPc1ZjrvItmSOHk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0d5d2a1-5e1b-452a-c07d-08dac9657575 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 13:04:42.6815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XygH5//Gv7uJ6vbjaKBUcEFutreJGvssMRvmR/L9UPgOMzUWaWoK/hUZU/Kvp7Xr2q/dSsOZpcAwDezfTlbEOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8218 On 18.11.2022 13:39, Roger Pau Monne wrote: > On one of my boxes when the HDMI cable is not plugged in the > FrameBufferBase of the EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE structure is > set to 0 by the firmware (while some of the other fields looking > plausible). > > Such (bogus address) ends up mapped in vesa_init(), and since it > overlaps with a RAM region the whole system goes down pretty badly, > see: > > (XEN) vesafb: framebuffer at 0x0000000000000000, mapped to 0xffff82c000201000, using 35209k, total 35209k > (XEN) vesafb: mode is 0x37557x32, linelength=960, font 8x16 Interesting mode - should we check for non-zero values there as well, perhaps? > (XEN) vesafb: Truecolor: size=8:8:8:8, shift=24:0:8:16 > (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) �ERROR: Class:0; Subclass:0; Operation: 0 > ERROR: No ConOut > ERROR: No ConIn > > Do like Linux and prevent using the EFI Frame Buffer if the base > address is 0. This is inline with the logic in Linuxes > fb_base_is_valid() function at drivers/video/fbdev/efifb.c v6.0.9. > > See also Linux commit 133bb070e94ab41d750c6f2160c8843e46f11b78 for > further reference. > > Signed-off-by: Roger Pau Monné > --- > Other options would be doing the check in vesa_init(), but that would > also then apply to other framebuffers and won't be strictly limited to > the EFI fb. Well, zero is wrong uniformly, so it wouldn't seem unreasonable to put the check there. But I'm happy to keep it in EFI code for now. > We could also check in vesa_init() whether the framebuffer overlaps > with any RAM region, but I think that should be in addition to the > change done here. Indeed. > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -552,7 +552,7 @@ static void __init efi_arch_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, > bpp = 0; > break; > } > - if ( bpp > 0 ) > + if ( bpp > 0 && gop->Mode->FrameBufferBase ) > { > vga_console_info.video_type = XEN_VGATYPE_EFI_LFB; > vga_console_info.u.vesa_lfb.gbl_caps = 2; /* possibly non-VGA */ A few lines up from here, just out of patch context, there is a PrintErr() which imo is bogus/misleading when also encountering a zero fb base. I'd like to suggest that you put the new check early in the function (perhaps extended by a zero check of other applicable fields, as per above), returning right away alongside another new PrintErr(). Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 18 13:07:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 13:07:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445748.701092 (Exim 4.92) (envelope-from ) id 1ow162-00053K-Lz; Fri, 18 Nov 2022 13:07:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445748.701092; Fri, 18 Nov 2022 13:07:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow162-00053D-JS; Fri, 18 Nov 2022 13:07:54 +0000 Received: by outflank-mailman (input) for mailman id 445748; Fri, 18 Nov 2022 13:07:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow161-000533-QT for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 13:07:53 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20619.outbound.protection.outlook.com [2a01:111:f400:7e1b::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 023cdf6e-6742-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 14:07:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7471.eurprd04.prod.outlook.com (2603:10a6:800:1a7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 18 Nov 2022 13:07:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 13:07:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 023cdf6e-6742-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g8PUtd35oirKymh9ERMG6KexNqDPGaMz8tVODYcpKy5F2uPIFF5ikearzrxpKwEErdneRm5PhHAB/HOdYiU4ZuuIRPU9y6sp4r94hStuSwf2EYmNrRtBX4popTpLDPytnpqVa4qyMFrxpJ5e/PoffpwEeKlTSzRDLwjqBwMX3wWG908sQiH0fPVi5bDbhSxCxL5bfYL8yj0Y7xHfVeIsPGjGPOqA4Va3Cp6hSOkuB4o4qQd6ePb6P+RkMLzyw8/rjKCKgdG52moL4GoH4YwpMpMyawDqahgV2L5nSyZHSGo2ub6N8uab3bbi+D+aESigLyt64//IHEuvlP5GGZekJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wj+wN79UIU++EZEPDK8h9OnzJpEAaIWwPp7bth08jRw=; b=U1INVGbgBcMTVyLRasD07llkkZCNVpZIt41X37OZ29tgRNaD6upEgxwFznwd6nB9B6ZfpsIwAmOjBYBMQVX6oZ77lBduWNfi0749+wNU0ycrnKbq65vIZo4E/qn7yKjH3mFRS1siDWNwwV+sSrYf6oxvKPFt1yr1GQvuRMl1iYMAoiTFqxcfjwhbIyd2DGYjtrsEqv+9cn6IhtnOfq5ruzPxHhgrq8iY0W1mtlRKDVT1uehtipbr+bURNU7ZrsZS9mrW4ou/1/6w+2+LDYNxHW/YiQeQtgmWO+ISMpvY/1i+ZLHJmHuFLzZFTgWG8/91YrlHGolurzIiB3z3ui1Fxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wj+wN79UIU++EZEPDK8h9OnzJpEAaIWwPp7bth08jRw=; b=rW0H3reDWSTkAtBpMzrVd7dIRNUwcWh8QAnS+th8JWL9wK/J1PmgneAbGdMNBrjguSEQAx46tAl+tSn+m72AB2k18HmQajE+dhavR998T5otQ0ZeUPh4jbz0Z+hzXf6ueYkeQN6n0oW0e9c1R61SYZw0+R+A+8w3kkPOVooCl/pdZjBhvvPrsjsW3i80XhKTFxiTI2n0Iyzsvhbqm56JtLpWQCnUG0/Z1ERdgnPATCruwqkBhS/HCIaUyukGLey5CgKqinuAY/8IbpdsScec5LYxPlth/y0U32ocsv+EmrAtFFviOsZCgQbCyu5UHehHGNTcxXKhUA+pyd+QYBXiDw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6566ca22-e1fd-6e5b-3401-25838d7c5c17@suse.com> Date: Fri, 18 Nov 2022 14:07:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/2] x86/msi: Allow writes to registers on the same page as MSI-X table Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20221114192100.1539267-1-marmarek@invisiblethingslab.com> <20221114192100.1539267-2-marmarek@invisiblethingslab.com> <15138618-5cb0-8304-a56b-cb787e187772@suse.com> <9d034957-822c-74ba-9aea-0944cc456870@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7471:EE_ X-MS-Office365-Filtering-Correlation-Id: 53889188-6f46-4d6c-7623-08dac965e582 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4Pw1LdIZghYKKvDKjC9wS2gXmCK3HSfiJ0NEv7eAMkTtIW0hEthaObpHv9P63pmc80oBQBQB2/tbvPwuoEvMwy+vgGwxu/zXRAkVorxxUmU/AenHKqqfQZpK1bQqVQCgKNVonlPihggkfuE7PCmp66tKh3wVgbMJj+mp58B3nTaHZIjMQMDLCvFD2l3uSvrBADEa+On4YoO2ZOh2VcKvLlL1Jwkk0kiSwFav2IhXqnQXQ0pH6oP8fK4PU9S78ffoljV97PJAzoymPfVyNM19n1tI/FC8SY7jhCy7nwN3aFZb9u8avq6NcrtXG3Jfg9AEtj5ANdMo8ZLcVwd3MFLNN80YinXv2CMWbeesARiCJRgzvywoG6bh9rwKDFBMW8Ks/7GPhBkv3Js8CRuS3lYIqhwxc22CMapQDM7y1vP9rXONeAa7kHqV2LRhSaiI1S6mWQUnHNEryAqQRw7kbZ2suDJG2ovx8sArQEYhjVj5QW7f7urYMuxIWTKIBv083Yz09MYKvkILiD80tr2P4NKSTYA0xOPAjFJOEPFJSnYChOPI9ThD1GIxRMo9+Ov7vJa9/iugD3wr2dsFAUkV3UoogQSuR66E2NSdbFq5RBkoM0zTplvf3h+0P2zsfwsK8h7VyoO+Iq3NFDGEs1P3ZwrvQhxDk/56qouGckgAvnE7CY1I0JaBpVzh/NJPUUgUHafOfWV1rI9X6Ik/Mnt7gHoy4+QCDPau/x5mT/Pq3YOqjB8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(376002)(396003)(136003)(39860400002)(451199015)(478600001)(31686004)(6486002)(8676002)(26005)(66476007)(8936002)(4326008)(66946007)(36756003)(66556008)(6512007)(186003)(5660300002)(53546011)(6916009)(6506007)(316002)(54906003)(2616005)(2906002)(86362001)(31696002)(41300700001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1hlYzE5TUpYMlh3VjB3blg5RFB2NzFxcTNRcEpWMndOMGdxUUprdVhINE1u?= =?utf-8?B?N3dkM1RYZ1oyK3hwZmd3YU1lUE9rYkJoMVQ4cms1MXIwYlViTExQTUJGQ0l5?= =?utf-8?B?Z255OVR3R1BmMFY2VFFJK25scUI5eFpqaVZJUGwvT1huVnU0NnBxc2gvcHNh?= =?utf-8?B?QXpLbERuREZIZFFUTSt5OTJxRmdnYmd0WVhMeCtNeGJrdmNUNHBnQVZYYmN4?= =?utf-8?B?eDYvaGVoVEd1R1hTZ0tVeDNoa295aW01WmM0aEZFV01tSzc1SWpDTmRZVzdN?= =?utf-8?B?MzhlWnBGVmFKTi82N1lmb0pMNGNEd2V1ODZienB2RUVKV25UYnFENU53emVp?= =?utf-8?B?alN4TDJ6TlZLVVVyZDhGc1NHVk1GYldiWDlTaEZDa29ZZUpHMW5Ib1pGQVov?= =?utf-8?B?aWljMWRLRStMZ2JDd0RXM1h3YmdNUUR1dk9obGEwbFhOd004K1U4bDl6N1VK?= =?utf-8?B?bUxMbzFxbUExaU9sV0RUUkllN2wydkF0ZzZXTEk2NW9lRkdWYVU1a2c2WFFC?= =?utf-8?B?ejc5TVdhQ3R5WDVldHVoOVUvSmVOWlB4c254ZHNxenZuVGptYjFtcURTejVq?= =?utf-8?B?cUVQaG81SVRaUVk5VEUyUm5yYllaUWo0RE1mSkxNOG5CYlBzajBsdk1CclZR?= =?utf-8?B?OXNQZjZ5Nml0ekNUNnRFVk9TN0Z4Mk9vV3FhYXY5cjAzUG1aVDNKREtEYi9N?= =?utf-8?B?eWJ3ZmlzTlBuTUtHSk5qVlZta01SeXBuUExYVDBnRk5HSld5RC9MYW56N0JL?= =?utf-8?B?NS9ZQm15MFR5MTJVTEg5Lzhsa1djcmtIVUhSN1hJV2RwN1htdzUxcnV0L1RX?= =?utf-8?B?Ny9LQU81SGdmdmpaeGVpSDVaTnN5Z1dnZnpTOUNuekpuaHBjM1NTekV1dVkv?= =?utf-8?B?czMwYXlHajFMZjd1VkNsT2p6cGtZNUQyRllHWmVVS3dwb1BkaEl0QTdvOFJl?= =?utf-8?B?QUVYazRaQkJBeTZKOFF4dGRGRkp4V2RlSVk1U3JqNkNWUVhISVFIeE9vYUxQ?= =?utf-8?B?WkgrTVRDVDd0K29pMDREWGg1dVN4eG53RWNSM2N1Y3EvaXJHMW94aUFKTi9P?= =?utf-8?B?V3ZkM3lhQVNlZWZVcFZiYUVNTFlSZEdzOXFxS1JmV2NmV0Iza2Fkd213Zkdi?= =?utf-8?B?UUNJQTc4V0huc1dxaXYvb0hqeTJ1M0ZMcFV6aVkvMjdGeGxVdmdRN1R2c3dx?= =?utf-8?B?NHVDc3BzVFNIUGkzME0wTk1KQ24xT2MrVHgrQitGRG9ucHN1UytHOEhHRmxx?= =?utf-8?B?bHVOUWFCSnlLSHk4ZWVmdkg1Q3B6cG1vcXo2NnZYMU5jUmFSODN0cDBrMFo0?= =?utf-8?B?Q0p0SmxObkV4czZsaWJZU1VRZ3FRU3R3dm1GWFNydUFDMFRDejJXNlZYMHlu?= =?utf-8?B?eUN4RGVLSTdjVWhRVXhtY21IWHkvTVhhdGJGOHZtRWZ3amEwZGJmS1JlNHRz?= =?utf-8?B?QkIyRlpIL3dsaGFFczVuQytHWis3OHRMMUI1Rm4zbUlSTXM3WTBRMXFHeWxq?= =?utf-8?B?Q2tDNGNrUUQwSDVQckozZkhpVHRXSVRxZ1BhdG1zVWxGbnRJd1F0YzRvRit5?= =?utf-8?B?eE4wWVBSdjFSRGVzQXJ2aWJ4cTBnZ3p3emFyQ2E3TjdJemVIVGpCaVM2cjdM?= =?utf-8?B?Njdlbm85ZHRCZVFUc1dCQjF2ZmQ1TG1IcGttZmZ3OXo3WVhBOU45dk14Qk5v?= =?utf-8?B?QUV6bVVFUzNBTWlRWUlhM0NwbCtuS2Z2OEEra3RKdk1IUFFNK2thTm9saGh4?= =?utf-8?B?elFsV3BjbEJXOFdIc3BQOGpKM2J1Z3BjRHBJUllBbzRzajdjcG13blNYTVZ6?= =?utf-8?B?a1FuZFU2OUw2TmZjMERJeVFMY3B2RzlyOGszWUxOdDBVYXVSSnRLbzRhZ203?= =?utf-8?B?ellCWVNiK2o1Qm13Q0ZDNVpuVzV2TkEyU3VUMEdIZ2U4UllPQWdPOXlLdE1P?= =?utf-8?B?VSt2OUtPcHB5T2xua0Z4N0RtbHVTRy9CN2FsN0xUWTVQTjZvS01Ec1g2OEgv?= =?utf-8?B?ODRJdW1ZOHF4U1QxOXpPYzByTDNFM3FKTUhyM2dTUU9HcGNmUlpPSlU3TFJU?= =?utf-8?B?N0lubjg5NnUzREgrODdzd2hHZm5oLzllSWJ1Z0dPL3RVTTN5cEhHVkZMc09U?= =?utf-8?Q?sISbEadtNdUOBAxxdldT1xgel?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53889188-6f46-4d6c-7623-08dac965e582 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 13:07:50.6852 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: amQwVAtWZhaQjaX9xrsfPOJar1N+P9Fdcm7yjmUaqZLTgb8gbxwDLpGzmPBHzKyMyq64sddSgKzZUzddeANVkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7471 On 18.11.2022 14:00, Marek Marczykowski-Górecki wrote: > On Fri, Nov 18, 2022 at 01:33:39PM +0100, Jan Beulich wrote: >> On 18.11.2022 13:19, Marek Marczykowski-Górecki wrote: >>> On Fri, Nov 18, 2022 at 08:20:14AM +0100, Jan Beulich wrote: >>>> On 17.11.2022 18:31, Marek Marczykowski-Górecki wrote: >>>>> On Thu, Nov 17, 2022 at 05:34:36PM +0100, Jan Beulich wrote: >>>>>> Which in turn raises the question: Do you need to handle reads >>>>>> in the new code in the first place? >>>>> >>>>> The page not being mapped is also the reason why I do need to handle >>>>> reads too. >>>> >>>> Just for my own clarity: You mean "not mapped to qemu" here? >>> >>> No, to the HVM domain (in p2m). Xen (outside of MSI-X specific code for >>> HVM) doesn't know where those reads should be from. >> >> Hmm, I was expecting them to be mapped r/o to the guest, but perhaps I'm >> misremembering. Clearly both ept_p2m_type_to_flags() and >> p2m_type_to_flags() take mmio_ro_ranges into consideration, which is >> what I was basing my understanding on (without having looked at other >> places in detail). > > Qemu doesn't map the page (using xc_domain_memory_mapping()) where MSI-X > table lives. I tried to modify this part, but it resulted in EPT > violation on write attempt (and my emulation code wasn't called at all). Well, yes - that leads to the other path I pointed you at, which is used for both HVM and PV (and which, as per what you say, then looks to be relevant for PVH only right now). Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 18 13:08:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 13:08:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445753.701104 (Exim 4.92) (envelope-from ) id 1ow16r-0005aX-V0; Fri, 18 Nov 2022 13:08:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445753.701104; Fri, 18 Nov 2022 13:08:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow16r-0005aQ-SG; Fri, 18 Nov 2022 13:08:45 +0000 Received: by outflank-mailman (input) for mailman id 445753; Fri, 18 Nov 2022 13:08:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow16r-0005aC-4C for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 13:08:45 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2060f.outbound.protection.outlook.com [2a01:111:f400:7e1b::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 20c19711-6742-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 14:08:43 +0100 (CET) Received: from AS8PR04CA0009.eurprd04.prod.outlook.com (2603:10a6:20b:310::14) by PR3PR08MB5563.eurprd08.prod.outlook.com (2603:10a6:102:89::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Fri, 18 Nov 2022 13:08:39 +0000 Received: from AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:310:cafe::4e) by AS8PR04CA0009.outlook.office365.com (2603:10a6:20b:310::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 13:08:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT012.mail.protection.outlook.com (100.127.141.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 13:08:38 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Fri, 18 Nov 2022 13:08:38 +0000 Received: from e9564ab55d0b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C6C72996-3C92-4758-941B-FB6A790EA0B4.1; Fri, 18 Nov 2022 13:08:31 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e9564ab55d0b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 13:08:31 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB6714.eurprd08.prod.outlook.com (2603:10a6:10:2a4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 13:08:28 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5834.007; Fri, 18 Nov 2022 13:08:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20c19711-6742-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HVdbegJFSl8rsfpweAcvv1Cu15l2BVX230/QXDxZbls=; b=gKyhYiHXz6E3gh7jEL4rCEO24fH1nuTE0QmPorpEHbrqgyQMqyRtBgegsyigI6rVGcX0Hg6r8KayzCuDObcDqPGeNC67SWWzyB9Dk9xikEyQljgof36TdWjEfP0INXOHOaAM6pnuKGtKXyTTGJ4Iu4/j3fpKTTCdA42r1YmqnC4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0716b2e3c7229a0d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ddwUwTUc8ItpM+PcuoJktEymORTzEptC5JgSRQUYvloNZ91JbnniVWxD0VGtNI+2sPug8hZjGp8OWTDH0A9qYyV2D0MPeKORE09gLBdArb5DK1OXCwn7HqL9S/2hqhI1k1cr0CCAhnKqasA12j1QVjJeMH6n3rKO1qNaEJ8gfXwTtFJghmMxzItgT6kVemoex/+LwSWhwFz4Az5aTvocpErKcSZyLh3qtRDHbkRcmEXnIZQOuIKA8t5+k7YfK9OfDJHqr2SrhaEpyoxDMCGESW2Ik0ABrWNvg2UaO7n9nWv+HDHsR+wq7b3N8mz3ZwU8niwiBPmrT/hUgtsHi4iGVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HVdbegJFSl8rsfpweAcvv1Cu15l2BVX230/QXDxZbls=; b=CGpRPJKh0EkF3gtd0Au1UGrq5YRYDrflexARo2lPQCHR+q4xQA79lyQZGhR7PetEKAOfYTAms7AwJX+dm15dhHBEA76OgO3VHtst50rnGXQZeP0pFbFIL+nCPJsXogyiOkxB+wXZvuIDZ/HP4jLhqYEpx7ELXrEdeH7UpaxUlMUrLrrt1zd+LG2eWNDfdrKzV1E33fu6RBK2fxlG+2Nk5eVxdaZx+g2jFEPZj/GDgzV1j2wMNXZxFTJxVXLrYmu3aeJBCv8SIJQ8TwgBDxGCjlBs2gDDsvHRvXYdLNZEtTThp2RjKUS9ZZtsNHZi0JXkjxb6b1YeYObPqlcjgGePcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HVdbegJFSl8rsfpweAcvv1Cu15l2BVX230/QXDxZbls=; b=gKyhYiHXz6E3gh7jEL4rCEO24fH1nuTE0QmPorpEHbrqgyQMqyRtBgegsyigI6rVGcX0Hg6r8KayzCuDObcDqPGeNC67SWWzyB9Dk9xikEyQljgof36TdWjEfP0INXOHOaAM6pnuKGtKXyTTGJ4Iu4/j3fpKTTCdA42r1YmqnC4= From: Bertrand Marquis To: Michal Orzel CC: "xen-devel@lists.xenproject.org" , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v4 1/3] automation: Create Yocto docker images Thread-Topic: [PATCH v4 1/3] automation: Create Yocto docker images Thread-Index: AQHY+mjC+0nxqx9t9k+ZuMYOtPDJka5EYYoAgAAv0YCAAALGAIAAFL0A Date: Fri, 18 Nov 2022 13:08:27 +0000 Message-ID: <2CD8454F-DF03-40D3-AE4C-55FE9B184C2A@arm.com> References: <6d48a0f83324d2f42597d43c41ce72d6d80150e6.1668677493.git.bertrand.marquis@arm.com> <60ff35c3-0b3a-7c9f-edf5-0639056570d7@amd.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DB9PR08MB6714:EE_|AM7EUR03FT012:EE_|PR3PR08MB5563:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b7d1d23-4b88-4362-7e4b-08dac9660260 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 15EuIvEUxKuC4ilEf7rU9S2LHkClNWPKKbnLMrPp8a344bM6icANZD29HpISw6Zq5VeQMg4OIa9O7G+32CUW/BR30TlyMoOo3xnyu010iMK1lQsJwUW7dlFMrXYwU5M1WySNzLhqb2kAwcyk2P5XEInYOyyEZaYJBXl2ybaeG+/ffr72H6rLiga6OZv+yNGVNQsAIoeQMqmegQNvOP3nGW97ufKmwKj9wQZI/F+sn7917jc3H7zqNjaBAUt7kSKnnrP85ClldOHWbyiFGEyM3Sl1QfQWw6poMpeRZG3/nz3ElVegsQ/diAt03yMWp8tBlAqWcK94/tun9Ml1e+wsRsGuDT9bmV8oNWVt/FP9Z2SXr4wnyYAzeLaYZ9CMO+1S+H7WB7gRclrf6KC2oKlt77B258124MBfp9FMrn/iOujgnKFgWDqRSB4ee5aaWwD18zeLW19WKxw0W/OMTW9JUHJTfP+ZfXaCz0FMQYcl+7XZ24zaE2h16+IDSG8UfbwjTVOuCgHjrIGp6SwQZesm8clh6tBlGSGDnvNGxFagX/vmEUz+r6SFEEQMJREBfP/AwlFQIqJ13Xl6r2H9o6VHcd3OkX9dag3QhNakSLcwhECzmHiyl8XqFB8qi4Ded20rRL6j+7RS2Ye/E1ZOIY1zV5zn/Z/T0cbh9nMDdWAFeYki3knVIvqw0DsCLfrPqw9SLBjIPSjl8uZIP8zq8UhRFsRSNeLo9R/pv4WbDfVimNvOoA1DT8UvDyxki3RojqvAmCU8wOIVcwFAn0IzjKTcBXPnEfO5ss9phOaegGbCIGs= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(346002)(396003)(366004)(451199015)(122000001)(38100700002)(41300700001)(84970400001)(66476007)(33656002)(66446008)(36756003)(76116006)(66946007)(5660300002)(8936002)(64756008)(86362001)(8676002)(30864003)(66556008)(4326008)(26005)(91956017)(2906002)(54906003)(38070700005)(6916009)(316002)(6506007)(6512007)(478600001)(966005)(53546011)(45080400002)(83380400001)(6486002)(2616005)(71200400001)(186003)(45980500001)(559001)(579004);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <081EBDC8AF37C240AE31C4ECB6C1C256@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6714 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d803d39d-50df-4658-009b-08dac965fb67 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 16GZzuZ+eiQcpTz8MCIHyIYeaNGZEzDFD07Tb3f5RbjXu5O599jdAQuQFXPA4aL7tL+up1Pqxq/pCbFnCVl7ZMobjEDwHiqZhh1xpwxBmeEmWWaCuuoGuR4bJ2E2KrR+mA54OLPJPDlz+JxK+oSfbyMP479ae5GQUG/Q0/+tVL+AIJO/zPW14Rx5OWtUCNrXUk4xZggf2Ip39jqAubnUtffmIR5EQqWFKPEZhNZU5Ngybzh38r3Wb1ocxrXG6IVX3NMN7boZ5He/vj+gcZpMIWs24eUZzm76UYwF63QRu69ELEVCbpI0+u7UGH3/KAz9ilpuXwJpdCiDgmtmCBOr+cObo04zHm/XbnbDie/Me90n6YbgfsPOKQZW4a16P66FBPB9Q13+9Kp3/IVt09+Illd/kEPBg5kads0HplalHNc1nNRlBO8wSBtOsVgg0IcMXbhpVxT+yrk5qlXhO138mC/JSqvE2Qw0/9LF6SabEs3H7S3c0eVRWjkKsNk1T3lLSXrEhd3InTIAV/reE7ZWCsNZwlmniSoT8D3uhSXllKEnz6SrKBgnCISelQO6wWp45sSPOXVCdGWR7DsdPWE/deDoOVvPMgdbWVbzJ5AtoXReaLzVje727bPvQABVrNDPdGH2iKd2iH2TGaY4CaipHn75iWHqUjG8u1aIFmZMyytxCEUKsN56APDqjuJUmgnCohBoUzLGUshhL5BBqb9WJOmXbyevvwtNSQJ9TlLmujsukcMGm9NtsF27u42SpuUIV1/pPUickIl4g0BpyXKA9w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199015)(40470700004)(36840700001)(46966006)(6506007)(83380400001)(33656002)(26005)(966005)(70206006)(2906002)(41300700001)(86362001)(84970400001)(54906003)(30864003)(6512007)(47076005)(45080400002)(478600001)(36860700001)(5660300002)(186003)(4326008)(8936002)(356005)(2616005)(6862004)(40460700003)(8676002)(70586007)(316002)(336012)(81166007)(82740400003)(6486002)(40480700001)(82310400005)(53546011)(107886003)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 13:08:38.9290 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7b7d1d23-4b88-4362-7e4b-08dac9660260 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5563 SGksDQoNCj4gT24gMTggTm92IDIwMjIsIGF0IDExOjU0LCBNaWNoYWwgT3J6ZWwgPG1pY2hhbC5v cnplbEBhbWQuY29tPiB3cm90ZToNCj4gDQo+IEhpIEJlcnRyYW5kLA0KPiANCj4gT24gMTgvMTEv MjAyMiAxMjo0NCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+IA0KPj4gDQo+PiBIaSBNaWNo YWwsDQo+PiANCj4+PiBPbiAxOCBOb3YgMjAyMiwgYXQgMDg6NTMsIE1pY2hhbCBPcnplbCA8bWlj aGFsLm9yemVsQGFtZC5jb20+IHdyb3RlOg0KPj4+IA0KPj4+IEhpIEJlcnRyYW5kLA0KPj4+IA0K Pj4+IEp1c3QsIHNvbWUgbWlub3IgY29tbWVudHMuDQo+Pj4gDQo+Pj4gT24gMTcvMTEvMjAyMiAx MDozOSwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4gDQo+Pj4+IA0KPj4+PiBBZGQgY29u dGFpbmVycyBzdWl0YWJsZSB0byBydW4geW9jdG8ga2lya3N0b25lIGJ1aWxkIGJhc2VkIG9uIHVi dW50dQ0KPj4+PiAyMi4wNC4gSXQgY29udGFpbnMgYWxsIHBhY2thZ2VzIHJlcXVpcmVkIGJ5IFlv Y3RvIGFuZCBhIGNoZWNrb3V0IG9mIHRoZQ0KPj4+PiBsYXllcnMgcmVxdWlyZWQgdG8gYnVpbGQg WGVuIHdpdGggWW9jdG8uDQo+Pj4+IA0KPj4+PiBBZGQgYSBnZW5lcmljIGRvY2tlciBpbWFnZSB0 ZW1wbGF0ZSB0byBiZSB1c2VkIHRvIGF1dG9tYXRpY2FsbHkgZ2VuZXJhdGUNCj4+Pj4gZG9ja2Vy IGZpbGVzIGZvciBkaWZmZXJlbnQgY29uZmlndXJhdGlvbnM6DQo+Pj4+IC0gc3BlY2lmaWMgeW9j dG8gdmVyc2lvbg0KPj4+PiAtIGRpZmZlcmVudCB0YXJnZXRzIChxZW11IGFybSwgYXJtNjQgYW5k IHg4NikNCj4+Pj4gLSBkaWZmZXJlbnQgaG9zdCBwbGF0Zm9ybXMgKHg4NiBvciBhcm02NCkNCj4+ Pj4gDQo+Pj4+IER1cmluZyBhIGNhbGwgdG8gJ21ha2UgYWxsJywgb25seSB0aGUgaW1hZ2VzIGZv ciB0aGUgY3VycmVudCBob3N0DQo+Pj4+IHBsYXRmb3JtIHdpbGwgYmUgZ2VuZXJhdGVkLg0KPj4+ IFRoaXMgbG9va3MgbGlrZSBhIHN0YWxlIGNvbW1lbnQuIFRoZSByZWFzb24gYmVpbmcsIGluIHRo ZSBuZXcgdmVyc2lvbiwgYnkgZGVmYXVsdA0KPj4+IHdlIGJ1aWxkIHRoZSBpbWFnZXMgZm9yIHRo ZSBhcmNoaXRlY3R1cmVzIGV4cGVjdGVkIGJ5IHRoZSBDSSBhbmQgaXRzIHJ1bm5lcnMNCj4+PiB0 byBtYXRjaCB0aGUgY3VycmVudCB3b3JrZmxvdy4NCj4+IA0KPj4gUmlnaHQgSSB3aWxsIGZpeCB0 aGUgY29tbWl0IG1lc3NhZ2UuDQo+PiANCj4+PiANCj4+Pj4gSWYgbmVlZGVkLCBpbWFnZXMgZm9y IGFuIG90aGVyIGhvc3QgcGxhdGZvcm0gY2FuIGJlIGdlbmVyYXRlZCBtYW51YWxseQ0KPj4+PiBi eSBjYWxsaW5nIHRoZSByaWdodCBtYWtlIHRhcmdldCAoc2VlIG1ha2UgaGVscCkuDQo+Pj4+IA0K Pj4+PiBBZGQgYSBidWlsZCBzY3JpcHQgdG8gYnVpbGQgYW5kIHJ1biB4ZW4gb24gcWVtdSB1c2lu ZyBZb2N0by4NCj4+Pj4gVGhlIHNjcmlwdCBzdXBwb3J0cyBhcm0zMiwgYXJtNjQgYW5kIHg4Nl82 NCBhbmQgY2hlY2tzIHRoYXQgZG9tMCBpcw0KPj4+PiBwcm9wZXJseSBib290aW5nLiBBdCB0aGlz IHN0YWdlIHRoaXMgZG9lcyBub3QgcnVuIGFueSBndWVzdCBvbiB0b3Agb2YNCj4+Pj4gZG9tMC4g VGhlIHNjcmlwdCBpcyB0byBiZSBleGVjdXRlZCBpbiBvbmUgb2YgdGhlIGRvY2tlciBpbWFnZXMg dG8gYnVpbGQNCj4+Pj4gYW5kIHJ1biBhIHN5c3RlbSB1c2luZyBhIFhlbiBzb3VyY2UgdHJlZS4N Cj4+Pj4gDQo+Pj4+IFNpZ25lZC1vZmYtYnk6IEJlcnRyYW5kIE1hcnF1aXMgPGJlcnRyYW5kLm1h cnF1aXNAYXJtLmNvbT4NCj4+Pj4gLS0tDQo+Pj4+IENoYW5nZXMgaW4gdjQ6DQo+Pj4+IC0gUmV3 b3JrIHRoZSBzeXN0ZW0gdG8gaGF2ZSBvbmUgZG9ja2VyZmlsZSB0ZW1wbGF0ZSBmcm9tIHdoaWNo IG1ha2Ugd2lsbA0KPj4+PiBnZW5lcmF0ZSB0aGUgcmVxdWlyZWQgZG9ja2VyZmlsZXMgZm9yIHRo ZSB3YW50ZWQgY29uZmlndXJhdGlvbg0KPj4+IFRoYXQgaXMgZ3JlYXQuDQo+PiANCj4+IFRoYW5r cyA6LSkNCj4+PiANCj4+Pj4gLSBhZGQgc3VwcG9ydCBmb3IgZGlmZmVyZW50IGhvc3QgYXJjaGl0 ZWN0dXJlcw0KPj4+PiAtIE1lcmdlIHRoZSBnZW5lcmF0aW9uIHN5c3RlbSBpbnRvIG9uZSBzaW5n bGUgZG9ja2VyZmlsZQ0KPj4+PiAtIE1lcmdlIHBhdGNoZXMgMSBhbmQgMiBpbiBhIHNpbmdsZSBw YXRjaA0KPj4+PiAtIEludHJvZHVjZSBDT05UQUlORVJTX0VYVFJBIHRvIGhhdmUgZXh0cmEgY29u dGFpbmVycyBub3QgYnVpbHQgYnkNCj4+Pj4gZGVmYXVsdCAoZm9yIHRob3NlIG5vdCB1c2VkIGJ5 IENJIGJ1dCB1c2VmdWwgdG8gdXNlcnMpDQo+Pj4+IENoYW5nZXMgaW4gdjM6DQo+Pj4+IC0gbGlt aXQgbnVtYmVyIG9mIGpvYnMgaW4geW9jdG8gYnkgZGVmYXVsdCB0byA4IGFuZCBhZGQgLS1udW0t am9icw0KPj4+PiBvcHRpb24gdG8gdGhlIHNjcmlwdCB0byBzZXQgYSBjdXN0b20gbnVtYmVyIG9m IGpvYnMNCj4+Pj4gLSBkbyBub3QgY29weSBhbnltb3JlIHRoZSBidWlsZC15b2N0by5zaCBzY3Jp cHQgaW5zaWRlIHRoZSBtYWluIGltYWdlIHNvDQo+Pj4+IHRoYXQgdGhlIGN1cnJlbnQgb25lIGlu IHRoZSByZXBvc2l0b3J5IGlzIHVzZWQgd2hlbiBydW5uaW5nDQo+Pj4+IENoYW5nZXMgaW4gdjI6 DQo+Pj4+IC0gYWRkIGEgLS1kdW1wLWxvZyBjb21tYW5kIGxpbmUgb3B0aW9uIHRvIGJ1aWxkLXlv Y3RvLnNoIHNjcmlwdCB0byBkdW1wDQo+Pj4+IHRoZSBsb2dzIGlmIGFuIGVycm9yIG9jY3Vycy4N Cj4+Pj4gQ2hhbmdlcyBpbiB2MToNCj4+Pj4gLSBhZGQgLS1pbWFnZSBjb21tYW5kIGxpbmUgYXJn dW1lbnQgdG8gYnVpbGQteW9jdG8uc2ggdG8gYWxsb3cgYnVpbGRpbmcNCj4+Pj4gc29tZXRoaW5n IGRpZmZlcmVudCB0aGFuIHhlbi1pbWFnZS1taW5pbWFsLg0KPj4+PiAtIG1vZGlmeSBkb2NrZXJm aWxlIHRvIGhhdmUgb25lIGxheWVyIHBlciBsaW5lIGFuZCBtYWtlIGl0IGVhc2llciB0byBhZGQN Cj4+Pj4gb3RoZXIuIEkga2VwdCB0aGUgZm9yIGxvb3AgdG8ga2VlcCB0aGUgbnVtYmVyIG9mIGRv Y2tlciBzdGVwcyBsb3dlcg0KPj4+PiAtIHVwZGF0ZSBjb21taXQgbWVzc2FnZSB0byB3YXJuIHRo YXQgbm8gZ3Vlc3QgYXJlIHRlc3RlZC4NCj4+Pj4gLSBmaXggYnVpbGQteW9jdG8gc2NyaXB0IHRv IHByb3Blcmx5IHJldHVybiB3aXRoIGFuIGVycm9yIGlmIGV4cGVjdA0KPj4+PiBzY3JpcHQgZW5k cyB1cCBpbiB0aW1lb3V0IG9yIEVPRi4NCj4+Pj4gLS0tDQo+Pj4+IGF1dG9tYXRpb24vYnVpbGQv TWFrZWZpbGUgICAgICAgICAgICAgICAgICB8ICAxNCArLQ0KPj4+PiBhdXRvbWF0aW9uL2J1aWxk L3lvY3RvL2J1aWxkLXlvY3RvLnNoICAgICAgfCAzNDkgKysrKysrKysrKysrKysrKysrKysrDQo+ Pj4+IGF1dG9tYXRpb24vYnVpbGQveW9jdG8veW9jdG8uZG9ja2VyZmlsZS5pbiB8IDExNCArKysr KysrDQo+Pj4+IGF1dG9tYXRpb24vYnVpbGQveW9jdG8veW9jdG8uaW5jICAgICAgICAgICB8ICA0 MSArKysNCj4+Pj4gNCBmaWxlcyBjaGFuZ2VkLCA1MTYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkNCj4+Pj4gY3JlYXRlIG1vZGUgMTAwNzU1IGF1dG9tYXRpb24vYnVpbGQveW9jdG8vYnVp bGQteW9jdG8uc2gNCj4+Pj4gY3JlYXRlIG1vZGUgMTAwNjQ0IGF1dG9tYXRpb24vYnVpbGQveW9j dG8veW9jdG8uZG9ja2VyZmlsZS5pbg0KPj4+PiBjcmVhdGUgbW9kZSAxMDA2NDQgYXV0b21hdGlv bi9idWlsZC95b2N0by95b2N0by5pbmMNCj4+Pj4gDQo+Pj4+IGRpZmYgLS1naXQgYS9hdXRvbWF0 aW9uL2J1aWxkL01ha2VmaWxlIGIvYXV0b21hdGlvbi9idWlsZC9NYWtlZmlsZQ0KPj4+PiBpbmRl eCBhNGIyYjg1MTc4Y2YuLjcyYTUzMzViYWVjMSAxMDA2NDQNCj4+Pj4gLS0tIGEvYXV0b21hdGlv bi9idWlsZC9NYWtlZmlsZQ0KPj4+PiArKysgYi9hdXRvbWF0aW9uL2J1aWxkL01ha2VmaWxlDQo+ Pj4+IEBAIC0xLDEzICsxLDE4IEBADQo+Pj4+IA0KPj4+PiAjIHRoZSBiYXNlIG9mIHdoZXJlIHRo ZXNlIGNvbnRhaW5lcnMgd2lsbCBhcHBlYXINCj4+Pj4gUkVHSVNUUlkgOj0gcmVnaXN0cnkuZ2l0 bGFiLmNvbS94ZW4tcHJvamVjdC94ZW4NCj4+Pj4gLUNPTlRBSU5FUlMgPSAkKHN1YnN0IC5kb2Nr ZXJmaWxlLCwkKHdpbGRjYXJkICovKi5kb2NrZXJmaWxlKSkNCj4+Pj4gK0NPTlRBSU5FUlMgPSAk KGZpbHRlci1vdXQgeW9jdG8vJSwkKHN1YnN0IC5kb2NrZXJmaWxlLCwkKHdpbGRjYXJkICovKi5k b2NrZXJmaWxlKSkpDQo+Pj4+ICtDT05UQUlORVJTX0VYVFJBID0NCj4+Pj4gRE9DS0VSX0NNRCA/ PSBkb2NrZXINCj4+Pj4gDQo+Pj4+ICtpbmNsdWRlIHlvY3RvL3lvY3RvLmluYw0KPj4+PiArDQo+ Pj4+IGhlbHA6DQo+Pj4+ICAgICAgIEBlY2hvICJCdWlsZHMgY29udGFpbmVycyBmb3IgYnVpbGRp bmcgWGVuIGJhc2VkIG9uIGRpZmZlcmVudCBkaXN0cm9zIg0KPj4+PiAgICAgICBAZWNobyAiVG8g YnVpbGQgb25lIHJ1biAnbWFrZSBESVNUUk8vVkVSU0lPTicuIEF2YWlsYWJsZSBjb250YWluZXJz OiINCj4+Pj4gICAgICAgQCQoZm9yZWFjaCBmaWxlLCQoc29ydCAkKENPTlRBSU5FUlMpKSxlY2hv ICR7ZmlsZX07KQ0KPj4+PiArICAgICAgIEBlY2hvICJFeHRyYSBjb250YWluZXJzIChub3QgYnVp bHQgdXNpbmcgbWFrZSBhbGwpOiINCj4+Pj4gKyAgICAgICBAJChmb3JlYWNoIGZpbGUsJChzb3J0 ICQoQ09OVEFJTkVSU19FWFRSQSkpLGVjaG8gJHtmaWxlfTspDQo+Pj4+ICAgICAgIEBlY2hvICJU byBwdXNoIGNvbnRhaW5lciBidWlsZHMsIHNldCB0aGUgZW52IHZhciBQVVNIIg0KPj4+PiANCj4+ Pj4gJTogJS5kb2NrZXJmaWxlICMjIEJ1aWxkcyBjb250YWluZXJzDQo+Pj4+IEBAIC0xNiw1ICsy MSwxMCBAQCBoZWxwOg0KPj4+PiAgICAgICAgICAgICAgICQoRE9DS0VSX0NNRCkgcHVzaCAkKFJF R0lTVFJZKS8kKEBEKTokKEBGKTsgXA0KPj4+PiAgICAgICBmaQ0KPj4+PiANCj4+Pj4gLS5QSE9O WTogYWxsDQo+Pj4+ICsuUEhPTlk6IGFsbCBjbGVhbg0KPj4+PiBhbGw6ICQoQ09OVEFJTkVSUykN Cj4+Pj4gKw0KPj4+PiArIyBSZW1vdmUgZ2VuZXJhdGVkIGRvY2tlcmZpbGVzIGZvciB5b2N0bw0K Pj4+PiArY2xlYW46DQo+Pj4+ICsgICAgICAgcm0gLWYgeW9jdG8vKi5kb2NrZXJmaWxlcw0KPj4+ IEFyZSB0aGVzZSBmaWxlcyBuZWVkZWQgYWZ0ZXIgbWFrZSBpcyBjb21wbGV0ZWQ/DQo+Pj4gSWYg bm90LCBtYXliZSB0byBhdm9pZCBoYXZpbmcgc29tZSB1bnRyYWNrZWQgZmlsZXMgaW4gdGhlIHRy ZWUsIHRoZXkgY291bGQgYmUgcmVtb3ZlZCBhZnRlciBtYWtlIGlzIGRvbmU/DQo+PiANCj4+IEkg ZG8gbm90IGFncmVlIGhlcmUsIG9uIG1pZ2h0IHdhbnQgdG8gaW5zcGVjdCB0aG9zZSBmaWxlcyB0 byBjaGVjay4NCj4+IENsZWFuaW5nIGR1cmluZyBtYWtlIGNsZWFuIGlzIG1vcmUgc3RhbmRhcmQu DQo+PiANCj4+IEFsc28gdGhvc2UgYXJlIGludGVybWVkaWF0ZSBmaWxlcyBzbyBtYWtlIHNob3Vs ZC9jb3VsZCBjbGVhbiB0aGVtIGF1dG9tYXRpY2FsbHkuDQo+PiBJIHdpbGwgbWFrZSBhIHRyeSB0 byBmbGFnIHRoZW0gaW50ZXJtZWRpYXRlIGlmIG5vdCBoYW5kbGVkIGF1dG9tYXRpY2FsbHkgYWxy ZWFkeSBidXQgSSB3aWxsIHN0aWxsIGtlZXAgdGhpcyBoZXJlLg0KPj4gDQo+IEl0IGlzIG9rIGZv ciBtZS4gSSBqdXN0IHJhaXNlZCBhIGNvbmNlcm4gOikNCj4gDQo+Pj4gDQo+Pj4+ICsNCj4+Pj4g ZGlmZiAtLWdpdCBhL2F1dG9tYXRpb24vYnVpbGQveW9jdG8vYnVpbGQteW9jdG8uc2ggYi9hdXRv bWF0aW9uL2J1aWxkL3lvY3RvL2J1aWxkLXlvY3RvLnNoDQo+Pj4+IG5ldyBmaWxlIG1vZGUgMTAw NzU1DQo+Pj4+IGluZGV4IDAwMDAwMDAwMDAwMC4uZDBjOTNkZmFmZmUwDQo+Pj4+IC0tLSAvZGV2 L251bGwNCj4+Pj4gKysrIGIvYXV0b21hdGlvbi9idWlsZC95b2N0by9idWlsZC15b2N0by5zaA0K Pj4+PiBAQCAtMCwwICsxLDM0OSBAQA0KPj4+PiArIyEvYmluL2Jhc2gNCj4+Pj4gKyMNCj4+Pj4g KyMgWW9jdG8gbWV0YSB2aXJ0dWFsaXphdGlvbiBidWlsZCBhbmQgcnVuIHNjcmlwdA0KPj4+PiAr Iw0KPj4+PiArIyBUaGlzIHNjcmlwdCBpcyBidWlsZGluZyBZb2N0byB4ZW4taW1hZ2UtbWluaW1h bCBmb3IgcWVtdSB0YXJnZXRzIGFuZCBydW4NCj4+Pj4gKyMgdGhlbSB1c2luZyBydW5xZW11IGlu c2lkZSB5b2N0byB0byBjaGVjayB0aGF0IGRvbTAgaXMgYm9vdGluZyBwcm9wZXJseQ0KPj4+IE1p c3NpbmcgZG90IGF0IHRoZSBlbmQgb2YgYSBzZW50ZW5jZS4NCj4+IA0KPj4gV2lsbCBmaXgNCj4+ IA0KPj4+IA0KPj4+PiArIyBUaGUgYnVpbGQgaXMgdXNpbmcgYSBsb2NhbCB4ZW4gc291cmNlIHRy ZWUgc28gdGhhdCBzcGVjaWZpYyBwYXRjaGVzIGNhbiBiZQ0KPj4+PiArIyB0ZXN0ZWQuDQo+Pj4+ ICsjIEluIG9yZGVyIHRvIG9wdGltaXplIHRoZSBidWlsZCB0aW1lLCBhIGJ1aWxkIGNhY2hlIGlz IHVzZWQgc28gdGhhdCBvbmx5IHhlbg0KPj4+PiArIyBwYWNrYWdlcyBhbmQgaXRzIGRlcGVuZGVu Y2llcyBhcmUgcmVidWlsdCAocWVtdSBhbmQgZmluYWwgaW1hZ2UgbWFpbmx5KS4NCj4+Pj4gKyMN Cj4+Pj4gKw0KPj4+PiArIyBEaXJlY3Rvcmllcw0KPj4+PiArWU9DVE9ESVI9IiRIT01FL3lvY3Rv LWxheWVycyINCj4+Pj4gK0NBQ0hFRElSPSIkSE9NRS95b2N0by1jYWNoZSINCj4+Pj4gK0xPR0RJ Uj0iJEhPTUUvbG9ncyINCj4+Pj4gK1hFTkRJUj0iJEhPTUUveGVuIg0KPj4+PiArQlVJTERESVI9 IiRIT01FL2J1aWxkIg0KPj4+PiArDQo+Pj4+ICsjIHdoYXQgeW9jdG8gYnNwIHdlIHN1cHBvcnQN Cj4+Pj4gK1RBUkdFVF9TVVBQT1JURUQ9InFlbXVhcm0gcWVtdWFybTY0IHFlbXV4ODYtNjQiDQo+ Pj4+ICtWRVJCT1NFPSJuIg0KPj4+PiArVEFSR0VUTElTVD0iIg0KPj4+PiArQlVJTERKT0JTPSI4 Ig0KPj4+PiArDQo+Pj4+ICsjIGFjdGlvbnMgdG8gZG8NCj4+Pj4gK2RvX2NsZWFuPSJuIg0KPj4+ PiArZG9fYnVpbGQ9InkiDQo+Pj4+ICtkb19ydW49InkiDQo+Pj4+ICtkb19sb2NhbHNyYz0ibiIN Cj4+Pj4gK2RvX2R1bXA9Im4iDQo+Pj4+ICtidWlsZF9yZXN1bHQ9MA0KPj4+PiArDQo+Pj4+ICsj IGxheWVycyB0byBpbmNsdWRlIGluIHRoZSBwcm9qZWN0DQo+Pj4+ICtidWlsZF9sYXllcmxpc3Q9 InBva3kvbWV0YSBwb2t5L21ldGEtcG9reSBwb2t5L21ldGEteW9jdG8tYnNwIFwNCj4+Pj4gKyAg ICAgICAgICAgICAgICAgbWV0YS1vcGVuZW1iZWRkZWQvbWV0YS1vZSBtZXRhLW9wZW5lbWJlZGRl ZC9tZXRhLXB5dGhvbiBcDQo+Pj4+ICsgICAgICAgICAgICAgICAgIG1ldGEtb3BlbmVtYmVkZGVk L21ldGEtZmlsZXN5c3RlbXMgXA0KPj4+PiArICAgICAgICAgICAgICAgICBtZXRhLW9wZW5lbWJl ZGRlZC9tZXRhLW5ldHdvcmtpbmcgbWV0YS12aXJ0dWFsaXphdGlvbiINCj4+Pj4gKw0KPj4+PiAr IyB5b2N0byBpbWFnZSB0byBidWlsZA0KPj4+PiArYnVpbGRfaW1hZ2U9Inhlbi1pbWFnZS1taW5p bWFsIg0KPj4+PiArDQo+Pj4+ICtmdW5jdGlvbiBwcmludF9wcm9ncmVzcygpIHsNCj4+Pj4gKyAg ICBlY2hvIC1uICIkKGRhdGUgKyVUKSAkKiINCj4+Pj4gK30NCj4+Pj4gKw0KPj4+PiArZnVuY3Rp b24gcnVuX3Rhc2soKSB7DQo+Pj4+ICsgICAgbG9jYWwgdGFza19uYW1lPSIkMSINCj4+Pj4gKyAg ICBsb2NhbCB0YXNrX3RhcmdldD0iJDIiDQo+Pj4+ICsNCj4+Pj4gKyAgICB0YXNrX2xvZz0iJHt0 YXNrX25hbWUvL3Byb2plY3RffS0ke3Rhc2tfdGFyZ2V0fSINCj4+Pj4gKw0KPj4+PiArICAgIG1r ZGlyIC1wICIke0xPR0RJUn0iDQo+Pj4+ICsgICAgcHJpbnRfcHJvZ3Jlc3MNCj4+Pj4gKyAgICBl Y2hvIC1uICIke3Rhc2tfbmFtZS8vcHJvamVjdF99ICR7dGFza190YXJnZXR9OiAiDQo+Pj4+ICsg ICAgaWYgWyAiJHtWRVJCT1NFfSIgPSAibiIgXTsgdGhlbg0KPj4+PiArICAgICAgICAkQCA+ICIk e0xPR0RJUn0vJHt0YXNrX2xvZ30ubG9nIiAyPiYxDQo+Pj4+ICsgICAgZWxzZQ0KPj4+PiArICAg ICAgICAkQCAyPiYxIHwgdGVlICIke0xPR0RJUn0vJHt0YXNrX2xvZ30ubG9nIg0KPj4+PiArICAg IGZpDQo+Pj4+ICsNCj4+Pj4gKyAgICBpZiBbICR7P30gLW5lIDAgXTsgdGhlbg0KPj4+PiArICAg ICAgICBlY2hvICJFcnJvciINCj4+Pj4gKyAgICAgICAgYnVpbGRfcmVzdWx0PSQoKGJ1aWxkX3Jl c3VsdCsxKSkNCj4+Pj4gKyAgICAgICAgaWYgWyAiJHtkb19kdW1wfSIgPSAieSIgXTsgdGhlbg0K Pj4+PiArICAgICAgICAgICAgZWNobw0KPj4+PiArICAgICAgICAgICAgZWNobyAiIyMjIyMjIyMj IyMjIExPR1MtU1RBUlQgIyMjIyMjIyMjIyMjIg0KPj4+PiArICAgICAgICAgICAgY2F0ICIke0xP R0RJUn0vJHt0YXNrX2xvZ30ubG9nIg0KPj4+PiArICAgICAgICAgICAgZWNobyAiIyMjIyMjIyMj IyMjICBMT0dTLUVORCAgIyMjIyMjIyMjIyMjIg0KPj4+PiArICAgICAgICAgICAgZWNobw0KPj4+ PiArICAgICAgICBmaQ0KPj4+PiArICAgICAgICByZXR1cm4gMQ0KPj4+PiArICAgIGVsc2UNCj4+ Pj4gKyAgICAgICAgZWNobyAiT0siDQo+Pj4+ICsgICAgICAgIHJldHVybiAwDQo+Pj4+ICsgICAg ZmkNCj4+Pj4gK30NCj4+Pj4gKw0KPj4+PiArZnVuY3Rpb24gcHJvamVjdF9jcmVhdGUoKSB7DQo+ Pj4+ICsgICAgdGFyZ2V0PSIkezE6P30iDQo+Pj4+ICsgICAgZGVzdGRpcj0iJHtCVUlMRERJUn0v JHt0YXJnZXR9Ig0KPj4+PiArDQo+Pj4+ICsgICAgKA0KPj4+PiArICAgICAgICAjIGluaXQgeW9j dG8gcHJvamVjdA0KPj4+PiArICAgICAgICBzb3VyY2UgJHtZT0NUT0RJUn0vcG9reS9vZS1pbml0 LWJ1aWxkLWVudiAiJHtkZXN0ZGlyfSINCj4+Pj4gKw0KPj4+PiArICAgICAgICAjIGFkZCBuZWVk ZWQgbGF5ZXJzDQo+Pj4+ICsgICAgICAgIGZvciBsYXllciBpbiAke2J1aWxkX2xheWVybGlzdH07 IGRvDQo+Pj4+ICsgICAgICAgICAgICBiaXRiYWtlLWxheWVycyBhZGQtbGF5ZXIgJHtZT0NUT0RJ Un0vJHtsYXllcn0gfHwgZXhpdCAxDQo+Pj4+ICsgICAgICAgIGRvbmUNCj4+Pj4gKyAgICApIHx8 IHJldHVybiAxDQo+Pj4+ICsNCj4+Pj4gKyAgICAjIGN1c3RvbWl6ZSBwcm9qZWN0IGNvbmZpZ3Vy YXRpb24NCj4+Pj4gKyAgICBjYXQgPDxFT0YgPj4gIiR7ZGVzdGRpcn0vY29uZi9sb2NhbC5jb25m Ig0KPj4+PiArIyBZb2N0byBCU1ANCj4+Pj4gK01BQ0hJTkUgPSAiJHt0YXJnZXR9Ig0KPj4+PiAr DQo+Pj4+ICsjIFVzZSBsb2NhbCBjYWNoZSB0byByZXVzZSBwcmV2aW91cyBidWlsZHMgcmVzdWx0 cw0KPj4+PiArU1NUQVRFX0RJUiA9ICIke0NBQ0hFRElSfS9zc3RhdGUtY2FjaGUiDQo+Pj4+ICtE TF9ESVIgPSAiJHtDQUNIRURJUn0vZG93bmxvYWRzIg0KPj4+PiArDQo+Pj4+ICsjIEVuYWJsZSB4 ZW4gYW5kIHZpcnR1YWxpemF0aW9uDQo+Pj4+ICtESVNUUk9fRkVBVFVSRVMgPSAiIHZpcnR1YWxp emF0aW9uIHhlbiBpcHY0Ig0KPj4+PiArDQo+Pj4+ICsjIFNwZWVkIHVwIHJ1biBieSBub3QgZ2Vu ZXJhdGluZyBzc2ggaG9zdCBrZXlzDQo+Pj4+ICtJTUFHRV9JTlNUQUxMOmFwcGVuZDpwbi14ZW4t aW1hZ2UtbWluaW1hbCA9ICIgc3NoLXByZWdlbi1ob3N0a2V5cyINCj4+Pj4gKw0KPj4+PiArIyBT YXZlIHNvbWUgZGlzayBzcGFjZQ0KPj4+PiArSU5IRVJJVCArPSAicm1fd29yayINCj4+Pj4gKw0K Pj4+PiArIyBSZWR1Y2UgbnVtYmVyIG9mIGpvYnMNCj4+Pj4gK0JCX05VTUJFUl9USFJFQURTPSIk e0JVSUxESk9CU30iDQo+Pj4+ICsNCj4+Pj4gK0VPRg0KPj4+PiArDQo+Pj4+ICsgICAgaWYgWyAi JHtkb19sb2NhbHNyY30iID0gInkiIF07IHRoZW4NCj4+Pj4gKyAgICAgICAgWEVOVkVSUz0kKGdy ZXAgLWUgIl5YRU5fUkVMIiBcDQo+Pj4+ICsgICAgICAgICAgICAiJHtZT0NUT0RJUn0iL21ldGEt dmlydHVhbGl6YXRpb24vcmVjaXBlcy1leHRlbmRlZC94ZW4veGVuXyouYmIgXA0KPj4+PiArICAg ICAgICAgICAgMj4gL2Rldi9udWxsIHwgdHIgLWQgJyAnIHwgdHIgLWQgJz8nIHwgdHIgLWQgJyIn IFwNCj4+Pj4gKyAgICAgICAgICAgIHwgc2VkIC1lICJzLy4qPS8vIiB8IHNvcnQgLVYgfCB0YWls IC1uIDEpDQo+Pj4+ICsNCj4+Pj4gKyAgICAgICAgWEVOQkFTRT0kKGRpcm5hbWUgIiQocmVhbHBh dGggLW0gIiR7WEVORElSfSIpIikNCj4+Pj4gKyAgICAgICAgWEVOU1VCPSQoYmFzZW5hbWUgIiQo cmVhbHBhdGggLW0gIiR7WEVORElSfSIpIikNCj4+Pj4gKw0KPj4+PiArICAgICAgICBjYXQgPDxF T0YgPj4gIiR7ZGVzdGRpcn0vY29uZi9sb2NhbC5jb25mIg0KPj4+PiArIyBVc2UgbG9jYWwgc291 cmNlcyBmb3IgeGVuIGFuZCB4ZW4tdG9vbHMNCj4+Pj4gK0ZJTEVTRVhUUkFQQVRIUzpwcmVwZW5k OnBuLXhlbiA6PSAiJHtYRU5CQVNFfToiDQo+Pj4+ICtGSUxFU0VYVFJBUEFUSFM6cHJlcGVuZDpw bi14ZW4tdG9vbHMgOj0gIiR7WEVOQkFTRX06Ig0KPj4+PiArDQo+Pj4+ICtTUkNfVVJJOnBuLXhl biA9ICJmaWxlOi8vJHtYRU5TVUJ9LztzdWJkaXI9bG9jYWwteGVuLyINCj4+Pj4gK1NSQ19VUkk6 cG4teGVuLXRvb2xzID0gImZpbGU6Ly8ke1hFTlNVQn0vO3N1YmRpcj1sb2NhbC14ZW4vIg0KPj4+ PiArDQo+Pj4+ICtQUkVGRVJSRURfVkVSU0lPTjpwbi14ZW4gPSAiJHtYRU5WRVJTfSUiDQo+Pj4+ ICtQUkVGRVJSRURfVkVSU0lPTjpwbi14ZW4tdG9vbHMgPSAiJHtYRU5WRVJTfSUiDQo+Pj4+ICsN Cj4+Pj4gK1M6cG4teGVuID0gIlwke1dPUktESVJ9L2xvY2FsLXhlbi8ke1hFTlNVQn0iDQo+Pj4+ ICtTOnBuLXhlbi10b29scyA9ICJcJHtXT1JLRElSfS9sb2NhbC14ZW4vJHtYRU5TVUJ9Ig0KPj4+ PiArDQo+Pj4+ICtTUkNSRVY6cG4teGVuID0gIlwke0FVVE9SRVZ9Ig0KPj4+PiArU1JDUkVWOnBu LXhlbi10b29scyA9ICJcJHtBVVRPUkVWfSINCj4+Pj4gKw0KPj4+PiArU1JDUFY6cG4teGVuID0g IjEiDQo+Pj4+ICtTUkNQVjpwbi14ZW4tdG9vbHMgPSAiMSINCj4+Pj4gKw0KPj4+PiArIyBEaXNh YmxlIGFsbCBRQSBlcnJvcnMgYXMgdGhlIHJlY2lwZSBpcyBub3QgdXAgdG8gZGF0ZSB3aXRoIGNo YW5nZXMgaW4gWGVuDQo+Pj4+ICsjIHdoZW4gd2UgdXNlIGxvY2FsIHNvdXJjZXMNCj4+Pj4gK0VS Uk9SX1FBOnBuLXhlbiA9ICJhcmNoIg0KPj4+PiArRVJST1JfUUE6cG4teGVuLXRvb2xzID0gImFy Y2giDQo+Pj4+ICsNCj4+Pj4gK0VPRg0KPj4+PiArICAgIGZpDQo+Pj4+ICt9DQo+Pj4+ICsNCj4+ Pj4gK2Z1bmN0aW9uIHByb2plY3RfYnVpbGQoKSB7DQo+Pj4+ICsgICAgdGFyZ2V0PSIkezE6P30i DQo+Pj4+ICsgICAgZGVzdGRpcj0iJHtCVUlMRERJUn0vJHt0YXJnZXR9Ig0KPj4+PiArDQo+Pj4+ ICsgICAgKA0KPj4+PiArICAgICAgICBzb3VyY2UgJHtZT0NUT0RJUn0vcG9reS9vZS1pbml0LWJ1 aWxkLWVudiAiJHtkZXN0ZGlyfSINCj4+Pj4gKw0KPj4+PiArICAgICAgICBiaXRiYWtlICIke2J1 aWxkX2ltYWdlfSIgfHwgZXhpdCAxDQo+Pj4+ICsgICAgKSB8fCByZXR1cm4gMQ0KPj4+PiArfQ0K Pj4+PiArDQo+Pj4+ICtmdW5jdGlvbiBwcm9qZWN0X2NsZWFuKCkgew0KPj4+PiArICAgIHRhcmdl dD0iJHsxOj99Ig0KPj4+PiArICAgIGRlc3RkaXI9IiR7QlVJTERESVJ9LyR7dGFyZ2V0fSINCj4+ Pj4gKw0KPj4+PiArICAgIHJtIC1yZiAiJHtkZXN0ZGlyfSINCj4+Pj4gK30NCj4+Pj4gKw0KPj4+ PiArZnVuY3Rpb24gcHJvamVjdF9ydW4oKSB7DQo+Pj4+ICsgICAgdGFyZ2V0PSIkezE6P30iDQo+ Pj4+ICsgICAgZGVzdGRpcj0iJHtCVUlMRERJUn0vJHt0YXJnZXR9Ig0KPj4+PiArICAgICgNCj4+ Pj4gKyAgICAgICAgc291cmNlICR7WU9DVE9ESVJ9L3Bva3kvb2UtaW5pdC1idWlsZC1lbnYgIiR7 ZGVzdGRpcn0iID4gL2Rldi9udWxsIDI+JjENCj4+Pj4gKw0KPj4+PiArICAgICAgICAvdXNyL2Jp bi9leHBlY3QgPDxFT0YNCj4+Pj4gK3NldCB0aW1lb3V0IDEwMA0KPj4+PiArc3Bhd24gYmFzaCAt YyAicnVucWVtdSBzZXJpYWxzdGRpbyBub2dyYXBoaWMgc2xpcnAiDQo+Pj4+ICsNCj4+Pj4gK2V4 cGVjdF9hZnRlciB7DQo+Pj4+ICsgICAgLXJlICIoLiopXHIiIHsNCj4+Pj4gKyAgICAgICAgZXhw X2NvbnRpbnVlDQo+Pj4+ICsgICAgfQ0KPj4+PiArICAgIHRpbWVvdXQge3NlbmRfdXNlciAiRVJS T1ItVGltZW91dCFcbiI7IGV4aXQgMX0NCj4+Pj4gKyAgICBlb2Yge3NlbmRfdXNlciAiRVJST1It RU9GIVxuIjsgZXhpdCAxfQ0KPj4+PiArfQ0KPj4+PiArDQo+Pj4+ICsjIHdhaXQgaW5pdGlhbCBs b2dpbg0KPj4+PiArZXhwZWN0IC1yZSAiLiogbG9naW46ICINCj4+Pj4gK3NlbmQgInJvb3RcciIN Cj4+Pj4gK2V4cGVjdCAtcmUgInJvb3RALiojICINCj4+Pj4gKw0KPj4+PiArRU9GDQo+Pj4+ICsg ICAgZXhpdCAkPw0KPj4+PiArICAgICkgfHwgcmV0dXJuIDENCj4+Pj4gK30NCj4+Pj4gKw0KPj4+ PiArZnVuY3Rpb24gaGVscCgpIHsNCj4+Pj4gKyAgICBjYXQgPDxFT0YNCj4+Pj4gK1VzYWdlOiAk ezB9IFtUQVJHRVQxXSBbVEFSR0VUMl0NCj4+Pj4gKw0KPj4+PiArVGhpcyBzY3JpcHQgaXMgYnVp bGQgdGhlIHlvY3RvIHhlbi1pbWFnZS1taW5pbWFsIGZvciBkaWZmZXJlbnQgcWVtdSB0YXJnZXRz DQo+Pj4+ICthbmQgaXMgcnVubmluZyBpdCBhZnRlci4NCj4+Pj4gK1dpdGhvdXQgYW55IHRhcmdl dCBzcGVjaWZpZWQsIGFsbCBzdXBwb3J0ZWQgdGFyZ2V0cyBhcmUgZG9uZS4NCj4+Pj4gKw0KPj4+ PiArT3B0aW9uczoNCj4+Pj4gKyAgLWgsIC0taGVscCAgICAgICBQcmludCB0aGlzIGhlbHANCj4+ Pj4gKyAgLXYsIC0tdmVyYm9zZSAgICBWZXJib3NlIGJ1aWxkDQo+Pj4+ICsgIC0tbGlzdC10YXJn ZXQgICAgTGlzdCBzdXBwb3J0ZWQgdGFyZ2V0cw0KPj4+PiArICAtLWNsZWFuICAgICAgICAgIENs ZWFuIGV4aXN0aW5nIHByb2plY3QgYmVmb3JlIHN0YXJ0aW5nDQo+Pj4+ICsgIC0tbm8tYnVpbGQg ICAgICAgRG8gbm90IGJ1aWxkICh0byBydW4gYW4gYWxyZWFkeSBidWlsdCBwcm9qZWN0KQ0KPj4+ PiArICAtLW5vLXJ1biAgICAgICAgIERvIG5vdCBydW4NCj4+Pj4gKyAgLS1udW0tam9icz1OVU0g ICBEZWZpbmUgdGhlIG51bWJlciBvZiBwYXJhbGxlbCBqb2JzIGluIFlvY3RvLg0KPj4+PiArICAg ICAgICAgICAgICAgICAgIERlZmF1bHQ6ICR7QlVJTERKT0JTfQ0KPj4+PiArICAtLWR1bXAtbG9n ICAgICAgIE9uIGVycm9yLCBkdW1wIHRoZSBsb2dzIG9uIHRoZSBjb25zb2xlDQo+Pj4+ICsgIC0t aW1hZ2U9SU1HICAgICAgWW9jdG8gaW1hZ2Ugb3IgcGFja2FnZSB0byBidWlsZA0KPj4+PiArICAg ICAgICAgICAgICAgICAgIERlZmF1bHQ6IHhlbi1pbWFnZS1taW5pbWFsDQo+Pj4+ICsgIC0teGVu LWRpcj1ESVIgICAgcGF0aCB0byB4ZW4gaHlwZXJ2aXNvciBzb3VyY2UgdHJlZQ0KPj4+PiArICAg ICAgICAgICAgICAgICAgIGlmIG5vdCBwcm92aWRlLCBub3JtYWwgeW9jdG8gdmVyc2lvbiBvZiB4 ZW4gaXMgYnVpbHQNCj4+Pj4gKyAgICAgICAgICAgICAgICAgICBEZWZhdWx0OiAke1hFTkRJUn0N Cj4+Pj4gKyAgLS1vdXQtZGlyPURJUiAgICBkaXJlY3Rvcnkgd2hlcmUgdG8gY3JlYXRlIHRoZSBw cm9qZWN0c3MNCj4+Pj4gKyAgICAgICAgICAgICAgICAgICBEZWZhdWx0OiAke0JVSUxERElSfQ0K Pj4+PiArICAtLWxvZy1kaXI9RElSICAgIGRpcmVjdG9yeSB0byBzdG9yZSBsb2dzDQo+Pj4+ICsg ICAgICAgICAgICAgICAgICAgRGVmYXVsdDogJHtMT0dESVJ9DQo+Pj4+ICsgIC0tY2FjaGUtZGly PURJUiAgZGlyZWN0b3J5IHdoZXJlIHRvIHRha2UgYW5kIHN0b3JlIGJ1aWxkIGNhY2hlDQo+Pj4+ ICsgICAgICAgICAgICAgICAgICAgRGVmYXVsdDogJHtDQUNIRURJUn0NCj4+Pj4gKyAgLS1sYXll ci1kaXI9RElSICBkaXJlY3RvcnkgY29udGFpbmluZyB0aGUgY2hlY2tvdXQgb2YgeW9jdG8gbGF5 ZXJzDQo+Pj4+ICsgICAgICAgICAgICAgICAgICAgRGVmYXVsdDogJHtZT0NUT0RJUn0NCj4+Pj4g K0VPRg0KPj4+PiArfQ0KPj4+PiArDQo+Pj4+ICtmb3IgT1BUSU9OIGluICIkQCINCj4+Pj4gK2Rv DQo+Pj4+ICsgICAgY2FzZSAke09QVElPTn0gaW4NCj4+Pj4gKyAgICAgICAgLWh8LS1oZWxwKQ0K Pj4+PiArICAgICAgICAgICAgaGVscA0KPj4+PiArICAgICAgICAgICAgZXhpdCAwDQo+Pj4+ICsg ICAgICAgICAgICA7Ow0KPj4+PiArICAgICAgICAtdnwtLXZlcmJvc2UpDQo+Pj4+ICsgICAgICAg ICAgICBWRVJCT1NFPSJ5Ig0KPj4+PiArICAgICAgICAgICAgOzsNCj4+Pj4gKyAgICAgICAgLS1s aXN0LXRhcmdldHMpDQo+Pj4+ICsgICAgICAgICAgICBlY2hvICIke1RBUkdFVF9TVVBQT1JURUR9 Ig0KPj4+PiArICAgICAgICAgICAgZXhpdCAwDQo+Pj4+ICsgICAgICAgICAgICA7Ow0KPj4+PiAr ICAgICAgICAtLWNsZWFuKQ0KPj4+PiArICAgICAgICAgICAgZG9fY2xlYW49InkiDQo+Pj4+ICsg ICAgICAgICAgICA7Ow0KPj4+PiArICAgICAgICAtLW5vLWJ1aWxkKQ0KPj4+PiArICAgICAgICAg ICAgZG9fYnVpbGQ9Im4iDQo+Pj4+ICsgICAgICAgICAgICA7Ow0KPj4+PiArICAgICAgICAtLW5v LXJ1bikNCj4+Pj4gKyAgICAgICAgICAgIGRvX3J1bj0ibiINCj4+Pj4gKyAgICAgICAgICAgIDs7 DQo+Pj4+ICsgICAgICAgIC0tZHVtcC1sb2cpDQo+Pj4+ICsgICAgICAgICAgICBkb19kdW1wPSJ5 Ig0KPj4+PiArICAgICAgICAgICAgOzsNCj4+Pj4gKyAgICAgICAgLS1udW0tam9icz0qKQ0KPj4+ PiArICAgICAgICAgICAgQlVJTERKT0JTPSIke09QVElPTiMqPX0iDQo+Pj4+ICsgICAgICAgICAg ICA7Ow0KPj4+PiArICAgICAgICAtLWltYWdlPSopDQo+Pj4+ICsgICAgICAgICAgICBidWlsZF9p bWFnZT0iJHtPUFRJT04jKj19Ig0KPj4+PiArICAgICAgICAgICAgOzsNCj4+Pj4gKyAgICAgICAg LS14ZW4tZGlyPSopDQo+Pj4+ICsgICAgICAgICAgICBYRU5ESVI9IiR7T1BUSU9OIyo9fSINCj4+ Pj4gKyAgICAgICAgICAgIGlmIFsgISAtZSAiJHtYRU5ESVJ9L3hlbi9NYWtlZmlsZSIgXTsgdGhl bg0KPj4+PiArICAgICAgICAgICAgICAgIGVjaG8gIk5vIFhlbiBzb3VyY2UgdHJlZSBpbiAke1hF TkRJUn0iDQo+Pj4+ICsgICAgICAgICAgICAgICAgZXhpdCAxDQo+Pj4+ICsgICAgICAgICAgICBm aQ0KPj4+PiArICAgICAgICAgICAgZG9fbG9jYWxzcmM9InkiDQo+Pj4+ICsgICAgICAgICAgICA7 Ow0KPj4+PiArICAgICAgICAtLW91dC1kaXI9KikNCj4+Pj4gKyAgICAgICAgICAgIEJVSUxERElS PSIke09QVElPTiMqPX0iDQo+Pj4+ICsgICAgICAgICAgICA7Ow0KPj4+PiArICAgICAgICAtLWxv Zy1kaXI9KikNCj4+Pj4gKyAgICAgICAgICAgIExPR0RJUj0iJHtPUFRJT04jKj19Ig0KPj4+PiAr ICAgICAgICAgICAgOzsNCj4+Pj4gKyAgICAgICAgLS1jYWNoZS1kaXI9KikNCj4+Pj4gKyAgICAg ICAgICAgIENBQ0hFRElSPSIke09QVElPTiMqPX0iDQo+Pj4+ICsgICAgICAgICAgICA7Ow0KPj4+ PiArICAgICAgICAtLWxheWVyLWRpcj0qKQ0KPj4+PiArICAgICAgICAgICAgWU9DVE9ESVI9IiR7 T1BUSU9OIyo9fSINCj4+Pj4gKyAgICAgICAgICAgIDs7DQo+Pj4+ICsgICAgICAgIC0tKikNCj4+ Pj4gKyAgICAgICAgICAgIGVjaG8gIkludmFsaWQgb3B0aW9uICR7T1BUSU9OfSINCj4+Pj4gKyAg ICAgICAgICAgIGhlbHANCj4+Pj4gKyAgICAgICAgICAgIGV4aXQgMQ0KPj4+PiArICAgICAgICAg ICAgOzsNCj4+Pj4gKyAgICAgICAgKikNCj4+Pj4gKyAgICAgICAgICAgIGlmIGVjaG8gIiR7VEFS R0VUX1NVUFBPUlRFRH0iIHwgZ3JlcCAtcSAtdyAiJHtPUFRJT059IjsgdGhlbg0KPj4+PiArICAg ICAgICAgICAgICAgIFRBUkdFVExJU1Q9IiR7VEFSR0VUTElTVH0gJHtPUFRJT059Ig0KPj4+PiAr ICAgICAgICAgICAgZWxzZQ0KPj4+PiArICAgICAgICAgICAgICAgIGVjaG8gIlVuc3VwcG9ydGVk IHRhcmdldCAke09QVElPTn0iDQo+Pj4+ICsgICAgICAgICAgICAgICAgZXhpdCAxDQo+Pj4+ICsg ICAgICAgICAgICBmaQ0KPj4+PiArICAgICAgICAgICAgOzsNCj4+Pj4gKyAgICBlc2FjDQo+Pj4+ ICtkb25lDQo+Pj4+ICsNCj4+Pj4gKyMgaWYgbm8gdGFyZ2V0IGlzIHNwZWNpZmllZCBidWlsZCBh bGwgdGFyZ2V0cw0KPj4+PiAraWYgWyAteiAiJHtUQVJHRVRMSVNUfSIgXTsgdGhlbg0KPj4+PiAr ICAgIFRBUkdFVExJU1Q9IiR7VEFSR0VUX1NVUFBPUlRFRH0iDQo+Pj4+ICtmaQ0KPj4+PiArDQo+ Pj4+ICtta2RpciAtcCAiJHtDQUNIRURJUn0iDQo+Pj4+ICtta2RpciAtcCAiJHtMT0dESVJ9Ig0K Pj4+PiArbWtkaXIgLXAgIiR7QlVJTERESVJ9Ig0KPj4+PiArDQo+Pj4+ICsjIE1ha2Ugc3VyZSB3 ZSBoYXZlIGFuIGFic29sdXRlIHBhdGgNCj4+Pj4gK1lPQ1RPRElSPSQocmVhbHBhdGggLW0gIiR7 WU9DVE9ESVJ9IikNCj4+Pj4gK0NBQ0hFRElSPSQocmVhbHBhdGggLW0gIiR7Q0FDSEVESVJ9IikN Cj4+Pj4gK0JVSUxERElSPSQocmVhbHBhdGggLW0gIiR7QlVJTERESVJ9IikNCj4+Pj4gK0xPR0RJ Uj0kKHJlYWxwYXRoIC1tICIke0xPR0RJUn0iKQ0KPj4+PiAraWYgWyAiJHtkb19sb2NhbHNyY30i ID0gInkiIF07IHRoZW4NCj4+Pj4gKyAgICBYRU5ESVI9JChyZWFscGF0aCAtbSAiJHtYRU5ESVJ9 IikNCj4+Pj4gK2ZpDQo+Pj4+ICsNCj4+Pj4gKyMgQ2hlY2sgdGhhdCB3ZSBoYXZlIGFsbCB0aGUg bGF5ZXJzIHdlIG5lZWQNCj4+Pj4gK2ZvciBmIGluICR7YnVpbGRfbGF5ZXJsaXN0fTsgZG8NCj4+ Pj4gKyAgICBpZiBbICEgLWYgIiR7WU9DVE9ESVJ9LyR7Zn0vY29uZi9sYXllci5jb25mIiBdOyB0 aGVuDQo+Pj4+ICsgICAgICAgIGVjaG8gIkxheWVyICR7Zn0gbWlzc2luZyBpbiAke1lPQ1RPRElS fSINCj4+Pj4gKyAgICAgICAgZXhpdCAxDQo+Pj4+ICsgICAgZmkNCj4+Pj4gK2RvbmUNCj4+Pj4g Kw0KPj4+PiArZm9yIGYgaW4gJHtUQVJHRVRMSVNUfTsgZG8NCj4+Pj4gKyAgICBpZiBbICIke2Rv X2NsZWFufSIgPSAieSIgXTsgdGhlbg0KPj4+PiArICAgICAgICBydW5fdGFzayBwcm9qZWN0X2Ns ZWFuICR7Zn0NCj4+Pj4gKyAgICBmaQ0KPj4+PiArICAgIGlmIFsgISAtZiAke0JVSUxERElSfS8k e2Z9L2NvbmYvbG9jYWwuY29uZiBdOyB0aGVuDQo+Pj4+ICsgICAgICAgIHJ1bl90YXNrIHByb2pl Y3RfY3JlYXRlICR7Zn0NCj4+Pj4gKyAgICBmaQ0KPj4+PiArICAgIGlmIFsgLWYgJHtCVUlMRERJ Un0vJHtmfS9jb25mL2xvY2FsLmNvbmYgXTsgdGhlbg0KPj4+PiArICAgICAgICBpZiBbICIke2Rv X2J1aWxkfSIgPSAieSIgXTsgdGhlbg0KPj4+PiArICAgICAgICAgICAgcnVuX3Rhc2sgcHJvamVj dF9idWlsZCAke2Z9DQo+Pj4+ICsgICAgICAgIGZpDQo+Pj4+ICsgICAgICAgIGlmIFsgIiR7ZG9f cnVufSIgPSAieSIgXTsgdGhlbg0KPj4+PiArICAgICAgICAgICAgcnVuX3Rhc2sgcHJvamVjdF9y dW4gJHtmfQ0KPj4+PiArICAgICAgICBmaQ0KPj4+PiArDQo+Pj4+ICsgICAgZmkNCj4+Pj4gK2Rv bmUNCj4+Pj4gKw0KPj4+PiArcHJpbnRfcHJvZ3Jlc3MgIkJ1aWxkIENvbXBsZXRlICgke2J1aWxk X3Jlc3VsdH0gZXJyb3JzKSINCj4+Pj4gK2VjaG8NCj4+Pj4gK2V4aXQgJHtidWlsZF9yZXN1bHR9 DQo+Pj4+ICsNCj4+Pj4gZGlmZiAtLWdpdCBhL2F1dG9tYXRpb24vYnVpbGQveW9jdG8veW9jdG8u ZG9ja2VyZmlsZS5pbiBiL2F1dG9tYXRpb24vYnVpbGQveW9jdG8veW9jdG8uZG9ja2VyZmlsZS5p bg0KPj4+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPj4+PiBpbmRleCAwMDAwMDAwMDAwMDAuLjUz NTBiYjJiODdiNw0KPj4+PiAtLS0gL2Rldi9udWxsDQo+Pj4+ICsrKyBiL2F1dG9tYXRpb24vYnVp bGQveW9jdG8veW9jdG8uZG9ja2VyZmlsZS5pbg0KPj4+PiBAQCAtMCwwICsxLDExNCBAQA0KPj4+ PiArIyBEb2NrZXIgZmlsZSB0byBjcmVhdGUgYW4gZW52aXJvbm1lbnQgdG8gYnVpbGQgeW9jdG8g d2l0aCB2aXJ0dWFsaXphdGlvbg0KPj4+PiArIw0KPj4+PiArIyBBcmd1bWVudHMgdGhhdCBjYW4g YmUgcGFzc2VkIGR1cmluZyBpbWFnZSBjcmVhdGlvbiB1c2luZyAtLWJ1aWxkLWFyZzoNCj4+Pj4g KyMgImhvc3RfdWlkPSQoaWQgLXUpIjogdG8gdXNlIGN1cnJlbnQgdXNlciB1aWQgZm9yIGJ1aWxk IHVzZXIgaW4gdGhlIGltYWdlDQo+Pj4+ICsjICJob3N0X2dpZD0kKGlkIC1nKSI6IHRvIHVzZSBj dXJyZW50IHVzZXIgZ2lkIGZvciBidWlsZCB1c2VyIGluIHRoZSBpbWFnZQ0KPj4+PiArIyAidWJ1 bnR1X3ZlcnNpb249VkVSUyI6IHRvIHNlbGVjdCB0aGUgdWJ1bnR1IHZlcnNpb24gbnVtYmVyDQo+ Pj4gSXMgaXMgdGhlIGNhc2UsIHRoYXQgdGhpcyBkb2NrZXJmaWxlIGFuZCB0aGUgcGFja2FnZXMg aW5zdGFsbGVkIHdpbGwgd29yayBvbiBhbnkNCj4+PiB2ZXJzaW9uIG9mIHVidW50dSB3ZSB3aWxs IHBhc3MgaGVyZT8gSWYgbm90LCBtYXliZSB3ZSBzaG91bGQganVzdCBzdGljayB0byAyMi4wNCBh bmQNCj4+PiBub3QgZ2l2ZSB0aGUgdXNlciB0aGUgb3Bwb3J0dW5pdHkgdG8gY2hhbmdlIHRoaXMu DQo+PiANCj4+IFRoZXJlIGlzIG5vIHN1cHBvcnQgcmlnaHQgbm93IHRvIGJ1aWxkIGZvciBhIGRp ZmZlcmVudCB2ZXJzaW9uIG9mIHVidW50dSB3aXRob3V0DQo+PiBtb2RpZnlpbmcgdGhlIGRvY2tl ciBmaWxlLiBJIGtlcHQgdGhhdCBhcyBhcmd1bWVudCBoZXJlIGJlY2F1c2UgdGhlIGdlbmVyYXRl ZA0KPj4gZmlsZS9jb250YWluZXIgZG9lcyBub3QgY29udGFpbiBhbiB1YnVudHUgdmVyc2lvbiBp biBpdHMgbmFtZSBzbyBjaGFuZ2luZyB0aGUNCj4+IHZhbHVlIGhlcmUgaW4gdGhlIGZ1dHVyZSB3 aWxsIG1ha2UgaXQgY2xlYXJlci4NCj4gT2suDQo+PiANCj4+IEkgYW0gb2sgdG8gcmVtb3ZlIHRo ZSB2YXJpYWJsZSBhbmQgZGlyZWN0bHkgdXNlIHRoZSB2YWx1ZSBpZiB5b3UgdGhpbmsgdGhpcyBp cyBuZWNlc3NhcnkuDQo+IE5vIG5lZWQuDQo+IA0KPj4gDQo+Pj4gDQo+Pj4+ICsNCj4+Pj4gKyMg VXNlIHN0YW5kYXJkIHVidW50dSBtaW5pbWFsDQo+Pj4+ICtBUkcgdWJ1bnR1X3ZlcnNpb249MjIu MDQNCj4+Pj4gK0Zyb20gIyNET0NLRVJQTEFUIyN1YnVudHU6JHVidW50dV92ZXJzaW9uIEFTIGJh c2UNCj4+Pj4gK0xBQkVMIG1haW50YWluZXIubmFtZT0iVGhlIFhlbiBQcm9qZWN0ICIgXA0KPj4+ PiArICAgICAgbWFpbnRhaW5lci5lbWFpbD0ieGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3Jn Ig0KPj4+PiArDQo+Pj4+ICtFTlYgREVCSUFOX0ZST05URU5EPW5vbmludGVyYWN0aXZlDQo+Pj4+ ICsNCj4+Pj4gKyMgSW5zdGFsbCBtaW5pbWFsIHVidW50dSByZXF1aXJlbWVudHMgZm9yIHlvY3Rv IGFuZCBvdGhlciB0b29scyB3ZSBuZWVkDQo+Pj4+ICsjIFNlZSBodHRwczovL25hbTExLnNhZmVs aW5rcy5wcm90ZWN0aW9uLm91dGxvb2suY29tLz91cmw9aHR0cHMlM0ElMkYlMkZkb2NzLnlvY3Rv cHJvamVjdC5vcmclMkY0LjAuMSUyRmJyaWVmLXlvY3RvcHJvamVjdHFzJTJGaW5kZXguaHRtbCUy M2J1aWxkLWhvc3QtcGFja2FnZXMmYW1wO2RhdGE9MDUlN0MwMSU3Q21pY2hhbC5vcnplbCU0MGFt ZC5jb20lN0NkNWVjYTA4Zjk2NWQ0ZmQxYTk5NTA4ZGFjOTVhNDFlNyU3QzNkZDg5NjFmZTQ4ODRl NjA4ZTExYTgyZDk5NGUxODNkJTdDMCU3QzAlN0M2MzgwNDM2ODY3NTUyOTIzMjIlN0NVbmtub3du JTdDVFdGcGJHWnNiM2Q4ZXlKV0lqb2lNQzR3TGpBd01EQWlMQ0pRSWpvaVYybHVNeklpTENKQlRp STZJazFoYVd3aUxDSlhWQ0k2TW4wJTNEJTdDMzAwMCU3QyU3QyU3QyZhbXA7c2RhdGE9RCUyRkFl JTJGQ1VvMiUyRldjdkpBWGpSVzR2Vzl6NHB3V2NVRU9oZTFUZGxvekVDdyUzRCZhbXA7cmVzZXJ2 ZWQ9MA0KPj4+PiArUlVOIGFwdC1nZXQgdXBkYXRlICYmIFwNCj4+Pj4gKyAgICBhcHQtZ2V0IC0t cXVpZXQgLS15ZXMgaW5zdGFsbCBcDQo+Pj4+ICsgICAgICAgIGdhd2sgXA0KPj4+PiArICAgICAg ICB3Z2V0IFwNCj4+Pj4gKyAgICAgICAgZ2l0IFwNCj4+Pj4gKyAgICAgICAgZGlmZnN0YXQgXA0K Pj4+PiArICAgICAgICB1bnppcCBcDQo+Pj4+ICsgICAgICAgIHRleGluZm8gXA0KPj4+PiArICAg ICAgICBnY2MgXA0KPj4+PiArICAgICAgICBidWlsZC1lc3NlbnRpYWwgXA0KPj4+PiArICAgICAg ICBjaHJwYXRoIFwNCj4+Pj4gKyAgICAgICAgc29jYXQgXA0KPj4+PiArICAgICAgICBjcGlvIFwN Cj4+Pj4gKyAgICAgICAgcHl0aG9uMyBcDQo+Pj4+ICsgICAgICAgIHB5dGhvbjMtcGlwIFwNCj4+ Pj4gKyAgICAgICAgcHl0aG9uMy1wZXhwZWN0IFwNCj4+Pj4gKyAgICAgICAgeHotdXRpbHMgXA0K Pj4+PiArICAgICAgICBkZWJpYW51dGlscyBcDQo+Pj4+ICsgICAgICAgIGlwdXRpbHMtcGluZyBc DQo+Pj4+ICsgICAgICAgIHB5dGhvbjMtZ2l0IFwNCj4+Pj4gKyAgICAgICAgcHl0aG9uMy1qaW5q YTIgXA0KPj4+PiArICAgICAgICBsaWJlZ2wxLW1lc2EgXA0KPj4+PiArICAgICAgICBsaWJzZGwx LjItZGV2IFwNCj4+Pj4gKyAgICAgICAgcHl0aG9uMy1zdWJ1bml0IFwNCj4+Pj4gKyAgICAgICAg bWVzYS1jb21tb24tZGV2IFwNCj4+Pj4gKyAgICAgICAgenN0ZCBcDQo+Pj4+ICsgICAgICAgIGxp Ymx6NC10b29sIFwNCj4+Pj4gKyAgICAgICAgZmlsZSBcDQo+Pj4+ICsgICAgICAgIHZpbSBcDQo+ Pj4+ICsgICAgICAgIGJpc29uIFwNCj4+Pj4gKyAgICAgICAgZXhwZWN0IFwNCj4+Pj4gKyAgICAg ICAgbG9jYWxlcyBcDQo+Pj4+ICsgICAgICAgIGxpYmx6NC10b29sIFwNCj4+Pj4gKyAgICAgICAg enN0ZCBcDQo+Pj4+ICsgICAgICAgIG9wZW5zc2wgXA0KPj4+PiArICAgICAgICBsaWJzc2wzIFwN Cj4+Pj4gKyAgICAgICAgY2EtY2VydGlmaWNhdGVzIFwNCj4+Pj4gKyAgICAgICAgJiYgXA0KPj4+ PiArICAgICAgICBhcHQtZ2V0IGF1dG9yZW1vdmUgLXkgJiYgXA0KPj4+PiArICAgICAgICBhcHQt Z2V0IGNsZWFuICYmIFwNCj4+Pj4gKyAgICAgICAgcm0gLXJmIC92YXIvbGliL2FwdC9saXN0cyog L3RtcC8qIC92YXIvdG1wLyoNCj4+Pj4gKw0KPj4+PiArIyBVc2UgYmFzaCBhcyBzaGVsbA0KPj4+ PiArUlVOIHJtIC9iaW4vc2ggJiYgbG4gLXMgYmFzaCAvYmluL3NoDQo+Pj4+ICsNCj4+Pj4gKyMg Rml4IGxvY2FsIGZvciB5b2N0bw0KPj4+PiArUlVOIGxvY2FsZS1nZW4gZW5fVVMuVVRGLTggJiYg dXBkYXRlLWxvY2FsZSBMQ19BTEw9ZW5fVVMuVVRGLTggXA0KPj4+PiArICAgIExBTkc9ZW5fVVMu VVRGLTgNCj4+Pj4gK0VOViBMQU5HIGVuX1VTLlVURi04DQo+Pj4+ICtFTlYgTENfQUxMIGVuX1VT LlVURi04DQo+Pj4+ICsNCj4+Pj4gKyMgQ3JlYXRlIGEgdXNlciBmb3IgdGhlIGJ1aWxkICh3ZSBk b24ndCB3YW50IHRvIGJ1aWxkIGFzIHJvb3QpDQo+Pj4+ICtFTlYgVVNFUl9OQU1FIGRvY2tlci1i dWlsZA0KPj4+PiArQVJHIGhvc3RfdWlkPTEwMDANCj4+Pj4gK0FSRyBob3N0X2dpZD0xMDAwDQo+ Pj4+ICtSVU4gZ3JvdXBhZGQgLWcgJGhvc3RfZ2lkICRVU0VSX05BTUUgJiYgXA0KPj4+PiArICAg IHVzZXJhZGQgLWcgJGhvc3RfZ2lkIC1tIC1zIC9iaW4vYmFzaCAtdSAkaG9zdF91aWQgJFVTRVJf TkFNRQ0KPj4+PiArDQo+Pj4+ICsjIFN3aXRjaCB0byBvdXIgdXNlciBpbnN0ZWFkIG9mIHJvb3Qg YW5kIHN0YXJ0IGluIGl0cyBob21lDQo+Pj4+ICtVU0VSICRVU0VSX05BTUUNCj4+Pj4gK1dPUktE SVIgL2hvbWUvJFVTRVJfTkFNRQ0KPj4+PiArDQo+Pj4+ICsjIENyZWF0ZSBuZWVkZWQgZGlyZWN0 b3JpZXMNCj4+Pj4gK1JVTiBta2RpciAtcCAvaG9tZS8kVVNFUl9OQU1FL3lvY3RvLWxheWVycyBc DQo+Pj4+ICsgICAgICAgICAgICAgL2hvbWUvJFVTRVJfTkFNRS95b2N0by1jYWNoZSBcDQo+Pj4+ ICsgICAgICAgICAgICAgL2hvbWUvJFVTRVJfTkFNRS9sb2dzIFwNCj4+Pj4gKyAgICAgICAgICAg ICAvaG9tZS8kVVNFUl9OQU1FL2JpbiBcDQo+Pj4+ICsgICAgICAgICAgICAgL2hvbWUvJFVTRVJf TkFNRS94ZW4gJiYgXA0KPj4+PiArICAgIGNob3duICRVU0VSX05BTUUuJFVTRVJfTkFNRSAvaG9t ZS8kVVNFUl9OQU1FLyoNCj4+Pj4gKw0KPj4+PiArIyBjbG9uZSB5b2N0byByZXBvc2l0b3JpZXMg d2UgbmVlZA0KPj4+PiArUlVOIGZvciByZXAgaW4gXA0KPj4+PiArICAgICAgICAgICAgICAgIGh0 dHBzOi8vbmFtMTEuc2FmZWxpbmtzLnByb3RlY3Rpb24ub3V0bG9vay5jb20vP3VybD1odHRwcyUz QSUyRiUyRmdpdGh1Yi5jb20lMkZvcGVuZW1iZWRkZWQlMkZtZXRhLW9wZW5lbWJlZGRlZCZhbXA7 ZGF0YT0wNSU3QzAxJTdDbWljaGFsLm9yemVsJTQwYW1kLmNvbSU3Q2Q1ZWNhMDhmOTY1ZDRmZDFh OTk1MDhkYWM5NWE0MWU3JTdDM2RkODk2MWZlNDg4NGU2MDhlMTFhODJkOTk0ZTE4M2QlN0MwJTdD MCU3QzYzODA0MzY4Njc1NTI5MjMyMiU3Q1Vua25vd24lN0NUV0ZwYkdac2IzZDhleUpXSWpvaU1D NHdMakF3TURBaUxDSlFJam9pVjJsdU16SWlMQ0pCVGlJNklrMWhhV3dpTENKWFZDSTZNbjAlM0Ql N0MzMDAwJTdDJTdDJTdDJmFtcDtzZGF0YT01SUIlMkJPOU0wRFUzRDdoTjdxOUZ0OU9pdnFmbVRW S3VPVktnRld1RWxVdTQlM0QmYW1wO3Jlc2VydmVkPTAgXA0KPj4+PiArICAgICAgICAgICAgICAg IGh0dHBzOi8vbmFtMTEuc2FmZWxpbmtzLnByb3RlY3Rpb24ub3V0bG9vay5jb20vP3VybD1odHRw cyUzQSUyRiUyRmdpdC55b2N0b3Byb2plY3Qub3JnJTJGcG9reSZhbXA7ZGF0YT0wNSU3QzAxJTdD bWljaGFsLm9yemVsJTQwYW1kLmNvbSU3Q2Q1ZWNhMDhmOTY1ZDRmZDFhOTk1MDhkYWM5NWE0MWU3 JTdDM2RkODk2MWZlNDg4NGU2MDhlMTFhODJkOTk0ZTE4M2QlN0MwJTdDMCU3QzYzODA0MzY4Njc1 NTQ0ODAzMCU3Q1Vua25vd24lN0NUV0ZwYkdac2IzZDhleUpXSWpvaU1DNHdMakF3TURBaUxDSlFJ am9pVjJsdU16SWlMQ0pCVGlJNklrMWhhV3dpTENKWFZDSTZNbjAlM0QlN0MzMDAwJTdDJTdDJTdD JmFtcDtzZGF0YT1mTVJnVEZOcmpSNWF0aHU5a1hTTlhBTCUyRmVOMlJ3TyUyQnU2Q1p4Q2JoZXN5 VSUzRCZhbXA7cmVzZXJ2ZWQ9MCBcDQo+Pj4+ICsgICAgICAgICAgICAgICAgaHR0cHM6Ly9uYW0x MS5zYWZlbGlua3MucHJvdGVjdGlvbi5vdXRsb29rLmNvbS8/dXJsPWh0dHBzJTNBJTJGJTJGZ2l0 LnlvY3RvcHJvamVjdC5vcmclMkZtZXRhLXZpcnR1YWxpemF0aW9uJmFtcDtkYXRhPTA1JTdDMDEl N0NtaWNoYWwub3J6ZWwlNDBhbWQuY29tJTdDZDVlY2EwOGY5NjVkNGZkMWE5OTUwOGRhYzk1YTQx ZTclN0MzZGQ4OTYxZmU0ODg0ZTYwOGUxMWE4MmQ5OTRlMTgzZCU3QzAlN0MwJTdDNjM4MDQzNjg2 NzU1NDQ4MDMwJTdDVW5rbm93biU3Q1RXRnBiR1pzYjNkOGV5SldJam9pTUM0d0xqQXdNREFpTENK UUlqb2lWMmx1TXpJaUxDSkJUaUk2SWsxaGFXd2lMQ0pYVkNJNk1uMCUzRCU3QzMwMDAlN0MlN0Ml N0MmYW1wO3NkYXRhPUo2SlFQM0libjJXYUQxY1R0ZHVDNFQlMkJibk5XbFVIbUZQWHJMc0llMUNT dyUzRCZhbXA7cmVzZXJ2ZWQ9MCBcDQo+Pj4+ICsgICAgICAgICAgICA7IGRvIFwNCj4+Pj4gKyAg ICAgICAgZ2l0IC1DIC9ob21lLyRVU0VSX05BTUUveW9jdG8tbGF5ZXJzIFwNCj4+Pj4gKyAgICAg ICAgICAgIGNsb25lIC1iICMjWU9DVE9WRVJTSU9OIyMgLS1zaW5nbGUtYnJhbmNoICRyZXA7IFwN Cj4+Pj4gKyAgICBkb25lDQo+Pj4+ICsNCj4+Pj4gKyMgVGhlIGJ1aWxkZXIgc3RhZ2UgaXMgYnVp bGRpbmcgYW4gaW5pdGlhbCBjYWNoZSBzdGF0ZSB0aGF0IHdlIGluY2x1ZGUgaW4gdGhlDQo+Pj4+ ICsjIGZpbmFsIGltYWdlDQo+Pj4+ICtGcm9tIGJhc2UgQVMgYnVpbGRlcg0KPj4+PiArDQo+Pj4+ ICsjIFRoaXMgc3RlcCBjYW4gdGFrZSBvbmUgdG8gc2V2ZXJhbCBob3VycyBkZXBlbmRpbmcgb24g eW91ciBkb3dubG9hZCBiYW5kd2l0aA0KPj4+PiArIyBhbmQgdGhlIHNwZWVkIG9mIHlvdXIgY29t cHV0ZXINCj4+Pj4gK0NPUFkgLi9idWlsZC15b2N0by5zaCAvDQo+Pj4+ICtSVU4gL2J1aWxkLXlv Y3RvLnNoIC0tZHVtcC1sb2cgIyNZT0NUT1RBUkdFVCMjDQo+Pj4+ICsNCj4+Pj4gK0Zyb20gYmFz ZQ0KPj4+PiArDQo+Pj4+ICsjIE9ubHkgY29weSB0aGUgY2FjaGUgc3RhdHVzDQo+Pj4+ICtDT1BZ IC0tZnJvbT1idWlsZGVyIC9ob21lLyRVU0VSX05BTUUveW9jdG8tY2FjaGUgL2hvbWUvJFVTRVJf TkFNRS95b2N0by1jYWNoZS8uDQo+Pj4+ICsNCj4+Pj4gK0xBQkVMIG1haW50YWluZXIubmFtZT0i VGhlIFhlbiBQcm9qZWN0ICIgXA0KPj4+PiArICAgICAgbWFpbnRhaW5lci5lbWFpbD0ieGVuLWRl dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnIg0KPj4+PiArDQo+Pj4+IGRpZmYgLS1naXQgYS9hdXRv bWF0aW9uL2J1aWxkL3lvY3RvL3lvY3RvLmluYyBiL2F1dG9tYXRpb24vYnVpbGQveW9jdG8veW9j dG8uaW5jDQo+Pj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+Pj4+IGluZGV4IDAwMDAwMDAwMDAw MC4uMDQwNzZiYzhkMTc0DQo+Pj4+IC0tLSAvZGV2L251bGwNCj4+Pj4gKysrIGIvYXV0b21hdGlv bi9idWlsZC95b2N0by95b2N0by5pbmMNCj4+Pj4gQEAgLTAsMCArMSw0MSBAQA0KPj4+PiArIyBU aGlzIG1ha2VmaWxlIGdlbmVyYXRlcyB0aGUgZG9ja2VyIGZpbGVzIGZvciBZb2N0byBidWlsZHMN Cj4+Pj4gKyMgVGhlIGNvbnRhaW5lcnMgZm9yIHRoZSBjdXJyZW50IGFyY2hpdGVjdHVyZSBhcmUg dGhlIG9uZSBidWlsdCB1c2luZyBtYWtlIGFsbA0KPj4+PiArIyBUbyBidWlsZCBjb250YWluZXJz IGZvciBhIGRpZmZlcmVudCBhcmNoaXRlY3R1cmUsIHlvdSBuZWVkIHRvIGNhbGwgbWFrZSBmb3IN Cj4+Pj4gKyMgdGhlIGltYWdlIHlvdSB3YW50IGV4cGxpY2l0ZWx5DQo+Pj4gQ291bGQgeW91IHBs ZWFzZSBhZGQgYSBkb3QgYXQgdGhlIGVuZCBvZiBlYWNoIHNlbnRlbmNlIGFib3ZlLiBUaGlzIHdp bGwgaW1wcm92ZSByZWFkYWJpbGl0eS4NCj4+IA0KPj4gWWVzIHdpbGwgZG8uDQo+PiANCj4+PiAN Cj4+Pj4gKyMgVGhlIGNvbnRhaW5lcnMgYXJlIG5hbWVkIHRoaXMgd2F5Og0KPj4+PiArIyBZT0NU T1ZFUlNJT04tVEFSR0VUIGZvciB4ODZfNjQgaG9zdHMNCj4+Pj4gKyMgWU9DVE9WRVJTSU9OLVRB UkdFVC1hcm02NHY4IGZvciBhcm02NCBob3N0cw0KPj4+PiArDQo+Pj4+ICsjIFlvY3RvIHZlcnNp b25zIHdlIGFyZSBjdXJyZW50bHkgdXNpbmcNCj4+Pj4gK1lPQ1RPX1ZFUlNJT04gPSBraXJrc3Rv bmUNCj4+Pj4gKw0KPj4+PiArIyBZb2N0byBCU1BzIHdlIHdhbnQgdG8gYnVpbGQgZm9yDQo+Pj4+ ICtZT0NUT19UQVJHRVRTID0gcWVtdWFybTY0IHFlbXVhcm0gcWVtdXg4Ni02NA0KPj4+PiArDQo+ Pj4+ICsjIFN1cHBvcnRlZCBIb3N0IHBsYXRmb3JtcyAoaG9zdCBhcmNoaXRlY3R1cmUgc3BlY2lm aWMgb25lcykNCj4+PiBUbyBhdm9pZCBtaXNtYXRjaCBcd3J0IHBsYXRmb3JtIHZzIGFyY2hpdGVj dHVyZSBJIHdvdWxkIHN0aWNrIHRvIHRoZSBsYXR0ZXIgb25lLg0KPj4+IEluIHRoZSBkb2NrZXIg d29ybGQsIGFybTY0djggaXMgYW4gYXJjaGl0ZWN0dXJlIHdoZXJlYXMgbGludXgvYXJtNjQvdjgg aXMgYSBwbGF0Zm9ybS4NCj4+IA0KPj4gU28gInlvY3RvIHRhcmdldOKAnSBhbmQg4oCcY29udGFp bmVyIHBsYXRmb3Jt4oCdID8NCj4gY29udGFpbmVyIGFyY2hpdGVjdHVyZQ0KPiANCg0KT2sNCg0K Pj4gDQo+Pj4gDQo+Pj4+ICtZT0NUT19IT1NUUyA9IGFtZDY0IGFybTY0djgNCj4+Pj4gKw0KPj4+ PiArIyBBcmNoaXRlY3R1cmUgd2Ugd2FudCB0byB1c2UgaW4gZ2l0bGFiIENJIChkZXBlbmRzIG9u IHJ1bm5lcnMgYXJjaCkNCj4+Pj4gK0NJX0FSQ0ggPSBhcm02NHY4DQo+Pj4+ICsNCj4+Pj4gK2Rl ZmluZSBHRU5fRE9DS0VSDQo+Pj4+ICsjIE1ha2UgYWxsIGlzIGdlbmVyYXRpbmcgd2hhdCB3ZSB3 YW50IGluIHRoZSBDSQ0KPj4+PiAraWZlcSAoJChDSV9BUkNIKSwkKDMpKQ0KPj4+PiArQ09OVEFJ TkVSUyArPSB5b2N0by8kKDEpLSQoMikkKDQpDQo+Pj4+ICtlbHNlDQo+Pj4+ICtDT05UQUlORVJT X0VYVFJBICs9IHlvY3RvLyQoMSktJCgyKSQoNCkNCj4+Pj4gK2VuZGlmDQo+Pj4+ICsNCj4+Pj4g K3lvY3RvLyQoMSktJCgyKSQoNCkuZG9ja2VyZmlsZTogeW9jdG8veW9jdG8uZG9ja2VyZmlsZS5p bg0KPj4+PiArICAgICAgIGVjaG8gPiAkJEANCj4+Pj4gKyAgICAgICBjYXQgJCQ8IHwgXA0KPj4+ PiArICAgICAgICAgICBzZWQgLWUgInMsIyNZT0NUT1ZFUlNJT04jIywkKDEpLGciIHwgXA0KPj4+ PiArICAgICAgICAgICBzZWQgLWUgInMsIyNZT0NUT1RBUkdFVCMjLCQoMiksZyIgfCBcDQo+Pj4+ ICsgICAgICAgICAgIHNlZCAtZSAicywjI0RPQ0tFUlBMQVQjIywkKDMpLyxnIiA+ICQkQA0KPj4+ PiArDQo+Pj4+ICtlbmRlZg0KPj4+PiArDQo+Pj4+ICskKGV2YWwgJChmb3JlYWNoIHZlcnMsJChZ T0NUT19WRVJTSU9OKSxcDQo+Pj4+ICsgICAgJChmb3JlYWNoIHRhciwkKFlPQ1RPX1RBUkdFVFMp LFwNCj4+Pj4gKyAgICAkKGZvcmVhY2ggaHN0LCQoWU9DVE9fSE9TVFMpLFwNCj4+Pj4gKyAgICAk KGNhbGwgR0VOX0RPQ0tFUiwkKHZlcnMpLCQodGFyKSwkKGhzdCksJChpZiAkKGZpbHRlciBhbWQ2 NCwkKGhzdCkpLCwtJChoc3QpKSkpKSkpDQo+Pj4gVGhpcyBjb3VsZCBiZSBhbGlnbmVkIHVuZGVy IGZpcnN0IGZvcmVhY2guIEFsc28gSSB0aGluayB0aGVyZSBpcyBubyBuZWVkIHRvIHRyeSB0byBz aG9ydGVuIHRoZSB2ZXJzaW9uLHRhcmdldCxob3N0Lg0KPj4gDQo+PiBUaGlzIGlzIHNvbWV0aGlu ZyB5b3UgcmVxdWVzdGVkIG1lIGluIG9yZGVyIHRvIGhhdmUgY29udGFpbmVyIG5hbWVzIGZvciB5 b2N0byBjb2hlcmVudA0KPj4gd2l0aCBvdGhlciB4ZW4gY29udGFpbmVycyAoaWUgb25seSBoYXZl IHRoZSAtYXJtNjR2OCBzdWZmaXggZm9yIGFybSkuDQo+PiANCj4+IERvIHlvdSB3YW50IG1lIHRv IHJldmVydCB0aGlzIGFuZCBoYXZlIG5hbWVzIGNvbnRhaW5pbmcgdGhlIGFtZDY0IHN1ZmZpeCA/ DQo+IFRoaXMgaXMgbm90IHdoYXQgSSBtZWFudC4NCj4gSSBqdXN0IHdhbnRlZCB0byB1c2UgdGhl IGZ1bGwgd29yZHMgbGlrZSB0YXJnZXQsaG9zdCx2ZXJzaW9uIGluc3RlYWQgb2YgdGFyLGhzdCx2 ZXJzDQo+IGFuZCBmb3IgdGhlICJmb3JlYWNoIiB0byBiZSBhbGlnbmVkLg0KDQpBaCBvayB0aGlz IGlzIG1vcmUgY2xlYXIsIEkgd2lsbCBjaGFuZ2UgdGhhdC4NCg0KQ2hlZXJzDQpCZXJ0cmFuZA0K DQo+IA0KPj4gDQo+PiBUaGFua3MgZm9yIHRoZSByZXZpZXcNCj4+IA0KPj4gQ2hlZXJzDQo+PiBC ZXJ0cmFuZA0KPj4gDQo+Pj4gDQo+Pj4+IC0tDQo+Pj4+IDIuMjUuMQ0KPj4+PiANCj4+PiANCj4+ PiB+TWljaGFsDQo+PiANCj4gfk1pY2hhbA0KDQo= From xen-devel-bounces@lists.xenproject.org Fri Nov 18 13:09:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 13:09:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445757.701115 (Exim 4.92) (envelope-from ) id 1ow17X-00068l-Cg; Fri, 18 Nov 2022 13:09:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445757.701115; Fri, 18 Nov 2022 13:09:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow17X-00068e-9w; Fri, 18 Nov 2022 13:09:27 +0000 Received: by outflank-mailman (input) for mailman id 445757; Fri, 18 Nov 2022 13:09:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow17V-0005xA-KR for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 13:09:25 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20621.outbound.protection.outlook.com [2a01:111:f400:7d00::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 38b0e6f9-6742-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 14:09:24 +0100 (CET) Received: from AS8P251CA0004.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::21) by AM8PR08MB6577.eurprd08.prod.outlook.com (2603:10a6:20b:355::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Fri, 18 Nov 2022 13:09:21 +0000 Received: from VI1EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f2:cafe::cc) by AS8P251CA0004.outlook.office365.com (2603:10a6:20b:2f2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19 via Frontend Transport; Fri, 18 Nov 2022 13:09:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT046.mail.protection.outlook.com (100.127.144.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 13:09:20 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Fri, 18 Nov 2022 13:09:20 +0000 Received: from f5958f5a1aa1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 44590639-1942-463C-BF0D-EC28D853E384.1; Fri, 18 Nov 2022 13:09:13 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f5958f5a1aa1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 13:09:13 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS4PR08MB7654.eurprd08.prod.outlook.com (2603:10a6:20b:4f0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 13:09:12 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5834.007; Fri, 18 Nov 2022 13:09:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38b0e6f9-6742-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bSkVDnZRk6GYOMvQGLduC9jeeH+3aaFcStTq6iQN1kk=; b=U/ohzwQsB/O2I9QJeLotjv4XeQsHWV+s5dJ1nc1/8QKQ7cshEWWu6E7WHv0wg5hJ1u5X5SRpQOAwT5czGnR7bw4gWgh0X73foXRKbosGdjwXH3oq8cUbfufauOEMMoO5OpVtiszmpnpK/unNY9IX7GfLYBDYcjGLyXb+QSNhgcA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 98494a77e4082d13 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LAAQ7POtbyWINABso6pRlF2nG3ND8j+V/XBgN9hCKWLV05zYAqMMaB92VqJaGcoX1eFA5oMVFqNs0UQhlLEeq5ziaPXM4aJnUv6MZBA+t+6UYuOtFws1dupJccxkuPq/fDuvXwE9bw7p0oHC4TFd/9wPe2+6Cl3ptkV8TguZRUvpe7wFZRoydBDQuuTdBpKOc5+boUThlKDrsM7xTLP2jGzBoXObZGmWpG303cldH23paHPl802Jf3dB3kQVBfEIn/dGReJf9YI7ySsE3k7+JmyGIfjHQBcywxfmD0gRdp7ku10r5ZeP9CX6BoKflmH4Et1sWdI2NucDKhM3l4+kuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bSkVDnZRk6GYOMvQGLduC9jeeH+3aaFcStTq6iQN1kk=; b=FQ7eIDSEHMxPCCfVX4FxRrs8zDsSV8eMWKpg3E3jrQZHR+KcdcnA5EQnQSwpYjViJTlUaS5lYTC2zHg4mJJxuKOGvo/AdIVN2zGoomUuTFMEkapFsQOhR14/5HFs431S4LXC/xAQwCfjNr1lVe2J1u16bFs2ybmDe9QBbSdgC8nwk6XP/eN0L6IhzSGVKNFvgwnDyPePogiMIab273blgFdBNh3K48SOIvqWp/PaUwdqTHe3ov2fCX10ZQasIiynELYbk+HvceQqCFYhpdfFm2RajmIT1GPFqxH/MM5hQEZzf2E81pmdimRI8Ei96nmtatHgmV1OEL69HbcWEam5ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bSkVDnZRk6GYOMvQGLduC9jeeH+3aaFcStTq6iQN1kk=; b=U/ohzwQsB/O2I9QJeLotjv4XeQsHWV+s5dJ1nc1/8QKQ7cshEWWu6E7WHv0wg5hJ1u5X5SRpQOAwT5czGnR7bw4gWgh0X73foXRKbosGdjwXH3oq8cUbfufauOEMMoO5OpVtiszmpnpK/unNY9IX7GfLYBDYcjGLyXb+QSNhgcA= From: Bertrand Marquis To: Michal Orzel CC: "xen-devel@lists.xenproject.org" , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v4 2/3] automation: Add a clean rule for containers Thread-Topic: [PATCH v4 2/3] automation: Add a clean rule for containers Thread-Index: AQHY+mi0wlvynKbFO0CQN7pfcZf/NK5EYyiAgABF7IA= Date: Fri, 18 Nov 2022 13:09:11 +0000 Message-ID: References: <3a127e836d744fbb2954690293ee47d2c0c899e2.1668677493.git.bertrand.marquis@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS4PR08MB7654:EE_|VI1EUR03FT046:EE_|AM8PR08MB6577:EE_ X-MS-Office365-Filtering-Correlation-Id: 82fe6038-fedc-4e0e-4498-08dac9661b44 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: C1xXHJ/peVCEadZA+P86uYKn65UJrAlwOYr7vY//y6NRQfxoZfnZ+CPixN6n8knBlpM/E08dp/KVWM1pVomyQwIxCYXqQ0P4GgyEAVOfSCvH1hOf/0Wq8CYIntxVhAyLyXl5vLNd6VBZKvXpH+IbXJH38CgquOuJgqii4Dt0WWtJNuWyORC/3INZVGj8kFs8LOTLFDUJlplT2O5aL+IkRhpEoAbbs2+4AXkk3wqlpnLbW//xB9mF/z2tOjkxnHMvHS5wxEdoDTXlKDe8tlSF3eAZCL+kjGHOd/pcaZDNOujUEG3G4sKOcJlFOVtfWWfBrM1WNK2ewKS62jLPYgd/HndgqKF6AOe7jfSygDpmTCF7xBhURdjQlibxkx7ifNnzfTn52yHL1hnJKqOs0UFyfDciKqdkbAMp5/VkJoreB9LsNIXr9M4BzgRQ6QBlZS3RPuTEbSLosvDDhcXG9A8jZIZovDH9uFaV0H+eq6SCReTW+zUoqFmn8Dp80wGu+ZxtuFafQv1a/yNq9CaCIn49myoIQ9EWJtwgCQeeFDOXCwRK4ZpuUOpVN502061NZglI2UY096JCRZY9VpttmeQkzdZlaJIoWx9OSnXT/XeWqwDzV3AvyAU7LxZz3tmwwOCgKOCVUjwTqdvIbW/BesHTM8OvhJc7zNS0IUWosGQgHxFCsqEY1/YCkOZpnsOBEchAN8w5xyrDQFvC/N/1RSZDzR2QPEjNMZwNbpo+Jg4UW60= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(376002)(396003)(366004)(451199015)(33656002)(36756003)(38100700002)(316002)(8936002)(2906002)(4326008)(38070700005)(4744005)(122000001)(86362001)(66556008)(66946007)(6916009)(91956017)(186003)(2616005)(6486002)(478600001)(66446008)(41300700001)(6506007)(64756008)(8676002)(66476007)(54906003)(5660300002)(26005)(71200400001)(6512007)(76116006)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <9C682DF73912C541869624FC352281B5@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7654 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b4981802-c659-4312-7939-08dac96615ea X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E45xYMWKIoiGViQbneP5j2FHkPXi1F27XqJDcFBB5pJTJsv7iGJlMQcuzZ+7mMfBLnsxm6tbA4A1Mv6LPsIgq/lyDDfoHVqYxyXGGGnHwLh6pD+j3oSgzl+nW4mJFRHS0UMnD/JhcFeG9V0zLEDrZkKs/VKKxjdVF+Npi/MaJuRHSSCHySeCxa7k79qaoMuOQTH2aszElZa+3wanTydeFEmjjp8FAX74/QpC05qECiSbEGbpPGd9Ve9h0m3XAA5O6CcboeQn4cUPw+CdytvUxcOR8Cfw5fgl/VagdelfLijlVi/fb1WIEbWlwPW3TcNx3Op/i6HiIBk4jCiIVjhzA7rTmvEjzrWX+39TiMCjwvV5wCZkS/lzKNOOi4ipcJj0Lxuhyy8EooSSI13rvSi3CaSdWkZNwku++qZIna/MOnHhDwkblG+uNdfbuv33IIonSQgvKSO0rHhS7vfs83ETY36jTvqFvYxhErvO+ocg3oQDf6qDJ1v2y5hEgEIFKou2QkNztaI56FBQqA21ZZu4aXQnxvA2K9TklF8TOXA6Cdz8v9lxmeRd7wc7rHZd3gF19J5eO7B2Hp6jQN+jka+mXtIhRUUQ8hR8RsY4wiSucDayJF/oGQVspCVnBpxCJoVMh3kBL23hc5lJfSzvXGewfDMUzhwsYMdge5i8FsdFHJb7CbNAdp84QqH+oAWvVbYdA8+mWOkhqZcWrzG2U0DBVA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(70206006)(70586007)(5660300002)(6862004)(4744005)(8936002)(81166007)(4326008)(26005)(6506007)(8676002)(41300700001)(6512007)(33656002)(336012)(316002)(186003)(36860700001)(36756003)(40460700003)(54906003)(86362001)(107886003)(82740400003)(53546011)(356005)(40480700001)(82310400005)(478600001)(47076005)(2616005)(2906002)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 13:09:20.6558 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 82fe6038-fedc-4e0e-4498-08dac9661b44 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6577 Hi Michal, > On 18 Nov 2022, at 08:58, Michal Orzel wrote: >=20 > Hi Bertrand, >=20 > On 17/11/2022 10:39, Bertrand Marquis wrote: >>=20 >>=20 >> Add make clean support to remove the containers from the local docker >> registry: > I have to say that I am a bit scared of adding a clean rule. > make clean is something that can easily sneak into this directory and can > remove the yocto images that we had to spent several hours to build. > The accidental clean can have severe consequences :) >=20 > In any case, if we want to add such possibility I would stick to calling = always: > make clean- > and remove the option to call "make clean" to remove all the images. Make sense, I will remove those to be automatically called from make clean Cheers Bertrand >=20 > ~Michal From xen-devel-bounces@lists.xenproject.org Fri Nov 18 13:10:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 13:10:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445762.701125 (Exim 4.92) (envelope-from ) id 1ow18x-0007ks-Nh; Fri, 18 Nov 2022 13:10:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445762.701125; Fri, 18 Nov 2022 13:10:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow18x-0007kl-Kh; Fri, 18 Nov 2022 13:10:55 +0000 Received: by outflank-mailman (input) for mailman id 445762; Fri, 18 Nov 2022 13:10:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow18w-0007kf-KB for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 13:10:54 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2061b.outbound.protection.outlook.com [2a01:111:f400:7d00::61b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6e520dbc-6742-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 14:10:53 +0100 (CET) Received: from DUZPR01CA0013.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c3::6) by AS2PR08MB9786.eurprd08.prod.outlook.com (2603:10a6:20b:605::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Fri, 18 Nov 2022 13:10:41 +0000 Received: from DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3c3:cafe::d3) by DUZPR01CA0013.outlook.office365.com (2603:10a6:10:3c3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Fri, 18 Nov 2022 13:10:41 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT063.mail.protection.outlook.com (100.127.142.255) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 18 Nov 2022 13:10:41 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Fri, 18 Nov 2022 13:10:41 +0000 Received: from a12975b779d6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 60D1668B-0536-44D3-9967-141980D24A87.1; Fri, 18 Nov 2022 13:10:34 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a12975b779d6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Nov 2022 13:10:34 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAWPR08MB9005.eurprd08.prod.outlook.com (2603:10a6:102:33e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 13:10:31 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5834.007; Fri, 18 Nov 2022 13:10:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e520dbc-6742-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QjGNyL8RKxtucLG+xdGQDWNcAwGaB414utaccGVbBEk=; b=ijwpYMS83XdPLdwsK3DbismzVY0+Q7BPfNhwawnflrngdL94Fz2IdRjwrc+642i1FuJS7IZkhx0MZtozsGhVIIqAj6Hn44NwV2/UyjINe0BIuJXB2TyTW5Sji6cY0d92Qk+2VmxWvqnruOcfmA44UMwcRUCtuTXQmJGtZ+LHIpc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: ba572b422e488886 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=odTYNlMPUT7aReJ0Hsa+1km767rCt//aIfb3ZKHHl97dbZJLZqdt5bqxyqSSvwebgI1RyQ2o10175EQHK2a/l0NrfACpC+n3sBPiONTdYhPj5V3HJ9gHjTNiA8el41dVjmAARkZ+6OxDSoK3PdspIL3HZR/yTEW10PuhvY4a7In0No2pjuWau//qYcRlvYVsWopryd60fxMg05+wBWzDR3uXoAzDpGMjaJwuaGS85vcNx8s1Sch53PRE9EQJZeSxz+bzRC7fYTkqemmfW5flDmpAtDlLuZ52cfpZDQAdmTA+y/nOR8HhEmGODRAXa+ITbjnaXXGZxt8kkY6CVIs3ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QjGNyL8RKxtucLG+xdGQDWNcAwGaB414utaccGVbBEk=; b=AtS3FJD3YsbBLVT0Ro88GZR+6RINyQmdQDu9XA3trGRtNK6l2Wt5gsQNqR2tgw4EXI6r5EREwjjMD9BGMIqAOMG5pjaH7H51dF/EswNFijO6M3rFiE710wmzu7AgqycpJ0FlXVuQuVFJVkWrY4TsAhjgobHyjT7M5LU5NMS1Ylj+0PBUb9JxesvQ2EYt4kJiH7ChraL7Du+yPsK+O+6von/Ug0M+c/Kwk3G99dm3MGzoi5nVe2eqMtNsvpwULutxufdw+HIy51GkkmH/Le0U7FI3kzERSicZ7DKxc5PeoPS8vU2M9evJwJ3uyEUKwgVYTs7RelHvPeNCJYF5TNyrkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QjGNyL8RKxtucLG+xdGQDWNcAwGaB414utaccGVbBEk=; b=ijwpYMS83XdPLdwsK3DbismzVY0+Q7BPfNhwawnflrngdL94Fz2IdRjwrc+642i1FuJS7IZkhx0MZtozsGhVIIqAj6Hn44NwV2/UyjINe0BIuJXB2TyTW5Sji6cY0d92Qk+2VmxWvqnruOcfmA44UMwcRUCtuTXQmJGtZ+LHIpc= From: Bertrand Marquis To: Michal Orzel CC: Xen developer discussion , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH] docs/misc/arm: Update references to Linux kernel docs Thread-Topic: [PATCH] docs/misc/arm: Update references to Linux kernel docs Thread-Index: AQHY+0N2vSlEmd+I6EOXaDTIdICPg65Ep70A Date: Fri, 18 Nov 2022 13:10:31 +0000 Message-ID: <31E1FFCF-F675-47D9-BCDB-5884F7360567@arm.com> References: <20221118114554.20696-1-michal.orzel@amd.com> In-Reply-To: <20221118114554.20696-1-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|PAWPR08MB9005:EE_|DBAEUR03FT063:EE_|AS2PR08MB9786:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ecb7be4-2b83-4816-6753-08dac9664b5f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fOyWM5nkV+51o0eflhHNpzBZHgrL5+ON8gfcK/kZVxoFHOF93cg65VXoKbqmlzwg/rabWLNGfAbRmZAfqecQ89c8QH7n7nLIN/rj/BwhxCLinzb+/Ns+ytTkzrcZATWjDb1ZxttRJnF7X/Bo/HyhLF/BS7QTXNRtnVIYIa0PYQc8swzaem0i8hhXHM1Smbw+jW8vuYIm6uFZekr51j1i3PvcU4M28xnDOgc7TXnwJZ53WMAW3MoXfoCrhipcJNIw9oKzhKi7M3EMBNx3Km2pHIj3/F7DSIDcf8/Z7gdbhZ/UERqjfaUkQGBGIZh7zw516R+zn+kEKKXJM5pq5UdG37ahJCQ8CzJhq7P1Mc6WWgJc+LesmYnd/UWNh3CjuHZTDM5MLZKyfqLk2JOYm7ulgN0Kiqwl38s48szmnqCY+k0YeEtEgRCFC2iJuB5KhIoHY/lOub71H13P8ctCf10p3lm1htJq1AmOMyV8pppwDhbV5ltBZ1bZeZXT8RoBoTBaxpgwa0XOzaXn+lqcEWxZW+LOYQLSBcZzsFt0s1kd3FQLWItYflCgJgr39pFIF8FSqiK2yMpndq0E8mTK4zKnPbCB7BVupc1Md+EgIiWiSzVxoe1GOte7gb0umUn3X2o6xFdSKvJp2948lDHq+dqZgbJO79VT4rmXkhtyxy5qJXUceIMrN1N1zHUlNCwEtb+WuC37fGT3GjBLOO7BrL0/1QqNlyseptNfymfFDoM7ZWvjqycGefHlUp5pgCffpr2ICwc8ALqFPHxVOG+wFwBIQ82X0PQ364WXCPjn80Wy/ZfjfiR9FlbxnLvXFNtzpumV X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(346002)(366004)(136003)(451199015)(91956017)(64756008)(76116006)(36756003)(4326008)(66476007)(66946007)(66556008)(5660300002)(66446008)(8676002)(8936002)(33656002)(86362001)(54906003)(83380400001)(478600001)(6506007)(26005)(6512007)(71200400001)(19625735003)(6916009)(6486002)(2616005)(966005)(186003)(53546011)(316002)(2906002)(38070700005)(38100700002)(122000001)(41300700001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9005 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 57fc3b3f-2f2a-4a34-bb4e-08dac966457e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o9KS/oYqc0KtkhMdUUw98WFnP63M4ez9hmfY8WixojObRxYz+18vJ30wIdDdi/+AjSqRHO16BM9q6mu5Q+HRC18jqd8rwmIEjP6Id/e64MeEopKLkNrnd3X96iWwzCg3nhavqrSGuylGsf/eL2Dl9JKH3SdKfpmRdpJnew2PTR2Oglna5p74d4NMS+B4REW+UFMefhsZ9Osb+tP01S58LNmvratelNuNd3J7X36FF5WY4EU/5FKiQPeQHE21PMdqklLOLLB/KS19Q4t74ifZa1uHY7YxXKgBFxtuNkjtb8nf3Sd5kDYAoKUgIBqGo0Qm6IzfFOMHzRK2xPkfYV350EsQ2rHZpE4qKn+4Eehgik8slqjjz0y4u0e3lxlHAiqbaXYTZEZEeevLLe7EKn9PzLCLcyOx2dKQAQ3IGtyHa5uPEXJ0yS7JnsuHU2PeNfxfSOZmKepDmUwL10I4LAENhG8Cr+qSWuE/3iejrpjNv33GcE8gTSGIHAgztg6wrKou6hiG3JZU9d5ThJVrNY4QIUm5e6CB463Pph3LxoWH8ub+9fuWWRGrKwLghMm3QrhENonf2DIHqUidDVTZTXSUd1lB+sYtaYil5DFZSG+VRBnmD0rVP1NM4L+0htQFHb4BENQmMaRYUxpJvyEbqDnBS5BqrwQfgAMii8xEg2gu9O4NN3LlynqOruUedJE/eNrlt68I0yyk8iUVyVEu7xUjS7P37gGKEP3u0rZOpm4wU+t7JBxyTk+f2v0SMZPxrcaAX0PYH2t87r0pyaAEhKgHvw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(346002)(396003)(451199015)(46966006)(40470700004)(36840700001)(83380400001)(6486002)(33656002)(356005)(86362001)(81166007)(82740400003)(5660300002)(8936002)(53546011)(6862004)(36860700001)(8676002)(70206006)(4326008)(41300700001)(70586007)(26005)(82310400005)(47076005)(107886003)(6512007)(316002)(6506007)(40460700003)(186003)(336012)(2616005)(19625735003)(2906002)(54906003)(478600001)(40480700001)(36756003)(966005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 13:10:41.4737 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6ecb7be4-2b83-4816-6753-08dac9664b5f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9786 Hi Michal, > On 18 Nov 2022, at 11:45, Michal Orzel wrote: >=20 > Some time ago, Linux switched the format of docs to ReST and the format > of device-tree bindings to json-schema. >=20 > Signed-off-by: Michal Orzel Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > docs/misc/arm/booting.txt | 8 ++++---- > docs/misc/arm/passthrough.txt | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/docs/misc/arm/booting.txt b/docs/misc/arm/booting.txt > index d3f6ce4755f6..3e0c03e06596 100644 > --- a/docs/misc/arm/booting.txt > +++ b/docs/misc/arm/booting.txt > @@ -34,8 +34,8 @@ Xen relies on some settings the firmware has to configu= re in EL3 before starting > * The bit SCR_EL3.HCE (resp. SCR.HCE for 32-bit ARM) must be set to 1. >=20 >=20 > -[1] linux/Documentation/arm/Booting > -Latest version: http://git.kernel.org/cgit/linux/kernel/git/torvalds/lin= ux.git/tree/Documentation/arm/Booting > +[1] linux/Documentation/arm/booting.rst > +Latest version: http://git.kernel.org/cgit/linux/kernel/git/torvalds/lin= ux.git/tree/Documentation/arm/booting.rst >=20 > -[2] linux/Documentation/arm64/booting.txt > -Latest version: http://git.kernel.org/cgit/linux/kernel/git/torvalds/lin= ux.git/tree/Documentation/arm64/booting.txt > +[2] linux/Documentation/arm64/booting.rst > +Latest version: http://git.kernel.org/cgit/linux/kernel/git/torvalds/lin= ux.git/tree/Documentation/arm64/booting.rst > diff --git a/docs/misc/arm/passthrough.txt b/docs/misc/arm/passthrough.tx= t > index 219d1cca571b..4f0a024818a2 100644 > --- a/docs/misc/arm/passthrough.txt > +++ b/docs/misc/arm/passthrough.txt > @@ -71,8 +71,8 @@ Please refer to your platform docs for the MMIO ranges = and interrupts. > They can also be calculated from the original device tree (not > recommended). You can read about the "interrupts" property format in the > device tree bindings of the interrupt controller of your platform. For > -example, in the case of GICv2 see [arm,gic.txt]; in the case of GICv3 > -see [arm,gic-v3.txt] in the Linux repository. For both GICv2 and GICv3 > +example, in the case of GICv2 see [arm,gic.yaml]; in the case of GICv3 > +see [arm,gic-v3.yaml] in the Linux repository. For both GICv2 and GICv3 > the "interrupts" property format is the same: the first cell is the > interrupt type, and the second cell is the interrupt number. Given that > SPI numbers start from 32, in this example 80 + 32 =3D 112. > @@ -187,6 +187,6 @@ assign a network card to a dom0-less guest on Xilinx = Ultrascale+ MPSoC: > }; >=20 >=20 > -[arm,gic.txt]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/= linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/arm,g= ic.txt > -[arm,gic-v3.txt]: https://git.kernel.org/pub/scm/linux/kernel/git/torval= ds/linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/ar= m,gic-v3.txt > +[arm,gic.yaml]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds= /linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/arm,= gic.yaml > +[arm,gic-v3.yaml]: https://git.kernel.org/pub/scm/linux/kernel/git/torva= lds/linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/a= rm,gic-v3.yaml > [xl.cfg]: https://xenbits.xen.org/docs/unstable/man/xl.cfg.5.html > --=20 > 2.25.1 >=20 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 13:11:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 13:11:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445763.701137 (Exim 4.92) (envelope-from ) id 1ow194-00082J-06; Fri, 18 Nov 2022 13:11:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445763.701137; Fri, 18 Nov 2022 13:11:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow193-00082C-Sv; Fri, 18 Nov 2022 13:11:01 +0000 Received: by outflank-mailman (input) for mailman id 445763; Fri, 18 Nov 2022 13:10:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow191-000817-SB for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 13:10:59 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20615.outbound.protection.outlook.com [2a01:111:f400:7e1b::615]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 716c2b31-6742-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 14:10:58 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7471.eurprd04.prod.outlook.com (2603:10a6:800:1a7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 18 Nov 2022 13:10:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 13:10:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 716c2b31-6742-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FxkN2mFNq2ywYwIcinIgOd+tBJqzgJMGjt+TYy2zr7id2hJBBcLOTlnNAYJqWfCWwiICntvoqHVQ5jyAWJiSvJf4Gvafj3JWZYbgb46SczrnxvN64/nEJbGjgcymrzJOV2vj0G4W7SyMWpR6MD1yW6kyn92USh5dqsnRhWopA10RC0js/Te3AWLNtKVZ6UVda2ZDBGFb5vk3lAQ+9zfTqiFxPXnZ+w0TWWD3/SO/H7YxfBQQYkfh//dSUd4JWJlNKAA6FouEHCPE5ZW4YwWoPyOO5XuDX/V1pcgNDACHxnoGuf+aWrepltUjEdyMBo2k4SKrP0iKE8YWiAv29u5jqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yYkz69mvailF3/Dnf5UMLrpVpwRVCUcsht9JOvU8pFY=; b=kvs4gyxsITu6d6OMY63dc5JvxRnNlQJqhzEsOIgFzuh+J9RyhHkM9qbjVgUh3rd3vflGCITb6ooazVNhHnV5Oxd4mUIuzFl6Ji98dHIqtJf1caQN4z7oomYX9o4eDECD5kbF+BBnA9gw/4+5Nc8iGPoajaxNzgjV6DpBWMo4eN6qb2VR051MFf83yD5O93FIS4Q6JOPLukqGmUYYxrzJEA0vh2pFfIBctuS/K17iQpUnTzfh3PBPnNAIkLHF+tJb1X3vd/M3VBbbbyo8SBCMiQ7cBRz8yqqdSMLLUUaYh7yXj3M4EnJUKaHe1Llwi4Kg1jTiTGM6mQrQJhkUiAcFnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yYkz69mvailF3/Dnf5UMLrpVpwRVCUcsht9JOvU8pFY=; b=rqarVSJ3CQg5Ix5g9del4nbfZNXc7deNgxmxMoywHXEWD5/O9bF09ZftqrXWpcgWJQcuABnwIf+nUGMergXHRSVdICHnHPUMD5dqcMUtkw0MJIH3mu5S/dOthiBoFT2hgcSOUjSpja2E0pSs0RaLE6cwMV+q8b8RT1cfegC/rFmuXK/4vYqsC5Q9CcrnSCEfwU9htz6gETwMOQcQIkYuJacWCDnKDHL4yT84pMdT2XzrBY0FST4kleH1G+LtpAO6wCqclXvHtGBpQscjvBTZAJd+30fD1ltoC3OGcvjGATtwTZLW1RH9QIwLnTeE9l6r5sX+s6CAYLvvOZlXqW8Z7Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 18 Nov 2022 14:10:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v9 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20221118104508.768274-1-wei.chen@arm.com> <20221118104508.768274-6-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20221118104508.768274-6-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0171.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7471:EE_ X-MS-Office365-Filtering-Correlation-Id: ebc817bc-4190-40dd-fa86-08dac96654d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FmCs/KeemC1k+gOZroq5+h7DXx2xNFn7Q6xgENnuD7FOm3R5sP6MqDVdni62GKj4ZDPr3KP8TMQSfJjMft+TeP85CfCm5qjXWzH8ZLbls9XZZvOuNVbG47O4UPkAr0Y2+NSxyIInDhGxaTO2YcnTdg4ae4PH6EbcK7EPtrHbTSoVrQI+yShs10uv9WmU4ODVhIDqNnPbTHxYpVstQo5WxciUJE5GmS+8N1kbOitbwjTF7WrcSIZFix3ucT0ip9NvB2teoJbWIw6cgr5UlvrouHh8+i/7DqvC6JWgk7L4u+zISGOGAcJolkcZmZ0p/SOaEEq6q3iOPzbjEqS2rTsy/lIaC4p44HJeBQ+DtshCpN6EbZQ508szLekilQCEkWghSwW2brit3pkXz3SIl9yHDZ4Y8HLbOAB/vtzHaS1uXb35QWG2o/JUaJf+JBWlkcxrUQWPoR8VpMky9boojAOWwVK5XjhMutqFD/lD2JBekQzOc1d8SonkI1nqKrRIx+9clvjlGUnV3yt3aTK6lWwKtJj95dpkJ6FNxe65D3w1aats/ozs62CrelrkxZeKheQNADyLTDcnfCnDYsCqCOPOAw2yNQGzGTuN58FLmWw9AYRtNB+hyfoGXl5n650Tob0wn7RpxsrxkRQkQWvfwhHScE5m2SjmO61T52roQZF8GIekf3XYep+XAnXMXembFNp4D2WKpM2dcgzzhU5x0IfItrs1I4YoSfUKNKIdHmqfe/Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(376002)(396003)(136003)(39860400002)(451199015)(478600001)(31686004)(6486002)(8676002)(26005)(66476007)(8936002)(4326008)(66946007)(36756003)(66556008)(6512007)(186003)(5660300002)(53546011)(6916009)(6506007)(316002)(54906003)(2616005)(2906002)(83380400001)(86362001)(31696002)(41300700001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXRxTW9GdTFmL0NvNTVhY3pBbzlRamkzaUoxWDJmRWRyU2NWN1MrY0JINXNU?= =?utf-8?B?YTVrZ0hVVG82ck45QWR4ZzRhZVducVVFRzlSNnNYaEJmcVpscGwxcDg4RG1T?= =?utf-8?B?ckpLT2FRVzZ6UExQZzRHY0Z2L3VKcllKUkJSK2JMM2JUSmNIcW05eDNyRW41?= =?utf-8?B?Q1hJblhOdzNXcDNJWEJ6UjRLTXZqdEZiYVZ3VmpQRG9ubGx2TmtIUk5vaW5O?= =?utf-8?B?cE1oV1FwcHBtMVJtanlKMWhaTDk4VzlHMWJnZ1NHUWk1M2R3UE5ObXExVThM?= =?utf-8?B?cGZoZHhUSWpTMmhKOWFxYW92NnQ1b0tEYTNXWFkvRmtyNFhVRzVNdkZ2dU5S?= =?utf-8?B?b3VmMWJkMzRJUHJ6RE1TZVNVU2tFRmZoK214QnlQdCtVTzUxdjVJRFZkOS9M?= =?utf-8?B?cmlyeExWblBBcGNwNDBuNHIrUDkvSU55OG9vT0Eva2tFbGhNTGdHNllDWkEw?= =?utf-8?B?MlJLTnNZczRSUFRBbmRINk9XS2NlZjdlSVVhVU4vWUcrZk81T1ZUR1FvOURM?= =?utf-8?B?ay9YeldNUTUrbzJFbXU4Wk1iK1FKaitwTCtXRjlwOGUzTzJ2NE1wR3loVXR0?= =?utf-8?B?QzFLTkpBS0JqaGxVS29aUG5ydHZmeTRTc0hodjZ1UzVqTE9aVGNITkJXMjYw?= =?utf-8?B?eERhZitXT2h3Y1hCYm9YNTdTTVhEcHorbStLek1XdVh6VUtTRlJhVmxRRE9W?= =?utf-8?B?aDYvUlg5WjJFNUVDTEFFdHFVL0tkOTg0eGZaRzlxbEdVOG00bTlHMjAreFVL?= =?utf-8?B?RnZsS2c3Wkx5S0daQkR1MC9tVnFQTWZ0RGtSUjhpMm1zdlp5UVZkMlZJbU95?= =?utf-8?B?SlY2Rm95VVp6alg2eEtHaWo0MTh6bTJDdTkzdlVTaVpmczJuZmxuMlQxZVZB?= =?utf-8?B?Snp3OWYyOXBrek1EZGJMMnlGQXVWbmF5VjBpS0NuaG92ZGQ1cUVjb28vVUc0?= =?utf-8?B?ZHBJY2FDbVR6ZmhPRFAxYjMzVVhuR1hOZXRwZXdrN0JMK1hJSm5IVEIrYnVQ?= =?utf-8?B?bmNpaTVJYUVBSFBKZzRrSSttWG5wRDEzbU5RZkJrWGdiYmpmRnlZZGsvcTZW?= =?utf-8?B?Q1NGa0wwUHdBUlExZTgrczJrSnYxN21yTWxoTS95SUw1RGsvWnVJZmw5K1Va?= =?utf-8?B?U2M4RE92Y0k5bnJqM3oySkNwZ0cweHRhUDI5aHN2Rmpxbm5JNnROVFo3QWlW?= =?utf-8?B?RXdBWTNzUjRKMnhRQTFySitxd3cvTkJQZGxrb3dvalJnOTgzWHNJUVJXTHA3?= =?utf-8?B?dmVYL0V2eVZHRmxjZ2xvOHA2akxXWWpKL05jWjNXT0RQZUVtZkxSL1N5WG5W?= =?utf-8?B?M1JjMHZ0R1JBVTdhalRrYWlOQVBBUmsyemc1ajJNL0hGR1phb2pPejRmZlI0?= =?utf-8?B?TU1zbDNjbnJORzNvQUppVWJ3NFdjU2U2V3hkZ0ZhTmk2Y3d0QnJZdGxhUHpn?= =?utf-8?B?bGhma1FySFQ3R0V0UEpnaFE1VWtSVUdoVHhKZWhvaStkYXlEREdsa0lIVWJs?= =?utf-8?B?VURlYjFIdDhMaExyZUx0TnJuS214YXdnS2JBbS9QZm4rcmkwcURoNjV1MStz?= =?utf-8?B?TGJkNitQSUt0SjJoYzVwREpDNjN2Q2duc3VtV3p0NHJpdzJmRDA1WGUvTlda?= =?utf-8?B?UGJEQjRYMjVSb0xSWWtCTVBORnkxdmRFdGVKSTdzZmxTRTBJbWR5YWtoOXBI?= =?utf-8?B?aFdLc2wweDNaTW14WmN6RXhxeDBCaFpMdG5mT2xoQTJCYU42dS9MY3ZWM01S?= =?utf-8?B?cE1zbnRQMTJ1RlB5aWk4QmZHaWdaeEt1MGxZOXJyTVpNMnJxRDY1V0J4VGFV?= =?utf-8?B?cGE1anUzQWRrU1Y0cjhPdS9SbVlTYW9BR3BrU29RYlhmUVFXUU5VbTZsTkRM?= =?utf-8?B?eStVUnl4SnhiWWxOUjJWNUVUVWRWb1FrQzdqTkk4Tzg0SWd3QStpUlFJMjdG?= =?utf-8?B?V2xEVWVJUkViSXJWZEd5MGo4NnZUckRMbG8yWXZReXBMRUJ5dVg4N0tPeU9Z?= =?utf-8?B?ME81RWxJaU1FdkMyNndBeFVYcjNvYUxySmJydlR3QnN2VVdqOG1lSlAzYVA2?= =?utf-8?B?dXpZVSttam9Eb3JPRXo1WXJwVm1xZCtKdVBkUTVsNGNyRjNSdDhNalltMDcx?= =?utf-8?Q?eEXHyCKh5ffTLU8hM5zjnH1Fz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebc817bc-4190-40dd-fa86-08dac96654d9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 13:10:57.4702 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7S79x/h9HgZ6tGIZcXzLgcmfEVg+ZW29O/EFPC3QNf/rqvnaOz485r5oSFzXq5fwMecZY7/G7dB3tnLbhPF4wQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7471 On 18.11.2022 11:45, Wei Chen wrote: > x86 has implemented a set of codes to process NUMA nodes. These > codes will parse NUMA memory and processor information from > ACPI SRAT table. But except some ACPI specific codes, most > of the process code like memory blocks validation, node memory > range updates and some sanity check can be reused by other > NUMA implementation. > > So in this patch, we move some variables and related functions > for NUMA memory and processor to common as library. At the > same time, numa_set_processor_nodes_parsed has been introduced > for ACPI specific code to update processor parsing results. > With this helper, we can reuse most of NUMA memory affinity init > code from ACPI. As bad_srat and node_to_pxm functions have been > used in common code to do architectural fallback and node to > architectural node info translation. But it doesn't make sense > to reuse the functions names in common code, we have rename them > to neutral names as well. > > PXM is an ACPI specific item, we can't use it in common code > directly. So we introduced an numa_fw_nid_name for each NUMA > implementation to set their specific firmware NUMA node name. > In this case, we do not need to retain a lot of per-arch code > but still can print architectural log messages for different > NUMA implementations. A default value "???" will be set to > indicate an unset numa_fw_nid_name. > > mem_hotplug is accessed by common code if memory hotplug is > activated. Even if this is only supported by x86, export the > variable so that other architectures could support it in the future. > > As asm/acpi.h has been removed from common/numa.c, we have to > move NR_NODE_MEMBLKS from asm/acpi.h to xen/numa.h in this patch > as well. > > Signed-off-by: Wei Chen Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Fri Nov 18 13:44:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 13:44:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445777.701148 (Exim 4.92) (envelope-from ) id 1ow1fl-0003x8-OT; Fri, 18 Nov 2022 13:44:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445777.701148; Fri, 18 Nov 2022 13:44:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow1fl-0003x1-Li; Fri, 18 Nov 2022 13:44:49 +0000 Received: by outflank-mailman (input) for mailman id 445777; Fri, 18 Nov 2022 13:44:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow1fk-0003wv-Oz for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 13:44:48 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 28818953-6747-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 14:44:46 +0100 (CET) Received: from mail-bn1nam02lp2041.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Nov 2022 08:44:42 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM8PR03MB6245.namprd03.prod.outlook.com (2603:10b6:8:32::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 13:44:36 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Fri, 18 Nov 2022 13:44:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28818953-6747-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668779085; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=wF59RuD8Rj2Axz2JSiM4yybdghUoVELSgnJe+HgwmWE=; b=Ie4QdNaErY+YpKVSXtP9Sxp7bKWdJWbKzhkFqjaU0m8cJFBSOAHaVeMQ GEJBKAFvmNZvGB/5aRAMxhZFh5EoYMU3FaSjuxSvxJftVrtmwanhyceTc NWuN8hFX6JPTqN1P8njXxqlOI3bZpgEa46ZTimuNRL0bvVcSs5EIpRNY5 0=; X-IronPort-RemoteIP: 104.47.51.41 X-IronPort-MID: 85133242 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:OxEwmqPjZlnSm/rvrR2BlsFynXyQoLVcMsEvi/4bfWQNrUomhTFSy mQbXG2HMvreMWTyctF3PYni8klQuMTQmNU1Hgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5wxmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0v1oImVh+ 6UfERcmRU26jaG64vHnasA506zPLOGzVG8ekldJ6GmDSNwAGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PNxvzG7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLVryv33bWTx0sXXqoUNLy42vc1qWbCw0koETERdnSnkaGm3xvWt9V3b hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JPF8Uq5QfLzbDbiy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU331y1uPhTa7OCxQJ2lbYyYBFVEB+4O7/Nh1iQ/TRNF+FqLzlsfyBTz73 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxloRiFKND2Bw1WXm0A== IronPort-HdrOrdr: A9a23:S1KuParv9DIMgmOJf0lc5Z0aV5opeYIsimQD101hICG9E/bo9P xG88566faZslwssRIb6LK90cC7KBu2yXcS2+Qs1NyZMDUO1lHIEKhSqa7j2SDdASHk1uM178 ldWpk7LNXxCFh8g+b2iTPWL+od X-IronPort-AV: E=Sophos;i="5.96,174,1665460800"; d="scan'208";a="85133242" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=auIbv0PjFVDoL9tmAdY7EZfBNDKL3aBJREThSK6Xf8JxgHxr3Uc7o+H/K6CFF04pTqT6K1fVzoPUEZIHdG87t6w3rLPAWs/GZDcosfr9z1OFu9JFbLHGHsiVidvkf338t8h+WGTzHPZ9Lu5dbq02Y+ZiNb0oNmaK9XyNmWud8pTf3e7LGR4/Ic8uCvt6XLyyWUVHnDiXOHAS8LUk0a1GcKOLRTDR7mF6+yM18I4x8O1X3rj0BQwjmv3F9VQtVuEO3DkzmjeScMJkPNe1eSQiC3awSu3rwcdxUKW7Sud9cxS/erK2MhQr2ifAhboQhiY5JL9wmcPtHtUfprrV+n1wkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lNlMLUQguxBjhgQ7a2qDcoPA+nYF/Bgs2inTOGLNjMI=; b=BEpALoVrg10EKqpURrwCMdzaEXuYLVqTrpnLw5Ks/sz5sknZV9COFz5dxVkeZfgvuDOUfjinuYEZuzd6dosejTIYJvHz7XmCZTZ7QCPB2kjyqmXSilY15xhPOn4BSqze3yp3cHrmVM7Wm3HO7eGP5+iaDhKQ4QN1BTrdrCsv29dh6jl5alEbcvT5lI18MVU2zsnoIlFQ1OBRQyKgn+ZX3KGAT7KuYHWHRQiRfP9am5AyJPktxsWu+sCa8vEZEOBvkQBDX00IWjaB1yyAhqkWvIwv5vuY/dKnxAmFzMHUKSOdnrHDRuEMNk/GflvhieRxn90pVDfOlKOdC8oVLfZaJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lNlMLUQguxBjhgQ7a2qDcoPA+nYF/Bgs2inTOGLNjMI=; b=lABmMVSaF2TNAHjf2ECbCi/eIpVGSEHmtOFSqhzcQ+h0QMeEvJ8Ge/cbjPCq4qjuENSKguyYRE1epf5YJdbUPSYB2sJwztSXPJUdhD46awKzO68l0dykB3oDvKM6BQiBQVVQJU3TKOhPD4MYYeKMLuwiPhwmrd0t5SzDcuZsBog= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 18 Nov 2022 14:44:28 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] efifb: ignore frame buffer with physical address 0 Message-ID: References: <20221118123925.25363-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0643.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::10) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM8PR03MB6245:EE_ X-MS-Office365-Filtering-Correlation-Id: 848eeb2b-4425-43dc-7a06-08dac96b067a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w6VyRvWIHoONfg3gft3k9ysg6wQT4yYdzA2did9ODnNib8CVST+9hvWq2nlBMkps/P086guyqL/l0IstOTHpD0gbFPEqdewNa7JMr6n8dfD4Ji2R9w5MTsQVyfThb+32VlWgiDayH7ERcRRnKm5XJzlVsJE7uTb6RBC+lrj0DCUpWNI+K6gJd8V1ZFOYmVoXSnYZ3cAwmwHfq644hMtFINeS+V2RCvC664eMthp6FiHz14yiLxi7kjCa9azPfrf9ZMTnSpuzBirBHQ85FZalu0Htisz2sjqKMM96nTamwsXRVNLkNh5AH73fYyvqGu67OQ8zCjBdjtE2/SgxMVbYRUt083hZzBUPvFoRQ5M/VsMPEAo4sE/IB2uAylT7ilmyiNCOHn8dO8dlgnM5yZfEdaz+QQJFWuDDRMWCB0oXoENQaZ03zHjjKPUJyhhyK7qezj3vCO0QA2BMq+R7QcUXPgEw307EB+/NitQW/I0FVrBHamTh1giXIxGlXCrnYbFVEfliS2ZaScIAD0ZnFt0xTtPVRN6b3bFYafWgw14NNI1GVdc3JUQyAFSChZHbUsK6oIr8LboOnWobjfDGl12B+A6yavAqlOfZhqCb0+Y9D3pVfDUYEHi5MI095iLpwHKpGXGSPg6vHrjbreH+Ak35tQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(366004)(136003)(346002)(39860400002)(376002)(396003)(451199015)(38100700002)(66946007)(82960400001)(4326008)(8676002)(83380400001)(66476007)(66556008)(85182001)(8936002)(5660300002)(2906002)(54906003)(6916009)(316002)(186003)(26005)(6666004)(6512007)(6506007)(9686003)(86362001)(33716001)(53546011)(6486002)(478600001)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eU15Y29WQkdQc296SjlHalVrTWVsS0JVN2Z1aStyaitDK1RzcUZQY2R4c3Y0?= =?utf-8?B?ZTBlczI2ZG9EbFRtcUVMUTBJSG5ZdUdqVk9NRXRKcjhja1d1MDZOTVZ4dVl0?= =?utf-8?B?U1lZeWRHWVF5Q2NJZUw3T2xlVGNqUmlyOWhyNkMrU1c2aE8xUVNYSzlOdjZu?= =?utf-8?B?OVByVVBIQ1ZiU0RNVWdaQlVwZGFxVmFaa3NDeER1RzhqTjM0aGpxTy9CRDBt?= =?utf-8?B?V0ZjMDhmcTFVUGtyTEFoY00xZTdZQ2t2aVJ5OEIrUmkxdkticUFWallUcDVj?= =?utf-8?B?VE5VU2VTTjNyWnZVR1YyR25tVGY1T2xJT1pTeWgvMXBTRUNmTmdSOW5OS0Rl?= =?utf-8?B?SVpXaGx4NG5hb05BSTNtWmZ2NFNDZ3pnZzB0SERtZEtwZTA3bVlleWVRYVRU?= =?utf-8?B?MjNFa2lUNTdEdmdYVDMxS0NOK0RWZXo0aXBjWHgySzNLWHliM2M2UmpKMU92?= =?utf-8?B?UklEcFFuUG8zdXNhVitMb1I0VE0zOWdjeVY0ZGF3WUcyVFIyMzFEeEVXWFdC?= =?utf-8?B?QTAvak9GeXpYUkg2ZjNibzZGbnBsakFoc21LbnNjTmMzMVVHMjlMUWZRb0pa?= =?utf-8?B?bU13YXdlVDFMRFBzS2NOR0srU3prMGhDZnJpek9mU2xEbTJwaUV3RnM4cTFY?= =?utf-8?B?VTdpWXFaOUx5NDNYZ2xETlJXUXBMTjRnbk9OZ3ZSRmRZT1BVMXlBT0pGaGxI?= =?utf-8?B?ZndBYzVTSFh2OUI4aE45emFMdjNLeE1OcDNSWCtaR3pUUkJtRytFbFNpNmhX?= =?utf-8?B?NDh6Qy9wYnZVMW5YVlVua2dYMDJCdHRBN2h0NUliNmJqM3lwbktHdUJORDhY?= =?utf-8?B?TDBrSzI1M09KdjhNSis3UVRVek80OG80ZHVpeU5jWlg1eVBkaVA3cklja05G?= =?utf-8?B?Wk12eWI0WjlLT1ZTQmVXSTJwU0lyWHViWG1PTE4ydGVQQmxIMlB0UDNaV3BD?= =?utf-8?B?eHF5dlRLMGdhVVkxV010dVN6ZStYdDRXbXBndm9lZDVWYXRMM2g4c2pla2xv?= =?utf-8?B?VnpkUllCWGYvalJBeExrOHFVdTQvYkhwUU1SL0c0UFV3Yy81YWJWb1kxVzR6?= =?utf-8?B?MG5Pc3BybUgvSHRyNXNWNnEyRzFTSFdhMTFEMnY0bG5MRkFzejJKVWd5Zy9G?= =?utf-8?B?QXhkY1lFRFVUMGx4eW9UYnRWa2dveTZMRHlkN25TM2huK1ROb2VkTDZ6NzZT?= =?utf-8?B?TEdZMkw1NFhDK1Q4cXpwSStSWlZxSWpseERlanJNTFoxUlhwWDZkZTBQaUF2?= =?utf-8?B?bEEzY3JLR3F2Rmsya1daN3JXQ3hRcDlXZncrRTFEWVRaNHJNVXpwUlFKQWda?= =?utf-8?B?YmtPbXBCbVIwdUhLZkE5M3ZWNTZ5eXNjZFdubVZycTlHaDJlaXo4N2N3WG53?= =?utf-8?B?Q1pLOWpXc1QybHFhb1krSlowb0EwbzVaZm1CaWZDa3daanZxS0hBWEVQNm85?= =?utf-8?B?Yk1teWtaRENEMFRLY3JiM3R3T1ZDMmFjZVZLVEY0bmpqaU95SDh1dHFDWjE5?= =?utf-8?B?c3lRR1lPeTNRdDBNc09WTjRuUytwTHhLSjRGa1ArM2J5T2REQlozaTFWa25a?= =?utf-8?B?cTVmbTk3UklEOVFEK21ROTA5eGVWNkJ6ZmpTbGlLM2N2ODZxUHhrWGF4QXA2?= =?utf-8?B?Y2lFbmcraUZqbmxmdkpnYkVOZ3BFTzdQQjBZYWdxekxPMzJ1N2p6UkhYTXhz?= =?utf-8?B?VlNYaFVET003S283dWFsZnRjMXFoNjZPMUhaV0Q3QTBoT2oxdlhBbUFtMDha?= =?utf-8?B?d0RrOTB0RmFnWkJnNXg0cXdDTUxNYnhtcGlmTWJLNlNpU0VNNWpMbG9uWG9J?= =?utf-8?B?MXMyWW1YWGNkRGQ3R2JJTlFWdlRMOVhUTzY4WTV2TS84LzFTOHNmQlNhSmZI?= =?utf-8?B?bjVIcU1OYlJueklMNUw5TTFvaGwzaEV4RFNvT0dWaXEvSTJEK21xY0xIMi9n?= =?utf-8?B?TjBGV1dmRUFQbmE1ZjNDWE5BUVlVWkVRM1kwL21tdEFQc1Zidk9Kb1EzK043?= =?utf-8?B?SFVjdTlseFhIUDdOcktZOFk5Rm5jSGVtSFZXRldIeUV3bnhYK3Y2YW9neW9p?= =?utf-8?B?MzhiQlpDS1d4Mk5oWnQ3eDN1K1pWVGJHdFFTaXlKVGdaWHZTVHpjcDJVZC9Y?= =?utf-8?Q?1xkfjls913GNFCLnEfcWPJ+SM?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: RWKJVmeZpVAlpmYxiBwjR/9+S2o4QKJlc/9/3YxLEKUYKg8zBbeEQOWNzyNNgSXz9V4FMc2hkINRQAyw+cGBdPgmkm/gnvO84xg1g08S+auiiMbdo9eoRROIiBp+5y39VyCpK/HpbZTAo4rUOtuzV7w5kOPkH+Bv8aMOOh5oeM+nuVgEGAOwhGf7dACrFHadXJiuOyFSl1jiOgK+CtBvEhHMtrV7npu/6HD3jZYgdgWSY/Vv/GVazImX/hOm/bLRD/wSQaf7J8OgeBBWYnSszkzAmR4HfA2dVlAlfBNgkyeaYgCBi8Rr9gcKv2CxsiOsaaK7G87r6hxJenn/sARFUhOF7KFnLus71bdoNijrXXbuLCyUQcJEiuvkxM1vMit5/htKR6KMYZ5paaWHdb5zZgkWUAyGBso4zJtR/htTOzbfG7MTCTvsaU06OG1KznwigEjH0JZDQ9D+cJCxjh2d9XiMLC09Kf/+Rlxo4xx5nCNHncnnr1YdGYFpx/07rBvbCWw7b+vtpI3nueBeocWJGiIX2ZsIHME98/ZCERbA38WLbwia9SKGr8L1kjD0RknEr+lHgtpVr45ush5b8gb93lf/O0dfmvbEXgYIrP1lCAM2U2NwDjvuN8KJ+NSdOyaYL0D2k796mu4NPlGI7gLd2UxopbqnWMs8rDVfv2IKZOkzOLoy/l487iKaLK6efG/CDUkQ9Eo4C3ZDxLtquTdEwLPOQhfxxgP/zUwPpG8CFHvwsY+SjB5gCGSZJ/vBSlgDpnEx2PoXh0U5kCkwUR6UKqwi+xWm9UjmJ4TJ/MieeoKEC4mnYYrsI5sdLBQKl2fbAdmoh+iOORCXR3JOBDfAOQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 848eeb2b-4425-43dc-7a06-08dac96b067a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 13:44:35.3108 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GHa/ZQzYWkzfNiU+iq4s1Ce+Z6PfmPXNje4vZGdBu2qEzCFX1D3dVBxF+Nh2NlJmvj7kDPv8MZ4nNwOe6a7pGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR03MB6245 On Fri, Nov 18, 2022 at 02:04:40PM +0100, Jan Beulich wrote: > On 18.11.2022 13:39, Roger Pau Monne wrote: > > On one of my boxes when the HDMI cable is not plugged in the > > FrameBufferBase of the EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE structure is > > set to 0 by the firmware (while some of the other fields looking > > plausible). > > > > Such (bogus address) ends up mapped in vesa_init(), and since it > > overlaps with a RAM region the whole system goes down pretty badly, > > see: > > > > (XEN) vesafb: framebuffer at 0x0000000000000000, mapped to 0xffff82c000201000, using 35209k, total 35209k > > (XEN) vesafb: mode is 0x37557x32, linelength=960, font 8x16 > > Interesting mode - should we check for non-zero values there as well, > perhaps? We could, yes, I went for what Linux currently does, but a height or width of 0 is also likely wrong. We already check for bpp != 0. > > (XEN) vesafb: Truecolor: size=8:8:8:8, shift=24:0:8:16 > > (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) �ERROR: Class:0; Subclass:0; Operation: 0 > > ERROR: No ConOut > > ERROR: No ConIn > > > > Do like Linux and prevent using the EFI Frame Buffer if the base > > address is 0. This is inline with the logic in Linuxes > > fb_base_is_valid() function at drivers/video/fbdev/efifb.c v6.0.9. > > > > See also Linux commit 133bb070e94ab41d750c6f2160c8843e46f11b78 for > > further reference. > > > > Signed-off-by: Roger Pau Monné > > --- > > Other options would be doing the check in vesa_init(), but that would > > also then apply to other framebuffers and won't be strictly limited to > > the EFI fb. > > Well, zero is wrong uniformly, so it wouldn't seem unreasonable to > put the check there. But I'm happy to keep it in EFI code for now. > > > We could also check in vesa_init() whether the framebuffer overlaps > > with any RAM region, but I think that should be in addition to the > > change done here. > > Indeed. > > > --- a/xen/arch/x86/efi/efi-boot.h > > +++ b/xen/arch/x86/efi/efi-boot.h > > @@ -552,7 +552,7 @@ static void __init efi_arch_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, > > bpp = 0; > > break; > > } > > - if ( bpp > 0 ) > > + if ( bpp > 0 && gop->Mode->FrameBufferBase ) > > { > > vga_console_info.video_type = XEN_VGATYPE_EFI_LFB; > > vga_console_info.u.vesa_lfb.gbl_caps = 2; /* possibly non-VGA */ > > A few lines up from here, just out of patch context, there is a > PrintErr() which imo is bogus/misleading when also encountering a > zero fb base. I'd like to suggest that you put the new check early > in the function (perhaps extended by a zero check of other > applicable fields, as per above), returning right away alongside > another new PrintErr(). Would you be fine with the new message being "Invalid Frame Buffer configuration found"? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Nov 18 13:56:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 13:56:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445782.701159 (Exim 4.92) (envelope-from ) id 1ow1qM-0005eF-OD; Fri, 18 Nov 2022 13:55:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445782.701159; Fri, 18 Nov 2022 13:55:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow1qM-0005e8-Ke; Fri, 18 Nov 2022 13:55:46 +0000 Received: by outflank-mailman (input) for mailman id 445782; Fri, 18 Nov 2022 13:55:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow1qK-0005e2-PW for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 13:55:45 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aed5e5be-6748-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 14:55:41 +0100 (CET) Received: from mail-dm6nam11lp2172.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Nov 2022 08:55:38 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SN4PR03MB6752.namprd03.prod.outlook.com (2603:10b6:806:213::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 13:55:35 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Fri, 18 Nov 2022 13:55:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aed5e5be-6748-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668779741; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=0moBXfh8fpbTkG1mYrLvjYi1lqCkiTUgpCg4+pD83XU=; b=VZ4xaDW1TT5mQo4sk1MVTqpkCLGk56UkP/rCBhDIZt1Jgu3rW5xl5PB9 hSq2ivwIlxiSeA2c/dqtcGODvej02aRyJmOlqW5e2uq36NJMuwFMUBX8z TPQ52k+EJLrmM72SEMt7/SodiDFuimS9mqPH9udj16yMnNQ5IJuG8CtCb o=; X-IronPort-RemoteIP: 104.47.57.172 X-IronPort-MID: 85537105 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Pz3M8KiDkau03NbcyNgVI+rOX161VREKZh0ujC45NGQN5FlHY01je htvCjvTOKqOZWDyeY9+aIizphwE65/Uz4RiTAdq/y0zRnkb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QaOzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQpMgotZUqlnN6U65KZSvNSnNV8PfLkadZ3VnFIlVk1DN4AaLWaGuDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEuluGyarI5efTTLSlRtlyfq W/cuXzwHzkRNcCFyCrD+XWp7gPKtXOmBdlNTeXlnhJsqG/KwzACE0xIbGemreWHh2OhZ8BBM UNBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQMQvqcseVTEsk FiTkLvBFTFp9bGYV3+Z3rOVti+pfzgYK3cYYi0JRhdD5MPsyLzflTrKR9dnVaKw0Nv8HGipx yjQ9XdkwbIOkcQMyqO3u0jdhC6hrYTISQhz4RjLWmWi7UVyY4vNi5GU1GU3JM1odO6xJmRtd lBe8yRCxIji1a2wqRE= IronPort-HdrOrdr: A9a23:KngGR6PB7gAmIMBcT6H255DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa DskPZvln6FQzA6f867Dn4KU6zqoMDKrovvZVorFgMq8w6HiBKv8frfHwKD1hkTfjtTyfN6mF K12TDR1+GGibWW2xXc32jc49B/n8bg8MJKAIihm9UYMTLljyevfcBEV6eZtD44jemz4BIBkc XKoT0nI8NvgkmhNV2dkF/I4U3NwTwu43jtxRuxhmbim9XwQHYfB9BajYxUXxPF4w541esMmJ 5j7ia8jd56HBnAlCPy65zhUAxrrFO9pT4HnfQIh3JSfIMCYPt6rJAZ/mlSDJAcdRiKobwPIa 1LNoXx9fxWeVSVYzTwuXRu+sWlWjAJEhKPUiE5y7mo+gkTuEo841oTxcQZkHtF3ok6UYN46+ PNNbktvK1ST+cNBJgNStspcI+SMCjgUBjMOGWdLRDMD6ccIU/ArJbx/fEc+PyqQpoV15E/8a 6xH2+wjVRCO34GNPf+n6Giqnv2MSeAtHXWu41jDqFCy/zBrOGBC1zHdLgs+/HQ0cn3TPerH8 pbA6gmc8MLHVGeZ7qh4DeOKqW6CUNuJPH96exLLG6mk4bsFrDAkND9XbL6GIfNeAxUKV8XRE FzEQTOGA== X-IronPort-AV: E=Sophos;i="5.96,174,1665460800"; d="scan'208";a="85537105" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZWDHxrxxFMQdTBKhUSztP0sl+x6MtBu1g0owkKZe1astjB3O+N0OqS+o8nq40m7JseRR7XCfgF8CLdaNOUS3hczONB+O4C4JQYewLLLXsp14YHkx2VohYwWXqwVBPM212oEyQymDZQSfta64lNFiGicE0wBg4cM+9iRA97btwQf6D+99g6eq8HFav33NlmNjfWogvpJHwZqJHInnsSR2ahOAdiEvWjtWvEDColWomHEK5gBPzUSqjn9VkBJKTXSiRZAPpDgUsVOQdKrkHd3eCeR4YHezFlJtgjm4WRLhKR6MX6WzHiHIJWNZBznCSnH7lmc4ASRq4Ro8r5CB9ei4sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0vH3u6snomVKL4Rux0jqMDKm9vJjDe0uNRBAXmfFJu4=; b=Dxz+VaX9rLx3x2biuuUfgN2KMIuTEoL/D9tNfTWVjBw3aCLL3ndE5W4pSfbV4AmwuvqParEkGMUZ2XxZdo1L6LgBSBOisrzuVw80Hvg7Gr3kmvq9bKNg7D/fSIwm0XAPboWfWDGu/w1yVbPym2mf18xc3gXcoZq6S1uj7xQK4ovBZ5VhUPlF1Miyd/JLL/ZDjFztRwRFP0zIWq7hbldvJVTdTVwW5mwd+8y/zEmCfKrP4BuCuC73KCknyURsCgwk8MfQXPS9VezY9QSlxtM7mY81kepNlTxLWsyCcaJzByrFgQySz8BeAH0dH01DpysU1wLe3fntDgiU//K3OLvB6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0vH3u6snomVKL4Rux0jqMDKm9vJjDe0uNRBAXmfFJu4=; b=IifXmDu0wXQlIQp7ruLWN1kfn2hSGHS1JQxbcV4EQrvUMsA6wSuyHCbwwySdJ5epJPtsraaGFrdn1k6p9i5C5rbjpsKqv3hsw9VSq6Jn48r5260e6iKdUqMJXn7w0I2VholMkiczi1W/84CVP/xdorZ3dpkRjxZELYPoPeibHJU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 18 Nov 2022 14:55:29 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Message-ID: References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> X-ClientProxiedBy: LO2P265CA0071.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::35) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SN4PR03MB6752:EE_ X-MS-Office365-Filtering-Correlation-Id: 6eaf47f5-b059-4d3b-6a29-08dac96c90ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P6BEni3FMS559RZrv+5DZuglLmEL0DdDNj8q0NZN5fVQEp4nlQIyMHjJzfIUePi3kvgZESfSgNeV/bg0FsjMbGq1G8bALJidcsBNx4j4pDvvgrqkhGmPl/1EwxVXLroPu1+4R9chT4p4P6vCLL5Ta60k5//fHdeSaJWE1jY7cUgsZ4cC3ad9IgU5FtNFl/acQU4KxyKamS9eMSjp/nJv9hsCT+X5luSfNxfMfANPRF6CLrD66lkN4gGWVSnZbI8Amuil+sEmzQIB+ww9JRGLcpl7y6yZx0At2Nq9qQiosVCuts+pnULX1jnryrTi1sb9RUNdxLjpqIXnBeYxlGSTezyMFRBa0HkoiVj3crgoiHrah09nml54xlFaJ5MnT9/lvrnfFu2NQKT5L9JRoue1iQYu2bXXSejqAr009EcSS11jG4wBdv1kyz8Pvpz95jWEIMZV4rQN0vJQef3MduRtx0UDFR+zrfswO2lKVdUnIbHveX+UhI4n5hAKgL4yHqq+fgpRIfJ6PTgkuzR1tzDCJwvHY9l+4s8bYJAgfeOkZ06/3W6XYQh9xRmmZhHxF1os5y5BHP2qageMSRXxgEkvz3vfQITefAevIE7J5fwEGR/6EeVUnnd3cH4Vx2BbORlDrxVkAtHnGih/JRkJ8eeh5Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(366004)(376002)(136003)(396003)(346002)(39860400002)(451199015)(2906002)(83380400001)(85182001)(41300700001)(5660300002)(8936002)(86362001)(38100700002)(82960400001)(33716001)(316002)(6666004)(186003)(54906003)(53546011)(6916009)(6506007)(66556008)(66946007)(66476007)(4326008)(8676002)(26005)(9686003)(478600001)(6486002)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzFJY0pTM3EzZ2dodU9wK1Iwbkwzb0c5V2JEelZ5L1JNWjVDZUJ0cjdXY0RT?= =?utf-8?B?V1paU2FkZE1zcTVBbTUyckJZa1hPMURZVklmeGdTZ1dhVXd5K2lCc3hvN2Js?= =?utf-8?B?SVl3Z1lKRktzbGtCZjhSc2RHeWlQS0ZicWMzS1NMT0sycndIeXpHVGlhMGtu?= =?utf-8?B?a1BBRmVNRDQxTW9FS3QyNnA5bXEzSmJyL1N6U1RaVDV1emExV2EyU0VXenM4?= =?utf-8?B?SHJtQjdPM0d3L3J5SFFGWExVNjJqcDA4U2pkRCtWUWV0K2F3VDBCRzVIVDZQ?= =?utf-8?B?SmlzdzVjRWdBVk9zbnBac1ZIbC9mS3NFNk5YTEttaFRvRVBuV0dpTG5GeFU0?= =?utf-8?B?NjZTaThreWZGZGdHYUYrL2poblRTaFVBYVF2WWNnMDYyT2RoR2s1a1Mzc29O?= =?utf-8?B?S25aZDd5T3BubmVnTGhjR3duQnRBZ014NVpUdENWUFBpcCsrdzhsYVJNODhG?= =?utf-8?B?OHIxbS9iN1Q3OU9KSkc0d0N3ZWJtbUtiOFNVR3NQY0hYK0tPUDZKcWp2eUZa?= =?utf-8?B?SzZwQ0MzVTU5SzdaMElYNXhzNytXbkkra29rSzMrMzlmWU81VysrWjgxdjJn?= =?utf-8?B?YktLc1JBWWxJdStOTTBLaW9ZUS8vdDBEeWVqNC9ub0VldmNucEpJdXhoS2dT?= =?utf-8?B?VmNIbnp5YWNUQVVMYWNVZWtiV1JUN09sWUtmVEZuRTdmeUpIUnFqNVhaTmhX?= =?utf-8?B?MzhkMEN4MWNXWjRrQnVWV0FoR2Y5UHRKUkhwdjkyMUZCS0daSjdLbmZuT1FO?= =?utf-8?B?eUNkR01jditkRWtVWmZSVEZRQ0FGWW9weVNMakV0blZuUUlzSXdWaUFoVEFk?= =?utf-8?B?cXpGTGtKb2ZXWXpkQ1RCTmNNTW1YM2ltZFMwUld5K1ZpbVF3YUdQaFRhT2di?= =?utf-8?B?YTdvT3FDM3NKMnowSm05TS9xTzJhQmNTbkY4a2R4cXNEcWp5Q3RxY1JzSFJZ?= =?utf-8?B?M1R1a21zSG5tR0NGZGY2VGlJSCtiTTd2ZUhjbTJPMFdQUjJZV3AxRFhJRldX?= =?utf-8?B?ZG1mMzllQm12RlBQdnZ4SExxSEllWGxQZW0rSGl4ajBCT21NaTRzYS9UMW8x?= =?utf-8?B?NmdEZXBJVU5nSWFLWWQ3VE5YS3ZSdmlwaEFYT3Nvd3NVR1NVVGttbjQxaWpz?= =?utf-8?B?WFB1bXhKcFh6c0xJb3dUL3p4aWdOb2JwTlNOZHUwaUo2d2J5UlVOVk81UVha?= =?utf-8?B?V3ZvUmdsdVcvbVdTNVdUcTFQQlVpTmxlRFRIWVhRTVRWUGNpc1pCeUFBaS9k?= =?utf-8?B?bzZyUWZ5a2thZmE5STVmd2Y3WmNlSGZCUG1rSFNSRXlqRzhEN2h2NEQ3R2kx?= =?utf-8?B?bmxxL01xWGpNaEdyS3NpR0h3cFYvaEVOL1o5aTdKTWtBRkVTdE5hc1orQmJh?= =?utf-8?B?S0gxbWhvbjBUakF5WEU0YzdUUnpSeTFXQk41eVFTSTJLT1F2TExCU0MrdmFp?= =?utf-8?B?VUEvOWJPK1Q1RlVSaWtqaFl2aVFGbVJ6RXA1Z2NJTmVUUkxZY1RHM3YvdWJB?= =?utf-8?B?NmYxT3NaTUNqVUFheTdYQzFqMElDQkFESTBuSTR4WkpuNTRkWENaMGlVMi9y?= =?utf-8?B?K1B4ZkNwL256S2ZMMTBySjZpRm1iNGFzNmlLQVZhU0lVd2p0d2hJOW9iL3dI?= =?utf-8?B?SEpSano2bHVXUmNiN2d1ekVSU1lnaG4zTWl0TjltT0g4QVROT1pqYXNXT1JV?= =?utf-8?B?VC95dHdxN0ZhTGV2TWRhVzF4ZDdrY3o3VGx0QUlBK1pET2w0TEE2R3FINUJX?= =?utf-8?B?UFZKV2NqYzZFZW9JUzN3MnpXUnJwOVM5dnJubEQ2Z2hVcVdaWmh2NlpEdDZ6?= =?utf-8?B?T3QvRVBIRnFONDlabzExd3VpQTJhd2dNZ2dNQVF5RDRvbFhkb2Q3d1dacERq?= =?utf-8?B?ZFZYMUtZamdXRnRtQk1raGRSLzVBVFBHSXU0Z1hnS1JWVjFHTndaUGt3R1Ev?= =?utf-8?B?VTlZVXVOdGxqSGdmUEFteGR1UE9WNUNFL0tjM1g2TVdJS3doaUg0V1ZZcnhv?= =?utf-8?B?dDM0WlZVZi95ZUVOT0JRRVVYY0t4U0Z1QkhEaDJPa0MvdWFVQy9lYXRjdVRz?= =?utf-8?B?SFpwdmhnTnhkWUlmZG4zbG9UZUZkRXhLdHNSYTk5clp4RFYzUnN2eS81ZUgx?= =?utf-8?Q?oRxfNXihweJceh/OJXMYnHSrM?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: vAQ7huP8+PmgqjnKo/eFl4VvzXkLv8oxUxwum/0ZrLCziDce6H+jJ2U3/xH5T2/1sbrNgbwgpQex4127qQ1wL8/r7WHQ1NCUkvWpxpJwoEe9wvvW7eyP5KpTlZTt5nDmSeSAhwaC64dJLgVTpYzx6Cet1HtL4YopeS2UPFDd0F3yobpPrhRzgdP3cNwgGguLZbw89HYApx1C+3VjdV9HP/MKYQhUEh1dceVle6Ll0h/RUJQmeXj+ph/BtcVgxSjLg11DNcGtB3lpPVAhI0Nbhl1Pov3E8v2vtdObVm3StaprC7m09KIw/sR3opiCA2Nel/rjlQep3lwnVOsJrTjZp2wHkinWMJyhXO5+gHOhP06qqUS4LjtoZfEHUtc1UYr9tNMYVRxS6RpkTJhabR01wjTYcqdJNpd+Y973kTnRhPL9PmIfHB4UK5vjmFeQt4qEHULWInyEVBlDYvu2V5QpeG2jrwbvnKcV9dBkFEcIpbRbmemnr6SjIPQnB6P5ucfkdVcUJCj0siBJ9uWUosTyBu3VjxczRwkkTEWGGpmHT299pcfSz4OEng98o8Nw/kILa1Mb7vTHMvZKOXrnAvsZKKOeL+V4HxtvNXfnAf+RqqqUoiA/suU1lj3LYBypoRf9ZiiCQg3oD/ceURV+wS1FA468U09LuZivyUydmGy9fPRv1GSxLz9SmFJwsPquIRdK2SBzfGk0kDKdeVBzXvlYtPcZoGvyFTdntQyOsiu1xReEEyLjfZ9B9K2Y/IbkHPCe+73g7C+oNoNNAeqM4E8GMAnD61cnhxTnoFLy58SiaHzPachX4Fs6/rUeQ+653L8wC9+C7XcbIykTQv3QE3sflH5OZrlT0fSQjeVcJIPhH9E= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6eaf47f5-b059-4d3b-6a29-08dac96c90ff X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 13:55:35.5640 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K+6SxyH+CNqvEdaANgOFQLe8Y5e1yEIa4Gz4vIYYHprN3XTlmoroE/sNad7aSPKYBOYg7EF25phm5W+g6LyFcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6752 On Fri, Nov 18, 2022 at 01:54:33PM +0100, Jan Beulich wrote: > On 18.11.2022 13:33, Andrew Cooper wrote: > > On 18/11/2022 10:31, Jan Beulich wrote: > >> Linux'es relatively new use of HVMOP_set_evtchn_upcall_vector has > >> exposed a problem with the marking of the respective vector as > >> pending: For quite some time Linux has been checking whether any stale > >> ISR or IRR bits would still be set while preparing the LAPIC for use. > >> This check is now triggering on the upcall vector, as the registration, > >> at least for APs, happens before the LAPIC is actually enabled. > >> > >> In software-disabled state an LAPIC would not accept any interrupt > >> requests and hence no IRR bit would newly become set while in this > >> state. As a result it is also wrong for us to mark the upcall vector as > >> having a pending request when the vLAPIC is in this state. > > > > I agree with this. > > > >> To compensate for the "enabled" check added to the assertion logic, add > >> logic to (conditionally) mark the upcall vector as having a request > >> pending at the time the LAPIC is being software-enabled by the guest. > > > > But this, I don't think is appropriate. > > > > The point of raising on enable is allegedly to work around setup race > > conditions.  I'm unconvinced by this reasoning, but it is what it is, > > and the stated behaviour is to raise there and then. > > > > If a guest enables evtchn while the LAPIC is disabled, then the > > interrupt is lost.  Like every other interrupt in an x86 system. > > Edge triggered ones you mean, I suppose, but yes. > > > I don't think there is any credible way a guest kernel author can expect > > the weird evtchn edgecase to wait for an arbitrary point in the future, > > and it's a corner case that I think is worth not keeping. > > Well - did you look at 7b5b8ca7dffd ("x86/upcall: inject a spurious event > after setting upcall vector"), referenced by the Fixes: tag? The issue is > that with evtchn_upcall_pending once set, there would never again be a > notification. So if what you say is to be the model we follow, then that > earlier change was perhaps wrong as well. Instead it should then have > been a guest change (as also implicit from your reply) to clear > evtchn_upcall_pending after vCPU info registration (there) or LAPIC > enabling (here), perhaps by way of "manually" invoking the handling of > that pending event, or by issuing a self-IPI with that vector. > Especially the LAPIC enabling case would then be yet another Xen-specific > on a guest code path which better wouldn't have to be aware of Xen. Another option might be to clear evtchn_upcall_pending once the vLAPIC is enabled, so that further setting of evtchn_upcall_pending will inject the vector. I'm worried however whether that could break existing users, as this would be an interface behavior change. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Nov 18 13:56:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 13:56:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445787.701170 (Exim 4.92) (envelope-from ) id 1ow1rD-0006DZ-5A; Fri, 18 Nov 2022 13:56:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445787.701170; Fri, 18 Nov 2022 13:56:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow1rD-0006DS-2J; Fri, 18 Nov 2022 13:56:39 +0000 Received: by outflank-mailman (input) for mailman id 445787; Fri, 18 Nov 2022 13:56:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow1rB-0005e2-GD for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 13:56:37 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20619.outbound.protection.outlook.com [2a01:111:f400:7e1b::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d06a9f14-6748-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 14:56:35 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8805.eurprd04.prod.outlook.com (2603:10a6:10:2e0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Fri, 18 Nov 2022 13:56:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 13:56:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d06a9f14-6748-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WdGYqp/6JtNSAqrNYxcYiab+gq4sDzdCA2wTqybHoZY0v9E9KtyCUTNUx5Q3f+6qLj4fl3yaiXbAD+w7BMlEEGeZbuZtP+7RDcdEGmI3GIIID1xQdc3BdJ+gsX2+CH7FiWHizKHqWEJgjFkc62P1yvKRH6R8KirsFI6b4ZDfGycUjW9aVzgD18hQMhf80Xvgd2EPQD8uJ9M4eYGmFDDvYpma3EYzE12DM7HJFBHLtAcK/RoLhqUU1dt157ruTJdcghf4NWXVdI3XSyzIOEXTEJkNkqHJ1e8vtLYOaZTdf7P+JtgIqFohjPhCdDpBNeoS8sTikWhbENnETX5mgjBN2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=15/mCCZo8iSZ2OCYInkPQMMZKDWnQCxH+KVsa63G4MY=; b=cOeNQQIGSifTn06GBECtBpTPGjkaYUgsGM6LjrLcKOi8zRg3FRQxSjqKDyH7Wr8xrTIvcX5cfmAUUA4WYyGi64JdH6OmsPYnKRVw1aGa+RDG+KTjq6KHLwz/6T+yErLjaBODA3picCtzgbWQvVc/hTEj3m5JPww9bbsa+oexUF6d/D4cka6YALJVTwqVfPZSALVcyB5C4Qn4Fpv0jcGOvbugi7PYl72wQPJYRd79RLlbEShjfOp4pny+IHQj4YAu4p24+Eg9H6QYUoEGoczc5ouqzR2wEqewNUnonCrNXWRsKOl0d5CQJ2DHqij+9V2A1wGQu/kB7npNld9UhJS2sQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=15/mCCZo8iSZ2OCYInkPQMMZKDWnQCxH+KVsa63G4MY=; b=fB1gwwjrY/Y5hFG9ZHaxKP5GX+7ZSDSiEcXBtDQmfHQAJumUAcLg+1fU6G3JBtuH4lam7CQl8egxiB/jg1U0QZVqUJjmBTj6y2U42WwgcKkToZYni6pmdhTX5CKqaHYDEKnF+Di2gjlo4eNNeF/D55JFbn80ijjLqO6wtKOnSNvmChDfkCygNGJNlpWzdYWCNav52rV1/2pmcZToR/r3An06ZpBMrFFrTDSiTRzrvDNVV48PloS/XwNImFkyYLzyuSE48ydhBPGSeZPw9rNnZwA3m3xExoyLRyjtKlGVGtOtXhQ+PXfbukLWh07uLMYMlwF+xiDP3mlYOJ5xUcQwsQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 18 Nov 2022 14:56:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] efifb: ignore frame buffer with physical address 0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20221118123925.25363-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FRYP281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8805:EE_ X-MS-Office365-Filtering-Correlation-Id: 9deb2a66-a716-4a88-daf0-08dac96cb422 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MuSTYN3WLcS/xx2pTuL/wdFbmVSdQc8y+M9vpXqXtm/0Bxe+D3dxSuofDPjfonDQCgu3HVElKKhhS3YZBPEcUrCDQevl0HQaryAS8flggmmYJLMVIiJBUXYLcwGpb4FMZNV+IhOj7kA76vI888oIgVcWTNXhfoNKhscqzU57zv9JFAKSkVDHjSfRsPZ2WRJJy1B7j+P3vGzgkgqKPQWfaDdBDhxh0XTcqdUzwAEkvsUOz8kSlH97WO4vWV/QYuj9ameQhuCbsTX6tK36Hm3HskLHbt93SXdiZ11srQpqDrq08eVPH5Cy4FzcBhx5xVPOZ5yzTkIG1HWOYz5aW898VeL1myRXFdTDBIf6+vfxwBjExNuZMCeWJBmh/C3rO4lomBzN9wRcPF2jND8NqBKSvxi1QPoAs7OcM3i7g1nxrU+7xbaH0kw2+P8VTX5BgiUG49xGjABEevxA5i26SL4jHsfNxhNtURoDAe5jpZAfEP9rYFIntREbSO2f8LpjjEvKeGTilbQIMf1Zzl43FMXbhcQ0AYeO8yamuqKWgWSS+7vjtYX53szmvS6eodi0+B5o87I0cAqN3qrJPQX/6ZIchtZZeEUh3hcfHI10C09hhZWtRM6ZWPEjXYBJo+le65D1d2kKcAm8ezX1E7rJPC6LQ+QXq1KepZs5QWolWYvceWoWfL7Gzvmlz8u8tKnBPyzMHTryoBc7X5xKrSwfhbUcgP/XV6I8hIBKRs2+VG29l+A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(376002)(396003)(366004)(39860400002)(451199015)(31686004)(36756003)(31696002)(8936002)(4326008)(2906002)(38100700002)(86362001)(83380400001)(54906003)(186003)(66556008)(6486002)(6916009)(316002)(478600001)(2616005)(26005)(41300700001)(66476007)(6512007)(5660300002)(8676002)(6506007)(66946007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlhIMUY2Rk9hN0tkalROcGlReVkrUG1KWll0QVFkRU1EZjh1cTJjcW1MT0pG?= =?utf-8?B?RU05UUwvREdNaFhRelU3TmppenNTaDZkSWlXcUpnQ1JMeFZ1ZUZsUGN1eFh4?= =?utf-8?B?Wmg4L3BZaTdHenF6MHVYTTl0cUpiSmFnaEs1YXpROWtKUVFuWGtDYlBXcWkv?= =?utf-8?B?NWVsVHZuUU5CS3ZSMlFzdytjOUtYNmlGNUErMTlPVTVqV0ljakFKK003L3Q5?= =?utf-8?B?c3Bxc0d6SmtDazFWQ3MrTWRaNWppZ0kvZlU2Vm40d1BMSlRxTnkyWDRzdkth?= =?utf-8?B?WEtLZTFJUDZRa05wbzNud1EvNnp4VDBwMEdjSzRHWU9mc0loMGlvc052SEZM?= =?utf-8?B?UmtBaWtPUFBwa0w4K1V5MXFHSnpQVHkrczdYZy9MWEdjQ24wd0NkUjhGSDY4?= =?utf-8?B?Z1djWHpRUTdxc2dSV0JOZmpsS05SVFd0NGhiRm8wOWMxTXpvUmF1T2RHZE5z?= =?utf-8?B?bmxBQTNqSUtSZEVLSS9EQjZFbjVZcnU3SVVDWmhlUjNVdVJTQzZTcVl0SFlu?= =?utf-8?B?bFdMREgxeTVvZi9RQUtrWFlrOFB0dTJmM3ZiVlBaMmJ5UmZ1U3NpWDg3dU9r?= =?utf-8?B?aU1UMFdnVGcrMHQwK0lCbUx5eEhtL1pNYkpPeHB5eUZjSE4veFo0aExCbUxS?= =?utf-8?B?OFVObnB6RGVSaEphMFJsZWo2R3BvMC9BZkVnTlJsSFJnTTBoYXlZMWpyWE5r?= =?utf-8?B?OUUvTnBYQU9scHF0VDZjcGkvV2RDOEhUZUtKVnFvK2s3V3o5ckFzK2hnSGNS?= =?utf-8?B?VlNZZGxZV0lONG1ScVZTUTJjaUg0dnh2emNTNkxDZHNnYTV0Mm9WR3RZWTMv?= =?utf-8?B?a3U1WVhTWEgzUE9hL2VpSmloTkJvWFp5c0VnY2czbDFHbEJaUzQ4S0ZsTXZF?= =?utf-8?B?Q05VcDJQdFVMd0MyVXlXNFViUGtqVFdJMWc3YUdXbW93elV2dVc3SCtickI4?= =?utf-8?B?TEJpd2k3cnI4bklSdXVnVHpjRE9lRjQ5OWhFdEF6TXJ4Vkdqb2tORDBFbVIv?= =?utf-8?B?blIwMUUxZEZ5WEd5d2JibUQzL1dVdVRIQlVlRGdHR1lxRTM2dGE1d3h4QVBJ?= =?utf-8?B?cmdGRFZNa05ZYmtzY3htaTRTMjVIbDk0WHdxenVUZTArVVBrckJOWUhMemVm?= =?utf-8?B?WTdIUDFOR1g0VEt4VEdUOFpNUHlzQ1A3YTJPWkYvTStFV0o5YkNFRlFtZDFw?= =?utf-8?B?LzkwK1VRYVllRjdONVpLMEdvSHBpdEJqQ3Y5RlZocmZHSWFFN3RoeFVITlp3?= =?utf-8?B?ekNrMXNCZ3cwODVib2RsU282Q1AvekpRcWtsRzU5ekVvSkJ4L1VJUG5wQ1pU?= =?utf-8?B?ckU0NllYUFRxZEpaT3p6UEsvdmpManMvbERoZDNOQ0Q1U0ZnZmo1TVpGQXZF?= =?utf-8?B?TUk4S3Y3NGw3dGFSNUUxeGtDUEFyUlRUY0JmMThVUTlzVy9ReWtBN1RmbnR0?= =?utf-8?B?Z2pTdVUrRG1ManVHdWExck53QlhJTFpUa3JtSlhPbHROV3E1TitsU0ZybDB4?= =?utf-8?B?Mkw0N0NaNGlMU2NobGFBNTZ2VWRudFdjbGtkQXBKcGNMWEU5NUZEQUJabFZa?= =?utf-8?B?K1JaM2xRRTJ4QzYvaWtKWTRNNjVVc3JueVVYT3pWazhEWVZ4WDB4WGE3QllN?= =?utf-8?B?dFNjMEtQU0ZRMk1vdWVlMVZJcXRzM1AxbTFydGkybWxvb3FQZEI0TVJ5R3Jt?= =?utf-8?B?Q3krbW1zem0zeHpydFora1laSDBtVmxnS0RFM3VPMTMxb0dXanhHMkoyUk9w?= =?utf-8?B?N3Bqc0lnTjR3OW9iQWRXS0hNeDAydXRmd1ozeVRiSCtsY0VxMFRRL250Yzlm?= =?utf-8?B?SDFQZE1ka0pqaFhMNHhreWFmNHovYlBVZ3d6YUlxREdLcUZ1UU53dnBKdFRw?= =?utf-8?B?T21JS0d2M3RxVXFhenlDS2ZHNnUrcU9mcjhpcVVDOHVROHEwNk8vR1BlNzht?= =?utf-8?B?SXNCZXhPN2J5U1J4Z3dPYysrbEFBdG13YWlHOUN1Y2JmTnAyQno5bUpobk40?= =?utf-8?B?eG1zUlpVdmJsNklIdGxKU0c0T0ZyaktvZW40bVhhNmxFb3Z1QWJYMk5JckQ5?= =?utf-8?B?THloV25OMjA4YUpWNUxoWWVLT0xXM054N3ZJVzdIdmhxaGw0NWhvc1RVSyt3?= =?utf-8?Q?8vHAgvrA0gVM7RBZsElt79Cpu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9deb2a66-a716-4a88-daf0-08dac96cb422 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 13:56:34.3743 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6iljPuAtfHJmAugbeZBipuM4A6fu6WDFSYdllKnxGovd1Jr7Qw7RTINsTI1RJwJ9MmiNd0dnz71KoudFe8yU+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8805 On 18.11.2022 14:44, Roger Pau Monné wrote: > On Fri, Nov 18, 2022 at 02:04:40PM +0100, Jan Beulich wrote: >> On 18.11.2022 13:39, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/efi/efi-boot.h >>> +++ b/xen/arch/x86/efi/efi-boot.h >>> @@ -552,7 +552,7 @@ static void __init efi_arch_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, >>> bpp = 0; >>> break; >>> } >>> - if ( bpp > 0 ) >>> + if ( bpp > 0 && gop->Mode->FrameBufferBase ) >>> { >>> vga_console_info.video_type = XEN_VGATYPE_EFI_LFB; >>> vga_console_info.u.vesa_lfb.gbl_caps = 2; /* possibly non-VGA */ >> >> A few lines up from here, just out of patch context, there is a >> PrintErr() which imo is bogus/misleading when also encountering a >> zero fb base. I'd like to suggest that you put the new check early >> in the function (perhaps extended by a zero check of other >> applicable fields, as per above), returning right away alongside >> another new PrintErr(). > > Would you be fine with the new message being "Invalid Frame Buffer > configuration found"? Yeah, that'll probably do. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 18 13:58:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 13:58:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445791.701181 (Exim 4.92) (envelope-from ) id 1ow1sn-0006ng-GS; Fri, 18 Nov 2022 13:58:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445791.701181; Fri, 18 Nov 2022 13:58:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow1sn-0006nZ-DK; Fri, 18 Nov 2022 13:58:17 +0000 Received: by outflank-mailman (input) for mailman id 445791; Fri, 18 Nov 2022 13:58:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow1sm-0006nT-9P for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 13:58:16 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20609.outbound.protection.outlook.com [2a01:111:f400:fe13::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0bc4e246-6749-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 14:58:14 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7793.eurprd04.prod.outlook.com (2603:10a6:20b:240::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Fri, 18 Nov 2022 13:58:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 13:58:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bc4e246-6749-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CmHxRwJlI3ohLxM27CVTI9bihfceapPmYGGV3t/uVtjse1ZwGYxLc0UXKjmjHQvlQ0oI2mvrhTzzLvf5my2tZp7GSsO0991j1ECEzNpx7Q327oC1UPil2OyjRCQ74LSEvvPXubih9x6vODLws6j8+iFUqliXaWHLAmym+7Al0XX6YQXL/2A1Qa+QYfKgyoIHuGbFNtTTEOiUcqz7CjQ5/hKJs3ifLPbzQrBOXjFstqkZ9PQMUPHlgx+KCYg64L66hSaBRlfuiNoQcR+IDcJ2QbF/g/MCelN6aK6hU2NhTZXSn2TR360Zmm48YHPCkVdbBChB2pe+8vdojj0m777STQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/od3HOrDwIzV/8AvZpDoF3peZnkN8EfBKMO+v6kT9aU=; b=ARoCGF3rE3RI+1IUZ5FQEYKUx5V+WcoPlap9DzR1QPxvlFCaT2MLGwSwbQSVGoe7ZGjfrwVRtE9f9TjYhTY/wEKQH7r0LaEpoJjGtZfQTyQARMD2M1Xll/K7NHPrjNTBG6AHGBojDY/85RaI1x/FBGaW8wt4t20SOBsGOCiixVPSp+CiQ1/5YDl+R0BfRp4akuo43ACmI8w+W/T+4+WUi3lFvixdVsgVTprrlgVpxCh8Tiqa9TTrxWJcCtQ4D3iKctr/Lfta8t6b+bST4w6Rg9N2VI0lF5xKLOTymQnOazngba5P79BbSU5+2u4w4C3jzQp8LH8fczzAXyT51z2dWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/od3HOrDwIzV/8AvZpDoF3peZnkN8EfBKMO+v6kT9aU=; b=E43v7tWO6haw6+rMvxu36sy8HgUOtPN1uWSXA979GDxQjQSvpvMI2mkwFY5aZlIMQD3DOV17j/bGt+fgAyO51kd8tSoV5IM9Gol1+/gnltfyQVvHBxPuGZkx8DQ/SjQAGmFlW62RWht0nGj/0H47mI9VDlfVcDc58PMezhfgKoOZPIZSu1DJvvpnxskz0ZKoJLr0iCssmI1sdn71ZmEkp3Io3w7qWXevoHf9n8I8QRQtfT0wD5MpMJiMo1RYL1eYpSK8uoZcbhnChHPU+4IMSP96JjnVav3Q1W9T2jfYGX5v23IEt6QdtYBSECPg1NVQ1EBXicg3j9o88JItYnPaGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 18 Nov 2022 14:58:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7793:EE_ X-MS-Office365-Filtering-Correlation-Id: d7036e5e-2502-4ef5-6a5f-08dac96ceef4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z50NPPSTSJv33OvW+RbDoBFtGBWjmOSHcffpt7YXVIn+maED3xVKzFjKaE0VBZzac+GB4+vTT/oS3VitMm+lcYZzCB9xvvMg8xTnrF2XFl+5OnVrpYrfcPaf79PZkZSipROn8561/i1Xkq0GULiWAFsTul3r+w5DdkdK39BFUl6R9sdjq1gmhsVl+yX2Cm0LtcDfMLRJ7Wc7h9NEZKWStzNyXLIgB34UI0dhxIOAiTG8Y5Exqb1AiuUSJVY/Ic3Kn6GXEp/X0W4x+3KDNF1JEFeXc0TeYXwfIPZBKu6vbfXZfg/IARXZ85sGi4aLDEMpE/ikibOFTk81r2tqj7qjDwAkB6VGHsFVJDX4GN3YD5A4rh9n2cTzBTx8/MWLafP/QxcAYGhuBM818X0QU2SWqI3O9yTNH5TessZgaSwzjQPDN8ogn1Rl0QQ2VtjcHBTvfGJrLofifA0nos1xMuLIbsrSc5YVdGqNE0LKyLkB28ersxuBAC40K2PzZIuSgGEkUmaJ1HdLw8v+S+AIpfoXZST87n6xZEHpeKOtU/gV330Eu6XkFtaB31OOKe705frmEr1ZEbiUF37ttOih1GO7Ex1dnQwIvuUJSXAJV2uoR3TMsNsjJ1S60HdD5+izsh/ztjpiZH0Qw0InSFmC/jDY0WYtSblUazP7d61kCeKLkE3xW3/ONynb6fe1gxrU07SE2PwspDHjj4MpS82+6x2zZ+bd5ZaDf9YDmdOQ3UABG+8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(39860400002)(396003)(376002)(366004)(451199015)(53546011)(5660300002)(186003)(54906003)(316002)(6916009)(6506007)(2616005)(26005)(6512007)(4326008)(66556008)(8936002)(36756003)(66946007)(66476007)(8676002)(38100700002)(41300700001)(86362001)(83380400001)(2906002)(31696002)(478600001)(31686004)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RC9MNkU5eWNGL3RTTS9MeUhMeXk3TnZVS3dWQVBCdTRMM3lIUnVoQWtOTE80?= =?utf-8?B?ZzNMckE2eFp1UXpsajkxdGZiUHVKV3J6bWlsWmtjWldMZm84SWM5YTVpZW1G?= =?utf-8?B?d1hJdkw0WGtqQnVJSVBiNmYyVmJWbzJrbG5xMm9RS0tXaXNWQnNTZVE3VzVa?= =?utf-8?B?dW1yaC83SGJBcW1YKzVxWXNrUXRRWlI3WnQ2aHlhVHNXQnl0QVhXUjB1dzc1?= =?utf-8?B?b1ZWeXVSaDhnSWN0Ync3TDVQVWhxaUMybzhiMndvWjdZQzcrQ09vQkE3ZHk4?= =?utf-8?B?Tjl4N2xHeTdvcnVlSStHMTFHNVBCc2pOYXh6Rm9nUzdXKzZwTHQrc0FNQW9o?= =?utf-8?B?UC9UTGxidFZMUlhqbEhRa2t0M1M0NWtFd3U1T3lqZjhtVkRLTlpYZ2JlRE9j?= =?utf-8?B?bTVvNDVrRDQralkyeXlDSGpaMkV5L0U3QTFCRVpPMzBBRjF1QTJ2N2J4Zzl4?= =?utf-8?B?UDFVN2xEZUJuWFZwUUpTcDNqS0FmWHBCMm9tblYrZjkrQ3VaUlQvK052Qks2?= =?utf-8?B?eUJ4T1ZCTTBwdGhiaUhVOStETzNBOWs0VmdLQnIyZXh0WldZREJFUzEvdDEy?= =?utf-8?B?cERIRWVTU2NoMm9XUmdGN29BZXB1aHhDSGdpS3Y2SFN0NlkycWVvU3YxYjdk?= =?utf-8?B?b0tqQXEwbHpGTGQ1cURXOE5CN3BlSnpOaVJNWThYaVBQY1duRzRleG8weTVu?= =?utf-8?B?V1pOd29tT1RyWjNuZ3FjVEVMM0gwTDBnWjhaMTk5ZHQyeVdHdm42TERrcHJs?= =?utf-8?B?Mk8zYVZPakx3SGJTVnpvdnJHRWt0bFdBYTkzQjduTnZaQnBvdlIyRTBrM056?= =?utf-8?B?ZWpuZlFjSDBUWUZ3K1ZuNXp2NDlaMTB4Q3N4RHJaYi82NUlVQkZkNjFGUlhq?= =?utf-8?B?WjR2T1pacHRKYk56aUFOMjl2ekxDM3ZtT3E2b2k5MHVhZmIrTUZpRmlGVTZP?= =?utf-8?B?MGtTdHZLa29Fb1F3aWN5NHp5dENIQVlTUHRCd25NTEV2MEFMNEwyb1FMTFJN?= =?utf-8?B?NUhCZ2wrZ3o1M2E2eWRVd1hxN05DK3ZVNmw5NlR4cG1lbHFDN2xkRlRCTzl6?= =?utf-8?B?OHFiaC95YWRBWm1OKzlGVW5qTWtkU0JJN0xCVjJkZTM3dXNqYUxoWUs1ejlk?= =?utf-8?B?ckt4NDJLVGZ1cm5uWW80WmVtemtHd0VZOE1xQTlIcGZzc2w0UW1SYnhDdEt1?= =?utf-8?B?YmptR2l0Z0pPTUdzMVNhZG1SVmFEc0lhVFhmU3dGb2I3ZVNkdVhtWFRYRGFY?= =?utf-8?B?eW9QdG9seDNKR0x6bmpHUG1qOWF2S21GMWJGSDhOTjRYOEJ1cUhmamJEeHJa?= =?utf-8?B?bWQ1b2dpcEJwTFA4NHpaUk41SFRmVHBSeXovWGtoMmZYUnUyTXdtRjVPSXQr?= =?utf-8?B?eGlxT0RabnQwckJTeDR5RGdGSUFwSTkvTDRFdjhUTmZ3MTg4N0dET0NCSXNu?= =?utf-8?B?Z05jUmFmeHVKUXBNdGJ0bjB5MlBXaFJ0c3JTNzd6enROc1Y0RFd0eWpJckVk?= =?utf-8?B?OFdRV2hoeFBWekI5OW9uMVpqK2UxS3lDTE95SnlIYXVqTzFDQjc4eVEydmZD?= =?utf-8?B?aFgvaVFPZDZLT0V1dnc5RzljNnZrSzNDTzZtQTA5VDFXeGdEcStKL2lDVEVW?= =?utf-8?B?RzZ4OHNlcVNQTnRFcXBXdk1sMUphMVF4d08yMmpQNUhnanI0bkI1SDlScWFH?= =?utf-8?B?aHVYODZyQjdWMUNXbHh2cjE4c0o2NWVnNzA1T3ZqUitsbnBWWFk2Y2FDcmw5?= =?utf-8?B?ZmthMkgrNFJqUXlrQXhKd3A4L0FobGN3bjRHSmY3azBMYWZxZ3h4RVEvZVRW?= =?utf-8?B?enFBZ1RMU1BuQ0hXdHRtdFhkL3JNbFo4R3hQQjZ1T21EMENRUFVGNnVtQzJZ?= =?utf-8?B?b3FKOXkvSDBwUWMrais5dHI5RTR5Y0pLQ1dab3pzT1VRTWFWdGdRc2J6dE5C?= =?utf-8?B?YjNsdnlWUHlqL0lvS3ZpNmdNOS9CYk1xZCttTVZ0SXZBa3Uxc2VZNThOMUR6?= =?utf-8?B?cS9jUFoxZ2tKUm9vUTRFTUp2a3hyZXVFbDYyR2FsbU5iRG53dmpyenJuUGRr?= =?utf-8?B?bHl5c1dNQzQ1UnFuUG8zZGZlOFh5c2kyOWRkV2d6ZC9HYW0vMHNGNUt3K1Ny?= =?utf-8?Q?4ClO86WifImGluxdgxIbbLpIb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7036e5e-2502-4ef5-6a5f-08dac96ceef4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 13:58:13.0086 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V3Ee5Dt7nom9s4w2Pd5zbI15G5yWL6FOZd4V8jDlwE9gZBTX1VrbKHzXmQ4H+rsAkHVmBiFufU7hLEoNHHpr4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7793 On 18.11.2022 14:55, Roger Pau Monné wrote: > On Fri, Nov 18, 2022 at 01:54:33PM +0100, Jan Beulich wrote: >> On 18.11.2022 13:33, Andrew Cooper wrote: >>> On 18/11/2022 10:31, Jan Beulich wrote: >>>> Linux'es relatively new use of HVMOP_set_evtchn_upcall_vector has >>>> exposed a problem with the marking of the respective vector as >>>> pending: For quite some time Linux has been checking whether any stale >>>> ISR or IRR bits would still be set while preparing the LAPIC for use. >>>> This check is now triggering on the upcall vector, as the registration, >>>> at least for APs, happens before the LAPIC is actually enabled. >>>> >>>> In software-disabled state an LAPIC would not accept any interrupt >>>> requests and hence no IRR bit would newly become set while in this >>>> state. As a result it is also wrong for us to mark the upcall vector as >>>> having a pending request when the vLAPIC is in this state. >>> >>> I agree with this. >>> >>>> To compensate for the "enabled" check added to the assertion logic, add >>>> logic to (conditionally) mark the upcall vector as having a request >>>> pending at the time the LAPIC is being software-enabled by the guest. >>> >>> But this, I don't think is appropriate. >>> >>> The point of raising on enable is allegedly to work around setup race >>> conditions.  I'm unconvinced by this reasoning, but it is what it is, >>> and the stated behaviour is to raise there and then. >>> >>> If a guest enables evtchn while the LAPIC is disabled, then the >>> interrupt is lost.  Like every other interrupt in an x86 system. >> >> Edge triggered ones you mean, I suppose, but yes. >> >>> I don't think there is any credible way a guest kernel author can expect >>> the weird evtchn edgecase to wait for an arbitrary point in the future, >>> and it's a corner case that I think is worth not keeping. >> >> Well - did you look at 7b5b8ca7dffd ("x86/upcall: inject a spurious event >> after setting upcall vector"), referenced by the Fixes: tag? The issue is >> that with evtchn_upcall_pending once set, there would never again be a >> notification. So if what you say is to be the model we follow, then that >> earlier change was perhaps wrong as well. Instead it should then have >> been a guest change (as also implicit from your reply) to clear >> evtchn_upcall_pending after vCPU info registration (there) or LAPIC >> enabling (here), perhaps by way of "manually" invoking the handling of >> that pending event, or by issuing a self-IPI with that vector. >> Especially the LAPIC enabling case would then be yet another Xen-specific >> on a guest code path which better wouldn't have to be aware of Xen. > > Another option might be to clear evtchn_upcall_pending once the vLAPIC > is enabled, so that further setting of evtchn_upcall_pending will > inject the vector. I'm worried however whether that could break > existing users, as this would be an interface behavior change. You mean _Xen_ clearing the flag? No, that breaks firmly documented behavior. Xen only ever sets this field. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 18 14:09:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 14:09:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445798.701192 (Exim 4.92) (envelope-from ) id 1ow23l-0000AG-HJ; Fri, 18 Nov 2022 14:09:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445798.701192; Fri, 18 Nov 2022 14:09:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow23l-0000A9-EW; Fri, 18 Nov 2022 14:09:37 +0000 Received: by outflank-mailman (input) for mailman id 445798; Fri, 18 Nov 2022 14:09:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow23k-00009w-Li for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 14:09:36 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a024ab52-674a-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 15:09:35 +0100 (CET) Received: from mail-mw2nam12lp2042.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Nov 2022 09:09:20 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA0PR03MB5452.namprd03.prod.outlook.com (2603:10b6:806:c3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Fri, 18 Nov 2022 14:09:18 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Fri, 18 Nov 2022 14:09:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a024ab52-674a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668780575; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Q8UmST6oS+LA7ANIQGYHQXQhnAHoVkyC9TJv4pXJq6I=; b=FlQaCioDB0L6q5ApFnni9jzbu4Q5OTjrR3xtd3Bo66Qb5DeEkIZSsItR 2v9iahqOd5NsIBC1CpgymP4C4VXf7VdwD/3DyXb41lr6MWf3qbaK4SZzn YfiA8sIdz0YxTcI0G9VZZNOUKo49UlrQQos16AB3OxCszn+TZ+GHjnwGB w=; X-IronPort-RemoteIP: 104.47.66.42 X-IronPort-MID: 84696034 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:PSiy0q4CfgjmBGHCcSH1EwxRtBLGchMFZxGqfqrLsTDasY5as4F+v jNOCG+DOqqLNmH8eNhwaoWyp0wBuMTXytFmHgs/+3wwHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkS7AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m2 /wjIQkATU66of+u5IqeUbZ3iMYFFZy+VG8fkikIITDxK98DGMqGZpqQoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6NkkotitABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prr+Tw3KlANlOfFG+3qBouHij/0MUMjkLdUKnpKOggG6ncd0Kf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwB6J4rrZ5UCeHGdsZiZIddgOpMIwAzsw2 Tehj97vQDBirrCRYXac7auP6yO/PzAPKm0PbjNCShEKi+QPu6k2hxPLC9N8Sqi8i4SvHSmqm 2zQ6i8jm78UkMgHkb2h+kzKiC6toZ6PSRMp4gLQXSSu6QYRiJOZWrFEIGPztZ5oRLt1hHHb1 JTYs6ByNNwzMKw= IronPort-HdrOrdr: A9a23:7cHytaPLviXN28BcTjujsMiBIKoaSvp037BK7S1MoNJuEvBw9v re+MjzsCWftN9/Yh4dcLy7VpVoIkmskKKdg7NhXotKNTOO0AeVxelZhrcKqAeQeREWmNQ96U 9hGZIOdeEZDzJB/LrHCN/TKade/DGFmprY+9s31x1WPGZXgzkL1XYDNu6ceHcGIjVuNN4CO7 e3wNFInDakcWR/VLXAOpFUN9Kz3uEijfjdEGY7OyI= X-IronPort-AV: E=Sophos;i="5.96,174,1665460800"; d="scan'208";a="84696034" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nIl7FjEibHsBKRsQCHTfw+IItdg2yJpcKHsN6xcv5vcnQK6xiWIvJTL73NsGoWKVpplqHxqEacDofs2ARKfy7mBE7dPAwemeOjlNOdDgc6I+iccGYsNjhm7JdxTe/q314bCnqxrY4jG5yXugtLktMCfWmRqC0Xd7aD2Q1hu/XRWSqcP0CD/ewT+erGYTLJeVSloknFLZhQsdjKj1CfX8NUT4PSZ2k2he2140xb9GVdSj45KGyHKLpKVUPAoGDs8uCio9WXMLaGVRBJHsJtKnsXrRhAEJ102kZ1O9vqUclLMavyy8z/daziT6zXdNHHMPpinFM5hOTSVOp9FO4AUmDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oI41v7wgd+nwcrMXBSYhUl49WAatpc5nbxjV5Y99p8w=; b=G7SEDdNrZR6RyE+kjCMPLS9sH9cXarnIidinmuR8xumt9YHZtdoG9YyfdWXe96ldyP0TgJ/d8s1FA+CgzyF+GJ8EZdqWO/Dt4oVfPUxK01NDjRVJimprfywn3Icm4ZrbypXgRuh2FPEV8GClxWpRwNIiIIaGY/0rwgk7E9kSmMHPP3rtxxOO1sCgmMafNJ0Me7odPAZco2RFl8NdCT0rlM2o8PQ4LGgpfHMGMD8Rgn1vD6hsuDc4ZWsqyXQAkzEL34xxvnwLmehTtEFgHMzhsxx4VKTE9DwjYECVKwTBsh3aulQ4W2CKv/jesMlpkLPpH65VT30z8WfxVeY6zylq4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oI41v7wgd+nwcrMXBSYhUl49WAatpc5nbxjV5Y99p8w=; b=nWRguZ1XwcslC41uaWHduKfnVQgqKBOOPb+PVYiFHPPHCrzbrz0hEmuN9o8wb8tNtgvf4yZZSCik+3rm6lcQ6k8YNx9PzDuMFjpktsUWULIsXHB9BND29fTfP6fdxwtlk5vD+coUg4w7tbFu2NlaPzyQAyj0J06jRtQnKd26yeM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 18 Nov 2022 15:09:14 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Message-ID: References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: BN9PR03CA0417.namprd03.prod.outlook.com (2603:10b6:408:111::32) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA0PR03MB5452:EE_ X-MS-Office365-Filtering-Correlation-Id: 28163c3a-7765-4704-b59b-08dac96e7b0a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a6uTfvQllSJLp0/ewTS+9D0OtlLF4zyPvibT2M8hsLXsqanvemioM7WfTU26VWL/bbgVLYa0j+dIuk3e9qiDPeaaHnXwcpL6AWZJUMHNtPkahdRAJ0cwQkiqIeXzOXvJYAjVZ+Q1vdbAvXVkjBaXEkMIJgyOgU5JFwgyxIqI6B/PgDrgYxFEOW71Sigc+Xqcoqefsb/Xol9Cns3CcVF6eurYF4hc0WQFM8PIRHuWEJ90v1kDueo1OT2L71wUvJsuZAVpAqDxI3oZT2NQccMbIOZoVnRjhptQi0poOXWvg8hwJGJYh04PVSVTdiimmCpDnhT1bBpGjnFUFOe+QbPC00IMfIipsnPdcJ4wXEtK1G71bTbsmbUHBxMCb0DbmHwvVCoRlX25s9qNqoodlbPCz7kYBbzb0uznhXVi1Q+tHmyPhEx59WarTdJiSi4k4NgtZBGBxh8BUX8hBcj2CVH5Jw5QSLK3fIxVz9mGVCMmlG1qnAr04KjCMZPhxFb86RvhP9gaxEPyNzBe6sX4XLVYWdXp0e5UqKwJR388RhsQEbe+aVr0KluF297fwHuIqOaej5eDHA+AzqPAC98TxoZuAKXjvcJ2vY0zMA4tUvRWwwrXINSoCvY7i6NPdplGHt0polxUBm4w21+xhCq+jB1Xtg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(346002)(136003)(376002)(396003)(366004)(39860400002)(451199015)(85182001)(86362001)(82960400001)(38100700002)(33716001)(6486002)(26005)(6512007)(6666004)(53546011)(6916009)(6506007)(54906003)(9686003)(8936002)(186003)(5660300002)(83380400001)(66476007)(2906002)(8676002)(4326008)(66556008)(316002)(478600001)(66946007)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzZXWkI0blpncW1mT3FZeldURFZSNy9nbzJqWlE4eWlrL3ExaTRtTzFTaFFD?= =?utf-8?B?alN5T2VCakZ1VEJHTGhIL1JteXU2NUI5dmZRa3I1ZmFNYlpXc3ZxZk1IUE9S?= =?utf-8?B?K0ErdlgzMVY2c3cvRStNZFpCRnFkd2ZtS1FoaDMzaHF1RUVxUTBvSTl4NnNr?= =?utf-8?B?cVJmU1gwb2tUOXNyK3NEQ21QR3VLcUVabGM5aUhsRElTa2FoOWpYQlllTFJ2?= =?utf-8?B?Qm45VDgvR28rTmhZL29rbmtsQlh6b1R5a3VYR1RGMVFBSml6SU1ubTliVGla?= =?utf-8?B?TVJ2S0Mya0owNzk4bzBQcStaOHl6dk8xOHBYVEJBR2loODU2L09lbDhMYXlS?= =?utf-8?B?TjF4bXhvY2o1dU5CdEpMM0ozMHppQWZTVGNCdkJIZ0Jvb3lZeEdSSGZPNVM2?= =?utf-8?B?NzE0UEV2ZjZYSzFYQkFudHRDNmExSHVUR1gxYUF6dnRTbUpMVDJJU2dNZmxT?= =?utf-8?B?c2RFUndKdHFodzc0NDZOWkM1ZDRqMGwzOWo0MlFaUXhVd0R3eWpnRkhBQzkz?= =?utf-8?B?dTZiN1JqRXYwVEdnRXl3eHorODFMMTJTRnhHR2NiRkIyalJ1bk9seHZtSGpa?= =?utf-8?B?NTZ0djlITGxDSkhsa25RUkJ5bklRUzgwM2JyYWM0dUpnVE5UOE4wVWllVXVy?= =?utf-8?B?aE1TaFJ5cWt3ZHB3UHU5SEVPWFQ3dTBobHdRb3pTL0VOYS9qeVQ4SFhGNC9N?= =?utf-8?B?QzlMRXcveTEyUU9sVnBPb25ZeFNqcFFmbEt2VzRqNUJkOFQweFRTRnNhUzZ6?= =?utf-8?B?dGJSN3h0d3ozMUZMWG1vSlJQVzhxTlVKZitxZ3FTZ1BzclAvRGFjTURCUkJF?= =?utf-8?B?Tk5lMEFZc3JpQ3FjYTZ3bXByb0JSbTgvQmpMdEFMU0c2ZGlWbUhqY0V4Qk94?= =?utf-8?B?blVKdWIra3RVcUxOQ0Q2MnlNTFhCdTJmYU5VTDkzVXh4NEROd1dDSnVUVms3?= =?utf-8?B?bmF3b0dmSG1McE9nQXpWc2RpcVowcFhWM24yNmR6REhJK2tLUUE3RnhGMlB2?= =?utf-8?B?VlYyd0N0MklpTFVWaGhDQ3JRY2dQeG1uSXBaRlBvSStHb3hOdW9BSzFFNG12?= =?utf-8?B?Mjgrd1dMcVh2Q2g1VDU0dGRoKys3RmlJY0V0NGdpeXQydUNqVUFPVG0wSXZw?= =?utf-8?B?M2lGT283Z1FrMzd6TzM5M3pWOGdiN1ZVRzhSQ3h5VWNkSUVPOVJPdjRNRFhO?= =?utf-8?B?QjV0Y3ltVktjakpJTWtGSzZwY0pBSnlxS0JzQUt5YS9ob1IxMFFSbmRFeUxN?= =?utf-8?B?WW53MU9pa0dJZFFSR2xJRFYzNUxYamlrRnhEQS9nTVFjL29qamhTYWVKTW9k?= =?utf-8?B?TkZYVnlaS1ZXTC9uUFQ5TVFVZU5peURSYWVZcldZKzU3ZkJtaUZNZzZSMW1h?= =?utf-8?B?WGtYR21MQ3BVM1JXaVVBYVBlcXpVbG1zdFlsVy9zSkpMdmE2SjhtNXNkREU3?= =?utf-8?B?TjBiU1Fra3hDSzJqakgxRnJwK0dFQ2xCQXpnaGpML2ZudlJYME5yWWdjZ2ZR?= =?utf-8?B?OCtKdjBoWndMSUVIYklsY2M3eUIxV0VHK1UySHZtMXBzK3dOb2RmWGM5d05R?= =?utf-8?B?K3psTnFYSmNvTnFxTndOdFhqL1ozYzVQOWtON2JVVlJuLzRjZXdFeVFVbXVD?= =?utf-8?B?VmhmMVBiZ2M0WkQ5MzVsQzkrQVFZV21EN0N1RDR3Z0ZDMnJ1SmxRRVNXa1pF?= =?utf-8?B?Z3QwRllTK2JjYkpjWVduQzFYZ0Y3Qkxad2RscXF2ajZ2UUdEcVUzQWdaZkFU?= =?utf-8?B?MDlTRGlSS2x1cW1PT3IyZUlJZWVZREJPMkpBeGJqMFFrazBWcTBnK2FJZC82?= =?utf-8?B?U1NQMTNEazFUMjF2WCtJR29BN3JOZEg2VU13NU1VdXFjVjlZVjZnbUJadnZv?= =?utf-8?B?OERheXNxckFyUC9rV0FvQVNSR0g5RGliMzlnMEhPSHhlR1B6Tit3TkdIY0l1?= =?utf-8?B?RnVSZVJNMmkxQUhVZjlCT3NtenVPenhDL0hFN3ByRW1zT0F1N3E4K1kyVTBu?= =?utf-8?B?K21hK0pOSnpYY3o0Rm53aWxnOUVMcE54cXRibnBUK25QemxkYjBVdE0xaUJG?= =?utf-8?B?OFl3NTFYYTNCMVJkYkRQOGh4cTM1eU5BQU9maTB2WmNBUXY5ek02UjBQNy80?= =?utf-8?Q?om0deS7Wgi35Uc/LyMFyjlcs0?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: GtkbP10ZAz6R1YHAH3j8+tXm89XEFVA8NrE6cxZb//HL+pwIiVHYfa96/WPKEYymdz/D6emU2TYBULmpIl8HzLfPgg31+qRTjB1GpNfY3aTUHjFx5W1QQoyWiO4P35OFMXTDYJ9R+K7DBN9D9nlRKR6jNAbM/3Bq5mY9vQYlXu9qdyfmAPruxtCquzKaolacmgIynyTLA319oC++7zW7hUT43d6alteucVroa2cufI3DEjmzLCyjo93P88dA4DhVegHpRJcg9aLJIuUpDfvB/p9PpHNo6EAzjBd2xj0VPnECmqOCM+mxfMwa3cNO3yHJ1G2h+lTcIweJlePUCa46+qCHNQo8swAprYzwX3tPFpNKjCj3I/Y55nd6TPIkwnZfQyp8YAKVZ1OYdVQcw7HmMAaKG2sFVIaVQgx1QLeXQUvS1ldoOwxRtR1/a/WvtP5FFRjuep/xtcROVkyR4eveZGgUpc0rF+MOMoOfWHgrAmPyjrNpC4/oPwOe9VOJStDmo8ppDFKv7pDM/nfJq7gSk9VpDeEe/WsNkJb1EeL3ApgyoJzSHDDP/1oRXmsl/yvBMV1RPq8ERCdKmd2XNT37N5wY3AWRabKTzKe3HMGKBbctYvjcNMTzbsk5jsaVp7GFEuwv6fKLOOyh3xBBqedJMt9ZPnx1eiEoJlKrnz5Y6nTukJ8F4bdmBA7zrbmxdtNiBFAk2P8NXoB2kfy4Pz230kNikqn9WVfiEROi8e8kTax5zHs51j9ZRuZbsllNkfDhu1HOFfN+OYRyDIK+4HAhU4oUV5HnH6Q8jAEOvjh1x/WLsUKGj8WqXfxm3etGmuLor9lsHTS0dz7nc6ZDPi/UM80mtp+0Hab50dKCRqMDCtI= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28163c3a-7765-4704-b59b-08dac96e7b0a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 14:09:17.8293 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0vmBB+svo0ZgDUgqS65Q+xf00Q/N62NHiaihCFzdsUrPUgxnHMWJrA662QhThJj1n26C6xN2Vovyhp9wG9uh+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5452 On Fri, Nov 18, 2022 at 02:58:10PM +0100, Jan Beulich wrote: > On 18.11.2022 14:55, Roger Pau Monné wrote: > > On Fri, Nov 18, 2022 at 01:54:33PM +0100, Jan Beulich wrote: > >> On 18.11.2022 13:33, Andrew Cooper wrote: > >>> On 18/11/2022 10:31, Jan Beulich wrote: > >>>> Linux'es relatively new use of HVMOP_set_evtchn_upcall_vector has > >>>> exposed a problem with the marking of the respective vector as > >>>> pending: For quite some time Linux has been checking whether any stale > >>>> ISR or IRR bits would still be set while preparing the LAPIC for use. > >>>> This check is now triggering on the upcall vector, as the registration, > >>>> at least for APs, happens before the LAPIC is actually enabled. > >>>> > >>>> In software-disabled state an LAPIC would not accept any interrupt > >>>> requests and hence no IRR bit would newly become set while in this > >>>> state. As a result it is also wrong for us to mark the upcall vector as > >>>> having a pending request when the vLAPIC is in this state. > >>> > >>> I agree with this. > >>> > >>>> To compensate for the "enabled" check added to the assertion logic, add > >>>> logic to (conditionally) mark the upcall vector as having a request > >>>> pending at the time the LAPIC is being software-enabled by the guest. > >>> > >>> But this, I don't think is appropriate. > >>> > >>> The point of raising on enable is allegedly to work around setup race > >>> conditions.  I'm unconvinced by this reasoning, but it is what it is, > >>> and the stated behaviour is to raise there and then. > >>> > >>> If a guest enables evtchn while the LAPIC is disabled, then the > >>> interrupt is lost.  Like every other interrupt in an x86 system. > >> > >> Edge triggered ones you mean, I suppose, but yes. > >> > >>> I don't think there is any credible way a guest kernel author can expect > >>> the weird evtchn edgecase to wait for an arbitrary point in the future, > >>> and it's a corner case that I think is worth not keeping. > >> > >> Well - did you look at 7b5b8ca7dffd ("x86/upcall: inject a spurious event > >> after setting upcall vector"), referenced by the Fixes: tag? The issue is > >> that with evtchn_upcall_pending once set, there would never again be a > >> notification. So if what you say is to be the model we follow, then that > >> earlier change was perhaps wrong as well. Instead it should then have > >> been a guest change (as also implicit from your reply) to clear > >> evtchn_upcall_pending after vCPU info registration (there) or LAPIC > >> enabling (here), perhaps by way of "manually" invoking the handling of > >> that pending event, or by issuing a self-IPI with that vector. > >> Especially the LAPIC enabling case would then be yet another Xen-specific > >> on a guest code path which better wouldn't have to be aware of Xen. > > > > Another option might be to clear evtchn_upcall_pending once the vLAPIC > > is enabled, so that further setting of evtchn_upcall_pending will > > inject the vector. I'm worried however whether that could break > > existing users, as this would be an interface behavior change. > > You mean _Xen_ clearing the flag? No, that breaks firmly documented > behavior. Xen only ever sets this field. So the only other option would be for Xen to ignore evtchn_upcall_pending and always inject the interrupt in vcpu_mark_events_pending(), but that would then lead to spurious interrupts if an event channel triggers while the pending upcall vector is still set in the ISR and evtchn_upcall_pending has already been cleared. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Nov 18 14:12:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 14:12:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445804.701203 (Exim 4.92) (envelope-from ) id 1ow26K-0001oq-19; Fri, 18 Nov 2022 14:12:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445804.701203; Fri, 18 Nov 2022 14:12:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow26J-0001oj-Um; Fri, 18 Nov 2022 14:12:15 +0000 Received: by outflank-mailman (input) for mailman id 445804; Fri, 18 Nov 2022 14:12:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow26J-0001oY-7v for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 14:12:15 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fed13d85-674a-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 15:12:13 +0100 (CET) Received: from mail-dm6nam12lp2169.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Nov 2022 09:12:06 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BLAPR03MB5554.namprd03.prod.outlook.com (2603:10b6:208:290::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Fri, 18 Nov 2022 14:12:04 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Fri, 18 Nov 2022 14:12:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fed13d85-674a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668780733; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=aOVpsm2W+wZlvL8oIv5L1JJCqAPusdUKo6dkCuzgAq8=; b=Bi4lDQ5gq3N9mGzP/CMMMHNKxPUSFhHzAI/AYXl4WsuLJBoz7Wkb6FOq kok6Wc3veUHsESr6tDrCSQY1eluty1FaiXebfM1VrssGXtOHopgUUfCGG uWBuAuKMvUIVFcN0o+aGp/gpguzh1INAfFJ6dXCurv1ZFK3IuwdX9WJhg k=; X-IronPort-RemoteIP: 104.47.59.169 X-IronPort-MID: 84176170 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4nVGYaqGt4JFWB+MHEbpNMITOTteBmI/ZBIvgKrLsJaIsI4StFCzt garIBmEbPbfNGSkKYhzO9u38BtSv5CEy4dnTwFpqSszEisR8ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzilNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADwIbgmyp8am+eKqc/k2jd0ja8PsF5xK7xmMzRmBZRonabbqZvyQoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jemraYSEEjCJbZw9ckKwv GXJ8n6/GhgHHNee1SCE4jSngeqncSbTCN5LS+PhqaYCbFu73SsXAUROcGWAraeHzU+TfYpBd xE9w397xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnM08SCEu1 1SJt8j0HjEpu7qQIVqC8p+EoDX0PjIaRVLufgcBRAoBptXm/oc6i0uVSs45SfDkyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CBhRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:xH49G6sFINE3B5h0i23JpqWW7skCAoAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBHhHPlOkPEs1NaZLXDbUQ6TQL2KgrGSpwEIdxefygc/79 YcT0EBMqyWMbESt6+TjmiF+r4bsaO6GcuT9ILjJhlWPGJXg/YK1XYDNu/XKDwDeCB2Qb4CUL aM7MtOoDStPVwRc8SAH3EAG8TTutHRk5riQBgeQzoq8hOHgz+E4KPzV0Hw5GZXbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7hGhdf7zdNHJcqUzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iEnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjXuVm2Hqr8DVTC8zT5Mpv/MuTjLpr24b+P1s2q NC2GyU87JREBP7hSz4o/zFTQtjmEaYqWcr1cQTk3tce40Db6I5l/1pwGplVLM7WA7q4oEuF+ djSOna+fZtaFufK0vUu2F+qebcLUgbL1OjeAwvq8aV2z9ZkDRS1E0D3vESmX8G6dYUV4REz/ 6sCNUlqJh+CustKY5tDuYIRsW6TkbXRwjXDW6UKVP7UIkaJnP2rYLt6rld3pDmRHUx9up9pH 39aiIYiYZrEHieSfFmnac7uCwleV/NEggEkapllttEUr6VfsuaDcTMciFtryKamYRgPiTqYY fOBHtoOY6dEYKXI/cu4+TfYeghFZBMarxhhv8LH3Szn+nsFqrG8sTmTde7HsudLd9jYBK1Pk c+ X-IronPort-AV: E=Sophos;i="5.96,174,1665460800"; d="scan'208";a="84176170" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l+MtVd7SiFYw3welXT2juuK0NzWjzFKmjz/T3gESV0HiEBkTA12RiilasXJHUTCyV+fPBdkHpd3YPXwfEr/343U1hNz0TmynDrZ8ca/Xxg7PesFka9rV8Z6Q6HDEdE4GElsYxF/RLTIc7+nq2xUC7X8I4CNjHlcfX3cne+CPwHTW88GcGBhSotHva2h7CJLHpd+6lgoFRl7ieqMjGQooewm+x9ppypZLxSJqeTGjVCJzrPlhUSwr7Uraj9TG0AanAsdXkOcoyZRqgdAjkypexo1s+gDsdcEFmo/oLi79VAZcfIocjnNJZpqt+KHJBe6vBj0nfoaiOsTD4H0x0RdjNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZjEZzFkTYxDknDXb49z3xsoGFctbINBUhrfuN4m+sNs=; b=MtUd77mC2PrJDJEcWuihQmjS3D6s1bPJNVST+/UNmeW7CzmJL6shWv5YhvJL3q1Web/f0kf2mKr1zgY6/OL0df7JgJLp8erUGMMpe5/BiWJzAK8+CvPFOzVQP1CKZ4VF2j4AMl8Mo5DE/26+nyOUJXKJ9LTsG18ww/v0uBPLBr08mPadZWw/kHdW2rdFgo/lLBupqrx+Ta2TUHq73ClnfMPuDOqQtwHSuIYMlrnw4XSWrAo+GlyJVv/QbFkpwHRETTRprmTaNhQ1YLgemVZs/OCVkckegRJxnJuEVdwYZgrlWcHlUHIjo8gevqXIge6c20p7keR1Z0hFCcFhg75XoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZjEZzFkTYxDknDXb49z3xsoGFctbINBUhrfuN4m+sNs=; b=u0XVC7LqK0sLG45ppOFuzEPFIHDIZHoMScFY1RvGeggUXrVZddIsuoMPsAkhr4P+v+94EBouLZpTZQSYd3dL8FbZpJsGl4WhSooR8/3qYASwjZykESBR/yNmV+KkoYsYln9fct+oUzaDq+U+0ngzvkFjoC0uCoqd+VHBBHARMFU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v2] efifb: ignore frame buffer with invalid configuration Date: Fri, 18 Nov 2022 15:11:32 +0100 Message-Id: <20221118141132.26242-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0424.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::15) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BLAPR03MB5554:EE_ X-MS-Office365-Filtering-Correlation-Id: ad001150-b5f0-4d07-8256-08dac96ede15 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WZjYwEaw8VVNoxqRY7mmEbxVoaeErsBmXg9Du8LZIg4ibCMVO3G1DOSmWKj/MHjRtNk7aBIEsJSu+hmwdfgwpc2EATkauMavoJDsdYoROyZuo8PHMVe43cHDSI/9kY83Sn5aqfcp3LpUGbW8EYIPmb3NnMURoD2eOq+6UabGWhx8RMn2dZQWHAE+zra/8k7fEFqTU1qQlv5CkC4p2ayevH3+10n2hRQ5zxh55R2Z3AwJx66nhKD03eU51GEESur9gIR66Ov5+rQBj7Vl0zKYDZUtKiRof9+WdMBcBikDb0wF1Y9KSRb/Q+QcCfyceZOEUhrNZwZrS73OjBV6bMGOsgw0ycZkO9oABw+Hys2QDCw61rgLwRO5mIRexuJaMBclBI8bQb5k8qQVswnP5hf39F5l1HBbj1Y1yHGJymB86Tej7G0GT4cbcLgOMmH+1MREFSRcf5tRXKW9Tc7/M6olZUFX561SvpkT9lELpaTxjVn5Mly+yBgBcncXM40dRgQ1DBZL5CAIS7Lf/sTEkqedtSDqOJQH52LEv2Su3XFP1rj33/v40XDrTlLfHjIXkWo3iTwCunzghk985nREwYTLDUhxeSS+y5cNkVjZcNAnBPU5pVN78XUjPxZxV2C45EllhvGYlOUkkhvGBW1wucUKXA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(366004)(396003)(136003)(346002)(451199015)(86362001)(83380400001)(5660300002)(41300700001)(8936002)(186003)(6666004)(66476007)(66556008)(8676002)(2616005)(26005)(66946007)(316002)(4326008)(6512007)(38100700002)(478600001)(2906002)(82960400001)(1076003)(6916009)(36756003)(54906003)(6486002)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ulo1R1ZGS0h1OGJnZWJoUVJnanpBaWxIOU5QSXg5aU5PeExWRVhGaitCZkk4?= =?utf-8?B?N2RIZWVIVzk5QXlCREtwa2FLQXJoTERYbE5LSjZIS3NQZzdHRXZiQ0pWSlMy?= =?utf-8?B?dVRmalVSYTlTVHNhQmhjeGdCVWIvM3IxM2hVL1F3RXFvak1JUFo0OFZFcXJs?= =?utf-8?B?V2M5MkZQNEcvWVgvQjFpa2pYYjFTYkg0WUd0UzBtOTBIU0JmZzNnT2hRQ3hs?= =?utf-8?B?T2Rtb1QwbWtFdHpMZVEvckh1Qkhqem5wT25RMGplQTkwZjN4aVBuY0cvREpK?= =?utf-8?B?SStjL0U5K2tZQ1NCVDdvZENOWmlzVktpaWlWdDg0NXc0bkozaEtUaFRibm5F?= =?utf-8?B?ZlR1NklJRWJ3SWJtdHlNK2pPUEY4SkJUTXUwYmF5WVBNQ3NEUWhmMmdoUkxi?= =?utf-8?B?bllGMzF3bnBldk01eFJvSVd3cjhIdHZMTVliaFA0SkF5OHdXeDJLMytIRUov?= =?utf-8?B?R0k2Sy9FRXFPWjByaFRWcEFUaUNrNEhjQ3VaN3dqTGtWWHNUVWpJeWVhNmJx?= =?utf-8?B?S3NSZE1qeFJqcGFLS3dXaW5OWUl1NjI3a1Iyd0JCOXl4dHM3WStZRFd3cVRm?= =?utf-8?B?YzgxcTlhb0ppY3ZRdWVEZWVaVUNmbnlYSElCb1hQZVVUaGg1UkVscnRmcXZJ?= =?utf-8?B?Z0ZkK1lQNkk1TmZ2aTAxUE0zUHVYcjJzaEl5eS95RG1OOUY1eUZXdVBmdHFn?= =?utf-8?B?cG9CTVovWEx4dGFVVitVcmh3VUtmdjBrWVFWWHFnVHJHNXhwV09MSFQ0Vmoy?= =?utf-8?B?a1l4c1gvTHMzMldpM1JHT2xURkdjOEw1eVlWaUlJMVI4cG9RYW1IeStRcmNy?= =?utf-8?B?bFB4ZnlqT1ROYk5EWWJvQlRrQjFZaktaYjZaVHo4QkxrbDh2UXdxY2ZZSVkw?= =?utf-8?B?NjJlVUpIS3lsanBUa2d3dGFQZU9KUHRYZ1N5OWs1cUJBUENPRll5VXNDcHlu?= =?utf-8?B?RGVGN1d6N0pwRXJWaTlvMHlPM25yaXFXakhFVmh0aFBUcUtJeGZlRTN4b2NI?= =?utf-8?B?MVdEbDUwcDNzTExjTHROckw3ZUg5OWdZQmxONDdzbE9BZGhOaktRYmEraUFS?= =?utf-8?B?QlVua0F1WDdFcCt4eGN4MklhbkNOVlFrdGgvdVFMeHBmdU1pMExHSE1wWFph?= =?utf-8?B?eU12Y3JvRkFKKzl0QTBIcHVoa3NScXhiSmRDSy9Pa2ROYkxCeG5Lbk9oOGVh?= =?utf-8?B?VHpUVFNkOFpIblVEZUI1M3NmUEswc2xEMlNBQXN6MW9laGVZNWJPUHV0WEh1?= =?utf-8?B?UjFhU2c2TStGRGdraVFGajFBWGR3Rk5wYThqdTFBOUdkNTdNeU1oRktuYUtS?= =?utf-8?B?TkxkdEdZNFEwNm1FbzdFbnZzcjdpWmNVUVRZMHNJRnBkbHNMYU4zQjE0UkVs?= =?utf-8?B?dTZaUVBWMWQ0bUIvZVU3bnA1Q2hYYTNkMk9ad0YxRjFkeTdDWThiZld5WVZV?= =?utf-8?B?c3B6R09YVS9DbUVzUk1HVmNSTDc2VkpjaURyV3NsdjlHWnYzd3dvdlI0eEda?= =?utf-8?B?SHNkRGR5NkQyd21UQWFlNzhncnhhOHUxemNQbkhTeWFaRWtQczRXViszVVNa?= =?utf-8?B?LzhhS3RDbTFDdWI1WXpWajBGVkg3bHFGME1pUndEeVY3K0VXUXBkWGliVFBS?= =?utf-8?B?MVZXbWpvRnRjcVZyZ1lMeFl3eW4wa3BzbE15THNISis0S21BbEZsdU85YVN4?= =?utf-8?B?UTJqTE9GRGRjMXNVdksxUjhRMDJLN2RoQ2xzR0lDWmhxVDNOcFNRbzN6MXJX?= =?utf-8?B?NjdHUHlSTzRxd01rUXRZcDNsOU1iQ3pBdFUzK2sxWDN5U2Y1c2dJSnRQYWZO?= =?utf-8?B?bjNlWDFKNllQZnV4OEt5Ykp3WlQ5MWVNOHd0NTV1bmp3dzc2aXlJN2xmWHVh?= =?utf-8?B?bmlxemNmZDB3UG1mUldhMTM3RzMzQ3lrOG1KMzkzVnAxSHhNcmdvczZ4ODhW?= =?utf-8?B?UC9xWmRWenNLYmtHSkJhMGNyZWZzMjJNVmNOdWwrUTdIREkvVE5UdUxONm1k?= =?utf-8?B?YXFvN2NWTWpvRGpic3Z2djJybTQ5S3JtS2RqNGZabnJhd21qNHhHSXhMQS9O?= =?utf-8?B?cW1yRmIyemhTN0U4N3RlUVZhRWUvc1J2YzB1bjYwUGdGSEoxTWNxNzZ1ci9K?= =?utf-8?Q?1Fu+rhwDvODLiPQ0kEh17Lslt?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: g9pIpyxpVtABZ9km7o7LJWs95g9QjACEccUfpzVzu+9iffUgYC4gMZjcooO48MMaTmlR9D35WlGVOuj1jj7SOYfUIEzXMhqNrdyvRWfvKoVsNOWGIF98lbbfu5IPe0/RwP3MnzSQC+2AU8H079FpESN1UzNSy6Ir1ziQBnyqcmNKoJ5v/33pc4atJqEUf7qdh4Jpze45fAuXGQrJm128a4gh8/vXr5SCqAeZgA7GtFSUu7zA9q1F2xVoQkeddB4k6lim7Rvl8sZpjJ6SNaZWw7bt+T23gU/IcMPrbtNBC5dRi4i5qD67zK6Nr2w9k7Nw3y6CbaN+EITol6RNPso9oIMWSmb6pzRa3nN4wA7OMCUCmdw/Vmvo5jjEIR4/7kv640Lahep1MSAZndIGhn5J1MvUHRlu+L8Ekp4zk9PExHiEdb+ci5TklzS4SPGVnOM90d/MjpIHzTrWegS7zVzfspt9qQwL5iIWGlwbw+y7IuWMWjbQu/AykoKcyY0Il6BNY1PUsG6YcqtKJJdkqOqdfrTtzWWhlm64T19/fRmfBVpxEBbo2XrNmaJkq42CkK4TRFUwvwE4u+/XcyRLsChou1yiFR9tmPYN29ygCJeRRXEoAzuoULZumhyrgR/Eh+p4CmaZRKZ8U6iCiA2UgDsF95dNqO+DLgim9+JnzkDuvBsvofxEt+CJwxO271TJ0PhmyudhimenNi99x7ucZwBAk8hAaZkCHZDQ5ZNRiKg1021r6EHFG5SzHOQ+XIL7ljHe++u283wSzWNNTUfYaqVbm37ppRKiNMISP6kaFut7p08tL7R3M8FGVwwL9tj82IybEGdC+fcQi0ohwlyoNFWqpw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad001150-b5f0-4d07-8256-08dac96ede15 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 14:12:03.8383 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W8l9KaUrHYMmLoF/mMIVVSre1NUbeVYD9BYP1O5/dc7Vr8TIq2gCHfJCgOSKE048E4+ndB18GOO95ea38vtfYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5554 On one of my boxes when the HDMI cable is not plugged in the FrameBufferBase of the EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE structure is set to 0 by the firmware (while some of the other fields looking plausible). Such (bogus address) ends up mapped in vesa_init(), and since it overlaps with a RAM region the whole system goes down pretty badly, see: (XEN) vesafb: framebuffer at 0x0000000000000000, mapped to 0xffff82c000201000, using 35209k, total 35209k (XEN) vesafb: mode is 0x37557x32, linelength=960, font 8x16 (XEN) vesafb: Truecolor: size=8:8:8:8, shift=24:0:8:16 (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) �ERROR: Class:0; Subclass:0; Operation: 0 ERROR: No ConOut ERROR: No ConIn Do like Linux and prevent using the EFI Frame Buffer if the base address is 0. This is inline with the logic in Linuxes fb_base_is_valid() function at drivers/video/fbdev/efifb.c v6.0.9. See also Linux commit 133bb070e94ab41d750c6f2160c8843e46f11b78 for further reference. Also prevent using Frame Buffers that have a 0 height or width, as those are also invalid. Signed-off-by: Roger Pau Monné --- Changes since v1: - Print a message. - Also refuse configurations with height or width == 0. --- xen/arch/x86/efi/efi-boot.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index e82ac9daa7..27f928ed3c 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -506,6 +506,13 @@ static void __init efi_arch_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, #ifdef CONFIG_VIDEO int bpp = 0; + if ( !gop->Mode->FrameBufferBase || !mode_info->HorizontalResolution || + !mode_info->VerticalResolution ) + { + PrintErr(L"Invalid Frame Buffer configuration found\r\n"); + return; + } + switch ( mode_info->PixelFormat ) { case PixelRedGreenBlueReserved8BitPerColor: -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 14:27:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 14:27:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445811.701214 (Exim 4.92) (envelope-from ) id 1ow2KV-0003Zj-Aa; Fri, 18 Nov 2022 14:26:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445811.701214; Fri, 18 Nov 2022 14:26:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow2KV-0003Zc-6t; Fri, 18 Nov 2022 14:26:55 +0000 Received: by outflank-mailman (input) for mailman id 445811; Fri, 18 Nov 2022 14:26:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow2KT-0003ZW-I3 for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 14:26:53 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0a888508-674d-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 15:26:51 +0100 (CET) Received: from mail-co1nam11lp2177.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Nov 2022 09:26:49 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6419.namprd03.prod.outlook.com (2603:10b6:806:1c2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Fri, 18 Nov 2022 14:26:47 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Fri, 18 Nov 2022 14:26:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a888508-674d-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668781611; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=AyhkqLleMRx0SzMNTZlrN7J9sB33TBgsH4vEMo82oNs=; b=PsULl2l89JljIiV3K3D3MyS7YXyjlKQBeVP99jPrDBohBaliuDFCIIBZ pAYSSFUKd7PdyFeitZOth2MuvMat3vS4EbNW7034XBW3EsPRG97lFIL39 iEzHNv6KwGT2Jb6vOavTZH9AfxcgKbWhzmlhFgSULK85eAuo/3+z6YHAz Q=; X-IronPort-RemoteIP: 104.47.56.177 X-IronPort-MID: 85136771 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Nm0vzq6ikDKTJOyBW4/rtwxRtA3GchMFZxGqfqrLsTDasY5as4F+v jRNUDqEOffZZzH9Lt12OovjoBhUvpSGztNrGVdrqHwwHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkS7AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mp OUeKjAIaEq6pryH/uOAF9hopN85M5y+VG8fkikIITDxK98DGMmGaIKToNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Okkooj+eF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efwHqgBt1NTdVU8NZSslzP2kwKNycyUHKEjdyHoXfuSeN2f hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaETAcMGsqdSICCwwf7LHeTJobixvOSpNoF/ezh9isQDXom WnV8245mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5 xDoR+D2ADgyMKyw IronPort-HdrOrdr: A9a23:lpfp+q+FM0qpLkfQT/Buk+Gydr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdgLNhRItKOTOLhILGFuFfBOfZsl7d8mjFh5VgPM RbAtRD4b/LfD9HZK/BiWHXcurIguP3lpxA7d2uskuFJjsaD52IgT0JaDpyRSZNNXN77NcCZe 2hz/sCgwDlVWUcb8y9CHVAd+/fp+fTnJajTQ8aCwUh4AyuiyrtzLLhCRCX0joXTjsKmN4ZgC P4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GKN2QhtMTIjDMjB/tQIh6QbWNsB08venqwlc3l9 vnpQsmIq1ImjvsV1DwhSGo9xjr0T4o5XOn4ViEgUH7qci8YD4hEcJOia9QbxOcsiMbzZhB+Z MO+1jcm4tcDBvGkii4z9/UVytynk7xhXY5i+Ycg1FWTINbQr5Mqo40+l9TDf47bVTHwbFiNN MrINDX5f5Qf1/fR3fFvlN3yNjpZXg3FgfueDlxhuWllxxt2FxpxUoRw8IS2l0a8ogmdpVC7+ PYdox1ibBnVKYtHO1ALdZEZfHyJn3GQBrKPm7XC0/gDrs7N3XErIOyyKkp5dutZIcDwPIJ6d j8uWtjxC8Pkn/VeI2zNMUhyGGPfIz9Z0Wh9ihm3ek2hlWmL4CbcxFqSzgV4ridSrskc4jmss 2ISeNr6s/YXBTT8LlyrnPDsrlpWAwjuZ4uy6IGcmPLhP73AavXkcGeWMrvBdPWYEYZsyXEcz E+YAQ= X-IronPort-AV: E=Sophos;i="5.96,174,1665460800"; d="scan'208";a="85136771" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oG1ho8aRy4VPFRB5/0Luo6BemPtnSWyNIzgU1NisiMqNfEauimdeLegfL8izV1FEqdvUxSc0oai1JyTmu3/5M5Yf/7h06+hHlYOCkxK18kXeQkm6a/KbzVGGLXTQOFSOYRrIBuB5uruFrXq8AS3fghSNLx3SMCBua7mb+64mIDB7grhHIneJoyJqqW8OAnYgBcoUb5FEx5JbF91CK2GzcpGaVhfwAsVRmIhGiSqHGXiTnI+4wPXibJiQoneyRQuwZNzuhh1DlHruxLBFUQYMYBZUeEupXhgaiKLfjZE+73IgO7VHpENwRCCuD6ws0yG/Ymn52u0AyUnZP1ILTXeB6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fdHW+CD+LvS3lDFBvGGEz4K2719YLrRZKumvuHvW+YQ=; b=kdbtzcjPWCa1zn1v8KaxrlArQ/5gkfkLwZob8IRe4pGcXPx2dqi/VTOL9KPw5VTRANI9OWzGty1aiGvC5pDI/2Q+icIT4hICvWVO8vYByvk+M+v/nCHtctvBCo8Z8vTEsSEBbytb/hV0gW41tX1txlsafw/TUg+VObNU36iD8IEuBV1C5sDow35QjP/1/cqExgyYVUmN6UXMQpuLqsYJf+CQV9Y5JJfBMjW2Cmt7dTjNMtOeM+2WqL2yqw7pmcNrxA9s1kwHtSK/mHCItR2BxWOYQwlEKAt3OIbqNJ6hBBO2pz879ZQqhdw/BQH9aBrA2yY59JpOdCRxdI9+v6vYqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fdHW+CD+LvS3lDFBvGGEz4K2719YLrRZKumvuHvW+YQ=; b=kTPhsisBF4u9qcGo42V/fWGX/ZxO/jxdg4S0TJlz9DGrpxTVCqKDM+d0DleUnI8Odwfsu7oQdL3t0VyW4J2U0PN83RzP+9WBG8clxHdA3hOR4tBq7qMxkr747bWN1vMrkafDJE6TFIQw0PWk94mOEqtr6AvlE0utnla5KZFjRJs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 18 Nov 2022 15:26:41 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Paul Durrant Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0584.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::15) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6419:EE_ X-MS-Office365-Filtering-Correlation-Id: febaf5b6-e4a9-466f-0db2-08dac970ec9f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qDFzUXbPDoc7RYlHyn7MaOcZn8IZhaDIjNJwbpNQJCKVRZv1IPYlOQ5K4DQX33bUXexXnSM1pFDsnmzHRP+xr0BkUQF5LwjZ0A5UsOm1auvvmDmE6jHoG4VxsQoOOafQw0QenCYvBc1QGjinoLSlXGRsAlhGoU7k2DrTBdLifXcavU7b4PRd+KbmatLjbKz/dVBFrzZpGvm8CFzij4CAQLZvEYBDwJgvCJ+wpqhLBNtkTKu//xpPr0y4hVuPbQaQ/hjlghtJD6aIfr84hUn4XDuJ6WmAMmWFxUF96AjFg6GqcI9DDDckFzvcPGtNN0pRRC0pDCDqcfJtR2PfUs+egjS/U98yUZ8hlJlwMl5FhyfUw1v8ILo5/8UGcqsBZUS4GG8AwzrDfGDHRo8VYXcwR4VCJLCptVXa8QPhCMJdamkl9CL/QRCk46zdMuVz9j/f0VIg04zXl0tLJwsLwKde4qz057kM6CghMMyLGlOhxGyEk2XYW5FjLBpqsFnPfBXn7vfb3DBhuS0vAF1pqCLDMhhuTtiJeIhhyB9MQqKY2/hTZFJlJp6BdZeuWpkRwx/tY3oqo+seRgs5JsuT1QRtVKcIdGlqTG1uQ6mF5T2lnk48ilb5FUrUuIFnajKg4uhaLyEBOOpzSItShdTGwTelSA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(39860400002)(366004)(376002)(136003)(396003)(346002)(451199015)(6506007)(186003)(26005)(9686003)(6512007)(6666004)(86362001)(85182001)(41300700001)(66556008)(66946007)(8676002)(66476007)(83380400001)(6486002)(33716001)(4326008)(478600001)(6916009)(54906003)(82960400001)(316002)(38100700002)(2906002)(5660300002)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QURGanBKU3FRekErMkozNkpiVU5jTUlEMFVQdnc5d2srZ0VJbldTZDhKSXlr?= =?utf-8?B?cHJHVitMYk5vWmxtd1pUL2NBY2NzaG0rR25VTVJpbSswMjQ1Z3FZUGt4dCsy?= =?utf-8?B?dFFPdlByN3cyeGo4dXd0VU1WRUxkaXhCMEZ1WVJseEF5VXlQWG1BZld4Z2tV?= =?utf-8?B?ckhRVExJSWx3VElyaUxHNEZ0NWluU05aRTM3aVZOV0ZqVHQ2dGo3ZXU4SzBh?= =?utf-8?B?R1FUSG5nNXhMZFgrR2Q4Wk1yT01BTVU2RjFYbE50dDlTdlJGeGE4eWduS01D?= =?utf-8?B?RXlZSFhxVHRldk1ua09YMWxVZ3pJNnFhNWtPL2VvZXowZnZIZXBhc3JmOXpw?= =?utf-8?B?RmxybVJVVGRsUzVLcXAwMzRkWm5HeG9nYWJaaTl1ZS9DZ2lqNkhrSFVxRGdK?= =?utf-8?B?Y1k4MURiVmliUG9SQUFmMFRCUzNtdXp2UURUN25BNkJ5VzdXTHpLVmxIeUMv?= =?utf-8?B?S2phUVVOeW1KUHB2YUREemJEVnhPRUhOdTdmcWNVZnFYdGZhbWx0WWNEd2dy?= =?utf-8?B?QytoejlvVGdDZmxvM3JoeU1mNDd2bzMzS1dMOUdYbTlNZFhBb0lNc3h1M28y?= =?utf-8?B?bFpmQlFHQllGSDNLK0pWT1ZGaUZIUVdUcjhycWprNVZXdUdyK3RRWHpJb3gr?= =?utf-8?B?VVQwUEltcnE4eUdiS1Y4S01nTkZYbnBvNkFPQ3c0T3RwZjlBMURRWXpWMDhG?= =?utf-8?B?QSs3L2NHWVovL3U3UkpUeHhKUzlJVXZhUnB4ajZTSlFVa2VaamhLVXo4Mm5Q?= =?utf-8?B?RXBjdEZ5UldoTkNjdU1ubHNJbUV5bEJvSU52dnFCaE9CQStIQVRCbnM4aVFx?= =?utf-8?B?eVl0TlUwV2ptMmV5eTZ5YXJuTmFwTFY5NjI5M2pTWmsrdHVoVlVKS3pxZkx3?= =?utf-8?B?NHdNQjJILzhjQllQYkJ0UHVHNElOMm04aGJ0K3JtOTI4VnZSTDlvOEdDdjBR?= =?utf-8?B?amFHaWJjelRpemg3T1lCL0RabDVwTEczeVoxaFJBZVhwRTlsU3gwajZ6cE1h?= =?utf-8?B?VDVQMnlOOHJtSHAvTytmRkliVVlWQTZ4WEFzQWZUdEF0eU0zZ3Njelg3Z3hH?= =?utf-8?B?QWs0WWlCYXFKdWRCMzcySjBIb1lUaTB2dGdXVkNzRURRQTg1WXhxaTRjSmho?= =?utf-8?B?MnlwMlNna1BKSEkrQTVReVJ3V3h3ZjR3bC9FbzZ2T2JnMklvZ2hDK2lVMTAz?= =?utf-8?B?b3hNSU1ZaHFCOWNCUGxtU0p2N21qc2kwUVE4amZBbExXUFhXY3gzVEhmUTZp?= =?utf-8?B?eVpYV0xNRllsMGIrUlQ5NDgrQUROMlArUVR4TjdSWlJPNnltVnBya0d1QSth?= =?utf-8?B?bFlCVmNCeE5taDdkWG8vM1BOaHhycHp0OFpOK21lS0loZU1PaU9hdnpPUXpN?= =?utf-8?B?NGErdlp6eUUvM0xMNTNIVGk0QThzZ0t3Sk51Z2JhRlVTVE5CMHBId1E1aytY?= =?utf-8?B?Y1NieGQ5cnJhM0s3RitTSHh4dld4dElMRGM3bVRkcHIyNjdTQmJhL0tKTkRt?= =?utf-8?B?cGxSL3JQSVVyenJteWZFNitlOG5raWtOQWNPbW1WS25KbHlZS2wyQ1cvVWRZ?= =?utf-8?B?MFJlUFR1MHM5K3NueENLdFBod25KaTByNjlMcndPTk5KU0NKQmgxVjlkVUpE?= =?utf-8?B?SXpRYzNUSTVaWjdkMTZuV3RlekRiZlJRS0pyc0ZQb2VMcys4c2QzK1duSVFw?= =?utf-8?B?a0pQaWNURTRMNG9GYjVEK0pXdEhwWlVIZ3AwUURDYy9SbTh0QXpXcStRMHhQ?= =?utf-8?B?VGMrdy8xcld6V2haUzh2TnZ4czZzeVQ3bzBmZ0pPck1RQ09sV3JCclZhMFll?= =?utf-8?B?RCtVNGN4RHcycTJoVm5rcEZiWkwwSlhuY1VaNThNbHN1cWpNSm9PeldLWVJK?= =?utf-8?B?M05pbUdCTXNqZHZUaWNTMzFIaklQeXJ1cWJSUWtXNXQwOUhWSmRCWUMxNUJ4?= =?utf-8?B?dG1XbFkrZXlBczJ6dlVrRG9KV01GUDlSSCtMYzZGUmdyOVg4UDJYQThSSHhr?= =?utf-8?B?d245ZEhzdEc1MGlXU3ptN0tSRzVUNkRSNkRhdWdGN2ZjM1JXYmQzYzF2OWhZ?= =?utf-8?B?YkR1NnpycHlTMXMrYjM1L0VBanNlcFFQMFFlci8zSEY2d2tJTnBkRHF6Nng1?= =?utf-8?Q?PeSZq1ORjwAa5EkfLVnmf7v3J?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: N4zgIlRkXb/9Ou2yt2X0WID8OaTsJAzJcG0YD+9jj0w2HO03utaBcUmJsuynwr/mC4BcMCCKGEB11o7CvQXCSgXpahXxe3nUIlCDZpW2tBIYkCBEq/4/tW230+n+ZrNyYhcgHmEiyZ9wQMdiFgqqkTcxfb65Qm521m6rX5sKxsPJbuUDVFICJHM4G5FsS2seTaheG1wgX7CDnSJHpd29MeZmboDZaTTmgUF9IB/O7GZCRR4fwAip6DgwKkLc0jjercLLLuEr8mXNKNVvB8xIZSmRB06DpnPxUJ/ie9FXuPGJTcKSk1LIzYfkNDzp3PndsjqjzD3YtMN+pvkDCCFt7ZQLXff9z56wdwbHMBVtTEDJ5XqclhtmILn61U5oaGnQpRtqkeSo5UdyevZmXz0z2xN3CT3DezU3EVoFvXQ7iK66dUyPmHT/Av6zqPXjAWRzansRgUwYLrvIE3W8j0bejVTeTR/OJHuJ6+JGMMpbBJwf8OAKBMbAyFSI0hS+twnMmCLpnfancbS9Ne64GmzhMV0jLDe71ncs/6Oq8TfqT0Aqp2dJqcVKLFWK7vTO4yyaFmwbhpYAVdOL1LsVFsYv4qNOrvNqXG4+EanlpSLLkPj9KrgnZ2FON+OGkBsS8m8iHuNPTHlAxNzUmCSS4vlsiyeOHb5GAfVL7o8KUd3jbZ/IoFDZOWdnW/bPdm9k53kry5vTEFTlfQKemjg32vqSv9/L5xAG/tch/dj/+coYRuZZQZrt15+VeAjkJpCl5UnNyMguDMjN2PcX9Ao4SjOi3OmO2j9Mxux9ABjVj2RF1BbqsvaKVZcwHk53DaPkdTLApxkTEdURDTLZhXfJ/scgFZm1Val3XZrfb4WydVDuCNk= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: febaf5b6-e4a9-466f-0db2-08dac970ec9f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 14:26:47.2212 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2WVpFEQkzrN4WS/j1gPK3cBq3KrNXcJPFl8G4UTXkSYk0tVsAnGLvMI5AnfKG76TwZGLZCQlR0eLznbEzAFcOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6419 On Fri, Nov 18, 2022 at 11:31:28AM +0100, Jan Beulich wrote: > Linux'es relatively new use of HVMOP_set_evtchn_upcall_vector has > exposed a problem with the marking of the respective vector as > pending: For quite some time Linux has been checking whether any stale > ISR or IRR bits would still be set while preparing the LAPIC for use. > This check is now triggering on the upcall vector, as the registration, > at least for APs, happens before the LAPIC is actually enabled. > > In software-disabled state an LAPIC would not accept any interrupt > requests and hence no IRR bit would newly become set while in this > state. As a result it is also wrong for us to mark the upcall vector as > having a pending request when the vLAPIC is in this state. > > To compensate for the "enabled" check added to the assertion logic, add > logic to (conditionally) mark the upcall vector as having a request > pending at the time the LAPIC is being software-enabled by the guest. > > Fixes: 7b5b8ca7dffd ("x86/upcall: inject a spurious event after setting upcall vector") > Signed-off-by: Jan Beulich > --- > Don't one or both of the Viridian uses of vlapic_set_irq() need similar > guarding? > > Is it actually necessary for hvmop_set_evtchn_upcall_vector() and > hvm_set_callback_via() to call hvm_assert_evtchn_irq() when > evtchn_upcall_pending is false? > > --- a/xen/arch/x86/hvm/irq.c > +++ b/xen/arch/x86/hvm/irq.c > @@ -321,9 +321,10 @@ void hvm_assert_evtchn_irq(struct vcpu * > > if ( v->arch.hvm.evtchn_upcall_vector != 0 ) > { > - uint8_t vector = v->arch.hvm.evtchn_upcall_vector; > + struct vlapic *vlapic = vcpu_vlapic(v); > > - vlapic_set_irq(vcpu_vlapic(v), vector, 0); > + if ( vlapic_enabled(vlapic) ) > + vlapic_set_irq(vlapic, v->arch.hvm.evtchn_upcall_vector, 0); Shouldn't the vlapic_enabled() check itself be in vlapic_set_irq()? We certainly don't want any vectors set until the vlapic is enabled, be it event channel upcalls or any other sources. Maybe best to add an ASSERT in vlapic_set_irq() to be sure the lapic is enabled, as other callers already check this before trying to inject? Also, and not strictly related to your change, isn't this possibly racy, as by the time you evaluate the return of vlapic_enabled() it is already stale, as there's no lock to protect it from changing? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Nov 18 14:27:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 14:27:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445814.701225 (Exim 4.92) (envelope-from ) id 1ow2Kv-00041U-Jd; Fri, 18 Nov 2022 14:27:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445814.701225; Fri, 18 Nov 2022 14:27:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow2Kv-00041L-Eu; Fri, 18 Nov 2022 14:27:21 +0000 Received: by outflank-mailman (input) for mailman id 445814; Fri, 18 Nov 2022 14:27:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow2Kt-0003yS-GF for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 14:27:19 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 194d55da-674d-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 15:27:17 +0100 (CET) Received: from mail-dm6nam10lp2103.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Nov 2022 09:27:13 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by SJ0PR03MB5486.namprd03.prod.outlook.com (2603:10b6:a03:28d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 14:27:09 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860%5]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 14:27:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 194d55da-674d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668781637; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=+qPcSZPRcCEGhfaQTMUwLxLzGhIEdK+SWBMxKB4hHc0=; b=YwHrqiXLdYIw5l8930U4EAwmYxS7VTB91i1QoI7a2x+DpMoRIpTUOnr2 J36LmuVzY0gAoPamsNSVbm5NrYq1lhMTdv/8HCvtvKCA5RPHAmXYjQq3r EJ0fPVwgRqE8+LhmMwKyuKU5wjrBv17X3EC80mHIsot2d/qe+QNzBmSU1 M=; X-IronPort-RemoteIP: 104.47.58.103 X-IronPort-MID: 85540255 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:a8C5zqP5XzYWOu3vrR2VlsFynXyQoLVcMsEvi/4bfWQNrUoh32cHn zccDTrTafzfZWajct9waouxoxsHuJPdndBnTgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5wxmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uBtMDthq uYBEwI2VBuSu7+H5pK0Y/Y506zPLOGzVG8ekldJ6GiBSNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PpxujCIpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8efwH6nANhPSdVU8NZgqmyzmWlOOCRJbgah+deemHbkWI5Qf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmSzoLE7gDfAXILJhZZYcEinN87Q3otz FDht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHeTJobixvOSpNvFfCzh9isQTXom WnS9245mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5 hDoR+D2ADgyMKyw IronPort-HdrOrdr: A9a23:+BtNl6kk4E+OQWb4hgjaXFp9W9rpDfNGiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtND4b7LfCRHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaFp2IhD0JbjpzfHcGJjWvUvECZe ChD4d81k2dUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpixBiSgSiu4LvaFQHd+hsFSTtAzZor7G CAymXCl+6emsD+7iWZ+37Y7pxQltek4txfBPaUgsxQBiTwhh2ubIFBXaTHmDwuuumg5Hsjjd GJiRY9OMZY7W/XYwiO0FPQ8jil9Axrx27pyFeej3emicvlRAgiA84EoY5CaBPW52cpodk5ic twriuknqsSKSmFsDX25tDOWR0vvk2ooUA6mepWq3BES4MRZJJYsIRa1kJIF5UrGj789ekcYZ 9TJfCZwMwTXUKRbnjfsGUq6NuwXk4rFhPDeUQGstz96UkloFlJi28jgOAPlHYJ85wwD7Ne4f 7fD6hunLZSCucLcKNUHo46MISKI12IZSiJHHOZIFzhGq1CEWnKsYTL7LI84/zvUIAUzaE1hI /KXDpjxCIPknrVeIyzNaBwg1DwqD3XZ0Wv9ige3ek1hlTEfsukDcXZI2pe0fdJoJ0kc77msr iISddr6sTYXBrT8LZyrnLDsqZpWAcjue0uy6MGsgG107b2A7yvkNDnW9DuA5eoOQoYewrEcw s+tX7IVY990nw= X-IronPort-AV: E=Sophos;i="5.96,174,1665460800"; d="scan'208";a="85540255" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ek7EuKT8Pv5zJsEzXaFCELMLc0bjXbP+4knfDCODgongd6rNi/ADuHJLEQSzL5asNwWGf1V0AqmPhhNBA783ei3bqTDzGD+K7XxEN90UAeKrFyQSb5Yf+4q2EHbiFoyOhbzM0MI6tjphW7qLKNWy/wskggLJz7MPDUzfVkOI+MJp6beZnzaT1ixKJRSkNS/u/dTJoEkY/K2uXpl77hwtZavhH14QJrbwZnhQZuEBFuOXVHAIIhZeT/rFnYiCZVJ/sJaDObcltIBf0ysFxY6deCTL8rsBofRoS1VsVlXDMM4ObF4dvSAXC+FDtQO2NEjTxu/jk59ID3E8Mek1kROYSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+qPcSZPRcCEGhfaQTMUwLxLzGhIEdK+SWBMxKB4hHc0=; b=Q1Q2He3+Rk9jKUhfHvOzrN8iE6EkhS5YYoD1pZ3/ZY4FYctJSB4SqYnUdSGKrBTNQBPABuP7aVyuq1zYyNdVeFeGbdDxxgPnm8Av1TraMm4UL98NIMimEue0F9U26SKDUZSl5EBg/12OxaqKzgLVQ1vtFxTbTWbH8DoOqRQIbEk1UlGLiaNUKISFCmjJpaHpMsUOwRAlWupiTf50rfentnhrihxdyV6m8FttX8o7Q01cu1r1jb7/WVtrBXt5gsplzv7K9ko/VqeXu3XQjFBtandxfZTgmzqqOlXCpWJE9Ua5/XU6fvCzrBSlenVvOGxNZwQW2cQLLj7rBgKKbDUC5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+qPcSZPRcCEGhfaQTMUwLxLzGhIEdK+SWBMxKB4hHc0=; b=XZM4Uuo0Sw1konxNmkug8oBju5K4/Lb1mvo7Zj66bX/kxTrz8BX+03ZB3kegVs1RGmiaim7E7CL7KSpO1CdyFjMKyxakvJ76D1GcdmyWsKTZqfwMc7Tx0IdKDJiM437f1QVUAfhymT4Y7dpUkJb2S7ak1aZLCmA+usUlEv/usug= From: Andrew Cooper To: Jan Beulich CC: Wei Liu , Roger Pau Monne , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Thread-Topic: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Thread-Index: AQHY+zjv47cM7GZ23kWVhiI/91aGOa5EnVaAgAAGB4CAABnfgA== Date: Fri, 18 Nov 2022 14:27:09 +0000 Message-ID: <5a2df843-1acd-ad78-baff-e47befd0703c@citrix.com> References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> In-Reply-To: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|SJ0PR03MB5486:EE_ x-ms-office365-filtering-correlation-id: 97222673-4b13-4926-db52-08dac970f9f5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Oyt78VZHT3zaioAohWSfHu4zKOkpU4f4nCHQPluFumvpZXnsXZNqSfHQtai2PldJZ1PJQv64eGh9dcL7LhLSZcWimUycpZa7s0IqqGy1Av9LlPauouPaG7olCwDrWw2LOFsQTCIsTveOlp3lhCHGi/h7sg9SZJyrDG4jqS2g++MzxVklYdfElt4a38IyBvKB4HvHE22OrR0qPQ76Cw5UGCjPLh7mgMfn+EB61CKKdVtStGD2QdIZNLvnQVZBAQ640nHtsbFeuKiqZIUWpnbzij5+SsR7OLHoafKRP2+XkLX9n1BetSfWWZbYm3PfDDE1fa9iDMt+p8C8Rg8HAkVMut2at1ND4L5NLjC+20gwvXspqk4LvDQqxVA2Y0JLLq5XhO8sbWZaGJ2rFaJyFugejtF0auT9sXGqhaDHyf7u+HXP5HigLDCR3Uyrdzfw3p7gGn+o3BKwidfBGFbfs8AYnidP2suAFUwdgNwAAmqozr3mML1J/H1bXgg4bAVFR1xo4hAiMAWIwBd9AoPDYk7ZJKzfXkPaRxvo6pvdDMERmrvLGgTa4fPInzNuZXX4R574JHPylghgsZI+sdU/cI/XqI/FRt+I4RXFqiAd37uud/ztx0tV/VXZ9CL57V1obcdsmmy/K4ytDy+86C69P/q1rMtHkKuQDCGqgT4l+8X1EiODD6jKp4wr5TIK+QdbuzBqCMXcH/k9kWe5i7K8dAfDxlsIk1xFjCVhBud9rBcQ4EOr7zLPoFr1Ow6ellLhCWwZJUv6aX8aD/Yl3A7jrRGYeQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(366004)(39860400002)(451199015)(6486002)(31686004)(122000001)(86362001)(6506007)(71200400001)(38100700002)(478600001)(82960400001)(31696002)(316002)(186003)(5660300002)(26005)(6512007)(6916009)(53546011)(54906003)(8936002)(8676002)(66556008)(66946007)(64756008)(66476007)(66446008)(91956017)(76116006)(38070700005)(41300700001)(36756003)(2616005)(83380400001)(2906002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?c2paaW92RHpGd0ZaeEtuazRGMWh1MTg1OUgwdVk0VmlYdlczb1BkS1FnZ01L?= =?utf-8?B?Ti9kQlVpL3lJV29iZmNVWm1abHV4UkVUNklzNnptT2RGWUxzcE5wYzIwYjVK?= =?utf-8?B?TjhBYTN1VUgxK1R6Skp3cmRGdzNzSitjNm10UHMzMUR2Zk56Vmt3Y0ZOV2JR?= =?utf-8?B?Z1ZIdzNGQWRSM0JOZGRzdkEvKzRRaWRhaDNMMVpHV01pdUFXay9mNkFTU0o0?= =?utf-8?B?N3FnZmE0MHJXSlZuckFORzlhdDlDM1lTZW9mWFBoUGhia1JQV0RZRVZCc2Fv?= =?utf-8?B?RnVQYmVZaFFjaW42Unk0TWJVSGdRc3hxSGpnVTdIUHBrRUhMUW01dno5V1pq?= =?utf-8?B?TVV0RmlvdEtGQkM0WVl5TlF0M2s0KzdXM2hxMEFNOVc5R0xpWlFyQStZSXhN?= =?utf-8?B?aXNGMmZrOG16WUM5OTdJNnRiVE1WMDhJQUlKeTVsOXVuMkU4T015YWQxVkw2?= =?utf-8?B?OFBSQU5KeWc2ODMyeTg1TFd4TnR0TnlMQndWK0NPUWR5TjFSMk10YjZzRk9E?= =?utf-8?B?ZU10U0FkQ0VKWGlxRjFIOWkwVXpFdUtpL3dYKy8zbWFvRERTTllBK0thSDV3?= =?utf-8?B?ZWxycHhvYlBZTHBBWkVoV1ZuQzRmMXd5dlNsYU11VG5qWlJyQVZEaDkvK3FB?= =?utf-8?B?cUROUnUyMGdWQWlwN3p5eW12czhZbTcxWWFqZDZsZ0RBQzlaN1NQRFJBcmdv?= =?utf-8?B?Y1ZqeUcxZDI5V0tyVmlkYzkwQnFKZEZiVE1CY0JUeGdPSkJIME9Od0dRT21x?= =?utf-8?B?clh2VS9yWmkvOGdLdzJjY3lBSnNyem9iUjc5eExzWnY2eFhJTGs3SmlZWkFM?= =?utf-8?B?K3Z2bjFUcUN1c1ZxSUV3TEtINHZYRnVlNkIydVFIQi9JemN0b0QxdHNsSUhj?= =?utf-8?B?SEVJeTZKTzdCM3ZOSzB1akJFTkxzdjlZMDdZQSt6VHV0Z2JaS1ZmRUFJZTli?= =?utf-8?B?Q1Q1YW1JTSs3VkxSN3c2WU80RGsvOXltck5BY1JGTFcweWNOUDBtN2MxV09v?= =?utf-8?B?amZXU29mZVY1bUEydWwvQnhLZHJIMmVSdDZKUGdtTXc0VnNoM2pwWEw4aG4x?= =?utf-8?B?S2VtNGFYeklENFNHWHRtMW1zdEJ2TW1WUjNtVG16QllUZDl0ZFNxamFTR1BR?= =?utf-8?B?RUFtVlh6WDk5WUpSQ1ZvNDROdEhuWHZDRVIxRTJEcDJ0MTFueVZEMjBwWWhX?= =?utf-8?B?YzAwTkZpOW13UW9IM3dMNU9sNjhzT21kNGxxVVJEZkNLTVl1RmRlVitweEJo?= =?utf-8?B?dUhhc1V2dnhELzZlQVlFUHh1MitFV2tjQjhNYWZHakExWDRLNXIrL1VQL2NX?= =?utf-8?B?MEEwc0hqRVhNV1RLbEpRcmxlVTRKSnhpTXdJM0V2UW8rZjBVOVBJais5eW80?= =?utf-8?B?SlBtY1BER3VBRERDeUd5YkdQRUFGSGlVV0d3eHdtTnh1YlR2Mmw0RUdBbjVy?= =?utf-8?B?dm5JQ0xPcDZVQzRjbmY1RElVQVRjY1kxWXNKOHJvN2RyQ212aGROZ09iTHh0?= =?utf-8?B?YXE0VjdUc3JsejVvVXJJczhaUTk5MlNxNHFwOHh2UEhxNC9SQzdQZkJ3cXJz?= =?utf-8?B?M0o0V3MwdjY1TlFCZ1lFTmd1bWZ3NTFnNnEyeEtCa1RBeitJKzRoWEdnOENH?= =?utf-8?B?L0gwNUF0eE93K0FKeEZiK0pHQisrQXl3UE0xeHdialdFd3EzZ2NIWFI3VWlu?= =?utf-8?B?VXJVcHNqbWJkOUc4OTloemYvV3F3ZTVQakpqMWZjU2JvWW1YUHlRcktFbENX?= =?utf-8?B?WTRnVjJ2ajgxNk9mV21MTEZwNXE0M1lJQm9PdHcxQndaOWJtVkFBSzZvM0NS?= =?utf-8?B?MU9ZN1JHWTRlMDc3UXBKV09ocmxSS2xJVVBEREhiTkFzVGVCeWZJYW5XRjl3?= =?utf-8?B?cUZtNEk2Qmp5RGErVE9JU2tHTTVldm5CUWNsdlBMa1FGZjd2dWoyekMxemZY?= =?utf-8?B?MTJPditrWUJLUjZYTm5WQzE3TCttWTBvTUdkUWdIekRUWTREQXlkVnFTZ2ky?= =?utf-8?B?T0RES05KdytkRnJDdEp5VUJGRFg3WjZ1VUltRU9WbkhJOXByMG9zRWN4NEpW?= =?utf-8?B?TGlueWhkeGtpVDR4VzZqTTFjYytETXJJdkgvQnVVSllBZDlCakhqdUluNGRH?= =?utf-8?Q?PQn5yhfAZKbpI/oV27Ps4lgHh?= Content-Type: text/plain; charset="utf-8" Content-ID: <4DBF54FC315A59458DD89DA4E89AD598@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: uTgDMtYOsSCED6U85BWdS4YOwowrHFgqui8wxSNjC1Yu21P7UBNjxvIKDIx2czCiBeASiyQP5iYbULH7htOcRfvLBwkQ8YvdIg5YAnqpV9C/qqHDKzAbqxHWGOf3jNKYgLHYaWSd8a+xRZVhm8/hKfBhX17hXLFy0snT460+KhBaog1F4Jegnj80JGsVDWzWb/9EMePBbZtxHiEGf0H7YFKyqyhFHuy1nSQJZN9DbRtnd3LD0ZMWTa30VQzXd+s4tlbdt2qjaZSl042qQ0I9EdxOEvJ7xnadmUiUf1u8irb25H5wQe8Gq0CXHIkPTh4SLOLaxM2k2aWmGzuSTn4jyRRY8MJqbI1ZaZ+JIBCVhlI0rGXOerGrDPyXpiJq4oZwcrHovpkUCZav5gwURZIAutCl76RhHvh9U952P85/xHFIwkXWYwaNZLehYysc42bew8xjQ/49m3C4X70nLtYA3q20y/Qb0Zy5ZeqhP4ti33SqW+vSXA8IOV1LHSd7GD3G7IWIdIONR7pM6O8n+HFK2RcEvwja3uVMzYihE1/YbALDU0G3lO0FBo7ZhNtwl6EynpOPkZRBi0I48Xey4aqUY+lYIj3Wv3R7JLYSAZkwlfUL+ENwbQ4nDfTDVnCEw+hyNS4FGdnxHAFGz4rtMUifimDABs6Ow7PEPeTUZqW7sYex6yky10HbiSpmV0GTr+7jSJeRg77DhRdliyDk5pTSYjrLL/OTYzQWQoev26A+xKn5/Zjv43JmA/GHhs5U5qoqVNQttPDYqnsXJpTob4NHGLBT45EidDgZrJkXSnjmKYciyH0I0JyDAP78FiJjrfZuCKvaCZY0shOfvwLQRDrlGhjCci5fxFYuRdhx/T2g+Lw= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97222673-4b13-4926-db52-08dac970f9f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2022 14:27:09.3193 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c2aeJucJoQ8AQN2pdCRNg0M7X0IE5fsdgjevMt1h3G/oCsuOT6pzgyMmeZZ2OFy/ZuEyo3ZI6Eo9x/pE/yT5FOVRB2v4dsq5l3PNeOoS+Io= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5486 T24gMTgvMTEvMjAyMiAxMjo1NCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE4LjExLjIwMjIg MTM6MzMsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxOC8xMS8yMDIyIDEwOjMxLCBKYW4g QmV1bGljaCB3cm90ZToNCj4+PiBMaW51eCdlcyByZWxhdGl2ZWx5IG5ldyB1c2Ugb2YgSFZNT1Bf c2V0X2V2dGNobl91cGNhbGxfdmVjdG9yIGhhcw0KPj4+IGV4cG9zZWQgYSBwcm9ibGVtIHdpdGgg dGhlIG1hcmtpbmcgb2YgdGhlIHJlc3BlY3RpdmUgdmVjdG9yIGFzDQo+Pj4gcGVuZGluZzogRm9y IHF1aXRlIHNvbWUgdGltZSBMaW51eCBoYXMgYmVlbiBjaGVja2luZyB3aGV0aGVyIGFueSBzdGFs ZQ0KPj4+IElTUiBvciBJUlIgYml0cyB3b3VsZCBzdGlsbCBiZSBzZXQgd2hpbGUgcHJlcGFyaW5n IHRoZSBMQVBJQyBmb3IgdXNlLg0KPj4+IFRoaXMgY2hlY2sgaXMgbm93IHRyaWdnZXJpbmcgb24g dGhlIHVwY2FsbCB2ZWN0b3IsIGFzIHRoZSByZWdpc3RyYXRpb24sDQo+Pj4gYXQgbGVhc3QgZm9y IEFQcywgaGFwcGVucyBiZWZvcmUgdGhlIExBUElDIGlzIGFjdHVhbGx5IGVuYWJsZWQuDQo+Pj4N Cj4+PiBJbiBzb2Z0d2FyZS1kaXNhYmxlZCBzdGF0ZSBhbiBMQVBJQyB3b3VsZCBub3QgYWNjZXB0 IGFueSBpbnRlcnJ1cHQNCj4+PiByZXF1ZXN0cyBhbmQgaGVuY2Ugbm8gSVJSIGJpdCB3b3VsZCBu ZXdseSBiZWNvbWUgc2V0IHdoaWxlIGluIHRoaXMNCj4+PiBzdGF0ZS4gQXMgYSByZXN1bHQgaXQg aXMgYWxzbyB3cm9uZyBmb3IgdXMgdG8gbWFyayB0aGUgdXBjYWxsIHZlY3RvciBhcw0KPj4+IGhh dmluZyBhIHBlbmRpbmcgcmVxdWVzdCB3aGVuIHRoZSB2TEFQSUMgaXMgaW4gdGhpcyBzdGF0ZS4N Cj4+IEkgYWdyZWUgd2l0aCB0aGlzLg0KPj4NCj4+PiBUbyBjb21wZW5zYXRlIGZvciB0aGUgImVu YWJsZWQiIGNoZWNrIGFkZGVkIHRvIHRoZSBhc3NlcnRpb24gbG9naWMsIGFkZA0KPj4+IGxvZ2lj IHRvIChjb25kaXRpb25hbGx5KSBtYXJrIHRoZSB1cGNhbGwgdmVjdG9yIGFzIGhhdmluZyBhIHJl cXVlc3QNCj4+PiBwZW5kaW5nIGF0IHRoZSB0aW1lIHRoZSBMQVBJQyBpcyBiZWluZyBzb2Z0d2Fy ZS1lbmFibGVkIGJ5IHRoZSBndWVzdC4NCj4+IEJ1dCB0aGlzLCBJIGRvbid0IHRoaW5rIGlzIGFw cHJvcHJpYXRlLg0KPj4NCj4+IFRoZSBwb2ludCBvZiByYWlzaW5nIG9uIGVuYWJsZSBpcyBhbGxl Z2VkbHkgdG8gd29yayBhcm91bmQgc2V0dXAgcmFjZQ0KPj4gY29uZGl0aW9ucy7CoCBJJ20gdW5j b252aW5jZWQgYnkgdGhpcyByZWFzb25pbmcsIGJ1dCBpdCBpcyB3aGF0IGl0IGlzLA0KPj4gYW5k IHRoZSBzdGF0ZWQgYmVoYXZpb3VyIGlzIHRvIHJhaXNlIHRoZXJlIGFuZCB0aGVuLg0KPj4NCj4+ IElmIGEgZ3Vlc3QgZW5hYmxlcyBldnRjaG4gd2hpbGUgdGhlIExBUElDIGlzIGRpc2FibGVkLCB0 aGVuIHRoZQ0KPj4gaW50ZXJydXB0IGlzIGxvc3QuwqAgTGlrZSBldmVyeSBvdGhlciBpbnRlcnJ1 cHQgaW4gYW4geDg2IHN5c3RlbS4NCj4gRWRnZSB0cmlnZ2VyZWQgb25lcyB5b3UgbWVhbiwgSSBz dXBwb3NlLCBidXQgeWVzLg0KDQpGb3IgSU8tQVBJQyBzeXN0ZW1zLCB5b3UgbW9zdGx5IGxvc2Ug bGluZSBpbnRlcnJ1cHRzIHRvbywgZG9uJ3QgeW91Pw0KDQpUaGUgbGluZSB3aWxsIHJlbWFpbiBw ZW5kaW5nIGF0IHRoZSBJTy1BUElDLCBidXQgbm90aGluZyBpbiB0aGUgc3lzdGVtDQp3aWxsIHVu d2VkZ2UgdW50aWwgc29tZW9uZSBwb2xscyB0aGUgSU8tQVBJQy4NCg0KRWl0aGVyIHdheS4uLg0K DQo+DQo+PiBJIGRvbid0IHRoaW5rIHRoZXJlIGlzIGFueSBjcmVkaWJsZSB3YXkgYSBndWVzdCBr ZXJuZWwgYXV0aG9yIGNhbiBleHBlY3QNCj4+IHRoZSB3ZWlyZCBldnRjaG4gZWRnZWNhc2UgdG8g d2FpdCBmb3IgYW4gYXJiaXRyYXJ5IHBvaW50IGluIHRoZSBmdXR1cmUsDQo+PiBhbmQgaXQncyBh IGNvcm5lciBjYXNlIHRoYXQgSSB0aGluayBpcyB3b3J0aCBub3Qga2VlcGluZy4NCj4gV2VsbCAt IGRpZCB5b3UgbG9vayBhdCA3YjViOGNhN2RmZmQgKCJ4ODYvdXBjYWxsOiBpbmplY3QgYSBzcHVy aW91cyBldmVudA0KPiBhZnRlciBzZXR0aW5nIHVwY2FsbCB2ZWN0b3IiKSwgcmVmZXJlbmNlZCBi eSB0aGUgRml4ZXM6IHRhZz8gVGhlIGlzc3VlIGlzDQo+IHRoYXQgd2l0aCBldnRjaG5fdXBjYWxs X3BlbmRpbmcgb25jZSBzZXQsIHRoZXJlIHdvdWxkIG5ldmVyIGFnYWluIGJlIGENCj4gbm90aWZp Y2F0aW9uLg0KDQpPaywgc28gd2UgZG8gbmVlZCB0byBkbyBzb21ldGhpbmcuDQoNCj4gIFNvIGlm IHdoYXQgeW91IHNheSBpcyB0byBiZSB0aGUgbW9kZWwgd2UgZm9sbG93LCB0aGVuIHRoYXQNCj4g ZWFybGllciBjaGFuZ2Ugd2FzIHBlcmhhcHMgd3JvbmcgYXMgd2VsbC4gSW5zdGVhZCBpdCBzaG91 bGQgdGhlbiBoYXZlDQo+IGJlZW4gYSBndWVzdCBjaGFuZ2UgKGFzIGFsc28gaW1wbGljaXQgZnJv bSB5b3VyIHJlcGx5KSB0byBjbGVhcg0KPiBldnRjaG5fdXBjYWxsX3BlbmRpbmcgYWZ0ZXIgdkNQ VSBpbmZvIHJlZ2lzdHJhdGlvbiAodGhlcmUpIG9yIExBUElDDQo+IGVuYWJsaW5nIChoZXJlKSwg cGVyaGFwcyBieSB3YXkgb2YgIm1hbnVhbGx5IiBpbnZva2luZyB0aGUgaGFuZGxpbmcgb2YNCj4g dGhhdCBwZW5kaW5nIGV2ZW50LCBvciBieSBpc3N1aW5nIGEgc2VsZi1JUEkgd2l0aCB0aGF0IHZl Y3Rvci4NCj4gRXNwZWNpYWxseSB0aGUgTEFQSUMgZW5hYmxpbmcgY2FzZSB3b3VsZCB0aGVuIGJl IHlldCBhbm90aGVyIFhlbi1zcGVjaWZpYw0KPiBvbiBhIGd1ZXN0IGNvZGUgcGF0aCB3aGljaCBi ZXR0ZXIgd291bGRuJ3QgaGF2ZSB0byBiZSBhd2FyZSBvZiBYZW4uIA0KDQpXaXRob3V0IHRyeWlu ZyB0byBwcmVzY3JpYmUgaG93IHRvIGZpeCB0aGlzIHNwZWNpZmljIGlzc3VlLCB3aGVyZXZlcg0K cG9zc2libGUgd2Ugc2hvdWxkIGJlIHRyeWluZyB0byBsaW1pdCB0aGUgWGVuLWlzbXMgZnJvbSBu b24tWGVuIGFyZWFzLsKgDQpUaGVyZSdzIGEgd2hvbGUgbG90IG9mIHBvb3JseSBkZXNjcmliZWQg YW5kIHN1cnByaXNpbmcgYmVoYXZpb3VycyB3aGljaA0KaGF2ZSBub3Qgc3Rvb2QgdGhlIHRlc3Qg b2YgdGltZS4NCg0KSW4gdGhpcyBjYXNlLCBpdCBzZWVtcyB0aGF0IHdlIGhhdmUgeWV0IGFub3Ro ZXIgeDg2IFBWLWlzbSB3aGljaCBoYXNuJ3QNCnRyYW5zbGF0ZWQgd2VsbCB4ODYgSFZNLsKgIFNw ZWNpZmljYWxseSwgd2UncmUgdHJ5aW5nIHRvIG92ZXJsYXkgYW4NCmVudGlyZWx5IHNoYXJlZC1t ZW1vcnkgKGFuZCBkZWxheWVkIHJldHVybi10by1ndWVzdCkgaW50ZXJydXB0DQpjb250cm9sbGVy IG9udG8gb25lIHdoaWNoIGlzIHByb3Blcmx5IGNvbnN0cnVjdGVkIHRvIGhhbmRsZSBldmVudHMg aW4NCnJlYWx0aW1lLg0KDQoNCkkgZXZlbiBnb3QgYXMgZmFyIGFzIHdyaXRpbmcgdGhhdCBtYXli ZSBsZWF2aW5nIGl0IGFzLWlzIHdhcyB0aGUgYmVzdA0Kb3B0aW9uIChwcmluY2lwbGUgb2YgbGVh c3Qgc3VycHJpc2UgZm9yIFhlbiBkZXZlbG9wZXJzKSwgYnV0IG91cg0KImZyaWVuZCIgYXBpYyBh Y2NlbGVyYXRpb24gc3RyaWtlcyBhZ2Fpbi4NCg0KWGVuIGRvZXNuJ3QgYWx3YXlzIGdldCBhIFZN RXhpdCB3aGVuIHRoZSBndWVzdCBjbGVhcnMgU1dfRElTQUJMRSwNCmJlY2F1c2UgbWljcm9jb2Rl IG1heSBoYXZlIGFjY2VsZXJhdGVkIGl0Lg0KDQpBIGNvbnNlcXVlbmNlIG9mIHRoaXMgb2JzZXJ2 YXRpb24gaXMgdGhhdCBYZW4gY2Fubm90IGhhdmUNCm5vbi1MQVBJQy1hcmNodGllY3R1cmFsIGJl aGF2aW91ciBpbiB0aGUgdmxhcGljIGVtdWxhdGlvbi7CoCBTbyBJIHRoaW5rDQp3ZSBuZWVkIHRv IGZpbmQgYSBzb2x1dGlvbiB0byB0aGlzIHByb2JsZW0gdGhhdCBkb2Vzbid0IGhvb2sgQVBJQ19T UElWLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri Nov 18 14:40:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 14:40:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445823.701236 (Exim 4.92) (envelope-from ) id 1ow2XH-0006g3-Rd; Fri, 18 Nov 2022 14:40:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445823.701236; Fri, 18 Nov 2022 14:40:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow2XH-0006fw-OM; Fri, 18 Nov 2022 14:40:07 +0000 Received: by outflank-mailman (input) for mailman id 445823; Fri, 18 Nov 2022 14:40:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow2XG-0006bH-KN for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 14:40:06 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e349284f-674e-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 15:40:05 +0100 (CET) Received: from mail-mw2nam10lp2104.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Nov 2022 09:40:02 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by CH0PR03MB6113.namprd03.prod.outlook.com (2603:10b6:610:b8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 14:39:58 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::2393:22c1:7766:5caa%5]) with mapi id 15.20.5813.016; Fri, 18 Nov 2022 14:39:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e349284f-674e-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668782405; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=8HUZYwP7dd08boQwshX7Unr0XRMHi75S02MTCz7VE2U=; b=TWEcSXvzQ7vUDiQ2HwhxiR/c0jVdaWCJCB+YRSp9PpvSHm0Sj8NVD7Zm u5utnwnzqjmj2kEU9HGe85CwpqkrXzCeKtxnoXrYvBMN2G9UrXNsHrbUo LxZgvUFxWLKF+FATAhdlick0rOgtPYdVs9RN9p6STydY8qRzT7AUwJA8y c=; X-IronPort-RemoteIP: 104.47.55.104 X-IronPort-MID: 85541248 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:EPiF8alM5SLVkEnLV7Ra1GXo5gyTJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIcX2jUOPzYMDbyeNska4XloUIDvpTWzN5lSFc4/ChgRiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5Q+GzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 c5BAXMzSgrdvd+J64qWY+lVlvYIM+C+aevzulk4pd3YJdAPZMmbBoD1v5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3ieCxWDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnzX6mBNtISO3QGvhChlC0/3ZCAg8qb16li/OC00u+dMJ7J BlBksYphe1onKCxdfHdUhuisTi7txgTc9NKFqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9WopWm1876VqXa3JnITJGpbPSscF1Jdv5/kvZ05iQ/JQpB7Cqmpg9bpGDb2h TeXsCw5gLZVhskOv0mmwW36b/uXjsChZmYICs//BwpJMisRiFaZWrGV IronPort-HdrOrdr: A9a23:tunLSKzjWDGW4JMWE6RPKrPxRugkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICOgqTM6ftWzd1FdAQ7sD0WKP+UyCJ8S6zJ8n6U 4CSdkDNDSTNykcsS+S2mDRfbcdKZu8gcaVbI/lvgpQpGpRGsVdBmlCe2Sm+hocfng9OXN1Lu vq2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJTIWGhI97wGKrDWwrJr3CQKR0BsyWy5Ghe5Kyx mPryXJooGY992rwB7V0GHeq7xQhdva09NGQOCcl8QPLT3oqwCwIKBsQaeLsjwZqPymrHwqjN 7PiRE9ONkb0QKYQkiF5T/WnyXw2jcn7HHvjXeenHvYuMT8ABY3EdBIi451egbQrxNIhqA07I t7m0ai87ZHBxLJmyrwo/DOShFRj0Kx5V4vi/QagXBzWZYXLJVRsYsc1kVIF4poJlON1KkXVM 1VSO3M7vdfdl2XK1jfo2lU2dSpGk8+Gx+XK3JyyPC94nxzpjRU3kEYzMsQkjMr75QmUaRJ4O zCL+BBiKxOZtV+V9MzOM4xBe+MTkDdSxPFN2yfZX79ErscBn7Lo5nrpJ0o+eCRfoASxpdaou WMbLphjx9yR6vSM7zP4HUSmSq9A1lVHA6dh/223qIJ9IEVH9HQQG++oFNHqbrSnxxQOLyfZx +JAuMmPxbSFxqQJW935XyBZ3BzEwhqbCRHgKdOZ3u+5uT2F6bNisv3NN7uGZuFK0dVZoq4OA pIYATO X-IronPort-AV: E=Sophos;i="5.96,174,1665460800"; d="scan'208";a="85541248" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WyMO7Yqk5Um1sf1F1Gob00Kc5O9Nme1XFbTiQWa1uKJ4uEFU4k+trzPKZsz3bKhj4u3/uHK3b60R6KU1fiS4HuBXkOv09/LUQpcEUlsAgLednAVhmj2BOrfPw4/poe+8i4QL1YvMeqDKTXM5oO8g58ealTNsy1ePicMvZZyA2NdSmFuxLUqX9m2DUXj6CNWnhPSwcqfYLCM++/UBpta8sx9Sj0wy/T4kUVQTgVrzv+KkvDI9s3hxYaWn4e5jdVekrsxscY6Fkb7+cJIfLx3xs6F+QPLyunU0rqOWvJi33uyU51xGDjLL6FbikMwNYgbSmLklF/fD136y5Pm/qPSNbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XcYhGxGlfRIrYHUNUGzrdlSjRttcGg75WlNpZCiPtdI=; b=WJ1x4DmX3jkJ0LIFUJ8J7L19r4i+S0xhtJXs2b0Cj7Q/8gZXhEdhPJ6Nl5aB0slpkBg2v46bP3W3LFEedrb0ULIkO407fGyIXcztoJnd5dXBj+0Ni7AtEYW3bZrhjO2scpSfzr+qNs9ZlkvtUZ7Z5dGdc0t04XKf8J1hWH374dhaDroR7nogsMGDy8YPML1WP5gedQXlQMkdNVEI8TLWxKapV1khG3UP6M4pE/P3PJoCtvB8Vlk074Uu42fmLNTjExvIUxW9r3fZBsQI0M3n8GylvV/85oJIHEbWeXZkPzJXgofun/Jh3iXAl1HZDhdm3VTTWFFHBDwz4VYDSkc8NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XcYhGxGlfRIrYHUNUGzrdlSjRttcGg75WlNpZCiPtdI=; b=Z5q0Ora/n02Bfh8EQbUlAV8UP3H4XRAjmYZl6oDd3fd7L8PI1serh92mMiTQRpglSJowS3kykSXoDmCAg6Zr0LSUBShwCjj/XiXr9La+JKeH6GPkjMlY/el+aJphCpnDvS+k0skAZBEZyOEk1iBEBCK3e3KXd55E54k0/6fjH+k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 18 Nov 2022 15:39:53 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper , Henry Wang Cc: xen-devel@lists.xenproject.org Subject: Re: [xen-unstable test] 174809: regressions - trouble: broken/fail/pass Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO6P123CA0005.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:338::10) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|CH0PR03MB6113:EE_ X-MS-Office365-Filtering-Correlation-Id: 65db40db-c2b2-46bc-2f0c-08dac972c419 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yP/xs/fy1/h92qDF9vAQDP12KPpjFvtvkxghRVDLE8+F6aSmlenWoji2zMdqiawnov8duoh9PUD6zdIyb1AJJQ4Nlk18yJkFQZICIfKznhpwCI4+cPMjRgTOFMEoVzES2Qwx08JWoNw2jjwogftx6j0NhAq9DFvvgCQgVDJ4nxXC51UXOCno26BRCwef0TQkyD6Og6UoCb+slZEXU02iyICopBQwz3OpkY2CU1iy1mhN0SzUKxSBN9dkoapxmUu4nP67pHPpo9Z3BSMwUmjXT6+iKOEBzDbl3GGB1PRH7kNWr/GE4w6/HE+shKq9JTgCr0ZQuqcDP2GoBxMcrfOw9ef+D5dGVwkXL3VGlMbV353Ru6PbVH0f/pfonTRkXi9DV0ZknrwSRTTMx7iir4JiNGi5P6VRoZP62246X0UvyhKCOJUN+uodNVlmVODWHMkubHwFTMSfTJqTPQo7h7w0ggTVaxVOusthlhE1fsOQ4eF9IIevPf+lF/jz8UPv+Kzq6o/Wgyyw9d+8l+CWEOqCkHHY2qMXa2Gbe1UAKrYvZnldQ0nW+3TH7AkALzs32SLXiICFrdWGztRSrhXM/FDc9jyoX8Mu+Z7HLYAmwLFg+6ZkVpf5MUA93TPRQkKCq8YUNahvOAeOOhdsHHkdscrKCKnSjg+KFKeFn0lh9pBCI0w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(366004)(136003)(346002)(39860400002)(396003)(376002)(451199015)(82960400001)(6512007)(26005)(316002)(8676002)(38100700002)(66556008)(4326008)(9686003)(86362001)(66946007)(66476007)(83380400001)(5660300002)(2906002)(41300700001)(85182001)(8936002)(186003)(478600001)(6486002)(966005)(33716001)(6506007)(6666004)(110136005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cENQT21oRFc1dzlWU2pXbEQ1V0NiZ1BUN2xJSkNhMUhuRUxJb3ZTOUdsdmda?= =?utf-8?B?dElPWjRTbmgzaFlTZU1sSXBMTThjTlpkYndsU3c4b0tmVnBMSnlBeVRZeTNh?= =?utf-8?B?bjNwREtGL0w4emY2RmlMdnd2WkZpK2x3NExNeVJBN0RkS2x2ampTRVJhSzZK?= =?utf-8?B?bFJmekc2eEtZb0ZGSVhndjQ3MlJLM0lvRTFQdllOZzV4ZXE4bFNBdXVXN1Nr?= =?utf-8?B?ODY0V3BsM0FKUWg0Tndnb3hESlZ2UW5BK21JZ1RQVHd6T3NPeFlBVHlkOTFC?= =?utf-8?B?STM5T3hncjRyQmhBaFJNSzN0L2tUdllGMXkwMjAwMnN1K2xETVNTd1lnVU1a?= =?utf-8?B?bEhKcldaVldGbktRNjZCVU5IL2ZEZFRHbnV0OHk2R1ExckwrK0NEemFEcllo?= =?utf-8?B?bExrU3hhbEhzaC9TK2xlWFlLb1JkYW1EMC9tZVFzN2VJbFBKSVpzZVVXS0to?= =?utf-8?B?S2M2Um1pTFlra0hEZThQVVQ2cy9SZUYzRmdCUUJvVXlTUXZ4WGtJK2s5V3dk?= =?utf-8?B?aWhXUkI4b1QxU3J1RzVjRmtHUE9KZWxpU2UzakVjTUJnV3cvcUtMdEpiNjA3?= =?utf-8?B?TWw2ZlpzbVlMbHp1OTlEUmdRN0Q1K1gzdEExa1Ywc2Z2aDd0Q0YwaHdZeVNo?= =?utf-8?B?MWNIdmJsdjZGNWlMTnpnMm9DV0J4RXpDcGpvTTBjL1ZvOHlORlNrSklxd0Y3?= =?utf-8?B?djc2Qko3N2ErY0Y2dXdRM1RLZGJyM1grUmtRSU5ydFdRcWpNWXgwN2lpREpW?= =?utf-8?B?QXRiUjhMWmQyaUtwZU5uNnljQ3p2L3gzQnBPREladWcyWTNVelZDbWtTcmZ0?= =?utf-8?B?WmxSblB5d1I3cFRaaldYSGxNT2xQUTRGQ1NHMlM1RjVvVDJwNUpQdk1LNmE2?= =?utf-8?B?ZHRhMUZyU0R5U1Nrem9VSjVPUU8yV3AwaWdHNTVlUC8xcS9CQ2FKOVo4L0hn?= =?utf-8?B?VXZid1JPTklmR1prd09vZEQ2SGN2SGFYbWl3Z3RjblFvdENxM0MrVkJ2ZENY?= =?utf-8?B?S1BHcS9Zc2xxODcvMVNPS3grUW5uVzhSeWJ6UVgxdTkzaTVjY21KbXRUUEwy?= =?utf-8?B?Smc3dEN5WFl0ZUt5VFVxWEtPcUhNaHdSNlZUVkRqb3NDU2prKzFrcUVaQ09W?= =?utf-8?B?Y210S3ZBRHQxTGUramtIWVkyVXhYcllvT0JhQ3lJd1BkZ1BiSXFyRFpjbGVk?= =?utf-8?B?ZUNGYjJ5SEV5eFVOS0JxWTErMUx5RXF4NS80T1lzTDZFVE1lZjNCVSt6eFU4?= =?utf-8?B?VXdFUUFXQ1hKQ2N4SWdzVVdBQnZ4REZmS2E5Tm5KejJQaWtMOXo4dkdWZWdl?= =?utf-8?B?NFplRmVUUG9RUG5CTjlJMmVQZlcxY3JqK2hVM0d3elo1M25ubE5tV0x4VXVI?= =?utf-8?B?eTlkOWJCbEQ0cnVjT2RZaFB2dUFPOE5aYkhDQzVhU2w0aVpsZ3NMRnVHUnpv?= =?utf-8?B?MzhGTWdOWFh6UGZtR09xOWRKS0Y5czlKQS9tSmZNdk1BUUxsdVpwREpJMk5N?= =?utf-8?B?dmxSb2NaK0VnbnlJeDRUWnF5aWZlQkRadVVLcmEycFRVaDAybVhUM2VZYno3?= =?utf-8?B?aUFFblRNK1FVSDJqbFMxZTIyVEJnMDg0UCtkeUk3R2Q1K01raE5BWXF0a21C?= =?utf-8?B?QklTaHplaitYaXMydVNDV2l1dHp3RkhOeGZTbHRkT3hQQU5YM1lxaEUxK2Rl?= =?utf-8?B?WHlPMmNQTVprem5ENE4xemp3M2RPMWZueTI3aXZzOWRueXptK3k4bS80Uktz?= =?utf-8?B?WmVKYUs3OTR5S3NnSmFnbjhYckhWK0F6YWhlRkVEeDIveEZHWW1VaUY4a3B0?= =?utf-8?B?RzBuZzE2WjRVWm4zZklzOFMzQmplcU1POWhoeXc5WGg4dzIxYmZLWDVkZWR0?= =?utf-8?B?VHhtWmZGbXA3UjR0WDVkVnJOVXJWMG00amxjN2c4TnV5Zk5kNlR2aUpFd0Jx?= =?utf-8?B?eFlSdHFZYThDOHhmZkI2OVFEZ2ZmTWZwYko1V0pna2pzR01MaXNBWThMQW83?= =?utf-8?B?YmtZQ1g2U3BlaVpMV3BzSDcrUEdkVDhUMlFTUlUzd0UrdmxzOTg0ckFsTmxL?= =?utf-8?B?eGRFWXJYTlVjNE9RdmdrbEZIdmtybTNPTkdUd1Y0ZWREMU16SmJJcmxuRDVw?= =?utf-8?Q?E83lrx8mNKeLmOn6UOk/k5Ub4?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: PIUmeSdLuNFkSiP1FvkneBfF8kB7dMhvbABKNHOKr4324jOOZgH6p1gHMW3Jc7YrCkaSOEEDo+5wbdqWNasGcBawTwwNSMaD9NhK/UNsGMOQgfnKa+bDmY/Qu5AHibu9buV4bn8qXZu0lk+eosF6IzxCOj2S7wBEvTCZOnvjMuuTD9X/l67AeqKsYpMz89tUPsVBMdfQYa0lirLwKhaSaPJ5utgAz8ZywsFolkFB1j1xYNQKGVd93DCUyjNIoMPi2YoJBiJ9lSr8GvxOvGPu1LZX0G5PQVPSHX7bIj8J0X9S4d/9/MYSQqVBGWRsIJGyPCc0hY74uJ4NzU5MwEuPi9lBpbdIED3Em/k3pRsLlGefV8YRCMo7XGg1r5D3BJtGe1+lgfv7vczzN7W+e2Z4+Gn4a4E0L4yzbiBYGLxSdH1kprzBNtokKCkapUhzk17GBgb8Ak5WEfuF4JypkxUwpLajd5JLHC8e/GhJ12beeGXtzQIliwLnaTKQ2AfNhxqWV4NvQyBFklrGCzTNPaCm/l08EbN8h3XgTbBzeJjjH3xhuSa+osOEziXtzvRZ4wl7JnsnAW49OOGQFtTxC5q4X/MkYikfvV0roZVjxJUVYKLAO+FGCLyrWtYlgZQdLUVUjP5xE+0NWEVujpx9drttobThdHBj7IFJqpSDNIb1Yzfzvoxk3GDDICX5frsuSXi5VAla7Z2KMCG4JX8+BtNv8m64o45HhlX3mAi8VUcFR4IQ8UtkE6fvTw0Jj2XKNLGKyhSBi6Q0U9UdEm6OOB75KzBhWlpzFbXDrU2J2FAcYC4= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65db40db-c2b2-46bc-2f0c-08dac972c419 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 14:39:58.7150 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bHdaImq1Zb/X1HsVp4USBVN5tEkEPpBUGP8Eaz8pbQKnzZe5vqOMR0QOfoWaW6ou5nFVMhldVCIT+5H3Yp0amQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6113 On Fri, Nov 18, 2022 at 10:21:52AM +0000, osstest service owner wrote: > flight 174809 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/174809/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken > test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 5 host-install(5) broken REGR. vs. 174797 > test-amd64-amd64-xl-credit2 20 guest-localmigrate/x10 fail REGR. vs. 174797 > test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 > test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 > test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 > test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 > test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 > test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 > test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 > test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 174797 Looking at a random failure: Nov 18 01:55:09.233941 (d1) Searching bootorder for: HALT Nov 18 01:55:11.681666 (d1) drive 0x000f5890: PCHS=16383/16/63 translation=lba LCHS=1024/255/63 s=20480000 Nov 18 01:55:11.693694 (d1) Space available for UMB: cb000-e9000, f52e0-f5820 Nov 18 01:55:11.693754 (d1) Returned 258048 bytes of ZoneHigh Nov 18 01:55:11.705648 (d1) e820 map has 8 items: Nov 18 01:55:11.705676 (d1) 0: 0000000000000000 - 000000000009fc00 = 1 RAM Nov 18 01:55:11.705701 (d1) 1: 000000000009fc00 - 00000000000a0000 = 2 RESERVED Nov 18 01:55:11.717716 (d1) 2: 00000000000f0000 - 0000000000100000 = 2 RESERVED Nov 18 01:55:11.717768 (d1) 3: 0000000000100000 - 00000000effff000 = 1 RAM Nov 18 01:55:11.729687 (d1) 4: 00000000effff000 - 00000000f0000000 = 2 RESERVED Nov 18 01:55:11.729745 (d1) 5: 00000000fc000000 - 00000000fc00b000 = 4 NVS Nov 18 01:55:11.741693 (d1) 6: 00000000fc00b000 - 0000000100000000 = 2 RESERVED Nov 18 01:55:11.741752 (d1) 7: 0000000100000000 - 0000000148000000 = 1 RAM Nov 18 01:55:11.753644 (d1) enter handle_19: Nov 18 01:55:11.753721 (d1) NULL Nov 18 01:55:11.753796 (d1) Booting from DVD/CD... Nov 18 01:55:11.753864 (d1) Booting from 0000:7c00 Nov 18 01:55:11.753936 (XEN) arch/x86/mm/hap/hap.c:304: d1 failed to allocate from HAP pool Nov 18 01:55:18.633799 (XEN) Failed to shatter gfn 7ed37: -12 Nov 18 01:55:18.633866 (XEN) d1v0 EPT violation 0x19c (--x/rw-) gpa 0x0000007ed373a1 mfn 0x33ed37 type 0 Nov 18 01:55:18.645790 (XEN) d1v0 Walking EPT tables for GFN 7ed37: Nov 18 01:55:18.645850 (XEN) d1v0 epte 9c0000047eba3107 Nov 18 01:55:18.645893 (XEN) d1v0 epte 9c000003000003f3 Nov 18 01:55:18.645935 (XEN) d1v0 --- GLA 0x7ed373a1 Nov 18 01:55:18.657783 (XEN) domain_crash called from arch/x86/hvm/vmx/vmx.c:3758 Nov 18 01:55:18.657844 (XEN) Domain 1 (vcpu#0) crashed on cpu#8: Nov 18 01:55:18.669781 (XEN) ----[ Xen-4.17-rc x86_64 debug=y Not tainted ]---- Nov 18 01:55:18.669843 (XEN) CPU: 8 Nov 18 01:55:18.669884 (XEN) RIP: 0020:[<000000007ed373a1>] Nov 18 01:55:18.681711 (XEN) RFLAGS: 0000000000010002 CONTEXT: hvm guest (d1v0) Nov 18 01:55:18.681772 (XEN) rax: 000000007ed373a1 rbx: 000000007ed3726c rcx: 0000000000000000 Nov 18 01:55:18.693713 (XEN) rdx: 000000007ed2e610 rsi: 0000000000008e38 rdi: 000000007ed37448 Nov 18 01:55:18.693775 (XEN) rbp: 0000000001b410a0 rsp: 0000000000320880 r8: 0000000000000000 Nov 18 01:55:18.705725 (XEN) r9: 0000000000000000 r10: 0000000000000000 r11: 0000000000000000 Nov 18 01:55:18.717733 (XEN) r12: 0000000000000000 r13: 0000000000000000 r14: 0000000000000000 Nov 18 01:55:18.717794 (XEN) r15: 0000000000000000 cr0: 0000000000000011 cr4: 0000000000000000 Nov 18 01:55:18.729713 (XEN) cr3: 0000000000400000 cr2: 0000000000000000 Nov 18 01:55:18.729771 (XEN) fsb: 0000000000000000 gsb: 0000000000000000 gss: 0000000000000002 Nov 18 01:55:18.741711 (XEN) ds: 0028 es: 0028 fs: 0000 gs: 0000 ss: 0028 cs: 0020 It seems to be related to the paging pool adding Andrew and Henry so that he is aware. Roger. From xen-devel-bounces@lists.xenproject.org Fri Nov 18 15:50:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 15:50:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445831.701247 (Exim 4.92) (envelope-from ) id 1ow3co-0005lO-Th; Fri, 18 Nov 2022 15:49:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445831.701247; Fri, 18 Nov 2022 15:49:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow3co-0005lH-Qe; Fri, 18 Nov 2022 15:49:54 +0000 Received: by outflank-mailman (input) for mailman id 445831; Fri, 18 Nov 2022 15:49:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow3cn-0005lA-OP for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 15:49:54 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a171213a-6758-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 16:49:50 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 96280320029B; Fri, 18 Nov 2022 10:49:46 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 18 Nov 2022 10:49:47 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Nov 2022 10:49:44 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a171213a-6758-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1668786586; x=1668872986; bh=KqQEuKxfkbRxTU5nDAZWsBYliBRDq3obTAX NYs/tvIE=; b=LHwyay5CtX5MpoR1iLOr8PAfRyE37G7z4XYVAbrRIz/WZCIn+av 5/sb3jQ1GeRJCdrrEV+LYGsuzghXdL2mgSL4HE+w6deMaPZES3L96l7GlPN6Qa/F 3i2X84FaMkaqd8uJRPosVDOsmpl5Pq6scuPW3M8dRp9LujqbpbbSZYJZH6hsFrKa xQzWB9gi7aUbWQppWD4f1t1zp6YFMBUtqFJ1lmJdNEIo0/HSq7O51sB62pJCxHkm oZEq0TDSUN/p/NYXHJ2l2fI7c6jbmRfmqke20ho4CnaDDdrDx8OuPDJ79T8EX2vy I/k4V8i7soF8+CgSZ5QzuI0PHvNCbKf2+yA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1668786586; x=1668872986; bh=KqQEuKxfkbRxT U5nDAZWsBYliBRDq3obTAXNYs/tvIE=; b=lYaJGjVJkv/Wx0CHAk/JR4cjQZOi8 ouePFaQuyM0eTxEQjeiCLnUtNWgYs5+tzUfaWbpZwTJy/D/Z9LlaGQgpgUhqGWzP c+4D5zANcspwHF1gf7yR8XN5UUWe/XlEeQUDkFseLC8XmaWBcHRYui660Xs/Ydy1 IE2JegSQWUOV7ZEuj+0Nf+pk8ItWH24ZVCPgPt1r5cHg/x7QAuMNbMfEq8XToY7d 45S9WBa06KZPxdkokEmhOizI+g3xqr+R7DXTA3kS+3gnLCCR4wOWrM78FBfbcbMY YXtn+wkFDsvgUEiZrTd06LeDj4tQw78rR+OkiV1R/B/yKlKLFQ6H4lHiA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrhedtgdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffogggtgfesthekredtredtjeenucfhrhhomhepofgrrhgvkhcu ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepleekhfdu leetleelleetteevfeefteffkeetteejheelgfegkeelgeehhfdthedvnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR INTERFACE) Subject: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled Date: Fri, 18 Nov 2022 16:49:23 +0100 Message-Id: <20221118154931.1928298-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until the table is filled. Then it disables INTx just before clearing MASKALL bit. Currently this approach is rejected by xen-pciback. According to the PCIe spec, device cannot use INTx when MSI/MSI-X is enabled (in other words: enabling MSI/MSI-X implicitly disables INTx). Change the logic to consider INTx disabled if MSI/MSI-X is enabled. This applies to three places: - checking currently enabled interrupts type, - transition to MSI/MSI-X - where INTx would be implicitly disabled, - clearing INTx disable bit - which can be allowed even if MSI/MSI-X is enabled, as device should consider INTx disabled anyway in that case Fixes: 5e29500eba2a ("xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKALL too") Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - allow clearing INTx regardless of MSI/MSI-X state, to be consistent with enabling MSI/MSI-X Changes in v2: - restructure the patch to consider not only MASKALL bit, but enabling MSI/MSI-X generally, without explicitly disabling INTx first --- drivers/xen/xen-pciback/conf_space.c | 19 +++++++++++------ .../xen/xen-pciback/conf_space_capability.c | 3 ++- drivers/xen/xen-pciback/conf_space_header.c | 21 +++---------------- 3 files changed, 18 insertions(+), 25 deletions(-) diff --git a/drivers/xen/xen-pciback/conf_space.c b/drivers/xen/xen-pciback/conf_space.c index 059de92aea7d..d47eee6c5143 100644 --- a/drivers/xen/xen-pciback/conf_space.c +++ b/drivers/xen/xen-pciback/conf_space.c @@ -288,12 +288,6 @@ int xen_pcibk_get_interrupt_type(struct pci_dev *dev) u16 val; int ret = 0; - err = pci_read_config_word(dev, PCI_COMMAND, &val); - if (err) - return err; - if (!(val & PCI_COMMAND_INTX_DISABLE)) - ret |= INTERRUPT_TYPE_INTX; - /* * Do not trust dev->msi(x)_enabled here, as enabling could be done * bypassing the pci_*msi* functions, by the qemu. @@ -316,6 +310,19 @@ int xen_pcibk_get_interrupt_type(struct pci_dev *dev) if (val & PCI_MSIX_FLAGS_ENABLE) ret |= INTERRUPT_TYPE_MSIX; } + + /* + * PCIe spec says device cannot use INTx if MSI/MSI-X is enabled, + * so check for INTx only when both are disabled. + */ + if (!ret) { + err = pci_read_config_word(dev, PCI_COMMAND, &val); + if (err) + return err; + if (!(val & PCI_COMMAND_INTX_DISABLE)) + ret |= INTERRUPT_TYPE_INTX; + } + return ret ?: INTERRUPT_TYPE_NONE; } diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xen/xen-pciback/conf_space_capability.c index 097316a74126..eb4c1af44f5c 100644 --- a/drivers/xen/xen-pciback/conf_space_capability.c +++ b/drivers/xen/xen-pciback/conf_space_capability.c @@ -236,10 +236,11 @@ static int msi_msix_flags_write(struct pci_dev *dev, int offset, u16 new_value, return PCIBIOS_SET_FAILED; if (new_value & field_config->enable_bit) { - /* don't allow enabling together with other interrupt types */ + /* don't allow enabling together with other interrupt type */ int int_type = xen_pcibk_get_interrupt_type(dev); if (int_type == INTERRUPT_TYPE_NONE || + int_type == INTERRUPT_TYPE_INTX || int_type == field_config->int_type) goto write; return PCIBIOS_SET_FAILED; diff --git a/drivers/xen/xen-pciback/conf_space_header.c b/drivers/xen/xen-pciback/conf_space_header.c index 981435103af1..fc0332645966 100644 --- a/drivers/xen/xen-pciback/conf_space_header.c +++ b/drivers/xen/xen-pciback/conf_space_header.c @@ -104,24 +104,9 @@ static int command_write(struct pci_dev *dev, int offset, u16 value, void *data) pci_clear_mwi(dev); } - if (dev_data && dev_data->allow_interrupt_control) { - if ((cmd->val ^ value) & PCI_COMMAND_INTX_DISABLE) { - if (value & PCI_COMMAND_INTX_DISABLE) { - pci_intx(dev, 0); - } else { - /* Do not allow enabling INTx together with MSI or MSI-X. */ - switch (xen_pcibk_get_interrupt_type(dev)) { - case INTERRUPT_TYPE_NONE: - pci_intx(dev, 1); - break; - case INTERRUPT_TYPE_INTX: - break; - default: - return PCIBIOS_SET_FAILED; - } - } - } - } + if (dev_data && dev_data->allow_interrupt_control && + ((cmd->val ^ value) & PCI_COMMAND_INTX_DISABLE)) + pci_intx(dev, !(value & PCI_COMMAND_INTX_DISABLE)); cmd->val = value; -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 16:53:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 16:53:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445847.701258 (Exim 4.92) (envelope-from ) id 1ow4bk-0005rf-F8; Fri, 18 Nov 2022 16:52:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445847.701258; Fri, 18 Nov 2022 16:52:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow4bk-0005rY-BY; Fri, 18 Nov 2022 16:52:52 +0000 Received: by outflank-mailman (input) for mailman id 445847; Fri, 18 Nov 2022 16:52:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow4bi-0005rM-ON for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 16:52:50 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6caf5f4d-6761-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 17:52:47 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6caf5f4d-6761-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668790366; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=J2CiieSJZxtkuKEWP4p8/1ZixIJQEx/CBNf7XOvZuew=; b=hmLyHFO6DoDprPar3+HP8uGJfuP/dXWRvOokfGqZAcSnaUpfvkyMIbgl kRh8R/f+1crfluauUSqxie5QlpJoiLmSH+BCaqd34Jtbv5eUvDxHhwiq6 uiU5RhRHT7ob7rO1hz8PH4bPXFusu83KJZS0hnlYYl3xQvOwuYISyM8yd I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84189304 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:qDwk46lLDhnkXmm5lNwq1sDo5gyWJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJLXWzVbKuINmCnLdtwaImz8BtQvp7TyYdmSVdorik1FyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5Q+GzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 foJJiEqRU6EvcKJ8oq5e8B329x/dNa+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsfYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9zhrB9 jOdpziR7hcyboOT+R+M4HiW1vLBk2D0AqkRCr7oz6s/6LGU7jNKU0BHPbehmtGmjmauVtQZL FYbkgIsorI171eDVcTmUluzp3vslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC9 lKPhcKvOjVpv5WcU3fb/bCRxQ5eIgBMczVEP3VdC1JYvZ+z++nfky4jUP5lAaCkqfarHgvQ/ AKyrhkXnOgL0ZYUgvDTEU/8vxqgoZ3ATwgQ7wrRX3644g4RWLNJd7BE+nCAs68ecd/xok2p+ SFdxpPAtLxm4YSlznTlfQkbIF2+Cx9p2hX4iEUnIZQu/i/FF5WLLdEJu2EWyKuE3685ld7Vj K374105CHx7ZiHCgUpLj2WZVawXIVDIT4iNaxwtRoMmj1gYXFbvENtSTUCRxXvxt0MnjLsyP 5yWGe71UyhKVv46kWfsGb5FuVPO+szY7TmLLXwc5032uYdymVbPEetVWLdwRr9RAFy4TPX9r I8EapriJ+R3W+zieCjHmbP/3nhTRUXWxPne9aRqSwJ0ClA7QT54UKeOn+5Jlk4Mt/09q9okN 0qVAidwoGcTT1WeQelWQhiPsI/SYKs= IronPort-HdrOrdr: A9a23:LI5eY6xi1bUE00zMAEIBKrPwJr1zdoMgy1knxilNoRw8SKOlfq eV7ZEmPH7P+VEssR4b+OxoVJPsfZq+z+8W3WByB9eftWDd0QPCRr2KhbGSpwEIcBeRygcy78 tdmtBFeb7NMWQ= X-IronPort-AV: E=Sophos;i="5.96,174,1665460800"; d="scan'208";a="84189304" From: Anthony PERARD To: CC: Henry Wang , Anthony PERARD , Andrew Cooper , Wei Liu , Juergen Gross Subject: [XEN PATCH for-4.17] libs/light: Propagate libxl__arch_domain_create() return code Date: Fri, 18 Nov 2022 16:52:35 +0000 Message-ID: <20221118165235.14143-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Commit 34990446ca91 started to overwrite the `rc` value from libxl__arch_domain_create(), thus error aren't propagated anymore. Check `rc` value before doing the next thing. Fixes: 34990446ca91 ("libxl: don't ignore the return value from xc_cpuid_apply_policy") Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD --- tools/libs/light/libxl_dom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c index b59bbe00bb..fa5c79e4f6 100644 --- a/tools/libs/light/libxl_dom.c +++ b/tools/libs/light/libxl_dom.c @@ -377,6 +377,7 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid, state->console_port = xc_evtchn_alloc_unbound(ctx->xch, domid, state->console_domid); rc = libxl__arch_domain_create(gc, d_config, state, domid); + if (rc) goto out; /* Construct a CPUID policy, but only for brand new domains. Domains * being migrated-in/restored have CPUID handled during the @@ -384,6 +385,7 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid, if (!state->restore) rc = libxl__cpuid_legacy(ctx, domid, false, info); +out: return rc; } -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Nov 18 17:02:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 17:02:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445854.701269 (Exim 4.92) (envelope-from ) id 1ow4ky-0007dD-F0; Fri, 18 Nov 2022 17:02:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445854.701269; Fri, 18 Nov 2022 17:02:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow4ky-0007d6-C0; Fri, 18 Nov 2022 17:02:24 +0000 Received: by outflank-mailman (input) for mailman id 445854; Fri, 18 Nov 2022 17:02:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow4kw-0007ck-CN for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 17:02:22 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c22b1981-6762-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 18:02:20 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c22b1981-6762-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668790940; h=from:to:cc:subject:date:message-id:mime-version; bh=megvoOBEwOx7JByp5KjUWgWt+wIQJv3ptW72mSIUpLA=; b=UVkRgbiFry/6YnIl+/9h5naJvCL9LurW62XB6tG/fqpVlR9t8hKiU5CT TsG0vthueXKx7Yvthuyf0hhbjD9HdZEPYz6brFQl79dFi1kdojcY5Unie X0MW4I+A0Xo81vr4HRouQbn7P93pKx8d4uNOd0DkHGAYMWO/1KL6V2kxa 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85151333 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:lJne0qjbEDnRF5YiXRy9rAJdX161EBAKZh0ujC45NGQN5FlHY01je htvWmCDPPeDZzGkeN0kYN6/pkxXsceAyYViSQBt+C5hEiwb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QaOzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQoBgBKRS2stdiVye+mbrBDm/w/E+jSadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQthbF/ z+fpD+iav0cHNXY233eqmKjuszszCXpA6EzTJGc19c/1TV/wURMUUZLBDNXu8KRqkO4QcMZF EUS9QInt610/0uuJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpVTA9nJZoH3pwj AbPxo63Q2w02FGIdZ6D3oe6nXSZBAcnF0wLODIgFCQY28Xcgbhm23ojUe1fOKKyi9T0HxT5z DaLsDUyit0vsCIb60mo1QuZ2mzx//AlWiZwv1yKBTz9smuVcab/P+SVBU7nAeGsxWpzZn2Ip zA6lseX94ji5rndxXXWEI3h8FxEjstp0QEwY3Y1QfHNFBz3oRZPmLy8BxkgTHqFyu5eJVfUj Lb74Gu8JPZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPMguLlLaoXswPBb4M4XRfK4Ey/lX1 XCzKJfEMJrnIf4/kGreqxk1jtfHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrlR0U5FyS2Lm +ti2zyikUgGD7SlOnaJrOb+7zkidBAGOHw/kOQPHsbrH+asMDhJ5yP5qV/5R7FYog== IronPort-HdrOrdr: A9a23:ZM28DazsAvRosXqsUVGYKrPwOr1zdoMgy1knxilNoRw8SKKlfq GV7ZMmPHDP6Ar5NEtNpTniAtjlfZq/z+8X3WB5B97LN2OKhILBFvAG0WKI+Vzd8kPFmdK1rZ 0QEZRDNA== X-IronPort-AV: E=Sophos;i="5.96,174,1665460800"; d="scan'208";a="85151333" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Anthony PERARD , Henry Wang Subject: [PATCH for-4.17] tools/libxl: Correct error message units in libxl__domain_set_paging_mempool_size() Date: Fri, 18 Nov 2022 17:02:13 +0000 Message-ID: <20221118170213.2872-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain The error message accidentally printed the bytes value as if it were kB. Fixes: 7c3bbd940dd8 ("xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls") Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Henry Wang For 4.17. This is a low risk change, and makes an error message accurate. --- tools/libs/light/libxl_dom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c index b59bbe00bb30..68ad9763b6ba 100644 --- a/tools/libs/light/libxl_dom.c +++ b/tools/libs/light/libxl_dom.c @@ -1459,7 +1459,8 @@ int libxl__domain_set_paging_mempool_size( int r = xc_set_paging_mempool_size(CTX->xch, domid, shadow_mem); if (r) { LOGED(ERROR, domid, - "Failed to set paging mempool size to %"PRIu64"kB", shadow_mem); + "Failed to set paging mempool size to %lukB", + d_config->b_info.shadow_memkb); return ERROR_FAIL; } -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Nov 18 17:18:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 17:18:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445860.701280 (Exim 4.92) (envelope-from ) id 1ow50q-0000ud-PJ; Fri, 18 Nov 2022 17:18:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445860.701280; Fri, 18 Nov 2022 17:18:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow50q-0000uW-MU; Fri, 18 Nov 2022 17:18:48 +0000 Received: by outflank-mailman (input) for mailman id 445860; Fri, 18 Nov 2022 17:18:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow50o-0000uP-JS for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 17:18:46 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0da637a9-6765-11ed-91b6-6bf2151ebd3b; Fri, 18 Nov 2022 18:18:45 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0da637a9-6765-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668791925; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lm4vFfQPUI68pU6CkdVXHdbmE4t7kd1xAa6hhR+i92k=; b=GGLZOQCeBr1/SDAOedrLe+5Y9L5O0pF0ajtKccdhntADHSe2aK3ZGc1o 1meJEV9ovxDhYk4B8XR6olhHP/LXFJH/V6qXz9OBQyno5XmoQBEpiJEBB bonp+14VU7XCbilJ2AQpLRNgIlKGBO4DXYOnUpya91SV6YE+z43ro1WKG 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84191301 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:sapZtKgV1ujuzBsSL4rHs8twX161EBAKZh0ujC45NGQN5FlHY01je htvW22AOamJNGGgco1wbI209RsC78WEm9I3QAQ9+C8yEykb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QaOzyJ94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tRAJAwoNSybudmH45+rSNNDl8cJDtD0adZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglH2dSFYr1SE47I6+WHJwCR60aT3McqTcduPLSlQthbE/ zOfpDygav0cHN6vxD+/9nCUusDOgiX+dag0EIW05PE/1TV/wURMUUZLBDNXu8KRqkO4QcMZF EUS9QInt610/0uuJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpVTA9nJZoH3pwj AbPxo63Q2w02FGIdZ6D3u+YkRbpBTArFl4hSD8GdyQU4PPBuZ5m23ojUe1fOKKyi9T0HxT5z DaLsDUyit0vsCIb60mo1QuZ2mzx//AlWiZwv1yKBTz9smuVcab/P+SVBU7nAeGsxWpzZn2Ip zA6lseX94ji5rndxXXWEI3h8FxEjstp0QEwY3Y1QfHNFBz3oRZPmLy8BxkgTHqFyu5eJVfUj Lb74Gu8JPZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPMguLlLaoXswPBb4M4XRfK4Ey/lX1 XCzKJfEMJrnIf4/kGreqxk1jtfHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrlR0U5FyS2Lm +ti2zyikUgGD7SlOnaJrOb+7zkidBAGOHw/kOQPHsbrH+asMDhJ5yP5qV/5R7FYog== IronPort-HdrOrdr: A9a23:rVl97ayjs/6iD3ERE5PEKrPwLL1zdoMgy1knxilNoRw8SKKlfu SV7ZAmPH7P+VMssR4b9OxoVJPtfZqYz+8T3WBzB8bBYOCFgguVxehZhOOIqQEIWReOldK1vZ 0QFZSWY+eQMbEVt6nH3DU= X-IronPort-AV: E=Sophos;i="5.96,175,1665460800"; d="scan'208";a="84191301" Date: Fri, 18 Nov 2022 17:18:33 +0000 From: Anthony PERARD To: Andrew Cooper CC: Xen-devel , Henry Wang Subject: Re: [PATCH for-4.17] tools/libxl: Correct error message units in libxl__domain_set_paging_mempool_size() Message-ID: References: <20221118170213.2872-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221118170213.2872-1-andrew.cooper3@citrix.com> On Fri, Nov 18, 2022 at 05:02:13PM +0000, Andrew Cooper wrote: > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c > index b59bbe00bb30..68ad9763b6ba 100644 > --- a/tools/libs/light/libxl_dom.c > +++ b/tools/libs/light/libxl_dom.c > @@ -1459,7 +1459,8 @@ int libxl__domain_set_paging_mempool_size( > int r = xc_set_paging_mempool_size(CTX->xch, domid, shadow_mem); > if (r) { > LOGED(ERROR, domid, > - "Failed to set paging mempool size to %"PRIu64"kB", shadow_mem); > + "Failed to set paging mempool size to %lukB", > + d_config->b_info.shadow_memkb); Unless I miss read, `shadow_memkb` is also "uint64_t", so I'm pretty sure the format doesn't need to be changed, and we should keep using PRIu64. With that changed: Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Nov 18 17:22:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 17:22:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445867.701291 (Exim 4.92) (envelope-from ) id 1ow54r-0002Ta-Aw; Fri, 18 Nov 2022 17:22:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445867.701291; Fri, 18 Nov 2022 17:22:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow54r-0002TT-7k; Fri, 18 Nov 2022 17:22:57 +0000 Received: by outflank-mailman (input) for mailman id 445867; Fri, 18 Nov 2022 17:22:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow54q-0002TN-0j for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 17:22:56 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a23f172f-6765-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 18:22:54 +0100 (CET) Received: from mail-mw2nam10lp2102.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Nov 2022 12:22:43 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by SJ0PR03MB5599.namprd03.prod.outlook.com (2603:10b6:a03:285::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Fri, 18 Nov 2022 17:22:39 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::c98c:5b85:6d10:4860%5]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 17:22:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a23f172f-6765-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1668792174; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=04wH1a30RvapAXQXfQDg7ThxeQ1mtCu6FAVdTnYjwF4=; b=Lwe3MU1ky1aLYnAasdV8sA8RV2pdLJ286T+Gc14pg5v4dzkN0DJDSPCO kT5JiNoFBiaf3ZK18p5brFooDY/F3jL6O6X9Fnl/9aoN4LfrhbmgDYsuR E4VtizS2hb6YcjrvHJFF1qhMvouPqYI5v87iJMLeY9YMVA/uh4UHrFh5y Q=; X-IronPort-RemoteIP: 104.47.55.102 X-IronPort-MID: 84191593 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:NhSH+aqonbbLG7rAadk/QM9XqAheBmLTZBIvgKrLsJaIsI4StFCzt garIBnQPKmKajH1ftB1Ptjg8EIPvJfXndM2TlZsqClnQysRpZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzilNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAG8QTh/dt/n1+Y2mb/V3qJpgFdLbLqpK7xmMzRmBZRonabbqZvySoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeWraYKPEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXoqqc72QDCnQT/DjUdewedrcGQunSYfI1bG UcX6BE0rKU9oRnDot7VGkfQTGS/lj4RXcBBVdIz7g6lw7DRpQ2eAwAsQiZabd06tOc/XTEwy kKShNTtGCBut7uOD3ma89+8rzq0NTIEMGwqaioNTA9D6N7myKkjgxSKQtt9HaqditzuBSq20 z2MtDI5hbgYkYgMzarTwLzcqzelp5yMSxFv4AzSBzqh9lkgPNTjYJG041/G6/oGNJyeUlSKo HkDnY6Z8fwKCpaO0ieKRY3hAY2U2hpMCxWE6XYHInXr323FF6KLFWyI3AxDGQ== IronPort-HdrOrdr: A9a23:c65wXapir/UAssoqLdvDCZEaV5rReYIsimQD101hICG9Evb0qy lhppQmPH7P+VIssRQb8+xoV5PufZqxz/BICOoqTNKftWvdyQiVxehZhOOP/9SJIUbDH4VmpM VdmsZFaeEZDTJB/LvHCAvTKadd/DFQmprY+ts3zB1WPH9Xg7kL1XYfNu4CeHcGPzWvA/ACZf yhz/sCnRWMU1INYP+2A3EUNtKz3eEixPrdEGc77wdM0nj3sQ+V X-IronPort-AV: E=Sophos;i="5.96,175,1665460800"; d="scan'208";a="84191593" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fk6vpPo9g+oH6S0Na4ntZv/U5WVKlJ9t+5BULH5mOKWXfmFaTiuywWLdyzK+4zL1+1WwM2VworAmx4ImkYktDide9lDc+q+KY0n6ESe5Kp+Ir3tzuEXjEVa14igifPITkeufuHyk4sY8PUfpWyEwRo2bD1pmBs5209W7RlINsQ+vzql5AJ3CZS4/PAi2FkCUjp0htXcb68XJ/bg8iBlSDILLiUzQ0IpOjX3NX4Z+CwQFC+nP+hQmkT+gOHwFrgnOrkeknAovwzQI+q2x1RWlG8w0THcxmrlTGtGSHF9gvkRw9WpcOrxsYbEviOs9Bz98iD90hmWm+OUokXigMFL/PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=04wH1a30RvapAXQXfQDg7ThxeQ1mtCu6FAVdTnYjwF4=; b=aDyxIZLOXZHSjESy0XakXCXvsdU88SaaB/wAF+k8PFj1KqVlVUl3m68fWGURkif5WnmhjzbMyY15aB4I8c05TD0qNGG/ww8ZhQH0jJDmHHu6AoxOqV2L9sf9Tm2sTX8X6j9TAsEIInGgtzI7wLQCNvnstxS2LHb0Dv+JqVivnugoBG7qjh+wFhzKuaiFzeh2W2RnDYCZa8iCdfQIJX1iIjIipHsQSN5nCJmlDkp/8FCZ2spGa4/CdI9C7B3lk8ZP+w/rTZrRTiftrzrs73hXHPAXR/cKAsd5iMd2F/aco6oLTesHNA+DkYQpiOHDaR+Yg0iNz+3Ry56/jU+P/PyAZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=04wH1a30RvapAXQXfQDg7ThxeQ1mtCu6FAVdTnYjwF4=; b=jwzQewtpBt5O+i5BGg2rh/kLDb8jbkn2+FFwWskmxb0lMeFKjNPdeCIyiMGfnf7Ac79VqolHdn58SmiWM7lXD6gp2K/JK0gjBnY8O+NTdcbSel6VDoicKBppB1dtyPVpMhYMbxWBEub140TyMMOR9yNmr3/3ptrFqIXQENFFtSk= From: Andrew Cooper To: Roger Pau Monne , Henry Wang , Anthony Perard , Daniel Smith , Jason Andryuk CC: "xen-devel@lists.xenproject.org" Subject: Flask vs paging mempool - Was: [xen-unstable test] 174809: regressions - trouble: broken/fail/pass Thread-Topic: Flask vs paging mempool - Was: [xen-unstable test] 174809: regressions - trouble: broken/fail/pass Thread-Index: AQHY+zeiYojqAeFzxUaCyzIpzopUAa5EwM6AgAAteAA= Date: Fri, 18 Nov 2022 17:22:39 +0000 Message-ID: <6846bb37-345e-ca3d-4cad-2032c4852e15@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|SJ0PR03MB5599:EE_ x-ms-office365-filtering-correlation-id: bd74d6e2-a54d-4461-748c-08dac9897e29 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M6sU+n7sSdorKuH2TqPuYiWEzUjVyLT47aAvnb+Dbu+KzFhi5fYWIlbSl6q2XUC8yA5TZtIVzI465FIlioU1o1azsBJgkB14wCIvM+Gr3O5OOg3Oz4wBOjndyv3GaDjNoXvQma+TANvEluMrz2rJ208CIhg6oIs8MF5loW6qPkuMCd/FjMxm0ll5SpXUinWPm46Je3P763LuLASbnm6jtKwTS7ZS7IYRJ7jQQDmbedUuWI1Hrnq/z7TxBEHdo7IS7NnDES5otx4fYgQP7+OsbZjh4PAIq/jbiipEaNRH4vO7nSI/3M62lpO0q39JjL+ClhrrHotaEQw7AdW3ZwTv/3J6RkUhI0Jqnba4JhRJcgFC+Mm1G3BmDLnhc3WjN2+PU1w1Mrmj0lRjNOr7xdVW+kCBQgf1XX9/j8D7yRCRXlo1b3afLJYyWK+AA436CxbNVtc4acJ3ZDU5990ayF1pdmr+3BnxqLcx0zeM7dhlECU79crocTYk/OV3Yn/9SwHhyjYpsk17nG89pjSkKFso+1xUHPWUB3Kuk8IygD95e6JJda+S9GtpVUKO11o7g5ae0l9UwBzD9eNVXkjyoSUYx0IhIFsk1lT216jXEMbpey2m+iL08TYuGXNzex6AisnH9tvRrmYWrLktZ0naht24edbuANhDDtywa3EO2Won4AOAvwJCaFNPszV3RNXPMEDwzE4pJGms1QXFWJBIjkP2WI+mH1rp0troR9yZtara2Wxl8u3IyveDX4inwLPdCCzUV60Q3LIkL46hP41tsfRgJQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(366004)(346002)(136003)(376002)(451199015)(36756003)(31696002)(86362001)(122000001)(38070700005)(38100700002)(82960400001)(6506007)(31686004)(110136005)(53546011)(316002)(6486002)(478600001)(71200400001)(5660300002)(186003)(2616005)(8936002)(83380400001)(2906002)(26005)(6512007)(91956017)(66446008)(41300700001)(8676002)(64756008)(4326008)(76116006)(66476007)(66946007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Y3N5c01IL1AxWkdMMm1vTkhLWUtEZnBsakhuV2h2VmNyNUhmcVdaRlpaaUw0?= =?utf-8?B?S3dIT2RjTmUvSk5nV3oyMVBwUXJCR3A3L3lISGsvVmpIb0IxNUdNQ2N2VDZi?= =?utf-8?B?NjBveitvVlB5TU9wOHRHejZyZTlheXdQNDVQNi9ZeHJkWnh4RWdFTURYMisv?= =?utf-8?B?OFFyNFZSTnN4K2UzV3pPMlJENjh5ZVQyaXNhR3F0TlRoK0Q0ZXlDUTIzNTZL?= =?utf-8?B?aHRySnZ0V0RmNmhEWWhJYVA5MTEyMVlYVDVUbzNXampINlAxaDE4a3VSQkp2?= =?utf-8?B?b1h6V2txamwyOXhxc1V4MkpRRGt2dGtYcUxnV3lHckl3OVBRVjdDMFFNeS9l?= =?utf-8?B?dTBoMytxNG9kUHowKytUakV0KzRkc0sxNFcrSDZWSXE4eEVwbkpuOThnVXR4?= =?utf-8?B?eXBQT0gwQi8zYnFhQlVUK0kvZzJkRG5BdHhsaFlWUWZFQXRLVVVxWkJJVTli?= =?utf-8?B?T3JIOEsxVXVDOFJQdVcvbTQ5TG5BdTBRRkt3ejNzRzBXeTVHYlhIMlVicmFx?= =?utf-8?B?aUxpTXh4WEw1UmtuUnFZalc0VHJ6bDFDdjVnempsdzFlVkYzbkZQODB6K3hw?= =?utf-8?B?MzFHN0VweDhNajRYUHZlVmpyZzgrSTl1aHAzQk1hOFhWRy9sa3Zic3pJK2hJ?= =?utf-8?B?WjZlTHBaZ0RrTEhsNVIrODBZV2JwektpeCtBRHcwYUxUd0JwYjJIWlYzTGRs?= =?utf-8?B?SzFIalBRSG1CMURvUEVaa3EyRE11REUxWHptL3FvV3FEdkhWSFFsYmFCc1F0?= =?utf-8?B?ZmdaNWVCRVpidEUyblZuQ1ZMM0I3b0NRWnR3RjVxR1F4NUtiZkhKWlE4eUpr?= =?utf-8?B?am9sNTBXY1E0YUI2dHFJU01HR1F3RTJQRnlzREdJUjVEbVJmNGFsVW5ZazI4?= =?utf-8?B?YW92RDJaMTl1a1lJNDZ2NVRORDljcWlFQkEwekJsUkxkaUlVVHhjRlZINEFF?= =?utf-8?B?WG4xYzdVTkJ0RUZETGc2V3lpMWJYRVU1VHk4WGdqTkpNdUJVM24vRUcyRm9s?= =?utf-8?B?M2lPSkZVLzBmTUEwZWwxNFpEblVLMERtdmc3eGdxdTJ3bkFrbUJqdEFhUUgr?= =?utf-8?B?cGxJdkRKWTdoQmdTWm8rd1NHWUVXZ2VQVFBBd0wraEZsN09ndGRIRnhNREdT?= =?utf-8?B?dDMvM2Y5R3o4Zy9JN0l2bVBDS3ZGcGtRQ0orNy85Zy9Ga3FHb25oeVc2ZW00?= =?utf-8?B?Z2h2TXJLVUsvWGpPcWFUcytJMHA2VHljak1BR0w0TWFYQlNnZnk1R2h4eG9P?= =?utf-8?B?Rm9SSWxFTDY3aDhCVCtFTmpMQjRVZit5MzRlQnpIdyt4RTNPZlhYZkFDTGVj?= =?utf-8?B?cHB2VUdnY05jQS9aL01uTHVhamlVYUYvUllSUlBVVkViVExRdDVya1I5TEJ3?= =?utf-8?B?NThpWnYrWmI4K1hDNkxCNVFWWTlSUmh3dUlEaGFSUVpsNUtWN2xDdTN4QWNW?= =?utf-8?B?NGxHTjhoSTJYUzBkQWFaUDI4OE5waWhnY0pLRS9KOVljUGxSM2w4VDRMaDZS?= =?utf-8?B?Q3o5N2pqZzF3enpaRFpKN2x4RkhiSExLbS9YdzdQaTJpdDhQUmxDN1JSM2VE?= =?utf-8?B?ZGI0MkI4aG13VXFsUkZBdFlYZHo2ek5JWk9tKzBJUHZvWEhJck9DSkF4VnMz?= =?utf-8?B?ZytmYkNpeWhWZVRSa2pBY09yQnhpa2MrSlR4L2xxVTV5b2hjTlp2bCtwaEVE?= =?utf-8?B?RGFac1NNbGdwVmZET3F6UmJMVlpUNXFmVVJnS3VLeVZRd2kvZ3E5Z0NiMUVw?= =?utf-8?B?ZGl0WUxwYThIQjRGMWozL0w1VUgzZUVkdk9jRG5tZDF2ZGhvU2N6di93d1Ja?= =?utf-8?B?SXlyUkZFUE5HSEFaWXA2Z1dJdjIrb2RWZWI5ZmFjTndJem1sU1B0aEtsZGZK?= =?utf-8?B?Sjk3Y1crK3BrR2ordzVzNG1uNmdWdWlOcmQxelhNaGFUSUlLSDdvVTFsWHJZ?= =?utf-8?B?YjllcmZmVDBDTTRzMkdvYVA0LzhXWksxajZscFdqazlGeEpveGpPQUlXRkE2?= =?utf-8?B?ckdQMFByVHRDZWgzZWtKdk1GK1lzYStKZkR1WlJyUFZIWTlSaklvbGQ1MUhC?= =?utf-8?B?Y2JiN3BzYlVES21YTGxhQ2Uzb1NzMFNlclYwWFRnSTczaFduVDRhSzBMckJT?= =?utf-8?Q?atKP0om8zXT6aDQJ8P0pNYUto?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: oVkVI8gNhmsjq0HywBK0eR75G+/FS9QAXJyoT3CSlIQ/CLPauJNyLrrSYm57R4J0povJNXycxHtn/3sOZmaYvUN8IuaCaWAg/jAqo2DLucMrwi61TMQJWv+fSbD2hvxHrFT7YfGDz0zetUXBOQpzyjGB2wbCWn39dgWm2tfll4hfugz3o4/iQD/PH3sAvlgHDUTB8V8iNM3fewKvw/t5DkuyuhhRApnzO/rgBuNEBsVvqlnnRSDgyKjq7Sx/A/dPgKYXw+0IWVrj3kVl8DdCNJAWsQInxvP+G2DuJdcUkkXc2ZRJ8ReVbSB7JyP4Gm84yHT+iNLijY3L3wEhD+4dcJuKQ84gKOORc8/WKSTtujmZ9BgTsJIh3f89cacgCfBJIUS05qgyqm9qLr1ZjRjCOBL0FZzmAl8RIvj2nWEv8wzNNO+8ccyf94mogU8wsLOCSobL31AbTiSwYoMubvVBg1TL4A83o7ZRTrhtq/XH75+lzptz9kYiSZJg6TxVEq9EX9uJHU/euwQQNU5ltprLOMqNDk9OctPW+kw6HC5JsvNFqCQAMFJL3imyeittj9uyAuAMGDIPfNTNOfCfrt8qHYhKzOQCYs16CYREIcNIkS0xAO6SiakwFslYZSssizaEPRg2hus4V7ZxfBivpawHKvsVUfaOGjyEo2xYiPgELhCVSZ0RbY/ydbKTOLRgEfGwvG4/eaUuQsCTgDV7XnJbLnpRR3M86wU6Q5J9GRrmY61pzCdyocM/ipehVS4C+/HCVbEIK9Emtk7V81xyiQyyevzxmicMnIFBT8TPEOSM1fetInuPJssaFgaTRovSf/b/2rsJbLUUw3ays3uHkvV7jv1A29dIQynEeonAiZRqVFC/BCuZATERzPoKbrO8tRoM X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd74d6e2-a54d-4461-748c-08dac9897e29 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2022 17:22:39.0382 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J2OSgbsoEC6ChuBBbwjb+qC4wwWSjKVXqpmyri9vO69YhU4OdNriMrSTE5jM0TQuxvp9P+k+HiggMUejEGBXyxlxl1Ly+1D4PSToOCo8W58= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5599 T24gMTgvMTEvMjAyMiAxNDozOSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBOb3YgMTggMDE6 NTU6MTEuNzUzOTM2IChYRU4pIGFyY2gveDg2L21tL2hhcC9oYXAuYzozMDQ6IGQxIGZhaWxlZCB0 byBhbGxvY2F0ZSBmcm9tIEhBUCBwb29sDQo+IE5vdiAxOCAwMTo1NToxOC42MzM3OTkgKFhFTikg RmFpbGVkIHRvIHNoYXR0ZXIgZ2ZuIDdlZDM3OiAtMTINCj4gTm92IDE4IDAxOjU1OjE4LjYzMzg2 NiAoWEVOKSBkMXYwIEVQVCB2aW9sYXRpb24gMHgxOWMgKC0teC9ydy0pIGdwYSAweDAwMDAwMDdl ZDM3M2ExIG1mbiAweDMzZWQzNyB0eXBlIDANCj4gTm92IDE4IDAxOjU1OjE4LjY0NTc5MCAoWEVO KSBkMXYwIFdhbGtpbmcgRVBUIHRhYmxlcyBmb3IgR0ZOIDdlZDM3Og0KPiBOb3YgMTggMDE6NTU6 MTguNjQ1ODUwIChYRU4pIGQxdjAgIGVwdGUgOWMwMDAwMDQ3ZWJhMzEwNw0KPiBOb3YgMTggMDE6 NTU6MTguNjQ1ODkzIChYRU4pIGQxdjAgIGVwdGUgOWMwMDAwMDMwMDAwMDNmMw0KPiBOb3YgMTgg MDE6NTU6MTguNjQ1OTM1IChYRU4pIGQxdjAgIC0tLSBHTEEgMHg3ZWQzNzNhMQ0KPiBOb3YgMTgg MDE6NTU6MTguNjU3NzgzIChYRU4pIGRvbWFpbl9jcmFzaCBjYWxsZWQgZnJvbSBhcmNoL3g4Ni9o dm0vdm14L3ZteC5jOjM3NTgNCj4gTm92IDE4IDAxOjU1OjE4LjY1Nzg0NCAoWEVOKSBEb21haW4g MSAodmNwdSMwKSBjcmFzaGVkIG9uIGNwdSM4Og0KPiBOb3YgMTggMDE6NTU6MTguNjY5NzgxIChY RU4pIC0tLS1bIFhlbi00LjE3LXJjICB4ODZfNjQgIGRlYnVnPXkgIE5vdCB0YWludGVkIF0tLS0t DQo+IE5vdiAxOCAwMTo1NToxOC42Njk4NDMgKFhFTikgQ1BVOiAgICA4DQo+IE5vdiAxOCAwMTo1 NToxOC42Njk4ODQgKFhFTikgUklQOiAgICAwMDIwOls8MDAwMDAwMDA3ZWQzNzNhMT5dDQo+IE5v diAxOCAwMTo1NToxOC42ODE3MTEgKFhFTikgUkZMQUdTOiAwMDAwMDAwMDAwMDEwMDAyICAgQ09O VEVYVDogaHZtIGd1ZXN0IChkMXYwKQ0KPiBOb3YgMTggMDE6NTU6MTguNjgxNzcyIChYRU4pIHJh eDogMDAwMDAwMDA3ZWQzNzNhMSAgIHJieDogMDAwMDAwMDA3ZWQzNzI2YyAgIHJjeDogMDAwMDAw MDAwMDAwMDAwMA0KPiBOb3YgMTggMDE6NTU6MTguNjkzNzEzIChYRU4pIHJkeDogMDAwMDAwMDA3 ZWQyZTYxMCAgIHJzaTogMDAwMDAwMDAwMDAwOGUzOCAgIHJkaTogMDAwMDAwMDA3ZWQzNzQ0OA0K PiBOb3YgMTggMDE6NTU6MTguNjkzNzc1IChYRU4pIHJicDogMDAwMDAwMDAwMWI0MTBhMCAgIHJz cDogMDAwMDAwMDAwMDMyMDg4MCAgIHI4OiAgMDAwMDAwMDAwMDAwMDAwMA0KPiBOb3YgMTggMDE6 NTU6MTguNzA1NzI1IChYRU4pIHI5OiAgMDAwMDAwMDAwMDAwMDAwMCAgIHIxMDogMDAwMDAwMDAw MDAwMDAwMCAgIHIxMTogMDAwMDAwMDAwMDAwMDAwMA0KPiBOb3YgMTggMDE6NTU6MTguNzE3NzMz IChYRU4pIHIxMjogMDAwMDAwMDAwMDAwMDAwMCAgIHIxMzogMDAwMDAwMDAwMDAwMDAwMCAgIHIx NDogMDAwMDAwMDAwMDAwMDAwMA0KPiBOb3YgMTggMDE6NTU6MTguNzE3Nzk0IChYRU4pIHIxNTog MDAwMDAwMDAwMDAwMDAwMCAgIGNyMDogMDAwMDAwMDAwMDAwMDAxMSAgIGNyNDogMDAwMDAwMDAw MDAwMDAwMA0KPiBOb3YgMTggMDE6NTU6MTguNzI5NzEzIChYRU4pIGNyMzogMDAwMDAwMDAwMDQw MDAwMCAgIGNyMjogMDAwMDAwMDAwMDAwMDAwMA0KPiBOb3YgMTggMDE6NTU6MTguNzI5NzcxIChY RU4pIGZzYjogMDAwMDAwMDAwMDAwMDAwMCAgIGdzYjogMDAwMDAwMDAwMDAwMDAwMCAgIGdzczog MDAwMDAwMDAwMDAwMDAwMg0KPiBOb3YgMTggMDE6NTU6MTguNzQxNzExIChYRU4pIGRzOiAwMDI4 ICAgZXM6IDAwMjggICBmczogMDAwMCAgIGdzOiAwMDAwICAgc3M6IDAwMjggICBjczogMDAyMA0K Pg0KPiBJdCBzZWVtcyB0byBiZSByZWxhdGVkIHRvIHRoZSBwYWdpbmcgcG9vbCBhZGRpbmcgQW5k cmV3IGFuZCBIZW5yeSBzbw0KPiB0aGF0IGhlIGlzIGF3YXJlLg0KDQpTdW1tYXJ5IG9mIHdoYXQg SSd2ZSBqdXN0IGdpdmVuIG9uIElSQy9NYXRyaXguDQoNClRoaXMgY3Jhc2ggaXMgY2F1c2VkIGJ5 IHR3byB0aGluZ3MuwqAgRmlyc3QNCg0KwqAgKFhFTikgRkxBU0s6IERlbnlpbmcgdW5rbm93biBk b21jdGw6IDg2Lg0KDQpiZWNhdXNlIEkgY29tcGxldGVseSBmb3Jnb3QgdG8gd2lyZSB1cCBGbGFz ayBmb3IgdGhlIG5ldyBoeXBlcmNhbGxzLsKgDQpCdXQgc28gZGlkIHRoZSBvcmlnaW5hbCBYU0Et NDA5IGZpeCAoYXMgU0VDQ0xBU1NfU0hBRE9XIGlzIGJlaGluZA0KQ09ORklHX1g4NiksIHNvIEkg ZG9uJ3QgZmVlbCBxdWl0ZSBhcyBiYWQgYWJvdXQgdGhpcy4NCg0KQW5kIHNlY29uZCBiZWNhdXNl IGxpYnhsIGlnbm9yZXMgdGhlIGVycm9yIGl0IGdldHMgYmFjaywgYW5kIGJsaW5kbHkNCmNvbnRp bnVlcyBvbndhcmQuwqAgQW50aG9ueSBoYXMgcG9zdGVkICJsaWJzL2xpZ2h0OiBQcm9wYWdhdGUN CmxpYnhsX19hcmNoX2RvbWFpbl9jcmVhdGUoKSByZXR1cm4gY29kZSIgdG8gZml4IHRoZSBsaWJ4 bCBoYWxmIG9mIHRoZQ0KYnVnLCBhbmQgSSBwb3N0ZWQgYSBzZWNvbmQgbGlieGwgYnVnZml4IHRv IGZpeCBhbiBlcnJvciBtZXNzYWdlLsKgIEJvdGgNCmFyZSB2ZXJ5IHNpbXBsZS4NCg0KDQpGb3Ig Rmxhc2ssIHdlIG5lZWQgbmV3IGFjY2VzcyB2ZWN0b3JzIGJlY2F1c2UgdGhpcyBpcyBhIGNvbW1v bg0KaHlwZXJjYWxsLCBidXQgSSdtIHVuc3VyZSBob3cgdG8gaW50ZXJsaW5rIGl0IHdpdGggeDg2 J3Mgc2hhZG93DQpjb250cm9sLsKgIFRoaXMgd2lsbCByZXF1aXJlIGEgYml0IG9mIHBvbmRlcmlu ZywgYnV0IGl0IGlzIHByb2JhYmx5DQplYXNpZXIgdG8ganVzdCBsZWF2ZSB0aGVtIHVubGlua2Vk Lg0KDQoNCkZsYXNrIGlzIGxpc3RlZCBhcyBleHBlcmltZW50YWwgd2hpY2ggbWVhbnMgaXQgZG9l c24ndCB0ZWNobmljYWxseQ0KbWF0dGVyIGlmIHdlIGJyZWFrIGl0LCBidXQgaXQgaXMgdXNlZCBi eSBPcGVuWFQgc28gbm90IGZpeGluZyBpdCBmb3INCjQuMTcgd291bGQgYmUgcmF0aGVyIHJ1ZGUu DQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri Nov 18 18:40:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 18:40:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445878.701302 (Exim 4.92) (envelope-from ) id 1ow6I6-0003E8-P1; Fri, 18 Nov 2022 18:40:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445878.701302; Fri, 18 Nov 2022 18:40:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow6I6-0003E1-Lu; Fri, 18 Nov 2022 18:40:42 +0000 Received: by outflank-mailman (input) for mailman id 445878; Fri, 18 Nov 2022 18:40:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow6I5-0003Dr-4Q; Fri, 18 Nov 2022 18:40:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow6I5-0001CF-1q; Fri, 18 Nov 2022 18:40:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow6I4-00084u-He; Fri, 18 Nov 2022 18:40:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ow6I4-0001sm-HA; Fri, 18 Nov 2022 18:40:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3unspFTHcIKfVUVVF5aNGzwFUPSMBc082v5WMAiz9Ec=; b=s9ysRbbhd1IAvWbnLNK6Tg70u8 yMxUqnl5MJMXjDMgUxq7zpmKFpV3LNy/j+yZd4PVEPHmF6/IAIC6Nktnn10OlrzRVVmft011abTvW 8VmqoCw0Cetyvf5RZOvy3mZwEzohrKRf+gemSHNKoKndC8TSMy6lACFvsq+n69i6/CLY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174812: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=84368d882b9688bfac77ce48d33b1e20a4e4a787 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Fri, 18 Nov 2022 18:40:40 +0000 flight 174812 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174812/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 84368d882b9688bfac77ce48d33b1e20a4e4a787 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 41 days Failing since 173470 2022-10-08 06:21:34 Z 41 days 71 attempts Testing same since 174808 2022-11-17 23:41:39 Z 0 days 2 attempts ------------------------------------------------------------ 1749 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 165602 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Nov 18 20:47:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 20:47:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445902.701313 (Exim 4.92) (envelope-from ) id 1ow8GN-0008N6-5G; Fri, 18 Nov 2022 20:47:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445902.701313; Fri, 18 Nov 2022 20:47:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow8GN-0008Mz-1Z; Fri, 18 Nov 2022 20:47:03 +0000 Received: by outflank-mailman (input) for mailman id 445902; Fri, 18 Nov 2022 20:47:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow8GL-0008Mt-NS for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 20:47:01 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 25b818c8-6782-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 21:46:59 +0100 (CET) Received: by mail-ej1-x62b.google.com with SMTP id gv23so15895428ejb.3 for ; Fri, 18 Nov 2022 12:46:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25b818c8-6782-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=O5mIJKaMx1pQwhku2nm6bI31JWHjArdgLDjzIVWQmzw=; b=p6G0G6EmyfrWheZD8YdSOgeWzjDKm8jq9RXjYThdcRilvkW/x7/9i5Iv+x+3+VNTtM aYFi5FUuKw4c4HpSqMOp4oyAn9yUVMVpOzIq3W3rN7ZFtwME6UWQP21JxkI4kO0e3V5l p/jMO/XmminachraU1I6jznhFkTMgGTCgUKqrSkIgF4zfLxaP1kXDlqfs26JXpqGAh16 Q9HbkH3+JdCgcPV0kCanVuWpcrquQ61jFWku3miKhdg2Vuxgj1mopqUH9nvBT4F9rpwR 2h7/eTXetDDT9Okvv92D8PlgXeo82Ni9s+lmuyvyk+btnRv0J5EQNtoGzSWPg493nvJL flhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O5mIJKaMx1pQwhku2nm6bI31JWHjArdgLDjzIVWQmzw=; b=kX3uoxHGxZjy55ByVpkVfrSpvCK4auvERc65p+5sv6xQAQcG9+YABfConnIdFH3JQp 9rFTydbtNcwWd2G3SvELG4zRT1fipiTo+gb24jTDxzyzuo8wL+f0njbBQCSghn3rwwT3 HR3WD1VPdtY+AVTOq2YLSwfkK+c7Ryt3YKSquswjl65CfhVT3py868/PxmjDAqHT+qxl OF5byDgWPM++2u/Gn7g4iz0mQjg00HJhIWlczJ5t63x+WLo8DybD0oAqfZHBzpBwYpoV YRmfrRlcr1sFyQQ/cu4Era8aocKZpYOoCWplZqz4FqVCozyf/gwFDmR0wzPJEENSfkD1 Nl6A== X-Gm-Message-State: ANoB5plfO8B2XQUiikawZupMTcsGzIe6jNmHDRBE3A4G+8JvLViLd/nL nz3RzjaDzQwnuvuOrALdYodMVrt/i+vxsx4DIKn5UAQksnM= X-Google-Smtp-Source: AA0mqf5WICxI6NK59qKF2yN268AeQmX+15/dr5sYNyDhDKSnHOrrc88T6Mmb4wPczvMKKxnxv6B9WAiLIRxQLi+WC3g= X-Received: by 2002:a17:906:65c4:b0:7ad:d250:b907 with SMTP id z4-20020a17090665c400b007add250b907mr7182127ejn.737.1668804419101; Fri, 18 Nov 2022 12:46:59 -0800 (PST) MIME-Version: 1.0 References: <20221118154931.1928298-1-marmarek@invisiblethingslab.com> In-Reply-To: <20221118154931.1928298-1-marmarek@invisiblethingslab.com> From: Jason Andryuk Date: Fri, 18 Nov 2022 15:46:47 -0500 Message-ID: Subject: Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Nov 18, 2022 at 10:50 AM Marek Marczykowski-G=C3=B3recki wrote: > > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until > the table is filled. Then it disables INTx just before clearing MASKALL > bit. Currently this approach is rejected by xen-pciback. > According to the PCIe spec, device cannot use INTx when MSI/MSI-X is > enabled (in other words: enabling MSI/MSI-X implicitly disables INTx). > > Change the logic to consider INTx disabled if MSI/MSI-X is enabled. This > applies to three places: > - checking currently enabled interrupts type, > - transition to MSI/MSI-X - where INTx would be implicitly disabled, > - clearing INTx disable bit - which can be allowed even if MSI/MSI-X is > enabled, as device should consider INTx disabled anyway in that case > > Fixes: 5e29500eba2a ("xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKALL t= oo") > Signed-off-by: Marek Marczykowski-G=C3=B3recki > --- > Changes in v3: > - allow clearing INTx regardless of MSI/MSI-X state, to be consistent > with enabling MSI/MSI-X > Changes in v2: > - restructure the patch to consider not only MASKALL bit, but enabling > MSI/MSI-X generally, without explicitly disabling INTx first > --- I was trying to test your xen-pciback v3 patch, and I am having assignment fail consistently now. It is actually failing to quarantine to domIO in the first place, which matches the failure from the other day (when I more carefully read through the logs). It now consistently fails to quarantine on every boot unlike the other day where it happened once. I added some printks and it 's getting -EBUSY from pdev_msix_assign() which means pci_reset_msix_state() is failing: if ( pci_conf_read16(pdev->sbdf, msix_control_reg(pos)) & PCI_MSIX_FLAGS_MASKALL ) return -EBUSY; # lspci -vv -s 14.3 ... Capabilities: [80] MSI-X: Enable- Count=3D16 Masked+ Vector table: BAR=3D0 offset=3D00002000 PBA: BAR=3D0 offset=3D00003000 So it looks like MASKALL is set and prevents assignment. setpci -s 00:14.3 82.W=3Df cleared that out for me and I could assign the device. My dom0 boots, it runs flask-label-pci for a set of PCI devices (including iwlwifi), then xl pci-assignable-add for all PCI devices which will be passed through, then a little later it boots the associated domains. Dom0 does not have a driver for iwlwifi. I'll have to investigate more to see how MASKALL is getting set. This had not been an issue before your recent patches. Regards, Jason From xen-devel-bounces@lists.xenproject.org Fri Nov 18 20:49:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 20:49:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445906.701323 (Exim 4.92) (envelope-from ) id 1ow8Io-0000Uu-HL; Fri, 18 Nov 2022 20:49:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445906.701323; Fri, 18 Nov 2022 20:49:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow8Io-0000Un-EQ; Fri, 18 Nov 2022 20:49:34 +0000 Received: by outflank-mailman (input) for mailman id 445906; Fri, 18 Nov 2022 20:49:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow8In-0000Ud-7i; Fri, 18 Nov 2022 20:49:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow8In-00046B-3a; Fri, 18 Nov 2022 20:49:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow8Im-00042U-Lv; Fri, 18 Nov 2022 20:49:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ow8Im-0002P2-LN; Fri, 18 Nov 2022 20:49:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JmBZHsr/9keF4qna4Tgbcg5a17AbFEcZRGMcXDmeiig=; b=sWYwFYkAZwEmZsPhM5QGusjw3A 3CzYyYcWYxzAZqWI3tBeKJLH8CYBLu0wqSumroSG/A43uRIvk9txThb2NJHfLDiKJmBlJBnJ6dgMo Fyu7bfBXjUEpp6Xb1mNIm2UGyHIvVkp5qyLAYNHZpQbnpTQmy09ZjuhlJx75jrrGAl34=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174814: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=db8fa01c61db0317a9ee947925226234c65d48e8 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Fri, 18 Nov 2022 20:49:32 +0000 flight 174814 xen-unstable real [real] flight 174817 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174814/ http://logs.test-lab.xenproject.org/osstest/logs/174817/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 174797 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen db8fa01c61db0317a9ee947925226234c65d48e8 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 1 days Testing same since 174809 2022-11-18 00:06:55 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit db8fa01c61db0317a9ee947925226234c65d48e8 Author: Andrew Cooper Date: Thu Oct 20 12:14:30 2022 +0100 xen/arm: Correct the p2m pool size calculations Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit bd87315a603bf25e869e6293f7db7b1024d67999 Author: Andrew Cooper Date: Thu Oct 20 12:13:46 2022 +0100 tools/tests: Unit test for paging mempool size Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit 22b20bd98c025e06525410e3ab3494d5e63489f7 Author: Andrew Cooper Date: Fri Oct 21 14:13:00 2022 +0100 xen: Introduce non-broken hypercalls for the paging mempool size The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 Author: Andrew Cooper Date: Mon Nov 14 21:47:59 2022 +0000 x86/hvm: Revert per-domain APIC acceleration support I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisted in due course. Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Fixes: 6b2b9b340509 ("x86: report Interrupt Controller Virtualization capabilities") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Nov 18 21:11:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 21:11:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445916.701338 (Exim 4.92) (envelope-from ) id 1ow8dg-0004JD-CV; Fri, 18 Nov 2022 21:11:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445916.701338; Fri, 18 Nov 2022 21:11:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow8dg-0004J6-9Q; Fri, 18 Nov 2022 21:11:08 +0000 Received: by outflank-mailman (input) for mailman id 445916; Fri, 18 Nov 2022 21:11:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow8de-0004J0-EX for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 21:11:06 +0000 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [2a00:1450:4864:20::52d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 83641e3d-6785-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 22:11:05 +0100 (CET) Received: by mail-ed1-x52d.google.com with SMTP id s5so8787436edc.12 for ; Fri, 18 Nov 2022 13:11:05 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83641e3d-6785-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jxcv2nm3tG3Z0vhlABJP9BKuaFPvcny/CHCF+xgivEo=; b=EQNRksUcissCQfWp3uUCSBPpc84XrnRzLQrYVMzCPILzwF0WyUtsGQwFje4Ff44V3i fvPeeyi9f2nArlCS9x9Wq+AkuJEDKDXA1yaBMpHW5INw4li9BWv8sdH8kqdbVWKcD4Yy gYgvQdP0cZjRWhan0dgIUjBlYpkaIjslxn6b4uARHM3GyOV63ZCXSd3h5SFBP/1ksRpu lT0NPUwK20UMtD/on2qUOXjLojgNb4wf/0YPPYq2gJxr2GyqQXFtr+LrtC7yQtwwem7W UIywRFX1iin4VgUU8b6WOJIQ85ohiBb7Z/NEG3XdPlzDTPhvuz7YRthacJn2CgausC/1 Mgpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jxcv2nm3tG3Z0vhlABJP9BKuaFPvcny/CHCF+xgivEo=; b=O+2z0IPLGsX6InCAF9XSe/exyvaQweytUxFnQo9w8Ix9NywRiOc7i+DiIlva3Gw+pu G0mJBKi+QhouQgqqIn8izIx+mHgqM9hfRD4VAY49Xt3EPkFaN0zifzLUnV4LhMjUp+uc 1bao9hu71EKKVqduVo7CB5EanpgYdJD/rwEWH/xUWCheKUXSxNudfw3JD5PnUTkyDB0i t61U7Qa4aauZsqR0pQ4iXU52Dd4XMxUEzCAwICjyjz1aWcpLDqMcb6zP71GTAIyCUCtG ES8I2RYS4ht4Tok1cXdOVrKO22/SwGGylrXwUvlwMTf/O808WzqXs9l3YjGleKzG32Es v5KQ== X-Gm-Message-State: ANoB5pl+SflDFZ9pMnd17roh2jhaU0udo8mYn4hB12ap7V+8OQUC1FOG 3wVKMuXUrkKfyQjmMXm+r8FB6iw464MkFY+QzjP1bQbd X-Google-Smtp-Source: AA0mqf7HP8NVU94cZsKl8GsLsvV6qUNqiZT2IJZYbjR6N4V8rePa08CDrfvwedq99SGcYxzDnzBOw/y5CkNPEEDEPVg= X-Received: by 2002:a05:6402:2d6:b0:461:8efb:3f84 with SMTP id b22-20020a05640202d600b004618efb3f84mr7676426edx.210.1668805864709; Fri, 18 Nov 2022 13:11:04 -0800 (PST) MIME-Version: 1.0 References: <6846bb37-345e-ca3d-4cad-2032c4852e15@citrix.com> In-Reply-To: <6846bb37-345e-ca3d-4cad-2032c4852e15@citrix.com> From: Jason Andryuk Date: Fri, 18 Nov 2022 16:10:52 -0500 Message-ID: Subject: Re: Flask vs paging mempool - Was: [xen-unstable test] 174809: regressions - trouble: broken/fail/pass To: Andrew Cooper Cc: Roger Pau Monne , Henry Wang , Anthony Perard , Daniel Smith , "xen-devel@lists.xenproject.org" Content-Type: text/plain; charset="UTF-8" On Fri, Nov 18, 2022 at 12:22 PM Andrew Cooper wrote: > > On 18/11/2022 14:39, Roger Pau Monne wrote: > > Nov 18 01:55:11.753936 (XEN) arch/x86/mm/hap/hap.c:304: d1 failed to allocate from HAP pool > > Nov 18 01:55:18.633799 (XEN) Failed to shatter gfn 7ed37: -12 > > Nov 18 01:55:18.633866 (XEN) d1v0 EPT violation 0x19c (--x/rw-) gpa 0x0000007ed373a1 mfn 0x33ed37 type 0 > > Nov 18 01:55:18.645790 (XEN) d1v0 Walking EPT tables for GFN 7ed37: > > Nov 18 01:55:18.645850 (XEN) d1v0 epte 9c0000047eba3107 > > Nov 18 01:55:18.645893 (XEN) d1v0 epte 9c000003000003f3 > > Nov 18 01:55:18.645935 (XEN) d1v0 --- GLA 0x7ed373a1 > > Nov 18 01:55:18.657783 (XEN) domain_crash called from arch/x86/hvm/vmx/vmx.c:3758 > > Nov 18 01:55:18.657844 (XEN) Domain 1 (vcpu#0) crashed on cpu#8: > > Nov 18 01:55:18.669781 (XEN) ----[ Xen-4.17-rc x86_64 debug=y Not tainted ]---- > > Nov 18 01:55:18.669843 (XEN) CPU: 8 > > Nov 18 01:55:18.669884 (XEN) RIP: 0020:[<000000007ed373a1>] > > Nov 18 01:55:18.681711 (XEN) RFLAGS: 0000000000010002 CONTEXT: hvm guest (d1v0) > > Nov 18 01:55:18.681772 (XEN) rax: 000000007ed373a1 rbx: 000000007ed3726c rcx: 0000000000000000 > > Nov 18 01:55:18.693713 (XEN) rdx: 000000007ed2e610 rsi: 0000000000008e38 rdi: 000000007ed37448 > > Nov 18 01:55:18.693775 (XEN) rbp: 0000000001b410a0 rsp: 0000000000320880 r8: 0000000000000000 > > Nov 18 01:55:18.705725 (XEN) r9: 0000000000000000 r10: 0000000000000000 r11: 0000000000000000 > > Nov 18 01:55:18.717733 (XEN) r12: 0000000000000000 r13: 0000000000000000 r14: 0000000000000000 > > Nov 18 01:55:18.717794 (XEN) r15: 0000000000000000 cr0: 0000000000000011 cr4: 0000000000000000 > > Nov 18 01:55:18.729713 (XEN) cr3: 0000000000400000 cr2: 0000000000000000 > > Nov 18 01:55:18.729771 (XEN) fsb: 0000000000000000 gsb: 0000000000000000 gss: 0000000000000002 > > Nov 18 01:55:18.741711 (XEN) ds: 0028 es: 0028 fs: 0000 gs: 0000 ss: 0028 cs: 0020 > > > > It seems to be related to the paging pool adding Andrew and Henry so > > that he is aware. > > Summary of what I've just given on IRC/Matrix. > > This crash is caused by two things. First > > (XEN) FLASK: Denying unknown domctl: 86. > > because I completely forgot to wire up Flask for the new hypercalls. > But so did the original XSA-409 fix (as SECCLASS_SHADOW is behind > CONFIG_X86), so I don't feel quite as bad about this. Broken for ARM, but not for x86, right? I think SECCLASS_SHADOW is available in the policy bits - it's just whether or not the hook functions are available? > And second because libxl ignores the error it gets back, and blindly > continues onward. Anthony has posted "libs/light: Propagate > libxl__arch_domain_create() return code" to fix the libxl half of the > bug, and I posted a second libxl bugfix to fix an error message. Both > are very simple. > > > For Flask, we need new access vectors because this is a common > hypercall, but I'm unsure how to interlink it with x86's shadow > control. This will require a bit of pondering, but it is probably > easier to just leave them unlinked. It sort of seems like it could go under domain2 since domain/domain2 have most of the memory stuff, but it is non-PV. shadow has its own set of hooks. It could go in hvm which already has some memory stuff. > Flask is listed as experimental which means it doesn't technically > matter if we break it, but it is used by OpenXT so not fixing it for > 4.17 would be rather rude. It's definitely nicer to have functional Flask in the release. OpenXT can use a backport if necessary, so it doesn't need to be a release blocker. Having said that, Flask is a nice feature of Xen, so it would be good to have it functioning in 4.17. Regards, Jason From xen-devel-bounces@lists.xenproject.org Fri Nov 18 21:46:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 21:46:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445922.701349 (Exim 4.92) (envelope-from ) id 1ow9CA-00088R-3X; Fri, 18 Nov 2022 21:46:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445922.701349; Fri, 18 Nov 2022 21:46:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow9C9-00088K-W6; Fri, 18 Nov 2022 21:46:45 +0000 Received: by outflank-mailman (input) for mailman id 445922; Fri, 18 Nov 2022 21:46:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ow9C9-00088E-9y for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 21:46:45 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7c98939e-678a-11ed-8fd2-01056ac49cbb; Fri, 18 Nov 2022 22:46:42 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 8CDB332008FF; Fri, 18 Nov 2022 16:46:39 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 18 Nov 2022 16:46:40 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Nov 2022 16:46:37 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c98939e-678a-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668807999; x= 1668894399; bh=m0qim5xloUqSWCBLe4PKp9y/XJvQoCDrt2G9AYpaGa8=; b=p vQtOjvp0f4uVWQ650FLODz+Gchx4RTWFrmCorFUs3dg/qF1gR1GReNAOvbbDfj05 RLwzicAWmcn8mGNWcF3IAvcG5gW9LYpPqHENDYbnMbklMCg9hXlPB07IShrVMIcX qC7s5++ppkM7TXGOiLqX+KV6BvmK/Hroty8SKb28aiPCpVOyDl74w9mW7ewvdd2r Vw10DJMI23PS/hxi6FugyCWCt9ME9jVw7uMof2mx28V7jH+WEiiBxHs9XjCkga6J o6rGfCN2BHTJFe9ipcfRsR4FGQJ1cMEn4hw7F28f3jzxL/DJmycnDxOMjoBGrH22 bIG3ymvM9l7kaTbHKlQPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668807999; x=1668894399; bh=m0qim5xloUqSWCBLe4PKp9y/XJvQ oCDrt2G9AYpaGa8=; b=L2OjdpMEGbpYn5RluyOLgAEawWRJnDxcYx09A1H0V3vG UVaNQojhYS6LC/+PuhmaXch59rbf6FjYJ7jVNQAPA74IHXP2nPD7qB7RzQCUrS+C d70ucOla/rdJ+hz/SB5uxohfTGMD4vuHfWC01frMuTFsu2/GUEU5qr4gtTK88Lzf qiPwZ1G95xVVAqey4X+ZkaKSWS8q/Iex2YywB1s3SOFs0pD9pTBADlx/e/Rxngfh FUqpuRvwHBH5PlTTGjbS/2vGFKQjdllSlRS1ezGpImRXeOwDoQRT4nuMKks1MdYn zHA/rcTIbE3Lhps863FnqszHU8wSv2PZ5X99AMS7FA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrhedtgdduheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepueek teetgefggfekudehteegieeljeejieeihfejgeevhfetgffgteeuteetueetnecuffhomh grihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Fri, 18 Nov 2022 22:46:34 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jason Andryuk Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Subject: Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled Message-ID: References: <20221118154931.1928298-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qQdthczOYgb16K95" Content-Disposition: inline In-Reply-To: --qQdthczOYgb16K95 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 18 Nov 2022 22:46:34 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jason Andryuk Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Subject: Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled On Fri, Nov 18, 2022 at 03:46:47PM -0500, Jason Andryuk wrote: > On Fri, Nov 18, 2022 at 10:50 AM Marek Marczykowski-G=C3=B3recki > wrote: > > > > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until > > the table is filled. Then it disables INTx just before clearing MASKALL > > bit. Currently this approach is rejected by xen-pciback. > > According to the PCIe spec, device cannot use INTx when MSI/MSI-X is > > enabled (in other words: enabling MSI/MSI-X implicitly disables INTx). > > > > Change the logic to consider INTx disabled if MSI/MSI-X is enabled. This > > applies to three places: > > - checking currently enabled interrupts type, > > - transition to MSI/MSI-X - where INTx would be implicitly disabled, > > - clearing INTx disable bit - which can be allowed even if MSI/MSI-X is > > enabled, as device should consider INTx disabled anyway in that case > > > > Fixes: 5e29500eba2a ("xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKALL= too") > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > > --- > > Changes in v3: > > - allow clearing INTx regardless of MSI/MSI-X state, to be consistent > > with enabling MSI/MSI-X > > Changes in v2: > > - restructure the patch to consider not only MASKALL bit, but enabling > > MSI/MSI-X generally, without explicitly disabling INTx first > > --- >=20 > I was trying to test your xen-pciback v3 patch, and I am having > assignment fail consistently now. It is actually failing to > quarantine to domIO in the first place, which matches the failure from > the other day (when I more carefully read through the logs). It now > consistently fails to quarantine on every boot unlike the other day > where it happened once. Does this include the very first assignment too, or only after domain reboot? If the latter, maybe some cleanup missed clearing MASKALL? FWIW, the patch applied to Qubes (https://github.com/QubesOS/qubes-linux-kernel/pull/680) seems to work fine (the full test run is still in progress, but I see some green marks already). > I added some printks and it 's getting -EBUSY from pdev_msix_assign() > which means pci_reset_msix_state() is failing: > if ( pci_conf_read16(pdev->sbdf, msix_control_reg(pos)) & > PCI_MSIX_FLAGS_MASKALL ) > return -EBUSY; >=20 > # lspci -vv -s 14.3 > ... > Capabilities: [80] MSI-X: Enable- Count=3D16 Masked+ > Vector table: BAR=3D0 offset=3D00002000 > PBA: BAR=3D0 offset=3D00003000 >=20 > So it looks like MASKALL is set and prevents assignment. >=20 > setpci -s 00:14.3 82.W=3Df > cleared that out for me and I could assign the device. >=20 > My dom0 boots, it runs flask-label-pci for a set of PCI devices > (including iwlwifi), then xl pci-assignable-add for all PCI devices > which will be passed through, then a little later it boots the > associated domains. Dom0 does not have a driver for iwlwifi. >=20 > I'll have to investigate more to see how MASKALL is getting set. This > had not been an issue before your recent patches. I guess before the patches nothing set anything in MSI-X capability, because it was hidden... Anyway, to support my cleanup hypothesis, I tried to destroy a PCI-having domain, and it left MSI-X enabled (at least according to the config space). MASKALL was _not_ set, but I haven't checked masking of individual vectors. TBH, I'm not sure what should be responsible for the MSI-X cleanup after guest destroy. Should it be Xen? Qemu? Pciback? Pciback calls PHYSDEVOP_{prepare,release}_msix only when binding/unbinding from the device (so - xl pci-assignable-{add,remove}), so this isn't the right place. Should that be in Xen, in deassign_device() (part of DOMCTL_deassign_device)? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --qQdthczOYgb16K95 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN3/TsACgkQ24/THMrX 1ywkSQf/aTohVS7nA2ExCmuvEVfy/hGZ6deH7uoh3uApGTOhNEmD+ImNzRDDwDW9 vK7MAeJnE9zBQq4zklTd/DiktxefRu6X8HGTklrI8sZ8qjq92NYZF4Vul/g7/+l6 4XGi6dNdvN5P7e7TUTHI49rtBrvfA51DCuW9SLJTvI5RAXXRbLan8luGij51/TWH TsxfNPJ+fX0pWr/G9ynnSeBUJzw+BcBAwj4FaMPkWaOvl0wDK98lspRTrXIJ7Usw nzbgnNqwkAbQ+E/s1eSDnw1BQxDXcFxM6orO6fP/ntFSIpIbHmLesV3erYumLYLf /O8lcstVWu7jFOXtQMBMoc2sYJh92A== =m44E -----END PGP SIGNATURE----- --qQdthczOYgb16K95-- From xen-devel-bounces@lists.xenproject.org Fri Nov 18 23:35:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 23:35:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445934.701366 (Exim 4.92) (envelope-from ) id 1owAsu-0003gU-Us; Fri, 18 Nov 2022 23:35:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445934.701366; Fri, 18 Nov 2022 23:35:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owAsu-0003gN-QZ; Fri, 18 Nov 2022 23:35:00 +0000 Received: by outflank-mailman (input) for mailman id 445934; Fri, 18 Nov 2022 23:35:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owAst-0003gH-BY for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 23:35:00 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b8a188a-6799-11ed-8fd2-01056ac49cbb; Sat, 19 Nov 2022 00:34:56 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F2069627C2; Fri, 18 Nov 2022 23:34:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36654C433D7; Fri, 18 Nov 2022 23:34:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b8a188a-6799-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668814494; bh=skqeH9P/3U/0oqXFG+A3ElWlnHoKLUDJ0goaqolA7mc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=SrrpXpKdN5TVCYfgUXrxhYZt4YxOQxcW5K0vHUJUobEfSpByRuIl/11SxA1kSlu+k gvvrCflDYnJnAwhS7UQSKCrDRekMX+CwcpZhFIh3GhHb0dwX8ozM5F6EMER+joxfI/ f4W6ffA+wyJxdS9qFZRLuOFq+uYSUZGTYhDUnB4qaOC+jOQXwuwcjChtfQnfxrDWVz 1EW12MI4rnWnCYahlLI/Xu9B0DJi6/C9iPgcADq+5GTadcGprNDa5sepHJ1Zg9IRdl jQnS540AFaYA7LAWr3N/Q4eRD14JD3nCX3LTylJsgxwe7hVHy3DZxpAAl3ATQwmGrR +1D8OU4F7KL9A== Date: Fri, 18 Nov 2022 15:34:51 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Bertrand Marquis cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v4 1/3] automation: Create Yocto docker images In-Reply-To: <6d48a0f83324d2f42597d43c41ce72d6d80150e6.1668677493.git.bertrand.marquis@arm.com> Message-ID: References: <6d48a0f83324d2f42597d43c41ce72d6d80150e6.1668677493.git.bertrand.marquis@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1987139687-1668809228=:1049131" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1987139687-1668809228=:1049131 Content-Type: text/plain; CHARSET=US-ASCII Content-ID: On Thu, 17 Nov 2022, Bertrand Marquis wrote: > Add containers suitable to run yocto kirkstone build based on ubuntu > 22.04. It contains all packages required by Yocto and a checkout of the > layers required to build Xen with Yocto. > > Add a generic docker image template to be used to automatically generate > docker files for different configurations: > - specific yocto version > - different targets (qemu arm, arm64 and x86) > - different host platforms (x86 or arm64) > > During a call to 'make all', only the images for the current host > platform will be generated. > If needed, images for an other host platform can be generated manually > by calling the right make target (see make help). > > Add a build script to build and run xen on qemu using Yocto. > The script supports arm32, arm64 and x86_64 and checks that dom0 is > properly booting. At this stage this does not run any guest on top of > dom0. The script is to be executed in one of the docker images to build > and run a system using a Xen source tree. > > Signed-off-by: Bertrand Marquis This series looks great and I think it is almost ready to be committed. Only one comment from me below. Also, I tested it successfully both building the containers, and also the full gitlab-ci pipeline, hurray! The only issue is that it works for qemuarm64 and qemuarm, but not qemux86-64: the container build doesn't work. I am attaching the error logs from 2 different builds on 2 different arm64 machines. To be honest, if qemux86-64 on arm64 turns out to be an issue, I'd be happy to take the series without it for now. > --- > Changes in v4: > - Rework the system to have one dockerfile template from which make will > generate the required dockerfiles for the wanted configuration > - add support for different host architectures > - Merge the generation system into one single dockerfile > - Merge patches 1 and 2 in a single patch > - Introduce CONTAINERS_EXTRA to have extra containers not built by > default (for those not used by CI but useful to users) > Changes in v3: > - limit number of jobs in yocto by default to 8 and add --num-jobs > option to the script to set a custom number of jobs > - do not copy anymore the build-yocto.sh script inside the main image so > that the current one in the repository is used when running > Changes in v2: > - add a --dump-log command line option to build-yocto.sh script to dump > the logs if an error occurs. > Changes in v1: > - add --image command line argument to build-yocto.sh to allow building > something different than xen-image-minimal. > - modify dockerfile to have one layer per line and make it easier to add > other. I kept the for loop to keep the number of docker steps lower > - update commit message to warn that no guest are tested. > - fix build-yocto script to properly return with an error if expect > script ends up in timeout or EOF. > --- > automation/build/Makefile | 14 +- > automation/build/yocto/build-yocto.sh | 349 +++++++++++++++++++++ > automation/build/yocto/yocto.dockerfile.in | 114 +++++++ > automation/build/yocto/yocto.inc | 41 +++ > 4 files changed, 516 insertions(+), 2 deletions(-) > create mode 100755 automation/build/yocto/build-yocto.sh > create mode 100644 automation/build/yocto/yocto.dockerfile.in > create mode 100644 automation/build/yocto/yocto.inc > > diff --git a/automation/build/Makefile b/automation/build/Makefile > index a4b2b85178cf..72a5335baec1 100644 > --- a/automation/build/Makefile > +++ b/automation/build/Makefile > @@ -1,13 +1,18 @@ > > # the base of where these containers will appear > REGISTRY := registry.gitlab.com/xen-project/xen > -CONTAINERS = $(subst .dockerfile,,$(wildcard */*.dockerfile)) > +CONTAINERS = $(filter-out yocto/%,$(subst .dockerfile,,$(wildcard */*.dockerfile))) > +CONTAINERS_EXTRA = > DOCKER_CMD ?= docker > > +include yocto/yocto.inc I think it would be good to add a comment here to say how make could be invoked for the yocto containers, for instance "make yocto/kirkstone-qemuarm64" or "make yocto/kirkstone-qemuarm64-arm64v8" and explain the difference. People tend to build locally individual containers, rather than the whole set. > help: > @echo "Builds containers for building Xen based on different distros" > @echo "To build one run 'make DISTRO/VERSION'. Available containers:" > @$(foreach file,$(sort $(CONTAINERS)),echo ${file};) > + @echo "Extra containers (not built using make all):" > + @$(foreach file,$(sort $(CONTAINERS_EXTRA)),echo ${file};) > @echo "To push container builds, set the env var PUSH" > > %: %.dockerfile ## Builds containers > @@ -16,5 +21,10 @@ help: > $(DOCKER_CMD) push $(REGISTRY)/$(@D):$(@F); \ > fi > > -.PHONY: all > +.PHONY: all clean > all: $(CONTAINERS) > + > +# Remove generated dockerfiles for yocto > +clean: > + rm -f yocto/*.dockerfiles > + > diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh > new file mode 100755 > index 000000000000..d0c93dfaffe0 > --- /dev/null > +++ b/automation/build/yocto/build-yocto.sh > @@ -0,0 +1,349 @@ > +#!/bin/bash > +# > +# Yocto meta virtualization build and run script > +# > +# This script is building Yocto xen-image-minimal for qemu targets and run > +# them using runqemu inside yocto to check that dom0 is booting properly > +# The build is using a local xen source tree so that specific patches can be > +# tested. > +# In order to optimize the build time, a build cache is used so that only xen > +# packages and its dependencies are rebuilt (qemu and final image mainly). > +# > + > +# Directories > +YOCTODIR="$HOME/yocto-layers" > +CACHEDIR="$HOME/yocto-cache" > +LOGDIR="$HOME/logs" > +XENDIR="$HOME/xen" > +BUILDDIR="$HOME/build" > + > +# what yocto bsp we support > +TARGET_SUPPORTED="qemuarm qemuarm64 qemux86-64" > +VERBOSE="n" > +TARGETLIST="" > +BUILDJOBS="8" > + > +# actions to do > +do_clean="n" > +do_build="y" > +do_run="y" > +do_localsrc="n" > +do_dump="n" > +build_result=0 > + > +# layers to include in the project > +build_layerlist="poky/meta poky/meta-poky poky/meta-yocto-bsp \ > + meta-openembedded/meta-oe meta-openembedded/meta-python \ > + meta-openembedded/meta-filesystems \ > + meta-openembedded/meta-networking meta-virtualization" > + > +# yocto image to build > +build_image="xen-image-minimal" > + > +function print_progress() { > + echo -n "$(date +%T) $*" > +} > + > +function run_task() { > + local task_name="$1" > + local task_target="$2" > + > + task_log="${task_name//project_}-${task_target}" > + > + mkdir -p "${LOGDIR}" > + print_progress > + echo -n "${task_name//project_} ${task_target}: " > + if [ "${VERBOSE}" = "n" ]; then > + $@ > "${LOGDIR}/${task_log}.log" 2>&1 > + else > + $@ 2>&1 | tee "${LOGDIR}/${task_log}.log" > + fi > + > + if [ ${?} -ne 0 ]; then > + echo "Error" > + build_result=$((build_result+1)) > + if [ "${do_dump}" = "y" ]; then > + echo > + echo "############ LOGS-START ############" > + cat "${LOGDIR}/${task_log}.log" > + echo "############ LOGS-END ############" > + echo > + fi > + return 1 > + else > + echo "OK" > + return 0 > + fi > +} > + > +function project_create() { > + target="${1:?}" > + destdir="${BUILDDIR}/${target}" > + > + ( > + # init yocto project > + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" > + > + # add needed layers > + for layer in ${build_layerlist}; do > + bitbake-layers add-layer ${YOCTODIR}/${layer} || exit 1 > + done > + ) || return 1 > + > + # customize project configuration > + cat <> "${destdir}/conf/local.conf" > +# Yocto BSP > +MACHINE = "${target}" > + > +# Use local cache to reuse previous builds results > +SSTATE_DIR = "${CACHEDIR}/sstate-cache" > +DL_DIR = "${CACHEDIR}/downloads" > + > +# Enable xen and virtualization > +DISTRO_FEATURES = " virtualization xen ipv4" > + > +# Speed up run by not generating ssh host keys > +IMAGE_INSTALL:append:pn-xen-image-minimal = " ssh-pregen-hostkeys" > + > +# Save some disk space > +INHERIT += "rm_work" > + > +# Reduce number of jobs > +BB_NUMBER_THREADS="${BUILDJOBS}" > + > +EOF > + > + if [ "${do_localsrc}" = "y" ]; then > + XENVERS=$(grep -e "^XEN_REL" \ > + "${YOCTODIR}"/meta-virtualization/recipes-extended/xen/xen_*.bb \ > + 2> /dev/null | tr -d ' ' | tr -d '?' | tr -d '"' \ > + | sed -e "s/.*=//" | sort -V | tail -n 1) > + > + XENBASE=$(dirname "$(realpath -m "${XENDIR}")") > + XENSUB=$(basename "$(realpath -m "${XENDIR}")") > + > + cat <> "${destdir}/conf/local.conf" > +# Use local sources for xen and xen-tools > +FILESEXTRAPATHS:prepend:pn-xen := "${XENBASE}:" > +FILESEXTRAPATHS:prepend:pn-xen-tools := "${XENBASE}:" > + > +SRC_URI:pn-xen = "file://${XENSUB}/;subdir=local-xen/" > +SRC_URI:pn-xen-tools = "file://${XENSUB}/;subdir=local-xen/" > + > +PREFERRED_VERSION:pn-xen = "${XENVERS}%" > +PREFERRED_VERSION:pn-xen-tools = "${XENVERS}%" > + > +S:pn-xen = "\${WORKDIR}/local-xen/${XENSUB}" > +S:pn-xen-tools = "\${WORKDIR}/local-xen/${XENSUB}" > + > +SRCREV:pn-xen = "\${AUTOREV}" > +SRCREV:pn-xen-tools = "\${AUTOREV}" > + > +SRCPV:pn-xen = "1" > +SRCPV:pn-xen-tools = "1" > + > +# Disable all QA errors as the recipe is not up to date with changes in Xen > +# when we use local sources > +ERROR_QA:pn-xen = "arch" > +ERROR_QA:pn-xen-tools = "arch" > + > +EOF > + fi > +} > + > +function project_build() { > + target="${1:?}" > + destdir="${BUILDDIR}/${target}" > + > + ( > + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" > + > + bitbake "${build_image}" || exit 1 > + ) || return 1 > +} > + > +function project_clean() { > + target="${1:?}" > + destdir="${BUILDDIR}/${target}" > + > + rm -rf "${destdir}" > +} > + > +function project_run() { > + target="${1:?}" > + destdir="${BUILDDIR}/${target}" > + ( > + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" > /dev/null 2>&1 > + > + /usr/bin/expect < +set timeout 100 > +spawn bash -c "runqemu serialstdio nographic slirp" > + > +expect_after { > + -re "(.*)\r" { > + exp_continue > + } > + timeout {send_user "ERROR-Timeout!\n"; exit 1} > + eof {send_user "ERROR-EOF!\n"; exit 1} > +} > + > +# wait initial login > +expect -re ".* login: " > +send "root\r" > +expect -re "root@.*# " > + > +EOF > + exit $? > + ) || return 1 > +} > + > +function help() { > + cat < +Usage: ${0} [TARGET1] [TARGET2] > + > +This script is build the yocto xen-image-minimal for different qemu targets > +and is running it after. > +Without any target specified, all supported targets are done. > + > +Options: > + -h, --help Print this help > + -v, --verbose Verbose build > + --list-target List supported targets > + --clean Clean existing project before starting > + --no-build Do not build (to run an already built project) > + --no-run Do not run > + --num-jobs=NUM Define the number of parallel jobs in Yocto. > + Default: ${BUILDJOBS} > + --dump-log On error, dump the logs on the console > + --image=IMG Yocto image or package to build > + Default: xen-image-minimal > + --xen-dir=DIR path to xen hypervisor source tree > + if not provide, normal yocto version of xen is built > + Default: ${XENDIR} > + --out-dir=DIR directory where to create the projectss > + Default: ${BUILDDIR} > + --log-dir=DIR directory to store logs > + Default: ${LOGDIR} > + --cache-dir=DIR directory where to take and store build cache > + Default: ${CACHEDIR} > + --layer-dir=DIR directory containing the checkout of yocto layers > + Default: ${YOCTODIR} > +EOF > +} > + > +for OPTION in "$@" > +do > + case ${OPTION} in > + -h|--help) > + help > + exit 0 > + ;; > + -v|--verbose) > + VERBOSE="y" > + ;; > + --list-targets) > + echo "${TARGET_SUPPORTED}" > + exit 0 > + ;; > + --clean) > + do_clean="y" > + ;; > + --no-build) > + do_build="n" > + ;; > + --no-run) > + do_run="n" > + ;; > + --dump-log) > + do_dump="y" > + ;; > + --num-jobs=*) > + BUILDJOBS="${OPTION#*=}" > + ;; > + --image=*) > + build_image="${OPTION#*=}" > + ;; > + --xen-dir=*) > + XENDIR="${OPTION#*=}" > + if [ ! -e "${XENDIR}/xen/Makefile" ]; then > + echo "No Xen source tree in ${XENDIR}" > + exit 1 > + fi > + do_localsrc="y" > + ;; > + --out-dir=*) > + BUILDDIR="${OPTION#*=}" > + ;; > + --log-dir=*) > + LOGDIR="${OPTION#*=}" > + ;; > + --cache-dir=*) > + CACHEDIR="${OPTION#*=}" > + ;; > + --layer-dir=*) > + YOCTODIR="${OPTION#*=}" > + ;; > + --*) > + echo "Invalid option ${OPTION}" > + help > + exit 1 > + ;; > + *) > + if echo "${TARGET_SUPPORTED}" | grep -q -w "${OPTION}"; then > + TARGETLIST="${TARGETLIST} ${OPTION}" > + else > + echo "Unsupported target ${OPTION}" > + exit 1 > + fi > + ;; > + esac > +done > + > +# if no target is specified build all targets > +if [ -z "${TARGETLIST}" ]; then > + TARGETLIST="${TARGET_SUPPORTED}" > +fi > + > +mkdir -p "${CACHEDIR}" > +mkdir -p "${LOGDIR}" > +mkdir -p "${BUILDDIR}" > + > +# Make sure we have an absolute path > +YOCTODIR=$(realpath -m "${YOCTODIR}") > +CACHEDIR=$(realpath -m "${CACHEDIR}") > +BUILDDIR=$(realpath -m "${BUILDDIR}") > +LOGDIR=$(realpath -m "${LOGDIR}") > +if [ "${do_localsrc}" = "y" ]; then > + XENDIR=$(realpath -m "${XENDIR}") > +fi > + > +# Check that we have all the layers we need > +for f in ${build_layerlist}; do > + if [ ! -f "${YOCTODIR}/${f}/conf/layer.conf" ]; then > + echo "Layer ${f} missing in ${YOCTODIR}" > + exit 1 > + fi > +done > + > +for f in ${TARGETLIST}; do > + if [ "${do_clean}" = "y" ]; then > + run_task project_clean ${f} > + fi > + if [ ! -f ${BUILDDIR}/${f}/conf/local.conf ]; then > + run_task project_create ${f} > + fi > + if [ -f ${BUILDDIR}/${f}/conf/local.conf ]; then > + if [ "${do_build}" = "y" ]; then > + run_task project_build ${f} > + fi > + if [ "${do_run}" = "y" ]; then > + run_task project_run ${f} > + fi > + > + fi > +done > + > +print_progress "Build Complete (${build_result} errors)" > +echo > +exit ${build_result} > + > diff --git a/automation/build/yocto/yocto.dockerfile.in b/automation/build/yocto/yocto.dockerfile.in > new file mode 100644 > index 000000000000..5350bb2b87b7 > --- /dev/null > +++ b/automation/build/yocto/yocto.dockerfile.in > @@ -0,0 +1,114 @@ > +# Docker file to create an environment to build yocto with virtualization > +# > +# Arguments that can be passed during image creation using --build-arg: > +# "host_uid=$(id -u)": to use current user uid for build user in the image > +# "host_gid=$(id -g)": to use current user gid for build user in the image > +# "ubuntu_version=VERS": to select the ubuntu version number > + > +# Use standard ubuntu minimal > +ARG ubuntu_version=22.04 > +From ##DOCKERPLAT##ubuntu:$ubuntu_version AS base > +LABEL maintainer.name="The Xen Project " \ > + maintainer.email="xen-devel@lists.xenproject.org" > + > +ENV DEBIAN_FRONTEND=noninteractive > + > +# Install minimal ubuntu requirements for yocto and other tools we need > +# See https://docs.yoctoproject.org/4.0.1/brief-yoctoprojectqs/index.html#build-host-packages > +RUN apt-get update && \ > + apt-get --quiet --yes install \ > + gawk \ > + wget \ > + git \ > + diffstat \ > + unzip \ > + texinfo \ > + gcc \ > + build-essential \ > + chrpath \ > + socat \ > + cpio \ > + python3 \ > + python3-pip \ > + python3-pexpect \ > + xz-utils \ > + debianutils \ > + iputils-ping \ > + python3-git \ > + python3-jinja2 \ > + libegl1-mesa \ > + libsdl1.2-dev \ > + python3-subunit \ > + mesa-common-dev \ > + zstd \ > + liblz4-tool \ > + file \ > + vim \ > + bison \ > + expect \ > + locales \ > + liblz4-tool \ > + zstd \ > + openssl \ > + libssl3 \ > + ca-certificates \ > + && \ > + apt-get autoremove -y && \ > + apt-get clean && \ > + rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* > + > +# Use bash as shell > +RUN rm /bin/sh && ln -s bash /bin/sh > + > +# Fix local for yocto > +RUN locale-gen en_US.UTF-8 && update-locale LC_ALL=en_US.UTF-8 \ > + LANG=en_US.UTF-8 > +ENV LANG en_US.UTF-8 > +ENV LC_ALL en_US.UTF-8 > + > +# Create a user for the build (we don't want to build as root) > +ENV USER_NAME docker-build > +ARG host_uid=1000 > +ARG host_gid=1000 > +RUN groupadd -g $host_gid $USER_NAME && \ > + useradd -g $host_gid -m -s /bin/bash -u $host_uid $USER_NAME > + > +# Switch to our user instead of root and start in its home > +USER $USER_NAME > +WORKDIR /home/$USER_NAME > + > +# Create needed directories > +RUN mkdir -p /home/$USER_NAME/yocto-layers \ > + /home/$USER_NAME/yocto-cache \ > + /home/$USER_NAME/logs \ > + /home/$USER_NAME/bin \ > + /home/$USER_NAME/xen && \ > + chown $USER_NAME.$USER_NAME /home/$USER_NAME/* > + > +# clone yocto repositories we need > +RUN for rep in \ > + https://github.com/openembedded/meta-openembedded \ > + https://git.yoctoproject.org/poky \ > + https://git.yoctoproject.org/meta-virtualization \ > + ; do \ > + git -C /home/$USER_NAME/yocto-layers \ > + clone -b ##YOCTOVERSION## --single-branch $rep; \ > + done > + > +# The builder stage is building an initial cache state that we include in the > +# final image > +From base AS builder > + > +# This step can take one to several hours depending on your download bandwith > +# and the speed of your computer > +COPY ./build-yocto.sh / > +RUN /build-yocto.sh --dump-log ##YOCTOTARGET## > + > +From base > + > +# Only copy the cache status > +COPY --from=builder /home/$USER_NAME/yocto-cache /home/$USER_NAME/yocto-cache/. > + > +LABEL maintainer.name="The Xen Project " \ > + maintainer.email="xen-devel@lists.xenproject.org" > + > diff --git a/automation/build/yocto/yocto.inc b/automation/build/yocto/yocto.inc > new file mode 100644 > index 000000000000..04076bc8d174 > --- /dev/null > +++ b/automation/build/yocto/yocto.inc > @@ -0,0 +1,41 @@ > +# This makefile generates the docker files for Yocto builds > +# The containers for the current architecture are the one built using make all > +# To build containers for a different architecture, you need to call make for > +# the image you want explicitely > +# The containers are named this way: > +# YOCTOVERSION-TARGET for x86_64 hosts > +# YOCTOVERSION-TARGET-arm64v8 for arm64 hosts > + > +# Yocto versions we are currently using > +YOCTO_VERSION = kirkstone > + > +# Yocto BSPs we want to build for > +YOCTO_TARGETS = qemuarm64 qemuarm qemux86-64 > + > +# Supported Host platforms (host architecture specific ones) > +YOCTO_HOSTS = amd64 arm64v8 > + > +# Architecture we want to use in gitlab CI (depends on runners arch) > +CI_ARCH = arm64v8 > + > +define GEN_DOCKER > +# Make all is generating what we want in the CI > +ifeq ($(CI_ARCH),$(3)) > +CONTAINERS += yocto/$(1)-$(2)$(4) > +else > +CONTAINERS_EXTRA += yocto/$(1)-$(2)$(4) > +endif > + > +yocto/$(1)-$(2)$(4).dockerfile: yocto/yocto.dockerfile.in > + echo > $$@ > + cat $$< | \ > + sed -e "s,##YOCTOVERSION##,$(1),g" | \ > + sed -e "s,##YOCTOTARGET##,$(2),g" | \ > + sed -e "s,##DOCKERPLAT##,$(3)/,g" > $$@ > + > +endef > + > +$(eval $(foreach vers,$(YOCTO_VERSION),\ > + $(foreach tar,$(YOCTO_TARGETS),\ > + $(foreach hst,$(YOCTO_HOSTS),\ > + $(call GEN_DOCKER,$(vers),$(tar),$(hst),$(if $(filter amd64,$(hst)),,-$(hst))))))) > -- > 2.25.1 > --8323329-1987139687-1668809228=:1049131 Content-Type: application/octet-stream; NAME=build.log Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: ATTACHMENT; FILENAME=build.log fCBzZWQgLWUgJ3MvQW1sQ29kZS9zc2R0X3M0L2cnIC1lICdzL19hbWxfY29k ZS8vZycgL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1w L3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFi bGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYnMvbGlnaHQv c3NkdF9zNC5oZXggPi9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2 LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQu MTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJz L2xpZ2h0L3NzZHRfczQuaAp8IEFTTCBJbnB1dDogICAgIHNzZHRfdHBtLmFz bCAtICAgICA5MTIgYnl0ZXMgICAgICAzIGtleXdvcmRzICAgICAzMCBzb3Vy Y2UgbGluZXMKfCBBTUwgT3V0cHV0OiAgICAvaG9tZS9kb2NrZXItYnVpbGQv YnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4 L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9n aXQvdG9vbHMvbGlicy9saWdodC9zc2R0X3RwbS5hbWwgLSAgICAgIDc2IGJ5 dGVzICAgICAgMCBvcGNvZGVzICAgICAgIDMgbmFtZWQgb2JqZWN0cwp8IEhl eCBEdW1wOiAgICAgIC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2 LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQu MTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJz L2xpZ2h0L3NzZHRfdHBtLmhleCAtICAgIDExNTMgYnl0ZXMKfCAKfCBDb21w aWxhdGlvbiBzdWNjZXNzZnVsLiAwIEVycm9ycywgMCBXYXJuaW5ncywgMCBS ZW1hcmtzLCAwIE9wdGltaXphdGlvbnMKfCBzZWQgLWUgJ3MvQW1sQ29kZS9z c2R0X3RwbS9nJyAtZSAncy9fYW1sX2NvZGUvL2cnIC9ob21lL2RvY2tlci1i dWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3kt bGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIy LXIwL2dpdC90b29scy9saWJzL2xpZ2h0L3NzZHRfdHBtLmhleCA+L2hvbWUv ZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTIt NjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2Yy NjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYnMvbGlnaHQvc3NkdF90cG0uaAp8 IEFTTCBJbnB1dDogICAgIHNzZHRfbGFwdG9wX3NsYXRlLmFzbCAtICAgIDEw ODYgYnl0ZXMgICAgICA0IGtleXdvcmRzICAgICA0MCBzb3VyY2UgbGluZXMK fCBBTUwgT3V0cHV0OiAgICAvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVt dXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29s cy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMv bGlicy9saWdodC9zc2R0X2xhcHRvcF9zbGF0ZS5hbWwgLSAgICAgIDczIGJ5 dGVzICAgICAgMSBvcGNvZGVzICAgICAgIDMgbmFtZWQgb2JqZWN0cwp8IEhl eCBEdW1wOiAgICAgIC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2 LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQu MTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJz L2xpZ2h0L3NzZHRfbGFwdG9wX3NsYXRlLmhleCAtICAgIDExODkgYnl0ZXMK fCAKfCBDb21waWxhdGlvbiBzdWNjZXNzZnVsLiAwIEVycm9ycywgMCBXYXJu aW5ncywgMCBSZW1hcmtzLCAwIE9wdGltaXphdGlvbnMKfCBzZWQgLWUgJ3Mv QW1sQ29kZS9zc2R0X2xhcHRvcF9zbGF0ZS9nJyAtZSAncy9fYW1sX2NvZGUv L2cnIC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93 b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxl QVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJzL2xpZ2h0L3Nz ZHRfbGFwdG9wX3NsYXRlLmhleCA+L2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxk L3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4t dG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rv b2xzL2xpYnMvbGlnaHQvc3NkdF9sYXB0b3Bfc2xhdGUuaAp8IHNzZHRfcG0u YXNsICAgIDM5NzogICAgICAgICAgICAgICAgIFN0b3JlIChcX1NCLlBCMiwg TG9jYWwwKQp8IFdhcm5pbmcgIDMxNDQgLSAgICAgICBNZXRob2QgTG9jYWwg aXMgc2V0IGJ1dCBuZXZlciB1c2VkIF4gIChMb2NhbDApCnwgCnwgQVNMIElu cHV0OiAgICAgc3NkdF9wbS5hc2wgLSAgIDEyNTc1IGJ5dGVzICAgIDE5MiBr ZXl3b3JkcyAgICA0MjAgc291cmNlIGxpbmVzCnwgQU1MIE91dHB1dDogICAg L2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsv Y29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRP SU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYnMvbGlnaHQvc3NkdF9w bS5hbWwgLSAgICAxNDQ3IGJ5dGVzICAgIDEzMSBvcGNvZGVzICAgICAgNjEg bmFtZWQgb2JqZWN0cwp8IEhleCBEdW1wOiAgICAgIC9ob21lL2RvY2tlci1i dWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3kt bGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIy LXIwL2dpdC90b29scy9saWJzL2xpZ2h0L3NzZHRfcG0uaGV4IC0gICAxMzk3 NSBieXRlcwp8IAp8IENvbXBpbGF0aW9uIHN1Y2Nlc3NmdWwuIDAgRXJyb3Jz LCAxIFdhcm5pbmdzLCAwIFJlbWFya3MsIDMxIE9wdGltaXphdGlvbnMKfCBz ZWQgLWUgJ3MvQW1sQ29kZS9zc2R0X3BtL2cnIC1lICdzL19hbWxfY29kZS8v ZycgL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dv cmsvY29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVB VVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYnMvbGlnaHQvc3Nk dF9wbS5oZXggPi9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0 L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYr c3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJzL2xp Z2h0L3NzZHRfcG0uaAp8IHJtIC1mIC9ob21lL2RvY2tlci1idWlsZC9idWls ZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVu LXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90 b29scy9saWJzL2xpZ2h0L3NzZHRfczMuYW1sIC9ob21lL2RvY2tlci1idWls ZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGlu dXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIw L2dpdC90b29scy9saWJzL2xpZ2h0L3NzZHRfczMuaGV4Cnwgcm0gLWYgL2hv bWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29y ZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5D K2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYnMvbGlnaHQvc3NkdF90cG0u YW1sIC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93 b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxl QVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJzL2xpZ2h0L3Nz ZHRfdHBtLmhleAp8IHg4Nl82NC1wb2t5LWxpbnV4LWdjYyAgLS1zeXNyb290 PS9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3Jr L2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVU T0lOQytmMjY1NDQ0OTIyLXIwL3JlY2lwZS1zeXNyb290ICAgLW02NCAtREJV SUxEX0lEIC1mbm8tc3RyaWN0LWFsaWFzaW5nIC1zdGQ9Z251OTkgLVdhbGwg LVdzdHJpY3QtcHJvdG90eXBlcyAtV2RlY2xhcmF0aW9uLWFmdGVyLXN0YXRl bWVudCAtV25vLXVudXNlZC1idXQtc2V0LXZhcmlhYmxlIC1Xbm8tdW51c2Vk LWxvY2FsLXR5cGVkZWZzICAgLU8yIC1mb21pdC1mcmFtZS1wb2ludGVyIC1E X19YRU5fSU5URVJGQUNFX1ZFUlNJT05fXz1fX1hFTl9MQVRFU1RfSU5URVJG QUNFX1ZFUlNJT05fXyAtTU1EIC1NUCAtTUYgLl9saWJ4bC5hcGktZm9yLWNo ZWNrLmQgLURfTEFSR0VGSUxFX1NPVVJDRSAtRF9MQVJHRUZJTEU2NF9TT1VS Q0UgLURDT05GSUdfUENJX1NVUFBfTEVHQUNZX0lSUSAtZnN0YWNrLXByb3Rl Y3Rvci1zdHJvbmcgIC1PMiAtRF9GT1JUSUZZX1NPVVJDRT0yIC1XZm9ybWF0 IC1XZm9ybWF0LXNlY3VyaXR5IC1XZXJyb3I9Zm9ybWF0LXNlY3VyaXR5ICAt TzIgLXBpcGUgLWcgLWZlbGltaW5hdGUtdW51c2VkLWRlYnVnLXR5cGVzIC1m bWFjcm8tcHJlZml4LW1hcD0vaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVt dXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29s cy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMD0vdXNyL3NyYy9k ZWJ1Zy94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjIt cjAgICAgICAgICAgICAgICAgICAgICAgLWZkZWJ1Zy1wcmVmaXgtbWFwPS9o b21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2Nv cmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lO QytmMjY1NDQ0OTIyLXIwPS91c3Ivc3JjL2RlYnVnL3hlbi10b29scy80LjE2 K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMCAgICAgICAgICAgICAgICAg ICAgICAtZmRlYnVnLXByZWZpeC1tYXA9L2hvbWUvZG9ja2VyLWJ1aWxkL2J1 aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94 ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvcmVj aXBlLXN5c3Jvb3Q9ICAgICAgICAgICAgICAgICAgICAgIC1mZGVidWctcHJl Zml4LW1hcD0vaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90 bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80LjE2K3N0 YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9yZWNpcGUtc3lzcm9vdC1uYXRp dmU9ICAtV25vLWZvcm1hdC16ZXJvLWxlbmd0aCAtV21pc3NpbmctZGVjbGFy YXRpb25zIC1Xbm8tZGVjbGFyYXRpb24tYWZ0ZXItc3RhdGVtZW50IC1XZm9y bWF0LW5vbmxpdGVyYWwgLUkuIC1wdGhyZWFkIC1XZXJyb3IgLVdtaXNzaW5n LXByb3RvdHlwZXMgLUkuL2luY2x1ZGUgLUkvaG9tZS9kb2NrZXItYnVpbGQv YnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4 L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9n aXQvdG9vbHMvbGlicy9saWdodC8uLi8uLi8uLi90b29scy9pbmNsdWRlICAt SS9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3Jr L2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVU T0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJzL2xpZ2h0Ly4uLy4u Ly4uL3Rvb2xzL2luY2x1ZGUgIC1JL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxk L3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4t dG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rv b2xzL2xpYnMvbGlnaHQvLi4vLi4vLi4vdG9vbHMvaW5jbHVkZSAgLUkvaG9t ZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3Jl Mi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMr ZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMvbGlicy9saWdodC8uLi8uLi8uLi90 b29scy9pbmNsdWRlICAtSS9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11 eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xz LzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9s aWJzL2xpZ2h0Ly4uLy4uLy4uL3Rvb2xzL2luY2x1ZGUgLURfX1hFTl9UT09M U19fICAtSS9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3Rt cC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3Rh YmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJzL2xpZ2h0 Ly4uLy4uLy4uL3Rvb2xzL2luY2x1ZGUgIC1JL2hvbWUvZG9ja2VyLWJ1aWxk L2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51 eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAv Z2l0L3Rvb2xzL2xpYnMvbGlnaHQvLi4vLi4vLi4vdG9vbHMvaW5jbHVkZSAg LUkvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29y ay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFV VE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMvbGlicy9saWdodC8uLi8u Li8uLi90b29scy9pbmNsdWRlIC1JL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxk L3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4t dG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvcmVjaXBl LXN5c3Jvb3QvdXNyL2luY2x1ZGUvbGlibmwzIC1Xc2hhZG93IC1pbmNsdWRl IC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3Jr L2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVU T0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJzL2xpZ2h0Ly4uLy4u Ly4uL3Rvb2xzL2NvbmZpZy5oIC1JL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxk L3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4t dG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rv b2xzL2xpYnMvbGlnaHQvLi4vLi4vLi4vdG9vbHMvaW5jbHVkZSAtSS9ob21l L2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUy LTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytm MjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJzL2xpZ2h0Ly4uLy4uLy4uL3Rv b2xzL2luY2x1ZGUgIC1jIC1FIC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9x ZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRv b2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29s cy9saWJzL2xpZ2h0Ly4uLy4uLy4uL3Rvb2xzL2luY2x1ZGUvbGlieGwuaCAg XAp8ICAgICAgIC1ETElCWExfRVhURVJOQUxfQ0FMTEVSU19PTkxZPUxJQlhM X0VYVEVSTkFMX0NBTExFUlNfT05MWSBcCnwgICAgICAgPl9saWJ4bC5hcGkt Zm9yLWNoZWNrLm5ldwp8IHJtIC1mIC9ob21lL2RvY2tlci1idWlsZC9idWls ZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVu LXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90 b29scy9saWJzL2xpZ2h0L3NzZHRfczQuYW1sIC9ob21lL2RvY2tlci1idWls ZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGlu dXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIw L2dpdC90b29scy9saWJzL2xpZ2h0L3NzZHRfczQuaGV4CnwgL2hvbWUvZG9j a2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQt cG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0 NDQ5MjItcjAvcmVjaXBlLXN5c3Jvb3QtbmF0aXZlL3Vzci9iaW4vcHl0aG9u My1uYXRpdmUvcHl0aG9uMyBnZW50ZXN0LnB5IGxpYnhsX3R5cGVzLmlkbCB0 ZXN0aWRsLmMubmV3Cnwgcm0gLWYgL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxk L3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4t dG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rv b2xzL2xpYnMvbGlnaHQvc3NkdF9sYXB0b3Bfc2xhdGUuYW1sIC9ob21lL2Rv Y2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0 LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1 NDQ0OTIyLXIwL2dpdC90b29scy9saWJzL2xpZ2h0L3NzZHRfbGFwdG9wX3Ns YXRlLmhleAp8IHJtIC1mIC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11 eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xz LzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9s aWJzL2xpZ2h0L3NzZHRfcG0uYW1sIC9ob21lL2RvY2tlci1idWlsZC9idWls ZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVu LXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90 b29scy9saWJzL2xpZ2h0L3NzZHRfcG0uaGV4CnwgSW4gZmlsZSBpbmNsdWRl ZCBmcm9tIG1rX2RzZHQuYzoyMToKfCAvaG9tZS9kb2NrZXItYnVpbGQvYnVp bGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hl bi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQv dG9vbHMvbGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9hcmNoLXg4 Ni94ZW4uaDozNDogZXJyb3I6ICJfX19ERUZJTkVfWEVOX0dVRVNUX0hBTkRM RSIgcmVkZWZpbmVkIFstV2Vycm9yXQp8ICAgIDM0IHwgI2RlZmluZSBfX19E RUZJTkVfWEVOX0dVRVNUX0hBTkRMRShuYW1lLCB0eXBlKSBcCnwgICAgICAg fAp8IEluIGZpbGUgaW5jbHVkZWQgZnJvbSAvaG9tZS9kb2NrZXItYnVpbGQv YnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4 L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9n aXQvdG9vbHMvbGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9hcmNo LXg4Ni8uLi94ZW4uaDozNSwKfCAgICAgICAgICAgICAgICAgIGZyb20gL2hv bWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29y ZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5D K2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMv aW5jbHVkZS94ZW4vYXJjaC14ODYveGVuLmg6MjcsCnwgICAgICAgICAgICAg ICAgICBmcm9tIG1rX2RzZHQuYzoyMToKfCAvaG9tZS9kb2NrZXItYnVpbGQv YnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4 L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9n aXQvdG9vbHMvbGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9hcmNo LXg4Ni8uLi9hcmNoLWFybS5oOjE3Njogbm90ZTogdGhpcyBpcyB0aGUgbG9j YXRpb24gb2YgdGhlIHByZXZpb3VzIGRlZmluaXRpb24KfCAgIDE3NiB8ICNk ZWZpbmUgX19fREVGSU5FX1hFTl9HVUVTVF9IQU5ETEUobmFtZSwgdHlwZSkg ICAgICAgICAgICAgICAgICBcCnwgICAgICAgfAp8IEluIGZpbGUgaW5jbHVk ZWQgZnJvbSBta19kc2R0LmM6MjE6CnwgL2hvbWUvZG9ja2VyLWJ1aWxkL2J1 aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94 ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0 L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMvaW5jbHVkZS94ZW4vYXJjaC14 ODYveGVuLmg6NTM6IGVycm9yOiAiX19YRU5fR1VFU1RfSEFORExFIiByZWRl ZmluZWQgWy1XZXJyb3JdCnwgICAgNTMgfCAjZGVmaW5lIF9fWEVOX0dVRVNU X0hBTkRMRShuYW1lKSAgICAgICAgX19ndWVzdF9oYW5kbGVfICMjIG5hbWUK fCAgICAgICB8CnwgSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC9ob21lL2RvY2tl ci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBv a3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0 OTIyLXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUv eGVuL2FyY2gteDg2Ly4uL3hlbi5oOjM1LAp8ICAgICAgICAgICAgICAgICAg ZnJvbSAvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAv d29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJs ZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMvbGliYWNwaS8uLi8u Li90b29scy9pbmNsdWRlL3hlbi9hcmNoLXg4Ni94ZW4uaDoyNywKfCAgICAg ICAgICAgICAgICAgIGZyb20gbWtfZHNkdC5jOjIxOgp8IC9ob21lL2RvY2tl ci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBv a3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0 OTIyLXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUv eGVuL2FyY2gteDg2Ly4uL2FyY2gtYXJtLmg6MTkzOiBub3RlOiB0aGlzIGlz IHRoZSBsb2NhdGlvbiBvZiB0aGUgcHJldmlvdXMgZGVmaW5pdGlvbgp8ICAg MTkzIHwgI2RlZmluZSBfX1hFTl9HVUVTVF9IQU5ETEUobmFtZSkgICAgICAg IF9fZ3Vlc3RfaGFuZGxlXzY0XyAjIyBuYW1lCnwgICAgICAgfAp8IEluIGZp bGUgaW5jbHVkZWQgZnJvbSBta19kc2R0LmM6MjE6CnwgL2hvbWUvZG9ja2Vy LWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9r eS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5 MjItcjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMvaW5jbHVkZS94 ZW4vYXJjaC14ODYveGVuLmg6NTU6IGVycm9yOiAiWEVOX0dVRVNUX0hBTkRM RV9QQVJBTSIgcmVkZWZpbmVkIFstV2Vycm9yXQp8ICAgIDU1IHwgI2RlZmlu ZSBYRU5fR1VFU1RfSEFORExFX1BBUkFNKG5hbWUpICAgIFhFTl9HVUVTVF9I QU5ETEUobmFtZSkKfCAgICAgICB8CnwgSW4gZmlsZSBpbmNsdWRlZCBmcm9t IC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3Jr L2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVU T0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rv b2xzL2luY2x1ZGUveGVuL2FyY2gteDg2Ly4uL3hlbi5oOjM1LAp8ICAgICAg ICAgICAgICAgICAgZnJvbSAvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVt dXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29s cy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMv bGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9hcmNoLXg4Ni94ZW4u aDoyNywKfCAgICAgICAgICAgICAgICAgIGZyb20gbWtfZHNkdC5jOjIxOgp8 IC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3Jr L2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVU T0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rv b2xzL2luY2x1ZGUveGVuL2FyY2gteDg2Ly4uL2FyY2gtYXJtLmg6MTk1OiBu b3RlOiB0aGlzIGlzIHRoZSBsb2NhdGlvbiBvZiB0aGUgcHJldmlvdXMgZGVm aW5pdGlvbgp8ICAgMTk1IHwgI2RlZmluZSBYRU5fR1VFU1RfSEFORExFX1BB UkFNKG5hbWUpICAgIF9fZ3Vlc3RfaGFuZGxlXyAjIyBuYW1lCnwgICAgICAg fAp8IEluIGZpbGUgaW5jbHVkZWQgZnJvbSBta19kc2R0LmM6MjE6CnwgL2hv bWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29y ZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5D K2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMv aW5jbHVkZS94ZW4vYXJjaC14ODYveGVuLmg6NTY6IGVycm9yOiAic2V0X3hl bl9ndWVzdF9oYW5kbGVfcmF3IiByZWRlZmluZWQgWy1XZXJyb3JdCnwgICAg NTYgfCAjZGVmaW5lIHNldF94ZW5fZ3Vlc3RfaGFuZGxlX3JhdyhobmQsIHZh bCkgIGRvIHsgKGhuZCkucCA9IHZhbDsgfSB3aGlsZSAoMCkKfCAgICAgICB8 CnwgSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC9ob21lL2RvY2tlci1idWlsZC9i dWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgv eGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dp dC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVuL2FyY2gt eDg2Ly4uL3hlbi5oOjM1LAp8ICAgICAgICAgICAgICAgICAgZnJvbSAvaG9t ZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3Jl Mi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMr ZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMvbGliYWNwaS8uLi8uLi90b29scy9p bmNsdWRlL3hlbi9hcmNoLXg4Ni94ZW4uaDoyNywKfCAgICAgICAgICAgICAg ICAgIGZyb20gbWtfZHNkdC5jOjIxOgp8IC9ob21lL2RvY2tlci1idWlsZC9i dWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgv eGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dp dC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVuL2FyY2gt eDg2Ly4uL2FyY2gtYXJtLmg6MTk2OiBub3RlOiB0aGlzIGlzIHRoZSBsb2Nh dGlvbiBvZiB0aGUgcHJldmlvdXMgZGVmaW5pdGlvbgp8ICAgMTk2IHwgI2Rl ZmluZSBzZXRfeGVuX2d1ZXN0X2hhbmRsZV9yYXcoaG5kLCB2YWwpICAgICAg ICAgICAgICAgICAgXAp8ICAgICAgIHwKfCBJbiBmaWxlIGluY2x1ZGVkIGZy b20gbWtfZHNkdC5jOjIxOgp8IC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9x ZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRv b2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29s cy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVuL2FyY2gteDg2L3hl bi5oOjc3OiBlcnJvcjogIlBSSV94ZW5fcGZuIiByZWRlZmluZWQgWy1XZXJy b3JdCnwgICAgNzcgfCAjZGVmaW5lIFBSSV94ZW5fcGZuICJseCIKfCAgICAg ICB8CnwgSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC9ob21lL2RvY2tlci1idWls ZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGlu dXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIw L2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVuL2Fy Y2gteDg2Ly4uL3hlbi5oOjM1LAp8ICAgICAgICAgICAgICAgICAgZnJvbSAv aG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9j b3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9J TkMrZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMvbGliYWNwaS8uLi8uLi90b29s cy9pbmNsdWRlL3hlbi9hcmNoLXg4Ni94ZW4uaDoyNywKfCAgICAgICAgICAg ICAgICAgIGZyb20gbWtfZHNkdC5jOjIxOgp8IC9ob21lL2RvY2tlci1idWls ZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGlu dXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIw L2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVuL2Fy Y2gteDg2Ly4uL2FyY2gtYXJtLmg6MjA1OiBub3RlOiB0aGlzIGlzIHRoZSBs b2NhdGlvbiBvZiB0aGUgcHJldmlvdXMgZGVmaW5pdGlvbgp8ICAgMjA1IHwg I2RlZmluZSBQUklfeGVuX3BmbiBQUkl4NjQKfCAgICAgICB8CnwgSW4gZmls ZSBpbmNsdWRlZCBmcm9tIG1rX2RzZHQuYzoyMToKfCAvaG9tZS9kb2NrZXIt YnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5 LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDky Mi1yMC9naXQvdG9vbHMvbGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hl bi9hcmNoLXg4Ni94ZW4uaDo3ODogZXJyb3I6ICJQUkl1X3hlbl9wZm4iIHJl ZGVmaW5lZCBbLVdlcnJvcl0KfCAgICA3OCB8ICNkZWZpbmUgUFJJdV94ZW5f cGZuICJsdSIKfCAgICAgICB8CnwgSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC9o b21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2Nv cmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lO QytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xz L2luY2x1ZGUveGVuL2FyY2gteDg2Ly4uL3hlbi5oOjM1LAp8ICAgICAgICAg ICAgICAgICAgZnJvbSAvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4 Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80 LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMvbGli YWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9hcmNoLXg4Ni94ZW4uaDoy NywKfCAgICAgICAgICAgICAgICAgIGZyb20gbWtfZHNkdC5jOjIxOgp8IC9o b21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2Nv cmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lO QytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xz L2luY2x1ZGUveGVuL2FyY2gteDg2Ly4uL2FyY2gtYXJtLmg6MjA2OiBub3Rl OiB0aGlzIGlzIHRoZSBsb2NhdGlvbiBvZiB0aGUgcHJldmlvdXMgZGVmaW5p dGlvbgp8ICAgMjA2IHwgI2RlZmluZSBQUkl1X3hlbl9wZm4gUFJJdTY0Cnwg ICAgICAgfAp8IEluIGZpbGUgaW5jbHVkZWQgZnJvbSBta19kc2R0LmM6MjE6 CnwgL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dv cmsvY29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVB VVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4vLi4v dG9vbHMvaW5jbHVkZS94ZW4vYXJjaC14ODYveGVuLmg6MTE3OiBlcnJvcjog IlhFTl9MRUdBQ1lfTUFYX1ZDUFVTIiByZWRlZmluZWQgWy1XZXJyb3JdCnwg ICAxMTcgfCAjZGVmaW5lIFhFTl9MRUdBQ1lfTUFYX1ZDUFVTIDMyCnwgICAg ICAgfAp8IEluIGZpbGUgaW5jbHVkZWQgZnJvbSAvaG9tZS9kb2NrZXItYnVp bGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxp bnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1y MC9naXQvdG9vbHMvbGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9h cmNoLXg4Ni8uLi94ZW4uaDozNSwKfCAgICAgICAgICAgICAgICAgIGZyb20g L2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsv Y29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRP SU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9v bHMvaW5jbHVkZS94ZW4vYXJjaC14ODYveGVuLmg6MjcsCnwgICAgICAgICAg ICAgICAgICBmcm9tIG1rX2RzZHQuYzoyMToKfCAvaG9tZS9kb2NrZXItYnVp bGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxp bnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1y MC9naXQvdG9vbHMvbGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9h cmNoLXg4Ni8uLi9hcmNoLWFybS5oOjIxMjogbm90ZTogdGhpcyBpcyB0aGUg bG9jYXRpb24gb2YgdGhlIHByZXZpb3VzIGRlZmluaXRpb24KfCAgIDIxMiB8 ICNkZWZpbmUgWEVOX0xFR0FDWV9NQVhfVkNQVVMgMQp8ICAgICAgIHwKfCBJ biBmaWxlIGluY2x1ZGVkIGZyb20gbWtfZHNkdC5jOjIxOgp8IC9ob21lL2Rv Y2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0 LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1 NDQ0OTIyLXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1 ZGUveGVuL2FyY2gteDg2L3hlbi5oOjEyMjogZXJyb3I6ICJQUklfeGVuX3Vs b25nIiByZWRlZmluZWQgWy1XZXJyb3JdCnwgICAxMjIgfCAjZGVmaW5lIFBS SV94ZW5fdWxvbmcgImx4Igp8ICAgICAgIHwKfCBJbiBmaWxlIGluY2x1ZGVk IGZyb20gL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1w L3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFi bGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4v Li4vdG9vbHMvaW5jbHVkZS94ZW4vYXJjaC14ODYvLi4veGVuLmg6MzUsCnwg ICAgICAgICAgICAgICAgICBmcm9tIC9ob21lL2RvY2tlci1idWlsZC9idWls ZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVu LXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90 b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVuL2FyY2gteDg2 L3hlbi5oOjI3LAp8ICAgICAgICAgICAgICAgICAgZnJvbSBta19kc2R0LmM6 MjE6CnwgL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1w L3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFi bGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4v Li4vdG9vbHMvaW5jbHVkZS94ZW4vYXJjaC14ODYvLi4vYXJjaC1hcm0uaDoy MTU6IG5vdGU6IHRoaXMgaXMgdGhlIGxvY2F0aW9uIG9mIHRoZSBwcmV2aW91 cyBkZWZpbml0aW9uCnwgICAyMTUgfCAjZGVmaW5lIFBSSV94ZW5fdWxvbmcg UFJJeDY0CnwgICAgICAgfAp8IEluIGZpbGUgaW5jbHVkZWQgZnJvbSBta19k c2R0LmM6MjE6CnwgL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYt NjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4x NitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYmFj cGkvLi4vLi4vdG9vbHMvaW5jbHVkZS94ZW4vYXJjaC14ODYveGVuLmg6MTc5 Ojg6IGVycm9yOiByZWRlZmluaXRpb24gb2Yg4oCYc3RydWN0IHZjcHVfZ3Vl c3RfY29udGV4dOKAmQp8ICAgMTc5IHwgc3RydWN0IHZjcHVfZ3Vlc3RfY29u dGV4dCB7CnwgICAgICAgfCAgICAgICAgXn5+fn5+fn5+fn5+fn5+fn5+Cnwg SW4gZmlsZSBpbmNsdWRlZCBmcm9tIC9ob21lL2RvY2tlci1idWlsZC9idWls ZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVu LXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90 b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVuL2FyY2gteDg2 Ly4uL3hlbi5oOjM1LAp8ICAgICAgICAgICAgICAgICAgZnJvbSAvaG9tZS9k b2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02 NC1wb2t5LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2 NTQ0NDkyMi1yMC9naXQvdG9vbHMvbGliYWNwaS8uLi8uLi90b29scy9pbmNs dWRlL3hlbi9hcmNoLXg4Ni94ZW4uaDoyNywKfCAgICAgICAgICAgICAgICAg IGZyb20gbWtfZHNkdC5jOjIxOgp8IC9ob21lL2RvY2tlci1idWlsZC9idWls ZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVu LXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90 b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVuL2FyY2gteDg2 Ly4uL2FyY2gtYXJtLmg6MjkzOjg6IG5vdGU6IG9yaWdpbmFsbHkgZGVmaW5l ZCBoZXJlCnwgICAyOTMgfCBzdHJ1Y3QgdmNwdV9ndWVzdF9jb250ZXh0IHsK fCAgICAgICB8ICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn4KfCBJbiBmaWxl IGluY2x1ZGVkIGZyb20gbWtfZHNkdC5jOjIxOgp8IC9ob21lL2RvY2tlci1i dWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3kt bGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIy LXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVu L2FyY2gteDg2L3hlbi5oOjE5MjogZXJyb3I6ICJfVkdDRl9vbmxpbmUiIHJl ZGVmaW5lZCBbLVdlcnJvcl0KfCAgIDE5MiB8ICNkZWZpbmUgX1ZHQ0Zfb25s aW5lICAgICAgICAgICAgICAgICAgIDUKfCAgICAgICB8CnwgSW4gZmlsZSBp bmNsdWRlZCBmcm9tIC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2 LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQu MTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJh Y3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVuL2FyY2gteDg2Ly4uL3hlbi5o OjM1LAp8ICAgICAgICAgICAgICAgICAgZnJvbSAvaG9tZS9kb2NrZXItYnVp bGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxp bnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1y MC9naXQvdG9vbHMvbGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9h cmNoLXg4Ni94ZW4uaDoyNywKfCAgICAgICAgICAgICAgICAgIGZyb20gbWtf ZHNkdC5jOjIxOgp8IC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2 LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQu MTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJh Y3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVuL2FyY2gteDg2Ly4uL2FyY2gt YXJtLmg6Mjk0OiBub3RlOiB0aGlzIGlzIHRoZSBsb2NhdGlvbiBvZiB0aGUg cHJldmlvdXMgZGVmaW5pdGlvbgp8ICAgMjk0IHwgI2RlZmluZSBfVkdDRl9v bmxpbmUgICAgICAgICAgICAgICAgICAgMAp8ICAgICAgIHwKfCBJbiBmaWxl IGluY2x1ZGVkIGZyb20gbWtfZHNkdC5jOjIxOgp8IC9ob21lL2RvY2tlci1i dWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3kt bGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIy LXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVu L2FyY2gteDg2L3hlbi5oOjE5NToyNjogZXJyb3I6IGZpZWxkIOKAmHVzZXJf cmVnc+KAmSBoYXMgaW5jb21wbGV0ZSB0eXBlCnwgICAxOTUgfCAgICAgc3Ry dWN0IGNwdV91c2VyX3JlZ3MgdXNlcl9yZWdzOyAgICAgICAgIC8qIFVzZXIt bGV2ZWwgQ1BVIHJlZ2lzdGVycyAgICAgKi8KfCAgICAgICB8ICAgICAgICAg ICAgICAgICAgICAgICAgICBefn5+fn5+fn4KfCAvaG9tZS9kb2NrZXItYnVp bGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxp bnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1y MC9naXQvdG9vbHMvbGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9h cmNoLXg4Ni94ZW4uaDoyMzE6MzU6IGVycm9yOiBjb25mbGljdGluZyB0eXBl cyBmb3Ig4oCYdmNwdV9ndWVzdF9jb250ZXh0X3TigJk7IGhhdmUg4oCYc3Ry dWN0IHZjcHVfZ3Vlc3RfY29udGV4dOKAmQp8ICAgMjMxIHwgdHlwZWRlZiBz dHJ1Y3QgdmNwdV9ndWVzdF9jb250ZXh0IHZjcHVfZ3Vlc3RfY29udGV4dF90 Owp8ICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IF5+fn5+fn5+fn5+fn5+fn5+fn5+CnwgSW4gZmlsZSBpbmNsdWRlZCBmcm9t IC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3Jr L2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVU T0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rv b2xzL2luY2x1ZGUveGVuL2FyY2gteDg2Ly4uL3hlbi5oOjM1LAp8ICAgICAg ICAgICAgICAgICAgZnJvbSAvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVt dXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29s cy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMv bGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9hcmNoLXg4Ni94ZW4u aDoyNywKfCAgICAgICAgICAgICAgICAgIGZyb20gbWtfZHNkdC5jOjIxOgp8 IC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3Jr L2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVU T0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rv b2xzL2luY2x1ZGUveGVuL2FyY2gteDg2Ly4uL2FyY2gtYXJtLmg6MzAzOjM1 OiBub3RlOiBwcmV2aW91cyBkZWNsYXJhdGlvbiBvZiDigJh2Y3B1X2d1ZXN0 X2NvbnRleHRfdOKAmSB3aXRoIHR5cGUg4oCYdmNwdV9ndWVzdF9jb250ZXh0 X3TigJkge2FrYSDigJhzdHJ1Y3QgdmNwdV9ndWVzdF9jb250ZXh04oCZfQp8 ICAgMzAzIHwgdHlwZWRlZiBzdHJ1Y3QgdmNwdV9ndWVzdF9jb250ZXh0IHZj cHVfZ3Vlc3RfY29udGV4dF90Owp8ICAgICAgIHwgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+fn5+CnwgSW4g ZmlsZSBpbmNsdWRlZCBmcm9tIG1rX2RzZHQuYzoyMToKfCAvaG9tZS9kb2Nr ZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1w b2t5LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0 NDkyMi1yMC9naXQvdG9vbHMvbGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRl L3hlbi9hcmNoLXg4Ni94ZW4uaDozNTozMzogZXJyb3I6IGNvbmZsaWN0aW5n IHR5cGVzIGZvciDigJhfX2d1ZXN0X2hhbmRsZV92Y3B1X2d1ZXN0X2NvbnRl eHRfdOKAmTsgaGF2ZSDigJhzdHJ1Y3QgPGFub255bW91cz7igJkKfCAgICAz NSB8ICAgICB0eXBlZGVmIHN0cnVjdCB7IHR5cGUgKnA7IH0gX19ndWVzdF9o YW5kbGVfICMjIG5hbWUKfCAgICAgICB8ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgXn5+fn5+fn5+fn5+fn5+CnwgL2hvbWUvZG9ja2VyLWJ1 aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1s aW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjIt cjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMvaW5jbHVkZS94ZW4v YXJjaC14ODYveGVuLmg6NTA6NTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1h Y3JvIOKAmF9fX0RFRklORV9YRU5fR1VFU1RfSEFORExF4oCZCnwgICAgNTAg fCAgICAgX19fREVGSU5FX1hFTl9HVUVTVF9IQU5ETEUobmFtZSwgdHlwZSk7 ICAgXAp8ICAgICAgIHwgICAgIF5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ CnwgL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dv cmsvY29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVB VVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4vLi4v dG9vbHMvaW5jbHVkZS94ZW4vYXJjaC14ODYveGVuLmg6NTI6NDE6IG5vdGU6 IGluIGV4cGFuc2lvbiBvZiBtYWNybyDigJhfX0RFRklORV9YRU5fR1VFU1Rf SEFORExF4oCZCnwgICAgNTIgfCAjZGVmaW5lIERFRklORV9YRU5fR1VFU1Rf SEFORExFKG5hbWUpICAgX19ERUZJTkVfWEVOX0dVRVNUX0hBTkRMRShuYW1l LCBuYW1lKQp8ICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn4KfCAvaG9t ZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3Jl Mi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMr ZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMvbGliYWNwaS8uLi8uLi90b29scy9p bmNsdWRlL3hlbi9hcmNoLXg4Ni94ZW4uaDoyMzI6MTogbm90ZTogaW4gZXhw YW5zaW9uIG9mIG1hY3JvIOKAmERFRklORV9YRU5fR1VFU1RfSEFORExF4oCZ CnwgICAyMzIgfCBERUZJTkVfWEVOX0dVRVNUX0hBTkRMRSh2Y3B1X2d1ZXN0 X2NvbnRleHRfdCk7CnwgICAgICAgfCBefn5+fn5+fn5+fn5+fn5+fn5+fn5+ fgp8IEluIGZpbGUgaW5jbHVkZWQgZnJvbSAvaG9tZS9kb2NrZXItYnVpbGQv YnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4 L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9n aXQvdG9vbHMvbGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9hcmNo LXg4Ni8uLi94ZW4uaDozNSwKfCAgICAgICAgICAgICAgICAgIGZyb20gL2hv bWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29y ZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5D K2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMv aW5jbHVkZS94ZW4vYXJjaC14ODYveGVuLmg6MjcsCnwgICAgICAgICAgICAg ICAgICBmcm9tIG1rX2RzZHQuYzoyMToKfCAvaG9tZS9kb2NrZXItYnVpbGQv YnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4 L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9n aXQvdG9vbHMvbGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9hcmNo LXg4Ni8uLi9hcmNoLWFybS5oOjE3ODo5OiBub3RlOiBwcmV2aW91cyBkZWNs YXJhdGlvbiBvZiDigJhfX2d1ZXN0X2hhbmRsZV92Y3B1X2d1ZXN0X2NvbnRl eHRfdOKAmSB3aXRoIHR5cGUg4oCYX19ndWVzdF9oYW5kbGVfdmNwdV9ndWVz dF9jb250ZXh0X3TigJkKfCAgIDE3OCB8ICAgICAgICAgX19ndWVzdF9oYW5k bGVfICMjIG5hbWU7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBc CnwgICAgICAgfCAgICAgICAgIF5+fn5+fn5+fn5+fn5+fgp8IC9ob21lL2Rv Y2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0 LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1 NDQ0OTIyLXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1 ZGUveGVuL2FyY2gteDg2Ly4uL2FyY2gtYXJtLmg6MTkwOjU6IG5vdGU6IGlu IGV4cGFuc2lvbiBvZiBtYWNybyDigJhfX19ERUZJTkVfWEVOX0dVRVNUX0hB TkRMReKAmQp8ICAgMTkwIHwgICAgIF9fX0RFRklORV9YRU5fR1VFU1RfSEFO RExFKG5hbWUsIHR5cGUpOyAgIFwKfCAgICAgICB8ICAgICBefn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fgp8IC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9x ZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRv b2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29s cy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVuL2FyY2gteDg2Ly4u L2FyY2gtYXJtLmg6MTkyOjQxOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFj cm8g4oCYX19ERUZJTkVfWEVOX0dVRVNUX0hBTkRMReKAmQp8ICAgMTkyIHwg I2RlZmluZSBERUZJTkVfWEVOX0dVRVNUX0hBTkRMRShuYW1lKSAgIF9fREVG SU5FX1hFTl9HVUVTVF9IQU5ETEUobmFtZSwgbmFtZSkKfCAgICAgICB8ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+CnwgL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxk L3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4t dG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rv b2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMvaW5jbHVkZS94ZW4vYXJjaC14ODYv Li4vYXJjaC1hcm0uaDozMDQ6MTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1h Y3JvIOKAmERFRklORV9YRU5fR1VFU1RfSEFORExF4oCZCnwgICAzMDQgfCBE RUZJTkVfWEVOX0dVRVNUX0hBTkRMRSh2Y3B1X2d1ZXN0X2NvbnRleHRfdCk7 CnwgICAgICAgfCBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fgp8IEluIGZpbGUg aW5jbHVkZWQgZnJvbSBta19kc2R0LmM6MjE6CnwgL2hvbWUvZG9ja2VyLWJ1 aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1s aW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjIt cjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMvaW5jbHVkZS94ZW4v YXJjaC14ODYveGVuLmg6MzU6MzM6IGVycm9yOiBjb25mbGljdGluZyB0eXBl cyBmb3Ig4oCYX19ndWVzdF9oYW5kbGVfY29uc3RfdmNwdV9ndWVzdF9jb250 ZXh0X3TigJk7IGhhdmUg4oCYc3RydWN0IDxhbm9ueW1vdXM+4oCZCnwgICAg MzUgfCAgICAgdHlwZWRlZiBzdHJ1Y3QgeyB0eXBlICpwOyB9IF9fZ3Vlc3Rf aGFuZGxlXyAjIyBuYW1lCnwgICAgICAgfCAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+fgp8IC9ob21lL2RvY2tlci1i dWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3kt bGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIy LXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVu L2FyY2gteDg2L3hlbi5oOjUxOjU6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBt YWNybyDigJhfX19ERUZJTkVfWEVOX0dVRVNUX0hBTkRMReKAmQp8ICAgIDUx IHwgICAgIF9fX0RFRklORV9YRU5fR1VFU1RfSEFORExFKGNvbnN0XyMjbmFt ZSwgY29uc3QgdHlwZSkKfCAgICAgICB8ICAgICBefn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fgp8IC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2 LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQu MTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJh Y3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVuL2FyY2gteDg2L3hlbi5oOjUy OjQxOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCYX19ERUZJTkVf WEVOX0dVRVNUX0hBTkRMReKAmQp8ICAgIDUyIHwgI2RlZmluZSBERUZJTkVf WEVOX0dVRVNUX0hBTkRMRShuYW1lKSAgIF9fREVGSU5FX1hFTl9HVUVTVF9I QU5ETEUobmFtZSwgbmFtZSkKfCAgICAgICB8ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+CnwgL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1w L3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFi bGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4v Li4vdG9vbHMvaW5jbHVkZS94ZW4vYXJjaC14ODYveGVuLmg6MjMyOjE6IG5v dGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyDigJhERUZJTkVfWEVOX0dVRVNU X0hBTkRMReKAmQp8ICAgMjMyIHwgREVGSU5FX1hFTl9HVUVTVF9IQU5ETEUo dmNwdV9ndWVzdF9jb250ZXh0X3QpOwp8ICAgICAgIHwgXn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn4KfCBJbiBmaWxlIGluY2x1ZGVkIGZyb20gL2hvbWUvZG9j a2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQt cG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0 NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMvaW5jbHVk ZS94ZW4vYXJjaC14ODYvLi4veGVuLmg6MzUsCnwgICAgICAgICAgICAgICAg ICBmcm9tIC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3Rt cC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3Rh YmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJhY3BpLy4u Ly4uL3Rvb2xzL2luY2x1ZGUveGVuL2FyY2gteDg2L3hlbi5oOjI3LAp8ICAg ICAgICAgICAgICAgICAgZnJvbSBta19kc2R0LmM6MjE6CnwgL2hvbWUvZG9j a2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQt cG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0 NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMvaW5jbHVk ZS94ZW4vYXJjaC14ODYvLi4vYXJjaC1hcm0uaDoxNzg6OTogbm90ZTogcHJl dmlvdXMgZGVjbGFyYXRpb24gb2Yg4oCYX19ndWVzdF9oYW5kbGVfY29uc3Rf dmNwdV9ndWVzdF9jb250ZXh0X3TigJkgd2l0aCB0eXBlIOKAmF9fZ3Vlc3Rf aGFuZGxlX2NvbnN0X3ZjcHVfZ3Vlc3RfY29udGV4dF904oCZCnwgICAxNzgg fCAgICAgICAgIF9fZ3Vlc3RfaGFuZGxlXyAjIyBuYW1lOyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXAp8ICAgICAgIHwgICAgICAgICBefn5+ fn5+fn5+fn5+fn4KfCAvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4 Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80 LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMvbGli YWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9hcmNoLXg4Ni8uLi9hcmNo LWFybS5oOjE5MTo1OiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCY X19fREVGSU5FX1hFTl9HVUVTVF9IQU5ETEXigJkKfCAgIDE5MSB8ICAgICBf X19ERUZJTkVfWEVOX0dVRVNUX0hBTkRMRShjb25zdF8jI25hbWUsIGNvbnN0 IHR5cGUpCnwgICAgICAgfCAgICAgXn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn4KfCAvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAv d29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJs ZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMvbGliYWNwaS8uLi8u Li90b29scy9pbmNsdWRlL3hlbi9hcmNoLXg4Ni8uLi9hcmNoLWFybS5oOjE5 Mjo0MTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmF9fREVGSU5F X1hFTl9HVUVTVF9IQU5ETEXigJkKfCAgIDE5MiB8ICNkZWZpbmUgREVGSU5F X1hFTl9HVUVTVF9IQU5ETEUobmFtZSkgICBfX0RFRklORV9YRU5fR1VFU1Rf SEFORExFKG5hbWUsIG5hbWUpCnwgICAgICAgfCAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fgp8IC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3Rt cC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3Rh YmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJhY3BpLy4u Ly4uL3Rvb2xzL2luY2x1ZGUveGVuL2FyY2gteDg2Ly4uL2FyY2gtYXJtLmg6 MzA0OjE6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyDigJhERUZJTkVf WEVOX0dVRVNUX0hBTkRMReKAmQp8ICAgMzA0IHwgREVGSU5FX1hFTl9HVUVT VF9IQU5ETEUodmNwdV9ndWVzdF9jb250ZXh0X3QpOwp8ICAgICAgIHwgXn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn4KfCBJbiBmaWxlIGluY2x1ZGVkIGZyb20g bWtfZHNkdC5jOjIxOgp8IC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11 eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xz LzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9s aWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVuL2FyY2gteDg2L3hlbi5o OjIzNDo4OiBlcnJvcjogcmVkZWZpbml0aW9uIG9mIOKAmHN0cnVjdCBhcmNo X3NoYXJlZF9pbmZv4oCZCnwgICAyMzQgfCBzdHJ1Y3QgYXJjaF9zaGFyZWRf aW5mbyB7CnwgICAgICAgfCAgICAgICAgXn5+fn5+fn5+fn5+fn5+fgp8IElu IGZpbGUgaW5jbHVkZWQgZnJvbSAvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQv cWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10 b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQvdG9v bHMvbGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9hcmNoLXg4Ni8u Li94ZW4uaDozNSwKfCAgICAgICAgICAgICAgICAgIGZyb20gL2hvbWUvZG9j a2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQt cG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0 NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMvaW5jbHVk ZS94ZW4vYXJjaC14ODYveGVuLmg6MjcsCnwgICAgICAgICAgICAgICAgICBm cm9tIG1rX2RzZHQuYzoyMToKfCAvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQv cWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10 b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQvdG9v bHMvbGliYWNwaS8uLi8uLi90b29scy9pbmNsdWRlL3hlbi9hcmNoLXg4Ni8u Li9hcmNoLWFybS5oOjM0NTo4OiBub3RlOiBvcmlnaW5hbGx5IGRlZmluZWQg aGVyZQp8ICAgMzQ1IHwgc3RydWN0IGFyY2hfc2hhcmVkX2luZm8gewp8ICAg ICAgIHwgICAgICAgIF5+fn5+fn5+fn5+fn5+fn4KfCBJbiBmaWxlIGluY2x1 ZGVkIGZyb20gbWtfZHNkdC5jOjIxOgp8IC9ob21lL2RvY2tlci1idWlsZC9i dWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgv eGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dp dC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2luY2x1ZGUveGVuL2FyY2gt eDg2L3hlbi5oOjI3NTozMzogZXJyb3I6IGNvbmZsaWN0aW5nIHR5cGVzIGZv ciDigJhhcmNoX3NoYXJlZF9pbmZvX3TigJk7IGhhdmUg4oCYc3RydWN0IGFy Y2hfc2hhcmVkX2luZm/igJkKfCAgIDI3NSB8IHR5cGVkZWYgc3RydWN0IGFy Y2hfc2hhcmVkX2luZm8gYXJjaF9zaGFyZWRfaW5mb190Owp8ICAgICAgIHwg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+ fn5+fn4KfCBJbiBmaWxlIGluY2x1ZGVkIGZyb20gL2hvbWUvZG9ja2VyLWJ1 aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1s aW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjIt cjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMvaW5jbHVkZS94ZW4v YXJjaC14ODYvLi4veGVuLmg6MzUsCnwgICAgICAgICAgICAgICAgICBmcm9t IC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3Jr L2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVU T0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rv b2xzL2luY2x1ZGUveGVuL2FyY2gteDg2L3hlbi5oOjI3LAp8ICAgICAgICAg ICAgICAgICAgZnJvbSBta19kc2R0LmM6MjE6CnwgL2hvbWUvZG9ja2VyLWJ1 aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1s aW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjIt cjAvZ2l0L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMvaW5jbHVkZS94ZW4v YXJjaC14ODYvLi4vYXJjaC1hcm0uaDozNDc6MzM6IG5vdGU6IHByZXZpb3Vz IGRlY2xhcmF0aW9uIG9mIOKAmGFyY2hfc2hhcmVkX2luZm9fdOKAmSB3aXRo IHR5cGUg4oCYYXJjaF9zaGFyZWRfaW5mb1904oCZIHtha2Eg4oCYc3RydWN0 IGFyY2hfc2hhcmVkX2luZm/igJl9CnwgICAzNDcgfCB0eXBlZGVmIHN0cnVj dCBhcmNoX3NoYXJlZF9pbmZvIGFyY2hfc2hhcmVkX2luZm9fdDsKfCAgICAg ICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+ fn5+fn5+fn5+CnwgSW4gZmlsZSBpbmNsdWRlZCBmcm9tIG1rX2RzZHQuYzoy MToKfCAvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAv d29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJs ZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMvbGliYWNwaS8uLi8u Li90b29scy9pbmNsdWRlL3hlbi9hcmNoLXg4Ni94ZW4uaDoyODI6ODogZXJy b3I6IHJlZGVmaW5pdGlvbiBvZiDigJhzdHJ1Y3QgeGVuX2FyY2hfZG9tYWlu Y29uZmln4oCZCnwgICAyODIgfCBzdHJ1Y3QgeGVuX2FyY2hfZG9tYWluY29u ZmlnIHsKfCAgICAgICB8ICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn4K fCBJbiBmaWxlIGluY2x1ZGVkIGZyb20gL2hvbWUvZG9ja2VyLWJ1aWxkL2J1 aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94 ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0 L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMvaW5jbHVkZS94ZW4vYXJjaC14 ODYvLi4veGVuLmg6MzUsCnwgICAgICAgICAgICAgICAgICBmcm9tIC9ob21l L2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUy LTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytm MjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJhY3BpLy4uLy4uL3Rvb2xzL2lu Y2x1ZGUveGVuL2FyY2gteDg2L3hlbi5oOjI3LAp8ICAgICAgICAgICAgICAg ICAgZnJvbSBta19kc2R0LmM6MjE6CnwgL2hvbWUvZG9ja2VyLWJ1aWxkL2J1 aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94 ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0 L3Rvb2xzL2xpYmFjcGkvLi4vLi4vdG9vbHMvaW5jbHVkZS94ZW4vYXJjaC14 ODYvLi4vYXJjaC1hcm0uaDozMTc6ODogbm90ZTogb3JpZ2luYWxseSBkZWZp bmVkIGhlcmUKfCAgIDMxNyB8IHN0cnVjdCB4ZW5fYXJjaF9kb21haW5jb25m aWcgewp8ICAgICAgIHwgICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+fn5+fgp8 IGNjMTogYWxsIHdhcm5pbmdzIGJlaW5nIHRyZWF0ZWQgYXMgZXJyb3JzCnwg bWFrZVs3XTogKioqIFtNYWtlZmlsZTo1MDogL2hvbWUvZG9ja2VyLWJ1aWxk L2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51 eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAv Z2l0L3Rvb2xzL2xpYnMvbGlnaHQvbWtfZHNkdF0gRXJyb3IgMQp8IG1ha2Vb N106IExlYXZpbmcgZGlyZWN0b3J5ICcvaG9tZS9kb2NrZXItYnVpbGQvYnVp bGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hl bi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQv dG9vbHMvbGliYWNwaScKfCBtYWtlWzZdOiAqKiogW01ha2VmaWxlOjQxOiBh Y3BpXSBFcnJvciAyCnwgbWFrZVs2XTogKioqIFdhaXRpbmcgZm9yIHVuZmlu aXNoZWQgam9icy4uLi4KfCBQYXJzaW5nIGxpYnhsX3R5cGVzLmlkbAp8IG12 IC1mIF9saWJ4bC5hcGktZm9yLWNoZWNrLm5ldyBfbGlieGwuYXBpLWZvci1j aGVjawp8IG12IHRlc3RpZGwuYy5uZXcgdGVzdGlkbC5jCnwgbWFrZVs2XTog TGVhdmluZyBkaXJlY3RvcnkgJy9ob21lL2RvY2tlci1idWlsZC9idWlsZC9x ZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRv b2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29s cy9saWJzL2xpZ2h0Jwp8IG1ha2VbNV06ICoqKiBbL2hvbWUvZG9ja2VyLWJ1 aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1s aW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjIt cjAvZ2l0L3Rvb2xzL2xpYnMvLi4vLi4vdG9vbHMvUnVsZXMubWs6MTY2OiBz dWJkaXItaW5zdGFsbC1saWdodF0gRXJyb3IgMgp8IG1ha2VbNV06IExlYXZp bmcgZGlyZWN0b3J5ICcvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4 Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80 LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMvbGli cycKfCBtYWtlWzRdOiAqKiogWy9ob21lL2RvY2tlci1idWlsZC9idWlsZC9x ZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRv b2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29s cy9saWJzLy4uLy4uL3Rvb2xzL1J1bGVzLm1rOjE2MTogc3ViZGlycy1pbnN0 YWxsXSBFcnJvciAyCnwgbWFrZVs0XTogTGVhdmluZyBkaXJlY3RvcnkgJy9o b21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2Nv cmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lO QytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJzJwp8IG1ha2VbM106ICoq KiBbL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dv cmsvY29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVB VVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzLy4uL3Rvb2xzL1J1bGVz Lm1rOjE2Njogc3ViZGlyLWluc3RhbGwtbGlic10gRXJyb3IgMgp8IG1ha2Vb M106IExlYXZpbmcgZGlyZWN0b3J5ICcvaG9tZS9kb2NrZXItYnVpbGQvYnVp bGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hl bi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQv dG9vbHMnCnwgbWFrZVsyXTogKioqIFsvaG9tZS9kb2NrZXItYnVpbGQvYnVp bGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hl bi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQv dG9vbHMvLi4vdG9vbHMvUnVsZXMubWs6MTYxOiBzdWJkaXJzLWluc3RhbGxd IEVycm9yIDIKfCBtYWtlWzJdOiBMZWF2aW5nIGRpcmVjdG9yeSAnL2hvbWUv ZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTIt NjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2Yy NjU0NDQ5MjItcjAvZ2l0L3Rvb2xzJwp8IG1ha2VbMV06ICoqKiBbTWFrZWZp bGU6NjY6IGluc3RhbGxdIEVycm9yIDIKfCBtYWtlWzFdOiBMZWF2aW5nIGRp cmVjdG9yeSAnL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQv dG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitz dGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzJwp8IG1ha2U6 ICoqKiBbTWFrZWZpbGU6MTQwOiBpbnN0YWxsLXRvb2xzXSBFcnJvciAyCnwg RVJST1I6IG9lX3J1bm1ha2UgZmFpbGVkCnwgV0FSTklORzogL2hvbWUvZG9j a2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQt cG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0 NDQ5MjItcjAvdGVtcC9ydW4uZG9fY29tcGlsZS4yNTgxODk0OjIwMiBleGl0 IDEgZnJvbSAnZXhpdCAxJwp8IFdBUk5JTkc6IEJhY2t0cmFjZSAoQkIgZ2Vu ZXJhdGVkIHNjcmlwdCk6CnwgICAgICAgIzE6IGJiZmF0YWxfbG9nLCAvaG9t ZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3Jl Mi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMr ZjI2NTQ0NDkyMi1yMC90ZW1wL3J1bi5kb19jb21waWxlLjI1ODE4OTQsIGxp bmUgMjAyCnwgICAgICAgIzI6IGRpZSwgL2hvbWUvZG9ja2VyLWJ1aWxkL2J1 aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94 ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvdGVt cC9ydW4uZG9fY29tcGlsZS4yNTgxODk0LCBsaW5lIDE4Ngp8ICAgICAgICMz OiBvZV9ydW5tYWtlLCAvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4 Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80 LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC90ZW1wL3J1bi5kb19j b21waWxlLjI1ODE4OTQsIGxpbmUgMTgxCnwgICAgICAgIzQ6IGRvX2NvbXBp bGUsIC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93 b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxl QVVUT0lOQytmMjY1NDQ0OTIyLXIwL3RlbXAvcnVuLmRvX2NvbXBpbGUuMjU4 MTg5NCwgbGluZSAxNzUKfCAgICAgICAjNTogbWFpbiwgL2hvbWUvZG9ja2Vy LWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9r eS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5 MjItcjAvdGVtcC9ydW4uZG9fY29tcGlsZS4yNTgxODk0LCBsaW5lIDIxNQpO T1RFOiByZWNpcGUgeGVuLXRvb2xzLTQuMTYrc3RhYmxlQVVUT0lOQytmMjY1 NDQ0OTIyLXIwOiB0YXNrIGRvX2NvbXBpbGU6IEZhaWxlZApFUlJPUjogVGFz ayAoL2hvbWUvZG9ja2VyLWJ1aWxkL3lvY3RvLWxheWVycy9tZXRhLXZpcnR1 YWxpemF0aW9uL3JlY2lwZXMtZXh0ZW5kZWQveGVuL3hlbi10b29sc180LjE2 LmJiOmRvX2NvbXBpbGUpIGZhaWxlZCB3aXRoIGV4aXQgY29kZSAnMScKTk9U RTogcmVjaXBlIGdldHRleHQtMC4yMS1yMDogdGFzayBkb19wYWNrYWdlX3dy aXRlX3JwbTogU3VjY2VlZGVkCk5PVEU6IHJlY2lwZSB4ZW4tNC4xNitzdGFi bGVBVVRPSU5DK2YyNjU0NDQ5MjItcjA6IHRhc2sgZG9fY29tcGlsZTogU3Vj Y2VlZGVkCk5PVEU6IFRhc2tzIFN1bW1hcnk6IEF0dGVtcHRlZCAzMzk2IHRh c2tzIG9mIHdoaWNoIDAgZGlkbid0IG5lZWQgdG8gYmUgcmVydW4gYW5kIDEg ZmFpbGVkLgoKU3VtbWFyeTogMSB0YXNrIGZhaWxlZDoKICAvaG9tZS9kb2Nr ZXItYnVpbGQveW9jdG8tbGF5ZXJzL21ldGEtdmlydHVhbGl6YXRpb24vcmVj aXBlcy1leHRlbmRlZC94ZW4veGVuLXRvb2xzXzQuMTYuYmI6ZG9fY29tcGls ZQpTdW1tYXJ5OiBUaGVyZSB3YXMgMSBXQVJOSU5HIG1lc3NhZ2UuClN1bW1h cnk6IFRoZXJlIHdlcmUgMiBFUlJPUiBtZXNzYWdlcywgcmV0dXJuaW5nIGEg bm9uLXplcm8gZXhpdCBjb2RlLgojIyMjIyMjIyMjIyMgIExPR1MtRU5EICAj IyMjIyMjIyMjIyMKCjA2OjMyOjE4IHJ1biBxZW11eDg2LTY0OiBFcnJvcgoK IyMjIyMjIyMjIyMjIExPR1MtU1RBUlQgIyMjIyMjIyMjIyMjCnNwYXduIGJh c2ggLWMgcnVucWVtdSBzZXJpYWxzdGRpbyBub2dyYXBoaWMgc2xpcnAKcnVu cWVtdSAtIElORk8gLSBSdW5uaW5nIGJpdGJha2UgLWUgLi4uCmxzOiBjYW5u b3QgYWNjZXNzICcvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02 NC90bXAvZGVwbG95L2ltYWdlcy9xZW11eDg2LTY0LyoucWVtdWJvb3QuY29u Zic6IE5vIHN1Y2ggZmlsZSBvciBkaXJlY3RvcnkKcnVucWVtdSAtIEVSUk9S IC0gQ29tbWFuZCAnbHMgLXQgL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3Fl bXV4ODYtNjQvdG1wL2RlcGxveS9pbWFnZXMvcWVtdXg4Ni02NC8qLnFlbXVi b290LmNvbmYnIHJldHVybmVkIG5vbi16ZXJvIGV4aXQgc3RhdHVzIDIuCnJ1 bnFlbXUgLSBJTkZPIC0gQ2xlYW5pbmcgdXAKcnVucWVtdSAtIElORk8gLSBI b3N0IHVwdGltZTogMTIyMDExLjgxCgp0cHV0OiBObyB2YWx1ZSBmb3IgJFRF Uk0gYW5kIG5vIC1UIHNwZWNpZmllZApFUlJPUi1FT0YhCiMjIyMjIyMjIyMj IyAgTE9HUy1FTkQgICMjIyMjIyMjIyMjIwoKMDY6MzI6MjAgQnVpbGQgQ29t cGxldGUgKDIgZXJyb3JzKQpUaGUgY29tbWFuZCAnL2Jpbi9zaCAtYyAvYnVp bGQteW9jdG8uc2ggLS1kdW1wLWxvZyBxZW11eDg2LTY0JyByZXR1cm5lZCBh IG5vbi16ZXJvIGNvZGU6IDIKbWFrZTogKioqIFtNYWtlZmlsZToxOTogeW9j dG8va2lya3N0b25lLXFlbXV4ODYtNjQtYXJtNjR2OF0gRXJyb3IgMgo= --8323329-1987139687-1668809228=:1049131 Content-Type: application/octet-stream; NAME=build2.log Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: ATTACHMENT; FILENAME=build2.log LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQu MTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL3JlY2lwZS1zeXNyb290 LW5hdGl2ZT0gIC1Xbm8tZm9ybWF0LXplcm8tbGVuZ3RoIC1XbWlzc2luZy1k ZWNsYXJhdGlvbnMgLVduby1kZWNsYXJhdGlvbi1hZnRlci1zdGF0ZW1lbnQg LVdmb3JtYXQtbm9ubGl0ZXJhbCAtSS4gLXB0aHJlYWQgLVdlcnJvciAtV21p c3NpbmctcHJvdG90eXBlcyAtSS4vaW5jbHVkZSAtSS9ob21lL2RvY2tlci1i dWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3kt bGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIy LXIwL2dpdC90b29scy9saWJzL2xpZ2h0Ly4uLy4uLy4uL3Rvb2xzL2luY2x1 ZGUgIC1JL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1w L3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFi bGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYnMvbGlnaHQv Li4vLi4vLi4vdG9vbHMvaW5jbHVkZSAgLUkvaG9tZS9kb2NrZXItYnVpbGQv YnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4 L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9n aXQvdG9vbHMvbGlicy9saWdodC8uLi8uLi8uLi90b29scy9pbmNsdWRlICAt SS9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3Jr L2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVU T0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJzL2xpZ2h0Ly4uLy4u Ly4uL3Rvb2xzL2luY2x1ZGUgIC1JL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxk L3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4t dG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rv b2xzL2xpYnMvbGlnaHQvLi4vLi4vLi4vdG9vbHMvaW5jbHVkZSAtRF9fWEVO X1RPT0xTX18gIC1JL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYt NjQvdG1wL3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4x NitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYnMv bGlnaHQvLi4vLi4vLi4vdG9vbHMvaW5jbHVkZSAgLUkvaG9tZS9kb2NrZXIt YnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5 LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDky Mi1yMC9naXQvdG9vbHMvbGlicy9saWdodC8uLi8uLi8uLi90b29scy9pbmNs dWRlICAtSS9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3Rt cC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3Rh YmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy9saWJzL2xpZ2h0 Ly4uLy4uLy4uL3Rvb2xzL2luY2x1ZGUgLUkvaG9tZS9kb2NrZXItYnVpbGQv YnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4 L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9y ZWNpcGUtc3lzcm9vdC91c3IvaW5jbHVkZS9saWJubDMgLVdzaGFkb3cgLWlu Y2x1ZGUgL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1w L3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFi bGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYnMvbGlnaHQv Li4vLi4vLi4vdG9vbHMvY29uZmlnLmggIC1jIC1vIGxpYnhsX2Jvb3Rsb2Fk ZXIubyBsaWJ4bF9ib290bG9hZGVyLmMKfCBybSAtZiAvaG9tZS9kb2NrZXIt YnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5 LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDky Mi1yMC9naXQvdG9vbHMvbGlicy9saWdodC9zc2R0X3BtLmFtbCAvaG9tZS9k b2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02 NC1wb2t5LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2 NTQ0NDkyMi1yMC9naXQvdG9vbHMvbGlicy9saWdodC9zc2R0X3BtLmhleAp8 IG1ha2VbN106IExlYXZpbmcgZGlyZWN0b3J5ICcvaG9tZS9kb2NrZXItYnVp bGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxp bnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1y MC9naXQvdG9vbHMvbGliYWNwaScKfCBtYWtlWzZdOiAqKiogW01ha2VmaWxl OjQxOiBhY3BpXSBFcnJvciAyCnwgbWFrZVs2XTogKioqIFdhaXRpbmcgZm9y IHVuZmluaXNoZWQgam9icy4uLi4KfCBtYWtlWzZdOiBMZWF2aW5nIGRpcmVj dG9yeSAnL2hvbWUvZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1w L3dvcmsvY29yZTItNjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFi bGVBVVRPSU5DK2YyNjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYnMvbGlnaHQn CnwgbWFrZVs1XTogTGVhdmluZyBkaXJlY3RvcnkgJy9ob21lL2RvY2tlci1i dWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3kt bGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIy LXIwL2dpdC90b29scy9saWJzJwp8IG1ha2VbNV06ICoqKiBbL2hvbWUvZG9j a2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQt cG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0 NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYnMvLi4vLi4vdG9vbHMvUnVsZXMubWs6 MTY2OiBzdWJkaXItaW5zdGFsbC1saWdodF0gRXJyb3IgMgp8IG1ha2VbNF06 IExlYXZpbmcgZGlyZWN0b3J5ICcvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQv cWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10 b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9naXQvdG9v bHMvbGlicycKfCBtYWtlWzNdOiBMZWF2aW5nIGRpcmVjdG9yeSAnL2hvbWUv ZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTIt NjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2Yy NjU0NDQ5MjItcjAvZ2l0L3Rvb2xzJwp8IG1ha2VbNF06ICoqKiBbL2hvbWUv ZG9ja2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTIt NjQtcG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2Yy NjU0NDQ5MjItcjAvZ2l0L3Rvb2xzL2xpYnMvLi4vLi4vdG9vbHMvUnVsZXMu bWs6MTYxOiBzdWJkaXJzLWluc3RhbGxdIEVycm9yIDIKfCBtYWtlWzNdOiAq KiogWy9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93 b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxl QVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy8uLi90b29scy9SdWxl cy5tazoxNjY6IHN1YmRpci1pbnN0YWxsLWxpYnNdIEVycm9yIDIKfCBtYWtl WzJdOiAqKiogWy9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0 L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYr c3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwL2dpdC90b29scy8uLi90b29s cy9SdWxlcy5tazoxNjE6IHN1YmRpcnMtaW5zdGFsbF0gRXJyb3IgMgp8IG1h a2VbMl06IExlYXZpbmcgZGlyZWN0b3J5ICcvaG9tZS9kb2NrZXItYnVpbGQv YnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4 L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC9n aXQvdG9vbHMnCnwgbWFrZVsxXTogKioqIFtNYWtlZmlsZTo2NjogaW5zdGFs bF0gRXJyb3IgMgp8IG1ha2VbMV06IExlYXZpbmcgZGlyZWN0b3J5ICcvaG9t ZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3Jl Mi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMr ZjI2NTQ0NDkyMi1yMC9naXQvdG9vbHMnCnwgbWFrZTogKioqIFtNYWtlZmls ZToxNDA6IGluc3RhbGwtdG9vbHNdIEVycm9yIDIKfCBFUlJPUjogb2VfcnVu bWFrZSBmYWlsZWQKfCBXQVJOSU5HOiAvaG9tZS9kb2NrZXItYnVpbGQvYnVp bGQvcWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hl bi10b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC90ZW1w L3J1bi5kb19jb21waWxlLjIyNDAzODQ6MjAyIGV4aXQgMSBmcm9tICdleGl0 IDEnCnwgV0FSTklORzogQmFja3RyYWNlIChCQiBnZW5lcmF0ZWQgc2NyaXB0 KToKfCAgICAgICAjMTogYmJmYXRhbF9sb2csIC9ob21lL2RvY2tlci1idWls ZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3JrL2NvcmUyLTY0LXBva3ktbGlu dXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIw L3RlbXAvcnVuLmRvX2NvbXBpbGUuMjI0MDM4NCwgbGluZSAyMDIKfCAgICAg ICAjMjogZGllLCAvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4Ni02 NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10b29scy80LjE2 K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC90ZW1wL3J1bi5kb19jb21w aWxlLjIyNDAzODQsIGxpbmUgMTg2CnwgICAgICAgIzM6IG9lX3J1bm1ha2Us IC9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3RtcC93b3Jr L2NvcmUyLTY0LXBva3ktbGludXgveGVuLXRvb2xzLzQuMTYrc3RhYmxlQVVU T0lOQytmMjY1NDQ0OTIyLXIwL3RlbXAvcnVuLmRvX2NvbXBpbGUuMjI0MDM4 NCwgbGluZSAxODEKfCAgICAgICAjNDogZG9fY29tcGlsZSwgL2hvbWUvZG9j a2VyLWJ1aWxkL2J1aWxkL3FlbXV4ODYtNjQvdG1wL3dvcmsvY29yZTItNjQt cG9reS1saW51eC94ZW4tdG9vbHMvNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0 NDQ5MjItcjAvdGVtcC9ydW4uZG9fY29tcGlsZS4yMjQwMzg0LCBsaW5lIDE3 NQp8ICAgICAgICM1OiBtYWluLCAvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQv cWVtdXg4Ni02NC90bXAvd29yay9jb3JlMi02NC1wb2t5LWxpbnV4L3hlbi10 b29scy80LjE2K3N0YWJsZUFVVE9JTkMrZjI2NTQ0NDkyMi1yMC90ZW1wL3J1 bi5kb19jb21waWxlLjIyNDAzODQsIGxpbmUgMjE1Ck5PVEU6IHJlY2lwZSB4 ZW4tdG9vbHMtNC4xNitzdGFibGVBVVRPSU5DK2YyNjU0NDQ5MjItcjA6IHRh c2sgZG9fY29tcGlsZTogRmFpbGVkCkVSUk9SOiBUYXNrICgvaG9tZS9kb2Nr ZXItYnVpbGQveW9jdG8tbGF5ZXJzL21ldGEtdmlydHVhbGl6YXRpb24vcmVj aXBlcy1leHRlbmRlZC94ZW4veGVuLXRvb2xzXzQuMTYuYmI6ZG9fY29tcGls ZSkgZmFpbGVkIHdpdGggZXhpdCBjb2RlICcxJwpOT1RFOiByZWNpcGUgeGVu LTQuMTYrc3RhYmxlQVVUT0lOQytmMjY1NDQ0OTIyLXIwOiB0YXNrIGRvX2Nv bXBpbGU6IFN1Y2NlZWRlZApOT1RFOiByZWNpcGUgcWVtdS1zeXN0ZW0tbmF0 aXZlLTYuMi4wLXIwOiB0YXNrIGRvX2NvbXBpbGU6IFN1Y2NlZWRlZApOT1RF OiBUYXNrcyBTdW1tYXJ5OiBBdHRlbXB0ZWQgMzM4OSB0YXNrcyBvZiB3aGlj aCAwIGRpZG4ndCBuZWVkIHRvIGJlIHJlcnVuIGFuZCAxIGZhaWxlZC4KClN1 bW1hcnk6IDEgdGFzayBmYWlsZWQ6CiAgL2hvbWUvZG9ja2VyLWJ1aWxkL3lv Y3RvLWxheWVycy9tZXRhLXZpcnR1YWxpemF0aW9uL3JlY2lwZXMtZXh0ZW5k ZWQveGVuL3hlbi10b29sc180LjE2LmJiOmRvX2NvbXBpbGUKU3VtbWFyeTog VGhlcmUgd2VyZSAyIEVSUk9SIG1lc3NhZ2VzLCByZXR1cm5pbmcgYSBub24t emVybyBleGl0IGNvZGUuCiMjIyMjIyMjIyMjIyAgTE9HUy1FTkQgICMjIyMj IyMjIyMjIwoKMjM6MTc6MzcgcnVuIHFlbXV4ODYtNjQ6IEVycm9yCgojIyMj IyMjIyMjIyMgTE9HUy1TVEFSVCAjIyMjIyMjIyMjIyMKc3Bhd24gYmFzaCAt YyBydW5xZW11IHNlcmlhbHN0ZGlvIG5vZ3JhcGhpYyBzbGlycApydW5xZW11 IC0gSU5GTyAtIFJ1bm5pbmcgYml0YmFrZSAtZSAuLi4KbHM6IGNhbm5vdCBh Y2Nlc3MgJy9ob21lL2RvY2tlci1idWlsZC9idWlsZC9xZW11eDg2LTY0L3Rt cC9kZXBsb3kvaW1hZ2VzL3FlbXV4ODYtNjQvKi5xZW11Ym9vdC5jb25mJzog Tm8gc3VjaCBmaWxlIG9yIGRpcmVjdG9yeQpydW5xZW11IC0gRVJST1IgLSBD b21tYW5kICdscyAtdCAvaG9tZS9kb2NrZXItYnVpbGQvYnVpbGQvcWVtdXg4 Ni02NC90bXAvZGVwbG95L2ltYWdlcy9xZW11eDg2LTY0LyoucWVtdWJvb3Qu Y29uZicgcmV0dXJuZWQgbm9uLXplcm8gZXhpdCBzdGF0dXMgMi4KcnVucWVt dSAtIElORk8gLSBDbGVhbmluZyB1cApydW5xZW11IC0gSU5GTyAtIEhvc3Qg dXB0aW1lOiA4MTIzOS4yMgoKdHB1dDogTm8gdmFsdWUgZm9yICRURVJNIGFu ZCBubyAtVCBzcGVjaWZpZWQKRVJST1ItRU9GIQojIyMjIyMjIyMjIyMgIExP R1MtRU5EICAjIyMjIyMjIyMjIyMKCjIzOjE3OjM4IEJ1aWxkIENvbXBsZXRl ICgyIGVycm9ycykKVGhlIGNvbW1hbmQgJy9iaW4vc2ggLWMgL2J1aWxkLXlv Y3RvLnNoIC0tZHVtcC1sb2cgcWVtdXg4Ni02NCcgcmV0dXJuZWQgYSBub24t emVybyBjb2RlOiAyCm1ha2U6ICoqKiBbTWFrZWZpbGU6MTk6IHlvY3RvL2tp cmtzdG9uZS1xZW11eDg2LTY0LWFybTY0djhdIEVycm9yIDIK --8323329-1987139687-1668809228=:1049131-- From xen-devel-bounces@lists.xenproject.org Fri Nov 18 23:48:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 23:48:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445941.701377 (Exim 4.92) (envelope-from ) id 1owB6I-0005QP-9S; Fri, 18 Nov 2022 23:48:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445941.701377; Fri, 18 Nov 2022 23:48:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owB6I-0005QI-4r; Fri, 18 Nov 2022 23:48:50 +0000 Received: by outflank-mailman (input) for mailman id 445941; Fri, 18 Nov 2022 23:48:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owB6G-0005QC-S9 for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 23:48:48 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8aa3a015-679b-11ed-91b6-6bf2151ebd3b; Sat, 19 Nov 2022 00:48:47 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BAF9D62806; Fri, 18 Nov 2022 23:48:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D36FAC433C1; Fri, 18 Nov 2022 23:48:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8aa3a015-679b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668815325; bh=9n32t82Y0NAtD3tzNxkHbijTeGRFdYs5YlcqqnTWVwA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=VgJ6CPqauvdpcIHKy7kM465rbHjbL0ae06BaPLFC2RJNeoAxve3g0uNAB2SC6pGC5 +x4gEpTyVm9kpILxgVZRvPXOTx4DYWS2sglBDNvgA94+jAn3Zy8iMkDE9hibOoVfGt ez6A/9bP4XEinAC7Vhghqg+q0Qrp3BcnTBGOeYg47OenNUzW2AFgiUXnU/h+m2yrDf XMz1QZkT/mAQeCIC6J8ZvuTDN6xFNIEuqWOuycCDF3y+2/fGoaBoi5GXlYOv/QbRJo j/tj//aXl/yWZ7hDIKYf+bF+Bub3hgDvMwxToN25ePqRWwtdSROtyjn+yMjPh32Yx1 ng38BK5eO1JQg== Date: Fri, 18 Nov 2022 15:48:43 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 1/2] automation: Install packages required by tests in containers In-Reply-To: <20221117161643.3351-2-michal.orzel@amd.com> Message-ID: References: <20221117161643.3351-1-michal.orzel@amd.com> <20221117161643.3351-2-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 17 Nov 2022, Michal Orzel wrote: > Installation of additional packages from the test scripts when running > the tests has some drawbacks. It is slower than cloning containers and can > fail due to some network issues (apparently it often happens on x86 > rackspace). This patch is adding the packages required by the tests to be > installed when building the containers. > > >From qemu-alpine-x86_64.sh into debian:stretch: > - cpio, > - busybox-static. > > >From qemu-smoke-*-{arm,arm64}.sh into debian:unstable-arm64v8: > - u-boot-qemu, > - u-boot-tools, > - device-tree-compiler, > - curl, > - cpio, > - busybox-static. > > The follow-up patch will remove installation of these packages from the > test scripts. This is done in order not to break the CI in-between. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > automation/build/debian/stretch.dockerfile | 3 +++ > automation/build/debian/unstable-arm64v8.dockerfile | 7 +++++++ > 2 files changed, 10 insertions(+) > > diff --git a/automation/build/debian/stretch.dockerfile b/automation/build/debian/stretch.dockerfile > index da6aa874dd70..30fcc5288dee 100644 > --- a/automation/build/debian/stretch.dockerfile > +++ b/automation/build/debian/stretch.dockerfile > @@ -49,6 +49,9 @@ RUN apt-get update && \ > apt-transport-https \ > # for test phase, qemu-smoke-* jobs > qemu-system-x86 \ > + # for test phase, qemu-alpine-* jobs > + cpio \ > + busybox-static \ > && \ > apt-get autoremove -y && \ > apt-get clean && \ > diff --git a/automation/build/debian/unstable-arm64v8.dockerfile b/automation/build/debian/unstable-arm64v8.dockerfile > index 5c73458d9d19..0080c22ba21f 100644 > --- a/automation/build/debian/unstable-arm64v8.dockerfile > +++ b/automation/build/debian/unstable-arm64v8.dockerfile > @@ -43,6 +43,13 @@ RUN apt-get update && \ > wget \ > git \ > nasm \ > + # for test phase, qemu-smoke-* jobs > + u-boot-qemu \ > + u-boot-tools \ > + device-tree-compiler \ > + curl \ > + cpio \ > + busybox-static \ > && \ > apt-get autoremove -y && \ > apt-get clean && \ > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Fri Nov 18 23:49:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 18 Nov 2022 23:49:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445942.701388 (Exim 4.92) (envelope-from ) id 1owB6S-0005ix-Fz; Fri, 18 Nov 2022 23:49:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445942.701388; Fri, 18 Nov 2022 23:49:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owB6S-0005iq-Ci; Fri, 18 Nov 2022 23:49:00 +0000 Received: by outflank-mailman (input) for mailman id 445942; Fri, 18 Nov 2022 23:48:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owB6R-0005QC-E1 for xen-devel@lists.xenproject.org; Fri, 18 Nov 2022 23:48:59 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 91736158-679b-11ed-91b6-6bf2151ebd3b; Sat, 19 Nov 2022 00:48:58 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 56B56627E3; Fri, 18 Nov 2022 23:48:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BFAEC433C1; Fri, 18 Nov 2022 23:48:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91736158-679b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668815336; bh=sJelOwOAWzvSA2FGL8q+He9FN0rOxw50Vkr2Xrn/ZyY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tFkDQMbyk59dmvARLwHyzZtB0nR6QC/Vlxgj9twnIpc1HopTOVw+8zrtmIcU1rLKj okoU9b81qlR0nStkvdc/7gVhr0+TptR1hMFd+0bWtdHUOuvLSjmZc3QCRb7SRe11x0 gh+sYM5RKQpNJmN4Z7YkiOwUqj3aa4ErbUtn26G1AFfzu2qKC0nM2it3OO8geEVC8Z KyoOf+NCbAZhSHps/HwbtRAYX6xrS4oxuXKOGCXFISRAkEc7dznuVDl0cum9o0Edyj 3Mjbsh/0rI0OeGx24mZmBnWMtw+fCi8DRbuUC/gF8+GzeDKs4UYgfD3Fb8GYKKe0IS 9Q6LkKOSGR8Zw== Date: Fri, 18 Nov 2022 15:48:54 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 2/2] automation: Remove installation of packages from test scripts In-Reply-To: <20221117161643.3351-3-michal.orzel@amd.com> Message-ID: References: <20221117161643.3351-1-michal.orzel@amd.com> <20221117161643.3351-3-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 17 Nov 2022, Michal Orzel wrote: > Now, when these packages are already installed in the respective > containers, we can remove them from the test scripts. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > automation/scripts/qemu-alpine-x86_64.sh | 4 ---- > automation/scripts/qemu-smoke-dom0-arm32.sh | 8 -------- > automation/scripts/qemu-smoke-dom0-arm64.sh | 9 --------- > automation/scripts/qemu-smoke-dom0less-arm64.sh | 9 --------- > 4 files changed, 30 deletions(-) > > diff --git a/automation/scripts/qemu-alpine-x86_64.sh b/automation/scripts/qemu-alpine-x86_64.sh > index 2e9625109c56..8c8d0b0cd759 100755 > --- a/automation/scripts/qemu-alpine-x86_64.sh > +++ b/automation/scripts/qemu-alpine-x86_64.sh > @@ -2,10 +2,6 @@ > > set -ex > > -apt-get -qy update > -apt-get -qy install --no-install-recommends cpio \ > - busybox-static > - > # DomU Busybox > cd binaries > mkdir -p initrd > diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh > index ef19b988c2c4..98e4d481f65c 100755 > --- a/automation/scripts/qemu-smoke-dom0-arm32.sh > +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh > @@ -2,14 +2,6 @@ > > set -ex > > -export DEBIAN_FRONTEND=noninteractive > -apt-get -qy update > -apt-get -qy install --no-install-recommends u-boot-qemu \ > - u-boot-tools \ > - device-tree-compiler \ > - curl \ > - cpio > - > cd binaries > # Use the kernel from Debian > curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz > diff --git a/automation/scripts/qemu-smoke-dom0-arm64.sh b/automation/scripts/qemu-smoke-dom0-arm64.sh > index 9004c537e325..0bf5cfdc61f9 100755 > --- a/automation/scripts/qemu-smoke-dom0-arm64.sh > +++ b/automation/scripts/qemu-smoke-dom0-arm64.sh > @@ -2,15 +2,6 @@ > > set -ex > > -export DEBIAN_FRONTEND=noninteractive > -apt-get -qy update > -apt-get -qy install --no-install-recommends u-boot-qemu \ > - u-boot-tools \ > - device-tree-compiler \ > - cpio \ > - curl \ > - busybox-static > - > # DomU Busybox > cd binaries > mkdir -p initrd > diff --git a/automation/scripts/qemu-smoke-dom0less-arm64.sh b/automation/scripts/qemu-smoke-dom0less-arm64.sh > index 933209e2e01e..2b59346fdcfd 100755 > --- a/automation/scripts/qemu-smoke-dom0less-arm64.sh > +++ b/automation/scripts/qemu-smoke-dom0less-arm64.sh > @@ -38,15 +38,6 @@ fi > " > fi > > -export DEBIAN_FRONTEND=noninteractive > -apt-get -qy update > -apt-get -qy install --no-install-recommends u-boot-qemu \ > - u-boot-tools \ > - device-tree-compiler \ > - busybox-static \ > - cpio \ > - curl > - > # XXX QEMU looks for "efi-virtio.rom" even if it is unneeded > curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > ./binaries/qemu-system-aarch64 \ > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Sat Nov 19 00:36:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 00:36:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445952.701398 (Exim 4.92) (envelope-from ) id 1owBqD-00043c-JC; Sat, 19 Nov 2022 00:36:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445952.701398; Sat, 19 Nov 2022 00:36:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owBqD-00043V-GZ; Sat, 19 Nov 2022 00:36:17 +0000 Received: by outflank-mailman (input) for mailman id 445952; Sat, 19 Nov 2022 00:36:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owBqC-00043P-Rz for xen-devel@lists.xenproject.org; Sat, 19 Nov 2022 00:36:17 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2c5ec814-67a2-11ed-91b6-6bf2151ebd3b; Sat, 19 Nov 2022 01:36:14 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D7781B825DA; Sat, 19 Nov 2022 00:36:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E90B7C433D6; Sat, 19 Nov 2022 00:36:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c5ec814-67a2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668818171; bh=dwGE39AbfR/PbAZBDDm4IDB9zj109djqC5+9ZbOhbjY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Cu3GwSrnLAsXa2R99AMu5o44DYWPcM+WIczC8Wyn7c9F/jbvXntG4DV+XFZ4Xe5vN LaAnINMSwb4EbnuRVHv6PNPqOgPxEP3TOnTxmLe/MTFWZAZKP0uWb9Iv4Z+dMNTp0O FnGGdbugWv3beTjsqy6buCqGQsNeeCJbqp+3NyACIimyhhwY2kvtEBHaaOMaF+cdac +A0RBtkkRB55hzBiP7+cu6R5qU+bODgoxe0orsEYjdxHAU/D0i8dWgBCrNkPmytNG8 15TB+PanZLPl9AYhxSwNkI6NTm8d7HVQGk2q8WavV7lEEGSkYet1YkZFgltKDlqW8U 7srwYdXDJdevA== Date: Fri, 18 Nov 2022 16:36:08 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Leo Yan cc: Stefano Stabellini , Xen Develop , Julien Grall , Bertrand Marquis , Jan Beulich , Mathieu Poirier , Kasper Ornstein Mecklenburg , jgross@suse.com, oleksandr_tyshchenko@epam.com, boris.ostrovsky@oracle.com, wei.liu@kernel.org, paul@xen.org Subject: Re: Issue: Networking performance in Xen VM on Arm64 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi Leo, Thank you for the fantastic work with so many good details. Apologies for the late reply -- I have been traveling and on holiday. On Fri, 28 Oct 2022, Leo Yan wrote: > Hi Stefano, > > On Tue, Oct 25, 2022 at 04:58:16PM -0700, Stefano Stabellini wrote: > > On Mon, 24 Oct 2022, Leo Yan wrote: > > > > If you are really running with the NULL scheduler, then I would > > > > investigate why the vCPU has is_running == 0 because it should not > > > > happen. > > > > > > Correct for this: it's my bad that I didn't really enable NULL scheduler > > > in my code base. After I enabled NULL scheduler, the latency by context > > > switching is dismissed. > > > > > > 8963 pub-338 [002] 217.777652: bprint: xennet_tx_setup_grant: id=60 ref=1340 offset=2 len=1514 TSC: 7892178799 > > > 8964 pub-338 [002] 217.777662: bprint: xennet_tx_setup_grant: id=82 ref=1362 offset=2050 len=1006 TSC: 7892179043 > > > 8965 ksoftirqd/12-75 [012] 255.466914: bprint: xenvif_tx_build_gops.constprop.0: id=60 ref=1340 offset=2 len=1514 TSC: 7892179731 > > > 8966 ksoftirqd/12-75 [012] 255.466915: bprint: xenvif_tx_build_gops.constprop.0: id=82 ref=1362 offset=2050 len=1006 TSC: 7892179761 > > > 8967 pub-338 [002] 217.778057: bprint: xennet_tx_setup_grant: id=60 ref=1340 offset=2050 len=1514 TSC: 7892188930 > > > 8968 pub-338 [002] 217.778072: bprint: xennet_tx_setup_grant: id=53 ref=1333 offset=2 len=1514 TSC: 7892189293 > > > 8969 containerd-2965 [012] 255.467304: bprint: xenvif_tx_build_gops.constprop.0: id=60 ref=1340 offset=2050 len=1514 TSC: 7892189479 > > > 8970 containerd-2965 [012] 255.467306: bprint: xenvif_tx_build_gops.constprop.0: id=53 ref=1333 offset=2 len=1514 TSC: 7892189533 > > > > I am having difficulty following the messages. Are the two points [a] > > and [b] as described in the previous email shown here? > > No, the [b] point is about the trace point in Xen hypvervisor. > > For easier review I combined the trace log from Xen dom0 and dom0 > Linux kernels, in above log, the function xennet_tx_setup_grant() is > traced from domU Linux kernel and the function > xenvif_tx_build_gops.constprop.0 from dom0 Linux kernel and I sorted > the logs with TSC (Arm arch timer physical counter). > > Sorry for confusion and I didn't explain clearly. > > > > So the xennet (Xen net forend driver) and xenvif (net backend driver) > > > work in parallel. Please note, I didn't see networking performance > > > improvement after changed to use NULL scheduler. > > > > > > Now I will compare the duration for two directions, one direction is > > > sending data from xennet to xenvif, and another is the reversed > > > direction. It's very likely the two directions have significant > > > difference for sending data with grant tables, you could see in above > > > log, it takes 20~30us to transmit a data block (we can use the id > > > number and grant table's ref number to match the data block in xennet > > > driver and xenvif driver). > > > > > > > Now regarding the results, I can see the timestamp 3842008681 for > > > > xennet_notify_tx_irq, 3842008885 for vgic_inject_irq, and 3842008935 for > > > > vcpu_kick. Where is the corresponding TSC for the domain receiving the > > > > notification? > > > > > > > > Also for the other case, starting at 3842016505, can you please > > > > highlight the timestamp for vgic_inject_irq, vcpu_kick, and also the one > > > > for the domain receiving the notification? > > > > > > > > The most interesting timestamps would be the timestamp for vcpu_kick in > > > > "notification sending domain" [a], the timestamp for receiving the > > > > interrupt in the Xen on pCPU for the "notification receiving domain" > > > > [b], and the timestamp for the "notification receiving domain" getting > > > > the notification [c]. > > > > > > > > If really context switch is the issue, then the interesting latency > > > > would be between [a] and [b]. > > > > > > Understand. I agree that I didn't move into more details, the main > > > reason is Xen dmesg buffer is fragile after adding more logs, e.g. > > > after I added log in the function gicv3_send_sgi(), Xen will stuck > > > during the booting phase, and after adding logs in > > > leave_hypervisor_to_guest() it will introduce huge logs (so I need to > > > only trace for first 16 CPUs to mitigate log flood). > > > > > > I think it would be better to enable xentrace for my profiling at my > > > side. If I have any further data, will share back. > > > > Looking forward to it. Without more details it is impossible to identify > > the source of the problem and fix it. > > The application passes data to Linux kernel and low level driver needs > to transfer skbs between Xen network frontend and backend drivers via > Xen shared ring buffer / grant table. So let's step back to review > the duration in the network drivers for sending and receiving skbs. > > I measured intervals for sending skbs, one direction is for sending skb > from dom0 to domU and another direction is from domU to dom0. For easier > review, I plotted the intervals in diagrams [1][2] for these two > directions respectively. > > In a diagram it has three metrics: > > - Packet sending interval: measures the interval from the sender. > > For the direction from dom0 to domu, this metric measures the > interval for sending skbs in the Xen backend driver in dom0. > > For the direction from domU to dom0, this metric measures the > interval for sending skbs in the Xen frontend driver in domU. > > - Packet receiving interval: measures the interval for the receiver. > > For the direction from dom0 to domu, this metric measures the > interval for receiving skbs in the Xen frontend driver in domU. > > For the direction from domU to dom0, this metric measures the > interval for receiving skbs in the Xen backend driver in dom0. > > - Packet response interval: measures the interval between sender and > receiver. > > This interval measures the duration between a skb is sending out > from the sender and until it's fetched from grant table by the > receiver. > > >From these three metrics we can know the latency is caused by three > actors: sender, receiver, Xen hypervisor. > > In two diagrams we can see the packet response interval (yellow line) > is about 10~20us. The response interval for domu -> dom0 (~10us) is > even better than the interval for dom0 -> domu (15~20us), which means > the response time is not the curplit for the poor performance when > sending data from domu to dom0. I agree with you. > The purple line and blue line for sending and receiving intervals are > correlated, this means the drivers in two sides (dom0 and domU) work in > parallel. > > A big difference is we can see the sending interval (purple line) in the > diagram xmit_interval_dom0_to_domu.png usually keeps at ~1us, but the > sending interval in the diagram xmit_interval_domu_to_dom0.png is > about 10us. I also find it curious that the receiving interval is almost 0 in the "dom0 to domU" direction and instead it is about 10us in the "domU to dom0" direction. Why would it take more time to receive skbs in one direction compared to the other? Are the "receiving interval" and the "sending interval" measuring the same delay just from the receiver side and from the sender side? > If map to the code, I think the function xennet_start_xmit() in Xen > frontend driver is critical for the sending interval in domU. I can > see several things cost time when sending a packet: > > - Xen frontend driver needs to setup grant table for every skb, it > invokes the function xennet_tx_setup_grant() and > gnttab_grant_foreign_access_ref() to prepare grant table; > > - Xen frontend driver sends notification by calling > notify_remote_via_irq(). It will trap to Xen hypervisor to send the > interrupt, this takes several macro seonds for this step. > > - Xen frontend driver calls xennet_tx_buf_gc(), the interval for this > function is vary, it will take ~30us in the case for reclaiming grant > table. > > Any thoughts for this? For the sake of latency, it is better to avoid sources of uncertainty (even at the cost of bandwidth). From what you wrote above and from the other email it would seem that xennet_tx_buf_gc() can cause significant delays. One idea is only to parse the responses (RING_COPY_RESPONSE) in xennet_tx_buf_gc() and delay the calls to gnttab_end_foreign_access_ref for later. In other words: 1) xennet_tx_buf_gc: read responses, grants to be removed "for later" 2) independently when idle (maybe from a kthread or independent tasklet) look for grants to be removed and remove them Basically it is a lazy grant removal scheme where once receiving skbs, the related grants are not immediately freed, but later lazily. From xen-devel-bounces@lists.xenproject.org Sat Nov 19 01:10:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 01:10:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445960.701410 (Exim 4.92) (envelope-from ) id 1owCNe-00078g-9Y; Sat, 19 Nov 2022 01:10:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445960.701410; Sat, 19 Nov 2022 01:10:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owCNe-00078Z-5Y; Sat, 19 Nov 2022 01:10:50 +0000 Received: by outflank-mailman (input) for mailman id 445960; Sat, 19 Nov 2022 01:10:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owCNc-00078T-Ig for xen-devel@lists.xenproject.org; Sat, 19 Nov 2022 01:10:49 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fd6eb5e3-67a6-11ed-91b6-6bf2151ebd3b; Sat, 19 Nov 2022 02:10:45 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 3562732005BC; Fri, 18 Nov 2022 20:10:41 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 18 Nov 2022 20:10:42 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Nov 2022 20:10:39 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd6eb5e3-67a6-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668820240; x= 1668906640; bh=5ZTgwin0129aHkVKnahjCMa8iAMdMUWn/8FuM88/l8s=; b=Y /kP2NAbHWWMuxtBzYGa+f7z0RUBou8a73WlsYgDTjXguRT0kLWMM5Gp8Qw6qwzy8 ysLeF1gtK9fKJUX0cZrmCFGc+SyLVU22oiwRvpcRK2r/jywU7jbY6z2EmqezONAh DHqJk36+TrmMxla7hOeR/Rr5G0aFgaFNa7Hhw+3761ztHl1JWOgxo4xdezGUDsnM 7O+5vz/ngBPkzIAz/MlPLWoCz52RX8RC+ZJv5HOWQGeKPsLx+cXkNS1IKki188NV xDtmLvLURwwJDrIC/8A/xetPJ/V41IADQKYyStoilVMHeI+jY5nb8I6FyDKyJp0B VfR1HwGzjTZ/8k7PNnF5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668820240; x=1668906640; bh=5ZTgwin0129aHkVKnahjCMa8iAMd MUWn/8FuM88/l8s=; b=A2qiiyNnB1jaLh+c3g0Bv2qIzo1xFA/STTCwKwGQhV8c CaQNuH8inrMNyUeDpesjwG4ZCt/STe/8bPr6H7gjsmRLAYmqf40smjpWrYKxabqg xRS6V/mBMQfsjKPJHumNqzUmzbobj2Sl8/VwJs0SYg0AGDhpQaVIyX0JaIf+fJJW jWk227NazmYUVG33QAImi1YYyyMsHifWAm0z6+t+Y3hUuyoy/Saqw17nTDJkdcSv gKj/yG8plOpQhmOE5GCHx7TmlzbVgNtCJhXWg+YhoEsJKX3LT808r9iqpeWLj4pb tOpceD1Nfm/RNRKr73YXXI4z3hXrM4BbJFnvizaRPQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrhedugdefudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeutdehhfdtvdfffeejjedvhedvjeei heffheekkeehgeelueelveeludetheetteenucffohhmrghinhepghhithhhuhgsrdgtoh hmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggv mhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Fri, 18 Nov 2022 20:10:33 -0500 From: Demi Marie Obenour To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: Ard Biesheuvel , linux-efi@vger.kernel.org, Xen developer discussion , Peter Jones , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup based on hypercall Message-ID: References: <20221003112625.972646-1-ardb@kernel.org> <20221003112625.972646-6-ardb@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eZXLIpVKxA42QWNq" Content-Disposition: inline In-Reply-To: --eZXLIpVKxA42QWNq Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 18 Nov 2022 20:10:33 -0500 From: Demi Marie Obenour To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: Ard Biesheuvel , linux-efi@vger.kernel.org, Xen developer discussion , Peter Jones , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup based on hypercall On Mon, Oct 03, 2022 at 07:04:02PM +0200, Marek Marczykowski-G=C3=B3recki w= rote: > On Mon, Oct 03, 2022 at 06:37:19PM +0200, Ard Biesheuvel wrote: > > On Mon, 3 Oct 2022 at 18:23, Demi Marie Obenour > > wrote: > > > > > > On Mon, Oct 03, 2022 at 05:59:52PM +0200, Ard Biesheuvel wrote: > > > > On Mon, 3 Oct 2022 at 17:29, Demi Marie Obenour > > > > wrote: > > > > > > > > > > On Mon, Oct 03, 2022 at 01:26:24PM +0200, Ard Biesheuvel wrote: > > > > > > Xen on x86 boots dom0 in EFI mode but without providing a memor= y map. > > > > > > This means that some sanity checks we would like to perform on > > > > > > configuration tables or other data structures in memory are not > > > > > > currently possible. Xen does, however, expose EFI memory descri= ptor info > > > > > > via a Xen hypercall, so let's wire that up instead. > > > > > > > > > > > > Co-developed-by: Demi Marie Obenour > > > > > > Signed-off-by: Demi Marie Obenour > > > > > > Signed-off-by: Ard Biesheuvel > > > > > > --- > > > > > > drivers/firmware/efi/efi.c | 5 ++- > > > > > > drivers/xen/efi.c | 34 ++++++++++++++++++++ > > > > > > include/linux/efi.h | 1 + > > > > > > 3 files changed, 39 insertions(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/= efi.c > > > > > > index 55bd3f4aab28..2c12b1a06481 100644 > > > > > > --- a/drivers/firmware/efi/efi.c > > > > > > +++ b/drivers/firmware/efi/efi.c > > > > > > @@ -456,7 +456,7 @@ void __init efi_find_mirror(void) > > > > > > * and if so, populate the supplied memory descriptor with the= appropriate > > > > > > * data. > > > > > > */ > > > > > > -int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_= md) > > > > > > +int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *ou= t_md) > > > > > > { > > > > > > efi_memory_desc_t *md; > > > > > > > > > > > > @@ -485,6 +485,9 @@ int efi_mem_desc_lookup(u64 phys_addr, efi_= memory_desc_t *out_md) > > > > > > return -ENOENT; > > > > > > } > > > > > > > > > > > > +extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_= t *out_md) > > > > > > + __weak __alias(__efi_mem_desc_lookup); > > > > > > + > > > > > > /* > > > > > > * Calculate the highest address of an efi memory descriptor. > > > > > > */ > > > > > > diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c > > > > > > index d1ff2186ebb4..74f3f6d8cdc8 100644 > > > > > > --- a/drivers/xen/efi.c > > > > > > +++ b/drivers/xen/efi.c > > > > > > @@ -26,6 +26,7 @@ > > > > > > > > > > > > #include > > > > > > #include > > > > > > +#include > > > > > > #include > > > > > > #include > > > > > > > > > > > > @@ -292,3 +293,36 @@ void __init xen_efi_runtime_setup(void) > > > > > > efi.get_next_high_mono_count =3D xen_efi_get_next_high= _mono_count; > > > > > > efi.reset_system =3D xen_efi_reset_system; > > > > > > } > > > > > > + > > > > > > +int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_= md) > > > > > > +{ > > > > > > + static_assert(XEN_PAGE_SHIFT =3D=3D EFI_PAGE_SHIFT, > > > > > > + "Mismatch between EFI_PAGE_SHIFT and XEN_PA= GE_SHIFT"); > > > > > > + struct xen_platform_op op =3D { > > > > > > + .cmd =3D XENPF_firmware_info, > > > > > > + .u.firmware_info =3D { > > > > > > + .type =3D XEN_FW_EFI_INFO, > > > > > > + .index =3D XEN_FW_EFI_MEM_INFO, > > > > > > + .u.efi_info.mem.addr =3D phys_addr, > > > > > > + .u.efi_info.mem.size =3D U64_MAX - phys_a= ddr, > > > > > > + } > > > > > > + }; > > > > > > + union xenpf_efi_info *info =3D &op.u.firmware_info.u.efi_= info; > > > > > > + int rc; > > > > > > + > > > > > > + if (!efi_enabled(EFI_PARAVIRT) || efi_enabled(EFI_MEMMAP)) > > > > > > + return __efi_mem_desc_lookup(phys_addr, out_md); > > > > > > + > > > > > > + rc =3D HYPERVISOR_platform_op(&op); > > > > > > + if (rc) { > > > > > > + pr_warn("Failed to lookup header 0x%llx in Xen me= mory map: error %d\n", > > > > > > + phys_addr, rc); > > > > > > + } > > > > > > + > > > > > > + out_md->phys_addr =3D info->mem.addr; > > > > > > > > > > This will be equal to phys_addr, not the actual start of the memo= ry > > > > > region. > > > > > > > > > > > + out_md->num_pages =3D info->mem.size >> EFI_PAGE_SH= IFT; > > > > > > > > > > Similarly, this will be the number of bytes in the memory region > > > > > after phys_addr, not the total number of bytes in the region. Th= ese two > > > > > differences mean that this function is not strictly equivalent to= the > > > > > original efi_mem_desc_lookup(). > > > > > > > > > > I am not sure if this matters in practice, but I thought you woul= d want > > > > > to be aware of it. > > > > > > > > This is a bit disappointing. Is there no way to obtain this > > > > information via a Xen hypercall? > > > > > > It is possible, but doing so is very complex (it essentially requires= a > > > binary search). This really should be fixed on the Xen side. > > > > > > > In any case, it means we'll need to round down phys_addr to page si= ze > > > > at the very least. > > > > > > That makes sense. Are there any callers that will be broken even with > > > this rounding? > >=20 > > As far as I can tell, it should work fine. The only thing to double > > check is whether we are not creating spurious error messages from > > efi_arch_mem_reserve() this way, but as far as I can tell, that should > > be fine too. > >=20 > > Is there anyone at your end that can give this a spin on an actual > > Xen/x86 system? >=20 > Demi, if you open a PR with this at > https://github.com/QubesOS/qubes-linux-kernel/pulls, I can run it > through our CI - (at least) one of the machines has ESRT table. Done: https://github.com/QubesOS/qubes-linux-kernel/pull/681 > AFAIR your test laptop has it too. It does; I plan to test a version that has the needed rounding. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --eZXLIpVKxA42QWNq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmN4LQ4ACgkQsoi1X/+c IsHajw//UHBxXvpBAaynVshK24kWcagS+15BbXEqlSvj8f4y7Kjd/j71nedJG9wM fbDlTd9ThZh+Bts17ytNdVxxx1NPN0vwm9Y65alkMraBBS0zKlbSMLofYTBHc4K5 k9JxkuEejvWOYXKEHzDXIong/pKBMa1LFQVrkS/SfV8KpRm8jAS7+a/+5MnzsRP5 iAQ89uiCJO2fipRHlw7dEnwMy1UR7S/huHUaKh0Zjdyu3LGFNVkPC1LE43BVg8rB 2nwkfGpBcnHvGmG74/DC3SoPdlA89NCSaJnbJzY+0eEfkhZrZBaV4C7+MLCljXeQ mDGyTDLYWpt5GKv52OfL1UmW1qlp2b1cn8mADcqAHFGKyWzhvsfV16J+q1p9eJ4f xeX7PIYpHefhifjHnghR792HoVYaHrzz0fELsYlBCYxkysSzACpUbdgOXI3CJZ2u nTuI+ktChEb9+EoV5ZF3RWzWjIQRLRZBkAXZdLuFn0+VKojnirSTf5UeBsqORStK sNuHUirH2Y917nSidGZjAcMeh7wg1gA6nTx/zvfR+hoGZW7BUdlqbWUKHFyu8PqN vlosBmJp16MCylNe61+1fxyM78dfpTMd72jHwJLyq71Na+WgiRXuCFUoADHCi6He 0KH4QOPfjJ0xYOokeSnC/6MNGIBYJdUaxxKUGgdQKSZ5emLd5WI= =ahFb -----END PGP SIGNATURE----- --eZXLIpVKxA42QWNq-- From xen-devel-bounces@lists.xenproject.org Sat Nov 19 01:40:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 01:40:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445969.701427 (Exim 4.92) (envelope-from ) id 1owCpf-0001aZ-Q6; Sat, 19 Nov 2022 01:39:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445969.701427; Sat, 19 Nov 2022 01:39:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owCpf-0001aS-Lp; Sat, 19 Nov 2022 01:39:47 +0000 Received: by outflank-mailman (input) for mailman id 445969; Sat, 19 Nov 2022 01:39:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owCpe-0001aM-7P for xen-devel@lists.xenproject.org; Sat, 19 Nov 2022 01:39:46 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20606.outbound.protection.outlook.com [2a01:111:f400:7e1b::606]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 09cf5131-67ab-11ed-8fd2-01056ac49cbb; Sat, 19 Nov 2022 02:39:42 +0100 (CET) Received: from DUZPR01CA0064.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c2::17) by PAWPR08MB9590.eurprd08.prod.outlook.com (2603:10a6:102:2e8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Sat, 19 Nov 2022 01:39:39 +0000 Received: from DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3c2:cafe::6b) by DUZPR01CA0064.outlook.office365.com (2603:10a6:10:3c2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Sat, 19 Nov 2022 01:39:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT046.mail.protection.outlook.com (100.127.142.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Sat, 19 Nov 2022 01:39:39 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Sat, 19 Nov 2022 01:39:39 +0000 Received: from 7233a6393383.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EDB50CCD-11C3-4560-A55D-AE9198E895D1.1; Sat, 19 Nov 2022 01:39:32 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7233a6393383.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 19 Nov 2022 01:39:32 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAWPR08MB9055.eurprd08.prod.outlook.com (2603:10a6:102:343::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.8; Sat, 19 Nov 2022 01:39:31 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5834.009; Sat, 19 Nov 2022 01:39:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09cf5131-67ab-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xPmB5r0Qb0oqisuYaZfatXH2js6mSfv/b+/205Fi+vo=; b=2VYm6Pow5u9v+ZsI8Dq6k4f7cHg3NqnGbuT5MqP7gOkSmdklA5yj0qsZTCkBArYco5VCAwGx8WJxY+DtcCfgCojYEZFNoKLodfQcdS9DuFUC7pUCqDbj1sKMUPYEXQhUgvPDBnMJJdakTRk3sfjkB1Ayktn7/8ltW70ZYdu0mPw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KEIobXLEZyKhk9881WgwZANJpUQBTEHjmeEx85pTbf5uMkW0BzQfk7RLad2RUX+6u1Zgl7L72XaVS3R//UKitIBbSrC1ra/TSRQSFIxDB6Ww0s9Ohg8SniHOZHDm1Auf2rZduNisJ5WUy12DbTjfCTFEgIJGqQvuJl5lJwbFYFp/To4YXiyx3zYazb2OUK74CQUjsqqIU9sS+D/pp4byx2mQk2WtpNnlMRzf8ID/wKmqyGBo4yDoWl3r730NkN4/HaFj+OdlUb9OcR41/rNDfPA0cPf0/GsO5HFFuzYyqfPaA8jaP1mzEAFI87BdWO/7hI72aLG4jwayBVeq0ngDNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xPmB5r0Qb0oqisuYaZfatXH2js6mSfv/b+/205Fi+vo=; b=YgpczSQiQkCzymzBOjNOQO1DI1ApRnL47K80VbmjfFT94sE/US6Si7vs4PbyiZF4vkgUXOm9zkIZ2JI6yNGNwejaDC5OJb1vFMINvz83t92JuZJ48Ixah2xcc1yAPWg4vk+6qvc5ZtKA/2+rhzhNMJPUnV/tPRDYT0tHO5j16Yr7vfet7MmJ/bBFr9Nbs9mtAixzy1h8SCNoT4chTKrgMDRybNmGAde4b+RenGApsq8NSqg/c+jJERpIQkzg3RDxpLhBA1cCcB8PsdqGGAcRN0nlGGpSixRdz6yQM0+nXy5+mXXiJLrufom1bBFIiYsYeWxIqAtXvxPUfwgwDa+uvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xPmB5r0Qb0oqisuYaZfatXH2js6mSfv/b+/205Fi+vo=; b=2VYm6Pow5u9v+ZsI8Dq6k4f7cHg3NqnGbuT5MqP7gOkSmdklA5yj0qsZTCkBArYco5VCAwGx8WJxY+DtcCfgCojYEZFNoKLodfQcdS9DuFUC7pUCqDbj1sKMUPYEXQhUgvPDBnMJJdakTRk3sfjkB1Ayktn7/8ltW70ZYdu0mPw= From: Henry Wang To: Anthony PERARD , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Wei Liu , Juergen Gross Subject: RE: [XEN PATCH for-4.17] libs/light: Propagate libxl__arch_domain_create() return code Thread-Topic: [XEN PATCH for-4.17] libs/light: Propagate libxl__arch_domain_create() return code Thread-Index: AQHY+245sY2WpYuKG0eYsgh9xhHeR65FeJEA Date: Sat, 19 Nov 2022 01:39:31 +0000 Message-ID: References: <20221118165235.14143-1-anthony.perard@citrix.com> In-Reply-To: <20221118165235.14143-1-anthony.perard@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: BAA1DF80BFE6044789EB0732A9F95C72.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAWPR08MB9055:EE_|DBAEUR03FT046:EE_|PAWPR08MB9590:EE_ X-MS-Office365-Filtering-Correlation-Id: d420e06d-e523-4252-d8b5-08dac9ceec77 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1utKKLiDQjzh8B6eB/maOFcqNeEoP4J5KTV5Qyr/KdrIiZbygD0MDSTTH8D4Y++E4gwboFm1dwO6m9LT0b9NbrjhOYKhOHghz0Hv3PBHGBGGq/4O+Y6sqAgAFQm2Fwe9L3On/vXlWDhMr9tP9w3Frojiwfgb2NlQf3oLOt8XZgmJ/A6UKfVHMx/P7nnVIeoqdLcQGX6t4BrqSnDQ5yGhPDzVoXpEzWI8vbu7tUyhrOWsCsBg8zv3SN0jaPVe+tI8Q2intXxi5zkAvonqXxV5B+mxfagdV1RdNjUp4OVBAD4xNVHKJRw3jCAl50e7kQHTg+gsU8xlrATzHUZaX/Gcea24FjnXJZDbMy7ciNENgAuyLujvMw3THoC20kZvFBk0qJYssZLyo6KvLVZhAxkvg49fY5ITmZ6TyBxjeFOD6FqWoE4uY3lny/lYUWkfjyLypbJAbJWBDirGHB+hrSUsdzy2Iq60NK6cTYQJFH+VBnqt+s5CohFmlnHuiclzMKXB5qV/diLhRK0G2E0/gl6wjej/j8okXPQNwtLsYC3nj3xr/vO0/3bx6w6I8IwXGcXar6Le+rC+O7V+rGHa4cxzVH11TXyPEzakN4KRvg4uXjsVq5lLFwssob6muhzxQioZ3LQUq8h1ovQ2+Zs09gRwBG8OwCrPY602Npcv4JfZ4+oCzq47XpWuiqTDRKbwDHs90tm5z9lVHMm9ci1anrrhzZjdRZCTkXHYvL2/om+O0S0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(396003)(376002)(136003)(39860400002)(451199015)(316002)(54906003)(2906002)(478600001)(110136005)(6506007)(66946007)(9686003)(7696005)(71200400001)(26005)(76116006)(186003)(41300700001)(8936002)(4326008)(122000001)(83380400001)(4744005)(38100700002)(55016003)(5660300002)(52536014)(8676002)(86362001)(66476007)(66556008)(33656002)(66446008)(38070700005)(64756008)(101420200003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9055 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 35f714be-e358-4f07-060b-08dac9cee790 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1oXQZPUUqRkfGgayG+k+lwmh5nJjxI1lBLNxgESk7KvvjsEi7yfCcLoLma7NTOA1BYvaKwr3yaiqyjkc3L6fS4IMVM82jVlT0hRplHqshCpiGXugGXxvkqxMfKiPrN8lbF+3kszlNQSF2Cm0qpfBuovKDTyI347cl9B8dllFLCHfm4+7O9C3ewiQS8WEFpkE5X0NHT/SxxEU05puvleY/1IISkjve0kd0NZRHvSKImH/JC4VvHavq1iC77rEMwh3e/O9cbmZhha4oVD0UN4aueBIHxnHjTXOR5ctoWqAOn5boSGvg8K9F0chFg2gdaimBtF1cn6wvP1gQZYlww0RLoDIZ4S605UQN45riV+TnqfeFgGmArNymuGOLp7tmFZ5hvg3Hj8LIAyzHZojj/ZI/HRlLWcS0ccEbQvhJ9NEgn+eYaSihx4JaTZUSnDr9BfkL18mZLHZwYA54ZHnDYEP9KeanDinoJofOy0ImVoT7ofulSmF0lQ27tUuTbSqVD8lIUORTSOG9b8GOl9yWHVMTaTru+bakZBS9Sr3UoAq1eFN3Oq37Or33TJE2CV5cGiZUhpyxxYGhBMdGiCrVdpe3EFc7FcfQGrhTd+oatCwMkIIinOB76SCKx1PuzatgdtwPAElulDJeH/hAfvLtQyt+esI1hz/HqPK3B9gR4/8YC+mxPOgfHpnRO6T/sPvlT9Hz1DGljVSiHZmxVVB2dhBeWkVf/gJQX8uMvAb8E/NH7sby5MjXYA23fmmgVb9AlvS X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(396003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(40460700003)(186003)(110136005)(33656002)(5660300002)(336012)(316002)(54906003)(9686003)(26005)(7696005)(6506007)(4744005)(41300700001)(70586007)(52536014)(8936002)(4326008)(70206006)(8676002)(40480700001)(36860700001)(82310400005)(356005)(81166007)(82740400003)(83380400001)(47076005)(55016003)(2906002)(86362001)(478600001)(107886003)(101420200003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2022 01:39:39.3913 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d420e06d-e523-4252-d8b5-08dac9ceec77 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9590 Hi Anthony, > -----Original Message----- > From: Anthony PERARD > Subject: [XEN PATCH for-4.17] libs/light: Propagate > libxl__arch_domain_create() return code >=20 > Commit 34990446ca91 started to overwrite the `rc` value from > libxl__arch_domain_create(), thus error aren't propagated anymore. >=20 > Check `rc` value before doing the next thing. >=20 > Fixes: 34990446ca91 ("libxl: don't ignore the return value from > xc_cpuid_apply_policy") > Reported-by: Andrew Cooper > Signed-off-by: Anthony PERARD Release-acked-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Sat Nov 19 01:46:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 01:46:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445974.701437 (Exim 4.92) (envelope-from ) id 1owCwH-0003Bq-G2; Sat, 19 Nov 2022 01:46:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445974.701437; Sat, 19 Nov 2022 01:46:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owCwH-0003Bj-DA; Sat, 19 Nov 2022 01:46:37 +0000 Received: by outflank-mailman (input) for mailman id 445974; Sat, 19 Nov 2022 01:46:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owCwF-0003Bd-P2 for xen-devel@lists.xenproject.org; Sat, 19 Nov 2022 01:46:35 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70049.outbound.protection.outlook.com [40.107.7.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ff5e685c-67ab-11ed-8fd2-01056ac49cbb; Sat, 19 Nov 2022 02:46:34 +0100 (CET) Received: from DBBPR09CA0040.eurprd09.prod.outlook.com (2603:10a6:10:d4::28) by DU0PR08MB9051.eurprd08.prod.outlook.com (2603:10a6:10:470::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.8; Sat, 19 Nov 2022 01:46:05 +0000 Received: from DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:d4:cafe::7f) by DBBPR09CA0040.outlook.office365.com (2603:10a6:10:d4::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Sat, 19 Nov 2022 01:46:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT041.mail.protection.outlook.com (100.127.142.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Sat, 19 Nov 2022 01:46:04 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Sat, 19 Nov 2022 01:46:04 +0000 Received: from 873c802cda53.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8E3E0EB4-7997-4419-A8BB-7ED014FE9CCA.1; Sat, 19 Nov 2022 01:45:57 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 873c802cda53.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 19 Nov 2022 01:45:57 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PA4PR08MB6285.eurprd08.prod.outlook.com (2603:10a6:102:e0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.8; Sat, 19 Nov 2022 01:45:56 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5834.009; Sat, 19 Nov 2022 01:45:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff5e685c-67ab-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wd8mJ5zfR+79oWHkdqNzD1zqjctsNe0GXT3PlKrnKbI=; b=uR44bQFy8bokgmurAZ/rJ+5gZctTItVtmoGbQ266Fud0+6Zxryaob+B8Re5PKsU5CFXCreAU1VmwKMl5+csS84eYyurSk2PMq/lEV9joG6IB2enUPCO6TkPxXE9gl0P7h4eVEbvsWUe+G7CNSqaUetx4jZvNsoPJO7dD22zi2KY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MwU9/oKQRCHS5rwOBlDo7NLqj8nvQyY+DgeALunYXJ38xozsulbsrR9A9tw6MCICY/Kfgf07pgxlKRGAMHEsHlauz+bZQkd6R59kTKWSKdkcKJbVxs+pFN6HBjXhMo23xXSP0Kgy5JqaPP4AzY/BIcxo6AxqEUpu7kFu9n820T8x8OHbWcOCvUGSdsW9kDOIka1TjaKXPwEY7E+7s6olL2bgb5J5bXxWTKw2t6ghJj1lpfNVQQjDAXScfmATRFiBESkbbE4XJnV4tSoG3Wf9VOqqIJodla1mTp2lF4OFtyeUbciSNr3KtqjMvY360+CkPI1bpVL4iUpcSpKp7YaILw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wd8mJ5zfR+79oWHkdqNzD1zqjctsNe0GXT3PlKrnKbI=; b=B4lIGlsE9lFtHcPT0gnXSmgA6NyrEb/u9287/4gafKvgYzYK+FiKig4qUQwaapyobp/jZ/acGTPFuG/yrT4WUyfyMgdu46zjdAHbu2H0/ujCF+YbK5Hsl/8af5o15J/5iVDSAhzidDvDlzW6iPCtVykwIAUy0mAx5hDMwLtGVxWbc6YqBkL0bJ7H2B8j3HlaBV//45Y3Aemu1s850R/7dNk3VmJryA06G6KJ68YChmwqS6USF3ErhO1c9Ov8hhGzNI8WHXzh/0vvJKwewwWXCRIr0NbOLa8C65CYdbBoqAJnVbiMe4KZkaV9mJcAgwvJ1juexHqUpa4JuxvFIuzrgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wd8mJ5zfR+79oWHkdqNzD1zqjctsNe0GXT3PlKrnKbI=; b=uR44bQFy8bokgmurAZ/rJ+5gZctTItVtmoGbQ266Fud0+6Zxryaob+B8Re5PKsU5CFXCreAU1VmwKMl5+csS84eYyurSk2PMq/lEV9joG6IB2enUPCO6TkPxXE9gl0P7h4eVEbvsWUe+G7CNSqaUetx4jZvNsoPJO7dD22zi2KY= From: Henry Wang To: Anthony PERARD , Andrew Cooper CC: Xen-devel Subject: RE: [PATCH for-4.17] tools/libxl: Correct error message units in libxl__domain_set_paging_mempool_size() Thread-Topic: [PATCH for-4.17] tools/libxl: Correct error message units in libxl__domain_set_paging_mempool_size() Thread-Index: AQHY+2+K+dbSE+6zIE6kpdVqzhxbFq5E7LKAgACNCOA= Date: Sat, 19 Nov 2022 01:45:56 +0000 Message-ID: References: <20221118170213.2872-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 93EA12714FF6254BB8A7C4FE948BDE3F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PA4PR08MB6285:EE_|DBAEUR03FT041:EE_|DU0PR08MB9051:EE_ X-MS-Office365-Filtering-Correlation-Id: 197fa909-5f20-4a66-0fc5-08dac9cfd222 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XCt2jda+2hAH/+ZtbusbfKdy+xsWkDX7F1YjiqOhSIdGkQYAlGdLKL2pIkiRH8i7x4ByKbDC1azxhlp3p2El/GtCljumi/UUFavgqtMhUzTqjJD7CIqnpIY9Cm+ucU7y3WzTsIWrUp51xG/+6qjnYsAmSu3M61ux8nyC/1Rc9+t775ytVyN7em2XQxCnvg0h3LrhSp+gtpciNSr87fILvbRqGioTbjRFyOvJ+vXL3OhgTLnorBIAs/dTiXGJ8yfVnWliTTGek4wkhloKGlWL6i+wSq6SWDvHP3+jy1YUSLH86setcTnHbveRyyJj8XsgDkZKDBd3e+uV5dGaJrOHOevmlFrOayYDVkXhFjIJJDCGLXDqUj3keovVDWRWEL05UwYBPEy4vpXvehjdiYYjTAyhwPIkmOeo/GYTJlDi2X9y7nrfRIFIaR/v8FnPaluZtHS1i9cGSexVGvnE5amH51bbyBaFXK+C6w0yU95wHA9DGGlbmFz2dpSEXyZhByRiSDPbNCrE2wlVnrgFAUZ6/WeTMHOL8vEYTI2g5azIc3bO5qYjwUsgBUnZLHHWxDNsvXnS/YCtzT/mntwbQAy4SUtY2A5ujMPNcc7jOxIVPide2bzvpg6w82W0OEreWD2OyehJaQ58cZID64XfRuZo5tsg8+1mDcgj6cuYq4lZSARxpuDBA1YeDN2MwHaaCL8uO3Pqjf8UGL7p5nimVndBXkKvf2MGswO9qRysQiVvDR8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(366004)(451199015)(9686003)(2906002)(71200400001)(478600001)(7696005)(26005)(6506007)(15650500001)(83380400001)(38100700002)(33656002)(122000001)(52536014)(316002)(186003)(4326008)(55016003)(8676002)(5660300002)(86362001)(38070700005)(110136005)(66946007)(8936002)(41300700001)(66446008)(64756008)(66556008)(66476007)(76116006)(101420200003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6285 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6b0633c6-76db-44b8-c603-08dac9cfcd00 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mp11AB8vGAQMEJ2Fc86Cyrfd0ctyZXuSSeNYdwUu8lJ9H8C1eMc/JaNju9sWPkOt2G/a0Wi7zSXsOTbsybsP/20U872W89vfEui5rLlurMl5RgudvDMpwswQGaHJt2bRTNeihlWhlyyUeradxxwZfqJb2qGyr9S9D6aupAvizdaoAVoSttexFNRfB0u35oqR8+gz4p/eBStbZ7bVMlbtTQnNai+H4YBMJnUMNiabTHltA0pxCMl7GzykK+bOJLMVzrYhOah2Bre0i2y/ZMoWfUw/eZztmQBM5O8hPI2F4BPX9mXv96PCDBQlmflQQ6W71honUdUQF2etjg2TzXwm1UI7Tz4gy0WP8by1J3rRh20eUZZzbd/b/lTxgDgGQazSJ842yfcGq/GrRKFceZuyfBNpEqDKMYKy8oIY7FnmQy1nREXJFRWJLGQH752je66EEZUZpVvhhwhnmnSWJEFahynEP1nyk29QNABw6O15dpwzpn4qPzTFUSTkiAFrf6BlpFbX+4C1rTJf3JCiz+kXAvYxCrWYMoUYtCKpZRYOhowyFnEb4LjSBRXqqPPKiqUnGkCKEIIGK/kW+lbojakyT+jKtkZ80yFuVjk865aqpFn5CaHUE1R+ILOiMXpZY9nznyncHvmn2MJDgF/mZ8iE0GtchV/DoFi+27C601348ftJpa5n0/SkvJ0KCb3d8GtgjGdyQ170CRrtRqcS74qa1bIQdtMDB9RA1bJNIEu+ZeI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(40470700004)(36840700001)(46966006)(36860700001)(2906002)(83380400001)(33656002)(40460700003)(55016003)(70206006)(70586007)(40480700001)(41300700001)(82310400005)(86362001)(82740400003)(110136005)(7696005)(6506007)(356005)(81166007)(186003)(8936002)(5660300002)(336012)(52536014)(4326008)(8676002)(47076005)(15650500001)(316002)(26005)(9686003)(478600001)(101420200003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2022 01:46:04.7051 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 197fa909-5f20-4a66-0fc5-08dac9cfd222 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9051 Hi Anthony and Andrew, > -----Original Message----- > From: Anthony PERARD > Subject: Re: [PATCH for-4.17] tools/libxl: Correct error message units in > libxl__domain_set_paging_mempool_size() >=20 > On Fri, Nov 18, 2022 at 05:02:13PM +0000, Andrew Cooper wrote: > > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.= c > > index b59bbe00bb30..68ad9763b6ba 100644 > > --- a/tools/libs/light/libxl_dom.c > > +++ b/tools/libs/light/libxl_dom.c > > @@ -1459,7 +1459,8 @@ int libxl__domain_set_paging_mempool_size( > > int r =3D xc_set_paging_mempool_size(CTX->xch, domid, shadow_mem); > > if (r) { > > LOGED(ERROR, domid, > > - "Failed to set paging mempool size to %"PRIu64"kB", > shadow_mem); > > + "Failed to set paging mempool size to %lukB", > > + d_config->b_info.shadow_memkb); >=20 > Unless I miss read, `shadow_memkb` is also "uint64_t", so I'm pretty > sure the format doesn't need to be changed, and we should keep using > PRIu64. I did a grep in current code, and: In libs/light/libxl_types.idl, "shadow_memkb" is defined as MemKB, which is MemKB =3D UInt(64, init_val =3D "LIBXL_MEMKB_DEFAULT", json_gen_fn =3D "= libxl__uint64_gen_json") so yes it is 64bit indeed. Using PRIu64 seems correct. Kind regards, Henry >=20 > With that changed: Acked-by: Anthony PERARD >=20 > Thanks, >=20 > -- > Anthony PERARD From xen-devel-bounces@lists.xenproject.org Sat Nov 19 03:56:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 03:56:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.445996.701454 (Exim 4.92) (envelope-from ) id 1owEyA-0001Al-V7; Sat, 19 Nov 2022 03:56:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 445996.701454; Sat, 19 Nov 2022 03:56:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owEyA-0001Ae-Rg; Sat, 19 Nov 2022 03:56:42 +0000 Received: by outflank-mailman (input) for mailman id 445996; Sat, 19 Nov 2022 03:56:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owEy9-0001AU-F4; Sat, 19 Nov 2022 03:56:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owEy9-00046z-C0; Sat, 19 Nov 2022 03:56:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owEy9-0008Ns-0Z; Sat, 19 Nov 2022 03:56:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owEy9-0001GQ-0B; Sat, 19 Nov 2022 03:56:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=puQRh/Euq6rv1MI5yCWYt/IjnZv8MKRHo/xRioADbJ8=; b=OooISTM0feN6pJ2cOpj8R7pmIm jRUQXThGqyp9hf9nJnv2uOV+8G8ytZN3BX+Mn6e3Pn1/QhNfu1im0eqjhYjZXglG10dIUHKMIdY1l 5gtjY32wHn5esTi36zPEh54Zf/zEmircyV+N1x2lIfZGTQFOcUxtsvPS+vDLS22qVBik=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174816: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=84368d882b9688bfac77ce48d33b1e20a4e4a787 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sat, 19 Nov 2022 03:56:41 +0000 flight 174816 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174816/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 84368d882b9688bfac77ce48d33b1e20a4e4a787 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 42 days Failing since 173470 2022-10-08 06:21:34 Z 41 days 72 attempts Testing same since 174808 2022-11-17 23:41:39 Z 1 days 3 attempts ------------------------------------------------------------ 1749 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 165602 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 19 05:58:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 05:58:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446008.701472 (Exim 4.92) (envelope-from ) id 1owGrT-0006br-N3; Sat, 19 Nov 2022 05:57:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446008.701472; Sat, 19 Nov 2022 05:57:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owGrT-0006bk-KF; Sat, 19 Nov 2022 05:57:55 +0000 Received: by outflank-mailman (input) for mailman id 446008; Sat, 19 Nov 2022 05:57:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owGrS-0006ba-DK; Sat, 19 Nov 2022 05:57:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owGrS-00079L-AB; Sat, 19 Nov 2022 05:57:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owGrR-00070z-RT; Sat, 19 Nov 2022 05:57:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owGrR-0007et-Qz; Sat, 19 Nov 2022 05:57:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=e11FqVXoStzUTqw5ONUVOZxDW9DDF8lD5W1XpXmW4PA=; b=0Z3B+JtkUbB3fOmYNM13YsbGbM t9zmDEyMUSDJ7WbKs+GxorffS1ovN3tKJiJIY1nUHoj1WyhX21UuApeJR6Kt3rE+4YGTEBlyZ2wnI uBfC1cqJR9yg0IHff/tBd6PuwpSCP+7lFHtAMuM04483zANlt3XrOY3CpxGuaINeckUM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174819: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-livepatch:xen-boot:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=db8fa01c61db0317a9ee947925226234c65d48e8 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Sat, 19 Nov 2022 05:57:53 +0000 flight 174819 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174819/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 174797 Tests which are failing intermittently (not blocking): test-amd64-i386-livepatch 8 xen-boot fail pass in 174814 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen db8fa01c61db0317a9ee947925226234c65d48e8 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 2 days Testing same since 174809 2022-11-18 00:06:55 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch fail test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit db8fa01c61db0317a9ee947925226234c65d48e8 Author: Andrew Cooper Date: Thu Oct 20 12:14:30 2022 +0100 xen/arm: Correct the p2m pool size calculations Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit bd87315a603bf25e869e6293f7db7b1024d67999 Author: Andrew Cooper Date: Thu Oct 20 12:13:46 2022 +0100 tools/tests: Unit test for paging mempool size Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit 22b20bd98c025e06525410e3ab3494d5e63489f7 Author: Andrew Cooper Date: Fri Oct 21 14:13:00 2022 +0100 xen: Introduce non-broken hypercalls for the paging mempool size The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 Author: Andrew Cooper Date: Mon Nov 14 21:47:59 2022 +0000 x86/hvm: Revert per-domain APIC acceleration support I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisted in due course. Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Fixes: 6b2b9b340509 ("x86: report Interrupt Controller Virtualization capabilities") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Nov 19 08:28:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 08:28:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446030.701489 (Exim 4.92) (envelope-from ) id 1owJCr-0006q9-RZ; Sat, 19 Nov 2022 08:28:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446030.701489; Sat, 19 Nov 2022 08:28:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owJCr-0006q2-OX; Sat, 19 Nov 2022 08:28:09 +0000 Received: by outflank-mailman (input) for mailman id 446030; Sat, 19 Nov 2022 08:28:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owJCp-0006pw-TI for xen-devel@lists.xen.org; Sat, 19 Nov 2022 08:28:09 +0000 Received: from server.eikelenboom.it (server.eikelenboom.it [91.121.65.215]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 17070198-67e4-11ed-8fd2-01056ac49cbb; Sat, 19 Nov 2022 09:28:06 +0100 (CET) Received: from 131-195-250-62.ftth.glasoperator.nl ([62.250.195.131]:46996 helo=[172.16.1.212]) by server.eikelenboom.it with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1owJDZ-0001cM-Jm; Sat, 19 Nov 2022 09:28:53 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17070198-67e4-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=eikelenboom.it; s=20180706; h=Content-Transfer-Encoding:Content-Type: Subject:From:Cc:To:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DJreaUMvt4zA0FCli4gW45voLTfYum2Sr88dejDCL4o=; b=Bgk45hLnCBxrR7FghkDkLpbkG/ kVkd17OfU2UZVIKRFbrCpf9wfzuVPRPSQGwjUpFPEq4YFkrHe+Hv4dRsbw1FMNDcjPe6Ix8vZpkW9 WvMHqOKM8OAt5trzx149PgwazaUWtB5TnfemqDokgn9NGn9xKFmwufMpIOuldh41CrGE=; Message-ID: <42579618-f8e2-9fd2-0b6c-f2c87f7c57a6@eikelenboom.it> Date: Sat, 19 Nov 2022 09:28:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Content-Language: nl-NL, en-US To: Juergen Gross , Yu Zhao Cc: linux-kernel , Xen-devel From: Sander Eikelenboom Subject: Xen-unstable Linux-6.1.0-rc5 BUG: unable to handle page fault for address: ffff8880083374d0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Yu / Juergen, This night I got a dom0 kernel crash on my new Ryzen box running Xen-unstable and a Linux-6.1.0-rc5 kernel. I did enable the new and shiny MGLRU, could this be related ? -- Sander Nov 19 06:30:11 serveerstertje kernel: [68959.647371] BUG: unable to handle page fault for address: ffff8880083374d0 Nov 19 06:30:11 serveerstertje kernel: [68959.663555] #PF: supervisor write access in kernel mode Nov 19 06:30:11 serveerstertje kernel: [68959.677542] #PF: error_code(0x0003) - permissions violation Nov 19 06:30:11 serveerstertje kernel: [68959.691181] PGD 3026067 P4D 3026067 PUD 3027067 PMD 7fee5067 PTE 8010000008337065 Nov 19 06:30:11 serveerstertje kernel: [68959.705084] Oops: 0003 [#1] PREEMPT SMP NOPTI Nov 19 06:30:11 serveerstertje kernel: [68959.718710] CPU: 7 PID: 158 Comm: kswapd0 Not tainted 6.1.0-rc5-20221118-doflr-mac80211debug+ #1 Nov 19 06:30:11 serveerstertje kernel: [68959.732457] Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./B450 Pro4 R2.0, BIOS P5.60 10/20/2022 Nov 19 06:30:11 serveerstertje kernel: [68959.746391] RIP: e030:pmdp_test_and_clear_young+0x25/0x40 Nov 19 06:30:11 serveerstertje kernel: [68959.760294] Code: 00 00 00 66 90 48 b9 ff ff 1f 00 00 00 f0 ff 48 8b 02 48 be ff 0f 00 00 00 00 f0 ff a8 80 48 0f 44 ce 48 21 c8 83 e0 20 74 0c 48 0f ba 32 05 0f 92 c0 0f b6 c0 c3 cc cc c Nov 19 06:30:11 serveerstertje kernel: [68959.787908] RSP: e02b:ffffc9000161f940 EFLAGS: 00010202 Nov 19 06:30:11 serveerstertje kernel: [68959.801637] RAX: 0000000000000020 RBX: 0000000000000000 RCX: fff0000000000fff Nov 19 06:30:11 serveerstertje kernel: [68959.815243] RDX: ffff8880083374d0 RSI: fff0000000000fff RDI: ffff888010f41000 Nov 19 06:30:11 serveerstertje kernel: [68959.828683] RBP: ffffc9000161fa70 R08: 000ffffffffff000 R09: 00005654134b5000 Nov 19 06:30:11 serveerstertje kernel: [68959.842026] R10: 000000000000689e R11: 0000000000000000 R12: ffff8880083374d0 Nov 19 06:30:11 serveerstertje kernel: [68959.855214] R13: ffff88807fc1a000 R14: ffff8880083374d0 R15: 0000000000000000 Nov 19 06:30:11 serveerstertje kernel: [68959.868118] FS: 0000000000000000(0000) GS:ffff8880801c0000(0000) knlGS:0000000000000000 Nov 19 06:30:11 serveerstertje kernel: [68959.880689] CS: e030 DS: 0000 ES: 0000 CR0: 0000000080050033 Nov 19 06:30:11 serveerstertje kernel: [68959.893457] CR2: ffff8880083374d0 CR3: 000000000f33c000 CR4: 0000000000050660 Nov 19 06:30:11 serveerstertje kernel: [68959.906377] Call Trace: Nov 19 06:30:11 serveerstertje kernel: [68959.919219] Nov 19 06:30:11 serveerstertje kernel: [68959.931844] walk_pmd_range_locked.isra.87+0x2e9/0x4e0 Nov 19 06:30:11 serveerstertje kernel: [68959.944840] walk_pud_range+0x69c/0x980 Nov 19 06:30:11 serveerstertje kernel: [68959.957562] walk_pgd_range+0xe9/0x810 Nov 19 06:30:11 serveerstertje kernel: [68959.970161] ? mt_find+0x1f8/0x3c0 Nov 19 06:30:11 serveerstertje kernel: [68959.982808] __walk_page_range+0x17b/0x180 Nov 19 06:30:11 serveerstertje kernel: [68959.995440] walk_page_range+0x106/0x170 Nov 19 06:30:11 serveerstertje kernel: [68960.008014] try_to_inc_max_seq+0x40a/0x9e0 Nov 19 06:30:11 serveerstertje kernel: [68960.020262] lru_gen_age_node+0x1d3/0x280 Nov 19 06:30:11 serveerstertje kernel: [68960.032222] ? shrink_node+0x294/0x710 Nov 19 06:30:11 serveerstertje kernel: [68960.044129] balance_pgdat+0x1c3/0x650 Nov 19 06:30:11 serveerstertje kernel: [68960.055995] ? prepare_to_wait_event+0x110/0x110 Nov 19 06:30:11 serveerstertje kernel: [68960.068022] kswapd+0x1f0/0x3a0 Nov 19 06:30:11 serveerstertje kernel: [68960.079997] ? prepare_to_ From xen-devel-bounces@lists.xenproject.org Sat Nov 19 10:32:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 10:32:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446053.701512 (Exim 4.92) (envelope-from ) id 1owL8a-0004KY-3s; Sat, 19 Nov 2022 10:31:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446053.701512; Sat, 19 Nov 2022 10:31:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owL8a-0004KR-0i; Sat, 19 Nov 2022 10:31:52 +0000 Received: by outflank-mailman (input) for mailman id 446053; Sat, 19 Nov 2022 10:31:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owL8Y-0004KH-3R; Sat, 19 Nov 2022 10:31:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owL8X-0005CQ-VV; Sat, 19 Nov 2022 10:31:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owL8X-0005hc-Fe; Sat, 19 Nov 2022 10:31:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owL8X-0001Yc-FF; Sat, 19 Nov 2022 10:31:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Cx91Qd3/3gQDZV38ZSaT9KGX8Z4RI0vtsAnImtetuUQ=; b=fC9jroAE1tYZjemZvL0pRq2LqB 7914U/8iawJNEeVX+f3+E02uakHkIytIv2ekvZ1yK063miiCRtkZEkvb6XZqkHkZ4F3H6z41PmDbe WVBcSwDYB/lTFZywIcJljtcbfrMHNKlka2ovAD+vZKnZ251I0CahzhSqiO0UVem499iM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174824: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=0b17b1b0a48de6d19404014ff5f0303ab9782028 X-Osstest-Versions-That: libvirt=0be7d0f1cb257260758e38ffafcef5d2e0b43b86 From: osstest service owner Date: Sat, 19 Nov 2022 10:31:49 +0000 flight 174824 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174824/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174811 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174811 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174811 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 0b17b1b0a48de6d19404014ff5f0303ab9782028 baseline version: libvirt 0be7d0f1cb257260758e38ffafcef5d2e0b43b86 Last test of basis 174811 2022-11-18 04:20:09 Z 1 days Testing same since 174824 2022-11-19 04:18:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Göran Uddeborg Jiang Jiacheng Ján Tomko 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 0be7d0f1cb..0b17b1b0a4 0b17b1b0a48de6d19404014ff5f0303ab9782028 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Nov 19 11:07:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 11:07:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446043.701533 (Exim 4.92) (envelope-from ) id 1owLgk-0008Db-76; Sat, 19 Nov 2022 11:07:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446043.701533; Sat, 19 Nov 2022 11:07:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owLgk-0008D0-2e; Sat, 19 Nov 2022 11:07:10 +0000 Received: by outflank-mailman (input) for mailman id 446043; Sat, 19 Nov 2022 09:02:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owJkD-0003Ee-FS for xen-devel@lists.xenproject.org; Sat, 19 Nov 2022 09:02:37 +0000 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e8be1769-67e8-11ed-91b6-6bf2151ebd3b; Sat, 19 Nov 2022 10:02:36 +0100 (CET) Received: from dggpeml500023.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NDndf0h6HzFqQ9; Sat, 19 Nov 2022 16:59:18 +0800 (CST) Received: from ubuntu1804.huawei.com (10.67.174.58) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 19 Nov 2022 17:02:29 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8be1769-67e8-11ed-91b6-6bf2151ebd3b From: Xiu Jianfeng To: , , , , , , , CC: , , Subject: [PATCH 0/2] x86/xen: Fix memory leak issue Date: Sat, 19 Nov 2022 16:59:21 +0800 Message-ID: <20221119085923.114889-1-xiujianfeng@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.174.58] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500023.china.huawei.com (7.185.36.114) X-CFilter-Loop: Reflected The new string allocated by kasprintf() is leaked on error path Xiu Jianfeng (2): x86/xen: Fix memory leak in xen_smp_intr_init{_pv}() x86/xen: Fix memory leak in xen_init_lock_cpu() arch/x86/xen/smp.c | 16 ++++++++++++---- arch/x86/xen/smp_pv.c | 8 ++++++-- arch/x86/xen/spinlock.c | 3 ++- 3 files changed, 20 insertions(+), 7 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Nov 19 11:07:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 11:07:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446047.701540 (Exim 4.92) (envelope-from ) id 1owLgk-0008KU-Gn; Sat, 19 Nov 2022 11:07:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446047.701540; Sat, 19 Nov 2022 11:07:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owLgk-0008IO-CJ; Sat, 19 Nov 2022 11:07:10 +0000 Received: by outflank-mailman (input) for mailman id 446047; Sat, 19 Nov 2022 09:02:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owJkG-0003FI-OH for xen-devel@lists.xenproject.org; Sat, 19 Nov 2022 09:02:40 +0000 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e8c0e0df-67e8-11ed-8fd2-01056ac49cbb; Sat, 19 Nov 2022 10:02:38 +0100 (CET) Received: from dggpeml500023.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NDnhk1qhNzHvsQ; Sat, 19 Nov 2022 17:01:58 +0800 (CST) Received: from ubuntu1804.huawei.com (10.67.174.58) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 19 Nov 2022 17:02:31 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8c0e0df-67e8-11ed-8fd2-01056ac49cbb From: Xiu Jianfeng To: , , , , , , , CC: , , Subject: [PATCH 2/2] x86/xen: Fix memory leak in xen_init_lock_cpu() Date: Sat, 19 Nov 2022 16:59:23 +0800 Message-ID: <20221119085923.114889-3-xiujianfeng@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221119085923.114889-1-xiujianfeng@huawei.com> References: <20221119085923.114889-1-xiujianfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.174.58] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500023.china.huawei.com (7.185.36.114) X-CFilter-Loop: Reflected In xen_init_lock_cpu(), the @name has allocated new string by kasprintf(), if bind_ipi_to_irqhandler() fails, it should be freed, otherwise may lead to a memory leak issue, fix it. Fixes: 2d9e1e2f58b5 ("xen: implement Xen-specific spinlocks") Signed-off-by: Xiu Jianfeng --- arch/x86/xen/spinlock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c index 043c73dfd2c9..156d3e04c9ef 100644 --- a/arch/x86/xen/spinlock.c +++ b/arch/x86/xen/spinlock.c @@ -86,7 +86,8 @@ void xen_init_lock_cpu(int cpu) disable_irq(irq); /* make sure it's never delivered */ per_cpu(lock_kicker_irq, cpu) = irq; per_cpu(irq_name, cpu) = name; - } + } else + kfree(name); printk("cpu %d spinlock event irq %d\n", cpu, irq); } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Nov 19 11:07:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 11:07:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446042.701528 (Exim 4.92) (envelope-from ) id 1owLgj-0008AW-Tc; Sat, 19 Nov 2022 11:07:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446042.701528; Sat, 19 Nov 2022 11:07:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owLgj-0008AP-Qz; Sat, 19 Nov 2022 11:07:09 +0000 Received: by outflank-mailman (input) for mailman id 446042; Sat, 19 Nov 2022 09:02:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owJkC-0003Ee-EZ for xen-devel@lists.xenproject.org; Sat, 19 Nov 2022 09:02:36 +0000 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e6ad8afc-67e8-11ed-91b6-6bf2151ebd3b; Sat, 19 Nov 2022 10:02:34 +0100 (CET) Received: from dggpeml500023.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NDndf6QTTzFqQX; Sat, 19 Nov 2022 16:59:18 +0800 (CST) Received: from ubuntu1804.huawei.com (10.67.174.58) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 19 Nov 2022 17:02:30 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6ad8afc-67e8-11ed-91b6-6bf2151ebd3b From: Xiu Jianfeng To: , , , , , , , CC: , , Subject: [PATCH 1/2] x86/xen: Fix memory leak in xen_smp_intr_init{_pv}() Date: Sat, 19 Nov 2022 16:59:22 +0800 Message-ID: <20221119085923.114889-2-xiujianfeng@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221119085923.114889-1-xiujianfeng@huawei.com> References: <20221119085923.114889-1-xiujianfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.174.58] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500023.china.huawei.com (7.185.36.114) X-CFilter-Loop: Reflected These local variables @{resched|pmu|callfunc...}_name saves the new string allocated by kasprintf(), and when bind_{v}ipi_to_irqhandler() fails, it goes to the @fail tag, and calls xen_smp_intr_free{_pv}() to free resource, however the new string is not saved, which cause a memory leak issue. fix it. Fixes: 9702785a747a ("i386: move xen") Signed-off-by: Xiu Jianfeng --- arch/x86/xen/smp.c | 16 ++++++++++++---- arch/x86/xen/smp_pv.c | 8 ++++++-- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c index c3e1f9a7d43a..6e9426b6b18a 100644 --- a/arch/x86/xen/smp.c +++ b/arch/x86/xen/smp.c @@ -71,8 +71,10 @@ int xen_smp_intr_init(unsigned int cpu) IRQF_PERCPU|IRQF_NOBALANCING, resched_name, NULL); - if (rc < 0) + if (rc < 0) { + kfree(resched_name); goto fail; + } per_cpu(xen_resched_irq, cpu).irq = rc; per_cpu(xen_resched_irq, cpu).name = resched_name; @@ -83,8 +85,10 @@ int xen_smp_intr_init(unsigned int cpu) IRQF_PERCPU|IRQF_NOBALANCING, callfunc_name, NULL); - if (rc < 0) + if (rc < 0) { + kfree(callfunc_name); goto fail; + } per_cpu(xen_callfunc_irq, cpu).irq = rc; per_cpu(xen_callfunc_irq, cpu).name = callfunc_name; @@ -94,8 +98,10 @@ int xen_smp_intr_init(unsigned int cpu) xen_debug_interrupt, IRQF_PERCPU | IRQF_NOBALANCING, debug_name, NULL); - if (rc < 0) + if (rc < 0) { + kfree(debug_name); goto fail; + } per_cpu(xen_debug_irq, cpu).irq = rc; per_cpu(xen_debug_irq, cpu).name = debug_name; } @@ -107,8 +113,10 @@ int xen_smp_intr_init(unsigned int cpu) IRQF_PERCPU|IRQF_NOBALANCING, callfunc_name, NULL); - if (rc < 0) + if (rc < 0) { + kfree(callfunc_name); goto fail; + } per_cpu(xen_callfuncsingle_irq, cpu).irq = rc; per_cpu(xen_callfuncsingle_irq, cpu).name = callfunc_name; diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c index 480be82e9b7b..228d0207380c 100644 --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -124,8 +124,10 @@ int xen_smp_intr_init_pv(unsigned int cpu) IRQF_PERCPU|IRQF_NOBALANCING, callfunc_name, NULL); - if (rc < 0) + if (rc < 0) { + kfree(callfunc_name); goto fail; + } per_cpu(xen_irq_work, cpu).irq = rc; per_cpu(xen_irq_work, cpu).name = callfunc_name; @@ -135,8 +137,10 @@ int xen_smp_intr_init_pv(unsigned int cpu) xen_pmu_irq_handler, IRQF_PERCPU|IRQF_NOBALANCING, pmu_name, NULL); - if (rc < 0) + if (rc < 0) { + kfree(pmu_name); goto fail; + } per_cpu(xen_pmu_irq, cpu).irq = rc; per_cpu(xen_pmu_irq, cpu).name = pmu_name; } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Nov 19 13:28:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 13:28:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446092.701573 (Exim 4.92) (envelope-from ) id 1owNsl-0007wL-RQ; Sat, 19 Nov 2022 13:27:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446092.701573; Sat, 19 Nov 2022 13:27:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owNsl-0007wE-Ov; Sat, 19 Nov 2022 13:27:43 +0000 Received: by outflank-mailman (input) for mailman id 446092; Sat, 19 Nov 2022 13:27:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owNsj-0007w4-US; Sat, 19 Nov 2022 13:27:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owNsj-0000WN-Ru; Sat, 19 Nov 2022 13:27:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owNsj-00032K-Fd; Sat, 19 Nov 2022 13:27:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owNsj-0007gf-F9; Sat, 19 Nov 2022 13:27:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sZbcDKJv0QMVTrkZLv3WdNU2upnGI11PZlyrhgHgvm8=; b=yU8BX7++p+5BKex1KMr2fSNz3k kqQmb5oDz0MirBfrdFxWWA0lWQfJknRzQLmTFzEZIWJEPv0ADUUxC49iV4FYU0pFlsDLIeNc+Lbvm bDtGeVQ5teBZqCCeh6mYCJ5S0FNSzEcDea1tiBEBGkzEowgcgXoglkn/60x/jO2eIMzg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174823: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=fe24a97cf2543e8832e7a2124802e5c32aac05aa X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sat, 19 Nov 2022 13:27:41 +0000 flight 174823 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174823/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux fe24a97cf2543e8832e7a2124802e5c32aac05aa baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 42 days Failing since 173470 2022-10-08 06:21:34 Z 42 days 73 attempts Testing same since 174823 2022-11-19 03:58:29 Z 0 days 1 attempts ------------------------------------------------------------ 1791 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 169553 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 19 14:10:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 14:10:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446103.701585 (Exim 4.92) (envelope-from ) id 1owOXq-00059O-1r; Sat, 19 Nov 2022 14:10:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446103.701585; Sat, 19 Nov 2022 14:10:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owOXp-00059H-UF; Sat, 19 Nov 2022 14:10:09 +0000 Received: by outflank-mailman (input) for mailman id 446103; Sat, 19 Nov 2022 14:10:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owOXo-000597-8C; Sat, 19 Nov 2022 14:10:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owOXo-0001RJ-4q; Sat, 19 Nov 2022 14:10:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owOXn-0004Av-Oo; Sat, 19 Nov 2022 14:10:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owOXn-0003SF-OM; Sat, 19 Nov 2022 14:10:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=28c8EyuzeulJMa0o9Dxk/UQaELHVjTUSp8nnWXbRk0Q=; b=OlJ9G5fK69WkuICHxqKoiwo/6p U//vGbenEPCenmfevv5n/1cOHAqrTV4Mm3YHFcKdpSmfyUMkNGAMxTBUl03ZjqVcQZFKmSZ3dm6z9 r3Z1fd6ieBKqFaXvSDn/rQyChVRnmVCeVCYvV5f+Osey5xAk8whSxRt3ofLAO4PyUiwI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174826: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-livepatch:xen-boot:fail:heisenbug xen-unstable:test-arm64-arm64-examine:reboot:fail:heisenbug xen-unstable:test-arm64-arm64-xl:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=db8fa01c61db0317a9ee947925226234c65d48e8 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Sat, 19 Nov 2022 14:10:07 +0000 flight 174826 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174826/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 174797 Tests which are failing intermittently (not blocking): test-amd64-i386-livepatch 8 xen-boot fail in 174819 pass in 174826 test-arm64-arm64-examine 8 reboot fail pass in 174819 test-arm64-arm64-xl 18 guest-start/debian.repeat fail pass in 174819 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen db8fa01c61db0317a9ee947925226234c65d48e8 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 2 days Testing same since 174809 2022-11-18 00:06:55 Z 1 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit db8fa01c61db0317a9ee947925226234c65d48e8 Author: Andrew Cooper Date: Thu Oct 20 12:14:30 2022 +0100 xen/arm: Correct the p2m pool size calculations Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit bd87315a603bf25e869e6293f7db7b1024d67999 Author: Andrew Cooper Date: Thu Oct 20 12:13:46 2022 +0100 tools/tests: Unit test for paging mempool size Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit 22b20bd98c025e06525410e3ab3494d5e63489f7 Author: Andrew Cooper Date: Fri Oct 21 14:13:00 2022 +0100 xen: Introduce non-broken hypercalls for the paging mempool size The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 Author: Andrew Cooper Date: Mon Nov 14 21:47:59 2022 +0000 x86/hvm: Revert per-domain APIC acceleration support I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisted in due course. Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Fixes: 6b2b9b340509 ("x86: report Interrupt Controller Virtualization capabilities") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Nov 19 14:37:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 14:37:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446114.701601 (Exim 4.92) (envelope-from ) id 1owOxz-00088h-AS; Sat, 19 Nov 2022 14:37:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446114.701601; Sat, 19 Nov 2022 14:37:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owOxz-00088a-7q; Sat, 19 Nov 2022 14:37:11 +0000 Received: by outflank-mailman (input) for mailman id 446114; Sat, 19 Nov 2022 14:37:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owOxx-00088P-GU for xen-devel@lists.xenproject.org; Sat, 19 Nov 2022 14:37:09 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a4b9f479-6817-11ed-91b6-6bf2151ebd3b; Sat, 19 Nov 2022 15:37:07 +0100 (CET) Received: by mail-ej1-x62e.google.com with SMTP id gv23so19492807ejb.3 for ; Sat, 19 Nov 2022 06:37:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4b9f479-6817-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MHOa+D8mpRhpdgnZXN5k9URMGupIKtlcB4yfQ7rRjso=; b=YpkFXoMqkgDKSItLrDTJw6yO2The++PAUc34DHgUev0QspSdPd+pa/bAtNixW376AD ZyvNOq5ojGPlthrP8SKjYt5Yq6D38pirzObDG7BXRxoYTEEp4AD8Anxv7CAMAEHRr1lz AAnkDsEwYodQTWOfGa91DxWw1dfnRDFOiu+NxTC83u5sut1L/X8MlmywQR8xbwm/4NmF keEHp4Gq6D76r8mAebQAU/cqDallo76a9I/tSEf6XHSyoOzLCw1i+XngGKcVC+6teT9c 1QlBbqlCtulxKavNIG8bJIcBBZDH4D8Eb3//Sa5p2CIYrNadZCB53B4w1BPwIWIIAKWu 7lbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MHOa+D8mpRhpdgnZXN5k9URMGupIKtlcB4yfQ7rRjso=; b=2ILJmKRgDY5TOFGl/vhQRXOAxEf/enntdeIgk6hRIoF9o6Ib074tO7Llyy2OBUtTX7 QvpeqGkzc9MApqrgIObd0E4l7/bysFcwxow0B/1w3NgK0o2z+sr4WZjB4II6885eb++V 3s4QhLGmX5Xd7KqrDzFO5ucdIQTJFnmw2b5zAWSrJ1s2O8d3TI1SS7KAHs0CpRyqB7Ha +SksIVXGGhyxCEQX1UL5ddirQmVXMpvziXj2z+6GnTwBgERdEq9xojuR2V7MFEJaHZHe 69Ui1I7KwGlQA5KoppeA2VHrYPKiN0I9oNgNbm4jmSqjJ4ghw4ZyxfWZOX0uQLvFzElG jqeg== X-Gm-Message-State: ANoB5pm6C0YdbjVoXfKYka6ItC/JtvXSTFEL2/K2Ih8RmXayyO968m5Q Nm6zGrDScjBh6icVFVJ1hVd0/fInvq8mAGE4hkg= X-Google-Smtp-Source: AA0mqf4MO12erJ/AziUOpMWmAip6juEbRm46sbjaHB2toJ1l3Odf8nhwsShVU984UjItUKU8PAzbmjNjdUIomTFyPBo= X-Received: by 2002:a17:906:65c4:b0:7ad:d250:b907 with SMTP id z4-20020a17090665c400b007add250b907mr9399864ejn.737.1668868627066; Sat, 19 Nov 2022 06:37:07 -0800 (PST) MIME-Version: 1.0 References: <20221118154931.1928298-1-marmarek@invisiblethingslab.com> In-Reply-To: From: Jason Andryuk Date: Sat, 19 Nov 2022 09:36:54 -0500 Message-ID: Subject: Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Marek, On Fri, Nov 18, 2022 at 4:46 PM Marek Marczykowski-G=C3=B3recki wrote: > > On Fri, Nov 18, 2022 at 03:46:47PM -0500, Jason Andryuk wrote: > > On Fri, Nov 18, 2022 at 10:50 AM Marek Marczykowski-G=C3=B3recki > > wrote: > > > > > > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked unt= il > > > the table is filled. Then it disables INTx just before clearing MASKA= LL > > > bit. Currently this approach is rejected by xen-pciback. > > > According to the PCIe spec, device cannot use INTx when MSI/MSI-X is > > > enabled (in other words: enabling MSI/MSI-X implicitly disables INTx)= . > > > > > > Change the logic to consider INTx disabled if MSI/MSI-X is enabled. T= his > > > applies to three places: > > > - checking currently enabled interrupts type, > > > - transition to MSI/MSI-X - where INTx would be implicitly disabled, > > > - clearing INTx disable bit - which can be allowed even if MSI/MSI-X= is > > > enabled, as device should consider INTx disabled anyway in that ca= se > > > > > > Fixes: 5e29500eba2a ("xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKA= LL too") > > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > > > --- > > > Changes in v3: > > > - allow clearing INTx regardless of MSI/MSI-X state, to be consisten= t > > > with enabling MSI/MSI-X > > > Changes in v2: > > > - restructure the patch to consider not only MASKALL bit, but enabli= ng > > > MSI/MSI-X generally, without explicitly disabling INTx first > > > --- > > > > I was trying to test your xen-pciback v3 patch, and I am having > > assignment fail consistently now. It is actually failing to > > quarantine to domIO in the first place, which matches the failure from > > the other day (when I more carefully read through the logs). It now > > consistently fails to quarantine on every boot unlike the other day > > where it happened once. > > Does this include the very first assignment too, or only after domain > reboot? If the latter, maybe some cleanup missed clearing MASKALL? It's the quarantine during dom0 boot that fails. Later assignment during VM boot fails. I tried warm reboots and cold boots and it happened both times. I also modified my initrd to halt in there and checked the config space. MASKALL wasn't set at that time. I need to double check - MASKALL may have been unset after dom0 booted in that case. I'll test more to figure when and how MASKALL is getting set. > FWIW, the patch applied to Qubes > (https://github.com/QubesOS/qubes-linux-kernel/pull/680) seems to work > fine (the full test run is still in progress, but I see some green marks > already). Does Qubes quarantine devices explicitly, or are they in dom0 and libvirt/libxl just assigns them when a domain boots? > > I added some printks and it 's getting -EBUSY from pdev_msix_assign() > > which means pci_reset_msix_state() is failing: > > if ( pci_conf_read16(pdev->sbdf, msix_control_reg(pos)) & > > PCI_MSIX_FLAGS_MASKALL ) > > return -EBUSY; > > > > # lspci -vv -s 14.3 > > ... > > Capabilities: [80] MSI-X: Enable- Count=3D16 Masked+ > > Vector table: BAR=3D0 offset=3D00002000 > > PBA: BAR=3D0 offset=3D00003000 > > > > So it looks like MASKALL is set and prevents assignment. > > > > setpci -s 00:14.3 82.W=3Df > > cleared that out for me and I could assign the device. > > > > My dom0 boots, it runs flask-label-pci for a set of PCI devices > > (including iwlwifi), then xl pci-assignable-add for all PCI devices > > which will be passed through, then a little later it boots the > > associated domains. Dom0 does not have a driver for iwlwifi. > > > > I'll have to investigate more to see how MASKALL is getting set. This > > had not been an issue before your recent patches. > > I guess before the patches nothing set anything in MSI-X capability, > because it was hidden... Well, stubdom hasn't even booted when, so it would be the Xen or pciback change to modify MASKALL? > Anyway, to support my cleanup hypothesis, I tried to destroy a > PCI-having domain, and it left MSI-X enabled (at least according to the > config space). MASKALL was _not_ set, but I haven't checked masking of > individual vectors. TBH, I'm not sure what should be responsible for the > MSI-X cleanup after guest destroy. Should it be Xen? Qemu? Pciback? > Pciback calls PHYSDEVOP_{prepare,release}_msix only when > binding/unbinding from the device (so - xl pci-assignable-{add,remove}), > so this isn't the right place. I need to review all this code to give a meaningful response. Would xen-pciback set MASKALL when it binds a device? That happens before xl pci-assignable-add tries to quarantine (assign to to domIO). > Should that be in Xen, in deassign_device() (part of > DOMCTL_deassign_device)? It seems to me that Xen needs to ultimately disable the device. Thanks, Jason From xen-devel-bounces@lists.xenproject.org Sat Nov 19 14:37:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 14:37:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446116.701612 (Exim 4.92) (envelope-from ) id 1owOyY-0000Al-JO; Sat, 19 Nov 2022 14:37:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446116.701612; Sat, 19 Nov 2022 14:37:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owOyY-0000Ae-Gp; Sat, 19 Nov 2022 14:37:46 +0000 Received: by outflank-mailman (input) for mailman id 446116; Sat, 19 Nov 2022 14:37:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owOyX-0000AR-Hy for xen-devel@lists.xenproject.org; Sat, 19 Nov 2022 14:37:45 +0000 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [2a00:1450:4864:20::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9fc3911-6817-11ed-8fd2-01056ac49cbb; Sat, 19 Nov 2022 15:37:43 +0100 (CET) Received: by mail-ej1-x62d.google.com with SMTP id me22so2865998ejb.8 for ; Sat, 19 Nov 2022 06:37:43 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9fc3911-6817-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6KGEGZSA6ReBRUx4XvCy0uvdFeo4yZkejk6eMcKN1Zc=; b=n5AeAWUDkzI5JnNvTgTqQzYYZxtNqKLSf57P21/AGvMv2TJoAEB9gvksffv6+4HBEm /ourTFBAkiN2d4iA15tQmj5gxYwkdWM0MvVGKQ+ApGNzgkRwXQNTSaeIS2rpLlN96c9C YqL8+u1HTLR/L4IQxoSjMBALfBdHNS+jxrzu5hUO0TWJZbqi2ce2c07YqxI3Z7U1zsIZ 2oK+g1Y+HzvhxhLjeunKgtoVC53T2lEAEq1ZtOFj3zk6XoB+7uzw0XhcvLNW3XcbGPJl SQpC+TjaYSQmIzJSJmo0wxANzCv/q4zge6zzFZWUHMLKWa7JwcVQuX/94j2V0BPV51kz alhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6KGEGZSA6ReBRUx4XvCy0uvdFeo4yZkejk6eMcKN1Zc=; b=U92FBLQO+pAje0sxDk4JhSKNlxbVDk56O7OnCbVIy0YPWNLidAOc3dW5P5Ey75aPlx ZsFR9I58x4W0KzWIlef2uGfIn8ZUfikme5m1Bp7ANMnSFcmUnirMHfjkWiuLoMOnkaTv cvZdEZAmmKZ+qiL7o5cdz24Q4AhmLwdt5yEHmSB1xJA1TPxkkibu+e0i2hAmKsf1o2ZR bBRAseKMMd2uefpNebQ6329pbaGQnJQAfYEs41x08/Xf2XarkMqgFgiI5WcUYemxudwj oiFvGIsfaoRyfmxpdq7FRvWHi2NA0NW6nTXbFDikXwTmTPm0aAmTlqLqqXncdFmnUo9p eLpQ== X-Gm-Message-State: ANoB5pk+q4STraMGrAvjS8sM1rhKDErm4BD+8XhphhFqCYEamqL+G4Xc aTooID/+AHMHUkxhqn634Js5288RFIx5nPPB9zNvLqju X-Google-Smtp-Source: AA0mqf7TxqX+TzgrXztmKTiv13J23lOB6/sRm2UmwgxB6XzLNn8Scm5JOuCHAecHPaoj/u6N9w+Tlq+M4ok/in6uDVk= X-Received: by 2002:a17:906:b892:b0:788:3a75:dc5 with SMTP id hb18-20020a170906b89200b007883a750dc5mr632491ejb.537.1668868663032; Sat, 19 Nov 2022 06:37:43 -0800 (PST) MIME-Version: 1.0 References: <20221118165235.14143-1-anthony.perard@citrix.com> In-Reply-To: <20221118165235.14143-1-anthony.perard@citrix.com> From: Jason Andryuk Date: Sat, 19 Nov 2022 09:37:31 -0500 Message-ID: Subject: Re: [XEN PATCH for-4.17] libs/light: Propagate libxl__arch_domain_create() return code To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Henry Wang , Andrew Cooper , Wei Liu , Juergen Gross Content-Type: text/plain; charset="UTF-8" On Fri, Nov 18, 2022 at 11:53 AM Anthony PERARD wrote: > > Commit 34990446ca91 started to overwrite the `rc` value from > libxl__arch_domain_create(), thus error aren't propagated anymore. > > Check `rc` value before doing the next thing. > > Fixes: 34990446ca91 ("libxl: don't ignore the return value from xc_cpuid_apply_policy") > Reported-by: Andrew Cooper > Signed-off-by: Anthony PERARD Was the issue that libxl__arch_domain_create() failed, but then libxl__cpuid_legacy() succeeded. rc was overwritten, so libxl__build_pre() returns success? Reviewed-by: Jason Andryuk Thanks, Jason From xen-devel-bounces@lists.xenproject.org Sat Nov 19 16:34:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 16:34:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446133.701630 (Exim 4.92) (envelope-from ) id 1owQmp-0005XU-Qf; Sat, 19 Nov 2022 16:33:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446133.701630; Sat, 19 Nov 2022 16:33:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owQmp-0005XN-Ny; Sat, 19 Nov 2022 16:33:47 +0000 Received: by outflank-mailman (input) for mailman id 446133; Sat, 19 Nov 2022 16:33:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owQmo-0005XF-5x for xen-devel@lists.xenproject.org; Sat, 19 Nov 2022 16:33:46 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ed55fec5-6827-11ed-8fd2-01056ac49cbb; Sat, 19 Nov 2022 17:33:42 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 039975C0049; Sat, 19 Nov 2022 11:33:41 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 19 Nov 2022 11:33:41 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 19 Nov 2022 11:33:39 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed55fec5-6827-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668875620; x= 1668962020; bh=k1JAkdVKYVaYxy7kpC5w8PdLHIgc/yfPIYL5UkOFoDY=; b=U FfepIQkuRItQ+/RiE97orM1O6zNvi/VRaBRkKEf7rZY/eNrkBFpNjDdIeMa8resL voWC3eqP7CwW31vto5TEet10oPB1Lt6Y67vEe8AynLgPhIaBTzxIHTCuChFPeXdj OeWnoqFOwvt/uYeZWGpPuHEEnVOmqTsalJUGbRyhGqmt37jWK9ux/CE3v3rwfySN 2POOHBjhRHSfCY5qsB3WW7SCN25M5FqkinuzfD9D+XfYoAAx37WHW9cYWQMpfD3R pnbNkS2s6dxTdswawuohCdzRvwzKuoJAxgEw3TVO5vFbiMZgwSU4WRNuBHjKucFr MuYvlHWErGT0xCGqzyIYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668875620; x=1668962020; bh=k1JAkdVKYVaYxy7kpC5w8PdLHIgc /yfPIYL5UkOFoDY=; b=lJcopc9Opa+b6cHyTKQiOD7+nX2mwT03Ph9BbVVZuT5I 9VP8a5u0d3AeJOBBREXjFugQusX0JMrdM/Rt2rzsEVqWXRbmNMcoiSUZy3/Eb2tQ Krk1TUa95At6+S2CJ1wZJQtCffQFB1GktV2vTOvxhlCNrBmKSNwUExOaJRLMASuj S0NDX4atxmBdozpETZMlV7vQA5W/wWZG+Gx7zPrc2rtIab/YFP+pD1wAPcRRD359 lWu0kzBk6NVJz/nyhFWUhrYvW2Y8zGbO4cDKQDeG/sBh1vCD7NtFv2bupzobkIK+ teN1qvBEEDHJneZmbGkOJAjMchPfd/+BHd558a+gBQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrhedvgdeludcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeukeet teeggffgkeduheetgeeileejjeeiiefhjeegvefhtefggfetueetteeuteenucffohhmrg hinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Sat, 19 Nov 2022 17:33:36 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jason Andryuk Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Subject: Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled Message-ID: References: <20221118154931.1928298-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sCWikLql3O/b4frL" Content-Disposition: inline In-Reply-To: --sCWikLql3O/b4frL Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sat, 19 Nov 2022 17:33:36 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jason Andryuk Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Subject: Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled On Sat, Nov 19, 2022 at 09:36:54AM -0500, Jason Andryuk wrote: > Hi, Marek, >=20 > On Fri, Nov 18, 2022 at 4:46 PM Marek Marczykowski-G=C3=B3recki > wrote: > > > > On Fri, Nov 18, 2022 at 03:46:47PM -0500, Jason Andryuk wrote: > > > I was trying to test your xen-pciback v3 patch, and I am having > > > assignment fail consistently now. It is actually failing to > > > quarantine to domIO in the first place, which matches the failure from > > > the other day (when I more carefully read through the logs). It now > > > consistently fails to quarantine on every boot unlike the other day > > > where it happened once. > > > > Does this include the very first assignment too, or only after domain > > reboot? If the latter, maybe some cleanup missed clearing MASKALL? >=20 > It's the quarantine during dom0 boot that fails. Later assignment > during VM boot fails. I tried warm reboots and cold boots and it > happened both times. >=20 > I also modified my initrd to halt in there and checked the config > space. MASKALL wasn't set at that time. I need to double check - > MASKALL may have been unset after dom0 booted in that case. >=20 > I'll test more to figure when and how MASKALL is getting set. >=20 > > FWIW, the patch applied to Qubes > > (https://github.com/QubesOS/qubes-linux-kernel/pull/680) seems to work > > fine (the full test run is still in progress, but I see some green marks > > already). >=20 > Does Qubes quarantine devices explicitly, or are they in dom0 and > libvirt/libxl just assigns them when a domain boots? We do quarantine them explicitly, still in initramfs. > > > I added some printks and it 's getting -EBUSY from pdev_msix_assign() > > > which means pci_reset_msix_state() is failing: > > > if ( pci_conf_read16(pdev->sbdf, msix_control_reg(pos)) & > > > PCI_MSIX_FLAGS_MASKALL ) > > > return -EBUSY; > > > > > > # lspci -vv -s 14.3 > > > ... > > > Capabilities: [80] MSI-X: Enable- Count=3D16 Masked+ > > > Vector table: BAR=3D0 offset=3D00002000 > > > PBA: BAR=3D0 offset=3D00003000 > > > > > > So it looks like MASKALL is set and prevents assignment. > > > > > > setpci -s 00:14.3 82.W=3Df > > > cleared that out for me and I could assign the device. > > > > > > My dom0 boots, it runs flask-label-pci for a set of PCI devices > > > (including iwlwifi), then xl pci-assignable-add for all PCI devices > > > which will be passed through, then a little later it boots the > > > associated domains. Dom0 does not have a driver for iwlwifi. > > > > > > I'll have to investigate more to see how MASKALL is getting set. This > > > had not been an issue before your recent patches. > > > > I guess before the patches nothing set anything in MSI-X capability, > > because it was hidden... >=20 > Well, stubdom hasn't even booted when, so it would be the Xen or > pciback change to modify MASKALL? Weird... > > Anyway, to support my cleanup hypothesis, I tried to destroy a > > PCI-having domain, and it left MSI-X enabled (at least according to the > > config space). MASKALL was _not_ set, but I haven't checked masking of > > individual vectors. TBH, I'm not sure what should be responsible for the > > MSI-X cleanup after guest destroy. Should it be Xen? Qemu? Pciback? > > Pciback calls PHYSDEVOP_{prepare,release}_msix only when > > binding/unbinding from the device (so - xl pci-assignable-{add,remove}), > > so this isn't the right place. >=20 > I need to review all this code to give a meaningful response. Would > xen-pciback set MASKALL when it binds a device? That happens before > xl pci-assignable-add tries to quarantine (assign to to domIO). I don't see pciback doing that. And also, my patches shouldn't change behaviour of pciback when binding to a device (so, if it would be doing that, it would happen before my patches too). Maybe that's an interaction with some other patches? > > Should that be in Xen, in deassign_device() (part of > > DOMCTL_deassign_device)? >=20 > It seems to me that Xen needs to ultimately disable the device. That's my intuition too. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --sCWikLql3O/b4frL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN5BWAACgkQ24/THMrX 1yyF0Af/aYMmZvYJ1q+GwXf5MPWXWaBIlU/0TQMqLyNv6+JNpsplksGAxarsFwMr 4sXcwivdu7fslA6RfvbZ6L5hV5opwAGyg76i3PZsQo35ezsdcVIGAqNt3Uj+4LE7 rzPwn+7b6yaKLjVPybqvN6n0/sLpO7d5E4ZpPy6/Ww89DAUFwhIS5hDDnnmrc3QO UQkQ5HpykQNx7Iq9cOdZabbSzS1ms0bS9pj8GzCPmJY3Lgu/q2aPkqMvpuJ+TwpQ oDKPzNK/BPoAVaEWf5bzFcybMf3ZiaQS4E6sauKxausfkh4Sn+hCeoqJVKreBUvQ 8Jksic/ya73VURI5MVCfaHH33g1wTw== =wgKy -----END PGP SIGNATURE----- --sCWikLql3O/b4frL-- From xen-devel-bounces@lists.xenproject.org Sat Nov 19 22:00:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 22:00:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446153.701665 (Exim 4.92) (envelope-from ) id 1owVsh-0006mW-Ta; Sat, 19 Nov 2022 22:00:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446153.701665; Sat, 19 Nov 2022 22:00:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owVsh-0006mP-Ql; Sat, 19 Nov 2022 22:00:11 +0000 Received: by outflank-mailman (input) for mailman id 446153; Sat, 19 Nov 2022 22:00:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owVsg-0006mF-GD; Sat, 19 Nov 2022 22:00:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owVsg-0003kF-DZ; Sat, 19 Nov 2022 22:00:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owVsg-00021D-2t; Sat, 19 Nov 2022 22:00:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owVsg-00039x-2T; Sat, 19 Nov 2022 22:00:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Wt9cFmHMu21lI7HP0U8i0pteLh5Ta5VaiB3DeyqogNk=; b=OkNNs3wpfttxrv4fnIZyqXyeE+ bBnoVK2Ct5/BD3JVeKATikFksJ54RadpE0QnyoGXXq7cmBW7nN07tABMCWT0zF+tq/fUhSjE4Fau7 KS0UDc56Sa2EIbKn7E7aK0pe9/9jw7+Lu/A1wQ0fe+BqiKczjXfS5X76pezfVclBhL84=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174833: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=fe24a97cf2543e8832e7a2124802e5c32aac05aa X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sat, 19 Nov 2022 22:00:10 +0000 flight 174833 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174833/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux fe24a97cf2543e8832e7a2124802e5c32aac05aa baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 43 days Failing since 173470 2022-10-08 06:21:34 Z 42 days 74 attempts Testing same since 174823 2022-11-19 03:58:29 Z 0 days 2 attempts ------------------------------------------------------------ 1791 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 169553 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 19 22:34:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 22:34:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446161.701675 (Exim 4.92) (envelope-from ) id 1owWQG-0002IM-NP; Sat, 19 Nov 2022 22:34:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446161.701675; Sat, 19 Nov 2022 22:34:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owWQG-0002IF-Kl; Sat, 19 Nov 2022 22:34:52 +0000 Received: by outflank-mailman (input) for mailman id 446161; Sat, 19 Nov 2022 22:34:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owWQF-0002I5-Gp; Sat, 19 Nov 2022 22:34:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owWQF-0004RF-DL; Sat, 19 Nov 2022 22:34:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owWQF-0002oH-1u; Sat, 19 Nov 2022 22:34:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owWQF-000434-1S; Sat, 19 Nov 2022 22:34:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=8KxZv8l3tP9Ei2k/JG2RY4a2FSeno4zP8VXRGWwUQF0=; b=UwU0k2lfmEFfRPLFnNzfPNZ5zt OW7PzJFzQYk+3WnVu1RoOrzd+C7jS6vAeVo1hZMFWJIdAfvkJcg8bC/xJMspIGF/H7upo4so9p1q0 ynOZK/aevzcx5UiFx66iglbewJFZQZ6mX4WkoucwHGWJAKOEBI+320V9a081MNiC7soU=; To: xen-devel@lists.xenproject.org Subject: [xen-unstable bisection] complete test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm Message-Id: From: osstest service owner Date: Sat, 19 Nov 2022 22:34:51 +0000 branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm testid guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Bug not present: bd87315a603bf25e869e6293f7db7b1024d67999 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174840/ commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm.guest-saverestore.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable/test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm.guest-saverestore --summary-out=tmp/174840.bisection-summary --basis-template=174797 --blessings=real,real-bisect,real-retry xen-unstable test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm guest-saverestore Searching for failure / basis pass: 174826 fail [host=nocera1] / 174797 [host=fiano0] 174791 [host=debina1] 174773 [host=pinot1] 174769 [host=albana1] 174762 [host=sabro1] 174753 [host=godello1] 174747 [host=huxelrebe0] 174742 [host=elbling0] 174733 [host=himrod0] 174724 [host=pinot0] 174701 [host=italia1] 174682 [host=nobling1] 174670 [host=nocera0] 174663 [host=nobling0] 174652 [host=godello0] 174641 [host=italia0] 174636 [host=elbling1] 174629 [host=chardonnay1] 174607 [host=chardonnay0] 174597 [host=albana0] 174586 [host=debi\ na0] 174574 ok. Failure / basis pass flights: 174826 / 174574 (tree with no url: minios) (tree with no url: ovmf) (tree with no url: seabios) Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 2dd823ca7237e7fb90c890642d6a3b357a26fcff Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#b746458e1ce1bec85e58b458386f8b7\ a0bedfaa6-b746458e1ce1bec85e58b458386f8b7a0bedfaa6 git://xenbits.xen.org/xen.git#2dd823ca7237e7fb90c890642d6a3b357a26fcff-db8fa01c61db0317a9ee947925226234c65d48e8 Loaded 5001 nodes in revision graph Searching for test results: 174574 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 2dd823ca7237e7fb90c890642d6a3b357a26fcff 174586 [host=debina0] 174597 [host=albana0] 174607 [host=chardonnay0] 174629 [host=chardonnay1] 174636 [host=elbling1] 174641 [host=italia0] 174652 [host=godello0] 174663 [host=nobling0] 174670 [host=nocera0] 174682 [host=nobling1] 174701 [host=italia1] 174724 [host=pinot0] 174733 [host=himrod0] 174742 [host=elbling0] 174747 [host=huxelrebe0] 174753 [host=godello1] 174762 [host=sabro1] 174769 [host=albana1] 174773 [host=pinot1] 174791 [host=debina1] 174797 [host=fiano0] 174814 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174819 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174827 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 2dd823ca7237e7fb90c890642d6a3b357a26fcff 174828 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174829 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7b068ac89024308862c4f448dd248645d2b8e882 174830 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 224dab941629f9cfb793999bcece4c31776b7827 174831 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f5d56f4b253072264efc0fece698a91779e362f5 174826 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174832 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 22b20bd98c025e06525410e3ab3494d5e63489f7 174834 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174836 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e 174837 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174838 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e 174839 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174840 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Searching for interesting versions Result found: flight 174574 (pass), for basis pass For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999, results HASH(0x5607598e4080) HASH(0x5607598e4b00) HASH(0x56075939b360) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1\ ce1bec85e58b458386f8b7a0bedfaa6 22b20bd98c025e06525410e3ab3494d5e63489f7, results HASH(0x560759392c18) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f5d56f4b253072264efc0fece698a91779e362f5, results HASH(0x5607598f9f48) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f\ 0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 224dab941629f9cfb793999bcece4c31776b7827, results HASH(0x5607598f7f40) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7b068ac89024308862c4f448dd248645d2b8e882, results HASH(0x5607598ea218) For basis failure, parent search stopping at c3038e718a19\ fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 2dd823ca7237e7fb90c890642d6a3b357a26fcff, results HASH(0x5607598e7c10) HASH(0x5607598f1f00) Result found: flight 174814 (fail), for basis failure (at ancestor ~732) Repro found: flight 174827 (pass), for basis pass Repro found: flight 174828 (fail), for basis failure 0 revisions at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 No revisions left to test, checking graph state. Result found: flight 174834 (pass), for last pass Result found: flight 174836 (fail), for first failure Repro found: flight 174837 (pass), for last pass Repro found: flight 174838 (fail), for first failure Repro found: flight 174839 (pass), for last pass Repro found: flight 174840 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Bug not present: bd87315a603bf25e869e6293f7db7b1024d67999 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174840/ commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang Revision graph left in /home/logs/results/bisect/xen-unstable/test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm.guest-saverestore.{dot,ps,png,html,svg}. ---------------------------------------- 174840: tolerable ALL FAIL flight 174840 xen-unstable real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/174840/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail baseline untested jobs: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Sat Nov 19 22:44:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 19 Nov 2022 22:44:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446168.701687 (Exim 4.92) (envelope-from ) id 1owWZy-0003tb-NX; Sat, 19 Nov 2022 22:44:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446168.701687; Sat, 19 Nov 2022 22:44:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owWZy-0003tU-Ka; Sat, 19 Nov 2022 22:44:54 +0000 Received: by outflank-mailman (input) for mailman id 446168; Sat, 19 Nov 2022 22:44:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owWZx-0003tJ-7m; Sat, 19 Nov 2022 22:44:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owWZx-0004kU-1L; Sat, 19 Nov 2022 22:44:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owWZw-00031i-KM; Sat, 19 Nov 2022 22:44:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owWZw-0005hb-Jq; Sat, 19 Nov 2022 22:44:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0mtYQHKU6BBsqgs1nqjylZmrpyLarrfYD5LzaO2b3QA=; b=e2MWcXY+zLJRl0hN9UEop8JreH RrLfUzFXbZJ/7/R7LUJz4CmFSFoJo5UXBBd3n2Wgvw5Hk+NNVrCnwLS7E/bDNjE6wbML6EP2ixO2g oLELVCc9WLdTST5DdCNO+FeYoE5KEiBjPZZadJJTxJKnEhyBvWKw+SxYFZ83UN7ClsVU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174835: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-xsm::broken:regression xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-amd64-libvirt-xsm:host-install(5):broken:heisenbug xen-unstable:test-arm64-arm64-examine:reboot:fail:heisenbug xen-unstable:test-arm64-arm64-xl:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=db8fa01c61db0317a9ee947925226234c65d48e8 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Sat, 19 Nov 2022 22:44:52 +0000 flight 174835 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174835/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm broken test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 174797 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-xsm 5 host-install(5) broken pass in 174826 test-arm64-arm64-examine 8 reboot fail in 174826 pass in 174835 test-arm64-arm64-xl 18 guest-start/debian.repeat fail in 174826 pass in 174835 test-amd64-amd64-xl-qemuu-ws16-amd64 12 windows-install fail pass in 174826 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail in 174826 like 174797 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail in 174826 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen db8fa01c61db0317a9ee947925226234c65d48e8 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 2 days Testing same since 174809 2022-11-18 00:06:55 Z 1 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm broken test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-libvirt-xsm broken broken-step test-amd64-amd64-libvirt-xsm host-install(5) Not pushing. ------------------------------------------------------------ commit db8fa01c61db0317a9ee947925226234c65d48e8 Author: Andrew Cooper Date: Thu Oct 20 12:14:30 2022 +0100 xen/arm: Correct the p2m pool size calculations Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit bd87315a603bf25e869e6293f7db7b1024d67999 Author: Andrew Cooper Date: Thu Oct 20 12:13:46 2022 +0100 tools/tests: Unit test for paging mempool size Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit 22b20bd98c025e06525410e3ab3494d5e63489f7 Author: Andrew Cooper Date: Fri Oct 21 14:13:00 2022 +0100 xen: Introduce non-broken hypercalls for the paging mempool size The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 Author: Andrew Cooper Date: Mon Nov 14 21:47:59 2022 +0000 x86/hvm: Revert per-domain APIC acceleration support I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisted in due course. Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Fixes: 6b2b9b340509 ("x86: report Interrupt Controller Virtualization capabilities") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sun Nov 20 06:46:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 20 Nov 2022 06:46:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446217.701749 (Exim 4.92) (envelope-from ) id 1owe5H-0003jW-Vw; Sun, 20 Nov 2022 06:45:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446217.701749; Sun, 20 Nov 2022 06:45:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owe5H-0003j6-QF; Sun, 20 Nov 2022 06:45:43 +0000 Received: by outflank-mailman (input) for mailman id 446217; Sun, 20 Nov 2022 06:45:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owe5H-0003iw-4T; Sun, 20 Nov 2022 06:45:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owe5H-0006Qr-1n; Sun, 20 Nov 2022 06:45:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owe5G-0007bx-NS; Sun, 20 Nov 2022 06:45:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owe5G-00042G-N2; Sun, 20 Nov 2022 06:45:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jzZ/LEdGFf1iIhUimNaOjNHGdiQRuTNVQxZ57YK0aAk=; b=0HIf1rtzPnRz0M+cYJMhFKjYgd PwZVaQhtE9mt3IACOekcwCSmMIXXjTs2EjDnQ5xjpghLVv2nHUL0Rq3jgEHw0ad3C4SIBvM9q/qpX 12p4tMKGbsAfu6F3B7p0RHCR9MXSvs9pxp2XQasmWJurEq/eqER6sbggaj0E29GuYL18=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174841: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b6e7fdfd6f6a8bf88fcdb4a45da52c42ba238c25 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sun, 20 Nov 2022 06:45:42 +0000 flight 174841 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174841/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux b6e7fdfd6f6a8bf88fcdb4a45da52c42ba238c25 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 43 days Failing since 173470 2022-10-08 06:21:34 Z 43 days 75 attempts Testing same since 174841 2022-11-19 22:09:59 Z 0 days 1 attempts ------------------------------------------------------------ 1794 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 169797 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 20 07:29:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 20 Nov 2022 07:29:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446232.701771 (Exim 4.92) (envelope-from ) id 1owele-0000Gz-9C; Sun, 20 Nov 2022 07:29:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446232.701771; Sun, 20 Nov 2022 07:29:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owele-0000Gs-5C; Sun, 20 Nov 2022 07:29:30 +0000 Received: by outflank-mailman (input) for mailman id 446232; Sun, 20 Nov 2022 07:29:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owelc-0000Gi-AJ; Sun, 20 Nov 2022 07:29:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owelc-0007IS-1J; Sun, 20 Nov 2022 07:29:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owelb-0000Ag-Lu; Sun, 20 Nov 2022 07:29:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owelb-0002fu-LM; Sun, 20 Nov 2022 07:29:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1kWx7cfZ69gILrJID5Mz2D868fclU9GgcNIlgrgsJg0=; b=sgV3aNfvD4vB+eoOOh3obFKwgK UTvWKbQY8tOJOsiKs0khd72pAuT1imKWtkMGittbqk5prW12rvfQ/UKuu9OnRQlMaImNnPUW155AT GDMH/97Is9yWdOXyGLiQmCA848bJKCVjJqVDBR+1eghEJYm40ZRzCrYG2pLCi0I7MqeI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174843: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-xsm::broken:regression xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-amd64-libvirt-xsm:host-install(5):broken:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=db8fa01c61db0317a9ee947925226234c65d48e8 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Sun, 20 Nov 2022 07:29:27 +0000 flight 174843 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174843/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm broken in 174835 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 174797 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-xsm 5 host-install(5) broken in 174835 pass in 174843 test-amd64-amd64-xl-qemuu-ws16-amd64 12 windows-install fail in 174835 pass in 174843 test-amd64-i386-xl-xsm 7 xen-install fail pass in 174835 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail pass in 174835 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail pass in 174835 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen db8fa01c61db0317a9ee947925226234c65d48e8 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 3 days Testing same since 174809 2022-11-18 00:06:55 Z 2 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-libvirt-xsm broken Not pushing. ------------------------------------------------------------ commit db8fa01c61db0317a9ee947925226234c65d48e8 Author: Andrew Cooper Date: Thu Oct 20 12:14:30 2022 +0100 xen/arm: Correct the p2m pool size calculations Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit bd87315a603bf25e869e6293f7db7b1024d67999 Author: Andrew Cooper Date: Thu Oct 20 12:13:46 2022 +0100 tools/tests: Unit test for paging mempool size Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit 22b20bd98c025e06525410e3ab3494d5e63489f7 Author: Andrew Cooper Date: Fri Oct 21 14:13:00 2022 +0100 xen: Introduce non-broken hypercalls for the paging mempool size The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 Author: Andrew Cooper Date: Mon Nov 14 21:47:59 2022 +0000 x86/hvm: Revert per-domain APIC acceleration support I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisted in due course. Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Fixes: 6b2b9b340509 ("x86: report Interrupt Controller Virtualization capabilities") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sun Nov 20 08:29:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 20 Nov 2022 08:29:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446253.701787 (Exim 4.92) (envelope-from ) id 1owfh3-0007eD-6V; Sun, 20 Nov 2022 08:28:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446253.701787; Sun, 20 Nov 2022 08:28:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owfh3-0007e6-3n; Sun, 20 Nov 2022 08:28:49 +0000 Received: by outflank-mailman (input) for mailman id 446253; Sun, 20 Nov 2022 08:28:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owfh1-0007dw-KJ; Sun, 20 Nov 2022 08:28:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owfh1-0000fL-H1; Sun, 20 Nov 2022 08:28:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owfh1-0002m5-6C; Sun, 20 Nov 2022 08:28:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owfh1-0006it-5l; Sun, 20 Nov 2022 08:28:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=5UvD1GpozgHTFkF0VwNJTBHKqeUZ7Zq3K/G7PDtiaEM=; b=IcjoqZxnQnpPqMkqT4QhGWFenq 4pz1sTCFnLw34QQhbASWnrTV2QaRIrwZrWXn8nD9VELsSQ8Msv7IHxL6H/9R9gT9qpximuI3KrhYy fKkZagCXwGHeQ/nTWoZhgbwrAkL/5BBAZ7y8fi11lP+DUQZWmvPt1mU5oFiBPqmuG+ww=; To: xen-devel@lists.xenproject.org Subject: [xen-unstable bisection] complete test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm Message-Id: From: osstest service owner Date: Sun, 20 Nov 2022 08:28:47 +0000 branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Bug not present: bd87315a603bf25e869e6293f7db7b1024d67999 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174855/ commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm.debian-hvm-install.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable/test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm.debian-hvm-install --summary-out=tmp/174855.bisection-summary --basis-template=174797 --blessings=real,real-bisect,real-retry xen-unstable test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm debian-hvm-install Searching for failure / basis pass: 174843 fail [host=debina1] / 174797 [host=chardonnay0] 174791 [host=albana1] 174773 [host=albana0] 174769 [host=nocera1] 174762 [host=huxelrebe1] 174753 [host=nobling0] 174747 [host=elbling0] 174742 [host=debina0] 174733 [host=huxelrebe0] 174724 [host=fiano1] 174701 [host=pinot0] 174682 [host=pinot1] 174670 [host=italia1] 174663 [host=nobling1] 174652 [host=chardonnay1] 174641 [host=nocera0] 174636 [host=elbling1] 174629 [host=chardonnay0] 174607 ok. Failure / basis pass flights: 174843 / 174607 (tree with no url: minios) (tree with no url: ovmf) (tree with no url: seabios) Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 2d9b3699136d20e354a94daefebbeefa9ceec7b6 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#b746458e1ce1bec85e58b458386f8b7\ a0bedfaa6-b746458e1ce1bec85e58b458386f8b7a0bedfaa6 git://xenbits.xen.org/xen.git#2d9b3699136d20e354a94daefebbeefa9ceec7b6-db8fa01c61db0317a9ee947925226234c65d48e8 Loaded 5001 nodes in revision graph Searching for test results: 174607 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 2d9b3699136d20e354a94daefebbeefa9ceec7b6 174629 [host=chardonnay0] 174636 [host=elbling1] 174641 [host=nocera0] 174652 [host=chardonnay1] 174663 [host=nobling1] 174670 [host=italia1] 174682 [host=pinot1] 174701 [host=pinot0] 174724 [host=fiano1] 174733 [host=huxelrebe0] 174742 [host=debina0] 174747 [host=elbling0] 174753 [host=nobling0] 174762 [host=huxelrebe1] 174769 [host=nocera1] 174773 [host=albana0] 174791 [host=albana1] 174797 [host=chardonnay0] 174814 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174819 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174826 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174842 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 2d9b3699136d20e354a94daefebbeefa9ceec7b6 174844 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174845 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 c805ceb0b26a643c7e47f01f2dbc50555d93cce8 174846 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 c62748312e0adec0cbcf0f8d7d126080e5e43a82 174847 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 174848 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174849 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e 174850 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174851 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e 174843 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174853 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174855 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Searching for interesting versions Result found: flight 174607 (pass), for basis pass For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999, results HASH(0x55b3d7e96a50) HASH(0x55b3d7e93820) HASH(0x55b3d7e860c0) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1\ ce1bec85e58b458386f8b7a0bedfaa6 e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9, results HASH(0x55b3d7e90290) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 c62748312e0adec0cbcf0f8d7d126080e5e43a82, results HASH(0x55b3d7e897d0) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f\ 0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 c805ceb0b26a643c7e47f01f2dbc50555d93cce8, results HASH(0x55b3d7e9db10) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 2d9b3699136d20e354a94daefebbeefa9ceec7b6, results HASH(0x55b3d7e894d0) HASH(0x55b3d7e877c8) Result found: flight 174814 (fail), \ for basis failure (at ancestor ~732) Repro found: flight 174842 (pass), for basis pass Repro found: flight 174843 (fail), for basis failure 0 revisions at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 No revisions left to test, checking graph state. Result found: flight 174848 (pass), for last pass Result found: flight 174849 (fail), for first failure Repro found: flight 174850 (pass), for last pass Repro found: flight 174851 (fail), for first failure Repro found: flight 174853 (pass), for last pass Repro found: flight 174855 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Bug not present: bd87315a603bf25e869e6293f7db7b1024d67999 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174855/ commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang Revision graph left in /home/logs/results/bisect/xen-unstable/test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm.debian-hvm-install.{dot,ps,png,html,svg}. ---------------------------------------- 174855: tolerable ALL FAIL flight 174855 xen-unstable real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/174855/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail baseline untested jobs: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Sun Nov 20 11:08:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 20 Nov 2022 11:08:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446274.701819 (Exim 4.92) (envelope-from ) id 1owiBZ-0007xu-Fv; Sun, 20 Nov 2022 11:08:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446274.701819; Sun, 20 Nov 2022 11:08:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owiBZ-0007xn-DH; Sun, 20 Nov 2022 11:08:29 +0000 Received: by outflank-mailman (input) for mailman id 446274; Sun, 20 Nov 2022 11:08:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owiBX-0007xd-DP for xen-devel@lists.xenproject.org; Sun, 20 Nov 2022 11:08:27 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a4aa87df-68c3-11ed-91b6-6bf2151ebd3b; Sun, 20 Nov 2022 12:08:25 +0100 (CET) Received: from [10.10.1.128] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1668942496767420.7787927416391; Sun, 20 Nov 2022 03:08:16 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4aa87df-68c3-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; t=1668942497; cv=none; d=zohomail.com; s=zohoarc; b=kEw47x2QrPTksyBHc/8JvHHX4rF+TZgUCdoprA3fI3Qy/3xbBjjnVNdc852kKvnPip7lZVxjZ1gysNE8fLeIqCMBHYmPpSdqFqWLfy2maOfEMT3jTFsK0Xj4WVIZJz4yHUDHTHc8ItmdKS6yki/62rz7RUw5oddD4irtTnv/T0Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668942497; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=10Dq8n20jXc8W6amE2OsE6o/Jj6s5bwGfjdY3iz1oU4=; b=YNEWL6I6Wi0gt1rmFwwdXPDuRt9bmkexrg95VAHHO3Oat0fRp1GrnkewA9UOqkWGsHQJfew138YFYqxR8FApNpZ6aRPYc9N0T4bGK+XmQwz85RtkpDHdLdmHnmKm5Q+zeZ2UybbxkDuWCpWd13yKWpEh+R1JN5G2MhU3y0rZMQ8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1668942497; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=10Dq8n20jXc8W6amE2OsE6o/Jj6s5bwGfjdY3iz1oU4=; b=YGfQ9kT36WTVML9VpAsdwbMaJmTd5Iq/+hgATQDmMHCuD/sQY8/BBX8UtjvyA7la Jl9Iqqe8Ku5273TIr+XtIsS0PdnegBxLqEi0U7IM6pCqY0Qx+IesedyZEm+o9q+m1SD VhCED9bVRKg399NOJscmd9XxPsVf9FlxhIaZsVrQ= Message-ID: Date: Sun, 20 Nov 2022 06:08:14 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: Flask vs paging mempool - Was: [xen-unstable test] 174809: regressions - trouble: broken/fail/pass Content-Language: en-US To: Jason Andryuk , Andrew Cooper Cc: Roger Pau Monne , Henry Wang , Anthony Perard , "xen-devel@lists.xenproject.org" References: <6846bb37-345e-ca3d-4cad-2032c4852e15@citrix.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 11/18/22 16:10, Jason Andryuk wrote: > On Fri, Nov 18, 2022 at 12:22 PM Andrew Cooper > wrote: >> >> On 18/11/2022 14:39, Roger Pau Monne wrote: >>> Nov 18 01:55:11.753936 (XEN) arch/x86/mm/hap/hap.c:304: d1 failed to allocate from HAP pool >>> Nov 18 01:55:18.633799 (XEN) Failed to shatter gfn 7ed37: -12 >>> Nov 18 01:55:18.633866 (XEN) d1v0 EPT violation 0x19c (--x/rw-) gpa 0x0000007ed373a1 mfn 0x33ed37 type 0 >>> Nov 18 01:55:18.645790 (XEN) d1v0 Walking EPT tables for GFN 7ed37: >>> Nov 18 01:55:18.645850 (XEN) d1v0 epte 9c0000047eba3107 >>> Nov 18 01:55:18.645893 (XEN) d1v0 epte 9c000003000003f3 >>> Nov 18 01:55:18.645935 (XEN) d1v0 --- GLA 0x7ed373a1 >>> Nov 18 01:55:18.657783 (XEN) domain_crash called from arch/x86/hvm/vmx/vmx.c:3758 >>> Nov 18 01:55:18.657844 (XEN) Domain 1 (vcpu#0) crashed on cpu#8: >>> Nov 18 01:55:18.669781 (XEN) ----[ Xen-4.17-rc x86_64 debug=y Not tainted ]---- >>> Nov 18 01:55:18.669843 (XEN) CPU: 8 >>> Nov 18 01:55:18.669884 (XEN) RIP: 0020:[<000000007ed373a1>] >>> Nov 18 01:55:18.681711 (XEN) RFLAGS: 0000000000010002 CONTEXT: hvm guest (d1v0) >>> Nov 18 01:55:18.681772 (XEN) rax: 000000007ed373a1 rbx: 000000007ed3726c rcx: 0000000000000000 >>> Nov 18 01:55:18.693713 (XEN) rdx: 000000007ed2e610 rsi: 0000000000008e38 rdi: 000000007ed37448 >>> Nov 18 01:55:18.693775 (XEN) rbp: 0000000001b410a0 rsp: 0000000000320880 r8: 0000000000000000 >>> Nov 18 01:55:18.705725 (XEN) r9: 0000000000000000 r10: 0000000000000000 r11: 0000000000000000 >>> Nov 18 01:55:18.717733 (XEN) r12: 0000000000000000 r13: 0000000000000000 r14: 0000000000000000 >>> Nov 18 01:55:18.717794 (XEN) r15: 0000000000000000 cr0: 0000000000000011 cr4: 0000000000000000 >>> Nov 18 01:55:18.729713 (XEN) cr3: 0000000000400000 cr2: 0000000000000000 >>> Nov 18 01:55:18.729771 (XEN) fsb: 0000000000000000 gsb: 0000000000000000 gss: 0000000000000002 >>> Nov 18 01:55:18.741711 (XEN) ds: 0028 es: 0028 fs: 0000 gs: 0000 ss: 0028 cs: 0020 >>> >>> It seems to be related to the paging pool adding Andrew and Henry so >>> that he is aware. >> >> Summary of what I've just given on IRC/Matrix. >> >> This crash is caused by two things. First >> >> (XEN) FLASK: Denying unknown domctl: 86. >> >> because I completely forgot to wire up Flask for the new hypercalls. >> But so did the original XSA-409 fix (as SECCLASS_SHADOW is behind >> CONFIG_X86), so I don't feel quite as bad about this. > > Broken for ARM, but not for x86, right? > > I think SECCLASS_SHADOW is available in the policy bits - it's just > whether or not the hook functions are available? > >> And second because libxl ignores the error it gets back, and blindly >> continues onward. Anthony has posted "libs/light: Propagate >> libxl__arch_domain_create() return code" to fix the libxl half of the >> bug, and I posted a second libxl bugfix to fix an error message. Both >> are very simple. >> >> >> For Flask, we need new access vectors because this is a common >> hypercall, but I'm unsure how to interlink it with x86's shadow >> control. This will require a bit of pondering, but it is probably >> easier to just leave them unlinked. > > It sort of seems like it could go under domain2 since domain/domain2 > have most of the memory stuff, but it is non-PV. shadow has its own > set of hooks. It could go in hvm which already has some memory stuff. Since the new hypercall is for managing a memory pool for any domain, though HVM is the only one supported today, imho it belongs under domain/domain2. Something to consider is that there is another guest memory pool that is managed, the PoD pool, which has a dedicated privilege for it. This leads me to the question of whether access to manage the PoD pool and the paging pool size should be separate accesses or whether they should be under the same access. IMHO I believe it should be the latter as I can see no benefit in disaggregating access to the PoD pool and the paging pool. In fact I find myself thinking in terms of should the managing domain have control over the size of any backing memory pools for the target domain. I am not seeing any benefit to discriminating between which backing memory pool a managing domain should be able to manage. With that said, I am open to being convinced otherwise. Since this is an XSA fix that will be backported, moving get/set PoD hypercalls under a new permission would be too disruptive. I would recommend introducing the permission set/getmempools under the domain access vector, which will only control access to the paging pool. Then planning can occur for 4.18 to look at transitioning get/set PoD target to being controlled via get/setmempools. >> Flask is listed as experimental which means it doesn't technically >> matter if we break it, but it is used by OpenXT so not fixing it for >> 4.17 would be rather rude. > > It's definitely nicer to have functional Flask in the release. OpenXT > can use a backport if necessary, so it doesn't need to be a release > blocker. Having said that, Flask is a nice feature of Xen, so it > would be good to have it functioning in 4.17. As maintainer I would really prefer not to see 4.17 go out with any part of XSM broken. While it is considered experimental, which I hope to rectify, it is a long standing feature that has been kept stable, and for which there is a sizeable user base. IMHO I think it deserves a proper fix before release. V/r, Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Sun Nov 20 14:57:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 20 Nov 2022 14:57:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446307.701854 (Exim 4.92) (envelope-from ) id 1owlkO-0007K6-4A; Sun, 20 Nov 2022 14:56:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446307.701854; Sun, 20 Nov 2022 14:56:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owlkO-0007Jz-0t; Sun, 20 Nov 2022 14:56:40 +0000 Received: by outflank-mailman (input) for mailman id 446307; Sun, 20 Nov 2022 14:56:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owlkM-0007Jp-Hx; Sun, 20 Nov 2022 14:56:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owlkM-0000lf-5m; Sun, 20 Nov 2022 14:56:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owlkL-00043K-MV; Sun, 20 Nov 2022 14:56:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owlkL-000429-M1; Sun, 20 Nov 2022 14:56:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NLYxN0CKiyceeC0ng/y5aqbedyjibWwQZfkFbciNpGA=; b=FOnvh0NJql9gbwbr3fshqTVbhQ fUEjMJCkVjkwl6k/1GLbqriSWoa/epHe6rLu1ntgYuCFxhUulg8mX6RKTKeecURM46fdlTOyYZ8ZF zcB9lf+tRLufU2rXxxaB3LElpzrEqdnVKvy8kSzk5tY14YfhH4qnKq3jJdDOhmyIbj1Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174852: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=77c51ba552a1c4f73228766e43ae37c4101b3758 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sun, 20 Nov 2022 14:56:37 +0000 flight 174852 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174852/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 77c51ba552a1c4f73228766e43ae37c4101b3758 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 43 days Failing since 173470 2022-10-08 06:21:34 Z 43 days 76 attempts Testing same since 174852 2022-11-20 06:47:12 Z 0 days 1 attempts ------------------------------------------------------------ 1795 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 170076 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 20 15:42:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 20 Nov 2022 15:42:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446319.701871 (Exim 4.92) (envelope-from ) id 1owmT6-0004Yq-Mc; Sun, 20 Nov 2022 15:42:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446319.701871; Sun, 20 Nov 2022 15:42:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owmT6-0004Yj-Jt; Sun, 20 Nov 2022 15:42:52 +0000 Received: by outflank-mailman (input) for mailman id 446319; Sun, 20 Nov 2022 15:42:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owmT6-0004YZ-5q; Sun, 20 Nov 2022 15:42:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owmT6-0001oc-2T; Sun, 20 Nov 2022 15:42:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owmT5-00055t-Kg; Sun, 20 Nov 2022 15:42:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owmT5-0001NR-KB; Sun, 20 Nov 2022 15:42:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QfyW8yAqFJ6gxcJ3kXUt8lEUwks+fZk+HA+lHocFu0Q=; b=OOe7AJKnqaa+pjdK30eDe0ba1r I0pazzQQsfJ4Jtf+YFNLhqI/AAJKalZlQR1wJPhxRCFsWyn8Zt4R9PTVehck+HbcUSPr226TgKb/j hQL7IItSNkH5iTbLyoxKIQAePJYUroMAzf7phlKunnxF6St/mYDpf9Fy9zYCUj30o0XQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174854: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-xsm::broken:regression xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-amd64-libvirt-xsm:host-install(5):broken:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-i386-freebsd10-amd64:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=db8fa01c61db0317a9ee947925226234c65d48e8 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Sun, 20 Nov 2022 15:42:51 +0000 flight 174854 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174854/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm broken in 174835 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 174797 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-xsm 5 host-install(5) broken in 174835 pass in 174854 test-amd64-amd64-xl-qemuu-ws16-amd64 12 windows-install fail in 174835 pass in 174854 test-amd64-i386-xl-xsm 7 xen-install fail in 174843 pass in 174854 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 174843 pass in 174854 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail pass in 174835 test-amd64-i386-freebsd10-amd64 19 guest-localmigrate/x10 fail pass in 174843 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen db8fa01c61db0317a9ee947925226234c65d48e8 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 3 days Testing same since 174809 2022-11-18 00:06:55 Z 2 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-libvirt-xsm broken Not pushing. ------------------------------------------------------------ commit db8fa01c61db0317a9ee947925226234c65d48e8 Author: Andrew Cooper Date: Thu Oct 20 12:14:30 2022 +0100 xen/arm: Correct the p2m pool size calculations Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit bd87315a603bf25e869e6293f7db7b1024d67999 Author: Andrew Cooper Date: Thu Oct 20 12:13:46 2022 +0100 tools/tests: Unit test for paging mempool size Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit 22b20bd98c025e06525410e3ab3494d5e63489f7 Author: Andrew Cooper Date: Fri Oct 21 14:13:00 2022 +0100 xen: Introduce non-broken hypercalls for the paging mempool size The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 Author: Andrew Cooper Date: Mon Nov 14 21:47:59 2022 +0000 x86/hvm: Revert per-domain APIC acceleration support I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisted in due course. Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Fixes: 6b2b9b340509 ("x86: report Interrupt Controller Virtualization capabilities") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Mon Nov 21 00:19:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 00:19:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446358.701911 (Exim 4.92) (envelope-from ) id 1owuWt-0007pQ-Dc; Mon, 21 Nov 2022 00:19:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446358.701911; Mon, 21 Nov 2022 00:19:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owuWt-0007pJ-AG; Mon, 21 Nov 2022 00:19:19 +0000 Received: by outflank-mailman (input) for mailman id 446358; Mon, 21 Nov 2022 00:19:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owuWr-0007p9-Ka; Mon, 21 Nov 2022 00:19:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owuWr-0005h2-H1; Mon, 21 Nov 2022 00:19:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owuWr-00028U-5Q; Mon, 21 Nov 2022 00:19:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owuWr-0007aM-50; Mon, 21 Nov 2022 00:19:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UxM4hpqjgDbInS2sZiq8uhpF89S0z/2qWWlEYWb0EKQ=; b=hw4goLXG/ezdnSrICSNrNRFj/d JuOgC5kxUcCndlXfulbZPZsqL/L67ISUZDXNzeVFva9RmZkilvFVv1YLi4tfmQqoYneXwmNJ066Rx IR7KLSeIKN0m1Toom+PYx5XO3xyNGomzZLqDZ3HKMlClJ+bksg/AsEerFeZpVQuhgD1A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174863: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=77c51ba552a1c4f73228766e43ae37c4101b3758 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Mon, 21 Nov 2022 00:19:17 +0000 flight 174863 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174863/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 77c51ba552a1c4f73228766e43ae37c4101b3758 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 44 days Failing since 173470 2022-10-08 06:21:34 Z 43 days 77 attempts Testing same since 174852 2022-11-20 06:47:12 Z 0 days 2 attempts ------------------------------------------------------------ 1795 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 170076 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Nov 21 02:57:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 02:57:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446376.701929 (Exim 4.92) (envelope-from ) id 1owwzj-0006Gf-EF; Mon, 21 Nov 2022 02:57:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446376.701929; Mon, 21 Nov 2022 02:57:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owwzj-0006GX-9J; Mon, 21 Nov 2022 02:57:15 +0000 Received: by outflank-mailman (input) for mailman id 446376; Mon, 21 Nov 2022 02:57:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owwzi-0006GN-9A; Mon, 21 Nov 2022 02:57:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owwzi-0007u0-20; Mon, 21 Nov 2022 02:57:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1owwzh-0008Cb-JB; Mon, 21 Nov 2022 02:57:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1owwzh-0004KX-IC; Mon, 21 Nov 2022 02:57:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jjDXhXLi0DMZpMmOHRx54vehkWfgX5763LFHiLXxCc8=; b=jEIDFCL801jST1RI9LkCqyxBm8 IblkiEOPd5hjA75a0jClcS0ErgrCCf5gUtkF8TziHNJAXsJrL1NjSIuku3JooLuTOMG9ZCGvLyCgU OCyJL6fDqgVPtcp9dUmHTKmzbk/fKWa2/uIlVecWO1QI2tFzYaIV1dJZl9CkTGI0lH9Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174865: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=db8fa01c61db0317a9ee947925226234c65d48e8 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Mon, 21 Nov 2022 02:57:13 +0000 flight 174865 xen-unstable real [real] flight 174872 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174865/ http://logs.test-lab.xenproject.org/osstest/logs/174872/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 174797 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen db8fa01c61db0317a9ee947925226234c65d48e8 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 3 days Testing same since 174809 2022-11-18 00:06:55 Z 3 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit db8fa01c61db0317a9ee947925226234c65d48e8 Author: Andrew Cooper Date: Thu Oct 20 12:14:30 2022 +0100 xen/arm: Correct the p2m pool size calculations Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit bd87315a603bf25e869e6293f7db7b1024d67999 Author: Andrew Cooper Date: Thu Oct 20 12:13:46 2022 +0100 tools/tests: Unit test for paging mempool size Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit 22b20bd98c025e06525410e3ab3494d5e63489f7 Author: Andrew Cooper Date: Fri Oct 21 14:13:00 2022 +0100 xen: Introduce non-broken hypercalls for the paging mempool size The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 Author: Andrew Cooper Date: Mon Nov 14 21:47:59 2022 +0000 x86/hvm: Revert per-domain APIC acceleration support I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisted in due course. Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Fixes: 6b2b9b340509 ("x86: report Interrupt Controller Virtualization capabilities") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Mon Nov 21 07:10:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 07:10:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446395.701952 (Exim 4.92) (envelope-from ) id 1ox0wZ-0000Rq-Jq; Mon, 21 Nov 2022 07:10:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446395.701952; Mon, 21 Nov 2022 07:10:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox0wZ-0000Rj-Gc; Mon, 21 Nov 2022 07:10:15 +0000 Received: by outflank-mailman (input) for mailman id 446395; Mon, 21 Nov 2022 07:10:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox0wY-0000RP-2g for xen-devel@lists.xen.org; Mon, 21 Nov 2022 07:10:14 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8a2bf435-696b-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 08:10:12 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9C09121AA6; Mon, 21 Nov 2022 07:10:11 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6341A1377F; Mon, 21 Nov 2022 07:10:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YgzYFVMke2NwJQAAMHmgww (envelope-from ); Mon, 21 Nov 2022 07:10:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a2bf435-696b-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669014611; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YpmSrVrUBAdaUDiX6pnx+0nZgmk8yIbXBfDLUV6ifsI=; b=QZ8g33SJR7P0Y8bJ04TOoeDwcxE1tO4caJsPMMa5Bx62H2l+drpoueCJWmexyHDZ+p+W2n gkNNPsyaowjdqkjJgMQLEli80qqwDVpEsdyeZc8bOQkRBlllekzWZaEMwExeB3capuCf3N pt6C49g3rLQG4IyEtAofi1JHwI04j4w= Message-ID: <99178e0a-ff6a-9bfa-4ade-b4bf6fdc306f@suse.com> Date: Mon, 21 Nov 2022 08:10:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 To: Sander Eikelenboom , Yu Zhao Cc: linux-kernel , Xen-devel References: <42579618-f8e2-9fd2-0b6c-f2c87f7c57a6@eikelenboom.it> Content-Language: en-US From: Juergen Gross Subject: Re: Xen-unstable Linux-6.1.0-rc5 BUG: unable to handle page fault for address: ffff8880083374d0 In-Reply-To: <42579618-f8e2-9fd2-0b6c-f2c87f7c57a6@eikelenboom.it> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------o6rTmt8hCoIt2ik0m6BGQhMn" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------o6rTmt8hCoIt2ik0m6BGQhMn Content-Type: multipart/mixed; boundary="------------329OYkFlR7h0dmdTzX2YNdD0"; protected-headers="v1" From: Juergen Gross To: Sander Eikelenboom , Yu Zhao Cc: linux-kernel , Xen-devel Message-ID: <99178e0a-ff6a-9bfa-4ade-b4bf6fdc306f@suse.com> Subject: Re: Xen-unstable Linux-6.1.0-rc5 BUG: unable to handle page fault for address: ffff8880083374d0 References: <42579618-f8e2-9fd2-0b6c-f2c87f7c57a6@eikelenboom.it> In-Reply-To: <42579618-f8e2-9fd2-0b6c-f2c87f7c57a6@eikelenboom.it> --------------329OYkFlR7h0dmdTzX2YNdD0 Content-Type: multipart/mixed; boundary="------------LnoS1hZwb0nVyBNfaT4OOCul" --------------LnoS1hZwb0nVyBNfaT4OOCul Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTkuMTEuMjIgMDk6MjgsIFNhbmRlciBFaWtlbGVuYm9vbSB3cm90ZToNCj4gSGkgWXUg LyBKdWVyZ2VuLA0KPiANCj4gVGhpcyBuaWdodCBJIGdvdCBhIGRvbTAga2VybmVsIGNyYXNo IG9uIG15IG5ldyBSeXplbiBib3ggcnVubmluZyBYZW4tdW5zdGFibGUgDQo+IGFuZCBhIExp bnV4LTYuMS4wLXJjNSBrZXJuZWwuDQo+IEkgZGlkIGVuYWJsZSB0aGUgbmV3IGFuZCBzaGlu eSBNR0xSVSwgY291bGQgdGhpcyBiZSByZWxhdGVkID8NCg0KSXQgbWlnaHQgYmUgcmVsYXRl ZCwgYnV0IEkgdGhpbmsgaXQgY291bGQgaGFwcGVuIGluZGVwZW5kZW50bHkgZnJvbSBpdC4N Cg0KPiBOb3YgMTkgMDY6MzA6MTEgc2VydmVlcnN0ZXJ0amUga2VybmVsOiBbNjg5NTkuNjQ3 MzcxXSBCVUc6IHVuYWJsZSB0byBoYW5kbGUgcGFnZSANCj4gZmF1bHQgZm9yIGFkZHJlc3M6 IGZmZmY4ODgwMDgzMzc0ZDANCj4gTm92IDE5IDA2OjMwOjExIHNlcnZlZXJzdGVydGplIGtl cm5lbDogWzY4OTU5LjY2MzU1NV0gI1BGOiBzdXBlcnZpc29yIHdyaXRlIA0KPiBhY2Nlc3Mg aW4ga2VybmVsIG1vZGUNCj4gTm92IDE5IDA2OjMwOjExIHNlcnZlZXJzdGVydGplIGtlcm5l bDogWzY4OTU5LjY3NzU0Ml0gI1BGOiBlcnJvcl9jb2RlKDB4MDAwMykgLSANCj4gcGVybWlz c2lvbnMgdmlvbGF0aW9uDQo+IE5vdiAxOSAwNjozMDoxMSBzZXJ2ZWVyc3RlcnRqZSBrZXJu ZWw6IFs2ODk1OS42OTExODFdIFBHRCAzMDI2MDY3IFA0RCAzMDI2MDY3IA0KPiBQVUQgMzAy NzA2NyBQTUQgN2ZlZTUwNjcgUFRFIDgwMTAwMDAwMDgzMzcwNjUNCj4gTm92IDE5IDA2OjMw OjExIHNlcnZlZXJzdGVydGplIGtlcm5lbDogWzY4OTU5LjcwNTA4NF0gT29wczogMDAwMyBb IzFdIFBSRUVNUFQgDQo+IFNNUCBOT1BUSQ0KPiBOb3YgMTkgMDY6MzA6MTEgc2VydmVlcnN0 ZXJ0amUga2VybmVsOiBbNjg5NTkuNzE4NzEwXSBDUFU6IDcgUElEOiAxNTggQ29tbTogDQo+ IGtzd2FwZDAgTm90IHRhaW50ZWQgNi4xLjAtcmM1LTIwMjIxMTE4LWRvZmxyLW1hYzgwMjEx ZGVidWcrICMxDQo+IE5vdiAxOSAwNjozMDoxMSBzZXJ2ZWVyc3RlcnRqZSBrZXJuZWw6IFs2 ODk1OS43MzI0NTddIEhhcmR3YXJlIG5hbWU6IFRvIEJlIA0KPiBGaWxsZWQgQnkgTy5FLk0u IFRvIEJlIEZpbGxlZCBCeSBPLkUuTS4vQjQ1MCBQcm80IFIyLjAsIEJJT1MgUDUuNjAgMTAv MjAvMjAyMg0KPiBOb3YgMTkgMDY6MzA6MTEgc2VydmVlcnN0ZXJ0amUga2VybmVsOiBbNjg5 NTkuNzQ2MzkxXSBSSVA6IA0KPiBlMDMwOnBtZHBfdGVzdF9hbmRfY2xlYXJfeW91bmcrMHgy NS8weDQwDQoNClRoZSBrZXJuZWwgdGlyZWQgdG8gcmVzZXQgdGhlICJhY2Nlc3NlZCIgYml0 IGluIHRoZSBwbWQgZW50cnkuDQoNCkl0IGRvZXMgc28gb25seSBzaW5jZSBjb21taXQgZWVk OWEzMjhhYTFhZS4gQmVmb3JlIHRoYXQNCnBtZHBfdGVzdF9hbmRfY2xlYXJfeW91bmcoKSBj b3VsZCBiZSBjYWxsZWQgb25seSBmb3IgaHVnZSBwYWdlcywgd2hpY2ggYXJlDQpkaXNhYmxl ZCBpbiBYZW4gUFYgZ3Vlc3RzLg0KDQpwbWRwX3Rlc3RfYW5kX2NsZWFyX3lvdW5nKCkgZG9l cyBhIHRlc3RfYW5kX2NsZWFyX2JpdCgpIG9mIHRoZSBwbWQgZW50cnksIHdoaWNoDQppcyBm YWlsaW5nIHNpbmNlIHRoZSBoeXBlcnZpc29yIGlzIGVtdWxhdGluZyBwdGUgZW50cnkgbW9k aWZpY2F0aW9ucyBvbmx5IChwbWQNCmFuZCBwdWQgZW50cmllcyBjYW4gYmUgc2V0IHZpYSBo eXBlcmNhbGxzIG9ubHkpLg0KDQpDb3VsZCB5b3UgcGxlYXNlIHRlc3QgdGhlIGF0dGFjaGVk IHBhdGNoIHdoZXRoZXIgaXQgZml4ZXMgdGhlIGlzc3VlIGZvciB5b3U/DQoNCg0KSnVlcmdl bg0KDQo= --------------LnoS1hZwb0nVyBNfaT4OOCul Content-Type: text/x-patch; charset=UTF-8; name="0001-x86-mm-fix-pmdp_test_and_clear_young-for-Xen-PV-gues.patch" Content-Disposition: attachment; filename*0="0001-x86-mm-fix-pmdp_test_and_clear_young-for-Xen-PV-gues.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlODllYTgxM2NjMDljYTdjMzFhZjgxYTg3YjQ4NTZjZDNlYmEzYWI5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ CkRhdGU6IE1vbiwgMjEgTm92IDIwMjIgMDc6NDE6MTQgKzAxMDAKU3ViamVjdDogW1BBVENI XSB4ODYvbW06IGZpeCBwbWRwX3Rlc3RfYW5kX2NsZWFyX3lvdW5nKCkgZm9yIFhlbiBQViBn dWVzdHMKCldoZW4gcnVubmluZyBhcyBhIFhlbiBQViBndWVzdHMgY29tbWl0IGVlZDlhMzI4 YWExYSAoIm1tOiB4ODY6IGFkZApDT05GSUdfQVJDSF9IQVNfTk9OTEVBRl9QTURfWU9VTkci KSBjYW4gY2F1c2UgYSBwcm90ZWN0aW9uIHZpb2xhdGlvbgppbiBwbWRwX3Rlc3RfYW5kX2Ns ZWFyX3lvdW5nKCk6CgogQlVHOiB1bmFibGUgdG8gaGFuZGxlIHBhZ2UgZmF1bHQgZm9yIGFk ZHJlc3M6IGZmZmY4ODgwMDgzMzc0ZDAKICNQRjogc3VwZXJ2aXNvciB3cml0ZSBhY2Nlc3Mg aW4ga2VybmVsIG1vZGUKICNQRjogZXJyb3JfY29kZSgweDAwMDMpIC0gcGVybWlzc2lvbnMg dmlvbGF0aW9uCiBQR0QgMzAyNjA2NyBQNEQgMzAyNjA2NyBQVUQgMzAyNzA2NyBQTUQgN2Zl ZTUwNjcgUFRFIDgwMTAwMDAwMDgzMzcwNjUKIE9vcHM6IDAwMDMgWyMxXSBQUkVFTVBUIFNN UCBOT1BUSQogQ1BVOiA3IFBJRDogMTU4IENvbW06IGtzd2FwZDAgTm90IHRhaW50ZWQgNi4x LjAtcmM1LTIwMjIxMTE4LWRvZmxyKyAjMQogUklQOiBlMDMwOnBtZHBfdGVzdF9hbmRfY2xl YXJfeW91bmcrMHgyNS8weDQwCgpUaGlzIGhhcHBlbnMgYmVjYXVzZSB0aGUgWGVuIGh5cGVy dmlzb3IgY2FuJ3QgZW11bGF0ZSBkaXJlY3Qgd3JpdGVzIHRvCnBhZ2UgdGFibGUgZW50cmll cyBvdGhlciB0aGFuIFBURXMuCgpJbiBvcmRlciB0byBmaXggdGhhdCBkbyB0aGUgUE1EIGFj Y2VzcyBiaXQgcmVzZXR0aW5nIG9ubHkgd2hlbiBub3QKcnVubmluZyBhcyBhIFhlbiBQViBn dWVzdC4gTm90ZSB0aGF0IFBVRCBlbnRyaWVzIGFyZSBubyBpc3N1ZSwgYXMgdGhvc2UKd29u J3QgYmUgd3JpdHRlbiBkaXJlY3RseSBieSB0aGUga2VybmVsIHdoZW4gcnVubmluZyBhcyBh IFhlbiBQViBndWVzdApkdWUgdG8gdHJhbnNwYXJlbnQgaHVnZSBwYWdlcyBiZWluZyBkaXNh YmxlZCBpbiB0aGF0IGNhc2UuCgpGaXhlczogZWVkOWEzMjhhYTFhICgibW06IHg4NjogYWRk IENPTkZJR19BUkNIX0hBU19OT05MRUFGX1BNRF9ZT1VORyIpClJlcG9ydGVkLWJ5OiBTYW5k ZXIgRWlrZWxlbmJvb20gPGxpbnV4QGVpa2VsZW5ib29tLml0PgpTaWduZWQtb2ZmLWJ5OiBK dWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+Ci0tLQogYXJjaC94ODYvbW0vcGd0YWJs ZS5jIHwgMTEgKysrKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyks IDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvYXJjaC94ODYvbW0vcGd0YWJsZS5jIGIv YXJjaC94ODYvbW0vcGd0YWJsZS5jCmluZGV4IDg1MjVmMjg3NmZiNC4uMDc2YTk5ZTc3ZTI4 IDEwMDY0NAotLS0gYS9hcmNoL3g4Ni9tbS9wZ3RhYmxlLmMKKysrIGIvYXJjaC94ODYvbW0v cGd0YWJsZS5jCkBAIC01NTYsOSArNTU2LDE0IEBAIGludCBwbWRwX3Rlc3RfYW5kX2NsZWFy X3lvdW5nKHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hLAogewogCWludCByZXQgPSAwOwog Ci0JaWYgKHBtZF95b3VuZygqcG1kcCkpCi0JCXJldCA9IHRlc3RfYW5kX2NsZWFyX2JpdChf UEFHRV9CSVRfQUNDRVNTRUQsCi0JCQkJCSAodW5zaWduZWQgbG9uZyAqKXBtZHApOworCWlm IChwbWRfeW91bmcoKnBtZHApKSB7CisJCWlmIChjcHVfZmVhdHVyZV9lbmFibGVkKFg4Nl9G RUFUVVJFX1hFTlBWKSkgeworCQkJcmV0ID0gMTsKKwkJfSBlbHNlIHsKKwkJCXJldCA9IHRl c3RfYW5kX2NsZWFyX2JpdChfUEFHRV9CSVRfQUNDRVNTRUQsCisJCQkJCQkgKHVuc2lnbmVk IGxvbmcgKilwbWRwKTsKKwkJfQorCX0KIAogCXJldHVybiByZXQ7CiB9Ci0tIAoyLjM1LjMK Cg== --------------LnoS1hZwb0nVyBNfaT4OOCul Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------LnoS1hZwb0nVyBNfaT4OOCul-- --------------329OYkFlR7h0dmdTzX2YNdD0-- --------------o6rTmt8hCoIt2ik0m6BGQhMn Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmN7JFIFAwAAAAAACgkQsN6d1ii/Ey/u 0Qf+NtFVtxXUf9jKqD/URRGmreeQ9YcGntIrDbw49OVDTP+fIIwh0pN92mR3CYH2eFWJ71YP178V 4TMG6K5Jy4mXVsIj7avO5wH9/88ZzAYS+KZZfz2o7kkzNmuiDkpIlkEa4uXukeF0FzLbt7qwvY1X mlD3ktSvBPW+Mc2jR9UdLkQWciDHe08sRZNaEdFPNYFlZver6d0ywDgZlUV+kN+LKk5nC9YnLTVi Qyu4hkdfWi0QmqK0iKCdCm6TUubQTJzGkj+lPLipW/VkKFveKXaXb37QBrn5iB9fSxrW+IfPC/mY KKnDmObhp64T4oKE3u+ImHYn0UpJnGmCZHII6jmrCg== =b81P -----END PGP SIGNATURE----- --------------o6rTmt8hCoIt2ik0m6BGQhMn-- From xen-devel-bounces@lists.xenproject.org Mon Nov 21 08:04:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 08:04:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446410.701968 (Exim 4.92) (envelope-from ) id 1ox1ms-0006hM-Ro; Mon, 21 Nov 2022 08:04:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446410.701968; Mon, 21 Nov 2022 08:04:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox1ms-0006hF-PA; Mon, 21 Nov 2022 08:04:18 +0000 Received: by outflank-mailman (input) for mailman id 446410; Mon, 21 Nov 2022 08:04:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox1mr-0006h9-Bi for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 08:04:17 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062b.outbound.protection.outlook.com [2a01:111:f400:7d00::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1632c0e8-6973-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 09:04:16 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8105.eurprd04.prod.outlook.com (2603:10a6:10:24a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.11; Mon, 21 Nov 2022 08:04:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 08:04:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1632c0e8-6973-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GxLp5rc3Ly1vkn3CLW0R2PvgflnK4Jgy/93aiHg625VBVP6pam6T+3gghhMgAnvpj2z+RiFGLWq5WJrq6N6wZcLIwRI+dDYcuprzp3LEKVcEG8On/wet9daogvtZq0kA8jvt2ZIzkd/aNB4K2ZyB43Xl3q8cm2dW9wLxqQLFr+US0gkfaB+XsPIw/pz237/sPhF/5iUye1eLaeigIV6ypXj+eZtfcGuuyKnLM/BiYlSfBbfns7xx/Vm0fdNUHQgR/ouSzOPYLdcVY/qYrdA5TKz3xKCLZvrnAFy9YB6w8BkCYJ6hbyTUcXQc5q0qORAE+ILIBL8k6VOTLzTefpvIBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B1oerJ/CYyTjY9T3AnzNTNUOt+7S9HlMFlNCOHSnzcQ=; b=eSSHDLlf79wH7+N3a55MW0JvDEH/EdPI7CF1jq72om0uwBgkArfFsjx/G4hVuNFsKg8HHnlbJN3l7b7bxhHjLLqihzkP58/Px/A00bqGKixE73kee6qRBYn4k2/zcDi8fBX8iaEHe2fLidrZOgdooUFpb+j+wAMMUOAjFwIMVDJDejINi0Xww7Hg3E8bIp1qOdpg/yprkeCVwEfncHAROZGHmJNW7R9R0UmBdswqgxJ/7oWuSt/ZgEo3gt/zGfAYxKiprWMoaRfmeuZqPztFMNJW5l7eswCG6aWmamm5i/EgmUTF77oOBzUX4OA7hd9v1bZP+RTNp0jxQHfk6mqiPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B1oerJ/CYyTjY9T3AnzNTNUOt+7S9HlMFlNCOHSnzcQ=; b=gG2i3nbmjOTamQIypdBl4SYqrwh0rg5W7x20iMMuBVGz4JIy9Euxw644knkXtgp15Q9W9AUGvlT4Ew+WD08KoSI8UPFfctl1J8x1/qY1Se40xMqDwkETkjL+v+p2ZZ3yzHG0UTDzABq+s4h9kMqaAiCieInXWs1S7iRiKPgKIFkR7tWyII1bcyyrgPElCWmzkQdFo1niWXzHKdfUbuYpFi0Uz4RAx2LngIqJZ7AWm1bQG9Aawt0OqERWNpEl2elSuQlhE5yFyC08NHioxgUOCzktu48+nw4XOVmzKnmPnwf6PQpxNSJl8ennwVOteX+SV27pGEeh7gE/UddoIvEs6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <08577045-517d-3566-9931-dcc1df6c2cb6@suse.com> Date: Mon, 21 Nov 2022 09:04:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: Flask vs paging mempool - Was: [xen-unstable test] 174809: regressions - trouble: broken/fail/pass Content-Language: en-US To: "Daniel P. Smith" Cc: Roger Pau Monne , Henry Wang , Anthony Perard , "xen-devel@lists.xenproject.org" , Jason Andryuk , Andrew Cooper References: <6846bb37-345e-ca3d-4cad-2032c4852e15@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0022.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8105:EE_ X-MS-Office365-Filtering-Correlation-Id: 05034cd2-6e06-496a-f089-08dacb96f95d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fk1qPCIL4u5jovmitytYXMrug7/a9rN7amb8C6IcQTu6efDgiHw5OHUInzVqJRmNP6ZWJMd+FtKEmKDBa/V+KPq6915JS6P0CLRVUTuWufzhN6ooLcmuPabUHIEoo5A6/vOszN+sLeua3YElXq51cr9jzpuze2CcjjCYlhZZ6edWCJHhJ1yfiuBMMvo7Sv7gBNvQPggA8kDPaOxVc8qaH7k/QItA+zDhXZyv19H11GpOWrMP7viDHssfwjuTvfRgCdsC/nCKfOa+q/d4E4KpdNPrpBUGe/oddyO0GfkGftU4ZI5ZIVtKM/5XeQuiBCDtrgeist7n9SamSigFNVAx49cLtvp9+qyIAjOuvKDxp1/TacqzAuE+JK1YZBBGGq8P5zj1ZZq8AVKxTK1Nfu9KQm9B5oh1pcI8vOj6TuiqgBZRCxO0KC2DLKcAayeWUZYFyqmGCXE2k8XKGvjaKpcN4RO475Uq5xcindqSmIAhiBQ6fS+w/ayA8VMEBRfeb0WiSWbQdd3ebnHsg0p8Pd+9eLe4LGZJChNQ2OY9093qhuOXUnQTvh7Z7dfo3QvaFyffdajIFUA5Xza1TZTASpVtunsIqNqheHdlD9++Qii5Bp575kA2j1+XOW/BiKn2pG7e8GN/k0xVQAR7fC06a8XqbEGS8OlF/4FoIy70y4mR7rPP5uuohSYG/Z+VmUyVbf6FDk/eRudofFh0ZIBw5UbY+ahUKRDaLR4v/oWD0sTTRms= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(396003)(39860400002)(366004)(346002)(451199015)(26005)(38100700002)(54906003)(86362001)(31696002)(478600001)(6506007)(5660300002)(53546011)(8936002)(6486002)(66946007)(4326008)(8676002)(66476007)(316002)(41300700001)(66556008)(6916009)(186003)(2906002)(2616005)(83380400001)(6512007)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0VqRWpVT25ZWGdheEZwSVBkMVpoOTdsbVpNZ05xdHRjc2FqaVFNekRjSVZj?= =?utf-8?B?NitLSjhTZi9RbSt1ZmhLY2wxUGFkQ3E1RDZ4eVpoQkxZUm9veko5eTF6eWtw?= =?utf-8?B?eDRwNktCNW4vUkZnOEFPKzk0NGpCRkE2ekEvMm5MNVpudDNQeVNNcFkvQUI4?= =?utf-8?B?WGFBaDQ1dFdLWHNMY1VMYjBTaGM0RmN5cEpNdHQrVU1wUVhsUzV6dWVsaUN4?= =?utf-8?B?YzlhTVFjVnpxbmxVaXZYc3IzTmdDdUtzck1zcVFNTUExd1h0MWV1ZWhCTjlQ?= =?utf-8?B?bVoxcDV4bmlqcHNJOWExaXNVZVlxNjA4N05idnFvZjJteWt3NmFVNXQ2RkZh?= =?utf-8?B?eC9RQW5uR0YzQTZHQ3JjU1hPM1FKcVdlbndoZHZOdTJZOEFiVC9IVTVRdENZ?= =?utf-8?B?R2xqZWNya3FEQ1phWXlDcXpzNHhSMXowS3NES2RPQWRsak5NdFUvQ2FQVkdU?= =?utf-8?B?Rm9ieTVBQWRWcjd4dENiZ3NFOFpYM0wxcGJMMWxnNzVUc2pjU3Q4RTdoM0Jk?= =?utf-8?B?SW0xdUF0N3pKcENaa3orS1JtSm5Zdnpsb05UN09CU2dTZlpuV0sySXl2VXhR?= =?utf-8?B?S2x3emI3UFdyd3ZZcEtHOGJDaVFRS2FxZUwvL0xQRTBRVjBWdkloai8rNmpn?= =?utf-8?B?QXhLUmZzK0pNU3ZNZXZaaDFPN1RWNktPbERJZUdReVA0dU4yNFNTb0t3bDBQ?= =?utf-8?B?cFZ6dFo0TmIyTXI2Mkd6TXJNeFFtRHZ6bjJDOG1Bc0ZDZDdIeVVIN3BpemJF?= =?utf-8?B?ZGNGbWt3QWFFamNQM0h0Ykc2VWdRREFuaFlXa2RaaFpmV3lKS2V1RS8yNEg5?= =?utf-8?B?ZTIrSVJmc093dVJTYi84a0FBVzBQWXpSTUoyUWxVN1g5dE9rKzI4SlB3dThh?= =?utf-8?B?ZERXUkR4KzRRaFdnemtkclI5djNGV2kxeFdoa0lmNjFtbm5qQ2NSaTBxZ2t4?= =?utf-8?B?QTJITDFNYnBzU3pnVUlTM0hocXlFZGNrQVBBUzlaakVRTWNicURMc0Vzc014?= =?utf-8?B?RTd0dVRrcDV5R2lpZ1NxVi9JM1kvR1h2S3RCZ0toWFJReElpVXhOQjJiYUJM?= =?utf-8?B?VjM4aE5WZTFsbTRBMmp3cXhuNlc4d1pzb09ydWdidVBpSE0wSlVSSkpVWStv?= =?utf-8?B?cUlQZktseGl1ZGptNjRKUDlSMjJOb2FSY3dHbzQreEdDZDcrQXRCS2NwUktz?= =?utf-8?B?Z2hmdzY2SW0ra0UwaVEvVUZZK3JlYU5FYnVjMnh3TTJKOVVMelN3RDNhS3k3?= =?utf-8?B?LzJXREVSMzZveG5HaXVuUnRwdUhQVGNZV2hNVjFmQmpuWjVheDJGTjAyeTJv?= =?utf-8?B?dE9reEFQYi9LaEI2eUJQeC90OUFBRC9ONWNPN0RKcUo3M28wODl2UUEwUUhh?= =?utf-8?B?SHFvWU5wWUZqL3F0YUhWd2ZibHZYTHRJVHhPaVJDTkczWE9DVkljL1JxTGh1?= =?utf-8?B?SHQzbWhIUSticm5MLzM2TEM4dGE1SmQ2UmMzUmVMTUdRbnZjRGFXSlAvSnNV?= =?utf-8?B?ajFuZG1PcjhuQTZzT0pKRmNpY2RBTHJRVjE5UEVUQVVucUo5Wk9IK1FicWRL?= =?utf-8?B?aHg3YkZ6dTlIYW9qUVcvdS9hTjVhYW9LQzVWanV2OUdzWmFtVXFwRmJlVEcv?= =?utf-8?B?a2VoVUtPMGZma2hrcnRNUlNxdEZuNmZLQlVxcndSMmRoNitZQ2ZhNjR4dmdN?= =?utf-8?B?KzNUYnhhNklsNEtLRHZnbEFNMHkvbVVOdktIU25ySjBqa3ZKQ3hBVGI5SnlH?= =?utf-8?B?YjFQL2xibnpjWkswbStjNkVVR3FwMW1VYklybVY2RUxaTUpQaUxja2w1Nmx1?= =?utf-8?B?OTRxL2lOSmtmVlVNR0xubXJReER3TnJkenMxdUZKZzJMUkwwdFhYK01YMk5P?= =?utf-8?B?Ynh4UUFSb3VSSXpBRkY2eUNZeGNsaHRZbGlRWStxYUxjYndENllLcTlXZ2U0?= =?utf-8?B?cG92cy9UUGpTZUhsR2ZpVHJLaE9YT3UyYjZXVmVPeGZTU3Z4NnlqangzNFdL?= =?utf-8?B?WTAvYnd0d3RFR3BwU2ZQTmovT2k0c0F0MHM0ZXIzdW5MYm1uOXpUUWlTZUIz?= =?utf-8?B?ZVB4RG03azNyQ0ZiMkx4cGU5Q29MR1Q4R3BBRUxVUmdlcTE1UldpMDNDV3ZP?= =?utf-8?Q?gImsWnMPNPPChupEL4Q/vo2SM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05034cd2-6e06-496a-f089-08dacb96f95d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 08:04:11.7125 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qghO3wFoUQtuUDaLFW7W8QDXZN3hBNeaNS6MIBvUZnLNvm+VOenQMgU9t+5x0hn9JKih8mi1qLVoLUSUQHgPWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8105 On 20.11.2022 12:08, Daniel P. Smith wrote: > On 11/18/22 16:10, Jason Andryuk wrote: >> On Fri, Nov 18, 2022 at 12:22 PM Andrew Cooper wrote: >>> For Flask, we need new access vectors because this is a common >>> hypercall, but I'm unsure how to interlink it with x86's shadow >>> control. This will require a bit of pondering, but it is probably >>> easier to just leave them unlinked. >> >> It sort of seems like it could go under domain2 since domain/domain2 >> have most of the memory stuff, but it is non-PV. shadow has its own >> set of hooks. It could go in hvm which already has some memory stuff. > > Since the new hypercall is for managing a memory pool for any domain, > though HVM is the only one supported today, imho it belongs under > domain/domain2. > > Something to consider is that there is another guest memory pool that is > managed, the PoD pool, which has a dedicated privilege for it. This > leads me to the question of whether access to manage the PoD pool and > the paging pool size should be separate accesses or whether they should > be under the same access. IMHO I believe it should be the latter as I > can see no benefit in disaggregating access to the PoD pool and the > paging pool. In fact I find myself thinking in terms of should the > managing domain have control over the size of any backing memory pools > for the target domain. I am not seeing any benefit to discriminating > between which backing memory pool a managing domain should be able to > manage. With that said, I am open to being convinced otherwise. Yet the two pools are of quite different nature: The PoD pool is memory the domain itself gets to use (more precisely it is memory temporarily "stolen" from the domain). The paging pool, otoh, is memory we need to make the domain actually function, without the guest having access to that memory. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 21 08:16:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 08:16:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446416.701980 (Exim 4.92) (envelope-from ) id 1ox1yZ-0008IA-VJ; Mon, 21 Nov 2022 08:16:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446416.701980; Mon, 21 Nov 2022 08:16:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox1yZ-0008I3-ST; Mon, 21 Nov 2022 08:16:23 +0000 Received: by outflank-mailman (input) for mailman id 446416; Mon, 21 Nov 2022 08:16:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox1yY-0008Hx-Q9 for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 08:16:22 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130040.outbound.protection.outlook.com [40.107.13.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c77b2d42-6974-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 09:16:20 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7130.eurprd04.prod.outlook.com (2603:10a6:10:123::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 08:15:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 08:15:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c77b2d42-6974-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ePHgTCw/0S0He11zh/wkhojr1U4TDHNyQKmx2PoL8GYkFNlGAxHIV88joeCv3GYnOaNGZK+OCNUb+5lvyGHbAPsdJUA2dvgPQCYSpUBjhcg22cu7YrEwNNpgxui+d2pJCXV0GUbsDjfRtemBetPXT8h1poCI9Tb0xcQVFG0lbu3l1s9hHYCFgZd0oVMTfbn7ej6DhiZjjFxQvcWUdAxfxZ/MSCCd4gAgRJsov5EtLIHvj1pCbC2SGs31CqiS5MLDZjAcCSjyxebyjsLo8y6kZQsH70hOGVMl8gZ7ImqtbEBSHDs6wCew9stLt+p42ByjZIWtvkfn667p11n4n5Vf5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/zVZrDcTECDCUU9XSL7IpNafkjQIy37KSqkWvtAnlC4=; b=GOZ+mDebiS/642wYxuuhv6mp4fqLaDyB/VoI/v2oH4VjObrGBtIBhTf4CWwnZdRaq304HJfruLhUzj92asUaAern84mPh5UffcT8F6qkzumHBV62KrAggqJdDzKtt7iC8SGvui3m5oZHSqDKVhs0/QHAeGqVcdlTSMagNUVSbXMIccqcSpsGttniKwLySrRJQ/Og0HQ863CRgUsk4bxiEHeKnXn6dOoWO3GVRcg3CXg9EvjYvvXKLPP1TA55Z0nQDse9k9wFwugdAANpH3dOxqybXEp+TyZB3Zv5fRhHcnP/WqXN9y656xSL4La2Fo3EeaGx0wuF3MBkwm+rzkzF/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/zVZrDcTECDCUU9XSL7IpNafkjQIy37KSqkWvtAnlC4=; b=oEAk6qcRxvOyl0aV1ivUigl6G9AaN6H35FdpUc9VxSgBSSXSNbMftdBc2nhMSAdi40xJE9joziM7WdfsvArE79780xLj+uvs2W9KPKmLDp5TW47grCmhSzMnT9mwmT6s1e1OXTSPkOFWzDr5tAFW/WA94tK85DN7oPNp6czT3kg7bft0SiC9WJBWFO6/CKvbOkq8t1wiFmB7hMY24eKaVyjrr+Mo5f71IVg2qV/Ljb24i+0XDq+1+GWqy6gFTUggZ46okqacSH9nTXxokOsa07O4XQnTXH9BgE1rYcshYbr7BY++rhB5hoaZFk4LKRIhST8T9eevQ1Ht3hxZevIaAA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 21 Nov 2022 09:15:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2] efifb: ignore frame buffer with invalid configuration Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20221118141132.26242-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20221118141132.26242-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7130:EE_ X-MS-Office365-Filtering-Correlation-Id: e8c85098-1408-4f4a-b21f-08dacb989ad0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6AvcV3ZZOpymyWQ+Kc3tJzAQJNHQTPsyCLTUhLic0p/ykoF1Dp0OO8oVp3w1c1ZYCuzwTZPAVpnpdlcGk6UEbYdEU2C9ImlnmT+4P1pN9jFoiOC2WYkVb7+Bw0F9Y1YehxPj7nnOPpB4XnB1cfJm2Ll6KmW5vM73uKbrlKSG61qR7dLVg0wlAnx5y/r5xJRhEpTk1DtiD9f4gukECIfLaSQRhEZ95/9YNOnecPXdsG5M/KeCmUAmaHScY7JS8m1D7HHqrEcxaL0qj4WhnAitTxhpHpWBPTk292FAGLrdVGvnuMcEKlg7W7/pyd10yZw3z4i9AVdmeQ+Oz91o4Hv2oQTEu0LilaM26HPusB2PO2K2Bhrv8DUdAftqkn8ydroDYjIDBvhi9q+euIMfw3d84SOFSLhqUCvPI+a4KEjX6ulLGU/0701/rBAj7U1qR5eN9Kf9cm9umzWVGS3qiZnr83LL7xTLvzztQfbAi7se1vDJ4qfY7m1ps6TachQzbUdaIdTEcjwUHfJTYmEw0RuddYmxgBObkq9C9bg78uSaUUlpst3REhYnox4bgMB4yCqUIVGjaSxFK2LPJDZ6b/D0Z6WQq9wyJjTGHvqVvquZQ1HCFaHcfD4Oo1MfiTL0xxTg+d/4lqVTEmUi4tLozYWfLPSzpDJ9BU0/7TAEIiaywOmD00WW7uzlOOeuSJL1EWCFZbGzZgUc2P5sdunLubv3ne1pEABYc2SilxJhKflLhFg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(136003)(39860400002)(376002)(366004)(451199015)(38100700002)(478600001)(86362001)(6486002)(31686004)(6506007)(316002)(186003)(2616005)(36756003)(8936002)(54906003)(6916009)(26005)(2906002)(53546011)(41300700001)(31696002)(8676002)(66946007)(6512007)(66556008)(4326008)(5660300002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0FqZnFGTEE1Z3FWZjZ6QjZmYzBHMVRXV2ErQnlac2M1U1FHUFpueENzc0g2?= =?utf-8?B?UytETGRINjVFMUVzQmJaL3lyK0l4UmwwNzROZ2l0cDdwTU5RUUcvR1VPVGdk?= =?utf-8?B?cG9Kb1Jhc05CSlBOL3JnTkx3dmpRNTRtbDN3YjU3ZTVpVDk3NmJNZG1MZWRo?= =?utf-8?B?T1dWc1oxMWY1Ti84NEs1ZUxncWUxUUJ3MFZORVRlMG5HWlMrRndUblVYODZG?= =?utf-8?B?L1ZoRXlVRmRwcEVSaDZueEpwLzlyMXpmSk9qcXVWMjhHd3RmYjVLYkRncTVL?= =?utf-8?B?YUlyUENkd01zYWlBYmMvMWpJTXlaL3VmaEk5Umlnb21GZnVDTnhIc21KY0c0?= =?utf-8?B?WE4ybXhtc3l1Y2VhZUREWTMvc0tBdVRUYlR5cVB3ekhiVFV4N1A2eHBxb2tT?= =?utf-8?B?UG84aUVPYWsyMzM1NGpwQzVDbWQrQ1prQTdxYnFYK2MwUHc5dkR3NWhyZkJF?= =?utf-8?B?S2JRa1JrY0syNmlHRSt4cXptd2t3VW4wY0RGT2dzVlVFOHQycWp4TXFRV2R4?= =?utf-8?B?eHd4dEdpMUw1NWZMM2NySUQvVVJINEhaYkF2YzE3dWZKQy9tOGw1d2ZYdkNB?= =?utf-8?B?N2t4MUVOUHZ0eDdGR2RoWkUwcU9rakhROU1VcnZ1ZzROajV5ZktXcHdvN3lM?= =?utf-8?B?Y2VRZzMvYVNXL3hyV3V2WnZlWHY5TitDNWpYUzJKR2RpdXp0cG5JbGhrWkMy?= =?utf-8?B?V2dKc1FGMTJZbUdZM3FZRW53R0tnUU1vakIyd1pMMGlvK01IQzBiMkhrQlcv?= =?utf-8?B?RzlGdk1QUU1GU2QzV0JhdEZSVVFrTi9BaThVWkxaWXUxOStBa0Naa0I2aWNw?= =?utf-8?B?NnZFK3IxOVFkU0R6R3FqZXh3aWdEZFlWZHI0SUxhU2ZidUpSU3VsejVjQVdW?= =?utf-8?B?TkV1bEl0RUhQUzB1UlcvaVhOa2lIZS9CcThoZktsZDc5RUxYMkVZd04zZDV0?= =?utf-8?B?a1hHRGhwMUsvSFpXMkU0UmxnZVZHT3JqMVhyNzBUcGxCVzRBVWFLeGxIMzZ6?= =?utf-8?B?K055d3Fxb2ppbUNiYXdMSlVtRzh3UFpyTEZaLzkxOUU2QmFpTlVPL21JYW1Z?= =?utf-8?B?bW9QdUdnMTd3Z1JWeUlnZXhHclM0U04zWG5LQ1hGV1ExeHduQW1tOWZ1QmZR?= =?utf-8?B?SGdzcC9DSTNXdHlFMGM4dnk1MVZIaHd4YnNGMWl1NTJxNGVKNlA1UHZrVE1Y?= =?utf-8?B?T1d1RDRYdDl0VE9TajQxcElVdExUMG0yQ1JHSjdZUHpsT0toWnQ3USt4dTdn?= =?utf-8?B?U2VLN1BCYXJzY2RGdWlKdUdJTzllaEpnUEhqSkI0NTVXTStkdllkVzgwSlg3?= =?utf-8?B?SEp4QllQQVJWeU5wQmtGV3JFMHJVQkQyMzhXN2JCUnlnUy8rTzVtWlVQTHNQ?= =?utf-8?B?MUdYZVdjUXgxcnNuWTJBdTBMZDFRenpTdUNNK0VJdUtqdnZpM1h3dit3K3Ji?= =?utf-8?B?cVhsTVdQZEpQWDBGTTVFbWZCMk82UU0zRERxcFJMWUNQeU16QzhWd0RvUitk?= =?utf-8?B?aDZQODBsb0JvY0hvYXRhWEl4TEVLaXZEUk4zWnFiTmhTYXFDQjY0ZHVPNlN1?= =?utf-8?B?c3RZSVVDSGdxbXZNbUtXalRUbHpRUzF6VzE5aHl4bDNyZ0ttLzdxZjlkUWRq?= =?utf-8?B?bHE0bG9yYmpiQklvRmpzdDJjcS94Umtwc1RpajJ2d1NZMFZKL0U3by9pWkFB?= =?utf-8?B?WXArQ21hb3lkS1hHOE10MEpQdXZ3VlZUZTVOL2tiUldnbVExQUowQ2dHUWtQ?= =?utf-8?B?eXZFZVVJaVR5RGRYeVZoUHhGVXVtQ0pva0hLRWtiTDRPaFFTVmNaRmpDbmVJ?= =?utf-8?B?RFQrYlh1OW52SHo0WlFTZjNYUE1DcjF3ZDZ5a2xkRUtHM1BFaUtLcVQ5c2Yw?= =?utf-8?B?QW41UEZkcG9PZlB4NmtMbDdZSjRObzRjdE9rUXBTVzk5VzFsY1lWZGZ3bEs5?= =?utf-8?B?cW5QZ3RNYTA4UDE5RzhzY2F6ODIwU0NFeVNuSm1uajRGR2FaVVlWQ1NFYzZp?= =?utf-8?B?R2hoVjcrMVVKTjQ3SkF4aVNMcFNOUWhTUnJUUXZOdERFN3cwYjV0QmU3b0ZY?= =?utf-8?B?TmZoUDhiZ01zWXdkUjZiWVlUa2FSeEdJUjZ4azhVWXB3T0VtOGRlcXdndkRB?= =?utf-8?Q?3EzAfDog6r0/4/sezIhDGEAkQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8c85098-1408-4f4a-b21f-08dacb989ad0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 08:15:52.0276 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hbxzhkyu6nSGbKZ+Fm8zYlRd2P4QHGRpXIZNe0i4086A5KLoF3TiK5/y3WFd4YKBMazd5UzFYHsmG9VcOba+sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7130 On 18.11.2022 15:11, Roger Pau Monne wrote: > On one of my boxes when the HDMI cable is not plugged in the > FrameBufferBase of the EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE structure is > set to 0 by the firmware (while some of the other fields looking > plausible). > > Such (bogus address) ends up mapped in vesa_init(), and since it > overlaps with a RAM region the whole system goes down pretty badly, > see: > > (XEN) vesafb: framebuffer at 0x0000000000000000, mapped to 0xffff82c000201000, using 35209k, total 35209k > (XEN) vesafb: mode is 0x37557x32, linelength=960, font 8x16 > (XEN) vesafb: Truecolor: size=8:8:8:8, shift=24:0:8:16 > (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) �ERROR: Class:0; Subclass:0; Operation: 0 > ERROR: No ConOut > ERROR: No ConIn > > Do like Linux and prevent using the EFI Frame Buffer if the base > address is 0. This is inline with the logic in Linuxes > fb_base_is_valid() function at drivers/video/fbdev/efifb.c v6.0.9. > > See also Linux commit 133bb070e94ab41d750c6f2160c8843e46f11b78 for > further reference. > > Also prevent using Frame Buffers that have a 0 height or width, as > those are also invalid. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Nov 21 08:21:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 08:21:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446421.701991 (Exim 4.92) (envelope-from ) id 1ox23N-0001Qp-N0; Mon, 21 Nov 2022 08:21:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446421.701991; Mon, 21 Nov 2022 08:21:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox23N-0001Qi-K8; Mon, 21 Nov 2022 08:21:21 +0000 Received: by outflank-mailman (input) for mailman id 446421; Mon, 21 Nov 2022 08:18:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox20o-0000TJ-3q for xen-devel@lists.xen.org; Mon, 21 Nov 2022 08:18:42 +0000 Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [2607:f8b0:4864:20::e2a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1a8b8484-6975-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 09:18:41 +0100 (CET) Received: by mail-vs1-xe2a.google.com with SMTP id t5so10483954vsh.8 for ; Mon, 21 Nov 2022 00:18:40 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a8b8484-6975-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5FNLqZ3+KdQjzm7Sx3mBq4NxeuMTkAwBYeRYu3X/hpw=; b=ZT1IBXqXR8n7CAGsZwETJtXB5s+32HQ0WfDf9ELFM7TnqZKlgWOeBc/bChoGMeTXZI DBw5IgWzhYRwwB8q2PlTYpDsgp/Xn0faD8qlQqeqGTzK+LtA5bO4pTSl6VhvOF3XjuUB v7cQhUjxPdiSW4o/cUm4GMGrYxkl6E57CDG+DeRbt7ONLQ4PRpM51bw/quQN3Qeh/nRb JOozyTr672VPCmMVeXPM/Pap3nqPGUKwDDQvfOazKh7eIRlTkGXUgXoNOSeHNoDkShnQ BYjmuzxMjI4p4EU4gVYY8/BJb9B8jMg9lMMiMnAoeTTtQL0QVNNx19/DQH0TeRn3a1mM HCZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5FNLqZ3+KdQjzm7Sx3mBq4NxeuMTkAwBYeRYu3X/hpw=; b=5fdvJ+5DLTsZrkncGLlOfUDJXAvqKb25ydwgMvpuuAdQNyqzEwEG57Kcwie4dv1h+F Dz+XH/HeCDu7G5R5S+xUoFnNvevrfOvOkarWfcMxiJHaXlwV/8rLcpB3eaZFTyxjoNZ5 Qfd+lBy0HPlJHZ8DTeTCT26UH7qSA5r67KC6HddQNW+s9xwqkOt+B2qpTtuIG2c05NLL OfcHqWZke3jkTSgkhOBZfuylJuc0mxP6/kLDPFBdpIJeT/Es4FxykOL1URPG9yf2j8r2 z4HwLxru90YHz5dzHlLsA/86ZOeSmuaY8fG+jSVde9t4Bbj02c3WTqanN+9ANIZnGe/h nLfA== X-Gm-Message-State: ANoB5pmLbF/i5nTL6bjY6EJTHu1nIQf/C1jKHxhj2Y0ZIetD5cIDbOmP pNbFBm1X1wh1vAdhi7ahPR76Z6jexu3b2/yy+4EHaw== X-Google-Smtp-Source: AA0mqf6QG/XZV0N6cp0tywJ1b6hLNvJyyPYmMjylRsqJ9dVG67YrNCJaKMIbcALAv7PxmXvGlzEcAkmgNqBCPxSecSs= X-Received: by 2002:a67:c98e:0:b0:3ad:3d65:22b with SMTP id y14-20020a67c98e000000b003ad3d65022bmr3275421vsk.65.1669018718896; Mon, 21 Nov 2022 00:18:38 -0800 (PST) MIME-Version: 1.0 References: <42579618-f8e2-9fd2-0b6c-f2c87f7c57a6@eikelenboom.it> <99178e0a-ff6a-9bfa-4ade-b4bf6fdc306f@suse.com> In-Reply-To: <99178e0a-ff6a-9bfa-4ade-b4bf6fdc306f@suse.com> From: Yu Zhao Date: Mon, 21 Nov 2022 01:18:02 -0700 Message-ID: Subject: Re: Xen-unstable Linux-6.1.0-rc5 BUG: unable to handle page fault for address: ffff8880083374d0 To: Juergen Gross , Sander Eikelenboom Cc: linux-kernel , Xen-devel Content-Type: text/plain; charset="UTF-8" On Mon, Nov 21, 2022 at 12:10 AM Juergen Gross wrote: > > On 19.11.22 09:28, Sander Eikelenboom wrote: > > Hi Yu / Juergen, Hi Sander / Juergen, Thanks for the report and the analysis. > > This night I got a dom0 kernel crash on my new Ryzen box running Xen-unstable > > and a Linux-6.1.0-rc5 kernel. > > I did enable the new and shiny MGLRU, could this be related ? > > It might be related, but I think it could happen independently from it. Yes, I think it's related. > > Nov 19 06:30:11 serveerstertje kernel: [68959.647371] BUG: unable to handle page > > fault for address: ffff8880083374d0 > > Nov 19 06:30:11 serveerstertje kernel: [68959.663555] #PF: supervisor write > > access in kernel mode > > Nov 19 06:30:11 serveerstertje kernel: [68959.677542] #PF: error_code(0x0003) - > > permissions violation > > Nov 19 06:30:11 serveerstertje kernel: [68959.691181] PGD 3026067 P4D 3026067 > > PUD 3027067 PMD 7fee5067 PTE 8010000008337065 > > Nov 19 06:30:11 serveerstertje kernel: [68959.705084] Oops: 0003 [#1] PREEMPT > > SMP NOPTI > > Nov 19 06:30:11 serveerstertje kernel: [68959.718710] CPU: 7 PID: 158 Comm: > > kswapd0 Not tainted 6.1.0-rc5-20221118-doflr-mac80211debug+ #1 > > Nov 19 06:30:11 serveerstertje kernel: [68959.732457] Hardware name: To Be > > Filled By O.E.M. To Be Filled By O.E.M./B450 Pro4 R2.0, BIOS P5.60 10/20/2022 > > Nov 19 06:30:11 serveerstertje kernel: [68959.746391] RIP: > > e030:pmdp_test_and_clear_young+0x25/0x40 > > The kernel tired to reset the "accessed" bit in the pmd entry. Correct. > It does so only since commit eed9a328aa1ae. Before that > pmdp_test_and_clear_young() could be called only for huge pages, which are > disabled in Xen PV guests. Correct. After that commit, we also can clear the accessed bit in non-leaf PMD entries (pointing to PTE tables). > pmdp_test_and_clear_young() does a test_and_clear_bit() of the pmd entry, which > is failing since the hypervisor is emulating pte entry modifications only (pmd > and pud entries can be set via hypercalls only). > > Could you please test the attached patch whether it fixes the issue for you? There is a runtime kill switch for ARCH_HAS_NONLEAF_PMD_YOUNG, since I wasn't able to verify this capability on all x86 varieties. The following should do it: # cat /sys/kernel/mm/lru_gen/enabled 0x0007 # echo 3 >/sys/kernel/mm/lru_gen/enabled Details are in Documentation/admin-guide/mm/multigen_lru.rst. Alternatively, we could make ARCH_HAS_NONLEAF_PMD_YOUNG a runtime check similar to arch_has_hw_pte_young() on arm64. From xen-devel-bounces@lists.xenproject.org Mon Nov 21 08:25:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 08:25:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446429.702002 (Exim 4.92) (envelope-from ) id 1ox27g-00023N-8U; Mon, 21 Nov 2022 08:25:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446429.702002; Mon, 21 Nov 2022 08:25:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox27g-00023G-5b; Mon, 21 Nov 2022 08:25:48 +0000 Received: by outflank-mailman (input) for mailman id 446429; Mon, 21 Nov 2022 08:25:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox27f-000236-DC; Mon, 21 Nov 2022 08:25:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox27f-00086F-BN; Mon, 21 Nov 2022 08:25:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox27e-0006vv-UJ; Mon, 21 Nov 2022 08:25:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ox27e-0004Lp-Tr; Mon, 21 Nov 2022 08:25:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rvFd8+MAXprn9UfQXxOF7+C+PwX6/4qXGyPhjih5AUg=; b=VtD41aoiFw7flSa/YNqDZymsUw C3v7HZ1LdjDe9BhJm8+PZT+VdgA8aQCMv+abaDlqzuZBX7X/lzpswM74zwWW2IUy2VxYFVsgcbW6L TxRk3laxh9Ht0BVp1BP3TLykRWO2418fObwzs/La5aWPfn5OncQ9GEc9zJnYkbuX3qFI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174871: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Mon, 21 Nov 2022 08:25:46 +0000 flight 174871 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174871/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 44 days Failing since 173470 2022-10-08 06:21:34 Z 44 days 78 attempts Testing same since 174871 2022-11-21 00:40:59 Z 0 days 1 attempts ------------------------------------------------------------ 1802 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 171425 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Nov 21 08:34:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 08:34:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446439.702013 (Exim 4.92) (envelope-from ) id 1ox2G1-0003b0-4V; Mon, 21 Nov 2022 08:34:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446439.702013; Mon, 21 Nov 2022 08:34:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox2G1-0003at-0P; Mon, 21 Nov 2022 08:34:25 +0000 Received: by outflank-mailman (input) for mailman id 446439; Mon, 21 Nov 2022 08:34:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox2Fz-0003an-80 for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 08:34:23 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130059.outbound.protection.outlook.com [40.107.13.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4bf3532f-6977-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 09:34:21 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8273.eurprd04.prod.outlook.com (2603:10a6:20b:3e5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 08:33:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 08:33:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bf3532f-6977-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fjG7QIyISG1RuCEKsXUOBY6f9EBN8MGUPEFO0eENjMDoTgkZoZIztv1b5N+KwJdGjbkguw6zYs4bemVvkyqjGrgB+ncgncVJV/oQAMEFK+fiftl21DVWW41bTxVGIJg3KRQh9FzbJeCq+SXsqRa3QOihzJupx35XSjIlv3EC+I3HUVgCRV4V4ZovjYTpzVx1aAAXswAam2xx1n7NezuNXJ/Jikab2WFQ+2wV/5HmUyBq3apMo9ZX/oenqtP/KdIQZfwZ+L2fFAFoHx+i2/SW/l3uuurZ+QmbBxOg+dAaqT+RtOrNQdBgisPuAlk7PWP2G4B9ZUyaJOQctSSe7ZWNcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6/ZsOhRYGx9QcVg/XJaeGGZ4mApFDuRwmnp8U76S0wg=; b=BFoKZnwb17+ILd6NE5WbmUAC+FXziIU2IS5P9Vd+PBkEuQg2t/cn+fOCxxWrOcsaaB6+ymRSqF3BnQCiWFkHMO2Z10fkx4/e4FelmjBBnR6Z/b8e7I1SH1i1jYuCoH8lAKDkI1694qlDinLtM5VFEXXpXezDaXee4ZyeEruc0uwztocI50VtBM77Eq5HBV4r8eu7a+7ujs+k6Fb0wyewKAJADoC5XLqB+fvJ6CuzShp+e4p22R/Wy4n4kw7griF5dfEDtWBAuLTudEMNHtrIdY79voDz5VDnf2g0Pq+8XXbLgFA2IJaOpbqaRAi6MBthkzW2KQ0KpOh0cES4X3dPKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6/ZsOhRYGx9QcVg/XJaeGGZ4mApFDuRwmnp8U76S0wg=; b=zyIEVuTXpnWCT00qzXB8y8aYFkO5NGnb4Ejpt0gwx/+ra7slR2G8rXok+NwTTFiPhCfJqCWAqXF9PF27c3DfmMaC6QSe6wJ3pJQF/KK7sAdZSp8ZP0rwT1ZpKWttrvw72Qj3N+V5rhTw9Vf/V7UHTiHNzxfFgDOwp3qUXz6CikGzRBWHioVyLC1OjouXBwuiArHp8+23jki3620srjZulftnoA+Gv7DEJtiiXbDLf24vwAlsXtLhRGlDv/KHWlBLjCX+Yy+Cx0k8c1CIiZao53qnzoEYSPToPFSmutc8cxuyjmn2U5a3AkHkO51+FWOJxxdQOOIP6VsDA29y7dF5Tw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3add150d-ab4d-9147-005e-3f3160ec9667@suse.com> Date: Mon, 21 Nov 2022 09:33:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Paul Durrant References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8273:EE_ X-MS-Office365-Filtering-Correlation-Id: a5660669-5dec-451f-00c5-08dacb9b1f09 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WzG12CwahfLN7vnOkDp9C+j9QcctkhqK4yL3xtQNsr7BwrFFFBc8PtoJrkYXf9iMV0iXUge+FBKvMPQNHZPeEwaPF3imyFpngqPrx/Bsr9LTbi9krHX6oexRchVHQNga7YWgM1Z+RWvnGnGoFzV+uyoJsczcrA9FSEOOYtTjE90mlE8DgSGZzlUgVg5M9603HBkkoKnGw6/vmd1AaRnZMz3ZRcFbvUxU6nljC7MDeVLH9PszzvO/BTc4+s3a80xWuboDbil1teHDuYxaP5RiUB9/XF4Y9Xm5HlQx72V6I9sTFFk0RplKix3takvPMd2Ol3H8MMYVgQsQYJ1ra8kL2MmQUwk7dQLyFVNxGZyu+QzGyKSBUz3xgT2pHPt8Hsd423JGiLFJ2Q7qyg+TaaU0seVURFEX7vlV9Q72tmSLQJxLFxTKyilXhh79j4+gnbrz9FyyrOAmSO9zPlttyV3C+XSX/SY5pfWWi10tMCqrpKk3VxKZtQ+g/lCKj2S6+WuY0JgPhHpFgTNkaIkSe5vur+W5AoVAsBTE+OS5bDFMBk9AIpliFBO9xgYUbysvZ9gbxXiDPn/3P+8KbKTeIn3Qc979f8jlIWAVRdXdjvWfgmMr6UpdPip2BKnWnUFv3ySlGA6ylCODDobbjV2tBLpeKW60fB4P5GF89RJtsW76hJ4V2+wVS2pnQprQMNirux1JBrSLJZrE4fB+IQ3PHE+Q/nbbn9SeOx8oH+YTG41/agY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(346002)(366004)(396003)(39860400002)(451199015)(86362001)(31696002)(36756003)(41300700001)(2616005)(66946007)(66476007)(4326008)(8676002)(186003)(8936002)(5660300002)(6486002)(478600001)(6512007)(26005)(316002)(53546011)(54906003)(6506007)(38100700002)(6916009)(66556008)(83380400001)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzMrc2FhZUNXaG1lY2ZBRytuTWlvbjRRd1RlWmxqNlB6YTJjRTgzNk1IWG8v?= =?utf-8?B?V1oveUVuMW9pdWZBNXI3T2V1amNHRU4yTlNRUGlMTjlVZm0wT0RDbzFUUzVt?= =?utf-8?B?NmxLbHhvRVo0MGkwVHY3d2NRekJnTWc3RjNpalhLUHZFdEtzcTBqY3o5dFNn?= =?utf-8?B?ZFd5bmRCanJnbHJxMzNLay9nWWljNjRGbDVDYVZQdnQ2MldQV2JLY2lVV0ZM?= =?utf-8?B?RGNvNVVIYlVCNlY3dldjVUtHQ2hVa2x1STNtUEVRSytzbHY5bTE3WjhkVXRH?= =?utf-8?B?eGdnYW9SSVdVclpxcE1WMnBxWGlLZTZaTy8zUDdzUUxpeEVUY2laWlVuV25Q?= =?utf-8?B?UTJJL3hvMUFWQndoOVV2UHNSd1p5bGhyb21ySTJrRnVOVWdENHFJaGxnL3Mz?= =?utf-8?B?NXBVUFh5WHMxVE0rRG8xVjFVTklWUWphVWhZWElNYUNaQ1AzUDZMZzZ0aytN?= =?utf-8?B?Sks2NmFQSC9CUWJjWnlIMGNYdE04V1JsVEFFMFlyVmtCdWgrRXR6d3AvTkNl?= =?utf-8?B?S04yQ2Q0S0t4OFdPNXBETC9qR3FYa3VLcnhnZzRla2tNK2o1ZWZGSkNVQzQy?= =?utf-8?B?MlJoNEtLdVlLQ1Z0cDBOV09LT1BONlZsZlllNjFQU3JrUWJvT1FxSzNVSmUz?= =?utf-8?B?WjAxamh4d2tSUGZKQkQ1Nit2WFpTdkMyR3BrQ0x1VjFzaHN0YXVzK0tBcVZC?= =?utf-8?B?cUttVXNmdkgvYm8yOHBLUzRGQUhhWmt6UTRublcvblFEdi9EMkpJYnIvZEhR?= =?utf-8?B?anR1aER3bkg5cFFZZjBCN080Tkd4WTlTSENFVUxlTCs4c0Z3VmNGclZoZ0tK?= =?utf-8?B?STBoV0g2bFpRbi8zaEFHdUM0Q3RYQ1luRW54Q3FYQmwyNTAxTVZCOHh3NmRQ?= =?utf-8?B?ZHZaeEp4NGZaUUcwNS9QdGhYeXI4Nkc3dEpPUDh6SzV1cVVUdUQ1aXB5ekNk?= =?utf-8?B?eE5XMTlSckU2WFRuVmVnMXFRV0srUC9NYVhVSHJmQjN2S0pOaHRWYVdkUWxr?= =?utf-8?B?OWlzS2tTNlBXY1JLc002b0dSTFV5c051TXBPUm1acnBxTklTKzhPTGVDRHND?= =?utf-8?B?N0xsZzJ2TktNUVdIc1J0UytrcTdiUjNzSTlyVEh2UkZXQlhTWDNsTUFNenhi?= =?utf-8?B?UFZBekF3TGc4WkwzQ3llMngzcHk2b3d3M0gvSjZlL085UjBSamp2ZGRXWHBr?= =?utf-8?B?UmNKU0xWNS8xTFhnUlFtMm44aFdzQWUvSWVKdS91M1NaUzNjS1FuVy9OMk10?= =?utf-8?B?ZVJyM1FQTm5PY0g5OHRtUFgxbUhLbHB5RTFYc2plSWFiRVBaNzhhUFFOU2pE?= =?utf-8?B?VTZkcDh3SXM5eksyWmhua2U5VXl5a1VTOXdVVE5WR29pNEpSeDEwQ2JRL2JY?= =?utf-8?B?M0NiMENFUTJRdll4aHNxSjZjLzIvZ3pxbjk1UnpMalZqSS92SUNGNzlZNU5q?= =?utf-8?B?MDNOTW0yVTlJUHNpMElYdEJYb3liNjRreVRQVDFCcThuS0dwQkd4QTRaQnRw?= =?utf-8?B?TURkNGQ3TVFHK1Jmb01rRlpoZTRtTEEzVGZqQXhuY2I0bUN3cDdaZVlpYmVQ?= =?utf-8?B?SjJKWjZaUVc1WnRMZDkyVVVORC9uOFhFOVRpQklITUcxQnJvVk1hbEh4OStp?= =?utf-8?B?ZFJGQXdsZzVXYW1ZdnNLbE96ZTg4bmZPRGpkTnNvTnJlSTU2bHNtV00xTnN4?= =?utf-8?B?cDdYQmtpditIQzlaRXU2cGtyWVRMeWd2SlUwdTNoY1EvUUVSa3BpazFtYTBG?= =?utf-8?B?cDdoeFdQRkRZVStEMEJMWUhCa0E2T3E4WUhFKzB0ZmpRTXB3dGs3QjF5V0sx?= =?utf-8?B?K3hMVHNzMjlRVVkvZ1ZkRzB1NUtWNnQrZFFZOFhtemZWQmtXK1dob0d0TGJy?= =?utf-8?B?OWkxRTNMTk1GWkFJcUluNml0aDFKdnJWQWE4TE4zeUh1MXd6UHA4RHJpd01N?= =?utf-8?B?MHcxdDFmSWVkQ2hQQVFVaDBNWmZJL0s1THdYVXExc2FRbUtjOEtpL2FDZnJV?= =?utf-8?B?eHBmN3N4QVRmQ3J1RzdFYkNwMy8rMEVlM0duMms0TnF2V0JxbXBKWEtCYjk3?= =?utf-8?B?SjFXelRvUk1qd1NUa0k4d2xnMDN6cStveGVscWl5bFdTb2pVZjJzVkQwZGor?= =?utf-8?Q?hZxKUwn+IOI/MaPspu2xTDrQk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5660669-5dec-451f-00c5-08dacb9b1f09 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 08:33:52.8962 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 59jKmPE8h9rpq/2a/EjoG9ecgPU5UcIoVveoHI6qz2YVDR5OzuGpnTGetg1Q/rNOp85CntAHHQCWUiac8ZwtKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8273 On 18.11.2022 15:26, Roger Pau Monné wrote: > On Fri, Nov 18, 2022 at 11:31:28AM +0100, Jan Beulich wrote: >> Linux'es relatively new use of HVMOP_set_evtchn_upcall_vector has >> exposed a problem with the marking of the respective vector as >> pending: For quite some time Linux has been checking whether any stale >> ISR or IRR bits would still be set while preparing the LAPIC for use. >> This check is now triggering on the upcall vector, as the registration, >> at least for APs, happens before the LAPIC is actually enabled. >> >> In software-disabled state an LAPIC would not accept any interrupt >> requests and hence no IRR bit would newly become set while in this >> state. As a result it is also wrong for us to mark the upcall vector as >> having a pending request when the vLAPIC is in this state. >> >> To compensate for the "enabled" check added to the assertion logic, add >> logic to (conditionally) mark the upcall vector as having a request >> pending at the time the LAPIC is being software-enabled by the guest. >> >> Fixes: 7b5b8ca7dffd ("x86/upcall: inject a spurious event after setting upcall vector") >> Signed-off-by: Jan Beulich >> --- >> Don't one or both of the Viridian uses of vlapic_set_irq() need similar >> guarding? >> >> Is it actually necessary for hvmop_set_evtchn_upcall_vector() and >> hvm_set_callback_via() to call hvm_assert_evtchn_irq() when >> evtchn_upcall_pending is false? >> >> --- a/xen/arch/x86/hvm/irq.c >> +++ b/xen/arch/x86/hvm/irq.c >> @@ -321,9 +321,10 @@ void hvm_assert_evtchn_irq(struct vcpu * >> >> if ( v->arch.hvm.evtchn_upcall_vector != 0 ) >> { >> - uint8_t vector = v->arch.hvm.evtchn_upcall_vector; >> + struct vlapic *vlapic = vcpu_vlapic(v); >> >> - vlapic_set_irq(vcpu_vlapic(v), vector, 0); >> + if ( vlapic_enabled(vlapic) ) >> + vlapic_set_irq(vlapic, v->arch.hvm.evtchn_upcall_vector, 0); > > Shouldn't the vlapic_enabled() check itself be in vlapic_set_irq()? We > certainly don't want any vectors set until the vlapic is enabled, be > it event channel upcalls or any other sources. In principle yes, and I did consider doing so, but for several callers (potentially used frequently) this would be redundant with other checking they do already (first and foremost callers using vlapic_lowest_prio()). However, looking again I think vioapic_deliver() and vmsi_deliver() violate this as well in their dest_Fixed handling. (In both cases I'm actually inclined to also remove the odd *_inj_irq() helper functions.) > Maybe best to add an ASSERT in vlapic_set_irq() to be sure the lapic is > enabled, as other callers already check this before trying to inject? Perhaps, yes (once we've fixed paths where the check is presently missing). > Also, and not strictly related to your change, isn't this possibly > racy, as by the time you evaluate the return of vlapic_enabled() it is > already stale, as there's no lock to protect it from changing? Wouldn't this simply match a signal arriving to a physical LAPIC just the moment before it is enabled? Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 21 08:34:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 08:34:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446440.702024 (Exim 4.92) (envelope-from ) id 1ox2G4-0003rC-GT; Mon, 21 Nov 2022 08:34:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446440.702024; Mon, 21 Nov 2022 08:34:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox2G4-0003r1-DA; Mon, 21 Nov 2022 08:34:28 +0000 Received: by outflank-mailman (input) for mailman id 446440; Mon, 21 Nov 2022 08:34:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox2G3-0003qc-PJ for xen-devel@lists.xen.org; Mon, 21 Nov 2022 08:34:27 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e889e55-6977-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 09:34:26 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0158A21D61; Mon, 21 Nov 2022 08:34:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CAA9E1376E; Mon, 21 Nov 2022 08:34:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ur7qLxE4e2O0TgAAMHmgww (envelope-from ); Mon, 21 Nov 2022 08:34:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e889e55-6977-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669019666; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wAYfXQcdNToH3FWmAOzlk7EzYDNtXqlvFgsSgsh+wOU=; b=rceGxtU8LHhCfWjY4R6lHBmG8RVOi5PVGAV2FbcihDgo2YFJl491yP6cJbNc8rYm+APihF njCskZ/a4A90eRiSyTE51ITCfSmQGIq9QSW3nSxviwBokkoa7HYVPT4Ph/o2WcGQhQaNqk UB9Ang+q1xL5JsMVtso9V5+PyjxcAak= Message-ID: Date: Mon, 21 Nov 2022 09:34:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: Yu Zhao , Sander Eikelenboom Cc: linux-kernel , Xen-devel References: <42579618-f8e2-9fd2-0b6c-f2c87f7c57a6@eikelenboom.it> <99178e0a-ff6a-9bfa-4ade-b4bf6fdc306f@suse.com> From: Juergen Gross Subject: Re: Xen-unstable Linux-6.1.0-rc5 BUG: unable to handle page fault for address: ffff8880083374d0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Kfk3CqL3c2ximaN4GegaSaNe" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Kfk3CqL3c2ximaN4GegaSaNe Content-Type: multipart/mixed; boundary="------------6q0oqkju0wGjGElA5N1Uc8tl"; protected-headers="v1" From: Juergen Gross To: Yu Zhao , Sander Eikelenboom Cc: linux-kernel , Xen-devel Message-ID: Subject: Re: Xen-unstable Linux-6.1.0-rc5 BUG: unable to handle page fault for address: ffff8880083374d0 References: <42579618-f8e2-9fd2-0b6c-f2c87f7c57a6@eikelenboom.it> <99178e0a-ff6a-9bfa-4ade-b4bf6fdc306f@suse.com> In-Reply-To: --------------6q0oqkju0wGjGElA5N1Uc8tl Content-Type: multipart/mixed; boundary="------------6liXf91R80rbZ4shFsSeAVdW" --------------6liXf91R80rbZ4shFsSeAVdW Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjEuMTEuMjIgMDk6MTgsIFl1IFpoYW8gd3JvdGU6DQo+IE9uIE1vbiwgTm92IDIxLCAy MDIyIGF0IDEyOjEwIEFNIEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4gd3JvdGU6 DQo+Pg0KPj4gT24gMTkuMTEuMjIgMDk6MjgsIFNhbmRlciBFaWtlbGVuYm9vbSB3cm90ZToN Cj4+PiBIaSBZdSAvIEp1ZXJnZW4sDQo+IA0KPiBIaSBTYW5kZXIgLyBKdWVyZ2VuLA0KPiAN Cj4gVGhhbmtzIGZvciB0aGUgcmVwb3J0IGFuZCB0aGUgYW5hbHlzaXMuDQo+IA0KPj4+IFRo aXMgbmlnaHQgSSBnb3QgYSBkb20wIGtlcm5lbCBjcmFzaCBvbiBteSBuZXcgUnl6ZW4gYm94 IHJ1bm5pbmcgWGVuLXVuc3RhYmxlDQo+Pj4gYW5kIGEgTGludXgtNi4xLjAtcmM1IGtlcm5l bC4NCj4+PiBJIGRpZCBlbmFibGUgdGhlIG5ldyBhbmQgc2hpbnkgTUdMUlUsIGNvdWxkIHRo aXMgYmUgcmVsYXRlZCA/DQo+Pg0KPj4gSXQgbWlnaHQgYmUgcmVsYXRlZCwgYnV0IEkgdGhp bmsgaXQgY291bGQgaGFwcGVuIGluZGVwZW5kZW50bHkgZnJvbSBpdC4NCj4gDQo+IFllcywg SSB0aGluayBpdCdzIHJlbGF0ZWQuDQo+IA0KPj4+IE5vdiAxOSAwNjozMDoxMSBzZXJ2ZWVy c3RlcnRqZSBrZXJuZWw6IFs2ODk1OS42NDczNzFdIEJVRzogdW5hYmxlIHRvIGhhbmRsZSBw YWdlDQo+Pj4gZmF1bHQgZm9yIGFkZHJlc3M6IGZmZmY4ODgwMDgzMzc0ZDANCj4+PiBOb3Yg MTkgMDY6MzA6MTEgc2VydmVlcnN0ZXJ0amUga2VybmVsOiBbNjg5NTkuNjYzNTU1XSAjUEY6 IHN1cGVydmlzb3Igd3JpdGUNCj4+PiBhY2Nlc3MgaW4ga2VybmVsIG1vZGUNCj4+PiBOb3Yg MTkgMDY6MzA6MTEgc2VydmVlcnN0ZXJ0amUga2VybmVsOiBbNjg5NTkuNjc3NTQyXSAjUEY6 IGVycm9yX2NvZGUoMHgwMDAzKSAtDQo+Pj4gcGVybWlzc2lvbnMgdmlvbGF0aW9uDQo+Pj4g Tm92IDE5IDA2OjMwOjExIHNlcnZlZXJzdGVydGplIGtlcm5lbDogWzY4OTU5LjY5MTE4MV0g UEdEIDMwMjYwNjcgUDREIDMwMjYwNjcNCj4+PiBQVUQgMzAyNzA2NyBQTUQgN2ZlZTUwNjcg UFRFIDgwMTAwMDAwMDgzMzcwNjUNCj4+PiBOb3YgMTkgMDY6MzA6MTEgc2VydmVlcnN0ZXJ0 amUga2VybmVsOiBbNjg5NTkuNzA1MDg0XSBPb3BzOiAwMDAzIFsjMV0gUFJFRU1QVA0KPj4+ IFNNUCBOT1BUSQ0KPj4+IE5vdiAxOSAwNjozMDoxMSBzZXJ2ZWVyc3RlcnRqZSBrZXJuZWw6 IFs2ODk1OS43MTg3MTBdIENQVTogNyBQSUQ6IDE1OCBDb21tOg0KPj4+IGtzd2FwZDAgTm90 IHRhaW50ZWQgNi4xLjAtcmM1LTIwMjIxMTE4LWRvZmxyLW1hYzgwMjExZGVidWcrICMxDQo+ Pj4gTm92IDE5IDA2OjMwOjExIHNlcnZlZXJzdGVydGplIGtlcm5lbDogWzY4OTU5LjczMjQ1 N10gSGFyZHdhcmUgbmFtZTogVG8gQmUNCj4+PiBGaWxsZWQgQnkgTy5FLk0uIFRvIEJlIEZp bGxlZCBCeSBPLkUuTS4vQjQ1MCBQcm80IFIyLjAsIEJJT1MgUDUuNjAgMTAvMjAvMjAyMg0K Pj4+IE5vdiAxOSAwNjozMDoxMSBzZXJ2ZWVyc3RlcnRqZSBrZXJuZWw6IFs2ODk1OS43NDYz OTFdIFJJUDoNCj4+PiBlMDMwOnBtZHBfdGVzdF9hbmRfY2xlYXJfeW91bmcrMHgyNS8weDQw DQo+Pg0KPj4gVGhlIGtlcm5lbCB0aXJlZCB0byByZXNldCB0aGUgImFjY2Vzc2VkIiBiaXQg aW4gdGhlIHBtZCBlbnRyeS4NCj4gDQo+IENvcnJlY3QuDQo+IA0KPj4gSXQgZG9lcyBzbyBv bmx5IHNpbmNlIGNvbW1pdCBlZWQ5YTMyOGFhMWFlLiBCZWZvcmUgdGhhdA0KPj4gcG1kcF90 ZXN0X2FuZF9jbGVhcl95b3VuZygpIGNvdWxkIGJlIGNhbGxlZCBvbmx5IGZvciBodWdlIHBh Z2VzLCB3aGljaCBhcmUNCj4+IGRpc2FibGVkIGluIFhlbiBQViBndWVzdHMuDQo+IA0KPiBD b3JyZWN0LiBBZnRlciB0aGF0IGNvbW1pdCwgd2UgYWxzbyBjYW4gY2xlYXIgdGhlIGFjY2Vz c2VkIGJpdCBpbg0KPiBub24tbGVhZiBQTUQgZW50cmllcyAocG9pbnRpbmcgdG8gUFRFIHRh YmxlcykuDQo+IA0KPj4gcG1kcF90ZXN0X2FuZF9jbGVhcl95b3VuZygpIGRvZXMgYSB0ZXN0 X2FuZF9jbGVhcl9iaXQoKSBvZiB0aGUgcG1kIGVudHJ5LCB3aGljaA0KPj4gaXMgZmFpbGlu ZyBzaW5jZSB0aGUgaHlwZXJ2aXNvciBpcyBlbXVsYXRpbmcgcHRlIGVudHJ5IG1vZGlmaWNh dGlvbnMgb25seSAocG1kDQo+PiBhbmQgcHVkIGVudHJpZXMgY2FuIGJlIHNldCB2aWEgaHlw ZXJjYWxscyBvbmx5KS4NCj4+DQo+PiBDb3VsZCB5b3UgcGxlYXNlIHRlc3QgdGhlIGF0dGFj aGVkIHBhdGNoIHdoZXRoZXIgaXQgZml4ZXMgdGhlIGlzc3VlIGZvciB5b3U/DQo+IA0KPiBU aGVyZSBpcyBhIHJ1bnRpbWUga2lsbCBzd2l0Y2ggZm9yIEFSQ0hfSEFTX05PTkxFQUZfUE1E X1lPVU5HLCBzaW5jZSBJDQo+IHdhc24ndCBhYmxlIHRvIHZlcmlmeSB0aGlzIGNhcGFiaWxp dHkgb24gYWxsIHg4NiB2YXJpZXRpZXMuIFRoZSBmb2xsb3dpbmcNCj4gc2hvdWxkIGRvIGl0 Og0KPiANCj4gICAgIyBjYXQgL3N5cy9rZXJuZWwvbW0vbHJ1X2dlbi9lbmFibGVkDQo+ICAg IDB4MDAwNw0KPiAgICAjIGVjaG8gMyA+L3N5cy9rZXJuZWwvbW0vbHJ1X2dlbi9lbmFibGVk DQo+IA0KPiBEZXRhaWxzIGFyZSBpbiBEb2N1bWVudGF0aW9uL2FkbWluLWd1aWRlL21tL211 bHRpZ2VuX2xydS5yc3QuDQo+IA0KPiBBbHRlcm5hdGl2ZWx5LCB3ZSBjb3VsZCBtYWtlIEFS Q0hfSEFTX05PTkxFQUZfUE1EX1lPVU5HIGEgcnVudGltZQ0KPiBjaGVjayBzaW1pbGFyIHRv IGFyY2hfaGFzX2h3X3B0ZV95b3VuZygpIG9uIGFybTY0Lg0KDQpJIGxpa2UgdGhpcyBpZGVh Lg0KDQpUaGUgcGF0Y2ggc2hvdWxkIGJlIHJhdGhlciB0cml2aWFsLiBMZXQgbWUgaGF2ZSBh IHRyeSAuLi4NCg0KDQpKdWVyZ2VuDQo= --------------6liXf91R80rbZ4shFsSeAVdW Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------6liXf91R80rbZ4shFsSeAVdW-- --------------6q0oqkju0wGjGElA5N1Uc8tl-- --------------Kfk3CqL3c2ximaN4GegaSaNe Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmN7OBEFAwAAAAAACgkQsN6d1ii/Ey9t ugf/ZZV3nHL08qIK81y4NnuFeGp4Rwx8ZzbQKaQASeppe8yrwGmTeN4FB675mAXwxdNlzojJ2mav 3+BjJiOzom+cTzOqt1Yh9nTFmXQQDJGQOsGo7r+B83Xb4VF+HkN8C1Cx7zT4nwqBInp5LnEnLXkN PTs1DmbDA4XWTKBLK5YKiB9aN1K7+NIniJ0dpAbS534jFKvyOU3yzuJbMuD5QfokBtvsI+INX7+s IlMAkbtAE411O++Pg9l30QZpTrxo8426VyW17EkDROqCibjMugOxreXF+4e6g5EDw5GKD4+v7T/u KpFqvV3cyCJUJ2XM4tMu3fclaXXtTkQy6x3p06ESUA== =Oniq -----END PGP SIGNATURE----- --------------Kfk3CqL3c2ximaN4GegaSaNe-- From xen-devel-bounces@lists.xenproject.org Mon Nov 21 08:56:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 08:56:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446452.702035 (Exim 4.92) (envelope-from ) id 1ox2bQ-0006qi-9Q; Mon, 21 Nov 2022 08:56:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446452.702035; Mon, 21 Nov 2022 08:56:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox2bQ-0006qb-6S; Mon, 21 Nov 2022 08:56:32 +0000 Received: by outflank-mailman (input) for mailman id 446452; Mon, 21 Nov 2022 08:56:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox2bP-0006qV-4v for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 08:56:31 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2062e.outbound.protection.outlook.com [2a01:111:f400:fe1b::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6359e3ae-697a-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 09:56:29 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8773.eurprd04.prod.outlook.com (2603:10a6:10:2e0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Mon, 21 Nov 2022 08:56:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 08:56:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6359e3ae-697a-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dAYtz5GmFPeJX8NfmmqNjVbI1bSAZiQqPpvwnx4E2C6VXtMALcjce2M0lhg1U3kqS9hqufXe/4jLXOFl/zOZyBhRNvbiuQSJc+chArgGUdgIc7pOGJ9VVa1X3aOnyEK7rD20RePyfTj9icJVnLVuQRuUccf/FJQYywWZgIQq6OTiKg6wsuyALHCEUxe4NJmFYeHjtt73ekD7d086CdQMMnCtYjWFUbftaxP6gQ0n5pk7o/83PTIxvuVEj/rwPQUAxzkxMV79r4lUDTrNKKTRRE+qSoI8S0byaXMvtuG/uRfUSTSjBE2XB6VRxzqA8KeTCnDtHep4/MXY+EFUOzgExw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6SUCM6cVplr9ffzTzczI0ukj1ZqakVMnRlVhKFc90rY=; b=iqi4IyuRrW/PhOu+asOZD6NYv2jH6RF/3ohrrX9u7ifEXqYWDg2me1exyDDgsJT+WvGHicplP8+bRXE23njIHfzSeTN2MeaqBDDNvoyaGItatPKCmc83kTGkB5zakXiPm2oAhxVlCpffeyK2A0XjGL8nxZwb2Owx4ZPwAECjU3udiS4phBwt+wrXnWP0DSW+EL7rGVzGEvf7eIsGDdsMLDVlYi+bHFHbNur/wAbMpfZMZlYgpy5d2Rrno0gAPhPzsGVVJng4Wusf3j+NwBOkPAyYwjvuybybWEmkuaC+7jfY14kwv4dJAQR928KxG9rj4XQweyXKzCthocvY9MZudA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6SUCM6cVplr9ffzTzczI0ukj1ZqakVMnRlVhKFc90rY=; b=S5x02++1BxXa7PF0oDOKs0HpR4Y53MNEMUafwLZfTjJY5Q6aN3a9lWDPDBCwv9rhZ9sBIjnAqjf+VviMbltFBitPwV3pgUJ6HnQcOnYt+HrFAqRh7AG+GkNcofZKc+NapFb+G/k/QVIhLV6GHhz501ANUtv5w8ZwVNgWF6kGJL68UtPFlJ7IP4x6bu4zPO7acq91SDdL7/oK/IgwZby088o/1TmjtQarUYtSvchJbwQ1GxhcnT6XSBfUC6Ntmi1d2yjkJ/g1+vtlQfv9/nGLJdTqAzyO6AHwzUP6TxNk7hVHowbZL6w/cIEst/JRXyP2Qo8QHaeOthin7ype/SV5Tw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <878e635f-b116-3580-945f-f8acb711a5bc@suse.com> Date: Mon, 21 Nov 2022 09:56:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , Paul Durrant , "xen-devel@lists.xenproject.org" References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> <5a2df843-1acd-ad78-baff-e47befd0703c@citrix.com> From: Jan Beulich In-Reply-To: <5a2df843-1acd-ad78-baff-e47befd0703c@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FRYP281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8773:EE_ X-MS-Office365-Filtering-Correlation-Id: 73141bf2-b115-49c4-49d0-08dacb9e4611 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /M+BAIVc7cd2GjN2ZRCHI44mqgOUISRsdeXUT1DBhoHzIOSgrFoesqGqu28epKIKSHsaTDJKriiGa44mkMydCio0+aZDf2C/vsGYTiW0YSHDN1Gjmy+6OwnNM1R2MR4zoNpzecgh18LPiEPj2ytUIlYtkRwTDgmuxh+8//2+r0haRHGurQ86E80XDqi3k4oeys4rIvZMqP3T0yJzPUa4YSVmKe9SpZIusGHMm18KkxBlS8ATHYqnJOtajHCHqybr14kuxqCSmpu13wjEC8LXuE31Cd51RRr5V82v35p17RHjAnqhAq/o6RYE0+FASxPBcu/8yFfbnfQ/TJU92dtMb3SnimwS1lkfnFGVryKTPT0xG3S9656CiULvKLgxbgmFrWfoOHyS7k7NH+2QX4lk8cRyWz5/M0dOwoV1LaXPSqp3GfOfY0+fFHQjK4hPZIaWNkROkOnXvnCBX4AlMpqIVxKE2iNpd4Klar9tooOImJmCl85R1Y4pnSijGAh3qi2+DY95FVCzHrcc1e8V0C3F8kXRIFsGmMxT4CDf/Ic4w2/V4MTgw2ZTWcq7Modlv40mu0qAw8MjALwEWK6S814OGUEbhsClkmxBHd7UegefRh/xU2A4RvhkANoTAlU0mxwmVf+WUVFDGa8Yiy7ae7UvJY1/YuuKE+/WqawFCTHx8B2AYaIo9kK1fZnt5Ev9c7i4b9KIgS7FAxyqzjsWOl/Vw706rP/rzMlM06qY2K0oy9g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39860400002)(396003)(346002)(366004)(451199015)(83380400001)(36756003)(8936002)(186003)(41300700001)(38100700002)(2616005)(5660300002)(2906002)(31696002)(86362001)(53546011)(6916009)(31686004)(6506007)(54906003)(6486002)(316002)(478600001)(6512007)(26005)(4326008)(66556008)(8676002)(66476007)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3E0NXo4WnBMTUQrczJuQk8xRzZDL0VTV0Zsb2s5VnU0TUNXYk13N2RndkE1?= =?utf-8?B?Y1JlMUJndDhaWmYrU1pNN3lRZElnKzAxMkVNMzAyUFduNzU3Q2xHdXQwMjM4?= =?utf-8?B?SEdVb0p1YmFiNjZ2VkRua2tRWjlNcTBVTXdLdEk1ODhZaDJJRE9VRlNvR2pY?= =?utf-8?B?OTkwTllzRW5XY3hXT01FZmNRaHJ6Qlp4RXlaWVo0YTJpNWduY2JkdFNoZmMr?= =?utf-8?B?RDBqZlk3Vmtaa3VsSldDN3pXVWlsMWVvU3hvTEZoNE10a3BwczZxWDdERkJE?= =?utf-8?B?QVQzSUo3Q1lNZWQ0dndIRjgwQk1VOTZrZnhBczUwL01JYy9aVkRJSjV6bWhz?= =?utf-8?B?TWl2YnRFa2QrK0dZWThvQnRlT2huT29Hblk5a2dYWHFad0dNY2Q3UmdDVlNN?= =?utf-8?B?YjZxYUxKWHI3VWoraXQ5TllVcGRFMmFwNU9sNFB0eGluR1JreUd1WWJpQUZl?= =?utf-8?B?MmZWZnY2bi9OVndWbXJxZ2JOUlNubFAzTkRVZDVDZ29pN2EzMmplRVZ1QWg5?= =?utf-8?B?Vm03eXhmc2IzT0FEK1VZOEFSUm9FYWg4UW1US2tJRnBYTE0xSlkwckNEQmRr?= =?utf-8?B?N1B0U0pNY2dYYmVnak4xZ0NkNDN4dThFcHZ1d0kwVGpadENYQ2pxSzUrcTlv?= =?utf-8?B?TGROdlh0VWhNeU1lNTB1Q2QxNVRPaDJ1RnhOUzd1SVdmc3VNdkJRYU1rT3Nh?= =?utf-8?B?aExzTm4zTDRmQ3Y5dUpsdXdHZnlEL29aMy9CSS85bE5pK1c1bm01dkE0ZDA4?= =?utf-8?B?dXQzdEdQeHRCcUNMYjhGQ2JpdFZOYmdrdk8ra1pkcmdtYXJTYmFQaVJqNHdO?= =?utf-8?B?UXlCbkhhdEhyZytsOFliSEo3L2NVSXJSWWJLcUlSZlJ1U1lJTHArMEhyN3FL?= =?utf-8?B?aUVmRmVGQzBTNStvZzlnS3IwVkRqaTFJUVVSSmdZdExKV1J1UU4ybTlBeU1L?= =?utf-8?B?TUM3b1RnYWpBOUdTMDkzNVVBR1dIU1kwanB0OGdkM0duNnJqRFNZNXZEOVMr?= =?utf-8?B?UmJ1ZjRodzVadUFnMUlPQm1tQVc2L0ozMDRaVzAzTDl6VW9aYTV6Snh1cDhZ?= =?utf-8?B?bnRvdGI4M0ZJN2hiWVpCN3YzQ3VYWXlCS3oydXM0Sitnc2R0THQ2REZEam0y?= =?utf-8?B?MWhZUHBjYkFxcm9zYktZRkk2alY0L2tmTmQvSkI5S3ZXbldIaHpIcFluRVli?= =?utf-8?B?dTBPbkQ2MXUxdWxnS2dSNXRyNzh4dWwzZDFHRjZzTjl1SVRKS21sSXFzZFE5?= =?utf-8?B?SFFvaFl4NGUwV3F5Yi9BZ2FjcVpyZ2dPMFNBTy9QTW9NUnBuejFDanA4cjlO?= =?utf-8?B?KzVoMzJFYm9qZEx0cjZVdjFTZWw1ajhyNGgwN2k3UE44UGl0Tlk2azBIUFZl?= =?utf-8?B?UVVQRGFaYWJVTHp0WDU1b2pMTkdTRDRISEhkRU9hVW4rbFJ0eFRvdHozR0Vq?= =?utf-8?B?ekN0S2FBMHJUSmpCWDlIczhHcy83REg2czV2VWcyVUY4bS8rQnRTcXcyVUYv?= =?utf-8?B?Q1pzV05WYUQ3TGlKUXNYaHdVbjkzZ0NFQTQ3WVJYeW5vTWhtY2Y2eDFENkFO?= =?utf-8?B?RitqMWRVM3oyRUJ6VnJEWm02KzVlVzZ0VU5XTHBWV1hqbXFMUG1WdjJFMUlM?= =?utf-8?B?VjVsdXdZZ0owYmMrMExUNldkSmJqOUFmMU9RekkrQWtvamNDSWcrbmtja1FR?= =?utf-8?B?MTY4RUdEWk9pL3Vpdm9VMFNtV3g1YWxQR0MxLzd0WTdJUjlXTnFucTl3V0ht?= =?utf-8?B?VnFhdlVqQ0NsQmx1VFF4NXQ5TXlCRitMS0NrZ3FlbzZIMjJ5bVIvUFVjZ3Ir?= =?utf-8?B?NnUrWmtJalBXdlJMYlZMUjkxczVENXhNRmpTYkRtOEpqeDJpUStWMDFEd1Rm?= =?utf-8?B?ZFhVR1pybnFLSHVKNVJGbUVjaDk0SDZJL1pSR1JsKzRUWC96Rkd2MklINTMv?= =?utf-8?B?OVE3TjFZQUFsVTdaZFBRRXdLckJDNlhVVkwvNkZRaEEvWkxCOGRET1hWL0FP?= =?utf-8?B?WkhJdGRNczRUcU5MTnoyTXBkUy9kT05LZmJWcnVXRXVWSXRSK2hoTDlCTVlp?= =?utf-8?B?VjJYR3QvWjYvNXVBTC90MEhwU0VOSzRINmRWdkM3ZjFnKzRkUnVVYW45a1p6?= =?utf-8?Q?aYlK9yl6T7ni4ScUkdje55NhR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73141bf2-b115-49c4-49d0-08dacb9e4611 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 08:56:26.8249 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6m4MkU6n7EV9s/5c6gTSxYs14umem1Ej5ulLIIc1QMV0QU0TtETvgKfpWtzs8ZD9sku244jPn66mQU7rLQJcfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8773 On 18.11.2022 15:27, Andrew Cooper wrote: > On 18/11/2022 12:54, Jan Beulich wrote: >> On 18.11.2022 13:33, Andrew Cooper wrote: >>> On 18/11/2022 10:31, Jan Beulich wrote: >>>> Linux'es relatively new use of HVMOP_set_evtchn_upcall_vector has >>>> exposed a problem with the marking of the respective vector as >>>> pending: For quite some time Linux has been checking whether any stale >>>> ISR or IRR bits would still be set while preparing the LAPIC for use. >>>> This check is now triggering on the upcall vector, as the registration, >>>> at least for APs, happens before the LAPIC is actually enabled. >>>> >>>> In software-disabled state an LAPIC would not accept any interrupt >>>> requests and hence no IRR bit would newly become set while in this >>>> state. As a result it is also wrong for us to mark the upcall vector as >>>> having a pending request when the vLAPIC is in this state. >>> I agree with this. >>> >>>> To compensate for the "enabled" check added to the assertion logic, add >>>> logic to (conditionally) mark the upcall vector as having a request >>>> pending at the time the LAPIC is being software-enabled by the guest. >>> But this, I don't think is appropriate. >>> >>> The point of raising on enable is allegedly to work around setup race >>> conditions.  I'm unconvinced by this reasoning, but it is what it is, >>> and the stated behaviour is to raise there and then. >>> >>> If a guest enables evtchn while the LAPIC is disabled, then the >>> interrupt is lost.  Like every other interrupt in an x86 system. >> Edge triggered ones you mean, I suppose, but yes. > > For IO-APIC systems, you mostly lose line interrupts too, don't you? > > The line will remain pending at the IO-APIC, but nothing in the system > will unwedge until someone polls the IO-APIC. > > Either way... > >> >>> I don't think there is any credible way a guest kernel author can expect >>> the weird evtchn edgecase to wait for an arbitrary point in the future, >>> and it's a corner case that I think is worth not keeping. >> Well - did you look at 7b5b8ca7dffd ("x86/upcall: inject a spurious event >> after setting upcall vector"), referenced by the Fixes: tag? The issue is >> that with evtchn_upcall_pending once set, there would never again be a >> notification. > > Ok, so we do need to do something. > >> So if what you say is to be the model we follow, then that >> earlier change was perhaps wrong as well. Instead it should then have >> been a guest change (as also implicit from your reply) to clear >> evtchn_upcall_pending after vCPU info registration (there) or LAPIC >> enabling (here), perhaps by way of "manually" invoking the handling of >> that pending event, or by issuing a self-IPI with that vector. >> Especially the LAPIC enabling case would then be yet another Xen-specific >> on a guest code path which better wouldn't have to be aware of Xen. > > Without trying to prescribe how to fix this specific issue, wherever > possible we should be trying to limit the Xen-isms from non-Xen areas.  > There's a whole lot of poorly described and surprising behaviours which > have not stood the test of time. > > In this case, it seems that we have yet another x86 PV-ism which hasn't > translated well x86 HVM.  Specifically, we're trying to overlay an > entirely shared-memory (and delayed return-to-guest) interrupt > controller onto one which is properly constructed to handle events in > realtime. > > > I even got as far as writing that maybe leaving it as-is was the best > option (principle of least surprise for Xen developers), but our > "friend" apic acceleration strikes again. > > Xen doesn't always get a VMExit when the guest clears SW_DISABLE, > because microcode may have accelerated it. But as per "APIC-Write Emulation" in the SDM we'd still get an APIC-write VM exit. If we didn't, how would our internal accounting of APIC enabled state (VLAPIC_SW_DISABLED) work? And the neighboring (to where I'm adding the new code) pt_may_unmask_irq() call then also wouldn't occur. I'm actually pretty sure we do too much in this case - in particular none of the vlapic_set_reg() should be necessary. But we certainly can't get away with doing nothing, and hence we depend on that VM exit to actually occur. Plus simply making the vlapic_set_reg() conditional also likely wouldn't do any good, so if anything we may want to split vlapic_reg_write() and invoke only the "2nd half" from vlapic_apicv_write(). Jan > A consequence of this observation is that Xen cannot have > non-LAPIC-archtiectural behaviour in the vlapic emulation.  So I think > we need to find a solution to this problem that doesn't hook APIC_SPIV. > > ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Nov 21 10:33:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 10:33:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446479.702074 (Exim 4.92) (envelope-from ) id 1ox47K-0001Es-05; Mon, 21 Nov 2022 10:33:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446479.702074; Mon, 21 Nov 2022 10:33:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox47J-0001El-SU; Mon, 21 Nov 2022 10:33:33 +0000 Received: by outflank-mailman (input) for mailman id 446479; Mon, 21 Nov 2022 10:33:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox47I-0000fJ-BZ for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 10:33:32 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f1144f7e-6987-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 11:33:30 +0100 (CET) Received: from mail-mw2nam12lp2041.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 05:33:28 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BL1PR03MB6102.namprd03.prod.outlook.com (2603:10b6:208:31c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 10:33:27 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 10:33:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1144f7e-6987-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669026810; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=OhG1pbo0HKf03bdp7i14jI3MJOhmG5fyzzDFeRToEuM=; b=hE8NIDMac0HPpquAYtkSWW6pO/Q3GcLpMK8k/P0ytvUFmxLR1ic0NzR5 6a9btmlSVCfIrekB6ilYLIAdOoq4GWpbA3q1/bKjDLPYLL5jV9hBJdXvd 7pbrlTfbVyfOA7ZhdPmLQh9OtL4TOVZmQWXi8xdYinq8ZFq0Y+dtgWike I=; X-IronPort-RemoteIP: 104.47.66.41 X-IronPort-MID: 85257545 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:yb8t2KsqbvNlQZnNRYyVSp0py+fnVEZeMUV32f8akzHdYApBsoF/q tZmKWzXbPzbYDb8ftknaozkoxwGupeEn9IwSwFp+CExF3hA+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaEziFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwLxJQVkG5wNON76unaft2i9sgMtnQFdZK0p1g5Wmx4fcOZ7nmGv+PwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0ovjv6xabI5efTTLSlRtlyfq W/cuXzwHzkRNcCFyCrD+XWp7gPKtXOmAt9NSeHlnhJsqHe460kqGBQTbGCmgN+QsGSGX/9SJ mVBr0LCqoB3riRHVOLVWxy+vW7BvRMGXddUO/M15RvLyafO5QudQG8eQVZpeNEg8cM7WzEu/ luIhM/yQyxitqWPTnCQ/avSqim9UQAXInUFfjQsVhYe7p/op4RbpgnTR9xnHYargdDvXzL92 TaHqG45nbp7pcQMzaSgu1fcnyiruIPKXyYy/AzcWm/j5QR8DKa5aIi4wVza6+tcNoGfT0nHs HVss82f6u8JJYuAmCyEXKMGG7TBz/ydGDTYgFNpT98t+lyF93e9cMZQ6TdlKUFBNscCZC+vY UnPtAcX75hWVFO6PfFfYI+rDckui6/6GrzNVujdRshffp9rMgSA+UlGf0ee1m3puEshi6cyP dGca8nEJXIXD65PzzesQeoZl7gxyUgWwWLVWIC+xh+/0JKAa3OPD7QIKl2DaqY+9qzsnenO2 9NWNs/PzgoFVuT7O3PT6dRLcQlMKmUnD5frrcARbvSEPgdtBGAmDbnW3K8lfItm2a9Sk48k4 02AZ6OR83Kn7VWvFOlAQioLhG/HNXqnkU8GAA== IronPort-HdrOrdr: A9a23:W3xG5a74aS/2UGjmfwPXwaiCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HjBEDmewKnyXcV2/hrAV7GZmXbUQSTXeVfBOfZowEIXheOj9K1tp 0QDJSWdueAamSS5PySiGfYLz9j+qj+zEnBv5aj854Hd3AOV0gP1XYbNu7NeXcGOTWuSKBJYq a0145inX6NaH4XZsO0Cj0sWPXCncTCkNbLcAMLHBku7SiJlHeN5KThGxaV8x8CW3cXqI1Su1 Ttokjc3OGOovu7whjT2yv66IlXosLozp9uFdGBkc8cLxTrk0KNaJ56U7OPkTgpqKWE6Uoskv PLvxA8Vv4DoE/5TyWQm1/AygPg2DEh5zvLzkKZu2LqpYjcSCghA8RMqIpFel+BgnBQ9O1U4e Zu5Sa0ppBXBRTPkGDU4MXJbQhjkg6RrWA5meAeonRDWc81aaNXr6YY4ERJea1wVR7S2cQCKq 1DHcvc7PFZfRezaG3YhHBmxJiWUnE6Dn69Mz0/k/3Q9wITsGFyzkMeysBatGwH7ogBR55N4P mBGrh0lZlVJ/VmI55VNaMke4+aG2bNSRXDPCa5OlL8DpwKPHrLttre/Kg13ue3Y5YFpaFC16 gpaGko9VLaRnieSvFnhPZwg1LwqSSGLHjQI/hlltlEUuaWfsuvDcWBIGpe4fdI7c9vRvEzYM zDSK6+M8WTU1cGJrw5rjEWI6MiT0X2cPdlzurTCGj+1f7jG8nNitHxVsr1Cf7ELQsEM1mPcU frGgKDafl90g== X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="85257545" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AvScgZsGqDa0NR2KIR7n5fVNr0diVh/savKaYpSfFFxvqyuJM6azyU+/FRCEzzJO8a+hm8DmeGQusqvj++TYP3vwpreShwlPGrYiJpsh2HN2EQNrNSdrNbW/oQKttzeusjbD7slYu+dRlU4bZoDuxZ/V09uRdE27d35zjgeWl9hwY8mCqRgylctDeCSbm/AgViwmq1M091Vx4blPlG3dQB5JvC0YELHPdLqDp3ekEftmEtJwGcbyse42d5dVRTGxtIfkKl+BSEeXbPKJTyCSgAAr01cgTwOKKKZ96CzUsVgP3vZpMjjQT0TiXDarx9phC6WOEFEH12vkuUZGquXMSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vg+rjiccX1faa/xjxY+0Qw0fO6LNKDvwiUc3ugbC6P0=; b=Py3N2rqEMs/y1gkTEcMh/PjCOddExM1RzWa67Z7mN80rLzUhIFE5qExWUwMD+yXd7IZ8I/OI53QFkQw6SL7Lr3gP8fwz2ooHKf9lhLSy3gg3r2DDeRJfZLJAU1gnywePhVHGg+91ru65G4RGSFAvPeBEivCtztzQNg2+HZaBvqNGbMBWNvLjeFDeFqI85SUkm8QR7xQy4zNSYcAkBG6DMeSPx7Va0NEVFi9l8tH+6fIaf/qlK502RIIRe3Dj9aWJ9PyyevadtNt3dDjxPoMphuzbopdQPlCqQOVIiJClWNJEvAPinqPDcNExFNYFEC7e4fWuHJPFYAHhpkeoCWgyFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vg+rjiccX1faa/xjxY+0Qw0fO6LNKDvwiUc3ugbC6P0=; b=bROBq+vzMaJTAxcK/2L/Upt6iBUzd4VaYgeEazMlekeqA9ESeQAflW+CyimXXv793g+E4NW/rwqqgSHpSx8Tv/BwkprMRmz0pprW+E7HDcdUcSAUFkSKfiNjW8KFgZPcqAoC6D0M4TFPFQPzF+KZADKhkfeS4iUMeI8fUcSeeQw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, jgross@suse.com, Roger Pau Monne , stable@vger.kernel.org, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org Subject: [PATCH 2/3] acpi/processor: sanitize _PDC buffer bits when running as Xen dom0 Date: Mon, 21 Nov 2022 11:21:11 +0100 Message-Id: <20221121102113.41893-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221121102113.41893-1-roger.pau@citrix.com> References: <20221121102113.41893-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0273.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::8) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB6102:EE_ X-MS-Office365-Filtering-Correlation-Id: dccdf515-9599-4924-fbb9-08dacbabd331 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lea1d1MD2u4Fp0UglumcYiXvBnRvEZ5AAHOuqAVmAQSC0xxngLaohYJcCpofPr1Ktxqx6Iz24PpBB1dH+wEPvPoqEiqSChtGDpGMVevhDsTVUufyoZUV5w/ELvvKC89yE1prq2Uk6tqBPr+HwuJ2+2EvIORL6sHOqzXnAF7Sd1qZewPHSyc8MGyPt4fL4rDhzDXmeqKO9Vie7xFLHIAdSvZgqm1uc4PJIa/9I9q0K6AvKpXqGYzBYeEHmyFOcYvN1OXL7KDHk8kPzSPeyPWWgpYoPGfCKQ1YA9GqYaupkkHaVJr2H/vApoMroBF3RRi7chNaFgTOOEjfhDLdaNCzorUL32Z/ygf1jfgJkN2xSxq/C/UeMAQXPHXI7dTZL5A0ZHBbmPL9X+0A/u0/ENcrc2H5mWE48QTNkpzrZyVGcw9a5ake6tYALhZE8ZwvwCff6NUJcMpNWnlRGxm5E/bfjH1w9kgjA53IaddG4mj6Yc0DmYo6J0jKdk/56x4QZ/O9y7hUmekiToAGnOcc/8VATzHl4/BGRw16l+7m7X+fyCVgi9lOhtMEpnDW0OU9gAcWBx0FmH6k8i+f66g/xOo5rEKDreaIrOaPh2+d1iyyGvve5IMI35xCk7+Z68L3AZQcAM4SqqPTPD2QtmGfIU/pMw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(136003)(366004)(451199015)(478600001)(6666004)(6506007)(6486002)(54906003)(38100700002)(66946007)(66476007)(26005)(316002)(8676002)(86362001)(6512007)(83380400001)(6916009)(66556008)(4326008)(82960400001)(7416002)(5660300002)(186003)(41300700001)(8936002)(2906002)(1076003)(36756003)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2ZsMzlveVFqQ1BIbnFpUmRPVzBvMGxvRGlpTlZWSGJjV1Q1N2R2b05Memdw?= =?utf-8?B?dWxtTTM5MVVZM0ZCVFh4TDRpMXBYUi84cXVsMVRnNGVieUVzMVBjQTYwYlpX?= =?utf-8?B?RDRKUkprS3QrakM5V1gvNG9BYi9UTE85cXQzOGxLZE50bUNqVUZnanRTNWhh?= =?utf-8?B?Rmxtc3M4aTdKcHYycFdNdG1EY01vYnEycktFZEJQYkdtNEdydnZQVXBZdzNU?= =?utf-8?B?RStCY2FQYWZoM29SaFNKZmlUSzlkMzlZbi9Td28wWDROdEF6RmQwQnBVKzgz?= =?utf-8?B?cnlhOE5NZWFIQjlvOFlkS04zaXhSRTRKVGI0TnA4RDVYK2lyOEtyejhLZ25x?= =?utf-8?B?ejVkZzFuSm1RN0U5TXNHZGJuZzVKVitRcUFLeXpRL2lZNXJ5b1kxWm9nbTli?= =?utf-8?B?TmZmR2dBcndVSkU4TGlVeHpvS1NNYzBqZjV4c2ZDQWZEbDZtK1AvNHhsK2dV?= =?utf-8?B?MmNVR1NCNmdjbGZhVTdXQmNjTkdLUVYxQ0pWZ2FwSUlHdlBOOVk2SjYwNDhQ?= =?utf-8?B?QVJYK0tVNzdjME5Eb1RZSkZVMFdScmFITjN6dFEraFJ4a0VZMC92K0d1RnV4?= =?utf-8?B?bVBmeFROZjAvdTZaSHlWTnNrbFRpcGNJNUw4ZTNZS21ZcG1CMW9BYXBGNFdw?= =?utf-8?B?REl2cWV6QWFxZXROQW51VFFaUkUrVE1QdVk2WDVkckpSSys3b3RCTEdFalF1?= =?utf-8?B?azlseHp4eEdGeU9MTmtaa3hLSFM5Nk5LNXduaGR4dzFCaXFQSlAzNytVMzE4?= =?utf-8?B?aWswaEZDMjJDYVl3eXBIVnFRQ0lWa0piVkJ5OG4wODQwd3g1eDRXYmQrRkpM?= =?utf-8?B?Mmg2RzYrem1QNlJHSGtuUXBTaThkYU5adERvNStjbng1SDJXTG5mSCtFVWxE?= =?utf-8?B?ZFFFMEtXSXM3SEY0OTNjL0tDWE9DdWhKQ21GOVVLSUs1akZwd3VTbVNHdGM2?= =?utf-8?B?dXpKZVVERGVIRU83R0hZd0I2Y2MxNTNmL2ZOc2lJZURDK0VSTVlQWGY0V2w3?= =?utf-8?B?MlU3ZlNOVHVSdk5WbUVMSUVUUzNxdEJXMkFldFI5QVZmZFZVY25VRzVjQWxu?= =?utf-8?B?cUlkYjh1R3gvYjRaM2dEcVVGeXhHYTBGUk5HaEZuNGtyZWJ5aWdiVjJWN2Z1?= =?utf-8?B?b0E0U05XRmcwdXZvaFNtempTTFRBcnFTUXAvQW81OGg5cVpiNjgrY29taWlW?= =?utf-8?B?YVNSL0huS3NqcXlST2h2SzJTMzFMeHhaWWtBV0ZHYUdPZmwwc2FMYk40ZHJw?= =?utf-8?B?clZ1NnZkRWllYUllbVdDVmFrcTQyUjJaTEpGKzZzclV5bUdtVDlRMEEwV056?= =?utf-8?B?SEc3OEorM3ZrZkRrRHY0Q0NJeDh2ZkFaRWtPYVVEMUNlbDkvNmprOThsbFl4?= =?utf-8?B?ZStwK2NHeWpzelBRNHlUaS9tdTlKdEdpVCtOVncvNjQ5Yk1vdmhJSVBUSzVp?= =?utf-8?B?Y1hlOGZNRk9Yd0pteFJYZlRuaFBKVDByMXJIR1hITmNvbnlSb0hOM2ZySFd1?= =?utf-8?B?elBSU3gxUS9TSityM0xXTkpJMTNrN3Fwa1pyclhqdjZIcFpXN2RzUXozWkF5?= =?utf-8?B?RExyM2FBaXFVVnB6RTJ6em5sYjl4Vzd5M2NRSTRVbnc5azZXbTNaM3cxUFpa?= =?utf-8?B?TTFHRVFJYXY1UGtpMmdJKyt0Z3ZJVGRpWWswN0gxWnQ1MW1uV3BSbFM2TmNC?= =?utf-8?B?Q3dGTC9qeTJzTWQ1aURoWmc1ejBLSDJBdy9OTGdBc0cxd1BvTUg2dU9oWUFR?= =?utf-8?B?UEFkUlhJZDVNY0QxdkllVXByVUVQWmpicThtUmNmeXF5WmRLUHJXb3Y4b3pi?= =?utf-8?B?ZFBmNUoyT3o5T29QbVZGdElJd1FDN0U5ejdHY21YcDhXL3pMeWNhYUFWVlgz?= =?utf-8?B?M012cDdLWWx3ZlQwYTdlYmF2OUZra0FJNk5FTjBxTUJJNEhjNGE3d0RHMUpL?= =?utf-8?B?b0p2L2dydmdnM092OWJHRWphdjBkYTNuMnVwUGRqcktkRVdJN2JKb0p2OXg4?= =?utf-8?B?ck1laG82QVdOdnB5Q1FkUU1DeWZGOU1FWXJqRXlLVUhteXh1cForRTRwZTJU?= =?utf-8?B?YktRNXU0QTlOSjZ4Vk95c1VaY2VJNS9XaXJuZjFZY3RkYlJTeExiTE9OS0tn?= =?utf-8?Q?C3HmYVmPnXyqkGobWoj01hTtV?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?WjZqeGJPWmJuWFVDTStIQkhCTXhiZFRRSEtaZ01aTWl2QjJwY2dadWZyRHVL?= =?utf-8?B?THJLS21adDlON0QxMlMzZTFlNDBaTk1HcFQzeVI1SXgyb1hXOHhCK0Vyd1ZX?= =?utf-8?B?c0swTWNwMWRBdGhRK3VGakZJRE9QQzdzc1Yzd2V2L2RLbHZSZXdvb05mVWlp?= =?utf-8?B?RU13S01XZmhwQlN5NXVzclJkNzVKL1I4dDFaTFkxajJrc3VoYzRqUVpjTm5p?= =?utf-8?B?VVFNa2NTbG9sU292bGVPanJ1MGpwU3k5NDMvdmtTM2U3cm9Nd1JtdE1UVmx0?= =?utf-8?B?cjl1QVNxemxOYTRSc3Z3ZURiSFFLVFZNd0JIMERjQXFMd1dZSUhITktqNXJm?= =?utf-8?B?UlFMSVMybm9PaWJETU5FekZRWUZDdmdwbEZCb2ZMcTNyRmVWUm5KVVhUdjZ4?= =?utf-8?B?U0lUd2tOT3BvRXBGVmgxMXNvZERHNFE3aUtlR1NkN2NuYVR4NGdPKzBBVFZX?= =?utf-8?B?eEFHYU9PeGFKTnJxRVpzNTZTV083M2pLL1VKekQ0bU9QWjQvdE9Xa3Y5Q3V0?= =?utf-8?B?VjU3U3BVSVkrWFBwU3ZIYmduWHVhdFRPd2ZvcC9lZHdzaWVLMmw1NHJRNDdI?= =?utf-8?B?UkJrY25Zb21xU0VHdWcrNllDNmUvcEptSmhuRnZwWWpidWVHeUhBRkxNRjlU?= =?utf-8?B?Mkp0YXF3aHFUaElBczZRYUJOSmh5YTRsY21NY2piSk8vR3lhMXNYV2QzL1NY?= =?utf-8?B?UTZYUTNUcm4zT2dwUG9RWFJyY0g1SmN3WW1Sak00dlpGVEFqZGk0b28vbGZz?= =?utf-8?B?aWV2cGhZRkUzTU1lWm0wOGE4N3dLRWh3aE8rWnBIQ21sNW9xNWJDVVh6THBU?= =?utf-8?B?ZWZkUU9TZTA5YWpja2M0dHg5RHgyVm93d1I5Q1ZqMVBTUHJsVGloVVkyTHBG?= =?utf-8?B?VkxUQUVPS2IxMk9nTUx4NGxIVmNKUGVxSVI0M2Y0K2xPZzljenFpSkErTnZR?= =?utf-8?B?UlcvN3p2eWR2Q0xtZG1iNW1RMkhmUXh2ZTdtekFQQXJiakJQdnlBYkxINHNL?= =?utf-8?B?dER6c0dBc2pHNHdWNXZURHkrWUpyM0tHbVZ1Sm1SR1JBNXlaMi9OajM1RzJ5?= =?utf-8?B?SVdqQUFhNndsOExtMW1sSXk5NGhvc0MwUmdQNlp6OHNsd3N6Tzd2RXZXZ0ZM?= =?utf-8?B?SmdXR0tEcFl4ZHBaN0xLUzVpRGlVRk42NGVyWjRyZmlHTWxrU2I0dWpkY0pw?= =?utf-8?B?MEV3T3Q0NldrSW1wTEFwdmw3Wis4Q3lWQlp5ejVpMDMwd29xVEZ6RlkyYzFi?= =?utf-8?B?VzBEcFp1dSt4bkZXVW5uWDMycWdqanJyN2N1bHVWbFI1QzMybGZaNGJHdE4w?= =?utf-8?B?eTZNYTVyL1ZHQzArbUV1OFJlalNPV1RHODBoZUZEaVV2UW9vejltekE2d2xY?= =?utf-8?B?YXJrc0Zxd1ZDRXpITlJ0aDlSamNPSUhuNlg2TXpuYmhwMS9jdi9KWXV2aDR3?= =?utf-8?B?TGRFVFVrNWxjd1ZYeDc3VVVsem1UMVh2Z1dwaGdXYkoweU1pWk8zUnVJejh1?= =?utf-8?B?Tk16NGZDSmJVd1A2L2xMVllaL0J0TTg0bndaR0x0N0J0NG1JMCsxZnlOZXdM?= =?utf-8?B?WUZOMmEvMm41d2FZeVoyd09KLzlTZi9wVjhNUUpnNXRlZnQxUFhXWi9ZLzUx?= =?utf-8?B?NGhRY0pNWXdSK2RTYVhBU2dicmtOWEE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: dccdf515-9599-4924-fbb9-08dacbabd331 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 10:33:27.1804 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j9QCyLUjfjXEGBx7UlRAyBtNMf5Q6/y0WQFVbwDgLK1TWirOJP5fSUmLL397XKna5j2ailLu9tQha84uY7bT+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6102 The Processor _PDC buffer bits notify ACPI of the OS capabilities, and so ACPI can adjust the return of other Processor methods taking the OS capabilities into account. When Linux is running as a Xen dom0, it's the hypervisor the entity in charge of processor power management, and hence Xen needs to make sure the capabilities reported in the _PDC buffer match the capabilities of the driver in Xen. Introduce a small helper to sanitize the buffer when running as Xen dom0. Signed-off-by: Roger Pau Monné Cc: stable@vger.kernel.org --- arch/x86/include/asm/xen/hypervisor.h | 2 ++ arch/x86/xen/enlighten.c | 17 +++++++++++++++++ drivers/acpi/processor_pdc.c | 8 ++++++++ 3 files changed, 27 insertions(+) diff --git a/arch/x86/include/asm/xen/hypervisor.h b/arch/x86/include/asm/xen/hypervisor.h index b9f512138043..b4ed90ef5e68 100644 --- a/arch/x86/include/asm/xen/hypervisor.h +++ b/arch/x86/include/asm/xen/hypervisor.h @@ -63,12 +63,14 @@ void __init mem_map_via_hcall(struct boot_params *boot_params_p); #ifdef CONFIG_XEN_DOM0 bool __init xen_processor_present(uint32_t acpi_id); +void xen_sanitize_pdc(uint32_t *buf); #else static inline bool xen_processor_present(uint32_t acpi_id) { BUG(); return false; } +static inline void xen_sanitize_pdc(uint32_t *buf) { BUG(); } #endif #endif /* _ASM_X86_XEN_HYPERVISOR_H */ diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index d4c44361a26c..394dd6675113 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -372,4 +372,21 @@ bool __init xen_processor_present(uint32_t acpi_id) return false; } + +void xen_sanitize_pdc(uint32_t *buf) +{ + struct xen_platform_op op = { + .cmd = XENPF_set_processor_pminfo, + .interface_version = XENPF_INTERFACE_VERSION, + .u.set_pminfo.id = -1, + .u.set_pminfo.type = XEN_PM_PDC, + }; + int ret; + + set_xen_guest_handle(op.u.set_pminfo.pdc, buf); + ret = HYPERVISOR_platform_op(&op); + if (ret) + pr_info("sanitize of _PDC buffer bits from Xen failed: %d\n", + ret); +} #endif diff --git a/drivers/acpi/processor_pdc.c b/drivers/acpi/processor_pdc.c index 18fb04523f93..58f4c208517a 100644 --- a/drivers/acpi/processor_pdc.c +++ b/drivers/acpi/processor_pdc.c @@ -137,6 +137,14 @@ acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in) buffer[2] &= ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH); } + if (xen_initial_domain()) + /* + * When Linux is running as Xen dom0 it's the hypervisor the + * entity in charge of the processor power management, and so + * Xen needs to check the OS capabilities reported in the _PDC + * buffer matches what the hypervisor driver supports. + */ + xen_sanitize_pdc((uint32_t *)pdc_in->pointer->buffer.pointer); status = acpi_evaluate_object(handle, "_PDC", pdc_in, NULL); if (ACPI_FAILURE(status)) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Nov 21 10:33:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 10:33:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446477.702052 (Exim 4.92) (envelope-from ) id 1ox479-0000fW-Av; Mon, 21 Nov 2022 10:33:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446477.702052; Mon, 21 Nov 2022 10:33:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox479-0000fP-8D; Mon, 21 Nov 2022 10:33:23 +0000 Received: by outflank-mailman (input) for mailman id 446477; Mon, 21 Nov 2022 10:33:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox478-0000fJ-FK for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 10:33:22 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e9de6941-6987-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 11:33:20 +0100 (CET) Received: from mail-mw2nam12lp2041.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 05:33:17 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BL1PR03MB6102.namprd03.prod.outlook.com (2603:10b6:208:31c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 10:33:15 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 10:33:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9de6941-6987-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669026800; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=VtKZmUNtkGjFcATWMzJ/LR+x+GuqGEdUcBVpPzKztNE=; b=cQsxcuT2tJNrUDXKZ3wV1QPH8qJ9q29E01iZX/lSE8sd86eU7B94LBSk WyEFi3hf71Yo2VRgTmLD2KRKZHVvsplPPKdhvRbnw5eBGdijHfGSZynwP 8LKbw9g8A0AndLGh1B4EXHydEwuuTx7Dd6/zXnlzIV7VdNEcu3cKgSO6t E=; X-IronPort-RemoteIP: 104.47.66.41 X-IronPort-MID: 85257534 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:35ylQ6oSiJoLI/wwuZ5kFxSFocJeBmIsZBIvgKrLsJaIsI4StFCzt garIBmHOPuJa2vwedFxPN+1pBxS65eByoJjQFY6rns3RCNE8JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzSBNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABRSVECsmL2d/PW+FKpO3856F/XoH7pK7xmMzRmBZRonabbqZvyQoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3juarbIO9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAurBdhPS+DjqpaGhnW2x1AjLi8zWGed4sKj1BfuSdhiF ko9r39GQa8asRbDosPGdxm5pmOU+x0RQdxdF8Uk5wyXjKnZ+QCUAi4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkA9L2AYYjQfZRAY+NSlq4Y25i8jVf5mGa+xy9jqQzf5x mnQqDBk3+lKy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg= IronPort-HdrOrdr: A9a23:LTSCHqF2p7Mdq+DNpLqFnJLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LK90c67MAvhHP9OkPAs1NKZMDUO11HYSL2KgbGD/9SCIVyCygci79 YGT0EWMrSZYzlHZK7BkXOF+r0bsby6Gc6T9ITjJyAHd3AQV0gs1XYMNi+rVmlNACVWD5swE5 SRouJBujqbYHwSKuirG3UfWODHhtvT0LbrewQPCRIL4BSHyWrA0s+zLzGomjMlFx9fy7Yr9m bI1yT/+6WYqvm+jjPMymPJ6JxSud35jv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDn1H8a1P 335zswNcV67H3cOkmzvBvWwgHllBIj8WXrx1O0iWbq5ZWRfkNNN+NxwaZiNjfJ4Uspu99xlI pNwmKirpJSSTfNhj706dTkXwxj0mC0vX0hu+gOiGE3a/poVJZh6agkuG9FGpYJGyz3rKghDe lVFcnZoM1bdFuLBkqpzVVH8ZiJZDAeDx2GSk8Ntoi+yD5Nhk10yEMe2Yg2gmoA3IhVcegJ28 30doBT0J1eRM4faqxwQM0bR9GsN2DLSRXQdEqPPFXcEr0dMX6lke+73FwM3pDlRHU09upypH yYO2ko9VLaOnieQ/Fm5ac7vSwkGw6GLHfQIsI33ekIhlSzfsuoDcS5ciFRryKRmYRiPiTlYY fNBHsvOY6EEYLPI/c64+SsYegmFVAuFOsoh/0cZ3Wi5ur2F6yCjJ2rTB+UHsunLQoZ X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="85257534" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gRvXG2DzKR9Szh8BWAphbhsHwRSTZfkQdNWCw2OmD5rhz9FKRL8a1J3ulHFVTeZvbArs7sS2pqu8LlaGfcEG8uTI7ujEDXeOiI2bGDr3UE41G4bAZthAehrihN3dpC8D8uWWh2zo6eP71NZiI7mbHDf1WlTAGHrjH8qcI6O2uYAVIU/zEyge9hnwdipN8AM5fhr91AdMcwW1ljnNA5zfam+W/06q2M8DRBqflRobxLj3IN607TWYsUrquigo1nrYA65dfjRzNfk5qCAbdMYmgvBDmXtLq6Iul1urlOCQBf4XS+rHE1fl/xPJWsy6Z3Ju2fGNeNI4vLEX/onuO1oc5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k4SvY7y6ErqHXHaRFZW96PoM5qCfueW0X+04g2uti3o=; b=LYc7Ohas8NawiwUoNbBGFDUIpVQAL+KLfee2uOx/ivoEWmc5KMu6ieQkMYFcoUHFtNmZ6qMR8xXcHPdG4oDUaELsi7M6GSCuFFeI3Yq6/OotDNLHu5EFKbMoYEQ1JIrVJDejta/58CuoyDkqxWX+ddyNcW3s3k0Z8rkWVERsadtY5K1hWXxD97xf78svhi1ymfFjbPCKJGQNCffqz4d/1rI1VhiAdo3E1ToWQgFIdHope9IDMYmFVlIzsby/s9zfA5I3zG26ruvTRS5Vy/3/vk+kGGbowtabUrRdldHQadkQYN/HFyAOtsPacvJ41jRWG4aj4lYijxrNK817xXDMwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k4SvY7y6ErqHXHaRFZW96PoM5qCfueW0X+04g2uti3o=; b=a2tLUExJhPAS99YvnpoO+C2tz+CcSexUt6Vleh0s+GsVIyrxNjIFiM4irgJ5a1ffWrEDBVCy8ODMXm6w0hBV40sEzLDyGD3+xaIkUM4o+0FeTWlHHu/DhfmEZP/ID1ljcdS5IR6WiOl49gg9E6amm1caRs9+siv6UNwQufm2HAQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, jgross@suse.com, Roger Pau Monne Subject: [PATCH 0/3] xen: ACPI processor related fixes Date: Mon, 21 Nov 2022 11:21:09 +0100 Message-Id: <20221121102113.41893-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0516.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::23) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB6102:EE_ X-MS-Office365-Filtering-Correlation-Id: d92c5184-858c-47a7-26b8-08dacbabcbda X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hLfHdKlixdjBEYFzKteicPAx0QtxGn5/DaZt8LCPnyuLU1uBt7W2jDuB2RFx4Pbr7NCrgb9qXUZCXOvkt1/F/nCNUwRGL4h1dTu/ec6gr/TROiP8XxiPgN0/ihqjOJkpUQ3nlpCilbqv7P5njbPYVNS1b+uK36NOuje5SzDrUhFG/y/doaoX1rH/lzwTdMcXdfv+zzrsY79J3GZcZdsAUWsiS2ELvmp8o4RQGeeZINtQpdDuK82QiJ+pR8H/yF6pst2cZ+jEANoBep6AJIEmu3x+QESeKk+fuhyVRlqj9DSH0iF18o0zLLx+juNsJSCBBvrM2d3JAzJH4iU8QpSn3tVWGtg9KdovpemdQkQrIWyGYqPS6rUYU5Y2nVXdTlWMYutuux5byijOQMN78R8KIC7uyG8q3r+kFcwLGZGciok3qNaPUR4hTXF+ZTjpkTUm2f5OY8HFEuOafASTiiGYm5CGrxyBQcF2bfZfEf5h6idXFFaTG7VYxBq73mVctPKt4QZY8Hs7uc/raBg2tM1nZWqC8JM+Gls1MyDIixnvBy4ZvcKPzvXzyeB5HoCMveppTYq2whHHd1HfX1VKzqS1JXdUsAwKyRrGR2gya/kUzmcVlcirT6/fn9ziUvHVLnszEf94iB60eAx+nHxicSLIKw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(136003)(366004)(451199015)(478600001)(6666004)(107886003)(6506007)(6486002)(38100700002)(66946007)(66476007)(26005)(316002)(8676002)(86362001)(6512007)(83380400001)(6916009)(66556008)(4326008)(82960400001)(5660300002)(186003)(41300700001)(8936002)(2906002)(1076003)(36756003)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlkwREYrMTQ0dGpJZzMvM2NyWWxjZUFJTklvekNkT1o5WTBTYVRFeXhpemhw?= =?utf-8?B?ZHVRR1QyMmFmVmtMekxENDFmVEpnTkNIbDV0T0V6SS9IWXBLb2xjYU0wK1RN?= =?utf-8?B?NlBUaHhhR3l6dUJQRlBXS1ZYODR5dU01aHZSOVM5cGZLVis0RVJBeFIwZHBv?= =?utf-8?B?eTFBSXJpeVFrd2NrRWNOUVhNSFhxM2lwb05MWGZlWkJ1dFBEMXRxVUhEaFlT?= =?utf-8?B?Tkd6aW5VSTVEcGZKYWZqOVk1b1FDWTJaSFVrdjF0R0JUazNUUERWN1V2RXJF?= =?utf-8?B?ZWZDK1ZTUlpJRHlqNEJaa09ORjJWOXVwdm5remNYWDAwK1dERmFXcHEybjNz?= =?utf-8?B?ZmdmazliRERFUXl1MFBWQXlMbzQ4cGtVblUyUTlJdHFETFNaR2ZIcXJYRVI1?= =?utf-8?B?cmZLK3JQR3BiQTIyb1BJRnZ5a1E5YmVtakJ6VFNQZTc5WDlFZjY2MkZ1OGFz?= =?utf-8?B?cFBqZkFWUHdHRVEwc1VOcWYrVWdkbzIvNk4vU095MFo4cmMwNHB2anhzNXZV?= =?utf-8?B?b3hNanE4SjNzbUxyNWJoZUZSSERZdWpJSTdrVG9KeldpcUVuNU1sSmZGamY5?= =?utf-8?B?NVRaMGJFeHduNUlqUFFyaFUxeURVZkpXSldXUHYzZ080OFR3eEEySU1VK3B2?= =?utf-8?B?eU05blJTM2ZpeTNuRmZZRzhoQ2U5UTlKQmNHZHE4b0VTN2FuK3dIbUZKSUtV?= =?utf-8?B?ZU9nRHlYRXdZVjBDUjdvZ3NIaDVicEROamx6UnJjSHZtU2RLYU1ESDBTemxR?= =?utf-8?B?OU0zUzFhd01EbXIrTlZoUDUxOGgwY0N4bWhmSjhvdG1wMDZLcHN1WlJmUEwz?= =?utf-8?B?MmhiVzdQZUt0dzcrU1RBYzlsSG1OUVZKR0l6Y1hFTTVPT3hRcy9uWHBLeHlT?= =?utf-8?B?aVRwR2xjWUMwWXZkNHZueWJ1OFlmaEJxdG04djYrWHU3ZDZBQ1pVMnNrT2Fo?= =?utf-8?B?NFBkZnM2dk4wUWkwZ2ZnaWo2WnhDL25UUlNnZWRrOWhhMHZXbGtqRi9FdlU3?= =?utf-8?B?MUttNlZmWUFJVlN0MHdSeDZpajFSOVUvMWgrVFA1R01DeU5WYWlNbzZGWFRz?= =?utf-8?B?NjJYQTJIZlRVekdOd0JhUnVpb1IxVzdUUEdyaFF2K2JpYkxIQk5NallwOThB?= =?utf-8?B?QisxSG1YUlBpRjFSVHZGUGQrWDdnNE1uS2hiN2N1bER6L0FxWDEwL3ZtM20y?= =?utf-8?B?cUpnbmdkdGF3dzh4QlBoZXJGNy9Bb3JWSzlDMURWdzVIZzdUUkwrS2lZdzJS?= =?utf-8?B?SFYvb25UallZVW5vNnNpTFBvd0NZbTR0YWdNTGRFT0Fhd3hiQndPdXM1Skx4?= =?utf-8?B?V2hHREdRMVBYQ0M2TE5mNEtCSU11ZllpU2E1TGR1bFVTMnd4aWo4UEcyb0Q3?= =?utf-8?B?WWl1enFTU01nbEJKMElSMHZJVGR3OGV3ZnFqekRqQkhYN1ZpWnA4TjMwUUo5?= =?utf-8?B?WkNzMG53T0pBVVYzMzIzcUMxd1dUYldweUdwWVV1MXJwRGFQckNDY3lORUk5?= =?utf-8?B?TlZxTEdLSGhrYWJaczJDbTFPbXJEaWY3eEtvQ3VCTC9xZmYycTNzcElWWXU3?= =?utf-8?B?RWNTYThlUk5Pd1F0RjJvUFhITTIvVUdrekdBTnVnK29SdjdhbWNHNXFja1dB?= =?utf-8?B?QTA0bUt6RDNqWTdFZjNaTlRybmlleUxQY0JQWlZYQldXYVF6dHNubXEvdGds?= =?utf-8?B?a1N6TytzM1lGekN1MDRwcjJha1BWeFFKWHVzNFJIT2FGODlKZXptbXd5bUl5?= =?utf-8?B?b092RnltTDZSNGN5cUVVQUIxVkRUOWJaeW43L3RlaFY2MTFBTndmVnYweWZ6?= =?utf-8?B?RFFsNnpMdnU2cUhEWDBUajdkU2l1Q2poSlRGbzY2RkxML2hGK0x2WmJvTWsz?= =?utf-8?B?VVoyTmg5VDhkN2ZMWVUrUXo5UklGYTljVmRZNTF6SVBnRzZJUjh4eHlmY0g5?= =?utf-8?B?eFE3M21wOWhOaUd3Smpma0hxSEF5MkhvWUhKZlJKRkZrNkNEZGQwRTVCZFQv?= =?utf-8?B?WHNGdi9jWFNVU3g4UUFGekNvZmJ3azU4TFlmc0djNDVXa0xkUkwydjBBSFQ1?= =?utf-8?B?K0pLdklnTkJDbDNNcFBHdEpBaGxVRm5hYjkzdGxuZzhKZ1ZrK3RlcmNCQ3FI?= =?utf-8?Q?bIY5C8ZEyzdTpxOKiVytwjAxS?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: JYM7vPhQvUgbOCfbgx6s0JvbU5l6UctQgsn3D92uJfIH6hDgVV5dN7PhjoPfE8HLcHWdHwqAVM+hAyZ0+B0+ymNvz/5ko71ARTa9sktfnQ5T7GTDUXR3X2SxiKCfKFI0e930A2EOy2/HAwNkaSzfUM604Cr0FFU/dssbyVSGFh7PlVzkQBxqy1lSqN3yrL3rFrJZ7tIMS7Bc53S0UVlPOYDL6+u8Is0b84+y4VjpKO7hIPgzCCPH0rxbjmpJfXfL0bgScnW8KFs1JqOB+lAJpnNjSwjSwDrLgQfkXmOrfslBOXYDSBD/ZfpiMsS6IlPzHpKigWUl2bcDEcEXTe7qJz6aqOrHXK3K8WxBTzv1FOmeu5pfMZil5pZvS3onZlIKEslXcIUjfQBE2NUHGatT6po0ZXnrRGHfDJOpDLbeA7UJXF/dik01XC4hT3UZWyWe2d7YIDsuHICCXGhsGP38a2nN+8iO2uBZUA7czZSTWDv2Tu3Hepbd7b3oinATJuK4nGXkJfBefXaQ+T7SY55kdO71DHjj8eVCs54icub1j0lADOt7c0+aJRm3+/gxNd2QuYtifeh6X3kffL05cqOwHXZywSwl2crR4A7r1PRGJWUEB5FCVOrzM6AKUarkqqSukMc+HAsXZx0yOLgLZZENhGuzLOwQJ9h7yNKKFS43PQIKnl8o7/Gm0wB06cxcJ66Ha/dSRzV/anOrbPFbdiWn6U4pIAvAY3SbpvqUX2bWqW80lTZ6YF6xGOqwLLuMNd5w/87jXbacE7sjHPF7bN+1pmMs1Vy1Uc156naENhxdKFRAQQGoiLBoeA3tlRMEAD5tTsx66inA1KidZ3NEwVMUzSR23GEv5UZa352PbfifSCU= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d92c5184-858c-47a7-26b8-08dacbabcbda X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 10:33:14.8763 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HMVPIZ4ljS26zDalgLMM0W67mX2AuwRO0T0bKS8OX7l6pzyaLj5P840j9ptmlkHebiibtESXBSmO44RAUxmj/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6102 Hello, This series aims to fix some shortcomings with the handling of ACPI Processors objects when running as a Xen dom0. First two patches fix the execution of the _PDC methods for all CPUs on the system and not just the ones available to dom0, while also making sure that the _PDC capabilities reported to ACPI match what the perfrmance and power drivers in Xen can handle. Final patch fixes the Xen ACPI Processor driver to also work when used in a PVH dom0, that has a custom build ACPI MADT table and mismatched Processor UIDs between the MADT and the Processor objects in the dynamic AML. I don't really like the current implementation of the Xen ACPI Processor driver, it IMO relies too much on data being fetched by generic kernel code. For one the generic fetcher functions can take CPUID data into account in order to sanitize what's found in ACPI, but capabilities reported to dom0 can be different from the native ones. Also the Xen ACPI Processor code relies on cloning the data from CPUs in order to fill for the pCPUs > vCPUs, but this is wrong when running on heterogeneous systems. Last patch introduces some helpers to Xen ACPI Processor that should allow fetching all the required data, for each ACPI Processor object on the dynamic tables. It might be helpful to explore disabling any Processor object handling done by generic drivers and just fetch all the data from the Xen Processor driver itself for every Processor object on the namespace. Likewise it might be better to just execute _PDC from that same Xen ACPI Processor driver instead of polluting the generic ACPI Processor driver. The series should be taken as a RFC partially, due to my own doubts about whether the current implementation is indeed the right one moving forward. Thanks, Roger. Roger Pau Monne (3): acpi/processor: fix evaluating _PDC method when running as Xen dom0 acpi/processor: sanitize _PDC buffer bits when running as Xen dom0 xen/acpi: upload power and performance related data from a PVH dom0 arch/x86/include/asm/xen/hypervisor.h | 12 ++ arch/x86/xen/enlighten.c | 44 +++++ drivers/acpi/processor_pdc.c | 19 +++ drivers/xen/xen-acpi-processor.c | 225 ++++++++++++++++++++++++-- 4 files changed, 284 insertions(+), 16 deletions(-) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Nov 21 10:33:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 10:33:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446478.702063 (Exim 4.92) (envelope-from ) id 1ox47D-0000vX-NI; Mon, 21 Nov 2022 10:33:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446478.702063; Mon, 21 Nov 2022 10:33:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox47D-0000vQ-KS; Mon, 21 Nov 2022 10:33:27 +0000 Received: by outflank-mailman (input) for mailman id 446478; Mon, 21 Nov 2022 10:33:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox47B-0000fJ-W0 for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 10:33:26 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed4de6b3-6987-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 11:33:24 +0100 (CET) Received: from mail-mw2nam12lp2049.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 05:33:22 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BL1PR03MB6102.namprd03.prod.outlook.com (2603:10b6:208:31c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 10:33:20 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 10:33:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed4de6b3-6987-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669026804; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=YHPGugGitXvHZlE1d9kV/h0t+sD3euQGc1fPgzWqA5o=; b=aJsuR9+Lw+jiGV+wWDHyrpYQOsd/QQOl/cJmV9QcgzSbDlM57W5Tm/It BW/hQJ+YuTj0/LF/ySfaZNV3HmzZU3IDZqnOxL2nT+bfe092rSuTQr98Z yDImM9Fi6lLbXb3yZVD0RjwwElpbaOwKBfs4HmPkRNivxHq3BfBcAStMz E=; X-IronPort-RemoteIP: 104.47.66.49 X-IronPort-MID: 85257541 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:46A+dq0vDFv1o4vKu/bD5fpxkn2cJEfYwER7XKvMYLTBsI5bp2RUy DEbUG2OOvbYa2H3fNp0bo3l80kOv8eGx9ZiG1dopC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVkPKgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfGU9q8 +5DChExPh2oh9Dx+q6ge+g1iZF2RCXrFNt3VnBI6xj8VKxjZK+ZBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxpvS6PnWSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iLx3LKQwH+iMG4UPK2H0fds3Qa5/GMoVDgXdnCmpty7uFHrDrqzL GRRoELCt5Ma8E2tU8m4XBCipnOAlgATVsAWEOAg7gyJjK3O7G6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+Woim1IjM9NnIZaGkPSg5ty9PkuoAoyBXUUsxkDrW2n/XyAzj7x z3Mpy87750Pgsob/6G6+03bmTWqp4iPQgNdzgDWWG2ixhl0aI6se8qj7l2zxfxYBI+dT1SH7 D4IlqC24OkQANeNnSqWTeMlGLCv+ubDMTvAjFopFJ4knxy9qyCLfo1K5jx6YkBzPa4seSfgS F3CpQRLopRUOROCd6Z5ao+1I8cn167tEZLiTP+8Rt5DZJJZdwKd+ixqI0mK0AjFmUMskKg5N r+baYCnCnNyIbpqyjm/W+oG0fkzzyQ6xHvaSZHTzhK73L7Yb3mQIZ8BMV2TfqUw57uFiBva/ swZNMaQzRhbFurkbUHqHZU7KFkLKT0+GsrwoskOLOqbeFI6SScmFuPbxq4nd8p9haNJm+zU/ 3a7HEhF1F74gn6BIgKPApx+VI7SsV9EhSpTFUQR0ZyAghDPva7HAH8jSqYK IronPort-HdrOrdr: A9a23:lLr1CqHA5d/qxkw5pLqFiJLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LK90c67MAnhHP9OkPIs1NKZMDUO11HYSL2KgbGD/9SkIVyGygc/79 YeT0EBMqyWMbESt6+TjmiF+pQbsaG6GciT9JvjJhxWPGRXgs9bnmRE4lHxKDwKeOAKP+tOKL Osou584xawc3Ueacq2QlEDQuj4vtXO0L72fBIcABYjyQ+WyRel8qTzHRS01goXF2on+8ZpzU H11yjCoomzufCyzRHRk0fV8pRtgdPkjvdTGcCWjcARCzP0ziKlfp5oVbGutC085Muv9FEput /RpApIBbU511rhOkWO5Tf90Qjp1zgjr1fk1F+jmHPm5ej0XigzBcZtjZ9QNkKx0TtpgPhMlI Zwm06JvZteCh3N2Az7+tjzThlv0m65u2Arn+I/h2FWFaEedLhSh4oC+149KuZIIAvKrKQcVM V+BsDV4/hbNXuccnDip2FqhOehW3widy32N3Qqi4iw6Xx7jXp5x0wXyIg0hXEb7q8wTJFC+q DtLrlovKsmdL5ZUYtNQMM6BeenAG3ERhzBdEiIJ078Ka0BM3XR77bq/bQO4v2wcpBg9up8pH 34aiIZiYcOQTOsNSXXt6c7sCwlAV/NEQgF8/supqSQ4dbHNf/W2S7qciFdryLvmYRaPiThYY fCBHtnOY6cEYLQI/c54+SHYeg1FZA/arxghj9pYSP4nuv7bqvXi8f8TNH/YJLQLBdMYBKNPp JEZkm/GPl9 X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="85257541" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hIpmqLgd1AzlqK8pqGDec0OLCrIb8xv/yosS8KXL/bN28ieay/LlbgbozxatE+yaEpSP/5jEHN9pLhtBVJUMMR6l4aFVRwFzy8RLH2dm6R7X50SDJ1AdymDDVEikFEql5Wz4UvTq12t2jjyiVgGllJFXnyoKmD3FzC/b4J02dRCwosWGXM9lDovQ55YPl3YAtMnOZv1oRA33Y0ZEhk8jSWyAL0rFMTWBFLm07aN77FpROiurpmNQDgahonxNPdRcMr2rOvMZ+29EG0N1DCTwKHOiUWxXmO5c8m7PFBmfO1P1hkChGxUwzEAXzMnNvl9bRik8/oq5ksYSHYHYe8CWsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V+3B4L6OirXeCSTJWk4PnCTnlFvaE8OXfvZ/IgYSk6A=; b=hyS4BGKh9pbxAsdhDiynwJfs//zih3895saqEs31lA8EjCdrifxFamaePSaUV1TQ+fOseJISzrQXxTA9mDKlYNG+nBEQn7ovwKa6Ov+PXQSFADOKpN6PQLegN8x0OMZ58BVD4uiekB9R3voNssMF+UoFhKZxKaxF0CdPWHuw1+5o+c51NZZNZvM52ts5lxu+nzXe3Mk0JgjLzTJ1kJuu2yfn32H6lW07hzt1OFAGdx8/3Z+954mGlP7sOu/5Rm+8s4ygcnCp1gv/7DUwEOWsXrl+PZCjNFKkwwj+VRE1mpBmogkLszhgwEHomKk15P5ioKFYQeJWJznorpXCXgVTGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V+3B4L6OirXeCSTJWk4PnCTnlFvaE8OXfvZ/IgYSk6A=; b=wqJSgE7utIsmTSsPzikIXUv6qWUXOLiRiXZxWZtmP41BM1KbEuml7ofsPfHvq6XbAVtkWZNut1r5RbeOI9Bk6Wd/fup4aPcMaCNWTAs1A4TJdrfi7bLFDiJVrQiI0WEaH7SZ9KgBAM6Olq9CHQlNZt9G1P+0aFAJ7x6LG6XGvZU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, jgross@suse.com, Roger Pau Monne , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Alex Chiang , Venkatesh Pallipadi , linux-acpi@vger.kernel.org Subject: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0 Date: Mon, 21 Nov 2022 11:21:10 +0100 Message-Id: <20221121102113.41893-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221121102113.41893-1-roger.pau@citrix.com> References: <20221121102113.41893-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0041.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::12) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB6102:EE_ X-MS-Office365-Filtering-Correlation-Id: fe416c5d-484e-4b08-2ed8-08dacbabcef7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rnbkGf486ctDaemLQOehJivg6yriyrtrll6TV8wRURi3pxnCLqz4yDd+uARn4d65Rkcm/so0lxHNrLybHIeaAvO0jJjwMm1ym5KgNxVOrdlTUZOwbV3LWQIZEiNOLf3pSlwJF0GLydgNx9IOH1BnCnbjtY2FVfWHOm6+3w1MFiL6ljwsSQcQLVsU06uRW8BLc9ixfKUz28MvWxxCyBFnQlIFi+y+5TQVc0mFuPwwarhhtQj38+l9JscUTZDcOLPv8sJ4/oayunvazhPhVkS0tlmazQs3gHWqk4opUg6UCc9Ap9DkDO1ofIa4TGqyOryf34Tke5XzvyPxdAJtgga93nt0clHpyULbX81Pkp2FHIawWNkAniwqO3+TSdLCk6u4eLKepm79kdJc6LITvuMMOCvwGwWT+zUXPj82pEU/Ae8eDv0UjZEzOK/GU8e+i+kMi/nqDdkutkqWfg5y5gAirrQVb+JRVcPagtrA2G9Kn59IS5l1W2qpRIWykW0T09wvzmqQ883PvBMMOIBscphoh/3m2k/tsiU95LMiLyLyA9pI59MtdRjosN0pKfS1Pppaeo0cd/8SxBafCJF5duJm8q44YqF/kOdRhbnFr9RYbFbRXfj3tnfe+Lh9zRSjCdDYpWtBTo74J9DooVYWIEn5Sg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(136003)(366004)(451199015)(478600001)(6666004)(6506007)(6486002)(54906003)(38100700002)(66946007)(66476007)(26005)(316002)(8676002)(86362001)(6512007)(83380400001)(6916009)(66556008)(4326008)(82960400001)(7416002)(5660300002)(186003)(41300700001)(8936002)(2906002)(1076003)(36756003)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anlBdnZnWkxyalJMbGtMbEFVSEJRR3lsWjRtRmxWdVY5TU5FRWNLdXJnemlx?= =?utf-8?B?c0wrQWZYRFU5U0R5S0VUR3BTOVJDWTNUTFVnd3BWYndrUFNWcUFOTnNLcjhp?= =?utf-8?B?eDFIQmM1UmFtVFpPVC9xa0JwZVdIaFdaYXVXZ0cxZWFVYjQ4QUd2YjY2NjMx?= =?utf-8?B?ZElPUUZaZjRnT1dKL0NKMzYzRE42T2E4ZUw3c2pTMXczUytyR1FVRGdDTFJR?= =?utf-8?B?Y0tub0FkcVplUUh3MmlqbGpRZHNSU01kVVE5aWtRTlQ3bEtlRXlSYmNDZytL?= =?utf-8?B?b0o2YWVPa2p1dUh1dFdzN0ZWTzZpNThuaFZRaTJUVldEc0JWeGhXRGl5LzFa?= =?utf-8?B?RmhQbCsxYXkvRm5oaVV6bzFlUWl0UTRyRmx5ZkFWbHhRNnZoT0hOUE5WN0pO?= =?utf-8?B?M2hKT3lwT0R0UUlnc0oydXUvbE1BeEJ2dXRpbi9GaEJRWCtwV2FMdFRhNHVK?= =?utf-8?B?dHd4YTVXL3d1K1l1Y3dwT1YrRUlEWmpuVitzcmhvYW9zWktBbnZRM1BwN2Iz?= =?utf-8?B?eHBQbU8ycTIwbzlnc3BqYTlaOFF5VGxLWGJicG9VT3hUdnRaR0x4dTFLNnE4?= =?utf-8?B?S0NWa29jeEZzREpvNURSc0NYL1JFSVBUN1Rjbi9SbFppR2h6Sm9hakZFMEw5?= =?utf-8?B?SUd6dVdwTmV2a29jbFBXa0Y1bHJ3ajkwR08vYTBsbUZWY0lHOGlLeloxMm1j?= =?utf-8?B?M2d1R2JCYW1DbmNueFlESzVOcHlFZUhNZkxGb0Iwb2swcWtwQkFhem1CcDh3?= =?utf-8?B?YkVqcHMwMUFmNVV2a0lzczNHZjArSmZZejJXRFNzeCtZNXRhb2dzbGx2aHY5?= =?utf-8?B?cFR4eVVaWFFNcSt0MThHOTNESEJOM0FhUVJkYTdyMmpTU21YS3RKM3VjTzJr?= =?utf-8?B?THdOcWlpZUxDNjFHS054V1RyREFibllCcHBFZGFNMUtLRHdMTkxqSTh4bUhI?= =?utf-8?B?MzdPUVhDd1ovdkwxMFNoMEJ5YTh4R1ZHRmEzUVRjdWpQUk9udWtpTFdyUCts?= =?utf-8?B?alFNeEJHdGVQVERrYUVpbEY3ellXd0RTa2ZydlhhblJlTHJEUkw5b0p0elI5?= =?utf-8?B?ZHorcDVzdE05UEU2VlVPcnIxSXI2ekNvd0R0UUFZbWtNa05naDJWMWRCNmFa?= =?utf-8?B?RUkrbXAwSGxXbklYamxvRTN2WjlBY3hkZkxXemRBcm45RkdmUDhOdDZDT2gr?= =?utf-8?B?bEh2MHNQWm9IUnVRN21yeFR2ZTFSdkFUUkJwUDRnWkFkRldncTkvaCtRUkp2?= =?utf-8?B?VWFqNGNGREtPSlBmdkt0OERZSVhLa2RxVzM2aEpmakdTdDQ0S2syRkhGamFu?= =?utf-8?B?Ym9FSXNoT2tZbFRER3c4dDUzaDIxN28wYm5BblQvcGlsMWUxQk1yTFJrUXBo?= =?utf-8?B?RzdWZyswS0lOeVVVQVJnczdhODBDRUl3Y3pZaFZVZ3J6L2w5aElvdUt0YTRu?= =?utf-8?B?TFNXZE1KdmI3cjJ3OGxvcVFMUmhrV0svbnhrMG9ScmtuS29QRjlWOThDQ2Yw?= =?utf-8?B?KzRJdWQ2M3JJb1dxZDN2anNDVldsOWhqdXpQRjloS3lIZTY0MCtMUGx0UHha?= =?utf-8?B?VmdWZitaaEs2RDliLzhUeFRISFQ2dEFqYWljYkgzTFFLblZrb2hhWlhtN2Vw?= =?utf-8?B?Smw0UHNYdFJzakd5NmhhL2s0cHNIWnlkNXVkS1BPcFpUSEJBbisyb2FuN2pv?= =?utf-8?B?MU9saG5DRkZPS3dCUksxU3ZHTHdaZm9Ib29FM01VK0RXY0M1NmFPUGNtRXRN?= =?utf-8?B?aTRlQm9HMVZndDJpdFB6cjNGaXlvMjhFNDBYajcvOEdhc0lUaWxWWFExYXhR?= =?utf-8?B?d0ZON1Nzb1dWWkVuRDF5aUMyT1p6OERROVF3RGRBM0wzYW5lb0szbkNuendh?= =?utf-8?B?bWRIamZ4Qy9INzVTMy9lTHRCS3hFK0trYnNRMk5UV3VCRjVrMFZ4dGFJZldB?= =?utf-8?B?bWhKMFkzRTZnT3VtTytEeUUwQmFHWklYS05VRW9VTTAxaldHZlBJdWc2SjVh?= =?utf-8?B?TElXSXVOUnRNL1dtN1lHUnhvclIvMWMybUZMd2ltZFI0QjRaNHlNQlRsL0pO?= =?utf-8?B?b0hkRWFzSlA3V1RlSHV2eGRXTDNOZHdJQk1NY0d3ZjlVbUhKZFVVYVo2WXVX?= =?utf-8?Q?OOoDgcQ3kVdj+b2f1SiaWy0Ej?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?OCt3U2hFRysvUnpVUDZqZjVxL0ZSZ25adlRzSkQvWlJJL1JoL2s0OEV2RWQ4?= =?utf-8?B?YWJmeG50RVVoclJ3MkNwdXdVaGp2M3Qrdk45QWZBL01sM0U3dHdZREJ0aExM?= =?utf-8?B?UWlqUFhtaEJ1NFVhRnRPUmdVTXdxMXUzK3NaTXc3emhCWW5BZlhKSFZBYXhv?= =?utf-8?B?bENyL3dXeHBYNXJDUWFoMzNTbGxGRzlJSmowczBqZzZCYzVDbVJHN2JLTStV?= =?utf-8?B?T2g0M0RUOXl2K0xlanUycXBsWThXckVPdGprWXFCVTd0ZWdMNUZxU01RMlEy?= =?utf-8?B?ZExrWXpHNWxOWlN6ZFRmRmJRSzBSa200ZTBFN2J3OGhub1BBMmEyNVZYVEJl?= =?utf-8?B?WHNYdlhuMTR5eUh0MjVoZVlmL25sbHgrVzJPQnJQK1JGZDV6UjAwNyttK05R?= =?utf-8?B?a0VkVUNIUXlST1BXcCsvNk1SZUhNWGhXTUZkZjdtN2J4ejdXUG1Xd1E0OU1N?= =?utf-8?B?WWd0MVhpZDJ5YlBndlZkT0dmNmhZVzI5d3Bpdkc5ZE00M0k3Wk5yVHJRZENj?= =?utf-8?B?M0xaVEI5ejA3NGxxVFhJaEtVREwvb2VGakFEU3JPcmdCVlFTVTdLSUNiZUYy?= =?utf-8?B?b1JsejJoT0h2NThMcEdyT2wzUlc5ZHVUOUowdkg1T0lPT3hlcit1b0xQTWRR?= =?utf-8?B?NDgrSUIvWG9aWlR4b2NjcHlRVE56T3hrQmZId0tBbWVTZDQ4bnFFMTVnbDZq?= =?utf-8?B?MFBOZUplSDRpa2szL3VzdGk1UDM3QXEzbEZabDM0SnVQN1F3WVFnVWFhOGRR?= =?utf-8?B?RFpCYTZVaStBUXBuK2VacFRxTlFvNUZRRDExbjNrMTRaeXRpd1QzcWtWcks4?= =?utf-8?B?VnlqVTdQbGF1SFpYVWdIOVlYeTlZc2orMGdKR29pQU54RDNiQndzWDZoWlYv?= =?utf-8?B?by9UOWpXbjlPbU1iREowVzcxWnp5WlpjSXcvWHhqYytBM0Z4dEJEaURXWlU1?= =?utf-8?B?OTd5dC94MG4xaUI0d2szWWZabmxlR1F2ZzQzdDdrclBSMWZuL2NJQ0N6b0ZB?= =?utf-8?B?eENva0VxVFg3WndydGlYK04xdDZpRVRZK25iWkpQMG9qbDNVQnNXOFlrSTBQ?= =?utf-8?B?TmxSS2F2bVVWZHJlQ01mTUtGdFAxUnR1SFhxaElqVDNZKzQ2bkRLcmVTRDNx?= =?utf-8?B?YXE1bDhsNGZyM3EzeVBqREtiUFZwaVQxZWNocTNIeDQ3d3lLU0cxeCs0NXlj?= =?utf-8?B?N3h3ZTJTTGR6R0VMUkloNGx2VXFVWWxQai90VkxLQkR1VWI1aEpsSTdLS3Mx?= =?utf-8?B?UTFWQVU5T0RPSGVPUG1VTVFDekhtMGMxQ3BJL2dlbEtQYlMxWUlTWitrQ1VX?= =?utf-8?B?dHRxWUhWRWdsV1JFcFZPVUtobFRRbUtsell0V3ZrNGhzMENaQm5JbkdYZzZO?= =?utf-8?B?a0gvTjZGRGpPVWd0K2xTRUgzaDRIMmdkcWNvS0hldlR0NENLekVRUmpaeWdl?= =?utf-8?B?VUpYYmpXN0VsT3BRc2VqaU8vN1p2eGs1TnNnbUVmbW5SRlVjeVlFYU9VR1Jq?= =?utf-8?B?K2ZobEpmamxINHprQjFtekZtaTlLM1lMWEhLYkYwZ1VkTk9iejBMaWxiUFdJ?= =?utf-8?B?WTBaYUVGWDUyYkZTaE9VblhXUi92UHJWN01pektYZDJyTlhRZ2JuZDAwSFhO?= =?utf-8?B?QVh4K3dVTHRsWmh3SklqUytWOG5GVVE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe416c5d-484e-4b08-2ed8-08dacbabcef7 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 10:33:20.7252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pZiemV/SDoG9Ln0GCEvmTh/MKvi7TdyjpgEzrjy7YSpSf4s5gYtxgOLxo2nztL/rkYGuKuVGXmY4oSrqIuXXNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6102 When running as a Xen dom0 the number of CPUs available to Linux can be different from the number of CPUs present on the system, but in order to properly fetch processor performance related data _PDC must be executed on all the physical CPUs online on the system. The current checks in processor_physically_present() result in some processor objects not getting their _PDC methods evaluated when Linux is running as Xen dom0. Fix this by introducing a custom function to use when running as Xen dom0 in order to check whether a processor object matches a CPU that's online. Fixes: 5d554a7bb064 ('ACPI: processor: add internal processor_physically_present()') Signed-off-by: Roger Pau Monné --- arch/x86/include/asm/xen/hypervisor.h | 10 ++++++++++ arch/x86/xen/enlighten.c | 27 +++++++++++++++++++++++++++ drivers/acpi/processor_pdc.c | 11 +++++++++++ 3 files changed, 48 insertions(+) diff --git a/arch/x86/include/asm/xen/hypervisor.h b/arch/x86/include/asm/xen/hypervisor.h index 16f548a661cf..b9f512138043 100644 --- a/arch/x86/include/asm/xen/hypervisor.h +++ b/arch/x86/include/asm/xen/hypervisor.h @@ -61,4 +61,14 @@ void __init xen_pvh_init(struct boot_params *boot_params); void __init mem_map_via_hcall(struct boot_params *boot_params_p); #endif +#ifdef CONFIG_XEN_DOM0 +bool __init xen_processor_present(uint32_t acpi_id); +#else +static inline bool xen_processor_present(uint32_t acpi_id) +{ + BUG(); + return false; +} +#endif + #endif /* _ASM_X86_XEN_HYPERVISOR_H */ diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index b8db2148c07d..d4c44361a26c 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -346,3 +346,30 @@ void xen_arch_unregister_cpu(int num) } EXPORT_SYMBOL(xen_arch_unregister_cpu); #endif + +#ifdef CONFIG_XEN_DOM0 +bool __init xen_processor_present(uint32_t acpi_id) +{ + unsigned int i, maxid; + struct xen_platform_op op = { + .cmd = XENPF_get_cpuinfo, + .interface_version = XENPF_INTERFACE_VERSION, + }; + int ret = HYPERVISOR_platform_op(&op); + + if (ret) + return false; + + maxid = op.u.pcpu_info.max_present; + for (i = 0; i <= maxid; i++) { + op.u.pcpu_info.xen_cpuid = i; + ret = HYPERVISOR_platform_op(&op); + if (ret) + continue; + if (op.u.pcpu_info.acpi_id == acpi_id) + return op.u.pcpu_info.flags & XEN_PCPU_FLAGS_ONLINE; + } + + return false; +} +#endif diff --git a/drivers/acpi/processor_pdc.c b/drivers/acpi/processor_pdc.c index 8c3f82c9fff3..18fb04523f93 100644 --- a/drivers/acpi/processor_pdc.c +++ b/drivers/acpi/processor_pdc.c @@ -14,6 +14,8 @@ #include #include +#include + #include "internal.h" static bool __init processor_physically_present(acpi_handle handle) @@ -47,6 +49,15 @@ static bool __init processor_physically_present(acpi_handle handle) return false; } + if (xen_initial_domain()) + /* + * When running as a Xen dom0 the number of processors Linux + * sees can be different from the real number of processors on + * the system, and we still need to execute _PDC for all of + * them. + */ + return xen_processor_present(acpi_id); + type = (acpi_type == ACPI_TYPE_DEVICE) ? 1 : 0; cpuid = acpi_get_cpuid(handle, type, acpi_id); -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Nov 21 10:33:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 10:33:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446483.702085 (Exim 4.92) (envelope-from ) id 1ox47Y-0001uI-EL; Mon, 21 Nov 2022 10:33:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446483.702085; Mon, 21 Nov 2022 10:33:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox47Y-0001u9-Al; Mon, 21 Nov 2022 10:33:48 +0000 Received: by outflank-mailman (input) for mailman id 446483; Mon, 21 Nov 2022 10:33:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox47W-0000fJ-RT for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 10:33:47 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f83dcec6-6987-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 11:33:44 +0100 (CET) Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 05:33:38 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BL1PR03MB6102.namprd03.prod.outlook.com (2603:10b6:208:31c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 10:33:35 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 10:33:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f83dcec6-6987-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669026823; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=4p0/tD9nmKeKYFF9dxbiWoNZZF40bde8hOcTGuaiPP4=; b=iQg9tqmOlIy2o01WqXUyHlSH4ZRndieNTRdY67CuJc6QNlmvQ1uzidrD k0A+eIIotpXPf/vCxt5iSWgwSnSREGwcKNba/goGqurbg19J0yufPC8tv Xrs0gnN/GpCEaPhGaiO5K09MsjTZ9McHvgeLUwxwLzj5DDTjZPEaNojTV M=; X-IronPort-RemoteIP: 104.47.55.171 X-IronPort-MID: 87779431 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:yCsLaKweCgdYjLlgNDt6t+dHxirEfRIJ4+MujC+fZmUNrF6WrkVVz mtNWDiOa/yPZGbwL49wbIy+9x8B6seDmIVnGQBsriAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnP6kT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KV9o+ OUnLzMpUlPdn8WHnpO0dO5Qpdt2eaEHPKtH0p1h5RfwKK98BLrlE+DN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjWVlVMouFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE1rCQwnKnA9t6+LuQ6L1xu3iT6jUpOCYIDXjqh+O4kEGmRIcKQ 6AT0m90xUQoz2SvT9/gT1i7rWSCsxo0RdVdCas55RuLx66S5ByWbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hTG9Iy8ONkcZeDQJCwAC5rHLqoYpjwmJSc1/Cqmrld7kMTbqy juOoW41gLB7pdIE07WT+VHBni62oZ7IXkg5623/W2Oj4QRRfoOpZ4W0r1Pc6J5oJp6xR12As X5U3cSThMgCBI+A0iyERv4AGpmt5vCYIHvdh0JiG98q8DHF027zI6hT7St4KUMvNdwLERfpe Eb7qxJN44UVN3yvBYdseJ64AckuyanmFPzmW+rSY94IZYJ+HCeA+CxtfkeW03rajFk3kao/N JGYdu6hFX8fT69gyVKLq/w11LYqwmU0wzPVTJWilRC/i+PBPTiSVKsPN0aIYqYh9qSYrQ7J8 tFZccyX1xFYV+64aS7SmWIOEW03wbEALcieg6RqmiSre2KKxElJ5yft/I4c IronPort-HdrOrdr: A9a23:ddTW96zTSUlfct4YXSXYKrPxTOgkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scu9qBTnhORICOgqTMyftWzd1FdAQ7sSibcKrweBJ8S6zJ8l6U 4CSdkANDSPNykcsS+S2mDRfbcdKZu8gdiVbI/lvgtQpGpRGsRdBmlCe2Wm+hocfng6OXN1Lu vr2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJTIWGhI97wGKrDWwrJr3CQKR0BsyWy5Ghe5Kyx mOryXJooGY992rwB7V0GHeq7xQhdva09NGQOCcl8QPLT3oqwCwIKBsQaeLsjwZqPymrHwqjN 7PiRE9ONkb0QKbQkiF5T/WnyXw2jcn7HHvjXeenHvYuMT8ABY3EdBIi451egbQrxNIhqA17I t7m0ai87ZHBxLJmyrwo/DOShFRj0Kx5V4vi/QagXBzWZYXLJVRsYsc1kVIF4poJlOy1KkXVM 1VSO3M7vdfdl2XK1jfo2lU2dSpGk8+Gx+XK3Jyz/C94nxzpjRU3kEYzMsQkjMr75QmUaRJ4O zCL+BBiKxOZtV+V9MyOM4xBe+MTkDdSxPFN2yfZX79ErscBn7Lo5nrpJ0o+eCRfoASxpdaou WPbLphjx9zR6vSM7zM4HUSmSq9AllVHA6dhv223qIJ+4EVH9HQQGi+oFNHqbrTnxxQOLyeZx +JAuMnPxbSFxqRJW935XyOZ3ArEwh5bCQ0gKdOZ7vcmLO9FqTa8srmTd30GJ3BVR4ZZ0KXOA pxYNG0HrQM0nyW X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="87779431" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OfMIqcuWdpLfMQRAAJ0ptLB/TEY+azYR7NbmuoX4NlbyKWzvGRST88tR6rNQebex0ROMS1llOigF5ojuIyUFNnhf6101FPpM0V9HcoDy39NJnUvSJfbLzPfXckeB2cYVioN9VYtXSwSzErnk0QrjhESs43UvLj4zRBE8bxIYnM+9rDgAJHGQ9Agepr69JBL+CBEO+8yqAPsQ2nlqlt1gD0+LzsCdpYgxnx+zjFWOeP2qe9+8io0CdciMRaEt5nFKOtvnejvQoKMsk1jNSP7uYZuiDIay7ZCiAzMhmF16FH8U34C0RQkg6lF0AZJGntwutgAKdavrqaSmB82LmMxgHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z49Tu1Ypmjei/9l5AHd8zeioUpwinUkwsOpJU7h/0Lo=; b=E39mtrVFOK3jj4DcwYxCysmTucj+7wzgSPcyqjqvsrrRP4tFobQOAo2ICYf27WsCXr3HeGP2FRaDwc/IHjegd56//DNQfE/FINkbhPAJQFhwRo9YxMnGuQXU3bavViNamNqykmEHuIjUoHCPBv8BtdSwjClJHi+jD7qJQ6qHfUX4c3CJ7nCKJPZe21vxe2N4fgsgDNGuUQYRxOIAAxEZjJfbJICbCwHAQUp/Xst7YEhZwfo8X3bfJZ8ws7BFQMn/NPQjNtTtWvRXU04KN9TWfBY0KAU+wiNtYriaB8tQX1S9vEbOleaIE6+NCePZQiHOROBfJQHrq7xbswh3afbVOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z49Tu1Ypmjei/9l5AHd8zeioUpwinUkwsOpJU7h/0Lo=; b=nNwZLtkZ0BWg8TmOLyqJmlvcVxsJCRq8MRKF9ORweR4QIOlhcF7WyXBhTCRS3Q5M+D8j7r+j31POxrZxhJAw4/FKCCWLsqhwhD3k+sbL/zf3IujFLtMS1re7YAvXnSDiJtI20/zD4HBucxT/UYGDWbPPDGRNYoka6rlbhQd428I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, jgross@suse.com, Roger Pau Monne , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH 3/3] xen/acpi: upload power and performance related data from a PVH dom0 Date: Mon, 21 Nov 2022 11:21:12 +0100 Message-Id: <20221121102113.41893-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221121102113.41893-1-roger.pau@citrix.com> References: <20221121102113.41893-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0620.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:294::16) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB6102:EE_ X-MS-Office365-Filtering-Correlation-Id: f52a8980-9f7b-42ce-36c5-08dacbabd6d6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cRDCH1YOIuHSOcCwvQrsm1XnPDPZS7doelFmQeTvhuvelNoHhlW2HHDKdaoytEMkRCTaG88RaQA5eqQsldhaMYnEHkknLvV8P3PbqNcvABi+KdedVWQLy+S/sLnAqcYIN6GD2ZJs5+55Y8yhzkeBHk+NuxQK5eY3bdndUJ4X4azAYbstAxFRtVvCCZNEUitElQ84IllbMTy817sELMJTm9AWIuebtM6vtF2offbGM82po5/YNZs4K2TARSmrwukArSWN7TR/WB4iyWj4A9LoycjuB05OfGfJmZJ+YCqFPfFw3vyOHXhHYiHtjBaCnD2Umhnq8+tlySAYXce5msVdwN/d6tC3v95aOqaSELAAvSstsgVWTWFwdYou+9CyHvktvvfGBu/sQCBzDLset++NxOG/uBEx2PskJC/Tz7qD96XFNUQsvp5qWq73a41XjGphbdUE7TqIY+GT8QyNxmRibaIQqgJkp30v40s8i8FLad6YGeJTjeZngzUulp0tC4zq33vf9fGNCQfLS/co7dOwmMziwjpUOM1gHfaGiZrighULF70rm085GGlCP1QlaUhF31iSwKmlfFPx27pGJn7sKBQCU6x1jg9IQF6Vw3+v7NgExFJcfGOPwtfKCNyjCG2NidLmjut6x+RBnJ0jBPxkRw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(136003)(366004)(451199015)(478600001)(6666004)(6506007)(6486002)(54906003)(38100700002)(66946007)(66476007)(26005)(316002)(8676002)(86362001)(30864003)(6512007)(83380400001)(6916009)(66556008)(4326008)(82960400001)(7416002)(5660300002)(186003)(41300700001)(8936002)(2906002)(1076003)(36756003)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZCtwdnRjYk9sa1lkK0g5bTV1Y1RrbVo0NUJrdGozMGljOExDVzR5N0xNQnhu?= =?utf-8?B?enVpTjExN042dzdpb0lpRzNMWHdDSDF2elVrTXdHbnRrNTNLdXRjMnVOcHFj?= =?utf-8?B?bHdSSXhXN0M5VG5qUjJrRkpLTGlMRlNpeDJ2djZVVzVmYWUvbU9UeUo2aklw?= =?utf-8?B?d29mRm9oL3Y1WVJiNzJlcnA1Z2NzTVNIcmtXM3drRDNOeHUvckNBanZFY0c1?= =?utf-8?B?ZnMrbm9mMHI2b0FzRmVZVkpOdXZYNFdiVWNIbEkrQ0NXdDJYRHJ4bkk1eldM?= =?utf-8?B?SkdEL24xQ0NMcWE1dXBIcm5KUzcyWUxGc3JkS3ZHZkd5Ym94M2RjSm1LL0ZI?= =?utf-8?B?czh1YXJhWFFsRkFSMEZlYndscGtGakVhNlJ4UEhvTlVqRE1JNmJad0FzODhN?= =?utf-8?B?a0R0VzQyelVxWVAwNkZ0bDYxQytmY3BWNi9ITENhQXdCbENaaDhWelBKR1ox?= =?utf-8?B?M3VVL1cyTExyRGI1b2UrRzFQVE14YTBWdVJocGhHTVVERHpVSGtKMWtsVXdw?= =?utf-8?B?a3ludGdZbUJKb2hSZkQ4VFNwWW1kZElwU2tRMkZaWFIrMm1SVGVOOHZnNDB1?= =?utf-8?B?cWFpbnZTNTluL0h0MVBrOW5sWE54MW91QytQSk55b2xVNThUd0hKTHo3ZVdi?= =?utf-8?B?TXRyemxDQ1dVSHpON1FjSGpOLzdERkg1cEltakI3cGt4UG15bUxWbDZkSEYv?= =?utf-8?B?NnhRQWFHT2d5dVNydGNUL3hZWjBIZ2FhNzk3d0p6d0pPUVd0Zis1T2lBSmlr?= =?utf-8?B?bDJrMk42OExQMDhpZ0l0VTNERkNldzBSMjhTaFIrTzVvVStvam1BZDdvaGg2?= =?utf-8?B?TDlxcFRQZi9yN1l4WkZLdkNWK1oyT0pVaVRjRStscTllT1AvbzlobDIxa1ZO?= =?utf-8?B?elV2dVhiZjNvZFdTcE1NMlFIaGU2RlZycjI5ZmlndDl1RUV2eVZZQlFFdWla?= =?utf-8?B?bGJqZUtKMGIyUlVINFlpOGNvODI4ZnY3cytQckFZQ3hqTWRVVmR3WllLN2xR?= =?utf-8?B?aGJZVEtEWFkrL21OYlBkRTJGOUZ6V2ZxVTJ4U1JPTDhlOG5DTHBpcXlLUE81?= =?utf-8?B?d1JDUUNZMGMzSGJrcVQ4Z1lpbCt6U3l6ZG45dmlUMDliZldzaUxwb0QyZUtr?= =?utf-8?B?eWM1VkdjZ2Y2TVBhMTA5c0VGZElvOEJueWtsYlUxNlQxMjA5RWZyM0tzV3VW?= =?utf-8?B?T3JqVUZseXZIa3dWckJLWEYzMHBnY3E1dUt0Vm56ckxjNmVWNWF5STVOSTBF?= =?utf-8?B?L0J3VXl5ZEhLREJIc0xXMEVyZjFZbjE3NlVSallNY3NNNnJGbjhVaFlYbzha?= =?utf-8?B?aUpEbGk1M2RXM0JsT1d2U3BNNEgxcndYeXpWaExGQ2FBVTdNMURmZlpacVZi?= =?utf-8?B?cExPRS85ak05SHRIR0d5UGpUNkxTdHNwQzU2cEVoeTBpTXcvOE5kZ21uY3c1?= =?utf-8?B?Nmt2cWlpWmxQTjdTRXo1czBrMmVJZ1ZhMlhjYm1FTEJmNjRyamhUcVJsUGt4?= =?utf-8?B?ay9DYXhYNnlYZkJPbFhXU2Rlam9wd2JKUy8xQ2FMWlVSR3d4dEloTU5keVNz?= =?utf-8?B?dlp1Vm9pdEI5T29COEhBK3RoR2dRR2YyY2N3Q2owbGU0QzVQWVRzWFNqeGhS?= =?utf-8?B?UFkvSU84OEFOcFpIc0VpK3J3QVJQckk5M3FkKzE5N1Axem5oVHJQQXVhVFJ2?= =?utf-8?B?VVNZamJzNmc4eWlVVDkxL0IzNVE5NlB1SGtUSHBEZHJIMENIdjdQTktVQzVl?= =?utf-8?B?bVpYUWN2MExGZ2VkUnpQTzhWZTl1bzE0Mk5DbkpQYjgrMkY3UDBhaWptcVNL?= =?utf-8?B?YlVOU3h2WVY2NENGV0wxejVpdUIyL0YrQ1V4Snptc25uZzNOaGQ2YjVEQzYv?= =?utf-8?B?alFramRqQW91a05Cc2hVS0dGYW90NGtGQVMyeFZSNVRYeW93Vjk5QkhHYU1r?= =?utf-8?B?dlJOb3NMSUxFNkxpMkM5b1lOOUFQcnN4bU0vUmloLy9DOGRRbVFZTjUvcEg0?= =?utf-8?B?Ny9JUWlWMERzOStjUVBRcGNSRVBUVmpZMjd0OWZ6bENlQjFGU1VBWThaZnBs?= =?utf-8?B?VG9HeHNnaXpGZFFzMlA1OHpzM3lmOW0rN0FlalBBSmRMSEg2WUwrU3d4dDRo?= =?utf-8?Q?ai2xx4MYkD61xLpRV9xxae4DM?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?UXkrdVlhVFZLb3IrK1U2Vlljd0VjNy9qbWRFdUtKUGczL2VnYmNnQmxRN1Nl?= =?utf-8?B?V2E3Z3BxVkVIWHREMHQ3LzBZbHQ5M0VUL3BHc1dNaWVaMnBjY09ZSmhuSFRq?= =?utf-8?B?MEpIN0NWSndKWUp1eE9EVXdJczVJRzVuTHJab2NPdkt4YjV3NlVTS1NSSWQ3?= =?utf-8?B?WlJOdllUZCtwajYza2dZeDdwaTZCN2JTcjdLNzF3enRGWEZsRXRoaUQ1NmpX?= =?utf-8?B?SmVQQ3NSR3lTb1dvclViamVjemJxMDR6T0RlTnpXbWV3OFlmMXhYS05lNy9i?= =?utf-8?B?Q2FQc1lvRXFSZlRDM3hjbGt6WHNIYThYNlptL0VOanhhem45RWtUQnIreEM1?= =?utf-8?B?bWFRTm0vWURaUWRPK0I3VzZrLzBQeDQxWkNzQXB0a0F0R3pQMzBrMkcxekxa?= =?utf-8?B?RU5VeGc4ZTRPSE5aZGRDN3NzSHhmY2QzWFpBcDV3dXByR3JWdjhkckRBYVRa?= =?utf-8?B?V0NycDBCaWVPbDZOWC9DeFNRSkJDdm4rUkZMdjVzOWZNRUV0TmNYODB4K292?= =?utf-8?B?cHF6YjU0ZXZJWU9ZMHdBRFdGSzRtUnZFbUd4YVFBMDRWQ01OYkl5ejd3a1JX?= =?utf-8?B?NEhVNnpRbUlUVDludGVQSThiTGxTbXMyRENWTE5neWppUTdGZHFoOUI3UDlv?= =?utf-8?B?Tnc3R0VKOEkzTVZJVkFXU09pV0ptcDFFUkVzUDFzaHU3d0ZhUzNPd043RUY4?= =?utf-8?B?QmNNekJRZzRrSGdsa2QvR0RGU0xIRk96ZmdjRlJnc3BhNGxBK005Vkh1OXZv?= =?utf-8?B?TG14QnhVV1pPalBvTlcraDZKRXh6QTRlbC9SbFl5VE1aZjRQT1lVUktEdjZ5?= =?utf-8?B?OHNBOE5oVXUzVDJZb1daQTZDTmxJci95K3JKYU1WQUJxUW9Ycm1wakdUdUhx?= =?utf-8?B?ZDdVd01VV3h4ZmdIcyt4QjByamxHMUEwclJzTCtuWWl5ckJBRk1NZDVxY0gw?= =?utf-8?B?SHdxTmsvQjNwRkl5V2w1WFJxaE15Z25DNEtGQVFVV0hKUWhvY2JVdG5lMXVv?= =?utf-8?B?TzR4UEc5TXllUlJRZUYrdHNqL3h5RER6cnhjYWZkOEhlQ2xHdGo4UmdaVzRP?= =?utf-8?B?azF0dTRpY3Q4Q0thR05wYmlRNFJ2eEdKODhvRC92cGlqMk1rQ2ZzRWEzT2dV?= =?utf-8?B?aDloNzVJM21TODNaTTBtOFJUeHpxWHJrKzlKOGZEc2N4ejNYQkNDNVVOMVBZ?= =?utf-8?B?UzZSbWhqck9jZ1hpNDZRellYaS9zWmdkWUhoVkp3RU5DUzZDc2dGV1hWcnR2?= =?utf-8?B?eTEzNkxMYy93QitnbmVGRjBhZHN6V1d1bi8rVWg4ZW5aZFZBUzJDSVJGbkNn?= =?utf-8?B?aG01eGZDSjNqa3JsTFNaUnV3akhYMzVvZXN0NmZsbStndXdqUXJlWEhLRjNG?= =?utf-8?B?Ykp4Q1RabjdUY1FHUmg2ZndqUzhXdVI3RDZIdkpyeTFWOW81eGxubS9mZ2wz?= =?utf-8?B?cDRIekFHYTJOQVpSVEFuQ3orT0dJZ1Bma0pwaFB1N3k3aTJ2REFucXlkbjhy?= =?utf-8?Q?WxsN4+uxj6vDjotUv4HVJovMAVa?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f52a8980-9f7b-42ce-36c5-08dacbabd6d6 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 10:33:35.3402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QiNvpLKeXFZVMe+yZgJqgi5Cw+9ORRg4KdRxKLVqfxVrY7Z271NSXb8rsyxm6IfO5DCxa2zzK9hFoilN0K2jOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6102 When running as a PVH dom0 the ACPI MADT is crafted by Xen in order to report the correct numbers of vCPUs that dom0 has, so the host MADT is not provided to dom0. This creates issues when parsing the power and performance related data from ACPI dynamic tables, as the ACPI Processor UIDs found on the dynamic code are likely to not match the ones crafted by Xen in the dom0 MADT. Xen would rely on Linux having filled at least the power and performance related data of the vCPUs on the system, and would clone that information in order to setup the remaining pCPUs on the system if dom0 vCPUs < pCPUs. However when running as PVH dom0 it's likely that none of dom0 CPUs will have the power and performance data filled, and hence the Xen ACPI Processor driver needs to fetch that information by itself. In order to do so correctly, introduce a new helper to fetch the _CST data without taking into account the system capabilities from the CPUID output, as the capabilities reported to dom0 in CPUID might be different from the ones on the host. Note that the newly introduced code will only fetch the _CST, _PSS, _PPC and _PCT from a single CPU, and clone that information for all the other Processors. This won't work on an heterogeneous system with Processors having different power and performance related data between them. Signed-off-by: Roger Pau Monné --- arch/x86/include/asm/xen/hypervisor.h | 2 +- arch/x86/xen/enlighten.c | 2 +- drivers/xen/xen-acpi-processor.c | 225 ++++++++++++++++++++++++-- 3 files changed, 211 insertions(+), 18 deletions(-) diff --git a/arch/x86/include/asm/xen/hypervisor.h b/arch/x86/include/asm/xen/hypervisor.h index b4ed90ef5e68..1ead5253bc6c 100644 --- a/arch/x86/include/asm/xen/hypervisor.h +++ b/arch/x86/include/asm/xen/hypervisor.h @@ -62,7 +62,7 @@ void __init mem_map_via_hcall(struct boot_params *boot_params_p); #endif #ifdef CONFIG_XEN_DOM0 -bool __init xen_processor_present(uint32_t acpi_id); +bool xen_processor_present(uint32_t acpi_id); void xen_sanitize_pdc(uint32_t *buf); #else static inline bool xen_processor_present(uint32_t acpi_id) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 394dd6675113..a7b41103d3e5 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -348,7 +348,7 @@ EXPORT_SYMBOL(xen_arch_unregister_cpu); #endif #ifdef CONFIG_XEN_DOM0 -bool __init xen_processor_present(uint32_t acpi_id) +bool xen_processor_present(uint32_t acpi_id) { unsigned int i, maxid; struct xen_platform_op op = { diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c index 9cb61db67efd..b189ea69d557 100644 --- a/drivers/xen/xen-acpi-processor.c +++ b/drivers/xen/xen-acpi-processor.c @@ -48,6 +48,8 @@ static unsigned long *acpi_id_cst_present; /* Which ACPI P-State dependencies for a enumerated processor */ static struct acpi_psd_package *acpi_psd; +static bool pr_initialized; + static int push_cxx_to_hypervisor(struct acpi_processor *_pr) { struct xen_platform_op op = { @@ -172,8 +174,13 @@ static int xen_copy_psd_data(struct acpi_processor *_pr, /* 'acpi_processor_preregister_performance' does not parse if the * num_processors <= 1, but Xen still requires it. Do it manually here. + * + * Also init the field if not set, as that's possible if the physical + * CPUs on the system doesn't match the data provided in the MADT when + * running as a PVH dom0. */ - if (pdomain->num_processors <= 1) { + if (pdomain->num_processors <= 1 || + dst->shared_type == CPUFREQ_SHARED_TYPE_NONE) { if (pdomain->coord_type == DOMAIN_COORD_TYPE_SW_ALL) dst->shared_type = CPUFREQ_SHARED_TYPE_ALL; else if (pdomain->coord_type == DOMAIN_COORD_TYPE_HW_ALL) @@ -313,6 +320,155 @@ static unsigned int __init get_max_acpi_id(void) pr_debug("Max ACPI ID: %u\n", max_acpi_id); return max_acpi_id; } + +/* + * Custom version of the native acpi_processor_evaluate_cst() function, to + * avoid some sanity checks done based on the CPUID data. When running as a + * Xen domain the CPUID data provided to dom0 is not the native one, so C + * states cannot be sanity checked. Leave it to the hypervisor which is also + * the entity running the driver. + */ +static int xen_acpi_processor_evaluate_cst(acpi_handle handle, + struct acpi_processor_power *info) +{ + struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL }; + union acpi_object *cst; + acpi_status status; + u64 count; + int last_index = 0; + int i, ret = 0; + + status = acpi_evaluate_object(handle, "_CST", NULL, &buffer); + if (ACPI_FAILURE(status)) { + acpi_handle_debug(handle, "No _CST\n"); + return -ENODEV; + } + + cst = buffer.pointer; + + /* There must be at least 2 elements. */ + if (!cst || cst->type != ACPI_TYPE_PACKAGE || cst->package.count < 2) { + acpi_handle_warn(handle, "Invalid _CST output\n"); + ret = -EFAULT; + goto end; + } + + count = cst->package.elements[0].integer.value; + + /* Validate the number of C-states. */ + if (count < 1 || count != cst->package.count - 1) { + acpi_handle_warn(handle, "Inconsistent _CST data\n"); + ret = -EFAULT; + goto end; + } + + for (i = 1; i <= count; i++) { + union acpi_object *element; + union acpi_object *obj; + struct acpi_power_register *reg; + struct acpi_processor_cx cx; + + /* + * If there is not enough space for all C-states, skip the + * excess ones and log a warning. + */ + if (last_index >= ACPI_PROCESSOR_MAX_POWER - 1) { + acpi_handle_warn(handle, "No room for more idle states (limit: %d)\n", + ACPI_PROCESSOR_MAX_POWER - 1); + break; + } + + memset(&cx, 0, sizeof(cx)); + + element = &cst->package.elements[i]; + if (element->type != ACPI_TYPE_PACKAGE) { + acpi_handle_info(handle, "_CST C%d type(%x) is not package, skip...\n", + i, element->type); + continue; + } + + if (element->package.count != 4) { + acpi_handle_info(handle, "_CST C%d package count(%d) is not 4, skip...\n", + i, element->package.count); + continue; + } + + obj = &element->package.elements[0]; + + if (obj->type != ACPI_TYPE_BUFFER) { + acpi_handle_info(handle, "_CST C%d package element[0] type(%x) is not buffer, skip...\n", + i, obj->type); + continue; + } + + reg = (struct acpi_power_register *)obj->buffer.pointer; + + obj = &element->package.elements[1]; + if (obj->type != ACPI_TYPE_INTEGER) { + acpi_handle_info(handle, "_CST C[%d] package element[1] type(%x) is not integer, skip...\n", + i, obj->type); + continue; + } + + cx.type = obj->integer.value; + /* + * There are known cases in which the _CST output does not + * contain C1, so if the type of the first state found is not + * C1, leave an empty slot for C1 to be filled in later. + */ + if (i == 1 && cx.type != ACPI_STATE_C1) + last_index = 1; + + cx.address = reg->address; + cx.index = last_index + 1; + + switch (reg->space_id) { + case ACPI_ADR_SPACE_FIXED_HARDWARE: + cx.entry_method = ACPI_CSTATE_FFH; + break; + + case ACPI_ADR_SPACE_SYSTEM_IO: + cx.entry_method = ACPI_CSTATE_SYSTEMIO; + break; + + default: + acpi_handle_info(handle, "_CST C%d space_id(%x) neither FIXED_HARDWARE nor SYSTEM_IO, skip...\n", + i, reg->space_id); + continue; + } + + if (cx.type == ACPI_STATE_C1) + cx.valid = 1; + + obj = &element->package.elements[2]; + if (obj->type != ACPI_TYPE_INTEGER) { + acpi_handle_info(handle, "_CST C%d package element[2] type(%x) not integer, skip...\n", + i, obj->type); + continue; + } + + cx.latency = obj->integer.value; + + obj = &element->package.elements[3]; + if (obj->type != ACPI_TYPE_INTEGER) { + acpi_handle_info(handle, "_CST C%d package element[3] type(%x) not integer, skip...\n", + i, obj->type); + continue; + } + + memcpy(&info->states[++last_index], &cx, sizeof(cx)); + } + + acpi_handle_info(handle, "Found %d idle states\n", last_index); + + info->count = last_index; + +end: + kfree(buffer.pointer); + + return ret; +} + /* * The read_acpi_id and check_acpi_ids are there to support the Xen * oddity of virtual CPUs != physical CPUs in the initial domain. @@ -354,24 +510,44 @@ read_acpi_id(acpi_handle handle, u32 lvl, void *context, void **rv) default: return AE_OK; } - if (invalid_phys_cpuid(acpi_get_phys_id(handle, - acpi_type == ACPI_TYPE_DEVICE, - acpi_id))) { + + if (!xen_processor_present(acpi_id)) { pr_debug("CPU with ACPI ID %u is unavailable\n", acpi_id); return AE_OK; } - /* There are more ACPI Processor objects than in x2APIC or MADT. - * This can happen with incorrect ACPI SSDT declerations. */ - if (acpi_id >= nr_acpi_bits) { - pr_debug("max acpi id %u, trying to set %u\n", - nr_acpi_bits - 1, acpi_id); - return AE_OK; - } + /* OK, There is a ACPI Processor object */ __set_bit(acpi_id, acpi_id_present); pr_debug("ACPI CPU%u w/ PBLK:0x%lx\n", acpi_id, (unsigned long)pblk); + if (!pr_initialized) { + struct acpi_processor *pr = context; + int rc; + + /* + * There's no CPU on the system that has any performance or + * power related data, initialize all the required fields by + * fetching that info here. + * + * Note such information is only fetched once, and then reused + * for all pCPUs. This won't work on heterogeneous systems + * with different Cx anb/or Px states between CPUs. + */ + + pr->handle = handle; + + rc = acpi_processor_get_performance_info(pr); + if (rc) + pr_debug("ACPI CPU%u failed to get performance data\n", + acpi_id); + rc = xen_acpi_processor_evaluate_cst(handle, &pr->power); + if (rc) + pr_debug("ACPI CPU%u failed to get _CST data\n", acpi_id); + + pr_initialized = true; + } + /* It has P-state dependencies */ if (!acpi_processor_get_psd(handle, &acpi_psd[acpi_id])) { pr_debug("ACPI CPU%u w/ PST:coord_type = %llu domain = %llu\n", @@ -392,8 +568,7 @@ read_acpi_id(acpi_handle handle, u32 lvl, void *context, void **rv) static int check_acpi_ids(struct acpi_processor *pr_backup) { - if (!pr_backup) - return -ENODEV; + BUG_ON(!pr_backup); if (acpi_id_present && acpi_id_cst_present) /* OK, done this once .. skip to uploading */ @@ -422,8 +597,8 @@ static int check_acpi_ids(struct acpi_processor *pr_backup) acpi_walk_namespace(ACPI_TYPE_PROCESSOR, ACPI_ROOT_OBJECT, ACPI_UINT32_MAX, - read_acpi_id, NULL, NULL, NULL); - acpi_get_devices(ACPI_PROCESSOR_DEVICE_HID, read_acpi_id, NULL, NULL); + read_acpi_id, NULL, pr_backup, NULL); + acpi_get_devices(ACPI_PROCESSOR_DEVICE_HID, read_acpi_id, pr_backup, NULL); upload: if (!bitmap_equal(acpi_id_present, acpi_ids_done, nr_acpi_bits)) { @@ -464,6 +639,7 @@ static int xen_upload_processor_pm_data(void) struct acpi_processor *pr_backup = NULL; int i; int rc = 0; + bool free_perf = false; pr_info("Uploading Xen processor PM info\n"); @@ -475,13 +651,30 @@ static int xen_upload_processor_pm_data(void) if (!pr_backup) { pr_backup = kzalloc(sizeof(struct acpi_processor), GFP_KERNEL); - if (pr_backup) + if (pr_backup) { memcpy(pr_backup, _pr, sizeof(struct acpi_processor)); + pr_initialized = true; + } } (void)upload_pm_data(_pr); } + if (!pr_backup) { + pr_backup = kzalloc(sizeof(struct acpi_processor), GFP_KERNEL); + if (!pr_backup) + return -ENOMEM; + pr_backup->performance = kzalloc(sizeof(struct acpi_processor_performance), + GFP_KERNEL); + if (!pr_backup->performance) { + kfree(pr_backup); + return -ENOMEM; + } + free_perf = true; + } + rc = check_acpi_ids(pr_backup); + if (free_perf) + kfree(pr_backup->performance); kfree(pr_backup); return rc; -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Mon Nov 21 10:50:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 10:50:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446501.702096 (Exim 4.92) (envelope-from ) id 1ox4NV-0004v9-Ra; Mon, 21 Nov 2022 10:50:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446501.702096; Mon, 21 Nov 2022 10:50:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox4NV-0004v2-Ot; Mon, 21 Nov 2022 10:50:17 +0000 Received: by outflank-mailman (input) for mailman id 446501; Mon, 21 Nov 2022 10:50:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox4NU-0004uw-MD for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 10:50:16 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 464810b9-698a-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 11:50:14 +0100 (CET) Received: from mail-mw2nam10lp2107.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 05:50:11 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by DM6PR03MB5129.namprd03.prod.outlook.com (2603:10b6:5:1eb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.11; Mon, 21 Nov 2022 10:50:07 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::5c96:fc3a:9d36:4a2e]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::5c96:fc3a:9d36:4a2e%4]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 10:50:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 464810b9-698a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669027814; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=EVVapN5AyFBIbz8p+YHaAbuk84v6u4IHoGC2r3i8diI=; b=gOX5wd+G1Vz5kg7KbIZ7Z9Gh23FlbnSKJsKsQUpCQ6j7rmt+N9K3M92U 8NhSMF1Vkc+YWPbjgtFI0WtOUPRD2mQDMkyBelM5TBegyWtPo9mJdlH6p 1Vp3fhK1FqC9kkngmF7bcCCPFONy3trwev0plk/IqHefDbHfIPNt1WSfd Q=; X-IronPort-RemoteIP: 104.47.55.107 X-IronPort-MID: 85659536 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:X+OSIK/+4Jk5dvqj7SizDrUDmX+TJUtcMsCJ2f8bNWPcYEJGY0x3n DdLCmmOMv/eNjekL4p1b4u1oE0DuMDRz9dgGVBoryg8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKoS5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklX8 /8hdSBKZSuz2cSqzuqbRrZOt+MKeZyD0IM34hmMzBn/JNN/GdXmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUpj9ABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCN9MSezlraACbFu73DwKJAUcWH2AodK62k2RC89Zc kpOw397xUQ13AnxJjXnZDWYrXier1gjUtxfO+Qg7UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhqgGqy8qDqzPW0QMjUEbCpdFQ8duYC7/8c0kw7FSctlHOitlNrpFDrsw jeM6i8jm7EUis1N3KK+lbzavw+RSlHyZlZdzm3qsqiNt2uVuKbNi1SU1GXm IronPort-HdrOrdr: A9a23:MnGa5a5T3M/Se8b9lwPXweCCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpixBiSgSiu4LvaFQHd+hsFSTtAzZor7G CAymXCl+SemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQBiTwhh2ubIFBXaTHmDwuuumg5Hsjjd GJiRY9OMZY7W/XYwiO0FXQ8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMk5 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvvn+9Ua1wWR4S2rpXV9 WGP/usosq+tmnqNkwxi1MfhOBEmE5DRituDHJy4fB9mAIm4UyRh3FouPD32E1wtK7VAqM0md gteM5T5c5zZ95TYqRnCOgbR8yrTmTLXBLXKWqXZU/qDacdJhv22tfKCZgOlZaXkaYzve0PsY WEVEkduX85ekroB8HL1JpX8grVSGH4WTj20MlR65Vwp7W5HdPQQGa+YUFrl9Hlr+QUA8XdVf r2MJVKA+X7JW+rHYpSxQXxV5RbNHFbWswIvdQwXU6Iv6vwW8XXn/2edOyWKKvmED4iVG+6Cn wfXCLrLMEF9UyvUm+QummkZ5osQD2LwXtdKtmowwFI8vl9CmRliHlktX2poseWNDZFrqs6OE NjPbKPqNLImVWL X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="85659536" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cq6NRp2ZcVtostVA6SCpynJPIrclFt2ZQUKHBB7NL6PuAMN37+RMsspFnVEGt7q0HUjsR8u70ylgWhhczHtl76tr1JyXGIeXHO8Czi5Lh0HybbTiVZpGxENHFQwMw22Vy1i3uxmvwe5ZClGihEcXJOz/mXOH1PwlfkjI+rdHNPTxnfQD6lyXZNxJgE/4ptKENvwy3EkO0TT3kzrpaFFRJo0pTccRu3ZH5L9OQ7CUZGHO/bNhGmhDOrmYKYVDOBC9h+NEB9ONUkYrqVCmpnM+kcdGmFSTPbcSgfypH2JNHtB+N+hyz+wABD99J3/k4snwq0wV6H46QF7y8RjAp9eZEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EVVapN5AyFBIbz8p+YHaAbuk84v6u4IHoGC2r3i8diI=; b=K6gUz4VcHOthYQm69t5W9Wx5EQjNEv09XOK6QX6yt7Zz93lnEnoVwEx4L5mHmiEh4/tkpzZnlT3JC778g32plQj6YQEsK5IFZ7TK+nCj1eiDxQsKUTH6GAhiNXtaR9FmSSTsfzXsb2Vo5JIVtAX0iD4V33l4IbUWfRHdfmgidydSR8UllvMhr4siqAk2VIeIdCTog8DqoxRzMoiCf/0hwM0iDhEO3I8vmPbBKQhRjYNzgmtE74boiD3KyBLQX/BPqTW24fIqv4FinHAhnZiH1haF2o2XxwquikjnlYyKkWdxHpZlhgGPYjyFAzQUBjc9PTiBdTZk+e9PA4i+SyZPYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EVVapN5AyFBIbz8p+YHaAbuk84v6u4IHoGC2r3i8diI=; b=FjZO691pWrkPnWcSIxs+xOgbQunk+MIlR7U/qVSdj7ctDzNRE8IVioQ56M7W9Ca1q5x0Xlx3WQ125Yz3gbivp+/qEN8MBkm6hnakt562TOCzWbT1tutryuNg+ox5tB/nezPvX4wm3O52R/nS1MOyRR/v+xcZIxPloTNIy0y5aQc= From: Andrew Cooper To: Henry Wang , Anthony Perard CC: Xen-devel Subject: Re: [PATCH for-4.17] tools/libxl: Correct error message units in libxl__domain_set_paging_mempool_size() Thread-Topic: [PATCH for-4.17] tools/libxl: Correct error message units in libxl__domain_set_paging_mempool_size() Thread-Index: AQHY+2+HxzzdtfVo7EqtEeJLb7BMnq5E7LOAgACNwgCAA7y1gA== Date: Mon, 21 Nov 2022 10:50:07 +0000 Message-ID: <0d19dd94-7396-476b-b29c-a13d6f339f10@citrix.com> References: <20221118170213.2872-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|DM6PR03MB5129:EE_ x-ms-office365-filtering-correlation-id: 01e14e0d-6ba3-4b6d-6e40-08dacbae27b6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Og7FKTobAQzQYO4b3Otz9cA1qKznwB+2688fFcM0WS1sMcWQKvCx9L/zV2SDafZAAOJs0wuNuJZ4z0j52I8++ini4j37RR13bmwLIMAgvZYd2NPGwM5kdB63e6t43zrkadERAAoSROsMH5uP5SXRoxUAiLvbTOC42DTSTaAeBje14fshOjtOHbYOGsEc32VJiWzUihdnT0c537M1GEiKkmBtUKqtaIMg4+vuBITA30rGkvk2RjxE1NRR07QaYJ++qoI0eeFyJhaCy0egKpMXAoPudjr46+mDXuQqWIjZG+CHAcyjISpaZOIWbuHf8lbmjJX/6L3OPo4SvJgjLL2DwWY7S5CrY+/oduS3yfeu6MnZY1+AAf04+xpw3VzA+AK0Xt24TS01F+YfRHQ6ii2WoPuNya+Aw85ZM2ewHX9M/nEDKNixHD1DS/+YNPzNTXyD1K4oqG/581V3I8lMJC5NSlQVODH0hWfNa/ALkDCMu5bBSv+NGBjGA1NUsbtRrppC2JertXnCXcM20RSF/BPKFgDjtOdQASo/zVwym8uK024p13ZUVk4Myr207hVWYxYtB9RbsCmCt1c5d9OGDi1lf9znFEy4h4zKnNOZMGnk7ZzIErDbTOIAzYAgauH77IhgkdK7bfH/ffMZQK8ZNbRP47V5nRmAzkONA5bjJgcIE2PcwPzM2kbbP+/8ghAiDzJr0gsov96ZdG7+7BKj2koypeZQ56lqAiL1w6oiWiPR5q08uHdNtcBwB9h8LA5LiDudUF6qq1X4UTgMrDWd77sFHIAAw63Lvg6ogHDOobLtx3g= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(451199015)(82960400001)(31686004)(38100700002)(5660300002)(122000001)(31696002)(83380400001)(86362001)(316002)(6636002)(6486002)(478600001)(38070700005)(110136005)(71200400001)(15650500001)(2906002)(8936002)(66446008)(8676002)(64756008)(66476007)(91956017)(76116006)(41300700001)(66556008)(4326008)(26005)(66946007)(186003)(6512007)(2616005)(6506007)(53546011)(36756003)(101420200003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dnZhQ2VTcVRkRmh5V1hhMFNZOTZ3ZkhDRnp2SHk3T3RFZkRPWlNnOEQ2cWJk?= =?utf-8?B?NDFYamhpZlQ3Y09ZS2ZKbW54dk9tTjFhRFY3V2p3YnBIMHpiNW9RSTR1eDA5?= =?utf-8?B?b3FmZDJCSFlkTjgxc2dQL0VESkFiL1lKbWlzZ1lJc0RNbWY1NDJiMlVDdjBC?= =?utf-8?B?TUI1RnhJMmRQaFlWYXI2MmQ5cSswMXN5Q2t2Vi9UeENZZjBlZlgrbVh1RjM0?= =?utf-8?B?aW5IZHNkZmIzNnZJclNIZHgzbnp5VzNzeDJLa3RROUNQQUVOWnF5eTZBVW9Q?= =?utf-8?B?Y290RVoxMVBOYXhEYkVHSXRGSEtoMkE1d0JwZGc5aFMzSnNmdDhhU1N0KzBF?= =?utf-8?B?UzVseXoxdXZYakc3eUZJRDhsSDFUV2I5OVVtMEcwT3ZPNlVFQXg3b25LWGJZ?= =?utf-8?B?cThsdm1kb0t3UEd3RTNYRkovUkw2THhQR3dGZkpkaDhQWnloeU1JZUhHQzh6?= =?utf-8?B?c05Zc25EaWVGZnA1TWxaNUVadDZMVXNNZWp3ekRPMmhyT1c4ZXRwVjR1Ynl4?= =?utf-8?B?Z0hXSjVWZU91aitqTTU2aENEbitiQi93OEN0TUYrNWVsRTZQWW9hbDA4K0RW?= =?utf-8?B?RmE4clVOTmNhaGNZSVN0c01KdDJSWjF0S2FlM3VSa3hXMnU3SVVBTnNtUDJS?= =?utf-8?B?R1ozdkZsM0lDREMyaHhlTXFqcXBBT0Nzek5yYS9HRm9SeW5IOEdUMk1oV0Rt?= =?utf-8?B?ck1WdERzKzVGd2UydUxENUd5SUtuUW1nOWFhbHRWdzVLT0tmdlFYNE9EVTd3?= =?utf-8?B?dFhGaHF6cERFTUpuOG1NVElWTEdRSVFWdWV0QnVFMW5jZjU4aWlMRGRoaCth?= =?utf-8?B?THpJYlpCenpOelFrZ0ZZaU9LSDR1NUExenlvQ1hsWm5XVE5kRUVDTkV1Sndn?= =?utf-8?B?akVPU1FXS0hXV2tFdGhXR1F2WjlsN2NMUURMbE15MkZDLzI1Y3ZqYlFIYkxv?= =?utf-8?B?TzZNUmFJRCtNTG5wWGVyYjBtZ0FIa0k5d1hLL1pzak5OcCtHWWh6UTBtTTRy?= =?utf-8?B?a2Q3bGc0eWJUekZqTmpFNHdTRmx2cy9iTmpPcmNJSFlsOTdkaTVMLy9nTFhQ?= =?utf-8?B?WGk2TTlQS20vTGc2WmJ5akhoZ3VoK1o5dnJlMC9oUkJjREpaUTQvdUltcC9o?= =?utf-8?B?Myt0U1VTbndPRE0xdFJEMHBhRG04ZzloZXUxK041NVNGeHJJcnVxSWdmbVdQ?= =?utf-8?B?UFZ0aG55MWZvOHQrcGdLM042SjllN1FaMm5JelJtdnRmTWwzc3cweWhDNzNq?= =?utf-8?B?VE9yUUFKZVZxalVRV3JTNmJBSm90anlNMFJSZlNsT2tkOFMrVmFWT0o3N0FN?= =?utf-8?B?RWFEaEp0amJZSVV4VDI0MWdDb254eVMzR2ZpMndjcUIvNEpUVjlORU1xZjFF?= =?utf-8?B?SE94Rjk0a3dsUFBoa1hEZFludUk0UFM1UnlBOFF4TCtONjk3MFVvdmZNc3B0?= =?utf-8?B?dkFNNm5NL2wrMG5JZmg1elZnMDZyV2dReWhyNlhMZmsrRUFYNEpVSnp6NUlL?= =?utf-8?B?K3ZOaGpzYjBubDVSZlA1OW10WGlFYityOFdiQldCTnJ6dXViL3lBcUlrclRR?= =?utf-8?B?V0RFbStPa0VkVkFoNzJQUmtJZnkwR1prMHdBdDh6eEN0VjRqSGlDdHhLYTd3?= =?utf-8?B?cSt4R1lrTEFMQ2VqdW8yLzA5YmhOTU9VdVFrc1B4M2hCcDNOVUxHQjhsNFpa?= =?utf-8?B?R011NFBDQndJTUJkQU43MGI5KzVDc29YTjBKQnhub281NzN5b0ZmOGErVmhE?= =?utf-8?B?VHB3VmZNeUt0eC80a2xKT3hKWFNiMHZzUEw4d3E4d2dSaStDVnF5ZTloS2tS?= =?utf-8?B?czFId2o5OHdHdHV0Z3FMUU52aEZ6cWc5elAyMm1FbjhsWEZZL1BlQUJyUHli?= =?utf-8?B?M203dVRzWVA3d3VtVWdQOGphb21wOUowS2FGazI2QVBueHpCS2FrZUxsQjI5?= =?utf-8?B?clRhTUtVa05qQjF3b2JVQUlCajMyYUZVNHVPK2xEdTJhNVVPMzl1OWlacWls?= =?utf-8?B?Vk91czFVbVZPbDlTWVpHTGIwT3JCamkxS1VXV1pjd04vWXIrUTBUSDJxMzJj?= =?utf-8?B?OWpDc1VzMXZUbFp2b04vZjI3Y1N2V1pKTGcxdWJWODc1Sjc0YVRBSE5zK0xV?= =?utf-8?Q?Sg1q7lm+AWSW8kPzgbr2ICRCz?= Content-Type: text/plain; charset="utf-8" Content-ID: <21CEFE25A3B44F4DAF943CB3CDA5F338@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DmqWWAH3oqyIAz3jjTmp6ZRoq8RbEOOYUhLwdBOKVr98RyNIOZFR1+nZtDyTxrbeFEmqA2115rJ47OGa3Uu/AEpsAqg+r8WluSJM7rVA1fppHj+fWt1+Piz7quYqH6rMPem5wyCc/9viweD73VUx2C49wFhW7KP8MIzGl+dLuDm/YhZ/LP2jkxf0KdOnqICAc4jqv/aYO04RQ6+4TGLzskFU751Eg80W7GcSVHIkaBq0ADQwdswL1kEuqGnmlAXzu0NkyttOo2vtra0Q7Qdg281CS5Vo1SKXer25olh18N84Q+SgGp5Mt1TZuIwYiYx5TgfFoHOIUqf9OpLHXMwLYHOetc+vLGyZ9PP0kZRNnzGLMg9lrU/1DNKYW18I+UIX2vxazOB/G6RNWey+8ljwtIRQ/L2oAhiBMysX9oIsaOPwEqLoneISS+K6YpngM5DoEwv4e+6zaUGML5EEK+Fa+39qYjur9gEsc8T/5GRn2Rxil6EcIJojMQZerjDYTLy3Qne6ys/P2x/OUaXyfLSR0TI4vaz3uaMuPZdaHslrycRt9OTvSbO6CWipeIlH4pZ14u3CwRub2hvy0zD+JuV5w/3tVncok0RnJ0jjHv1wiBi/CB/jNHfVX6tWyk9pQSipjPIwODJhDuCj6hRkjQxH7f6MP/bhDViuBOqqk5oslwrjHmYidjzpz6+2kHD9jv03qFuQbyPEkkQfXQT6JSw67HGLgOF71DaOWt7zKuW6PfXWpX3zegoSWGgWZbDXhzdiSmF1YUV/kxiTNLT+kIm0gi6+JxFdLHXVOZWu/swA3k1+swbCNtiN2Qo15UimvbzY X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01e14e0d-6ba3-4b6d-6e40-08dacbae27b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2022 10:50:07.7049 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n6+npF7xMC0miNHJiprP4NIuPMFwDcvQp9GuTsQF24h882zPBizFG7bpjtaaluTdU3gAc2pCCW+fykQyTvoYDm32LjheuJuCaKPFFoDOhlA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5129 T24gMTkvMTEvMjAyMiAwMTo0NSwgSGVucnkgV2FuZyB3cm90ZToNCj4gSGkgQW50aG9ueSBhbmQg QW5kcmV3LA0KPg0KPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4+IEZyb206IEFudGhv bnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPg0KPj4gU3ViamVjdDogUmU6IFtQ QVRDSCBmb3ItNC4xN10gdG9vbHMvbGlieGw6IENvcnJlY3QgZXJyb3IgbWVzc2FnZSB1bml0cyBp bg0KPj4gbGlieGxfX2RvbWFpbl9zZXRfcGFnaW5nX21lbXBvb2xfc2l6ZSgpDQo+Pg0KPj4gT24g RnJpLCBOb3YgMTgsIDIwMjIgYXQgMDU6MDI6MTNQTSArMDAwMCwgQW5kcmV3IENvb3BlciB3cm90 ZToNCj4+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9kb20uYyBiL3Rvb2xz L2xpYnMvbGlnaHQvbGlieGxfZG9tLmMNCj4+PiBpbmRleCBiNTliYmUwMGJiMzAuLjY4YWQ5NzYz YjZiYSAxMDA2NDQNCj4+PiAtLS0gYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2RvbS5jDQo+Pj4g KysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9kb20uYw0KPj4+IEBAIC0xNDU5LDcgKzE0NTks OCBAQCBpbnQgbGlieGxfX2RvbWFpbl9zZXRfcGFnaW5nX21lbXBvb2xfc2l6ZSgNCj4+PiAgICAg IGludCByID0geGNfc2V0X3BhZ2luZ19tZW1wb29sX3NpemUoQ1RYLT54Y2gsIGRvbWlkLCBzaGFk b3dfbWVtKTsNCj4+PiAgICAgIGlmIChyKSB7DQo+Pj4gICAgICAgICAgTE9HRUQoRVJST1IsIGRv bWlkLA0KPj4+IC0gICAgICAgICAgICAgICJGYWlsZWQgdG8gc2V0IHBhZ2luZyBtZW1wb29sIHNp emUgdG8gJSJQUkl1NjQia0IiLA0KPj4gc2hhZG93X21lbSk7DQo+Pj4gKyAgICAgICAgICAgICAg IkZhaWxlZCB0byBzZXQgcGFnaW5nIG1lbXBvb2wgc2l6ZSB0byAlbHVrQiIsDQo+Pj4gKyAgICAg ICAgICAgICAgZF9jb25maWctPmJfaW5mby5zaGFkb3dfbWVta2IpOw0KPj4gVW5sZXNzIEkgbWlz cyByZWFkLCBgc2hhZG93X21lbWtiYCBpcyBhbHNvICJ1aW50NjRfdCIsIHNvIEknbSBwcmV0dHkN Cj4+IHN1cmUgdGhlIGZvcm1hdCBkb2Vzbid0IG5lZWQgdG8gYmUgY2hhbmdlZCwgYW5kIHdlIHNo b3VsZCBrZWVwIHVzaW5nDQo+PiBQUkl1NjQuDQo+IEkgZGlkIGEgZ3JlcCBpbiBjdXJyZW50IGNv ZGUsIGFuZDoNCj4gSW4gbGlicy9saWdodC9saWJ4bF90eXBlcy5pZGwsICJzaGFkb3dfbWVta2Ii IGlzIGRlZmluZWQgYXMgTWVtS0IsIHdoaWNoDQo+IGlzIE1lbUtCID0gVUludCg2NCwgaW5pdF92 YWwgPSAiTElCWExfTUVNS0JfREVGQVVMVCIsIGpzb25fZ2VuX2ZuID0gImxpYnhsX191aW50NjRf Z2VuX2pzb24iKQ0KPiBzbyB5ZXMgaXQgaXMgNjRiaXQgaW5kZWVkLiBVc2luZyBQUkl1NjQgc2Vl bXMgY29ycmVjdC4NCg0KSXQgaGlnaGxpZ2h0cyB0aGF0IHRoZXJlJ3MgeWV0IGFub3RoZXIgb3Zl cmZsb3cgYnVnLCBwcmUtZXhpc3RpbmcgZnJvbQ0KdGhlIG9sZCBpbXBsZW1lbnRhdGlvbi4NCg0K fkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Mon Nov 21 10:54:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 10:54:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446507.702110 (Exim 4.92) (envelope-from ) id 1ox4RG-0005fv-Fn; Mon, 21 Nov 2022 10:54:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446507.702110; Mon, 21 Nov 2022 10:54:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox4RG-0005fk-CQ; Mon, 21 Nov 2022 10:54:10 +0000 Received: by outflank-mailman (input) for mailman id 446507; Mon, 21 Nov 2022 10:54:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox4RE-0005fd-Uu for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 10:54:09 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d1009760-698a-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 11:54:06 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 05:54:04 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BN9PR03MB6204.namprd03.prod.outlook.com (2603:10b6:408:101::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Mon, 21 Nov 2022 10:54:01 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 10:54:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1009760-698a-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669028046; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=FRHsnaIg+6wT3rKzyFR1BgKLBJcUu9uYnF0YbcQXc3s=; b=ABjHg7SMwvlBbM/KIU2GDWLWObfb2zFzP4AH/uWyE8M1Sfi3O17vMCcE 6Ot3dWKeZhKRuM5yorivvw9CFVeU0yvo33yEAQ6AqkzL0ialfOf+C4JzQ gqgCL3fSocB2yAdDitwH3G3B77D7g/LUU0Lo5gfjex8AgygfY3p+d7tqM Y=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 87780530 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:DPVSj6rs+TpoMyVf125QmISBBbheBmItZBIvgKrLsJaIsI4StFCzt garIBmAM/aPYDShKdB2Yd628h5VuZeBndFkG1Fkry5jHypD85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzSBNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAC5QUT+f3+Pp+rycTvVxvZoNPfvSFYxK7xmMzRmBZRonabbqZvyToPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYSEEjCJbZw9ckKwv GXJ8n6/GhgHHNee1SCE4jSngeqncSbTCN1NROXlraYCbFu76WA0KQwKBX2Ho+CrgF++VP9nM xBK9X97xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqC8p+EoDX0PjIaRUcabDIAZRsI5Z/kuo5bs/7UZtNqEarwhNulHzj1m mmOtHJn2eRVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5H2ADwmZX1VqBGwfQ== IronPort-HdrOrdr: A9a23:Y7dzSK+ze4+4LC4MUvJuk+G4dr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpixBiSgSiu4LvaFQHd+hsFSTtAzZor7G CAymXCl++emsD+7iWZ+37Y7pxQltek4txfBPaUgsxQBiTwhh2ubIFBXaTHmDwuuumg5Hsjjd GJiRY9OMZY7W/XYwiO0FDQ8jil9Axrx27pyFeej3emicvlRAgiA84EoY5CaBPW52cpodk5ic twriqknqsSKSmFsDX25tDOWR0vvk2ooUA6mepWq3BES4MRZJJYsIRa1kJIF5UrGj789ekcYa BTJfCZwMwTXUKRbnjfsGUq6NuwXk4rFhPDeUQGstz96UkioFlJi28jgOAPlHYJ85wwD7Ne4f 7fD6hunLZSCucLcKNUHo46MIWKI12IZSiJHHOZIFzhGq1CEWnKsYTL7LI84/zvUIAUzaE1hI /KXDpjxCEPknrVeI2zNaBwg1PwqD3XZ0Wu9ige3ek0hlTEfsurDcXZI2pe1vdJoJ0kc7/msr iISdZr6sTYXBvT8LZyrnPDsqZpWAgjue0uy6IGsgG107X2A7yvkNDnW9DuA5eoOQoYewrEcw g+tX7IVYh90nw= X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="87780530" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X6WpdUAZIRGp7+T4lhroEE6Gyyy9weVMc0mYaevkUCFSTkNj92iZiYcfhjgB3Kt0h8OwPQhwCb6Tf35Wy/mTLbbOXXz7vnU8Bv7//UX0LOlQruEF1kh+bW1f7LWeK7LUgugQya5C9XiWZkke3iuiR1iC13+mYnaKO6qsfEtO7c3Yccs5Uqxw5x7UHsXKnf733H15C1BuKv9ItnINcdoN6wi02EWUO1NxRsETnYGbDM/po0MPoMzIJoR0kqHVQjk1IGbTiQ3rHTTFsyByAM6+V4HJhCOzch0h6WHKlsQ802p1OEPVDCKlXNrna1mMmcZ9HNjWpfkZ09pbEeSBbaUhWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uXPRE9/w0IxQsZlnqZBqfQmBsGGlHugRoDRt+bTKGTA=; b=MnRE207ElzERtrTYRtqclrSbVRswoQVl8C+9cV0okfVjRfULc+XgDznuAaDJDLf8faDQPB+CPOKDQypanAjn++26vpNncfyQsWs9KToNruyj8xBDxtIUMv5p2uQOZRRUVcZjN5Hpc5ZjeMgZTnXjpy1YBnnudFNbU5tJy8s+J0zOHRBRZQvKKb09rn8QlAu3B/SV2M/Qtv0e5arMzFuNTBXSfE+pRsNizU1zUIpf8XPJ+jcwRhpJuJ2iVUhIZuxnydfRhnVUlDBTVrtKsZp7A5huH3mLLDW1J+gV5Kp/rS1mVzDu+5mN8Fo2AQVnazHbK0gtpLZub7vQj7BhbTtI4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uXPRE9/w0IxQsZlnqZBqfQmBsGGlHugRoDRt+bTKGTA=; b=azeJvRbNPKnfTDLxHE072vJ+K849y1j1mItv1KZY58sdYDQxpbYyf/SJMMEoFIqKwov8YaWfPtu+PxNLlVGX5j+FBDB6QMf2jJQibcEqKiGWd0ewVNiF73rMJ4cptHwGdWQ8EPbntu0yDkZ3og1VYro5DXTM7qhd3jy0P03XUSI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 21 Nov 2022 11:53:56 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Paul Durrant Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Message-ID: References: <3add150d-ab4d-9147-005e-3f3160ec9667@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3add150d-ab4d-9147-005e-3f3160ec9667@suse.com> X-ClientProxiedBy: LO6P265CA0029.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::15) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6204:EE_ X-MS-Office365-Filtering-Correlation-Id: f5fb676d-e592-4912-0339-08dacbaeb2f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PL0Q3i7xhWfPjHrZ0I22uZksEmMsj+kAiyQLMF4e29zX9nsQIQzXp+6wlvMxkt2pSNxWofdSgIZ/tdw8vUPxYNEewlUym5Axs7CyrnwiYwsynYix7IOQEjFsmLmVTgFr/KbNGSop8dIh4jKt0MzbeCabhdi5cGmc7Ixd5qpK3f33jBcCmv+YjYN9C4emktaBENnaby7GefhlZL3yObzdtLJ2Zh7qQ+UkmU3WiJIxQPIrbSGeDIY4OEJbrod3kL+3a4UMiQyrq0kMsx/v1VxGs8k2YrS5WQ6jSI7hvr/7U6fM3+nhpFquonebn8fyBO8hSwLCRbVZwLcXJHdphJ9VzTf4d+Ov8O7ouPpmRYsWASaJlsj7u6QKDo+P0shmbhvOGGMdoNCNnafu2gz+Ad+VtETelsN4Oab5ciZm7JSVZ//dKN7EKEzeQGGPDQbvDKerrP8J4OMYi48YVCqqZcXF/v+WtFpNRJxGAt1a1u7mjM3pMOsGrtDQWU9TehqMIx7po6ofC+gBkCJTwo8qiCNy2q8MPranb7ku99HUVzSbfIKXNq5YRj+REpHSdT+Xdjdh3nvv10SezyouxEMvua5rla/DRV9S7ZMRcCrTLiVkvm78ognOZYiFWARamukiuH4JLiXWTPkAOFEv3m8Dmw/oHg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(39860400002)(366004)(136003)(346002)(396003)(376002)(451199015)(2906002)(66556008)(66946007)(53546011)(41300700001)(86362001)(85182001)(4326008)(6916009)(6506007)(38100700002)(54906003)(82960400001)(83380400001)(33716001)(8936002)(8676002)(186003)(5660300002)(66476007)(9686003)(26005)(6512007)(316002)(478600001)(6666004)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHFNR3JnODNSWkQ4T1Y1aVhrbnNlVjFLMkxKSi9CZ0VjL2NLVTRIcjFLN01o?= =?utf-8?B?VVdoS1kybnYwczNacXMvcldKN2tLc1VaMGpNWXhMTXZwVFBtbFFhOUZoK1pR?= =?utf-8?B?RG9HeUsyUy9UQ01QV01Da2FwaHovVG16OEhJTldhNk5hbEFOVHN1WElFZDBM?= =?utf-8?B?dG5YNlBFS1Vtd3lWdzRQYWZxdktnTjR5aktQbkVxZXBGN2RvbXcwbWhOdUM1?= =?utf-8?B?MWwzeDM3NzhCbEg1bTRuVldKSGR2ZDYvZ2xPS1ZwbFVCUHZWSGtPY3Vuc0hm?= =?utf-8?B?RWxub2NYcTZiYUtPbmJpQnErQlJEM2lReFB3NWV3SjZsS2hGR1I1cGhYMXZn?= =?utf-8?B?WDdiZklUdEhCMmp6YkxrUkc0OFJLMTVLMGVkaGVweWY1R3hybjkvdEFoV1J5?= =?utf-8?B?SGJXbnlKcWg3Z3N6dE11anBTTzFJSHkvYldybHFVZ3dJTTlOaFdHUys5YkZq?= =?utf-8?B?WkQvS21Zc1hXMUMwU1M0Zjl5T3FtTzFrQUluOU4wbi9JNHdmSy9wdFVGcjBt?= =?utf-8?B?OVJQWmRudVhmQ3JuUmlZUEs1Y0I5bElBVU5iQkhzNmJjQ29OZXpEK0VMbUhs?= =?utf-8?B?WXVxSkVDRFA4STlzZVhvQ1NaWGFYcHdyaFFyOHpaSzZJU3N3UTh1TTJBajBO?= =?utf-8?B?a0VBMGRWbnRhRFpMWk9iQ1FDNXdVNkhkNENFRW16Nm5LMGkwM1BuZVp3bCtk?= =?utf-8?B?bFZKYnRVRWdZMm5HUkVuZnNqVktMRGFiUzMrU0JvUXRQTjZLNy9UeGQ0RzVT?= =?utf-8?B?UE1LVXJMMWhtMSswMGduRmFWQ2g1SnlmeCs3cmJzQjN6TWRrdkhSdkZkWDM2?= =?utf-8?B?RXB5UVlnWExoNDcrb3lrVUlkVndHVUtBUGJRaUtHVVFJcTZCbHRaVE0xZWNY?= =?utf-8?B?TEhKSXQxcTdUVy9xcEhxd2dUNU1ubnYzWitHMlQ4cnN4cUJVenJ2M3dFNWNY?= =?utf-8?B?R0w2RGFIVVYzZHBYTmF5ZkRBeVVCRmt6WDRaT203YlhyMFJrQmU2R281dVpp?= =?utf-8?B?MWcvZVpYTDROTndYZ0Z5dTY4N043NW9iRG9kdk9RSG1ZNGhlZkFiR3JXRHVt?= =?utf-8?B?Rll6RExhTGplWmNaUW5LV2pXM1NsbHVBQld0T2hsK0VpRy96QUtCQVN0N2Zq?= =?utf-8?B?anBPbGxjZDFiV1pWeGtpb2dZTUs0a0RZYXZqZmR6UTQvQW5Ha3IxK3ZSN2ZZ?= =?utf-8?B?TGFhWmlTMWc3UXhDTGk1ZXpDOGlaKy9LcHM1NTQyR002bGFNamJsTENOUW9q?= =?utf-8?B?b0dPNGN4WXZQdXlpV1hkVUV2REZ5WHY5K3FCbDVXMUczZjVYVjVxZ09DVzFS?= =?utf-8?B?ek54Z0hzS3hZU29LZ2lyaTRRRHJKWnV6c1lBcW9RSEtpUXRXZ2E3SUFxTE9W?= =?utf-8?B?OWhZTUJ4T0dWT0pPWFJxMEV2YXZQZ0EraVYwOFNVUFczWnR6WnVnL1ZRQW1n?= =?utf-8?B?dlRnYTdqcG01aFdlalpJQmhVeFk0SHprUWZBY0pGQXZSWEVGbnBUeENoVzZz?= =?utf-8?B?SW15QnpFbzJMb3VjUThBaEFIa011K2Rla3MrQ2ZvMmQxMnNEeXhHMCtmMFFo?= =?utf-8?B?UjB5Y0VtU3RxaHFvWTBHYkd5eDh2WHRiYWNuZ3JXUzNERmFNM1BZTC9BNnhw?= =?utf-8?B?MHkxSXAybUZpTVdJRUltYmJaNG94MzVFaldDd3ZDWjZ3eVQ2QVovd05OVlBF?= =?utf-8?B?cU1vdGdyZGtvZUh2Vy8zQ1dsaFhmTnQzTk1HL2M0WGlicHViam9GUkVaR0Fw?= =?utf-8?B?cjJseEdETzB1SXhKVlhGQzlPbkpQUDFCQW40YUcwZlR6YkpiMU1NMnRhUG9F?= =?utf-8?B?VXhZUmtzeHM3WFJjTnBQYmpENDBKdFRvaFQ4cVArNFozTGFBYVFJRTg1RWFY?= =?utf-8?B?blg3ME9wTDZvSEJsNVJac0RhOEw4NmpYTlY4V3lKY3RjdmR5eEZuMkdUZk1y?= =?utf-8?B?aGNBbGhrYVJMSzc1d2R4eEVlQjF3ZUZUWGFIcEV0RDNFTkNZY3BDZ0ZyZExE?= =?utf-8?B?Z1ZvcUtsRmZaQ2RmZWoydEY1RkZrdTJ5eVZrbTc5aGkwYTdwemx5NENJSVpl?= =?utf-8?B?Z29TYlhTZlJJaHhvbE9hTVU0MThwMEtVL05JNCtFL2JheFdzZ1BpVGhqWlJI?= =?utf-8?Q?JH3Gg8mwrkn6pMS2+Hg9c3etQ?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: m0LbAa7i5K636D7bYdNsXqFOywKo5jlVAirWvo1xS4wEIKOdLKjdEGly1IOIKAO3CGfChcHi2GqyFX2uDOi9xK0zTFGcIOXy3F/5D2ZEW8IgYInZ9/69pI+tHYsy8fwPORGr45HCwgx+grSbLzQox5+U6RtOiWBAAKjCKbv5qEYbNIl0MQ2DoWool4sWKwfGpHT5NMFNmuKak6+G5lq1IUBQ3JBfIOM0v5jXOszrmJztne1LzTpZEdIo+Zg2szE3VH0przWvW10S1JC7JIqMKlljaBCEz+oOFshVP4f1wKoGNBHF1iW2X7UXnPl086WWPf/mG3uFm2+UGZ0MAHXy5cx+4Hyw1tNx4WPAYkId+JDnvtrIuNmo7dZ05TZ1K/hHJRf+8/U9kJKWdTjS5ID5swUUOb0xaULJmlHPyk7726fI+4uk5iAtQgIi8R16+QSK+3xgORsMVppRGufUlOkMkElaPMuIyUfiLVeAK+ebT98b/mtDrHnRtEUAX0ZlIXZSww6CWKl/1gWmgpMtsWRyHtcznigzhjqumdGzEF1ZUWF1yxy0Z0VtZSCJN7knxiMzPblVzIqeJ4UqvfHExAeaFq2ymkOUnPiEe2ruLWznZtJ+Lw4UtJPGC8wmOZyCmc32+FGPPEJoxtFJjCzXcNg+dQUwAsdHjdhQlFYxlP31tPitu6SAh/xFLS7clbFGnYh6+XzVH/V0XLOiN8KcBHKexPyxRvvN7KFGlpZVI5azKK7F3J7fd7KRy/OSiUQOxRB2cTPDBwkv4oGlt1jiyJ2FzlE5MwWAWnQFXl9zWSj+74RsyBbNDYtYszd7avYAJ824qY5JFP0SVO75JuyJTazAY+MZwzer2J6br0kaIAXjtFM= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5fb676d-e592-4912-0339-08dacbaeb2f5 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 10:54:01.6776 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xSo16z09zSaO55tUhVVJBTqZNT/VDfpQ/rY9Gc8fe/Or2YwQYRBtIgz72dqA7cPsPEEvF85hG55d2uk+CR2YLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6204 On Mon, Nov 21, 2022 at 09:33:53AM +0100, Jan Beulich wrote: > On 18.11.2022 15:26, Roger Pau Monné wrote: > > On Fri, Nov 18, 2022 at 11:31:28AM +0100, Jan Beulich wrote: > >> Linux'es relatively new use of HVMOP_set_evtchn_upcall_vector has > >> exposed a problem with the marking of the respective vector as > >> pending: For quite some time Linux has been checking whether any stale > >> ISR or IRR bits would still be set while preparing the LAPIC for use. > >> This check is now triggering on the upcall vector, as the registration, > >> at least for APs, happens before the LAPIC is actually enabled. > >> > >> In software-disabled state an LAPIC would not accept any interrupt > >> requests and hence no IRR bit would newly become set while in this > >> state. As a result it is also wrong for us to mark the upcall vector as > >> having a pending request when the vLAPIC is in this state. > >> > >> To compensate for the "enabled" check added to the assertion logic, add > >> logic to (conditionally) mark the upcall vector as having a request > >> pending at the time the LAPIC is being software-enabled by the guest. > >> > >> Fixes: 7b5b8ca7dffd ("x86/upcall: inject a spurious event after setting upcall vector") > >> Signed-off-by: Jan Beulich > >> --- > >> Don't one or both of the Viridian uses of vlapic_set_irq() need similar > >> guarding? > >> > >> Is it actually necessary for hvmop_set_evtchn_upcall_vector() and > >> hvm_set_callback_via() to call hvm_assert_evtchn_irq() when > >> evtchn_upcall_pending is false? > >> > >> --- a/xen/arch/x86/hvm/irq.c > >> +++ b/xen/arch/x86/hvm/irq.c > >> @@ -321,9 +321,10 @@ void hvm_assert_evtchn_irq(struct vcpu * > >> > >> if ( v->arch.hvm.evtchn_upcall_vector != 0 ) > >> { > >> - uint8_t vector = v->arch.hvm.evtchn_upcall_vector; > >> + struct vlapic *vlapic = vcpu_vlapic(v); > >> > >> - vlapic_set_irq(vcpu_vlapic(v), vector, 0); > >> + if ( vlapic_enabled(vlapic) ) > >> + vlapic_set_irq(vlapic, v->arch.hvm.evtchn_upcall_vector, 0); > > > > Shouldn't the vlapic_enabled() check itself be in vlapic_set_irq()? We > > certainly don't want any vectors set until the vlapic is enabled, be > > it event channel upcalls or any other sources. > > In principle yes, and I did consider doing so, but for several callers > (potentially used frequently) this would be redundant with other > checking they do already (first and foremost callers using > vlapic_lowest_prio()). However, looking again I think vioapic_deliver() > and vmsi_deliver() violate this as well in their dest_Fixed handling. > (In both cases I'm actually inclined to also remove the odd *_inj_irq() > helper functions.) > > > Maybe best to add an ASSERT in vlapic_set_irq() to be sure the lapic is > > enabled, as other callers already check this before trying to inject? > > Perhaps, yes (once we've fixed paths where the check is presently > missing). Another option would be to unconditionally return 0 for IRR and ISR reads when the LAPIC is disabled, that would avoid having to force the event channel injection when the LAPIC is enabled, but there could be more than just the event channel vector queued in that way which would be against the spec. > > Also, and not strictly related to your change, isn't this possibly > > racy, as by the time you evaluate the return of vlapic_enabled() it is > > already stale, as there's no lock to protect it from changing? > > Wouldn't this simply match a signal arriving to a physical LAPIC just > the moment before it is enabled? Hm, yes, any guest trying to play this kind of games with the APIC is free to keep the pieces. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Nov 21 11:01:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 11:01:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446515.702121 (Exim 4.92) (envelope-from ) id 1ox4Yh-0007Fx-8W; Mon, 21 Nov 2022 11:01:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446515.702121; Mon, 21 Nov 2022 11:01:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox4Yh-0007Fq-5e; Mon, 21 Nov 2022 11:01:51 +0000 Received: by outflank-mailman (input) for mailman id 446515; Mon, 21 Nov 2022 11:01:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox4Yf-0007Fk-Mc for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 11:01:49 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70053.outbound.protection.outlook.com [40.107.7.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e43515d0-698b-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 12:01:47 +0100 (CET) Received: from FR2P281CA0109.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::8) by AM8PR08MB5810.eurprd08.prod.outlook.com (2603:10a6:20b:1d2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Mon, 21 Nov 2022 11:01:17 +0000 Received: from VI1EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:9c:cafe::65) by FR2P281CA0109.outlook.office365.com (2603:10a6:d10:9c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17 via Frontend Transport; Mon, 21 Nov 2022 11:01:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT026.mail.protection.outlook.com (100.127.144.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Mon, 21 Nov 2022 11:01:16 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Mon, 21 Nov 2022 11:01:16 +0000 Received: from c409788f01af.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B8A92DE8-5417-41E6-A037-AD65A5E3AD1D.1; Mon, 21 Nov 2022 11:01:11 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c409788f01af.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Nov 2022 11:01:11 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB3PR08MB8820.eurprd08.prod.outlook.com (2603:10a6:10:438::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Mon, 21 Nov 2022 11:01:10 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5857.013; Mon, 21 Nov 2022 11:01:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e43515d0-698b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ylLdoX3quGgGcnv6snER42N6P7jvPC1rDvaK2FEHeVs=; b=Q72Wluj1/iFOh48L2SOQF/4S6AOEuZLcve4qIpq2KMNVvRGhxM6zwZVMH/1dxGeYA0F/AT5EQaeQRHilxuoqS4LNQCmp0R0HD+NQruZnqd3Mhd1kDDxrpyHokx8ZL1kM/VUsw/DNohjujavP+28HPyMajoLso3QjSo5o9THcEDc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gIx1rZ5oFRYYjxbukV7Vl7//I7JC3aD200zA4XiBLg1/4tzpsvruR9TpjTUOgWeGKcIQHEpQLzzwt3guVj6026XVk+OoWLFJPM+zAwGGRzENryZqhDMafLuFl6ArM/lWM7+ozW4px1L8fXVpmDGX17c4NPxt3oZ3aWq23Fzo5xVVZb3U1OmJxwPwuxnCEqYpFS5+SFW/7Ly7izjPpymbTz+9znM3ZLcl2d/QUUxWZ2Z/1oygzgDtKBIDGIhXTzWSyhnX+bgnML10/2tOvehLe5bLXaYSMfQfkoCjmNI1XA3u5/6yAZ85MIX/1ODR34f6amwVUi3fhtxw1zrde01/mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ylLdoX3quGgGcnv6snER42N6P7jvPC1rDvaK2FEHeVs=; b=gX9L6baJSriEVTm7Y/4B4X4DFvTyg36i04ptgQAC8jwruG8501prjbL/NpHaBY/8SuEHqZkYr3oD8z8FBeLEi2bofWfBCoGa5p1peltkIsv3SwRIYIW2cYjAyvv1ED6gdI2BJQ/NhKX0BeFxrQjtKnPKlvnxBNTc8ixO6JKb6B/yNsmladselO7+DfRMKbhlGP1QBJrc9d9s+9CFM8jyS0SWFkBgq4eIFunSe/HZFLqarCGv+4cxv04MKGYKfrfw+bDjNliOsfxW6Owi8W9/AaWDPiAYKqdXXa5V7Fd+jNrcjv0/YIqueQVxVdK1OwrGLhnXssX3CkZxp+3zs5RS/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ylLdoX3quGgGcnv6snER42N6P7jvPC1rDvaK2FEHeVs=; b=Q72Wluj1/iFOh48L2SOQF/4S6AOEuZLcve4qIpq2KMNVvRGhxM6zwZVMH/1dxGeYA0F/AT5EQaeQRHilxuoqS4LNQCmp0R0HD+NQruZnqd3Mhd1kDDxrpyHokx8ZL1kM/VUsw/DNohjujavP+28HPyMajoLso3QjSo5o9THcEDc= From: Henry Wang To: Anthony PERARD , Andrew Cooper CC: Xen-devel Subject: RE: [PATCH for-4.17] tools/libxl: Correct error message units in libxl__domain_set_paging_mempool_size() Thread-Topic: [PATCH for-4.17] tools/libxl: Correct error message units in libxl__domain_set_paging_mempool_size() Thread-Index: AQHY+2+K+dbSE+6zIE6kpdVqzhxbFq5E7LKAgARNc2A= Date: Mon, 21 Nov 2022 11:01:09 +0000 Message-ID: References: <20221118170213.2872-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B1E32200F7237248A4F105170B110607.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB3PR08MB8820:EE_|VI1EUR03FT026:EE_|AM8PR08MB5810:EE_ X-MS-Office365-Filtering-Correlation-Id: 2cde8acc-652c-431f-f69a-08dacbafb681 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JFtbsKK6dtm/AyiN6RnXSbA0XEKLkfbTYBlGYa3k0YlzYCCS81hxYAx+U5f0v5g6C7VCFZDg7XgnK0UIKxFsl1EQA4Wz/jiuaxcOJ7vu/GN7qMQlI5LCvnJb/f0fFgEihDf5tiMc9mdbEVpRktJmNXN7/zFmVQSwPAancffGXEDR5ptPcFV3eVtDff5o/pgB+P9zjrS0FpkkWuJlOOotwVOKLbsLg0w7sMscauFu6qY5L/J1ffStbaXB+1UKMb2gstrE7SZJuFvbzNKhvzU+fr/73XzZX+jxTQJu4As9UzysShIkSrSCjFJoTeM7d+UpyHCFUJxlFHq0SbYNKDV/J00dUErLlccNjViZfiiZjP/GqxUkYQUB5QCtf4pj2PoSi4I7nbHsxeTr3VmpqtcQd/UDhkjpzS//1p84E4DiJ1IdGKVtoHuQr1oI2MPyg0cdJVqQRSHvp7a5vauCrMaeBmG5czOn0oQd/u5Pn+DiQzvSZfJhs4MmUsy6742Mj15Dn2fXk9UNSAO9JLO2lK+2wpvYsZHMFJ6JjHVhBc9IMNiA9g9ypuWpYVWNHk9ixGFfvOOM6MGlpsVK82XcpUmrXF85h1NI36MNsuqHXSanP6Y++zuFzhLEnzXes2Xwnumc8YUOPon0yyULvNoO0gS1cL8jC7/qvDsup4agxEm37lkaYQ51Pa5mpPLAINCzh3zfJcYDjSicnx5tE1Fga92Dtu5zOGyD/wFI7Yz16LXa9Jk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39850400004)(136003)(366004)(376002)(346002)(396003)(451199015)(71200400001)(38100700002)(55016003)(8676002)(15650500001)(83380400001)(186003)(110136005)(66446008)(4326008)(86362001)(38070700005)(52536014)(66556008)(478600001)(33656002)(76116006)(5660300002)(41300700001)(64756008)(122000001)(66476007)(66946007)(8936002)(26005)(2906002)(6506007)(316002)(7696005)(9686003)(101420200003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8820 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2cd3eaff-3d61-48b2-e51d-08dacbafb26a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gzYvucx7mP2VKDFbCLdDU6agnjn0NFGVq/6B9tcWOkw37iKk/kZIX5CdNaz7wZLksyP6qmfL/KAsNN+LTvfRUF0tfU8wcHUMHKqQ3cSz419nUK3xryf+a+Gpoc21TeDbTPYXMHOeEokNhMAD3R1pZQfHmbQHNfhr3WMY9xSIJ6jjbpUAOiKOYKFIfx9cYKPjOdfGf8n46qFKPfw8/yynbOsGC7G1oHB+yu+lVFWE2C9rPaF1wtj8b5mym/5UcjPo6rFkA4s433pYe9Q0Zjq5YVQQtgU8w2O4R6/hXjAPyMADQ+SMewaKARqtKenurSwQTGDvUPGJRgjs3IsqMmx4KWc0H+Sw7neFmUd58HeRnsfvcDjznatal9McJWTTggIjDABmAKnqzy6AU8gKcWDBB0TnoL3wPuamaaE0gDiwwiLvrDx4OkrGLVEx42DokYasX3rquVdmKnpFavYbrhrX0tgsd8wuhoBrOj/o7yPVYFizRV8DEDvkDDDtXm0mPig5BQL7EyHyiP5YUIwHjckVZSmvk0SPRo7+51PJViRdkmh+fx3aCqQ/JgjRCcruC/m09ehfe0YyznfPLnAaDzPg8qHshjNmGISuW++aP4PnlHFlR40T6F6x2d7WWxBvAfT8sLgQPEuwEh5Fzn65X01uTyJT6MbXmXeBzksjNyzNu5mCYrw3kNzJSrz+ePSfIkCfpA4tSlBUjuSyi3F9bv6qW2Xjw5jzu2v230lkb13GgPNlkJ+OUbBHXjsW026mu3Op X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199015)(40470700004)(36840700001)(46966006)(36860700001)(83380400001)(81166007)(86362001)(356005)(82740400003)(2906002)(8936002)(4326008)(15650500001)(110136005)(70586007)(70206006)(82310400005)(40460700003)(41300700001)(52536014)(5660300002)(55016003)(9686003)(7696005)(40480700001)(26005)(47076005)(186003)(6506007)(316002)(336012)(478600001)(8676002)(33656002)(101420200003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 11:01:16.6938 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2cde8acc-652c-431f-f69a-08dacbafb681 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5810 Hi Andrew, > -----Original Message----- > Subject: Re: [PATCH for-4.17] tools/libxl: Correct error message units in > libxl__domain_set_paging_mempool_size() >=20 > On Fri, Nov 18, 2022 at 05:02:13PM +0000, Andrew Cooper wrote: > > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.= c > > index b59bbe00bb30..68ad9763b6ba 100644 > > --- a/tools/libs/light/libxl_dom.c > > +++ b/tools/libs/light/libxl_dom.c > > @@ -1459,7 +1459,8 @@ int libxl__domain_set_paging_mempool_size( > > int r =3D xc_set_paging_mempool_size(CTX->xch, domid, shadow_mem); > > if (r) { > > LOGED(ERROR, domid, > > - "Failed to set paging mempool size to %"PRIu64"kB", > shadow_mem); > > + "Failed to set paging mempool size to %lukB", > > + d_config->b_info.shadow_memkb); >=20 > Unless I miss read, `shadow_memkb` is also "uint64_t", so I'm pretty > sure the format doesn't need to be changed, and we should keep using > PRIu64. >=20 > With that changed: Acked-by: Anthony PERARD Release-acked-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Mon Nov 21 11:10:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 11:10:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446523.702135 (Exim 4.92) (envelope-from ) id 1ox4go-0000JD-4C; Mon, 21 Nov 2022 11:10:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446523.702135; Mon, 21 Nov 2022 11:10:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox4go-0000J6-0H; Mon, 21 Nov 2022 11:10:14 +0000 Received: by outflank-mailman (input) for mailman id 446523; Mon, 21 Nov 2022 11:10:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox4gm-0000IA-MN; Mon, 21 Nov 2022 11:10:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox4gm-0003Fp-F6; Mon, 21 Nov 2022 11:10:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox4gm-0005aa-0B; Mon, 21 Nov 2022 11:10:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ox4gl-00080M-Vj; Mon, 21 Nov 2022 11:10:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8IOgZwRgRNNeeQ0FvMGzv+LX20L2VUOokNefP9SLlOs=; b=mJ+ClEewNb2UW5O6l7oF4SWo5Y IYUDN3toKw4LcoMB2Z8C8jJRNuEoGI4IcFZQL06BmClfSGa0a/YO+TfnOIt5J+OtlTxomV3ZX96tX AacREHarHdLM23HE5M4SKUhXAdXCII/X19kwy7YX9/QBhiDtznL8yE6brh92W+qAvNZ0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174874: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=db8fa01c61db0317a9ee947925226234c65d48e8 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Mon, 21 Nov 2022 11:10:11 +0000 flight 174874 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174874/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 174797 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail pass in 174865 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen db8fa01c61db0317a9ee947925226234c65d48e8 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 4 days Testing same since 174809 2022-11-18 00:06:55 Z 3 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit db8fa01c61db0317a9ee947925226234c65d48e8 Author: Andrew Cooper Date: Thu Oct 20 12:14:30 2022 +0100 xen/arm: Correct the p2m pool size calculations Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit bd87315a603bf25e869e6293f7db7b1024d67999 Author: Andrew Cooper Date: Thu Oct 20 12:13:46 2022 +0100 tools/tests: Unit test for paging mempool size Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit 22b20bd98c025e06525410e3ab3494d5e63489f7 Author: Andrew Cooper Date: Fri Oct 21 14:13:00 2022 +0100 xen: Introduce non-broken hypercalls for the paging mempool size The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 Author: Andrew Cooper Date: Mon Nov 14 21:47:59 2022 +0000 x86/hvm: Revert per-domain APIC acceleration support I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisted in due course. Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Fixes: 6b2b9b340509 ("x86: report Interrupt Controller Virtualization capabilities") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Mon Nov 21 11:14:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 11:14:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446536.702157 (Exim 4.92) (envelope-from ) id 1ox4lL-0001JZ-3F; Mon, 21 Nov 2022 11:14:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446536.702157; Mon, 21 Nov 2022 11:14:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox4lL-0001JS-0Y; Mon, 21 Nov 2022 11:14:55 +0000 Received: by outflank-mailman (input) for mailman id 446536; Mon, 21 Nov 2022 11:14:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox4lJ-00013r-GN for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 11:14:53 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0621.outbound.protection.outlook.com [2a01:111:f400:fe0c::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b804ac44-698d-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 12:14:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7858.eurprd04.prod.outlook.com (2603:10a6:20b:237::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 11:14:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 11:14:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b804ac44-698d-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MXubM4kpG2yWFsCnZKUYZ7mNVWjtZXY9wE3/mxW47cKKGuNy7wfgb7eGNIWgmbDLuFvOkLMMR/WMna1zz1N5xh08jB8Oxf9jjxQFSNzh89LYljvxJxOeHoFgMhqz9dZyWD7CWe3GBnUHpTI9fE2s8rtq2nSuBj1aaBeOaGb3hjun3clSBtJcqTWQTwv9g1RWAG6bQdE2xGyWOhAzThC3HLJL1oewrsb7dC6KrWG6uzOPtNNYyMbhxDYXUtejdm/3mdMJH52u88H0uBPPmagCAiRXPWlt3qDqDIZ+MfHwTQwjMeAIFucfkITLQWQBO0hwR4D7dOd+rrWM4VRHjCiQPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uu95olh0a1stZdTCzdFwRikBa491MDOhLph4j6+HwDA=; b=hm1ELtZAvDCq3YEMdihPyOLgSmQ7oFZPxZjybXBo3okwXT0XFBPoXf387HqdIBoYzUKJC1tp8NM/moVFrMOftjoYlLpJPD3MoH8dswsPPm3B/HEWdmNtcdyWH8JRssQpBkB8y4aQK0EJC5yYKUBPGSHb9BR0aVuMC49kOxw6GDl8a6X0IsKu+aEkoQeKLbaEBB5t73q1W+KiGa94xGZpj1WAKTe/OttBT37KQbPJ64GqYxBgT5loVTfjUaln5K2i8OertoTBIuU4VaR78PzP2PMxooQWkVTB2HTa1vDi7w8Oe8PVzJ+TcJLRXMawWQXmVASMExb4HOTZPq1rsT4o6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uu95olh0a1stZdTCzdFwRikBa491MDOhLph4j6+HwDA=; b=algksr0O3NJZJywgiGElU0Kiba9b6UnKywXXhIVa2hDhe8Frx9LdQhINilCmlacZg8t0y+x94OA2CqdRpECieubV4qJFaPaZ447raDiTH7qNq2oyXV8OTqCeJWIehLrYdTt+G1jPGBOzEgwQd/adCfvC8IxDyHgnMTMME/MX/jii5CLocpSCVxLIs/YRu7k+MdSHO2Iwp9XA1b5GHjgdP3GQpMfeOCwAukiJg9h/HuN37K4hmNraMPJiFPKBN/+2Q5EdxYJMb+8EkQPwEOfmC5V+h4j7aISLU7IT4q3IU3bG8bLlis1xvQ4M0Ws031KsPWQ06ZfkFHQRG2cz9gVvxw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 21 Nov 2022 12:14:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Paul Durrant References: <3add150d-ab4d-9147-005e-3f3160ec9667@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0072.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7858:EE_ X-MS-Office365-Filtering-Correlation-Id: 3dbe5277-86fb-43c2-5c39-08dacbb19af8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 555UDND9o7DOM9gWBSjnP45XSN5hTNB/EtAc4IFQlZtIbJfeRq+GKFqaQICvugOeVtQPb+GHQpSwdVQUnRnshzscO0BhCrPaOFtLr5A/ixuHnTQjHjyuuGDqxHwlGZ2Y7UiA6TxW3tBFtQe/zFA/n37vdlhonfk0uUEE5YB/gTutyt+Jir8MZmJhWOKIBkTRFuDnIN4mrsq7+2xoGilh2WVjB7zWA88/fb+HjUenkyy2rlEHxLmHma42cOrbUutoMGm4BBYsIFaFrSDEumJNHNfhy3xd+ZGraWLBqCn7cfW95s27a5Vq9ZyxncqTQorHFM6PaBq4IxsxYIyHrcs6dSTfADTbVbn25stf+73g2yHO9Dl1anIPlc20CltKgN4nSulo0X3Bm8TF9BoX6V0dGdHECzoyPvykdJ9+sTEHXEGXKBTfo4h1VNNlCmBeaOdScG1yypq7JQa5+VZHLb5SIqDIMWwBcAUrwOTV8FT+mNgbYgwPPXMlN+YV+Co1pL0Owucu98Pi86LzPQhSwkUMsvcrMPslmUurWrvbpVOUXuKkVsiqDCxUU+reVSP7/6HuUAI6bpy6HF5HlhAYjw+9dvmFcbJx7oy2GIbC28pRV6NbYmEqOz4d1ggr4Gxm6dRpyiW4yxPwHwNmYwE4PutqKmH9qUGR6yWK3fP1ni/Nb18Wny0kwNOfyrnLvoZLm1oxtSFDG+Tp2QU4EtrzjNTi87ogQQ/RFZCp2poMTFTayIo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199015)(86362001)(83380400001)(31696002)(38100700002)(41300700001)(4744005)(2906002)(8936002)(5660300002)(478600001)(6666004)(53546011)(2616005)(6506007)(26005)(8676002)(4326008)(66556008)(66476007)(66946007)(316002)(6486002)(6512007)(54906003)(186003)(6916009)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTlKMndHY053UmlEellhREpBempMc2lJeWZQRHlNcmhxM3lvZHZvTmRhbUtX?= =?utf-8?B?ZjlQeEV3ZkpIc2xhRTJTSkY4L1cxazZ6UzBGTENFK1JDYkxUeUhZaDcwZmQy?= =?utf-8?B?SThtRFVTc3dad3k1UmdxTDdVZ0NXUlBJeFJEcUc0Y2taYTkrY2x1M3U1SzdH?= =?utf-8?B?R0ovZzRsdllpSlgrU1NMc3RwQ3A4TFhMczhzbjJZZGFYT2JMR3BLV2JpRDJ3?= =?utf-8?B?RlIyV05wVmxqY2NQVkIrM0EwZDB6VTRsR2k3M3JNNVdOWjN2YzNnZmg2SnZS?= =?utf-8?B?V29VbzJ6S0JYbklBQ3N1Z2wxaXpZVEpnM1I4cG13V3orNTN4bnRXQjhoeVlW?= =?utf-8?B?OXFxTVJrcU02NG9laXEwRW4vWmJqZ3JvWHZGdXNpclgwVFM5RmlUZEVTNktK?= =?utf-8?B?clhEL2duWUs5S1pkWkNqMzlScXJzVS90L0JDamZQVHFKSjZmYXRWbE9CajJC?= =?utf-8?B?WkRtZTIvQUpvUy9oZmdObVRpeU1VVG9jNjZqRUxBRzZMckdpUnlQY2dsSk83?= =?utf-8?B?SkdrWGgzaTJwbnByK3BIVTNXR01MbHVTVzJnYWg0Q2pobEVsTHp0MERyc0V1?= =?utf-8?B?ZUFGTStPdDdQUEZTMEtaQjMzbWdMK05jT1ZGSVdybVhrVGRPb2NWcXdkREVF?= =?utf-8?B?RzJUZmozd1FuSEFMOUtBbHpTWlpSWG56emZHMUdRUTBKU0xJclBDQXdLTTQx?= =?utf-8?B?Y2hmWkNjWXlwSnBXT0g4ak00Wk9JTWdFTFZxcGtZVnZPazN6elBDb3NKMnJE?= =?utf-8?B?cHRqbmF3alUvUkQvTHhlOVAySHd6ZlYzZTRUOW9rM0VabFNSdS9yMjFxRzJN?= =?utf-8?B?V1hGS0tUNEhkZU8zZGxIcFJCZWpRT3FTM2hUNW92QWJwZVB1eU5NMWZYSXZS?= =?utf-8?B?ckNYTVY1K0haaE1IbTRRaG5Ba2JHVFVwdXhNbUlvL1pBeDRvOHE1YnlEREdw?= =?utf-8?B?dUZONGdhTmM1eCttOXR1MW4wNUd6QUE2M2oyOWdvWDVlNk4zSGFXTEdpN3pU?= =?utf-8?B?a3U3ai9hY2hyZGRUT1hiZ1ZuenZEUXFDbTFZWlAzYzMyWDZzMHZKQ0liUFE3?= =?utf-8?B?TmRNYzJBVUo4Nk5NcjhycUFTM1pzdGFCN3hwSlJ0VUdYbkV4eTJJSmQwcEIv?= =?utf-8?B?UXdOL1FSWmtmd2dnaXhNN0k5WlVqeVJscU51ZklzWnBGS3ZlMkRYUVlvOU1k?= =?utf-8?B?SXNKdjJMOEIxVE5jUWFBa1p0T1E5THdrTTBqNTlIczZ0c29PRlozQXM1bThR?= =?utf-8?B?OTlpMHNndVdVUFFtS0RQdm1QSTVqd1JlUTRIM1FoSU1vcVh1TXZKazNveWdj?= =?utf-8?B?UDJ5L3puaHZnNUtwYmZlaTlQZHVoS2MyeDZUZVNtU2lpS29GQzBBeHM3K2hC?= =?utf-8?B?b2N0Y0oyYXBXSXFYVW5EVEh1ZGZHU0pDVWNac0FGK3NPZVV5VDI5R0lOWU5D?= =?utf-8?B?KzIzTEZDREJFVmdlMzhlend0Ulp4d1pRTldybS9YYm1NZlErKyt6emVIcVpN?= =?utf-8?B?RVZZLzRLOEh0bDVBLzhXY2diWUJiQTlhWE1HbHdXN3NlWHduMG9mbmVCNmFE?= =?utf-8?B?S0dwdEV3U0xUR1BGcm53N1lXRlo2d3NEZFdjcnZKS21wTDBnNkx4amdiSVpJ?= =?utf-8?B?K1dYYTh5UGN0Qk1JS2VIV21MVldSVFFxZDVtUWQ1dzVoT3BIZTdWaDBwU2NV?= =?utf-8?B?OThFZEFnZmtma1BBZndsUS93K0NhM1VMbXk3VENJMGJxL1VqYk1JLzFyVVpZ?= =?utf-8?B?WWdQS0V6bFhVMUh1SUpoYjZQVTczQURPSnZ6d1M3Vm1IdXBWNVlNbS85eHQv?= =?utf-8?B?NG9tS1BDV3QreVAvV0lRRmtqTGQ1YzlWZlg0ZVBka0xFQnBKYjhGeXZxczJT?= =?utf-8?B?anp1dDJ6dmJwYzFHTXY5aTRFcmxobmtPVFdsMUI5ZzBNQzU2RythbFVDZ0la?= =?utf-8?B?OGJZYlVqaGFsTytublpibVY1UTYxOTFRaktsU3Uzc1JkNkpreEJld2NnUlQ1?= =?utf-8?B?MG5WWW9WU01NYmg2WXhxckJBczFNdmpWZkFMM2x3QnM5dFBTUEcvemUySWRG?= =?utf-8?B?Wloxa3Q4NzFPL2VRc3pKdFJLR3doVmxYVVh4NXBhbzQ3ZWdWbm0rSkRHdUJv?= =?utf-8?Q?6fe6VP2udT/Gd/2BY7bysoxrx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3dbe5277-86fb-43c2-5c39-08dacbb19af8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 11:14:49.6745 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2bEG9eJDEIiDj3aHx1xEUDVBdrK524tMx+90lHnxkmHRgXUsOB8s7evvnD3Z5xXQSJ610tNogY/KHtpdGUE5vw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7858 On 21.11.2022 11:53, Roger Pau Monné wrote: > On Mon, Nov 21, 2022 at 09:33:53AM +0100, Jan Beulich wrote: >> On 18.11.2022 15:26, Roger Pau Monné wrote: >>> Maybe best to add an ASSERT in vlapic_set_irq() to be sure the lapic is >>> enabled, as other callers already check this before trying to inject? >> >> Perhaps, yes (once we've fixed paths where the check is presently >> missing). > > Another option would be to unconditionally return 0 for IRR and ISR > reads when the LAPIC is disabled, that would avoid having to force the > event channel injection when the LAPIC is enabled, but there could be > more than just the event channel vector queued in that way which would > be against the spec. Pre-existing set IRR bits remain set when moving into disabled mode. If we faked zeros for reads, we'd violate the spec and undermine Linux'es checking of the bits. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 21 11:14:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 11:14:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446535.702146 (Exim 4.92) (envelope-from ) id 1ox4lI-000144-R6; Mon, 21 Nov 2022 11:14:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446535.702146; Mon, 21 Nov 2022 11:14:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox4lI-00013x-OI; Mon, 21 Nov 2022 11:14:52 +0000 Received: by outflank-mailman (input) for mailman id 446535; Mon, 21 Nov 2022 11:14:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox4lH-00013r-VF for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 11:14:51 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2060b.outbound.protection.outlook.com [2a01:111:f400:fe1a::60b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b67345da-698d-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 12:14:49 +0100 (CET) Received: from AS8PR04CA0193.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::18) by DB9PR08MB6425.eurprd08.prod.outlook.com (2603:10a6:10:261::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Mon, 21 Nov 2022 11:14:41 +0000 Received: from VI1EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f3:cafe::14) by AS8PR04CA0193.outlook.office365.com (2603:10a6:20b:2f3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Mon, 21 Nov 2022 11:14:41 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT060.mail.protection.outlook.com (100.127.144.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Mon, 21 Nov 2022 11:14:40 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Mon, 21 Nov 2022 11:14:40 +0000 Received: from ee2e8895edc2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C8DDF3B3-A6B3-4D73-8FCA-56768C95823F.1; Mon, 21 Nov 2022 11:14:34 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ee2e8895edc2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Nov 2022 11:14:34 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB9586.eurprd08.prod.outlook.com (2603:10a6:10:454::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Mon, 21 Nov 2022 11:14:32 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5857.013; Mon, 21 Nov 2022 11:14:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b67345da-698d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fr8Jxdu00rHfsJfBUD0rCF1ad1sc/8lJ/F5h0Q/2xlc=; b=KSyzB8+rbZUACHWdSi8RaxYe6cNln+kogIHj5tRik5PMHxwzyHa/XQats+JBY+4NMQGbumpJLn4f4UrL7VM/Lug/qAOYsWFgtxHTMZlm3fN/NsJNBMfmj0RDlxXMEj5sU9OPaQmig5mGaWHzeUFEUXM+GhpV/ojVdAJk+Cek1Lk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MaNmNM+jDSCrluv0Cl8aveTtGwI/V3d6wVJ8KWkgg0KRuhvMBfSuor+hKtPYwdB3e6X23tlhtizODnDmag3iSY2bh2i1GtzN5RI9gwZAkknAtfxs5NGiP/Lt11Wr32u61A4hdkRVG7APdkhNTVuYZGhCGBxXZ2WlkieeuZ60TOWEcwBezSu5J1v6RITAI4IoIa4Xr+QYTwcQLbg3tsMxc19KHk3cPXs15C5fcrAkFOhwnFXiI5G+g/5P0gcWtfghyUJIMGoO6E94Dx8GR1TUZ4o7+HIjXlwq9eAMr6+M5oRzCt8knOcL4uFGye7iAMbnTdtuhOcjBzVEwT/ESrJkeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fr8Jxdu00rHfsJfBUD0rCF1ad1sc/8lJ/F5h0Q/2xlc=; b=mxyu3mFbxSCFEINXby86CntXI0uxYGxz+joWJnKPBPkxTVAT/uHZtcCdzj+nZqXThLVzelnAYAuESwLZvkCwCOV2wyoDMvf5UhP1D8gS6Pt+fAmM4sXyJFMi647h9/2t+rxcd31vKp9ZzxhsZTvwVAYpVdaoWWfwlvdh2s8iuUVi71f5t31uhHyBUUpVXmEeneeyBoLICbIVxTxFkfPwTMS/NOR6CV5Ru85uvTnCOR1Bc7RZxNKTG/M1+JHntp60j2PR4NIjtWt+boxB7ywJIipWW9xU54qUBKQ1b3v2dmsSOo793I6mtf9JAYQeWom20iiFCPsvYThMQEgBt9cymg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fr8Jxdu00rHfsJfBUD0rCF1ad1sc/8lJ/F5h0Q/2xlc=; b=KSyzB8+rbZUACHWdSi8RaxYe6cNln+kogIHj5tRik5PMHxwzyHa/XQats+JBY+4NMQGbumpJLn4f4UrL7VM/Lug/qAOYsWFgtxHTMZlm3fN/NsJNBMfmj0RDlxXMEj5sU9OPaQmig5mGaWHzeUFEUXM+GhpV/ojVdAJk+Cek1Lk= From: Henry Wang To: Jan Beulich , Roger Pau Monne CC: Andrew Cooper , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2] efifb: ignore frame buffer with invalid configuration Thread-Topic: [PATCH v2] efifb: ignore frame buffer with invalid configuration Thread-Index: AQHY+1fO1GnKKHbNPku6hX+/5ZUkBa5JDEEAgAAxRhA= Date: Mon, 21 Nov 2022 11:14:32 +0000 Message-ID: References: <20221118141132.26242-1-roger.pau@citrix.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D5B19C168787A34F9D9EA693F73114D3.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB9PR08MB9586:EE_|VI1EUR03FT060:EE_|DB9PR08MB6425:EE_ X-MS-Office365-Filtering-Correlation-Id: d67a91c0-4896-468b-f1a1-08dacbb195c4 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: EcLU1Vmvyj0wFfgbhlHim1m295poZzfNFoQVkOiTmvi/QRGq1T/2OVDwPJEYMy7qW8vvRpC4Devvfw3EMWdJFFPb0lk+trIOCLKV5/4fr5bF95G+vq1H93n94JtQv5n17PkxhanUUR+R+9w6LTkyYO+ih9ZMJtJhd6b0xtSA/ReRV/8sPCCKUNMmWDeyLCeD+TBQS+rXCqAqGO5paFN1+pKqEpgaZ0sAgWkIfKRrQjjp1M+YKsYQouMspzU0V5hlL9ZGd2gGBGW7BzpZiH32RYR97/hpiTrkimTsvNqYZhG7dcSdLqaC3F1gXcjISaxr5S1ZjCqXMJGEYw3fXEEKzkgejwq43Pcjle4jz/ItHA/kUcm75IvXScDJRLXN+sqQUW+MCgEs05n27kbw0oZzGnGHZ3FE5yTwsVLdMvjNn7d4xAN6j/J0f3Ah9RbR0J2Hr+RSWT9l87hUZITAbt4ZEjvz58una6QWth8P4bQ+nuspp43mepQl3Dq18FJrraUfFP0Xg1giU1HRjp2uf2nF122IE+Syj9CV8AA2lS2SnNq7vaoyxzC1zvuhs2qVitLEvO2Oyixd8GyTUFzEpA4d/XHv6UZ1bUjdcLwAquw+ihuqarlcvOB1NNB/k2GjsuTFUaFZPWpJw4lMoCzgH6pvCO+Bc9O9lOirRGrJldFfWr+guhrfTu5v2tNYgMfo5hLnzTTkkXF6oNnTt+J4VyJb1g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199015)(86362001)(122000001)(83380400001)(38100700002)(38070700005)(41300700001)(2906002)(52536014)(8936002)(5660300002)(478600001)(55016003)(53546011)(7696005)(6506007)(26005)(8676002)(4326008)(66556008)(66446008)(66476007)(76116006)(66946007)(316002)(9686003)(110136005)(54906003)(186003)(64756008)(71200400001)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9586 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 19d92849-88c4-4e7f-bc79-08dacbb190f2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iPLM3m9Fly9z84/NR6iouUiIiyl2gdifRvkfs3lbZsWXS/+/0vOa6pye9ebaplp2HwXb44XIvsmI7HVhZWw0DfUpmKVgEiOZA6Ah0d9RFdweqwf8fJoOTnSfpcJaPfbgWjALKKUwz5zgPJA1BjIqQQk/qKYzQbjHn7E7hsgNIxdNJSLd87XHGwk3vZ6DnSKZjk7CKjsvkCh6b4ZDEY9KIAF/KM/Ih6zE4h0ASf2eN5euzGYYmzvBXEf/pZYoWQo2q6uZqfwVtyfD5re2m3vH/WQBRAv4YyDJONWUyMGneT7s+ADJL1ijkcE3j7csEeW8ColGVASal/sjABE4rVJk+rUTybHBn+l6aqAW92l9aiDEZpzWocTBiSd3RTsQW+T2bZD+s5O7IAL+AezbYY/MMRv/D68Tm7IfpAjYvpzIminnDjOu+bBKeam2sf0UKvamZtQB+ijRZaNuFEsyUDTUq1pvUOYI1xUHYKoKQEK6RwHTe82Zi0dlZgshN4ZIam5QirLPCfylcOuYIpKSeJZ1GG6EyILfk0o/+41O4Eb9HHWGe9jogJqbzHzkDC6VGcPH53k9g1xas6L7LL+EVQmmSxF68IZepeII/XZd73sqa78c/rqE/JriA+mTXqZIMgskQtzJ0d7EMZXDp2fvPl5im+3a5jRDuiypkRk6XXKrsFLLjt2gwI8Tp9faNDMll2jxHmC+H4CxP9Nc9wpAL1Mo4Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(346002)(376002)(451199015)(36840700001)(46966006)(40470700004)(41300700001)(40480700001)(8936002)(52536014)(316002)(54906003)(70586007)(5660300002)(4326008)(8676002)(70206006)(478600001)(82740400003)(55016003)(86362001)(6506007)(83380400001)(26005)(110136005)(81166007)(356005)(2906002)(33656002)(9686003)(7696005)(186003)(336012)(47076005)(82310400005)(40460700003)(53546011)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 11:14:40.7614 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d67a91c0-4896-468b-f1a1-08dacbb195c4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6425 SGkgUm9nZXIgYW5kIEphbiwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBTdWJq ZWN0OiBSZTogW1BBVENIIHYyXSBlZmlmYjogaWdub3JlIGZyYW1lIGJ1ZmZlciB3aXRoIGludmFs aWQgY29uZmlndXJhdGlvbg0KPiANCj4gT24gMTguMTEuMjAyMiAxNToxMSwgUm9nZXIgUGF1IE1v bm5lIHdyb3RlOg0KPiA+IE9uIG9uZSBvZiBteSBib3hlcyB3aGVuIHRoZSBIRE1JIGNhYmxlIGlz IG5vdCBwbHVnZ2VkIGluIHRoZQ0KPiA+IEZyYW1lQnVmZmVyQmFzZSBvZiB0aGUgRUZJX0dSQVBI SUNTX09VVFBVVF9QUk9UT0NPTF9NT0RFDQo+IHN0cnVjdHVyZSBpcw0KPiA+IHNldCB0byAwIGJ5 IHRoZSBmaXJtd2FyZSAod2hpbGUgc29tZSBvZiB0aGUgb3RoZXIgZmllbGRzIGxvb2tpbmcNCj4g PiBwbGF1c2libGUpLg0KPiA+DQo+ID4gU3VjaCAoYm9ndXMgYWRkcmVzcykgZW5kcyB1cCBtYXBw ZWQgaW4gdmVzYV9pbml0KCksIGFuZCBzaW5jZSBpdA0KPiA+IG92ZXJsYXBzIHdpdGggYSBSQU0g cmVnaW9uIHRoZSB3aG9sZSBzeXN0ZW0gZ29lcyBkb3duIHByZXR0eSBiYWRseSwNCj4gPiBzZWU6 DQo+ID4NCj4gPiAoWEVOKSB2ZXNhZmI6IGZyYW1lYnVmZmVyIGF0IDB4MDAwMDAwMDAwMDAwMDAw MCwgbWFwcGVkIHRvDQo+IDB4ZmZmZjgyYzAwMDIwMTAwMCwgdXNpbmcgMzUyMDlrLCB0b3RhbCAz NTIwOWsNCj4gPiAoWEVOKSB2ZXNhZmI6IG1vZGUgaXMgMHgzNzU1N3gzMiwgbGluZWxlbmd0aD05 NjAsIGZvbnQgOHgxNg0KPiA+IChYRU4pIHZlc2FmYjogVHJ1ZWNvbG9yOiBzaXplPTg6ODo4Ojgs IHNoaWZ0PTI0OjA6ODoxNg0KPiA+IChYRU4pIChYRU4pIChYRU4pIChYRU4pIChYRU4pIChYRU4p IChYRU4pIChYRU4pIO+/vUVSUk9SOiBDbGFzczowOw0KPiBTdWJjbGFzczowOyBPcGVyYXRpb246 IDANCj4gPiBFUlJPUjogTm8gQ29uT3V0DQo+ID4gRVJST1I6IE5vIENvbkluDQo+ID4NCj4gPiBE byBsaWtlIExpbnV4IGFuZCBwcmV2ZW50IHVzaW5nIHRoZSBFRkkgRnJhbWUgQnVmZmVyIGlmIHRo ZSBiYXNlDQo+ID4gYWRkcmVzcyBpcyAwLiAgVGhpcyBpcyBpbmxpbmUgd2l0aCB0aGUgbG9naWMg aW4gTGludXhlcw0KPiA+IGZiX2Jhc2VfaXNfdmFsaWQoKSBmdW5jdGlvbiBhdCBkcml2ZXJzL3Zp ZGVvL2ZiZGV2L2VmaWZiLmMgdjYuMC45Lg0KPiA+DQo+ID4gU2VlIGFsc28gTGludXggY29tbWl0 IDEzM2JiMDcwZTk0YWI0MWQ3NTBjNmYyMTYwYzg4NDNlNDZmMTFiNzggZm9yDQo+ID4gZnVydGhl ciByZWZlcmVuY2UuDQo+ID4NCj4gPiBBbHNvIHByZXZlbnQgdXNpbmcgRnJhbWUgQnVmZmVycyB0 aGF0IGhhdmUgYSAwIGhlaWdodCBvciB3aWR0aCwgYXMNCj4gPiB0aG9zZSBhcmUgYWxzbyBpbnZh bGlkLg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1 QGNpdHJpeC5jb20+DQo+IA0KPiBSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1 c2UuY29tPg0KDQpJIHNhdyB0aGUgSVJDL01hdHJpeCBtZXNzYWdlIGZyb20gYm90aCBvZiB5b3Uu IFNpbmNlIEphbiBtZW50aW9uZWQNCnRoYXQgdGhpcyBwYXRjaCB3aWxsIGJlIGJhY2twb3J0ZWQg YW55d2F5IGFuZCB0aGlzIGlzIGEgYnVnZml4IHBhdGNoDQpmb3Igc2FmZXR5IG9mIHRoZSBjb2Rl LiBJIGFtIGdpdmluZyBteSByZWxlYXNlLWFjayB0byByZWR1Y2UgdGhlDQptYWludGVuYW5jZS9i YWNrcG9ydCBidXJkZW4gZm9yIGNvbW1pdHRlcnMuDQoNClJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5 IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg== From xen-devel-bounces@lists.xenproject.org Mon Nov 21 11:37:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 11:37:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446552.702168 (Exim 4.92) (envelope-from ) id 1ox57R-0004E4-1S; Mon, 21 Nov 2022 11:37:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446552.702168; Mon, 21 Nov 2022 11:37:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox57Q-0004Dx-US; Mon, 21 Nov 2022 11:37:44 +0000 Received: by outflank-mailman (input) for mailman id 446552; Mon, 21 Nov 2022 11:37:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox57P-0004Dr-Bf for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 11:37:43 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e6f8b7d3-6990-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 12:37:40 +0100 (CET) Received: from mail-bn8nam12lp2177.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 06:37:37 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by BLAPR03MB5475.namprd03.prod.outlook.com (2603:10b6:208:299::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Mon, 21 Nov 2022 11:37:35 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::5c96:fc3a:9d36:4a2e]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::5c96:fc3a:9d36:4a2e%4]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 11:37:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6f8b7d3-6990-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669030660; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=0Yo2Ijg1FoGfPa3iGjQpR7x4/uRmoIYcCH6eiUISy4k=; b=OOttn/HVEtcDmgTnWaJcj0UutwyZgbSnw/dwaw2yU+NuLLq1+qXl6ruQ t4ol2MPkj3T4XuDQIWcDFn2sD9vFtbr85XnL2gcNIwrz/hhZCKtgIbqJb 4lOnmrujXF5usukdLToR0CH3kwBYC/bHefiDPH8kPKE37ySgOKA687xet Y=; X-IronPort-RemoteIP: 104.47.55.177 X-IronPort-MID: 85261346 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:HPQGGqn+BvzEJirRS7ndDM3o5gxKJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWDGzUOfzZM2qgKdF+aYS1pE4HuZKHzYMxSABk/io0FSMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5gaGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eIICQIhdFeOu+Kd4rumSuMx3p0pLOC+aevzulk4pd3YJdAPZMmZBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3ieeyWDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapCSefmr6U23jV/wEQMLx1KVWWU+sPgyWT5VNhnC hYp+Sgh+P1aGEuDC4OVsweDiHyNuBIGSsdTO+I/4QCJjKHT5m6xJmUCVC8HV9Ugu+c/Xzls3 ViM9/vlHSdqsaGVYXuF+62IsCipPiwIMW4FYzRCRgwAi/HzrYd2gh/RQ9JLFK+uksazCTz22 yqNriU1m/MUl8Fj6kmg1VXOgjbprJ6ZSAcwv1/TRjj8sVw/Y5O5bYu171Sd9exHMIuSUliGu j4DhtSa6+cNS5qKkURhXdkwIV1g3N7dWBW0vLKlN8BJG+iFk5J7Qb1t3Q== IronPort-HdrOrdr: A9a23:y/E4qa3hGH59+GP2zdiLsQqjBZpxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LoSK05KX8Gx242A5bdz9U278t/U XMjgS8v8yYwrCG4y6Z81WWw4VdmdPnxNcGLMuQivINIjGpphe0aJ9nU7iiuilwhO208l4lnP TFvh9lFcVu7HH6eH2zvHLWqkfd+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ g7nF6xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklUqvoXRiKrbzPIt MeS/0018wmN29yqEqp51WH9ebcGkjb2C32GnTq9PbliAS+10oJsnfwjPZv4kvosqhNC6Wsrt 60TJiB3tt1P7ArRLM4C+EbTcStDGvRBRrKLWKJOFziULoKInTXtvfMkfwIDcyRCes1JaEJ6e L8eUIdsXR3d1PlCMWI0pEO+hfRQH+lVTCozs1F/ZB2trD1WbKuaES4ORsTutrlp+9aDtzQWv 61Np4TC/j/LXH2EYIM2wHlQZFdJXQXTcVQsNcmXFCFpN7NN+TRx6TmWeeWIKCoHScvW2v5DH dGVD/vJN9Y5kTuQXP8iAi5YQKYRqU+x+MELEH3xZlh9GFWDPw8juE8syXI2uibbTtfr6cxYE xyZLv6j6LTnxjFwVr1 X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="85261346" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cVoeeGYOR+kLywlbz6L1Vup1JhbE5TZD8MsSjD7WWYQNDFOgAD5hSdTERYLUc7+ragKUXILKUwIgie6xIyGGIotCMn/u3bs+vFTjUaa63qDenM2N/tcqrJWIgaiewLJVmxMJcqJccJwzt1xZ4vye5f/NFf6xjoT1THNb3E4AdzkMR0s3OGygws7XtclUlBfHJAzAo7fI+CEfqMpPMBTP5M7RCpCOfqqimnnhu4LIg7DLx5SnSb+ZPlwVMYpPcPgbMuXGeHP9IDiCy5d82Uj3zMOpGwvic0Hk2lGlO6b2udRAEX0egKj4i8pcI3rE8TpkupDmad+P2D2Tg1JZYjsX8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Yo2Ijg1FoGfPa3iGjQpR7x4/uRmoIYcCH6eiUISy4k=; b=oFMKxubBfmcaK/tUjstd7lCO6wuy0cia/YZrFfFg4hd8MZWDmiGIz1/TJr++ONeAc3VIniQon5IgQjMJ+tjjGZt+DxhyvwcDL5pPaADZeIuiLkVdVFiVhpxvv4v9f0TtoGQx162eOo1IveHrPwXGr++sPvlTzcKWbfVCcZCPXh372/SioFaohurmIKvESA+n6JdM+NoEQPYOsiTLnvDxZZrQAb1q61Yco1+aIFPwfNYVOcR8Q9aGN/Ipl2cGKdN/s2z9bDU6jKqp45tk1NYkA0gmBzF0kY/9RrNw/Uwt8Yl5Gnz4phoqaTYu27Aaf8bBVv+J8HOt/xFjKomj1F0feg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Yo2Ijg1FoGfPa3iGjQpR7x4/uRmoIYcCH6eiUISy4k=; b=YksVHL0BnFVX9uv0ZngFf4braVvf3bIOUum0MfiOU6HpZ+Xdj7/XZdoi9JAG/CxUSRYGFj0XOEjXAFwQxkVGNJURDCO7bCd49sg4ATt/6IvyUki5ptzY8UK9X/1aSsc9hc08twSrmT1iw77XxnN4AvJzcPckUBL/aWG035s6wnw= From: Andrew Cooper To: Jason Andryuk CC: Roger Pau Monne , Henry Wang , Anthony Perard , Daniel Smith , "xen-devel@lists.xenproject.org" Subject: Re: Flask vs paging mempool - Was: [xen-unstable test] 174809: regressions - trouble: broken/fail/pass Thread-Topic: Flask vs paging mempool - Was: [xen-unstable test] 174809: regressions - trouble: broken/fail/pass Thread-Index: AQHY+zeiYojqAeFzxUaCyzIpzopUAa5EwM6AgAAteACAAD/FAIAEFtEA Date: Mon, 21 Nov 2022 11:37:34 +0000 Message-ID: <56152342-2644-e618-7590-0f8335aac801@citrix.com> References: <6846bb37-345e-ca3d-4cad-2032c4852e15@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|BLAPR03MB5475:EE_ x-ms-office365-filtering-correlation-id: eb4a2855-03f2-4e49-4ebf-08dacbb4c8e7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GeoSbqtDuFI+b7mFWCsRImEMPYYq406bEtD2PVncn0L3FnzkDApdesZ+66NB+RoZFbmIDMr983IJp3MpfKye4yB/pI4h6/XJZ6kKoF6Iqcaphs/lFtwQ0rah8isj3KrSHdo67IBUccPgThZQBO6kjgLRbbPWRzAEE9bHtlVRkSloXBIUD3fbj3kaoCNcz1UEyhrc6974J/2NQlpoN0U4Hw+eE3Z78jxM2cY7MDrFqCzJTfSYTWRX3JhluKwCFpTmuLOC60BlZa6rGI6y4o0C9sdQBOffjyByoXGKT81DtERjqsfq04YXsUgktDgdVvI8jqcg3ErLGwmFpJ1bOa5DreXj0PQVwpEpIrie9vEsHFgxHx9HZeGaHr+dH7rqpGz92AQAHhSUxPJy91tr1JU1/VnzxxswVA0in6eTLHBIKRUoaVLQJEunZRNePXJVts0/TeYYU8XqrmSBECAqQ2VTVDpXJuVBTJoXc8IYij/c8FZtQWxY5JHRDJ+U2g5Xm/VZ2SjA93DLXyiidFFmSJGUPuJRhzU9sdU49xGnNBQYsZVYmxJEy08lUxN8vzIaFsFmlIb0VJ1YHItWufD+pJfGJGnm/lj5aIi877bYIKR57iYLaqDbv+KTIs1CKRZBB252IQDNYNTE08URMKVx5Y+OmlrNj8+Ilujww9WtBc7jGv7zeiceQUw82V3ZB0d6A48DbytKP1rtlHvHRtvcTifmxRmr4UEE7D/6v24E5UeE3NGO6UikqYQWSYoL+bZxQNzBtUBEIvR6720PpttfWo1gMA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(366004)(39860400002)(376002)(396003)(451199015)(6512007)(186003)(53546011)(26005)(83380400001)(2616005)(82960400001)(122000001)(38100700002)(76116006)(64756008)(2906002)(5660300002)(71200400001)(54906003)(6486002)(66556008)(6506007)(6916009)(478600001)(4326008)(8676002)(41300700001)(8936002)(66476007)(66446008)(66946007)(316002)(91956017)(36756003)(86362001)(31696002)(38070700005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bVMveThtbDRUV0xDOHdFNnZuZ2F5WE00S2NzSkpTODNnVkdEYlpvU05lZkRG?= =?utf-8?B?R0MvMnhoT3A3ZmtJTlRnTlBNc1ArQ2lHOHNsNkxOd0VGSVRUY1VSZy92ZGx5?= =?utf-8?B?NHVNa0xJMEhKb2lydlRxSFRzK1BRVytEbVFwYlY1MFdrUmVULysyaXZTemh2?= =?utf-8?B?d09Fd012TVdLWDZ3d2ZyV0Q4c1pGVkJwc2VSSlJDLzVOZWpKbEhUcVJDVWRP?= =?utf-8?B?cXZjNndMTCtQbFRNQ2IrU2FoSHZVOTFhcE1rOVVLOWFKYjFFSElzWGJWaXFs?= =?utf-8?B?N0hkQTZ5Qzk5UWg3UjM4UU9LTjFCL2lQYUlHM0JkUDMxb1g2VVhNcTBtdEpp?= =?utf-8?B?V2xqdkIzTFNUZzFLanAxR0NYTVFONWRFb1NDUlNvdFlFc1BTOEFkNE02R0FW?= =?utf-8?B?R2o5T3hGZVUzRCtGYU1vUWc4Q1JMdDFkaXBsRGFpc1VXYWt0b0FldnFwWXB3?= =?utf-8?B?bHQyUXNWM1pjNXIwYXBqcG9nMDAzZFJqYTduaHdxbjJ3bktpTDdBSEpBZC96?= =?utf-8?B?bFE4QVN1bzZjdEwzREtJVGtRQmI5ajd1RHNsK0NTMGdFbENXRmZGR29zK002?= =?utf-8?B?andzT2pBS2ZYQm9hY0VIa2dNeDNUQ1JPSkRrMjAzMlg1WlUyM2JhOWZaN3ZL?= =?utf-8?B?T0lxSFZYeXU2Vm1wMEU0VjMwZlFLeDZXSWlIZ3Evb1hVT0prb25mM0tsQUVN?= =?utf-8?B?dG5SU2hrQzVOSW1tS253RFovNjV1K2kyTE5WOWVMODVPdTdFNGx6bUhoMkNX?= =?utf-8?B?ZmErait4a1YvbVhYb0liV2xFZ0JYa1hxV1RwSlNQZWdudGNNTjV0bEljLzRa?= =?utf-8?B?eStsM1M1SkN4MG1RV3grSWJzVFdjd0JROFR3QVJFeDQ0aGw0ZUdUWlBLSnhX?= =?utf-8?B?SE1jZEMwNHEzNG40dkZWTk92bVYrUVhpdnl0SExwVThweHI1dWh0Q1J2bUZk?= =?utf-8?B?TG54ZnE4S1VaQ202WmJtcWF3bCtDM1FNWWFjVk1wUDY3dS9KV2RqK3F1ckdh?= =?utf-8?B?UXpBUVpZYmlMVGUweHpOeXhldFMva245aE94a3dCSkc1K2V1Z1FUbGRiOVdH?= =?utf-8?B?OUdTMnBWQXIwd3ZoR0Z3dGhXZm9ITWt6cVUzam1ZV2dIR0QwQzduVytmQlVX?= =?utf-8?B?TFZTRHRnNUhZSzNNc2ZMMzRVQmdmYXNrYVV3UUh5S3l4RlVYK1VYczBGU1Av?= =?utf-8?B?VTRpLzEyZ1ZsZkgxQjNlMVN5Nkk2WFN6ZHFoK3FPN2JCbncwMGRzNEtRNUxE?= =?utf-8?B?OUQySWxraTV2aUpWL0hoZk9vcC8rSUVmODlkaGJTem5NcXd2ak91L3lnaGRW?= =?utf-8?B?SnNDMUE1TjlkMVpWd1pYU1EwTUhFZW1ERlAwd1BtZTNlclBTK0ZuVGRSMEE0?= =?utf-8?B?WGs0Um5kODg1d3hIdXIxWGh3TTN5eGdzbkQzRU9RM1NQM0htdE5PSHl4aXdZ?= =?utf-8?B?cmFqaHp6SVVjMmc3dTEyRzlOQ2F2SUJ1d1ZaaHorZ2VQTTg3YWdWS0tMOWcz?= =?utf-8?B?NVpHYmRqWTVpdm0zL0JTN2F0Q2tNdkpVbWdJWGF4bHozdHRUS21NZXBmbWhj?= =?utf-8?B?bDdjZTNJbjdiRWtCU1hYRTl5TWdDUm5FdEEyUEhYa08rMCt0OTdGT25KWFVN?= =?utf-8?B?b3YvRm5sZ2UvQSthb1RtK3pMQ21DRnRqVTc2cnJoelo2Ni94V3RSTFdaZ2hk?= =?utf-8?B?M2o3ZUgwK0RKL2poNmFMZGIzSUZLMXF2QU9XdWpJQ09na1QyUDQwTE1Jd1E1?= =?utf-8?B?SkxvaXRlZWI1TXpMZmlMc3FyRG4ra2NuQVpWTmVzS3ZFd3FUWGx2RkdzVUNo?= =?utf-8?B?Y0N3YnZ4Ty9nWUc2N1lUUXJubk5HaVcxOHZJTUZDMHZydmY1WklLQjYyQUYv?= =?utf-8?B?VTlMSzZ3WlI0WWkwdG14SCs5TnUrQUtFaDFNaVBvQzRBeGZ0K0l1SUhwRm4r?= =?utf-8?B?d0pxZ2s4WHBFSVVlbUtHMnM2MU1qRW5BcXlMVHc2d2REaXJuYVpGRy92eEtB?= =?utf-8?B?dElIb3FRajhyUzJsNnNSc3M0WTNQZzFiRnhaUERsMGtnM1ppK3lURlVjcTcw?= =?utf-8?B?bHBoZVM0enFWNFVVUDR6OVlXa2Uvc2dzak5EazB1disxVDJpcHFXQUxXR0hD?= =?utf-8?Q?g2i7F5EozQcHj1af59ubREjXL?= Content-Type: text/plain; charset="utf-8" Content-ID: <5AA7CBD72BCFE84B9184A5DDBF158D9D@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DY2QP6hucQ+BX6x16r3a8kEQJHVk8eI4eeR0k40qxvKbiw5Ut3D3O4lFPKxTaLPOc3W0Lloxxgeokb14BviesJiirWTOkP19Ku7BFMeCt9EYKbgIj25g67NKlVT0ex0/h5UOULEm/a18EfL3/cPy5ptm2QTuvDMbiwfD4jP87lHdbMFYSBgVP7bwSpJf14jPIninozrj8vy47bN3fITpACA/N/nW7Jv3D+pjwv4S2QK5Y2r7DTrvUns/AXgxUbSmJ2eSinSIhpewn/bm095aFPULsZjsAX5b7nwn+1mEcFysnC6Q0eDWw3l3Vy1UQBjHFiMT69bSPuFBM3jV1Rr/xP0295mXj2HHNg7rZiA1VPx/VXyHixas04DvasQGHsqmICCaWEqtRkgf2Q8kt7qrb1Tvl6RCQAFtOz+JLhocOg4En87y+LsmvIqYpgR4qNQhurnR1A2HvyOhmANP0xNpFx6zKtfnXSVXj2YYy2rcxA6tIi7xAdQvv006aqinU2JY3inzAqQY7QYUTAJoFR82sRLoKFJ46TYknqkzgAenWV52MWXh0Rx+mk0tjbQojk31uGw28BbB5r2d+CksekR2cDcwbM4QjwW1gQQlvzmZxdLba9IKKHkB4ZNAE5TCdEFCj96MkojCUheBkE2OM3tqkVvm+mpEk2SRYVuvxJ1jTQK9S/Chx+jOAVkflp3GrNFUcaLl3ZtkbkJx1L84VkWV3c1vbFBtG3kl7LPo+TlzrijNF2+Fdv8LNt+xKvPVHDYxJUyVQeEMI3l3XyVMZLb3/SMOIrITxSmajl2MB4YRdkuryp4UqqbY5ihQPHjnA/6HgAxsjEUQn6ZyPtxQOTu//LxBYL+htCbJgvycXQ5AKGbFsFQFhR7M/0KEy7R3GIMU X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb4a2855-03f2-4e49-4ebf-08dacbb4c8e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2022 11:37:35.0875 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JB1hSE6sy9Bda/15asZwOBSwjTuWzm9krCpOFQ1K+9PffHscjzVsxS4zTQwDkHM5xqfcdkaZl0+IzWS7m94Gm9BGH5xeQL/0AfEe673JiKY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5475 T24gMTgvMTEvMjAyMiAyMToxMCwgSmFzb24gQW5kcnl1ayB3cm90ZToNCj4gT24gRnJpLCBOb3Yg MTgsIDIwMjIgYXQgMTI6MjIgUE0gQW5kcmV3IENvb3Blcg0KPiA8QW5kcmV3LkNvb3BlcjNAY2l0 cml4LmNvbT4gd3JvdGU6DQo+PiBPbiAxOC8xMS8yMDIyIDE0OjM5LCBSb2dlciBQYXUgTW9ubmUg d3JvdGU6DQo+Pj4gTm92IDE4IDAxOjU1OjExLjc1MzkzNiAoWEVOKSBhcmNoL3g4Ni9tbS9oYXAv aGFwLmM6MzA0OiBkMSBmYWlsZWQgdG8gYWxsb2NhdGUgZnJvbSBIQVAgcG9vbA0KPj4+IE5vdiAx OCAwMTo1NToxOC42MzM3OTkgKFhFTikgRmFpbGVkIHRvIHNoYXR0ZXIgZ2ZuIDdlZDM3OiAtMTIN Cj4+PiBOb3YgMTggMDE6NTU6MTguNjMzODY2IChYRU4pIGQxdjAgRVBUIHZpb2xhdGlvbiAweDE5 YyAoLS14L3J3LSkgZ3BhIDB4MDAwMDAwN2VkMzczYTEgbWZuIDB4MzNlZDM3IHR5cGUgMA0KPj4+ IE5vdiAxOCAwMTo1NToxOC42NDU3OTAgKFhFTikgZDF2MCBXYWxraW5nIEVQVCB0YWJsZXMgZm9y IEdGTiA3ZWQzNzoNCj4+PiBOb3YgMTggMDE6NTU6MTguNjQ1ODUwIChYRU4pIGQxdjAgIGVwdGUg OWMwMDAwMDQ3ZWJhMzEwNw0KPj4+IE5vdiAxOCAwMTo1NToxOC42NDU4OTMgKFhFTikgZDF2MCAg ZXB0ZSA5YzAwMDAwMzAwMDAwM2YzDQo+Pj4gTm92IDE4IDAxOjU1OjE4LjY0NTkzNSAoWEVOKSBk MXYwICAtLS0gR0xBIDB4N2VkMzczYTENCj4+PiBOb3YgMTggMDE6NTU6MTguNjU3NzgzIChYRU4p IGRvbWFpbl9jcmFzaCBjYWxsZWQgZnJvbSBhcmNoL3g4Ni9odm0vdm14L3ZteC5jOjM3NTgNCj4+ PiBOb3YgMTggMDE6NTU6MTguNjU3ODQ0IChYRU4pIERvbWFpbiAxICh2Y3B1IzApIGNyYXNoZWQg b24gY3B1Izg6DQo+Pj4gTm92IDE4IDAxOjU1OjE4LjY2OTc4MSAoWEVOKSAtLS0tWyBYZW4tNC4x Ny1yYyAgeDg2XzY0ICBkZWJ1Zz15ICBOb3QgdGFpbnRlZCBdLS0tLQ0KPj4+IE5vdiAxOCAwMTo1 NToxOC42Njk4NDMgKFhFTikgQ1BVOiAgICA4DQo+Pj4gTm92IDE4IDAxOjU1OjE4LjY2OTg4NCAo WEVOKSBSSVA6ICAgIDAwMjA6WzwwMDAwMDAwMDdlZDM3M2ExPl0NCj4+PiBOb3YgMTggMDE6NTU6 MTguNjgxNzExIChYRU4pIFJGTEFHUzogMDAwMDAwMDAwMDAxMDAwMiAgIENPTlRFWFQ6IGh2bSBn dWVzdCAoZDF2MCkNCj4+PiBOb3YgMTggMDE6NTU6MTguNjgxNzcyIChYRU4pIHJheDogMDAwMDAw MDA3ZWQzNzNhMSAgIHJieDogMDAwMDAwMDA3ZWQzNzI2YyAgIHJjeDogMDAwMDAwMDAwMDAwMDAw MA0KPj4+IE5vdiAxOCAwMTo1NToxOC42OTM3MTMgKFhFTikgcmR4OiAwMDAwMDAwMDdlZDJlNjEw ICAgcnNpOiAwMDAwMDAwMDAwMDA4ZTM4ICAgcmRpOiAwMDAwMDAwMDdlZDM3NDQ4DQo+Pj4gTm92 IDE4IDAxOjU1OjE4LjY5Mzc3NSAoWEVOKSByYnA6IDAwMDAwMDAwMDFiNDEwYTAgICByc3A6IDAw MDAwMDAwMDAzMjA4ODAgICByODogIDAwMDAwMDAwMDAwMDAwMDANCj4+PiBOb3YgMTggMDE6NTU6 MTguNzA1NzI1IChYRU4pIHI5OiAgMDAwMDAwMDAwMDAwMDAwMCAgIHIxMDogMDAwMDAwMDAwMDAw MDAwMCAgIHIxMTogMDAwMDAwMDAwMDAwMDAwMA0KPj4+IE5vdiAxOCAwMTo1NToxOC43MTc3MzMg KFhFTikgcjEyOiAwMDAwMDAwMDAwMDAwMDAwICAgcjEzOiAwMDAwMDAwMDAwMDAwMDAwICAgcjE0 OiAwMDAwMDAwMDAwMDAwMDAwDQo+Pj4gTm92IDE4IDAxOjU1OjE4LjcxNzc5NCAoWEVOKSByMTU6 IDAwMDAwMDAwMDAwMDAwMDAgICBjcjA6IDAwMDAwMDAwMDAwMDAwMTEgICBjcjQ6IDAwMDAwMDAw MDAwMDAwMDANCj4+PiBOb3YgMTggMDE6NTU6MTguNzI5NzEzIChYRU4pIGNyMzogMDAwMDAwMDAw MDQwMDAwMCAgIGNyMjogMDAwMDAwMDAwMDAwMDAwMA0KPj4+IE5vdiAxOCAwMTo1NToxOC43Mjk3 NzEgKFhFTikgZnNiOiAwMDAwMDAwMDAwMDAwMDAwICAgZ3NiOiAwMDAwMDAwMDAwMDAwMDAwICAg Z3NzOiAwMDAwMDAwMDAwMDAwMDAyDQo+Pj4gTm92IDE4IDAxOjU1OjE4Ljc0MTcxMSAoWEVOKSBk czogMDAyOCAgIGVzOiAwMDI4ICAgZnM6IDAwMDAgICBnczogMDAwMCAgIHNzOiAwMDI4ICAgY3M6 IDAwMjANCj4+Pg0KPj4+IEl0IHNlZW1zIHRvIGJlIHJlbGF0ZWQgdG8gdGhlIHBhZ2luZyBwb29s IGFkZGluZyBBbmRyZXcgYW5kIEhlbnJ5IHNvDQo+Pj4gdGhhdCBoZSBpcyBhd2FyZS4NCj4+IFN1 bW1hcnkgb2Ygd2hhdCBJJ3ZlIGp1c3QgZ2l2ZW4gb24gSVJDL01hdHJpeC4NCj4+DQo+PiBUaGlz IGNyYXNoIGlzIGNhdXNlZCBieSB0d28gdGhpbmdzLiAgRmlyc3QNCj4+DQo+PiAgIChYRU4pIEZM QVNLOiBEZW55aW5nIHVua25vd24gZG9tY3RsOiA4Ni4NCj4+DQo+PiBiZWNhdXNlIEkgY29tcGxl dGVseSBmb3Jnb3QgdG8gd2lyZSB1cCBGbGFzayBmb3IgdGhlIG5ldyBoeXBlcmNhbGxzLg0KPj4g QnV0IHNvIGRpZCB0aGUgb3JpZ2luYWwgWFNBLTQwOSBmaXggKGFzIFNFQ0NMQVNTX1NIQURPVyBp cyBiZWhpbmQNCj4+IENPTkZJR19YODYpLCBzbyBJIGRvbid0IGZlZWwgcXVpdGUgYXMgYmFkIGFi b3V0IHRoaXMuDQo+IEJyb2tlbiBmb3IgQVJNLCBidXQgbm90IGZvciB4ODYsIHJpZ2h0Pw0KDQpT cGVjaWZpY2FsbHksIHRoZSBvcmlnaW5hbCBYU0EtNDA5IGZpeCBicm9rZSBGbGFzayAob24gQVJN IG9ubHkpIGJ5DQppbnRyb2R1Y2luZyBzaGFkb3cgZG9tY3RsIHRvIEFSTSB3aXRob3V0IG1ha2lu ZyBmbGFza19zaGFkb3dfY29udHJvbCgpDQpjb21tb24uDQoNCkkgImZpeGVkIiB0aGF0IGJ5IHJl bW92aW5nIEFSTSdzIHVzZSBvZiBzaGFkb3cgZG9tY3RsLCBhbmQgYnJva2UgaXQNCmRpZmZlcmVu dGx5IGJ5IG5vdCBhZGRpbmcgRmxhc2sgY29udHJvbHMgZm9yIHRoZSBuZXcgY29tbW9uIGh5cGVy Y2FsbHMuDQoNCj4gSSB0aGluayBTRUNDTEFTU19TSEFET1cgaXMgYXZhaWxhYmxlIGluIHRoZSBw b2xpY3kgYml0cyAtIGl0J3MganVzdA0KPiB3aGV0aGVyIG9yIG5vdCB0aGUgaG9vayBmdW5jdGlv bnMgYXJlIGF2YWlsYWJsZT8NCg0KSSBzdXNwZWN0IHNvLg0KDQo+PiBBbmQgc2Vjb25kIGJlY2F1 c2UgbGlieGwgaWdub3JlcyB0aGUgZXJyb3IgaXQgZ2V0cyBiYWNrLCBhbmQgYmxpbmRseQ0KPj4g Y29udGludWVzIG9ud2FyZC4gIEFudGhvbnkgaGFzIHBvc3RlZCAibGlicy9saWdodDogUHJvcGFn YXRlDQo+PiBsaWJ4bF9fYXJjaF9kb21haW5fY3JlYXRlKCkgcmV0dXJuIGNvZGUiIHRvIGZpeCB0 aGUgbGlieGwgaGFsZiBvZiB0aGUNCj4+IGJ1ZywgYW5kIEkgcG9zdGVkIGEgc2Vjb25kIGxpYnhs IGJ1Z2ZpeCB0byBmaXggYW4gZXJyb3IgbWVzc2FnZS4gIEJvdGgNCj4+IGFyZSB2ZXJ5IHNpbXBs ZS4NCj4+DQo+Pg0KPj4gRm9yIEZsYXNrLCB3ZSBuZWVkIG5ldyBhY2Nlc3MgdmVjdG9ycyBiZWNh dXNlIHRoaXMgaXMgYSBjb21tb24NCj4+IGh5cGVyY2FsbCwgYnV0IEknbSB1bnN1cmUgaG93IHRv IGludGVybGluayBpdCB3aXRoIHg4NidzIHNoYWRvdw0KPj4gY29udHJvbC4gIFRoaXMgd2lsbCBy ZXF1aXJlIGEgYml0IG9mIHBvbmRlcmluZywgYnV0IGl0IGlzIHByb2JhYmx5DQo+PiBlYXNpZXIg dG8ganVzdCBsZWF2ZSB0aGVtIHVubGlua2VkLg0KPiBJdCBzb3J0IG9mIHNlZW1zIGxpa2UgaXQg Y291bGQgZ28gdW5kZXIgZG9tYWluMiBzaW5jZSBkb21haW4vZG9tYWluMg0KPiBoYXZlIG1vc3Qg b2YgdGhlIG1lbW9yeSBzdHVmZiwgYnV0IGl0IGlzIG5vbi1QVi4gIHNoYWRvdyBoYXMgaXRzIG93 bg0KPiBzZXQgb2YgaG9va3MuICBJdCBjb3VsZCBnbyBpbiBodm0gd2hpY2ggYWxyZWFkeSBoYXMg c29tZSBtZW1vcnkgc3R1ZmYuDQoNCkhhdmluZyBsb29rZWQgYXQgYWxsIHRoZSBwcm9wb3NlZCBv cHRpb25zLCBJJ20gZ29pbmcgdG8gcHV0IGl0IGluDQpkb21haW4vZG9tYWluMi4NCg0KVGhpcyBu ZXcgaHlwZXJjYWxsIGlzIGludGVudGlvbmFsbHkgY29tbW9uLCBhbmQgYXBwbGljYWJsZSB0byBh bGwgZG9tYWluDQp0eXBlcyAoZXZlbnR1YWxseSAtIHg4NiBQViBndWVzdHMgdXNlIHRoaXMgbWVt b3J5IHBvb2wgZHVyaW5nIG1pZ3JhdGUpLsKgDQpGdXJ0aGVybW9yZSwgaXQgbmVlZHMgYmFja3Bv cnRpbmcgYWxvbmcgd2l0aCBhbGwgdGhlIG90aGVyIGZpeGVzIHRvIHRyeQ0KYW5kIG1ha2UgNDA5 IHdvcmsuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Mon Nov 21 12:06:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 12:06:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446567.702185 (Exim 4.92) (envelope-from ) id 1ox5ZT-0007vn-I6; Mon, 21 Nov 2022 12:06:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446567.702185; Mon, 21 Nov 2022 12:06:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox5ZT-0007vg-FJ; Mon, 21 Nov 2022 12:06:43 +0000 Received: by outflank-mailman (input) for mailman id 446567; Mon, 21 Nov 2022 12:06:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox5ZS-0007va-Rp for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 12:06:42 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2061e.outbound.protection.outlook.com [2a01:111:f400:fe13::61e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f5544e8d-6994-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 13:06:41 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7171.eurprd04.prod.outlook.com (2603:10a6:208:19c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Mon, 21 Nov 2022 12:06:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 12:06:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f5544e8d-6994-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KYlUCWHbOHLKXVcGDhYsLpn2aHWqmBfHlxEMSVxBn24JH8VkBrA479gklJF+jmVP6pXVlDleJvyYfOUOMEJBWVkT2qbM5GE2s02tgaCXggrujQMYK3ZfVg7AJ3fUHBgZlcYUyPnhBNE60cc1Pp42kh0FAhaCAaqB+Z0tFkKuX6IHOXoRCJymSmh7AO7NgYKmuWDpme7wOzdNo8g2iOWE4CXGphnB5wIygVEGH/XYphl/cTtVQtvO+/nF1MKWvd+E7oQK6gJADND/UXISJZ+bSh0ljcjzZB2C3n2HGnn9mMRguAtAWbNEL9TuVMOfuXkF5JrhUag9l5ibwzdYYZZ0Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PfWqe8txZ8pTIPnXFfeSBoTDiYmJpnxz5DrlDj77Cnw=; b=WBG/7GBqKkPWICmg21vzuubj89rkqJ3eIP5SA3sV2Y8mH+5FqGyYd6nhWDxEbcx/srYSsdg/k0DfgESkUJT6eofR6kfOKMGum7KIgc3AYChYW8PXUUJhCyRAP5g1VcDLxAcDtMJUFcm3nQVxV04bWuoaVlVhm8fDwz+XHKMcU7Y0ucCzSlw33UiVOyAvckc5dhxk79y6bEpqI8IZ1b4kQch/D8/Q00WXP5aeIDzjRQUklwrUWjDXb4Fo0CNToGVZewYSmZVP4dNW5PfTcEcYTHm1Yw34T585KuO4mt+RvyENq/N345K3s8QQrB/TgnTrgfFs88eDOlUqAGxgyEw3dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PfWqe8txZ8pTIPnXFfeSBoTDiYmJpnxz5DrlDj77Cnw=; b=40pI6Ikh+hICoZWEIh9lZ6OjRFDp205xGWt25BCQ1uTDOzptEfvHwiZjk0Qk7h0fWQ3ho1hl3zMXxzCOI3NTEvCL5/p7p+/L1yFNnXJmlmKUIiuFlAfovKk83oasP25/ajThCpXKXt+5LCYhkIsqXSWoeXaqQB5iJIHZ4DBUllz2067aQfuJN0aVVzdaob3y8iMkU92egwvnlL66eqvC7CuvBCKRJjy6WxKG931fTND7NNmDMWJYv5NkoI+ov3dB0RhArSlaFd2hGjnagdk7Jx95/PtRQR/u4EsvGlkaAA3xdnFlWXKz1NdX/u7rN6pjZun1sujXtpQdlhmdF5jASg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 21 Nov 2022 13:06:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Language: en-US From: Jan Beulich To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Paul Durrant References: <3add150d-ab4d-9147-005e-3f3160ec9667@suse.com> In-Reply-To: <3add150d-ab4d-9147-005e-3f3160ec9667@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0105.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7171:EE_ X-MS-Office365-Filtering-Correlation-Id: 23ea07b1-2abb-4689-fa8b-08dacbb8d8df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 655GfqNVrbFS6y3/tzvYYbaHvvvv3ystyEV1cdyOrNzt+NfNLkReDhpoFmg5BLoB1RFyicc8G32LeLOyuayWYTZpHKU4GTXJaTtn/br33++Gip0nToshLCxz0Fm4HqpBcKwTdO235gv8mFE/BK27zBuG/9yo6Z0UejIObeKQ5WLuIOoFo5lGkbWIYUttwUhzFiA6GwvjnObmHLDt+m9NWzGJf3D82XYrmcz8jsQ+psAzdrwAjWZ6Dwknc7zFHhLowONG5a8FBeCUi7oQ7LqH1k+CPXWHPFKs/r3JAJQ+H7X1Sn41AGuvOVtW66TVW3C4X8Ao/XVRZbFL1vsR1GrTSlOq8vFA8ebqdhx+35yqjajhXTQXuf1B6U6/04SwxClWqBSmO1o8BaYIagD8vCFWMVQ+UWhsedAU5kDCeOBj73PJ9BPcYn2GXb1bIn0tySfBnBCIhN7TJ6k8odjWMvBUQCC6aUTxgdlIAlofccm17TzVAvCLHKZYLuekyE/69BFmfT4oStQzHFSavomUsjFir6TF/eh4cNC8PC0DAwB/aqk2tBgQNmUg2fhjUeMydVAjGlqN+sw+YQgIA+8NMdVEqISAWDJEdtUiT+JIchdZmUPuBj3MaDACbmysMpUVT8+h9o4bNY1Q5CEU4QXovQUASVLm2YpZtdlZM+tK2T5zuRGMycc3rgb9RiIsiI6WfZdys3Ph5egkU8b7a7rPlJLTOx4XoUlf99uXx2dGet1GD3Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(136003)(346002)(366004)(376002)(451199015)(6512007)(2616005)(8936002)(53546011)(186003)(26005)(4326008)(5660300002)(4744005)(478600001)(38100700002)(36756003)(316002)(31696002)(86362001)(6506007)(6486002)(54906003)(6916009)(41300700001)(66556008)(66476007)(66946007)(8676002)(31686004)(83380400001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1FIZjVkTXNIWjVpNmk1NnFhSDBnQUsvUkN3QXFVZW5nZHVHeUc1MnphcVhI?= =?utf-8?B?KzJYSHlQODF3UFZ5UWlYNlFaMmcvZG5jYzQ5VXdoNElueksrVndvVWpNb05l?= =?utf-8?B?NG9NZXVOL0d1UDVLakNIQnR2SjRWQVZtc1ZZOTBUSXg4Y2pEQUlsWlg3RmM0?= =?utf-8?B?TXVRdUtPRCtHZUEyaWFlaUh0U2w3R0V3U1BnNTc5eHVTOHhyaG9KemlHMUxs?= =?utf-8?B?bVBzak1pSFcyM2tLMjUxeEpJNkpQTkZUOU9TVWp2bUlNby9XbUFlZ3UrdnlQ?= =?utf-8?B?UGQzbjJwWW9NVllFam13S1hwenZ1NHdudDNqRWp6TzB2Y2YyU2JIRXMyVTVx?= =?utf-8?B?VWU4eU5TclU5L1haeVQ2MlRrQ0MxMjFIQmRJNXRWb29rN0pjL0ZTTWVnK3c2?= =?utf-8?B?NVhoS0E3NERIc1BYUjNjNXF1N1IxZ2wyOUVOS09RZnJDTFRaU09rLzJPZ0NW?= =?utf-8?B?TXo3dUZlQ2prMHdQb3BCcit0ZTNYSUpudGNwWWJ0KzB1SW94aUtnR0dpb3hR?= =?utf-8?B?V0lNSzVuREpKMWF5Qi9xbEhOVElFWm5oRG1LMlB4YzkxTGQzbjRvWC8vd1Fs?= =?utf-8?B?bjBYUDBBczM1dllZUmVmUHFPTGVBWitDYUpCTkF5Mmo4R2NnK1ZLSVd6WUln?= =?utf-8?B?RVUxdFRTdmxkbGhSMzdxcEdtdi9ybzdpZkw0NUM1NDM0MHdEazdqQkYyTllm?= =?utf-8?B?VnFZcXQrTTl5TVZ5Q0g4ZHJEMVNkMjlCWHpoak5LRUpiQ0tYSE42OVFuSDYx?= =?utf-8?B?VW9wenBheWpHaHJNZmVoT2xIU0VFOGJPKzVjWUU2d3UwcXJvMHJaTDhFa3Bz?= =?utf-8?B?cXR3am0rM0dRcUdCbTZhdEhLcUp4TmJBTjR4TW9MUG1XTitKM1VQdmIzZHR1?= =?utf-8?B?c3dRYllkUDJkajBld25sbTZoOE5kSnc3L09IL243Q1lGSEtoTEpNSGMza3pL?= =?utf-8?B?c2NLcUUvUC84Z3dtbi8wSVdzc2pQVVFsbXpnTDY1c1VxNm03YWpBOTE2OFcv?= =?utf-8?B?SUxGcFNuWVovUWJtbkZDNE13UitPQ25NWWRLV1NNb2JieThrR1Exb0VVM25u?= =?utf-8?B?elFrdU96dXZPQlVKMG02SXAyMU52d2UvenZqbm9sRnRSMDdSOXNsalRXYWp3?= =?utf-8?B?RW5UR1pBQnpEdUhmZ2IwUHpmWXR0Wml1cUJZWUt6VlpjMzdvTUpHWitEM1p0?= =?utf-8?B?Q2lwVFAzMml6d2JTTys2SVhwUGZiMG4wanJZYzdINTl2RHJ6dE9TZHFKMmNp?= =?utf-8?B?QWxLRDRPcHRRWDB0aFlVOVJmK3B5YU0rVlRtTFZrSjF3ZktiVWdJVXIrd2ts?= =?utf-8?B?ZnVpTWhHTDRPdzczRTVkNEE1NlY1eTZjejhLNzJKL0ZpcG5tZ1BRbHdtbEpW?= =?utf-8?B?WEdkdE9pWklOdktsaVBzZ0pNRVVUTTcyTFpxYzBsRXdyeUtVSmluM1lpbC9n?= =?utf-8?B?ZjF3azRZSFlReWlvelJxRlRBODJ6eFQ3SE9HMnBxVmQvY0xCRWoycTlhSW5t?= =?utf-8?B?NkpuZUpXb3VYS3h3Si85Tnl4dktIL0M0enR6ckZwWC9XOVFoSTVVQU9zSU1v?= =?utf-8?B?cWpNaS9HY3NWaHZnMi9qYWM5UzBiMmoxL3pzS21VY3B1ZW9XZmcrbUd0ZlFP?= =?utf-8?B?TjNQejNMUVZEQk5MbkV1N1pUN25RMVByK3NvSFJjemE3dFZyS0VVQ3Z5d1dS?= =?utf-8?B?czdoOFlCVkl4UmYvc0FiSmE0S3J2RG9LVHJrS2Zwb3ZTTDVBYk9KUHp6aGdv?= =?utf-8?B?dmF0bzFjVU8rbEF4N2ZXcUQ0eXM3SGY1TzlTWnBGUHJuQkZCZGY5cU9DbVM0?= =?utf-8?B?UG5lVjVBVUFlTGNSZ0Qza2doWGUxSEhMdmloMkNoZkRKbUFyUGxsd3hiZmkr?= =?utf-8?B?bTh4WE5BSGJicUFldWxCaDFGZWd6eXNKejRaVDU0LzZFWjhOUitwTDUyNHht?= =?utf-8?B?OFY5MlZaSlEwQXNKZUdBNXJrUWNlWmNZMWh5QzJYWXVaWU1CVjVlWkMrWEJN?= =?utf-8?B?aHlWS1VVUnFvTi82WisxQitHS09QZDJwZTFYa0hKeExyd0lTNkx5d3pFNE9K?= =?utf-8?B?aDUvMTNVOWRjWmZXeFcrZlN4MWgxYnFBZ3Nuc0xxdlVINHZLYXdHMWQ5ZXZO?= =?utf-8?Q?Jca2ghZA6LwR2nt8ToHgNs6PU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23ea07b1-2abb-4689-fa8b-08dacbb8d8df X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 12:06:40.0418 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jbOb4x7A1E3YX39a0OVVH1wupCzXFMAiBkg+x+Ss8NG5k2SI3D4gmaMbmn2TBbj/sM1yPzvjqx/jlFfTMwl1gA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7171 On 21.11.2022 09:33, Jan Beulich wrote: > On 18.11.2022 15:26, Roger Pau Monné wrote: >> Maybe best to add an ASSERT in vlapic_set_irq() to be sure the lapic is >> enabled, as other callers already check this before trying to inject? > > Perhaps, yes (once we've fixed paths where the check is presently > missing). Actually - no, such an ASSERT() would then be racy against the vLAPIC being disabled elsewhere at this very moment. It would at best be valid when done on the vCPU in question. The SDM also provides for this: "The reception of any interrupt or transmission of any IPIs that are in progress when the local APIC is disabled are completed before the local APIC enters the software-disabled state." We don't follow this to the letter, but you get the point. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 21 12:13:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 12:13:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446573.702199 (Exim 4.92) (envelope-from ) id 1ox5ft-00010x-9O; Mon, 21 Nov 2022 12:13:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446573.702199; Mon, 21 Nov 2022 12:13:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox5ft-00010q-6e; Mon, 21 Nov 2022 12:13:21 +0000 Received: by outflank-mailman (input) for mailman id 446573; Mon, 21 Nov 2022 12:13:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox5fs-00010k-5h for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 12:13:20 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20613.outbound.protection.outlook.com [2a01:111:f400:7d00::613]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e23a611d-6995-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 13:13:19 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8509.eurprd04.prod.outlook.com (2603:10a6:102:210::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Mon, 21 Nov 2022 12:13:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 12:13:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e23a611d-6995-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xkwosi6Z0eMXEUxYAT1HVXXVZ0I3/rXDfj8mmShesKfESpeEbhQ8JhrCILpFB2piVNwKyVSLeZtzuJHHL3Wt/PyyJ0dTLYCQ/gq0NcDkTlLzQW/W62LLA/TF2eB6ETCMKXjbc/sk/rjHqI4U4dzIro3f8DcC/7p+Bd6yrxIOfiR/sZ1yzRVGKx+xkV5B9WG7IUEpBqGwgvDAJe74ifb88BPAJ0JPYVa58V0wVuT3ocXc4PuM9XLB7F4tiyyr7VisGgu7m4KZc7z+K8ud/kKzBpRc501KL0EgfwRLhED967eLXv+JdIArn/HxVK1LRa3HZzuKaqQYabFEjhM/bkAxtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oUu6rnRXe9YkDTkyf1SAxdBVIm8j6LjCfjDtHIypVgQ=; b=QEdiMSilbMDD144iactQY8VIQQcSL5o9iJ13U2/uy8yuI7qhf43Hg04A0NUUvbK0yHyg/+c6BRxBt7+Vbonv1Y/+HIu/KDweVtAlt1UQD0uyXHxf8fNQfU8BMraTW6TBIP8Maz6EMPkXTxGUMHt+G5gXbDtDTiTPS/sHhhaeYBQ6k2mkC7SqBEq5jisN2j+TuGeNpV05zxh+xx96hjLfgOWwxBYn6BMYSGbZAwNaIjGPI5T4O1dMnNTYARnyMgMHrBCGakjX3/v9VAFG/idG6WCvA+wknZs/hDKmOc9WU7i6mQDQhbzmfXI1T3ONT1E57Fd02+IzCaFoTBK4mfxD1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oUu6rnRXe9YkDTkyf1SAxdBVIm8j6LjCfjDtHIypVgQ=; b=btVXMtDAcO3mVmqm0L6u8ezUFKgJEn3TS+1vAbsN55Y5fEmRR9S2TUzmD09LdAfPkAslDNY+R1MZz6v3QXpaDOWb70ph555SkQ214VyngyvR16Tz6OfY2x5SyYCVL2aPqeIfaXwvf4V+A2SXOuFiT8p8J0nyAxZ5B6vng2tEAa2MD1eNEw06M0EK8cA8CR0Y9Ad+uzUylevcuD+fGFA+rOFLYv0v1IqH49HIirzmXyKBadSqJt9i6v4xxyPHlGUvCI5wwBVboen0/v6A9+PLV5KFjl1AuEe88EDre7IVyF2h4mXCi+ZEqRgnbm4Ga4bYMkAZMzNlKvgXlQjgI+4W5g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <69b79ab2-0acc-5980-9a79-8c477aa33868@suse.com> Date: Mon, 21 Nov 2022 13:13:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/HVM: don't mark external IRQs as pending when vLAPIC is disabled Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8509:EE_ X-MS-Office365-Filtering-Correlation-Id: 7278d11e-aebe-44f7-1ad9-08dacbb9c574 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CxkocuabUKDFb4G+y2hzmK+X4DnD+k0nZMQstC66YuB16+UtBScCq68zQk3fTIoEZLZtP/oiy7HTRcJwbK2vA+E35yWMpOdKhjsfffNmUICQzpYXNlWI2esHR9deo3Q/aq4wS4seyqmG8HNORApQs7n+FSCOkmc0CbI/mKDzksl4+vxBdE3nhoWToadB+iiF1b4K+Dz0RcQXOQ9rH89XWS+4vxb98QMPOIrFl/3bnWQ+LKPCKI9YpHHLikltssvDCw8MEWcp7qQOgC3iZuxSl/dsMRKPgxei0ArWVTHndYAwvozSFMB48UOuLMGxtSyrmK3L9ZucYOSt7r76cMICjhdT2k9PFyAs9rmlST0CbIrLeA3dO83aMqFwdY4z3RlLLb/k9qnwEvuv3t28pnXYuwlPIJDniOxbRwDQkjpGqu3w7I94aSS19n9ciIoyXFU4tcdI6XghNqy8MXZ2NrvoZ2a30GFGRcRr4a7bEf55PToWoos8oZSQ8FTlTyTogiAGi+M/LvSDG3LxuA55fRwpXxi5gXQfJRGQ3GfCZChlwoG/vgDbWPvtOFkGTv79S0NTwx9kyOleSCIOS3pnp5Ahf/u6jsxxM2EYgacmHQ1vmAxt2TJ6OgnO7ks+s2zsTV6uCy2kPyOn7K2M2dYSkjs+n/RJMAh8XpWEOtzbw30mv275vtOwVLUcJ6oxYy8pnEk6qg/CJ/m5OjmKl0AFDJmc6NAOHjaRu9wDs/snbQ9vrvY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(136003)(346002)(376002)(39860400002)(451199015)(31686004)(2906002)(2616005)(186003)(38100700002)(31696002)(26005)(478600001)(6506007)(66946007)(66556008)(6512007)(5660300002)(316002)(4326008)(8676002)(6916009)(66476007)(36756003)(8936002)(6486002)(83380400001)(86362001)(41300700001)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VG1DOGpuN2dHS3p6NFZWcjVUNGcxVkFuaDArMUVzZnZiVFEzaHJuUm9BYVRt?= =?utf-8?B?NmNQQ3UxQUJzMWhKelV1M0E0RmFob2ROT1ZXU1dlWkV6ejYwVzM2eHR1WFpn?= =?utf-8?B?bnpxYVl0RDMyVGthNEV5eWZqVnB4bWZUVnJOaVBjYXFLRVhBV1R6S1ZaY1lx?= =?utf-8?B?VXZvWmxkeUFlQnJBTFZycVl1ZVdvK1ZoWFc1bFhCMFJKTVhBNnMyZXFENm9C?= =?utf-8?B?L3h6aXlnOWNROXV1RVNtdUJ0YUxhaWNuSEdmTXlCNUd5UWpKRjltVUMvODZV?= =?utf-8?B?d2pPcnNaenJncktPSVpldzhiTGRqbnJCOEpCL2liU29GNGc3SmtZSW5OaXZI?= =?utf-8?B?S091eXdhVDFNcEtWQzJaOUdoOVg5QXdSQ2Q4K3NtT0xXK01hRU9EVExhNHhQ?= =?utf-8?B?QzRwZUhEbU5uVXBwa3BtcXdOYXN4OHpVckxZNGRCUXQvRFVIKzJPQ0NTSzN2?= =?utf-8?B?MzVpbmsxZSsrUSt2TllEWFFzTitodDg5T2UraEN6OHg2Tmkrd0RxOFppYk5i?= =?utf-8?B?NDBDcDg4SFppUXNIakdjZ0FVcGdiMmk2bEdIUk9URnFvODZ4dnprWndTajlq?= =?utf-8?B?WmtzNkNSU1FWdkVmMjFyYlN6MCtsR01Vd25XTzZ6dDBveHhQRHI0UDlHR2lU?= =?utf-8?B?SjFBSVZ3SWdUdjVHUzlJU05lMkg5akpmME1UaGROall6ZHpEeWJqbGpBdyts?= =?utf-8?B?eXdobW81TGJ4WXc4Njc3UjdHNEFCbVhTZzJ1eEZQanZCNDJaa1VwS2l4aXFr?= =?utf-8?B?eUhJVUpEM295Q1FteTdvNXIxdjQ5ZlpFKzZURmxpYzhTQmlWUU5rczRWN0h0?= =?utf-8?B?UmcvQkI1a3hhcDNzd3cvem5CdnB1dnJDa2kremNTN2dTTW5lYnlrZ2JtMEw5?= =?utf-8?B?b05HM3ZaakQvRzhicHdKM2FYSHl0azlsc1BWK3RxQjlkd0h3am9XK09vNHFn?= =?utf-8?B?NjYxY25PMm5ROGRNcDU4NFBlNHZpc1pBVlBkN3pic213bXAwZ3p3elhuQit1?= =?utf-8?B?WXNQNVpNYnFGQUlmdlFOUnVrcmZCQkhrejBIWW5sWG1Bclg1eVFXQzZQdlFP?= =?utf-8?B?K1V6NktsZEpDMDI1b3dkcko3bTVraFVTNE9KY0JXaGZFelpiajhuaXZTZFJq?= =?utf-8?B?bHFrRXZwdDRtcXZYdC9maVdrV3oxc3JUb3ZLTFZCZmRpYnVmamVoUERiSVpa?= =?utf-8?B?WjdXUFJHZjNEbURtV0wxdUZEcjM0OXZEZEZRTnhkRDZib0x6VzdvT043cjNG?= =?utf-8?B?aUxaK3JjUEVGZ0JqWUZaOFhKN2RDMmE5bXhraGRTQ2NwVkFNZ3JFRS9uZnh2?= =?utf-8?B?cGQrQk85emxBY21YL0h6UXRBd2hWVmtoT1pOejJMZ3p0aWJDWkN6b1R6bTNB?= =?utf-8?B?amF3eGRFUit6WkJTdUxTSUhWSGdTelBLcWUwc0hxUkQzSEZmS3NGYzcyK2o4?= =?utf-8?B?SWhWRWFYa0FVeWt1OUFJcVVZRDQ0czBmcU5pNU1jS25vUEQ3cUpQT0E2RTdx?= =?utf-8?B?RGJhR0orRVh0YUc0NmxEOUc5Y2NsWUc0K0cxYi9rOUo1SWVRYVp3cWMvelZN?= =?utf-8?B?VVVadUdVeVgrQkVKNnJNbTBKeUV6M2w4OFRpTzhxU0FDZWVRT2k5VjY3RitF?= =?utf-8?B?MU85MmN1M2k4b0FZMUl3bmp2MVJZRmE4TWorMVNuS1RXRXJBZEc1dEtTN3li?= =?utf-8?B?WURYbzlZcHBmS2pnZFd0NDNJR3NNdU83UDNESGM0L0lXNVVuaXhaR0ZudlpY?= =?utf-8?B?UmpscG9oaHNSTW9CalRBbHZRbzRldHl5M2hCNCtGOW9qV2UzSDdPM25IaHV2?= =?utf-8?B?MXhYcWVxcnhTdTIxK3BOMFNZZ2ZyeVRXWVk4eWRKcFdpeXk2S1V6bDNnMUp5?= =?utf-8?B?M3VvM0N5VXVOeEJQWWJ3MlFrcUlzZG1aTnFlWVVsL1pZWGRoUnUxVjJSZUZm?= =?utf-8?B?V09kS1kwajA2OFY4UmNnSWh5Q0g4eEZUS1R6L2d0d0Via3BGdGZWZ1ZEOXBP?= =?utf-8?B?N2VOU3djWUxMdjZldGpUYjlnUlpxNldoUDRiNkdFMFhNcWlWVXN6UHQ0VUlG?= =?utf-8?B?Qjc0TlluUmY3TjZTRTU2djQrOGU1d1NpUktUZmlXSTcwNTBkdFpmcWdMdExF?= =?utf-8?Q?ZMPKnwQhztvsvl/hdNE+74xRR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7278d11e-aebe-44f7-1ad9-08dacbb9c574 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 12:13:16.9392 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iM118i3WCxkcnXfuS6MJ4WxAylFkV6OSRtu41JJ5fjBEh5IrZTpE4Slu9B61S7RpD/0eM/bcTlxy32hwTFNWiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8509 In software-disabled state an LAPIC does not accept any interrupt requests and hence no IRR bit would newly become set while in this state. As a result it is also wrong for us to mark IO-APIC or MSI originating vectors as having a pending request when the vLAPIC is in this state. Such interrupts are simply lost. Introduce (IO-APIC) or re-use (MSI) a local variable to help readability. Fixes: 4fe21ad3712e ("This patch add virtual IOAPIC support for VMX guest") Fixes: 85715f4bc7c9 ("MSI 5/6: add MSI support to passthrough HVM domain") Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vioapic.c +++ b/xen/arch/x86/hvm/vioapic.c @@ -460,9 +460,14 @@ static void vioapic_deliver(struct hvm_v case dest_Fixed: for_each_vcpu ( d, v ) - if ( vlapic_match_dest(vcpu_vlapic(v), NULL, 0, dest, dest_mode) ) - ioapic_inj_irq(vioapic, vcpu_vlapic(v), vector, trig_mode, + { + struct vlapic *vlapic = vcpu_vlapic(v); + + if ( vlapic_enabled(vlapic) && + vlapic_match_dest(vlapic, NULL, 0, dest, dest_mode) ) + ioapic_inj_irq(vioapic, vlapic, vector, trig_mode, delivery_mode); + } break; case dest_NMI: --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -87,10 +87,12 @@ int vmsi_deliver( case dest_Fixed: for_each_vcpu ( d, v ) - if ( vlapic_match_dest(vcpu_vlapic(v), NULL, - 0, dest, dest_mode) ) - vmsi_inj_irq(vcpu_vlapic(v), vector, - trig_mode, delivery_mode); + { + target = vcpu_vlapic(v); + if ( vlapic_enabled(target) && + vlapic_match_dest(target, NULL, 0, dest, dest_mode) ) + vmsi_inj_irq(target, vector, trig_mode, delivery_mode); + } break; default: From xen-devel-bounces@lists.xenproject.org Mon Nov 21 12:14:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 12:14:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446577.702210 (Exim 4.92) (envelope-from ) id 1ox5gZ-0001WH-Jb; Mon, 21 Nov 2022 12:14:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446577.702210; Mon, 21 Nov 2022 12:14:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox5gZ-0001WA-GE; Mon, 21 Nov 2022 12:14:03 +0000 Received: by outflank-mailman (input) for mailman id 446577; Mon, 21 Nov 2022 12:14:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox5gX-0001T8-Kg for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 12:14:01 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20630.outbound.protection.outlook.com [2a01:111:f400:7d00::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fb00bee5-6995-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 13:14:00 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8509.eurprd04.prod.outlook.com (2603:10a6:102:210::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Mon, 21 Nov 2022 12:13:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 12:13:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb00bee5-6995-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MUWmWmKnV+iBVAwjZMHG1XqSqRRB+qdBbn7pKSUs/SBOsmkV5GwXPF/v6nnEFksxQGMAhIHvvjcjYKJNMQiZqSJA3XYRZOlDUZ632sM/gxgVnzZx4Dv7v8jW7nvo/qHx68d3Ow+dVL87yt1vmdsrzVKIu8xsXO63/wVRb7kdcbbcnB4gBMF3QXM0xsGYaJ1FBR5IN2hBFlMwuv8ZkCp70wmV0/UygPi4ZeL6DGNw/y6Ldz8Cz8mDk0Nmc2MO7sXMqN14gEQHP7ztkjsqxKmSw0ZCN+6m+UTJUFovtAd3zam/L+4bK9n2MsWIKrkbm7Oekoa4av0KUIRqCNahPB7ljA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tfkW11X9pDByfM7tL7/0F2TK04AeoKyeauuXX07eoQI=; b=JAh37n2ZUEHxokUli2eKfVW1aaKUsv4rLIh8Z7bvk5lQUO6ynblszCOA4mm/bdlXGSW95CBUCI5V2D5/ZueomBpkz+0OoAlbxDYGtZ2oHxCQAoHk0Q5xGe1dGKalpI1Ilf96HW49+d6tGl1e9dTzrLoOsMZD2Y95OpbbbNdq5OmV9SuH4GNdl7NBvlfPH7IhMxmrw4twYzBZNkxzR6Wd5EFf7GKWGIPhhPbSdeYcNF2rmpgcK4UR0z+KeBRVPcw3kzcyJF3EQHjqkYPPLfbS8rP6nozKFUbGFhklYD4F/9hIo8nN2mya4UVW9oMcpFJbbHdG9DyQ3q7E0xiCZgwjBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tfkW11X9pDByfM7tL7/0F2TK04AeoKyeauuXX07eoQI=; b=BBXWIrA6ibhNu4L4A8so0gBcf0nj7VA079ICHPdBWWf04TQ5y8QYLXnnss8cgSWElehjvOW+jJU4DvPDBnFuTY6KG+6L6DbU4O+wwzwO0wfHIMutWTo0LRxcEgWacXhp791ZprG8SUpHlP/FTetxO8vSm56Nl59oWwynlbINmV0BsOZmRV+U4czBY3vBX0BsoHNZVoP/03B1tEGc6UByK+b7hf74V532HI3AUptKYQywrSt8WMVg2bf+3bfdEL6GqOT+DK+b6qa1TrX9jnGf9Ge5YSmhPJydlezW1v8WYLidbxXGM6icikDlhFNI+LfSxt6Fq4k7Uy0pOfO/tklX7Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 21 Nov 2022 13:13:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Paul Durrant , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/Viridian: don't mark IRQ vectors as pending when vLAPIC is disabled Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8509:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c151ad7-f28e-4979-7a5f-08dacbb9de70 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Flt8IEoZuedTSYfEVt+anvEFbo5ofqqoEUHZN/ImWDmHZ5+jf7t/y7jGUErK5c97VL5PxnhX00JgfHZXHEYTUHvDqt45u8vJeVCUOC6ZXnUbaZE87dCABMcIt1k29Gkn/Up+sDT5eXdLiAynbO2tKVWW8S1XDo4pQvPbK5KUUWFo58jBqumxkdFHtvJXHI9i/fFAkDuwXi84XpO0mHw0IXtjytbuxCViKaelWW1pbwDOAQ5LdVG0+r5vQOASkQRjiOvc/hjPd0ZJ1iBtpGCfxMOqeKTl/wO2eavrE6FCNvesyRnMhlH/oKmFdHowjGNojk6d8q2/kf0I9yfSKwdI7AKZE5VTNRd5ynJ3GrGHyTVHIlAmzP8jo/fpo8iWlCSkIrIxbBjmGTYiRa5PL7H4QJmcxGDi5rvL8/5cNZtMmYN4crZcKSYU9kzanEC52apIEzSHLoUZdgQr8ZjzDL4fa5oOaiB3VU5G8EZ4vayxXWjCSWLyPOXNvdq0C/HWxn2Uu8VsfRjF08Eq4rtprXoJaxr71DGuFerspqoaRZ1GvxvwxYEOwKHjDTFEMRMV4A+tJbPHoo0WSDxh7p6d1A3KE5mUKnODVxPqblh8iel02HoTyu/mW46jsZnBHoWGV54BygbEmKoVGGVMHW/SSEJMib4gLi1rjuvPTjWwWHVg4u2yUp4bjL749nLk68G+5fP6tVQCcAsdJto3EfxyIHvZZvvmIyj7JS23YVyaUDOH23Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(136003)(346002)(376002)(39860400002)(451199015)(31686004)(2906002)(2616005)(186003)(38100700002)(31696002)(26005)(478600001)(6506007)(66946007)(66556008)(6512007)(5660300002)(316002)(4326008)(8676002)(6916009)(66476007)(36756003)(8936002)(6486002)(83380400001)(86362001)(41300700001)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmZjYkhYZ3pJOUt3azNFaU9JVEE3YkFHTFlMM3hsNEFHR0lOcjFaY2RlZk9q?= =?utf-8?B?ZmhWbDFqWnhVL003VHJabmlScFFzNjJ4Q3pqdnZ0M1pVUEcvckVsN2tuNkQ5?= =?utf-8?B?RkFVUGRtSFVrbzIvZC9WTjB1S0RjS3orUXJTMG9xdWJocXhzSWFLRGxoQVh0?= =?utf-8?B?ZHBJSHF1cldkdTJNL08rWW1OOC9uZW5mUVY2NlhaNDFwT3JzVVZpN0I0eVZM?= =?utf-8?B?aVdBU2VzbzB6c2tOTDBtZktXd1dCbkRtQVB3YlZMQXZmbkhja0RiWkd6N1hU?= =?utf-8?B?UGprVVh4bUpnL3g4ZFR5NTk1Q2FUQXpKM3dvQTRTMFBTd2hxbEszZW5UVzRv?= =?utf-8?B?ZzRPUEdXNHQ3emZYYW9xamkxcTJTaUt4a0FDdFpnZWU4UlNLRzkzaHVtajBk?= =?utf-8?B?SVZsQVdXd0Juc3prQ3FiTlVOZ1JrMnJteCtBNERROTZIY2FFN2tJWFBrM3E1?= =?utf-8?B?TThURkRYQWNTbUFJaFVueVJMbDloQ1JmY2dReTBmYWlrb3JRWHBxRFVaU2lw?= =?utf-8?B?ZXNEbXNjSzhoM3BwQkw2eEJnSzQzWTdMb3Eva1VFd25saEFuM01YR2lPNFBz?= =?utf-8?B?ckxZZFRYeUF6Q0VGaHFOd0NJMy9sOTlMMndoZjljbFVSZXdZK3c5dFBYMVBK?= =?utf-8?B?Mk4xendVTjZOWlc0OUZQVnk0MEYwWTc3RmFMVkw0VHZzd3BCK2E1UUMxNC9Z?= =?utf-8?B?NUwrbGllT1pzdGNMcHRENzc5dWNMdzJpMlNGaGhxcVNwVWtUeklJd0E1VmhR?= =?utf-8?B?NnZPZkRsY0VzOTljV1h0QjNYcHRFb2t5OElUMU9LNElNNkMxbzYvREYwMGZw?= =?utf-8?B?R3pJcFN6dkViSTFlYTRBRnRGMk9XZ3E0Q1NKNzVXaU5leFBGK004TTdUOUVw?= =?utf-8?B?NlNDNUt4bFd0cGlqSWxtbmxMUUw1QXR6ZGZEdWJyY1plcEg4T0xwOHF1TUVH?= =?utf-8?B?aEdDVTFSVXZJRHV4SEZicHV3NCs3UmI1eUlIUi9OL3BZM1M5VkVLcE1IUlZi?= =?utf-8?B?Mi95aGJSSnFmUU1KdVMzd1l3dkZQRlpiMi84TFhka01pUWZpeVlzNEI1RjFK?= =?utf-8?B?NElIZ1p6MFdCZFpLazJwc3pzV3k0SVJ1WCtFUUVDNk5ZRDVwMStYTUtzbFJ3?= =?utf-8?B?Q1N5ZVZyRDdZWFVMTXZueUJlaC9jMEJidTFZNkxQWWQ5VDlUM3hhNlNhUGl0?= =?utf-8?B?dm53RkNLOXp0WFhkVml0STRXS01USEtFcnNPS2JlVmxBbFhtWnQxS1ozZkNN?= =?utf-8?B?ODV0RU9mZnRaM1ZWbExXQkc0L2w3alBoaW9NQ3RYM2JvQ1U1TStCcjA0YnVk?= =?utf-8?B?TFdUMlQ0blYvL25iM2RqU0ExSWVGLytOS3dZdHFFYlRVS2VpTUViWkZTSjZC?= =?utf-8?B?L2ZaMjNveWQ2MGxYbEYxMjhnY0c0dnR3SjV0RUlVUzg0b1A5eWhGaWZaYlNm?= =?utf-8?B?Y3RlZGplNVU2c1FqMzh4NkRWeDNYT043SmdmOWpWcDN1K2haNzR1aEZZVzRB?= =?utf-8?B?ZnBwUDVBUElkUnpCYjVkTHBucnRQZnFCUVBYWFlwdzZDU3BTeG16RDFSR3dV?= =?utf-8?B?akxueTEzb2ovQXVWZldCK3VZUUxGSnFVQm5mK2NucjBZZmtkMWk3THE2ZWpr?= =?utf-8?B?ZUdPenBZSFNsWkZnWTljTE5BTWQ1WGNMN1laRzlkcFliT2l2UW5wUi9ONUJ1?= =?utf-8?B?bTA2TlI4OW91TmVBYWVrWWlLeC9wb0FSTVBWcjVGOVZKUzB6Nk52c29xRGo2?= =?utf-8?B?bC8xTkVuRmx1dXBRdjlIZ2tsWVNIbGxJbHYxeTVteW50VFdONXh3SkVEdlNh?= =?utf-8?B?S1grM051dTF0RlFkWDZ0MG1ubWJ5cHlYK3BDNzkzbzJPRFJzd1c1VFBRdktN?= =?utf-8?B?Rzh3RmxLejZSWkFIaEd1U2ZRZWFqRURNeHphS2hZRlhjZ2FUL3pqYUZVZXlL?= =?utf-8?B?d2FJWGlPcGlUcmVWb0ROMXFaa2l2WHdONk1jV09DUFdDWS91V3ZXWWh1RDl5?= =?utf-8?B?blJOajlyS090Q3JUMXcvV00rUUdPcTNQUlpDcWRjaWdOSWJ3cmxPbVRRRm1M?= =?utf-8?B?TFBWTkJSOWJETEllV0hHa1NWNkdNc1Z5TXhoWVpZZHpQVzZvV1UvN21qQjhZ?= =?utf-8?Q?f2ZenTv+f19H5fn6M5aIOH+Ma?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c151ad7-f28e-4979-7a5f-08dacbb9de70 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 12:13:58.8273 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GuGDiuVx42woSDwynum9KfVkiTp8bw2snao/LiF76iDbv5BPABcFx7QOtNF8GM/AvUPBgua7+BnMPiCfH6cyfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8509 In software-disabled state an LAPIC does not accept any interrupt requests and hence no IRR bit would newly become set while in this state. As a result it is also wrong for us to mark Viridian IPI or timer vectors as having a pending request when the vLAPIC is in this state. Such interrupts are simply lost. Introduce a local variable in send_ipi() to help readability. Fixes: fda96b7382ea ("viridian: add implementation of the HvSendSyntheticClusterIpi hypercall") Fixes: 26fba3c85571 ("viridian: add implementation of synthetic timers") Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/viridian/synic.c +++ b/xen/arch/x86/hvm/viridian/synic.c @@ -359,7 +359,7 @@ bool viridian_synic_deliver_timer_msg(st BUILD_BUG_ON(sizeof(payload) > sizeof(msg->u.payload)); memcpy(msg->u.payload, &payload, sizeof(payload)); - if ( !vs->masked ) + if ( !vs->masked && vlapic_enabled(vcpu_vlapic(v)) ) vlapic_set_irq(vcpu_vlapic(v), vs->vector, 0); return true; --- a/xen/arch/x86/hvm/viridian/viridian.c +++ b/xen/arch/x86/hvm/viridian/viridian.c @@ -811,7 +811,12 @@ static void send_ipi(struct hypercall_vp cpu_raise_softirq_batch_begin(); for_each_vp ( vpmask, vp ) - vlapic_set_irq(vcpu_vlapic(currd->vcpu[vp]), vector, 0); + { + struct vlapic *vlapic = vcpu_vlapic(currd->vcpu[vp]); + + if ( vlapic_enabled(vlapic) ) + vlapic_set_irq(vlapic, vector, 0); + } if ( nr > 1 ) cpu_raise_softirq_batch_finish(); From xen-devel-bounces@lists.xenproject.org Mon Nov 21 12:14:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 12:14:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446581.702221 (Exim 4.92) (envelope-from ) id 1ox5hA-000275-1T; Mon, 21 Nov 2022 12:14:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446581.702221; Mon, 21 Nov 2022 12:14:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox5h9-00026y-Tf; Mon, 21 Nov 2022 12:14:39 +0000 Received: by outflank-mailman (input) for mailman id 446581; Mon, 21 Nov 2022 12:14:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox5h8-0001vt-5m for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 12:14:38 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0f9defd7-6996-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 13:14:36 +0100 (CET) Received: from [10.10.1.128] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1669032864902143.4470409260905; Mon, 21 Nov 2022 04:14:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f9defd7-6996-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; t=1669032867; cv=none; d=zohomail.com; s=zohoarc; b=Y+LsheZCVhhdQeNSE8I45kLFI95mq+XzQ4AOZ7rgVQ9gf3MiPOhwsU/HYTN728xroWjUsZW70+qif3Ovs3EcihxoyfoVJyBlFWJjkHsCjJINpz/yBCMvyuWcAaM6IfRmCe28gn1QNnozbVCzOD/9VZ8NEuhtfD/SLf9WjjGEOmI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669032867; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=kAvyxNhxrDhDOTk3kJ4SBAnDuRQLgM3Lx2hQnjnoA9A=; b=a+S9zrpKWPTtoH9Mq0v6fk3qZseeCUMRO/6I/Pswp+RygZbq7cjbkRVI6ae7hRX9d0wCISysDnyvyc+zcUZ1qv4y8u8Vfh6YFijFftdKrOB6nfxjQisTgROV6DfluXjUsZ/Q+vajkVaFO6bMgdD8UjlaQlcPwz5zfmvzgdtV4RI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1669032867; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=kAvyxNhxrDhDOTk3kJ4SBAnDuRQLgM3Lx2hQnjnoA9A=; b=P81mi1pVtIhg9toGquMvsbAK3o/aktr0yYyyVvy0cp94pZ/UFGk2JdRDjz9uQiIx 0U5CQayD2hR0C6wyiUhR6Mlc5lNtElUHUSkWO/+6gk/iRLUu2FA+TaRazqI6xd8TqlR XovwnMBa2XACUVGLVzaIIDCwdqZaHwmf3WMghieA= Message-ID: <5e24609e-a54d-8303-9385-a99a98cdf3a2@apertussolutions.com> Date: Mon, 21 Nov 2022 07:14:23 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: Flask vs paging mempool - Was: [xen-unstable test] 174809: regressions - trouble: broken/fail/pass Content-Language: en-US To: Jan Beulich Cc: Roger Pau Monne , Henry Wang , Anthony Perard , "xen-devel@lists.xenproject.org" , Jason Andryuk , Andrew Cooper References: <6846bb37-345e-ca3d-4cad-2032c4852e15@citrix.com> <08577045-517d-3566-9931-dcc1df6c2cb6@suse.com> From: "Daniel P. Smith" In-Reply-To: <08577045-517d-3566-9931-dcc1df6c2cb6@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 11/21/22 03:04, Jan Beulich wrote: > On 20.11.2022 12:08, Daniel P. Smith wrote: >> On 11/18/22 16:10, Jason Andryuk wrote: >>> On Fri, Nov 18, 2022 at 12:22 PM Andrew Cooper wrote: >>>> For Flask, we need new access vectors because this is a common >>>> hypercall, but I'm unsure how to interlink it with x86's shadow >>>> control. This will require a bit of pondering, but it is probably >>>> easier to just leave them unlinked. >>> >>> It sort of seems like it could go under domain2 since domain/domain2 >>> have most of the memory stuff, but it is non-PV. shadow has its own >>> set of hooks. It could go in hvm which already has some memory stuff. >> >> Since the new hypercall is for managing a memory pool for any domain, >> though HVM is the only one supported today, imho it belongs under >> domain/domain2. >> >> Something to consider is that there is another guest memory pool that is >> managed, the PoD pool, which has a dedicated privilege for it. This >> leads me to the question of whether access to manage the PoD pool and >> the paging pool size should be separate accesses or whether they should >> be under the same access. IMHO I believe it should be the latter as I >> can see no benefit in disaggregating access to the PoD pool and the >> paging pool. In fact I find myself thinking in terms of should the >> managing domain have control over the size of any backing memory pools >> for the target domain. I am not seeing any benefit to discriminating >> between which backing memory pool a managing domain should be able to >> manage. With that said, I am open to being convinced otherwise. > > Yet the two pools are of quite different nature: The PoD pool is memory > the domain itself gets to use (more precisely it is memory temporarily > "stolen" from the domain). The paging pool, otoh, is memory we need to > make the domain actually function, without the guest having access to > that memory. The question is not necessarily what the pools' exact purpose are, but who will need control over their size. If one takes a courser view, and say these memory pools relate to how a domain is consuming memory, then it follows that only entity needing access is the entity granted control/management over the domain memory usage. In the end there will still be an access check for both calls, the question is whether it makes any sense to differentiate between them in the security model. As I just outlined, IMHO there is not, but I am open to hearing why they would need to be differentiated in the security model. v/r, dps From xen-devel-bounces@lists.xenproject.org Mon Nov 21 12:24:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 12:24:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446590.702234 (Exim 4.92) (envelope-from ) id 1ox5qD-0003l0-Td; Mon, 21 Nov 2022 12:24:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446590.702234; Mon, 21 Nov 2022 12:24:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox5qD-0003kt-Qo; Mon, 21 Nov 2022 12:24:01 +0000 Received: by outflank-mailman (input) for mailman id 446590; Mon, 21 Nov 2022 12:24:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox5qC-0003kn-Ur for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 12:24:01 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5ebbae6b-6997-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 13:23:58 +0100 (CET) Received: from mail-bn1nam02lp2043.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 07:23:55 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by PH0PR03MB6219.namprd03.prod.outlook.com (2603:10b6:510:e8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.11; Mon, 21 Nov 2022 12:23:52 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::5c96:fc3a:9d36:4a2e]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::5c96:fc3a:9d36:4a2e%4]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 12:23:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ebbae6b-6997-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669033438; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=oVL7tfPvhqZHEWr4k0UwNBS6LYjPQVIpkkPufNfNWCQ=; b=SyxPi5CXEcsuhq3z7n/mcR7nCNof4AvmbqhFFZUODsot5NENvqcSjhwd VjDFlCGZxfCROy7OTYHYo22FWqstFPCDLo61J9qc/aynd/GpF456m9YsG kYWyVU33KfscD0QT1enZCfGNsPk9M4vaErmXP7OAv1T5efJ4Rj8ecvkez c=; X-IronPort-RemoteIP: 104.47.51.43 X-IronPort-MID: 85665039 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:CpfDY6u5bWo5utqUaNebnlR0rOfnVGdfMUV32f8akzHdYApBsoF/q tZmKWDTa6yKMTHxetx2PNmw9EkH6J7Qx4BhTQprrX8wRnsR+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaEziFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwNm8yNR2nl6GK64mRYO5Lids7M+TABdZK0p1g5Wmx4fcOZ7nmG/+Pz/kBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osif6xa7I5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6RODmqKMy2wz7Kmo7VjgKTgGBsfqCj22lSf1iB 3U4xDEVsv1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xGWwsXjNHLts8u6ceXTU30 neZktWvAiZg2JWFRHTY+rqKoDeaPSkOMXREdSICVREC4dTovMc0lB2nczp4OKu8j9mwEzepx TmP9HI6n+9L0ZVN0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLlm4U2l/MBVfNgwIQ== IronPort-HdrOrdr: A9a23:stulDKDbxes4vTDlHeiEsseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzI39QWUijusybjiVzyVxA0XXT9jyaortT GtqX252oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuQFNzn2jQ6sRYJ5H5mPpio8ru2D4Esj1P PMvxAjFcJu7G65RBD6nTLdny3blBo+4X7rzlGVxVH5p9bieT48A81dwapEbxrw8SMbzZJB+Z MO+1jcm4tcDBvGkii4zcPPTQtWmk29pmdnufIPjkZYTZAVZNZq3M4iFQJuYdI99RDBmcca+d pVfYfhDTFtAAqnhkXizy1SKRqXLywO91m9MxM/U4euokVrdThCvjclLYok7zc9HdsGOud5D6 6vCNUWqJheCsARdq5zH+EHXI++DXHMWwvFNCaILU3gD7xvAQOFl3fb2sRD2AiRQu1/8LIi3J DaFF9Iv287fEzjTcWIwZ1Q6xjIBGGwRy7kxM1S74Vw/uSUfsuhDQSTDFQ118ewqfQWBcPWH/ 61JZJNGvfmaW/jA5xA0QHyU4RbbXMeTMoWsNAmXE/mmLOCFqT68ujANPrDLrvkFjgpHmv5H3 sYRTD2YN5N60i6M0WI9CQ5m0mdD3AX0agAY5QypdJjubTlHrc8wjQ9mBC++tyBLyFEv+g/YF Z+SYmX4J+GmQ== X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="85665039" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MLZ1T6aU5w7jxtBojLBVo0tKfBIM6ZWEKkvjVlPulZecYgMSMu/T/yfFtjnLErf69FBjQbCIKjZLwRXGBTDCcnXnrxp76AD3utEUKCMAJWV4f0rdWJHhj2IP/KszkhWWRr5V0K32UMtF0g1Aukn7Xm0/nqHUzir6h1R9ALvChgmSvrfiIlSFGANNm68jrMOHAutveXhDD5OctOhXUdAx9NmYJjQk6xoeDurghBFhmVN7koCzTNObyT5K3yG3YxGQKFCt74TZOzE56IaAe+cZT/i1oxz5iZT17LdqXwVE8jNwrU2FLe7mZ3HABqqPdxZt/VaBgJsRvjKxjEt/T10emQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oVL7tfPvhqZHEWr4k0UwNBS6LYjPQVIpkkPufNfNWCQ=; b=NMcuS8tKLWo97lFEdCXpeGDYaA6lTIUgnN2GiUTiKpRF7HGwNdrcswlVS2XqwnAevoDOHPzK3Vj5gWc/0nOz6mgzQ+T1K5emPWaJRYaEmEo4Qk8+hMXFUoVsp/JtGICpbgfjgUeVwAsBjIR1IJxV8eeBohOLo7YSHIIdHisbA3xPuceoQGdEFs3dUHhTEckjRkZeu68PGrfI7AQYiWUglB422AkOBZHoIrFlqXzvttRVkJU0ThMHXqf5vdobXAtsjrelRASdjOti6ET1jKpEza0RbwdN+w3ux+T5NPHduf5WWg+Ty7K/GTIVtFsq0gwhJ9wIzwL5YoRQfivsg57MDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oVL7tfPvhqZHEWr4k0UwNBS6LYjPQVIpkkPufNfNWCQ=; b=hTMgljQmWa45q08/3hOBYjiVrfevlUpLb1e4nY1DmKE6Srf16KH4izVhvSXU8hTjwRx7blkrhKQSLp9DuaKyEs6G6hGmrnhIa7r27THhn/J59nFET+tdtV1u7/ZznYPjPgUKJyhY9xNwAXHGDMIJSBjBEscmYDpzB+RuzpZoRcg= From: Andrew Cooper To: Jan Beulich CC: Wei Liu , Roger Pau Monne , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Thread-Topic: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Thread-Index: AQHY+zjv47cM7GZ23kWVhiI/91aGOa5EnVaAgAAGB4CAABnfgIAEWpmAgAA59AA= Date: Mon, 21 Nov 2022 12:23:52 +0000 Message-ID: <69507b8d-1f31-39fb-7469-e240fbfdde44@citrix.com> References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> <5a2df843-1acd-ad78-baff-e47befd0703c@citrix.com> <878e635f-b116-3580-945f-f8acb711a5bc@suse.com> In-Reply-To: <878e635f-b116-3580-945f-f8acb711a5bc@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|PH0PR03MB6219:EE_ x-ms-office365-filtering-correlation-id: bc54823f-298b-4383-1612-08dacbbb4088 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /7zK09pA+NloDfx9DB7rjYnraYuLbhLJr+idu2J09pPgUhMu5leMc3JjS0/8gWobeAT0nB0IMKzG2JQPv4GzJiU7G57tZzgc+5foDtMb7VGoPpp0SsuxWgSD/c/vxJNUZBIoUElAb/G+0ezwk7f53SEeL5O6jI41fCWWv6L0A57ZUytqpBF/xgu9exVNgcVjJl0HOFGOX06v3ZJMPkgxs4gUZGlVjqocyWFnTqrW29vsJTzYTVtC6NTWo4PH/oW6dNXm4jrP/Gmw711lEZzXIxSCECtzPcpFXcUh3S0I6kWcSJCDZqx22rbkwbiCGVlFQ6NiTrFck9E1txMvPBgLNXy3DRHrBZZ+1pcGFZAPftYPDfk4cT0KdWSVSfI5d3s832BQkoDLEiKnFKnPVdNQEk6CzgfvPT+Ni7lh5pHMVPFsLe4hEAV3bAoY9XCBGiu8i5Y/p5MUD3KX91GYQFSfBUz1XcOBookwA1dSnabznhEFbEmabJfIZ4OuPINOqlg1ITX5LjPV8eYKvpaq8sbygX06EnqXaftpnGsLfyTQxoi+8QmMjCh6RjmhdicnfBx3wftrZJ2/CY/aLhgWSPx22dAfwu/Hf+4SdhNdxgjzIqONLPBMU2uLY/pDQB6OLdSgVPkHtF0jSVuVOLnw6yi0K0P/Idqq6MiE/r0yUSxfXBl9tLUZChqwVspraKqTgU6PnLLQt8MPQ/yNMW9Oj7xVHfYFdyVqJx33rfMzMfbUCcCxO//etj0NleSdOcJF+PkXv1qufuCAAhc3TGmc2Voibg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(366004)(136003)(451199015)(71200400001)(91956017)(53546011)(26005)(6486002)(478600001)(76116006)(64756008)(4326008)(8676002)(66446008)(6506007)(66946007)(6916009)(41300700001)(66476007)(66556008)(316002)(122000001)(38100700002)(6512007)(54906003)(83380400001)(2616005)(186003)(8936002)(2906002)(5660300002)(31686004)(31696002)(86362001)(36756003)(82960400001)(38070700005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VklERFE1azBseGRBVlpVY0gyUTg5UkFZTmtYOUF6Lzgvc21iQUM3SDNPN1FM?= =?utf-8?B?RDB1bWh4ZUNsRlh6bHBJUGF5R3o2NWpHUWVzRmVQNDhWcXhqYTdlaHNJdWh4?= =?utf-8?B?d2lZSmVSS2NJWlptTWRLOVZPVWtZQk5sbjBiVU5VTTMxeTdva2NJTnZzcGtO?= =?utf-8?B?SkVlaGRjSHQ1aW1hNk56RjYrNTBGQUVGYUZVM0JSdnFqcFZqK25xU0JZbzNE?= =?utf-8?B?Y0JWZElsUkIwa05STDVoOC9zVVBPVUM3US9KajdPcnpiZTg2azdFajAvZFJH?= =?utf-8?B?cHVGVHZZcWxCTWU3QURiMExpVG83M0oyTzVzek1VRXp1NlBUVVN4SFBLV1Ix?= =?utf-8?B?YmlZQ21JWkZMaFhoaG9CUkVXOCt2K05mU2MxME9KRGdUTUNlREFod0NGMmVZ?= =?utf-8?B?UndQaE80N3dmMmgzcVU0UktzMXF3cHJkdGhwUk5xSVE5eVFoWWd5Qkd6emxT?= =?utf-8?B?Lyt3VU1hbHhpY3JVMjBCVWZZaDVWZjZ6UFV3OXdEdHliTlVxa0FvTFRRa2Rq?= =?utf-8?B?SGZFWWpiVklpaVV0Y3FrR0V4ZTg1U2FsNDNFc3FTN0hQRENWemJtelNhY1FT?= =?utf-8?B?bEVzK2RlMGRYNks4R0lLMjZ5ZE5IcUN1R3FITjROejBUSzRONytLY1hXMmxP?= =?utf-8?B?ZXliNHJyK1dpS25hUHNnNkFNU2pCYnBHVzZVOHRkcDFFekdid0lqd0cydTBI?= =?utf-8?B?OTJ4R0N5dld2RnBickpTeU5WVkk4Qi83NytZVktIczZrRXRlaFZ4NmdKSjJs?= =?utf-8?B?Wk96dzRqNlBkdENFanRnc0JCcmhubXhBcFlQYS9KdUFyQldEbDR3ZDg3SnQ3?= =?utf-8?B?Sk45b0NzNEFhZjhjN3JaaDBNcG04S21FU3F1MzhDQ3lxQlhXeC9OUjFrbXc2?= =?utf-8?B?S1J5K3lyVDFGUEt4NnU0a1B1QkI0T0ZOOHlFT0lHeXN2QVJSR1RDejdoNGZG?= =?utf-8?B?Z09hb3l1czltT0JWbUFvU0pRc2xOenMwN2JhaWR5Z1UwcDQ3ekR3RnZrbGJl?= =?utf-8?B?aHBMRVVvc1dDSnE2VkNuRE9jMDQzRHh5Y09PZUdPNWhtU0ZJbWovdGtFSmFU?= =?utf-8?B?dDVxSktKTEdEeXdWSEdValRBOERVVk9aRU11T0lIclVZTlFQWHNGdTFlRjN1?= =?utf-8?B?bEIvZStuU2JnQnFjUEtlMHc0N0YrUEMyL29JRUc3ZFY2OCttbkFJOVJOR05z?= =?utf-8?B?cy9CWE92TnZ4N2NmMUpCN1NaK1JMOFFGY0xocnVxcVU3WDk2cU5aakpOYVhn?= =?utf-8?B?cHgxUlBETUhKSDFpbTk1NlFiQXUvZEpWU3BDYmV1V2tZeU5ZanlNRTFUMFZh?= =?utf-8?B?bmJCSzVQWEQ4eGdzWUZ2K3cwRzJ1TDJQaklnMzBieHJFZFZpbFV0UzVVL3ph?= =?utf-8?B?SktxcXpzUnpNNDdpQzAvZ1JjeE5pd0gvVm1LR0VnVGYzZ2IyTHQ3aGZPczVO?= =?utf-8?B?MGR3RHdzUnhFZUZocDVsc2R6bnZuUVpDZUhqSVVvWElWRmRPR1hQRU4yUUh1?= =?utf-8?B?Y2pSbVRhSXhiZ0ZqVW81dUgybFhVb1h6WFlmYkRJWWNueENFZ3BNZ1hWaHhy?= =?utf-8?B?TDQxby9UR3lLSVJ6Vmo3ZTE5V2NuUUVuMFo1ZEt2VWRFU1F4RFJhc29id3N6?= =?utf-8?B?Y3pDODh6bFFhSVRIeDlyYmlOZWJSWE0zMlBFaGVKQTlsdXhrcnNjR2pmd2ZF?= =?utf-8?B?ZjMvd245Skt5MXNnQWlTcENoWGtnV2VaMFczeW1FVE1KSUpwWTQvNWpnd01o?= =?utf-8?B?Q2FNKzFpUXRyVysvc2xvaTJSbmJ4czltc3kxeUF5aUlZakFxWWtGQ05ZZkxv?= =?utf-8?B?bFZMc2JMV3FOMzBwVDZ2TlEzSGZ6d1RLN3hyeGZaWmRKTW9raEVzalVmOERs?= =?utf-8?B?T3RaUHRpa25HcnAwMFRNL3hHcy9iWnpOVHd0Qmppc3dxSVkxQ1hvaEpaRUdj?= =?utf-8?B?WDArYlhvWFdtMmdXWG43TkwxL09kM1daR1dhU092RkNIWWJnVG9xMUlHVHJW?= =?utf-8?B?STdpTk9XQ3ZuQkEvYnlJOGJlZnZ3dTFBSEkrL0xiV0hqU3o4SWVoWnBwSlpY?= =?utf-8?B?RTBYUEZqckw0K1NEMTZ4UWx0WU5RU29ZNlFraTh0K3VLUER1RURaQ09UL1Yw?= =?utf-8?Q?FxHbppA+Jfyqh9Hxfp6EzFDTH?= Content-Type: text/plain; charset="utf-8" Content-ID: <284CE6C9B6DC1C4280FF853296F15313@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pvL15yjwaMa3JGCKLL4N9BrhMkIZcPofq6OjL7tp53yZgorjzlJuyK91H9Qf8qBmADRt8/RVcMj3MiQquna6XY25ox1cJH9hwkjGttzNz6I+/wwQ/vfuFYDOsIl/XA9MgkvleKeRToqITse1u1iW3gJyDp2ktB3BZ6E/vRmaZCRzh6NIAcvGGutpNeM7/HX78A7jHjzbjHctCW9qYTg+AuGcDiee3GF6xeamZ24sBvphJC8B0BAdVcm2rUFLQJXz2NoneXKaSQn3z40SRVEyz6c/LcHlzo6qvQJ9wTddZgP0aEc3yD+PNNLAtNW7aZhaYnRt1PPUXrAZNDTi5Cp3mm3mzp0cGPy7kKUK7rpzZycQBWpV+8XuQDU3aiD+ALzwM856QuHfjALgWbAHyKLGx1O4s1yDogDwCWn7pzOE9RKw7YfqiCpxXlmCRTWrX8d7BJhScnirzGmq0WjL2tIxumstGy1sEoKaxlP5/s+EqGUAgwubfk9OQnz+yvq0me0jfQE8p6JjohNaPQP1ZOssfej5OtKDzPeG1S/04bVnRbq2upP6rTk+XcyC9blPIx25e7DLyNDGAGC7SwKHI9UddbyuFDsA6h/DXBWBShn7PHYE7aupbSVaN0poYXuS5+GtgARxsFexF3AxD06I91fHn09fNYVR4NKOd89RCl9H8Twy3PwW7IQaTOCty8kGZ1XYLRZAwd3OYJXz9OMBloMdkFTfh+OnrFa0ix/SQdlxvLlB6kv2ieIWBAWbvWPhqZinU11nAWd/0WfVjkwRa/G7zemTNTlE5E+rRE02t6sLTzZK+I6Av0Cj++MmoZxwJyIfr+GRFNeYtB04j5BH1FZkEdcp870HiG2WPbEoopU2WF0= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc54823f-298b-4383-1612-08dacbbb4088 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2022 12:23:52.8173 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6v2QI533RQ284Pm62gup3IPICiSDsUpCz6877w1DJkTlBUrWCJVE6jejsgoLfdzEvkLF8sx/D9vuCzwiSpP0eq6Dhm4/yNDSEuPm7xIUGxw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6219 T24gMjEvMTEvMjAyMiAwODo1NiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE4LjExLjIwMjIg MTU6MjcsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxOC8xMS8yMDIyIDEyOjU0LCBKYW4g QmV1bGljaCB3cm90ZToNCj4+PiBPbiAxOC4xMS4yMDIyIDEzOjMzLCBBbmRyZXcgQ29vcGVyIHdy b3RlOg0KPj4+PiBPbiAxOC8xMS8yMDIyIDEwOjMxLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+ IExpbnV4J2VzIHJlbGF0aXZlbHkgbmV3IHVzZSBvZiBIVk1PUF9zZXRfZXZ0Y2huX3VwY2FsbF92 ZWN0b3IgaGFzDQo+Pj4+PiBleHBvc2VkIGEgcHJvYmxlbSB3aXRoIHRoZSBtYXJraW5nIG9mIHRo ZSByZXNwZWN0aXZlIHZlY3RvciBhcw0KPj4+Pj4gcGVuZGluZzogRm9yIHF1aXRlIHNvbWUgdGlt ZSBMaW51eCBoYXMgYmVlbiBjaGVja2luZyB3aGV0aGVyIGFueSBzdGFsZQ0KPj4+Pj4gSVNSIG9y IElSUiBiaXRzIHdvdWxkIHN0aWxsIGJlIHNldCB3aGlsZSBwcmVwYXJpbmcgdGhlIExBUElDIGZv ciB1c2UuDQo+Pj4+PiBUaGlzIGNoZWNrIGlzIG5vdyB0cmlnZ2VyaW5nIG9uIHRoZSB1cGNhbGwg dmVjdG9yLCBhcyB0aGUgcmVnaXN0cmF0aW9uLA0KPj4+Pj4gYXQgbGVhc3QgZm9yIEFQcywgaGFw cGVucyBiZWZvcmUgdGhlIExBUElDIGlzIGFjdHVhbGx5IGVuYWJsZWQuDQo+Pj4+Pg0KPj4+Pj4g SW4gc29mdHdhcmUtZGlzYWJsZWQgc3RhdGUgYW4gTEFQSUMgd291bGQgbm90IGFjY2VwdCBhbnkg aW50ZXJydXB0DQo+Pj4+PiByZXF1ZXN0cyBhbmQgaGVuY2Ugbm8gSVJSIGJpdCB3b3VsZCBuZXds eSBiZWNvbWUgc2V0IHdoaWxlIGluIHRoaXMNCj4+Pj4+IHN0YXRlLiBBcyBhIHJlc3VsdCBpdCBp cyBhbHNvIHdyb25nIGZvciB1cyB0byBtYXJrIHRoZSB1cGNhbGwgdmVjdG9yIGFzDQo+Pj4+PiBo YXZpbmcgYSBwZW5kaW5nIHJlcXVlc3Qgd2hlbiB0aGUgdkxBUElDIGlzIGluIHRoaXMgc3RhdGUu DQo+Pj4+IEkgYWdyZWUgd2l0aCB0aGlzLg0KPj4+Pg0KPj4+Pj4gVG8gY29tcGVuc2F0ZSBmb3Ig dGhlICJlbmFibGVkIiBjaGVjayBhZGRlZCB0byB0aGUgYXNzZXJ0aW9uIGxvZ2ljLCBhZGQNCj4+ Pj4+IGxvZ2ljIHRvIChjb25kaXRpb25hbGx5KSBtYXJrIHRoZSB1cGNhbGwgdmVjdG9yIGFzIGhh dmluZyBhIHJlcXVlc3QNCj4+Pj4+IHBlbmRpbmcgYXQgdGhlIHRpbWUgdGhlIExBUElDIGlzIGJl aW5nIHNvZnR3YXJlLWVuYWJsZWQgYnkgdGhlIGd1ZXN0Lg0KPj4+PiBCdXQgdGhpcywgSSBkb24n dCB0aGluayBpcyBhcHByb3ByaWF0ZS4NCj4+Pj4NCj4+Pj4gVGhlIHBvaW50IG9mIHJhaXNpbmcg b24gZW5hYmxlIGlzIGFsbGVnZWRseSB0byB3b3JrIGFyb3VuZCBzZXR1cCByYWNlDQo+Pj4+IGNv bmRpdGlvbnMuwqAgSSdtIHVuY29udmluY2VkIGJ5IHRoaXMgcmVhc29uaW5nLCBidXQgaXQgaXMg d2hhdCBpdCBpcywNCj4+Pj4gYW5kIHRoZSBzdGF0ZWQgYmVoYXZpb3VyIGlzIHRvIHJhaXNlIHRo ZXJlIGFuZCB0aGVuLg0KPj4+Pg0KPj4+PiBJZiBhIGd1ZXN0IGVuYWJsZXMgZXZ0Y2huIHdoaWxl IHRoZSBMQVBJQyBpcyBkaXNhYmxlZCwgdGhlbiB0aGUNCj4+Pj4gaW50ZXJydXB0IGlzIGxvc3Qu wqAgTGlrZSBldmVyeSBvdGhlciBpbnRlcnJ1cHQgaW4gYW4geDg2IHN5c3RlbS4NCj4+PiBFZGdl IHRyaWdnZXJlZCBvbmVzIHlvdSBtZWFuLCBJIHN1cHBvc2UsIGJ1dCB5ZXMuDQo+PiBGb3IgSU8t QVBJQyBzeXN0ZW1zLCB5b3UgbW9zdGx5IGxvc2UgbGluZSBpbnRlcnJ1cHRzIHRvbywgZG9uJ3Qg eW91Pw0KPj4NCj4+IFRoZSBsaW5lIHdpbGwgcmVtYWluIHBlbmRpbmcgYXQgdGhlIElPLUFQSUMs IGJ1dCBub3RoaW5nIGluIHRoZSBzeXN0ZW0NCj4+IHdpbGwgdW53ZWRnZSB1bnRpbCBzb21lb25l IHBvbGxzIHRoZSBJTy1BUElDLg0KPj4NCj4+IEVpdGhlciB3YXkuLi4NCj4+DQo+Pj4+IEkgZG9u J3QgdGhpbmsgdGhlcmUgaXMgYW55IGNyZWRpYmxlIHdheSBhIGd1ZXN0IGtlcm5lbCBhdXRob3Ig Y2FuIGV4cGVjdA0KPj4+PiB0aGUgd2VpcmQgZXZ0Y2huIGVkZ2VjYXNlIHRvIHdhaXQgZm9yIGFu IGFyYml0cmFyeSBwb2ludCBpbiB0aGUgZnV0dXJlLA0KPj4+PiBhbmQgaXQncyBhIGNvcm5lciBj YXNlIHRoYXQgSSB0aGluayBpcyB3b3J0aCBub3Qga2VlcGluZy4NCj4+PiBXZWxsIC0gZGlkIHlv dSBsb29rIGF0IDdiNWI4Y2E3ZGZmZCAoIng4Ni91cGNhbGw6IGluamVjdCBhIHNwdXJpb3VzIGV2 ZW50DQo+Pj4gYWZ0ZXIgc2V0dGluZyB1cGNhbGwgdmVjdG9yIiksIHJlZmVyZW5jZWQgYnkgdGhl IEZpeGVzOiB0YWc/IFRoZSBpc3N1ZSBpcw0KPj4+IHRoYXQgd2l0aCBldnRjaG5fdXBjYWxsX3Bl bmRpbmcgb25jZSBzZXQsIHRoZXJlIHdvdWxkIG5ldmVyIGFnYWluIGJlIGENCj4+PiBub3RpZmlj YXRpb24uDQo+PiBPaywgc28gd2UgZG8gbmVlZCB0byBkbyBzb21ldGhpbmcuDQo+Pg0KPj4+ICBT byBpZiB3aGF0IHlvdSBzYXkgaXMgdG8gYmUgdGhlIG1vZGVsIHdlIGZvbGxvdywgdGhlbiB0aGF0 DQo+Pj4gZWFybGllciBjaGFuZ2Ugd2FzIHBlcmhhcHMgd3JvbmcgYXMgd2VsbC4gSW5zdGVhZCBp dCBzaG91bGQgdGhlbiBoYXZlDQo+Pj4gYmVlbiBhIGd1ZXN0IGNoYW5nZSAoYXMgYWxzbyBpbXBs aWNpdCBmcm9tIHlvdXIgcmVwbHkpIHRvIGNsZWFyDQo+Pj4gZXZ0Y2huX3VwY2FsbF9wZW5kaW5n IGFmdGVyIHZDUFUgaW5mbyByZWdpc3RyYXRpb24gKHRoZXJlKSBvciBMQVBJQw0KPj4+IGVuYWJs aW5nIChoZXJlKSwgcGVyaGFwcyBieSB3YXkgb2YgIm1hbnVhbGx5IiBpbnZva2luZyB0aGUgaGFu ZGxpbmcgb2YNCj4+PiB0aGF0IHBlbmRpbmcgZXZlbnQsIG9yIGJ5IGlzc3VpbmcgYSBzZWxmLUlQ SSB3aXRoIHRoYXQgdmVjdG9yLg0KPj4+IEVzcGVjaWFsbHkgdGhlIExBUElDIGVuYWJsaW5nIGNh c2Ugd291bGQgdGhlbiBiZSB5ZXQgYW5vdGhlciBYZW4tc3BlY2lmaWMNCj4+PiBvbiBhIGd1ZXN0 IGNvZGUgcGF0aCB3aGljaCBiZXR0ZXIgd291bGRuJ3QgaGF2ZSB0byBiZSBhd2FyZSBvZiBYZW4u IA0KPj4gV2l0aG91dCB0cnlpbmcgdG8gcHJlc2NyaWJlIGhvdyB0byBmaXggdGhpcyBzcGVjaWZp YyBpc3N1ZSwgd2hlcmV2ZXINCj4+IHBvc3NpYmxlIHdlIHNob3VsZCBiZSB0cnlpbmcgdG8gbGlt aXQgdGhlIFhlbi1pc21zIGZyb20gbm9uLVhlbiBhcmVhcy7CoA0KPj4gVGhlcmUncyBhIHdob2xl IGxvdCBvZiBwb29ybHkgZGVzY3JpYmVkIGFuZCBzdXJwcmlzaW5nIGJlaGF2aW91cnMgd2hpY2gN Cj4+IGhhdmUgbm90IHN0b29kIHRoZSB0ZXN0IG9mIHRpbWUuDQo+Pg0KPj4gSW4gdGhpcyBjYXNl LCBpdCBzZWVtcyB0aGF0IHdlIGhhdmUgeWV0IGFub3RoZXIgeDg2IFBWLWlzbSB3aGljaCBoYXNu J3QNCj4+IHRyYW5zbGF0ZWQgd2VsbCB4ODYgSFZNLsKgIFNwZWNpZmljYWxseSwgd2UncmUgdHJ5 aW5nIHRvIG92ZXJsYXkgYW4NCj4+IGVudGlyZWx5IHNoYXJlZC1tZW1vcnkgKGFuZCBkZWxheWVk IHJldHVybi10by1ndWVzdCkgaW50ZXJydXB0DQo+PiBjb250cm9sbGVyIG9udG8gb25lIHdoaWNo IGlzIHByb3Blcmx5IGNvbnN0cnVjdGVkIHRvIGhhbmRsZSBldmVudHMgaW4NCj4+IHJlYWx0aW1l Lg0KPj4NCj4+DQo+PiBJIGV2ZW4gZ290IGFzIGZhciBhcyB3cml0aW5nIHRoYXQgbWF5YmUgbGVh dmluZyBpdCBhcy1pcyB3YXMgdGhlIGJlc3QNCj4+IG9wdGlvbiAocHJpbmNpcGxlIG9mIGxlYXN0 IHN1cnByaXNlIGZvciBYZW4gZGV2ZWxvcGVycyksIGJ1dCBvdXINCj4+ICJmcmllbmQiIGFwaWMg YWNjZWxlcmF0aW9uIHN0cmlrZXMgYWdhaW4uDQo+Pg0KPj4gWGVuIGRvZXNuJ3QgYWx3YXlzIGdl dCBhIFZNRXhpdCB3aGVuIHRoZSBndWVzdCBjbGVhcnMgU1dfRElTQUJMRSwNCj4+IGJlY2F1c2Ug bWljcm9jb2RlIG1heSBoYXZlIGFjY2VsZXJhdGVkIGl0Lg0KPiBCdXQgYXMgcGVyICJBUElDLVdy aXRlIEVtdWxhdGlvbiIgaW4gdGhlIFNETSB3ZSdkIHN0aWxsIGdldCBhbiBBUElDLXdyaXRlDQo+ IFZNIGV4aXQuDQoNCkludGVsIGlzbid0IHRoZSBvbmx5IGFjY2VsZXJhdGVkIGltcGxlbWVudGF0 aW9uLCBhbmQgdGhlcmUgZnV0dXJlDQpkZXRhaWxzIG5vdCBpbiB0aGUgcHVibGljIGRvY3MuDQoN ClRoZXJlIHdpbGwgYmUgYW4gaW1wbGVtZW50YXRpb24gd2Ugd2lsbCB3YW50IHRvIHN1cHBvcnQg d2hlcmUgWGVuDQpkb2Vzbid0IGdldCBhIHZtZXhpdCBmb3IgYSB3cml0ZSB0byBTUElWLg0KDQo+ IElmIHdlIGRpZG4ndCwgaG93IHdvdWxkIG91ciBpbnRlcm5hbCBhY2NvdW50aW5nIG9mIEFQSUMg ZW5hYmxlZA0KPiBzdGF0ZSAoVkxBUElDX1NXX0RJU0FCTEVEKSB3b3JrPw0KDQpJdCBkb2Vzbid0 Lg0KDQpPbmUgb2YgbWFueSBwcm9ibGVtcyBvbiB0aGUgImtub3duIGVycm9ycyIgbGlzdCBmcm9t IGFuIGluY29tcGxldGUNCm9yaWdpbmFsIGF0dGVtcHQgdG8gZ2V0IGFjY2VsZXJhdGlvbiB3b3Jr aW5nLg0KDQpUaGVyZSdzIG5vIGdvb2QgcmVhc29uIHRvIGNhY2hlIHRob3NlIGRpc2FibGVzIGlu IHRoZSBmaXJzdCBwbGFjZSAoYm90aA0KYXJlIGJvdGggdHJpdmlhbGx5IGF2YWlsYWJsZSBmcm9t IG90aGVyIHBvc2l0aW9ucyBpbiBtZW1vcnkpLCBhbmQNCmNvcnJlY3RuZXNzIHJlYXNvbnMgbm90 IHRvLg0KDQo+ICBBbmQgdGhlIG5laWdoYm9yaW5nICh0byB3aGVyZSBJJ20gYWRkaW5nDQo+IHRo ZSBuZXcgY29kZSkgcHRfbWF5X3VubWFza19pcnEoKSBjYWxsIHRoZW4gYWxzbyB3b3VsZG4ndCBv Y2N1ci4NCj4NCj4gSSdtIGFjdHVhbGx5IHByZXR0eSBzdXJlIHdlIGRvIHRvbyBtdWNoIGluIHRo aXMgY2FzZSAtIGluIHBhcnRpY3VsYXIgbm9uZQ0KPiBvZiB0aGUgdmxhcGljX3NldF9yZWcoKSBz aG91bGQgYmUgbmVjZXNzYXJ5LiBCdXQgd2UgY2VydGFpbmx5IGNhbid0IGdldA0KPiBhd2F5IHdp dGggZG9pbmcgbm90aGluZywgYW5kIGhlbmNlIHdlIGRlcGVuZCBvbiB0aGF0IFZNIGV4aXQgdG8g YWN0dWFsbHkNCj4gb2NjdXIuDQoNCldlIG11c3QgZG8gZXhhY3RseSBhbmQgb25seSB3aGF0IHJl YWwgaGFyZHdhcmUgZG9lcywgc28gdGhhdCB0aGUgc3RhdGUNCmNoYW5nZXMgZW11bGF0ZWQgYnkg WGVuIGFyZSBpZGVudGljYWwgdG8gdGhvc2UgYWNjZWxlcmF0ZWQgYnkgbWljcm9jb2RlLg0KDQpP dGhlciB0aGFuIHRoYXQsIEkgcmVhbGx5IHdvdWxkbid0IG1ha2UgYW55IHByZXN1bXB0aW9ucyBh Ym91dCB0aGUNCmV4aXN0aW5nIHZMQVBJQyBsb2dpYyBiZWluZyBjb3JyZWN0Lg0KDQpJdCBpcywg YXQgYmVzdCwgZW5vdWdoIG9mIGFuIGFwcHJveGltYXRpb24gdG8gdGhlIHNwZWMgZm9yIG1ham9y IE9TZXMgdG8NCmZ1bmN0aW9uLCB3aXRoIG11bHRpcGxlIGtub3duIGJ1Z3MgYW5kIG5vIGNvaGVy ZW50IHRlc3RpbmcuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Mon Nov 21 12:34:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 12:34:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446596.702246 (Exim 4.92) (envelope-from ) id 1ox60b-0005JT-VU; Mon, 21 Nov 2022 12:34:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446596.702246; Mon, 21 Nov 2022 12:34:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox60b-0005JM-Sd; Mon, 21 Nov 2022 12:34:45 +0000 Received: by outflank-mailman (input) for mailman id 446596; Mon, 21 Nov 2022 12:34:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox60a-0005JG-EJ for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 12:34:44 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on061e.outbound.protection.outlook.com [2a01:111:f400:fe0c::61e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id df963846-6998-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 13:34:43 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7939.eurprd04.prod.outlook.com (2603:10a6:20b:241::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 12:34:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 12:34:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df963846-6998-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WSKnNg0NFbBpQIgP59srSBup+GsP0OvnSctiNK1/jR4pqMS7d0epTQx9J8EbstVJMxNt5Me8P5K3Gl5Bbk03VQOR2oq9OoW7k7jneFdflWJijUSzgsg41rNgVKBLt8IwtxjTa2jlbyogLYAvc9Bg9fnOVGefbAqr9r0744ShLHzMCPxnpkoYpkfff2URp+YRMGdLmN0vv3iISDOU0KLbi+iSsrJ7aYjpjjMDfghZgFu0R35YyXelR7z6/SSu7NVbRgDbYZNDxBhhFo7pd4eAB519r8L125SqtNl/Tw14MhjCeJP9ppUucXmFAsIR7Rg2yglxYAVnlV8V419IPI1rBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vgMQQ1uffSE9xiLv/nTQb1rO9grcF4e+l3+hkZFc1fc=; b=ZmdYskC7uLzEnxTKnPE41A8QQahq7z0RlJ8CCOJeOBXHwjQ6Ylz1ChlXk20bkKZEjPtXv2z0GkKGVeOyayrS/qC8pI9re3xlqsLr5QIRSZW42RtN3PVcwIXgUoF/gMio/pbR8pdkMOohD60U4Qe4GXkW3XtXoKC4oZdmhfNyUUzEqn7hYoZj4PseUxP9t21jTejAQatbjsrvZl2MpNQUVR5Mi0KPYqQRn5/4EAY7uO/rONSejQEbyhZRQI9hiXmtjyNfkUidUdlLEKcwjrixhOcXdgumlucaVqqn5pbEvPZzwdTmVt6noDVhGxIkROuuHznMIg6HcrbuseLfuY52EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vgMQQ1uffSE9xiLv/nTQb1rO9grcF4e+l3+hkZFc1fc=; b=A1D0ONP2eNFAIfQ12JiUMS/wNPvJpzU1mL00DxSPUkPkS3llskknOqNiQM7sL83au509zW2D93hSrBEoFyvGlZKbxOvwkt20aU11x+x1BAVgW2D1Luba9JAjc1KEtBTzHgZFsSfsImiHZPp4LqcnfcW0CKXxH1KcQlfVatqUcydk68GtSJgb60EysrwM/VgrSH0fNOab3oPjmtwROF6Ics3NUZrAl3v91B2CLUHIE/n4oXSNvgEYekG9xBlLhlRTsl64IsOy56NzJfmUk0pJD9RXMIlH1o9NI/DhJ0iGSbfXNG9Sxg+ef2UDxFeSJlLru4TbbwgLsmh7hK3pNc8pkw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <33a005bf-0596-c624-0e70-077a450ac2ae@suse.com> Date: Mon, 21 Nov 2022 13:34:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , Paul Durrant , "xen-devel@lists.xenproject.org" References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> <5a2df843-1acd-ad78-baff-e47befd0703c@citrix.com> <878e635f-b116-3580-945f-f8acb711a5bc@suse.com> <69507b8d-1f31-39fb-7469-e240fbfdde44@citrix.com> From: Jan Beulich In-Reply-To: <69507b8d-1f31-39fb-7469-e240fbfdde44@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0140.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7939:EE_ X-MS-Office365-Filtering-Correlation-Id: b087305a-4c87-4628-9dba-08dacbbcc288 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G2IAPvZxTqE/GFM0eIgSprPyKIsNRh3dlM6POmMaky3J+PtqvqVA5mWRjGQvouwgfG6/lKWWOBjAjgdVgYNL1Wm7lx+jyRX2JWd9bV90rpnbQtozaVRzVNf7D2YTdl0MzO/URePGwvDj7JGehUsMcK2DJi5Q3TQKjMu3edgZZG5ecxQNP9/1PG86b2QrE9FRHVpEifNbDsjUHiLQ7B3wrn2lpGCkR7LcroprggtBFeVp9AxZqdve7G/B/AAKQXiWzaeLI4yEwSbJn6HC9aq3NnM1Wi3icmRd/tWOmRyR0rOAt3yjCR4LjG4f70SX7wqovjsa4lLxCSAG8d8EEDg6Ba3IgG9ydrQVdOlbmCro9iAbq4a2ceGM0Zy0LXp6KOYdYmprovgmzkeTGhi3cgI/+wuluguQmMN8oL5ljwm1XECe/0wLj+O4Zp2mhOocdEx9NnpHkvJoROl1E25067TfMUCKBGV6miHNGkzARNgQzNRaA8vs5AKXf2mIz3vm1+iQKh/UIFkB5HQIUpa1XVexcwc+x0qiccw1hAezL8+E8NP2Wu6kGMNf5DXzoMh8G/J1SwiZ2I8A/uMW6StzFZvF4dD8d2JrR4DxPWu6A6NQng+/wCnN/WqQ0s3mWFPD9Ux0AKT16BSt/XOaS4LKE0m2P06Q2ry/U4ZlL/O2ISvxSc7f/IGW3wOv1ozUA0k5rrnS3VGnFCk50oCNskrLXXXaonYWm9++KiWVcVmM8WD8cec= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199015)(5660300002)(54906003)(6506007)(6916009)(316002)(53546011)(66476007)(8676002)(4326008)(36756003)(66946007)(66556008)(41300700001)(6512007)(26005)(2616005)(8936002)(186003)(38100700002)(2906002)(83380400001)(31696002)(86362001)(31686004)(6486002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0NoblJycHRHVm1PY1hPYTd3WTRraDVIUHNPaVZqU09FZG5WMHVKc3VFT3VD?= =?utf-8?B?RG1rcGc1QStRQXZWdSs5MDQ5M3NVNzdMM01MQ1lCR2lRLzNKY09tcFJvQmlF?= =?utf-8?B?K1Q4dXRyVkhTc09xeFBCNmNvaTZoMFBtODMxNjR3cEtCM016cWtIOFc5TUF2?= =?utf-8?B?OTVJSkcrWUhpbkVTbVNrbEJmaWlIaWNGMForeVE3bG5tMjJvQk5Pdy9vY0NL?= =?utf-8?B?aVVGLzltZ2RPcXJvZDNtUk1XczNZUUtoV1U3RFg0MWJaa2kydEhwZGhQalhJ?= =?utf-8?B?VnFQc0E0VDYyRzIyUW1MenRBV2ZxSFJxcHhYSlpkK0ZDK3ZtelZCaTBvVUlG?= =?utf-8?B?RVVMV1R4Qms1Wnc1QU9CaHlMeFBCSlNqU0FZQnRzVzhXZjhGNmtOQXpnNk5E?= =?utf-8?B?L0tMcUZPcHZjTnNmc0JrcGp3ZHVwQllzVVUyT2VXM1NYZWpjY0dXM0ErckNP?= =?utf-8?B?cTVEQkVRWUJ4UWZTWHltR0UxalcrejVPQmZ6Y2dtUmRGTGdYclFVSExoSWV6?= =?utf-8?B?WVg1cklGOExFbWpsZ3dqV2RnZVh2b3MzWkVBOWFhcUdqNFlKaDlJWDFRcG5Q?= =?utf-8?B?cTJkS0hqb1lYcG9pcm54d0FzeFNDM1VySzJQLzBYOWdrbElSRk1wbHR1eld6?= =?utf-8?B?MFNPMmlFeUpiUS9VSlhQOXc5c2hWVmRYTFpUYWZmVlgzSXNuVVppL0dqZU5p?= =?utf-8?B?dGhDWkswaXEwclVCdXVaSXFHWDVvSHdLa0trYnRBRVk1ZElGNWxhSTJ1eUhz?= =?utf-8?B?RXhnbGpZWGVzUzRkQnFITWJxYWI1dlJkZVdtN3NpRXoxYUlXTE1PRUZaZ3l4?= =?utf-8?B?NlloMlZlWk1MOXZ6QkVxZ3FublBTN3FhYjBuOUlvSmZYMFJ1SjJJMTUzWFhO?= =?utf-8?B?VmhXci9xZktCUnpDV3YvSFVHaFJkRmd5TnJ1b2l5dUVkdlU3WlprcGgvYUtu?= =?utf-8?B?eXJ2RVJGZjFCRUNxSnZkK0Zld2lHUUpVbzQ3dGgwVmJXVkJReHJScW9GMEZm?= =?utf-8?B?U25DVlZiRXo3VTNCMjJUc3pNaFdtR3NKV1JMTy8xcjJqald6dUhBK2VhN0dU?= =?utf-8?B?N1hodUxpWm1mYlQxamRZOFRhTldudXYyUlJ0eVh4NFhBdmZybURuMkYwTkVD?= =?utf-8?B?R2ZvZHNqdm5EaUw0ZGNYN0FlZDc5Z1pnUzdLWDNLbkQydmFqOGdwOWVYeE93?= =?utf-8?B?RStjd2JTV2F4dEZmeE1JNDg2VjlPaVBCTWJPQndFeDJhVXVFUEwwdFM0dURW?= =?utf-8?B?YTFXWHFjVHRsckdJbzQ5aVNocWNNeGtNWkg1c3dORWdESmNRSmttZGVKdjVx?= =?utf-8?B?R0tqUzB3Zk1JenBMdEFac2pMV3k0QURoOUN6d3JZOHRZUUhyallWeW5OVkl4?= =?utf-8?B?OXlHNzR1NFRPM0NFV290a0hXUTFhSFBDd2FpczR1NUdRUFUxODFrMU9RZlRI?= =?utf-8?B?ZVBURitSazNzb1REbXFLRU1PRmN3K1BZMldUOWNPakkzL2pvUk1mOWJxN3hM?= =?utf-8?B?ZXVXdXluNWpTUkMxeklmem1GVWFHZy93NXF6NW02ZjNRUEVKMTBPd1Bvai9j?= =?utf-8?B?SHovYko4dDdvREdaQ2M0S3NGcFdrbDhEZG9OclJjV3doeHlWdGw5cGdxQWtj?= =?utf-8?B?RzlWd3lYQjVyWmh1RkdOeWpNZEdBYlBVVHk0eUU0U1NaUXRzdGZiOXlhTFY4?= =?utf-8?B?Q01rNjQ5SUxWK0dZa29iMEtyS2k0ejZVa1BFTDZEb2owOGhwM2FVOXhiVFZm?= =?utf-8?B?c215empwUDJ4Tnk0eHBKU2lqb2MydFhWSUoyVUFnWlNkQ3B4dVRFTU1qYnkv?= =?utf-8?B?RGxCR0dyZkRvYzJNWStka00raWg0Y2h0WWUyM3ZmSXRWUUhQZFZuL24yVERa?= =?utf-8?B?WXVDWlpKOWQzaFN6eVllSGo4aGpibWdkaXhlN0F2VmExU1grZW5SS0JKS1Bu?= =?utf-8?B?MW1mMVNzRjJDenJuaDVQNEtQVTd6bE1iWlVxNzZwSGV0eEVVWDUvd0N5NjFB?= =?utf-8?B?MDZkQVlTRTVkM09qdjlQaDZQZ08vVVpTaGhXYlhQOGdzZU9raWZQS1dXbXE1?= =?utf-8?B?OFNKVWUza09lNmdsUlZ0akJ3TmtYV29acHowR3h3ZEhiOFlEVFFuZE9OTUtB?= =?utf-8?Q?aHGC1PxD25+VenlkmKYVmx+uy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b087305a-4c87-4628-9dba-08dacbbcc288 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 12:34:40.5463 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I61HqU/H/uS5xw5FTW2yVvhBN8Sbi4fmWaKPLGcLzt81ieB7cqFO9yLXe/yCxNoOJOcTUlkm/DHqZn5WNndobA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7939 On 21.11.2022 13:23, Andrew Cooper wrote: > On 21/11/2022 08:56, Jan Beulich wrote: >> On 18.11.2022 15:27, Andrew Cooper wrote: >>> On 18/11/2022 12:54, Jan Beulich wrote: >>>> On 18.11.2022 13:33, Andrew Cooper wrote: >>>>> On 18/11/2022 10:31, Jan Beulich wrote: >>>>>> Linux'es relatively new use of HVMOP_set_evtchn_upcall_vector has >>>>>> exposed a problem with the marking of the respective vector as >>>>>> pending: For quite some time Linux has been checking whether any stale >>>>>> ISR or IRR bits would still be set while preparing the LAPIC for use. >>>>>> This check is now triggering on the upcall vector, as the registration, >>>>>> at least for APs, happens before the LAPIC is actually enabled. >>>>>> >>>>>> In software-disabled state an LAPIC would not accept any interrupt >>>>>> requests and hence no IRR bit would newly become set while in this >>>>>> state. As a result it is also wrong for us to mark the upcall vector as >>>>>> having a pending request when the vLAPIC is in this state. >>>>> I agree with this. >>>>> >>>>>> To compensate for the "enabled" check added to the assertion logic, add >>>>>> logic to (conditionally) mark the upcall vector as having a request >>>>>> pending at the time the LAPIC is being software-enabled by the guest. >>>>> But this, I don't think is appropriate. >>>>> >>>>> The point of raising on enable is allegedly to work around setup race >>>>> conditions.  I'm unconvinced by this reasoning, but it is what it is, >>>>> and the stated behaviour is to raise there and then. >>>>> >>>>> If a guest enables evtchn while the LAPIC is disabled, then the >>>>> interrupt is lost.  Like every other interrupt in an x86 system. >>>> Edge triggered ones you mean, I suppose, but yes. >>> For IO-APIC systems, you mostly lose line interrupts too, don't you? >>> >>> The line will remain pending at the IO-APIC, but nothing in the system >>> will unwedge until someone polls the IO-APIC. >>> >>> Either way... >>> >>>>> I don't think there is any credible way a guest kernel author can expect >>>>> the weird evtchn edgecase to wait for an arbitrary point in the future, >>>>> and it's a corner case that I think is worth not keeping. >>>> Well - did you look at 7b5b8ca7dffd ("x86/upcall: inject a spurious event >>>> after setting upcall vector"), referenced by the Fixes: tag? The issue is >>>> that with evtchn_upcall_pending once set, there would never again be a >>>> notification. >>> Ok, so we do need to do something. >>> >>>> So if what you say is to be the model we follow, then that >>>> earlier change was perhaps wrong as well. Instead it should then have >>>> been a guest change (as also implicit from your reply) to clear >>>> evtchn_upcall_pending after vCPU info registration (there) or LAPIC >>>> enabling (here), perhaps by way of "manually" invoking the handling of >>>> that pending event, or by issuing a self-IPI with that vector. >>>> Especially the LAPIC enabling case would then be yet another Xen-specific >>>> on a guest code path which better wouldn't have to be aware of Xen. >>> Without trying to prescribe how to fix this specific issue, wherever >>> possible we should be trying to limit the Xen-isms from non-Xen areas.  >>> There's a whole lot of poorly described and surprising behaviours which >>> have not stood the test of time. >>> >>> In this case, it seems that we have yet another x86 PV-ism which hasn't >>> translated well x86 HVM.  Specifically, we're trying to overlay an >>> entirely shared-memory (and delayed return-to-guest) interrupt >>> controller onto one which is properly constructed to handle events in >>> realtime. >>> >>> >>> I even got as far as writing that maybe leaving it as-is was the best >>> option (principle of least surprise for Xen developers), but our >>> "friend" apic acceleration strikes again. >>> >>> Xen doesn't always get a VMExit when the guest clears SW_DISABLE, >>> because microcode may have accelerated it. >> But as per "APIC-Write Emulation" in the SDM we'd still get an APIC-write >> VM exit. > > Intel isn't the only accelerated implementation, and there future > details not in the public docs. > > There will be an implementation we will want to support where Xen > doesn't get a vmexit for a write to SPIV. I see. >> If we didn't, how would our internal accounting of APIC enabled >> state (VLAPIC_SW_DISABLED) work? > > It doesn't. > > One of many problems on the "known errors" list from an incomplete > original attempt to get acceleration working. > > There's no good reason to cache those disables in the first place (both > are both trivially available from other positions in memory), and > correctness reasons not to. > >> And the neighboring (to where I'm adding >> the new code) pt_may_unmask_irq() call then also wouldn't occur. >> >> I'm actually pretty sure we do too much in this case - in particular none >> of the vlapic_set_reg() should be necessary. But we certainly can't get >> away with doing nothing, and hence we depend on that VM exit to actually >> occur. > > We must do exactly and only what real hardware does, so that the state > changes emulated by Xen are identical to those accelerated by microcode. > > Other than that, I really wouldn't make any presumptions about the > existing vLAPIC logic being correct. > > It is, at best, enough of an approximation to the spec for major OSes to > function, with multiple known bugs and no coherent testing. But can we leave resolving of the wider issue then separate, and leave the change here as it presently is? Yes, mimic-ing the same behavior later may be "interesting", but if we can't achieve consistent behavior with yet more advanced acceleration, maybe we simply can't use that (perhaps until a complete overhaul of everything involved in LAPIC handling, possibly including a guest side indicator that they're happy without the extra signaling, at which point that yet-more-advanced acceleration could then be enabled for that guest). Otherwise - do you have any suggestion as to alternative logic which I might use in this patch? Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 21 12:42:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 12:42:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446602.702257 (Exim 4.92) (envelope-from ) id 1ox67e-0006uu-Qx; Mon, 21 Nov 2022 12:42:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446602.702257; Mon, 21 Nov 2022 12:42:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox67e-0006un-OA; Mon, 21 Nov 2022 12:42:02 +0000 Received: by outflank-mailman (input) for mailman id 446602; Mon, 21 Nov 2022 12:42:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox67c-0006ug-LU for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 12:42:00 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2060e.outbound.protection.outlook.com [2a01:111:f400:fe12::60e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e3a0648d-6999-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 13:41:59 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8526.eurprd04.prod.outlook.com (2603:10a6:102:211::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 12:41:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 12:41:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3a0648d-6999-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BnDEY7yqNH7Z+nECNdBSEnqJ/o4AZ5M90Lt/AQeyORCk2xClWwmFNZoFKmqU8LmF4k7+V4o4/N5XLz6Yw9T+fWN1BQjaZxlemX5cw1N6Gc1plbNpNohI2CJLRkpd/RGGIL7SGLgZFi3kVJYRM4VzfPWQQR3+r3bMutTAtn5DM1lSRPz+eHwWKBvuZUqWU+oi4oIbQSds/O7TzWCchc375EsfHkLzsnoUcUiHQkM9VF9NQl7rABctcUdu3Loq9VMOUkWQQD0aUB1dM7dlnlV63HrPyW2GHfXDdnLcZWaZTNIOJ/6ZO2GW5nvJCBQbr2VCE55XrmLQzIWdUbTHA/Be3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XEx6ECnOSFnF6BliBWg13i61lRLETnt3SNgJJ4neH6E=; b=Ztf1vj7Ae5JylqmgkF4TiYFvJgrkH6F+nuK8kWNOqtZmG/U3sZ5/fqBPoHyGids6RBTq4s9c95r+514emcNIkdSMUx8PiVse9h+9gMQfD2FRw+WmaRE70fEUyd/ToICNXScqlYqR6A9y4l7B9qrSJZh9YES4RGAUzyzNGi81PICwsBaEsQ7N6k4pFH0Vg5BGf5PidBEQWVCw3TD+fR2XUC2Cl2X40w2TKv0OetI6UdYgJQKx37P+QGTqi4Xf8QXniwjdM5QnDI3fn8GHtoX9KBI2fkCWfXQweD3yu75ZIy9VVeDyCYbpuTOdC2QESuvxFE0V91dlPq60DVUYEVfIhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XEx6ECnOSFnF6BliBWg13i61lRLETnt3SNgJJ4neH6E=; b=QGUZiK3rF7+cho/mMSmTw6nfyfC+u8pQ20KvvGH6vMoMGKGplQWtUrLL6geP5/VOzBDShNVJ6ZgmNmkMeD7RuOYBtpWp8LVGsjsekZg1sG8+maZtML0jaynboq3D03vQPTvUQVAsv9QhmX7esn0hJjsroyiKjqOmA/6MK/BlVrldGD7E7WdmdhcHGoRUPerzGKc85dA4LjO4vzozAA3ai+SkHrxgO5pFNGLNWEK83/6Fl/A/79YXCazFEEj4w5W62n/0hw5VQOwY39Tnj/HfTqi1GB5sIvGLNuUmFohcDFx+B6EQPfle3QEe1sSJYapuanUGX3rvqYnGmnXAqQgqkQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 21 Nov 2022 13:41:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Ping: [PATCH] Argo: don't obtain excess page references Content-Language: en-US From: Jan Beulich To: Christopher Clark Cc: "xen-devel@lists.xenproject.org" References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8526:EE_ X-MS-Office365-Filtering-Correlation-Id: 99569939-4ce7-4756-e8dd-08dacbbdc69d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ViTtUWdnuDvBsbrY+NYLMDGv2XTnhxRMe1IYOnmbcIpXn85Q6uk3RITPLe9SIOTBDUXzbDph76P23/3aLBdyNt8g+4zpHIPpZnSr2CVyR5N8esVCH+o3E1AQveaXjsFOI2yyKdaEM1UhYTt//Ql5cUirw0fQWkwLyzvKPorbsdWqn2xYZODenKbEe1rpMn2xi/IoxCKm1YpnpuXI5qWEDKxDOCdiFwD56PSltkUhmhNO6e6R41gEVe6TaPnXCaUXi437bsgTPmS+o9zUtwEXqJv4eea7J3cgWYG0QASWoJdLYTXxw1mXVyGEM22truiP5ibzPXmSvNoIs01diiR/CRDNABupk0rc/ZcNrpTjA9U2FxynbnjWfQCYwQ7er8jif7KbHh6m5xAf5K5e/Ckdt2pu9/9Xn3aP71XOP+LKabD1fFh7AompxRYrpxg/oEHhaGygOmWg//y5NwcQTrzdcpkrtZ0oDNBkJy3GpziXILD/4ALOxWK2T5eMg+TIrWzVEGaHpqsNNREDziqXVVu4DlDUPAMQZt1P2kwkr+s3MWqhp3y7FRNiyisit0xewd/aP2HABNA4oGjjqjqnKC5hNc6fZUB3jp9bOhQUUOQa5DZtRQ3BFhgJ7mCrQqaRWRvEbU+vqo9MEFWqIJKJWB/cwF3zTyNUfLJ4Mwpj2SWZjmncMjunVN7s4ZL17JMCDw0WqBnrQ2b8UJVD1ez77mRqStZ7mdFdFeqtyZ/3nzPBHGc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(366004)(136003)(396003)(346002)(376002)(451199015)(38100700002)(86362001)(31696002)(6506007)(53546011)(6666004)(316002)(5660300002)(186003)(2616005)(8676002)(6512007)(26005)(66476007)(4326008)(6916009)(478600001)(66946007)(6486002)(83380400001)(66556008)(8936002)(2906002)(41300700001)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUcxU3B1Y1ExUi9LdzJYYmtZaU0rSVFUbHZPUDR5b01OeHZROUU4alhIclY3?= =?utf-8?B?NlNvb2RqTjlJdUN4dS81TGZhcTErZTlOcCs1TWk5TmMwN2dNREpvMGZwcmhJ?= =?utf-8?B?ZXlwdWQzaXdGbEl6akRla0R6UXpBT0gvYndaQXpNSkt6amNUVERiWW9JYTNx?= =?utf-8?B?NFFpQXdRYTZJelAxd204R25vSEFpbVIvaFd3OCtvU2xYRVB1byt4VHg0SS83?= =?utf-8?B?K2ZXUzJFbDV5Vzg5RGtVV3dnZHRZbDBqVGpPN09aVzljcFJldUNvVkluTzl6?= =?utf-8?B?TDA5SEVNUmhEWTQ1UmwrQ2FwOWdSamd5SCtET3BJT2x0TlFReHl3Mk5yNVd3?= =?utf-8?B?LzJSUGtJZCthZVRPbUtodE1UQTh3bnZGSFdHR0NnR0w2K0x4QUllNEEyQ3Y0?= =?utf-8?B?UkpXb0Fqb1pURk1DeWNlZWdqdnExdTFjYXgvSTFRalJKbWFYZkg4MDhNVHJm?= =?utf-8?B?SUFMQ2tjTWY4UnIzaUJNd1pYZjQ2Vldwb2VYNXNtcFdObUVwZzd5Y0pxZ2lT?= =?utf-8?B?OWhJOEJoRWorT0dBbDh6NEhpenNYa2U1dzdsNDFlekc2czEwWll6dldNREwv?= =?utf-8?B?NS9uMnQ0K3pEU0FPRDB5OGRWSkJDaHR1RFY0b25uYWZOVlRPcEd2eVdEVktj?= =?utf-8?B?NGN5YVFoUDh1Y2s4R2NuUzVKc29IMkNOTHF0UTdyMytoc1VhQTJERUZVSlN2?= =?utf-8?B?NFZONjY5NnBoOW5yTTBkYjA4OGE0VmYvNVZseEdtSnUxOHYvZ0IzbXZOT2xF?= =?utf-8?B?K2lBalNBTHFQMndURGV0V25IOVZlaXljTjQrcC94RFVnUW9COUdsVG9SUi9n?= =?utf-8?B?VitsMjgwRjNnY1pDL2RsNmpwZnB3aG51TENzcHVsd0RVWm10WmZmUGlIOEVI?= =?utf-8?B?RkpKVTEzYmhjZDdaTUpNZjl2TXJ0cFYwNmdkNkhUaGNRMVVBTFBXZkVENHNZ?= =?utf-8?B?bjN5ekx3VGQvRDd3b0l1Zmh1Tm1jNUcrVFdUS3NIb0RPd01pZXJ4Tm8yNUMw?= =?utf-8?B?Zk94amJaemY0VmlGRnNIelVSUHdLamZxTTNaankwWmcxVzdyZGh2T1dpUlF5?= =?utf-8?B?QUJjV2U2bzF6WUJwaFRCVFpUYnpmcVY0cE9McWEzenNhL29Eajg5K1pXTVky?= =?utf-8?B?UDNzN0pmaEtwV21DQWVPdWY0eFZiMWNtL2VKT3JxUnNQR2xpU0pMWlpOaWFT?= =?utf-8?B?VGVGQldVN2ErYWhLeWsvQXJZcHdoalVJeG9paWpyU0J6NFhlS2JoNDdSdEJT?= =?utf-8?B?VzJKN3l4eGhxUHFrT3d3bEdqL1M3b0RDS1lHQ0JZOWc5RGIzbmJ2WkVSaXpn?= =?utf-8?B?eDFMZlVOaVBYcmJQM2hHZitZL09YNnZMczFESkl1Y1hhZHA0bndkc0Q1cFR5?= =?utf-8?B?aXhIMVlVdmcvbTZkVlpYQkVHOFVGZXN1U0JpdUU1SnlYckQxdExwd2VzSXNP?= =?utf-8?B?dENuRXM2VklwWjJzcGhZYUg5SE03YzRWdHErYnA3Tk5IdnV1S2xKWjRIZkZs?= =?utf-8?B?U0ZGYmhYb3FlYU5QTzZ6aTM1S0pvVDY1NjlmY00vSzMvQkIydWhkNFVGd1BO?= =?utf-8?B?MVlzSG1oT0srMGg3Y2Zaa3krYnoxc1VPZ3dZUUZxRHdtandsc1ZoSjBaSUU2?= =?utf-8?B?eVg1V3lSNTFUQnBaaEdoNFhhVEFZdTB4S1dFMjJtdUxIS0dXOEpCc2JIT1Nh?= =?utf-8?B?MDgyeHVySXBPaXdTRUpGTDVOQ3BsWWhLM2ZJQ1lKbzMzTUh2VjNjTU5oM1g3?= =?utf-8?B?cGxaeDk1NlVMQWx4dzZML25PZVp3Z0lZNXEyczNkT3l3SU1meGFBZWxjTGE1?= =?utf-8?B?QVdSTXFjcGJkUDVzMi9PM1dhZUFjZVV1ZnNESElFUjczWHZzNENsanZMbERV?= =?utf-8?B?eVFiMlArTU1waGNLa1F3WjBRaGVvUTBOQWxEa3o1dDFuZlJFUTNQWmFneW9s?= =?utf-8?B?bnpTY3FOK2Z5bmJCSU1JaWliR2c2eXNmMXRSZEprU010Wi83R04yR2VURHZo?= =?utf-8?B?WUQrVTVkSGJRdE80V0JHT0FnNm01ODVMNk5IOVZKMGlGU1h2VENlSWdLYzRV?= =?utf-8?B?TEcrWVBGTjg5U0dqWU8wZEREbFdGcW1rQWdyVlJSZnJsajNEYlJrSHdBUis3?= =?utf-8?Q?U4xlXJj6wxtkfevrNCbXGmWFF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99569939-4ce7-4756-e8dd-08dacbbdc69d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 12:41:56.9091 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9Gr3xuB28CycJLFIA1Vx3XimdBlHXCJ2grh32vV5mAdfzMLFUBQAbE6yHEBEJbNENbX4fZ14GBJRiQ0cKE3a4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8526 On 11.10.2022 11:28, Jan Beulich wrote: > find_ring_mfn() already holds a page reference when trying to obtain a > writable type reference. We shouldn't make assumptions on the general > reference count limit being effectively "infinity". Obtain merely a type > ref, re-using the general ref by only dropping the previously acquired > one in the case of an error. > > Signed-off-by: Jan Beulich Ping? > --- > I further question the log-dirty check there: The present P2M type of a > page doesn't really matter for writing to the page (plus it's stale by > the time it is looked at). Instead I think every write to such a page > needs to be accompanied by a call to paging_mark_dirty(). > > --- a/xen/common/argo.c > +++ b/xen/common/argo.c > @@ -1429,10 +1429,11 @@ find_ring_mfn(struct domain *d, gfn_t gf > ret = -EAGAIN; > #endif > else if ( (p2mt != p2m_ram_rw) || > - !get_page_and_type(page, d, PGT_writable_page) ) > + !get_page_type(page, PGT_writable_page) ) > ret = -EINVAL; > > - put_page(page); > + if ( unlikely(ret) ) > + put_page(page); > > return ret; > } > From xen-devel-bounces@lists.xenproject.org Mon Nov 21 14:02:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 14:02:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446619.702274 (Exim 4.92) (envelope-from ) id 1ox7Nd-00077t-Pa; Mon, 21 Nov 2022 14:02:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446619.702274; Mon, 21 Nov 2022 14:02:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7Nd-00077m-Mn; Mon, 21 Nov 2022 14:02:37 +0000 Received: by outflank-mailman (input) for mailman id 446619; Mon, 21 Nov 2022 14:02:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7Nc-00077g-TG for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 14:02:36 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20602.outbound.protection.outlook.com [2a01:111:f400:7d00::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2606bc7c-69a5-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 15:02:35 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6909.eurprd04.prod.outlook.com (2603:10a6:803:13d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Mon, 21 Nov 2022 14:02:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 14:02:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2606bc7c-69a5-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PkY9CRI/ZBJj+43CC5yEuSMdyRs5x5jxpg6wrnu+0PeGBMCw1jheQGQ5U7msP6BgxibLTDLrhcU16PbTPFl7SWA5yrXaGmTd0Xy8+BrwE9YGHzM6uwovyZBSW7HFPqwidj2inN1ucq0wqiNoubkU+lPDdILxVcgKO8smhnK6SSJ8yHEiO13LMarAQjsBB2JVWbUdKraVMFaXFdeMcImKA++hatxlp/TJx4D4UWk3ysHKZGb7igfLMq836CCtt3v095jkL6lbIO/VOFcE4xT+t7uGtfgkvuuPMVP6UiakxiWTPVcWPdn/bI0lVNgPJZjwEwlWdo//QWFchNHd2AdveA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IPGbfdI0s5RvrhldWpZ8LqzeGn10EJlf7jOZx4NJznk=; b=IkpKNQNEeTGxu7IvfjnwBH67qOoceh+8vLZhG8Sf66sGjZqBWUka+YkRhIxCj+M2TkZDEL0KCYxLd2uqu57zOgc6G+aFYRFndRkaoka2jAnUASA5AhZWSJPooB8sKbm0dmmllAeiq15vnZTGFkHPd9pXX7PihEyZUu5ccj7gkJ8q/Ck1uqefhI61NTrZsU2uNnZwVMj8rbjQzfIDmqA949nSWcMNuCNPZlK8ZNQY/yaR8xI5Tec8ZkWqPqsD/Tusdch9vjm1yzf1c4le3TMnnj708EvsdQ6+JWvck53MOuDQ5qqEJ0U+5t/V5lEhsFM8KTOo8au7Pd2HvUiwNyusYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IPGbfdI0s5RvrhldWpZ8LqzeGn10EJlf7jOZx4NJznk=; b=02zimt1lVuSDEoZQr9wxXkm8BsBxL0JYk2OuqPQqzEPOKAFRjGQiXzl6OqurXMk50atHy/kzTTTyqbEVvU21sb/GI/1eQ0sWMPRWLF5ktuttyll1dhGTPgVj2aGolxMxmAd/U5zs3D46ujTJi6/wcPw4Yi3g33Vkr8FXHXmYFNSwXpDglyiWyaoiwBJCOiATsrk8tGET1vWTCnd2xvj/rGPaz9UqdbboTStLcoO9+PTIP/F6KVjRfs8R1j5Td6jpHrdVihgmNvm8zU9gRwa0ovRNLtS44tnihQsFe+MTcXO7o9CeIAEV4y7VN3vsIEUz4JQeTMppLDoXgq5xm3YX5Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 21 Nov 2022 15:02:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0 Content-Language: en-US To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, jgross@suse.com, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Alex Chiang , Venkatesh Pallipadi , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221121102113.41893-1-roger.pau@citrix.com> <20221121102113.41893-2-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20221121102113.41893-2-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0200.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6909:EE_ X-MS-Office365-Filtering-Correlation-Id: b3b3abc2-9446-423c-352f-08dacbc90913 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DuPP+lxt05pBk77p1hv5/L+Uh4Uz1fptLao2+kV8gQ2fMBevwZN6FGv0z2YYM5XkNVSDbj4UHcCoyHalR7CCD5CkRHv64wmK3LHKPXLXtqipOb1Q1RPdVo1leh1kV9O06Zpm+fK2VwMItbMB9FUxCbQn025GAs9ovvIcccRgI75meGEdRgYd6/mZktaWGRQqxOzrx3bGJZ2cWzs65YEtUJkktPES2GDsUTynzzg7hewGtcUrASW5EQOKimyjYwBJmQ/XdexHiiX972q/qpcQ0eyIvG6y98+J8+LkWdHIvm3rRUUx1iykZ/OJYcAFFtgKnvXegZit3/5T+Gicy4sa03dAqKXtwKDwadshrkMqnMpw2eeSpBz3JBbpgoDET0R7F8jOYVAUuG7kilZEWC2kWIbjyO3kHSKxPM1S8ihJ1g7Yo1sSUPyix64xmBOvpwyoBukV+fFNHPc6dXBO86dZIEwkx3paRF/bNt2U4CK2ZZD9zuOTHe4UAHTIYurmmXtTe0Zgk5/MfQ3sCXq8ia/rQT1p32cKZWYtnC8CHkdWhAFl0Fm/Qupo0Zqy7UopbvlcxHWRQ8P/Qljcl16aKWuFwqnjcLf3f9syx4+iJEKg1uCpy+HoBvjaStJ+YLeQOcj7WVCO6UCsIvr1NaNVqKxRV0kpIwnxWyV0dddr/+i7XjHq742yviF2z19J652pkmWn1zbMxQCNn2fqgDubBu3tnSqryAszs++Un8jhxnl2y/U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(376002)(136003)(346002)(39860400002)(451199015)(6486002)(26005)(2906002)(86362001)(36756003)(6506007)(31696002)(478600001)(6512007)(38100700002)(53546011)(2616005)(186003)(4744005)(8936002)(7416002)(41300700001)(31686004)(66556008)(4326008)(66476007)(8676002)(5660300002)(66946007)(66899015)(6916009)(54906003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rm5lNmpQT0pQTDc1c1V3T2pxVFNNUEthNkVnU3dCei9yQWxkREY3YThoQlha?= =?utf-8?B?SkwrbkV0TW9maG5yQ0JoNXFnVGJNTWp5QWVFTHR3TUsrdTNkdHQ1OGhMeGVQ?= =?utf-8?B?cDE3OVRjRWowWjZtQXVYZ3JxeFZlSkxwUXhsSnFuUks5dEFQdkpkclRRUXkr?= =?utf-8?B?YnZwL1FqWkhxMEpwbWFNTUlxQU1LeFpaaVQxdUJnY2JMV2dNaDNKTEF3clg3?= =?utf-8?B?ZUx0QlROR29pZ0ZvS2pPRS81VGJHMnhOUytNVXFCdllMRjBjeTlLejI4ci9m?= =?utf-8?B?VTJkTzNZajhWYmo4ZllhbzdsRDZGcTlZaFVGbk1kbXpVK3lQZkdMdjljYzE5?= =?utf-8?B?T3l5OVlRTGkzQkFJUUZaQS8zUG5OZE8rYWswY05mRVUwNHFMQkhCcVNlamgy?= =?utf-8?B?NWt3QTE0ME0yRFFHL1Bzc3Rrbmc5eDVic3k5ejdvbzlPMnpQKzQrck95UkZN?= =?utf-8?B?ZHJnMU8yRkpZTDg5NGIzOHNYK1I3SS9XZUhDVGlXc3luWUE2UzRrUmhsWEFq?= =?utf-8?B?U1JSM3QvaUFMK3dUOGs4NGF3eGFyOFU3L1ppWDY5RVBVQmRVZGxINDlVbStK?= =?utf-8?B?UGw5MG15MjRXdllaa29JMEt0L2N5N3BZa3VGRjlua1RYc09PTmNrelVyYTMz?= =?utf-8?B?VFZRWTV1c1lPeTUwa3NiSUNLb1M0L2Jsa3Nzbk1wRE5ibGV1MjJZTkJwd2E0?= =?utf-8?B?NzFneTczYkpTbWQ2Y0N4NHl4SjZUL0lyWm93ZTV1aWpHeUpwUkVldnhOMndT?= =?utf-8?B?cUJNM0FKejJkd0FUSHQzS3N0MlBsVEtTeVNWSUZkb2o4ODNUaTNTZG5rMlBz?= =?utf-8?B?T0pWN0Uwb0dFTEFvdnM1TXBHcWpkMWw5WUt6Q0kxVmhXeU1BOHBwWU9vblZu?= =?utf-8?B?bml4RlFtRURHUnhFSU41amJoT3B2M3g0RkxFbGt2c0RvNG8vZHp1Y3BLN0cz?= =?utf-8?B?OGRIZkdpVjdNelB5VnRUVjdBWWZEbVJ3SU9rYkUwYmRYckd0ZVhMb0lxWnFY?= =?utf-8?B?SUw2MVFQcHRJeEFQZTVEcnV0b2FqV3BmYU9QZndsNzdxb09lUUloY042UXlQ?= =?utf-8?B?MkpJVUdsci9GQ1FLS2JQNG13OE52ZmhaT0pZRzE5RzE0RlRraFlrN2JFektr?= =?utf-8?B?T0hwM1o3OU5sMUhDYUw0WTQ5UFRtL1NUSVhweG5kc1hJbEVvVzJWZHpaSGJQ?= =?utf-8?B?RXlXUU4vWkFpdzk0YVNNVDVlVEtaNSs0aEFOZlh0V1ZMSWdvYmQrWnZ6L3F4?= =?utf-8?B?MTVxazNrbWNRc0JoVExoakV5RCtjU3AwVWhYWXlONWhkbGRuUGozZGgwZXNt?= =?utf-8?B?bmMxUDVIa2F6M2RTcFdoZ2ZYMTR5UGxrbm5BWCtwWFFMVXR5b2N3QjV6WXhG?= =?utf-8?B?UmZiZHhMcWp5K0NQRjNiV1Nya1VGMWJMSktRcTY5V2kwVC9aaDhZM3pIZVhn?= =?utf-8?B?cERab1FsMG9ObXFEMzVIOHBRVlUyZGx4MEhRRHF0SFVURS93ZDVBbmFvbm9B?= =?utf-8?B?aGR2UjRreUczMExKY2ozbndhWk1Jamx1Uzc3K21PSEtuZzN6V0hPUFlYVGtp?= =?utf-8?B?cHhmNTFCWWxVV0JsYUlZSVczSHZwZXNwckFuY0tiaE9idGRWTzdLTE1IbVRk?= =?utf-8?B?clE4aDJHd05IVHZ2SEdFMkMzcFdVRTgxUXVMZ3kxV1RYQlNVZ2VvTGdtZ3R4?= =?utf-8?B?TkwwNUhFZXRjZVdGZ3k1UERGYmdodlV3ZmcrbXp3cnJtcXhyTHlwQ2ZtSmE0?= =?utf-8?B?dUY0NkV4WmEzeWNhVGVZOUlQRXBTTzdRL0xha2VXK2lkVElyeUdxbWdhSU1x?= =?utf-8?B?YUlNOG1oWjFuakNjT0F2SGIrVFJhUGdQZ2hIWER4b2YrZ255MEY2OTZLT1hm?= =?utf-8?B?RVBKeGFzWDZkL0s4RVhTOGhKR3gwbU5nYWZabmlWRU1WcWVPYjhlTXI4VzIz?= =?utf-8?B?Q3pxOS80eUdIVERNZmpUcWhNS3hjVXJsQUR6Q1lXVEpqTitkME1oTS95QStr?= =?utf-8?B?R29sS1lLeGpXZlIrRDlYZlFtYzdUekU2NlA1emhrTVpDNDR5RHREd0RlZ2xN?= =?utf-8?B?VTVXcG9DSWdMSG5WNzByYzFMS2ZRVU42d21hbE1tVDBZeG56RDNHOVlMVTV6?= =?utf-8?Q?NLE628SCRMJYg6PiYRIyfgGhh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3b3abc2-9446-423c-352f-08dacbc90913 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 14:02:32.9496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6wzfbLPY2e+GegVkJLZJ4Gt34eX1XwWbmzN+nFqJMiAwV/tbb95HEMMhcTC8De2WP7DD77Iu6mtgnAgJNHAJCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6909 On 21.11.2022 11:21, Roger Pau Monne wrote: > @@ -47,6 +49,15 @@ static bool __init processor_physically_present(acpi_handle handle) > return false; > } > > + if (xen_initial_domain()) > + /* > + * When running as a Xen dom0 the number of processors Linux > + * sees can be different from the real number of processors on > + * the system, and we still need to execute _PDC for all of > + * them. > + */ > + return xen_processor_present(acpi_id); > + > type = (acpi_type == ACPI_TYPE_DEVICE) ? 1 : 0; > cpuid = acpi_get_cpuid(handle, type, acpi_id); We had to deal with this in our XenoLinux forward ports as well, but at the time it appeared upstream I decided to make use of acpi_get_apicid() (which meanwhile was renamed to acpi_get_phys_id()). Wouldn't than be an option, eliminating the need for a Xen-specific new function? Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 21 14:10:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 14:10:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446625.702285 (Exim 4.92) (envelope-from ) id 1ox7VS-0000EE-IE; Mon, 21 Nov 2022 14:10:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446625.702285; Mon, 21 Nov 2022 14:10:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7VS-0000E7-FA; Mon, 21 Nov 2022 14:10:42 +0000 Received: by outflank-mailman (input) for mailman id 446625; Mon, 21 Nov 2022 14:10:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7VR-0000E0-Go for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 14:10:41 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20610.outbound.protection.outlook.com [2a01:111:f400:fe12::610]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4779f5bf-69a6-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 15:10:40 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7147.eurprd04.prod.outlook.com (2603:10a6:10:126::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.11; Mon, 21 Nov 2022 14:10:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 14:10:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4779f5bf-69a6-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PB64rKASW9TdovkFi0wr4fRwsBI2skZZzMhH8A2JQBSFF/qovhnXyYmeeJZ77YHRF6GhHSiaztMpoYsrg7TIe/SskbHjg9zShFpvVE2K2vX5yC3OW3B92lfIvYJiGhpQRb/1Fmwc39ICSXGoyy3VUm/CbBpGRT9wzz3dljzaf1Z9Y3YLD0/dN5rtlbQ5ureAVZqWIHpRaM8PdNoiV7GHx/aJDJjrN2WNIov+TgPZ3qKksRZzlLWFfEelZYiIL5lFLmS5GFMH9qOkWauHIyAOpvmxXW6dQDyILMxq/YR52PE/wPb/teliZ+Yo/XemAefK8vQDbcvh7E5vMYmQGi79uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uqGaJMZncYNRrX5y3Oe4JYlD/pqZ6PvqNDJzlD83cig=; b=GbD/q0CHH+ftQZuj16ES82UXhXRdH/q5YbjIB8Kn+60e3i21HdAcg1rz1oFFBOxawWcwttO1d2/EHYcY/BBSzSQIU+9NUKrFIJ5SqG6wXMlZIGA1ErFWCTg5a+wnVIGFzY9N3wndmAM0NOYA3SJNNTpww3F/w/uIMy9wm6k71aGdzVPG6oIsFmOL6XTXu080DiKYPNacVZnUWdrEptT+WG9947fCGnsXneDSRTvujj1TH97YASVAXNlVpOM4f914m5S9BP3ySl1lqIvi984trvdrVDF75P2/x75flnLrEuaW5z3Rg/P+B8fL53wUIRHv6BU70sISEBNvKqftiy2t6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uqGaJMZncYNRrX5y3Oe4JYlD/pqZ6PvqNDJzlD83cig=; b=v6r3+Y4WEq2llyvtGv7JE0qpbLI7IOq0xCoZs8/cPdYEf5be1cmEcO36a5AnxwwGyIQeSgxlXAPizEu0vzW6VUtxO1vkSSS1ruGnCZzAHrb1fqGIKybuUp78Aqkxkf4e4Ov8nST6fT3NhHZOz96v4cgGqnVH5Dkb0ejYFVhll8JkR1vUQR3G/0I8S2vvW0cDiTSXgFOAeIUCOuIrm+4/v9LdplgdcTyUm0UZIdB6MtIfa1W9HefXKXE2GwAuNr+dlpsk9bikr1NUzYo7+kbag7RVTYPe37RkRRqaBgMFt1r8uNV0D9EotyMQxewD8p2qLMCcPVek6Tp3yt+28eLA4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 21 Nov 2022 15:10:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/3] acpi/processor: sanitize _PDC buffer bits when running as Xen dom0 Content-Language: en-US To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, jgross@suse.com, stable@vger.kernel.org, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221121102113.41893-1-roger.pau@citrix.com> <20221121102113.41893-3-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20221121102113.41893-3-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0150.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7147:EE_ X-MS-Office365-Filtering-Correlation-Id: 28eacf66-2bab-47cf-dc74-08dacbca2a5c X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ArLkeVlyKAUsEP+nOPGBZSxFsigrfcNRh6/qrkllximvqxqq24T2Qr5XXBJk9geNdEF8KjmJ9qlBQmVQ0UNxAtHCUHs5jIjGUWZ2g4et7aslOWtbBCSLuSj5W4uoE6YMvkhkyAx/T4v6vP5ArKBeLNj8aUIBiZePVTnfoy62uKGgQGGcuM9XxFTIoelXmwsPjzAL6q0XT8Up2qWNpun3EgTz1jl0Mq0uyStH7avFKcZSWWz4CazpClxlfmW4fmjac71wJ20tSEldUE8aN4iVBoeyBHcsOM4jL9tUcbiJznCu42ThWah2/SKZY3uVZNv+flAmydZqmPQTbXEJrnPghwbZJmHSBJbQsKhZgtss1ApQs6GzWJxRW7kUR5yQTbZMZ3iXNVkvolrTyN9cglTc+SbNdMw+Pmz3Z1xJl8lLo+IpMDb8uFWcsI0TmYjmL3lRqBrEeI9LI/TltxfKFlHUUmUSbIxkBjOSaAnXg1bB1DNgluWVfxH+EnKEXL4NbNx+q8kirbEL3GwwoPjDgMYc0UmiTwQhnva05qxwoF3St+uSdDB4h6+hAoaItsiOWe88pvrgSueeWTvGCfSQXpiq4X8QyD9MsBhYeqplvPc9dEE2aogiMegR2FtFC4hb+jfW493UBs0897zQdzxev23KlJu1aeyG54e48OrxZNh9lNSjR2a9MCqWdGmTclnVIlC9WAr93iOvKYut4k9bT2QFWI4wKdHI/FtpJYZ8REvNH9k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(346002)(39860400002)(136003)(396003)(451199015)(31686004)(36756003)(86362001)(31696002)(26005)(38100700002)(2616005)(186003)(6916009)(6512007)(83380400001)(2906002)(54906003)(8936002)(7416002)(5660300002)(6506007)(478600001)(53546011)(6486002)(66476007)(41300700001)(316002)(4326008)(66556008)(66946007)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXZMd2NMbm5lSnErdGZhTnlndUNkVWlKLzZSNmhwaFQ5Z0ZDc3ZmVVlPWkky?= =?utf-8?B?TFhDaHpCTllUYUFNOHFsQ1JLVnVJellRZWNiamsxWVNvRVdtMGZybnVoL3Ny?= =?utf-8?B?bS9NZkZ0cEpDaG5LemY4d3hKdTBvTmd3L0cvd1FjL2JjTW5DU3ZoL21IREtM?= =?utf-8?B?WDVzZ0orbnEzMjZUWkQwME5vVGdSbzFHejFDUVFVaThEdkhhUmErV1VWR0tn?= =?utf-8?B?dkVjeDIzUmovak1zZjA5U0REckJoOExMRkJuQVp3ZVZhSmdoT1czc0VZN1lN?= =?utf-8?B?dGdZSzBMSXZEbndGN1ZCWUNyYnNKT3VPRlA4TTZiN3NURWdZQTBGNUZQeGgz?= =?utf-8?B?SGl5aTEwUE9DalVFOVozdjlzb2RjYzhSSm1ZQ0gzdTZXU2o5ak4yK1FEWGlG?= =?utf-8?B?cUl4UVA2bDJ6bUxaRk5OQ2Z4cFdXZHpNMFU4Ri9MMk44d2YvS3RiVXU0ZktZ?= =?utf-8?B?S0gvb0c5a3ZNZHoyMjdPaG9ZMzNzbkJMc2tnRmY4Zk01eXRIVE9qWmRMTHhF?= =?utf-8?B?REsvamhwNUpSTzIvL056YndKZEVQWmdFN3IwRk5sUUVaUGlvR01HQm1uMmds?= =?utf-8?B?OUVYZ0Z2TVJkNTRoKzdyeDd0Z3lVaXJXTnJmdW8zWDl1ZEtsQWt4VXR0ODFl?= =?utf-8?B?d1hqQWp3a2pPakNDT2s0RkNhbzFmNFA4UVNNYWFidHRhb25mNUxFMjgyRmxj?= =?utf-8?B?Y1VzRk52L1dRbGlWMVEwM2l4NVpkMmVSQis1RGprR0EzL2tmSzVvNTF0MGNj?= =?utf-8?B?dmovNWVhc2tHQW15TXBONWdvT3JvT09GaTVWcXNMOHFud09vSE5oeWgzYVJE?= =?utf-8?B?U0dhNlVrMkpEMDk4Sk9ydWhsVjNScWI2WWg4bjl6dzVEWWhCck5ZSEVENFVP?= =?utf-8?B?bU1UeUN3Mlc3VVlROEZmaHlHT0U4ZUlhSnFHYUVLVEhoci93MkVFellpNHE3?= =?utf-8?B?bVVnekZtMElPQmxhaEs0TU03eHQ2Sm5BaDNDQWJxazRsTmQ5YmNISGVrblI1?= =?utf-8?B?V1drWEgxSGJtOC9ia3ZzbVNWT20rVEVTSGd6a0U4VXBHOVFJYjB5bEp1UTdn?= =?utf-8?B?NnFFeXBiQW5BblcxMHl0M0d3NHR0WEkrR05DS085RGlkQUdsQTJwdHF1K0ds?= =?utf-8?B?c1o0bWNDT0doR0grNUduNmVScUVRRGxwMDJObjJ4RFBiUmR6ZzhjVkxJVWd2?= =?utf-8?B?Y0V2dG9icE9SVkQwYkZ0TFgvOGJadk9tTDVBTTFlQ1lVdTdPTCtiWFhKTUJX?= =?utf-8?B?S0JJeXdJSXdaaExnRTBDOWMwNHRXK3pqVjBKd3lubXJTTUw2RGYvSkZIaytQ?= =?utf-8?B?YWRmUUI2VDRzVUJZYldWVTYrSEVKb2ZDMEZORHpFQjZuNy8vQk1VNVlWRjJ0?= =?utf-8?B?UkpHUFpwU3RPZU1nSE5KaS9Gc1J6VHNkUEJ5MjBkd3F4NE1LNHBsOXhnZWwy?= =?utf-8?B?MTNuU01xVkJ1ZG9xZDh5WHF2ZlR5WnNSc2xHaW9sUGNUKytGOXRTNEJtS2Zy?= =?utf-8?B?V0RyOGFHWkswZjlRaXptejhXdEpMbGdDaUo1bmR6ZlQ2SGo5VFoxbzVmbEdY?= =?utf-8?B?OWpXbjUyeFBzTDM3Um1ZYXdOSytVM2hCVTVsSVRJd0NWdnpEVVJudXhNK0dz?= =?utf-8?B?bHh6L0tPelNkQ1NWblp6T0RLSUhWaU53Vk55YytEVDZmNXFmUDR2WHhpL2cz?= =?utf-8?B?RTNkaitCYS9YRVFta0UybXNHZEhrV3V5RktiNzI4VXdnNThKeDVCaE83Rm50?= =?utf-8?B?YjRXZGpLQWFsbS9IeGxwTWoyaldkSTAybUFVcllTaEkwY1BrTlFLd3duODVq?= =?utf-8?B?R2FQeTJlN1JldGgwVEtYTFBsSUlFZ2ltWWpITkhUeURBYmpTbWh4dkJGTHdl?= =?utf-8?B?SDlCS1ZDeUIrKzg2K2h1V0hBTk5Yd3dGZFViV0Y1aXN6SHhYSnpwd2Y2UlE4?= =?utf-8?B?UVdMcTBoUmg5Y3dWdkVBK3FQT2RXam9ieW9NeEJ6MTcwcUtzamN5TnN2TDlZ?= =?utf-8?B?Y25pZzFFb3ZIZkRLNjlMQkNjNXhoczJZU0dZekNjaml1Sm1FNzR4YXVpell6?= =?utf-8?B?R3N6ZG9QN0hKSVNxWmk4cVZaR3FlTDB2Z0ZzSzBhZ0VBYVFLQy9BL0tzbzR3?= =?utf-8?Q?r1qIgfJcn8wgWIJC7iZpuwqsL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28eacf66-2bab-47cf-dc74-08dacbca2a5c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 14:10:38.1845 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sZd0cmQLoRVHfnpNXcGJg6DZFF7f6gjZ3HwyAaRvOwfyrfDftB0Q0L8usms4R7hSOsh91o6FotJI6ZN8kRd89w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7147 On 21.11.2022 11:21, Roger Pau Monne wrote: > --- a/drivers/acpi/processor_pdc.c > +++ b/drivers/acpi/processor_pdc.c > @@ -137,6 +137,14 @@ acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in) > buffer[2] &= ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH); > > } > + if (xen_initial_domain()) > + /* > + * When Linux is running as Xen dom0 it's the hypervisor the > + * entity in charge of the processor power management, and so > + * Xen needs to check the OS capabilities reported in the _PDC > + * buffer matches what the hypervisor driver supports. > + */ > + xen_sanitize_pdc((uint32_t *)pdc_in->pointer->buffer.pointer); > status = acpi_evaluate_object(handle, "_PDC", pdc_in, NULL); Again looking at our old XenoLinux forward port we had this inside the earlier if(), as an _alternative_ to the &= (I don't think it's valid to apply both the kernel's and Xen's adjustments). That would also let you use "buffer" rather than re-calculating it via yet another (risky from an abstract pov) cast. It was the very nature of requiring Xen-specific conditionals which I understand was the reason why so far no attempt was made to get this (incl the corresponding logic for patch 1) into any upstream kernel. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 21 14:13:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 14:13:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446631.702296 (Exim 4.92) (envelope-from ) id 1ox7Y8-0000rY-2i; Mon, 21 Nov 2022 14:13:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446631.702296; Mon, 21 Nov 2022 14:13:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7Y7-0000rR-W1; Mon, 21 Nov 2022 14:13:27 +0000 Received: by outflank-mailman (input) for mailman id 446631; Mon, 21 Nov 2022 14:13:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7Y6-0000rJ-LG for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 14:13:26 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20625.outbound.protection.outlook.com [2a01:111:f400:7d00::625]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9c1a41a-69a6-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 15:13:25 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9174.eurprd04.prod.outlook.com (2603:10a6:20b:449::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 14:13:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 14:13:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9c1a41a-69a6-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aFKXemftMMeyHLiYhM4WyZo1uT0HtazJL+HY9Fff97ZGIZ32ufsfpyYyU2Jz4/QaNXhGKFhPCehB7z4JSNI0NQQ1oqVm1TBiGoDbndGCzYNCPUr3N/zwWerpyfiZ64hRFroM1XCvfP03SDyOdf8GjU5KhGAocEF5y8Gg69yynyiGXpP0Io4CSqjsNhi+vC+DL5Kzfqy5SxjkG2NRoW3wrsUGAzWf6z7LmwiindVmVkEGjNOU9XfcmOpjO0LU0Q/ihbdPFbHufkqVqomije4j45llw5ENCPqlalOOpYK/UdAq1CJGZ3jfO4KJREUBAi5sZAF/X36Lz7/NTqKu0wWKbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BiQfIr9QNmNdqzrWkESllByDiNlkhrvXBEeYIIgQsQM=; b=Ha0uzuo/sGC4a6ne9alxrilMi69Ct8A8F2VCHj75AL1JR2SMnKsjeoTNeXiOqsFuAj1KXfuXoii2sINCJhdcWh6EksOjP4M6NmX8rCf/NGnJNcofOvWVWFTVtPMrxLrOdckLqHQZYVaY/PEd4h+qNmY3poC7Ixo78E0ZBQLDp1Qpr7mn5gFj+07/lDZfTvEVU6ZUQbk4R8RDwaI9OT2/LhZjtEtRam9ycp3YEjbexprKu65LZifqa/3blymUwbsLKQNGcnvqmCGTBi7KzEpU4pJ0adjvloIgNLhvGVjqgO2n2NmUJby1nMW04WioYt6gU96W6QBlABahwF7H7W2Plw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BiQfIr9QNmNdqzrWkESllByDiNlkhrvXBEeYIIgQsQM=; b=zufbeLq24UbFuIu1RzIi4NyUZJRcxsiuLwLJqRCvOfmvdZW05xcU6wiDlUpb2mO98fbZDQYs4IN2LlzTQezMilzsa06lj+4GqHxs2tbtvHOKezlDjAACfV8bhHf6NqWPs7YWN+gDf39GJQPgsbVk6E37fZUh0s2BG+tfdrsIb+yMiGGZ9ZeFHgbwO+wNYaJalxcYAYXF1pWPJm5PxzDbL28wQtCUGz9jxXZg3W6j8VSKnPQK/I+n+iN9lELRc8e21KG5TKav7AemvEzlFp3/mAJrKjymxR5lws9kWIuab7SRkidhhUGb20FWCFjkXvzzQPvW/94U0X3UaSBkpctoAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 21 Nov 2022 15:13:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/3] acpi/processor: sanitize _PDC buffer bits when running as Xen dom0 Content-Language: en-US From: Jan Beulich To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, jgross@suse.com, stable@vger.kernel.org, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221121102113.41893-1-roger.pau@citrix.com> <20221121102113.41893-3-roger.pau@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0199.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9174:EE_ X-MS-Office365-Filtering-Correlation-Id: ddb42abc-bc1d-4041-2cba-08dacbca8d1d X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RezsW0DTRb6OStLxb93IEjmwDCwXS7gu+sS5LvcYV1yqEobQnzL+eYrcVYvUvcVC2DejvDk8wdGkdt4jPC8dh6XU9ZxROw0KP8afiz8+F2ytd5Xch17Tlw+BvyKOozY6Mx0bS+nGSD6Vut+2IsjR6EXCtiYODkLwtdSOYhNE5YwfGEqEgRNn27L7NWHa4aU0fzwJnsRXzo7OZo+6oZqrEpknpKstZV0pmRT39k0VgIFV3+12SSHayRRq8iwzsyGs9EeUX6FbhaxOuXMGp1j970v3dtw88r0WGZ9Oy5Qxoca1E7cm377oOppnt2ymOUy+YLNB4u5oDdLNmoJj8LeqQDuLUmb1crb09t1ZfLYPU0Mez+yRw2qIUAQ5E3ObKORYU6ZA5H3blsBGglWZU3l2h2cDcDFOUEoPlWlvlw//kTvc+2VoO3uksWimwZgjfuO8rHJtcUJK+JBIE8KN0MkyTJOBnDlA+hrV22FVVDe7SkgkgPYLqwwRzas9lzbL1ddPxq/HO9hZlKmujThC8AxV3flQ+hwN4wJm9ehfJYd373KKxvKqASjkAfWi7UzOVIlScFHa1zJfpQjAtSNOAPS+BD3yiZrCoLjLXeozTqd0tTNik0KaKx82B0RlIBysP/82iBZSYixJaQ7Ocoh6jbNyHmqk+u5EjcmWmPjoPYr7JD2jsrcf/GTHsqAni/oazgiz+xDlJ7ZiFrmBvd5kair8RA7VGYKcW62F37BvIm995Zo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(39850400004)(346002)(366004)(396003)(451199015)(186003)(6486002)(2616005)(83380400001)(66946007)(31696002)(86362001)(38100700002)(5660300002)(54906003)(4326008)(66556008)(8936002)(8676002)(66476007)(41300700001)(6916009)(316002)(7416002)(36756003)(31686004)(6512007)(26005)(53546011)(478600001)(6506007)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGdLa1Y2TmxyNU1jNytwRWhueFBEZkZOdlkzRWtQdG4xVnVJeGw0TFdvMS93?= =?utf-8?B?eTlrb1M3bU5rRTVqZTFwWG82YjE0R2hLaW9ZSzc4UUpnRmQ5UTdvMnIrbkxn?= =?utf-8?B?UkNsRldXcStXNFJRUjVSUVE4TmxtV2NpYjNnWmMvVytILzVHZ3FHUDBqY2hk?= =?utf-8?B?SDFNV0ZFYlYwWE40d3k5ajc3R1NtTFMwZnA3UWs1K1FHWFhRMjJ5YmlxMUwx?= =?utf-8?B?NDNwMlluOWJmbFprY1gzR3dUeHpRMUNCbExiRDBISjU3a3k5bEFPZHp4bHFW?= =?utf-8?B?Q3RWa1ZIODFUenY1V2tHOXVvV1lkNXhONS9Ia0NNZHlzeUZ4T3pGNUwzZkNk?= =?utf-8?B?MmVTaXNXaHRQWFowUWdhVytlRXQyeUh2TEw4TGhOTHZGV2lZUW80TExZMWk0?= =?utf-8?B?M3F3SlZhVlVFakowV1hvWDdQTWkrQ1hjYm5ZR3BOaUF6KzUwelJVYzV2ZCtu?= =?utf-8?B?VzFDK1R3NDRoVEFKc3I5OGRaZFlqTWg2VXllOEhDZXcvN3F4aWdURFpIOVZZ?= =?utf-8?B?dmdSM00wY2c5VVFJR1l2MmliWXBhTmx4QVdjcnAyZTh5YzJHUmt1MkpadGdn?= =?utf-8?B?NS9VZFlSVElKNm1oTmw3UnlUWXAyY2lZZEg0WHNzZVNxR0N5QnV3UHN1RDdx?= =?utf-8?B?SW9PenpXSVM1aHhGZjFBakQ2ODNKMlN4L3RsVmdYUFg0QTk3RTZPMThnR2NB?= =?utf-8?B?TFBTUzFmZ3ArUm5xWHM5QzBFcm9GK05PQ1NyakttakM1K3BMeUlLNlkveVJC?= =?utf-8?B?NU51UlZRaDR2d29xdlFIYUl0RWNiU0xnZHdhc2VNRWUxZGk2NHpMYitQc0t1?= =?utf-8?B?L1JXNC9oclBIUVB3ZElIVHJvUC9TVitLQnhvbHVhVlZwT2lreVYySENjeGRY?= =?utf-8?B?K29CVnBwVTQ0ZDRwVEI4d0hlZHBQdVd6eU1aeHhYdkl2T2ZpR0NOUjU5czA3?= =?utf-8?B?ZU9CSlhncXlsRi9vRTlQOEpHajF0SU5YVUQ0VFZmajFZelgvNE5TSHNLZzVy?= =?utf-8?B?SGJsVndOUUY5WEF0SnE0ZU5mQ1VEYjY1bHNNUFBXZjZKSmVBd2ZCNkpPL2FI?= =?utf-8?B?OEdOekNaY2swcEtCdFZ2MGJIWnpMQi9Xam5xT0d5OWdSUnZ5NkJPeWZhQ2dF?= =?utf-8?B?L2xkRmQxRUhId3ZZY2czeFR2UGZUam5Qb240ei95SksvTnZ2bmN1MkY2SW1T?= =?utf-8?B?Y055ZFFJbzl6WnJzSU9sMXZNcHA5K1U1dE1LSEJ1UXBJL3FnL3A1ai9XSzc1?= =?utf-8?B?V0RJcVdpa3htdHQ0MnNFVFBEM01ZSDFsWGUyYUdXSG1uNSthQmxFekp5VjM1?= =?utf-8?B?eWt6bzNhTzNJWnRmL2tLblRRcWtKb1VIT2YxL09aZDdLSE1BWVF0OEtPTGs5?= =?utf-8?B?MzF4VHdvSGExeDFWZEtEUXllR0wycWNzaXFsblhqdmJqMjdUeE9kMzNkYXBm?= =?utf-8?B?NmpLMG1WaGNibDNLNk5ZWlV3Y1hxaWdmZEl0Y3hPUUdoZGMvcXdSYitiY2pO?= =?utf-8?B?ZmJtUEhCbFhaVnRsZjZ2K0EyWUVmUTdyNG0yQTEwM1VXQjdhdDlDL0FGRlly?= =?utf-8?B?QTZpWFhMa3R2N3JxRjJiY3hYY3NVSVBYZ04vVHFzdFkxLzQ3MkI0aERSVjhk?= =?utf-8?B?TkVDUm85aHlFNm0yZGJCUENxTzJ5bUdOUmlST2dNMDRxbVpWeDVlcU1kaTZS?= =?utf-8?B?YWh4T25GeXV0QkZadEI4bDhNVDMvU2U1dUllSWRzdk9sOE5aRUFXU0c0aGds?= =?utf-8?B?TDlibWcvckZWMGhCZmJIVmtJM2VzOWRqbXdsYzZhbWFXUGlUbnVIVkRZMXBy?= =?utf-8?B?bUJXdGlPTFdLaVoyNlVaaEdvUzJkM0FWeVBEaDgyQ3BGWS9kd0tKWFJUM0xZ?= =?utf-8?B?c3BzMEZ2K2VmRys3Zmd4WmRiRDZGd2ZYcjJOazd0MjBuMTY2VGRCOENIYVVn?= =?utf-8?B?azF1ekxjN1pZZG4wL3h0QVJCR2tVa2dXNGIxRmxySXhEKytRZmtGR0FBSmdE?= =?utf-8?B?aUY2dUt6QmtjSTViUTRKWFFGUkR4Z1RLZkNnbDJyVjNCc3VmWkpoVzIzSUVk?= =?utf-8?B?eEpDWkJUWXhJdXJ5SUsrYlNVMHB4MjNyd0ZNRUdSa29nWEFTaTA3Umh5c3VP?= =?utf-8?Q?gU/fBhhaLuFZ/LY7wJKQgckY/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddb42abc-bc1d-4041-2cba-08dacbca8d1d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 14:13:23.9084 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MuN4G6hgcfp3p51OaU77D+qPd4ZiBrrs3WAqEsIzzE4dZ+SopKhWQb45u5gUkY2SQuWtvIFLh/TBUeE28uEVNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9174 On 21.11.2022 15:10, Jan Beulich wrote: > On 21.11.2022 11:21, Roger Pau Monne wrote: >> --- a/drivers/acpi/processor_pdc.c >> +++ b/drivers/acpi/processor_pdc.c >> @@ -137,6 +137,14 @@ acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in) >> buffer[2] &= ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH); >> >> } >> + if (xen_initial_domain()) >> + /* >> + * When Linux is running as Xen dom0 it's the hypervisor the >> + * entity in charge of the processor power management, and so >> + * Xen needs to check the OS capabilities reported in the _PDC >> + * buffer matches what the hypervisor driver supports. >> + */ >> + xen_sanitize_pdc((uint32_t *)pdc_in->pointer->buffer.pointer); >> status = acpi_evaluate_object(handle, "_PDC", pdc_in, NULL); > > Again looking at our old XenoLinux forward port we had this inside the > earlier if(), as an _alternative_ to the &= (I don't think it's valid > to apply both the kernel's and Xen's adjustments). That would also let > you use "buffer" rather than re-calculating it via yet another (risky > from an abstract pov) cast. Oh, I notice this can end up being misleading: Besides having it in the earlier if() we had also #ifdef-ed out that if() itself (keeping just the body). The equivalent of this here might then be if (boot_option_idle_override == IDLE_NOMWAIT || xen_initial_domain()) { Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 21 14:21:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 14:21:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446637.702307 (Exim 4.92) (envelope-from ) id 1ox7fP-0002PO-PX; Mon, 21 Nov 2022 14:20:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446637.702307; Mon, 21 Nov 2022 14:20:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7fP-0002PH-Mo; Mon, 21 Nov 2022 14:20:59 +0000 Received: by outflank-mailman (input) for mailman id 446637; Mon, 21 Nov 2022 14:20:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7fN-0002PB-RV for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 14:20:57 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0617.outbound.protection.outlook.com [2a01:111:f400:fe0c::617]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b680018f-69a7-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 15:20:56 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 14:20:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 14:20:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b680018f-69a7-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BIoHMEKR7vndtfoZ/JKn4oXOduuQffPtXrxR/vlkfwYi4NQegYpZM0MJnTJ64YHgjheHKR1kLTq1CUfvyR/kUKFWVB0UmcKwyabKv6E83UmxWuWgZg41jgA+5WUq2JCK53++wszSdtY4o5PRQV5VvQe0WirWTEUOVPQYGaWxUtWbCuUrw0XwHGgtSTBalyyno5p2TKzxgKr6LK2v15fKAkHTk87SQrJF6yMUHLxYeKvnhDVzik/xHJ3KteJZrQB6qM3NEMUiD1EeNy/05+qvWPpADpdzDN3Go4iinkWOrI4NPiDhvemKLuc4b8BendajngoFJDTxCwFfMuG8uwjVHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RekUAs2NVLsFowGUN7aH39geJvfdQnZe8z04sdBvMy8=; b=grb+vbxsf0jXkXrsbs0u3Ghi73zRUVhlgPccVKTWnRfCtG3cltkmXxVDLEO5tLU+iJFIRdMBqzQrrvIKmGxjZz79y0k8YuDGfvvn12KwC1O2Y9J01sTX8kNvVr6SXJSRXxEA07m5KNtaAX7dOw425pxb+Q8rf/86REE5/+/zWQykjsIFrAToNioUS6ZSdxuRMNq4iWhmjt6uLIIzZ/WczHSXSfd1k8IJSSCmQyzVHbR8oC3fYHK6UOykD/IkJ0Uf1P+gcUnEdjGvGE2EzxnlpjOHAA7c+BrpmaGq8S7UacPTwA7hU+1AdKApD0EKlrtHRC1APb62gKrlIAL56fguzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RekUAs2NVLsFowGUN7aH39geJvfdQnZe8z04sdBvMy8=; b=dkzcB2kbXSz08n58JTX4YT8qP4fZVZe4OuZVKpWUG47iFiIE6asvjgQnLwEvq54aH4jq4iOIE2AoE+/Hb/rawuER/w6lawFUkH9gbzZPKN/Jp302rnGBhoOIf4c19U7xIlfOgcCAF8PlIuto08YyWpJJAkaPGxr1vkFWj1iCL6U8Wn+lp5JHCpHIO/h4CIRTIKKup9yXn2KRM7GJM/7DpymtFzzniUgGP4yPlJ/DKX/XLPIoGLoECzaPvSaj6GTDTRVa2uJMGlXZK/uHfb2dbhlCsHJ3HyywkhYJ3Kp687ZDNJK8JKL+K6DTRaWala9L7tP9+4Ufxjg4xCm3tWqXiQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 21 Nov 2022 15:20:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 0/3] xen: ACPI processor related fixes Content-Language: en-US To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, jgross@suse.com, linux-kernel@vger.kernel.org References: <20221121102113.41893-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20221121102113.41893-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0030.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8676:EE_ X-MS-Office365-Filtering-Correlation-Id: d5bb9f93-0c3e-4288-146b-08dacbcb99f1 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2OvNRSD7jsSYx6kqSYKPZdCnnekzeV5hybozR1+lwhQ9zBmBc0oFhGUeUNTmw+lj6dRXrs8zSaY4ZdHVRI0hsvH2OobEpxui2GfO1sVg4I21VY/Ox+FmGgUDR9mxTdH8vBye4bmSujO0vlHZPT1uW82Zd6jiigY538KBxeSxpuVKsQzDHSNcjvOcY+fiFr/v/hinOK89Un/d3qunPWokrCyO4OkkU4PXlLmtCGszbJEp+BxIbEwG5hir6pp2j1q+mGSyibunOQnX1DYBEYlZzbfJ3CEc1VnQdbzMgCc/zl/s89yYcIiKzvRP8tCKhnJPFVBBi6tUU8yMpHUYNku3k5vnJz3SpS6i2etOeGOIU6XXcq0dlwVC8b9zYdOozgT10H4WY/6Jv5Iu4f/dbvoGpUBqGgr/Sa5a+6zw7e6QJ4agwBfxeLRpz22VjKK6psLCLmusX45zGU4mlm8HQ8mj+Mxswz52aCWcHIvr+7EVAKwz5bxsLKM4Ggr7fPP+tiIyRh0wV6oqrU3H9VKh6miQG1sBulObu3AM7MisGvoCMP10DnR7Bm7TkownOtO8+FSH1l5MHBQY7xhDMUKpsML0greQwqhZCySTOLgc5UEVhprQ1P+YFuV3c/SfQu7XdR5f2Zd9FcAyH3SmYp5KcWwz+ppSGUQS7Rk8maFgePepZ3ilTcI8HGwEqDn9sbE4O1REXvB4MADSXLE6O66ZbKawkmMapM/k/YLDtTfs3ijF86g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(396003)(346002)(376002)(39860400002)(451199015)(36756003)(31686004)(38100700002)(41300700001)(2906002)(83380400001)(86362001)(31696002)(66476007)(66556008)(8676002)(316002)(6486002)(66946007)(4326008)(26005)(6512007)(6916009)(186003)(5660300002)(8936002)(478600001)(6506007)(2616005)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGN2alFWeEdqRER1NWhhWDVNUVpXZU5WRHNTemZBTGFRZmN3VjFuL2lOMm1P?= =?utf-8?B?WW9ldmU0TksyaGc4c0RVM1VZTnh5ald5ZzJNQmsveVJUbFNSS0xrRzdlTzZI?= =?utf-8?B?VW9NdElyWjlNRHo4NGdYVWxQNWJFeGxLaWxwNGVMRlh1WmQrNjQ4dDhhZVkw?= =?utf-8?B?VUN2d0ZCS3BrVXQ5a25kaG0zRUQ3cXNZVmtyNUd5amdBWGlmYTJodm1mZ3Ja?= =?utf-8?B?ZVYwcVEzUXF2SkFJRUwyYUZ3cE5CU2x6WDF0M1R0Q1dmV0svbzFTY1NjWkI2?= =?utf-8?B?NlVUY2dESStRdThZeWxhZGt6REpzVHc2MGdxOS9JVDM1NzZ5TGs0azJDZGdl?= =?utf-8?B?MzFudjVmNnlxWHZaTTc5ai85VFhEc0RpZmJXSUN4TjVJSHJOa3dhcGV4ZlM3?= =?utf-8?B?cEFsNkhXb3VsdHVFVVhzSnNtem5NYzNzckErdXZOMDYzaFJlMWxMUHFPNWY4?= =?utf-8?B?WVVPVlFzWDc3c29sYldsMENRVktWT0Ztd0g2aTVBakVpN3VvSE5YK1FrcE1H?= =?utf-8?B?b240OTdzaU1ZSjNFcHRyVUpXdk5BVmRMckJmMEp4Y2xqdDVCbkFqZEI4aURu?= =?utf-8?B?VnFuVjlIalVNT0R5T09oWTF2ZGRMVTN2VWdXUndkS1R1Y3RDRnh2Q2NVTTFl?= =?utf-8?B?WFFTVGdOMExaVHRkN1J1ZEliSWxTM0JVVktPZ3J0dTJuMWxsVElKSTZNSGhk?= =?utf-8?B?SG1SWEtwQ2JacWNDRG00bFNvKzBERVR3bitOcXN3RXBEWHR0NTJlYTg4R0c2?= =?utf-8?B?QkhNanl3b1FGbFhUTzBSV2RSUTN2NzQvUVhqMWxSQXpTbjUzMThVbEVpclpz?= =?utf-8?B?K0ExL1RLVXBGdTgvZlNPTVRXTTlWMkY0SkRHM1ZnVThSeU5lOWwrQSt6OUpy?= =?utf-8?B?MzVybjVuVFM5Rm1oZy9WWFN4OGRoZGUxNldMc01lZERzNFg5dUFuWGNGcUFR?= =?utf-8?B?VythcTViQ0ZnWFFUNDM0NURCOFVYUVU3SFlMRDRSUWFiM3NwVUUwZWRYUXZr?= =?utf-8?B?WHRxTk1ETGdoaGRiTWMxbHNZalN2Vy9hVThmMXorRWFNZGY1cVdmVHY5UmxE?= =?utf-8?B?Mk1WbWRCNVFWeE8zeXlEdFNCMlQ0eDdGaVFVaWlweERoZWxhT0tSZEZYcFJ4?= =?utf-8?B?b1lIZXc5MFJDQk81K1EzcDllUDF6OEZYRk40N0J1dzhXT3p5YVlzTFFhNG5a?= =?utf-8?B?MEJRczRyeVU1VjN1Tms5MDVuVFVwQlliUUkzWUczT0hZd1lSNEhTTGlLenRY?= =?utf-8?B?aEVRVW15QkZ6R3FqRE5naDZyKzB3NU1rWFNmaXpmNXdSN2FBRUJaaURacTdP?= =?utf-8?B?UDhCZG40MmpkY1oyNFBFNzd1bjVCalk2ckZHbkgzRk1RVllTYkcxYkJ2SFNG?= =?utf-8?B?SWhjNDJodzdiUVFYakxtSktYMk1qaDMyQlZxamYwU2Z6anlDZ0UrdnNnVzBI?= =?utf-8?B?cUk0M0g3VXVzZkVNVUZyN1hmaDF1dms4dFVqdGNWckk5UWd3dDBlK1lZMkFi?= =?utf-8?B?elQ5ZElHbmdsT05ub250bGZSTnFEUmovR1lVRGFYNUxiTDNkdzI3dFY1emR5?= =?utf-8?B?TDhhcWhkTnZ1UkUyS3BXSVpPeHdMOFdlaERpMWtpU2dYTjFiRWFyV2Q0TG4z?= =?utf-8?B?LzJzbWlSeHF3ZktNUDNnNCttNkZPYzg1cUtFOUlTSUdhQlBvSnoxQ3FSVS9J?= =?utf-8?B?VTN3dER2ek9haDNCMEE5d3RMeW5nQ0tmNy9UQ3pXS1VodUxIVGVna0hveGlu?= =?utf-8?B?M0RWNFpzZEdqM0VLdUhLdmd3WUlQbFRQUHIyb2wxYlZzUFpxZ3lrRzZXYSs4?= =?utf-8?B?b3ZVWklKcXUzeWtPRDE3YjlMSUJuMUhmZjhvY0RRVkdmSGhjcTkrV0lPYXoz?= =?utf-8?B?RFBMMG5HQVVDcE1Ia2ozMWVJNGN5bXluYjU5MnFVTWZodi8wMnBDbjNyYlhB?= =?utf-8?B?Mk9KZ0svR2ExeG1GblUvWFN3ck1Xb2RXVEJpbXRWcktwbzB6NGlRcEowQUNL?= =?utf-8?B?S01STXN1SWZGYkx6OWlVbmlNbWlLamhWQndzdDZ5NWRVMlJFTm9KMDVsM1ZM?= =?utf-8?B?UWQ3S2RRS1N2WlVCczRuRHZxTGpFb2h5M0Vub1RlVUZiK250S3F2bXNBTnZp?= =?utf-8?Q?TfR/ohBX4cTcRIufAapv10ulX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5bb9f93-0c3e-4288-146b-08dacbcb99f1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 14:20:54.8797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jD0YAGzWk/DIMFeR8oZyTtWty5RfISDOKteYXPubBiATb3X0SJ4TE17/huyMRdtW8En4lWME8rYLrEMyYcJ7Ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8676 On 21.11.2022 11:21, Roger Pau Monne wrote: > Hello, > > This series aims to fix some shortcomings with the handling of ACPI > Processors objects when running as a Xen dom0. > > First two patches fix the execution of the _PDC methods for all CPUs on > the system and not just the ones available to dom0, while also making > sure that the _PDC capabilities reported to ACPI match what the > perfrmance and power drivers in Xen can handle. > > Final patch fixes the Xen ACPI Processor driver to also work when used > in a PVH dom0, that has a custom build ACPI MADT table and mismatched > Processor UIDs between the MADT and the Processor objects in the dynamic > AML. > > I don't really like the current implementation of the Xen ACPI Processor > driver, it IMO relies too much on data being fetched by generic kernel > code. For one the generic fetcher functions can take CPUID data into > account in order to sanitize what's found in ACPI, but capabilities > reported to dom0 can be different from the native ones. Also the Xen > ACPI Processor code relies on cloning the data from CPUs in order to fill > for the pCPUs > vCPUs, but this is wrong when running on heterogeneous > systems. Yes, these are problems (and as per reading the description of the last patch you even extend this "cloning" of data), but ... > Last patch introduces some helpers to Xen ACPI Processor that should > allow fetching all the required data, for each ACPI Processor object on > the dynamic tables. It might be helpful to explore disabling any > Processor object handling done by generic drivers and just fetch all the > data from the Xen Processor driver itself for every Processor object on > the namespace. Likewise it might be better to just execute _PDC from > that same Xen ACPI Processor driver instead of polluting the generic > ACPI Processor driver. ... cloning functions living elsewhere also has the genuine problem of them then needing to be kept in sync without there being any trigger to know when an original function was changed in some way. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 21 14:30:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 14:30:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446642.702318 (Exim 4.92) (envelope-from ) id 1ox7oQ-0003sD-Lu; Mon, 21 Nov 2022 14:30:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446642.702318; Mon, 21 Nov 2022 14:30:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7oQ-0003s6-JC; Mon, 21 Nov 2022 14:30:18 +0000 Received: by outflank-mailman (input) for mailman id 446642; Mon, 21 Nov 2022 14:30:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7oO-0003s0-Vx for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 14:30:17 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ff147609-69a8-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 15:30:12 +0100 (CET) Received: from mail-dm6nam12lp2176.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 09:30:00 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BLAPR03MB5378.namprd03.prod.outlook.com (2603:10b6:208:292::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 14:29:56 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 14:29:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff147609-69a8-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669041012; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=G3SSruBUWzJkSpyt33DrUwrJ9PiNYwYZUjb0wa/957g=; b=JzJ/tpF0s24cUUTZBbDVyMvs0oidjTn0+L046fnxluxyKm2yqnzY0w/x veVdcekzGNEgM22FH1ibCdtOnmDSAC30DQGk8baCKufJl5hgAdYuJIXml QaqaS9ctE51eMxFaDLJnSU9w+FDFtLa+f0SdKjvGgu23eBaTNFin8lNSA 0=; X-IronPort-RemoteIP: 104.47.59.176 X-IronPort-MID: 87795842 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5Cba6a4iRCoWEZMAS4LhvgxRtP3HchMFZxGqfqrLsTDasY5as4F+v mYfDG+HaPuKN2HyKdggOYri/EkB6pbXmoM3TAA/pCA8Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkR5QeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mx /8GFWlKSDO41/OR25axevdnt/kFM5y+VG8fkikIITDxK98DGMqGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnUooj+aF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efwnyqBdJOTtVU8NZpq3C96mJDMiQcTHv4p/iV03abA/JQf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmL+aU3WG7Z+PsCi/fyMSKAcqbygeTBBD5ML/uoYtlRHeZtF5GaWxg5v+HjSY6 yyFqDgWg7QVkNIR0KO67RbLjlqEo5nPQQkd/AjbXmu5qAh+YeaNbZSA4Fza4PAQaoqUJnGNt WYJ3ciX6vsDC7mJlSqQUKMMGq2k47CONzi0qU4/QbEi+i6r9nrleppfiBl+PE5BINcYfiWva 0jW0StL7ZFaMX+CbqJtZY+1TcMwwsDIEdnjXNjXY8BIb5w3cxWIlAlnbk6R1mbiuEg016o4P P+zb8uqDn8GBL9niiK/Q+McybYnxwg/w3/eQdbwyBHP+b6fYmOFDL4OKFqmcO809uWHrR/T/ tIZMNGFoz1bUevjcmzU/JQVIFQiM3c2H9b1ptZRe+rFJRBpcFzNENfUyLIlPoBgwaJck76S+ mnnAxAGjl3imXfANAOGLGh5b6/iVop+qnR9OjEwOVGv2D4oZoPHALojSqbbtIIPrIRLpcOYh dFcEylcKpyjkgj6xgk= IronPort-HdrOrdr: A9a23:Q9aBgKxqTqAZtoK6Ua26KrPxRugkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICOgqTM6ftWzd1FdAQ7sD0WKP+UyCJ8S6zJ8n6U 4CSdkDNDSTNykcsS+S2mDRfbcdKZu8gcaVbI/lvgpQpGpRGsVdBmlCe2Sm+hocfng9OXN1Lu vq2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJTIWGhI97wGKrDWwrJr3CQKR0BsyWy5Ghe5Kyx mPryXJooGY992rwB7V0GHeq7xQhdva09NGQOCcl8QPLT3oqwCwIKBsQaeLsjwZqPymrHwqjN 7PiRE9ONkb0QKYQkiF5T/WnyXw2jcn7HHvjXeenHvYuMT8ABY3EdBIi451egbQrxNIhqA07I t7m0ai87ZHBxLJmyrwo/DOShFRj0Kx5V4vi/QagXBzWZYXLJVRsYsc1kVIF4poJlON1KkXVM 1VSO3M7vdfdl2XK1jfo2lU2dSpGk8+Gx+XK3JyyPC94nxzpjRU3kEYzMsQkjMr75QmUaRJ4O zCL+BBiKxOZtV+V9MzOM4xBe+MTkDdSxPFN2yfZX79ErscBn7Lo5nrpJ0o+eCRfoASxpdaou WMbLphjx9yR6vSM7zP4HUSmSq9A1lVHA6dh/223qIJ9IEVH9HQQG++oFNHqbrSnxxQOLyfZx +JAuMmPxbSFxqQJW935XyBZ3BzEwhqbCRHgKdOZ3u+5uT2F6bNisv3NN7uGZuFK0dVZoq4OA pIYATO X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="87795842" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=csfjpdt0quG2PviwscLVDKzdldbEYEUIdSDQ8Fzbo3RN90JglsLVBfgl/jMCzZx2DqXXcS3FeF0ap0N80XEDrGXsoJIyasU47YILoyGKwZ4w9pnNedMnDia/52RZ8U6DTbbfSG4hyVpBc3XzhWA7EcmSqmEJM0ZXISOJmWFfB8KBG9KdGqloCpkMbAXex3Wy+uE41U56B3izPlW+OLUYTqFpMzXPvMdis+pxOleI1nwV+1T7i6IsOA61b3s6CMQWNoaD902sN3oqJKEOeQedfocT2PLhsyD8hrp6OrFpXn8a+Ik1sn1AF48yeIkhwmAI5C+Ad/wk8PKypXKcC/I3nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/drRiTkJpiXLwzDMMfkyf5zJFFnRxlphj2PfuaNtPjU=; b=nBNqQAwt6UjpqDMazs3fm6SK5Kc6PmkVwC0UlwVsMut5BVtH7IIAApi13fgnalTevI3tEB+qDTci+l6gzX/IIe0Ne632ZyKJz501pQmRlZyom3ahMaXP9o8MTHm/rrU3q8jlB0NEZaevXT0RJucI4FOSH0DvJmuTfU18zMyjxtHoAHpfyF2tADUmv1y7lgqJRc4mj2Uetk4CUvT7hJVJ4hXiUnQC28uT5cHw39bmC7EG7DNZIdrqmOXMHrs+q4f/1S8CBsYS5ISogAGv3PKyPwBRkjAuy4eJKDy3gTCo7DFeLq2JnHAVtOYxXgW7DxBGYq6C+M3m+GlZnDaQu9JmPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/drRiTkJpiXLwzDMMfkyf5zJFFnRxlphj2PfuaNtPjU=; b=A+MhFhxAhyTx2SVsVeec1KFo9SSd9K69Td38AQBYxxwdZ67JQzpT+NDFewHm0kXcOr9nIWJ0pw2uplwwUDZf/oJ7HS9VJuSmN74P8+C+RscWDt301ACnSB+YdlwTdJIEmJoi/q7iaVeLnk/o2Baqu1d8vA3Qxd7/42XZ1+q35nk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 21 Nov 2022 15:29:50 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: xen-devel@lists.xenproject.org, jgross@suse.com, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Alex Chiang , Venkatesh Pallipadi , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0 Message-ID: References: <20221121102113.41893-1-roger.pau@citrix.com> <20221121102113.41893-2-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0257.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::10) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BLAPR03MB5378:EE_ X-MS-Office365-Filtering-Correlation-Id: d8d95f27-433b-4f1c-ed97-08dacbccdc45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fcp2tumsv4w90w3Eov5e0Sl9BP5S4KNl/NFYkhxCsuZMzqWjHjjy9oxrmE/3KhY/SXqePhwKQ2iexZaJ/McNCwhDxjRxTev6pnbyNBot4ysAkRsYQ5ZT91+secJ7x9LYiGm1LWdVLFle/eieOq/i/534azJejrrCW6tCjbvOuw+wAt+lIxS+8oXmu1bv+fc2gbi9ZEdIVrDk1wVsV9lrmd5ftGXDsMras/AUQfkaPiVSVqcCZj6CshPRq3VWPZ9pVUlTgexrGNgd20HUaUITdzj59s13wt0PpXrVfjoqVoX0ugj5NbT1HugK5j3tdgjFNNQIxPDdX95oBOvpb38zWw7YXXuZoD0ERpoJ9xnBenAsTQI2QQjDsHKO99hPUyQMD7UyJSKl5J6J76r1czNMcYl6yuMphQBojDJAXaJTS86KFg/xFZVfg1sCIBjBghgOyLKWjtWqGo4SjHkjnoiOOU57z8kKxfX0LWwRsmO/9RAUIo0y+5T82ptaeUAuMbeVfm3aqpqVbPlJeQnWvjCf9GGIGXfRIksYVKiDkvvLOQcngzmHzi5OjgFB7evoB3hv/1cBG09AqHercirfq/dlTxa3L6/B4TuPGWv6BHQRxJnw9ZyDJSRyztBOzgdi8G5BMec94jPq2O9N2DF/JLUL9w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(376002)(136003)(396003)(346002)(366004)(39860400002)(451199015)(66476007)(66946007)(9686003)(66556008)(38100700002)(4326008)(41300700001)(85182001)(316002)(6512007)(6916009)(26005)(8676002)(186003)(2906002)(5660300002)(7416002)(82960400001)(8936002)(53546011)(66899015)(86362001)(478600001)(6486002)(6666004)(54906003)(33716001)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3V1UnZhenBXeFd3ZmVtam1Vc3RoM3VzVlR4R1NUWTB6MEZqWnp5enFwMnI2?= =?utf-8?B?ZUdyWkNsVi9aZ2xLcS8xWDhiTHNuaEpXY3lxRmVkYWpSK3RBTENIRC9jZmli?= =?utf-8?B?U21wMlBKQUtQRUI0UkJxcHhXT1dobkY3RHlnYzF2UUdWTTVXN3ZaMERnNVpl?= =?utf-8?B?TjB3UmkzRTZlVEhXQ2htcG8wUWJ5LzlKNTk5bHFxSi9iclprRmp6TEJhdGVM?= =?utf-8?B?REt3cGxucmJub0JKU0pPaG92b1dCNmRhQU5pQjRYN2FudWgzcitST3kwRHFM?= =?utf-8?B?bHNkV2RKWlhmZnNZRG5IdnBBQzFjZUZYZHNrTnRqNWF3R1Ewb1RpcHBZZmtN?= =?utf-8?B?QTBZY1Mya2p2aFg0Q1RXTEFlWVZUUHAzUWhKRndwNFpPOVlFaWs0R3U1amFP?= =?utf-8?B?NHB1Ri9Lb3A2emFXcWtMeWNXbXovd3FQdHBuL2d3b2IvaGtZOXoxNzNHZ3Ft?= =?utf-8?B?QlBPNW5DRGZhZ0NnQ2RpdnN5SjlhVGJBbEVOU2R4bVRZdENkT1dXRmNzTXlP?= =?utf-8?B?a0hmd0NsQkg4dmV3MUF4VU9aUXdxQ1pudjZoOEgxK2VPQk13TmFHU2grelhz?= =?utf-8?B?NzcwdnZOT3I5aXZWWmFxd1VlT2ltTnRmcFlNSDJKVlhPZEVkZEE4ZDZIMGZ1?= =?utf-8?B?OWZaZzJ2SHpYLy9mR2FyOFBNeENHSWZrU21OUGxobVpaZWdRWDdndXJGT215?= =?utf-8?B?c0NjcVA1R1VTMFZPYlAvS2IxclhDbGJab0o0cXNoTlBkZnBrTVIxTVNuNERM?= =?utf-8?B?TjJlLzVackdnTDFnVUFOUnNZaXExVVExTnIvQkx4MjE0azVETlEwdEZRT3gr?= =?utf-8?B?RHlLUnNpOGpLQzl5d2NUa0pGanoxYjNoMzd2Qlo4V2ttd2pNSTN6cFBxTTgw?= =?utf-8?B?K3c3QzBwQXhvR014Zi9Ramw1b1EzS0ttRDBYTkZYTmZkTmlFdklMczVML0lZ?= =?utf-8?B?RER2R2VmeUROL3NhVUZKMmxVN3hKZ1JHeUsvT0V0elZwblJEcm9xWW1QMnZT?= =?utf-8?B?Y3g4QzkwenBLb05YdXJ5TVlad2F2VzNiNDByUlZxNDVjdmNCZ3hJWGJ3VkM2?= =?utf-8?B?ckE3bUdmS0p4WCtqVENhb2NhSzBkSGVnN0pVcGNHbkpEVndIYXdWbVJyTkM1?= =?utf-8?B?a2cvWVZZK1h3dDBLZ3R5VDI4SlJHL1JxSHo5bzdicVhxbHpXalN0aDJoQW1v?= =?utf-8?B?VHdEenN2cHByVDRaWjB0TFZ2SllLL3ZSb2ttREw1aW9VMjA4b3lWSWpubEJ2?= =?utf-8?B?TE11VUs3U0VoQkVyaHNFOUZ6bXFwemgxSDhocTFRYXQ5ZVdHM1lRVmNxb0s5?= =?utf-8?B?SlhiMUdnbkV6WkhGaXVVVkxJeHoyYXVyaWFab0M5WnhxNXZOQ0ovV3JvaVJI?= =?utf-8?B?dEZlSVdrUDB1dGcvdHVHTC8wSzRQRldKaURNN2szOG1jY0t5eXhKWWJnUFcx?= =?utf-8?B?U1d1TStKcnNEcS96MjQxdkZHT25zTElxN0EySC9oWXZjV2ZuV0NjK0Z6U0p3?= =?utf-8?B?cnZDRmgyZlJlKy9oWXZmbEhVcVovdVRwK3JxR21tb0FXckkzSC9pOEJka2p6?= =?utf-8?B?c2JCeEZMS0dYcWtHdWl5WGIvQ29ISExwOHU5Vm5BOFc4YUhMZ1RIb0hNcDFn?= =?utf-8?B?MTIwY005aE1rVTc1VmkxODYrTUh1eW4yVFQ2S1pvNUJ6UzB4SHB3aHBGclJq?= =?utf-8?B?TlVaNnBwa1oxeXFjaTJiS3hFNU5mOGRNeGRVem5WdXpsR3lxb0hiZFBWRm9a?= =?utf-8?B?SVQ5ZVQyMUR0M1R4a2NkUVRNdnl3UHRkcks3L3pBOTk3Y0VmMVJ5Z3ltdHU1?= =?utf-8?B?Rnh2cnFVZTZnS1Y0OXBlRlo3QjYwQnZGY0t4Vk50WU9rcGpNZWlCMFgzcGNi?= =?utf-8?B?aFlSeDE2RHlpTG5BNVNZSmVIY3NieEZ2R2taem5rZVRkWnZXRC9kMkgzcitM?= =?utf-8?B?OHVsOFJUWUllWFBhRWE0VnJkZWhpL1ZZYUdJVDlybGEvQ2tXa0NRWFNxelZr?= =?utf-8?B?Q2NvNE9hMmM5bERESVd6d0tFT01UbVpVVTFFOUg0cmlDSHBBY3Q5L1NaRDlX?= =?utf-8?B?d0NGaThZWTV1K3FrMGN6blNkNWVYZldJZ1dIRWhOK3MrdDVXN2JtbXRRNHdq?= =?utf-8?Q?yuTVttI7LGYABZUHb7uPnI/sN?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?N3VIR1pseTFBOVRmb1crb0N2MXRaL2V3cll3TWZCbHNoRDF4QUlJRk9NK1Bz?= =?utf-8?B?M0RUUFZXR3lCejd6Z2J2cFVqb2xSZU4zZ1ZCYk44b3VGeXJ4aFh0Y0U4QzJs?= =?utf-8?B?d20rdDlwY1pkOE54RHJhSGU5OElvNWNnNitibmtBazZ1NzFxRGg3MndRM0l4?= =?utf-8?B?TUFuckd5OFdHWm9BSnVDQlpzSVlxUkp6L1RDNjlYaXBmZVNjS283YndJL1ZB?= =?utf-8?B?ckk0Ulc3RWFMMVhJakI5TSt3UElia3BHaWllQzBVMEIweXlZdEV0eEx5UDVS?= =?utf-8?B?SlJNREo5V29qcGdlTjFpRjhWWE96M2I1SmNDc1pEcUJFdXZIU0hGWmVpQ3ov?= =?utf-8?B?L0lPc3E2MHBFNHhGREIybjU2aVppb1BlTnVKRWRqMkl4WVFXMGUwMldUOG5I?= =?utf-8?B?ODZoMmwvcEVpNGhWV1BHd0xocXVkdkVMUXJQVU9pbGNmL1daRDJJRkxiWm1Y?= =?utf-8?B?cWV3ai9raFUyWm1xTVdKRnlQdVo1VmZObVFuL21iVXA4UFh3OWRKcjhyenZy?= =?utf-8?B?bWtGOVJUSzluTHNWTnl4STF3VExtQ2oveGtCdjdaSSt0bHZUUWxrTFhqMUhH?= =?utf-8?B?ZXozcnZSSWl5VkNrbmNVbUkrNTAxeHhtUW1JMXdKdThJWmpCY3F6U1hGVkhy?= =?utf-8?B?akxmMlNKYzVqUnhRUldHTmZhVmdKR3R1LzlsQzlSUGpkdU45OFY4dEtvWHJ2?= =?utf-8?B?NmY1R1MyZkIvcUplVStwYlRzQlIwQzBmdWp3eTA1RFdsb3JXdzRDdEFtcmdj?= =?utf-8?B?ZWdLWFUwL0tsWE9aNHFVbllYMWRQMTlPcWtjai8wbEhqcEY0ZHZUN0thSzIw?= =?utf-8?B?M1dqVHhFVEpEQmdtNXc5Zys0WjJ2RFgwR0VTYmtRYWwyZXRPc1RqVGs0U0tW?= =?utf-8?B?QmZ1R2czcklzdlpXYktDSzY0aTE4dmd2elFDcWJ5ZzhmSCtBNkdzMkFJb2FM?= =?utf-8?B?TDJjeDYzck44ZXlod0FWaWNtdjBoaHYwVlFoWjdnVUFCTlg1aU9xV2s3d0dN?= =?utf-8?B?bUVkSWZFUUt3UElMMUVydmsyYXRkbnZsVVhsT25Ka054T2xjK1hhbUZST2I0?= =?utf-8?B?NFY4Rm5oQThhbzJKRkp5Z1NSNlphRlZULy83N0F4djk1Qll3T2l1eFROY29t?= =?utf-8?B?eERwQUpleDFxcCs2cS9VN29iMGNveFJjWjI2YzhSZk80TnJvQ2h5MmxLdlVG?= =?utf-8?B?bUZuV3Q5YmxxdzVod2I2MUdJY3llYzdHZnlveFdNRFQ0QjRGSXNuVUg5VGd1?= =?utf-8?B?azZOOTI3dGRQQ0h5dCtXOFRXY0dwSHMzRzN1K1FoUmk5Um16N3Fvb3Q3T01V?= =?utf-8?B?OFVMWW9CZngydWxXU0dIYjJGdWlzLzZCQ1piZjNEeURrdjAraDNRRTdIam04?= =?utf-8?B?d3BWc2N2SU9IWVRIN3dlQnFXNHVrNU1NajY4OEl0R0h4L2NBdzIwZGs5WDFP?= =?utf-8?B?MDBXdjhRM3RWK20zT01mSnFrZStaeFBFQ01WdGJFdWQzWU9tSTVjOXlVRUZU?= =?utf-8?B?VElFY1pnTDRsT3FLUGFhUTJndWE5V3NIaHZPcDZYdFIyWkhFOUNCU3hPTzVB?= =?utf-8?B?Tzk2UDFEUi90cm51UVI4b2YvRS9POHkrTExoWHFRN04xazFpczhoeUxsSCt4?= =?utf-8?Q?eWbNWNGduXMYunDu2LFP1tpr3ckpEhmdo/8Z4g8xZc9g=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8d95f27-433b-4f1c-ed97-08dacbccdc45 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 14:29:55.8339 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JNwHc2HGL68Xjyb/sHJMiDjjLFT+0r9UcdjDs2EOf50Ybm1o/7b/r/G+KRFClUrAobSrlpDygbIiprvIujkFxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5378 On Mon, Nov 21, 2022 at 03:02:30PM +0100, Jan Beulich wrote: > On 21.11.2022 11:21, Roger Pau Monne wrote: > > @@ -47,6 +49,15 @@ static bool __init processor_physically_present(acpi_handle handle) > > return false; > > } > > > > + if (xen_initial_domain()) > > + /* > > + * When running as a Xen dom0 the number of processors Linux > > + * sees can be different from the real number of processors on > > + * the system, and we still need to execute _PDC for all of > > + * them. > > + */ > > + return xen_processor_present(acpi_id); > > + > > type = (acpi_type == ACPI_TYPE_DEVICE) ? 1 : 0; > > cpuid = acpi_get_cpuid(handle, type, acpi_id); > > We had to deal with this in our XenoLinux forward ports as well, but at > the time it appeared upstream I decided to make use of acpi_get_apicid() > (which meanwhile was renamed to acpi_get_phys_id()). Wouldn't than be an > option, eliminating the need for a Xen-specific new function? While this would work for PV, it won't work on a PVH dom0, since the ACPI MADT table is not the native one in that case, and thus the Processor UIDs in the MADT don't match the ones in the Processor objects/devices. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Nov 21 14:37:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 14:37:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446650.702332 (Exim 4.92) (envelope-from ) id 1ox7vZ-0004fh-Hr; Mon, 21 Nov 2022 14:37:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446650.702332; Mon, 21 Nov 2022 14:37:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7vZ-0004fa-Et; Mon, 21 Nov 2022 14:37:41 +0000 Received: by outflank-mailman (input) for mailman id 446650; Mon, 21 Nov 2022 14:37:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7vY-0004fJ-0G for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 14:37:40 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0a9e9316-69aa-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 15:37:38 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a9e9316-69aa-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669041458; h=from:to:cc:subject:date:message-id:mime-version; bh=/mQb6IKbpG71pb7gDLB0PeGeWHy9p1e+43GdXuFxaE4=; b=QBc3YjD3YMOCPjV/K1QnSvxArNfldy+cWMdifQUKkcfBO8mZghcVYndU lwJHhZkPOpM1kdT5Ad43BYCNfhZBYvXjXnYNEXdSgXHyveYPO1MZ4tEjG XelXGXTDmrUQIKcVlOdHOBagpxpQ/QbgPFsCvyOIp1XnV7tlVzDtyDtpQ s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85675813 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Lb+iOqp0eN8arSpVsc36443ce5heBmIvZRIvgKrLsJaIsI4StFCzt garIBmBaPzcZWuheIoja42y8EwOuJDTmIQ1Hgc+rCA0HigS95uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzSBNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACkgbjGH1suk+piYe9tToM0nIsfBDapK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFHU/rSn8/x7pX7WxRepEiYuuwc5G/LwRYq+LPsLMDUapqBQsA9ckOw9 j+YoDmpW0py2Nq39RmP+Cr1hdXztz71d4UiLZei9t16qQjGroAUIEJPDgbqyRWjsWayVN5SJ FYd0jY/pqg1skqwR5/yWAPQiHKcpRsdR9p4GvU38h2Q0bHT5xuFB28CVXhKb9lOnM0/QzAwx 0KKt9zsDD1r9raSTBq11rqStyL0BiETIkcLfypCRgwAi/HzrYd2gh/RQ9JLFK+uksazCTz22 yqNriU1m/MUl8Fj6kmg1QmZ2XT2/MGPF1NroFWMNo640u9nTJeIZ62suHHJ19xjHbSmaFCFs nYuquHLuYjiEqqxvCCKRewMGpSg6PCELCDQjDZTInUxy9i+0yX9JN4NuVmSMG8sa59ZImGxP Cc/rCsLvPdu0G2Wgbibim5bI+Aj1uDeGNvsTZg4hfIeM8EqJGdrEMyDDHN8PlwBc2B2y8nT3 Kt3lu7yZUv28Yw9kFKLqx41iNfGBkkWnAs/v6zTwRW9yqa5b3WIU7oDO1bmRrlnsvPV/lSPq IoBb5fiJ/BjvArWO3i/zGLuBQpScShT6W7e9qS7idJv0iI5QTp8Wpc9MJsqepB/nrQ9qws71 ijVZ6KZoXKh7UD6xfKiMC44N+K3Acoh8BrW/0UEZD6V5pTqWq73hI93Snf9VeBPGDBLpRKsc 8Q4Rg== IronPort-HdrOrdr: A9a23:/ia8v6HjHiy0okX7pLqE/MeALOsnbusQ8zAXP0AYc3Nom62j5q STdZsgtCMc5Ax9ZJhCo6HkBEDjexPhHPdOiOF7V4tKNDOW2ldAR7sN0WKN+VHd8lXFh41g6Z s= X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="85675813" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Anthony PERARD , Henry Wang , Daniel De Graaf , Daniel Smith , Jason Andryuk Subject: [PATCH for-4.17 0/2] Even more XSA-409 fixes Date: Mon, 21 Nov 2022 14:37:29 +0000 Message-ID: <20221121143731.27545-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain Once more, with feeling... Patch 1 has been posted previously, but has accumulated another bugfix. Patch 2 has been discussed on list, but this is the first posting. I've confirmed that it fixes the issue reported by OSSTest. Andrew Cooper (2): tools/libxl: Fixes to libxl__domain_set_paging_mempool_size() xen/flask: Wire up XEN_DOMCTL_{get,set}_paging_mempool_size tools/flask/policy/modules/dom0.te | 3 ++- tools/flask/policy/modules/xen.if | 2 +- tools/libs/light/libxl_dom.c | 10 +++++++++- xen/xsm/flask/hooks.c | 6 ++++++ xen/xsm/flask/policy/access_vectors | 4 ++++ 5 files changed, 22 insertions(+), 3 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Nov 21 14:37:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 14:37:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446651.702338 (Exim 4.92) (envelope-from ) id 1ox7vZ-0004k0-Qy; Mon, 21 Nov 2022 14:37:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446651.702338; Mon, 21 Nov 2022 14:37:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7vZ-0004io-N0; Mon, 21 Nov 2022 14:37:41 +0000 Received: by outflank-mailman (input) for mailman id 446651; Mon, 21 Nov 2022 14:37:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7vY-0004fK-B0 for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 14:37:40 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b2a6ea2-69aa-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 15:37:38 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b2a6ea2-69aa-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669041458; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=BEhUtYQiNhE+S6ZLJyiIO/s+cSj9YjkEWslisUg9O84=; b=H5dic1/lST5EKLy8RxHC+1zJDAtWXuKe1scUfR4qlObhCkAl+YOB7g1T 6F8YO3vRKD3BbznzBkVBs6hTzvvRRqssnEoMnJLrZTUIP90QRkIpKXl/p 71PWdLKWydphr2qHg2blCOan7KyAcJLRnHQLAV+N6vYL3EX858Y78uq9S o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85274744 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:oaQB36NGvw4EYGLvrR3Jl8FynXyQoLVcMsEvi/4bfWQNrUp00mMPn GtMXG+Ob/uPN2TxfI12PI3j805U6JTUx4dqTAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5AVmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0u9ZIkYT/ KZBEmwmN0upi73p4b+JFeY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w/N3wsYDUWUrsTILs4kP2lmT/UdDpApUjOjaE2/3LS3Ep6172F3N/9KoHQGpkKwhrwS mTu/0CoOg5KJtem6mSCw3jytMSX2j7fcddHfFG/3qEz2wDCroAJMzU2WF2hsL+Gg0ixc9tFL gof/S9Ghbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6k6nMsF2AbLoZ87YlvGGJsh gThc87V6SJHuZO2bi+UrO6u8RjrYgIZcjAjaB1bQl5QizX8m70bghXKR9dlNae6iNzpBD39q wy3QDgCa6Y71pBSifjilbzTq3f1/8WSEFZpjunCdjj9hj6VcrJJcGBBBbLzyf9bZLiUQVCa1 JTvs5jPtbteZX1hecHkfQnsIF1Kz6zfWNE5vbKIN8dJythV0yT/Fb28GRknTKqpW+5dEdMTX GfduBlK+LhYN2awYKl8buqZUpp0nfm+RI6+Cq6MMrKih6SdkyferUlTibO4hTixwCDAb4liU XtkTSpcJSlDUvk2pNZHb+wczaUq1kgDKZD7HPjGItXO+eT2WUN5vp9fbgDRP7hlsP3ZyOgXm v4GX/a3J9xkeLWWSkHqHUQ7dDjm8VBT6UjKlvFq IronPort-HdrOrdr: A9a23:Vkj/tKtZPkAEFi9VuPyHl7Pl7skDdtV00zEX/kB9WHVpmszxra +TdZUgpHnJYVkqOU3I9ersBEDEewK/yXcX2/h3AV7BZmnbUQKTRekIh7cKgQeQfhEWntQtsZ uIGJIRNDSfNzRHZL7BkWqFL+o= X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="85274744" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Anthony PERARD , Henry Wang Subject: [PATCH 1/2] tools/libxl: Fixes to libxl__domain_set_paging_mempool_size() Date: Mon, 21 Nov 2022 14:37:30 +0000 Message-ID: <20221121143731.27545-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221121143731.27545-1-andrew.cooper3@citrix.com> References: <20221121143731.27545-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain The error message accidentally printed the bytes value as if it were kB. Furthermore, both b_info.shadow_memkb and shadow_mem are uint64_t, meaning there is a risk of overflow if the user specified a stupidly large value in the vm.cfg file. Check and reject such a condition. Fixes: 7c3bbd940dd8 ("xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls") Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Henry Wang v2: * Retain PRIu64 * Check for overflow For 4.17. This is a low risk change, removes one overflow case, and makes an error message accurate. --- tools/libs/light/libxl_dom.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c index fa5c79e4f650..b454f988fbc5 100644 --- a/tools/libs/light/libxl_dom.c +++ b/tools/libs/light/libxl_dom.c @@ -1458,10 +1458,18 @@ int libxl__domain_set_paging_mempool_size( shadow_mem = d_config->b_info.shadow_memkb; shadow_mem <<= 10; + if ((shadow_mem >> 10) != d_config->b_info.shadow_memkb) { + LOGED(ERROR, domid, + "shadow_memkb value %"PRIu64"kB too large", + d_config->b_info.shadow_memkb); + return ERROR_FAIL; + } + int r = xc_set_paging_mempool_size(CTX->xch, domid, shadow_mem); if (r) { LOGED(ERROR, domid, - "Failed to set paging mempool size to %"PRIu64"kB", shadow_mem); + "Failed to set paging mempool size to %"PRIu64"kB", + d_config->b_info.shadow_memkb); return ERROR_FAIL; } -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Nov 21 14:37:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 14:37:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446652.702353 (Exim 4.92) (envelope-from ) id 1ox7vb-0005A8-43; Mon, 21 Nov 2022 14:37:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446652.702353; Mon, 21 Nov 2022 14:37:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7vb-00059x-0H; Mon, 21 Nov 2022 14:37:43 +0000 Received: by outflank-mailman (input) for mailman id 446652; Mon, 21 Nov 2022 14:37:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox7vZ-0004fJ-0C for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 14:37:41 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0c986450-69aa-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 15:37:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c986450-69aa-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669041459; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=EOhf4hatGmnjIQxVt5++g1lD6WQQosxGmgv1LZ7z5fo=; b=eK1oDvPIwQeJ3+BpO+YBHJriaQEyNvEj0RYVsw7PoepQm9lvhGnLRGlA Pv2bGAecv1JYIrfMdMpiv5/97bdX6p6YZB+Cwj6C/ZAfhTnul/jO1GoTJ YQlMRrqvxColqPviJetjAhg6LZYUeCXBD5lI09tDzkmyE9oId/KNe7r8/ Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85675817 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:xqAwXqgw6BT1X8eHNW5fg4G2X161VxAKZh0ujC45NGQN5FlHY01je htvW2rTa67fMWqkftp/PI21pBsGuZfTytFqSVNq+ypmQiMb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QWHzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ0LgoKd0mJp9uwybK+S8xChMsPHPnSadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQthbF+ D2brz2mav0cHPKuyRTb9lzrvcqMjQnkab0MNue39sc/1TV/wURMUUZLBDNXu8KRhlalXtNDK 2Qd4ic0sbUp70uvU8X8WBuj5nWDu3Y0WdNWH/cr9QKlxa/d4gLfDW8BJhZhZdo8pYkJTDol/ laTmpXiAjkHmK2YTzeR+6mZqRu2ODMJNikSaCkcVwwH7tL/5oYpgXrnQtlvHaGvh/XpCDrwx HaMtyF4iLIN5fPnzI3iowqB2Wj14MGUEEhlvW07Q15J8CtVYrSiftWiyWHd5PZFLaO3TFatj Eg9zp32AP81MbmBkymEQeMoFb6v5uqYPDC0vWODD6XN5Bz2pSf9INk4DCVWYR4wb51aIWOBj Fr741s52XNFAJe9gUabiaqVAt9i86XvHM+Nuhv8PosXOcgZmONqEUhTia+sM4PFyhJEfUQD1 XCzL66R4Y4yU/gP8dZPb751PH9C7nlWKZnvbZ761Q+79rGVeWSYT7wIWHPXML5pvf3V+l6Jr Y4DXydv9/m4eLSvChQ7DKZJdQxaRZTFLc2eRzNrmh6rfVM9RTBJ5w75yrI9YY1195m5Zc+Rl kxQmyZwljLCuJEwAV/UMS8yMO+zA8sXQLBSFXVEAGtEEkMLOe6HhJrzvbNuFVX73ISPFcJJc sQ= IronPort-HdrOrdr: A9a23:6m9Yhazw/I1oH7Nsel14KrPwLL1zdoMgy1knxilNoRw8SKOlfq GV7ZImPHDP6Qr5NEtMpTnEAtjjfZq+z+8T3WByB9eftWDd0QPCRr2Kr7GSpgEIcxeOktK1vp 0PT0ERMrHN5CBB/KXH3DU= X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="85675817" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Daniel De Graaf , Daniel Smith , Jason Andryuk , Henry Wang Subject: [PATCH 2/2] xen/flask: Wire up XEN_DOMCTL_{get,set}_paging_mempool_size Date: Mon, 21 Nov 2022 14:37:31 +0000 Message-ID: <20221121143731.27545-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221121143731.27545-1-andrew.cooper3@citrix.com> References: <20221121143731.27545-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain These were overlooked in the original patch, and noticed by OSSTest which does run some Flask tests. Fixes: 22b20bd98c02 ("xen: Introduce non-broken hypercalls for the paging mempool size") Suggested-by: Daniel Smith Signed-off-by: Andrew Cooper --- CC: Daniel De Graaf CC: Daniel Smith CC: Jason Andryuk CC: Henry Wang It should be noted that the original XSA-409 fix broke Flask on ARM but no testing noticed. c/s 7c3bbd940dd8 ("xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls") "fixes" the original breakage and introduced this breakage instead. For 4.17. It's a fix for an issue that OSSTest is currently blocking as a regression. --- tools/flask/policy/modules/dom0.te | 3 ++- tools/flask/policy/modules/xen.if | 2 +- xen/xsm/flask/hooks.c | 6 ++++++ xen/xsm/flask/policy/access_vectors | 4 ++++ 4 files changed, 13 insertions(+), 2 deletions(-) diff --git a/tools/flask/policy/modules/dom0.te b/tools/flask/policy/modules/dom0.te index f710ff9941c0..f1dcff48e227 100644 --- a/tools/flask/policy/modules/dom0.te +++ b/tools/flask/policy/modules/dom0.te @@ -35,7 +35,8 @@ allow dom0_t dom0_t:domain { setvcpucontext max_vcpus setaffinity getaffinity getscheduler getdomaininfo getvcpuinfo getvcpucontext setdomainmaxmem setdomainhandle setdebugging hypercall settime setaddrsize getaddrsize trigger - getpodtarget setpodtarget set_misc_info set_virq_handler + getpodtarget setpodtarget getpagingmempool setpagingmempool set_misc_info + set_virq_handler }; allow dom0_t dom0_t:domain2 { set_cpu_policy gettsc settsc setscheduler set_vnumainfo diff --git a/tools/flask/policy/modules/xen.if b/tools/flask/policy/modules/xen.if index 424daab6a022..6b7b7d403ab4 100644 --- a/tools/flask/policy/modules/xen.if +++ b/tools/flask/policy/modules/xen.if @@ -92,7 +92,7 @@ define(`manage_domain', ` allow $1 $2:domain { getdomaininfo getvcpuinfo getaffinity getaddrsize pause unpause trigger shutdown destroy setaffinity setdomainmaxmem getscheduler resume - setpodtarget getpodtarget }; + setpodtarget getpodtarget getpagingmempool setpagingmempool }; allow $1 $2:domain2 set_vnumainfo; ') diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 391aec4dc221..78225f68c15c 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -822,6 +822,12 @@ static int cf_check flask_domctl(struct domain *d, int cmd) case XEN_DOMCTL_get_cpu_policy: return current_has_perm(d, SECCLASS_DOMAIN2, DOMAIN2__GET_CPU_POLICY); + case XEN_DOMCTL_get_paging_mempool_size: + return current_has_perm(d, SECCLASS_DOMAIN, DOMAIN__GETPAGINGMEMPOOL); + + case XEN_DOMCTL_set_paging_mempool_size: + return current_has_perm(d, SECCLASS_DOMAIN, DOMAIN__SETPAGINGMEMPOOL); + default: return avc_unknown_permission("domctl", cmd); } diff --git a/xen/xsm/flask/policy/access_vectors b/xen/xsm/flask/policy/access_vectors index 6359c7fc8757..4e6710a63e1b 100644 --- a/xen/xsm/flask/policy/access_vectors +++ b/xen/xsm/flask/policy/access_vectors @@ -180,6 +180,10 @@ class domain set_misc_info # XEN_DOMCTL_set_virq_handler set_virq_handler +# XEN_DOMCTL_get_paging_mempool_size + getpagingmempool +# XEN_DOMCTL_set_paging_mempool_size + setpagingmempool } # This is a continuation of class domain, since only 32 permissions can be -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Nov 21 14:45:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 14:45:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446668.702368 (Exim 4.92) (envelope-from ) id 1ox83W-0007MX-0V; Mon, 21 Nov 2022 14:45:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446668.702368; Mon, 21 Nov 2022 14:45:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox83V-0007MQ-Tn; Mon, 21 Nov 2022 14:45:53 +0000 Received: by outflank-mailman (input) for mailman id 446668; Mon, 21 Nov 2022 14:45:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox83V-0007MK-G8 for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 14:45:53 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 311dfbad-69ab-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 15:45:51 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 311dfbad-69ab-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669041951; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=A0ZU3n4nkUZ/GkH/x9oCvJqzeawHZFknP0QjWtUFPRw=; b=J9VD08wB0ltp6d7Uu5XGjUWBq/V7DG4RCRU43NqpqspVJiYy4rUuuNzi Z6yKT6WBlZH93EGQrSmyiFP4Z5e/UeU+2NtUa7VQv2eE+cAKI6XeQpE9b Tpdl5BeGA+P4FQ7DXG7CHPu2FV+KsEGMyRgRt8YJA9zI+dlI1dNA07twH g=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85275705 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:4A6xKKASqVpeLBVW/0Xjw5YqxClBgxIJ4kV8jS/XYbTApDsi0zwPm DdMWzqBbvfYY2L1Ld0nad+z9RwP7ZTXm9JhQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpC5wRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwpMl7H2JQx 80hCTUjbQy6jb7nz5GLY7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/AZQinOCulz/nfidRsl69rqsr+WnDigd21dABNfKFJ4bVGJoNwy50o ErP5yPGMyARF+eylyTcwCiLg/XwnSTCDdd6+LqQqacx3Qz7KnYoID0bU0Gq58awjEGWUshab UcT/0IGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbizt1HUBdEGQHMoZ/8pZrG3p6j Tdlgu8FGxQxn7GLSmyvx461qB2xJREfcT4NRh8tGF5tD8bYnKk/iRfGT9BGGaGzj8HoFTyY/ w1mvBTSlJ1I05dVivzTEUTvxmv1+8OXFlJdChD/BDrN0+9vWGKyi2VEA3D/5O0IEouWR0LpU JMsy5nHt7Bm4X1geUWwrAQx8FKBvazt3NjgbblHQfEcG8yFoSLLQGypyGgWyYcAGp9slcXVS EHSoxhNw5RYIWGna6R6C6roVZp6nPaxT4+5CKiIBjarXnSWXFbWlByCmGbKhzy9+KTSufxX1 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuKLa0WDn2Pj9KjWZJiYe1bawTfNrxlsv7sTce82 483CvZmAi53CIXWChQ7O6ZKRbzWBRDX3azLlvE= IronPort-HdrOrdr: A9a23:T9rmQ60oZozy3oES/ygvtAqjBLAkLtp133Aq2lEZdPRUGvb4qy mLpoV96faUskd0ZJhOo7y90cW7Lk80sKQFh7X5Xo3SOTUO2lHYT72KhLGKq1aLdhEWtNQtt5 uIG5IOceEYZmIbsS+V2meFL+o= X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="85275705" Date: Mon, 21 Nov 2022 14:45:41 +0000 From: Anthony PERARD To: Andrew Cooper CC: Xen-devel , Henry Wang Subject: Re: [PATCH 1/2] tools/libxl: Fixes to libxl__domain_set_paging_mempool_size() Message-ID: References: <20221121143731.27545-1-andrew.cooper3@citrix.com> <20221121143731.27545-2-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221121143731.27545-2-andrew.cooper3@citrix.com> On Mon, Nov 21, 2022 at 02:37:30PM +0000, Andrew Cooper wrote: > The error message accidentally printed the bytes value as if it were kB. > > Furthermore, both b_info.shadow_memkb and shadow_mem are uint64_t, meaning > there is a risk of overflow if the user specified a stupidly large value in > the vm.cfg file. Check and reject such a condition. > > Fixes: 7c3bbd940dd8 ("xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls") > Signed-off-by: Andrew Cooper > --- > > v2: > * Retain PRIu64 > * Check for overflow > > For 4.17. This is a low risk change, removes one overflow case, and makes an > error message accurate. Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Nov 21 14:46:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 14:46:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446669.702379 (Exim 4.92) (envelope-from ) id 1ox83c-0007dO-9N; Mon, 21 Nov 2022 14:46:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446669.702379; Mon, 21 Nov 2022 14:46:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox83c-0007dF-5p; Mon, 21 Nov 2022 14:46:00 +0000 Received: by outflank-mailman (input) for mailman id 446669; Mon, 21 Nov 2022 14:45:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox83a-0007cM-MO for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 14:45:58 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 343357c0-69ab-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 15:45:57 +0100 (CET) Received: from mail-co1nam11lp2175.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 09:45:54 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by PH0PR03MB6464.namprd03.prod.outlook.com (2603:10b6:510:bd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 21 Nov 2022 14:45:52 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::5c96:fc3a:9d36:4a2e]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::5c96:fc3a:9d36:4a2e%4]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 14:45:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 343357c0-69ab-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669041956; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=hp9P61fgn1RuHvIj1Cz0V1fKbLBHYOGLcBRppAK30rY=; b=JrGIEOxMfxRbaoWIA+w65ZO28fdbhK6VQqxXmA6APfCrf0gy1xRGQQm6 OcHiikKKjvuOUC5nLzYEMHWXlXX4qPL0mZ2Hpo9SbDoXVEhPZEz69Iali DluTE9876IdFE/ztdA8kHwGzK8rT43mfLqbH/h8Qje7omLMHLDAOZ1zzr 8=; X-IronPort-RemoteIP: 104.47.56.175 X-IronPort-MID: 85253912 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:vzXvw65rhkHQq4GHP5x1zAxRtBrGchMFZxGqfqrLsTDasY5as4F+v mRLXD3VMqvZZWb1Lo91YYrjp0oC65CDm9dmTQA/rCEzHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkR5QeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m2 /BBExInTCG6vt2Z0JKrWLRP28URFZy+VG8fkikIITDxK98DGMmGaIKToNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Okkooj+WF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJPTuDjp6cw6LGV7jE9DDswRVSrnd6e1X75C5VAD 2sp5RN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgc/iTQsSAIE55zop9g1hxeWF9J7Svfq05vyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLzsZ6s8K7xooG9g UU5 IronPort-HdrOrdr: A9a23:QgsC06rAd5BM3/Rkkw9yblgaV5sDLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcItKLzOWwldAS7sSobcKogeQUREWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZa6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyR+49bLgFBCc/xEGFxdC260r/2 TpmxHwovzLiYD79jbsk0voq7hGktrozdVOQOSKl8guMz3pziq4eYh7XLWGnTYt5MWi8kwjnt Xgqwope+5z93TSVGeopgaF4Xiv7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twriGknqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYdU99WPBmcUa+d tVfYbhDcVtABWnhrfizzBSKemXLzAO99G9MxA/U4KuomNrdTtCvjYlLYQk7ws9HdQGOtl5Dq 3/Q9pVfPsldL5oUYttQOgGWse5EWrLXFbFN3+TO03uEOUdN2vKsIOf2sR92AiGQu1+8HIJou W2bHpI8WopP07+A8yH25NGthjLXWWmRDzojsVT/YJwtLHwTKfidXTrciFkr+Kw5/EERsHLUf e6P5xbR/flMGv1AI5MmwnzQYNbJ3USWNAc/tw7R1WNqMTWLZCCjJ2STN/DYL72VTo0UGL2BX UOGDD1OcVb90iuHmT1hRDAMkmdDnAXPagAZZQy09Jju7TlbLc8wzT9oW7Jlv2jOHlFrrE8el d4Lffujr67zFPGj1r10w== X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="85253912" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YUcspBl0LERqARwtM4FvS2vOaV5HjBCVBkcDXR0J9Yc8u0memeR8YJzqIB3bgpaNWDyLr7b9ewwZyBtAinXR/z0PS4SgBTLI8gil4LSu6zpTtN04Zgq5VpAcFgVbPWnkDv39fIeGzj88lFTx7AIghTso0kDMY5Y4V4nlkEd+1Gyfi/hAXe/zf3MDFSkanVqATnMXsTx1tC0WGO5ChmBcTI3ebnq/zHyyoZcVFz9j8qh5WaHMNEuhmgqlJ71TfjBk0ROGftOLjLPXdj3uq9mBALYhM3i5ha3klsXXDeM6Gf3o7NQxB9SFClubAnBTmI+zxUXi3JmDmjtilkhOqqbjAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hp9P61fgn1RuHvIj1Cz0V1fKbLBHYOGLcBRppAK30rY=; b=YlEmUNWgCGoj2jm8GNKmbbvOmewwPL/d+IXpnbepsTETRga7W7S7tNDRgBH7UHVwD5F0cYGU9HjfJYDkuuA+nhbjgzfOxDxg95vyTQHoQwBWDBH7u7+XIPG3xwhaFuwSbx1zWbVYb2CcLoZZCDzqer8ocV8UwLUcMz3Cif1eekk2xxhLSTip5jxEw2d1fev4RPd+Z7yY0l2iDSfdGNDtqV3ubQXGF/25dSu3dHok3dCobUT7JhSXueJLD0gqmwgAAB43fq/SY0bz9FYtrDKGjSVGhWCKXlmYaiB3HBWBEpGtmjyFJVDo2hnXwmKYiig1dqMeIVWJptDFvz1hcv7r5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hp9P61fgn1RuHvIj1Cz0V1fKbLBHYOGLcBRppAK30rY=; b=VPWjLfRdSJr6XmVyDSKuB/BR8C9xSb+kpyw3XzBASgDR3Myn2WM1l/JMs6K7ZJ5b2UDGMqfsBGUaZ5HSaQAM9e1b+IFT2yDPuTjXMU7jFlMmCHVzR21hDzp3LKFsfyXjJ3Iy3I9p0PK+ykJJnW7qAzVBWUcEGL2G3QEsCaZ1LJI= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH] x86/HVM: don't mark external IRQs as pending when vLAPIC is disabled Thread-Topic: [PATCH] x86/HVM: don't mark external IRQs as pending when vLAPIC is disabled Thread-Index: AQHY/aKo13OJiWHN50yw2/gbAohrPK5JdKIA Date: Mon, 21 Nov 2022 14:45:52 +0000 Message-ID: <4d53c50a-e91d-ec76-c884-152cb10feb86@citrix.com> References: <69b79ab2-0acc-5980-9a79-8c477aa33868@suse.com> In-Reply-To: <69b79ab2-0acc-5980-9a79-8c477aa33868@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|PH0PR03MB6464:EE_ x-ms-office365-filtering-correlation-id: 781eee5a-0cde-4a17-4ea7-08dacbcf16a5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NoiDJmGZxi0HoGd66WTAII7uxtoKASbfWhTwHT3szuv48Nnil87Oau+8wu7kYTqWhT08PQiDji76L40GQpP6zlVov4W22ZYkYM8BjrHbaH9m4CkV5JEhNyqGJHLJQxWxjDRjCghGOtbFy5dw7kAOxjTebMOuEMf6i5wBPMgHEaDJr3ft2Van9alVH8TvgMnyyUeDyUI+f9cCX/bWikaOyUuHHeNOieQrLlEPQqCB5lAlR4XB6wql+gixD3hV4DsnBnFDqzMA6Qb0LdYg2JiYGwnYV51BinIZdHGdY1bYrn7AwbIKfK4iurHVtN9ZRuh4yYW6GARhUwohQK3eKFRlt88RutpPXFl44Ke6G/CmQVLVcc6K8dn6FjwleYNQGpEcXQMIO//071stm3kWE+dPFyeSprFaWSDJ0cvDJCE7n1YWqhdBGzgIIOJORswOzlAKevA1lldP62f3q5XWP2n1j/8Lxwx1b6YfVMu+yZJqZdA8E1kyAGQ9INRJ1rdMSv3xnUGKUT8SeafciV+lBJ3aJPf5PxdoNDi73GggrU/UzTJmd5ids180EWid1RaT3XtkbuF07PF34l0SKgQ5cpLkuP9Rs/kuhoClJGZqcezTsKc6g6J8zpK+d2oRYPBqq3aNFZQ5ce2YHOrW30oIElnxUSpeUww3fOaM5jS2HAIEky+R1tii8IipaWL5U7d7A8IFuQJOsvv7Jc/0BvHRRbksRZTBZtzScucHt1OvlYMR0is6KunmV4CIVtqrgzicnuGq+osSGrIYjJOwj7+D0P3Qcw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(366004)(376002)(39860400002)(451199015)(53546011)(36756003)(31686004)(38100700002)(6512007)(38070700005)(82960400001)(41300700001)(86362001)(110136005)(31696002)(122000001)(107886003)(4744005)(5660300002)(83380400001)(6506007)(2616005)(2906002)(186003)(66556008)(54906003)(6486002)(64756008)(71200400001)(316002)(91956017)(76116006)(26005)(66446008)(66476007)(4326008)(8936002)(8676002)(478600001)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ckk1VjFDc1NJSENzMTQ2ZUY5Y05qL0dTaGMxZEFQZ3NudkNtVU9iU1duRmNi?= =?utf-8?B?TTB3QXl3cjNQbkpWYXdKamlrUVcxbG50Z2UzSTNMb0U4R21BcjhGcTJVd0ZD?= =?utf-8?B?emhBUE5LTGZxdTJ1RHFmalJFYmRudUwwcG1JRW05OFE1TXhRcDc0UkVPZ3NZ?= =?utf-8?B?MkI5UmwxVXF2cUxRZGVwY3pHR2tscnF1UlRRaHdWOUdhelRHRDdHYzd2MDFC?= =?utf-8?B?TytpUjNwQ1ljMUdZOXd6VEdEcVBkbmRNdGZQclJOWWl4UlpRVmU4NFdjU0FC?= =?utf-8?B?RlRVaGg3aENwTlF2TzZkNUxrK2hONGhFeWd3UWdVWXdsSTZmSjh0QTVJNzJP?= =?utf-8?B?Skx1WE5Ta01Ma0RyeUNDMFE1ZnFud1ozTkhMajNnS1dSdElheHhhSkZNd2ls?= =?utf-8?B?Z3haMDhzOG5DUTkzWm5IdnJYbVV6ZERmc09JQ0ZJbXhOdm4zU0F6cFZGek0w?= =?utf-8?B?WFp1YlhhckF6ZXd0TmRRMVB5OFlBUVc0dWJmWFhHUEpuUGtWYjlpMXk2c1da?= =?utf-8?B?SmVodnZqZmZJcm4xZWNwQ3JVZ0E4UTNaOXp1Yk5RV0Q3WUJoRTNyZm0yNVpt?= =?utf-8?B?ZEN5bWlJVFVTNXF6Zmp1N3VWVWxjTTZYMjFlUE0vNkkxT2VXOHRiWFJBOW1s?= =?utf-8?B?SzcxS2JGR2ZTeEpYTjhCd1IxbXgwb3RjUXVwcFVCRnFtMHkySlhPNnU1c2px?= =?utf-8?B?U2M4NEwwSml2eEdZQ08xUGJHUTZmY1BaRk5GdERUSHZncitMdUN3MWFlbXZN?= =?utf-8?B?Q0Z5UE9sUC90U2Z4cHhtN0VCNVU3TVNnZnJHQko1em8xbVhDVFdrMC9rSlU2?= =?utf-8?B?aHlYSmovb2Z0NHUvQTg5QUdOWkxNSWpvMktGdUpTeEJtNkdlSHJCSnkvNFQ2?= =?utf-8?B?RFViSnlVVGlVcittWGptSklTT1JKNWJqRG1WWGVTRmtzZUhUUGp0ZnMvSHkr?= =?utf-8?B?bVdVZFNCbGtCUVlNbDNOR1AxWXMxSGFWTTNRYThnQ3lYQ3Q0R1Z1N0lzOG9y?= =?utf-8?B?aklVNTFCSkhsVzdTQzVVU0FiYXA4Z3JtdTZEK0FjTHIzc0hPZ0lOeTc5SGRT?= =?utf-8?B?dVpaOFpIVDVGMU5DWFdvaWVxZ3pmTUt0bnpWMm14czRoaVlZZXYzTFl0SU96?= =?utf-8?B?Wm5SdXZKRjBmZS9TSldKZFA2Q0pZUndqYWloK0FRSUZ1aG9CaGdWeitwWHVp?= =?utf-8?B?a1RqRGwwYjViMk1waHc1TWdkMmE4dXhEWEw2OXpBRXc1NVRDZG1tRTE5bzNq?= =?utf-8?B?K0lVZXRway8zNG5tdHU2TDM3R1A1WFlnTXFERTFKK3lrT0hmNXZTNzlQNjNI?= =?utf-8?B?SnN2SjRienJMVnpJNEpYUnZNa0MrUGhoZ1ltdXVrc294TW1FL3FxYmtiRnI3?= =?utf-8?B?a1VGTFoydnpaUUc3N3QxUUZyYXVJTlNVOEVWU1g3ZTFjRjJ3bEhrL1hWQmxT?= =?utf-8?B?dUgrTmxiS2E2NzRnU1ZkY1Q5VHQ4TVRCeU9ZZ1hDcGlSY1hHUUZsUHd0b3d3?= =?utf-8?B?enhnS0h2Z3dHWk9MTDc2NjJPT2JadE12U3RJa2EyN2o5ZzB3MkwwY0YvSWlY?= =?utf-8?B?ekhkNEN3M29aZVM5RFVVVXZJMnVCd2YvZnVlWlJSRVM5MlN1MS9xYTNaVjJw?= =?utf-8?B?cFFDWE9oM2V4d01oYkpDWDdSYU5kNys4NVZVenZRQzJ6L1p3NWVxV1pGYVo1?= =?utf-8?B?WFlneFlkU2tHakI5Uk02c0VlV0hHblE2L0NMSGQ5Z3VqeTcrQ0VFdkxUWllR?= =?utf-8?B?Mnl3eGNZcjJTYlppMURjQy8yQWhRUmdSYVRoODhmSkI1TmNXV1lrVXNKM0dT?= =?utf-8?B?cmVLWDRpVUduSmV6N0lxa1FYbGVpckJlR2NOOE42M011dmFZUFM2by9Ja0dZ?= =?utf-8?B?RDZVaVAxbnVya1VkVFUwYjd2WWFQMGhVZnh1V2RmTGFjd0pkOGljamIrN0I5?= =?utf-8?B?dFovVHRoZU1Fd2RObFZLY0tqNUt3eGFGVGRWay9SbDd1b2JqV1F5TkVRR3p3?= =?utf-8?B?dE1vU2l3aG5MRVlkWmVYMDlMci9KUXJlT0VvbXNnQWZ5VFI5TFNlenV3dnFl?= =?utf-8?B?NndIZE5PZEREcjgrdzU2VjBDcjExR29ic3dXcnlHSjl3R0J1NnNPNjFCZ2pG?= =?utf-8?Q?QNSiK/gNqGY2mcAPZ9rCC0egw?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pUZlmYP0owY5Jet0ugW+Sdpc4ourz6CUjVx0CHAV/tySccAwx4bmyTkloTmYpF+A7ecLYcwJMPnrpAI17ggo5PkgyXQzwx0SdFe3kk2O042/iHGWWS7PmLsUJLys5lvNNoFPG/bSUVajG1X/O/LP5qWxHoNo70vEQjF4Qlp6V5a5dlXMOo4uXU8vdB4EgVLi53UgU34lnBlek7OBWzolr2PtyXYi/hGD/RjPNHspdfWfU6oP7wMSWasvCGdexfAFVxJ0pUgF1jcfefTDWfwG2L/Eses6KpQ/XvmOI3eCUbHNIa6uwC1KaAvFs6Ft+q/BkqWSfsHjzF4P3TUfbSNZSFIoeMwM2wTxBAS1sqwO3SiuQgJGdeI5OLXR+BjbWs1IGdf5xTwhxNYylvmOadhQg7S+tydd/DRM47Z/UH1VTeuLxTkvttk8paxbQeAe5ckOU6Viyehj/Dx660ONaSzM9mJa7CysWKjD0XY6O3ZQI/xg0bNHW1U8w95myqjy8XtXXasc5OBc0cbuZPAkQR21XDkxTi9YwVaQNIzgp5bHy8gM9xjdTvVqUdR7KYUr7zACNBM0Ga1oIUMuu2MBkvyrIFgFYw4n6OaWxqYWow7csVCpWxbBuHLf80efGwMtGIv20dn4c+irQf9CSGvuANVeQI9/zXRjNlRJN0sLDjL/kRgVWifvI40xxkmsQDaQJ/Ch8er6ej9e/iQY/Bf3S+Zivqhfb0nNn2i1/zzjmBEhTcNQ+4hSy+ux6nMztEvQpIW6+E4OQaVz7yPEwP+jk3G5rWVooqix0NVwZFQGfMrHmKZVebtLQbgFtuR0KMNmPuM04pWzjuCfk/viF2eouIgfCw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 781eee5a-0cde-4a17-4ea7-08dacbcf16a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2022 14:45:52.4322 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xhJmk9qpQkLr0vz7Q2/5GeEl5Z6/RDcYbY3Z74nJq1WG+KXmXsjoz0hJQyi6ej2HVCsmK2GAswCiBXWTA8LSprrqXMQ4Ru4dNMTvVBUr1e0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6464 T24gMjEvMTEvMjAyMiAxMjoxMywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEluIHNvZnR3YXJlLWRp c2FibGVkIHN0YXRlIGFuIExBUElDIGRvZXMgbm90IGFjY2VwdCBhbnkgaW50ZXJydXB0DQo+IHJl cXVlc3RzIGFuZCBoZW5jZSBubyBJUlIgYml0IHdvdWxkIG5ld2x5IGJlY29tZSBzZXQgd2hpbGUg aW4gdGhpcw0KPiBzdGF0ZS4gQXMgYSByZXN1bHQgaXQgaXMgYWxzbyB3cm9uZyBmb3IgdXMgdG8g bWFyayBJTy1BUElDIG9yIE1TSQ0KPiBvcmlnaW5hdGluZyB2ZWN0b3JzIGFzIGhhdmluZyBhIHBl bmRpbmcgcmVxdWVzdCB3aGVuIHRoZSB2TEFQSUMgaXMgaW4NCj4gdGhpcyBzdGF0ZS4gU3VjaCBp bnRlcnJ1cHRzIGFyZSBzaW1wbHkgbG9zdC4NCj4NCj4gSW50cm9kdWNlIChJTy1BUElDKSBvciBy ZS11c2UgKE1TSSkgYSBsb2NhbCB2YXJpYWJsZSB0byBoZWxwDQo+IHJlYWRhYmlsaXR5Lg0KPg0K PiBGaXhlczogNGZlMjFhZDM3MTJlICgiVGhpcyBwYXRjaCBhZGQgdmlydHVhbCBJT0FQSUMgc3Vw cG9ydCBmb3IgVk1YIGd1ZXN0IikNCj4gRml4ZXM6IDg1NzE1ZjRiYzdjOSAoIk1TSSA1LzY6IGFk ZCBNU0kgc3VwcG9ydCB0byBwYXNzdGhyb3VnaCBIVk0gZG9tYWluIikNCj4gU2lnbmVkLW9mZi1i eTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpBY2tlZC1ieTogQW5kcmV3IENv b3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCg== From xen-devel-bounces@lists.xenproject.org Mon Nov 21 14:47:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 14:47:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446677.702390 (Exim 4.92) (envelope-from ) id 1ox850-0008Vg-P2; Mon, 21 Nov 2022 14:47:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446677.702390; Mon, 21 Nov 2022 14:47:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox850-0008VZ-ML; Mon, 21 Nov 2022 14:47:26 +0000 Received: by outflank-mailman (input) for mailman id 446677; Mon, 21 Nov 2022 14:47:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox84z-0008VT-Eh for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 14:47:25 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 67f4ee67-69ab-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 15:47:24 +0100 (CET) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 09:47:15 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by SJ0PR03MB5886.namprd03.prod.outlook.com (2603:10b6:a03:2dc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Mon, 21 Nov 2022 14:47:13 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::5c96:fc3a:9d36:4a2e]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::5c96:fc3a:9d36:4a2e%4]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 14:47:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67f4ee67-69ab-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669042043; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=yXx8/D21ie/hTcCChUKVy4Q00hWiNLKaJ6gn9AWZOEA=; b=D2wp8EHX7RHrCT6IWJQ7yrh1JJOJXoSY3g1bIrjK42uG2FvG6tA/HoMO zQvjYoIknjBh/RYHKUE+bypzB56E6GP1J9XjqBH6Ql/62Xp7rU87yWaOL dGlcqu9Ci4+TIUsAL7DtIcAXbogzlU46ESN70ZVkCGaNOliJ83d55xr3W s=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 84835141 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:zeqvFa7mVOHEB5hm5v5T/gxRtAjGchMFZxGqfqrLsTDasY5as4F+v jYXWG7XOv2MZzDyL9wlOYzgoR4Fv57RxtZkTVM9qi9hHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkR5QeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m5 PhHcg4VUxu5qvux4riFFNN+ict6M5y+VG8fkikIITDxK98DGMqGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnUooj+eF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJOROblr6Iz6LGV7jQJOAI4WByBmuOwlmPgd/tOA EI69SV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq17r6JqRuiNC5TKnUNDQcbSSMV7t+lp5s85i8jVf5mGa+xy9HwRzf5x mnQqDBk3upMy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg= IronPort-HdrOrdr: A9a23:cRIY2KotBsdqLP65isxa5MIaV5sDLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcItKLzOWwldAS7sSobcKogeQUREWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZa6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyR+49bLgFBCc/xEGFxdC260r/2 TpmxHwovzLiYD79jbsk0voq7hGktrozdVOQOSKl8guMz3pziq4eYh7XLWGnTYt5MWi8kwjnt Xgqwope+5z93TSVGeopgaF4Xiv7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twriGknqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYdU99WPBmcUa+d tVfYbhDcVtABWnhrfizzBSKemXLzAO99G9MxA/U4KuomNrdTtCvjYlLYQk7ws9HdQGOtl5Dq 3/Q9pVfPsldL5oUYttQOgGWse5EWrLXFbFN3+TO03uEOUdN2vKsIOf2sR92AiGQu1+8HIJou W2bHpI8WopP07+A8yH25NGthjLXWWmRDzojsVT/YJwtLHwTKfidXTrciFkr+Kw5/EERsHLUf e6P5xbR/flMGv1AI5MmwnzQYNbJ3USWNAc/tw7R1WNqMTWLZCCjJ2STN/DYL72VTo0UGL2BX UOGDD1OcVb90iuHmT1hRDAMkmdDnAXPagAZZQy09Jju7TlbLc8wzT9oW7Jlv2jOHlFrrE8el d4Lffujr67zFPGj1r10w== X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="84835141" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=niw8r5LMfZhTidkGRY5v9nDilQl5qXbMmMssmi4DHVHqk3mEDsm3NiRKHYAzxZ/iVGlymiMNIuooAVQtw6w+HG6xUBePi+VFG0zhcyl/dX3IC/cPP0LFQR0cyZ1nBbU0eE9aXz1Z1cxrQ8/FBk5yR59lJ00H2+ZW1nVFnshKqnS+GTsmPO/HvQBrjxBl3uIApyd7HWqRmpCYgPDub8+g3xJyMCWcWPBsnxJwTXWfGZJ9qiXrXr4LHMv/MFhTbc656k9ajMN66jyCR++grJ1BQx+HAiFjuUqjafU0WHFhF1cHcYAJkhz5BBwZq6/2wCk73HGtVc+YhTlToLF05s8wxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yXx8/D21ie/hTcCChUKVy4Q00hWiNLKaJ6gn9AWZOEA=; b=aBYKa2+t5+/w8nA2KdvdTIYXAx2vrq2S3oGlenp3uLFFvjxBeAqwyP/HNfY6ve2Z08VqAqjy9AZrCAo3gag1QupHDHCFdxGHMumBmShbnKD5K14iIHZnbO88ylxHDQs+YmSpqZuVgA1kaRKK+h136FlIWbeQ+w0F7y1DgsNJ5B80OXJOFGDRhY385AErwRiP1kA2QMKFztyLkwfJHG8VcXHCXAWbmvFG71nRXL/6IuX9gOeffGiXCmUydRf0k+BerQlKUooxHw58iYSAITTY1OGE/a0Z8MRfVyVcTh2vpugQPOY8lUir4uNlWjfnP5lbXPqftcGsOIk3jOF1O5xwvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yXx8/D21ie/hTcCChUKVy4Q00hWiNLKaJ6gn9AWZOEA=; b=bQlZ7BEZCOhL6BsrV9WivYlIcFK2b28YEmCRscXFCVnelKEIQZduGI0/GH2ybAsCjlVQYkawzkVPAWYDb3NuOZWLV1sb+fMbr7jBDxq6pMADMd/lpzuA1Xsr9ZwZ/VLq+3RkKuRXBkZAa4W4vBh0l6TBUhJSmIkH6Ad8SQe/FaU= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Paul Durrant , Wei Liu , Roger Pau Monne Subject: Re: [PATCH] x86/Viridian: don't mark IRQ vectors as pending when vLAPIC is disabled Thread-Topic: [PATCH] x86/Viridian: don't mark IRQ vectors as pending when vLAPIC is disabled Thread-Index: AQHY/aLC8acXtzuGekaGc6l+6XhP265JdQKA Date: Mon, 21 Nov 2022 14:47:13 +0000 Message-ID: <5ac3bb24-1b2e-4ccf-5282-51e8b03921fd@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|SJ0PR03MB5886:EE_ x-ms-office365-filtering-correlation-id: ff0daafc-02a7-4ae0-5998-08dacbcf4706 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oAvZmnGgfzcO0vXp7G+J7OvuAC3Y9uAVI1yc9w3aUh5BjoczFFQCl4fhOkzUgSd54GEJR+hwLnX/y3MShVYEMjLgWriXij1F1+Mbr65eiGoUiyqY34Vg0GjaqODnFAs5nQpI91q09sHHXi/DNeYKWCaUVhsKXOTkpMG+3J/G6lQf/dnDVPx/DosjsssmYbN9apjK86QRXXL/iPXlBWmJ34ZGqzhpnwgmTRxtu7e2dPWuU6SmXUYdG5KQFPwPa5rlKldE0oXV528f8zPiRYpgfus7gWIBN1EczKRa47gP/qGS50xPL0o/huLhbi8C+AvO6Jm9xDhydf4/hdFU5mEMgAxsygmkOVQ1FTPKiDxpgM1p/cgewU0A7WmrgCKGkIcrWVIHtRCEI546JM77OUzDrjjO7kEhRE++LaQHziNttN8T2Gjprl8W4BPwaez5ilMS0vuyCkjmmVJIiWY57hiJWXisDiDexgMXY7p0nhtgYFs/LPsf5Z7GHCWX90WmPeL9GWOdubTiZha2+JPlIaGqFU7aqFSeMkw2+2a9ysFepRez6Qb7+jGwEriJ10m4KOHq28gRxEMRfmycL/IVBNfu0lDIVpPWX4iGGtj8CiKannmSCofREdVJEBs51jzzTg4PQD8X5WzLX6F3CBd0lMau+O6lS7JcTNfIpV26wpJREqQhtxZ8kPRvHkR5MOM6FKQWPxmjZaUG/oKHmasqc1swLU23cDyaSWMpaZZj70+qpkkcMIL3bBMoNFnf6n/hGl5a07To0ZGeHvo684dqLapeQQi22tSSJbnJby7js59K1lJEgKbVR/Bi2nSW7A5N69yh x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(366004)(376002)(451199015)(82960400001)(122000001)(38100700002)(26005)(38070700005)(31696002)(86362001)(6506007)(478600001)(6486002)(71200400001)(53546011)(5660300002)(8936002)(107886003)(4326008)(66556008)(8676002)(76116006)(91956017)(64756008)(66946007)(66476007)(41300700001)(316002)(66446008)(186003)(110136005)(4744005)(2616005)(2906002)(54906003)(6512007)(83380400001)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?blhoNGtSL1N5R3RHMEZHWjZMVlArNGlHejFib05Ec0lnTlpYNHBOQmFqS0pT?= =?utf-8?B?SUtkRWZSSTQ1K2V0ZHhaMWd4c083OW5JeXVXNTdOUGdzZzNrdFFqbnlmUTBT?= =?utf-8?B?SndhS09Da0hVdDZGM1lOb2xLM0cyeUg3eSt2L2hxalpzdlduckhOa3BXZkJZ?= =?utf-8?B?OFJuMU96YnJEQmE0QUJSRHM5ei9heTJRRnRjQUNValkrWG9TS1JxeU1QQytl?= =?utf-8?B?ZWN5L0xrWVhtMGtOMEYza05JQk82a3NZNzlhL1R0TnZZV1NFa3BCcVZSYi9U?= =?utf-8?B?Snl1cEFscEkzUHV4YnpMMW1CMnBuQXpwMmd2a1paNThQd2haWFVZa3RUMzEz?= =?utf-8?B?MlY4QUhudS83UTllbkY5RHVhNU4wRTE2MDM3MklCMFVQOW8ya1BiOVRPM1Zm?= =?utf-8?B?dTBuT2doMXlPTHpULzBlVXFzM2FlQVloU1FhU0lLRWFYZFkyclczMnZGWVJK?= =?utf-8?B?NmRiMFFGUFNmRmM2Zm1BVER4K1NjWU42TmxRQ2RmUERGbHR0ejF2Nms1SGs4?= =?utf-8?B?RDg5UVVVZFhCQzE1M1k5M3M2Ky9LT04zTUJVd3M5blNHSXh1bHRQa0tGKzd1?= =?utf-8?B?UG56ZW45UUUwVDdiN21YYUtCY1dZNDgrQWJwcmREajN4SmpYd3RCRG5xY1h2?= =?utf-8?B?NFNVWU5MZjA1U1phWXBQb2lYYnVuYmVFTHk1c0F1RThzZ2JTd05ROEVHeWs0?= =?utf-8?B?NFRTeFgrVHl2N1I1SUYxbkdtOElUZ2g0WlNPRjFsc0pZZXdLZ3psSTcvTXNF?= =?utf-8?B?NWhTL2VFOGo4R0dZaklBRXNPeHh4S0ZpRHBqMHFlemFMSHVKQjBKZnQvMHcz?= =?utf-8?B?UWMzREdmWThNMVFBUS94RXZZOTQvNzVJTk9OVDBFRWpmSVEybG92WnkzZWJI?= =?utf-8?B?aXlXU1NKbWFEY0hKdVgrTFFIVWFOYVBPblM5b01kUG56L3VMUEtDN2xCVHJj?= =?utf-8?B?NmVlOHZqUkFmZjc2UWdDSUxFK0M0bndIdUJ5WCtLNjdEUXA0bFNiWDNHbkV5?= =?utf-8?B?eUFNU2lzQWc4cm9CZUZ2Y29OOXdRUnpwclJZdmFtQXFNd3gwOTE2b0ljaEhh?= =?utf-8?B?VkJNamg2RTRyckxvS1p3amQvT0o5L3A4SEMvaDJOcnNwd1FkeTBmR1NLZm03?= =?utf-8?B?WEpMUzFKd1RXTU80cFNKcFhjZmowaVdSK210NUxLV21iVVNHSnN3MkV6Yk5M?= =?utf-8?B?WEVmQWlMTVBrbDRxYVJkTDlZQTlDNGF3ZnNYWGhJUDVuRVhyOXdsdHMrWlUx?= =?utf-8?B?SENRVzdmNFhid0h3SHM1b0htOTBJdWd4elFneEZRT3NpZjRneEVuVnFjc2xF?= =?utf-8?B?WEk3OHRRMnVQTFZQNVF0RnR4SThUY2psd1RZbi9pcXgyYWVEMlI0VHlEUUtu?= =?utf-8?B?MmdGYlJFTDFsTG1wVWxpTXc1eWpoZE55WDRoeVg3NzRZYmV6YzdVMlcwRjRY?= =?utf-8?B?TzdOY1B4NnBldncxRFYxSm9BZ3F5OXQyRVNhVmx6Rlh6b05mRHYzZ2lTRWVX?= =?utf-8?B?MHNuUEtXbVp3MzFPR0IrUGpqK0RxVk5yV1lnU05FNzhkRVE2LzBoMUZyWmd3?= =?utf-8?B?V1hhazFESmdqL3dlRWdYSEx2ckZEZGdzczVGSjVmL1owZklwSmJLdlFibk9w?= =?utf-8?B?NHltQk5RbEM4ZzU0N2JQViszYlVBV1hxS0l1OUFseEVWOTlCekZ2VkNaOGJJ?= =?utf-8?B?QnJIOXRSZ1ZoSmxaYVlTZ1c0UmpJQnEzekxNempxTUhPQTdUVllwaTFJZVNK?= =?utf-8?B?TmVzQmhTdXJJby9hWFFRdzY0cVg5SStIT3ViSDFITHdFbEhLODRKbzlpaFds?= =?utf-8?B?L3g1c0tKbUtLUXhGZXNLMlFSWCtqbVU1cGI2L1FQS043dkcrUGozb0tzN0px?= =?utf-8?B?V3MzbThXS2N3dEdFbkpSb1BVWGtZN2VtdTgvVkhFa3ZBQlphZUhSMFV0NWlx?= =?utf-8?B?VjBIeWVrdDhheHFrZFRPWUhKaDVYQlJ6Z1BDdjJvaXdOK3F4d1NvRHJQOUtx?= =?utf-8?B?QkJGaGJnQ2Y5cC9DU2xqNTE4Yy83L1RmcGZKckpMMTFqYXh3TXR3cTgyTkxV?= =?utf-8?B?TytKemZBTSttajFtSEVsOWVyZzZGcXN5bUwyVTdIWEdRMHdsMjMzSFRzcnM1?= =?utf-8?Q?ecv6PedxGIq2QaC3l8IOYWq3A?= Content-Type: text/plain; charset="utf-8" Content-ID: <6224057CBFA6A9418DFAF7B4FAA59AF7@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: NFKNQl8VI22t2LPxt1PMk6hZ6xpm4Ad4Za41zljbdlVBY+erLaKs70P1h50LdMKIDk8afyEnZSutt4Yv5cc5dNKUlHkIFe09w2c0UdWTHtAh/p7GZbqJ5cdikKmZNoRkhy8kjc+TYZi4L8CHZB/czpf0mfFpf9G2yCWvkXOKVmq6aVLOjyW+J3HP8us5pT0anMM4KdNAMHmJbyDSEVj1N/RhB0A46hrtLxFouzhx++4fxhxVh/2HgasmzNeDUetiD3MSJN4YCLHHVg+eEKTp24nxBv9Mn6syKKcVz7s7DbJpydDJJtc38x+ZQ9+YsgJjdjYH5t1xYu+5bS2wpqckpbYeDNLXn4GpLEcSs5POr/0Euq+PtDBbCZYYLOfl1PAhOlkplaC7qSzWInk4Y7qOApec3R9kKAAeGFTqe/FBJRW6D2MoRwZOf9D1h1XvubwvAQJA4QhJLM3baDhcTGI+HXjYjKa+JAEa/c/Zjti9cz27MnI/eSpgQmReRRlqc8Ch+Fhlow1n5BhbxQJ86L8eGGtP6TC2Jp6CMjzR6Zxz6JGdC+ZAHyvHIhSR0bjbz5Ik5p0fpMupdQnit1r66HIOfb8TutQRWXXbui0mAQso2xi5CE82PNb/okkKfhvYVVmGqsLzuRjncRhMB7ZQ+fNDx/ZkgrgeJ8EmPNKejJOyhAZnDg6c6WdXfgbZJ2UAq4HLVxNsi02b2h9BFpe3fUIcNW8E8CksAQwQ862rGBUd58AN8WBHM+THptfuFfbCIc9/r3PYgCCDoXZ2uPnQFTDJMqHur+ERRHaCLYDC+Aztar1zoLoO88F51wuneVNAHP2sNdlo9va8Wvbkm4JztmZIUrq2z8R5VmVcoC81dw/4bpg= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff0daafc-02a7-4ae0-5998-08dacbcf4706 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2022 14:47:13.6301 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WkqLvLvKz5jWEfMrMYzxpyCCXJawmr39+gqSqXAWOGeALXP+y3wmEoz6R3vXePxyePtC2VKkI5r5yoDW6xcecXAl+8s30ZcHmqgVVhiX/Yc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5886 T24gMjEvMTEvMjAyMiAxMjoxMywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEluIHNvZnR3YXJlLWRp c2FibGVkIHN0YXRlIGFuIExBUElDIGRvZXMgbm90IGFjY2VwdCBhbnkgaW50ZXJydXB0DQo+IHJl cXVlc3RzIGFuZCBoZW5jZSBubyBJUlIgYml0IHdvdWxkIG5ld2x5IGJlY29tZSBzZXQgd2hpbGUg aW4gdGhpcw0KPiBzdGF0ZS4gQXMgYSByZXN1bHQgaXQgaXMgYWxzbyB3cm9uZyBmb3IgdXMgdG8g bWFyayBWaXJpZGlhbiBJUEkgb3IgdGltZXINCj4gdmVjdG9ycyBhcyBoYXZpbmcgYSBwZW5kaW5n IHJlcXVlc3Qgd2hlbiB0aGUgdkxBUElDIGlzIGluIHRoaXMgc3RhdGUuDQo+IFN1Y2ggaW50ZXJy dXB0cyBhcmUgc2ltcGx5IGxvc3QuDQo+DQo+IEludHJvZHVjZSBhIGxvY2FsIHZhcmlhYmxlIGlu IHNlbmRfaXBpKCkgdG8gaGVscCByZWFkYWJpbGl0eS4NCj4NCj4gRml4ZXM6IGZkYTk2YjczODJl YSAoInZpcmlkaWFuOiBhZGQgaW1wbGVtZW50YXRpb24gb2YgdGhlIEh2U2VuZFN5bnRoZXRpY0Ns dXN0ZXJJcGkgaHlwZXJjYWxsIikNCj4gRml4ZXM6IDI2ZmJhM2M4NTU3MSAoInZpcmlkaWFuOiBh ZGQgaW1wbGVtZW50YXRpb24gb2Ygc3ludGhldGljIHRpbWVycyIpDQo+IFNpZ25lZC1vZmYtYnk6 IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KQWNrZWQtYnk6IEFuZHJldyBDb29w ZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Mon Nov 21 14:50:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 14:50:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446683.702401 (Exim 4.92) (envelope-from ) id 1ox87o-0001Vc-5u; Mon, 21 Nov 2022 14:50:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446683.702401; Mon, 21 Nov 2022 14:50:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox87o-0001VV-3F; Mon, 21 Nov 2022 14:50:20 +0000 Received: by outflank-mailman (input) for mailman id 446683; Mon, 21 Nov 2022 14:50:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox87m-0001VN-A9 for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 14:50:18 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cfa995c2-69ab-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 15:50:16 +0100 (CET) Received: by mail-ej1-x632.google.com with SMTP id n12so29021604eja.11 for ; Mon, 21 Nov 2022 06:50:16 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfa995c2-69ab-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VVRqdWgGLYqrv+2xsWOJNrqRSIn5rptDcdc9kWYSVc8=; b=HGYVU4PnAhNtY0kg9DzzLTS5u5onQmKmsEPFjN4u7MMBisxMMvsgGFv4bktmi4eFZJ 2VVHT1B3ylV3bNDWZYOKIh+iRL8FbMbjbbG8psZaEiEHJsJE2vSlAEb6L76/hWyIoDsr f7geCNPqvStnjiYieQaqeN14tZ6Ap69VmFl2IfDx0cz0mUTNOHo1f+mx1in01Fq2kAu9 ydT66SdKYreqbZTfH2vsSGGB++xsnKi186FpodVxRe5QSXYbJy5fCOlwXH1W7u0kNXNK D8tkq9mgJwtkV1GQ9XoE4Fxzq+MJeSu3aLjvfoZHq6er+/k/nPulU5V2HbyzgY+UbCPl dHCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VVRqdWgGLYqrv+2xsWOJNrqRSIn5rptDcdc9kWYSVc8=; b=IkaKGIvA7PC1D0jHxzAzH5ISrwqLFPSsrMx54zHle1auEOAHainjHn8fbkZPK9pcJT v2/WwOkfApxZv2STzp+bJTDS4viCgXSq0Uq0RU9aAeZTMjHvAxyW4DDZFzSlHwIB5gQS j/0kniM/hixM1EK/+uhZgrQZeB37oSHUH8SW/jM7smePPKOzjPUgNR7nFJQyG158P/4W kb7vRepx9n3jtm2kwqwMBRI/aWd2Vgk6xtUtVAHc2xpFz7JdMhDkEWP4/0Qe50NEQ+q4 XpcGhzW8PVQClJUdhWiOP+MDQ/P4VEwbFx8LMlVgJI/XQBVVsYQXXI8cVcaI2RVFL0OK g+sQ== X-Gm-Message-State: ANoB5pnpRoK7bsg4auvvd3HVj4ibkq7qg1Dgy47PyQUbL3lSfT6Ww5a9 PcKbvXO9jr2RxVjIIpaUfcDPgHNNDqazx0dvAvlISw== X-Google-Smtp-Source: AA0mqf6pK8MgyTRcFlHdqTuy6OtV8l5qLiOmuaci2Vk1IAz7EyrikBaA1n00ovBknTO9DwnC0lMD5KMWewEER3gL2sA= X-Received: by 2002:a17:906:2785:b0:78d:98a7:2e7 with SMTP id j5-20020a170906278500b0078d98a702e7mr262135ejc.535.1669042215831; Mon, 21 Nov 2022 06:50:15 -0800 (PST) MIME-Version: 1.0 References: <20221022155120.7000-1-carlo.nonato@minervasys.tech> <20221022155120.7000-3-carlo.nonato@minervasys.tech> In-Reply-To: <20221022155120.7000-3-carlo.nonato@minervasys.tech> From: Carlo Nonato Date: Mon, 21 Nov 2022 15:50:04 +0100 Message-ID: Subject: Re: [PATCH v3 2/9] xen/arm: add cache coloring initialization for domains To: Jan Beulich , Andrew Cooper Cc: marco.solieri@unimore.it, xen-devel@lists.xenproject.org, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Marco Solieri Content-Type: text/plain; charset="UTF-8" Hi x86 devs, I want to ask you some questions about this patch because in the previous version me and Julien have discussed how cache colors should be passed in domain creation. You should be able to read that discussion, anyway here is a link to it https://marc.info/?l=xen-devel&m=166151802002263 In short, using struct xen_arch_domainconfig works fine only when domctl hypercall is issued. That struct contains a XEN_GUEST_HANDLE so it should point to guest memory and must not be used when creating a domain from Xen itself (i.e. dom0 or dom0less domains). The easy way to go is then changing the domain_create() signature to require also a color array and its length to be passed in for these latter cases. Are you ok with that? See below for more comments. Another question is then if xen_arch_domainconfig is the right place where to put the coloring fields for domctl hypercall value passing. See below for more comments. I know that these two questions are very specific so let me know if something is unclear. On Sat, Oct 22, 2022 at 5:51 PM Carlo Nonato wrote: > > This commit adds array pointers to domains as well as to the hypercall > and configuration structure employed in domain creation. The latter is used > both by the toolstack and by Xen itself to pass configuration data to the > domain creation function, so the XEN_GUEST_HANDLE macro must be adopted to > be able to access guest memory in the first case. This implies special care > for the copy of the configuration data into the domain data, meaning that a > discrimination variable for the two possible code paths (coming from Xen or > from the toolstack) is needed. > > The initialization and free functions for colored domains are also added. > The former is responsible for allocating and populating the color array > of the domain and it also checks for configuration issues. One of those > issues is enabling both coloring and directmap for the domain because they > contradicts one another. Since that, Dom0 must not be created with the > directmap flag. > The latter instead frees allocated memory. > > Based on original work from: Luca Miccio > > Signed-off-by: Carlo Nonato > Signed-off-by: Marco Solieri > --- > v3: > - xfree() for colors array in case of errors in domain_coloring_init() > --- > docs/misc/arm/cache-coloring.rst | 14 ++++++- > xen/arch/arm/coloring.c | 57 +++++++++++++++++++++++++++++ > xen/arch/arm/domain.c | 7 ++++ > xen/arch/arm/domain_build.c | 13 ++++++- > xen/arch/arm/include/asm/coloring.h | 10 +++++ > xen/arch/arm/include/asm/domain.h | 4 ++ > xen/include/public/arch-arm.h | 8 ++++ > 7 files changed, 110 insertions(+), 3 deletions(-) > > diff --git a/docs/misc/arm/cache-coloring.rst b/docs/misc/arm/cache-coloring.rst > index b0f9a2e917..e8ee8fafde 100644 > --- a/docs/misc/arm/cache-coloring.rst > +++ b/docs/misc/arm/cache-coloring.rst > @@ -16,7 +16,7 @@ In order to enable and use it, few steps are needed. > (refer to menuconfig help for value meaning and when it should be changed). > > CONFIG_MAX_CACHE_COLORS= > -- Assign colors to Dom0 using the `Color selection format`_ (see > +- Assign colors to domains using the `Color selection format`_ (see > `Coloring parameters`_ for more documentation pointers). > > Background > @@ -114,6 +114,9 @@ LLC way size (as previously discussed) and Dom0 colors can be set using the > appropriate command line parameters. See the relevant documentation in > "docs/misc/xen-command-line.pandoc". > > +Note that if no color configuration is provided for domains, they fallback to > +the default one, which corresponds simply to all available colors. > + > Known issues and limitations > **************************** > > @@ -133,3 +136,12 @@ too) is set to 2^15 = 32768 colors because of some limitation on the domain > configuration structure size used in domain creation. "uint16_t" is the biggest > integer type that fit the constraint and 2^15 is the biggest power of 2 it can > easily represent. This value is big enough for the generic case, though. > + > + > +"xen,static-mem" isn't supported when coloring is enabled > +######################################################### > + > +In the domain configuration, "xen,static-mem" allows memory to be statically > +allocated to the domain. This isn't possibile when cache coloring is enabled, > +because that memory can't be guaranteed to be of the same colors assigned to > +that domain. > diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c > index 36eea2d6c0..a7b59f5aba 100644 > --- a/xen/arch/arm/coloring.c > +++ b/xen/arch/arm/coloring.c > @@ -23,6 +23,7 @@ > */ > #include > #include > +#include > #include > #include > #include > @@ -232,6 +233,62 @@ bool __init coloring_init(void) > return true; > } > > +int domain_coloring_init(struct domain *d, > + const struct xen_arch_domainconfig *config) > +{ > + if ( is_domain_direct_mapped(d) ) > + { > + printk(XENLOG_ERR > + "Can't enable coloring and directmap at the same time for %pd\n", > + d); > + return -EINVAL; > + } > + > + if ( is_hardware_domain(d) ) > + { > + d->arch.colors = dom0_colors; > + d->arch.num_colors = dom0_num_colors; > + } > + else if ( config->num_colors == 0 ) > + { > + printk(XENLOG_WARNING > + "Color config not found for %pd. Using default\n", d); > + d->arch.colors = xzalloc_array(unsigned int, max_colors); > + d->arch.num_colors = set_default_domain_colors(d->arch.colors); > + } > + else > + { > + d->arch.colors = xzalloc_array(unsigned int, config->num_colors); > + d->arch.num_colors = config->num_colors; > + if ( config->from_guest ) > + copy_from_guest(d->arch.colors, config->colors, config->num_colors); > + else > + memcpy(d->arch.colors, config->colors.p, > + sizeof(unsigned int) * config->num_colors); > + } Question 1: Here is the current hacky solution in action: using config->from_guest to decide whether to call copy_from_guest() or memcpy(). This is a no go for Julien (and also for me right now). In my current work, I tried to get rid of this field simply by calling copy_from_guest() only in domctl.c, but this solution still isn't easy to maintain because the config->colors.p field can either be a guest pointer or a Xen one and mixing the two semantics can be problematic. > + > + if ( !d->arch.colors ) > + { > + printk(XENLOG_ERR "Colors allocation failed for %pd\n", d); > + return -ENOMEM; > + } > + > + if ( !check_colors(d->arch.colors, d->arch.num_colors) ) > + { > + printk(XENLOG_ERR "Bad color config for %pd\n", d); > + domain_coloring_free(d); > + return -EINVAL; > + } > + > + return 0; > +} > + > +void domain_coloring_free(struct domain *d) > +{ > + if ( !is_hardware_domain(d) ) > + xfree(d->arch.colors); > +} > + > /* > * Local variables: > * mode: C > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index 2d6253181a..b4dd64dff4 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -23,6 +23,7 @@ > #include > > #include > +#include > #include > #include > #include > @@ -712,6 +713,10 @@ int arch_domain_create(struct domain *d, > ioreq_domain_init(d); > #endif > > + if ( IS_ENABLED(CONFIG_CACHE_COLORING) && > + (rc = domain_coloring_init(d, &config->arch)) ) > + goto fail; > + > /* p2m_init relies on some value initialized by the IOMMU subsystem */ > if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 ) > goto fail; > @@ -807,6 +812,8 @@ void arch_domain_destroy(struct domain *d) > get_order_from_bytes(d->arch.efi_acpi_len)); > #endif > domain_io_free(d); > + if ( IS_ENABLED(CONFIG_CACHE_COLORING) ) > + domain_coloring_free(d); > } > > void arch_domain_shutdown(struct domain *d) > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 40e3c2e119..97f2060007 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -35,6 +35,12 @@ > > #define STATIC_EVTCHN_NODE_SIZE_CELLS 2 > > +#ifdef CONFIG_CACHE_COLORING > +#define XEN_DOM0_CREATE_FLAGS CDF_privileged > +#else > +#define XEN_DOM0_CREATE_FLAGS CDF_privileged | CDF_directmap > +#endif > + > static unsigned int __initdata opt_dom0_max_vcpus; > integer_param("dom0_max_vcpus", opt_dom0_max_vcpus); > > @@ -3963,7 +3969,10 @@ static int __init construct_dom0(struct domain *d) > /* type must be set before allocate_memory */ > d->arch.type = kinfo.type; > #endif > - allocate_memory_11(d, &kinfo); > + if ( IS_ENABLED(CONFIG_CACHE_COLORING) ) > + allocate_memory(d, &kinfo); > + else > + allocate_memory_11(d, &kinfo); > find_gnttab_region(d, &kinfo); > > #ifdef CONFIG_STATIC_SHM > @@ -4025,7 +4034,7 @@ void __init create_dom0(void) > if ( iommu_enabled ) > dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; > > - dom0 = domain_create(0, &dom0_cfg, CDF_privileged | CDF_directmap); > + dom0 = domain_create(0, &dom0_cfg, XEN_DOM0_CREATE_FLAGS); > if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) > panic("Error creating domain 0\n"); > > diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h > index 3b563d3b90..0d2dfada10 100644 > --- a/xen/arch/arm/include/asm/coloring.h > +++ b/xen/arch/arm/include/asm/coloring.h > @@ -27,12 +27,22 @@ > #ifdef CONFIG_CACHE_COLORING > > #include > +#include > + > +#include > > bool __init coloring_init(void); > > +int domain_coloring_init(struct domain *d, > + const struct xen_arch_domainconfig *config); > +void domain_coloring_free(struct domain *d); > + > #else /* !CONFIG_CACHE_COLORING */ > > static inline bool __init coloring_init(void) { return true; } > +static inline int domain_coloring_init( > + struct domain *d, const struct xen_arch_domainconfig *config) { return 0; } > +static inline void domain_coloring_free(struct domain *d) {} > > #endif /* CONFIG_CACHE_COLORING */ > #endif /* __ASM_ARM_COLORING_H__ */ > diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h > index 26a8348eed..291f7c375d 100644 > --- a/xen/arch/arm/include/asm/domain.h > +++ b/xen/arch/arm/include/asm/domain.h > @@ -58,6 +58,10 @@ struct arch_domain > #ifdef CONFIG_ARM_64 > enum domain_type type; > #endif > +#ifdef CONFIG_CACHE_COLORING > + unsigned int *colors; > + unsigned int num_colors; > +#endif > > /* Virtual MMU */ > struct p2m_domain p2m; > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > index c8b6058d3a..adf843a7a1 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -314,6 +314,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); > #define XEN_DOMCTL_CONFIG_TEE_NONE 0 > #define XEN_DOMCTL_CONFIG_TEE_OPTEE 1 > > +__DEFINE_XEN_GUEST_HANDLE(color_t, unsigned int); Question 2: This color_t definition is employed because the guest handle for "unsigned int" (uint) is defined later (public/xen.h) and (citing Julien): > Hmmm... And I guess we can't define "unsigned int" earlier because they > rely on macro defined in arch-arm.h? So the solution could be to move everything up a level in xen_domctl_createdomain, where using uint wouldn't be a problem. If this goes to common code then should it be guarded with some #ifdef or not? > + > struct xen_arch_domainconfig { > /* IN/OUT */ > uint8_t gic_version; > @@ -335,6 +337,12 @@ struct xen_arch_domainconfig { > * > */ > uint32_t clock_frequency; > + /* IN */ > + uint8_t from_guest; > + /* IN */ > + uint16_t num_colors; > + /* IN */ > + XEN_GUEST_HANDLE(color_t) colors; > }; > #endif /* __XEN__ || __XEN_TOOLS__ */ > > -- > 2.34.1 > Thanks. - Carlo Nonato From xen-devel-bounces@lists.xenproject.org Mon Nov 21 14:52:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 14:52:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446690.702413 (Exim 4.92) (envelope-from ) id 1ox89V-0002ET-MP; Mon, 21 Nov 2022 14:52:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446690.702413; Mon, 21 Nov 2022 14:52:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox89V-0002EM-HM; Mon, 21 Nov 2022 14:52:05 +0000 Received: by outflank-mailman (input) for mailman id 446690; Mon, 21 Nov 2022 14:52:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox89V-0002EG-1Y for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 14:52:05 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062f.outbound.protection.outlook.com [2a01:111:f400:fe0e::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0f596ddf-69ac-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 15:52:03 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8679.eurprd04.prod.outlook.com (2603:10a6:10:2de::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.11; Mon, 21 Nov 2022 14:52:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 14:52:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f596ddf-69ac-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GwqsWwykpeERZjTrOKPKvPnUGAGfRD5RqV7xPoonMCqh/aamOa+XfTBMprUlBdXwj5EKYBvgzpu9b1JNf6QmiNCHum2Iko0PwYCHjYt1Vf1tWaLc4NGIkA9+Hl+i8JgYcg4WSgi4ynz/0ht6pc9yyzDzIfsyCZQ9pNdXXMwD1arVlD2c8flc5PZl4BSGRP7sAvKHlILiGKk5iMf/ZKAlVyKDxFpqbhLUfjdRY5GAXhuiNcyT+Qbsai7XpSMjVdVl+Xe+Wo8DV7H76CHs9Gf9NdIIxrVKXeMeo1fhmElDRx5/TI41xDsGFjkDu/ECGnPhh385+fHYOCk9xxYR15G7SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xSZcEztiLzwU5is5DeASIufqgCPwdgIddl565ZM4GGg=; b=ej0fz81qnsKeb8ji87w4pptrf2crZPVStg4KrB576jVe6kNqIM2PD2ugvJ/ICEIsscfbeJHbQuAvqEiC7aGYWxWgHnx5AilF5nlfpQnF6Ir3ZtTDSwqciq+uv9OsP+4Y0n4q+37JsPkOnKB8D0dSiR/gkYSVPXJzWSct/g/J3oQZeBzop1IJdUsSJZGa+zsQeeHC/JA4U8g7Rro5RgA4Xd7rP3hsFSUH39qVhqoFjZ6A+KUxjuJDX5kN1/Rmpr0t9PGhFSnEUGWYOkVkGuMmInRprAju+8ASnFVAkoWZDWRVqPljzAYQ7VY8dZWqSYbaeyDOXz3buGET83xRpnN2oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xSZcEztiLzwU5is5DeASIufqgCPwdgIddl565ZM4GGg=; b=Uov2Ha+I+9QYTw88tMO7H6k6bEuLZatlnaN2ikpeIj57kb+6AeyEEnr11GC+PazmR+ZSMnIT7say9RSV2eN0pNM+ebE+3B9IC89Sh1cPs9HkLjM6O6uEjcY7AeNpIQUENiOnnNK+/WZOGByYG6bXz9FTa/iQtisFc+25SW1tm+Vo+Wj3w9y9pPI5X/bbrQAxGjjMBJmgjZR9IEmZfPs1+mL4WLR6JilCtkreUwzzIFSn1B/JnYNaqsx1hS0bO4U046tMUnbrbPKMN4cuL5iC/Gh2f72B12p39a1BtBpTsASkzzYQxNmf/sh4Ndp4Ow75Ewt/7H0bKuC/Q+tskinPDw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <53a21308-0948-66c9-86e0-d576ab884567@suse.com> Date: Mon, 21 Nov 2022 15:51:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, jgross@suse.com, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221121102113.41893-1-roger.pau@citrix.com> <20221121102113.41893-2-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0019.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8679:EE_ X-MS-Office365-Filtering-Correlation-Id: 504646fb-802b-4079-739c-08dacbcff19c X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3NYzLrUZ077g3c72UED1CGwDpmviBsy6M0RwXvYah5ycOH+NVX5kQk9UNgcLQerkVWIIwM5LmptlaYVRlBm9War1vn+DuIWIRELhK/M/OQuW7t3oCIfu7plhm2Y+KstAjLebW2EPk04Rkw12GUg0+7JJYlW0YmBfAMMtHlIWIZBGdoEbhd1DLXkOC9cHWTE2B9iCH96xcOIlFOkpDnMeb5i5D8KYLEzR8amV1fXv1z4LSbSzC6Fo889q998bqpq6JUXXOXLP71cgpeaJyd20MC1U2f6/w+WtQMnPHu5AfAlui8xw6amanKqqnhusWx6RQV7ZWlDWHaJUyOgLLiK07TTFDQdpsl8AVoiVGEtPm4j3SX5ZWmKyJbgpRYl5AANsLj3e8801XvOUV0QGe/V5//ASDDIhpaIoHUM1CkY9gfnvHwj1lA2pUQR5wG8R6YTJALTrLmLboZIfjtj6D9TGTB742yZ68xtCE4cNR/boYDiAscWCVeTXtUjsjDv7AozlssmVMaINj7pKThmaYQp/y5EgndcCNt7KYks7Y6lpqgUdYnbIFgPhzrGBcSmCz6mrIAwFXoAlbzy4yASaoZWab4fv2vT11looaqrgETVWDHMfH4z94DVyMWS1A59eX+ATXQFioJWT1Q6ck3f9fjiG8vi2DtiSneJpaaQVGWbRFa1DVfmXDAeijc4OfXKqEcl9L9SLdAiQbIuypz4C7LgjfLi+CRvVelbaNUJH31mKEoA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(39860400002)(376002)(346002)(451199015)(4326008)(66556008)(5660300002)(36756003)(66476007)(2616005)(8676002)(83380400001)(66946007)(54906003)(316002)(6916009)(7416002)(86362001)(31696002)(8936002)(2906002)(38100700002)(6512007)(6506007)(26005)(478600001)(186003)(41300700001)(31686004)(66899015)(53546011)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkVYMDArUEJXdjcvMXo1Qk1EOUhDQ0Y4WUsrVGx6eEFORkhXeEhlOEJpVnU1?= =?utf-8?B?Wm1VV0lPYS9DTGpUc1VQajAwNVR6ejdzSjBsbXV1aitKVTBlTEFKVWdpNGRS?= =?utf-8?B?MmZuNThUMkNGbEp2ZlFPQUU0VVA0RkRiZHR0MnZJU2Y2aDFJUEF5TnYxOTFa?= =?utf-8?B?T2VaMkRQanQ2ZkNKZFNQcjB5TVlqTkUvSVVoYnpaOEdXOFFmRnFKWFhWbGpj?= =?utf-8?B?d2diQ0xvUllSQzJ0MGswS1VzM2hGUjJONTdMb0F3aUFHaUd3dmNGSXZTS1VK?= =?utf-8?B?MXhHZUFmYmhXUEM0YTlGbG1VOG9PdWtUUE1hcW9sTEw2eHdYUEh1R0pKNmZT?= =?utf-8?B?b2tkamNBYmtOUGdwcGdvcWtRWVVBck4zM3l6aUNUSWZMTW4vMHd0RzdHS0c0?= =?utf-8?B?OXNDMlRiNjMvWWc1TXRoWmhyVURDK3lndlNhR0RCbG5iWG9uV3k5eWVReHMx?= =?utf-8?B?V0VCVlV3NkdqSHl3cnA1K2FJL3MwTnZyT1F4VDMzQVpkNk1oSy9OalhpQmxW?= =?utf-8?B?QlJoQTltMG5xbUFnRllZOG9WWm5MTWpTNUNpelNITmJyeTB4d0F0Tjc1ODQv?= =?utf-8?B?QXRXaldpcTUzdWkybEdCOUx2VUUyZnc2Zk9xNGwwekVkamJCZmZsM1RIY2Zl?= =?utf-8?B?Z3VFZW1GVFVPZkZPdkVnU0pMa1RWc3ZHZXBKalhkQ0lRZVZMdmovS053RjhS?= =?utf-8?B?eG42a0dUSmgya1I1aWR1Q3d4N3NQZHEzc1JVSGtSZzdTK0tqeVA2eExxdHBt?= =?utf-8?B?RzZTWEdqVU5hS0Z5SGxSekp0SUE4OE1DUGpDUG1yTmtwOHV3NG9JQ0lsOUZK?= =?utf-8?B?VTJ5aURCV0JTd1BmdS9YVWNkZDB3NnlqYUo2V2ovd2pJcm1vZ2IvRkYrQzZz?= =?utf-8?B?MjFvUitwVWhHR3ZMcUptZVkyWEdmcFNlbzJnTFYzc3Npb0JYaTVSZFJMdlhn?= =?utf-8?B?b3JMSCt0OG9JSFFiMkFtNmRIdlRQYnQ4SHhVWGJseG80dFRyc3l1UFRjR3Nn?= =?utf-8?B?WENmZmY5QlpDK0FxeTBzc3JpWmNKWGRZMlVwNllmMzNiWkdjQk0zdFppa09j?= =?utf-8?B?V0N3bzNnUk1objl6VzR1bmw1SG5mRkhrYjdTbTVVSHk3VzE3YkRud29UM0pJ?= =?utf-8?B?ZGdlT0FSWVBFRHBQOHliYUlEMStvYlVmeUtKSXpNNU9rRE1tQ3RxV2s4Y1gx?= =?utf-8?B?R3dqRGdMbnJqMERyTllxaVZkOEFQMEdkOElHNnRaNVo4R0lhRXZZeXlMQlN2?= =?utf-8?B?d3JhZlJGZXg1c01oK3Q1eXp1ckFxaDVGMU9xK0ZuZld5SEd2Y251bTBWdXBs?= =?utf-8?B?R0llemxPeEVqalJpdUtCd0Y4OVFMQ2ZYRmFzcFlJS3hPMUxUNTRKdlRvcXZQ?= =?utf-8?B?WTdwYlRubjhUUjZOZ2JuTVlNdFN6NFE2VlVvQTVrcFpuTnVaZ2JqVnpJTDRQ?= =?utf-8?B?WTVSMFEwdlh5MkZXMzUzamU0ZXpyL1lZek5HaFFQU28vOU9kZmo2eWdHWm9t?= =?utf-8?B?b3lnbitnTVdtOFdoWmhYTkZoN2lJRUhZZ2xyQTg4RG9paThwV0tER2RON3p5?= =?utf-8?B?Q2grUmZRTis0dFkxZktpV0NhS3hJRXlDcGlkZGdPb2xJSkJLRmZSL09YRXNw?= =?utf-8?B?TmFEM1BXYkU3bG5EL1U4V29HdjdDaXpIOWszQzZwd1RycG5XWGZQMUx5NzNQ?= =?utf-8?B?VjFJcVhob09JdTFwVWpPNjNNajJMTHhyNjVBaytmczNnT2E2a1l1SG04c3dm?= =?utf-8?B?OUFyN3gvTm9pb0tCRGJzSVNPZHM5SXZzQ0IwcTQzS05QZWlPOGk3SW02NHEw?= =?utf-8?B?S0xLZFFwNFhKeDVnN2pGMm9KUkJmWHlKc0NraVFFbk9ybnpOUWk3L2xhSzda?= =?utf-8?B?ZXNsVzZsdU53WVJyZTk5VTdvYW82dERTcHFQRnVDRG1WaFNPaTVpcmhTY3FB?= =?utf-8?B?M1R2LzVqc1Z1YkIyUW82MFRjSVpTcFZpdXc3cU42RW5GYlBvMG9mdis3aDhK?= =?utf-8?B?RHdnQlJMc1hSS3B6K1Z3M0xYdkxjc2swUi9Zd1Z1RG5STXJQcjJFL0VPanND?= =?utf-8?B?VE5tVlFWNVk5dkpLV2t0ODZWRkNlbG0rZzI1d29xdER1dFkwZFg2ek1tVm85?= =?utf-8?Q?hBfbHye2Vo5kCgLDNtKv2+hWi?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 504646fb-802b-4079-739c-08dacbcff19c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 14:51:59.9827 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dPhZ8P0hb2xchzpuuJTIOo81cBY4J7yhoiqHcPlrpXvp6Fm2mG2Kq04PA8G+OxO2mn11I2gZhZ2lZ2xZBIS7MA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8679 On 21.11.2022 15:29, Roger Pau Monné wrote: > On Mon, Nov 21, 2022 at 03:02:30PM +0100, Jan Beulich wrote: >> On 21.11.2022 11:21, Roger Pau Monne wrote: >>> @@ -47,6 +49,15 @@ static bool __init processor_physically_present(acpi_handle handle) >>> return false; >>> } >>> >>> + if (xen_initial_domain()) >>> + /* >>> + * When running as a Xen dom0 the number of processors Linux >>> + * sees can be different from the real number of processors on >>> + * the system, and we still need to execute _PDC for all of >>> + * them. >>> + */ >>> + return xen_processor_present(acpi_id); >>> + >>> type = (acpi_type == ACPI_TYPE_DEVICE) ? 1 : 0; >>> cpuid = acpi_get_cpuid(handle, type, acpi_id); >> >> We had to deal with this in our XenoLinux forward ports as well, but at >> the time it appeared upstream I decided to make use of acpi_get_apicid() >> (which meanwhile was renamed to acpi_get_phys_id()). Wouldn't than be an >> option, eliminating the need for a Xen-specific new function? > > While this would work for PV, it won't work on a PVH dom0, since the > ACPI MADT table is not the native one in that case, and thus the > Processor UIDs in the MADT don't match the ones in the Processor > objects/devices. I wonder whether we can actually get away with this difference long term. I've gone back and looked at the commit introducing the code to build the replacement MADT, but there's no mention of either the reason for the changed numbering or the reason for limiting MADT entries to just the number of CPUs Dom0 will have. (Clearly we need distinct APIC IDs, at least until Xen becomes more flexible / correct in this regard. And clearly we'd need to "invent" ACPI IDs in case Dom0 had more vCPU-s than there are pCPU-s.) Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 21 15:04:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 15:04:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446696.702423 (Exim 4.92) (envelope-from ) id 1ox8Kx-0003rE-MP; Mon, 21 Nov 2022 15:03:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446696.702423; Mon, 21 Nov 2022 15:03:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox8Kx-0003r7-JS; Mon, 21 Nov 2022 15:03:55 +0000 Received: by outflank-mailman (input) for mailman id 446696; Mon, 21 Nov 2022 15:03:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox8Kw-0003r1-Lz for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 15:03:54 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b5326dbf-69ad-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 16:03:52 +0100 (CET) Received: from mail-mw2nam04lp2170.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 10:03:48 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BN9PR03MB6044.namprd03.prod.outlook.com (2603:10b6:408:119::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Mon, 21 Nov 2022 15:03:45 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 15:03:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5326dbf-69ad-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669043032; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=74gGC/+XVntRJWZO1FWJrYsJ1OH7xIwi7wtWaUh3H3E=; b=fTvQu5VWEjNZ9ww6+IPCe3BaBBPKKB5IPQA86/KFk+aZXMU8k3J+b7D0 5NIfkc3v8tiDP3ijb0jzmPH5tCSwBp9KA+rKp65t84pKXAVYRKwFDAs5v 4OIK956DO+3ODaMNM0PYKNk38WUJz/08r6XiMNtV82Cj01k2Sj+J8VYZz E=; X-IronPort-RemoteIP: 104.47.73.170 X-IronPort-MID: 85678752 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:vKkMAKp8vC6UcC6DWx1Tr57i+wheBmI0ZRIvgKrLsJaIsI4StFCzt garIBmEM/feYGf3LtB3a4Sx8UMO6MPXmNIxHlNrqnw8QiIa8ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzSBNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAAIrNhKbp+Lp/LyYCfI2us8SfZbQN5xK7xmMzRmBZRonabbqZv2WoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+OraYWNEjCJbZw9ckKwv GXJ8n6/GhgHHNee1SCE4jSngeqncSbTCN9MS+3nq6QCbFu7ykMeOhkseEqAp+jn1kuYdu0YF gsJ5X97xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqf+a2TtiiaIjUOICkJYipsZRAZ6tPnraktgR/VCNVuCqi4ipvyAz6Y6 zqNtiklwbIIkdQMyb647HjAmTunopWPRQkwji3LUWa1xgd4YpO5fYuu6Eid4fsoBIOYSFaGl GIJl8iX8KYFCpTlvCaVaOwJHbyvt7CJPVX0jVdxEt8h/jK29niLeYFW/SE4JUF1P8JCcjjsC GfD6V1555JJOnauK6htbOqZC9wj5brxCdP/EPvTa7JmeJF/fQKD1CJjf0id2ybqikdEuaUyP 52zcsu2C3seT6N9w1KeQ+YbzK9uzysmxEvNSp3hiReqy7yTYDiSU7htGF+PaP0pqaCJugPY9 /5BOMaQjRZSSuvzZm/Q64F7ELwRBX0yBJSzrtMNcOeGelZiADt4VKeXxq49cYt4magTjv3P4 ny2Rk5fzhz4mGHDLgKJLHtkbdsDQKpCkJ7yBgR0VX7A5pTpSdzHAHs3H3fvQYQayQ== IronPort-HdrOrdr: A9a23:Co7Uy68SM1lXbmLEKJ5uk+Gydr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdgLNhRItKOTOLhILGFuFfBOfZsl7d8mjFh5VgPM RbAtRD4b/LfD9HZK/BiWHXcurIguP3lpxA7d2uskuFJjsaD52IgT0JaDpyRSZNNXN77NcCZe 2hz/sCgwDlVWUcb8y9CHVAd+/fp+fTnJajTQ8aCwUh4AyuiyrtzLLhCRCX0joXTjsKmN4ZgC P4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GKN2QhtMTIjDMjB/tQIh6QbWNsB08venqwlc3l9 vnpQsmIq1ImjvsV1DwhSGo9xjr0T4o5XOn4ViEgUH7qci8YD4hEcJOia9QbxOcsiMbzZhB+Z MO+1jcm4tcDBvGkii4z9/UVytynk7xhXY5i+Ycg1FWTINbQr5Mqo40+l9TDf47bVTHwbFiNN MrINDX5f5Qf1/fR3fFvlN3yNjpZXg3FgfueDlxhuWllxxt2FxpxUoRw8IS2l0a8ogmdpVC7+ PYdox1ibBnVKYtHO1ALdZEZfHyJn3GQBrKPm7XC0/gDrs7N3XErIOyyKkp5dutZIcDwPIJ6d j8uWtjxC8Pkn/VeI2zNMUhyGGPfIz9Z0Wh9ihm3ek2hlWmL4CbcxFqSzgV4ridSrskc4jmss 2ISeNr6s/YXBTT8LlyrnPDsrlpWAwjuZ4uy6IGcmPLhP73AavXkcGeWMrvBdPWYEYZsyXEcz E+YAQ= X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="85678752" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mltunTYnAUfU4WRY+IRVktXiyg8yYenRpZ3mKWu2qBGADQV4ebaAo1g96O0V5aXb1PJc1fJQzTJP49WR5CR9l8DbMQlxnB26UanmTdObHcTlA1Vaho6B6pNNklQNhezGk2LG1xNaHUNop+jaySdj+XEQvCPyRoyZ+O9z91WZ22u9Ko+In65LM/p+0gXNfDC64wwiFf7gpDlhV6TS0giFVCqeJITMVmgogm33l0txZHBYLarFuCXFxqRCFXRpEmXk2WiGMhQO8soXZEmKwEDRwbmzYp4OublReI15pQzjfEEaLqPjFr2r9RA3ZOKBErG3T+fxQp0mIVgrG6kXwHO9Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G8kEk6AAysY2z/E7re01QoqsHZRMQRyyh0Cgrhc6VtM=; b=YXwt5N0W8JZ3pFcDBSlL/DqLrT84lJrpO9Hq21xWd2rojQYqYsIfE7Np5S6ZXAHBT2csBDj2mmnKCIqcxT+HuElhFJK6VeZ+Xz+aBZhzFt07XP8PwAkavudD4O6lLcR/5QrjgmPetwHi+m078ShmqHzliDaYVGkcLly2bGAyX3cWKIK1Z4Ze3J21+0AfBnNng5VMCJXgPprbFwoyvVpjzSfTBMbU+hnWr6l2zIn6xOgXc6q9xWcFVvOIIcFfsA3lt9uNUW7H0RMPQZ/5xslk3i7/lb+tSyldXXnz3hoY1mHpSkQNMXaZ51cukEkbIakdjsMxw2a8SHMKyV+XlcFqcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G8kEk6AAysY2z/E7re01QoqsHZRMQRyyh0Cgrhc6VtM=; b=gN7SD/xaTy0TOyu765GUUterW9xJdHu7JtC+PnU07shzyqQHVkil7lS/3rwEWJiSUy/UkdJI1XdU1doCnEsFzyNOiHOZmlHOXaMNzuS9CA+kmf/RBYseTYKSl/ntAkkI8nS8zeel9ngrYlEpboU4Z9bTkTvABB1qM/AqHjokjQM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 21 Nov 2022 16:03:40 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: xen-devel@lists.xenproject.org, jgross@suse.com, stable@vger.kernel.org, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] acpi/processor: sanitize _PDC buffer bits when running as Xen dom0 Message-ID: References: <20221121102113.41893-1-roger.pau@citrix.com> <20221121102113.41893-3-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0110.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::26) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6044:EE_ X-MS-Office365-Filtering-Correlation-Id: d31ff563-3920-49c6-8835-08dacbd195f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qXL89dQwxDeP2RA6Lk0o0+iLmmOSLBx/kimYmb7j/s2XvHOeoYCJNRxfsh0Cm8ye7wqMDEncV23iYM+H330CAT5G8blJe+BdRY5Oolw07ZHWxYL9zIlSENNRtMh/YRkf1m1CSUpLBv+blV7v36er8VoYxGJ1btLwzSLtrHig796i+5cOEL3goGHjXCkh20CTrjHh8WTXvOnpTnxW12LFYq5+NKkHC1jJL834jP/fgLvk2JolsJJ895BRfx+dSbfXCDmSPodtLhX9989TzSwjX7ZP0HhpF66uYuBa7jeigsS0AB2ANM/R09Z7FM7S2JCC5ptuf/P+ghwgK6c4GY1BxERUFpjMpSV3TSidBcVWvabiwcjIy0Q96pU7B3/6R9AJ87g8QUhN3Dy8MjSrYG251R+83x6RUkJx8L0O5onlqnifbZy1G+NW2YQhdLJ1i1HLIOvsiX4vvbT3A0D6kKoLUk3Cnz0/33hsdjE1FaPRt7rvHG4E8KuJ+tVHOGnUy9P1wHEzAe5In1CedF9EaBXZRkfosfoBA10bjzHCU7ZHzdFtqbBoyIndHwGdgMZEssoGJWRHUVw92VJBjiihmKEz1jicBEvUGJ68jYmX9MIvCsxbMFN/XWVS/OHmgeHXAbPpDuOM6X1giJb2v/Cx4lB48g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(396003)(136003)(39860400002)(346002)(366004)(376002)(451199015)(82960400001)(38100700002)(33716001)(26005)(86362001)(6506007)(478600001)(6486002)(53546011)(7416002)(6666004)(5660300002)(8936002)(4326008)(66556008)(8676002)(66946007)(66476007)(41300700001)(316002)(186003)(2906002)(54906003)(6512007)(6916009)(83380400001)(9686003)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWV4aVRjWm1TVEs0cGovVVBmdmQ5cHdiUmwrOXNYK1doZG1EcE4wVnhDSHIz?= =?utf-8?B?TlFYL2x1ZkF3RkVwNVJaak9ST2FuKzMxZDAvckdBUFhtZ1BLL05USmRpcHFh?= =?utf-8?B?Z1lYZitrTGppRUQ2SnB6M1hQVzE1VEVqbEFKczdMTWxSZzNHR1N6enhyNUEy?= =?utf-8?B?SGF2NjF5YnNtdDVuV3RZSUR2a0wvVHJwaWpubUxoUmZyS0FSSmtId1BQWHY0?= =?utf-8?B?Zll3Sndab0txSVo4TUZmNEVDUmRqbEl0ejJNS3Q3UGlzY0t3N3Nlai9oM01W?= =?utf-8?B?dWgxaDNDZUpSaTQwcFZwaHVsZ2FYRmxPcXFIK0VEQkFNVzVTS1B2NjFyVGxp?= =?utf-8?B?WmlIeUtkVnNoTWFHR3h1cUszSjlBdXEvczR6Q0pWV0Z5QStIKy9HcjltajFo?= =?utf-8?B?WmNWd3l5V0xYOUhJcWNtSFlHWXRRYVREYVNLT0g4VW1sbnFUUFMrdE40bWdl?= =?utf-8?B?V1YwK1MxSVlTRExqdzdRQ1ExMU9GY0Rpbzk0SGZwaXNhZThuaXl4dFcwNzhr?= =?utf-8?B?cko0VUd1TUlGTE0yOGNnTGpzaWhzcmlieEV3Wnh3c2NTOVViYzVqU2oxenJ1?= =?utf-8?B?RUsvajFFMVFuaTJqeVFnVVZjb0RtOVdrVnhlUEFyZmdpNDEwUmNmOGlIcGtE?= =?utf-8?B?VkdHTlBtYURKckRyc0dwRDhUS0pUTVQrS3VOY0UrdVBVUnRDdStVSExHMEZ4?= =?utf-8?B?d002SFFnZnpHaVd6eVFoRW9IaDhHRDZyNXdUaGVSd094UXpzaVAvZWdQcjhq?= =?utf-8?B?KzdxVGhkWEc0WS90aGxFdnFFelh0N0ptTHZLWnBXcXJUNVVzbUx0TjJScThO?= =?utf-8?B?VXdUWXBqdkhENFNMUnZwSmtXUzJ3d3JQNjQ5aXloUXdERkEzS1plR0N0OWcx?= =?utf-8?B?eWhCTlJSVEF3R0pQYVh1ZWo0VFhaZlV5a0RBa0VpclVZYW1MZEhoa2IvY0Fk?= =?utf-8?B?QXdZanVKRHBoY0k1cE5TNFg0OGFJNktZLzg0VXpRNVVaSXRlYmNPYzRHcmlQ?= =?utf-8?B?QjdyZTBlMDFkYmlER3BqYytURGFKWVpscURZSzFORjBkSlpwQ0szSFAwVWRq?= =?utf-8?B?amQwY25VbDdzYUlPaXVXbXhXQWorTTBqcnlIRk9JU1ZZVHYyQ3RJblREaXd4?= =?utf-8?B?elg1b3pDb05ObUkyWThuYmpSSjhMeDVsQVJ0QklvbmNuZi81eXFWVzJnQzZO?= =?utf-8?B?Y0tyYTZTR2ZPN3dORTFVUk9rZ1BBbUVjNENnWUZ3cDd5aEtPNjBTVGo2elha?= =?utf-8?B?anhWdFpVcEJkSmJldlRVcFJBT3MwQnBWcEFRNXN5U0xsby9wY1FSajZzTmVm?= =?utf-8?B?OFZ0NDlnRXFMZWo1VUV5TTRqOUg1eTJMay9KeHJ0bGJiTVVWdXcxOVRUNmRU?= =?utf-8?B?TUZLbGpicjgrNU92K2dpZldrNnNScEZWYS9OVExsOGQwbVUyRGlMUEVXajNu?= =?utf-8?B?d2FFeHMrUkhYSFJHUEQxVWlSSGdqeXR1N3VERVd1WXFoeGRETGxVNTlVOGRM?= =?utf-8?B?cERoUDJZRmJiRGhvS1NpaWIyUCtXMmU4RklaN3hDRGNnN2JYUnVrYUhCWnFo?= =?utf-8?B?RGpjWVlFTnlUcm15VmxVTm5HeUlSZW9MSmFTWUtaeHpFR2VFQWJ3MTBsMlpW?= =?utf-8?B?bTlxRWJiby9IcS9DdTk0SjVTWlpJeWJIeVRqTjBrZTh4UVZNYWxrUWdycXZr?= =?utf-8?B?aXJDZjFNSWNsY1dIekd0WitTSzJlak1mdG1rdy9FYzBQUW10RGN3TEUxRGVj?= =?utf-8?B?UzFqRlFFSHRqZG1zVXJ5NXlINTIweUMyeTRxZU1rRU1Cbk9DaXFqUzhrQTR3?= =?utf-8?B?MzdzZmNxZTB2RnlOQmRRdjllenRLOUZRcyttTVJZWjJweUFZbURQajkreG1Y?= =?utf-8?B?VEhEN2o2eFI5L2FPSDdzejJZMDA3bGVlU243WmtIVVh2VjJlR1R2d1FVVkxR?= =?utf-8?B?MTJjclprTHFUa3FicUt2Y05Xc1BUbERKdTZ0cWppdnVmSTZybXB2a1U1Y3hT?= =?utf-8?B?Z2xzWCtiTDJaWkdJTkRKSE16bjY0UDZvdU0xRUpPZURhMGh0dmdIY2piYTMy?= =?utf-8?B?VTQreEJqKzNnMnJlSHEvdGZtWDNZOGlwOEVYR1gwcXJmeGZBT2VMRzVuUkpR?= =?utf-8?Q?XsL3eq57KFADOErNtuR6PX7c/?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?d3F2RXVDL20yY0JNNmdWL0NSYXp6MitnN0phaDRyYm5Fd0JiblJmcVhtOXMw?= =?utf-8?B?VUYzNEVFbEhyakZSdUM5clVrNi85dUcwcTJsN2J4MnRQOGNwUFBqNHV4WkZ0?= =?utf-8?B?bEFGb0p3UlJKTnIxVVEzMzhnQW9oWW9NazBnZmlFMWIyZWlnbXVoQmhjWDZ5?= =?utf-8?B?S1JKWXpyUlJueWRYM1hLcmIxYzJXK2xVS2l3SHBWaWYxdFlpbmx2L3R6RmZN?= =?utf-8?B?bEZOdWJjV0FqRGVqZjZ0Z0Zia3oyZ1VZdDVWaWJTVnNjeFhJNmZrbUxuYjJs?= =?utf-8?B?ZFVnd2hvalJWRDVmSDNLVnlXYmNDQjZGaUNpMXUxdFJnZTNUZTcyMVhPOVVx?= =?utf-8?B?d2diRFVuL25way9XbHZMYVA2L0o3RFduQzlxUmY1UTc1MG5oMzNSVGpXN3NB?= =?utf-8?B?QzE3MHd1ZjBTa252TE1JUnl3TE1ScUdkdVNIZmtxT3ZYUkdGanlvdUxsNFRM?= =?utf-8?B?Q1FUS21lNm1Gc29tMHJlaHVaaW5ZcGRIajYwbC9aL2dWNG4rK0NIajZETW1Y?= =?utf-8?B?dDJ5eVAwWkJvY1AwYkRuMDlvc0xHRUxvRCt2Q1JzOFlUcW9QMjJMQjNrYUpC?= =?utf-8?B?clJLS255OUpZSnRhQUhsV0pwOElmME1abXpGTHgrcjBsNkZ2WCsxekNJeSt4?= =?utf-8?B?eTNmMDBGaUtheVdhZS9aVlh6d1JWc2drSmM1N29EczNBb05Eai8ycTZDVVB3?= =?utf-8?B?ZWRSVHpyUHZSa0RmTVVrekVSczM2ZWpRUlhQcGFJZ014dXEwV1BYNHZlWlpt?= =?utf-8?B?Nm54Qk5IMUlnUEFiZ0tINVM4ZE8wOG9ZVHpGNXViRVoxamlMRHN6NkFMQ2lG?= =?utf-8?B?UmRkL3RGZzF2UjVOTC91OFlqM20vWEg3RGt2cFBWRjZ0d08wNjJQOFhFWW4z?= =?utf-8?B?Qkg0UTRJSHBmUEh0S0p2N014ZXlQRGU1aUw5UmVMRlMzbEt0bExUaVB3VFRD?= =?utf-8?B?ei9GTVVuamlVM25hV1hNTEVtK1pGV0xKcXJJZytUVnIyUDAza3ZaanpHRElT?= =?utf-8?B?Z1N0QjZGaWZRSzhYSDJ5QjdtbjU4MHZ2ZzFUS2p6V3l3WFFzdWFvVWdyQnY3?= =?utf-8?B?N01OV0tOVlphckEzcFZLTHJ5WW8wMnRSWXQ1S3FKMDB2Y1liRlBOZXFObzNP?= =?utf-8?B?bXJZcVE4aFhvZ1Q5WjNheVdZdWFkVVVVQ2N4N1FUcG9KbXBacWdpYkRyK29H?= =?utf-8?B?RGpRcjZNSVJXS0wzdGdiQWhENXFXak9wWGlLc1REU0pzd2w4Uy8yQmtIdzh0?= =?utf-8?B?M2c3N3RzRUxSM1pnZ2FRNFVjZGFHTWlGZ1lhOTRCRmhGS3liWFFVUGUrMXk1?= =?utf-8?B?bXV3eEp0UEpwUHMrZzRsQ1liTjhKcmI2NTVTcnhLOWFWMlFsUUo3dU9xNmIw?= =?utf-8?B?SFBDREdpaHphenFINDBudlA4ZC9ja2xqVFJvVDBBOFF4cTlYSGhqRDN6b2xV?= =?utf-8?B?dXZuZ0xJQkF1RVpmVFZHTU9PL2VjeVBKVUFIaVhoamYzSHpWaDEvdXNDelV5?= =?utf-8?B?QTMzTkpwaDVpUnI4RWg1cy9XeVdCNVd5djRQdFBzZGt0c29XMjg1WDVhY0tJ?= =?utf-8?B?VVQ3b0QvT2psV09ZVjNiciszcGxKVWZpWEZMY0lXWlJlOXlQRERiSGZiS1RE?= =?utf-8?Q?YcatSdlcU72rUzeZ0H5cYLfdZjXvZcg2P2a/oOXyiTeI=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d31ff563-3920-49c6-8835-08dacbd195f9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 15:03:45.3306 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fs4TE4RXe+NAUmO3NF2xJXkNcPkdC9m9Z+q4u0tl5vOLp9UraRBfv9BrS6yYEZP8m8IcMsEembGfcj2dkO7Eeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6044 On Mon, Nov 21, 2022 at 03:10:36PM +0100, Jan Beulich wrote: > On 21.11.2022 11:21, Roger Pau Monne wrote: > > --- a/drivers/acpi/processor_pdc.c > > +++ b/drivers/acpi/processor_pdc.c > > @@ -137,6 +137,14 @@ acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in) > > buffer[2] &= ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH); > > > > } > > + if (xen_initial_domain()) > > + /* > > + * When Linux is running as Xen dom0 it's the hypervisor the > > + * entity in charge of the processor power management, and so > > + * Xen needs to check the OS capabilities reported in the _PDC > > + * buffer matches what the hypervisor driver supports. > > + */ > > + xen_sanitize_pdc((uint32_t *)pdc_in->pointer->buffer.pointer); > > status = acpi_evaluate_object(handle, "_PDC", pdc_in, NULL); > > Again looking at our old XenoLinux forward port we had this inside the > earlier if(), as an _alternative_ to the &= (I don't think it's valid > to apply both the kernel's and Xen's adjustments). That would also let > you use "buffer" rather than re-calculating it via yet another (risky > from an abstract pov) cast. Hm, I've wondered this and decided it wasn't worth to short-circuit the boot_option_idle_override conditional because ACPI_PDC_C_C2C3_FFH and ACPI_PDC_C_C1_FFH will be set anyway by Xen in arch_acpi_set_pdc_bits() as part of ACPI_PDC_C_CAPABILITY_SMP. I could re-use some of the code in there, but didn't want to make it more difficult to read just for the benefit of reusing buffer. > It was the very nature of requiring Xen-specific conditionals which I > understand was the reason why so far no attempt was made to get this > (incl the corresponding logic for patch 1) into any upstream kernel. Yes, well, it's all kind of ugly. Hence my suggestion to simply avoid doing any ACPI Processor object handling in Linux with the native code and handle it all in a Xen specific driver. That requires the Xen driver being able to fetch more data itself form the ACPI Processor methods, but also unties it from the dependency on the data being filled by the generic code, and the 'tricks' is plays into fooling generic code to think certain processors are online. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Nov 21 15:10:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 15:10:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446701.702434 (Exim 4.92) (envelope-from ) id 1ox8Qo-0004Tz-Aj; Mon, 21 Nov 2022 15:09:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446701.702434; Mon, 21 Nov 2022 15:09:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox8Qo-0004Ts-82; Mon, 21 Nov 2022 15:09:58 +0000 Received: by outflank-mailman (input) for mailman id 446701; Mon, 21 Nov 2022 15:09:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox8Qm-0004Tm-Cr for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 15:09:56 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8c7ae602-69ae-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 16:09:54 +0100 (CET) Received: from mail-bn7nam10lp2103.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 10:09:40 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB6748.namprd03.prod.outlook.com (2603:10b6:a03:40b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.24; Mon, 21 Nov 2022 15:09:38 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 15:09:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c7ae602-69ae-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669043394; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=vwhDoO7tdiRatKyOMWQlRx1p7KK5kwcmauffhQUAy4I=; b=KpedC5j19cOdQw3DMRDwXPx1VRhhMzhC1kDzI9kTB4csOXrLaUXOLkKD 9DNR6aQSvWJ7PAtgtpu8o/hj8C9NdnIFs1NpcX6/6hpkyTBO+T+93FfdP z5R56rkw2Ge17UElPMA7yR/JIGgzzOAqO2Wm0MhMEVvWOw/Yw/ET2uO2D 4=; X-IronPort-RemoteIP: 104.47.70.103 X-IronPort-MID: 84314400 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:cWUvpax7FqovEdqJYf96t+cjxirEfRIJ4+MujC+fZmUNrF6WrkUEn GIXCGmAa/3bamv0eY0gYNmy9k9Uv5bWz4BmTFc9/iAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnP6kT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWRV0 OwzBj43VBbdjtL15ZaZS7A3rNt2eaEHPKtH0p1h5RfwKK9+BLrlHODN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDCVlVQquFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE1rOUxH+nANp6+LuQz7lxuW2vwlUpJz4fRAWgmcGW0FOXcocKQ 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRtv6eSUmm17aqPoHW5Pi19BWUFfy4fCwwe/8PkvpownzrIVN9oFKPzhdrwcRnsz DSahCw/gagPl8kN1rX98V2vqzetoJfOZhQ46gXeQiSu6QYRTIS9T4Ws6FXdvbBMIe6xQlCfs T4Eks6F4eYmCZCLiTzLQeMREbXv7PGAWBXM0QBHHJQ78TmpvXm5cuh44Cl3DFV4LsEePzTuZ Sf7owpf7ZJXFHind6l6Z8S2EctC5aztE97NVf3OaNdKJJ9re2ev+CBoeF7V1mv1kWAynqwlf 5SWa8ChCTAdE6sP5D63QfoNlLwm3CYzwUvNSp3hiReqy7yTYDiSU7htDbeVRuUw7afBqgOK9 d9abpOO008GCLa4ZTTL+4kOK1xMNWI8GZ39t81QcKiEPxZiH2YiTfTWxNvNZrBYokicrc+Ql lnVZ6OS4AOXaaHvQelSVk1eVQ== IronPort-HdrOrdr: A9a23:UQit+KPd2urfUMBcT6H255DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa DskPZvln6FQzA6f867Dn4KU6zqoMDKrovvZVorFgMq8w6HiBKv8frfHwKD1hkTfjtTyfN6mF K12TDR1+GGibWW2xXc32jc49B/n8bg8MJKAIihm9UYMTLljyevfcBEV6eZtD44jemz4BIBkc XKoT0nI8NvgkmhNV2dkF/I4U3NwTwu43jtxRuxhmbim9XwQHYfB9BajYxUXxPF4w541esMmJ 5j7ia8jd56HBnAlCPy65zhUAxrrFO9pT4HnfQIh3JSfIMCYPt6rJAZ/mlSDJAcdRiKobwPIa 1LNoXx9fxWeVSVYzTwuXRu+sWlWjAJEhKPUiE5y7mo+gkTuEo841oTxcQZkHtF3ok6UYN46+ PNNbktvK1ST+cNBJgNStspcI+SMCjgUBjMOGWdLRDMD6ccIU/ArJbx/fEc+PyqQpoV15E/8a 6xH2+wjVRCO34GNPf+n6Giqnv2MSeAtHXWu41jDqFCy/zBrOGBC1zHdLgs+/HQ0cn3TPerH8 pbA6gmc8MLHVGeZ7qh4DeOKqW6CUNuJPH96exLLG6mk4bsFrDAkND9XbL6GIfNeAxUKV8XRE FzEQTOGA== X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="84314400" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YOTO6nrLm4F2c9bVccIENHRkp2uFoO5G+KZl6fapw29fvllb1CCw3noHm6O6QLBADjgFPKWYjJBOFjSvyMdVVJvg1PwmA4mOZwvUf4GlY1gfq/FLgeO549n7C1ni5S6Je6X3VbtRfrgERru36iWtY4VTOEYWtfgi9exzPOWLPWRxsK64/0ML0hY1iP+reEBNTZbRCCnbg2WuuH3DA/8anPw2eZNpDUKLBBW/65q1eNauF6LpkVkEzUw9D5+L6UWWRda3eXNxu9jVAlz3WZs1QbyJA22D91zNq/X1H6BKlJESm1kVMUg/r2PcAmStOea+9c/1kgADS7eHkmVvBcX33A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xJAV3gu9bvonr8L5L+A08ezmPNN3r1cKnnOY5J8L51Y=; b=cknetg0hP9CTL0I0JA32Q/n4nwiZn2cL+7w43rY2bkhAq9Hte9RnxXPgn7nVcUIQipt/6zfH81ZH7Ou8iGDw2q6n2bnWChHTQA61r7PCogpHD1jEI8Umv9PsMNVYMcA1DjOVNxZBz3WM3ohSG5zSUYam9kVmh8IBldrMDpFy0MXhsV5L+XWILJiIXSLwuOJsZASNA+VtpLBiWZh4Ve4X89j1PPS4nYywj3fg5flNsEcd8nkQN8kc+G3T8LYHSDsQK89dHhr615FAuP2+bEdspA/cIFlTJHTrauG9osVrrwlOySg+0VECGgYzlaNPLF4UwcvqBFS4yfkmy3XHlBJDmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xJAV3gu9bvonr8L5L+A08ezmPNN3r1cKnnOY5J8L51Y=; b=WnPmzXo+pu2iq2ty6th09TgMLuOYV7oqdFHqXke/JbA3ul19qoC+YjG9xwBGww3VNdC6z3Yo6QXWwpZ4SPKdkD8b0SvG+vVsEdlQolZMTzLsuRf7ul/wNYmZWrZIP6/pWCP4vxM4pNt29Zc3YQYYVk5X9HDmYSyXLN06+uRw9W8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 21 Nov 2022 16:09:32 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: xen-devel@lists.xenproject.org, jgross@suse.com, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0 Message-ID: References: <20221121102113.41893-1-roger.pau@citrix.com> <20221121102113.41893-2-roger.pau@citrix.com> <53a21308-0948-66c9-86e0-d576ab884567@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <53a21308-0948-66c9-86e0-d576ab884567@suse.com> X-ClientProxiedBy: LO2P265CA0434.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::14) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6748:EE_ X-MS-Office365-Filtering-Correlation-Id: 51243e71-97b4-47a5-14ec-08dacbd2685c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +m8Q/lMKx2EdRA5s4Z3eqYB/W4BXscYz1L2G/UOSejEdoXwJWkHOtZf5Dl5G2pjVm3r0QdXEi8EZ2aWlQOl9D6CJrmwPra2lwiQ8uUPacsdjtD+DkZnwP/1dPCoave4qfKr8nheM08QPZLO0ShQ2tkgJbe9LCGTiMe6lmQ9wYk+nnUoA3IacpRgTAeBlkbsE2VREn+F8/c7Qnl/97PtWQOVeq3VAck4KB17FkW88a56SWb26pslCKZ3SI8gnE2Bbay6eSvZc7eEKhhhzDBHUzLQ5Iju19diPHBgOa1PLGkYn0t7n3leswY0rv/wXWvdtx2KVnDG861tsSCgEF++0p5XdUIJ6KFM3xE56+nMtFY5cl4jlXyBYAq7YQA+3poRsIr9uBhZfeg0XW9Q5jTB/vPnrDdJgSPLYwLXWUJCqVyZhStqTzRoawZEFJIgCkiophXfgy1AWcsdzy09fkKE72jckObUtSReIRn4Z2PCvCVMKymG7cYI3Ychk47k23RTz2gmOD0wBwBGHemJqCUYZkqQ3MkhkIdnVSjWcCjnp6SdcatVEJHGspc1wegiew8zxlui+qdgz7fE5VjqfnLJ9YdXZC4atCCkX48Q3I6M2b50DE3A/A2dbowIqkyDakmxwPUY7aZeDxSPZINIGY7PsYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(396003)(376002)(136003)(366004)(346002)(39860400002)(451199015)(7416002)(5660300002)(6506007)(9686003)(41300700001)(26005)(66946007)(4326008)(66476007)(6916009)(8676002)(54906003)(66556008)(85182001)(316002)(8936002)(186003)(53546011)(6512007)(38100700002)(83380400001)(82960400001)(33716001)(2906002)(86362001)(6486002)(478600001)(6666004)(66899015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUVPc0FGam04RGw4VWcxcjhIV0tuc2czWlkzRkpwQzF3ZnhLUFByRWtLbGZv?= =?utf-8?B?S29BS0V0TWZxN3hrQ1kvU0VsN01SSE5qMmtBNXVMVDZuKzBsekZTRlYxVXg4?= =?utf-8?B?dkpyZ21xN2xkb2NsWlFVLzFyZEg3NnlWejBBTFRPQmVIMEZDV01mbld0RDZJ?= =?utf-8?B?OS9xZkwxVFRXbXJVK095cWdyc0tBWDNjODIvZ1htQ3JTbS9Xdlh5T1k2Z3Vq?= =?utf-8?B?Wm1kcEpOcWxIdG9La1A5bHprTjBBckppZjR6YWtLQTBUZGFyMjdRZmFZa0NH?= =?utf-8?B?QnNremVLTjlkbngrOTE3N3lTWUxQNW9kWkxlcW92Z0VTd205b2s1VzRjVjFW?= =?utf-8?B?MytMN1VqUi9BZ08rakNCUlk0WlZhVlJlclcwNkFPTzllaEthUUgxV2p5b2VS?= =?utf-8?B?WDEremdUVFNOWnBiTzR1TDdsQkdLcG41T1J0QS81TlJwcWRpeEFCQk1sMFBN?= =?utf-8?B?dk9ZL2JhbEUwbkkzWnZjbkxUSEJzaHVZZ3hQR1MzWk1yc1A3Yy9QZS9leDZu?= =?utf-8?B?Ymhla0VLYkorcGlOV0p3UU5lemhoZFg0KzlUQi9pSEl0RGJaT0JyVi9tVmpS?= =?utf-8?B?WWkvNjBQbDBEQ2crZHBaV3FHY2gzT2d6NlFsckhqS3IvRjVZckdNUjFSQXFT?= =?utf-8?B?b1JZR1h4VG9iNEtOaHg1NDlid1lqVXNWZ2RSQlpaNnNlZlBCdEZyYzJWVHUx?= =?utf-8?B?UDg5a0szNFMzN3JNdURVRjdwamNsNFhnWG9QaG4rY2FVNEwwc3AzeU1COHVn?= =?utf-8?B?bzgxSEJUdTIzZ3JwT2NKQWEwMlpqVXhCamVHbEd4ZGZWNmg0VnlIT2VRZ25z?= =?utf-8?B?aC9hZEJBbklmc2VBM2xQZm5jNkpWZVVrZXBuQkhMUjBIVWFOemcxSjdMa0ZI?= =?utf-8?B?ajRoV2UrRHg4end3VFI1UjV2Y05jRTUrNGFqYnZmRFJXdXNOOW1hTnpLUTZn?= =?utf-8?B?eGVmcXRPdTBzS3hTTnVzN1VqL0ZmOUp2SHg3NFZKb0NWZm5VNXV3MEtBbFZV?= =?utf-8?B?QVFpb1lLUzcyNTVOcWN0K2xOdUxtU2tETFRjbjBZTUVDdlVNNFcxVnAvNUhl?= =?utf-8?B?ZDVYTkxjYVdCWE43dnM5S3d3RmJubzdtZ1VEV3dwenhrMGZ4a3NsY3J1WUFZ?= =?utf-8?B?bStNWURWV2t4b2pLNURIb3E2a2V0RXE0L1hRa0syNjZ2c2tqdFpLVlRtaEZ1?= =?utf-8?B?VkRxbi9pUEl1ME02NTNDRExDYVprNWcvRkdmS3ltbXMwVFpkNkMzaXVwQmwr?= =?utf-8?B?RGJ3K1NIRUV4aDZyY2lhbUNKMHdONEx6c1ZabGFYVnBzQnNDTS9nUHd4MDZr?= =?utf-8?B?UFRTZzdpeGVVMFVSTGFCdHZQNmw1QTVTUnpZcWtCZEtMckJYUDhkMi9ZVUxL?= =?utf-8?B?ZjFlM2hEQzVROWo5YnlxdWhGRElvaE5nekpCaTFhRk5tbGVWVll1Z0NpbmpD?= =?utf-8?B?UktTczlKRUxzOFdydkY1Y2pwVWhVcDdkbjMzd3ZhVlhNZDBSM2JjanptdFov?= =?utf-8?B?MDRNbHFmUCtxUDVxemZoS0xyNDFnYWN6cS9YVWlqZlkvNXhiR0pWVUo5ak1p?= =?utf-8?B?MVVIYXdyV05JZUtlVUt3WHl2ZzJyQmlBT0ZDbm1GVW4xYVdHNlZZTHpiUFF2?= =?utf-8?B?dDZ6K2psK1dobmtxbWl2cHNnei9ndHpKWWF1YStoZlFVbFBJZy9zV0tkL25Y?= =?utf-8?B?SjVDNWR1NGFHRm83TTlyUi9zRmxHaUFQeldJUUZ0L1FacWlWdGNhZ2JRekdn?= =?utf-8?B?ckVKUzFPVUo2aWczZThNWUNiZTBJK0JQUWpSd2dSazg2aTJZYlZBS0EyOFdw?= =?utf-8?B?U2R4RU5kR296Zmt1Q1JjcHI1L3piM25BV3ErZzFHa0RCVk9tRHRqai9McmtL?= =?utf-8?B?ck5KUExwWHk3Z0puVksrNDl6SStMeDhYRmpXQjlWWTAwRGdMUWZwU3RzU1Ja?= =?utf-8?B?QWd6aFdwR0E5L1ZUUWREUXU1SEpHSXMwMHRXeEtTbGczbzZpUkdCalBxTHlJ?= =?utf-8?B?bzVkeFZ1Q1NEcHBvMFNwYlZBb3JnQndmRmY3MWthVHBGLzVqcTN2SUdaTjUv?= =?utf-8?B?QWVwbW9zaUoyazdwNzltRTZIanBsVkFPK1puUC9QaHhxemJPMEc0SDFobE16?= =?utf-8?Q?57691Lhvt6dNzSuJ/BwPBLZka?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?aWNoU2FmNGpXWkxldmMrMG95a1I1R3Q1Mk5IY2VUQlJ6QWE4Q3BjMDMrSVVE?= =?utf-8?B?emRmR083SUFzRG96am1CRHBTaXNXSFZodWtLbGhDekxtTU93RTQ0dGNVVVBR?= =?utf-8?B?Rkx1YklQclgzRlBBYUdhQWlSdGRUU0M0cytTcXFCY3Y5STMxS1lnbERWN3N5?= =?utf-8?B?c0EwTnNnMlg5UlJnSkRCSmczZlV6R1d1L1lLY29TU3BEc3dWbENGUGVFTU03?= =?utf-8?B?VE1VbVo0UkM3K3pEd0JyQUxvSTZsVHBVdmNiaE13RW5UbzM3bnVmS2pnSFVu?= =?utf-8?B?UXcrcW9xT1huOTFDL3N1dURvUEtBdXlsQkJFR3Q4Q3YzOFVGU1lMMXhFaitv?= =?utf-8?B?dHFpd3d5V2JFcHhveXFraTNkSk5URjlneUJhcEpobmJEUmowbjgxaHVNYzN1?= =?utf-8?B?cHJoMU95TmNNMHdYMFdOWGVMaFFxOExvRGZIN0VSbncrS0RrWVpOYnhBS2J1?= =?utf-8?B?cGo4a1AxamNhSi92MXJ6dy9jaWJzZGNZaVRnOVl6cENINHpoakhEYXFvTVVk?= =?utf-8?B?RDdsZEczYUYvSGI5N3hvcFZLMm5CWm5zNFE2dkNEVXp0aEZlRjlCQVBVL1Vi?= =?utf-8?B?bHRMWjlYV0xMemJ1dnlLMUVFcS83b3RZZjZNeGExTTI2V3QyTDVQRXMyZzVv?= =?utf-8?B?SzBUQmdWR24wbjZtZG5HZzJuRGt2VHJyZHBSZThDNThPeUNNbzIvb1VmWjc5?= =?utf-8?B?QURVVlpudXVvcDFmKzY1ZmlNZzBzazkyZ2JCcGxjdGpKNVNYamxIUm80L2o4?= =?utf-8?B?aXVvZkxjQVhxMEVVdzg1cm1VcjN0WkM2RTRNTmxBNnBQOUlEbXd0WFNGTFBV?= =?utf-8?B?N2c1Z1BVaW9aVElUVXFoL085OG1wM1E3NWp1Tk9BZ0l1QXFWV0RJaXVvVFA2?= =?utf-8?B?cmtuMExQT2FJa2MyY1hadCtTZ1IxYXowWXhXTS9idXl6UWRQa3dmb3JWMWQv?= =?utf-8?B?cEJVK3cyM2VhdVhJSTFaSWw1azZoaXgyMUEvTkxDZEhCdVZpYUN5Vkg4Y2Nt?= =?utf-8?B?QzNzVE45TjN2MFQ0YXVPSnVUaW1GdTI4Yk5XNUkyblZTcjVBeWxtN1lnS1Js?= =?utf-8?B?eEs2T3JsNU5mUWVhSHNvV1FVblowZHhhWXU1Z0t0U3JYZ28rbWt5OU9yOFFo?= =?utf-8?B?aVRONm9XL1l3dFB3MjN5MFhyVkRXdDhDNHMwdFU3NDJoVG1Sa0JHR2JKQWVh?= =?utf-8?B?TTl5bVJweG5hdFY3UkxmYjkrM3o3YWltSGxEZlZITjVMN1VXbFBzYlNxM0tC?= =?utf-8?B?dlUreUN6SVFWSnRIR0Z5UXlqT1lTZUxWRzZ2NWZwZ2xUQ2lJWXJaYVZIVFdv?= =?utf-8?B?V05wTXZicVFKbmhOWlVDMkFxcW1JQVJzMVNNeTBVREUySHhCOEpBZzNoMEJW?= =?utf-8?B?cGJ0bWRNam92UUhiRzJ3a1lhdUZ1OW9ENyt2czZ5MlpYalpNZDVHS1FXNDNo?= =?utf-8?B?L3Q4TlhUNUhRbXN1b3BndlZVOTg5SDZHaHl1eko3MVYrL2dNaWpmZXBOa3Iy?= =?utf-8?B?SVlXbmw0MXdtUkdOTnI4eFB6cTJKZVRBUEZnVy9Mc1NXYTlhNmU0ZTFpYVFx?= =?utf-8?Q?Aojtg4/SHeLkdpVSmXSPV8lA/T5AdQYuMyVEij4pnOzz15?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51243e71-97b4-47a5-14ec-08dacbd2685c X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 15:09:38.2344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A3forrIWn7Vs5WdyO4ni6dgCnVj+1YHKuXa4gFxzta/TS1TOoBMzFJ4rpZwOzpg3ySSbMxn6C8cgXzzezq7CFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6748 On Mon, Nov 21, 2022 at 03:51:58PM +0100, Jan Beulich wrote: > On 21.11.2022 15:29, Roger Pau Monné wrote: > > On Mon, Nov 21, 2022 at 03:02:30PM +0100, Jan Beulich wrote: > >> On 21.11.2022 11:21, Roger Pau Monne wrote: > >>> @@ -47,6 +49,15 @@ static bool __init processor_physically_present(acpi_handle handle) > >>> return false; > >>> } > >>> > >>> + if (xen_initial_domain()) > >>> + /* > >>> + * When running as a Xen dom0 the number of processors Linux > >>> + * sees can be different from the real number of processors on > >>> + * the system, and we still need to execute _PDC for all of > >>> + * them. > >>> + */ > >>> + return xen_processor_present(acpi_id); > >>> + > >>> type = (acpi_type == ACPI_TYPE_DEVICE) ? 1 : 0; > >>> cpuid = acpi_get_cpuid(handle, type, acpi_id); > >> > >> We had to deal with this in our XenoLinux forward ports as well, but at > >> the time it appeared upstream I decided to make use of acpi_get_apicid() > >> (which meanwhile was renamed to acpi_get_phys_id()). Wouldn't than be an > >> option, eliminating the need for a Xen-specific new function? > > > > While this would work for PV, it won't work on a PVH dom0, since the > > ACPI MADT table is not the native one in that case, and thus the > > Processor UIDs in the MADT don't match the ones in the Processor > > objects/devices. > > I wonder whether we can actually get away with this difference long term. > I've gone back and looked at the commit introducing the code to build the > replacement MADT, but there's no mention of either the reason for the > changed numbering or the reason for limiting MADT entries to just the > number of CPUs Dom0 will have. (Clearly we need distinct APIC IDs, at > least until Xen becomes more flexible / correct in this regard. And > clearly we'd need to "invent" ACPI IDs in case Dom0 had more vCPU-s than > there are pCPU-s.) Linux when running in PVH/HVM mode uses the ACPI Processor UID in the MADT as the vCPU ID, so attempting to re-use the native UIDs doesn't work. We could expand the dom0 crafted MADT to make sure all the native ACPI Processor UIDs are present in the crafted MADT, by adding them as not present entries, but that seems more like a bodge than a proper solution. Even then those X2APIC entries would appear as offline by the current checks, and thus won't get _PDC evaluated either. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Nov 21 15:14:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 15:14:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446707.702444 (Exim 4.92) (envelope-from ) id 1ox8Ur-00063V-Uo; Mon, 21 Nov 2022 15:14:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446707.702444; Mon, 21 Nov 2022 15:14:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox8Ur-00063O-Rx; Mon, 21 Nov 2022 15:14:09 +0000 Received: by outflank-mailman (input) for mailman id 446707; Mon, 21 Nov 2022 15:14:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox8Uq-00062w-8t for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 15:14:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20618.outbound.protection.outlook.com [2a01:111:f400:7d00::618]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2396db6d-69af-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 16:14:06 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7768.eurprd04.prod.outlook.com (2603:10a6:20b:2a4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.13; Mon, 21 Nov 2022 15:14:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 15:14:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2396db6d-69af-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DFwaQB3Td62GETRX8wOnNzZuX0d+l4LOuxfX6SjJN5sCH4jcYg8McWwrg05Pj60d1+eNgud2VASXR+L/CBOd0cxVkZMXL+u8gy8dAiFdjwbMyhUEYJphd2J5fdfuilrZchSu2FymvipI+Kq44vl0P5fvnibZhh7Lz0dL0IC7pOFRaCGUY1vVqYjwf6ESk5o8NrSdpbv+A/qdO1eOwzvSfMXd++zZn2UfOenA01+xNQD02RFEcDHNQBABiIYvaZVUn2wAtsK6Vax6J52awBbXJYCmA3ArAuL6FV0Kzn0Vm9OQD8r660HHLfu1FDHPSyLg71SpApFWxh3t/mVtD6Yhyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L1l+5WKkemKXygWG0sUNz4ML3UDsCgcH/FILormivZg=; b=PNRJrWkrw6TRWNnD0DVxJbRtMvSrbaSjMSioqVtcK34gOaJieQ51Bdnrk7wy80Gmtw/ZzSIR2JnHit2uksJt/vRCOYOkeUGoc3rOIT+v7y6hBYhP8G1beVdmgxjaA0x+wq9zl5F9l57Pul31kmoC8xzj5m4W4uf2i5mQ7eQXqEoONARjUvCGzFggZyjnaeXesnLETf2ZfRbOlA2qG+cdvXl6yRtMKR2/Q4zwlaZ0rUBcjJ3ak+wkKMMy/iO2LIbXkRcjTfjCI1o7Yn2Qnrwz8azOb1jlH1ErwkQxznkpMCnLVcoSNXMww9paal4gq8wf2dCqzQkb93wMNFthn5AiNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L1l+5WKkemKXygWG0sUNz4ML3UDsCgcH/FILormivZg=; b=t8wcPfwuRjk7taTFzRB2/IBS5s9j0ANH4Fd7+vUjlAUtEfxiNKSv1akSfcWFqdAfJd4g1geI38iNF2qi5NMtN+BkN5GGy3izFe1N2sdqke0Yn8s644qbLgT17KXAE+v/taTmFC8R+vC92PEXv3x0lD1y9lLKrGB0phzv26qI0ghG8Z56xf0JyCsXv8u7iitGhBeMIn/O7P8q04xV60Y2Q3Pw2wdhAfunEkvAWJBFPcPCIvd9oIfZljN7Fum2PC03p1dcHQ4CxVgJZr4aaNxAAcDrLKpmzVNqFf2moW4gssu4b35k72rdFhklNdRm5tw0LBRGJSREp2hpXcSmYuzrvQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2e6c8d81-01d1-81a1-8fd4-4385e46befe4@suse.com> Date: Mon, 21 Nov 2022 16:14:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 2/9] xen/arm: add cache coloring initialization for domains Content-Language: en-US To: Carlo Nonato Cc: marco.solieri@unimore.it, xen-devel@lists.xenproject.org, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Marco Solieri , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20221022155120.7000-1-carlo.nonato@minervasys.tech> <20221022155120.7000-3-carlo.nonato@minervasys.tech> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0120.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7768:EE_ X-MS-Office365-Filtering-Correlation-Id: e2ec724a-5b69-472a-80bf-08dacbd30695 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bMt0u8OgfPWSS9VRCoOGAG442tT2c68toPrh0kugEAM7+KJGRiUFibNsgKWvt7aSfWjIL8GULDZJ3wwnVHmQ8fxUHcM8tcIthNyEHz10GjEoEQUTMFx8mAdG9gv1xNVPAFG5rQ33KA0D8zE1g+RQ3jG57pVEQIywCQMozxEKY8ox/oPmBu+Ljhl3vdad228YSivmO/4l8cGvZxH1cZXSuPIAvJF2OjMTM64ilvb5OlA0LkYH4uszoX1wG7B4eHHapJdV3COadJRPyz+nL4x/lEg5dI30OS+LN1af79qISA+Ixb3tVRGDoJnW8ANq1CBnRq9BTFDDLa5YhR/is1QrNdNH2qRzhHdY+bmUv9hxCKWvWB87LUutuy67dDNH2sAbD6TF34WStM0/uYwPag+OwbbJMLUjXO0IK1s7Vz8VtSbyqhhLV1nYPhxEpjGAysJbJjYFNzKpRSUYEgK8Yo8kzS+TsVK8mBFNWu/DJurGgAiFV7lBz0Ndn+LHeLsZQzdWZMZXcJoBF/jxx1VXWClCZIoPysnE11Nsq3DEoo0ZLMAYeVbcuu9hKtP9k7tRk4O50onv44f7rpNl5LRmCnKH/HHnMC8OZgKEzqwJHon4LN+usRQ/WfaulE49zSbvWXZUWLTGejj+DIev/2D9DrADKLv7C/Lw4yLSs9oH5MY8mV+xpn4xSC59IfHZk2FLNYtcdbwV8BkQiUCXWwZZG3wl9XOsVyOkGe4xKM506wr1Zn8l590MniX4BzxWLGsiV+LN X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(136003)(396003)(346002)(366004)(451199015)(41300700001)(7416002)(8936002)(66556008)(5660300002)(4326008)(316002)(54906003)(6916009)(66946007)(66476007)(31686004)(8676002)(478600001)(36756003)(2906002)(2616005)(6512007)(966005)(6486002)(6506007)(26005)(186003)(53546011)(38100700002)(31696002)(86362001)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWRTMVZGdjBBSHZKZVl1QUxaSnk1Ly9mOERNREd0Z3BjcTVsL21DRkIzM21r?= =?utf-8?B?cGpOWWp0MWFxY2NzU3QxR2Z4U0ExZDdRVDRUYW0yakVXSFVURi9Pa3k4a25E?= =?utf-8?B?K2VQd0pSamx3R0xqZXlTbnk5MldLcysvSzhBUHVWUnZwTVBSNmpwQWFCQjdi?= =?utf-8?B?M2dvampKVVZxZXNzSkZJV2NjUGdDOXAwMy9IUWhXbkpVWXhtMkRaTFl5SFRL?= =?utf-8?B?ZEk4YTRXQm5mTUl3M0dwcVdVOFEvblhwZ2loOWJOYmMrQ1lOSWlBcnVaS1NP?= =?utf-8?B?TVFvbWJhcjR1RFFwUU1wSDZiSzk1bTJseG5rR0lwcmZzUHJaSERNRFA3TjM2?= =?utf-8?B?ampnamlWdHBvM2hVOWpiSDM5bWxpU2RkWVZGSFRZdVRWTDlDakpuZU5Ic20r?= =?utf-8?B?TE1vNjRVMTZNTkI1eTc2MTNKYzZ0ZkVLWkh0anJaS0tsK3BsYk9SN1MrdFZF?= =?utf-8?B?N2REdkNlVlc2dk95ZDE2Z1FoQUlmYU1neEhrWWVPaHl0elIzVUNnVjJaSGls?= =?utf-8?B?RFVNN1R2dEFYL09GZ0tBaTJlN09BRkxsWDdNNGUycXA0a0owRlRWZDF0MHZS?= =?utf-8?B?eVc4eHFYQU9xbldxdjJ1TUwrczBOdU9qa2dFbHZsZ1NMOTlOK2pETlIyRmFw?= =?utf-8?B?NmlMVmxiUUR2RkxFK2diRE03cEgvME1kUjZUTVlOajBpRFNZeWtKUzlGdSsv?= =?utf-8?B?T1lCWXpUaXMyUDVRclZhOGlXY1JVTW5xTGpERU1KblZTRUxvNXh1SmM1QzRj?= =?utf-8?B?a3Zwdkc5S3FYMjNNREpNWGhXSy82cEEwS0orR2s3bHFzY3kwTWsvN2Fmd3Fv?= =?utf-8?B?WlpwSVZQMmVlK29MUGM0RFV3SGpUbVBMT0lmbXM3OVZtMW9qUzlIZkt3NDI2?= =?utf-8?B?a29IQ2Q0QlU5UUJldVdqUVAwMloydjBQamtPQ3pJZkFXRFQ4RmltZ0ZKWDFY?= =?utf-8?B?QW5uOXNvNFQ5Mk5sT21KMzQ2ZEJDUnAyM3VKQ2YyR0FNZUxrSEduTzVaREdP?= =?utf-8?B?bHlUWDlzYUxDS3Q1NWdUR0RaR2hYZVZZb1ZENDF4RzUzb2ttR0JZMGd3V3hK?= =?utf-8?B?TTJsNFlOT2RQZDA4NFhEd0VGWlBnUTVZNWtnRXRnRXcrbnZZbm5pQTd4OHYv?= =?utf-8?B?dlk2MXA1MnF2aDJsMjBVRmM5ZXVLWUdTaC9jUE1aVXJhOTZZYWdkVUNpbmlZ?= =?utf-8?B?QkZrcGgxUGpXWUpNTjlLUy9UREdnRVpRSHpOM0w0UUNXaXRlSWY1N3JRTklr?= =?utf-8?B?NmFXa2krWkRpMko5OU5YKzV3UWlHMS9UVUlZK0tjNHV4YTRnQjloT1laalpR?= =?utf-8?B?KzFuRTdnYkRNT25GSG1PdDJCTEFjVjkxQ2NYQUhRTXZ6RFlQTGowVHlxR0dn?= =?utf-8?B?aFd2UmJoenFFL0RQZ0xLSnFnM3ZpcWV1QWhYVUdmVXpJRlFXY1JCdnlUQWJm?= =?utf-8?B?aXFTRmZhTllLUDFzQmUra1ZPOG0zUHNTZlF2aUlyTytTS3JrbTl5VmU0V21x?= =?utf-8?B?RVZwSUJnaFE0aUJBTDJtcFVqanBWSUhWZjhsQjBoR1BVc0t0Vmc3S05MYzls?= =?utf-8?B?MGpGS0tremRiVG5ML29aZVl6bVZjblgyV1c2anptc2h6dnFPa21uNm1TS3RI?= =?utf-8?B?bC95RmgwMndrSVgvRDRNRk50QWRWTnM4d2hlVTMxVi8xdW5ZMFhIVk9PVXZW?= =?utf-8?B?YWRTa1hQbUkwN3ptczh1TmFKVWR4S1g3Ui9aVU9yTlIyWFRLcGtodjlwQklo?= =?utf-8?B?VFBXS1gvUHFMSlJTV1lJRG5ZcTVEMXk4Mkx4b0dUd0Z0UjVHUVJwQ0o3NmE0?= =?utf-8?B?dVV2eDViNWRUUUpBeGQ5cWNPaDg1RDA4OWNpOXNlNU1xOG9uQzdEekJ4VG1U?= =?utf-8?B?dHg4b0h4bmNvbXg0bGJQc0Z5R0lKZGQ2UjIzdUt5QzV3N0I3b3JJNmZmZk5n?= =?utf-8?B?UUdCS0hXNlJYd1ZaNmd1YnBZSFp4UHdxQWRJcVo2eWJxSFM2TEk1NFE2NnZE?= =?utf-8?B?eHpBVzBYWTFyajl4ZStJYkd1RW00VWtEZlBaaGNLclRzbGExSkhUeElNclU5?= =?utf-8?B?SmN1N0U3bkxkS3RNaTU2RGZ1QzhHNkVkS1d5Ym1FVnNyR2RCV2xnK3R3VWVF?= =?utf-8?Q?/d0JzwuZ00cfxRiO9nPVne92r?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2ec724a-5b69-472a-80bf-08dacbd30695 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 15:14:03.6283 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xjnD905Gd8qn++jEtzilWLMMu2T8S6mZBUD4OX8UcRhXYaVoatCLSTvUUzu+jDvIzP86tW6dAVVglmDaVU8pJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7768 On 21.11.2022 15:50, Carlo Nonato wrote: > Hi x86 devs, Any reason you didn't include Roger? > I want to ask you some questions about this patch because in the previous > version me and Julien have discussed how cache colors should be passed in > domain creation. You should be able to read that discussion, anyway here is > a link to it > > https://marc.info/?l=xen-devel&m=166151802002263 I've looked at the first few entries, without finding an answer to ... > In short, using struct xen_arch_domainconfig works fine only when domctl > hypercall is issued. That struct contains a XEN_GUEST_HANDLE so it > should point to guest memory and must not be used when creating a domain > from Xen itself (i.e. dom0 or dom0less domains). The easy way to go is then > changing the domain_create() signature to require also a color array and its > length to be passed in for these latter cases. > Are you ok with that? See below for more comments. ... my immediate question: Does supplying the colors necessarily need to done right at domain creation? Wouldn't it suffice to be done before first allocating memory to the new domain, i.e. via a separate domctl (and then for Xen-created domains via a separate Xen-internal function, which the new domctl handling would also call)? Or do colors also affect the allocation of struct domain itself (and pointers hanging off of it)? > Another question is then if xen_arch_domainconfig is the right place where to > put the coloring fields for domctl hypercall value passing. > See below for more comments. I think I said so before in other contexts: To me this coloring thing isn't Arm-specific, and hence - despite only being implemented for Arm right now - would preferably be generic at the interface level. >> @@ -232,6 +233,62 @@ bool __init coloring_init(void) >> return true; >> } >> >> +int domain_coloring_init(struct domain *d, >> + const struct xen_arch_domainconfig *config) >> +{ >> + if ( is_domain_direct_mapped(d) ) >> + { >> + printk(XENLOG_ERR >> + "Can't enable coloring and directmap at the same time for %pd\n", >> + d); >> + return -EINVAL; >> + } >> + >> + if ( is_hardware_domain(d) ) >> + { >> + d->arch.colors = dom0_colors; >> + d->arch.num_colors = dom0_num_colors; >> + } >> + else if ( config->num_colors == 0 ) >> + { >> + printk(XENLOG_WARNING >> + "Color config not found for %pd. Using default\n", d); >> + d->arch.colors = xzalloc_array(unsigned int, max_colors); >> + d->arch.num_colors = set_default_domain_colors(d->arch.colors); >> + } >> + else >> + { >> + d->arch.colors = xzalloc_array(unsigned int, config->num_colors); >> + d->arch.num_colors = config->num_colors; >> + if ( config->from_guest ) >> + copy_from_guest(d->arch.colors, config->colors, config->num_colors); >> + else >> + memcpy(d->arch.colors, config->colors.p, >> + sizeof(unsigned int) * config->num_colors); >> + } > > Question 1: > Here is the current hacky solution in action: using config->from_guest to > decide whether to call copy_from_guest() or memcpy(). This is a no go for > Julien (and also for me right now). In my current work, I tried to get rid > of this field simply by calling copy_from_guest() only in domctl.c, but this > solution still isn't easy to maintain because the config->colors.p field can > either be a guest pointer or a Xen one and mixing the two semantics can be > problematic. You simply cannot expect copy_from_guest() to work when the source pointer is not a guest one. >> --- a/xen/include/public/arch-arm.h >> +++ b/xen/include/public/arch-arm.h >> @@ -314,6 +314,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); >> #define XEN_DOMCTL_CONFIG_TEE_NONE 0 >> #define XEN_DOMCTL_CONFIG_TEE_OPTEE 1 >> >> +__DEFINE_XEN_GUEST_HANDLE(color_t, unsigned int); > > Question 2: > This color_t definition is employed because the guest handle for > "unsigned int" (uint) is defined later (public/xen.h) and (citing Julien): > >> Hmmm... And I guess we can't define "unsigned int" earlier because they >> rely on macro defined in arch-arm.h? > > So the solution could be to move everything up a level in > xen_domctl_createdomain, where using uint wouldn't be a problem. > If this goes to common code then should it be guarded with some #ifdef > or not? As per above I'd say it shouldn't. But then you also shouldn't use "unsigned int" in any new additions to the public interface. Only fixed width types are suitable to use here. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 21 15:17:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 15:17:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446712.702456 (Exim 4.92) (envelope-from ) id 1ox8XX-0006f6-CB; Mon, 21 Nov 2022 15:16:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446712.702456; Mon, 21 Nov 2022 15:16:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox8XX-0006ez-9M; Mon, 21 Nov 2022 15:16:55 +0000 Received: by outflank-mailman (input) for mailman id 446712; Mon, 21 Nov 2022 15:16:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox8XW-0006er-AS for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 15:16:54 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062e.outbound.protection.outlook.com [2a01:111:f400:7d00::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86cb7e30-69af-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 16:16:52 +0100 (CET) Received: from ZR0P278CA0098.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::13) by PAWPR08MB10306.eurprd08.prod.outlook.com (2603:10a6:102:366::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Mon, 21 Nov 2022 15:16:50 +0000 Received: from VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:910:23:cafe::e6) by ZR0P278CA0098.outlook.office365.com (2603:10a6:910:23::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15 via Frontend Transport; Mon, 21 Nov 2022 15:16:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT055.mail.protection.outlook.com (100.127.144.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Mon, 21 Nov 2022 15:16:50 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Mon, 21 Nov 2022 15:16:49 +0000 Received: from c912d1320bac.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9D323E04-DF9B-4671-9F29-C21D68618871.1; Mon, 21 Nov 2022 15:16:43 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c912d1320bac.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Nov 2022 15:16:43 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAVPR08MB9723.eurprd08.prod.outlook.com (2603:10a6:102:31e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Mon, 21 Nov 2022 15:16:36 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5857.013; Mon, 21 Nov 2022 15:16:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86cb7e30-69af-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mdJfzeZ/1HN40XUuQZpgYB2EBpNQUccpK56mfhXaWlI=; b=5rTzdzwyeDPvixeu+9Xws3YW47E5U1zWbiRAcMk6MHcxAenCgnAMaj1xRTkwhfkexEEiXYi0gmaJXp21H9C3CsSGzMq7+56ymeIWiLlILhq2EC871+Mk9rJp8mlXT6IoBp9A+jg5hiMC4Ji3GficpR+we+m9I1TLcrFoa1/uOws= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YyKttmCfBVG7XyYKdHxKfG94+/4Pd2nFrDNtqUi2vPy3WNsqUnneWl83FTd+LVtr27YWt2djWkp3zpl7KyJbQoCSw6268poZnfCcr9ayzoQ2OVS+q9pNdYM1qrA4mFeSncZPp84XFVONsR46Ws826bEbiOC38R47VdLMiB+l2WjCUvLOdvzLrmiRFeT/++eq+8BivhQ2nGJ7EI2+lpwO9ogvGq8wLEt7OwtJe3vrHu4ZkCZDDRtJnjuvgJsIK/sR9B5VDi6a8Fqer1odD0Lr4QLNIvk+/C6Io1fy/b9PIJ7jkrx8RL/NOarTgPW9WzKWDim/dex1jUeeT+36Jr9G4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mdJfzeZ/1HN40XUuQZpgYB2EBpNQUccpK56mfhXaWlI=; b=PZ4zlYoWQtHUkoiK+CUE0I1DjI3SNNql3Ng161jU2jYePTVXzUS0I0AtnAgxWoXi8WALjEfEQiUkjw9eXPhY2a2VRxNS4jXFY/INqQNqIN6QHXeLJPedEnX0TAlAtL6322KZHA+qMJ/hOAu+fP0I+gRSnEJ0ce17/H3TpWJlGCIvkoGS1Q4ay8VSiLcztANX0DTTiUvnAAIJOz99KDZ7ywmpEcnOz1bGFkxiUHIF/8wu54NGGOZD8XPFTed6VWQ5CDBoV6pI/duvpJymvuDZYIUPXG51AcPX0LPRBFUbZf85pERJfXeeivSkWcY5k/lDLwF+v2cNqkL4aB6ST9qiQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mdJfzeZ/1HN40XUuQZpgYB2EBpNQUccpK56mfhXaWlI=; b=5rTzdzwyeDPvixeu+9Xws3YW47E5U1zWbiRAcMk6MHcxAenCgnAMaj1xRTkwhfkexEEiXYi0gmaJXp21H9C3CsSGzMq7+56ymeIWiLlILhq2EC871+Mk9rJp8mlXT6IoBp9A+jg5hiMC4Ji3GficpR+we+m9I1TLcrFoa1/uOws= From: Henry Wang To: Anthony PERARD , Andrew Cooper CC: Xen-devel Subject: RE: [PATCH 1/2] tools/libxl: Fixes to libxl__domain_set_paging_mempool_size() Thread-Topic: [PATCH 1/2] tools/libxl: Fixes to libxl__domain_set_paging_mempool_size() Thread-Index: AQHY/bbT1Aw53rbod0uWYqQTx0in/a5JdG2AgAAIiEA= Date: Mon, 21 Nov 2022 15:16:36 +0000 Message-ID: References: <20221121143731.27545-1-andrew.cooper3@citrix.com> <20221121143731.27545-2-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: AE5034E85BD89F4EACBA53E878189D3A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAVPR08MB9723:EE_|VI1EUR03FT055:EE_|PAWPR08MB10306:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c832208-7e16-4941-36ad-08dacbd36a01 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MQQuZPWlCerfR7XDdKu6pQH+nTUlgLH07ckaqBbRvuNfMSFLViipVcQnjwjY0CvAzPOHvRTIhQuW8QLuczxVcVZiVvTN0mvh1+6F9JNlpYTqJ2H7VFsaDS9+W0XBK1OntSMXD6rb2oLaowttBmeG4+Ui7CrTtjyqXkkz9+aRpX+G9VIlb1SkWipBOwZ4dN2WImcdyf4niSWc9HOY08Qx3DpvjZkC828/r6Vz+aCTk3TgRwwhd59zNpF9nqxhJ46SnS/x3fMUUjN/AJ/1giTZtjoFYntS4GLRUb3Jwb2IjVeCJMXTSuvAQGaixIMWlXYu3sd5PYSgy5+fZIsbDwkPda9jFivWWAjpWC9Bmws49sun1FZ9Pv4I9GD5o9ciZxXLmJoXbPKOJX/HwKHdvUqVAKNi9sqB8DNC1ADNudkhG31iEvBURkRuAoISR7ZkuoaAS7ktWWhTnUQ4pT0VvtalzeV+1lTid3NZXhgM/sGS90CcWuwGzqwkcgkMZfVm087x2w14Qat3mcOI6kD+zUtwQwLrUtIZI6poNAsPw9+YieMs+BCLTprjV+7i2LXCwVAaIcHRHRj9HRjZ02IOHKKSMcyiqylRDyEFJIPJOeZZC4Q+8xuinE5CIi7PEdcV/ULJihhnUIRdloSjWF+Sh6mmKWq722Ms7cgqqLqBxYbmfnqBx8vnasvCD/TCXwNg5eJQiHTJlbhodlIXGgqTkzRNHttMIRmmFdJOoH/OuqDPmlQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(376002)(39860400002)(136003)(396003)(451199015)(52536014)(41300700001)(8936002)(64756008)(76116006)(5660300002)(4326008)(66476007)(8676002)(66556008)(316002)(66946007)(66446008)(83380400001)(55016003)(478600001)(38070700005)(110136005)(6506007)(26005)(71200400001)(2906002)(86362001)(33656002)(7696005)(9686003)(4744005)(186003)(38100700002)(122000001)(101420200003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9723 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9d06c44b-7954-4509-60c1-08dacbd361af X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r/FPcjc/5jheRsF1Y/VDLsj2D60hPdm+ioyuiBArcHq7cB+F6QFBZW0iENosA4UQDofGS27LkHOBqPMXfJSVJoo3u5b6IomWE480C1FQxM2xBzF7GV20QFbZjBtNqoMwqEUth9M2VRxXyAxGqrXHu8DDxDKz3OmGtmIijyL6OA33iw8hopmiAFq55qUk6P39rMmxwCOKR66845Nmqgx5znJ96g5vjuEeRDEJ2iRrQkcyJNTIrZ0MNuKdo+yGkLkYWSuDj/u1cldlL/N5NMz8xpC8RDRrq6m05LGLSIwHAV7TiA9XfMJ6mAOR4sqpHUYCGwG8AmzeXubgy63FmtzGk7hc6qfw7rFO7vxeGPYRrmGIYmV7iqF20btkpxNCnTR4vGaw4Wq2hPBZDDVcF7wKpry0UpcW+Dx3F7Zl0LUjaOqX4btrhdIYrYYjlFixo4nsp/ItN6RACsL7phHGOLEJN8kLNCgDk3F1k3LdZZcFNQSgvrdyqa+wseifplHs6ltN3RdHYJYcp4KxklT7EJyrXNoAnzz2M9Ny3dkL1zxlA79xnDxWp5aqCygpuwmzJ68VrWGgd//pFgwCsO6K3pPvh06Lhl6SAL/PdPbo0CRccuowMxseFnQEjilkSc4cEZM0Do0FgdZAPCwZAlyaroN4XTLG8qxObTqO4lfHGwoTJ/P5q2svb2Q2vKBxLKcqcZPiQ3qyoRD+7ZxXiMgSkdG+Isej5pUtQATJ4POZ6Yo3Es9fYV1FO5kAPArpY7aax3kt X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(6506007)(47076005)(7696005)(9686003)(26005)(186003)(110136005)(2906002)(478600001)(336012)(40460700003)(33656002)(40480700001)(55016003)(86362001)(82740400003)(81166007)(356005)(83380400001)(82310400005)(36860700001)(8936002)(4744005)(41300700001)(70206006)(52536014)(8676002)(70586007)(4326008)(5660300002)(316002)(101420200003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 15:16:50.2255 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5c832208-7e16-4941-36ad-08dacbd36a01 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10306 Hi Andrew, > -----Original Message----- > Subject: Re: [PATCH 1/2] tools/libxl: Fixes to > libxl__domain_set_paging_mempool_size() >=20 > On Mon, Nov 21, 2022 at 02:37:30PM +0000, Andrew Cooper wrote: > > The error message accidentally printed the bytes value as if it were kB= . > > > > Furthermore, both b_info.shadow_memkb and shadow_mem are uint64_t, > meaning > > there is a risk of overflow if the user specified a stupidly large valu= e in > > the vm.cfg file. Check and reject such a condition. > > > > Fixes: 7c3bbd940dd8 ("xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; > use p2m mempool hypercalls") > > Signed-off-by: Andrew Cooper > > --- > > > > v2: > > * Retain PRIu64 > > * Check for overflow > > > > For 4.17. This is a low risk change, removes one overflow case, and ma= kes > an > > error message accurate. >=20 > Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Mon Nov 21 15:19:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 15:19:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446717.702467 (Exim 4.92) (envelope-from ) id 1ox8Zd-0007EA-Oe; Mon, 21 Nov 2022 15:19:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446717.702467; Mon, 21 Nov 2022 15:19:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox8Zd-0007E3-LW; Mon, 21 Nov 2022 15:19:05 +0000 Received: by outflank-mailman (input) for mailman id 446717; Mon, 21 Nov 2022 15:19:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox8Zd-0007Dx-5P for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 15:19:05 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20601.outbound.protection.outlook.com [2a01:111:f400:fe13::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d57a52cd-69af-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 16:19:04 +0100 (CET) Received: from DB6PR07CA0111.eurprd07.prod.outlook.com (2603:10a6:6:2c::25) by PAXPR08MB7442.eurprd08.prod.outlook.com (2603:10a6:102:2b8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.15; Mon, 21 Nov 2022 15:19:00 +0000 Received: from DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::3c) by DB6PR07CA0111.outlook.office365.com (2603:10a6:6:2c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Mon, 21 Nov 2022 15:19:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT007.mail.protection.outlook.com (100.127.142.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Mon, 21 Nov 2022 15:19:00 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Mon, 21 Nov 2022 15:18:59 +0000 Received: from 428a4cd0406a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B0A2E9CB-C69E-4789-9399-D7138E766704.1; Mon, 21 Nov 2022 15:18:53 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 428a4cd0406a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Nov 2022 15:18:53 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS2PR08MB8456.eurprd08.prod.outlook.com (2603:10a6:20b:55c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Mon, 21 Nov 2022 15:18:52 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5857.013; Mon, 21 Nov 2022 15:18:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d57a52cd-69af-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ByFzQziCz3y6P3c0BnRBWFklGTm45bgQ7b8bEMxa1ck=; b=zysAjg1TL4O0ipkb2EmN4+c71gaqGg/obPrOO8/j4Ey940i3oX6Z/uSwmtrgQrUAcR0g0pn7WTBeWjEwM98nYoJzt4u+jnw+fG0tNChTE6Ph6vGqoBLqGnhuXhgF/QTWwJefUTHmOBQIl1hlFhg4s5pDCHhc3wjf3K8IRe3Lrdw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LVdoHu6X/zaDiV0IGy3a7mDBZY1JFY62NJxQg0ZH/GTMVqIp2qCIfP3EI5WXhKtGHdKU5TPkYQv5o/ZxznohbZNjDAsbBojJEVrGk2zfYTbymgNZo0nYFV0Pc7IH+vDYyApOYhMpBLJq2oiapvCoI95aYR5fCdWOvm/Ht/L7/oVxYOT8pN9exDLMHtHM5zX+DzYvy8pANQ+Bau52dxmxX96xGytdYjpTWW4LsHZjJzG8xG3licDg9WrC4TfVGFOzq8GN/u+PRY3vP1y3LkNhzMnx+DKdcGZDHoV1w/hmXNit5F1MaYFsrmmp11fl7rQDVRpOPw/AkC9SVwZwqdPERg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ByFzQziCz3y6P3c0BnRBWFklGTm45bgQ7b8bEMxa1ck=; b=IibjyPWLbhk7qm3/NAdI+MEzCZHBIUOgt558pAlW4K4HQBxFbz1tVlGFatRf+/kSQj2nwl1tl8b3ylhluHFiDvfzQc9kUVJBno5XQ17X0oGY9vCt9p7YRBYlBDnicQREPBsYTnSAF1mXrKwxDW8WCoUK52msEjOhaMdJ8jxgxmkezOlL6Y1pwFdI1gnmlDod3NUBbu067jUBd3WJ5J1WTSeuawd1Abb4ta5wE+Sos6p+kEE6x2H/o6rvRQ35CzXG1E3CKYNrncihMQSvwb0PzqB1b2DjUS8ifGtNJ4/UKIhdtrK2XxYq2vYK1UaPBJDLLQzR69e59ZBQqf077Cy+cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ByFzQziCz3y6P3c0BnRBWFklGTm45bgQ7b8bEMxa1ck=; b=zysAjg1TL4O0ipkb2EmN4+c71gaqGg/obPrOO8/j4Ey940i3oX6Z/uSwmtrgQrUAcR0g0pn7WTBeWjEwM98nYoJzt4u+jnw+fG0tNChTE6Ph6vGqoBLqGnhuXhgF/QTWwJefUTHmOBQIl1hlFhg4s5pDCHhc3wjf3K8IRe3Lrdw= From: Henry Wang To: Andrew Cooper , Xen-devel CC: Daniel De Graaf , Daniel Smith , Jason Andryuk Subject: RE: [PATCH 2/2] xen/flask: Wire up XEN_DOMCTL_{get,set}_paging_mempool_size Thread-Topic: [PATCH 2/2] xen/flask: Wire up XEN_DOMCTL_{get,set}_paging_mempool_size Thread-Index: AQHY/bbVX0GSNM/JZUeuvzit/8P6fK5JfROQ Date: Mon, 21 Nov 2022 15:18:52 +0000 Message-ID: References: <20221121143731.27545-1-andrew.cooper3@citrix.com> <20221121143731.27545-3-andrew.cooper3@citrix.com> In-Reply-To: <20221121143731.27545-3-andrew.cooper3@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 66F8555E4AE86046BCBAAE755912140D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS2PR08MB8456:EE_|DBAEUR03FT007:EE_|PAXPR08MB7442:EE_ X-MS-Office365-Filtering-Correlation-Id: f12ba5b7-7d11-4a39-adbb-08dacbd3b752 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: anuxUr4Rrjdjq9g+LWC4V8ZesFIhC/g41jkEZtPV+bwqYxNO9mdTIvQzirXzaVJ4ruVLvWSAUnMENjtvZc6l1Pu8yQVJsukYQQZOBv2Zz+S3ZAJXvX5kjo2IG0V93eRPO+zj595Kkatih2fxwnUGMdflptWEjy8R19wHQWhqh2JyMGYy+QRid/mlwY+F3Ex+RQMVc9GcQx1URePmNl4G95geyxiyJg5ekLZJmjygfeF/5gAuvp7g8hCWYHHj2qUh4W7hRCjYiRgGr4zs3XEK1K+a0601KKFdcGJuYZSSD3n4sCKJSqTMp1csDcD53uP4FetPRPBRLfuCiMDHSVyyCg9FL4QCFYWCWsc5hx7qT3FUzDWeQNwHUWmmyjCGxFi6foQGes6DaJw2FxVRZpWrMbHMdz5Zcso16XB7TIOVUmRWCVEcBVNOfhUKdevncDUGeeyjwYisWnnt6sftJRtThnR8beJqXS1fZjS9+oFwO+Wgxv+7P/uJFN7sruEXcdaiufXyh2KAvXycIZQ2I8mY7nbYOq8/RgZ083qBEbSOhD0LlRBmNKjzyEoviHr5KayM8FnlXv6rbe3ygiwqfNBI1PNfUAfFwdkdpWXYyLvmHo828tHfoBzWvBm8/i2dKirR3COMsd7zDONztoqMG1zhPbOpiCzDswqG/Ph4JYvbtk8kour0X+8mgJLhEoLw/izf+bAg9R4s8R3xqcd9L8POjA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(396003)(346002)(39860400002)(136003)(451199015)(86362001)(66446008)(4326008)(33656002)(53546011)(55016003)(41300700001)(76116006)(66946007)(66556008)(66476007)(4744005)(52536014)(186003)(5660300002)(8676002)(8936002)(64756008)(71200400001)(478600001)(26005)(9686003)(316002)(110136005)(38100700002)(122000001)(54906003)(6506007)(7696005)(38070700005)(83380400001)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8456 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b93b36bc-0948-40f9-2927-08dacbd3b295 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JH8rskIDBeTRyvsTuA9/qqFx8psaVZRrOJTUYP6jIsTr2fz8CYd0UU0WgkzhH+KpaYikBCYkZIceUudCZI9oqHAOhetvnSlD4MOg4qM9WAUslAToETD42cjd/NXr9AdauuNPeiWZgW3kh9DQi+9T0+eU0+LgbfgZ+IV04jPPjdPk7AJCuEv7h2McmG+PrlWqfkgTG9hbRXucODhBEB8omuE3cm7Dz+o1R82hXoncJ6lwdKlzC4CBHQgVmJ2paEwqXj+kiS+ZJvEoGy8Fe8+LBrBxmCY7m/bA5n8GLG25FS8BLko+jP+G6WX+7AaGH5AlKmavJRVJ7+tKRJpRztPxsufG0k5KoAxCyRgefR6JqL9OvklkMj5PW5zxJtDAy99w0XrLuKkfliOPFbiwJc99AK87Ibl8lDN4Z2iKKedpTqUl14iqguMzoJBTD8abbmiUuCT1oIrMxeyfPjCgXQ5zRX9oDK/jX3+ma/FGZua4AKiph5HGw2jgMoHmYYp3YUp2XcUFaW8R++j1pTYabLe9x+NpITURGwjXrGvyYqRW7rCg6giyAa3nXtWxKjzwMxXMc1gUrW8ySGHhpOets54TkACceCSwXDtzJKynU7cr/Ia5cUYZrBig9DxnGLn/fGQDuMn/+WSNlRSzDuzzYHEifVkTmd2DRN9QaID4NmCRsWEKU3MtH3B5iUlHxzvRtszoTUOzouEOyuz4D7sPWW0zAg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199015)(46966006)(36840700001)(40470700004)(41300700001)(8936002)(4744005)(54906003)(4326008)(5660300002)(316002)(70206006)(70586007)(52536014)(8676002)(478600001)(2906002)(107886003)(47076005)(336012)(6506007)(186003)(110136005)(9686003)(53546011)(7696005)(26005)(36860700001)(82310400005)(40480700001)(40460700003)(33656002)(83380400001)(81166007)(82740400003)(86362001)(356005)(55016003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 15:19:00.0533 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f12ba5b7-7d11-4a39-adbb-08dacbd3b752 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7442 Hi Andrew, > -----Original Message----- > From: Andrew Cooper > Sent: Monday, November 21, 2022 10:38 PM > To: Xen-devel > Cc: Andrew Cooper ; Daniel De Graaf > ; Daniel Smith ; > Jason Andryuk ; Henry Wang > > Subject: [PATCH 2/2] xen/flask: Wire up > XEN_DOMCTL_{get,set}_paging_mempool_size >=20 > These were overlooked in the original patch, and noticed by OSSTest which > does > run some Flask tests. >=20 > Fixes: 22b20bd98c02 ("xen: Introduce non-broken hypercalls for the paging > mempool size") > Suggested-by: Daniel Smith > Signed-off-by: Andrew Cooper Release-acked-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Mon Nov 21 15:40:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 15:40:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446725.702481 (Exim 4.92) (envelope-from ) id 1ox8tt-0001Ye-Ll; Mon, 21 Nov 2022 15:40:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446725.702481; Mon, 21 Nov 2022 15:40:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox8tt-0001Y4-Hk; Mon, 21 Nov 2022 15:40:01 +0000 Received: by outflank-mailman (input) for mailman id 446725; Mon, 21 Nov 2022 15:39:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox8tr-0001Su-QG for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 15:39:59 +0000 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [2a00:1450:4864:20::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c13b0ab6-69b2-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 16:39:58 +0100 (CET) Received: by mail-ej1-x629.google.com with SMTP id f27so29534309eje.1 for ; Mon, 21 Nov 2022 07:39:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c13b0ab6-69b2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TL4bxAMdTZ7/1iyaxpPl4jxAMqdKroHRy/h4GAuBQWQ=; b=HRicA2c2dHd8dbFhosIW4sVbG3lBUOTPKDKmYe8cR6sg29ZjWSxVPDQt4z+N4hG7tO aZzD5XwkNpgQRh6IbTCjFxrlAAEteg7YgmTlN6YJvLbjSCN/wR8Twn8Gj9P4mQCeRp1s +P/6MzvX/dpsh83ZR9MTs0xVVKzC7FmNN4ZvGliFAptZgBIZjp+AqZtxVLe+fKGLg52m 3eTrv/xfR1pz2mjZ3ISQQeRr9HfHXWR0uRr50j87rjfsXCbP5ruQHjl8zQ9p1lCVIfh2 79x+nuztF3Lww/HwcZEkvY+ERzt8g+5RYL0AtCZd53u0QEcNyE96OH1KmNwiCeVHDi1V EADA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TL4bxAMdTZ7/1iyaxpPl4jxAMqdKroHRy/h4GAuBQWQ=; b=kXXcOA83Za2KPWB1yUZIGBF84dkmY7o/3kLJ78VU+qftoRH/BlZwdm6H+kGWemL0QH bONppDS3xUPzBYM/tG54kXM4lP7dj0xW/A+pE9LftjptEK3MMvRV905uxg8/5H9TRvkJ f3KwM8wDa5oePQ2vN7Sgeng4c9xCuUyIudLIApZwUxB11oUV9/ud1PSEpc5CUMH/klxr DN1d5FXDK/fdZfDj3FeWQOR9u/D2wK3fXeaN29ToUOrJhFanOgCfC047k/8dG9audcgE yMPk0OQHGDam6AdzD//XntlloHlr8eExwrgUNpRMUNfTQNXsZUwqCiH6HLFRDH7ulyE1 e78w== X-Gm-Message-State: ANoB5pm71D6jHlmYo744FBEcNe/dKUpur+DZvYbnRlzH/714gN5HcZyr pfgjQrsJMveu4NAkXcz6nxb3adTbIbn8oq65K40= X-Google-Smtp-Source: AA0mqf7j8jthng5USitAtvZjDRWXc92ugVtfIfkWRF/Wr83E3WdNJS8TQ5MdKmxwzsvvewdkXRLx+QS/+WWQyT+8hTs= X-Received: by 2002:a17:907:b686:b0:78d:f796:c00d with SMTP id vm6-20020a170907b68600b0078df796c00dmr1335927ejc.251.1669045198116; Mon, 21 Nov 2022 07:39:58 -0800 (PST) MIME-Version: 1.0 References: <20221121143731.27545-1-andrew.cooper3@citrix.com> <20221121143731.27545-3-andrew.cooper3@citrix.com> In-Reply-To: <20221121143731.27545-3-andrew.cooper3@citrix.com> From: Jason Andryuk Date: Mon, 21 Nov 2022 10:39:46 -0500 Message-ID: Subject: Re: [PATCH 2/2] xen/flask: Wire up XEN_DOMCTL_{get,set}_paging_mempool_size To: Andrew Cooper Cc: Xen-devel , Daniel De Graaf , Daniel Smith , Henry Wang Content-Type: text/plain; charset="UTF-8" On Mon, Nov 21, 2022 at 9:37 AM Andrew Cooper wrote: > > These were overlooked in the original patch, and noticed by OSSTest which does > run some Flask tests. > > Fixes: 22b20bd98c02 ("xen: Introduce non-broken hypercalls for the paging mempool size") > Suggested-by: Daniel Smith > Signed-off-by: Andrew Cooper > --- > CC: Daniel De Graaf > CC: Daniel Smith > CC: Jason Andryuk > CC: Henry Wang Reviewed-by: Jason Andryuk Thanks, Andrew. Though we might want a small tweak - possibly as a follow up? > diff --git a/tools/flask/policy/modules/xen.if b/tools/flask/policy/modules/xen.if > index 424daab6a022..6b7b7d403ab4 100644 > --- a/tools/flask/policy/modules/xen.if > +++ b/tools/flask/policy/modules/xen.if > @@ -92,7 +92,7 @@ define(`manage_domain', ` > allow $1 $2:domain { getdomaininfo getvcpuinfo getaffinity > getaddrsize pause unpause trigger shutdown destroy > setaffinity setdomainmaxmem getscheduler resume > - setpodtarget getpodtarget }; > + setpodtarget getpodtarget getpagingmempool setpagingmempool }; There is also create_domain_common which is for a dedicated "domain builder" that creates but does not manage domains. I think that should gain setpagingmempool permission? Regards, Jason From xen-devel-bounces@lists.xenproject.org Mon Nov 21 15:41:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 15:41:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446730.702492 (Exim 4.92) (envelope-from ) id 1ox8vd-0002vG-Vm; Mon, 21 Nov 2022 15:41:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446730.702492; Mon, 21 Nov 2022 15:41:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox8vd-0002v9-Sv; Mon, 21 Nov 2022 15:41:49 +0000 Received: by outflank-mailman (input) for mailman id 446730; Mon, 21 Nov 2022 15:41:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox8vc-0002v3-0Q for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 15:41:48 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 01d6f580-69b3-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 16:41:47 +0100 (CET) Received: by mail-ej1-x62e.google.com with SMTP id me22so12870157ejb.8 for ; Mon, 21 Nov 2022 07:41:47 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01d6f580-69b3-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TCMlnWg+myOhhKN0SxZMVCH4mYM2c7IIKgrkO+HeaWk=; b=Y2RO/yW642IDIaLYTAISydu25+lH0EHbLtHCbKmBKzdnSwR4XVBHiICXHVrhgghG8f qzDASEcxyUzmk5Az0j2opwEyoq+DlHwLteDgK1bUfPBVgMSxXn4RfCTuSaZ+0g67ZzS6 7PC8oehAF2iilexEtWcuzzPq194e5+ZsSkStZnZwm0M8jP8p6EEstIbEcO8wND7uY+9Z KQLWrNK0wMSON02oH+DSHWAWUVQuPYVDYr/E5OIZ/ugRbDxYxsEg4PkrAMgjYGAZq8Xn uXHkfai7YE97+XY6rOJusPdqRdvo2H+eIq/y7P2MBDncBo4Xr02NdvLuzE2Yd+Uf2zLc Dr8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TCMlnWg+myOhhKN0SxZMVCH4mYM2c7IIKgrkO+HeaWk=; b=jR8BEtuLRb1DXuhdvBivB1NfT2OpBFXNHM6gjvkSrnBJU5CYV2hopwtiguY7je5RVp a1aKBsvonp9hCkQlJKG0hhVl/VHcYsFQBSFhVkxcujUtYjLT0dJW3zHSVOXZtb7y8oPS dFYF0RBlovLfC/o91rMEtnyzU/I8BPX7tQDZ1kGxaFMJ3ovnPJ4nTDtQ4DsiOQKHg5mS EQ+OXxfrTdq/DalvoYgdAzctv+NLyewbXT7WbrkQP/1tgkXK597DntIPXwrTYT+an9l6 k8KTvfcqBuMfdDRcJ/HNmAEeIaMkpytWZ6mklSnH+QARFZBUkd3+UdDUqfGOJvoc3WQe aRAg== X-Gm-Message-State: ANoB5pn1uKhiWVAHpsXOGjnkSlhLHkF2Ujcuto1xX0EduWkLswsZKaeZ l2cUIBzLx/v9cVIXcjbqOfz88WR433glTdPP39k= X-Google-Smtp-Source: AA0mqf5uOHOc2RxD/WaWaZ1u85j1VVhGSa0IldqxagvBVMqoRS1IH+b3Ral1oqQSSUWehCElDYUPp1lqEbwMbm6ODRU= X-Received: by 2002:a17:906:448d:b0:7ae:37aa:6bf with SMTP id y13-20020a170906448d00b007ae37aa06bfmr15892382ejo.481.1669045306558; Mon, 21 Nov 2022 07:41:46 -0800 (PST) MIME-Version: 1.0 References: <20221118154931.1928298-1-marmarek@invisiblethingslab.com> In-Reply-To: From: Jason Andryuk Date: Mon, 21 Nov 2022 10:41:34 -0500 Message-ID: Subject: Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Nov 19, 2022 at 11:33 AM Marek Marczykowski-G=C3=B3recki wrote: > > On Sat, Nov 19, 2022 at 09:36:54AM -0500, Jason Andryuk wrote: > > Hi, Marek, > > > > On Fri, Nov 18, 2022 at 4:46 PM Marek Marczykowski-G=C3=B3recki > > wrote: > > > > > > On Fri, Nov 18, 2022 at 03:46:47PM -0500, Jason Andryuk wrote: > > > > I was trying to test your xen-pciback v3 patch, and I am having > > > > assignment fail consistently now. It is actually failing to > > > > quarantine to domIO in the first place, which matches the failure f= rom > > > > the other day (when I more carefully read through the logs). It no= w > > > > consistently fails to quarantine on every boot unlike the other day > > > > where it happened once. > > > > > > Does this include the very first assignment too, or only after domain > > > reboot? If the latter, maybe some cleanup missed clearing MASKALL? > > > > It's the quarantine during dom0 boot that fails. Later assignment > > during VM boot fails. I tried warm reboots and cold boots and it > > happened both times. > > > > I also modified my initrd to halt in there and checked the config > > space. MASKALL wasn't set at that time. I need to double check - > > MASKALL may have been unset after dom0 booted in that case. > > > > I'll test more to figure when and how MASKALL is getting set. I'm testing with a laptop without a battery. It seems MASKALL remains set when rebooting or when left plugged in. >From unplugged, a cold boot doesn't have MASKALL set and the network vm boo= ts. After that, rebooting the laptop leaves MASKALL set on the NIC when the laptop reboots. NIC assignment fails. Shutdown and later boot while left plugged in keeps MASKALL set. NIC assignment fails. I have only tested this scenario for short periods of time, so I don't know if it would eventually clear after a longer time. Regards, Jason From xen-devel-bounces@lists.xenproject.org Mon Nov 21 15:46:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 15:46:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446737.702506 (Exim 4.92) (envelope-from ) id 1ox90D-0003Zn-IP; Mon, 21 Nov 2022 15:46:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446737.702506; Mon, 21 Nov 2022 15:46:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox90D-0003Zg-FU; Mon, 21 Nov 2022 15:46:33 +0000 Received: by outflank-mailman (input) for mailman id 446737; Mon, 21 Nov 2022 15:46:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox90C-0003Za-3L for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 15:46:32 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a98c8265-69b3-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 16:46:30 +0100 (CET) Received: from mail-co1nam11lp2172.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 10:46:19 -0500 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by DS7PR03MB5591.namprd03.prod.outlook.com (2603:10b6:5:2ca::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Mon, 21 Nov 2022 15:46:17 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::5c96:fc3a:9d36:4a2e]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::5c96:fc3a:9d36:4a2e%4]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 15:46:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a98c8265-69b3-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669045590; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=CSP00r10vQy+QH3m25K+YDlTWgiYvTP+Iw9w86WGZx8=; b=aZXOLGKT9uwMOegfL7JrSvi0SGzDV9gGct14zhPgYKXeUCckI7FQm0sp jesRdMSnfq/d7CxcKqRTBof3OMjxaJr4kYg164F9Gw+nvMJafkDmiNvGJ K1acZRcbtW94TeHhMZYVAgJwS+L0nqRREwM4t1ZQHbq51+kZ7zWEO4eq5 c=; X-IronPort-RemoteIP: 104.47.56.172 X-IronPort-MID: 87803773 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jQ38yqjtCTgdxr5m2d8XBGfZX161gBEKZh0ujC45NGQN5FlHY01je htvUGCBbqyIZ2vzKdFwYYri8UIFvsSBytM1QVY6+CFmRHwb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QWHzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tRHB24JQCGo196x0ZyfV883ipQfEvTSadZ3VnFIlVk1DN4AaLWaGuDhwoYd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEvluGyarI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6ROLorqU13wb7Kmo7LBsOdQKJheuAsk+vXexwK 0wOohN2ov1nnKCsZpynN/Gim1aGtxgQQctNEMU17QiMzuzf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8oTy+NCcPJEcedCQESk0D+NClr4Yt5jrDVs1mEbK1ptTtFCvs3 iuRqywjm7QUi9VN3KK+lXjnjjS2t972Rwg6zgzNWySu6QYRWWK+T4mh6Fye5vEZKo+cFwCFp CJdxJLY6/0SB5aQkiDLWP8KALyi+/eCNnvbnEJrGJ4isT+q/hZPYLxt3d23H28xWu5sRNMjS Ba7Vd95jHOLAEaXUA== IronPort-HdrOrdr: A9a23:aSbnYK9/dfzun2u7mUBuk+Hwdr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirCWekD+y77b+Mh6AmjMTSSlGz7sO+X XM11WR3NTjj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhn8lwqyY4xlerua+BQ4uvum5loGmM TF5z0gI8NwwXXMeXzdm2qi5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe F29lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQFo+dY7bWfHAbIcYa 5T5fLnlbBrmJShHinkV1xUsZiRt7IIb0+7qwY5y5eoOnNt7Q1EJgMjtbAidzE7hdIAotB/lp r52u4DrsAwcuYGKa16H+sPWs2xFyjERg/NKnubJRD9GLgAIG+lke+/3FwZ3pDcRHUz9upFpL 3RFFdD8WIicUPnDsODmJVN7xDWWW24GTDg0NtX6ZR1sqD1AOODC1zJdHk+18+75/kPCMzSXP i+fJpQHv/4NGPrXYJExRf3VZVeIWQXFMcVptE4UVSTpd+jEPyjisXLNPLIYLb9GzctXW3yRn MFQTjoPc1FqlumX3fp6SKhL08FunaPiK6YPJKqjNT7krJ9R7GkmjJl+WiR94WMNSBItLAwcQ 93PK7n+5nL11WLwQ== X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="87803773" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XK2PO6CwsCA34lnFmsv//6goMteX+h3dS/8wPp22QRVN/NvBEk8i/4ntjII8YX6RcJ23YiIqeZKHYNMhrXXaG4Oti29oJabC3EB2rVJU2TObb2BVxiJBR4NHu830OLRTDDDp+p2PAbR5s176UE33gu0IKVTPFKnWpsAKUVPMWcmeiUIMVUqgNYC/nvJd4q5GlMaSgC45TIovXyDgvR8xN8kzG9gS3SyHyX+5d76Tv5qfVZwOmGi8FUrZAgRF9sPr4MC0MWL0dvQYCptaz83CIkimYOOGpt4rRUTlO8UNXleqjAlyr4VFkKmBqvbJ/XypLF2PgJRZr3UBaCM4lRTGbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CSP00r10vQy+QH3m25K+YDlTWgiYvTP+Iw9w86WGZx8=; b=DVRXzyLLOgIjkMjHY2u4wdtRwROmJkofYmnKgzb4dELOm4T/0H5oIlS7x1iLYFvcfgKxnbYN7g3FU2DpuKpQC3PxV/2aDKV3YdOXNO4KaT+ZEICHp4eStc5apzV4Xf/3kEVHLK5t3R15PSSH5Dt+Ls9T61EG+SLShUDz6W/xICJADqIZuwa5DgXdeKMZDlEJ13FNRlzSSP116Dpso+uQdh+U1sYISZsvNpcUJOwq34GU7k+BsrJG8aFjbrqkY5eX2r7GPWL19EPHasNamm7cwRtvfGCxlw2z7AvWXKi2tGKtG39HQ/kFgPSf5MR7F0GLESzR4reCWOFngFkZNjjcvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CSP00r10vQy+QH3m25K+YDlTWgiYvTP+Iw9w86WGZx8=; b=NSskk8+11UynLjBcG302/3XR9jDxvcVKb3qI7660dcTVt9ITAAnDrOPFKGEdwBtLA45y68X8YWphWlpAahi05gRKP3t6zfQiXSxOd9+AqXeRtWZTDoeDJtPN4YZw9T5z4XSwzcwgb2dZJkEFVcd15QTZ/tlmo+6Nfo7AF9ZHmrQ= From: Andrew Cooper To: Jason Andryuk CC: Xen-devel , Daniel De Graaf , Daniel Smith , Henry Wang Subject: Re: [PATCH 2/2] xen/flask: Wire up XEN_DOMCTL_{get,set}_paging_mempool_size Thread-Topic: [PATCH 2/2] xen/flask: Wire up XEN_DOMCTL_{get,set}_paging_mempool_size Thread-Index: AQHY/bbRnyNjpAguUkKfWUCja4W2UK5Jg4kAgAAB0oA= Date: Mon, 21 Nov 2022 15:46:17 +0000 Message-ID: <9a302c19-4f07-77a5-5e41-310498c7cf23@citrix.com> References: <20221121143731.27545-1-andrew.cooper3@citrix.com> <20221121143731.27545-3-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|DS7PR03MB5591:EE_ x-ms-office365-filtering-correlation-id: fec1c9c1-1e4c-4307-ca51-08dacbd7873d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 81/bYxPjiJXVLAhIDNpu/f3mBZxXFsAwWBS66h+eQBFWt7za53b2FekSFumaGOCIPGr2uA6NbTzYZLW5j6/WO7UTlDZ/Z4kZvDN2YrGr5LMNdzcZZB1CGNCDQ3L2hcnwOpF9Nstkhj/dhyTGpW0xMLM+2InEuCqnPtcVrFJ0ylViaiVnZEKN5iVYvYGJ7D2aKyXO3iQqE2B+SILJArqX2ufHmcRRHCyzZUjEs5vkOcsP5p8FJlYc9M3SfZ7fo6Cxc0cWU05lJAUwDTtuqrYAT9er1l6ZnaefoY5g9/nUsC6ulB3rq60pXsvDe7VK0/63sU+hRIkKD3XkM411dAC8XjjiMy4lfmfaRbjXIEXryXW446ZqQMDjhdywri7drE6033J/Aa/MJIBEprYp/XMLfW2QKSBiN00VuBny+2Oh8sG6IqvV09gj45G4uGzXqXU7fBVCT2exJZXRJBuv45+3MlpxLvzcrOS3L8t4KwCS26d3ifXDXN4jRxdvSCueIXP/1V8bXMMwDhqALsL8ALN9GQ5prbfUkeBbRVewgMLoa9UzvuOsP1QYgJNwnMfDCeWUtjcGvWVuUk9XLuZ2ghBs6vLS2HetiHesnjWf2xGvTS++G8HqvW/SkywHXd6AMJ+GOFqM80xv3YATCi+sN/6dvJeOjdxEMRHxY04Kn4U3C9F+UUoYXN6pRcwexpBptYq12gSwFSYJRkllkglC+YhHQ0i/cjgl2QaE/vktgfc1n/pjy8TXCz5cUr2CJ92anGkf7COP6GytykqSWCRpGHJhYg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(396003)(346002)(39860400002)(136003)(451199015)(86362001)(31696002)(36756003)(66446008)(4326008)(53546011)(41300700001)(91956017)(76116006)(66946007)(2616005)(66556008)(66476007)(186003)(5660300002)(8676002)(8936002)(64756008)(6486002)(71200400001)(478600001)(26005)(6512007)(316002)(38100700002)(6916009)(122000001)(54906003)(6506007)(38070700005)(82960400001)(83380400001)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UU5kYndpaGUvV0NzTzJ3WnQxUmtVYld2QUZUbVJtdno1VDgzS1M5dFFWdVB4?= =?utf-8?B?V0J6K2VzQmlJWkEvY21rQjJRYzg4Z1Q5N3E4SWUvMjNua2llTUZERlg2ZFQw?= =?utf-8?B?bFZmUDFudU1kVGtrOW4wWjRJd0V5NXBUdnVjRjJsMEgrV05zUGF1aVVqeUVu?= =?utf-8?B?cGlOWmF3akZJb2ZIMnB2aDFpOWIrZ3pTaTJsVEdObEw4TkhkeXV3UTdYd3Zk?= =?utf-8?B?Q3BvMU4rV2xRRXp1WkpIODNXTnNqUUo2UGh0NEgwbXlZQUM2Z3BYb1Z3V2xK?= =?utf-8?B?Z2trVUlXcHN2ckdEeXJMNi9YTXB1UHlxNGJwVjF0bEpmZHk1eWR1MTJ4d0pI?= =?utf-8?B?MGx4UXROWFRveFU4cWdJeEIzUXNqTW5POUV1NWZOQiszby9tL3cxMUhmSVBv?= =?utf-8?B?QVJMajhob1VYL2lQN3Y0QXp4QVJHYlY0Z3RUa0plS2V3V1J6Q2FUZHZ1RnB3?= =?utf-8?B?SVBpZVJOam1VZENud0dRcERUQVE2R0JQamtpbllhSVNBbFpWYWJlbTQ2eHg5?= =?utf-8?B?VnczTXpFRUFqSkZyQ0ZoT3FtYytHV2Q3dWUrR2dMNis4a05PSlBVTjc5eW80?= =?utf-8?B?Q0JJcC9FN0dHa3NIR1VNblVCQkZZN1JCVGhNVTlFVW9ERlJldGpqaG9Tc2dI?= =?utf-8?B?RVpVc21RQVNNTlFUSEl2dVFJRFlwVWo2SVB2TkpDdzFTUFFta2tHVlhOZ3Ra?= =?utf-8?B?KzVUWFRJKzVqcmpMRFFsa1VCMmVMNkJRbnpuK01Jc1U2dkwwRkhhOXV5MUV5?= =?utf-8?B?dkRlUEd3dFFqeFZyUXlvdHJtSmE2TGlncnlRSGNiSjk1OEFpMGFLVmdUdE8v?= =?utf-8?B?ZFYzZUxJUWJhTnl1Q3Z3dCtSR0dEaHFwNHBxWjllU3VuOWZCMHEwYkpydXZN?= =?utf-8?B?d3NyZmhLQTMxQUxzQ25Ec0JqUWZxR3ZmcXhZanNEVnNYSkFXa3YrK0NPSkpN?= =?utf-8?B?cnNDbnRRdGNCcGN1NGhBY2k2dEtqOThTZThJV1Y1SExKbVJIb3BpQWp0WUt3?= =?utf-8?B?SEJDWUl0dnNlUExxOUlKZ3JjblFFVlFzbEFmblQ4c3ZzRmZMKzFGeFoxV2Nw?= =?utf-8?B?NzF1MFdCUlpPT1BLemhkR3dzbTRhczNSaDRBUjErYVB5YTNNNkMxYnd1Vkgz?= =?utf-8?B?NVd6MDJZV3RiOHlNNFJkTHdlRFhBVFFDSFJxbDVjS2FYajdzck45VVNKWDBY?= =?utf-8?B?RWt4TUtrRkpTSlFJQkdnZW9ZaldZa2RhYUp6cU5OT0JhVUJWVWptMDFGZnlw?= =?utf-8?B?NjN3c05tMFJkY3hJc1pwcGw2alpYL1pWRURyZ1JyQnA3cTB5M1kxS0dBUUY5?= =?utf-8?B?YnJxaGtEakpNdzBONTYrbmYwT2pkaHVEOVk3ejNEWDNEOUw3R1lLbFlkQk82?= =?utf-8?B?OS91NkUrRldTSEYwSDZzYXhjZWluL041dHdlZnVOOVE5aWdVdTQ2L2R6Z3Jj?= =?utf-8?B?Z0tvSWJ6TzVPdFhJMWhMZHdwSHIxR0h1RkdPTjZkb0Q1a3BLWWtRNDg3RFQw?= =?utf-8?B?b1R5VDlLaWNtajlmNXJRZzRWSGNZNlNQeTNhak9rZFdkTFVWaC9hZThRRU1J?= =?utf-8?B?b1ZqSVFBQTFmTFBYekVJZmxPSStyS1l3RXNtbjlSVFVXbzc2WHpBMTZya1Ux?= =?utf-8?B?eTBlb2JLVFdJTW4rN3h5SGYxdXZZb2F4S0pxUmhDSGh3WGlNYmVIZFJIaDhU?= =?utf-8?B?MW80cmQxMHhNNmlpejBiTVFVRDdOOFB3KzhHU0EycHhnRUdBS3hiZFVOQkFq?= =?utf-8?B?UXN6T1hSM3granRvT2IxZ2p1Z3J5TWEweW4vRExSbmh1aWVqemVOd1V0Rnl1?= =?utf-8?B?VDlIbEpkNXhMTmF2M1NtWlo0SXViVDV6bHJmekhVckJ6bkFPTFpvQ212UVlX?= =?utf-8?B?b0ZBeEFkekxteGtlZFROWk9TVWxVK3liclhsZ1poMk9hejJYM0VoRC8yb3Q0?= =?utf-8?B?Rm1vQkREWXhqUGxIeElaSUtQdXhDRWJINHFrL2Z5bVdJWUtjRi8rWm15cit2?= =?utf-8?B?OENLeEIrbjUxbjRMTU02RDgrSHFYVWxxb2JZNlNVd1I1YVlINWNzbUMvNUc0?= =?utf-8?B?alg5Ti9yTTgxclRIK1dmWXVmamhYSmFyY2tEemY4VmtxQ3ROVUZXNUtVWTY5?= =?utf-8?Q?vfInAbCb8Rw+ezXpDT2j0vHAw?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5KNeeR/roirT/4uxJPEbxaEkkkVfw6dZpT/RI3sQNlJ9qFTlqbf8mPVTkiqdT6A+QTwkWwpnPE56arUZi9nzYd1c1XPKgpv2QWm0PNljFKS2oaYNmSsW924KTtqnhILoBkFVqXSmhHIvRVT1TTeorcSwXfdmkqLNYoSOyv24ZH84JHTZDKNWNXSORND8G9gTUxVneoaTdvJMGg5Y93Pec0cIlgpVWAyhc2+ZqzmusNBJwwfpInYFHsoB2KKqClY0LmP4IV223ny0PejNgok4UrfVttICY7/ZwxTh4XhiyCLPWfPvLq2QRLGqLAoEAEHvk0wvRGdu9oXdFOOktjvT7B7K0UVFTPVy8Ts2L7Kc/GP+auIF3NNiApA2Rd7rWWKrOZQNnMBGwvjX7WGtgXMyaVvg38oO91gfUOoYDl18mWVUASPgoj7SVLJ3t+tqwvDpZctl8aY/ww+DgLK/n8F9hT+ziITl2IiRfjPsvLYs8aCWEootWgIyW2DWpdQ6H0axE6XuwW6zKihZKF6E5DPDED2g40X8uHyNVMmwuTjE1PO81tL/bES30bh9tTrQ0e2UQlqm8BqsZ2ZudDEMISYSaoEpvbTGO1516Xyqc4d/ZI7PV9zQOHVWABQRqW11JhJ8sAabb07XBT4QGmisQVyES0Kj7OIdjKpQv+jvINEEDR8dtTPfQjmGMH7baUb8teoNeQztE+Txl6QloEtDKADjiN6UHjJWWPFsyHl195Qi0aiEP4FZVeE4S/hU0t/9H0Bw+gKYaHGnGQf0dh4kNkq1I+aQWIoQMrfzjjA4bQfXMZJgROauoPCXpaxBiblnn7yV5fhU8s4y6ir9Ld7z/Ecu9/BGec5Hy8vG5THHk5LZt6EXmgAzqjw9LCllNpnhf8kZB60HTuKerI3wLtsfjSaUgavCWEfD/fij7Cg1/co1yvs= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fec1c9c1-1e4c-4307-ca51-08dacbd7873d X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2022 15:46:17.3102 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EM29rwrRZNXKKiMYatBxzjEY5Vuw3RBTO65HLkrxuZGPx8BLnb7Aao9gf3AAQWoR+QPKEWWYQ3zFwUYEp7OklxdIWtn59MLL7c3L7q+RicA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5591 T24gMjEvMTEvMjAyMiAxNTozOSwgSmFzb24gQW5kcnl1ayB3cm90ZToNCj4gT24gTW9uLCBOb3Yg MjEsIDIwMjIgYXQgOTozNyBBTSBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXgu Y29tPiB3cm90ZToNCj4+IFRoZXNlIHdlcmUgb3Zlcmxvb2tlZCBpbiB0aGUgb3JpZ2luYWwgcGF0 Y2gsIGFuZCBub3RpY2VkIGJ5IE9TU1Rlc3Qgd2hpY2ggZG9lcw0KPj4gcnVuIHNvbWUgRmxhc2sg dGVzdHMuDQo+Pg0KPj4gRml4ZXM6IDIyYjIwYmQ5OGMwMiAoInhlbjogSW50cm9kdWNlIG5vbi1i cm9rZW4gaHlwZXJjYWxscyBmb3IgdGhlIHBhZ2luZyBtZW1wb29sIHNpemUiKQ0KPj4gU3VnZ2Vz dGVkLWJ5OiBEYW5pZWwgU21pdGggPGRwc21pdGhAYXBlcnR1c3NvbHV0aW9ucy5jb20+DQo+PiBT aWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0K Pj4gLS0tDQo+PiBDQzogRGFuaWVsIERlIEdyYWFmIDxkZ2RlZ3JhQHR5Y2hvLm5zYS5nb3Y+DQo+ PiBDQzogRGFuaWVsIFNtaXRoIDxkcHNtaXRoQGFwZXJ0dXNzb2x1dGlvbnMuY29tPg0KPj4gQ0M6 IEphc29uIEFuZHJ5dWsgPGphbmRyeXVrQGdtYWlsLmNvbT4NCj4+IENDOiBIZW5yeSBXYW5nIDxI ZW5yeS5XYW5nQGFybS5jb20+DQo+IFJldmlld2VkLWJ5OiBKYXNvbiBBbmRyeXVrIDxqYW5kcnl1 a0BnbWFpbC5jb20+DQo+DQo+IFRoYW5rcywgQW5kcmV3LiAgVGhvdWdoIHdlIG1pZ2h0IHdhbnQg YSBzbWFsbCB0d2VhayAtIHBvc3NpYmx5IGFzIGEgZm9sbG93IHVwPw0KPg0KPj4gZGlmZiAtLWdp dCBhL3Rvb2xzL2ZsYXNrL3BvbGljeS9tb2R1bGVzL3hlbi5pZiBiL3Rvb2xzL2ZsYXNrL3BvbGlj eS9tb2R1bGVzL3hlbi5pZg0KPj4gaW5kZXggNDI0ZGFhYjZhMDIyLi42YjdiN2Q0MDNhYjQgMTAw NjQ0DQo+PiAtLS0gYS90b29scy9mbGFzay9wb2xpY3kvbW9kdWxlcy94ZW4uaWYNCj4+ICsrKyBi L3Rvb2xzL2ZsYXNrL3BvbGljeS9tb2R1bGVzL3hlbi5pZg0KPj4gQEAgLTkyLDcgKzkyLDcgQEAg ZGVmaW5lKGBtYW5hZ2VfZG9tYWluJywgYA0KPj4gICAgICAgICBhbGxvdyAkMSAkMjpkb21haW4g eyBnZXRkb21haW5pbmZvIGdldHZjcHVpbmZvIGdldGFmZmluaXR5DQo+PiAgICAgICAgICAgICAg ICAgICAgICAgICBnZXRhZGRyc2l6ZSBwYXVzZSB1bnBhdXNlIHRyaWdnZXIgc2h1dGRvd24gZGVz dHJveQ0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgc2V0YWZmaW5pdHkgc2V0ZG9tYWlubWF4 bWVtIGdldHNjaGVkdWxlciByZXN1bWUNCj4+IC0gICAgICAgICAgICAgICAgICAgICAgIHNldHBv ZHRhcmdldCBnZXRwb2R0YXJnZXQgfTsNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgIHNldHBv ZHRhcmdldCBnZXRwb2R0YXJnZXQgZ2V0cGFnaW5nbWVtcG9vbCBzZXRwYWdpbmdtZW1wb29sIH07 DQo+IFRoZXJlIGlzIGFsc28gY3JlYXRlX2RvbWFpbl9jb21tb24gd2hpY2ggaXMgZm9yIGEgZGVk aWNhdGVkICJkb21haW4NCj4gYnVpbGRlciIgdGhhdCBjcmVhdGVzIGJ1dCBkb2VzIG5vdCBtYW5h Z2UgZG9tYWlucy4gIEkgdGhpbmsgdGhhdA0KPiBzaG91bGQgZ2FpbiBzZXRwYWdpbmdtZW1wb29s IHBlcm1pc3Npb24/DQoNClNvdW5kcyBsaWtlIGl0IHNob3VsZC7CoCBTb21ldGhpbmcgbGlrZSB0 aGlzPw0KDQpkaWZmIC0tZ2l0IGEvdG9vbHMvZmxhc2svcG9saWN5L21vZHVsZXMveGVuLmlmDQpi L3Rvb2xzL2ZsYXNrL3BvbGljeS9tb2R1bGVzL3hlbi5pZg0KaW5kZXggNmI3YjdkNDAzYWI0Li4x MWMxNTYyYWE1ZGEgMTAwNjQ0DQotLS0gYS90b29scy9mbGFzay9wb2xpY3kvbW9kdWxlcy94ZW4u aWYNCisrKyBiL3Rvb2xzL2ZsYXNrL3BvbGljeS9tb2R1bGVzL3hlbi5pZg0KQEAgLTQ5LDcgKzQ5 LDggQEAgZGVmaW5lKGBjcmVhdGVfZG9tYWluX2NvbW1vbicsIGANCsKgwqDCoMKgwqDCoMKgIGFs bG93ICQxICQyOmRvbWFpbiB7IGNyZWF0ZSBtYXhfdmNwdXMgc2V0ZG9tYWlubWF4bWVtIHNldGFk ZHJzaXplDQrCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdl dGRvbWFpbmluZm8gaHlwZXJjYWxsIHNldHZjcHVjb250ZXh0IGdldHNjaGVkdWxlcg0KwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnZXR2Y3B1aW5mbyBnZXRh ZGRyc2l6ZSBnZXRhZmZpbml0eSBzZXRhZmZpbml0eQ0KLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHNldHRpbWUgc2V0ZG9tYWluaGFuZGxlIGdldHZjcHVjb250 ZXh0DQpzZXRfbWlzY19pbmZvIH07DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgc2V0dGltZSBzZXRkb21haW5oYW5kbGUgZ2V0dmNwdWNvbnRleHQgc2V0X21p c2NfaW5mbw0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdl dHBhZ2luZ21lbXBvb2wgc2V0cGFnaW5nbWVtcG9vbCB9Ow0KwqDCoMKgwqDCoMKgwqAgYWxsb3cg JDEgJDI6ZG9tYWluMiB7IHNldF9jcHVfcG9saWN5IHNldHRzYyBzZXRzY2hlZHVsZXIgc2V0Y2xh aW0NCsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc2V0X3Zu dW1haW5mbyBnZXRfdm51bWFpbmZvIGNhY2hlZmx1c2gNCsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcHNyX2NtdF9vcCBwc3JfYWxsb2Mgc29mdF9yZXNldA0K DQpJIGNhbiBmb2xkIHRoaXMgaW4gb24gY29tbWl0Lg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Mon Nov 21 15:54:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 15:54:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446742.702516 (Exim 4.92) (envelope-from ) id 1ox97u-00055f-An; Mon, 21 Nov 2022 15:54:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446742.702516; Mon, 21 Nov 2022 15:54:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox97u-00055Y-8J; Mon, 21 Nov 2022 15:54:30 +0000 Received: by outflank-mailman (input) for mailman id 446742; Mon, 21 Nov 2022 15:54:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox97t-00055S-02 for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 15:54:29 +0000 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [2a00:1450:4864:20::533]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c7488192-69b4-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 16:54:27 +0100 (CET) Received: by mail-ed1-x533.google.com with SMTP id f7so16859879edc.6 for ; Mon, 21 Nov 2022 07:54:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7488192-69b4-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=O7wrvF8cv/7DZCsp8TsTkcEqJGvPXPVcgkDNtN7ewYo=; b=VPMv7JC8sFo8zAlwnSCHzJ3CcI1Eo+wWgxbtNvfHVbNmrNMqCcpoYWmEW8g0iG2uZY g4ik1nRenO1XcwVpzQ9kbJgoQv/qeyqQH27HHQL/huhJu048n2hFvbrUnBdoTWui/5vT C0LOme7/QGYE8tqa2r7TFwe50kecT4F+r1mA/6lqfnMDRx4fICs6acNtm0gaCY0TUJR8 zkuiE9gO+D1tOEnu8YlPfQyYgxKyODq/SN9ReKd+2EARQluWHbczRMrWNw2TJMTHPp4X XXc9LxZhx9n8nao4MmIiJQnM63EHlmkjf2uE5F7ys3f/yIZ01tCI8R7tqn/n8CsROlW+ 52Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=O7wrvF8cv/7DZCsp8TsTkcEqJGvPXPVcgkDNtN7ewYo=; b=YR6WGsilpOZv4cXF3XELRuTw8NrFD69uadOQDLFylX86NUsembGLzgDfCMEcXzuPVR XOKT6RDwpeOstEnsg0L0Vk5duSuZJa466pARcMT1iMPuXKuL6XktY6OkCuEnrVKMeVH6 jnUX7jC62/VqfxpKz/eqSVHgmt422jZ8y6cTk6N36c7+HlsEndRAuyHYmJu17rUxaK7m ygOGhx2RhnYyPq+O4MyT4rUwEj+pmJAS5yG0B4T01K3OAVWprFvmjWlXfmJ/6yQP6M3d 9jCyLZ6ZPI3vcfTTreyfN0mR0xqkeAoJJAHLt4p8Q7sl74indr8n5H//Kjt4FGyvxw0F Y/hQ== X-Gm-Message-State: ANoB5pkg4sEOutOmOf3Laq1oVjyK4QGxHFVCBGrucRPUtXMCLVU5D3VD hzm+KCygTAqgTbIdC1tiPhHdrn9p0LqHwDrDXEY= X-Google-Smtp-Source: AA0mqf64cW9xzT3urlLFxEWbS8cABzz7J2Iy727RookjhUCc7jGUlI9NdHl1QdlBl/3jZEvwMgWtIwrAqdLgqOFlcJk= X-Received: by 2002:aa7:d551:0:b0:468:fb2c:6c8c with SMTP id u17-20020aa7d551000000b00468fb2c6c8cmr15306118edr.340.1669046067451; Mon, 21 Nov 2022 07:54:27 -0800 (PST) MIME-Version: 1.0 References: <20221121143731.27545-1-andrew.cooper3@citrix.com> <20221121143731.27545-3-andrew.cooper3@citrix.com> <9a302c19-4f07-77a5-5e41-310498c7cf23@citrix.com> In-Reply-To: <9a302c19-4f07-77a5-5e41-310498c7cf23@citrix.com> From: Jason Andryuk Date: Mon, 21 Nov 2022 10:54:15 -0500 Message-ID: Subject: Re: [PATCH 2/2] xen/flask: Wire up XEN_DOMCTL_{get,set}_paging_mempool_size To: Andrew Cooper Cc: Xen-devel , Daniel De Graaf , Daniel Smith , Henry Wang Content-Type: text/plain; charset="UTF-8" On Mon, Nov 21, 2022 at 10:46 AM Andrew Cooper wrote: > > On 21/11/2022 15:39, Jason Andryuk wrote: > > On Mon, Nov 21, 2022 at 9:37 AM Andrew Cooper wrote: > >> These were overlooked in the original patch, and noticed by OSSTest which does > >> run some Flask tests. > >> > >> Fixes: 22b20bd98c02 ("xen: Introduce non-broken hypercalls for the paging mempool size") > >> Suggested-by: Daniel Smith > >> Signed-off-by: Andrew Cooper > >> --- > >> CC: Daniel De Graaf > >> CC: Daniel Smith > >> CC: Jason Andryuk > >> CC: Henry Wang > > Reviewed-by: Jason Andryuk > > > > Thanks, Andrew. Though we might want a small tweak - possibly as a follow up? > > > >> diff --git a/tools/flask/policy/modules/xen.if b/tools/flask/policy/modules/xen.if > >> index 424daab6a022..6b7b7d403ab4 100644 > >> --- a/tools/flask/policy/modules/xen.if > >> +++ b/tools/flask/policy/modules/xen.if > >> @@ -92,7 +92,7 @@ define(`manage_domain', ` > >> allow $1 $2:domain { getdomaininfo getvcpuinfo getaffinity > >> getaddrsize pause unpause trigger shutdown destroy > >> setaffinity setdomainmaxmem getscheduler resume > >> - setpodtarget getpodtarget }; > >> + setpodtarget getpodtarget getpagingmempool setpagingmempool }; > > There is also create_domain_common which is for a dedicated "domain > > builder" that creates but does not manage domains. I think that > > should gain setpagingmempool permission? > > Sounds like it should. Something like this? > > diff --git a/tools/flask/policy/modules/xen.if > b/tools/flask/policy/modules/xen.if > index 6b7b7d403ab4..11c1562aa5da 100644 > --- a/tools/flask/policy/modules/xen.if > +++ b/tools/flask/policy/modules/xen.if > @@ -49,7 +49,8 @@ define(`create_domain_common', ` > allow $1 $2:domain { create max_vcpus setdomainmaxmem setaddrsize > getdomaininfo hypercall setvcpucontext getscheduler > getvcpuinfo getaddrsize getaffinity setaffinity > - settime setdomainhandle getvcpucontext > set_misc_info }; > + settime setdomainhandle getvcpucontext set_misc_info > + getpagingmempool setpagingmempool }; > allow $1 $2:domain2 { set_cpu_policy settsc setscheduler setclaim > set_vnumainfo get_vnumainfo cacheflush > psr_cmt_op psr_alloc soft_reset > > I can fold this in on commit. Yes, though strictly speaking it may only need setpagingmempool and not getpagingmempool. These are all calls that would execute before the domain is run. But adding both is probably fine since the builder is setting these itself. i.e. allowing it to read what it set is fine. So, yes, I'd just fold this in. Thanks, Jason From xen-devel-bounces@lists.xenproject.org Mon Nov 21 16:07:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 16:07:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446749.702528 (Exim 4.92) (envelope-from ) id 1ox9KN-0007Iv-K5; Mon, 21 Nov 2022 16:07:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446749.702528; Mon, 21 Nov 2022 16:07:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9KN-0007Io-Gq; Mon, 21 Nov 2022 16:07:23 +0000 Received: by outflank-mailman (input) for mailman id 446749; Mon, 21 Nov 2022 16:07:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9KL-0007Ii-Te for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 16:07:21 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 92579f7c-69b6-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 17:07:19 +0100 (CET) Received: from [10.10.1.128] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 166904682378198.6141457560326; Mon, 21 Nov 2022 08:07:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92579f7c-69b6-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; t=1669046824; cv=none; d=zohomail.com; s=zohoarc; b=XsxlZuBDXKq5xx8vLfdfl6bkLpNqINiuxC6ig7fHm8Bd5MkobXYpivv0CIGtsud89sMFTZRX2VOqz2H3DCN0mG8Tfi4Ed4TYQfmvJcfJrtX0FIvymUjWTDo0TzLv/n2PFOfK3800H/S5DjXbtQPq0LBB/jdcn8a9MMpC9jlORaE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669046824; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=tZyRZ/fk8LIzCTdf9SXGL+KC5e8X2bBuohDXP+YgN18=; b=bWH8E4vdpfPDKKmzu+w4UgpMHjfjfyhFQTuk0gga7i6ZkGKrWD8zu6UgHdlediyebzSmFuHcz/FI64Nhhe2huFouqILUIxueeQfMUlo8RNNWQFtKuq2LtTJ6TVpYiWnBNL+mVbIm7cAXGOPZZAfy+3+js0zUIXu3wUIsK2v1SlM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1669046824; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=tZyRZ/fk8LIzCTdf9SXGL+KC5e8X2bBuohDXP+YgN18=; b=j+P9Lli+ZmJKfVvbIBNCXhgH0SpReiIXZQytUD9k1Hxgv1OCKzxWNJBBblmoQOl+ h0+9O4wRTtc4tCfZniIXyrILi3uOIRLQk/iNlB4TbTb5isMaE5hcMvUJgCQ8v+ouG5u 11ws6c3ZQ8EyGssoy0rb6bHTbPgNYgLhbd1aVEvU= Message-ID: Date: Mon, 21 Nov 2022 11:07:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 2/2] xen/flask: Wire up XEN_DOMCTL_{get,set}_paging_mempool_size Content-Language: en-US To: Andrew Cooper , Xen-devel Cc: Daniel De Graaf , Jason Andryuk , Henry Wang References: <20221121143731.27545-1-andrew.cooper3@citrix.com> <20221121143731.27545-3-andrew.cooper3@citrix.com> From: "Daniel P. Smith" In-Reply-To: <20221121143731.27545-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 11/21/22 09:37, Andrew Cooper wrote: > These were overlooked in the original patch, and noticed by OSSTest which does > run some Flask tests. > > Fixes: 22b20bd98c02 ("xen: Introduce non-broken hypercalls for the paging mempool size") > Suggested-by: Daniel Smith > Signed-off-by: Andrew Cooper > --- > CC: Daniel De Graaf > CC: Daniel Smith > CC: Jason Andryuk > CC: Henry Wang > > It should be noted that the original XSA-409 fix broke Flask on ARM but no > testing noticed. c/s 7c3bbd940dd8 ("xen/arm, libxl: Revert > XEN_DOMCTL_shadow_op; use p2m mempool hypercalls") "fixes" the original > breakage and introduced this breakage instead. > > For 4.17. It's a fix for an issue that OSSTest is currently blocking as a > regression. Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Mon Nov 21 16:16:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 16:16:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446754.702539 (Exim 4.92) (envelope-from ) id 1ox9TV-0000QU-Gd; Mon, 21 Nov 2022 16:16:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446754.702539; Mon, 21 Nov 2022 16:16:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9TV-0000QN-Dh; Mon, 21 Nov 2022 16:16:49 +0000 Received: by outflank-mailman (input) for mailman id 446754; Mon, 21 Nov 2022 16:16:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9TT-0000QH-4Z for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 16:16:47 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e36d15d3-69b7-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 17:16:44 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1EFBE5C01EE; Mon, 21 Nov 2022 11:16:43 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 21 Nov 2022 11:16:43 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Nov 2022 11:16:40 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e36d15d3-69b7-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1669047403; x= 1669133803; bh=8u8BK+CFOK6Os3q3JXi2LJOFdVIbcEqAq43H0giut5I=; b=a 1AsJBgHv/PWsYOqBDV6KWtZK9U51frFcUYVVexL9W99wdVN/wA7niic6xoagcZ9m jLckeRlhfPDolwITvqk3EuBat+8GbmVsJULLtxajVFlqJFZWfW4AWvUZm1jtYwia jGvPjTq0uwHiytaAeKg/BboxsD5N4V+3aW906md+G3/TC36s08eRp2i7LL2w2aul ldd1T8S4iU+aG8ggEJPxWy294S1avVisBcHTGGLVc+zF/8WXtHH2OVKZU4r5M9oz WXBXPXlpx6BZq0Lte6IcPQa1LDPxir3yT60prg5EzJc3HE+gHe86u6P1L4IO1M7s 5WWjlZ+3pBKvtLNgNXWaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1669047403; x=1669133803; bh=8u8BK+CFOK6Os3q3JXi2LJOFdVIb cEqAq43H0giut5I=; b=P6gIsGnHA8cbrAgjOHVE6p1MLiEV0C55j+cYjEvhl/RP sY+rA9V49gRUZF1rTWAxLN4jqlfLofdrMHw9n//8hrjGTFOnnE3V5r/A2v3voZ6d E/G6GBSLHIMZcwAXZTUPC1qj8QqUzweSXTmP7NQW3af8OXQE6M48WPDCFSjlE12S EwIbG/2xV5Kr0nBOAwri+P/FqeXN3hWZRo+meSvxBRd8FAITRN2UJRLBWGiguevH gfQwWAD8mP2PsxDDesccivP7ARMIHUdwDbY/ReG9QHDs04E3UiyeN83sKbwbv+3r 2smN+20GvljOIYu51qASdrw0CvUOvzSCTHM1tSrrTQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrheeigdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 21 Nov 2022 17:16:37 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jason Andryuk Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Subject: Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled Message-ID: References: <20221118154931.1928298-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Zq9ZSVbg9oNu91zv" Content-Disposition: inline In-Reply-To: --Zq9ZSVbg9oNu91zv Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 21 Nov 2022 17:16:37 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jason Andryuk Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Subject: Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled On Mon, Nov 21, 2022 at 10:41:34AM -0500, Jason Andryuk wrote: > On Sat, Nov 19, 2022 at 11:33 AM Marek Marczykowski-G=C3=B3recki > wrote: > > > > On Sat, Nov 19, 2022 at 09:36:54AM -0500, Jason Andryuk wrote: > > > Hi, Marek, > > > > > > On Fri, Nov 18, 2022 at 4:46 PM Marek Marczykowski-G=C3=B3recki > > > wrote: > > > > > > > > On Fri, Nov 18, 2022 at 03:46:47PM -0500, Jason Andryuk wrote: > > > > > I was trying to test your xen-pciback v3 patch, and I am having > > > > > assignment fail consistently now. It is actually failing to > > > > > quarantine to domIO in the first place, which matches the failure= from > > > > > the other day (when I more carefully read through the logs). It = now > > > > > consistently fails to quarantine on every boot unlike the other d= ay > > > > > where it happened once. > > > > > > > > Does this include the very first assignment too, or only after doma= in > > > > reboot? If the latter, maybe some cleanup missed clearing MASKALL? > > > > > > It's the quarantine during dom0 boot that fails. Later assignment > > > during VM boot fails. I tried warm reboots and cold boots and it > > > happened both times. > > > > > > I also modified my initrd to halt in there and checked the config > > > space. MASKALL wasn't set at that time. I need to double check - > > > MASKALL may have been unset after dom0 booted in that case. > > > > > > I'll test more to figure when and how MASKALL is getting set. >=20 > I'm testing with a laptop without a battery. It seems MASKALL remains > set when rebooting or when left plugged in. >=20 > From unplugged, a cold boot doesn't have MASKALL set and the network vm b= oots. >=20 > After that, rebooting the laptop leaves MASKALL set on the NIC when > the laptop reboots. NIC assignment fails. >=20 > Shutdown and later boot while left plugged in keeps MASKALL set. NIC > assignment fails. I have only tested this scenario for short periods > of time, so I don't know if it would eventually clear after a longer > time. That's interesting, seems like firmware is not resetting the device properly. Maybe related to enabled wake on lan? Anyway, resetting the device at domain create/destroy is AFAIR normally done by pciback (at the instruction by the toolstack). Should it maybe be done when assigning to pciback initially too? Or maybe in this specific case, device reset doesn't properly clear MASKALL, so pciback should clear it explicitly (after ensuring the MSI-X enable is cleared too)? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --Zq9ZSVbg9oNu91zv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN7pGYACgkQ24/THMrX 1yxERQf9H+wGG9EoUn9lEqAbJsW6Pe0L4+RgIEU63aMDb1AWJH8jNYkUWaNM5X6A goktstxeX/Y3luFyhQujlu4+SyqVZdouIzyB2Y6LUf+GVo9a2uKVVYR1OpFAcoEM w4vCPhDx4T6IE1iAWxLmLJzRz5c1BOEp7srCrDMCCShggoiKpgGrOeXaKuu1rzPU sSj+BTJcnR/TT+REL1HQkClQIzA4+bfjQyfU3uBKcMzS3IEJdb5BEu/ApHcWO/i7 k0ciDq9j3iBxBZ7tE7CbsY3eM8mYuQUnF8PjA2T/9R3gge0P2pogZmYGxfHsfjbA 7arbj3nv9o75HQoDNWT+a10mfYgsDw== =haAo -----END PGP SIGNATURE----- --Zq9ZSVbg9oNu91zv-- From xen-devel-bounces@lists.xenproject.org Mon Nov 21 16:23:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 16:23:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446762.702550 (Exim 4.92) (envelope-from ) id 1ox9Zp-0001wY-8H; Mon, 21 Nov 2022 16:23:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446762.702550; Mon, 21 Nov 2022 16:23:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9Zp-0001wR-3M; Mon, 21 Nov 2022 16:23:21 +0000 Received: by outflank-mailman (input) for mailman id 446762; Mon, 21 Nov 2022 16:23:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9Zo-0001wL-9u for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 16:23:20 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cefced53-69b8-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 17:23:18 +0100 (CET) Received: by mail-ed1-x52b.google.com with SMTP id y24so11957338edi.10 for ; Mon, 21 Nov 2022 08:23:18 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cefced53-69b8-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kOC3xpcSeBrhe9xp8UYxSIBZUQ4q9qNE3uC0xGYTuIk=; b=STpcBNP/F9DSWXS08DECPjprcKuC7AH7LAGxWPSkl4/pq/Wi4xU0THsqWYL4L8ds9C ChNWBFSD9fX/Z0nYPfhK46OE1L6FVc/xCq8/CKtXK+8J5F5dvFZ0bCOiW5ndxktv7Fd6 dfaGxFO3WQXAeaTRj+4KHsPC4tRbHFQV0of7IHutMP4ihrwC62SrBEUOc8irrqLAdx6J sLYYKsPT+QuIY/KvA3vJ8qsBjAsQ9lQJ72cxA9Nuzz/vXIYsJmVLjigNmBoXiZfUhfp7 C+CbLQYgNjzwtL4zPOAoNGGpaJvSVK7TutXBzz2mHKu7fp9kCLDXVrDRpEcjupWLWKiQ 03Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kOC3xpcSeBrhe9xp8UYxSIBZUQ4q9qNE3uC0xGYTuIk=; b=T2K2pSzZ+tECwWwGz9k7x/k89c4wjft2MfOIQIMdoc36Us74CkMjGuBOIfiU5NXuo0 GntdRKpSmH/7gjnHZ7JWb6jTsNsZA4/N2/KiZQ4Zw6hAdCM0HRbQ8JrBi9AcFo3xLZln F3D9snKeHUi+GrPwrNBsgBESA0bIOIqvQ2jyuIClCqv4oGqoPCdjvzjIcLP0bfQvrYTO Z7biB+rxvf4VV1Q90s3+XuPPernbXEryiuyCXz1eVZk8i0YN6Xuh8aws6pkL7KRc4ggB r7799LBx6muNOy9wjDMwSo3Euf2JslR5VbwK1hnnRmiaHUDzWZckuZpYY09J8W7Rt4O+ XyDg== X-Gm-Message-State: ANoB5pmv7TEWNV7NwK+ietisUZSEJ5YspiGFy+LnRA/hzv3b/YFuuhc8 bB7eQ11MbngFsv64QkMkvjd1YP0VEDsrXMDDwrgoMw== X-Google-Smtp-Source: AA0mqf5+XjN4gBu5gbLyOjFcHQ/vJLXZsjq4uuQyMhlNEfqGzsoJPLlHEXghmvwENQNB/84KsXGXckMznCAk0HKsTAM= X-Received: by 2002:aa7:cf12:0:b0:469:a6ce:bb5 with SMTP id a18-20020aa7cf12000000b00469a6ce0bb5mr28356edy.368.1669047798320; Mon, 21 Nov 2022 08:23:18 -0800 (PST) MIME-Version: 1.0 References: <20221022155120.7000-1-carlo.nonato@minervasys.tech> <20221022155120.7000-3-carlo.nonato@minervasys.tech> <2e6c8d81-01d1-81a1-8fd4-4385e46befe4@suse.com> In-Reply-To: <2e6c8d81-01d1-81a1-8fd4-4385e46befe4@suse.com> From: Carlo Nonato Date: Mon, 21 Nov 2022 17:23:07 +0100 Message-ID: Subject: Re: [PATCH v3 2/9] xen/arm: add cache coloring initialization for domains To: Jan Beulich Cc: marco.solieri@unimore.it, xen-devel@lists.xenproject.org, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Marco Solieri , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Type: text/plain; charset="UTF-8" On Mon, Nov 21, 2022 at 4:14 PM Jan Beulich wrote: > > On 21.11.2022 15:50, Carlo Nonato wrote: > > Hi x86 devs, > > Any reason you didn't include Roger? Nope. Sorry, forgot to add him. > > I want to ask you some questions about this patch because in the previous > > version me and Julien have discussed how cache colors should be passed in > > domain creation. You should be able to read that discussion, anyway here is > > a link to it > > > > https://marc.info/?l=xen-devel&m=166151802002263 > > I've looked at the first few entries, without finding an answer to ... > > > In short, using struct xen_arch_domainconfig works fine only when domctl > > hypercall is issued. That struct contains a XEN_GUEST_HANDLE so it > > should point to guest memory and must not be used when creating a domain > > from Xen itself (i.e. dom0 or dom0less domains). The easy way to go is then > > changing the domain_create() signature to require also a color array and its > > length to be passed in for these latter cases. > > Are you ok with that? See below for more comments. > > ... my immediate question: Does supplying the colors necessarily need to > done right at domain creation? Wouldn't it suffice to be done before first > allocating memory to the new domain, i.e. via a separate domctl (and then > for Xen-created domains via a separate Xen-internal function, which the > new domctl handling would also call)? Or do colors also affect the > allocation of struct domain itself (and pointers hanging off of it)? This would be really good. The only problem I can see is the p2m allocation which is done during domain creation. With the current set of patches it results in a "Failed to allocate P2M pages" since we want to have p2m tables allocated with the same color of the domain and a null page is returned because we have no colors. > > Another question is then if xen_arch_domainconfig is the right place where to > > put the coloring fields for domctl hypercall value passing. > > See below for more comments. > > I think I said so before in other contexts: To me this coloring thing > isn't Arm-specific, and hence - despite only being implemented for Arm > right now - would preferably be generic at the interface level. Ok, I'll try to do that. > >> @@ -232,6 +233,62 @@ bool __init coloring_init(void) > >> return true; > >> } > >> > >> +int domain_coloring_init(struct domain *d, > >> + const struct xen_arch_domainconfig *config) > >> +{ > >> + if ( is_domain_direct_mapped(d) ) > >> + { > >> + printk(XENLOG_ERR > >> + "Can't enable coloring and directmap at the same time for %pd\n", > >> + d); > >> + return -EINVAL; > >> + } > >> + > >> + if ( is_hardware_domain(d) ) > >> + { > >> + d->arch.colors = dom0_colors; > >> + d->arch.num_colors = dom0_num_colors; > >> + } > >> + else if ( config->num_colors == 0 ) > >> + { > >> + printk(XENLOG_WARNING > >> + "Color config not found for %pd. Using default\n", d); > >> + d->arch.colors = xzalloc_array(unsigned int, max_colors); > >> + d->arch.num_colors = set_default_domain_colors(d->arch.colors); > >> + } > >> + else > >> + { > >> + d->arch.colors = xzalloc_array(unsigned int, config->num_colors); > >> + d->arch.num_colors = config->num_colors; > >> + if ( config->from_guest ) > >> + copy_from_guest(d->arch.colors, config->colors, config->num_colors); > >> + else > >> + memcpy(d->arch.colors, config->colors.p, > >> + sizeof(unsigned int) * config->num_colors); > >> + } > > > > Question 1: > > Here is the current hacky solution in action: using config->from_guest to > > decide whether to call copy_from_guest() or memcpy(). This is a no go for > > Julien (and also for me right now). In my current work, I tried to get rid > > of this field simply by calling copy_from_guest() only in domctl.c, but this > > solution still isn't easy to maintain because the config->colors.p field can > > either be a guest pointer or a Xen one and mixing the two semantics can be > > problematic. > > You simply cannot expect copy_from_guest() to work when the source pointer > is not a guest one. > > >> --- a/xen/include/public/arch-arm.h > >> +++ b/xen/include/public/arch-arm.h > >> @@ -314,6 +314,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); > >> #define XEN_DOMCTL_CONFIG_TEE_NONE 0 > >> #define XEN_DOMCTL_CONFIG_TEE_OPTEE 1 > >> > >> +__DEFINE_XEN_GUEST_HANDLE(color_t, unsigned int); > > > > Question 2: > > This color_t definition is employed because the guest handle for > > "unsigned int" (uint) is defined later (public/xen.h) and (citing Julien): > > > >> Hmmm... And I guess we can't define "unsigned int" earlier because they > >> rely on macro defined in arch-arm.h? > > > > So the solution could be to move everything up a level in > > xen_domctl_createdomain, where using uint wouldn't be a problem. > > If this goes to common code then should it be guarded with some #ifdef > > or not? > > As per above I'd say it shouldn't. But then you also shouldn't use > "unsigned int" in any new additions to the public interface. Only > fixed width types are suitable to use here. Got it. > Jan Thanks. - Carlo Nonato From xen-devel-bounces@lists.xenproject.org Mon Nov 21 16:25:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 16:25:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446766.702561 (Exim 4.92) (envelope-from ) id 1ox9bu-0002WQ-J5; Mon, 21 Nov 2022 16:25:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446766.702561; Mon, 21 Nov 2022 16:25:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9bu-0002WJ-G4; Mon, 21 Nov 2022 16:25:30 +0000 Received: by outflank-mailman (input) for mailman id 446766; Mon, 21 Nov 2022 16:25:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9bt-0002W9-3W; Mon, 21 Nov 2022 16:25:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9bt-0002WY-11; Mon, 21 Nov 2022 16:25:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9bs-0002XB-Qm; Mon, 21 Nov 2022 16:25:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ox9bs-0005WR-QK; Mon, 21 Nov 2022 16:25:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Nze2b50RsLWOmaRFx31xJSb1S+Dy94pb4D3s13ztURY=; b=3V4qSBf/ifENOEN4fylhLydZFp jGOaAVzkXFV4aoGdVfJOoz6LXMuEvHFV0E7wo4cH/y2QuTuTr/3xXRH8Nb03vGDFk0epKEzBke+iQ 5SgXoGg5/sOHhPsaOJdg6qoE65Wnk+MbzZyYLBdQ4j6dEAHOh6tHFI5ugJ54sOdx3OT0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174883: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=8cdfbf95b19c01fbb741c41d5ea5a94f8823964c X-Osstest-Versions-That: xen=db8fa01c61db0317a9ee947925226234c65d48e8 From: osstest service owner Date: Mon, 21 Nov 2022 16:25:28 +0000 flight 174883 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174883/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 8cdfbf95b19c01fbb741c41d5ea5a94f8823964c baseline version: xen db8fa01c61db0317a9ee947925226234c65d48e8 Last test of basis 174806 2022-11-17 20:01:48 Z 3 days Testing same since 174883 2022-11-21 12:00:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git db8fa01c61..8cdfbf95b1 8cdfbf95b19c01fbb741c41d5ea5a94f8823964c -> smoke From xen-devel-bounces@lists.xenproject.org Mon Nov 21 16:27:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 16:27:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446772.702571 (Exim 4.92) (envelope-from ) id 1ox9di-000373-VM; Mon, 21 Nov 2022 16:27:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446772.702571; Mon, 21 Nov 2022 16:27:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9di-00036w-SZ; Mon, 21 Nov 2022 16:27:22 +0000 Received: by outflank-mailman (input) for mailman id 446772; Mon, 21 Nov 2022 16:27:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9dh-00036h-BL for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 16:27:21 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20613.outbound.protection.outlook.com [2a01:111:f400:7d00::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5e5e0f1b-69b9-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 17:27:19 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8187.eurprd04.prod.outlook.com (2603:10a6:10:24a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 16:27:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 16:27:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e5e0f1b-69b9-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B0fNpVRGZjrzI4uaz2a4r27xN9Z3GFe5+eBcsOl7cvgs6hGTDCS9S6sQ+O5GwCbqDnpAexs0+Hf5h62NFPtOqBBQswtHeHtrSV8dlU1jJ/OQO4EI+FSGdyC/9sCRXe+6IvjrDIT2Kdhs1zsvewjcgMr+Ypg+z60ZZjRUt8AOKQo7C0zclDDLtLEJoZQaHWXo+oeaIkJZFbUkOLhlpuMd5bxTA5dW8XHEAR4b21IKlqnAtbHjeIGDm0AzlkNDM/KUXfO76IyNQnV16AvaWk8pCm3e3Ev6qDPVz5Syeu7W9uHq24xa7eAJSXYrm7MHuk010TcsEfXWJnFz5EiMiUQqQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gweotCxjxxG9H3WOS31m2tZBG9WvznEGBh8ZcsSAN7k=; b=VAikol9qkYkgZdB3GZVExlymDwGUr8/fCDoZ00UeLrx0GQ6SDksu4w8o4r86kpIiJG7ZCAYYJz/uaNT6sam7jDwCwAgkQc7/2AQYn2zlqu6VIZ/1XFUDut9LfgHhLvUjbNRQ2dyuTUm/1lwYfEkrWWyw7OaLh4wMdev48uvfwKDYHD/XE1PjKmSLgtu0tKtfRqzf26dxbVsOyxFpEc3ex6mSAFuxPJRPrFJi6Har7x96R1hGltuJJdDbERvRIEVIzpIQGDGVO83qTbEnimHuuiRhSvzjkRzjd1t1y+kSh3ic8rxbYdncNEttO/WySoDrUR5IRnAiCp+yVZ1b2wOkvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gweotCxjxxG9H3WOS31m2tZBG9WvznEGBh8ZcsSAN7k=; b=HSkJWJQTdnO3xwYRZ0H2N+rf8jkdJnTQTPMiVlhrKW3AyyeVvNak/KYk2P7nl2Kcg7go0Rsk1RyPAXBUAmN05iJsJGIO4mmlJkU1SJ+BCEJP5UQJIthvLR2Mjc3QVn0VQxggcSfdyeFWJG6gNp7quh0T6Nwn76tVUtRPFq/6R2A8zbD5BkWZmOA2bs7IkiBHugpD+jMhCg5tEfF0lDnXwy3eyygpqb3PIaDObzv6JCwnbgybcvml3FAC+MKkgbppVyso2NJe9v7YNMliGpaWr3YrDvyV4Km5Qb9/LKrXHxWbAZnr8oRkpqnnekzshmEcK0T6CWRy83xQjvOlTOFUvA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <60663f81-09cd-e46b-bb94-1afe50519086@suse.com> Date: Mon, 21 Nov 2022 17:27:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: EFI's -mapbs option may cause Linux to panic() Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Juergen Gross , Andrew Cooper Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0137.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8187:EE_ X-MS-Office365-Filtering-Correlation-Id: e614d7a2-c914-44ab-0180-08dacbdd4164 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bZboaLBNqMQ0K/kZbYLVzIMDCic/c8G53ynjGmvRGBZxoxY3PEW2nVnEqdqNoQM4QAA0yltE6Yd96Sgan5SK7aKzoMN2uns77aK4XnjkK0/voeGsrrrP6WaB5HY6StJ14QlZl9ob4423OvG9EUXkunpTkT604FHERZCacqXHglfQ/4ZvoePePRmsikqgxQ8H1AjnSNnYj0zbAA9YfzZGLvu6U/Sy9OQ/BHvKbErFgqD7vPGIsEiuRYOh7dSoN3JP8dobXyl8HvIDwqxVwWpW7H2REt6NbHQoSXTLJzkyqqmWtezZgoN0Dt5WxjbXDwDug/10RbxpUMw8F2qwvtj8v1PPHPLlv2WlIGlw0KGV4TE84079Altlh7CWOj3PodNsSkWolq2S+PSd6azK8qglvaaueVLloEVe/aKfPtuSqa/B1AlxYWBX+yNavf+6HnsMn4ES+RISg2X/5IUdR3klwqaAqsn3UsJfQJ8zC4A+Kgi4cJ+LmerNQgBLY3Wg9wFca06UMVPa/jsfCwhYrl9CMXAIGgNTZD5kzQEWb8eZgSkQn7761Z3lEogdBrg5LMAVxXyaP1DmrmIxYSsM6qOShBoORYKZKb9d44CnhVr4H9Q79wfSVIZ6TB9rI9DcqN5edGB2/HP877RnAXOd2q3PWFD8lWS/Fvj33rUxruh3HpTyp6N2UxEB9vqctws5Dtd3yCrELevNlZi9Tfo/toyPTKk/INyrlCYm5FaNN4DlSI0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(376002)(346002)(396003)(366004)(451199015)(31686004)(36756003)(86362001)(8676002)(31696002)(2906002)(8936002)(4326008)(38100700002)(83380400001)(54906003)(6916009)(2616005)(316002)(186003)(66946007)(66556008)(6486002)(478600001)(5660300002)(41300700001)(66476007)(26005)(6512007)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mi9BRGg3RVVqbXpxblJnSFpNN1RIZjYrRjBmRWMvY0k4bXZ4Q0VZZFlGbW9q?= =?utf-8?B?cXhDbS9peURGWDV5SlJ4YnE4QXJNYkpLOG0rMHVINEtwMWRiQ0F2WjZEbU5z?= =?utf-8?B?U2FjZUxxWTIreStZN3dsUTFmcDVObEQyRVN5S0FBeXRnQXNsZjJsOUxacHBo?= =?utf-8?B?Q1Q1UlNzbHFtSkJlNEQxMG1NVmR4Mm1jZ2JZYWxuVGRITndPYmNoYmplUkpU?= =?utf-8?B?WWNRL01KcEVYajdWRVNiWGU1STJZcGFzZlQvNjRvNjRJeFQ4b1VwUndqbnVo?= =?utf-8?B?dlhHQnJKdlgrVUNkRUZnUCsyVmdZTHVSa29aSTBiNktnc3gzOUJWOWs4Q3B1?= =?utf-8?B?bXdPY2x2cGtGRDBTMlh5NHpxNTZLRng5R1E4S0Q3UEVzeVBHQm1LRFY3Y1RZ?= =?utf-8?B?dlYxSEdxSDhtb3BQSktENWJjb1cxTElncUszb3BjcHFnck1TcGFnWk40YVAz?= =?utf-8?B?b3dNWTA5cHBCVzYwUk9MNXc2eVRJRTdJbDlEYzd6NW1vY0VvSGlSMVBFaE90?= =?utf-8?B?NGtwLzhEZytPb1ZFL2FhRTFDcVRBY3VDN0xMRUVIUUZ0eHlLcGFrSmI1cWR4?= =?utf-8?B?RFo5ZUhucTZlQ1Y0OFFxRThDTHBQdW5rWTdHVnlzTmc0U0NRNUFsNUNkSjdy?= =?utf-8?B?Y0RIMHkxQnlRNGxBZTZKbVpHQzNuMGlreSt5QVgwOW5hV1ZXWURUUU5valFJ?= =?utf-8?B?WksvWVdmcFhvRytlWFNCL3lLZUg4aWNJVFJKUXBPZGxnNGRvRUhGbW8vV0R1?= =?utf-8?B?bC9GRnpVSWt1YWdXVUVTbEhqbUMzRHhUK1hWdjh5MjZ5NHErb3FQSHRXTFRk?= =?utf-8?B?NlFtK1VBL2JyUTRSVnZXN1ZLYzdRRjBvVlh0RE92ZEMrWXRiZGhmR21WclRQ?= =?utf-8?B?RjB4TVI4MkRnSXA5NmdFNmp2ZkpwbmdxMnVzZG9vUmN1TkFVNTZiaWszNjFl?= =?utf-8?B?ZGdLcjZTblA2dEhrSHZjc3c0eTFaS0lNRVZkV0pVYTlkRzFhMjlHSDFpcTJH?= =?utf-8?B?UWYxOE9NdXYraEFqa0xRTUdNMTBEMFJEejhSdVpkazAyem5iTjdKUll2VHVq?= =?utf-8?B?MTdqRysvemY0M2lVRGtrWFhKRitFSlBjSFk0bDlmdXlRdEZUMVlTUDlHb2Mv?= =?utf-8?B?VUUzM1I0K2FhWnpScXVPN2YvUkZJWllxNWx5Wk4xdTAyUFBkQitqWVcxdXVQ?= =?utf-8?B?a0cvWXgxOFBDNWtLcnJhc3VjNlI0SnNiR2ZZU05WVFFPTDFqMjBoTVl6NS9Y?= =?utf-8?B?cnEwY2ZYYW5rSnJmZktxTlEyTXY2bkdpbDNCaWYxQndPTjEyV2pML2x1RUo2?= =?utf-8?B?QVhQbXB3UENQcFA3SGpsRlFwQ3dVZ1hXaTdPM1hkcjJGby9QNkx1NndUcFV0?= =?utf-8?B?dmowTEVHdlFBdUhHd1NjcWRtS0k0WWhscnIrdlpKZEZ5Smsrd251eUIyNHJl?= =?utf-8?B?N2MwK0lHT2JOc3JncytjZytXUzIvUTZzdzliK0pOd003eFhGM3FHdFVGbUM5?= =?utf-8?B?VkVheFNSSXBHekRIZnFWQmlnU015aExLbXdFMjVabFh2WUYyS2xoZnp5YU1s?= =?utf-8?B?REtpZ2g2eWdJSWtXdHVmNTR1RHFhOGJVWm9LTENHYVgraVNYVWtlSUdoOVVQ?= =?utf-8?B?QmNuZlpHWFVwMWNwUzdYK2FHbTRhaTRPSVdRU0N5ZTdJd0hGNHdjWlRHbk5Z?= =?utf-8?B?UGlLOFNCeCt4a0xuSUhwbTlaMHQ0KzN2bE13NmVWKzNTVjYwSUxBZ0tvWU1O?= =?utf-8?B?cFErcm1JZnNENjJ1LzdlWG5EUkovbTZYOGllMFBCajFvbGxFTGgrVVVMZU45?= =?utf-8?B?WkV0a0hsa3RyVkcwc0pvcGlxN2JHKzdtUnphMW1lVGFVc2JyYmNOU09VUy9C?= =?utf-8?B?RWtnVVpuTnJxTXBTSG93NVZpcEU5MHVTRTNEbm5HN01Bc0crWTdocS9PZWt6?= =?utf-8?B?N2VTd0c1WGxkbjZFY0FZeXlLMlM5ajZjMldqb2k4L3J5VHpqMW8yMko4YVpU?= =?utf-8?B?c2UwdFdKRk5vY1dvWTR3YWJnMWJMOHV1WWFzOVNYRHdoUFdIa2hpQnBtdG1V?= =?utf-8?B?SGp6azhlRnY0TnB0STFOcEN6eEUyZW1oZncrd0lYWVNUMkRwdHUzUUF1cWZj?= =?utf-8?Q?pf2n99tPgYQlYwoy+dXOB0WS5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e614d7a2-c914-44ab-0180-08dacbdd4164 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 16:27:17.2567 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ibZetBuCKPnB4T8s0fgpUdA9468jB0O0XZ2uoBJbsptolkHqkBXJKf39+SGEXbiLYweGU8uaW2QWX/ADG3Opxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8187 Hello, on a system with these first two EFI memory map entries (XEN) 0000000000000-000000009dfff type=4 attr=000000000000000f (XEN) 000000009e000-000000009ffff type=2 attr=000000000000000f i.e. except for 2 pages all space below 1M being BootServicesData, the -mapbs option has the effect of marking reserved all that space. Then Linux fails trying to allocate its lowmem trampoline (which really it shouldn't need when running in PV mode), ultimately leading to panic("Real mode trampoline was not allocated"); in their init_real_mode(). While for PV I think it is clear that the easiest is to avoid trampoline setup in the first place, iirc PVH Dom0 also tries to mirror the host memory map to its own address space. Does PVH Linux require a lowmem trampoline? While the two pages here are just enough for Xen's trampoline, I still wonder whether we want to adjust -mapbs behavior. Since whatever we might do leaves a risk of conflicting with true firmware (mis)use of that space, the best I can think of right now would be another option altering behavior (or providing altered behavior). Yet such an option would likely need to be more fine-grained then than covering all of the low Mb in one go. Which feels like both going too far and making it awkward for people to figure out what value(s) to use ... Thoughts anyone? Thanks, Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 21 16:27:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 16:27:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446776.702583 (Exim 4.92) (envelope-from ) id 1ox9e1-0003YV-9z; Mon, 21 Nov 2022 16:27:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446776.702583; Mon, 21 Nov 2022 16:27:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9e1-0003YO-7A; Mon, 21 Nov 2022 16:27:41 +0000 Received: by outflank-mailman (input) for mailman id 446776; Mon, 21 Nov 2022 16:27:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9dz-00036h-CH for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 16:27:39 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 67f8937b-69b9-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 17:27:37 +0100 (CET) Received: from mail-dm6nam10lp2101.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 11:27:28 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by PH0PR03MB6350.namprd03.prod.outlook.com (2603:10b6:510:bf::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Mon, 21 Nov 2022 16:27:25 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 16:27:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67f8937b-69b9-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669048057; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=cGveTbYlUtYIGfGjD5yYpeKLamNB5hByN35fm9LvD44=; b=MntIjVYbUKKTZ0YwS07N1NnhN2EB/vzuM2y9bK7SfWYHx1LCry9hqpYq 7gHbfvdc/nkKZES/a6a/Y1uVM6NDgTTqt0TpSJDgeJd76CTiK9fNlZb0/ tGS4sVSmX1EXPKZ91dj2FE5SHFeRvVqKZMGDoDm+Hj/UMM2Hm65A3WzWm 4=; X-IronPort-RemoteIP: 104.47.58.101 X-IronPort-MID: 84845554 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:VQT8A6OV53tuQvrvrR1llsFynXyQoLVcMsEvi/4bfWQNrUp00DcHy zdMDGnVbKrbYzHweIt0bd/n8xhVvJbdmIVjSQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5AVmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0tcuMUpu7 NYhExUEawKIqaWykLKUceY506zPLOGzVG8ekldJ6GiBSNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PpxujCKpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+toi782rKSwH+TtIQ6LaC57NpIkVuq4W0sEwEIZF2Dr/2GlRvrMz5YA wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/vrCiZoq6a9Um+G+/GfqjbaESwUK3ISICwJVw0I5/H9r4wpyBHCVNBuFOiylNKdJN3r6 zWDrSx7i7BNi8cOjv2/5Qqe22vqoYXVRAko4AmRRnii8g5yeI+iYcqv9ETf6vFDao2eSzFto UQ5piRX18hWZbnlqcBHaLxl8G2BjxpdDADhvA== IronPort-HdrOrdr: A9a23:GJu9a60y4848+sWtqQO/rAqjBdhxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtrp uIEJIOdOEYb2IK6voSiTPQe7hA/DDEytHPuQ639QYRcegAUdAF0+4WMHf4LqUgLzM2f6bRWa DskfZvln6FQzA6f867Dn4KU6zqoMDKrovvZVorFgMq8w6HiBKv8frfHwKD1hkTfjtTyfN6mF K12DDR1+GGibWW2xXc32jc49B/n8bg8MJKAIihm9UYMTLljyevfcBEV6eZtD44jemz4BIBkc XKoT0nI8NvgkmhNl2dkF/I4U3NwTwu43jtxRuxhmbim9XwQHYfB9BajYxUXxPF4w541esMmZ 5j7ia8jd56HBnAlCPy65zhUAxrrFO9pT4HnfQIh3JSfIMCYPt6rJAZ/mlSDJAcdRiKnrwPIa 1LNoXx9fxWeVSVYzTwuXRu+sWlWjAJEhKPUiE5y76o+gkTuEo841oTxcQZkHtF3ok6UYN46+ PNNbktvK1ST+cNBJgNS9spcI+SMCjgUBjMOGWdLRDMD6ccIU/ArJbx/fEc+PyqQpoV15E/8a 6xHG+wjVRCOn4GNPf+nKGiqnv2MSaAtHXWu4xjDqFCy/PBrOGBC1zAdLgs+/HQ0Mn3TPerHs pbA6gmcsMLHVGeZrqh4DeOJaW6CUNuJfH96exLL26mk4bsFrDAkND9XbL6GIfNeAxUKl8XRE FzFgTOGA== X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="84845554" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oIoxd9JhG43ATbf3w97tlDb4bQ3lwzWvfEL7XmdRL9GAqu20lNH/YcdvOJG+Q+89BPQUR0iGMWWDeosjjE/kBxPx2pivMHJmACWz634Y3LSmZs2Tt86W1JpcevtUcvJkG1LMy2Wzonp37zeEiV9mSMPve6pzKFm8sLE7em8s1s/9evWTqLHtKHGPrx4cZh8CFsW/DC74H1Ww8GJQO7b/JXvpLI5F73tsR55b7Aue0DJy++sePbD+iRoRP/0KlKiPKXxNXfvu+a2uWUAtwhKh45985X9mAx/UuLwhPSg3KyY8dPd9wCe8OubhKxYkrfr0dIWGAK7NCxlp/Dv+TOKEYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UsDEQpJHO5qJ24sFtz7HXkUECot20VnojR6DUr5V4Ms=; b=ntMaA6Azl3RsjhJsBsXqCj0Nh/G7UGhKXMMdKTVbWGWigxNxCcmYe4fCiELKfT9btdOexdWDJvVQFkTRmLiPr0wGTB4J5kSPZ+a3aDP89JUQaKtlKcOmb64HH1bZMzctJ1o6c4SNhLWSnN78oRD2usZABbH8F0UJPvZJ+7351afYCELUdTR0AWlp1sqmG5xRKgHz8NpaqPECQfXa+LaV9ac1n9jIy1Sw7C7NvTpOtoqX1ztIUtXbh1nq2nTrOeBLZrBk+RGS1iZXey+0FJomW5bEOGU7K+yOtKa9iZ9V8dWXlTfKuRzEu8bEQXxjFfHdxC43DqpyumPgXyhklaNIyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UsDEQpJHO5qJ24sFtz7HXkUECot20VnojR6DUr5V4Ms=; b=pIAVQ+2ynKeGQBPgqQ0zJFez31ldOzUOS0ZEt2X55FWlZoe67uHlPnttDZuBeHzYQ529uifJBCoBAnv1K2jcHxpUgiqPW6CI8RiOq/pW7CP3ZCGcpPxGhjxzsm2ZvsTCUt0AlK+Av8j5BLnh2oN58MyD7V5pKabn6pg/WQvWhUc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 21 Nov 2022 17:27:19 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: xen-devel@lists.xenproject.org, jgross@suse.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] xen: ACPI processor related fixes Message-ID: References: <20221121102113.41893-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0573.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::6) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB6350:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f828085-d316-4891-b486-08dacbdd45c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: avCsakB1YpFdIiWP5zy2QqBWzI5kBMasDQiPUn9+CYwfs5xlmk0NxdNKXK9LPydPmHsY8XtwWVvZoR+tO6kyzWM01z2cmXqBvmO2i4rjkjnYQWHUUgCJsxhK5nSng85crDHdIb7gMqEOuUOm3ERyA85yE5p759uh8YHlWFfVayjsMvQrO38zP/hNr5F8KKcB223FtVmW/CB+TfG8v+LwzQZsFLR4vdwSOwKJhYnzRjRQpgI2984BOe3fL35CQD6MDmHoDSUE2ZYpXRXVQtjbEx3W8cQj04NpE4c4mmdZQp9hnSKsNHS+OxhH7empfmd6kwpHmOom76aVhKddaCUgUoWTeE4Gr/JfyJv/PPwvjuS6y7vSF42g0IZqQRTFJlHIKByyVz11ao6t4glzOs7zcO3i7pe9n6sqQwOosd5RZ/xkG9PGp9Z6uxG7f1AN3rXFso+CVS0GHgxVrrPy4mGyvOjPfTUTT65oLhw723aO274i6AdfhSGUIulRPz+YIW93s/vM1VADhfQQdcpLAC5ls7YBiQHRDL8IbW9h26vC2k8mrh9QDBwoeQBjs0oz2t5buUKkCuA1/5Y6U05pK4nOfFkkfCFuMUvczH5Lzc7jbLy5j0koc6DrmGN4VRlP6pN752soyJ0rAhb/emOv+12WtA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(396003)(136003)(39860400002)(346002)(366004)(376002)(451199015)(82960400001)(38100700002)(33716001)(26005)(86362001)(6506007)(478600001)(6486002)(53546011)(6666004)(5660300002)(8936002)(4326008)(66556008)(8676002)(66946007)(66476007)(41300700001)(316002)(186003)(2906002)(6512007)(6916009)(83380400001)(9686003)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0Jzczk1V2hpd0k2blJyY1JjeVlFL2dnWk1kTWdPSE5TejZNUGJ3MlhXU2hh?= =?utf-8?B?cjl5SitwNmRQd2FvbWNEOUVaRklPQzUvdW9HYTZvNzI2NW10dExZV09VdVh1?= =?utf-8?B?LzBNVVlCVGJrY1NBZXNaQ0FxNUhhRHJkZytwUGVaZjZ0V0gvNEhPUGZncVBI?= =?utf-8?B?WkhEeXdEbkk2RUlUNnhJRU9lai9wTlA2U08yT01IQlB1elY5QkRlVHVlNjJa?= =?utf-8?B?TWpXWGVtZXNYMHdFeG9HbE1kakE1azBacHVKQU5FZWdaUUZEZ1FleW1vVlpZ?= =?utf-8?B?ZjR1WlRyMm9EN1dDajZaSzNpYlpmd2FuVHh2YlljTWZTUUVLU1p1RHNUYUFp?= =?utf-8?B?SVJCWjFaSTFnQm5aSGVUWVhPeS91eVdWQXFUcUp6MzdFeG5ZcUVBaDRaNGkv?= =?utf-8?B?YUNXZkJZOHYybE9VM3FZcHY5MUc2REJ5bVJyR09uL1hYWUp5ZW9wK0hoQ0Vk?= =?utf-8?B?SEZsTHZKQzBwSEJPTGp6UUlkUUwrcHB3K0w1SHhpdkx1dFJTeHdwKzlUbGMv?= =?utf-8?B?SEFtWlRkczJydjh5TmRTM3dqak1lam5hQW1HSUJQRWlyeUJ1eUhCc0hhNnNS?= =?utf-8?B?NHpiR091Wmo2NmowNThnZnB1Ky9GVWZoVUFHbTV0VThUSXk4V1VLQzN6UTZU?= =?utf-8?B?L1pwbHFmV2w2bW4zZXBhTG4xTXVjN3VlYmxjMW9rNEdWRWZPWDFMSlBMVFlu?= =?utf-8?B?N0x1b0Q1eW9nNkNmenJYVVRxWTY3WE1CTWU5d3dYWHpFVjVZY0RpQ0IyUWc5?= =?utf-8?B?amFsanJYM0g4djJSdlFNS1hkUmVBR1dISVJBTURqYitkNGExNXhRQXlQeXZl?= =?utf-8?B?L2FaQjZyYXhqSXRSbTN5LzB4TE5jQ21jVHFYN1ZzR01oY1FXL3Jibks4YUpX?= =?utf-8?B?QUNvK1AyOGpOb0RtUFNTS2Zlb2hmcm9IdTFUODJkTzBFMGJUR1hxTmxvYnBH?= =?utf-8?B?T3lCckoxRDFTclo4c0lNUWNqL3Qxem93bVJtejRmaFBOR1g2bXJzM3hQYnFy?= =?utf-8?B?Y1dZbUpTODFHWnZ0akhkUWNrcGlyL1E0eWRYUUpYZTRSQis2VkNHRmkyUmhy?= =?utf-8?B?dSsrY1djK2ZEeEtPVWJSeG5KUy9iYWZQZ3htWGpObzE3Y1J3UXlUMzNUeDlp?= =?utf-8?B?WnZxTE1SVENhNzlwMUJaN244UksweXErMW9zVis3TngvNXFyQzU4STIyc25N?= =?utf-8?B?L01yTTVRVzg0L0JEZzN3alNHQ253RVY2S3VaaTRDbjlRMXJacndFK3I4ZEND?= =?utf-8?B?bHVpL0FnVmNnd3FLTWdrUDh2MlUrS1hZaWZVYXNoVGVBaVJZMGVwaXVjMzQ5?= =?utf-8?B?aEhEWndKRjdkVURyRDJEeUd4MjQ1MGdscTdGSkp6UlVkYmVMYnhCNTNHbEMw?= =?utf-8?B?Z1NlNU5HYlN2THB0RWZGWHN5UGlzNzBMKzlkQ2p6enY4Vjl6VVZFbkZzN2VX?= =?utf-8?B?ZWs4K2ZZVE82WEZGUkxpSzJMVFRZZDNlZm81R2wxQ2t5VVJScGU2UW9qQ2ZU?= =?utf-8?B?ZlAyRjk4TjB2bVAreU1uV0tZMmQ1MHRoSnpuWHUrRklZcG9veWR1VGU3N2FH?= =?utf-8?B?Y3NmZ1dtVmtsbmQ5WXQrRnJlTmFDYzh0ajByelFBZ0QySE5mSkdpckRjbHl1?= =?utf-8?B?KzlvMmRTZ2E2WEE0V1N4Mkx4VFRXc2JHaXM5ZWh1ckszRWdDVFVSSXJrUEdR?= =?utf-8?B?NEhUaFlMYnFRY3ZhVHRCVjV5OW95SzZRNUNlS2NrYlFXMnB6amo1MVlhODNs?= =?utf-8?B?M0UwMmJVY2NlWVJURVdwNWtra0lsLzlEemEyeUhOZU9NUFB6WUtOU3dVUWpS?= =?utf-8?B?QXduS0NpUVczQTliZUtKeTVUdjVRRUdRODhENno3M2xLQm15OENLTEp3Tk1F?= =?utf-8?B?OHNJVzVGL3FSM21ZTCt0U1ozKzlUaUpPR2l1bEFneC8zM1NUT0hlbUFvQkFo?= =?utf-8?B?aVYzTnZXQXlZVnNMQkZWcFVtZzhEYkFYTm5wWnZaeXMxNDlsM09QdC9lUjd2?= =?utf-8?B?VTJtQzU5Nlo5S1VhM1hXczNmOGprTllYRktpOXo4eGlveHBSRjRlZTRYeGZH?= =?utf-8?B?dWVIeEVVR29ac3RETXFhMktGTlN6MmRUNzBvTHBJZXY5YkxCaXppeExqWDRV?= =?utf-8?Q?iXwvticTTHULGYmZcjBngVpoJ?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: o+sqLHxymIPca3z3XM/2t0I9q89f7wgQNv8mHsTFpyUhAQPczGCGBKV2niGI82KK1LzTuipQBUMxrTmisBcz1TufQTKkKVbWmujVWSqn2evhg+tBWd6sk81kcScFYxFFgBZ98Ji+WPpYrjhUpntQI6ghYTP+mN6kSFiWsKU9H4Ti7ldF3Ov6j5Nkctb4C3UEGFzMJcss6Rulgpk6ykipK3oKIEDxsZ2v2H2KF9RmsTax5HN5UCmdp7SqmTAXSz0M0cHvnN78ANc3KJND78ipxe1x01FLC8ZNi9XmT5H2EsfK1j5VihLlwHTA3E+jJi0YYGxh+LA9sXrtKBWesQvxO6YxET9btstkeXS8ZzCpGQxVzwM5iuFNvq+7w24QCk95KLxT5SgyMZZai0Em+Ugnas7X+xcIBWInvwlhPN5OpQ1O3S4lDOkXmDhbod8W+zubaZbfKFUJyPqSFNxHWmbfimS45SC+sopNFW1BJW4Zp5ESRizCfaGnHZKfgTvQqjOc3LDGpH5mdkQguKF4gkLhcGR4iLRA0pQvQ0wlxk/yGtu060Rq+ABL2dMJMZr/sTK68CijnzevmiOaLgl8YudcXLFTkia3JmyeD7T8xFq76QQiUr03alThmm+UxSu7av2pmnYr09bpz5zhJa4NCxyblYHEoe9c525FrkiFxs0M0z7rHf9sgfrjfIF6cTuWW4HnnwgGJ55D15qjZ1rOrued4EN2VcbdFz3ceP5aLF9dHkwBicYWfqdGf8oAelMYI4wSkIGqsqy1ClXxW4Kfd2LxIbniRqSVML4UIKKsY1oXB6B6lNpORR7sPvmQRrThahyQb4C6tchrye8GA1gWepZiEmwJYd57GfKX+GDRvXLBfEsq4SwrndNMumeAlsm3M6zu X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f828085-d316-4891-b486-08dacbdd45c2 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 16:27:24.7770 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gq+BjUuQjIsGxnzgTx0NRgszJX8XGRXDv3J/u3biWfVbrcFQaCIotBSNaQk6DtS1vxmhacPKqhXWTjnuC8VKTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6350 On Mon, Nov 21, 2022 at 03:20:53PM +0100, Jan Beulich wrote: > On 21.11.2022 11:21, Roger Pau Monne wrote: > > Hello, > > > > This series aims to fix some shortcomings with the handling of ACPI > > Processors objects when running as a Xen dom0. > > > > First two patches fix the execution of the _PDC methods for all CPUs on > > the system and not just the ones available to dom0, while also making > > sure that the _PDC capabilities reported to ACPI match what the > > perfrmance and power drivers in Xen can handle. > > > > Final patch fixes the Xen ACPI Processor driver to also work when used > > in a PVH dom0, that has a custom build ACPI MADT table and mismatched > > Processor UIDs between the MADT and the Processor objects in the dynamic > > AML. > > > > I don't really like the current implementation of the Xen ACPI Processor > > driver, it IMO relies too much on data being fetched by generic kernel > > code. For one the generic fetcher functions can take CPUID data into > > account in order to sanitize what's found in ACPI, but capabilities > > reported to dom0 can be different from the native ones. Also the Xen > > ACPI Processor code relies on cloning the data from CPUs in order to fill > > for the pCPUs > vCPUs, but this is wrong when running on heterogeneous > > systems. > > Yes, these are problems (and as per reading the description of the > last patch you even extend this "cloning" of data), but ... > > > Last patch introduces some helpers to Xen ACPI Processor that should > > allow fetching all the required data, for each ACPI Processor object on > > the dynamic tables. It might be helpful to explore disabling any > > Processor object handling done by generic drivers and just fetch all the > > data from the Xen Processor driver itself for every Processor object on > > the namespace. Likewise it might be better to just execute _PDC from > > that same Xen ACPI Processor driver instead of polluting the generic > > ACPI Processor driver. > > ... cloning functions living elsewhere also has the genuine problem of > them then needing to be kept in sync without there being any trigger to > know when an original function was changed in some way. Well, yes, but using generic functions also has the risk of them being modified to take into account CPUID data for example and then the result would no longer be suitable for Xen's usage without us noticing. Also has the downside of parsing the data into Linux structures which then need to be translated into Xen format. It might be more straight forward to just evaluate the required ACPI methods and parse the ACPI data from the Xen ACPI Processor driver into the format used by Xen and upload that to the hypervisor. I realize however this is a big change, and would mean almost a rewrite from scratch of the Xen ACPI Processor driver. I wouldn't want to start that task without having agreement that this is the correct way forward. Roger. From xen-devel-bounces@lists.xenproject.org Mon Nov 21 16:40:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 16:40:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446788.702594 (Exim 4.92) (envelope-from ) id 1ox9qb-0006G9-Eo; Mon, 21 Nov 2022 16:40:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446788.702594; Mon, 21 Nov 2022 16:40:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9qb-0006G2-BF; Mon, 21 Nov 2022 16:40:41 +0000 Received: by outflank-mailman (input) for mailman id 446788; Mon, 21 Nov 2022 16:40:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9qa-0006Fw-32 for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 16:40:40 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20631.outbound.protection.outlook.com [2a01:111:f400:fe1a::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2f251b03-69bb-11ed-91b6-6bf2151ebd3b; Mon, 21 Nov 2022 17:40:19 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8383.eurprd04.prod.outlook.com (2603:10a6:20b:3ed::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 16:40:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 16:40:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f251b03-69bb-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ks9eTSKH/yTsHTFmwW2TQ9W42ta4+y34Slr/0glkj84coLlBGlmm+qT/xITAy6ZCnQI89XF/sm2afnv3Ocj35KBzFf5tCMHwWZ06lYXxcQcBgux8u7dm6dCDCKXiaowhAcGKxw2h2p2TUcxK7Dgru3u/xryyUtc9jAW8SNbnQXBBymejj4eTFe8IOfVv5uExsikejQS14/0GvlBca5bPwvBFDiIykAAj18kXcPHXkJyZi4747VNUAUStLrEnwMtkcmDc5lUxyIsW9/vQ6xqSSya/CfanodNjluLAsnkN7DBTWV0ZHinvF7h7U7+D4LAi9mMNzOuxXmhABifg0fW5NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fpXqnltry/DVMttgSGxzUaNst09c34V5O+Xj2fwDYdk=; b=fQiPvkNhMV8fPDtUfwn14cU7pfPh/34+ltqAjNzxxnz/+MB5nZuRG/KtatUW1x2WbK6PceQDlDay1tiANp48tPyAim/mlOq0O/4fIBORqqTv2zGh8sJ9nMMLsV0FZFpSm3CKUB3CKJa0N3FKPpDkyAyETrGNmELJXf9XKOeEOw2DQSJ5ExX3B6CdnLJZ1ysnuncaSnDywnVxwLQHy98IWahC1kfpYm8srElbSOq1v51sxymS3G8yAdoePQ6w6Cykeg4rxot5Ks+RhkLRogGQWWriISK270xFzo2z3JlaZAs+QIUa9KVNapNU+xEXcIC7fCHobUcHvA8X4i5RroYqVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fpXqnltry/DVMttgSGxzUaNst09c34V5O+Xj2fwDYdk=; b=353c3JuPoopbemwO3m1H/hztousC5lfUF+vOYpkQbr34bsqlXYts1jKv92SZglxyQ3GjY1Jt6/8xo5xEK+Tnvx8/rHwt2xeXa2NRE5Y7AvWaHntVuMS7YHOfvKHQhpBew4OaTRCypRr9gPwz4aPZjRkGT9PKMXYXOQwWyPYzmyN4no0EitHuiSgY3CH5PwlUNzA+LMv+2zyCQKlK/+o076inxI2HOFP0vNCORBOF69V6Cbr89qIY3TJi5PpwtaTGbMcYrcsh57YvVEB5sqXAgQrO+YOjXu2xmg0btQECgg0hts99ooZfbJNdyuEndY58weBMD11tirorbQSjmDoEjA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6c07cdfc-888a-45bb-2077-528a809a62f4@suse.com> Date: Mon, 21 Nov 2022 17:40:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 2/9] xen/arm: add cache coloring initialization for domains Content-Language: en-US To: Carlo Nonato Cc: marco.solieri@unimore.it, xen-devel@lists.xenproject.org, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Marco Solieri , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20221022155120.7000-1-carlo.nonato@minervasys.tech> <20221022155120.7000-3-carlo.nonato@minervasys.tech> <2e6c8d81-01d1-81a1-8fd4-4385e46befe4@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8383:EE_ X-MS-Office365-Filtering-Correlation-Id: aa8fce05-1f91-46d2-e646-08dacbdf1238 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j3Xr7b2+/ZKOwkZEDjESp2FJjbr7eRMFFKkebD8ARjv2W71hoOozX41u+l7kIZu14JNF2975WlKeyf3TrglP8wOf9iU2lnvADRAXknEGUFEpHGySasOuLZz7xtmXD9hRdlKuXW0pn7l1V6wy+/nYbH85w/OlBOCXtIx2ymwvYD3qoDvu4RshBc6i1U0h9CO7e5o2IbBPgXY6p4BsbSYY4S2CW8KQmB8eWSMaaiO9JY4LTOCu1yAu/hRarWNIZlLGz/nyWl4ypDmxHkbjc1o0m/iiwdiOkGhypa2v06fR5XiAIGWSSrLHHmzP5wdQCCfDzXh3W4+pVmcqS2OBZlBagaaga9g4frqKWcyfrAQ0m2kfYB/LC9XrrgUhFLZ6eGztzo+Opzz3ol+/DhP2vQkgCOjg3BKUVsXwfCVSK8/544URLAptZPrmv+rR0v1qTNvb+LD4HncF2XOeEnE8KPBoAsVcpHaGyhVU7oEFPPXXvSepf3prtVaD32K6EuArrJPp1Dr7ADCY/HgXLbgdjbPHv6GHa6b3eraGcl9yqDlB66+hemXbh4+R0kvOif2FJoUuedUr9cHT7XRfJsNH7H5enT574bOaG9dMShaooMIULv1LHCJ1Ngktuz5p89ojTEsVjb08+HKcnmhWmRE+qKnY2Ei/zWaA98imEUn5bBAhAegObnLYEAUUG7TE/Sg7bPWZ1T2Ex3yc5rEN4vHyEzkiiMprqvsf5SnVMG9+lnbNX5+gTA/gy/FQ+HqyEi/KK7PPbI6+XjHKUyLe2b5kSFeH7A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(346002)(396003)(376002)(366004)(451199015)(36756003)(31696002)(86362001)(4326008)(53546011)(41300700001)(66946007)(2616005)(66556008)(66476007)(186003)(5660300002)(8676002)(8936002)(6486002)(966005)(6666004)(7416002)(478600001)(26005)(6512007)(316002)(38100700002)(6916009)(54906003)(6506007)(83380400001)(66899015)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3VocW9uUVgvTHVBNmhqYTRmNFpzaTd4VVZtOSs5TzhrT0FGdFlMbjE2NXc5?= =?utf-8?B?YlhrYWRtQXpoNG9Camp5OWtvMWxuZXVDdk9WYVhycktOQm0zbHI0YWlYSVMz?= =?utf-8?B?b2hldlBYN1YxYjhKZ1Y3YTRmbHFIMEJDUmVoOVhnaXl3RGlKWnhIVWp4MzM3?= =?utf-8?B?Z3lJbDdBeU00Tzg4L0l1aG9UMkFkWDBNREhsTm9sNnpvc0tUOHJWY2IzQ0Ju?= =?utf-8?B?dFNQSUt2VldaNjBLWkFoSFB2L1RYTnpWWkdPVzltWHZXMGpyekJQQkZ4ZW1I?= =?utf-8?B?STl3Zm12Rm1LbDl3cjc0OGVuK2xzY2Ixa0VOZi9SdUt4Y3l6blpmNnJOODlC?= =?utf-8?B?eklFUUFqSURydUNmaFQ2dU5FQTd4Vno3Snp1ck9aVERPY1Z2MmpCL0NtYVZG?= =?utf-8?B?M1k3YnFYT3o0ZTFlSWZvb05qeXROSjl2U1RGemovTjc0SllxdEt2UFA4MU9M?= =?utf-8?B?ZnRPMklSVjRmTXlHQytQekVJVGlaQjNUVVlpZUx2UTdLT25KSGhIQnFTa1p3?= =?utf-8?B?Uk4rZzdod0ZWSHAxMGZ4SkpFVDFrWDFUNW8rYk0xSXlMOE1oZWlmT1hra3k3?= =?utf-8?B?WUlPbVltWU9xV3BCWmtZVllxWWNQT0tWMWNKL0VQMWlhQ0xTMmJQNDVxcm44?= =?utf-8?B?NVFsOEpwUXR2OWpmNjVzSjNTc1hUZjNFd2psN3htQmIvWXhtYnlQTEsxTmtD?= =?utf-8?B?Y3IvK1ZEbE1TVi93RW1zcC8yZHJDREdIaENUNUZLZS9lQmhsV0ZyQUI2Q1Ar?= =?utf-8?B?R2Q4SmhCU01kN3dDK1NIdWVFL0cvaFhOTVRDbW5pSHErMklkNGNrY2MwMUp6?= =?utf-8?B?Y2hZU3V5NjNZZWVnMnA4VGlaYnBBdUdKSFp3VmJ4c3crYzVKR055MFlkR3Ez?= =?utf-8?B?UWsya0tmUFdOTjZHeFRNMWEzL2lYaHVDdGxaVnM5OHAzYVZMeVh3L2srSlpB?= =?utf-8?B?Y1R2MXl2YWNyQUpvVkw1RWd2RG10TzY3L3BzbUc2ZnJZOGE5ckdab0QweG53?= =?utf-8?B?OFgweS9nUDdIbGoxZHcySHk3NktGWjcvK2poWG4yNnVBQk5WN2FZRUZlUnJG?= =?utf-8?B?bXNMRjZMTWFIM25hMldBWDNhcDVlQVNKRnhta05QL0lSWTcxZ1NqR2NIZmhN?= =?utf-8?B?TTgrMThEK25TNlhGcjNCeFFSVS9IVnV6Zk5zaW00T2swOTRudXJZdzBmbEo2?= =?utf-8?B?aVQ4VktiN2lDSGlWTkIvbTR4N04yVWtXbnM3UkgzOTd0alFaeEkyQ0VjZ2hy?= =?utf-8?B?YnUrZ3ByZ2dzWmZqUktjMTFPckoxODRvb01ydllKejZjUzhZbktHM0t5VTc0?= =?utf-8?B?VmVUVTRrd2FWSnZpdEIxaG9QSkY4eTJjbmwzLzJpSVdkZjFORGdnRXFuRmRr?= =?utf-8?B?dURFUldsak1Sa3cxbVZqODBaTUdOMldQd3Q0bWlnanJNR0hSUDVZU3FjRTly?= =?utf-8?B?REYyTGx6Y0M3QUFBNnhGN0N5ckJBdXVraExVajdEZmZCWWFZWFA4a0YrR0Yv?= =?utf-8?B?MWxLYkdjMURqenRRdS9ZNWFtaUQrZjJkU3gvQTYwUHFVSVdvREFESjcwd3pu?= =?utf-8?B?L2trcmtxWk1SMHd4RzlZQnFSRERuVS9NRWtkazYzM1Vxd1VTUkI4RGhpV0NN?= =?utf-8?B?N3dOTWMya1crNzZDK3d5N3lkRmJpN3V0VEZOMVZIenkyeGw5UXUvRkowa1Fh?= =?utf-8?B?SVFCTGJkMlQyOURyUktXY2x6UDkrSXVIQTVXczI0UzVib0M0b1pKcWhhY2ox?= =?utf-8?B?MEQ0K2NCWFVFWGZNc0kxeVRpR3lxNWJNSWYyYk43VktKbTl5TG84Y3NsVlM0?= =?utf-8?B?ajd1blJ6VjFpWktWN1JmRHlHeWhkSlNmZlBoZW1KRllTN1gzUlNUeDhkSTds?= =?utf-8?B?Y0d0VUVKc1lpdFQ1SnpRLytMM1RHc1VpK2x1aWJBMDZHVHF5LzVyWk11TWYv?= =?utf-8?B?dFZMZm9tTTdjbldoaEEweUNKdFhiL2hHbmZJQURpTFI0UFB6eXR2YjZIYjJI?= =?utf-8?B?cmF0OHp0ZWFPZTVmbTByQllNeFJUVjQyRTNOYjJGOUhMOThaRUQ5Ymh0Nmh6?= =?utf-8?B?bHhKN0F0NjlsNkRtTmwxVUJmaDB3YTBsRHdFeUFaTHlab1RMalRhWTVNQTQ5?= =?utf-8?Q?hqCZyUbanbADg0Cx8znR5/M3V?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa8fce05-1f91-46d2-e646-08dacbdf1238 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 16:40:17.1304 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qqmm1RDr9BhoHdEBrCne2zK2kGkiNh+9lFLk4U6Iy1DsHeyQ2hFXe90+3EKrBywuISqKqfQCK3Ep2AS+y7DJyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8383 On 21.11.2022 17:23, Carlo Nonato wrote: > On Mon, Nov 21, 2022 at 4:14 PM Jan Beulich wrote: >> On 21.11.2022 15:50, Carlo Nonato wrote: >>> I want to ask you some questions about this patch because in the previous >>> version me and Julien have discussed how cache colors should be passed in >>> domain creation. You should be able to read that discussion, anyway here is >>> a link to it >>> >>> https://marc.info/?l=xen-devel&m=166151802002263 >> >> I've looked at the first few entries, without finding an answer to ... >> >>> In short, using struct xen_arch_domainconfig works fine only when domctl >>> hypercall is issued. That struct contains a XEN_GUEST_HANDLE so it >>> should point to guest memory and must not be used when creating a domain >>> from Xen itself (i.e. dom0 or dom0less domains). The easy way to go is then >>> changing the domain_create() signature to require also a color array and its >>> length to be passed in for these latter cases. >>> Are you ok with that? See below for more comments. >> >> ... my immediate question: Does supplying the colors necessarily need to >> done right at domain creation? Wouldn't it suffice to be done before first >> allocating memory to the new domain, i.e. via a separate domctl (and then >> for Xen-created domains via a separate Xen-internal function, which the >> new domctl handling would also call)? Or do colors also affect the >> allocation of struct domain itself (and pointers hanging off of it)? > > This would be really good. The only problem I can see is the p2m allocation > which is done during domain creation. With the current set of patches it > results in a "Failed to allocate P2M pages" since we want to have p2m tables > allocated with the same color of the domain and a null page is returned > because we have no colors. Hmm, I see. It would seem to me that this p2m init really is happening too early. Ideally domain_create would merely mean creating a largely empty container, with stuff being populated subsequently as necessary. But I guess this is too much of a re-work to be done in the context here, plus of course I may be overlooking something which actually makes it necessary for domain creation to be structured the way it is right now. (Imo the reason for the early minimal population of the p2m, added only quite recently, wasn't a good one, and the vGIC init would better be deferred. Yet once again I may lack details on why that's not possible.) Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 21 16:48:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 16:48:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446794.702608 (Exim 4.92) (envelope-from ) id 1ox9yB-0006ud-7u; Mon, 21 Nov 2022 16:48:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446794.702608; Mon, 21 Nov 2022 16:48:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9yB-0006uW-55; Mon, 21 Nov 2022 16:48:31 +0000 Received: by outflank-mailman (input) for mailman id 446794; Mon, 21 Nov 2022 16:48:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9yA-0006uQ-AX for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 16:48:30 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 510f4f17-69bc-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 17:48:27 +0100 (CET) Received: from mail-bn8nam12lp2168.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2022 11:48:21 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SN4PR03MB6781.namprd03.prod.outlook.com (2603:10b6:806:214::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Mon, 21 Nov 2022 16:48:19 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 16:48:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 510f4f17-69bc-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669049307; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=cK4n6ewWgm8jKlO6BsummbS5B6NZxoFXAz6FPcIK/QI=; b=Oz5dZNQF4HN6B/DiRWdX3aVeNRtEUi0gTT85fJbG1KRkbt0eUs+iWR8b p1DAmPKfsQbCsEC/k14I8gVWk91SXYzYrLLbrYJRx9hF3UZ6uW6KxzN+s h6aH+kcnRG2nO396ZB2ErnJiYlwmJkQOzFLmcJQtHO24rXhwJLxPfrD10 4=; X-IronPort-RemoteIP: 104.47.55.168 X-IronPort-MID: 87810426 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FBdvmqNQDnT9XqLvrR2HlsFynXyQoLVcMsEvi/4bfWQNrUonhTIFn WdKWDuGaP2DZ2HyfNFzaY6+oR9Tvp+GmtMyGgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5AVmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vlpXU9W1 8EcEjo2NheC26WG0aymZ+Y506zPLOGzVG8ekldJ6GiDSNwAEdXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PdxujaDpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+toi3837eTx32TtIQ6TeCi+fB63n2qwjIXLgZRdAG1gtWhhRvrMz5YA wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/vrCiZoq6a9Um+G+/GfqjbaBMQOBWoLZCtBRw1V5dDm+ds3lkiWEIYlF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9XABYTzhRqYELukcw== IronPort-HdrOrdr: A9a23:eP9X86o9BAyLsAvFlAAu0UAaV5tBLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN xdmstFeaHN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMD2CAJsQizuRZDzrcHGfE2J9dOAE/d enl716jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDKw875BKIhTaI7qe/NxSDxB8RXx5G3L9nqA H+4kfEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJptkJJi7qggOIYp0kf7GZpjg6rMym9V5vut jRpBULOdh19hrqDymIiCqo/zOl/Ccl6nfkx1PdqXz/ofbhTDZ/L8Zan4pWfjbQ9kJl5bhHoe t29lPck6ASIQLLnSz76dSNfxZ2lnCsqX5nteIIlXRQXaYXdbcUh40C+0F+FosGAUvBmfYaOd grKPuZyOddcFucYXyclm5zwOa0VnB2JRuCSlhqgL3m7xFm2FRCi2cIzs0WmXkNsLgnTYNf2u jCOqN00JlTU84/d8tGdag8aPryLlaIbQPHMWqUL1iiProAIWjxp5n+56hwzP22eaYP0IA5lP 36IR9lXFYJCgPT4PC1rd12GkinehT/Yd2t8LAS23FBgMyzeFKxWhfzCmzHkKOb0oYi64PgKr OO0altco7exFvVaPl0NjLFKudvwFklIbgoU4UAKiazi/OODLHWncrmV9uWDIbRMF8fKxPC6z 04LXLOGPk= X-IronPort-AV: E=Sophos;i="5.96,181,1665460800"; d="scan'208";a="87810426" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dC0+mc9sSBchedzBzcJtUQh+rKksYpZvYvs8eGLHiBow09lDb0uJbRevVVcvUM3HkAtSOaOPBOPOnedq0mY3W4/JjozJsLYP6IjZ7OqsBs1+fj5qmCwtyVboGJUwNKFy3NZUYeY/Y81TjC2I8FCoUbwfbgkZ/GzL9ELo5CLeejLGimw+YIsJ9IiOI+amewpwRVGu3VdcbKdoJIsXN506hkdMwiI6LggxQcxTfvKvdTuf1bfLkbRnBszbtnTjuowO7XA481rujjqEyg65DCCHD1LKOUDCNznb3tAcOjV/Ysy0AEtV0s1PqFjfwje8BbTM0al35PNmhUl4c99lAF1cfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qL8ehkCJaIYXdYnKzFISbnqCkUUCDtOxfQ/QkHU4+28=; b=ANCyyRxuHfIY61b4Q6eBPZLZ8sHtADVUDBDjEsyXkCSXEBItCjCHlsaEo/7MWYh3vixQt/lk+jyC+ckHIyMqIr56bDlQrplJo4Bv3B7yMmjRb18+XmHW9oHdbeR1Pz1zOmo/MYDWblBVaT6mjZ4DbjkQSA7dQfsnSXo+mu2DPEP9+7vUKAgXOj+LxKZjwt9Vw5ZsZihjC76pODle3lmlRS/VCMYbnHBQU/NmtDNcjs1rJSmAAdzvk7fe3fz2L/cWKqYxYYnGm9QGOAKSdndKRCXB+YV1fYhXJec5iJM2wjgHuWaL6FLg4TT4jCdmVK3jQ4AnhTqQS34ziujtcAgzzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qL8ehkCJaIYXdYnKzFISbnqCkUUCDtOxfQ/QkHU4+28=; b=s/afmezUlDFEcc1vT72HA5pV824DCJ08HRI2B9GjpFyD+ZG+kHIE8OgIge8Ssn6Q1EaDIQE6vdA5PVMUrjlYXw6hNSjqHY0+lCha1urnL6M1UHeYL2WNfwSJJikjCeMfU7r2PAd4owry+L2a3nSZ5aXKSF27mqUZ9jqmWYVjNnw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 21 Nov 2022 17:48:10 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Juergen Gross , Andrew Cooper Subject: Re: EFI's -mapbs option may cause Linux to panic() Message-ID: References: <60663f81-09cd-e46b-bb94-1afe50519086@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <60663f81-09cd-e46b-bb94-1afe50519086@suse.com> X-ClientProxiedBy: LO4P265CA0052.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::15) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SN4PR03MB6781:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b580b67-b308-4372-e6f9-08dacbe02f7c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7d1oLo8Q6hZjzXUnlPReYJuYgs+3rNPOJXiUwgeyjGUmkXOwjcF0K52SQsYvq9NH0Ag2LQ/o9nSBAiIqEbOM9N+OIIN0OnQIIPCRNqaSHLUNHl6wnUKWqSI32irJnVSedIyE0bWDkKd9kaYXgFxG95bWcI+s/XpVcStViMg9ouIsdeyEJQZyqY8+097Pfl1FeD0y011LqFv4+5QItIr3xSxGuR5BKl9GfP37gmtPBeW3ZLY3g8kz33naE96uQM0G6zIF7z5uO1I5q1cQ0PtNgYLqvMST7B9n7XO/qoG6S0LXDlIjFSZqcC8kkkpOs3gFyDnsVR8JK6Q0BkoOPWHG84dJ9Gh9wS0pbBF4JuFtXVbPk1ON9cE5XxsiqwWNZDEsnE1N8sPhonsgjJ5+bU5Wu9/t25DLvuWiwezjRlL9y2St1s/PwIhSNDSyi3CTfC/+WSEcG7pjyHa8qH4M8kbDqKwd71rK0MV7Y7J8TwQwgHaVGE+QSc9PdlQxKKDwtcSrmpfcRi3xmPEDYv9ZIwjyPgDrG3QNoGhGxLbs1dG9eJhBe5eVdK5otrMlgoK56rYOJwVdyvJvCt7a/04krmr8dlBDq9+d6inQK+7YspPGLQl/i35MukXiYeg7aTIFEDMIVUm4fOMz0MgD2k/lyO4agA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(396003)(376002)(346002)(366004)(39860400002)(451199015)(5660300002)(4326008)(9686003)(66476007)(66556008)(8676002)(41300700001)(66946007)(316002)(85182001)(6512007)(26005)(6916009)(54906003)(186003)(6506007)(8936002)(38100700002)(82960400001)(33716001)(83380400001)(2906002)(86362001)(6666004)(107886003)(6486002)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWdVOGtwZFN6UjJRS2FVaU1pY1FtUThkd2tpM05NNVhiR3cyWXlRTmZvZEFq?= =?utf-8?B?V0Nwc3VaRGc3QVFYOE9KR21rejNHSmxkWU43R09XTnU4eDJ1am53YUViVytM?= =?utf-8?B?Q1NEZ05IS0xrenRnUVZVTThwYUJkYlJhTG82N2pMcWI0azViUnlGcnBWeDVO?= =?utf-8?B?VC84NGlQNnAzUk9KMWNZT0h2UWdNOWw5eUFnWHFJU0E0TU54L0Rqc3p2VEhK?= =?utf-8?B?ZWdjL0NWWlRodUpPbkJNc2wvbmVpdmg0TnZONXNRZStBaDVPTVVQWGlXcDhM?= =?utf-8?B?c1JaRE1ySTZoaGQxZXpIUUo3MUpqTTg5OWRSS2dUUEN3VUppYktyajA2MmFq?= =?utf-8?B?dmh5MzY5aFBZYnZzc1FnRUhkMjFNU3lhaUI5TVJQb1RhMUZmMFd0aEJhS1JU?= =?utf-8?B?blJVWUpRRCtNYkxBcE1heGNoYVlwU1llWXhSWkZmWEpiZnk1enR3K29WQVN0?= =?utf-8?B?Y0NyNmNUSkd4enhtWk0zamcyK3JUUWFKQUJMdlhwc1FzRDQ0V20rbzZsS1pr?= =?utf-8?B?U25rdUp1a21LdkxpdjhpbXlWUmViT0xTQ05PaXlobzN0b2dvVGtZemdSOXBk?= =?utf-8?B?bEdjVUZteVlVanRlS2tQQm94M2RPNUpoQ2c5dW5OZHVPc0dtNmJIbnZvMUFS?= =?utf-8?B?OEMrT08xSGUvRiswTFZjQnQxdVNkekRWVW1IelM3ZXJ5bThpYi9kcmRTKzlW?= =?utf-8?B?MTU2UjZRVyswOHpiZC9uVUd5eHU3NTNTc2g3MTFXR0VtRzM5dVcxUGxCMDdX?= =?utf-8?B?Mm52TGtpeTAzMXRvT0tsU2dzMzBGUkZRTkczcDJMVFZBT2RTL2tzVEFCdXZI?= =?utf-8?B?MjhzQWZJOFg3THdCN1BVRUZZNEQrczdFNGtubUh5NGRtdTZ1bG1IdnMxeFMv?= =?utf-8?B?eVNyWU1TWUdDWkMzSGhIdzVRb1JBaEg0OUREU0VLc2k3V0hQazlwZXd4b2Zo?= =?utf-8?B?WEd0aWxSaVlrMGVNZ3dDbWxCTzB4UHNtRWNrbGg0VE1jMGk5WmtIQ1NGQkQw?= =?utf-8?B?U3hZUzVFRGlCSGo5ZFFidWlrYlo0cnQrVzJjV0swQnJVa21NUlY3RS8xa0Fy?= =?utf-8?B?NmpzQ1JRMDh3OWlyT3R6OWRaMDI3SXBaQ21wZmZHbHVtemtSQ05KQVNCSjFN?= =?utf-8?B?WTNscnVjRElqSkNYSyt4UkluQzRUWTZCWCtCR2pGYjR3U3FBMXczYVRrTFpU?= =?utf-8?B?ZDRYR0xPK3c1azRVcy9ad1FjK243aU1OSnkvSENGZmVJRFdiejFhQkI4em9z?= =?utf-8?B?RzJmMXZkaU41K0c2S2FrUGNzemg5MmFreFFxeHdiTmdxZWpoVnZCRHRscUFt?= =?utf-8?B?RjNFZmZkc2JCNFZhRUZ0S2VxUXBQRFZjNmZZVEZ4L0ZJZk5aclMwbkZhTTZh?= =?utf-8?B?WUlIWWZsUmFJN1gzRElsL3ZwK243aWt1WnJOdW5FdllFcU96eXZhc21GMFpX?= =?utf-8?B?WVVDdXBDRDFrQmJRMWJDWXZ1TnhHTjBsTmlRS3dGSjdFSVB6YlJnYk5hWTIx?= =?utf-8?B?cERKYSt0dnExS0x4alpjZjB2Z2JCNTJRQ25KRERoR1N0cGZsYTNXRW9DYnpz?= =?utf-8?B?Mkx4UlphVy9uTUlGeEJnUnpucnV6RllrT3dLUDN0MjUyQWxlUllzY2JsWDF4?= =?utf-8?B?RlloeGNqQW1RdHlwOUVCMFNPYmVtQVpjVmVOcER4NVlia3VlZDU2SUgzSkxI?= =?utf-8?B?bVJha08rR29zcVhKNFZWVng2ZlB3RnBXWnRMalNLTmZacVp0cHhrRUlhNEl3?= =?utf-8?B?bHRKSjZ1YkpMZ2NQQjV1YjF2alc5TjRITGo2dGRQSDBiNFl5TDlINUlVanVZ?= =?utf-8?B?T1NOOWhZa2IvUktSakFYUU4zOGlMQjBHK2pjeWs2YzlxTkpINzY1VTZKYmwy?= =?utf-8?B?WUVEcmd5WVdqOEJER3cvQkhjOUN3WTNuTUQ2N0NMZk53SDBrYnljc3JudENp?= =?utf-8?B?cmFpQkVZeGFsTXBYT29rV2MrWWZXSHRMbVlXMElUMVpReXVic3o5WlZnY3BO?= =?utf-8?B?VmtRS3VKOGFUbjM0QlZKRTcvRGNWRDY0LzIxbjFjQnhMUWE1TzNpQjFpb05W?= =?utf-8?B?VDdLOTd6dDlFQ1hNbVJvdVljMnhOMWFFNU9WUUZQWWRUUWk2U3o3RDN5Mmlv?= =?utf-8?Q?RRd2R6rv6dkhU7QV8hE43UjLE?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DKAxLgjPJbYWsa10CveSYLtbCgRQAqsCxtQQyVoVnPzcRsGIr5eslchPa1eG7oG+aY5sXbXdepdWNl2gAhj8cPHKwH6f2y13nPyQ9iTrppo4qSzCphUlKaaUtdLPhkIwbpRYYXMhjF9+Fut6YzK0oxINIlN7BEkoSjPvPj36pGEifF18gGvNQ91KTwAqOnX682cfoPMJJvYE8U51Kx75z16WI4eLSJHuaak7nmZ0c3qlYMhesN8StHjLWO4H2vb2qmKid7JiC2TzCwQQH8tzcWvvUUu02yMWTHZscxAOco9s17a3i2DEjL+hPw17Y5cRefgFbgRQ++fKTYp94I9+dRTlGeUrWYtQVMwRL1XQEC0YV17h1XKsCABZgRXG1YD21GzOnPDCIypOB1uh6Vj9ZED2AHdg31qMHhsk6nH+vi+17LZVbajFvyadECxZucrKYq5SpK/aCflVRpl7S+Xk6ozp8jqsLB2awfTIFxvbaWmZt0P841CIDtCYaXcxISX3o3xk5A0205E44N/5z5qgLG2cRDXnRL93qmOiRCBES7+l9UAH5q0PCfXSKVWIU5hy0IIyIi7Nyl9yVDNw4TUNhiFKiCLr0zt+wVHgukJnwhnsgcBBQKoz4OlyayzoKG+qoiKWTEuJynkE3+oEbsR+Nnzu9KP7CsO9Est1csDa8j8eeYlKc6tWAJvOjTxCfiKaQfV/CwNUrhhw5WzuTp39Nwdg8GCywKLpEI+aGem0TtqfInwvVrycB/WCPCJd/SkjGZLBDSX/VsMJbMmBR0ry9sPv21Dvs+qJd967YOJGW7DsqUNouOmA2CYvBKM3k8uMPlpLLQKYiPD+UnahZvgGbA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b580b67-b308-4372-e6f9-08dacbe02f7c X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 16:48:18.9569 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: flDbE6xhAwACwFLKcMiPv2nRR9ag+oyRDT4Utx6jjcJ5I64+T1p5GNnkaZFhg05uEa9YoMBg1rcSMt1z2r2WnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6781 On Mon, Nov 21, 2022 at 05:27:16PM +0100, Jan Beulich wrote: > Hello, > > on a system with these first two EFI memory map entries > > (XEN) 0000000000000-000000009dfff type=4 attr=000000000000000f > (XEN) 000000009e000-000000009ffff type=2 attr=000000000000000f > > i.e. except for 2 pages all space below 1M being BootServicesData, the > -mapbs option has the effect of marking reserved all that space. Then > Linux fails trying to allocate its lowmem trampoline (which really it > shouldn't need when running in PV mode), ultimately leading to > > panic("Real mode trampoline was not allocated"); > > in their init_real_mode(). > > While for PV I think it is clear that the easiest is to avoid > trampoline setup in the first place, iirc PVH Dom0 also tries to > mirror the host memory map to its own address space. Does PVH Linux > require a lowmem trampoline? Yes, it does AFAIK. I guess those two pages won't be enough for Linux boot trampoline requirements then. I assume native Linux is fine with this memory map because it reclaims the EfiBootServicesData region and that's enough. > While the two pages here are just enough for Xen's trampoline, I still > wonder whether we want to adjust -mapbs behavior. Since whatever we > might do leaves a risk of conflicting with true firmware (mis)use of > that space, the best I can think of right now would be another option > altering behavior (or providing altered behavior). Yet such an option > would likely need to be more fine-grained then than covering all of > the low Mb in one go. Which feels like both going too far and making > it awkward for people to figure out what value(s) to use ... > > Thoughts anyone? I'm unsure what to recommend. The mapbs option is a workaround for broken firmware, and it's not enabled by default, so we might be lucky and never find a system with a memory map like you describe that also requires mapbs in order to boot. Any native OS would also have problems booting in such system if it has any option similar to mapbs, so I don't see much solution. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Nov 21 16:48:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 16:48:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446796.702619 (Exim 4.92) (envelope-from ) id 1ox9yU-0007Kn-MQ; Mon, 21 Nov 2022 16:48:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446796.702619; Mon, 21 Nov 2022 16:48:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9yU-0007Kc-HJ; Mon, 21 Nov 2022 16:48:50 +0000 Received: by outflank-mailman (input) for mailman id 446796; Mon, 21 Nov 2022 16:48:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9yT-0007Is-A0; Mon, 21 Nov 2022 16:48:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9yT-00034F-8H; Mon, 21 Nov 2022 16:48:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ox9yS-0003i9-Q4; Mon, 21 Nov 2022 16:48:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ox9yS-0003ys-Pc; Mon, 21 Nov 2022 16:48:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=F3pU/glTPsxUM+Vr4ZF/Nzy/rPYEr5n7GUlFMGM880k=; b=P8jGVH2fwQ4mYcoeB8rG8vIWQA KeceHFT12Jr7Th1iU5uVEQAtaqKPIkl7othePFjLKQD27ZU1L7/UuVG1YQ50JmfrVWNaqp/cToZsr xaGr/9UlpWCa7ZT8lzv/I/aJZmI/mLXBFPBExOs6P1HkCsYLTAFrvZqn6M+JO1VFXjK8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174878: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Mon, 21 Nov 2022 16:48:48 +0000 flight 174878 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174878/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 44 days Failing since 173470 2022-10-08 06:21:34 Z 44 days 79 attempts Testing same since 174871 2022-11-21 00:40:59 Z 0 days 2 attempts ------------------------------------------------------------ 1802 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 171425 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Nov 21 17:01:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 17:01:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446815.702633 (Exim 4.92) (envelope-from ) id 1oxAAR-0001da-Lr; Mon, 21 Nov 2022 17:01:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446815.702633; Mon, 21 Nov 2022 17:01:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxAAR-0001dT-J3; Mon, 21 Nov 2022 17:01:11 +0000 Received: by outflank-mailman (input) for mailman id 446815; Mon, 21 Nov 2022 17:01:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxAAQ-0001d6-F2 for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 17:01:10 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2062d.outbound.protection.outlook.com [2a01:111:f400:fe16::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 15df6b23-69be-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 18:01:07 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7784.eurprd04.prod.outlook.com (2603:10a6:20b:2ae::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Mon, 21 Nov 2022 17:01:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.011; Mon, 21 Nov 2022 17:01:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15df6b23-69be-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UJk4AIyHxR26fJZBzOHWniB6uujp6lBb6HMzCvZq9fTyvcTp+FZ6UIEuSyuWK8IljdS0WAbLIHxlAW9b25Hl5QyF7DDOJUiqESGW3nIGLumkP8HFxS9SoeGrY0nCBwYM+Rdk48KFIvCg7VlmbjUpGUHsb98S19/P5eFdjC/kyrFx6knuF/wQI54QWbOrG+6zwUuOpfsxobtwSaNdJNbZgdmCx19/rXmle6LnasvgLt+CSPvix5DsEdQrkkCyFBUsEBqRv10scBJqQ2nvr18guMikNzNzcJ93Ad4NoCJlLeTOFb2yDWaCcl8kjI/2Piaatk6U6RvnLl/T3bFfA0D2ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EwSaJ69VqtlHaXJZo53ZeJUMPXoNBAWFGcHJKcXt8nc=; b=LuGUVoNA3OugqNrgZ1rrus9bMLIKsGbPhTEgFot+HTvbxLNI+CuQJTBg3vAkM2u7B+RLM8vz1K5OU6BoyJuF7+JqEtiCRoPoIr5wFWmOnV2QDuDOcVtccly942fKJGdS4pr96TFnCoSqqcGp7lyI84qHvrTegoHvmds/gnXianolZUrca5ARm8ASf1381Q8faXTLqTOdTFjyfTRFeNtzy4Ig5ITC3U3fQOtftbAsFDVISwij/+yEZlgaMnoonUbzwcMPnrFKLyitXaoSV/Cqr55MTgiTfSCx9r+Xkg296WYDrJdXbkxzDy4plQfWUmlgYC5cj+fcs+sKWvJoBT+kRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EwSaJ69VqtlHaXJZo53ZeJUMPXoNBAWFGcHJKcXt8nc=; b=hdX3wu/hDrPpBdCDWHLdU0xnsd1eZVvXgP1LjGA8XlqoWWtel6KX5abIyvnsYXu5psWc/w9fipD9zLpZ25Zz869XQzOWiwLJtJpWQ4zt7iUPvaVza3GBB2ZofTixCgLjWYANqtODBqv2LOC/JD+Z7lV0akqw9J9O0uLmNhIF+DKGsZKR0Cxg6E4JQGoo6VrRz1UGU6CkJPILBakHrR6ySfCtO6+UBO/4rkYdYADokQZrMgevsYwi1+q8NHzi5RSdKlmbVg17VBP/Vjh3PfDarsJgeRK39HMKJtJPesG04WkcHbeUxYLkNfhVu+75FjBYNmTaGWNt37E73EnoFPnCrw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <296f95d8-5506-c95d-1c14-915cbf3e4f30@suse.com> Date: Mon, 21 Nov 2022 18:01:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: EFI's -mapbs option may cause Linux to panic() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Juergen Gross , Andrew Cooper References: <60663f81-09cd-e46b-bb94-1afe50519086@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0038.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7784:EE_ X-MS-Office365-Filtering-Correlation-Id: 0aaecb1e-c195-45d7-f88c-08dacbe1f853 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2sd87gxsZmpG7bsFjh5BF7IxJBXcwvPF61JRejo/YSQEIq50UlSPsxy1j12jsRY70tVJ+BfgFVjeXVSPFYPBldBgXqYlTDSTJSjs+2+1z8KPIMwfa3/8kFbCbV4fJk6mXFghrTl8Q9vFOKn63XzWc9HRmsFqUgiZ2T7bjmhmyW8FjbHzN8BNotcOwSbuYFDRMlXD1kDYkqeyBAQFsURPG5ZpIWE4snGAXGuAz8Kw3xab7lauHm55GOUVwGimeb58INf96JR1MwwsGc/NaC593PH6JKy5UnE+D+w5ift9gK84fug8RQULIp26p2u+Ni4aC+Wf3R8frNEs2u0uUFZHDSbrhnZ5XrTnkNu9U8BOw+mK2otuPLU4qD8GoCmOD1GxFYQJvMLfihA1wajAC50Td+SFkBMQSgNgblnEsUatSsRMFSd4DrYkkl0HKoyXeKAItVCylB3vfpxqR0/pU9wG5cJuG594NrPvztlvBb/bWF2TFm+io2aDKywfqwBtW6GyovCOD8UQayfVcITy3T5qgWK5xLEZLa0z+8Ut/CzDcCN7+rFvsR2NvTBJWOvU7RFdQ6lsCmzUeoFzKOiUqKRMY/3x6JmT5J4Lg7zveNssS7d6XIhm3yH0bCkXV7lbHu2i5+Hq311cru+LW2ZjsMouqWSlBbMQfMNrDBWmOY/QMU1JcO2LIrqfl4jrbEiMEoPqp89AQgVFSss3K2YEPDySKvFY7pDW7UTMMtwrLo8x+DM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(366004)(39860400002)(396003)(136003)(451199015)(31686004)(41300700001)(5660300002)(8936002)(54906003)(316002)(6916009)(66899015)(66946007)(4326008)(66556008)(66476007)(8676002)(6486002)(83380400001)(31696002)(6506007)(478600001)(86362001)(36756003)(2906002)(26005)(6512007)(2616005)(186003)(53546011)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGozOWZvMDJJNk02WU13SHFIQ2NGOWtERDBoVlRWR0R3dzZXaXgvNm1YVC8v?= =?utf-8?B?Q0hIZ2cvdVB1a2FDeTNKTlkreDBPSmoreXl6dUhURVA3VHFzbmhHclliTVBC?= =?utf-8?B?OTFScElYSGovczRDTTdKdG0xTVl2dVJYOEEwVU5VT2dMcWV1dWs4dW5ZU0NQ?= =?utf-8?B?MS9UMHdPMUJtcENLbE9Ud3BTbFB6TzN6ZUk1eFJDNEd5akVzWmtCQjNmWjVH?= =?utf-8?B?ZU5FeEdjME9oVHdaT1lqaWU0ZXpyV3JXcjdDZWcwUHU3VFpVbFpFYzVXaUZN?= =?utf-8?B?b2hVV0cra05nbDVTUlUrM0FJUnBOOHJlTUVENkhoUzRVZ3NWL1JRY0Y4bkxw?= =?utf-8?B?TklKZHFCbFZvei9vNVNyNE9mNzMwMWF4dGJrbjk0WFlxTlpza01QUitpK1M2?= =?utf-8?B?MmJZVnExWXBIcy9rOTlzcmE4Y0tXb3lMWkIrVzhEaWpuZkw5dzlacVJ6ZWZS?= =?utf-8?B?TUtzcmdia0srMFIyU0YyV20xWS9KYlV1U1dDbGlYb21wSUhweGFCM3plUFNL?= =?utf-8?B?TlhFNUlXSkswU2o1aU1FMXVKNUpjd2FvR0hwMG1SMVRYRWdGQ21jd3dsejJR?= =?utf-8?B?ekpkSkJlREFoNkkvczduZHIyWEM4V3pHTy9RRGhxUXdXZHRxTkxzcWRlaG10?= =?utf-8?B?cUdYWkJlN2Eva01nTG9IZEs3cnV1ZTE2MnVnVVpGclRCaDhYZ1U0WUFJTjBq?= =?utf-8?B?MUFWQ0pXQStZZUtzYUNKY1JrcSsxcE5aYlgrdmVNSGNDZjFXN21KdEZtcllT?= =?utf-8?B?a0VvaFJWeFljYldEcU55WlNVTXB2RzRwT21yQlIybnp2Tk94aVlHNllOOUYx?= =?utf-8?B?UldZS1VJWDduWFJid3haUmFTMEtkc0JmNGE0dkJ4aS95TDBhU1IwektFeVpM?= =?utf-8?B?cmJ6U0lHVlRsdFVnZnpLV29vVjVRMEFjVzY4U3FhcDloVEVrYkF0RW1ZRGRp?= =?utf-8?B?cDI0b2ZueE0wY2VsemQ0V1Q1RnA0MzRFUkZzWlZ2MW1BWG1MQzROTzZsbzFN?= =?utf-8?B?VnFQK3lIME0xeVV6OXJBWUxuanFUM1ljZ2R3V29nZFk4dUphQmdUd0x6WUxi?= =?utf-8?B?TTJJYXRuWXVPUm5KeE02TDJmeGRKZDlwM2NTcFRhY2l4aUs5Y21TZFRtbmdX?= =?utf-8?B?MUhVZCtKWTAza2JWZHlGcjYrdzk5VTVSSGNGUDFmbWxkcDJHa2QwbVpGWjVN?= =?utf-8?B?SnFZYkNqUFRiYlcxZUw0TXMways5NStLRnhqc1NSc0NxS2MrL0VxM1o3aXA0?= =?utf-8?B?RytONmZyS3NtMm4wQk5XK2dodVQvMkhZNVAyWFpuUUR3aUR2MWFpa2t4TVcv?= =?utf-8?B?K2tXaGZzWjAxSnByYUdvUEtxSStpeXgxdkRZbUFxMmtJN0F3eFVhbEhXbnFj?= =?utf-8?B?RnZhQlZUcmIxc2J0MFRlc1VkWlExKy9HbG15WW1jWmlCdHdhMG53eWtoWWFz?= =?utf-8?B?L0tNVVRCakdlRmpVdmRkazlhVE5QSzM2eHhMU0dTNVBxQmxDVzl0TjdVQU5n?= =?utf-8?B?dDdMZEFiMlRNeTFOSjk4eE5hYTdjWk56RGZoaFYvV1pidGh6QUN6QkRPczNN?= =?utf-8?B?WDdhdDJnQ3JGS3RNRU1WREVRdndvODRQYWxTakVvY1liOG83K1dybHh5QU1K?= =?utf-8?B?UFo0WTZQb3NTQzh4ZFM5MlBJZVdXa2o0emFQVjFDMXEvcjQ4Z0NBc25PeURl?= =?utf-8?B?alB3cDNJS3hqQ09BNWpWeHBwZEQ3ZDArUldDVHRQVHZnWXU3MmY4bXJsOHNi?= =?utf-8?B?TXFJUmNKWUljV1dyNFg4TFJEUnZaNSsvUFNSaTNkUkxVUXFhd0FiejdDdTRQ?= =?utf-8?B?ZUlNUFNpQ2o1UlJFTGFGczRGbzZBcVRnV1A0Z2pRQVczZUpRV25oUTFzZkx2?= =?utf-8?B?VTVqRnk4Q1VIYmZrNlhtdGgwYmZhQVhxWEoxVlI5RFdSc2QvZkFpMFYyc1ht?= =?utf-8?B?SDl4Y3RHRVMyeEtyM0VNcDFUQXZjL3ZkRjV6Zzc5NGxRN096cWVoYnBIbEsx?= =?utf-8?B?dXQwaFcxNXVaNDAvUTBDSG93QXBhUFZmaUZkSks1YjdzNkhVZmU3RkJNVXhi?= =?utf-8?B?RjJnbGNobnRGNVdyT2JYTE1VWnFlTGR5SDc5WXdyRkhpVy9ON2tlck4rOXpi?= =?utf-8?Q?pGtuciVmHUydiItW+qx3Od/Yv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0aaecb1e-c195-45d7-f88c-08dacbe1f853 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 17:01:02.1772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V2pAcVZotcdGxPQrKHCrHsoWJPFXeJti6NlWtiQ90f4PnOT6aGo4so4yRL2PMC8n8iwTTontXEuE9lvFiZs33Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7784 On 21.11.2022 17:48, Roger Pau Monné wrote: > On Mon, Nov 21, 2022 at 05:27:16PM +0100, Jan Beulich wrote: >> Hello, >> >> on a system with these first two EFI memory map entries >> >> (XEN) 0000000000000-000000009dfff type=4 attr=000000000000000f >> (XEN) 000000009e000-000000009ffff type=2 attr=000000000000000f >> >> i.e. except for 2 pages all space below 1M being BootServicesData, the >> -mapbs option has the effect of marking reserved all that space. Then >> Linux fails trying to allocate its lowmem trampoline (which really it >> shouldn't need when running in PV mode), ultimately leading to >> >> panic("Real mode trampoline was not allocated"); >> >> in their init_real_mode(). >> >> While for PV I think it is clear that the easiest is to avoid >> trampoline setup in the first place, iirc PVH Dom0 also tries to >> mirror the host memory map to its own address space. Does PVH Linux >> require a lowmem trampoline? > > Yes, it does AFAIK. I guess those two pages won't be enough for > Linux boot trampoline requirements then. > > I assume native Linux is fine with this memory map because it reclaims > the EfiBootServicesData region and that's enough. That's my understanding as well. >> While the two pages here are just enough for Xen's trampoline, I still >> wonder whether we want to adjust -mapbs behavior. Since whatever we >> might do leaves a risk of conflicting with true firmware (mis)use of >> that space, the best I can think of right now would be another option >> altering behavior (or providing altered behavior). Yet such an option >> would likely need to be more fine-grained then than covering all of >> the low Mb in one go. Which feels like both going too far and making >> it awkward for people to figure out what value(s) to use ... >> >> Thoughts anyone? > > I'm unsure what to recommend. The mapbs option is a workaround for > broken firmware, and it's not enabled by default, so we might be lucky > and never find a system with a memory map like you describe that also > requires mapbs in order to boot. Guess how we've learned of the issue: Systems may boot fine without -mapbs, but they may fail to reboot because of that (in)famous issue of firmware writers not properly separating boot services code paths from runtime services ones. And there we're dealing with a system where I suspect this to be the case, just that - unlike in earlier similar cases - there's no "clean" crash proving the issue (the system simply hangs). Hence my request that they use -mapbs to try to figure out. And yes, "reboot=acpi" helps there, but they insist on knowing what component is to blame. Jan > Any native OS would also have problems booting in such system if it > has any option similar to mapbs, so I don't see much solution. > > Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Nov 21 17:44:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 17:44:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446836.702644 (Exim 4.92) (envelope-from ) id 1oxAqF-0006Et-0x; Mon, 21 Nov 2022 17:44:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446836.702644; Mon, 21 Nov 2022 17:44:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxAqE-0006Em-UF; Mon, 21 Nov 2022 17:44:22 +0000 Received: by outflank-mailman (input) for mailman id 446836; Mon, 21 Nov 2022 17:44:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxAqD-0006Eg-BB for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 17:44:21 +0000 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [2a00:1450:4864:20::436]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 20aedae8-69c4-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 18:44:20 +0100 (CET) Received: by mail-wr1-x436.google.com with SMTP id z4so6381418wrr.3 for ; Mon, 21 Nov 2022 09:44:20 -0800 (PST) Received: from [10.95.165.146] (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id i3-20020a1c5403000000b003cfc02ab8basm19695480wmb.33.2022.11.21.09.44.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 09:44:19 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20aedae8-69c4-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=6CZHdh0V/+SYwu9a7gToiPM7S/ZgBybSFroCH/WhgYI=; b=o9Y0LGoyN02A8le6Z2d/o3VW+fZe0Oc2tiRUnJSX8ur3/OZLm5wG5zqid41Yq+GjM2 u6EHb15dvRjJKAp5dR2eZk/CUSW/mUq+714z1YTeNkZxLOItddi9V5AKDNPStZAOIQfe uSkCJXY1fjRIAkfR2tfyNWrlrWDQd/fFNpfWtiJq4KGTUxXAzZ/Czty8Csqyo1aG5ZOE X4CC2eY+C0d38R70NyN7ofeu+VK9L1aqqdnhZu82/1hVF+Xsy0Igp/1u1w1njjaSbE6+ OKQB++nu2zE0GJen3CbdpyYMcIeTDNsXM0YPQ/GhI5pv/aNRzJvCXLihbWRtTI8nPZl4 eMhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6CZHdh0V/+SYwu9a7gToiPM7S/ZgBybSFroCH/WhgYI=; b=OvCi3F8tYc4hBjr7iV6DDm+IZOztiXowFWiW1F+4lKR6T0J/qzi3+wY5OSAo3rE2jd oj0w0ld/rCikFCWrFtcvohdcR1hZU6QiTTvqeKde2m5V3P7a1xISMYO0fkIPsL9NiMLV cwc+vR+G/KhP/ilqKOrZyOwoNGBhdwIqWcpAZ+yDW9akn02clh8J5duHeYmkHX9wSb0l DuO+cL4BDMOsi8EMD3zMlJiTx/lcq6amcBtHsFxf9i8bCZjkJVHldnYV7iD9GlR2qe+g Iirw/MV1S3/Zw8luhQBgBc+6UM4IpK/g/N9BBLgSwS+tXcn5Ity50K83txltw9MK1TNv LQUQ== X-Gm-Message-State: ANoB5plUkl0+nwTkUmFcIcPGhF7bcztiy0cpYxgnilP3Kux/sBFdzAT8 1d+jw+2BsrjEDvfJhv2qcc8= X-Google-Smtp-Source: AA0mqf6mz6tckF37iW+VhPcyLTEn0ltS+FrrSued1Msttt5q/vY7ELJWB/eItUl4u1LBs7ZmQXoDQQ== X-Received: by 2002:adf:a546:0:b0:234:d3ce:6b32 with SMTP id j6-20020adfa546000000b00234d3ce6b32mr11789191wrb.718.1669052659733; Mon, 21 Nov 2022 09:44:19 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <8b5f085c-bc81-0312-294a-b224f23387fa@xen.org> Date: Mon, 21 Nov 2022 17:44:18 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/Viridian: don't mark IRQ vectors as pending when vLAPIC is disabled To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Content-Language: en-US Organization: Xen Project In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/11/2022 12:13, Jan Beulich wrote: > In software-disabled state an LAPIC does not accept any interrupt > requests and hence no IRR bit would newly become set while in this > state. As a result it is also wrong for us to mark Viridian IPI or timer > vectors as having a pending request when the vLAPIC is in this state. > Such interrupts are simply lost. > > Introduce a local variable in send_ipi() to help readability. > > Fixes: fda96b7382ea ("viridian: add implementation of the HvSendSyntheticClusterIpi hypercall") > Fixes: 26fba3c85571 ("viridian: add implementation of synthetic timers") > Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Mon Nov 21 18:49:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 18:49:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446848.702661 (Exim 4.92) (envelope-from ) id 1oxBrU-0004Yq-VB; Mon, 21 Nov 2022 18:49:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446848.702661; Mon, 21 Nov 2022 18:49:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxBrU-0004Yj-Qi; Mon, 21 Nov 2022 18:49:44 +0000 Received: by outflank-mailman (input) for mailman id 446848; Mon, 21 Nov 2022 18:49:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxBrR-0004Yc-Sn for xen-devel@lists.xenproject.org; Mon, 21 Nov 2022 18:49:42 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3f233566-69cd-11ed-8fd2-01056ac49cbb; Mon, 21 Nov 2022 19:49:37 +0100 (CET) Received: by mail-ej1-x62e.google.com with SMTP id ud5so30640328ejc.4 for ; Mon, 21 Nov 2022 10:49:37 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f233566-69cd-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ke3DBYdzwNX9X3SC3XaBS7LOcZvE1sBnQryOqOw3NRU=; b=qZfLQ862GvcHha+Szhmo/kMAF+M3lLLfjIQYKHZ/FAtwb+AhC8hIyb0JsBWH6PSaIC 4eBPGI6FGa/H2tH5Jq/dAZM5akEtK919XbWWcVq8FQKg/56D1btqGt9P3hAC0Bb9vIUk gzR9wRvGhjCfz/ZWZ75Hd2O6dOFU1fPVyiH5E7il2y8fy1zrSjAXb/daB6npXyQuF78b /Ga4JV+0azCO8VOZ7Ducu+oxIrndpUj4U3OlpNFofnc9zcDj7dGX4UIn6B30jx4EHbH0 du61dUhbuSiwrvvQluE9mtH7VvJVdM63jjqs1CqF0czqUgsSO/NlWu8i8SD+Eny1rFl1 IxQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ke3DBYdzwNX9X3SC3XaBS7LOcZvE1sBnQryOqOw3NRU=; b=TKmqC5ld+5GagW0aybhNFEX8GLGKbuKqdeuU5vtqrRdUDdjydiTVRaDG+w6dlo36RB h+jwe9AQz4MEVv8M2zV6EK5QIMUYvlr91ymPYn8YoO285LyHWOJKTHW6JVAPchbR9T9D Nq+UXDxeC1rXtsZ1l0gNJ1wjI0InuoGUjhBAzxpEvUGmGmbFin5w/VqNrwtti9in9fMz fecYwzqXqQADx6QCaORQrVNKgyqH8vY+nsE4XwzhQxhsQ6eE9pD9WWp/oFzfgGB+kSuj rplRG8Cd4eC5cHH0HOaotGL6Ejf2GSuOKZz0Fhgd3tWRJiYLWXWCYXUBBd0Izwj+XzIH 5xqA== X-Gm-Message-State: ANoB5pluz3Um4hQ4q397OeMrUWqD3+I6pBHfo4TYJLvxeeA/qcHqsSU0 //4vI+t01dCNVrRaaVXYdYFBf67HirWhexVnWZ63mZpTEZ0= X-Google-Smtp-Source: AA0mqf6vimyNhAqWEBJZLSyR/Mx6BDOSJTbVBQPUHMZyBoTR93JPFuKXT5U80ZQLhQ2Ccj6sCQJExvKPaUFsBjxOTMQ= X-Received: by 2002:a17:907:3907:b0:7ae:37a8:9b5c with SMTP id so7-20020a170907390700b007ae37a89b5cmr1482502ejc.241.1669056576054; Mon, 21 Nov 2022 10:49:36 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Vipul Suneja Date: Tue, 22 Nov 2022 00:19:19 +0530 Message-ID: Subject: Re: Porting Xen in raspberry pi4B To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, oleksandr_andrushchenko@epam.com, oleksandr_tyshchenko@epam.com, jgross@suse.com, boris.ostrovsky@oracle.com, Bertrand.Marquis@arm.com Content-Type: multipart/mixed; boundary="00000000000054191f05edff84e8" --00000000000054191f05edff84e8 Content-Type: multipart/alternative; boundary="00000000000054191d05edff84e6" --00000000000054191d05edff84e6 Content-Type: text/plain; charset="UTF-8" Hi Stefano, Thanks for the support! Looks like I have tried all the combinations & possible ways to get display up but failed. Is there any document or pdf for porting xen on raspberrypi4. I could find lot's of links telling the same but couldn't see any official user guide or document from the xen community on the same. If there is something to refer to please share with me. I am attaching the kernel configuration file also, just take a look if i have missed anything. Any other suggestions or input from your end could be really helpful? Regards, Vipul Kumar On Fri, Nov 11, 2022 at 6:40 AM Stefano Stabellini wrote: > Hi Vipul, > > Sorry for the late reply. From the earlier logs that you sent, it looks > like everything should be working correctly. Specifically: > > vfb = "" > 1 = "" > 0 = "" > frontend = "/local/domain/1/device/vfb/0" > frontend-id = "1" > online = "1" > state = "4" > vnc = "1" > vnclisten = "127.0.0.1" > vncdisplay = "0" > vncunused = "1" > sdl = "0" > opengl = "0" > feature-resize = "1" > hotplug-status = "connected" > request-update = "1" > > state "4" means "connected". So I would expect that you should be able > to connect to the vnc server using vncviewer. You might not see anything > (black screen) but you should definitely be able to connect. > > I wouldn't try to launch x11 in the guest just yet. fbcon in Linux is > enough to render something on the screen. You should be able to see the > Linux text-based console rendered graphically, connecting to it via vnc. > > Sorry for the basic question, but have you tried all the following? > > vncviewer 127.0.0.1:0 > vncviewer 127.0.0.1:1 > vncviewer 127.0.0.1:2 > vncviewer 127.0.0.1:5900 > vncviewer 127.0.0.1:5901 > vncviewer 127.0.0.1:5902 > > Given that from the xenstore-ls logs everything seems to work correctly > I am not sure what else to suggest. You might have to add printf to QEMU > ui/vnc.c and hw/display/xenfb.c to see what is going wrong. > > Cheers, > > Stefano > > > On Mon, 7 Nov 2022, Vipul Suneja wrote: > > Hi Stefano, > > Thanks! > > > > Any input further on "xenstore-ls" logs? > > > > I am trying to run the x0vncserver & x11vnc server manually on guest > machine(xen_guest_image_minimal) image but it's failing with the below > > error. > > > > root@raspberrypi4-64:/usr/bin# x0vncserver > > x0vncserver: unable to open display "" > > root@raspberrypi4-64:/usr/bin# > > root@raspberrypi4-64:/usr/bin# x11vnc > > ############################################################### > > #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@# > > #@ @# > > #@ ** WARNING ** WARNING ** WARNING ** WARNING ** @# > > #@ @# > > #@ YOU ARE RUNNING X11VNC WITHOUT A PASSWORD!! @# > > #@ @# > > #@ This means anyone with network access to this computer @# > > #@ may be able to view and control your desktop. @# > > #@ @# > > #@ >>> If you did not mean to do this Press CTRL-C now!! <<< @# > > #@ @# > > #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@# > > #@ @# > > #@ You can create an x11vnc password file by running: @# > > #@ @# > > #@ x11vnc -storepasswd password /path/to/passfile @# > > #@ or x11vnc -storepasswd /path/to/passfile @# > > #@ or x11vnc -storepasswd @# > > #@ @# > > #@ (the last one will use ~/.vnc/passwd) @# > > #@ @# > > #@ and then starting x11vnc via: @# > > #@ @# > > #@ x11vnc -rfbauth /path/to/passfile @# > > #@ @# > > #@ an existing ~/.vnc/passwd file from another VNC @# > > #@ application will work fine too. @# > > #@ @# > > #@ You can also use the -passwdfile or -passwd options. @# > > #@ (note -passwd is unsafe if local users are not trusted) @# > > #@ @# > > #@ Make sure any -rfbauth and -passwdfile password files @# > > #@ cannot be read by untrusted users. @# > > #@ @# > > #@ Use x11vnc -usepw to automatically use your @# > > #@ ~/.vnc/passwd or ~/.vnc/passwdfile password files. @# > > #@ (and prompt you to create ~/.vnc/passwd if neither @# > > #@ file exists.) Under -usepw, x11vnc will exit if it @# > > #@ cannot find a password to use. @# > > #@ @# > > #@ @# > > #@ Even with a password, the subsequent VNC traffic is @# > > #@ sent in the clear. Consider tunnelling via ssh(1): @# > > #@ @# > > #@ http://www.karlrunge.com/x11vnc/#tunnelling @# > > #@ @# > > #@ Or using the x11vnc SSL options: -ssl and -stunnel @# > > #@ @# > > #@ Please Read the documentation for more info about @# > > #@ passwords, security, and encryption. @# > > #@ @# > > #@ http://www.karlrunge.com/x11vnc/faq.html#faq-passwd @# > > #@ @# > > #@ To disable this warning use the -nopw option, or put @# > > #@ 'nopw' on a line in your ~/.x11vncrc file. @# > > #@ @# > > #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@# > > ############################################################### > > 09/03/2018 12:58:41 x11vnc version: 0.9.16 lastmod: 2019-01-05 pid: 424 > > 09/03/2018 12:58:41 XOpenDisplay("") failed. > > 09/03/2018 12:58:41 Trying again with XAUTHLOCALHOSTNAME=localhost ... > > 09/03/2018 12:58:41 > > 09/03/2018 12:58:41 *** XOpenDisplay failed. No -display or DISPLAY. > > 09/03/2018 12:58:41 *** Trying ":0" in 4 seconds. Press Ctrl-C to abort. > > 09/03/2018 12:58:41 *** 1 2 3 4 > > 09/03/2018 12:58:45 XOpenDisplay(":0") failed. > > 09/03/2018 12:58:45 Trying again with XAUTHLOCALHOSTNAME=localhost ... > > 09/03/2018 12:58:45 XOpenDisplay(":0") failed. > > 09/03/2018 12:58:45 Trying again with unset XAUTHLOCALHOSTNAME ... > > 09/03/2018 12:58:45 > > > > 09/03/2018 12:58:45 *************************************** > > 09/03/2018 12:58:45 *** XOpenDisplay failed (:0) > > > > *** x11vnc was unable to open the X DISPLAY: ":0", it cannot continue. > > *** There may be "Xlib:" error messages above with details about the > failure. > > > > Some tips and guidelines: > > > > ** An X server (the one you wish to view) must be running before x11vnc > is > > started: x11vnc does not start the X server. (however, see the > -create > > option if that is what you really want). > > > > ** You must use -display , -OR- set and export your $DISPLAY > > environment variable to refer to the display of the desired X server. > > - Usually the display is simply ":0" (in fact x11vnc uses this if you > forget > > to specify it), but in some multi-user situations it could be ":1", > ":2", > > or even ":137". Ask your administrator or a guru if you are having > > difficulty determining what your X DISPLAY is. > > > > ** Next, you need to have sufficient permissions (Xauthority) > > to connect to the X DISPLAY. Here are some Tips: > > > > - Often, you just need to run x11vnc as the user logged into the X > session. > > So make sure to be that user when you type x11vnc. > > - Being root is usually not enough because the incorrect > MIT-MAGIC-COOKIE > > file may be accessed. The cookie file contains the secret key that > > allows x11vnc to connect to the desired X DISPLAY. > > - You can explicitly indicate which MIT-MAGIC-COOKIE file should be used > > by the -auth option, e.g.: > > x11vnc -auth /home/someuser/.Xauthority -display :0 > > x11vnc -auth /tmp/.gdmzndVlR -display :0 > > you must have read permission for the auth file. > > See also '-auth guess' and '-findauth' discussed below. > > > > ** If NO ONE is logged into an X session yet, but there is a greeter > login > > program like "gdm", "kdm", "xdm", or "dtlogin" running, you will need > > to find and use the raw display manager MIT-MAGIC-COOKIE file. > > Some examples for various display managers: > > > > gdm: -auth /var/gdm/:0.Xauth > > -auth /var/lib/gdm/:0.Xauth > > kdm: -auth /var/lib/kdm/A:0-crWk72 > > -auth /var/run/xauth/A:0-crWk72 > > xdm: -auth /var/lib/xdm/authdir/authfiles/A:0-XQvaJk > > dtlogin: -auth /var/dt/A:0-UgaaXa > > > > Sometimes the command "ps wwwwaux | grep auth" can reveal the file > location. > > > > Starting with x11vnc 0.9.9 you can have it try to guess by using: > > > > -auth guess > > > > (see also the x11vnc -findauth option.) > > > > Only root will have read permission for the file, and so x11vnc must > be run > > as root (or copy it). The random characters in the filenames will of > course > > change and the directory the cookie file resides in is system > dependent. > > > > See also: http://www.karlrunge.com/x11vnc/faq.html > > > > Regards, > > Vipul Kumar > > > > On Thu, Nov 3, 2022 at 10:27 PM Vipul Suneja > wrote: > > Hi Stefano, > > Thanks! > > > > I used xen-guest-image-minimal(simple console based image) as a guest > with fbcon & fbdev enabled in kernel configurations but still > > the same error can't open the display. > > below are the outcome of "xenstore-ls": > > > > root@raspberrypi4-64:~/guest1# xenstore-ls > > tool = "" > > xenstored = "" > > local = "" > > domain = "" > > 0 = "" > > control = "" > > feature-poweroff = "1" > > feature-reboot = "1" > > domid = "0" > > name = "Domain-0" > > device-model = "" > > 0 = "" > > backends = "" > > console = "" > > vkbd = "" > > vfb = "" > > qnic = "" > > state = "running" > > 1 = "" > > backends = "" > > console = "" > > vkbd = "" > > vfb = "" > > qnic = "" > > state = "running" > > backend = "" > > vbd = "" > > 1 = "" > > 51712 = "" > > frontend = "/local/domain/1/device/vbd/51712" > > params = > "/home/root/guest2/xen-guest-image-minimal-raspberrypi4-64.ext3" > > script = "/etc/xen/scripts/block" > > frontend-id = "1" > > online = "1" > > removable = "0" > > bootable = "1" > > state = "4" > > dev = "xvda" > > type = "phy" > > mode = "w" > > device-type = "disk" > > discard-enable = "1" > > feature-max-indirect-segments = "256" > > multi-queue-max-queues = "4" > > max-ring-page-order = "4" > > node = "/dev/loop0" > > physical-device = "7:0" > > physical-device-path = "/dev/loop0" > > hotplug-status = "connected" > > feature-flush-cache = "1" > > discard-granularity = "4096" > > discard-alignment = "0" > > discard-secure = "0" > > feature-discard = "1" > > feature-barrier = "1" > > feature-persistent = "1" > > sectors = "1794048" > > info = "0" > > sector-size = "512" > > physical-sector-size = "512" > > vfb = "" > > 1 = "" > > 0 = "" > > frontend = "/local/domain/1/device/vfb/0" > > frontend-id = "1" > > online = "1" > > state = "4" > > vnc = "1" > > vnclisten = "127.0.0.1" > > vncdisplay = "0" > > vncunused = "1" > > sdl = "0" > > opengl = "0" > > feature-resize = "1" > > hotplug-status = "connected" > > request-update = "1" > > vkbd = "" > > 1 = "" > > 0 = "" > > frontend = "/local/domain/1/device/vkbd/0" > > frontend-id = "1" > > online = "1" > > state = "4" > > feature-abs-pointer = "1" > > feature-raw-pointer = "1" > > hotplug-status = "connected" > > console = "" > > 1 = "" > > 0 = "" > > frontend = "/local/domain/1/console" > > frontend-id = "1" > > online = "1" > > state = "1" > > protocol = "vt100" > > vif = "" > > 1 = "" > > 0 = "" > > frontend = "/local/domain/1/device/vif/0" > > frontend-id = "1" > > online = "1" > > state = "4" > > script = "/etc/xen/scripts/vif-bridge" > > mac = "e4:5f:01:cd:7b:dd" > > bridge = "xenbr0" > > handle = "0" > > type = "vif" > > hotplug-status = "connected" > > feature-sg = "1" > > feature-gso-tcpv4 = "1" > > feature-gso-tcpv6 = "1" > > feature-ipv6-csum-offload = "1" > > feature-rx-copy = "1" > > feature-xdp-headroom = "1" > > feature-rx-flip = "0" > > feature-multicast-control = "1" > > feature-dynamic-multicast-control = "1" > > feature-split-event-channels = "1" > > multi-queue-max-queues = "4" > > feature-ctrl-ring = "1" > > 1 = "" > > vm = "/vm/d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f" > > name = "guest2" > > cpu = "" > > 0 = "" > > availability = "online" > > 1 = "" > > availability = "online" > > memory = "" > > static-max = "2097152" > > target = "2097152" > > videoram = "0" > > device = "" > > suspend = "" > > event-channel = "" > > vbd = "" > > 51712 = "" > > backend = "/local/domain/0/backend/vbd/1/51712" > > backend-id = "0" > > state = "4" > > virtual-device = "51712" > > device-type = "disk" > > multi-queue-num-queues = "2" > > queue-0 = "" > > ring-ref = "8" > > event-channel = "4" > > queue-1 = "" > > ring-ref = "9" > > event-channel = "5" > > protocol = "arm-abi" > > feature-persistent = "1" > > vfb = "" > > 0 = "" > > backend = "/local/domain/0/backend/vfb/1/0" > > backend-id = "0" > > state = "4" > > page-ref = "275022" > > event-channel = "3" > > protocol = "arm-abi" > > feature-update = "1" > > vkbd = "" > > 0 = "" > > backend = "/local/domain/0/backend/vkbd/1/0" > > backend-id = "0" > > state = "4" > > request-abs-pointer = "1" > > page-ref = "275322" > > page-gref = "1284" > > event-channel = "10" > > vif = "" > > 0 = "" > > backend = "/local/domain/0/backend/vif/1/0" > > backend-id = "0" > > state = "4" > > handle = "0" > > mac = "e4:5f:01:cd:7b:dd" > > mtu = "1500" > > xdp-headroom = "0" > > multi-queue-num-queues = "2" > > queue-0 = "" > > tx-ring-ref = "1280" > > rx-ring-ref = "1281" > > event-channel-tx = "6" > > event-channel-rx = "7" > > queue-1 = "" > > tx-ring-ref = "1282" > > rx-ring-ref = "1283" > > event-channel-tx = "8" > > event-channel-rx = "9" > > request-rx-copy = "1" > > feature-rx-notify = "1" > > feature-sg = "1" > > feature-gso-tcpv4 = "1" > > feature-gso-tcpv6 = "1" > > feature-ipv6-csum-offload = "1" > > control = "" > > shutdown = "" > > feature-poweroff = "1" > > feature-reboot = "1" > > feature-suspend = "" > > sysrq = "" > > platform-feature-multiprocessor-suspend = "1" > > platform-feature-xs_reset_watches = "1" > > data = "" > > drivers = "" > > feature = "" > > attr = "" > > error = "" > > domid = "1" > > store = "" > > port = "1" > > ring-ref = "233473" > > console = "" > > backend = "/local/domain/0/backend/console/1/0" > > backend-id = "0" > > limit = "1048576" > > type = "xenconsoled" > > output = "pty" > > tty = "/dev/pts/1" > > port = "2" > > ring-ref = "233472" > > vnc-listen = "127.0.0.1" > > vnc-port = "5900" > > image = "" > > device-model-pid = "788" > > vm = "" > > d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f = "" > > name = "guest2" > > uuid = "d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f" > > start_time = "1520600274.27" > > libxl = "" > > 1 = "" > > device = "" > > vbd = "" > > 51712 = "" > > frontend = "/local/domain/1/device/vbd/51712" > > backend = "/local/domain/0/backend/vbd/1/51712" > > params = > "/home/root/guest2/xen-guest-image-minimal-raspberrypi4-64.ext3" > > script = "/etc/xen/scripts/block" > > frontend-id = "1" > > online = "1" > > removable = "0" > > bootable = "1" > > state = "1" > > dev = "xvda" > > type = "phy" > > mode = "w" > > device-type = "disk" > > discard-enable = "1" > > vfb = "" > > 0 = "" > > frontend = "/local/domain/1/device/vfb/0" > > backend = "/local/domain/0/backend/vfb/1/0" > > frontend-id = "1" > > online = "1" > > state = "1" > > vnc = "1" > > vnclisten = "127.0.0.1" > > vncdisplay = "0" > > vncunused = "1" > > sdl = "0" > > opengl = "0" > > vkbd = "" > > 0 = "" > > frontend = "/local/domain/1/device/vkbd/0" > > backend = "/local/domain/0/backend/vkbd/1/0" > > frontend-id = "1" > > online = "1" > > state = "1" > > console = "" > > 0 = "" > > frontend = "/local/domain/1/console" > > backend = "/local/domain/0/backend/console/1/0" > > frontend-id = "1" > > online = "1" > > state = "1" > > protocol = "vt100" > > vif = "" > > 0 = "" > > frontend = "/local/domain/1/device/vif/0" > > backend = "/local/domain/0/backend/vif/1/0" > > frontend-id = "1" > > online = "1" > > state = "1" > > script = "/etc/xen/scripts/vif-bridge" > > mac = "e4:5f:01:cd:7b:dd" > > bridge = "xenbr0" > > handle = "0" > > type = "vif" > > hotplug-status = "" > > type = "pvh" > > dm-version = "qemu_xen" > > root@raspberrypi4-64:~/guest1# > > > > Any input as per above? Looking forward to hearing from you. > > > > Regards, > > Vipul Kumar > > > > On Wed, Oct 26, 2022 at 5:21 AM Stefano Stabellini < > sstabellini@kernel.org> wrote: > > Hi Vipul, > > > > If you look at the QEMU logs, it says: > > > > VNC server running on 127.0.0.1:5900 > > > > That is the VNC server you need to connect to. So in theory: > > > > vncviewer 127.0.0.1:5900 > > > > should work correctly. > > > > > > If you have: > > > > vfb = ["type=vnc"] > > > > in your xl config file and you have "fbdev" in your Linux guest, it > > should work. > > > > If you connect to the VNC server but you get a black screen, it > might be > > a guest configuration issue. I would try with a simpler guest, > text only > > (no X11, no Wayland) and enable the fbdev console (fbcon). See > > Documentation/fb/fbcon.rst in Linux. You should be able to see a > > graphical console over VNC. > > > > If that works, then you know that the fbdev kernel driver > (xen-fbfront) > > works correctly. > > > > If it doesn't work, the output of "xenstore-ls" would be > interesting. > > > > Cheers, > > > > Stefano > > > > > > On Wed, 19 Oct 2022, Vipul Suneja wrote: > > > Hi Stefano, > > > > > > Thanks for the response! > > > > > > I am following the same link you shared from the beginning. > Tried the command "vncviewer localhost:0" in DOM0 but same > > issue "Can't open > > > display", below are the logs: > > > > > > root@raspberrypi4-64:~# vncviewer localhost:0 > > > > > > TigerVNC Viewer 64-bit v1.11.0 > > > Built on: 2020-09-08 12:16 > > > Copyright (C) 1999-2020 TigerVNC Team and many others (see > README.rst) > > > See https://www.tigervnc.org for information on TigerVNC. > > > Can't open display: > > > > > > Below are the netstat logs, i couldn't see anything running at > port 5900 or 5901: > > > > > > root@raspberrypi4-64:~# netstat -tuwx > > > Active Internet connections (w/o servers) > > > Proto Recv-Q Send-Q Local Address Foreign Address > State > > > tcp 0 164 192.168.1.39:ssh 192.168.1.38:37472 > ESTABLISHED > > > Active UNIX domain sockets (w/o servers) > > > Proto RefCnt Flags Type State I-Node Path > > > unix 8 [ ] DGRAM CONNECTED 10565 /dev/log > > > unix 3 [ ] STREAM CONNECTED 10891 > /var/run/xenstored/socket > > > unix 3 [ ] STREAM CONNECTED 13791 > > > unix 3 [ ] STREAM CONNECTED 10843 > /var/run/xenstored/socket > > > unix 3 [ ] STREAM CONNECTED 10573 > /var/run/xenstored/socket > > > unix 2 [ ] DGRAM CONNECTED 14510 > > > unix 3 [ ] STREAM CONNECTED 13249 > > > unix 2 [ ] DGRAM CONNECTED 13887 > > > unix 2 [ ] DGRAM CONNECTED 10599 > > > unix 3 [ ] STREAM CONNECTED 14005 > > > unix 3 [ ] STREAM CONNECTED 13258 > > > unix 3 [ ] STREAM CONNECTED 13248 > > > unix 3 [ ] STREAM CONNECTED 14003 > > > unix 3 [ ] STREAM CONNECTED 10572 > /var/run/xenstored/socket > > > unix 3 [ ] STREAM CONNECTED 10786 > /var/run/xenstored/socket > > > unix 3 [ ] DGRAM CONNECTED 13186 > > > unix 3 [ ] STREAM CONNECTED 10864 > /var/run/xenstored/socket > > > unix 3 [ ] STREAM CONNECTED 10812 > /var/run/xenstored/socket > > > unix 2 [ ] DGRAM CONNECTED 14083 > > > unix 3 [ ] STREAM CONNECTED 10813 > /var/run/xenstored/socket > > > unix 3 [ ] STREAM CONNECTED 14068 > > > unix 3 [ ] STREAM CONNECTED 13256 > > > unix 3 [ ] STREAM CONNECTED 10571 > /var/run/xenstored/socket > > > unix 3 [ ] STREAM CONNECTED 10842 > > > unix 3 [ ] STREAM CONNECTED 13985 > > > unix 3 [ ] DGRAM CONNECTED 13185 > > > unix 2 [ ] STREAM CONNECTED 13884 > > > unix 2 [ ] DGRAM CONNECTED 14528 > > > unix 2 [ ] DGRAM CONNECTED 13785 > > > unix 3 [ ] STREAM CONNECTED 14034 > > > > > > Attaching xen log files of /var/log/xen. > > > I didn't get the role of QEMU here because as mentioned earlier, > I am porting in raspberrypi 4B. > > > > > > Regards, > > > Vipul Kumar > > > > > > On Wed, Oct 19, 2022 at 12:43 AM Stefano Stabellini < > sstabellini@kernel.org> wrote: > > > It usually works the way it is described in the guide: > > > > > > > > > https://www.virtuatopia.com/index.php?title=Configuring_a_VNC_based_Graphical_Console_for_a_Xen_Paravirtualized_domainU_Guest > > > > > > You don't need to install any VNC-related server software > because it is > > > already provided by Xen (to be precise it is provided by > QEMU working > > > together with Xen.) > > > > > > You only need the vnc client in dom0 so that you can > connect, but you > > > could also run the vnc client outside from another host. > So basically > > > the following should work when executed in Dom0 after > creating DomU: > > > > > > vncviewer localhost:0 > > > > > > Can you attach the Xen and QEMU logs (/var/log/xen/*)? And > also use > > > netstat -taunp to check if there is anything running at > port 5900 or > > > 5901? > > > > > > Cheers, > > > > > > Stefano > > > > > > > > > On Tue, 18 Oct 2022, Vipul Suneja wrote: > > > > Hi Stefano, > > > > > > > > Thanks for the response! > > > > > > > > I could install tigerVNC, x11vnc & libvncserver in Dom0 > xen-image-minimal but only manage to install > > libvncserver(couldn't > > > install tigervnc > > > > & x11vnc because of x11 > > > > support missing, it's wayland) in DOMU custom graphical > image. I tried running vncviewer with IP address & port > > in dom0 to > > > access the domu > > > > graphical image display as per below commands. > > > > > > > > vncviewer 192.168.1.42:5901 > > > > > > > > But it showing can't open display, below are the logs: > > > > > > > > root@raspberrypi4-64:~/guest1# vncviewer > 192.168.1.42:5901 > > > > > > > > TigerVNC Viewer 64-bit v1.11.0 > > > > Built on: 2020-09-08 12:16 > > > > Copyright (C) 1999-2020 TigerVNC Team and many others > (see README.rst) > > > > See https://www.tigervnc.org for information on > TigerVNC. > > > > Can't open display: > > > > root@raspberrypi4-64:~/guest1# > > > > > > > > I am not exactly sure what the issue is but I thought > only libvncserver in DOMU could work to get access but it > > did not > > > work. > > > > If TigerVNC is the issue here then is there any other > VNC source which could be installed for both x11 & > > wayland supported > > > images? > > > > > > > > Regards, > > > > Vipul Kumar > > > > > > > > On Tue, Oct 18, 2022 at 2:40 AM Stefano Stabellini < > sstabellini@kernel.org> wrote: > > > > VNC is typically easier to setup, because SDL > needs extra libraries at > > > > build time and runtime. If QEMU is built without > SDL support it won't > > > > start when you ask for SDL. > > > > > > > > VNC should work with both x11 and wayland in your > domU. It doesn't work > > > > at the x11 level, it exposes a special fbdev > device in your domU that > > > > should work with: > > > > - a graphical console in Linux domU > > > > - x11 > > > > - wayland (but I haven't tested this so I am not > 100% sure about it) > > > > > > > > When you say "it doesn't work", what do you mean? > Do you get a black > > > > window? > > > > > > > > You need CONFIG_XEN_FBDEV_FRONTEND in Linux domU > > > > (drivers/video/fbdev/xen-fbfront.c). I would try > to get a graphical text > > > > console up and running in your domU before > attempting x11/wayland. > > > > > > > > Cheers, > > > > > > > > Stefano > > > > > > > > On Mon, 17 Oct 2022, Vipul Suneja wrote: > > > > > Hi, > > > > > Thanks! > > > > > > > > > > I have ported xen minimal image as DOM0 & custom > wayland GUI based image as DOMU in raspberry pi4B. I > > am trying to > > > make GUI > > > > display up > > > > > for guest machine. I tried using sdl, included > below line in guest.conf file > > > > > vfb= [ 'sdl=1' ] > > > > > > > > > > But it is throwing below error: > > > > > > > > > > root@raspberrypi4-64:~/guest1# xl create -c > guest1.cfg > > > > > Parsing config from guest1.cfg > > > > > libxl: error: > libxl_qmp.c:1400:qmp_ev_fd_callback: Domain 3:error on QMP socket: > Connection reset by > > peer > > > > > libxl: error: > libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the QMP > connection to > > QEMU > > > > > libxl: error: > libxl_dm.c:3351:device_model_postconfig_done: Domain 3:Post DM startup > configs failed, > > rc=-26 > > > > > libxl: error: > libxl_create.c:1867:domcreate_devmodel_started: Domain 3:device model did > not start: -26 > > > > > libxl: error: > libxl_aoutils.c:646:libxl__kill_xs_path: Device Model already exited > > > > > libxl: error: > libxl_domain.c:1183:libxl__destroy_domid: Domain 3:Non-existant domain > > > > > libxl: error: > libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to destroy > guest > > > > > libxl: error: > libxl_domain.c:1064:domain_destroy_cb: Domain 3:Destruction of domain failed > > > > > > > > > > Another way is VNC, i could install tigervnc in > DOM0 but same i couldn't in guest machine because it > > doesn't support > > > > x11(supports wayland > > > > > only). I am completely blocked here, Need your > support to enable the display up. > > > > > Any alternative of VNC which could work in both > x11 & wayland supported images? > > > > > > > > > > Any input on VNC, SDL or any other way to > proceed on this? Looking forward to hearing from you. > > > > > > > > > > Regards, > > > > > Vipul Kumar > > > > > > > > > > > > > > > > > > > > > > > > > > > --00000000000054191d05edff84e6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Stefano,

Thanks for the=C2=A0support= !

Looks like I have tried all the combinations=C2= =A0& possible ways to get display up but failed. Is there any document = or pdf for porting xen on raspberrypi4.
I could find lot's of= links telling the same but couldn't see any official user guide or doc= ument from the xen community on the same. If there is something to refer=C2= =A0
to please share with me.
I am attaching the kernel = configuration file also, just take a look if i have missed anything.
<= div>Any other suggestions or input from your end could be really helpful?

Regards,
Vipul Kumar

On Fri, Nov 11,= 2022 at 6:40 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
Hi Vipul,

Sorry for the late reply. From the earlier logs that you sent, it looks
like everything should be working correctly. Specifically:

=C2=A0=C2=A0 =C2=A0 vfb =3D ""
=C2=A0=C2=A0 =C2=A0 =C2=A01 =3D ""
=C2=A0=C2=A0 =C2=A0 =C2=A0 0 =3D ""
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/= vfb/0"
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0online =3D "1"
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0state =3D "4"
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0vnc =3D "1"
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0vnclisten =3D "127.0.0.1"
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0vncdisplay =3D "0"
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0vncunused =3D "1"
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0sdl =3D "0"
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0opengl =3D "0"
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0feature-resize =3D "1"
=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0hotplug-status =3D "connected" =C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0request-update =3D "1"

state "4" means "connected". So I would expect that you= should be able
to connect to the vnc server using vncviewer. You might not see anything (black screen) but you should definitely be able to connect.

I wouldn't try to launch x11 in the guest just yet. fbcon in Linux is enough to render something on the screen. You should be able to see the
Linux text-based console rendered graphically, connecting to it via vnc.
Sorry for the basic question, but have you tried all the following?

vncviewer 127.0.0.1:0
vncviewer 127.0.0.1:1
vncviewer 127.0.0.1:2
vncviewer 127.0.0.1:5900
vncviewer 127.0.0.1:5901
vncviewer 127.0.0.1:5902

Given that from the xenstore-ls logs everything seems to work correctly
I am not sure what else to suggest. You might have to add printf to QEMU ui/vnc.c and hw/display/xenfb.c to see what is going wrong.

Cheers,

Stefano


On Mon, 7 Nov 2022, Vipul Suneja wrote:
> Hi Stefano,
> Thanks!
>
> Any input further on "xenstore-ls" logs?
>
> I am trying to run the x0vncserver & x11vnc server manually on gue= st machine(xen_guest_image_minimal) image but it's failing with the bel= ow
> error.
>
> root@raspberrypi4-64:/usr/bin# x0vncserver
> x0vncserver: unable to open display ""
> root@raspberrypi4-64:/usr/bin#
> root@raspberrypi4-64:/usr/bin# x11vnc
> ###############################################################
> #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0** =C2=A0WARNING =C2=A0** =C2=A0WARNING =C2=A0** =C2=A0WARNIN= G =C2=A0** =C2=A0WARNING =C2=A0** =C2=A0 @#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0YOU ARE RUNNING X11VNC WITHOUT A PASSWOR= D!! =C2=A0 =C2=A0 =C2=A0 =C2=A0@#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0This means anyone with network access to this computer =C2=A0= @#
> #@ =C2=A0may be able to view and control your desktop. =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0@#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ >>> If you did not mean to do this Press CTRL-C now!! <= << @#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0You can create an x11vnc password file by running: =C2=A0 =C2= =A0 =C2=A0 @#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0 =C2=A0 =C2=A0 x11vnc -storepasswd password /path/to/passfile= =C2=A0 =C2=A0 =C2=A0@#
> #@ =C2=A0or =C2=A0 x11vnc -storepasswd /path/to/passfile =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0or =C2=A0 x11vnc -storepasswd =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 @#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0(the last one will use ~/.vnc/passwd) =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0@#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0and then starting x11vnc via: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0@#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0 =C2=A0 =C2=A0x11vnc -rfbauth /path/to/passfile =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0@#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0an existing ~/.vnc/passwd file from another VNC =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0@#
> #@ =C2=A0application will work fine too. =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0@#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0You can also use the -passwdfile or -passwd options. =C2=A0 = =C2=A0 @#
> #@ =C2=A0(note -passwd is unsafe if local users are not trusted) =C2= =A0@#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0Make sure any -rfbauth and -passwdfile password files =C2=A0 = =C2=A0@#
> #@ =C2=A0cannot be read by untrusted users. =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0Use x11vnc -usepw to automatically use your =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0@#
> #@ =C2=A0~/.vnc/passwd or ~/.vnc/passwdfile password files. =C2=A0 =C2= =A0 =C2=A0 @#
> #@ =C2=A0(and prompt you to create ~/.vnc/passwd if neither =C2=A0 =C2= =A0 =C2=A0 @#
> #@ =C2=A0file exists.) =C2=A0Under -usepw, x11vnc will exit if it =C2= =A0 =C2=A0 =C2=A0@#
> #@ =C2=A0cannot find a password to use. =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0Even with a password, the subsequent VNC traffic is =C2=A0 = =C2=A0 =C2=A0@#
> #@ =C2=A0sent in the clear.=C2=A0 Consider tunnelling via ssh(1): =C2= =A0 =C2=A0 =C2=A0@#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0 =C2=A0http://www.karlrunge.com/x11vnc/#tun= nelling =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0@#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0Or using the x11vnc SSL options: -ssl and -stunnel =C2=A0 =C2= =A0 =C2=A0 @#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0Please Read the documentation for more info about =C2=A0 =C2= =A0 =C2=A0 =C2=A0@#
> #@ =C2=A0passwords, security, and encryption. =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0 =C2=A0http://www.karlrunge.com/x11= vnc/faq.html#faq-passwd =C2=A0 =C2=A0@#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0To disable this warning use the -nopw option, or put =C2=A0 = =C2=A0 @#
> #@ =C2=A0'nopw' on a line in your ~/.x11vncrc file. =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @#
> #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@#
> ###############################################################
> 09/03/2018 12:58:41 x11vnc version: 0.9.16 lastmod: 2019-01-05 =C2=A0p= id: 424
> 09/03/2018 12:58:41 XOpenDisplay("") failed.
> 09/03/2018 12:58:41 Trying again with XAUTHLOCALHOSTNAME=3Dlocalhost .= ..
> 09/03/2018 12:58:41
> 09/03/2018 12:58:41 *** XOpenDisplay failed. No -display or DISPLAY. > 09/03/2018 12:58:41 *** Trying ":0" in 4 seconds.=C2=A0 Pres= s Ctrl-C to abort.
> 09/03/2018 12:58:41 *** 1 2 3 4
> 09/03/2018 12:58:45 XOpenDisplay(":0") failed.
> 09/03/2018 12:58:45 Trying again with XAUTHLOCALHOSTNAME=3Dlocalhost .= ..
> 09/03/2018 12:58:45 XOpenDisplay(":0") failed.
> 09/03/2018 12:58:45 Trying again with unset XAUTHLOCALHOSTNAME ...
> 09/03/2018 12:58:45
>
> 09/03/2018 12:58:45 ***************************************
> 09/03/2018 12:58:45 *** XOpenDisplay failed (:0)
>
> *** x11vnc was unable to open the X DISPLAY: ":0", it cannot= continue.
> *** There may be "Xlib:" error messages above with details a= bout the failure.
>
> Some tips and guidelines:
>
> ** An X server (the one you wish to view) must be running before x11vn= c is
> =C2=A0 =C2=A0started: x11vnc does not start the X server. =C2=A0(howev= er, see the -create
> =C2=A0 =C2=A0option if that is what you really want).
>
> ** You must use -display <disp>, -OR- set and export your $DISPL= AY
> =C2=A0 =C2=A0environment variable to refer to the display of the desir= ed X server.
> =C2=A0- Usually the display is simply ":0" (in fact x11vnc u= ses this if you forget
> =C2=A0 =C2=A0to specify it), but in some multi-user situations it coul= d be ":1", ":2",
> =C2=A0 =C2=A0or even ":137".=C2=A0 Ask your administrator or= a guru if you are having
> =C2=A0 =C2=A0difficulty determining what your X DISPLAY is.
>
> ** Next, you need to have sufficient permissions (Xauthority)
> =C2=A0 =C2=A0to connect to the X DISPLAY. =C2=A0 Here are some Tips: >
> =C2=A0- Often, you just need to run x11vnc as the user logged into the= X session.
> =C2=A0 =C2=A0So make sure to be that user when you type x11vnc.
> =C2=A0- Being root is usually not enough because the incorrect MIT-MAG= IC-COOKIE
> =C2=A0 =C2=A0file may be accessed.=C2=A0 The cookie file contains the = secret key that
> =C2=A0 =C2=A0allows x11vnc to connect to the desired X DISPLAY.
> =C2=A0- You can explicitly indicate which MIT-MAGIC-COOKIE file should= be used
> =C2=A0 =C2=A0by the -auth option, e.g.:
> =C2=A0 =C2=A0 =C2=A0 =C2=A0x11vnc -auth /home/someuser/.Xauthority -di= splay :0
> =C2=A0 =C2=A0 =C2=A0 =C2=A0x11vnc -auth /tmp/.gdmzndVlR -display :0 > =C2=A0 =C2=A0you must have read permission for the auth file.
> =C2=A0 =C2=A0See also '-auth guess' and '-findauth' di= scussed below.
>
> ** If NO ONE is logged into an X session yet, but there is a greeter l= ogin
> =C2=A0 =C2=A0program like "gdm", "kdm", "xdm&= quot;, or "dtlogin" running, you will need
> =C2=A0 =C2=A0to find and use the raw display manager MIT-MAGIC-COOKIE = file.
> =C2=A0 =C2=A0Some examples for various display managers:
>
> =C2=A0 =C2=A0 =C2=A0gdm: =C2=A0 =C2=A0 -auth /var/gdm/:0.Xauth
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 -auth /var/lib/gdm/:0= .Xauth
> =C2=A0 =C2=A0 =C2=A0kdm: =C2=A0 =C2=A0 -auth /var/lib/kdm/A:0-crWk72 > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 -auth /var/run/xauth/= A:0-crWk72
> =C2=A0 =C2=A0 =C2=A0xdm: =C2=A0 =C2=A0 -auth /var/lib/xdm/authdir/auth= files/A:0-XQvaJk
> =C2=A0 =C2=A0 =C2=A0dtlogin: -auth /var/dt/A:0-UgaaXa
>
> =C2=A0 =C2=A0Sometimes the command "ps wwwwaux | grep auth" = can reveal the file location.
>
> =C2=A0 =C2=A0Starting with x11vnc 0.9.9 you can have it try to guess b= y using:
>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 -auth guess
>
> =C2=A0 =C2=A0(see also the x11vnc -findauth option.)
>
> =C2=A0 =C2=A0Only root will have read permission for the file, and so = x11vnc must be run
> =C2=A0 =C2=A0as root (or copy it).=C2=A0 The random characters in the = filenames will of course
> =C2=A0 =C2=A0change and the directory the cookie file resides in is sy= stem dependent.
>
> See also: http://www.karlrunge.com/x11vnc/faq.html<= br> >
> Regards,
> Vipul Kumar
>
> On Thu, Nov 3, 2022 at 10:27 PM Vipul Suneja <vsuneja63@gmail.com> wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Hi Stefano,
> Thanks!
>
> I used xen-guest-image-minimal(simple console based image) as a guest = with fbcon & fbdev enabled in kernel configurations but still
> the same error can't open the display.
> below are the outcome of "xenstore-ls":
>
> root@raspberrypi4-64:~/guest1# xenstore-ls
> tool =3D ""
> =C2=A0xenstored =3D ""
> local =3D ""
> =C2=A0domain =3D ""
> =C2=A0 0 =3D ""
> =C2=A0 =C2=A0control =3D ""
> =C2=A0 =C2=A0 feature-poweroff =3D "1"
> =C2=A0 =C2=A0 feature-reboot =3D "1"
> =C2=A0 =C2=A0domid =3D "0"
> =C2=A0 =C2=A0name =3D "Domain-0"
> =C2=A0 =C2=A0device-model =3D ""
> =C2=A0 =C2=A0 0 =3D ""
> =C2=A0 =C2=A0 =C2=A0backends =3D ""
> =C2=A0 =C2=A0 =C2=A0 console =3D ""
> =C2=A0 =C2=A0 =C2=A0 vkbd =3D ""
> =C2=A0 =C2=A0 =C2=A0 vfb =3D ""
> =C2=A0 =C2=A0 =C2=A0 qnic =3D ""
> =C2=A0 =C2=A0 =C2=A0state =3D "running"
> =C2=A0 =C2=A0 1 =3D ""
> =C2=A0 =C2=A0 =C2=A0backends =3D ""
> =C2=A0 =C2=A0 =C2=A0 console =3D ""
> =C2=A0 =C2=A0 =C2=A0 vkbd =3D ""
> =C2=A0 =C2=A0 =C2=A0 vfb =3D ""
> =C2=A0 =C2=A0 =C2=A0 qnic =3D ""
> =C2=A0 =C2=A0 =C2=A0state =3D "running"
> =C2=A0 =C2=A0backend =3D ""
> =C2=A0 =C2=A0 vbd =3D ""
> =C2=A0 =C2=A0 =C2=A01 =3D ""
> =C2=A0 =C2=A0 =C2=A0 51712 =3D ""
> =C2=A0 =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/v= bd/51712"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0params =3D "/home/root/guest2/xen-gues= t-image-minimal-raspberrypi4-64.ext3"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0script =3D "/etc/xen/scripts/block&quo= t;
> =C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0online =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0removable =3D "0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0bootable =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0state =3D "4"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0dev =3D "xvda"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0type =3D "phy"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0mode =3D "w"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0device-type =3D "disk"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0discard-enable =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-max-indirect-segments =3D "256= "
> =C2=A0 =C2=A0 =C2=A0 =C2=A0multi-queue-max-queues =3D "4" > =C2=A0 =C2=A0 =C2=A0 =C2=A0max-ring-page-order =3D "4"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0node =3D "/dev/loop0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0physical-device =3D "7:0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0physical-device-path =3D "/dev/loop0&q= uot;
> =C2=A0 =C2=A0 =C2=A0 =C2=A0hotplug-status =3D "connected" > =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-flush-cache =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0discard-granularity =3D "4096" > =C2=A0 =C2=A0 =C2=A0 =C2=A0discard-alignment =3D "0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0discard-secure =3D "0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-discard =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-barrier =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-persistent =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0sectors =3D "1794048"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0info =3D "0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0sector-size =3D "512"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0physical-sector-size =3D "512" > =C2=A0 =C2=A0 vfb =3D ""
> =C2=A0 =C2=A0 =C2=A01 =3D ""
> =C2=A0 =C2=A0 =C2=A0 0 =3D ""
> =C2=A0 =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/v= fb/0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0online =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0state =3D "4"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0vnc =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0vnclisten =3D "127.0.0.1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0vncdisplay =3D "0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0vncunused =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0sdl =3D "0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0opengl =3D "0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-resize =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0hotplug-status =3D "connected" > =C2=A0 =C2=A0 =C2=A0 =C2=A0request-update =3D "1"
> =C2=A0 =C2=A0 vkbd =3D ""
> =C2=A0 =C2=A0 =C2=A01 =3D ""
> =C2=A0 =C2=A0 =C2=A0 0 =3D ""
> =C2=A0 =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/v= kbd/0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0online =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0state =3D "4"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-abs-pointer =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-raw-pointer =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0hotplug-status =3D "connected" > =C2=A0 =C2=A0 console =3D ""
> =C2=A0 =C2=A0 =C2=A01 =3D ""
> =C2=A0 =C2=A0 =C2=A0 0 =3D ""
> =C2=A0 =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/console&= quot;
> =C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0online =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0state =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0protocol =3D "vt100"
> =C2=A0 =C2=A0 vif =3D ""
> =C2=A0 =C2=A0 =C2=A01 =3D ""
> =C2=A0 =C2=A0 =C2=A0 0 =3D ""
> =C2=A0 =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/v= if/0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0online =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0state =3D "4"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0script =3D "/etc/xen/scripts/vif-bridg= e"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0mac =3D "e4:5f:01:cd:7b:dd"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0bridge =3D "xenbr0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0handle =3D "0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0type =3D "vif"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0hotplug-status =3D "connected" > =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-sg =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-gso-tcpv4 =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-gso-tcpv6 =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-ipv6-csum-offload =3D "1"=
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-rx-copy =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-xdp-headroom =3D "1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-rx-flip =3D "0"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-multicast-control =3D "1"=
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-dynamic-multicast-control =3D "= ;1"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-split-event-channels =3D "1&qu= ot;
> =C2=A0 =C2=A0 =C2=A0 =C2=A0multi-queue-max-queues =3D "4" > =C2=A0 =C2=A0 =C2=A0 =C2=A0feature-ctrl-ring =3D "1"
> =C2=A0 1 =3D ""
> =C2=A0 =C2=A0vm =3D "/vm/d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f&quo= t;
> =C2=A0 =C2=A0name =3D "guest2"
> =C2=A0 =C2=A0cpu =3D ""
> =C2=A0 =C2=A0 0 =3D ""
> =C2=A0 =C2=A0 =C2=A0availability =3D "online"
> =C2=A0 =C2=A0 1 =3D ""
> =C2=A0 =C2=A0 =C2=A0availability =3D "online"
> =C2=A0 =C2=A0memory =3D ""
> =C2=A0 =C2=A0 static-max =3D "2097152"
> =C2=A0 =C2=A0 target =3D "2097152"
> =C2=A0 =C2=A0 videoram =3D "0"
> =C2=A0 =C2=A0device =3D ""
> =C2=A0 =C2=A0 suspend =3D ""
> =C2=A0 =C2=A0 =C2=A0event-channel =3D ""
> =C2=A0 =C2=A0 vbd =3D ""
> =C2=A0 =C2=A0 =C2=A051712 =3D ""
> =C2=A0 =C2=A0 =C2=A0 backend =3D "/local/domain/0/backend/vbd/1/5= 1712"
> =C2=A0 =C2=A0 =C2=A0 backend-id =3D "0"
> =C2=A0 =C2=A0 =C2=A0 state =3D "4"
> =C2=A0 =C2=A0 =C2=A0 virtual-device =3D "51712"
> =C2=A0 =C2=A0 =C2=A0 device-type =3D "disk"
> =C2=A0 =C2=A0 =C2=A0 multi-queue-num-queues =3D "2"
> =C2=A0 =C2=A0 =C2=A0 queue-0 =3D ""
> =C2=A0 =C2=A0 =C2=A0 =C2=A0ring-ref =3D "8"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0event-channel =3D "4"
> =C2=A0 =C2=A0 =C2=A0 queue-1 =3D ""
> =C2=A0 =C2=A0 =C2=A0 =C2=A0ring-ref =3D "9"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0event-channel =3D "5"
> =C2=A0 =C2=A0 =C2=A0 protocol =3D "arm-abi"
> =C2=A0 =C2=A0 =C2=A0 feature-persistent =3D "1"
> =C2=A0 =C2=A0 vfb =3D ""
> =C2=A0 =C2=A0 =C2=A00 =3D ""
> =C2=A0 =C2=A0 =C2=A0 backend =3D "/local/domain/0/backend/vfb/1/0= "
> =C2=A0 =C2=A0 =C2=A0 backend-id =3D "0"
> =C2=A0 =C2=A0 =C2=A0 state =3D "4"
> =C2=A0 =C2=A0 =C2=A0 page-ref =3D "275022"
> =C2=A0 =C2=A0 =C2=A0 event-channel =3D "3"
> =C2=A0 =C2=A0 =C2=A0 protocol =3D "arm-abi"
> =C2=A0 =C2=A0 =C2=A0 feature-update =3D "1"
> =C2=A0 =C2=A0 vkbd =3D ""
> =C2=A0 =C2=A0 =C2=A00 =3D ""
> =C2=A0 =C2=A0 =C2=A0 backend =3D "/local/domain/0/backend/vkbd/1/= 0"
> =C2=A0 =C2=A0 =C2=A0 backend-id =3D "0"
> =C2=A0 =C2=A0 =C2=A0 state =3D "4"
> =C2=A0 =C2=A0 =C2=A0 request-abs-pointer =3D "1"
> =C2=A0 =C2=A0 =C2=A0 page-ref =3D "275322"
> =C2=A0 =C2=A0 =C2=A0 page-gref =3D "1284"
> =C2=A0 =C2=A0 =C2=A0 event-channel =3D "10"
> =C2=A0 =C2=A0 vif =3D ""
> =C2=A0 =C2=A0 =C2=A00 =3D ""
> =C2=A0 =C2=A0 =C2=A0 backend =3D "/local/domain/0/backend/vif/1/0= "
> =C2=A0 =C2=A0 =C2=A0 backend-id =3D "0"
> =C2=A0 =C2=A0 =C2=A0 state =3D "4"
> =C2=A0 =C2=A0 =C2=A0 handle =3D "0"
> =C2=A0 =C2=A0 =C2=A0 mac =3D "e4:5f:01:cd:7b:dd"
> =C2=A0 =C2=A0 =C2=A0 mtu =3D "1500"
> =C2=A0 =C2=A0 =C2=A0 xdp-headroom =3D "0"
> =C2=A0 =C2=A0 =C2=A0 multi-queue-num-queues =3D "2"
> =C2=A0 =C2=A0 =C2=A0 queue-0 =3D ""
> =C2=A0 =C2=A0 =C2=A0 =C2=A0tx-ring-ref =3D "1280"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0rx-ring-ref =3D "1281"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0event-channel-tx =3D "6"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0event-channel-rx =3D "7"
> =C2=A0 =C2=A0 =C2=A0 queue-1 =3D ""
> =C2=A0 =C2=A0 =C2=A0 =C2=A0tx-ring-ref =3D "1282"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0rx-ring-ref =3D "1283"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0event-channel-tx =3D "8"
> =C2=A0 =C2=A0 =C2=A0 =C2=A0event-channel-rx =3D "9"
> =C2=A0 =C2=A0 =C2=A0 request-rx-copy =3D "1"
> =C2=A0 =C2=A0 =C2=A0 feature-rx-notify =3D "1"
> =C2=A0 =C2=A0 =C2=A0 feature-sg =3D "1"
> =C2=A0 =C2=A0 =C2=A0 feature-gso-tcpv4 =3D "1"
> =C2=A0 =C2=A0 =C2=A0 feature-gso-tcpv6 =3D "1"
> =C2=A0 =C2=A0 =C2=A0 feature-ipv6-csum-offload =3D "1"
> =C2=A0 =C2=A0control =3D ""
> =C2=A0 =C2=A0 shutdown =3D ""
> =C2=A0 =C2=A0 feature-poweroff =3D "1"
> =C2=A0 =C2=A0 feature-reboot =3D "1"
> =C2=A0 =C2=A0 feature-suspend =3D ""
> =C2=A0 =C2=A0 sysrq =3D ""
> =C2=A0 =C2=A0 platform-feature-multiprocessor-suspend =3D "1"= ;
> =C2=A0 =C2=A0 platform-feature-xs_reset_watches =3D "1"
> =C2=A0 =C2=A0data =3D ""
> =C2=A0 =C2=A0drivers =3D ""
> =C2=A0 =C2=A0feature =3D ""
> =C2=A0 =C2=A0attr =3D ""
> =C2=A0 =C2=A0error =3D ""
> =C2=A0 =C2=A0domid =3D "1"
> =C2=A0 =C2=A0store =3D ""
> =C2=A0 =C2=A0 port =3D "1"
> =C2=A0 =C2=A0 ring-ref =3D "233473"
> =C2=A0 =C2=A0console =3D ""
> =C2=A0 =C2=A0 backend =3D "/local/domain/0/backend/console/1/0&qu= ot;
> =C2=A0 =C2=A0 backend-id =3D "0"
> =C2=A0 =C2=A0 limit =3D "1048576"
> =C2=A0 =C2=A0 type =3D "xenconsoled"
> =C2=A0 =C2=A0 output =3D "pty"
> =C2=A0 =C2=A0 tty =3D "/dev/pts/1"
> =C2=A0 =C2=A0 port =3D "2"
> =C2=A0 =C2=A0 ring-ref =3D "233472"
> =C2=A0 =C2=A0 vnc-listen =3D "127.0.0.1"
> =C2=A0 =C2=A0 vnc-port =3D "5900"
> =C2=A0 =C2=A0image =3D ""
> =C2=A0 =C2=A0 device-model-pid =3D "788"
> vm =3D ""
> =C2=A0d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f =3D ""
> =C2=A0 name =3D "guest2"
> =C2=A0 uuid =3D "d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f"
> =C2=A0 start_time =3D "1520600274.27"
> libxl =3D ""
> =C2=A01 =3D ""
> =C2=A0 device =3D ""
> =C2=A0 =C2=A0vbd =3D ""
> =C2=A0 =C2=A0 51712 =3D ""
> =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/vbd/5171= 2"
> =C2=A0 =C2=A0 =C2=A0backend =3D "/local/domain/0/backend/vbd/1/51= 712"
> =C2=A0 =C2=A0 =C2=A0params =3D "/home/root/guest2/xen-guest-image= -minimal-raspberrypi4-64.ext3"
> =C2=A0 =C2=A0 =C2=A0script =3D "/etc/xen/scripts/block"
> =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
> =C2=A0 =C2=A0 =C2=A0online =3D "1"
> =C2=A0 =C2=A0 =C2=A0removable =3D "0"
> =C2=A0 =C2=A0 =C2=A0bootable =3D "1"
> =C2=A0 =C2=A0 =C2=A0state =3D "1"
> =C2=A0 =C2=A0 =C2=A0dev =3D "xvda"
> =C2=A0 =C2=A0 =C2=A0type =3D "phy"
> =C2=A0 =C2=A0 =C2=A0mode =3D "w"
> =C2=A0 =C2=A0 =C2=A0device-type =3D "disk"
> =C2=A0 =C2=A0 =C2=A0discard-enable =3D "1"
> =C2=A0 =C2=A0vfb =3D ""
> =C2=A0 =C2=A0 0 =3D ""
> =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/vfb/0&qu= ot;
> =C2=A0 =C2=A0 =C2=A0backend =3D "/local/domain/0/backend/vfb/1/0&= quot;
> =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
> =C2=A0 =C2=A0 =C2=A0online =3D "1"
> =C2=A0 =C2=A0 =C2=A0state =3D "1"
> =C2=A0 =C2=A0 =C2=A0vnc =3D "1"
> =C2=A0 =C2=A0 =C2=A0vnclisten =3D "127.0.0.1"
> =C2=A0 =C2=A0 =C2=A0vncdisplay =3D "0"
> =C2=A0 =C2=A0 =C2=A0vncunused =3D "1"
> =C2=A0 =C2=A0 =C2=A0sdl =3D "0"
> =C2=A0 =C2=A0 =C2=A0opengl =3D "0"
> =C2=A0 =C2=A0vkbd =3D ""
> =C2=A0 =C2=A0 0 =3D ""
> =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/vkbd/0&q= uot;
> =C2=A0 =C2=A0 =C2=A0backend =3D "/local/domain/0/backend/vkbd/1/0= "
> =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
> =C2=A0 =C2=A0 =C2=A0online =3D "1"
> =C2=A0 =C2=A0 =C2=A0state =3D "1"
> =C2=A0 =C2=A0console =3D ""
> =C2=A0 =C2=A0 0 =3D ""
> =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/console" > =C2=A0 =C2=A0 =C2=A0backend =3D "/local/domain/0/backend/console/= 1/0"
> =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
> =C2=A0 =C2=A0 =C2=A0online =3D "1"
> =C2=A0 =C2=A0 =C2=A0state =3D "1"
> =C2=A0 =C2=A0 =C2=A0protocol =3D "vt100"
> =C2=A0 =C2=A0vif =3D ""
> =C2=A0 =C2=A0 0 =3D ""
> =C2=A0 =C2=A0 =C2=A0frontend =3D "/local/domain/1/device/vif/0&qu= ot;
> =C2=A0 =C2=A0 =C2=A0backend =3D "/local/domain/0/backend/vif/1/0&= quot;
> =C2=A0 =C2=A0 =C2=A0frontend-id =3D "1"
> =C2=A0 =C2=A0 =C2=A0online =3D "1"
> =C2=A0 =C2=A0 =C2=A0state =3D "1"
> =C2=A0 =C2=A0 =C2=A0script =3D "/etc/xen/scripts/vif-bridge"=
> =C2=A0 =C2=A0 =C2=A0mac =3D "e4:5f:01:cd:7b:dd"
> =C2=A0 =C2=A0 =C2=A0bridge =3D "xenbr0"
> =C2=A0 =C2=A0 =C2=A0handle =3D "0"
> =C2=A0 =C2=A0 =C2=A0type =3D "vif"
> =C2=A0 =C2=A0 =C2=A0hotplug-status =3D ""
> =C2=A0 type =3D "pvh"
> =C2=A0 dm-version =3D "qemu_xen"
> root@raspberrypi4-64:~/guest1#
>
> Any input as per above? Looking forward to hearing from you.
>
> Regards,
> Vipul Kumar
>
> On Wed, Oct 26, 2022 at 5:21 AM Stefano Stabellini <sstabellini@kernel.org>= wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Hi Vipul,
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0If you look at the QEMU logs, it says:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0VNC server running on 127.0.0.1:5900
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0That is the VNC server you need to connect t= o. So in theory:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 vncviewer 127.0.0.1:5900
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0should work correctly.
>
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0If you have:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 vfb =3D ["type=3Dvnc"]
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0in your xl config file and you have "fb= dev" in your Linux guest, it
>=C2=A0 =C2=A0 =C2=A0 =C2=A0should work.
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0If you connect to the VNC server but you get= a black screen, it might be
>=C2=A0 =C2=A0 =C2=A0 =C2=A0a guest configuration issue. I would try wit= h a simpler guest, text only
>=C2=A0 =C2=A0 =C2=A0 =C2=A0(no X11, no Wayland) and enable the fbdev co= nsole (fbcon). See
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Documentation/fb/fbcon.rst in Linux. You sho= uld be able to see a
>=C2=A0 =C2=A0 =C2=A0 =C2=A0graphical console over VNC.
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0If that works, then you know that the fbdev = kernel driver (xen-fbfront)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0works correctly.
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0If it doesn't work, the output of "= xenstore-ls" would be interesting.
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Cheers,
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Stefano
>
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0On Wed, 19 Oct 2022, Vipul Suneja wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Hi Stefano,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Thanks for the response!
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> I am following the same link you shared= from the beginning. Tried the command "vncviewer localhost:0" in= DOM0 but same
>=C2=A0 =C2=A0 =C2=A0 =C2=A0issue "Can't open
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> display", below are the logs:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> root@raspberrypi4-64:~# vncviewer local= host:0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> TigerVNC Viewer 64-bit v1.11.0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Built on: 2020-09-08 12:16
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Copyright (C) 1999-2020 TigerVNC Team a= nd many others (see README.rst)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> See https://www.tigervnc.org for inf= ormation on TigerVNC.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Can't open display:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Below are the netstat logs, i couldn= 9;t see anything running at port 5900 or 5901:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> root@raspberrypi4-64:~# netstat -tuwx >=C2=A0 =C2=A0 =C2=A0 =C2=A0> Active Internet connections (w/o server= s)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Proto Recv-Q Send-Q Local Address =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Foreign Address =C2=A0 =C2=A0 =C2=A0 =C2=A0= State =C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> tcp =C2=A0 =C2=A0 =C2=A0 =C2=A00 =C2=A0= =C2=A0164 192.168.1.39:ssh =C2=A0 =C2=A0 =C2=A0 =C2=A0192.168.1.38:37472 =C2=A0 =C2=A0 =C2=A0ESTABLISHED
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Active UNIX domain sockets (w/o servers= )
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Proto RefCnt Flags =C2=A0 =C2=A0 =C2=A0= Type =C2=A0 =C2=A0 =C2=A0 State =C2=A0 =C2=A0 =C2=A0 =C2=A0 I-Node Path >=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A08 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2= =A0 =C2=A010565 /dev/log
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A010891 /var/run/xenstored/socket
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A013791
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A010843 /var/run/xenstored/socket
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A010573 /var/run/xenstored/socket
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2= =A0 =C2=A014510
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A013249
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2= =A0 =C2=A013887
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2= =A0 =C2=A010599
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A014005
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A013258
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A013248
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A014003
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A010572 /var/run/xenstored/socket
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A010786 /var/run/xenstored/socket
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2= =A0 =C2=A013186
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A010864 /var/run/xenstored/socket
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A010812 /var/run/xenstored/socket
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2= =A0 =C2=A014083
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A010813 /var/run/xenstored/socket
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A014068
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A013256
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A010571 /var/run/xenstored/socket
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A010842
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A013985
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2= =A0 =C2=A013185
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A013884
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2= =A0 =C2=A014528
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2= =A0 =C2=A013785
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] = =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 = =C2=A014034
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Attaching xen log files of /var/log/xen= .
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> I didn't get the role of QEMU here = because as mentioned earlier, I am porting in raspberrypi 4B.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Regards,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Vipul Kumar
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0> On Wed, Oct 19, 2022 at 12:43 AM Stefan= o Stabellini <sstabellini@kernel.org> wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0It usually wo= rks the way it is described in the guide:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0https://www= .virtuatopia.com/index.php?title=3DConfiguring_a_VNC_based_Graphical_Consol= e_for_a_Xen_Paravirtualized_domainU_Guest
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0You don't= need to install any VNC-related server software because it is
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0already provi= ded by Xen (to be precise it is provided by QEMU working
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0together with= Xen.)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0You only need= the vnc client in dom0 so that you can connect, but you
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0could also ru= n the vnc client outside from another host. So basically
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0the following= should work when executed in Dom0 after creating DomU:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 vncvie= wer localhost:0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0Can you attac= h the Xen and QEMU logs (/var/log/xen/*)? And also use
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0netstat -taun= p to check if there is anything running at port 5900 or
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A05901?
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0Cheers,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0Stefano
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0On Tue, 18 Oc= t 2022, Vipul Suneja wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Hi Stefa= no,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Thanks f= or the response!
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> I could = install tigerVNC, x11vnc & libvncserver in Dom0 xen-image-minimal but o= nly manage to install
>=C2=A0 =C2=A0 =C2=A0 =C2=A0libvncserver(couldn't
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0install tiger= vnc
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> & x1= 1vnc because of x11
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> support = missing, it's wayland) in DOMU custom graphical image. I tried running = vncviewer with IP address & port
>=C2=A0 =C2=A0 =C2=A0 =C2=A0in dom0 to
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0access the do= mu
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> graphica= l image display as per below commands.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0vn= cviewer 192.168.1.42:5901
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0Bu= t it showing can't open display, below are the logs:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> root@ras= pberrypi4-64:~/guest1# vncviewer 192.168.1.42:5901
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> TigerVNC= Viewer 64-bit v1.11.0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Built on= : 2020-09-08 12:16
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Copyrigh= t (C) 1999-2020 TigerVNC Team and many others (see README.rst)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> See https= ://www.tigervnc.org for information on TigerVNC.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Can'= t open display:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> root@ras= pberrypi4-64:~/guest1#
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> I am not= exactly=C2=A0sure what the issue is but I thought only libvncserver in DOM= U could work to get access but it
>=C2=A0 =C2=A0 =C2=A0 =C2=A0did not
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0work.=C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> If Tiger= VNC is the issue here then is there any other VNC source which could be ins= talled for both x11 &
>=C2=A0 =C2=A0 =C2=A0 =C2=A0wayland supported
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0images?
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Regards,=
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> Vipul Ku= mar
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0> On Tue, = Oct 18, 2022 at 2:40 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0VNC is typically easier to setup, because SDL needs ext= ra libraries at
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0build time and runtime. If QEMU is built without SDL su= pport it won't
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0start when you ask for SDL.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0VNC should work with both x11 and wayland in your domU.= It doesn't work
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0at the x11 level, it exposes a special fbdev device in = your domU that
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0should work with:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0- a graphical console in Linux domU
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0- x11
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0- wayland (but I haven't tested this so I am not 10= 0% sure about it)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0When you say "it doesn't work", what do y= ou mean? Do you get a black
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0window?
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0You need CONFIG_XEN_FBDEV_FRONTEND in Linux domU
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0(drivers/video/fbdev/xen-fbfront.c). I would try to get= a graphical text
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0console up and running in your domU before attempting x= 11/wayland.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0Cheers,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0Stefano
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0On Mon, 17 Oct 2022, Vipul Suneja wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> Hi,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> Thanks!
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> I have ported xen minimal image as DOM0 & cust= om wayland GUI based image as DOMU in raspberry pi4B. I
>=C2=A0 =C2=A0 =C2=A0 =C2=A0am trying to
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0make GUI
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0display up
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> for=C2=A0guest machine. I tried using=C2=A0sdl, in= cluded below line in guest.conf file
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> vfb=3D [ 'sdl=3D1' ]
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> But it is throwing below error:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> root@raspberrypi4-64:~/guest1# xl create -c guest1= .cfg
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> Parsing config from guest1.cfg
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback:= Domain 3:error on QMP socket: Connection reset by
>=C2=A0 =C2=A0 =C2=A0 =C2=A0peer
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> libxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback:= Domain 3:Error happened with the QMP connection to
>=C2=A0 =C2=A0 =C2=A0 =C2=A0QEMU
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> libxl: error: libxl_dm.c:3351:device_model_postcon= fig_done: Domain 3:Post DM startup configs failed,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0rc=3D-26
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> libxl: error: libxl_create.c:1867:domcreate_devmod= el_started: Domain 3:device model did not start: -26
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> libxl: error: libxl_aoutils.c:646:libxl__kill_xs_p= ath: Device Model already exited
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> libxl: error: libxl_domain.c:1183:libxl__destroy_d= omid: Domain 3:Non-existant domain
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> libxl: error: libxl_domain.c:1137:domain_destroy_c= allback: Domain 3:Unable to destroy guest
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> libxl: error: libxl_domain.c:1064:domain_destroy_c= b: Domain 3:Destruction of domain failed
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> Another way is VNC, i could install tigervnc in DO= M0 but same i couldn't in guest machine because it
>=C2=A0 =C2=A0 =C2=A0 =C2=A0doesn't support
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0x11(supports wayland
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> only). I am completely blocked here, Need your sup= port to enable the display up.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> Any alternative of VNC which could work in both x1= 1 & wayland supported images?
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> Any input on VNC, SDL or any other way to proceed = on this? Looking forward to hearing from you.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> Regards,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 = =C2=A0 =C2=A0 =C2=A0> Vipul Kumar
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0>
>
>
>
--00000000000054191d05edff84e6-- --00000000000054191f05edff84e8 Content-Type: application/octet-stream; name=config Content-Disposition: attachment; filename=config Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lar54cp20 IwojIEF1dG9tYXRpY2FsbHkgZ2VuZXJhdGVkIGZpbGU7IERPIE5PVCBFRElULgojIExpbnV4L2Fy bTY0IDUuMTUuNjggS2VybmVsIENvbmZpZ3VyYXRpb24KIwpDT05GSUdfQ0NfVkVSU0lPTl9URVhU PSJhYXJjaDY0LXBva3ktbGludXgtZ2NjIChHQ0MpIDExLjMuMCIKQ09ORklHX0NDX0lTX0dDQz15 CkNPTkZJR19HQ0NfVkVSU0lPTj0xMTAzMDAKQ09ORklHX0NMQU5HX1ZFUlNJT049MApDT05GSUdf QVNfSVNfR05VPXkKQ09ORklHX0FTX1ZFUlNJT049MjAyNDQ1MDgKQ09ORklHX0xEX0lTX0JGRD15 CkNPTkZJR19MRF9WRVJTSU9OPTIwMjQ0NTA4CkNPTkZJR19MTERfVkVSU0lPTj0wCkNPTkZJR19D Q19DQU5fTElOSz15CkNPTkZJR19DQ19DQU5fTElOS19TVEFUSUM9eQpDT05GSUdfQ0NfSEFTX0FT TV9HT1RPPXkKQ09ORklHX0NDX0hBU19BU01fR09UT19PVVRQVVQ9eQpDT05GSUdfQ0NfSEFTX0FT TV9HT1RPX1RJRURfT1VUUFVUPXkKQ09ORklHX0NDX0hBU19BU01fSU5MSU5FPXkKQ09ORklHX0ND X0hBU19OT19QUk9GSUxFX0ZOX0FUVFI9eQpDT05GSUdfSVJRX1dPUks9eQpDT05GSUdfQlVJTERU SU1FX1RBQkxFX1NPUlQ9eQpDT05GSUdfVEhSRUFEX0lORk9fSU5fVEFTSz15CgojCiMgR2VuZXJh bCBzZXR1cAojCkNPTkZJR19JTklUX0VOVl9BUkdfTElNSVQ9MzIKIyBDT05GSUdfQ09NUElMRV9U RVNUIGlzIG5vdCBzZXQKIyBDT05GSUdfV0VSUk9SIGlzIG5vdCBzZXQKQ09ORklHX0xPQ0FMVkVS U0lPTj0iLXlvY3RvLXN0YW5kYXJkIgojIENPTkZJR19MT0NBTFZFUlNJT05fQVVUTyBpcyBub3Qg c2V0CkNPTkZJR19CVUlMRF9TQUxUPSIiCkNPTkZJR19ERUZBVUxUX0lOSVQ9IiIKQ09ORklHX0RF RkFVTFRfSE9TVE5BTUU9Iihub25lKSIKQ09ORklHX1NXQVA9eQpDT05GSUdfU1lTVklQQz15CkNP TkZJR19TWVNWSVBDX1NZU0NUTD15CkNPTkZJR19QT1NJWF9NUVVFVUU9eQpDT05GSUdfUE9TSVhf TVFVRVVFX1NZU0NUTD15CiMgQ09ORklHX1dBVENIX1FVRVVFIGlzIG5vdCBzZXQKQ09ORklHX0NS T1NTX01FTU9SWV9BVFRBQ0g9eQojIENPTkZJR19VU0VMSUIgaXMgbm90IHNldAojIENPTkZJR19B VURJVCBpcyBub3Qgc2V0CkNPTkZJR19IQVZFX0FSQ0hfQVVESVRTWVNDQUxMPXkKCiMKIyBJUlEg c3Vic3lzdGVtCiMKQ09ORklHX0dFTkVSSUNfSVJRX1BST0JFPXkKQ09ORklHX0dFTkVSSUNfSVJR X1NIT1c9eQpDT05GSUdfR0VORVJJQ19JUlFfU0hPV19MRVZFTD15CkNPTkZJR19HRU5FUklDX0lS UV9FRkZFQ1RJVkVfQUZGX01BU0s9eQpDT05GSUdfR0VORVJJQ19JUlFfTUlHUkFUSU9OPXkKQ09O RklHX0hBUkRJUlFTX1NXX1JFU0VORD15CkNPTkZJR19HRU5FUklDX0lSUV9DSElQPXkKQ09ORklH X0lSUV9ET01BSU49eQpDT05GSUdfSVJRX1NJTT15CkNPTkZJR19JUlFfRE9NQUlOX0hJRVJBUkNI WT15CkNPTkZJR19HRU5FUklDX0lSUV9JUEk9eQpDT05GSUdfR0VORVJJQ19NU0lfSVJRPXkKQ09O RklHX0dFTkVSSUNfTVNJX0lSUV9ET01BSU49eQpDT05GSUdfSVJRX01TSV9JT01NVT15CkNPTkZJ R19IQU5ETEVfRE9NQUlOX0lSUT15CkNPTkZJR19JUlFfRk9SQ0VEX1RIUkVBRElORz15CkNPTkZJ R19TUEFSU0VfSVJRPXkKIyBDT05GSUdfR0VORVJJQ19JUlFfREVCVUdGUyBpcyBub3Qgc2V0CiMg ZW5kIG9mIElSUSBzdWJzeXN0ZW0KCkNPTkZJR19HRU5FUklDX1RJTUVfVlNZU0NBTEw9eQpDT05G SUdfR0VORVJJQ19DTE9DS0VWRU5UUz15CkNPTkZJR19BUkNIX0hBU19USUNLX0JST0FEQ0FTVD15 CkNPTkZJR19HRU5FUklDX0NMT0NLRVZFTlRTX0JST0FEQ0FTVD15CgojCiMgVGltZXJzIHN1YnN5 c3RlbQojCkNPTkZJR19USUNLX09ORVNIT1Q9eQpDT05GSUdfSFpfUEVSSU9ESUM9eQojIENPTkZJ R19OT19IWl9JRExFIGlzIG5vdCBzZXQKIyBDT05GSUdfTk9fSFpfRlVMTCBpcyBub3Qgc2V0CiMg Q09ORklHX05PX0haIGlzIG5vdCBzZXQKQ09ORklHX0hJR0hfUkVTX1RJTUVSUz15CiMgZW5kIG9m IFRpbWVycyBzdWJzeXN0ZW0KCkNPTkZJR19CUEY9eQpDT05GSUdfSEFWRV9FQlBGX0pJVD15CkNP TkZJR19BUkNIX1dBTlRfREVGQVVMVF9CUEZfSklUPXkKCiMKIyBCUEYgc3Vic3lzdGVtCiMKQ09O RklHX0JQRl9TWVNDQUxMPXkKQ09ORklHX0JQRl9KSVQ9eQojIENPTkZJR19CUEZfSklUX0FMV0FZ U19PTiBpcyBub3Qgc2V0CkNPTkZJR19CUEZfSklUX0RFRkFVTFRfT049eQpDT05GSUdfQlBGX1VO UFJJVl9ERUZBVUxUX09GRj15CiMgQ09ORklHX0JQRl9QUkVMT0FEIGlzIG5vdCBzZXQKIyBDT05G SUdfQlBGX0xTTSBpcyBub3Qgc2V0CiMgZW5kIG9mIEJQRiBzdWJzeXN0ZW0KCiMgQ09ORklHX1BS RUVNUFRfTk9ORSBpcyBub3Qgc2V0CiMgQ09ORklHX1BSRUVNUFRfVk9MVU5UQVJZIGlzIG5vdCBz ZXQKQ09ORklHX1BSRUVNUFQ9eQpDT05GSUdfUFJFRU1QVF9DT1VOVD15CkNPTkZJR19QUkVFTVBU SU9OPXkKCiMKIyBDUFUvVGFzayB0aW1lIGFuZCBzdGF0cyBhY2NvdW50aW5nCiMKQ09ORklHX1RJ Q0tfQ1BVX0FDQ09VTlRJTkc9eQojIENPTkZJR19WSVJUX0NQVV9BQ0NPVU5USU5HX0dFTiBpcyBu b3Qgc2V0CiMgQ09ORklHX0lSUV9USU1FX0FDQ09VTlRJTkcgaXMgbm90IHNldApDT05GSUdfSEFW RV9TQ0hFRF9BVkdfSVJRPXkKQ09ORklHX0JTRF9QUk9DRVNTX0FDQ1Q9eQpDT05GSUdfQlNEX1BS T0NFU1NfQUNDVF9WMz15CiMgQ09ORklHX1RBU0tTVEFUUyBpcyBub3Qgc2V0CiMgQ09ORklHX1BT SSBpcyBub3Qgc2V0CiMgZW5kIG9mIENQVS9UYXNrIHRpbWUgYW5kIHN0YXRzIGFjY291bnRpbmcK CkNPTkZJR19DUFVfSVNPTEFUSU9OPXkKCiMKIyBSQ1UgU3Vic3lzdGVtCiMKQ09ORklHX1RSRUVf UkNVPXkKQ09ORklHX1BSRUVNUFRfUkNVPXkKIyBDT05GSUdfUkNVX0VYUEVSVCBpcyBub3Qgc2V0 CkNPTkZJR19TUkNVPXkKQ09ORklHX1RSRUVfU1JDVT15CkNPTkZJR19UQVNLU19SQ1VfR0VORVJJ Qz15CkNPTkZJR19UQVNLU19SQ1U9eQpDT05GSUdfVEFTS1NfUlVERV9SQ1U9eQpDT05GSUdfVEFT S1NfVFJBQ0VfUkNVPXkKQ09ORklHX1JDVV9TVEFMTF9DT01NT049eQpDT05GSUdfUkNVX05FRURf U0VHQ0JMSVNUPXkKIyBlbmQgb2YgUkNVIFN1YnN5c3RlbQoKQ09ORklHX0lLQ09ORklHPXkKQ09O RklHX0lLQ09ORklHX1BST0M9eQojIENPTkZJR19JS0hFQURFUlMgaXMgbm90IHNldApDT05GSUdf TE9HX0JVRl9TSElGVD0xNwpDT05GSUdfTE9HX0NQVV9NQVhfQlVGX1NISUZUPTEyCkNPTkZJR19Q UklOVEtfU0FGRV9MT0dfQlVGX1NISUZUPTEzCiMgQ09ORklHX1BSSU5US19JTkRFWCBpcyBub3Qg c2V0CkNPTkZJR19HRU5FUklDX1NDSEVEX0NMT0NLPXkKCiMKIyBTY2hlZHVsZXIgZmVhdHVyZXMK IwojIENPTkZJR19VQ0xBTVBfVEFTSyBpcyBub3Qgc2V0CiMgZW5kIG9mIFNjaGVkdWxlciBmZWF0 dXJlcwoKQ09ORklHX0FSQ0hfU1VQUE9SVFNfTlVNQV9CQUxBTkNJTkc9eQpDT05GSUdfQ0NfSEFT X0lOVDEyOD15CkNPTkZJR19BUkNIX1NVUFBPUlRTX0lOVDEyOD15CkNPTkZJR19DR1JPVVBTPXkK Q09ORklHX1BBR0VfQ09VTlRFUj15CkNPTkZJR19NRU1DRz15CkNPTkZJR19NRU1DR19TV0FQPXkK Q09ORklHX01FTUNHX0tNRU09eQpDT05GSUdfQkxLX0NHUk9VUD15CkNPTkZJR19DR1JPVVBfV1JJ VEVCQUNLPXkKQ09ORklHX0NHUk9VUF9TQ0hFRD15CkNPTkZJR19GQUlSX0dST1VQX1NDSEVEPXkK IyBDT05GSUdfQ0ZTX0JBTkRXSURUSCBpcyBub3Qgc2V0CiMgQ09ORklHX1JUX0dST1VQX1NDSEVE IGlzIG5vdCBzZXQKQ09ORklHX0NHUk9VUF9QSURTPXkKIyBDT05GSUdfQ0dST1VQX1JETUEgaXMg bm90IHNldApDT05GSUdfQ0dST1VQX0ZSRUVaRVI9eQpDT05GSUdfQ1BVU0VUUz15CkNPTkZJR19Q Uk9DX1BJRF9DUFVTRVQ9eQpDT05GSUdfQ0dST1VQX0RFVklDRT15CkNPTkZJR19DR1JPVVBfQ1BV QUNDVD15CkNPTkZJR19DR1JPVVBfUEVSRj15CkNPTkZJR19DR1JPVVBfQlBGPXkKIyBDT05GSUdf Q0dST1VQX01JU0MgaXMgbm90IHNldApDT05GSUdfQ0dST1VQX0RFQlVHPXkKQ09ORklHX1NPQ0tf Q0dST1VQX0RBVEE9eQpDT05GSUdfTkFNRVNQQUNFUz15CkNPTkZJR19VVFNfTlM9eQpDT05GSUdf VElNRV9OUz15CkNPTkZJR19JUENfTlM9eQpDT05GSUdfVVNFUl9OUz15CkNPTkZJR19QSURfTlM9 eQpDT05GSUdfTkVUX05TPXkKIyBDT05GSUdfQ0hFQ0tQT0lOVF9SRVNUT1JFIGlzIG5vdCBzZXQK IyBDT05GSUdfU0NIRURfQVVUT0dST1VQIGlzIG5vdCBzZXQKIyBDT05GSUdfU1lTRlNfREVQUkVD QVRFRCBpcyBub3Qgc2V0CkNPTkZJR19SRUxBWT15CkNPTkZJR19CTEtfREVWX0lOSVRSRD15CkNP TkZJR19JTklUUkFNRlNfU09VUkNFPSIiCkNPTkZJR19SRF9HWklQPXkKQ09ORklHX1JEX0JaSVAy PXkKQ09ORklHX1JEX0xaTUE9eQpDT05GSUdfUkRfWFo9eQpDT05GSUdfUkRfTFpPPXkKQ09ORklH X1JEX0xaND15CkNPTkZJR19SRF9aU1REPXkKIyBDT05GSUdfQk9PVF9DT05GSUcgaXMgbm90IHNl dApDT05GSUdfQ0NfT1BUSU1JWkVfRk9SX1BFUkZPUk1BTkNFPXkKIyBDT05GSUdfQ0NfT1BUSU1J WkVfRk9SX1NJWkUgaXMgbm90IHNldApDT05GSUdfTERfT1JQSEFOX1dBUk49eQpDT05GSUdfU1lT Q1RMPXkKQ09ORklHX0hBVkVfVUlEMTY9eQpDT05GSUdfU1lTQ1RMX0VYQ0VQVElPTl9UUkFDRT15 CkNPTkZJR19FWFBFUlQ9eQpDT05GSUdfVUlEMTY9eQpDT05GSUdfTVVMVElVU0VSPXkKIyBDT05G SUdfU0dFVE1BU0tfU1lTQ0FMTCBpcyBub3Qgc2V0CkNPTkZJR19TWVNGU19TWVNDQUxMPXkKQ09O RklHX0ZIQU5ETEU9eQpDT05GSUdfUE9TSVhfVElNRVJTPXkKQ09ORklHX1BSSU5USz15CkNPTkZJ R19CVUc9eQpDT05GSUdfRUxGX0NPUkU9eQpDT05GSUdfQkFTRV9GVUxMPXkKQ09ORklHX0ZVVEVY PXkKQ09ORklHX0ZVVEVYX1BJPXkKQ09ORklHX0hBVkVfRlVURVhfQ01QWENIRz15CkNPTkZJR19F UE9MTD15CkNPTkZJR19TSUdOQUxGRD15CkNPTkZJR19USU1FUkZEPXkKQ09ORklHX0VWRU5URkQ9 eQpDT05GSUdfU0hNRU09eQpDT05GSUdfQUlPPXkKQ09ORklHX0lPX1VSSU5HPXkKQ09ORklHX0FE VklTRV9TWVNDQUxMUz15CkNPTkZJR19NRU1CQVJSSUVSPXkKQ09ORklHX0tBTExTWU1TPXkKQ09O RklHX0tBTExTWU1TX0FMTD15CkNPTkZJR19LQUxMU1lNU19CQVNFX1JFTEFUSVZFPXkKIyBDT05G SUdfVVNFUkZBVUxURkQgaXMgbm90IHNldApDT05GSUdfQVJDSF9IQVNfTUVNQkFSUklFUl9TWU5D X0NPUkU9eQpDT05GSUdfS0NNUD15CkNPTkZJR19SU0VRPXkKIyBDT05GSUdfREVCVUdfUlNFUSBp cyBub3Qgc2V0CiMgQ09ORklHX0VNQkVEREVEIGlzIG5vdCBzZXQKQ09ORklHX0hBVkVfUEVSRl9F VkVOVFM9eQojIENPTkZJR19QQzEwNCBpcyBub3Qgc2V0CgojCiMgS2VybmVsIFBlcmZvcm1hbmNl IEV2ZW50cyBBbmQgQ291bnRlcnMKIwpDT05GSUdfUEVSRl9FVkVOVFM9eQojIENPTkZJR19ERUJV R19QRVJGX1VTRV9WTUFMTE9DIGlzIG5vdCBzZXQKIyBlbmQgb2YgS2VybmVsIFBlcmZvcm1hbmNl IEV2ZW50cyBBbmQgQ291bnRlcnMKCkNPTkZJR19WTV9FVkVOVF9DT1VOVEVSUz15CkNPTkZJR19T TFVCX0RFQlVHPXkKQ09ORklHX0NPTVBBVF9CUks9eQojIENPTkZJR19TTEFCIGlzIG5vdCBzZXQK Q09ORklHX1NMVUI9eQojIENPTkZJR19TTE9CIGlzIG5vdCBzZXQKQ09ORklHX1NMQUJfTUVSR0Vf REVGQVVMVD15CiMgQ09ORklHX1NMQUJfRlJFRUxJU1RfUkFORE9NIGlzIG5vdCBzZXQKIyBDT05G SUdfU0xBQl9GUkVFTElTVF9IQVJERU5FRCBpcyBub3Qgc2V0CiMgQ09ORklHX1NIVUZGTEVfUEFH RV9BTExPQ0FUT1IgaXMgbm90IHNldApDT05GSUdfU0xVQl9DUFVfUEFSVElBTD15CkNPTkZJR19T WVNURU1fREFUQV9WRVJJRklDQVRJT049eQpDT05GSUdfUFJPRklMSU5HPXkKQ09ORklHX1RSQUNF UE9JTlRTPXkKIyBlbmQgb2YgR2VuZXJhbCBzZXR1cAoKQ09ORklHX0FSTTY0PXkKQ09ORklHXzY0 QklUPXkKQ09ORklHX01NVT15CkNPTkZJR19BUk02NF9QQUdFX1NISUZUPTEyCkNPTkZJR19BUk02 NF9DT05UX1BURV9TSElGVD00CkNPTkZJR19BUk02NF9DT05UX1BNRF9TSElGVD00CkNPTkZJR19B UkNIX01NQVBfUk5EX0JJVFNfTUlOPTE4CkNPTkZJR19BUkNIX01NQVBfUk5EX0JJVFNfTUFYPTI0 CkNPTkZJR19BUkNIX01NQVBfUk5EX0NPTVBBVF9CSVRTX01JTj0xMQpDT05GSUdfQVJDSF9NTUFQ X1JORF9DT01QQVRfQklUU19NQVg9MTYKQ09ORklHX1NUQUNLVFJBQ0VfU1VQUE9SVD15CkNPTkZJ R19JTExFR0FMX1BPSU5URVJfVkFMVUU9MHhkZWFkMDAwMDAwMDAwMDAwCkNPTkZJR19MT0NLREVQ X1NVUFBPUlQ9eQpDT05GSUdfR0VORVJJQ19CVUc9eQpDT05GSUdfR0VORVJJQ19CVUdfUkVMQVRJ VkVfUE9JTlRFUlM9eQpDT05GSUdfR0VORVJJQ19IV0VJR0hUPXkKQ09ORklHX0dFTkVSSUNfQ1NV TT15CkNPTkZJR19HRU5FUklDX0NBTElCUkFURV9ERUxBWT15CkNPTkZJR19BUkNIX01IUF9NRU1N QVBfT05fTUVNT1JZX0VOQUJMRT15CkNPTkZJR19TTVA9eQpDT05GSUdfS0VSTkVMX01PREVfTkVP Tj15CkNPTkZJR19GSVhfRUFSTFlDT05fTUVNPXkKQ09ORklHX1BHVEFCTEVfTEVWRUxTPTMKQ09O RklHX0FSQ0hfU1VQUE9SVFNfVVBST0JFUz15CkNPTkZJR19BUkNIX1BST0NfS0NPUkVfVEVYVD15 CgojCiMgUGxhdGZvcm0gc2VsZWN0aW9uCiMKIyBDT05GSUdfQVJDSF9BQ1RJT05TIGlzIG5vdCBz ZXQKIyBDT05GSUdfQVJDSF9TVU5YSSBpcyBub3Qgc2V0CiMgQ09ORklHX0FSQ0hfQUxQSU5FIGlz IG5vdCBzZXQKIyBDT05GSUdfQVJDSF9BUFBMRSBpcyBub3Qgc2V0CkNPTkZJR19BUkNIX0JDTTI4 MzU9eQojIENPTkZJR19BUkNIX0JDTTQ5MDggaXMgbm90IHNldAojIENPTkZJR19BUkNIX0JDTV9J UFJPQyBpcyBub3Qgc2V0CiMgQ09ORklHX0FSQ0hfQkVSTElOIGlzIG5vdCBzZXQKIyBDT05GSUdf QVJDSF9CSVRNQUlOIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJDSF9CUkNNU1RCIGlzIG5vdCBzZXQK IyBDT05GSUdfQVJDSF9FWFlOT1MgaXMgbm90IHNldAojIENPTkZJR19BUkNIX1NQQVJYNSBpcyBu b3Qgc2V0CiMgQ09ORklHX0FSQ0hfSzMgaXMgbm90IHNldAojIENPTkZJR19BUkNIX0xBWUVSU0NB UEUgaXMgbm90IHNldAojIENPTkZJR19BUkNIX0xHMUsgaXMgbm90IHNldAojIENPTkZJR19BUkNI X0hJU0kgaXMgbm90IHNldAojIENPTkZJR19BUkNIX0tFRU1CQVkgaXMgbm90IHNldAojIENPTkZJ R19BUkNIX01FRElBVEVLIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJDSF9NRVNPTiBpcyBub3Qgc2V0 CiMgQ09ORklHX0FSQ0hfTVZFQlUgaXMgbm90IHNldAojIENPTkZJR19BUkNIX01YQyBpcyBub3Qg c2V0CiMgQ09ORklHX0FSQ0hfUUNPTSBpcyBub3Qgc2V0CiMgQ09ORklHX0FSQ0hfUkVBTFRFSyBp cyBub3Qgc2V0CiMgQ09ORklHX0FSQ0hfUkVORVNBUyBpcyBub3Qgc2V0CiMgQ09ORklHX0FSQ0hf Uk9DS0NISVAgaXMgbm90IHNldAojIENPTkZJR19BUkNIX1MzMiBpcyBub3Qgc2V0CiMgQ09ORklH X0FSQ0hfU0VBVFRMRSBpcyBub3Qgc2V0CiMgQ09ORklHX0FSQ0hfSU5URUxfU09DRlBHQSBpcyBu b3Qgc2V0CiMgQ09ORklHX0FSQ0hfU1lOUVVBQ0VSIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJDSF9U RUdSQSBpcyBub3Qgc2V0CiMgQ09ORklHX0FSQ0hfU1BSRCBpcyBub3Qgc2V0CiMgQ09ORklHX0FS Q0hfVEhVTkRFUiBpcyBub3Qgc2V0CiMgQ09ORklHX0FSQ0hfVEhVTkRFUjIgaXMgbm90IHNldAoj IENPTkZJR19BUkNIX1VOSVBISUVSIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJDSF9WRVhQUkVTUyBp cyBub3Qgc2V0CiMgQ09ORklHX0FSQ0hfVklTQ09OVEkgaXMgbm90IHNldAojIENPTkZJR19BUkNI X1hHRU5FIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJDSF9aWU5RTVAgaXMgbm90IHNldAojIGVuZCBv ZiBQbGF0Zm9ybSBzZWxlY3Rpb24KCiMKIyBLZXJuZWwgRmVhdHVyZXMKIwoKIwojIEFSTSBlcnJh dGEgd29ya2Fyb3VuZHMgdmlhIHRoZSBhbHRlcm5hdGl2ZXMgZnJhbWV3b3JrCiMKQ09ORklHX0FS TTY0X1dPUktBUk9VTkRfQ0xFQU5fQ0FDSEU9eQpDT05GSUdfQVJNNjRfRVJSQVRVTV84MjYzMTk9 eQpDT05GSUdfQVJNNjRfRVJSQVRVTV84MjczMTk9eQpDT05GSUdfQVJNNjRfRVJSQVRVTV84MjQw Njk9eQpDT05GSUdfQVJNNjRfRVJSQVRVTV84MTk0NzI9eQpDT05GSUdfQVJNNjRfRVJSQVRVTV84 MzIwNzU9eQpDT05GSUdfQVJNNjRfRVJSQVRVTV84NDU3MTk9eQpDT05GSUdfQVJNNjRfRVJSQVRV TV84NDM0MTk9eQpDT05GSUdfQVJNNjRfTERfSEFTX0ZJWF9FUlJBVFVNXzg0MzQxOT15CkNPTkZJ R19BUk02NF9FUlJBVFVNXzEwMjQ3MTg9eQpDT05GSUdfQVJNNjRfRVJSQVRVTV8xNDE4MDQwPXkK Q09ORklHX0FSTTY0X1dPUktBUk9VTkRfU1BFQ1VMQVRJVkVfQVQ9eQpDT05GSUdfQVJNNjRfRVJS QVRVTV8xMTY1NTIyPXkKQ09ORklHX0FSTTY0X0VSUkFUVU1fMTMxOTM2Nz15CkNPTkZJR19BUk02 NF9FUlJBVFVNXzE1MzA5MjM9eQpDT05GSUdfQVJNNjRfV09SS0FST1VORF9SRVBFQVRfVExCST15 CkNPTkZJR19BUk02NF9FUlJBVFVNXzEyODY4MDc9eQpDT05GSUdfQVJNNjRfRVJSQVRVTV8xNDYz MjI1PXkKQ09ORklHX0FSTTY0X0VSUkFUVU1fMTU0MjQxOT15CkNPTkZJR19BUk02NF9FUlJBVFVN XzE1MDg0MTI9eQpDT05GSUdfQVJNNjRfRVJSQVRVTV8yNDQxMDA5PXkKQ09ORklHX0FSTTY0X0VS UkFUVU1fMjQ1NzE2OD15CkNPTkZJR19DQVZJVU1fRVJSQVRVTV8yMjM3NT15CkNPTkZJR19DQVZJ VU1fRVJSQVRVTV8yMzE1ND15CkNPTkZJR19DQVZJVU1fRVJSQVRVTV8yNzQ1Nj15CkNPTkZJR19D QVZJVU1fRVJSQVRVTV8zMDExNT15CkNPTkZJR19DQVZJVU1fVFgyX0VSUkFUVU1fMjE5PXkKQ09O RklHX0ZVSklUU1VfRVJSQVRVTV8wMTAwMDE9eQpDT05GSUdfSElTSUxJQ09OX0VSUkFUVU1fMTYx NjAwODAyPXkKQ09ORklHX1FDT01fRkFMS09SX0VSUkFUVU1fMTAwMz15CkNPTkZJR19RQ09NX0ZB TEtPUl9FUlJBVFVNXzEwMDk9eQpDT05GSUdfUUNPTV9RREYyNDAwX0VSUkFUVU1fMDA2NT15CkNP TkZJR19RQ09NX0ZBTEtPUl9FUlJBVFVNX0UxMDQxPXkKQ09ORklHX05WSURJQV9DQVJNRUxfQ05Q X0VSUkFUVU09eQpDT05GSUdfU09DSU9ORVhUX1NZTlFVQUNFUl9QUkVJVFM9eQojIGVuZCBvZiBB Uk0gZXJyYXRhIHdvcmthcm91bmRzIHZpYSB0aGUgYWx0ZXJuYXRpdmVzIGZyYW1ld29yawoKQ09O RklHX0FSTTY0XzRLX1BBR0VTPXkKIyBDT05GSUdfQVJNNjRfMTZLX1BBR0VTIGlzIG5vdCBzZXQK IyBDT05GSUdfQVJNNjRfNjRLX1BBR0VTIGlzIG5vdCBzZXQKQ09ORklHX0FSTTY0X1ZBX0JJVFNf Mzk9eQojIENPTkZJR19BUk02NF9WQV9CSVRTXzQ4IGlzIG5vdCBzZXQKQ09ORklHX0FSTTY0X1ZB X0JJVFM9MzkKQ09ORklHX0FSTTY0X1BBX0JJVFNfNDg9eQpDT05GSUdfQVJNNjRfUEFfQklUUz00 OAojIENPTkZJR19DUFVfQklHX0VORElBTiBpcyBub3Qgc2V0CkNPTkZJR19DUFVfTElUVExFX0VO RElBTj15CiMgQ09ORklHX1NDSEVEX01DIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NIRURfU01UIGlz IG5vdCBzZXQKQ09ORklHX05SX0NQVVM9NApDT05GSUdfSE9UUExVR19DUFU9eQojIENPTkZJR19O VU1BIGlzIG5vdCBzZXQKIyBDT05GSUdfSFpfMTAwIGlzIG5vdCBzZXQKQ09ORklHX0haXzI1MD15 CiMgQ09ORklHX0haXzMwMCBpcyBub3Qgc2V0CiMgQ09ORklHX0haXzEwMDAgaXMgbm90IHNldApD T05GSUdfSFo9MjUwCkNPTkZJR19TQ0hFRF9IUlRJQ0s9eQpDT05GSUdfQVJDSF9TUEFSU0VNRU1f RU5BQkxFPXkKQ09ORklHX0hXX1BFUkZfRVZFTlRTPXkKQ09ORklHX1BBUkFWSVJUPXkKQ09ORklH X1BBUkFWSVJUX1RJTUVfQUNDT1VOVElORz15CiMgQ09ORklHX0tFWEVDIGlzIG5vdCBzZXQKIyBD T05GSUdfS0VYRUNfRklMRSBpcyBub3Qgc2V0CiMgQ09ORklHX0NSQVNIX0RVTVAgaXMgbm90IHNl dApDT05GSUdfWEVOX0RPTTA9eQpDT05GSUdfWEVOPXkKQ09ORklHX0ZPUkNFX01BWF9aT05FT1JE RVI9MTEKQ09ORklHX1VOTUFQX0tFUk5FTF9BVF9FTDA9eQpDT05GSUdfTUlUSUdBVEVfU1BFQ1RS RV9CUkFOQ0hfSElTVE9SWT15CkNPTkZJR19ST0RBVEFfRlVMTF9ERUZBVUxUX0VOQUJMRUQ9eQoj IENPTkZJR19BUk02NF9TV19UVEJSMF9QQU4gaXMgbm90IHNldApDT05GSUdfQVJNNjRfVEFHR0VE X0FERFJfQUJJPXkKQ09ORklHX0NPTVBBVD15CkNPTkZJR19LVVNFUl9IRUxQRVJTPXkKIyBDT05G SUdfQVJNVjhfREVQUkVDQVRFRCBpcyBub3Qgc2V0CgojCiMgQVJNdjguMSBhcmNoaXRlY3R1cmFs IGZlYXR1cmVzCiMKQ09ORklHX0FSTTY0X0hXX0FGREJNPXkKQ09ORklHX0FSTTY0X1BBTj15CkNP TkZJR19BU19IQVNfTERBUFI9eQpDT05GSUdfQVNfSEFTX0xTRV9BVE9NSUNTPXkKIyBlbmQgb2Yg QVJNdjguMSBhcmNoaXRlY3R1cmFsIGZlYXR1cmVzCgojCiMgQVJNdjguMiBhcmNoaXRlY3R1cmFs IGZlYXR1cmVzCiMKIyBDT05GSUdfQVJNNjRfUE1FTSBpcyBub3Qgc2V0CkNPTkZJR19BUk02NF9S QVNfRVhUTj15CkNPTkZJR19BUk02NF9DTlA9eQojIGVuZCBvZiBBUk12OC4yIGFyY2hpdGVjdHVy YWwgZmVhdHVyZXMKCiMKIyBBUk12OC4zIGFyY2hpdGVjdHVyYWwgZmVhdHVyZXMKIwpDT05GSUdf QVJNNjRfUFRSX0FVVEg9eQpDT05GSUdfQVJNNjRfUFRSX0FVVEhfS0VSTkVMPXkKQ09ORklHX0ND X0hBU19CUkFOQ0hfUFJPVF9QQUNfUkVUPXkKQ09ORklHX0NDX0hBU19TSUdOX1JFVFVSTl9BRERS RVNTPXkKQ09ORklHX0FTX0hBU19QQUM9eQpDT05GSUdfQVNfSEFTX0NGSV9ORUdBVEVfUkFfU1RB VEU9eQojIGVuZCBvZiBBUk12OC4zIGFyY2hpdGVjdHVyYWwgZmVhdHVyZXMKCiMKIyBBUk12OC40 IGFyY2hpdGVjdHVyYWwgZmVhdHVyZXMKIwpDT05GSUdfQVJNNjRfQU1VX0VYVE49eQpDT05GSUdf QVNfSEFTX0FSTVY4XzQ9eQpDT05GSUdfQVJNNjRfVExCX1JBTkdFPXkKIyBlbmQgb2YgQVJNdjgu NCBhcmNoaXRlY3R1cmFsIGZlYXR1cmVzCgojCiMgQVJNdjguNSBhcmNoaXRlY3R1cmFsIGZlYXR1 cmVzCiMKQ09ORklHX0FTX0hBU19BUk1WOF81PXkKQ09ORklHX0FSTTY0X0JUST15CkNPTkZJR19D Q19IQVNfQlJBTkNIX1BST1RfUEFDX1JFVF9CVEk9eQpDT05GSUdfQVJNNjRfRTBQRD15CkNPTkZJ R19BUkNIX1JBTkRPTT15CkNPTkZJR19BUk02NF9BU19IQVNfTVRFPXkKQ09ORklHX0FSTTY0X01U RT15CiMgZW5kIG9mIEFSTXY4LjUgYXJjaGl0ZWN0dXJhbCBmZWF0dXJlcwoKIwojIEFSTXY4Ljcg YXJjaGl0ZWN0dXJhbCBmZWF0dXJlcwojCkNPTkZJR19BUk02NF9FUEFOPXkKIyBlbmQgb2YgQVJN djguNyBhcmNoaXRlY3R1cmFsIGZlYXR1cmVzCgpDT05GSUdfQVJNNjRfU1ZFPXkKQ09ORklHX0FS TTY0X01PRFVMRV9QTFRTPXkKIyBDT05GSUdfQVJNNjRfUFNFVURPX05NSSBpcyBub3Qgc2V0CkNP TkZJR19SRUxPQ0FUQUJMRT15CiMgQ09ORklHX1JBTkRPTUlaRV9CQVNFIGlzIG5vdCBzZXQKQ09O RklHX0NDX0hBVkVfU1RBQ0tQUk9URUNUT1JfU1lTUkVHPXkKQ09ORklHX1NUQUNLUFJPVEVDVE9S X1BFUl9UQVNLPXkKIyBlbmQgb2YgS2VybmVsIEZlYXR1cmVzCgojCiMgQm9vdCBvcHRpb25zCiMK Q09ORklHX0NNRExJTkU9IiIKQ09ORklHX0VGSV9TVFVCPXkKQ09ORklHX0VGST15CkNPTkZJR19E TUk9eQojIGVuZCBvZiBCb290IG9wdGlvbnMKCkNPTkZJR19TWVNWSVBDX0NPTVBBVD15CgojCiMg UG93ZXIgbWFuYWdlbWVudCBvcHRpb25zCiMKQ09ORklHX1NVU1BFTkQ9eQpDT05GSUdfU1VTUEVO RF9GUkVFWkVSPXkKIyBDT05GSUdfU1VTUEVORF9TS0lQX1NZTkMgaXMgbm90IHNldAojIENPTkZJ R19ISUJFUk5BVElPTiBpcyBub3Qgc2V0CkNPTkZJR19QTV9TTEVFUD15CkNPTkZJR19QTV9TTEVF UF9TTVA9eQojIENPTkZJR19QTV9BVVRPU0xFRVAgaXMgbm90IHNldAojIENPTkZJR19QTV9XQUtF TE9DS1MgaXMgbm90IHNldApDT05GSUdfUE09eQojIENPTkZJR19QTV9ERUJVRyBpcyBub3Qgc2V0 CkNPTkZJR19QTV9DTEs9eQpDT05GSUdfUE1fR0VORVJJQ19ET01BSU5TPXkKIyBDT05GSUdfV1Ff UE9XRVJfRUZGSUNJRU5UX0RFRkFVTFQgaXMgbm90IHNldApDT05GSUdfUE1fR0VORVJJQ19ET01B SU5TX1NMRUVQPXkKQ09ORklHX1BNX0dFTkVSSUNfRE9NQUlOU19PRj15CkNPTkZJR19DUFVfUE09 eQojIENPTkZJR19FTkVSR1lfTU9ERUwgaXMgbm90IHNldApDT05GSUdfQVJDSF9ISUJFUk5BVElP Tl9QT1NTSUJMRT15CkNPTkZJR19BUkNIX1NVU1BFTkRfUE9TU0lCTEU9eQojIGVuZCBvZiBQb3dl ciBtYW5hZ2VtZW50IG9wdGlvbnMKCiMKIyBDUFUgUG93ZXIgTWFuYWdlbWVudAojCgojCiMgQ1BV IElkbGUKIwpDT05GSUdfQ1BVX0lETEU9eQpDT05GSUdfQ1BVX0lETEVfTVVMVElQTEVfRFJJVkVS Uz15CkNPTkZJR19DUFVfSURMRV9HT1ZfTEFEREVSPXkKQ09ORklHX0NQVV9JRExFX0dPVl9NRU5V PXkKIyBDT05GSUdfQ1BVX0lETEVfR09WX1RFTyBpcyBub3Qgc2V0CkNPTkZJR19EVF9JRExFX1NU QVRFUz15CgojCiMgQVJNIENQVSBJZGxlIERyaXZlcnMKIwpDT05GSUdfQVJNX0NQVUlETEU9eQoj IENPTkZJR19BUk1fUFNDSV9DUFVJRExFIGlzIG5vdCBzZXQKIyBlbmQgb2YgQVJNIENQVSBJZGxl IERyaXZlcnMKIyBlbmQgb2YgQ1BVIElkbGUKCiMKIyBDUFUgRnJlcXVlbmN5IHNjYWxpbmcKIwpD T05GSUdfQ1BVX0ZSRVE9eQpDT05GSUdfQ1BVX0ZSRVFfR09WX0FUVFJfU0VUPXkKQ09ORklHX0NQ VV9GUkVRX0dPVl9DT01NT049eQpDT05GSUdfQ1BVX0ZSRVFfU1RBVD15CiMgQ09ORklHX0NQVV9G UkVRX0RFRkFVTFRfR09WX1BFUkZPUk1BTkNFIGlzIG5vdCBzZXQKQ09ORklHX0NQVV9GUkVRX0RF RkFVTFRfR09WX1BPV0VSU0FWRT15CiMgQ09ORklHX0NQVV9GUkVRX0RFRkFVTFRfR09WX1VTRVJT UEFDRSBpcyBub3Qgc2V0CiMgQ09ORklHX0NQVV9GUkVRX0RFRkFVTFRfR09WX09OREVNQU5EIGlz IG5vdCBzZXQKIyBDT05GSUdfQ1BVX0ZSRVFfREVGQVVMVF9HT1ZfQ09OU0VSVkFUSVZFIGlzIG5v dCBzZXQKIyBDT05GSUdfQ1BVX0ZSRVFfREVGQVVMVF9HT1ZfU0NIRURVVElMIGlzIG5vdCBzZXQK Q09ORklHX0NQVV9GUkVRX0dPVl9QRVJGT1JNQU5DRT15CkNPTkZJR19DUFVfRlJFUV9HT1ZfUE9X RVJTQVZFPXkKQ09ORklHX0NQVV9GUkVRX0dPVl9VU0VSU1BBQ0U9eQpDT05GSUdfQ1BVX0ZSRVFf R09WX09OREVNQU5EPXkKQ09ORklHX0NQVV9GUkVRX0dPVl9DT05TRVJWQVRJVkU9eQpDT05GSUdf Q1BVX0ZSRVFfR09WX1NDSEVEVVRJTD15CgojCiMgQ1BVIGZyZXF1ZW5jeSBzY2FsaW5nIGRyaXZl cnMKIwpDT05GSUdfQ1BVRlJFUV9EVD15CkNPTkZJR19DUFVGUkVRX0RUX1BMQVRERVY9eQpDT05G SUdfQVJNX1JBU1BCRVJSWVBJX0NQVUZSRVE9eQojIGVuZCBvZiBDUFUgRnJlcXVlbmN5IHNjYWxp bmcKIyBlbmQgb2YgQ1BVIFBvd2VyIE1hbmFnZW1lbnQKCkNPTkZJR19BUkNIX1NVUFBPUlRTX0FD UEk9eQojIENPTkZJR19BQ1BJIGlzIG5vdCBzZXQKIyBDT05GSUdfVklSVFVBTElaQVRJT04gaXMg bm90IHNldAojIENPTkZJR19BUk02NF9DUllQVE8gaXMgbm90IHNldAoKIwojIEdlbmVyYWwgYXJj aGl0ZWN0dXJlLWRlcGVuZGVudCBvcHRpb25zCiMKQ09ORklHX0NSQVNIX0NPUkU9eQpDT05GSUdf S1BST0JFUz15CiMgQ09ORklHX0pVTVBfTEFCRUwgaXMgbm90IHNldApDT05GSUdfVVBST0JFUz15 CkNPTkZJR19IQVZFX0VGRklDSUVOVF9VTkFMSUdORURfQUNDRVNTPXkKQ09ORklHX0tSRVRQUk9C RVM9eQpDT05GSUdfSEFWRV9LUFJPQkVTPXkKQ09ORklHX0hBVkVfS1JFVFBST0JFUz15CkNPTkZJ R19IQVZFX0ZVTkNUSU9OX0VSUk9SX0lOSkVDVElPTj15CkNPTkZJR19IQVZFX05NST15CkNPTkZJ R19UUkFDRV9JUlFGTEFHU19TVVBQT1JUPXkKQ09ORklHX1RSQUNFX0lSUUZMQUdTX05NSV9TVVBQ T1JUPXkKQ09ORklHX0hBVkVfQVJDSF9UUkFDRUhPT0s9eQpDT05GSUdfSEFWRV9ETUFfQ09OVElH VU9VUz15CkNPTkZJR19HRU5FUklDX1NNUF9JRExFX1RIUkVBRD15CkNPTkZJR19HRU5FUklDX0lE TEVfUE9MTF9TRVRVUD15CkNPTkZJR19BUkNIX0hBU19GT1JUSUZZX1NPVVJDRT15CkNPTkZJR19B UkNIX0hBU19LRUVQSU5JVFJEPXkKQ09ORklHX0FSQ0hfSEFTX1NFVF9NRU1PUlk9eQpDT05GSUdf QVJDSF9IQVNfU0VUX0RJUkVDVF9NQVA9eQpDT05GSUdfSEFWRV9BUkNIX1RIUkVBRF9TVFJVQ1Rf V0hJVEVMSVNUPXkKQ09ORklHX0FSQ0hfV0FOVFNfTk9fSU5TVFI9eQpDT05GSUdfSEFWRV9BU01f TU9EVkVSU0lPTlM9eQpDT05GSUdfSEFWRV9SRUdTX0FORF9TVEFDS19BQ0NFU1NfQVBJPXkKQ09O RklHX0hBVkVfUlNFUT15CkNPTkZJR19IQVZFX0ZVTkNUSU9OX0FSR19BQ0NFU1NfQVBJPXkKQ09O RklHX0hBVkVfSFdfQlJFQUtQT0lOVD15CkNPTkZJR19IQVZFX1BFUkZfUkVHUz15CkNPTkZJR19I QVZFX1BFUkZfVVNFUl9TVEFDS19EVU1QPXkKQ09ORklHX0hBVkVfQVJDSF9KVU1QX0xBQkVMPXkK Q09ORklHX0hBVkVfQVJDSF9KVU1QX0xBQkVMX1JFTEFUSVZFPXkKQ09ORklHX01NVV9HQVRIRVJf VEFCTEVfRlJFRT15CkNPTkZJR19NTVVfR0FUSEVSX1JDVV9UQUJMRV9GUkVFPXkKQ09ORklHX0FS Q0hfSEFWRV9OTUlfU0FGRV9DTVBYQ0hHPXkKQ09ORklHX0hBVkVfQUxJR05FRF9TVFJVQ1RfUEFH RT15CkNPTkZJR19IQVZFX0NNUFhDSEdfTE9DQUw9eQpDT05GSUdfSEFWRV9DTVBYQ0hHX0RPVUJM RT15CkNPTkZJR19BUkNIX1dBTlRfQ09NUEFUX0lQQ19QQVJTRV9WRVJTSU9OPXkKQ09ORklHX0hB VkVfQVJDSF9TRUNDT01QPXkKQ09ORklHX0hBVkVfQVJDSF9TRUNDT01QX0ZJTFRFUj15CkNPTkZJ R19TRUNDT01QPXkKQ09ORklHX1NFQ0NPTVBfRklMVEVSPXkKIyBDT05GSUdfU0VDQ09NUF9DQUNI RV9ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19IQVZFX0FSQ0hfU1RBQ0tMRUFLPXkKQ09ORklHX0hB VkVfU1RBQ0tQUk9URUNUT1I9eQpDT05GSUdfU1RBQ0tQUk9URUNUT1I9eQpDT05GSUdfU1RBQ0tQ Uk9URUNUT1JfU1RST05HPXkKQ09ORklHX0FSQ0hfU1VQUE9SVFNfTFRPX0NMQU5HPXkKQ09ORklH X0FSQ0hfU1VQUE9SVFNfTFRPX0NMQU5HX1RISU49eQpDT05GSUdfTFRPX05PTkU9eQpDT05GSUdf QVJDSF9TVVBQT1JUU19DRklfQ0xBTkc9eQpDT05GSUdfSEFWRV9DT05URVhUX1RSQUNLSU5HPXkK Q09ORklHX0hBVkVfVklSVF9DUFVfQUNDT1VOVElOR19HRU49eQpDT05GSUdfSEFWRV9JUlFfVElN RV9BQ0NPVU5USU5HPXkKQ09ORklHX0hBVkVfTU9WRV9QVUQ9eQpDT05GSUdfSEFWRV9NT1ZFX1BN RD15CkNPTkZJR19IQVZFX0FSQ0hfVFJBTlNQQVJFTlRfSFVHRVBBR0U9eQpDT05GSUdfSEFWRV9B UkNIX0hVR0VfVk1BUD15CkNPTkZJR19BUkNIX1dBTlRfSFVHRV9QTURfU0hBUkU9eQpDT05GSUdf SEFWRV9NT0RfQVJDSF9TUEVDSUZJQz15CkNPTkZJR19NT0RVTEVTX1VTRV9FTEZfUkVMQT15CkNP TkZJR19BUkNIX0hBU19FTEZfUkFORE9NSVpFPXkKQ09ORklHX0hBVkVfQVJDSF9NTUFQX1JORF9C SVRTPXkKQ09ORklHX0FSQ0hfTU1BUF9STkRfQklUUz0xOApDT05GSUdfSEFWRV9BUkNIX01NQVBf Uk5EX0NPTVBBVF9CSVRTPXkKQ09ORklHX0FSQ0hfTU1BUF9STkRfQ09NUEFUX0JJVFM9MTEKQ09O RklHX0FSQ0hfV0FOVF9ERUZBVUxUX1RPUERPV05fTU1BUF9MQVlPVVQ9eQpDT05GSUdfQ0xPTkVf QkFDS1dBUkRTPXkKQ09ORklHX09MRF9TSUdTVVNQRU5EMz15CkNPTkZJR19DT01QQVRfT0xEX1NJ R0FDVElPTj15CkNPTkZJR19DT01QQVRfMzJCSVRfVElNRT15CkNPTkZJR19IQVZFX0FSQ0hfVk1B UF9TVEFDSz15CkNPTkZJR19WTUFQX1NUQUNLPXkKQ09ORklHX0hBVkVfQVJDSF9SQU5ET01JWkVf S1NUQUNLX09GRlNFVD15CiMgQ09ORklHX1JBTkRPTUlaRV9LU1RBQ0tfT0ZGU0VUX0RFRkFVTFQg aXMgbm90IHNldApDT05GSUdfQVJDSF9IQVNfU1RSSUNUX0tFUk5FTF9SV1g9eQpDT05GSUdfU1RS SUNUX0tFUk5FTF9SV1g9eQpDT05GSUdfQVJDSF9IQVNfU1RSSUNUX01PRFVMRV9SV1g9eQpDT05G SUdfU1RSSUNUX01PRFVMRV9SV1g9eQpDT05GSUdfSEFWRV9BUkNIX0NPTVBJTEVSX0g9eQpDT05G SUdfSEFWRV9BUkNIX1BSRUwzMl9SRUxPQ0FUSU9OUz15CkNPTkZJR19BUkNIX1VTRV9NRU1SRU1B UF9QUk9UPXkKIyBDT05GSUdfTE9DS19FVkVOVF9DT1VOVFMgaXMgbm90IHNldApDT05GSUdfQVJD SF9IQVNfUkVMUj15CkNPTkZJR19BUkNIX1dBTlRfTERfT1JQSEFOX1dBUk49eQpDT05GSUdfQVJD SF9TVVBQT1JUU19ERUJVR19QQUdFQUxMT0M9eQoKIwojIEdDT1YtYmFzZWQga2VybmVsIHByb2Zp bGluZwojCiMgQ09ORklHX0dDT1ZfS0VSTkVMIGlzIG5vdCBzZXQKQ09ORklHX0FSQ0hfSEFTX0dD T1ZfUFJPRklMRV9BTEw9eQojIGVuZCBvZiBHQ09WLWJhc2VkIGtlcm5lbCBwcm9maWxpbmcKCkNP TkZJR19IQVZFX0dDQ19QTFVHSU5TPXkKQ09ORklHX0dDQ19QTFVHSU5TPXkKIyBDT05GSUdfR0ND X1BMVUdJTl9DWUNfQ09NUExFWElUWSBpcyBub3Qgc2V0CiMgQ09ORklHX0dDQ19QTFVHSU5fTEFU RU5UX0VOVFJPUFkgaXMgbm90IHNldAojIENPTkZJR19HQ0NfUExVR0lOX1JBTkRTVFJVQ1QgaXMg bm90IHNldAojIGVuZCBvZiBHZW5lcmFsIGFyY2hpdGVjdHVyZS1kZXBlbmRlbnQgb3B0aW9ucwoK Q09ORklHX1JUX01VVEVYRVM9eQpDT05GSUdfQkFTRV9TTUFMTD0wCkNPTkZJR19NT0RVTEVTPXkK IyBDT05GSUdfTU9EVUxFX0ZPUkNFX0xPQUQgaXMgbm90IHNldApDT05GSUdfTU9EVUxFX1VOTE9B RD15CiMgQ09ORklHX01PRFVMRV9GT1JDRV9VTkxPQUQgaXMgbm90IHNldAojIENPTkZJR19NT0RW RVJTSU9OUyBpcyBub3Qgc2V0CiMgQ09ORklHX01PRFVMRV9TUkNWRVJTSU9OX0FMTCBpcyBub3Qg c2V0CiMgQ09ORklHX01PRFVMRV9TSUcgaXMgbm90IHNldApDT05GSUdfTU9EVUxFX0NPTVBSRVNT X05PTkU9eQojIENPTkZJR19NT0RVTEVfQ09NUFJFU1NfR1pJUCBpcyBub3Qgc2V0CiMgQ09ORklH X01PRFVMRV9DT01QUkVTU19YWiBpcyBub3Qgc2V0CiMgQ09ORklHX01PRFVMRV9DT01QUkVTU19a U1REIGlzIG5vdCBzZXQKIyBDT05GSUdfTU9EVUxFX0FMTE9XX01JU1NJTkdfTkFNRVNQQUNFX0lN UE9SVFMgaXMgbm90IHNldApDT05GSUdfTU9EUFJPQkVfUEFUSD0iL3NiaW4vbW9kcHJvYmUiCiMg Q09ORklHX1RSSU1fVU5VU0VEX0tTWU1TIGlzIG5vdCBzZXQKQ09ORklHX01PRFVMRVNfVFJFRV9M T09LVVA9eQpDT05GSUdfQkxPQ0s9eQpDT05GSUdfQkxLX0RFVl9CU0dfQ09NTU9OPXkKIyBDT05G SUdfQkxLX0RFVl9CU0dMSUIgaXMgbm90IHNldAojIENPTkZJR19CTEtfREVWX0lOVEVHUklUWSBp cyBub3Qgc2V0CiMgQ09ORklHX0JMS19ERVZfWk9ORUQgaXMgbm90IHNldAojIENPTkZJR19CTEtf REVWX1RIUk9UVExJTkcgaXMgbm90IHNldAojIENPTkZJR19CTEtfV0JUIGlzIG5vdCBzZXQKIyBD T05GSUdfQkxLX0NHUk9VUF9JT0xBVEVOQ1kgaXMgbm90IHNldAojIENPTkZJR19CTEtfQ0dST1VQ X0lPQ09TVCBpcyBub3Qgc2V0CiMgQ09ORklHX0JMS19DR1JPVVBfSU9QUklPIGlzIG5vdCBzZXQK Q09ORklHX0JMS19ERUJVR19GUz15CiMgQ09ORklHX0JMS19TRURfT1BBTCBpcyBub3Qgc2V0CiMg Q09ORklHX0JMS19JTkxJTkVfRU5DUllQVElPTiBpcyBub3Qgc2V0CgojCiMgUGFydGl0aW9uIFR5 cGVzCiMKIyBDT05GSUdfUEFSVElUSU9OX0FEVkFOQ0VEIGlzIG5vdCBzZXQKQ09ORklHX01TRE9T X1BBUlRJVElPTj15CkNPTkZJR19FRklfUEFSVElUSU9OPXkKIyBlbmQgb2YgUGFydGl0aW9uIFR5 cGVzCgpDT05GSUdfQkxPQ0tfQ09NUEFUPXkKQ09ORklHX0JMS19NUV9QQ0k9eQpDT05GSUdfQkxL X01RX1ZJUlRJTz15CkNPTkZJR19CTEtfUE09eQpDT05GSUdfQkxPQ0tfSE9MREVSX0RFUFJFQ0FU RUQ9eQoKIwojIElPIFNjaGVkdWxlcnMKIwpDT05GSUdfTVFfSU9TQ0hFRF9ERUFETElORT15CkNP TkZJR19NUV9JT1NDSEVEX0tZQkVSPXkKIyBDT05GSUdfSU9TQ0hFRF9CRlEgaXMgbm90IHNldAoj IGVuZCBvZiBJTyBTY2hlZHVsZXJzCgpDT05GSUdfQVNOMT15CkNPTkZJR19VTklOTElORV9TUElO X1VOTE9DSz15CkNPTkZJR19BUkNIX1NVUFBPUlRTX0FUT01JQ19STVc9eQpDT05GSUdfTVVURVhf U1BJTl9PTl9PV05FUj15CkNPTkZJR19SV1NFTV9TUElOX09OX09XTkVSPXkKQ09ORklHX0xPQ0tf U1BJTl9PTl9PV05FUj15CkNPTkZJR19BUkNIX1VTRV9RVUVVRURfU1BJTkxPQ0tTPXkKQ09ORklH X1FVRVVFRF9TUElOTE9DS1M9eQpDT05GSUdfQVJDSF9VU0VfUVVFVUVEX1JXTE9DS1M9eQpDT05G SUdfUVVFVUVEX1JXTE9DS1M9eQpDT05GSUdfQVJDSF9IQVNfTk9OX09WRVJMQVBQSU5HX0FERFJF U1NfU1BBQ0U9eQpDT05GSUdfQVJDSF9IQVNfU1lTQ0FMTF9XUkFQUEVSPXkKQ09ORklHX0ZSRUVa RVI9eQoKIwojIEV4ZWN1dGFibGUgZmlsZSBmb3JtYXRzCiMKQ09ORklHX0JJTkZNVF9FTEY9eQpD T05GSUdfQ09NUEFUX0JJTkZNVF9FTEY9eQpDT05GSUdfQVJDSF9CSU5GTVRfRUxGX1NUQVRFPXkK Q09ORklHX0FSQ0hfSEFWRV9FTEZfUFJPVD15CkNPTkZJR19BUkNIX1VTRV9HTlVfUFJPUEVSVFk9 eQpDT05GSUdfRUxGQ09SRT15CkNPTkZJR19DT1JFX0RVTVBfREVGQVVMVF9FTEZfSEVBREVSUz15 CkNPTkZJR19CSU5GTVRfU0NSSVBUPXkKQ09ORklHX0JJTkZNVF9NSVNDPW0KQ09ORklHX0NPUkVE VU1QPXkKIyBlbmQgb2YgRXhlY3V0YWJsZSBmaWxlIGZvcm1hdHMKCiMKIyBNZW1vcnkgTWFuYWdl bWVudCBvcHRpb25zCiMKQ09ORklHX1NQQVJTRU1FTT15CkNPTkZJR19TUEFSU0VNRU1fRVhUUkVN RT15CkNPTkZJR19TUEFSU0VNRU1fVk1FTU1BUF9FTkFCTEU9eQpDT05GSUdfU1BBUlNFTUVNX1ZN RU1NQVA9eQpDT05GSUdfSEFWRV9GQVNUX0dVUD15CkNPTkZJR19BUkNIX0tFRVBfTUVNQkxPQ0s9 eQpDT05GSUdfTUVNT1JZX0lTT0xBVElPTj15CkNPTkZJR19BUkNIX0VOQUJMRV9NRU1PUllfSE9U UExVRz15CiMgQ09ORklHX01FTU9SWV9IT1RQTFVHIGlzIG5vdCBzZXQKQ09ORklHX0FSQ0hfRU5B QkxFX01FTU9SWV9IT1RSRU1PVkU9eQpDT05GSUdfU1BMSVRfUFRMT0NLX0NQVVM9NApDT05GSUdf QVJDSF9FTkFCTEVfU1BMSVRfUE1EX1BUTE9DSz15CkNPTkZJR19DT01QQUNUSU9OPXkKIyBDT05G SUdfUEFHRV9SRVBPUlRJTkcgaXMgbm90IHNldApDT05GSUdfTUlHUkFUSU9OPXkKQ09ORklHX0NP TlRJR19BTExPQz15CkNPTkZJR19QSFlTX0FERFJfVF82NEJJVD15CkNPTkZJR19NTVVfTk9USUZJ RVI9eQojIENPTkZJR19LU00gaXMgbm90IHNldApDT05GSUdfREVGQVVMVF9NTUFQX01JTl9BRERS PTQwOTYKQ09ORklHX0FSQ0hfU1VQUE9SVFNfTUVNT1JZX0ZBSUxVUkU9eQojIENPTkZJR19NRU1P UllfRkFJTFVSRSBpcyBub3Qgc2V0CiMgQ09ORklHX1RSQU5TUEFSRU5UX0hVR0VQQUdFIGlzIG5v dCBzZXQKIyBDT05GSUdfQ0xFQU5DQUNIRSBpcyBub3Qgc2V0CiMgQ09ORklHX0ZST05UU1dBUCBp cyBub3Qgc2V0CkNPTkZJR19DTUE9eQojIENPTkZJR19DTUFfREVCVUcgaXMgbm90IHNldAojIENP TkZJR19DTUFfREVCVUdGUyBpcyBub3Qgc2V0CiMgQ09ORklHX0NNQV9TWVNGUyBpcyBub3Qgc2V0 CkNPTkZJR19DTUFfQVJFQVM9NwojIENPTkZJR19aUE9PTCBpcyBub3Qgc2V0CiMgQ09ORklHX1pT TUFMTE9DIGlzIG5vdCBzZXQKQ09ORklHX0dFTkVSSUNfRUFSTFlfSU9SRU1BUD15CiMgQ09ORklH X0RFRkVSUkVEX1NUUlVDVF9QQUdFX0lOSVQgaXMgbm90IHNldAojIENPTkZJR19JRExFX1BBR0Vf VFJBQ0tJTkcgaXMgbm90IHNldApDT05GSUdfQVJDSF9IQVNfQ0FDSEVfTElORV9TSVpFPXkKQ09O RklHX0FSQ0hfSEFTX1BURV9ERVZNQVA9eQpDT05GSUdfQVJDSF9IQVNfWk9ORV9ETUFfU0VUPXkK Q09ORklHX1pPTkVfRE1BPXkKQ09ORklHX1pPTkVfRE1BMzI9eQpDT05GSUdfQVJDSF9VU0VTX0hJ R0hfVk1BX0ZMQUdTPXkKIyBDT05GSUdfUEVSQ1BVX1NUQVRTIGlzIG5vdCBzZXQKIyBDT05GSUdf R1VQX1RFU1QgaXMgbm90IHNldApDT05GSUdfQVJDSF9IQVNfUFRFX1NQRUNJQUw9eQpDT05GSUdf U0VDUkVUTUVNPXkKCiMKIyBEYXRhIEFjY2VzcyBNb25pdG9yaW5nCiMKIyBDT05GSUdfREFNT04g aXMgbm90IHNldAojIGVuZCBvZiBEYXRhIEFjY2VzcyBNb25pdG9yaW5nCiMgZW5kIG9mIE1lbW9y eSBNYW5hZ2VtZW50IG9wdGlvbnMKCkNPTkZJR19ORVQ9eQpDT05GSUdfQ09NUEFUX05FVExJTktf TUVTU0FHRVM9eQpDT05GSUdfTkVUX0lOR1JFU1M9eQpDT05GSUdfTkVUX0VHUkVTUz15CkNPTkZJ R19TS0JfRVhURU5TSU9OUz15CgojCiMgTmV0d29ya2luZyBvcHRpb25zCiMKQ09ORklHX1BBQ0tF VD15CiMgQ09ORklHX1BBQ0tFVF9ESUFHIGlzIG5vdCBzZXQKQ09ORklHX1VOSVg9eQpDT05GSUdf VU5JWF9TQ009eQpDT05GSUdfQUZfVU5JWF9PT0I9eQojIENPTkZJR19VTklYX0RJQUcgaXMgbm90 IHNldAojIENPTkZJR19UTFMgaXMgbm90IHNldApDT05GSUdfWEZSTT15CkNPTkZJR19YRlJNX0FM R089eQpDT05GSUdfWEZSTV9VU0VSPW0KIyBDT05GSUdfWEZSTV9JTlRFUkZBQ0UgaXMgbm90IHNl dApDT05GSUdfWEZSTV9TVUJfUE9MSUNZPXkKQ09ORklHX1hGUk1fTUlHUkFURT15CiMgQ09ORklH X1hGUk1fU1RBVElTVElDUyBpcyBub3Qgc2V0CkNPTkZJR19YRlJNX0FIPXkKQ09ORklHX1hGUk1f RVNQPXkKQ09ORklHX1hGUk1fSVBDT01QPW0KQ09ORklHX05FVF9LRVk9bQpDT05GSUdfTkVUX0tF WV9NSUdSQVRFPXkKIyBDT05GSUdfWERQX1NPQ0tFVFMgaXMgbm90IHNldApDT05GSUdfSU5FVD15 CkNPTkZJR19JUF9NVUxUSUNBU1Q9eQpDT05GSUdfSVBfQURWQU5DRURfUk9VVEVSPXkKIyBDT05G SUdfSVBfRklCX1RSSUVfU1RBVFMgaXMgbm90IHNldApDT05GSUdfSVBfTVVMVElQTEVfVEFCTEVT PXkKQ09ORklHX0lQX1JPVVRFX01VTFRJUEFUSD15CkNPTkZJR19JUF9ST1VURV9WRVJCT1NFPXkK Q09ORklHX0lQX1JPVVRFX0NMQVNTSUQ9eQpDT05GSUdfSVBfUE5QPXkKQ09ORklHX0lQX1BOUF9E SENQPXkKQ09ORklHX0lQX1BOUF9CT09UUD15CkNPTkZJR19JUF9QTlBfUkFSUD15CkNPTkZJR19O RVRfSVBJUD1tCkNPTkZJR19ORVRfSVBHUkVfREVNVVg9bQpDT05GSUdfTkVUX0lQX1RVTk5FTD15 CkNPTkZJR19ORVRfSVBHUkU9bQpDT05GSUdfTkVUX0lQR1JFX0JST0FEQ0FTVD15CkNPTkZJR19J UF9NUk9VVEVfQ09NTU9OPXkKQ09ORklHX0lQX01ST1VURT15CiMgQ09ORklHX0lQX01ST1VURV9N VUxUSVBMRV9UQUJMRVMgaXMgbm90IHNldApDT05GSUdfSVBfUElNU01fVjE9eQpDT05GSUdfSVBf UElNU01fVjI9eQpDT05GSUdfU1lOX0NPT0tJRVM9eQojIENPTkZJR19ORVRfSVBWVEkgaXMgbm90 IHNldApDT05GSUdfTkVUX1VEUF9UVU5ORUw9bQojIENPTkZJR19ORVRfRk9VIGlzIG5vdCBzZXQK IyBDT05GSUdfTkVUX0ZPVV9JUF9UVU5ORUxTIGlzIG5vdCBzZXQKQ09ORklHX0lORVRfQUg9bQpD T05GSUdfSU5FVF9FU1A9bQojIENPTkZJR19JTkVUX0VTUF9PRkZMT0FEIGlzIG5vdCBzZXQKIyBD T05GSUdfSU5FVF9FU1BJTlRDUCBpcyBub3Qgc2V0CkNPTkZJR19JTkVUX0lQQ09NUD1tCkNPTkZJ R19JTkVUX1hGUk1fVFVOTkVMPW0KQ09ORklHX0lORVRfVFVOTkVMPXkKQ09ORklHX0lORVRfRElB Rz15CkNPTkZJR19JTkVUX1RDUF9ESUFHPXkKIyBDT05GSUdfSU5FVF9VRFBfRElBRyBpcyBub3Qg c2V0CiMgQ09ORklHX0lORVRfUkFXX0RJQUcgaXMgbm90IHNldAojIENPTkZJR19JTkVUX0RJQUdf REVTVFJPWSBpcyBub3Qgc2V0CiMgQ09ORklHX1RDUF9DT05HX0FEVkFOQ0VEIGlzIG5vdCBzZXQK Q09ORklHX1RDUF9DT05HX0NVQklDPXkKQ09ORklHX0RFRkFVTFRfVENQX0NPTkc9ImN1YmljIgoj IENPTkZJR19UQ1BfTUQ1U0lHIGlzIG5vdCBzZXQKQ09ORklHX0lQVjY9eQpDT05GSUdfSVBWNl9S T1VURVJfUFJFRj15CiMgQ09ORklHX0lQVjZfUk9VVEVfSU5GTyBpcyBub3Qgc2V0CiMgQ09ORklH X0lQVjZfT1BUSU1JU1RJQ19EQUQgaXMgbm90IHNldApDT05GSUdfSU5FVDZfQUg9eQpDT05GSUdf SU5FVDZfRVNQPXkKIyBDT05GSUdfSU5FVDZfRVNQX09GRkxPQUQgaXMgbm90IHNldAojIENPTkZJ R19JTkVUNl9FU1BJTlRDUCBpcyBub3Qgc2V0CkNPTkZJR19JTkVUNl9JUENPTVA9bQojIENPTkZJ R19JUFY2X01JUDYgaXMgbm90IHNldAojIENPTkZJR19JUFY2X0lMQSBpcyBub3Qgc2V0CkNPTkZJ R19JTkVUNl9YRlJNX1RVTk5FTD1tCkNPTkZJR19JTkVUNl9UVU5ORUw9bQojIENPTkZJR19JUFY2 X1ZUSSBpcyBub3Qgc2V0CkNPTkZJR19JUFY2X1NJVD15CiMgQ09ORklHX0lQVjZfU0lUXzZSRCBp cyBub3Qgc2V0CkNPTkZJR19JUFY2X05ESVNDX05PREVUWVBFPXkKQ09ORklHX0lQVjZfVFVOTkVM PW0KIyBDT05GSUdfSVBWNl9HUkUgaXMgbm90IHNldAojIENPTkZJR19JUFY2X01VTFRJUExFX1RB QkxFUyBpcyBub3Qgc2V0CiMgQ09ORklHX0lQVjZfTVJPVVRFIGlzIG5vdCBzZXQKIyBDT05GSUdf SVBWNl9TRUc2X0xXVFVOTkVMIGlzIG5vdCBzZXQKIyBDT05GSUdfSVBWNl9TRUc2X0hNQUMgaXMg bm90IHNldAojIENPTkZJR19JUFY2X1JQTF9MV1RVTk5FTCBpcyBub3Qgc2V0CiMgQ09ORklHX0lQ VjZfSU9BTTZfTFdUVU5ORUwgaXMgbm90IHNldAojIENPTkZJR19ORVRMQUJFTCBpcyBub3Qgc2V0 CiMgQ09ORklHX01QVENQIGlzIG5vdCBzZXQKIyBDT05GSUdfTkVUV09SS19TRUNNQVJLIGlzIG5v dCBzZXQKQ09ORklHX05FVF9QVFBfQ0xBU1NJRlk9eQojIENPTkZJR19ORVRXT1JLX1BIWV9USU1F U1RBTVBJTkcgaXMgbm90IHNldApDT05GSUdfTkVURklMVEVSPXkKQ09ORklHX05FVEZJTFRFUl9B RFZBTkNFRD15CkNPTkZJR19CUklER0VfTkVURklMVEVSPXkKCiMKIyBDb3JlIE5ldGZpbHRlciBD b25maWd1cmF0aW9uCiMKQ09ORklHX05FVEZJTFRFUl9JTkdSRVNTPXkKQ09ORklHX05FVEZJTFRF Ul9ORVRMSU5LPW0KQ09ORklHX05FVEZJTFRFUl9GQU1JTFlfQlJJREdFPXkKQ09ORklHX05FVEZJ TFRFUl9GQU1JTFlfQVJQPXkKIyBDT05GSUdfTkVURklMVEVSX05FVExJTktfQUNDVCBpcyBub3Qg c2V0CkNPTkZJR19ORVRGSUxURVJfTkVUTElOS19RVUVVRT1tCkNPTkZJR19ORVRGSUxURVJfTkVU TElOS19MT0c9bQojIENPTkZJR19ORVRGSUxURVJfTkVUTElOS19PU0YgaXMgbm90IHNldApDT05G SUdfTkZfQ09OTlRSQUNLPW0KQ09ORklHX05GX0xPR19TWVNMT0c9bQpDT05GSUdfTkVURklMVEVS X0NPTk5DT1VOVD1tCkNPTkZJR19ORl9DT05OVFJBQ0tfTUFSSz15CiMgQ09ORklHX05GX0NPTk5U UkFDS19aT05FUyBpcyBub3Qgc2V0CiMgQ09ORklHX05GX0NPTk5UUkFDS19QUk9DRlMgaXMgbm90 IHNldAojIENPTkZJR19ORl9DT05OVFJBQ0tfRVZFTlRTIGlzIG5vdCBzZXQKIyBDT05GSUdfTkZf Q09OTlRSQUNLX1RJTUVPVVQgaXMgbm90IHNldAojIENPTkZJR19ORl9DT05OVFJBQ0tfVElNRVNU QU1QIGlzIG5vdCBzZXQKIyBDT05GSUdfTkZfQ09OTlRSQUNLX0xBQkVMUyBpcyBub3Qgc2V0CkNP TkZJR19ORl9DVF9QUk9UT19EQ0NQPXkKQ09ORklHX05GX0NUX1BST1RPX0dSRT15CkNPTkZJR19O Rl9DVF9QUk9UT19TQ1RQPXkKQ09ORklHX05GX0NUX1BST1RPX1VEUExJVEU9eQpDT05GSUdfTkZf Q09OTlRSQUNLX0FNQU5EQT1tCkNPTkZJR19ORl9DT05OVFJBQ0tfRlRQPW0KQ09ORklHX05GX0NP Tk5UUkFDS19IMzIzPW0KQ09ORklHX05GX0NPTk5UUkFDS19JUkM9bQpDT05GSUdfTkZfQ09OTlRS QUNLX0JST0FEQ0FTVD1tCkNPTkZJR19ORl9DT05OVFJBQ0tfTkVUQklPU19OUz1tCiMgQ09ORklH X05GX0NPTk5UUkFDS19TTk1QIGlzIG5vdCBzZXQKQ09ORklHX05GX0NPTk5UUkFDS19QUFRQPW0K Q09ORklHX05GX0NPTk5UUkFDS19TQU5FPW0KQ09ORklHX05GX0NPTk5UUkFDS19TSVA9bQpDT05G SUdfTkZfQ09OTlRSQUNLX1RGVFA9bQpDT05GSUdfTkZfQ1RfTkVUTElOSz1tCiMgQ09ORklHX05F VEZJTFRFUl9ORVRMSU5LX0dMVUVfQ1QgaXMgbm90IHNldApDT05GSUdfTkZfTkFUPW0KQ09ORklH X05GX05BVF9BTUFOREE9bQpDT05GSUdfTkZfTkFUX0ZUUD1tCkNPTkZJR19ORl9OQVRfSVJDPW0K Q09ORklHX05GX05BVF9TSVA9bQpDT05GSUdfTkZfTkFUX1RGVFA9bQpDT05GSUdfTkZfTkFUX1JF RElSRUNUPXkKQ09ORklHX05GX05BVF9NQVNRVUVSQURFPXkKQ09ORklHX05FVEZJTFRFUl9TWU5Q Uk9YWT1tCiMgQ09ORklHX05GX1RBQkxFUyBpcyBub3Qgc2V0CkNPTkZJR19ORVRGSUxURVJfWFRB QkxFUz1tCkNPTkZJR19ORVRGSUxURVJfWFRBQkxFU19DT01QQVQ9eQoKIwojIFh0YWJsZXMgY29t YmluZWQgbW9kdWxlcwojCkNPTkZJR19ORVRGSUxURVJfWFRfTUFSSz1tCkNPTkZJR19ORVRGSUxU RVJfWFRfQ09OTk1BUks9bQoKIwojIFh0YWJsZXMgdGFyZ2V0cwojCiMgQ09ORklHX05FVEZJTFRF Ul9YVF9UQVJHRVRfQ0hFQ0tTVU0gaXMgbm90IHNldApDT05GSUdfTkVURklMVEVSX1hUX1RBUkdF VF9DTEFTU0lGWT1tCkNPTkZJR19ORVRGSUxURVJfWFRfVEFSR0VUX0NPTk5NQVJLPW0KQ09ORklH X05FVEZJTFRFUl9YVF9UQVJHRVRfQ1Q9bQpDT05GSUdfTkVURklMVEVSX1hUX1RBUkdFVF9EU0NQ PW0KQ09ORklHX05FVEZJTFRFUl9YVF9UQVJHRVRfSEw9bQojIENPTkZJR19ORVRGSUxURVJfWFRf VEFSR0VUX0hNQVJLIGlzIG5vdCBzZXQKIyBDT05GSUdfTkVURklMVEVSX1hUX1RBUkdFVF9JRExF VElNRVIgaXMgbm90IHNldApDT05GSUdfTkVURklMVEVSX1hUX1RBUkdFVF9MT0c9bQpDT05GSUdf TkVURklMVEVSX1hUX1RBUkdFVF9NQVJLPW0KQ09ORklHX05FVEZJTFRFUl9YVF9OQVQ9bQpDT05G SUdfTkVURklMVEVSX1hUX1RBUkdFVF9ORVRNQVA9bQpDT05GSUdfTkVURklMVEVSX1hUX1RBUkdF VF9ORkxPRz1tCkNPTkZJR19ORVRGSUxURVJfWFRfVEFSR0VUX05GUVVFVUU9bQpDT05GSUdfTkVU RklMVEVSX1hUX1RBUkdFVF9OT1RSQUNLPW0KIyBDT05GSUdfTkVURklMVEVSX1hUX1RBUkdFVF9S QVRFRVNUIGlzIG5vdCBzZXQKQ09ORklHX05FVEZJTFRFUl9YVF9UQVJHRVRfUkVESVJFQ1Q9bQpD T05GSUdfTkVURklMVEVSX1hUX1RBUkdFVF9NQVNRVUVSQURFPW0KIyBDT05GSUdfTkVURklMVEVS X1hUX1RBUkdFVF9URUUgaXMgbm90IHNldAojIENPTkZJR19ORVRGSUxURVJfWFRfVEFSR0VUX1RQ Uk9YWSBpcyBub3Qgc2V0CkNPTkZJR19ORVRGSUxURVJfWFRfVEFSR0VUX1RSQUNFPW0KQ09ORklH X05FVEZJTFRFUl9YVF9UQVJHRVRfVENQTVNTPW0KIyBDT05GSUdfTkVURklMVEVSX1hUX1RBUkdF VF9UQ1BPUFRTVFJJUCBpcyBub3Qgc2V0CgojCiMgWHRhYmxlcyBtYXRjaGVzCiMKIyBDT05GSUdf TkVURklMVEVSX1hUX01BVENIX0FERFJUWVBFIGlzIG5vdCBzZXQKIyBDT05GSUdfTkVURklMVEVS X1hUX01BVENIX0JQRiBpcyBub3Qgc2V0CiMgQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9DR1JP VVAgaXMgbm90IHNldAojIENPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfQ0xVU1RFUiBpcyBub3Qg c2V0CkNPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfQ09NTUVOVD1tCkNPTkZJR19ORVRGSUxURVJf WFRfTUFUQ0hfQ09OTkJZVEVTPW0KIyBDT05GSUdfTkVURklMVEVSX1hUX01BVENIX0NPTk5MQUJF TCBpcyBub3Qgc2V0CkNPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfQ09OTkxJTUlUPW0KQ09ORklH X05FVEZJTFRFUl9YVF9NQVRDSF9DT05OTUFSSz1tCkNPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hf Q09OTlRSQUNLPW0KIyBDT05GSUdfTkVURklMVEVSX1hUX01BVENIX0NQVSBpcyBub3Qgc2V0CkNP TkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfRENDUD1tCiMgQ09ORklHX05FVEZJTFRFUl9YVF9NQVRD SF9ERVZHUk9VUCBpcyBub3Qgc2V0CkNPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfRFNDUD1tCkNP TkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfRUNOPW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9F U1A9bQpDT05GSUdfTkVURklMVEVSX1hUX01BVENIX0hBU0hMSU1JVD1tCkNPTkZJR19ORVRGSUxU RVJfWFRfTUFUQ0hfSEVMUEVSPW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9ITD1tCiMgQ09O RklHX05FVEZJTFRFUl9YVF9NQVRDSF9JUENPTVAgaXMgbm90IHNldAojIENPTkZJR19ORVRGSUxU RVJfWFRfTUFUQ0hfSVBSQU5HRSBpcyBub3Qgc2V0CiMgQ09ORklHX05FVEZJTFRFUl9YVF9NQVRD SF9MMlRQIGlzIG5vdCBzZXQKQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9MRU5HVEg9bQpDT05G SUdfTkVURklMVEVSX1hUX01BVENIX0xJTUlUPW0KQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9N QUM9bQpDT05GSUdfTkVURklMVEVSX1hUX01BVENIX01BUks9bQpDT05GSUdfTkVURklMVEVSX1hU X01BVENIX01VTFRJUE9SVD1tCiMgQ09ORklHX05FVEZJTFRFUl9YVF9NQVRDSF9ORkFDQ1QgaXMg bm90IHNldAojIENPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfT1NGIGlzIG5vdCBzZXQKIyBDT05G SUdfTkVURklMVEVSX1hUX01BVENIX09XTkVSIGlzIG5vdCBzZXQKQ09ORklHX05FVEZJTFRFUl9Y VF9NQVRDSF9QT0xJQ1k9bQojIENPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfUEhZU0RFViBpcyBu b3Qgc2V0CkNPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfUEtUVFlQRT1tCkNPTkZJR19ORVRGSUxU RVJfWFRfTUFUQ0hfUVVPVEE9bQojIENPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfUkFURUVTVCBp cyBub3Qgc2V0CkNPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfUkVBTE09bQojIENPTkZJR19ORVRG SUxURVJfWFRfTUFUQ0hfUkVDRU5UIGlzIG5vdCBzZXQKQ09ORklHX05FVEZJTFRFUl9YVF9NQVRD SF9TQ1RQPW0KIyBDT05GSUdfTkVURklMVEVSX1hUX01BVENIX1NPQ0tFVCBpcyBub3Qgc2V0CkNP TkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfU1RBVEU9bQpDT05GSUdfTkVURklMVEVSX1hUX01BVENI X1NUQVRJU1RJQz1tCkNPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfU1RSSU5HPW0KQ09ORklHX05F VEZJTFRFUl9YVF9NQVRDSF9UQ1BNU1M9bQojIENPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfVElN RSBpcyBub3Qgc2V0CkNPTkZJR19ORVRGSUxURVJfWFRfTUFUQ0hfVTMyPW0KIyBlbmQgb2YgQ29y ZSBOZXRmaWx0ZXIgQ29uZmlndXJhdGlvbgoKIyBDT05GSUdfSVBfU0VUIGlzIG5vdCBzZXQKIyBD T05GSUdfSVBfVlMgaXMgbm90IHNldAoKIwojIElQOiBOZXRmaWx0ZXIgQ29uZmlndXJhdGlvbgoj CkNPTkZJR19ORl9ERUZSQUdfSVBWND1tCiMgQ09ORklHX05GX1NPQ0tFVF9JUFY0IGlzIG5vdCBz ZXQKIyBDT05GSUdfTkZfVFBST1hZX0lQVjQgaXMgbm90IHNldAojIENPTkZJR19ORl9EVVBfSVBW NCBpcyBub3Qgc2V0CiMgQ09ORklHX05GX0xPR19BUlAgaXMgbm90IHNldAojIENPTkZJR19ORl9M T0dfSVBWNCBpcyBub3Qgc2V0CkNPTkZJR19ORl9SRUpFQ1RfSVBWND1tCkNPTkZJR19ORl9OQVRf UFBUUD1tCkNPTkZJR19ORl9OQVRfSDMyMz1tCkNPTkZJR19JUF9ORl9JUFRBQkxFUz1tCkNPTkZJ R19JUF9ORl9NQVRDSF9BSD1tCkNPTkZJR19JUF9ORl9NQVRDSF9FQ049bQpDT05GSUdfSVBfTkZf TUFUQ0hfUlBGSUxURVI9bQpDT05GSUdfSVBfTkZfTUFUQ0hfVFRMPW0KQ09ORklHX0lQX05GX0ZJ TFRFUj1tCkNPTkZJR19JUF9ORl9UQVJHRVRfUkVKRUNUPW0KQ09ORklHX0lQX05GX1RBUkdFVF9T WU5QUk9YWT1tCkNPTkZJR19JUF9ORl9OQVQ9bQpDT05GSUdfSVBfTkZfVEFSR0VUX01BU1FVRVJB REU9bQpDT05GSUdfSVBfTkZfVEFSR0VUX05FVE1BUD1tCkNPTkZJR19JUF9ORl9UQVJHRVRfUkVE SVJFQ1Q9bQpDT05GSUdfSVBfTkZfTUFOR0xFPW0KQ09ORklHX0lQX05GX1RBUkdFVF9DTFVTVEVS SVA9bQpDT05GSUdfSVBfTkZfVEFSR0VUX0VDTj1tCkNPTkZJR19JUF9ORl9UQVJHRVRfVFRMPW0K Q09ORklHX0lQX05GX1JBVz1tCkNPTkZJR19JUF9ORl9TRUNVUklUWT1tCkNPTkZJR19JUF9ORl9B UlBUQUJMRVM9bQpDT05GSUdfSVBfTkZfQVJQRklMVEVSPW0KQ09ORklHX0lQX05GX0FSUF9NQU5H TEU9bQojIGVuZCBvZiBJUDogTmV0ZmlsdGVyIENvbmZpZ3VyYXRpb24KCiMKIyBJUHY2OiBOZXRm aWx0ZXIgQ29uZmlndXJhdGlvbgojCiMgQ09ORklHX05GX1NPQ0tFVF9JUFY2IGlzIG5vdCBzZXQK IyBDT05GSUdfTkZfVFBST1hZX0lQVjYgaXMgbm90IHNldAojIENPTkZJR19ORl9EVVBfSVBWNiBp cyBub3Qgc2V0CiMgQ09ORklHX05GX1JFSkVDVF9JUFY2IGlzIG5vdCBzZXQKQ09ORklHX05GX0xP R19JUFY2PW0KQ09ORklHX0lQNl9ORl9JUFRBQkxFUz1tCiMgQ09ORklHX0lQNl9ORl9NQVRDSF9B SCBpcyBub3Qgc2V0CkNPTkZJR19JUDZfTkZfTUFUQ0hfRVVJNjQ9bQpDT05GSUdfSVA2X05GX01B VENIX0ZSQUc9bQpDT05GSUdfSVA2X05GX01BVENIX09QVFM9bQpDT05GSUdfSVA2X05GX01BVENI X0hMPW0KQ09ORklHX0lQNl9ORl9NQVRDSF9JUFY2SEVBREVSPW0KIyBDT05GSUdfSVA2X05GX01B VENIX01IIGlzIG5vdCBzZXQKIyBDT05GSUdfSVA2X05GX01BVENIX1JQRklMVEVSIGlzIG5vdCBz ZXQKQ09ORklHX0lQNl9ORl9NQVRDSF9SVD1tCiMgQ09ORklHX0lQNl9ORl9NQVRDSF9TUkggaXMg bm90IHNldAojIENPTkZJR19JUDZfTkZfVEFSR0VUX0hMIGlzIG5vdCBzZXQKQ09ORklHX0lQNl9O Rl9GSUxURVI9bQojIENPTkZJR19JUDZfTkZfVEFSR0VUX1JFSkVDVCBpcyBub3Qgc2V0CiMgQ09O RklHX0lQNl9ORl9UQVJHRVRfU1lOUFJPWFkgaXMgbm90IHNldApDT05GSUdfSVA2X05GX01BTkdM RT1tCkNPTkZJR19JUDZfTkZfUkFXPW0KIyBDT05GSUdfSVA2X05GX1NFQ1VSSVRZIGlzIG5vdCBz ZXQKQ09ORklHX0lQNl9ORl9OQVQ9bQojIENPTkZJR19JUDZfTkZfVEFSR0VUX01BU1FVRVJBREUg aXMgbm90IHNldAojIENPTkZJR19JUDZfTkZfVEFSR0VUX05QVCBpcyBub3Qgc2V0CiMgZW5kIG9m IElQdjY6IE5ldGZpbHRlciBDb25maWd1cmF0aW9uCgpDT05GSUdfTkZfREVGUkFHX0lQVjY9bQoj IENPTkZJR19ORl9DT05OVFJBQ0tfQlJJREdFIGlzIG5vdCBzZXQKQ09ORklHX0JSSURHRV9ORl9F QlRBQkxFUz1tCkNPTkZJR19CUklER0VfRUJUX0JST1VURT1tCkNPTkZJR19CUklER0VfRUJUX1Rf RklMVEVSPW0KQ09ORklHX0JSSURHRV9FQlRfVF9OQVQ9bQpDT05GSUdfQlJJREdFX0VCVF84MDJf Mz1tCkNPTkZJR19CUklER0VfRUJUX0FNT05HPW0KQ09ORklHX0JSSURHRV9FQlRfQVJQPW0KQ09O RklHX0JSSURHRV9FQlRfSVA9bQpDT05GSUdfQlJJREdFX0VCVF9JUDY9bQpDT05GSUdfQlJJREdF X0VCVF9MSU1JVD1tCkNPTkZJR19CUklER0VfRUJUX01BUks9bQpDT05GSUdfQlJJREdFX0VCVF9Q S1RUWVBFPW0KQ09ORklHX0JSSURHRV9FQlRfU1RQPW0KQ09ORklHX0JSSURHRV9FQlRfVkxBTj1t CkNPTkZJR19CUklER0VfRUJUX0FSUFJFUExZPW0KQ09ORklHX0JSSURHRV9FQlRfRE5BVD1tCkNP TkZJR19CUklER0VfRUJUX01BUktfVD1tCkNPTkZJR19CUklER0VfRUJUX1JFRElSRUNUPW0KQ09O RklHX0JSSURHRV9FQlRfU05BVD1tCkNPTkZJR19CUklER0VfRUJUX0xPRz1tCkNPTkZJR19CUklE R0VfRUJUX05GTE9HPW0KIyBDT05GSUdfQlBGSUxURVIgaXMgbm90IHNldApDT05GSUdfSVBfU0NU UD1tCiMgQ09ORklHX1NDVFBfREJHX09CSkNOVCBpcyBub3Qgc2V0CkNPTkZJR19TQ1RQX0RFRkFV TFRfQ09PS0lFX0hNQUNfTUQ1PXkKIyBDT05GSUdfU0NUUF9ERUZBVUxUX0NPT0tJRV9ITUFDX1NI QTEgaXMgbm90IHNldAojIENPTkZJR19TQ1RQX0RFRkFVTFRfQ09PS0lFX0hNQUNfTk9ORSBpcyBu b3Qgc2V0CkNPTkZJR19TQ1RQX0NPT0tJRV9ITUFDX01ENT15CiMgQ09ORklHX1NDVFBfQ09PS0lF X0hNQUNfU0hBMSBpcyBub3Qgc2V0CkNPTkZJR19JTkVUX1NDVFBfRElBRz1tCiMgQ09ORklHX1JE UyBpcyBub3Qgc2V0CkNPTkZJR19USVBDPW0KQ09ORklHX1RJUENfTUVESUFfVURQPXkKQ09ORklH X1RJUENfQ1JZUFRPPXkKQ09ORklHX1RJUENfRElBRz1tCiMgQ09ORklHX0FUTSBpcyBub3Qgc2V0 CiMgQ09ORklHX0wyVFAgaXMgbm90IHNldApDT05GSUdfU1RQPXkKQ09ORklHX0JSSURHRT15CkNP TkZJR19CUklER0VfSUdNUF9TTk9PUElORz15CiMgQ09ORklHX0JSSURHRV9WTEFOX0ZJTFRFUklO RyBpcyBub3Qgc2V0CiMgQ09ORklHX0JSSURHRV9NUlAgaXMgbm90IHNldAojIENPTkZJR19CUklE R0VfQ0ZNIGlzIG5vdCBzZXQKIyBDT05GSUdfTkVUX0RTQSBpcyBub3Qgc2V0CkNPTkZJR19WTEFO XzgwMjFRPW0KIyBDT05GSUdfVkxBTl84MDIxUV9HVlJQIGlzIG5vdCBzZXQKIyBDT05GSUdfVkxB Tl84MDIxUV9NVlJQIGlzIG5vdCBzZXQKIyBDT05GSUdfREVDTkVUIGlzIG5vdCBzZXQKQ09ORklH X0xMQz15CiMgQ09ORklHX0xMQzIgaXMgbm90IHNldAojIENPTkZJR19BVEFMSyBpcyBub3Qgc2V0 CiMgQ09ORklHX1gyNSBpcyBub3Qgc2V0CiMgQ09ORklHX0xBUEIgaXMgbm90IHNldAojIENPTkZJ R19QSE9ORVQgaXMgbm90IHNldApDT05GSUdfNkxPV1BBTj1tCiMgQ09ORklHXzZMT1dQQU5fREVC VUdGUyBpcyBub3Qgc2V0CkNPTkZJR182TE9XUEFOX05IQz1tCkNPTkZJR182TE9XUEFOX05IQ19E RVNUPW0KQ09ORklHXzZMT1dQQU5fTkhDX0ZSQUdNRU5UPW0KQ09ORklHXzZMT1dQQU5fTkhDX0hP UD1tCkNPTkZJR182TE9XUEFOX05IQ19JUFY2PW0KQ09ORklHXzZMT1dQQU5fTkhDX01PQklMSVRZ PW0KQ09ORklHXzZMT1dQQU5fTkhDX1JPVVRJTkc9bQpDT05GSUdfNkxPV1BBTl9OSENfVURQPW0K IyBDT05GSUdfNkxPV1BBTl9HSENfRVhUX0hEUl9IT1AgaXMgbm90IHNldAojIENPTkZJR182TE9X UEFOX0dIQ19VRFAgaXMgbm90IHNldAojIENPTkZJR182TE9XUEFOX0dIQ19JQ01QVjYgaXMgbm90 IHNldAojIENPTkZJR182TE9XUEFOX0dIQ19FWFRfSERSX0RFU1QgaXMgbm90IHNldAojIENPTkZJ R182TE9XUEFOX0dIQ19FWFRfSERSX0ZSQUcgaXMgbm90IHNldAojIENPTkZJR182TE9XUEFOX0dI Q19FWFRfSERSX1JPVVRFIGlzIG5vdCBzZXQKIyBDT05GSUdfSUVFRTgwMjE1NCBpcyBub3Qgc2V0 CkNPTkZJR19ORVRfU0NIRUQ9eQoKIwojIFF1ZXVlaW5nL1NjaGVkdWxpbmcKIwpDT05GSUdfTkVU X1NDSF9DQlE9bQpDT05GSUdfTkVUX1NDSF9IVEI9bQpDT05GSUdfTkVUX1NDSF9IRlNDPW0KQ09O RklHX05FVF9TQ0hfUFJJTz1tCiMgQ09ORklHX05FVF9TQ0hfTVVMVElRIGlzIG5vdCBzZXQKQ09O RklHX05FVF9TQ0hfUkVEPW0KIyBDT05GSUdfTkVUX1NDSF9TRkIgaXMgbm90IHNldApDT05GSUdf TkVUX1NDSF9TRlE9bQpDT05GSUdfTkVUX1NDSF9URVFMPW0KQ09ORklHX05FVF9TQ0hfVEJGPW0K IyBDT05GSUdfTkVUX1NDSF9DQlMgaXMgbm90IHNldAojIENPTkZJR19ORVRfU0NIX0VURiBpcyBu b3Qgc2V0CiMgQ09ORklHX05FVF9TQ0hfVEFQUklPIGlzIG5vdCBzZXQKQ09ORklHX05FVF9TQ0hf R1JFRD1tCkNPTkZJR19ORVRfU0NIX0RTTUFSSz1tCkNPTkZJR19ORVRfU0NIX05FVEVNPW0KIyBD T05GSUdfTkVUX1NDSF9EUlIgaXMgbm90IHNldAojIENPTkZJR19ORVRfU0NIX01RUFJJTyBpcyBu b3Qgc2V0CiMgQ09ORklHX05FVF9TQ0hfU0tCUFJJTyBpcyBub3Qgc2V0CiMgQ09ORklHX05FVF9T Q0hfQ0hPS0UgaXMgbm90IHNldAojIENPTkZJR19ORVRfU0NIX1FGUSBpcyBub3Qgc2V0CkNPTkZJ R19ORVRfU0NIX0NPREVMPW0KQ09ORklHX05FVF9TQ0hfRlFfQ09ERUw9bQojIENPTkZJR19ORVRf U0NIX0NBS0UgaXMgbm90IHNldAojIENPTkZJR19ORVRfU0NIX0ZRIGlzIG5vdCBzZXQKIyBDT05G SUdfTkVUX1NDSF9ISEYgaXMgbm90IHNldAojIENPTkZJR19ORVRfU0NIX1BJRSBpcyBub3Qgc2V0 CkNPTkZJR19ORVRfU0NIX0lOR1JFU1M9bQojIENPTkZJR19ORVRfU0NIX1BMVUcgaXMgbm90IHNl dAojIENPTkZJR19ORVRfU0NIX0VUUyBpcyBub3Qgc2V0CiMgQ09ORklHX05FVF9TQ0hfREVGQVVM VCBpcyBub3Qgc2V0CgojCiMgQ2xhc3NpZmljYXRpb24KIwpDT05GSUdfTkVUX0NMUz15CkNPTkZJ R19ORVRfQ0xTX0JBU0lDPXkKIyBDT05GSUdfTkVUX0NMU19UQ0lOREVYIGlzIG5vdCBzZXQKIyBD T05GSUdfTkVUX0NMU19ST1VURTQgaXMgbm90IHNldAojIENPTkZJR19ORVRfQ0xTX0ZXIGlzIG5v dCBzZXQKQ09ORklHX05FVF9DTFNfVTMyPXkKIyBDT05GSUdfQ0xTX1UzMl9QRVJGIGlzIG5vdCBz ZXQKIyBDT05GSUdfQ0xTX1UzMl9NQVJLIGlzIG5vdCBzZXQKIyBDT05GSUdfTkVUX0NMU19SU1ZQ IGlzIG5vdCBzZXQKIyBDT05GSUdfTkVUX0NMU19SU1ZQNiBpcyBub3Qgc2V0CiMgQ09ORklHX05F VF9DTFNfRkxPVyBpcyBub3Qgc2V0CkNPTkZJR19ORVRfQ0xTX0NHUk9VUD15CiMgQ09ORklHX05F VF9DTFNfQlBGIGlzIG5vdCBzZXQKIyBDT05GSUdfTkVUX0NMU19GTE9XRVIgaXMgbm90IHNldAoj IENPTkZJR19ORVRfQ0xTX01BVENIQUxMIGlzIG5vdCBzZXQKQ09ORklHX05FVF9FTUFUQ0g9eQpD T05GSUdfTkVUX0VNQVRDSF9TVEFDSz0zMgojIENPTkZJR19ORVRfRU1BVENIX0NNUCBpcyBub3Qg c2V0CiMgQ09ORklHX05FVF9FTUFUQ0hfTkJZVEUgaXMgbm90IHNldAojIENPTkZJR19ORVRfRU1B VENIX1UzMiBpcyBub3Qgc2V0CiMgQ09ORklHX05FVF9FTUFUQ0hfTUVUQSBpcyBub3Qgc2V0CiMg Q09ORklHX05FVF9FTUFUQ0hfVEVYVCBpcyBub3Qgc2V0CiMgQ09ORklHX05FVF9FTUFUQ0hfQ0FO SUQgaXMgbm90IHNldAojIENPTkZJR19ORVRfRU1BVENIX0lQVCBpcyBub3Qgc2V0CkNPTkZJR19O RVRfQ0xTX0FDVD15CiMgQ09ORklHX05FVF9BQ1RfUE9MSUNFIGlzIG5vdCBzZXQKIyBDT05GSUdf TkVUX0FDVF9HQUNUIGlzIG5vdCBzZXQKQ09ORklHX05FVF9BQ1RfTUlSUkVEPW0KIyBDT05GSUdf TkVUX0FDVF9TQU1QTEUgaXMgbm90IHNldAojIENPTkZJR19ORVRfQUNUX0lQVCBpcyBub3Qgc2V0 CiMgQ09ORklHX05FVF9BQ1RfTkFUIGlzIG5vdCBzZXQKIyBDT05GSUdfTkVUX0FDVF9QRURJVCBp cyBub3Qgc2V0CiMgQ09ORklHX05FVF9BQ1RfU0lNUCBpcyBub3Qgc2V0CkNPTkZJR19ORVRfQUNU X1NLQkVESVQ9bQojIENPTkZJR19ORVRfQUNUX0NTVU0gaXMgbm90IHNldAojIENPTkZJR19ORVRf QUNUX01QTFMgaXMgbm90IHNldAojIENPTkZJR19ORVRfQUNUX1ZMQU4gaXMgbm90IHNldAojIENP TkZJR19ORVRfQUNUX0JQRiBpcyBub3Qgc2V0CiMgQ09ORklHX05FVF9BQ1RfQ09OTk1BUksgaXMg bm90IHNldAojIENPTkZJR19ORVRfQUNUX0NUSU5GTyBpcyBub3Qgc2V0CiMgQ09ORklHX05FVF9B Q1RfU0tCTU9EIGlzIG5vdCBzZXQKIyBDT05GSUdfTkVUX0FDVF9JRkUgaXMgbm90IHNldAojIENP TkZJR19ORVRfQUNUX1RVTk5FTF9LRVkgaXMgbm90IHNldAojIENPTkZJR19ORVRfQUNUX0dBVEUg aXMgbm90IHNldAojIENPTkZJR19ORVRfVENfU0tCX0VYVCBpcyBub3Qgc2V0CkNPTkZJR19ORVRf U0NIX0ZJRk89eQojIENPTkZJR19EQ0IgaXMgbm90IHNldApDT05GSUdfRE5TX1JFU09MVkVSPXkK IyBDT05GSUdfQkFUTUFOX0FEViBpcyBub3Qgc2V0CiMgQ09ORklHX09QRU5WU1dJVENIIGlzIG5v dCBzZXQKIyBDT05GSUdfVlNPQ0tFVFMgaXMgbm90IHNldAojIENPTkZJR19ORVRMSU5LX0RJQUcg aXMgbm90IHNldAojIENPTkZJR19NUExTIGlzIG5vdCBzZXQKIyBDT05GSUdfTkVUX05TSCBpcyBu b3Qgc2V0CiMgQ09ORklHX0hTUiBpcyBub3Qgc2V0CiMgQ09ORklHX05FVF9TV0lUQ0hERVYgaXMg bm90IHNldAojIENPTkZJR19ORVRfTDNfTUFTVEVSX0RFViBpcyBub3Qgc2V0CiMgQ09ORklHX1FS VFIgaXMgbm90IHNldAojIENPTkZJR19ORVRfTkNTSSBpcyBub3Qgc2V0CkNPTkZJR19QQ1BVX0RF Vl9SRUZDTlQ9eQpDT05GSUdfUlBTPXkKQ09ORklHX1JGU19BQ0NFTD15CkNPTkZJR19TT0NLX1JY X1FVRVVFX01BUFBJTkc9eQpDT05GSUdfWFBTPXkKQ09ORklHX0NHUk9VUF9ORVRfUFJJTz15CkNP TkZJR19DR1JPVVBfTkVUX0NMQVNTSUQ9eQpDT05GSUdfTkVUX1JYX0JVU1lfUE9MTD15CkNPTkZJ R19CUUw9eQojIENPTkZJR19CUEZfU1RSRUFNX1BBUlNFUiBpcyBub3Qgc2V0CkNPTkZJR19ORVRf RkxPV19MSU1JVD15CgojCiMgTmV0d29yayB0ZXN0aW5nCiMKQ09ORklHX05FVF9QS1RHRU49bQoj IENPTkZJR19ORVRfRFJPUF9NT05JVE9SIGlzIG5vdCBzZXQKIyBlbmQgb2YgTmV0d29yayB0ZXN0 aW5nCiMgZW5kIG9mIE5ldHdvcmtpbmcgb3B0aW9ucwoKIyBDT05GSUdfSEFNUkFESU8gaXMgbm90 IHNldApDT05GSUdfQ0FOPW0KQ09ORklHX0NBTl9SQVc9bQpDT05GSUdfQ0FOX0JDTT1tCkNPTkZJ R19DQU5fR1c9bQpDT05GSUdfQ0FOX0oxOTM5PW0KIyBDT05GSUdfQ0FOX0lTT1RQIGlzIG5vdCBz ZXQKCiMKIyBDQU4gRGV2aWNlIERyaXZlcnMKIwojIENPTkZJR19DQU5fVkNBTiBpcyBub3Qgc2V0 CiMgQ09ORklHX0NBTl9WWENBTiBpcyBub3Qgc2V0CiMgQ09ORklHX0NBTl9TTENBTiBpcyBub3Qg c2V0CkNPTkZJR19DQU5fREVWPW0KQ09ORklHX0NBTl9DQUxDX0JJVFRJTUlORz15CiMgQ09ORklH X0NBTl9GTEVYQ0FOIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0FOX0dSQ0FOIGlzIG5vdCBzZXQKIyBD T05GSUdfQ0FOX0tWQVNFUl9QQ0lFRkQgaXMgbm90IHNldAojIENPTkZJR19DQU5fWElMSU5YQ0FO IGlzIG5vdCBzZXQKIyBDT05GSUdfQ0FOX0NfQ0FOIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0FOX0ND NzcwIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0FOX0lGSV9DQU5GRCBpcyBub3Qgc2V0CiMgQ09ORklH X0NBTl9NX0NBTiBpcyBub3Qgc2V0CiMgQ09ORklHX0NBTl9QRUFLX1BDSUVGRCBpcyBub3Qgc2V0 CiMgQ09ORklHX0NBTl9TSkExMDAwIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0FOX1NPRlRJTkcgaXMg bm90IHNldAoKIwojIENBTiBTUEkgaW50ZXJmYWNlcwojCiMgQ09ORklHX0NBTl9ISTMxMVggaXMg bm90IHNldAojIENPTkZJR19DQU5fTUNQMjUxWCBpcyBub3Qgc2V0CiMgQ09ORklHX0NBTl9NQ1Ay NTFYRkQgaXMgbm90IHNldAojIGVuZCBvZiBDQU4gU1BJIGludGVyZmFjZXMKCiMKIyBDQU4gVVNC IGludGVyZmFjZXMKIwojIENPTkZJR19DQU5fOERFVl9VU0IgaXMgbm90IHNldAojIENPTkZJR19D QU5fRU1TX1VTQiBpcyBub3Qgc2V0CiMgQ09ORklHX0NBTl9FU0RfVVNCMiBpcyBub3Qgc2V0CiMg Q09ORklHX0NBTl9FVEFTX0VTNThYIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0FOX0dTX1VTQiBpcyBu b3Qgc2V0CiMgQ09ORklHX0NBTl9LVkFTRVJfVVNCIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0FOX01D QkFfVVNCIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0FOX1BFQUtfVVNCIGlzIG5vdCBzZXQKIyBDT05G SUdfQ0FOX1VDQU4gaXMgbm90IHNldAojIGVuZCBvZiBDQU4gVVNCIGludGVyZmFjZXMKCiMgQ09O RklHX0NBTl9ERUJVR19ERVZJQ0VTIGlzIG5vdCBzZXQKIyBlbmQgb2YgQ0FOIERldmljZSBEcml2 ZXJzCgpDT05GSUdfQlQ9eQpDT05GSUdfQlRfQlJFRFI9eQpDT05GSUdfQlRfUkZDT01NPW0KQ09O RklHX0JUX1JGQ09NTV9UVFk9eQpDT05GSUdfQlRfQk5FUD1tCkNPTkZJR19CVF9CTkVQX01DX0ZJ TFRFUj15CkNPTkZJR19CVF9CTkVQX1BST1RPX0ZJTFRFUj15CkNPTkZJR19CVF9DTVRQPW0KQ09O RklHX0JUX0hJRFA9bQojIENPTkZJR19CVF9IUyBpcyBub3Qgc2V0CkNPTkZJR19CVF9MRT15CkNP TkZJR19CVF82TE9XUEFOPW0KIyBDT05GSUdfQlRfTEVEUyBpcyBub3Qgc2V0CiMgQ09ORklHX0JU X01TRlRFWFQgaXMgbm90IHNldAojIENPTkZJR19CVF9BT1NQRVhUIGlzIG5vdCBzZXQKQ09ORklH X0JUX0RFQlVHRlM9eQojIENPTkZJR19CVF9TRUxGVEVTVCBpcyBub3Qgc2V0CiMgQ09ORklHX0JU X0ZFQVRVUkVfREVCVUcgaXMgbm90IHNldAoKIwojIEJsdWV0b290aCBkZXZpY2UgZHJpdmVycwoj CkNPTkZJR19CVF9JTlRFTD1tCkNPTkZJR19CVF9CQ009bQpDT05GSUdfQlRfUlRMPW0KQ09ORklH X0JUX0hDSUJUVVNCPW0KIyBDT05GSUdfQlRfSENJQlRVU0JfQVVUT1NVU1BFTkQgaXMgbm90IHNl dApDT05GSUdfQlRfSENJQlRVU0JfQkNNPXkKIyBDT05GSUdfQlRfSENJQlRVU0JfTVRLIGlzIG5v dCBzZXQKQ09ORklHX0JUX0hDSUJUVVNCX1JUTD15CiMgQ09ORklHX0JUX0hDSUJUU0RJTyBpcyBu b3Qgc2V0CkNPTkZJR19CVF9IQ0lVQVJUPW0KQ09ORklHX0JUX0hDSVVBUlRfU0VSREVWPXkKQ09O RklHX0JUX0hDSVVBUlRfSDQ9eQojIENPTkZJR19CVF9IQ0lVQVJUX05PS0lBIGlzIG5vdCBzZXQK IyBDT05GSUdfQlRfSENJVUFSVF9CQ1NQIGlzIG5vdCBzZXQKIyBDT05GSUdfQlRfSENJVUFSVF9B VEgzSyBpcyBub3Qgc2V0CiMgQ09ORklHX0JUX0hDSVVBUlRfTEwgaXMgbm90IHNldApDT05GSUdf QlRfSENJVUFSVF8zV0lSRT15CiMgQ09ORklHX0JUX0hDSVVBUlRfSU5URUwgaXMgbm90IHNldApD T05GSUdfQlRfSENJVUFSVF9CQ009eQojIENPTkZJR19CVF9IQ0lVQVJUX1JUTCBpcyBub3Qgc2V0 CiMgQ09ORklHX0JUX0hDSVVBUlRfUUNBIGlzIG5vdCBzZXQKIyBDT05GSUdfQlRfSENJVUFSVF9B RzZYWCBpcyBub3Qgc2V0CiMgQ09ORklHX0JUX0hDSVVBUlRfTVJWTCBpcyBub3Qgc2V0CkNPTkZJ R19CVF9IQ0lCQ00yMDNYPW0KQ09ORklHX0JUX0hDSUJQQTEwWD1tCkNPTkZJR19CVF9IQ0lCRlVT Qj1tCkNPTkZJR19CVF9IQ0lWSENJPW0KIyBDT05GSUdfQlRfTVJWTCBpcyBub3Qgc2V0CiMgQ09O RklHX0JUX0FUSDNLIGlzIG5vdCBzZXQKIyBDT05GSUdfQlRfTVRLU0RJTyBpcyBub3Qgc2V0CiMg Q09ORklHX0JUX01US1VBUlQgaXMgbm90IHNldAojIENPTkZJR19CVF9WSVJUSU8gaXMgbm90IHNl dAojIGVuZCBvZiBCbHVldG9vdGggZGV2aWNlIGRyaXZlcnMKCiMgQ09ORklHX0FGX1JYUlBDIGlz IG5vdCBzZXQKIyBDT05GSUdfQUZfS0NNIGlzIG5vdCBzZXQKIyBDT05GSUdfTUNUUCBpcyBub3Qg c2V0CkNPTkZJR19GSUJfUlVMRVM9eQpDT05GSUdfV0lSRUxFU1M9eQpDT05GSUdfV0lSRUxFU1Nf RVhUPXkKQ09ORklHX1dFWFRfQ09SRT15CkNPTkZJR19XRVhUX1BST0M9eQpDT05GSUdfV0VYVF9T UFk9eQpDT05GSUdfV0VYVF9QUklWPXkKQ09ORklHX0NGRzgwMjExPW0KIyBDT05GSUdfTkw4MDIx MV9URVNUTU9ERSBpcyBub3Qgc2V0CiMgQ09ORklHX0NGRzgwMjExX0RFVkVMT1BFUl9XQVJOSU5H UyBpcyBub3Qgc2V0CiMgQ09ORklHX0NGRzgwMjExX0NFUlRJRklDQVRJT05fT05VUyBpcyBub3Qg c2V0CkNPTkZJR19DRkc4MDIxMV9SRVFVSVJFX1NJR05FRF9SRUdEQj15CkNPTkZJR19DRkc4MDIx MV9VU0VfS0VSTkVMX1JFR0RCX0tFWVM9eQpDT05GSUdfQ0ZHODAyMTFfREVGQVVMVF9QUz15CiMg Q09ORklHX0NGRzgwMjExX0RFQlVHRlMgaXMgbm90IHNldApDT05GSUdfQ0ZHODAyMTFfQ1JEQV9T VVBQT1JUPXkKQ09ORklHX0NGRzgwMjExX1dFWFQ9eQpDT05GSUdfTElCODAyMTE9eQpDT05GSUdf TElCODAyMTFfQ1JZUFRfV0VQPXkKQ09ORklHX0xJQjgwMjExX0NSWVBUX0NDTVA9eQpDT05GSUdf TElCODAyMTFfQ1JZUFRfVEtJUD15CiMgQ09ORklHX0xJQjgwMjExX0RFQlVHIGlzIG5vdCBzZXQK Q09ORklHX01BQzgwMjExPW0KQ09ORklHX01BQzgwMjExX0hBU19SQz15CkNPTkZJR19NQUM4MDIx MV9SQ19NSU5TVFJFTD15CkNPTkZJR19NQUM4MDIxMV9SQ19ERUZBVUxUX01JTlNUUkVMPXkKQ09O RklHX01BQzgwMjExX1JDX0RFRkFVTFQ9Im1pbnN0cmVsX2h0IgojIENPTkZJR19NQUM4MDIxMV9N RVNIIGlzIG5vdCBzZXQKIyBDT05GSUdfTUFDODAyMTFfTEVEUyBpcyBub3Qgc2V0CiMgQ09ORklH X01BQzgwMjExX0RFQlVHRlMgaXMgbm90IHNldAojIENPTkZJR19NQUM4MDIxMV9NRVNTQUdFX1RS QUNJTkcgaXMgbm90IHNldAojIENPTkZJR19NQUM4MDIxMV9ERUJVR19NRU5VIGlzIG5vdCBzZXQK Q09ORklHX01BQzgwMjExX1NUQV9IQVNIX01BWF9TSVpFPTAKQ09ORklHX1JGS0lMTD15CiMgQ09O RklHX1JGS0lMTF9JTlBVVCBpcyBub3Qgc2V0CiMgQ09ORklHX1JGS0lMTF9HUElPIGlzIG5vdCBz ZXQKIyBDT05GSUdfTkVUXzlQIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0FJRiBpcyBub3Qgc2V0CiMg Q09ORklHX0NFUEhfTElCIGlzIG5vdCBzZXQKIyBDT05GSUdfTkZDIGlzIG5vdCBzZXQKIyBDT05G SUdfUFNBTVBMRSBpcyBub3Qgc2V0CiMgQ09ORklHX05FVF9JRkUgaXMgbm90IHNldAojIENPTkZJ R19MV1RVTk5FTCBpcyBub3Qgc2V0CkNPTkZJR19EU1RfQ0FDSEU9eQpDT05GSUdfR1JPX0NFTExT PXkKQ09ORklHX05FVF9TRUxGVEVTVFM9eQpDT05GSUdfTkVUX1NPQ0tfTVNHPXkKQ09ORklHX1BB R0VfUE9PTD15CiMgQ09ORklHX0ZBSUxPVkVSIGlzIG5vdCBzZXQKQ09ORklHX0VUSFRPT0xfTkVU TElOSz15CgojCiMgRGV2aWNlIERyaXZlcnMKIwpDT05GSUdfQVJNX0FNQkE9eQpDT05GSUdfSEFW RV9QQ0k9eQpDT05GSUdfUENJPXkKQ09ORklHX1BDSV9ET01BSU5TPXkKQ09ORklHX1BDSV9ET01B SU5TX0dFTkVSSUM9eQpDT05GSUdfUENJX1NZU0NBTEw9eQojIENPTkZJR19QQ0lFUE9SVEJVUyBp cyBub3Qgc2V0CkNPTkZJR19QQ0lFQVNQTT15CkNPTkZJR19QQ0lFQVNQTV9ERUZBVUxUPXkKIyBD T05GSUdfUENJRUFTUE1fUE9XRVJTQVZFIGlzIG5vdCBzZXQKIyBDT05GSUdfUENJRUFTUE1fUE9X RVJfU1VQRVJTQVZFIGlzIG5vdCBzZXQKIyBDT05GSUdfUENJRUFTUE1fUEVSRk9STUFOQ0UgaXMg bm90IHNldAojIENPTkZJR19QQ0lFX1BUTSBpcyBub3Qgc2V0CkNPTkZJR19QQ0lfTVNJPXkKQ09O RklHX1BDSV9NU0lfSVJRX0RPTUFJTj15CkNPTkZJR19QQ0lfUVVJUktTPXkKIyBDT05GSUdfUENJ X0RFQlVHIGlzIG5vdCBzZXQKIyBDT05GSUdfUENJX1NUVUIgaXMgbm90IHNldApDT05GSUdfUENJ X0VDQU09eQojIENPTkZJR19QQ0lfSU9WIGlzIG5vdCBzZXQKIyBDT05GSUdfUENJX1BSSSBpcyBu b3Qgc2V0CiMgQ09ORklHX1BDSV9QQVNJRCBpcyBub3Qgc2V0CkNPTkZJR19QQ0lfTEFCRUw9eQoj IENPTkZJR19QQ0lFX0JVU19UVU5FX09GRiBpcyBub3Qgc2V0CkNPTkZJR19QQ0lFX0JVU19ERUZB VUxUPXkKIyBDT05GSUdfUENJRV9CVVNfU0FGRSBpcyBub3Qgc2V0CiMgQ09ORklHX1BDSUVfQlVT X1BFUkZPUk1BTkNFIGlzIG5vdCBzZXQKIyBDT05GSUdfUENJRV9CVVNfUEVFUjJQRUVSIGlzIG5v dCBzZXQKIyBDT05GSUdfSE9UUExVR19QQ0kgaXMgbm90IHNldAoKIwojIFBDSSBjb250cm9sbGVy IGRyaXZlcnMKIwojIENPTkZJR19QQ0lfRlRQQ0kxMDAgaXMgbm90IHNldApDT05GSUdfUENJX0hP U1RfQ09NTU9OPXkKQ09ORklHX1BDSV9IT1NUX0dFTkVSSUM9eQojIENPTkZJR19QQ0lFX1hJTElO WCBpcyBub3Qgc2V0CiMgQ09ORklHX1BDSV9YR0VORSBpcyBub3Qgc2V0CiMgQ09ORklHX1BDSUVf QUxURVJBIGlzIG5vdCBzZXQKIyBDT05GSUdfUENJX0hPU1RfVEhVTkRFUl9QRU0gaXMgbm90IHNl dAojIENPTkZJR19QQ0lfSE9TVF9USFVOREVSX0VDQU0gaXMgbm90IHNldApDT05GSUdfUENJRV9C UkNNU1RCPXkKIyBDT05GSUdfUENJRV9NSUNST0NISVBfSE9TVCBpcyBub3Qgc2V0CgojCiMgRGVz aWduV2FyZSBQQ0kgQ29yZSBTdXBwb3J0CiMKIyBDT05GSUdfUENJRV9EV19QTEFUX0hPU1QgaXMg bm90IHNldAojIENPTkZJR19QQ0lfSElTSSBpcyBub3Qgc2V0CiMgQ09ORklHX1BDSUVfS0lSSU4g aXMgbm90IHNldAojIENPTkZJR19QQ0lfTUVTT04gaXMgbm90IHNldAojIENPTkZJR19QQ0lFX0FM IGlzIG5vdCBzZXQKIyBlbmQgb2YgRGVzaWduV2FyZSBQQ0kgQ29yZSBTdXBwb3J0CgojCiMgTW9i aXZlaWwgUENJZSBDb3JlIFN1cHBvcnQKIwojIGVuZCBvZiBNb2JpdmVpbCBQQ0llIENvcmUgU3Vw cG9ydAoKIwojIENhZGVuY2UgUENJZSBjb250cm9sbGVycyBzdXBwb3J0CiMKIyBDT05GSUdfUENJ RV9DQURFTkNFX1BMQVRfSE9TVCBpcyBub3Qgc2V0CiMgQ09ORklHX1BDSV9KNzIxRV9IT1NUIGlz IG5vdCBzZXQKIyBlbmQgb2YgQ2FkZW5jZSBQQ0llIGNvbnRyb2xsZXJzIHN1cHBvcnQKIyBlbmQg b2YgUENJIGNvbnRyb2xsZXIgZHJpdmVycwoKIwojIFBDSSBFbmRwb2ludAojCiMgQ09ORklHX1BD SV9FTkRQT0lOVCBpcyBub3Qgc2V0CiMgZW5kIG9mIFBDSSBFbmRwb2ludAoKIwojIFBDSSBzd2l0 Y2ggY29udHJvbGxlciBkcml2ZXJzCiMKIyBDT05GSUdfUENJX1NXX1NXSVRDSFRFQyBpcyBub3Qg c2V0CiMgZW5kIG9mIFBDSSBzd2l0Y2ggY29udHJvbGxlciBkcml2ZXJzCgojIENPTkZJR19DWExf QlVTIGlzIG5vdCBzZXQKIyBDT05GSUdfUENDQVJEIGlzIG5vdCBzZXQKIyBDT05GSUdfUkFQSURJ TyBpcyBub3Qgc2V0CgojCiMgR2VuZXJpYyBEcml2ZXIgT3B0aW9ucwojCiMgQ09ORklHX1VFVkVO VF9IRUxQRVIgaXMgbm90IHNldApDT05GSUdfREVWVE1QRlM9eQpDT05GSUdfREVWVE1QRlNfTU9V TlQ9eQpDT05GSUdfU1RBTkRBTE9ORT15CkNPTkZJR19QUkVWRU5UX0ZJUk1XQVJFX0JVSUxEPXkK CiMKIyBGaXJtd2FyZSBsb2FkZXIKIwpDT05GSUdfRldfTE9BREVSPXkKQ09ORklHX0VYVFJBX0ZJ Uk1XQVJFPSIiCiMgQ09ORklHX0ZXX0xPQURFUl9VU0VSX0hFTFBFUiBpcyBub3Qgc2V0CiMgQ09O RklHX0ZXX0xPQURFUl9DT01QUkVTUyBpcyBub3Qgc2V0CkNPTkZJR19GV19DQUNIRT15CiMgZW5k IG9mIEZpcm13YXJlIGxvYWRlcgoKQ09ORklHX1dBTlRfREVWX0NPUkVEVU1QPXkKQ09ORklHX0FM TE9XX0RFVl9DT1JFRFVNUD15CkNPTkZJR19ERVZfQ09SRURVTVA9eQojIENPTkZJR19ERUJVR19E UklWRVIgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19ERVZSRVMgaXMgbm90IHNldAojIENPTkZJ R19ERUJVR19URVNUX0RSSVZFUl9SRU1PVkUgaXMgbm90IHNldAojIENPTkZJR19URVNUX0FTWU5D X0RSSVZFUl9QUk9CRSBpcyBub3Qgc2V0CkNPTkZJR19TWVNfSFlQRVJWSVNPUj15CkNPTkZJR19H RU5FUklDX0NQVV9BVVRPUFJPQkU9eQpDT05GSUdfR0VORVJJQ19DUFVfVlVMTkVSQUJJTElUSUVT PXkKQ09ORklHX1NPQ19CVVM9eQpDT05GSUdfUkVHTUFQPXkKQ09ORklHX1JFR01BUF9JMkM9eQpD T05GSUdfUkVHTUFQX1NQST1tCkNPTkZJR19SRUdNQVBfTU1JTz15CkNPTkZJR19SRUdNQVBfSVJR PXkKQ09ORklHX0RNQV9TSEFSRURfQlVGRkVSPXkKIyBDT05GSUdfRE1BX0ZFTkNFX1RSQUNFIGlz IG5vdCBzZXQKQ09ORklHX0dFTkVSSUNfQVJDSF9UT1BPTE9HWT15CiMgZW5kIG9mIEdlbmVyaWMg RHJpdmVyIE9wdGlvbnMKCiMKIyBCdXMgZGV2aWNlcwojCiMgQ09ORklHX0JSQ01TVEJfR0lTQl9B UkIgaXMgbm90IHNldAojIENPTkZJR19NT1hURVQgaXMgbm90IHNldAojIENPTkZJR19WRVhQUkVT U19DT05GSUcgaXMgbm90IHNldAojIENPTkZJR19NSElfQlVTIGlzIG5vdCBzZXQKIyBlbmQgb2Yg QnVzIGRldmljZXMKCiMgQ09ORklHX0NPTk5FQ1RPUiBpcyBub3Qgc2V0CgojCiMgRmlybXdhcmUg RHJpdmVycwojCgojCiMgQVJNIFN5c3RlbSBDb250cm9sIGFuZCBNYW5hZ2VtZW50IEludGVyZmFj ZSBQcm90b2NvbAojCiMgQ09ORklHX0FSTV9TQ01JX1BST1RPQ09MIGlzIG5vdCBzZXQKIyBlbmQg b2YgQVJNIFN5c3RlbSBDb250cm9sIGFuZCBNYW5hZ2VtZW50IEludGVyZmFjZSBQcm90b2NvbAoK IyBDT05GSUdfQVJNX1NDUElfUFJPVE9DT0wgaXMgbm90IHNldAojIENPTkZJR19GSVJNV0FSRV9N RU1NQVAgaXMgbm90IHNldApDT05GSUdfRE1JSUQ9eQojIENPTkZJR19ETUlfU1lTRlMgaXMgbm90 IHNldApDT05GSUdfUkFTUEJFUlJZUElfRklSTVdBUkU9eQojIENPTkZJR19GV19DRkdfU1lTRlMg aXMgbm90IHNldApDT05GSUdfU1lTRkI9eQojIENPTkZJR19TWVNGQl9TSU1QTEVGQiBpcyBub3Qg c2V0CiMgQ09ORklHX0FSTV9GRkFfVFJBTlNQT1JUIGlzIG5vdCBzZXQKIyBDT05GSUdfR09PR0xF X0ZJUk1XQVJFIGlzIG5vdCBzZXQKCiMKIyBFRkkgKEV4dGVuc2libGUgRmlybXdhcmUgSW50ZXJm YWNlKSBTdXBwb3J0CiMKQ09ORklHX0VGSV9FU1JUPXkKQ09ORklHX0VGSV9QQVJBTVNfRlJPTV9G RFQ9eQpDT05GSUdfRUZJX1JVTlRJTUVfV1JBUFBFUlM9eQpDT05GSUdfRUZJX0dFTkVSSUNfU1RV Qj15CkNPTkZJR19FRklfQVJNU1RVQl9EVEJfTE9BREVSPXkKIyBDT05GSUdfRUZJX0dFTkVSSUNf U1RVQl9JTklUUkRfQ01ETElORV9MT0FERVIgaXMgbm90IHNldAojIENPTkZJR19FRklfQk9PVExP QURFUl9DT05UUk9MIGlzIG5vdCBzZXQKIyBDT05GSUdfRUZJX0NBUFNVTEVfTE9BREVSIGlzIG5v dCBzZXQKIyBDT05GSUdfRUZJX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19SRVNFVF9BVFRBQ0tf TUlUSUdBVElPTiBpcyBub3Qgc2V0CiMgQ09ORklHX0VGSV9ESVNBQkxFX1BDSV9ETUEgaXMgbm90 IHNldAojIGVuZCBvZiBFRkkgKEV4dGVuc2libGUgRmlybXdhcmUgSW50ZXJmYWNlKSBTdXBwb3J0 CgpDT05GSUdfRUZJX0VBUkxZQ09OPXkKQ09ORklHX0FSTV9QU0NJX0ZXPXkKIyBDT05GSUdfQVJN X1BTQ0lfQ0hFQ0tFUiBpcyBub3Qgc2V0CkNPTkZJR19IQVZFX0FSTV9TTUNDQz15CkNPTkZJR19I QVZFX0FSTV9TTUNDQ19ESVNDT1ZFUlk9eQpDT05GSUdfQVJNX1NNQ0NDX1NPQ19JRD15CgojCiMg VGVncmEgZmlybXdhcmUgZHJpdmVyCiMKIyBlbmQgb2YgVGVncmEgZmlybXdhcmUgZHJpdmVyCiMg ZW5kIG9mIEZpcm13YXJlIERyaXZlcnMKCiMgQ09ORklHX0dOU1MgaXMgbm90IHNldApDT05GSUdf TVREPXkKIyBDT05GSUdfTVREX1RFU1RTIGlzIG5vdCBzZXQKCiMKIyBQYXJ0aXRpb24gcGFyc2Vy cwojCiMgQ09ORklHX01URF9BUjdfUEFSVFMgaXMgbm90IHNldAojIENPTkZJR19NVERfQ01ETElO RV9QQVJUUyBpcyBub3Qgc2V0CkNPTkZJR19NVERfT0ZfUEFSVFM9eQojIENPTkZJR19NVERfQUZT X1BBUlRTIGlzIG5vdCBzZXQKIyBDT05GSUdfTVREX1JFREJPT1RfUEFSVFMgaXMgbm90IHNldAoj IGVuZCBvZiBQYXJ0aXRpb24gcGFyc2VycwoKIwojIFVzZXIgTW9kdWxlcyBBbmQgVHJhbnNsYXRp b24gTGF5ZXJzCiMKQ09ORklHX01URF9CTEtERVZTPW0KQ09ORklHX01URF9CTE9DSz1tCiMgQ09O RklHX01URF9CTE9DS19STyBpcyBub3Qgc2V0CgojCiMgTm90ZSB0aGF0IGluIHNvbWUgY2FzZXMg VUJJIGJsb2NrIGlzIHByZWZlcnJlZC4gU2VlIE1URF9VQklfQkxPQ0suCiMKIyBDT05GSUdfRlRM IGlzIG5vdCBzZXQKIyBDT05GSUdfTkZUTCBpcyBub3Qgc2V0CiMgQ09ORklHX0lORlRMIGlzIG5v dCBzZXQKIyBDT05GSUdfUkZEX0ZUTCBpcyBub3Qgc2V0CiMgQ09ORklHX1NTRkRDIGlzIG5vdCBz ZXQKIyBDT05GSUdfU01fRlRMIGlzIG5vdCBzZXQKIyBDT05GSUdfTVREX09PUFMgaXMgbm90IHNl dAojIENPTkZJR19NVERfU1dBUCBpcyBub3Qgc2V0CiMgQ09ORklHX01URF9QQVJUSVRJT05FRF9N QVNURVIgaXMgbm90IHNldAoKIwojIFJBTS9ST00vRmxhc2ggY2hpcCBkcml2ZXJzCiMKIyBDT05G SUdfTVREX0NGSSBpcyBub3Qgc2V0CiMgQ09ORklHX01URF9KRURFQ1BST0JFIGlzIG5vdCBzZXQK Q09ORklHX01URF9NQVBfQkFOS19XSURUSF8xPXkKQ09ORklHX01URF9NQVBfQkFOS19XSURUSF8y PXkKQ09ORklHX01URF9NQVBfQkFOS19XSURUSF80PXkKQ09ORklHX01URF9DRklfSTE9eQpDT05G SUdfTVREX0NGSV9JMj15CiMgQ09ORklHX01URF9SQU0gaXMgbm90IHNldAojIENPTkZJR19NVERf Uk9NIGlzIG5vdCBzZXQKIyBDT05GSUdfTVREX0FCU0VOVCBpcyBub3Qgc2V0CiMgZW5kIG9mIFJB TS9ST00vRmxhc2ggY2hpcCBkcml2ZXJzCgojCiMgTWFwcGluZyBkcml2ZXJzIGZvciBjaGlwIGFj Y2VzcwojCiMgQ09ORklHX01URF9DT01QTEVYX01BUFBJTkdTIGlzIG5vdCBzZXQKIyBDT05GSUdf TVREX0lOVEVMX1ZSX05PUiBpcyBub3Qgc2V0CiMgQ09ORklHX01URF9QTEFUUkFNIGlzIG5vdCBz ZXQKIyBlbmQgb2YgTWFwcGluZyBkcml2ZXJzIGZvciBjaGlwIGFjY2VzcwoKIwojIFNlbGYtY29u dGFpbmVkIE1URCBkZXZpY2UgZHJpdmVycwojCiMgQ09ORklHX01URF9QTUM1NTEgaXMgbm90IHNl dAojIENPTkZJR19NVERfREFUQUZMQVNIIGlzIG5vdCBzZXQKIyBDT05GSUdfTVREX01DSFAyM0sy NTYgaXMgbm90IHNldAojIENPTkZJR19NVERfTUNIUDQ4TDY0MCBpcyBub3Qgc2V0CiMgQ09ORklH X01URF9TU1QyNUwgaXMgbm90IHNldAojIENPTkZJR19NVERfU0xSQU0gaXMgbm90IHNldAojIENP TkZJR19NVERfUEhSQU0gaXMgbm90IHNldAojIENPTkZJR19NVERfTVREUkFNIGlzIG5vdCBzZXQK IyBDT05GSUdfTVREX0JMT0NLMk1URCBpcyBub3Qgc2V0CgojCiMgRGlzay1Pbi1DaGlwIERldmlj ZSBEcml2ZXJzCiMKIyBDT05GSUdfTVREX0RPQ0czIGlzIG5vdCBzZXQKIyBlbmQgb2YgU2VsZi1j b250YWluZWQgTVREIGRldmljZSBkcml2ZXJzCgojCiMgTkFORAojCiMgQ09ORklHX01URF9PTkVO QU5EIGlzIG5vdCBzZXQKIyBDT05GSUdfTVREX1JBV19OQU5EIGlzIG5vdCBzZXQKIyBDT05GSUdf TVREX1NQSV9OQU5EIGlzIG5vdCBzZXQKCiMKIyBFQ0MgZW5naW5lIHN1cHBvcnQKIwojIENPTkZJ R19NVERfTkFORF9FQ0NfU1dfSEFNTUlORyBpcyBub3Qgc2V0CiMgQ09ORklHX01URF9OQU5EX0VD Q19TV19CQ0ggaXMgbm90IHNldAojIGVuZCBvZiBFQ0MgZW5naW5lIHN1cHBvcnQKIyBlbmQgb2Yg TkFORAoKIwojIExQRERSICYgTFBERFIyIFBDTSBtZW1vcnkgZHJpdmVycwojCiMgQ09ORklHX01U RF9MUEREUiBpcyBub3Qgc2V0CiMgZW5kIG9mIExQRERSICYgTFBERFIyIFBDTSBtZW1vcnkgZHJp dmVycwoKIyBDT05GSUdfTVREX1NQSV9OT1IgaXMgbm90IHNldAojIENPTkZJR19NVERfVUJJIGlz IG5vdCBzZXQKIyBDT05GSUdfTVREX0hZUEVSQlVTIGlzIG5vdCBzZXQKQ09ORklHX0RUQz15CkNP TkZJR19PRj15CiMgQ09ORklHX09GX1VOSVRURVNUIGlzIG5vdCBzZXQKQ09ORklHX09GX0ZMQVRU UkVFPXkKQ09ORklHX09GX0VBUkxZX0ZMQVRUUkVFPXkKQ09ORklHX09GX0tPQko9eQpDT05GSUdf T0ZfRFlOQU1JQz15CkNPTkZJR19PRl9BRERSRVNTPXkKQ09ORklHX09GX0lSUT15CkNPTkZJR19P Rl9SRVNFUlZFRF9NRU09eQpDT05GSUdfT0ZfUkVTT0xWRT15CkNPTkZJR19PRl9PVkVSTEFZPXkK IyBDT05GSUdfT0ZfQ09ORklHRlMgaXMgbm90IHNldAojIENPTkZJR19QQVJQT1JUIGlzIG5vdCBz ZXQKQ09ORklHX0JMS19ERVY9eQojIENPTkZJR19CTEtfREVWX05VTExfQkxLIGlzIG5vdCBzZXQK IyBDT05GSUdfQkxLX0RFVl9QQ0lFU1NEX01USVAzMlhYIGlzIG5vdCBzZXQKQ09ORklHX0JMS19E RVZfTE9PUD15CkNPTkZJR19CTEtfREVWX0xPT1BfTUlOX0NPVU5UPTgKQ09ORklHX0JMS19ERVZf Q1JZUFRPTE9PUD1tCiMgQ09ORklHX0JMS19ERVZfRFJCRCBpcyBub3Qgc2V0CkNPTkZJR19CTEtf REVWX05CRD1tCiMgQ09ORklHX0JMS19ERVZfU1g4IGlzIG5vdCBzZXQKQ09ORklHX0JMS19ERVZf UkFNPXkKQ09ORklHX0JMS19ERVZfUkFNX0NPVU5UPTE2CkNPTkZJR19CTEtfREVWX1JBTV9TSVpF PTQwOTYKIyBDT05GSUdfQ0RST01fUEtUQ0RWRCBpcyBub3Qgc2V0CiMgQ09ORklHX0FUQV9PVkVS X0VUSCBpcyBub3Qgc2V0CkNPTkZJR19YRU5fQkxLREVWX0ZST05URU5EPXkKQ09ORklHX1hFTl9C TEtERVZfQkFDS0VORD1tCiMgQ09ORklHX1ZJUlRJT19CTEsgaXMgbm90IHNldAojIENPTkZJR19C TEtfREVWX1JCRCBpcyBub3Qgc2V0CiMgQ09ORklHX0JMS19ERVZfUlNYWCBpcyBub3Qgc2V0Cgoj CiMgTlZNRSBTdXBwb3J0CiMKQ09ORklHX05WTUVfQ09SRT15CkNPTkZJR19CTEtfREVWX05WTUU9 eQojIENPTkZJR19OVk1FX01VTFRJUEFUSCBpcyBub3Qgc2V0CiMgQ09ORklHX05WTUVfRkMgaXMg bm90IHNldAojIENPTkZJR19OVk1FX1RDUCBpcyBub3Qgc2V0CiMgQ09ORklHX05WTUVfVEFSR0VU IGlzIG5vdCBzZXQKIyBlbmQgb2YgTlZNRSBTdXBwb3J0CgojCiMgTWlzYyBkZXZpY2VzCiMKIyBD T05GSUdfQUQ1MjVYX0RQT1QgaXMgbm90IHNldAojIENPTkZJR19EVU1NWV9JUlEgaXMgbm90IHNl dAojIENPTkZJR19QSEFOVE9NIGlzIG5vdCBzZXQKIyBDT05GSUdfVElGTV9DT1JFIGlzIG5vdCBz ZXQKIyBDT05GSUdfSUNTOTMyUzQwMSBpcyBub3Qgc2V0CiMgQ09ORklHX0VOQ0xPU1VSRV9TRVJW SUNFUyBpcyBub3Qgc2V0CiMgQ09ORklHX0hQX0lMTyBpcyBub3Qgc2V0CiMgQ09ORklHX0FQRFM5 ODAyQUxTIGlzIG5vdCBzZXQKIyBDT05GSUdfSVNMMjkwMDMgaXMgbm90IHNldAojIENPTkZJR19J U0wyOTAyMCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfVFNMMjU1MCBpcyBub3Qgc2V0CiMg Q09ORklHX1NFTlNPUlNfQkgxNzcwIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19BUERTOTkw WCBpcyBub3Qgc2V0CiMgQ09ORklHX0hNQzYzNTIgaXMgbm90IHNldAojIENPTkZJR19EUzE2ODIg aXMgbm90IHNldAojIENPTkZJR19MQVRUSUNFX0VDUDNfQ09ORklHIGlzIG5vdCBzZXQKIyBDT05G SUdfU1JBTSBpcyBub3Qgc2V0CiMgQ09ORklHX0RXX1hEQVRBX1BDSUUgaXMgbm90IHNldAojIENP TkZJR19QQ0lfRU5EUE9JTlRfVEVTVCBpcyBub3Qgc2V0CiMgQ09ORklHX1hJTElOWF9TREZFQyBp cyBub3Qgc2V0CiMgQ09ORklHX0hJU0lfSElLRVlfVVNCIGlzIG5vdCBzZXQKIyBDT05GSUdfQzJQ T1JUIGlzIG5vdCBzZXQKCiMKIyBFRVBST00gc3VwcG9ydAojCkNPTkZJR19FRVBST01fQVQyND1t CiMgQ09ORklHX0VFUFJPTV9BVDI1IGlzIG5vdCBzZXQKIyBDT05GSUdfRUVQUk9NX0xFR0FDWSBp cyBub3Qgc2V0CiMgQ09ORklHX0VFUFJPTV9NQVg2ODc1IGlzIG5vdCBzZXQKIyBDT05GSUdfRUVQ Uk9NXzkzQ1g2IGlzIG5vdCBzZXQKIyBDT05GSUdfRUVQUk9NXzkzWFg0NiBpcyBub3Qgc2V0CiMg Q09ORklHX0VFUFJPTV9JRFRfODlIUEVTWCBpcyBub3Qgc2V0CiMgQ09ORklHX0VFUFJPTV9FRTEw MDQgaXMgbm90IHNldAojIGVuZCBvZiBFRVBST00gc3VwcG9ydAoKIyBDT05GSUdfQ0I3MTBfQ09S RSBpcyBub3Qgc2V0CgojCiMgVGV4YXMgSW5zdHJ1bWVudHMgc2hhcmVkIHRyYW5zcG9ydCBsaW5l IGRpc2NpcGxpbmUKIwojIENPTkZJR19USV9TVCBpcyBub3Qgc2V0CiMgZW5kIG9mIFRleGFzIElu c3RydW1lbnRzIHNoYXJlZCB0cmFuc3BvcnQgbGluZSBkaXNjaXBsaW5lCgojIENPTkZJR19TRU5T T1JTX0xJUzNfU1BJIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19MSVMzX0kyQyBpcyBub3Qg c2V0CiMgQ09ORklHX0FMVEVSQV9TVEFQTCBpcyBub3Qgc2V0CiMgQ09ORklHX0dFTldRRSBpcyBu b3Qgc2V0CiMgQ09ORklHX0VDSE8gaXMgbm90IHNldAojIENPTkZJR19CQ01fVksgaXMgbm90IHNl dAojIENPTkZJR19NSVNDX0FMQ09SX1BDSSBpcyBub3Qgc2V0CiMgQ09ORklHX01JU0NfUlRTWF9Q Q0kgaXMgbm90IHNldAojIENPTkZJR19NSVNDX1JUU1hfVVNCIGlzIG5vdCBzZXQKIyBDT05GSUdf SEFCQU5BX0FJIGlzIG5vdCBzZXQKIyBDT05GSUdfVUFDQ0UgaXMgbm90IHNldAojIENPTkZJR19Q VlBBTklDIGlzIG5vdCBzZXQKIyBlbmQgb2YgTWlzYyBkZXZpY2VzCgojCiMgU0NTSSBkZXZpY2Ug c3VwcG9ydAojCkNPTkZJR19TQ1NJX01PRD15CiMgQ09ORklHX1JBSURfQVRUUlMgaXMgbm90IHNl dApDT05GSUdfU0NTSV9DT01NT049eQpDT05GSUdfU0NTST15CkNPTkZJR19TQ1NJX0RNQT15CkNP TkZJR19TQ1NJX1BST0NfRlM9eQoKIwojIFNDU0kgc3VwcG9ydCB0eXBlIChkaXNrLCB0YXBlLCBD RC1ST00pCiMKQ09ORklHX0JMS19ERVZfU0Q9eQojIENPTkZJR19DSFJfREVWX1NUIGlzIG5vdCBz ZXQKIyBDT05GSUdfQkxLX0RFVl9TUiBpcyBub3Qgc2V0CiMgQ09ORklHX0NIUl9ERVZfU0cgaXMg bm90IHNldApDT05GSUdfQkxLX0RFVl9CU0c9eQojIENPTkZJR19DSFJfREVWX1NDSCBpcyBub3Qg c2V0CiMgQ09ORklHX1NDU0lfQ09OU1RBTlRTIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV9MT0dH SU5HIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV9TQ0FOX0FTWU5DIGlzIG5vdCBzZXQKCiMKIyBT Q1NJIFRyYW5zcG9ydHMKIwojIENPTkZJR19TQ1NJX1NQSV9BVFRSUyBpcyBub3Qgc2V0CiMgQ09O RklHX1NDU0lfRkNfQVRUUlMgaXMgbm90IHNldAojIENPTkZJR19TQ1NJX0lTQ1NJX0FUVFJTIGlz IG5vdCBzZXQKIyBDT05GSUdfU0NTSV9TQVNfQVRUUlMgaXMgbm90IHNldAojIENPTkZJR19TQ1NJ X1NBU19MSUJTQVMgaXMgbm90IHNldAojIENPTkZJR19TQ1NJX1NSUF9BVFRSUyBpcyBub3Qgc2V0 CiMgZW5kIG9mIFNDU0kgVHJhbnNwb3J0cwoKQ09ORklHX1NDU0lfTE9XTEVWRUw9eQojIENPTkZJ R19JU0NTSV9UQ1AgaXMgbm90IHNldAojIENPTkZJR19JU0NTSV9CT09UX1NZU0ZTIGlzIG5vdCBz ZXQKIyBDT05GSUdfU0NTSV9DWEdCM19JU0NTSSBpcyBub3Qgc2V0CiMgQ09ORklHX1NDU0lfQ1hH QjRfSVNDU0kgaXMgbm90IHNldAojIENPTkZJR19TQ1NJX0JOWDJfSVNDU0kgaXMgbm90IHNldAoj IENPTkZJR19CRTJJU0NTSSBpcyBub3Qgc2V0CiMgQ09ORklHX0JMS19ERVZfM1dfWFhYWF9SQUlE IGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV9IUFNBIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV8z V185WFhYIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV8zV19TQVMgaXMgbm90IHNldAojIENPTkZJ R19TQ1NJX0FDQVJEIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV9BQUNSQUlEIGlzIG5vdCBzZXQK IyBDT05GSUdfU0NTSV9BSUM3WFhYIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV9BSUM3OVhYIGlz IG5vdCBzZXQKIyBDT05GSUdfU0NTSV9BSUM5NFhYIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV9I SVNJX1NBUyBpcyBub3Qgc2V0CiMgQ09ORklHX1NDU0lfTVZTQVMgaXMgbm90IHNldAojIENPTkZJ R19TQ1NJX01WVU1JIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV9BRFZBTlNZUyBpcyBub3Qgc2V0 CiMgQ09ORklHX1NDU0lfQVJDTVNSIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV9FU0FTMlIgaXMg bm90IHNldAojIENPTkZJR19NRUdBUkFJRF9ORVdHRU4gaXMgbm90IHNldAojIENPTkZJR19NRUdB UkFJRF9MRUdBQ1kgaXMgbm90IHNldAojIENPTkZJR19NRUdBUkFJRF9TQVMgaXMgbm90IHNldAoj IENPTkZJR19TQ1NJX01QVDNTQVMgaXMgbm90IHNldAojIENPTkZJR19TQ1NJX01QVDJTQVMgaXMg bm90IHNldAojIENPTkZJR19TQ1NJX01QSTNNUiBpcyBub3Qgc2V0CiMgQ09ORklHX1NDU0lfU01B UlRQUUkgaXMgbm90IHNldAojIENPTkZJR19TQ1NJX1VGU0hDRCBpcyBub3Qgc2V0CiMgQ09ORklH X1NDU0lfSFBUSU9QIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV9NWVJCIGlzIG5vdCBzZXQKIyBD T05GSUdfU0NTSV9NWVJTIGlzIG5vdCBzZXQKQ09ORklHX1hFTl9TQ1NJX0ZST05URU5EPXkKIyBD T05GSUdfU0NTSV9TTklDIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV9ETVgzMTkxRCBpcyBub3Qg c2V0CiMgQ09ORklHX1NDU0lfRkRPTUFJTl9QQ0kgaXMgbm90IHNldAojIENPTkZJR19TQ1NJX0lQ UyBpcyBub3Qgc2V0CiMgQ09ORklHX1NDU0lfSU5JVElPIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NT SV9JTklBMTAwIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV9TVEVYIGlzIG5vdCBzZXQKIyBDT05G SUdfU0NTSV9TWU01M0M4WFhfMiBpcyBub3Qgc2V0CiMgQ09ORklHX1NDU0lfSVBSIGlzIG5vdCBz ZXQKIyBDT05GSUdfU0NTSV9RTE9HSUNfMTI4MCBpcyBub3Qgc2V0CiMgQ09ORklHX1NDU0lfUUxB X0lTQ1NJIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV9EQzM5NXggaXMgbm90IHNldAojIENPTkZJ R19TQ1NJX0FNNTNDOTc0IGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV9XRDcxOVggaXMgbm90IHNl dApDT05GSUdfU0NTSV9ERUJVRz1tCiMgQ09ORklHX1NDU0lfUE1DUkFJRCBpcyBub3Qgc2V0CiMg Q09ORklHX1NDU0lfUE04MDAxIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NTSV9WSVJUSU8gaXMgbm90 IHNldAojIENPTkZJR19TQ1NJX0RIIGlzIG5vdCBzZXQKIyBlbmQgb2YgU0NTSSBkZXZpY2Ugc3Vw cG9ydAoKQ09ORklHX0hBVkVfUEFUQV9QTEFURk9STT15CkNPTkZJR19BVEE9bQpDT05GSUdfU0FU QV9IT1NUPXkKQ09ORklHX0FUQV9WRVJCT1NFX0VSUk9SPXkKQ09ORklHX0FUQV9GT1JDRT15CkNP TkZJR19TQVRBX1BNUD15CgojCiMgQ29udHJvbGxlcnMgd2l0aCBub24tU0ZGIG5hdGl2ZSBpbnRl cmZhY2UKIwpDT05GSUdfU0FUQV9BSENJPW0KQ09ORklHX1NBVEFfTU9CSUxFX0xQTV9QT0xJQ1k9 MAojIENPTkZJR19TQVRBX0FIQ0lfUExBVEZPUk0gaXMgbm90IHNldAojIENPTkZJR19BSENJX0NF VkEgaXMgbm90IHNldAojIENPTkZJR19BSENJX1FPUklRIGlzIG5vdCBzZXQKIyBDT05GSUdfU0FU QV9JTklDMTYyWCBpcyBub3Qgc2V0CiMgQ09ORklHX1NBVEFfQUNBUkRfQUhDSSBpcyBub3Qgc2V0 CiMgQ09ORklHX1NBVEFfU0lMMjQgaXMgbm90IHNldApDT05GSUdfQVRBX1NGRj15CgojCiMgU0ZG IGNvbnRyb2xsZXJzIHdpdGggY3VzdG9tIERNQSBpbnRlcmZhY2UKIwojIENPTkZJR19QRENfQURN QSBpcyBub3Qgc2V0CiMgQ09ORklHX1NBVEFfUVNUT1IgaXMgbm90IHNldAojIENPTkZJR19TQVRB X1NYNCBpcyBub3Qgc2V0CkNPTkZJR19BVEFfQk1ETUE9eQoKIwojIFNBVEEgU0ZGIGNvbnRyb2xs ZXJzIHdpdGggQk1ETUEKIwojIENPTkZJR19BVEFfUElJWCBpcyBub3Qgc2V0CiMgQ09ORklHX1NB VEFfRFdDIGlzIG5vdCBzZXQKQ09ORklHX1NBVEFfTVY9bQojIENPTkZJR19TQVRBX05WIGlzIG5v dCBzZXQKIyBDT05GSUdfU0FUQV9QUk9NSVNFIGlzIG5vdCBzZXQKIyBDT05GSUdfU0FUQV9TSUwg aXMgbm90IHNldAojIENPTkZJR19TQVRBX1NJUyBpcyBub3Qgc2V0CiMgQ09ORklHX1NBVEFfU1ZX IGlzIG5vdCBzZXQKIyBDT05GSUdfU0FUQV9VTEkgaXMgbm90IHNldAojIENPTkZJR19TQVRBX1ZJ QSBpcyBub3Qgc2V0CiMgQ09ORklHX1NBVEFfVklURVNTRSBpcyBub3Qgc2V0CgojCiMgUEFUQSBT RkYgY29udHJvbGxlcnMgd2l0aCBCTURNQQojCiMgQ09ORklHX1BBVEFfQUxJIGlzIG5vdCBzZXQK IyBDT05GSUdfUEFUQV9BTUQgaXMgbm90IHNldAojIENPTkZJR19QQVRBX0FSVE9QIGlzIG5vdCBz ZXQKIyBDT05GSUdfUEFUQV9BVElJWFAgaXMgbm90IHNldAojIENPTkZJR19QQVRBX0FUUDg2N1gg aXMgbm90IHNldAojIENPTkZJR19QQVRBX0NNRDY0WCBpcyBub3Qgc2V0CiMgQ09ORklHX1BBVEFf Q1lQUkVTUyBpcyBub3Qgc2V0CiMgQ09ORklHX1BBVEFfRUZBUiBpcyBub3Qgc2V0CiMgQ09ORklH X1BBVEFfSFBUMzY2IGlzIG5vdCBzZXQKIyBDT05GSUdfUEFUQV9IUFQzN1ggaXMgbm90IHNldAoj IENPTkZJR19QQVRBX0hQVDNYMk4gaXMgbm90IHNldAojIENPTkZJR19QQVRBX0hQVDNYMyBpcyBu b3Qgc2V0CiMgQ09ORklHX1BBVEFfSVQ4MjEzIGlzIG5vdCBzZXQKIyBDT05GSUdfUEFUQV9JVDgy MVggaXMgbm90IHNldAojIENPTkZJR19QQVRBX0pNSUNST04gaXMgbm90IHNldAojIENPTkZJR19Q QVRBX01BUlZFTEwgaXMgbm90IHNldAojIENPTkZJR19QQVRBX05FVENFTEwgaXMgbm90IHNldAoj IENPTkZJR19QQVRBX05JTkpBMzIgaXMgbm90IHNldAojIENPTkZJR19QQVRBX05TODc0MTUgaXMg bm90IHNldAojIENPTkZJR19QQVRBX09MRFBJSVggaXMgbm90IHNldAojIENPTkZJR19QQVRBX09Q VElETUEgaXMgbm90IHNldAojIENPTkZJR19QQVRBX1BEQzIwMjdYIGlzIG5vdCBzZXQKIyBDT05G SUdfUEFUQV9QRENfT0xEIGlzIG5vdCBzZXQKIyBDT05GSUdfUEFUQV9SQURJU1lTIGlzIG5vdCBz ZXQKIyBDT05GSUdfUEFUQV9SREMgaXMgbm90IHNldAojIENPTkZJR19QQVRBX1NDSCBpcyBub3Qg c2V0CiMgQ09ORklHX1BBVEFfU0VSVkVSV09SS1MgaXMgbm90IHNldAojIENPTkZJR19QQVRBX1NJ TDY4MCBpcyBub3Qgc2V0CiMgQ09ORklHX1BBVEFfU0lTIGlzIG5vdCBzZXQKIyBDT05GSUdfUEFU QV9UT1NISUJBIGlzIG5vdCBzZXQKIyBDT05GSUdfUEFUQV9UUklGTEVYIGlzIG5vdCBzZXQKIyBD T05GSUdfUEFUQV9WSUEgaXMgbm90IHNldAojIENPTkZJR19QQVRBX1dJTkJPTkQgaXMgbm90IHNl dAoKIwojIFBJTy1vbmx5IFNGRiBjb250cm9sbGVycwojCiMgQ09ORklHX1BBVEFfQ01ENjQwX1BD SSBpcyBub3Qgc2V0CiMgQ09ORklHX1BBVEFfTVBJSVggaXMgbm90IHNldAojIENPTkZJR19QQVRB X05TODc0MTAgaXMgbm90IHNldAojIENPTkZJR19QQVRBX09QVEkgaXMgbm90IHNldAojIENPTkZJ R19QQVRBX1BMQVRGT1JNIGlzIG5vdCBzZXQKIyBDT05GSUdfUEFUQV9SWjEwMDAgaXMgbm90IHNl dAoKIwojIEdlbmVyaWMgZmFsbGJhY2sgLyBsZWdhY3kgZHJpdmVycwojCiMgQ09ORklHX0FUQV9H RU5FUklDIGlzIG5vdCBzZXQKIyBDT05GSUdfUEFUQV9MRUdBQ1kgaXMgbm90IHNldApDT05GSUdf TUQ9eQpDT05GSUdfQkxLX0RFVl9NRD15CkNPTkZJR19NRF9BVVRPREVURUNUPXkKQ09ORklHX01E X0xJTkVBUj15CkNPTkZJR19NRF9SQUlEMD15CkNPTkZJR19NRF9SQUlEMT15CkNPTkZJR19NRF9S QUlEMTA9eQpDT05GSUdfTURfUkFJRDQ1Nj15CkNPTkZJR19NRF9NVUxUSVBBVEg9eQpDT05GSUdf TURfRkFVTFRZPXkKIyBDT05GSUdfQkNBQ0hFIGlzIG5vdCBzZXQKQ09ORklHX0JMS19ERVZfRE1f QlVJTFRJTj15CkNPTkZJR19CTEtfREVWX0RNPXkKIyBDT05GSUdfRE1fREVCVUcgaXMgbm90IHNl dApDT05GSUdfRE1fQlVGSU89eQojIENPTkZJR19ETV9ERUJVR19CTE9DS19NQU5BR0VSX0xPQ0tJ TkcgaXMgbm90IHNldAojIENPTkZJR19ETV9VTlNUUklQRUQgaXMgbm90IHNldApDT05GSUdfRE1f Q1JZUFQ9eQpDT05GSUdfRE1fU05BUFNIT1Q9eQojIENPTkZJR19ETV9USElOX1BST1ZJU0lPTklO RyBpcyBub3Qgc2V0CiMgQ09ORklHX0RNX0NBQ0hFIGlzIG5vdCBzZXQKIyBDT05GSUdfRE1fV1JJ VEVDQUNIRSBpcyBub3Qgc2V0CiMgQ09ORklHX0RNX0VCUyBpcyBub3Qgc2V0CiMgQ09ORklHX0RN X0VSQSBpcyBub3Qgc2V0CiMgQ09ORklHX0RNX0NMT05FIGlzIG5vdCBzZXQKQ09ORklHX0RNX01J UlJPUj15CiMgQ09ORklHX0RNX0xPR19VU0VSU1BBQ0UgaXMgbm90IHNldAojIENPTkZJR19ETV9S QUlEIGlzIG5vdCBzZXQKQ09ORklHX0RNX1pFUk89eQojIENPTkZJR19ETV9NVUxUSVBBVEggaXMg bm90IHNldAojIENPTkZJR19ETV9ERUxBWSBpcyBub3Qgc2V0CiMgQ09ORklHX0RNX0RVU1QgaXMg bm90IHNldAojIENPTkZJR19ETV9JTklUIGlzIG5vdCBzZXQKIyBDT05GSUdfRE1fVUVWRU5UIGlz IG5vdCBzZXQKIyBDT05GSUdfRE1fRkxBS0VZIGlzIG5vdCBzZXQKIyBDT05GSUdfRE1fVkVSSVRZ IGlzIG5vdCBzZXQKIyBDT05GSUdfRE1fU1dJVENIIGlzIG5vdCBzZXQKIyBDT05GSUdfRE1fTE9H X1dSSVRFUyBpcyBub3Qgc2V0CiMgQ09ORklHX0RNX0lOVEVHUklUWSBpcyBub3Qgc2V0CiMgQ09O RklHX1RBUkdFVF9DT1JFIGlzIG5vdCBzZXQKIyBDT05GSUdfRlVTSU9OIGlzIG5vdCBzZXQKCiMK IyBJRUVFIDEzOTQgKEZpcmVXaXJlKSBzdXBwb3J0CiMKIyBDT05GSUdfRklSRVdJUkUgaXMgbm90 IHNldAojIENPTkZJR19GSVJFV0lSRV9OT1NZIGlzIG5vdCBzZXQKIyBlbmQgb2YgSUVFRSAxMzk0 IChGaXJlV2lyZSkgc3VwcG9ydAoKQ09ORklHX05FVERFVklDRVM9eQpDT05GSUdfTUlJPXkKQ09O RklHX05FVF9DT1JFPXkKQ09ORklHX0JPTkRJTkc9bQpDT05GSUdfRFVNTVk9bQojIENPTkZJR19X SVJFR1VBUkQgaXMgbm90IHNldAojIENPTkZJR19FUVVBTElaRVIgaXMgbm90IHNldAojIENPTkZJ R19ORVRfRkMgaXMgbm90IHNldAojIENPTkZJR19JRkIgaXMgbm90IHNldAojIENPTkZJR19ORVRf VEVBTSBpcyBub3Qgc2V0CiMgQ09ORklHX01BQ1ZMQU4gaXMgbm90IHNldAojIENPTkZJR19JUFZM QU4gaXMgbm90IHNldAojIENPTkZJR19WWExBTiBpcyBub3Qgc2V0CiMgQ09ORklHX0dFTkVWRSBp cyBub3Qgc2V0CiMgQ09ORklHX0JBUkVVRFAgaXMgbm90IHNldAojIENPTkZJR19HVFAgaXMgbm90 IHNldAojIENPTkZJR19NQUNTRUMgaXMgbm90IHNldApDT05GSUdfTkVUQ09OU09MRT15CkNPTkZJ R19ORVRQT0xMPXkKQ09ORklHX05FVF9QT0xMX0NPTlRST0xMRVI9eQpDT05GSUdfVFVOPW0KIyBD T05GSUdfVFVOX1ZORVRfQ1JPU1NfTEUgaXMgbm90IHNldApDT05GSUdfVkVUSD15CiMgQ09ORklH X1ZJUlRJT19ORVQgaXMgbm90IHNldApDT05GSUdfTkxNT049eQojIENPTkZJR19BUkNORVQgaXMg bm90IHNldApDT05GSUdfRVRIRVJORVQ9eQpDT05GSUdfTkVUX1ZFTkRPUl8zQ09NPXkKIyBDT05G SUdfVk9SVEVYIGlzIG5vdCBzZXQKIyBDT05GSUdfVFlQSE9PTiBpcyBub3Qgc2V0CkNPTkZJR19O RVRfVkVORE9SX0FEQVBURUM9eQojIENPTkZJR19BREFQVEVDX1NUQVJGSVJFIGlzIG5vdCBzZXQK Q09ORklHX05FVF9WRU5ET1JfQUdFUkU9eQojIENPTkZJR19FVDEzMVggaXMgbm90IHNldApDT05G SUdfTkVUX1ZFTkRPUl9BTEFDUklURUNIPXkKIyBDT05GSUdfU0xJQ09TUyBpcyBub3Qgc2V0CkNP TkZJR19ORVRfVkVORE9SX0FMVEVPTj15CiMgQ09ORklHX0FDRU5JQyBpcyBub3Qgc2V0CiMgQ09O RklHX0FMVEVSQV9UU0UgaXMgbm90IHNldApDT05GSUdfTkVUX1ZFTkRPUl9BTUFaT049eQojIENP TkZJR19FTkFfRVRIRVJORVQgaXMgbm90IHNldApDT05GSUdfTkVUX1ZFTkRPUl9BTUQ9eQojIENP TkZJR19BTUQ4MTExX0VUSCBpcyBub3Qgc2V0CiMgQ09ORklHX1BDTkVUMzIgaXMgbm90IHNldAoj IENPTkZJR19BTURfWEdCRSBpcyBub3Qgc2V0CkNPTkZJR19ORVRfVkVORE9SX0FRVUFOVElBPXkK IyBDT05GSUdfQVFUSU9OIGlzIG5vdCBzZXQKQ09ORklHX05FVF9WRU5ET1JfQVJDPXkKQ09ORklH X05FVF9WRU5ET1JfQVRIRVJPUz15CiMgQ09ORklHX0FUTDIgaXMgbm90IHNldAojIENPTkZJR19B VEwxIGlzIG5vdCBzZXQKIyBDT05GSUdfQVRMMUUgaXMgbm90IHNldAojIENPTkZJR19BVEwxQyBp cyBub3Qgc2V0CiMgQ09ORklHX0FMWCBpcyBub3Qgc2V0CkNPTkZJR19ORVRfVkVORE9SX0JST0FE Q09NPXkKIyBDT05GSUdfQjQ0IGlzIG5vdCBzZXQKQ09ORklHX0JDTUdFTkVUPXkKIyBDT05GSUdf Qk5YMiBpcyBub3Qgc2V0CiMgQ09ORklHX0NOSUMgaXMgbm90IHNldAojIENPTkZJR19USUdPTjMg aXMgbm90IHNldAojIENPTkZJR19CTlgyWCBpcyBub3Qgc2V0CiMgQ09ORklHX1NZU1RFTVBPUlQg aXMgbm90IHNldAojIENPTkZJR19CTlhUIGlzIG5vdCBzZXQKQ09ORklHX05FVF9WRU5ET1JfQ0FE RU5DRT15CiMgQ09ORklHX01BQ0IgaXMgbm90IHNldApDT05GSUdfTkVUX1ZFTkRPUl9DQVZJVU09 eQojIENPTkZJR19USFVOREVSX05JQ19QRiBpcyBub3Qgc2V0CiMgQ09ORklHX1RIVU5ERVJfTklD X1ZGIGlzIG5vdCBzZXQKIyBDT05GSUdfVEhVTkRFUl9OSUNfQkdYIGlzIG5vdCBzZXQKIyBDT05G SUdfVEhVTkRFUl9OSUNfUkdYIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0FWSVVNX1BUUCBpcyBub3Qg c2V0CiMgQ09ORklHX0xJUVVJRElPIGlzIG5vdCBzZXQKIyBDT05GSUdfTElRVUlESU9fVkYgaXMg bm90IHNldApDT05GSUdfTkVUX1ZFTkRPUl9DSEVMU0lPPXkKIyBDT05GSUdfQ0hFTFNJT19UMSBp cyBub3Qgc2V0CiMgQ09ORklHX0NIRUxTSU9fVDMgaXMgbm90IHNldAojIENPTkZJR19DSEVMU0lP X1Q0IGlzIG5vdCBzZXQKIyBDT05GSUdfQ0hFTFNJT19UNFZGIGlzIG5vdCBzZXQKQ09ORklHX05F VF9WRU5ET1JfQ0lTQ089eQojIENPTkZJR19FTklDIGlzIG5vdCBzZXQKQ09ORklHX05FVF9WRU5E T1JfQ09SVElOQT15CiMgQ09ORklHX0dFTUlOSV9FVEhFUk5FVCBpcyBub3Qgc2V0CiMgQ09ORklH X0RORVQgaXMgbm90IHNldApDT05GSUdfTkVUX1ZFTkRPUl9ERUM9eQojIENPTkZJR19ORVRfVFVM SVAgaXMgbm90IHNldApDT05GSUdfTkVUX1ZFTkRPUl9ETElOSz15CiMgQ09ORklHX0RMMksgaXMg bm90IHNldAojIENPTkZJR19TVU5EQU5DRSBpcyBub3Qgc2V0CkNPTkZJR19ORVRfVkVORE9SX0VN VUxFWD15CiMgQ09ORklHX0JFMk5FVCBpcyBub3Qgc2V0CkNPTkZJR19ORVRfVkVORE9SX0VaQ0hJ UD15CiMgQ09ORklHX0VaQ0hJUF9OUFNfTUFOQUdFTUVOVF9FTkVUIGlzIG5vdCBzZXQKQ09ORklH X05FVF9WRU5ET1JfR09PR0xFPXkKIyBDT05GSUdfR1ZFIGlzIG5vdCBzZXQKQ09ORklHX05FVF9W RU5ET1JfSElTSUxJQ09OPXkKIyBDT05GSUdfSElYNUhEMl9HTUFDIGlzIG5vdCBzZXQKIyBDT05G SUdfSElTSV9GRU1BQyBpcyBub3Qgc2V0CiMgQ09ORklHX0hJUDA0X0VUSCBpcyBub3Qgc2V0CiMg Q09ORklHX0hOU19EU0FGIGlzIG5vdCBzZXQKIyBDT05GSUdfSE5TX0VORVQgaXMgbm90IHNldAoj IENPTkZJR19ITlMzIGlzIG5vdCBzZXQKQ09ORklHX05FVF9WRU5ET1JfSFVBV0VJPXkKIyBDT05G SUdfSElOSUMgaXMgbm90IHNldApDT05GSUdfTkVUX1ZFTkRPUl9JODI1WFg9eQpDT05GSUdfTkVU X1ZFTkRPUl9JTlRFTD15CiMgQ09ORklHX0UxMDAgaXMgbm90IHNldAojIENPTkZJR19FMTAwMCBp cyBub3Qgc2V0CiMgQ09ORklHX0UxMDAwRSBpcyBub3Qgc2V0CiMgQ09ORklHX0lHQiBpcyBub3Qg c2V0CiMgQ09ORklHX0lHQlZGIGlzIG5vdCBzZXQKIyBDT05GSUdfSVhHQiBpcyBub3Qgc2V0CiMg Q09ORklHX0lYR0JFIGlzIG5vdCBzZXQKIyBDT05GSUdfSVhHQkVWRiBpcyBub3Qgc2V0CiMgQ09O RklHX0k0MEUgaXMgbm90IHNldAojIENPTkZJR19JNDBFVkYgaXMgbm90IHNldAojIENPTkZJR19J Q0UgaXMgbm90IHNldAojIENPTkZJR19GTTEwSyBpcyBub3Qgc2V0CiMgQ09ORklHX0lHQyBpcyBu b3Qgc2V0CiMgQ09ORklHX0pNRSBpcyBub3Qgc2V0CkNPTkZJR19ORVRfVkVORE9SX0xJVEVYPXkK IyBDT05GSUdfTElURVhfTElURUVUSCBpcyBub3Qgc2V0CkNPTkZJR19ORVRfVkVORE9SX01BUlZF TEw9eQojIENPTkZJR19NVk1ESU8gaXMgbm90IHNldAojIENPTkZJR19TS0dFIGlzIG5vdCBzZXQK IyBDT05GSUdfU0tZMiBpcyBub3Qgc2V0CiMgQ09ORklHX09DVEVPTlRYMl9BRiBpcyBub3Qgc2V0 CiMgQ09ORklHX09DVEVPTlRYMl9QRiBpcyBub3Qgc2V0CkNPTkZJR19ORVRfVkVORE9SX01FTExB Tk9YPXkKIyBDT05GSUdfTUxYNF9FTiBpcyBub3Qgc2V0CiMgQ09ORklHX01MWDVfQ09SRSBpcyBu b3Qgc2V0CiMgQ09ORklHX01MWFNXX0NPUkUgaXMgbm90IHNldAojIENPTkZJR19NTFhGVyBpcyBu b3Qgc2V0CkNPTkZJR19ORVRfVkVORE9SX01JQ1JFTD15CiMgQ09ORklHX0tTODg0MiBpcyBub3Qg c2V0CiMgQ09ORklHX0tTODg1MSBpcyBub3Qgc2V0CiMgQ09ORklHX0tTODg1MV9NTEwgaXMgbm90 IHNldAojIENPTkZJR19LU1o4ODRYX1BDSSBpcyBub3Qgc2V0CkNPTkZJR19ORVRfVkVORE9SX01J Q1JPQ0hJUD15CiMgQ09ORklHX0VOQzI4SjYwIGlzIG5vdCBzZXQKIyBDT05GSUdfRU5DWDI0SjYw MCBpcyBub3Qgc2V0CiMgQ09ORklHX0xBTjc0M1ggaXMgbm90IHNldApDT05GSUdfTkVUX1ZFTkRP Ul9NSUNST1NFTUk9eQpDT05GSUdfTkVUX1ZFTkRPUl9NSUNST1NPRlQ9eQpDT05GSUdfTkVUX1ZF TkRPUl9NWVJJPXkKIyBDT05GSUdfTVlSSTEwR0UgaXMgbm90IHNldAojIENPTkZJR19GRUFMTlgg aXMgbm90IHNldApDT05GSUdfTkVUX1ZFTkRPUl9OST15CiMgQ09ORklHX05JX1hHRV9NQU5BR0VN RU5UX0VORVQgaXMgbm90IHNldApDT05GSUdfTkVUX1ZFTkRPUl9OQVRTRU1JPXkKIyBDT05GSUdf TkFUU0VNSSBpcyBub3Qgc2V0CiMgQ09ORklHX05TODM4MjAgaXMgbm90IHNldApDT05GSUdfTkVU X1ZFTkRPUl9ORVRFUklPTj15CiMgQ09ORklHX1MySU8gaXMgbm90IHNldAojIENPTkZJR19WWEdF IGlzIG5vdCBzZXQKQ09ORklHX05FVF9WRU5ET1JfTkVUUk9OT01FPXkKIyBDT05GSUdfTkZQIGlz IG5vdCBzZXQKQ09ORklHX05FVF9WRU5ET1JfODM5MD15CiMgQ09ORklHX05FMktfUENJIGlzIG5v dCBzZXQKQ09ORklHX05FVF9WRU5ET1JfTlZJRElBPXkKIyBDT05GSUdfRk9SQ0VERVRIIGlzIG5v dCBzZXQKQ09ORklHX05FVF9WRU5ET1JfT0tJPXkKIyBDT05GSUdfRVRIT0MgaXMgbm90IHNldApD T05GSUdfTkVUX1ZFTkRPUl9QQUNLRVRfRU5HSU5FUz15CiMgQ09ORklHX0hBTUFDSEkgaXMgbm90 IHNldAojIENPTkZJR19ZRUxMT1dGSU4gaXMgbm90IHNldApDT05GSUdfTkVUX1ZFTkRPUl9QRU5T QU5ETz15CiMgQ09ORklHX0lPTklDIGlzIG5vdCBzZXQKQ09ORklHX05FVF9WRU5ET1JfUUxPR0lD PXkKIyBDT05GSUdfUUxBM1hYWCBpcyBub3Qgc2V0CiMgQ09ORklHX1FMQ05JQyBpcyBub3Qgc2V0 CkNPTkZJR19ORVRYRU5fTklDPXkKIyBDT05GSUdfUUVEIGlzIG5vdCBzZXQKQ09ORklHX05FVF9W RU5ET1JfQlJPQ0FERT15CiMgQ09ORklHX0JOQSBpcyBub3Qgc2V0CkNPTkZJR19ORVRfVkVORE9S X1FVQUxDT01NPXkKQ09ORklHX1FDQTcwMDA9bQojIENPTkZJR19RQ0E3MDAwX1NQSSBpcyBub3Qg c2V0CkNPTkZJR19RQ0E3MDAwX1VBUlQ9bQojIENPTkZJR19RQ09NX0VNQUMgaXMgbm90IHNldAoj IENPTkZJR19STU5FVCBpcyBub3Qgc2V0CkNPTkZJR19ORVRfVkVORE9SX1JEQz15CiMgQ09ORklH X1I2MDQwIGlzIG5vdCBzZXQKQ09ORklHX05FVF9WRU5ET1JfUkVBTFRFSz15CiMgQ09ORklHXzgx MzlDUCBpcyBub3Qgc2V0CiMgQ09ORklHXzgxMzlUT08gaXMgbm90IHNldAojIENPTkZJR19SODE2 OSBpcyBub3Qgc2V0CkNPTkZJR19ORVRfVkVORE9SX1JFTkVTQVM9eQpDT05GSUdfTkVUX1ZFTkRP Ul9ST0NLRVI9eQpDT05GSUdfTkVUX1ZFTkRPUl9TQU1TVU5HPXkKIyBDT05GSUdfU1hHQkVfRVRI IGlzIG5vdCBzZXQKQ09ORklHX05FVF9WRU5ET1JfU0VFUT15CkNPTkZJR19ORVRfVkVORE9SX1NJ TEFOPXkKIyBDT05GSUdfU0M5MjAzMSBpcyBub3Qgc2V0CkNPTkZJR19ORVRfVkVORE9SX1NJUz15 CiMgQ09ORklHX1NJUzkwMCBpcyBub3Qgc2V0CiMgQ09ORklHX1NJUzE5MCBpcyBub3Qgc2V0CkNP TkZJR19ORVRfVkVORE9SX1NPTEFSRkxBUkU9eQojIENPTkZJR19TRkMgaXMgbm90IHNldAojIENP TkZJR19TRkNfRkFMQ09OIGlzIG5vdCBzZXQKQ09ORklHX05FVF9WRU5ET1JfU01TQz15CiMgQ09O RklHX1NNQzkxWCBpcyBub3Qgc2V0CiMgQ09ORklHX0VQSUMxMDAgaXMgbm90IHNldAojIENPTkZJ R19TTVNDOTExWCBpcyBub3Qgc2V0CiMgQ09ORklHX1NNU0M5NDIwIGlzIG5vdCBzZXQKQ09ORklH X05FVF9WRU5ET1JfU09DSU9ORVhUPXkKQ09ORklHX05FVF9WRU5ET1JfU1RNSUNSTz15CiMgQ09O RklHX1NUTU1BQ19FVEggaXMgbm90IHNldApDT05GSUdfTkVUX1ZFTkRPUl9TVU49eQojIENPTkZJ R19IQVBQWU1FQUwgaXMgbm90IHNldAojIENPTkZJR19TVU5HRU0gaXMgbm90IHNldAojIENPTkZJ R19DQVNTSU5JIGlzIG5vdCBzZXQKIyBDT05GSUdfTklVIGlzIG5vdCBzZXQKQ09ORklHX05FVF9W RU5ET1JfU1lOT1BTWVM9eQojIENPTkZJR19EV0NfWExHTUFDIGlzIG5vdCBzZXQKQ09ORklHX05F VF9WRU5ET1JfVEVIVVRJPXkKIyBDT05GSUdfVEVIVVRJIGlzIG5vdCBzZXQKQ09ORklHX05FVF9W RU5ET1JfVEk9eQojIENPTkZJR19USV9DUFNXX1BIWV9TRUwgaXMgbm90IHNldAojIENPTkZJR19U TEFOIGlzIG5vdCBzZXQKQ09ORklHX05FVF9WRU5ET1JfVklBPXkKIyBDT05GSUdfVklBX1JISU5F IGlzIG5vdCBzZXQKIyBDT05GSUdfVklBX1ZFTE9DSVRZIGlzIG5vdCBzZXQKQ09ORklHX05FVF9W RU5ET1JfV0laTkVUPXkKIyBDT05GSUdfV0laTkVUX1c1MTAwIGlzIG5vdCBzZXQKIyBDT05GSUdf V0laTkVUX1c1MzAwIGlzIG5vdCBzZXQKQ09ORklHX05FVF9WRU5ET1JfWElMSU5YPXkKIyBDT05G SUdfWElMSU5YX0VNQUNMSVRFIGlzIG5vdCBzZXQKIyBDT05GSUdfWElMSU5YX0FYSV9FTUFDIGlz IG5vdCBzZXQKIyBDT05GSUdfWElMSU5YX0xMX1RFTUFDIGlzIG5vdCBzZXQKIyBDT05GSUdfRkRE SSBpcyBub3Qgc2V0CiMgQ09ORklHX0hJUFBJIGlzIG5vdCBzZXQKQ09ORklHX1BIWUxJQj15CkNP TkZJR19TV1BIWT15CkNPTkZJR19GSVhFRF9QSFk9eQoKIwojIE1JSSBQSFkgZGV2aWNlIGRyaXZl cnMKIwojIENPTkZJR19BTURfUEhZIGlzIG5vdCBzZXQKIyBDT05GSUdfQURJTl9QSFkgaXMgbm90 IHNldAojIENPTkZJR19BUVVBTlRJQV9QSFkgaXMgbm90IHNldApDT05GSUdfQVg4ODc5NkJfUEhZ PXkKQ09ORklHX0JST0FEQ09NX1BIWT15CiMgQ09ORklHX0JDTTU0MTQwX1BIWSBpcyBub3Qgc2V0 CkNPTkZJR19CQ003WFhYX1BIWT15CiMgQ09ORklHX0JDTTg0ODgxX1BIWSBpcyBub3Qgc2V0CiMg Q09ORklHX0JDTTg3WFhfUEhZIGlzIG5vdCBzZXQKQ09ORklHX0JDTV9ORVRfUEhZTElCPXkKIyBD T05GSUdfQ0lDQURBX1BIWSBpcyBub3Qgc2V0CiMgQ09ORklHX0NPUlRJTkFfUEhZIGlzIG5vdCBz ZXQKIyBDT05GSUdfREFWSUNPTV9QSFkgaXMgbm90IHNldAojIENPTkZJR19JQ1BMVVNfUEhZIGlz IG5vdCBzZXQKIyBDT05GSUdfTFhUX1BIWSBpcyBub3Qgc2V0CiMgQ09ORklHX0lOVEVMX1hXQVlf UEhZIGlzIG5vdCBzZXQKIyBDT05GSUdfTFNJX0VUMTAxMUNfUEhZIGlzIG5vdCBzZXQKIyBDT05G SUdfTUFSVkVMTF9QSFkgaXMgbm90IHNldAojIENPTkZJR19NQVJWRUxMXzEwR19QSFkgaXMgbm90 IHNldAojIENPTkZJR19NQVJWRUxMXzg4WDIyMjJfUEhZIGlzIG5vdCBzZXQKIyBDT05GSUdfTUFY TElORUFSX0dQSFkgaXMgbm90IHNldAojIENPTkZJR19NRURJQVRFS19HRV9QSFkgaXMgbm90IHNl dApDT05GSUdfTUlDUkVMX1BIWT15CkNPTkZJR19NSUNST0NISVBfUEhZPXkKIyBDT05GSUdfTUlD Uk9DSElQX1QxX1BIWSBpcyBub3Qgc2V0CiMgQ09ORklHX01JQ1JPU0VNSV9QSFkgaXMgbm90IHNl dAojIENPTkZJR19NT1RPUkNPTU1fUEhZIGlzIG5vdCBzZXQKIyBDT05GSUdfTkFUSU9OQUxfUEhZ IGlzIG5vdCBzZXQKIyBDT05GSUdfTlhQX0M0NV9USkExMVhYX1BIWSBpcyBub3Qgc2V0CiMgQ09O RklHX05YUF9USkExMVhYX1BIWSBpcyBub3Qgc2V0CiMgQ09ORklHX0FUODAzWF9QSFkgaXMgbm90 IHNldAojIENPTkZJR19RU0VNSV9QSFkgaXMgbm90IHNldAojIENPTkZJR19SRUFMVEVLX1BIWSBp cyBub3Qgc2V0CiMgQ09ORklHX1JFTkVTQVNfUEhZIGlzIG5vdCBzZXQKIyBDT05GSUdfUk9DS0NI SVBfUEhZIGlzIG5vdCBzZXQKQ09ORklHX1NNU0NfUEhZPXkKIyBDT05GSUdfU1RFMTBYUCBpcyBu b3Qgc2V0CiMgQ09ORklHX1RFUkFORVRJQ1NfUEhZIGlzIG5vdCBzZXQKIyBDT05GSUdfRFA4Mzgy Ml9QSFkgaXMgbm90IHNldAojIENPTkZJR19EUDgzVEM4MTFfUEhZIGlzIG5vdCBzZXQKIyBDT05G SUdfRFA4Mzg0OF9QSFkgaXMgbm90IHNldAojIENPTkZJR19EUDgzODY3X1BIWSBpcyBub3Qgc2V0 CiMgQ09ORklHX0RQODM4NjlfUEhZIGlzIG5vdCBzZXQKIyBDT05GSUdfVklURVNTRV9QSFkgaXMg bm90IHNldAojIENPTkZJR19YSUxJTlhfR01JSTJSR01JSSBpcyBub3Qgc2V0CiMgQ09ORklHX01J Q1JFTF9LUzg5OTVNQSBpcyBub3Qgc2V0CkNPTkZJR19NRElPX0RFVklDRT15CkNPTkZJR19NRElP X0JVUz15CkNPTkZJR19GV05PREVfTURJTz15CkNPTkZJR19PRl9NRElPPXkKQ09ORklHX01ESU9f REVWUkVTPXkKIyBDT05GSUdfTURJT19CSVRCQU5HIGlzIG5vdCBzZXQKQ09ORklHX01ESU9fQkNN X1VOSU1BQz15CiMgQ09ORklHX01ESU9fSElTSV9GRU1BQyBpcyBub3Qgc2V0CiMgQ09ORklHX01E SU9fTVZVU0IgaXMgbm90IHNldAojIENPTkZJR19NRElPX01TQ0NfTUlJTSBpcyBub3Qgc2V0CiMg Q09ORklHX01ESU9fT0NURU9OIGlzIG5vdCBzZXQKIyBDT05GSUdfTURJT19JUFE0MDE5IGlzIG5v dCBzZXQKIyBDT05GSUdfTURJT19JUFE4MDY0IGlzIG5vdCBzZXQKIyBDT05GSUdfTURJT19USFVO REVSIGlzIG5vdCBzZXQKCiMKIyBNRElPIE11bHRpcGxleGVycwojCiMgQ09ORklHX01ESU9fQlVT X01VWF9HUElPIGlzIG5vdCBzZXQKIyBDT05GSUdfTURJT19CVVNfTVVYX01VTFRJUExFWEVSIGlz IG5vdCBzZXQKIyBDT05GSUdfTURJT19CVVNfTVVYX01NSU9SRUcgaXMgbm90IHNldAoKIwojIFBD UyBkZXZpY2UgZHJpdmVycwojCiMgQ09ORklHX1BDU19YUENTIGlzIG5vdCBzZXQKIyBlbmQgb2Yg UENTIGRldmljZSBkcml2ZXJzCgpDT05GSUdfUFBQPW0KQ09ORklHX1BQUF9CU0RDT01QPW0KQ09O RklHX1BQUF9ERUZMQVRFPW0KQ09ORklHX1BQUF9GSUxURVI9eQojIENPTkZJR19QUFBfTVBQRSBp cyBub3Qgc2V0CkNPTkZJR19QUFBfTVVMVElMSU5LPXkKQ09ORklHX1BQUE9FPW0KIyBDT05GSUdf UFBUUCBpcyBub3Qgc2V0CkNPTkZJR19QUFBfQVNZTkM9bQpDT05GSUdfUFBQX1NZTkNfVFRZPW0K Q09ORklHX1NMSVA9bQpDT05GSUdfU0xIQz1tCkNPTkZJR19TTElQX0NPTVBSRVNTRUQ9eQpDT05G SUdfU0xJUF9TTUFSVD15CkNPTkZJR19TTElQX01PREVfU0xJUDY9eQpDT05GSUdfVVNCX05FVF9E UklWRVJTPXkKIyBDT05GSUdfVVNCX0NBVEMgaXMgbm90IHNldAojIENPTkZJR19VU0JfS0FXRVRI IGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX1BFR0FTVVMgaXMgbm90IHNldAojIENPTkZJR19VU0Jf UlRMODE1MCBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9SVEw4MTUyIGlzIG5vdCBzZXQKQ09ORklH X1VTQl9MQU43OFhYPXkKQ09ORklHX1VTQl9VU0JORVQ9eQpDT05GSUdfVVNCX05FVF9BWDg4MTdY PXkKQ09ORklHX1VTQl9ORVRfQVg4ODE3OV8xNzhBPXkKQ09ORklHX1VTQl9ORVRfQ0RDRVRIRVI9 eQojIENPTkZJR19VU0JfTkVUX0NEQ19FRU0gaXMgbm90IHNldApDT05GSUdfVVNCX05FVF9DRENf TkNNPXkKIyBDT05GSUdfVVNCX05FVF9IVUFXRUlfQ0RDX05DTSBpcyBub3Qgc2V0CiMgQ09ORklH X1VTQl9ORVRfQ0RDX01CSU0gaXMgbm90IHNldAojIENPTkZJR19VU0JfTkVUX0RNOTYwMSBpcyBu b3Qgc2V0CiMgQ09ORklHX1VTQl9ORVRfU1I5NzAwIGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX05F VF9TUjk4MDAgaXMgbm90IHNldAojIENPTkZJR19VU0JfTkVUX1NNU0M3NVhYIGlzIG5vdCBzZXQK Q09ORklHX1VTQl9ORVRfU01TQzk1WFg9eQojIENPTkZJR19VU0JfTkVUX0dMNjIwQSBpcyBub3Qg c2V0CkNPTkZJR19VU0JfTkVUX05FVDEwODA9eQojIENPTkZJR19VU0JfTkVUX1BMVVNCIGlzIG5v dCBzZXQKIyBDT05GSUdfVVNCX05FVF9NQ1M3ODMwIGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX05F VF9STkRJU19IT1NUIGlzIG5vdCBzZXQKQ09ORklHX1VTQl9ORVRfQ0RDX1NVQlNFVF9FTkFCTEU9 eQpDT05GSUdfVVNCX05FVF9DRENfU1VCU0VUPXkKQ09ORklHX1VTQl9BTElfTTU2MzI9eQpDT05G SUdfVVNCX0FOMjcyMD15CkNPTkZJR19VU0JfQkVMS0lOPXkKQ09ORklHX1VTQl9BUk1MSU5VWD15 CkNPTkZJR19VU0JfRVBTT04yODg4PXkKQ09ORklHX1VTQl9LQzIxOTA9eQpDT05GSUdfVVNCX05F VF9aQVVSVVM9eQojIENPTkZJR19VU0JfTkVUX0NYODIzMTBfRVRIIGlzIG5vdCBzZXQKIyBDT05G SUdfVVNCX05FVF9LQUxNSUEgaXMgbm90IHNldAojIENPTkZJR19VU0JfTkVUX1FNSV9XV0FOIGlz IG5vdCBzZXQKIyBDT05GSUdfVVNCX0hTTyBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9ORVRfSU5U NTFYMSBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9JUEhFVEggaXMgbm90IHNldAojIENPTkZJR19V U0JfU0lFUlJBX05FVCBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9WTDYwMCBpcyBub3Qgc2V0CiMg Q09ORklHX1VTQl9ORVRfQ0g5MjAwIGlzIG5vdCBzZXQKQ09ORklHX1VTQl9ORVRfQVFDMTExPXkK Q09ORklHX1VTQl9SVEw4MTUzX0VDTT15CkNPTkZJR19XTEFOPXkKQ09ORklHX1dMQU5fVkVORE9S X0FETVRFSz15CiMgQ09ORklHX0FETTgyMTEgaXMgbm90IHNldApDT05GSUdfV0xBTl9WRU5ET1Jf QVRIPXkKIyBDT05GSUdfQVRIX0RFQlVHIGlzIG5vdCBzZXQKIyBDT05GSUdfQVRINUsgaXMgbm90 IHNldAojIENPTkZJR19BVEg1S19QQ0kgaXMgbm90IHNldAojIENPTkZJR19BVEg5SyBpcyBub3Qg c2V0CiMgQ09ORklHX0FUSDlLX0hUQyBpcyBub3Qgc2V0CiMgQ09ORklHX0NBUkw5MTcwIGlzIG5v dCBzZXQKIyBDT05GSUdfQVRINktMIGlzIG5vdCBzZXQKIyBDT05GSUdfQVI1NTIzIGlzIG5vdCBz ZXQKIyBDT05GSUdfV0lMNjIxMCBpcyBub3Qgc2V0CiMgQ09ORklHX0FUSDEwSyBpcyBub3Qgc2V0 CiMgQ09ORklHX1dDTjM2WFggaXMgbm90IHNldAojIENPTkZJR19BVEgxMUsgaXMgbm90IHNldApD T05GSUdfV0xBTl9WRU5ET1JfQVRNRUw9eQojIENPTkZJR19BVE1FTCBpcyBub3Qgc2V0CiMgQ09O RklHX0FUNzZDNTBYX1VTQiBpcyBub3Qgc2V0CkNPTkZJR19XTEFOX1ZFTkRPUl9CUk9BRENPTT15 CkNPTkZJR19CNDM9bQpDT05GSUdfQjQzX0JDTUE9eQpDT05GSUdfQjQzX1NTQj15CkNPTkZJR19C NDNfQlVTRVNfQkNNQV9BTkRfU1NCPXkKIyBDT05GSUdfQjQzX0JVU0VTX0JDTUEgaXMgbm90IHNl dAojIENPTkZJR19CNDNfQlVTRVNfU1NCIGlzIG5vdCBzZXQKQ09ORklHX0I0M19QQ0lfQVVUT1NF TEVDVD15CkNPTkZJR19CNDNfUENJQ09SRV9BVVRPU0VMRUNUPXkKIyBDT05GSUdfQjQzX1NESU8g aXMgbm90IHNldApDT05GSUdfQjQzX0JDTUFfUElPPXkKQ09ORklHX0I0M19QSU89eQpDT05GSUdf QjQzX1BIWV9HPXkKQ09ORklHX0I0M19QSFlfTj15CkNPTkZJR19CNDNfUEhZX0xQPXkKQ09ORklH X0I0M19QSFlfSFQ9eQpDT05GSUdfQjQzX0hXUk5HPXkKIyBDT05GSUdfQjQzX0RFQlVHIGlzIG5v dCBzZXQKQ09ORklHX0I0M0xFR0FDWT1tCkNPTkZJR19CNDNMRUdBQ1lfUENJX0FVVE9TRUxFQ1Q9 eQpDT05GSUdfQjQzTEVHQUNZX1BDSUNPUkVfQVVUT1NFTEVDVD15CkNPTkZJR19CNDNMRUdBQ1lf SFdSTkc9eQpDT05GSUdfQjQzTEVHQUNZX0RFQlVHPXkKQ09ORklHX0I0M0xFR0FDWV9ETUE9eQpD T05GSUdfQjQzTEVHQUNZX1BJTz15CkNPTkZJR19CNDNMRUdBQ1lfRE1BX0FORF9QSU9fTU9ERT15 CiMgQ09ORklHX0I0M0xFR0FDWV9ETUFfTU9ERSBpcyBub3Qgc2V0CiMgQ09ORklHX0I0M0xFR0FD WV9QSU9fTU9ERSBpcyBub3Qgc2V0CkNPTkZJR19CUkNNVVRJTD1tCiMgQ09ORklHX0JSQ01TTUFD IGlzIG5vdCBzZXQKQ09ORklHX0JSQ01GTUFDPW0KQ09ORklHX0JSQ01GTUFDX1BST1RPX0JDREM9 eQpDT05GSUdfQlJDTUZNQUNfU0RJTz15CkNPTkZJR19CUkNNRk1BQ19VU0I9eQojIENPTkZJR19C UkNNRk1BQ19QQ0lFIGlzIG5vdCBzZXQKIyBDT05GSUdfQlJDTV9UUkFDSU5HIGlzIG5vdCBzZXQK IyBDT05GSUdfQlJDTURCRyBpcyBub3Qgc2V0CkNPTkZJR19XTEFOX1ZFTkRPUl9DSVNDTz15CkNP TkZJR19XTEFOX1ZFTkRPUl9JTlRFTD15CiMgQ09ORklHX0lQVzIxMDAgaXMgbm90IHNldAojIENP TkZJR19JUFcyMjAwIGlzIG5vdCBzZXQKIyBDT05GSUdfSVdMNDk2NSBpcyBub3Qgc2V0CiMgQ09O RklHX0lXTDM5NDUgaXMgbm90IHNldAojIENPTkZJR19JV0xXSUZJIGlzIG5vdCBzZXQKQ09ORklH X1dMQU5fVkVORE9SX0lOVEVSU0lMPXkKQ09ORklHX0hPU1RBUD15CiMgQ09ORklHX0hPU1RBUF9G SVJNV0FSRSBpcyBub3Qgc2V0CiMgQ09ORklHX0hPU1RBUF9QTFggaXMgbm90IHNldAojIENPTkZJ R19IT1NUQVBfUENJIGlzIG5vdCBzZXQKIyBDT05GSUdfSEVSTUVTIGlzIG5vdCBzZXQKIyBDT05G SUdfUDU0X0NPTU1PTiBpcyBub3Qgc2V0CkNPTkZJR19XTEFOX1ZFTkRPUl9NQVJWRUxMPXkKIyBD T05GSUdfTElCRVJUQVMgaXMgbm90IHNldAojIENPTkZJR19MSUJFUlRBU19USElORklSTSBpcyBu b3Qgc2V0CkNPTkZJR19NV0lGSUVYPW0KQ09ORklHX01XSUZJRVhfU0RJTz1tCiMgQ09ORklHX01X SUZJRVhfUENJRSBpcyBub3Qgc2V0CiMgQ09ORklHX01XSUZJRVhfVVNCIGlzIG5vdCBzZXQKIyBD T05GSUdfTVdMOEsgaXMgbm90IHNldApDT05GSUdfV0xBTl9WRU5ET1JfTUVESUFURUs9eQojIENP TkZJR19NVDc2MDFVIGlzIG5vdCBzZXQKIyBDT05GSUdfTVQ3NngwVSBpcyBub3Qgc2V0CiMgQ09O RklHX01UNzZ4MEUgaXMgbm90IHNldAojIENPTkZJR19NVDc2eDJFIGlzIG5vdCBzZXQKIyBDT05G SUdfTVQ3NngyVSBpcyBub3Qgc2V0CiMgQ09ORklHX01UNzYwM0UgaXMgbm90IHNldAojIENPTkZJ R19NVDc2MTVFIGlzIG5vdCBzZXQKIyBDT05GSUdfTVQ3NjYzVSBpcyBub3Qgc2V0CiMgQ09ORklH X01UNzY2M1MgaXMgbm90IHNldAojIENPTkZJR19NVDc5MTVFIGlzIG5vdCBzZXQKIyBDT05GSUdf TVQ3OTIxRSBpcyBub3Qgc2V0CkNPTkZJR19XTEFOX1ZFTkRPUl9NSUNST0NISVA9eQojIENPTkZJ R19XSUxDMTAwMF9TRElPIGlzIG5vdCBzZXQKIyBDT05GSUdfV0lMQzEwMDBfU1BJIGlzIG5vdCBz ZXQKQ09ORklHX1dMQU5fVkVORE9SX1JBTElOSz15CkNPTkZJR19SVDJYMDA9bQojIENPTkZJR19S VDI0MDBQQ0kgaXMgbm90IHNldAojIENPTkZJR19SVDI1MDBQQ0kgaXMgbm90IHNldAojIENPTkZJ R19SVDYxUENJIGlzIG5vdCBzZXQKIyBDT05GSUdfUlQyODAwUENJIGlzIG5vdCBzZXQKIyBDT05G SUdfUlQyNTAwVVNCIGlzIG5vdCBzZXQKQ09ORklHX1JUNzNVU0I9bQojIENPTkZJR19SVDI4MDBV U0IgaXMgbm90IHNldApDT05GSUdfUlQyWDAwX0xJQl9VU0I9bQpDT05GSUdfUlQyWDAwX0xJQj1t CkNPTkZJR19SVDJYMDBfTElCX0ZJUk1XQVJFPXkKQ09ORklHX1JUMlgwMF9MSUJfQ1JZUFRPPXkK Q09ORklHX1JUMlgwMF9MSUJfTEVEUz15CiMgQ09ORklHX1JUMlgwMF9ERUJVRyBpcyBub3Qgc2V0 CkNPTkZJR19XTEFOX1ZFTkRPUl9SRUFMVEVLPXkKIyBDT05GSUdfUlRMODE4MCBpcyBub3Qgc2V0 CiMgQ09ORklHX1JUTDgxODcgaXMgbm90IHNldApDT05GSUdfUlRMX0NBUkRTPW0KIyBDT05GSUdf UlRMODE5MkNFIGlzIG5vdCBzZXQKIyBDT05GSUdfUlRMODE5MlNFIGlzIG5vdCBzZXQKIyBDT05G SUdfUlRMODE5MkRFIGlzIG5vdCBzZXQKIyBDT05GSUdfUlRMODcyM0FFIGlzIG5vdCBzZXQKIyBD T05GSUdfUlRMODcyM0JFIGlzIG5vdCBzZXQKIyBDT05GSUdfUlRMODE4OEVFIGlzIG5vdCBzZXQK IyBDT05GSUdfUlRMODE5MkVFIGlzIG5vdCBzZXQKIyBDT05GSUdfUlRMODgyMUFFIGlzIG5vdCBz ZXQKIyBDT05GSUdfUlRMODE5MkNVIGlzIG5vdCBzZXQKIyBDT05GSUdfUlRMOFhYWFUgaXMgbm90 IHNldAojIENPTkZJR19SVFc4OCBpcyBub3Qgc2V0CkNPTkZJR19XTEFOX1ZFTkRPUl9SU0k9eQoj IENPTkZJR19SU0lfOTFYIGlzIG5vdCBzZXQKQ09ORklHX1dMQU5fVkVORE9SX1NUPXkKIyBDT05G SUdfQ1cxMjAwIGlzIG5vdCBzZXQKQ09ORklHX1dMQU5fVkVORE9SX1RJPXkKIyBDT05GSUdfV0wx MjUxIGlzIG5vdCBzZXQKIyBDT05GSUdfV0wxMlhYIGlzIG5vdCBzZXQKIyBDT05GSUdfV0wxOFhY IGlzIG5vdCBzZXQKIyBDT05GSUdfV0xDT1JFIGlzIG5vdCBzZXQKQ09ORklHX1dMQU5fVkVORE9S X1pZREFTPXkKIyBDT05GSUdfVVNCX1pEMTIwMSBpcyBub3Qgc2V0CiMgQ09ORklHX1pEMTIxMVJX IGlzIG5vdCBzZXQKQ09ORklHX1dMQU5fVkVORE9SX1FVQU5URU5OQT15CiMgQ09ORklHX1FUTkZN QUNfUENJRSBpcyBub3Qgc2V0CiMgQ09ORklHX01BQzgwMjExX0hXU0lNIGlzIG5vdCBzZXQKIyBD T05GSUdfVVNCX05FVF9STkRJU19XTEFOIGlzIG5vdCBzZXQKIyBDT05GSUdfVklSVF9XSUZJIGlz IG5vdCBzZXQKIyBDT05GSUdfV0FOIGlzIG5vdCBzZXQKCiMKIyBXaXJlbGVzcyBXQU4KIwojIENP TkZJR19XV0FOIGlzIG5vdCBzZXQKIyBlbmQgb2YgV2lyZWxlc3MgV0FOCgpDT05GSUdfWEVOX05F VERFVl9GUk9OVEVORD15CkNPTkZJR19YRU5fTkVUREVWX0JBQ0tFTkQ9bQojIENPTkZJR19WTVhO RVQzIGlzIG5vdCBzZXQKIyBDT05GSUdfTkVUREVWU0lNIGlzIG5vdCBzZXQKIyBDT05GSUdfTkVU X0ZBSUxPVkVSIGlzIG5vdCBzZXQKQ09ORklHX0lTRE49eQpDT05GSUdfSVNETl9DQVBJPXkKQ09O RklHX0NBUElfVFJBQ0U9eQpDT05GSUdfSVNETl9DQVBJX01JRERMRVdBUkU9eQojIENPTkZJR19N SVNETiBpcyBub3Qgc2V0CgojCiMgSW5wdXQgZGV2aWNlIHN1cHBvcnQKIwpDT05GSUdfSU5QVVQ9 eQpDT05GSUdfSU5QVVRfTEVEUz15CkNPTkZJR19JTlBVVF9GRl9NRU1MRVNTPW0KIyBDT05GSUdf SU5QVVRfU1BBUlNFS01BUCBpcyBub3Qgc2V0CiMgQ09ORklHX0lOUFVUX01BVFJJWEtNQVAgaXMg bm90IHNldAoKIwojIFVzZXJsYW5kIGludGVyZmFjZXMKIwojIENPTkZJR19JTlBVVF9NT1VTRURF ViBpcyBub3Qgc2V0CiMgQ09ORklHX0lOUFVUX0pPWURFViBpcyBub3Qgc2V0CkNPTkZJR19JTlBV VF9FVkRFVj15CiMgQ09ORklHX0lOUFVUX0VWQlVHIGlzIG5vdCBzZXQKCiMKIyBJbnB1dCBEZXZp Y2UgRHJpdmVycwojCkNPTkZJR19JTlBVVF9LRVlCT0FSRD15CiMgQ09ORklHX0tFWUJPQVJEX0FE QyBpcyBub3Qgc2V0CiMgQ09ORklHX0tFWUJPQVJEX0FEUDU1ODggaXMgbm90IHNldAojIENPTkZJ R19LRVlCT0FSRF9BRFA1NTg5IGlzIG5vdCBzZXQKQ09ORklHX0tFWUJPQVJEX0FUS0JEPXkKIyBD T05GSUdfS0VZQk9BUkRfUVQxMDUwIGlzIG5vdCBzZXQKIyBDT05GSUdfS0VZQk9BUkRfUVQxMDcw IGlzIG5vdCBzZXQKIyBDT05GSUdfS0VZQk9BUkRfUVQyMTYwIGlzIG5vdCBzZXQKIyBDT05GSUdf S0VZQk9BUkRfRExJTktfRElSNjg1IGlzIG5vdCBzZXQKIyBDT05GSUdfS0VZQk9BUkRfTEtLQkQg aXMgbm90IHNldAojIENPTkZJR19LRVlCT0FSRF9HUElPIGlzIG5vdCBzZXQKIyBDT05GSUdfS0VZ Qk9BUkRfR1BJT19QT0xMRUQgaXMgbm90IHNldAojIENPTkZJR19LRVlCT0FSRF9UQ0E2NDE2IGlz IG5vdCBzZXQKIyBDT05GSUdfS0VZQk9BUkRfVENBODQxOCBpcyBub3Qgc2V0CiMgQ09ORklHX0tF WUJPQVJEX01BVFJJWCBpcyBub3Qgc2V0CiMgQ09ORklHX0tFWUJPQVJEX0xNODMyMyBpcyBub3Qg c2V0CiMgQ09ORklHX0tFWUJPQVJEX0xNODMzMyBpcyBub3Qgc2V0CiMgQ09ORklHX0tFWUJPQVJE X01BWDczNTkgaXMgbm90IHNldAojIENPTkZJR19LRVlCT0FSRF9NQ1MgaXMgbm90IHNldAojIENP TkZJR19LRVlCT0FSRF9NUFIxMjEgaXMgbm90IHNldAojIENPTkZJR19LRVlCT0FSRF9ORVdUT04g aXMgbm90IHNldAojIENPTkZJR19LRVlCT0FSRF9PUEVOQ09SRVMgaXMgbm90IHNldAojIENPTkZJ R19LRVlCT0FSRF9TQU1TVU5HIGlzIG5vdCBzZXQKIyBDT05GSUdfS0VZQk9BUkRfU1RPV0FXQVkg aXMgbm90IHNldAojIENPTkZJR19LRVlCT0FSRF9TVU5LQkQgaXMgbm90IHNldAojIENPTkZJR19L RVlCT0FSRF9TVE1QRSBpcyBub3Qgc2V0CiMgQ09ORklHX0tFWUJPQVJEX09NQVA0IGlzIG5vdCBz ZXQKIyBDT05GSUdfS0VZQk9BUkRfVE0yX1RPVUNIS0VZIGlzIG5vdCBzZXQKIyBDT05GSUdfS0VZ Qk9BUkRfWFRLQkQgaXMgbm90IHNldApDT05GSUdfS0VZQk9BUkRfQ0FQMTFYWD1tCiMgQ09ORklH X0tFWUJPQVJEX0JDTSBpcyBub3Qgc2V0CkNPTkZJR19JTlBVVF9NT1VTRT15CkNPTkZJR19NT1VT RV9QUzI9eQpDT05GSUdfTU9VU0VfUFMyX0FMUFM9eQpDT05GSUdfTU9VU0VfUFMyX0JZRD15CkNP TkZJR19NT1VTRV9QUzJfTE9HSVBTMlBQPXkKQ09ORklHX01PVVNFX1BTMl9TWU5BUFRJQ1M9eQpD T05GSUdfTU9VU0VfUFMyX1NZTkFQVElDU19TTUJVUz15CkNPTkZJR19NT1VTRV9QUzJfQ1lQUkVT Uz15CkNPTkZJR19NT1VTRV9QUzJfVFJBQ0tQT0lOVD15CiMgQ09ORklHX01PVVNFX1BTMl9FTEFO VEVDSCBpcyBub3Qgc2V0CiMgQ09ORklHX01PVVNFX1BTMl9TRU5URUxJQyBpcyBub3Qgc2V0CiMg Q09ORklHX01PVVNFX1BTMl9UT1VDSEtJVCBpcyBub3Qgc2V0CkNPTkZJR19NT1VTRV9QUzJfRk9D QUxURUNIPXkKQ09ORklHX01PVVNFX1BTMl9TTUJVUz15CiMgQ09ORklHX01PVVNFX1NFUklBTCBp cyBub3Qgc2V0CiMgQ09ORklHX01PVVNFX0FQUExFVE9VQ0ggaXMgbm90IHNldAojIENPTkZJR19N T1VTRV9CQ001OTc0IGlzIG5vdCBzZXQKIyBDT05GSUdfTU9VU0VfQ1lBUEEgaXMgbm90IHNldAoj IENPTkZJR19NT1VTRV9FTEFOX0kyQyBpcyBub3Qgc2V0CiMgQ09ORklHX01PVVNFX1ZTWFhYQUEg aXMgbm90IHNldAojIENPTkZJR19NT1VTRV9HUElPIGlzIG5vdCBzZXQKIyBDT05GSUdfTU9VU0Vf U1lOQVBUSUNTX0kyQyBpcyBub3Qgc2V0CiMgQ09ORklHX01PVVNFX1NZTkFQVElDU19VU0IgaXMg bm90IHNldAojIENPTkZJR19JTlBVVF9KT1lTVElDSyBpcyBub3Qgc2V0CiMgQ09ORklHX0lOUFVU X1RBQkxFVCBpcyBub3Qgc2V0CkNPTkZJR19JTlBVVF9UT1VDSFNDUkVFTj15CiMgQ09ORklHX1RP VUNIU0NSRUVOX0FEUzc4NDYgaXMgbm90IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9BRDc4Nzcg aXMgbm90IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9BRDc4NzkgaXMgbm90IHNldAojIENPTkZJ R19UT1VDSFNDUkVFTl9BREMgaXMgbm90IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9BUjEwMjFf STJDIGlzIG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hTQ1JFRU5fQVRNRUxfTVhUIGlzIG5vdCBzZXQK IyBDT05GSUdfVE9VQ0hTQ1JFRU5fQVVPX1BJWENJUiBpcyBub3Qgc2V0CiMgQ09ORklHX1RPVUNI U0NSRUVOX0JVMjEwMTMgaXMgbm90IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9CVTIxMDI5IGlz IG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hTQ1JFRU5fQ0hJUE9ORV9JQ044MzE4IGlzIG5vdCBzZXQK IyBDT05GSUdfVE9VQ0hTQ1JFRU5fQ1k4Q1RNQTE0MCBpcyBub3Qgc2V0CiMgQ09ORklHX1RPVUNI U0NSRUVOX0NZOENUTUcxMTAgaXMgbm90IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9DWVRUU1Bf Q09SRSBpcyBub3Qgc2V0CiMgQ09ORklHX1RPVUNIU0NSRUVOX0NZVFRTUDRfQ09SRSBpcyBub3Qg c2V0CiMgQ09ORklHX1RPVUNIU0NSRUVOX0RZTkFQUk8gaXMgbm90IHNldAojIENPTkZJR19UT1VD SFNDUkVFTl9IQU1QU0hJUkUgaXMgbm90IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9FRVRJIGlz IG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hTQ1JFRU5fRUdBTEFYIGlzIG5vdCBzZXQKIyBDT05GSUdf VE9VQ0hTQ1JFRU5fRUdBTEFYX1NFUklBTCBpcyBub3Qgc2V0CiMgQ09ORklHX1RPVUNIU0NSRUVO X0VYQzMwMDAgaXMgbm90IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9GVUpJVFNVIGlzIG5vdCBz ZXQKIyBDT05GSUdfVE9VQ0hTQ1JFRU5fR09PRElYIGlzIG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hT Q1JFRU5fSElERUVQIGlzIG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hTQ1JFRU5fSFlDT05fSFk0NlhY IGlzIG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hTQ1JFRU5fSUxJMjEwWCBpcyBub3Qgc2V0CiMgQ09O RklHX1RPVUNIU0NSRUVOX0lMSVRFSyBpcyBub3Qgc2V0CiMgQ09ORklHX1RPVUNIU0NSRUVOX1M2 U1k3NjEgaXMgbm90IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9HVU5aRSBpcyBub3Qgc2V0CiMg Q09ORklHX1RPVUNIU0NSRUVOX0VLVEYyMTI3IGlzIG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hTQ1JF RU5fRUxBTiBpcyBub3Qgc2V0CiMgQ09ORklHX1RPVUNIU0NSRUVOX0VMTyBpcyBub3Qgc2V0CiMg Q09ORklHX1RPVUNIU0NSRUVOX1dBQ09NX1c4MDAxIGlzIG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hT Q1JFRU5fV0FDT01fSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hTQ1JFRU5fTUFYMTE4MDEg aXMgbm90IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9NQ1M1MDAwIGlzIG5vdCBzZXQKIyBDT05G SUdfVE9VQ0hTQ1JFRU5fTU1TMTE0IGlzIG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hTQ1JFRU5fTUVM RkFTX01JUDQgaXMgbm90IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9NU0cyNjM4IGlzIG5vdCBz ZXQKIyBDT05GSUdfVE9VQ0hTQ1JFRU5fTVRPVUNIIGlzIG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hT Q1JFRU5fSU1YNlVMX1RTQyBpcyBub3Qgc2V0CiMgQ09ORklHX1RPVUNIU0NSRUVOX0lORVhJTyBp cyBub3Qgc2V0CiMgQ09ORklHX1RPVUNIU0NSRUVOX01LNzEyIGlzIG5vdCBzZXQKIyBDT05GSUdf VE9VQ0hTQ1JFRU5fUEVOTU9VTlQgaXMgbm90IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9FRFRf RlQ1WDA2IGlzIG5vdCBzZXQKQ09ORklHX1RPVUNIU0NSRUVOX1JBU1BCRVJSWVBJX0ZXPW0KIyBD T05GSUdfVE9VQ0hTQ1JFRU5fVE9VQ0hSSUdIVCBpcyBub3Qgc2V0CiMgQ09ORklHX1RPVUNIU0NS RUVOX1RPVUNIV0lOIGlzIG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hTQ1JFRU5fUElYQ0lSIGlzIG5v dCBzZXQKIyBDT05GSUdfVE9VQ0hTQ1JFRU5fV0RUODdYWF9JMkMgaXMgbm90IHNldAojIENPTkZJ R19UT1VDSFNDUkVFTl9VU0JfQ09NUE9TSVRFIGlzIG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hTQ1JF RU5fVE9VQ0hJVDIxMyBpcyBub3Qgc2V0CiMgQ09ORklHX1RPVUNIU0NSRUVOX1RTQ19TRVJJTyBp cyBub3Qgc2V0CiMgQ09ORklHX1RPVUNIU0NSRUVOX1RTQzIwMDQgaXMgbm90IHNldAojIENPTkZJ R19UT1VDSFNDUkVFTl9UU0MyMDA1IGlzIG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hTQ1JFRU5fVFND MjAwNyBpcyBub3Qgc2V0CiMgQ09ORklHX1RPVUNIU0NSRUVOX1JNX1RTIGlzIG5vdCBzZXQKIyBD T05GSUdfVE9VQ0hTQ1JFRU5fU0lMRUFEIGlzIG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hTQ1JFRU5f U0lTX0kyQyBpcyBub3Qgc2V0CiMgQ09ORklHX1RPVUNIU0NSRUVOX1NUMTIzMiBpcyBub3Qgc2V0 CiMgQ09ORklHX1RPVUNIU0NSRUVOX1NUTUZUUyBpcyBub3Qgc2V0CiMgQ09ORklHX1RPVUNIU0NS RUVOX1NUTVBFIGlzIG5vdCBzZXQKIyBDT05GSUdfVE9VQ0hTQ1JFRU5fU1VSNDAgaXMgbm90IHNl dAojIENPTkZJR19UT1VDSFNDUkVFTl9TVVJGQUNFM19TUEkgaXMgbm90IHNldAojIENPTkZJR19U T1VDSFNDUkVFTl9TWDg2NTQgaXMgbm90IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9UUFM2NTA3 WCBpcyBub3Qgc2V0CiMgQ09ORklHX1RPVUNIU0NSRUVOX1pFVDYyMjMgaXMgbm90IHNldAojIENP TkZJR19UT1VDSFNDUkVFTl9aRk9SQ0UgaXMgbm90IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9S T0hNX0JVMjEwMjMgaXMgbm90IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9JUVM1WFggaXMgbm90 IHNldAojIENPTkZJR19UT1VDSFNDUkVFTl9aSU5JVElYIGlzIG5vdCBzZXQKQ09ORklHX0lOUFVU X01JU0M9eQojIENPTkZJR19JTlBVVF9BRDcxNFggaXMgbm90IHNldAojIENPTkZJR19JTlBVVF9B UklaT05BX0hBUFRJQ1MgaXMgbm90IHNldAojIENPTkZJR19JTlBVVF9BVE1FTF9DQVBUT1VDSCBp cyBub3Qgc2V0CiMgQ09ORklHX0lOUFVUX0JNQTE1MCBpcyBub3Qgc2V0CiMgQ09ORklHX0lOUFVU X0UzWDBfQlVUVE9OIGlzIG5vdCBzZXQKIyBDT05GSUdfSU5QVVRfTU1BODQ1MCBpcyBub3Qgc2V0 CiMgQ09ORklHX0lOUFVUX0dQSU9fQkVFUEVSIGlzIG5vdCBzZXQKIyBDT05GSUdfSU5QVVRfR1BJ T19ERUNPREVSIGlzIG5vdCBzZXQKIyBDT05GSUdfSU5QVVRfR1BJT19WSUJSQSBpcyBub3Qgc2V0 CiMgQ09ORklHX0lOUFVUX0FUSV9SRU1PVEUyIGlzIG5vdCBzZXQKIyBDT05GSUdfSU5QVVRfS0VZ U1BBTl9SRU1PVEUgaXMgbm90IHNldAojIENPTkZJR19JTlBVVF9LWFRKOSBpcyBub3Qgc2V0CiMg Q09ORklHX0lOUFVUX1BPV0VSTUFURSBpcyBub3Qgc2V0CiMgQ09ORklHX0lOUFVUX1lFQUxJTksg aXMgbm90IHNldAojIENPTkZJR19JTlBVVF9DTTEwOSBpcyBub3Qgc2V0CiMgQ09ORklHX0lOUFVU X1JFR1VMQVRPUl9IQVBUSUMgaXMgbm90IHNldAojIENPTkZJR19JTlBVVF9VSU5QVVQgaXMgbm90 IHNldAojIENPTkZJR19JTlBVVF9QQ0Y4NTc0IGlzIG5vdCBzZXQKIyBDT05GSUdfSU5QVVRfUFdN X0JFRVBFUiBpcyBub3Qgc2V0CiMgQ09ORklHX0lOUFVUX1BXTV9WSUJSQSBpcyBub3Qgc2V0CiMg Q09ORklHX0lOUFVUX0dQSU9fUk9UQVJZX0VOQ09ERVIgaXMgbm90IHNldAojIENPTkZJR19JTlBV VF9EQTcyODBfSEFQVElDUyBpcyBub3Qgc2V0CiMgQ09ORklHX0lOUFVUX0FEWEwzNFggaXMgbm90 IHNldAojIENPTkZJR19JTlBVVF9JTVNfUENVIGlzIG5vdCBzZXQKIyBDT05GSUdfSU5QVVRfSVFT MjY5QSBpcyBub3Qgc2V0CiMgQ09ORklHX0lOUFVUX0lRUzYyNkEgaXMgbm90IHNldAojIENPTkZJ R19JTlBVVF9DTUEzMDAwIGlzIG5vdCBzZXQKQ09ORklHX0lOUFVUX1hFTl9LQkRERVZfRlJPTlRF TkQ9eQojIENPTkZJR19JTlBVVF9EUlYyNjBYX0hBUFRJQ1MgaXMgbm90IHNldAojIENPTkZJR19J TlBVVF9EUlYyNjY1X0hBUFRJQ1MgaXMgbm90IHNldAojIENPTkZJR19JTlBVVF9EUlYyNjY3X0hB UFRJQ1MgaXMgbm90IHNldAojIENPTkZJR19STUk0X0NPUkUgaXMgbm90IHNldAoKIwojIEhhcmR3 YXJlIEkvTyBwb3J0cwojCkNPTkZJR19TRVJJTz15CkNPTkZJR19TRVJJT19TRVJQT1JUPXkKIyBD T05GSUdfU0VSSU9fQU1CQUtNSSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFUklPX1BDSVBTMiBpcyBu b3Qgc2V0CkNPTkZJR19TRVJJT19MSUJQUzI9eQojIENPTkZJR19TRVJJT19SQVcgaXMgbm90IHNl dAojIENPTkZJR19TRVJJT19BTFRFUkFfUFMyIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VSSU9fUFMy TVVMVCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFUklPX0FSQ19QUzIgaXMgbm90IHNldAojIENPTkZJ R19TRVJJT19BUEJQUzIgaXMgbm90IHNldAojIENPTkZJR19TRVJJT19HUElPX1BTMiBpcyBub3Qg c2V0CiMgQ09ORklHX1VTRVJJTyBpcyBub3Qgc2V0CiMgQ09ORklHX0dBTUVQT1JUIGlzIG5vdCBz ZXQKIyBlbmQgb2YgSGFyZHdhcmUgSS9PIHBvcnRzCiMgZW5kIG9mIElucHV0IGRldmljZSBzdXBw b3J0CgojCiMgQ2hhcmFjdGVyIGRldmljZXMKIwpDT05GSUdfVFRZPXkKQ09ORklHX1ZUPXkKQ09O RklHX0NPTlNPTEVfVFJBTlNMQVRJT05TPXkKQ09ORklHX1ZUX0NPTlNPTEU9eQpDT05GSUdfVlRf Q09OU09MRV9TTEVFUD15CkNPTkZJR19IV19DT05TT0xFPXkKQ09ORklHX1ZUX0hXX0NPTlNPTEVf QklORElORz15CkNPTkZJR19VTklYOThfUFRZUz15CiMgQ09ORklHX0xFR0FDWV9QVFlTIGlzIG5v dCBzZXQKQ09ORklHX0xESVNDX0FVVE9MT0FEPXkKCiMKIyBTZXJpYWwgZHJpdmVycwojCkNPTkZJ R19TRVJJQUxfRUFSTFlDT049eQpDT05GSUdfU0VSSUFMXzgyNTA9eQpDT05GSUdfU0VSSUFMXzgy NTBfREVQUkVDQVRFRF9PUFRJT05TPXkKQ09ORklHX1NFUklBTF84MjUwXzE2NTUwQV9WQVJJQU5U Uz15CiMgQ09ORklHX1NFUklBTF84MjUwX0ZJTlRFSyBpcyBub3Qgc2V0CkNPTkZJR19TRVJJQUxf ODI1MF9DT05TT0xFPXkKQ09ORklHX1NFUklBTF84MjUwX0RNQT15CkNPTkZJR19TRVJJQUxfODI1 MF9QQ0k9eQpDT05GSUdfU0VSSUFMXzgyNTBfRVhBUj15CkNPTkZJR19TRVJJQUxfODI1MF9OUl9V QVJUUz0xCkNPTkZJR19TRVJJQUxfODI1MF9SVU5USU1FX1VBUlRTPTEKQ09ORklHX1NFUklBTF84 MjUwX0VYVEVOREVEPXkKIyBDT05GSUdfU0VSSUFMXzgyNTBfTUFOWV9QT1JUUyBpcyBub3Qgc2V0 CiMgQ09ORklHX1NFUklBTF84MjUwX0FTUEVFRF9WVUFSVCBpcyBub3Qgc2V0CkNPTkZJR19TRVJJ QUxfODI1MF9TSEFSRV9JUlE9eQojIENPTkZJR19TRVJJQUxfODI1MF9ERVRFQ1RfSVJRIGlzIG5v dCBzZXQKIyBDT05GSUdfU0VSSUFMXzgyNTBfUlNBIGlzIG5vdCBzZXQKQ09ORklHX1NFUklBTF84 MjUwX0JDTTI4MzVBVVg9eQpDT05GSUdfU0VSSUFMXzgyNTBfRlNMPXkKIyBDT05GSUdfU0VSSUFM XzgyNTBfRFcgaXMgbm90IHNldAojIENPTkZJR19TRVJJQUxfODI1MF9SVDI4OFggaXMgbm90IHNl dApDT05GSUdfU0VSSUFMX09GX1BMQVRGT1JNPXkKCiMKIyBOb24tODI1MCBzZXJpYWwgcG9ydCBz dXBwb3J0CiMKIyBDT05GSUdfU0VSSUFMX0FNQkFfUEwwMTAgaXMgbm90IHNldApDT05GSUdfU0VS SUFMX0FNQkFfUEwwMTE9eQpDT05GSUdfU0VSSUFMX0FNQkFfUEwwMTFfQ09OU09MRT15CiMgQ09O RklHX1NFUklBTF9FQVJMWUNPTl9BUk1fU0VNSUhPU1QgaXMgbm90IHNldAojIENPTkZJR19TRVJJ QUxfS0dEQl9OTUkgaXMgbm90IHNldAojIENPTkZJR19TRVJJQUxfTUFYMzEwMCBpcyBub3Qgc2V0 CiMgQ09ORklHX1NFUklBTF9NQVgzMTBYIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VSSUFMX1VBUlRM SVRFIGlzIG5vdCBzZXQKQ09ORklHX1NFUklBTF9DT1JFPXkKQ09ORklHX1NFUklBTF9DT1JFX0NP TlNPTEU9eQpDT05GSUdfQ09OU09MRV9QT0xMPXkKIyBDT05GSUdfU0VSSUFMX0pTTSBpcyBub3Qg c2V0CiMgQ09ORklHX1NFUklBTF9TSUZJVkUgaXMgbm90IHNldAojIENPTkZJR19TRVJJQUxfU0ND TlhQIGlzIG5vdCBzZXQKQ09ORklHX1NFUklBTF9TQzE2SVM3WFhfQ09SRT1tCkNPTkZJR19TRVJJ QUxfU0MxNklTN1hYPW0KQ09ORklHX1NFUklBTF9TQzE2SVM3WFhfSTJDPXkKQ09ORklHX1NFUklB TF9TQzE2SVM3WFhfU1BJPXkKIyBDT05GSUdfU0VSSUFMX0JDTTYzWFggaXMgbm90IHNldAojIENP TkZJR19TRVJJQUxfQUxURVJBX0pUQUdVQVJUIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VSSUFMX0FM VEVSQV9VQVJUIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VSSUFMX1hJTElOWF9QU19VQVJUIGlzIG5v dCBzZXQKIyBDT05GSUdfU0VSSUFMX0FSQyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFUklBTF9SUDIg aXMgbm90IHNldAojIENPTkZJR19TRVJJQUxfRlNMX0xQVUFSVCBpcyBub3Qgc2V0CiMgQ09ORklH X1NFUklBTF9GU0xfTElORkxFWFVBUlQgaXMgbm90IHNldAojIENPTkZJR19TRVJJQUxfQ09ORVhB TlRfRElHSUNPTE9SIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VSSUFMX1NQUkQgaXMgbm90IHNldAoj IGVuZCBvZiBTZXJpYWwgZHJpdmVycwoKQ09ORklHX1NFUklBTF9NQ1RSTF9HUElPPXkKIyBDT05G SUdfU0VSSUFMX05PTlNUQU5EQVJEIGlzIG5vdCBzZXQKIyBDT05GSUdfTl9HU00gaXMgbm90IHNl dAojIENPTkZJR19OT1pPTUkgaXMgbm90IHNldAojIENPTkZJR19OVUxMX1RUWSBpcyBub3Qgc2V0 CkNPTkZJR19IVkNfRFJJVkVSPXkKQ09ORklHX0hWQ19JUlE9eQpDT05GSUdfSFZDX1hFTj15CkNP TkZJR19IVkNfWEVOX0ZST05URU5EPXkKIyBDT05GSUdfSFZDX0RDQyBpcyBub3Qgc2V0CkNPTkZJ R19TRVJJQUxfREVWX0JVUz15CkNPTkZJR19TRVJJQUxfREVWX0NUUkxfVFRZUE9SVD15CiMgQ09O RklHX1RUWV9QUklOVEsgaXMgbm90IHNldAojIENPTkZJR19WSVJUSU9fQ09OU09MRSBpcyBub3Qg c2V0CiMgQ09ORklHX0lQTUlfSEFORExFUiBpcyBub3Qgc2V0CkNPTkZJR19IV19SQU5ET009eQoj IENPTkZJR19IV19SQU5ET01fVElNRVJJT01FTSBpcyBub3Qgc2V0CiMgQ09ORklHX0hXX1JBTkRP TV9CQTQzMSBpcyBub3Qgc2V0CkNPTkZJR19IV19SQU5ET01fQkNNMjgzNT15CkNPTkZJR19IV19S QU5ET01fSVBST0NfUk5HMjAwPXkKIyBDT05GSUdfSFdfUkFORE9NX1ZJUlRJTyBpcyBub3Qgc2V0 CiMgQ09ORklHX0hXX1JBTkRPTV9DQ1RSTkcgaXMgbm90IHNldAojIENPTkZJR19IV19SQU5ET01f WElQSEVSQSBpcyBub3Qgc2V0CkNPTkZJR19IV19SQU5ET01fQVJNX1NNQ0NDX1RSTkc9eQojIENP TkZJR19BUFBMSUNPTSBpcyBub3Qgc2V0CkNPTkZJR19ERVZNRU09eQpDT05GSUdfREVWUE9SVD15 CiMgQ09ORklHX1RDR19UUE0gaXMgbm90IHNldAojIENPTkZJR19YSUxMWUJVUyBpcyBub3Qgc2V0 CiMgQ09ORklHX1hJTExZVVNCIGlzIG5vdCBzZXQKQ09ORklHX1JBTkRPTV9UUlVTVF9DUFU9eQpD T05GSUdfUkFORE9NX1RSVVNUX0JPT1RMT0FERVI9eQojIGVuZCBvZiBDaGFyYWN0ZXIgZGV2aWNl cwoKIwojIEkyQyBzdXBwb3J0CiMKQ09ORklHX0kyQz15CkNPTkZJR19JMkNfQk9BUkRJTkZPPXkK Q09ORklHX0kyQ19DT01QQVQ9eQpDT05GSUdfSTJDX0NIQVJERVY9bQpDT05GSUdfSTJDX01VWD15 CgojCiMgTXVsdGlwbGV4ZXIgSTJDIENoaXAgc3VwcG9ydAojCiMgQ09ORklHX0kyQ19BUkJfR1BJ T19DSEFMTEVOR0UgaXMgbm90IHNldAojIENPTkZJR19JMkNfTVVYX0dQSU8gaXMgbm90IHNldAoj IENPTkZJR19JMkNfTVVYX0dQTVVYIGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX01VWF9MVEM0MzA2 IGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX01VWF9QQ0E5NTQxIGlzIG5vdCBzZXQKIyBDT05GSUdf STJDX01VWF9QQ0E5NTR4IGlzIG5vdCBzZXQKQ09ORklHX0kyQ19NVVhfUElOQ1RSTD1tCiMgQ09O RklHX0kyQ19NVVhfUkVHIGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX0RFTVVYX1BJTkNUUkwgaXMg bm90IHNldAojIENPTkZJR19JMkNfTVVYX01MWENQTEQgaXMgbm90IHNldAojIGVuZCBvZiBNdWx0 aXBsZXhlciBJMkMgQ2hpcCBzdXBwb3J0CgpDT05GSUdfSTJDX0hFTFBFUl9BVVRPPXkKQ09ORklH X0kyQ19BTEdPQklUPXkKCiMKIyBJMkMgSGFyZHdhcmUgQnVzIHN1cHBvcnQKIwoKIwojIFBDIFNN QnVzIGhvc3QgY29udHJvbGxlciBkcml2ZXJzCiMKIyBDT05GSUdfSTJDX0FMSTE1MzUgaXMgbm90 IHNldAojIENPTkZJR19JMkNfQUxJMTU2MyBpcyBub3Qgc2V0CiMgQ09ORklHX0kyQ19BTEkxNVgz IGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX0FNRDc1NiBpcyBub3Qgc2V0CiMgQ09ORklHX0kyQ19B TUQ4MTExIGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX0k4MDEgaXMgbm90IHNldAojIENPTkZJR19J MkNfSVNDSCBpcyBub3Qgc2V0CiMgQ09ORklHX0kyQ19QSUlYNCBpcyBub3Qgc2V0CiMgQ09ORklH X0kyQ19ORk9SQ0UyIGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX05WSURJQV9HUFUgaXMgbm90IHNl dAojIENPTkZJR19JMkNfU0lTNTU5NSBpcyBub3Qgc2V0CiMgQ09ORklHX0kyQ19TSVM2MzAgaXMg bm90IHNldAojIENPTkZJR19JMkNfU0lTOTZYIGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX1ZJQSBp cyBub3Qgc2V0CiMgQ09ORklHX0kyQ19WSUFQUk8gaXMgbm90IHNldAoKIwojIEkyQyBzeXN0ZW0g YnVzIGRyaXZlcnMgKG1vc3RseSBlbWJlZGRlZCAvIHN5c3RlbS1vbi1jaGlwKQojCkNPTkZJR19J MkNfQkNNMjgzNT1tCkNPTkZJR19JMkNfQlJDTVNUQj15CiMgQ09ORklHX0kyQ19DQURFTkNFIGlz IG5vdCBzZXQKIyBDT05GSUdfSTJDX0NCVVNfR1BJTyBpcyBub3Qgc2V0CiMgQ09ORklHX0kyQ19E RVNJR05XQVJFX1BMQVRGT1JNIGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX0RFU0lHTldBUkVfUENJ IGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX0VNRVYyIGlzIG5vdCBzZXQKQ09ORklHX0kyQ19HUElP PW0KIyBDT05GSUdfSTJDX0dQSU9fRkFVTFRfSU5KRUNUT1IgaXMgbm90IHNldAojIENPTkZJR19J MkNfTk9NQURJSyBpcyBub3Qgc2V0CiMgQ09ORklHX0kyQ19PQ09SRVMgaXMgbm90IHNldAojIENP TkZJR19JMkNfUENBX1BMQVRGT1JNIGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX1JLM1ggaXMgbm90 IHNldAojIENPTkZJR19JMkNfU0lNVEVDIGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX1RIVU5ERVJY IGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX1hJTElOWCBpcyBub3Qgc2V0CgojCiMgRXh0ZXJuYWwg STJDL1NNQnVzIGFkYXB0ZXIgZHJpdmVycwojCiMgQ09ORklHX0kyQ19ESU9MQU5fVTJDIGlzIG5v dCBzZXQKIyBDT05GSUdfSTJDX0NQMjYxNSBpcyBub3Qgc2V0CiMgQ09ORklHX0kyQ19ST0JPVEZV WlpfT1NJRiBpcyBub3Qgc2V0CiMgQ09ORklHX0kyQ19UQU9TX0VWTSBpcyBub3Qgc2V0CiMgQ09O RklHX0kyQ19USU5ZX1VTQiBpcyBub3Qgc2V0CgojCiMgT3RoZXIgSTJDL1NNQnVzIGJ1cyBkcml2 ZXJzCiMKIyBDT05GSUdfSTJDX1ZJUlRJTyBpcyBub3Qgc2V0CiMgZW5kIG9mIEkyQyBIYXJkd2Fy ZSBCdXMgc3VwcG9ydAoKIyBDT05GSUdfSTJDX1NUVUIgaXMgbm90IHNldAojIENPTkZJR19JMkNf U0xBVkUgaXMgbm90IHNldAojIENPTkZJR19JMkNfREVCVUdfQ09SRSBpcyBub3Qgc2V0CiMgQ09O RklHX0kyQ19ERUJVR19BTEdPIGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX0RFQlVHX0JVUyBpcyBu b3Qgc2V0CiMgZW5kIG9mIEkyQyBzdXBwb3J0CgojIENPTkZJR19JM0MgaXMgbm90IHNldApDT05G SUdfU1BJPXkKIyBDT05GSUdfU1BJX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklHX1NQSV9NQVNURVI9 eQojIENPTkZJR19TUElfTUVNIGlzIG5vdCBzZXQKCiMKIyBTUEkgTWFzdGVyIENvbnRyb2xsZXIg RHJpdmVycwojCiMgQ09ORklHX1NQSV9BTFRFUkEgaXMgbm90IHNldAojIENPTkZJR19TUElfQVhJ X1NQSV9FTkdJTkUgaXMgbm90IHNldApDT05GSUdfU1BJX0JDTTI4MzU9bQpDT05GSUdfU1BJX0JD TTI4MzVBVVg9bQojIENPTkZJR19TUElfQklUQkFORyBpcyBub3Qgc2V0CiMgQ09ORklHX1NQSV9D QURFTkNFIGlzIG5vdCBzZXQKIyBDT05GSUdfU1BJX0NBREVOQ0VfUVVBRFNQSSBpcyBub3Qgc2V0 CiMgQ09ORklHX1NQSV9ERVNJR05XQVJFIGlzIG5vdCBzZXQKIyBDT05GSUdfU1BJX05YUF9GTEVY U1BJIGlzIG5vdCBzZXQKIyBDT05GSUdfU1BJX0dQSU8gaXMgbm90IHNldAojIENPTkZJR19TUElf RlNMX1NQSSBpcyBub3Qgc2V0CiMgQ09ORklHX1NQSV9PQ19USU5ZIGlzIG5vdCBzZXQKIyBDT05G SUdfU1BJX1BMMDIyIGlzIG5vdCBzZXQKIyBDT05GSUdfU1BJX1BYQTJYWCBpcyBub3Qgc2V0CiMg Q09ORklHX1NQSV9ST0NLQ0hJUCBpcyBub3Qgc2V0CiMgQ09ORklHX1NQSV9TQzE4SVM2MDIgaXMg bm90IHNldAojIENPTkZJR19TUElfU0lGSVZFIGlzIG5vdCBzZXQKIyBDT05GSUdfU1BJX01YSUMg aXMgbm90IHNldAojIENPTkZJR19TUElfVEhVTkRFUlggaXMgbm90IHNldAojIENPTkZJR19TUElf WENPTU0gaXMgbm90IHNldAojIENPTkZJR19TUElfWElMSU5YIGlzIG5vdCBzZXQKIyBDT05GSUdf U1BJX1pZTlFNUF9HUVNQSSBpcyBub3Qgc2V0CiMgQ09ORklHX1NQSV9BTUQgaXMgbm90IHNldAoK IwojIFNQSSBNdWx0aXBsZXhlciBzdXBwb3J0CiMKIyBDT05GSUdfU1BJX01VWCBpcyBub3Qgc2V0 CgojCiMgU1BJIFByb3RvY29sIE1hc3RlcnMKIwpDT05GSUdfU1BJX1NQSURFVj15CiMgQ09ORklH X1NQSV9MT09QQkFDS19URVNUIGlzIG5vdCBzZXQKIyBDT05GSUdfU1BJX1RMRTYyWDAgaXMgbm90 IHNldAojIENPTkZJR19TUElfU0xBVkUgaXMgbm90IHNldApDT05GSUdfU1BJX0RZTkFNSUM9eQoj IENPTkZJR19TUE1JIGlzIG5vdCBzZXQKIyBDT05GSUdfSFNJIGlzIG5vdCBzZXQKQ09ORklHX1BQ Uz15CiMgQ09ORklHX1BQU19ERUJVRyBpcyBub3Qgc2V0CiMgQ09ORklHX05UUF9QUFMgaXMgbm90 IHNldAoKIwojIFBQUyBjbGllbnRzIHN1cHBvcnQKIwojIENPTkZJR19QUFNfQ0xJRU5UX0tUSU1F UiBpcyBub3Qgc2V0CiMgQ09ORklHX1BQU19DTElFTlRfTERJU0MgaXMgbm90IHNldAojIENPTkZJ R19QUFNfQ0xJRU5UX0dQSU8gaXMgbm90IHNldAoKIwojIFBQUyBnZW5lcmF0b3JzIHN1cHBvcnQK IwoKIwojIFBUUCBjbG9jayBzdXBwb3J0CiMKQ09ORklHX1BUUF8xNTg4X0NMT0NLPXkKQ09ORklH X1BUUF8xNTg4X0NMT0NLX09QVElPTkFMPXkKCiMKIyBFbmFibGUgUEhZTElCIGFuZCBORVRXT1JL X1BIWV9USU1FU1RBTVBJTkcgdG8gc2VlIHRoZSBhZGRpdGlvbmFsIGNsb2Nrcy4KIwpDT05GSUdf UFRQXzE1ODhfQ0xPQ0tfS1ZNPXkKIyBDT05GSUdfUFRQXzE1ODhfQ0xPQ0tfSURUODJQMzMgaXMg bm90IHNldAojIENPTkZJR19QVFBfMTU4OF9DTE9DS19JRFRDTSBpcyBub3Qgc2V0CiMgQ09ORklH X1BUUF8xNTg4X0NMT0NLX09DUCBpcyBub3Qgc2V0CiMgZW5kIG9mIFBUUCBjbG9jayBzdXBwb3J0 CgpDT05GSUdfUElOQ1RSTD15CkNPTkZJR19QSU5NVVg9eQpDT05GSUdfUElOQ09ORj15CkNPTkZJ R19HRU5FUklDX1BJTkNPTkY9eQojIENPTkZJR19ERUJVR19QSU5DVFJMIGlzIG5vdCBzZXQKIyBD T05GSUdfUElOQ1RSTF9NQ1AyM1MwOCBpcyBub3Qgc2V0CiMgQ09ORklHX1BJTkNUUkxfU0lOR0xF IGlzIG5vdCBzZXQKIyBDT05GSUdfUElOQ1RSTF9TWDE1MFggaXMgbm90IHNldAojIENPTkZJR19Q SU5DVFJMX1NUTUZYIGlzIG5vdCBzZXQKIyBDT05GSUdfUElOQ1RSTF9PQ0VMT1QgaXMgbm90IHNl dAojIENPTkZJR19QSU5DVFJMX01JQ1JPQ0hJUF9TR1BJTyBpcyBub3Qgc2V0CkNPTkZJR19QSU5D VFJMX0JDTTI4MzU9eQoKIwojIFJlbmVzYXMgcGluY3RybCBkcml2ZXJzCiMKIyBlbmQgb2YgUmVu ZXNhcyBwaW5jdHJsIGRyaXZlcnMKCkNPTkZJR19HUElPTElCPXkKQ09ORklHX0dQSU9MSUJfRkFT VFBBVEhfTElNSVQ9NTEyCkNPTkZJR19PRl9HUElPPXkKQ09ORklHX0dQSU9MSUJfSVJRQ0hJUD15 CiMgQ09ORklHX0RFQlVHX0dQSU8gaXMgbm90IHNldAojIENPTkZJR19HUElPX1NZU0ZTIGlzIG5v dCBzZXQKQ09ORklHX0dQSU9fQ0RFVj15CkNPTkZJR19HUElPX0NERVZfVjE9eQoKIwojIE1lbW9y eSBtYXBwZWQgR1BJTyBkcml2ZXJzCiMKIyBDT05GSUdfR1BJT183NFhYX01NSU8gaXMgbm90IHNl dAojIENPTkZJR19HUElPX0FMVEVSQSBpcyBub3Qgc2V0CkNPTkZJR19HUElPX1JBU1BCRVJSWVBJ X0VYUD15CiMgQ09ORklHX0dQSU9fQ0FERU5DRSBpcyBub3Qgc2V0CiMgQ09ORklHX0dQSU9fRFdB UEIgaXMgbm90IHNldAojIENPTkZJR19HUElPX0VYQVIgaXMgbm90IHNldAojIENPTkZJR19HUElP X0ZUR1BJTzAxMCBpcyBub3Qgc2V0CiMgQ09ORklHX0dQSU9fR0VORVJJQ19QTEFURk9STSBpcyBu b3Qgc2V0CiMgQ09ORklHX0dQSU9fR1JHUElPIGlzIG5vdCBzZXQKIyBDT05GSUdfR1BJT19ITFdE IGlzIG5vdCBzZXQKIyBDT05GSUdfR1BJT19MT0dJQ1ZDIGlzIG5vdCBzZXQKIyBDT05GSUdfR1BJ T19NQjg2UzdYIGlzIG5vdCBzZXQKIyBDT05GSUdfR1BJT19QTDA2MSBpcyBub3Qgc2V0CiMgQ09O RklHX0dQSU9fU0FNQTVEMl9QSU9CVSBpcyBub3Qgc2V0CiMgQ09ORklHX0dQSU9fU0lGSVZFIGlz IG5vdCBzZXQKIyBDT05GSUdfR1BJT19TWVNDT04gaXMgbm90IHNldAojIENPTkZJR19HUElPX1hH RU5FIGlzIG5vdCBzZXQKIyBDT05GSUdfR1BJT19YSUxJTlggaXMgbm90IHNldAojIENPTkZJR19H UElPX0FNRF9GQ0ggaXMgbm90IHNldAojIGVuZCBvZiBNZW1vcnkgbWFwcGVkIEdQSU8gZHJpdmVy cwoKIwojIEkyQyBHUElPIGV4cGFuZGVycwojCiMgQ09ORklHX0dQSU9fQURQNTU4OCBpcyBub3Qg c2V0CiMgQ09ORklHX0dQSU9fQUROUCBpcyBub3Qgc2V0CiMgQ09ORklHX0dQSU9fR1dfUExEIGlz IG5vdCBzZXQKIyBDT05GSUdfR1BJT19NQVg3MzAwIGlzIG5vdCBzZXQKIyBDT05GSUdfR1BJT19N QVg3MzJYIGlzIG5vdCBzZXQKQ09ORklHX0dQSU9fUENBOTUzWD15CkNPTkZJR19HUElPX1BDQTk1 M1hfSVJRPXkKIyBDT05GSUdfR1BJT19QQ0E5NTcwIGlzIG5vdCBzZXQKIyBDT05GSUdfR1BJT19Q Q0Y4NTdYIGlzIG5vdCBzZXQKIyBDT05GSUdfR1BJT19UUElDMjgxMCBpcyBub3Qgc2V0CiMgZW5k IG9mIEkyQyBHUElPIGV4cGFuZGVycwoKIwojIE1GRCBHUElPIGV4cGFuZGVycwojCkNPTkZJR19H UElPX0FSSVpPTkE9bQpDT05GSUdfR1BJT19TVE1QRT15CiMgZW5kIG9mIE1GRCBHUElPIGV4cGFu ZGVycwoKIwojIFBDSSBHUElPIGV4cGFuZGVycwojCiMgQ09ORklHX0dQSU9fQlQ4WFggaXMgbm90 IHNldAojIENPTkZJR19HUElPX1BDSV9JRElPXzE2IGlzIG5vdCBzZXQKIyBDT05GSUdfR1BJT19Q Q0lFX0lESU9fMjQgaXMgbm90IHNldAojIENPTkZJR19HUElPX1JEQzMyMVggaXMgbm90IHNldAoj IGVuZCBvZiBQQ0kgR1BJTyBleHBhbmRlcnMKCiMKIyBTUEkgR1BJTyBleHBhbmRlcnMKIwojIENP TkZJR19HUElPXzc0WDE2NCBpcyBub3Qgc2V0CiMgQ09ORklHX0dQSU9fTUFYMzE5MVggaXMgbm90 IHNldAojIENPTkZJR19HUElPX01BWDczMDEgaXMgbm90IHNldAojIENPTkZJR19HUElPX01DMzM4 ODAgaXMgbm90IHNldAojIENPTkZJR19HUElPX1BJU09TUiBpcyBub3Qgc2V0CiMgQ09ORklHX0dQ SU9fWFJBMTQwMyBpcyBub3Qgc2V0CiMgZW5kIG9mIFNQSSBHUElPIGV4cGFuZGVycwoKIwojIFVT QiBHUElPIGV4cGFuZGVycwojCiMgZW5kIG9mIFVTQiBHUElPIGV4cGFuZGVycwoKIwojIFZpcnR1 YWwgR1BJTyBkcml2ZXJzCiMKIyBDT05GSUdfR1BJT19BR0dSRUdBVE9SIGlzIG5vdCBzZXQKQ09O RklHX0dQSU9fTU9DS1VQPW0KIyBDT05GSUdfR1BJT19WSVJUSU8gaXMgbm90IHNldAojIGVuZCBv ZiBWaXJ0dWFsIEdQSU8gZHJpdmVycwoKIyBDT05GSUdfVzEgaXMgbm90IHNldApDT05GSUdfUE9X RVJfUkVTRVQ9eQojIENPTkZJR19QT1dFUl9SRVNFVF9CUkNNU1RCIGlzIG5vdCBzZXQKIyBDT05G SUdfUE9XRVJfUkVTRVRfR1BJTyBpcyBub3Qgc2V0CiMgQ09ORklHX1BPV0VSX1JFU0VUX0dQSU9f UkVTVEFSVCBpcyBub3Qgc2V0CiMgQ09ORklHX1BPV0VSX1JFU0VUX0xUQzI5NTIgaXMgbm90IHNl dAojIENPTkZJR19QT1dFUl9SRVNFVF9SRUdVTEFUT1IgaXMgbm90IHNldAojIENPTkZJR19QT1dF Ul9SRVNFVF9SRVNUQVJUIGlzIG5vdCBzZXQKIyBDT05GSUdfUE9XRVJfUkVTRVRfWEdFTkUgaXMg bm90IHNldAojIENPTkZJR19QT1dFUl9SRVNFVF9TWVNDT04gaXMgbm90IHNldAojIENPTkZJR19Q T1dFUl9SRVNFVF9TWVNDT05fUE9XRVJPRkYgaXMgbm90IHNldAojIENPTkZJR19TWVNDT05fUkVC T09UX01PREUgaXMgbm90IHNldAojIENPTkZJR19OVk1FTV9SRUJPT1RfTU9ERSBpcyBub3Qgc2V0 CkNPTkZJR19QT1dFUl9TVVBQTFk9eQojIENPTkZJR19QT1dFUl9TVVBQTFlfREVCVUcgaXMgbm90 IHNldAojIENPTkZJR19QREFfUE9XRVIgaXMgbm90IHNldAojIENPTkZJR19HRU5FUklDX0FEQ19C QVRURVJZIGlzIG5vdCBzZXQKIyBDT05GSUdfVEVTVF9QT1dFUiBpcyBub3Qgc2V0CiMgQ09ORklH X0NIQVJHRVJfQURQNTA2MSBpcyBub3Qgc2V0CiMgQ09ORklHX0JBVFRFUllfQ1cyMDE1IGlzIG5v dCBzZXQKIyBDT05GSUdfQkFUVEVSWV9EUzI3ODAgaXMgbm90IHNldAojIENPTkZJR19CQVRURVJZ X0RTMjc4MSBpcyBub3Qgc2V0CiMgQ09ORklHX0JBVFRFUllfRFMyNzgyIGlzIG5vdCBzZXQKIyBD T05GSUdfQkFUVEVSWV9TQlMgaXMgbm90IHNldAojIENPTkZJR19DSEFSR0VSX1NCUyBpcyBub3Qg c2V0CiMgQ09ORklHX01BTkFHRVJfU0JTIGlzIG5vdCBzZXQKIyBDT05GSUdfQkFUVEVSWV9CUTI3 WFhYIGlzIG5vdCBzZXQKIyBDT05GSUdfQkFUVEVSWV9NQVgxNzA0MCBpcyBub3Qgc2V0CiMgQ09O RklHX0JBVFRFUllfTUFYMTcwNDIgaXMgbm90IHNldAojIENPTkZJR19DSEFSR0VSX01BWDg5MDMg aXMgbm90IHNldAojIENPTkZJR19DSEFSR0VSX0xQODcyNyBpcyBub3Qgc2V0CiMgQ09ORklHX0NI QVJHRVJfR1BJTyBpcyBub3Qgc2V0CiMgQ09ORklHX0NIQVJHRVJfTUFOQUdFUiBpcyBub3Qgc2V0 CiMgQ09ORklHX0NIQVJHRVJfTFQzNjUxIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0hBUkdFUl9MVEM0 MTYyTCBpcyBub3Qgc2V0CiMgQ09ORklHX0NIQVJHRVJfREVURUNUT1JfTUFYMTQ2NTYgaXMgbm90 IHNldAojIENPTkZJR19DSEFSR0VSX0JRMjQxNVggaXMgbm90IHNldAojIENPTkZJR19DSEFSR0VS X0JRMjQyNTcgaXMgbm90IHNldAojIENPTkZJR19DSEFSR0VSX0JRMjQ3MzUgaXMgbm90IHNldAoj IENPTkZJR19DSEFSR0VSX0JRMjUxNVggaXMgbm90IHNldAojIENPTkZJR19DSEFSR0VSX0JRMjU4 OTAgaXMgbm90IHNldAojIENPTkZJR19DSEFSR0VSX0JRMjU5ODAgaXMgbm90IHNldAojIENPTkZJ R19DSEFSR0VSX0JRMjU2WFggaXMgbm90IHNldAojIENPTkZJR19DSEFSR0VSX1NNQjM0NyBpcyBu b3Qgc2V0CiMgQ09ORklHX0JBVFRFUllfR0FVR0VfTFRDMjk0MSBpcyBub3Qgc2V0CiMgQ09ORklH X0JBVFRFUllfR09MREZJU0ggaXMgbm90IHNldAojIENPTkZJR19CQVRURVJZX1JUNTAzMyBpcyBu b3Qgc2V0CiMgQ09ORklHX0NIQVJHRVJfUlQ5NDU1IGlzIG5vdCBzZXQKIyBDT05GSUdfQ0hBUkdF Ul9VQ1MxMDAyIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0hBUkdFUl9CRDk5OTU0IGlzIG5vdCBzZXQK Q09ORklHX0hXTU9OPW0KIyBDT05GSUdfSFdNT05fREVCVUdfQ0hJUCBpcyBub3Qgc2V0CgojCiMg TmF0aXZlIGRyaXZlcnMKIwojIENPTkZJR19TRU5TT1JTX0FENzMxNCBpcyBub3Qgc2V0CiMgQ09O RklHX1NFTlNPUlNfQUQ3NDE0IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19BRDc0MTggaXMg bm90IHNldAojIENPTkZJR19TRU5TT1JTX0FETTEwMjEgaXMgbm90IHNldAojIENPTkZJR19TRU5T T1JTX0FETTEwMjUgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0FETTEwMjYgaXMgbm90IHNl dAojIENPTkZJR19TRU5TT1JTX0FETTEwMjkgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0FE TTEwMzEgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0FETTExNzcgaXMgbm90IHNldAojIENP TkZJR19TRU5TT1JTX0FETTkyNDAgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0FEVDczMTAg aXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0FEVDc0MTAgaXMgbm90IHNldAojIENPTkZJR19T RU5TT1JTX0FEVDc0MTEgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0FEVDc0NjIgaXMgbm90 IHNldAojIENPTkZJR19TRU5TT1JTX0FEVDc0NzAgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JT X0FEVDc0NzUgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0FIVDEwIGlzIG5vdCBzZXQKIyBD T05GSUdfU0VOU09SU19BUVVBQ09NUFVURVJfRDVORVhUIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VO U09SU19BUzM3MCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfQVNDNzYyMSBpcyBub3Qgc2V0 CiMgQ09ORklHX1NFTlNPUlNfQVhJX0ZBTl9DT05UUk9MIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VO U09SU19BU1BFRUQgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0FUWFAxIGlzIG5vdCBzZXQK IyBDT05GSUdfU0VOU09SU19DT1JTQUlSX0NQUk8gaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JT X0NPUlNBSVJfUFNVIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19EUklWRVRFTVAgaXMgbm90 IHNldAojIENPTkZJR19TRU5TT1JTX0RTNjIwIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19E UzE2MjEgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0k1S19BTUIgaXMgbm90IHNldAojIENP TkZJR19TRU5TT1JTX0Y3MTgwNUYgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0Y3MTg4MkZH IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19GNzUzNzVTIGlzIG5vdCBzZXQKIyBDT05GSUdf U0VOU09SU19GVFNURVVUQVRFUyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfR0w1MThTTSBp cyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfR0w1MjBTTSBpcyBub3Qgc2V0CiMgQ09ORklHX1NF TlNPUlNfRzc2MEEgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0c3NjIgaXMgbm90IHNldAoj IENPTkZJR19TRU5TT1JTX0dQSU9fRkFOIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19ISUg2 MTMwIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19JSU9fSFdNT04gaXMgbm90IHNldAojIENP TkZJR19TRU5TT1JTX0lUODcgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0pDNDIgaXMgbm90 IHNldAojIENPTkZJR19TRU5TT1JTX1BPV1IxMjIwIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09S U19MSU5FQUdFIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19MVEMyOTQ1IGlzIG5vdCBzZXQK IyBDT05GSUdfU0VOU09SU19MVEMyOTQ3X0kyQyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNf TFRDMjk0N19TUEkgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0xUQzI5OTAgaXMgbm90IHNl dAojIENPTkZJR19TRU5TT1JTX0xUQzI5OTIgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0xU QzQxNTEgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0xUQzQyMTUgaXMgbm90IHNldAojIENP TkZJR19TRU5TT1JTX0xUQzQyMjIgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0xUQzQyNDUg aXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0xUQzQyNjAgaXMgbm90IHNldAojIENPTkZJR19T RU5TT1JTX0xUQzQyNjEgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX01BWDExMTEgaXMgbm90 IHNldAojIENPTkZJR19TRU5TT1JTX01BWDEyNyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNf TUFYMTYwNjUgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX01BWDE2MTkgaXMgbm90IHNldAoj IENPTkZJR19TRU5TT1JTX01BWDE2NjggaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX01BWDE5 NyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTUFYMzE3MjIgaXMgbm90IHNldAojIENPTkZJ R19TRU5TT1JTX01BWDMxNzMwIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19NQVg2NjIxIGlz IG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19NQVg2NjM5IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VO U09SU19NQVg2NjQyIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19NQVg2NjUwIGlzIG5vdCBz ZXQKIyBDT05GSUdfU0VOU09SU19NQVg2Njk3IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19N QVgzMTc5MCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTUNQMzAyMSBpcyBub3Qgc2V0CiMg Q09ORklHX1NFTlNPUlNfVEM2NTQgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX1RQUzIzODYx IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19NUjc1MjAzIGlzIG5vdCBzZXQKIyBDT05GSUdf U0VOU09SU19BRENYWCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTE02MyBpcyBub3Qgc2V0 CiMgQ09ORklHX1NFTlNPUlNfTE03MCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTE03MyBp cyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTE03NSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNP UlNfTE03NyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTE03OCBpcyBub3Qgc2V0CiMgQ09O RklHX1NFTlNPUlNfTE04MCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTE04MyBpcyBub3Qg c2V0CiMgQ09ORklHX1NFTlNPUlNfTE04NSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTE04 NyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTE05MCBpcyBub3Qgc2V0CiMgQ09ORklHX1NF TlNPUlNfTE05MiBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTE05MyBpcyBub3Qgc2V0CiMg Q09ORklHX1NFTlNPUlNfTE05NTIzNCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTE05NTI0 MSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTE05NTI0NSBpcyBub3Qgc2V0CiMgQ09ORklH X1NFTlNPUlNfUEM4NzM2MCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfUEM4NzQyNyBpcyBu b3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTlRDX1RIRVJNSVNUT1IgaXMgbm90IHNldAojIENPTkZJ R19TRU5TT1JTX05DVDY2ODMgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX05DVDY3NzUgaXMg bm90IHNldAojIENPTkZJR19TRU5TT1JTX05DVDc4MDIgaXMgbm90IHNldAojIENPTkZJR19TRU5T T1JTX05DVDc5MDQgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX05QQ003WFggaXMgbm90IHNl dAojIENPTkZJR19TRU5TT1JTX05aWFRfS1JBS0VOMiBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNP UlNfT0NDX1A4X0kyQyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfUENGODU5MSBpcyBub3Qg c2V0CiMgQ09ORklHX1BNQlVTIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19QV01fRkFOIGlz IG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19SQVNQQkVSUllQSV9IV01PTiBpcyBub3Qgc2V0CiMg Q09ORklHX1NFTlNPUlNfU0JUU0kgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX1NCUk1JIGlz IG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19TSFQxNSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNP UlNfU0hUMjEgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX1NIVDN4IGlzIG5vdCBzZXQKIyBD T05GSUdfU0VOU09SU19TSFQ0eCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfU0hUQzEgaXMg bm90IHNldAojIENPTkZJR19TRU5TT1JTX1NJUzU1OTUgaXMgbm90IHNldAojIENPTkZJR19TRU5T T1JTX0RNRTE3MzcgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0VNQzE0MDMgaXMgbm90IHNl dAojIENPTkZJR19TRU5TT1JTX0VNQzIxMDMgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0VN QzZXMjAxIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19TTVNDNDdNMSBpcyBub3Qgc2V0CiMg Q09ORklHX1NFTlNPUlNfU01TQzQ3TTE5MiBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfU01T QzQ3QjM5NyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfU0NINTYyNyBpcyBub3Qgc2V0CiMg Q09ORklHX1NFTlNPUlNfU0NINTYzNiBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfU1RUUzc1 MSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfU01NNjY1IGlzIG5vdCBzZXQKIyBDT05GSUdf U0VOU09SU19BREMxMjhEODE4IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19BRFM3ODI4IGlz IG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19BRFM3ODcxIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VO U09SU19BTUM2ODIxIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19JTkEyMDkgaXMgbm90IHNl dAojIENPTkZJR19TRU5TT1JTX0lOQTJYWCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfSU5B MzIyMSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfVEM3NCBpcyBub3Qgc2V0CiMgQ09ORklH X1NFTlNPUlNfVEhNQzUwIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19UTVAxMDIgaXMgbm90 IHNldAojIENPTkZJR19TRU5TT1JTX1RNUDEwMyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNf VE1QMTA4IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19UTVA0MDEgaXMgbm90IHNldAojIENP TkZJR19TRU5TT1JTX1RNUDQyMSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfVE1QNTEzIGlz IG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19WSUE2ODZBIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VO U09SU19WVDEyMTEgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX1ZUODIzMSBpcyBub3Qgc2V0 CiMgQ09ORklHX1NFTlNPUlNfVzgzNzczRyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfVzgz NzgxRCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfVzgzNzkxRCBpcyBub3Qgc2V0CiMgQ09O RklHX1NFTlNPUlNfVzgzNzkyRCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfVzgzNzkzIGlz IG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19XODM3OTUgaXMgbm90IHNldAojIENPTkZJR19TRU5T T1JTX1c4M0w3ODVUUyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfVzgzTDc4Nk5HIGlzIG5v dCBzZXQKIyBDT05GSUdfU0VOU09SU19XODM2MjdIRiBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNP UlNfVzgzNjI3RUhGIGlzIG5vdCBzZXQKQ09ORklHX1RIRVJNQUw9eQojIENPTkZJR19USEVSTUFM X05FVExJTksgaXMgbm90IHNldAojIENPTkZJR19USEVSTUFMX1NUQVRJU1RJQ1MgaXMgbm90IHNl dApDT05GSUdfVEhFUk1BTF9FTUVSR0VOQ1lfUE9XRVJPRkZfREVMQVlfTVM9MApDT05GSUdfVEhF Uk1BTF9PRj15CiMgQ09ORklHX1RIRVJNQUxfV1JJVEFCTEVfVFJJUFMgaXMgbm90IHNldApDT05G SUdfVEhFUk1BTF9ERUZBVUxUX0dPVl9TVEVQX1dJU0U9eQojIENPTkZJR19USEVSTUFMX0RFRkFV TFRfR09WX0ZBSVJfU0hBUkUgaXMgbm90IHNldAojIENPTkZJR19USEVSTUFMX0RFRkFVTFRfR09W X1VTRVJfU1BBQ0UgaXMgbm90IHNldAojIENPTkZJR19USEVSTUFMX0dPVl9GQUlSX1NIQVJFIGlz IG5vdCBzZXQKQ09ORklHX1RIRVJNQUxfR09WX1NURVBfV0lTRT15CiMgQ09ORklHX1RIRVJNQUxf R09WX0JBTkdfQkFORyBpcyBub3Qgc2V0CiMgQ09ORklHX1RIRVJNQUxfR09WX1VTRVJfU1BBQ0Ug aXMgbm90IHNldAojIENPTkZJR19DUFVfVEhFUk1BTCBpcyBub3Qgc2V0CiMgQ09ORklHX1RIRVJN QUxfRU1VTEFUSU9OIGlzIG5vdCBzZXQKIyBDT05GSUdfVEhFUk1BTF9NTUlPIGlzIG5vdCBzZXQK CiMKIyBCcm9hZGNvbSB0aGVybWFsIGRyaXZlcnMKIwpDT05GSUdfQkNNMjcxMV9USEVSTUFMPXkK Q09ORklHX0JDTTI4MzVfVEhFUk1BTD15CiMgZW5kIG9mIEJyb2FkY29tIHRoZXJtYWwgZHJpdmVy cwoKIyBDT05GSUdfR0VORVJJQ19BRENfVEhFUk1BTCBpcyBub3Qgc2V0CkNPTkZJR19XQVRDSERP Rz15CkNPTkZJR19XQVRDSERPR19DT1JFPXkKIyBDT05GSUdfV0FUQ0hET0dfTk9XQVlPVVQgaXMg bm90IHNldApDT05GSUdfV0FUQ0hET0dfSEFORExFX0JPT1RfRU5BQkxFRD15CkNPTkZJR19XQVRD SERPR19PUEVOX1RJTUVPVVQ9MAojIENPTkZJR19XQVRDSERPR19TWVNGUyBpcyBub3Qgc2V0CiMg Q09ORklHX1dBVENIRE9HX0hSVElNRVJfUFJFVElNRU9VVCBpcyBub3Qgc2V0CgojCiMgV2F0Y2hk b2cgUHJldGltZW91dCBHb3Zlcm5vcnMKIwojIENPTkZJR19XQVRDSERPR19QUkVUSU1FT1VUX0dP ViBpcyBub3Qgc2V0CgojCiMgV2F0Y2hkb2cgRGV2aWNlIERyaXZlcnMKIwpDT05GSUdfU09GVF9X QVRDSERPRz1tCiMgQ09ORklHX0dQSU9fV0FUQ0hET0cgaXMgbm90IHNldAojIENPTkZJR19YSUxJ TlhfV0FUQ0hET0cgaXMgbm90IHNldAojIENPTkZJR19aSUlSQVZFX1dBVENIRE9HIGlzIG5vdCBz ZXQKIyBDT05GSUdfQVJNX1NQODA1X1dBVENIRE9HIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJNX1NC U0FfV0FUQ0hET0cgaXMgbm90IHNldAojIENPTkZJR19DQURFTkNFX1dBVENIRE9HIGlzIG5vdCBz ZXQKIyBDT05GSUdfRFdfV0FUQ0hET0cgaXMgbm90IHNldAojIENPTkZJR19NQVg2M1hYX1dBVENI RE9HIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJNX1NNQ19XQVRDSERPRyBpcyBub3Qgc2V0CiMgQ09O RklHX0FMSU03MTAxX1dEVCBpcyBub3Qgc2V0CiMgQ09ORklHX0k2MzAwRVNCX1dEVCBpcyBub3Qg c2V0CkNPTkZJR19CQ00yODM1X1dEVD15CiMgQ09ORklHX01FTl9BMjFfV0RUIGlzIG5vdCBzZXQK Q09ORklHX1hFTl9XRFQ9bQoKIwojIFBDSS1iYXNlZCBXYXRjaGRvZyBDYXJkcwojCiMgQ09ORklH X1BDSVBDV0FUQ0hET0cgaXMgbm90IHNldAojIENPTkZJR19XRFRQQ0kgaXMgbm90IHNldAoKIwoj IFVTQi1iYXNlZCBXYXRjaGRvZyBDYXJkcwojCiMgQ09ORklHX1VTQlBDV0FUQ0hET0cgaXMgbm90 IHNldApDT05GSUdfU1NCX1BPU1NJQkxFPXkKQ09ORklHX1NTQj1tCkNPTkZJR19TU0JfU1BST009 eQpDT05GSUdfU1NCX0JMT0NLSU89eQpDT05GSUdfU1NCX1BDSUhPU1RfUE9TU0lCTEU9eQpDT05G SUdfU1NCX1BDSUhPU1Q9eQpDT05GSUdfU1NCX0I0M19QQ0lfQlJJREdFPXkKQ09ORklHX1NTQl9T RElPSE9TVF9QT1NTSUJMRT15CiMgQ09ORklHX1NTQl9TRElPSE9TVCBpcyBub3Qgc2V0CkNPTkZJ R19TU0JfRFJJVkVSX1BDSUNPUkVfUE9TU0lCTEU9eQpDT05GSUdfU1NCX0RSSVZFUl9QQ0lDT1JF PXkKIyBDT05GSUdfU1NCX0RSSVZFUl9HUElPIGlzIG5vdCBzZXQKQ09ORklHX0JDTUFfUE9TU0lC TEU9eQpDT05GSUdfQkNNQT1tCkNPTkZJR19CQ01BX0JMT0NLSU89eQpDT05GSUdfQkNNQV9IT1NU X1BDSV9QT1NTSUJMRT15CkNPTkZJR19CQ01BX0hPU1RfUENJPXkKIyBDT05GSUdfQkNNQV9IT1NU X1NPQyBpcyBub3Qgc2V0CkNPTkZJR19CQ01BX0RSSVZFUl9QQ0k9eQojIENPTkZJR19CQ01BX0RS SVZFUl9HTUFDX0NNTiBpcyBub3Qgc2V0CiMgQ09ORklHX0JDTUFfRFJJVkVSX0dQSU8gaXMgbm90 IHNldAojIENPTkZJR19CQ01BX0RFQlVHIGlzIG5vdCBzZXQKCiMKIyBNdWx0aWZ1bmN0aW9uIGRl dmljZSBkcml2ZXJzCiMKQ09ORklHX01GRF9DT1JFPXkKIyBDT05GSUdfTUZEX0FDVDg5NDVBIGlz IG5vdCBzZXQKIyBDT05GSUdfTUZEX0FTMzcxMSBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9BUzM3 MjIgaXMgbm90IHNldAojIENPTkZJR19QTUlDX0FEUDU1MjAgaXMgbm90IHNldAojIENPTkZJR19N RkRfQUFUMjg3MF9DT1JFIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX0FUTUVMX0ZMRVhDT00gaXMg bm90IHNldAojIENPTkZJR19NRkRfQVRNRUxfSExDREMgaXMgbm90IHNldAojIENPTkZJR19NRkRf QkNNNTkwWFggaXMgbm90IHNldAojIENPTkZJR19NRkRfQkQ5NTcxTVdWIGlzIG5vdCBzZXQKIyBD T05GSUdfTUZEX0FYUDIwWF9JMkMgaXMgbm90IHNldAojIENPTkZJR19NRkRfTUFERVJBIGlzIG5v dCBzZXQKIyBDT05GSUdfUE1JQ19EQTkwM1ggaXMgbm90IHNldAojIENPTkZJR19NRkRfREE5MDUy X1NQSSBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9EQTkwNTJfSTJDIGlzIG5vdCBzZXQKIyBDT05G SUdfTUZEX0RBOTA1NSBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9EQTkwNjIgaXMgbm90IHNldAoj IENPTkZJR19NRkRfREE5MDYzIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX0RBOTE1MCBpcyBub3Qg c2V0CiMgQ09ORklHX01GRF9ETE4yIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX0dBVEVXT1JLU19H U0MgaXMgbm90IHNldAojIENPTkZJR19NRkRfTUMxM1hYWF9TUEkgaXMgbm90IHNldAojIENPTkZJ R19NRkRfTUMxM1hYWF9JMkMgaXMgbm90IHNldAojIENPTkZJR19NRkRfTVAyNjI5IGlzIG5vdCBz ZXQKIyBDT05GSUdfTUZEX0hJNjQyMV9QTUlDIGlzIG5vdCBzZXQKIyBDT05GSUdfSFRDX1BBU0lD MyBpcyBub3Qgc2V0CiMgQ09ORklHX0hUQ19JMkNQTEQgaXMgbm90IHNldAojIENPTkZJR19MUENf SUNIIGlzIG5vdCBzZXQKIyBDT05GSUdfTFBDX1NDSCBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9J TlRFTF9QTVQgaXMgbm90IHNldAojIENPTkZJR19NRkRfSVFTNjJYIGlzIG5vdCBzZXQKIyBDT05G SUdfTUZEX0pBTlpfQ01PRElPIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX0tFTVBMRCBpcyBub3Qg c2V0CiMgQ09ORklHX01GRF84OFBNODAwIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEXzg4UE04MDUg aXMgbm90IHNldAojIENPTkZJR19NRkRfODhQTTg2MFggaXMgbm90IHNldAojIENPTkZJR19NRkRf TUFYMTQ1NzcgaXMgbm90IHNldAojIENPTkZJR19NRkRfTUFYNzc2MjAgaXMgbm90IHNldAojIENP TkZJR19NRkRfTUFYNzc2NTAgaXMgbm90IHNldAojIENPTkZJR19NRkRfTUFYNzc2ODYgaXMgbm90 IHNldAojIENPTkZJR19NRkRfTUFYNzc2OTMgaXMgbm90IHNldAojIENPTkZJR19NRkRfTUFYNzc4 NDMgaXMgbm90IHNldAojIENPTkZJR19NRkRfTUFYODkwNyBpcyBub3Qgc2V0CiMgQ09ORklHX01G RF9NQVg4OTI1IGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX01BWDg5OTcgaXMgbm90IHNldAojIENP TkZJR19NRkRfTUFYODk5OCBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9NVDYzNjAgaXMgbm90IHNl dAojIENPTkZJR19NRkRfTVQ2Mzk3IGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX01FTkYyMUJNQyBp cyBub3Qgc2V0CiMgQ09ORklHX0VaWF9QQ0FQIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX0NQQ0FQ IGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1ZJUEVSQk9BUkQgaXMgbm90IHNldAojIENPTkZJR19N RkRfTlRYRUMgaXMgbm90IHNldAojIENPTkZJR19NRkRfUkVUVSBpcyBub3Qgc2V0CiMgQ09ORklH X01GRF9QQ0Y1MDYzMyBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9SREMzMjFYIGlzIG5vdCBzZXQK IyBDT05GSUdfTUZEX1JUNDgzMSBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9SVDUwMzMgaXMgbm90 IHNldAojIENPTkZJR19NRkRfUkM1VDU4MyBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9SSzgwOCBp cyBub3Qgc2V0CiMgQ09ORklHX01GRF9STjVUNjE4IGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1NF Q19DT1JFIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1NJNDc2WF9DT1JFIGlzIG5vdCBzZXQKIyBD T05GSUdfTUZEX1NNNTAxIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1NLWTgxNDUyIGlzIG5vdCBz ZXQKQ09ORklHX01GRF9TVE1QRT15CgojCiMgU1RNaWNyb2VsZWN0cm9uaWNzIFNUTVBFIEludGVy ZmFjZSBEcml2ZXJzCiMKQ09ORklHX1NUTVBFX0kyQz15CiMgQ09ORklHX1NUTVBFX1NQSSBpcyBu b3Qgc2V0CiMgZW5kIG9mIFNUTWljcm9lbGVjdHJvbmljcyBTVE1QRSBJbnRlcmZhY2UgRHJpdmVy cwoKQ09ORklHX01GRF9TWVNDT049eQojIENPTkZJR19NRkRfVElfQU0zMzVYX1RTQ0FEQyBpcyBu b3Qgc2V0CiMgQ09ORklHX01GRF9MUDM5NDMgaXMgbm90IHNldAojIENPTkZJR19NRkRfTFA4Nzg4 IGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1RJX0xNVSBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9Q QUxNQVMgaXMgbm90IHNldAojIENPTkZJR19UUFM2MTA1WCBpcyBub3Qgc2V0CiMgQ09ORklHX1RQ UzY1MDEwIGlzIG5vdCBzZXQKIyBDT05GSUdfVFBTNjUwN1ggaXMgbm90IHNldAojIENPTkZJR19N RkRfVFBTNjUwODYgaXMgbm90IHNldAojIENPTkZJR19NRkRfVFBTNjUwOTAgaXMgbm90IHNldAoj IENPTkZJR19NRkRfVFBTNjUyMTcgaXMgbm90IHNldAojIENPTkZJR19NRkRfVElfTFA4NzNYIGlz IG5vdCBzZXQKIyBDT05GSUdfTUZEX1RJX0xQODc1NjUgaXMgbm90IHNldAojIENPTkZJR19NRkRf VFBTNjUyMTggaXMgbm90IHNldAojIENPTkZJR19NRkRfVFBTNjU4NlggaXMgbm90IHNldAojIENP TkZJR19NRkRfVFBTNjU5MTAgaXMgbm90IHNldAojIENPTkZJR19NRkRfVFBTNjU5MTJfSTJDIGlz IG5vdCBzZXQKIyBDT05GSUdfTUZEX1RQUzY1OTEyX1NQSSBpcyBub3Qgc2V0CiMgQ09ORklHX01G RF9UUFM4MDAzMSBpcyBub3Qgc2V0CiMgQ09ORklHX1RXTDQwMzBfQ09SRSBpcyBub3Qgc2V0CiMg Q09ORklHX1RXTDYwNDBfQ09SRSBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9XTDEyNzNfQ09SRSBp cyBub3Qgc2V0CiMgQ09ORklHX01GRF9MTTM1MzMgaXMgbm90IHNldAojIENPTkZJR19NRkRfVEMz NTg5WCBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9UUU1YODYgaXMgbm90IHNldAojIENPTkZJR19N RkRfVlg4NTUgaXMgbm90IHNldAojIENPTkZJR19NRkRfTE9DSE5BR0FSIGlzIG5vdCBzZXQKQ09O RklHX01GRF9BUklaT05BPW0KQ09ORklHX01GRF9BUklaT05BX0kyQz1tCiMgQ09ORklHX01GRF9B UklaT05BX1NQSSBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9DUzQ3TDI0IGlzIG5vdCBzZXQKQ09O RklHX01GRF9XTTUxMDI9eQojIENPTkZJR19NRkRfV001MTEwIGlzIG5vdCBzZXQKIyBDT05GSUdf TUZEX1dNODk5NyBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9XTTg5OTggaXMgbm90IHNldAojIENP TkZJR19NRkRfV004NDAwIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1dNODMxWF9JMkMgaXMgbm90 IHNldAojIENPTkZJR19NRkRfV004MzFYX1NQSSBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9XTTgz NTBfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1dNODk5NCBpcyBub3Qgc2V0CiMgQ09ORklH X01GRF9ST0hNX0JENzE4WFggaXMgbm90IHNldAojIENPTkZJR19NRkRfUk9ITV9CRDcwNTI4IGlz IG5vdCBzZXQKIyBDT05GSUdfTUZEX1JPSE1fQkQ3MTgyOCBpcyBub3Qgc2V0CiMgQ09ORklHX01G RF9ST0hNX0JEOTU3WE1VRiBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9TVFBNSUMxIGlzIG5vdCBz ZXQKIyBDT05GSUdfTUZEX1NUTUZYIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX0FUQzI2MFhfSTJD IGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1FDT01fUE04MDA4IGlzIG5vdCBzZXQKIyBDT05GSUdf UkFWRV9TUF9DT1JFIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX0lOVEVMX00xMF9CTUMgaXMgbm90 IHNldAojIENPTkZJR19NRkRfUlNNVV9JMkMgaXMgbm90IHNldAojIENPTkZJR19NRkRfUlNNVV9T UEkgaXMgbm90IHNldAojIGVuZCBvZiBNdWx0aWZ1bmN0aW9uIGRldmljZSBkcml2ZXJzCgpDT05G SUdfUkVHVUxBVE9SPXkKIyBDT05GSUdfUkVHVUxBVE9SX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklH X1JFR1VMQVRPUl9GSVhFRF9WT0xUQUdFPXkKIyBDT05GSUdfUkVHVUxBVE9SX1ZJUlRVQUxfQ09O U1VNRVIgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfVVNFUlNQQUNFX0NPTlNVTUVSIGlz IG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SXzg4UEc4NlggaXMgbm90IHNldAojIENPTkZJR19S RUdVTEFUT1JfQUNUODg2NSBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9BRDUzOTggaXMg bm90IHNldApDT05GSUdfUkVHVUxBVE9SX0FSSVpPTkFfTERPMT1tCkNPTkZJR19SRUdVTEFUT1Jf QVJJWk9OQV9NSUNTVVBQPW0KIyBDT05GSUdfUkVHVUxBVE9SX0RBOTEyMSBpcyBub3Qgc2V0CiMg Q09ORklHX1JFR1VMQVRPUl9EQTkyMTAgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfREE5 MjExIGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX0ZBTjUzNTU1IGlzIG5vdCBzZXQKIyBD T05GSUdfUkVHVUxBVE9SX0ZBTjUzODgwIGlzIG5vdCBzZXQKQ09ORklHX1JFR1VMQVRPUl9HUElP PXkKIyBDT05GSUdfUkVHVUxBVE9SX0lTTDkzMDUgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFU T1JfSVNMNjI3MUEgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfTFAzOTcxIGlzIG5vdCBz ZXQKIyBDT05GSUdfUkVHVUxBVE9SX0xQMzk3MiBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRP Ul9MUDg3MlggaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfTFA4NzU1IGlzIG5vdCBzZXQK IyBDT05GSUdfUkVHVUxBVE9SX0xUQzM1ODkgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1Jf TFRDMzY3NiBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9NQVgxNTg2IGlzIG5vdCBzZXQK IyBDT05GSUdfUkVHVUxBVE9SX01BWDg2NDkgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1Jf TUFYODY2MCBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9NQVg4ODkzIGlzIG5vdCBzZXQK IyBDT05GSUdfUkVHVUxBVE9SX01BWDg5NTIgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1Jf TUFYODk3MyBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9NQVg3NzgyNiBpcyBub3Qgc2V0 CiMgQ09ORklHX1JFR1VMQVRPUl9NQ1AxNjUwMiBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRP Ul9NUDU0MTYgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfTVA4ODU5IGlzIG5vdCBzZXQK IyBDT05GSUdfUkVHVUxBVE9SX01QODg2WCBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9N UFE3OTIwIGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX01UNjMxMSBpcyBub3Qgc2V0CiMg Q09ORklHX1JFR1VMQVRPUl9QQ0E5NDUwIGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX1BG OFgwMCBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9QRlVaRTEwMCBpcyBub3Qgc2V0CiMg Q09ORklHX1JFR1VMQVRPUl9QVjg4MDYwIGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX1BW ODgwODAgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfUFY4ODA5MCBpcyBub3Qgc2V0CiMg Q09ORklHX1JFR1VMQVRPUl9QV00gaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfUkFTUEJF UlJZUElfVE9VQ0hTQ1JFRU5fQVRUSU5ZIGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX1JU NDgwMSBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9SVDYxNjAgaXMgbm90IHNldAojIENP TkZJR19SRUdVTEFUT1JfUlQ2MjQ1IGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX1JUUTIx MzQgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfUlRNVjIwIGlzIG5vdCBzZXQKIyBDT05G SUdfUkVHVUxBVE9SX1JUUTY3NTIgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfU0xHNTEw MDAgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfU1k4MTA2QSBpcyBub3Qgc2V0CiMgQ09O RklHX1JFR1VMQVRPUl9TWTg4MjRYIGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX1NZODgy N04gaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfVFBTNTE2MzIgaXMgbm90IHNldAojIENP TkZJR19SRUdVTEFUT1JfVFBTNjIzNjAgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfVFBT NjUwMjMgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfVFBTNjUwN1ggaXMgbm90IHNldAoj IENPTkZJR19SRUdVTEFUT1JfVFBTNjUxMzIgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1Jf VFBTNjUyNFggaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfVkNUUkwgaXMgbm90IHNldApD T05GSUdfUkNfQ09SRT15CkNPTkZJR19SQ19NQVA9eQojIENPTkZJR19MSVJDIGlzIG5vdCBzZXQK IyBDT05GSUdfUkNfREVDT0RFUlMgaXMgbm90IHNldApDT05GSUdfUkNfREVWSUNFUz15CiMgQ09O RklHX1JDX0FUSV9SRU1PVEUgaXMgbm90IHNldAojIENPTkZJR19JUl9ISVg1SEQyIGlzIG5vdCBz ZXQKIyBDT05GSUdfSVJfSU1PTiBpcyBub3Qgc2V0CiMgQ09ORklHX0lSX0lNT05fUkFXIGlzIG5v dCBzZXQKIyBDT05GSUdfSVJfTUNFVVNCIGlzIG5vdCBzZXQKIyBDT05GSUdfSVJfUkVEUkFUMyBp cyBub3Qgc2V0CiMgQ09ORklHX0lSX1NUUkVBTVpBUCBpcyBub3Qgc2V0CiMgQ09ORklHX0lSX0lH T1JQTFVHVVNCIGlzIG5vdCBzZXQKIyBDT05GSUdfSVJfSUdVQU5BIGlzIG5vdCBzZXQKIyBDT05G SUdfSVJfVFRVU0JJUiBpcyBub3Qgc2V0CiMgQ09ORklHX1JDX0xPT1BCQUNLIGlzIG5vdCBzZXQK IyBDT05GSUdfSVJfR1BJT19DSVIgaXMgbm90IHNldAojIENPTkZJR19JUl9TRVJJQUwgaXMgbm90 IHNldAojIENPTkZJR19JUl9TSVIgaXMgbm90IHNldAojIENPTkZJR19SQ19YQk9YX0RWRCBpcyBu b3Qgc2V0CiMgQ09ORklHX0lSX1RPWSBpcyBub3Qgc2V0CkNPTkZJR19DRUNfQ09SRT1tCkNPTkZJ R19NRURJQV9DRUNfUkM9eQpDT05GSUdfTUVESUFfQ0VDX1NVUFBPUlQ9eQojIENPTkZJR19DRUNf Q0g3MzIyIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0VDX0dQSU8gaXMgbm90IHNldAojIENPTkZJR19V U0JfUFVMU0U4X0NFQyBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9SQUlOU0hBRE9XX0NFQyBpcyBu b3Qgc2V0CkNPTkZJR19NRURJQV9TVVBQT1JUPW0KIyBDT05GSUdfTUVESUFfU1VQUE9SVF9GSUxU RVIgaXMgbm90IHNldAojIENPTkZJR19NRURJQV9TVUJEUlZfQVVUT1NFTEVDVCBpcyBub3Qgc2V0 CgojCiMgTWVkaWEgZGV2aWNlIHR5cGVzCiMKQ09ORklHX01FRElBX0NBTUVSQV9TVVBQT1JUPXkK Q09ORklHX01FRElBX0FOQUxPR19UVl9TVVBQT1JUPXkKQ09ORklHX01FRElBX0RJR0lUQUxfVFZf U1VQUE9SVD15CkNPTkZJR19NRURJQV9SQURJT19TVVBQT1JUPXkKQ09ORklHX01FRElBX1NEUl9T VVBQT1JUPXkKQ09ORklHX01FRElBX1BMQVRGT1JNX1NVUFBPUlQ9eQpDT05GSUdfTUVESUFfVEVT VF9TVVBQT1JUPXkKIyBlbmQgb2YgTWVkaWEgZGV2aWNlIHR5cGVzCgojCiMgTWVkaWEgY29yZSBz dXBwb3J0CiMKQ09ORklHX1ZJREVPX0RFVj1tCkNPTkZJR19NRURJQV9DT05UUk9MTEVSPXkKQ09O RklHX0RWQl9DT1JFPW0KIyBlbmQgb2YgTWVkaWEgY29yZSBzdXBwb3J0CgojCiMgVmlkZW80TGlu dXggb3B0aW9ucwojCkNPTkZJR19WSURFT19WNEwyPW0KQ09ORklHX1ZJREVPX1Y0TDJfSTJDPXkK IyBDT05GSUdfVklERU9fVjRMMl9TVUJERVZfQVBJIGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9f QURWX0RFQlVHIGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9fRklYRURfTUlOT1JfUkFOR0VTIGlz IG5vdCBzZXQKQ09ORklHX1ZJREVPX1RVTkVSPW0KIyBlbmQgb2YgVmlkZW80TGludXggb3B0aW9u cwoKIwojIE1lZGlhIGNvbnRyb2xsZXIgb3B0aW9ucwojCiMgQ09ORklHX01FRElBX0NPTlRST0xM RVJfRFZCIGlzIG5vdCBzZXQKIyBlbmQgb2YgTWVkaWEgY29udHJvbGxlciBvcHRpb25zCgojCiMg RGlnaXRhbCBUViBvcHRpb25zCiMKIyBDT05GSUdfRFZCX01NQVAgaXMgbm90IHNldApDT05GSUdf RFZCX05FVD15CkNPTkZJR19EVkJfTUFYX0FEQVBURVJTPTE2CkNPTkZJR19EVkJfRFlOQU1JQ19N SU5PUlM9eQojIENPTkZJR19EVkJfREVNVVhfU0VDVElPTl9MT1NTX0xPRyBpcyBub3Qgc2V0CiMg Q09ORklHX0RWQl9VTEVfREVCVUcgaXMgbm90IHNldAojIGVuZCBvZiBEaWdpdGFsIFRWIG9wdGlv bnMKCiMKIyBNZWRpYSBkcml2ZXJzCiMKQ09ORklHX01FRElBX1VTQl9TVVBQT1JUPXkKCiMKIyBX ZWJjYW0gZGV2aWNlcwojCkNPTkZJR19VU0JfVklERU9fQ0xBU1M9bQpDT05GSUdfVVNCX1ZJREVP X0NMQVNTX0lOUFVUX0VWREVWPXkKIyBDT05GSUdfVVNCX0dTUENBIGlzIG5vdCBzZXQKIyBDT05G SUdfVVNCX1BXQyBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX0NQSUEyIGlzIG5vdCBzZXQKIyBD T05GSUdfVVNCX1pSMzY0WFggaXMgbm90IHNldAojIENPTkZJR19VU0JfU1RLV0VCQ0FNIGlzIG5v dCBzZXQKIyBDT05GSUdfVVNCX1MyMjU1IGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9fVVNCVFYg aXMgbm90IHNldAoKIwojIEFuYWxvZyBUViBVU0IgZGV2aWNlcwojCiMgQ09ORklHX1ZJREVPX1BW UlVTQjIgaXMgbm90IHNldAojIENPTkZJR19WSURFT19IRFBWUiBpcyBub3Qgc2V0CiMgQ09ORklH X1ZJREVPX1NUSzExNjBfQ09NTU9OIGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9fR083MDA3IGlz IG5vdCBzZXQKCiMKIyBBbmFsb2cvZGlnaXRhbCBUViBVU0IgZGV2aWNlcwojCiMgQ09ORklHX1ZJ REVPX0FVMDgyOCBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX0NYMjMxWFggaXMgbm90IHNldAoj IENPTkZJR19WSURFT19UTTYwMDAgaXMgbm90IHNldAoKIwojIERpZ2l0YWwgVFYgVVNCIGRldmlj ZXMKIwojIENPTkZJR19EVkJfVVNCIGlzIG5vdCBzZXQKIyBDT05GSUdfRFZCX1VTQl9WMiBpcyBu b3Qgc2V0CiMgQ09ORklHX0RWQl9UVFVTQl9CVURHRVQgaXMgbm90IHNldAojIENPTkZJR19EVkJf VFRVU0JfREVDIGlzIG5vdCBzZXQKIyBDT05GSUdfU01TX1VTQl9EUlYgaXMgbm90IHNldAojIENP TkZJR19EVkJfQjJDMl9GTEVYQ09QX1VTQiBpcyBub3Qgc2V0CiMgQ09ORklHX0RWQl9BUzEwMiBp cyBub3Qgc2V0CgojCiMgV2ViY2FtLCBUViAoYW5hbG9nL2RpZ2l0YWwpIFVTQiBkZXZpY2VzCiMK Q09ORklHX1ZJREVPX0VNMjhYWD1tCkNPTkZJR19WSURFT19FTTI4WFhfVjRMMj1tCkNPTkZJR19W SURFT19FTTI4WFhfQUxTQT1tCkNPTkZJR19WSURFT19FTTI4WFhfRFZCPW0KQ09ORklHX1ZJREVP X0VNMjhYWF9SQz1tCgojCiMgU29mdHdhcmUgZGVmaW5lZCByYWRpbyBVU0IgZGV2aWNlcwojCiMg Q09ORklHX1VTQl9BSVJTUFkgaXMgbm90IHNldAojIENPTkZJR19VU0JfSEFDS1JGIGlzIG5vdCBz ZXQKIyBDT05GSUdfVVNCX01TSTI1MDAgaXMgbm90IHNldAojIENPTkZJR19NRURJQV9QQ0lfU1VQ UE9SVCBpcyBub3Qgc2V0CkNPTkZJR19SQURJT19BREFQVEVSUz15CiMgQ09ORklHX1JBRElPX1NJ NDcwWCBpcyBub3Qgc2V0CiMgQ09ORklHX1JBRElPX1NJNDcxMyBpcyBub3Qgc2V0CiMgQ09ORklH X1VTQl9NUjgwMCBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9EU0JSIGlzIG5vdCBzZXQKIyBDT05G SUdfUkFESU9fTUFYSVJBRElPIGlzIG5vdCBzZXQKIyBDT05GSUdfUkFESU9fU0hBUksgaXMgbm90 IHNldAojIENPTkZJR19SQURJT19TSEFSSzIgaXMgbm90IHNldAojIENPTkZJR19VU0JfS0VFTkUg aXMgbm90IHNldAojIENPTkZJR19VU0JfUkFSRU1PTk8gaXMgbm90IHNldAojIENPTkZJR19VU0Jf TUE5MDEgaXMgbm90IHNldAojIENPTkZJR19SQURJT19URUE1NzY0IGlzIG5vdCBzZXQKIyBDT05G SUdfUkFESU9fU0FBNzcwNkggaXMgbm90IHNldAojIENPTkZJR19SQURJT19URUY2ODYyIGlzIG5v dCBzZXQKIyBDT05GSUdfUkFESU9fV0wxMjczIGlzIG5vdCBzZXQKQ09ORklHX1ZJREVPX1RWRUVQ Uk9NPW0KQ09ORklHX1ZJREVPQlVGMl9DT1JFPW0KQ09ORklHX1ZJREVPQlVGMl9WNEwyPW0KQ09O RklHX1ZJREVPQlVGMl9NRU1PUFM9bQpDT05GSUdfVklERU9CVUYyX1ZNQUxMT0M9bQpDT05GSUdf VjRMX1BMQVRGT1JNX0RSSVZFUlM9eQojIENPTkZJR19WSURFT19DQUZFX0NDSUMgaXMgbm90IHNl dAojIENPTkZJR19WSURFT19DQURFTkNFIGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9fQVNQRUVE IGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9fTVVYIGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9f WElMSU5YIGlzIG5vdCBzZXQKIyBDT05GSUdfVjRMX01FTTJNRU1fRFJJVkVSUyBpcyBub3Qgc2V0 CiMgQ09ORklHX0RWQl9QTEFURk9STV9EUklWRVJTIGlzIG5vdCBzZXQKIyBDT05GSUdfU0RSX1BM QVRGT1JNX0RSSVZFUlMgaXMgbm90IHNldAoKIwojIE1NQy9TRElPIERWQiBhZGFwdGVycwojCiMg Q09ORklHX1NNU19TRElPX0RSViBpcyBub3Qgc2V0CiMgQ09ORklHX1Y0TF9URVNUX0RSSVZFUlMg aXMgbm90IHNldAojIENPTkZJR19EVkJfVEVTVF9EUklWRVJTIGlzIG5vdCBzZXQKIyBlbmQgb2Yg TWVkaWEgZHJpdmVycwoKIwojIE1lZGlhIGFuY2lsbGFyeSBkcml2ZXJzCiMKQ09ORklHX01FRElB X0FUVEFDSD15CkNPTkZJR19WSURFT19JUl9JMkM9bQoKIwojIEF1ZGlvIGRlY29kZXJzLCBwcm9j ZXNzb3JzIGFuZCBtaXhlcnMKIwojIENPTkZJR19WSURFT19UVkFVRElPIGlzIG5vdCBzZXQKIyBD T05GSUdfVklERU9fVERBNzQzMiBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX1REQTk4NDAgaXMg bm90IHNldAojIENPTkZJR19WSURFT19UREExOTk3WCBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVP X1RFQTY0MTVDIGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9fVEVBNjQyMCBpcyBub3Qgc2V0CiMg Q09ORklHX1ZJREVPX01TUDM0MDAgaXMgbm90IHNldAojIENPTkZJR19WSURFT19DUzMzMDggaXMg bm90IHNldAojIENPTkZJR19WSURFT19DUzUzNDUgaXMgbm90IHNldAojIENPTkZJR19WSURFT19D UzUzTDMyQSBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX1RMVjMyMEFJQzIzQiBpcyBub3Qgc2V0 CiMgQ09ORklHX1ZJREVPX1VEQTEzNDIgaXMgbm90IHNldAojIENPTkZJR19WSURFT19XTTg3NzUg aXMgbm90IHNldAojIENPTkZJR19WSURFT19XTTg3MzkgaXMgbm90IHNldAojIENPTkZJR19WSURF T19WUDI3U01QWCBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX1NPTllfQlRGX01QWCBpcyBub3Qg c2V0CiMgZW5kIG9mIEF1ZGlvIGRlY29kZXJzLCBwcm9jZXNzb3JzIGFuZCBtaXhlcnMKCiMKIyBS RFMgZGVjb2RlcnMKIwojIENPTkZJR19WSURFT19TQUE2NTg4IGlzIG5vdCBzZXQKIyBlbmQgb2Yg UkRTIGRlY29kZXJzCgojCiMgVmlkZW8gZGVjb2RlcnMKIwojIENPTkZJR19WSURFT19BRFY3MTgw IGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9fQURWNzE4MyBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJ REVPX0FEVjc0OFggaXMgbm90IHNldAojIENPTkZJR19WSURFT19BRFY3NjA0IGlzIG5vdCBzZXQK IyBDT05GSUdfVklERU9fQURWNzg0MiBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX0JUODE5IGlz IG5vdCBzZXQKIyBDT05GSUdfVklERU9fQlQ4NTYgaXMgbm90IHNldAojIENPTkZJR19WSURFT19C VDg2NiBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX0tTMDEyNyBpcyBub3Qgc2V0CiMgQ09ORklH X1ZJREVPX01MODZWNzY2NyBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX1NBQTcxMTAgaXMgbm90 IHNldAojIENPTkZJR19WSURFT19TQUE3MTFYIGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9fVEMz NTg3NDMgaXMgbm90IHNldAojIENPTkZJR19WSURFT19UVlA1MTRYIGlzIG5vdCBzZXQKIyBDT05G SUdfVklERU9fVFZQNTE1MCBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX1RWUDcwMDIgaXMgbm90 IHNldAojIENPTkZJR19WSURFT19UVzI4MDQgaXMgbm90IHNldAojIENPTkZJR19WSURFT19UVzk5 MDMgaXMgbm90IHNldAojIENPTkZJR19WSURFT19UVzk5MDYgaXMgbm90IHNldAojIENPTkZJR19W SURFT19UVzk5MTAgaXMgbm90IHNldAojIENPTkZJR19WSURFT19WUFgzMjIwIGlzIG5vdCBzZXQK IyBDT05GSUdfVklERU9fTUFYOTI4NiBpcyBub3Qgc2V0CgojCiMgVmlkZW8gYW5kIGF1ZGlvIGRl Y29kZXJzCiMKIyBDT05GSUdfVklERU9fU0FBNzE3WCBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVP X0NYMjU4NDAgaXMgbm90IHNldAojIGVuZCBvZiBWaWRlbyBkZWNvZGVycwoKIwojIFZpZGVvIGVu Y29kZXJzCiMKIyBDT05GSUdfVklERU9fU0FBNzEyNyBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVP X1NBQTcxODUgaXMgbm90IHNldAojIENPTkZJR19WSURFT19BRFY3MTcwIGlzIG5vdCBzZXQKIyBD T05GSUdfVklERU9fQURWNzE3NSBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX0FEVjczNDMgaXMg bm90IHNldAojIENPTkZJR19WSURFT19BRFY3MzkzIGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9f QURWNzUxMSBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX0FEOTM4OUIgaXMgbm90IHNldAojIENP TkZJR19WSURFT19BSzg4MVggaXMgbm90IHNldAojIENPTkZJR19WSURFT19USFM4MjAwIGlzIG5v dCBzZXQKIyBlbmQgb2YgVmlkZW8gZW5jb2RlcnMKCiMKIyBWaWRlbyBpbXByb3ZlbWVudCBjaGlw cwojCiMgQ09ORklHX1ZJREVPX1VQRDY0MDMxQSBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX1VQ RDY0MDgzIGlzIG5vdCBzZXQKIyBlbmQgb2YgVmlkZW8gaW1wcm92ZW1lbnQgY2hpcHMKCiMKIyBB dWRpby9WaWRlbyBjb21wcmVzc2lvbiBjaGlwcwojCiMgQ09ORklHX1ZJREVPX1NBQTY3NTJIUyBp cyBub3Qgc2V0CiMgZW5kIG9mIEF1ZGlvL1ZpZGVvIGNvbXByZXNzaW9uIGNoaXBzCgojCiMgU0RS IHR1bmVyIGNoaXBzCiMKIyBDT05GSUdfU0RSX01BWDIxNzUgaXMgbm90IHNldAojIGVuZCBvZiBT RFIgdHVuZXIgY2hpcHMKCiMKIyBNaXNjZWxsYW5lb3VzIGhlbHBlciBjaGlwcwojCiMgQ09ORklH X1ZJREVPX1RIUzczMDMgaXMgbm90IHNldAojIENPTkZJR19WSURFT19NNTI3OTAgaXMgbm90IHNl dAojIENPTkZJR19WSURFT19JMkMgaXMgbm90IHNldAojIENPTkZJR19WSURFT19TVF9NSVBJRDAy IGlzIG5vdCBzZXQKIyBlbmQgb2YgTWlzY2VsbGFuZW91cyBoZWxwZXIgY2hpcHMKCiMKIyBDYW1l cmEgc2Vuc29yIGRldmljZXMKIwojIENPTkZJR19WSURFT19ISTU1NiBpcyBub3Qgc2V0CiMgQ09O RklHX1ZJREVPX0lNWDIxNCBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX0lNWDIxOSBpcyBub3Qg c2V0CiMgQ09ORklHX1ZJREVPX0lNWDI1OCBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX0lNWDI3 NCBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX0lNWDI5MCBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJ REVPX0lNWDMxOSBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX0lNWDMzNCBpcyBub3Qgc2V0CiMg Q09ORklHX1ZJREVPX0lNWDMzNSBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX0lNWDM1NSBpcyBu b3Qgc2V0CiMgQ09ORklHX1ZJREVPX0lNWDQxMiBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX09W MDJBMTAgaXMgbm90IHNldAojIENPTkZJR19WSURFT19PVjI2NDAgaXMgbm90IHNldAojIENPTkZJ R19WSURFT19PVjI2NTkgaXMgbm90IHNldAojIENPTkZJR19WSURFT19PVjI2ODAgaXMgbm90IHNl dAojIENPTkZJR19WSURFT19PVjI2ODUgaXMgbm90IHNldAojIENPTkZJR19WSURFT19PVjU2NDAg aXMgbm90IHNldAojIENPTkZJR19WSURFT19PVjU2NDUgaXMgbm90IHNldAojIENPTkZJR19WSURF T19PVjU2NDcgaXMgbm90IHNldAojIENPTkZJR19WSURFT19PVjU2NDggaXMgbm90IHNldAojIENP TkZJR19WSURFT19PVjY2NTAgaXMgbm90IHNldAojIENPTkZJR19WSURFT19PVjU2NzAgaXMgbm90 IHNldAojIENPTkZJR19WSURFT19PVjU2NzUgaXMgbm90IHNldAojIENPTkZJR19WSURFT19PVjU2 OTUgaXMgbm90IHNldAojIENPTkZJR19WSURFT19PVjcyNTEgaXMgbm90IHNldAojIENPTkZJR19W SURFT19PVjc3MlggaXMgbm90IHNldAojIENPTkZJR19WSURFT19PVjc2NDAgaXMgbm90IHNldAoj IENPTkZJR19WSURFT19PVjc2NzAgaXMgbm90IHNldAojIENPTkZJR19WSURFT19PVjc3NDAgaXMg bm90IHNldAojIENPTkZJR19WSURFT19PVjg4NTYgaXMgbm90IHNldAojIENPTkZJR19WSURFT19P Vjg4NjUgaXMgbm90IHNldAojIENPTkZJR19WSURFT19PVjkyODIgaXMgbm90IHNldAojIENPTkZJ R19WSURFT19PVjk2NDAgaXMgbm90IHNldAojIENPTkZJR19WSURFT19PVjk2NTAgaXMgbm90IHNl dAojIENPTkZJR19WSURFT19PVjEzODU4IGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9fVlM2NjI0 IGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9fTVQ5TTAwMSBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJ REVPX01UOU0wMzIgaXMgbm90IHNldAojIENPTkZJR19WSURFT19NVDlNMTExIGlzIG5vdCBzZXQK IyBDT05GSUdfVklERU9fTVQ5UDAzMSBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX01UOVQwMDEg aXMgbm90IHNldAojIENPTkZJR19WSURFT19NVDlUMTEyIGlzIG5vdCBzZXQKIyBDT05GSUdfVklE RU9fTVQ5VjAxMSBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX01UOVYwMzIgaXMgbm90IHNldAoj IENPTkZJR19WSURFT19NVDlWMTExIGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9fU1IwMzBQQzMw IGlzIG5vdCBzZXQKIyBDT05GSUdfVklERU9fTk9PTjAxMFBDMzAgaXMgbm90IHNldAojIENPTkZJ R19WSURFT19NNU1PTFMgaXMgbm90IHNldAojIENPTkZJR19WSURFT19SREFDTTIwIGlzIG5vdCBz ZXQKIyBDT05GSUdfVklERU9fUkRBQ00yMSBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX1JKNTRO MSBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX1M1SzZBQSBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJ REVPX1M1SzZBMyBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX1M1SzRFQ0dYIGlzIG5vdCBzZXQK IyBDT05GSUdfVklERU9fUzVLNUJBRiBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX0NDUyBpcyBu b3Qgc2V0CiMgQ09ORklHX1ZJREVPX0VUOEVLOCBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJREVPX1M1 QzczTTMgaXMgbm90IHNldAojIGVuZCBvZiBDYW1lcmEgc2Vuc29yIGRldmljZXMKCiMKIyBMZW5z IGRyaXZlcnMKIwojIENPTkZJR19WSURFT19BRDU4MjAgaXMgbm90IHNldAojIENPTkZJR19WSURF T19BSzczNzUgaXMgbm90IHNldAojIENPTkZJR19WSURFT19EVzk3MTQgaXMgbm90IHNldAojIENP TkZJR19WSURFT19EVzk3NjggaXMgbm90IHNldAojIENPTkZJR19WSURFT19EVzk4MDdfVkNNIGlz IG5vdCBzZXQKIyBlbmQgb2YgTGVucyBkcml2ZXJzCgojCiMgRmxhc2ggZGV2aWNlcwojCiMgQ09O RklHX1ZJREVPX0FEUDE2NTMgaXMgbm90IHNldAojIENPTkZJR19WSURFT19MTTM1NjAgaXMgbm90 IHNldAojIENPTkZJR19WSURFT19MTTM2NDYgaXMgbm90IHNldAojIGVuZCBvZiBGbGFzaCBkZXZp Y2VzCgojCiMgU1BJIGhlbHBlciBjaGlwcwojCiMgQ09ORklHX1ZJREVPX0dTMTY2MiBpcyBub3Qg c2V0CiMgZW5kIG9mIFNQSSBoZWxwZXIgY2hpcHMKCiMKIyBNZWRpYSBTUEkgQWRhcHRlcnMKIwpD T05GSUdfQ1hEMjg4MF9TUElfRFJWPW0KIyBlbmQgb2YgTWVkaWEgU1BJIEFkYXB0ZXJzCgpDT05G SUdfTUVESUFfVFVORVI9bQoKIwojIEN1c3RvbWl6ZSBUViB0dW5lcnMKIwpDT05GSUdfTUVESUFf VFVORVJfU0lNUExFPW0KQ09ORklHX01FRElBX1RVTkVSX1REQTE4MjUwPW0KQ09ORklHX01FRElB X1RVTkVSX1REQTgyOTA9bQpDT05GSUdfTUVESUFfVFVORVJfVERBODI3WD1tCkNPTkZJR19NRURJ QV9UVU5FUl9UREExODI3MT1tCkNPTkZJR19NRURJQV9UVU5FUl9UREE5ODg3PW0KQ09ORklHX01F RElBX1RVTkVSX1RFQTU3NjE9bQpDT05GSUdfTUVESUFfVFVORVJfVEVBNTc2Nz1tCkNPTkZJR19N RURJQV9UVU5FUl9NU0kwMDE9bQpDT05GSUdfTUVESUFfVFVORVJfTVQyMFhYPW0KQ09ORklHX01F RElBX1RVTkVSX01UMjA2MD1tCkNPTkZJR19NRURJQV9UVU5FUl9NVDIwNjM9bQpDT05GSUdfTUVE SUFfVFVORVJfTVQyMjY2PW0KQ09ORklHX01FRElBX1RVTkVSX01UMjEzMT1tCkNPTkZJR19NRURJ QV9UVU5FUl9RVDEwMTA9bQpDT05GSUdfTUVESUFfVFVORVJfWEMyMDI4PW0KQ09ORklHX01FRElB X1RVTkVSX1hDNTAwMD1tCkNPTkZJR19NRURJQV9UVU5FUl9YQzQwMDA9bQpDT05GSUdfTUVESUFf VFVORVJfTVhMNTAwNVM9bQpDT05GSUdfTUVESUFfVFVORVJfTVhMNTAwN1Q9bQpDT05GSUdfTUVE SUFfVFVORVJfTUM0NFM4MDM9bQpDT05GSUdfTUVESUFfVFVORVJfTUFYMjE2NT1tCkNPTkZJR19N RURJQV9UVU5FUl9UREExODIxOD1tCkNPTkZJR19NRURJQV9UVU5FUl9GQzAwMTE9bQpDT05GSUdf TUVESUFfVFVORVJfRkMwMDEyPW0KQ09ORklHX01FRElBX1RVTkVSX0ZDMDAxMz1tCkNPTkZJR19N RURJQV9UVU5FUl9UREExODIxMj1tCkNPTkZJR19NRURJQV9UVU5FUl9FNDAwMD1tCkNPTkZJR19N RURJQV9UVU5FUl9GQzI1ODA9bQpDT05GSUdfTUVESUFfVFVORVJfTTg4UlM2MDAwVD1tCkNPTkZJ R19NRURJQV9UVU5FUl9UVUE5MDAxPW0KQ09ORklHX01FRElBX1RVTkVSX1NJMjE1Nz1tCkNPTkZJ R19NRURJQV9UVU5FUl9JVDkxM1g9bQpDT05GSUdfTUVESUFfVFVORVJfUjgyMFQ9bQpDT05GSUdf TUVESUFfVFVORVJfTVhMMzAxUkY9bQpDT05GSUdfTUVESUFfVFVORVJfUU0xRDFDMDA0Mj1tCkNP TkZJR19NRURJQV9UVU5FUl9RTTFEMUIwMDA0PW0KIyBlbmQgb2YgQ3VzdG9taXplIFRWIHR1bmVy cwoKIwojIEN1c3RvbWlzZSBEVkIgRnJvbnRlbmRzCiMKCiMKIyBNdWx0aXN0YW5kYXJkIChzYXRl bGxpdGUpIGZyb250ZW5kcwojCkNPTkZJR19EVkJfU1RCMDg5OT1tCkNPTkZJR19EVkJfU1RCNjEw MD1tCkNPTkZJR19EVkJfU1RWMDkweD1tCkNPTkZJR19EVkJfU1RWMDkxMD1tCkNPTkZJR19EVkJf U1RWNjExMHg9bQpDT05GSUdfRFZCX1NUVjYxMTE9bQpDT05GSUdfRFZCX01YTDVYWD1tCkNPTkZJ R19EVkJfTTg4RFMzMTAzPW0KCiMKIyBNdWx0aXN0YW5kYXJkIChjYWJsZSArIHRlcnJlc3RyaWFs KSBmcm9udGVuZHMKIwpDT05GSUdfRFZCX0RSWEs9bQpDT05GSUdfRFZCX1REQTE4MjcxQzJERD1t CkNPTkZJR19EVkJfU0kyMTY1PW0KQ09ORklHX0RWQl9NTjg4NDcyPW0KQ09ORklHX0RWQl9NTjg4 NDczPW0KCiMKIyBEVkItUyAoc2F0ZWxsaXRlKSBmcm9udGVuZHMKIwpDT05GSUdfRFZCX0NYMjQx MTA9bQpDT05GSUdfRFZCX0NYMjQxMjM9bQpDT05GSUdfRFZCX01UMzEyPW0KQ09ORklHX0RWQl9a TDEwMDM2PW0KQ09ORklHX0RWQl9aTDEwMDM5PW0KQ09ORklHX0RWQl9TNUgxNDIwPW0KQ09ORklH X0RWQl9TVFYwMjg4PW0KQ09ORklHX0RWQl9TVEI2MDAwPW0KQ09ORklHX0RWQl9TVFYwMjk5PW0K Q09ORklHX0RWQl9TVFY2MTEwPW0KQ09ORklHX0RWQl9TVFYwOTAwPW0KQ09ORklHX0RWQl9UREE4 MDgzPW0KQ09ORklHX0RWQl9UREExMDA4Nj1tCkNPTkZJR19EVkJfVERBODI2MT1tCkNPTkZJR19E VkJfVkVTMVg5Mz1tCkNPTkZJR19EVkJfVFVORVJfSVREMTAwMD1tCkNPTkZJR19EVkJfVFVORVJf Q1gyNDExMz1tCkNPTkZJR19EVkJfVERBODI2WD1tCkNPTkZJR19EVkJfVFVBNjEwMD1tCkNPTkZJ R19EVkJfQ1gyNDExNj1tCkNPTkZJR19EVkJfQ1gyNDExNz1tCkNPTkZJR19EVkJfQ1gyNDEyMD1t CkNPTkZJR19EVkJfU0kyMVhYPW0KQ09ORklHX0RWQl9UUzIwMjA9bQpDT05GSUdfRFZCX0RTMzAw MD1tCkNPTkZJR19EVkJfTUI4NkExNj1tCkNPTkZJR19EVkJfVERBMTAwNzE9bQoKIwojIERWQi1U ICh0ZXJyZXN0cmlhbCkgZnJvbnRlbmRzCiMKQ09ORklHX0RWQl9TUDg4N1g9bQpDT05GSUdfRFZC X0NYMjI3MDA9bQpDT05GSUdfRFZCX0NYMjI3MDI9bQpDT05GSUdfRFZCX1M1SDE0MzI9bQpDT05G SUdfRFZCX0RSWEQ9bQpDT05GSUdfRFZCX0w2NDc4MT1tCkNPTkZJR19EVkJfVERBMTAwNFg9bQpD T05GSUdfRFZCX05YVDYwMDA9bQpDT05GSUdfRFZCX01UMzUyPW0KQ09ORklHX0RWQl9aTDEwMzUz PW0KQ09ORklHX0RWQl9ESUIzMDAwTUI9bQpDT05GSUdfRFZCX0RJQjMwMDBNQz1tCkNPTkZJR19E VkJfRElCNzAwME09bQpDT05GSUdfRFZCX0RJQjcwMDBQPW0KQ09ORklHX0RWQl9ESUI5MDAwPW0K Q09ORklHX0RWQl9UREExMDA0OD1tCkNPTkZJR19EVkJfQUY5MDEzPW0KQ09ORklHX0RWQl9FQzEw MD1tCkNPTkZJR19EVkJfU1RWMDM2Nz1tCkNPTkZJR19EVkJfQ1hEMjgyMFI9bQpDT05GSUdfRFZC X0NYRDI4NDFFUj1tCkNPTkZJR19EVkJfUlRMMjgzMD1tCkNPTkZJR19EVkJfUlRMMjgzMj1tCkNP TkZJR19EVkJfUlRMMjgzMl9TRFI9bQpDT05GSUdfRFZCX1NJMjE2OD1tCkNPTkZJR19EVkJfWkQx MzAxX0RFTU9EPW0KQ09ORklHX0RWQl9DWEQyODgwPW0KCiMKIyBEVkItQyAoY2FibGUpIGZyb250 ZW5kcwojCkNPTkZJR19EVkJfVkVTMTgyMD1tCkNPTkZJR19EVkJfVERBMTAwMjE9bQpDT05GSUdf RFZCX1REQTEwMDIzPW0KQ09ORklHX0RWQl9TVFYwMjk3PW0KCiMKIyBBVFNDIChOb3J0aCBBbWVy aWNhbi9Lb3JlYW4gVGVycmVzdHJpYWwvQ2FibGUgRFRWKSBmcm9udGVuZHMKIwpDT05GSUdfRFZC X05YVDIwMFg9bQpDT05GSUdfRFZCX09SNTEyMTE9bQpDT05GSUdfRFZCX09SNTExMzI9bQpDT05G SUdfRFZCX0JDTTM1MTA9bQpDT05GSUdfRFZCX0xHRFQzMzBYPW0KQ09ORklHX0RWQl9MR0RUMzMw NT1tCkNPTkZJR19EVkJfTEdEVDMzMDZBPW0KQ09ORklHX0RWQl9MRzIxNjA9bQpDT05GSUdfRFZC X1M1SDE0MDk9bQpDT05GSUdfRFZCX0FVODUyMj1tCkNPTkZJR19EVkJfQVU4NTIyX0RUVj1tCkNP TkZJR19EVkJfQVU4NTIyX1Y0TD1tCkNPTkZJR19EVkJfUzVIMTQxMT1tCkNPTkZJR19EVkJfTVhM NjkyPW0KCiMKIyBJU0RCLVQgKHRlcnJlc3RyaWFsKSBmcm9udGVuZHMKIwpDT05GSUdfRFZCX1M5 MjE9bQpDT05GSUdfRFZCX0RJQjgwMDA9bQpDT05GSUdfRFZCX01CODZBMjBTPW0KCiMKIyBJU0RC LVMgKHNhdGVsbGl0ZSkgJiBJU0RCLVQgKHRlcnJlc3RyaWFsKSBmcm9udGVuZHMKIwpDT05GSUdf RFZCX1RDOTA1MjI9bQpDT05GSUdfRFZCX01OODg0NDNYPW0KCiMKIyBEaWdpdGFsIHRlcnJlc3Ry aWFsIG9ubHkgdHVuZXJzL1BMTAojCkNPTkZJR19EVkJfUExMPW0KQ09ORklHX0RWQl9UVU5FUl9E SUIwMDcwPW0KQ09ORklHX0RWQl9UVU5FUl9ESUIwMDkwPW0KCiMKIyBTRUMgY29udHJvbCBkZXZp Y2VzIGZvciBEVkItUwojCkNPTkZJR19EVkJfRFJYMzlYWUo9bQpDT05GSUdfRFZCX0xOQkgyNT1t CkNPTkZJR19EVkJfTE5CSDI5PW0KQ09ORklHX0RWQl9MTkJQMjE9bQpDT05GSUdfRFZCX0xOQlAy Mj1tCkNPTkZJR19EVkJfSVNMNjQwNT1tCkNPTkZJR19EVkJfSVNMNjQyMT1tCkNPTkZJR19EVkJf SVNMNjQyMz1tCkNPTkZJR19EVkJfQTgyOTM9bQpDT05GSUdfRFZCX0xHUzhHTDU9bQpDT05GSUdf RFZCX0xHUzhHWFg9bQpDT05GSUdfRFZCX0FUQk04ODMwPW0KQ09ORklHX0RWQl9UREE2NjV4PW0K Q09ORklHX0RWQl9JWDI1MDVWPW0KQ09ORklHX0RWQl9NODhSUzIwMDA9bQpDT05GSUdfRFZCX0FG OTAzMz1tCkNPTkZJR19EVkJfSE9SVVMzQT1tCkNPTkZJR19EVkJfQVNDT1QyRT1tCkNPTkZJR19E VkJfSEVMRU5FPW0KCiMKIyBDb21tb24gSW50ZXJmYWNlIChFTjUwMjIxKSBjb250cm9sbGVyIGRy aXZlcnMKIwpDT05GSUdfRFZCX0NYRDIwOTk9bQpDT05GSUdfRFZCX1NQMj1tCiMgZW5kIG9mIEN1 c3RvbWlzZSBEVkIgRnJvbnRlbmRzCgojCiMgVG9vbHMgdG8gZGV2ZWxvcCBuZXcgZnJvbnRlbmRz CiMKIyBDT05GSUdfRFZCX0RVTU1ZX0ZFIGlzIG5vdCBzZXQKIyBlbmQgb2YgTWVkaWEgYW5jaWxs YXJ5IGRyaXZlcnMKCiMKIyBHcmFwaGljcyBzdXBwb3J0CiMKQ09ORklHX1ZHQV9BUkI9eQpDT05G SUdfVkdBX0FSQl9NQVhfR1BVUz0xNgpDT05GSUdfRFJNPXkKQ09ORklHX0RSTV9NSVBJX0RTST15 CiMgQ09ORklHX0RSTV9EUF9BVVhfQ0hBUkRFViBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9ERUJV R19NTSBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9ERUJVR19TRUxGVEVTVCBpcyBub3Qgc2V0CkNP TkZJR19EUk1fS01TX0hFTFBFUj15CiMgQ09ORklHX0RSTV9ERUJVR19EUF9NU1RfVE9QT0xPR1lf UkVGUyBpcyBub3Qgc2V0CkNPTkZJR19EUk1fRkJERVZfRU1VTEFUSU9OPXkKQ09ORklHX0RSTV9G QkRFVl9PVkVSQUxMT0M9MTAwCiMgQ09ORklHX0RSTV9GQkRFVl9MRUFLX1BIWVNfU01FTSBpcyBu b3Qgc2V0CkNPTkZJR19EUk1fTE9BRF9FRElEX0ZJUk1XQVJFPXkKIyBDT05GSUdfRFJNX0RQX0NF QyBpcyBub3Qgc2V0CkNPTkZJR19EUk1fR0VNX0NNQV9IRUxQRVI9eQpDT05GSUdfRFJNX0tNU19D TUFfSEVMUEVSPXkKQ09ORklHX0RSTV9HRU1fU0hNRU1fSEVMUEVSPXkKCiMKIyBJMkMgZW5jb2Rl ciBvciBoZWxwZXIgY2hpcHMKIwojIENPTkZJR19EUk1fSTJDX0NINzAwNiBpcyBub3Qgc2V0CiMg Q09ORklHX0RSTV9JMkNfU0lMMTY0IGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX0kyQ19OWFBfVERB OTk4WCBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9JMkNfTlhQX1REQTk5NTAgaXMgbm90IHNldAoj IGVuZCBvZiBJMkMgZW5jb2RlciBvciBoZWxwZXIgY2hpcHMKCiMKIyBBUk0gZGV2aWNlcwojCiMg Q09ORklHX0RSTV9IRExDRCBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9NQUxJX0RJU1BMQVkgaXMg bm90IHNldAojIENPTkZJR19EUk1fS09NRURBIGlzIG5vdCBzZXQKIyBlbmQgb2YgQVJNIGRldmlj ZXMKCiMgQ09ORklHX0RSTV9SQURFT04gaXMgbm90IHNldAojIENPTkZJR19EUk1fQU1ER1BVIGlz IG5vdCBzZXQKIyBDT05GSUdfRFJNX05PVVZFQVUgaXMgbm90IHNldAojIENPTkZJR19EUk1fVkdF TSBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9WS01TIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1ZN V0dGWCBpcyBub3Qgc2V0CkNPTkZJR19EUk1fVURMPW0KIyBDT05GSUdfRFJNX0FTVCBpcyBub3Qg c2V0CiMgQ09ORklHX0RSTV9NR0FHMjAwIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1JDQVJfRFdf SERNSSBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9SQ0FSX0xWRFMgaXMgbm90IHNldAojIENPTkZJ R19EUk1fUVhMIGlzIG5vdCBzZXQKQ09ORklHX0RSTV9WSVJUSU9fR1BVPXkKQ09ORklHX0RSTV9Q QU5FTD15CgojCiMgRGlzcGxheSBQYW5lbHMKIwojIENPTkZJR19EUk1fUEFORUxfQUJUX1kwMzBY WDA2N0EgaXMgbm90IHNldAojIENPTkZJR19EUk1fUEFORUxfQVJNX1ZFUlNBVElMRSBpcyBub3Qg c2V0CiMgQ09ORklHX0RSTV9QQU5FTF9BU1VTX1owMFRfVE01UDVfTlQzNTU5NiBpcyBub3Qgc2V0 CiMgQ09ORklHX0RSTV9QQU5FTF9CT0VfSElNQVg4Mjc5RCBpcyBub3Qgc2V0CiMgQ09ORklHX0RS TV9QQU5FTF9CT0VfVFYxMDFXVU1fTkw2IGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX0RT SV9DTSBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9QQU5FTF9MVkRTIGlzIG5vdCBzZXQKIyBDT05G SUdfRFJNX1BBTkVMX1NJTVBMRSBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9QQU5FTF9FTElEQV9L RDM1VDEzMyBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9QQU5FTF9GRUlYSU5fSzEwMV9JTTJCQTAy IGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX0ZFSVlBTkdfRlkwNzAyNERJMjZBMzBEIGlz IG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX0lMSVRFS19JTDkzMjIgaXMgbm90IHNldAojIENP TkZJR19EUk1fUEFORUxfSUxJVEVLX0lMSTkzNDEgaXMgbm90IHNldAojIENPTkZJR19EUk1fUEFO RUxfSUxJVEVLX0lMSTk4ODFDIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX0lOTk9MVVhf RUowMzBOQSBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9QQU5FTF9JTk5PTFVYX1AwNzlaQ0EgaXMg bm90IHNldApDT05GSUdfRFJNX1BBTkVMX0pESV9MVDA3ME1FMDUwMDA9bQojIENPTkZJR19EUk1f UEFORUxfS0hBREFTX1RTMDUwIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX0tJTkdESVNQ TEFZX0tEMDk3RDA0IGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX0xFQURURUtfTFRLMDUw SDMxNDZXIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX0xFQURURUtfTFRLNTAwSEQxODI5 IGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX1NBTVNVTkdfTEQ5MDQwIGlzIG5vdCBzZXQK IyBDT05GSUdfRFJNX1BBTkVMX0xHX0xCMDM1UTAyIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BB TkVMX0xHX0xHNDU3MyBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9QQU5FTF9ORUNfTkw4MDQ4SEwx MSBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9QQU5FTF9OT1ZBVEVLX05UMzU1MTAgaXMgbm90IHNl dAojIENPTkZJR19EUk1fUEFORUxfTk9WQVRFS19OVDM2NjcyQSBpcyBub3Qgc2V0CiMgQ09ORklH X0RSTV9QQU5FTF9OT1ZBVEVLX05UMzkwMTYgaXMgbm90IHNldAojIENPTkZJR19EUk1fUEFORUxf TUFOVElYX01MQUYwNTdXRTUxIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX09MSU1FWF9M Q0RfT0xJTlVYSU5PIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX09SSVNFVEVDSF9PVE04 MDA5QSBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9QQU5FTF9PU0RfT1NEMTAxVDI1ODdfNTNUUyBp cyBub3Qgc2V0CiMgQ09ORklHX0RSTV9QQU5FTF9QQU5BU09OSUNfVlZYMTBGMDM0TjAwIGlzIG5v dCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX1JBU1BCRVJSWVBJX1RPVUNIU0NSRUVOIGlzIG5vdCBz ZXQKIyBDT05GSUdfRFJNX1BBTkVMX1JBWURJVU1fUk02NzE5MSBpcyBub3Qgc2V0CiMgQ09ORklH X0RSTV9QQU5FTF9SQVlESVVNX1JNNjgyMDAgaXMgbm90IHNldAojIENPTkZJR19EUk1fUEFORUxf Uk9OQk9fUkIwNzBEMzAgaXMgbm90IHNldAojIENPTkZJR19EUk1fUEFORUxfU0FNU1VOR19BVE5B MzNYQzIwIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX1NBTVNVTkdfREI3NDMwIGlzIG5v dCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX1NBTVNVTkdfUzZEMTZEMCBpcyBub3Qgc2V0CiMgQ09O RklHX0RSTV9QQU5FTF9TQU1TVU5HX1M2RTNIQTIgaXMgbm90IHNldAojIENPTkZJR19EUk1fUEFO RUxfU0FNU1VOR19TNkU2M0owWDAzIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX1NBTVNV TkdfUzZFNjNNMCBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9QQU5FTF9TQU1TVU5HX1M2RTg4QTBf QU1TNDUyRUYwMSBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9QQU5FTF9TQU1TVU5HX1M2RThBQTAg aXMgbm90IHNldAojIENPTkZJR19EUk1fUEFORUxfU0FNU1VOR19TT0ZFRjAwIGlzIG5vdCBzZXQK IyBDT05GSUdfRFJNX1BBTkVMX1NFSUtPXzQzV1ZGMUcgaXMgbm90IHNldAojIENPTkZJR19EUk1f UEFORUxfU0hBUlBfTFExMDFSMVNYMDEgaXMgbm90IHNldAojIENPTkZJR19EUk1fUEFORUxfU0hB UlBfTFMwMzdWN0RXMDEgaXMgbm90IHNldAojIENPTkZJR19EUk1fUEFORUxfU0hBUlBfTFMwNDNU MUxFMDEgaXMgbm90IHNldAojIENPTkZJR19EUk1fUEFORUxfU0lUUk9OSVhfU1Q3NzAxIGlzIG5v dCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX1NJVFJPTklYX1NUNzcwMyBpcyBub3Qgc2V0CiMgQ09O RklHX0RSTV9QQU5FTF9TSVRST05JWF9TVDc3ODlWIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BB TkVMX1NPTllfQUNYNDI0QUtQIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX1NPTllfQUNY NTY1QUtNIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX1RET19UTDA3MFdTSDMwIGlzIG5v dCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX1RQT19URDAyOFRURUMxIGlzIG5vdCBzZXQKIyBDT05G SUdfRFJNX1BBTkVMX1RQT19URDA0M01URUExIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BBTkVM X1RQT19UUEcxMTAgaXMgbm90IHNldAojIENPTkZJR19EUk1fUEFORUxfVFJVTFlfTlQzNTU5N19X UVhHQSBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9QQU5FTF9WSVNJT05PWF9STTY5Mjk5IGlzIG5v dCBzZXQKIyBDT05GSUdfRFJNX1BBTkVMX1dJREVDSElQU19XUzI0MDEgaXMgbm90IHNldAojIENP TkZJR19EUk1fUEFORUxfWElOUEVOR19YUFAwNTVDMjcyIGlzIG5vdCBzZXQKIyBlbmQgb2YgRGlz cGxheSBQYW5lbHMKCkNPTkZJR19EUk1fQlJJREdFPXkKQ09ORklHX0RSTV9QQU5FTF9CUklER0U9 eQoKIwojIERpc3BsYXkgSW50ZXJmYWNlIEJyaWRnZXMKIwojIENPTkZJR19EUk1fQ0ROU19EU0kg aXMgbm90IHNldAojIENPTkZJR19EUk1fQ0hJUE9ORV9JQ042MjExIGlzIG5vdCBzZXQKIyBDT05G SUdfRFJNX0NIUk9OVEVMX0NINzAzMyBpcyBub3Qgc2V0CkNPTkZJR19EUk1fRElTUExBWV9DT05O RUNUT1I9bQojIENPTkZJR19EUk1fTE9OVElVTV9MVDg5MTJCIGlzIG5vdCBzZXQKIyBDT05GSUdf RFJNX0xPTlRJVU1fTFQ5NjExIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX0xPTlRJVU1fTFQ5NjEx VVhDIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX0lURV9JVDY2MTIxIGlzIG5vdCBzZXQKIyBDT05G SUdfRFJNX0xWRFNfQ09ERUMgaXMgbm90IHNldAojIENPTkZJR19EUk1fTUVHQUNISVBTX1NURFBY WFhYX0dFX0I4NTBWM19GVyBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9OV0xfTUlQSV9EU0kgaXMg bm90IHNldAojIENPTkZJR19EUk1fTlhQX1BUTjM0NjAgaXMgbm90IHNldAojIENPTkZJR19EUk1f UEFSQURFX1BTODYyMiBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9QQVJBREVfUFM4NjQwIGlzIG5v dCBzZXQKIyBDT05GSUdfRFJNX1NJTF9TSUk4NjIwIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1NJ STkwMlggaXMgbm90IHNldAojIENPTkZJR19EUk1fU0lJOTIzNCBpcyBub3Qgc2V0CkNPTkZJR19E Uk1fU0lNUExFX0JSSURHRT1tCiMgQ09ORklHX0RSTV9USElORV9USEM2M0xWRDEwMjQgaXMgbm90 IHNldAojIENPTkZJR19EUk1fVE9TSElCQV9UQzM1ODc2MiBpcyBub3Qgc2V0CiMgQ09ORklHX0RS TV9UT1NISUJBX1RDMzU4NzY0IGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1RPU0hJQkFfVEMzNTg3 NjcgaXMgbm90IHNldAojIENPTkZJR19EUk1fVE9TSElCQV9UQzM1ODc2OCBpcyBub3Qgc2V0CiMg Q09ORklHX0RSTV9UT1NISUJBX1RDMzU4Nzc1IGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1RJX1RG UDQxMCBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9USV9TTjY1RFNJODMgaXMgbm90IHNldAojIENP TkZJR19EUk1fVElfU042NURTSTg2IGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1RJX1RQRDEyUzAx NSBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9BTkFMT0dJWF9BTlg2MzQ1IGlzIG5vdCBzZXQKIyBD T05GSUdfRFJNX0FOQUxPR0lYX0FOWDc4WFggaXMgbm90IHNldAojIENPTkZJR19EUk1fQU5BTE9H SVhfQU5YNzYyNSBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9JMkNfQURWNzUxMSBpcyBub3Qgc2V0 CiMgQ09ORklHX0RSTV9DRE5TX01IRFA4NTQ2IGlzIG5vdCBzZXQKIyBlbmQgb2YgRGlzcGxheSBJ bnRlcmZhY2UgQnJpZGdlcwoKQ09ORklHX0RSTV9WQzQ9bQpDT05GSUdfRFJNX1ZDNF9IRE1JX0NF Qz15CiMgQ09ORklHX0RSTV9FVE5BVklWIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX0hJU0lfSElC TUMgaXMgbm90IHNldAojIENPTkZJR19EUk1fSElTSV9LSVJJTiBpcyBub3Qgc2V0CiMgQ09ORklH X0RSTV9NWFNGQiBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9BUkNQR1UgaXMgbm90IHNldAojIENP TkZJR19EUk1fQk9DSFMgaXMgbm90IHNldAojIENPTkZJR19EUk1fQ0lSUlVTX1FFTVUgaXMgbm90 IHNldAojIENPTkZJR19EUk1fR00xMlUzMjAgaXMgbm90IHNldAojIENPTkZJR19EUk1fU0lNUExF RFJNIGlzIG5vdCBzZXQKIyBDT05GSUdfVElOWURSTV9IWDgzNTdEIGlzIG5vdCBzZXQKIyBDT05G SUdfVElOWURSTV9JTEk5MjI1IGlzIG5vdCBzZXQKIyBDT05GSUdfVElOWURSTV9JTEk5MzQxIGlz IG5vdCBzZXQKIyBDT05GSUdfVElOWURSTV9JTEk5NDg2IGlzIG5vdCBzZXQKIyBDT05GSUdfVElO WURSTV9NSTAyODNRVCBpcyBub3Qgc2V0CiMgQ09ORklHX1RJTllEUk1fUkVQQVBFUiBpcyBub3Qg c2V0CiMgQ09ORklHX1RJTllEUk1fU1Q3NTg2IGlzIG5vdCBzZXQKIyBDT05GSUdfVElOWURSTV9T VDc3MzVSIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1BMMTExIGlzIG5vdCBzZXQKQ09ORklHX0RS TV9YRU49eQpDT05GSUdfRFJNX1hFTl9GUk9OVEVORD15CiMgQ09ORklHX0RSTV9MSU1BIGlzIG5v dCBzZXQKIyBDT05GSUdfRFJNX1BBTkZST1NUIGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX1RJRFNT IGlzIG5vdCBzZXQKIyBDT05GSUdfRFJNX0dVRCBpcyBub3Qgc2V0CiMgQ09ORklHX0RSTV9MRUdB Q1kgaXMgbm90IHNldApDT05GSUdfRFJNX1BBTkVMX09SSUVOVEFUSU9OX1FVSVJLUz15CgojCiMg RnJhbWUgYnVmZmVyIERldmljZXMKIwpDT05GSUdfRkJfQ01ETElORT15CkNPTkZJR19GQl9OT1RJ Rlk9eQpDT05GSUdfRkI9eQojIENPTkZJR19GSVJNV0FSRV9FRElEIGlzIG5vdCBzZXQKQ09ORklH X0ZCX0NGQl9GSUxMUkVDVD15CkNPTkZJR19GQl9DRkJfQ09QWUFSRUE9eQpDT05GSUdfRkJfQ0ZC X0lNQUdFQkxJVD15CkNPTkZJR19GQl9TWVNfRklMTFJFQ1Q9eQpDT05GSUdfRkJfU1lTX0NPUFlB UkVBPXkKQ09ORklHX0ZCX1NZU19JTUFHRUJMSVQ9eQojIENPTkZJR19GQl9GT1JFSUdOX0VORElB TiBpcyBub3Qgc2V0CkNPTkZJR19GQl9TWVNfRk9QUz15CkNPTkZJR19GQl9ERUZFUlJFRF9JTz15 CkNPTkZJR19GQl9CQUNLTElHSFQ9bQpDT05GSUdfRkJfTU9ERV9IRUxQRVJTPXkKIyBDT05GSUdf RkJfVElMRUJMSVRUSU5HIGlzIG5vdCBzZXQKCiMKIyBGcmFtZSBidWZmZXIgaGFyZHdhcmUgZHJp dmVycwojCiMgQ09ORklHX0ZCX0NJUlJVUyBpcyBub3Qgc2V0CiMgQ09ORklHX0ZCX1BNMiBpcyBu b3Qgc2V0CiMgQ09ORklHX0ZCX0FSTUNMQ0QgaXMgbm90IHNldAojIENPTkZJR19GQl9DWUJFUjIw MDAgaXMgbm90IHNldAojIENPTkZJR19GQl9BU0lMSUFOVCBpcyBub3Qgc2V0CiMgQ09ORklHX0ZC X0lNU1RUIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfRUZJIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJf T1BFTkNPUkVTIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfUzFEMTNYWFggaXMgbm90IHNldAojIENP TkZJR19GQl9OVklESUEgaXMgbm90IHNldAojIENPTkZJR19GQl9SSVZBIGlzIG5vdCBzZXQKIyBD T05GSUdfRkJfSTc0MCBpcyBub3Qgc2V0CiMgQ09ORklHX0ZCX01BVFJPWCBpcyBub3Qgc2V0CiMg Q09ORklHX0ZCX1JBREVPTiBpcyBub3Qgc2V0CiMgQ09ORklHX0ZCX0FUWTEyOCBpcyBub3Qgc2V0 CiMgQ09ORklHX0ZCX0FUWSBpcyBub3Qgc2V0CiMgQ09ORklHX0ZCX1MzIGlzIG5vdCBzZXQKIyBD T05GSUdfRkJfU0FWQUdFIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfU0lTIGlzIG5vdCBzZXQKIyBD T05GSUdfRkJfTkVPTUFHSUMgaXMgbm90IHNldAojIENPTkZJR19GQl9LWVJPIGlzIG5vdCBzZXQK IyBDT05GSUdfRkJfM0RGWCBpcyBub3Qgc2V0CiMgQ09ORklHX0ZCX1ZPT0RPTzEgaXMgbm90IHNl dAojIENPTkZJR19GQl9WVDg2MjMgaXMgbm90IHNldAojIENPTkZJR19GQl9UUklERU5UIGlzIG5v dCBzZXQKIyBDT05GSUdfRkJfQVJLIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfUE0zIGlzIG5vdCBz ZXQKIyBDT05GSUdfRkJfQ0FSTUlORSBpcyBub3Qgc2V0CiMgQ09ORklHX0ZCX1NNU0NVRlggaXMg bm90IHNldApDT05GSUdfRkJfVURMPW0KIyBDT05GSUdfRkJfSUJNX0dYVDQ1MDAgaXMgbm90IHNl dAojIENPTkZJR19GQl9WSVJUVUFMIGlzIG5vdCBzZXQKQ09ORklHX1hFTl9GQkRFVl9GUk9OVEVO RD15CiMgQ09ORklHX0ZCX01FVFJPTk9NRSBpcyBub3Qgc2V0CiMgQ09ORklHX0ZCX01CODYyWFgg aXMgbm90IHNldApDT05GSUdfRkJfU0lNUExFPXkKQ09ORklHX0ZCX1NTRDEzMDc9bQojIENPTkZJ R19GQl9TTTcxMiBpcyBub3Qgc2V0CiMgZW5kIG9mIEZyYW1lIGJ1ZmZlciBEZXZpY2VzCgojCiMg QmFja2xpZ2h0ICYgTENEIGRldmljZSBzdXBwb3J0CiMKIyBDT05GSUdfTENEX0NMQVNTX0RFVklD RSBpcyBub3Qgc2V0CkNPTkZJR19CQUNLTElHSFRfQ0xBU1NfREVWSUNFPW0KIyBDT05GSUdfQkFD S0xJR0hUX0tURDI1MyBpcyBub3Qgc2V0CiMgQ09ORklHX0JBQ0tMSUdIVF9QV00gaXMgbm90IHNl dAojIENPTkZJR19CQUNLTElHSFRfUUNPTV9XTEVEIGlzIG5vdCBzZXQKIyBDT05GSUdfQkFDS0xJ R0hUX0FEUDg4NjAgaXMgbm90IHNldAojIENPTkZJR19CQUNLTElHSFRfQURQODg3MCBpcyBub3Qg c2V0CiMgQ09ORklHX0JBQ0tMSUdIVF9MTTM2MzBBIGlzIG5vdCBzZXQKIyBDT05GSUdfQkFDS0xJ R0hUX0xNMzYzOSBpcyBub3Qgc2V0CiMgQ09ORklHX0JBQ0tMSUdIVF9MUDg1NVggaXMgbm90IHNl dAojIENPTkZJR19CQUNLTElHSFRfR1BJTyBpcyBub3Qgc2V0CiMgQ09ORklHX0JBQ0tMSUdIVF9M VjUyMDdMUCBpcyBub3Qgc2V0CiMgQ09ORklHX0JBQ0tMSUdIVF9CRDYxMDcgaXMgbm90IHNldAoj IENPTkZJR19CQUNLTElHSFRfQVJDWENOTiBpcyBub3Qgc2V0CiMgQ09ORklHX0JBQ0tMSUdIVF9M RUQgaXMgbm90IHNldAojIGVuZCBvZiBCYWNrbGlnaHQgJiBMQ0QgZGV2aWNlIHN1cHBvcnQKCkNP TkZJR19WSURFT01PREVfSEVMUEVSUz15CkNPTkZJR19IRE1JPXkKCiMKIyBDb25zb2xlIGRpc3Bs YXkgZHJpdmVyIHN1cHBvcnQKIwpDT05GSUdfRFVNTVlfQ09OU09MRT15CkNPTkZJR19EVU1NWV9D T05TT0xFX0NPTFVNTlM9ODAKQ09ORklHX0RVTU1ZX0NPTlNPTEVfUk9XUz0yNQpDT05GSUdfRlJB TUVCVUZGRVJfQ09OU09MRT15CkNPTkZJR19GUkFNRUJVRkZFUl9DT05TT0xFX0xFR0FDWV9BQ0NF TEVSQVRJT049eQpDT05GSUdfRlJBTUVCVUZGRVJfQ09OU09MRV9ERVRFQ1RfUFJJTUFSWT15CkNP TkZJR19GUkFNRUJVRkZFUl9DT05TT0xFX1JPVEFUSU9OPXkKQ09ORklHX0ZSQU1FQlVGRkVSX0NP TlNPTEVfREVGRVJSRURfVEFLRU9WRVI9eQojIGVuZCBvZiBDb25zb2xlIGRpc3BsYXkgZHJpdmVy IHN1cHBvcnQKCiMgQ09ORklHX0xPR08gaXMgbm90IHNldAojIGVuZCBvZiBHcmFwaGljcyBzdXBw b3J0CgpDT05GSUdfU09VTkQ9eQpDT05GSUdfU05EPW0KQ09ORklHX1NORF9USU1FUj1tCkNPTkZJ R19TTkRfUENNPW0KQ09ORklHX1NORF9QQ01fRUxEPXkKQ09ORklHX1NORF9QQ01fSUVDOTU4PXkK Q09ORklHX1NORF9ETUFFTkdJTkVfUENNPW0KQ09ORklHX1NORF9IV0RFUD1tCkNPTkZJR19TTkRf U0VRX0RFVklDRT1tCkNPTkZJR19TTkRfUkFXTUlEST1tCkNPTkZJR19TTkRfSkFDSz15CkNPTkZJ R19TTkRfSkFDS19JTlBVVF9ERVY9eQojIENPTkZJR19TTkRfT1NTRU1VTCBpcyBub3Qgc2V0CkNP TkZJR19TTkRfUENNX1RJTUVSPXkKQ09ORklHX1NORF9IUlRJTUVSPW0KIyBDT05GSUdfU05EX0RZ TkFNSUNfTUlOT1JTIGlzIG5vdCBzZXQKQ09ORklHX1NORF9TVVBQT1JUX09MRF9BUEk9eQpDT05G SUdfU05EX1BST0NfRlM9eQpDT05GSUdfU05EX1ZFUkJPU0VfUFJPQ0ZTPXkKIyBDT05GSUdfU05E X1ZFUkJPU0VfUFJJTlRLIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX0RFQlVHIGlzIG5vdCBzZXQK Q09ORklHX1NORF9WTUFTVEVSPXkKQ09ORklHX1NORF9TRVFVRU5DRVI9bQpDT05GSUdfU05EX1NF UV9EVU1NWT1tCkNPTkZJR19TTkRfU0VRX0hSVElNRVJfREVGQVVMVD15CkNPTkZJR19TTkRfU0VR X01JRElfRVZFTlQ9bQpDT05GSUdfU05EX1NFUV9NSURJPW0KQ09ORklHX1NORF9TRVFfVklSTUlE ST1tCkNPTkZJR19TTkRfTVBVNDAxX1VBUlQ9bQpDT05GSUdfU05EX0RSSVZFUlM9eQpDT05GSUdf U05EX0RVTU1ZPW0KQ09ORklHX1NORF9BTE9PUD1tCkNPTkZJR19TTkRfVklSTUlEST1tCkNPTkZJ R19TTkRfTVRQQVY9bQojIENPTkZJR19TTkRfU0VSSUFMX1UxNjU1MCBpcyBub3Qgc2V0CkNPTkZJ R19TTkRfTVBVNDAxPW0KQ09ORklHX1NORF9QQ0k9eQojIENPTkZJR19TTkRfQUQxODg5IGlzIG5v dCBzZXQKIyBDT05GSUdfU05EX0FMUzMwMCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9BTEk1NDUx IGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX0FUSUlYUCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9B VElJWFBfTU9ERU0gaXMgbm90IHNldAojIENPTkZJR19TTkRfQVU4ODEwIGlzIG5vdCBzZXQKIyBD T05GSUdfU05EX0FVODgyMCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9BVTg4MzAgaXMgbm90IHNl dAojIENPTkZJR19TTkRfQVcyIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX0FaVDMzMjggaXMgbm90 IHNldAojIENPTkZJR19TTkRfQlQ4N1ggaXMgbm90IHNldAojIENPTkZJR19TTkRfQ0EwMTA2IGlz IG5vdCBzZXQKIyBDT05GSUdfU05EX0NNSVBDSSBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9PWFlH RU4gaXMgbm90IHNldAojIENPTkZJR19TTkRfQ1M0MjgxIGlzIG5vdCBzZXQKIyBDT05GSUdfU05E X0NTNDZYWCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9DVFhGSSBpcyBub3Qgc2V0CiMgQ09ORklH X1NORF9EQVJMQTIwIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX0dJTkEyMCBpcyBub3Qgc2V0CiMg Q09ORklHX1NORF9MQVlMQTIwIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX0RBUkxBMjQgaXMgbm90 IHNldAojIENPTkZJR19TTkRfR0lOQTI0IGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX0xBWUxBMjQg aXMgbm90IHNldAojIENPTkZJR19TTkRfTU9OQSBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9NSUEg aXMgbm90IHNldAojIENPTkZJR19TTkRfRUNITzNHIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX0lO RElHTyBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9JTkRJR09JTyBpcyBub3Qgc2V0CiMgQ09ORklH X1NORF9JTkRJR09ESiBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9JTkRJR09JT1ggaXMgbm90IHNl dAojIENPTkZJR19TTkRfSU5ESUdPREpYIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX0VNVTEwSzEg aXMgbm90IHNldAojIENPTkZJR19TTkRfRU1VMTBLMVggaXMgbm90IHNldAojIENPTkZJR19TTkRf RU5TMTM3MCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9FTlMxMzcxIGlzIG5vdCBzZXQKIyBDT05G SUdfU05EX0VTMTkzOCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9FUzE5NjggaXMgbm90IHNldAoj IENPTkZJR19TTkRfRk04MDEgaXMgbm90IHNldAojIENPTkZJR19TTkRfSERTUCBpcyBub3Qgc2V0 CiMgQ09ORklHX1NORF9IRFNQTSBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9JQ0UxNzEyIGlzIG5v dCBzZXQKIyBDT05GSUdfU05EX0lDRTE3MjQgaXMgbm90IHNldAojIENPTkZJR19TTkRfSU5URUw4 WDAgaXMgbm90IHNldAojIENPTkZJR19TTkRfSU5URUw4WDBNIGlzIG5vdCBzZXQKIyBDT05GSUdf U05EX0tPUkcxMjEyIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX0xPTEEgaXMgbm90IHNldAojIENP TkZJR19TTkRfTFg2NDY0RVMgaXMgbm90IHNldAojIENPTkZJR19TTkRfTUFFU1RSTzMgaXMgbm90 IHNldAojIENPTkZJR19TTkRfTUlYQVJUIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX05NMjU2IGlz IG5vdCBzZXQKIyBDT05GSUdfU05EX1BDWEhSIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1JJUFRJ REUgaXMgbm90IHNldAojIENPTkZJR19TTkRfUk1FMzIgaXMgbm90IHNldAojIENPTkZJR19TTkRf Uk1FOTYgaXMgbm90IHNldAojIENPTkZJR19TTkRfUk1FOTY1MiBpcyBub3Qgc2V0CiMgQ09ORklH X1NORF9TRTZYIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPTklDVklCRVMgaXMgbm90IHNldAoj IENPTkZJR19TTkRfVFJJREVOVCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9WSUE4MlhYIGlzIG5v dCBzZXQKIyBDT05GSUdfU05EX1ZJQTgyWFhfTU9ERU0gaXMgbm90IHNldAojIENPTkZJR19TTkRf VklSVFVPU08gaXMgbm90IHNldAojIENPTkZJR19TTkRfVlgyMjIgaXMgbm90IHNldAojIENPTkZJ R19TTkRfWU1GUENJIGlzIG5vdCBzZXQKCiMKIyBIRC1BdWRpbwojCiMgQ09ORklHX1NORF9IREFf SU5URUwgaXMgbm90IHNldAojIGVuZCBvZiBIRC1BdWRpbwoKQ09ORklHX1NORF9IREFfUFJFQUxM T0NfU0laRT02NApDT05GSUdfU05EX1NQST15CkNPTkZJR19TTkRfVVNCPXkKQ09ORklHX1NORF9V U0JfQVVESU89bQpDT05GSUdfU05EX1VTQl9BVURJT19VU0VfTUVESUFfQ09OVFJPTExFUj15CkNP TkZJR19TTkRfVVNCX1VBMTAxPW0KQ09ORklHX1NORF9VU0JfQ0FJQVE9bQpDT05GSUdfU05EX1VT Ql9DQUlBUV9JTlBVVD15CkNPTkZJR19TTkRfVVNCXzZGSVJFPW0KIyBDT05GSUdfU05EX1VTQl9I SUZBQ0UgaXMgbm90IHNldAojIENPTkZJR19TTkRfQkNEMjAwMCBpcyBub3Qgc2V0CiMgQ09ORklH X1NORF9VU0JfUE9EIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1VTQl9QT0RIRCBpcyBub3Qgc2V0 CiMgQ09ORklHX1NORF9VU0JfVE9ORVBPUlQgaXMgbm90IHNldAojIENPTkZJR19TTkRfVVNCX1ZB UklBWCBpcyBub3Qgc2V0CkNPTkZJR19TTkRfU09DPW0KQ09ORklHX1NORF9TT0NfR0VORVJJQ19E TUFFTkdJTkVfUENNPXkKIyBDT05GSUdfU05EX1NPQ19BREkgaXMgbm90IHNldAojIENPTkZJR19T TkRfU09DX0FNRF9BQ1AgaXMgbm90IHNldAojIENPTkZJR19TTkRfQVRNRUxfU09DIGlzIG5vdCBz ZXQKQ09ORklHX1NORF9CQ00yODM1X1NPQ19JMlM9bQojIENPTkZJR19TTkRfQkNNNjNYWF9JMlNf V0hJU1RMRVIgaXMgbm90IHNldAojIENPTkZJR19TTkRfREVTSUdOV0FSRV9JMlMgaXMgbm90IHNl dAoKIwojIFNvQyBBdWRpbyBmb3IgRnJlZXNjYWxlIENQVXMKIwoKIwojIENvbW1vbiBTb0MgQXVk aW8gb3B0aW9ucyBmb3IgRnJlZXNjYWxlIENQVXM6CiMKIyBDT05GSUdfU05EX1NPQ19GU0xfQVNS QyBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfRlNMX1NBSSBpcyBub3Qgc2V0CiMgQ09ORklH X1NORF9TT0NfRlNMX0FVRE1JWCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfRlNMX1NTSSBp cyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfRlNMX1NQRElGIGlzIG5vdCBzZXQKIyBDT05GSUdf U05EX1NPQ19GU0xfRVNBSSBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfRlNMX01JQ0ZJTCBp cyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfRlNMX1hDVlIgaXMgbm90IHNldAojIENPTkZJR19T TkRfU09DX0lNWF9BVURNVVggaXMgbm90IHNldAojIGVuZCBvZiBTb0MgQXVkaW8gZm9yIEZyZWVz Y2FsZSBDUFVzCgojIENPTkZJR19TTkRfSTJTX0hJNjIxMF9JMlMgaXMgbm90IHNldAojIENPTkZJ R19TTkRfU09DX0lNRyBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfTVRLX0JUQ1ZTRCBpcyBu b3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfU09GX1RPUExFVkVMIGlzIG5vdCBzZXQKCiMKIyBTVE1p Y3JvZWxlY3Ryb25pY3MgU1RNMzIgU09DIGF1ZGlvIHN1cHBvcnQKIwojIGVuZCBvZiBTVE1pY3Jv ZWxlY3Ryb25pY3MgU1RNMzIgU09DIGF1ZGlvIHN1cHBvcnQKCiMgQ09ORklHX1NORF9TT0NfWElM SU5YX0kyUyBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfWElMSU5YX0FVRElPX0ZPUk1BVFRF UiBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfWElMSU5YX1NQRElGIGlzIG5vdCBzZXQKIyBD T05GSUdfU05EX1NPQ19YVEZQR0FfSTJTIGlzIG5vdCBzZXQKQ09ORklHX1NORF9TT0NfSTJDX0FO RF9TUEk9bQoKIwojIENPREVDIGRyaXZlcnMKIwojIENPTkZJR19TTkRfU09DX0FDOTdfQ09ERUMg aXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX0FEQVUxMzcyX0kyQyBpcyBub3Qgc2V0CiMgQ09O RklHX1NORF9TT0NfQURBVTEzNzJfU1BJIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19BREFV MTcwMSBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfQURBVTE3NjFfSTJDIGlzIG5vdCBzZXQK IyBDT05GSUdfU05EX1NPQ19BREFVMTc2MV9TUEkgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09D X0FEQVU3MDAyIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19BREFVNzExOF9IVyBpcyBub3Qg c2V0CiMgQ09ORklHX1NORF9TT0NfQURBVTcxMThfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfU05E X1NPQ19BSzQxMDQgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX0FLNDExOCBpcyBub3Qgc2V0 CiMgQ09ORklHX1NORF9TT0NfQUs0NDU4IGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19BSzQ1 NTQgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX0FLNDYxMyBpcyBub3Qgc2V0CiMgQ09ORklH X1NORF9TT0NfQUs0NjQyIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19BSzUzODYgaXMgbm90 IHNldAojIENPTkZJR19TTkRfU09DX0FLNTU1OCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0Nf QUxDNTYyMyBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfQkQyODYyMyBpcyBub3Qgc2V0CiMg Q09ORklHX1NORF9TT0NfQlRfU0NPIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19DUzM1TDMy IGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19DUzM1TDMzIGlzIG5vdCBzZXQKIyBDT05GSUdf U05EX1NPQ19DUzM1TDM0IGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19DUzM1TDM1IGlzIG5v dCBzZXQKIyBDT05GSUdfU05EX1NPQ19DUzM1TDM2IGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NP Q19DUzQyTDQyIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19DUzQyTDUxX0kyQyBpcyBub3Qg c2V0CiMgQ09ORklHX1NORF9TT0NfQ1M0Mkw1MiBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0Nf Q1M0Mkw1NiBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfQ1M0Mkw3MyBpcyBub3Qgc2V0CiMg Q09ORklHX1NORF9TT0NfQ1M0MjM0IGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19DUzQyNjUg aXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX0NTNDI3MCBpcyBub3Qgc2V0CkNPTkZJR19TTkRf U09DX0NTNDI3MT1tCkNPTkZJR19TTkRfU09DX0NTNDI3MV9JMkM9bQojIENPTkZJR19TTkRfU09D X0NTNDI3MV9TUEkgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX0NTNDJYWDhfSTJDIGlzIG5v dCBzZXQKIyBDT05GSUdfU05EX1NPQ19DUzQzMTMwIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NP Q19DUzQzNDEgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX0NTNDM0OSBpcyBub3Qgc2V0CiMg Q09ORklHX1NORF9TT0NfQ1M1M0wzMCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfQ1gyMDcy WCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfREE3MjEzIGlzIG5vdCBzZXQKIyBDT05GSUdf U05EX1NPQ19ETUlDIGlzIG5vdCBzZXQKQ09ORklHX1NORF9TT0NfSERNSV9DT0RFQz1tCiMgQ09O RklHX1NORF9TT0NfRVM3MTM0IGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19FUzcyNDEgaXMg bm90IHNldAojIENPTkZJR19TTkRfU09DX0VTODMxNiBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9T T0NfRVM4MzI4X0kyQyBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfRVM4MzI4X1NQSSBpcyBu b3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfR1RNNjAxIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NP Q19JQ1M0MzQzMiBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfSU5OT19SSzMwMzYgaXMgbm90 IHNldAojIENPTkZJR19TTkRfU09DX01BWDk4MDg4IGlzIG5vdCBzZXQKQ09ORklHX1NORF9TT0Nf TUFYOTgzNTdBPW0KIyBDT05GSUdfU05EX1NPQ19NQVg5ODUwNCBpcyBub3Qgc2V0CiMgQ09ORklH X1NORF9TT0NfTUFYOTg2NyBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfTUFYOTg5MjcgaXMg bm90IHNldAojIENPTkZJR19TTkRfU09DX01BWDk4MzczX0kyQyBpcyBub3Qgc2V0CiMgQ09ORklH X1NORF9TT0NfTUFYOTgzOTAgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX01BWDk4NjAgaXMg bm90IHNldAojIENPTkZJR19TTkRfU09DX01TTTg5MTZfV0NEX0RJR0lUQUwgaXMgbm90IHNldAoj IENPTkZJR19TTkRfU09DX1BDTTE2ODEgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX1BDTTE3 ODlfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19QQ00xNzlYX0kyQyBpcyBub3Qgc2V0 CiMgQ09ORklHX1NORF9TT0NfUENNMTc5WF9TUEkgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09D X1BDTTE4NlhfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19QQ00xODZYX1NQSSBpcyBu b3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfUENNMzA2MF9JMkMgaXMgbm90IHNldAojIENPTkZJR19T TkRfU09DX1BDTTMwNjBfU1BJIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19QQ00zMTY4QV9J MkMgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX1BDTTMxNjhBX1NQSSBpcyBub3Qgc2V0CiMg Q09ORklHX1NORF9TT0NfUENNNTEwMkEgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX1BDTTUx MnhfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19QQ001MTJ4X1NQSSBpcyBub3Qgc2V0 CiMgQ09ORklHX1NORF9TT0NfUkszMzI4IGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19SVDU2 MTYgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX1JUNTYzMSBpcyBub3Qgc2V0CiMgQ09ORklH X1NORF9TT0NfUlQ1NjQwIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19SVDU2NTkgaXMgbm90 IHNldAojIENPTkZJR19TTkRfU09DX1NHVEw1MDAwIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NP Q19TSU1QTEVfQU1QTElGSUVSIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19TSU1QTEVfTVVY IGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19TUERJRiBpcyBub3Qgc2V0CiMgQ09ORklHX1NO RF9TT0NfU1NNMjMwNSBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfU1NNMjUxOCBpcyBub3Qg c2V0CiMgQ09ORklHX1NORF9TT0NfU1NNMjYwMl9TUEkgaXMgbm90IHNldAojIENPTkZJR19TTkRf U09DX1NTTTI2MDJfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19TU000NTY3IGlzIG5v dCBzZXQKIyBDT05GSUdfU05EX1NPQ19TVEEzMlggaXMgbm90IHNldAojIENPTkZJR19TTkRfU09D X1NUQTM1MCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfU1RJX1NBUyBpcyBub3Qgc2V0CiMg Q09ORklHX1NORF9TT0NfVEFTMjU1MiBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfVEFTMjU2 MiBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfVEFTMjc2NCBpcyBub3Qgc2V0CiMgQ09ORklH X1NORF9TT0NfVEFTMjc3MCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfVEFTNTA4NiBpcyBu b3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfVEFTNTcxWCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9T T0NfVEFTNTcyMCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfVEFTNjQyNCBpcyBub3Qgc2V0 CiMgQ09ORklHX1NORF9TT0NfVERBNzQxOSBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfVEZB OTg3OSBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfVEZBOTg5WCBpcyBub3Qgc2V0CiMgQ09O RklHX1NORF9TT0NfVExWMzIwQUlDMjNfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19U TFYzMjBBSUMyM19TUEkgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX1RMVjMyMEFJQzMxWFgg aXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX1RMVjMyMEFJQzMyWDRfSTJDIGlzIG5vdCBzZXQK IyBDT05GSUdfU05EX1NPQ19UTFYzMjBBSUMzMlg0X1NQSSBpcyBub3Qgc2V0CiMgQ09ORklHX1NO RF9TT0NfVExWMzIwQUlDM1hfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19UTFYzMjBB SUMzWF9TUEkgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX1RMVjMyMEFEQ1gxNDAgaXMgbm90 IHNldAojIENPTkZJR19TTkRfU09DX1RTM0EyMjdFIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NP Q19UU0NTNDJYWCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfVFNDUzQ1NCBpcyBub3Qgc2V0 CiMgQ09ORklHX1NORF9TT0NfVURBMTMzNCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfV004 NTEwIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19XTTg1MjMgaXMgbm90IHNldAojIENPTkZJ R19TTkRfU09DX1dNODUyNCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfV004NTgwIGlzIG5v dCBzZXQKIyBDT05GSUdfU05EX1NPQ19XTTg3MTEgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09D X1dNODcyOCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfV004NzMxIGlzIG5vdCBzZXQKIyBD T05GSUdfU05EX1NPQ19XTTg3MzcgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX1dNODc0MSBp cyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfV004NzUwIGlzIG5vdCBzZXQKIyBDT05GSUdfU05E X1NPQ19XTTg3NTMgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX1dNODc3MCBpcyBub3Qgc2V0 CiMgQ09ORklHX1NORF9TT0NfV004Nzc2IGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19XTTg3 ODIgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX1dNODgwNF9JMkMgaXMgbm90IHNldAojIENP TkZJR19TTkRfU09DX1dNODgwNF9TUEkgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX1dNODkw MyBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfV004OTA0IGlzIG5vdCBzZXQKQ09ORklHX1NO RF9TT0NfV004OTYwPW0KIyBDT05GSUdfU05EX1NPQ19XTTg5NjIgaXMgbm90IHNldAojIENPTkZJ R19TTkRfU09DX1dNODk3NCBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfV004OTc4IGlzIG5v dCBzZXQKIyBDT05GSUdfU05EX1NPQ19XTTg5ODUgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09D X1pMMzgwNjAgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX01BWDk3NTkgaXMgbm90IHNldAoj IENPTkZJR19TTkRfU09DX01UNjM1MSBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfTVQ2MzU4 IGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19NVDY2NjAgaXMgbm90IHNldAojIENPTkZJR19T TkRfU09DX05BVTgzMTUgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX05BVTg1NDAgaXMgbm90 IHNldAojIENPTkZJR19TTkRfU09DX05BVTg4MTAgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09D X05BVTg4MjIgaXMgbm90IHNldAojIENPTkZJR19TTkRfU09DX05BVTg4MjQgaXMgbm90IHNldAoj IENPTkZJR19TTkRfU09DX1RQQTYxMzBBMiBpcyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfTFBB U1NfV1NBX01BQ1JPIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX1NPQ19MUEFTU19WQV9NQUNSTyBp cyBub3Qgc2V0CiMgQ09ORklHX1NORF9TT0NfTFBBU1NfUlhfTUFDUk8gaXMgbm90IHNldAojIENP TkZJR19TTkRfU09DX0xQQVNTX1RYX01BQ1JPIGlzIG5vdCBzZXQKIyBlbmQgb2YgQ09ERUMgZHJp dmVycwoKIyBDT05GSUdfU05EX1NJTVBMRV9DQVJEIGlzIG5vdCBzZXQKIyBDT05GSUdfU05EX0FV RElPX0dSQVBIX0NBUkQgaXMgbm90IHNldApDT05GSUdfU05EX1hFTl9GUk9OVEVORD1tCkNPTkZJ R19TTkRfVklSVElPPW0KCiMKIyBISUQgc3VwcG9ydAojCkNPTkZJR19ISUQ9eQojIENPTkZJR19I SURfQkFUVEVSWV9TVFJFTkdUSCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRFJBVyBpcyBub3Qgc2V0 CiMgQ09ORklHX1VISUQgaXMgbm90IHNldApDT05GSUdfSElEX0dFTkVSSUM9eQoKIwojIFNwZWNp YWwgSElEIGRyaXZlcnMKIwojIENPTkZJR19ISURfQTRURUNIIGlzIG5vdCBzZXQKIyBDT05GSUdf SElEX0FDQ1VUT1VDSCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9BQ1JVWCBpcyBub3Qgc2V0CiMg Q09ORklHX0hJRF9BUFBMRSBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9BUFBMRUlSIGlzIG5vdCBz ZXQKIyBDT05GSUdfSElEX0FTVVMgaXMgbm90IHNldAojIENPTkZJR19ISURfQVVSRUFMIGlzIG5v dCBzZXQKIyBDT05GSUdfSElEX0JFTEtJTiBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9CRVRPUF9G RiBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9CSUdCRU5fRkYgaXMgbm90IHNldAojIENPTkZJR19I SURfQ0hFUlJZIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX0NISUNPTlkgaXMgbm90IHNldAojIENP TkZJR19ISURfQ09SU0FJUiBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9DT1VHQVIgaXMgbm90IHNl dAojIENPTkZJR19ISURfTUFDQUxMWSBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9QUk9ESUtFWVMg aXMgbm90IHNldAojIENPTkZJR19ISURfQ01FRElBIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX0NS RUFUSVZFX1NCMDU0MCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9DWVBSRVNTIGlzIG5vdCBzZXQK IyBDT05GSUdfSElEX0RSQUdPTlJJU0UgaXMgbm90IHNldAojIENPTkZJR19ISURfRU1TX0ZGIGlz IG5vdCBzZXQKIyBDT05GSUdfSElEX0VMQU4gaXMgbm90IHNldAojIENPTkZJR19ISURfRUxFQ09N IGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX0VMTyBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9FWktF WSBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9HRU1CSVJEIGlzIG5vdCBzZXQKIyBDT05GSUdfSElE X0dGUk0gaXMgbm90IHNldAojIENPTkZJR19ISURfR0xPUklPVVMgaXMgbm90IHNldAojIENPTkZJ R19ISURfSE9MVEVLIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX1ZJVkFMREkgaXMgbm90IHNldAoj IENPTkZJR19ISURfR1Q2ODNSIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX0tFWVRPVUNIIGlzIG5v dCBzZXQKIyBDT05GSUdfSElEX0tZRSBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9VQ0xPR0lDIGlz IG5vdCBzZXQKIyBDT05GSUdfSElEX1dBTFRPUCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9WSUVX U09OSUMgaXMgbm90IHNldAojIENPTkZJR19ISURfR1lSQVRJT04gaXMgbm90IHNldAojIENPTkZJ R19ISURfSUNBREUgaXMgbm90IHNldAojIENPTkZJR19ISURfSVRFIGlzIG5vdCBzZXQKIyBDT05G SUdfSElEX0pBQlJBIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX1RXSU5IQU4gaXMgbm90IHNldAoj IENPTkZJR19ISURfS0VOU0lOR1RPTiBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9MQ1BPV0VSIGlz IG5vdCBzZXQKIyBDT05GSUdfSElEX0xFRCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9MRU5PVk8g aXMgbm90IHNldApDT05GSUdfSElEX0xPR0lURUNIPW0KIyBDT05GSUdfSElEX0xPR0lURUNIX0hJ RFBQIGlzIG5vdCBzZXQKQ09ORklHX0xPR0lURUNIX0ZGPXkKQ09ORklHX0xPR0lSVU1CTEVQQUQy X0ZGPXkKQ09ORklHX0xPR0lHOTQwX0ZGPXkKQ09ORklHX0xPR0lXSEVFTFNfRkY9eQojIENPTkZJ R19ISURfTUFHSUNNT1VTRSBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9NQUxUUk9OIGlzIG5vdCBz ZXQKIyBDT05GSUdfSElEX01BWUZMQVNIIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX1JFRFJBR09O IGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX01JQ1JPU09GVCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJ RF9NT05URVJFWSBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9NVUxUSVRPVUNIIGlzIG5vdCBzZXQK IyBDT05GSUdfSElEX05USSBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9OVFJJRyBpcyBub3Qgc2V0 CiMgQ09ORklHX0hJRF9PUlRFSyBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9QQU5USEVSTE9SRCBp cyBub3Qgc2V0CiMgQ09ORklHX0hJRF9QRU5NT1VOVCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9Q RVRBTFlOWCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9QSUNPTENEIGlzIG5vdCBzZXQKIyBDT05G SUdfSElEX1BMQU5UUk9OSUNTIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX1BMQVlTVEFUSU9OIGlz IG5vdCBzZXQKIyBDT05GSUdfSElEX1BSSU1BWCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9SRVRS T0RFIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX1JPQ0NBVCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJ RF9TQUlURUsgaXMgbm90IHNldAojIENPTkZJR19ISURfU0FNU1VORyBpcyBub3Qgc2V0CiMgQ09O RklHX0hJRF9TRU1JVEVLIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX1NPTlkgaXMgbm90IHNldAoj IENPTkZJR19ISURfU1BFRURMSU5LIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX1NURUFNIGlzIG5v dCBzZXQKIyBDT05GSUdfSElEX1NURUVMU0VSSUVTIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX1NV TlBMVVMgaXMgbm90IHNldAojIENPTkZJR19ISURfUk1JIGlzIG5vdCBzZXQKIyBDT05GSUdfSElE X0dSRUVOQVNJQSBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9TTUFSVEpPWVBMVVMgaXMgbm90IHNl dAojIENPTkZJR19ISURfVElWTyBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9UT1BTRUVEIGlzIG5v dCBzZXQKIyBDT05GSUdfSElEX1RISU5HTSBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9USFJVU1RN QVNURVIgaXMgbm90IHNldAojIENPTkZJR19ISURfVURSQVdfUFMzIGlzIG5vdCBzZXQKIyBDT05G SUdfSElEX1UyRlpFUk8gaXMgbm90IHNldAojIENPTkZJR19ISURfV0FDT00gaXMgbm90IHNldAoj IENPTkZJR19ISURfV0lJTU9URSBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9YSU5NTyBpcyBub3Qg c2V0CiMgQ09ORklHX0hJRF9aRVJPUExVUyBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9aWURBQ1JP TiBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9TRU5TT1JfSFVCIGlzIG5vdCBzZXQKIyBDT05GSUdf SElEX0FMUFMgaXMgbm90IHNldAojIENPTkZJR19ISURfTUNQMjIyMSBpcyBub3Qgc2V0CiMgZW5k IG9mIFNwZWNpYWwgSElEIGRyaXZlcnMKCiMKIyBVU0IgSElEIHN1cHBvcnQKIwpDT05GSUdfVVNC X0hJRD15CiMgQ09ORklHX0hJRF9QSUQgaXMgbm90IHNldAojIENPTkZJR19VU0JfSElEREVWIGlz IG5vdCBzZXQKIyBlbmQgb2YgVVNCIEhJRCBzdXBwb3J0CgojCiMgSTJDIEhJRCBzdXBwb3J0CiMK IyBDT05GSUdfSTJDX0hJRF9PRiBpcyBub3Qgc2V0CiMgQ09ORklHX0kyQ19ISURfT0ZfR09PRElY IGlzIG5vdCBzZXQKIyBlbmQgb2YgSTJDIEhJRCBzdXBwb3J0CiMgZW5kIG9mIEhJRCBzdXBwb3J0 CgpDT05GSUdfVVNCX09IQ0lfTElUVExFX0VORElBTj15CkNPTkZJR19VU0JfU1VQUE9SVD15CkNP TkZJR19VU0JfQ09NTU9OPXkKIyBDT05GSUdfVVNCX1VMUElfQlVTIGlzIG5vdCBzZXQKIyBDT05G SUdfVVNCX0NPTk5fR1BJTyBpcyBub3Qgc2V0CkNPTkZJR19VU0JfQVJDSF9IQVNfSENEPXkKQ09O RklHX1VTQj15CkNPTkZJR19VU0JfUENJPXkKIyBDT05GSUdfVVNCX0FOTk9VTkNFX05FV19ERVZJ Q0VTIGlzIG5vdCBzZXQKCiMKIyBNaXNjZWxsYW5lb3VzIFVTQiBvcHRpb25zCiMKQ09ORklHX1VT Ql9ERUZBVUxUX1BFUlNJU1Q9eQojIENPTkZJR19VU0JfRkVXX0lOSVRfUkVUUklFUyBpcyBub3Qg c2V0CiMgQ09ORklHX1VTQl9EWU5BTUlDX01JTk9SUyBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9P VEcgaXMgbm90IHNldAojIENPTkZJR19VU0JfT1RHX1BST0RVQ1RMSVNUIGlzIG5vdCBzZXQKIyBD T05GSUdfVVNCX09UR19ESVNBQkxFX0VYVEVSTkFMX0hVQiBpcyBub3Qgc2V0CkNPTkZJR19VU0Jf QVVUT1NVU1BFTkRfREVMQVk9MgojIENPTkZJR19VU0JfTU9OIGlzIG5vdCBzZXQKCiMKIyBVU0Ig SG9zdCBDb250cm9sbGVyIERyaXZlcnMKIwojIENPTkZJR19VU0JfQzY3WDAwX0hDRCBpcyBub3Qg c2V0CkNPTkZJR19VU0JfWEhDSV9IQ0Q9eQojIENPTkZJR19VU0JfWEhDSV9EQkdDQVAgaXMgbm90 IHNldApDT05GSUdfVVNCX1hIQ0lfUENJPXkKIyBDT05GSUdfVVNCX1hIQ0lfUENJX1JFTkVTQVMg aXMgbm90IHNldAojIENPTkZJR19VU0JfWEhDSV9QTEFURk9STSBpcyBub3Qgc2V0CiMgQ09ORklH X1VTQl9FSENJX0hDRCBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9PWFUyMTBIUF9IQ0QgaXMgbm90 IHNldAojIENPTkZJR19VU0JfSVNQMTE2WF9IQ0QgaXMgbm90IHNldAojIENPTkZJR19VU0JfRk9U RzIxMF9IQ0QgaXMgbm90IHNldAojIENPTkZJR19VU0JfTUFYMzQyMV9IQ0QgaXMgbm90IHNldAoj IENPTkZJR19VU0JfT0hDSV9IQ0QgaXMgbm90IHNldAojIENPTkZJR19VU0JfVUhDSV9IQ0QgaXMg bm90IHNldAojIENPTkZJR19VU0JfU0w4MTFfSENEIGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX1I4 QTY2NTk3X0hDRCBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9IQ0RfQkNNQSBpcyBub3Qgc2V0CiMg Q09ORklHX1VTQl9IQ0RfU1NCIGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX0hDRF9URVNUX01PREUg aXMgbm90IHNldAoKIwojIFVTQiBEZXZpY2UgQ2xhc3MgZHJpdmVycwojCiMgQ09ORklHX1VTQl9B Q00gaXMgbm90IHNldAojIENPTkZJR19VU0JfUFJJTlRFUiBpcyBub3Qgc2V0CiMgQ09ORklHX1VT Ql9XRE0gaXMgbm90IHNldAojIENPTkZJR19VU0JfVE1DIGlzIG5vdCBzZXQKCiMKIyBOT1RFOiBV U0JfU1RPUkFHRSBkZXBlbmRzIG9uIFNDU0kgYnV0IEJMS19ERVZfU0QgbWF5CiMKCiMKIyBhbHNv IGJlIG5lZWRlZDsgc2VlIFVTQl9TVE9SQUdFIEhlbHAgZm9yIG1vcmUgaW5mbwojCkNPTkZJR19V U0JfU1RPUkFHRT15CiMgQ09ORklHX1VTQl9TVE9SQUdFX0RFQlVHIGlzIG5vdCBzZXQKIyBDT05G SUdfVVNCX1NUT1JBR0VfUkVBTFRFSyBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9TVE9SQUdFX0RB VEFGQUIgaXMgbm90IHNldAojIENPTkZJR19VU0JfU1RPUkFHRV9GUkVFQ09NIGlzIG5vdCBzZXQK IyBDT05GSUdfVVNCX1NUT1JBR0VfSVNEMjAwIGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX1NUT1JB R0VfVVNCQVQgaXMgbm90IHNldAojIENPTkZJR19VU0JfU1RPUkFHRV9TRERSMDkgaXMgbm90IHNl dAojIENPTkZJR19VU0JfU1RPUkFHRV9TRERSNTUgaXMgbm90IHNldAojIENPTkZJR19VU0JfU1RP UkFHRV9KVU1QU0hPVCBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9TVE9SQUdFX0FMQVVEQSBpcyBu b3Qgc2V0CiMgQ09ORklHX1VTQl9TVE9SQUdFX09ORVRPVUNIIGlzIG5vdCBzZXQKIyBDT05GSUdf VVNCX1NUT1JBR0VfS0FSTUEgaXMgbm90IHNldAojIENPTkZJR19VU0JfU1RPUkFHRV9DWVBSRVNT X0FUQUNCIGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX1NUT1JBR0VfRU5FX1VCNjI1MCBpcyBub3Qg c2V0CiMgQ09ORklHX1VTQl9VQVMgaXMgbm90IHNldAoKIwojIFVTQiBJbWFnaW5nIGRldmljZXMK IwojIENPTkZJR19VU0JfTURDODAwIGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX01JQ1JPVEVLIGlz IG5vdCBzZXQKIyBDT05GSUdfVVNCSVBfQ09SRSBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9DRE5T X1NVUFBPUlQgaXMgbm90IHNldAojIENPTkZJR19VU0JfTVVTQl9IRFJDIGlzIG5vdCBzZXQKIyBD T05GSUdfVVNCX0RXQzMgaXMgbm90IHNldApDT05GSUdfVVNCX0RXQzI9eQpDT05GSUdfVVNCX0RX QzJfSE9TVD15CgojCiMgR2FkZ2V0L0R1YWwtcm9sZSBtb2RlIHJlcXVpcmVzIFVTQiBHYWRnZXQg c3VwcG9ydCB0byBiZSBlbmFibGVkCiMKIyBDT05GSUdfVVNCX0RXQzJfUENJIGlzIG5vdCBzZXQK IyBDT05GSUdfVVNCX0RXQzJfREVCVUcgaXMgbm90IHNldAojIENPTkZJR19VU0JfRFdDMl9UUkFD S19NSVNTRURfU09GUyBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9JU1AxNzYwIGlzIG5vdCBzZXQK CiMKIyBVU0IgcG9ydCBkcml2ZXJzCiMKIyBDT05GSUdfVVNCX1NFUklBTCBpcyBub3Qgc2V0Cgoj CiMgVVNCIE1pc2NlbGxhbmVvdXMgZHJpdmVycwojCiMgQ09ORklHX1VTQl9FTUk2MiBpcyBub3Qg c2V0CiMgQ09ORklHX1VTQl9FTUkyNiBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9BRFVUVVggaXMg bm90IHNldAojIENPTkZJR19VU0JfU0VWU0VHIGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX0xFR09U T1dFUiBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9MQ0QgaXMgbm90IHNldAojIENPTkZJR19VU0Jf Q1lQUkVTU19DWTdDNjMgaXMgbm90IHNldAojIENPTkZJR19VU0JfQ1lUSEVSTSBpcyBub3Qgc2V0 CiMgQ09ORklHX1VTQl9JRE1PVVNFIGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX0ZURElfRUxBTiBp cyBub3Qgc2V0CiMgQ09ORklHX1VTQl9BUFBMRURJU1BMQVkgaXMgbm90IHNldAojIENPTkZJR19B UFBMRV9NRklfRkFTVENIQVJHRSBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9MRCBpcyBub3Qgc2V0 CiMgQ09ORklHX1VTQl9UUkFOQ0VWSUJSQVRPUiBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9JT1dB UlJJT1IgaXMgbm90IHNldAojIENPTkZJR19VU0JfVEVTVCBpcyBub3Qgc2V0CiMgQ09ORklHX1VT Ql9FSFNFVF9URVNUX0ZJWFRVUkUgaXMgbm90IHNldAojIENPTkZJR19VU0JfSVNJR0hURlcgaXMg bm90IHNldAojIENPTkZJR19VU0JfWVVSRVggaXMgbm90IHNldAojIENPTkZJR19VU0JfRVpVU0Jf RlgyIGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX0hVQl9VU0IyNTFYQiBpcyBub3Qgc2V0CiMgQ09O RklHX1VTQl9IU0lDX1VTQjM1MDMgaXMgbm90IHNldAojIENPTkZJR19VU0JfSFNJQ19VU0I0NjA0 IGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX0xJTktfTEFZRVJfVEVTVCBpcyBub3Qgc2V0CiMgQ09O RklHX1VTQl9DSEFPU0tFWSBpcyBub3Qgc2V0CgojCiMgVVNCIFBoeXNpY2FsIExheWVyIGRyaXZl cnMKIwojIENPTkZJR19OT1BfVVNCX1hDRUlWIGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCX0dQSU9f VkJVUyBpcyBub3Qgc2V0CiMgQ09ORklHX1VTQl9JU1AxMzAxIGlzIG5vdCBzZXQKIyBDT05GSUdf VVNCX1VMUEkgaXMgbm90IHNldAojIGVuZCBvZiBVU0IgUGh5c2ljYWwgTGF5ZXIgZHJpdmVycwoK IyBDT05GSUdfVVNCX0dBREdFVCBpcyBub3Qgc2V0CiMgQ09ORklHX1RZUEVDIGlzIG5vdCBzZXQK Q09ORklHX1VTQl9ST0xFX1NXSVRDSD15CkNPTkZJR19NTUM9eQpDT05GSUdfUFdSU0VRX0VNTUM9 eQojIENPTkZJR19QV1JTRVFfU0Q4Nzg3IGlzIG5vdCBzZXQKQ09ORklHX1BXUlNFUV9TSU1QTEU9 eQpDT05GSUdfTU1DX0JMT0NLPXkKQ09ORklHX01NQ19CTE9DS19NSU5PUlM9MzIKIyBDT05GSUdf U0RJT19VQVJUIGlzIG5vdCBzZXQKIyBDT05GSUdfTU1DX1RFU1QgaXMgbm90IHNldAoKIwojIE1N Qy9TRC9TRElPIEhvc3QgQ29udHJvbGxlciBEcml2ZXJzCiMKIyBDT05GSUdfTU1DX0RFQlVHIGlz IG5vdCBzZXQKIyBDT05GSUdfTU1DX0FSTU1NQ0kgaXMgbm90IHNldApDT05GSUdfTU1DX1NESENJ PXkKQ09ORklHX01NQ19TREhDSV9JT19BQ0NFU1NPUlM9eQojIENPTkZJR19NTUNfU0RIQ0lfUENJ IGlzIG5vdCBzZXQKQ09ORklHX01NQ19TREhDSV9QTFRGTT15CiMgQ09ORklHX01NQ19TREhDSV9P Rl9BUkFTQU4gaXMgbm90IHNldAojIENPTkZJR19NTUNfU0RIQ0lfT0ZfQVNQRUVEIGlzIG5vdCBz ZXQKIyBDT05GSUdfTU1DX1NESENJX09GX0FUOTEgaXMgbm90IHNldAojIENPTkZJR19NTUNfU0RI Q0lfT0ZfRFdDTVNIQyBpcyBub3Qgc2V0CiMgQ09ORklHX01NQ19TREhDSV9DQURFTkNFIGlzIG5v dCBzZXQKIyBDT05GSUdfTU1DX1NESENJX0ZfU0RIMzAgaXMgbm90IHNldAojIENPTkZJR19NTUNf U0RIQ0lfTUlMQkVBVVQgaXMgbm90IHNldApDT05GSUdfTU1DX1NESENJX0lQUk9DPXkKIyBDT05G SUdfTU1DX1RJRk1fU0QgaXMgbm90IHNldApDT05GSUdfTU1DX1NQST1tCiMgQ09ORklHX01NQ19D QjcxMCBpcyBub3Qgc2V0CiMgQ09ORklHX01NQ19WSUFfU0RNTUMgaXMgbm90IHNldAojIENPTkZJ R19NTUNfRFcgaXMgbm90IHNldAojIENPTkZJR19NTUNfVlVCMzAwIGlzIG5vdCBzZXQKIyBDT05G SUdfTU1DX1VTSEMgaXMgbm90IHNldAojIENPTkZJR19NTUNfVVNESEk2Uk9MMCBpcyBub3Qgc2V0 CiMgQ09ORklHX01NQ19DUUhDSSBpcyBub3Qgc2V0CiMgQ09ORklHX01NQ19IU1EgaXMgbm90IHNl dAojIENPTkZJR19NTUNfVE9TSElCQV9QQ0kgaXMgbm90IHNldAojIENPTkZJR19NTUNfQkNNMjgz NSBpcyBub3Qgc2V0CiMgQ09ORklHX01NQ19NVEsgaXMgbm90IHNldApDT05GSUdfTU1DX1NESENJ X1hFTk9OPXkKIyBDT05GSUdfTU1DX1NESENJX09NQVAgaXMgbm90IHNldAojIENPTkZJR19NTUNf U0RIQ0lfQU02NTQgaXMgbm90IHNldAojIENPTkZJR19NRU1TVElDSyBpcyBub3Qgc2V0CkNPTkZJ R19ORVdfTEVEUz15CkNPTkZJR19MRURTX0NMQVNTPXkKIyBDT05GSUdfTEVEU19DTEFTU19GTEFT SCBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfQ0xBU1NfTVVMVElDT0xPUiBpcyBub3Qgc2V0CiMg Q09ORklHX0xFRFNfQlJJR0hUTkVTU19IV19DSEFOR0VEIGlzIG5vdCBzZXQKCiMKIyBMRUQgZHJp dmVycwojCiMgQ09ORklHX0xFRFNfQU4zMDI1OUEgaXMgbm90IHNldAojIENPTkZJR19MRURTX0FX MjAxMyBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfQkNNNjMyOCBpcyBub3Qgc2V0CiMgQ09ORklH X0xFRFNfQkNNNjM1OCBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfQ1IwMDE0MTE0IGlzIG5vdCBz ZXQKIyBDT05GSUdfTEVEU19FTDE1MjAzMDAwIGlzIG5vdCBzZXQKIyBDT05GSUdfTEVEU19MTTM1 MzAgaXMgbm90IHNldAojIENPTkZJR19MRURTX0xNMzUzMiBpcyBub3Qgc2V0CiMgQ09ORklHX0xF RFNfTE0zNjQyIGlzIG5vdCBzZXQKIyBDT05GSUdfTEVEU19MTTM2OTJYIGlzIG5vdCBzZXQKIyBD T05GSUdfTEVEU19QQ0E5NTMyIGlzIG5vdCBzZXQKIyBDT05GSUdfTEVEU19HUElPIGlzIG5vdCBz ZXQKIyBDT05GSUdfTEVEU19MUDM5NDQgaXMgbm90IHNldAojIENPTkZJR19MRURTX0xQMzk1MiBp cyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfTFA1MFhYIGlzIG5vdCBzZXQKIyBDT05GSUdfTEVEU19M UDU1WFhfQ09NTU9OIGlzIG5vdCBzZXQKIyBDT05GSUdfTEVEU19MUDg4NjAgaXMgbm90IHNldAoj IENPTkZJR19MRURTX1BDQTk1NVggaXMgbm90IHNldAojIENPTkZJR19MRURTX1BDQTk2M1ggaXMg bm90IHNldAojIENPTkZJR19MRURTX0RBQzEyNFMwODUgaXMgbm90IHNldAojIENPTkZJR19MRURT X1BXTSBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfUkVHVUxBVE9SIGlzIG5vdCBzZXQKIyBDT05G SUdfTEVEU19CRDI4MDIgaXMgbm90IHNldAojIENPTkZJR19MRURTX0xUMzU5MyBpcyBub3Qgc2V0 CiMgQ09ORklHX0xFRFNfVENBNjUwNyBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfVExDNTkxWFgg aXMgbm90IHNldAojIENPTkZJR19MRURTX0xNMzU1eCBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNf SVMzMUZMMzE5WCBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfSVMzMUZMMzJYWCBpcyBub3Qgc2V0 CgojCiMgTEVEIGRyaXZlciBmb3IgYmxpbmsoMSkgVVNCIFJHQiBMRUQgaXMgdW5kZXIgU3BlY2lh bCBISUQgZHJpdmVycyAoSElEX1RISU5HTSkKIwojIENPTkZJR19MRURTX0JMSU5LTSBpcyBub3Qg c2V0CiMgQ09ORklHX0xFRFNfU1lTQ09OIGlzIG5vdCBzZXQKIyBDT05GSUdfTEVEU19NTFhSRUcg aXMgbm90IHNldAojIENPTkZJR19MRURTX1VTRVIgaXMgbm90IHNldAojIENPTkZJR19MRURTX1NQ SV9CWVRFIGlzIG5vdCBzZXQKIyBDT05GSUdfTEVEU19USV9MTVVfQ09NTU9OIGlzIG5vdCBzZXQK CiMKIyBGbGFzaCBhbmQgVG9yY2ggTEVEIGRyaXZlcnMKIwoKIwojIExFRCBUcmlnZ2VycwojCiMg Q09ORklHX0xFRFNfVFJJR0dFUlMgaXMgbm90IHNldAojIENPTkZJR19BQ0NFU1NJQklMSVRZIGlz IG5vdCBzZXQKIyBDT05GSUdfSU5GSU5JQkFORCBpcyBub3Qgc2V0CkNPTkZJR19FREFDX1NVUFBP UlQ9eQojIENPTkZJR19SVENfQ0xBU1MgaXMgbm90IHNldApDT05GSUdfRE1BREVWSUNFUz15CiMg Q09ORklHX0RNQURFVklDRVNfREVCVUcgaXMgbm90IHNldAoKIwojIERNQSBEZXZpY2VzCiMKQ09O RklHX0RNQV9FTkdJTkU9eQpDT05GSUdfRE1BX1ZJUlRVQUxfQ0hBTk5FTFM9eQpDT05GSUdfRE1B X09GPXkKIyBDT05GSUdfQUxURVJBX01TR0RNQSBpcyBub3Qgc2V0CiMgQ09ORklHX0FNQkFfUEww OFggaXMgbm90IHNldAojIENPTkZJR19CQ01fU0JBX1JBSUQgaXMgbm90IHNldApDT05GSUdfRE1B X0JDTTI4MzU9eQojIENPTkZJR19EV19BWElfRE1BQyBpcyBub3Qgc2V0CiMgQ09ORklHX0ZTTF9F RE1BIGlzIG5vdCBzZXQKIyBDT05GSUdfRlNMX1FETUEgaXMgbm90IHNldAojIENPTkZJR19ISVNJ X0RNQSBpcyBub3Qgc2V0CiMgQ09ORklHX0lOVEVMX0lETUE2NCBpcyBub3Qgc2V0CiMgQ09ORklH X01WX1hPUl9WMiBpcyBub3Qgc2V0CiMgQ09ORklHX1BMMzMwX0RNQSBpcyBub3Qgc2V0CiMgQ09O RklHX1BMWF9ETUEgaXMgbm90IHNldAojIENPTkZJR19YSUxJTlhfRE1BIGlzIG5vdCBzZXQKIyBD T05GSUdfWElMSU5YX1pZTlFNUF9ETUEgaXMgbm90IHNldAojIENPTkZJR19YSUxJTlhfWllOUU1Q X0RQRE1BIGlzIG5vdCBzZXQKIyBDT05GSUdfUUNPTV9ISURNQV9NR01UIGlzIG5vdCBzZXQKIyBD T05GSUdfUUNPTV9ISURNQSBpcyBub3Qgc2V0CiMgQ09ORklHX0RXX0RNQUMgaXMgbm90IHNldAoj IENPTkZJR19EV19ETUFDX1BDSSBpcyBub3Qgc2V0CiMgQ09ORklHX0RXX0VETUEgaXMgbm90IHNl dAojIENPTkZJR19EV19FRE1BX1BDSUUgaXMgbm90IHNldAojIENPTkZJR19TRl9QRE1BIGlzIG5v dCBzZXQKCiMKIyBETUEgQ2xpZW50cwojCiMgQ09ORklHX0FTWU5DX1RYX0RNQSBpcyBub3Qgc2V0 CiMgQ09ORklHX0RNQVRFU1QgaXMgbm90IHNldAoKIwojIERNQUJVRiBvcHRpb25zCiMKQ09ORklH X1NZTkNfRklMRT15CiMgQ09ORklHX1NXX1NZTkMgaXMgbm90IHNldAojIENPTkZJR19VRE1BQlVG IGlzIG5vdCBzZXQKIyBDT05GSUdfRE1BQlVGX01PVkVfTk9USUZZIGlzIG5vdCBzZXQKIyBDT05G SUdfRE1BQlVGX0RFQlVHIGlzIG5vdCBzZXQKIyBDT05GSUdfRE1BQlVGX1NFTEZURVNUUyBpcyBu b3Qgc2V0CkNPTkZJR19ETUFCVUZfSEVBUFM9eQojIENPTkZJR19ETUFCVUZfU1lTRlNfU1RBVFMg aXMgbm90IHNldApDT05GSUdfRE1BQlVGX0hFQVBTX1NZU1RFTT15CkNPTkZJR19ETUFCVUZfSEVB UFNfQ01BPXkKIyBlbmQgb2YgRE1BQlVGIG9wdGlvbnMKCiMgQ09ORklHX0FVWERJU1BMQVkgaXMg bm90IHNldAojIENPTkZJR19VSU8gaXMgbm90IHNldAojIENPTkZJR19WRklPIGlzIG5vdCBzZXQK Q09ORklHX1ZJUlRfRFJJVkVSUz15CkNPTkZJR19WSVJUSU89eQpDT05GSUdfVklSVElPX01FTlU9 eQojIENPTkZJR19WSVJUSU9fUENJIGlzIG5vdCBzZXQKIyBDT05GSUdfVklSVElPX0JBTExPT04g aXMgbm90IHNldAojIENPTkZJR19WSVJUSU9fSU5QVVQgaXMgbm90IHNldAojIENPTkZJR19WSVJU SU9fTU1JTyBpcyBub3Qgc2V0CkNPTkZJR19WSVJUSU9fRE1BX1NIQVJFRF9CVUZGRVI9eQojIENP TkZJR19WRFBBIGlzIG5vdCBzZXQKQ09ORklHX1ZIT1NUX01FTlU9eQojIENPTkZJR19WSE9TVF9O RVQgaXMgbm90IHNldAojIENPTkZJR19WSE9TVF9DUk9TU19FTkRJQU5fTEVHQUNZIGlzIG5vdCBz ZXQKCiMKIyBNaWNyb3NvZnQgSHlwZXItViBndWVzdCBzdXBwb3J0CiMKIyBlbmQgb2YgTWljcm9z b2Z0IEh5cGVyLVYgZ3Vlc3Qgc3VwcG9ydAoKIwojIFhlbiBkcml2ZXIgc3VwcG9ydAojCkNPTkZJ R19YRU5fQkFMTE9PTj15CkNPTkZJR19YRU5fU0NSVUJfUEFHRVNfREVGQVVMVD15CkNPTkZJR19Y RU5fREVWX0VWVENITj15CkNPTkZJR19YRU5fQkFDS0VORD15CkNPTkZJR19YRU5GUz15CkNPTkZJ R19YRU5fQ09NUEFUX1hFTkZTPXkKQ09ORklHX1hFTl9TWVNfSFlQRVJWSVNPUj15CkNPTkZJR19Y RU5fWEVOQlVTX0ZST05URU5EPXkKQ09ORklHX1hFTl9HTlRERVY9bQpDT05GSUdfWEVOX0dOVERF Vl9ETUFCVUY9eQpDT05GSUdfWEVOX0dSQU5UX0RFVl9BTExPQz1tCkNPTkZJR19YRU5fR1JBTlRf RE1BX0FMTE9DPXkKQ09ORklHX1NXSU9UTEJfWEVOPXkKQ09ORklHX1hFTl9QVkNBTExTX0ZST05U RU5EPXkKQ09ORklHX1hFTl9QVkNBTExTX0JBQ0tFTkQ9eQpDT05GSUdfWEVOX1BSSVZDTUQ9eQpD T05GSUdfWEVOX0VGST15CkNPTkZJR19YRU5fQVVUT19YTEFURT15CkNPTkZJR19YRU5fRlJPTlRf UEdESVJfU0hCVUY9eQojIGVuZCBvZiBYZW4gZHJpdmVyIHN1cHBvcnQKCiMgQ09ORklHX0dSRVlC VVMgaXMgbm90IHNldAojIENPTkZJR19DT01FREkgaXMgbm90IHNldApDT05GSUdfU1RBR0lORz15 CiMgQ09ORklHX1BSSVNNMl9VU0IgaXMgbm90IHNldAojIENPTkZJR19SVEw4MTkyVSBpcyBub3Qg c2V0CiMgQ09ORklHX1JUTExJQiBpcyBub3Qgc2V0CiMgQ09ORklHX1JUTDg3MjNCUyBpcyBub3Qg c2V0CiMgQ09ORklHX1I4NzEyVSBpcyBub3Qgc2V0CiMgQ09ORklHX1I4MTg4RVUgaXMgbm90IHNl dAojIENPTkZJR19SVFM1MjA4IGlzIG5vdCBzZXQKIyBDT05GSUdfVlQ2NjU1IGlzIG5vdCBzZXQK IyBDT05GSUdfVlQ2NjU2IGlzIG5vdCBzZXQKCiMKIyBJSU8gc3RhZ2luZyBkcml2ZXJzCiMKCiMK IyBBY2NlbGVyb21ldGVycwojCiMgQ09ORklHX0FESVMxNjIwMyBpcyBub3Qgc2V0CiMgQ09ORklH X0FESVMxNjI0MCBpcyBub3Qgc2V0CiMgZW5kIG9mIEFjY2VsZXJvbWV0ZXJzCgojCiMgQW5hbG9n IHRvIGRpZ2l0YWwgY29udmVydGVycwojCiMgQ09ORklHX0FENzgxNiBpcyBub3Qgc2V0CiMgQ09O RklHX0FENzI4MCBpcyBub3Qgc2V0CiMgZW5kIG9mIEFuYWxvZyB0byBkaWdpdGFsIGNvbnZlcnRl cnMKCiMKIyBBbmFsb2cgZGlnaXRhbCBiaS1kaXJlY3Rpb24gY29udmVydGVycwojCiMgQ09ORklH X0FEVDczMTYgaXMgbm90IHNldAojIGVuZCBvZiBBbmFsb2cgZGlnaXRhbCBiaS1kaXJlY3Rpb24g Y29udmVydGVycwoKIwojIENhcGFjaXRhbmNlIHRvIGRpZ2l0YWwgY29udmVydGVycwojCiMgQ09O RklHX0FENzc0NiBpcyBub3Qgc2V0CiMgZW5kIG9mIENhcGFjaXRhbmNlIHRvIGRpZ2l0YWwgY29u dmVydGVycwoKIwojIERpcmVjdCBEaWdpdGFsIFN5bnRoZXNpcwojCiMgQ09ORklHX0FEOTgzMiBp cyBub3Qgc2V0CiMgQ09ORklHX0FEOTgzNCBpcyBub3Qgc2V0CiMgZW5kIG9mIERpcmVjdCBEaWdp dGFsIFN5bnRoZXNpcwoKIwojIE5ldHdvcmsgQW5hbHl6ZXIsIEltcGVkYW5jZSBDb252ZXJ0ZXJz CiMKIyBDT05GSUdfQUQ1OTMzIGlzIG5vdCBzZXQKIyBlbmQgb2YgTmV0d29yayBBbmFseXplciwg SW1wZWRhbmNlIENvbnZlcnRlcnMKCiMKIyBBY3RpdmUgZW5lcmd5IG1ldGVyaW5nIElDCiMKIyBD T05GSUdfQURFNzg1NCBpcyBub3Qgc2V0CiMgZW5kIG9mIEFjdGl2ZSBlbmVyZ3kgbWV0ZXJpbmcg SUMKCiMKIyBSZXNvbHZlciB0byBkaWdpdGFsIGNvbnZlcnRlcnMKIwojIENPTkZJR19BRDJTMTIx MCBpcyBub3Qgc2V0CiMgZW5kIG9mIFJlc29sdmVyIHRvIGRpZ2l0YWwgY29udmVydGVycwojIGVu ZCBvZiBJSU8gc3RhZ2luZyBkcml2ZXJzCgojIENPTkZJR19GQl9TTTc1MCBpcyBub3Qgc2V0CiMg Q09ORklHX1NUQUdJTkdfTUVESUEgaXMgbm90IHNldAoKIwojIEFuZHJvaWQKIwojIGVuZCBvZiBB bmRyb2lkCgojIENPTkZJR19TVEFHSU5HX0JPQVJEIGlzIG5vdCBzZXQKIyBDT05GSUdfTFRFX0dE TTcyNFggaXMgbm90IHNldAojIENPTkZJR19HU19GUEdBQk9PVCBpcyBub3Qgc2V0CiMgQ09ORklH X1VOSVNZU1NQQVIgaXMgbm90IHNldAojIENPTkZJR19DT01NT05fQ0xLX1hMTlhfQ0xLV1pSRCBp cyBub3Qgc2V0CiMgQ09ORklHX0ZCX1RGVCBpcyBub3Qgc2V0CiMgQ09ORklHX0tTNzAxMCBpcyBu b3Qgc2V0CkNPTkZJR19CQ01fVklERU9DT1JFPXkKQ09ORklHX0JDTTI4MzVfVkNISVE9bQpDT05G SUdfVkNISVFfQ0RFVj15CkNPTkZJR19TTkRfQkNNMjgzNT1tCkNPTkZJR19WSURFT19CQ00yODM1 PW0KQ09ORklHX0JDTTI4MzVfVkNISVFfTU1BTD1tCiMgQ09ORklHX1BJNDMzIGlzIG5vdCBzZXQK IyBDT05GSUdfWElMX0FYSVNfRklGTyBpcyBub3Qgc2V0CiMgQ09ORklHX0ZJRUxEQlVTX0RFViBp cyBub3Qgc2V0CiMgQ09ORklHX1FMR0UgaXMgbm90IHNldAojIENPTkZJR19XRlggaXMgbm90IHNl dAojIENPTkZJR19HT0xERklTSCBpcyBub3Qgc2V0CiMgQ09ORklHX0NIUk9NRV9QTEFURk9STVMg aXMgbm90IHNldAojIENPTkZJR19NRUxMQU5PWF9QTEFURk9STSBpcyBub3Qgc2V0CkNPTkZJR19I QVZFX0NMSz15CkNPTkZJR19IQVZFX0NMS19QUkVQQVJFPXkKQ09ORklHX0NPTU1PTl9DTEs9eQoK IwojIENsb2NrIGRyaXZlciBmb3IgQVJNIFJlZmVyZW5jZSBkZXNpZ25zCiMKIyBDT05GSUdfSUNT VCBpcyBub3Qgc2V0CiMgQ09ORklHX0NMS19TUDgxMCBpcyBub3Qgc2V0CiMgZW5kIG9mIENsb2Nr IGRyaXZlciBmb3IgQVJNIFJlZmVyZW5jZSBkZXNpZ25zCgojIENPTkZJR19MTUswNDgzMiBpcyBu b3Qgc2V0CiMgQ09ORklHX0NPTU1PTl9DTEtfTUFYOTQ4NSBpcyBub3Qgc2V0CiMgQ09ORklHX0NP TU1PTl9DTEtfU0k1MzQxIGlzIG5vdCBzZXQKIyBDT05GSUdfQ09NTU9OX0NMS19TSTUzNTEgaXMg bm90IHNldAojIENPTkZJR19DT01NT05fQ0xLX1NJNTE0IGlzIG5vdCBzZXQKIyBDT05GSUdfQ09N TU9OX0NMS19TSTU0NCBpcyBub3Qgc2V0CiMgQ09ORklHX0NPTU1PTl9DTEtfU0k1NzAgaXMgbm90 IHNldAojIENPTkZJR19DT01NT05fQ0xLX0NEQ0U3MDYgaXMgbm90IHNldAojIENPTkZJR19DT01N T05fQ0xLX0NEQ0U5MjUgaXMgbm90IHNldAojIENPTkZJR19DT01NT05fQ0xLX0NTMjAwMF9DUCBp cyBub3Qgc2V0CiMgQ09ORklHX0NPTU1PTl9DTEtfQVhJX0NMS0dFTiBpcyBub3Qgc2V0CiMgQ09O RklHX0NPTU1PTl9DTEtfWEdFTkUgaXMgbm90IHNldAojIENPTkZJR19DT01NT05fQ0xLX1BXTSBp cyBub3Qgc2V0CiMgQ09ORklHX0NPTU1PTl9DTEtfVkM1IGlzIG5vdCBzZXQKIyBDT05GSUdfQ09N TU9OX0NMS19GSVhFRF9NTUlPIGlzIG5vdCBzZXQKQ09ORklHX0NMS19CQ00yNzExX0RWUD15CkNP TkZJR19DTEtfQkNNMjgzNT15CkNPTkZJR19DTEtfUkFTUEJFUlJZUEk9eQojIENPTkZJR19YSUxJ TlhfVkNVIGlzIG5vdCBzZXQKIyBDT05GSUdfSFdTUElOTE9DSyBpcyBub3Qgc2V0CgojCiMgQ2xv Y2sgU291cmNlIGRyaXZlcnMKIwpDT05GSUdfVElNRVJfT0Y9eQpDT05GSUdfVElNRVJfUFJPQkU9 eQpDT05GSUdfQ0xLU1JDX01NSU89eQpDT05GSUdfQVJNX0FSQ0hfVElNRVI9eQpDT05GSUdfQVJN X0FSQ0hfVElNRVJfRVZUU1RSRUFNPXkKQ09ORklHX0FSTV9BUkNIX1RJTUVSX09PTF9XT1JLQVJP VU5EPXkKQ09ORklHX0ZTTF9FUlJBVFVNX0EwMDg1ODU9eQpDT05GSUdfSElTSUxJQ09OX0VSUkFU VU1fMTYxMDEwMTAxPXkKQ09ORklHX0FSTTY0X0VSUkFUVU1fODU4OTIxPXkKQ09ORklHX0FSTV9U SU1FUl9TUDgwND15CiMgQ09ORklHX01JQ1JPQ0hJUF9QSVQ2NEIgaXMgbm90IHNldAojIGVuZCBv ZiBDbG9jayBTb3VyY2UgZHJpdmVycwoKQ09ORklHX01BSUxCT1g9eQojIENPTkZJR19BUk1fTUhV IGlzIG5vdCBzZXQKIyBDT05GSUdfQVJNX01IVV9WMiBpcyBub3Qgc2V0CiMgQ09ORklHX1BMQVRG T1JNX01IVSBpcyBub3Qgc2V0CiMgQ09ORklHX1BMMzIwX01CT1ggaXMgbm90IHNldAojIENPTkZJ R19BTFRFUkFfTUJPWCBpcyBub3Qgc2V0CkNPTkZJR19CQ00yODM1X01CT1g9eQojIENPTkZJR19N QUlMQk9YX1RFU1QgaXMgbm90IHNldApDT05GSUdfSU9NTVVfSU9WQT15CkNPTkZJR19JT01NVV9B UEk9eQpDT05GSUdfSU9NTVVfU1VQUE9SVD15CgojCiMgR2VuZXJpYyBJT01NVSBQYWdldGFibGUg U3VwcG9ydAojCiMgQ09ORklHX0lPTU1VX0lPX1BHVEFCTEVfTFBBRSBpcyBub3Qgc2V0CiMgQ09O RklHX0lPTU1VX0lPX1BHVEFCTEVfQVJNVjdTIGlzIG5vdCBzZXQKIyBlbmQgb2YgR2VuZXJpYyBJ T01NVSBQYWdldGFibGUgU3VwcG9ydAoKIyBDT05GSUdfSU9NTVVfREVCVUdGUyBpcyBub3Qgc2V0 CkNPTkZJR19JT01NVV9ERUZBVUxUX0RNQV9TVFJJQ1Q9eQojIENPTkZJR19JT01NVV9ERUZBVUxU X0RNQV9MQVpZIGlzIG5vdCBzZXQKIyBDT05GSUdfSU9NTVVfREVGQVVMVF9QQVNTVEhST1VHSCBp cyBub3Qgc2V0CkNPTkZJR19PRl9JT01NVT15CkNPTkZJR19JT01NVV9ETUE9eQojIENPTkZJR19B Uk1fU01NVSBpcyBub3Qgc2V0CiMgQ09ORklHX0FSTV9TTU1VX1YzIGlzIG5vdCBzZXQKIyBDT05G SUdfVklSVElPX0lPTU1VIGlzIG5vdCBzZXQKCiMKIyBSZW1vdGVwcm9jIGRyaXZlcnMKIwojIENP TkZJR19SRU1PVEVQUk9DIGlzIG5vdCBzZXQKIyBlbmQgb2YgUmVtb3RlcHJvYyBkcml2ZXJzCgoj CiMgUnBtc2cgZHJpdmVycwojCiMgQ09ORklHX1JQTVNHX1FDT01fR0xJTktfUlBNIGlzIG5vdCBz ZXQKIyBDT05GSUdfUlBNU0dfVklSVElPIGlzIG5vdCBzZXQKIyBlbmQgb2YgUnBtc2cgZHJpdmVy cwoKIyBDT05GSUdfU09VTkRXSVJFIGlzIG5vdCBzZXQKCiMKIyBTT0MgKFN5c3RlbSBPbiBDaGlw KSBzcGVjaWZpYyBEcml2ZXJzCiMKCiMKIyBBbWxvZ2ljIFNvQyBkcml2ZXJzCiMKIyBlbmQgb2Yg QW1sb2dpYyBTb0MgZHJpdmVycwoKIwojIEJyb2FkY29tIFNvQyBkcml2ZXJzCiMKQ09ORklHX0JD TTI4MzVfUE9XRVI9eQpDT05GSUdfUkFTUEJFUlJZUElfUE9XRVI9eQojIENPTkZJR19TT0NfQlJD TVNUQiBpcyBub3Qgc2V0CiMgZW5kIG9mIEJyb2FkY29tIFNvQyBkcml2ZXJzCgojCiMgTlhQL0Zy ZWVzY2FsZSBRb3JJUSBTb0MgZHJpdmVycwojCiMgQ09ORklHX1FVSUNDX0VOR0lORSBpcyBub3Qg c2V0CiMgQ09ORklHX0ZTTF9SQ1BNIGlzIG5vdCBzZXQKIyBlbmQgb2YgTlhQL0ZyZWVzY2FsZSBR b3JJUSBTb0MgZHJpdmVycwoKIwojIGkuTVggU29DIGRyaXZlcnMKIwojIGVuZCBvZiBpLk1YIFNv QyBkcml2ZXJzCgojCiMgRW5hYmxlIExpdGVYIFNvQyBCdWlsZGVyIHNwZWNpZmljIGRyaXZlcnMK IwojIENPTkZJR19MSVRFWF9TT0NfQ09OVFJPTExFUiBpcyBub3Qgc2V0CiMgZW5kIG9mIEVuYWJs ZSBMaXRlWCBTb0MgQnVpbGRlciBzcGVjaWZpYyBkcml2ZXJzCgojCiMgUXVhbGNvbW0gU29DIGRy aXZlcnMKIwojIGVuZCBvZiBRdWFsY29tbSBTb0MgZHJpdmVycwoKIyBDT05GSUdfU09DX1RJIGlz IG5vdCBzZXQKCiMKIyBYaWxpbnggU29DIGRyaXZlcnMKIwojIGVuZCBvZiBYaWxpbnggU29DIGRy aXZlcnMKIyBlbmQgb2YgU09DIChTeXN0ZW0gT24gQ2hpcCkgc3BlY2lmaWMgRHJpdmVycwoKIyBD T05GSUdfUE1fREVWRlJFUSBpcyBub3Qgc2V0CiMgQ09ORklHX0VYVENPTiBpcyBub3Qgc2V0CiMg Q09ORklHX01FTU9SWSBpcyBub3Qgc2V0CkNPTkZJR19JSU89bQpDT05GSUdfSUlPX0JVRkZFUj15 CiMgQ09ORklHX0lJT19CVUZGRVJfQ0IgaXMgbm90IHNldAojIENPTkZJR19JSU9fQlVGRkVSX0RN QSBpcyBub3Qgc2V0CiMgQ09ORklHX0lJT19CVUZGRVJfRE1BRU5HSU5FIGlzIG5vdCBzZXQKIyBD T05GSUdfSUlPX0JVRkZFUl9IV19DT05TVU1FUiBpcyBub3Qgc2V0CkNPTkZJR19JSU9fS0ZJRk9f QlVGPW0KQ09ORklHX0lJT19UUklHR0VSRURfQlVGRkVSPW0KIyBDT05GSUdfSUlPX0NPTkZJR0ZT IGlzIG5vdCBzZXQKQ09ORklHX0lJT19UUklHR0VSPXkKQ09ORklHX0lJT19DT05TVU1FUlNfUEVS X1RSSUdHRVI9MgojIENPTkZJR19JSU9fU1dfREVWSUNFIGlzIG5vdCBzZXQKIyBDT05GSUdfSUlP X1NXX1RSSUdHRVIgaXMgbm90IHNldAojIENPTkZJR19JSU9fVFJJR0dFUkVEX0VWRU5UIGlzIG5v dCBzZXQKCiMKIyBBY2NlbGVyb21ldGVycwojCiMgQ09ORklHX0FESVMxNjIwMSBpcyBub3Qgc2V0 CiMgQ09ORklHX0FESVMxNjIwOSBpcyBub3Qgc2V0CiMgQ09ORklHX0FEWEwzNDVfSTJDIGlzIG5v dCBzZXQKIyBDT05GSUdfQURYTDM0NV9TUEkgaXMgbm90IHNldAojIENPTkZJR19BRFhMMzcyX1NQ SSBpcyBub3Qgc2V0CiMgQ09ORklHX0FEWEwzNzJfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfQk1B MTgwIGlzIG5vdCBzZXQKIyBDT05GSUdfQk1BMjIwIGlzIG5vdCBzZXQKIyBDT05GSUdfQk1BNDAw IGlzIG5vdCBzZXQKIyBDT05GSUdfQk1DMTUwX0FDQ0VMIGlzIG5vdCBzZXQKIyBDT05GSUdfQk1J MDg4X0FDQ0VMIGlzIG5vdCBzZXQKIyBDT05GSUdfREEyODAgaXMgbm90IHNldAojIENPTkZJR19E QTMxMSBpcyBub3Qgc2V0CiMgQ09ORklHX0RNQVJEMDYgaXMgbm90IHNldAojIENPTkZJR19ETUFS RDA5IGlzIG5vdCBzZXQKIyBDT05GSUdfRE1BUkQxMCBpcyBub3Qgc2V0CiMgQ09ORklHX0ZYTFM4 OTYyQUZfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfRlhMUzg5NjJBRl9TUEkgaXMgbm90IHNldAoj IENPTkZJR19JSU9fU1RfQUNDRUxfM0FYSVMgaXMgbm90IHNldAojIENPTkZJR19LWFNEOSBpcyBu b3Qgc2V0CiMgQ09ORklHX0tYQ0pLMTAxMyBpcyBub3Qgc2V0CiMgQ09ORklHX01DMzIzMCBpcyBu b3Qgc2V0CiMgQ09ORklHX01NQTc0NTVfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfTU1BNzQ1NV9T UEkgaXMgbm90IHNldAojIENPTkZJR19NTUE3NjYwIGlzIG5vdCBzZXQKIyBDT05GSUdfTU1BODQ1 MiBpcyBub3Qgc2V0CiMgQ09ORklHX01NQTk1NTEgaXMgbm90IHNldAojIENPTkZJR19NTUE5NTUz IGlzIG5vdCBzZXQKIyBDT05GSUdfTVhDNDAwNSBpcyBub3Qgc2V0CiMgQ09ORklHX01YQzYyNTUg aXMgbm90IHNldAojIENPTkZJR19TQ0EzMDAwIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NBMzMwMCBp cyBub3Qgc2V0CiMgQ09ORklHX1NUSzgzMTIgaXMgbm90IHNldAojIENPTkZJR19TVEs4QkE1MCBp cyBub3Qgc2V0CiMgZW5kIG9mIEFjY2VsZXJvbWV0ZXJzCgojCiMgQW5hbG9nIHRvIGRpZ2l0YWwg Y29udmVydGVycwojCiMgQ09ORklHX0FENzA5MVI1IGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ3MTI0 IGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ3MTkyIGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ3MjY2IGlz IG5vdCBzZXQKIyBDT05GSUdfQUQ3MjkxIGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ3MjkyIGlzIG5v dCBzZXQKIyBDT05GSUdfQUQ3Mjk4IGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ3NDc2IGlzIG5vdCBz ZXQKIyBDT05GSUdfQUQ3NjA2X0lGQUNFX1BBUkFMTEVMIGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ3 NjA2X0lGQUNFX1NQSSBpcyBub3Qgc2V0CiMgQ09ORklHX0FENzc2NiBpcyBub3Qgc2V0CiMgQ09O RklHX0FENzc2OF8xIGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ3NzgwIGlzIG5vdCBzZXQKIyBDT05G SUdfQUQ3NzkxIGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ3NzkzIGlzIG5vdCBzZXQKIyBDT05GSUdf QUQ3ODg3IGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ3OTIzIGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ3 OTQ5IGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ3OTlYIGlzIG5vdCBzZXQKIyBDT05GSUdfQURJX0FY SV9BREMgaXMgbm90IHNldAojIENPTkZJR19DQzEwMDAxX0FEQyBpcyBub3Qgc2V0CiMgQ09ORklH X0VOVkVMT1BFX0RFVEVDVE9SIGlzIG5vdCBzZXQKIyBDT05GSUdfSEk4NDM1IGlzIG5vdCBzZXQK IyBDT05GSUdfSFg3MTEgaXMgbm90IHNldAojIENPTkZJR19JTkEyWFhfQURDIGlzIG5vdCBzZXQK IyBDT05GSUdfTFRDMjQ3MSBpcyBub3Qgc2V0CiMgQ09ORklHX0xUQzI0ODUgaXMgbm90IHNldAoj IENPTkZJR19MVEMyNDk2IGlzIG5vdCBzZXQKIyBDT05GSUdfTFRDMjQ5NyBpcyBub3Qgc2V0CiMg Q09ORklHX01BWDEwMjcgaXMgbm90IHNldAojIENPTkZJR19NQVgxMTEwMCBpcyBub3Qgc2V0CiMg Q09ORklHX01BWDExMTggaXMgbm90IHNldAojIENPTkZJR19NQVgxMjQxIGlzIG5vdCBzZXQKIyBD T05GSUdfTUFYMTM2MyBpcyBub3Qgc2V0CiMgQ09ORklHX01BWDk2MTEgaXMgbm90IHNldAojIENP TkZJR19NQ1AzMjBYIGlzIG5vdCBzZXQKIyBDT05GSUdfTUNQMzQyMiBpcyBub3Qgc2V0CiMgQ09O RklHX01DUDM5MTEgaXMgbm90IHNldAojIENPTkZJR19OQVU3ODAyIGlzIG5vdCBzZXQKIyBDT05G SUdfU0RfQURDX01PRFVMQVRPUiBpcyBub3Qgc2V0CiMgQ09ORklHX1NUTVBFX0FEQyBpcyBub3Qg c2V0CiMgQ09ORklHX1RJX0FEQzA4MUMgaXMgbm90IHNldAojIENPTkZJR19USV9BREMwODMyIGlz IG5vdCBzZXQKIyBDT05GSUdfVElfQURDMDg0UzAyMSBpcyBub3Qgc2V0CiMgQ09ORklHX1RJX0FE QzEyMTM4IGlzIG5vdCBzZXQKIyBDT05GSUdfVElfQURDMTA4UzEwMiBpcyBub3Qgc2V0CiMgQ09O RklHX1RJX0FEQzEyOFMwNTIgaXMgbm90IHNldAojIENPTkZJR19USV9BREMxNjFTNjI2IGlzIG5v dCBzZXQKIyBDT05GSUdfVElfQURTMTAxNSBpcyBub3Qgc2V0CiMgQ09ORklHX1RJX0FEUzc5NTAg aXMgbm90IHNldAojIENPTkZJR19USV9BRFM4MzQ0IGlzIG5vdCBzZXQKIyBDT05GSUdfVElfQURT ODY4OCBpcyBub3Qgc2V0CiMgQ09ORklHX1RJX0FEUzEyNFMwOCBpcyBub3Qgc2V0CiMgQ09ORklH X1RJX0FEUzEzMUUwOCBpcyBub3Qgc2V0CiMgQ09ORklHX1RJX1RMQzQ1NDEgaXMgbm90IHNldAoj IENPTkZJR19USV9UU0MyMDQ2IGlzIG5vdCBzZXQKIyBDT05GSUdfVkY2MTBfQURDIGlzIG5vdCBz ZXQKIyBDT05GSUdfWElMSU5YX1hBREMgaXMgbm90IHNldAojIGVuZCBvZiBBbmFsb2cgdG8gZGln aXRhbCBjb252ZXJ0ZXJzCgojCiMgQW5hbG9nIEZyb250IEVuZHMKIwojIENPTkZJR19JSU9fUkVT Q0FMRSBpcyBub3Qgc2V0CiMgZW5kIG9mIEFuYWxvZyBGcm9udCBFbmRzCgojCiMgQW1wbGlmaWVy cwojCiMgQ09ORklHX0FEODM2NiBpcyBub3Qgc2V0CiMgQ09ORklHX0hNQzQyNSBpcyBub3Qgc2V0 CiMgZW5kIG9mIEFtcGxpZmllcnMKCiMKIyBDYXBhY2l0YW5jZSB0byBkaWdpdGFsIGNvbnZlcnRl cnMKIwojIENPTkZJR19BRDcxNTAgaXMgbm90IHNldAojIGVuZCBvZiBDYXBhY2l0YW5jZSB0byBk aWdpdGFsIGNvbnZlcnRlcnMKCiMKIyBDaGVtaWNhbCBTZW5zb3JzCiMKIyBDT05GSUdfQVRMQVNf UEhfU0VOU09SIGlzIG5vdCBzZXQKIyBDT05GSUdfQVRMQVNfRVpPX1NFTlNPUiBpcyBub3Qgc2V0 CiMgQ09ORklHX0JNRTY4MCBpcyBub3Qgc2V0CkNPTkZJR19DQ1M4MTE9bQojIENPTkZJR19JQVFD T1JFIGlzIG5vdCBzZXQKIyBDT05GSUdfUE1TNzAwMyBpcyBub3Qgc2V0CiMgQ09ORklHX1NDRDMw X0NPUkUgaXMgbm90IHNldApDT05GSUdfU0VOU0lSSU9OX1NHUDMwPW0KIyBDT05GSUdfU0VOU0lS SU9OX1NHUDQwIGlzIG5vdCBzZXQKIyBDT05GSUdfU1BTMzBfSTJDIGlzIG5vdCBzZXQKIyBDT05G SUdfU1BTMzBfU0VSSUFMIGlzIG5vdCBzZXQKIyBDT05GSUdfVlo4OVggaXMgbm90IHNldAojIGVu ZCBvZiBDaGVtaWNhbCBTZW5zb3JzCgojCiMgSGlkIFNlbnNvciBJSU8gQ29tbW9uCiMKIyBlbmQg b2YgSGlkIFNlbnNvciBJSU8gQ29tbW9uCgojCiMgSUlPIFNDTUkgU2Vuc29ycwojCiMgZW5kIG9m IElJTyBTQ01JIFNlbnNvcnMKCiMKIyBTU1AgU2Vuc29yIENvbW1vbgojCiMgQ09ORklHX0lJT19T U1BfU0VOU09SSFVCIGlzIG5vdCBzZXQKIyBlbmQgb2YgU1NQIFNlbnNvciBDb21tb24KCiMKIyBE aWdpdGFsIHRvIGFuYWxvZyBjb252ZXJ0ZXJzCiMKIyBDT05GSUdfQUQ1MDY0IGlzIG5vdCBzZXQK IyBDT05GSUdfQUQ1MzYwIGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ1MzgwIGlzIG5vdCBzZXQKIyBD T05GSUdfQUQ1NDIxIGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ1NDQ2IGlzIG5vdCBzZXQKIyBDT05G SUdfQUQ1NDQ5IGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ1NTkyUiBpcyBub3Qgc2V0CiMgQ09ORklH X0FENTU5M1IgaXMgbm90IHNldAojIENPTkZJR19BRDU1MDQgaXMgbm90IHNldAojIENPTkZJR19B RDU2MjRSX1NQSSBpcyBub3Qgc2V0CiMgQ09ORklHX0FENTY4Nl9TUEkgaXMgbm90IHNldAojIENP TkZJR19BRDU2OTZfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ1NzU1IGlzIG5vdCBzZXQKIyBD T05GSUdfQUQ1NzU4IGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ1NzYxIGlzIG5vdCBzZXQKIyBDT05G SUdfQUQ1NzY0IGlzIG5vdCBzZXQKIyBDT05GSUdfQUQ1NzY2IGlzIG5vdCBzZXQKIyBDT05GSUdf QUQ1NzcwUiBpcyBub3Qgc2V0CiMgQ09ORklHX0FENTc5MSBpcyBub3Qgc2V0CiMgQ09ORklHX0FE NzMwMyBpcyBub3Qgc2V0CiMgQ09ORklHX0FEODgwMSBpcyBub3Qgc2V0CiMgQ09ORklHX0RQT1Rf REFDIGlzIG5vdCBzZXQKIyBDT05GSUdfRFM0NDI0IGlzIG5vdCBzZXQKIyBDT05GSUdfTFRDMTY2 MCBpcyBub3Qgc2V0CiMgQ09ORklHX0xUQzI2MzIgaXMgbm90IHNldAojIENPTkZJR19NNjIzMzIg aXMgbm90IHNldAojIENPTkZJR19NQVg1MTcgaXMgbm90IHNldAojIENPTkZJR19NQVg1ODIxIGlz IG5vdCBzZXQKIyBDT05GSUdfTUNQNDcyNSBpcyBub3Qgc2V0CiMgQ09ORklHX01DUDQ5MjIgaXMg bm90IHNldAojIENPTkZJR19USV9EQUMwODJTMDg1IGlzIG5vdCBzZXQKIyBDT05GSUdfVElfREFD NTU3MSBpcyBub3Qgc2V0CiMgQ09ORklHX1RJX0RBQzczMTEgaXMgbm90IHNldAojIENPTkZJR19U SV9EQUM3NjEyIGlzIG5vdCBzZXQKIyBDT05GSUdfVkY2MTBfREFDIGlzIG5vdCBzZXQKIyBlbmQg b2YgRGlnaXRhbCB0byBhbmFsb2cgY29udmVydGVycwoKIwojIElJTyBkdW1teSBkcml2ZXIKIwoj IGVuZCBvZiBJSU8gZHVtbXkgZHJpdmVyCgojCiMgRnJlcXVlbmN5IFN5bnRoZXNpemVycyBERFMv UExMCiMKCiMKIyBDbG9jayBHZW5lcmF0b3IvRGlzdHJpYnV0aW9uCiMKIyBDT05GSUdfQUQ5NTIz IGlzIG5vdCBzZXQKIyBlbmQgb2YgQ2xvY2sgR2VuZXJhdG9yL0Rpc3RyaWJ1dGlvbgoKIwojIFBo YXNlLUxvY2tlZCBMb29wIChQTEwpIGZyZXF1ZW5jeSBzeW50aGVzaXplcnMKIwojIENPTkZJR19B REY0MzUwIGlzIG5vdCBzZXQKIyBDT05GSUdfQURGNDM3MSBpcyBub3Qgc2V0CiMgZW5kIG9mIFBo YXNlLUxvY2tlZCBMb29wIChQTEwpIGZyZXF1ZW5jeSBzeW50aGVzaXplcnMKIyBlbmQgb2YgRnJl cXVlbmN5IFN5bnRoZXNpemVycyBERFMvUExMCgojCiMgRGlnaXRhbCBneXJvc2NvcGUgc2Vuc29y cwojCiMgQ09ORklHX0FESVMxNjA4MCBpcyBub3Qgc2V0CiMgQ09ORklHX0FESVMxNjEzMCBpcyBu b3Qgc2V0CiMgQ09ORklHX0FESVMxNjEzNiBpcyBub3Qgc2V0CiMgQ09ORklHX0FESVMxNjI2MCBp cyBub3Qgc2V0CiMgQ09ORklHX0FEWFJTMjkwIGlzIG5vdCBzZXQKIyBDT05GSUdfQURYUlM0NTAg aXMgbm90IHNldAojIENPTkZJR19CTUcxNjAgaXMgbm90IHNldAojIENPTkZJR19GWEFTMjEwMDJD IGlzIG5vdCBzZXQKIyBDT05GSUdfTVBVMzA1MF9JMkMgaXMgbm90IHNldAojIENPTkZJR19JSU9f U1RfR1lST18zQVhJUyBpcyBub3Qgc2V0CiMgQ09ORklHX0lURzMyMDAgaXMgbm90IHNldAojIGVu ZCBvZiBEaWdpdGFsIGd5cm9zY29wZSBzZW5zb3JzCgojCiMgSGVhbHRoIFNlbnNvcnMKIwoKIwoj IEhlYXJ0IFJhdGUgTW9uaXRvcnMKIwojIENPTkZJR19BRkU0NDAzIGlzIG5vdCBzZXQKIyBDT05G SUdfQUZFNDQwNCBpcyBub3Qgc2V0CiMgQ09ORklHX01BWDMwMTAwIGlzIG5vdCBzZXQKIyBDT05G SUdfTUFYMzAxMDIgaXMgbm90IHNldAojIGVuZCBvZiBIZWFydCBSYXRlIE1vbml0b3JzCiMgZW5k IG9mIEhlYWx0aCBTZW5zb3JzCgojCiMgSHVtaWRpdHkgc2Vuc29ycwojCiMgQ09ORklHX0FNMjMx NSBpcyBub3Qgc2V0CiMgQ09ORklHX0RIVDExIGlzIG5vdCBzZXQKIyBDT05GSUdfSERDMTAwWCBp cyBub3Qgc2V0CiMgQ09ORklHX0hEQzIwMTAgaXMgbm90IHNldAojIENPTkZJR19IVFMyMjEgaXMg bm90IHNldAojIENPTkZJR19IVFUyMSBpcyBub3Qgc2V0CiMgQ09ORklHX1NJNzAwNSBpcyBub3Qg c2V0CiMgQ09ORklHX1NJNzAyMCBpcyBub3Qgc2V0CiMgZW5kIG9mIEh1bWlkaXR5IHNlbnNvcnMK CiMKIyBJbmVydGlhbCBtZWFzdXJlbWVudCB1bml0cwojCiMgQ09ORklHX0FESVMxNjQwMCBpcyBu b3Qgc2V0CiMgQ09ORklHX0FESVMxNjQ2MCBpcyBub3Qgc2V0CiMgQ09ORklHX0FESVMxNjQ3NSBp cyBub3Qgc2V0CiMgQ09ORklHX0FESVMxNjQ4MCBpcyBub3Qgc2V0CiMgQ09ORklHX0JNSTE2MF9J MkMgaXMgbm90IHNldAojIENPTkZJR19CTUkxNjBfU1BJIGlzIG5vdCBzZXQKIyBDT05GSUdfRlhP Uzg3MDBfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfRlhPUzg3MDBfU1BJIGlzIG5vdCBzZXQKIyBD T05GSUdfS01YNjEgaXMgbm90IHNldAojIENPTkZJR19JTlZfSUNNNDI2MDBfSTJDIGlzIG5vdCBz ZXQKIyBDT05GSUdfSU5WX0lDTTQyNjAwX1NQSSBpcyBub3Qgc2V0CiMgQ09ORklHX0lOVl9NUFU2 MDUwX0kyQyBpcyBub3Qgc2V0CiMgQ09ORklHX0lOVl9NUFU2MDUwX1NQSSBpcyBub3Qgc2V0CiMg Q09ORklHX0lJT19TVF9MU002RFNYIGlzIG5vdCBzZXQKIyBDT05GSUdfSUlPX1NUX0xTTTlEUzAg aXMgbm90IHNldAojIGVuZCBvZiBJbmVydGlhbCBtZWFzdXJlbWVudCB1bml0cwoKIwojIExpZ2h0 IHNlbnNvcnMKIwojIENPTkZJR19BREpEX1MzMTEgaXMgbm90IHNldAojIENPTkZJR19BRFVYMTAy MCBpcyBub3Qgc2V0CiMgQ09ORklHX0FMMzAxMCBpcyBub3Qgc2V0CiMgQ09ORklHX0FMMzMyMEEg aXMgbm90IHNldAojIENPTkZJR19BUERTOTMwMCBpcyBub3Qgc2V0CiMgQ09ORklHX0FQRFM5OTYw IGlzIG5vdCBzZXQKIyBDT05GSUdfQVM3MzIxMSBpcyBub3Qgc2V0CkNPTkZJR19CSDE3NTA9bQoj IENPTkZJR19CSDE3ODAgaXMgbm90IHNldAojIENPTkZJR19DTTMyMTgxIGlzIG5vdCBzZXQKIyBD T05GSUdfQ00zMjMyIGlzIG5vdCBzZXQKIyBDT05GSUdfQ00zMzIzIGlzIG5vdCBzZXQKIyBDT05G SUdfQ00zNjA1IGlzIG5vdCBzZXQKIyBDT05GSUdfQ00zNjY1MSBpcyBub3Qgc2V0CiMgQ09ORklH X0dQMkFQMDAyIGlzIG5vdCBzZXQKIyBDT05GSUdfR1AyQVAwMjBBMDBGIGlzIG5vdCBzZXQKIyBD T05GSUdfU0VOU09SU19JU0wyOTAxOCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfSVNMMjkw MjggaXMgbm90IHNldAojIENPTkZJR19JU0wyOTEyNSBpcyBub3Qgc2V0CiMgQ09ORklHX0pTQTEy MTIgaXMgbm90IHNldAojIENPTkZJR19SUFIwNTIxIGlzIG5vdCBzZXQKIyBDT05GSUdfTFRSNTAx IGlzIG5vdCBzZXQKIyBDT05GSUdfTFYwMTA0Q1MgaXMgbm90IHNldAojIENPTkZJR19NQVg0NDAw MCBpcyBub3Qgc2V0CiMgQ09ORklHX01BWDQ0MDA5IGlzIG5vdCBzZXQKIyBDT05GSUdfTk9BMTMw NSBpcyBub3Qgc2V0CiMgQ09ORklHX09QVDMwMDEgaXMgbm90IHNldAojIENPTkZJR19QQTEyMjAz MDAxIGlzIG5vdCBzZXQKIyBDT05GSUdfU0kxMTMzIGlzIG5vdCBzZXQKIyBDT05GSUdfU0kxMTQ1 IGlzIG5vdCBzZXQKIyBDT05GSUdfU1RLMzMxMCBpcyBub3Qgc2V0CiMgQ09ORklHX1NUX1VWSVMy NSBpcyBub3Qgc2V0CiMgQ09ORklHX1RDUzM0MTQgaXMgbm90IHNldAojIENPTkZJR19UQ1MzNDcy IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19UU0wyNTYzIGlzIG5vdCBzZXQKIyBDT05GSUdf VFNMMjU4MyBpcyBub3Qgc2V0CiMgQ09ORklHX1RTTDI1OTEgaXMgbm90IHNldAojIENPTkZJR19U U0wyNzcyIGlzIG5vdCBzZXQKIyBDT05GSUdfVFNMNDUzMSBpcyBub3Qgc2V0CiMgQ09ORklHX1VT NTE4MkQgaXMgbm90IHNldAojIENPTkZJR19WQ05MNDAwMCBpcyBub3Qgc2V0CiMgQ09ORklHX1ZD Tkw0MDM1IGlzIG5vdCBzZXQKIyBDT05GSUdfVkVNTDYwMzAgaXMgbm90IHNldAojIENPTkZJR19W RU1MNjA3MCBpcyBub3Qgc2V0CiMgQ09ORklHX1ZMNjE4MCBpcyBub3Qgc2V0CiMgQ09ORklHX1pP UFQyMjAxIGlzIG5vdCBzZXQKIyBlbmQgb2YgTGlnaHQgc2Vuc29ycwoKIwojIE1hZ25ldG9tZXRl ciBzZW5zb3JzCiMKIyBDT05GSUdfQUs4OTc0IGlzIG5vdCBzZXQKIyBDT05GSUdfQUs4OTc1IGlz IG5vdCBzZXQKIyBDT05GSUdfQUswOTkxMSBpcyBub3Qgc2V0CiMgQ09ORklHX0JNQzE1MF9NQUdO X0kyQyBpcyBub3Qgc2V0CiMgQ09ORklHX0JNQzE1MF9NQUdOX1NQSSBpcyBub3Qgc2V0CiMgQ09O RklHX01BRzMxMTAgaXMgbm90IHNldAojIENPTkZJR19NTUMzNTI0MCBpcyBub3Qgc2V0CiMgQ09O RklHX0lJT19TVF9NQUdOXzNBWElTIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19ITUM1ODQz X0kyQyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfSE1DNTg0M19TUEkgaXMgbm90IHNldAoj IENPTkZJR19TRU5TT1JTX1JNMzEwMF9JMkMgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX1JN MzEwMF9TUEkgaXMgbm90IHNldAojIENPTkZJR19ZQU1BSEFfWUFTNTMwIGlzIG5vdCBzZXQKIyBl bmQgb2YgTWFnbmV0b21ldGVyIHNlbnNvcnMKCiMKIyBNdWx0aXBsZXhlcnMKIwojIENPTkZJR19J SU9fTVVYIGlzIG5vdCBzZXQKIyBlbmQgb2YgTXVsdGlwbGV4ZXJzCgojCiMgSW5jbGlub21ldGVy IHNlbnNvcnMKIwojIGVuZCBvZiBJbmNsaW5vbWV0ZXIgc2Vuc29ycwoKIwojIFRyaWdnZXJzIC0g c3RhbmRhbG9uZQojCiMgQ09ORklHX0lJT19JTlRFUlJVUFRfVFJJR0dFUiBpcyBub3Qgc2V0CiMg Q09ORklHX0lJT19TWVNGU19UUklHR0VSIGlzIG5vdCBzZXQKIyBlbmQgb2YgVHJpZ2dlcnMgLSBz dGFuZGFsb25lCgojCiMgTGluZWFyIGFuZCBhbmd1bGFyIHBvc2l0aW9uIHNlbnNvcnMKIwojIGVu ZCBvZiBMaW5lYXIgYW5kIGFuZ3VsYXIgcG9zaXRpb24gc2Vuc29ycwoKIwojIERpZ2l0YWwgcG90 ZW50aW9tZXRlcnMKIwojIENPTkZJR19BRDUxMTAgaXMgbm90IHNldAojIENPTkZJR19BRDUyNzIg aXMgbm90IHNldAojIENPTkZJR19EUzE4MDMgaXMgbm90IHNldAojIENPTkZJR19NQVg1NDMyIGlz IG5vdCBzZXQKIyBDT05GSUdfTUFYNTQ4MSBpcyBub3Qgc2V0CiMgQ09ORklHX01BWDU0ODcgaXMg bm90IHNldAojIENPTkZJR19NQ1A0MDE4IGlzIG5vdCBzZXQKIyBDT05GSUdfTUNQNDEzMSBpcyBu b3Qgc2V0CiMgQ09ORklHX01DUDQ1MzEgaXMgbm90IHNldAojIENPTkZJR19NQ1A0MTAxMCBpcyBu b3Qgc2V0CiMgQ09ORklHX1RQTDAxMDIgaXMgbm90IHNldAojIGVuZCBvZiBEaWdpdGFsIHBvdGVu dGlvbWV0ZXJzCgojCiMgRGlnaXRhbCBwb3RlbnRpb3N0YXRzCiMKIyBDT05GSUdfTE1QOTEwMDAg aXMgbm90IHNldAojIGVuZCBvZiBEaWdpdGFsIHBvdGVudGlvc3RhdHMKCiMKIyBQcmVzc3VyZSBz ZW5zb3JzCiMKIyBDT05GSUdfQUJQMDYwTUcgaXMgbm90IHNldAojIENPTkZJR19CTVAyODAgaXMg bm90IHNldAojIENPTkZJR19ETEhMNjBEIGlzIG5vdCBzZXQKIyBDT05GSUdfRFBTMzEwIGlzIG5v dCBzZXQKIyBDT05GSUdfSFAwMyBpcyBub3Qgc2V0CiMgQ09ORklHX0lDUDEwMTAwIGlzIG5vdCBz ZXQKIyBDT05GSUdfTVBMMTE1X0kyQyBpcyBub3Qgc2V0CiMgQ09ORklHX01QTDExNV9TUEkgaXMg bm90IHNldAojIENPTkZJR19NUEwzMTE1IGlzIG5vdCBzZXQKIyBDT05GSUdfTVM1NjExIGlzIG5v dCBzZXQKIyBDT05GSUdfTVM1NjM3IGlzIG5vdCBzZXQKIyBDT05GSUdfSUlPX1NUX1BSRVNTIGlz IG5vdCBzZXQKIyBDT05GSUdfVDU0MDMgaXMgbm90IHNldAojIENPTkZJR19IUDIwNkMgaXMgbm90 IHNldAojIENPTkZJR19aUEEyMzI2IGlzIG5vdCBzZXQKIyBlbmQgb2YgUHJlc3N1cmUgc2Vuc29y cwoKIwojIExpZ2h0bmluZyBzZW5zb3JzCiMKIyBDT05GSUdfQVMzOTM1IGlzIG5vdCBzZXQKIyBl bmQgb2YgTGlnaHRuaW5nIHNlbnNvcnMKCiMKIyBQcm94aW1pdHkgYW5kIGRpc3RhbmNlIHNlbnNv cnMKIwojIENPTkZJR19JU0wyOTUwMSBpcyBub3Qgc2V0CiMgQ09ORklHX0xJREFSX0xJVEVfVjIg aXMgbm90IHNldAojIENPTkZJR19NQjEyMzIgaXMgbm90IHNldAojIENPTkZJR19QSU5HIGlzIG5v dCBzZXQKIyBDT05GSUdfUkZENzc0MDIgaXMgbm90IHNldAojIENPTkZJR19TUkYwNCBpcyBub3Qg c2V0CiMgQ09ORklHX1NYOTMxMCBpcyBub3Qgc2V0CiMgQ09ORklHX1NYOTUwMCBpcyBub3Qgc2V0 CiMgQ09ORklHX1NSRjA4IGlzIG5vdCBzZXQKIyBDT05GSUdfVkNOTDMwMjAgaXMgbm90IHNldAoj IENPTkZJR19WTDUzTDBYX0kyQyBpcyBub3Qgc2V0CiMgZW5kIG9mIFByb3hpbWl0eSBhbmQgZGlz dGFuY2Ugc2Vuc29ycwoKIwojIFJlc29sdmVyIHRvIGRpZ2l0YWwgY29udmVydGVycwojCiMgQ09O RklHX0FEMlM5MCBpcyBub3Qgc2V0CiMgQ09ORklHX0FEMlMxMjAwIGlzIG5vdCBzZXQKIyBlbmQg b2YgUmVzb2x2ZXIgdG8gZGlnaXRhbCBjb252ZXJ0ZXJzCgojCiMgVGVtcGVyYXR1cmUgc2Vuc29y cwojCiMgQ09ORklHX0xUQzI5ODMgaXMgbm90IHNldAojIENPTkZJR19NQVhJTV9USEVSTU9DT1VQ TEUgaXMgbm90IHNldAojIENPTkZJR19NTFg5MDYxNCBpcyBub3Qgc2V0CiMgQ09ORklHX01MWDkw NjMyIGlzIG5vdCBzZXQKIyBDT05GSUdfVE1QMDA2IGlzIG5vdCBzZXQKIyBDT05GSUdfVE1QMDA3 IGlzIG5vdCBzZXQKIyBDT05GSUdfVE1QMTE3IGlzIG5vdCBzZXQKIyBDT05GSUdfVFNZUzAxIGlz IG5vdCBzZXQKIyBDT05GSUdfVFNZUzAyRCBpcyBub3Qgc2V0CiMgQ09ORklHX01BWDMxODU2IGlz IG5vdCBzZXQKIyBlbmQgb2YgVGVtcGVyYXR1cmUgc2Vuc29ycwoKIyBDT05GSUdfTlRCIGlzIG5v dCBzZXQKIyBDT05GSUdfVk1FX0JVUyBpcyBub3Qgc2V0CkNPTkZJR19QV009eQpDT05GSUdfUFdN X1NZU0ZTPXkKIyBDT05GSUdfUFdNX0RFQlVHIGlzIG5vdCBzZXQKIyBDT05GSUdfUFdNX0FUTUVM X1RDQiBpcyBub3Qgc2V0CkNPTkZJR19QV01fQkNNMjgzNT1tCiMgQ09ORklHX1BXTV9EV0MgaXMg bm90IHNldAojIENPTkZJR19QV01fRlNMX0ZUTSBpcyBub3Qgc2V0CkNPTkZJR19QV01fUENBOTY4 NT1tCiMgQ09ORklHX1BXTV9SQVNQQkVSUllQSV9QT0UgaXMgbm90IHNldAojIENPTkZJR19QV01f U1RNUEUgaXMgbm90IHNldAoKIwojIElSUSBjaGlwIHN1cHBvcnQKIwpDT05GSUdfSVJRQ0hJUD15 CkNPTkZJR19BUk1fR0lDPXkKQ09ORklHX0FSTV9HSUNfTUFYX05SPTEKQ09ORklHX0FSTV9HSUNf VjJNPXkKQ09ORklHX0FSTV9HSUNfVjM9eQpDT05GSUdfQVJNX0dJQ19WM19JVFM9eQpDT05GSUdf QVJNX0dJQ19WM19JVFNfUENJPXkKIyBDT05GSUdfQUxfRklDIGlzIG5vdCBzZXQKQ09ORklHX0JS Q01TVEJfTDJfSVJRPXkKQ09ORklHX1BBUlRJVElPTl9QRVJDUFU9eQojIGVuZCBvZiBJUlEgY2hp cCBzdXBwb3J0CgojIENPTkZJR19JUEFDS19CVVMgaXMgbm90IHNldApDT05GSUdfUkVTRVRfQ09O VFJPTExFUj15CkNPTkZJR19SRVNFVF9SQVNQQkVSUllQST15CkNPTkZJR19SRVNFVF9TSU1QTEU9 eQojIENPTkZJR19SRVNFVF9USV9TWVNDT04gaXMgbm90IHNldAoKIwojIFBIWSBTdWJzeXN0ZW0K IwpDT05GSUdfR0VORVJJQ19QSFk9eQojIENPTkZJR19QSFlfWEdFTkUgaXMgbm90IHNldAojIENP TkZJR19QSFlfQ0FOX1RSQU5TQ0VJVkVSIGlzIG5vdCBzZXQKIyBDT05GSUdfQkNNX0tPTkFfVVNC Ml9QSFkgaXMgbm90IHNldAojIENPTkZJR19QSFlfQ0FERU5DRV9UT1JSRU5UIGlzIG5vdCBzZXQK IyBDT05GSUdfUEhZX0NBREVOQ0VfRFBIWSBpcyBub3Qgc2V0CiMgQ09ORklHX1BIWV9DQURFTkNF X1NJRVJSQSBpcyBub3Qgc2V0CiMgQ09ORklHX1BIWV9DQURFTkNFX1NBTFZPIGlzIG5vdCBzZXQK IyBDT05GSUdfUEhZX0ZTTF9JTVg4TVFfVVNCIGlzIG5vdCBzZXQKIyBDT05GSUdfUEhZX01JWEVM X01JUElfRFBIWSBpcyBub3Qgc2V0CiMgQ09ORklHX1BIWV9QWEFfMjhOTV9IU0lDIGlzIG5vdCBz ZXQKIyBDT05GSUdfUEhZX1BYQV8yOE5NX1VTQjIgaXMgbm90IHNldAojIENPTkZJR19QSFlfQ1BD QVBfVVNCIGlzIG5vdCBzZXQKIyBDT05GSUdfUEhZX01BUFBIT05FX01ETTY2MDAgaXMgbm90IHNl dAojIENPTkZJR19QSFlfT0NFTE9UX1NFUkRFUyBpcyBub3Qgc2V0CiMgQ09ORklHX1BIWV9TQU1T VU5HX1VTQjIgaXMgbm90IHNldAojIGVuZCBvZiBQSFkgU3Vic3lzdGVtCgojIENPTkZJR19QT1dF UkNBUCBpcyBub3Qgc2V0CiMgQ09ORklHX01DQiBpcyBub3Qgc2V0CgojCiMgUGVyZm9ybWFuY2Ug bW9uaXRvciBzdXBwb3J0CiMKIyBDT05GSUdfQVJNX0NDSV9QTVUgaXMgbm90IHNldAojIENPTkZJ R19BUk1fQ0NOIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJNX0NNTiBpcyBub3Qgc2V0CkNPTkZJR19B Uk1fUE1VPXkKIyBDT05GSUdfQVJNX0RTVV9QTVUgaXMgbm90IHNldAojIENPTkZJR19BUk1fU1BF X1BNVSBpcyBub3Qgc2V0CiMgZW5kIG9mIFBlcmZvcm1hbmNlIG1vbml0b3Igc3VwcG9ydAoKIyBD T05GSUdfUkFTIGlzIG5vdCBzZXQKIyBDT05GSUdfVVNCNCBpcyBub3Qgc2V0CgojCiMgQW5kcm9p ZAojCiMgQ09ORklHX0FORFJPSUQgaXMgbm90IHNldAojIGVuZCBvZiBBbmRyb2lkCgojIENPTkZJ R19MSUJOVkRJTU0gaXMgbm90IHNldAojIENPTkZJR19EQVggaXMgbm90IHNldApDT05GSUdfTlZN RU09eQpDT05GSUdfTlZNRU1fU1lTRlM9eQpDT05GSUdfTlZNRU1fUk1FTT1tCgojCiMgSFcgdHJh Y2luZyBzdXBwb3J0CiMKIyBDT05GSUdfU1RNIGlzIG5vdCBzZXQKIyBDT05GSUdfSU5URUxfVEgg aXMgbm90IHNldAojIGVuZCBvZiBIVyB0cmFjaW5nIHN1cHBvcnQKCiMgQ09ORklHX0ZQR0EgaXMg bm90IHNldAojIENPTkZJR19GU0kgaXMgbm90IHNldAojIENPTkZJR19URUUgaXMgbm90IHNldApD T05GSUdfUE1fT1BQPXkKIyBDT05GSUdfU0lPWCBpcyBub3Qgc2V0CiMgQ09ORklHX1NMSU1CVVMg aXMgbm90IHNldAojIENPTkZJR19JTlRFUkNPTk5FQ1QgaXMgbm90IHNldAojIENPTkZJR19DT1VO VEVSIGlzIG5vdCBzZXQKIyBDT05GSUdfTU9TVCBpcyBub3Qgc2V0CiMgZW5kIG9mIERldmljZSBE cml2ZXJzCgojCiMgRmlsZSBzeXN0ZW1zCiMKQ09ORklHX0RDQUNIRV9XT1JEX0FDQ0VTUz15CiMg Q09ORklHX1ZBTElEQVRFX0ZTX1BBUlNFUiBpcyBub3Qgc2V0CkNPTkZJR19GU19JT01BUD15CiMg Q09ORklHX0VYVDJfRlMgaXMgbm90IHNldAojIENPTkZJR19FWFQzX0ZTIGlzIG5vdCBzZXQKQ09O RklHX0VYVDRfRlM9eQpDT05GSUdfRVhUNF9VU0VfRk9SX0VYVDI9eQpDT05GSUdfRVhUNF9GU19Q T1NJWF9BQ0w9eQpDT05GSUdfRVhUNF9GU19TRUNVUklUWT15CiMgQ09ORklHX0VYVDRfREVCVUcg aXMgbm90IHNldApDT05GSUdfSkJEMj15CiMgQ09ORklHX0pCRDJfREVCVUcgaXMgbm90IHNldApD T05GSUdfRlNfTUJDQUNIRT15CiMgQ09ORklHX1JFSVNFUkZTX0ZTIGlzIG5vdCBzZXQKIyBDT05G SUdfSkZTX0ZTIGlzIG5vdCBzZXQKIyBDT05GSUdfWEZTX0ZTIGlzIG5vdCBzZXQKIyBDT05GSUdf R0ZTMl9GUyBpcyBub3Qgc2V0CiMgQ09ORklHX09DRlMyX0ZTIGlzIG5vdCBzZXQKQ09ORklHX0JU UkZTX0ZTPXkKQ09ORklHX0JUUkZTX0ZTX1BPU0lYX0FDTD15CiMgQ09ORklHX0JUUkZTX0ZTX0NI RUNLX0lOVEVHUklUWSBpcyBub3Qgc2V0CiMgQ09ORklHX0JUUkZTX0ZTX1JVTl9TQU5JVFlfVEVT VFMgaXMgbm90IHNldAojIENPTkZJR19CVFJGU19ERUJVRyBpcyBub3Qgc2V0CiMgQ09ORklHX0JU UkZTX0FTU0VSVCBpcyBub3Qgc2V0CiMgQ09ORklHX0JUUkZTX0ZTX1JFRl9WRVJJRlkgaXMgbm90 IHNldAojIENPTkZJR19OSUxGUzJfRlMgaXMgbm90IHNldAojIENPTkZJR19GMkZTX0ZTIGlzIG5v dCBzZXQKIyBDT05GSUdfRlNfREFYIGlzIG5vdCBzZXQKQ09ORklHX0ZTX1BPU0lYX0FDTD15CkNP TkZJR19FWFBPUlRGUz15CiMgQ09ORklHX0VYUE9SVEZTX0JMT0NLX09QUyBpcyBub3Qgc2V0CkNP TkZJR19GSUxFX0xPQ0tJTkc9eQpDT05GSUdfRlNfRU5DUllQVElPTj15CkNPTkZJR19GU19FTkNS WVBUSU9OX0FMR1M9eQojIENPTkZJR19GU19WRVJJVFkgaXMgbm90IHNldApDT05GSUdfRlNOT1RJ Rlk9eQpDT05GSUdfRE5PVElGWT15CkNPTkZJR19JTk9USUZZX1VTRVI9eQojIENPTkZJR19GQU5P VElGWSBpcyBub3Qgc2V0CiMgQ09ORklHX1FVT1RBIGlzIG5vdCBzZXQKQ09ORklHX0FVVE9GUzRf RlM9eQpDT05GSUdfQVVUT0ZTX0ZTPXkKQ09ORklHX0ZVU0VfRlM9bQpDT05GSUdfQ1VTRT1tCiMg Q09ORklHX1ZJUlRJT19GUyBpcyBub3Qgc2V0CiMgQ09ORklHX09WRVJMQVlfRlMgaXMgbm90IHNl dAoKIwojIENhY2hlcwojCiMgQ09ORklHX0ZTQ0FDSEUgaXMgbm90IHNldAojIGVuZCBvZiBDYWNo ZXMKCiMKIyBDRC1ST00vRFZEIEZpbGVzeXN0ZW1zCiMKIyBDT05GSUdfSVNPOTY2MF9GUyBpcyBu b3Qgc2V0CiMgQ09ORklHX1VERl9GUyBpcyBub3Qgc2V0CiMgZW5kIG9mIENELVJPTS9EVkQgRmls ZXN5c3RlbXMKCiMKIyBET1MvRkFUL0VYRkFUL05UIEZpbGVzeXN0ZW1zCiMKQ09ORklHX0ZBVF9G Uz15CkNPTkZJR19NU0RPU19GUz15CkNPTkZJR19WRkFUX0ZTPXkKIyBDT05GSUdfVkZBVF9GU19O T19EVUFMTkFNRVMgaXMgbm90IHNldApDT05GSUdfRkFUX0RFRkFVTFRfQ09ERVBBR0U9NDM3CkNP TkZJR19GQVRfREVGQVVMVF9JT0NIQVJTRVQ9Imlzbzg4NTktMSIKIyBDT05GSUdfVkZBVF9OT19D UkVBVEVfV0lUSF9MT05HTkFNRVMgaXMgbm90IHNldAojIENPTkZJR19GQVRfREVGQVVMVF9VVEY4 IGlzIG5vdCBzZXQKIyBDT05GSUdfRVhGQVRfRlMgaXMgbm90IHNldAojIENPTkZJR19OVEZTX0ZT IGlzIG5vdCBzZXQKIyBDT05GSUdfTlRGUzNfRlMgaXMgbm90IHNldAojIGVuZCBvZiBET1MvRkFU L0VYRkFUL05UIEZpbGVzeXN0ZW1zCgojCiMgUHNldWRvIGZpbGVzeXN0ZW1zCiMKQ09ORklHX1BS T0NfRlM9eQpDT05GSUdfUFJPQ19LQ09SRT15CkNPTkZJR19QUk9DX1NZU0NUTD15CkNPTkZJR19Q Uk9DX1BBR0VfTU9OSVRPUj15CiMgQ09ORklHX1BST0NfQ0hJTERSRU4gaXMgbm90IHNldApDT05G SUdfS0VSTkZTPXkKQ09ORklHX1NZU0ZTPXkKQ09ORklHX1RNUEZTPXkKQ09ORklHX1RNUEZTX1BP U0lYX0FDTD15CkNPTkZJR19UTVBGU19YQVRUUj15CiMgQ09ORklHX1RNUEZTX0lOT0RFNjQgaXMg bm90IHNldApDT05GSUdfQVJDSF9TVVBQT1JUU19IVUdFVExCRlM9eQojIENPTkZJR19IVUdFVExC RlMgaXMgbm90IHNldApDT05GSUdfTUVNRkRfQ1JFQVRFPXkKQ09ORklHX0FSQ0hfSEFTX0dJR0FO VElDX1BBR0U9eQpDT05GSUdfQ09ORklHRlNfRlM9bQpDT05GSUdfRUZJVkFSX0ZTPW0KIyBlbmQg b2YgUHNldWRvIGZpbGVzeXN0ZW1zCgpDT05GSUdfTUlTQ19GSUxFU1lTVEVNUz15CiMgQ09ORklH X09SQU5HRUZTX0ZTIGlzIG5vdCBzZXQKIyBDT05GSUdfQURGU19GUyBpcyBub3Qgc2V0CiMgQ09O RklHX0FGRlNfRlMgaXMgbm90IHNldAojIENPTkZJR19FQ1JZUFRfRlMgaXMgbm90IHNldAojIENP TkZJR19IRlNfRlMgaXMgbm90IHNldAojIENPTkZJR19IRlNQTFVTX0ZTIGlzIG5vdCBzZXQKIyBD T05GSUdfQkVGU19GUyBpcyBub3Qgc2V0CiMgQ09ORklHX0JGU19GUyBpcyBub3Qgc2V0CiMgQ09O RklHX0VGU19GUyBpcyBub3Qgc2V0CiMgQ09ORklHX1lBRkZTX0ZTIGlzIG5vdCBzZXQKIyBDT05G SUdfSkZGUzJfRlMgaXMgbm90IHNldAojIENPTkZJR19DUkFNRlMgaXMgbm90IHNldAojIENPTkZJ R19TUVVBU0hGUyBpcyBub3Qgc2V0CiMgQ09ORklHX1ZYRlNfRlMgaXMgbm90IHNldAojIENPTkZJ R19NSU5JWF9GUyBpcyBub3Qgc2V0CiMgQ09ORklHX09NRlNfRlMgaXMgbm90IHNldAojIENPTkZJ R19IUEZTX0ZTIGlzIG5vdCBzZXQKIyBDT05GSUdfUU5YNEZTX0ZTIGlzIG5vdCBzZXQKIyBDT05G SUdfUU5YNkZTX0ZTIGlzIG5vdCBzZXQKQ09ORklHX1JPTUZTX0ZTPW0KQ09ORklHX1JPTUZTX0JB Q0tFRF9CWV9CTE9DSz15CiMgQ09ORklHX1JPTUZTX0JBQ0tFRF9CWV9NVEQgaXMgbm90IHNldAoj IENPTkZJR19ST01GU19CQUNLRURfQllfQk9USCBpcyBub3Qgc2V0CkNPTkZJR19ST01GU19PTl9C TE9DSz15CiMgQ09ORklHX1BTVE9SRSBpcyBub3Qgc2V0CiMgQ09ORklHX1NZU1ZfRlMgaXMgbm90 IHNldAojIENPTkZJR19VRlNfRlMgaXMgbm90IHNldAojIENPTkZJR19FUk9GU19GUyBpcyBub3Qg c2V0CiMgQ09ORklHX0FVRlNfRlMgaXMgbm90IHNldApDT05GSUdfTkVUV09SS19GSUxFU1lTVEVN Uz15CkNPTkZJR19ORlNfRlM9eQpDT05GSUdfTkZTX1YyPXkKQ09ORklHX05GU19ERUZfRklMRV9J T19TSVpFPTQwOTYKQ09ORklHX05GU19WMz15CiMgQ09ORklHX05GU19WM19BQ0wgaXMgbm90IHNl dApDT05GSUdfTkZTX1Y0PXkKIyBDT05GSUdfTkZTX1NXQVAgaXMgbm90IHNldAojIENPTkZJR19O RlNfVjRfMSBpcyBub3Qgc2V0CkNPTkZJR19ST09UX05GUz15CiMgQ09ORklHX05GU19VU0VfTEVH QUNZX0ROUyBpcyBub3Qgc2V0CkNPTkZJR19ORlNfVVNFX0tFUk5FTF9ETlM9eQojIENPTkZJR19O RlNfRElTQUJMRV9VRFBfU1VQUE9SVCBpcyBub3Qgc2V0CiMgQ09ORklHX05GU0QgaXMgbm90IHNl dApDT05GSUdfR1JBQ0VfUEVSSU9EPXkKQ09ORklHX0xPQ0tEPXkKQ09ORklHX0xPQ0tEX1Y0PXkK Q09ORklHX05GU19DT01NT049eQpDT05GSUdfU1VOUlBDPXkKQ09ORklHX1NVTlJQQ19HU1M9eQpD T05GSUdfUlBDU0VDX0dTU19LUkI1PXkKIyBDT05GSUdfU1VOUlBDX0RJU0FCTEVfSU5TRUNVUkVf RU5DVFlQRVMgaXMgbm90IHNldAojIENPTkZJR19TVU5SUENfREVCVUcgaXMgbm90IHNldAojIENP TkZJR19DRVBIX0ZTIGlzIG5vdCBzZXQKQ09ORklHX0NJRlM9eQpDT05GSUdfQ0lGU19TVEFUUzI9 eQpDT05GSUdfQ0lGU19BTExPV19JTlNFQ1VSRV9MRUdBQ1k9eQojIENPTkZJR19DSUZTX1VQQ0FM TCBpcyBub3Qgc2V0CkNPTkZJR19DSUZTX1hBVFRSPXkKQ09ORklHX0NJRlNfUE9TSVg9eQpDT05G SUdfQ0lGU19ERUJVRz15CiMgQ09ORklHX0NJRlNfREVCVUcyIGlzIG5vdCBzZXQKIyBDT05GSUdf Q0lGU19ERUJVR19EVU1QX0tFWVMgaXMgbm90IHNldAojIENPTkZJR19DSUZTX0RGU19VUENBTEwg aXMgbm90IHNldAojIENPTkZJR19DSUZTX1NXTl9VUENBTEwgaXMgbm90IHNldAojIENPTkZJR19D SUZTX1JPT1QgaXMgbm90IHNldAojIENPTkZJR19TTUJfU0VSVkVSIGlzIG5vdCBzZXQKQ09ORklH X1NNQkZTX0NPTU1PTj15CiMgQ09ORklHX0NPREFfRlMgaXMgbm90IHNldAojIENPTkZJR19BRlNf RlMgaXMgbm90IHNldApDT05GSUdfTkxTPXkKQ09ORklHX05MU19ERUZBVUxUPSJpc284ODU5LTEi CkNPTkZJR19OTFNfQ09ERVBBR0VfNDM3PXkKQ09ORklHX05MU19DT0RFUEFHRV83Mzc9bQpDT05G SUdfTkxTX0NPREVQQUdFXzc3NT1tCkNPTkZJR19OTFNfQ09ERVBBR0VfODUwPW0KQ09ORklHX05M U19DT0RFUEFHRV84NTI9bQpDT05GSUdfTkxTX0NPREVQQUdFXzg1NT1tCkNPTkZJR19OTFNfQ09E RVBBR0VfODU3PW0KQ09ORklHX05MU19DT0RFUEFHRV84NjA9bQpDT05GSUdfTkxTX0NPREVQQUdF Xzg2MT1tCkNPTkZJR19OTFNfQ09ERVBBR0VfODYyPW0KQ09ORklHX05MU19DT0RFUEFHRV84NjM9 bQpDT05GSUdfTkxTX0NPREVQQUdFXzg2ND1tCkNPTkZJR19OTFNfQ09ERVBBR0VfODY1PW0KQ09O RklHX05MU19DT0RFUEFHRV84NjY9bQpDT05GSUdfTkxTX0NPREVQQUdFXzg2OT1tCkNPTkZJR19O TFNfQ09ERVBBR0VfOTM2PW0KQ09ORklHX05MU19DT0RFUEFHRV85NTA9bQpDT05GSUdfTkxTX0NP REVQQUdFXzkzMj1tCkNPTkZJR19OTFNfQ09ERVBBR0VfOTQ5PW0KQ09ORklHX05MU19DT0RFUEFH RV84NzQ9bQpDT05GSUdfTkxTX0lTTzg4NTlfOD1tCkNPTkZJR19OTFNfQ09ERVBBR0VfMTI1MD1t CkNPTkZJR19OTFNfQ09ERVBBR0VfMTI1MT1tCkNPTkZJR19OTFNfQVNDSUk9bQpDT05GSUdfTkxT X0lTTzg4NTlfMT15CkNPTkZJR19OTFNfSVNPODg1OV8yPW0KQ09ORklHX05MU19JU084ODU5XzM9 bQpDT05GSUdfTkxTX0lTTzg4NTlfND1tCkNPTkZJR19OTFNfSVNPODg1OV81PW0KQ09ORklHX05M U19JU084ODU5XzY9bQpDT05GSUdfTkxTX0lTTzg4NTlfNz1tCkNPTkZJR19OTFNfSVNPODg1OV85 PW0KQ09ORklHX05MU19JU084ODU5XzEzPW0KQ09ORklHX05MU19JU084ODU5XzE0PW0KQ09ORklH X05MU19JU084ODU5XzE1PW0KQ09ORklHX05MU19LT0k4X1I9bQpDT05GSUdfTkxTX0tPSThfVT1t CiMgQ09ORklHX05MU19NQUNfUk9NQU4gaXMgbm90IHNldAojIENPTkZJR19OTFNfTUFDX0NFTFRJ QyBpcyBub3Qgc2V0CiMgQ09ORklHX05MU19NQUNfQ0VOVEVVUk8gaXMgbm90IHNldAojIENPTkZJ R19OTFNfTUFDX0NST0FUSUFOIGlzIG5vdCBzZXQKIyBDT05GSUdfTkxTX01BQ19DWVJJTExJQyBp cyBub3Qgc2V0CiMgQ09ORklHX05MU19NQUNfR0FFTElDIGlzIG5vdCBzZXQKIyBDT05GSUdfTkxT X01BQ19HUkVFSyBpcyBub3Qgc2V0CiMgQ09ORklHX05MU19NQUNfSUNFTEFORCBpcyBub3Qgc2V0 CiMgQ09ORklHX05MU19NQUNfSU5VSVQgaXMgbm90IHNldAojIENPTkZJR19OTFNfTUFDX1JPTUFO SUFOIGlzIG5vdCBzZXQKIyBDT05GSUdfTkxTX01BQ19UVVJLSVNIIGlzIG5vdCBzZXQKQ09ORklH X05MU19VVEY4PW0KIyBDT05GSUdfRExNIGlzIG5vdCBzZXQKIyBDT05GSUdfVU5JQ09ERSBpcyBu b3Qgc2V0CkNPTkZJR19JT19XUT15CiMgZW5kIG9mIEZpbGUgc3lzdGVtcwoKIwojIFNlY3VyaXR5 IG9wdGlvbnMKIwpDT05GSUdfS0VZUz15CiMgQ09ORklHX0tFWVNfUkVRVUVTVF9DQUNIRSBpcyBu b3Qgc2V0CiMgQ09ORklHX1BFUlNJU1RFTlRfS0VZUklOR1MgaXMgbm90IHNldApDT05GSUdfRU5D UllQVEVEX0tFWVM9eQojIENPTkZJR19LRVlfREhfT1BFUkFUSU9OUyBpcyBub3Qgc2V0CiMgQ09O RklHX1NFQ1VSSVRZX0RNRVNHX1JFU1RSSUNUIGlzIG5vdCBzZXQKQ09ORklHX1NFQ1VSSVRZPXkK IyBDT05GSUdfU0VDVVJJVFlGUyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFQ1VSSVRZX05FVFdPUksg aXMgbm90IHNldApDT05GSUdfU0VDVVJJVFlfUEFUSD15CkNPTkZJR19IQVZFX0hBUkRFTkVEX1VT RVJDT1BZX0FMTE9DQVRPUj15CiMgQ09ORklHX0hBUkRFTkVEX1VTRVJDT1BZIGlzIG5vdCBzZXQK IyBDT05GSUdfRk9SVElGWV9TT1VSQ0UgaXMgbm90IHNldAojIENPTkZJR19TVEFUSUNfVVNFUk1P REVIRUxQRVIgaXMgbm90IHNldAojIENPTkZJR19TRUNVUklUWV9TTUFDSyBpcyBub3Qgc2V0CiMg Q09ORklHX1NFQ1VSSVRZX1RPTU9ZTyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFQ1VSSVRZX0FQUEFS TU9SIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VDVVJJVFlfTE9BRFBJTiBpcyBub3Qgc2V0CiMgQ09O RklHX1NFQ1VSSVRZX1lBTUEgaXMgbm90IHNldAojIENPTkZJR19TRUNVUklUWV9TQUZFU0VUSUQg aXMgbm90IHNldAojIENPTkZJR19TRUNVUklUWV9MT0NLRE9XTl9MU00gaXMgbm90IHNldApDT05G SUdfU0VDVVJJVFlfTEFORExPQ0s9eQpDT05GSUdfSU5URUdSSVRZPXkKIyBDT05GSUdfSU5URUdS SVRZX1NJR05BVFVSRSBpcyBub3Qgc2V0CiMgQ09ORklHX0lNQSBpcyBub3Qgc2V0CiMgQ09ORklH X0lNQV9TRUNVUkVfQU5EX09SX1RSVVNURURfQk9PVCBpcyBub3Qgc2V0CiMgQ09ORklHX0VWTSBp cyBub3Qgc2V0CkNPTkZJR19ERUZBVUxUX1NFQ1VSSVRZX0RBQz15CkNPTkZJR19MU009ImxhbmRs b2NrLGxvY2tkb3duLHlhbWEsbG9hZHBpbixzYWZlc2V0aWQsaW50ZWdyaXR5LGJwZiIKCiMKIyBL ZXJuZWwgaGFyZGVuaW5nIG9wdGlvbnMKIwoKIwojIE1lbW9yeSBpbml0aWFsaXphdGlvbgojCkNP TkZJR19JTklUX1NUQUNLX05PTkU9eQojIENPTkZJR19HQ0NfUExVR0lOX1NUUlVDVExFQUtfVVNF UiBpcyBub3Qgc2V0CiMgQ09ORklHX0dDQ19QTFVHSU5fU1RSVUNUTEVBS19CWVJFRiBpcyBub3Qg c2V0CiMgQ09ORklHX0dDQ19QTFVHSU5fU1RSVUNUTEVBS19CWVJFRl9BTEwgaXMgbm90IHNldAoj IENPTkZJR19HQ0NfUExVR0lOX1NUQUNLTEVBSyBpcyBub3Qgc2V0CiMgQ09ORklHX0lOSVRfT05f QUxMT0NfREVGQVVMVF9PTiBpcyBub3Qgc2V0CiMgQ09ORklHX0lOSVRfT05fRlJFRV9ERUZBVUxU X09OIGlzIG5vdCBzZXQKQ09ORklHX0NDX0hBU19aRVJPX0NBTExfVVNFRF9SRUdTPXkKIyBDT05G SUdfWkVST19DQUxMX1VTRURfUkVHUyBpcyBub3Qgc2V0CiMgZW5kIG9mIE1lbW9yeSBpbml0aWFs aXphdGlvbgojIGVuZCBvZiBLZXJuZWwgaGFyZGVuaW5nIG9wdGlvbnMKIyBlbmQgb2YgU2VjdXJp dHkgb3B0aW9ucwoKQ09ORklHX1hPUl9CTE9DS1M9eQpDT05GSUdfQVNZTkNfQ09SRT15CkNPTkZJ R19BU1lOQ19NRU1DUFk9eQpDT05GSUdfQVNZTkNfWE9SPXkKQ09ORklHX0FTWU5DX1BRPXkKQ09O RklHX0FTWU5DX1JBSUQ2X1JFQ09WPXkKQ09ORklHX0NSWVBUTz15CgojCiMgQ3J5cHRvIGNvcmUg b3IgaGVscGVyCiMKQ09ORklHX0NSWVBUT19BTEdBUEk9eQpDT05GSUdfQ1JZUFRPX0FMR0FQSTI9 eQpDT05GSUdfQ1JZUFRPX0FFQUQ9eQpDT05GSUdfQ1JZUFRPX0FFQUQyPXkKQ09ORklHX0NSWVBU T19TS0NJUEhFUj15CkNPTkZJR19DUllQVE9fU0tDSVBIRVIyPXkKQ09ORklHX0NSWVBUT19IQVNI PXkKQ09ORklHX0NSWVBUT19IQVNIMj15CkNPTkZJR19DUllQVE9fUk5HPXkKQ09ORklHX0NSWVBU T19STkcyPXkKQ09ORklHX0NSWVBUT19STkdfREVGQVVMVD15CkNPTkZJR19DUllQVE9fQUtDSVBI RVIyPXkKQ09ORklHX0NSWVBUT19BS0NJUEhFUj15CkNPTkZJR19DUllQVE9fS1BQMj15CkNPTkZJ R19DUllQVE9fS1BQPXkKQ09ORklHX0NSWVBUT19BQ09NUDI9eQpDT05GSUdfQ1JZUFRPX01BTkFH RVI9eQpDT05GSUdfQ1JZUFRPX01BTkFHRVIyPXkKIyBDT05GSUdfQ1JZUFRPX1VTRVIgaXMgbm90 IHNldApDT05GSUdfQ1JZUFRPX01BTkFHRVJfRElTQUJMRV9URVNUUz15CkNPTkZJR19DUllQVE9f R0YxMjhNVUw9eQpDT05GSUdfQ1JZUFRPX05VTEw9eQpDT05GSUdfQ1JZUFRPX05VTEwyPXkKIyBD T05GSUdfQ1JZUFRPX1BDUllQVCBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBUT19DUllQVEQgaXMg bm90IHNldApDT05GSUdfQ1JZUFRPX0FVVEhFTkM9eQpDT05GSUdfQ1JZUFRPX1RFU1Q9bQoKIwoj IFB1YmxpYy1rZXkgY3J5cHRvZ3JhcGh5CiMKQ09ORklHX0NSWVBUT19SU0E9eQojIENPTkZJR19D UllQVE9fREggaXMgbm90IHNldApDT05GSUdfQ1JZUFRPX0VDQz15CkNPTkZJR19DUllQVE9fRUNE SD15CiMgQ09ORklHX0NSWVBUT19FQ0RTQSBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBUT19FQ1JE U0EgaXMgbm90IHNldAojIENPTkZJR19DUllQVE9fU00yIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZ UFRPX0NVUlZFMjU1MTkgaXMgbm90IHNldAoKIwojIEF1dGhlbnRpY2F0ZWQgRW5jcnlwdGlvbiB3 aXRoIEFzc29jaWF0ZWQgRGF0YQojCkNPTkZJR19DUllQVE9fQ0NNPXkKQ09ORklHX0NSWVBUT19H Q009eQojIENPTkZJR19DUllQVE9fQ0hBQ0hBMjBQT0xZMTMwNSBpcyBub3Qgc2V0CiMgQ09ORklH X0NSWVBUT19BRUdJUzEyOCBpcyBub3Qgc2V0CkNPTkZJR19DUllQVE9fU0VRSVY9eQpDT05GSUdf Q1JZUFRPX0VDSEFJTklWPXkKCiMKIyBCbG9jayBtb2RlcwojCkNPTkZJR19DUllQVE9fQ0JDPXkK IyBDT05GSUdfQ1JZUFRPX0NGQiBpcyBub3Qgc2V0CkNPTkZJR19DUllQVE9fQ1RSPXkKQ09ORklH X0NSWVBUT19DVFM9eQpDT05GSUdfQ1JZUFRPX0VDQj15CiMgQ09ORklHX0NSWVBUT19MUlcgaXMg bm90IHNldAojIENPTkZJR19DUllQVE9fT0ZCIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX1BD QkMgaXMgbm90IHNldApDT05GSUdfQ1JZUFRPX1hUUz15CiMgQ09ORklHX0NSWVBUT19LRVlXUkFQ IGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX0FESUFOVFVNIGlzIG5vdCBzZXQKQ09ORklHX0NS WVBUT19FU1NJVj15CgojCiMgSGFzaCBtb2RlcwojCkNPTkZJR19DUllQVE9fQ01BQz15CkNPTkZJ R19DUllQVE9fSE1BQz15CkNPTkZJR19DUllQVE9fWENCQz1tCiMgQ09ORklHX0NSWVBUT19WTUFD IGlzIG5vdCBzZXQKCiMKIyBEaWdlc3QKIwpDT05GSUdfQ1JZUFRPX0NSQzMyQz15CiMgQ09ORklH X0NSWVBUT19DUkMzMiBpcyBub3Qgc2V0CkNPTkZJR19DUllQVE9fWFhIQVNIPXkKQ09ORklHX0NS WVBUT19CTEFLRTJCPXkKQ09ORklHX0NSWVBUT19DUkNUMTBESUY9bQpDT05GSUdfQ1JZUFRPX0dI QVNIPXkKIyBDT05GSUdfQ1JZUFRPX1BPTFkxMzA1IGlzIG5vdCBzZXQKQ09ORklHX0NSWVBUT19N RDQ9eQpDT05GSUdfQ1JZUFRPX01ENT15CkNPTkZJR19DUllQVE9fTUlDSEFFTF9NSUM9eQojIENP TkZJR19DUllQVE9fUk1EMTYwIGlzIG5vdCBzZXQKQ09ORklHX0NSWVBUT19TSEExPXkKQ09ORklH X0NSWVBUT19TSEEyNTY9eQpDT05GSUdfQ1JZUFRPX1NIQTUxMj15CiMgQ09ORklHX0NSWVBUT19T SEEzIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX1NNMyBpcyBub3Qgc2V0CiMgQ09ORklHX0NS WVBUT19TVFJFRUJPRyBpcyBub3Qgc2V0CkNPTkZJR19DUllQVE9fV1A1MTI9bQoKIwojIENpcGhl cnMKIwpDT05GSUdfQ1JZUFRPX0FFUz15CiMgQ09ORklHX0NSWVBUT19BRVNfVEkgaXMgbm90IHNl dApDT05GSUdfQ1JZUFRPX0JMT1dGSVNIPW0KQ09ORklHX0NSWVBUT19CTE9XRklTSF9DT01NT049 bQpDT05GSUdfQ1JZUFRPX0NBTUVMTElBPW0KQ09ORklHX0NSWVBUT19DQVNUX0NPTU1PTj1tCkNP TkZJR19DUllQVE9fQ0FTVDU9bQpDT05GSUdfQ1JZUFRPX0NBU1Q2PW0KQ09ORklHX0NSWVBUT19E RVM9eQojIENPTkZJR19DUllQVE9fRkNSWVBUIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX0NI QUNIQTIwIGlzIG5vdCBzZXQKQ09ORklHX0NSWVBUT19TRVJQRU5UPW0KIyBDT05GSUdfQ1JZUFRP X1NNNCBpcyBub3Qgc2V0CkNPTkZJR19DUllQVE9fVFdPRklTSD1tCkNPTkZJR19DUllQVE9fVFdP RklTSF9DT01NT049bQoKIwojIENvbXByZXNzaW9uCiMKQ09ORklHX0NSWVBUT19ERUZMQVRFPXkK IyBDT05GSUdfQ1JZUFRPX0xaTyBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBUT184NDIgaXMgbm90 IHNldAojIENPTkZJR19DUllQVE9fTFo0IGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX0xaNEhD IGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX1pTVEQgaXMgbm90IHNldAoKIwojIFJhbmRvbSBO dW1iZXIgR2VuZXJhdGlvbgojCiMgQ09ORklHX0NSWVBUT19BTlNJX0NQUk5HIGlzIG5vdCBzZXQK Q09ORklHX0NSWVBUT19EUkJHX01FTlU9eQpDT05GSUdfQ1JZUFRPX0RSQkdfSE1BQz15CiMgQ09O RklHX0NSWVBUT19EUkJHX0hBU0ggaXMgbm90IHNldAojIENPTkZJR19DUllQVE9fRFJCR19DVFIg aXMgbm90IHNldApDT05GSUdfQ1JZUFRPX0RSQkc9eQpDT05GSUdfQ1JZUFRPX0pJVFRFUkVOVFJP UFk9eQpDT05GSUdfQ1JZUFRPX1VTRVJfQVBJPW0KQ09ORklHX0NSWVBUT19VU0VSX0FQSV9IQVNI PW0KQ09ORklHX0NSWVBUT19VU0VSX0FQSV9TS0NJUEhFUj1tCkNPTkZJR19DUllQVE9fVVNFUl9B UElfUk5HPW0KIyBDT05GSUdfQ1JZUFRPX1VTRVJfQVBJX1JOR19DQVZQIGlzIG5vdCBzZXQKQ09O RklHX0NSWVBUT19VU0VSX0FQSV9BRUFEPW0KIyBDT05GSUdfQ1JZUFRPX1VTRVJfQVBJX0VOQUJM RV9PQlNPTEVURSBpcyBub3Qgc2V0CkNPTkZJR19DUllQVE9fSEFTSF9JTkZPPXkKQ09ORklHX0NS WVBUT19IVz15CiMgQ09ORklHX0NSWVBUT19ERVZfQVRNRUxfRUNDIGlzIG5vdCBzZXQKIyBDT05G SUdfQ1JZUFRPX0RFVl9BVE1FTF9TSEEyMDRBIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX0RF Vl9DQ1AgaXMgbm90IHNldAojIENPTkZJR19DUllQVE9fREVWX05JVFJPWF9DTk41NVhYIGlzIG5v dCBzZXQKIyBDT05GSUdfQ1JZUFRPX0RFVl9DQVZJVU1fWklQIGlzIG5vdCBzZXQKIyBDT05GSUdf Q1JZUFRPX0RFVl9WSVJUSU8gaXMgbm90IHNldAojIENPTkZJR19DUllQVE9fREVWX1NBRkVYQ0VM IGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX0RFVl9DQ1JFRSBpcyBub3Qgc2V0CiMgQ09ORklH X0NSWVBUT19ERVZfSElTSV9TRUMgaXMgbm90IHNldAojIENPTkZJR19DUllQVE9fREVWX0FNTE9H SUNfR1hMIGlzIG5vdCBzZXQKQ09ORklHX0FTWU1NRVRSSUNfS0VZX1RZUEU9eQpDT05GSUdfQVNZ TU1FVFJJQ19QVUJMSUNfS0VZX1NVQlRZUEU9eQpDT05GSUdfWDUwOV9DRVJUSUZJQ0FURV9QQVJT RVI9eQojIENPTkZJR19QS0NTOF9QUklWQVRFX0tFWV9QQVJTRVIgaXMgbm90IHNldApDT05GSUdf UEtDUzdfTUVTU0FHRV9QQVJTRVI9eQojIENPTkZJR19QS0NTN19URVNUX0tFWSBpcyBub3Qgc2V0 CiMgQ09ORklHX1NJR05FRF9QRV9GSUxFX1ZFUklGSUNBVElPTiBpcyBub3Qgc2V0CgojCiMgQ2Vy dGlmaWNhdGVzIGZvciBzaWduYXR1cmUgY2hlY2tpbmcKIwpDT05GSUdfU1lTVEVNX1RSVVNURURf S0VZUklORz15CkNPTkZJR19TWVNURU1fVFJVU1RFRF9LRVlTPSIiCiMgQ09ORklHX1NZU1RFTV9F WFRSQV9DRVJUSUZJQ0FURSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFQ09OREFSWV9UUlVTVEVEX0tF WVJJTkcgaXMgbm90IHNldAojIENPTkZJR19TWVNURU1fQkxBQ0tMSVNUX0tFWVJJTkcgaXMgbm90 IHNldAojIGVuZCBvZiBDZXJ0aWZpY2F0ZXMgZm9yIHNpZ25hdHVyZSBjaGVja2luZwoKQ09ORklH X0JJTkFSWV9QUklOVEY9eQoKIwojIExpYnJhcnkgcm91dGluZXMKIwpDT05GSUdfUkFJRDZfUFE9 eQpDT05GSUdfUkFJRDZfUFFfQkVOQ0hNQVJLPXkKQ09ORklHX0xJTkVBUl9SQU5HRVM9eQojIENP TkZJR19QQUNLSU5HIGlzIG5vdCBzZXQKQ09ORklHX0JJVFJFVkVSU0U9eQpDT05GSUdfSEFWRV9B UkNIX0JJVFJFVkVSU0U9eQpDT05GSUdfR0VORVJJQ19TVFJOQ1BZX0ZST01fVVNFUj15CkNPTkZJ R19HRU5FUklDX1NUUk5MRU5fVVNFUj15CkNPTkZJR19HRU5FUklDX05FVF9VVElMUz15CkNPTkZJ R19HRU5FUklDX0ZJTkRfRklSU1RfQklUPXkKQ09ORklHX0NPUkRJQz1tCiMgQ09ORklHX1BSSU1F X05VTUJFUlMgaXMgbm90IHNldApDT05GSUdfUkFUSU9OQUw9eQpDT05GSUdfR0VORVJJQ19QQ0lf SU9NQVA9eQpDT05GSUdfQVJDSF9VU0VfQ01QWENIR19MT0NLUkVGPXkKQ09ORklHX0FSQ0hfSEFT X0ZBU1RfTVVMVElQTElFUj15CkNPTkZJR19BUkNIX1VTRV9TWU1fQU5OT1RBVElPTlM9eQojIENP TkZJR19JTkRJUkVDVF9QSU8gaXMgbm90IHNldAoKIwojIENyeXB0byBsaWJyYXJ5IHJvdXRpbmVz CiMKQ09ORklHX0NSWVBUT19MSUJfQUVTPXkKQ09ORklHX0NSWVBUT19MSUJfQVJDND15CkNPTkZJ R19DUllQVE9fTElCX0JMQUtFMlNfR0VORVJJQz15CiMgQ09ORklHX0NSWVBUT19MSUJfQ0hBQ0hB IGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX0xJQl9DVVJWRTI1NTE5IGlzIG5vdCBzZXQKQ09O RklHX0NSWVBUT19MSUJfREVTPXkKQ09ORklHX0NSWVBUT19MSUJfUE9MWTEzMDVfUlNJWkU9OQoj IENPTkZJR19DUllQVE9fTElCX1BPTFkxMzA1IGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX0xJ Ql9DSEFDSEEyMFBPTFkxMzA1IGlzIG5vdCBzZXQKQ09ORklHX0NSWVBUT19MSUJfU0hBMjU2PXkK IyBlbmQgb2YgQ3J5cHRvIGxpYnJhcnkgcm91dGluZXMKCkNPTkZJR19MSUJfTUVNTkVRPXkKQ09O RklHX0NSQ19DQ0lUVD1tCkNPTkZJR19DUkMxNj15CkNPTkZJR19DUkNfVDEwRElGPW0KQ09ORklH X0NSQ19JVFVfVD15CkNPTkZJR19DUkMzMj15CiMgQ09ORklHX0NSQzMyX1NFTEZURVNUIGlzIG5v dCBzZXQKQ09ORklHX0NSQzMyX1NMSUNFQlk4PXkKIyBDT05GSUdfQ1JDMzJfU0xJQ0VCWTQgaXMg bm90IHNldAojIENPTkZJR19DUkMzMl9TQVJXQVRFIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JDMzJf QklUIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JDNjQgaXMgbm90IHNldAojIENPTkZJR19DUkM0IGlz IG5vdCBzZXQKQ09ORklHX0NSQzc9bQpDT05GSUdfTElCQ1JDMzJDPXkKQ09ORklHX0NSQzg9bQpD T05GSUdfWFhIQVNIPXkKQ09ORklHX0FVRElUX0FSQ0hfQ09NUEFUX0dFTkVSSUM9eQojIENPTkZJ R19SQU5ET00zMl9TRUxGVEVTVCBpcyBub3Qgc2V0CkNPTkZJR19aTElCX0lORkxBVEU9eQpDT05G SUdfWkxJQl9ERUZMQVRFPXkKQ09ORklHX0xaT19DT01QUkVTUz15CkNPTkZJR19MWk9fREVDT01Q UkVTUz15CkNPTkZJR19MWjRfREVDT01QUkVTUz15CkNPTkZJR19aU1REX0NPTVBSRVNTPXkKQ09O RklHX1pTVERfREVDT01QUkVTUz15CkNPTkZJR19YWl9ERUM9eQpDT05GSUdfWFpfREVDX1g4Nj15 CkNPTkZJR19YWl9ERUNfUE9XRVJQQz15CkNPTkZJR19YWl9ERUNfSUE2ND15CkNPTkZJR19YWl9E RUNfQVJNPXkKQ09ORklHX1haX0RFQ19BUk1USFVNQj15CkNPTkZJR19YWl9ERUNfU1BBUkM9eQpD T05GSUdfWFpfREVDX0JDSj15CiMgQ09ORklHX1haX0RFQ19URVNUIGlzIG5vdCBzZXQKQ09ORklH X0RFQ09NUFJFU1NfR1pJUD15CkNPTkZJR19ERUNPTVBSRVNTX0JaSVAyPXkKQ09ORklHX0RFQ09N UFJFU1NfTFpNQT15CkNPTkZJR19ERUNPTVBSRVNTX1haPXkKQ09ORklHX0RFQ09NUFJFU1NfTFpP PXkKQ09ORklHX0RFQ09NUFJFU1NfTFo0PXkKQ09ORklHX0RFQ09NUFJFU1NfWlNURD15CkNPTkZJ R19HRU5FUklDX0FMTE9DQVRPUj15CkNPTkZJR19URVhUU0VBUkNIPXkKQ09ORklHX1RFWFRTRUFS Q0hfS01QPW0KQ09ORklHX1RFWFRTRUFSQ0hfQk09bQpDT05GSUdfVEVYVFNFQVJDSF9GU009bQpD T05GSUdfQlRSRUU9eQpDT05GSUdfSU5URVJWQUxfVFJFRT15CkNPTkZJR19BU1NPQ0lBVElWRV9B UlJBWT15CkNPTkZJR19IQVNfSU9NRU09eQpDT05GSUdfSEFTX0lPUE9SVF9NQVA9eQpDT05GSUdf SEFTX0RNQT15CkNPTkZJR19ETUFfT1BTPXkKQ09ORklHX05FRURfU0dfRE1BX0xFTkdUSD15CkNP TkZJR19ORUVEX0RNQV9NQVBfU1RBVEU9eQpDT05GSUdfQVJDSF9ETUFfQUREUl9UXzY0QklUPXkK Q09ORklHX0RNQV9ERUNMQVJFX0NPSEVSRU5UPXkKQ09ORklHX0FSQ0hfSEFTX1NFVFVQX0RNQV9P UFM9eQpDT05GSUdfQVJDSF9IQVNfVEVBUkRPV05fRE1BX09QUz15CkNPTkZJR19BUkNIX0hBU19T WU5DX0RNQV9GT1JfREVWSUNFPXkKQ09ORklHX0FSQ0hfSEFTX1NZTkNfRE1BX0ZPUl9DUFU9eQpD T05GSUdfQVJDSF9IQVNfRE1BX1BSRVBfQ09IRVJFTlQ9eQpDT05GSUdfU1dJT1RMQj15CiMgQ09O RklHX0RNQV9SRVNUUklDVEVEX1BPT0wgaXMgbm90IHNldApDT05GSUdfRE1BX05PTkNPSEVSRU5U X01NQVA9eQpDT05GSUdfRE1BX0NPSEVSRU5UX1BPT0w9eQpDT05GSUdfRE1BX1JFTUFQPXkKQ09O RklHX0RNQV9ESVJFQ1RfUkVNQVA9eQpDT05GSUdfRE1BX0NNQT15CiMgQ09ORklHX0RNQV9QRVJO VU1BX0NNQSBpcyBub3Qgc2V0CgojCiMgRGVmYXVsdCBjb250aWd1b3VzIG1lbW9yeSBhcmVhIHNp emU6CiMKQ09ORklHX0NNQV9TSVpFX01CWVRFUz0xNgpDT05GSUdfQ01BX1NJWkVfU0VMX01CWVRF Uz15CiMgQ09ORklHX0NNQV9TSVpFX1NFTF9QRVJDRU5UQUdFIGlzIG5vdCBzZXQKIyBDT05GSUdf Q01BX1NJWkVfU0VMX01JTiBpcyBub3Qgc2V0CiMgQ09ORklHX0NNQV9TSVpFX1NFTF9NQVggaXMg bm90IHNldApDT05GSUdfQ01BX0FMSUdOTUVOVD04CiMgQ09ORklHX0RNQV9BUElfREVCVUcgaXMg bm90IHNldAojIENPTkZJR19ETUFfTUFQX0JFTkNITUFSSyBpcyBub3Qgc2V0CkNPTkZJR19TR0xf QUxMT0M9eQpDT05GSUdfQ1BVX1JNQVA9eQpDT05GSUdfRFFMPXkKQ09ORklHX0dMT0I9eQojIENP TkZJR19HTE9CX1NFTEZURVNUIGlzIG5vdCBzZXQKQ09ORklHX05MQVRUUj15CkNPTkZJR19DTFpf VEFCPXkKIyBDT05GSUdfSVJRX1BPTEwgaXMgbm90IHNldApDT05GSUdfTVBJTElCPXkKQ09ORklH X0RJTUxJQj15CkNPTkZJR19MSUJGRFQ9eQpDT05GSUdfT0lEX1JFR0lTVFJZPXkKQ09ORklHX1VD UzJfU1RSSU5HPXkKQ09ORklHX0hBVkVfR0VORVJJQ19WRFNPPXkKQ09ORklHX0dFTkVSSUNfR0VU VElNRU9GREFZPXkKQ09ORklHX0dFTkVSSUNfVkRTT19USU1FX05TPXkKQ09ORklHX0ZPTlRfU1VQ UE9SVD15CiMgQ09ORklHX0ZPTlRTIGlzIG5vdCBzZXQKQ09ORklHX0ZPTlRfOHg4PXkKQ09ORklH X0ZPTlRfOHgxNj15CkNPTkZJR19TR19QT09MPXkKQ09ORklHX0FSQ0hfU1RBQ0tXQUxLPXkKQ09O RklHX1NCSVRNQVA9eQojIGVuZCBvZiBMaWJyYXJ5IHJvdXRpbmVzCgpDT05GSUdfR0VORVJJQ19M SUJfREVWTUVNX0lTX0FMTE9XRUQ9eQoKIwojIEtlcm5lbCBoYWNraW5nCiMKCiMKIyBwcmludGsg YW5kIGRtZXNnIG9wdGlvbnMKIwojIENPTkZJR19QUklOVEtfVElNRSBpcyBub3Qgc2V0CiMgQ09O RklHX1BSSU5US19DQUxMRVIgaXMgbm90IHNldAojIENPTkZJR19TVEFDS1RSQUNFX0JVSUxEX0lE IGlzIG5vdCBzZXQKQ09ORklHX0NPTlNPTEVfTE9HTEVWRUxfREVGQVVMVD03CkNPTkZJR19DT05T T0xFX0xPR0xFVkVMX1FVSUVUPTQKQ09ORklHX01FU1NBR0VfTE9HTEVWRUxfREVGQVVMVD00CiMg Q09ORklHX0JPT1RfUFJJTlRLX0RFTEFZIGlzIG5vdCBzZXQKIyBDT05GSUdfRFlOQU1JQ19ERUJV RyBpcyBub3Qgc2V0CiMgQ09ORklHX0RZTkFNSUNfREVCVUdfQ09SRSBpcyBub3Qgc2V0CkNPTkZJ R19TWU1CT0xJQ19FUlJOQU1FPXkKQ09ORklHX0RFQlVHX0JVR1ZFUkJPU0U9eQojIGVuZCBvZiBw cmludGsgYW5kIGRtZXNnIG9wdGlvbnMKCiMKIyBDb21waWxlLXRpbWUgY2hlY2tzIGFuZCBjb21w aWxlciBvcHRpb25zCiMKQ09ORklHX0RFQlVHX0lORk89eQojIENPTkZJR19ERUJVR19JTkZPX1JF RFVDRUQgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19JTkZPX0NPTVBSRVNTRUQgaXMgbm90IHNl dAojIENPTkZJR19ERUJVR19JTkZPX1NQTElUIGlzIG5vdCBzZXQKQ09ORklHX0RFQlVHX0lORk9f RFdBUkZfVE9PTENIQUlOX0RFRkFVTFQ9eQojIENPTkZJR19ERUJVR19JTkZPX0RXQVJGNCBpcyBu b3Qgc2V0CiMgQ09ORklHX0RFQlVHX0lORk9fRFdBUkY1IGlzIG5vdCBzZXQKIyBDT05GSUdfREVC VUdfSU5GT19CVEYgaXMgbm90IHNldAojIENPTkZJR19HREJfU0NSSVBUUyBpcyBub3Qgc2V0CkNP TkZJR19GUkFNRV9XQVJOPTIwNDgKIyBDT05GSUdfU1RSSVBfQVNNX1NZTVMgaXMgbm90IHNldAoj IENPTkZJR19SRUFEQUJMRV9BU00gaXMgbm90IHNldAojIENPTkZJR19IRUFERVJTX0lOU1RBTEwg aXMgbm90IHNldAojIENPTkZJR19ERUJVR19TRUNUSU9OX01JU01BVENIIGlzIG5vdCBzZXQKQ09O RklHX1NFQ1RJT05fTUlTTUFUQ0hfV0FSTl9PTkxZPXkKIyBDT05GSUdfREVCVUdfRk9SQ0VfRlVO Q1RJT05fQUxJR05fNjRCIGlzIG5vdCBzZXQKQ09ORklHX0FSQ0hfV0FOVF9GUkFNRV9QT0lOVEVS Uz15CkNPTkZJR19GUkFNRV9QT0lOVEVSPXkKIyBDT05GSUdfVk1MSU5VWF9NQVAgaXMgbm90IHNl dAojIENPTkZJR19ERUJVR19GT1JDRV9XRUFLX1BFUl9DUFUgaXMgbm90IHNldAojIGVuZCBvZiBD b21waWxlLXRpbWUgY2hlY2tzIGFuZCBjb21waWxlciBvcHRpb25zCgojCiMgR2VuZXJpYyBLZXJu ZWwgRGVidWdnaW5nIEluc3RydW1lbnRzCiMKQ09ORklHX01BR0lDX1NZU1JRPXkKQ09ORklHX01B R0lDX1NZU1JRX0RFRkFVTFRfRU5BQkxFPTB4MQpDT05GSUdfTUFHSUNfU1lTUlFfU0VSSUFMPXkK Q09ORklHX01BR0lDX1NZU1JRX1NFUklBTF9TRVFVRU5DRT0iIgpDT05GSUdfREVCVUdfRlM9eQpD T05GSUdfREVCVUdfRlNfQUxMT1dfQUxMPXkKIyBDT05GSUdfREVCVUdfRlNfRElTQUxMT1dfTU9V TlQgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19GU19BTExPV19OT05FIGlzIG5vdCBzZXQKQ09O RklHX0hBVkVfQVJDSF9LR0RCPXkKQ09ORklHX0tHREI9eQpDT05GSUdfS0dEQl9IT05PVVJfQkxP Q0tMSVNUPXkKQ09ORklHX0tHREJfU0VSSUFMX0NPTlNPTEU9eQojIENPTkZJR19LR0RCX1RFU1RT IGlzIG5vdCBzZXQKQ09ORklHX0tHREJfS0RCPXkKQ09ORklHX0tEQl9ERUZBVUxUX0VOQUJMRT0w eDEKIyBDT05GSUdfS0RCX0tFWUJPQVJEIGlzIG5vdCBzZXQKQ09ORklHX0tEQl9DT05USU5VRV9D QVRBU1RST1BISUM9MApDT05GSUdfQVJDSF9IQVNfVUJTQU5fU0FOSVRJWkVfQUxMPXkKIyBDT05G SUdfVUJTQU4gaXMgbm90IHNldApDT05GSUdfSEFWRV9LQ1NBTl9DT01QSUxFUj15CiMgZW5kIG9m IEdlbmVyaWMgS2VybmVsIERlYnVnZ2luZyBJbnN0cnVtZW50cwoKQ09ORklHX0RFQlVHX0tFUk5F TD15CkNPTkZJR19ERUJVR19NSVNDPXkKCiMKIyBNZW1vcnkgRGVidWdnaW5nCiMKIyBDT05GSUdf UEFHRV9FWFRFTlNJT04gaXMgbm90IHNldAojIENPTkZJR19ERUJVR19QQUdFQUxMT0MgaXMgbm90 IHNldAojIENPTkZJR19QQUdFX09XTkVSIGlzIG5vdCBzZXQKIyBDT05GSUdfUEFHRV9QT0lTT05J TkcgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19QQUdFX1JFRiBpcyBub3Qgc2V0CiMgQ09ORklH X0RFQlVHX1JPREFUQV9URVNUIGlzIG5vdCBzZXQKQ09ORklHX0FSQ0hfSEFTX0RFQlVHX1dYPXkK IyBDT05GSUdfREVCVUdfV1ggaXMgbm90IHNldApDT05GSUdfR0VORVJJQ19QVERVTVA9eQojIENP TkZJR19QVERVTVBfREVCVUdGUyBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX09CSkVDVFMgaXMg bm90IHNldAojIENPTkZJR19TTFVCX0RFQlVHX09OIGlzIG5vdCBzZXQKIyBDT05GSUdfU0xVQl9T VEFUUyBpcyBub3Qgc2V0CkNPTkZJR19IQVZFX0RFQlVHX0tNRU1MRUFLPXkKIyBDT05GSUdfREVC VUdfS01FTUxFQUsgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19TVEFDS19VU0FHRSBpcyBub3Qg c2V0CiMgQ09ORklHX1NDSEVEX1NUQUNLX0VORF9DSEVDSyBpcyBub3Qgc2V0CkNPTkZJR19BUkNI X0hBU19ERUJVR19WTV9QR1RBQkxFPXkKIyBDT05GSUdfREVCVUdfVk0gaXMgbm90IHNldAojIENP TkZJR19ERUJVR19WTV9QR1RBQkxFIGlzIG5vdCBzZXQKQ09ORklHX0FSQ0hfSEFTX0RFQlVHX1ZJ UlRVQUw9eQojIENPTkZJR19ERUJVR19WSVJUVUFMIGlzIG5vdCBzZXQKIyBDT05GSUdfREVCVUdf TUVNT1JZX0lOSVQgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19QRVJfQ1BVX01BUFMgaXMgbm90 IHNldApDT05GSUdfSEFWRV9BUkNIX0tBU0FOPXkKQ09ORklHX0hBVkVfQVJDSF9LQVNBTl9TV19U QUdTPXkKQ09ORklHX0hBVkVfQVJDSF9LQVNBTl9IV19UQUdTPXkKQ09ORklHX0hBVkVfQVJDSF9L QVNBTl9WTUFMTE9DPXkKQ09ORklHX0NDX0hBU19LQVNBTl9HRU5FUklDPXkKQ09ORklHX0NDX0hB U19LQVNBTl9TV19UQUdTPXkKQ09ORklHX0NDX0hBU19XT1JLSU5HX05PU0FOSVRJWkVfQUREUkVT Uz15CiMgQ09ORklHX0tBU0FOIGlzIG5vdCBzZXQKQ09ORklHX0hBVkVfQVJDSF9LRkVOQ0U9eQpD T05GSUdfS0ZFTkNFPXkKQ09ORklHX0tGRU5DRV9TQU1QTEVfSU5URVJWQUw9MTAwCkNPTkZJR19L RkVOQ0VfTlVNX09CSkVDVFM9MjU1CkNPTkZJR19LRkVOQ0VfU1RSRVNTX1RFU1RfRkFVTFRTPTAK IyBlbmQgb2YgTWVtb3J5IERlYnVnZ2luZwoKIyBDT05GSUdfREVCVUdfU0hJUlEgaXMgbm90IHNl dAoKIwojIERlYnVnIE9vcHMsIExvY2t1cHMgYW5kIEhhbmdzCiMKIyBDT05GSUdfUEFOSUNfT05f T09QUyBpcyBub3Qgc2V0CkNPTkZJR19QQU5JQ19PTl9PT1BTX1ZBTFVFPTAKQ09ORklHX1BBTklD X1RJTUVPVVQ9MAojIENPTkZJR19TT0ZUTE9DS1VQX0RFVEVDVE9SIGlzIG5vdCBzZXQKIyBDT05G SUdfREVURUNUX0hVTkdfVEFTSyBpcyBub3Qgc2V0CiMgQ09ORklHX1dRX1dBVENIRE9HIGlzIG5v dCBzZXQKIyBDT05GSUdfVEVTVF9MT0NLVVAgaXMgbm90IHNldAojIGVuZCBvZiBEZWJ1ZyBPb3Bz LCBMb2NrdXBzIGFuZCBIYW5ncwoKIwojIFNjaGVkdWxlciBEZWJ1Z2dpbmcKIwpDT05GSUdfU0NI RURfREVCVUc9eQpDT05GSUdfU0NIRURfSU5GTz15CkNPTkZJR19TQ0hFRFNUQVRTPXkKIyBlbmQg b2YgU2NoZWR1bGVyIERlYnVnZ2luZwoKIyBDT05GSUdfREVCVUdfVElNRUtFRVBJTkcgaXMgbm90 IHNldApDT05GSUdfREVCVUdfUFJFRU1QVD15CgojCiMgTG9jayBEZWJ1Z2dpbmcgKHNwaW5sb2Nr cywgbXV0ZXhlcywgZXRjLi4uKQojCkNPTkZJR19MT0NLX0RFQlVHR0lOR19TVVBQT1JUPXkKIyBD T05GSUdfUFJPVkVfTE9DS0lORyBpcyBub3Qgc2V0CiMgQ09ORklHX0xPQ0tfU1RBVCBpcyBub3Qg c2V0CiMgQ09ORklHX0RFQlVHX1JUX01VVEVYRVMgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19T UElOTE9DSyBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX01VVEVYRVMgaXMgbm90IHNldAojIENP TkZJR19ERUJVR19XV19NVVRFWF9TTE9XUEFUSCBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX1JX U0VNUyBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX0xPQ0tfQUxMT0MgaXMgbm90IHNldAojIENP TkZJR19ERUJVR19BVE9NSUNfU0xFRVAgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19MT0NLSU5H X0FQSV9TRUxGVEVTVFMgaXMgbm90IHNldAojIENPTkZJR19MT0NLX1RPUlRVUkVfVEVTVCBpcyBu b3Qgc2V0CiMgQ09ORklHX1dXX01VVEVYX1NFTEZURVNUIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NG X1RPUlRVUkVfVEVTVCBpcyBub3Qgc2V0CiMgQ09ORklHX0NTRF9MT0NLX1dBSVRfREVCVUcgaXMg bm90IHNldAojIGVuZCBvZiBMb2NrIERlYnVnZ2luZyAoc3BpbmxvY2tzLCBtdXRleGVzLCBldGMu Li4pCgojIENPTkZJR19ERUJVR19JUlFGTEFHUyBpcyBub3Qgc2V0CkNPTkZJR19TVEFDS1RSQUNF PXkKIyBDT05GSUdfV0FSTl9BTExfVU5TRUVERURfUkFORE9NIGlzIG5vdCBzZXQKIyBDT05GSUdf REVCVUdfS09CSkVDVCBpcyBub3Qgc2V0CgojCiMgRGVidWcga2VybmVsIGRhdGEgc3RydWN0dXJl cwojCiMgQ09ORklHX0RFQlVHX0xJU1QgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19QTElTVCBp cyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX1NHIGlzIG5vdCBzZXQKIyBDT05GSUdfREVCVUdfTk9U SUZJRVJTIGlzIG5vdCBzZXQKIyBDT05GSUdfQlVHX09OX0RBVEFfQ09SUlVQVElPTiBpcyBub3Qg c2V0CiMgZW5kIG9mIERlYnVnIGtlcm5lbCBkYXRhIHN0cnVjdHVyZXMKCiMgQ09ORklHX0RFQlVH X0NSRURFTlRJQUxTIGlzIG5vdCBzZXQKCiMKIyBSQ1UgRGVidWdnaW5nCiMKIyBDT05GSUdfUkNV X1NDQUxFX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19SQ1VfVE9SVFVSRV9URVNUIGlzIG5vdCBz ZXQKIyBDT05GSUdfUkNVX1JFRl9TQ0FMRV9URVNUIGlzIG5vdCBzZXQKQ09ORklHX1JDVV9DUFVf U1RBTExfVElNRU9VVD0yMQpDT05GSUdfUkNVX1RSQUNFPXkKIyBDT05GSUdfUkNVX0VRU19ERUJV RyBpcyBub3Qgc2V0CiMgZW5kIG9mIFJDVSBEZWJ1Z2dpbmcKCiMgQ09ORklHX0RFQlVHX1dRX0ZP UkNFX1JSX0NQVSBpcyBub3Qgc2V0CiMgQ09ORklHX0NQVV9IT1RQTFVHX1NUQVRFX0NPTlRST0wg aXMgbm90IHNldApDT05GSUdfTEFURU5DWVRPUD15CkNPTkZJR19OT1BfVFJBQ0VSPXkKQ09ORklH X0hBVkVfRlVOQ1RJT05fVFJBQ0VSPXkKQ09ORklHX0hBVkVfRlVOQ1RJT05fR1JBUEhfVFJBQ0VS PXkKQ09ORklHX0hBVkVfRFlOQU1JQ19GVFJBQ0U9eQpDT05GSUdfSEFWRV9EWU5BTUlDX0ZUUkFD RV9XSVRIX1JFR1M9eQpDT05GSUdfSEFWRV9GVFJBQ0VfTUNPVU5UX1JFQ09SRD15CkNPTkZJR19I QVZFX1NZU0NBTExfVFJBQ0VQT0lOVFM9eQpDT05GSUdfSEFWRV9DX1JFQ09SRE1DT1VOVD15CkNP TkZJR19UUkFDRV9DTE9DSz15CkNPTkZJR19SSU5HX0JVRkZFUj15CkNPTkZJR19FVkVOVF9UUkFD SU5HPXkKQ09ORklHX0NPTlRFWFRfU1dJVENIX1RSQUNFUj15CkNPTkZJR19UUkFDSU5HPXkKQ09O RklHX0dFTkVSSUNfVFJBQ0VSPXkKQ09ORklHX1RSQUNJTkdfU1VQUE9SVD15CkNPTkZJR19GVFJB Q0U9eQojIENPTkZJR19CT09UVElNRV9UUkFDSU5HIGlzIG5vdCBzZXQKQ09ORklHX0ZVTkNUSU9O X1RSQUNFUj15CkNPTkZJR19GVU5DVElPTl9HUkFQSF9UUkFDRVI9eQpDT05GSUdfRFlOQU1JQ19G VFJBQ0U9eQpDT05GSUdfRFlOQU1JQ19GVFJBQ0VfV0lUSF9SRUdTPXkKIyBDT05GSUdfRlVOQ1RJ T05fUFJPRklMRVIgaXMgbm90IHNldAojIENPTkZJR19TVEFDS19UUkFDRVIgaXMgbm90IHNldAoj IENPTkZJR19JUlFTT0ZGX1RSQUNFUiBpcyBub3Qgc2V0CiMgQ09ORklHX1BSRUVNUFRfVFJBQ0VS IGlzIG5vdCBzZXQKIyBDT05GSUdfU0NIRURfVFJBQ0VSIGlzIG5vdCBzZXQKIyBDT05GSUdfSFdM QVRfVFJBQ0VSIGlzIG5vdCBzZXQKIyBDT05GSUdfT1NOT0lTRV9UUkFDRVIgaXMgbm90IHNldAoj IENPTkZJR19USU1FUkxBVF9UUkFDRVIgaXMgbm90IHNldApDT05GSUdfRlRSQUNFX1NZU0NBTExT PXkKIyBDT05GSUdfVFJBQ0VSX1NOQVBTSE9UIGlzIG5vdCBzZXQKQ09ORklHX0JSQU5DSF9QUk9G SUxFX05PTkU9eQojIENPTkZJR19QUk9GSUxFX0FOTk9UQVRFRF9CUkFOQ0hFUyBpcyBub3Qgc2V0 CiMgQ09ORklHX1BST0ZJTEVfQUxMX0JSQU5DSEVTIGlzIG5vdCBzZXQKQ09ORklHX0JMS19ERVZf SU9fVFJBQ0U9eQpDT05GSUdfS1BST0JFX0VWRU5UUz15CiMgQ09ORklHX0tQUk9CRV9FVkVOVFNf T05fTk9UUkFDRSBpcyBub3Qgc2V0CkNPTkZJR19VUFJPQkVfRVZFTlRTPXkKQ09ORklHX0JQRl9F VkVOVFM9eQpDT05GSUdfRFlOQU1JQ19FVkVOVFM9eQpDT05GSUdfUFJPQkVfRVZFTlRTPXkKIyBD T05GSUdfQlBGX0tQUk9CRV9PVkVSUklERSBpcyBub3Qgc2V0CkNPTkZJR19GVFJBQ0VfTUNPVU5U X1JFQ09SRD15CkNPTkZJR19GVFJBQ0VfTUNPVU5UX1VTRV9QQVRDSEFCTEVfRlVOQ1RJT05fRU5U Ulk9eQojIENPTkZJR19TWU5USF9FVkVOVFMgaXMgbm90IHNldAojIENPTkZJR19ISVNUX1RSSUdH RVJTIGlzIG5vdCBzZXQKIyBDT05GSUdfVFJBQ0VfRVZFTlRfSU5KRUNUIGlzIG5vdCBzZXQKIyBD T05GSUdfVFJBQ0VQT0lOVF9CRU5DSE1BUksgaXMgbm90IHNldAojIENPTkZJR19SSU5HX0JVRkZF Ul9CRU5DSE1BUksgaXMgbm90IHNldAojIENPTkZJR19UUkFDRV9FVkFMX01BUF9GSUxFIGlzIG5v dCBzZXQKIyBDT05GSUdfRlRSQUNFX1JFQ09SRF9SRUNVUlNJT04gaXMgbm90IHNldAojIENPTkZJ R19GVFJBQ0VfU1RBUlRVUF9URVNUIGlzIG5vdCBzZXQKIyBDT05GSUdfUklOR19CVUZGRVJfU1RB UlRVUF9URVNUIGlzIG5vdCBzZXQKIyBDT05GSUdfUklOR19CVUZGRVJfVkFMSURBVEVfVElNRV9E RUxUQVMgaXMgbm90IHNldAojIENPTkZJR19QUkVFTVBUSVJRX0RFTEFZX1RFU1QgaXMgbm90IHNl dAojIENPTkZJR19LUFJPQkVfRVZFTlRfR0VOX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19TQU1Q TEVTIGlzIG5vdCBzZXQKQ09ORklHX1NUUklDVF9ERVZNRU09eQojIENPTkZJR19JT19TVFJJQ1Rf REVWTUVNIGlzIG5vdCBzZXQKCiMKIyBhcm02NCBEZWJ1Z2dpbmcKIwojIENPTkZJR19QSURfSU5f Q09OVEVYVElEUiBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX0VGSSBpcyBub3Qgc2V0CiMgQ09O RklHX0FSTTY0X1JFTE9DX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19DT1JFU0lHSFQgaXMgbm90 IHNldAojIGVuZCBvZiBhcm02NCBEZWJ1Z2dpbmcKCiMKIyBLZXJuZWwgVGVzdGluZyBhbmQgQ292 ZXJhZ2UKIwojIENPTkZJR19LVU5JVCBpcyBub3Qgc2V0CiMgQ09ORklHX05PVElGSUVSX0VSUk9S X0lOSkVDVElPTiBpcyBub3Qgc2V0CkNPTkZJR19GVU5DVElPTl9FUlJPUl9JTkpFQ1RJT049eQoj IENPTkZJR19GQVVMVF9JTkpFQ1RJT04gaXMgbm90IHNldApDT05GSUdfQVJDSF9IQVNfS0NPVj15 CkNPTkZJR19DQ19IQVNfU0FOQ09WX1RSQUNFX1BDPXkKIyBDT05GSUdfS0NPViBpcyBub3Qgc2V0 CkNPTkZJR19SVU5USU1FX1RFU1RJTkdfTUVOVT15CiMgQ09ORklHX0xLRFRNIGlzIG5vdCBzZXQK IyBDT05GSUdfVEVTVF9NSU5fSEVBUCBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfRElWNjQgaXMg bm90IHNldAojIENPTkZJR19LUFJPQkVTX1NBTklUWV9URVNUIGlzIG5vdCBzZXQKIyBDT05GSUdf QkFDS1RSQUNFX1NFTEZfVEVTVCBpcyBub3Qgc2V0CiMgQ09ORklHX1JCVFJFRV9URVNUIGlzIG5v dCBzZXQKIyBDT05GSUdfUkVFRF9TT0xPTU9OX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19JTlRF UlZBTF9UUkVFX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19QRVJDUFVfVEVTVCBpcyBub3Qgc2V0 CiMgQ09ORklHX0FUT01JQzY0X1NFTEZURVNUIGlzIG5vdCBzZXQKIyBDT05GSUdfQVNZTkNfUkFJ RDZfVEVTVCBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfSEVYRFVNUCBpcyBub3Qgc2V0CiMgQ09O RklHX1NUUklOR19TRUxGVEVTVCBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfU1RSSU5HX0hFTFBF UlMgaXMgbm90IHNldAojIENPTkZJR19URVNUX1NUUlNDUFkgaXMgbm90IHNldAojIENPTkZJR19U RVNUX0tTVFJUT1ggaXMgbm90IHNldAojIENPTkZJR19URVNUX1BSSU5URiBpcyBub3Qgc2V0CiMg Q09ORklHX1RFU1RfU0NBTkYgaXMgbm90IHNldAojIENPTkZJR19URVNUX0JJVE1BUCBpcyBub3Qg c2V0CiMgQ09ORklHX1RFU1RfVVVJRCBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfWEFSUkFZIGlz IG5vdCBzZXQKIyBDT05GSUdfVEVTVF9PVkVSRkxPVyBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1Rf UkhBU0hUQUJMRSBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfSEFTSCBpcyBub3Qgc2V0CiMgQ09O RklHX1RFU1RfSURBIGlzIG5vdCBzZXQKIyBDT05GSUdfVEVTVF9MS00gaXMgbm90IHNldAojIENP TkZJR19URVNUX0JJVE9QUyBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfVk1BTExPQyBpcyBub3Qg c2V0CiMgQ09ORklHX1RFU1RfVVNFUl9DT1BZIGlzIG5vdCBzZXQKIyBDT05GSUdfVEVTVF9CUEYg aXMgbm90IHNldAojIENPTkZJR19URVNUX0JMQUNLSE9MRV9ERVYgaXMgbm90IHNldAojIENPTkZJ R19GSU5EX0JJVF9CRU5DSE1BUksgaXMgbm90IHNldAojIENPTkZJR19URVNUX0ZJUk1XQVJFIGlz IG5vdCBzZXQKIyBDT05GSUdfVEVTVF9TWVNDVEwgaXMgbm90IHNldAojIENPTkZJR19URVNUX1VE RUxBWSBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfU1RBVElDX0tFWVMgaXMgbm90IHNldAojIENP TkZJR19URVNUX0tNT0QgaXMgbm90IHNldAojIENPTkZJR19URVNUX01FTUNBVF9QIGlzIG5vdCBz ZXQKIyBDT05GSUdfVEVTVF9TVEFDS0lOSVQgaXMgbm90IHNldAojIENPTkZJR19URVNUX01FTUlO SVQgaXMgbm90IHNldAojIENPTkZJR19URVNUX0ZSRUVfUEFHRVMgaXMgbm90IHNldApDT05GSUdf QVJDSF9VU0VfTUVNVEVTVD15CiMgQ09ORklHX01FTVRFU1QgaXMgbm90IHNldAojIGVuZCBvZiBL ZXJuZWwgVGVzdGluZyBhbmQgQ292ZXJhZ2UKIyBlbmQgb2YgS2VybmVsIGhhY2tpbmcK --00000000000054191f05edff84e8-- From xen-devel-bounces@lists.xenproject.org Mon Nov 21 19:35:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 19:35:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446858.702678 (Exim 4.92) (envelope-from ) id 1oxCZy-0001mi-Oc; Mon, 21 Nov 2022 19:35:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446858.702678; Mon, 21 Nov 2022 19:35:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxCZy-0001mb-LH; Mon, 21 Nov 2022 19:35:42 +0000 Received: by outflank-mailman (input) for mailman id 446858; Mon, 21 Nov 2022 19:35:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxCZx-0001mR-4a; Mon, 21 Nov 2022 19:35:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxCZx-0006kb-1G; Mon, 21 Nov 2022 19:35:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxCZw-0002EV-Jo; Mon, 21 Nov 2022 19:35:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxCZw-0005S1-JM; Mon, 21 Nov 2022 19:35:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=i27E3npQhnGTCu7ARHXrPU6/65cEhikTzCtYwLyRvq0=; b=YLbswePyPLYcz2tb0+W9GQrsxv 8bJYY7fmV/weeM7rgzPTKxYTkbiq7M4FClywxUboqxsHPcdv5p8TIfccyAwMmbWpfDbd1YCMtmKog OzFeO9yWnOB+KHf3dbs/Gv4PjOJUkdKWc4qzr3zrMcgrPud3Gmy2jkFVkl5VePSEiwrA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 174889: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=345135942bf9632eba1409ba432cfcae3b7649c7 X-Osstest-Versions-That: xen=8cdfbf95b19c01fbb741c41d5ea5a94f8823964c From: osstest service owner Date: Mon, 21 Nov 2022 19:35:40 +0000 flight 174889 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174889/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 345135942bf9632eba1409ba432cfcae3b7649c7 baseline version: xen 8cdfbf95b19c01fbb741c41d5ea5a94f8823964c Last test of basis 174883 2022-11-21 12:00:29 Z 0 days Testing same since 174889 2022-11-21 17:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 8cdfbf95b1..345135942b 345135942bf9632eba1409ba432cfcae3b7649c7 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Nov 21 20:33:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 21 Nov 2022 20:33:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446917.702713 (Exim 4.92) (envelope-from ) id 1oxDTf-00015r-I4; Mon, 21 Nov 2022 20:33:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446917.702713; Mon, 21 Nov 2022 20:33:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxDTf-00015k-EL; Mon, 21 Nov 2022 20:33:15 +0000 Received: by outflank-mailman (input) for mailman id 446917; Mon, 21 Nov 2022 20:33:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxDTd-00015a-FK; Mon, 21 Nov 2022 20:33:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxDTd-0008Kc-Bw; Mon, 21 Nov 2022 20:33:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxDTc-0003r5-Rr; Mon, 21 Nov 2022 20:33:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxDTc-0000yW-RP; Mon, 21 Nov 2022 20:33:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ipQSxxfRkUdFMds+0iCJtLP8oCLuzIzSlZ7E3dCGqdo=; b=5iY8gTkCuKFdNfdk6r+vsY+I6O DdUkC7oiuOlteZpQrW0HsjLrGj4aiz0by7++iKO4qmuRbErzndGq+KIl+wii5iO7q1K0+j46pB68t 2faCW8lD8CWAiMvWKyJ298v7Yq9dog90seWqHvezoB7In2BUQydFN3NTUsyk1NozMbwo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174881: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-saverestore:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=db8fa01c61db0317a9ee947925226234c65d48e8 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Mon, 21 Nov 2022 20:33:12 +0000 flight 174881 xen-unstable real [real] flight 174892 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174881/ http://logs.test-lab.xenproject.org/osstest/logs/174892/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 174797 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 174797 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 15 guest-saverestore fail REGR. vs. 174797 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen db8fa01c61db0317a9ee947925226234c65d48e8 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 4 days Testing same since 174809 2022-11-18 00:06:55 Z 3 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit db8fa01c61db0317a9ee947925226234c65d48e8 Author: Andrew Cooper Date: Thu Oct 20 12:14:30 2022 +0100 xen/arm: Correct the p2m pool size calculations Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit bd87315a603bf25e869e6293f7db7b1024d67999 Author: Andrew Cooper Date: Thu Oct 20 12:13:46 2022 +0100 tools/tests: Unit test for paging mempool size Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit 22b20bd98c025e06525410e3ab3494d5e63489f7 Author: Andrew Cooper Date: Fri Oct 21 14:13:00 2022 +0100 xen: Introduce non-broken hypercalls for the paging mempool size The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 Author: Andrew Cooper Date: Mon Nov 14 21:47:59 2022 +0000 x86/hvm: Revert per-domain APIC acceleration support I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisted in due course. Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Fixes: 6b2b9b340509 ("x86: report Interrupt Controller Virtualization capabilities") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Tue Nov 22 00:09:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 00:09:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446938.702748 (Exim 4.92) (envelope-from ) id 1oxGqo-0006nn-4g; Tue, 22 Nov 2022 00:09:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446938.702748; Tue, 22 Nov 2022 00:09:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxGqo-0006ng-1v; Tue, 22 Nov 2022 00:09:22 +0000 Received: by outflank-mailman (input) for mailman id 446938; Tue, 22 Nov 2022 00:09:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxGqm-0006nW-IX; Tue, 22 Nov 2022 00:09:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxGqm-0005AQ-Et; Tue, 22 Nov 2022 00:09:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxGql-0007D6-V5; Tue, 22 Nov 2022 00:09:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxGql-0008D5-Uc; Tue, 22 Nov 2022 00:09:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=UynXKCZXtNIIZgoKaya0INem9dw2XTsHgj3IbvoO0WA=; b=IvNSe98g3o1Vqt4jDyl8uMnwQK +m09Hx4YlY9Runa6gsM+Af0q5RoBdiqsFQJSjlxj6FfDsZ18Q8m6Mg4bG2MZVozmYh3rWYSWx8EEf wN0R8b9GX7vS6upTZd6s1BavJX8ziEYw1UcfGxxGbHBRzPVbJQXKmziByn4HZ1a4FW/k=; To: xen-devel@lists.xenproject.org Subject: [xen-unstable bisection] complete test-amd64-i386-xl-qemuu-debianhvm-i386-xsm Message-Id: From: osstest service owner Date: Tue, 22 Nov 2022 00:09:19 +0000 branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-qemuu-debianhvm-i386-xsm testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Bug not present: bd87315a603bf25e869e6293f7db7b1024d67999 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174900/ commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test-amd64-i386-xl-qemuu-debianhvm-i386-xsm.debian-hvm-install.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable/test-amd64-i386-xl-qemuu-debianhvm-i386-xsm.debian-hvm-install --summary-out=tmp/174900.bisection-summary --basis-template=174797 --blessings=real,real-bisect,real-retry xen-unstable test-amd64-i386-xl-qemuu-debianhvm-i386-xsm debian-hvm-install Searching for failure / basis pass: 174881 fail [host=nobling1] / 174797 [host=nocera1] 174773 [host=nobling0] 174769 [host=debina0] 174762 [host=huxelrebe0] 174753 [host=italia1] 174747 [host=albana0] 174742 [host=chardonnay1] 174733 [host=chardonnay0] 174724 [host=fiano0] 174701 [host=fiano1] 174682 [host=italia0] 174663 [host=nocera0] 174652 [host=pinot1] 174641 [host=pinot0] 174636 [host=elbling0] 174629 [host=huxelrebe1] 174607 [host=debina1] 174586 [host=nocera1] 174574 [host=albana1] 174563 [host=nobling0] 174547 [host=hux\ elrebe0] 174542 [host=debina0] 174538 [host=albana0] 174534 [host=italia1] 174526 [host=chardonnay0] 174499 [host=chardonnay1] 174435 [host=fiano0] 174367 [host=fiano1] 174285 [host=italia0] 174252 [host=pinot0] 174210 [host=nocera0] 174133 ok. Failure / basis pass flights: 174881 / 174133 (tree with no url: minios) (tree with no url: ovmf) (tree with no url: seabios) Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9029bc265cdf2bd63376dde9fdd91db4ce9c0586 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#b746458e1ce1bec85e58b458386f8b7\ a0bedfaa6-b746458e1ce1bec85e58b458386f8b7a0bedfaa6 git://xenbits.xen.org/xen.git#9029bc265cdf2bd63376dde9fdd91db4ce9c0586-db8fa01c61db0317a9ee947925226234c65d48e8 Loaded 5001 nodes in revision graph Searching for test results: 173812 [host=elbling0] 173920 [host=elbling1] 174057 [host=albana1] 174133 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9029bc265cdf2bd63376dde9fdd91db4ce9c0586 174165 [host=nocera0] 174210 [host=nocera0] 174252 [host=pinot0] 174285 [host=italia0] 174367 [host=fiano1] 174435 [host=fiano0] 174499 [host=chardonnay1] 174526 [host=chardonnay0] 174534 [host=italia1] 174538 [host=albana0] 174542 [host=debina0] 174547 [host=huxelrebe0] 174563 [host=nobling0] 174574 [host=albana1] 174586 [host=nocera1] 174597 [host=debina1] 174607 [host=debina1] 174629 [host=huxelrebe1] 174636 [host=elbling0] 174641 [host=pinot0] 174652 [host=pinot1] 174663 [host=nocera0] 174670 [host=italia0] 174682 [host=italia0] 174701 [host=fiano1] 174724 [host=fiano0] 174733 [host=chardonnay0] 174742 [host=chardonnay1] 174747 [host=albana0] 174753 [host=italia1] 174762 [host=huxelrebe0] 174769 [host=debina0] 174773 [host=nobling0] 174791 [host=nocera1] 174797 [host=nocera1] 174814 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174819 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174826 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174843 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174854 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174865 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174874 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174880 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9029bc265cdf2bd63376dde9fdd91db4ce9c0586 174882 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174884 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9bfde319dbac2a1321898d2f75a3f075c3eb7b32 174885 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 13ac37f1416cae88d97f7baf6cf2a827edb9a187 174886 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 63ca22f9207aadebe6aaeab4dc21b1fcd9e7795a 174887 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 97abc04e387bb070f9c917269be0ff4e5a813bcf 174888 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f5d56f4b253072264efc0fece698a91779e362f5 174881 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174891 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 22b20bd98c025e06525410e3ab3494d5e63489f7 174898 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174893 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174894 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e 174895 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174897 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e 174900 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e 173459 [host=chardonnay1] 173477 [host=chardonnay0] 173466 [host=fiano1] 173482 [host=debina1] 173488 [host=huxelrebe0] 173738 [host=albana0] 173663 [host=nocera1] Searching for interesting versions Result found: flight 174133 (pass), for basis pass For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999, results HASH(0x55f37100e750) HASH(0x55f370f86e88) HASH(0x55f370a20b50) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1\ ce1bec85e58b458386f8b7a0bedfaa6 22b20bd98c025e06525410e3ab3494d5e63489f7, results HASH(0x55f370f6f138) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f5d56f4b253072264efc0fece698a91779e362f5, results HASH(0x55f37100d408) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f\ 0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 97abc04e387bb070f9c917269be0ff4e5a813bcf, results HASH(0x55f37100b960) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 63ca22f9207aadebe6aaeab4dc21b1fcd9e7795a, results HASH(0x55f371007b50) For basis failure, parent search stopping at c3038e718a19\ fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 13ac37f1416cae88d97f7baf6cf2a827edb9a187, results HASH(0x55f370f68af8) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9bfde319dbac2a1321898d2f75a3f075c3eb7b32, results HASH(0x55f370a28b3\ 0) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9029bc265cdf2bd63376dde9fdd91db4ce9c0586, results HASH(0x55f370f79d88) HASH(0x55f370f6fa38) Result found: flight 174814 (fail), for basis failure (at ancestor ~732) Repro found: flight 174880 (pass), for basis pass Repro found: flight 174881 (fail), for basis failure 0 revisions at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 No revisions left to test, checking graph state. Result found: flight 174893 (pass), for last pass Result found: flight 174894 (fail), for first failure Repro found: flight 174895 (pass), for last pass Repro found: flight 174897 (fail), for first failure Repro found: flight 174898 (pass), for last pass Repro found: flight 174900 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Bug not present: bd87315a603bf25e869e6293f7db7b1024d67999 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174900/ commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang pnmtopng: 249 colors found Revision graph left in /home/logs/results/bisect/xen-unstable/test-amd64-i386-xl-qemuu-debianhvm-i386-xsm.debian-hvm-install.{dot,ps,png,html,svg}. ---------------------------------------- 174900: tolerable ALL FAIL flight 174900 xen-unstable real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/174900/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail baseline untested jobs: test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Tue Nov 22 02:12:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 02:12:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446954.702768 (Exim 4.92) (envelope-from ) id 1oxIm6-00025n-2g; Tue, 22 Nov 2022 02:12:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446954.702768; Tue, 22 Nov 2022 02:12:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxIm5-00025f-Tt; Tue, 22 Nov 2022 02:12:37 +0000 Received: by outflank-mailman (input) for mailman id 446954; Tue, 22 Nov 2022 02:12:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxIm4-00025V-3i; Tue, 22 Nov 2022 02:12:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxIm4-0006mi-0H; Tue, 22 Nov 2022 02:12:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxIm3-00064k-JC; Tue, 22 Nov 2022 02:12:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxIm3-0006dV-If; Tue, 22 Nov 2022 02:12:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tpXkOmW6/j7SQqSx+WnmWA7QhU1CMww45cUOJG2H4m0=; b=uBT51CvQ3ZUmIRJ5qab7e8cLD5 Fhraq+SPmp0sX9QiTJ2eV8Y+F1oOcT5/BnsKnGPiW2y8wBpRgw6Y9lxLiNz5OoW54UTFk3plGpy+I GOXkypebQb0oRB3Y376+znnQY0DX+IwPQyVSsetxJywa+u5KGfq33YdceH9iTMvGfg6Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174890: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-seattle::broken:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:host-install:broken:heisenbug linux-linus:test-arm64-arm64-xl-seattle:host-install(5):broken:heisenbug linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 22 Nov 2022 02:12:35 +0000 flight 174890 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174890/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-seattle broken test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail in 174878 REGR. vs. 173462 Tests which are failing intermittently (not blocking): test-amd64-amd64-examine-bios 5 host-install broken pass in 174878 test-arm64-arm64-xl-seattle 5 host-install(5) broken pass in 174878 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 45 days Failing since 173470 2022-10-08 06:21:34 Z 44 days 80 attempts Testing same since 174871 2022-11-21 00:40:59 Z 1 days 3 attempts ------------------------------------------------------------ 1802 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle broken test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-arm64-arm64-xl-seattle broken broken-step test-amd64-amd64-examine-bios host-install broken-step test-arm64-arm64-xl-seattle host-install(5) Not pushing. (No revision log; it would be 171425 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Nov 22 04:18:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 04:18:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446972.702791 (Exim 4.92) (envelope-from ) id 1oxKjG-0006ed-Tj; Tue, 22 Nov 2022 04:17:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446972.702791; Tue, 22 Nov 2022 04:17:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxKjG-0006eW-Qd; Tue, 22 Nov 2022 04:17:50 +0000 Received: by outflank-mailman (input) for mailman id 446972; Tue, 22 Nov 2022 04:17:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxKjF-0006eG-Dd; Tue, 22 Nov 2022 04:17:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxKjF-00015m-8H; Tue, 22 Nov 2022 04:17:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxKjF-00048u-12; Tue, 22 Nov 2022 04:17:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxKjF-0008O2-0a; Tue, 22 Nov 2022 04:17:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SqpO8uYmyScImBcjQEDXZrnfZ4VlcPU6IUIG9qp5oMw=; b=byxPhl2UylXMHNr+/Gjsg8S/Tm YiqAM56OQqzmh4CtCtWx/UDqt6nNtU+TB7nndgFJs57GnDltL823RKZdOmvyeyWa4usHHH/ND5dKU kHjxai2ftnhXlkrpRI52J9zWawaGSeWKXr7hfafwhiJfLHlMBH97KlRR96X23uK8WL0w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174896: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64::broken:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:host-install(5):broken:regression xen-unstable:test-amd64-amd64-examine-bios:host-install:broken:regression xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=345135942bf9632eba1409ba432cfcae3b7649c7 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Tue, 22 Nov 2022 04:17:49 +0000 flight 174896 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174896/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 broken test-amd64-i386-xl-qemut-debianhvm-amd64 5 host-install(5) broken REGR. vs. 174797 test-amd64-amd64-examine-bios 5 host-install broken REGR. vs. 174797 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 174797 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 345135942bf9632eba1409ba432cfcae3b7649c7 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 5 days Failing since 174809 2022-11-18 00:06:55 Z 4 days 11 attempts Testing same since 174896 2022-11-21 20:43:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Daniel P. Smith Jan Beulich Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 broken test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-i386-xl-qemut-debianhvm-amd64 broken broken-step test-amd64-i386-xl-qemut-debianhvm-amd64 host-install(5) broken-step test-amd64-amd64-examine-bios host-install Not pushing. ------------------------------------------------------------ commit 345135942bf9632eba1409ba432cfcae3b7649c7 Author: Andrew Cooper Date: Mon Nov 21 12:46:39 2022 +0000 xen/flask: Wire up XEN_DOMCTL_{get,set}_paging_mempool_size These were overlooked in the original patch, and noticed by OSSTest which does run some Flask tests. Fixes: 22b20bd98c02 ("xen: Introduce non-broken hypercalls for the paging mempool size") Suggested-by: Daniel Smith Signed-off-by: Andrew Cooper Reviewed-by: Jason Andryuk Acked-by: Daniel P. Smith Release-acked-by: Henry Wang commit 8746d3e2550b142cd751ca7a041a38789a020d2b Author: Andrew Cooper Date: Fri Nov 18 16:53:45 2022 +0000 tools/libxl: Fixes to libxl__domain_set_paging_mempool_size() The error message accidentally printed the bytes value as if it were kB. Furthermore, both b_info.shadow_memkb and shadow_mem are uint64_t, meaning there is a risk of overflow if the user specified a stupidly large value in the vm.cfg file. Check and reject such a condition. Fixes: 7c3bbd940dd8 ("xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls") Signed-off-by: Andrew Cooper Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit 8cdfbf95b19c01fbb741c41d5ea5a94f8823964c Author: Anthony PERARD Date: Mon Nov 21 12:23:01 2022 +0100 libs/light: Propagate libxl__arch_domain_create() return code Commit 34990446ca91 started to overwrite the `rc` value from libxl__arch_domain_create(), thus error aren't propagated anymore. Check `rc` value before doing the next thing. Fixes: 34990446ca91 ("libxl: don't ignore the return value from xc_cpuid_apply_policy") Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD Reviewed-by: Jason Andryuk Release-acked-by: Henry Wang commit 57f07cca82521088cca0c1fc36d6ffd06cb7de80 Author: Roger Pau Monné Date: Mon Nov 21 12:21:51 2022 +0100 efifb: ignore frame buffer with invalid configuration On one of my boxes when the HDMI cable is not plugged in the FrameBufferBase of the EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE structure is set to 0 by the firmware (while some of the other fields looking plausible). Such (bogus address) ends up mapped in vesa_init(), and since it overlaps with a RAM region the whole system goes down pretty badly, see: (XEN) vesafb: framebuffer at 0x0000000000000000, mapped to 0xffff82c000201000, using 35209k, total 35209k (XEN) vesafb: mode is 0x37557x32, linelength=960, font 8x16 (XEN) vesafb: Truecolor: size=8:8:8:8, shift=24:0:8:16 (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) �ERROR: Class:0; Subclass:0; Operation: 0 ERROR: No ConOut ERROR: No ConIn Do like Linux and prevent using the EFI Frame Buffer if the base address is 0. This is inline with the logic in Linuxes fb_base_is_valid() function at drivers/video/fbdev/efifb.c v6.0.9. See also Linux commit 133bb070e94ab41d750c6f2160c8843e46f11b78 for further reference. Also prevent using Frame Buffers that have a 0 height or width, as those are also invalid. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Release-acked-by: Henry Wang commit db8fa01c61db0317a9ee947925226234c65d48e8 Author: Andrew Cooper Date: Thu Oct 20 12:14:30 2022 +0100 xen/arm: Correct the p2m pool size calculations Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit bd87315a603bf25e869e6293f7db7b1024d67999 Author: Andrew Cooper Date: Thu Oct 20 12:13:46 2022 +0100 tools/tests: Unit test for paging mempool size Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit 22b20bd98c025e06525410e3ab3494d5e63489f7 Author: Andrew Cooper Date: Fri Oct 21 14:13:00 2022 +0100 xen: Introduce non-broken hypercalls for the paging mempool size The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 Author: Andrew Cooper Date: Mon Nov 14 21:47:59 2022 +0000 x86/hvm: Revert per-domain APIC acceleration support I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisted in due course. Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Fixes: 6b2b9b340509 ("x86: report Interrupt Controller Virtualization capabilities") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Tue Nov 22 04:41:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 04:41:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446980.702801 (Exim 4.92) (envelope-from ) id 1oxL5s-0001jK-Si; Tue, 22 Nov 2022 04:41:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446980.702801; Tue, 22 Nov 2022 04:41:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxL5s-0001jD-Q2; Tue, 22 Nov 2022 04:41:12 +0000 Received: by outflank-mailman (input) for mailman id 446980; Tue, 22 Nov 2022 04:41:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxL5s-0001j7-0Y for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 04:41:12 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20611.outbound.protection.outlook.com [2a01:111:f400:7eaf::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e0527685-6a1f-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 05:41:09 +0100 (CET) Received: from AS9P194CA0009.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::19) by GV2PR08MB8147.eurprd08.prod.outlook.com (2603:10a6:150:7b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 04:40:57 +0000 Received: from AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46d:cafe::d6) by AS9P194CA0009.outlook.office365.com (2603:10a6:20b:46d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15 via Frontend Transport; Tue, 22 Nov 2022 04:40:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT014.mail.protection.outlook.com (100.127.140.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Tue, 22 Nov 2022 04:40:56 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Tue, 22 Nov 2022 04:40:56 +0000 Received: from 1124bd2dc486.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D7790354-42D5-4961-BDA5-BE0B414FE426.1; Tue, 22 Nov 2022 04:40:50 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1124bd2dc486.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Nov 2022 04:40:50 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB7762.eurprd08.prod.outlook.com (2603:10a6:10:3ba::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 04:40:48 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5857.013; Tue, 22 Nov 2022 04:40:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0527685-6a1f-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MndssoRpk1eDjRrPkex3BGiCIwkwRSIyKOb7Fj2wHcc=; b=C+/oRY2j9j6WIJFFbm8h9qrNnQmFCLBjP89rAw1W4SU+2WhXgJoKHtkY7x6VedNu3/h0cs9RgInicCdT8CjVogThUaLshPkjPDMpF7pECXmyPhDJG43+LTcOKtLq9QBUYivxSwzfsnt0jFgIpC+7us6sobT0b4YdyfCZ9WaeU68= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cX6gAEfbLlAiayEqIF9z0RHItBN/HHoskyAvYB2s0UgA/1zuPMHXONncYzl/UER7xfAvcV2CCFyi6Up/NNAC4PjEidUnz3lAxnjkW1U+Dus9gRYQOLUZAve9Ct5kAFLqajCWaup2of0ZfFfi4Sn+3QhQm51tZfDPzekV9qFZjUWuQEJeUybczKahgYfnQ5LRDmz5aO5nYdLa23NCTOL2t1G3qnp4k6EWrUlM6PDPnCrlnR58TPnLIkPRvTyMLyIYeqyIklhBdmAuAb9sgBaHiJwBiqmYLElYakgfelOrU1tSjfbkgi22ojmFXE/ouX6DNvrpIz1GGdaL3J9bHbaahQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MndssoRpk1eDjRrPkex3BGiCIwkwRSIyKOb7Fj2wHcc=; b=jKrtuo7TM1QfKvDvXVYp5lPP6+MtBH/tlS/kULspiEc8VwYy07+I9vvmL5hl3l9Sw6bbXHc1DhIAmPunn8x3CBA8z+63rL2HIDgV33PiNTZXLQtMT6yJxJKpPnPmtsPx6XJFtXB8IDGlUZ1fBezUvxhrriZkhRRQqvlGV602Ci1g9m6jaFYq4uzBuWTWnZPW6to0JUZ17fe/tl4UkwVygUEuj3GHAlZkm6UAuOEg7iqULcYcShD+iMIHbFHZT83gREwJ/yXvOMPR1r9ZFtKLZWXAZAK42iYXFNuoT9qaOuPGLUzXcQQScYnvQwBVN/Bjws2nnXFHn/y4m5j/zjlWPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MndssoRpk1eDjRrPkex3BGiCIwkwRSIyKOb7Fj2wHcc=; b=C+/oRY2j9j6WIJFFbm8h9qrNnQmFCLBjP89rAw1W4SU+2WhXgJoKHtkY7x6VedNu3/h0cs9RgInicCdT8CjVogThUaLshPkjPDMpF7pECXmyPhDJG43+LTcOKtLq9QBUYivxSwzfsnt0jFgIpC+7us6sobT0b4YdyfCZ9WaeU68= From: Henry Wang To: osstest service owner , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: RE: [xen-unstable test] 174896: regressions - trouble: broken/fail/pass Thread-Topic: [xen-unstable test] 174896: regressions - trouble: broken/fail/pass Thread-Index: AQHY/il0mnhbZI+0lU6khiE134HQUa5KXDNg Date: Tue, 22 Nov 2022 04:40:47 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A5DDBA7DDF2CEB47AEB531772492C284.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DU0PR08MB7762:EE_|AM7EUR03FT014:EE_|GV2PR08MB8147:EE_ X-MS-Office365-Filtering-Correlation-Id: b52295b8-d679-49ff-5592-08dacc43bf35 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nQay4RksP3ApgWWYoOKWRFEO/gkAFzgW5EOyIL/t9Ge0BxBHoPAgmuYfluAoX5McixauN0i9dkdRmJhKnZTr++fyA7gCsT1OqbzEcSDkNwVZAkEwKerJDsSogq7kAGmiBXM00SIAiGam+6PgKl30FYbERHl8uKb29HhQpzvna4Aj8KZ4/cNwgtPaw/6zSaabk8CY+RjGAlxU1ey1sh7IHWfp9IyAXBNYzrVCVaWrpVNKrZnHiFN55nBevDbk5/DJqZsH02m51JWSrSbVck7u5OC8c6JSk4Qp8vABfqe3p6yfEJeN+E1WDgtRreY4HwFB8q/YT1miQ1KXFHbgDwYAPjhFTgygimxbgXAT1hbyHGEzE9pPMaHfjw9cedc7zeHmpAz0cCPV1l4PKDuXDB8JE0icupJTjaBRb0mE0QdAvZzQnlRikvLd+WCyj+2RLBbP4aDA+tatja1GU//ojE36Li2RJ17uM7e5JNo60teNsndxVIqqdkuI7pO312DAqXkeJJJyitvRqEIiWrUjAicz7dEwZJfe02CLKtbGVitniNWXOTlsOAHC+j+N0SzAFrY1gVtwNdJ72QOlKG9Uk/3LhbxwRakBEtgkM/dimvl2E1+hlrvDX+JGsYDViafnXOZU0/g5NJGWdsqD60qpoRlG1IYlrFY3j8tNqIAsTkV4U4FKNdgpmrhdq6eR0dLcsblZ6IfX6VyhpEXojIOzVu97n0fnmrpszXhaq411gWQt0km5DJVvaNcw+WdytYQ0aB/2qmtNzn3aKjlEc2w3Jqc30w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(366004)(39860400002)(396003)(451199015)(71200400001)(966005)(478600001)(9686003)(76116006)(66946007)(8676002)(66446008)(6506007)(7696005)(64756008)(41300700001)(4326008)(66556008)(66476007)(110136005)(38100700002)(122000001)(186003)(316002)(26005)(54906003)(55016003)(52536014)(2906002)(5660300002)(83380400001)(8936002)(33656002)(86362001)(38070700005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7762 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b53122d6-c356-403e-6858-08dacc43b9c0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Amul78SxZAr2XMmjeeWI+HqvrSI45L9hM8DNcich3puowDc4NKIIA/fLNwnLohoe1d0IqG6+1Se2+ZrM9Oh5ioNE90+MLZjaWBFQo/MlydLi9OWF7Q+te0eL5vcDdp7R2MuNgPoUORdCWdpaP9LppaQA/ZWnKZmF8LFtFcwo/RYXXrhhSzKJUCg1X78FG9uewpbE71Ge70uuXVuvbrdcvuXd3Nejkhy0OEjcjWbjCKSblQRmJL67QtHuk1AjiF/s7OGaWhuuvez7246ORgX2AaKe+BXGtboCkrswC+fZVrLZLrZGxXAYzfz95iFKYGV1Gin3pAIzNhkvJVTNNJI4ll+jQUJQ8sOwQaTz9ClUXqg46jF4fNyaUGLkmScYZp3U8SoCAW4i5FDmZXFpf43WcTmiqTnLLkOepyb6wJ3b3SSnpWbYnCPq79qbKbRs6oWtSTsDl+5MUhLx7Fila1XuJ1LiRJAuaWFTpAMM7AQpSpK2u5h/WxjhZKk1GpsjFWjPk5lSVWGwOgfB2k16AJE/JU3Z8/ifn6fYGZQPzbCAKC0BvrrKjmCTu2O2wEdTzLNRTHow1IDg89eKdag6bcx0IqxU0N+vfklKLgy2AZVOzSLaMJA9/uO69EQjnQaINw7d+4Dl9fxttRUkuMqy0a6nyW73zGw/h9/D+3kOEBIYIPw4VPYnx4wF5x+qWwLjcZ+THp1tIhcOzV/MjynCB3OSSTiAFK1kwbEmuKsN8voWf06YoOWPE7x8NuYCO3jspOD8rmAFFT2BlHDmLA9BqtdBcQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199015)(46966006)(36840700001)(40470700004)(70586007)(47076005)(70206006)(186003)(336012)(40480700001)(26005)(316002)(2906002)(9686003)(6506007)(7696005)(478600001)(966005)(54906003)(86362001)(110136005)(107886003)(40460700003)(41300700001)(82310400005)(356005)(82740400003)(8936002)(55016003)(33656002)(5660300002)(52536014)(83380400001)(8676002)(81166007)(4326008)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 04:40:56.8540 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b52295b8-d679-49ff-5592-08dacc43bf35 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8147 SGksIA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFt4ZW4tdW5z dGFibGUgdGVzdF0gMTc0ODk2OiByZWdyZXNzaW9ucyAtIHRyb3VibGU6IGJyb2tlbi9mYWlsL3Bh c3MNCj4gDQo+IGZsaWdodCAxNzQ4OTYgeGVuLXVuc3RhYmxlIHJlYWwgW3JlYWxdDQo+IGh0dHA6 Ly9sb2dzLnRlc3QtbGFiLnhlbnByb2plY3Qub3JnL29zc3Rlc3QvbG9ncy8xNzQ4OTYvDQo+IA0K PiBSZWdyZXNzaW9ucyA6LSgNCj4gDQo+IFRlc3RzIHdoaWNoIGRpZCBub3Qgc3VjY2VlZCBhbmQg YXJlIGJsb2NraW5nLA0KPiBpbmNsdWRpbmcgdGVzdHMgd2hpY2ggY291bGQgbm90IGJlIHJ1bjoN Cj4gIHRlc3QtYW1kNjQtaTM4Ni14bC1xZW11dC1kZWJpYW5odm0tYW1kNjQgICAgPGpvYiBzdGF0 dXM+ICAgICAgICAgICAgICAgIGJyb2tlbg0KPiAgdGVzdC1hbWQ2NC1pMzg2LXhsLXFlbXV0LWRl Ymlhbmh2bS1hbWQ2NCA1IGhvc3QtaW5zdGFsbCg1KSBicm9rZW4gUkVHUi4NCj4gdnMuIDE3NDc5 Nw0KPiAgdGVzdC1hbWQ2NC1hbWQ2NC1leGFtaW5lLWJpb3MgIDUgaG9zdC1pbnN0YWxsICAgICAg ICAgIGJyb2tlbiBSRUdSLiB2cy4NCj4gMTc0Nzk3DQo+ICB0ZXN0LWFtZDY0LWFtZDY0LXhsLXFl bXV1LWRlYmlhbmh2bS1pMzg2LXhzbSAxMiBkZWJpYW4taHZtLWluc3RhbGwNCj4gZmFpbCBSRUdS LiB2cy4gMTc0Nzk3DQoNClNlZWluZyBbMV0gWzJdIGFuZCBbM10sIEkgZ3Vlc3MgdGhlcmUgaXMg c3RpbGwgc29tZXRoaW5nIHdyb25nIG9yIGl0IGlzIGp1c3QgYW4gT1NTVGVzdCBnbGl0Y2g/DQoN ClsxXSBodHRwOi8vbG9ncy50ZXN0LWxhYi54ZW5wcm9qZWN0Lm9yZy9vc3N0ZXN0L2xvZ3MvMTc0 ODk2L3Rlc3QtYW1kNjQtYW1kNjQteGwtcWVtdXUtZGViaWFuaHZtLWkzODYteHNtL3NhYnJvMS0t LXZhci1sb2cteGVuLW9zc3Rlc3Qtc2VyaWFsLWRlYmlhbmh2bS5ndWVzdC5vc3N0ZXN0LmxvZw0K DQpbMl0gaHR0cDovL2xvZ3MudGVzdC1sYWIueGVucHJvamVjdC5vcmcvb3NzdGVzdC9sb2dzLzE3 NDg5Ni90ZXN0LWFtZDY0LWFtZDY0LXhsLXFlbXV1LWRlYmlhbmh2bS1pMzg2LXhzbS9zZXJpYWwt c2Ficm8xLmxvZy4wDQoNClszXSBodHRwOi8vbG9ncy50ZXN0LWxhYi54ZW5wcm9qZWN0Lm9yZy9v c3N0ZXN0L2xvZ3MvMTc0ODk2L3Rlc3QtYW1kNjQtYW1kNjQteGwtcWVtdXUtZGViaWFuaHZtLWkz ODYteHNtL3NlcmlhbC1zYWJybzEubG9nDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 22 05:19:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 05:19:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446986.702819 (Exim 4.92) (envelope-from ) id 1oxLga-0005km-QI; Tue, 22 Nov 2022 05:19:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446986.702819; Tue, 22 Nov 2022 05:19:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxLga-0005kf-NJ; Tue, 22 Nov 2022 05:19:08 +0000 Received: by outflank-mailman (input) for mailman id 446986; Tue, 22 Nov 2022 05:19:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxLga-0005kV-18; Tue, 22 Nov 2022 05:19:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxLgZ-0002qG-TZ; Tue, 22 Nov 2022 05:19:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxLgZ-000760-H5; Tue, 22 Nov 2022 05:19:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxLgZ-0004Rf-Gd; Tue, 22 Nov 2022 05:19:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=521k7uEpe/4iyTydqe/MWljX1U6VlybroCbuSs9gW88=; b=feZfFtJvCTajBOsOgtUnxwCITN m4R0+lvBYHWm7v2XE24hyWOK7ZBwGtWIu/T7nqp4ckVM56lPxfr8AUQpZ3far19AK393Q7g9r5y1r W24gf6rw64X6jBi/K0k0tj3CY7R3Sh53FyhM7GU8qcFvLOuZycTbWK+WN3MLxhHV5G5I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174899: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start.2:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=6d71357a3b651ec9db126e4862b77e13165427f5 X-Osstest-Versions-That: qemuu=a082fab9d259473a9d5d53307cf83b1223301181 From: osstest service owner Date: Tue, 22 Nov 2022 05:19:07 +0000 flight 174899 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174899/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qcow2 22 guest-start.2 fail blocked in 174807 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174807 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174807 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174807 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174807 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174807 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174807 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174807 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174807 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 6d71357a3b651ec9db126e4862b77e13165427f5 baseline version: qemuu a082fab9d259473a9d5d53307cf83b1223301181 Last test of basis 174807 2022-11-17 20:37:12 Z 4 days Testing same since 174899 2022-11-21 21:37:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Ard Biesheuvel Bin Meng Fiona Ebner Jason Wang Juan Quintela Leonardo Bras Peter Maydell Peter Xu Stefan Hajnoczi Strahinja Jankovic Strahinja Jankovic jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git a082fab9d2..6d71357a3b 6d71357a3b651ec9db126e4862b77e13165427f5 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Nov 22 05:48:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 05:48:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446993.702830 (Exim 4.92) (envelope-from ) id 1oxM8i-0000wt-9U; Tue, 22 Nov 2022 05:48:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446993.702830; Tue, 22 Nov 2022 05:48:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxM8i-0000wm-6t; Tue, 22 Nov 2022 05:48:12 +0000 Received: by outflank-mailman (input) for mailman id 446993; Tue, 22 Nov 2022 05:48:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxM8g-0000wg-6y for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 05:48:10 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 3c93c24a-6a29-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 06:48:06 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 264451FB; Mon, 21 Nov 2022 21:48:12 -0800 (PST) Received: from a015971.shanghai.arm.com (unknown [10.169.188.104]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 56B123F73D; Mon, 21 Nov 2022 21:48:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c93c24a-6a29-11ed-91b6-6bf2151ebd3b From: Jiamei Xie To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, jiamei.xie@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2] xen/arm: vpl011: Make access to DMACR write-ignore Date: Tue, 22 Nov 2022 13:46:44 +0800 Message-Id: <20221122054644.1092173-1-jiamei.xie@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", Linux SBSA PL011 driver will access PL011 DMACR register in some functions. As chapter "B Generic UART" in "ARM Server Base System Architecture"[1] documentation describes, SBSA UART doesn't support DMA. In current code, when the kernel tries to access DMACR register, Xen will inject a data abort: Unhandled fault at 0xffffffc00944d048 Mem abort info: ESR = 0x96000000 EC = 0x25: DABT (current EL), IL = 32 bits SET = 0, FnV = 0 EA = 0, S1PTW = 0 FSC = 0x00: ttbr address size fault Data abort info: ISV = 0, ISS = 0x00000000 CM = 0, WnR = 0 swapper pgtable: 4k pages, 39-bit VAs, pgdp=0000000020e2e000 [ffffffc00944d048] pgd=100000003ffff803, p4d=100000003ffff803, pud=100000003ffff803, pmd=100000003fffa803, pte=006800009c090f13 Internal error: ttbr address size fault: 96000000 [#1] PREEMPT SMP ... Call trace: pl011_stop_rx+0x70/0x80 tty_port_shutdown+0x7c/0xb4 tty_port_close+0x60/0xcc uart_close+0x34/0x8c tty_release+0x144/0x4c0 __fput+0x78/0x220 ____fput+0x1c/0x30 task_work_run+0x88/0xc0 do_notify_resume+0x8d0/0x123c el0_svc+0xa8/0xc0 el0t_64_sync_handler+0xa4/0x130 el0t_64_sync+0x1a0/0x1a4 Code: b9000083 b901f001 794038a0 8b000042 (b9000041) ---[ end trace 83dd93df15c3216f ]--- note: bootlogd[132] exited with preempt_count 1 /etc/rcS.d/S07bootlogd: line 47: 132 Segmentation fault start-stop-daemon As discussed in [2], this commit makes the access to DMACR register write-ignore as an improvement. [1] https://developer.arm.com/documentation/den0094/c/?lang=en [2] https://lore.kernel.org/xen-devel/alpine.DEB.2.22.394.2211161552420.4020@ubuntu-linux-20-04-desktop/ Signed-off-by: Jiamei Xie --- xen/arch/arm/vpl011.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c index 43522d48fd..e97fe3ebe7 100644 --- a/xen/arch/arm/vpl011.c +++ b/xen/arch/arm/vpl011.c @@ -463,6 +463,10 @@ static int vpl011_mmio_write(struct vcpu *v, case FR: case RIS: case MIS: + case DMACR: + printk(XENLOG_G_DEBUG + "vpl011: WI on register offset %#08x\n", + vpl011_reg); goto write_ignore; case IMSC: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 07:27:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 07:27:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.446999.702844 (Exim 4.92) (envelope-from ) id 1oxNgX-0003DP-DP; Tue, 22 Nov 2022 07:27:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 446999.702844; Tue, 22 Nov 2022 07:27:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxNgX-0003DI-9q; Tue, 22 Nov 2022 07:27:13 +0000 Received: by outflank-mailman (input) for mailman id 446999; Tue, 22 Nov 2022 07:27:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxNgW-0003DC-2A for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 07:27:12 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20610.outbound.protection.outlook.com [2a01:111:f400:fe12::610]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 12d19627-6a37-11ed-8fd2-01056ac49cbb; Tue, 22 Nov 2022 08:27:10 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8564.eurprd04.prod.outlook.com (2603:10a6:20b:423::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Tue, 22 Nov 2022 07:27:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.015; Tue, 22 Nov 2022 07:27:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12d19627-6a37-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BMvnq3Ko2Br6NrygAZPu2p3A1/8K+Fg+r72+7g5y3Y+w8lqLdsK5HINppYpqqxsQNcHXEEL3c1q5156JrGnFo/l0Rpa4TkDqI4cudaDhB73Pg8ct/SzfN0PIl/x562hnaSUqa+42o7daB4Aj1EphwGEHBfxDTPl7viM0uC08cwHHyNzsm86+8b92CU65He80I6erAPGdEfAnrfZkcXdi5A/ZQJ9sE1dpowCSTYqJAwSXxp7djtXNHsWjOE90HVLnCgFD3IJgBRQpCg4uIQsJewOPgPlEMTVI/XbVHLnKkzbsD1VAOtRCcxjxpcHuwXFg0/ZZsD9mTBMQyvc5Uzs5hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bj+l0B2KzTpqvQj9Zw9Y2nhgWJnlS2JA2gaymQIwPDY=; b=N7WgZP9evAuoo7/7Nz5rLbSgkYgEVYnI+ggQZZBF5Wu8/kD1cAZL+FcUq3SVeHIKxqPjNb6IY24AcOSGA+TyJVYJvm6zymA/cyS9dKpfxpTScSaCu9ML/DiMiblvJENHusMAvV6TzeKEC/BbCvFdVB2/n16BNe15HISDzyR9oKi8K5peKNxZBBgPNehy7S8E5IPqcIbpMNeSXHUKRbsYNSnOZd8Rh3Rag74Xoy4DcLVTLGBsIO8TzBdxTKTKB8vFcAXJm9vapKRij1z9CEMubXpR4UO3GUEoxkJ3Niiz+cyktlDFMvEPINUWveGR0SFBwMQ7nlL9ntBqyYbFRu0Syg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bj+l0B2KzTpqvQj9Zw9Y2nhgWJnlS2JA2gaymQIwPDY=; b=08MBm0Sv6IOql97qOdJ6KMTEnrtZ/1ta3186uoqxvZbbisXeap7pnl2v0664UuRfDCAwgny9LWaqh8ULAIEXLRnFuc4gjs9afJwi3XTDNW2NV8qeBXRe+utZTxwDJNCYX2tqEtJNf5gdlU//kwvcRvgH4I+pJwYVWlirCTM8fqBk+SExPXpyRS+IPcjzqon0WWws5Bz1mZLDUH1KOq57UIU71XC6ryIUFEKladoMxhmu68JC+OlkfCAlNOwmdh9QUDtCpRjWRbNB8b0V1J5gQFOdVhoVVsuxdPEp7SxJ5jxhvcAcbXwiE9UCqiVxKmuNmYqFgDey1sd2OqR96GIuyA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <44dfd2eb-9ef8-7254-70a1-e41177d6c9af@suse.com> Date: Tue, 22 Nov 2022 08:27:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [xen-unstable test] 174896: regressions - trouble: broken/fail/pass Content-Language: en-US To: Henry Wang Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , osstest service owner , "xen-devel@lists.xenproject.org" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0020.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8564:EE_ X-MS-Office365-Filtering-Correlation-Id: d6f246e6-55d9-4369-7b3c-08dacc5af651 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UnWsLjDPejvBGAdl5qI5W3ji7qXcfapVIbiXOhm3Xrm5YaGdofboEizUWZEJq1B2zDNpjvOLMCp1c4lQ/SjT0HenNCw9tYn37bLGFQHIJYTgRqz0a3g095K0uMh73232eMh/uvR0X2NFAoQ0TvQaEZnnCpVY3DmVyaqp4M1AcJQl0gKhDn368ixK/N9yVNGXHUS4gdbhacpfYfl5JaSPfyK+w5XkC7u0JaeGUpACvnKM1QNeULp4cdQHuSzZbhCUqDnjxlxUF0qHxvxR8YMkbw7ZJI8IH/uq7scXRyAFRVgZcUjNwue0ltv8Ygiz29h8nAJSWMtdlZHmXx5y7HgMdgLO14oP8rwmTUcboNAMFB5uGSARigCn+GaeIHNuuj3vs6/5G0abD/cZWbN5l2rXbi6T5deNC3XRd+U/oMCNXDBjLevOmbpAUZNDr4Wv57Zpym6lI/YddWcFVR+aLNuWATHXe7JSDP7uGDJmpmKr1n7FYKyf72SP5Wc4u6wtkw3fB0kNBSdUCB6cKOdFBbGsCygku8kQ5UDI4YQ1/ccK+JeObGE2IDUYVF8BEPk7SU+VVA6V76jG3EuyM/jnk46GtMjQw6qDANuILWywWS4V/In7MxB31m4K1m7+92qMuBVC4Z09Lv2X6yA9uK5IsYOR28njLqVlu8qu/ty1vsIQeboE7FVsI83wWMQrqX6f+0y7POYxZ2Mqs4nT/TqDWE/Yntnx2iZ8prta9xlAPJycery+5ZmP852rbpCYn7Fq/rkuSzE0f7RZrG1cmqmRci5LJ1Jv7Q6yKfX9yuZhAUGknaU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(376002)(39860400002)(366004)(396003)(451199015)(31696002)(86362001)(31686004)(5660300002)(36756003)(6506007)(2616005)(66946007)(316002)(66476007)(66556008)(6512007)(8676002)(4326008)(6916009)(53546011)(26005)(54906003)(41300700001)(8936002)(83380400001)(186003)(966005)(478600001)(6486002)(2906002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDZnOVQ0eHNkUnlMV2FvTHI2TE83VlZCTHpsWkpBNWdsbmRCREgvc3hnL0lG?= =?utf-8?B?aXBxM1V0cVdWZ3RkNEQ0YWMzazRXRlkrd2JLMXk0bU5LQnp6ZUxIa0Jranc1?= =?utf-8?B?MEZkVVNzcWhFdkVuNFlRQkZ3Z3RkZjExYUNuQTgwSUQxbEFSYlc1eDVBa0tZ?= =?utf-8?B?MCsxWTNRc2xKV3AyR1dBcVR4M0xuUHplUi8ra05uS24vYU1MdWIvRlZjRVlx?= =?utf-8?B?QzBjTGd5YnZtbENNNmlpbFJYTWpyNTlDMEpxRExjYy93UGlCNUpQM3k1cEZQ?= =?utf-8?B?aGp2SVhmQ0VuQU5JRm9OQTYvdVBSWUxSOVhPZ29SbHA4ZzR5OTJzUlN3TW1F?= =?utf-8?B?d1d5c2pDMTZQRkQxTlRod1dYN1NCdXpQdDRpRFJvdUVJVkI3TnRqeHRYL2Vx?= =?utf-8?B?MXZzS2dIZTEvalpjSS9FQXpZRGliajFDSGYvQkE1VWtUQ1B3Q1JLRTYwTUNV?= =?utf-8?B?a0RzU1JtaDZjUDIxL3NaQXVHWjdMZWV4blFXc2gyWTFwVFZPaGJqb2FNcXVk?= =?utf-8?B?cStTaVNtZ1AvZHpDd0UzeVJhMFdOQ2NHb08vQXBsVnlBcEVtUWFWei9kVnI3?= =?utf-8?B?ejF3d0xIdGdZa1hKbTFTTm1OV010VGc0Wk1TUUtJUzVScWhLSjFqMm5lM05t?= =?utf-8?B?WnNodG96RG54QW50bnhuUTN6dFRLWTRtVTdNVllXZEhudHE4bnhiQVlXMEdk?= =?utf-8?B?ZnJFTkVOSm5oL3Y4MWZKRWxYY1Fvd2Q5K01EVjhuanRSTU93MVY2S2lqUmJC?= =?utf-8?B?WVBzMjlsM1ppVW1hOENXSVMzSHoxM25jdWVuTi8xYWRRU2FCYk4wSlV1NGl5?= =?utf-8?B?Vk5pVWZGcTVVRXBqbjloUDJ3S0JOYVNPNzBLYWY4S2tWdStaelZoVTBjT0Mv?= =?utf-8?B?cjJVVGFwM0xNMkluNmV6ZXpvNmpsNGlKcGJOTmxaMmxVRzdrZzVWdisyZjdR?= =?utf-8?B?WUhuN0I3Tmo3Mnh2SXg4VC9GZXhyeEw0ajNqRFpPWWtVMjdJL1YrWmFTNUhj?= =?utf-8?B?b2dIODdUQVgrS3NRbUphdEJQVDFMcmdoUXVzRytCOEs2bzdBUm5yanRUNjdR?= =?utf-8?B?WXdobkp6TnA0TDlHbWRuL3UyZGVqZEhZVTd3a0RLMENBTVZTRzlOTlN1dk1C?= =?utf-8?B?MlpDaGtBKzkyV2JNK0JCdDA0MlBONFFmaDNUVDZJblc0QnVab2QwVzFVNXpz?= =?utf-8?B?QkRSL0g5SjJMVFF3eHhqdC9iL3kyb3R4dU1Mc0F6VUVlRVg2VkRVb3EwV3VX?= =?utf-8?B?ZERYL3Jnem1vOWZwdmtKRVpZbm04dlBtT2NZUlN6YzhoYkNqNjBpRzZVR2x3?= =?utf-8?B?MHAxeU5xZC9neE1SZmE0SXNOcS9UTHhYWnpycTJ5VFBLMzBjMGpIb3NTMWVV?= =?utf-8?B?c1pLZVVQQnI1eUU3bENVZm9ZS0RwcjJpS0xTU0JKZDA3OHhTT0N4b2c5a3BR?= =?utf-8?B?S2VmeFhiN21HbnQrYThnYkJOTGYwR0FSVWhnL3gvbXpDVU5Yd3pkZFpjeWZj?= =?utf-8?B?M3k0UTQxOTU3TjI4OStCMDR6cTdsVHFINFRQREhFZnVjVmZsbVVwL3dOYnZS?= =?utf-8?B?a01sQ1BlU0plYVBTN2J3TWl0NnVaNTRSbE5IMHFSZm5IalhhNnlvY2dMaFBO?= =?utf-8?B?VytsVE8rRWlGZ0hNeC9wUGlXNkRnQ29LK2xaZjEvSiszdXJ2eDNDeU9NeFRk?= =?utf-8?B?c0NRNXlmYWlnY2JZSU5KSzJkTU5UenRLQkRqUjBpNXlTRXR0RmJXR0IzSnp4?= =?utf-8?B?Rmg2cThoQmpkZFA5S1VDWXFoWWNSdWVZeFdtdlQvMVp0eDFXcStTYXFzV0NO?= =?utf-8?B?ZmRrclpyNXFqbis5b1hYU003Vm1tV0lGK08zcjloSTJVRmJvMzdDSDFiYmEx?= =?utf-8?B?eHozNk9GWk5YV2FRWXlXQjlxMWx6a2hNN0lyTVZLUS9RZm1FOFQwOTcwSVBP?= =?utf-8?B?RHJRL2xLMTc2U1k3cDF1MmpFa1cyVEVic3FkY2p5cXNqaXhJZ3RSOUwyYjUr?= =?utf-8?B?T3dJK1JjOTlmYkRXSVE3MnRBakhZRFZHbHJKMUgydkZXczB1RkRqSGNoeTRN?= =?utf-8?B?MnJtemRrQVl6Z1RENWdMMnBUWWhLWldkOXFRMlNjWTY4ZEQxZTIzMVFaQy9J?= =?utf-8?Q?8xcAoZJVcc0WgunANfVuG7oN1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6f246e6-55d9-4369-7b3c-08dacc5af651 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 07:27:07.9098 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y3k9EHP3+UgNEhbudwVNOw7KG/cV7zOQRWZGL3FKzPAfHEmdLh/2KlU6vS054nXTYvNqtsT9pXMR/hCkBfECZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8564 On 22.11.2022 05:40, Henry Wang wrote: > Hi, > >> -----Original Message----- >> Subject: [xen-unstable test] 174896: regressions - trouble: broken/fail/pass >> >> flight 174896 xen-unstable real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/174896/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> including tests which could not be run: >> test-amd64-i386-xl-qemut-debianhvm-amd64 broken >> test-amd64-i386-xl-qemut-debianhvm-amd64 5 host-install(5) broken REGR. >> vs. 174797 >> test-amd64-amd64-examine-bios 5 host-install broken REGR. vs. >> 174797 >> test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install >> fail REGR. vs. 174797 > > Seeing [1] [2] and [3], I guess there is still something wrong or it is just an OSSTest glitch? The first three are certainly osstest / environment issues, which is generally the case when a test's status is "broken". The 4th, as already said in reply to flight 172089, is a test which sadly fails every now and then. So let's hope for another flight and better luck. Jan > [1] http://logs.test-lab.xenproject.org/osstest/logs/174896/test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm/sabro1---var-log-xen-osstest-serial-debianhvm.guest.osstest.log > > [2] http://logs.test-lab.xenproject.org/osstest/logs/174896/test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm/serial-sabro1.log.0 > > [3] http://logs.test-lab.xenproject.org/osstest/logs/174896/test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm/serial-sabro1.log > > Kind regards, > Henry From xen-devel-bounces@lists.xenproject.org Tue Nov 22 07:30:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 07:30:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447004.702854 (Exim 4.92) (envelope-from ) id 1oxNjw-0004jS-RU; Tue, 22 Nov 2022 07:30:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447004.702854; Tue, 22 Nov 2022 07:30:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxNjw-0004jL-Or; Tue, 22 Nov 2022 07:30:44 +0000 Received: by outflank-mailman (input) for mailman id 447004; Tue, 22 Nov 2022 07:30:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxNjv-0004jC-89 for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 07:30:43 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062a.outbound.protection.outlook.com [2a01:111:f400:fe0c::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 90a43b49-6a37-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 08:30:40 +0100 (CET) Received: from AS9PR06CA0203.eurprd06.prod.outlook.com (2603:10a6:20b:45d::27) by AS4PR08MB7783.eurprd08.prod.outlook.com (2603:10a6:20b:517::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 07:30:36 +0000 Received: from AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45d:cafe::1a) by AS9PR06CA0203.outlook.office365.com (2603:10a6:20b:45d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15 via Frontend Transport; Tue, 22 Nov 2022 07:30:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT055.mail.protection.outlook.com (100.127.141.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Tue, 22 Nov 2022 07:30:35 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Tue, 22 Nov 2022 07:30:35 +0000 Received: from e9722d2a57cd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E952E4B6-24C1-4A6C-BE07-FDE6C49500B8.1; Tue, 22 Nov 2022 07:30:29 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e9722d2a57cd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Nov 2022 07:30:29 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PA4PR08MB5965.eurprd08.prod.outlook.com (2603:10a6:102:f3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 07:30:27 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5857.013; Tue, 22 Nov 2022 07:30:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90a43b49-6a37-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wA0TT99i4HIavR544PdA0RQqXR3ohnoiN4YpSN4GiTI=; b=zuDdQ9hPpH/k8w/+71OOi5nys3MnU9oHVer/M+yO4kLbmSsSDZM0KpKSEMNXXFL5zOoKx9OoL/Ab1Qv5RLZZGqgs8040+h2L8Z6xHE6biGsmpLrc+WfXvXYqBzhNYjT32LtsY/Y9ovcRC4mj32d83aY9aVz86SZSGZj8t/tYK90= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XGskxHLZWO5i02FLgc8ivTiYOK6iUIpcjA2QNWT3JrAc/7Ylsez9LpPvrAw4q7IjLE+8AGlQAlULTrqGnEEUkaorpNAofizWyrQV0YxyQmZVA5aeSowb01a4k8g1QaFq0hpC31uhzKUB2wc8S9kJlHdSZyeEMRWePlnsNGKovQXFWqON0tS2rjPtVtCDF7SlYP0VR4n3zoNAMhAHGElxCeYg2Tn0rwoLySHA3qEfaX7IbbHEZny0deYRU95eL6tFe3dhYkAa7DhL1maXb+4mGUa7QNEQFYrD+MDhyKmfxCJj9U7EXXs7jp8+Pv3wnwkVjEcTyhTAMbDGHRTMWmKk1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wA0TT99i4HIavR544PdA0RQqXR3ohnoiN4YpSN4GiTI=; b=meaBSvC3c3JfAMclbzAlSMXiDQjDWqsUS2YCgbBBfC1uqg4tO3hb3H4GIpVB86bRXlZlKPnifPfys7QfX5Fm7JE4sie7VWC/P8Pwzws06YgVphw1PD3quTSUpte3nRvrLX/G0XoO/T9lqb2/Hf4F+LUK7fvXfCYuopb/DBcZsRnkURuYOTPr3YeAoCqg5jLorTYprpYoDTfhmDpUwuRfLbpyOKiQysRwzn6QPiy5A58pT+X/tpG8c/YUO7CP4FHSIaCwIRPh9R/euU2q5TLeaENaICoZ9+i4lMdWeFyDLRthIr0kTpn/Dgu7iDiQtfwqAaYxFYqDmI4hfEc70pWRQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wA0TT99i4HIavR544PdA0RQqXR3ohnoiN4YpSN4GiTI=; b=zuDdQ9hPpH/k8w/+71OOi5nys3MnU9oHVer/M+yO4kLbmSsSDZM0KpKSEMNXXFL5zOoKx9OoL/Ab1Qv5RLZZGqgs8040+h2L8Z6xHE6biGsmpLrc+WfXvXYqBzhNYjT32LtsY/Y9ovcRC4mj32d83aY9aVz86SZSGZj8t/tYK90= From: Henry Wang To: Jan Beulich CC: Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , osstest service owner , "xen-devel@lists.xenproject.org" Subject: RE: [xen-unstable test] 174896: regressions - trouble: broken/fail/pass Thread-Topic: [xen-unstable test] 174896: regressions - trouble: broken/fail/pass Thread-Index: AQHY/il0mnhbZI+0lU6khiE134HQUa5KXDNggAAvHwCAAABZ4A== Date: Tue, 22 Nov 2022 07:30:26 +0000 Message-ID: References: <44dfd2eb-9ef8-7254-70a1-e41177d6c9af@suse.com> In-Reply-To: <44dfd2eb-9ef8-7254-70a1-e41177d6c9af@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E78FE4625D43294C9FC2C7503EB24B2A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PA4PR08MB5965:EE_|AM7EUR03FT055:EE_|AS4PR08MB7783:EE_ X-MS-Office365-Filtering-Correlation-Id: 09323a22-38ab-4167-50f3-08dacc5b724a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: euTEtdGxJj8EHKA5oS+1Nv0Yb+JmER5GpuB/APfrC91/RlZS4uO3G7Z9JqbdAdpmy5Tq8IkQvcwgnZmmnWCDHd4iGXkMrbx9F1irC8kHGjGw+8evmubWs2M4LHaLxDHDbmvSILJjoKV0950DPxqSxJh71GBJ6KB4BnDpURkeJWY9RCn3g7QwRA836FYo54QMLI04AgdGM3gx76Rp2ztnhm4IOclxzji0Z3o5x0TywMBeXadUBY+nRw3HLO6K5WGAnrGclHr0R7y56aTg2SsBGT5RqRxgIDpRFVIiIZVmuKW1u9U38hzsKyEfluF0Qa2cbhDe6MDHgxPOBNPFY/nBWdw1dnncF8ZabSwJE1Mx42WZ1QgIsJCvkz6C6ZfsShhWnaurxb8pTJhlGCD1XkDGe0ICTxC/+oHgfQB+qbNyB+5bUwdaCJCJJws1j+0Is0yD/U1AiV5LV1pswSCIDrXU0APvTdbHZep7LfAZ/WgTJ897XIkPoteWB3odJaOCcpKkQbdxSpqSBK2dhLuwLeNnkkvKzofxFSfnI/uS0/BsiuV3keUVmy9Jo7jGFMlUuj24/0FHkd9X0P5qVhDk2U+ytgolvR0Cp1vAuc2KpENdOLMM6WiQqxTLPpNDh7qtdkk7/BAWqzN/9r8F0CRZKLXZu3booowSS/QhXP8brq2+318MbvJZEJJvTu3ab4ZgjRjsHgGur1Xsn0RpheMzdrE7+pkNkq2oHnStgfddordY7h49TSD7VAZhtauQTaM4ALChbj46nHY30rNPmHuOFbfdHg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(366004)(396003)(39860400002)(451199015)(33656002)(8676002)(2906002)(38070700005)(4326008)(86362001)(8936002)(38100700002)(83380400001)(122000001)(66476007)(6916009)(316002)(54906003)(66556008)(186003)(66946007)(966005)(478600001)(76116006)(5660300002)(52536014)(26005)(64756008)(41300700001)(66446008)(53546011)(9686003)(6506007)(71200400001)(55016003)(7696005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5965 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 762c3972-8441-4a56-3089-08dacc5b6d0b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tmbM4UjU1rPajbKAi/cGGvRZ5ofKIBnUtt9umiEa3QNK2+k1tU2Y3+dFXvPhnBTD/PXg+ATLbUeJJPqMno/4AqfKg340qdEDdpQUHHykgg4j+XAAjzfOgxXBnHcidgVPD6siC1ckBlPS2YXcIejbZqVXSxj7RL9o8vkWZKS2MvWXo3fRYXPYh0c1xvHz/SRbxp8mr2BcHn3LkepoveWQglZwC9aYxjmj6feDSjYKvkgjg9oCq/NKvWnfi9S3EzgLAVt+G48pkwAEN5Dtj6B0gyy/hNrCzcN6KosP8wwysACBVj9gwmFOfQo6xuSxjxSKtDQz6o6FgADqQmo2a1JIzqhxl9b26u1ZrLit80PR+TGZSrxlmo8yyjjzdYMx9eEaVldWEJcVc2BXpkL96AMN4QtPXtF0unT5DrGDhnFZ13OP8wxSDKl/2Ji8wHVVexscCk34gpz162HO4HvP54Dtjg32xLHz4PW/4FHsNZx2Ms3hWplL0466RFe7nvluc2y3tDFQDym6fCcxL4mjB6Sfvp6ebAwj84VyHIHnzIjjl/cm1uoaJm3B/PikjVkOopggAvp0jrnfzZwUgE+vgPsAgM6pr+kd7FZ0GaIKOOEcAOCzfkiqnXDbPkX/cvgTNxqNFHXxUf6pJYjK7HBg7WMBcKDHqSeebZoM3UdxU/tu4JNPb7vg6kLMAXCM40zPMPRQwNxjezvWyNrntC7QnVZaNXkufKopQ3k2apLig/htUD17sUvDDfuY7HS6idCYX0SMqORijcIOrPr4djn3BCa7Zw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(39860400002)(376002)(451199015)(46966006)(40470700004)(36840700001)(55016003)(81166007)(356005)(82310400005)(478600001)(966005)(7696005)(86362001)(53546011)(82740400003)(6506007)(40480700001)(40460700003)(41300700001)(6862004)(33656002)(52536014)(54906003)(8676002)(70206006)(70586007)(4326008)(316002)(8936002)(5660300002)(26005)(9686003)(83380400001)(36860700001)(336012)(186003)(2906002)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 07:30:35.6972 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 09323a22-38ab-4167-50f3-08dacc5b724a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7783 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFt4ZW4tdW5zdGFibGUgdGVz dF0gMTc0ODk2OiByZWdyZXNzaW9ucyAtIHRyb3VibGU6DQo+IGJyb2tlbi9mYWlsL3Bhc3MNCj4g DQo+IE9uIDIyLjExLjIwMjIgMDU6NDAsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+ID4gSGksDQo+ID4N Cj4gPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4gU3ViamVjdDogW3hlbi11bnN0 YWJsZSB0ZXN0XSAxNzQ4OTY6IHJlZ3Jlc3Npb25zIC0gdHJvdWJsZToNCj4gYnJva2VuL2ZhaWwv cGFzcw0KPiA+Pg0KPiA+PiBmbGlnaHQgMTc0ODk2IHhlbi11bnN0YWJsZSByZWFsIFtyZWFsXQ0K PiA+PiBodHRwOi8vbG9ncy50ZXN0LWxhYi54ZW5wcm9qZWN0Lm9yZy9vc3N0ZXN0L2xvZ3MvMTc0 ODk2Lw0KPiA+Pg0KPiA+PiBSZWdyZXNzaW9ucyA6LSgNCj4gPj4NCj4gPj4gVGVzdHMgd2hpY2gg ZGlkIG5vdCBzdWNjZWVkIGFuZCBhcmUgYmxvY2tpbmcsDQo+ID4+IGluY2x1ZGluZyB0ZXN0cyB3 aGljaCBjb3VsZCBub3QgYmUgcnVuOg0KPiA+PiAgdGVzdC1hbWQ2NC1pMzg2LXhsLXFlbXV0LWRl Ymlhbmh2bS1hbWQ2NCAgICA8am9iIHN0YXR1cz4NCj4gYnJva2VuDQo+ID4+ICB0ZXN0LWFtZDY0 LWkzODYteGwtcWVtdXQtZGViaWFuaHZtLWFtZDY0IDUgaG9zdC1pbnN0YWxsKDUpIGJyb2tlbg0K PiBSRUdSLg0KPiA+PiB2cy4gMTc0Nzk3DQo+ID4+ICB0ZXN0LWFtZDY0LWFtZDY0LWV4YW1pbmUt YmlvcyAgNSBob3N0LWluc3RhbGwgICAgICAgICAgYnJva2VuIFJFR1IuIHZzLg0KPiA+PiAxNzQ3 OTcNCj4gPj4gIHRlc3QtYW1kNjQtYW1kNjQteGwtcWVtdXUtZGViaWFuaHZtLWkzODYteHNtIDEy IGRlYmlhbi1odm0taW5zdGFsbA0KPiA+PiBmYWlsIFJFR1IuIHZzLiAxNzQ3OTcNCj4gPg0KPiA+ IFNlZWluZyBbMV0gWzJdIGFuZCBbM10sIEkgZ3Vlc3MgdGhlcmUgaXMgc3RpbGwgc29tZXRoaW5n IHdyb25nIG9yIGl0IGlzIGp1c3QgYW4NCj4gT1NTVGVzdCBnbGl0Y2g/DQo+IA0KPiBUaGUgZmly c3QgdGhyZWUgYXJlIGNlcnRhaW5seSBvc3N0ZXN0IC8gZW52aXJvbm1lbnQgaXNzdWVzLCB3aGlj aCBpcw0KPiBnZW5lcmFsbHkgdGhlIGNhc2Ugd2hlbiBhIHRlc3QncyBzdGF0dXMgaXMgImJyb2tl biIuIFRoZSA0dGgsIGFzDQo+IGFscmVhZHkgc2FpZCBpbiByZXBseSB0byBmbGlnaHQgMTcyMDg5 LCBpcyBhIHRlc3Qgd2hpY2ggc2FkbHkgZmFpbHMNCj4gZXZlcnkgbm93IGFuZCB0aGVuLiBTbyBs ZXQncyBob3BlIGZvciBhbm90aGVyIGZsaWdodCBhbmQgYmV0dGVyIGx1Y2suDQoNClRoYW5rcyBm b3IgdGhlIGNvbmZpcm1hdGlvbiwgdGhpcyBpcyByZWFzc3VyaW5nIGFuZCBJIGd1ZXNzIEkgYW0g Z2V0dGluZyB0b28NCnNlbnNpdGl2ZSBub3cgOikgU29ycnkgSSBzb21laG93IG1pc3NlZCB5b3Vy IHJlcGx5IHRvIDE3MjA4OSwgbmV4dCB0aW1lIEkNCndpbGwgY2hlY2sgbXkgaW5ib3ggaGlzdG9y eSBmaXJzdC4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkgDQoNCg0KPiANCj4gSmFuDQo+IA0KPiA+ IFsxXSBodHRwOi8vbG9ncy50ZXN0LWxhYi54ZW5wcm9qZWN0Lm9yZy9vc3N0ZXN0L2xvZ3MvMTc0 ODk2L3Rlc3QtYW1kNjQtDQo+IGFtZDY0LXhsLXFlbXV1LWRlYmlhbmh2bS1pMzg2LXhzbS9zYWJy bzEtLS12YXItbG9nLXhlbi1vc3N0ZXN0LXNlcmlhbC0NCj4gZGViaWFuaHZtLmd1ZXN0Lm9zc3Rl c3QubG9nDQo+ID4NCj4gPiBbMl0gaHR0cDovL2xvZ3MudGVzdC1sYWIueGVucHJvamVjdC5vcmcv b3NzdGVzdC9sb2dzLzE3NDg5Ni90ZXN0LWFtZDY0LQ0KPiBhbWQ2NC14bC1xZW11dS1kZWJpYW5o dm0taTM4Ni14c20vc2VyaWFsLXNhYnJvMS5sb2cuMA0KPiA+DQo+ID4gWzNdIGh0dHA6Ly9sb2dz LnRlc3QtbGFiLnhlbnByb2plY3Qub3JnL29zc3Rlc3QvbG9ncy8xNzQ4OTYvdGVzdC1hbWQ2NC0N Cj4gYW1kNjQteGwtcWVtdXUtZGViaWFuaHZtLWkzODYteHNtL3NlcmlhbC1zYWJybzEubG9nDQo+ ID4NCj4gPiBLaW5kIHJlZ2FyZHMsDQo+ID4gSGVucnkNCg0K From xen-devel-bounces@lists.xenproject.org Tue Nov 22 07:34:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 07:34:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447009.702865 (Exim 4.92) (envelope-from ) id 1oxNnx-0005LE-Bo; Tue, 22 Nov 2022 07:34:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447009.702865; Tue, 22 Nov 2022 07:34:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxNnx-0005L7-96; Tue, 22 Nov 2022 07:34:53 +0000 Received: by outflank-mailman (input) for mailman id 447009; Tue, 22 Nov 2022 07:34:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxNnv-0005Ku-IR for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 07:34:51 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2061c.outbound.protection.outlook.com [2a01:111:f400:fe16::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 254fdcfa-6a38-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 08:34:50 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7009.eurprd04.prod.outlook.com (2603:10a6:208:19b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Tue, 22 Nov 2022 07:34:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.015; Tue, 22 Nov 2022 07:34:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 254fdcfa-6a38-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JoXpqeRG3dpREgaEqv87AO6oM7JtYEi8LeTTn93ZQBwC7jyRb2tvRHkNdEQaGg+PGNcvXvmWSsvIof2B7Jj+U33tTzM3H+pERJh5acXnj6TjuCixSqtc7+KB4ktifQImd4+QtMwhyttAulIlVlBSD7NUM9LS5GU9uVMif26hmG+lhaPnPGzEPupCcY9hUTkD5p7vjIyDt3WRBgYJg3guUeax3gtQnQjOdyrLo++Hy9znpDdm0NW4752znRhHM5Er+xrZBoaTC/MBY+hcq2qDmOvtx69OaWeBZ4cOost2t8jkpq7SQZug3UI8MdvzlOVJcanvTeWM5x0s6XsnQRB84A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QtZVCz7ByEpoqFK1T38WnG0kgLWnuHbUKrfHS2fQ0tM=; b=CJFM8Gpnh+xk7vSwuSYDC/Ikh8whH3lAE2xgzHxYBbtMHsfUG0g5FH6HUxJMlCr6IMpDlOu6vpmwRIhA/ldMM9YpcJWz5Ie9zH+KXYx+6TbpAe4jxOw189TcXOqtCp/Pgb5017i1Kn8boCHFbnKD6iBm1PagZ+BAfaEU1f6IQanNojfHEIhUAi1EdcZE5etB9XgxoVT68uV1Bt9xvywupjuEzY7Dw/xrUdLBemeMBcG8+ZpbCXTyH0ycx2wPzEDsOhCL32TrWnl0sdGXeGKyX04/gHX1T/+R15NpjSBUuFkNqfalfW9UL/kpf7ZSTDR1FmFC6AzUKr0R/7Hec2R59A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QtZVCz7ByEpoqFK1T38WnG0kgLWnuHbUKrfHS2fQ0tM=; b=CMS6osAoXhiqwRHeTxkCOeiooQoI5MJedxuHzO9e//Ew/qNMr0NeeZlrQzfPcCByLdYvSWnmSx/6+gN6twA7jQ0uWe7DCJST41qm4mLx25xCYt1aaHOCZxsXOMd6SWyiXWiD+M3vm7C7kIaE7q7DfDoKRy2xdO+BfzVSqdNXCKMIMTSy9niA66KU4lV/ygUy6GU+x4rsa7eYIPDnrEu1F1LG7YJ3FWFAsSM712xxIL80R6yusiRRs1A3a92desuyF0jRs2sHgKnkMUhUZuVF+T8+a1o9/X/xDSPSsPKXIhuEoUzxi6+FyeX/HHtAsB5U8RYVPZfEuPEK6WNiAjve6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 22 Nov 2022 08:34:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [xen-unstable test] 174896: regressions - trouble: broken/fail/pass Content-Language: en-US To: Henry Wang Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , osstest service owner , "xen-devel@lists.xenproject.org" References: <44dfd2eb-9ef8-7254-70a1-e41177d6c9af@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0167.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7009:EE_ X-MS-Office365-Filtering-Correlation-Id: 711adb46-316b-450f-c961-08dacc5c0806 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dASH9ayZ0mBXpLYkJpF6MLu9sOffH/kh12bvFEVtQIY3M3tG7Xk4bXWCmhIkBltRoLsG4+2a1mTHMSPakm1U9+Icyfse+ES5Yk29tOBbBubf16/jYVX7D2Y/rPYWd4GSST5ZVoWNkAY1QQkAhpffaM3vezM21hrrVi+tGnb67R8rlU6A3vxac+QcT1wlI28DzIJkQLFx3B6MY7xy4B8PdETg4kAzHJVLYKUfdEx6ymkA97OlRc/YgMdfeLlJXyzAXBxZFnN9RC4F+8unuAn71M8hl1uOxCdbvs/7ITtnbaKtZyGUfUnQug018JsYwMGVZbhnhlWaJe3elBbxalZDER5cwMRTrlYA2hQuknQbF0z6ijRR0yeZRa5thLlQ7XNiRk8cZTafH3Mt9khWa82VejoIKyQh9DIOMIvmEdTXtq3mZEFGiGrpff5432yBbrmhUj7QlSwXknTcbbOGLEY/2MTHUo0Wbj9QKi/WUHlywLfZxcVFGchDEQxqpeBbF8nFl30Y14xE8d9eY015wJ3DwaX7BmDCCJui8YvO2ucqwCw+WMdbLg8cw1wFWW2lyrY0y0H/BjxKMf+YAjI8hlR+6qA6uTYSNE9Awb3w/EG9wh9bcAy3ilKRC3XW9O9vA+nXxsh1YxWCGmPTTb20sKwzcB1Spg/ghtnMiKstI5QI8dO/vF9CXzukSdgDrEk8evJBQnoMtAaBtmwuEftyazNyfQyvIht7LFxjGQJkSsXPkjc/UjK56A2AKydq+hRH7Ef8mnn8Kq5R2cZoUanfcQrj9w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(346002)(366004)(396003)(376002)(451199015)(6512007)(86362001)(31696002)(83380400001)(38100700002)(2906002)(41300700001)(8936002)(186003)(478600001)(4326008)(53546011)(6506007)(2616005)(26005)(316002)(8676002)(66476007)(966005)(6486002)(54906003)(66556008)(6916009)(66946007)(5660300002)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWhuazNnN1NZazV0YkRJaWdjZ2VhclVzd0VvSEhqZjFTZXV0YmhYNUZzZGFx?= =?utf-8?B?RkcrQ1FlSUhOVjIydEJhOUoxZ3graEJwVGJCUU80d09kdU50YSsxMUhXYzAx?= =?utf-8?B?OGJzdDMvR3NkWXF4QTA1d3VQT1VnMjAwZUNpbGVDdXBEc29nclVhR1pDY0Vo?= =?utf-8?B?bDR4dkdCT0ZUbjl3Qno1ai9BcUhMVmtTWVlKZEpXZVhyWEcyZkdUT0Rha0xX?= =?utf-8?B?cmQ4aGN6L0ZGclp3bnBBSEdLNkZzNjA0ajBEQS9XaHpibkVIL3k5RzV5c3Vq?= =?utf-8?B?UDJHNmFXbUwzRmpLeVNWL1ZoMFNSTmtMb2dBYlpNWXl6SGd0dCswM2lHc2lN?= =?utf-8?B?NWVmamZMN3FUd2tid3pXUkYwd1dBbWgrci82eERCU1dMcnA5dkhwVFN2TzdP?= =?utf-8?B?VWFadHpDSGFIOVVIT0w3cmRpeGNhRWhPaWlyMUVWZU1Ma3VvSXhjTmNRR0c3?= =?utf-8?B?aC81WXhGTXBnVW83QlIwQXZWYjNDQTFiYlNRR1hlQWQ3cTBWRWo3UFl6M2FK?= =?utf-8?B?SXJRMmxjU0pOTEhMbFJ5OTVYMzc5Ui9iUWliLy9MN3l4eDRnTXNVQkQxcDBx?= =?utf-8?B?NHZQQVhtejRLWm9va2ZQN1Q4KzBmdWt5Z3Nmdmpma2l6YWR5VzBzVi9jblBv?= =?utf-8?B?aEZaYU82WVBtTlZ2Y3p1STdLTElvV05XTnFQVGtBaWxpSXNTWDJ5eTZTQUdu?= =?utf-8?B?Mll1dGlMZU9SM2VEVDc2ckhNVWk5MkRIb3NORzVWc2J2Z05oY1FlSGdpTjRR?= =?utf-8?B?dzFnR0NzTS84RUp4Rk5tQ2JPbXBkUDMvMExuRm1DaHlGWWRNdUVLRzJINTJM?= =?utf-8?B?eU5NYmFVTDNRVVlmZVpHK21abXFvL21najBYVEpuWWF6UE1aRDgvWUlpS29Z?= =?utf-8?B?aXZPVCtKYmg5blJhdzZCZURER1dNcjdDNis2RDVpQWs1clB4UlltR3R6TjNS?= =?utf-8?B?cnMyR2dKNmlESFJjNThONVZwVXFvTTEwMG80dG0zWUFQMVBuLzBQTzlGYW5H?= =?utf-8?B?SVRMcTZJMzlldUl2Q0R2OFl1OU9pakM5TnJVSkdYdXlDbFlSa3pZSk1EdFZo?= =?utf-8?B?eE4wNitZdFZ4SHB6YVNyL0ptUlhPTElZcmMvdXJOYlJuVmhsajhyMk5NbFdk?= =?utf-8?B?MzIyZEk0NVlkWDZuZExmeGRnTlhMOFRlVGhVQXErTW00Qkx5QjMxQnY1NlI3?= =?utf-8?B?RGZGaWRDWHZMekNFZGhldmFkQjVhNTFGTllxek4xRG9EcFBqa0ttTGc3VDFl?= =?utf-8?B?SUFjSVp0clBpQTV0Z256bEYySGExSThQM2U5N05IWUV2RjFEMTd1Wll0dGpC?= =?utf-8?B?Tk95RE80NUpPNDFHRElzNnFTTGg2bzczUkZtR25Ga2ZkNVp0VHJvVjgzek92?= =?utf-8?B?UFZubldYVW5VTTZ0ZkpIemRLeUhKaDVKSi9yNkdnalFyd1RncFArOE5nN0tl?= =?utf-8?B?RFN2M2N0QlM3WHIvdExsTkVtN0ZUc2oyaFJiYUFsYUl5eENBcEoyQmtjNFJo?= =?utf-8?B?Nm1UbHVRNG5kYnNYN20rOWxJeldhUTVKYTBvTmE2RXVHNTBYenZkeW1mNEhs?= =?utf-8?B?OXV2S3Rwei80WGJxNjdaOW5xUWRza3p0SDcxZkxDN3hzaDI2WmQvQzNCRzZ1?= =?utf-8?B?ZG9nQVNLSmxCT0ovSzZJTlp6TlBWWTFBQ1h3NVcvelRueFNWY1dNZTdnOTBl?= =?utf-8?B?K0lQWC9RN1BRSFRrUFhaT1ZvN1FnKzZ6TEp1OG1aODg4OGgvaUlmZElqVk9m?= =?utf-8?B?c1F1YllkY1Axb2MyVUVWc1pUQUpINTBUYWtQbWdHN091dWhPa1F0MWJkWGwx?= =?utf-8?B?OFQ1WlFYcEZUWFNDVXY0eXRjT1ZwNGN0aUliVXgzK09ObFE5bFhjdVpRQ1Bp?= =?utf-8?B?RFA2MndFb1R4elp0SW1tUHBMWENoQjc4S0hYYTdhRDBucGRuTkRtL0FJREtG?= =?utf-8?B?WWROaW0yU3c4VFg1OGxqVUI3b1ZaYXI5WngwM1gyazgvVVlXMldHUE5ib2Nj?= =?utf-8?B?U3B0cnJtVjZ1Mzg0OGNUbnl0YUtBY3Qxd2d2UzVLcVh1SzlLdm01dnEzeFlV?= =?utf-8?B?UXBIbU0ybmJQSkNEOTNiN0xXTkhNWStObGcreGoxZ0RQUUhCTStBU1lPdW1j?= =?utf-8?Q?rHC2Y64rKps8Tws3BVvLpZ3py?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 711adb46-316b-450f-c961-08dacc5c0806 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 07:34:47.1785 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nGfJkHF8NGZ9Q1MVFmyNLJUzzY6/8OmKzFpYdM7iaBKVZbDRafL51HuTg/PQTECQSn0QnpElQZfXn3HMWkBlMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7009 On 22.11.2022 08:30, Henry Wang wrote: > Hi Jan, > >> -----Original Message----- >> From: Jan Beulich >> Subject: Re: [xen-unstable test] 174896: regressions - trouble: >> broken/fail/pass >> >> On 22.11.2022 05:40, Henry Wang wrote: >>> Hi, >>> >>>> -----Original Message----- >>>> Subject: [xen-unstable test] 174896: regressions - trouble: >> broken/fail/pass >>>> >>>> flight 174896 xen-unstable real [real] >>>> http://logs.test-lab.xenproject.org/osstest/logs/174896/ >>>> >>>> Regressions :-( >>>> >>>> Tests which did not succeed and are blocking, >>>> including tests which could not be run: >>>> test-amd64-i386-xl-qemut-debianhvm-amd64 >> broken >>>> test-amd64-i386-xl-qemut-debianhvm-amd64 5 host-install(5) broken >> REGR. >>>> vs. 174797 >>>> test-amd64-amd64-examine-bios 5 host-install broken REGR. vs. >>>> 174797 >>>> test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install >>>> fail REGR. vs. 174797 >>> >>> Seeing [1] [2] and [3], I guess there is still something wrong or it is just an >> OSSTest glitch? >> >> The first three are certainly osstest / environment issues, which is >> generally the case when a test's status is "broken". The 4th, as >> already said in reply to flight 172089, is a test which sadly fails >> every now and then. So let's hope for another flight and better luck. > > Thanks for the confirmation, this is reassuring and I guess I am getting too > sensitive now :) Sorry I somehow missed your reply to 172089, next time I > will check my inbox history first. Oh, I'm sorry, no, this was not a complaint in any way. It was merely an attempt to make people look at the state just in case they can see a way to analyze the cause of these random failures; I for one still have no good idea. Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 22 08:50:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 08:50:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447027.702885 (Exim 4.92) (envelope-from ) id 1oxOya-0005C7-9w; Tue, 22 Nov 2022 08:49:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447027.702885; Tue, 22 Nov 2022 08:49:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxOya-0005C0-7Q; Tue, 22 Nov 2022 08:49:56 +0000 Received: by outflank-mailman (input) for mailman id 447027; Tue, 22 Nov 2022 08:49:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxOyY-0005Bu-Va for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 08:49:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxOyY-0008NE-RF; Tue, 22 Nov 2022 08:49:54 +0000 Received: from [15.248.2.8] (helo=[10.0.25.11]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxOyY-0004EN-JB; Tue, 22 Nov 2022 08:49:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=3i8A1aBCbmGOrESZEj5Q7r4ODp5BGjHK4a0BMzIHuvw=; b=vTYIQvdyyiUa5l+2q+sgPivY6o 9Sr7KmIEal1amC8iZKhbCzKFDSGki+LOyojhkUBFH69tBgVNJ6XDad4TLSE2XaMgQynWdT97VV1SP 4kPNeFXOREJRbHh9GUiEjQQdTyFLUwX2ZnLtYpAF2TEkBVJ+1grzPpR8YPI3VD3arkBY=; Message-ID: <22626b14-8047-8fbe-0668-5caeff304640@xen.org> Date: Tue, 22 Nov 2022 08:49:51 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/2] Changelog: Add __ro_after_init and CET To: Andrew Cooper , Xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20220309123936.16991-1-andrew.cooper3@citrix.com> <20220309123936.16991-3-andrew.cooper3@citrix.com> Content-Language: en-US From: Julien Grall In-Reply-To: <20220309123936.16991-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Andrew, On 09/03/2022 12:39, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > --- > CHANGELOG.md | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index 83d85fad5bbc..577517383ec9 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > > ## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD > > +### Added > + - __ro_after_init support on x86, for marking data as immutable after boot. This is also supported by Arm (see commit ace403022358 "xen/arm: Support properly __ro_after_init on Arm"). Cheers, > + - Support for Xen using x86 Control Flow Enforcement technology for its own > + protection. Both Shadow Stacks (ROP protection) and Indirect Branch > + Tracking (COP/JOP protection). > + > ### Removed / support downgraded > - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 22 09:47:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 09:47:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447046.702903 (Exim 4.92) (envelope-from ) id 1oxPsC-0003QK-Rw; Tue, 22 Nov 2022 09:47:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447046.702903; Tue, 22 Nov 2022 09:47:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxPsC-0003QD-O8; Tue, 22 Nov 2022 09:47:24 +0000 Received: by outflank-mailman (input) for mailman id 447046; Tue, 22 Nov 2022 09:47:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxPsB-0003Q7-7U for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 09:47:23 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a7511804-6a4a-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 10:47:21 +0100 (CET) Received: from mail-mw2nam12lp2043.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Nov 2022 04:47:16 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BL1PR03MB6120.namprd03.prod.outlook.com (2603:10b6:208:311::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Tue, 22 Nov 2022 09:47:15 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Tue, 22 Nov 2022 09:47:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7511804-6a4a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669110440; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Eet2K4HA2p4b2alsskA3RB5poZhyvxZa3rI/wBToWJ0=; b=AhZaXSpkEO+7mg822NqU1NB3zpk4ZXxch3tKltrhWCiSu8NcqFsQbq/b 7emJqXY7dPka3lrNd/PpQp5eQ6gugsrbAPSEWQg3NAkr2k75eE9O/XdXI DY9UGwJ+J8TrWNjJtiZnzFeQUJkNFgcjuwhqFbQSDRGLjqFiCAA2l9mMV 4=; X-IronPort-RemoteIP: 104.47.66.43 X-IronPort-MID: 85317572 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Pu4vta6Q99ai+BPtm+gpMQxRtBvGchMFZxGqfqrLsTDasY5as4F+v mQYXGDXM6uOMWv0KN52Pozk90wD6JbUxtM1GVc9rCFjHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkR5geH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m+ c5JJzBcQh25nf+X7IKjaM48md4DM5y+VG8fkikIITDxK98DGMqGZpqQoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Nkkoti9ABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prr+SxnqkBd1IfFG+3vtW3wKU9n0tMycHWmH8sMCTjFW+Ut0Kf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHsrKPTmmG3qyJtj70Mi8QRVLufgcBRAoBptz8+oc6i0uVSs45SPLuyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CBhRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:s4Hml6/A973Hqq98tyJuk+G4dr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpixBiSgSiu4LvaFQHd+hsFSTtAzZor7G CAymXCl++emsD+7iWZ+37Y7pxQltek4txfBPaUgsxQBiTwhh2ubIFBXaTHmDwuuumg5Hsjjd GJiRY9OMZY7W/XYwiO0FDQ8jil9Axrx27pyFeej3emicvlRAgiA84EoY5CaBPW52cpodk5ic twriqknqsSKSmFsDX25tDOWR0vvk2ooUA6mepWq3BES4MRZJJYsIRa1kJIF5UrGj789ekcYa BTJfCZwMwTXUKRbnjfsGUq6NuwXk4rFhPDeUQGstz96UkioFlJi28jgOAPlHYJ85wwD7Ne4f 7fD6hunLZSCucLcKNUHo46MIWKI12IZSiJHHOZIFzhGq1CEWnKsYTL7LI84/zvUIAUzaE1hI /KXDpjxCEPknrVeI2zNaBwg1PwqD3XZ0Wu9ige3ek0hlTEfsurDcXZI2pe1vdJoJ0kc7/msr iISdZr6sTYXBvT8LZyrnPDsqZpWAgjue0uy6IGsgG107X2A7yvkNDnW9DuA5eoOQoYewrEcw g+tX7IVYh90nw= X-IronPort-AV: E=Sophos;i="5.96,183,1665460800"; d="scan'208";a="85317572" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hyGMiIlr0MJnsiXNxnYlZ0uM2Mk7scfmhLUChBcSyLdViBXHbT1CHj/1wNJCuB4OjI/SZdTANMrkigaU0wqhndX/JLzWHjFcg7r6R6eZGMGb7X0vAScG5qqTNn1k9F4Y5LNsComQM3spBH6kfIqfVAXOWSeeGGZlUz00+cxCWG1Z33Hu9Ikeqxz/iX3tZGkGj9cVP8wnD2zwaeDrAM7lW6BLeetxd3x6JV1Z3x85atc+RKewo3p/Dh+rk5a+KQNEG5kjl5SyfTgqcvbzw1XiSqIhsFvDTCPn/d3ke59c3VxjS8EPRIzL1xOFOtNxukLTvyjXD8jiek94kHwLtkiyOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AzNgKsvmxEG7MU2AdrR/ACp7s33x3ImYCR9I6zf4s+0=; b=mWNSPwrhJ7u7VgM0tHQ3hoZuaTofduF/0hLrKagPEaOpVUAJti63p4KSWCxkI/0YIbyw0yj3fNvwU8cUvokrE+MA8aCbnoIxZ1QWtq/3kUMKG06X7ySOTWhAhN84USPJzQXmWTMrQPUyJNbLyKN4g3dzh9f6Xk8p+dYhGJFj0cSxdfNDoGPCMy6RS+8sGMX8ceuFx4kUc5gV60YpUHHa9IoF6UUR9J3j2mn+7/8AlBxkd1dDRuQHnFmt1tU5NZcxJnyi6wz7qYN0YeDmkABMUI/wuZoZqndXiipcPPnbA15N+vLIZyp7SRd2PY2wqI6cYkIhMNJFkfvkT7dv/9IA1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AzNgKsvmxEG7MU2AdrR/ACp7s33x3ImYCR9I6zf4s+0=; b=uH3DXGR+RA9tJxpbyYNpKgKxOTe7GOcRhK8gdf9y8rOp2W1IZ8YMiOEv/OLVA056uLFEkyTxW6XVODMSEazVDyvFoLNyIJPcQWuhPonxPr5fbhahZaumlw+mq7bDjz06FzDJkOC8vht00/Hdmc9ZmBOTKSIWHJqwQsGs9FdLUs0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 22 Nov 2022 10:47:09 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Juergen Gross , Andrew Cooper Subject: Re: EFI's -mapbs option may cause Linux to panic() Message-ID: References: <60663f81-09cd-e46b-bb94-1afe50519086@suse.com> <296f95d8-5506-c95d-1c14-915cbf3e4f30@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <296f95d8-5506-c95d-1c14-915cbf3e4f30@suse.com> X-ClientProxiedBy: LO4P265CA0238.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:350::11) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB6120:EE_ X-MS-Office365-Filtering-Correlation-Id: 33947344-a4d1-454f-ff28-08dacc6e8951 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y8PkyCgQUOEhrqXgsj7VC0ofEVxinCyZil3VJL0Ep9L5Lppui3UBMIVLW/qbTIAu5Z1ApjldVTHENaKMmKpj343ryBwOjEqf+8OZORpRkWPjtrHM8pdzrPv4LQVGRfxMXHqaPg83AfnJwH9mkVXJkGBHnaL394hU02BfAxPUbohxl5Cl3b7ZMWXp9tKM94lrPl5WVyyrIN9Ochi6mrrH5APIQEhNCufZn3sXZuvRkMVv1r77pyBcF1Ii/IwlEJTsKOWZiyN8vXUws91trtavZ3R2b3Cm/l73ZVwI3whXj6lvgVF5h650zAZkUK1OM3Le+212vMcjk45OqD/aDBR76+m8Cip+0cUfVGGTj7ZlJDODj/+8If/5qeAqUUYRXKgbUOw0BJjXw/dmU0oCbxi3GrIBPAH4Wu/nbowN4pmLPhHF0Z7arX5+HuF3fvI2yOrIBZZnm6lC/Qx58+QGT5GSUB0JXd0B4XhsOWqs+dSoAV40HH5DIBfaD12bkiB5ksnv8us/dNMyHOiI6+T97NzSg5JWP/EbIsSXGe+Ka4mc9Uw2TbW/EsKzV3IZDnNtow1MeqTh8zAOBT9JlE1KPcKRU5/7aTwwtsg6y+lzyKV8YPL77ys22PYu72wQ7bhVHLq8wCR2dWS3+ygxR291RXObwA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(366004)(39860400002)(346002)(396003)(136003)(376002)(451199015)(86362001)(85182001)(66946007)(41300700001)(186003)(66556008)(66476007)(478600001)(4326008)(8676002)(5660300002)(8936002)(107886003)(6666004)(316002)(6486002)(26005)(6512007)(9686003)(53546011)(6506007)(54906003)(6916009)(82960400001)(38100700002)(33716001)(2906002)(83380400001)(66899015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUVUQmx5RmVUQU5RaFBNMmRGUkJGbVhVMUtUelE0czBDb2xqb1NWSHA5RWhK?= =?utf-8?B?TXR0MWsyRi93T3Q4OGRuN2ttdlBMUWg3dy9aelh1N0lDYzFZcStPSzlZdSt2?= =?utf-8?B?SzBybklIY3I2M3ZpUFRxUFNNbUxBZlpkc3NvSXhrcXgxT2FWc2c4TUdGUGhO?= =?utf-8?B?bVlTNEFHeGhLdnlacG9GQXlhM1ZHZFM5NDdqZ0ptT21WK0JJU1p3S1NxRE5L?= =?utf-8?B?VnVBb20xMEY1WGJJTnVKa0Z6ZXU3RlhLcjc3eEs3UVlNaXIyMHFjOGZJZkFa?= =?utf-8?B?U1MxaHo5WlFLYXpQayt6NWN3USsxYWZoNXlrMm1mZ1NhcUVKYTFKZFltTENp?= =?utf-8?B?UnF3bkVJeTRZT1lzanZDRndnZVhNMldYMExTMnBMbnIxQUJSd2E2ZDhxNnNt?= =?utf-8?B?OG9TSzJLb040VkNxbklReG9nTW5hNlprK1R2d0RlclR4eU95OG1ZNmY4RjJL?= =?utf-8?B?RHJwODdFaXJlSGlJVHNYRGYwOGdOVXZmdWZGeU5TRVVzR3FnR0M2eW1CcVkr?= =?utf-8?B?MFluSGF4aGJJNkJMNlQ4Y3hNRnh3YXZydng1YnFLQWx3VVh1eStkdUtQMU5O?= =?utf-8?B?NkJpK3ZsbXFxV2szMVNySlFBWFhkYk0zWGprRFJBY05UaElWRk9Xa3MydjdZ?= =?utf-8?B?djVIZkd5QjhnTXdqYUFxSzkyMUlBZy9EbmFwYjc0N3lRVjM1V21jeGdiTVdF?= =?utf-8?B?UnFYV0hBNGlHSm0xNXNUT0xMbnZxZG4vc1h3azVLeVRPdnh5QWh4SGVmZW04?= =?utf-8?B?bThhaTVFSWdOSlJJY0NubzNPRmdjS2JaV3ZIem5LeWQ5TytNcFRqOW92dThl?= =?utf-8?B?NlZTdXI5WURVV0RnV3BzV0tiSE5Qd0RycUFnYkNLb3AwMFpGUEM0MmRMWEVq?= =?utf-8?B?TTNSekVES0pNQ2xPVUZKeFB3U3VkS1JLR2pTdWhuczk3ZW5FWExGbVEza2RC?= =?utf-8?B?bDFBd0RTMldNRkVuMmQyNVhVRndZenRSY0ppaXp1dDBkOXpnbTJ0T0EvUHFF?= =?utf-8?B?QWJneTJ0dFR3QmZwT0FKYzNDZ0x1K2Z5RlB0aWRid1kwTTdIV2NMV3B4NG1m?= =?utf-8?B?bEZxTmR2aHVHNXhrWlpZS1J0cVc1Q2JkNU1JeUd5eEFJaUxUY0c5U2Z4bHRO?= =?utf-8?B?ZHd3MjdkWExLZFNBUmRjLy9qSnRKbHVoWUhhMXV0Mm4rZkhCR0xFOUhMZSt6?= =?utf-8?B?V2NxbFA1YzhKZ2JhcWk3UTE5bUN3cmNyVm9rWDk2SXlSS3dERHl4WElYcnBa?= =?utf-8?B?bkpISGxtTWo3eE8wazRGbG9TWURmYXQ2amJWbHRjZE9HS3BLM2NYRjljaTA4?= =?utf-8?B?UlNqMnBYdkZSS3dvTjlTUE5uQUJJNnFENWZtNnQrYlFWSVV1Znd4c1F1azkz?= =?utf-8?B?N3dRRXdVcW81UWRwQTBSYW1PRHRDck1ZSGI2YkhURFVuV1JIa2M1aHFJNnlL?= =?utf-8?B?MFdBaFdTaXZxQWtTdzFCN2JtZng5Q2s0QzMyYUNxWWQ4TEhCNUpsTmozMzRY?= =?utf-8?B?d1lpbjNuTEx5Nk9pOUZDSUlYNWx1NUtKTW9RSXd3K1QyUjBjbjFUTkRRK2ll?= =?utf-8?B?dzNRd28zL1hOak54RXhrdGJ6dWw3azFZMzYyUy9HN0ZvMkROZ0VLakhXOWxG?= =?utf-8?B?NlF5WE1RV2dZTUxVdG9qV0RCRWc0VllyUTRQQ29jejVDd2RLeFNJUUsvai83?= =?utf-8?B?K2wrWkZzeFJtUmFkTHZ3NHdoemcrRTRsdWdpWll0UDd5b3RhZDgyUUVzR2dL?= =?utf-8?B?Vi8vTTVIWjUxbytrdm5kM01mUzQ2VzdOVHZZUXVSUFljaFRhM2h0NGV6TVZV?= =?utf-8?B?ZGJQckkzbWhGTFd4NnMrQkdoK2xoWDN3RlNObmJ4L2RXOGNwVWlYYXlYMjMw?= =?utf-8?B?aDlYcmY5NkFzMkp4anh4cVhyRW9EcnIwRmM1T1FONFR4MVJ1WWFhZVYvaUtN?= =?utf-8?B?VnJHc1Q5VUYxanVaTXl1VHp3ZGVkcnF3R2VRSTFqcGRlaE9FUGdxU0lHdzg2?= =?utf-8?B?VU0yclRWUXRqYys2RFZXOVZ6cW5RWmVMWmppclpIQW1nb1oyd2N6RnU1T0sv?= =?utf-8?B?NU1LN2RIYVpOdTBWdEVvYWVrZkZENWdDL2FJd3VNam1FZVFyVll1bkMvLzVj?= =?utf-8?Q?AATAzCfLesVyEURcZWslnxbqD?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: lh1+HuUKFG4rV+1FDCjwR70et0V+UU6hOeatYXqFUkdwLlQYpXW51RbiVFPvsk+qwpWE4tl75K5VkyA4tGs1YhYzedR7xmtbRq66VNJwD2fAHwMUNkkYHj6P7dQ3Ir3FtyHCLDoaH7vViam/R+kYu7oEAupZWwTminM47hkonpAqgy0Bd7BvperXPg8j3HwK64CuWnumZokMC+8lC5Nr0DtxtC9LClkHuX1p1Uc5x4zTVI+kw6GgAjdwHjqq9SpVfNZcx2tZxgNHYtcthPomo2lAydVXSb9Mks5Mte+nvzmiUg+RpluFM/wEtpg8VHN1NHwUzYmAdkCjL5t1EMMUr17HbdRfwpCzD8ziiQXdHLKV3FdPX0CcbatM5QTraLSOyvloLxLi0z7EwnqfSoELXOFuQnjiNbzrKcGL3IAuJFahqn+fp5JFh7R6ORPeMkv5gwIELwZ8KVGpaRSavrjqiXlSB6Sx35HZwVkI0QXJv1Dty1+DCynGnFksdlKLCKo4lKD5sT+u3k9rmFbutsIztPos5oSMRDpSA9/NeJxQPhsBCSlN6d4fV+xttLSk80FAAI8Wk1GfWdteD4/uC1Fbfse1SDgGJ/8t3qbpGhivYS0xM17MEovdXOQUxA6JO24HMVysQQavlX5TSHPsEIlULKljStBXH2KE27dzShRenhHLKORHA6ZfihnKrwLneZmBiNuajfLYStzgnpjaC2vTXizrB33MXUCLo1POSNms4OX7BOehUCLa7Pp17yx4hpvZMPGUJEUJcSmvrf4QIOjJ/lV2bLqR+Hrn1S26NEVvMrvi2t/rI9X+SOIGLg4wfDpgBaX95TW7+B3NjgPi3Q4rWA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33947344-a4d1-454f-ff28-08dacc6e8951 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 09:47:15.1635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jvawfs1gNL+2+hE/cP228KxrS0PKZrMJne9qny8b/h5j1WOaaItfEGwOmY2iGUljFe2O4Z1XC6dmFjYt8TK32g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6120 On Mon, Nov 21, 2022 at 06:01:00PM +0100, Jan Beulich wrote: > On 21.11.2022 17:48, Roger Pau Monné wrote: > > On Mon, Nov 21, 2022 at 05:27:16PM +0100, Jan Beulich wrote: > >> Hello, > >> > >> on a system with these first two EFI memory map entries > >> > >> (XEN) 0000000000000-000000009dfff type=4 attr=000000000000000f > >> (XEN) 000000009e000-000000009ffff type=2 attr=000000000000000f > >> > >> i.e. except for 2 pages all space below 1M being BootServicesData, the > >> -mapbs option has the effect of marking reserved all that space. Then > >> Linux fails trying to allocate its lowmem trampoline (which really it > >> shouldn't need when running in PV mode), ultimately leading to > >> > >> panic("Real mode trampoline was not allocated"); > >> > >> in their init_real_mode(). > >> > >> While for PV I think it is clear that the easiest is to avoid > >> trampoline setup in the first place, iirc PVH Dom0 also tries to > >> mirror the host memory map to its own address space. Does PVH Linux > >> require a lowmem trampoline? > > > > Yes, it does AFAIK. I guess those two pages won't be enough for > > Linux boot trampoline requirements then. > > > > I assume native Linux is fine with this memory map because it reclaims > > the EfiBootServicesData region and that's enough. > > That's my understanding as well. > > >> While the two pages here are just enough for Xen's trampoline, I still > >> wonder whether we want to adjust -mapbs behavior. Since whatever we > >> might do leaves a risk of conflicting with true firmware (mis)use of > >> that space, the best I can think of right now would be another option > >> altering behavior (or providing altered behavior). Yet such an option > >> would likely need to be more fine-grained then than covering all of > >> the low Mb in one go. Which feels like both going too far and making > >> it awkward for people to figure out what value(s) to use ... > >> > >> Thoughts anyone? > > > > I'm unsure what to recommend. The mapbs option is a workaround for > > broken firmware, and it's not enabled by default, so we might be lucky > > and never find a system with a memory map like you describe that also > > requires mapbs in order to boot. > > Guess how we've learned of the issue: Systems may boot fine without > -mapbs, but they may fail to reboot because of that (in)famous issue of > firmware writers not properly separating boot services code paths from > runtime services ones. And there we're dealing with a system where I > suspect this to be the case, just that - unlike in earlier similar > cases - there's no "clean" crash proving the issue (the system simply > hangs). Hence my request that they use -mapbs to try to figure out. > > And yes, "reboot=acpi" helps there, but they insist on knowing what > component is to blame. Well, if reboot=acpi fixes it then it's quite clear EFI reboot method is to blame? Or they want to know the exact cause that makes EFI reboot fail, because that's quite difficult to figure out from our end. But I'm afraid I don't see any solution to make mapbs work with a PVH dom0 on a system with a memory map like you provided, short of adding some kind of bodge to not map and mark as reserved memory below 1MB (but that kind of defeats the purpose of mapbs). Roger. From xen-devel-bounces@lists.xenproject.org Tue Nov 22 10:30:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 10:30:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447057.702919 (Exim 4.92) (envelope-from ) id 1oxQY8-0000b3-1t; Tue, 22 Nov 2022 10:30:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447057.702919; Tue, 22 Nov 2022 10:30:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxQY7-0000aw-VR; Tue, 22 Nov 2022 10:30:43 +0000 Received: by outflank-mailman (input) for mailman id 447057; Tue, 22 Nov 2022 10:30:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxQY5-0000aq-IN for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 10:30:41 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b4545d13-6a50-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 11:30:39 +0100 (CET) Received: from mail-mw2nam10lp2106.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.106]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Nov 2022 05:30:29 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5181.namprd03.prod.outlook.com (2603:10b6:208:1e5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Tue, 22 Nov 2022 10:30:27 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5834.015; Tue, 22 Nov 2022 10:30:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4545d13-6a50-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669113039; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=0tMZ1pECm84EgpELAXlKn2mZIBCJ/rgQbglXsMFEKdI=; b=MUOoW51HwoD3wnBj861pSZoTmfDCb0WmlXtNlqaiLT5EoW93F+c2vYVJ MR4aadclh2W9XESaR1sloXJyipGsvtYCs9IpfA39lA6OrgqE5z6HGyuPG 5RAIbOTKCnS1R8BrSs6+wQeZ1pQxItg6ObbsZVOMIu4h2VMt/vsQ+rGCs k=; X-IronPort-RemoteIP: 104.47.55.106 X-IronPort-MID: 84376239 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:z+GbXa/5MWSdZWUoH3t8DrUDsn+TJUtcMsCJ2f8bNWPcYEJGY0x3x mocXmvXb6mIM2fyKdx+bIm0oUgBu5XTm4NrSAQ9+C88E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKoR5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkl/y vY1JA0XRSyBpMeskZT8T+ZSg+08eZyD0IM34hmMzBn/JNN/GdXmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUpjtABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCN5JS+Pira8CbFu7xFJNMg03dH2ArOSJjnGEAPcOE 2INw397xUQ13AnxJjXnZDW6vXqFsxg0S9dWVeog52ml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JW3Y3+A8rafrRupJDMYa2QFYEcsUg8t89Tl5oYpgXryos1LFae0ipjwBmv2y jXT9Cwm3exL04gMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl BA5dwK2toji0bnlePSxfdgw IronPort-HdrOrdr: A9a23:TfrEdaxuM/IuYmjkEQ9dKrPxBOgkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2jnC6l87nzFjmfx1M7XylUybkv3G DZm0ihj5/T8s2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHBmxulf4NoXpyFpXQQrPu04Fgnvd HQq1MLPth16VnWYmapyCGdlTXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t MJ40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIWLH5AJlO+1GkUKp goMCju3ocRTbpcVQGBgoBb+q3pYp30JGbffqFNgL3P79EcpgEF86JR/r1iop5HzuN8d3AM3Z W7Dkwj/os+MfM+fOZzAvwMTtCwDXGISRXQMHiKKVCiD60fPWnRwqSHqYndydvaD6Dg9qFC7q jpQRddryo/akjuAcqB0NlC9Q3MWny0WXDoxttF75Z0t7XgTP6zWBfzA2wGgo+lubESE8fbU/ G8NNZfBOLiN3LnHcJM0xflU5dfJHECWIkeu8o9WViJvsXXQ7ea/tDzYbLWPv7gADwkUmTwDj 8KWyXyPtxJ6gSxVnrxkHHqKgfQk4zEjOdN+YThjpsuIdI2R/xxWyAu+CSEz9DOLyFeuaore0 Y7KK/7k8qA1BuLwVo= X-IronPort-AV: E=Sophos;i="5.96,183,1665460800"; d="scan'208";a="84376239" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aE6UkjyurqTXZB+/8aDsSlBpUfBL8csZxF4prpFlgEDMG6zrM7CZHoKEXXsj/UvakwJpK0IE3iREplV+j1SvF/9Khpbp1l0RZXdrw8b0AXAZDvNptCpIQE6c/pBjZ0H+TtgIzObmUP5dTLX22yzYnyWGHtl3YBJMc21hN//lB03H8CBL9ueN4Z9zsFo5LKNgvDr1M7rVUB08zW+/LeGoXdmSTs5MzE7USv62ZYOhXRPAiObb1I+nRR25koSX9SuJTTcEZFcmjP3LHwBxGcbHlrCE16mDT4OOQAC7ksqXM23zNacMrcjezmZycUzzaeS0u+n+zq/d/GfEjnvS09gBWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0tMZ1pECm84EgpELAXlKn2mZIBCJ/rgQbglXsMFEKdI=; b=bgPcu3dnVQvlOlZLyF0hs4P/KOLreCzctLEMUHUL200YGlTh+c0rVHfzIwNODEhNGB1cdGujnen0lUp47D+vyd4uSt+KZYqts48zT4XWWx2fURqnbspS+qTmNV7c9mu7ybibuQjwkKYEi08pk1WP2sNNHgg7k/qZ+S+GrcH62QIGFp8MBBoeeISZJu5Gj3ptdRsKc4FanW026fVSZJw2p7GaplYJspxkThxv/QcI5X1Xv07fEiKCgUeIMMdlnIaFVF9dtEjkokdKWc70tvDUydS8Qj9O/pBLF4W84MJY628VQg51MlqG04uyYT4iEwBInMs8fkKUtrV9RdkAHbCLcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0tMZ1pECm84EgpELAXlKn2mZIBCJ/rgQbglXsMFEKdI=; b=SAOa+z92JtFY05DQUgGWM9iUZax1BhLy5MMLtVIC0BZnleIqwzSfjziqgn3q7x2FcrS5DIlpOqupXMf+tYdKs8IEtYp8rn8AVnlmtEDMX0Gj9nWQRmLzkxsVznqk80ygf45AqVv2N3IGpoMRbfU+4J/8rYlY8Kvwuex0fJZQYHg= From: Andrew Cooper To: Julien Grall , Xen-devel CC: Jan Beulich , Roger Pau Monne , Wei Liu Subject: Re: [PATCH 2/2] Changelog: Add __ro_after_init and CET Thread-Topic: [PATCH 2/2] Changelog: Add __ro_after_init and CET Thread-Index: AQHYM7LH1RgXNeZAgkCaPnspMShcz65MN16AgAAcGwA= Date: Tue, 22 Nov 2022 10:30:27 +0000 Message-ID: <1977c21c-4c77-e2e5-76ee-0a5d4c0fa977@citrix.com> References: <20220309123936.16991-1-andrew.cooper3@citrix.com> <20220309123936.16991-3-andrew.cooper3@citrix.com> <22626b14-8047-8fbe-0668-5caeff304640@xen.org> In-Reply-To: <22626b14-8047-8fbe-0668-5caeff304640@xen.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB5181:EE_ x-ms-office365-filtering-correlation-id: d9e1fa72-759d-4426-7403-08dacc74926e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cqOYRBWTJZ/xIodbAar3E5t5YIj9J5uK66nNaXp/oTHr0cL16k+6Or1Y7T2KGbhgzBPJN+gTkAnLGYYzworxXwE+WEWwGkGNseDdtdGPGIaGLBatIrST549UdXG384wDBlTSqZ6CkpvQzKQ2xI7UvBpT50JFk4B4e+VUXNcTlTa0Fotu9YMrMy/M6G5xkSgi/qZ/ezQPQ4CEmOaFvOZ1eOFiHDL3XLWB4YCmURq5I8knL+YgjQalGtkMEhg4QAeoyNoOqSoG9rf1fSspsFYeTwqEWKrrxrcGMq1KZH3qisDK5dWpYR0OeupCpxrjJqWh0TVMG1BTDI8MHEIsrsWLI2x21ZoSSoLJTH3av86J4g6uEHOs82YARucVE23B+rAFNc5uFrm+iFUK90Ew9/UztZvpFAHTndlOPXZ/YOh2FM2I+oYZpm7ReZhzLAldB5TyCmfEMA+YKxzxCuBZNax2Z4FyfzLu3dvV4x8eyj6y/J1ofXZSexSiTAbyUWkF6a4+QtQTk1TUKFQOoe4ti20Q53eSBnvhX9X+Md/AsK8v8DtOo2qMev7TNFfh8htXptAzXUD7td5gsIR3xpqt0IXlNOSRGpQ3N6+THGhJSe4EZ3vNfb6LbReIaNxNTbRM3gjH1vUaFRQLOwrWtgj8rBwE7pnAtr2JjO4U0IS2teEXJbg02mlMZ6Ly/m91fDCkKvUwCHNAr7wqChvfh/cTs+24i1qs7L/xr3pLlhr3uap5nApd3E0BnJYvmgzGR7QzkFa5IfwptBc4iyvfOD+T4x5s/K4cRcXU9aEznL8MgCmiooleDEOVd8/n7MdG5H0ubbcESgiNHU6OGIeB5tI6v6s8cV8WV1HW2lgwBdSJHdegQ12AbPnnEVbRCTUrmIdXjEHV x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(366004)(376002)(396003)(346002)(451199015)(2906002)(31686004)(2616005)(76116006)(66946007)(91956017)(53546011)(41300700001)(36756003)(31696002)(86362001)(66556008)(4326008)(66446008)(38070700005)(122000001)(110136005)(6506007)(54906003)(82960400001)(38100700002)(8936002)(6486002)(64756008)(8676002)(4744005)(186003)(66476007)(5660300002)(6512007)(478600001)(316002)(26005)(71200400001)(59356011)(207903002)(219803003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MUZreUtXNmxDMFU4b1RZanpud2twUmppd0YzelU5dG5NaVQwOEhxUGM5Ym1j?= =?utf-8?B?eHd0OTczUUl6MVk0SVdiaWt1eGNnRW5MWWdGQzY4aDhjc3FUVm1xVE00QkY5?= =?utf-8?B?REE3RVY1dEgvdEVxVXg4MVlJM1RnU1RYT2xBdlA2SkNVVml5Q1NZakwycDhK?= =?utf-8?B?WDM5V25qS2ljYTd4RktYaVloNTVzSVNhTEc0Y1o4dTdHcFdvSm9wTFJrd0F3?= =?utf-8?B?ZW82Um12TE1mNG40OVhBdHNoUzQrUnB6aXhJSGppL0QwTzBYbHZub2R3VlZp?= =?utf-8?B?enN2U0JJV3E4S1JMWGJuT3pyWFFaanZIWFZ3VlorVXlaRlN2ODJKdmFJdUdu?= =?utf-8?B?NGxIaTJPYmNVZlZiUTR6QmxCRE9PRXcwSmJSYzJuWVVmSGMvQk10YmJydHBG?= =?utf-8?B?RlM0a1BYdXR4amZiV2F6K3BwRnIxYlh3RjhmWXh5VTA4VG5YSXJXUFprNlhO?= =?utf-8?B?YWpkVnZGU3UrNCtDVmxDTkVFdUx1aVZ1T3lKNXRnQWhZVHViUHZCdzhEYVpa?= =?utf-8?B?MnY5KzVJR2JYRHhNZjdGVlFkU0tVMk4xRHl1UW50YTMza2xKMzBTWk95Ly9i?= =?utf-8?B?WjRwT1IvZkZ6ajhyMU9hVDMwUmx3cUhtTDJlU1RNM3NidTV0NkRTRVpiUE8x?= =?utf-8?B?T21SRjJlOVRUQTRmMmZtVWNYZXRmY2R5S2ZSRTMrenpvRlpzNXhsRmYwMEha?= =?utf-8?B?RzUyc0tjMEhIK3FENDVrVDE2YlNaQ1dmeXJWejI4VlJ0MWZGeDJCVHZaczl3?= =?utf-8?B?MXQ4RHZrZmQ4dk12T0dkRWZ0ZXVZRWhHWTZ2aUtjcHo1NHdLNnoyekxvZVVy?= =?utf-8?B?VVArNEx0ZnQxdndYMnMzN29ycmJzRVhZTWpWeEtWaktUSHA0Z2paa3VBZE10?= =?utf-8?B?Ym0zTlRldlF3Q2tMdllva2oyMGJJT1A4MzRHRFpQV1hCNUFVQlhtamJSUzRy?= =?utf-8?B?OXc3c2srUnpreENvZ2wrNm1ZSE50cXl4WmlnalRPcHY3MGkxV2F6UVk5dDZj?= =?utf-8?B?cFYwTWhXYnIvc1RFa1crb01vWXY5dHRrY1AwUkFHYU1vUEoyTjh6S2xoYUFI?= =?utf-8?B?TmEzWG4xaWY1cW1SMzBEcG9XSDcwcnVlZzVWRGtFdkd1cEdYenU1ZDNBdzF4?= =?utf-8?B?YWhVY2xvbzFPeXl1eFNGaENLbG9yeEJheDd1bnZFelJQM0JIMThYM2hqTm4y?= =?utf-8?B?dzBMOVcxRm9KR1BqRlY4a0tSdVlRQ0lRNzRhUjBmS2dsaCt1MTlvVU1ERkpj?= =?utf-8?B?WkcvM0FaK2V1aExuSGNhVTNjaUdNME9mRkl2djRndnpVOVNwNThNSmgySytI?= =?utf-8?B?OW9oaWlsQTlha2IzdU5wU1l3K3ZKNnhpQStqOU03L29IVWd6U2ZlWlBiL0VM?= =?utf-8?B?Y21UTkFtb2tINUZaSG14NERYWWhLMHQ3Z25qSG5zV2Y1b0ZVUXNqODYvSmFK?= =?utf-8?B?SzRnTFQyclJ0WmE1MEZxOWIzdkMyMStRS0E2czVxc3FURTk4QU9Ba0FMMTBm?= =?utf-8?B?TlhONzl0Z0dDMVpUZitpRjZxL1EvV01GSzFkQ2YyLytleTFqTkhZM25QSitX?= =?utf-8?B?M28xVW5VWFZCTGF3V1dqZWd1aTNmTUwvcjlNZmNVODRIMHZucFFkOFl4TnFu?= =?utf-8?B?cytyR2MzZzZ3eHkvT3VtQk9qeCtIMVUyR2liMFBST3BuRnVseXNxWGJLamw1?= =?utf-8?B?UXdtaUhmazBzQXROazh2eERPS0tEZHROTVJmeFhvRVhoWk9lR1R1aG1lM1Rl?= =?utf-8?B?NWlqdDlwMDJUcTdZZFdpZytxdm5KZUpNcFl5ZGxUR2lra1dRK3V6M2t2T2o4?= =?utf-8?B?QVRrQWx1TUxRa1haZFRNSUw0L0pCalVRREZTNFYwZEJBNktZVkFualNIRmhN?= =?utf-8?B?MXl6cjFiQWp1dlpVZTlWU1l1V21oU2xRNEFpbWZJZytpYnZtajJLQzVEcktD?= =?utf-8?B?cGUvSDRuNlkrZ1FKMm5EOTNWaFA2TXlTVzJ0NTRWUE9UMG93clo1Q0N0dDBn?= =?utf-8?B?RFZtM0QySWtLVlM1d2ZDY3ZrMFZRNXROVkJ5QjA4YmVUOWIwU2FqR0tXUkpz?= =?utf-8?B?TS9SSm9pL0FDRHZRUlJVWE1EcnI2NGsrSDIwUC8vTEV3UXJOMzhLTDMwM2t1?= =?utf-8?Q?Q71lop8RRC0SrZOq2tvtIOqWL?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: YxyCxU2gbptoPIcJZPkkM6GGdQDrLW9syxSunf80agdUjLiAY99MRnwTKTqI3WgZ+RaFYcckYxBkGOHUdXqJXTeuDrvplKFGduXEUiwBRjeZzmZya6GsOULS51KP4beZE8X2IjAduHoA0BvOmyBWgPAcuDDkkZ6RktgcEtJIqPA5RIVOxI+HjkilDaMgYgwP0svO/PxymhuZwmujown/YXJU1bokX0UvkO+zt3N8nLtmV+KN0Cqph31RD3uqd9ZTwY3GfjvH6rw+vfvXCSPepjuapuGgITlVemc09kMAAqDeruDa5wbyLp8a+KrW6hrjqOsHTQ4P0aj/iVnsn1X267J2NT8GQ1y2s7qGnctC23emIUaFXlbTMV2A/y68qxrSmy16tF641/gsNXmu2zyaaN4qKZ/0euhOYizxt3+B6IWUhGFe2QNaonIySAmX25dXdH77U6OGldob4zXxUKL+tX7fJMQ9DHNRYtf59XQh2t1298hSiGpji3n56mgnPU2QhpFz9J54fLKrNvzOu3FWbmTkpq6iTFCE75uo0DDpv37PFJuHFia6oY2LfWIAXcqWOq2KcOI0weTwyNA0dG4PpbIMY7A2Vk/2XOvslEDJYfLAGue8x/3B1gbEr4aZ+wUlWXyOFzZ4INRKx8rCNsT5lvcU10zk4vHJGkZojs9PrewifQKjLJO6hWfi9mHM57ZBtoVN3HrqQ1I7pjRy9Fg3fbhJWnFD7v82elasJDKGrD9DBDaBJZG/dEg4pR3LTyzyzwQmGrEoiD0km4ZEVgRgvN92MyRsUMfCtqT2872VqSRNOmFuV9kN8sZMUlAEnlSRiHe4EjQs1HZEE/oAUwoxSxl9FOlhHqG7MhIKPZhnqDM= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9e1fa72-759d-4426-7403-08dacc74926e X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2022 10:30:27.1175 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QCVVgBq/sJlnEhgZiHxx64rPkXzU/DMae+ifPmUJmLcAU/JUgbzVXXLVOptzxvA7tjdc6OvsDTjY/LZbxjTX0GEhSWG0fwTmNv+sVBWG7UQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5181 T24gMjIvMTEvMjAyMiAwODo0OSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSBBbmRyZXcsDQo+ DQo+IE9uIDA5LzAzLzIwMjIgMTI6MzksIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBTaWduZWQt b2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPj4gLS0t DQo+PiBDQzogSmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPg0KPj4gQ0M6IFJvZ2VyIFBh dSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPj4gQ0M6IFdlaSBMaXUgPHdsQHhlbi5v cmc+DQo+PiAtLS0NCj4+IMKgIENIQU5HRUxPRy5tZCB8IDYgKysrKysrDQo+PiDCoCAxIGZpbGUg Y2hhbmdlZCwgNiBpbnNlcnRpb25zKCspDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL0NIQU5HRUxPRy5t ZCBiL0NIQU5HRUxPRy5tZA0KPj4gaW5kZXggODNkODVmYWQ1YmJjLi41Nzc1MTczODNlYzkgMTAw NjQ0DQo+PiAtLS0gYS9DSEFOR0VMT0cubWQNCj4+ICsrKyBiL0NIQU5HRUxPRy5tZA0KPj4gQEAg LTYsNiArNiwxMiBAQCBUaGUgZm9ybWF0IGlzIGJhc2VkIG9uIFtLZWVwIGENCj4+IENoYW5nZWxv Z10oaHR0cHM6Ly9rZWVwYWNoYW5nZWxvZy5jb20vZW4vMS4wLjAvKQ0KPj4gwqAgwqAgIyMgW3Vu c3RhYmxlDQo+PiBVTlJFTEVBU0VEXShodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9 eGVuLmdpdDthPXNob3J0bG9nO2g9c3RhZ2luZykNCj4+IC0gVEJEDQo+PiDCoCArIyMjIEFkZGVk DQo+PiArIC0gX19yb19hZnRlcl9pbml0IHN1cHBvcnQgb24geDg2LCBmb3IgbWFya2luZyBkYXRh IGFzIGltbXV0YWJsZQ0KPj4gYWZ0ZXIgYm9vdC4NCj4NCj4gVGhpcyBpcyBhbHNvIHN1cHBvcnRl ZCBieSBBcm0gKHNlZSBjb21taXQgYWNlNDAzMDIyMzU4ICJ4ZW4vYXJtOg0KPiBTdXBwb3J0IHBy b3Blcmx5IF9fcm9fYWZ0ZXJfaW5pdCBvbiBBcm0iKS4NCg0KWWVzLCBJIGtub3cuwqAgQ2hlY2sg dGhlIGRhdGUgb24gdGhpcyBlbWFpbC4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Tue Nov 22 10:45:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 10:45:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447063.702931 (Exim 4.92) (envelope-from ) id 1oxQmO-0002H8-Ed; Tue, 22 Nov 2022 10:45:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447063.702931; Tue, 22 Nov 2022 10:45:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxQmO-0002H1-Bq; Tue, 22 Nov 2022 10:45:28 +0000 Received: by outflank-mailman (input) for mailman id 447063; Tue, 22 Nov 2022 10:45:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxQmN-0002Gv-81 for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 10:45:27 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2060d.outbound.protection.outlook.com [2a01:111:f400:fe13::60d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aabf99b7-6a52-11ed-8fd2-01056ac49cbb; Tue, 22 Nov 2022 11:44:40 +0100 (CET) Received: from AS9PR06CA0567.eurprd06.prod.outlook.com (2603:10a6:20b:485::35) by AM8PR08MB6467.eurprd08.prod.outlook.com (2603:10a6:20b:316::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 10:45:19 +0000 Received: from VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:485:cafe::bf) by AS9PR06CA0567.outlook.office365.com (2603:10a6:20b:485::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15 via Frontend Transport; Tue, 22 Nov 2022 10:45:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT017.mail.protection.outlook.com (100.127.145.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Tue, 22 Nov 2022 10:45:19 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Tue, 22 Nov 2022 10:45:18 +0000 Received: from 824d84545918.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8B24797F-C5A8-4911-92EC-F77C61C36745.1; Tue, 22 Nov 2022 10:45:11 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 824d84545918.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Nov 2022 10:45:11 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DBAPR08MB5637.eurprd08.prod.outlook.com (2603:10a6:10:1b0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 10:45:09 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5857.013; Tue, 22 Nov 2022 10:45:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aabf99b7-6a52-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XL45yE1auA7pXF1rabve14a/zbaXeKNZRFhxInGfmKU=; b=nNZntcHGfKxncZLQlYjuseftFsBVLoAPsh5zzs9DEzyPjZFbbC7ow6gf2JkVt7SJfOvCzcw8X7QelJV+cAHijz9j2yTa8ji8h+z/fbBBQXe+lj1ztJImMM04eDwk9remjqY4EG6kAcpY2CGCnHTfWHP2JN/ZohUyHgjv0twcD5s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 4e32d7a7df4ffb05 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fOoppdOHG1JUlX+SiTZ3tsdOetIUEAVmqnlbaVCOFO2y41U+0op6RfmPpix5Uyo2VubXuIPlKFUQBorE5RRTNrfsaC0Wu/hVeVtmodcnNGQMYtcDeVi9ty+bwNTUjwp0h8QhXeInjCv71SlUyYjKMjM22QS6yVxm4qjklPD34to+hz00NSMJaklBhdWOmZfSjoVRLLIPXnC4Y+Lx1HLeBoiIZMKE4Elnnxqnc3RR3U/DWy7bTHO64kRtra+diOMDPVKEzekrCo5xEcvJ9ZMpRID1RaCFUm11qLpEXpNOhVy8kDfgeP1FIyqWvwzOev4wO13Gt6Beofvut21NSeWhjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XL45yE1auA7pXF1rabve14a/zbaXeKNZRFhxInGfmKU=; b=lede8blayh62s8eU1wi9Rc9kWU6Yn08AV27qtQuLgLiHCx+XhkkkJXsYcihRrlgZmHMn9llbW8DFgFcgRtd8gTFoMppCdsXBN7Emm3w3iP/GGmEHD1RxtbRK7/9zfhcyU9NyziUeaPHP6nU+liu88SU+4kdAQKjdsDa21vrhu82CGrzenpXJ0TBVT7YHnzOwaKYKrvflm3gcf3gYdPqNC0eaZj8eG4DDU9bZNxgX8/pbOVWk47LBAdHdIWdnRczs44T++l4Mn+Z6GrHEPobA57IOz3gj6NdZodhOGYTmwPK0SDnc+NTsOObS/tE/1x7FcB+CgmnbC+q31B66IiCEtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XL45yE1auA7pXF1rabve14a/zbaXeKNZRFhxInGfmKU=; b=nNZntcHGfKxncZLQlYjuseftFsBVLoAPsh5zzs9DEzyPjZFbbC7ow6gf2JkVt7SJfOvCzcw8X7QelJV+cAHijz9j2yTa8ji8h+z/fbBBQXe+lj1ztJImMM04eDwk9remjqY4EG6kAcpY2CGCnHTfWHP2JN/ZohUyHgjv0twcD5s= From: Henry Wang To: Andrew Cooper , Julien Grall , Xen-devel CC: Jan Beulich , Roger Pau Monne , Wei Liu Subject: RE: [PATCH 2/2] Changelog: Add __ro_after_init and CET Thread-Topic: [PATCH 2/2] Changelog: Add __ro_after_init and CET Thread-Index: AQHYM7LpT1yHXMQKSUCKpVv8817rGK5MN16AgAAcG4CAAANG8A== Date: Tue, 22 Nov 2022 10:45:09 +0000 Message-ID: References: <20220309123936.16991-1-andrew.cooper3@citrix.com> <20220309123936.16991-3-andrew.cooper3@citrix.com> <22626b14-8047-8fbe-0668-5caeff304640@xen.org> <1977c21c-4c77-e2e5-76ee-0a5d4c0fa977@citrix.com> In-Reply-To: <1977c21c-4c77-e2e5-76ee-0a5d4c0fa977@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 971F519E2E538045B14637933C59231D.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DBAPR08MB5637:EE_|VI1EUR03FT017:EE_|AM8PR08MB6467:EE_ X-MS-Office365-Filtering-Correlation-Id: e7dfecd1-9fc2-4bf7-6255-08dacc76a63e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WDoxlbe8vyDDcdm48ZTIBKkcvtNrtaSf5PKBdlb/s3tSchnEAd7yGD7fxjPRaaTe6vFqCvUn7GrDK4XSg/w8xd4eU7bRr5pjGbkCyiq5ZsG5Wh2CnG5KuAGEYjKtsPygWpiZ8vzcWtbkAq1d5u38Xis2Kz0AIrTN1iiw1XJOj6mu6vVn8SgAS/jP0Wb/BvOLKX6L5+CWggWhIfORAwSVTlVkttWldKnt8BJFfRSm24rG75IUM365qizglVaXh2kzaImEFMa05YQPH1CDb6mRwACCAx66U/ROrn6cxOS7gSm1TEmrNMzEUGxMsrXycFlJcSAYGDgybqjcf/LllRL1VaDa3dfYDmMxKEBJnUPozUOhUXh108yw9eU1QsiccKVRV5ujmCv51PnlvXyaF2HvPDrA0wIDxnT/4LXx7iVxySyvJgd/kOe5H5XkaVtteRoySU5DX/N5jY26a0a/gy7UiKhoBRg9b3EtFwlYOV+MHJh+I6Rfhvx6CniDuz9yA94PvmFdYafbNu6lZVgK1UawIXlQx1Z09p2OvoI4RsJfjdHl7l1Ssn9yl2oLTzhe5qzdFYxcgTu4MYKD3+nwItYzH2uXMyTfAddBAqNWUfXxsVL4wtu1xAN/YMEzghGRqGYXJITRHQMiwrasTKJfiryXjjm4Zyb7HYBcthCaoUCABfojpZzxcO3A2MFgfglBMz5RVOGT21//f5l45FYVCm38AoJe0AeOSwnu48XIPCAq4/0iejn06od8nnHXeEAvJ8wojWEsS++v63PFenxKvXWux+G0MpCrigEN0xr0hnE4ycYFK+UbzvrE6bDzSeTfpHupXTuGpiOsgNrsv/RDPHECYoMfVE9K8aYhs6AoqQ/+OUs= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(396003)(376002)(366004)(451199015)(41300700001)(76116006)(52536014)(8936002)(54906003)(316002)(66946007)(66446008)(5660300002)(66556008)(4326008)(66476007)(64756008)(8676002)(86362001)(6506007)(55016003)(71200400001)(478600001)(83380400001)(38070700005)(110136005)(2906002)(7696005)(186003)(53546011)(122000001)(9686003)(38100700002)(33656002)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5637 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3d68e3aa-f1c1-4b82-878e-08dacc76a05a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pFSdNfGTmcWDiyMuZlMKkdSAfeUiA0GkLW0WoGYrCJk9LyBXU6Nc806riEpnl53W1JNKa/vpHGHru5ZIZqUkplQ6Mh9Mb6WVp8bxM9gKHddbQ9rbqewxc61uR2O8Ws94LX33bE8L38niq9x7w6Zxugx8J25J3OqEuupZe4vc5ReGXlz/4o780PWZu9WE+RDEbESNUr3abuunlwR8ZGleHZ6MojZmoAgZs1eKQLHg42yXx7eGqJ5bNatEKnCeHeG+PuYqAhHiqA6FrMvFXtIzpcigQj/CubLN3tzbE7vuSkB4Vq0MTqisqOkdiYqppQWKkZal8xzzC1p04+5y7ddOb9s6YQeJzOFyd00ZtqxHM/Cx9b6HdiZ2ivXi+NKXre3tyqFPmUlpxtGrIxSTstZ7oJZnZ0/ZQria/b6YUXGLvaxwyLLnHGZiYPenMV1oGs6kER9OxTBaKg3ZRZ+NqglQGsAt5aebQKX2bzXZ2UOwXgzR1uoqytmJ3R8jf7RpCRZ1hhf12TBCkvt+ttwN4cJ3PBPkfxPNzPU1Dk2UxPO5Di2t01Ax1ZRQtOEdvdGLKXuXrq3GoTQ6rgIDfb968g7ENt2oSKYu8Svv2AXpuo9UO/x2luexWgqieEAglY+JujL3Q/cQpQtLeuZUvzeGKRq7ypqL+dm1Cw59CtlLDdv99RBl2sCNYgNTa+g12M4fv8LGuzyzmo8mDtulncbUBqrokM6fx6susZvOoiHwPmPj/L3XFVua5lcJkEFr2hS1Cs7PR1p0QZAFi/cdzpzX8uv0b+TytUXEyGG5yp62deLGsQ4Q48U27taDyJHsgbvO12lRtEPguAgvUbyLqhQfzmC/5mTMK+CLlwcHWXzNiRfWdVs= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(376002)(396003)(451199015)(46966006)(36840700001)(40470700004)(8936002)(316002)(110136005)(478600001)(47076005)(54906003)(52536014)(186003)(82310400005)(5660300002)(6506007)(53546011)(7696005)(336012)(2906002)(9686003)(82740400003)(83380400001)(26005)(356005)(41300700001)(40480700001)(70586007)(70206006)(8676002)(36860700001)(86362001)(4326008)(55016003)(33656002)(81166007)(40460700003)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 10:45:19.2566 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e7dfecd1-9fc2-4bf7-6255-08dacc76a63e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6467 SGkgQm90aCwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBTdWJqZWN0OiBSZTog W1BBVENIIDIvMl0gQ2hhbmdlbG9nOiBBZGQgX19yb19hZnRlcl9pbml0IGFuZCBDRVQNCj4gDQo+ IE9uIDIyLzExLzIwMjIgMDg6NDksIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gPiBIaSBBbmRyZXcs DQo+ID4NCj4gPiBPbiAwOS8wMy8yMDIyIDEyOjM5LCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPiA+ PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29t Pg0KPiA+PiAtLS0NCj4gPj4gQ0M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT4NCj4g Pj4gQ0M6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiA+PiBDQzog V2VpIExpdSA8d2xAeGVuLm9yZz4NCj4gPj4gLS0tDQo+ID4+IMKgIENIQU5HRUxPRy5tZCB8IDYg KysrKysrDQo+ID4+IMKgIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKykNCj4gPj4NCj4g Pj4gZGlmZiAtLWdpdCBhL0NIQU5HRUxPRy5tZCBiL0NIQU5HRUxPRy5tZA0KPiA+PiBpbmRleCA4 M2Q4NWZhZDViYmMuLjU3NzUxNzM4M2VjOSAxMDA2NDQNCj4gPj4gLS0tIGEvQ0hBTkdFTE9HLm1k DQo+ID4+ICsrKyBiL0NIQU5HRUxPRy5tZA0KPiA+PiBAQCAtNiw2ICs2LDEyIEBAIFRoZSBmb3Jt YXQgaXMgYmFzZWQgb24gW0tlZXAgYQ0KPiA+PiBDaGFuZ2Vsb2ddKGh0dHBzOi8va2VlcGFjaGFu Z2Vsb2cuY29tL2VuLzEuMC4wLykNCj4gPj4gwqAgwqAgIyMgW3Vuc3RhYmxlDQo+ID4+DQo+IFVO UkVMRUFTRURdKGh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9c2hv cnRsb2c7aD1zdGFnaW4NCj4gZykNCj4gPj4gLSBUQkQNCj4gPj4gwqAgKyMjIyBBZGRlZA0KPiA+ PiArIC0gX19yb19hZnRlcl9pbml0IHN1cHBvcnQgb24geDg2LCBmb3IgbWFya2luZyBkYXRhIGFz IGltbXV0YWJsZQ0KPiA+PiBhZnRlciBib290Lg0KPiA+DQo+ID4gVGhpcyBpcyBhbHNvIHN1cHBv cnRlZCBieSBBcm0gKHNlZSBjb21taXQgYWNlNDAzMDIyMzU4ICJ4ZW4vYXJtOg0KPiA+IFN1cHBv cnQgcHJvcGVybHkgX19yb19hZnRlcl9pbml0IG9uIEFybSIpLg0KPiANCj4gWWVzLCBJIGtub3cu wqAgQ2hlY2sgdGhlIGRhdGUgb24gdGhpcyBlbWFpbC4NCg0KVGhhbmtzIEp1bGllbiB2ZXJ5IG11 Y2ggZm9yIHBvaW50aW5nIHRoaXMgb3V0IDopIEkgd2lsbCBjb3JyZWN0IHRoaXMgdG8NCiItIF9f cm9fYWZ0ZXJfaW5pdCBzdXBwb3J0LCBmb3IgbWFya2luZyBkYXRhIGFzIGltbXV0YWJsZSBhZnRl ciBib290LiINCmluIHYzIHdoZW4gSSByZXNwaW4gdGhlIHNlcmllcywgc2luY2UgSmFuIGFsc28g cHJvdmlkZWQgc29tZSBjb21tZW50cw0KYWJvdXQgcGF0Y2ggIzMgYW5kIEkgZ3Vlc3MgQW5kcmV3 IHdvbid0IG1pbmQgaWYgSSBkbyB0aGUgcmVzcGluICg/KS4NCg0KS2luZCByZWdhcmRzLA0KSGVu cnkNCg0KDQoNCj4gDQo+IH5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Tue Nov 22 11:27:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 11:27:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447077.702948 (Exim 4.92) (envelope-from ) id 1oxRQT-0006tJ-Eb; Tue, 22 Nov 2022 11:26:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447077.702948; Tue, 22 Nov 2022 11:26:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxRQT-0006tC-Bv; Tue, 22 Nov 2022 11:26:53 +0000 Received: by outflank-mailman (input) for mailman id 447077; Tue, 22 Nov 2022 11:26:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxRQS-0006t6-A4 for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 11:26:52 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 8eb256e1-6a58-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 12:26:50 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B0621FB; Tue, 22 Nov 2022 03:26:56 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 018953F73B; Tue, 22 Nov 2022 03:26:37 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8eb256e1-6a58-11ed-91b6-6bf2151ebd3b From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Jan Beulich , Andrew Cooper , Christopher Clark , Nathan Studer , Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Doug Goldstein , Juergen Gross , Dario Faggioli , Elena Ufimtseva , George Dunlap , Nick Rosbrook , Lukasz Hawrylko , "Daniel P . Smith" , =?UTF-8?q?Mateusz=20M=C3=B3wka?= , Kevin Tian , Jun Nakajima , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Anthony Perard , Bob Eshleman , Alistair Francis , Connor Davis , Meng Xu , Samuel Thibault , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Daniel De Graaf , Quan Xu , Community Manager Subject: [PATCH v3 0/3] Populate entries for 4.17 Date: Tue, 22 Nov 2022 19:26:20 +0800 Message-Id: <20221122112623.1441905-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hello, The following changes are preparation work for the 4.17 release. Also collecting the changelog changes happened during the 4.17 dev phase. This is my first pass at the log for the release, it's likely missing more entries. I'm Ccing all maintainers in this cover letter and also in patch #1 for further feedback on missing items. Thanks, Henry v2 -> v3: - Move the uncertain release date to patch #3. - Remove the "on x86" for __ro_after_init, as Arm also supports the __ro_after_init. - Take the opportunity in patch #3 to also adjust the 4.17 entry since this patch will be applied only after branching. v1 -> v2: - Pick other changelog patches happened during the 4.17 dev phase. - Correct wording for two x86 entries (clock frequency calibration and SPR & ADL support) following Jan's suggestion. - Add missing Arm entries from Oleksandr. - Add missing i.MX entry following Stefano's suggestion. Andrew Cooper (1): Changelog: Add __ro_after_init and CET Henry Wang (2): CHANGELOG: Add missing entries for work during the 4.17 release CHANGELOG: Start new "unstable" section CHANGELOG.md | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 11:27:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 11:27:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447079.702959 (Exim 4.92) (envelope-from ) id 1oxRQq-0007F7-NB; Tue, 22 Nov 2022 11:27:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447079.702959; Tue, 22 Nov 2022 11:27:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxRQq-0007Ey-K5; Tue, 22 Nov 2022 11:27:16 +0000 Received: by outflank-mailman (input) for mailman id 447079; Tue, 22 Nov 2022 11:27:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxRQp-0007EN-Qr for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 11:27:15 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 82789161-6a58-11ed-8fd2-01056ac49cbb; Tue, 22 Nov 2022 12:26:30 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E39012FC; Tue, 22 Nov 2022 03:27:20 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 28B9E3F73B; Tue, 22 Nov 2022 03:27:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82789161-6a58-11ed-8fd2-01056ac49cbb From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Jan Beulich , Andrew Cooper , Christopher Clark , Nathan Studer , Stewart Hildebrand , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Doug Goldstein , Juergen Gross , Dario Faggioli , Elena Ufimtseva , George Dunlap , Nick Rosbrook , Lukasz Hawrylko , "Daniel P . Smith" , =?UTF-8?q?Mateusz=20M=C3=B3wka?= , Kevin Tian , Jun Nakajima , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Anthony Perard , Bob Eshleman , Alistair Francis , Connor Davis , Meng Xu , Samuel Thibault , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Daniel De Graaf , Quan Xu , Community Manager Subject: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Date: Tue, 22 Nov 2022 19:26:21 +0800 Message-Id: <20221122112623.1441905-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221122112623.1441905-1-Henry.Wang@arm.com> References: <20221122112623.1441905-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Henry Wang --- v2 -> v3: - Move the uncertain release date to patch #3. v1 -> v2: - Correct wording for two x86 entries (clock frequency calibration and SPR & ADL support) following Jan's suggestion. - Add missing Arm entries from Oleksandr. - Add missing i.MX entry following Stefano's suggestion. --- CHANGELOG.md | 32 ++++++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index adbbb216fa..c593081aaf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,16 +4,44 @@ Notable changes to Xen will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) -## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD +## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) ### Changed - On x86 "vga=current" can now be used together with GrUB2's gfxpayload setting. Note that this requires use of "multiboot2" (and "module2") as the GrUB commands loading Xen. + - The "gnttab" option now has a new command line sub-option for disabling the + GNTTABOP_transfer functionality. + - The x86 MCE command line option info is now updated. ### Added / support upgraded + - Out-of-tree builds for the hypervisor now supported. + - The project has officially adopted 4 directives and 24 rules of MISRA-C, + added MISRA-C checker build integration, and defined how to document + deviations. - IOMMU superpage support on x86, affecting PV guests as well as HVM/PVH ones when they don't share page tables with the CPU (HAP / EPT / NPT). - - Support VIRT_SSBD feature for HVM guests on AMD. + - Support VIRT_SSBD feature for HVM guests on AMD and MSR_SPEC_CTRL feature for + SVM guests. + - Improved TSC, CPU, and APIC clock frequency calibration on x86. + - Add mwait-idle support for SPR and ADL on x86. + - Extend security support for hosts to 12 TiB of memory on x86. + - Add command line option to set cpuid parameters for dom0 at boot time on x86. + - Improved static configuration options on Arm. + - cpupools can be specified at boot using device tree on Arm. + - It is possible to use PV drivers with dom0less guests, allowing statically + booted dom0less guests with PV devices. + - On Arm, p2m structures are now allocated out of a pool of memory set aside at + domain creation. + - Improved mitigations against Spectre-BHB on Arm. + - Support VirtIO-MMIO devices in toolstack on Arm. + - Allow setting the number of CPUs to activate at runtime from command line + option on Arm. + - Grant-table support on Arm was improved and hardened by implementing + "simplified M2P-like approach for the xenheap pages" + - Add Renesas R-Car Gen4 IPMMU-VMSA support on Arm. + - Add i.MX lpuart and i.MX8QM initial support on Arm. + - Improved toolstack build system. + - Add Xue - console over USB 3 Debug Capability. ### Removed / support downgraded - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 11:27:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 11:27:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447080.702970 (Exim 4.92) (envelope-from ) id 1oxRQu-0007Y1-UK; Tue, 22 Nov 2022 11:27:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447080.702970; Tue, 22 Nov 2022 11:27:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxRQu-0007Xu-RL; Tue, 22 Nov 2022 11:27:20 +0000 Received: by outflank-mailman (input) for mailman id 447080; Tue, 22 Nov 2022 11:27:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxRQt-0007EN-HX for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 11:27:19 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 84ff76e1-6a58-11ed-8fd2-01056ac49cbb; Tue, 22 Nov 2022 12:26:34 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 77F571480; Tue, 22 Nov 2022 03:27:24 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A7C9A3F73B; Tue, 22 Nov 2022 03:27:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84ff76e1-6a58-11ed-8fd2-01056ac49cbb From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Henry Wang , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Julien Grall , Community Manager Subject: [PATCH v3 2/3] Changelog: Add __ro_after_init and CET Date: Tue, 22 Nov 2022 19:26:22 +0800 Message-Id: <20221122112623.1441905-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221122112623.1441905-1-Henry.Wang@arm.com> References: <20221122112623.1441905-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Andrew Cooper Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné --- v2 -> v3: - Remove the "on x86" for __ro_after_init, as Arm also supports the __ro_after_init. v1 -> v2: - Include this patch in the series --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c593081aaf..5ef507a49c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ### Added / support upgraded - Out-of-tree builds for the hypervisor now supported. + - __ro_after_init support, for marking data as immutable after boot. - The project has officially adopted 4 directives and 24 rules of MISRA-C, added MISRA-C checker build integration, and defined how to document deviations. @@ -23,6 +24,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Support VIRT_SSBD feature for HVM guests on AMD and MSR_SPEC_CTRL feature for SVM guests. - Improved TSC, CPU, and APIC clock frequency calibration on x86. + - Support for Xen using x86 Control Flow Enforcement technology for its own + protection. Both Shadow Stacks (ROP protection) and Indirect Branch + Tracking (COP/JOP protection). - Add mwait-idle support for SPR and ADL on x86. - Extend security support for hosts to 12 TiB of memory on x86. - Add command line option to set cpuid parameters for dom0 at boot time on x86. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 11:27:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 11:27:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447081.702981 (Exim 4.92) (envelope-from ) id 1oxRQy-0007rR-5x; Tue, 22 Nov 2022 11:27:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447081.702981; Tue, 22 Nov 2022 11:27:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxRQy-0007rI-2e; Tue, 22 Nov 2022 11:27:24 +0000 Received: by outflank-mailman (input) for mailman id 447081; Tue, 22 Nov 2022 11:27:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxRQw-0006t6-Sr for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 11:27:22 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a183aa65-6a58-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 12:27:22 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C76CD1480; Tue, 22 Nov 2022 03:27:27 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 782973F73B; Tue, 22 Nov 2022 03:27:19 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a183aa65-6a58-11ed-91b6-6bf2151ebd3b From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Julien Grall , Jan Beulich , Community Manager Subject: [PATCH v3 3/3] CHANGELOG: Start new "unstable" section Date: Tue, 22 Nov 2022 19:26:23 +0800 Message-Id: <20221122112623.1441905-4-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221122112623.1441905-1-Henry.Wang@arm.com> References: <20221122112623.1441905-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Henry Wang --- v2 -> v3: - Take the opportunity to also adjust the 4.17 entry since this patch will be applied only after branching. - Add 4.17 release date. - Drop Julien's Acked-by because of the change of the patch. v1 -> v2: - Add Julien's Acked-by. --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5ef507a49c..e2fb1974d6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,9 @@ Notable changes to Xen will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) -## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) +## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD + +## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.17.0) - 2022-12-?? ### Changed - On x86 "vga=current" can now be used together with GrUB2's gfxpayload setting. Note that -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 12:14:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 12:14:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447114.702997 (Exim 4.92) (envelope-from ) id 1oxSAB-0005xk-7r; Tue, 22 Nov 2022 12:14:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447114.702997; Tue, 22 Nov 2022 12:14:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSAB-0005xd-4q; Tue, 22 Nov 2022 12:14:07 +0000 Received: by outflank-mailman (input) for mailman id 447114; Tue, 22 Nov 2022 12:14:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSA9-0005xX-5d for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 12:14:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSA8-0004W3-Si; Tue, 22 Nov 2022 12:14:04 +0000 Received: from [54.239.6.187] (helo=[192.168.24.76]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxSA8-0004Y8-Kv; Tue, 22 Nov 2022 12:14:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Cc: References:To:Subject:MIME-Version:Date:Message-ID; bh=313pTQ7mn6x1RGSgUbmfS0AK9g/ia/au5WD8yx2fENA=; b=Qpj8s/FpJ42fS02KmZv61bEE/i O6umMhxwU34NeLLVbMcsQO0X+BgILCfEovPSw+ahhYJkBq7VgFjhf6NWyjqqollsaebUc/sHkBJ2E g7i/aBJNsEkH5ZWWCZLkQRg4pHY8EkTbB2ZwbGySiAy578whGIfihM0fqIESzLMNfmcM=; Message-ID: Date: Tue, 22 Nov 2022 12:14:01 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" References: <20221122112623.1441905-1-Henry.Wang@arm.com> <20221122112623.1441905-2-Henry.Wang@arm.com> Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich , Andrew Cooper , Bertrand Marquis , Stefano Stabellini From: Julien Grall In-Reply-To: <20221122112623.1441905-2-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit (Reducing the CC-list) Hi, On 22/11/2022 11:26, Henry Wang wrote: > Signed-off-by: Henry Wang > --- > v2 -> v3: > - Move the uncertain release date to patch #3. > v1 -> v2: > - Correct wording for two x86 entries (clock frequency calibration > and SPR & ADL support) following Jan's suggestion. > - Add missing Arm entries from Oleksandr. > - Add missing i.MX entry following Stefano's suggestion. > --- > CHANGELOG.md | 32 ++++++++++++++++++++++++++++++-- > 1 file changed, 30 insertions(+), 2 deletions(-) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index adbbb216fa..c593081aaf 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -4,16 +4,44 @@ Notable changes to Xen will be documented in this file. > > The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > > -## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD > +## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) > > ### Changed > - On x86 "vga=current" can now be used together with GrUB2's gfxpayload setting. Note that > this requires use of "multiboot2" (and "module2") as the GrUB commands loading Xen. > + - The "gnttab" option now has a new command line sub-option for disabling the > + GNTTABOP_transfer functionality. > + - The x86 MCE command line option info is now updated. > > ### Added / support upgraded > + - Out-of-tree builds for the hypervisor now supported. > + - The project has officially adopted 4 directives and 24 rules of MISRA-C, > + added MISRA-C checker build integration, and defined how to document > + deviations. > - IOMMU superpage support on x86, affecting PV guests as well as HVM/PVH ones > when they don't share page tables with the CPU (HAP / EPT / NPT). > - - Support VIRT_SSBD feature for HVM guests on AMD. > + - Support VIRT_SSBD feature for HVM guests on AMD and MSR_SPEC_CTRL feature for > + SVM guests. Did you really intend to write "SVM" rather than HVM? If yes, then to me "HVM guests on AMD" means the same as "SVM guests". So I would suggest the following wording: Support for VIRT_SSBD and MSR_SPEC_CTRL for HVM guests on AMD. > + - Improved TSC, CPU, and APIC clock frequency calibration on x86. > + - Add mwait-idle support for SPR and ADL on x86. > + - Extend security support for hosts to 12 TiB of memory on x86. > + - Add command line option to set cpuid parameters for dom0 at boot time on x86. > + - Improved static configuration options on Arm. > + - cpupools can be specified at boot using device tree on Arm. > + - It is possible to use PV drivers with dom0less guests, allowing statically > + booted dom0less guests with PV devices. > + - On Arm, p2m structures are now allocated out of a pool of memory set aside at > + domain creation. > + - Improved mitigations against Spectre-BHB on Arm. > + - Support VirtIO-MMIO devices in toolstack on Arm. I would clarify that this is *only* creating the device-tree binding. IOW, there are no support for ACPI nor device-emulator (still in progress from Xen Project PoV). > + - Allow setting the number of CPUs to activate at runtime from command line > + option on Arm. > + - Grant-table support on Arm was improved and hardened by implementing > + "simplified M2P-like approach for the xenheap pages" > + - Add Renesas R-Car Gen4 IPMMU-VMSA support on Arm. > + - Add i.MX lpuart and i.MX8QM initial support on Arm. I was under the impression that the code that was merged is enough to support the platform. Do you have any pointer where it says it is not sufficient? > + - Improved toolstack build system. > + - Add Xue - console over USB 3 Debug Capability. > > ### Removed / support downgraded > - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 22 12:17:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 12:17:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447117.703008 (Exim 4.92) (envelope-from ) id 1oxSDj-0006Ye-ME; Tue, 22 Nov 2022 12:17:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447117.703008; Tue, 22 Nov 2022 12:17:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSDj-0006YX-JR; Tue, 22 Nov 2022 12:17:47 +0000 Received: by outflank-mailman (input) for mailman id 447117; Tue, 22 Nov 2022 12:17:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSDi-0006YR-Oj for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 12:17:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSDg-0004ae-8n; Tue, 22 Nov 2022 12:17:44 +0000 Received: from [54.239.6.187] (helo=[192.168.24.76]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxSDg-0004bm-0P; Tue, 22 Nov 2022 12:17:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=m7X4+5x81nuYeGJGRTW7aMjAj7lNQXwx6lXlw9Kh1+w=; b=Du83Dw5BK0RF2EQt/h4M6xOGsP oeDRLCQZ2RtbKS6c48ZsPUCUrHsVPFjY90pu8iqasyifOFH+gL6y+Sly9GBOZJL6BCd3P5HEGWtxA Xat9I4/r39zCm2AbOTT1niYDYSetwc0mLBqlDrFqCv2F7cf/8OT0ORtKvwGinbuK6FCU=; Message-ID: <91ccea91-5b4c-4348-0efa-725aca1d683a@xen.org> Date: Tue, 22 Nov 2022 13:17:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 2/3] Changelog: Add __ro_after_init and CET Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Community Manager References: <20221122112623.1441905-1-Henry.Wang@arm.com> <20221122112623.1441905-3-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20221122112623.1441905-3-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Henry, On 22/11/2022 11:26, Henry Wang wrote: > From: Andrew Cooper > > Signed-off-by: Andrew Cooper Your signed-off-by is missing. > Reviewed-by: Roger Pau Monné > --- > v2 -> v3: > - Remove the "on x86" for __ro_after_init, as Arm also supports the > __ro_after_init. > v1 -> v2: > - Include this patch in the series > --- > CHANGELOG.md | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index c593081aaf..5ef507a49c 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > > ### Added / support upgraded > - Out-of-tree builds for the hypervisor now supported. > + - __ro_after_init support, for marking data as immutable after boot. > - The project has officially adopted 4 directives and 24 rules of MISRA-C, > added MISRA-C checker build integration, and defined how to document > deviations. > @@ -23,6 +24,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > - Support VIRT_SSBD feature for HVM guests on AMD and MSR_SPEC_CTRL feature for > SVM guests. > - Improved TSC, CPU, and APIC clock frequency calibration on x86. > + - Support for Xen using x86 Control Flow Enforcement technology for its own > + protection. Both Shadow Stacks (ROP protection) and Indirect Branch > + Tracking (COP/JOP protection). > - Add mwait-idle support for SPR and ADL on x86. > - Extend security support for hosts to 12 TiB of memory on x86. > - Add command line option to set cpuid parameters for dom0 at boot time on x86. -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 22 12:20:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 12:20:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447122.703020 (Exim 4.92) (envelope-from ) id 1oxSGQ-00081U-4q; Tue, 22 Nov 2022 12:20:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447122.703020; Tue, 22 Nov 2022 12:20:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSGQ-00081N-0V; Tue, 22 Nov 2022 12:20:34 +0000 Received: by outflank-mailman (input) for mailman id 447122; Tue, 22 Nov 2022 12:20:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSGP-00081H-6F for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 12:20:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSGN-0004fb-1z; Tue, 22 Nov 2022 12:20:31 +0000 Received: from [54.239.6.187] (helo=[192.168.24.76]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxSGM-0004e4-Ql; Tue, 22 Nov 2022 12:20:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=MWUa2GmehP6occvRq293w+jwQRY5A5V9VQ1SCmGZJDQ=; b=QSLq1oMmHnn3YaEGj2H5+lHIed a38WPruBsuQY6nX7uH0ZEWFwRA7Un2Vyjn8rbtbIaU2Xc3UU7JG0CSVRmz2pi//qKBWRX7cERC+U4 OoynbgXaqTYenbNggsp8kQGvhlRYl7NQw5jJH4GlJ2rqbAxj3HWTL8XEwCa4m89rJe+I=; Message-ID: Date: Tue, 22 Nov 2022 13:20:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 3/3] CHANGELOG: Start new "unstable" section Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Jan Beulich , Community Manager References: <20221122112623.1441905-1-Henry.Wang@arm.com> <20221122112623.1441905-4-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20221122112623.1441905-4-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/11/2022 11:26, Henry Wang wrote: > Signed-off-by: Henry Wang > --- > v2 -> v3: > - Take the opportunity to also adjust the 4.17 entry since this > patch will be applied only after branching. Does this means the date will not be updated in the CHANGELOG.md for 4.17? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 22 12:25:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 12:25:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447127.703030 (Exim 4.92) (envelope-from ) id 1oxSLZ-0000FF-MD; Tue, 22 Nov 2022 12:25:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447127.703030; Tue, 22 Nov 2022 12:25:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSLZ-0000F8-JV; Tue, 22 Nov 2022 12:25:53 +0000 Received: by outflank-mailman (input) for mailman id 447127; Tue, 22 Nov 2022 12:25:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSLY-0000F2-Io for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 12:25:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSLY-0004l0-77; Tue, 22 Nov 2022 12:25:52 +0000 Received: from [54.239.6.187] (helo=[192.168.24.76]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxSLX-0004rN-Uw; Tue, 22 Nov 2022 12:25:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=+wDAabZAYZSYqrCIbbz0EqjIkZlNVKmg0sFSdzzE+h4=; b=2J3UGZ5T/m9q2PJ76vYLupOTih uQtyhhP9lKCI97GI1AThHGx8K2q2tJZHVA5XeCj5yxaxgvQ6XSuc72DhZpwvDcao6/E6Mxbk3TEhQ G7niiZ1pjGnTRGBhhgU22V8QIjbIoOibGM/wugk4oI1Q4hAlEOiigo8aggIgkIGlsFB0=; Message-ID: Date: Tue, 22 Nov 2022 13:25:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2] xen/arm: vpl011: Make access to DMACR write-ignore Content-Language: en-US To: Jiamei Xie , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221122054644.1092173-1-jiamei.xie@arm.com> From: Julien Grall In-Reply-To: <20221122054644.1092173-1-jiamei.xie@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 22/11/2022 05:46, Jiamei Xie wrote: > When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", > Linux SBSA PL011 driver will access PL011 DMACR register in some > functions. As chapter "B Generic UART" in "ARM Server Base System > Architecture"[1] documentation describes, SBSA UART doesn't support > DMA. In current code, when the kernel tries to access DMACR register, > Xen will inject a data abort: > Unhandled fault at 0xffffffc00944d048 > Mem abort info: > ESR = 0x96000000 > EC = 0x25: DABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > FSC = 0x00: ttbr address size fault > Data abort info: > ISV = 0, ISS = 0x00000000 > CM = 0, WnR = 0 > swapper pgtable: 4k pages, 39-bit VAs, pgdp=0000000020e2e000 > [ffffffc00944d048] pgd=100000003ffff803, p4d=100000003ffff803, pud=100000003ffff803, pmd=100000003fffa803, pte=006800009c090f13 > Internal error: ttbr address size fault: 96000000 [#1] PREEMPT SMP > ... > Call trace: > pl011_stop_rx+0x70/0x80 > tty_port_shutdown+0x7c/0xb4 > tty_port_close+0x60/0xcc > uart_close+0x34/0x8c > tty_release+0x144/0x4c0 > __fput+0x78/0x220 > ____fput+0x1c/0x30 > task_work_run+0x88/0xc0 > do_notify_resume+0x8d0/0x123c > el0_svc+0xa8/0xc0 > el0t_64_sync_handler+0xa4/0x130 > el0t_64_sync+0x1a0/0x1a4 > Code: b9000083 b901f001 794038a0 8b000042 (b9000041) > ---[ end trace 83dd93df15c3216f ]--- > note: bootlogd[132] exited with preempt_count 1 > /etc/rcS.d/S07bootlogd: line 47: 132 Segmentation fault start-stop-daemon > > As discussed in [2], this commit makes the access to DMACR register > write-ignore as an improvement. Didn't we agree to emulate all non-SBSA registers as WI? IOW, the default case should contain a 'goto write_ignore' rather return 0. > > [1] https://developer.arm.com/documentation/den0094/c/?lang=en > [2] https://lore.kernel.org/xen-devel/alpine.DEB.2.22.394.2211161552420.4020@ubuntu-linux-20-04-desktop/ > > Signed-off-by: Jiamei Xie > --- > xen/arch/arm/vpl011.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c > index 43522d48fd..e97fe3ebe7 100644 > --- a/xen/arch/arm/vpl011.c > +++ b/xen/arch/arm/vpl011.c > @@ -463,6 +463,10 @@ static int vpl011_mmio_write(struct vcpu *v, > case FR: > case RIS: > case MIS: > + case DMACR: > + printk(XENLOG_G_DEBUG > + "vpl011: WI on register offset %#08x\n", > + vpl011_reg); IMHO, this message should be printed just after the write_ignore label. > goto write_ignore; > > case IMSC: Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 22 12:46:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 12:46:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447141.703048 (Exim 4.92) (envelope-from ) id 1oxSfs-0002s7-AM; Tue, 22 Nov 2022 12:46:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447141.703048; Tue, 22 Nov 2022 12:46:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSfs-0002s0-6y; Tue, 22 Nov 2022 12:46:52 +0000 Received: by outflank-mailman (input) for mailman id 447141; Tue, 22 Nov 2022 12:46:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSfq-0002ru-LA for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 12:46:50 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20602.outbound.protection.outlook.com [2a01:111:f400:7e1b::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b9ac9e3c-6a63-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 13:46:47 +0100 (CET) Received: from AS9PR0301CA0041.eurprd03.prod.outlook.com (2603:10a6:20b:469::32) by AS8PR08MB9550.eurprd08.prod.outlook.com (2603:10a6:20b:61d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 12:46:45 +0000 Received: from AM7EUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:469:cafe::b0) by AS9PR0301CA0041.outlook.office365.com (2603:10a6:20b:469::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Tue, 22 Nov 2022 12:46:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT050.mail.protection.outlook.com (100.127.141.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Tue, 22 Nov 2022 12:46:45 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Tue, 22 Nov 2022 12:46:44 +0000 Received: from 0a8110988f2e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C27B624D-1237-4FFE-989D-BD5A2EFEDF9F.1; Tue, 22 Nov 2022 12:46:39 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0a8110988f2e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Nov 2022 12:46:39 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB9195.eurprd08.prod.outlook.com (2603:10a6:20b:57f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 12:46:37 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5857.013; Tue, 22 Nov 2022 12:46:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9ac9e3c-6a63-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mGLB/wtv91hEU0lKR4BhU9TgSqz6jmnlLehiaq3oBGg=; b=z0eZKNzIIIciDxCnjWdMchaHGO0XT6BsIKrTuxQPurgtk9awEEuU/B/E2eADvFCjhs1unfpe2lAsOPABsok3y4rZQsE3JYWm3b0HKzjjxy/DJLFMb9HDnlV2B6ZeX3MVUGrfakss/QzP/BV5UMpkemH3UpqcLcKKPaKD+eUT64o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K681y2qpkoJvv/qCPqDIoYgd3/nwNmNfUzYliLgqEO+QQFR80s8O1pgRHTll+/RyG/s6zSqx037zdaWTRBBjpoEUgv2SP867eYmZQyHbXEjuWIj6NwOAi9sOpfZE6ONcJvvxgsYPMqVIalVAE1aWuoeDOYXu3QNNXxuVQGQnxyaa7sjPEq7t5O8d8AiAQXxJlzBJeoP556fKm52ImHAV2804tFQg6RPiaE2pF9CBwIAFMfHRSsxqulWAEGW8Ld5zfbfeW1j+/70Jf8jHBGKfKqeMQhfnOmPqnvfPz43aGw8/OdAmM/rf9QfTNkfY8kaNWORzhYGKMuS7ACnhORI+WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mGLB/wtv91hEU0lKR4BhU9TgSqz6jmnlLehiaq3oBGg=; b=EokwAtKakk0bgGKRCu//d9BrsLKmVoV/pwcoDEffzIajs8ou59K4lOF4I3pwYP9kWM6K4xiBE4He5vqJALT2rIA5z2o588BpEbJd6JG5GxftCTRg0rZSqdB33mSEoXyAczycQW9dlMJSxfj12kwX/Tr77N23CJK46iua4rLdEcF7U0/OzwZ/Vex8zdsZcJMTBVNssZOvVVSIvwt7ok0dyOB4n0xXk5cjnFQi6bD72v5oCQ6/JaLmuoQrradaCFF6oOVk2FStm8nS1LpkMsRNWpcxVhqUBI5NtQQalHwCzgMKBiqXHyj/nRZw+4+JWt8SjLUPrkBBXH+clugR5tFVOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mGLB/wtv91hEU0lKR4BhU9TgSqz6jmnlLehiaq3oBGg=; b=z0eZKNzIIIciDxCnjWdMchaHGO0XT6BsIKrTuxQPurgtk9awEEuU/B/E2eADvFCjhs1unfpe2lAsOPABsok3y4rZQsE3JYWm3b0HKzjjxy/DJLFMb9HDnlV2B6ZeX3MVUGrfakss/QzP/BV5UMpkemH3UpqcLcKKPaKD+eUT64o= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Jan Beulich , Andrew Cooper , Bertrand Marquis , Stefano Stabellini Subject: RE: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Thread-Topic: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Thread-Index: AQHY/mWeJ7PIIiwbMEi0iLnxeCbJiq5K2wSAgAAHBWA= Date: Tue, 22 Nov 2022 12:46:37 +0000 Message-ID: References: <20221122112623.1441905-1-Henry.Wang@arm.com> <20221122112623.1441905-2-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F6BA55D6E589A14F8B63FC29A5A2B20F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB9195:EE_|AM7EUR03FT050:EE_|AS8PR08MB9550:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e1f3c41-ff1d-4249-9d6e-08dacc879ce1 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3/LJQzxq6wXdXdom3Cd0KOwPvT9+gNakuABXKw44eVr4rIarQyTKzsGPjqewshWHa307fOJsEFEeEXlwy91asJ7VexGSZ9C/NIWgZIP9CuA2Y/ACJjg7X5xwusCZJ2InxpfqWf/HSlFDb0+2No8jaYPc5A0PPN1jJlybmNxaYngR2O8rCDHcJXDhPE+oDWTrl+HjDMpyAqlOdX8HWUJ6l8Y5QsP4QpTE6Iz+Wgz/n/wU0396kMW+TpdsEr8xi8GLJPgfJWkxDTkrOh2g4KY4dRaJOa5qU+txGO+mOHmXjt9dFJ15Pv9YdXBON6Gu9yGZclZybDw5wWdcc4BlCH0r02or/aAdDg3+qjnioYQHUQF73iHHzyaqAw4HT7DAjaLlulMWBHIrh1TnMBHg6kRl9/tQX0VkfRwHWuW3/d+ycT4Ojs3H+ZIlfl86nJdAZgYiNu/LY6lRHGi7AHbJS6hWNDpUU+n3d1oYaA62ksviS68/BcAdS0zlg8HLlC0XbyXrcnDjJ+36oSVIDB0hibTYgT+eFhSpBKELTfw6oDJxECxwapDBuHfW/+U+3BayFCwCC+lSrjpXZvl494qxy/WMu66r/6W92lRwm7fpRCQZ/d/Xy/soTMjyo/R3b3q+vDO4MsuV6ob7baKN6YtSVRpZ/4963z9Q3cmlKPUMMVo0w/fHxyasbE8RwMVwTpnUTPWnyyf0/2eoh0jDub4bppkxqETTI6Tg0kGjKMU15j6L63o3ts47RIZ4DIF3I0LwZXtiLXZoDwDocsbNQGS5ZQ7YYR/KmupR5229OD/M1L52FHpHLqbQiq6R46CcGOrNbcIY2zRf7psMCsAHw8OAkESWqawPJN2IORv+kq6Z7IOb860= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(346002)(136003)(376002)(39860400002)(451199015)(55016003)(2906002)(186003)(38070700005)(38100700002)(8936002)(66556008)(6506007)(7696005)(76116006)(26005)(5660300002)(66476007)(66946007)(4326008)(316002)(64756008)(53546011)(8676002)(9686003)(33656002)(966005)(478600001)(83380400001)(41300700001)(52536014)(122000001)(66446008)(71200400001)(54906003)(86362001)(110136005)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9195 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b3ef9100-daa4-4bd6-3a0b-08dacc879847 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: euptK0BY/rim2oFyUcU/25FH7sO3ym2rSXkjPilJ2aOdOg9A/Mhggvlt7CA99oxYhqL/AtPI1wi9m6t6xn2/EvUWYjzzuPJlpsEFdu6V46yr0moQ3PCrVg82Ivj72EvAOMxkwYdk+1cHnvXMerJtuexV1M1dmT1t+7GMdrDwB40qsSRVmsjGiywzwGBO+sWrXHjOY5oCTMfLvg4CJx8SVgLd+JSF6yHJ32+KMrSurR77fAxQndt4PJMtd8GUuOxXC7EIWC1NaMsfqeuujdxfwvw1+BSUu8JmvMevEdW/J4ofR76/ndIKTWd3e1jBvOb2U+U0JVDJurhWZ1zsdFhQFS3LxLzkglwl0UZwFVUV0oCboBP0lGby6nmoKdvWv6T0rNxVmTJgSjGHuvbmGRbOobKhuWz9CVshowmF2mCCtFba08NFKuK34XMBbHrxO32ZbF1ULGhfKEYRqo7wdg6abapb5+b5IOdFHyvXJsd6E66GmuGcF3d7AK14OM+MthrkPNYp+p44W8j4E3tZo3xxc7lhueFRu+Bx4cWNOaYF0YZk3jaRKWpP2XBDSlXhYTqau5A1Q50F6uABoxJJllXJtm9EpY3UTPy4ndcdkZVctb1HzpFifii1XUmBIOT8v6f0/7QXF9W8GxnTlX3VN5h5YZjlAddVP1torjYb0uRmIRtXT8a+Si5wSsoy2lOt73ljamUXU/PcjIDpW5mQduQIyTnubuRToOWvlXu+6v7gnT2wIxyIAcZrd9dKEmR3TntetoZLWQbKjazu6UBqH6HlOPWokTRqGyACqwuZAa6eq6hL+xgAQjv7IwoOy920dMnGbRqvb6ysRRPNi6WlDqRPlrnjW7G5kRDEmPcqfdJEgVo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(346002)(136003)(451199015)(40470700004)(46966006)(36840700001)(33656002)(356005)(82740400003)(81166007)(86362001)(8676002)(4326008)(83380400001)(8936002)(2906002)(70586007)(36860700001)(54906003)(110136005)(316002)(336012)(186003)(47076005)(966005)(478600001)(7696005)(41300700001)(82310400005)(52536014)(55016003)(40460700003)(70206006)(5660300002)(40480700001)(53546011)(6506007)(26005)(9686003)(107886003)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 12:46:45.0404 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e1f3c41-ff1d-4249-9d6e-08dacc879ce1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9550 SGkgSnVsaWVuLA0KDQpUaGFua3MgZm9yIHlvdXIgcmV2aWV3IGFzIGFsd2F5cyENCg0KPiAtLS0t LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYzIDEvM10gQ0hBTkdFTE9HOiBBZGQgbWlzc2lu ZyBlbnRyaWVzIGZvciB3b3JrIGR1cmluZw0KPiB0aGUgNC4xNyByZWxlYXNlDQo+IA0KPiAoUmVk dWNpbmcgdGhlIENDLWxpc3QpDQoNClRoYW5rcywgSSB3aWxsIHVzZSB0aGlzIENDLWxpc3QgaW4g djQuDQoNCj4gDQo+IEhpLA0KPiANCj4gT24gMjIvMTEvMjAyMiAxMToyNiwgSGVucnkgV2FuZyB3 cm90ZToNCj4gPiBTaWduZWQtb2ZmLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ DQo+ID4gLSAtIFN1cHBvcnQgVklSVF9TU0JEIGZlYXR1cmUgZm9yIEhWTSBndWVzdHMgb24gQU1E Lg0KPiA+ICsgLSBTdXBwb3J0IFZJUlRfU1NCRCBmZWF0dXJlIGZvciBIVk0gZ3Vlc3RzIG9uIEFN RCBhbmQNCj4gTVNSX1NQRUNfQ1RSTCBmZWF0dXJlIGZvcg0KPiA+ICsgICBTVk0gZ3Vlc3RzLg0K PiANCj4gRGlkIHlvdSByZWFsbHkgaW50ZW5kIHRvIHdyaXRlICJTVk0iIHJhdGhlciB0aGFuIEhW TT8gSWYgeWVzLCB0aGVuIHRvIG1lDQo+ICJIVk0gZ3Vlc3RzIG9uIEFNRCIgbWVhbnMgdGhlIHNh bWUgYXMgIlNWTSBndWVzdHMiLg0KDQpJIGFtIHNvcnJ5IGFib3V0IHRoZSBjb25mdXNpb24uIEkg dGhpbmsgdGhlIGxhdHRlciBwYXJ0IG9mIHRoaXMgc2VudGVuY2UgaXMNCmp1c3QgYSBkaXJlY3Qg Y29weSBvZiB0aXRsZSBpbiBbMV0uIEJ1dCBieSByZWFkaW5nIHRoZSBjb250ZW50IG9mIHRoYXQN CmNvdmVyIGxldHRlciBJIHRoaW5rLi4uDQoNCj4gDQo+IFNvIEkgd291bGQgc3VnZ2VzdCB0aGUg Zm9sbG93aW5nIHdvcmRpbmc6DQo+IA0KPiBTdXBwb3J0IGZvciBWSVJUX1NTQkQgYW5kIE1TUl9T UEVDX0NUUkwgZm9yIEhWTSBndWVzdHMgb24gQU1ELg0KDQouLi50aGlzIGlzIGNvcnJlY3QuIFNv IEkgd2lsbCB1c2UgeW91ciBzdWdnZXN0ZWQgc2VudGVuY2UgaW4gdjQuIFRoYW5rcy4NCg0KPiAN Cj4gPiArIC0gU3VwcG9ydCBWaXJ0SU8tTU1JTyBkZXZpY2VzIGluIHRvb2xzdGFjayBvbiBBcm0u DQo+IA0KPiBJIHdvdWxkIGNsYXJpZnkgdGhhdCB0aGlzIGlzICpvbmx5KiBjcmVhdGluZyB0aGUg ZGV2aWNlLXRyZWUgYmluZGluZy4NCj4gSU9XLCB0aGVyZSBhcmUgbm8gc3VwcG9ydCBmb3IgQUNQ SSBub3IgZGV2aWNlLWVtdWxhdG9yIChzdGlsbCBpbg0KPiBwcm9ncmVzcyBmcm9tIFhlbiBQcm9q ZWN0IFBvVikuDQoNCllvdSBhcmUgY29ycmVjdC4gSSB3aWxsIGNoYW5nZSB0bzoNCiJTdXBwb3J0 IFZpcnRJTy1NTUlPIGRldmljZXMgZGV2aWNlLXRyZWUgYmluZGluZyBjcmVhdGlvbiBpbiB0b29s c3RhY2sNCm9uIEFybSINCg0KPiANCj4gPiArIC0gQWxsb3cgc2V0dGluZyB0aGUgbnVtYmVyIG9m IENQVXMgdG8gYWN0aXZhdGUgYXQgcnVudGltZSBmcm9tIGNvbW1hbmQNCj4gbGluZQ0KPiA+ICsg ICBvcHRpb24gb24gQXJtLg0KPiA+ICsgLSBHcmFudC10YWJsZSBzdXBwb3J0IG9uIEFybSB3YXMg aW1wcm92ZWQgYW5kIGhhcmRlbmVkIGJ5DQo+IGltcGxlbWVudGluZw0KPiA+ICsgICAic2ltcGxp ZmllZCBNMlAtbGlrZSBhcHByb2FjaCBmb3IgdGhlIHhlbmhlYXAgcGFnZXMiDQo+ID4gKyAtIEFk ZCBSZW5lc2FzIFItQ2FyIEdlbjQgSVBNTVUtVk1TQSBzdXBwb3J0IG9uIEFybS4NCj4gPiArIC0g QWRkIGkuTVggbHB1YXJ0IGFuZCBpLk1YOFFNIGluaXRpYWwgc3VwcG9ydCBvbiBBcm0uDQo+IA0K PiBJIHdhcyB1bmRlciB0aGUgaW1wcmVzc2lvbiB0aGF0IHRoZSBjb2RlIHRoYXQgd2FzIG1lcmdl ZCBpcyBlbm91Z2ggdG8NCj4gc3VwcG9ydCB0aGUgcGxhdGZvcm0uIERvIHlvdSBoYXZlIGFueSBw b2ludGVyIHdoZXJlIGl0IHNheXMgaXQgaXMgbm90DQo+IHN1ZmZpY2llbnQ/DQoNCkFoIHRoaXMg aXMgYWxzbyBkaXJlY3RseSBmcm9tIHRoZSB0aXRsZSBvZiBbMl0sIHdoZXJlIGl0IGlzIG9ubHkg YQ0KInhlbi9hcm06IGFkZCBpLk1YIGxwdWFydCBhbmQgaS5NWDhRTSBpbml0aWFsIHN1cHBvcnQi DQoNCkkgd291bGQgYmUgbW9yZSB0aGFuIGhhcHB5IHRvIHJlbW92ZSB0aGUgImluaXRpYWwiIGlm IHlvdSB0aGluayBpdCBpcw0KYXBwcm9wcmlhdGUuDQoNCj4gDQo+ID4gKyAtIEltcHJvdmVkIHRv b2xzdGFjayBidWlsZCBzeXN0ZW0uDQo+ID4gKyAtIEFkZCBYdWUgLSBjb25zb2xlIG92ZXIgVVNC IDMgRGVidWcgQ2FwYWJpbGl0eS4NCj4gPg0KPiA+ICAgIyMjIFJlbW92ZWQgLyBzdXBwb3J0IGRv d25ncmFkZWQNCj4gPiAgICAtIGRyb3BwZWQgc3VwcG9ydCBmb3IgdGhlICh4ODYtb25seSkgInZl c2EtbXRyciIgYW5kICJ2ZXNhLXJlbWFwIg0KPiBjb21tYW5kIGxpbmUgb3B0aW9ucw0KDQpbMV0g aHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzIwMjIwMTI4MTMyOTI3LjE0OTk3LTEt YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbS8NClsyXSBodHRwczovL2xvcmUua2VybmVsLm9yZy94 ZW4tZGV2ZWwvMjAyMjA0MTkwNDM5MjcuMjM1NDItMS1wZW5nLmZhbkBvc3MubnhwLmNvbS8NCg0K S2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVu IEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 22 12:47:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 12:47:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447144.703059 (Exim 4.92) (envelope-from ) id 1oxSgI-0003L5-Mg; Tue, 22 Nov 2022 12:47:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447144.703059; Tue, 22 Nov 2022 12:47:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSgI-0003Ky-Jl; Tue, 22 Nov 2022 12:47:18 +0000 Received: by outflank-mailman (input) for mailman id 447144; Tue, 22 Nov 2022 12:47:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSgH-0003CI-21 for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 12:47:17 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cac570e1-6a63-11ed-8fd2-01056ac49cbb; Tue, 22 Nov 2022 13:47:16 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3A92E21D3F; Tue, 22 Nov 2022 12:47:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DEDFA13B01; Tue, 22 Nov 2022 12:47:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6TL5NNLEfGMtNAAAMHmgww (envelope-from ); Tue, 22 Nov 2022 12:47:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cac570e1-6a63-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669121235; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YsI7A9SUK5qB234FSuBPSK2EHGVG9qNw7j4AtLZMBFs=; b=HcI0V97JVESYsYCFrZMA/9XvAVxNCGjH531cFEv8+9xWNpmt9D+e/kJ+ADeycemTTztcdD 1pBn8cOQ0yiSWUGagYyz+qRPQju7a+IIWQyxk5MIsYdMbEKzpAcNwK69SL5gXPH3rNSRiA 0bRVi+M2wb9wNR4jnIHvyhfPLfQyViI= Message-ID: Date: Tue, 22 Nov 2022 13:47:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 0/5] x86: Switch X86_FEATURE_XENPV to cpu_feature_enabled() use Content-Language: en-US To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Pu Wen References: <20221104072701.20283-1-jgross@suse.com> From: Juergen Gross In-Reply-To: <20221104072701.20283-1-jgross@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------BM67QrvznezM2snUWc094p0n" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------BM67QrvznezM2snUWc094p0n Content-Type: multipart/mixed; boundary="------------DY0Si20AgKhX1epXJ30fV0Ic"; protected-headers="v1" From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Pu Wen Message-ID: Subject: Re: [PATCH v2 0/5] x86: Switch X86_FEATURE_XENPV to cpu_feature_enabled() use References: <20221104072701.20283-1-jgross@suse.com> In-Reply-To: <20221104072701.20283-1-jgross@suse.com> --------------DY0Si20AgKhX1epXJ30fV0Ic Content-Type: multipart/mixed; boundary="------------E5GA5WyRnhJiGBCZDpezveYm" --------------E5GA5WyRnhJiGBCZDpezveYm Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMTEuMjIgMDg6MjYsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE1ha2UgZXNwZWNp YWxseSBrZXJuZWxzIHdpdGhvdXQgQ09ORklHX1hFTl9QViBtb3JlIGVmZmljaWVudCBieQ0K PiB1c2luZyBjcHVfZmVhdHVyZV9lbmFibGVkKFg4Nl9GRUFUVVJFX1hFTlBWKSBpbnN0ZWFk IG9mIGJvb3RfY3B1X2hhcygpDQo+IGFuZCBmcmllbmRzLg0KPiANCj4gQ2hhbmdlcyBpbiBW MjoNCj4gLSBuZXcgcGF0Y2ggNA0KPiANCj4gSnVlcmdlbiBHcm9zcyAoNSk6DQo+ICAgIHg4 NjogYWRkIFg4Nl9GRUFUVVJFX1hFTlBWIHRvIGRpc2FibGVkLWZlYXR1cmVzLmgNCj4gICAg eDg2OiByZW1vdmUgdW5uZWVkZWQgNjQtYml0IGRlcGVuZGVuY3kgaW4gYXJjaF9lbnRlcl9m cm9tX3VzZXJfbW9kZSgpDQo+ICAgIHg4NjogZHJvcCAzMi1iaXQgWGVuIFBWIGd1ZXN0IGNv ZGUgaW4gdXBkYXRlX3Rhc2tfc3RhY2soKQ0KPiAgICB4ODY6IHJlbW92ZSBYODZfRkVBVFVS RV9YRU5QViB1c2FnZSBpbiBzZXR1cF9jcHVfZW50cnlfYXJlYSgpDQo+ICAgIHg4Njogc3dp dGNoIHRvIGNwdV9mZWF0dXJlX2VuYWJsZWQoKSBmb3IgWDg2X0ZFQVRVUkVfWEVOUFYNCj4g DQo+ICAgYXJjaC94ODYvaW5jbHVkZS9hc20vZGlzYWJsZWQtZmVhdHVyZXMuaCB8IDggKysr KysrKy0NCj4gICBhcmNoL3g4Ni9pbmNsdWRlL2FzbS9lbnRyeS1jb21tb24uaCAgICAgIHwg NCArKy0tDQo+ICAgYXJjaC94ODYvaW5jbHVkZS9hc20vc3dpdGNoX3RvLmggICAgICAgICB8 IDcgKystLS0tLQ0KPiAgIGFyY2gveDg2L2tlcm5lbC9jcHUvYW1kLmMgICAgICAgICAgICAg ICAgfCAyICstDQo+ICAgYXJjaC94ODYva2VybmVsL2NwdS9idWdzLmMgICAgICAgICAgICAg ICB8IDIgKy0NCj4gICBhcmNoL3g4Ni9rZXJuZWwvY3B1L2h5Z29uLmMgICAgICAgICAgICAg IHwgMiArLQ0KPiAgIGFyY2gveDg2L2tlcm5lbC9wcm9jZXNzXzY0LmMgICAgICAgICAgICAg fCA0ICsrLS0NCj4gICBhcmNoL3g4Ni9rZXJuZWwvdG9wb2xvZ3kuYyAgICAgICAgICAgICAg IHwgMiArLQ0KPiAgIGFyY2gveDg2L21tL2NwdV9lbnRyeV9hcmVhLmMgICAgICAgICAgICAg fCA4ICsrLS0tLS0tDQo+ICAgOSBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCAy MCBkZWxldGlvbnMoLSkNCj4gDQoNClRoZSBwYXRjaGVzIGhhdmUgYWxsIGFuICJBY2siIGJ5 IERhdmUuIEkgdGhpbmsgdGhpcyBzZXJpZXMgc2hvdWxkIGdvIGluDQp2aWEgdGhlIHRpcCB0 cmVlLCBubz8NCg0KDQpKdWVyZ2VuDQo= --------------E5GA5WyRnhJiGBCZDpezveYm Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------E5GA5WyRnhJiGBCZDpezveYm-- --------------DY0Si20AgKhX1epXJ30fV0Ic-- --------------BM67QrvznezM2snUWc094p0n Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmN8xNIFAwAAAAAACgkQsN6d1ii/Ey+X Zgf+Kyl5SsflAy66qlgC+7jxck3nSUVruLb5t+QS9ovIZUCboi2QQopfEtZqI2aNaAVuQSUjNTKQ tJnBHduslM0ZEdNA9o3bOTKajo4Uweh7ruP5lq93jsaSc2cvj0TnjSbStk8O1b+VN+vaAO94vmwG qVUZ1stQtYRQ1x92zvMYX5Nk1oRlcSIBsVjSk23QU0D4+iFqUpV+/Jo8u+YKrxp7gZulXpD3vUMX AeegrU2HZKPHDsuD9ax3LFZ/YIILqJCxdrkIjNb+DhynYR9GsQqvPYWa9mMId/kyvCvhX3Rv1lpi UZezHAhtybIkPo77jldrjQQKu+IsDgKSSINmXwx58g== =gZnK -----END PGP SIGNATURE----- --------------BM67QrvznezM2snUWc094p0n-- From xen-devel-bounces@lists.xenproject.org Tue Nov 22 12:47:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 12:47:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447148.703070 (Exim 4.92) (envelope-from ) id 1oxSgh-0003vh-VI; Tue, 22 Nov 2022 12:47:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447148.703070; Tue, 22 Nov 2022 12:47:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSgh-0003va-SO; Tue, 22 Nov 2022 12:47:43 +0000 Received: by outflank-mailman (input) for mailman id 447148; Tue, 22 Nov 2022 12:47:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSgh-0002ru-9l for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 12:47:43 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060b.outbound.protection.outlook.com [2a01:111:f400:7d00::60b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id daaa1b8a-6a63-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 13:47:42 +0100 (CET) Received: from AS9PR04CA0142.eurprd04.prod.outlook.com (2603:10a6:20b:48a::16) by DU0PR08MB7907.eurprd08.prod.outlook.com (2603:10a6:10:3b1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 12:47:40 +0000 Received: from VI1EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:48a:cafe::23) by AS9PR04CA0142.outlook.office365.com (2603:10a6:20b:48a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Tue, 22 Nov 2022 12:47:40 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT033.mail.protection.outlook.com (100.127.144.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Tue, 22 Nov 2022 12:47:39 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Tue, 22 Nov 2022 12:47:39 +0000 Received: from 8848a3136710.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 30A6D0E9-2E78-47AD-BE39-64FB0002094D.1; Tue, 22 Nov 2022 12:47:33 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8848a3136710.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Nov 2022 12:47:33 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB7766.eurprd08.prod.outlook.com (2603:10a6:20b:526::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 12:47:31 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5857.013; Tue, 22 Nov 2022 12:47:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: daaa1b8a-6a63-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6LpsNp6smybJ3wD5pJJ7YlNcHmaZvW1d0m0RIET8cVQ=; b=y/Aal0RkF4JnptXV0DpqLEfUYcJ+5QpjVMYBhExL6oONRBxr0R9Ztvr85O6jYacZAwKGNkWYfbaYCiQ4+GVet97GiI5x5bDA5OOvBauqNHeEfaO2Bh8axKYuLzJ1HdqjKQK7AYvtd6QSVCBrCNdBBEPdmmtGpf1sY4lmWjMj7+c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lwX//6NGfyRDiSrofj/VxP0cKKmjDYy/qT4fGCLpfbA73t8QqHrN/4EWRLR/eDzV5vjpISrA98peJvGlnCh1eQx/a7WHyH7GoINCB24qNRopCWwlRSATT4IOVkTiRbozuzVA1yVvGHDI5AxBjTG2sL+Dn/WIu5hH+0Vp7cUy6Lhz2LuqE/wB8Jrd5V8dqyBavA37h8VosawvvIf/aCYm4L+eumWBTnQFjZ7cDM6GbtqazLGPnp8wbtlfynpFdRO1qphuqBIt02JqlPcCMmRRDWabgFS4pgowJQ+TujPJjZ0JuwlU90qirHjYeLokU32o2u9/VC2E8pMAmKbEyZSpuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6LpsNp6smybJ3wD5pJJ7YlNcHmaZvW1d0m0RIET8cVQ=; b=KPgL+Iqh2N20L0ZG3Roz6y3ezQlCM8LuWFffVyGTUmczYLu219t3Cn0aqZvMHwxRVp6psBreljpgG9OaxSPHwld/4jWZm/EMb7x38F20Kkn5719feFMrZRgkyt3ajc+B9LIC4fLs5xMLURVXDGEz9khf9hbkvlpqjK5G004jc0q0i91nF52DlmuhqSRI4uS92VA3G97aisSa2eJUwbc45z9u7LlFIQRxJuHBj2M3MCHjbQyVTr+piHsLRYoSAq8jVH6yMaWX8+XzI78Js5A0YVTyM6nB1nStkc5oQD5va7XxkU2AzYGMC75RQmbmUaxIYEVAWyAGro+BDCEZIvjY4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6LpsNp6smybJ3wD5pJJ7YlNcHmaZvW1d0m0RIET8cVQ=; b=y/Aal0RkF4JnptXV0DpqLEfUYcJ+5QpjVMYBhExL6oONRBxr0R9Ztvr85O6jYacZAwKGNkWYfbaYCiQ4+GVet97GiI5x5bDA5OOvBauqNHeEfaO2Bh8axKYuLzJ1HdqjKQK7AYvtd6QSVCBrCNdBBEPdmmtGpf1sY4lmWjMj7+c= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Jan Beulich , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Community Manager Subject: RE: [PATCH v3 2/3] Changelog: Add __ro_after_init and CET Thread-Topic: [PATCH v3 2/3] Changelog: Add __ro_after_init and CET Thread-Index: AQHY/mWEFM0MUU7mj0ueqMutGzP20q5K3AqAgAAIFLA= Date: Tue, 22 Nov 2022 12:47:30 +0000 Message-ID: References: <20221122112623.1441905-1-Henry.Wang@arm.com> <20221122112623.1441905-3-Henry.Wang@arm.com> <91ccea91-5b4c-4348-0efa-725aca1d683a@xen.org> In-Reply-To: <91ccea91-5b4c-4348-0efa-725aca1d683a@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 89417DCF1559ED40B991B3E4BB2698D2.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB7766:EE_|VI1EUR03FT033:EE_|DU0PR08MB7907:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d388124-1692-4528-64c7-08dacc87bd5e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: k74KjCyyVkqP/sevEJ8WGLu7zGL3gzXPf4FOS0O68Y04xFPbtmrJA31bFZuxBb2MRHQwtHJkRQa8Aa+BXFR9EkpQushLMLpQ80bhZoyz4PpKvfBV7+PQ+PLeiPWuf7OuT0Des79KTkRaKssTzA87RP5cdaaooceejiawCTrlzUg2qWZKd+N7SG0oCWA9+MMtKFxCdyxIzrTqWtzhl99vopkunMu5fdK7pFk/Cc0BrP3yIdAR3o9ADcGmiM7zBF4mK2YEjPz+hMivNm5IpVmSpYFy/sByykYqlSaPPmRzyasQAvcScg62cu67oghGFojvVWz9RYcy1uan+nMNQAeuR/TpOKMrKYUQXzZe2rs5DINCFDqJbwieZ9aJAXwsyoW60OBzz1PHHz63uuevyTUNLevPC0OYzrRpOSNfRRQlmZAliGPR9+CsdHoUw6m4EOfnbY8MvD8XnrtTWtm+4QBFZ8f5g7AIaAHmMhh97O2vhsYPDj1GrZYtk6b5u51ywEtg8qSFxfoJWcjLgCSfx/yWLOp3GMcN0uFpGBRtmLU82LPXgDFbqr849v9rqbvFg8UXZXWxcOa6Vq6RqDeN5xRuwdBrgjsM9nrJ6IB2/20VPh2vXqYC6WoXyY2U2bnCeujQM0tS6ecOQUHfKonXYSKSKlvVZ7RZdc+gJEwm6ngLPqb1pr8D1vbIxPJF2Vkc3rb8RFOJlNAskxyIFYQc2Dy0rLdXx+eaZHJtZoST10yD0mZwa01GQ/aT0iwMS1FEluQHNP23BC86h8/nfmtVUP7OSFTsKYsf8t3PNjrcs7SCRnUUBpqPHpv2Zlk37Q4phDskavfU9kNdTXZ7PXq+FtRQTg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(346002)(366004)(451199015)(7696005)(6506007)(53546011)(26005)(186003)(110136005)(122000001)(2906002)(478600001)(71200400001)(9686003)(38070700005)(38100700002)(33656002)(55016003)(83380400001)(86362001)(8936002)(4744005)(41300700001)(76116006)(66556008)(64756008)(66946007)(66476007)(52536014)(8676002)(66446008)(5660300002)(4326008)(54906003)(316002)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7766 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9f5d3210-6d3b-4f12-f273-08dacc87b832 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XN4sg3OGalV1/oukP8ct8jMAGqvZ/X6MRc0W4R/KnKrrfpgq+V5RriwA9CJb7iVto5qe7x4kzmTz1XD72ViTfpuUa4QJk28hXiiDV/uNb5lHE6REYpQR6EFinujVc1ZFRaA+9c7rxkPQZOP9eVsAu09KK14fVNc/v+/oD7NPxUAHDj0O/rTJkcgnUlpgQWRSqIoBcP8j3n2aCoEw1/vWeLPzgiZ+so7ym131O9jrPt8gjum7RcW90wcM4VGWmjP+AXlsSW5ndM6udpDftTzqZx/s5/FjQzNBK4OViWj/k955tYKpFhJxN+QDUvC/EUHUA+D2P4ZSL8bkvNlnGnf/TGoj2xrWyWoKThzJ7TmBUNWs+bgLfarvuwrrbtH2+KBXaAeL0dfoJhYkSzCckouSXXfuK7ohP34n5QlgkM3Q0bz5OZCQjvRs0WB/rNuVe81zMCimPQ8wKuOgIyck6wnh91DwyA3j9eCFbWWgu5QjHQlhxkD2esNIJpBT9SW+8pHEFOvaGyxQHQPc2vwT695QpvDUV+JX3bslXdDQuf4rV4eFdAqDE/DB4OPmCjD5DumA9MTtHtZ6SMUhQrfXk+pWjbEYTe4X7qMLVAhK7DtfV453Qb2DN9gkElX9cjlfh+pOEIoFxitE9enqcwGONoZ59+VyWVcOH8DBiAlgIRbpJXw2/6su8YkGbZDLRMKeh20cechWcUxMjXZpd79jFF+h1uXVpwj5aMpeGnnD8eFwxrW/PWJed6KqgCHQrrYEV1Y1AS8P6izsOooil2H3d163lvKjV71YXvf2uRhyFSjuOy4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(136003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(33656002)(70586007)(478600001)(70206006)(4326008)(8676002)(316002)(36860700001)(41300700001)(55016003)(5660300002)(82310400005)(52536014)(54906003)(40460700003)(110136005)(81166007)(82740400003)(356005)(40480700001)(47076005)(53546011)(26005)(6506007)(7696005)(9686003)(186003)(86362001)(83380400001)(336012)(2906002)(4744005)(8936002)(59356011)(219803003)(207903002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 12:47:39.4984 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2d388124-1692-4528-64c7-08dacc87bd5e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7907 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMgMi8zXSBD aGFuZ2Vsb2c6IEFkZCBfX3JvX2FmdGVyX2luaXQgYW5kIENFVA0KPiANCj4gSGkgSGVucnksDQo+ IA0KPiBPbiAyMi8xMS8yMDIyIDExOjI2LCBIZW5yeSBXYW5nIHdyb3RlOg0KPiA+IEZyb206IEFu ZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+ID4NCj4gPiBTaWduZWQt b2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiANCj4g WW91ciBzaWduZWQtb2ZmLWJ5IGlzIG1pc3NpbmcuDQoNClNvcnJ5IEkgY29tcGxldGVseSBmb3Jn b3QgSSBuZWVkIHRvIGFkZCBteSBvd24gc2lnbi1vZmYgaWYgSSBjaGFuZ2VkDQpvdGhlciBwZW9w bGUncyBwYXRjaC4gV2lsbCBhZGQgaW4gdjQuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 22 13:02:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 13:02:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447158.703081 (Exim 4.92) (envelope-from ) id 1oxSuT-0006b8-7p; Tue, 22 Nov 2022 13:01:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447158.703081; Tue, 22 Nov 2022 13:01:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSuT-0006b1-4U; Tue, 22 Nov 2022 13:01:57 +0000 Received: by outflank-mailman (input) for mailman id 447158; Tue, 22 Nov 2022 13:01:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxSuS-0006av-0C for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 13:01:56 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20604.outbound.protection.outlook.com [2a01:111:f400:fe13::604]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d639b5e8-6a65-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 14:01:54 +0100 (CET) Received: from DU2PR04CA0204.eurprd04.prod.outlook.com (2603:10a6:10:28d::29) by PAWPR08MB9542.eurprd08.prod.outlook.com (2603:10a6:102:2ed::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 13:01:49 +0000 Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28d:cafe::b8) by DU2PR04CA0204.outlook.office365.com (2603:10a6:10:28d::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Tue, 22 Nov 2022 13:01:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Tue, 22 Nov 2022 13:01:48 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Tue, 22 Nov 2022 13:01:48 +0000 Received: from b485587a1f7f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D85419D4-D787-4963-AD5E-FA2164E2225B.1; Tue, 22 Nov 2022 13:01:42 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b485587a1f7f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Nov 2022 13:01:42 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PR3PR08MB5611.eurprd08.prod.outlook.com (2603:10a6:102:85::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 13:01:40 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5857.013; Tue, 22 Nov 2022 13:01:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d639b5e8-6a65-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FbfDe2/tD+H2krNtxFerY6zA4E0NL6H9mw07H98uRyM=; b=e69OrnMxPiLOZf4gzdpanP7HnFQot/NW5BVuF6EZRHQF7o/zbrhHVZYySgSm3qqwb4P6p07SkQdftS8tW054sKZEepuC/3L2ITNn4YN+bUaP3MjeDF8MeZQMRk9yCn7RxbtuoC5N4FoI6AUJbgUbXqH++CR7+4YvyyxkAC8xHJc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fbNLzLX1AjE3X68hyDoZopgIq50mUp9UuPzfgT/tcxsVpLIsiJbPS7nhDKLStC27iAqq0oUfVWNaehg33RBo9PZo0pQOUmqsXemtJGsUpm/3HvEwvpTXDzX3xNbmtTU9DpO1NucxknU9nAXBZ5S5KyZM+gUbce1I0x48bh1fPEkGkkFbzm8TZXVyZuxuV5L1YByquyKy0tWkyt/7Ia7TYMq6HkyHlcg6mke00ySfUDtzLbAfzcJzmEm/U0vldzcpdSYNvD5uz9m0XzLVV45XP+G1vsTsWGIRl8IIeLVLrXtCFPlUSVJy39Vp7MYWdYz/4OxbOkKge2S/+OnSHtD9Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FbfDe2/tD+H2krNtxFerY6zA4E0NL6H9mw07H98uRyM=; b=cie38JK8nTPa2JBUTBRhQNrhkckS7454i+gBopT/K5J0+UBjUNiSUtSKqVfX4DLkZPf19FdttQ+0KSo3ZVVm1GLpGj+7bu+i8fGz0bpMAQhxTo5VHelpZuqkpcJWlKqAQgjHibX2koa8R82p3avxcqW7SkudC4zK3EVgz+BKDUrqGr5nqlK7487ek2dLIA1Xlh5X0BFMV/MSEa/CbdzqwIFTziPWbTSusobjhmlzESv+hgPzhExkodCwRmVUDDH/uI/ofceXJM0+tNfLJp4TqhxrRp81L80T64fEIwxbfbQRsxsiW5MzntdlZQTb8mWVW3lE0RlQkETnmJ/U30o8Rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FbfDe2/tD+H2krNtxFerY6zA4E0NL6H9mw07H98uRyM=; b=e69OrnMxPiLOZf4gzdpanP7HnFQot/NW5BVuF6EZRHQF7o/zbrhHVZYySgSm3qqwb4P6p07SkQdftS8tW054sKZEepuC/3L2ITNn4YN+bUaP3MjeDF8MeZQMRk9yCn7RxbtuoC5N4FoI6AUJbgUbXqH++CR7+4YvyyxkAC8xHJc= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Community Manager , George Dunlap Subject: RE: [PATCH v3 3/3] CHANGELOG: Start new "unstable" section Thread-Topic: [PATCH v3 3/3] CHANGELOG: Start new "unstable" section Thread-Index: AQHY/mVq8IT3DEtFT02yY9W+7uo6WK5K3NEAgAAIReA= Date: Tue, 22 Nov 2022 13:01:40 +0000 Message-ID: References: <20221122112623.1441905-1-Henry.Wang@arm.com> <20221122112623.1441905-4-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 56467DA2E5F93F4A98CDA2BC8C2FC259.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PR3PR08MB5611:EE_|DBAEUR03FT010:EE_|PAWPR08MB9542:EE_ X-MS-Office365-Filtering-Correlation-Id: 7398c871-a0cc-4b2f-1c0e-08dacc89b758 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: uAeNrbQkABs5Zb0qxmtk3dgVEXbefUbZVduRV+tdOc9RhocvWkG9fFhuD1N89InCd8v6gaqBadXcW/+cgj/BVX1SfI46wbPAm5a9s2du/qs9BWLmYHJUFK2U0NYLi/RBZAoYILEwFtbQsMn94Jomj2+Ws2FG1GMJHZcH3wSQ8jMIDdDRnDGdvE1+90RoFXqEPQp64FK0ZkDFnwSJtbc1hi5IiBzk/ZfD4MBSCj0/mOfi6b63h82bELhtzEGF6RSSiIMxpvOVYM8im2NnmkVLc9J4rokqr/vNlPo4Ew4LVX0vNfKLRx0FgbAFjgraKggZLcZLbCgAzJMP5xDQA2VhxUXYQjD/cJLNajdb78cRpbXsldMXkhj3dbjIISkbvFsgJESrwr7ATr/vvsLfFxSFVTjBwWEj3XZtmE5L64E/mQ5MphWtgtsBkf8lAGIq9MBCGONIhXP3VQC44v4FGtxFahSgroSa51CEeQ73qBI+8ABOV2VmhSsYmTlY4uRtl83/F1v8ooEBP8fXsLIDi1s7LssQHqZztPbnkWOY9+St3p2DyTApBML4n2zS6ILhRB7diVgIlLe9Sr1xVnQ4+QQ814NF3wZMFKbkgVrEz/PKRC6OANcELNYrJiJJ5dvs12+1Xul7jQ2doU8pec7K44EjPTKawTW43PQaozLlhMz28AamwsfPCYj4XG/0ivFDb84Ddq1YZ6Su49/pxefQi7k+F6x0c4h8q0IDIiZS2e6vTYrT3nQYBsJZqLpWXQV0fOC8PCn0VKFy8edB0268i28/ofkjgZ5qFSripU1etjlfT4bu8Q4Y5o7mfDAuEQAUvRKZfQSR4nDE4+0kreJ41yLSX630u9YOIkx+LLMTWX2wEFA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(366004)(136003)(376002)(346002)(451199015)(41300700001)(8936002)(4326008)(316002)(5660300002)(54906003)(76116006)(66556008)(66946007)(66476007)(64756008)(8676002)(66446008)(52536014)(2906002)(478600001)(71200400001)(53546011)(966005)(7696005)(9686003)(6506007)(110136005)(186003)(122000001)(26005)(38100700002)(38070700005)(86362001)(55016003)(33656002)(83380400001)(59356011)(219803003)(207903002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5611 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bdac6304-395b-42b6-826c-08dacc89b265 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L/SLjUC7LA3UVSXmQ1fsFP/wLMV+E/IF4HvLtjB5RbubLM0ex4Ba9RaVLMDw32Q77YuKMcekuGUfTqUPWWNIKTCaXRaAf91RAQt1h8WHai800+r5vAPx1lpbWC+IIU1ZteP0hec55NmC6DzM3/CFIcr2SkfoyhVolnq/lyUOXd32lqtcs477xMfBVEsbvB1ycLXoMBiDqxvad+xs4F6OpPIU1MJtoF6s4zWFLIrMA6JG1Ve7H0eZkes9LCYRRrbcmeajZMsEN1uhpMQAWt83ry3qHJPWVYa4EZad6H3/35K28bup4iFuIHddQYD1iiLs0uxTCrvCL3lGyJA4ZDInJQtuSp5/Rbgnu0Iwsm9NJCQ45AHfBdDJO9ig2OAuON+Rx37M9PGYIuLFsw06OKTKwdV/xfuK7CIkKXuTZYkW19criQ8Mctc3V/6UtoNpCPDdazGfVk2vevt5k/Oc3aLLABGLnWvdogBkfYWVYuucdHhoA+83AwyQtWuYqKgyrJOlwFTH88Sm+LpbBHsftYEC1ESFmrzDGguIV8ZAulvaK4sy1SFTi0XA2HtihU7AMHi1qXJAkRhI2LVckjpFpZhWdu59I14mWrhec94Zkqh7cWINwtnn0C39Zo+CZIVJCUdXG8AJd7RDpuxO6CcSuOC9SB5xwdUDQsfV2aPfpYQhaPwGIRq3+Y9z2U9J0FMeNy6oMRmS5480Ws/wOHE7qVr32dIOTlSAwxy9S29Cb+mhXMERIZQdXpq2Lo8lwkgODVze20qkBpQVBoKeQjWXf8BuLC5+5AH1QGF2eLVKNxx2vtqxTuOISxpZ6/I2ehkflr8eHiIwmY0RmxADm+ZRUSs4T7XsFhIaUzkG7R1D1PPg1zE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(36860700001)(5660300002)(83380400001)(2906002)(82740400003)(86362001)(4326008)(8676002)(110136005)(40460700003)(81166007)(356005)(8936002)(70206006)(41300700001)(40480700001)(52536014)(26005)(7696005)(55016003)(9686003)(53546011)(6506007)(107886003)(47076005)(316002)(186003)(336012)(54906003)(82310400005)(70586007)(478600001)(966005)(33656002)(59356011)(219803003)(207903002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 13:01:48.4937 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7398c871-a0cc-4b2f-1c0e-08dacc89b758 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9542 SGkgSnVsaWVuLA0KDQooK0dlb3JnZSBzaW5jZSB0aGlzIGlzIGFib3V0IHRoZSByZWxlYXNlIGRh dGUpDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVuIEdyYWxs IDxqdWxpZW5AeGVuLm9yZz4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MyAzLzNdIENIQU5HRUxP RzogU3RhcnQgbmV3ICJ1bnN0YWJsZSIgc2VjdGlvbg0KPiBPbiAyMi8xMS8yMDIyIDExOjI2LCBI ZW5yeSBXYW5nIHdyb3RlOg0KPiA+IFNpZ25lZC1vZmYtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5Lldh bmdAYXJtLmNvbT4NCj4gPiAtLS0NCj4gPiB2MiAtPiB2MzoNCj4gPiAtIFRha2UgdGhlIG9wcG9y dHVuaXR5IHRvIGFsc28gYWRqdXN0IHRoZSA0LjE3IGVudHJ5IHNpbmNlIHRoaXMNCj4gPiAgICBw YXRjaCB3aWxsIGJlIGFwcGxpZWQgb25seSBhZnRlciBicmFuY2hpbmcuDQo+IA0KPiBEb2VzIHRo aXMgbWVhbnMgdGhlIGRhdGUgd2lsbCBub3QgYmUgdXBkYXRlZCBpbiB0aGUgQ0hBTkdFTE9HLm1k IGZvciA0LjE3Pw0KDQpBZ2FpbiBzb3JyeSBmb3IgY2F1c2luZyB5b3VyIGNvbmZ1c2lvbi4gQnV0 IGFjdHVhbGx5IEkgYW0gYWxzbyBjb25mdXNlZCBhZnRlcg0KY2hlY2tpbmcgQ0hBTkdFTE9HIGlu IG91ciBwcmV2aW91cyByZWxlYXNlcywgYmVjYXVzZSBub25lIG9mIHRoZW0NCmlzIHByZWNpc2Uu Li4NCg0KU28gaW4gNC4xNiBbMV0sIHRoZSBsaW5rIG9mIHRoZSByZWxlYXNlIHdhcyBub3QgY29y cmVjdCAoSSBiZWxpZXZlIHdlIGZpeGVkIHRoaXMpLA0KaW4gNC4xNSBbMl0sIHRoZSByZWxlYXNl IGRhdGUgd2FzIFRCRCwgYW5kIGluIDQuMTQgWzNdLCB0aGUgNC4xNCBlbnRyeSB3YXMgbm90DQpj cmVhdGVkLiANCg0KVGhpcyBtYWtlcyBtZSBhIGxpdHRsZSBiaXQgY3VyaW91cyBhYm91dCB3aGF0 IHdlIGFyZSBnb2luZyB0byBkbyB0aGlzIHRpbWUsDQphcyB5b3UgYXJlIHRoZSByZWxlYXNlIHRl Y2huaWNpYW4sIHNvIEkgd2lsbCBmb2xsb3cgeW91ciB3b3JraW5nIHN0eWxlLg0KDQpFaXRoZXIg KDEpIFdlIG1ha2UgYSBmaXhlZCBkYXRlIG9mIHJlbGVhc2UgYW5kIGNvbW1pdCB0aGUgdXBkYXRl ZCB2ZXJzaW9uIG9mDQp0aGlzIHBhdGNoIHdpdGggdGhpcyBmaXhlZCBkYXRlIGFuZCByZWxlYXNl IHRhZyBiZWZvcmUgYnJhbmNoaW5nLCB0aGVuIGRvbid0IHRvdWNoDQp0aGUgQ0hBTkdFTE9HIGF0 IGFsbCBhZnRlciwgT3IgKDIpIFdlIGJyYW5jaCBvZmYgbGF0ZXIgdGhpcyBtb250aCBhbmQgdXBk YXRlIHRoZQ0KQ0hBTkdFTE9HIG9uZSBvciB0d28gZGF5cyBiZWZvcmUgdGhlIG9mZmljaWFsIHJl bGVhc2UsIHdvcmtzIGZvciBtZS4NCg0KWzFdIGh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdl Yi8/cD14ZW4uZ2l0O2E9dGFnO2g9cmVmcy90YWdzL1JFTEVBU0UtNC4xNi4wDQpbMl0gaHR0cHM6 Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT10YWc7aD1yZWZzL3RhZ3MvUkVM RUFTRS00LjE1LjANClszXSBodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9eGVuLmdp dDthPXRhZztoPXJlZnMvdGFncy9SRUxFQVNFLTQuMTQuMA0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5y eQ0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Tue Nov 22 13:14:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 13:14:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447170.703098 (Exim 4.92) (envelope-from ) id 1oxT6W-0008Ga-Jk; Tue, 22 Nov 2022 13:14:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447170.703098; Tue, 22 Nov 2022 13:14:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxT6W-0008GT-FU; Tue, 22 Nov 2022 13:14:24 +0000 Received: by outflank-mailman (input) for mailman id 447170; Tue, 22 Nov 2022 13:14:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxT6U-0008G0-Is; Tue, 22 Nov 2022 13:14:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxT6U-0005tW-HH; Tue, 22 Nov 2022 13:14:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxT6U-0001FL-7h; Tue, 22 Nov 2022 13:14:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxT6U-0004G7-7M; Tue, 22 Nov 2022 13:14:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kTjPUBKetjV6eE6qbcsh5Q6gT1mYaUV7ifJjN+HhLyY=; b=cUAn4Mo0qafhTwA3cuZGSO7Epj SGOWTGYX/GlBJNrLsDwKwvOYKI3sc6PCtpE4rjwqzOQh+sZV7b+hV05Tuo4lrF4QK1ZT1QfcULT/8 0yvPv29rWTZ941pygliKBirmIrqNuqUNd7rfk+sornH9TuV8sIU/6yH5dYPTZKxdgAp4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174907: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=2a2d5860435909f5619725a6c29583db90aa789b X-Osstest-Versions-That: libvirt=0b17b1b0a48de6d19404014ff5f0303ab9782028 From: osstest service owner Date: Tue, 22 Nov 2022 13:14:22 +0000 flight 174907 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174907/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174824 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174824 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174824 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 2a2d5860435909f5619725a6c29583db90aa789b baseline version: libvirt 0b17b1b0a48de6d19404014ff5f0303ab9782028 Last test of basis 174824 2022-11-19 04:18:50 Z 3 days Testing same since 174907 2022-11-22 04:20:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiri Denemark Jonathon Jongsma Michal Privoznik Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 0b17b1b0a4..2a2d586043 2a2d5860435909f5619725a6c29583db90aa789b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Nov 22 13:26:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 13:26:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447178.703109 (Exim 4.92) (envelope-from ) id 1oxTIM-0001RC-Lt; Tue, 22 Nov 2022 13:26:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447178.703109; Tue, 22 Nov 2022 13:26:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxTIM-0001R5-JG; Tue, 22 Nov 2022 13:26:38 +0000 Received: by outflank-mailman (input) for mailman id 447178; Tue, 22 Nov 2022 13:26:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxTIK-0001Qv-Lb; Tue, 22 Nov 2022 13:26:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxTIG-00067E-UM; Tue, 22 Nov 2022 13:26:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxTIG-0001Ui-Gt; Tue, 22 Nov 2022 13:26:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxTIG-0008NA-GO; Tue, 22 Nov 2022 13:26:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=T/gthfdJCl8Uif88DmR+UlYvL/TkBhUVcHETBXSIc1A=; b=KHTzNTgLdwetvhp4HA21Ur++Xi T1zxg+OYXUvuZeu5modC42a46souvCwaT6+C+Kaa2pzK8uE74XGYqUHef+olbf+J3K9JY3mWEhkgs PZ6Y3BfJX6Fsr4epDxN15rur5z1bk3kDO9f7SSibv/sLuBVHxKjWU24vdULWRPB2OakA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174903: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-seattle::broken:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:host-install:broken:heisenbug linux-linus:test-arm64-arm64-xl-seattle:host-install(5):broken:heisenbug linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 22 Nov 2022 13:26:32 +0000 flight 174903 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174903/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-seattle broken in 174890 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 Tests which are failing intermittently (not blocking): test-amd64-amd64-examine-bios 5 host-install broken in 174890 pass in 174903 test-arm64-arm64-xl-seattle 5 host-install(5) broken in 174890 pass in 174903 test-amd64-amd64-examine 4 memdisk-try-append fail pass in 174890 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 45 days Failing since 173470 2022-10-08 06:21:34 Z 45 days 81 attempts Testing same since 174871 2022-11-21 00:40:59 Z 1 days 4 attempts ------------------------------------------------------------ 1802 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-arm64-arm64-xl-seattle broken Not pushing. (No revision log; it would be 171425 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Nov 22 13:28:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 13:28:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447183.703120 (Exim 4.92) (envelope-from ) id 1oxTJp-0001yw-17; Tue, 22 Nov 2022 13:28:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447183.703120; Tue, 22 Nov 2022 13:28:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxTJo-0001yp-Ua; Tue, 22 Nov 2022 13:28:08 +0000 Received: by outflank-mailman (input) for mailman id 447183; Tue, 22 Nov 2022 13:28:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxTJm-0001yd-Vl for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 13:28:07 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0622.outbound.protection.outlook.com [2a01:111:f400:fe0c::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7ebb37aa-6a69-11ed-8fd2-01056ac49cbb; Tue, 22 Nov 2022 14:28:05 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6802.eurprd04.prod.outlook.com (2603:10a6:208:184::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Tue, 22 Nov 2022 13:28:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.015; Tue, 22 Nov 2022 13:28:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ebb37aa-6a69-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LCJgOUnRIPHHYPq3eIEDIBF3p7DSVSbm1gbi/z7+vw834FWUOsqTrqx4HDMY8Y/1Is7ObDE7DUzV8d8jD0Dk8CZnZiaYgR6Bf2+z7QebkdplwvgE42p72W61lzasnnRimwKDrNGyCKV2aLi9oU7n7MFYa60HdBPAfS6WJ+xWkrS1etdoGoXztLUtB9x4Vtd9F7VwmZ4JZMxE3IaAZUYIFjbbsq3oUvlhTC1AeBqNvDkta+fttScPPlS5bt663AKoaKWpYMuu3zfgMOYttrGVlWoXMHFQIZAiUb8F2XJGWpeixbYr4rhuZlT1COeO/aeZUTrpfDVRt4A1qoRtWGRujw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uWvDLOpfgzVaSdFEZLQ1GW7kKiQKWRWrLmBLRS2m16Y=; b=NsCMG18RntoDrKL7LpVTIDQz8mXZUDJ9SvqdkClphgGwYhE2+fljx+ipHRP/uG24HBKEZYndT606uvTp0sEy5ACGn5n143P1FFs7ssAZBu+CS7anYc2HNehKzGYCsc5wVL93nVdS7h0YVjjge0cbUcx++35Q7LeV4WSj/Ve9xkXKGNYPJ5M8FJQmeMihFU2ulYpzELSyjDZWpWePdtTkGyennmrVOp3TNJ25VP+FatJiqeFi6++fFDktu8foJ2EtQAwiAjfI+uqohT8xaggDvQRDD0Q2F824p37L56gWLCMJw6sWl4l51uWO8GdnHRWCcK9LdUVgOyAg/ReddM8vuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uWvDLOpfgzVaSdFEZLQ1GW7kKiQKWRWrLmBLRS2m16Y=; b=hLezTGwvNoZKkQFoNOQ+RZIvX2mb1mo79/0D+alywDYwfb9c2p3dZtWqUJpxymZx/hAK74vF6LohK+FX073DxTicxCJq9YyhGIHBgjXJs/Y73fWgbIyFYQtHX/q+pIkcgJXCc4cQ5QxDAhrh3Wf/IX6Ma7PPBd8v/SFv3e0nnXQ9yx01hOKI++ZjNtF41eiEt7BRKgioDlJimCBdMnhGkV2OBq4BZuVqc5KK1D7TugB6Alf4BicAhIbnaAYfM5S5VXJmJYIL7tokcbgb+n4DhYWwXmqCDUJupp9DMqYhs2cJgB0u1aXW5sHddIpuOH0qes91ask2Sl6MCjOMdSaNAA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <29704260-367f-994d-b269-976bded0ea7e@suse.com> Date: Tue, 22 Nov 2022 14:28:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 3/3] CHANGELOG: Start new "unstable" section Content-Language: en-US To: Henry Wang Cc: Community Manager , George Dunlap , Julien Grall , "xen-devel@lists.xenproject.org" References: <20221122112623.1441905-1-Henry.Wang@arm.com> <20221122112623.1441905-4-Henry.Wang@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0132.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6802:EE_ X-MS-Office365-Filtering-Correlation-Id: f342a9a7-96ca-44e3-3995-08dacc8d61c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bqpS4F/trTxBHmmMwJ+gECMIfDgBAGFn1EovjHa27XzfBHq/4GNDfUb+QMdeTSyS1gQUxKDnh6CcMVPQcM+/shgC/C+n8qd1JLtAfyvyqQCnP8+aqK7xz8xCKoVjaaeaj0VIU/2Ehz/r6s1hYIXKkt18jYd+UGvg5rZnzlIS371FY2++hH5kaGwSqlI6wmoiTE+SH1j5GELaWgUKXWv9oTEDl94LOEHNke5Jw518/cu8UnK1UusJoMa8UISdBI+8MNurNla6QeXJA78UbKaVq0vUVxszEh1lle983SuiK+9vFrrSt1jkyxGoIMZkTQr8jRR6JKkB+rExflpcOZ0NOGM04XksdlXUElNVG9tn5KgXaqevij8LXNhN2X5v6d8amcuAbLz88z0gR69fif6/4GY6B72VohbyCBGftchVfccT4y6TbT/4bCKRK5cioXt4m5Px/BhFvj9qY0tOQVc6ltRREh/NGrtQGSyk+QLWaXVS/Ym4MXDOzSHNb8VVmah4r6j9jTYogHCXBVtsFHBrVe9gIgHTdObZtfFLvB7WB5u4rNjMi4SN01vxkMGp+qaWSSD5PPxR1YlsDRnXV8XNkswbt1ZaT8W+r6uCPhaTh9dTBI+z8gDil03/Oh1iszixBsQiPQK8mMrUCofP+ek2jJO3FfCsaE8NHaSscHMXQi7EzKu35baixmDNCFmpsZeoP2mEPbxPjgPgnu9DJuCuXXqOr/iDSbXUCgkuVzpt9zpw+r7lOlCZN3ndEgl9dh6UiSn5Ub6uZqTOe3PMCyUTWRl9ns0DUilmTW+n1/CCyz625RGkFMina4XkacH6fn7X X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(366004)(39860400002)(346002)(136003)(451199015)(31686004)(36756003)(38100700002)(41300700001)(2906002)(83380400001)(86362001)(6916009)(31696002)(4326008)(66556008)(6512007)(186003)(316002)(66946007)(8676002)(54906003)(66476007)(26005)(8936002)(5660300002)(6486002)(2616005)(478600001)(6506007)(53546011)(59356011)(219803003)(207903002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2lwTC96UGZSWFgyd3BzdU9ERjlKdktaU1cyKy9SSnJKRTNubTFKVG5DbTUw?= =?utf-8?B?UHBqRTZOVkxsMTVmc29xTHhTZU9mUHh3cHU0Q2dpRndvTW82NHJ5M1NQU3JL?= =?utf-8?B?endQOHo0NDRmVjdCM0lNK1ZrTGgxZFZnYjlzcDRIQmpya29jOTZYRThKeDg2?= =?utf-8?B?aHdYQnFXUFR2TzhvK0JmbHdrcno0TUVBSFVoTjB4MjMwK0NFZ01SV1VscmQw?= =?utf-8?B?Y2h0QXlCM2pob2dlZHoxZWdVZEZrZkFLZmVxS0VQUFUzaXh6RnVKUzhZbTJJ?= =?utf-8?B?RTBIR3d6NXM4OVIwaXhnNW5oems0NFp3S1pPbUhiRGdzR1h0QzRHeW9qOE02?= =?utf-8?B?dmphbDVYVlQwYTdvUnFwWWJiUGdCcE10VTEyMmUzYXphZmdmaEFqZVNadjJE?= =?utf-8?B?RzVhZDB4a0toOXdlUHlZNTNTYTNSSzN6SXpjbTQ1bzNQSmhUcnFVV01lMzNK?= =?utf-8?B?bnBrY0RucEpPN2QyakZ3SU5DU2FURmJ5bXZUSjdzWjN4ZDBXK3UraTRWQTNO?= =?utf-8?B?T1FzT0xoU1FkT3FPQTBYSkhOZWNNOXdqT3k3V3pYTTJIWjNqN2FxSnhnbi9F?= =?utf-8?B?MEdqRW16RncyT1ZENWxFSnRRd2FGYnpEZ2FVdUxOUTJpcnlBdC9RWmNWV2JM?= =?utf-8?B?OXV1RWtxajNleDU3TWRpYUp1Z2lIZC96cW5pOGM4NGVhNDZ4YkdwdVMwSE5t?= =?utf-8?B?Yzk1bTJSSE5WMzJiWDBiTGtON0Fzc0liOXhhWkZpK0VpbmdMeTZwRWdvQW82?= =?utf-8?B?dUNvYkFCamtGZldjdzJlUWdFK0t1cXppNGh4Zng4NzFuQkdTaWgwUGNKMXVJ?= =?utf-8?B?S21nT08xbmRtaDJBbVluY1B5KzF3UWdpa01JdXZReDFSdEI2WUU4YTRGUEx1?= =?utf-8?B?UVg2RmxGRnJvVk5YN29ZLzljTThoREIvaW9vV0NLVHpENDlmMENXckNNcEwr?= =?utf-8?B?bXFFVS9WUFR2N1pGS21WTlJ3dEJBRG53SlhLcEpqckJSWGEzTDB1M0pmc1FI?= =?utf-8?B?TE1xdWtLQXVLWFUxZmZBdDJGemR1SisvMDRkeTR5U2pMVVBIdVVKYjhlTTRX?= =?utf-8?B?cGdWdWZQMFJjZ1QwY2pNRU02UnFCZU9NMXZtSWpURFBBcTRCV3ZNWmNUZXJF?= =?utf-8?B?NENVMTJkdVdON0hvczY1TFJmMk8yUjBGZGdtYmpRT2U4dEhteHlHaWxsbUEz?= =?utf-8?B?eWtrZk9ycmFLWE9PV05RS2gxSlIxWmFaYkpCM2FVSk9waXZRZE1yVGdJdk1S?= =?utf-8?B?T0tzYVZXcE02aFBlL1RUZjNmSUFyMzBTc2tnT29XTDYvUXdwN3J3T2dwWm5U?= =?utf-8?B?YmNta2w0ZklqOFNxaTJ4bTVHWjBWcis2WnlkMGlYU1RBZDZ2bXphOTluWlpY?= =?utf-8?B?eEZlWTkzaXlVM0syaS9CdzcxN0JKVlJhYUdtZzlzeUwxdFpJcDlZaDYwZ1h5?= =?utf-8?B?MktTWlpPNW5NN01SZC9pbzZ4N3JMUzdSWWhzRnRYRnEzTWF3YmwxSk55ZEJN?= =?utf-8?B?TFh5R016Zm1pRFlpMHh6dlA3dUFuOElXZGxmVmxUbjNHdEZocWVRSzV0WXRO?= =?utf-8?B?Q1VCY3lHWXFvb1F5RXl3a0N1MytENXdONytaRXI1ZDNOWElQOW5OM21xVDdM?= =?utf-8?B?VDBTeTJKSWxGS0ZVVDltRG00VFJIdUdqenAvRzJhRUZGQzZjam5LWml6SmRH?= =?utf-8?B?aDM3OWR3RU9VSGxyVVVXU0E5UnlWcTFFMVpFWEZrb0tCNHJYakJaV3J1N2Yw?= =?utf-8?B?SFFYVHkyRlBTbkJ3RnVWTkswY0RVOEdoRE5Tem1DenhhdW9QdEVIRHJrZk9S?= =?utf-8?B?UTZqWkhDUWFqM3ZIUllvSjBNOG50ak80bHo3NHdpU3NNdnJMTFVvMVB1VVNM?= =?utf-8?B?Sm9yTUs5TWdMR2Z4VXdMUHdZWWtwUG96a0NtNGJCanV3bmpsSnhyN2hFc25C?= =?utf-8?B?SWgrUElnU05oYXNuWlY1b0JBeWFQMzdQMkNnZnQxQTgrT2g0cXFBWVRvUng4?= =?utf-8?B?RmFFeCtlNXNpV1A3TjNDNlZaMzBpT3B0S1dHamNDMm1BTUtYUWRNZlN4anND?= =?utf-8?B?RTA5NldIc2MvR1pSS0wyV0tNYVpIUGNaQ3AycXYvQkJEeVBEQmxTRVlVaE5F?= =?utf-8?Q?NOwPeG7Hbzbi11s21FoWK2M+W?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f342a9a7-96ca-44e3-3995-08dacc8d61c9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 13:28:03.0941 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CBkPTPO4xauHFkO/4dOY3fOLGE2XoaEbK56kb9ZE2Z3NGcFx+NvwKyREFW/aO4Knhz3NTnNlaP3Wc+KOfJ08aA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6802 On 22.11.2022 14:01, Henry Wang wrote: >> -----Original Message----- >> From: Julien Grall >> Subject: Re: [PATCH v3 3/3] CHANGELOG: Start new "unstable" section >> On 22/11/2022 11:26, Henry Wang wrote: >>> Signed-off-by: Henry Wang >>> --- >>> v2 -> v3: >>> - Take the opportunity to also adjust the 4.17 entry since this >>> patch will be applied only after branching. >> >> Does this means the date will not be updated in the CHANGELOG.md for 4.17? > > Again sorry for causing your confusion. But actually I am also confused after > checking CHANGELOG in our previous releases, because none of them > is precise... > > So in 4.16 [1], the link of the release was not correct (I believe we fixed this), > in 4.15 [2], the release date was TBD, and in 4.14 [3], the 4.14 entry was not > created. > > This makes me a little bit curious about what we are going to do this time, > as you are the release technician, so I will follow your working style. > > Either (1) We make a fixed date of release and commit the updated version of > this patch with this fixed date and release tag before branching, then don't touch > the CHANGELOG at all after, Or (2) We branch off later this month and update the > CHANGELOG one or two days before the official release, works for me. Personally I think it should be the latter approach. Who know by how much more we're going to slip ... Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 22 14:11:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 14:11:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447196.703137 (Exim 4.92) (envelope-from ) id 1oxTzB-0007ea-Db; Tue, 22 Nov 2022 14:10:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447196.703137; Tue, 22 Nov 2022 14:10:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxTzB-0007eT-AP; Tue, 22 Nov 2022 14:10:53 +0000 Received: by outflank-mailman (input) for mailman id 447196; Tue, 22 Nov 2022 14:10:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxTzA-0007eJ-Tl; Tue, 22 Nov 2022 14:10:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxTzA-00075c-PO; Tue, 22 Nov 2022 14:10:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxTzA-0002Ul-HQ; Tue, 22 Nov 2022 14:10:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxTzA-0004XO-H1; Tue, 22 Nov 2022 14:10:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BvunWmVhKHTs+y3Z8ZKlWXCuiylD+p094iD6Gi61DM4=; b=zb+rwzeh8++U2WKGrFrt0LXYrB 0qd76WQyHAoo6atgnovnOUIvkqZHnmipvDxUowsiOP96iR/gsdQlsYAql3ZI5R3XDq9/xg3zEeENd umoF4P/Ivn/t2rXYQkG7HDkUKBhwy945z6IdB90l/K7xE89EL+a6GxaC204Zu7zfchms=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174906: trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-pvhv2-amd::broken:regression xen-unstable:test-amd64-amd64-examine-bios:host-install:broken:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64::broken:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:host-install(5):broken:heisenbug xen-unstable:test-amd64-amd64-xl-pvhv2-amd:host-install(5):broken:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=345135942bf9632eba1409ba432cfcae3b7649c7 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Tue, 22 Nov 2022 14:10:52 +0000 flight 174906 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174906/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvhv2-amd broken test-amd64-amd64-examine-bios 5 host-install broken REGR. vs. 174797 test-amd64-i386-xl-qemut-debianhvm-amd64 broken in 174896 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-amd64 5 host-install(5) broken in 174896 pass in 174906 test-amd64-amd64-xl-pvhv2-amd 5 host-install(5) broken pass in 174896 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 174896 pass in 174906 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail pass in 174896 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail in 174896 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 345135942bf9632eba1409ba432cfcae3b7649c7 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 5 days Failing since 174809 2022-11-18 00:06:55 Z 4 days 12 attempts Testing same since 174896 2022-11-21 20:43:42 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Daniel P. Smith Jan Beulich Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd broken test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-pvhv2-amd broken broken-step test-amd64-amd64-xl-pvhv2-amd host-install(5) broken-step test-amd64-amd64-examine-bios host-install broken-job test-amd64-i386-xl-qemut-debianhvm-amd64 broken Not pushing. ------------------------------------------------------------ commit 345135942bf9632eba1409ba432cfcae3b7649c7 Author: Andrew Cooper Date: Mon Nov 21 12:46:39 2022 +0000 xen/flask: Wire up XEN_DOMCTL_{get,set}_paging_mempool_size These were overlooked in the original patch, and noticed by OSSTest which does run some Flask tests. Fixes: 22b20bd98c02 ("xen: Introduce non-broken hypercalls for the paging mempool size") Suggested-by: Daniel Smith Signed-off-by: Andrew Cooper Reviewed-by: Jason Andryuk Acked-by: Daniel P. Smith Release-acked-by: Henry Wang commit 8746d3e2550b142cd751ca7a041a38789a020d2b Author: Andrew Cooper Date: Fri Nov 18 16:53:45 2022 +0000 tools/libxl: Fixes to libxl__domain_set_paging_mempool_size() The error message accidentally printed the bytes value as if it were kB. Furthermore, both b_info.shadow_memkb and shadow_mem are uint64_t, meaning there is a risk of overflow if the user specified a stupidly large value in the vm.cfg file. Check and reject such a condition. Fixes: 7c3bbd940dd8 ("xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls") Signed-off-by: Andrew Cooper Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit 8cdfbf95b19c01fbb741c41d5ea5a94f8823964c Author: Anthony PERARD Date: Mon Nov 21 12:23:01 2022 +0100 libs/light: Propagate libxl__arch_domain_create() return code Commit 34990446ca91 started to overwrite the `rc` value from libxl__arch_domain_create(), thus error aren't propagated anymore. Check `rc` value before doing the next thing. Fixes: 34990446ca91 ("libxl: don't ignore the return value from xc_cpuid_apply_policy") Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD Reviewed-by: Jason Andryuk Release-acked-by: Henry Wang commit 57f07cca82521088cca0c1fc36d6ffd06cb7de80 Author: Roger Pau Monné Date: Mon Nov 21 12:21:51 2022 +0100 efifb: ignore frame buffer with invalid configuration On one of my boxes when the HDMI cable is not plugged in the FrameBufferBase of the EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE structure is set to 0 by the firmware (while some of the other fields looking plausible). Such (bogus address) ends up mapped in vesa_init(), and since it overlaps with a RAM region the whole system goes down pretty badly, see: (XEN) vesafb: framebuffer at 0x0000000000000000, mapped to 0xffff82c000201000, using 35209k, total 35209k (XEN) vesafb: mode is 0x37557x32, linelength=960, font 8x16 (XEN) vesafb: Truecolor: size=8:8:8:8, shift=24:0:8:16 (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) �ERROR: Class:0; Subclass:0; Operation: 0 ERROR: No ConOut ERROR: No ConIn Do like Linux and prevent using the EFI Frame Buffer if the base address is 0. This is inline with the logic in Linuxes fb_base_is_valid() function at drivers/video/fbdev/efifb.c v6.0.9. See also Linux commit 133bb070e94ab41d750c6f2160c8843e46f11b78 for further reference. Also prevent using Frame Buffers that have a 0 height or width, as those are also invalid. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Release-acked-by: Henry Wang commit db8fa01c61db0317a9ee947925226234c65d48e8 Author: Andrew Cooper Date: Thu Oct 20 12:14:30 2022 +0100 xen/arm: Correct the p2m pool size calculations Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit bd87315a603bf25e869e6293f7db7b1024d67999 Author: Andrew Cooper Date: Thu Oct 20 12:13:46 2022 +0100 tools/tests: Unit test for paging mempool size Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit 22b20bd98c025e06525410e3ab3494d5e63489f7 Author: Andrew Cooper Date: Fri Oct 21 14:13:00 2022 +0100 xen: Introduce non-broken hypercalls for the paging mempool size The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 Author: Andrew Cooper Date: Mon Nov 14 21:47:59 2022 +0000 x86/hvm: Revert per-domain APIC acceleration support I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisted in due course. Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Fixes: 6b2b9b340509 ("x86: report Interrupt Controller Virtualization capabilities") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Tue Nov 22 15:10:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 15:10:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447209.703154 (Exim 4.92) (envelope-from ) id 1oxUv3-0005r2-1w; Tue, 22 Nov 2022 15:10:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447209.703154; Tue, 22 Nov 2022 15:10:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxUv2-0005qv-Ud; Tue, 22 Nov 2022 15:10:40 +0000 Received: by outflank-mailman (input) for mailman id 447209; Tue, 22 Nov 2022 15:10:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxUv1-0005ql-Ff; Tue, 22 Nov 2022 15:10:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxUv1-0008O8-BW; Tue, 22 Nov 2022 15:10:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxUv0-0005Jt-VD; Tue, 22 Nov 2022 15:10:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxUv0-0008Qe-Si; Tue, 22 Nov 2022 15:10:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=nWRIFH3lSR546WDaYBBsPXEZpPQhFEqF/3TQCDAiElw=; b=b/6imIKpHJyOcnIbM8GvcFhLB7 4wP0ba7ZPKDTrwsRtoxlYrMlBVVoqB70p9JwFQLJ9Bhj8/XQvo2iKjLNmzMNjuFjXqheX6ET11zzM HEAZYL5LHGgctTVr3tWi3CEqeUC+4qEQd0TiDvMePvVE7253NdFaTClXEC3tldk6B/Lc=; To: xen-devel@lists.xenproject.org Subject: [xen-unstable bisection] complete test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm Message-Id: From: osstest service owner Date: Tue, 22 Nov 2022 15:10:38 +0000 branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm testid debian-hvm-install Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Bug not present: bd87315a603bf25e869e6293f7db7b1024d67999 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174919/ commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm.debian-hvm-install.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable/test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm.debian-hvm-install --summary-out=tmp/174919.bisection-summary --basis-template=174797 --blessings=real,real-bisect,real-retry xen-unstable test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm debian-hvm-install Searching for failure / basis pass: 174881 fail [host=nobling1] / 174797 [host=godello1] 174791 [host=chardonnay0] 174773 [host=elbling1] 174769 [host=italia1] 174762 [host=albana1] 174753 [host=italia0] 174747 [host=nocera1] 174742 [host=debina1] 174733 [host=nobling0] 174724 [host=sabro0] 174701 [host=elbling0] 174682 [host=pinot0] 174670 [host=fiano0] 174663 [host=huxelrebe0] 174652 [host=sabro1] 174641 [host=albana0] 174636 [host=godello0] 174629 [host=debina0] 174607 ok. Failure / basis pass flights: 174881 / 174607 (tree with no url: minios) (tree with no url: ovmf) (tree with no url: seabios) Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Latest 0b17b1b0a48de6d19404014ff5f0303ab9782028 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 Basis pass a607baf65a66491d5bcbca1e3fa4e672a9ec8611 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 2d9b3699136d20e354a94daefebbeefa9ceec7b6 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/libvirt.git#a607baf65a66491d5bcbca1e3fa4e672a9ec8611-0b17b1b0a48de6d19404014ff5f0303ab9782028 https://gitlab.com/keycodemap/keycodemapdb.git#57ba70da5312170883a3d622cd2aa3fd0e2ec7ae-57ba70da5312170883a3d622cd2aa3fd0e2ec7ae git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0\ dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#b746458e1ce1bec85e58b458386f8b7a0bedfaa6-b746458e1ce1bec85e58b458386f8b7a0bedfaa6 git://xenbits.xen.org/xen.git#2d9b3699136d20e354a94daefebbeefa9ceec7b6-db8fa01c61db0317a9ee947925226234c65d48e8 Loaded 10001 nodes in revision graph Searching for test results: 174607 pass a607baf65a66491d5bcbca1e3fa4e672a9ec8611 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 2d9b3699136d20e354a94daefebbeefa9ceec7b6 174629 [host=debina0] 174636 [host=godello0] 174641 [host=albana0] 174652 [host=sabro1] 174663 [host=huxelrebe0] 174670 [host=fiano0] 174682 [host=pinot0] 174701 [host=elbling0] 174724 [host=sabro0] 174733 [host=nobling0] 174742 [host=debina1] 174747 [host=nocera1] 174753 [host=italia0] 174762 [host=albana1] 174769 [host=italia1] 174773 [host=elbling1] 174791 [host=chardonnay0] 174797 [host=godello1] 174814 fail irrelevant 174819 fail irrelevant 174826 fail irrelevant 174843 fail 0b17b1b0a48de6d19404014ff5f0303ab9782028 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174854 fail 0b17b1b0a48de6d19404014ff5f0303ab9782028 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174865 fail 0b17b1b0a48de6d19404014ff5f0303ab9782028 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174874 fail 0b17b1b0a48de6d19404014ff5f0303ab9782028 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174881 fail 0b17b1b0a48de6d19404014ff5f0303ab9782028 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174901 pass a607baf65a66491d5bcbca1e3fa4e672a9ec8611 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 2d9b3699136d20e354a94daefebbeefa9ceec7b6 174902 fail 0b17b1b0a48de6d19404014ff5f0303ab9782028 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174904 pass e864f3b50a3ca57b0ebb33677b94e1da638147d9 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 2b27967fb89d7904a1571a2fb963b1c9cac548db 174905 pass e5d86975857f1ca5431a84c460adc5bd4a260795 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2 174908 pass cd94d891fb4b5cdda229f58b1dee261d5514082b 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 b2030e6730a2b727dbfa7ecc5b9f1deb5f50d3fb 174909 pass d5ae0cd17827e8d2b26b0165a46ab0ebe6d7ce21 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 97abc04e387bb070f9c917269be0ff4e5a813bcf 174910 pass 0e39be85708ccc372b7d9bf81970d27fc42b4cc3 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f5d56f4b253072264efc0fece698a91779e362f5 174911 pass 8f1a8b26c3dcc6e74048ca15f4a55b24cd7f160c 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 22b20bd98c025e06525410e3ab3494d5e63489f7 174912 fail 8f1a8b26c3dcc6e74048ca15f4a55b24cd7f160c 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e 174913 pass 8f1a8b26c3dcc6e74048ca15f4a55b24cd7f160c 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174914 fail 8f1a8b26c3dcc6e74048ca15f4a55b24cd7f160c 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e 174915 pass 8f1a8b26c3dcc6e74048ca15f4a55b24cd7f160c 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174916 fail 8f1a8b26c3dcc6e74048ca15f4a55b24cd7f160c 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e 174917 pass 8f1a8b26c3dcc6e74048ca15f4a55b24cd7f160c 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174919 fail 8f1a8b26c3dcc6e74048ca15f4a55b24cd7f160c 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Searching for interesting versions Result found: flight 174607 (pass), for basis pass For basis failure, parent search stopping at 8f1a8b26c3dcc6e74048ca15f4a55b24cd7f160c 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999, results HASH(0x55fb38067110) HASH(0x55fb380a3418) HASH(0x55fb3808fc70) For basis failure, parent search stopping at 8f1a8b26c3dcc6e74048ca15f4a55b24cd7f160c 57ba70da5\ 312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 22b20bd98c025e06525410e3ab3494d5e63489f7, results HASH(0x55fb375e47e0) For basis failure, parent search stopping at 0e39be85708ccc372b7d9bf81970d27fc42b4cc3 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98\ c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f5d56f4b253072264efc0fece698a91779e362f5, results HASH(0x55fb375dd010) For basis failure, parent search stopping at d5ae0cd17827e8d2b26b0165a46ab0ebe6d7ce21 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 97abc04e387bb070f9c917269be0ff4e5a813bcf, results HASH(0x55fb368492c8) For basis\ failure, parent search stopping at cd94d891fb4b5cdda229f58b1dee261d5514082b 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 b2030e6730a2b727dbfa7ecc5b9f1deb5f50d3fb, results HASH(0x55fb375dc6e0) For basis failure, parent search stopping at e5d86975857f1ca5431a84c460adc5bd4a260795 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b\ 1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 17dfc79ce9fd6cf508ee84a7d0d972d6abe268c2, results HASH(0x55fb3806c348) For basis failure, parent search stopping at e864f3b50a3ca57b0ebb33677b94e1da638147d9 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0be\ dfaa6 2b27967fb89d7904a1571a2fb963b1c9cac548db, results HASH(0x55fb3806c648) For basis failure, parent search stopping at a607baf65a66491d5bcbca1e3fa4e672a9ec8611 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 2d9b3699136d20e354a94daefebbeefa9ceec7b6, results HASH(0x55fb38087f50) HASH(0x55fb3808e568) Result found: flight 174843 (fail), for \ basis failure (at ancestor ~910) Repro found: flight 174901 (pass), for basis pass Repro found: flight 174902 (fail), for basis failure 0 revisions at 8f1a8b26c3dcc6e74048ca15f4a55b24cd7f160c 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 No revisions left to test, checking graph state. Result found: flight 174913 (pass), for last pass Result found: flight 174914 (fail), for first failure Repro found: flight 174915 (pass), for last pass Repro found: flight 174916 (fail), for first failure Repro found: flight 174917 (pass), for last pass Repro found: flight 174919 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Bug not present: bd87315a603bf25e869e6293f7db7b1024d67999 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174919/ commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang pnmtopng: 214 colors found Revision graph left in /home/logs/results/bisect/xen-unstable/test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm.debian-hvm-install.{dot,ps,png,html,svg}. ---------------------------------------- 174919: tolerable FAIL flight 174919 xen-unstable real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/174919/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail baseline untested jobs: build-amd64-libvirt pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Tue Nov 22 15:16:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 15:16:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447215.703165 (Exim 4.92) (envelope-from ) id 1oxV10-0006UO-Nb; Tue, 22 Nov 2022 15:16:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447215.703165; Tue, 22 Nov 2022 15:16:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV10-0006UH-Ks; Tue, 22 Nov 2022 15:16:50 +0000 Received: by outflank-mailman (input) for mailman id 447215; Tue, 22 Nov 2022 15:16:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV0z-0006UB-M3 for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 15:16:49 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20618.outbound.protection.outlook.com [2a01:111:f400:7e88::618]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ae0a864f-6a78-11ed-8fd2-01056ac49cbb; Tue, 22 Nov 2022 16:16:47 +0100 (CET) Received: from BN9PR03CA0382.namprd03.prod.outlook.com (2603:10b6:408:f7::27) by BL1PR12MB5094.namprd12.prod.outlook.com (2603:10b6:208:312::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Tue, 22 Nov 2022 15:16:44 +0000 Received: from BN8NAM11FT082.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f7:cafe::12) by BN9PR03CA0382.outlook.office365.com (2603:10b6:408:f7::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15 via Frontend Transport; Tue, 22 Nov 2022 15:16:44 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT082.mail.protection.outlook.com (10.13.176.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Tue, 22 Nov 2022 15:16:44 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 22 Nov 2022 09:16:39 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 22 Nov 2022 09:16:37 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae0a864f-6a78-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GcLgF+QZ+zMsHWy5mdmowE8w6uT3fDkWYQC9pDNd/j+R+aO6SLWOLuBjaAiHAJR+bCy4WndbSyg6SV/SXscFNGqzlojRXU69zISOgC9PBSmwGxRoVRNYjOCmQM3EDS2w5wBLmeC3e9Jyba2QEmFjntBpV+ZYrwFOqTYYCEl33JER/j+sxqHBp9MGOyQxPy9QuFzp31Axuxaam87VbDxG+E0hrj9flwB2zRHaLgu9jStnZIBI5tls+18IZXL43LiRqneld678jp3G5MC3ryRHQ8Zn01p4QB/cHpxjdtiFgIWEQvjyXPfqzyhTl7H8jBZexe5EGm4MqS3Ic+wToqs2fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ge3y2Uo4Im8rI8BNj4uo4AEBY7/rK0L2lA5DH7qLKXs=; b=Mf5M1KO6SJNiV8yrU0lD3MRbzb1xUzixhYzlgPZxcHJQ3PNKItipz0g85DOzJMrnirGiVNsxv/ORPC0/A1UcWOhfOwSkd1Hjk199xLkaWD1BfT7uCbI1zVnqmtfaUvHRqpsP6Hi82Ak6abNVLs9t/V6CE4S8kfBcGjI+cNQhIkWc/wkYo3eFuLTVfixuFWNS9p3bUMg5j9LDSUDURFOQBmcAIN/lWxiLb+ZeD+WPlN0cH692mhh46IOS8lhCPoaLSsFhMwHf0KHit98k6kCRksn2mlrcLujLxyfJdVfNDmVLFvg0gTEtut0Eo84v/1cVvxr0tOwyM+SO/Hi+onkKGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ge3y2Uo4Im8rI8BNj4uo4AEBY7/rK0L2lA5DH7qLKXs=; b=CX5vp5pt5jH+uVECvZIxw9/TdB5IMYI1QJCc/svVTQdYVL1O82KjBymcs+eEurYrqY2MIfwYY8jM6euTDN9uCFMqdwt2jKa2U+NrFYUQo+adgVQJZ9wKr0vgxOje+S9Ov4+wURzBhrindh4gIEaqm8Xp+0XrSXOnRBlaszCDJD0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <1f0d8171-a56e-a7a2-e5c2-0d8d09ee0a1b@amd.com> Date: Tue, 22 Nov 2022 16:16:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2] xen/arm: vpl011: Make access to DMACR write-ignore Content-Language: en-US To: Julien Grall , Jiamei Xie , CC: , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221122054644.1092173-1-jiamei.xie@arm.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT082:EE_|BL1PR12MB5094:EE_ X-MS-Office365-Filtering-Correlation-Id: 08ca38bb-2c7e-4a9e-2b2a-08dacc9c90dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8TwjO0G7sgi+/IwrQJpL+XbeAWnRV4s84pOiDVY0wfpcL5qeu9N7kem8GHhaVBdZ5xrfC48JKQJ2lFGRhZD+jK+4QPGSYHwyOqZ1l0WjUaEPswIphIpyV6qDTPXWhx4QGvRY1JoBPBFz3S831NZ6IMqeI0Njyo1QMTm40t5NXdvz0CRDKoo/r7tY5dCbDmxQTkZ0rT7/4zhqeAjSzhrGdpgARNXy1OTx5T4Ph5lGGVePL/g8CtNAHGJwzS/t/tfUOaAzaFNexV8PB/Dr158c/eljyTucKuUYNvYzJVVgD34arGFNEHKM76IH4Ci7Mh3mQc4O+uX9rGuywSCmaaztunUd2BaOSTdm04EXX3hnFL2xyf+/yur7ZAzv0BLY6MdvSxbBJC1Ksu3V97qwOsu6T4pbek+s1QboLRPqvS3pvZo+7s1yh17IWx/15JLQulQtrWjkPXaebxVPMyFg5/GsmZRy2t+S7ro+7+m5LDqBsrQhzRZaLqf7x/fNAqHSGompK7t7FZftibwKiiQSM6ptpOM03+kVbxJNR/P7qsxzC5qCHn5pfhiJgZfptza4hrO0frZMqWoMbF0dQtL0Va7pBQpXF7RUocY7FJCLyCHr4muEv7aYWYUblz8kWLNBH+IbAOBtQP/X5CGVYrqd9/KI62yLlojYr8ZgM+NYiH1hySlgn+zeNULFPIUtVP/mmiwfc/93cGHMh8Yrf47f2wjFRHAC5l/m+rnTxHgzBA83ewvCudjq308dA9EfcoBRorObAftooXCIIrmKDFSAKe4WP+/+mS8eLHMy8WaA0HDGu/q0SuxwmKXndlPItVbREmRIVY4zWI8wQFJBCdGgoqKTuw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(346002)(136003)(451199015)(36840700001)(46966006)(40470700004)(426003)(47076005)(2616005)(336012)(356005)(53546011)(83380400001)(82740400003)(40460700003)(81166007)(186003)(36860700001)(40480700001)(2906002)(26005)(44832011)(5660300002)(16576012)(45080400002)(82310400005)(54906003)(966005)(70586007)(8676002)(478600001)(316002)(8936002)(70206006)(41300700001)(4326008)(110136005)(36756003)(86362001)(31696002)(31686004)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 15:16:44.3412 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 08ca38bb-2c7e-4a9e-2b2a-08dacc9c90dd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT082.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5094 Hi, On 22/11/2022 13:25, Julien Grall wrote: > > > Hi, > > On 22/11/2022 05:46, Jiamei Xie wrote: >> When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", >> Linux SBSA PL011 driver will access PL011 DMACR register in some >> functions. As chapter "B Generic UART" in "ARM Server Base System >> Architecture"[1] documentation describes, SBSA UART doesn't support >> DMA. In current code, when the kernel tries to access DMACR register, >> Xen will inject a data abort: >> Unhandled fault at 0xffffffc00944d048 >> Mem abort info: >> ESR = 0x96000000 >> EC = 0x25: DABT (current EL), IL = 32 bits >> SET = 0, FnV = 0 >> EA = 0, S1PTW = 0 >> FSC = 0x00: ttbr address size fault >> Data abort info: >> ISV = 0, ISS = 0x00000000 >> CM = 0, WnR = 0 >> swapper pgtable: 4k pages, 39-bit VAs, pgdp=0000000020e2e000 >> [ffffffc00944d048] pgd=100000003ffff803, p4d=100000003ffff803, pud=100000003ffff803, pmd=100000003fffa803, pte=006800009c090f13 >> Internal error: ttbr address size fault: 96000000 [#1] PREEMPT SMP >> ... >> Call trace: >> pl011_stop_rx+0x70/0x80 >> tty_port_shutdown+0x7c/0xb4 >> tty_port_close+0x60/0xcc >> uart_close+0x34/0x8c >> tty_release+0x144/0x4c0 >> __fput+0x78/0x220 >> ____fput+0x1c/0x30 >> task_work_run+0x88/0xc0 >> do_notify_resume+0x8d0/0x123c >> el0_svc+0xa8/0xc0 >> el0t_64_sync_handler+0xa4/0x130 >> el0t_64_sync+0x1a0/0x1a4 >> Code: b9000083 b901f001 794038a0 8b000042 (b9000041) >> ---[ end trace 83dd93df15c3216f ]--- >> note: bootlogd[132] exited with preempt_count 1 >> /etc/rcS.d/S07bootlogd: line 47: 132 Segmentation fault start-stop-daemon >> >> As discussed in [2], this commit makes the access to DMACR register >> write-ignore as an improvement. > > Didn't we agree to emulate all non-SBSA registers as WI? IOW, the > default case should contain a 'goto write_ignore' rather return 0. + we also agreed on emulating the reads to non spec compliant registers as RAZ. > >> >> [1] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdeveloper.arm.com%2Fdocumentation%2Fden0094%2Fc%2F%3Flang%3Den&data=05%7C01%7Cmichal.orzel%40amd.com%7C1065702b4fd2457cdbf808dacc84b45a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638047167600786580%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=W1dbakw6lkGkv4ydElIi%2Ba7uT7e7Pt5dB3vDtYpP%2FqQ%3D&reserved=0 >> [2] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fxen-devel%2Falpine.DEB.2.22.394.2211161552420.4020%40ubuntu-linux-20-04-desktop%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7C1065702b4fd2457cdbf808dacc84b45a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638047167600786580%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=O4zxuI3HqRA1bdraGcVVY8vV0HGbqOI3nFa%2FciC1cGQ%3D&reserved=0 >> >> Signed-off-by: Jiamei Xie >> --- >> xen/arch/arm/vpl011.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c >> index 43522d48fd..e97fe3ebe7 100644 >> --- a/xen/arch/arm/vpl011.c >> +++ b/xen/arch/arm/vpl011.c >> @@ -463,6 +463,10 @@ static int vpl011_mmio_write(struct vcpu *v, >> case FR: >> case RIS: >> case MIS: >> + case DMACR: >> + printk(XENLOG_G_DEBUG >> + "vpl011: WI on register offset %#08x\n", >> + vpl011_reg); > > IMHO, this message should be printed just after the write_ignore label. > >> goto write_ignore; >> >> case IMSC: > > Cheers, > > -- > Julien Grall > ~Michal From xen-devel-bounces@lists.xenproject.org Tue Nov 22 15:21:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 15:21:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447222.703190 (Exim 4.92) (envelope-from ) id 1oxV55-0008IX-La; Tue, 22 Nov 2022 15:21:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447222.703190; Tue, 22 Nov 2022 15:21:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV55-0008IO-HC; Tue, 22 Nov 2022 15:21:03 +0000 Received: by outflank-mailman (input) for mailman id 447222; Tue, 22 Nov 2022 15:21:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV53-00082v-T5 for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 15:21:02 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 453674ee-6a79-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 16:21:00 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 453674ee-6a79-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669130460; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=U8Mtv4XJ0/V7GDXCKpr+dmKQ2P2iVaWXqmopORRTpv8=; b=XqtljNjkrgSEWkZba8m12/Fm83Jy19xqetAP/d2hZ+P2QnCMgsZ8cHGd 0JhP1v2EeSXR14k+Lkkj26fERMcZdd5FmfrlqO5K+fvvxDl30E4mY8g2j grMjpqOyA3r4O7+sJToMVVzBnoqjekVfZFtZ3QB/2gM2jYWUmIp4FFDTj U=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85763998 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:hTo2yKt7nX/mPVa7uVC3M74eeefnVAReMUV32f8akzHdYApBsoF/q tZmKWqPaf+ON2ChfNklbdzloRkGvZSAn4JjTwBkrSBjQShH+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaEzSFJZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwMm5dcw+EnMiP/rfqZbhuqpk+NJbkBdZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfAdMYH49tL7Aan3XWjtUsl+K44Ew5HDe1ldZ27nxKtvFPNeNQK25m27I+ z2YpDWoUnn2MvTB4yie9Umj1tbhujHDVpgwL+K176Zl1Qj7Kms7V0RNCArTTeOCokK3Rd93M UEf/Ssq668o+ySDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJgOtc/R/6pVwH2Zzk AbUwZW5XlSDrYF5V1qHqOeJsjSpExErKD4tNC0oEBYdvNba9dRbYg30cjpzLEKkpoSrR2Cok 2vT/XlWa6Y71pBSifjilbzTq3f1/8WSEFZojunCdjj9hj6VcrJJcGBBBbLzyf9bZLiUQVCa1 JTvs5jPtbteZX1hecHkfQnsIF1Kz6zfWNEkqQQzd6TNDhz0k5NjFKgJiN2EGG9nM9wfZRjia 1LJtAVa6fd7ZSX0PPcqPtzuUZp0ksAM8OgJsdiNPrJzjmVZLlfbrEmCm2bNt4wSrKTcuf5mY srKGSpdJX0bFb5m3FKLqxQ1iNcWK+FX7T27eK0XODz9jObOPyfME+9t3ZnnRrlR0Z5oaT79q 753X/ZmAT0GOAEiSkE7KbIuEG0= IronPort-HdrOrdr: A9a23:DuguTqnm83TML+DVJOEj+peXo6TpDfIU3DAbv31ZSRFFG/Fxl6 iV8sjzsiWE8Qr5OUtQ/+xoV5PhfZqxz/JICMwqTNKftWrdyQyVxeNZnOjfKlTbckWUnINgPO VbAsxD4bXLfCBHZK3BgTVQfexO/DD+ytHLudvj X-IronPort-AV: E=Sophos;i="5.96,184,1665460800"; d="scan'208";a="85763998" From: Andrew Cooper To: Xen-devel CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Andrew Cooper" , Christian Lindig , David Scott , Rob Hoes Subject: [PATCH 4/8] tools/ocaml/evtchn: Extend the init() binding with a cloexec flag Date: Tue, 22 Nov 2022 15:20:39 +0000 Message-ID: <20221122152043.8518-5-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221122152043.8518-1-andrew.cooper3@citrix.com> References: <20221122152043.8518-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Edwin Török For live update, oxenstored wants to clear CLOEXEC on the evtchn handle, so it survives the execve() into the new oxenstored. Have the new interface match how cloexec works in other Ocaml standard libraries. Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper Acked-by: Christian Lindig --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes Split out of combined patch --- tools/ocaml/libs/eventchn/xeneventchn.ml | 5 ++++- tools/ocaml/libs/eventchn/xeneventchn.mli | 9 ++++++--- tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 10 +++++++--- 3 files changed, 17 insertions(+), 7 deletions(-) diff --git a/tools/ocaml/libs/eventchn/xeneventchn.ml b/tools/ocaml/libs/eventchn/xeneventchn.ml index be4de82f46b9..c16fdd4674f7 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn.ml +++ b/tools/ocaml/libs/eventchn/xeneventchn.ml @@ -16,7 +16,10 @@ type handle -external init: unit -> handle = "stub_eventchn_init" +external _init: bool -> handle = "stub_eventchn_init" + +let init ?(cloexec=true) () = _init cloexec + external fdopen: Unix.file_descr -> handle = "stub_eventchn_fdopen" external fd: handle -> Unix.file_descr = "stub_eventchn_fd" diff --git a/tools/ocaml/libs/eventchn/xeneventchn.mli b/tools/ocaml/libs/eventchn/xeneventchn.mli index 98b3c86f3702..870429b6b53a 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn.mli +++ b/tools/ocaml/libs/eventchn/xeneventchn.mli @@ -43,9 +43,12 @@ val to_int: t -> int val of_int: int -> t -val init: unit -> handle -(** Return an initialised event channel interface. On error it - will throw a Failure exception. *) +val init: ?cloexec:bool -> unit -> handle +(** [init ?cloexec ()] + Return an initialised event channel interface. + The default is to close the underlying file descriptor + on [execve], which can be overriden with [~cloexec:false]. + On error it will throw a Failure exception. *) val fdopen: Unix.file_descr -> handle (** Return an initialised event channel interface, from an already open evtchn diff --git a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c index 7bdf711bc150..aa8a69cc1ecb 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c +++ b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c @@ -50,14 +50,18 @@ static struct custom_operations xenevtchn_ops = { .compare_ext = custom_compare_ext_default, /* Can't compare */ }; -CAMLprim value stub_eventchn_init(void) +CAMLprim value stub_eventchn_init(value cloexec) { - CAMLparam0(); + CAMLparam1(cloexec); CAMLlocal1(result); xenevtchn_handle *xce; + unsigned int flags = 0; + + if ( !Bool_val(cloexec) ) + flags |= XENEVTCHN_NO_CLOEXEC; caml_enter_blocking_section(); - xce = xenevtchn_open(NULL, 0); + xce = xenevtchn_open(NULL, flags); caml_leave_blocking_section(); if (xce == NULL) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 15:21:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 15:21:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447221.703178 (Exim 4.92) (envelope-from ) id 1oxV54-00083F-C9; Tue, 22 Nov 2022 15:21:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447221.703178; Tue, 22 Nov 2022 15:21:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV54-000838-9Q; Tue, 22 Nov 2022 15:21:02 +0000 Received: by outflank-mailman (input) for mailman id 447221; Tue, 22 Nov 2022 15:21:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV52-00082v-QP for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 15:21:00 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 42fb11d6-6a79-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 16:20:58 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42fb11d6-6a79-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669130458; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1BYJug4YTOsoAI8ImSgHkkpV3S64Z2EdA3k2jZuilTM=; b=H2bLllQTlb4Rdou4xjz4HBpRYkzsLP9S1/L7bOJmr2bIf4XrkWwsKjq9 eoVkoH/W0c3W08DuLm+hiwWP7kbAdpJskQ1jlEl7gEbxK138Sg5gvAQlB syaBHSUC9KweU5moHXSaAuB5hO8hZtFob/dPOOAijvoxw2LXS4ck2BNiC Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85763990 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:xhKYfqlZGOeppPb1VSwL6bno5gzTJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIdCD+BbK2NYzD8LdAiPInl8UoFvJXWztAwS1Bkrig1QSMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5gWGyxH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 d88BxY9MxOOvuSv5qm0V8p13cU5MNa+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsfYT/7C7pn9AusrlD5fydVtxS+oq0v7nKI5AdwzKLsIJzefdniqcB9zhvH+ DmXrjyR7hcyEtuOyGCm/SKXoKzkwjnBYK89Nv6Bz6s/6LGU7jNKU0BHPbehmtG1g1Czc8hSI EsV/mwpt6da3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQA5oiVpMYJ88pVsHHpzi wHPz4iB6SFTXKO9alay0IfJrj6LPzEzNmAfRjZfTBEZ/Iy2yG0stS4jXuqPAYbs0IOkQWGrm mHbxMQtr+5N1JBWjs1X6XiC2mvx/caRE2bZ8y2NBgqYAhVFiJlJjmBCwXzS9r5+IYmQVTFtV 1BUypHFvIji4Xxg/RFhodnh/5nzvZ5pyBWG3TZS82AJrlxAOxeLJOi8Gg1WKkZzKdojcjT0e kLVsg45zMYNYiryMPIpPNjvVZtCIU3c+TPND6C8UzazSsIpKF/vEN9GOCZ8IFwBYGBzyPpia P93gO6nDGoACLQP8dZFb7517FLqrwhgrV7uqWfTlUn7geHHPSTNIVrHWXPXBt0EAGq/iF292 75i2wGikX2zjMWWjvHrzLMu IronPort-HdrOrdr: A9a23:Oa0BY6kf0R2FyhxsXLoZZDJhUbPpDfIq3DAbv31ZSRFFG/Fxl6 iV88jzsiWE7gr5OUtQ/uxoV5PgfZqxz/NICMwqTNWftWrdyQ+VxeNZjbcKqgeIc0aVygce79 YET0EXMqyIMbEQt6jHCWeDf+rIuOP3k5yVuQ== X-IronPort-AV: E=Sophos;i="5.96,184,1665460800"; d="scan'208";a="85763990" From: Andrew Cooper To: Xen-devel CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Andrew Cooper , Christian Lindig , David Scott , Rob Hoes Subject: [PATCH 2/8] tools/ocaml/evtchn: OCaml 5 support, fix potential resource leak Date: Tue, 22 Nov 2022 15:20:37 +0000 Message-ID: <20221122152043.8518-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221122152043.8518-1-andrew.cooper3@citrix.com> References: <20221122152043.8518-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Edwin Török There is no binding for xenevtchn_close(). In principle, this is a resource leak, but the typical usage is as a singleton that lives for the lifetime of the program. Ocaml 5 no longer permits storing a naked C pointer in an Ocaml value. Therefore, use a Custom block. This allows us to use the finaliser callback to call xenevtchn_close(), if the Ocaml object goes out of scope. Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper Acked-by: Christian Lindig --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes --- tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c index f889a7a2e4a1..37f1cc4e1478 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c +++ b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c @@ -33,7 +33,22 @@ #include #include -#define _H(__h) ((xenevtchn_handle *)(__h)) +#define _H(__h) (*((xenevtchn_handle **)Data_custom_val(__h))) + +static void stub_evtchn_finalize(value v) +{ + xenevtchn_close(_H(v)); +} + +static struct custom_operations xenevtchn_ops = { + .identifier = "xenevtchn", + .finalize = stub_evtchn_finalize, + .compare = custom_compare_default, /* Can't compare */ + .hash = custom_hash_default, /* Can't hash */ + .serialize = custom_serialize_default, /* Can't serialize */ + .deserialize = custom_deserialize_default, /* Can't deserialize */ + .compare_ext = custom_compare_ext_default, /* Can't compare */ +}; CAMLprim value stub_eventchn_init(void) { @@ -48,7 +63,9 @@ CAMLprim value stub_eventchn_init(void) if (xce == NULL) caml_failwith("open failed"); - result = (value)xce; + result = caml_alloc_custom(&xenevtchn_ops, sizeof(xce), 0, 1); + _H(result) = xce; + CAMLreturn(result); } -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 15:21:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 15:21:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447223.703201 (Exim 4.92) (envelope-from ) id 1oxV57-00008E-SP; Tue, 22 Nov 2022 15:21:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447223.703201; Tue, 22 Nov 2022 15:21:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV57-000082-Ph; Tue, 22 Nov 2022 15:21:05 +0000 Received: by outflank-mailman (input) for mailman id 447223; Tue, 22 Nov 2022 15:21:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV56-00082v-PN for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 15:21:04 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46e43b0a-6a79-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 16:21:03 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46e43b0a-6a79-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669130463; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6E4HgUtQnG7TB7MNmlWax1xF4tEg2WobhRgUJRbXoKQ=; b=U2Rn5APIPiuwBCJiWQcdJ0UjhuEb8UJAUIisoPRaiN6JTQT31ktj7Vwz 3CUA2goMCvgneFuXxMdpq0Km2umO96z+T4N9UgYOoLsNrNPwpylGtUFsg 2xCiTGTb2H/Vvu0JhbP9sovkZPj3NVbyVbKYH4GA0f6QtzaphrYkxbxfv 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85764000 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:HQRBuKs4bJThSIADhW0/O2NsY+fnVAReMUV32f8akzHdYApBsoF/q tZmKW7SPvqOZDD0fo0ibti3p0pU6sPczIc3TgVoryxgFS0Q+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaEzSFJZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwcBtQRAuupemM5Z2RZftghtQ6FdS3BdZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfAdMYH49tL7Aan3XWjtUsl+K44Ew5HDe1ldZ27nxKtvFPNeNQK25m27I+ z2YozyhWnn2MvS/7hne0VGjmdPivnymAqVCRL3p7KRD1Qj7Kms7V0RNCArTTeOCokK3Rd93M UEf/Ssq668o+ySDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJgOtc/R/6pVwH2Zzk AbUwZW5XlSDrYF5V1rF3eq+th6QMhIwAkUtdyMEXRI8/oXa9dRbYg30cjpzLEKkpoSrR2Cok 2vT/XlWa6Y71pBSifjilbzTq3f1/8WSEFZojunCdjj9hj6VcrJJcGBBBbLzyf9bZLiUQVCa1 JTvs5jPtbteZX1hecHkfQnsIF1Kz6zfWNEkqQQzd6TNDhz0k5NjFKgJiN2EGG9nM9wfZRjia 1LJtAVa6fd7ZSX0PPcqPtzuUZp0ksAM8OgJsdiNPrJzjmVZLlfbrEmCm2bNt4wSrKTcuf5mY srKGSpdJX0bFb5m3FKLqxQ1iNcWK+FX7T27eK0XODz9jObOPyfME+9t3ZnnRrlR0Z5oaT79q 753X/ZmAT0FOAEiSkE7KbIuEG0= IronPort-HdrOrdr: A9a23:0z8GkanO82M7V452K5Cr/YkwRrDpDfIq3DAbv31ZSRFFG/Fxl6 iV88jzsiWE7gr5OUtQ/uxoV5PgfZqxz/NICMwqTNWftWrdyQ+VxeNZjbcKqgeIc0aVygce79 YET0EXMqyIMbEQt6jHCWeDf+rIuOP3k5yVuQ== X-IronPort-AV: E=Sophos;i="5.96,184,1665460800"; d="scan'208";a="85764000" From: Andrew Cooper To: Xen-devel CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Rob Hoes Subject: [PATCH 6/8] tools/oxenstored: Log live update issues at warning level Date: Tue, 22 Nov 2022 15:20:41 +0000 Message-ID: <20221122152043.8518-7-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221122152043.8518-1-andrew.cooper3@citrix.com> References: <20221122152043.8518-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Edwin Török During live update, oxenstored tries a best effort approach to recover as many domains and information as possible even if it encounters errors restoring some domains. However, logging about misunderstood input is more severe than simply info. Log it at warning instead. Signed-off-by: Edwin Török Acked-by: Christian Lindig --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes --- tools/ocaml/xenstored/xenstored.ml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml index 6ceab02dee1e..23621bd49397 100644 --- a/tools/ocaml/xenstored/xenstored.ml +++ b/tools/ocaml/xenstored/xenstored.ml @@ -184,9 +184,9 @@ let from_channel_f chan global_f event_f socket_f domain_f watch_f store_f = (Perms.Node.of_string (unhexify perms ^ "\000")) (unhexify value) | _ -> - info "restoring: ignoring unknown line: %s" line + warn "restoring: ignoring unknown line: %s" line with exn -> - info "restoring: ignoring unknown line: %s (exception: %s)" + warn "restoring: ignoring unknown line: %s (exception: %s)" line (Printexc.to_string exn); () with End_of_file -> -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 15:21:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 15:21:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447224.703212 (Exim 4.92) (envelope-from ) id 1oxV5B-0000SP-4Y; Tue, 22 Nov 2022 15:21:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447224.703212; Tue, 22 Nov 2022 15:21:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV5B-0000SG-16; Tue, 22 Nov 2022 15:21:09 +0000 Received: by outflank-mailman (input) for mailman id 447224; Tue, 22 Nov 2022 15:21:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV59-0000Pt-OP for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 15:21:07 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46312c9c-6a79-11ed-8fd2-01056ac49cbb; Tue, 22 Nov 2022 16:21:04 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46312c9c-6a79-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669130464; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qRpT/sJXRqdzl+PXZvGGiTY+yIv7oFMfzWqn89Zz508=; b=CyftZprALvnpFOmmnF704TeXelRtISqcHVQ5rryv8cQtuPS0dDBrTQHE jnp/agjxzN01v5mOcp/EG9EErPGqOaGZ3ejaWl7q8JlVjh233HCm+s6m3 Iqb6tiFu0r3Pw3WMknrDOABDBgmeE8Dr0wHse/3V7RdqjYXHIQD7ungTV A=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85360546 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:mqhl76D7YM3BDxVW/3vjw5YqxClBgxIJ4kV8jS/XYbTApDIk1jcCy GUbCmjQbviNZWSke492Ptuy80IE6pGAxoUwQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpC5ARiDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw/NgsEGB8t tAjMC0iP0qmtfidwonmY7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/IZQyhuq3wFL4dCVVsgm9rqsr+WnDigd21dABNfKFJ4fUHZgJwC50o Erh+GvBIRckF+eV8mC43SuHje6fniTkDdd6+LqQqacx3Qz7KnYoIBEfS1aTu/SyjU+6HdVFJ CQ86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCopc4+C7AWDJCFGQYLoV76olmHlTGy 2NlgfvvO2d+sY/WZUmF65jF9xaAIwMXFjIrMHpsoRQ+3zXznG0ipkuREIc7QPXs34yd9SLYm G7T8nVn71kHpYtSjvjgowia6965jsKRJjPZ8Dk7SY5MAulRQIe+L7Kl5lHAhRqrBNbIFwLR1 JTodiX30QzvMX1uvHbXKAn1NOv1j8tpyRWF6bOvdrF4n9hXx1atfJpL/BZ1L1pzP8APdFfBO RGN6FsMucEMZiX0Msebhr5d7OxzncDd+SnNDKiIPrKinLAsHON4wM2eTRHJhD28+KTduao+J Y2aYa6R4YUyUMxaIfvfb7l17ILHMQhkmD+DHsmilUzPPHj3TCf9dIrp+WCmNogRhJ5oai2Pm zqDH6NmEylibdA= IronPort-HdrOrdr: A9a23:KzUus6F2ub7Cup9ipLqE7seALOsnbusQ8zAXP0AYc3Nom6uj5q aTdZUgpHjJYVkqOU3I9ersBEDEewK/yXcX2/h0AV7BZmnbUQKTRekIh7cKgQeQfhEWntQtrJ uIGJIRNDSfNzRHZL7BkWqFL+o= X-IronPort-AV: E=Sophos;i="5.96,184,1665460800"; d="scan'208";a="85360546" From: Andrew Cooper To: Xen-devel CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Andrew Cooper , Christian Lindig , David Scott , Rob Hoes Subject: [PATCH 5/8] tools/oxenstored: Keep /dev/xen/evtchn open across live update Date: Tue, 22 Nov 2022 15:20:40 +0000 Message-ID: <20221122152043.8518-6-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221122152043.8518-1-andrew.cooper3@citrix.com> References: <20221122152043.8518-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Edwin Török Closing the evtchn handle will unbind and free all local ports. The new xenstored would need to rebind all evtchns, which is work that we don't want or need to be doing during the critical handover period. However, it turns out that the Windows PV drivers also rebind their local port too across suspend/resume, leaving (o)xenstored with a stale idea of the remote port to use. In this case, reusing the established connection is the only robust option. Therefore: * Have oxenstored open /dev/xen/evtchn without CLOEXEC at start of day * Extend the handover information with the evtchn fd, and the local port number for each domain connection. * Have (the new) oxenstored recover the open handle using Xeneventchn.fdopen, and use the provided local ports rather than trying to rebind them. When this new information isn't present (i.e. live updating from an oxenstored prior to this change), the best-effort status quo will have to do. Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes Merge two patches to retain bisectability. Drop changes to the evtchn bindings. --- tools/ocaml/xenstored/domain.ml | 6 ++- tools/ocaml/xenstored/domains.ml | 14 +++++-- tools/ocaml/xenstored/event.ml | 8 +++- tools/ocaml/xenstored/xenstored.ml | 82 ++++++++++++++++++++++++++------------ 4 files changed, 78 insertions(+), 32 deletions(-) diff --git a/tools/ocaml/xenstored/domain.ml b/tools/ocaml/xenstored/domain.ml index 81cb59b8f1a2..527035ffdd32 100644 --- a/tools/ocaml/xenstored/domain.ml +++ b/tools/ocaml/xenstored/domain.ml @@ -61,7 +61,7 @@ let string_of_port = function | Some x -> string_of_int (Xeneventchn.to_int x) let dump d chan = - fprintf chan "dom,%d,%nd,%d\n" d.id d.mfn d.remote_port + fprintf chan "dom,%d,%nd,%d,%s\n" d.id d.mfn d.remote_port (string_of_port d.port) let notify dom = match dom.port with | None -> @@ -77,6 +77,10 @@ let bind_interdomain dom = dom.port <- Some (Event.bind_interdomain dom.eventchn dom.id dom.remote_port); debug "bound domain %d remote port %d to local port %s" dom.id dom.remote_port (string_of_port dom.port) +let restore_interdomain dom localport = + assert (dom.port = None); + dom.port <- Some (Xeneventchn.of_int localport); + debug "restored interdomain %d remote port %d to local port %s" dom.id dom.remote_port (string_of_port dom.port) let close dom = debug "domain %d unbound port %s" dom.id (string_of_port dom.port); diff --git a/tools/ocaml/xenstored/domains.ml b/tools/ocaml/xenstored/domains.ml index 17fe2fa25772..a91d2afd2a82 100644 --- a/tools/ocaml/xenstored/domains.ml +++ b/tools/ocaml/xenstored/domains.ml @@ -56,6 +56,7 @@ let exist doms id = Hashtbl.mem doms.table id let find doms id = Hashtbl.find doms.table id let number doms = Hashtbl.length doms.table let iter doms fct = Hashtbl.iter (fun _ b -> fct b) doms.table +let eventchn doms = doms.eventchn let rec is_empty_queue q = Queue.is_empty q || @@ -122,17 +123,22 @@ let cleanup doms = let resume _doms _domid = () -let create doms domid mfn port = +let maybe_bind_interdomain restore_localport dom = + match restore_localport with + | None -> Domain.bind_interdomain dom + | Some p -> Domain.restore_interdomain dom p + +let create doms domid mfn ?restore_localport port = let interface = Xenctrl.map_foreign_range xc domid (Xenmmap.getpagesize()) mfn in let dom = Domain.make domid mfn port interface doms.eventchn in Hashtbl.add doms.table domid dom; - Domain.bind_interdomain dom; + maybe_bind_interdomain restore_localport dom; dom let xenstored_kva = ref "" let xenstored_port = ref "" -let create0 doms = +let create0 ?restore_localport doms = let port, interface = ( let port = Utils.read_file_single_integer !xenstored_port @@ -146,7 +152,7 @@ let create0 doms = in let dom = Domain.make 0 Nativeint.zero port interface doms.eventchn in Hashtbl.add doms.table 0 dom; - Domain.bind_interdomain dom; + maybe_bind_interdomain restore_localport dom; Domain.notify dom; dom diff --git a/tools/ocaml/xenstored/event.ml b/tools/ocaml/xenstored/event.ml index ccca90b6fc4f..0159daac91f4 100644 --- a/tools/ocaml/xenstored/event.ml +++ b/tools/ocaml/xenstored/event.ml @@ -20,7 +20,13 @@ type t = { mutable virq_port: Xeneventchn.t option; } -let init () = { handle = Xeneventchn.init (); virq_port = None; } +let init ?fd () = + let handle = match fd with + | None -> Xeneventchn.init ~cloexec:false () + | Some fd -> Xeneventchn.fdopen fd + in + { handle; virq_port = None } + let fd eventchn = Xeneventchn.fd eventchn.handle let bind_dom_exc_virq eventchn = eventchn.virq_port <- Some (Xeneventchn.bind_dom_exc_virq eventchn.handle) let bind_interdomain eventchn domid port = Xeneventchn.bind_interdomain eventchn.handle domid port diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml index c5dc7a28d082..6ceab02dee1e 100644 --- a/tools/ocaml/xenstored/xenstored.ml +++ b/tools/ocaml/xenstored/xenstored.ml @@ -144,7 +144,7 @@ exception Bad_format of string let dump_format_header = "$xenstored-dump-format" -let from_channel_f chan global_f socket_f domain_f watch_f store_f = +let from_channel_f chan global_f event_f socket_f domain_f watch_f store_f = let unhexify s = Utils.unhexify s in let getpath s = let u = Utils.unhexify s in @@ -165,12 +165,17 @@ let from_channel_f chan global_f socket_f domain_f watch_f store_f = (* there might be more parameters here, e.g. a RO socket from a previous version: ignore it *) global_f ~rw + | "eventfd" :: eventfd :: [] -> + event_f ~eventfd | "socket" :: fd :: [] -> socket_f ~fd:(int_of_string fd) - | "dom" :: domid :: mfn :: port :: []-> + | "dom" :: domid :: mfn :: port :: rest -> domain_f (int_of_string domid) (Nativeint.of_string mfn) (int_of_string port) + (match rest with + | [] -> None (* backward compat: old version didn't have it *) + | localport :: _ -> Some (int_of_string localport)) | "watch" :: domid :: path :: token :: [] -> watch_f (int_of_string domid) (unhexify path) (unhexify token) @@ -189,10 +194,27 @@ let from_channel_f chan global_f socket_f domain_f watch_f store_f = done; info "Completed loading xenstore dump" -let from_channel store cons doms chan = +let from_channel store cons createdoms chan = (* don't let the permission get on our way, full perm ! *) let op = Store.get_ops store Perms.Connection.full_rights in let rwro = ref (None) in + let eventchnfd = ref (None) in + let doms = ref (None) in + + let require_doms () = + match !doms with + | None -> + let missing_eventchnfd = !eventchnfd = None in + if missing_eventchnfd then + warn "No event channel file descriptor available in dump!"; + let eventchn = Event.init ?fd:!eventchnfd () in + let domains = createdoms eventchn in + if missing_eventchnfd then + Event.bind_dom_exc_virq eventchn; + doms := Some domains; + domains + | Some d -> d + in let global_f ~rw = let get_listen_sock sockfd = let fd = sockfd |> int_of_string |> Utils.FD.of_int in @@ -201,6 +223,10 @@ let from_channel store cons doms chan = in rwro := get_listen_sock rw in + let event_f ~eventfd = + let fd = eventfd |> int_of_string |> Utils.FD.of_int in + eventchnfd := Some fd + in let socket_f ~fd = let ufd = Utils.FD.of_int fd in let is_valid = try (Unix.fstat ufd).Unix.st_kind = Unix.S_SOCK with _ -> false in @@ -209,12 +235,13 @@ let from_channel store cons doms chan = else warn "Ignoring invalid socket FD %d" fd in - let domain_f domid mfn port = + let domain_f domid mfn port restore_localport = + let doms = require_doms () in let ndom = if domid > 0 then - Domains.create doms domid mfn port + Domains.create doms domid mfn ?restore_localport port else - Domains.create0 doms + Domains.create0 ?restore_localport doms in Connections.add_domain cons ndom; in @@ -229,8 +256,8 @@ let from_channel store cons doms chan = op.Store.write path value; op.Store.setperms path perms in - from_channel_f chan global_f socket_f domain_f watch_f store_f; - !rwro + from_channel_f chan global_f event_f socket_f domain_f watch_f store_f; + !rwro, require_doms () let from_file store cons doms file = info "Loading xenstore dump from %s" file; @@ -238,7 +265,7 @@ let from_file store cons doms file = finally (fun () -> from_channel store doms cons channel) (fun () -> close_in channel) -let to_channel store cons rw chan = +let to_channel store cons (rw, eventchn) chan = let hexify s = Utils.hexify s in fprintf chan "%s\n" dump_format_header; @@ -247,6 +274,7 @@ let to_channel store cons rw chan = Unix.clear_close_on_exec fd; Utils.FD.to_int fd in fprintf chan "global,%d\n" (fdopt rw); + fprintf chan "eventchnfd,%d\n" (Utils.FD.to_int @@ Event.fd eventchn); (* dump connections related to domains: domid, mfn, eventchn port/ sockets, and watches *) Connections.iter cons (fun con -> Connection.dump con chan); @@ -367,7 +395,6 @@ let _ = | None -> () end; let store = Store.create () in - let eventchn = Event.init () in let next_frequent_ops = ref 0. in let advance_next_frequent_ops () = next_frequent_ops := (Unix.gettimeofday () +. !Define.conflict_max_history_seconds) @@ -375,16 +402,8 @@ let _ = let delay_next_frequent_ops_by duration = next_frequent_ops := !next_frequent_ops +. duration in - let domains = Domains.init eventchn advance_next_frequent_ops in + let domains eventchn = Domains.init eventchn advance_next_frequent_ops in - (* For things that need to be done periodically but more often - * than the periodic_ops function *) - let frequent_ops () = - if Unix.gettimeofday () > !next_frequent_ops then ( - History.trim (); - Domains.incr_conflict_credit domains; - advance_next_frequent_ops () - ) in let cons = Connections.create () in let quit = ref false in @@ -393,15 +412,15 @@ let _ = List.iter (fun path -> Store.write store Perms.Connection.full_rights path "") Store.Path.specials; - let rw_sock = + let rw_sock, domains = if cf.restart && Sys.file_exists Disk.xs_daemon_database then ( - let rwro = DB.from_file store domains cons Disk.xs_daemon_database in + let rw, domains = DB.from_file store domains cons Disk.xs_daemon_database in info "Live reload: database loaded"; - Event.bind_dom_exc_virq eventchn; Process.LiveUpdate.completed (); - rwro + rw, domains ) else ( info "No live reload: regular startup"; + let domains = domains @@ Event.init () in if !Disk.enable then ( info "reading store from disk"; Disk.read store @@ -411,13 +430,23 @@ let _ = if not (Store.path_exists store localpath) then Store.mkdir store (Perms.Connection.create 0) localpath; + let eventchn = Event.init () in if cf.domain_init then ( Connections.add_domain cons (Domains.create0 domains); Event.bind_dom_exc_virq eventchn ); - rw_sock + rw_sock, domains ) in + (* For things that need to be done periodically but more often + * than the periodic_ops function *) + let frequent_ops () = + if Unix.gettimeofday () > !next_frequent_ops then ( + History.trim (); + Domains.incr_conflict_credit domains; + advance_next_frequent_ops () + ) in + (* required for xenstore-control to detect availability of live-update *) let tool_path = Store.Path.of_string "/tool" in if not (Store.path_exists store tool_path) then @@ -433,10 +462,11 @@ let _ = Sys.set_signal Sys.sigpipe Sys.Signal_ignore; if cf.activate_access_log then begin - let post_rotate () = DB.to_file store cons (None) Disk.xs_daemon_database in + let post_rotate () = DB.to_file store cons (None, Domains.eventchn domains) Disk.xs_daemon_database in Logging.init_access_log post_rotate end; + let eventchn = Domains.eventchn domains in let spec_fds = (match rw_sock with None -> [] | Some x -> [ x ]) @ (if cf.domain_init then [ Event.fd eventchn ] else []) @@ -595,7 +625,7 @@ let _ = live_update := Process.LiveUpdate.should_run cons; if !live_update || !quit then begin (* don't initiate live update if saving state fails *) - DB.to_file store cons (rw_sock) Disk.xs_daemon_database; + DB.to_file store cons (rw_sock, eventchn) Disk.xs_daemon_database; quit := true; end with exc -> -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 15:21:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 15:21:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447225.703223 (Exim 4.92) (envelope-from ) id 1oxV5C-0000k9-Jc; Tue, 22 Nov 2022 15:21:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447225.703223; Tue, 22 Nov 2022 15:21:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV5C-0000jq-Gb; Tue, 22 Nov 2022 15:21:10 +0000 Received: by outflank-mailman (input) for mailman id 447225; Tue, 22 Nov 2022 15:21:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV5A-0000Pt-HL for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 15:21:08 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47ec3dae-6a79-11ed-8fd2-01056ac49cbb; Tue, 22 Nov 2022 16:21:06 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47ec3dae-6a79-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669130466; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=alWsFEiT/W2vR+rSP2qESkFw75Vrqo0QEbh3ZtJ0hE4=; b=O0Clf8tI+2zo2sFTict72Q6P0A6uAiLP5BvrabDriYq0lyPgbly+hRrv BN3tOKRgve5PnP5Repa+bAM+VvHYjTwKue9YeT+Mr4x3oMJ1DXu6s7uYO Vo1g273n446AEx0KbA3iHg33Bs0GDnWkEqYtN25PKyfETYzcL/RmP9VwE E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85360549 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:zzVsDauHIailmdrr4jvyaEIcUufnVAReMUV32f8akzHdYApBsoF/q tZmKTrQb/aNMDOheYsjYY2xpB4O6pHTmtZrHAFvpSk0F3xE+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaEzSFJZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwCjwnUiqs3vuMwo20eO0yq+4MB867M9ZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfAdMYH49tL7Aan3XWjtUsl+K44Ew5HDe1ldZ27nxKtvFPNeNQK25m27I+ zmYpzmlU3n2MvTG8hvfzHS1gNTguh7kG9ouPaeJ/M9D1Qj7Kms7V0RNCArTTeOCokK3Rd93M UEf/Ssq668o+ySDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJgOtc/R/6pVwH2Zzk AbUwZW5XlSDrYF5V1q/+p2olxzrIBIXEmAwYXEpZyQu5Ins9dRbYg30cjpzLEKkpoSrR2Cok 2vT/XlWa6Y71pBSifjilbzTq3f1/8WSEFZojunCdjj9hj6VcrJJcGBBBbLzyf9bZLiUQVCa1 JTvs5jPtbteZX1hecHkfQnsIF1Kz6zfWNEkqQQzd6TNDhz0k5NjFKgJiN2EGG9nM9wfZRjia 1LJtAVa6fd7ZSX0PPcqPtzuUZp0ksAM8OgJsdiNPrJzjmVZLlfbrEmCm2bNt4wSrKTcuf5mY srKGSpdJX0bFb5m3FKLqxQ1iNcWK+FX7T27eK0XODz9jObOPyfME+9t3ZnnRrlR0Z5oaT79q 753X/ZmAT0GOAEiSkE7KbIuEG0= IronPort-HdrOrdr: A9a23:EGspqaik0FwumPxo0MLjia6tSnBQXtwji2hC6mlwRA09TySZ// rAoB19726TtN9xYgBGpTnuAsi9qB/nmKKdpLNhX4tKPzOW3FdATrsD0WKK+VSJcEfDH6xmpM JdmsBFeaTN5DNB4/oSjjPVLz9Z+qjlzJyV X-IronPort-AV: E=Sophos;i="5.96,184,1665460800"; d="scan'208";a="85360549" From: Andrew Cooper To: Xen-devel CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Andrew Cooper , Christian Lindig , David Scott , Rob Hoes Subject: [PATCH 7/8] tools/oxenstored: Set uncaught exception handler Date: Tue, 22 Nov 2022 15:20:42 +0000 Message-ID: <20221122152043.8518-8-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221122152043.8518-1-andrew.cooper3@citrix.com> References: <20221122152043.8518-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Edwin Török Unhandled exceptions go to stderr by default, but this doesn't typically work for oxenstored because: * daemonize reopens stderr as /dev/null * systemd redirects stderr to /dev/null too Debugging an unhandled exception requires reproducing the issue locally when using --no-fork, and is not conducive to figuring out what went wrong on a remote system. Install a custom handler which also tries to render the backtrace to the configured syslog facility, and DAEMON|ERR otherwise. Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper Acked-by: Christian Lindig --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes Drop print_flush as prerr_endline already flushes. --- tools/ocaml/xenstored/logging.ml | 29 +++++++++++++++++++++++++++++ tools/ocaml/xenstored/xenstored.ml | 3 ++- 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/tools/ocaml/xenstored/logging.ml b/tools/ocaml/xenstored/logging.ml index 39c3036155a2..255051437d60 100644 --- a/tools/ocaml/xenstored/logging.ml +++ b/tools/ocaml/xenstored/logging.ml @@ -342,3 +342,32 @@ let xb_answer ~tid ~con ~ty data = let watch_not_fired ~con perms path = let data = Printf.sprintf "EPERM perms=[%s] path=%s" perms path in access_logging ~tid:0 ~con ~data Watch_not_fired ~level:Info + +let msg_of exn bt = + Printf.sprintf "Fatal exception: %s\n%s\n" (Printexc.to_string exn) + (Printexc.raw_backtrace_to_string bt) + +let fallback_exception_handler exn bt = + (* stderr goes to /dev/null, so use the logger where possible, + but always print to stderr too, in case everything else fails, + e.g. this can be used to debug with --no-fork + + this function should try not to raise exceptions, but if it does + the ocaml runtime should still print the exception, both the original, + and the one from this function, but to stderr this time + *) + let msg = msg_of exn bt in + prerr_endline msg; + (* See Printexc.set_uncaught_exception_handler, need to flush, + so has to call stop and flush *) + match !xenstored_logger with + | Some l -> error "xenstored-fallback" "%s" msg; l.stop () + | None -> + (* Too early, no logger set yet. + We normally try to use the configured logger so we don't flood syslog + during development for example, or if the user has a file set + *) + try Syslog.log Syslog.Daemon Syslog.Err msg + with e -> + let bt = Printexc.get_raw_backtrace () in + prerr_endline @@ msg_of e bt diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml index 23621bd49397..257481285f05 100644 --- a/tools/ocaml/xenstored/xenstored.ml +++ b/tools/ocaml/xenstored/xenstored.ml @@ -357,7 +357,8 @@ let tweak_gc () = Gc.set { (Gc.get ()) with Gc.max_overhead = !Define.gc_max_overhead } -let _ = +let () = + Printexc.set_uncaught_exception_handler Logging.fallback_exception_handler; let cf = do_argv in let pidfile = if Sys.file_exists (config_filename cf) then -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 15:21:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 15:21:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447226.703229 (Exim 4.92) (envelope-from ) id 1oxV5D-0000oy-5b; Tue, 22 Nov 2022 15:21:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447226.703229; Tue, 22 Nov 2022 15:21:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV5C-0000nh-Rx; Tue, 22 Nov 2022 15:21:10 +0000 Received: by outflank-mailman (input) for mailman id 447226; Tue, 22 Nov 2022 15:21:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV5B-0000Pt-Hf for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 15:21:09 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47d3b866-6a79-11ed-8fd2-01056ac49cbb; Tue, 22 Nov 2022 16:21:06 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47d3b866-6a79-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669130466; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=GE40QxnlDv68PxpIrB7fasnDGtdgXK+24c1Gkryqt3E=; b=gj4b+Xol7hOIh0JHT5WyslHsEWsYhZ2wqQKThbj1fzcCYs/+Z6sHe4um fBxbKnkbxjrx7xrLqXI8JMe0oYeFGlfweV0FqSWgQAcwlqcBXUkL4cM/E Z0e88oaeRoWKtkOtLnRKWgZg/XZVKedrr5cxbj+nLTR8RyrkLChDuxIjZ 0=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84920457 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:xGDM26P4ItuxAGvvrR33l8FynXyQoLVcMsEvi/4bfWQNrUoigzBRz 2YdCm6Fa/+JYmX3eYhyPIzn9BkBu8TSyIUxHgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5AZmOZingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0tlVKDxCz +VGE28cXAGNgf+P76K4dfY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w/N3wsYDUWUrsTILs4kP2lmT/UdDpApUjOjaE2/3LS3Ep6172F3N/9KoDbH50JwxnwS mTu9UWmDhoVG/KjkDOU7kiM3P/QjCencddHfFG/3qEz2wDCroAJMzUaXEW2ieO0gUm/X5RYM UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcLpDx2xXzZeCGQbMZp/6ZFwFWdCO kK1c83BOh5G7bGvUCymqaamvD20JBE6PWw9enpRJeca2OUPsL3fnzqWEIgySP7u14ykcd3j6 2vU9XZj3t3/meZOjvzmpg6f3lpAs7CTFmYIChPrsnVJB++TTKqsfMSW5FfS9p6sx67JHwDa7 BDodyVzhd3i7K1hdwTXGo3h5Jnzu5643MT02DaC3/AJrlxBAUKLc4FK+y1ZL0x0KMsCcjKBS BaN51IJucINYyH0M/Afj2eN5yMClPiIKDgYfqqMMoomjmZZKWdrAx2ClWbPhjuwwSDAYIk0O IuBcNbEMJrpIf0P8dd3Ls9DuYIWKtcWnz6PFcuilk7/uVdcDVbMIYo43JK1RrhRxMu5TM/9q r6z6+PiJ81jbdDD IronPort-HdrOrdr: A9a23:t//4JK9MLUiUJRzk48Buk+DSI+orL9Y04lQ7vn2YSXRuHfBw8P re+MjztCWE7Qr5N0tApTntAsS9qBDnhPxICOsqXYtKNTOO0ADDEGgL1/qE/9SKIUPDH4BmuZ uIC5IOa+HNMQ== X-IronPort-AV: E=Sophos;i="5.96,184,1665460800"; d="scan'208";a="84920457" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Christian Lindig , David Scott , Edwin Torok , Rob Hoes Subject: [PATCH 0/8] Oxenstored live update fixes Date: Tue, 22 Nov 2022 15:20:35 +0000 Message-ID: <20221122152043.8518-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit First set of Ocaml fixes, cleaned up from series posted previously. Patch 1 fixes a logical error introduced in the xenstore live update support. Patches 2-5 fix oxenstored to keep /dev/xen/evtchn open across live update. Patches 6-8 fix various issues with diagnostics. All previous feedback applied, but I've started this series again to avoid confusion. Andrew Cooper (1): tools/oxenstored: Fix incorrect scope after an if statement Edwin Török (7): tools/ocaml/evtchn: OCaml 5 support, fix potential resource leak tools/ocaml/evtchn: Add binding for xenevtchn_fdopen() tools/ocaml/evtchn: Extend the init() binding with a cloexec flag tools/oxenstored: Keep /dev/xen/evtchn open across live update tools/oxenstored: Log live update issues at warning level tools/oxenstored: Set uncaught exception handler tools/oxenstored/syslog: Avoid potential NULL dereference tools/ocaml/libs/eventchn/xeneventchn.ml | 6 +- tools/ocaml/libs/eventchn/xeneventchn.mli | 13 +++- tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 50 ++++++++++++-- tools/ocaml/xenstored/domain.ml | 6 +- tools/ocaml/xenstored/domains.ml | 14 ++-- tools/ocaml/xenstored/event.ml | 8 ++- tools/ocaml/xenstored/logging.ml | 29 +++++++++ tools/ocaml/xenstored/syslog_stubs.c | 7 +- tools/ocaml/xenstored/xenstored.ml | 94 ++++++++++++++++++--------- 9 files changed, 179 insertions(+), 48 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 15:21:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 15:21:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447227.703242 (Exim 4.92) (envelope-from ) id 1oxV5E-0001Ae-9I; Tue, 22 Nov 2022 15:21:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447227.703242; Tue, 22 Nov 2022 15:21:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV5E-00019x-4I; Tue, 22 Nov 2022 15:21:12 +0000 Received: by outflank-mailman (input) for mailman id 447227; Tue, 22 Nov 2022 15:21:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV5C-0000Pt-He for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 15:21:10 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 49559a23-6a79-11ed-8fd2-01056ac49cbb; Tue, 22 Nov 2022 16:21:07 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49559a23-6a79-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669130467; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7gWfaxpMRzjVNfVa6VAf16WPp08zyiDdBqzCCJVKn/c=; b=XBic0HkmTYoyl+rrSKQVwmYvkvdILCdQwegw/sd+dQVqmZC+BQ+I/VBX r021Dql6KvFm9ocYiNKHXRj6MErD8PpjfnBHHGy0988KJci9kkqr5ec4a hLU1TFoivED2+NCpH4cwuQEs5rjXOyeTTNW7TFTeQYGtTuipjxhH6UOZ8 U=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85360552 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:C1j3r6iJJLRle6uVytR2BSxrX161MhAKZh0ujC45NGQN5FlHY01je htvC2nXOauOMWTxLox2OtmzpElTuJfWmoA2SFQ+qyBgRiIb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QWEzyV94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQgCjFTMCqswNuq2ZzicLh2qsB+Hcb0adZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQthbF/ Tyeojmjav0cHO6t5Aja016OuuzgmjLed8FMDpG6/9c/1TV/wURMUUZLBDNXu8KRhkegVvpFJ kcT+y5oqrI9nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsc9JaQIV47olsH2Vsj wLX2YOybdByjFGLYUq/9+nKlxz1ADQMAzY4NDUoSVY07Ma29enfkSnzosZf/L+d14OrSGmgm Gnb/UDSlJ1I05dVivzTEUTvxmv1+8OXFlNdChD/BDrN0+9vWGKyi2VEA3D/5O0IEouWR0LpU JMsy5nHt7Bm4X1geUWwrAQx8FKBvazt3MX02wIHInXY323FFr7KVdk4DMtCDEloKN0YXjTif VXevwhcjLcKYiX7NfIqPd3rVZp1pUQFKTgCfqmEBuein7ArLFPXlM2QTRP4M5/RfLgEzvhkZ MbznTeEBncGE6V3pAdatM9EuYLGB0kWmwvueHwM5076jerFPSfPEd/o8jKmN4gE0U9Nmy2Nm /43CidA40w3vDHWCsUPzbMuEA== IronPort-HdrOrdr: A9a23:MGh4ja6DI60Kw1nAhgPXwM7XdLJyesId70hD6qhwISY7TiX+rb HJoB17726StN9/YhAdcLy7VZVoBEmsl6KdgrNhWYtKPjOHhILAFugLhuHfKn/bakjDH4ZmpN 5dmsNFZuEYY2IXsS+D2njaL+od X-IronPort-AV: E=Sophos;i="5.96,184,1665460800"; d="scan'208";a="85360552" From: Andrew Cooper To: Xen-devel CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Rob Hoes Subject: [PATCH 8/8] tools/oxenstored/syslog: Avoid potential NULL dereference Date: Tue, 22 Nov 2022 15:20:43 +0000 Message-ID: <20221122152043.8518-9-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221122152043.8518-1-andrew.cooper3@citrix.com> References: <20221122152043.8518-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Edwin Török strdup() may return NULL. Check for this before passing to syslog(). Drop const from c_msg. It is bogus, as demonstrated by the need to cast to void * in order to free the memory. Signed-off-by: Edwin Török Acked-by: Christian Lindig --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes --- tools/ocaml/xenstored/syslog_stubs.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/xenstored/syslog_stubs.c b/tools/ocaml/xenstored/syslog_stubs.c index 875d48ad57eb..e16c3a9491d0 100644 --- a/tools/ocaml/xenstored/syslog_stubs.c +++ b/tools/ocaml/xenstored/syslog_stubs.c @@ -14,6 +14,7 @@ #include #include +#include #include #include #include @@ -35,14 +36,16 @@ static int __syslog_facility_table[] = { value stub_syslog(value facility, value level, value msg) { CAMLparam3(facility, level, msg); - const char *c_msg = strdup(String_val(msg)); + char *c_msg = strdup(String_val(msg)); int c_facility = __syslog_facility_table[Int_val(facility)] | __syslog_level_table[Int_val(level)]; + if ( !c_msg ) + caml_raise_out_of_memory(); caml_enter_blocking_section(); syslog(c_facility, "%s", c_msg); caml_leave_blocking_section(); - free((void*)c_msg); + free(c_msg); CAMLreturn(Val_unit); } -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 15:21:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 15:21:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447228.703250 (Exim 4.92) (envelope-from ) id 1oxV5E-0001IY-Sb; Tue, 22 Nov 2022 15:21:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447228.703250; Tue, 22 Nov 2022 15:21:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV5E-0001Fk-Gz; Tue, 22 Nov 2022 15:21:12 +0000 Received: by outflank-mailman (input) for mailman id 447228; Tue, 22 Nov 2022 15:21:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV5D-0000Pt-Hj for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 15:21:11 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4975d2f2-6a79-11ed-8fd2-01056ac49cbb; Tue, 22 Nov 2022 16:21:07 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4975d2f2-6a79-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669130467; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ftaqE+uJKqGeClk6offLXZjZa6ryJgP18AvrDuvBHds=; b=g2fmZ/SMKNZI3AztpnsMDKDOsT0r7X331qoTTfFC9ESLV5sZcFx/pPQB r81fkaZtpb+DnJwnRIqGoKnNn1FqcghxcsxWd1KD0JlLuwlOgc1cSxuby TsAs0mknAQoppXI7RQhhqIQBvHTxXsZvxGFIHYrr/3IbRsKJlfvayUWqf g=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84920460 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:4ifm4KNFDFveuKrvrR33l8FynXyQoLVcMsEvi/4bfWQNrUpxhWMBn DBJXDrSPveCMDf8KYt+atm+/ExSv8eHmN5mHAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5AZmOZingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rsmPnNP8 /EfFD4ESRW5lrrn5ryHVPY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w/N3wsYDUWUrsTILs4kP2lmT/UdDpApUjOjaE2/3LS3Ep6172F3N/9KoDbH50JwB7wS mTu3VvZWxAlF96k4yeV2Wuyp/bszR7+YddHfFG/3qEz2wDCroAJMzUaXEW2ieO0gUm/X5RYM UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcLpDx2xXzZeCGQbMZp/6ZFwFWdCO kK1c83BWG1QoryTRHWh+L6zqAmjYXkzI1McenpRJeca2OUPsL3fnzqWEIgySP7u14ykcd3j6 2vU9XZj3t3/meZOjvzmpg6f3lpAs7CTFmYIChPrsnVJB++TTKqsfMSW5FfS9p6sx67JHwDa7 BDodyVzhd3i7K1hdwTXGo3h5Jnzu5643MT02DaC3/AJrlxBAUKLc4FK+y1ZL0x0KMsCcjKBS BaN51IJucINYyH0M/Afj2eN5yMClPiIKDgYfqqMMoomjmZZKWdrAx2ClWbPhjuwwSDAYIk0O IuBcNbEMJrpIf0P8dd3Ls9DuYIWKtcWnz6PFcuilk7/uVdcDVbMIYo43JK1RrhRxMu5TM/9q L6z6+PiJ81jbdDD IronPort-HdrOrdr: A9a23:YXERXaPQhTruqcBcTvmjsMiBIKoaSvp037Eqv3oedfUzSL3gqy nOpoV86faaslYssR0b9exofZPwJE80lqQFhrX5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtrZ uIGJIeNDSfNzdHZL7BkWuFL+o= X-IronPort-AV: E=Sophos;i="5.96,184,1665460800"; d="scan'208";a="84920460" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Christian Lindig , David Scott , Edwin Torok , Rob Hoes Subject: [PATCH 1/8] tools/oxenstored: Fix incorrect scope after an if statement Date: Tue, 22 Nov 2022 15:20:36 +0000 Message-ID: <20221122152043.8518-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221122152043.8518-1-andrew.cooper3@citrix.com> References: <20221122152043.8518-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit A debug statement got inserted into a single-expression if statement. Insert brackets to give the intended meaning, rather than the actual meaning where the "let con = Connections..." is outside and executed unconditionally. This results in some unnecessary ring checks for domains which otherwise have IO credit. Fixes: 42f0581a91d4 ("tools/oxenstored: Implement live update for socket connections") Reported-by: Edwin Török Signed-off-by: Andrew Cooper --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes --- tools/ocaml/xenstored/xenstored.ml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml index ffd43a4eee64..c5dc7a28d082 100644 --- a/tools/ocaml/xenstored/xenstored.ml +++ b/tools/ocaml/xenstored/xenstored.ml @@ -475,7 +475,7 @@ let _ = let ring_scan_checker dom = (* no need to scan domains already marked as for processing *) - if not (Domain.get_io_credit dom > 0) then + if not (Domain.get_io_credit dom > 0) then ( debug "Looking up domid %d" (Domain.get_id dom); let con = Connections.find_domain cons (Domain.get_id dom) in if not (Connection.has_more_work con) then ( @@ -490,7 +490,8 @@ let _ = let n = 32 + 2 * (Domains.number domains) in info "found lazy domain %d, credit %d" (Domain.get_id dom) n; Domain.set_io_credit ~n dom - ) in + ) + ) in let last_stat_time = ref 0. in let last_scan_time = ref 0. in -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 15:21:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 15:21:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447229.703264 (Exim 4.92) (envelope-from ) id 1oxV5G-0001l2-CZ; Tue, 22 Nov 2022 15:21:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447229.703264; Tue, 22 Nov 2022 15:21:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV5G-0001jW-5W; Tue, 22 Nov 2022 15:21:14 +0000 Received: by outflank-mailman (input) for mailman id 447229; Tue, 22 Nov 2022 15:21:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxV5E-0000Pt-Hn for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 15:21:12 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a1b946e-6a79-11ed-8fd2-01056ac49cbb; Tue, 22 Nov 2022 16:21:08 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a1b946e-6a79-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669130468; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0EP93NE9oZj0G/r8F641xXDztqVUJkqAFbkxrSBRCso=; b=FuUUYDEyZqu4ivHK7Yw/6WCpzlerdU5WmyhRVq+YM0MBcbWCTPRhYFlU eBgwohKLX1zgzoVNwxMPbdtqW6FuhjWF9Mbv7OjitS8xUcGwr3JX62nCW XpoFaShNyLhXyn6GIsg/JL9sj4c+rFrb5ndHVHBKOkIwWeOvxgGrlqqhG 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84920461 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:/m1Og6wtyNzAYIc9EMN6t+dlxirEfRIJ4+MujC+fZmUNrF6WrkUGz mceWGzSPa7YNjT8fIglYIWwoB4CsJPSzdJiGQU4rCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnP6oT4DcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KTwfy u4ZLj0KUh6KoOeM0erqbOdQmNt2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiFZkExB7E+ DuuE2LRMhcdNPmv5Rm81U2229HxrAarBLovLejtnhJtqALKnTFCYPEMbnO3qOe0olSzUNVeL woT4CVGhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6k6nMsF2AbLoZ87YlvGGJsh gThc87V6SJH7eyqW3Ob+7CoozqVPBIEdT4kaxMaUl5QizX8m73fni4jX/46TvDk1o2uQGChq 9yZhHNg3utO1Kbnw43+pAma2Gz0+/AlWyZvvm3qsnSZAhSVjWJPT6ih8hDl4PlJN+51pXHR7 SFfy6ByAA3jZKxhdRBho81XRtlFH97fbFXhbadHRvHMN12FohZPh7x47jBkP1tOOc0ZYzLva 0K7kVoPus4LYSb0MvUpPd3Z5yEWIU/ITISNaxwpRoAWPsgZmPGvoUmCmnJ8L0iyyRNxwMnTy L+QcNq2DGZyNEiU5GPeegrcuJd1rh0DKZT7H82nn0/+iODGDJNXIJ9cWGazgikCxPvsiG3oH xx3baNmFz03vDXCXxTq IronPort-HdrOrdr: A9a23:wxi1dKDj1Ql8FhDlHemq55DYdb4zR+YMi2TC1yhKJiC9Ffbo8f xG/c5rsiMc5wxxZJhNo7290ey7MBHhHP1OkO0s1NWZPDUO0VHAROoJ0WKh+UyEJ8SXzJ8l6U 4KScZD4bPLYWSS9fyKgzWFLw== X-IronPort-AV: E=Sophos;i="5.96,184,1665460800"; d="scan'208";a="84920461" From: Andrew Cooper To: Xen-devel CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Andrew Cooper , Christian Lindig , David Scott , Rob Hoes Subject: [PATCH 3/8] tools/ocaml/evtchn: Add binding for xenevtchn_fdopen() Date: Tue, 22 Nov 2022 15:20:38 +0000 Message-ID: <20221122152043.8518-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221122152043.8518-1-andrew.cooper3@citrix.com> References: <20221122152043.8518-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Edwin Török For live update, the new oxenstored needs to reconstruct an evtchn object around an existing file descriptor. Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper Acked-by: Christian Lindig --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes Split out of combined patch --- tools/ocaml/libs/eventchn/xeneventchn.ml | 1 + tools/ocaml/libs/eventchn/xeneventchn.mli | 4 ++++ tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 19 +++++++++++++++++++ 3 files changed, 24 insertions(+) diff --git a/tools/ocaml/libs/eventchn/xeneventchn.ml b/tools/ocaml/libs/eventchn/xeneventchn.ml index dd00a1f0ead5..be4de82f46b9 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn.ml +++ b/tools/ocaml/libs/eventchn/xeneventchn.ml @@ -17,6 +17,7 @@ type handle external init: unit -> handle = "stub_eventchn_init" +external fdopen: Unix.file_descr -> handle = "stub_eventchn_fdopen" external fd: handle -> Unix.file_descr = "stub_eventchn_fd" type t = int diff --git a/tools/ocaml/libs/eventchn/xeneventchn.mli b/tools/ocaml/libs/eventchn/xeneventchn.mli index 08c73376438e..98b3c86f3702 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn.mli +++ b/tools/ocaml/libs/eventchn/xeneventchn.mli @@ -47,6 +47,10 @@ val init: unit -> handle (** Return an initialised event channel interface. On error it will throw a Failure exception. *) +val fdopen: Unix.file_descr -> handle +(** Return an initialised event channel interface, from an already open evtchn + file descriptor. On error it will throw a Failure exception. *) + val fd: handle -> Unix.file_descr (** Return a file descriptor suitable for Unix.select. When the descriptor becomes readable, it is safe to call 'pending'. diff --git a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c index 37f1cc4e1478..7bdf711bc150 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c +++ b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c @@ -69,6 +69,25 @@ CAMLprim value stub_eventchn_init(void) CAMLreturn(result); } +CAMLprim value stub_eventchn_fdopen(value fdval) +{ + CAMLparam1(fdval); + CAMLlocal1(result); + xenevtchn_handle *xce; + + caml_enter_blocking_section(); + xce = xenevtchn_fdopen(NULL, Int_val(fdval), 0); + caml_leave_blocking_section(); + + if (xce == NULL) + caml_failwith("evtchn fdopen failed"); + + result = caml_alloc_custom(&xenevtchn_ops, sizeof(xce), 0, 1); + _H(result) = xce; + + CAMLreturn(result); +} + CAMLprim value stub_eventchn_fd(value xce) { CAMLparam1(xce); -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 16:38:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 16:38:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447261.703281 (Exim 4.92) (envelope-from ) id 1oxWHr-00042P-9i; Tue, 22 Nov 2022 16:38:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447261.703281; Tue, 22 Nov 2022 16:38:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxWHr-00042I-5k; Tue, 22 Nov 2022 16:38:19 +0000 Received: by outflank-mailman (input) for mailman id 447261; Tue, 22 Nov 2022 16:38:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxWHp-00042C-AU for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 16:38:17 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0fa83139-6a84-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 17:38:15 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6F80021EE0; Tue, 22 Nov 2022 16:38:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EEFFB13AA1; Tue, 22 Nov 2022 16:38:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id K5PhOPX6fGMNPgAAMHmgww (envelope-from ); Tue, 22 Nov 2022 16:38:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fa83139-6a84-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669135094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2HaFudDaMDVTnrq9g6vTYOKijFH6XNF8q+9ygX8nBYA=; b=fakECqQAM0jXiY64Wp3MlDxQ0wrI17FsjJs9aBXR4mPgmulrLathoVy4tvMr6JxJ+MqkMI qZ1FWS9pVQJr8Bc6fK6I/LZSTDe6x3x1PB3wTv72Scma9KVfatS2oZDDQ+P+n6sZua5thx lBeotURNkC+lOLawZpZRsFK3RlSaTq0= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ard Biesheuvel , Darren Hart , Andy Shevchenko , Boris Ostrovsky , xen-devel@lists.xenproject.org Subject: [PATCH v2 0/3] x86/realmode: use a dummy trampoline for Xen PV guests Date: Tue, 22 Nov 2022 17:38:07 +0100 Message-Id: <20221122163810.29752-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A Xen PV guests can't run in realmode, so the realmode trampoline can omitted. Changes in V2: - complete new approach Juergen Gross (3): x86/realmode: test real_mode_header outside of real_mode_size_needed() x86/realmode: add trampoline reference structure x86/xen: add a dummy trampoline for Xen PV guests arch/x86/include/asm/realmode.h | 15 +++++++++++---- arch/x86/platform/efi/quirks.c | 3 ++- arch/x86/realmode/init.c | 25 ++++++++++++++++++++----- arch/x86/xen/enlighten_pv.c | 17 +++++++++++++++++ 4 files changed, 50 insertions(+), 10 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 16:38:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 16:38:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447262.703292 (Exim 4.92) (envelope-from ) id 1oxWI5-0004Jn-Hr; Tue, 22 Nov 2022 16:38:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447262.703292; Tue, 22 Nov 2022 16:38:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxWI5-0004Jg-Dk; Tue, 22 Nov 2022 16:38:33 +0000 Received: by outflank-mailman (input) for mailman id 447262; Tue, 22 Nov 2022 16:38:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxWI4-00042C-U3 for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 16:38:33 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 19a4ad51-6a84-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 17:38:32 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8E9571F86C; Tue, 22 Nov 2022 16:38:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 42D6413AA1; Tue, 22 Nov 2022 16:38:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id stvRDgf7fGM7PgAAMHmgww (envelope-from ); Tue, 22 Nov 2022 16:38:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19a4ad51-6a84-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669135111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W81+a3w29o+2kJo/uKGKHkjczRGs9DSxwdSixl+/5NM=; b=ffdpOp0+DsrHVZg8DrFMLNS7LXGnNIErwkB8BlJypLISgN8W9iGkeM7HIK10YTkOSpFqti pgU9/Yo32npE4wwk3YyPZs7oaRSNolja4Mz2ZfRz198hqR3BYTFqlZFdnS3P5wKS9+v8Mp 5K+UqxdHbt3Zlq2PMITyuUNGwM6uXyU= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , xen-devel@lists.xenproject.org Subject: [PATCH v2 3/3] x86/xen: add a dummy trampoline for Xen PV guests Date: Tue, 22 Nov 2022 17:38:10 +0100 Message-Id: <20221122163810.29752-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221122163810.29752-1-jgross@suse.com> References: <20221122163810.29752-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When running as a Xen PV guest there is no need for setting up the realmode trampoline, as realmode isn't supported in this environment. Trying to setup the trampoline has been proven to be problematic in some cases, especially when trying to debug early boot problems with Xen requiring to keep the EFI boot-services memory mapped (some firmware variants seem to claim basically all memory below 1M for boot services). Setup a dummy trampoline in order to make init_real_mode() happy. In order to avoid too tight coupling between the Xen PV specific code and the trampoline handling, modify the trampoline handling to do nothing if the detected trampoline size is 0. Fixes: 084ee1c641a0 ("x86, realmode: Relocator for realmode code") Signed-off-by: Juergen Gross --- arch/x86/realmode/init.c | 6 ++++++ arch/x86/xen/enlighten_pv.c | 17 +++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/arch/x86/realmode/init.c b/arch/x86/realmode/init.c index 5a670a9ed2f7..538328ce5ff5 100644 --- a/arch/x86/realmode/init.c +++ b/arch/x86/realmode/init.c @@ -110,6 +110,9 @@ static void __init setup_real_mode(void) int i; #endif + if (!size) + return; + base = (unsigned char *)real_mode_header; /* @@ -204,6 +207,9 @@ static void __init set_real_mode_permissions(void) unsigned long text_start = (unsigned long) __va(real_mode_header->text_start); + if (!size) + return; + set_memory_nx((unsigned long) base, size >> PAGE_SHIFT); set_memory_ro((unsigned long) base, ro_size >> PAGE_SHIFT); set_memory_x((unsigned long) text_start, text_size >> PAGE_SHIFT); diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 038da45f057a..a6194a6a6806 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -71,6 +71,7 @@ #include #include #include +#include #ifdef CONFIG_X86_IOPL_IOPERM #include #endif @@ -137,12 +138,28 @@ static void __init xen_pv_init_platform(void) xen_init_time_ops(); } +static struct real_mode_header xen_rm_header; + +static __initdata struct trampoline_ref xen_dummy_trampoline = { + .blob = (unsigned char *)&xen_rm_header, + .blob_end = (unsigned char *)&xen_rm_header, +}; + +/* Setup dummy trampoline of size 0 with no relocations. */ +static void __init xen_setup_trampoline(void) +{ + real_mode_header = &xen_rm_header; + real_mode_trampoline = &xen_dummy_trampoline; +} + static void __init xen_pv_guest_late_init(void) { #ifndef CONFIG_SMP /* Setup shared vcpu info for non-smp configurations */ xen_setup_vcpu_info_placement(); #endif + + xen_setup_trampoline(); } static __read_mostly unsigned int cpuid_leaf5_ecx_val; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 22 17:13:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 17:13:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447272.703306 (Exim 4.92) (envelope-from ) id 1oxWpl-0000XE-Aa; Tue, 22 Nov 2022 17:13:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447272.703306; Tue, 22 Nov 2022 17:13:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxWpl-0000X7-7T; Tue, 22 Nov 2022 17:13:21 +0000 Received: by outflank-mailman (input) for mailman id 447272; Tue, 22 Nov 2022 17:13:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxWpk-0000X1-A6 for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 17:13:20 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2f120a9-6a88-11ed-91b6-6bf2151ebd3b; Tue, 22 Nov 2022 18:13:17 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2f120a9-6a88-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669137197; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=dibonJrbFJPYYbZVRju2tWu8dUxlVlZEda3MzHEgIJM=; b=f6FdS+OZaWcb6i8OOBrLaGA9R0RFwe+zJBYixnzJwKJNoDMQ02s+NRQ3 fLoQaRkJZDhWYfaf2LE3BM+xBTaQJe9k6+GJ55vz2dTieIC+hxY915CmI aUYsAcD4t5AizKrcmdSlJtYt/JUFhHxmNt56yL1TsUenFTRqAZqTCrq9T s=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84931259 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:qbc5bqCCtCEOFRVW/wjjw5YqxClBgxIJ4kV8jS/XYbTApDxw0jEPx mYeXGiFa/eCMzb9KI8gPIi29EgCv8CEyoUwQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpC5ARiDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw2cxJLmMTx 9EiFhtRMCvTps6w7LDqRbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/AZQinOCulz/nfidRsl69rqsr+WnDigd21dABNfKFJo3RHJ8Izy50o ErtpzT1IxcDNeCt9gra12+8qtXrwHPkDdd6+LqQqacx3Qz7KnYoIAUfSF+TsfS/zEmkVLp3O 0ESvyYjs6U23EiqVcXmGQ21pmaeuRwRUMYWFPc1gCmW0bbd6QudAmkCTxZCZcYguctwQiYlv neMlsnsDCZis5WUT2yc7baeqT6uOSkTInQGbCVCRgwAi/H6rYQuyx7CUNtnOKiyiNLzBHf32 T/ikcQlr+xN14hRjfz9pA2ZxWL3znTUcuIrzib9YE2nszFUXrCOO9KTuXn369pCfYnMGzFto 0M4d9iiAPEmVM/TxXTdG7xcTdlF9N7ebmSC3AcH840Jsm30piX9Jd04DCRWfh8BDyoSRdP+j KY/Uyt17YQbAnalZLQfj2mZW5VzlviI+TgIu5npgjtyjntZLlXvENlGPxL44owUuBFEfGFWE c7znTyQJXgbE7976zG9Wv0Q17Qmrghnmz2CHc2mkUv9j+TBDJJwdVviGALeBt3VEYve+FmFm zqhH5biJ+pjvB3WPXCMrN97waEiJnknH5Hmw/G7hcbaSjeL2QgJVZfs/F/WU9Y4w/QOz76Sp hlQmCZwkTLCuJEOEi3SAlgLVV8ldcwXQa4TVcD0AWuV5g== IronPort-HdrOrdr: A9a23:UcGP06F7kQBvQJ9fpLqE08eALOsnbusQ8zAXPiFKOH5om6mj/P xG88536faKskdpZJhNo7y90dC7MBThHMdOkO8s1NSZLWrbUQmTTb2KhLGKq1fd8kvFmdK1vp 0BT0ERMrPN5SwQt7ef3OHLeOxQpeW6zA== X-IronPort-AV: E=Sophos;i="5.96,184,1665460800"; d="scan'208";a="84931259" Date: Tue, 22 Nov 2022 17:12:59 +0000 From: Anthony PERARD To: Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= CC: , Stefano Stabellini , Paul Durrant , "open list:X86 Xen CPUs" Subject: Re: [PATCH 1/2] hw/xen/xen_pt: Call default handler only if no custom one is set Message-ID: References: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221114192011.1539233-1-marmarek@invisiblethingslab.com> On Mon, Nov 14, 2022 at 08:20:10PM +0100, Marek Marczykowski-Grecki wrote: > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > index 0ec7e52183..269bd26109 100644 > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -255,6 +255,7 @@ static void xen_pt_pci_write_config(PCIDevice *d, uint32_t addr, > uint32_t find_addr = addr; > XenPTRegInfo *reg = NULL; > bool wp_flag = false; > + uint32_t emul_mask = 0, write_val; > > if (xen_pt_pci_config_access_check(d, addr, len)) { > return; > @@ -310,7 +311,6 @@ static void xen_pt_pci_write_config(PCIDevice *d, uint32_t addr, > } > > memory_region_transaction_begin(); > - pci_default_write_config(d, addr, val, len); > > /* adjust the read and write value to appropriate CFC-CFF window */ > read_val <<= (addr & 3) << 3; > @@ -370,6 +370,8 @@ static void xen_pt_pci_write_config(PCIDevice *d, uint32_t addr, > return; > } > > + emul_mask |= ( (1 << (reg->size * 8) ) - 1 ) << ((find_addr & 3) * 8); > + > /* calculate next address to find */ > emul_len -= reg->size; > if (emul_len > 0) { > @@ -396,6 +398,24 @@ static void xen_pt_pci_write_config(PCIDevice *d, uint32_t addr, > /* need to shift back before passing them to xen_host_pci_set_block. */ > val >>= (addr & 3) << 3; > > + /* store emulated registers that didn't have specific hooks */ > + write_val = val; > + for (index = 0; emul_mask; index += emul_len) { `index` isn't used, was it meant to be use for something? > + emul_len = 0; > + while (emul_mask & 0xff) { > + emul_len++; This seems to count the number of byte that have a hook (xen_pt_find_reg() found a `reg_entry`). This loop should count instead the number of bytes for which no `reg_entry` have been found, right? Shouldn't the loop count when a byte in emul_mask is unset? > + emul_mask >>= 8; > + } > + if (emul_len) { > + uint32_t mask = ((1 << (emul_len * 8)) - 1); > + pci_default_write_config(d, addr, write_val & mask, emul_len); `addr` isn't updated in the loop, aren't we going to write bytes to the wrong place? If for example "emul_mask == 0x00ff00ff" ? > + write_val >>= emul_len * 8; > + } else { > + emul_mask >>= 8; > + write_val >>= 8; > + } > + } Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Nov 22 20:25:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 20:25:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447285.703329 (Exim 4.92) (envelope-from ) id 1oxZpn-0003sO-SW; Tue, 22 Nov 2022 20:25:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447285.703329; Tue, 22 Nov 2022 20:25:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZpn-0003sH-Pq; Tue, 22 Nov 2022 20:25:35 +0000 Received: by outflank-mailman (input) for mailman id 447285; Tue, 22 Nov 2022 20:25:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZpm-0003sB-4o for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 20:25:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZpk-0007tc-TL; Tue, 22 Nov 2022 20:25:32 +0000 Received: from [54.239.6.190] (helo=[192.168.0.48]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxZpk-0003xV-NH; Tue, 22 Nov 2022 20:25:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=KWjCQs3wcmRoxZynxW2SWqy+EjFwluHlLuchgtYaUCQ=; b=jzErxt4tbmEkNqsJiIrVdAxP9h +K/jIj8XRJYXBga+pBAm+cnyKRU9uuQjs6eD+Pd5Bdw8lhcL4SSUz1se9MBM0ECt9owHKWhMUKF43 d2dLJlzb1t1iwjXYpt6fBH6qWPLigQZBy0hGvTOo2fs6Zn2ddY1llozLjnr3q69QpYbA=; Message-ID: <2645971b-8094-6108-f3dd-567e93d1f1e5@xen.org> Date: Tue, 22 Nov 2022 21:25:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 2/9] xen/arm: add cache coloring initialization for domains Content-Language: en-US To: Jan Beulich , Carlo Nonato Cc: marco.solieri@unimore.it, xen-devel@lists.xenproject.org, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Marco Solieri , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20221022155120.7000-1-carlo.nonato@minervasys.tech> <20221022155120.7000-3-carlo.nonato@minervasys.tech> <2e6c8d81-01d1-81a1-8fd4-4385e46befe4@suse.com> <6c07cdfc-888a-45bb-2077-528a809a62f4@suse.com> From: Julien Grall In-Reply-To: <6c07cdfc-888a-45bb-2077-528a809a62f4@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 21/11/2022 16:40, Jan Beulich wrote: > On 21.11.2022 17:23, Carlo Nonato wrote: >> On Mon, Nov 21, 2022 at 4:14 PM Jan Beulich wrote: >>> On 21.11.2022 15:50, Carlo Nonato wrote: >>>> I want to ask you some questions about this patch because in the previous >>>> version me and Julien have discussed how cache colors should be passed in >>>> domain creation. You should be able to read that discussion, anyway here is >>>> a link to it >>>> >>>> https://marc.info/?l=xen-devel&m=166151802002263 >>> >>> I've looked at the first few entries, without finding an answer to ... >>> >>>> In short, using struct xen_arch_domainconfig works fine only when domctl >>>> hypercall is issued. That struct contains a XEN_GUEST_HANDLE so it >>>> should point to guest memory and must not be used when creating a domain >>>> from Xen itself (i.e. dom0 or dom0less domains). The easy way to go is then >>>> changing the domain_create() signature to require also a color array and its >>>> length to be passed in for these latter cases. >>>> Are you ok with that? See below for more comments. >>> >>> ... my immediate question: Does supplying the colors necessarily need to >>> done right at domain creation? Wouldn't it suffice to be done before first >>> allocating memory to the new domain, i.e. via a separate domctl (and then >>> for Xen-created domains via a separate Xen-internal function, which the >>> new domctl handling would also call)? Or do colors also affect the >>> allocation of struct domain itself (and pointers hanging off of it)? >> >> This would be really good. The only problem I can see is the p2m allocation >> which is done during domain creation. With the current set of patches it >> results in a "Failed to allocate P2M pages" since we want to have p2m tables >> allocated with the same color of the domain and a null page is returned >> because we have no colors. > > Hmm, I see. It would seem to me that this p2m init really is happening > too early. Ideally domain_create would merely mean creating a largely > empty container, with stuff being populated subsequently as necessary. The vGIC is not optional. So to me it sounds wrong to defer the decision to after the domain is created. It is not clear to me how you would check that mandatory components have been properly initialized. > But I guess this is too much of a re-work to be done in the context > here, plus of course I may be overlooking something which actually > makes it necessary for domain creation to be structured the way it is > right now. (Imo the reason for the early minimal population of the p2m, > added only quite recently, wasn't a good one, and the vGIC init would > better be deferred. Yet once again I may lack details on why that's not > possible.) See above for the theoritical part. For the practice part, we need to know the vGIC version at domain creation because it impact the maximum of vCPU we can expose. It is also not very clear where this could be initialized. Are you suggesting to add an extra mandatory hypercall? FAOD, I don't think p2m_set_allocation() would be the right place. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 22 20:27:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 20:27:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447288.703341 (Exim 4.92) (envelope-from ) id 1oxZrQ-0004Ou-9x; Tue, 22 Nov 2022 20:27:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447288.703341; Tue, 22 Nov 2022 20:27:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZrQ-0004On-4x; Tue, 22 Nov 2022 20:27:16 +0000 Received: by outflank-mailman (input) for mailman id 447288; Tue, 22 Nov 2022 20:27:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZrO-0004Od-UQ for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 20:27:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZrO-0007vA-NM; Tue, 22 Nov 2022 20:27:14 +0000 Received: from [54.239.6.190] (helo=[192.168.0.48]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxZrO-00040Z-Ek; Tue, 22 Nov 2022 20:27:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=I5Dj5ymoUijlFOCIZDkO/LcZt22w0GThXDOwBOug+Ac=; b=AJTGbjcc6jVPbbUQ/NXyl5fZui YhEMzMu067Rc8frWgNzFiu4pKlgoOFJFTv9fx4GOIPlHM2U1UEw2BzJVYZTgpD4/QW0YmD30hFTlS FmWJ/a8cfOAqhn529ASxuBUsS2M6Ny4hAyYWsrp/ArJTNgwmgg3gbk2Qxg2nEjvDXKe0=; Message-ID: Date: Tue, 22 Nov 2022 21:27:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] docs/misc/arm: Update references to Linux kernel docs Content-Language: en-US To: Bertrand Marquis , Michal Orzel Cc: Xen developer discussion , Stefano Stabellini , Volodymyr Babchuk , Henry Wang References: <20221118114554.20696-1-michal.orzel@amd.com> <31E1FFCF-F675-47D9-BCDB-5884F7360567@arm.com> From: Julien Grall In-Reply-To: <31E1FFCF-F675-47D9-BCDB-5884F7360567@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit (+ Henry) Hi, On 18/11/2022 13:10, Bertrand Marquis wrote: > Hi Michal, > >> On 18 Nov 2022, at 11:45, Michal Orzel wrote: >> >> Some time ago, Linux switched the format of docs to ReST and the format >> of device-tree bindings to json-schema. >> >> Signed-off-by: Michal Orzel > Reviewed-by: Bertrand Marquis This could potentially be a candidate for 4.17 as this is correcting the links in the docs. So risk free. If we have no new bug fixed queued for 4.17, then I could add the patch after branching. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 22 20:28:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 20:28:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447291.703350 (Exim 4.92) (envelope-from ) id 1oxZsy-0004yR-Ij; Tue, 22 Nov 2022 20:28:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447291.703350; Tue, 22 Nov 2022 20:28:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZsy-0004yK-Fs; Tue, 22 Nov 2022 20:28:52 +0000 Received: by outflank-mailman (input) for mailman id 447291; Tue, 22 Nov 2022 20:28:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZsx-0004yE-J3 for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 20:28:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZsx-0007wd-Ct; Tue, 22 Nov 2022 20:28:51 +0000 Received: from [54.239.6.190] (helo=[192.168.0.48]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxZsx-00041F-7k; Tue, 22 Nov 2022 20:28:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=QgVWXI4WMQiN9uNmu/rzhQzisfB1DR/xcOqqgXRAHJs=; b=ThSIttcHL4GyVJgC1/aHt3kCmM HW3SNAvifcbJmlGyLjkpIr1TALjnjuCRjyeBrrwSM7O+YJ8X1f7FJXu2s6OOmngLmDvkISq15oicp 5DDh/6eM40Flh4e+SOpV5BQY8sQehzaMDb+FPkUVoTpmPbzyxgg9NkSo9wpU3OthyUkg=; Message-ID: <5b239d4e-a75f-dccf-e4cd-232b623325f4@xen.org> Date: Tue, 22 Nov 2022 21:28:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/3] xen/arm: Drop early_uart_init macro from debug-meson.inc Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221118114618.20754-1-michal.orzel@amd.com> <20221118114618.20754-2-michal.orzel@amd.com> From: Julien Grall In-Reply-To: <20221118114618.20754-2-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 18/11/2022 11:46, Michal Orzel wrote: > early_uart_init macro is only used if CONFIG_EARLY_UART_INIT is set. > This config option depends on EARLY_UART_PL011, so there is no point > in defining it for MESON, especially if it is empty. Remove it and adapt > the existing comment. > > Signed-off-by: Michal Orzel Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 22 20:29:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 20:29:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447294.703362 (Exim 4.92) (envelope-from ) id 1oxZu0-0005X5-TY; Tue, 22 Nov 2022 20:29:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447294.703362; Tue, 22 Nov 2022 20:29:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZu0-0005Wy-Q6; Tue, 22 Nov 2022 20:29:56 +0000 Received: by outflank-mailman (input) for mailman id 447294; Tue, 22 Nov 2022 20:29:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZu0-0005Wm-5r for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 20:29:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZu0-0007zD-0a; Tue, 22 Nov 2022 20:29:56 +0000 Received: from [54.239.6.190] (helo=[192.168.0.48]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxZtz-00041o-Rb; Tue, 22 Nov 2022 20:29:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=c7bMFtwYfCpe3eSVFb1yZIAm4LXmJ+VMWj1cWJuycxI=; b=scNFEU1gvZhp3lQSaCjDqN2DiG 71hUE0tG0qm8wGz7LNlWr9KvW+CdPc5Vf47JOk78A8S0V5Qgs1T5qNM88Y2ztw/Hzs4eCHPdSu9Po YzyWAVR5HXPV00Qqs6WTLEBQGEjQ6pR/pWbbEKPHIk8fSAyrM87X1T7+RhBlV4Oih+ME=; Message-ID: Date: Tue, 22 Nov 2022 21:29:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 3/3] xen/arm: Define WLEN_8 macro and use it in debug-pl011 Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221118114618.20754-1-michal.orzel@amd.com> <20221118114618.20754-4-michal.orzel@amd.com> From: Julien Grall In-Reply-To: <20221118114618.20754-4-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 18/11/2022 11:46, Michal Orzel wrote: > At the moment, early printk code for pl011 uses a hardcoded value > for 8n1 LCR configuration. Define and use macro WLEN_8 for that purpose > (no parity and 1 stop bit are defined as 0). > > Signed-off-by: Michal Orzel Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 22 20:30:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 20:30:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447298.703372 (Exim 4.92) (envelope-from ) id 1oxZun-00075I-9U; Tue, 22 Nov 2022 20:30:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447298.703372; Tue, 22 Nov 2022 20:30:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZun-00075B-6k; Tue, 22 Nov 2022 20:30:45 +0000 Received: by outflank-mailman (input) for mailman id 447298; Tue, 22 Nov 2022 20:30:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZul-00074r-ID for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 20:30:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZul-00080J-5z; Tue, 22 Nov 2022 20:30:43 +0000 Received: from [54.239.6.190] (helo=[192.168.0.48]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxZul-00042Q-0P; Tue, 22 Nov 2022 20:30:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=9wpPxlQhqGUZjrAVNVC194QPMgHHiJ94+8I+E3EePYQ=; b=oISMxJoNd8F242UAce25QSKb31 IcFMVBReIJPqjAlVz/lUtqheHSO2nAu9drnV58o3NMuTaQphIu5Iy2dsOpgTdJP3hoWm59kjNPoZ6 2JguuVu65YoHwFai0lGcWyDAp0nuJD0qiJ+izZqCiW5pGePmrEu06TT2/1uokeABYNro=; Message-ID: <5bd1cef5-c466-caba-2b4b-24728e223ff6@xen.org> Date: Tue, 22 Nov 2022 21:30:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN v3 01/12] xen/Arm: vGICv3: Sysreg emulation is applicable for AArch64 only Content-Language: en-US To: Michal Orzel , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, jgrall@amazon.com, burzalodowa@gmail.com References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-2-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/11/2022 13:05, Michal Orzel wrote: > Hi Ayan, > > On 11/11/2022 15:17, Ayan Kumar Halder wrote: >> Sysreg emulation is 64-bit specific, so guard the calls to >> vgic_v3_emulate_sysreg() as well as the function itself with >> "#ifdef CONFIG_ARM_64". >> >> Signed-off-by: Ayan Kumar Halder > Reviewed-by: Michal Orzel Acked-by: Julien Grall Cheers, > > ~Michal -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 22 20:32:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 20:32:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447303.703384 (Exim 4.92) (envelope-from ) id 1oxZw0-0007fH-JS; Tue, 22 Nov 2022 20:32:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447303.703384; Tue, 22 Nov 2022 20:32:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZw0-0007fA-GM; Tue, 22 Nov 2022 20:32:00 +0000 Received: by outflank-mailman (input) for mailman id 447303; Tue, 22 Nov 2022 20:31:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZvz-0007ez-Ds for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 20:31:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZvz-00081x-2O; Tue, 22 Nov 2022 20:31:59 +0000 Received: from [54.239.6.190] (helo=[192.168.0.48]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxZvy-00043h-RM; Tue, 22 Nov 2022 20:31:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=DcQKRdEotdvsrK9aa5y6z2WHO71mRyHJqy/Jgv4i8Jg=; b=B0RO2+/qD51ZitPZPbnEckru6Q u+4ODD+NN9I1Bmim+dlb1vGvp5Qt+WAa4bbCFnPchqp9hw48k1pQ/LwWyIA+8J8h90jm6EkzxKwgl WNoCv+XaGpthWLhKW3coNFkBDT5d+jWRsFhWN51VspKNYGhwtPPYojl8Erqadf30WjIo=; Message-ID: <4045f91a-620a-98b0-d3c7-28af1b0ba4a8@xen.org> Date: Tue, 22 Nov 2022 21:31:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN v3 02/12] xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32 Content-Language: en-US To: Michal Orzel , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, jgrall@amazon.com, burzalodowa@gmail.com References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-3-ayan.kumar.halder@amd.com> <8086e3ac-445b-17a1-bba3-078024ab2579@amd.com> From: Julien Grall In-Reply-To: <8086e3ac-445b-17a1-bba3-078024ab2579@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/11/2022 13:39, Michal Orzel wrote: > Hi Ayan, > > On 11/11/2022 15:17, Ayan Kumar Halder wrote: >> Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169 >> Affinity level 3 is not present in AArch32. >> Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106, >> Affinity level 3 is not present in Armv7 (ie arm32). >> Thus, any access to affinity level 3 needs to be guarded within >> "ifdef CONFIG_ARM_64". >> >> Signed-off-by: Ayan Kumar Halder > Reviewed-by: Michal Orzel > > although, IMO the commit msg does not reflect the change (i.e. you do nothing > related to accessing MPIDR, but instead you are just not taking the Aff3 into account for AArch32). > Also, I'm not sure why you used VMPIDR and not MPIDR. +1. Can one of you propose an improved commit message/title? I would be happy to update the patch on commit if there are nothing else to update in this series. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 22 20:34:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 20:34:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447308.703395 (Exim 4.92) (envelope-from ) id 1oxZyG-0008Gr-0Q; Tue, 22 Nov 2022 20:34:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447308.703395; Tue, 22 Nov 2022 20:34:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZyF-0008Gk-TM; Tue, 22 Nov 2022 20:34:19 +0000 Received: by outflank-mailman (input) for mailman id 447308; Tue, 22 Nov 2022 20:34:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZyF-0008Ge-1H for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 20:34:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxZyE-00084S-Q9; Tue, 22 Nov 2022 20:34:18 +0000 Received: from [54.239.6.190] (helo=[192.168.0.48]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxZyE-0004FZ-J2; Tue, 22 Nov 2022 20:34:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=YRCf3Cb9sV3u/9CW8RMMLA+FoblCwH67IYd9aX7eNJM=; b=XGhn9H4P5p1i0gW5ghNQ+TlTjr 2NsJM2evIRc7TuTzOLi61yWgJIx1m51zH50NS3p7FlONGBTI5gGIvrNqZ2Rb+CpWj50G0s015dI1c xeJuuTmjq8UfFlaky05XVNEEa12U53NrPVJBlOm6Ob1Y1WZa6TD13U9/SZvOx67wEVI8=; Message-ID: <5925c335-0f4b-6221-24cd-07fed8f0e678@xen.org> Date: Tue, 22 Nov 2022 21:34:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN v3 03/12] xen/Arm: vreg: Support vreg_reg64_* helpers on AArch32 Content-Language: en-US To: Michal Orzel , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, jgrall@amazon.com, burzalodowa@gmail.com References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-4-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 17/11/2022 13:11, Michal Orzel wrote: > On 11/11/2022 15:17, Ayan Kumar Halder wrote: >> In some situations (e.g. GICR_TYPER), the hypervior may need to emulate >> 64bit registers in AArch32 mode. In such situations, the hypervisor may >> need to read/modify the lower or upper 32 bits of the 64 bit register. >> >> In AArch32, 'unsigned long' is 32 bits. Thus, we cannot use it for 64 bit >> registers. >> >> While we could replace 'unsigned long' by 'uint64_t', it is not entirely clear >> whether a 32-bit compiler would not allocate register for the upper 32-bit. >> Therefore fold vreg_reg_* helper in the size specific one and use the >> appropriate type based on the size requested. >> >> Signed-off-by: Ayan Kumar Halder > Reviewed-by: Michal Orzel Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 22 20:37:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 20:37:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447313.703405 (Exim 4.92) (envelope-from ) id 1oxa1W-0000TM-Du; Tue, 22 Nov 2022 20:37:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447313.703405; Tue, 22 Nov 2022 20:37:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxa1W-0000TF-BL; Tue, 22 Nov 2022 20:37:42 +0000 Received: by outflank-mailman (input) for mailman id 447313; Tue, 22 Nov 2022 20:37:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxa1V-0000T9-Pl for xen-devel@lists.xenproject.org; Tue, 22 Nov 2022 20:37:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxa1V-00088N-OO; Tue, 22 Nov 2022 20:37:41 +0000 Received: from [54.239.6.190] (helo=[192.168.0.48]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxa1V-0004QI-Id; Tue, 22 Nov 2022 20:37:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=DZj+sP1IY8TVYZZuzv+uibHW8qcoRrER2k0n27teEmU=; b=W0Hs+QEAiRP1PBc6JGBZ95DS82 OAVD+szbOxsN1FnHxM7tNyFsPijicUKCQElaoAe0W+e5kqRpxp5eG7Xg0HMWZE/cAj8OILJNkP4tK QsqRIqeJWt2hBFQU5Eu7lGBNmdWxaft9VqOi/yc8WR3B8Sd1ACTJgAqI0qVr/oLcwZ68=; Message-ID: <52e12805-169b-0ffe-ab7c-192d31320194@xen.org> Date: Tue, 22 Nov 2022 21:37:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN v3 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32 Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com, jgrall@amazon.com, burzalodowa@gmail.com References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-5-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: <20221111141739.2872-5-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 11/11/2022 14:17, Ayan Kumar Halder wrote: > Refer ARM DDI 0487I.a ID081822, G8-9650, G8.2.113 > Aff3 does not exist on AArch32. > Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106 > Aff3 does not exist on Armv7 (ie arm32). > > Thus, access to aff3 have been contained within "#ifdef CONFIG_ARM_64". > Also, v->arch.vmpidr is a 32 bit register on AArch32. So, we have copied it to > 'uint64_t vmpidr' to perform the shifts. > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from :- > v1 - Assigned v->arch.vmpidr to "uint64_t vmpdir". Then, we can use > MPIDR_AFFINITY_LEVEL macros to extract the affinity value. > > v2 - 1. "MPIDR_AFFINITY_LEVEL(vmpidr, 3)" is contained within > "#ifdef CONFIG_ARM_64". > 2. Updated commit message. > > xen/arch/arm/vgic-v3.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c > index 3f4509dcd3..a7a935ff57 100644 > --- a/xen/arch/arm/vgic-v3.c > +++ b/xen/arch/arm/vgic-v3.c > @@ -191,12 +191,16 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info, > case VREG64(GICR_TYPER): > { > uint64_t typer, aff; > + uint64_t vmpidr = v->arch.vmpidr; The type-widening here deserve an in-code comment. Otherwise, it would be easier for someone to decide to open-code v->arch.vmpidr again. > > if ( !vgic_reg64_check_access(dabt) ) goto bad_width; > - aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 | > - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 | > - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 | > - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32); > + aff = ( > +#ifdef CONFIG_ARM_64 > + MPIDR_AFFINITY_LEVEL(vmpidr, 3) << 56 | > +#endif > + MPIDR_AFFINITY_LEVEL(vmpidr, 2) << 48 | > + MPIDR_AFFINITY_LEVEL(vmpidr, 1) << 40 | > + MPIDR_AFFINITY_LEVEL(vmpidr, 0) << 32); > typer = aff; > /* We use the VCPU ID as the redistributor ID in bits[23:8] */ > typer |= v->vcpu_id << GICR_TYPER_PROC_NUM_SHIFT; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 22 22:17:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 22:17:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447324.703423 (Exim 4.92) (envelope-from ) id 1oxbZu-0002sL-LZ; Tue, 22 Nov 2022 22:17:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447324.703423; Tue, 22 Nov 2022 22:17:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxbZu-0002sE-IO; Tue, 22 Nov 2022 22:17:18 +0000 Received: by outflank-mailman (input) for mailman id 447324; Tue, 22 Nov 2022 22:17:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxbZs-0002s4-Rr; Tue, 22 Nov 2022 22:17:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxbZs-0001xc-Q6; Tue, 22 Nov 2022 22:17:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxbZs-0005sv-Gj; Tue, 22 Nov 2022 22:17:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxbZs-00015G-GE; Tue, 22 Nov 2022 22:17:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kBOrnzmcvdS2Avjf/GWDI4BJfKcMyh55ciIUu/FANEg=; b=i5SAPDThhI5VzdA/pyyeHOYgwY qwpezyDX9jWi1rDluOHXPTg9+rFYFgU7J4CAMLM4LQJT2iixG1tB6Nh+VkqTh+95GrmvqECfu1Wct tecHGkvZAtexz893gF7hHTsBHD4Pgz9995Cq6vr4u4LPbgZkep2OlMhwe03PPzwlhfmc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174918: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-seattle::broken:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:host-install:broken:heisenbug linux-linus:test-arm64-arm64-xl-seattle:host-install(5):broken:heisenbug linux-linus:test-amd64-amd64-examine-uefi:host-install:broken:heisenbug linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug linux-linus:test-amd64-amd64-examine-uefi:memdisk-try-append:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 22 Nov 2022 22:17:16 +0000 flight 174918 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174918/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-seattle broken in 174890 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Tests which are failing intermittently (not blocking): test-amd64-amd64-examine-bios 5 host-install broken in 174890 pass in 174918 test-arm64-arm64-xl-seattle 5 host-install(5) broken in 174890 pass in 174918 test-amd64-amd64-examine-uefi 5 host-install broken pass in 174903 test-amd64-amd64-examine 4 memdisk-try-append fail in 174903 pass in 174890 test-amd64-amd64-examine-uefi 4 memdisk-try-append fail pass in 174890 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 46 days Failing since 173470 2022-10-08 06:21:34 Z 45 days 82 attempts Testing same since 174871 2022-11-21 00:40:59 Z 1 days 5 attempts ------------------------------------------------------------ 1802 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-step test-amd64-amd64-examine-uefi host-install broken-job test-arm64-arm64-xl-seattle broken Not pushing. (No revision log; it would be 171425 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Nov 22 22:56:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 22:56:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447331.703433 (Exim 4.92) (envelope-from ) id 1oxcBh-0007Wt-N6; Tue, 22 Nov 2022 22:56:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447331.703433; Tue, 22 Nov 2022 22:56:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxcBh-0007Wm-KV; Tue, 22 Nov 2022 22:56:21 +0000 Received: by outflank-mailman (input) for mailman id 447331; Tue, 22 Nov 2022 22:56:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxcBg-0007Wc-6X; Tue, 22 Nov 2022 22:56:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxcBg-0002kE-1X; Tue, 22 Nov 2022 22:56:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxcBf-0007AL-GS; Tue, 22 Nov 2022 22:56:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxcBf-0007IC-Fz; Tue, 22 Nov 2022 22:56:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=l4bVX0J1oiST9KxoHh/UzYrX/XNC9ZCn33jx0gOxAwQ=; b=gNfQcorS7KBcn7/MNcGCmBhPyr TAvVxs/3lfavd7GcTGfg/bUDWDy/Q5io4BY7dOjQgg643YcaqBxqhED2TKymg11EOdalTSchA/YPO WkTIVnmHrjnO/0ZGmQMRg5ZwPOulA5n/aYi8tfOEtqKTTSGcHpOSIV8Yz2iRJo6keOKA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174920: trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-pvshim::broken:regression xen-unstable:test-amd64-amd64-xl-credit2::broken:regression xen-unstable:test-amd64-amd64-libvirt-vhd::broken:regression xen-unstable:test-amd64-amd64-xl-pvhv2-amd::broken:regression xen-unstable:test-amd64-amd64-xl-pvhv2-amd:host-install(5):broken:heisenbug xen-unstable:test-amd64-amd64-examine-bios:host-install:broken:heisenbug xen-unstable:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:host-install(5):broken:heisenbug xen-unstable:test-amd64-i386-xl-pvshim:host-install(5):broken:heisenbug xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-xsm:debian-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=345135942bf9632eba1409ba432cfcae3b7649c7 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Tue, 22 Nov 2022 22:56:19 +0000 flight 174920 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174920/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-pvshim broken test-amd64-amd64-xl-credit2 broken test-amd64-amd64-libvirt-vhd broken test-amd64-amd64-xl-pvhv2-amd broken in 174906 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-pvhv2-amd 5 host-install(5) broken in 174906 pass in 174920 test-amd64-amd64-examine-bios 5 host-install broken in 174906 pass in 174920 test-amd64-amd64-xl-credit2 5 host-install(5) broken pass in 174906 test-amd64-amd64-libvirt-vhd 5 host-install(5) broken pass in 174906 test-amd64-i386-xl-pvshim 5 host-install(5) broken pass in 174906 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail in 174906 pass in 174920 test-amd64-amd64-xl-xsm 12 debian-install fail pass in 174906 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-pvshim 14 guest-start fail in 174906 never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail in 174906 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 345135942bf9632eba1409ba432cfcae3b7649c7 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 5 days Failing since 174809 2022-11-18 00:06:55 Z 4 days 13 attempts Testing same since 174896 2022-11-21 20:43:42 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Daniel P. Smith Jan Beulich Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 broken test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim broken test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd broken test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-i386-xl-pvshim broken broken-job test-amd64-amd64-xl-credit2 broken broken-job test-amd64-amd64-libvirt-vhd broken broken-step test-amd64-amd64-xl-credit2 host-install(5) broken-step test-amd64-amd64-libvirt-vhd host-install(5) broken-step test-amd64-i386-xl-pvshim host-install(5) broken-job test-amd64-amd64-xl-pvhv2-amd broken Not pushing. ------------------------------------------------------------ commit 345135942bf9632eba1409ba432cfcae3b7649c7 Author: Andrew Cooper Date: Mon Nov 21 12:46:39 2022 +0000 xen/flask: Wire up XEN_DOMCTL_{get,set}_paging_mempool_size These were overlooked in the original patch, and noticed by OSSTest which does run some Flask tests. Fixes: 22b20bd98c02 ("xen: Introduce non-broken hypercalls for the paging mempool size") Suggested-by: Daniel Smith Signed-off-by: Andrew Cooper Reviewed-by: Jason Andryuk Acked-by: Daniel P. Smith Release-acked-by: Henry Wang commit 8746d3e2550b142cd751ca7a041a38789a020d2b Author: Andrew Cooper Date: Fri Nov 18 16:53:45 2022 +0000 tools/libxl: Fixes to libxl__domain_set_paging_mempool_size() The error message accidentally printed the bytes value as if it were kB. Furthermore, both b_info.shadow_memkb and shadow_mem are uint64_t, meaning there is a risk of overflow if the user specified a stupidly large value in the vm.cfg file. Check and reject such a condition. Fixes: 7c3bbd940dd8 ("xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls") Signed-off-by: Andrew Cooper Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit 8cdfbf95b19c01fbb741c41d5ea5a94f8823964c Author: Anthony PERARD Date: Mon Nov 21 12:23:01 2022 +0100 libs/light: Propagate libxl__arch_domain_create() return code Commit 34990446ca91 started to overwrite the `rc` value from libxl__arch_domain_create(), thus error aren't propagated anymore. Check `rc` value before doing the next thing. Fixes: 34990446ca91 ("libxl: don't ignore the return value from xc_cpuid_apply_policy") Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD Reviewed-by: Jason Andryuk Release-acked-by: Henry Wang commit 57f07cca82521088cca0c1fc36d6ffd06cb7de80 Author: Roger Pau Monné Date: Mon Nov 21 12:21:51 2022 +0100 efifb: ignore frame buffer with invalid configuration On one of my boxes when the HDMI cable is not plugged in the FrameBufferBase of the EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE structure is set to 0 by the firmware (while some of the other fields looking plausible). Such (bogus address) ends up mapped in vesa_init(), and since it overlaps with a RAM region the whole system goes down pretty badly, see: (XEN) vesafb: framebuffer at 0x0000000000000000, mapped to 0xffff82c000201000, using 35209k, total 35209k (XEN) vesafb: mode is 0x37557x32, linelength=960, font 8x16 (XEN) vesafb: Truecolor: size=8:8:8:8, shift=24:0:8:16 (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) �ERROR: Class:0; Subclass:0; Operation: 0 ERROR: No ConOut ERROR: No ConIn Do like Linux and prevent using the EFI Frame Buffer if the base address is 0. This is inline with the logic in Linuxes fb_base_is_valid() function at drivers/video/fbdev/efifb.c v6.0.9. See also Linux commit 133bb070e94ab41d750c6f2160c8843e46f11b78 for further reference. Also prevent using Frame Buffers that have a 0 height or width, as those are also invalid. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Release-acked-by: Henry Wang commit db8fa01c61db0317a9ee947925226234c65d48e8 Author: Andrew Cooper Date: Thu Oct 20 12:14:30 2022 +0100 xen/arm: Correct the p2m pool size calculations Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit bd87315a603bf25e869e6293f7db7b1024d67999 Author: Andrew Cooper Date: Thu Oct 20 12:13:46 2022 +0100 tools/tests: Unit test for paging mempool size Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit 22b20bd98c025e06525410e3ab3494d5e63489f7 Author: Andrew Cooper Date: Fri Oct 21 14:13:00 2022 +0100 xen: Introduce non-broken hypercalls for the paging mempool size The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 Author: Andrew Cooper Date: Mon Nov 14 21:47:59 2022 +0000 x86/hvm: Revert per-domain APIC acceleration support I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisted in due course. Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Fixes: 6b2b9b340509 ("x86: report Interrupt Controller Virtualization capabilities") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Tue Nov 22 23:25:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 22 Nov 2022 23:25:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447340.703450 (Exim 4.92) (envelope-from ) id 1oxce5-0002os-6u; Tue, 22 Nov 2022 23:25:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447340.703450; Tue, 22 Nov 2022 23:25:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxce5-0002ol-4C; Tue, 22 Nov 2022 23:25:41 +0000 Received: by outflank-mailman (input) for mailman id 447340; Tue, 22 Nov 2022 23:25:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxce3-0002ob-F5; Tue, 22 Nov 2022 23:25:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxce3-0003Oz-CS; Tue, 22 Nov 2022 23:25:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxce2-00082Z-Ub; Tue, 22 Nov 2022 23:25:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxce2-0004Qs-Tx; Tue, 22 Nov 2022 23:25:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4zCt4bfEX0iFKZ4YJOdEaBTqi6tZkdBQGBx8SvIvrXk=; b=w5ur11kY2lHN9/qQcsj9889Khh E0Is7ReEVdzOE1IC4DRgudHKYiy5vsrcK03gFvyj/5smQ5B8qnNh70CaMu2FUwVYIy3HsR2XF4X4d IWHeuzw6rZSoqcavx8oDDm8ZhWrWxeARXaY8Srz1pajU4iX63BELsq41q9o3EBaLbM7o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [seabios test] 174925: tolerable FAIL - PUSHED X-Osstest-Failures: seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: seabios=85d56f812f4d020b3b486682aff07d9f4a4c60fe X-Osstest-Versions-That: seabios=46de2eec93bffa0706e6229c0da2919763c8eb04 From: osstest service owner Date: Tue, 22 Nov 2022 23:25:38 +0000 flight 174925 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/174925/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171687 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171687 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171687 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171687 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171687 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: seabios 85d56f812f4d020b3b486682aff07d9f4a4c60fe baseline version: seabios 46de2eec93bffa0706e6229c0da2919763c8eb04 Last test of basis 171687 2022-07-19 11:10:32 Z 126 days Testing same since 174925 2022-11-22 18:40:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andy Pei Gerd Hoffmann Michael S. Tsirkin Paul Menzel Xiaofei Lee jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/seabios.git 46de2ee..85d56f8 85d56f812f4d020b3b486682aff07d9f4a4c60fe -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Nov 23 00:11:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 00:11:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447351.703468 (Exim 4.92) (envelope-from ) id 1oxdM8-0000aV-4P; Wed, 23 Nov 2022 00:11:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447351.703468; Wed, 23 Nov 2022 00:11:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxdM8-0000aO-1N; Wed, 23 Nov 2022 00:11:12 +0000 Received: by outflank-mailman (input) for mailman id 447351; Wed, 23 Nov 2022 00:11:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxdM6-0000aI-BX for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 00:11:10 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 53c171fe-6ac3-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 01:11:07 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 92A88B81E1D; Wed, 23 Nov 2022 00:11:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2418FC433D6; Wed, 23 Nov 2022 00:11:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53c171fe-6ac3-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669162265; bh=16YUw6VZ5kBcfgvsMnUTtSYMMd/qd/lp9/vM4wuQzUA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=eOcN6v8H3txIc07pt51SQhmhiYQDdULtoeXnQy39dDhq7rSBI0TfP0m4CD2UKcyQr E7bdVFirDNoXU2HMSYQ2suXZACcDWrxMhF5dvIME3MzYjdbm5MyT97T/izLPxHOAOf SZFrHvEDPAHxuf1L8SvCR/rNKP2wF7AsaAo76lancNFFUrdxdN8Bw+mjOI3JzUvsO8 9peJp9oT7IEkrxVRtIzpOjBHPiW8Z/9GV7dJQyI+/W2JCJyPJIgCO6qf6kN1wx8+M9 NpkdKlEuKoxYvMBARB0LJPEeWmp7lNiIK7gYYIYV0nDnCIbl4UBTjM6hOB2sFj7Yf/ awDNJ91qSWG0A== Date: Tue, 22 Nov 2022 16:11:00 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Vipul Suneja cc: Stefano Stabellini , xen-devel@lists.xenproject.org, oleksandr_andrushchenko@epam.com, oleksandr_tyshchenko@epam.com, jgross@suse.com, boris.ostrovsky@oracle.com, Bertrand.Marquis@arm.com Subject: Re: Porting Xen in raspberry pi4B In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-38028952-1669162265=:1049131" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-38028952-1669162265=:1049131 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Hi Vipul, I cannot spot any issue in the configuration, in particual you have: CONFIG_XEN_FBDEV_FRONTEND=y which is what you need. The only thing I can suggest is to add printks to the Linux frontend driver (the one running in the domU) which is drivers/video/fbdev/xen-fbfront.c and printfs to the QEMU backend (running in Dom0) which is hw/display/xenfb.c to figure out what is going on. Alternatively, you can setup PV network with the domU, such as: vif=[''] and then run x11 and a x11vnc server in your domU. You should be able to connect to it using vncviewer at the network IP of your domU. Basically you are skipping the problem because instead of using the PV framebuffer protocol, you just use VNC over the network with the domU. Cheers, Stefano On Tue, 22 Nov 2022, Vipul Suneja wrote: > Hi Stefano, > Thanks for the support! > > Looks like I have tried all the combinations & possible ways to get display up but failed. Is there any document or pdf for porting xen on > raspberrypi4. > I could find lot's of links telling the same but couldn't see any official user guide or document from the xen community on the same. If > there is something to refer  > to please share with me. > I am attaching the kernel configuration file also, just take a look if i have missed anything. > Any other suggestions or input from your end could be really helpful? > > Regards, > Vipul Kumar > > On Fri, Nov 11, 2022 at 6:40 AM Stefano Stabellini wrote: > Hi Vipul, > > Sorry for the late reply. From the earlier logs that you sent, it looks > like everything should be working correctly. Specifically: > >      vfb = "" >       1 = "" >        0 = "" >         frontend = "/local/domain/1/device/vfb/0" >         frontend-id = "1" >         online = "1" >         state = "4" >         vnc = "1" >         vnclisten = "127.0.0.1" >         vncdisplay = "0" >         vncunused = "1" >         sdl = "0" >         opengl = "0" >         feature-resize = "1" >         hotplug-status = "connected" >         request-update = "1" > > state "4" means "connected". So I would expect that you should be able > to connect to the vnc server using vncviewer. You might not see anything > (black screen) but you should definitely be able to connect. > > I wouldn't try to launch x11 in the guest just yet. fbcon in Linux is > enough to render something on the screen. You should be able to see the > Linux text-based console rendered graphically, connecting to it via vnc. > > Sorry for the basic question, but have you tried all the following? > > vncviewer 127.0.0.1:0 > vncviewer 127.0.0.1:1 > vncviewer 127.0.0.1:2 > vncviewer 127.0.0.1:5900 > vncviewer 127.0.0.1:5901 > vncviewer 127.0.0.1:5902 > > Given that from the xenstore-ls logs everything seems to work correctly > I am not sure what else to suggest. You might have to add printf to QEMU > ui/vnc.c and hw/display/xenfb.c to see what is going wrong. > > Cheers, > > Stefano > > > On Mon, 7 Nov 2022, Vipul Suneja wrote: > > Hi Stefano, > > Thanks! > > > > Any input further on "xenstore-ls" logs? > > > > I am trying to run the x0vncserver & x11vnc server manually on guest machine(xen_guest_image_minimal) image but it's failing > with the below > > error. > > > > root@raspberrypi4-64:/usr/bin# x0vncserver > > x0vncserver: unable to open display "" > > root@raspberrypi4-64:/usr/bin# > > root@raspberrypi4-64:/usr/bin# x11vnc > > ############################################################### > > #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@# > > #@                                                           @# > > #@  **  WARNING  **  WARNING  **  WARNING  **  WARNING  **   @# > > #@                                                           @# > > #@        YOU ARE RUNNING X11VNC WITHOUT A PASSWORD!!        @# > > #@                                                           @# > > #@  This means anyone with network access to this computer   @# > > #@  may be able to view and control your desktop.            @# > > #@                                                           @# > > #@ >>> If you did not mean to do this Press CTRL-C now!! <<< @# > > #@                                                           @# > > #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@# > > #@                                                           @# > > #@  You can create an x11vnc password file by running:       @# > > #@                                                           @# > > #@       x11vnc -storepasswd password /path/to/passfile      @# > > #@  or   x11vnc -storepasswd /path/to/passfile               @# > > #@  or   x11vnc -storepasswd                                 @# > > #@                                                           @# > > #@  (the last one will use ~/.vnc/passwd)                    @# > > #@                                                           @# > > #@  and then starting x11vnc via:                            @# > > #@                                                           @# > > #@      x11vnc -rfbauth /path/to/passfile                    @# > > #@                                                           @# > > #@  an existing ~/.vnc/passwd file from another VNC          @# > > #@  application will work fine too.                          @# > > #@                                                           @# > > #@  You can also use the -passwdfile or -passwd options.     @# > > #@  (note -passwd is unsafe if local users are not trusted)  @# > > #@                                                           @# > > #@  Make sure any -rfbauth and -passwdfile password files    @# > > #@  cannot be read by untrusted users.                       @# > > #@                                                           @# > > #@  Use x11vnc -usepw to automatically use your              @# > > #@  ~/.vnc/passwd or ~/.vnc/passwdfile password files.       @# > > #@  (and prompt you to create ~/.vnc/passwd if neither       @# > > #@  file exists.)  Under -usepw, x11vnc will exit if it      @# > > #@  cannot find a password to use.                           @# > > #@                                                           @# > > #@                                                           @# > > #@  Even with a password, the subsequent VNC traffic is      @# > > #@  sent in the clear.  Consider tunnelling via ssh(1):      @# > > #@                                                           @# > > #@    http://www.karlrunge.com/x11vnc/#tunnelling            @# > > #@                                                           @# > > #@  Or using the x11vnc SSL options: -ssl and -stunnel       @# > > #@                                                           @# > > #@  Please Read the documentation for more info about        @# > > #@  passwords, security, and encryption.                     @# > > #@                                                           @# > > #@    http://www.karlrunge.com/x11vnc/faq.html#faq-passwd    @# > > #@                                                           @# > > #@  To disable this warning use the -nopw option, or put     @# > > #@  'nopw' on a line in your ~/.x11vncrc file.               @# > > #@                                                           @# > > #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@# > > ############################################################### > > 09/03/2018 12:58:41 x11vnc version: 0.9.16 lastmod: 2019-01-05  pid: 424 > > 09/03/2018 12:58:41 XOpenDisplay("") failed. > > 09/03/2018 12:58:41 Trying again with XAUTHLOCALHOSTNAME=localhost ... > > 09/03/2018 12:58:41 > > 09/03/2018 12:58:41 *** XOpenDisplay failed. No -display or DISPLAY. > > 09/03/2018 12:58:41 *** Trying ":0" in 4 seconds.  Press Ctrl-C to abort. > > 09/03/2018 12:58:41 *** 1 2 3 4 > > 09/03/2018 12:58:45 XOpenDisplay(":0") failed. > > 09/03/2018 12:58:45 Trying again with XAUTHLOCALHOSTNAME=localhost ... > > 09/03/2018 12:58:45 XOpenDisplay(":0") failed. > > 09/03/2018 12:58:45 Trying again with unset XAUTHLOCALHOSTNAME ... > > 09/03/2018 12:58:45 > > > > 09/03/2018 12:58:45 *************************************** > > 09/03/2018 12:58:45 *** XOpenDisplay failed (:0) > > > > *** x11vnc was unable to open the X DISPLAY: ":0", it cannot continue. > > *** There may be "Xlib:" error messages above with details about the failure. > > > > Some tips and guidelines: > > > > ** An X server (the one you wish to view) must be running before x11vnc is > >    started: x11vnc does not start the X server.  (however, see the -create > >    option if that is what you really want). > > > > ** You must use -display , -OR- set and export your $DISPLAY > >    environment variable to refer to the display of the desired X server. > >  - Usually the display is simply ":0" (in fact x11vnc uses this if you forget > >    to specify it), but in some multi-user situations it could be ":1", ":2", > >    or even ":137".  Ask your administrator or a guru if you are having > >    difficulty determining what your X DISPLAY is. > > > > ** Next, you need to have sufficient permissions (Xauthority) > >    to connect to the X DISPLAY.   Here are some Tips: > > > >  - Often, you just need to run x11vnc as the user logged into the X session. > >    So make sure to be that user when you type x11vnc. > >  - Being root is usually not enough because the incorrect MIT-MAGIC-COOKIE > >    file may be accessed.  The cookie file contains the secret key that > >    allows x11vnc to connect to the desired X DISPLAY. > >  - You can explicitly indicate which MIT-MAGIC-COOKIE file should be used > >    by the -auth option, e.g.: > >        x11vnc -auth /home/someuser/.Xauthority -display :0 > >        x11vnc -auth /tmp/.gdmzndVlR -display :0 > >    you must have read permission for the auth file. > >    See also '-auth guess' and '-findauth' discussed below. > > > > ** If NO ONE is logged into an X session yet, but there is a greeter login > >    program like "gdm", "kdm", "xdm", or "dtlogin" running, you will need > >    to find and use the raw display manager MIT-MAGIC-COOKIE file. > >    Some examples for various display managers: > > > >      gdm:     -auth /var/gdm/:0.Xauth > >               -auth /var/lib/gdm/:0.Xauth > >      kdm:     -auth /var/lib/kdm/A:0-crWk72 > >               -auth /var/run/xauth/A:0-crWk72 > >      xdm:     -auth /var/lib/xdm/authdir/authfiles/A:0-XQvaJk > >      dtlogin: -auth /var/dt/A:0-UgaaXa > > > >    Sometimes the command "ps wwwwaux | grep auth" can reveal the file location. > > > >    Starting with x11vnc 0.9.9 you can have it try to guess by using: > > > >               -auth guess > > > >    (see also the x11vnc -findauth option.) > > > >    Only root will have read permission for the file, and so x11vnc must be run > >    as root (or copy it).  The random characters in the filenames will of course > >    change and the directory the cookie file resides in is system dependent. > > > > See also: http://www.karlrunge.com/x11vnc/faq.html > > > > Regards, > > Vipul Kumar > > > > On Thu, Nov 3, 2022 at 10:27 PM Vipul Suneja wrote: > >       Hi Stefano, > > Thanks! > > > > I used xen-guest-image-minimal(simple console based image) as a guest with fbcon & fbdev enabled in kernel configurations but > still > > the same error can't open the display. > > below are the outcome of "xenstore-ls": > > > > root@raspberrypi4-64:~/guest1# xenstore-ls > > tool = "" > >  xenstored = "" > > local = "" > >  domain = "" > >   0 = "" > >    control = "" > >     feature-poweroff = "1" > >     feature-reboot = "1" > >    domid = "0" > >    name = "Domain-0" > >    device-model = "" > >     0 = "" > >      backends = "" > >       console = "" > >       vkbd = "" > >       vfb = "" > >       qnic = "" > >      state = "running" > >     1 = "" > >      backends = "" > >       console = "" > >       vkbd = "" > >       vfb = "" > >       qnic = "" > >      state = "running" > >    backend = "" > >     vbd = "" > >      1 = "" > >       51712 = "" > >        frontend = "/local/domain/1/device/vbd/51712" > >        params = "/home/root/guest2/xen-guest-image-minimal-raspberrypi4-64.ext3" > >        script = "/etc/xen/scripts/block" > >        frontend-id = "1" > >        online = "1" > >        removable = "0" > >        bootable = "1" > >        state = "4" > >        dev = "xvda" > >        type = "phy" > >        mode = "w" > >        device-type = "disk" > >        discard-enable = "1" > >        feature-max-indirect-segments = "256" > >        multi-queue-max-queues = "4" > >        max-ring-page-order = "4" > >        node = "/dev/loop0" > >        physical-device = "7:0" > >        physical-device-path = "/dev/loop0" > >        hotplug-status = "connected" > >        feature-flush-cache = "1" > >        discard-granularity = "4096" > >        discard-alignment = "0" > >        discard-secure = "0" > >        feature-discard = "1" > >        feature-barrier = "1" > >        feature-persistent = "1" > >        sectors = "1794048" > >        info = "0" > >        sector-size = "512" > >        physical-sector-size = "512" > >     vfb = "" > >      1 = "" > >       0 = "" > >        frontend = "/local/domain/1/device/vfb/0" > >        frontend-id = "1" > >        online = "1" > >        state = "4" > >        vnc = "1" > >        vnclisten = "127.0.0.1" > >        vncdisplay = "0" > >        vncunused = "1" > >        sdl = "0" > >        opengl = "0" > >        feature-resize = "1" > >        hotplug-status = "connected" > >        request-update = "1" > >     vkbd = "" > >      1 = "" > >       0 = "" > >        frontend = "/local/domain/1/device/vkbd/0" > >        frontend-id = "1" > >        online = "1" > >        state = "4" > >        feature-abs-pointer = "1" > >        feature-raw-pointer = "1" > >        hotplug-status = "connected" > >     console = "" > >      1 = "" > >       0 = "" > >        frontend = "/local/domain/1/console" > >        frontend-id = "1" > >        online = "1" > >        state = "1" > >        protocol = "vt100" > >     vif = "" > >      1 = "" > >       0 = "" > >        frontend = "/local/domain/1/device/vif/0" > >        frontend-id = "1" > >        online = "1" > >        state = "4" > >        script = "/etc/xen/scripts/vif-bridge" > >        mac = "e4:5f:01:cd:7b:dd" > >        bridge = "xenbr0" > >        handle = "0" > >        type = "vif" > >        hotplug-status = "connected" > >        feature-sg = "1" > >        feature-gso-tcpv4 = "1" > >        feature-gso-tcpv6 = "1" > >        feature-ipv6-csum-offload = "1" > >        feature-rx-copy = "1" > >        feature-xdp-headroom = "1" > >        feature-rx-flip = "0" > >        feature-multicast-control = "1" > >        feature-dynamic-multicast-control = "1" > >        feature-split-event-channels = "1" > >        multi-queue-max-queues = "4" > >        feature-ctrl-ring = "1" > >   1 = "" > >    vm = "/vm/d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f" > >    name = "guest2" > >    cpu = "" > >     0 = "" > >      availability = "online" > >     1 = "" > >      availability = "online" > >    memory = "" > >     static-max = "2097152" > >     target = "2097152" > >     videoram = "0" > >    device = "" > >     suspend = "" > >      event-channel = "" > >     vbd = "" > >      51712 = "" > >       backend = "/local/domain/0/backend/vbd/1/51712" > >       backend-id = "0" > >       state = "4" > >       virtual-device = "51712" > >       device-type = "disk" > >       multi-queue-num-queues = "2" > >       queue-0 = "" > >        ring-ref = "8" > >        event-channel = "4" > >       queue-1 = "" > >        ring-ref = "9" > >        event-channel = "5" > >       protocol = "arm-abi" > >       feature-persistent = "1" > >     vfb = "" > >      0 = "" > >       backend = "/local/domain/0/backend/vfb/1/0" > >       backend-id = "0" > >       state = "4" > >       page-ref = "275022" > >       event-channel = "3" > >       protocol = "arm-abi" > >       feature-update = "1" > >     vkbd = "" > >      0 = "" > >       backend = "/local/domain/0/backend/vkbd/1/0" > >       backend-id = "0" > >       state = "4" > >       request-abs-pointer = "1" > >       page-ref = "275322" > >       page-gref = "1284" > >       event-channel = "10" > >     vif = "" > >      0 = "" > >       backend = "/local/domain/0/backend/vif/1/0" > >       backend-id = "0" > >       state = "4" > >       handle = "0" > >       mac = "e4:5f:01:cd:7b:dd" > >       mtu = "1500" > >       xdp-headroom = "0" > >       multi-queue-num-queues = "2" > >       queue-0 = "" > >        tx-ring-ref = "1280" > >        rx-ring-ref = "1281" > >        event-channel-tx = "6" > >        event-channel-rx = "7" > >       queue-1 = "" > >        tx-ring-ref = "1282" > >        rx-ring-ref = "1283" > >        event-channel-tx = "8" > >        event-channel-rx = "9" > >       request-rx-copy = "1" > >       feature-rx-notify = "1" > >       feature-sg = "1" > >       feature-gso-tcpv4 = "1" > >       feature-gso-tcpv6 = "1" > >       feature-ipv6-csum-offload = "1" > >    control = "" > >     shutdown = "" > >     feature-poweroff = "1" > >     feature-reboot = "1" > >     feature-suspend = "" > >     sysrq = "" > >     platform-feature-multiprocessor-suspend = "1" > >     platform-feature-xs_reset_watches = "1" > >    data = "" > >    drivers = "" > >    feature = "" > >    attr = "" > >    error = "" > >    domid = "1" > >    store = "" > >     port = "1" > >     ring-ref = "233473" > >    console = "" > >     backend = "/local/domain/0/backend/console/1/0" > >     backend-id = "0" > >     limit = "1048576" > >     type = "xenconsoled" > >     output = "pty" > >     tty = "/dev/pts/1" > >     port = "2" > >     ring-ref = "233472" > >     vnc-listen = "127.0.0.1" > >     vnc-port = "5900" > >    image = "" > >     device-model-pid = "788" > > vm = "" > >  d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f = "" > >   name = "guest2" > >   uuid = "d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f" > >   start_time = "1520600274.27" > > libxl = "" > >  1 = "" > >   device = "" > >    vbd = "" > >     51712 = "" > >      frontend = "/local/domain/1/device/vbd/51712" > >      backend = "/local/domain/0/backend/vbd/1/51712" > >      params = "/home/root/guest2/xen-guest-image-minimal-raspberrypi4-64.ext3" > >      script = "/etc/xen/scripts/block" > >      frontend-id = "1" > >      online = "1" > >      removable = "0" > >      bootable = "1" > >      state = "1" > >      dev = "xvda" > >      type = "phy" > >      mode = "w" > >      device-type = "disk" > >      discard-enable = "1" > >    vfb = "" > >     0 = "" > >      frontend = "/local/domain/1/device/vfb/0" > >      backend = "/local/domain/0/backend/vfb/1/0" > >      frontend-id = "1" > >      online = "1" > >      state = "1" > >      vnc = "1" > >      vnclisten = "127.0.0.1" > >      vncdisplay = "0" > >      vncunused = "1" > >      sdl = "0" > >      opengl = "0" > >    vkbd = "" > >     0 = "" > >      frontend = "/local/domain/1/device/vkbd/0" > >      backend = "/local/domain/0/backend/vkbd/1/0" > >      frontend-id = "1" > >      online = "1" > >      state = "1" > >    console = "" > >     0 = "" > >      frontend = "/local/domain/1/console" > >      backend = "/local/domain/0/backend/console/1/0" > >      frontend-id = "1" > >      online = "1" > >      state = "1" > >      protocol = "vt100" > >    vif = "" > >     0 = "" > >      frontend = "/local/domain/1/device/vif/0" > >      backend = "/local/domain/0/backend/vif/1/0" > >      frontend-id = "1" > >      online = "1" > >      state = "1" > >      script = "/etc/xen/scripts/vif-bridge" > >      mac = "e4:5f:01:cd:7b:dd" > >      bridge = "xenbr0" > >      handle = "0" > >      type = "vif" > >      hotplug-status = "" > >   type = "pvh" > >   dm-version = "qemu_xen" > > root@raspberrypi4-64:~/guest1# > > > > Any input as per above? Looking forward to hearing from you. > > > > Regards, > > Vipul Kumar > > > > On Wed, Oct 26, 2022 at 5:21 AM Stefano Stabellini wrote: > >       Hi Vipul, > > > >       If you look at the QEMU logs, it says: > > > >       VNC server running on 127.0.0.1:5900 > > > >       That is the VNC server you need to connect to. So in theory: > > > >         vncviewer 127.0.0.1:5900 > > > >       should work correctly. > > > > > >       If you have: > > > >         vfb = ["type=vnc"] > > > >       in your xl config file and you have "fbdev" in your Linux guest, it > >       should work. > > > >       If you connect to the VNC server but you get a black screen, it might be > >       a guest configuration issue. I would try with a simpler guest, text only > >       (no X11, no Wayland) and enable the fbdev console (fbcon). See > >       Documentation/fb/fbcon.rst in Linux. You should be able to see a > >       graphical console over VNC. > > > >       If that works, then you know that the fbdev kernel driver (xen-fbfront) > >       works correctly. > > > >       If it doesn't work, the output of "xenstore-ls" would be interesting. > > > >       Cheers, > > > >       Stefano > > > > > >       On Wed, 19 Oct 2022, Vipul Suneja wrote: > >       > Hi Stefano, > >       > > >       > Thanks for the response! > >       > > >       > I am following the same link you shared from the beginning. Tried the command "vncviewer localhost:0" in DOM0 but > same > >       issue "Can't open > >       > display", below are the logs: > >       > > >       > root@raspberrypi4-64:~# vncviewer localhost:0 > >       > > >       > TigerVNC Viewer 64-bit v1.11.0 > >       > Built on: 2020-09-08 12:16 > >       > Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst) > >       > See https://www.tigervnc.org for information on TigerVNC. > >       > Can't open display: > >       > > >       > Below are the netstat logs, i couldn't see anything running at port 5900 or 5901: > >       > > >       > root@raspberrypi4-64:~# netstat -tuwx > >       > Active Internet connections (w/o servers) > >       > Proto Recv-Q Send-Q Local Address           Foreign Address         State       > >       > tcp        0    164 192.168.1.39:ssh        192.168.1.38:37472      ESTABLISHED > >       > Active UNIX domain sockets (w/o servers) > >       > Proto RefCnt Flags       Type       State         I-Node Path > >       > unix  8      [ ]         DGRAM      CONNECTED      10565 /dev/log > >       > unix  3      [ ]         STREAM     CONNECTED      10891 /var/run/xenstored/socket > >       > unix  3      [ ]         STREAM     CONNECTED      13791 > >       > unix  3      [ ]         STREAM     CONNECTED      10843 /var/run/xenstored/socket > >       > unix  3      [ ]         STREAM     CONNECTED      10573 /var/run/xenstored/socket > >       > unix  2      [ ]         DGRAM      CONNECTED      14510 > >       > unix  3      [ ]         STREAM     CONNECTED      13249 > >       > unix  2      [ ]         DGRAM      CONNECTED      13887 > >       > unix  2      [ ]         DGRAM      CONNECTED      10599 > >       > unix  3      [ ]         STREAM     CONNECTED      14005 > >       > unix  3      [ ]         STREAM     CONNECTED      13258 > >       > unix  3      [ ]         STREAM     CONNECTED      13248 > >       > unix  3      [ ]         STREAM     CONNECTED      14003 > >       > unix  3      [ ]         STREAM     CONNECTED      10572 /var/run/xenstored/socket > >       > unix  3      [ ]         STREAM     CONNECTED      10786 /var/run/xenstored/socket > >       > unix  3      [ ]         DGRAM      CONNECTED      13186 > >       > unix  3      [ ]         STREAM     CONNECTED      10864 /var/run/xenstored/socket > >       > unix  3      [ ]         STREAM     CONNECTED      10812 /var/run/xenstored/socket > >       > unix  2      [ ]         DGRAM      CONNECTED      14083 > >       > unix  3      [ ]         STREAM     CONNECTED      10813 /var/run/xenstored/socket > >       > unix  3      [ ]         STREAM     CONNECTED      14068 > >       > unix  3      [ ]         STREAM     CONNECTED      13256 > >       > unix  3      [ ]         STREAM     CONNECTED      10571 /var/run/xenstored/socket > >       > unix  3      [ ]         STREAM     CONNECTED      10842 > >       > unix  3      [ ]         STREAM     CONNECTED      13985 > >       > unix  3      [ ]         DGRAM      CONNECTED      13185 > >       > unix  2      [ ]         STREAM     CONNECTED      13884 > >       > unix  2      [ ]         DGRAM      CONNECTED      14528 > >       > unix  2      [ ]         DGRAM      CONNECTED      13785 > >       > unix  3      [ ]         STREAM     CONNECTED      14034 > >       > > >       > Attaching xen log files of /var/log/xen. > >       > I didn't get the role of QEMU here because as mentioned earlier, I am porting in raspberrypi 4B. > >       > > >       > Regards, > >       > Vipul Kumar > >       > > >       > On Wed, Oct 19, 2022 at 12:43 AM Stefano Stabellini wrote: > >       >       It usually works the way it is described in the guide: > >       > > >       >      > >      >   https://www.virtuatopia.com/index.php?title=Configuring_a_VNC_based_Graphical_Console_for_a_Xen_Paravirtualized_domainU_Guest > >       > > >       >       You don't need to install any VNC-related server software because it is > >       >       already provided by Xen (to be precise it is provided by QEMU working > >       >       together with Xen.) > >       > > >       >       You only need the vnc client in dom0 so that you can connect, but you > >       >       could also run the vnc client outside from another host. So basically > >       >       the following should work when executed in Dom0 after creating DomU: > >       > > >       >         vncviewer localhost:0 > >       > > >       >       Can you attach the Xen and QEMU logs (/var/log/xen/*)? And also use > >       >       netstat -taunp to check if there is anything running at port 5900 or > >       >       5901? > >       > > >       >       Cheers, > >       > > >       >       Stefano > >       > > >       > > >       >       On Tue, 18 Oct 2022, Vipul Suneja wrote: > >       >       > Hi Stefano, > >       >       > > >       >       > Thanks for the response! > >       >       > > >       >       > I could install tigerVNC, x11vnc & libvncserver in Dom0 xen-image-minimal but only manage to install > >       libvncserver(couldn't > >       >       install tigervnc > >       >       > & x11vnc because of x11 > >       >       > support missing, it's wayland) in DOMU custom graphical image. I tried running vncviewer with IP address & > port > >       in dom0 to > >       >       access the domu > >       >       > graphical image display as per below commands. > >       >       >   > >       >       >  vncviewer 192.168.1.42:5901 > >       >       >   > >       >       >  But it showing can't open display, below are the logs: > >       >       >   > >       >       > root@raspberrypi4-64:~/guest1# vncviewer 192.168.1.42:5901 > >       >       > > >       >       > TigerVNC Viewer 64-bit v1.11.0 > >       >       > Built on: 2020-09-08 12:16 > >       >       > Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst) > >       >       > See https://www.tigervnc.org for information on TigerVNC. > >       >       > Can't open display: > >       >       > root@raspberrypi4-64:~/guest1# > >       >       > > >       >       > I am not exactly sure what the issue is but I thought only libvncserver in DOMU could work to get access but > it > >       did not > >       >       work.  > >       >       > If TigerVNC is the issue here then is there any other VNC source which could be installed for both x11 & > >       wayland supported > >       >       images? > >       >       > > >       >       > Regards, > >       >       > Vipul Kumar > >       >       > > >       >       > On Tue, Oct 18, 2022 at 2:40 AM Stefano Stabellini wrote: > >       >       >       VNC is typically easier to setup, because SDL needs extra libraries at > >       >       >       build time and runtime. If QEMU is built without SDL support it won't > >       >       >       start when you ask for SDL. > >       >       > > >       >       >       VNC should work with both x11 and wayland in your domU. It doesn't work > >       >       >       at the x11 level, it exposes a special fbdev device in your domU that > >       >       >       should work with: > >       >       >       - a graphical console in Linux domU > >       >       >       - x11 > >       >       >       - wayland (but I haven't tested this so I am not 100% sure about it) > >       >       > > >       >       >       When you say "it doesn't work", what do you mean? Do you get a black > >       >       >       window? > >       >       > > >       >       >       You need CONFIG_XEN_FBDEV_FRONTEND in Linux domU > >       >       >       (drivers/video/fbdev/xen-fbfront.c). I would try to get a graphical text > >       >       >       console up and running in your domU before attempting x11/wayland. > >       >       > > >       >       >       Cheers, > >       >       > > >       >       >       Stefano > >       >       > > >       >       >       On Mon, 17 Oct 2022, Vipul Suneja wrote: > >       >       >       > Hi, > >       >       >       > Thanks! > >       >       >       > > >       >       >       > I have ported xen minimal image as DOM0 & custom wayland GUI based image as DOMU in raspberry pi4B. I > >       am trying to > >       >       make GUI > >       >       >       display up > >       >       >       > for guest machine. I tried using sdl, included below line in guest.conf file > >       >       >       > vfb= [ 'sdl=1' ] > >       >       >       > > >       >       >       > But it is throwing below error: > >       >       >       > > >       >       >       > root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg > >       >       >       > Parsing config from guest1.cfg > >       >       >       > libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain 3:error on QMP socket: Connection reset by > >       peer > >       >       >       > libxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the QMP connection to > >       QEMU > >       >       >       > libxl: error: libxl_dm.c:3351:device_model_postconfig_done: Domain 3:Post DM startup configs failed, > >       rc=-26 > >       >       >       > libxl: error: libxl_create.c:1867:domcreate_devmodel_started: Domain 3:device model did not start: > -26 > >       >       >       > libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device Model already exited > >       >       >       > libxl: error: libxl_domain.c:1183:libxl__destroy_domid: Domain 3:Non-existant domain > >       >       >       > libxl: error: libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to destroy guest > >       >       >       > libxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain 3:Destruction of domain failed > >       >       >       > > >       >       >       > Another way is VNC, i could install tigervnc in DOM0 but same i couldn't in guest machine because it > >       doesn't support > >       >       >       x11(supports wayland > >       >       >       > only). I am completely blocked here, Need your support to enable the display up. > >       >       >       > Any alternative of VNC which could work in both x11 & wayland supported images? > >       >       >       > > >       >       >       > Any input on VNC, SDL or any other way to proceed on this? Looking forward to hearing from you. > >       >       >       > > >       >       >       > Regards, > >       >       >       > Vipul Kumar > >       >       > > >       >       > > >       >       > > >       > > >       > > >       > > > > > > > > > > --8323329-38028952-1669162265=:1049131-- From xen-devel-bounces@lists.xenproject.org Wed Nov 23 02:24:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 02:24:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447363.703488 (Exim 4.92) (envelope-from ) id 1oxfR6-0004dF-Ry; Wed, 23 Nov 2022 02:24:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447363.703488; Wed, 23 Nov 2022 02:24:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxfR6-0004d8-OB; Wed, 23 Nov 2022 02:24:28 +0000 Received: by outflank-mailman (input) for mailman id 447363; Wed, 23 Nov 2022 02:24:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxfR4-0004d2-RQ for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 02:24:27 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2061e.outbound.protection.outlook.com [2a01:111:f400:fe16::61e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f165baa7-6ad5-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 03:24:23 +0100 (CET) Received: from FR0P281CA0149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::16) by PAWPR08MB10089.eurprd08.prod.outlook.com (2603:10a6:102:365::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 02:24:21 +0000 Received: from VI1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:96:cafe::6c) by FR0P281CA0149.outlook.office365.com (2603:10a6:d10:96::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17 via Frontend Transport; Wed, 23 Nov 2022 02:24:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT049.mail.protection.outlook.com (100.127.144.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 23 Nov 2022 02:24:20 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Wed, 23 Nov 2022 02:24:19 +0000 Received: from 922f73f4658e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 39CB0E02-1254-48E0-85E7-F23B123741E1.1; Wed, 23 Nov 2022 02:24:09 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 922f73f4658e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 23 Nov 2022 02:24:09 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VE1PR08MB5776.eurprd08.prod.outlook.com (2603:10a6:800:1ac::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 02:24:07 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5857.017; Wed, 23 Nov 2022 02:24:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f165baa7-6ad5-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JS6MrGISxmUoUC8YMa7jOn+bYFflz9JjmR9/AWtQ6FI=; b=GEOXSCVrmhe1fgvxtoauUltvahUjRIJpaGLHhF/jL6nd4Mfb/mf/jLrZZkAJcF6PIHduofSRjCQAf54gvQLJF9rkKnl9qLedn7miooYiOWrWYTb3NyRkryo3DiHp3s6DKLn3iQMKHAn4jLInO30qf4ugE538xq0awCj+4T21BUY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NMetFAqFg443VIVPTkOumcbsW33mkov9+RjY9y7q4Lprw0wJVpQmW4aQnXi+sQ7rjDejuvxT6jLVGi0eZutQf6M2v8LHi6QnDhoFtcRNFu9bJOw6b9fg9vrUG4NM705GloKMZQAoffBbMJ5s2tJoZ9d9BQni367aYyMKSiYTaKf2AN8NSs2Hzlnfga73id8Du6nwmc+B8BTHCxZlUiXUDELhLsKecmXn+25ZDQn1vHEmbp4K4BuBBS2R1+VFpPRYcdyjSGAjRIgLMb03NISv9MyeSDzoltuRQrKvsQGUM3HM3BwsoAYZ2AZPmXfCpbK8YLFABPGCDwrN58wcv1d5LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JS6MrGISxmUoUC8YMa7jOn+bYFflz9JjmR9/AWtQ6FI=; b=b2qb08pxd3Z+pgUdA18xe7TbGKp5MI8cQEoxOovuiKrPhH0ZCNZXS1MXduM7AEtymWAPCPjiEwmPs19+CyDNte2IQ1Ku6arw1I/V4B/7turc6QJe1JSx9vmDNb3m8vPnz3Agsulj2JvyGem4E/QDnEsUujXMcAO0wJCPoKBLFizBXeGt+GA/Xe3nugHyre0SsSdkUt8+2Z6RTc4NV4zdLc0/SEnmuhHiRzbOqkTlgIQAzLXw4c2k33G34yiM+6zP69LTPNlqnKYzhtoVzUK8sBnmklL5xWxsvq92oliSqH/h6BISNRhuPpnDySyOSM0WYfKVIn9+X4hbJf0UR2viTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JS6MrGISxmUoUC8YMa7jOn+bYFflz9JjmR9/AWtQ6FI=; b=GEOXSCVrmhe1fgvxtoauUltvahUjRIJpaGLHhF/jL6nd4Mfb/mf/jLrZZkAJcF6PIHduofSRjCQAf54gvQLJF9rkKnl9qLedn7miooYiOWrWYTb3NyRkryo3DiHp3s6DKLn3iQMKHAn4jLInO30qf4ugE538xq0awCj+4T21BUY= From: Henry Wang To: Julien Grall , Bertrand Marquis , Michal Orzel CC: Xen developer discussion , Stefano Stabellini , Volodymyr Babchuk Subject: RE: [PATCH] docs/misc/arm: Update references to Linux kernel docs Thread-Topic: [PATCH] docs/misc/arm: Update references to Linux kernel docs Thread-Index: AQHY+0ODg1IOoey0002gCa5gqsUK/65Ep76AgAbDVQCAAGOFMA== Date: Wed, 23 Nov 2022 02:24:06 +0000 Message-ID: References: <20221118114554.20696-1-michal.orzel@amd.com> <31E1FFCF-F675-47D9-BCDB-5884F7360567@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 593AD10C17C2BD42BC7B4AC57012CBBB.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|VE1PR08MB5776:EE_|VI1EUR03FT049:EE_|PAWPR08MB10089:EE_ X-MS-Office365-Filtering-Correlation-Id: cec2bfa7-b3a2-467a-6cc9-08daccf9d414 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0XZRtXJ4VE5TpTLnriqe83NBEVBZyONd7vi8YeM6J9kS+NyDw/Z+M2cNIo0opCf9iWDVkJV7PPGeDsX6iScDWEGZhXgkxMti+hf545mEYMErYZfQLLym6xmERMXhu7OXWUAMbSne4XFn2jUxuQ0Zx1ASxGP0C8BQZOZFjFOrep3jHBNrEvwn0vNFuaTK7LZE2CIa1Zq50xzAaNz4ipIifePV5MGY1AeMoEEzY6Uu2FZ14yc9Q/qSIdIMytf3UXeSJFwRPPoA+GOmmEa2oPV6td9PRY/5ISmvQC+zWE2GIAiTY+XbRbqefsTAXv44BxEAWZJNUDVbU7LFYHDTPe1rj7E0k0cq+Mi9ob9/oXr+EkakxrVi2E+xgFiovhuA4QWKK6S2xihzMwaFXgieKryDw5YnpvsrKRFtMSTyZhxlhgQj/NLVqCqPy0pdniSrawzdPW9Zd7et+GxDuwfgE5BqTc0h0NajlbD1kN8nwoU9R2UJrgKReElvymmDTGK+1uQpZxIO3r3pANhANfzLKpdJsm5D1DKhnvAQfgnS7HlcXSIS8gjL9M4zchmispuN1fexMSo4rx6o8QHF+zn5vOeQG0/nS5qO/W5Iy/oCHpQBEDaLM/ozrvNF0nbrlsoEZNrpwOe6MsJQIZJnqzoD6855jcgjaclNj7ooS7cP+6DXdPcX7IEicNjUEwAzikmu1R3hl1rOCZTTovqMRj47y5b2dw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(366004)(376002)(451199015)(41300700001)(76116006)(52536014)(8936002)(54906003)(316002)(15650500001)(64756008)(66446008)(66946007)(5660300002)(66476007)(8676002)(66556008)(4326008)(86362001)(55016003)(6506007)(71200400001)(478600001)(83380400001)(38070700005)(26005)(110136005)(2906002)(7696005)(186003)(4744005)(9686003)(122000001)(38100700002)(53546011)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5776 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4fe9e270-610f-46ee-1c0e-08daccf9cbe0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k2fAJznZBQTlUlNd0uPoHnSj7y9CAacvOAVjK53kAQ48Q/efn9cUjTaqakPSkMLrqnjIrKIHKCxPgfcCCjITLx1BItVuJKLlduq3YsNboTwNu6z8CIalXLZ7MWXpud3f3djRs4F6fulckmn1ntcyGl8/4MAiSLQpvHBq5wtsnrsbLLHX0qRraoEl0bsD+gn25oj1+bD6V9d3tvFnKN1gArg6WQCwm74h2VCck/uanjr57ZV56i563Lh8PaKc6Vsr4ogVG7aoaok4cKFyX18k9USUDahuR2E0vpv04Vr4pPty9sZIpLCKuR20XQP/3XCtqMhI2YfXR6Y04FG/rQVH/yB3YI4A/wQO7CFVwQVqfuoMS83MUjVTXDuxxFWFX1JGI1R9zd2PgoY9HsJr3ZqJ2ToMsmTsR4CE/cvJRk+kmkjrmGJmZB2rxUP2PitwhN7xjgMWLyV9XSIKbdyeZRd7RhGZMf+y7KFPaIXIfnzV6AjG0OCxDuvTr4szaQB53cLz9UlACTGUtF0lJkx/RIaQ2WR62b1/CN92ljxxHhlLbPYDk5wG7mjg++Wp/OlPK87K/XrpAwPq4+UJCnqXWrGmSx5XAHtH281X+oKg3wWRuRlV8uk/1QiyRY1XaYi14v1yU+/781FnDGEj9X2uOLMqY/YjnBvNvWlATUXIokEGTTj/iU2rnZrt7tHsJxUmSwMhIny6LjtU3ZYp/viIW20MlQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(376002)(136003)(451199015)(46966006)(40470700004)(36840700001)(36860700001)(83380400001)(86362001)(8676002)(41300700001)(81166007)(8936002)(4744005)(356005)(4326008)(15650500001)(2906002)(40460700003)(70206006)(5660300002)(82310400005)(40480700001)(316002)(52536014)(26005)(7696005)(107886003)(55016003)(9686003)(6506007)(53546011)(47076005)(336012)(110136005)(70586007)(478600001)(54906003)(186003)(82740400003)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 02:24:20.2284 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cec2bfa7-b3a2-467a-6cc9-08daccf9d414 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10089 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGRvY3MvbWlz Yy9hcm06IFVwZGF0ZSByZWZlcmVuY2VzIHRvIExpbnV4IGtlcm5lbCBkb2NzDQo+IA0KPiAoKyBI ZW5yeSkNCg0KVGhhbmtzLg0KDQo+IA0KPiBIaSwNCj4gDQo+IE9uIDE4LzExLzIwMjIgMTM6MTAs IEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+ID4gSGkgTWljaGFsLA0KPiA+DQo+ID4+IE9uIDE4 IE5vdiAyMDIyLCBhdCAxMTo0NSwgTWljaGFsIE9yemVsIDxtaWNoYWwub3J6ZWxAYW1kLmNvbT4g d3JvdGU6DQo+ID4+DQo+ID4+IFNvbWUgdGltZSBhZ28sIExpbnV4IHN3aXRjaGVkIHRoZSBmb3Jt YXQgb2YgZG9jcyB0byBSZVNUIGFuZCB0aGUgZm9ybWF0DQo+ID4+IG9mIGRldmljZS10cmVlIGJp bmRpbmdzIHRvIGpzb24tc2NoZW1hLg0KPiA+Pg0KPiA+PiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWwg T3J6ZWwgPG1pY2hhbC5vcnplbEBhbWQuY29tPg0KPiA+IFJldmlld2VkLWJ5OiBCZXJ0cmFuZCBN YXJxdWlzIDxiZXJ0cmFuZC5tYXJxdWlzQGFybS5jb20+DQo+IA0KPiBUaGlzIGNvdWxkIHBvdGVu dGlhbGx5IGJlIGEgY2FuZGlkYXRlIGZvciA0LjE3IGFzIHRoaXMgaXMgY29ycmVjdGluZyB0aGUN Cj4gbGlua3MgaW4gdGhlIGRvY3MuIFNvIHJpc2sgZnJlZS4NCg0KQWdyZWVkLg0KDQo+IA0KPiBJ ZiB3ZSBoYXZlIG5vIG5ldyBidWcgZml4ZWQgcXVldWVkIGZvciA0LjE3LCB0aGVuIEkgY291bGQg YWRkIHRoZSBwYXRjaA0KPiBhZnRlciBicmFuY2hpbmcuDQoNClNvdW5kcyBnb29kIHRvIG1lLCBp ZiB5b3Ugd2FudCB0byBkbyB0aGF0Og0KDQpSZWxlYXNlLWFja2VkLWJ5OiBIZW5yeSBXYW5nIDxI ZW5yeS5XYW5nQGFybS5jb20+DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCg0KPiANCj4gQ2hl ZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 23 03:09:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 03:09:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447368.703501 (Exim 4.92) (envelope-from ) id 1oxg8W-0000vM-7N; Wed, 23 Nov 2022 03:09:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447368.703501; Wed, 23 Nov 2022 03:09:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxg8W-0000vF-4V; Wed, 23 Nov 2022 03:09:20 +0000 Received: by outflank-mailman (input) for mailman id 447368; Wed, 23 Nov 2022 03:09:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxg8U-0000v5-TA; Wed, 23 Nov 2022 03:09:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxg8U-0007YO-Ne; Wed, 23 Nov 2022 03:09:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxg8U-00040u-Gj; Wed, 23 Nov 2022 03:09:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxg8U-0004LY-GD; Wed, 23 Nov 2022 03:09:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rF2yOf5efybT+I9frwoEzWDTlBHNR2vLXEAOGLNGYIE=; b=en3yJ5SfhNu+6iDPDKlGDKJzds 25NPHTo9c4e4vDSpDyr7jRdpG+7+HbfrmKG2fZMljp+tESXBi5WAmlGceaqJcpxXd8+l2IdVxq4F7 0G8UZH+m+4BhVEMcheto4ygXY9RbYJ7NNqRJ70HRU9rorfnhIJk8khXArnwvEf8AAoNI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174923: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=16a550bdc0e49fcda0e6a6c55d648700ad33c8a4 X-Osstest-Versions-That: qemuu=6d71357a3b651ec9db126e4862b77e13165427f5 From: osstest service owner Date: Wed, 23 Nov 2022 03:09:18 +0000 flight 174923 qemu-mainline real [real] flight 174933 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174923/ http://logs.test-lab.xenproject.org/osstest/logs/174933/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 174933-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174899 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174899 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174899 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174899 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174899 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174899 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174899 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174899 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: qemuu 16a550bdc0e49fcda0e6a6c55d648700ad33c8a4 baseline version: qemuu 6d71357a3b651ec9db126e4862b77e13165427f5 Last test of basis 174899 2022-11-21 21:37:32 Z 1 days Testing same since 174923 2022-11-22 17:38:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Ani Sinha Cédric Le Goater Igor Mammedov Jason Wang John Snow Michael S. Tsirkin Peter Maydell Raphael Norwitz Song Gao Stefan Hajnoczi Stefan Weil Stefano Garzarella Xiaojuan Yang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 6d71357a3b..16a550bdc0 16a550bdc0e49fcda0e6a6c55d648700ad33c8a4 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Nov 23 04:03:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 04:03:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447381.703552 (Exim 4.92) (envelope-from ) id 1oxgzE-0008TZ-5g; Wed, 23 Nov 2022 04:03:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447381.703552; Wed, 23 Nov 2022 04:03:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxgzE-0008TS-2q; Wed, 23 Nov 2022 04:03:48 +0000 Received: by outflank-mailman (input) for mailman id 447381; Wed, 23 Nov 2022 04:03:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxgzC-0008AS-Bx for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 04:03:46 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d341c5b7-6ae3-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 05:03:45 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 655A71477; Tue, 22 Nov 2022 20:03:51 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C8CB23F587; Tue, 22 Nov 2022 20:03:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d341c5b7-6ae3-11ed-8fd2-01056ac49cbb From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Julien Grall , Jan Beulich , George Dunlap , Community Manager Subject: [PATCH v4 3/3] CHANGELOG: Start new "unstable" section Date: Wed, 23 Nov 2022 12:03:15 +0800 Message-Id: <20221123040315.1480112-4-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221123040315.1480112-1-Henry.Wang@arm.com> References: <20221123040315.1480112-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Henry Wang --- v3 -> v4: - No change. v2 -> v3: - Take the opportunity to also adjust the 4.17 entry since this patch will be applied only after branching. - Add 4.17 release date. - Drop Julien's acked-by because of the content change. v1 -> v2: - Add Julien's Acked-by. --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b315d59259..956b758e6b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,9 @@ Notable changes to Xen will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) -## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) +## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD + +## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.17.0) - 2022-12-?? ### Changed - On x86 "vga=current" can now be used together with GrUB2's gfxpayload setting. Note that -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 04:03:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 04:03:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447380.703541 (Exim 4.92) (envelope-from ) id 1oxgzA-0008Bd-UZ; Wed, 23 Nov 2022 04:03:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447380.703541; Wed, 23 Nov 2022 04:03:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxgzA-0008BW-Rc; Wed, 23 Nov 2022 04:03:44 +0000 Received: by outflank-mailman (input) for mailman id 447380; Wed, 23 Nov 2022 04:03:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxgz9-0008AS-U3 for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 04:03:43 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d155d0ae-6ae3-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 05:03:42 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 207BB139F; Tue, 22 Nov 2022 20:03:48 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4E0F23F587; Tue, 22 Nov 2022 20:03:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d155d0ae-6ae3-11ed-8fd2-01056ac49cbb From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Henry Wang , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Julien Grall , Community Manager Subject: [PATCH v4 2/3] Changelog: Add __ro_after_init and CET Date: Wed, 23 Nov 2022 12:03:14 +0800 Message-Id: <20221123040315.1480112-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221123040315.1480112-1-Henry.Wang@arm.com> References: <20221123040315.1480112-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Andrew Cooper Signed-off-by: Andrew Cooper Signed-off-by: Henry Wang Reviewed-by: Roger Pau Monné --- v3 -> v4: - Add my own sign-off because I changed the original wording. v2 -> v3: - Remove the "on x86" for __ro_after_init, as Arm also supports the __ro_after_init. v1 -> v2: - Include this patch in the series --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8fa8b198b3..b315d59259 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ### Added / support upgraded - Out-of-tree builds for the hypervisor now supported. + - __ro_after_init support, for marking data as immutable after boot. - The project has officially adopted 4 directives and 24 rules of MISRA-C, added MISRA-C checker build integration, and defined how to document deviations. @@ -22,6 +23,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) when they don't share page tables with the CPU (HAP / EPT / NPT). - Support for VIRT_SSBD and MSR_SPEC_CTRL for HVM guests on AMD. - Improved TSC, CPU, and APIC clock frequency calibration on x86. + - Support for Xen using x86 Control Flow Enforcement technology for its own + protection. Both Shadow Stacks (ROP protection) and Indirect Branch + Tracking (COP/JOP protection). - Add mwait-idle support for SPR and ADL on x86. - Extend security support for hosts to 12 TiB of memory on x86. - Add command line option to set cpuid parameters for dom0 at boot time on x86. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 04:03:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 04:03:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447379.703530 (Exim 4.92) (envelope-from ) id 1oxgz6-0007u5-NY; Wed, 23 Nov 2022 04:03:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447379.703530; Wed, 23 Nov 2022 04:03:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxgz6-0007ty-JN; Wed, 23 Nov 2022 04:03:40 +0000 Received: by outflank-mailman (input) for mailman id 447379; Wed, 23 Nov 2022 04:03:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxgz5-0007eX-8i for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 04:03:39 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ced911a8-6ae3-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 05:03:38 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0FD8F23A; Tue, 22 Nov 2022 20:03:44 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B36B73F587; Tue, 22 Nov 2022 20:03:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ced911a8-6ae3-11ed-91b6-6bf2151ebd3b From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Andrew Cooper , Stefano Stabellini , Julien Grall , Bertrand Marquis , Community Manager Subject: [PATCH v4 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Date: Wed, 23 Nov 2022 12:03:13 +0800 Message-Id: <20221123040315.1480112-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221123040315.1480112-1-Henry.Wang@arm.com> References: <20221123040315.1480112-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Henry Wang --- v3 -> v4: - Use the corrected sentence for VIRT_SSBD and MSR_SPEC_CTRL - Clarify that the virtio-mmio toolstack for ARM is only creating the device-tree binding. - Remove the "initial" in i.MX entry. v2 -> v3: - Move the uncertain release date to patch #3. v1 -> v2: - Correct wording for two x86 entries (clock frequency calibration and SPR & ADL support) following Jan's suggestion. - Add missing Arm entries from Oleksandr. - Add missing i.MX entry following Stefano's suggestion. --- CHANGELOG.md | 31 +++++++++++++++++++++++++++++-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index adbbb216fa..8fa8b198b3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,16 +4,43 @@ Notable changes to Xen will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) -## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD +## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) ### Changed - On x86 "vga=current" can now be used together with GrUB2's gfxpayload setting. Note that this requires use of "multiboot2" (and "module2") as the GrUB commands loading Xen. + - The "gnttab" option now has a new command line sub-option for disabling the + GNTTABOP_transfer functionality. + - The x86 MCE command line option info is now updated. ### Added / support upgraded + - Out-of-tree builds for the hypervisor now supported. + - The project has officially adopted 4 directives and 24 rules of MISRA-C, + added MISRA-C checker build integration, and defined how to document + deviations. - IOMMU superpage support on x86, affecting PV guests as well as HVM/PVH ones when they don't share page tables with the CPU (HAP / EPT / NPT). - - Support VIRT_SSBD feature for HVM guests on AMD. + - Support for VIRT_SSBD and MSR_SPEC_CTRL for HVM guests on AMD. + - Improved TSC, CPU, and APIC clock frequency calibration on x86. + - Add mwait-idle support for SPR and ADL on x86. + - Extend security support for hosts to 12 TiB of memory on x86. + - Add command line option to set cpuid parameters for dom0 at boot time on x86. + - Improved static configuration options on Arm. + - cpupools can be specified at boot using device tree on Arm. + - It is possible to use PV drivers with dom0less guests, allowing statically + booted dom0less guests with PV devices. + - On Arm, p2m structures are now allocated out of a pool of memory set aside at + domain creation. + - Improved mitigations against Spectre-BHB on Arm. + - Support VirtIO-MMIO devices device-tree binding creation in toolstack on Arm. + - Allow setting the number of CPUs to activate at runtime from command line + option on Arm. + - Grant-table support on Arm was improved and hardened by implementing + "simplified M2P-like approach for the xenheap pages" + - Add Renesas R-Car Gen4 IPMMU-VMSA support on Arm. + - Add i.MX lpuart and i.MX8QM support on Arm. + - Improved toolstack build system. + - Add Xue - console over USB 3 Debug Capability. ### Removed / support downgraded - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 04:03:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 04:03:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447378.703518 (Exim 4.92) (envelope-from ) id 1oxgz3-0007em-F7; Wed, 23 Nov 2022 04:03:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447378.703518; Wed, 23 Nov 2022 04:03:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxgz3-0007ef-CO; Wed, 23 Nov 2022 04:03:37 +0000 Received: by outflank-mailman (input) for mailman id 447378; Wed, 23 Nov 2022 04:03:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxgz2-0007eX-CH for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 04:03:36 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id cc0a1bda-6ae3-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 05:03:33 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4971A1FB; Tue, 22 Nov 2022 20:03:39 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id EB8173F587; Tue, 22 Nov 2022 20:03:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc0a1bda-6ae3-11ed-91b6-6bf2151ebd3b From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Andrew Cooper , Stefano Stabellini , Julien Grall , Bertrand Marquis , Community Manager Subject: [PATCH v4 0/3] Populate entries for 4.17 Date: Wed, 23 Nov 2022 12:03:12 +0800 Message-Id: <20221123040315.1480112-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hello, The following changes are preparation work for the 4.17 release. Also collecting the changelog changes happened during the 4.17 dev phase. This is my first pass at the log for the release, it's likely missing more entries. Thanks, Henry v3 -> v4: - Use the corrected sentence for VIRT_SSBD and MSR_SPEC_CTRL - Clarify that the virtio-mmio toolstack for ARM is only creating the device-tree binding. - Remove the "initial" in i.MX entry. - Add my own sign-off in patch #2 because I changed the original wording. v2 -> v3: - Move the uncertain release date to patch #3. - Remove the "on x86" for __ro_after_init, as Arm also supports the __ro_after_init. - Take the opportunity in patch #3 to also adjust the 4.17 entry since this patch will be applied only after branching. v1 -> v2: - Pick other changelog patches happened during the 4.17 dev phase. - Correct wording for two x86 entries (clock frequency calibration and SPR & ADL support) following Jan's suggestion. - Add missing Arm entries from Oleksandr. - Add missing i.MX entry following Stefano's suggestion. Andrew Cooper (1): Changelog: Add __ro_after_init and CET Henry Wang (2): CHANGELOG: Add missing entries for work during the 4.17 release CHANGELOG: Start new "unstable" section CHANGELOG.md | 35 ++++++++++++++++++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 07:27:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 07:27:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447405.703581 (Exim 4.92) (envelope-from ) id 1oxkAJ-0005k1-SB; Wed, 23 Nov 2022 07:27:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447405.703581; Wed, 23 Nov 2022 07:27:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxkAJ-0005ju-PI; Wed, 23 Nov 2022 07:27:27 +0000 Received: by outflank-mailman (input) for mailman id 447405; Wed, 23 Nov 2022 07:27:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxkAI-0005jn-AG for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 07:27:26 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20630.outbound.protection.outlook.com [2a01:111:f400:fe12::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 40555093-6b00-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 08:27:15 +0100 (CET) Received: from DU2P250CA0025.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::30) by GV2PR08MB8148.eurprd08.prod.outlook.com (2603:10a6:150:7c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 07:27:18 +0000 Received: from DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:231:cafe::62) by DU2P250CA0025.outlook.office365.com (2603:10a6:10:231::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17 via Frontend Transport; Wed, 23 Nov 2022 07:27:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT014.mail.protection.outlook.com (100.127.143.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17 via Frontend Transport; Wed, 23 Nov 2022 07:27:17 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Wed, 23 Nov 2022 07:27:17 +0000 Received: from 6500040f88f0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7960AD56-FE10-46B7-A5C1-DA793BF8FC1A.1; Wed, 23 Nov 2022 07:27:08 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6500040f88f0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 23 Nov 2022 07:27:08 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11) by AS8PR08MB10292.eurprd08.prod.outlook.com (2603:10a6:20b:62b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 07:27:04 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f]) by AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f%3]) with mapi id 15.20.5857.017; Wed, 23 Nov 2022 07:27:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 40555093-6b00-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4BimJQePf3eVGzfssfB7Y9ChTj0UKbB4iMTBhJnR9dQ=; b=i7i6P7/HFpR54HJ7L0/hweV/j0ybLZez9/ZGfrTuwS60yv35SY6aNGVvqrcMIbzYLQp9H/wjnadfjbqLJLFkcZlz2uLxVqMiA/ZqALHfRxC45UWF6V4137mIIJnb8S7atq3zMc/B45n+lbsxhsa+6ToWcj7sZngpZM+LteRggik= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cbjEw6FWO6i/vpVyekCNwV4M6F5QZGp99mIR+Xh6wJPuOxB/Np+t1hRYNIwB7rjdR9UrrW6Fb385LRT4keM/+2ZBjTLTrFOTJQzwjEsu6WJyt92RAsGxqgdxBk04ljxYLB86QZnHEXmbfuL6soE1Z8VQlYi1Cl7o2OTK2JIQPpULk0Vutf0zTa/djIlDrZZ2UCFFJxOY0vTrk73Y35slwmUmrdbnPy5wAsoHa7rxhy2WZZ/6qxZ7EbbrmrqQGIS1QbZdIKKsqzakEvaSydxPzI0qBgc8Czhd6shGO94lx4J2Enj14N4khh7IiQ5JgDYsgYF33jmFuDRV7zkEOOGicQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4BimJQePf3eVGzfssfB7Y9ChTj0UKbB4iMTBhJnR9dQ=; b=QBB7TabZg2m/HLtT+7bz4by3CiTAPbZqBozj7Ba4BddlU9mRMNXk5N51b4qJh0MfC0elXkyDCm1nYjHipKpatlb11JzqHerVDZYeirl9jRJLCiPqsoQDUc2kQmtPwjfgyXSEZX7OfNLGm300sraWpEIYAqfGKTIZF3YPbFs3a67wFDb/7Kdp2IlGcA23+0xdf/M7/5Hn9ThCFhE3KUcRks7ZoKA2Sv18LX9BR6CyCtpF1l9lQ9auYnnXsMSom0jLQSMx9IQLz7+eRVVEZjHq4IGoGzuHxthSW1powzsnSHT8Z1J6yH8GOREwxrXvmbaBiUfl28W8UjAW6YuaU2IW6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4BimJQePf3eVGzfssfB7Y9ChTj0UKbB4iMTBhJnR9dQ=; b=i7i6P7/HFpR54HJ7L0/hweV/j0ybLZez9/ZGfrTuwS60yv35SY6aNGVvqrcMIbzYLQp9H/wjnadfjbqLJLFkcZlz2uLxVqMiA/ZqALHfRxC45UWF6V4137mIIJnb8S7atq3zMc/B45n+lbsxhsa+6ToWcj7sZngpZM+LteRggik= From: Jiamei Xie To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v2] xen/arm: vpl011: Make access to DMACR write-ignore Thread-Topic: [PATCH v2] xen/arm: vpl011: Make access to DMACR write-ignore Thread-Index: AQHY/jYHhVkwya4U7kGFhTN8kPwCjK5K3q+AgAE9aTA= Date: Wed, 23 Nov 2022 07:27:02 +0000 Message-ID: References: <20221122054644.1092173-1-jiamei.xie@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 30B8778578721D48B34605AD68019380.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7696:EE_|AS8PR08MB10292:EE_|DBAEUR03FT014:EE_|GV2PR08MB8148:EE_ X-MS-Office365-Filtering-Correlation-Id: 9aaf8958-7585-42dd-4e14-08dacd242687 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wSk2xspo2Qdde++EIOClWgGQzEfH77mFSIo4aAgCIl6bEqO655gDqQnp9qSAiqk8jOoO07Q6arJHBuN/P9gOdFqXnIbzuKowCxwXRfsUKXu1HaK++zx/wvcwzRFy8lj6fpgvqN7j7u/D0lz60pSOiiifRMC7osFllWXk4KWn15it1NBcYnCYfNY0c1DIRuz6AWaq/Yx3Luo5U57XtyMuekd/ePuXKEHdtEKUGYAMscRiBKo7UOAriczvykxJRm4r/sxgcy6xo0/HRdy0Z1877U1DupJ447rOFbM0trHa7IIVONQPXKGkqTMoT3FIlCHCTIhkSb+mplDiV520UyiLNJZHfaQqI60HStq/68KypktTp8lWDnmfYbXDjKy+0L7RmMUwrPfKaUC7i4r7rBEO7na9e3mFg4wsS850jB1h5/HWxdmXD0uRF5wEWOn/e7TtsBvpFhJF9egmpHqObtKbD+2g+IrLJzW13WRwlLdNfX60oQG2CVrtg56dcJ9X97JNS/2rSvnthxDE1gYB0XYNoxENJz5A6mml9+3FoWBelyUWSRQsEJUWCb+woaGqg2wj/mqgM9jsxvfnHTbu7fGRDWzwfYbmSWlRF83Vtz9s0yElIyLiWnYhVEeI3pLf7vHGImTT+0+sYINILjx4g8crrOvjIAiBqoktivd83LcVMYPNr13LQ6D/ZOdH0OKVetPUq5ixMvE9ha4gzU+5bYdXvIeLCcK4V85Xj/iKVMuwgIqs3WYtgpeF67eIQfuj8GPF33pLsPRNzMjrgf02Jns0OQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(346002)(136003)(396003)(376002)(451199015)(41300700001)(5660300002)(8936002)(52536014)(33656002)(316002)(54906003)(110136005)(86362001)(66946007)(76116006)(2906002)(64756008)(4326008)(66476007)(66446008)(66556008)(8676002)(55016003)(71200400001)(478600001)(38070700005)(122000001)(38100700002)(6506007)(53546011)(7696005)(26005)(9686003)(83380400001)(966005)(186003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10292 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 82b554d0-2242-4579-c7b6-08dacd241dd5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XTpc1V2p9UJnLRsrnFQxWfPDjVNsdZFh77Tm5nyjEI/x1vC2DHOwASKrtE48GeBY7vOI54tBByvMWwSPIAC/atUH4o0hkoGYdxZd5WylC19/vkaD6p0p9mG/yPyW5IY5VvBAAGwiEyr7Nz4oB18fk0TbTytewe+iMWSoJkv1BodaRdE7tT/93d6xg+j7qm2SczlskJDZZmKisG2tm7vhr07aRN1OlwdtYzY4701KclNklP1BaM8GErSYdGrmkfyPdwa0w19uy5Cm6AXjFE+A81FVyB/ydT76PhHFnqUT6xyPXeDN4OKd2tGAL0LQwT9fPgMihQzbaEiGYNbgmJVVlxBCbaWQ65jYu7dLGDeH5tXoetYoDaMKrvxw/J3bwIuJ2BQCRqX+QPG+UpqXEdOwstnIVYtGoWdsgP4/kegO6GK/gcE/1YUllswWq92jEjhsYJRuRADD5MPONXUR40guJKewzEwq+KI1EpsF/G4InyGZ5wO8ZqHMUYnA3T7jupfXyf1z02x3L0saMx9twO5dqbDo1+qTFaYHtCbBderZrK8rPFrKcVgvTDMaCTplC4zr9VFLd3XUMsRjbhuwcXvUaOfNTcX0bk3D6EKMkeONDf1uBIPjorsaq4xDmRqq88VR+p+wZ5UTi5CWHHYgHydXOonFyJG5WnRZIz7y0MpgZlFxhOEPrflneApIiGrp8kLsKnxZOwmnj7PWTAjmB8t4wUAO1jk+cvCOS6gm7mHM1m+lUqK4Hp7qT6WiJnzzJU37lTbjq7u+2/QaKGE3tbFp+A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(346002)(376002)(451199015)(36840700001)(40470700004)(46966006)(41300700001)(8936002)(4326008)(5660300002)(316002)(54906003)(70206006)(70586007)(8676002)(52536014)(478600001)(336012)(107886003)(53546011)(966005)(7696005)(9686003)(6506007)(110136005)(186003)(26005)(47076005)(36860700001)(82310400005)(2906002)(40460700003)(40480700001)(81166007)(83380400001)(86362001)(82740400003)(33656002)(55016003)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 07:27:17.5264 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9aaf8958-7585-42dd-4e14-08dacd242687 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8148 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IFR1ZXNkYXksIE5vdmVtYmVyIDIyLCAy MDIyIDg6MjYgUE0NCj4gVG86IEppYW1laSBYaWUgPEppYW1laS5YaWVAYXJtLmNvbT47IHhlbi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5j b20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0 cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+Ow0KPiBWb2xvZHlteXIgQmFi Y2h1ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0gg djJdIHhlbi9hcm06IHZwbDAxMTogTWFrZSBhY2Nlc3MgdG8gRE1BQ1Igd3JpdGUtDQo+IGlnbm9y ZQ0KPiANCj4gSGksDQo+IA0KPiBPbiAyMi8xMS8yMDIyIDA1OjQ2LCBKaWFtZWkgWGllIHdyb3Rl Og0KPiA+IFdoZW4gdGhlIGd1ZXN0IGtlcm5lbCBlbmFibGVzIERNQSBlbmdpbmUgd2l0aA0KPiAi Q09ORklHX0RNQV9FTkdJTkU9eSIsDQo+ID4gTGludXggU0JTQSBQTDAxMSBkcml2ZXIgd2lsbCBh Y2Nlc3MgUEwwMTEgRE1BQ1IgcmVnaXN0ZXIgaW4gc29tZQ0KPiA+IGZ1bmN0aW9ucy4gQXMgY2hh cHRlciAiQiBHZW5lcmljIFVBUlQiIGluICJBUk0gU2VydmVyIEJhc2UgU3lzdGVtDQo+ID4gQXJj aGl0ZWN0dXJlIlsxXSBkb2N1bWVudGF0aW9uIGRlc2NyaWJlcywgU0JTQSBVQVJUIGRvZXNuJ3Qg c3VwcG9ydA0KPiA+IERNQS4gSW4gY3VycmVudCBjb2RlLCB3aGVuIHRoZSBrZXJuZWwgdHJpZXMg dG8gYWNjZXNzIERNQUNSIHJlZ2lzdGVyLA0KPiA+IFhlbiB3aWxsIGluamVjdCBhIGRhdGEgYWJv cnQ6DQo+ID4gVW5oYW5kbGVkIGZhdWx0IGF0IDB4ZmZmZmZmYzAwOTQ0ZDA0OA0KPiA+IE1lbSBh Ym9ydCBpbmZvOg0KPiA+ICAgIEVTUiA9IDB4OTYwMDAwMDANCj4gPiAgICBFQyA9IDB4MjU6IERB QlQgKGN1cnJlbnQgRUwpLCBJTCA9IDMyIGJpdHMNCj4gPiAgICBTRVQgPSAwLCBGblYgPSAwDQo+ ID4gICAgRUEgPSAwLCBTMVBUVyA9IDANCj4gPiAgICBGU0MgPSAweDAwOiB0dGJyIGFkZHJlc3Mg c2l6ZSBmYXVsdA0KPiA+IERhdGEgYWJvcnQgaW5mbzoNCj4gPiAgICBJU1YgPSAwLCBJU1MgPSAw eDAwMDAwMDAwDQo+ID4gICAgQ00gPSAwLCBXblIgPSAwDQo+ID4gc3dhcHBlciBwZ3RhYmxlOiA0 ayBwYWdlcywgMzktYml0IFZBcywgcGdkcD0wMDAwMDAwMDIwZTJlMDAwDQo+ID4gW2ZmZmZmZmMw MDk0NGQwNDhdIHBnZD0xMDAwMDAwMDNmZmZmODAzLCBwNGQ9MTAwMDAwMDAzZmZmZjgwMywNCj4g cHVkPTEwMDAwMDAwM2ZmZmY4MDMsIHBtZD0xMDAwMDAwMDNmZmZhODAzLCBwdGU9MDA2ODAwMDA5 YzA5MGYxMw0KPiA+IEludGVybmFsIGVycm9yOiB0dGJyIGFkZHJlc3Mgc2l6ZSBmYXVsdDogOTYw MDAwMDAgWyMxXSBQUkVFTVBUIFNNUA0KPiA+IC4uLg0KPiA+IENhbGwgdHJhY2U6DQo+ID4gICBw bDAxMV9zdG9wX3J4KzB4NzAvMHg4MA0KPiA+ICAgdHR5X3BvcnRfc2h1dGRvd24rMHg3Yy8weGI0 DQo+ID4gICB0dHlfcG9ydF9jbG9zZSsweDYwLzB4Y2MNCj4gPiAgIHVhcnRfY2xvc2UrMHgzNC8w eDhjDQo+ID4gICB0dHlfcmVsZWFzZSsweDE0NC8weDRjMA0KPiA+ICAgX19mcHV0KzB4NzgvMHgy MjANCj4gPiAgIF9fX19mcHV0KzB4MWMvMHgzMA0KPiA+ICAgdGFza193b3JrX3J1bisweDg4LzB4 YzANCj4gPiAgIGRvX25vdGlmeV9yZXN1bWUrMHg4ZDAvMHgxMjNjDQo+ID4gICBlbDBfc3ZjKzB4 YTgvMHhjMA0KPiA+ICAgZWwwdF82NF9zeW5jX2hhbmRsZXIrMHhhNC8weDEzMA0KPiA+ICAgZWww dF82NF9zeW5jKzB4MWEwLzB4MWE0DQo+ID4gQ29kZTogYjkwMDAwODMgYjkwMWYwMDEgNzk0MDM4 YTAgOGIwMDAwNDIgKGI5MDAwMDQxKQ0KPiA+IC0tLVsgZW5kIHRyYWNlIDgzZGQ5M2RmMTVjMzIx NmYgXS0tLQ0KPiA+IG5vdGU6IGJvb3Rsb2dkWzEzMl0gZXhpdGVkIHdpdGggcHJlZW1wdF9jb3Vu dCAxDQo+ID4gL2V0Yy9yY1MuZC9TMDdib290bG9nZDogbGluZSA0NzogMTMyIFNlZ21lbnRhdGlv biBmYXVsdCBzdGFydC1zdG9wLQ0KPiBkYWVtb24NCj4gPg0KPiA+IEFzIGRpc2N1c3NlZCBpbiBb Ml0sIHRoaXMgY29tbWl0IG1ha2VzIHRoZSBhY2Nlc3MgdG8gRE1BQ1IgcmVnaXN0ZXINCj4gPiB3 cml0ZS1pZ25vcmUgYXMgYW4gaW1wcm92ZW1lbnQuDQo+IA0KPiBEaWRuJ3Qgd2UgYWdyZWUgdG8g ZW11bGF0ZSBhbGwgbm9uLVNCU0EgcmVnaXN0ZXJzIGFzIFdJPyBJT1csIHRoZQ0KPiBkZWZhdWx0 IGNhc2Ugc2hvdWxkIGNvbnRhaW4gYSAnZ290byB3cml0ZV9pZ25vcmUnIHJhdGhlciByZXR1cm4g MC4NCg0KVGhhbmtzIGZvciB5b3VyIHJldmlldy4gIEknbGwgIGVtdWxhdGUgYWxsIG5vbi1TQlNB IHJlZ2lzdGVycyBhcyBXSSBpbiBwYXRjaCB2My4NCg0KPiANCj4gPg0KPiA+IFsxXSBodHRwczov L2RldmVsb3Blci5hcm0uY29tL2RvY3VtZW50YXRpb24vZGVuMDA5NC9jLz9sYW5nPWVuDQo+ID4g WzJdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3hlbi0NCj4gZGV2ZWwvYWxwaW5lLkRFQi4yLjIy LjM5NC4yMjExMTYxNTUyNDIwLjQwMjBAdWJ1bnR1LWxpbnV4LTIwLTA0LQ0KPiBkZXNrdG9wLw0K PiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogSmlhbWVpIFhpZSA8amlhbWVpLnhpZUBhcm0uY29tPg0K PiA+IC0tLQ0KPiA+ICAgeGVuL2FyY2gvYXJtL3ZwbDAxMS5jIHwgNCArKysrDQo+ID4gICAxIGZp bGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2Fy Y2gvYXJtL3ZwbDAxMS5jIGIveGVuL2FyY2gvYXJtL3ZwbDAxMS5jDQo+ID4gaW5kZXggNDM1MjJk NDhmZC4uZTk3ZmUzZWJlNyAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vdnBsMDExLmMN Cj4gPiArKysgYi94ZW4vYXJjaC9hcm0vdnBsMDExLmMNCj4gPiBAQCAtNDYzLDYgKzQ2MywxMCBA QCBzdGF0aWMgaW50IHZwbDAxMV9tbWlvX3dyaXRlKHN0cnVjdCB2Y3B1ICp2LA0KPiA+ICAgICAg IGNhc2UgRlI6DQo+ID4gICAgICAgY2FzZSBSSVM6DQo+ID4gICAgICAgY2FzZSBNSVM6DQo+ID4g KyAgICBjYXNlIERNQUNSOg0KPiA+ICsgICAgICAgIHByaW50ayhYRU5MT0dfR19ERUJVRw0KPiA+ ICsgICAgICAgICAgICAgICAidnBsMDExOiBXSSBvbiByZWdpc3RlciBvZmZzZXQgJSMwOHhcbiIs DQo+ID4gKyAgICAgICAgICAgICAgIHZwbDAxMV9yZWcpOw0KPiANCj4gSU1ITywgdGhpcyBtZXNz YWdlIHNob3VsZCBiZSBwcmludGVkIGp1c3QgYWZ0ZXIgdGhlIHdyaXRlX2lnbm9yZSBsYWJlbC4N Cg0KSSdsbCBwdXQgaXQgYWZ0ZXIgdGhlIHdyaXRlX2lnbm9yZSBsYWJsZSBpbiBwYXRjaCB2My4N Cg0KQmVzdCB3aXNoZXMNCkppYW1laSBYaWUNCg0KDQo+IA0KPiA+ICAgICAgICAgICBnb3RvIHdy aXRlX2lnbm9yZTsNCj4gPg0KPiA+ICAgICAgIGNhc2UgSU1TQzoNCj4gDQo+IENoZWVycywNCj4g DQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Wed Nov 23 07:30:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 07:30:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447409.703592 (Exim 4.92) (envelope-from ) id 1oxkD2-0007AO-FK; Wed, 23 Nov 2022 07:30:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447409.703592; Wed, 23 Nov 2022 07:30:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxkD2-0007AH-B1; Wed, 23 Nov 2022 07:30:16 +0000 Received: by outflank-mailman (input) for mailman id 447409; Wed, 23 Nov 2022 07:30:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxkD1-0007AB-2P for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 07:30:15 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20611.outbound.protection.outlook.com [2a01:111:f400:7d00::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a537bb77-6b00-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 08:30:05 +0100 (CET) Received: from AS9PR04CA0050.eurprd04.prod.outlook.com (2603:10a6:20b:46a::35) by DB9PR08MB9633.eurprd08.prod.outlook.com (2603:10a6:10:454::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 07:30:07 +0000 Received: from AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46a:cafe::b6) by AS9PR04CA0050.outlook.office365.com (2603:10a6:20b:46a::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17 via Frontend Transport; Wed, 23 Nov 2022 07:30:07 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT042.mail.protection.outlook.com (100.127.140.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 23 Nov 2022 07:30:06 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Wed, 23 Nov 2022 07:30:06 +0000 Received: from c34f26f97d1b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AB622778-5187-419C-82E5-82C7200702B1.1; Wed, 23 Nov 2022 07:29:57 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c34f26f97d1b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 23 Nov 2022 07:29:57 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11) by PAXPR08MB7349.eurprd08.prod.outlook.com (2603:10a6:102:225::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 07:29:52 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f]) by AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::d34b:9a50:9e36:20f%3]) with mapi id 15.20.5857.017; Wed, 23 Nov 2022 07:29:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a537bb77-6b00-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w0+yzMfLyTY+gNsbyRQZB9MLCJ1z9Wm5eejJvrqyon4=; b=glHREdtWXJGaLqmevVli522vyUL6U+ruLMDgPMK9jSM/EqQEQurgvH0uERQyZRsaxq5OuR7Ubjml+JhVMOikfBx1hyN7eCLtL62oTExIrWGMuSCIlvnXO9XQrdaD7lomJBZkl9Ud7KGusXEfYXaMH63gpHIMqGZdS2oruJIhRjM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cObVkwYXT2Eoghb0er2eCw8k2G1dGF/+OnXER6Lr4RiJ59WUVEh+BjqBxZGRkv67cdQ0DkWg8ZMNS3SJAl4VOw+syCEx9Vu3ZZJBXp+HSXpF+qiT51o4CDQYypV8g+ycjV4BlLVI0LQYJaUYIwV/NKZOZ5f21GEjtJ7NyanvVmmBwenIo0u/T9i09EsFvZ4QSyidI6K1la2JpwoqaFDEyQOGoK+Wxj8lVg1uR8ijmUbW80PEBaf32cpfyiD3urS3jfxktDHqVX/aw0Net34lY7l2Enw9rV8esUa64PCwhLEF8dQQ9RRipUxR/GjZuzy0JNMGBZW2++GDpxf8x1vd3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w0+yzMfLyTY+gNsbyRQZB9MLCJ1z9Wm5eejJvrqyon4=; b=SQ2Fdn2TiesktD9iC6kWIcBo7mn/RQHRhzBI3hfMvFQ4QzbrSAuaIJtW/5l8jd6PiTXAc5PfkF2AvVsUb3nlHaqPLFed8ZIy6yDEdRXT8f6p4HuYsRQAfTFHaD6Ml/DLzsXAHBO5M3WF7qeiEvSt0w5oiozX4ResBRHIqGAlCEREmAKTAfXGANn1otjqf3pzDTiqqlY67gixJvpdRBhGR6mp2BpW/QWDe7Q4/VtJRXPNbb7PeKQf6p8z5WzIYWyDXaX7uB1ZpEG9BONjwoBG6ziDRyHNg/LaHw6CdmOmxZCzY4j27Doy+YvTCI12T/HV926yL/uI7LrXi8diZMPS6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w0+yzMfLyTY+gNsbyRQZB9MLCJ1z9Wm5eejJvrqyon4=; b=glHREdtWXJGaLqmevVli522vyUL6U+ruLMDgPMK9jSM/EqQEQurgvH0uERQyZRsaxq5OuR7Ubjml+JhVMOikfBx1hyN7eCLtL62oTExIrWGMuSCIlvnXO9XQrdaD7lomJBZkl9Ud7KGusXEfYXaMH63gpHIMqGZdS2oruJIhRjM= From: Jiamei Xie To: Michal Orzel , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall Subject: RE: [PATCH v2] xen/arm: vpl011: Make access to DMACR write-ignore Thread-Topic: [PATCH v2] xen/arm: vpl011: Make access to DMACR write-ignore Thread-Index: AQHY/jYHhVkwya4U7kGFhTN8kPwCjK5K3q+AgAAvuICAAQ8v0A== Date: Wed, 23 Nov 2022 07:29:52 +0000 Message-ID: References: <20221122054644.1092173-1-jiamei.xie@arm.com> <1f0d8171-a56e-a7a2-e5c2-0d8d09ee0a1b@amd.com> In-Reply-To: <1f0d8171-a56e-a7a2-e5c2-0d8d09ee0a1b@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 378E34EACE726B48BF5D716C449846CC.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7696:EE_|PAXPR08MB7349:EE_|AM7EUR03FT042:EE_|DB9PR08MB9633:EE_ X-MS-Office365-Filtering-Correlation-Id: 56febcdf-9480-442f-3791-08dacd248b65 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qDBLvTmEUvA91zdfUz82Ay807eW9uK7dzgDpFQatRqp+b+54IxHtkQkHoHsxeUSxCTayRiGfNZYq4+dfvID76rTqAMTA9Eu6KBL4y9FMENwNOJFAskFi11gDnj0cD5WvlQw6orXHBih/qmVvYkD/IRVBZBb/bpxdTWu+GnhcqskiecA7IZYvV5v2D863Ua8qe3y6NNBhKai6LC/W/ZwX5W1gG9lZUVdKtmQ3jKLJMPG9Nt2rRFxapL6/Unwc9s0rNIwEvrqhruVRi9SuT9NSvnd7guCtDDqmkgBJqG93Qr2h9NvPQyD+GveoEAz5UJ5OKFvfVQwg+Z8rP4j7u90m9E1zZiKaT+dEojF30kcvJK3vyZ5akYG4SYtlTmsoLoyPPHAGhR1qVDm2E1se/RAdzS5/ToQLOEzZ2l123om2FF9xX6lkC49Azv9NR9gFLAz3nUMUDIjsGHu4KuxScXcs3mtUdLcA0zqp1sem+va5ipzBIIWCfxrb8bSzCXAmEp57ad97iL61R0We7NvsJteWivHGTc2Hi9B6cxSsD8jHa86AOLOYWAOLVXJF1AQmNG1sdRdHR8cdFl21TphoaSRU29qF843g54k7RAAsoRfMxG6i8ST6JDWL+T1AmFBrcU9q1NPExSeJUnyGHw5x+D/mNkekU2EWsq3HqORJgK58aO1TYINyrtTDsu0CLgR5f6Y2lveowJg4XGGO1Pi/Gr+bvvmW3oBfQG/MYibHVAtG2m3xqVrkivjUj460g5tOUKyuxTUEW1kOQfwAQJ32tPVdvQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(376002)(136003)(39860400002)(346002)(451199015)(38100700002)(83380400001)(5660300002)(122000001)(2906002)(86362001)(38070700005)(4326008)(110136005)(8676002)(8936002)(66446008)(52536014)(53546011)(26005)(64756008)(9686003)(55016003)(7696005)(71200400001)(41300700001)(6506007)(316002)(54906003)(186003)(66556008)(45080400002)(478600001)(76116006)(966005)(66476007)(66946007)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7349 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7d923cef-9667-49fb-69e2-08dacd2482c2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nV3OcaDzfTfmuDeQ/1Qp6XWthqMtxEA+OmtgPq6gTcC5JVNkqQJihE6LEpNjcY4JiWquHYoMa1K94doskJ3uIVTWufhfuScV8DgizPoXg7P69+xcfXJtPu6LlHnSLdIE4+G+ymtrtZE/0MCO2otadBWc6+1zfl9d/f1UfQ1dcN4jkLheg9euBunFvSJnbZpI1qWaZDZIXY5E2zCnA827T3rkMVX6eoAoLGeQbsXgRzdlK97V2kKd+oXTHc1DeYkRNEVfrkP7M4Y8MXnOJGu6Y5G143cLpE+U84RbC2Vudsjk7/3YeOPVBwQNURav6svWVQJ5jKGA5Iz+lD3yTKGRZFqDVrH41PuhN5iwFkDpad78puBoXV1CGAgv/IdInnQcA7KkhJ7PHk99dIWTrH27pEOjn1c2G5lu68hAoK01DlOnfNew6RFuD1yIO5PQ/N8NcVtcggT7JgnQb5N55HHhcIH6ojDkDkR8Wfei4eX/KNdwfPlOGBMzg0bL3VIlz8ARPavLHlxhcgWWPKbtg2gbhOGvXLIz8n2KZkFRIFgNUI58lbs5Llr8s2dZS9RHzkBP6QmVvFxPWueMDtW6tV5Ar3pwG/Y32uYGub8B3StqQQ4cvVFo8LLd54d8repS9eanZlF/HoKkUp1oqEehZ07oi/4VCv1SssizOxiYA/tDoIwzMaUohVmGM1OtD+yHm0g/4FhEvn6jITStyfMFxS/w51nZBS1Y6nHJVcg0moZHot1qSeQhXN3hlJc08BD37V9iwKH9Ihdnga/cCFodjbQpTQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199015)(36840700001)(46966006)(40470700004)(2906002)(8936002)(5660300002)(82310400005)(316002)(36860700001)(41300700001)(55016003)(40460700003)(54906003)(52536014)(110136005)(966005)(8676002)(45080400002)(70206006)(81166007)(33656002)(70586007)(4326008)(478600001)(53546011)(86362001)(336012)(47076005)(26005)(7696005)(6506007)(9686003)(186003)(83380400001)(356005)(82740400003)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 07:30:06.6435 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 56febcdf-9480-442f-3791-08dacd248b65 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9633 SGkgTWljaGFsLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE1pY2hh bCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+IFNlbnQ6IFR1ZXNkYXksIE5vdmVtYmVy IDIyLCAyMDIyIDExOjE3IFBNDQo+IFRvOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsg SmlhbWVpIFhpZSA8SmlhbWVpLlhpZUBhcm0uY29tPjsgeGVuLQ0KPiBkZXZlbEBsaXN0cy54ZW5w cm9qZWN0Lm9yZw0KPiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVmYW5vIFN0 YWJlbGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzIDxC ZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+Ow0KPiBWb2xvZHlteXIgQmFiY2h1ayA8Vm9sb2R5bXly X0JhYmNodWtAZXBhbS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjJdIHhlbi9hcm06IHZw bDAxMTogTWFrZSBhY2Nlc3MgdG8gRE1BQ1Igd3JpdGUtDQo+IGlnbm9yZQ0KPiANCj4gSGksDQo+ IA0KPiBPbiAyMi8xMS8yMDIyIDEzOjI1LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+ID4NCj4gPg0K PiA+IEhpLA0KPiA+DQo+ID4gT24gMjIvMTEvMjAyMiAwNTo0NiwgSmlhbWVpIFhpZSB3cm90ZToN Cj4gPj4gV2hlbiB0aGUgZ3Vlc3Qga2VybmVsIGVuYWJsZXMgRE1BIGVuZ2luZSB3aXRoDQo+ICJD T05GSUdfRE1BX0VOR0lORT15IiwNCj4gPj4gTGludXggU0JTQSBQTDAxMSBkcml2ZXIgd2lsbCBh Y2Nlc3MgUEwwMTEgRE1BQ1IgcmVnaXN0ZXIgaW4gc29tZQ0KPiA+PiBmdW5jdGlvbnMuIEFzIGNo YXB0ZXIgIkIgR2VuZXJpYyBVQVJUIiBpbiAiQVJNIFNlcnZlciBCYXNlIFN5c3RlbQ0KPiA+PiBB cmNoaXRlY3R1cmUiWzFdIGRvY3VtZW50YXRpb24gZGVzY3JpYmVzLCBTQlNBIFVBUlQgZG9lc24n dCBzdXBwb3J0DQo+ID4+IERNQS4gSW4gY3VycmVudCBjb2RlLCB3aGVuIHRoZSBrZXJuZWwgdHJp ZXMgdG8gYWNjZXNzIERNQUNSIHJlZ2lzdGVyLA0KPiA+PiBYZW4gd2lsbCBpbmplY3QgYSBkYXRh IGFib3J0Og0KPiA+PiBVbmhhbmRsZWQgZmF1bHQgYXQgMHhmZmZmZmZjMDA5NDRkMDQ4DQo+ID4+ IE1lbSBhYm9ydCBpbmZvOg0KPiA+PiAgICBFU1IgPSAweDk2MDAwMDAwDQo+ID4+ICAgIEVDID0g MHgyNTogREFCVCAoY3VycmVudCBFTCksIElMID0gMzIgYml0cw0KPiA+PiAgICBTRVQgPSAwLCBG blYgPSAwDQo+ID4+ICAgIEVBID0gMCwgUzFQVFcgPSAwDQo+ID4+ICAgIEZTQyA9IDB4MDA6IHR0 YnIgYWRkcmVzcyBzaXplIGZhdWx0DQo+ID4+IERhdGEgYWJvcnQgaW5mbzoNCj4gPj4gICAgSVNW ID0gMCwgSVNTID0gMHgwMDAwMDAwMA0KPiA+PiAgICBDTSA9IDAsIFduUiA9IDANCj4gPj4gc3dh cHBlciBwZ3RhYmxlOiA0ayBwYWdlcywgMzktYml0IFZBcywgcGdkcD0wMDAwMDAwMDIwZTJlMDAw DQo+ID4+IFtmZmZmZmZjMDA5NDRkMDQ4XSBwZ2Q9MTAwMDAwMDAzZmZmZjgwMywgcDRkPTEwMDAw MDAwM2ZmZmY4MDMsDQo+IHB1ZD0xMDAwMDAwMDNmZmZmODAzLCBwbWQ9MTAwMDAwMDAzZmZmYTgw MywgcHRlPTAwNjgwMDAwOWMwOTBmMTMNCj4gPj4gSW50ZXJuYWwgZXJyb3I6IHR0YnIgYWRkcmVz cyBzaXplIGZhdWx0OiA5NjAwMDAwMCBbIzFdIFBSRUVNUFQgU01QDQo+ID4+IC4uLg0KPiA+PiBD YWxsIHRyYWNlOg0KPiA+PiAgIHBsMDExX3N0b3BfcngrMHg3MC8weDgwDQo+ID4+ICAgdHR5X3Bv cnRfc2h1dGRvd24rMHg3Yy8weGI0DQo+ID4+ICAgdHR5X3BvcnRfY2xvc2UrMHg2MC8weGNjDQo+ ID4+ICAgdWFydF9jbG9zZSsweDM0LzB4OGMNCj4gPj4gICB0dHlfcmVsZWFzZSsweDE0NC8weDRj MA0KPiA+PiAgIF9fZnB1dCsweDc4LzB4MjIwDQo+ID4+ICAgX19fX2ZwdXQrMHgxYy8weDMwDQo+ ID4+ICAgdGFza193b3JrX3J1bisweDg4LzB4YzANCj4gPj4gICBkb19ub3RpZnlfcmVzdW1lKzB4 OGQwLzB4MTIzYw0KPiA+PiAgIGVsMF9zdmMrMHhhOC8weGMwDQo+ID4+ICAgZWwwdF82NF9zeW5j X2hhbmRsZXIrMHhhNC8weDEzMA0KPiA+PiAgIGVsMHRfNjRfc3luYysweDFhMC8weDFhNA0KPiA+ PiBDb2RlOiBiOTAwMDA4MyBiOTAxZjAwMSA3OTQwMzhhMCA4YjAwMDA0MiAoYjkwMDAwNDEpDQo+ ID4+IC0tLVsgZW5kIHRyYWNlIDgzZGQ5M2RmMTVjMzIxNmYgXS0tLQ0KPiA+PiBub3RlOiBib290 bG9nZFsxMzJdIGV4aXRlZCB3aXRoIHByZWVtcHRfY291bnQgMQ0KPiA+PiAvZXRjL3JjUy5kL1Mw N2Jvb3Rsb2dkOiBsaW5lIDQ3OiAxMzIgU2VnbWVudGF0aW9uIGZhdWx0IHN0YXJ0LXN0b3AtDQo+ IGRhZW1vbg0KPiA+Pg0KPiA+PiBBcyBkaXNjdXNzZWQgaW4gWzJdLCB0aGlzIGNvbW1pdCBtYWtl cyB0aGUgYWNjZXNzIHRvIERNQUNSIHJlZ2lzdGVyDQo+ID4+IHdyaXRlLWlnbm9yZSBhcyBhbiBp bXByb3ZlbWVudC4NCj4gPg0KPiA+IERpZG4ndCB3ZSBhZ3JlZSB0byBlbXVsYXRlIGFsbCBub24t U0JTQSByZWdpc3RlcnMgYXMgV0k/IElPVywgdGhlDQo+ID4gZGVmYXVsdCBjYXNlIHNob3VsZCBj b250YWluIGEgJ2dvdG8gd3JpdGVfaWdub3JlJyByYXRoZXIgcmV0dXJuIDAuDQo+ICsgd2UgYWxz byBhZ3JlZWQgb24gZW11bGF0aW5nIHRoZSByZWFkcyB0byBub24gc3BlYyBjb21wbGlhbnQgcmVn aXN0ZXJzIGFzDQo+IFJBWi4NCg0KVGhhbmtzIGZvciByZW1pbmRpbmcgbWUgb2YgdGhpcy4gSSds bCAgZW11bGF0aW5nIHRoZSByZWFkcyB0byBub24gc3BlYyBjb21wbGlhbnQgcmVnaXN0ZXJzIGFz DQpSQVogaW4gcGF0Y2ggdjMuDQoNCkJlc3Qgd2lzaGVzDQpKaWFtZWkgWGllDQoNCj4gDQo+ID4N Cj4gPj4NCj4gPj4gWzFdDQo+IGh0dHBzOi8vbmFtMTEuc2FmZWxpbmtzLnByb3RlY3Rpb24ub3V0 bG9vay5jb20vP3VybD1odHRwcyUzQSUyRiUyRmRldmUNCj4gbG9wZXIuYXJtLmNvbSUyRmRvY3Vt ZW50YXRpb24lMkZkZW4wMDk0JTJGYyUyRiUzRmxhbmclM0RlbiZhbQ0KPiBwO2RhdGE9MDUlN0Mw MSU3Q21pY2hhbC5vcnplbCU0MGFtZC5jb20lN0MxMDY1NzAyYjRmZDI0NTdjZGJmODANCj4gOGRh Y2M4NGI0NWElN0MzZGQ4OTYxZmU0ODg0ZTYwOGUxMWE4MmQ5OTRlMTgzZCU3QzAlN0MwJTdDNjM4 MA0KPiA0NzE2NzYwMDc4NjU4MCU3Q1Vua25vd24lN0NUV0ZwYkdac2IzZDhleUpXSWpvaU1DNHdM akF3TURBaQ0KPiBMQ0pRSWpvaVYybHVNeklpTENKQlRpSTZJazFoYVd3aUxDSlhWQ0k2TW4wJTNE JTdDMzAwMCU3QyU3QyU3QyYNCj4gYW1wO3NkYXRhPVcxZGJha3c2bGtHa3Y0eWRFbElpJTJCYTd1 VDdlN1B0NWRCM3ZEdFlwUCUyRnFRJTNEJmENCj4gbXA7cmVzZXJ2ZWQ9MA0KPiA+PiBbMl0NCj4g aHR0cHM6Ly9uYW0xMS5zYWZlbGlua3MucHJvdGVjdGlvbi5vdXRsb29rLmNvbS8/dXJsPWh0dHBz JTNBJTJGJTJGbG9yZS4NCj4ga2VybmVsLm9yZyUyRnhlbi0NCj4gZGV2ZWwlMkZhbHBpbmUuREVC LjIuMjIuMzk0LjIyMTExNjE1NTI0MjAuNDAyMCU0MHVidW50dS1saW51eC0yMC0wNC0NCj4gZGVz a3RvcCUyRiZhbXA7ZGF0YT0wNSU3QzAxJTdDbWljaGFsLm9yemVsJTQwYW1kLmNvbSU3QzEwNjU3 MDINCj4gYjRmZDI0NTdjZGJmODA4ZGFjYzg0YjQ1YSU3QzNkZDg5NjFmZTQ4ODRlNjA4ZTExYTgy ZDk5NGUxODNkJTdDDQo+IDAlN0MwJTdDNjM4MDQ3MTY3NjAwNzg2NTgwJTdDVW5rbm93biU3Q1RX RnBiR1pzYjNkOGV5SldJam9pDQo+IE1DNHdMakF3TURBaUxDSlFJam9pVjJsdU16SWlMQ0pCVGlJ NklrMWhhV3dpTENKWFZDSTZNbjAlM0QlN0MzMA0KPiAwMCU3QyU3QyU3QyZhbXA7c2RhdGE9TzR6 eHVJM0hxUkExYmRyYUdjVlZZOHZWMEhHYnFPSTNuRmElMkYNCj4gY2lDMWNHUSUzRCZhbXA7cmVz ZXJ2ZWQ9MA0KPiA+Pg0KPiA+PiBTaWduZWQtb2ZmLWJ5OiBKaWFtZWkgWGllIDxqaWFtZWkueGll QGFybS5jb20+DQo+ID4+IC0tLQ0KPiA+PiAgIHhlbi9hcmNoL2FybS92cGwwMTEuYyB8IDQgKysr Kw0KPiA+PiAgIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykNCj4gPj4NCj4gPj4gZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL2FybS92cGwwMTEuYyBiL3hlbi9hcmNoL2FybS92cGwwMTEuYw0K PiA+PiBpbmRleCA0MzUyMmQ0OGZkLi5lOTdmZTNlYmU3IDEwMDY0NA0KPiA+PiAtLS0gYS94ZW4v YXJjaC9hcm0vdnBsMDExLmMNCj4gPj4gKysrIGIveGVuL2FyY2gvYXJtL3ZwbDAxMS5jDQo+ID4+ IEBAIC00NjMsNiArNDYzLDEwIEBAIHN0YXRpYyBpbnQgdnBsMDExX21taW9fd3JpdGUoc3RydWN0 IHZjcHUgKnYsDQo+ID4+ICAgICAgIGNhc2UgRlI6DQo+ID4+ICAgICAgIGNhc2UgUklTOg0KPiA+ PiAgICAgICBjYXNlIE1JUzoNCj4gPj4gKyAgICBjYXNlIERNQUNSOg0KPiA+PiArICAgICAgICBw cmludGsoWEVOTE9HX0dfREVCVUcNCj4gPj4gKyAgICAgICAgICAgICAgICJ2cGwwMTE6IFdJIG9u IHJlZ2lzdGVyIG9mZnNldCAlIzA4eFxuIiwNCj4gPj4gKyAgICAgICAgICAgICAgIHZwbDAxMV9y ZWcpOw0KPiA+DQo+ID4gSU1ITywgdGhpcyBtZXNzYWdlIHNob3VsZCBiZSBwcmludGVkIGp1c3Qg YWZ0ZXIgdGhlIHdyaXRlX2lnbm9yZSBsYWJlbC4NCj4gPg0KPiA+PiAgICAgICAgICAgZ290byB3 cml0ZV9pZ25vcmU7DQo+ID4+DQo+ID4+ICAgICAgIGNhc2UgSU1TQzoNCj4gPg0KPiA+IENoZWVy cywNCj4gPg0KPiA+IC0tDQo+ID4gSnVsaWVuIEdyYWxsDQo+ID4NCj4gDQo+IH5NaWNoYWwNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 23 07:40:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 07:40:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447414.703603 (Exim 4.92) (envelope-from ) id 1oxkMS-0007zJ-Be; Wed, 23 Nov 2022 07:40:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447414.703603; Wed, 23 Nov 2022 07:40:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxkMS-0007zC-8d; Wed, 23 Nov 2022 07:40:00 +0000 Received: by outflank-mailman (input) for mailman id 447414; Wed, 23 Nov 2022 07:39:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxkMQ-0007z6-Gb for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 07:39:58 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0206c3a1-6b02-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 08:39:49 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 673FB1F8C3; Wed, 23 Nov 2022 07:39:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4528513AE7; Wed, 23 Nov 2022 07:39:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fvxFD0zOfWOUWQAAMHmgww (envelope-from ); Wed, 23 Nov 2022 07:39:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0206c3a1-6b02-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669189196; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mrCiJ0zlcHkhAJ/ZATPapXHMPwLYR0ZBTjb0deb4pU4=; b=M9sehXuMQlKKXzqmzRp73iNavWX1tiMd4hJel8Cw8wW40GTh0bGwXxpWzcXO9gtnVuRwNd Ev9YjE7Rx+4tQi81h+1hJm4X9/M36Qj5mNUOfbJ9qIr3uvIvZ+HKsfbUXT4x1KfzAgXZkm SMu6aiqzPz5Rs5W5Y2msesrsxmgRKzY= Message-ID: Date: Wed, 23 Nov 2022 08:39:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: EFI's -mapbs option may cause Linux to panic() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper References: <60663f81-09cd-e46b-bb94-1afe50519086@suse.com> <296f95d8-5506-c95d-1c14-915cbf3e4f30@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------JiZcaR5veqr4OGegtPvMZoeK" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------JiZcaR5veqr4OGegtPvMZoeK Content-Type: multipart/mixed; boundary="------------A7QSf6QomC8MDjaK2WDqUOzu"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper Message-ID: Subject: Re: EFI's -mapbs option may cause Linux to panic() References: <60663f81-09cd-e46b-bb94-1afe50519086@suse.com> <296f95d8-5506-c95d-1c14-915cbf3e4f30@suse.com> In-Reply-To: --------------A7QSf6QomC8MDjaK2WDqUOzu Content-Type: multipart/mixed; boundary="------------aAo1QpUoAJw3bzlWVdkj00FP" --------------aAo1QpUoAJw3bzlWVdkj00FP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjIuMTEuMjIgMTA6NDcsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+IE9uIE1vbiwg Tm92IDIxLCAyMDIyIGF0IDA2OjAxOjAwUE0gKzAxMDAsIEphbiBCZXVsaWNoIHdyb3RlOg0K Pj4gT24gMjEuMTEuMjAyMiAxNzo0OCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+PiBP biBNb24sIE5vdiAyMSwgMjAyMiBhdCAwNToyNzoxNlBNICswMTAwLCBKYW4gQmV1bGljaCB3 cm90ZToNCj4+Pj4gSGVsbG8sDQo+Pj4+DQo+Pj4+IG9uIGEgc3lzdGVtIHdpdGggdGhlc2Ug Zmlyc3QgdHdvIEVGSSBtZW1vcnkgbWFwIGVudHJpZXMNCj4+Pj4NCj4+Pj4gKFhFTikgIDAw MDAwMDAwMDAwMDAtMDAwMDAwMDA5ZGZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBm DQo+Pj4+IChYRU4pICAwMDAwMDAwMDllMDAwLTAwMDAwMDAwOWZmZmYgdHlwZT0yIGF0dHI9 MDAwMDAwMDAwMDAwMDAwZg0KPj4+Pg0KPj4+PiBpLmUuIGV4Y2VwdCBmb3IgMiBwYWdlcyBh bGwgc3BhY2UgYmVsb3cgMU0gYmVpbmcgQm9vdFNlcnZpY2VzRGF0YSwgdGhlDQo+Pj4+IC1t YXBicyBvcHRpb24gaGFzIHRoZSBlZmZlY3Qgb2YgbWFya2luZyByZXNlcnZlZCBhbGwgdGhh dCBzcGFjZS4gVGhlbg0KPj4+PiBMaW51eCBmYWlscyB0cnlpbmcgdG8gYWxsb2NhdGUgaXRz IGxvd21lbSB0cmFtcG9saW5lICh3aGljaCByZWFsbHkgaXQNCj4+Pj4gc2hvdWxkbid0IG5l ZWQgd2hlbiBydW5uaW5nIGluIFBWIG1vZGUpLCB1bHRpbWF0ZWx5IGxlYWRpbmcgdG8NCj4+ Pj4NCj4+Pj4gCQlwYW5pYygiUmVhbCBtb2RlIHRyYW1wb2xpbmUgd2FzIG5vdCBhbGxvY2F0 ZWQiKTsNCj4+Pj4NCj4+Pj4gaW4gdGhlaXIgaW5pdF9yZWFsX21vZGUoKS4NCj4+Pj4NCj4+ Pj4gV2hpbGUgZm9yIFBWIEkgdGhpbmsgaXQgaXMgY2xlYXIgdGhhdCB0aGUgZWFzaWVzdCBp cyB0byBhdm9pZA0KPj4+PiB0cmFtcG9saW5lIHNldHVwIGluIHRoZSBmaXJzdCBwbGFjZSwg aWlyYyBQVkggRG9tMCBhbHNvIHRyaWVzIHRvDQo+Pj4+IG1pcnJvciB0aGUgaG9zdCBtZW1v cnkgbWFwIHRvIGl0cyBvd24gYWRkcmVzcyBzcGFjZS4gRG9lcyBQVkggTGludXgNCj4+Pj4g cmVxdWlyZSBhIGxvd21lbSB0cmFtcG9saW5lPw0KPj4+DQo+Pj4gWWVzLCBpdCBkb2VzIEFG QUlLLiAgSSBndWVzcyB0aG9zZSB0d28gcGFnZXMgd29uJ3QgYmUgZW5vdWdoIGZvcg0KPj4+ IExpbnV4IGJvb3QgdHJhbXBvbGluZSByZXF1aXJlbWVudHMgdGhlbi4NCj4+Pg0KPj4+IEkg YXNzdW1lIG5hdGl2ZSBMaW51eCBpcyBmaW5lIHdpdGggdGhpcyBtZW1vcnkgbWFwIGJlY2F1 c2UgaXQgcmVjbGFpbXMNCj4+PiB0aGUgRWZpQm9vdFNlcnZpY2VzRGF0YSByZWdpb24gYW5k IHRoYXQncyBlbm91Z2guDQo+Pg0KPj4gVGhhdCdzIG15IHVuZGVyc3RhbmRpbmcgYXMgd2Vs bC4NCj4+DQo+Pj4+IFdoaWxlIHRoZSB0d28gcGFnZXMgaGVyZSBhcmUganVzdCBlbm91Z2gg Zm9yIFhlbidzIHRyYW1wb2xpbmUsIEkgc3RpbGwNCj4+Pj4gd29uZGVyIHdoZXRoZXIgd2Ug d2FudCB0byBhZGp1c3QgLW1hcGJzIGJlaGF2aW9yLiBTaW5jZSB3aGF0ZXZlciB3ZQ0KPj4+ PiBtaWdodCBkbyBsZWF2ZXMgYSByaXNrIG9mIGNvbmZsaWN0aW5nIHdpdGggdHJ1ZSBmaXJt d2FyZSAobWlzKXVzZSBvZg0KPj4+PiB0aGF0IHNwYWNlLCB0aGUgYmVzdCBJIGNhbiB0aGlu ayBvZiByaWdodCBub3cgd291bGQgYmUgYW5vdGhlciBvcHRpb24NCj4+Pj4gYWx0ZXJpbmcg YmVoYXZpb3IgKG9yIHByb3ZpZGluZyBhbHRlcmVkIGJlaGF2aW9yKS4gWWV0IHN1Y2ggYW4g b3B0aW9uDQo+Pj4+IHdvdWxkIGxpa2VseSBuZWVkIHRvIGJlIG1vcmUgZmluZS1ncmFpbmVk IHRoZW4gdGhhbiBjb3ZlcmluZyBhbGwgb2YNCj4+Pj4gdGhlIGxvdyBNYiBpbiBvbmUgZ28u IFdoaWNoIGZlZWxzIGxpa2UgYm90aCBnb2luZyB0b28gZmFyIGFuZCBtYWtpbmcNCj4+Pj4g aXQgYXdrd2FyZCBmb3IgcGVvcGxlIHRvIGZpZ3VyZSBvdXQgd2hhdCB2YWx1ZShzKSB0byB1 c2UgLi4uDQo+Pj4+DQo+Pj4+IFRob3VnaHRzIGFueW9uZT8NCj4+Pg0KPj4+IEknbSB1bnN1 cmUgd2hhdCB0byByZWNvbW1lbmQuICBUaGUgbWFwYnMgb3B0aW9uIGlzIGEgd29ya2Fyb3Vu ZCBmb3INCj4+PiBicm9rZW4gZmlybXdhcmUsIGFuZCBpdCdzIG5vdCBlbmFibGVkIGJ5IGRl ZmF1bHQsIHNvIHdlIG1pZ2h0IGJlIGx1Y2t5DQo+Pj4gYW5kIG5ldmVyIGZpbmQgYSBzeXN0 ZW0gd2l0aCBhIG1lbW9yeSBtYXAgbGlrZSB5b3UgZGVzY3JpYmUgdGhhdCBhbHNvDQo+Pj4g cmVxdWlyZXMgbWFwYnMgaW4gb3JkZXIgdG8gYm9vdC4NCj4+DQo+PiBHdWVzcyBob3cgd2Un dmUgbGVhcm5lZCBvZiB0aGUgaXNzdWU6IFN5c3RlbXMgbWF5IGJvb3QgZmluZSB3aXRob3V0 DQo+PiAtbWFwYnMsIGJ1dCB0aGV5IG1heSBmYWlsIHRvIHJlYm9vdCBiZWNhdXNlIG9mIHRo YXQgKGluKWZhbW91cyBpc3N1ZSBvZg0KPj4gZmlybXdhcmUgd3JpdGVycyBub3QgcHJvcGVy bHkgc2VwYXJhdGluZyBib290IHNlcnZpY2VzIGNvZGUgcGF0aHMgZnJvbQ0KPj4gcnVudGlt ZSBzZXJ2aWNlcyBvbmVzLiBBbmQgdGhlcmUgd2UncmUgZGVhbGluZyB3aXRoIGEgc3lzdGVt IHdoZXJlIEkNCj4+IHN1c3BlY3QgdGhpcyB0byBiZSB0aGUgY2FzZSwganVzdCB0aGF0IC0g dW5saWtlIGluIGVhcmxpZXIgc2ltaWxhcg0KPj4gY2FzZXMgLSB0aGVyZSdzIG5vICJjbGVh biIgY3Jhc2ggcHJvdmluZyB0aGUgaXNzdWUgKHRoZSBzeXN0ZW0gc2ltcGx5DQo+PiBoYW5n cykuIEhlbmNlIG15IHJlcXVlc3QgdGhhdCB0aGV5IHVzZSAtbWFwYnMgdG8gdHJ5IHRvIGZp Z3VyZSBvdXQuDQo+Pg0KPj4gQW5kIHllcywgInJlYm9vdD1hY3BpIiBoZWxwcyB0aGVyZSwg YnV0IHRoZXkgaW5zaXN0IG9uIGtub3dpbmcgd2hhdA0KPj4gY29tcG9uZW50IGlzIHRvIGJs YW1lLg0KPiANCj4gV2VsbCwgaWYgcmVib290PWFjcGkgZml4ZXMgaXQgdGhlbiBpdCdzIHF1 aXRlIGNsZWFyIEVGSSByZWJvb3QgbWV0aG9kDQo+IGlzIHRvIGJsYW1lPw0KPiANCj4gT3Ig dGhleSB3YW50IHRvIGtub3cgdGhlIGV4YWN0IGNhdXNlIHRoYXQgbWFrZXMgRUZJIHJlYm9v dCBmYWlsLA0KPiBiZWNhdXNlIHRoYXQncyBxdWl0ZSBkaWZmaWN1bHQgdG8gZmlndXJlIG91 dCBmcm9tIG91ciBlbmQuDQo+IA0KPiBCdXQgSSdtIGFmcmFpZCBJIGRvbid0IHNlZSBhbnkg c29sdXRpb24gdG8gbWFrZSBtYXBicyB3b3JrIHdpdGggYSBQVkgNCj4gZG9tMCBvbiBhIHN5 c3RlbSB3aXRoIGEgbWVtb3J5IG1hcCBsaWtlIHlvdSBwcm92aWRlZCwgc2hvcnQgb2YgYWRk aW5nDQo+IHNvbWUga2luZCBvZiBib2RnZSB0byBub3QgbWFwIGFuZCBtYXJrIGFzIHJlc2Vy dmVkIG1lbW9yeSBiZWxvdyAxTUINCj4gKGJ1dCB0aGF0IGtpbmQgb2YgZGVmZWF0cyB0aGUg cHVycG9zZSBvZiBtYXBicykuDQoNCldoYXQgd2UgY291bGQgZG8gaW4gc3VjaCBhIGNhc2Ug d291bGQgYmUgdG8gaW5oaWJpdCBzdXNwZW5kaW5nIHRoZQ0Kc3lzdGVtLCBhbmQgdG8gcnVu IGRvbTAgd2l0aCBhIHNpbmdsZSBjcHUgb25seS4gQW4gZXJyb3IgbWVzc2FnZQ0KaW5kaWNh dGluZyB0aGF0IHRoZSBzeXN0ZW0gc2hvdWxkIGJlIGJvb3RlZCB3aXRob3V0IG1hcGJzIHNo b3VsZCBiZQ0KaXNzdWVkLCBvZiBjb3Vyc2UuDQoNCg0KSnVlcmdlbg0K --------------aAo1QpUoAJw3bzlWVdkj00FP Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------aAo1QpUoAJw3bzlWVdkj00FP-- --------------A7QSf6QomC8MDjaK2WDqUOzu-- --------------JiZcaR5veqr4OGegtPvMZoeK Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmN9zksFAwAAAAAACgkQsN6d1ii/Ey/Z cAgAncLZsSwwuAQa1rn05VaqFmkOTFNJiifijltWHObwDjux35GtqHMxNrv0SP3+SDt+aKFjl0sU 7CN7VW4SPO11qnbtWhouGuxyscWukgSfvDss+71aQC4q/t9wu21XWgU8YQYq4T2Lf+uGz/c9WA3g esjWrCcnoQDNnp36JpLFQzp6wndlX0lgtM0vepYVfoPgngmAH5VRF8rk+7pXtnREE6rT5IF3gJd8 I+VSkKs7FteqH8vR/EKpzQ7wXzk/VDGscPThhRR5c/ElM04giRW9gXrsLAPWdJ40WyU8onJ2+CLB cDW8acEQ8NTksgfW/wlU6YTKY/zlrHVNm68AWFB3tw== =p5Xq -----END PGP SIGNATURE----- --------------JiZcaR5veqr4OGegtPvMZoeK-- From xen-devel-bounces@lists.xenproject.org Wed Nov 23 08:15:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 08:15:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447424.703619 (Exim 4.92) (envelope-from ) id 1oxkum-0004o5-Jk; Wed, 23 Nov 2022 08:15:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447424.703619; Wed, 23 Nov 2022 08:15:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxkum-0004ny-Gw; Wed, 23 Nov 2022 08:15:28 +0000 Received: by outflank-mailman (input) for mailman id 447424; Wed, 23 Nov 2022 08:15:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxkul-0004no-N6; Wed, 23 Nov 2022 08:15:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxkul-0006zl-LK; Wed, 23 Nov 2022 08:15:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxkul-0002SO-Br; Wed, 23 Nov 2022 08:15:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxkul-0001dq-BR; Wed, 23 Nov 2022 08:15:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Y0ODUPL0JWKuX8+AXxn3+tbcLXtdGXtRnjNNutOHkCk=; b=OxzDAXq6OIpnAgI7JOF1bQEPHc IbAUu3p1qfjcG51LRza6ViPrHERUXBWKXRC+t/HBcxQRCQq9RpJ4BL35W5JNCLA5y7aIp/60/HyMM FWNcNf1ZKdmc85fc0XCX3I6T7FxsJeGJK6oCjfBKJDqh8KfsizgjuVskPGi3MOcIwFiA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174928: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 23 Nov 2022 08:15:27 +0000 flight 174928 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174928/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 46 days Failing since 173470 2022-10-08 06:21:34 Z 46 days 83 attempts Testing same since 174871 2022-11-21 00:40:59 Z 2 days 6 attempts ------------------------------------------------------------ 1802 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 171425 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Nov 23 08:39:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 08:39:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447431.703631 (Exim 4.92) (envelope-from ) id 1oxlHz-0007TN-Ic; Wed, 23 Nov 2022 08:39:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447431.703631; Wed, 23 Nov 2022 08:39:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlHz-0007TG-Es; Wed, 23 Nov 2022 08:39:27 +0000 Received: by outflank-mailman (input) for mailman id 447431; Wed, 23 Nov 2022 08:39:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlHy-0007T6-47; Wed, 23 Nov 2022 08:39:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlHy-0007Ne-14; Wed, 23 Nov 2022 08:39:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlHx-00035P-QM; Wed, 23 Nov 2022 08:39:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxlHx-0000Ew-Pv; Wed, 23 Nov 2022 08:39:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=hDILsS9Dys6ONGHgMXu10KIZyr8M30gE1WbEIAGZ7RM=; b=Dri1pxUukcz2Ot7nPm+SYGUuXd sLLKdHSDSA0CjUmYLVB6cW0PW1X1WGQhBm6DC6WBmm/Nusf+YOWMg8Fvvhu5XinzWz+2+ISlIpTCG mgBey6dRB7Wm3HVvpzE5Y4GbvTgBsHE3dih8R8B3S8paXJm5IbJfsfjw9vcbzG1dZ4yI=; To: xen-devel@lists.xenproject.org Subject: [xen-unstable bisection] complete test-amd64-amd64-xl-qemut-debianhvm-i386-xsm Message-Id: From: osstest service owner Date: Wed, 23 Nov 2022 08:39:25 +0000 branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-qemut-debianhvm-i386-xsm testid guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Bug not present: bd87315a603bf25e869e6293f7db7b1024d67999 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174941/ commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test-amd64-amd64-xl-qemut-debianhvm-i386-xsm.guest-saverestore.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable/test-amd64-amd64-xl-qemut-debianhvm-i386-xsm.guest-saverestore --summary-out=tmp/174941.bisection-summary --basis-template=174797 --blessings=real,real-bisect,real-retry xen-unstable test-amd64-amd64-xl-qemut-debianhvm-i386-xsm guest-saverestore Searching for failure / basis pass: 174881 fail [host=nocera1] / 174797 [host=fiano0] 174791 [host=debina0] 174773 [host=pinot1] 174769 [host=huxelrebe1] 174762 [host=albana1] 174753 [host=debina1] 174747 [host=sabro1] 174742 [host=elbling0] 174733 [host=huxelrebe0] 174724 [host=himrod0] 174701 [host=italia1] 174682 [host=nobling1] 174670 [host=italia0] 174663 [host=nobling0] 174652 [host=godello0] 174641 [host=godello1] 174636 [host=fiano1] 174629 [host=chardonnay1] 174607 [host=chardonnay0] 174597 [host=albana0] 174586 [host=de\ bina0] 174574 [host=elbling1] 174563 [host=pinot1] 174547 [host=fiano0] 174542 [host=debina1] 174538 [host=pinot0] 174534 [host=sabro1] 174526 [host=albana1] 174499 [host=nocera0] 174435 [host=himrod0] 174367 [host=nobling0] 174285 [host=italia0] 174252 [host=godello1] 174210 [host=fiano1] 174165 [host=sabro0] 174057 [host=huxelrebe0] 173920 [host=chardonnay1] 173812 [host=nobling1] 173738 [host=sabro1] 173663 [host=fiano0] 173488 [host=albana1] 173482 [host=himrod0] 173466 [host=nobling0] 17345\ 9 [host=pinot0] 173452 [host=nocera0] 173436 [host=italia0] 173430 [host=sabro0] 173422 [host=debina0] 173416 [host=italia1] 173412 [host=debina1] 173402 [host=elbling0] 173398 [host=chardonnay1] 173394 ok. Failure / basis pass flights: 174881 / 173394 (tree with no url: minios) (tree with no url: ovmf) (tree with no url: seabios) Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Latest c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 Basis pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 1666086b00442b23e4fd70f4971e3bcf1a16b124 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#c3038e718a19fc596f7b1baba0f83d5146dc7784-c3038e718a19fc596f7b1baba0f83d5146dc7784 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#b746458e1ce1bec85e58b458386f8b7\ a0bedfaa6-b746458e1ce1bec85e58b458386f8b7a0bedfaa6 git://xenbits.xen.org/xen.git#1666086b00442b23e4fd70f4971e3bcf1a16b124-db8fa01c61db0317a9ee947925226234c65d48e8 Loaded 5001 nodes in revision graph Searching for test results: 173812 [host=nobling1] 173920 [host=chardonnay1] 174057 [host=huxelrebe0] 174133 [host=sabro0] 174165 [host=sabro0] 174210 [host=fiano1] 174252 [host=godello1] 174285 [host=italia0] 174367 [host=nobling0] 174435 [host=himrod0] 174499 [host=nocera0] 174526 [host=albana1] 174534 [host=sabro1] 174538 [host=pinot0] 174542 [host=debina1] 174547 [host=fiano0] 174563 [host=pinot1] 174574 [host=elbling1] 174586 [host=debina0] 174597 [host=albana0] 174607 [host=chardonnay0] 174629 [host=chardonnay1] 174636 [host=fiano1] 174641 [host=godello1] 174652 [host=godello0] 174663 [host=nobling0] 174670 [host=italia0] 174682 [host=nobling1] 174701 [host=italia1] 174724 [host=himrod0] 174733 [host=huxelrebe0] 174742 [host=elbling0] 174747 [host=sabro1] 174753 [host=debina1] 174762 [host=albana1] 174769 [host=huxelrebe1] 174773 [host=pinot1] 174791 [host=debina0] 174797 [host=fiano0] 174814 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174819 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174826 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174843 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174854 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174865 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174874 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174881 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174921 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 1666086b00442b23e4fd70f4971e3bcf1a16b124 174922 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db8fa01c61db0317a9ee947925226234c65d48e8 174924 blocked c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 3b5beaf49033cddf4b2cc4e4d391b966f4203471 174926 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db471408edd46af403b8bd44d180a928ad7fbb80 174927 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 08c6f57cfebad4046dabc05092b4a27c61a39980 174929 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 97abc04e387bb070f9c917269be0ff4e5a813bcf 174931 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f5d56f4b253072264efc0fece698a91779e362f5 174932 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 22b20bd98c025e06525410e3ab3494d5e63489f7 174934 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174936 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e 174938 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174939 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e 174940 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 174941 fail c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e 173394 pass c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 1666086b00442b23e4fd70f4971e3bcf1a16b124 173398 [host=chardonnay1] 173402 [host=elbling0] 173412 [host=debina1] 173416 [host=italia1] 173422 [host=debina0] 173430 [host=sabro0] 173436 [host=italia0] 173452 [host=nocera0] 173459 [host=pinot0] 173477 [host=himrod0] 173466 [host=nobling0] 173482 [host=himrod0] 173488 [host=albana1] 173738 [host=sabro1] 173663 [host=fiano0] Searching for interesting versions Result found: flight 173394 (pass), for basis pass For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999, results HASH(0x558bf74c5c58) HASH(0x558bf74cd658) HASH(0x558bf6ee0250) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1\ ce1bec85e58b458386f8b7a0bedfaa6 22b20bd98c025e06525410e3ab3494d5e63489f7, results HASH(0x558bf7438ba8) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f5d56f4b253072264efc0fece698a91779e362f5, results HASH(0x558bf7430b60) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f\ 0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 97abc04e387bb070f9c917269be0ff4e5a813bcf, results HASH(0x558bf742b928) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 08c6f57cfebad4046dabc05092b4a27c61a39980, results HASH(0x558bf743e3e0) For basis failure, parent search stopping at c3038e718a19\ fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 db471408edd46af403b8bd44d180a928ad7fbb80, results HASH(0x558bf74bd350) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 3b5beaf49033cddf4b2cc4e4d391b966f4203471, results HASH(0x558bf7434e9\ 8) For basis failure, parent search stopping at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 1666086b00442b23e4fd70f4971e3bcf1a16b124, results HASH(0x558bf742f158) HASH(0x558bf742d150) Result found: flight 174814 (fail), for basis failure (at ancestor ~732) Repro found: flight 174921 (pass), for basis pass Repro found: flight 174922 (fail), for basis failure 0 revisions at c3038e718a19fc596f7b1baba0f83d5146dc7784 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 bd87315a603bf25e869e6293f7db7b1024d67999 No revisions left to test, checking graph state. Result found: flight 174934 (pass), for last pass Result found: flight 174936 (fail), for first failure Repro found: flight 174938 (pass), for last pass Repro found: flight 174939 (fail), for first failure Repro found: flight 174940 (pass), for last pass Repro found: flight 174941 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Bug not present: bd87315a603bf25e869e6293f7db7b1024d67999 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174941/ commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang pnmtopng: 251 colors found Revision graph left in /home/logs/results/bisect/xen-unstable/test-amd64-amd64-xl-qemut-debianhvm-i386-xsm.guest-saverestore.{dot,ps,png,html,svg}. ---------------------------------------- 174941: tolerable ALL FAIL flight 174941 xen-unstable real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/174941/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 15 guest-saverestore fail baseline untested jobs: test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Wed Nov 23 08:45:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 08:45:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447438.703641 (Exim 4.92) (envelope-from ) id 1oxlNU-0000eU-BU; Wed, 23 Nov 2022 08:45:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447438.703641; Wed, 23 Nov 2022 08:45:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlNU-0000eN-8w; Wed, 23 Nov 2022 08:45:08 +0000 Received: by outflank-mailman (input) for mailman id 447438; Wed, 23 Nov 2022 08:45:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlNT-0000eH-BZ for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 08:45:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlNS-0007f8-V0; Wed, 23 Nov 2022 08:45:06 +0000 Received: from [54.239.6.185] (helo=[192.168.17.134]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxlNS-0007qQ-Mz; Wed, 23 Nov 2022 08:45:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=qxmfUAdRQQG/x8hp7Kbsx4WZpq7ukxDPxnFwRN8mpdk=; b=lTy/av9Ohktck/6osGe2VbJCXJ 0zVf3bhCTaMmnm37zU+jNs83O5u69O+A6LdptqhDq4gI04FcLoJeSW+kak6yTbI08pO9te9W1HNuS b2daM81CyWPchvV3yp/rnXFbvQh5dL3EMzO8egC8qdwli5bv/VXkt4cZIbq5DAPbtXvc=; Message-ID: <7b43c459-55db-58d4-840b-e13f11204211@xen.org> Date: Wed, 23 Nov 2022 09:45:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich , Andrew Cooper , Bertrand Marquis , Stefano Stabellini References: <20221122112623.1441905-1-Henry.Wang@arm.com> <20221122112623.1441905-2-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/11/2022 12:46, Henry Wang wrote: > Hi Julien, Hi Henry, > > Thanks for your review as always! > >> -----Original Message----- >> From: Julien Grall >> Subject: Re: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during >> the 4.17 release >> >> (Reducing the CC-list) > > Thanks, I will use this CC-list in v4. > >> >> Hi, >> >> On 22/11/2022 11:26, Henry Wang wrote: >>> Signed-off-by: Henry Wang >>> - - Support VIRT_SSBD feature for HVM guests on AMD. >>> + - Support VIRT_SSBD feature for HVM guests on AMD and >> MSR_SPEC_CTRL feature for >>> + SVM guests. >> >> Did you really intend to write "SVM" rather than HVM? If yes, then to me >> "HVM guests on AMD" means the same as "SVM guests". > > I am sorry about the confusion. I think the latter part of this sentence is > just a direct copy of title in [1]. But by reading the content of that > cover letter I think... > >> >> So I would suggest the following wording: >> >> Support for VIRT_SSBD and MSR_SPEC_CTRL for HVM guests on AMD. > > ...this is correct. So I will use your suggested sentence in v4. Thanks. > >> >>> + - Support VirtIO-MMIO devices in toolstack on Arm. >> >> I would clarify that this is *only* creating the device-tree binding. >> IOW, there are no support for ACPI nor device-emulator (still in >> progress from Xen Project PoV). > > You are correct. I will change to: > "Support VirtIO-MMIO devices device-tree binding creation in toolstack > on Arm" > >> >>> + - Allow setting the number of CPUs to activate at runtime from command >> line >>> + option on Arm. >>> + - Grant-table support on Arm was improved and hardened by >> implementing >>> + "simplified M2P-like approach for the xenheap pages" >>> + - Add Renesas R-Car Gen4 IPMMU-VMSA support on Arm. >>> + - Add i.MX lpuart and i.MX8QM initial support on Arm. >> >> I was under the impression that the code that was merged is enough to >> support the platform. Do you have any pointer where it says it is not >> sufficient? > > Ah this is also directly from the title of [2], where it is only a > "xen/arm: add i.MX lpuart and i.MX8QM initial support" > > I would be more than happy to remove the "initial" if you think it is > appropriate. I saw you already remove "initial" in v4 but I will still reply. On an earlier revision of the series I asked Peng if this was enough to boot Xen upstream on the platform and the answer was yes [3]. So I would assume that the basics work. Not sure about platform device passthrough. > >> >>> + - Improved toolstack build system. >>> + - Add Xue - console over USB 3 Debug Capability. >>> >>> ### Removed / support downgraded >>> - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" >> command line options > > [1] https://lore.kernel.org/xen-devel/20220128132927.14997-1-andrew.cooper3@citrix.com/ > [2] https://lore.kernel.org/xen-devel/20220419043927.23542-1-peng.fan@oss.nxp.com/ [3] https://lore.kernel.org/xen-devel/DU0PR04MB9417B86346491B63442D234D88139@DU0PR04MB9417.eurprd04.prod.outlook.com/ Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 23 08:50:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 08:50:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447442.703653 (Exim 4.92) (envelope-from ) id 1oxlSh-0002CQ-0V; Wed, 23 Nov 2022 08:50:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447442.703653; Wed, 23 Nov 2022 08:50:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlSg-0002CJ-SY; Wed, 23 Nov 2022 08:50:30 +0000 Received: by outflank-mailman (input) for mailman id 447442; Wed, 23 Nov 2022 08:50:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlSf-0002CC-43 for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 08:50:29 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0610.outbound.protection.outlook.com [2a01:111:f400:fe0e::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id deebd033-6b0b-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 09:50:26 +0100 (CET) Received: from AM6P192CA0085.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::26) by AS2PR08MB8477.eurprd08.prod.outlook.com (2603:10a6:20b:55b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 08:50:19 +0000 Received: from VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8d:cafe::1) by AM6P192CA0085.outlook.office365.com (2603:10a6:209:8d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15 via Frontend Transport; Wed, 23 Nov 2022 08:50:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT065.mail.protection.outlook.com (100.127.144.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 23 Nov 2022 08:50:19 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Wed, 23 Nov 2022 08:50:19 +0000 Received: from 15284aba1efa.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5C364947-8C31-4E3B-99DC-306DFC6F4E44.1; Wed, 23 Nov 2022 08:50:09 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 15284aba1efa.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 23 Nov 2022 08:50:09 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PA4PR08MB5950.eurprd08.prod.outlook.com (2603:10a6:102:e0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 08:50:06 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5857.017; Wed, 23 Nov 2022 08:50:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: deebd033-6b0b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LRmn/UkpYIsukzB+yoqI/GQN81Fgen5DU4CCDhrHLm0=; b=50U61TKhKqw+QaNRZ7n9k+uSizi9/sN5KB6sMhRM3/5laykpzlH7CBIXxp2vMYQznx38aJRtfymFNoBWsw1h6vEfS+FNlo2NeVQ891K7VhHACWVIcUmRs80qbwP4/+ENGzVK6syvvTDTcI4c/yln9SQygS81qh86wpekitKfUgE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eGcZ/AA4KDjgrf9ob6n92HpH9LQs4ZpI9MOxpKbvOG336Mw3RoAqSFaH2tqe66WtEoJ1+nuRCIL1+R6xxMFUnYawFIE13illxuxPOg8ZfhSA53I1Mu4CZoQYGhYCMtJYF7N+vN/wAxStvxHP6Y+bQENT4Bx7Rv8YaWk1rh/GAlZGVn+aqnJKtq9mx0MKUY8GoxV+60E3RnBc76+uy7gjyFplneYrfJEKxOUtq6G8NQ8E6067dSo7V/JCHgz6bHk7fLQeWzVb3hpQynof3CxGQHWdiW3Or3WQVTZPVk4+MbrKm7d17Ym1jcVn1u2IX688T0EEzIsXgmGlwlnB1ECmIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LRmn/UkpYIsukzB+yoqI/GQN81Fgen5DU4CCDhrHLm0=; b=YHdLNmKDj4qgOkPISPTuJHuomissF53zZVKRSlD1lRrRiT0hdbBpSIavyZGPWqVR8Ufx8Uy+xsDfwaLdLbz6Dux3KN3PkvHLLBqVWtGRJ4YeHIOSlcoHhN4zwjs+obrfS3IGsUbB32w4GrBPdbmmXJS+nTJDOXugaXmq+Kq52dteJIu1rX9dqlOAFVRmEKCuT0tr7lHFoHQHds5jyKbuVy7wEj+s92B0IfUuZ7oGI1jSiu3kVq3K7eblWm4FfGmn43ERAXJmBhaOYeNe6NzqCH6ZNz+LXMdbUqBZe5fsSvIwXdu263+hhLyKCmJuDlibXEfhOCt2nMCupvI5KIC4AQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LRmn/UkpYIsukzB+yoqI/GQN81Fgen5DU4CCDhrHLm0=; b=50U61TKhKqw+QaNRZ7n9k+uSizi9/sN5KB6sMhRM3/5laykpzlH7CBIXxp2vMYQznx38aJRtfymFNoBWsw1h6vEfS+FNlo2NeVQ891K7VhHACWVIcUmRs80qbwP4/+ENGzVK6syvvTDTcI4c/yln9SQygS81qh86wpekitKfUgE= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Jan Beulich , Andrew Cooper , Bertrand Marquis , Stefano Stabellini Subject: RE: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Thread-Topic: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Thread-Index: AQHY/mWeJ7PIIiwbMEi0iLnxeCbJiq5K2wSAgAAHBWCAAVDtgIAAAEvA Date: Wed, 23 Nov 2022 08:50:06 +0000 Message-ID: References: <20221122112623.1441905-1-Henry.Wang@arm.com> <20221122112623.1441905-2-Henry.Wang@arm.com> <7b43c459-55db-58d4-840b-e13f11204211@xen.org> In-Reply-To: <7b43c459-55db-58d4-840b-e13f11204211@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: FC8F253033153544A7C19989848B2C41.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PA4PR08MB5950:EE_|VI1EUR03FT065:EE_|AS2PR08MB8477:EE_ X-MS-Office365-Filtering-Correlation-Id: f236fa26-25e2-438f-e260-08dacd2fc00a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kFMOLVcp58v7ANaF3to6WW9e+w+oVt9vuLAU0mGcsd2eCPf6YnRzy2iEiABIEGYv2uOa06qD28aFubAMLJOSLWQOq7YRhqvEf5vHd69UqkNpl+foP9r99SDeBtS/bDDT4rS0NjN0ZeIFYfGhz9WU7oujGvt8QqsD2L+uFAjR5rJfg6HHuKUAv7fBCJaGzdivUUvnUWCwAxckzhvPE9GOurnqYUj6bqat2ntSweVdm6BQ2b8mpCBWcDZXsPydhG/ngD0ppsHRWubqKJn0wP/6UEmPBQu0GTXsIp5yA8m3yLkBzUk0ehgmQLPzNC8CY9gE0KXjBnudT54fdXHjydvrB0Jjph9+5eMr7qeKjcG6UUy5psl0v7xs/gUrpC8lzyRrjZE7mJ5SYvZwKJetn4dI/mj64DN7Tb0IihEkz311Qq0TwblHZ7hRFA031N3dbrx3YwzLj9qxriDEZiO1GIJWipmdU5IOvbKjryKQ3C9vK2q1WLP9GCKwXuNV0jH/Prts8uGR6eR8TtTLDkIiGaWARDsDLEYPbHtbNIw+fUNMAzFtEzPVGj9XrgzFgn/2xYMjgy1DT9mCGoEEai8tVSQvna2t02QHhV6Ss+x6pVTnVWrtQlgaPpyI6GLDwwZL2uMAbS0cgl8GivWBGdTc+rzFBZdckXHAJSYnqH2i9sgAUSQKgqah5EaCAvJRfryJgZTI3/i6TMmMhZaB5xUh5daPGcTHRRxnZl8zBQuzlORMD3Ydez0tugdK6Ori7DaSples6+k6hiQ5nd7JmYuaAM2Mf40ZV/mOq9BgsYJiCz5FpM0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(366004)(396003)(376002)(136003)(451199015)(41300700001)(52536014)(316002)(8936002)(64756008)(4326008)(5660300002)(66446008)(8676002)(66556008)(66946007)(54906003)(66476007)(55016003)(83380400001)(86362001)(76116006)(478600001)(26005)(110136005)(6506007)(71200400001)(2906002)(38070700005)(7696005)(9686003)(186003)(4744005)(33656002)(38100700002)(122000001)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5950 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5f7a472a-c43c-4ad1-bb71-08dacd2fb835 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tnuuv4CEgjwWXsPXRLpPngkvc9ztn1zuVjD5Ge2TDQm1A4ooQbDBSFU7GUGe7bXlqglUI+hGhxQP/xeuOhftBt1QbZOH/q6k7epx3D146UbC79hbQU3cOYkEJWgzJ3vXF7kTKIgAc0t719jyX7xZDqs7NG/1UR2kXvFZjpR8Gl5wXP//PAxt2d/k7WEwUC/xQUEpywO7OsoijUujF/dmrah/zmYzx3osqif14LM57uLQFjgL1tJmRRq5Lj+TSKMnvy/DIPBehh5+j0HQb/tPVDKuPtnoUczRvJGRfBrOJu5jKSJSACSIN+mOIN8d0aldewr+Y2CS0E/vRmznp4G0XrRhHNgQU5K7ZZAV1Udk6+8jn84r4o9tf3Z8RdARpYANSCXi0/fgmR4fnfqkpLSd7tIfWiJI6aM9pQSD4KscKYGcHtcJvx9x6H0GzBFljHmfCYxaeCr6+vCzdWfKcDwrIoXbC2ADGRtWCmYCjbRE37lmjtCK3k/pcbNm4H0eN5rTzyIFuHMhofsIWeaietxOCxhLU3brnDaIMZhdkIGYOAkwiOA3PL0cmYuSUZpPa0dC5Y10ZJy7Q2bzp77nEFjNhknvLpOubZLOSFN40gEHq/4YEm9d/Q8z2/DZ6XqphQwO/u6dgBmSGB3dE+oP4W5R8FUwfuJt9HuLXlthHHMKxSSQvnCQWgNzXsAX8MzA6Yp5uDEO+zWxR13G68SAHVB3s5AcSKfCyPrqeznQgmy+36F6qtlrYNvLX2arC8Pyf70wA5spSluJjsmHNguCcDvyoCQ4BCyqtRuOWm1hYT4lrho= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(396003)(451199015)(36840700001)(40470700004)(46966006)(81166007)(36860700001)(110136005)(8936002)(316002)(82740400003)(4326008)(86362001)(83380400001)(4744005)(2906002)(356005)(70586007)(5660300002)(54906003)(40480700001)(26005)(40460700003)(9686003)(82310400005)(6506007)(55016003)(7696005)(107886003)(41300700001)(52536014)(47076005)(336012)(70206006)(8676002)(478600001)(186003)(33656002)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 08:50:19.4348 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f236fa26-25e2-438f-e260-08dacd2fc00a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8477 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMgMS8zXSBD SEFOR0VMT0c6IEFkZCBtaXNzaW5nIGVudHJpZXMgZm9yIHdvcmsgZHVyaW5nDQo+IHRoZSA0LjE3 IHJlbGVhc2UNCj4gPj4gSSB3YXMgdW5kZXIgdGhlIGltcHJlc3Npb24gdGhhdCB0aGUgY29kZSB0 aGF0IHdhcyBtZXJnZWQgaXMgZW5vdWdoIHRvDQo+ID4+IHN1cHBvcnQgdGhlIHBsYXRmb3JtLiBE byB5b3UgaGF2ZSBhbnkgcG9pbnRlciB3aGVyZSBpdCBzYXlzIGl0IGlzIG5vdA0KPiA+PiBzdWZm aWNpZW50Pw0KPiA+DQo+ID4gQWggdGhpcyBpcyBhbHNvIGRpcmVjdGx5IGZyb20gdGhlIHRpdGxl IG9mIFsyXSwgd2hlcmUgaXQgaXMgb25seSBhDQo+ID4gInhlbi9hcm06IGFkZCBpLk1YIGxwdWFy dCBhbmQgaS5NWDhRTSBpbml0aWFsIHN1cHBvcnQiDQo+ID4NCj4gPiBJIHdvdWxkIGJlIG1vcmUg dGhhbiBoYXBweSB0byByZW1vdmUgdGhlICJpbml0aWFsIiBpZiB5b3UgdGhpbmsgaXQgaXMNCj4g PiBhcHByb3ByaWF0ZS4NCj4gDQo+IEkgc2F3IHlvdSBhbHJlYWR5IHJlbW92ZSAiaW5pdGlhbCIg aW4gdjQgYnV0IEkgd2lsbCBzdGlsbCByZXBseS4gT24gYW4NCj4gZWFybGllciByZXZpc2lvbiBv ZiB0aGUgc2VyaWVzIEkgYXNrZWQgUGVuZyBpZiB0aGlzIHdhcyBlbm91Z2ggdG8gYm9vdA0KPiBY ZW4gdXBzdHJlYW0gb24gdGhlIHBsYXRmb3JtIGFuZCB0aGUgYW5zd2VyIHdhcyB5ZXMgWzNdLg0K DQpHcmVhdCwgdGhlbiByZW1vdmluZyB0aGUgImluaXRpYWwiIGRlZmluaXRlbHkgbWFrZXMgZ29v ZCBzZW5zZS4gVGhhbmtzDQpmb3IgY29uZmlybWluZyB0aGlzLg0KDQpLaW5kIHJlZ2FyZHMsDQpI ZW5yeQ0K From xen-devel-bounces@lists.xenproject.org Wed Nov 23 08:57:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 08:57:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447446.703664 (Exim 4.92) (envelope-from ) id 1oxlYv-0002pe-M7; Wed, 23 Nov 2022 08:56:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447446.703664; Wed, 23 Nov 2022 08:56:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlYv-0002pX-Io; Wed, 23 Nov 2022 08:56:57 +0000 Received: by outflank-mailman (input) for mailman id 447446; Wed, 23 Nov 2022 08:56:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlYu-0002pN-VA; Wed, 23 Nov 2022 08:56:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlYu-0007rR-QK; Wed, 23 Nov 2022 08:56:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlYu-0003Wt-CE; Wed, 23 Nov 2022 08:56:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxlYu-0003T5-Bm; Wed, 23 Nov 2022 08:56:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0OxAjdOspRUhS3ym71MuXh9TJvz9bX5t8bHkRoLilVU=; b=ADw+E5psmCicZQVhHOySk4Ufao 37Op/WtIrjdHINSppea1r8UY4v+pu+2CIsvGtcbO505rxtwJQLZWbD0HELnU8CPagIPgJFgIMieRU PSQwsv2TMsPrWNHtISKsd49AdB0jaPeBCFCCS60JqVwvdn7skGfeMOniKFxchcTjMEMY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174930: FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-pvshim::broken:regression xen-unstable:test-amd64-amd64-libvirt-vhd::broken:regression xen-unstable:test-amd64-amd64-xl-credit2::broken:regression xen-unstable:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:host-install(5):broken:heisenbug xen-unstable:test-amd64-i386-xl-pvshim:host-install(5):broken:heisenbug xen-unstable:test-amd64-amd64-xl-xsm:debian-install:fail:heisenbug xen-unstable:test-amd64-coresched-i386-xl:guest-start.2:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=345135942bf9632eba1409ba432cfcae3b7649c7 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Wed, 23 Nov 2022 08:56:56 +0000 flight 174930 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174930/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-pvshim broken in 174920 test-amd64-amd64-libvirt-vhd broken in 174920 test-amd64-amd64-xl-credit2 broken in 174920 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-credit2 5 host-install(5) broken in 174920 pass in 174930 test-amd64-amd64-libvirt-vhd 5 host-install(5) broken in 174920 pass in 174930 test-amd64-i386-xl-pvshim 5 host-install(5) broken in 174920 pass in 174930 test-amd64-amd64-xl-xsm 12 debian-install fail in 174920 pass in 174930 test-amd64-coresched-i386-xl 23 guest-start.2 fail pass in 174920 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail pass in 174920 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 345135942bf9632eba1409ba432cfcae3b7649c7 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 6 days Failing since 174809 2022-11-18 00:06:55 Z 5 days 14 attempts Testing same since 174896 2022-11-21 20:43:42 Z 1 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Daniel P. Smith Jan Beulich Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-i386-xl-pvshim broken broken-job test-amd64-amd64-libvirt-vhd broken broken-job test-amd64-amd64-xl-credit2 broken Not pushing. ------------------------------------------------------------ commit 345135942bf9632eba1409ba432cfcae3b7649c7 Author: Andrew Cooper Date: Mon Nov 21 12:46:39 2022 +0000 xen/flask: Wire up XEN_DOMCTL_{get,set}_paging_mempool_size These were overlooked in the original patch, and noticed by OSSTest which does run some Flask tests. Fixes: 22b20bd98c02 ("xen: Introduce non-broken hypercalls for the paging mempool size") Suggested-by: Daniel Smith Signed-off-by: Andrew Cooper Reviewed-by: Jason Andryuk Acked-by: Daniel P. Smith Release-acked-by: Henry Wang commit 8746d3e2550b142cd751ca7a041a38789a020d2b Author: Andrew Cooper Date: Fri Nov 18 16:53:45 2022 +0000 tools/libxl: Fixes to libxl__domain_set_paging_mempool_size() The error message accidentally printed the bytes value as if it were kB. Furthermore, both b_info.shadow_memkb and shadow_mem are uint64_t, meaning there is a risk of overflow if the user specified a stupidly large value in the vm.cfg file. Check and reject such a condition. Fixes: 7c3bbd940dd8 ("xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls") Signed-off-by: Andrew Cooper Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit 8cdfbf95b19c01fbb741c41d5ea5a94f8823964c Author: Anthony PERARD Date: Mon Nov 21 12:23:01 2022 +0100 libs/light: Propagate libxl__arch_domain_create() return code Commit 34990446ca91 started to overwrite the `rc` value from libxl__arch_domain_create(), thus error aren't propagated anymore. Check `rc` value before doing the next thing. Fixes: 34990446ca91 ("libxl: don't ignore the return value from xc_cpuid_apply_policy") Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD Reviewed-by: Jason Andryuk Release-acked-by: Henry Wang commit 57f07cca82521088cca0c1fc36d6ffd06cb7de80 Author: Roger Pau Monné Date: Mon Nov 21 12:21:51 2022 +0100 efifb: ignore frame buffer with invalid configuration On one of my boxes when the HDMI cable is not plugged in the FrameBufferBase of the EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE structure is set to 0 by the firmware (while some of the other fields looking plausible). Such (bogus address) ends up mapped in vesa_init(), and since it overlaps with a RAM region the whole system goes down pretty badly, see: (XEN) vesafb: framebuffer at 0x0000000000000000, mapped to 0xffff82c000201000, using 35209k, total 35209k (XEN) vesafb: mode is 0x37557x32, linelength=960, font 8x16 (XEN) vesafb: Truecolor: size=8:8:8:8, shift=24:0:8:16 (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) (XEN) �ERROR: Class:0; Subclass:0; Operation: 0 ERROR: No ConOut ERROR: No ConIn Do like Linux and prevent using the EFI Frame Buffer if the base address is 0. This is inline with the logic in Linuxes fb_base_is_valid() function at drivers/video/fbdev/efifb.c v6.0.9. See also Linux commit 133bb070e94ab41d750c6f2160c8843e46f11b78 for further reference. Also prevent using Frame Buffers that have a 0 height or width, as those are also invalid. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Release-acked-by: Henry Wang commit db8fa01c61db0317a9ee947925226234c65d48e8 Author: Andrew Cooper Date: Thu Oct 20 12:14:30 2022 +0100 xen/arm: Correct the p2m pool size calculations Allocating or freeing p2m pages doesn't alter the size of the mempool; only the split between free and used pages. Right now, the hypercalls operate on the free subset of the pool, meaning that XEN_DOMCTL_get_paging_mempool_size varies with time as the guest shuffles its physmap, and XEN_DOMCTL_set_paging_mempool_size ignores the used subset of the pool and lets the guest grow unbounded. This fixes test-pagign-mempool on ARM so that the behaviour matches x86. This is part of XSA-409 / CVE-2022-33747. Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool") Signed-off-by: Andrew Cooper Reviewed-by: Julien Grall Release-acked-by: Henry Wang commit 7c3bbd940dd8aeb1649734e5055798cc6f3fea4e Author: Andrew Cooper Date: Tue Oct 25 15:27:05 2022 +0100 xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7. First of all, with ARM borrowing x86's implementation, the logic to set the pool size should have been common, not duplicated. Introduce libxl__domain_set_paging_mempool_size() as a shared implementation, and use it from the ARM and x86 paths. It is left as an exercise to the reader to judge how libxl/xl can reasonably function without the ability to query the pool size... Remove ARM's p2m_domctl() infrastructure now the functioanlity has been replaced with a working and unit tested interface. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD Release-acked-by: Henry Wang commit bd87315a603bf25e869e6293f7db7b1024d67999 Author: Andrew Cooper Date: Thu Oct 20 12:13:46 2022 +0100 tools/tests: Unit test for paging mempool size Exercise some basic functionality of the new xc_{get,set}_paging_mempool_size() hypercalls. This passes on x86, but fails currently on ARM. ARM will be fixed up in future patches. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit 22b20bd98c025e06525410e3ab3494d5e63489f7 Author: Andrew Cooper Date: Fri Oct 21 14:13:00 2022 +0100 xen: Introduce non-broken hypercalls for the paging mempool size The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: * All set_allocation() flavours have an overflow-before-widen bug when calculating "sc->mb << (20 - PAGE_SHIFT)". * All flavours have a granularity of 1M. This was tolerable when the size of the pool could only be set at the same granularity, but is broken now that ARM has a 16-page stopgap allocation in use. * All get_allocation() flavours round up, and in particular turn 0 into 1, meaning the get op returns junk before a successful set op. * The x86 flavours reject the hypercalls before the VM has vCPUs allocated, despite the pool size being a domain property. * Even the hypercall names are long-obsolete. Implement a better interface, which can be first used to unit test the behaviour, and subsequently correct a broken implementation. The old interface will be retired in due course. The unit of bytes (as opposed pages) is a deliberate API/ABI improvement to more easily support multiple page granularities. This is part of XSA-409 / CVE-2022-33747. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Jan Beulich Acked-by: Anthony PERARD Release-acked-by: Henry Wang commit e5ac68a0110cb43a3a0bc17d545ae7a0bd746ef9 Author: Andrew Cooper Date: Mon Nov 14 21:47:59 2022 +0000 x86/hvm: Revert per-domain APIC acceleration support I was really hoping to avoid this, but its now too late in the 4.17 freeze and we still don't have working fixes. The in-Xen calculations for assistance capabilities are buggy. For the avoidance of doubt, the original intention was to be able to control every aspect of a APIC acceleration so we could comprehensively test Xen's support, as it has proved to be buggy time and time again. Even after a protracted discussion on what the new API ought to mean, attempts to apply it to the existing logic have been unsuccessful, proving that the API/ABI is too complicated for most people to reason about. This reverts most of: 2ce11ce249a3981bac50914c6a90f681ad7a4222 6b2b9b3405092c3ad38d7342988a584b8efa674c leaving in place the non-APIC specific changes (minimal as they are). This takes us back to the behaviour of Xen 4.16 where APIC acceleration is configured on a per system basis. This work will be revisted in due course. Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC") Fixes: 6b2b9b340509 ("x86: report Interrupt Controller Virtualization capabilities") Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Release-acked-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Nov 23 08:58:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 08:58:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447452.703675 (Exim 4.92) (envelope-from ) id 1oxlZw-0003Q0-4O; Wed, 23 Nov 2022 08:58:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447452.703675; Wed, 23 Nov 2022 08:58:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlZw-0003Pt-1l; Wed, 23 Nov 2022 08:58:00 +0000 Received: by outflank-mailman (input) for mailman id 447452; Wed, 23 Nov 2022 08:57:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlZu-0003Oz-1q for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 08:57:59 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ebd40c24-6b0c-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 09:57:57 +0100 (CET) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxlXZ-003jLI-6a; Wed, 23 Nov 2022 08:57:33 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 3564F30013F; Wed, 23 Nov 2022 09:55:30 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A0AFF2D819C4D; Wed, 23 Nov 2022 09:55:30 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebd40c24-6b0c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WEbEoRwkNU50xfDUGpl4daXU2L4OBNgPFu286C7zJm8=; b=Zw8zAIaFHr+ssmLxghLb2Zn751 8Cpacemx3ZAqyuSFe66NhvA0Lg6Ebw3hBz+9NLIdzJ0MfkaN3NrfOf3HFEbALlUF8hzhZZTAjK7Wc GUUNogOt3XHOl46ZpgWCQQ2pUJRlYrKlvZrsnheOKJVs74c5f6yGHbw6cJCw8FNnWX/uG4dbRw0DZ EMHMlSy6QCb0uskkyg6GtMCJoGpyGszdtq3IB5BUCarFcnz/16Aq4yIA28TYWLy/ieTNTvmhMhW+c MNPW56zsypplyYprshJTA3A6b4irPVYCGnQbvgngTm0qbsf6yXnbAzQQv/GuZjfTIKCSEXG82Lf/U se5OavBA==; Date: Wed, 23 Nov 2022 09:55:30 +0100 From: Peter Zijlstra To: Josh Poimboeuf Cc: "Paul E. McKenney" , sfr@canb.auug.org.au, linux-kernel@vger.kernel.org, jgross@suse.com, sstabellini@kernel.org, boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org, Andrew Cooper Subject: Re: objtool warning for next-20221118 Message-ID: References: <20221121040736.GA3738360@paulmck-ThinkPad-P17-Gen-1> <20221121145215.GF4001@paulmck-ThinkPad-P17-Gen-1> <20221122051605.4hcbslwxez2trdvt@treble> <20221123012350.kelmmadh65lyswqz@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221123012350.kelmmadh65lyswqz@treble> On Tue, Nov 22, 2022 at 05:23:50PM -0800, Josh Poimboeuf wrote: > On Tue, Nov 22, 2022 at 09:35:17AM +0100, Peter Zijlstra wrote: > > On Mon, Nov 21, 2022 at 09:16:05PM -0800, Josh Poimboeuf wrote: > > > > > It's complaining about an unreachable instruction after a call to > > > arch_cpu_idle_dead(). In this case objtool detects the fact > > > arch_cpu_idle_dead() doesn't return due to its call to the > > > non-CONFIG_SMP version of play_dead(). But GCC has no way of detecting > > > that because the caller is in another translation unit. > > > > > > As far as I can tell, that function should never return. Though it > > > seems to have some dubious semantics (see xen_pv_play_dead() for > > > example, which *does* seem to return?). I'm thinking it would be an > > > improvement to enforce that noreturn behavior across all arches and > > > platforms, sprinkling __noreturn and BUG() on arch_cpu_idle_dead() and > > > maybe some of it callees, where needed. > > > > > > Peter, what do you think? I could attempt a patch. > > > > I'm thinking the Xen case makes all this really rather difficult :/ > > > > While normally a CPU is brought up through a trampoline, Xen seems to > > have implemented it by simply returning from play_dead(), and afaict > > that is actually a valid way to go about doing it. > > o_O > > How the @#$% is that a valid way of doing it? Why not just do it the > normal way? Well, if you return from arch_cpu_idle_dead() you're back in the idle loop -- exactly where you would be if you were to bootstrap the whole CPU -- provided you have it remember the whole state (easier with a vCPU). But maybe I'm missing something, lets add Xen folks on. From xen-devel-bounces@lists.xenproject.org Wed Nov 23 09:18:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 09:18:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447459.703685 (Exim 4.92) (envelope-from ) id 1oxlti-00066b-QU; Wed, 23 Nov 2022 09:18:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447459.703685; Wed, 23 Nov 2022 09:18:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlti-00066U-Np; Wed, 23 Nov 2022 09:18:26 +0000 Received: by outflank-mailman (input) for mailman id 447459; Wed, 23 Nov 2022 09:18:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxlth-00066O-8I for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 09:18:25 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20601.outbound.protection.outlook.com [2a01:111:f400:7eaf::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c786532b-6b0f-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 10:18:23 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8993.eurprd04.prod.outlook.com (2603:10a6:20b:42c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.11; Wed, 23 Nov 2022 09:18:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 09:18:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c786532b-6b0f-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d8Eglrj+hhVW1vqs8SvlxDrV7FlzzrsGCiQD97ULpRFTlExnLKB6ayElCH1nyyPg6HyohNRCGvELgatUKQZTjaepYTjoM1FJwSM8FpzSbjftZNAHglHstMqlEm1yEirfvjGHg28GLmIG3SD67RT/Bf351gbSUW1tLTJ9QT6Pt4uIYC7lCEpfZ8kbUxMoomVeb8RfcWS7MqZXAoH8+TZx4N+XtLOfI4upGbqBRK2JsrRzWBnFgoFS3C5EIHWZF/GCz8VQPmbXAIKEdslNtDYgjEUs8LP9yBBnyQQDpsbEmK2jxP1wG2+ePHnqVPO+gqRn+w/0Bvtlu2/ew8MAqHAPFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OJGCgj/XYyZeBK7y0xZEQz/TMcDfe99jO4xKpvvGKUI=; b=cTpWS4jU6EwImNESDwziA0KZ+b2lFDPlmIycY3Jn+TOB6YoU7z/lSF0/SivDrdob5+leCDQO0jNVQKTlb3ZkPFRElljr23DfjGMAoQIw8i/uHbv649IWcTpq11/jgBqye5VIFZmVX/gBn7ZCPAOIocIlkWuX0BwYGIHRSYXw/LrrsTcXOYQluKOG3pvkMWCxbkWDcSMi9xhOpEmgHfAGajd03spmbPysmfcJRFeJdd6SuZO+mUsVgAW+mLXXD9wQ4ln3xiviV43jLydyhVflMz3c9SYYQvO8AJ27G6GdzgGjxyiqu4vtG4H5pJ/NpSL68bvDmbBLJ7Kuu8PsLaJsvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OJGCgj/XYyZeBK7y0xZEQz/TMcDfe99jO4xKpvvGKUI=; b=MI8oOKL7Ki6RhwvawucZo/H1Pk+7GUSBzGfX2byK/yr6InZPaIO7kmbtMCF5SDVfCdawIiJo+PzBDhmq3zHe5LhJ7AmoL75xt3LJdji7hyEZQ3r9elxdwsWQsn4bBKq7UGQzk6zIAB1XSC/JGOZeJbohR96oaDT5+8W3dgtIh7wm5vMK19ttHqYzbOlC+nZffr92+KSz1N/OB/7N3zA8Tr3YrIKJfxxV5OvYen6T7Za9QLx6WW9ev5N2sqq5HBGX9UAapWffVpEFnREbyzA1e7G8V2raMHOoV7roi7qnWz7NuXkkgGZ97Wz8IM/jER44w4K2AEtfGYsEtK3t1Z7Kqg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7491ca33-291f-1dfe-6826-2a210a1d08ae@suse.com> Date: Wed, 23 Nov 2022 10:18:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: EFI's -mapbs option may cause Linux to panic() Content-Language: en-US To: Juergen Gross Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <60663f81-09cd-e46b-bb94-1afe50519086@suse.com> <296f95d8-5506-c95d-1c14-915cbf3e4f30@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0104.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8993:EE_ X-MS-Office365-Filtering-Correlation-Id: a40f33e6-b94e-47d8-4207-08dacd33aaa3 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3wUSsg4RINZsnpCxFLnEj2Q7++TlYXvCOz82yt6ZZGN9G9Cc2+dipeM9O+8wbZifKLylLvld/kmJguUgC8x3P7KgI7lIp/1YT0pDghiRDqbV/a0PLjZXej+YxUR6gAsGe9Nq45U9+TxdExI6fXMBo7oNQo2YCubcvHzBb7/keDo5+AmF3Osysrb97PeZqJuhozP9hIAQ9J49Y2uyCg+ltZqlQqB8taG2IhrPMr6tHenO4n5eNBHE5u6S2u63G2TO0dPJj0B6ckafdIs/kfJXAim8K27Ef8a/tpwVwNqocgcNXUcwH44OMxY78KUr3st3baDLx85NblSO9zeunSW3tCrG4wH0fHjUdHd8p3j3b24S2w/aXo/1mCGmByy12MBKQ75qbovy7MvgRcgp75MsRRMBhj40ICyJXlBM1QCt1IptiTTN+2KDSLy5yMDxpRKqd1qXJY/Qm3YfAiCLuU8GUQ21kWV4L29XFpTJI6FSMEENvUtLSAbVMLM4/PQRabUXx4wQ2rR6hh+UvqfutQ066prqgCK/yGb6vTQTkEpDh2U0zwot4swPwIYBstvtV4//85KqGb2dJyD6R3IJNqY27DjAAh46uS/wIEszLCQDa1MmWiTWcksRELFKkPxGa1lL6+YHDTivMQIKuPEEIRUxb0a4mzLSfGDJi9YJB0l0iBSKYcWVpWP+dcZzS7gxOcm05VOH/ZV6H85QlW6KdNJoy1GxtMK0mWHwCV74ZgkbbwU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(136003)(366004)(376002)(396003)(451199015)(8936002)(186003)(53546011)(5660300002)(36756003)(41300700001)(6506007)(478600001)(66556008)(6486002)(6862004)(26005)(2906002)(6512007)(38100700002)(2616005)(31696002)(86362001)(83380400001)(66476007)(66946007)(37006003)(316002)(31686004)(54906003)(6636002)(8676002)(66899015)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFMwNVB1K1NUZzhFWVhVZGt0MnVJQ0ZVck0vUmRZV3J6YjFvYnZzU2ZtTjJX?= =?utf-8?B?S2dZU2huNWFHdlgvQ080MlVDLzEyYUsyY2tHdDdjYThianh1OEpnejBwS0cv?= =?utf-8?B?Mm9hK3c3VzlwN3NXcTI4UFY0dEZZSUlDOWxxM1hLem05dWsxaVFESGVoamxS?= =?utf-8?B?VGZGU0FURDgwN3VJZ3lMSWdJZWtTME5uQldOaHNVdCtZNXJIOTl5cnhaL3Y4?= =?utf-8?B?bkxLNmg2QlZkbmFmZHFrSGdhRnFSVHFwMlp5anBxZG82MFhmQ3R5L29MZkhm?= =?utf-8?B?aGFEaVp5OVRGK2dFTmhKcUJ3VmgvMXl6bWtBUHFuVWw4R2JzZUZaV0xsUmll?= =?utf-8?B?eEs5ZVZSeTdMQXdzZko2eVZ5bGI2OGtzR0daczExN0pKdUhFTnhLUGMwRFJK?= =?utf-8?B?Ty84Rld4eUxCS0MzSmNmYUVtbjh0VEorT0toY0VjQVc2M0diOXZPVlRkamJJ?= =?utf-8?B?UWcxWURjYXFlQXdGcnRpcnhGdXVYa2x3S1BiVHh6ME9vSkF4MXZnMjUrUGlB?= =?utf-8?B?S1BjSU44dzlrb20vbnI4U2lweXJHYnZqQVU5a1k0bHRKQlR3TzdHSTJpMkxJ?= =?utf-8?B?SUUzR0hwME9kMTd0OTMzQVhOcklSOU5GZXlyNFU5ZDFpNFJPSDVGUFNNa1da?= =?utf-8?B?bVk0L0FmWFUzMkdtVlhkbUtHc1pKYnJRNG5VK3Vya1p0ak9qOElqWUo2NnY1?= =?utf-8?B?WHlOY0NYZWRjMUhMR2IvOG1GT3daMEQzZkFCR1Jkak1HNDFycndNM3lLM1ZN?= =?utf-8?B?SWFoZlBFek1GdS9VZ09RZnp2Wm1tQ0luaHNmZE9sNjlScXREcENON0tKaVNG?= =?utf-8?B?d2djejFOWlZwTmlXdkczVlVNbCtwV2w1YXQvZlJRU0tPOHNXZzRYMjZPV1RL?= =?utf-8?B?ZzMzRXU0RFJ0b1NIOVkrQnFOSlpJaW13SGVaZ0poSEx1NE5hWnV4bWxINEVG?= =?utf-8?B?dVo3bXZrVThORkVXc29vOXNEMGd0TnI1UkNEYTNHMUtzUFlyV2k1TXhqK3U4?= =?utf-8?B?MUFMUTM5MXBUa3l3V1ZsRWZFWEFEdDd3cS9TUmNRWndKQTN2aHdzTEZHRy85?= =?utf-8?B?a3pBK1YwbjdXc05ZSDllU1BwRisrZFhZL0ZUeVpyNDJvTnlpMk83R3EyS2lC?= =?utf-8?B?aWNQclZXcUZHNk92VzVJWWlQak9RSEVGc0Z1LzFMc00zTXFrT3R2UFAwSHZN?= =?utf-8?B?Ym1LYlpyclltMjdJdFVibHJBUXVoa1BnRDUzVmdHazFBQ1VpQytiVnFOdFZV?= =?utf-8?B?RG5iTWIyTlJuZk5RY1RHdnUxWlc0NisyT2Q4Wnk0alBacUlCbGV1Q1ZFb1pT?= =?utf-8?B?NGlEQm1qVW4vMlY4RXI0K2orV2k5R2VVamV5M0VWNFV2VEsxaFJLblFIVnE5?= =?utf-8?B?SGdEdS9wbVlWSjNNL2hpU0JLYlozbysyck15QUdvdURuK1dxMWVZeHVQSWxw?= =?utf-8?B?eTJZQ0Z3RzVCdk1RMnk4ckU2UkNKUjZFeU1UcHNoYzZRd0tLZC9ncnVXZFlG?= =?utf-8?B?MGJUeGhTUWhHa3k1WUdsZkxodlp1dVI0L2JpTThyS1RqcFNrRngrVGJvQmx1?= =?utf-8?B?ZGw1WFBBNzBkOTRJWW5WQTZJNlk2d054clprV3d2TDUvamp0T2lYN00rS1Fa?= =?utf-8?B?ZC82VVlLN2ZnQVJlYjZ6a0RHOTI1ZjNOTTN5eUdhQmVvWTFYdGU1OGdWbm8v?= =?utf-8?B?QUtDbHZSNmNLUGYvcmZWY0s5TmhTWFUvWGtLY3lqTFJCeTR1clF1ZCtGYUdZ?= =?utf-8?B?aWJiTUhqVnB1c0hGY0FwUzdZaTIwZ1VjYVo0eUpML0t4Qkx3dnFjanVFYWFK?= =?utf-8?B?YzJhc1pITS9PZXBjNTZXazQwNE9TYVRhV1VEVXY3bzlWNzhCT3puczhpb29h?= =?utf-8?B?ZGNjZ21IdmVaL2dkdTNjamJZVkRVYVR2ZlgxUkhQMGhCTHIwK3NhY3VGSmc0?= =?utf-8?B?aXVUL3FsWXNpKzZsaTl0YnVPdUVocXlmb1IxNkhscms4amgzaU5KRFJCbjVo?= =?utf-8?B?cEJmY3QvWXJtYUZtZVlXK1pJMm9DZHBJVzhhRGFKblMvWGhmUWJMb0J3YVpL?= =?utf-8?B?cHltd2tlT0Jzc1l6VmlvdTR1eFVwbUNZNXV5aWpZWEF2aG9idXJsblo4bGxD?= =?utf-8?Q?DKL5GPhGdyPJTd+FUWkYIieKW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a40f33e6-b94e-47d8-4207-08dacd33aaa3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 09:18:21.7448 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zUdV/sBb/a3Q75qX6nnNcIRDIVIOgt5BbylAgLSnfZYrtbfg5e66UXvrOUDkVq1ugpXTsJY0yObkDdTxd92ivQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8993 On 23.11.2022 08:39, Juergen Gross wrote: > On 22.11.22 10:47, Roger Pau Monné wrote: >> On Mon, Nov 21, 2022 at 06:01:00PM +0100, Jan Beulich wrote: >>> On 21.11.2022 17:48, Roger Pau Monné wrote: >>>> On Mon, Nov 21, 2022 at 05:27:16PM +0100, Jan Beulich wrote: >>>>> Hello, >>>>> >>>>> on a system with these first two EFI memory map entries >>>>> >>>>> (XEN) 0000000000000-000000009dfff type=4 attr=000000000000000f >>>>> (XEN) 000000009e000-000000009ffff type=2 attr=000000000000000f >>>>> >>>>> i.e. except for 2 pages all space below 1M being BootServicesData, the >>>>> -mapbs option has the effect of marking reserved all that space. Then >>>>> Linux fails trying to allocate its lowmem trampoline (which really it >>>>> shouldn't need when running in PV mode), ultimately leading to >>>>> >>>>> panic("Real mode trampoline was not allocated"); >>>>> >>>>> in their init_real_mode(). >>>>> >>>>> While for PV I think it is clear that the easiest is to avoid >>>>> trampoline setup in the first place, iirc PVH Dom0 also tries to >>>>> mirror the host memory map to its own address space. Does PVH Linux >>>>> require a lowmem trampoline? >>>> >>>> Yes, it does AFAIK. I guess those two pages won't be enough for >>>> Linux boot trampoline requirements then. >>>> >>>> I assume native Linux is fine with this memory map because it reclaims >>>> the EfiBootServicesData region and that's enough. >>> >>> That's my understanding as well. >>> >>>>> While the two pages here are just enough for Xen's trampoline, I still >>>>> wonder whether we want to adjust -mapbs behavior. Since whatever we >>>>> might do leaves a risk of conflicting with true firmware (mis)use of >>>>> that space, the best I can think of right now would be another option >>>>> altering behavior (or providing altered behavior). Yet such an option >>>>> would likely need to be more fine-grained then than covering all of >>>>> the low Mb in one go. Which feels like both going too far and making >>>>> it awkward for people to figure out what value(s) to use ... >>>>> >>>>> Thoughts anyone? >>>> >>>> I'm unsure what to recommend. The mapbs option is a workaround for >>>> broken firmware, and it's not enabled by default, so we might be lucky >>>> and never find a system with a memory map like you describe that also >>>> requires mapbs in order to boot. >>> >>> Guess how we've learned of the issue: Systems may boot fine without >>> -mapbs, but they may fail to reboot because of that (in)famous issue of >>> firmware writers not properly separating boot services code paths from >>> runtime services ones. And there we're dealing with a system where I >>> suspect this to be the case, just that - unlike in earlier similar >>> cases - there's no "clean" crash proving the issue (the system simply >>> hangs). Hence my request that they use -mapbs to try to figure out. >>> >>> And yes, "reboot=acpi" helps there, but they insist on knowing what >>> component is to blame. >> >> Well, if reboot=acpi fixes it then it's quite clear EFI reboot method >> is to blame? >> >> Or they want to know the exact cause that makes EFI reboot fail, >> because that's quite difficult to figure out from our end. >> >> But I'm afraid I don't see any solution to make mapbs work with a PVH >> dom0 on a system with a memory map like you provided, short of adding >> some kind of bodge to not map and mark as reserved memory below 1MB >> (but that kind of defeats the purpose of mapbs). > > What we could do in such a case would be to inhibit suspending the > system, and to run dom0 with a single cpu only. An error message > indicating that the system should be booted without mapbs should be > issued, of course. That's going to be awkward: Linux can't very well issue a message suggesting to remove the use of a hypervisor option (behavior of which is an implementation detail to some degree, and hence the message could end up being misleading later). Xen also can't very well issue such a message, since it doesn't know how much of lowmem is going to be enough for whichever Dom0 OS there's going to be booted. In principle an OS may get away with less than a single page. Hence Xen at best could issue a "may not work" message (unless no space at all was available at some 4k-aligned boundary), and even then it being a false indication on some (many?) systems may lead to people not paying attention when they should. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 23 09:35:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 09:35:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447464.703697 (Exim 4.92) (envelope-from ) id 1oxmAU-0000Hj-Ai; Wed, 23 Nov 2022 09:35:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447464.703697; Wed, 23 Nov 2022 09:35:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmAU-0000Hc-7U; Wed, 23 Nov 2022 09:35:46 +0000 Received: by outflank-mailman (input) for mailman id 447464; Wed, 23 Nov 2022 09:35:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmAS-0000HU-Hd for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 09:35:44 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20604.outbound.protection.outlook.com [2a01:111:f400:7eab::604]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3279f236-6b12-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 10:35:43 +0100 (CET) Received: from DS7PR03CA0077.namprd03.prod.outlook.com (2603:10b6:5:3bb::22) by DM6PR12MB4466.namprd12.prod.outlook.com (2603:10b6:5:2ae::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 09:35:39 +0000 Received: from DM6NAM11FT041.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3bb:cafe::70) by DS7PR03CA0077.outlook.office365.com (2603:10b6:5:3bb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17 via Frontend Transport; Wed, 23 Nov 2022 09:35:39 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT041.mail.protection.outlook.com (10.13.172.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Wed, 23 Nov 2022 09:35:39 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 23 Nov 2022 03:35:39 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 23 Nov 2022 03:35:38 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 23 Nov 2022 03:35:37 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3279f236-6b12-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X1b5/s4i/Zv9yiO1K3WypKf0Is4wPTxAGJ8dp0sXIoq58YukV5iYpkfwItOPm1VQ6H58BmLToZkd1xpXhWGJMiEaLUHNOQXoaSbVE+FMBAyZfW3c1cYihLZEfSZAfdrUlJLoC9c9CtVHeGspQjrRelKO45eMkEo1DtLtiygC8zhg0kKJOmPxd6NnQq/Zr2A2SAvBRQ4AzMSicmhLu8TMFl8MibxiA8wLr7rxgh6B4q7VyCAokY4qGYaFoG2DGD2yfxQJWY1dE8Qza+XxC09mTCz33DYXRLBktLlSUnWu4KkDdpjy6z8UlJzGAMQ3rA1JNl4fDmeH0HOSF2yJSzhUuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w1Z0ulfy2zznqdIdy3z7j/WsoVF/LjxWP35bDf2X2ck=; b=b0uoCs1ofsNbW46y9lOzjsT5ZCkoxkdM95ALkLfPViYrHtd34ulf2Xw2UMZR2OY1nvwdS699xw+tpLT/oRYEe4dDBwrdzcBaTUAuSo3LOl8Qoxm76EgQe5xkTnFZtv6/g9eGiJluIP90xVAwnan623F79VSU0iQpRIFlV4VGK1TIGR7Jw5AlOUUgWOgbogykUHb1Ly7naYSAYqhUGy5HFrSoGm0MgXxoqoSZ+CqjvVa07WFK5GK3Wwwwn3L6I30nItgxs+fSWm42/551dSsfj7RWfEvn1bQDJ9UGccqiTZNqtMfrG382l+ZRm3u2VL7teOi6pUDXlyfFUznO1uDE3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w1Z0ulfy2zznqdIdy3z7j/WsoVF/LjxWP35bDf2X2ck=; b=IrEp6UoSmYCOheoIknACKudHjo4OR3/5lEAduHPTkfp6Ija/gfsYVC3I4bblu9kyImCX/zX2JmNhbQti/I2SXDnIP2TwPfoiQtcGQgl1qympupeplMH9KWr1E2WdZKCslDyWGFY2RtY/UQcqBa8Qld8T/x0gqcrNiTpLNV5pyko= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Wed, 23 Nov 2022 10:35:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN v3 02/12] xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32 To: Julien Grall , Ayan Kumar Halder , CC: , , , , , References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-3-ayan.kumar.halder@amd.com> <8086e3ac-445b-17a1-bba3-078024ab2579@amd.com> <4045f91a-620a-98b0-d3c7-28af1b0ba4a8@xen.org> Content-Language: en-US From: Michal Orzel In-Reply-To: <4045f91a-620a-98b0-d3c7-28af1b0ba4a8@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT041:EE_|DM6PR12MB4466:EE_ X-MS-Office365-Filtering-Correlation-Id: 702ba933-e328-4a46-770d-08dacd361558 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qL5fSlKsyVmSSt/799tm4jG0ShBX6hVRqqPjFObs5bVCCL7uZ3GplSTaRd/essSRFNTPUrHkZhlUYlXGVgAII1fYr6IgqPPOHmN+iGKbw8lhyes27J5Qn6lH5rAIot/w6Ehm/jONCBk2KRbkNkYZEt7iJIftFm5riXeG/2OVF2Efn3BDodj8JSvT9/nYezH/O+XO7Qgs+v+6p92xeOHB65FpG5cePZGb/NsrqE3shRC3acsuQGny+PTF9N0zLH9KSWlJOGDUfbz6FE5Lf//ll7wRub7x5JZNBa/Rnn2NNoV9KFCzAAmEgwGRL04B9v/eqNBZMkCrjzvx0y9MT3qs1K1tUcaSrjqoZhew79dAaE4i5Jm2eMPSsSwtmAUh4mldZxNKOH3jARYq/kmiTUKr1fe0oBRPZ87AwUSPviLxKFYPUKcFItEWkPlbROFq+3mSVhb38x0FzS/GL5PeyqBfyGnC5fvP4oh2phv2/IrFvpzDHUqngX9C5o+vXG9ZQYzSJasBxaxlXF4Ur8OsGFlY3g9V8ejGXyOjTFrUwJ9sfCJhLjYePCVe6qgeRnDU1FeMEzWtFj3sD4eGRrOWmzZ4W6OykYXoGdPk7zGwua9b+sDrkDcRIWfcCjN/ph8VGNzgBljy6jowfIbQ7PJy5CKcReiqjvaertkbbC9doW8KiTKxnXIKTHrbxwwMNucGb3/1g3Ke1ZOLiGEqtLFWH60ifil3OtnTw52/gmCl+dHivCVLwl8nz4YK53lojW3jR/NoOASF/1gy90aXXckZ6qZVFA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(376002)(136003)(451199015)(46966006)(36840700001)(40470700004)(36756003)(31686004)(86362001)(53546011)(31696002)(82740400003)(81166007)(40460700003)(356005)(47076005)(8936002)(44832011)(83380400001)(40480700001)(8676002)(82310400005)(36860700001)(2906002)(41300700001)(336012)(426003)(316002)(26005)(70586007)(186003)(5660300002)(16576012)(54906003)(478600001)(4326008)(110136005)(70206006)(2616005)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 09:35:39.5612 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 702ba933-e328-4a46-770d-08dacd361558 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT041.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4466 Hi Julien, On 22/11/2022 21:31, Julien Grall wrote: > > > On 17/11/2022 13:39, Michal Orzel wrote: >> Hi Ayan, >> >> On 11/11/2022 15:17, Ayan Kumar Halder wrote: >>> Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169 >>> Affinity level 3 is not present in AArch32. >>> Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106, >>> Affinity level 3 is not present in Armv7 (ie arm32). >>> Thus, any access to affinity level 3 needs to be guarded within >>> "ifdef CONFIG_ARM_64". >>> >>> Signed-off-by: Ayan Kumar Halder >> Reviewed-by: Michal Orzel >> >> although, IMO the commit msg does not reflect the change (i.e. you do nothing >> related to accessing MPIDR, but instead you are just not taking the Aff3 into account for AArch32). >> Also, I'm not sure why you used VMPIDR and not MPIDR. > > +1. Can one of you propose an improved commit message/title? Title: "Do not calculate affinity level 3 for AArch32" I think the commit message can stay as it is. > > I would be happy to update the patch on commit if there are nothing else > to update in this series. The series requires re-spinning anyway so no need to update the patch on commit. > > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 23 09:37:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 09:37:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447467.703708 (Exim 4.92) (envelope-from ) id 1oxmCA-0000pm-Lr; Wed, 23 Nov 2022 09:37:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447467.703708; Wed, 23 Nov 2022 09:37:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmCA-0000pf-IP; Wed, 23 Nov 2022 09:37:30 +0000 Received: by outflank-mailman (input) for mailman id 447467; Wed, 23 Nov 2022 09:37:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmC9-0000pW-Mp for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 09:37:29 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20617.outbound.protection.outlook.com [2a01:111:f400:7e1b::617]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 71c5e660-6b12-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 10:37:28 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8858.eurprd04.prod.outlook.com (2603:10a6:20b:409::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.11; Wed, 23 Nov 2022 09:37:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 09:37:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71c5e660-6b12-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AzVjYFI7anG0jg4L5qgC+pSMdtzcQstZSQdUI7YYd9CGUYAbFDKzmWFba/Kt4TX5RqECu8FZqJ4Q2txQFwUhNXO+Tjryf5p3Zu87eyagS4KStBVU9cK6vHxDua/xBR0v39682kpyDnLFIOgMtymsbCxIEbw+YzPch9t9fW7NtD1SSNDYS0WZO9X8sUB8xj4Mj0+ZKdubNsm6ukgd20ipn0toUKtyCHwoOvIbRZOJsegm2L4EDHFCjl7312rdBTAFW3GOuKzQA9E43fpViJiDK/+5xFJqTW9Mgyq0U7yIkGi0DPpQYh6lSEBjRrX/fkSvYT8p9zhBgEw7aaVJB3yslQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x5ty3CLTZ0hocY15yoErpTVc1qvUG4mLefS0k4LtJ8I=; b=Va84C3FqeJcUyNy5eMp469qv0bTS4KobtGM+aQjZ5Kv4lqkxWPWBj9rzm4PQ5JyNHWsaBMTsRzOnoAfNu4G/Rrxz/xfpMcJ9QfK1rAyAz8RBNV1rXE/Ee6FsSInNwWkUyiolVApjObBYPZaPFKDmsGuU7rjTLKdOaoMtiIEAx4qCEF/qjsA/mmwMJSQvnsv6pyC1I2Yrl9Nm0HiJm+x54MtXkJfi+7OQWWvUkcfvKmKxZdOygKqm/qCPlyB7TNUBh9AGpAnpudrmXgb2spmsaZO6862qay/z1YnMn5buJ3wfw1ZsjTtvn+XAGsG2AOgbEogyPJSzhXY0vA5tLs5VHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x5ty3CLTZ0hocY15yoErpTVc1qvUG4mLefS0k4LtJ8I=; b=uahANS8slMezmCHiQtiKlc2m32VyUchqus1OmguGOWpKd8VnVSIKPWYaPI+eS1dL1m1atWlAy2Ashb4gFwlU62wHPa4UKdi2m8Vt6sNbZ7Oxmnf1M+3DGaP5MD23ADyp+irHbEzexn4wntl29mn+Kszdq7X5g0iPXFv628dy7k/Sf+DSSDgOE3zUFJmf0e5oFN67mLvn1qjmd0oAlDkDH1LLGHc+dG6P318kGeaYxnGfilnRz5rWrtyWKcY1z9Hd/46VJx1RffqT3splrX3E3mZ5zk1IIPys1il3MwYHOy6RYQbd6R5ITYZDEAGnvldw9owUz0GrD1WrGOzJQQYj9w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1a9a16d9-221e-6fa4-0ace-fd6e8afaaa4a@suse.com> Date: Wed, 23 Nov 2022 10:37:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 3/3] x86/xen: add a dummy trampoline for Xen PV guests Content-Language: en-US To: Juergen Gross Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org References: <20221122163810.29752-1-jgross@suse.com> <20221122163810.29752-4-jgross@suse.com> From: Jan Beulich In-Reply-To: <20221122163810.29752-4-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0145.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8858:EE_ X-MS-Office365-Filtering-Correlation-Id: d2cd3074-9759-44f8-342f-08dacd36547b X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /JEJ1A1tsKVMY1X+NXNp5Doav6TVzAqldaZuxe5i9Tf266fIsAK1T0623sI+Q2PneAhBZxUKxtuKptbX6egWoYac7XiZfrA5RZDxe/bhJ4lifHCQDNyS3mPB3PmxehG3rGsDvH4oTena9KkCxn7fCgxCTLbycA9m+FhrMgEZrJvhNw5118+eas/luA4Lko6ZnZzwxL6L+8tE7jQWwi325Axm1vW8N/5m4OQ3DPW1ycjl4WJ/zfPmOdVKzihLtKXcwkdXXZAf25cut9pVlK8g1E9ky3ER3Hr/BWTnxLzci3MqZj0TYkCHDrmP3R6VcYBfjt+VasOEgjp1FT2wds7EzyKz6n16iC6erC3XPVnXD12ePAXa+qtNpo63QmwrubaFDJ2H8izScliamBJB1e2Vyumyjp5RYK3j8oLRbi8kw20tVVfhM/Q9s3rMXOuRHxeYhA4urQcOpK6yV198mdR7X/lLVToUOeroXHyPZrN9CMe+P4Pv4Avz91hRJoGR5GwyNSVAqZM7kPSz2WnELj7Chzd1QN5c0MeB4LidqEKVuVlcCWSxogpKD4wu3fXFmY/ovvrXrC01xjKEuP9R7Fwo1XaQcQoohvfsdHjqncocBIY9QT8As32Pzbsmw8jX61qlGw2FLZcRD2WDW6VDOaiZ8qxPzW1t764P5229Ne8g4ljZ14X22zsH7tUPhqUIFLSLIFY7rfJuT6smD+a3Okm+d+6Q0OEkQVHklIQ0mOi/O5I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(366004)(396003)(136003)(39860400002)(451199015)(8676002)(316002)(31696002)(86362001)(66946007)(66476007)(4326008)(36756003)(5660300002)(4744005)(6862004)(6512007)(41300700001)(8936002)(53546011)(186003)(478600001)(26005)(6506007)(6486002)(2616005)(37006003)(38100700002)(6636002)(66556008)(54906003)(31686004)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFlPSzJlNEZFSDdsdnpZbnEwQWFLQXJncW04S2cwYVdkczlPeGpUZUx2QVVI?= =?utf-8?B?cThRZXNZSG9RdGpTMFFvRE05a29iOG1yanlpQ0Nud3F0aVloelpOelk1UkRo?= =?utf-8?B?aWxhSWsyUTdvc0IrcWQ0N3dxT29OL1JyTXFwODM3d3JLQTluV09FaTZ3WU1W?= =?utf-8?B?aFBYem9HTldkYkhQNUlCdUM3b21WS1FpOEYzWkpuem4xVitwT0IyNGlmcmg3?= =?utf-8?B?V1dNeHliNmlha0duMS9vaHlVQWNKNytJYXFLTDNMWXphdFhGWGF2ZkFpcVVN?= =?utf-8?B?T2dvTFUvTmFrMTdaOHBEd3dyYXNyWUpuTzBjUThtRU14MytjUzBQL1QwR0pm?= =?utf-8?B?dFFEdThoYVFhSGsrQnQxY0lsVUYzSHRDczlGeUtxYUdFam1lbjRBbDVDQmJH?= =?utf-8?B?d3o2Qk1zQ0czWVQxRkp1cG41bForTDVYRWc0enJwZXJwZXJycGJHOG1IK2wz?= =?utf-8?B?WnMrdmk4YnBIaXpiTkFubDFzNHhPZW1PeGdXZWw2N1djNDMvdVFScHRHZFZB?= =?utf-8?B?cWZETWJWRFdINUhpTlp6MXRqYzJCMm5Uc0hHRnJaWW5YcUp5UFloZFRzc3Bn?= =?utf-8?B?YnVGZ3NtQkt6VjhBUnlpYU9ES0ZpUlRXUDE0MS80bkZnREpXUnBpbW1IUmhU?= =?utf-8?B?UGFxTmRIK09QRG5TVzh3TXJxN1d1OFdjYmtITFZLTWNET3k0MUZEUnpqWFgv?= =?utf-8?B?ekxTd1g1eXNidHgwK050SlhMdHVDTTZ2RlljNDFWMU9LZzBrMlpSQ0R5QzA0?= =?utf-8?B?dE0wdTlwRmlDL2U3N09SSHRqTXpzUnUzWFRNN0xpRkdybldaY3ZyQjVRbVJx?= =?utf-8?B?N3pCa2ZkNjdvSTNLdElaaXNvNE90bmo3ejNDV2ZWc002azlFclhadkFVMHpX?= =?utf-8?B?Vms5OW9vbjBCQ2pNcFBwSDhqMnFRNTRJUmJPRWgyb05odUlpSFpJNmt5WFhG?= =?utf-8?B?V2pic1RPZzdTWGZId1pWNmtiT0RKTm04VGhnUU9NOWxXVUdwdThSK3Z1eXVL?= =?utf-8?B?T3FvOGtORmRvb0NBZTlGcGJ3dlBsTjRSYVRVUElkNE9VaWtKenhqS1lrVXBy?= =?utf-8?B?VWRtY21oRVY0UjkzTFBHRHV2aVYyOHltdUpzZndrQmxQZ0ZiS3Z0RHJtUXYz?= =?utf-8?B?YUNBNEFCRXhPeTZQcmFsdUloQkdkeUozTFJXTGhRZ1lmaG9aTFFmMXFoTTNB?= =?utf-8?B?eG5Bckk2ZWxab1RXb2ZNOUwvNlNVRzRGczkvNGR3cy9HNlZnMVpUN0VLbnZk?= =?utf-8?B?dVhkYUVOdGdzSVdzb1g2TFRaTHhaMnZRdHluTkhValRRWVBBOFJCWXNvMEtV?= =?utf-8?B?M29OS2tPWXRFc0F2eE9lc2NGRGJKRXhtaDd2TXZ0Q1lwellsd2RMUTFMK1U3?= =?utf-8?B?aDc5YnRYSUVtMnNLM3IzL2xJd0xmQzY4NVNoc3FEZnkwK3NqeWZvZ1dWaGt5?= =?utf-8?B?MStYK3ZZRisvbU9HYkxYQTVOTktrNkdSblRydXpDVmZiWGdXa3UwNlBBNDBX?= =?utf-8?B?bmorZ2VIeVdYQXpUL3Z1bk1oRjRnN0lydVZicmxIYlVjbEZVY1dja1VJdDM0?= =?utf-8?B?anNBVXIzNWZ2TGV5QUttZVVEek9INVk0eDBuelRyUXg5UFRQQVR2Ri82SFNn?= =?utf-8?B?dFVPck5sQ2dFODZzang2eDIxUGVTUTB3enVhMU4xY3VpMGU1Q1FUdENtYzlq?= =?utf-8?B?Y2F2dVdINy9zeTBCcW5DUnJYQzVVTk5XbldRdUFVZmd3WUxkcjJnWDRRZFNu?= =?utf-8?B?K1JmRjdpVDFEWDd5K0dhb0pyd0REYkNmYzNSaHViNE1pN1BxaXBscXBMelY4?= =?utf-8?B?ajJ2dzJPWW5RcWl2N3RENXJrSjVuR0p4aWNZN1JJQWdFbGRGVStKWng0dnVU?= =?utf-8?B?aWJ2dUQ4NjJSS1MyNmpxUGgvUHBEaVdtZ1lYRHpkaXJPRi8vOEVDR0ZzdjI1?= =?utf-8?B?UEVPaHE0N1hhWm44SHdVTjhWMlVRTkw4citkSnNOV1cvUThoOWNOa3pHVWJI?= =?utf-8?B?K25uYlVuOEpOWmxCQlppQk5mOHNIZ1JHcWdsQlN0OW1VbGEyNTlIU0Y2R1Rw?= =?utf-8?B?cUJ2RHNqY3BBdDhMbVYvNllFUUZQc1JubjYxZWZhYm5XYjNhY3h4ODduUDZC?= =?utf-8?Q?pI/+elSyCG1YQSjtxqbw/kmgV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2cd3074-9759-44f8-342f-08dacd36547b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 09:37:25.7509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q94exXPPITLJRrX4O4d/1RterQG4+qNQSFHCJ6p4b1Q4hHSoRYg91a2B4awodEo1stBZjwTMODPtbJwCkdNvMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8858 On 22.11.2022 17:38, Juergen Gross wrote: > @@ -137,12 +138,28 @@ static void __init xen_pv_init_platform(void) > xen_init_time_ops(); > } > > +static struct real_mode_header xen_rm_header; > + > +static __initdata struct trampoline_ref xen_dummy_trampoline = { > + .blob = (unsigned char *)&xen_rm_header, > + .blob_end = (unsigned char *)&xen_rm_header, With both pointing to the start of the struct, doesn't it suffice for the above to be xen_rm_header[0]? At which point there'd be no reason to wonder whether that struct could live in .init.data ... Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 23 09:42:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 09:42:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447473.703719 (Exim 4.92) (envelope-from ) id 1oxmGO-0002Rg-AL; Wed, 23 Nov 2022 09:41:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447473.703719; Wed, 23 Nov 2022 09:41:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmGO-0002RZ-6O; Wed, 23 Nov 2022 09:41:52 +0000 Received: by outflank-mailman (input) for mailman id 447473; Wed, 23 Nov 2022 09:41:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmGM-0002RT-RX for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 09:41:50 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062c.outbound.protection.outlook.com [2a01:111:f400:7e1a::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0d698ff3-6b13-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 10:41:49 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9383.eurprd04.prod.outlook.com (2603:10a6:20b:4d9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 09:41:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 09:41:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d698ff3-6b13-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bOavXKx0BcA0o5Ktrv1/Tebv6tr/BWObddB2RXaw1TKMkUJ3ndZM8GXSHqP5zqMUhR2lTWMMMai+4nRlXlNXon8tzsZbnoPX+Tt31SCHQLXdGIkajwvIoZPa7aK5RCNOJNVG3CTEBc3o/FVB+MEP6OFlMlsnujnECsMQ8bo2euxR6npTD1C6qZtofj/OexWnxl+kcfN6vyvbxWyraicSaKBx7iyRTyaTLLKd/LsfHhYt/9ayxEJNP6O/x2LFZ7Of9P9Q/0uUAJzOXJ3cQy6CYnV52/hFELyWXMzXsz47GNzn722SD+FRM9Ud/NwzGshahXOHWCCRiuZjyLLi3CGWVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XG1AHlPhDXiS6rIw87uuY4aq1P2umvYb3YE/AwvEi+g=; b=gfuocVR/YKwg+0cq/vygONg6W8Rsa4cpFVp6N/AV/PE9dbuAycGFTPY2K8tyMp1JjzConjV7pfadRDPD/z4K38tjW2XDkTPEenVgtolACf/rr9NXne6xHtpOUz0V2hc0t1hqWdfP8Lq89STnMX0McL2bbLwBwhY//ww9wp0cNgAlXHp4bkhahJnbCEcGhqi0mkorH3kavc9iTGc8BMIuRtakEZNuT43y43FN0DQ7xwOfjY60MHOr1L4q3+7SsXT0auP3PsDdRi8uh32PCpRsjwifyHO1qxM6WYoNRAAB9gKaRldvPo/E0ra1RBG80sWB4c9J5CN2UW13nwCAj4ukzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XG1AHlPhDXiS6rIw87uuY4aq1P2umvYb3YE/AwvEi+g=; b=sUb0jKe3w+bkGDuzvKR8UPM6NLUCOfWVvTHd0RskzCH71btx+k0UPl/FfrFLEsdpeEfcKj8mmLIi5eRButTu/e5OqhHdxz/jnqIRnmvfZ3A3fiVZH2zRxPoFMsS6DIX5tFX7N2xJlgSEvIzKGwaqx/VXKxaaBxrmSbmndbuFHU0ixd56D3FGaoEhVOuxvlETFAx1/5LC9W/PDeQT5ffRbBaRRbwUB0ft3TBXehwr4MEHbL43fJnP6lU3I0/14BsEruW0QqeX7+2oxBgwfjL5wto/Au2zEtaXjbhi9Gl3ejx+hC/K8lOZJ4NjGcqNu+prMhs4TcP1Z/m2VN/Tuq8qTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 23 Nov 2022 10:41:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 2/9] xen/arm: add cache coloring initialization for domains Content-Language: en-US To: Julien Grall Cc: marco.solieri@unimore.it, xen-devel@lists.xenproject.org, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Marco Solieri , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Carlo Nonato References: <20221022155120.7000-1-carlo.nonato@minervasys.tech> <20221022155120.7000-3-carlo.nonato@minervasys.tech> <2e6c8d81-01d1-81a1-8fd4-4385e46befe4@suse.com> <6c07cdfc-888a-45bb-2077-528a809a62f4@suse.com> <2645971b-8094-6108-f3dd-567e93d1f1e5@xen.org> From: Jan Beulich In-Reply-To: <2645971b-8094-6108-f3dd-567e93d1f1e5@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0061.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9383:EE_ X-MS-Office365-Filtering-Correlation-Id: 43049f81-f4a2-4253-c13b-08dacd36f0b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3rPkZHP8sTy+RiOVPJYz1YhLO4SIZmLJ+Q79EBLiNTCS+YfcbFAOVTUu9PBJaJ/ZDQbdvhZpTah48NFzeq2oO9wbrZBtCsiTFiutGAk98eOpk9rGymH4+6khOaKA1MsqHqrsvgfej8iVs+L7HoxHWb+WrF9tvJdVTi7kDr5fg5/3l59W5qK+gIICASUuWyKUpOwhyOEUaRNg2zBqbQIwea+4gjt3kTqLIDS343nakFpW5Tmn7g0muKBG272D0wrW6z0MPtsUldQS2QuPlcmTuH4X6Y8PuoA9UfkTmwJIi7rPv+gFJ/FrW3CCtv944fR78bilLawh+4q/vxEfDbEBr0A+DFFkkq0TS69QjUYR+wkLwCCm/dq1bMP59jBFOwHlRqt91MmvodMWatij6l29OVlNibn1iaOvDnKaxAVLz/7uFcIHN20kkYeWE21nAcqiMa9ZPmzmFs5FmDTXWGxA0q1wicgphy3awIIcVkkIDMx0swcSChF5xdl9bojIezvWGKkB1kvsyvAcpiD0CJTvyANNTFcDWOhM+XAhEutYAQNCXX5oRURXaMLKVUGpiaWOT35N9A+7Ck9aqMwmImj2frIldc34+bBcQVhYua3IM1wzCXJSoAX5Ug1NpWMFCPEULG2RJGQ6K1mBp3ofwLnz4AhOY8sEBxcfY7VKa1EXv23DZjRii1hoGB+R4XjnaXhelk6EXBQdTAyoggqJ3wXHE3ExkwfyXIz1+v9cN2zG16c/ffjn/LyIg71Q/G9cpXv3U+kd52DZ9Xf7jyaIKxLetQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(366004)(376002)(346002)(39860400002)(451199015)(66476007)(41300700001)(31686004)(66946007)(66556008)(7416002)(5660300002)(8936002)(2906002)(66899015)(4326008)(8676002)(316002)(6916009)(54906003)(966005)(6486002)(478600001)(31696002)(186003)(2616005)(86362001)(6512007)(6506007)(26005)(53546011)(83380400001)(36756003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEt3WGVLUGtJcFRHdWZmSVg4RDZDenIyWk9WeUU0VHNSZkplc3pyTW9TdnQ0?= =?utf-8?B?a0dRaVZaOEN5QnBZWVhDWlFGUnlDMmJNYnEzSVJsckkvVUhQaWJzRnl4UjJn?= =?utf-8?B?MjBtSStZL3JWa2pXR1c1MFQ4TGt4K25EdmMyMGtMdkFDalNxekR5VXhqVjNT?= =?utf-8?B?dnhScUxRbWRiM1FUMlBMQVQ5cjlYVVdyQU9Ubjc0SmFsR2E1OXk1S2RPWHlG?= =?utf-8?B?enlaSU55d1pad3BUMmZQcFI5c1lQQUw3bjQ1bGxXcnIxazJGUWNXSHltVURX?= =?utf-8?B?RXJhNGl0d3FPRVJHUWo1LysrZWVnNngzWVhEejNZcVFiTi8zU3Y5TkZZenVH?= =?utf-8?B?RlE5RUxHN3VXUkkzZ3hDaEJTUWJhWndoS3VHd0hnenc1NERtbUZjRnc4WW9T?= =?utf-8?B?SEFqcWM4WFFGcDdCQnIwYUZWNlhCWWxaNTIwZVQ0cG5oTWdSTWpnV29RTVdB?= =?utf-8?B?ZDJQM20yQ3Nac3ZxSDRwb3ljZnBqYUlGSU9VZU1YQXJjN1F6U3VqcjE0SUti?= =?utf-8?B?NE9OVHZhMmptcU1CVUV2U3pkY05ERmU4RXZ6Q1h0Q2ZDUWU3VDNyRDBMTUx2?= =?utf-8?B?SmtJL3NEd0xJYndrdmovNk5iNklZTWNTUHo0NE80ZjFSR2xwUERJNWppaG5T?= =?utf-8?B?Q3RpVDZCajNCQU5VWGRYancyN2V5NXpyVGh1dGJNMEc4VWF5MVZsa1NHMTQv?= =?utf-8?B?RGR5Tm5rUllnajZMWDdUOFZBVU5lUWxGOEU1SnlONE90RG81aHA3WG4vazE3?= =?utf-8?B?RzNJODluUVJ2Sm1UMVVsZHlMU1g5ekZISVY2QzA4Zkp2NGZEdENrVXF1ZHpR?= =?utf-8?B?THFseVh1WnVYY3VNWXlZWkJNajFSL0FHdFMwbGdvWFd4eHZaZUVMRVFWSU5N?= =?utf-8?B?NWFsdFA5NEl2YWlzNWZmLytyTFpPQU9GeW9oaXc1azBaSVp5Z200TjUvS2NB?= =?utf-8?B?R1pKV0ZyN2FDSk9LRnl5d1Rsa0dpdHNST21KcGtxTGRjdzZHaWRHVnpuUVRu?= =?utf-8?B?dEJhcFA1bkRjbEs4ZVZJMU5KZ2ZhQkwwR2p0ZWJLclVGMzhkLzlxS3pBVHdn?= =?utf-8?B?QUNBK0RLaERXRVZqS1FkTWQ2bFAwVjVxZFR4WjR2Qmx4YnJoOWgzQWZyb21r?= =?utf-8?B?VFRoZXA5dURqVDBpckx5RTBNdFN1dCs2RHlUOVJYRytWTHFmNjR3NG9hTElo?= =?utf-8?B?NWg3bk1wajM1ZUI3SGZxR25xcnFTOWNnejhBQ2dYeVFMRmxMRzNCVWVuV0dU?= =?utf-8?B?aDZsNEJhNlNpR2RnNDBRMW5FSFh2ZXBhckRVdS9FQmpDVDlzbXZjWllGVlJ4?= =?utf-8?B?Y2x1Y2xKWjdvZmFUYlpoaWtLMXhSQ3JkZlNIR0dBRVVnTkltYUVPdlhmNC8v?= =?utf-8?B?SzNRWXRuK1JLN3ZGMTZOb0VyK1hzU0sxVnBkbklsQktKZG1jL282QTFkVU5t?= =?utf-8?B?aXRRQkVVNVJaaXYxTDF4UGNwdHJqTFNvOFJDOUFBRzF4UlRYVUtrbWJjb2ZN?= =?utf-8?B?dk4xTzNrTWdiRzJUaHdrRHZ4MEVPVTduUGcwTzBVWTloelFxSkYzNExibERx?= =?utf-8?B?cXlSN2Z6VXRUK2IrMXZRaDVoQk1ZczFldWJPM2xUT1Fzb1BsWDFZZWVsbzZt?= =?utf-8?B?V2xudzRLUTlxTW1lbTVocEpWMkxhdnFCeHo1bkEvN0UzbSs0MHFXV1B4cmdt?= =?utf-8?B?NTB0M1FtMldkUmQrTHFuZFFSR3lTY0wyanJuSnI4TEdUazJuYTY2S2ZLVkpa?= =?utf-8?B?cjg2Q3ZaMHN0c1hxWHFmN0J5bHpzcWJxZVB6djc3eVNvM2RDRTdoTEFLbjFQ?= =?utf-8?B?MnkyUVd3VXVFTkpZdk84eVh1WTJ0YVRNL3c1MjVOWTZUaVZrUTVLWlBQU3Za?= =?utf-8?B?VEhrdjVGaTFKWXVKblNDTHhQejBTOEoveC9VTitWWXhxNzJUL1Y4Y3BBN08r?= =?utf-8?B?ei9wbDR1ZUdmKzFBZUxGK1NQZU13dUlqenI3QUhRYlBRelR6M0tZWU5lY25i?= =?utf-8?B?SGh0THRuY0VESFpyUHV3UktaSFQ5UXVjLzBUUXVhVGYxcndtUVFWWWhkL1dQ?= =?utf-8?B?SzVBbEEybGViMnFrUjI0Q2dHSVhWMDFUdEtEMnNGRnQ4YzliUkNNK21Rb0Fu?= =?utf-8?Q?Lf/8WvqdkQkFQzIV417KV4m1r?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43049f81-f4a2-4253-c13b-08dacd36f0b5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 09:41:47.8280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iLbkd+EkpIgBjimzpArSfDorQl7v57pUPTQye4vkpgaV7iOVH0ftAfk34WiG0H/2jzIPHgaaea6Hebg4yVMPPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9383 On 22.11.2022 21:25, Julien Grall wrote: > Hi Jan, > > On 21/11/2022 16:40, Jan Beulich wrote: >> On 21.11.2022 17:23, Carlo Nonato wrote: >>> On Mon, Nov 21, 2022 at 4:14 PM Jan Beulich wrote: >>>> On 21.11.2022 15:50, Carlo Nonato wrote: >>>>> I want to ask you some questions about this patch because in the previous >>>>> version me and Julien have discussed how cache colors should be passed in >>>>> domain creation. You should be able to read that discussion, anyway here is >>>>> a link to it >>>>> >>>>> https://marc.info/?l=xen-devel&m=166151802002263 >>>> >>>> I've looked at the first few entries, without finding an answer to ... >>>> >>>>> In short, using struct xen_arch_domainconfig works fine only when domctl >>>>> hypercall is issued. That struct contains a XEN_GUEST_HANDLE so it >>>>> should point to guest memory and must not be used when creating a domain >>>>> from Xen itself (i.e. dom0 or dom0less domains). The easy way to go is then >>>>> changing the domain_create() signature to require also a color array and its >>>>> length to be passed in for these latter cases. >>>>> Are you ok with that? See below for more comments. >>>> >>>> ... my immediate question: Does supplying the colors necessarily need to >>>> done right at domain creation? Wouldn't it suffice to be done before first >>>> allocating memory to the new domain, i.e. via a separate domctl (and then >>>> for Xen-created domains via a separate Xen-internal function, which the >>>> new domctl handling would also call)? Or do colors also affect the >>>> allocation of struct domain itself (and pointers hanging off of it)? >>> >>> This would be really good. The only problem I can see is the p2m allocation >>> which is done during domain creation. With the current set of patches it >>> results in a "Failed to allocate P2M pages" since we want to have p2m tables >>> allocated with the same color of the domain and a null page is returned >>> because we have no colors. >> >> Hmm, I see. It would seem to me that this p2m init really is happening >> too early. Ideally domain_create would merely mean creating a largely >> empty container, with stuff being populated subsequently as necessary. > > The vGIC is not optional. So to me it sounds wrong to defer the decision > to after the domain is created. > > It is not clear to me how you would check that mandatory components have > been properly initialized. There could be final checking right before unpausing a domain for the first time. >> But I guess this is too much of a re-work to be done in the context >> here, plus of course I may be overlooking something which actually >> makes it necessary for domain creation to be structured the way it is >> right now. (Imo the reason for the early minimal population of the p2m, >> added only quite recently, wasn't a good one, and the vGIC init would >> better be deferred. Yet once again I may lack details on why that's not >> possible.) > > See above for the theoritical part. For the practice part, we need to > know the vGIC version at domain creation because it impact the maximum > of vCPU we can expose. Sure - I didn't suggest to leave that information out of domain_create. > It is also not very clear where this could be initialized. Are you > suggesting to add an extra mandatory hypercall? FAOD, I don't think > p2m_set_allocation() would be the right place. I agree with the latter - that would at best be a bodge. And yes, I was thinking of having a separate domctl for that purpose. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 23 09:49:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 09:49:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447478.703730 (Exim 4.92) (envelope-from ) id 1oxmNV-00035G-0e; Wed, 23 Nov 2022 09:49:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447478.703730; Wed, 23 Nov 2022 09:49:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmNU-000359-UB; Wed, 23 Nov 2022 09:49:12 +0000 Received: by outflank-mailman (input) for mailman id 447478; Wed, 23 Nov 2022 09:49:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmNU-000353-12 for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 09:49:12 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130043.outbound.protection.outlook.com [40.107.13.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 14510261-6b14-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 10:49:10 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9299.eurprd04.prod.outlook.com (2603:10a6:10:356::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 09:48:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 09:48:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14510261-6b14-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GEKlvSeNiuDLfEhIIKgwYaTrV0AjDn2/n0pn9dSGyhhslxBVvyRLRYLtZSpdlbr98uQevJCL13KgZsijJfW1bk4Olmm6OzNf/ZE+aO9xINRAt+vPvN2Jyea833Wnb3k9z85xlgaEAJ0fY1IJz3tvh1QtY672aoAmg1oYnt5RWfwcGymCr9C0MDJYRUFpYdsJFatvmcOoHB2+NRod6UZCgeUlzX5g4XHJjQsULg+1QKeHZIhLMZOqEP+9/6PAONAQneJgwflTWeQLmjBWkLJXL+oVoQv9qSTET7pDVSCyaQicTfuxc0fQRzqkxkC6C9kybU0eUNJvJcnzKLZ24M52QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gNau7kEw/1JZlPoPq7/ahtZEnJsjIHP0Aq2EgbodHO4=; b=Y7CvWcMs0rGSsS9Lm9mBiCaFbHlNeT85tulnxSmHEgG0SQzgQrxYAOHWF2peJZOXGd3caMNpl+Nnuf+zZOJV5jossKF7aXJ5cnusECdXlVC7xRjJbMVT2OpWvJsUZdceG9QgWShK+lV8COLt3kdmT3OW8bY05phZCIwDBpCPwZYmZNnwCMK/jO45wEYOT7TwUe69DJiQKNyvN/CdPYjOjc4UG7+mzBzL7CinMPnVVSMFjzOIenZhoTNMbDZRy0JF1Q3ZjPi8GkZ5NTWtFZUAv05k1Tg/qTogbCOWzCmRBL67Ko3NN8cGOhPg8CVlPatUMg3LVpraX3PSpixSb9ywDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gNau7kEw/1JZlPoPq7/ahtZEnJsjIHP0Aq2EgbodHO4=; b=tUicRpuBUMZPjlxsX+uuI0HhvyTxrYbbE9j673sqq1tI7MZ4dH4o7RJVAmOnYFFkMzLdVmZPBtHY+jqABUvEadG7uziSrGt9Q4osQfYMs3dHJfskOJsVlxcBs2kjcHAclH+vLahrI2tK5W/Lc3RVYRi1yIqesJbleXCJ0OAciVAEsXVlYoUX0auWRlfpZtTV1Ylms1aEbnFeu/QDBhFw/xdFEr1GduV7AEyhdR9pOffhfnL2jBjwvxj6+MJ3WVC/5k7311f53GAgLiroScHf5ds1EOi5hcGJNLpbssGF4gKwizBD+vCPvq4PrO5c82BbJNJ3H/gJRPAD6zLuWbpUGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8d26e256-d5d3-2cc2-9cfd-c5cc6fd41b79@suse.com> Date: Wed, 23 Nov 2022 10:48:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 2/9] xen/arm: add cache coloring initialization for domains Content-Language: en-US From: Jan Beulich To: Julien Grall Cc: marco.solieri@unimore.it, xen-devel@lists.xenproject.org, andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Marco Solieri , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Carlo Nonato References: <20221022155120.7000-1-carlo.nonato@minervasys.tech> <20221022155120.7000-3-carlo.nonato@minervasys.tech> <2e6c8d81-01d1-81a1-8fd4-4385e46befe4@suse.com> <6c07cdfc-888a-45bb-2077-528a809a62f4@suse.com> <2645971b-8094-6108-f3dd-567e93d1f1e5@xen.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9299:EE_ X-MS-Office365-Filtering-Correlation-Id: 906f16e2-f26e-4e3e-8cea-08dacd37e6bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RVk3FVISovgINM+8iSIL32xJvcUfRyJRMvhHvTvp/7VOP5Oa/KSCXqq9II8uNBtS/a7yP5l9cjsLR+YkInAcl+u6mr5nR0g9Uq1l0KmKcxkqimQonf11OCumGJRyTgwZyZeqG4cBVvR77kzm2VQ3AYmxCxHfdzN8h8O11Sywzt8wyaaN+VHZM7wSRUqWQ9zD9wsHOnmb2Miko7VMukeeEjvG/GW7ZIuYBfYSt6DR8cLj8Igji/F+MUnx6l87+GM6FkOlJ7b02LOcPEVc5JlgQwURS66PZrvd8oUKso6rO4Pw0EbnNFJXtlE64TJZPZ0C2R3mVXA58eDywp0GLBB8icTbqjgx3v1ig9+BDsNKeACNorAZMpIwect9AtAu73RwTvwj0S+J2WAl8rJ74o5Na8I1h0nzSJXoavdlaHPsRaYFKnnG3kyI6uHpbdo5X9Ie/s0M2yW1+2ZcqeFBb6Khh/S4Q2BxGxPEQVsteF/dL0NMnN2qD1uvjtl5S6gKmnAwTCqtuEiDFFSkiof2/zQW4dP/VI/BJrjetZojx0nwUSbtzP6gYzQ0JkBjmSu3264zz9rh8vGQQFbIBqh59VgjAuMj8YFEtB9G2ff2nLhkw8dpurHF4h9uh8n4AeqL3gTOTiG2gysVDZ0ZCj/hhggj03dEcSrOmwUKBe8zIx7uvfj46hup6O+9ecYnAD0sEdS/nw2SWCMrLJsooh2yGl+AwlRDfa93hgGAuRLrcpXzbls= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(396003)(376002)(366004)(136003)(451199015)(36756003)(478600001)(38100700002)(66946007)(4326008)(41300700001)(6486002)(8676002)(66476007)(316002)(66556008)(54906003)(186003)(2616005)(6512007)(26005)(6506007)(83380400001)(53546011)(86362001)(31696002)(66899015)(6916009)(2906002)(31686004)(7416002)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjljM0VhbTRWQ0M5TG81N0RoeEd0VkpibjJtdEFBTzJ6bGRTNFhIZjdqbnBa?= =?utf-8?B?U1dxc3g0Ykx4TEVPTElFeXJZclZXb3pzOVdaTThvYnhXc1ROam1FZWE3a3VF?= =?utf-8?B?WDQ3OTZVK1VsNXh6WWxLS2djZis2ZHM0cjA3RllFNHd0dzNzRDVhQ3VOMG1z?= =?utf-8?B?R1QyaTg2Z1NIcUhsMlhOR1REUzdXcTVEbHlEY3BEeENCRVJHcVNER1lDSWox?= =?utf-8?B?Yy9JbnhEc2RGbTErOGFsS1NVTTRtSTYxYVU4TldsSHVYSDEwMVRCL0pJcVpv?= =?utf-8?B?WlF3S3hhOU1YaXErOG9tYUxWaG14OHZCdkxPUnFoYUE2YXlIWU5WOStRTlUv?= =?utf-8?B?d05IWXczVWZKZGI1RS9jQUxsb2JJUldIVi9Tb3ZJUkFJNVg1eVlwZXdMRTB6?= =?utf-8?B?QkI2eDVYRFdud3I2cUdhRVFtMnZXZU1vUXh4YzJNRU9QcExlR3lEN1NEQ3dH?= =?utf-8?B?aWZ3VCtyWk1ZOVIrNTU2VEk1dVd3Rm5BK2Y5a05VbVpPMkJnS0UvQnRXd1pN?= =?utf-8?B?S2pZUUFtTlp0RWpteEdmeTM0YTFpUFRteEpxM2xlUTlCZUx1cW1TVEU5TW9L?= =?utf-8?B?eTZUUHp6RjdqNnF2SjRRNFFMaXltZWd6UG83bHo4ak9FSHlHVVpLN2dtU3lV?= =?utf-8?B?dWkvejhITWJnQkVhYWNoaG8xbDlVUGpRQTZUbC9MTzB1d0VlaHlvUjFiUXM0?= =?utf-8?B?TlZ2dWM0QlY3M3g3aG1wYjUvemJoSmxDK1BLQU1ZUjlxRWdEcGRIelJXdjFw?= =?utf-8?B?MXFJNmoxSW5kMmxtK2k3WFZmc0JKMDBpWFNtTDVWeU91M3lBdXFPVC9UdVdW?= =?utf-8?B?cDlHTUwwczBmeU0zeGpnTTZFRld5SkMxVTlWU202V2NDdXlsK2l0QVFxR2Jm?= =?utf-8?B?SjlNNGIwcGcvYWpKV1dpUWxtQ0dtR3doQy9lU0duOWdxc2J1bmVlZ2p4OS9G?= =?utf-8?B?cml6Y2JZSS9FWHEyZFZ4dmh4em5LaDJlTDhsR3ZxY1dDWVg1V3hvTzhicm1r?= =?utf-8?B?K0xQL1UvVFhlTGtpUnZhaWR4aWlUSEE5VFMzNG5HeDVTUHJhdGRnc2x3elNm?= =?utf-8?B?UGk5M1E4cHVlSGs3TWdrbnlDNTdBUUxuekJTcWF3ZUNyRUJNRWpwL3R5SExv?= =?utf-8?B?Y3pjMFBnUzBKd3ZKVkJjVkRlNTVJN2c4U0FQR012Szk1Q2p2VWpYODdkcWpt?= =?utf-8?B?NmZ4NEhYS1N2M2lLQ2lIWHlJRWFtQUhZL09TbTFPZ3lqS1ZWcUZVSDlZVzdF?= =?utf-8?B?VXQ1VCtBRzZURXVzcTVRdTJFQ096aW9NTmRUeXdabjl2MFdOTlpNaWRZTU4y?= =?utf-8?B?QUVUWUdJdGF2VFFjMjJYMm83Y1lEYWNXMDhJNFdpeXhhMEc1Wm9yZmxXbFlH?= =?utf-8?B?SXVHZEVRcTVZT1JXMzJYNzZjM3NqdEdHTnJ3aWg2bXFBTUFLc0I3OWROdGRw?= =?utf-8?B?amlkME54Y0JFaFNUdFVDSU8rL3ZKbFBlVGNUd0VCWWhtOUtucGtnUTZNcVBv?= =?utf-8?B?TzY0MW1VVEt2ODJ3TWNrQ05Od0ZJaFRzTnlrRXJuUDBiZFNHMHVvSVE1VTZ6?= =?utf-8?B?cjg3U2RFZzhOTElRRmRjOEswcDV5N0hpKzJkMzhQKzdzYTFOejREWmhoL3Ir?= =?utf-8?B?WG4rVlpQTWkrcEV2V0FqSVQwRkJ4TGsxV2EvY0tUbURQcmRiT0M5b1VHUG9V?= =?utf-8?B?cnhRNGxXaWQydWVMSHdWTjM4eWk3VkxYUUphK0l0YUY2YWpORVNsbWpUUjcx?= =?utf-8?B?bzVVa3ZTb0tzK0NDVlgrRWpiZFVZMFVmbHN5Wm1LWUt2aktIUFFoMnprN1Rs?= =?utf-8?B?VTFHeFRwTExHZExwWUtTTGRhVnRNR05WbUpjdHZYVy9IT1BsL2ZxbHhkMmtz?= =?utf-8?B?dmpIL1BOYzlhTDhQRy9HakxUWGhjblFaOVBUYUxqbTNTVGFGZU9ESVVub05x?= =?utf-8?B?b2ZsRU81RW91NDRrSGR4U3o5K3J5a1dhbldLRmJGNzdCcDZ6VzdjUDY3SWYx?= =?utf-8?B?c004eVI0aWo3eDYvTStwTStEcngvL0tqSjlTc1VrREtuYnB0Umk0QjhRdkVv?= =?utf-8?B?K0hLVTRYYi9TSkZ3ZjJsNzROallLNFpzdEI2eXR2YkpVZ0VOeGdhVkFJU0NC?= =?utf-8?Q?NVen8qGG3y4CvTz87lH8RzeYh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 906f16e2-f26e-4e3e-8cea-08dacd37e6bd X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 09:48:40.5986 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jIBIFsyrxI3ZVyGiaePgdm5X61FvpXXvgrHV4ecXJeA9M45ML5s5Zbxeln+AiBcCfBDvjqyPQI9ueeLJZ6uJcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9299 On 23.11.2022 10:41, Jan Beulich wrote: > On 22.11.2022 21:25, Julien Grall wrote: >> On 21/11/2022 16:40, Jan Beulich wrote: >>> On 21.11.2022 17:23, Carlo Nonato wrote: >>>> This would be really good. The only problem I can see is the p2m allocation >>>> which is done during domain creation. With the current set of patches it >>>> results in a "Failed to allocate P2M pages" since we want to have p2m tables >>>> allocated with the same color of the domain and a null page is returned >>>> because we have no colors. >>> >>> Hmm, I see. It would seem to me that this p2m init really is happening >>> too early. Ideally domain_create would merely mean creating a largely >>> empty container, with stuff being populated subsequently as necessary. >> >> The vGIC is not optional. So to me it sounds wrong to defer the decision >> to after the domain is created. >> >> It is not clear to me how you would check that mandatory components have >> been properly initialized. > > There could be final checking right before unpausing a domain for the > first time. > >>> But I guess this is too much of a re-work to be done in the context >>> here, plus of course I may be overlooking something which actually >>> makes it necessary for domain creation to be structured the way it is >>> right now. (Imo the reason for the early minimal population of the p2m, >>> added only quite recently, wasn't a good one, and the vGIC init would >>> better be deferred. Yet once again I may lack details on why that's not >>> possible.) >> >> See above for the theoritical part. For the practice part, we need to >> know the vGIC version at domain creation because it impact the maximum >> of vCPU we can expose. > > Sure - I didn't suggest to leave that information out of domain_create. > >> It is also not very clear where this could be initialized. Are you >> suggesting to add an extra mandatory hypercall? FAOD, I don't think >> p2m_set_allocation() would be the right place. > > I agree with the latter - that would at best be a bodge. And yes, I was > thinking of having a separate domctl for that purpose. The expand further: I think setvnumainfo would also better be issued before _any_ memory allocations for a domain. And I view vNUMA data as kind of comparable to the coloring data here. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 23 09:51:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 09:51:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447482.703740 (Exim 4.92) (envelope-from ) id 1oxmPq-0004ZV-DF; Wed, 23 Nov 2022 09:51:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447482.703740; Wed, 23 Nov 2022 09:51:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmPq-0004ZO-AL; Wed, 23 Nov 2022 09:51:38 +0000 Received: by outflank-mailman (input) for mailman id 447482; Wed, 23 Nov 2022 09:51:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmPo-0004ZI-Vf for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 09:51:36 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20608.outbound.protection.outlook.com [2a01:111:f400:fe5b::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 69d9a9fd-6b14-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 10:51:35 +0100 (CET) Received: from CY5PR15CA0076.namprd15.prod.outlook.com (2603:10b6:930:18::27) by CH2PR12MB4921.namprd12.prod.outlook.com (2603:10b6:610:62::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 09:51:31 +0000 Received: from CY4PEPF0000B8EA.namprd05.prod.outlook.com (2603:10b6:930:18:cafe::6c) by CY5PR15CA0076.outlook.office365.com (2603:10b6:930:18::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Wed, 23 Nov 2022 09:51:31 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000B8EA.mail.protection.outlook.com (10.167.241.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.11 via Frontend Transport; Wed, 23 Nov 2022 09:51:30 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 23 Nov 2022 03:51:28 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 23 Nov 2022 01:51:27 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 23 Nov 2022 03:51:25 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69d9a9fd-6b14-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qvi/Ce245i4V2ubyHOvypLPl5xdmskz3vw8anI4c8Ewo7A2IVxxxEaULOQvzllBzQQ0i6EC9swInl7ft6t1nAXxjrqXRDqwUckwlNoFbfz0z19AU1d9kV0IFqcRix003OL6yQ0LY4tXk9xdFVtgxDR0tdqnBAkxK0jmptn696PAMXSPka091vdBg+DozJH+iEOo+r8YubDpAulEaTxXilws8IiCq6MXMTmZ7NMSgBFWcZCEWe/JT5kclRL1Lqb94d3lOfXLSeDrav/tKMerf0Iti9YtBhI1ostO5hyAw+zEreJHnLTD4bwBT4q/iBS8zm4uM0BFxbN9gRYegYtLaqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a3AFr8Lf68vB9ret9F/CZH0Sq9Bs6pdxsluAiTqFWBI=; b=H9jzBoqP1b+VG8djYhpt4k1vRusCFlElVHcHwOe+gY0C5HNKt+AYimJ+8Pwh29jHRY4igcEqzvK2K61yPKOt/hnhhvq8oUvD3Qm6adzoVdCduxTyzkXI/+F8Cdt7E76PG0H3AkY1QjGcyzbNrueuyZkdR7kgxV7ZPNwOVMuYvobm8ahhCzGhiiC6dPCohJMMcAPewuZoWrEfJUK/MC7V+hC8asqS56CKaiGiHlyXhIu9KGj+ZxeHuRSpekcZf1LZEG6qa/pD2U4yJYMI0QaeNQQ77ZA5TRQQFX/4ZBirwSvjO6Gz+CK7srlNoICT0BvMgveef2lVeeCOgLXI6YdN6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a3AFr8Lf68vB9ret9F/CZH0Sq9Bs6pdxsluAiTqFWBI=; b=v5+WEbXyoZOpqK6c6jJq/+DQBToh5mfswc8nzjeJ2CrWuyfNI+omVfJ8igUka6OJ8g5jRGQ4Q7nItXxCOb07VAG98wx6zWdNjChxElpcvRVAs9J4yYLscGxxzvziAr8588BkEBqdGOKS705B6eL4PD9o6XkzzFOwiNoRjTpIXm4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Wed, 23 Nov 2022 10:51:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN v3 12/12] xen/Arm: GICv3: Enable GICv3 for AArch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-13-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20221111141739.2872-13-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EA:EE_|CH2PR12MB4921:EE_ X-MS-Office365-Filtering-Correlation-Id: 756163dc-0db6-485e-2cac-08dacd384c62 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kq5URaEP1VD5puEP0LBHlyC40py7iyr6ZueXK1nYRDapJ6bKfi0buQUWE4nwTPgBS0NGx0WRmQzgsjRnPyxdESDy9HDSlFYzX1/gPzNFozPiqLCycam/O9MWrDRNdT3+y2iZzctgZIsmkxWciw7Dv7za8XTm2VlFGXpGe7H3e6mg3Tyae7u/qEbWeSUMr+cnWfPOv7Vg6uPjXUMQeSxhOFfzsXsjgwBdU9NAGkPoLzWuAbwZyUmWtYN67QuzmWQYayrF7H4MzLuWLr7UE/Iq5uIbq/vSZpPejdCLpDDQTD8a3iacLSNhjfZHDI2d2v0E6aAThi05lJZVjI5g/jK+6ERinv7oTr9b9TMM+/5UZ3zgYM9w/rhAezo0iBuklfz0wINgB6Tww5/nDfaMycPRTdgOyjGBGmoiEA+kge1lQzAzppPYqzG4cQTk7rlOxFPpOKsVD7XWNKQdeXnWrZ2OF+eIM9lfcRtvDvZ3XRQ7upCGlS7NI8YOWI8OlEkj/2eHk9BxO5ImZDZREGXjyx9OlWaM6JqGx2rW9fhmXSq/JV+9HHhahcnAOrwVXOZg+NZU59qHi7qKEalYszXcv6Tfns6KrtC1CWzGRd9QKyA6SqY+NZfivYCCdXuKh8ukFyxBwkx4OLwLLMiOuYKZ1aYBSyepMJWrQwwxMakYP4m7IfDJyCUetBtMVTs/DRtCG7DI8ftcVn4iigQRBp03XkomsOJRj5V3SOGWzIa0sNy16bySO1hPptk0TqdmDL+FLVX0Iz52IiQX4H9wbbxuEiRWeA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(376002)(396003)(451199015)(46966006)(36840700001)(40470700004)(2906002)(36860700001)(31686004)(2616005)(70586007)(70206006)(53546011)(41300700001)(36756003)(82310400005)(31696002)(86362001)(40480700001)(110136005)(83380400001)(356005)(54906003)(4326008)(426003)(82740400003)(81166007)(47076005)(8936002)(8676002)(6666004)(5660300002)(186003)(44832011)(16576012)(26005)(336012)(316002)(40460700003)(478600001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 09:51:30.8617 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 756163dc-0db6-485e-2cac-08dacd384c62 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000B8EA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4921 Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: > One can now use GICv3 on AArch32 systems. However, ITS is not supported. > The reason being currently we are trying to validate GICv3 on an AArch32_v8R > system. Refer ARM DDI 0568A.c ID110520, B1.3.1, > "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE must not > implement LPI support." > > By default GICv3 is disabled on AArch32 and enabled on AArch64. > > Updated SUPPORT.md to state that GICv3 on Arm32 is not security supported. > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel with one remark... > --- > > Changed from :- > v1 - 1. Remove "ARM_64 || ARM_32" as it is always true. > 2. Updated SUPPORT.md. > > v2 - 1. GICv3 is enabled by default only on ARM_64. > 2. Updated SUPPORT.md. > > SUPPORT.md | 7 +++++++ > xen/arch/arm/Kconfig | 9 +++++---- > xen/arch/arm/include/asm/cpufeature.h | 1 + > 3 files changed, 13 insertions(+), 4 deletions(-) > > diff --git a/SUPPORT.md b/SUPPORT.md > index ab71464cf6..3f16d83191 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -82,6 +82,13 @@ Extension to the GICv3 interrupt controller to support MSI. > > Status: Experimental > > +### ARM/GICv3 ... For me this section should go before the section ARM/GICv3 ITS. The reason being ITS is an extension and your section being generic should be listed before listing extension. ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 23 10:06:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 10:06:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447488.703752 (Exim 4.92) (envelope-from ) id 1oxmeA-0006Ni-Q8; Wed, 23 Nov 2022 10:06:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447488.703752; Wed, 23 Nov 2022 10:06:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmeA-0006Nb-NS; Wed, 23 Nov 2022 10:06:26 +0000 Received: by outflank-mailman (input) for mailman id 447488; Wed, 23 Nov 2022 10:06:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmeA-0006NV-0q for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 10:06:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxme8-00014b-5b; Wed, 23 Nov 2022 10:06:24 +0000 Received: from [54.239.6.185] (helo=[192.168.17.134]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxme7-0002gO-T7; Wed, 23 Nov 2022 10:06:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=7BuRn4gN86YI+c+d6nd7UfoXB0hglny3yAPYefRYuh4=; b=micD1/FT5PuxF8apwEegZh3LVG IsUNRA5gexT9bhsRN34wsvfHXyXnnNZZjTuyT3xKeujQUsQ/WsGVvan2xFwKx3PnLb4aqtpuVUdFd K4y5K4SHual2nXG9H10D4juO5Ms7wlu9UVgwqcvQ7NH0XZSxMc3lfdMzLeSeHqH5sv4Y=; Message-ID: Date: Wed, 23 Nov 2022 11:06:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v4 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , Stefano Stabellini , Bertrand Marquis , Community Manager References: <20221123040315.1480112-1-Henry.Wang@arm.com> <20221123040315.1480112-2-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20221123040315.1480112-2-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 23/11/2022 04:03, Henry Wang wrote: > Signed-off-by: Henry Wang Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 23 10:07:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 10:07:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447491.703762 (Exim 4.92) (envelope-from ) id 1oxmei-0006sh-2Z; Wed, 23 Nov 2022 10:07:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447491.703762; Wed, 23 Nov 2022 10:07:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmeh-0006sa-Vs; Wed, 23 Nov 2022 10:06:59 +0000 Received: by outflank-mailman (input) for mailman id 447491; Wed, 23 Nov 2022 10:06:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmeg-0006sS-Vf for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 10:06:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmed-00014y-EH; Wed, 23 Nov 2022 10:06:55 +0000 Received: from [54.239.6.185] (helo=[192.168.17.134]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxmed-0002i0-5u; Wed, 23 Nov 2022 10:06:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=+tmvheOjdVs1qwz7U4EmZ3qnnhXJHpO3V/cE6DYtZJE=; b=2hiPCf0q8oToAcXajNYS8c1zfH SBk64oDeqmloX2WsAcrlUMRFOaOKQFr7NHEZGsywPd/WVeE9u6+nw5GEcb2TQ1z2TKCnbWf/TZJ5g jhpXHu19Mlb+PH7JNsF2yWHz6Af/xBckFm7FDccUtSt/8rjtX9f59psfbASFNKtFfG2Y=; Message-ID: Date: Wed, 23 Nov 2022 11:06:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v4 2/3] Changelog: Add __ro_after_init and CET Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Community Manager References: <20221123040315.1480112-1-Henry.Wang@arm.com> <20221123040315.1480112-3-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20221123040315.1480112-3-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 23/11/2022 04:03, Henry Wang wrote: > From: Andrew Cooper > > Signed-off-by: Andrew Cooper > Signed-off-by: Henry Wang > Reviewed-by: Roger Pau Monné Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 23 10:07:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 10:07:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447494.703775 (Exim 4.92) (envelope-from ) id 1oxmfO-0007R3-DE; Wed, 23 Nov 2022 10:07:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447494.703775; Wed, 23 Nov 2022 10:07:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmfO-0007Qu-8X; Wed, 23 Nov 2022 10:07:42 +0000 Received: by outflank-mailman (input) for mailman id 447494; Wed, 23 Nov 2022 10:07:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmfM-0007Qi-P9 for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 10:07:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmfM-00015m-JZ; Wed, 23 Nov 2022 10:07:40 +0000 Received: from [54.239.6.185] (helo=[192.168.17.134]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxmfM-0002lU-CL; Wed, 23 Nov 2022 10:07:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=7BuRn4gN86YI+c+d6nd7UfoXB0hglny3yAPYefRYuh4=; b=Lp5YrTLLUcPUTFo4FdNuLGoPWH XUhW8De4f+4sj9ZfM5IopcWpKlUm/Czaa0uyxfEfvWCPB1qumnH6F4PgR5PaU7ZkcCSZOMbXa+9tq yIvoIWcmAjh4jz5GVPkr1ZHzMkOaCyj9AjGuL2wtCOFN09DYVfiABefi9js9Ro2xnX6c=; Message-ID: <6017d143-72b4-e6f0-14d9-332dbcade7c9@xen.org> Date: Wed, 23 Nov 2022 11:07:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v4 3/3] CHANGELOG: Start new "unstable" section Content-Language: en-US To: Henry Wang , xen-devel@lists.xenproject.org Cc: Jan Beulich , George Dunlap , Community Manager References: <20221123040315.1480112-1-Henry.Wang@arm.com> <20221123040315.1480112-4-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20221123040315.1480112-4-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 23/11/2022 04:03, Henry Wang wrote: > Signed-off-by: Henry Wang Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 23 10:14:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 10:14:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447500.703784 (Exim 4.92) (envelope-from ) id 1oxmlu-0000e2-2w; Wed, 23 Nov 2022 10:14:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447500.703784; Wed, 23 Nov 2022 10:14:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmlu-0000dv-0D; Wed, 23 Nov 2022 10:14:26 +0000 Received: by outflank-mailman (input) for mailman id 447500; Wed, 23 Nov 2022 10:14:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmls-0000dp-L7 for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 10:14:24 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20613.outbound.protection.outlook.com [2a01:111:f400:7eab::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 993568f2-6b17-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 11:14:23 +0100 (CET) Received: from DM6PR07CA0127.namprd07.prod.outlook.com (2603:10b6:5:330::28) by SA1PR12MB6895.namprd12.prod.outlook.com (2603:10b6:806:24e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 10:14:19 +0000 Received: from DM6NAM11FT115.eop-nam11.prod.protection.outlook.com (2603:10b6:5:330:cafe::ca) by DM6PR07CA0127.outlook.office365.com (2603:10b6:5:330::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15 via Frontend Transport; Wed, 23 Nov 2022 10:14:19 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT115.mail.protection.outlook.com (10.13.173.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Wed, 23 Nov 2022 10:14:19 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 23 Nov 2022 04:14:18 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 23 Nov 2022 04:14:07 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 23 Nov 2022 04:14:05 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 993568f2-6b17-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W1BE9fzVoy9XaCa88NdOoUaTW7FVehB/MxgNci7+VhnmA1vWlyPiEiL4biA9gkVgikRQEmZF0465H6Ruhd2X0diXjJEO2U15DErKrxtCuT+m/Z9YjQZueLoMSVvdvGhhI5eyWTzzvclAmBOypYOxSonItEO83YpS6R37UdD8mpvZx2nM6OU2gpcvgmizIc3eKUMMobwnvuO7+V6gmcbB6OGmfmdosoqVZWk8/PC7T3Xx4Egpsv1HH7S1mRD/PyobXpys6JxXE1dYIAiEZLPhMrwYEEKhsybN4atv5G7MlmVJNuf9hHgUQNLehol/6CHU8tVm85CgHooN9MXlB9oCFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R3kgZAqvvWTRbTmHnVDl2y358/unH8LQ7vS1FDMUYY4=; b=b4AkhCw2mNG2yoLYvyOYGNy8Y3J6HTtDi2eElMIMg6nr2dCVERExkvbkbMM9kA8rk3GIBZMZzjsJVR+U9Y1O57HRXxEEom89VeFyM9qGPeFSSoSfEG4Vr3FVOSekWp4sC9FTs0xidAqXkTRLi1ysoSdHNQU6i1wwOiuxtgs0THBkcyyp2899sy1bgtwTfn50fAHfQ9QFxuOWmCGy6ywimsYPWr25kqYL+wUJCBZmdmX/wlYSpRrifXOxDaoE3z2sxiC2elwrSoGUKGfke6/IUx4r1g75SMcEkkPndaR2coJzq02yfNgxLYe2fwQOtIid3XCp/jIGBngVoM8XJA7AQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R3kgZAqvvWTRbTmHnVDl2y358/unH8LQ7vS1FDMUYY4=; b=UzoBKCAYvuGe4BvADbteL9vKxOSUwrn5Tag4dvH4P3ZVr7i+fjnjnzf0l2yyarfuG+43eHskL0joXSTVS6Y/U24fRMhjTLa0UirOCncV/M39ph1L7IldT2qx/d2ThClkhgVrZLzAr7NjvO1cx+GwFVmKBv7451fHduuFlVonKJo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Wed, 23 Nov 2022 11:14:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v4 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Content-Language: en-US To: Henry Wang , CC: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , "Stefano Stabellini" , Julien Grall , "Bertrand Marquis" , Community Manager References: <20221123040315.1480112-1-Henry.Wang@arm.com> <20221123040315.1480112-2-Henry.Wang@arm.com> From: Michal Orzel In-Reply-To: <20221123040315.1480112-2-Henry.Wang@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT115:EE_|SA1PR12MB6895:EE_ X-MS-Office365-Filtering-Correlation-Id: 98232559-0720-40b4-6b64-08dacd3b7bdf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tWqF+TeVH1OQMQ8gLo4NTYsmUoNjY99YJiXFsC2HuYLaegSEIk2hXcwXeob+oK37LoVnKJNUVfeiu1GhgTRRkjB479bXgJeItoTrMV1dBDSUteDd2WipVM5gGBQ4a4I0A/evonlrHID0004eauZMFkZ7RVQ9BGH08kbuC1G9pdP2x2YWnDAb2aqQMO0ZrNCrMteO9ViLPpFkXLYCZY8u65M3hvtsAqtBSwEpUv5ivro6Zj3RVHEa1OK4QPyoPIoMiaguOhTaLqkQ0N3UKuxlfZB6Oy6pjzEaHs6JkFCDQ6IxLkxSQLJ/6ofJhnjRXXqUqmsHpaB1k6Ip4fnfZE3v37wipFBKuLdna92IaUmGCN5Lx9eMunvYWK9O/UTNzrBzkRjxEQ/gsXhUsI4xiPHHJP9C6cJfUL4CmmvwHlZrG+sEqmpbHfsfOBBspiCCcf+1pn+YfgGWVpnSTRoq0LqQIGiMgHdErLpVNhliVhEcvJRNtdEEBlMKy/aU4tX39uLeEzIV94Vp9Ij8HwNT2aZcbJvj66XLSwumT+Gq3I+M0U8UiJxaX4Djj3jxfZAQMdD9SpuWx0r6vXOupmKFW1RW8G9qVSREW27CKRb6TGSjhNjkMgUhh5EGPIVEKXT6P82b6WKqmMJIfjDjQ1tlK6wdBZdvo4g169nSWun9dsTS1mw+9fhaoIR6E8DDIzNuP95RcH0CxJPhGmOHGuR8TvOGpsBG96kbZhHd+UjSqo9l8WwsqviwiJdhrjHQMBB3GmMr3i2kNiXU7fVC+ittFrruSqcR2jk5/eY7Lj5Beub5G4KlK9r6Cue/KR0ga2g+OHmVQG2YmuK2M1+qahuvBMNPDXSuKpNjG9LGnpSRaGHp4DmnHijxKxviIU5/qQWZ7lSt X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199015)(40470700004)(36840700001)(46966006)(82740400003)(8936002)(356005)(81166007)(186003)(336012)(5660300002)(26005)(86362001)(40460700003)(110136005)(40480700001)(53546011)(54906003)(316002)(16576012)(2616005)(82310400005)(36756003)(31696002)(41300700001)(70206006)(8676002)(4326008)(70586007)(31686004)(47076005)(426003)(478600001)(83380400001)(2906002)(44832011)(36860700001)(59356011)(219803003)(207903002)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 10:14:19.0569 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 98232559-0720-40b4-6b64-08dacd3b7bdf X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT115.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6895 Hi Henry, On 23/11/2022 05:03, Henry Wang wrote: > > > Signed-off-by: Henry Wang > --- > v3 -> v4: > - Use the corrected sentence for VIRT_SSBD and MSR_SPEC_CTRL > - Clarify that the virtio-mmio toolstack for ARM is only creating the > device-tree binding. > - Remove the "initial" in i.MX entry. > v2 -> v3: > - Move the uncertain release date to patch #3. > v1 -> v2: > - Correct wording for two x86 entries (clock frequency calibration > and SPR & ADL support) following Jan's suggestion. > - Add missing Arm entries from Oleksandr. > - Add missing i.MX entry following Stefano's suggestion. > --- > CHANGELOG.md | 31 +++++++++++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index adbbb216fa..8fa8b198b3 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -4,16 +4,43 @@ Notable changes to Xen will be documented in this file. > > The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) > > -## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD > +## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) > > ### Changed > - On x86 "vga=current" can now be used together with GrUB2's gfxpayload setting. Note that > this requires use of "multiboot2" (and "module2") as the GrUB commands loading Xen. > + - The "gnttab" option now has a new command line sub-option for disabling the > + GNTTABOP_transfer functionality. > + - The x86 MCE command line option info is now updated. > > ### Added / support upgraded > + - Out-of-tree builds for the hypervisor now supported. > + - The project has officially adopted 4 directives and 24 rules of MISRA-C, > + added MISRA-C checker build integration, and defined how to document > + deviations. > - IOMMU superpage support on x86, affecting PV guests as well as HVM/PVH ones > when they don't share page tables with the CPU (HAP / EPT / NPT). > - - Support VIRT_SSBD feature for HVM guests on AMD. > + - Support for VIRT_SSBD and MSR_SPEC_CTRL for HVM guests on AMD. > + - Improved TSC, CPU, and APIC clock frequency calibration on x86. > + - Add mwait-idle support for SPR and ADL on x86. > + - Extend security support for hosts to 12 TiB of memory on x86. > + - Add command line option to set cpuid parameters for dom0 at boot time on x86. > + - Improved static configuration options on Arm. > + - cpupools can be specified at boot using device tree on Arm. > + - It is possible to use PV drivers with dom0less guests, allowing statically > + booted dom0less guests with PV devices. > + - On Arm, p2m structures are now allocated out of a pool of memory set aside at > + domain creation. > + - Improved mitigations against Spectre-BHB on Arm. > + - Support VirtIO-MMIO devices device-tree binding creation in toolstack on Arm. > + - Allow setting the number of CPUs to activate at runtime from command line > + option on Arm. > + - Grant-table support on Arm was improved and hardened by implementing > + "simplified M2P-like approach for the xenheap pages" > + - Add Renesas R-Car Gen4 IPMMU-VMSA support on Arm. > + - Add i.MX lpuart and i.MX8QM support on Arm. > + - Improved toolstack build system. > + - Add Xue - console over USB 3 Debug Capability. Looking at the "Added" section for the previous releases, we seem to mention the changes to CI (automation/) as well. Because there were quite a few changes done in this release, adding at least the following, can be beneficial (something to consider): - gitlab-ci automation: Fixes and improvements together with new tests > > ### Removed / support downgraded > - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options > -- > 2.25.1 > > ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 23 10:18:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 10:18:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447504.703795 (Exim 4.92) (envelope-from ) id 1oxmph-0001Fz-KC; Wed, 23 Nov 2022 10:18:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447504.703795; Wed, 23 Nov 2022 10:18:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmph-0001Fs-HB; Wed, 23 Nov 2022 10:18:21 +0000 Received: by outflank-mailman (input) for mailman id 447504; Wed, 23 Nov 2022 10:18:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxmpf-0001Fm-NZ for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 10:18:19 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 261b79ce-6b18-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 11:18:18 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C473C1F8BB; Wed, 23 Nov 2022 10:18:17 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9CF5C13AE7; Wed, 23 Nov 2022 10:18:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2TEJJWnzfWPHJwAAMHmgww (envelope-from ); Wed, 23 Nov 2022 10:18:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 261b79ce-6b18-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669198697; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iuSGZFuyZzeUEmumRiCxIHsb08pfKDky/5eomCPXUPE=; b=o+EgsLh8LX3pcIUJGxqg0KB8j41kRsFYMsilohL4JTKxpzKVgB4duFJFrdqTNpTI+RLeBR uJviCcxA7c4oX6kJK0CtGHR1aYxILJppysiqO07kUielJIH9HQKJ1MzoFKiCEcmIuCfjGZ MGPi01yma4UrJAoGUlT6BHgFSeEU/ZY= Message-ID: <1c96e05c-1f2f-bb0f-864d-6a247416e2bd@suse.com> Date: Wed, 23 Nov 2022 11:18:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: EFI's -mapbs option may cause Linux to panic() Content-Language: en-US To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <60663f81-09cd-e46b-bb94-1afe50519086@suse.com> <296f95d8-5506-c95d-1c14-915cbf3e4f30@suse.com> <7491ca33-291f-1dfe-6826-2a210a1d08ae@suse.com> From: Juergen Gross In-Reply-To: <7491ca33-291f-1dfe-6826-2a210a1d08ae@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ez0VEdPf9XymXnZJIQD02dFx" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ez0VEdPf9XymXnZJIQD02dFx Content-Type: multipart/mixed; boundary="------------ZfyUh4e93zmqQHU6hcgSrYP1"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Message-ID: <1c96e05c-1f2f-bb0f-864d-6a247416e2bd@suse.com> Subject: Re: EFI's -mapbs option may cause Linux to panic() References: <60663f81-09cd-e46b-bb94-1afe50519086@suse.com> <296f95d8-5506-c95d-1c14-915cbf3e4f30@suse.com> <7491ca33-291f-1dfe-6826-2a210a1d08ae@suse.com> In-Reply-To: <7491ca33-291f-1dfe-6826-2a210a1d08ae@suse.com> --------------ZfyUh4e93zmqQHU6hcgSrYP1 Content-Type: multipart/mixed; boundary="------------4sZHyZqM39qp0fxPWukRviJs" --------------4sZHyZqM39qp0fxPWukRviJs Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjMuMTEuMjIgMTA6MTgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyMy4xMS4yMDIy IDA4OjM5LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjIuMTEuMjIgMTA6NDcsIFJv Z2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4gT24gTW9uLCBOb3YgMjEsIDIwMjIgYXQgMDY6 MDE6MDBQTSArMDEwMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+IE9uIDIxLjExLjIwMjIg MTc6NDgsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+Pj4+PiBPbiBNb24sIE5vdiAyMSwg MjAyMiBhdCAwNToyNzoxNlBNICswMTAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+PiBI ZWxsbywNCj4+Pj4+Pg0KPj4+Pj4+IG9uIGEgc3lzdGVtIHdpdGggdGhlc2UgZmlyc3QgdHdv IEVGSSBtZW1vcnkgbWFwIGVudHJpZXMNCj4+Pj4+Pg0KPj4+Pj4+IChYRU4pICAwMDAwMDAw MDAwMDAwLTAwMDAwMDAwOWRmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZg0KPj4+ Pj4+IChYRU4pICAwMDAwMDAwMDllMDAwLTAwMDAwMDAwOWZmZmYgdHlwZT0yIGF0dHI9MDAw MDAwMDAwMDAwMDAwZg0KPj4+Pj4+DQo+Pj4+Pj4gaS5lLiBleGNlcHQgZm9yIDIgcGFnZXMg YWxsIHNwYWNlIGJlbG93IDFNIGJlaW5nIEJvb3RTZXJ2aWNlc0RhdGEsIHRoZQ0KPj4+Pj4+ IC1tYXBicyBvcHRpb24gaGFzIHRoZSBlZmZlY3Qgb2YgbWFya2luZyByZXNlcnZlZCBhbGwg dGhhdCBzcGFjZS4gVGhlbg0KPj4+Pj4+IExpbnV4IGZhaWxzIHRyeWluZyB0byBhbGxvY2F0 ZSBpdHMgbG93bWVtIHRyYW1wb2xpbmUgKHdoaWNoIHJlYWxseSBpdA0KPj4+Pj4+IHNob3Vs ZG4ndCBuZWVkIHdoZW4gcnVubmluZyBpbiBQViBtb2RlKSwgdWx0aW1hdGVseSBsZWFkaW5n IHRvDQo+Pj4+Pj4NCj4+Pj4+PiAJCXBhbmljKCJSZWFsIG1vZGUgdHJhbXBvbGluZSB3YXMg bm90IGFsbG9jYXRlZCIpOw0KPj4+Pj4+DQo+Pj4+Pj4gaW4gdGhlaXIgaW5pdF9yZWFsX21v ZGUoKS4NCj4+Pj4+Pg0KPj4+Pj4+IFdoaWxlIGZvciBQViBJIHRoaW5rIGl0IGlzIGNsZWFy IHRoYXQgdGhlIGVhc2llc3QgaXMgdG8gYXZvaWQNCj4+Pj4+PiB0cmFtcG9saW5lIHNldHVw IGluIHRoZSBmaXJzdCBwbGFjZSwgaWlyYyBQVkggRG9tMCBhbHNvIHRyaWVzIHRvDQo+Pj4+ Pj4gbWlycm9yIHRoZSBob3N0IG1lbW9yeSBtYXAgdG8gaXRzIG93biBhZGRyZXNzIHNwYWNl LiBEb2VzIFBWSCBMaW51eA0KPj4+Pj4+IHJlcXVpcmUgYSBsb3dtZW0gdHJhbXBvbGluZT8N Cj4+Pj4+DQo+Pj4+PiBZZXMsIGl0IGRvZXMgQUZBSUsuICBJIGd1ZXNzIHRob3NlIHR3byBw YWdlcyB3b24ndCBiZSBlbm91Z2ggZm9yDQo+Pj4+PiBMaW51eCBib290IHRyYW1wb2xpbmUg cmVxdWlyZW1lbnRzIHRoZW4uDQo+Pj4+Pg0KPj4+Pj4gSSBhc3N1bWUgbmF0aXZlIExpbnV4 IGlzIGZpbmUgd2l0aCB0aGlzIG1lbW9yeSBtYXAgYmVjYXVzZSBpdCByZWNsYWltcw0KPj4+ Pj4gdGhlIEVmaUJvb3RTZXJ2aWNlc0RhdGEgcmVnaW9uIGFuZCB0aGF0J3MgZW5vdWdoLg0K Pj4+Pg0KPj4+PiBUaGF0J3MgbXkgdW5kZXJzdGFuZGluZyBhcyB3ZWxsLg0KPj4+Pg0KPj4+ Pj4+IFdoaWxlIHRoZSB0d28gcGFnZXMgaGVyZSBhcmUganVzdCBlbm91Z2ggZm9yIFhlbidz IHRyYW1wb2xpbmUsIEkgc3RpbGwNCj4+Pj4+PiB3b25kZXIgd2hldGhlciB3ZSB3YW50IHRv IGFkanVzdCAtbWFwYnMgYmVoYXZpb3IuIFNpbmNlIHdoYXRldmVyIHdlDQo+Pj4+Pj4gbWln aHQgZG8gbGVhdmVzIGEgcmlzayBvZiBjb25mbGljdGluZyB3aXRoIHRydWUgZmlybXdhcmUg KG1pcyl1c2Ugb2YNCj4+Pj4+PiB0aGF0IHNwYWNlLCB0aGUgYmVzdCBJIGNhbiB0aGluayBv ZiByaWdodCBub3cgd291bGQgYmUgYW5vdGhlciBvcHRpb24NCj4+Pj4+PiBhbHRlcmluZyBi ZWhhdmlvciAob3IgcHJvdmlkaW5nIGFsdGVyZWQgYmVoYXZpb3IpLiBZZXQgc3VjaCBhbiBv cHRpb24NCj4+Pj4+PiB3b3VsZCBsaWtlbHkgbmVlZCB0byBiZSBtb3JlIGZpbmUtZ3JhaW5l ZCB0aGVuIHRoYW4gY292ZXJpbmcgYWxsIG9mDQo+Pj4+Pj4gdGhlIGxvdyBNYiBpbiBvbmUg Z28uIFdoaWNoIGZlZWxzIGxpa2UgYm90aCBnb2luZyB0b28gZmFyIGFuZCBtYWtpbmcNCj4+ Pj4+PiBpdCBhd2t3YXJkIGZvciBwZW9wbGUgdG8gZmlndXJlIG91dCB3aGF0IHZhbHVlKHMp IHRvIHVzZSAuLi4NCj4+Pj4+Pg0KPj4+Pj4+IFRob3VnaHRzIGFueW9uZT8NCj4+Pj4+DQo+ Pj4+PiBJJ20gdW5zdXJlIHdoYXQgdG8gcmVjb21tZW5kLiAgVGhlIG1hcGJzIG9wdGlvbiBp cyBhIHdvcmthcm91bmQgZm9yDQo+Pj4+PiBicm9rZW4gZmlybXdhcmUsIGFuZCBpdCdzIG5v dCBlbmFibGVkIGJ5IGRlZmF1bHQsIHNvIHdlIG1pZ2h0IGJlIGx1Y2t5DQo+Pj4+PiBhbmQg bmV2ZXIgZmluZCBhIHN5c3RlbSB3aXRoIGEgbWVtb3J5IG1hcCBsaWtlIHlvdSBkZXNjcmli ZSB0aGF0IGFsc28NCj4+Pj4+IHJlcXVpcmVzIG1hcGJzIGluIG9yZGVyIHRvIGJvb3QuDQo+ Pj4+DQo+Pj4+IEd1ZXNzIGhvdyB3ZSd2ZSBsZWFybmVkIG9mIHRoZSBpc3N1ZTogU3lzdGVt cyBtYXkgYm9vdCBmaW5lIHdpdGhvdXQNCj4+Pj4gLW1hcGJzLCBidXQgdGhleSBtYXkgZmFp bCB0byByZWJvb3QgYmVjYXVzZSBvZiB0aGF0IChpbilmYW1vdXMgaXNzdWUgb2YNCj4+Pj4g ZmlybXdhcmUgd3JpdGVycyBub3QgcHJvcGVybHkgc2VwYXJhdGluZyBib290IHNlcnZpY2Vz IGNvZGUgcGF0aHMgZnJvbQ0KPj4+PiBydW50aW1lIHNlcnZpY2VzIG9uZXMuIEFuZCB0aGVy ZSB3ZSdyZSBkZWFsaW5nIHdpdGggYSBzeXN0ZW0gd2hlcmUgSQ0KPj4+PiBzdXNwZWN0IHRo aXMgdG8gYmUgdGhlIGNhc2UsIGp1c3QgdGhhdCAtIHVubGlrZSBpbiBlYXJsaWVyIHNpbWls YXINCj4+Pj4gY2FzZXMgLSB0aGVyZSdzIG5vICJjbGVhbiIgY3Jhc2ggcHJvdmluZyB0aGUg aXNzdWUgKHRoZSBzeXN0ZW0gc2ltcGx5DQo+Pj4+IGhhbmdzKS4gSGVuY2UgbXkgcmVxdWVz dCB0aGF0IHRoZXkgdXNlIC1tYXBicyB0byB0cnkgdG8gZmlndXJlIG91dC4NCj4+Pj4NCj4+ Pj4gQW5kIHllcywgInJlYm9vdD1hY3BpIiBoZWxwcyB0aGVyZSwgYnV0IHRoZXkgaW5zaXN0 IG9uIGtub3dpbmcgd2hhdA0KPj4+PiBjb21wb25lbnQgaXMgdG8gYmxhbWUuDQo+Pj4NCj4+ PiBXZWxsLCBpZiByZWJvb3Q9YWNwaSBmaXhlcyBpdCB0aGVuIGl0J3MgcXVpdGUgY2xlYXIg RUZJIHJlYm9vdCBtZXRob2QNCj4+PiBpcyB0byBibGFtZT8NCj4+Pg0KPj4+IE9yIHRoZXkg d2FudCB0byBrbm93IHRoZSBleGFjdCBjYXVzZSB0aGF0IG1ha2VzIEVGSSByZWJvb3QgZmFp bCwNCj4+PiBiZWNhdXNlIHRoYXQncyBxdWl0ZSBkaWZmaWN1bHQgdG8gZmlndXJlIG91dCBm cm9tIG91ciBlbmQuDQo+Pj4NCj4+PiBCdXQgSSdtIGFmcmFpZCBJIGRvbid0IHNlZSBhbnkg c29sdXRpb24gdG8gbWFrZSBtYXBicyB3b3JrIHdpdGggYSBQVkgNCj4+PiBkb20wIG9uIGEg c3lzdGVtIHdpdGggYSBtZW1vcnkgbWFwIGxpa2UgeW91IHByb3ZpZGVkLCBzaG9ydCBvZiBh ZGRpbmcNCj4+PiBzb21lIGtpbmQgb2YgYm9kZ2UgdG8gbm90IG1hcCBhbmQgbWFyayBhcyBy ZXNlcnZlZCBtZW1vcnkgYmVsb3cgMU1CDQo+Pj4gKGJ1dCB0aGF0IGtpbmQgb2YgZGVmZWF0 cyB0aGUgcHVycG9zZSBvZiBtYXBicykuDQo+Pg0KPj4gV2hhdCB3ZSBjb3VsZCBkbyBpbiBz dWNoIGEgY2FzZSB3b3VsZCBiZSB0byBpbmhpYml0IHN1c3BlbmRpbmcgdGhlDQo+PiBzeXN0 ZW0sIGFuZCB0byBydW4gZG9tMCB3aXRoIGEgc2luZ2xlIGNwdSBvbmx5LiBBbiBlcnJvciBt ZXNzYWdlDQo+PiBpbmRpY2F0aW5nIHRoYXQgdGhlIHN5c3RlbSBzaG91bGQgYmUgYm9vdGVk IHdpdGhvdXQgbWFwYnMgc2hvdWxkIGJlDQo+PiBpc3N1ZWQsIG9mIGNvdXJzZS4NCj4gDQo+ IFRoYXQncyBnb2luZyB0byBiZSBhd2t3YXJkOiBMaW51eCBjYW4ndCB2ZXJ5IHdlbGwgaXNz dWUgYSBtZXNzYWdlDQo+IHN1Z2dlc3RpbmcgdG8gcmVtb3ZlIHRoZSB1c2Ugb2YgYSBoeXBl cnZpc29yIG9wdGlvbiAoYmVoYXZpb3Igb2Ygd2hpY2gNCj4gaXMgYW4gaW1wbGVtZW50YXRp b24gZGV0YWlsIHRvIHNvbWUgZGVncmVlLCBhbmQgaGVuY2UgdGhlIG1lc3NhZ2UNCj4gY291 bGQgZW5kIHVwIGJlaW5nIG1pc2xlYWRpbmcgbGF0ZXIpLiBYZW4gYWxzbyBjYW4ndCB2ZXJ5 IHdlbGwgaXNzdWUNCj4gc3VjaCBhIG1lc3NhZ2UsIHNpbmNlIGl0IGRvZXNuJ3Qga25vdyBo b3cgbXVjaCBvZiBsb3dtZW0gaXMgZ29pbmcgdG8NCj4gYmUgZW5vdWdoIGZvciB3aGljaGV2 ZXIgRG9tMCBPUyB0aGVyZSdzIGdvaW5nIHRvIGJlIGJvb3RlZC4gSW4NCj4gcHJpbmNpcGxl IGFuIE9TIG1heSBnZXQgYXdheSB3aXRoIGxlc3MgdGhhbiBhIHNpbmdsZSBwYWdlLiBIZW5j ZSBYZW4NCj4gYXQgYmVzdCBjb3VsZCBpc3N1ZSBhICJtYXkgbm90IHdvcmsiIG1lc3NhZ2Ug KHVubGVzcyBubyBzcGFjZSBhdCBhbGwNCj4gd2FzIGF2YWlsYWJsZSBhdCBzb21lIDRrLWFs aWduZWQgYm91bmRhcnkpLCBhbmQgZXZlbiB0aGVuIGl0IGJlaW5nIGENCj4gZmFsc2UgaW5k aWNhdGlvbiBvbiBzb21lIChtYW55Pykgc3lzdGVtcyBtYXkgbGVhZCB0byBwZW9wbGUgbm90 IHBheWluZw0KPiBhdHRlbnRpb24gd2hlbiB0aGV5IHNob3VsZC4NCg0KQSBrZXJuZWwgbWVz c2FnZSBjb3VsZCBiZSBwaHJhc2VkIG1vcmUgZ2VuZXJpYywgZS5nLiAiQ291bGRuJ3QgZmlu ZCBhDQpsYXJnZSBlbm91Z2ggZnJlZSBtZW1vcnkgcmVnaW9uIGJlbG93IDFNQiwgbWF5YmUg ZHVlIHRvIGh5cGVydmlzb3INCnNldHRpbmdzIGFuZC9vciBmaXJtd2FyZSBpc3N1ZXMuIg0K DQoNCkp1ZXJnZW4NCg0K --------------4sZHyZqM39qp0fxPWukRviJs Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------4sZHyZqM39qp0fxPWukRviJs-- --------------ZfyUh4e93zmqQHU6hcgSrYP1-- --------------ez0VEdPf9XymXnZJIQD02dFx Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmN982kFAwAAAAAACgkQsN6d1ii/Ey+I +Af8COVoVWLZi5kwaGlDIykPU0lhbCP3H0tKLPpTJzQkKtb0dotqb9FWvZk36s5R04dNdKwH9LTa E2ubhFpTXq91Yx9g+DTUyr2Ei7F6vS2Hq6QmZ2uJbRU0N2fTbAotvoavAYmaX9Rcc0bRS7urnJxV 8e87rM7hvjJd3nLcV2s52MmaBHSrleaCZk4+w5zpC1Lyafud+4jvE1+EjxIDyL3pSfy/+Y8hK7sy GxB79dID/xpXLuqh0v8u+5quu5sQvSO1uPhlOFtfFD2aIfoOhR8jTxe6/m37sr459dTIGSkiKz86 93RMKHRg8OuqqqmkcM7NBxlHvxpZmO6ROXLva7PDOg== =J5Fh -----END PGP SIGNATURE----- --------------ez0VEdPf9XymXnZJIQD02dFx-- From xen-devel-bounces@lists.xenproject.org Wed Nov 23 10:47:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 10:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447510.703807 (Exim 4.92) (envelope-from ) id 1oxnHU-0004yA-2k; Wed, 23 Nov 2022 10:47:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447510.703807; Wed, 23 Nov 2022 10:47:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxnHT-0004y3-W7; Wed, 23 Nov 2022 10:47:03 +0000 Received: by outflank-mailman (input) for mailman id 447510; Wed, 23 Nov 2022 10:47:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxnHS-0004xx-GA for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 10:47:02 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2061c.outbound.protection.outlook.com [2a01:111:f400:7d00::61c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 27bcea85-6b1c-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 11:46:59 +0100 (CET) Received: from AM5PR0701CA0060.eurprd07.prod.outlook.com (2603:10a6:203:2::22) by AS2PR08MB8748.eurprd08.prod.outlook.com (2603:10a6:20b:544::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 10:46:50 +0000 Received: from AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::55) by AM5PR0701CA0060.outlook.office365.com (2603:10a6:203:2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17 via Frontend Transport; Wed, 23 Nov 2022 10:46:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT036.mail.protection.outlook.com (100.127.140.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17 via Frontend Transport; Wed, 23 Nov 2022 10:46:50 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Wed, 23 Nov 2022 10:46:50 +0000 Received: from c253a38cd7f0.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C73843E8-59A7-4CED-824C-488B3227743A.1; Wed, 23 Nov 2022 10:46:39 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c253a38cd7f0.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 23 Nov 2022 10:46:39 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB6613.eurprd08.prod.outlook.com (2603:10a6:20b:339::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 10:46:37 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1245:e53:a5ec:66fd%9]) with mapi id 15.20.5857.017; Wed, 23 Nov 2022 10:46:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27bcea85-6b1c-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GEqCmYSCnQ1oMkpH2WVLfxgYngOP2DPsuVZsmVS7yIY=; b=MT8vQchGT9GkeNg8qR7BdcKkOo/jDPPtpc6/vT/59CDQFnJaGlZ/OELUcBjBkRN9M5V+4LhHpFYuoHxxw/JJVD+KmGffapfrSlnAhNmqMaxFH8MYx5ctF4WjfhKbmCf2UmrqY62IlqPXv7n+JNRVlXhdOsvTn0gouFwc2pURsmc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kyN/LO+JYo6cwEn5IdXSpQ6NnpVQs93NLW1xBjcqoA7ne6f2dehXqT3q9eEnUmyIqPikC8yF8yz3X0/9Wvniq2xayzRvBufD7llP0Mp6XkwWocul4KHWWYRzJTkdoB2YN7WzzizjUlFHBhNwJ5LtBzUZNDLScyPXJfDd67j+t0AUb9MXNHmJDiua3o1l4xksv6fO1tVd63Xr0pSdWCDf6QxvhKzxdpH8mQmh1vwY6KPah7C2ge2rUJjb9Cg/JFiQGUwqcdjKNRYo9tn7GQZwPsYPt/7mZ3jm6bpE+Gt8HLu3uOpZvxyROy6kUL4zqeGG2njtbdUJWC8yWshr/fTODw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GEqCmYSCnQ1oMkpH2WVLfxgYngOP2DPsuVZsmVS7yIY=; b=AGNpWGIoOABT1OFdSLsMtxDyobkgMkkpfiuosJRG/5j972GjRd913/wf+wVdXJH7IEol0w5lAv2I5uhVhrMlaigm963EyeWT6OSQJ/rQ9KXY0+EXRZnfX3tbH3iMHPUBr42CKrMAuhQa/tTHhLZcorQiF03RbCFipFQO+z8cLiXHNxHxLc1HAnRczoLa5EkWQQC23ZtoJ40ukk4Vt5WYyg19TRKlFPD9whuAfpDrnMeYyCzG7qtEV1Ye+QFe4SPB4kDZY8K2gRAlY9wMm30CioMJPZonhV0RsxpNc71hjM3yfW4JIe6SW1AgjJgmYjebyFPzci+HUMa/TAH+JpzYZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GEqCmYSCnQ1oMkpH2WVLfxgYngOP2DPsuVZsmVS7yIY=; b=MT8vQchGT9GkeNg8qR7BdcKkOo/jDPPtpc6/vT/59CDQFnJaGlZ/OELUcBjBkRN9M5V+4LhHpFYuoHxxw/JJVD+KmGffapfrSlnAhNmqMaxFH8MYx5ctF4WjfhKbmCf2UmrqY62IlqPXv7n+JNRVlXhdOsvTn0gouFwc2pURsmc= From: Henry Wang To: Michal Orzel , "xen-devel@lists.xenproject.org" CC: Jan Beulich , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Andrew Cooper , Stefano Stabellini , Julien Grall , Bertrand Marquis , Community Manager Subject: RE: [PATCH v4 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Thread-Topic: [PATCH v4 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Thread-Index: AQHY/vCVM9giSFNS50+Elg9BVMdHfK5MSsCAgAAIIXA= Date: Wed, 23 Nov 2022 10:46:37 +0000 Message-ID: References: <20221123040315.1480112-1-Henry.Wang@arm.com> <20221123040315.1480112-2-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 21EF96A1BA72694AAC7E4080E99D1C42.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB6613:EE_|AM7EUR03FT036:EE_|AS2PR08MB8748:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c35ca6b-a65f-4b7e-754e-08dacd4006d7 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: E+c5j4hJ/K8vm5yoewzr3KrOGDq1n1TR/ljXLxNEgux8hYSHFDQnZGMnuru9kyojO5LFuDJ0y8/o4x6liVEjxT9I3y9OtDIqlrWSPhkzk0ZS3+2s+MlTNN7m5Q8D7jzmcnH4gzwH3tksmiu/0UGKGkjzbfcq1A7OTn8R61+ju3AhEDeZYCusEsT6AgOd1flBvGrVy8b3oxEY+LELvcnThrTJoBThXCv1HQ82AobesDHx4S6xjESbERH9uEIxWccLWPVqYiKAeofKDkWJ5pwFivOqP6jNRaDMNjWv57PJqEPv9fRlU8GZy2qvVeDFsCUgT7GAAB7uln/yLUlDb9pxDAzPDJw7ks11UtFwkMUipUqPBYpOOOXG2cgSXDZT9UnN2a9Vssakp8SHi2UlxG4Id1H7STR3ubcFkJVUh6Q01h7lUT6JCaT46vf/jOWOsNbYJNefr9p2lbFAy83IBURU3vd8rN8XqgAr7HShM+MhJaAm2ltWaGq61VV5PIqTQ2z4fGdE2oeQZ+BnmXRZxa3rXYFj6NHvCHYPnzTzcIiOxgsyMQ5s70fQmpl5JNQhOyC9YORHK/knCI/oHfoZVm8YEM9zJmXvh2pS8TqrdzCgbQS46oB7X7MUudX/AmZDcK1vkdDicnEWoScI2gf5qJTT+j1oEcNwFHqcaoqyXwolquGPLlksoiK5roHfCBc1wscwWq6v6ksmgAEmggBtb4OE2meHL+V1+ra6sA0xN/cnugz8uSNbjd7EwdTafsY0qRFfh6Eqm8sv2LOuaGaXRnA89SVCYf4ep5bO/v5N8YglCSU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(451199015)(2906002)(33656002)(4744005)(55016003)(76116006)(66946007)(41300700001)(86362001)(66556008)(38070700005)(52536014)(66446008)(122000001)(110136005)(7696005)(83380400001)(54906003)(38100700002)(4326008)(6506007)(8936002)(8676002)(64756008)(9686003)(5660300002)(66476007)(186003)(26005)(71200400001)(316002)(478600001)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6613 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6b7a78e2-86e4-4130-2059-08dacd3fff59 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2xPTZFrEOOVzgmJvNmfyQ0zTRBDj9P6rPNHvFgg3js8aBqLjr5cAcy08VF9Y63p6avc8bwmjYvNuT8cs13YRZb4KTZkP32NcpPRqzKk/dsFUkIMBiccizhGQxSv/ifJITR0U6bDe65itV+rLj8c8Gk6QO/RHYEHV4iBy7ehdyv6+BfZTzMsYpzfsWDnu5Hr4fFgv2Y0vHO/343DWxrkNm6MPPzBaN40T+z4CKobbp1s0c3q75R1CSbVDBvZ2Q8m9qwkiPn31WlhIRv0bcsJm+MfTppxWyvBNaks6ilemswCqFZFHGr/vgcGPE5vMcveLaOtU9cV/mXGw4aJMWCkZwAwrwIqLh1U7aUqBZvwQIX3NYieLLcIzFDxvPHKR0bjRQlbRP9qxWLcDxGkZuctuuy1crWxbaSq7XWioueQVJt0BewHiVPjJaWGd0LvwgN7QVO8bR3cGt5ZLgUMwgJhRJs1d58N0reYtOYwa6Ur3tbAtGwVkgxnh3uuzlEFitmMmoIICN4/sIS0jGldeUhIana+V3Fb3fXrdRLfX7rbGxEEBHkHrPBpjBzICO2mxybnXyQUtmLZl4APyeTg50iqmkEVR1Gw/5vBgG+QajadwO7UjiBO7KRXybqoYhjCZDJXUpY+StLioWnqNPnKf62yy4AT2zcQZ6YNAS6UDgQGLlSv7VysJs2FgPxz20ZALAGH/wUoB9dCeYe/2pWHfMULGP5/oWD1UAMVg2CrAjx0ZSjiLrrjqEcwm+sIQi5fjI7eo0pKKKjOIxuthYe6D/2T47JO00D46W26zlRU3IM7IlaM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199015)(46966006)(40470700004)(36840700001)(2906002)(81166007)(55016003)(356005)(82740400003)(40480700001)(36860700001)(33656002)(9686003)(7696005)(82310400005)(478600001)(8936002)(83380400001)(41300700001)(6506007)(40460700003)(5660300002)(52536014)(4744005)(86362001)(186003)(26005)(336012)(47076005)(8676002)(110136005)(54906003)(316002)(4326008)(70586007)(70206006)(59356011)(207903002)(219803003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 10:46:50.2262 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c35ca6b-a65f-4b7e-754e-08dacd4006d7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8748 SGkgTWljaGFsLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFJl OiBbUEFUQ0ggdjQgMS8zXSBDSEFOR0VMT0c6IEFkZCBtaXNzaW5nIGVudHJpZXMgZm9yIHdvcmsg ZHVyaW5nDQo+IHRoZSA0LjE3IHJlbGVhc2UNCj4gSGkgSGVucnksDQo+IExvb2tpbmcgYXQgdGhl ICJBZGRlZCIgc2VjdGlvbiBmb3IgdGhlIHByZXZpb3VzIHJlbGVhc2VzLCB3ZSBzZWVtIHRvDQo+ IG1lbnRpb24gdGhlIGNoYW5nZXMgdG8gQ0kgKGF1dG9tYXRpb24vKSBhcyB3ZWxsLg0KPiBCZWNh dXNlIHRoZXJlIHdlcmUgcXVpdGUgYSBmZXcgY2hhbmdlcyBkb25lIGluIHRoaXMgcmVsZWFzZSwg YWRkaW5nIGF0IGxlYXN0DQo+IHRoZSBmb2xsb3dpbmcsIGNhbiBiZSBiZW5lZmljaWFsIChzb21l dGhpbmcgdG8gY29uc2lkZXIpOg0KPiAtIGdpdGxhYi1jaSBhdXRvbWF0aW9uOiBGaXhlcyBhbmQg aW1wcm92ZW1lbnRzIHRvZ2V0aGVyIHdpdGggbmV3IHRlc3RzDQoNCkkgb25seSBzYXcgQ0kgZW50 cmllcyBpbiA0LjE1IHJlbGVhc2UsIGJ1dCBpZiB5b3Ugd2FudCB0byBhZGQgdGhpcyBJIGFtIG9r IHdpdGggdGhhdC4NClNvIEkgd2lsbCB3YWl0IGZvciBhIGRheSB0byBzZWUgaWYgcGVvcGxlIG9w cG9zZSB0aGlzLCBpZiBub3QgSSB3aWxsIGFkZCB5b3VyIHN1Z2dlc3RlZA0Kc2VudGVuY2UgaW4g djUuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 23 10:52:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 10:52:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447514.703818 (Exim 4.92) (envelope-from ) id 1oxnMa-0006VY-MO; Wed, 23 Nov 2022 10:52:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447514.703818; Wed, 23 Nov 2022 10:52:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxnMa-0006VR-JX; Wed, 23 Nov 2022 10:52:20 +0000 Received: by outflank-mailman (input) for mailman id 447514; Wed, 23 Nov 2022 10:52:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxnMZ-0006VL-18 for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 10:52:19 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e328eaac-6b1c-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 11:52:15 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Nov 2022 05:52:11 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB6142.namprd03.prod.outlook.com (2603:10b6:5:395::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Wed, 23 Nov 2022 10:52:09 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5857.018; Wed, 23 Nov 2022 10:52:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e328eaac-6b1c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669200735; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=IGXRa8X25n4XL4b0elOIM5eE8xWKepBBYafXDXSc+bE=; b=GyzmXwgPnbULdIhORiez6xy89/SwGN4WpfF9g0xjmdcO/tejNueMYpmi ExuUVO7N+aBNDP8VkdYxsC9TBqKkSJ5feeOuac3vzMAOYDLpvoZINqDir 9BNF8CubEU2Hb6TwpbDHJ8GCendm18E5aoFpR8Vufn6LKzLHBycJCRtMr w=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 85405011 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:IibV3KtNRpwUFe2BevLldCvWf+fnVBNeMUV32f8akzHdYApBsoF/q tZmKWrUbPjYZWf9f9okO47koE8EvJPTztVgHAI/r380FyMa+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaEzCFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwKzNXSBy9nuyP5I3jRONDuetkCdS1FdZK0p1g5Wmx4fcOZ7nmGvyPz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgP60bou9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPO3lqqY32ATKroAVICQOcVGKqvzisROBCpUDE Ggp1A8okIFnoSRHSfG4BXVUukWsphMAVsBCO+w85huExqfd70CeHGdsZjxZb90jvsg7bT8nz FmEm5XuHzMHmKWcVHaY/bS8rj6oPyURa2gYakcsVgUfy9Lqpot1hw/SQZBkCqHzh8CdMTXxx S2a6SsznbMeieYV2Kihu1PKmTShot7OVAFdzgfYRGW+9StieZWoIYev7DDz9u1cJYyUSl2Au nksmMWE6u0KS5aXm0SlSuIXHarv4O2ZKjrCml1+N547/j+p9jioeoU4yCFzIgJlP9gJfRftY VTPokVB6ZlLJnyoYKRrJYWrBKwXIbPIEN3kUrXeaIpIa50oLQufpngwNAiXwnznl1UqnecnI 5CHfM2wDHEcT6N60D6xQORb2rgurswj+V7uqVnA50zP+dKjiLS9E9/p7HPmgjgF0Z65 IronPort-HdrOrdr: A9a23:f7eyU67gZgQBaNMp4APXweCCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpixBiSgSiu4LvaFQHd+hsFSTtAzZor7G CAymXCl+SemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQBiTwhh2ubIFBXaTHmDwuuumg5Hsjjd GJiRY9OMZY7W/XYwiO0FXQ8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMk5 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvvn+9Ua1wWR4S2rpXV9 WGP/usosq+tmnqNkwxi1MfhOBEmE5DRituDHJy4fB9mAIm4UyRh3FouPD32E1wtK7VAqM0md gteM5T5c5zZ95TYqRnCOgbR8yrTmTLXBLXKWqXZU/qDacdJhv22tfKCZgOlZaXkaYzve0PsY WEVEkduX85ekroB8HL1JpX8grVSGH4WTj20MlR65Vwp7W5HdPQQGa+YUFrl9Hlr+QUA8XdVf r2MJVKA+X7JW+rHYpSxQXxV5RbNHFbWswIvdQwXU6Iv6vwW8XXn/2edOyWKKvmED4iVG+6Cn wfXCLrLMEF9UyvUm+QummkZ5osQD2LwXtdKtmowwFI8vl9CmRliHlktX2poseWNDZFrqs6OE NjPbKPqNLImVWL X-IronPort-AV: E=Sophos;i="5.96,187,1665460800"; d="scan'208";a="85405011" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IiR8x7jtux8s5yTJhIdE69sC+31LaR+XIAtEfYod+c0ChD1rNQGb2Y6WX/kLWARIE7sHRLDeuHyNaevec+xLkcGiHkN8eR5YK+7F4ySuSM8ccVVUUNWMh1dyAQADByUiAs+1f5jczHkg045Op86DgSescAUROTau8XV6KHcvwlFqdnQVJ73PWGcNEyK0k38Ulemx5Uev07XkrXsSBv7WkYlVrzcrhRwd/uoNNdAiJ8edX90G57A5S+eucz7WUt2TkPwwpxI2I7sYohEfmgMz2VD8DP5DdOGwfK4IqLUx4MGpP67a1DGSFI1E9NF9g9GcLHPH6Se+epVy6UKI84k7zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IGXRa8X25n4XL4b0elOIM5eE8xWKepBBYafXDXSc+bE=; b=i4EdGBPzFKWdho6FqLe8gY+JC+wz7vtuA312zmJZ3v1BpKuwDpoUPrWg9A4dqEU+prr5hlXRT7gEPPf5V5VmCKOsyK54t/Jklkwz2knSz2p4nR+8iYtMYhJ36nPgfw8KfDlmKTWVi72VP0HYFeXIiWMujx9SKpKpxH9RvnyA1ad8cIFOm96fBqqYKHKnXk779s3JnHWwqyy0+Nqart+VR21/qz9YTw8202qSINSMxkk6AnsOwvO7TLlXC9PKHHNb0H88yhlrubxgIMtxvFM6i+qICr0ksZH1+mvcBLdNGu4kmypMb+4m4q8HnLUbGCkZa29DoeuPwzIHLXcD945y5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IGXRa8X25n4XL4b0elOIM5eE8xWKepBBYafXDXSc+bE=; b=A5tvfmKLbcEGDwb39tqAEJtCfEbLNP35kaXvQ3UKjI8FiRIzmwSd3emlTbppy2W6l9b+euqLoNW/LtvOa1w5IKBMnkfwk6OFHrhz/w8rTaFaqjR1h4ZJ0idCp1l0s+Vt4iiJTd1Fmn9cjoYmQgBs3azkKtrmIwWMoBjjX2vdosw= From: Andrew Cooper To: Peter Zijlstra , Josh Poimboeuf CC: "Paul E. McKenney" , "sfr@canb.auug.org.au" , "linux-kernel@vger.kernel.org" , "jgross@suse.com" , "sstabellini@kernel.org" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" Subject: Re: objtool warning for next-20221118 Thread-Topic: objtool warning for next-20221118 Thread-Index: AQHY/xmtDBdsZRBv3UKvUqFDgKSI5K5MVQ6A Date: Wed, 23 Nov 2022 10:52:09 +0000 Message-ID: <2255c45f-d8ba-3f32-9d99-737ad3040dd7@citrix.com> References: <20221121040736.GA3738360@paulmck-ThinkPad-P17-Gen-1> <20221121145215.GF4001@paulmck-ThinkPad-P17-Gen-1> <20221122051605.4hcbslwxez2trdvt@treble> <20221123012350.kelmmadh65lyswqz@treble> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM4PR03MB6142:EE_ x-ms-office365-filtering-correlation-id: a68e4e03-c80a-4ff2-b70d-08dacd40c4e2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xwWSu+KGOZ/2e9mINlinQqRty1Fmg+A+9nyM14ZbX2c5FMfpJ/bzQBeKf0iow3ixKhVhM6on8mXf+iOBoKNQzPmWcpJYEo3XN0pahd1JBCLxmZzvqMo7OVFyS88pxyLwO11u/KyoFvDywa2V5RXGLUqglVeGswEx3ka3LnbYjOcb5+3D7y11N5oJ6e9HQrGV7BoUPo2DVytoXFEpifd37jkNWh6PfpgBFNa+ER1+9djtKOoA6+y7urqPYkDnCxHsfRCv18hNhydhRc5N9eomNQNsjgEoLPJB0XfSXB21+GH66vct4hmLZ+T9EwWjfEi6C4A4D6ZFpNWV7vYYcMMKDUVBUfJjn2RPsT1E3C8KUPoWUEcBbn2LgMHJ3NXKteG9X+PWTPz5m4RQbuSqpE6BCNa9QU1eOF9rp7RfgyWJIf+cNkWVz9JiajtylKWjM6n3nMoPe9jIYcEovpzZ4NIgmZvsG+ZDS97MdiiGsewKxFUpyw9K9EO7QWltMN0Sef4cA7J9D4Mmn5E+r5xwr9W0vQJn0hBbTLgZnFfQe2f8EkG/iS6qs0V+Suh1ppW0KdhD10bsgGhvYOvC9P+4Fs4o+trVfFriG3DQjQQklWdzz/UazqsYBFKRIt4OcbD5NOk3cGn4nSqDBLrQM6OGQt1JZKqwvWDeCfv6lOqGhQrd9MFwDmPYBZYQycGOUZVCxTq1NSRzJmLppaz9reg2Xh5+w3KEX4REIOlQnBp/e3slXNaH6J9+NpYXuWY3TOgCUOQEbg655eljjamaqeQ4bc/9KA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(136003)(396003)(376002)(346002)(451199015)(82960400001)(478600001)(31686004)(86362001)(38100700002)(6486002)(83380400001)(71200400001)(122000001)(6506007)(2616005)(186003)(36756003)(2906002)(316002)(110136005)(54906003)(26005)(53546011)(31696002)(91956017)(8936002)(41300700001)(76116006)(66946007)(8676002)(64756008)(6512007)(66556008)(66476007)(5660300002)(38070700005)(4326008)(66446008)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VGJ6dlpRUk90KzcyU3dGTGFtdzRDL3Exa3k5bUFLM2czcTRJMjJCOTQwYWo2?= =?utf-8?B?N0RKRlo4UFBSNzM5MThXOE92di9vU1c0NUJvSWdHb0dBUyswTW96Z0lJdnhG?= =?utf-8?B?c0gvMlM0Y3ZsSnF6S1pVa1dqbGo5Kzk1eGd4bXZuK1dWdER0ekxxdXI2dUpZ?= =?utf-8?B?SVRMdm96UXBtUzlXOU4xODlBamFOeXFhQUlQemZmbk1VWnFtcjVrV0t5QzRM?= =?utf-8?B?bFQyd2FhK0VVVG9DQnVPN2Nzc2kxNzB1RW1LdktoMVlmQTBmc0FDcEFKL0hE?= =?utf-8?B?UEc1LzQvcHdRdWw4TDdFRDRPOTRiV3J5bWI1Nmo5NmJyWmNJRmxTRmVRNGdK?= =?utf-8?B?T1l5bXpEVnpJNEVuNzZTcmF1Q3c2NEsxbXN0V3VwN3lveUZTOENvT0wrMFVM?= =?utf-8?B?ZXk1R043eUJwdXpRdDhhM0svQWtpSnhHaFNtalBIb29rbUo5SEdoeUtqS2sv?= =?utf-8?B?Nll4bWRNQm04YVpWbjg0c205SUpMTkZwdjRGOTl1N0JyWENLdHNGd0wyVFZJ?= =?utf-8?B?Z2pYN0RYcmQ5Uzd6NEhSNGN6RGovdDdxdDk3NWJQNm9rWTQxTklZTnAxOWhq?= =?utf-8?B?eE9VWlZNbzJ0Y2lISzlqdzBPVjVyUHhRbDJkdUtJbXpmVjE1QVRZVW1rZXJB?= =?utf-8?B?dnI4NklTSkpiWWFqWkhGWmcvVS9sWVpRN256SWE3QitEdS82Z3Z2Tk5mR1Qz?= =?utf-8?B?OWZLellhMUxXNFhyU2FiZGZJU0lvdk5JWkpUcUJvYWEvV2htbzN5UStwQThp?= =?utf-8?B?Zm5jQlRHMU1GTVN1eWFNTlhaUlQwQXc4eTdmb3NMNUIrck9iRjdudUY0dnp6?= =?utf-8?B?WklYZkEzcnYxRGNrZTBQajMxSmpnV01ib3hZbVRTYnZaY1cyeGswSlVXTGRa?= =?utf-8?B?dElUSnRSTUVDNHN0UkVieHd2NEVyZE1WUG1pV0d2YjJPeTVTQTBpTXluVUp2?= =?utf-8?B?anZvamh0SjAxaDBsZFZ6RXRuRlRtNU5uS3M3cjlMeThza0JjaEtKSkpvU24r?= =?utf-8?B?dWFFK0hFWDJLYUUxZWJKdS9udThZTHB6MUl5N2lGYVpPTlRGb2ttK0pXdnBR?= =?utf-8?B?UmpSeTBFVUk4VXdNdWdjdmpKVWNQT3Y0UThmWWwyWFhTc0c4U1huQ05NTEJB?= =?utf-8?B?NWZDNWhHN3dzQjlib1pFZWQ5UDhzOXo1Ky9mNTBtbkhSY2srajBhS1oxbmdi?= =?utf-8?B?aU1yTmVzdllTcVV5ekQ3TUFQVkNXeE1zSHBqM1Y3VUhSWXVCWmx3TlVlMmlr?= =?utf-8?B?QWlhM0x4ZEFMSVc0QzV3bE52aUNBL2xnNzBrSHdBMFpIMWwvUnY2ZHI1UjVY?= =?utf-8?B?UHliVk1aNUxoZjVpME9SNzEvWTFzRFlXVDdDTDZjSVBVTXpSVk9VUklLdkxi?= =?utf-8?B?TWg5L1JDaS9mdDJCK1JFdHAzdXY3TERrMEVoajNEMVFLZzE1THlkZGdCWHdU?= =?utf-8?B?c1REWDY0bFJ2aGVPTXFhaUZ6VjB3VitRbjc2TEozL3Rrb1ZXYm13OFdIRlRR?= =?utf-8?B?Y2lJcC81WWNMZHBETWxFQVhkSy9xNFZYS2NXQ2ZVRHh2aGF5cXJldlo1T1hM?= =?utf-8?B?ck4vNW0xQlF1SFgwL2lqeHpzeDdVV2dnam1aQmtObUk3dWdkV3BHTW9PUjhL?= =?utf-8?B?Q3FmVjZnbW8vbmN1ZTJWYmdGbUZKWGlWUGdmcmZYREZNUFkrK0JTS1lrNHdu?= =?utf-8?B?UHplWmlwM3BrLzNOWStWZ1lyNmRzd1dIR3ZSRnRPcXZ2R0Zzak1TWnpTcHZH?= =?utf-8?B?NmVQai9hbTZrajJDbUwza2pYQlJnK2Z5ZUpIS1ZkcVk1TEVqdnNoOFJGZU5h?= =?utf-8?B?T09rN3hpODRSVWNzeFhRUjN1RmdWYzRnL0JCNVJCUUxKMFZvMUZmU1NSTFJ5?= =?utf-8?B?dk4wZVc0Q2xybjVDSVU2am9EWEkyd2txRTMxb1BJYkQ2ZHlvR2x3TzVaMGdM?= =?utf-8?B?d3QzOGtvUXZ6a0RPK0VTa2diMkhMdlhwMjNVK2tsWnpTNmtIK3ZPNGE0RG1a?= =?utf-8?B?a3NJazlzOHpmb1J1c2FGVlFVZFd5MTR0MWZ1MjhJUXhDRk0rUDUrUVdYZzVt?= =?utf-8?B?RzhUblljVktuNVhjY2JCQWpUZEdlRkkvaTZQZ2FaTm93M3ZxQU9ERVdFU2FY?= =?utf-8?Q?hOcCbAiifv4U4pw0w1AxBA2bb?= Content-Type: text/plain; charset="utf-8" Content-ID: <1629E2400D15104BBE4D2B692AEF143E@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?OUNERGkxdnlnMXIzTWwwZ3pWaDZZWUdFbDltTVIzYUgwU2pTR1pGSUhoakQw?= =?utf-8?B?L1gzV29CTVRRbXRDQWwzTHJ4N3MrVGpIK1lSc2ZIUWZUakhDQ0k4a0tYdW9q?= =?utf-8?B?SkpQRWJTWml6cGl4bktSL0h4RDdySmZNQXlTSERRUXNtZUltMllzWEl1ODR5?= =?utf-8?B?OG5OQmdubGMrdVRoZlJ4a3dCa2JXdWNnRHFmNjgrci9zZFA1QlcyMWFLSEtP?= =?utf-8?B?eWFKc1pLQXpLdnNTeXRzV2dhUWhJTWUzVnZUeGNpdm9UZ3JpV2F1cUJIelpn?= =?utf-8?B?c3RNbWNxSktmdGxqRU5WQWYweWlhbkxlQTZGcGkrTkl0Tmt4VThmU3ZvbXVy?= =?utf-8?B?UlBTV2Y0N2ZEaGdqQTlmOVpMb2NwMVg0a21VWitNUnRzYnNSUXZkWDBtUjdM?= =?utf-8?B?Rk1JMlo3UE9od2xUZWdpSGdjaUE5aGgzWm9OVVVCZE1tZS8wTkQzUlo1VFh4?= =?utf-8?B?L1QxUng4YmVkcjZ3dkdkYzNNRVlPS2lTeVRrTisvNU9nNGN0TG5JcUFmbHh1?= =?utf-8?B?WHpkMHA4eU5SekRjclRpdTdvaWxpMlR4WUU4T0ZWU0pyTTI0dU5jRkdqZlJT?= =?utf-8?B?RVcwdVMzc3FtZWd3RURQcGp6MTRLTXdZMldQT3I2aVRzM2Y1K0h6MCtSa3kr?= =?utf-8?B?eFZ0cXFSMXhYRUgrRGJCamV0QUlYVUhJTnJ2K2ZKRWQ3N0hSWURBRG1vaUJn?= =?utf-8?B?SWwvaCtSYXFNcHYxOXBjaUdnN29zaHFXNW5vYlZSK0dOY29SLzZPVlNtRWw0?= =?utf-8?B?QTBXanNJZU5TNHFYdHlkNWY4OW1tWStZbVZtZkZja2gxOFhDdXFQbDFlbmtC?= =?utf-8?B?Q245QmZDVTFnVmJNRnhuVkovQjZuNkZ5UnJCMHdTLzI1QnkyZ2xjYmVQSGxa?= =?utf-8?B?YUtuMG5DR3B1aFhUTXJldjBJWVlDaTJkQy9XanorYWFZTDE3c1pIZFBLeG1R?= =?utf-8?B?WE9YK254WXprVjduUTJrbGkxQjZUc1NXbTNzeExrcFpOM05RRERKWSszcUJh?= =?utf-8?B?Sk5BRy9uaGloOUZZeUVibWRyWTRDNk5EbTg4K3hPWjZ0QTlHZzNxS29CRnpV?= =?utf-8?B?ZTUrMUxlVEtKYlBEenhFT0UwYVdkeUxxWlhVd1RqK1B4QS9VYjdEcitmWkFQ?= =?utf-8?B?VkZ5RGZUTEttNkFlV2sydmNwQ0UwN1VkRmtFQmRYOVFYeWxxRkhDME05R2Nn?= =?utf-8?B?ZkdPQ0FJMTdHOUFiZ3dhUEZlTlE2OXZZOCtzT3Q3M0hPdGh2cmh2U0ZWSG5M?= =?utf-8?B?eXBDdlhNbHBvd2o1NElxSWxuQTR4OTFnWXdha2ovdndKOXh5S0NtV3h0Ynha?= =?utf-8?B?NVg5T3dkN1lWWSttSE5WRmpqK0VKRnloUnVhTGJqRjE0MnBsS3VKbmpXZTVt?= =?utf-8?Q?S7fxC6Iwb3CH3qFswjl8fBrLMvi+j09s=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a68e4e03-c80a-4ff2-b70d-08dacd40c4e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2022 10:52:09.0514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jHQyuuteqTNjA6qi6V44RvRCWJSmUuDKCsRynlvFQzwlDMT6QLQYZjAVEaNePbYgsDBKoMqdoSCinedx5kBGywqVaLxiGB3++4UMpazT/cM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6142 T24gMjMvMTEvMjAyMiAwODo1NSwgUGV0ZXIgWmlqbHN0cmEgd3JvdGU6DQo+IE9uIFR1ZSwgTm92 IDIyLCAyMDIyIGF0IDA1OjIzOjUwUE0gLTA4MDAsIEpvc2ggUG9pbWJvZXVmIHdyb3RlOg0KPj4g T24gVHVlLCBOb3YgMjIsIDIwMjIgYXQgMDk6MzU6MTdBTSArMDEwMCwgUGV0ZXIgWmlqbHN0cmEg d3JvdGU6DQo+Pj4gT24gTW9uLCBOb3YgMjEsIDIwMjIgYXQgMDk6MTY6MDVQTSAtMDgwMCwgSm9z aCBQb2ltYm9ldWYgd3JvdGU6DQo+Pj4NCj4+Pj4gSXQncyBjb21wbGFpbmluZyBhYm91dCBhbiB1 bnJlYWNoYWJsZSBpbnN0cnVjdGlvbiBhZnRlciBhIGNhbGwgdG8NCj4+Pj4gYXJjaF9jcHVfaWRs ZV9kZWFkKCkuICBJbiB0aGlzIGNhc2Ugb2JqdG9vbCBkZXRlY3RzIHRoZSBmYWN0DQo+Pj4+IGFy Y2hfY3B1X2lkbGVfZGVhZCgpIGRvZXNuJ3QgcmV0dXJuIGR1ZSB0byBpdHMgY2FsbCB0byB0aGUN Cj4+Pj4gbm9uLUNPTkZJR19TTVAgdmVyc2lvbiBvZiBwbGF5X2RlYWQoKS4gIEJ1dCBHQ0MgaGFz IG5vIHdheSBvZiBkZXRlY3RpbmcNCj4+Pj4gdGhhdCBiZWNhdXNlIHRoZSBjYWxsZXIgaXMgaW4g YW5vdGhlciB0cmFuc2xhdGlvbiB1bml0Lg0KPj4+Pg0KPj4+PiBBcyBmYXIgYXMgSSBjYW4gdGVs bCwgdGhhdCBmdW5jdGlvbiBzaG91bGQgbmV2ZXIgcmV0dXJuLiAgVGhvdWdoIGl0DQo+Pj4+IHNl ZW1zIHRvIGhhdmUgc29tZSBkdWJpb3VzIHNlbWFudGljcyAoc2VlIHhlbl9wdl9wbGF5X2RlYWQo KSBmb3INCj4+Pj4gZXhhbXBsZSwgd2hpY2ggKmRvZXMqIHNlZW0gdG8gcmV0dXJuPykuICBJJ20g dGhpbmtpbmcgaXQgd291bGQgYmUgYW4NCj4+Pj4gaW1wcm92ZW1lbnQgdG8gZW5mb3JjZSB0aGF0 IG5vcmV0dXJuIGJlaGF2aW9yIGFjcm9zcyBhbGwgYXJjaGVzIGFuZA0KPj4+PiBwbGF0Zm9ybXMs IHNwcmlua2xpbmcgX19ub3JldHVybiBhbmQgQlVHKCkgb24gYXJjaF9jcHVfaWRsZV9kZWFkKCkg YW5kDQo+Pj4+IG1heWJlIHNvbWUgb2YgaXQgY2FsbGVlcywgd2hlcmUgbmVlZGVkLg0KPj4+Pg0K Pj4+PiBQZXRlciwgd2hhdCBkbyB5b3UgdGhpbms/ICBJIGNvdWxkIGF0dGVtcHQgYSBwYXRjaC4N Cj4+PiBJJ20gdGhpbmtpbmcgdGhlIFhlbiBjYXNlIG1ha2VzIGFsbCB0aGlzIHJlYWxseSByYXRo ZXIgZGlmZmljdWx0IDovDQo+Pj4NCj4+PiBXaGlsZSBub3JtYWxseSBhIENQVSBpcyBicm91Z2h0 IHVwIHRocm91Z2ggYSB0cmFtcG9saW5lLCBYZW4gc2VlbXMgdG8NCj4+PiBoYXZlIGltcGxlbWVu dGVkIGl0IGJ5IHNpbXBseSByZXR1cm5pbmcgZnJvbSBwbGF5X2RlYWQoKSwgYW5kIGFmYWljdA0K Pj4+IHRoYXQgaXMgYWN0dWFsbHkgYSB2YWxpZCB3YXkgdG8gZ28gYWJvdXQgZG9pbmcgaXQuDQo+ PiBvX08NCj4+DQo+PiBIb3cgdGhlIEAjJCUgaXMgdGhhdCBhIHZhbGlkIHdheSBvZiBkb2luZyBp dD8gIFdoeSBub3QganVzdCBkbyBpdCB0aGUNCj4+IG5vcm1hbCB3YXk/DQo+IFdlbGwsIGlmIHlv dSByZXR1cm4gZnJvbSBhcmNoX2NwdV9pZGxlX2RlYWQoKSB5b3UncmUgYmFjayBpbiB0aGUgaWRs ZQ0KPiBsb29wIC0tIGV4YWN0bHkgd2hlcmUgeW91IHdvdWxkIGJlIGlmIHlvdSB3ZXJlIHRvIGJv b3RzdHJhcCB0aGUgd2hvbGUNCj4gQ1BVIC0tIHByb3ZpZGVkIHlvdSBoYXZlIGl0IHJlbWVtYmVy IHRoZSB3aG9sZSBzdGF0ZSAoZWFzaWVyIHdpdGggYQ0KPiB2Q1BVKS4NCj4NCj4gQnV0IG1heWJl IEknbSBtaXNzaW5nIHNvbWV0aGluZywgbGV0cyBhZGQgWGVuIGZvbGtzIG9uLg0KDQpDYWxsaW5n IFZDUFVPUF9kb3duIG9uIG9uZXNlbGYgYWx3YXlzIHN1Y2NlZWRzLCBidXQgYWxsIGl0IGRvZXMg aXMNCmRlc2NoZWR1bGUgdGhlIHZDUFUuDQoNCkl0IGNhbiBiZSB1bmRvbmUgYXQgYSBsYXRlciBw b2ludCBieSBhIGRpZmZlcmVudCB2Y3B1IGlzc3VpbmcgVkNQVU9QX3VwDQphZ2FpbnN0IHRoZSBw cmV2aW91c2x5LWRvd25lZCBDUFUsIGF0IHdoaWNoIHBvaW50IHRoZSB2Q1BVIGdldHMgcmVzY2hl ZHVsZWQuDQoNClRoaXMgaXMgd2h5IHRoZSBWQ1BVT1BfZG93biBoeXBlcmNhbGwgcmV0dXJucyBu b3JtYWxseS7CoCBBbGwgc3RhdGUNCnJlYWxseSBpcyBpbnRhY3QuDQoNCkFzIGZvciB3aGF0IExp bnV4IGRvZXMsIHRoaXMgaXMgaG93IHhlbl9wdl9jcHVfdXAoKSBjdXJyZW50bHkgYmVoYXZlcy7C oA0KSWYgeW91IHdhbnQgdG8gbWFrZSBYZW4gYmVoYXZlIG1vcmUgZXZlcnl0aGluZyBlbHNlLCB0 aGVuIGJ1ZyBhIEJVRygpDQphZnRlciBWQ1BVT1BfZG93biwgYW5kIGFkanVzdCB4ZW5fcHZfY3B1 X3VwKCkgdG8gc2tpcCBpdHMgaW5pdGlhbGlzZWQNCmNoZWNrIGFuZCBhbHdheXMgdXNlIFZDUFVP UF9pbml0aWFsaXNlIHRvIGJyaW5nIHRoZSB2Q1BVIGJhY2sgb25saW5lLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 23 11:00:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 11:00:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447519.703829 (Exim 4.92) (envelope-from ) id 1oxnU0-0007D0-Jt; Wed, 23 Nov 2022 11:00:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447519.703829; Wed, 23 Nov 2022 11:00:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxnU0-0007Ct-Go; Wed, 23 Nov 2022 11:00:00 +0000 Received: by outflank-mailman (input) for mailman id 447519; Wed, 23 Nov 2022 10:59:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxnTz-0007Cn-2x for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 10:59:59 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f6060dde-6b1d-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 11:59:56 +0100 (CET) Received: from mail-dm6nam10lp2101.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Nov 2022 05:59:54 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by SJ0PR03MB6471.namprd03.prod.outlook.com (2603:10b6:a03:38d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 10:59:51 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 10:59:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6060dde-6b1d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669201196; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=ub3dcPr3NQCpIfBaeMj1CUNdcc6DRr0U3yFB+6Ru9IQ=; b=ETNUUNegqk35WjYl6tgAwtktsYJNdH+KEgvrOq5F+ofVL8bU/QRVbHQg bT1oHngVOF263aSlDShnqA8Rf4AF+eDod8ahgnv9lViE6UCpWaLEBKxU8 qu80bFxFDrFml9hJ28H1oIen33oIvMoMQij7XEiVtQc7AVeai3XdY0dLa Q=; X-IronPort-RemoteIP: 104.47.58.101 X-IronPort-MID: 85424128 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:sOpwE6MZhWBZSA7vrR27lsFynXyQoLVcMsEvi/4bfWQNrUonhjxRy zMWC26EaKuOY2b1L9l1aY+2pxkPv5WDx9RjSAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5AdmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rlGDE4J9 PkxEQxXTTLbwPiRw5uVUeY506zPLOGzVG8ekldJ6GiBSNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PpxujCKpOBy+OGF3N79cdyQRN5Jn0+e4 GbH+Wj4DTkRNcCFyCrD+XWp7gPKtXOmBNhOTefonhJsqHq93DAWVwInbnmisPSrkBW/X8ptA kNBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQqvdE7bSYn3 ViIm5XuHzMHjVGOYXeU97PRoTbsPyEQdDcGfXVdFVJD5MT/qoYuiB6JVsxkDKO+ktzyH3f33 iyOqy89wb4UiKbnypmGwLwOuBr0zrChc+L/zly/sr6Nhu+hWLOYWg== IronPort-HdrOrdr: A9a23:knL3fa7wrzb3tLI8/gPXweCCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpixBiSgSiu4LvaFQHd+hsFSTtAzZor7G CAymXCl+SemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQBiTwhh2ubIFBXaTHmDwuuumg5Hsjjd GJiRY9OMZY7W/XYwiO0FXQ8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMk5 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvvn+9Ua1wWR4S2rpXV9 WGP/usosq+tmnqNkwxi1MfhOBEmE5DRituDHJy4fB9mAIm4UyRh3FouPD32E1wtK7VAqM0md jsI+BmkqpDQdQRar84DOAdQdGvAmiIWh7UNnmOSG6XXZ3uqxr22uHKCZgOlZaXkaYzve0PsY WEVEkduX85ekroB8HL1JpX8grVSGH4WTj20MlR65Vwp7W5HdPQQGa+YUFrl9Hlr+QUA8XdVf r2MJVKA+X7JW+rHYpSxQXxV5RbNHFbWswIvdQwXU6Iv6vwW8XXn/2edOyWKKvmED4iVG+6Cn wfXCLrLMEF9UyvUm+QummkZ5osQD2LwXtdKtmowwFI8vl9CmRliHlktX2poseWNDZFrqs6OE NjPbKPqNLImVWL X-IronPort-AV: E=Sophos;i="5.96,187,1665460800"; d="scan'208";a="85424128" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FTfHV7PTbLL+OwQ6S8x0HfOQYUxEG1FRL62FTfJ8eYAjwg3MRgE3z6xwLNgWBIxVEbctovCcRPMIjNl52We6D83mnePvD1LB3if0PBduj4Cd9APJlj5QfVQ59YhRNrQ0YIq+6c1atABKqgX2lA+DV4XRC9qaNYsx1Ibyop3xI+oa/XJYURFunzrPgBOh/VH74UOxhlmf0yosgZ2UwrtOhYFvVt5eW9JysBXeNIsLCFoTpaK/VYOcfGXG0WPaEzElDkHh7ZE5r8QEgiaCkqG7nd7qNTypfIJC09oQGCuhKNukHTK4P7txNwfdOnGukaI51rkvQR9fLWBNxcH0H6hFGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ub3dcPr3NQCpIfBaeMj1CUNdcc6DRr0U3yFB+6Ru9IQ=; b=n/dNBABrGPaU488NsSx3fkZ6MdK2JxAy3bmd0rHkOvynHA31+b8U6hvUgMhoud507nazt6W6Noa3jKZEt+Qx7RPGi5hRf5AVpXgvMeyNtxxTusGe8ME/7ia+LByCtzN8yc6FKY/f3tRoaoqs07C2XvIwKhUW4O+CwQxjyZKQSf9cgl3DGz6MvsZWlaIO52BZ2LtEgVbm0DWEc3hqK3qPoMe9+wwi6c3dFhcdVfjj9p4SkJtVOEXqIl25hhGtTDj63vz490MHMhne1sSwVyeU5SAwiPbQUqMo2E5QAiDqq1eGhUWTBWRaRLyQLwoR6kNdhPqs/ZULU33JBHRgjx77TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ub3dcPr3NQCpIfBaeMj1CUNdcc6DRr0U3yFB+6Ru9IQ=; b=QU/k/YkkBBm2Tp7cysk91ZpCI+TQ1qDubSs2YmhneEDMwWBMTDgCEtvrnoWArk6NDjibn0bkPr4tSq/l6LSUit2TZmEAc5UF34mcmVv+wzKThvKDlDpBW7EBLNf7qRcITCjRNs6WPIQrvYdSF0DgSPT81d55jTBQzdOLXZJMKuA= From: Christian Lindig To: Andrew Cooper CC: Xen-devel , Edwin Torok , David Scott , Rob Hoes Subject: Re: [PATCH 5/8] tools/oxenstored: Keep /dev/xen/evtchn open across live update Thread-Topic: [PATCH 5/8] tools/oxenstored: Keep /dev/xen/evtchn open across live update Thread-Index: AQHY/oYKxtNRy0op0U+W6qla123BXq5MWFyA Date: Wed, 23 Nov 2022 10:59:51 +0000 Message-ID: <5D787A34-C3BA-4451-8F27-AA4D89C9046B@citrix.com> References: <20221122152043.8518-1-andrew.cooper3@citrix.com> <20221122152043.8518-6-andrew.cooper3@citrix.com> In-Reply-To: <20221122152043.8518-6-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|SJ0PR03MB6471:EE_ x-ms-office365-filtering-correlation-id: 91aa5856-6ad4-41d5-39dd-08dacd41d83d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /BjE4vXu9j7bGusKSp7Fpxipm3oJsK7Mf4F1Uex+8g1r0l3kLe/hUjU02T/rLm9oajqntuk2H008+nn20NdoGpHW3vLmhiFMchCapgsADiJixwxI3dN1rlxQDXcEX8EL1gsRVmHI5fL/NwHer4YWduQi0stXSlFKqdHDGB5VCgwgWqRAJ4Zy5nPUBg7DVhYoAJq7SOWuU8BfnykrzRB8ueaDWzFWNAMmu+K4c+4NTFHJPogjR/qz5sU4baRPX7KGIlqECbSB8U/0OAKDb5hhUmtSfB76Bt8bye38QZ9T2CVmcJvs/VUN8A/isXZKggzDmdUr7kxHo+OqBYyM6tQBs2EMqQveCThqVf5fr2KDBLqI8d6PjtoHLt6RQC+Ztbn+uWPA87gg9TUg/gFrfjP/J6b7oSGFoOL6uqB/5hUdVZILU4QcbzAW18V4xUuIn0qzPmTDVcxgQ5SwQWvuYTdXQ+s5ThH0mbmkqU3uYyfEdWbDYqBJHfgZC8W8vKWFnTkBhwF7moW5TPUHraj2ZEFnk2J2QD3xON+qfppO8s1GFpKhwYgfNlhV1tq3m3XvjyRKUm+dKjLx3f05VpyW2VbUyeF2zgCgbjeg5U7AWx6nbL5HsJCL7whjSpyoxtRaBOLyMlXqc/ulkMoEmDlLDqItJ/roL0Suczrx0TTyKs9YrzgCRSERl7Xlc68dybdDevFBYjr4TZs/OTmxwMspYCCMVG5hV/JbQqzduL5iHsNTrr0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(366004)(39860400002)(136003)(451199015)(5660300002)(2906002)(6862004)(38070700005)(26005)(8936002)(6512007)(6506007)(38100700002)(44832011)(53546011)(82960400001)(122000001)(15650500001)(316002)(37006003)(30864003)(33656002)(71200400001)(36756003)(6636002)(107886003)(54906003)(41300700001)(66446008)(4326008)(8676002)(66556008)(64756008)(66476007)(66574015)(6486002)(86362001)(186003)(91956017)(2616005)(83380400001)(66946007)(76116006)(478600001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?N0M0TlJPMUh2ZXo5WE4zWDRtUjNlb3J3WmVjNzBuTEFpL3RJbEJoTzhVa0g3?= =?utf-8?B?d1lRNG9HZitDY1ZVS2lHS3cxcHBoZFYvMlVXVTlYTHFUTVZnSlNOLzdoTmFY?= =?utf-8?B?T2tkQ2NzM0JXQW5aeENhZnB6YVpaSnlSUnFoWXZGMnVOaGoxeDEwdFNubkph?= =?utf-8?B?UWNIeStJKzBWVU9OazRLcW43dHZJSUtLYWVNRWY5aTBXUGpOTlQ2M2t0MlE3?= =?utf-8?B?VlQ1M0dMd1I4UE1nVnd6a3pkZjR3dU9hTXEvQXJXTG52WVBUTXM2cjQrRUwv?= =?utf-8?B?ZmFGS25BRDFJRDdXNWpXZEplazNhOUszV2xTZlNHZk1tOEFqK3NGaFl5SklZ?= =?utf-8?B?T0dNKzJ0WS9jSFYwdjdNbG5uZFZlNWJUUkh1UUhXTldyM3F3L3lNNnRuK0tU?= =?utf-8?B?bHgwWnp5RUN0T2Z6d0xpRDR2ZUZPcFZiZDFlL09jdmZaNnNDQXNKa0UzZlRj?= =?utf-8?B?NXlrRFMxTElKRTg2ZllkODJWR3RwMm1jbmtZd2VEQkc1RVJiWlB6SktXK09z?= =?utf-8?B?MjVBMEc2S2VVSmJHWVRJV2JiMm5nMzZydlJFQ3JyaTB0WDR2R3ZGcitqaEsz?= =?utf-8?B?VlpwaGF4dFc0MlZtcmhmSmNvR3h0MFEvcWI5WENnTWZla0JoV1NWdDk3clpm?= =?utf-8?B?ampCSlphSjExeU5yL3c2NzF5d0IzTXpRS2VQRmg1dVczd1NHOWhWN0p3NlZ6?= =?utf-8?B?TC9EaVdNWkxZcWpwd3dHV3R0TEkxL202TWFPV2NoQmZaZmhaYjNqMWVSR2xr?= =?utf-8?B?d2tKaFdQd0U4R29kdEtIRWpab2E5ajVRWkswZEtRQm5OSDdiZWhXODBUK1pB?= =?utf-8?B?dEc1anVzZTd5ZWNyOWZPWU80YzJSWEI0bzBHclZ6cDNuYVhXZ2Nhck45eUlz?= =?utf-8?B?cHMzazlWWWE5L1hJSlNNbWp1SE92WGpwZGhZRDNVQVA0d0N3d1FVWm5tREJn?= =?utf-8?B?QU5qeGVJbVBUN0hSREg5cmdzOGl3SGN4aTdUZzd5cW9OMy9aVERFdDJOOGh6?= =?utf-8?B?ZHBYcTgvcWpNV0xCcis5RWFKWmRyY1liTnJCL2R2U2F2TVFnV2Zod1pDWVg1?= =?utf-8?B?Yk40aEpmWTZpTHZETDNEcExzUVE3SUhKN0k3N0c4YnBNdzBhTXR4K3I4bWFK?= =?utf-8?B?d1ZQaCtxbEZCM1RwV3lXbXB0TDJKanRMNHZKMjB2UUMxT0JMOFVQT0R5R0Iw?= =?utf-8?B?VC95TnI3N3I2OElJc2NlcjNvSUpqQUJyTEc1ZGZhdlZzVllYZE5IcE12VGNY?= =?utf-8?B?bS9EMyszakhzLy9UQkVkcFBwcCtiWDFMVTV1VnROeldqbVlxb08vVWVGK3hS?= =?utf-8?B?dGQxRmNIWG1HOHNyRkVjb3JpRi8rRitnS2t4Tmd5dk1IRnVCSWEyN2krellO?= =?utf-8?B?Y3RmUW50SDUwRmJFd1JOdzdsZkdtTGxJbUNlZkw0OHpxSis5S1JLOGxQU3g3?= =?utf-8?B?bnhaWUU3SEVkQ3NiYWl2bDc3bTVCOGQraUEwVURGZUxJOWVoVlFQRnRnNXl6?= =?utf-8?B?THpMeEp5Qjh6YWdTd05ZbE04MC82am9QNm5qVnpxOVh6Zm5MN0VTVDRUaG1z?= =?utf-8?B?aG9HT1NtNWVYOWZQY09pcGhCK1VnK2NvN0RpT0ZKcmptOXZ3dG9IRUtjVjlm?= =?utf-8?B?dkJReVJ2alN1T05FOTlBOGpNY3FHNGEvd2h0bkQ4SnZ0R2VpVE9yTkVkMFc0?= =?utf-8?B?MHd0Sno0OGJHVURIdUFuQnhPc3FUcUpVZWpjTE5GRjFHOVp1Ky9Bcno0Wjha?= =?utf-8?B?WWozSmpxVUpyZWFTYmkvZGZESXErTnh4eWtBWFNlRUE5UHpXVWhac0JLQ054?= =?utf-8?B?emo2TUd1ZkRldGJSdTN6TVNpdnNSb1BUM0w1QzRneWV5U1pEK0pNMXpkMm5L?= =?utf-8?B?bHRQUFpyWi9RQ3B5a3AvZ2Y3c0NyUFNnTEFUSW13VFNDemxZQU5sWWdhUjQv?= =?utf-8?B?NVQ4NDMrUUt5bjdRL1FYWG9sV0NxR0lNTEZqQ3B6ZFJPdG1Lc2E3RjBCTDZw?= =?utf-8?B?OExHMXJCaDVDTitObHdzaUxDUkMxU25QdTBadjlnZVprN3hqcFFMQ3c1WVNC?= =?utf-8?B?ZlZ3dUlzYVhVVzF1T05DR2dlYVVvcjZodUxQYzZlc1pXZ3ZIc1lrdHNwY1lB?= =?utf-8?B?dmRuL0o3endWZW9WZzE2aFMrczlqUEl0clZOOEcydFlGNlNGUlBuemNWempl?= =?utf-8?Q?NMwREKyMNsn9/zqL7AviqyA=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <15295E6AE894B6478D2D3B97F70B9CD0@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: qQO23usy7JfOMiFw4mBxbl6GMTMsvn6TJC8j1Tbqpkac0nDJzq+QEOdnOubgs1iGSyj8jufITa3nrTKlOQBb1fQ+xlaCbrhy+xth2cWgGS6aOTRfaDaTxK39vL6nptrOLvSdwhW8/J12V8TTpHghJXR9J0naQHthjU2PQhyV1zUzXN38aPziKlZFDfEM/vxZq9k8WBCbqsX10QrLV8A2frIgmMCsnj6bBb+9d1VVJyUpTiWgAIlL3LiBEJ7w+/pnT2CNvXKjUs5nal8pd490lB356s+gKPF4arIpKRneQuIanNpN9T2SPTyncXuMAM2vRN3wjWMFx26rloxs1pWvBcO+AB++f3ujcNw52XBPm2hfzWIRNQGPGvPvwASsBMZQSrfwxWQbgXHdkrlpORiqzZDLkZr295ZuticKjeTkAdOvanusB18U7I32GJ3Q30YrXnXmiaK1Lx8fnZ2n6TXNlatQnZDPMHXj5SNQQNvgvM4kcByLcPERWeDSYIgoBAEP5CiXFWPQ3e8Iq0ONxMB4Tu2vdpXR94rfta/z7X9uVLdyctXmNsm4h8vRHPkxUy7skX5jQF2FiJwzL8+Ro6lN/Yrc9RF+lHdN9UrtbwyvxmUX4E3cGjs4riOsnx6pL3StNGcsKV/Zcy73yMH0x8bikWvJq8sYnQKI4GWkN1X8hrOrhKZDAfT+PE7sL5bZBXQVh+pkNX12TD5bTmnoL1zlcAUjte8G3fAS6buStGgmrllCKBJgf6BkOFcGthohjaWe+RNbJWtFIBXXEmUjtrZlEV8pKjJ72jpB2rbo1jAmqmRP34mD1CSkBRP9RFJV+oMs X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91aa5856-6ad4-41d5-39dd-08dacd41d83d X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2022 10:59:51.0337 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Fx445cRbQM6zSCAWaC5wEeQJogGfykEN2Ty36JrDD40siX6pqqCVR6YiE83E5jyAlCfKOfHp8tkrwoXHy5fpKtEEkRe3FYcueAppYLu9a0s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6471 DQoNCj4gT24gMjIgTm92IDIwMjIsIGF0IDE1OjIwLCBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29v cGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IEZyb206IEVkd2luIFTDtnLDtmsgPGVkdmlu LnRvcm9rQGNpdHJpeC5jb20+DQo+IA0KPiBDbG9zaW5nIHRoZSBldnRjaG4gaGFuZGxlIHdpbGwg dW5iaW5kIGFuZCBmcmVlIGFsbCBsb2NhbCBwb3J0cy4gIFRoZSBuZXcNCj4geGVuc3RvcmVkIHdv dWxkIG5lZWQgdG8gcmViaW5kIGFsbCBldnRjaG5zLCB3aGljaCBpcyB3b3JrIHRoYXQgd2UgZG9u J3Qgd2FudA0KPiBvciBuZWVkIHRvIGJlIGRvaW5nIGR1cmluZyB0aGUgY3JpdGljYWwgaGFuZG92 ZXIgcGVyaW9kLg0KPiANCj4gSG93ZXZlciwgaXQgdHVybnMgb3V0IHRoYXQgdGhlIFdpbmRvd3Mg UFYgZHJpdmVycyBhbHNvIHJlYmluZCB0aGVpciBsb2NhbCBwb3J0DQo+IHRvbyBhY3Jvc3Mgc3Vz cGVuZC9yZXN1bWUsIGxlYXZpbmcgKG8peGVuc3RvcmVkIHdpdGggYSBzdGFsZSBpZGVhIG9mIHRo ZQ0KPiByZW1vdGUgcG9ydCB0byB1c2UuICBJbiB0aGlzIGNhc2UsIHJldXNpbmcgdGhlIGVzdGFi bGlzaGVkIGNvbm5lY3Rpb24gaXMgdGhlDQo+IG9ubHkgcm9idXN0IG9wdGlvbi4NCj4gDQo+IFRo ZXJlZm9yZToNCj4gKiBIYXZlIG94ZW5zdG9yZWQgb3BlbiAvZGV2L3hlbi9ldnRjaG4gd2l0aG91 dCBDTE9FWEVDIGF0IHN0YXJ0IG9mIGRheQ0KPiAqIEV4dGVuZCB0aGUgaGFuZG92ZXIgaW5mb3Jt YXRpb24gd2l0aCB0aGUgZXZ0Y2huIGZkLCBhbmQgdGhlIGxvY2FsIHBvcnQNCj4gICBudW1iZXIg Zm9yIGVhY2ggZG9tYWluIGNvbm5lY3Rpb24uDQo+ICogSGF2ZSAodGhlIG5ldykgb3hlbnN0b3Jl ZCByZWNvdmVyIHRoZSBvcGVuIGhhbmRsZSB1c2luZyBYZW5ldmVudGNobi5mZG9wZW4sDQo+ICAg YW5kIHVzZSB0aGUgcHJvdmlkZWQgbG9jYWwgcG9ydHMgcmF0aGVyIHRoYW4gdHJ5aW5nIHRvIHJl YmluZCB0aGVtLg0KPiANCj4gV2hlbiB0aGlzIG5ldyBpbmZvcm1hdGlvbiBpc24ndCBwcmVzZW50 IChpLmUuIGxpdmUgdXBkYXRpbmcgZnJvbSBhbiBveGVuc3RvcmVkDQo+IHByaW9yIHRvIHRoaXMg Y2hhbmdlKSwgdGhlIGJlc3QtZWZmb3J0IHN0YXR1cyBxdW8gd2lsbCBoYXZlIHRvIGRvLg0KPiAN Cj4gU2lnbmVkLW9mZi1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4N Cj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4NCj4gLS0tDQo+IENDOiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJp eC5jb20+DQo+IENDOiBEYXZpZCBTY290dCA8ZGF2ZUByZWNvaWwub3JnPg0KPiBDQzogRWR3aW4g VG9yb2sgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+DQo+IENDOiBSb2IgSG9lcyA8Um9iLkhvZXNA Y2l0cml4LmNvbT4NCj4gDQoNCkFja2VkLWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4u bGluZGlnQGNpdHJpeC5jb20+DQoNCk5vdGhpbmcgc3RhbmRzIG91dCBmb3IgbWUuIEJ1dCB0aGlz IGlzIG9idmlvdXNseSBkZWxpY2F0ZSBpbiBzdXBwb3J0IG9mIGEgZGVsaWNhdGUgZmVhdHVyZSwg d2hpY2ggaXMgbGl2ZSB1cGRhdGUuIEkgY29tbWVudGVkIGJlZm9yZSB0aGF0IHRoZSBjb21tZW5k IGxpbmUgZ2V0cyBpbmNyZWFzaW5nbHkgY3Jvd2RlZC4NCg0K4oCUIEMNCg0KDQo+IE1lcmdlIHR3 byBwYXRjaGVzIHRvIHJldGFpbiBiaXNlY3RhYmlsaXR5LiAgRHJvcCBjaGFuZ2VzIHRvIHRoZSBl dnRjaG4gYmluZGluZ3MuDQo+IC0tLQ0KPiB0b29scy9vY2FtbC94ZW5zdG9yZWQvZG9tYWluLm1s ICAgIHwgIDYgKystDQo+IHRvb2xzL29jYW1sL3hlbnN0b3JlZC9kb21haW5zLm1sICAgfCAxNCAr KysrKy0tDQo+IHRvb2xzL29jYW1sL3hlbnN0b3JlZC9ldmVudC5tbCAgICAgfCAgOCArKystDQo+ IHRvb2xzL29jYW1sL3hlbnN0b3JlZC94ZW5zdG9yZWQubWwgfCA4MiArKysrKysrKysrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLQ0KPiA0IGZpbGVzIGNoYW5nZWQsIDc4IGluc2VydGlvbnMo KyksIDMyIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0 b3JlZC9kb21haW4ubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvZG9tYWluLm1sDQo+IGluZGV4 IDgxY2I1OWI4ZjFhMi4uNTI3MDM1ZmZkZDMyIDEwMDY0NA0KPiAtLS0gYS90b29scy9vY2FtbC94 ZW5zdG9yZWQvZG9tYWluLm1sDQo+ICsrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kb21haW4u bWwNCj4gQEAgLTYxLDcgKzYxLDcgQEAgbGV0IHN0cmluZ19vZl9wb3J0ID0gZnVuY3Rpb24NCj4g fCBTb21lIHggLT4gc3RyaW5nX29mX2ludCAoWGVuZXZlbnRjaG4udG9faW50IHgpDQo+IA0KPiBs ZXQgZHVtcCBkIGNoYW4gPQ0KPiAtCWZwcmludGYgY2hhbiAiZG9tLCVkLCVuZCwlZFxuIiBkLmlk IGQubWZuIGQucmVtb3RlX3BvcnQNCj4gKwlmcHJpbnRmIGNoYW4gImRvbSwlZCwlbmQsJWQsJXNc biIgZC5pZCBkLm1mbiBkLnJlbW90ZV9wb3J0IChzdHJpbmdfb2ZfcG9ydCBkLnBvcnQpDQo+IA0K PiBsZXQgbm90aWZ5IGRvbSA9IG1hdGNoIGRvbS5wb3J0IHdpdGgNCj4gfCBOb25lIC0+DQo+IEBA IC03Nyw2ICs3NywxMCBAQCBsZXQgYmluZF9pbnRlcmRvbWFpbiBkb20gPQ0KPiAJZG9tLnBvcnQg PC0gU29tZSAoRXZlbnQuYmluZF9pbnRlcmRvbWFpbiBkb20uZXZlbnRjaG4gZG9tLmlkIGRvbS5y ZW1vdGVfcG9ydCk7DQo+IAlkZWJ1ZyAiYm91bmQgZG9tYWluICVkIHJlbW90ZSBwb3J0ICVkIHRv IGxvY2FsIHBvcnQgJXMiIGRvbS5pZCBkb20ucmVtb3RlX3BvcnQgKHN0cmluZ19vZl9wb3J0IGRv bS5wb3J0KQ0KPiANCj4gK2xldCByZXN0b3JlX2ludGVyZG9tYWluIGRvbSBsb2NhbHBvcnQgPQ0K PiArCWFzc2VydCAoZG9tLnBvcnQgPSBOb25lKTsNCj4gKwlkb20ucG9ydCA8LSBTb21lIChYZW5l dmVudGNobi5vZl9pbnQgbG9jYWxwb3J0KTsNCj4gKwlkZWJ1ZyAicmVzdG9yZWQgaW50ZXJkb21h aW4gJWQgcmVtb3RlIHBvcnQgJWQgdG8gbG9jYWwgcG9ydCAlcyIgZG9tLmlkIGRvbS5yZW1vdGVf cG9ydCAoc3RyaW5nX29mX3BvcnQgZG9tLnBvcnQpDQo+IA0KPiBsZXQgY2xvc2UgZG9tID0NCj4g CWRlYnVnICJkb21haW4gJWQgdW5ib3VuZCBwb3J0ICVzIiBkb20uaWQgKHN0cmluZ19vZl9wb3J0 IGRvbS5wb3J0KTsNCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kb21haW5z Lm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RvbWFpbnMubWwNCj4gaW5kZXggMTdmZTJmYTI1 NzcyLi5hOTFkMmFmZDJhODIgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9k b21haW5zLm1sDQo+ICsrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kb21haW5zLm1sDQo+IEBA IC01Niw2ICs1Niw3IEBAIGxldCBleGlzdCBkb21zIGlkID0gSGFzaHRibC5tZW0gZG9tcy50YWJs ZSBpZA0KPiBsZXQgZmluZCBkb21zIGlkID0gSGFzaHRibC5maW5kIGRvbXMudGFibGUgaWQNCj4g bGV0IG51bWJlciBkb21zID0gSGFzaHRibC5sZW5ndGggZG9tcy50YWJsZQ0KPiBsZXQgaXRlciBk b21zIGZjdCA9IEhhc2h0YmwuaXRlciAoZnVuIF8gYiAtPiBmY3QgYikgZG9tcy50YWJsZQ0KPiAr bGV0IGV2ZW50Y2huIGRvbXMgPSBkb21zLmV2ZW50Y2huDQo+IA0KPiBsZXQgcmVjIGlzX2VtcHR5 X3F1ZXVlIHEgPQ0KPiAJUXVldWUuaXNfZW1wdHkgcSB8fA0KPiBAQCAtMTIyLDE3ICsxMjMsMjIg QEAgbGV0IGNsZWFudXAgZG9tcyA9DQo+IGxldCByZXN1bWUgX2RvbXMgX2RvbWlkID0NCj4gCSgp DQo+IA0KPiAtbGV0IGNyZWF0ZSBkb21zIGRvbWlkIG1mbiBwb3J0ID0NCj4gK2xldCBtYXliZV9i aW5kX2ludGVyZG9tYWluIHJlc3RvcmVfbG9jYWxwb3J0IGRvbSA9DQo+ICsJbWF0Y2ggcmVzdG9y ZV9sb2NhbHBvcnQgd2l0aA0KPiArCXwgTm9uZSAtPiBEb21haW4uYmluZF9pbnRlcmRvbWFpbiBk b20NCj4gKwl8IFNvbWUgcCAtPiBEb21haW4ucmVzdG9yZV9pbnRlcmRvbWFpbiBkb20gcA0KPiAr DQo+ICtsZXQgY3JlYXRlIGRvbXMgZG9taWQgbWZuID9yZXN0b3JlX2xvY2FscG9ydCBwb3J0ID0N Cj4gCWxldCBpbnRlcmZhY2UgPSBYZW5jdHJsLm1hcF9mb3JlaWduX3JhbmdlIHhjIGRvbWlkIChY ZW5tbWFwLmdldHBhZ2VzaXplKCkpIG1mbiBpbg0KPiAJbGV0IGRvbSA9IERvbWFpbi5tYWtlIGRv bWlkIG1mbiBwb3J0IGludGVyZmFjZSBkb21zLmV2ZW50Y2huIGluDQo+IAlIYXNodGJsLmFkZCBk b21zLnRhYmxlIGRvbWlkIGRvbTsNCj4gLQlEb21haW4uYmluZF9pbnRlcmRvbWFpbiBkb207DQo+ ICsJbWF5YmVfYmluZF9pbnRlcmRvbWFpbiByZXN0b3JlX2xvY2FscG9ydCBkb207DQo+IAlkb20N Cj4gDQo+IGxldCB4ZW5zdG9yZWRfa3ZhID0gcmVmICIiDQo+IGxldCB4ZW5zdG9yZWRfcG9ydCA9 IHJlZiAiIg0KPiANCj4gLWxldCBjcmVhdGUwIGRvbXMgPQ0KPiArbGV0IGNyZWF0ZTAgP3Jlc3Rv cmVfbG9jYWxwb3J0IGRvbXMgPQ0KPiAJbGV0IHBvcnQsIGludGVyZmFjZSA9DQo+IAkJKA0KPiAJ CQlsZXQgcG9ydCA9IFV0aWxzLnJlYWRfZmlsZV9zaW5nbGVfaW50ZWdlciAheGVuc3RvcmVkX3Bv cnQNCj4gQEAgLTE0Niw3ICsxNTIsNyBAQCBsZXQgY3JlYXRlMCBkb21zID0NCj4gCQlpbg0KPiAJ bGV0IGRvbSA9IERvbWFpbi5tYWtlIDAgTmF0aXZlaW50Lnplcm8gcG9ydCBpbnRlcmZhY2UgZG9t cy5ldmVudGNobiBpbg0KPiAJSGFzaHRibC5hZGQgZG9tcy50YWJsZSAwIGRvbTsNCj4gLQlEb21h aW4uYmluZF9pbnRlcmRvbWFpbiBkb207DQo+ICsJbWF5YmVfYmluZF9pbnRlcmRvbWFpbiByZXN0 b3JlX2xvY2FscG9ydCBkb207DQo+IAlEb21haW4ubm90aWZ5IGRvbTsNCj4gCWRvbQ0KPiANCj4g ZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9ldmVudC5tbCBiL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9ldmVudC5tbA0KPiBpbmRleCBjY2NhOTBiNmZjNGYuLjAxNTlkYWFjOTFmNCAx MDA2NDQNCj4gLS0tIGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2V2ZW50Lm1sDQo+ICsrKyBiL3Rv b2xzL29jYW1sL3hlbnN0b3JlZC9ldmVudC5tbA0KPiBAQCAtMjAsNyArMjAsMTMgQEAgdHlwZSB0 ID0gew0KPiAJbXV0YWJsZSB2aXJxX3BvcnQ6IFhlbmV2ZW50Y2huLnQgb3B0aW9uOw0KPiB9DQo+ IA0KPiAtbGV0IGluaXQgKCkgPSB7IGhhbmRsZSA9IFhlbmV2ZW50Y2huLmluaXQgKCk7IHZpcnFf cG9ydCA9IE5vbmU7IH0NCj4gK2xldCBpbml0ID9mZCAoKSA9DQo+ICsJbGV0IGhhbmRsZSA9IG1h dGNoIGZkIHdpdGgNCj4gKwkJfCBOb25lIC0+IFhlbmV2ZW50Y2huLmluaXQgfmNsb2V4ZWM6ZmFs c2UgKCkNCj4gKwkJfCBTb21lIGZkIC0+IFhlbmV2ZW50Y2huLmZkb3BlbiBmZA0KPiArCWluDQo+ ICsJeyBoYW5kbGU7IHZpcnFfcG9ydCA9IE5vbmUgfQ0KPiArDQo+IGxldCBmZCBldmVudGNobiA9 IFhlbmV2ZW50Y2huLmZkIGV2ZW50Y2huLmhhbmRsZQ0KPiBsZXQgYmluZF9kb21fZXhjX3ZpcnEg ZXZlbnRjaG4gPSBldmVudGNobi52aXJxX3BvcnQgPC0gU29tZSAoWGVuZXZlbnRjaG4uYmluZF9k b21fZXhjX3ZpcnEgZXZlbnRjaG4uaGFuZGxlKQ0KPiBsZXQgYmluZF9pbnRlcmRvbWFpbiBldmVu dGNobiBkb21pZCBwb3J0ID0gWGVuZXZlbnRjaG4uYmluZF9pbnRlcmRvbWFpbiBldmVudGNobi5o YW5kbGUgZG9taWQgcG9ydA0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3hl bnN0b3JlZC5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC94ZW5zdG9yZWQubWwNCj4gaW5kZXgg YzVkYzdhMjhkMDgyLi42Y2VhYjAyZGVlMWUgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL29jYW1sL3hl bnN0b3JlZC94ZW5zdG9yZWQubWwNCj4gKysrIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0 b3JlZC5tbA0KPiBAQCAtMTQ0LDcgKzE0NCw3IEBAIGV4Y2VwdGlvbiBCYWRfZm9ybWF0IG9mIHN0 cmluZw0KPiANCj4gbGV0IGR1bXBfZm9ybWF0X2hlYWRlciA9ICIkeGVuc3RvcmVkLWR1bXAtZm9y bWF0Ig0KPiANCj4gLWxldCBmcm9tX2NoYW5uZWxfZiBjaGFuIGdsb2JhbF9mIHNvY2tldF9mIGRv bWFpbl9mIHdhdGNoX2Ygc3RvcmVfZiA9DQo+ICtsZXQgZnJvbV9jaGFubmVsX2YgY2hhbiBnbG9i YWxfZiBldmVudF9mIHNvY2tldF9mIGRvbWFpbl9mIHdhdGNoX2Ygc3RvcmVfZiA9DQo+IAlsZXQg dW5oZXhpZnkgcyA9IFV0aWxzLnVuaGV4aWZ5IHMgaW4NCj4gCWxldCBnZXRwYXRoIHMgPQ0KPiAJ CWxldCB1ID0gVXRpbHMudW5oZXhpZnkgcyBpbg0KPiBAQCAtMTY1LDEyICsxNjUsMTcgQEAgbGV0 IGZyb21fY2hhbm5lbF9mIGNoYW4gZ2xvYmFsX2Ygc29ja2V0X2YgZG9tYWluX2Ygd2F0Y2hfZiBz dG9yZV9mID0NCj4gCQkJCQkoKiB0aGVyZSBtaWdodCBiZSBtb3JlIHBhcmFtZXRlcnMgaGVyZSwN Cj4gCQkJCQkgICBlLmcuIGEgUk8gc29ja2V0IGZyb20gYSBwcmV2aW91cyB2ZXJzaW9uOiBpZ25v cmUgaXQgKikNCj4gCQkJCQlnbG9iYWxfZiB+cncNCj4gKwkJCQl8ICJldmVudGZkIiA6OiBldmVu dGZkIDo6IFtdIC0+DQo+ICsJCQkJCWV2ZW50X2YgfmV2ZW50ZmQNCj4gCQkJCXwgInNvY2tldCIg OjogZmQgOjogW10gLT4NCj4gCQkJCQlzb2NrZXRfZiB+ZmQ6KGludF9vZl9zdHJpbmcgZmQpDQo+ IC0JCQkJfCAiZG9tIiA6OiBkb21pZCA6OiBtZm4gOjogcG9ydCA6OiBbXS0+DQo+ICsJCQkJfCAi ZG9tIiA6OiBkb21pZCA6OiBtZm4gOjogcG9ydCA6OiByZXN0IC0+DQo+IAkJCQkJZG9tYWluX2Yg KGludF9vZl9zdHJpbmcgZG9taWQpDQo+IAkJCQkJICAgICAgICAgKE5hdGl2ZWludC5vZl9zdHJp bmcgbWZuKQ0KPiAJCQkJCSAgICAgICAgIChpbnRfb2Zfc3RyaW5nIHBvcnQpDQo+ICsJCQkJCQkg KG1hdGNoIHJlc3Qgd2l0aA0KPiArCQkJCQkJICB8IFtdIC0+IE5vbmUgKCogYmFja3dhcmQgY29t cGF0OiBvbGQgdmVyc2lvbiBkaWRuJ3QgaGF2ZSBpdCAqKQ0KPiArCQkJCQkJICB8IGxvY2FscG9y dCA6OiBfIC0+IFNvbWUgKGludF9vZl9zdHJpbmcgbG9jYWxwb3J0KSkNCj4gCQkJCXwgIndhdGNo IiA6OiBkb21pZCA6OiBwYXRoIDo6IHRva2VuIDo6IFtdIC0+DQo+IAkJCQkJd2F0Y2hfZiAoaW50 X29mX3N0cmluZyBkb21pZCkNCj4gCQkJCQkgICAgICAgICh1bmhleGlmeSBwYXRoKSAodW5oZXhp ZnkgdG9rZW4pDQo+IEBAIC0xODksMTAgKzE5NCwyNyBAQCBsZXQgZnJvbV9jaGFubmVsX2YgY2hh biBnbG9iYWxfZiBzb2NrZXRfZiBkb21haW5fZiB3YXRjaF9mIHN0b3JlX2YgPQ0KPiAJZG9uZTsN Cj4gCWluZm8gIkNvbXBsZXRlZCBsb2FkaW5nIHhlbnN0b3JlIGR1bXAiDQo+IA0KPiAtbGV0IGZy b21fY2hhbm5lbCBzdG9yZSBjb25zIGRvbXMgY2hhbiA9DQo+ICtsZXQgZnJvbV9jaGFubmVsIHN0 b3JlIGNvbnMgY3JlYXRlZG9tcyBjaGFuID0NCj4gCSgqIGRvbid0IGxldCB0aGUgcGVybWlzc2lv biBnZXQgb24gb3VyIHdheSwgZnVsbCBwZXJtICEgKikNCj4gCWxldCBvcCA9IFN0b3JlLmdldF9v cHMgc3RvcmUgUGVybXMuQ29ubmVjdGlvbi5mdWxsX3JpZ2h0cyBpbg0KPiAJbGV0IHJ3cm8gPSBy ZWYgKE5vbmUpIGluDQo+ICsJbGV0IGV2ZW50Y2huZmQgPSByZWYgKE5vbmUpIGluDQoNCk5vIHBh cmVudGhlc2lzIHJlcXVpcmVkOiAicmVmIE5vbmXigJ0gd291bGQgYmUgZW5vdWdoLiBCdXQgZG9u 4oCZdCBib3RoZXIgLSBvbmNlIHdlIHVzZSBPQ2FtbGZvcm1hdCBpbnN0YW5jZXMgbGlrZSB0aGVz ZSB3aWxsIGJlIHBpY2tlZCB1cC4NCg0KDQo+ICsJbGV0IGRvbXMgPSByZWYgKE5vbmUpIGluDQo+ ICsNCj4gKwlsZXQgcmVxdWlyZV9kb21zICgpID0NCj4gKwkJbWF0Y2ggIWRvbXMgd2l0aA0KPiAr CQl8IE5vbmUgLT4NCg0KQWx0ZXJuYXRpdmUgY291bGQgYmU6DQp8IE5vbmUgd2hlbiAhZXZlbnRj aG5mZCA9IE5vbmUgLT4NCiAuLi4NCnwgTm9uZSAtPg0KIC4uLg0KfCBTb21lIGQgLT4gZA0KDQoN Cg0KPiArCQkJbGV0IG1pc3NpbmdfZXZlbnRjaG5mZCA9ICFldmVudGNobmZkID0gTm9uZSBpbg0K PiArCQkJaWYgbWlzc2luZ19ldmVudGNobmZkIHRoZW4NCj4gKwkJCQl3YXJuICJObyBldmVudCBj aGFubmVsIGZpbGUgZGVzY3JpcHRvciBhdmFpbGFibGUgaW4gZHVtcCEiOw0KPiArCQkJbGV0IGV2 ZW50Y2huID0gRXZlbnQuaW5pdCA/ZmQ6IWV2ZW50Y2huZmQgKCkgaW4NCj4gKwkJCWxldCBkb21h aW5zID0gY3JlYXRlZG9tcyBldmVudGNobiBpbg0KPiArCQkJaWYgbWlzc2luZ19ldmVudGNobmZk IHRoZW4NCj4gKwkJCQlFdmVudC5iaW5kX2RvbV9leGNfdmlycSBldmVudGNobjsNCj4gKwkJCWRv bXMgOj0gU29tZSBkb21haW5zOw0KPiArCQkJZG9tYWlucw0KPiArCQl8IFNvbWUgZCAtPiBkDQo+ ICsJaW4NCj4gCWxldCBnbG9iYWxfZiB+cncgPQ0KPiAJCWxldCBnZXRfbGlzdGVuX3NvY2sgc29j a2ZkID0NCj4gCQkJbGV0IGZkID0gc29ja2ZkIHw+IGludF9vZl9zdHJpbmcgfD4gVXRpbHMuRkQu b2ZfaW50IGluDQo+IEBAIC0yMDEsNiArMjIzLDEwIEBAIGxldCBmcm9tX2NoYW5uZWwgc3RvcmUg Y29ucyBkb21zIGNoYW4gPQ0KPiAJCWluDQo+IAkJcndybyA6PSBnZXRfbGlzdGVuX3NvY2sgcncN Cj4gCWluDQo+ICsJbGV0IGV2ZW50X2YgfmV2ZW50ZmQgPQ0KPiArCQlsZXQgZmQgPSBldmVudGZk IHw+IGludF9vZl9zdHJpbmcgfD4gVXRpbHMuRkQub2ZfaW50IGluDQo+ICsJCWV2ZW50Y2huZmQg Oj0gU29tZSBmZA0KPiArCWluDQo+IAlsZXQgc29ja2V0X2YgfmZkID0NCj4gCQlsZXQgdWZkID0g VXRpbHMuRkQub2ZfaW50IGZkIGluDQo+IAkJbGV0IGlzX3ZhbGlkID0gdHJ5IChVbml4LmZzdGF0 IHVmZCkuVW5peC5zdF9raW5kID0gVW5peC5TX1NPQ0sgd2l0aCBfIC0+IGZhbHNlIGluDQo+IEBA IC0yMDksMTIgKzIzNSwxMyBAQCBsZXQgZnJvbV9jaGFubmVsIHN0b3JlIGNvbnMgZG9tcyBjaGFu ID0NCj4gCQllbHNlDQo+IAkJCXdhcm4gIklnbm9yaW5nIGludmFsaWQgc29ja2V0IEZEICVkIiBm ZA0KPiAJaW4NCj4gLQlsZXQgZG9tYWluX2YgZG9taWQgbWZuIHBvcnQgPQ0KPiArCWxldCBkb21h aW5fZiBkb21pZCBtZm4gcG9ydCByZXN0b3JlX2xvY2FscG9ydCA9DQo+ICsJCWxldCBkb21zID0g cmVxdWlyZV9kb21zICgpIGluDQo+IAkJbGV0IG5kb20gPQ0KPiAJCQlpZiBkb21pZCA+IDAgdGhl bg0KPiAtCQkJCURvbWFpbnMuY3JlYXRlIGRvbXMgZG9taWQgbWZuIHBvcnQNCj4gKwkJCQlEb21h aW5zLmNyZWF0ZSBkb21zIGRvbWlkIG1mbiA/cmVzdG9yZV9sb2NhbHBvcnQgcG9ydA0KPiAJCQll bHNlDQo+IC0JCQkJRG9tYWlucy5jcmVhdGUwIGRvbXMNCj4gKwkJCQlEb21haW5zLmNyZWF0ZTAg P3Jlc3RvcmVfbG9jYWxwb3J0IGRvbXMNCj4gCQkJaW4NCj4gCQlDb25uZWN0aW9ucy5hZGRfZG9t YWluIGNvbnMgbmRvbTsNCj4gCQlpbg0KPiBAQCAtMjI5LDggKzI1Niw4IEBAIGxldCBmcm9tX2No YW5uZWwgc3RvcmUgY29ucyBkb21zIGNoYW4gPQ0KPiAJCW9wLlN0b3JlLndyaXRlIHBhdGggdmFs dWU7DQo+IAkJb3AuU3RvcmUuc2V0cGVybXMgcGF0aCBwZXJtcw0KPiAJCWluDQo+IC0JZnJvbV9j aGFubmVsX2YgY2hhbiBnbG9iYWxfZiBzb2NrZXRfZiBkb21haW5fZiB3YXRjaF9mIHN0b3JlX2Y7 DQo+IC0JIXJ3cm8NCj4gKwlmcm9tX2NoYW5uZWxfZiBjaGFuIGdsb2JhbF9mIGV2ZW50X2Ygc29j a2V0X2YgZG9tYWluX2Ygd2F0Y2hfZiBzdG9yZV9mOw0KPiArCSFyd3JvLCByZXF1aXJlX2RvbXMg KCkNCj4gDQo+IGxldCBmcm9tX2ZpbGUgc3RvcmUgY29ucyBkb21zIGZpbGUgPQ0KPiAJaW5mbyAi TG9hZGluZyB4ZW5zdG9yZSBkdW1wIGZyb20gJXMiIGZpbGU7DQo+IEBAIC0yMzgsNyArMjY1LDcg QEAgbGV0IGZyb21fZmlsZSBzdG9yZSBjb25zIGRvbXMgZmlsZSA9DQo+IAlmaW5hbGx5IChmdW4g KCkgLT4gZnJvbV9jaGFubmVsIHN0b3JlIGRvbXMgY29ucyBjaGFubmVsKQ0KPiAJICAgICAgICAo ZnVuICgpIC0+IGNsb3NlX2luIGNoYW5uZWwpDQo+IA0KPiAtbGV0IHRvX2NoYW5uZWwgc3RvcmUg Y29ucyBydyBjaGFuID0NCj4gK2xldCB0b19jaGFubmVsIHN0b3JlIGNvbnMgKHJ3LCBldmVudGNo bikgY2hhbiA9DQo+IAlsZXQgaGV4aWZ5IHMgPSBVdGlscy5oZXhpZnkgcyBpbg0KPiANCj4gCWZw cmludGYgY2hhbiAiJXNcbiIgZHVtcF9mb3JtYXRfaGVhZGVyOw0KPiBAQCAtMjQ3LDYgKzI3NCw3 IEBAIGxldCB0b19jaGFubmVsIHN0b3JlIGNvbnMgcncgY2hhbiA9DQo+IAkJVW5peC5jbGVhcl9j bG9zZV9vbl9leGVjIGZkOw0KPiAJCVV0aWxzLkZELnRvX2ludCBmZCBpbg0KPiAJZnByaW50ZiBj aGFuICJnbG9iYWwsJWRcbiIgKGZkb3B0IHJ3KTsNCj4gKwlmcHJpbnRmIGNoYW4gImV2ZW50Y2hu ZmQsJWRcbiIgKFV0aWxzLkZELnRvX2ludCBAQCBFdmVudC5mZCBldmVudGNobik7DQo+IA0KPiAJ KCogZHVtcCBjb25uZWN0aW9ucyByZWxhdGVkIHRvIGRvbWFpbnM6IGRvbWlkLCBtZm4sIGV2ZW50 Y2huIHBvcnQvIHNvY2tldHMsIGFuZCB3YXRjaGVzICopDQo+IAlDb25uZWN0aW9ucy5pdGVyIGNv bnMgKGZ1biBjb24gLT4gQ29ubmVjdGlvbi5kdW1wIGNvbiBjaGFuKTsNCj4gQEAgLTM2Nyw3ICsz OTUsNiBAQCBsZXQgXyA9DQo+IAl8IE5vbmUgICAgICAgICAtPiAoKSBlbmQ7DQo+IA0KPiAJbGV0 IHN0b3JlID0gU3RvcmUuY3JlYXRlICgpIGluDQo+IC0JbGV0IGV2ZW50Y2huID0gRXZlbnQuaW5p dCAoKSBpbg0KPiAJbGV0IG5leHRfZnJlcXVlbnRfb3BzID0gcmVmIDAuIGluDQo+IAlsZXQgYWR2 YW5jZV9uZXh0X2ZyZXF1ZW50X29wcyAoKSA9DQo+IAkJbmV4dF9mcmVxdWVudF9vcHMgOj0gKFVu aXguZ2V0dGltZW9mZGF5ICgpICsuICFEZWZpbmUuY29uZmxpY3RfbWF4X2hpc3Rvcnlfc2Vjb25k cykNCj4gQEAgLTM3NSwxNiArNDAyLDggQEAgbGV0IF8gPQ0KPiAJbGV0IGRlbGF5X25leHRfZnJl cXVlbnRfb3BzX2J5IGR1cmF0aW9uID0NCj4gCQluZXh0X2ZyZXF1ZW50X29wcyA6PSAhbmV4dF9m cmVxdWVudF9vcHMgKy4gZHVyYXRpb24NCj4gCWluDQo+IC0JbGV0IGRvbWFpbnMgPSBEb21haW5z LmluaXQgZXZlbnRjaG4gYWR2YW5jZV9uZXh0X2ZyZXF1ZW50X29wcyBpbg0KPiArCWxldCBkb21h aW5zIGV2ZW50Y2huID0gRG9tYWlucy5pbml0IGV2ZW50Y2huIGFkdmFuY2VfbmV4dF9mcmVxdWVu dF9vcHMgaW4NCj4gDQo+IC0JKCogRm9yIHRoaW5ncyB0aGF0IG5lZWQgdG8gYmUgZG9uZSBwZXJp b2RpY2FsbHkgYnV0IG1vcmUgb2Z0ZW4NCj4gLQkgKiB0aGFuIHRoZSBwZXJpb2RpY19vcHMgZnVu Y3Rpb24gKikNCj4gLQlsZXQgZnJlcXVlbnRfb3BzICgpID0NCj4gLQkJaWYgVW5peC5nZXR0aW1l b2ZkYXkgKCkgPiAhbmV4dF9mcmVxdWVudF9vcHMgdGhlbiAoDQo+IC0JCQlIaXN0b3J5LnRyaW0g KCk7DQo+IC0JCQlEb21haW5zLmluY3JfY29uZmxpY3RfY3JlZGl0IGRvbWFpbnM7DQo+IC0JCQlh ZHZhbmNlX25leHRfZnJlcXVlbnRfb3BzICgpDQo+IC0JCSkgaW4NCj4gCWxldCBjb25zID0gQ29u bmVjdGlvbnMuY3JlYXRlICgpIGluDQo+IA0KPiAJbGV0IHF1aXQgPSByZWYgZmFsc2UgaW4NCj4g QEAgLTM5MywxNSArNDEyLDE1IEBAIGxldCBfID0NCj4gCUxpc3QuaXRlciAoZnVuIHBhdGggLT4N Cj4gCQlTdG9yZS53cml0ZSBzdG9yZSBQZXJtcy5Db25uZWN0aW9uLmZ1bGxfcmlnaHRzIHBhdGgg IiIpIFN0b3JlLlBhdGguc3BlY2lhbHM7DQo+IA0KPiAtCWxldCByd19zb2NrID0NCj4gKwlsZXQg cndfc29jaywgZG9tYWlucyA9DQo+IAlpZiBjZi5yZXN0YXJ0ICYmIFN5cy5maWxlX2V4aXN0cyBE aXNrLnhzX2RhZW1vbl9kYXRhYmFzZSB0aGVuICgNCj4gLQkJbGV0IHJ3cm8gPSBEQi5mcm9tX2Zp bGUgc3RvcmUgZG9tYWlucyBjb25zIERpc2sueHNfZGFlbW9uX2RhdGFiYXNlIGluDQo+ICsJCWxl dCBydywgZG9tYWlucyA9IERCLmZyb21fZmlsZSBzdG9yZSBkb21haW5zIGNvbnMgRGlzay54c19k YWVtb25fZGF0YWJhc2UgaW4NCj4gCQlpbmZvICJMaXZlIHJlbG9hZDogZGF0YWJhc2UgbG9hZGVk IjsNCj4gLQkJRXZlbnQuYmluZF9kb21fZXhjX3ZpcnEgZXZlbnRjaG47DQo+IAkJUHJvY2Vzcy5M aXZlVXBkYXRlLmNvbXBsZXRlZCAoKTsNCj4gLQkJcndybw0KPiArCQlydywgZG9tYWlucw0KPiAJ KSBlbHNlICgNCj4gCQlpbmZvICJObyBsaXZlIHJlbG9hZDogcmVndWxhciBzdGFydHVwIjsNCj4g KwkJbGV0IGRvbWFpbnMgPSBkb21haW5zIEBAIEV2ZW50LmluaXQgKCkgaW4NCj4gCQlpZiAhRGlz ay5lbmFibGUgdGhlbiAoDQo+IAkJCWluZm8gInJlYWRpbmcgc3RvcmUgZnJvbSBkaXNrIjsNCj4g CQkJRGlzay5yZWFkIHN0b3JlDQo+IEBAIC00MTEsMTMgKzQzMCwyMyBAQCBsZXQgXyA9DQo+IAkJ aWYgbm90IChTdG9yZS5wYXRoX2V4aXN0cyBzdG9yZSBsb2NhbHBhdGgpIHRoZW4NCj4gCQkJU3Rv cmUubWtkaXIgc3RvcmUgKFBlcm1zLkNvbm5lY3Rpb24uY3JlYXRlIDApIGxvY2FscGF0aDsNCj4g DQo+ICsJCWxldCBldmVudGNobiA9IEV2ZW50LmluaXQgKCkgaW4NCj4gCQlpZiBjZi5kb21haW5f aW5pdCB0aGVuICgNCj4gCQkJQ29ubmVjdGlvbnMuYWRkX2RvbWFpbiBjb25zIChEb21haW5zLmNy ZWF0ZTAgZG9tYWlucyk7DQo+IAkJCUV2ZW50LmJpbmRfZG9tX2V4Y192aXJxIGV2ZW50Y2huDQo+ IAkJKTsNCj4gLQkJcndfc29jaw0KPiArCQlyd19zb2NrLCBkb21haW5zDQo+IAkpIGluDQo+IA0K PiArCSgqIEZvciB0aGluZ3MgdGhhdCBuZWVkIHRvIGJlIGRvbmUgcGVyaW9kaWNhbGx5IGJ1dCBt b3JlIG9mdGVuDQo+ICsJICogdGhhbiB0aGUgcGVyaW9kaWNfb3BzIGZ1bmN0aW9uICopDQo+ICsJ bGV0IGZyZXF1ZW50X29wcyAoKSA9DQo+ICsJCWlmIFVuaXguZ2V0dGltZW9mZGF5ICgpID4gIW5l eHRfZnJlcXVlbnRfb3BzIHRoZW4gKA0KPiArCQkJSGlzdG9yeS50cmltICgpOw0KPiArCQkJRG9t YWlucy5pbmNyX2NvbmZsaWN0X2NyZWRpdCBkb21haW5zOw0KPiArCQkJYWR2YW5jZV9uZXh0X2Zy ZXF1ZW50X29wcyAoKQ0KPiArCQkpIGluDQo+ICsNCj4gCSgqIHJlcXVpcmVkIGZvciB4ZW5zdG9y ZS1jb250cm9sIHRvIGRldGVjdCBhdmFpbGFiaWxpdHkgb2YgbGl2ZS11cGRhdGUgKikNCj4gCWxl dCB0b29sX3BhdGggPSBTdG9yZS5QYXRoLm9mX3N0cmluZyAiL3Rvb2wiIGluDQo+IAlpZiBub3Qg KFN0b3JlLnBhdGhfZXhpc3RzIHN0b3JlIHRvb2xfcGF0aCkgdGhlbg0KPiBAQCAtNDMzLDEwICs0 NjIsMTEgQEAgbGV0IF8gPQ0KPiAJU3lzLnNldF9zaWduYWwgU3lzLnNpZ3BpcGUgU3lzLlNpZ25h bF9pZ25vcmU7DQo+IA0KPiAJaWYgY2YuYWN0aXZhdGVfYWNjZXNzX2xvZyB0aGVuIGJlZ2luDQo+ IC0JCWxldCBwb3N0X3JvdGF0ZSAoKSA9IERCLnRvX2ZpbGUgc3RvcmUgY29ucyAoTm9uZSkgRGlz ay54c19kYWVtb25fZGF0YWJhc2UgaW4NCj4gKwkJbGV0IHBvc3Rfcm90YXRlICgpID0gREIudG9f ZmlsZSBzdG9yZSBjb25zIChOb25lLCBEb21haW5zLmV2ZW50Y2huIGRvbWFpbnMpIERpc2sueHNf ZGFlbW9uX2RhdGFiYXNlIGluDQo+IAkJTG9nZ2luZy5pbml0X2FjY2Vzc19sb2cgcG9zdF9yb3Rh dGUNCj4gCWVuZDsNCj4gDQo+ICsJbGV0IGV2ZW50Y2huID0gRG9tYWlucy5ldmVudGNobiBkb21h aW5zIGluDQo+IAlsZXQgc3BlY19mZHMgPQ0KPiAJCShtYXRjaCByd19zb2NrIHdpdGggTm9uZSAt PiBbXSB8IFNvbWUgeCAtPiBbIHggXSkgQA0KPiAJCShpZiBjZi5kb21haW5faW5pdCB0aGVuIFsg RXZlbnQuZmQgZXZlbnRjaG4gXSBlbHNlIFtdKQ0KPiBAQCAtNTk1LDcgKzYyNSw3IEBAIGxldCBf ID0NCj4gCQkJbGl2ZV91cGRhdGUgOj0gUHJvY2Vzcy5MaXZlVXBkYXRlLnNob3VsZF9ydW4gY29u czsNCj4gCQkJaWYgIWxpdmVfdXBkYXRlIHx8ICFxdWl0IHRoZW4gYmVnaW4NCj4gCQkJCSgqIGRv bid0IGluaXRpYXRlIGxpdmUgdXBkYXRlIGlmIHNhdmluZyBzdGF0ZSBmYWlscyAqKQ0KPiAtCQkJ CURCLnRvX2ZpbGUgc3RvcmUgY29ucyAocndfc29jaykgRGlzay54c19kYWVtb25fZGF0YWJhc2U7 DQo+ICsJCQkJREIudG9fZmlsZSBzdG9yZSBjb25zIChyd19zb2NrLCBldmVudGNobikgRGlzay54 c19kYWVtb25fZGF0YWJhc2U7DQo+IAkJCQlxdWl0IDo9IHRydWU7DQo+IAkJCWVuZA0KPiAJCXdp dGggZXhjIC0+DQo+IC0tIA0KPiAyLjExLjANCj4gDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 23 11:45:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 11:45:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447527.703839 (Exim 4.92) (envelope-from ) id 1oxoC0-0004ax-3s; Wed, 23 Nov 2022 11:45:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447527.703839; Wed, 23 Nov 2022 11:45:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxoC0-0004aq-1C; Wed, 23 Nov 2022 11:45:28 +0000 Received: by outflank-mailman (input) for mailman id 447527; Wed, 23 Nov 2022 11:45:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxoBz-0004ak-3W for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 11:45:27 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51fca572-6b24-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 12:45:25 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 48CE221F33; Wed, 23 Nov 2022 11:45:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E31CB13A37; Wed, 23 Nov 2022 11:45:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6+UDNtQHfmPTUwAAMHmgww (envelope-from ); Wed, 23 Nov 2022 11:45:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51fca572-6b24-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669203925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=AyhBQAsNxho2kk1GfKGx6zDLyWYyV1QLz+gDG7NJTZA=; b=Zkn7ZzDpoCCf/JgfLleT4uX7j1LVB22KCBz2YLwsoyCKxzEJYFLn6dS2KCoYG/ZDbmrWKd M6vUekyG/a2ld98xp97yxvtjLIwhLz4IRtOgVFz2nFKxZyiNNfQBdi3lyMXNpdB8zeg/Yc ejYMSHpqTF7xKsKSpz0Z4TJdktOrVNE= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , xen-devel@lists.xenproject.org Subject: [PATCH v3] x86/boot: skip realmode init code when running as Xen PV guest Date: Wed, 23 Nov 2022 12:45:23 +0100 Message-Id: <20221123114523.3467-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When running as a Xen PV guest there is no need for setting up the realmode trampoline, as realmode isn't supported in this environment. Trying to setup the trampoline has been proven to be problematic in some cases, especially when trying to debug early boot problems with Xen requiring to keep the EFI boot-services memory mapped (some firmware variants seem to claim basically all memory below 1M for boot services). Introduce new x86_platform_ops operations for that purpose, which can be set to a nop by the Xen PV specific kernel boot code. Fixes: 084ee1c641a0 ("x86, realmode: Relocator for realmode code") Suggested-by: H. Peter Anvin Signed-off-by: Juergen Gross --- V3: - and yet another approach (H. Peter Anvin) --- arch/x86/include/asm/realmode.h | 1 + arch/x86/include/asm/x86_init.h | 4 ++++ arch/x86/kernel/setup.c | 2 +- arch/x86/kernel/x86_init.c | 3 +++ arch/x86/realmode/init.c | 8 ++++++-- arch/x86/xen/enlighten_pv.c | 2 ++ 6 files changed, 17 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/realmode.h b/arch/x86/include/asm/realmode.h index fd6f6e5b755a..a336feef0af1 100644 --- a/arch/x86/include/asm/realmode.h +++ b/arch/x86/include/asm/realmode.h @@ -91,6 +91,7 @@ static inline void set_real_mode_mem(phys_addr_t mem) void reserve_real_mode(void); void load_trampoline_pgtable(void); +void init_real_mode(void); #endif /* __ASSEMBLY__ */ diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h index e9170457697e..c1c8c581759d 100644 --- a/arch/x86/include/asm/x86_init.h +++ b/arch/x86/include/asm/x86_init.h @@ -285,6 +285,8 @@ struct x86_hyper_runtime { * possible in x86_early_init_platform_quirks() by * only using the current x86_hardware_subarch * semantics. + * @realmode_reserve: reserve memory for realmode trampoline + * @realmode_init: initialize realmode trampoline * @hyper: x86 hypervisor specific runtime callbacks */ struct x86_platform_ops { @@ -301,6 +303,8 @@ struct x86_platform_ops { void (*apic_post_init)(void); struct x86_legacy_features legacy; void (*set_legacy_features)(void); + void (*realmode_reserve)(void); + void (*realmode_init)(void); struct x86_hyper_runtime hyper; struct x86_guest guest; }; diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index 216fee7144ee..892609cde4a2 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -1175,7 +1175,7 @@ void __init setup_arch(char **cmdline_p) * Moreover, on machines with SandyBridge graphics or in setups that use * crashkernel the entire 1M is reserved anyway. */ - reserve_real_mode(); + x86_platform.realmode_reserve(); init_mem_mapping(); diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c index 57353519bc11..ef80d361b463 100644 --- a/arch/x86/kernel/x86_init.c +++ b/arch/x86/kernel/x86_init.c @@ -25,6 +25,7 @@ #include #include #include +#include void x86_init_noop(void) { } void __init x86_init_uint_noop(unsigned int unused) { } @@ -145,6 +146,8 @@ struct x86_platform_ops x86_platform __ro_after_init = { .get_nmi_reason = default_get_nmi_reason, .save_sched_clock_state = tsc_save_sched_clock_state, .restore_sched_clock_state = tsc_restore_sched_clock_state, + .realmode_reserve = reserve_real_mode, + .realmode_init = init_real_mode, .hyper.pin_vcpu = x86_op_int_noop, .guest = { diff --git a/arch/x86/realmode/init.c b/arch/x86/realmode/init.c index 41d7669a97ad..247aca9f8ed1 100644 --- a/arch/x86/realmode/init.c +++ b/arch/x86/realmode/init.c @@ -200,14 +200,18 @@ static void __init set_real_mode_permissions(void) set_memory_x((unsigned long) text_start, text_size >> PAGE_SHIFT); } -static int __init init_real_mode(void) +void __init init_real_mode(void) { if (!real_mode_header) panic("Real mode trampoline was not allocated"); setup_real_mode(); set_real_mode_permissions(); +} +static int __init call_init_real_mode(void) +{ + x86_platform.realmode_init(); return 0; } -early_initcall(init_real_mode); +early_initcall(call_init_real_mode); diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 038da45f057a..8944726255c9 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -1266,6 +1266,8 @@ asmlinkage __visible void __init xen_start_kernel(struct start_info *si) xen_vcpu_info_reset(0); x86_platform.get_nmi_reason = xen_get_nmi_reason; + x86_platform.realmode_reserve = x86_init_noop; + x86_platform.realmode_init = x86_init_noop; x86_init.resources.memory_setup = xen_memory_setup; x86_init.irqs.intr_mode_select = x86_init_noop; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 11:56:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 11:56:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447531.703851 (Exim 4.92) (envelope-from ) id 1oxoMR-0006Cl-3x; Wed, 23 Nov 2022 11:56:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447531.703851; Wed, 23 Nov 2022 11:56:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxoMR-0006Ce-0b; Wed, 23 Nov 2022 11:56:15 +0000 Received: by outflank-mailman (input) for mailman id 447531; Wed, 23 Nov 2022 11:56:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxoMP-0006CY-6r for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 11:56:13 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2060c.outbound.protection.outlook.com [2a01:111:f400:7e8a::60c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d119e4e7-6b25-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 12:56:09 +0100 (CET) Received: from BN9PR03CA0647.namprd03.prod.outlook.com (2603:10b6:408:13b::22) by DM4PR12MB5939.namprd12.prod.outlook.com (2603:10b6:8:6a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 11:56:05 +0000 Received: from BN8NAM11FT035.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13b:cafe::d5) by BN9PR03CA0647.outlook.office365.com (2603:10b6:408:13b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15 via Frontend Transport; Wed, 23 Nov 2022 11:56:05 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT035.mail.protection.outlook.com (10.13.177.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.17 via Frontend Transport; Wed, 23 Nov 2022 11:56:04 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 23 Nov 2022 05:56:04 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 23 Nov 2022 03:55:41 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 23 Nov 2022 05:55:40 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d119e4e7-6b25-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I4ohfH7hPJuJgjjwGq4GWIXhVrPOFmtsdaEbEFvKsCGPpR3KkVS8rZdvecuqkD8Cf2/k33cDfDz1IXzRaOEzVnFv/1RgJ34Jq8KfzfgFF6ik5uGzsH3MN++roMWL1gxx8G1xINaJHU/hAgdIWxzcNFaj7OQVT1zTp9MRW6cW/lu+8VILUXUwcyESY2hGyorj1usFVV9SbDQ59joGJYivirjBEh/K4ePba3QEjx3bjfkQhktMoi5dmJhDGxDBxiev52iJE7UDlI21+Crjhx4PtkWo2r7/NEqKI3OURa63bmmj6Lg3pu9XOmIh06vycVJ7mZg70cck4/2omU+y48H+ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=86NL5ohWvqF9C5W7vTd4ysara5FRkbSAMBGZKGKQt1k=; b=bOs7QYuKKxtkkDG5ei/kN7AFvgpICV8YIgCaOa5yV3Mh+6QIu6rjpclDl4SDwYa3fkQ/PRcchcJDQyHF9JBG01Xlz5/g4ZXgQSaOlM88EyjrEm4d7DyAPTKTu4fR5aN7y25VvJQD1DRqPHp3i/wACfeGWC/sEqqrdpznsgufI7IybGmwbXh1/hnW+NY4cYiSdceLRatQ3k85GCbqNrnBP70jH0bpJiFFzwNVIWYMdOnCi1wIZjfoZJPwqli5wWKz4/eBXtNwmwVmDpYmli2WUbeWg+ojUcjx5/j1I+vhRAW1/1g3Y+gMdIlxNZd7s+5G7kyn+PTffhl11MGPwzNnSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=86NL5ohWvqF9C5W7vTd4ysara5FRkbSAMBGZKGKQt1k=; b=bwnTRzczqNdRGRX+9zxJurkQJY29TtiEDN6q09bzzM/cLbzXJrVGa/fmL/EgvbE3xEOjpsD/uwob7aCVsUZtd/riv9WQVCUodlP6I5Rz3WfE2ny1m2xcq9P5n4MwvhvexXfy/Fu7TKEGQNuTY7SCq45TvDxak/VeXert+GPY7/Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <54111a37-9319-2497-ad64-2f47c4d69764@amd.com> Date: Wed, 23 Nov 2022 12:55:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v4 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" CC: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , "Stefano Stabellini" , Julien Grall , "Bertrand Marquis" , Community Manager References: <20221123040315.1480112-1-Henry.Wang@arm.com> <20221123040315.1480112-2-Henry.Wang@arm.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT035:EE_|DM4PR12MB5939:EE_ X-MS-Office365-Filtering-Correlation-Id: 64c91e47-0dd3-4051-ead8-08dacd49b343 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qw6skuIB2ti1nl8cAaS/mV24muDzWZsbAgyOOFVwSid6lOvBEY72GHNHL1Pl0BoUnptszQUXSsvk5lcw3Ctr56aMq5goTaSqDbmPAGb3xic1rCK7VYE/aexAwC+Uy/3taeOl7XIcFHjuRvRoIa0ozusNljMAb9bptZg0X+mvY/XI2UzQZhsbLxfXB6/heBWaRj3AyGv+p8OypWq+VCWLJ/6k2Km0ZiEc+2lTA/hrIIiGJvYvTVoM0+NZHjqnoPjNfs03+saA26OenBzjxHwxGyKbNwqyh/7W8/CjHa19Chw1AnJz7GY3l8IEOfDmjbeC7TxBlEXvZs1t9/e3m4j5Hf9Zh90jGNYWDRHqfiA9jgeNObu83qotkqKL/azt7ateODqYrVoSei/Qfd7CX7ehg+AArPgW4tnikntlWjDZQ1aLzpit2F2kFNkjCF32WMxdl3aGArE5FheCLkIJCzSbSFgSYzgqHFBd1lKw2kDrlDGW14aLVg0TmZak6B74mfOa4dQEA/kql/8MI8PboLm++jD92hsNiRn59oUhl1HwwWOz4szAeVIbQKeKP1HnyLTojYuH5MzBllNkxHPvYEpl+i8txAtEGqfbP7KCagsS+cjGfN4IZ9MUFV5f1iETTQCW54x0cmC79p1ctgYnKncMiJ6ngfpylsWCJqigdPHpAnTYhhTV+DJjGNLc4K8oYS9Re4zkQUQOE6oaroeSJYMUBwnqyZmMEdG+iKBlHl6Z6nC5XLLYCSSkQ7JUpil5WRuIGsdLiMI6QuDV+go1wavjyEcT1gNcpka8YIubnm+CyLD6aMbtsfQl3bAWESaAE1aKVhZJur4c/Qjtx9CC657bchhuKh1abWZgCUirAc5AX0E= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(136003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(31686004)(336012)(426003)(47076005)(2906002)(186003)(83380400001)(2616005)(53546011)(478600001)(86362001)(70586007)(31696002)(26005)(70206006)(4326008)(8676002)(36756003)(40480700001)(8936002)(5660300002)(44832011)(82310400005)(36860700001)(41300700001)(82740400003)(81166007)(356005)(54906003)(16576012)(110136005)(316002)(40460700003)(59356011)(207903002)(219803003)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 11:56:04.9913 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 64c91e47-0dd3-4051-ead8-08dacd49b343 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT035.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5939 Hi Henry, On 23/11/2022 11:46, Henry Wang wrote: > > > Hi Michal, > >> -----Original Message----- >> Subject: Re: [PATCH v4 1/3] CHANGELOG: Add missing entries for work during >> the 4.17 release >> Hi Henry, >> Looking at the "Added" section for the previous releases, we seem to >> mention the changes to CI (automation/) as well. >> Because there were quite a few changes done in this release, adding at least >> the following, can be beneficial (something to consider): >> - gitlab-ci automation: Fixes and improvements together with new tests > > I only saw CI entries in 4.15 release, but if you want to add this I am ok with that. The CI entries are present in both 4.15 and 4.16: 4.15: - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6 - CI loop: Add qemu-based dom0 / domU test for ARM - CI loop: Add dom0less aarch64 smoke test 4.16: - 32bit Arm builds to the gitlab-ci automated tests. - x86 full system tests to the gitlab-ci automated tests. > So I will wait for a day to see if people oppose this, if not I will add your suggested > sentence in v5. > > Kind regards, > Henry ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 23 12:03:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 12:03:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447536.703862 (Exim 4.92) (envelope-from ) id 1oxoTN-0007rr-0J; Wed, 23 Nov 2022 12:03:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447536.703862; Wed, 23 Nov 2022 12:03:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxoTM-0007rk-SX; Wed, 23 Nov 2022 12:03:24 +0000 Received: by outflank-mailman (input) for mailman id 447536; Wed, 23 Nov 2022 12:03:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxoTL-0007re-AC for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 12:03:23 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d19ed45d-6b26-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 13:03:20 +0100 (CET) Received: from mail-dm6nam11lp2168.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Nov 2022 07:03:17 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by CO1PR03MB5811.namprd03.prod.outlook.com (2603:10b6:303:91::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 12:03:15 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 12:03:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d19ed45d-6b26-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669205000; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=BQQrbNel6RTWED+VCV4GUlkox+SV94ejzqtilabQk6w=; b=c4rOrlkuFglTLAG4SA8tR41QIfuAu2rI7DF4HfdJX6aLxA343VKk/NF6 4RHvXlHWDpoXn9HBMsz0EO7VZY5JYs45Hnv0CxWpKP4fj/CvaWhHo1PPl qXzCCBDxplX9Z1co/TDEtcE5hhfTbAJU52KZl+16L4s+Wq6umgZw6UECR M=; X-IronPort-RemoteIP: 104.47.57.168 X-IronPort-MID: 85832736 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:m+6RtaBteIgivxVW/xziw5YqxClBgxIJ4kV8jS/XYbTApD0hhjcCy 2FMXm7UP/mPMTfxeN92b4Xi9koP6p7Vnd82QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpC5QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwvfZmJ0px2 +cjLHNXXjqsvb6/346Dc7w57igjBJGD0II3nFhFlGicIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+uxuvTi7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLVryL33LCUw0sXXqoMG+yE2d5qm2efmGwrIiA5XmaYiPSm3xvWt9V3b hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JPF8Uq5QfLzbDbiy6BD3UAZi5MbpohrsBebSwn0 BqFks3kARRrsaaJUjSN+7GMtzSwNCMJa2gYakc5oRAt5tDipMQ/i0zJR9M6Saqt1ISrSXf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxodu51knHpU KA4pvWj IronPort-HdrOrdr: A9a23:9rpCgqE+jipImL7+pLqFiJLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH PQ3LswmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzI39QWUijusybjiVzyVxA0XXT9jyaortT GtqX2y2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuQFNzn2jQ6sRYJ5H5mPpio8ru2D4Esj1P PMvxAjFcJu7G65RBD/nTLdny3blBo+4X7rzlGVxVPlvMzCXTo/T+5Mn5hQfBf141cp+IgU6t MC40up875sST/QliX04NbFEzlsi0qPuHIn1coelWZWX4cyYKJY6aYf4ERWOpEdGz+S0vFvLM BeSOXnoNpGe1KTaH7U+kFp3dyXR3w2WiyLR0AT0/blpgR+rTRc9Q811cYflnAP+NYWUJ9f/d nJNaxuifVnUtIWRbgVPpZOfeKHTkj2BT7cOmObJlrqUIsdPWjWlpLx6LIpoMm3ZZ0zyocokp ipaiIWiYcLQTOvNSSy5uwJzviUK1/NHwgFi/suq6SRg4eMBYYCaka4ORUTe8jJmYRsPiSUYY f2BHtsOY6SEYLfI/c24+TAYegiFZA/arxghj9pYSP4nuv7bqvXi8f8TNH/YJLQLBdMYBKNPp JEZkm/GPl9 X-IronPort-AV: E=Sophos;i="5.96,187,1665460800"; d="scan'208";a="85832736" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d/QaZg/AtVPTGfRp3QGx1Ju8A+ivhN/EKJps8BcR/4LnYuYGqe+h984/vOJSLzx/L/3aAMBVP9Gd28r8dvb/wYEYA8Z0yBc1ZPCevdVXyaHwQ8//6QrHQu3Z5zCCBIDi5kc3OWoPy2gpMSRv2k+xV0aRvBSXdUL6Jt/GCfibIvhNMQMHyPnBzrgn3V9+53ic9r5vpfViiplzqfOzfmEdBhbvFyaPZ7TbtiBO9ROxwCrEYDMTNth5VA+4d4imMeZouwSYI5nnd36b2p+y8hE40mPFdDbdYh84+95ydT3Cp60WUnkJu/n/eHdQrnoTeGdGERz31rYPo2MXszKhw7tStQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CaBc5YUtrTp/b8VA8qm2klkf++dz7OUz+9ZVGyK1Oms=; b=f7P7CSRWfoLuyhISsU+GoeBWcdENz8R8rur28po+YXV42/yrjEweV9+utmWCGsq8T69pJoK/F1pH6p2fcQptsSRo1VjJjSz7o9SSQDNd9+PW9hhBT03dEPWLwKQgsOgKl5QSI0wMBf8e0xW3a7qHd9OIMLA0mvvVrXRuiHCaq8VSC1WVKC253WGGbZE9dA9OUlKaSfu8Es1yeJo8F0V0iIayLu07s5znbSxXGhNLprVJz27hRU+4C+C4+6og/+1Cv116WdbOqqYZNguOHRtYJnjqxozFNUG6KSO8XvB0WZsbcAP0U3xZlW24BFJ7wsck19Mrj5i1ifNH6sT7HdyeGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CaBc5YUtrTp/b8VA8qm2klkf++dz7OUz+9ZVGyK1Oms=; b=Kp70WBUUasjngatfLCin4goyI9l9RBJ2lYlxUNcC0Zj5bqmhLTkt9nsoXhEBjhmyZVs0nVSD0p3hnBnnDsjC6ACIjQZXAKVYLkI/0Ma/YQX3FtNhOlrE/sM8HKr033OFxbPlX0ijssa1yXg+L6IZqm/2qmg+iUFMbErnhHFlAUQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 23 Nov 2022 13:03:08 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Message-ID: References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> <5a2df843-1acd-ad78-baff-e47befd0703c@citrix.com> <878e635f-b116-3580-945f-f8acb711a5bc@suse.com> <69507b8d-1f31-39fb-7469-e240fbfdde44@citrix.com> <33a005bf-0596-c624-0e70-077a450ac2ae@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <33a005bf-0596-c624-0e70-077a450ac2ae@suse.com> X-ClientProxiedBy: LO4P123CA0096.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::11) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|CO1PR03MB5811:EE_ X-MS-Office365-Filtering-Correlation-Id: f9aae419-cd1e-443b-3012-08dacd4ab2f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y1kvZDv78QXRQNsdgeh19Uh/VFNAte84OTm5MjiVUjXpIaUq/DglUOw960P527CsAGlxY2phM5WHZU6NxIac+UhtEN8YA7otiMOcUzj2VU14I5l59bsVty0yEwQuPQm0aVmFoPNvXULTtlUQ68IxV5aPUPQD6HNXsIYHxVm6AiHHwzOFLy6QZ0GBLnFMbpFWmRJz2er+Oz4E5+2MTRepFD8g5ipBvSnoihVhIp+peZj7vtYguq/9nnCfW1HbWsE00dqoBajDdZBkx1fw1bxKLxCIlI8+vt/drYCqELeTsjh/nBP8LGsUIDRF31Puq0i5J2DARHgYYRLYWbJcPqaoVkEgHYDQ6ZwCW4snGrzCc5wZhuEdnLa56p1TszYhwof0ZRRJ0DMb3eLItaZkxGkJj7clzRi1gJkp/aAXCKDThje1BepyTuYUxOnH5G6jUXt6qnUTtNP9vaWT7u/cpWzdDeQBuj6x6viasQeISHQoIfnamXzT+qyqloRS5pdbI4S1EgRB1hkKjcFSjt/JdkEJlhuc/LUgGw4KmMLplvQw186FhtgQBrPqT0yU2YCVYiopP11peL66aDkY91L2gFHkoPDfGvmGHPx8aKI+YvjJmnOsSlmnL6IWLyT7xzym0Fx33whiYR0qUwOxKjZ/3kywbg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(366004)(376002)(39860400002)(136003)(396003)(346002)(451199015)(83380400001)(6486002)(86362001)(478600001)(85182001)(5660300002)(2906002)(8936002)(38100700002)(6512007)(9686003)(41300700001)(26005)(33716001)(82960400001)(66476007)(66556008)(186003)(6506007)(54906003)(8676002)(6916009)(6666004)(316002)(53546011)(66946007)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Smo2emhZb0VnR1NrbUI0QzBwQXIyUFhza2poUEJKRzZHdzIrdG9jYjlLaGJu?= =?utf-8?B?UGVqZE9kajkyTlpBTUc2RTF3ei96ejF1V2V6NTAyeWJ4V0FrLzVhT1pwWktN?= =?utf-8?B?VVE2dVYwdGNLNnpTNzBBdFF6L3MxSmkyNkp5bzVTWVNsdUVTbXA5a3U5Q0pB?= =?utf-8?B?cWlvOTNrY3RUc09tQmMxSFpEbmN1OGhkYkxEaDlOUzRLMnBzTTMxM0lURHE1?= =?utf-8?B?NUdTUmhsVnR6VC9LQXBMK2lXb0dLTmhoWWJTYkVWclBJZUhDcEpQOU1saU81?= =?utf-8?B?aTU4cG93c0pwWC9MZUdEZzNQOWE4Um1FZjV5dHBLbEhMc3hBVVU0ZktMbXFO?= =?utf-8?B?QmwwWStnaGhRanRCN2Q4YTV3UHRRRFZaWDIwLzRuZURBa0dBcklqVEJtbmg1?= =?utf-8?B?dGNobnFHMm1zbGp6VTNmM0NLK0l6L1Rhb1MwYmIxbGg1ZWRBMVJlTURCazND?= =?utf-8?B?dkUvRUE0dTBZYzhsQ0E3UFJDRkRNRFRSN1J2ZUhsSnBxQUJxSVIwc3pJOWNl?= =?utf-8?B?SzZkdHU0MUJ3aU1WUGpsREo0QkV6MG9uSjRWRmI0blNDOHlJb0FEc3NDMmQz?= =?utf-8?B?UWcvWTJrSlZEMS9oSndkdTRWTmxzRmg4d1pjSjJCR0NQZ2VKeFdjSDArSEJt?= =?utf-8?B?NnZOdHVETTFtRG12eE5INWd6ZGROUUN6R1NUcmx4NXNKVEJZbmlTWEsvaXc4?= =?utf-8?B?aUNydGxLbTZUeTRFNldzZE9WeUMrM1ByZEgrKzU4UHA4ZnVmc3lZckRTakdF?= =?utf-8?B?VkVaOGZzNElBSDBHUC9wc3NQY3poOTNlckc3Tlp5Yi9OTHZFRjFZZ240ZXI1?= =?utf-8?B?TDE2ZTRQYURuRzNzU2UzbU1PNVpqUGx2M0FLZEgxU0Z4MFJ5MlVHREtZUUNP?= =?utf-8?B?N1pmNkpqMGphQmo4aGRyTmN3ZzNCWlNjVnJGMWgvMDRUU2RoMEwxY2lXN0hN?= =?utf-8?B?S0pNQVczM0pXRlBON0c3bEpsaDRNTVNpaytXS2wvK0RxQjdTSjNrL2lCOUZr?= =?utf-8?B?ZTVaRFRPa3BycnVlVHZmNHdvQUxlTGZwTmtiWEREQTFJR3ZQT0dydSszd0lG?= =?utf-8?B?aUczRERQQTg5ZDV0RHFScDE0Q2dGSHVRSnV0eXJyWHdyUnQzY01Bc2UwNThP?= =?utf-8?B?OFBSVFNSN08rWHNYeE1YNG5sdTg5eHA5Q2p4OWxXcmJlOUd3cy9CaHJjUlFv?= =?utf-8?B?Y0xkZnVuNGRkektNUXVuVlVoaHZFMHNCemw4UXlWRWI3QTFRaEphcktwZnpP?= =?utf-8?B?bGdBTE9HdVR0R3VmZllhTnNqUmJRMTJuUFFTUmJwSmM3Mmx2a2U1ZU5Ea0ZC?= =?utf-8?B?cmtuTWJmU3RkN014bVpXb2d3MDlka3p3L2k0RU5jMU1qRFF6SC9jVk5LcG5T?= =?utf-8?B?bVZRczh4cFozSW5BVk9zVi9yODVYb3BMRlZVM2Q0WGJHVTYrMFVPVlIxcklC?= =?utf-8?B?anhadjNpLzFFckZNSlNaL0hDVWZGUFdncE5yalg2M1FXa29lWjNvckJJNVdS?= =?utf-8?B?TWZ4WU8vNThlTUVSRmNhYXRzUklXcDRXekV3QWp6SzZLc3JuNW5WYW5ac1pP?= =?utf-8?B?ZkFyUnllZHd3MktvdFZkek4rWmdKeXN2bjdmc0hyaUkzVnN6MHdRd25rTWNv?= =?utf-8?B?M0dsdkk0a2oxY1QzbTZJVmVtc0pYSEl1K0NET1RVK2dsVThFcFZrNFNZSXMw?= =?utf-8?B?MDg4Tm8xWDJacnhCY2E5TVNnaWVTMmZNcnI0SmE5S3lrcFhFRGExNFY0MWdK?= =?utf-8?B?dEQ4NVk2SDFsV2lrTEFkNkZFKys4ZTAwbXBqL21EaDVaVE1MQ2lVc1I0ZWNW?= =?utf-8?B?MDJQbEZWbEdnZ1REQ3h3V2cwemt2ZmhDdXBHYTIvWFRmSVlaNXBtdGQ2TUJw?= =?utf-8?B?akoxTXdGVDEvRjhBbU44RGRWNUMzNVhuNWhHTWVvMkRZWjQwTElwZElrTTI1?= =?utf-8?B?emNqcmtlQytBYmgrS24rS0dPaTFQRytmaFNZV09uUUxzdjdlTkJmRkxxUThk?= =?utf-8?B?eUhwSW4yZTdybnFaR3dHSjhUVEd4Y1BpR3cyQ2VmbGxvSHpveHVMdDNIbWh3?= =?utf-8?B?UDA4aysvQUFMRExrMnh1OWQxc21iT3FESEFrS3NqSldrdHpOcGd1aUxEWlZw?= =?utf-8?Q?hMjAJldWdHHhitepo5tFIVFQg?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: np1kKjZM+61cNllZzge0cBZ8NTwDPgnHg77+vSyTXvI8svJY4f7fLeQxUxRD5MSsygukk7SiMuWPJQcashTxty8GdUHgl++9LWVprO9P07oMDOv7uLEdbIMWDFLigrW5tilLSucrQ1to4fvAL8ZwcE1Njv7y66JUXmW1LMl9WeKcMOwAOfKj3ywnXj4/jei0jPwSPay3r8KSVPmqSIonLsxfN68UebpBxrn76lIl0v+mu+kb9CfS6uBCtlWSYJJFY992P7rxI2SWCMG3DLd3E53KNUedLN1OSjhzMvUkxHOX7kv2QuukzPSLcFin/Cmt0ZSAwRy8d1jEJy5wCTudOUQt0L8FAds80U9F9nDQuWSC7/IgLB5lYlBnKy9+1ZFOJ2+ORiNVf7jBrKPv0zewb2zR+cxYgGvKaJyhcNzOF/+rge0NSLi0gduvCoYG79enyOhVFQQ69HwaXVYek21j/76iAE502zRKpB+biwln3fgfL4kgPR6PElutzQYY4VqITPW+Q8Ei2yffQGcSdyGIaA0fMZd3dcly3TxEmVa8Pn+6Dmn6jadd7VfmnJ8HK24bUPC3I9kPX7/g2ORrO69KvG9RDgSfyh+4v8R5DBaRiTogiQJbZWWY4wOmk8Zgswg3l89NN3COGVdTIqm21bxrseMf3EgIY7LX9hk10/Nh2r0XF8UUoIyFE/bfJL7Auh7qjXEaqtjOlPpUl+m7XNqAgswEWZxGhKA9FA/vJ8JNg45Y3yW4FwyFdGNTRBzn9KT1WxgsjRBincJJVMXCy9BvtP80elbqxKdIIX6pxPJERggQ/5nn3QqPf4Ovjgon6euhxAhswe7RswaffKpvESszmKkbfXWV5elMI5pWq8gRbe0= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9aae419-cd1e-443b-3012-08dacd4ab2f4 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 12:03:15.4823 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dKYD5imbSMr8nNrs/6+h6DsgZtAMyc/rY/3aJJe1uy7d+Ywxy8AGWvTA33GVRJpPYncU2vx3Sd5Q+TprDm1OTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5811 On Mon, Nov 21, 2022 at 01:34:38PM +0100, Jan Beulich wrote: > On 21.11.2022 13:23, Andrew Cooper wrote: > > On 21/11/2022 08:56, Jan Beulich wrote: > >> On 18.11.2022 15:27, Andrew Cooper wrote: > >>> On 18/11/2022 12:54, Jan Beulich wrote: > >>>> On 18.11.2022 13:33, Andrew Cooper wrote: > >>>>> On 18/11/2022 10:31, Jan Beulich wrote: > >>>>>> Linux'es relatively new use of HVMOP_set_evtchn_upcall_vector has > >>>>>> exposed a problem with the marking of the respective vector as > >>>>>> pending: For quite some time Linux has been checking whether any stale > >>>>>> ISR or IRR bits would still be set while preparing the LAPIC for use. > >>>>>> This check is now triggering on the upcall vector, as the registration, > >>>>>> at least for APs, happens before the LAPIC is actually enabled. > >>>>>> > >>>>>> In software-disabled state an LAPIC would not accept any interrupt > >>>>>> requests and hence no IRR bit would newly become set while in this > >>>>>> state. As a result it is also wrong for us to mark the upcall vector as > >>>>>> having a pending request when the vLAPIC is in this state. > >>>>> I agree with this. > >>>>> > >>>>>> To compensate for the "enabled" check added to the assertion logic, add > >>>>>> logic to (conditionally) mark the upcall vector as having a request > >>>>>> pending at the time the LAPIC is being software-enabled by the guest. > >>>>> But this, I don't think is appropriate. > >>>>> > >>>>> The point of raising on enable is allegedly to work around setup race > >>>>> conditions.  I'm unconvinced by this reasoning, but it is what it is, > >>>>> and the stated behaviour is to raise there and then. > >>>>> > >>>>> If a guest enables evtchn while the LAPIC is disabled, then the > >>>>> interrupt is lost.  Like every other interrupt in an x86 system. > >>>> Edge triggered ones you mean, I suppose, but yes. > >>> For IO-APIC systems, you mostly lose line interrupts too, don't you? > >>> > >>> The line will remain pending at the IO-APIC, but nothing in the system > >>> will unwedge until someone polls the IO-APIC. > >>> > >>> Either way... > >>> > >>>>> I don't think there is any credible way a guest kernel author can expect > >>>>> the weird evtchn edgecase to wait for an arbitrary point in the future, > >>>>> and it's a corner case that I think is worth not keeping. > >>>> Well - did you look at 7b5b8ca7dffd ("x86/upcall: inject a spurious event > >>>> after setting upcall vector"), referenced by the Fixes: tag? The issue is > >>>> that with evtchn_upcall_pending once set, there would never again be a > >>>> notification. > >>> Ok, so we do need to do something. > >>> > >>>> So if what you say is to be the model we follow, then that > >>>> earlier change was perhaps wrong as well. Instead it should then have > >>>> been a guest change (as also implicit from your reply) to clear > >>>> evtchn_upcall_pending after vCPU info registration (there) or LAPIC > >>>> enabling (here), perhaps by way of "manually" invoking the handling of > >>>> that pending event, or by issuing a self-IPI with that vector. > >>>> Especially the LAPIC enabling case would then be yet another Xen-specific > >>>> on a guest code path which better wouldn't have to be aware of Xen. > >>> Without trying to prescribe how to fix this specific issue, wherever > >>> possible we should be trying to limit the Xen-isms from non-Xen areas.  > >>> There's a whole lot of poorly described and surprising behaviours which > >>> have not stood the test of time. > >>> > >>> In this case, it seems that we have yet another x86 PV-ism which hasn't > >>> translated well x86 HVM.  Specifically, we're trying to overlay an > >>> entirely shared-memory (and delayed return-to-guest) interrupt > >>> controller onto one which is properly constructed to handle events in > >>> realtime. > >>> > >>> > >>> I even got as far as writing that maybe leaving it as-is was the best > >>> option (principle of least surprise for Xen developers), but our > >>> "friend" apic acceleration strikes again. > >>> > >>> Xen doesn't always get a VMExit when the guest clears SW_DISABLE, > >>> because microcode may have accelerated it. > >> But as per "APIC-Write Emulation" in the SDM we'd still get an APIC-write > >> VM exit. > > > > Intel isn't the only accelerated implementation, and there future > > details not in the public docs. > > > > There will be an implementation we will want to support where Xen > > doesn't get a vmexit for a write to SPIV. > > I see. > > >> If we didn't, how would our internal accounting of APIC enabled > >> state (VLAPIC_SW_DISABLED) work? > > > > It doesn't. > > > > One of many problems on the "known errors" list from an incomplete > > original attempt to get acceleration working. > > > > There's no good reason to cache those disables in the first place (both > > are both trivially available from other positions in memory), and > > correctness reasons not to. > > > >> And the neighboring (to where I'm adding > >> the new code) pt_may_unmask_irq() call then also wouldn't occur. > >> > >> I'm actually pretty sure we do too much in this case - in particular none > >> of the vlapic_set_reg() should be necessary. But we certainly can't get > >> away with doing nothing, and hence we depend on that VM exit to actually > >> occur. > > > > We must do exactly and only what real hardware does, so that the state > > changes emulated by Xen are identical to those accelerated by microcode. > > > > Other than that, I really wouldn't make any presumptions about the > > existing vLAPIC logic being correct. > > > > It is, at best, enough of an approximation to the spec for major OSes to > > function, with multiple known bugs and no coherent testing. > > But can we leave resolving of the wider issue then separate, and leave > the change here as it presently is? Yes, mimic-ing the same behavior > later may be "interesting", but if we can't achieve consistent behavior > with yet more advanced acceleration, maybe we simply can't use that > (perhaps until a complete overhaul of everything involved in LAPIC > handling, possibly including a guest side indicator that they're happy > without the extra signaling, at which point that yet-more-advanced > acceleration could then be enabled for that guest). > > Otherwise - do you have any suggestion as to alternative logic which I > might use in this patch? Maybe the underlying issue is that we allow executing HVMOP_set_evtchn_upcall_vector against remote vCPU. This could be solved by only allowing HVMOP_set_evtchn_upcall_vector against the current vCPU and with the LAPIC enabled, but I guess we are too late for that. Actually, what about only injecting the spurious event if the vCPU is online, ie: diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index ae4368ec4b..4b84706579 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -4105,7 +4105,8 @@ static int hvmop_set_evtchn_upcall_vector( printk(XENLOG_G_INFO "%pv: upcall vector %02x\n", v, op.vector); v->arch.hvm.evtchn_upcall_vector = op.vector; - hvm_assert_evtchn_irq(v); + if ( is_vcpu_online(v) ) + hvm_assert_evtchn_irq(v); return 0; } I think that should fix the issue seen on Linux. We would additionally need to fix hvm_assert_evtchn_irq() to only set the vector if the vLAPIC is enabled. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Nov 23 12:41:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 12:41:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447540.703873 (Exim 4.92) (envelope-from ) id 1oxp4b-00049Y-UN; Wed, 23 Nov 2022 12:41:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447540.703873; Wed, 23 Nov 2022 12:41:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp4b-00049R-RL; Wed, 23 Nov 2022 12:41:53 +0000 Received: by outflank-mailman (input) for mailman id 447540; Wed, 23 Nov 2022 12:41:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp4a-00049G-U1 for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 12:41:52 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 334624d4-6b2c-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 13:41:51 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B0D9861C63; Wed, 23 Nov 2022 12:41:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A77EC433D6; Wed, 23 Nov 2022 12:41:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 334624d4-6b2c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669207309; bh=RW4HlKrC8HJ1IjGXRBDcvUafv7RxhxgfYV7vWL5KbOg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IXcoLK+S6JRoZqUld6sGVuGUhh6DuXfMCJAuFMiZ0/YZpfkfF4GGzP7eYG3nxL6VB MhWcBEKGWfrgSbjsA0VCAG7EtYtT2dHUZrTaLdIiDUpoMsc0grgeBaTBGveiwix+Cs qU65TWViQX18zHy9/ptjqMXJvTrUbpdMj+cjU+QzXLgs3YzVNOYGqtRbZRFaIUNOrF PBIZb3ENWruAqyR3MBNiQgAwoS0Mqh6HTVmQBwwBOmAF2xaAPqsq7jikx/7UqceFsZ jgNsCmskiE/pLiPkatUluT4+SXzT4yUQZp1JfcP8eU3yFCpU7irr9XyI10LARWWxK1 x8i/kHs/ckeRQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Juergen Gross , Sasha Levin , sstabellini@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 6.0 20/44] xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKALL too Date: Wed, 23 Nov 2022 07:40:29 -0500 Message-Id: <20221123124057.264822-20-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221123124057.264822-1-sashal@kernel.org> References: <20221123124057.264822-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit 5e29500eba2aa19e1323df46f64dafcd4a327092 ] When Xen domain configures MSI-X, the usual approach is to enable MSI-X together with masking all of them via the config space, then fill the table and only then clear PCI_MSIX_FLAGS_MASKALL. Allow doing this via QEMU running in a stub domain. Previously, when changing PCI_MSIX_FLAGS_MASKALL was not allowed, the whole write was aborted, preventing change to the PCI_MSIX_FLAGS_ENABLE bit too. Note the Xen hypervisor intercepts this write anyway, and may keep the PCI_MSIX_FLAGS_MASKALL bit set if it wishes to. It will store the guest-requested state and will apply it eventually. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jan Beulich Link: https://lore.kernel.org/r/20221114103110.1519413-1-marmarek@invisiblethingslab.com Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/xen-pciback/conf_space_capability.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xen/xen-pciback/conf_space_capability.c index 5e53b4817f16..097316a74126 100644 --- a/drivers/xen/xen-pciback/conf_space_capability.c +++ b/drivers/xen/xen-pciback/conf_space_capability.c @@ -190,13 +190,16 @@ static const struct config_field caplist_pm[] = { }; static struct msi_msix_field_config { - u16 enable_bit; /* bit for enabling MSI/MSI-X */ - unsigned int int_type; /* interrupt type for exclusiveness check */ + u16 enable_bit; /* bit for enabling MSI/MSI-X */ + u16 allowed_bits; /* bits allowed to be changed */ + unsigned int int_type; /* interrupt type for exclusiveness check */ } msi_field_config = { .enable_bit = PCI_MSI_FLAGS_ENABLE, + .allowed_bits = PCI_MSI_FLAGS_ENABLE, .int_type = INTERRUPT_TYPE_MSI, }, msix_field_config = { .enable_bit = PCI_MSIX_FLAGS_ENABLE, + .allowed_bits = PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL, .int_type = INTERRUPT_TYPE_MSIX, }; @@ -229,7 +232,7 @@ static int msi_msix_flags_write(struct pci_dev *dev, int offset, u16 new_value, return 0; if (!dev_data->allow_interrupt_control || - (new_value ^ old_value) & ~field_config->enable_bit) + (new_value ^ old_value) & ~field_config->allowed_bits) return PCIBIOS_SET_FAILED; if (new_value & field_config->enable_bit) { -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 12:41:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 12:41:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447541.703884 (Exim 4.92) (envelope-from ) id 1oxp4d-0004Oj-7O; Wed, 23 Nov 2022 12:41:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447541.703884; Wed, 23 Nov 2022 12:41:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp4d-0004Oc-3K; Wed, 23 Nov 2022 12:41:55 +0000 Received: by outflank-mailman (input) for mailman id 447541; Wed, 23 Nov 2022 12:41:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp4b-00049G-Kc for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 12:41:53 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34a3e6e4-6b2c-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 13:41:52 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C4047B81F3E; Wed, 23 Nov 2022 12:41:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 946FBC43470; Wed, 23 Nov 2022 12:41:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34a3e6e4-6b2c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669207310; bh=qhyl/ggZQXJL45HqOXJfkODiufFbxtVKPvB+MTZPIaY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Mr9FOQpdXUzqr7Qs+c7L44VJUnf1ARIMvj7NHceZwtBD4umWqqlcVndpS3IY8RkaP WOisUGqRu1dx6wU6nlgksIA6IVrfeqYtusEMlsP13ErvrfGexC9RA3z1HZdp2z6a7L Xphuj7AqDjWlZnP4IFGi9XEIJDGMFQRaIAnqWKodUMQq5YEzew1q62Uq2BU4lCnSQV 9Z7vBtlw5UipZ4Keq3rjDVKqmYr3q+XEPabEMgnGy7FXmV62LH96/8yvSPeT0IKWJg 4I8ThBTOOTwtB85LWsJhO7boP3zHhGjnt+TlmU/EtI3Q/8n+D8++wyXgRix2cvajZP fdzL2MAI6mh4w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: ruanjinjie , Oleksandr Tyshchenko , Juergen Gross , Sasha Levin , sstabellini@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 6.0 21/44] xen/platform-pci: add missing free_irq() in error path Date: Wed, 23 Nov 2022 07:40:30 -0500 Message-Id: <20221123124057.264822-21-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221123124057.264822-1-sashal@kernel.org> References: <20221123124057.264822-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: ruanjinjie [ Upstream commit c53717e1e3f0d0f9129b2e0dbc6dcc5e0a8132e9 ] free_irq() is missing in case of error in platform_pci_probe(), fix that. Signed-off-by: ruanjinjie Reviewed-by: Oleksandr Tyshchenko Link: https://lore.kernel.org/r/20221114112124.1965611-1-ruanjinjie@huawei.com Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/platform-pci.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c index 18f0ed8b1f93..6ebd819338ec 100644 --- a/drivers/xen/platform-pci.c +++ b/drivers/xen/platform-pci.c @@ -144,7 +144,7 @@ static int platform_pci_probe(struct pci_dev *pdev, if (ret) { dev_warn(&pdev->dev, "Unable to set the evtchn callback " "err=%d\n", ret); - goto out; + goto irq_out; } } @@ -152,13 +152,16 @@ static int platform_pci_probe(struct pci_dev *pdev, grant_frames = alloc_xen_mmio(PAGE_SIZE * max_nr_gframes); ret = gnttab_setup_auto_xlat_frames(grant_frames); if (ret) - goto out; + goto irq_out; ret = gnttab_init(); if (ret) goto grant_out; return 0; grant_out: gnttab_free_auto_xlat_frames(); +irq_out: + if (!xen_have_vector_callback) + free_irq(pdev->irq, pdev); out: pci_release_region(pdev, 0); mem_out: -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 12:43:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 12:43:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447547.703895 (Exim 4.92) (envelope-from ) id 1oxp5u-0005IC-JU; Wed, 23 Nov 2022 12:43:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447547.703895; Wed, 23 Nov 2022 12:43:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp5u-0005I5-GD; Wed, 23 Nov 2022 12:43:14 +0000 Received: by outflank-mailman (input) for mailman id 447547; Wed, 23 Nov 2022 12:43:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp5t-0005Hq-GU for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 12:43:13 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 63be7ca9-6b2c-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 13:43:12 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3890261CAB; Wed, 23 Nov 2022 12:43:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49470C433D7; Wed, 23 Nov 2022 12:43:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63be7ca9-6b2c-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669207391; bh=qhyl/ggZQXJL45HqOXJfkODiufFbxtVKPvB+MTZPIaY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vM99BO2hWFGDajxNBntMx/O8KPrcGl1TfG/+smIkW8a6P58zsmZgOYi0k3kq4j480 1ySc4mixZAeuhdSHd5AbB9tXxl2eXKDGUvqPQW9H2VRLMxQNcOaLS81qKuSKn1phPR QDl6p3mkZ8n/QyA/4UrsuY8COD1REI9puVzYkEhtZxrh+vlzpQfmCv+8MvjTCvmB0m wY4wMtc8Mu4nwTSFin6PC6gA19Rlq8UBI64ZvrOd8o7NuMAZV5xoMihZPgQ99A3YMe 0vWrktcabiR/MGJp6FH15tJNckPp9GboNFm9b+9Musg2cLyyqswKf6CwzUhOuzIvV3 F0fX+pIk8Ds7Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: ruanjinjie , Oleksandr Tyshchenko , Juergen Gross , Sasha Levin , sstabellini@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 5.15 14/31] xen/platform-pci: add missing free_irq() in error path Date: Wed, 23 Nov 2022 07:42:15 -0500 Message-Id: <20221123124234.265396-14-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221123124234.265396-1-sashal@kernel.org> References: <20221123124234.265396-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: ruanjinjie [ Upstream commit c53717e1e3f0d0f9129b2e0dbc6dcc5e0a8132e9 ] free_irq() is missing in case of error in platform_pci_probe(), fix that. Signed-off-by: ruanjinjie Reviewed-by: Oleksandr Tyshchenko Link: https://lore.kernel.org/r/20221114112124.1965611-1-ruanjinjie@huawei.com Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/platform-pci.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c index 18f0ed8b1f93..6ebd819338ec 100644 --- a/drivers/xen/platform-pci.c +++ b/drivers/xen/platform-pci.c @@ -144,7 +144,7 @@ static int platform_pci_probe(struct pci_dev *pdev, if (ret) { dev_warn(&pdev->dev, "Unable to set the evtchn callback " "err=%d\n", ret); - goto out; + goto irq_out; } } @@ -152,13 +152,16 @@ static int platform_pci_probe(struct pci_dev *pdev, grant_frames = alloc_xen_mmio(PAGE_SIZE * max_nr_gframes); ret = gnttab_setup_auto_xlat_frames(grant_frames); if (ret) - goto out; + goto irq_out; ret = gnttab_init(); if (ret) goto grant_out; return 0; grant_out: gnttab_free_auto_xlat_frames(); +irq_out: + if (!xen_have_vector_callback) + free_irq(pdev->irq, pdev); out: pci_release_region(pdev, 0); mem_out: -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 12:43:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 12:43:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447548.703906 (Exim 4.92) (envelope-from ) id 1oxp5v-0005Xu-Qn; Wed, 23 Nov 2022 12:43:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447548.703906; Wed, 23 Nov 2022 12:43:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp5v-0005Xn-Nm; Wed, 23 Nov 2022 12:43:15 +0000 Received: by outflank-mailman (input) for mailman id 447548; Wed, 23 Nov 2022 12:43:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp5u-0005Hq-7y for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 12:43:14 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 632d6ccc-6b2c-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 13:43:12 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3741861CAE; Wed, 23 Nov 2022 12:43:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 094C4C433C1; Wed, 23 Nov 2022 12:43:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 632d6ccc-6b2c-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669207389; bh=RW4HlKrC8HJ1IjGXRBDcvUafv7RxhxgfYV7vWL5KbOg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QK2zB+gHR4+h9XhfKkMLLNszNfc15wiSUlVRPPvnVU54dtWOPTeS91lrVPgCWLeYe LvtlVSfWgDCG/MLDYu0mmwkV0NE22KenT4qVUx0aLkamRWY8f8u5TPNqagOdeKUh6f +xe47da3M9R+1xbAYs23vsb3BxHsaspyxAkYnbEPUnzvCcHhskvycRNff1rQ7rx8df RGLc6X3YY82wsnEF2GShhLRjQ+MaLSClmrQStP0zQKEBwHw2mlGZ3zEo14bblSPyj/ iqBnKE4pE6WLkZrK/2UoaPUj/jLjFAIXlPxqYWQx/hPAwJayjXQWZA0s+vbJJ9GBWB kcgr0tKJ2Zh+w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Juergen Gross , Sasha Levin , sstabellini@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 5.15 13/31] xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKALL too Date: Wed, 23 Nov 2022 07:42:14 -0500 Message-Id: <20221123124234.265396-13-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221123124234.265396-1-sashal@kernel.org> References: <20221123124234.265396-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit 5e29500eba2aa19e1323df46f64dafcd4a327092 ] When Xen domain configures MSI-X, the usual approach is to enable MSI-X together with masking all of them via the config space, then fill the table and only then clear PCI_MSIX_FLAGS_MASKALL. Allow doing this via QEMU running in a stub domain. Previously, when changing PCI_MSIX_FLAGS_MASKALL was not allowed, the whole write was aborted, preventing change to the PCI_MSIX_FLAGS_ENABLE bit too. Note the Xen hypervisor intercepts this write anyway, and may keep the PCI_MSIX_FLAGS_MASKALL bit set if it wishes to. It will store the guest-requested state and will apply it eventually. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jan Beulich Link: https://lore.kernel.org/r/20221114103110.1519413-1-marmarek@invisiblethingslab.com Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/xen-pciback/conf_space_capability.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xen/xen-pciback/conf_space_capability.c index 5e53b4817f16..097316a74126 100644 --- a/drivers/xen/xen-pciback/conf_space_capability.c +++ b/drivers/xen/xen-pciback/conf_space_capability.c @@ -190,13 +190,16 @@ static const struct config_field caplist_pm[] = { }; static struct msi_msix_field_config { - u16 enable_bit; /* bit for enabling MSI/MSI-X */ - unsigned int int_type; /* interrupt type for exclusiveness check */ + u16 enable_bit; /* bit for enabling MSI/MSI-X */ + u16 allowed_bits; /* bits allowed to be changed */ + unsigned int int_type; /* interrupt type for exclusiveness check */ } msi_field_config = { .enable_bit = PCI_MSI_FLAGS_ENABLE, + .allowed_bits = PCI_MSI_FLAGS_ENABLE, .int_type = INTERRUPT_TYPE_MSI, }, msix_field_config = { .enable_bit = PCI_MSIX_FLAGS_ENABLE, + .allowed_bits = PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL, .int_type = INTERRUPT_TYPE_MSIX, }; @@ -229,7 +232,7 @@ static int msi_msix_flags_write(struct pci_dev *dev, int offset, u16 new_value, return 0; if (!dev_data->allow_interrupt_control || - (new_value ^ old_value) & ~field_config->enable_bit) + (new_value ^ old_value) & ~field_config->allowed_bits) return PCIBIOS_SET_FAILED; if (new_value & field_config->enable_bit) { -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 12:44:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 12:44:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447553.703917 (Exim 4.92) (envelope-from ) id 1oxp6r-0006MK-3F; Wed, 23 Nov 2022 12:44:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447553.703917; Wed, 23 Nov 2022 12:44:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp6r-0006M9-0C; Wed, 23 Nov 2022 12:44:13 +0000 Received: by outflank-mailman (input) for mailman id 447553; Wed, 23 Nov 2022 12:44:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp6o-0005Hq-R4 for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 12:44:10 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86099b34-6b2c-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 13:44:09 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B524361CAD; Wed, 23 Nov 2022 12:44:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0B17C433D6; Wed, 23 Nov 2022 12:44:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86099b34-6b2c-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669207447; bh=RW4HlKrC8HJ1IjGXRBDcvUafv7RxhxgfYV7vWL5KbOg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YKwsxoTfPXwjYPOAfpkBSTZ7MjKUFdJ38TGWkamu32/BWNk0lLY52sAjFRklqx+IE 2aFDlfqpZPc1k8lZjQptvza74vC5203tVRgMm9vZfQ7RT7Dhp6pjaUVFhs/iQ5JKH1 P2fR6m8kF9YnpRSduZUDHcVjIAyhsvIdbNXxWwLp2ljyeUqf3fN5lvldXQAs8Tlibf aSvgGRtxZ3y5T1C6v8Tltq0p07ma4jpE0J6n6Xrg62clmsUGzuMqCikgcjUEfGltTk +NsSl9aeWcfBQ+F/SO1GTln6t9IOa/YnPBIWhPTgVzKh7r9rhekcOOhti+qSyjK3YJ PPMk9Vy+XzPFQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Juergen Gross , Sasha Levin , sstabellini@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 5.10 09/22] xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKALL too Date: Wed, 23 Nov 2022 07:43:24 -0500 Message-Id: <20221123124339.265912-9-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221123124339.265912-1-sashal@kernel.org> References: <20221123124339.265912-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Marek Marczykowski-Górecki [ Upstream commit 5e29500eba2aa19e1323df46f64dafcd4a327092 ] When Xen domain configures MSI-X, the usual approach is to enable MSI-X together with masking all of them via the config space, then fill the table and only then clear PCI_MSIX_FLAGS_MASKALL. Allow doing this via QEMU running in a stub domain. Previously, when changing PCI_MSIX_FLAGS_MASKALL was not allowed, the whole write was aborted, preventing change to the PCI_MSIX_FLAGS_ENABLE bit too. Note the Xen hypervisor intercepts this write anyway, and may keep the PCI_MSIX_FLAGS_MASKALL bit set if it wishes to. It will store the guest-requested state and will apply it eventually. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jan Beulich Link: https://lore.kernel.org/r/20221114103110.1519413-1-marmarek@invisiblethingslab.com Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/xen-pciback/conf_space_capability.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xen/xen-pciback/conf_space_capability.c index 5e53b4817f16..097316a74126 100644 --- a/drivers/xen/xen-pciback/conf_space_capability.c +++ b/drivers/xen/xen-pciback/conf_space_capability.c @@ -190,13 +190,16 @@ static const struct config_field caplist_pm[] = { }; static struct msi_msix_field_config { - u16 enable_bit; /* bit for enabling MSI/MSI-X */ - unsigned int int_type; /* interrupt type for exclusiveness check */ + u16 enable_bit; /* bit for enabling MSI/MSI-X */ + u16 allowed_bits; /* bits allowed to be changed */ + unsigned int int_type; /* interrupt type for exclusiveness check */ } msi_field_config = { .enable_bit = PCI_MSI_FLAGS_ENABLE, + .allowed_bits = PCI_MSI_FLAGS_ENABLE, .int_type = INTERRUPT_TYPE_MSI, }, msix_field_config = { .enable_bit = PCI_MSIX_FLAGS_ENABLE, + .allowed_bits = PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL, .int_type = INTERRUPT_TYPE_MSIX, }; @@ -229,7 +232,7 @@ static int msi_msix_flags_write(struct pci_dev *dev, int offset, u16 new_value, return 0; if (!dev_data->allow_interrupt_control || - (new_value ^ old_value) & ~field_config->enable_bit) + (new_value ^ old_value) & ~field_config->allowed_bits) return PCIBIOS_SET_FAILED; if (new_value & field_config->enable_bit) { -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 12:44:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 12:44:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447554.703922 (Exim 4.92) (envelope-from ) id 1oxp6r-0006Q1-Cv; Wed, 23 Nov 2022 12:44:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447554.703922; Wed, 23 Nov 2022 12:44:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp6r-0006Ph-8j; Wed, 23 Nov 2022 12:44:13 +0000 Received: by outflank-mailman (input) for mailman id 447554; Wed, 23 Nov 2022 12:44:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp6p-0005Hq-R5 for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 12:44:11 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8699dea6-6b2c-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 13:44:10 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A86EB61CB6; Wed, 23 Nov 2022 12:44:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47039C43144; Wed, 23 Nov 2022 12:44:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8699dea6-6b2c-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669207449; bh=mb+pGKqyYHoKta2t0TvbE4ss9Y74jYvBeT3Shr+CzvU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UikIHeENFjbRVUzZotK7gQxna3KCvWNSZ/5lcZy2lkqR9awgK1eAcmrX8dhMR76ME QuT7QJI5DfARu4JkRId7ucqlkA2+pjxHbclDjBg8NXccPLmBHQ0ckzFHhbcZPXedQv gNyGFgvX+XKK4lQOt2ROLsofSTUDoZ28V93a+wvVB6WCcn1l+unkr+p3oOGlLYMhLH 4hIMO2D6650Cu9vGzEIaony+t7ZNOsp4IFxlPuiHCm6bU/3jpDfjMVM95U8Y23RH3m +o7dutyaAsI3LJS5KDVq61iVoRi0bsZfqsa9Ag05TdgbW6y4exo24s8htEB7ebZFSg Gnei+cFAq9Pgw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: ruanjinjie , Oleksandr Tyshchenko , Juergen Gross , Sasha Levin , sstabellini@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 5.10 10/22] xen/platform-pci: add missing free_irq() in error path Date: Wed, 23 Nov 2022 07:43:25 -0500 Message-Id: <20221123124339.265912-10-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221123124339.265912-1-sashal@kernel.org> References: <20221123124339.265912-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: ruanjinjie [ Upstream commit c53717e1e3f0d0f9129b2e0dbc6dcc5e0a8132e9 ] free_irq() is missing in case of error in platform_pci_probe(), fix that. Signed-off-by: ruanjinjie Reviewed-by: Oleksandr Tyshchenko Link: https://lore.kernel.org/r/20221114112124.1965611-1-ruanjinjie@huawei.com Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/platform-pci.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c index 9db557b76511..804d8f4d0e73 100644 --- a/drivers/xen/platform-pci.c +++ b/drivers/xen/platform-pci.c @@ -137,7 +137,7 @@ static int platform_pci_probe(struct pci_dev *pdev, if (ret) { dev_warn(&pdev->dev, "Unable to set the evtchn callback " "err=%d\n", ret); - goto out; + goto irq_out; } } @@ -145,13 +145,16 @@ static int platform_pci_probe(struct pci_dev *pdev, grant_frames = alloc_xen_mmio(PAGE_SIZE * max_nr_gframes); ret = gnttab_setup_auto_xlat_frames(grant_frames); if (ret) - goto out; + goto irq_out; ret = gnttab_init(); if (ret) goto grant_out; return 0; grant_out: gnttab_free_auto_xlat_frames(); +irq_out: + if (!xen_have_vector_callback) + free_irq(pdev->irq, pdev); out: pci_release_region(pdev, 0); mem_out: -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 12:44:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 12:44:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447559.703938 (Exim 4.92) (envelope-from ) id 1oxp7Q-0007R7-Ky; Wed, 23 Nov 2022 12:44:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447559.703938; Wed, 23 Nov 2022 12:44:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp7Q-0007R0-II; Wed, 23 Nov 2022 12:44:48 +0000 Received: by outflank-mailman (input) for mailman id 447559; Wed, 23 Nov 2022 12:44:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp7P-0007Eq-5V for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 12:44:47 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9be6288c-6b2c-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 13:44:46 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5AAF261C5E; Wed, 23 Nov 2022 12:44:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D321FC433C1; Wed, 23 Nov 2022 12:44:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9be6288c-6b2c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669207484; bh=qpcj/yxIVHVz+BB0iIupUGngTEfyrKmT7QUW4WDi3IE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pwaRTxpUVebgapkjE3zGaOmpwrkUHUR3PojUp0iubvRW0+QDbbHN2c3jta4i/Q7CV cKr3A2BTa3AZ76+VQHfmRUZXeEAcWjTgfHZTwfEsqfNBU4KZrgeMGC3znKfv1VHp3E cb8pj7pk8E9ch6BKQsqhIAVDlz05odgXfEeDNvB2m+/O+NyNV8U9qVuQVvLUgPFrkC 8B0V4oYEaBUYtLaGR5XCueePUpgF3Qo3Q+3nx+NLBPpIy8+vqSW4B3qvaTE+hGXESM sCMflxmUjqIv98zueOs9T1suabIVRB1e3TGmQgNZpIADOK+0tuSF01pYLSUY472Hlf JkjxhHEVHgl9g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: ruanjinjie , Oleksandr Tyshchenko , Juergen Gross , Sasha Levin , sstabellini@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 5.4 06/15] xen/platform-pci: add missing free_irq() in error path Date: Wed, 23 Nov 2022 07:44:16 -0500 Message-Id: <20221123124427.266286-6-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221123124427.266286-1-sashal@kernel.org> References: <20221123124427.266286-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: ruanjinjie [ Upstream commit c53717e1e3f0d0f9129b2e0dbc6dcc5e0a8132e9 ] free_irq() is missing in case of error in platform_pci_probe(), fix that. Signed-off-by: ruanjinjie Reviewed-by: Oleksandr Tyshchenko Link: https://lore.kernel.org/r/20221114112124.1965611-1-ruanjinjie@huawei.com Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/platform-pci.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c index c45646450135..e1cb277a9e16 100644 --- a/drivers/xen/platform-pci.c +++ b/drivers/xen/platform-pci.c @@ -137,7 +137,7 @@ static int platform_pci_probe(struct pci_dev *pdev, if (ret) { dev_warn(&pdev->dev, "Unable to set the evtchn callback " "err=%d\n", ret); - goto out; + goto irq_out; } } @@ -145,13 +145,16 @@ static int platform_pci_probe(struct pci_dev *pdev, grant_frames = alloc_xen_mmio(PAGE_SIZE * max_nr_gframes); ret = gnttab_setup_auto_xlat_frames(grant_frames); if (ret) - goto out; + goto irq_out; ret = gnttab_init(); if (ret) goto grant_out; return 0; grant_out: gnttab_free_auto_xlat_frames(); +irq_out: + if (!xen_have_vector_callback) + free_irq(pdev->irq, pdev); out: pci_release_region(pdev, 0); mem_out: -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 12:45:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 12:45:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447560.703950 (Exim 4.92) (envelope-from ) id 1oxp7n-0007wd-Tp; Wed, 23 Nov 2022 12:45:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447560.703950; Wed, 23 Nov 2022 12:45:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp7n-0007wU-QS; Wed, 23 Nov 2022 12:45:11 +0000 Received: by outflank-mailman (input) for mailman id 447560; Wed, 23 Nov 2022 12:45:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp7m-0007vg-8c for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 12:45:10 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9d53953-6b2c-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 13:45:09 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B524DB81F6F; Wed, 23 Nov 2022 12:45:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84134C4347C; Wed, 23 Nov 2022 12:45:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9d53953-6b2c-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669207507; bh=3Z5VSz+IaXP3WVAY6Thqe7EqruPoNaXQOHKek17Oe7E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MJnEFhUaa2fDFamkRLo7D9SoZMoSsCt8bhr6XENmv2mUjoTRzXvVCd9x+ysvXLW1O St0zu5yeQl7DYUzadV/QT+j7hXfSIjJMHOjOPIsLXEa8nqXmoXW3WLEFzS1jsXMoQ3 7/QQB1Kdb6m6+QMaT2OZJ4fbM4y0tyq0Z2Mycfj9Gd0UmEABwbQns6bIpkWsLJ+aHm 4QTPsIlOsrx2fRMZQyWN9DYulz3rYAskOeJ7r9EVB1uhyjiz9XFneKPDeWIvEyqasA ceoqze8NPQKkJ1UbeBO74O/DTOL6lfAB2BptHrt0mbs4UjfD6vbPvS+Q4Fh6eVvXxE ZlggVldtPs+Tw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: ruanjinjie , Oleksandr Tyshchenko , Juergen Gross , Sasha Levin , sstabellini@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 4.19 03/11] xen/platform-pci: add missing free_irq() in error path Date: Wed, 23 Nov 2022 07:44:48 -0500 Message-Id: <20221123124458.266492-3-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221123124458.266492-1-sashal@kernel.org> References: <20221123124458.266492-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: ruanjinjie [ Upstream commit c53717e1e3f0d0f9129b2e0dbc6dcc5e0a8132e9 ] free_irq() is missing in case of error in platform_pci_probe(), fix that. Signed-off-by: ruanjinjie Reviewed-by: Oleksandr Tyshchenko Link: https://lore.kernel.org/r/20221114112124.1965611-1-ruanjinjie@huawei.com Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/platform-pci.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c index 4cec8146609a..c7e190e5db30 100644 --- a/drivers/xen/platform-pci.c +++ b/drivers/xen/platform-pci.c @@ -150,7 +150,7 @@ static int platform_pci_probe(struct pci_dev *pdev, if (ret) { dev_warn(&pdev->dev, "Unable to set the evtchn callback " "err=%d\n", ret); - goto out; + goto irq_out; } } @@ -158,13 +158,16 @@ static int platform_pci_probe(struct pci_dev *pdev, grant_frames = alloc_xen_mmio(PAGE_SIZE * max_nr_gframes); ret = gnttab_setup_auto_xlat_frames(grant_frames); if (ret) - goto out; + goto irq_out; ret = gnttab_init(); if (ret) goto grant_out; return 0; grant_out: gnttab_free_auto_xlat_frames(); +irq_out: + if (!xen_have_vector_callback) + free_irq(pdev->irq, pdev); out: pci_release_region(pdev, 0); mem_out: -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 12:45:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 12:45:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447563.703961 (Exim 4.92) (envelope-from ) id 1oxp88-0008UP-7L; Wed, 23 Nov 2022 12:45:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447563.703961; Wed, 23 Nov 2022 12:45:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp88-0008UG-2Y; Wed, 23 Nov 2022 12:45:32 +0000 Received: by outflank-mailman (input) for mailman id 447563; Wed, 23 Nov 2022 12:45:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp86-0007vg-QP for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 12:45:30 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b5cccaf2-6b2c-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 13:45:29 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D570261CAB; Wed, 23 Nov 2022 12:45:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 694C2C433D7; Wed, 23 Nov 2022 12:45:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5cccaf2-6b2c-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669207528; bh=3Z5VSz+IaXP3WVAY6Thqe7EqruPoNaXQOHKek17Oe7E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sFQ5yoeNiVW/jqkdfMwNI1vYzLy+rzhvWe4Jmb9spLL5CKewzJn3r3jv/OZL0gYnM nYHt7AlpTS2PTLEFqnq/T/3hbnn9x2COxFDhfVjukA54TImSA54zSK+bHK+Snu++zV ablbXXZRWMt4d6BCkNdVNQofl7/xaYvoBMITw9qRu4hOIx33PHCMMhXm78G+8cqQAI Z0BjC+ZJsdApmS/P/HcRnrDkjZ4qfngzcCTz6wUOvImPYKCwThqiwtlYSdCWTKgkyX laUE3HFJCzD5a0cJ/14UNmT7JgJm7QwqY9jj0j1lHlFjfOMnmS8RffpRoNawGI+rKl 7TP/tJf34IOgA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: ruanjinjie , Oleksandr Tyshchenko , Juergen Gross , Sasha Levin , sstabellini@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 4.14 03/10] xen/platform-pci: add missing free_irq() in error path Date: Wed, 23 Nov 2022 07:45:11 -0500 Message-Id: <20221123124520.266643-3-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221123124520.266643-1-sashal@kernel.org> References: <20221123124520.266643-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: ruanjinjie [ Upstream commit c53717e1e3f0d0f9129b2e0dbc6dcc5e0a8132e9 ] free_irq() is missing in case of error in platform_pci_probe(), fix that. Signed-off-by: ruanjinjie Reviewed-by: Oleksandr Tyshchenko Link: https://lore.kernel.org/r/20221114112124.1965611-1-ruanjinjie@huawei.com Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/platform-pci.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c index 4cec8146609a..c7e190e5db30 100644 --- a/drivers/xen/platform-pci.c +++ b/drivers/xen/platform-pci.c @@ -150,7 +150,7 @@ static int platform_pci_probe(struct pci_dev *pdev, if (ret) { dev_warn(&pdev->dev, "Unable to set the evtchn callback " "err=%d\n", ret); - goto out; + goto irq_out; } } @@ -158,13 +158,16 @@ static int platform_pci_probe(struct pci_dev *pdev, grant_frames = alloc_xen_mmio(PAGE_SIZE * max_nr_gframes); ret = gnttab_setup_auto_xlat_frames(grant_frames); if (ret) - goto out; + goto irq_out; ret = gnttab_init(); if (ret) goto grant_out; return 0; grant_out: gnttab_free_auto_xlat_frames(); +irq_out: + if (!xen_have_vector_callback) + free_irq(pdev->irq, pdev); out: pci_release_region(pdev, 0); mem_out: -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 12:45:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 12:45:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447566.703972 (Exim 4.92) (envelope-from ) id 1oxp8N-0000Zh-Ih; Wed, 23 Nov 2022 12:45:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447566.703972; Wed, 23 Nov 2022 12:45:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp8N-0000Za-G6; Wed, 23 Nov 2022 12:45:47 +0000 Received: by outflank-mailman (input) for mailman id 447566; Wed, 23 Nov 2022 12:45:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxp8M-0008L9-Pd for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 12:45:46 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bf6c6782-6b2c-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 13:45:46 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F282F61C63; Wed, 23 Nov 2022 12:45:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DEEFC43470; Wed, 23 Nov 2022 12:45:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf6c6782-6b2c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669207544; bh=Syc8Sdgco/obOHgr5TpFdObKEaPxMDPmIGv/HB5/1Zo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FuGAmgu2w93dOO/5Rwq0l1Fs/lg+CsfwEAgsGbCkjZiUt2qz+QO01AR757NJ4gplj JDnW7d1sg1yUXRqdfWgwlLjg7jO0EO5n0wQf5JmwJkmAnMerMC+5UFr1ZHSJvcTcbv PTocfp9Uwu5ShTjMFFRmrFQYo7qHRRrEO18tzXri8OnQrGvE8mQH6zAlezJfqKTNJR V6yctH67eZhcjCsu9zE2yO8wZ/W+Wh/EPEBmxusT3VRUqATm4jdGLz4VczJMDavtr0 z4lqJ11HLMzPNUZ+bEmXKRxtghWjRKWyCX0qXtnFuc6/gBxKp2L4m13WWpC9GXScoN 6mhGSfDgt6pzA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: ruanjinjie , Oleksandr Tyshchenko , Juergen Gross , Sasha Levin , sstabellini@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 4.9 2/5] xen/platform-pci: add missing free_irq() in error path Date: Wed, 23 Nov 2022 07:45:34 -0500 Message-Id: <20221123124540.266772-2-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221123124540.266772-1-sashal@kernel.org> References: <20221123124540.266772-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: ruanjinjie [ Upstream commit c53717e1e3f0d0f9129b2e0dbc6dcc5e0a8132e9 ] free_irq() is missing in case of error in platform_pci_probe(), fix that. Signed-off-by: ruanjinjie Reviewed-by: Oleksandr Tyshchenko Link: https://lore.kernel.org/r/20221114112124.1965611-1-ruanjinjie@huawei.com Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/platform-pci.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c index cf9666680c8c..20365b01c36b 100644 --- a/drivers/xen/platform-pci.c +++ b/drivers/xen/platform-pci.c @@ -149,7 +149,7 @@ static int platform_pci_probe(struct pci_dev *pdev, if (ret) { dev_warn(&pdev->dev, "Unable to set the evtchn callback " "err=%d\n", ret); - goto out; + goto irq_out; } } @@ -157,7 +157,7 @@ static int platform_pci_probe(struct pci_dev *pdev, grant_frames = alloc_xen_mmio(PAGE_SIZE * max_nr_gframes); ret = gnttab_setup_auto_xlat_frames(grant_frames); if (ret) - goto out; + goto irq_out; ret = gnttab_init(); if (ret) goto grant_out; @@ -165,6 +165,9 @@ static int platform_pci_probe(struct pci_dev *pdev, return 0; grant_out: gnttab_free_auto_xlat_frames(); +irq_out: + if (!xen_have_vector_callback) + free_irq(pdev->irq, pdev); out: pci_release_region(pdev, 0); mem_out: -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 12:59:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 12:59:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447582.703982 (Exim 4.92) (envelope-from ) id 1oxpLI-0002aY-N6; Wed, 23 Nov 2022 12:59:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447582.703982; Wed, 23 Nov 2022 12:59:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxpLI-0002aR-KS; Wed, 23 Nov 2022 12:59:08 +0000 Received: by outflank-mailman (input) for mailman id 447582; Wed, 23 Nov 2022 12:59:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxpLH-0002aE-Lt; Wed, 23 Nov 2022 12:59:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxpLH-0004wE-Jo; Wed, 23 Nov 2022 12:59:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxpLH-00014b-8P; Wed, 23 Nov 2022 12:59:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxpLH-0005PX-7x; Wed, 23 Nov 2022 12:59:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HCZ1NQ2QYH6Jz5zVzsS0cLlJSbPzUhw3y+FtGyGZhQ8=; b=2Wwi7anMHy/htNDyITt5yWJuul yl7wLX9EychznI1mGl13dKHEKIXMw9L/NrZdYdfwgSco0IJd/vUy4a3vQOmr/azLehzzS6oigN670 SHqJ/XlQW9adEb494H+ifJcHz2N7HgiUgiilwCOglWWtjEQrUB6umOi45ccx32TmVz9o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [seabios test] 174943: tolerable FAIL - PUSHED X-Osstest-Failures: seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: seabios=3208b098f51a9ef96d0dfa71d5ec3a3eaec88f0a X-Osstest-Versions-That: seabios=85d56f812f4d020b3b486682aff07d9f4a4c60fe From: osstest service owner Date: Wed, 23 Nov 2022 12:59:07 +0000 flight 174943 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/174943/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174925 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174925 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174925 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174925 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174925 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: seabios 3208b098f51a9ef96d0dfa71d5ec3a3eaec88f0a baseline version: seabios 85d56f812f4d020b3b486682aff07d9f4a4c60fe Last test of basis 174925 2022-11-22 18:40:17 Z 0 days Testing same since 174943 2022-11-23 08:40:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Igor Mammedov Michael S. Tsirkin Xuan Zhuo jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/seabios.git 85d56f8..3208b09 3208b098f51a9ef96d0dfa71d5ec3a3eaec88f0a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Nov 23 13:52:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 13:52:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447588.703994 (Exim 4.92) (envelope-from ) id 1oxqAr-00010Z-QV; Wed, 23 Nov 2022 13:52:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447588.703994; Wed, 23 Nov 2022 13:52:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxqAr-00010S-NR; Wed, 23 Nov 2022 13:52:25 +0000 Received: by outflank-mailman (input) for mailman id 447588; Wed, 23 Nov 2022 13:11:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxpX9-0005Cy-9c for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 13:11:23 +0000 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 506acdef-6b30-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 14:11:19 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2022 05:11:03 -0800 Received: from jgronski-mobl.ger.corp.intel.com (HELO localhost) ([10.252.16.163]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2022 05:11:00 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 506acdef-6b30-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669209079; x=1700745079; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=9gwcGwK6aoR5XOXZTGRjJPQ6fKbr/kvLd/b/MtJuVvA=; b=MyfnaHdyl7VAG+l+GdJpYdOCkWYheaGvmxRkkq9hLcwaOiOt3vTHau5M 8GgWs4OuhkFi29CJB0GXfV6YfyzC0Urj2W/4S8knr78XZvRqzseXipr+U aFanTBjZp9uVJgQhh8E4Iwf8fjWgx7pNwJL2YYRWqaixIE980wG3N7oo0 lAUmgJmmmDlJnIWQS4yeiNewOkNHoCpNPdvfjjlk53W72AqyDKLvkUx85 UExOZRQ6bogrHPe3tx3cmACwHf+/cAs+mJlJqKgGPdvxH88dAbdziGTD6 F3lc/I/OI/o5E/sq+u5Dyzp4PGMPcRp4cQOXrI+5ExnK044bY4lWjg17r g==; X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="378319915" X-IronPort-AV: E=Sophos;i="5.96,187,1665471600"; d="scan'208";a="378319915" X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="674722512" X-IronPort-AV: E=Sophos;i="5.96,187,1665471600"; d="scan'208";a="674722512" From: Jani Nikula To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Cc: jani.nikula@intel.com Subject: [PATCH] xen: fix xen.h build for CONFIG_XEN_PVH=y Date: Wed, 23 Nov 2022 15:10:56 +0200 Message-Id: <20221123131057.3864183-1-jani.nikula@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Transfer-Encoding: 8bit For CONFIG_XEN_PVH=y, xen.h uses bool before the type is known. Include earlier. Signed-off-by: Jani Nikula --- include/xen/xen.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/xen/xen.h b/include/xen/xen.h index a99bab817523..7adf59837c25 100644 --- a/include/xen/xen.h +++ b/include/xen/xen.h @@ -2,6 +2,8 @@ #ifndef _XEN_XEN_H #define _XEN_XEN_H +#include + enum xen_domain_type { XEN_NATIVE, /* running on bare hardware */ XEN_PV_DOMAIN, /* running in a PV domain */ @@ -25,8 +27,6 @@ extern bool xen_pvh; #define xen_hvm_domain() (xen_domain_type == XEN_HVM_DOMAIN) #define xen_pvh_domain() (xen_pvh) -#include - extern uint32_t xen_start_flags; #include -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 14:39:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 14:39:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447595.704005 (Exim 4.92) (envelope-from ) id 1oxquQ-0005uv-7R; Wed, 23 Nov 2022 14:39:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447595.704005; Wed, 23 Nov 2022 14:39:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxquQ-0005uo-4k; Wed, 23 Nov 2022 14:39:30 +0000 Received: by outflank-mailman (input) for mailman id 447595; Wed, 23 Nov 2022 14:39:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxquO-0005ui-SE for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 14:39:29 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2061e.outbound.protection.outlook.com [2a01:111:f400:fe59::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a06dc06c-6b3c-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 15:39:26 +0100 (CET) Received: from MW4PR04CA0271.namprd04.prod.outlook.com (2603:10b6:303:89::6) by PH8PR12MB6721.namprd12.prod.outlook.com (2603:10b6:510:1cc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 14:39:23 +0000 Received: from CO1NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:303:89:cafe::73) by MW4PR04CA0271.outlook.office365.com (2603:10b6:303:89::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15 via Frontend Transport; Wed, 23 Nov 2022 14:39:23 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT032.mail.protection.outlook.com (10.13.174.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Wed, 23 Nov 2022 14:39:22 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 23 Nov 2022 08:39:21 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 23 Nov 2022 08:39:21 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 23 Nov 2022 08:39:20 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a06dc06c-6b3c-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IlvCoCnJvtr3SEMZHHStaHq/TlUGPbLIzRquTq7wHSF+s+bXHVEoKFr09C9bAZuRfVwkncesiHM9teYX4LXjy7u2byuT4hCcJFTIw98FZ1EfyfXNvzVeU42OkgSOVK/IIG1axnpRyYp6dXtYx+vN/+NRR4w9swCgCDLFh2PbYZu6tOkW1v2ntVYfP9b8PCgGLki4TEUAcgVcrYR/lJhyAzhCCGMn8vQAch5aVeby5tRCX5e5rmMYSqZg9PG0SG38c7q4Rqsz0t0Qy218ttX6Lm9Sgu7ZZeqNo74TDV7rZQN+3WkitJ4qhT9WSe8t/e3A8ZhZJJ30R3vIujMLwvbabg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=91ztrhNqOMOt8/1qRSE0i4yZUeitmA5IIjtHpwt4LOc=; b=bI00qXmRZDoS8HH2DBs2vJ7Pj8aO6T13E+PQnsBP6AiBUexkpVCj82CpK/0wfbGGWJaQ5bhlbN8Y+RIr5ygMMGu8r9NUMSKuGohqv/tuas4epHoQcmZmZHRJP1pHbbAk0o+9+F3uEyJMjxfIpuHwRCBygVYZdvVs9LuBEu6oswSZIjoxVsnXUIuqXfiWnxjU08tJ47Pe6s8cSG2/V/ZemzfIrAzlvj2/tWJfrgRsnq8pfRBddaBdiwNfl/aB5wQkmaIBXL0tNQqP7PMuM162p1DqA+8haitoic5HRp6qW2uUhThr9kjZNYNIy4DI/49zhUOrIhNFIr7dFLy/t3Lj9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=91ztrhNqOMOt8/1qRSE0i4yZUeitmA5IIjtHpwt4LOc=; b=VyMWm25UnYTdGC3iFOVeXbJqK+4pjPOMDAlw6hIcGTOHT1PKlkEmG17JgU8xURIX+RZi5b9NIh5ksqu6CcOnb6ZPx+0g+b3zP9MYQK1eaB7zXLGEpkRGzddM1o3afJzWupcD1mByRdbcOckBjh+4XLr9+A+lnpZbiM2J4J+mYgE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm: Fix unreachable panic for vpl011 vIRQ Date: Wed, 23 Nov 2022 15:39:13 +0100 Message-ID: <20221123143913.6527-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT032:EE_|PH8PR12MB6721:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c652ef6-a7b7-47c1-a576-08dacd60830f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mtyDhzEhA2+OO3CD5wC+BOsX6bLaPeKcwoZRIEvxGIjIRCSvKWNEzUNRqKaDksP0QB2biNWO+ObeXPiAFcyKKhbI+mdrIkqCEC0wq0XNI48Sp4e22Aey6E3DwndGiTk+agl0uGUG1/L0C9EURhWo7umoz15KB8di/VSr24e464K/YACuIXwyhbbJBBezbyEUDBG54ieV6QAe0+tIUjm1YB7l0hcxZdOGn9+8zBqBzO+BUw8Sgdz9vrmkDjRSE8/0pxi23vjt+gqL3+zDTgTV2J0sg9kfpO0cdqrnXfZ7WUOYsuT5CMpDT612QE2qfF4JCDoYn0TYNdJcpaWR3EpDOxB8nWPPvkiFbDkrCPUF6CzUA37qMygCoMO/4G6G0e46cml7PzSA0cuLmSKLf1DU0bzycXdtbaI98MPKkmtSCbyxNJF0ox78Ww8qmZZ+m4FazVwZPKUCC8iPag6LlALQhs7kXyopTmczEtLe0Zq+9bdSsSob3iZwf1+0n9aQN+ptlzQyRz8JI0EcH1vjWzxTt29Zgbs3+BVQWphtG1bBBUAB6meaGHxgZO8i6IEPGtz20KZw12ImNjj6QGHWD+89Rin5lZjUaDM7IyQWlq1DQCRnkTqUbOngxvos/Q2upCM4FJ8IWJEqHhRvIWb7IM6omxDqgKLxWSq6yA63zpc+0S/FCijiwtpZwmtB2FSIX8/mDMDzC1INpyLfSxpEIHJgHj87PVmrb/HCtC85MPW3uo8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(376002)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(6666004)(36860700001)(4326008)(478600001)(26005)(41300700001)(186003)(44832011)(8936002)(5660300002)(8676002)(2906002)(83380400001)(40460700003)(81166007)(356005)(82740400003)(36756003)(54906003)(70206006)(82310400005)(47076005)(336012)(426003)(1076003)(316002)(2616005)(6916009)(70586007)(40480700001)(86362001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 14:39:22.4179 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c652ef6-a7b7-47c1-a576-08dacd60830f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6721 When creating direct mapped domU, the vIRQ for vpl011 is taken from the SERHND_DTUART serial port using serial_irq. This function can return -1 (i.e. no interrupt found) in which case we should call a panic. However, vpl011_virq is defined as unsigned int which causes the panic to be unreachable, because less than zero comparison of an unsigned value can never be true. Fix it by defining vpl011_virq as int. Fixes: 3580c8b2dfc3 ("xen/arm: if direct-map domain use native UART address and IRQ number for vPL011") Signed-off-by: Michal Orzel --- To be considered to be taken for 4.17, although direct-map depends on CONFIG_STATIC_MEMORY which is marked as unsupported. --- xen/arch/arm/domain_build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index bd30d3798c9a..71a3243f48c5 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3897,7 +3897,7 @@ void __init create_domUs(void) if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) ) { - unsigned int vpl011_virq = GUEST_VPL011_SPI; + int vpl011_virq = GUEST_VPL011_SPI; d_cfg.arch.nr_spis = gic_number_lines() - 32; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 14:47:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 14:47:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447601.704016 (Exim 4.92) (envelope-from ) id 1oxr2P-0007XF-2D; Wed, 23 Nov 2022 14:47:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447601.704016; Wed, 23 Nov 2022 14:47:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxr2O-0007X8-VP; Wed, 23 Nov 2022 14:47:44 +0000 Received: by outflank-mailman (input) for mailman id 447601; Wed, 23 Nov 2022 14:47:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxr2N-0007Wy-1l; Wed, 23 Nov 2022 14:47:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxr2M-0007PC-UZ; Wed, 23 Nov 2022 14:47:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxr2M-00088F-JU; Wed, 23 Nov 2022 14:47:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxr2M-0001jQ-Iw; Wed, 23 Nov 2022 14:47:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+HubBm45FwnKuBprlztavrJ3HXxNbrH55AYGM0u4AQc=; b=X90ncUyX3diuAdTWIWou2r3jWd WhzVF8kSqfhYOsdGx5iklTxaIBsuWe4WhSr6EaLGh2RHBrv9+iBNi0CgYepmb2pnWEFoE3ez9xfXd DVBWLnN7RqvbxD5A81h8KpsFghl9btI/ja92m9UrLtYgX0SiL92vxMfbJnnaEMJe8Wvc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174937: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=4b90adf65a80c33f3359ba9af01759a2551b51cc X-Osstest-Versions-That: libvirt=2a2d5860435909f5619725a6c29583db90aa789b From: osstest service owner Date: Wed, 23 Nov 2022 14:47:42 +0000 flight 174937 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174937/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174907 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174907 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174907 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 4b90adf65a80c33f3359ba9af01759a2551b51cc baseline version: libvirt 2a2d5860435909f5619725a6c29583db90aa789b Last test of basis 174907 2022-11-22 04:20:08 Z 1 days Testing same since 174937 2022-11-23 04:18:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Ehrhardt Jiang Jiacheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 2a2d586043..4b90adf65a 4b90adf65a80c33f3359ba9af01759a2551b51cc -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Nov 23 14:50:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 14:50:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447607.704027 (Exim 4.92) (envelope-from ) id 1oxr56-0000gi-Kd; Wed, 23 Nov 2022 14:50:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447607.704027; Wed, 23 Nov 2022 14:50:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxr56-0000gb-Hr; Wed, 23 Nov 2022 14:50:32 +0000 Received: by outflank-mailman (input) for mailman id 447607; Wed, 23 Nov 2022 14:50:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxr55-0000gV-Eq for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 14:50:31 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2af1eeaa-6b3e-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 15:50:29 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Nov 2022 09:50:14 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH2PR03MB5270.namprd03.prod.outlook.com (2603:10b6:610:94::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 14:50:13 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5857.018; Wed, 23 Nov 2022 14:50:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2af1eeaa-6b3e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669215029; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=aaXdZiB9F/9O4yXuauqr9q4CaJgFdfOSj3tYLWiJoGI=; b=h86hm8NGFMTPA5vQJ4ty6oexCmtvN7OVVPhdP+5RgTMnsUfCcqKwoirk wSOeiTM5qIfdDOBhE7wu6t4Mkwi7uACitdAeRC39zqR/+85Rp52hZYYji Bz3J1VvRS5OFP3Vyr1e8no+ZEUpP6jcRYK3E9v06ojVX9MStswad5HoxW A=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 84477350 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:lSWyr638cAjf49ZMQ/bD5cxwkn2cJEfYwER7XKvMYLTBsI5bp2QFn GMZWWzQPqmJZGXzet0iYIu0908O6MOBnNJjSQY5pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVkPqgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfL0Je0 cQUcTcxdxWhwO+40fXkd7FwmZF2RCXrFNt3VnBI6xj8VK9ja7aTBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6KklwZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXOnBN1NT+DgnhJsqHqD3DcPODwmb2qUg8e7lkCyd4gBK FNBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQqvdE7bSYn3 ViIm5XuHzMHjVGOYXeU97PRpzXiPyEQdDYGfXVdE1tD5MT/qoYuiB6JVsxkDKO+ktzyH3f33 iyOqy89wb4UiKbnypmGwLwOuBr0zrChc+L/zlyGNo55xmuVvLKYWrE= IronPort-HdrOrdr: A9a23:pIjF16g5CYoN1oN+sL9ohIUvEnBQX/J23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu17h/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboXgTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp9KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wXh4SqbpXVd WGPvuso8q+QmnqKUwxeVMfmeBEa05DWituhHJy4vB9nQImx0yRhHFoufD31k1wiK7VDaM0p9 gse54Y6o2nBKUtHN1ALfZETs2tBmPXRxXQdGqUPFT8DakCf2nAspjt/dwOlaiXkbEzvewPca 76ISVlnH93f1irBdyF3ZVN/ByISGKhXS71wsUb45RioLXzSLfiLCXGETkV4oCdiuRaBteeV+ e4OZpQDfOmJWzyGZxR1wm7X5VJM3ERXMAcp95+UVOTpcDALJHsq4XgAb7uDauoFSxhVnL0A3 MFUjS2LMJc7lqzUnu9mxTVU2OFQD2KwXuxKtmuwwE+8vl/CmQXiHlltb2Q3LD6FRRS9qorYU B5PLTr1qumuGjexxe701lU X-IronPort-AV: E=Sophos;i="5.96,187,1665460800"; d="scan'208";a="84477350" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P2MKZEuJD7tDBnlhW6Ago/jlLE7y2ydB01YN7DKdMy1iAeax40lrYt9TY39H887HhbN4vcgMxkT+xcjLD1oM0vc/dqRBpj24ISYswqg5wMgx9Xcpfm9FDwsQ8YCzWJlTmiEM6auyNR8vgPQZ2rqyTAJMIwoSqOMtxkuG3QFJ40Ti7Bf/nf9lWeXddwVVXS7HS0bo61xkLhNvh313DfZRuArt8x7v5LM3jYY5p1qNtHvuIk8SQSbwBTDLOtb56Gi5KMqzuyEMbtR+waUMZXcwWcyXZsgiFj1oiDJ6mott57eNYt8Bez2PcAUayGhoO8Evm5NpS+1FYisBjrAOJWtPCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aaXdZiB9F/9O4yXuauqr9q4CaJgFdfOSj3tYLWiJoGI=; b=dYsw3Qd0k74GAUoyjJqZFAqZ93D+CQSZMd800MlXiILUZ9iuyfie+JV1k/VyrPo+wPy0OG/4En6lAgjrqxDehWR7mh8UOUhp2f+tnS+FDJgi+GMMC1+7ULD6uHpH3DpVveHKuOZqaLWPIdFzrc0VJ2eQavice0ckx1iR6SX09sTdNEf02WmzHaFg7VoNzHcqlP/1kMSvEEhhVJzBFBS2irikpBJ3KqalZ55fqH0HdM+jV2Vc+t4aky4WFoiwTqsZL12/F98gExhuFnr2hz+88tUsZWbaE1Nz2qzRcrYeiAxXWrzeuTRn6FRf3jufe4u7Z7AmFP/HBS599k7qZCELRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aaXdZiB9F/9O4yXuauqr9q4CaJgFdfOSj3tYLWiJoGI=; b=Mm7yd4sgF4nDT1VJK+kgvyh9l/gLZsTpi73hM23fHBRAhRpDukJPvFtBwyo7dSZp2LgkUBB0M8HPm09MU053+Pm8FYAoHl8OkKaVr4sd7/AA0afdKCkC5zkFyYT6ykZbt0SQ6S3TjWuHXtDZqfhJuHq7vcjsugFwcsJrpLqNZIQ= From: Andrew Cooper To: Xen-devel CC: Christian Lindig , David Scott , Edwin Torok , Rob Hoes Subject: Re: [PATCH 1/8] tools/oxenstored: Fix incorrect scope after an if statement Thread-Topic: [PATCH 1/8] tools/oxenstored: Fix incorrect scope after an if statement Thread-Index: AQHY/oYHeahpJxrT+UW3puGtv+tGG65MmLsA Date: Wed, 23 Nov 2022 14:50:12 +0000 Message-ID: References: <20221122152043.8518-1-andrew.cooper3@citrix.com> <20221122152043.8518-2-andrew.cooper3@citrix.com> In-Reply-To: <20221122152043.8518-2-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CH2PR03MB5270:EE_ x-ms-office365-filtering-correlation-id: 8d6fef59-84cd-4664-4c85-08dacd6206a5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZJQg8v0NTaBIcQ5sxlRnWFbguAS3uSwHginuINR1FccGKxna+Uvj7TydKSvHmhCNvG8Gab3Jk0JAMwzHNCn0za5Jffz4U+JLHiQz1JzZvNUEBxYoCIhzjMsGehUFnkK3dphRsdthMTv3+8jyCATPOkZ65VXhs8dvfD1WIJ8vPUxfhxYXHSDo5f3TcwJeDJhKieaN+tE+iFLwMTCQzEirnFIl4ZNn3hBe93hSXUNOw1Bk3AS9HkQ+ojZA/aRAvsaI8Q6jiM2NKfk39GPftkTNOWeFFi2vT53fYQ4YZHU3kay49HMOukv+IeZw8I3e/xXSORaBMoFJ9AFts4/ZxSn33E129He5XO340kXRhjxr9kZB9bQzhRU147v3FHxP/34VqD2dp7ShAB7BK+AS18jANT6OEhpx3Ek6A2v9VG9Ayyng4PGQLkLXJuvypYY+wOHHUlBXw+H4uRRTc4uiUnzQgxfK7jCV8RDbGem50yGTKjkzLeRtkO9Ej79GMwp4JpMGyuNK9ynpowRfUo0Zv+NOtWK1F/XxDsqV9e35++aPwBjnbIMxc07fnuzsLA8LVZwr10TDOWIrpgv3ZsUuxRoQKL6QrayZIMVsqsd5lpYZ1FdU6cjRCBeP5Hwx+/noFL3SdUU1DFniv35fFuWcitoiBOxChG8yPn38se8kgftyukjBWLHMisaUJCTEyhkaoYmyZDmqB3iw8KcW/89OzIIxt+FVUkSAo78BxoGmW7q3YR+OGm52EP1MKENGSwLBMrST+7HpM7eUG4badQXxBEtChQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(366004)(376002)(39860400002)(451199015)(26005)(107886003)(31686004)(71200400001)(38070700005)(6486002)(53546011)(6506007)(478600001)(82960400001)(6512007)(31696002)(86362001)(54906003)(6916009)(83380400001)(2906002)(316002)(38100700002)(41300700001)(66946007)(4326008)(8676002)(91956017)(76116006)(66556008)(64756008)(66476007)(66446008)(122000001)(36756003)(186003)(8936002)(2616005)(5660300002)(66574015)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WFdhUW9LYWYvNXgyYmtRRWNSNTNPMWVNWDlBUjB3VklMUEljQ01pS0FrTzg4?= =?utf-8?B?NmNjZzNkU21lYlB6NTV3dXdVOGxkWjJZOGNISlBvWkIwcHBXRU5hSlZoZE9Y?= =?utf-8?B?bEpDYVJjMkc3b1E3Z1FpSnpwbGpqSFBlWUtpM0tubGZCWFdZUTN4ems5ckJp?= =?utf-8?B?UUV3TXZrcklUSWZkZnBaeFQ0dWNmZDlrWkZxM25nNWMxczN2K01zUU1PSWVm?= =?utf-8?B?RlNNMFZ0MXFCbFB6Qkd1K0ZDUlRwVVBDcm8wSnV0UzVXd3Nwcnp0MUF2REt0?= =?utf-8?B?Qkd1UktTViswc3NtS1Zoc2ZNTUlyZUUxcnVWVzAzV1FHTkJOQkhiUmVmL2hw?= =?utf-8?B?Q2Z0Tk9zMElBR3VUR1ZTSDJ2TzlKODh3dXBzT0lVeHgrUGxMU1JUOGdKdGJH?= =?utf-8?B?K2VZNFEydllkUCtmVFdZaFd1MEJJazVIbXppS01iQWl1VldrMG0xazB3N3Qz?= =?utf-8?B?Y2hXQWx4a3gzd3hpUlNrcms1a1FLYm5rcHVpWVpFcVYwekxUY0hLTlFCVFpR?= =?utf-8?B?MitGeWgxYXFTdm91RHdYbTlWT0h3UGRWbC9HRUlreU1adEdjZXpPTWluZFQy?= =?utf-8?B?ODlQVVIzNWRUQmJlL0FnOUw2QlVXVTV1Y1BHWDN3eCs4OERTNU1EZVY2Sm1w?= =?utf-8?B?ZDg3dzF3dnFCRGh0Z0ZzOTA3b29SNUd6UHdLclhMVW1PaGd1MWR1WFlkbFlO?= =?utf-8?B?UXJmNHVtYTJ4ekhKbmJhZXEzZjRXcjJDejRqcCtlT1IyRzEvUkJtUVZ3aWMz?= =?utf-8?B?aWZLc2R4SWJST3M5Q0ZZVkxlTTNheXVyMGpkdzhXV0lBUG4vamRyVkNkOE9j?= =?utf-8?B?MmFzMEtEak5IL3dMMktTUkVxVGVhcEdyTE94QzUydG9RN3hsZXc5UytCT2V2?= =?utf-8?B?M1BjZHB1WDhNS0c0cGVadFN6Qm5aKytkRlNXQXNIZm9wZXdBc2VER3FNWHBv?= =?utf-8?B?QmtJckNEQWpnNC8zaHNYVnZLaUFLMk5CeXNhU1BGOFNLWDBsR25SMEluaGp3?= =?utf-8?B?Q1YyVGpTUzYwN2hjaUdMbHR2TGNnVzE2RzN5cDRRSllRSlpwclU0SjJsK3hm?= =?utf-8?B?UWg2aWlEWXQ3b1VRZm9kTFZjSXZLY2dLQzIxZW9BWjFYR3lCOVRPNFhhcmxB?= =?utf-8?B?VVJEMXNEMEhZSC84cnllTGljazNFdnE2a0VuQ3N5Zk16SHhwcFBUL1h2cW0v?= =?utf-8?B?WUExSzh5RHMvUFBmSVl4bm5SZlJ3dDZKeVlUNTNQakxicjNmRmZjckk0amhG?= =?utf-8?B?UXFCMEpaUlJpN2VQTmtNMnAyb2x1ZjNnU20wbkdCWDRoRjhkRkxTeUlIdzZl?= =?utf-8?B?RU9mZ1ZFeCsydG00MjhyOGVHV09IZDFlT3dLem14UWpZRHNTbEF6M1liUEl5?= =?utf-8?B?Y0Z2MDB1RkpGLzVScU1ZcENHRXJyamMwd0hCSCt1YnlYaDg4Q0F5UCticW9Y?= =?utf-8?B?SWNyZ2EwWU5aZk9OOVhVLy9WN09xUGJ4ZEZJWnhJQWZOTHdZMzhRb1VuRGtV?= =?utf-8?B?c3g5MHdMUjgwQkhVSlN1VGFKemxLc1JnSjBLdVhnTCs1UG9ieVlMWmRpcDg1?= =?utf-8?B?ZllyZWJhalk0bFVNWUlmRDFsTk9mV1I0T080WUpVaUxpVjRGNEE2UzBtREhD?= =?utf-8?B?NlBIVlllMmdWV3JLVmZISkJaK3IyUXI0elpGTWxqRlFaR3ZCSXdraEVCcUtV?= =?utf-8?B?MWpXVHBMSjhnRjhibGt2TkpldVV0QkJVWW9VNHhUYjJtaUdpQldDK1lBYS9D?= =?utf-8?B?aEpBS3NmN3RyTVMrWHprenFtcGVUemJRendFL1c3Z3Q5d0tua3VrM3RBOUlN?= =?utf-8?B?SHIvL25uQmttTTM2Y1ZCU0dVV1gzYm13dStmb0cwYXRzZWxUSkZaT3FlWUw1?= =?utf-8?B?ZCt5UFN0UFQ1Rk9xb1JSUzFkY21VMWVPYzZUTm80TEdQQlF6SWNjQkFlZkcw?= =?utf-8?B?cWpGV25KdzlHYjVMUUFkTmI4STlaQ2FBTUdNck5DUXJSTnBKcXpSRnNFcHZh?= =?utf-8?B?YXVGSzdTQVBoV0xhUm5XcThRbnVBU2tVNVFBQ3FPWW1yTm5obUVCT01ZUXAw?= =?utf-8?B?QUtQV2t4R0Y3Q1JrZU02NzRML2RNcmk5YUplU3dsRDlzcFdPSWNiY3BTS2hR?= =?utf-8?Q?B6yd1LH1OaKTsrPvlSWp3ZXtJ?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6LghKOL0sF3uWzNyqh00XudQtbe++kfIO2CrQ7kW53gux1Te/VOqQroktoizCArCvb3sVdkKAtNYgIaXyOWxyPVSP+9p/tFidTFEIBfT1he7P2StU2SLiUQvcmXOkCtZ8flRL+DuKlA88hlCtoPM2fF9FJZYpq5SNbAo3IP7A2uGBGDg8fNxODrK3eDL4n+INhxBP1/R2XJqdMXab7qWYSgw0/Fxiy8t31HIfQUurraR+SSC2Um9ZSTtyV0OyUfuaVeUqpu7urAgMIa5G+Rphhc24JIp3hIhsnMJSJlJbMJ8JFNjZwhRIirRhxLRFmdfqSSBbtR38t2oKbdGPzsu4gEdZzdsZsOvdkS2d8gxasXzfIbLyS6Kdg2gi0sHTSGOp1zhHWTNL5ivoLHh9WFnDjBHazvKYkT4IgZfO6lJfV00NPpv5udD3cN7SUPs8DoEaKue/L0ryIgnpsXDf6hx+ecXHYzqcMuhIQfUZR/vh5SYEA1SgosF6534N5LtebyTTBpuURAhObEconGwSEkk3nKZ5kRah9voWHigppyKngteZLPLnjEzHr/0ErIN0ppuHPbcCWIQnwKf8KjO9Y7+Dh0cAsJVQD9XbA3D6vRqzFAuVauZzHdRxDIbzXpUmNKKYhyjKRB1Ye5P5wJC15kDF0ILSjCBMH88F2GNYbunwx0/GHuddMqu/h9CQPFlN7ezCl9uQaSlM84f1BGxJfPHDPqpCJv/qh7XbvIN4WeNQ1xysrqwy46cwV6AFLlGJjiKyTt/JDRHlepqZmJHrU+q9i+EcBOXWyQGdmy/EyRi5d9A0YakmC1t9eGswrr9Vyx5 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d6fef59-84cd-4664-4c85-08dacd6206a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2022 14:50:12.7706 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3gyJNShkuXQsuWxZ9e6vQj9fXAic92x4S5ruWT/0emSpADcs1nnGlMUsq0Vojb3T2TDvwkpetz6bgTpoDmjyhh29H2p/P5W49Vr4Efp3EMQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5270 T24gMjIvMTEvMjAyMiAxNToyMCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gQSBkZWJ1ZyBzdGF0 ZW1lbnQgZ290IGluc2VydGVkIGludG8gYSBzaW5nbGUtZXhwcmVzc2lvbiBpZiBzdGF0ZW1lbnQu DQo+DQo+IEluc2VydCBicmFja2V0cyB0byBnaXZlIHRoZSBpbnRlbmRlZCBtZWFuaW5nLCByYXRo ZXIgdGhhbiB0aGUgYWN0dWFsIG1lYW5pbmcNCj4gd2hlcmUgdGhlICJsZXQgY29uID0gQ29ubmVj dGlvbnMuLi4iIGlzIG91dHNpZGUgYW5kIGV4ZWN1dGVkIHVuY29uZGl0aW9uYWxseS4NCj4NCj4g VGhpcyByZXN1bHRzIGluIHNvbWUgdW5uZWNlc3NhcnkgcmluZyBjaGVja3MgZm9yIGRvbWFpbnMg d2hpY2ggb3RoZXJ3aXNlIGhhdmUNCj4gSU8gY3JlZGl0Lg0KPg0KPiBGaXhlczogNDJmMDU4MWE5 MWQ0ICgidG9vbHMvb3hlbnN0b3JlZDogSW1wbGVtZW50IGxpdmUgdXBkYXRlIGZvciBzb2NrZXQg Y29ubmVjdGlvbnMiKQ0KPiBSZXBvcnRlZC1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4udG9yb2tA Y2l0cml4LmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3Bl cjNAY2l0cml4LmNvbT4NCj4gLS0tDQo+IENDOiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4u bGluZGlnQGNpdHJpeC5jb20+DQo+IENDOiBEYXZpZCBTY290dCA8ZGF2ZUByZWNvaWwub3JnPg0K PiBDQzogRWR3aW4gVG9yb2sgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+DQo+IENDOiBSb2IgSG9l cyA8Um9iLkhvZXNAY2l0cml4LmNvbT4NCg0KQ2hyaXN0aWFuIGRvZXNuJ3QgaGF2ZSB0aGlzIGVt YWlsIGZvciBzb21lIHJlYXNvbiwgYnV0IGhhcyBnaXZlbiBtZSBoaXMNCmFjayBpbiBwcml2YXRl Lg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 23 14:53:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 14:53:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447611.704038 (Exim 4.92) (envelope-from ) id 1oxr7j-0001Gh-3X; Wed, 23 Nov 2022 14:53:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447611.704038; Wed, 23 Nov 2022 14:53:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxr7j-0001Ga-0I; Wed, 23 Nov 2022 14:53:15 +0000 Received: by outflank-mailman (input) for mailman id 447611; Wed, 23 Nov 2022 14:53:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxr7i-0001GS-17 for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 14:53:14 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8d625da1-6b3e-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 15:53:12 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0A3601F85D; Wed, 23 Nov 2022 14:53:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D7EFF13AE7; Wed, 23 Nov 2022 14:53:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bsxDM9czfmO5LgAAMHmgww (envelope-from ); Wed, 23 Nov 2022 14:53:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d625da1-6b3e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669215192; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=unzQ75aMtIVfd3YwrIYzHUC33owzZjI6qKLv47YuZiw=; b=TNzTSTqmDU7eq8ZkUuWL56wij1QbrKM/nRYQKtKoCgdp45MBn+ZLFVoTslnVjZnhgiOYPZ XBlxlo8WY23i4qsfKzCkL4MMqrJsrMJTZRemG0Ijeh8d4RlvCqa9zErEfAnkPjJsa99+Me UTIJqxqZtkQnaBvn7ncYamIhCnhThsw= Message-ID: <99ec5c55-1830-762e-5e50-3bc4ee09cfb4@suse.com> Date: Wed, 23 Nov 2022 15:53:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] xen: fix xen.h build for CONFIG_XEN_PVH=y Content-Language: en-US To: Jani Nikula , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org References: <20221123131057.3864183-1-jani.nikula@intel.com> From: Juergen Gross In-Reply-To: <20221123131057.3864183-1-jani.nikula@intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------5KQQEcrrjT22lnsnNUIznSuJ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------5KQQEcrrjT22lnsnNUIznSuJ Content-Type: multipart/mixed; boundary="------------0xNuNlDOwL4aG0EhIhMncxxA"; protected-headers="v1" From: Juergen Gross To: Jani Nikula , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Message-ID: <99ec5c55-1830-762e-5e50-3bc4ee09cfb4@suse.com> Subject: Re: [PATCH] xen: fix xen.h build for CONFIG_XEN_PVH=y References: <20221123131057.3864183-1-jani.nikula@intel.com> In-Reply-To: <20221123131057.3864183-1-jani.nikula@intel.com> --------------0xNuNlDOwL4aG0EhIhMncxxA Content-Type: multipart/mixed; boundary="------------jaaX4evkLP6HDEbSH7JMxMI2" --------------jaaX4evkLP6HDEbSH7JMxMI2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjMuMTEuMjIgMTQ6MTAsIEphbmkgTmlrdWxhIHdyb3RlOg0KPiBGb3IgQ09ORklHX1hF Tl9QVkg9eSwgeGVuLmggdXNlcyBib29sIGJlZm9yZSB0aGUgdHlwZSBpcyBrbm93bi4gSW5j bHVkZQ0KPiA8bGludXgvdHlwZXMuaD4gZWFybGllci4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6 IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+DQoNClJldmlld2VkLWJ5OiBK dWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0KDQo= --------------jaaX4evkLP6HDEbSH7JMxMI2 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------jaaX4evkLP6HDEbSH7JMxMI2-- --------------0xNuNlDOwL4aG0EhIhMncxxA-- --------------5KQQEcrrjT22lnsnNUIznSuJ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmN+M9cFAwAAAAAACgkQsN6d1ii/Ey/8 BAf/UMfkPm3yCXwNK2PUIxB1sV/F7rGlENqZA9471KfsXpwt4dlGZjm+oxj3l/ewur75s090F9jK QuiTVgIdMyB/Sv+PJxW1wYLEaN3fx6nrOn8/5UJnYvLOP+zCHv2MM27z8GyFCLsFSxlkM7WnmUuH gbZKmo8aJmwh4mjLnTYu58EO49jMbU1ji7ElLzflKaZs0UiCmzCsaBryNHUjWZo47QrmC5+BOYpt oRUVTAWvVFEtvLh3jgDEeiTblq/EECP1M61fjUlR9CXKgRvilIMXnGK63yLWkGUdpncHXNuQGZJ7 nM6T4UFcEI6dBLz20U6qRyJhN5ogQS/D2YKw8CfpJQ== =BX4J -----END PGP SIGNATURE----- --------------5KQQEcrrjT22lnsnNUIznSuJ-- From xen-devel-bounces@lists.xenproject.org Wed Nov 23 15:22:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 15:22:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447623.704053 (Exim 4.92) (envelope-from ) id 1oxra6-00056g-F0; Wed, 23 Nov 2022 15:22:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447623.704053; Wed, 23 Nov 2022 15:22:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxra6-00056Z-Bc; Wed, 23 Nov 2022 15:22:34 +0000 Received: by outflank-mailman (input) for mailman id 447623; Wed, 23 Nov 2022 15:22:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxra4-00056T-Q7 for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 15:22:32 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060e.outbound.protection.outlook.com [2a01:111:f400:7e1a::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a4a0138f-6b42-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 16:22:29 +0100 (CET) Received: from DB6P193CA0019.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::29) by AS8PR08MB5990.eurprd08.prod.outlook.com (2603:10a6:20b:296::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 15:22:25 +0000 Received: from DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:29:cafe::fb) by DB6P193CA0019.outlook.office365.com (2603:10a6:6:29::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15 via Frontend Transport; Wed, 23 Nov 2022 15:22:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT030.mail.protection.outlook.com (100.127.142.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 23 Nov 2022 15:22:25 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Wed, 23 Nov 2022 15:22:24 +0000 Received: from ddb55654d503.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FEC085DD-0E6C-4FA6-A21E-2DD3B94E1F64.1; Wed, 23 Nov 2022 15:22:18 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ddb55654d503.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 23 Nov 2022 15:22:18 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DU2PR08MB10278.eurprd08.prod.outlook.com (2603:10a6:10:46e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 15:22:16 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5857.017; Wed, 23 Nov 2022 15:22:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4a0138f-6b42-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tJGdZSGA+Zz+MDqpTkkfwgrZXKIr7iCq3mH2Mrze9k0=; b=YZ6WkWUoO+4uFLht6l4/9aCpAYlWS/+kxtb9OR6zzEmtH9hYUB4NUstzSjm2HBe467FbcbiJd0b/dlKPOV6qzIHVijcxmhInAw4PiBhAXeVhTe4rOhbE0TPC0uDwMoI0BqkKMBGRJfQCJYx4pm279SvJ5hlXyoOVMCtacXWIIGM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0f1d60f574150f9a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MBlUlss1jq6MT/ASG/mxKCf0NgjHbpdRNPuqTK8Y3Abul/ayGwCaC96V4CM0td+FcfXporg0pXxSIIGtraHzbIuyPcrrVAZkqiD0GHo3BXm2nsnvlLyEKJksvroLqdrl4tdv0NaQROpd+l8fOGryEiQSr20eeiOzP2GdeKIA84mcMC70V+J39/TeEKWNxu0qAXiL4JZ7cL8ihI66LF9ShNngSSwjemgEJ/qQzvQRB/gOZr9Mqd+rXaBUpOteYu6jAy2Fies5jnmKIL5syOLymNBh5v3iUh3pXiUXfo00rd2M3JEzVx5WmtC7tGb1ZkNwLBc4cArQ+m1cwFANHSjtyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tJGdZSGA+Zz+MDqpTkkfwgrZXKIr7iCq3mH2Mrze9k0=; b=ObHKkPQeOSNpS/Rztggj7M8urCHfJTe/AqueJK5bSJ0grzB8NR1en+/4JsdbLUL+Hx62qOt6TXKc4jSNsg75ysTg0HLZounQ7CI5h74XKF3SeijFxXmgYM8mqcDx0AaOKwvhbRVeeANmApkGbue1Ve7iTfbznPhL1fvPYWD2Y+2+fqCZFtaDq+8pIW6C43TZTjkZyd+GSCTL26Ls9njXwu7wI/wde6+P5LDadrOw5GGbvVcfvOUSUAVZ6rupszc5SwOMUjd8dXeCI6/q5wN0DbNLAyDwIPJWKHFQzUR3XnGdbB9E61QVpuMMQOkmVZiW0V153uK2W5V5JYI0m3nRYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tJGdZSGA+Zz+MDqpTkkfwgrZXKIr7iCq3mH2Mrze9k0=; b=YZ6WkWUoO+4uFLht6l4/9aCpAYlWS/+kxtb9OR6zzEmtH9hYUB4NUstzSjm2HBe467FbcbiJd0b/dlKPOV6qzIHVijcxmhInAw4PiBhAXeVhTe4rOhbE0TPC0uDwMoI0BqkKMBGRJfQCJYx4pm279SvJ5hlXyoOVMCtacXWIIGM= From: Bertrand Marquis To: Michal Orzel CC: Xen developer discussion , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: Fix unreachable panic for vpl011 vIRQ Thread-Topic: [PATCH] xen/arm: Fix unreachable panic for vpl011 vIRQ Thread-Index: AQHY/0lo6R8O+m1HBk2HOFtyHTk0r65MoCaA Date: Wed, 23 Nov 2022 15:22:14 +0000 Message-ID: <29E29CB0-35F8-4961-9197-14E8CD7C43CA@arm.com> References: <20221123143913.6527-1-michal.orzel@amd.com> In-Reply-To: <20221123143913.6527-1-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DU2PR08MB10278:EE_|DBAEUR03FT030:EE_|AS8PR08MB5990:EE_ X-MS-Office365-Filtering-Correlation-Id: ac08c42e-dfa3-497a-3521-08dacd66865a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hs6ic3IROOdez/ETdNeqdUi2TPdC4UzErwgigvr8XJ6B0p5EoDjhZ7pPzoHh6PhoCCGwG/amNkNe1omuAO+8j7auKv+QIh5313wBhc6+CPJJmxZQrzrWZNn+X7sbBpTUOB/scxB8dWLy0rJNsGEmzCpXi9CNqr616U+rpKdmnF+pZSVmxs/nAGrbUOptvkQZeepeRK06MD/GynCQ4pS2df/RiOrbxZH865/fRGooaMKaAgWuq2S28VWNRGduE0oNAbjAN7NL6LzGddyW7faZH86mmAM1gCVS+anddPJFad9deLk56KTJ5RY3IUFLW9CgqU17r8Hq8cuxTuVT284bWuqjshTeBbsSmnd8IX5r8k4ppwKqOx0A21rL84H43EIlxnmrZvzGuip+T4sRhIrkCrEoYrpiKRbIRM+UCwyhCJzNEnufp84yvVCF46iN/A2Magm9BMRhkrXJLjh/SYQ2u/0phlamZUOA58HQacNOArIbyBD8gGVlMwfvSAnu3otUk6nhZ6pR4Y61Q43VtYi3TZQK5dOZsNdFGbM8cCgIbXcpUakyKxhaHSjNX4Bi5KwtFV8hed6iDhOYO3kTw/REKyak2zxUvImpY2zbwqpWcWZdD/JEBbjZ5oHWMx7TIpg8OZrkh02D2GpPjbykQuPZdcp+iMu+2HA7VkmBbvyn/hl661x1VVqSKQ7otN6Lc2S7MG35ujp74tiItHoxr+eU3sgt4w5gebqGEn9t5xauVqA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(366004)(396003)(39850400004)(136003)(451199015)(122000001)(38100700002)(38070700005)(83380400001)(186003)(53546011)(2616005)(64756008)(71200400001)(54906003)(26005)(6512007)(66946007)(76116006)(6916009)(66556008)(66446008)(66476007)(6506007)(91956017)(8676002)(478600001)(6486002)(316002)(8936002)(33656002)(5660300002)(2906002)(41300700001)(4326008)(36756003)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <4096B94F8D741C4782097AEF009202DE@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB10278 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e97276ad-8fc0-4ee5-243f-08dacd667fcd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0+ho47lmBH29xXmBAvD0XKHRhmST45z/X5mGZGw/ziUq1ZT+CFwSkqRW1Ollm6pjEWHC3nwJkdd1dUTa+4AsEIfmDaA7PCh0691GVsGmFC24uK9oTVA8WALaBf/eNGn6YB4rmYzVG0o8mggZsf/SnrzbVMYNhnMY9JnEWF8qglOvJqfsCNbHfcu7UOSQuLm0qBfiK0UmLehEgWySE7OJ2X6gZRj9pXBjLBp83qxdR93dfEJlvBYl6QEfD8roors6sD7ew8jFtV8Nwa+jE7DeBKavf+CmfvXFgYfVh0EQ8V3EM2IOjGQGaB021p7F6Fn+bRl+cr3bME2LzOh1oNKdt8oHGqALtQg1yzHmXNFSvvQgUA0z+JhH2YWbaGTyl1o54W2vd1gNYi6b/miEjAafW+Y/tjYZDUT7o8glAhWc0eVWVll3C7Yci2eWy8Bxof8jeNBFcdF6vm04bXLy3Kq89Xy3udKqQ9yvQOr6YSs6BVwft6U14hEZ93Ccdy06q5+CTO4h/8dNFnlz3ElK+2jqAiFz+MBO1ZyWCANoHr4+Yarj1Bm1uDXkWh3Qe59E56DH98uUfszF/EEyPIAXj24l5kbx9T3arbEzB4VIjSTxyXZ0Ue3ogRrjN3kDwY0tYnpGBURQkRKSnP31I9sTJfNaY8EmZfoNDMlGxO/hbAVrRin4qoUeFBo1y3QUwofF9oiieXeKa33BliAx3xqvTumxJg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199015)(40470700004)(36840700001)(46966006)(2906002)(107886003)(336012)(2616005)(47076005)(186003)(26005)(6512007)(36756003)(6486002)(53546011)(478600001)(36860700001)(86362001)(40480700001)(356005)(40460700003)(82740400003)(81166007)(83380400001)(33656002)(6506007)(82310400005)(8936002)(6862004)(41300700001)(8676002)(4326008)(70586007)(54906003)(70206006)(316002)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 15:22:25.0607 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ac08c42e-dfa3-497a-3521-08dacd66865a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5990 Hi Michal, > On 23 Nov 2022, at 14:39, Michal Orzel wrote: >=20 > When creating direct mapped domU, the vIRQ for vpl011 is taken from > the SERHND_DTUART serial port using serial_irq. This function can return > -1 (i.e. no interrupt found) in which case we should call a panic. > However, vpl011_virq is defined as unsigned int which causes the panic > to be unreachable, because less than zero comparison of an unsigned value > can never be true. Fix it by defining vpl011_virq as int. >=20 > Fixes: 3580c8b2dfc3 ("xen/arm: if direct-map domain use native UART addre= ss and IRQ number for vPL011") > Signed-off-by: Michal Orzel Reviewed-by: Bertrand Marquis > --- > To be considered to be taken for 4.17, although direct-map depends on > CONFIG_STATIC_MEMORY which is marked as unsupported. At this stage I do not think we should back port it for the release. We should consider this as candidate for 4.17.1 Cheers Bertrand > --- > xen/arch/arm/domain_build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index bd30d3798c9a..71a3243f48c5 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3897,7 +3897,7 @@ void __init create_domUs(void) >=20 > if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) = ) > { > - unsigned int vpl011_virq =3D GUEST_VPL011_SPI; > + int vpl011_virq =3D GUEST_VPL011_SPI; >=20 > d_cfg.arch.nr_spis =3D gic_number_lines() - 32; >=20 > --=20 > 2.25.1 >=20 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 15:23:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 15:23:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447627.704064 (Exim 4.92) (envelope-from ) id 1oxrbA-0005go-S9; Wed, 23 Nov 2022 15:23:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447627.704064; Wed, 23 Nov 2022 15:23:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrbA-0005gh-P6; Wed, 23 Nov 2022 15:23:40 +0000 Received: by outflank-mailman (input) for mailman id 447627; Wed, 23 Nov 2022 15:23:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrb9-0005fu-3w for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 15:23:39 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cd203fab-6b42-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 16:23:37 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 97C9B2189C; Wed, 23 Nov 2022 15:23:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3CDD413A37; Wed, 23 Nov 2022 15:23:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SAFNDfk6fmPzPAAAMHmgww (envelope-from ); Wed, 23 Nov 2022 15:23:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd203fab-6b42-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669217017; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jKl/2n9Duri+V7Xv3uOwwgRb3uvvikmr0ukBZFQf1Mk=; b=SpMCIN1fG4zdYwA/9m9VIQZEsDVepCuyJHYGstcGmykqeWS6jCqp7+BOGK79IM5AQGTEBu xFV8ML12tBpahAUOoPbp0I65GxNG+mwhuQs+BibU0sN8y+1W6mFjTlyGi+wOPb7TV4i9N2 6aaekmcqjA+klYD/+yQS+M65v2Xow80= Message-ID: <33b9d446-9907-ded6-114e-ce6c43cc3446@suse.com> Date: Wed, 23 Nov 2022 16:23:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 0/2] x86/xen: Fix memory leak issue Content-Language: en-US To: Xiu Jianfeng , boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, jeremy@goop.org Cc: x86@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20221119085923.114889-1-xiujianfeng@huawei.com> From: Juergen Gross In-Reply-To: <20221119085923.114889-1-xiujianfeng@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------N0DXiimiY7GNPY1AcmXVm3jz" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------N0DXiimiY7GNPY1AcmXVm3jz Content-Type: multipart/mixed; boundary="------------1NYcsdjiV7vBEFvXxW2W3UAe"; protected-headers="v1" From: Juergen Gross To: Xiu Jianfeng , boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, jeremy@goop.org Cc: x86@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: <33b9d446-9907-ded6-114e-ce6c43cc3446@suse.com> Subject: Re: [PATCH 0/2] x86/xen: Fix memory leak issue References: <20221119085923.114889-1-xiujianfeng@huawei.com> In-Reply-To: <20221119085923.114889-1-xiujianfeng@huawei.com> --------------1NYcsdjiV7vBEFvXxW2W3UAe Content-Type: multipart/mixed; boundary="------------gcK0ynbRDzFYOLkNi00ebDV5" --------------gcK0ynbRDzFYOLkNi00ebDV5 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTkuMTEuMjIgMDk6NTksIFhpdSBKaWFuZmVuZyB3cm90ZToNCj4gVGhlIG5ldyBzdHJp bmcgYWxsb2NhdGVkIGJ5IGthc3ByaW50ZigpIGlzIGxlYWtlZCBvbiBlcnJvciBwYXRoDQo+ IA0KPiBYaXUgSmlhbmZlbmcgKDIpOg0KPiAgICB4ODYveGVuOiBGaXggbWVtb3J5IGxlYWsg aW4geGVuX3NtcF9pbnRyX2luaXR7X3B2fSgpDQo+ICAgIHg4Ni94ZW46IEZpeCBtZW1vcnkg bGVhayBpbiB4ZW5faW5pdF9sb2NrX2NwdSgpDQo+IA0KPiAgIGFyY2gveDg2L3hlbi9zbXAu YyAgICAgIHwgMTYgKysrKysrKysrKysrLS0tLQ0KPiAgIGFyY2gveDg2L3hlbi9zbXBfcHYu YyAgIHwgIDggKysrKysrLS0NCj4gICBhcmNoL3g4Ni94ZW4vc3BpbmxvY2suYyB8ICAzICsr LQ0KPiAgIDMgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMo LSkNCj4gDQoNCkhtbSwgSSB0aGluayBpdCB3b3VsZCBtYWtlIG1vcmUgc2Vuc2UgdG8gYWx3 YXlzIHN0b3JlIHRoZSBuYW1lIGdlbmVyYXRlZA0KdmlhIGthc3ByaW50ZigpIGluIHRoZSBw ZXJjcHUgdmFyaWFibGUgKGluZGVwZW5kZW50bHkgZnJvbSBzdWNjZWVkaW5nIHRvDQpiaW5k IHRoZSBpcnEpLCBhbmQgaW4gdGhlIHJlbGF0ZWQgZnJlZSBmdW5jdGlvbiB0byBhbHdheXMg a2ZyZWUoKSBpdCBhbmQNCnNldCBpdCB0byBOVUxMIGFnYWluLg0KDQpUaGlzIHdvdWxkIHJl c3VsdCBpbiBsZXNzIGNvZGUuDQoNCg0KSnVlcmdlbg0K --------------gcK0ynbRDzFYOLkNi00ebDV5 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------gcK0ynbRDzFYOLkNi00ebDV5-- --------------1NYcsdjiV7vBEFvXxW2W3UAe-- --------------N0DXiimiY7GNPY1AcmXVm3jz Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmN+OvgFAwAAAAAACgkQsN6d1ii/Ey8f 6Qf+La6ZMkz0ZDoFJuXcyC/fOUM3aKhp9xRv7KTtSs2t2eodYiFenV0E2n1nMMCOpxHyGo0EqcEe AGd5YxjEo2CD09e3UyEFfDLr3ikFePLQXNuCHaMU5Yoeje6Ut253GUmI5ju+zkbe7fmmmdpLikdv MwuAOcGtaEBlhiNjUGMFdVsGT98gwAn1EV/3V3yqPI8/xTHTrmsuD+K2UmEmzrklo4reoKSPJGVu rRwFof65d74gPHNbnRTJjOhPN70rl4hVfljFvyEJ0viZfAllKQ1N803CM9PLD10Yyf5bbX5Ra71a t+25zCFcNorbPav7VPn0vwSIvJnTQrcuOUbqAPViZA== =nikX -----END PGP SIGNATURE----- --------------N0DXiimiY7GNPY1AcmXVm3jz-- From xen-devel-bounces@lists.xenproject.org Wed Nov 23 15:45:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 15:45:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447634.704091 (Exim 4.92) (envelope-from ) id 1oxrwb-0000Ly-5t; Wed, 23 Nov 2022 15:45:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447634.704091; Wed, 23 Nov 2022 15:45:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrwb-0000LC-1C; Wed, 23 Nov 2022 15:45:49 +0000 Received: by outflank-mailman (input) for mailman id 447634; Wed, 23 Nov 2022 15:45:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrwZ-0008Tc-RP for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 15:45:47 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e55031f1-6b45-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 16:45:46 +0100 (CET) Received: from mail-mw2nam04lp2172.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Nov 2022 10:45:45 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM4PR03MB6935.namprd03.prod.outlook.com (2603:10b6:8:47::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 15:45:44 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 15:45:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e55031f1-6b45-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669218346; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=j0eqFRB2p2CzTLiPH9LllAVmtry5VuOqjlnAIGu853k=; b=T0zjxfqfPnY3WYRtRk0p8R0U9d60vJq73sdEMpKSRwadpIEjheviZmyz 3aO65y7+DBvEOB6VNXi3Ss7sUXXDq9HzdceGS2n8digoLiC0Evo5RKF98 PXDQw7JSvuI4eNL3lT06BJ+qBTwAnVQ7KFRbgv6RWNBnfFEqyhcs0NaH7 M=; X-IronPort-RemoteIP: 104.47.73.172 X-IronPort-MID: 85425901 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5SFEIKPAZ0FZstLvrR2XlsFynXyQoLVcMsEvi/4bfWQNrUoihmNSy mZMW2uDOPzZMTb1Ldwlbdmy/RgFsZHRmtEyTwto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5AdmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0txzX0pis r9AEhAiUxujjtKxm7TlbcA506zPLOGzVG8ekldJ6GmFSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vFxujeJpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+toi/w3LKexXqTtIQ6JpGl8Po6h22qmn0jCyMPFlLh+ceGlRvrMz5YA wlOksY0loAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLm0NVDtIctElnM4wWz0x1 1WNks/pBDpgq7mcQzSW8bL8hTG4NDURLGQCTTQZVgZD6N7myLzflTrKR9dnVauq1Nv8HGmsx yjQ9XdkwbIOkcQMyqO3u0jdhC6hrYTISQhz4RjLWmWi7UVyY4vNi5GU1GU3JM1odO6xJmRtd lBd8yRCxIji1a2wqRE= IronPort-HdrOrdr: A9a23:xytmS6FnxK3LjzTdpLqFiJLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LK90c67MAnhHP9OkPIs1NKZMDUO11HYSL2KgbGD/9SkIVyGygc/79 YeT0EBMqyWMbESt6+TjmiF+pQbsaG6GciT9JvjJhxWPGRXgs9bnmRE4lHxKDwKeOAKP+tOKL Osou584xawc3Ueacq2QlEDQuj4vtXO0L72fBIcABYjyQ+WyRel8qTzHRS01goXF2on+8ZpzU H11yjCoomzufCyzRHRk0fV8pRtgdPkjvdTGcCWjcARCzP0ziKlfp5oVbGutC085Muv9FEput /RpApIBbU511rhOkWO5Tf90Qjp1zgjr1fk1F+jmHPm5ej0XigzBcZtjZ9QNkKx0TtpgPhMlI Zwm06JvZteCh3N2Az7+tjzThlv0m65u2Arn+I/h2FWFaEedLhSh4oC+149KuZIIAvKrKQcVM V+BsDV4/hbNXuccnDip2FqhOehW3widy32N3Qqi4iw6Xx7jXp5x0wXyIg0hXEb7q8wTJFC+q DtLrlovKsmdL5ZUYtNQMM6BeenAG3ERhzBdEiIJ078Ka0BM3XR77bq/bQO4v2wcpBg9up8pH 34aiIZiYcOQTOsNSXXt6c7sCwlAV/NEQgF8/supqSQ4dbHNf/W2S7qciFdryLvmYRaPiThYY fCBHtnOY6cEYLQI/c54+SHYeg1FZA/arxghj9pYSP4nuv7bqvXi8f8TNH/YJLQLBdMYBKNPp JEZkm/GPl9 X-IronPort-AV: E=Sophos;i="5.96,187,1665460800"; d="scan'208";a="85425901" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZJ4a0y/tFxin3qYVu+bKWAq0oq4wM9wPjnLpNNYZjR6YzIz5+LCiL9Wi4fU8fdjco40x2U0F4CZ20MfWynzvNbHYsC7ECHnE2CnNkeSU0D4yMjCH3s7e0Jf5KaWKVJ9pHSCwqito5mCDkbTw9AipoiSFDXtZXmFMQHe0fviAUxwQZrmsva+WgWs9J/lsJ+4LPHp3vGLhPwRxLQZHphwcEjb43235/ehhqsn1rIgdB6+WZ8U1jeV6tv7Ngwi66CQThcTpgdta0ozDsi+dtjCaIBGaUeDfwhe6eEc4lO0CxANPpqj0kh/bldYaCq/9DuF8XiJ0JvjREvTudUNb5dCvxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OdFMrPR8EW2lv0Zu+hrAeX4u8IAlUd+YRN8dsbbLR0w=; b=hrVq7CLn6q281VG5Nl1ocisnoL4RR+HqREpD9w2QJjPfy7y3jQAbsnI/C69yshHd5Xc7sOSmmUwzdlzwoRh+e8j6PybGG/q3XBV1ZRvZU73W7+P6rRJ2BhLW4z8pzUwieX7uOGJeuef9jFN5pc5knhpw+Ifv6H5hNnNeU+JHxIr/rr3k5/G2O1P7g8EIj8pOtQ4sIOLpqr7ek4hXjlRz0UaB+UuwYcm2SC8VDoHarMTXkVE+4AUo8e88B95ULZ19oeXg6Wy0PPfa0GrOuHizPk40ln6fzxX8lddIlEBf5KtekqV5n2UByyAawdqFld7JVnDEJs9nOQVl5eK9X1wpdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OdFMrPR8EW2lv0Zu+hrAeX4u8IAlUd+YRN8dsbbLR0w=; b=SmM12KcP/rDrmP4RRsaN168xiBbB87PoP4LKnN2eYmoNQoe26oItG9feFA01p3lUZlabWhIxSNWrHX2brarVUx9zRG+qGXXyLD/xgZ4IsQ7FkW58BJYRBawmaCWmyQo8lu6GgMFBKitZNAY6Aupe5OaTriLY+9vZHqMyZ7jJrWI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: marmarek@invisiblethingslab.com, Roger Pau Monne , Jan Beulich Subject: [PATCH 2/5] efi: only set a console mode if the current one is invalid Date: Wed, 23 Nov 2022 16:45:21 +0100 Message-Id: <20221123154525.63068-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221123154525.63068-1-roger.pau@citrix.com> References: <20221123154525.63068-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0643.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::10) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM4PR03MB6935:EE_ X-MS-Office365-Filtering-Correlation-Id: 11e88ea3-9595-4c58-4c31-08dacd69c82f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W1dpZhMnbvcp/o4BJH1sG9USCrFn8I6r6HZlSiRvjqc/2JsNlCqWM1MYBIWlTy6X6at1qRGQC+cvzJcL7g2E1Ik7c0yQdWLvC5Aa2qele5CDjWXg64pmrwjpViMk0P5w8Si1EJRSdkP57bVNKj8nxuhvSBxW/J0eYpegm0XKELXlSSHTnQkbE1oaItVO1ezdYYDNum3FbXY0KInc/i/ENeCidR+PKRHDX7efef/9J3r42Of24Q6LN3oDwTTY9F01wKiM61ZxIttaAMYSxXoyacoVySoo0PrE1c0T2y2+BV1FMxlahtfFnT5rPnmljEVDj4isZe4fdaslkHyn8VSxSO1ngO+gV0FfgN5bmKpCVTD10JVUPrabEnDgYhd4GrL1HYlaQTCGGbrsiEJHqi+iaSMh/jX78qmH+3M7fg1GmO8B7t+09wdXF1dYIUY9UVl5BeE1OhQkPnR3iIYozWCMUVB19Dwy5eS2Cmf1IV7kLSUvUYbzK5Vm5p/bXpHE9Q1DYEYd5ESg9Anz9sYRSgjL+WPqRsj/qRD/me3O7HM108t5qghiZqKFKSYFrTsN9+Z7MABgJHYMQeDwb6rgiYN8iSinXW6ZIvD7b3qoC6UYHc7kQRkqDEj5b1E6oc0zIU3TSKB3oqUbJPfH3retIQzQGw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(346002)(366004)(451199015)(36756003)(86362001)(41300700001)(66556008)(66946007)(316002)(66476007)(4326008)(8676002)(82960400001)(38100700002)(6486002)(54906003)(6916009)(478600001)(4744005)(186003)(2906002)(5660300002)(8936002)(6506007)(2616005)(1076003)(26005)(6512007)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzVSWWJhOEhzcnR4STZRSUtOYS9xSHhWSkhLeWVaQmh5RnZFZXBmRFhhWkpD?= =?utf-8?B?aG00cUliekJuS3BvekFzeWYyRmRUUnowNFh1eDd1NjAvenZXVGVnb2dCcnQz?= =?utf-8?B?bGM4QXZlbkN3VVR5SG5sLzBlRHZrUElpUUl3ZFFheDhOZm95V0FZc1hVckNK?= =?utf-8?B?ZVR2ODVpWTlmY2xwUlE2UTgrUlVLRkJmYkhnV1FyelJjU25obU02dTNtenE1?= =?utf-8?B?TGF0TDZqRG4xbXJGNTBkZXg2Skxua3p3TU1wK2hyV3p4WU14dWdyUU96WFI2?= =?utf-8?B?RXNUbmNTRCtWdGNRcys2MVpHcEpIQlUwSUJhMnZkLzVLVlZiajVMU3V3ZjZO?= =?utf-8?B?ZDVraGkrT09IWEZzblZydFA5cUhhZEtvWmtJTDR4V2RkZExOcmdvRGFIdk1Y?= =?utf-8?B?WnhEZDBSQWxhSmxvYlpZK015Tnc0TDdFaytBeGZUdFQ4ZTlKRVJzS3dPbkww?= =?utf-8?B?dnVYaWlvM01wWHJzOXVXTjFuYW91NmVNZW13K3pxRERLbFB1QmpHSFBGRzVT?= =?utf-8?B?dkxhRGNWanRmQytDWERlelhUTXIycEtreHlJZkZpdWRQRFB1dTBWRHJxUmw4?= =?utf-8?B?RnlEQVFiQWJCYWs5Z2JRTDAyNWRHUTFOaWUza0h5S2M3bmxDZk1uV0lCUjNO?= =?utf-8?B?eXRScE9kQ3BGQXBpRXB1U2FJaGo4M0QwOWVPRFdWL0tTQURZUkJKZWVaTjNZ?= =?utf-8?B?NDFaeGRzQzJOSTMxeVc5WlhlRGliVUpoUm1rQzZORzd4Tk9HV01nRmxaMVI1?= =?utf-8?B?RUxIdDNqUVljS25BQkZjRnVFZXlyWUFCeVZ1R0dLUndsN2dkcUM3UDVXemhq?= =?utf-8?B?cUtKNDdhYjFYeSt4MkxPcndDd2lnSmNFMS96MVpVOG0ydUZvYnpwWk9OaHJk?= =?utf-8?B?Nk9vTmhlV0E1aFpzMm5FQS9jSDNnd0UzMU1haWtwWno0UUgvZXJjQUdmd1Uv?= =?utf-8?B?c1YycDJ2WlR5M09aeEwxMEVFc1h2TEh0azZuL2RFZEMwYTNxWmJZK0lmM2FF?= =?utf-8?B?Y1k1M1M0VUNlRTdXd0pnaGdsRE4zODlQYVRXK0Fka2FyWEJId1dLcjBGK1E2?= =?utf-8?B?WC9LS3JUMVJtbEhaWEk3dzNGSGFUV0puYzhyRmdWbVJTWEppNXI1Y1NWOTBQ?= =?utf-8?B?cmx2ODBxZmNhejhOMk45ck0rU1BxdmI4RThSVkxxTlRuUUV0bWcveFhJM3gw?= =?utf-8?B?bGtieXJmQ216eCt3NmpjRGtWVUJTWFFBaFNUa3pGdXFIbEcxWG11dVk1d3M3?= =?utf-8?B?ZGprdFJKVWgvTlQ2QVFmSG1UT2NkaGdsM0ZnM2RhK21qeUhGTkZRYnZjck9l?= =?utf-8?B?MlR5bXA4N3RUNWxmWENGMW1xdTJpSUdvUjZzZHJLV0x1NmszMGtaL1gyMnZr?= =?utf-8?B?cmFNVURJVmNKUU9IYmlyekRyTENKWExvZzVNWjJmMW9OZDc0eFUwSVhMNUpT?= =?utf-8?B?UVF3NmxBV05ZRGRkOWVIcW1YSlo0NnM0dlI1WVZnME85cnk4QUJkZjNnYjZz?= =?utf-8?B?Q0NUSWNtU3dUMTlYOWUyMjFHQk1mU01NQmhpRk8wTUpqTGNJdk9ieXVjUnFy?= =?utf-8?B?Y3ZPQ3dwOW80US82VXBrb2lEN1FFS0ZNR1dQTm5LZGxaTVBPWXIrVGZ6RlBz?= =?utf-8?B?L3F5dXN6RzZwR2xvbm9oZHFSSmc4TExoZC9RWVVUZE1VZkhsc3Y2U0h0NTV1?= =?utf-8?B?SUJiallJOTlrZ3ZrbXFnVWRPaXFkRS9IWVBZRDBVVkpBdzZ1MTQ5Q2hCK3BF?= =?utf-8?B?bVFoMFJKbkJYZldZNVVWNkZzNW4xb3E4RlNZNXdmT3VDZzdjNDNYN0hjR3o3?= =?utf-8?B?SHpFb2Z3c1VmUjA4dGx6RjQ5MUJoQ0xKcXNvOGVUZy84MVlQcHBHQTBOSUU1?= =?utf-8?B?d0ZETnAvUTY4bWh6a3QvTkRsNkErbTdHWXQxbzR5SnZNUGhZM1ErMzd2ck9a?= =?utf-8?B?QzVzV1Z4MGtvalhUcjhYSlowL28yWUhtcmorOEU1OEYyeTBhbVd1SlFYNWRa?= =?utf-8?B?andsNi82SkZ1Q2ppelZWS1V4QkZzeEVGekJ2K1UraU9vNGNNci9Sc3pKY0ls?= =?utf-8?B?MjUxQVJWMng2SXF0L0cvWGl5d3lncng5MGJ1MitIUHQ0UEJNeGp5SnBWRkI2?= =?utf-8?Q?Ur77vRSkKUELgfiLHCJdIgST4?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: sQw0d2R/4kXK8gFxVrllvMenlohL903dxhsTBiwYgw54d5bBlCa0woxdhW0O9uFbnIdW2lHImtUW/Gw1GDCrChxZZNPybG+ZH79lgJzutmO3AcS0lHdwtibcz1hEbIcuIKMuEhxnnZ6abJtbRMqiAwpVdVLT6nrtbiJsVeM2AhU1NGMOamTTcOxS+LjEDbGYKA8O8erp3Cr/gU+DXbQL+HtUoxVAgt2sTmzj10+bM8HkaubyH+DGLvNZfqrdSJCJqCRwRFqGZWtuRxXGgQjF8td95R04CtzBtoyynjNnxcTQQt70EHGJItVXXTfZmJqECCjZfZLdoQGA2yMv0khnUs19SEYp81GX9KQvrH/dg2EPJFgeZH7uh8qfgAtONdAlrhj4RKNSLx8v0jUnMIf33Eveu4l5XG0FBePqqZNi6UshVfX8LLzRppYtpEs4A+WoatdCsrAhsEE2PwgpLCmebah5ZkY5xSt3VZaojPqIlq9YHdbYYPLQpz0wIfAqO4kwUayw4VSkXJGfNysJk8D7AGMHEAV7IqeSbvaj5UzIcM9r0OQnlNkCHQ9Adeq7pauNuto2ViMe5EXs/4fmdTZDvjCVL0GZ+FA8CzyJNNfRzmyaZ4JzFdGOYSifV4sERrSZJQl3EXJpTNTHJEOrbVPPFJ4Am7dz3Wj/lh9CWMQ7zOqwYC6DmunWChXhFh3fAWFQ4DzJVuMEtbSlECmfLVk/yVWR78WmAXYcvtuWdxC3P6qLZefUOuqWTxp00YzuMUG3dxfZp4WJ/SwCkHGLVoX1bRQ2abHlu9SoxMtJo6ETCQRcoz7pXgMGGQIPYsLWKGUq1yg+3rT0JFRPoV/9jENqFV0AB4ffZYuLrQyzNLIJWuo= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11e88ea3-9595-4c58-4c31-08dacd69c82f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 15:45:44.1711 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3GJU/zOriBRiTh0AE8G8o3GOpcn2XGN3AdFx4Ht8iBP1f9mSJUaoOi2SaGnjlmevoIcs6XOOAKc8yABYEYCC6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6935 Do not unconditionally set a mode in efi_console_set_mode(), do so only if the currently set mode is not valid. Signed-off-by: Roger Pau Monné --- xen/common/efi/boot.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index db0340c8e2..7e8a8b7857 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -799,6 +799,11 @@ static void __init efi_console_set_mode(void) UINTN cols, rows, size; unsigned int best, i; + /* Only set a mode if the current one is not valid. */ + if ( StdOut->QueryMode(StdOut, StdOut->Mode->Mode, &cols, &rows) == + EFI_SUCCESS ) + return; + for ( i = 0, size = 0, best = StdOut->Mode->Mode; i < StdOut->Mode->MaxMode; ++i ) { -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 15:45:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 15:45:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447633.704085 (Exim 4.92) (envelope-from ) id 1oxrwa-0000IH-SQ; Wed, 23 Nov 2022 15:45:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447633.704085; Wed, 23 Nov 2022 15:45:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrwa-0000IA-Pl; Wed, 23 Nov 2022 15:45:48 +0000 Received: by outflank-mailman (input) for mailman id 447633; Wed, 23 Nov 2022 15:45:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrwZ-0008Tc-2G for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 15:45:47 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e3846b7b-6b45-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 16:45:45 +0100 (CET) Received: from mail-mw2nam04lp2177.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Nov 2022 10:45:41 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM4PR03MB6935.namprd03.prod.outlook.com (2603:10b6:8:47::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 15:45:39 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 15:45:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3846b7b-6b45-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669218344; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=IvQbbGWxta8BOU6NuWUtOzHVaS0IfJ/5pqW/Sjjha+0=; b=ZT9Z2ehWaxW/+tnNR+EqLjE2wgqJa7bHpvKDYbpUDgWHmmQGwBruOJh7 MT+6ox1ad0Q/JSxzpsS4hxynOor/srNzQyGpH5X/JATjGZaZ+gYlyHc/C ExeePRAXwDNwPRp+QpH0cBCAPQAdCGq/GinOHMeId9bNhRYr/k+rdvEoH I=; X-IronPort-RemoteIP: 104.47.73.177 X-IronPort-MID: 85425892 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:H92EDa1erck4eEgpcfbD5T1wkn2cJEfYwER7XKvMYLTBsI5bp2MEz TYdWz+BO6vYN2fwetl+YY23/BkHu8PTzdE1HgFopC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVkPqgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfLE1lx 8A9Bi82NDO4wM/r6rKiTsNwiZF2RCXrFNt3VnBI6xj8VapjZK+ZBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouC6Kk1MZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r827OVwHOqAur+EpWhr98xvBqX5lVLVh09DnS4rdKliVOHDoc3x 0s8v3BGQbIJ3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsSzdbbdU8ucweRDo01 0SIldfkGTxutrKOTXuXsLyTqFuaOyIYMGsDbi8sVhYe7p/op4Rbpg3LZsZuFuiylNKdMTPtx zGHqgAuirNVitQEv42g5kzOiT+oopnPTyY26x/RU2bj6Rl2DLNJfKSt4FnfqPNfdoCQSwHdu GBewpfBqucTEZuKiSqBBv0XG62k7OqENzuahkNzG54m9HKm/HvLkZ1s3QyS7XxBaq4sEQIFq meJ0e+NzPe/5EeXUJI= IronPort-HdrOrdr: A9a23:dpotOKsyZ4rq5Wszh1m+HKvF7skCFoAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBHhHPlOkPMs1NaZLXLbUQ6TQL2KgrGSpwEIdxefygcZ79 YYT0EcMqyOMbEFt7ec3ODQKb9Jrri6GeKT9J/jJh9WPH1XgspbnmJE42igYy5LrF4sP+tFKH PQ3LswmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzI39QWUijusybjiVzyVxA0XXT9jyaortT GtqX2y2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuQFNzn2jQ6sRYJ5H5mPpio8ru2D4Esj1P PMvxAjFcJu7G65RBD/nTLdny3blBo+4X7rzlGVxVPlvMzCXTo/T+5Mn5hQfBf141cp+IgU6t MC40up875sST/QliX04NbFEzlsi0qPuHIn1coelWZWX4cyYKJY6aYf4ERWOpEdGz+S0vFvLM BeSOXnoNpGe1KTaH7U+kFp3dyXR3w2WiyLR0AT0/blpgR+rTRc9Q811cYflnAP+NYWUJ9f/d nJNaxuifVnUtIWRbgVPpZOfeKHTkj2BT7cOmObJlrqUIsdPWjWlpLx6LIpoMm3ZZ0zyocokp ipaiIWiYcLQTOvNSSy5uwJzviUK1/NHwgFi/suq6SRg4eMBYYCaka4ORUTe8jJmYRsPiSUYY f2BHtsOY6SEYLfI/c24+TAYegiFZBnarxyhj8aYSP7niuZEPycisXrNNDuGZHKLREIHkvCP1 prZkmBGCwH1DHnZkPF X-IronPort-AV: E=Sophos;i="5.96,187,1665460800"; d="scan'208";a="85425892" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bJNNP/A1EP399rVzYLncv4RFnxE5LnSEYxAokaCTDBcy6AhGDZeJSThiX9gZEnJh/G55wqsdfnAszO46o+s0qWaCbYlYutPa8PpJpPNZLOxMxpVF11I4qDWf/lVDdB9xY6NZPsOBG+Mx/UnVibihZhR1nkgxAW+VfQHnrSa3VdNHU80CTfI4/nKLC8qonoww2yLaZbrPZ+b7nYH8cLbzRWQMPhiZ8gfiRrMEDJ0R7Ku4UqlPEi0wKrRNwD2LREkMkXV+ZmRdA7nMc1Q4e5OfZR4bojHasMMEqPiDwtPjoYgVDC7Zp5BNlLGO1PRU4IFo4uGuIh9uWKS992G6JPGT1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ijoTp2u9ZjfF4M3JsrM4RqHyGjKHHh5FQnpmKT5pXL8=; b=WVRIw6Bwn9wABibvjF5Bt1sF9UyvmyoN4s/n+G81aocW9xuKHA4IIwm1kX1qmy7ldX3efpBPkfhcSZbeN5PJNx8v3UdyBQ/8ElrsHDhvwHD83qKvn6qCB3hHpzPHgdzt3JS3Vwk9w516zFhilaVrtc7Ummbr9SfQdHANfOz0SG/TK6DWeDIDiHSDzCwpyMoA0KhMSz9T2nJvsM8vyVEirbGT+XtujJV0CK+0MjjPap5a2UYRzyGeQSk5WyNI1RMESFH/5GjiYsgn5cz6W0h8LLOfUOr+2QjKzABpHJ0K/CuVNrimx7I84TAcUfc7rEd3RNdVa9zDvoGbeyjmYLqIzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ijoTp2u9ZjfF4M3JsrM4RqHyGjKHHh5FQnpmKT5pXL8=; b=jRxKeSP3Gl+fmWAwE4+FF3vbTY6zG9fDjDC63OXgbAdmMxPopD5jaCNDbeD12NttSrdvtvFSOp2L20tXGM30UhqUrmmUUn6KsXIjfChsJ3+fut7ZN2inTUfpzsxLYHQtgT9hvQZnBEKRr38meqcHhrk6NPGa1PVkDo0zzdLdbzg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: marmarek@invisiblethingslab.com, Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH 1/5] x86/platform: introduce hypercall to get initial video console settings Date: Wed, 23 Nov 2022 16:45:20 +0100 Message-Id: <20221123154525.63068-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221123154525.63068-1-roger.pau@citrix.com> References: <20221123154525.63068-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0534.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::19) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM4PR03MB6935:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c6fcbc1-6e5d-4547-8d5e-08dacd69c52c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EYHDaoyi020U3R0Vs3XR2TVA7oK3rE2HaB7ZdMmIEbV4D93tVl/nZU69nKdrOd/BVtWyFqlNOQvBfPhNsaj2DZUyh5BTDDUa0NWF8uMpxWtAemDfJWyDteAHphW8/QNaBHDoo/zTI3TUt3MLoDCLy45D4p/cg7grmqD7GQG4PAJ1kasAXX5gy2AERcaz8WwS+xgMUyw1EtjR+mnAnLWmU/7bs+Gd7Ucvds0zh9Zqm63q3LCeaDd0aDiUPJmLea2JlrCChrTtMoH+qFeIpjaUZ59CwjeCesXd1WCQewVccr36bQrHvIpv8KA2RZXcLW2to7sBKMn8u6/oTfkCZV/YmT0kviQ2+BfLrILJcNanuniMwPr8dlPCbjn/E2kYJTPfwK3HLuU+/kPnUZwnynarDn5Stc4wdjmubqoaZrKMSs6CA4GOG3TnimlV5KmhYeuLB/TrIp/rkqxmYuB/l0+2WpfxaGfpRV3MSNGvl4A04ALa5VZAYxXIwpAo197BIzhw7S7qti9dV9oWSyWnslzlLXlfVh0hBLJEJvRmMhX5+NxY7rl12lEMTkTPKdVPqkTuGDchZ8G7lyrpU1ucNMXSMxNROTgau2DMuuo2nnFHPHWnMDhSFfOTKMqWh6BJF87uq5pP2q66RMrCmUqko7Cy7g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(346002)(366004)(451199015)(36756003)(86362001)(41300700001)(66556008)(66946007)(316002)(66476007)(4326008)(8676002)(82960400001)(38100700002)(6486002)(83380400001)(54906003)(6916009)(478600001)(186003)(2906002)(5660300002)(8936002)(6506007)(2616005)(1076003)(26005)(6512007)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGFjWDdDa1NPcW5LYlJDUWowMG5VZExQcVFKMkQzQzFJZm4xM0NpbzFHK1Rt?= =?utf-8?B?dEd2NWQ5M2lNM0k0SUFTbXRFSm1oRjBHaUxTb0cycTNpSUZVZFlScFloZmhv?= =?utf-8?B?UFB6S3IwcWgzbDIwSVpvQTJ0WnRTVmJxYVZBV1dyU0lZVFB0OVBRNWdBMTcy?= =?utf-8?B?SVJFTjdjNGZScGVudHJSSU5MWXc1cEdXdzh6Qk53QTV4WXZOQlpISmk2b0ll?= =?utf-8?B?Y2dTSXBrY2tpVklvajhESUc1cVhLbEVSMGV2YlFTaTVJR2NpcVZ4Z2NKQ2Yv?= =?utf-8?B?YzZleWd1bVlQOHhhbjUwZkpFa3gwYUFDZWlqQjhCNWRGZnYvMUZzUDQzRE95?= =?utf-8?B?Q1ZTUUd6QUtBT1B2Z3hIaE45eTFIQnNwM2gwbVZxLzNaYXJPNldIYTgyajhP?= =?utf-8?B?VExIRHpDUDRiam1uamc4YnAzRkMxcWcxNHlnL2sxb3VldmdqREMyckQ1d0V2?= =?utf-8?B?cnMzb2NXMGE0b1d6ZUxxclhHNTdBMmQrcXkvT29tbExzbVFxeTRyYVQyN2NP?= =?utf-8?B?dWF2MDdvQUZDOFNNUEk4UmxrVjVpTUhoV3JJeGY3anNUVXJacHQ1aXZ5SU41?= =?utf-8?B?cWVDRXZGU2kvMTIvbWFwU01uWnVCV2dFT2I4SThWOWNnaUU4NmNvcEIwbWNx?= =?utf-8?B?a3QrWWRpQTBjaHRQZGMrWnhzTnJYSjRENFFHdjJEeFJuRTN2QkpRUWhtQ0g0?= =?utf-8?B?OENLZnJqbE9hL2hFQk1nMXg5OE5Qb1dleTZRNHNad1hEYk9rd0s2QUtya2U3?= =?utf-8?B?L0pUbklCdnBtOVh2Y040TlNsbmRRcUtKaGdQdElUWFM5WHAzWmlmZTV4YUtl?= =?utf-8?B?K2gvSXkzQU9rRDNMNitDZzQ2LzU1OTRNQzFXS2xoVkllY0xXbDB6UGpkcCsy?= =?utf-8?B?YmpLd2ZkUkplRnRUNUZneXA0VlcvcjNhU2VvbE11QnBTNVprbHppdktyOTZX?= =?utf-8?B?c1U2UlcwZjFFUmF4ODZacHRZWjdJS0EyTklKL3hXbUIzTldiL3FwOS9XMURp?= =?utf-8?B?dEt3bjB2VjAzSUhyNFdiOFVQeEVXRGd1WUx6eXZXOGZickd6ZTFmZzh0UU8w?= =?utf-8?B?Y1FCYXVwWGxZdk9jSHU4MWE4bE5OVmRDTE1NejZyYjZSalh2cmtBWUQvLy9o?= =?utf-8?B?NTIwaUJTZFRsd1g2ZStPalBwL3FvUERmRHlJQWQ0ZkhHK0xWMHdIZjNtS2Vz?= =?utf-8?B?cVpMc0ZYOTh4WEdiRzJvaGF0c0w3YzdSOWFvUWdjdGxGTzNXYytFTFY1RkE3?= =?utf-8?B?S0RYRTFObDQ4UVV5OWphVDFLK3VEcWZ4bmtYQi8zTXB5WnNuSmQ1Q0RyaHpH?= =?utf-8?B?OUdsTm1pSEtDNjhwVjEyUXN1MzB5WXYrR3pKVktGdUZ3YjBtS1lZNWJzVGpE?= =?utf-8?B?L2Y4WnlVaE1TazNJZW9NQU9LTHkxMW11SFJaYkNsRDFqL2VhTm5aVmNNMFd0?= =?utf-8?B?SFZSdklIWGhadWxOV1BRZHZOZythdnFxd0hWZTdEc0dyMC80azg0Q2t3MUlR?= =?utf-8?B?VWk5QTc5YXFwcXpsN1UwRG54UngxYkpYWG81Q1U0SjRWV1NNd3VzREYwOWNa?= =?utf-8?B?d29EbHdDR0tKcjFuNGVEeGNXcExuNC9ObEpzSWVUTmZFWVJDQmZMQm1aY3N0?= =?utf-8?B?bFB2SG1zdlNNNDZ3QlM5MUVJd3R0R1BCcEZBQ24wMmU5QnRiUDhCaVhWTnFV?= =?utf-8?B?Wm92bEI2NUxucmtjd29BbXB1ZjBhZHpjdW1oTlpiY0FSTW11cFdxVjExeFcz?= =?utf-8?B?TkNhVkZHTTdVb3Zab21JYVN2KzcvZlhuR1BzT3FRai8xdzI4c3UxQ24ycmtL?= =?utf-8?B?MFZieWx4ZFlVTHB1b3BCdHNvY1o1NWhzSG9pUytPQ0JOdWNHQ1gzTFFxdmVE?= =?utf-8?B?RUxSQkVkUVFWam9haUpHeXg2eFZONkFmUk5kZEhwZk42NWhNbk43Z0FmQk0z?= =?utf-8?B?YzROdzJuRklPTnRvK0Eyb1hhQ25OdHEyYkRlZkZ6SEQrZVRUSUJ2VCtyWXI3?= =?utf-8?B?cER3T2FMaVlEdGF3bmVMRlRZeUs2N3dtS1Q5L1g5VnQzdGxLMlpUSy92Zno2?= =?utf-8?B?K1J1Z0xOenV0S3VSM20xRllpd1FOS2NHM2p6YXdYVXBndGozRTdJUjdPQUdI?= =?utf-8?Q?njHo4IPcQ1xRqMdxl8muPwlPQ?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?Q2lXSUhFbExITUJOeXNVVTFWempCR3l1YjdobTAvaTVXUmNKSXBMcHV0Q3g3?= =?utf-8?B?L2tpNU9BUUxVOTQxdytkRUd4TVNqbEJDUG80S2VmcmxJb1I5QzRZaFB1NlNG?= =?utf-8?B?Wk9PYW9uVG1WaVJxTjYySGNZVSszYVovR2RYSGU0VUVleGg1bm5yWExnbFBk?= =?utf-8?B?MERWMDBvWmp4TmNDdTZkUWVmRW4wNlh1bVRncm1WSFExbFpVb3lEbCt0Nkt5?= =?utf-8?B?Tk5zdGhpUkczZEQ3WUtZTVR3VllENzlqRVQwRXhzSVRjckpnb2ppSXErcmZh?= =?utf-8?B?azN1bXlXRFh5cGU5aWVpS1lISHR4VXA3d1lFS2gzQTc0Y1phaHJnOTR1QnAy?= =?utf-8?B?TEVSNEwxTWFEbW4wRk96Mk1PMlptMjdVcDBzR3lHVHpwdkdKRERFYWEzSEtL?= =?utf-8?B?dzRoUzhmRmZubXlkQVl0aFBRcXZ0UDRVdE13Z2dWWmpWNWRWSEM3UEVGNGZu?= =?utf-8?B?OWEzZmYyVm0xZm1jOWhrOEJGNkNWTDY5MHBlZitsbHlBcVl5M3hXK2R3QWJZ?= =?utf-8?B?YUJrUlltSUE1NlBib1hxRXdyRnlhbkduZHJBTlJ4Rnd3VDN0ZmwrZm53ekha?= =?utf-8?B?MXRLRllTQm5RNFlPYXRFQkZvVEU1MG5DS3VEVENqcDlacXM3RWRpbTNka0dp?= =?utf-8?B?N251MDdpdVM2bEpacTBrd0dLYmoxNzkvbGpzOXhsZVJzTW4zOFkvNnlPK0dD?= =?utf-8?B?TWJTV2tlWnBOSC9jM3BxOUIwdk5SVHd6Qys1VHZqYmpDVGdNZ1dIblcxR251?= =?utf-8?B?MHRISENySlFoYlJKYy8xQUVlR1UxS3VOSzY3L1hBRS9Nd3JiUHI4VXRCdnha?= =?utf-8?B?aXFETUJ1ODlqa0JzWnVwS0dSaVVOeCtIanRKRHk3aHhuV3h4WEdkZTk0Q1FX?= =?utf-8?B?Q1gvQXE2cVZMZlJUUFVwRWh0KzdQblFKZmFIdWNvY2FHMkhuZmZEOXlXN1NZ?= =?utf-8?B?cjhQaFFKVlNWTk5vQVhsNUJlT05mWDE4RldHZVJ3VW1mOHVFT3luckdBNGUz?= =?utf-8?B?T29zWGZBcHdRaTFjOFFPYXFiVWVQQUZPdEljaVpsSWdQNkYvM1hFK2xmWHUv?= =?utf-8?B?Q1dTYU9kdU15Yzczai9rb0dWTUMyL2Q3cmNiNXRjT1d2TmVEMXNHbllHMzM1?= =?utf-8?B?UTVhRUdRcTd3OWp6VXBxdC9lbmhTUTh3emNiamtHTTVvTlBlcGZiWE5qSTV4?= =?utf-8?B?a0lrTGlPV2hDNFlycXhWQXIrZHM1empYa3N3b2dLdG9xaHAyVlFuMVc4MUdK?= =?utf-8?Q?q1GOsHwctiPvY+b?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c6fcbc1-6e5d-4547-8d5e-08dacd69c52c X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 15:45:39.2137 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6ZrmzDV8EVFYEjS9rROJ+VFh9NztKUJCrrOQ2DyLtgirDyN+gSwDbnbGWGX52HW7zrIrcUNzjndy67GcN5RO0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6935 This is required so PVH dom0 can get the initial video console state as handled by Xen. PV dom0 will get this as part of the start_info, but it doesn't seem necessary to place such information in the HVM start info. Signed-off-by: Roger Pau Monné --- xen/arch/x86/platform_hypercall.c | 11 +++++++++++ xen/drivers/video/vga.c | 2 +- xen/include/public/platform.h | 6 ++++++ 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/platform_hypercall.c b/xen/arch/x86/platform_hypercall.c index a7341dc3d7..3f0d0389af 100644 --- a/xen/arch/x86/platform_hypercall.c +++ b/xen/arch/x86/platform_hypercall.c @@ -839,6 +839,17 @@ ret_t do_platform_op( } break; + case XENPF_get_dom0_console: + if ( !fill_console_start_info(&op->u.dom0_console) ) + { + ret = -ENODEV; + break; + } + + if ( copy_field_to_guest(u_xenpf_op, op, u.dom0_console) ) + ret = -EFAULT; + break; + default: ret = -ENOSYS; break; diff --git a/xen/drivers/video/vga.c b/xen/drivers/video/vga.c index 29a88e8241..0a03508bee 100644 --- a/xen/drivers/video/vga.c +++ b/xen/drivers/video/vga.c @@ -205,7 +205,7 @@ static void cf_check vga_text_puts(const char *s, size_t nr) } } -int __init fill_console_start_info(struct dom0_vga_console_info *ci) +int fill_console_start_info(struct dom0_vga_console_info *ci) { memcpy(ci, &vga_console_info, sizeof(*ci)); return 1; diff --git a/xen/include/public/platform.h b/xen/include/public/platform.h index 5e1494fe9a..14784dfa77 100644 --- a/xen/include/public/platform.h +++ b/xen/include/public/platform.h @@ -605,6 +605,11 @@ struct xenpf_symdata { typedef struct xenpf_symdata xenpf_symdata_t; DEFINE_XEN_GUEST_HANDLE(xenpf_symdata_t); +/* Fetch the video console information and mode setup by Xen. */ +#define XENPF_get_dom0_console 64 +typedef struct dom0_vga_console_info xenpf_dom0_console_t; +DEFINE_XEN_GUEST_HANDLE(xenpf_dom0_console_t); + /* * ` enum neg_errnoval * ` HYPERVISOR_platform_op(const struct xen_platform_op*); @@ -635,6 +640,7 @@ struct xen_platform_op { xenpf_core_parking_t core_parking; xenpf_resource_op_t resource_op; xenpf_symdata_t symdata; + xenpf_dom0_console_t dom0_console; uint8_t pad[128]; } u; }; -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 15:45:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 15:45:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447632.704075 (Exim 4.92) (envelope-from ) id 1oxrwZ-0008Tu-Lh; Wed, 23 Nov 2022 15:45:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447632.704075; Wed, 23 Nov 2022 15:45:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrwZ-0008Tn-IW; Wed, 23 Nov 2022 15:45:47 +0000 Received: by outflank-mailman (input) for mailman id 447632; Wed, 23 Nov 2022 15:45:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrwY-0008Tb-H2 for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 15:45:46 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e3185d9b-6b45-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 16:45:44 +0100 (CET) Received: from mail-mw2nam12lp2046.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Nov 2022 10:45:36 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM4PR03MB6935.namprd03.prod.outlook.com (2603:10b6:8:47::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 15:45:34 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 15:45:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3185d9b-6b45-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669218343; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=plv8Q/8wTHHJVj3Exini4Rly0YHMh3Y9VO5rXghbQe0=; b=c51nM1MgdarYxVwI4XHqlVoof0Sn4NHUybL8rGe+L7ZXmXInppV6Gp75 BCpoSRRpolh/mxffv1yTE20Hth2Zh+Y3KripkcvAqTXsX8SsWHEZPhKav +hFq+vMjzHV1MsfW1z6Ixa2/IRXI/ejcw1tflBrkBpvKKKn8NeiDsk1t6 c=; X-IronPort-RemoteIP: 104.47.66.46 X-IronPort-MID: 87966129 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4Q6ElKkn8aPlJog3pXhkd/bo5gxuJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIdUDyBMq2MMTamKdgnb9yxpxlQ75GGmN4wTlc+q38xRSMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5gSGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 d1IbzAqZwCivKWv6pORQ8s2l5kHdvC+aevzulk4pd3YJdAPZMmZBoD1v5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVklI3jOaF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efwnKlBttIRdVU8NZWn2WLyHQzSycTWFu84tWDkBG9ZIlAf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpbdU8scYsSD8C1 1mXnsjoDzhirL2UT32G8r6e6zi1PEA9L2UPeCsFRgst+MT4rcc4iRenZslnOL64iJvyAz6Y6 zKXqCkzgZ0DgMhN0L+0lXjcmC6lrJXNSg8z5y3UU3ij4wc/Y5SqD7FE8nDe5PdEaYOGFF+Iu SFen9DEtLxQS5aQiCaKXeMBWqmz4OqIOyHdhlgpGIQ98zOq+DioeoU4DCxCGXqF+/0sIVfBC HI/cysLjHOPFBNGtZNKXr8= IronPort-HdrOrdr: A9a23:nLSczKzyz711R9rpQUNSKrPxWOgkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scu9qBTnhOZICOgqTM6ftWzd1FdAQ7sSibcKrweBJ8SczJ8h6U 4fSdkYNDSYNzET46fHCWGDYqwdKbK8gcWVbInlvhRQpVYAUdAa0+41MHfuLmRGAC19QbYpHp uV4cRK4xKmZHQsd8y+QlUVQuTZoNXPtZT+JToLHQQu5gWihS6hrOeSKWnR4j4uFxd0hZsy+2 nMlAL0oo2lrvGA0xfZk0PD8phMn9Pl691bQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idirP D85zMbe+hj4XLYeW+45TPrxgnbyT4rr1vv00WRj3fPqdHwAGtSMbs2uatpNj/ir2YwttB116 xGm0qfqppsFBvF2ADw/cLBWR1Gnle95VAijekQpXpCVpZ2Us4nkaUvuGduVLsQFiPz744qVM FoEcHn/f5TNWiXanjI11Mfs+CEbzAWJFOrU0ICssua33x9h3Zi1XYVw8QZgzMp6I89Y4Ms3Z WJDo1Y0JV1CuMGZ6N0A+kMBeGtDHbWfB7KOGWOZXz6CaA8PW7XoZKf2sR52AiTQu1H8HIOou WBbLsB3lRCO34GSPf+lqGjyyq9D1lUBl/Wu4JjD5sQgMyNeFOkC1zAdLkUqbrfnxwuOLymZx +NAuMoPxaaFxqJJW9o5XyNZ3AAEwhqbOQl/vAGZnmpnuXnbqXXi82zSoejGFOqK0duZl/C X-IronPort-AV: E=Sophos;i="5.96,187,1665460800"; d="scan'208";a="87966129" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UjIk0tmSeRXSatK5fMqgL47WaOimVIEXCSpdaQtjprQQgCqd8ODDHpsBwGAvwKeXor0UTfn5Bc+E521dCOqC31b9uYUYiUKI3A93JENSkXFLPtFq7rntnxPi/MrmQMWnp8KkbCw8UFrneLjTxQhTRS4KEhAoPLDa6+2jYSTY04jyy44uQzFacv76CVVX9MbLdYD8Zm2AWn3s3EQcZHejYtmL9ZOIEYuL+C1higAtN7zuE1Oi5ZFEr6V5xZv8JTox1MDtJR+aM7BC9Z9KbGqNU3hm8TPAvE7S/DVkUGA5sZwx6zZsanEMpqd1lBv0Dzp4XZRBxo3n69KPnen0gMd3ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mwYQDu3FJbnU9eijKndbLoQ5ZKpllZUTITw+E3o7oOw=; b=Xk1JdxCRvQMJyFy6dN1wo4j+vC7fB4a6fCPMLd0dUgohYMOZMkOFenO2s69xbHbZ8LkxrYJzwI+eHmJ16gIU6b3kgNBvGtNw2UpETrxUsnhRT+4o1GrHGmS9NUD+lPnnuT6AMinFGO7vs24wjhXqgEF+OlfNppxukvzR9F8huGGP9jku+yKF55Oh9lOJ9AKxBw/ASYNTVBMMaezjTt4+5UZ5UsJ+vWkcDncfdwR9o5Z9QKfV5BZoUSo+FC7BjTfGqjFXSu+mYCPPPvoJWJaJCeWHX287lWBkuhyqEcjfVkASqnksXAkZ/mVB2SaTDEwZ32yML79sPBIWudxJooadOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mwYQDu3FJbnU9eijKndbLoQ5ZKpllZUTITw+E3o7oOw=; b=ZHDJOZ8w7eSHr/8xUve/GUK6MS3XG6EasiPp26WrGmZY+qeEIHvkdkpYIBSDSyHpbTf1q5WT2AC9ihKZMqjMA1mhMbmqWNs80ZyG7cIrOjHKBfmlqF4bvbQMIG6N+w8aJDAh31xlhfMpj5zo4qaGROchI1Ulnd+kou5T0UVBZa4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: marmarek@invisiblethingslab.com, Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH 0/5] gfx: improvements when using multiboot2 and EFI + misc Date: Wed, 23 Nov 2022 16:45:19 +0100 Message-Id: <20221123154525.63068-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0021.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::12) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM4PR03MB6935:EE_ X-MS-Office365-Filtering-Correlation-Id: 974794d6-0392-450b-14cf-08dacd69c22f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5LXAH8FYz+4JDXt0jdMpePLQT41uXWUw7w9cn7wysRuBvhn6jH20b1vvmzGFYnHUM4k4lwx42e572kG6m4q9vVBjqdYs4IbYZAVoI2X5GpGYoFM0hZodepJys7saVD93h0LCeNVu5IlyW+9yF8iEpAYXcctrCC6k96WCfND3byBk9fwda0FS4QRwrWYY4eVa4RhlZRjsD8MlcRTRyEPhGZfAE2CCcMlcL1/Vc6rBk6aww+TB07BKyJ0WdsSl6au5EewZ3DH6US0hCJ/ha/Ul0iqc/C7Ml1lnB0SSxz2Xf3KyO/fTzTxmNt1A308hyKugi97MB8j7DUWHaani7BBRh9klNm1/5c1YQh4MXvfLwPlyA53td4z4xUioKaAaOMYIJNh2gd5tkVXjyDYRXy1eOqiCI+hg4eemjwiNenOMNRFhD81v4BffSHNkStF+C9wYUXpHTnU47dvRSSpYtLEcWzvJZe9XHYxbvJT6RZUHcbhRRQGwyD69f+J0exYJZkCdtRqkZsFK/d6evYYdmW5JQdTrXOcD/c89Dp380byBSVcZ35uFaPx2uawkvF6ijvvBrUKh3w8KH57UFOkjuMhaYt+ltIGQPx9jRljv+4YbRiWoOg35uLl0H4YVi3XYHwWDn9xihFNesWx5HWyVW8Q45A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(346002)(366004)(451199015)(36756003)(86362001)(41300700001)(66556008)(66946007)(316002)(66476007)(4326008)(8676002)(82960400001)(38100700002)(6486002)(83380400001)(54906003)(6916009)(478600001)(186003)(2906002)(5660300002)(8936002)(6506007)(2616005)(1076003)(26005)(6512007)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUJUM0dlUEN0a2pVNGc5R3NYbys5SVhzd292L29CYkhrSEFjNzNJTGk5dytZ?= =?utf-8?B?dGxHVnozMWNDaGVZT1JScmhFRUFyM1QyZEs3Rmh0Mkh1ajJTZFRCM2YwWjF5?= =?utf-8?B?eTNScnhQTkRsejJGbTh2QnViNTM0bWQ0TW1XdFFIRk0zQzlwRk5WbGpYYUtH?= =?utf-8?B?VWU0WmhQejlJM3RzbjVsdG1OOVVOVmpTc1JpWGowN0lRenhOMXJoeFlrQXFj?= =?utf-8?B?S0N5dnNFa2VITVgveUZqejZTYWdoWlRVeGkxU3FEMWRhcFhQdnkrYWl0ZG90?= =?utf-8?B?UHJNYVdZNVcxdmk1ZHdqYlNJZElHcC8vWlpoczlpS0x2TUtnQzdDaXB3c0li?= =?utf-8?B?OGlDczZWdXNLdlk4Zk1iYVZPN0p0WHlMYlBXU2Z3UXV2dzk3RmlHR1o2NXpS?= =?utf-8?B?OXlqQUNBb1I5MVhpSWthYjBuaFpKcEVhQmo5Tk5OL1g1R2MrOHdDUXJWRTMv?= =?utf-8?B?RjdjaUpUNTJuUUZMWnZSQ2FVempUcGpTaDZ4TXZaV1NYZGpzc3cvN3hSTlp6?= =?utf-8?B?cVBEMVh2aEVRbnhITk5rczgxZlJ5MlljcFNYVlhobHE1czY2YVNMYjlRT0Ew?= =?utf-8?B?WWhhaTg1eDFZbk5sUUlQeUpIRGczeDBJcVo3NFpjY00zTDZJSWMwenR5bVdS?= =?utf-8?B?WDREZ3I1YkFCTXhOOGNnODc5TzNiQnNNakNkSlpOMTZJR0d3VzN5WmZob2hQ?= =?utf-8?B?Rm00eVp4djhJbDh3ck5KVU5remtHMkJQQmVpUk8zQzE1bmViL2kzTyt4ZmtR?= =?utf-8?B?T0s4eXVNZjJnK0ZQVGN4RDhOTE9mdXBhamxhaThSNFpsamcxQUlIWVJRSVR3?= =?utf-8?B?ckUzcUxjK2R2ajE2eWd6Unl4YzBtOWFIVlBEWDUxbzhsV2VIdHBycG4vdjhl?= =?utf-8?B?aGxZMVFMUEdqcEJvL2NDTlBtMStKRWJORGkxWmpxTTlRNzNVNmNzeWxIVzg2?= =?utf-8?B?bnd2eC92aDVTU1RpaFNFUE5OY1N2RVIvK0RweHF3TlN0UTg1ZGJ6SFZNZG00?= =?utf-8?B?RUdlOU9FcE1QeHVIejZFQXpYeC8ydEpDNjhsbGlXTVc0M3cyclY2eENKeHl3?= =?utf-8?B?N0xMRktKVGNxdDdkeWNKbXRpdFV2dVdmaGZ3KzJCck9uUG1ZZkRGMTRrQ1Ax?= =?utf-8?B?OThwQXlCajV2VXcrdWFacWFJREI2WmV6NEJxYkNHNjJSWWhIeVRjUW5HRlR4?= =?utf-8?B?eVRXYlBQRld0Qys5ckNwbzJ4d1BGSHE2T2pKZkxDeCs0bUZSSzVRWml3aVFL?= =?utf-8?B?bTVHZWMwZXhmTExRTmc2Y0NzMHIvR3M0aHd3MUJUTm8vQmlsNFF0OHdlbi84?= =?utf-8?B?R3NNb1FUS2Z1eFJadVpyTzlKcFI0M3MvVDV5ZWZkOUd5VkY5MDNYVldzTC9q?= =?utf-8?B?Sno0YTlpbjFnV1EyN0dIWkdncm5FWnhRblZsZHBBSFlhUW5UQ2pJNWErSmZp?= =?utf-8?B?SmhqR3k4S3YrS0RwbkJnUDBBcFg3Q0pPbGJJVU9FUUJjQU5TclRQZzUxNjVm?= =?utf-8?B?R2J5K1FNc3lsNlIxMEd1ampWNDBaQUFvRzdKMktNR0N4NUI2eWFnVyt6dHNz?= =?utf-8?B?TnZqa0VUY2o0UG5BdDhYL3BsdFlYdllNclBnVlBSUkQ3L0NtOFFBaUpaTE5p?= =?utf-8?B?TGN1dVFWQ01YMndWaTFNUlM3bEZKWmpUaC8xcXFlUVpxS1ZwRlZocTk2N00w?= =?utf-8?B?OU02enBvL1hiYkZRUHNDemg2Z3hibmZldll1SGx6L252WWtrdSsrdVp1VTc2?= =?utf-8?B?M0tacTE0bzVERmtoZHQrZWlITmFPTGQwMnY5a2ZCd05KOFJEU3pkamZ4WEVC?= =?utf-8?B?aWp0RWZsTmtMK2lSaVI4TjI5bjlBcTFBaEYrYzRXTk5LWlB5NXBFdUI0T3hJ?= =?utf-8?B?YjhkQ0l0b1hucnkwNVgyeW5LTzUzQlE3WUh1ZEtBekhNbjh4NkduYi8zc0sw?= =?utf-8?B?a0NrZlJwS3dEUGRBS1Y5OWFpa2xPL25hNldYaDB0c2hRK1ovWElMMFNHTHhY?= =?utf-8?B?bFhCRW8xOWNvdU5hMERLV3Z3U1FxdXgvZGFGTDc1Q3dmTE15cERkKzVKWno5?= =?utf-8?B?QjB0aGZ1VWh4MEVaTXVDTGJYS0VjN2dWL1NuTlJZKzJCNXFaUnM1dlJ3S3Vz?= =?utf-8?Q?ztYxe39O95izvKTC+OU+WCMUU?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?cGlNRFZoTEhULzE0VnNJa0Vma1NTRVdFeFRNbUx5WXAwU1R0Rnp5TmJidXpE?= =?utf-8?B?V1drdTFNNGhFWFBQcXlPdk02S21wMGRNSjJ5NWE0Wm5uZkF5T1JLVm9reVFK?= =?utf-8?B?S1FGUUYwUkJMYTI0TXJlTmJ4V0xvTVJpMVNONVc1RVQ4OFVzNlVVUUgzV0p4?= =?utf-8?B?TDJ3bFFRZHp2UUJ1aU5sTWVlQmF3ckFaREtkV1M2N1U1aGo2L0xXQjJVaytN?= =?utf-8?B?dHkyendFbmdNRklWWkEzNG9IaHNaSnJjdlFGUWJGTDNTenlvTHpuMitUNGds?= =?utf-8?B?bXYzZEJTT1pxdlQyeGJJU0laa3lzQmFXSitCajVKL3JJdU9BWEpkT0ZuVW12?= =?utf-8?B?NDI4dlNHWEVnbFZEeThXVDByVHhqaW1TSUxmM3luY1VFR3dyQUdIMEVidTVu?= =?utf-8?B?QjE2b2Zqa0o2S0ZLNkdBcnhsclhiVytVK2gwMXZKM1dLZmxVd2NiWEdRaFo0?= =?utf-8?B?L3dwK2lsUW9hRFBiN0tDR3FyUFpwZURpclBiRmNVRlVNM281ZnBaRkowbVJr?= =?utf-8?B?b0tmRFF2OVhURDNFRGVVVElkaXJNVVdpbzA0N00rd2JBTnJVajRzbi9QcHZH?= =?utf-8?B?QXFBMWdrMGl6WHc4TERUWjhZTTFMUzhkVDRueUNGNk5YS1RIRXJhaitoRkMy?= =?utf-8?B?OHdkRVBJdDNTbXp5RWV6ZlJScE5rM2xJaDhpYnVoVjYyZzNtdnB2RDNyc1lq?= =?utf-8?B?R0NQTFpRalFxUWtxaUpwRFZyVlhHeFlMdVJTWTh3aFFrbGRjbWlEVmtBcW50?= =?utf-8?B?QXZObEZoMUMvMmM0ZFFuV3pGcXJ1Q0MrK3cxNWZQeTdzZXV3YkE2NFdMYVhE?= =?utf-8?B?NVpISmZDeU9nVlF5N1A3eldOSGQybURDZjZuN0NaUUJnTXR1N3RtOC9yU1A4?= =?utf-8?B?aFNZVHNJMHhsaWlVOGhkbmRVcHI5bkRMN3gxYUdUdEt3UEh5VEl2ajJOK3Rx?= =?utf-8?B?ckZVaG5OMFJFOWxGUVNpQVBoNWJzWFdLRk1SdWpidWlmV2J0blpsZ0xhN1Nx?= =?utf-8?B?RlhXaitRbEZnMURneUFoMUFYeHNsTkVDZ3dtdkpaNFJjTC9ERmtTTEZ3dWpB?= =?utf-8?B?bFFnd2xUZGxFM3FoUS9CUWR3d2haalA5U0k2T2dEc1dwQ1VQWlF4L2ZZUCsx?= =?utf-8?B?ZW92ZGJqc2tzY29pVDdpaGJpMFpMZlVIK3NsM1JTL1g4WXF0UDR6V2ZETHYy?= =?utf-8?B?SVNWaW5keit2RnpGKzZPODZOcUNRNzR6LzBCaERhVHlDbEJLRUdyQ3M3VSsr?= =?utf-8?Q?pm1ZdQPOte+muba?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 974794d6-0392-450b-14cf-08dacd69c22f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 15:45:34.1815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u7Rt4itGBaUgRBirvfOliaE78Fls1v4jwUdbRu6eS7IzLH/ztLFXIbQdZ0C14I6ecdvjlSg28E17+Bj9F7064A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6935 Hello, The following series contains some fixes and improvements related to graphics usage when booting Xen. First patch introduces a new platform hypercall to pass the graphics console information and mode to a PVH dom0, which doesn't have this information available as part of the start_info contents. Further patches fix some shortcomings when using multiboot2, mostly the ignoring of the console=vga (or lack of) and the vga=gfx- parameters. It also switches default Xen behaviour from trying to reuse the currently set GOP mode instead of attempting to set the maximum supported resolution. Marek: after this series using console= without the vga option should result in Xen not attempting to touch the selected GOP mode and the screen not getting cleared. Thanks, Roger. Roger Pau Monne (5): x86/platform: introduce hypercall to get initial video console settings efi: only set a console mode if the current one is invalid efi: try to use the currently set GOP mode multiboot2: parse console= option when setting GOP mode multiboot2: parse vga= option when setting GOP mode xen/arch/x86/boot/head.S | 15 ++++++++-- xen/arch/x86/efi/efi-boot.h | 48 +++++++++++++++++++++++++++++-- xen/arch/x86/platform_hypercall.c | 11 +++++++ xen/arch/x86/x86_64/asm-offsets.c | 1 + xen/common/efi/boot.c | 25 ++++++++++++++++ xen/drivers/video/vga.c | 2 +- xen/include/public/platform.h | 6 ++++ 7 files changed, 103 insertions(+), 5 deletions(-) -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 15:45:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 15:45:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447635.704107 (Exim 4.92) (envelope-from ) id 1oxrwk-0000uJ-GY; Wed, 23 Nov 2022 15:45:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447635.704107; Wed, 23 Nov 2022 15:45:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrwk-0000uA-De; Wed, 23 Nov 2022 15:45:58 +0000 Received: by outflank-mailman (input) for mailman id 447635; Wed, 23 Nov 2022 15:45:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrwi-0008Tb-Lx for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 15:45:56 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e9ed70bc-6b45-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 16:45:55 +0100 (CET) Received: from mail-mw2nam04lp2171.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Nov 2022 10:45:51 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM4PR03MB6935.namprd03.prod.outlook.com (2603:10b6:8:47::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 15:45:49 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 15:45:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9ed70bc-6b45-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669218355; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=rqDCpw9PYZ99mLkHO7aHSTRqrOOU9gk4oyTNsde8Epo=; b=ZNeNv0R9T/kpR86d9SLdYq0zjYYwiMfr8/OmLYS3v1hOJbf+/26oa+rJ B0UOkX7p9ML0xOGIY1JsMXuXIyFWjOCpPJxhx1Wn84VnsHqAr5+drOiWE HaLB7oftY/qYO/BLmpXFad+kau2jtDDJ7raGVL+6EWNo9dMfLvzxXT9l8 Y=; X-IronPort-RemoteIP: 104.47.73.171 X-IronPort-MID: 84481923 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:9CFyeKBLddc5aBVW/xviw5YqxClBgxIJ4kV8jS/XYbTApDsqhWQDx mcXXGrUP63fajHwfNh1ady+/EkAsZ6BmoNiQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpC5QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwxM9nITlp1 6MjdiEsURCRpt69wL74Vbw57igjBJGD0II3nFhFlW2cKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK/uxuvDG7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLVri78376VxksXXqoLDoKx+dsyj2ae4WEOJjQdVwK7nfC23xvWt9V3b hZ8FjAVhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xA2EeSzdbZd8OtckoRCcr3 FuEg9PoAzN0tLSfD3ma89+8rzm/JCwUJm8qfjIfQE0O5NyLnW0ophfGT9ImFbHviNTwQW302 2rT83F4gKgPh8kW0an95UrAnz+nupnOSEgy+xnTWWWmqAh+YeZJerCV1LQS1t4YRK7xc7VLl CFsdxS2hAzWMaywqQ== IronPort-HdrOrdr: A9a23:U3lO9K0B++xxdi2iVKDViQqjBdJxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjjfZq6z+8O3WBxB8bYYOCCggeVxe5ZnO/fKlHbexEWs9QtrJ uIEJIOd+EYc2IK6voSiTPQe7hA/DDEytHRuQ639QYQcegAUdAE0+4WMHf5LqUgLzM2eKbRWa DskPZvln6FQzA6f867Dn4KU6zqoMDKrovvZVorFgMq8w6HiBKv8frfHwKD1hkTfjtTyfN6mF K12TDR1+GGibWW2xXc32jc49B/n8bg8MJKAIihm9UYMTLljyevfcBEV6eZtD44jemz4BIBkc XKoT0nI8NvgkmhNV2dkF/I4U3NwTwu43jtxRuxhmbim9XwQHYfB9BajYxUXxPF4w541esMmJ 5j7ia8jd56HBnAlCPy65zhUAxrrFO9pT4HnfQIh3JSfIMCYPt6rJAZ/mlSDJAcdRiKobwPIa 1LNoXx9fxWeVSVYzTwuXRu+sWlWjAJEhKPUiE5y7mo+gkTuEo841oTxcQZkHtF3ok6UYN46+ PNNbktvK1ST+cNBJgNStspcI+SMCjgUBjMOGWdLRDMD6ccIU/ArJbx/fEc+PyqQpoV15E/8a 6xH2+wjVRCO34GNPf+n6Giqnv2MSeAtHXWu41jDqFCy/zBrOGBC1zHdLgs+/HQ0cn3TPerH8 pbA6gmc8MLHVGeZ7qh4DeOKqW6UUNuNvH9muxLL25m8fi7XbHCh6j8TMv5AobLPHINZl7fa0 FzLwQbYv8wo3yWZg== X-IronPort-AV: E=Sophos;i="5.96,187,1665460800"; d="scan'208";a="84481923" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X0/xB+/uEDWZFZmVvl0mwnarpo3o/1LX15ESmMhGMFPchr2FGOW7c12Qj6DADANkt6pjAD+34GOy5LNeKuUuLqyKW3tzjvnamJKWxGqAf3hc7R2ArMCOYlRf55H7Aki+wexvTsSy5eApMQSvg4WiMfQiqcJHnki0OdzIDFj/9Yz7LSrs8FVuo3arun6O5kHsINmz+OOHXBMeEW42GdRawBe1yKNt4dSps0FfYVpxJY9rYNjAV5AGAH2l2OhBXcwKqynO/j/cg53323+9VlNBmZ3Z4fOkC3l/Lxy6VQvk3aJ7xnoW/RhfdxLEKWAXRJ+/AQdrxBTmtTyX0Qca+c3/LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I67lgI11eTbs3SxHKjPkzA3VPvUoeQg5Ok/IMGaO6DU=; b=jY+2C0hXbmg4mlAiJpM9IpIXnTPOzFu218yQ3FRtvHFAF+C6mL/GRjTey3N6Xr6GNqKs/KcbfiqCrXbhhTzp7JviIGGCrL0yXduHPF31KaLe/BdEOXj9WbEgG7yALLP2N8A8ivlewGoeqmW31dpxslHcWnnk6K1kGhuBIrvF3WJsslotGKliBLCxB8QmMevkFn/ujmNJHftmmqKxo4S6pJoCFlnAyz9kAdgfC1ZDVMMt6UwKLl0BMUvkr8LvtP9HUp8afEiHHmsoC+T0FttWgKMYLFROwfGcCEpouLaPdO2cvaCVELBh5nU+s4ER4fe4x4H+MAVmzSA0PUfZJ35l7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I67lgI11eTbs3SxHKjPkzA3VPvUoeQg5Ok/IMGaO6DU=; b=OWlXlKEmNaZzKHd5UpiaC4nxvLLNrhcpZUTgF6kMU8pRXDiV30KuIoOQFV8kXYZAJz6FP6zO7IQ/VUZti1mw1s+jMDmqK79Dt3+hdHFC9PbBP4mvMebwlLG7xzubGon7nQUR1Br8yNwCHGjseTzcAr3kHcpqqUY819ss/Zi7wdU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: marmarek@invisiblethingslab.com, Roger Pau Monne , Jan Beulich Subject: [PATCH 3/5] efi: try to use the currently set GOP mode Date: Wed, 23 Nov 2022 16:45:22 +0100 Message-Id: <20221123154525.63068-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221123154525.63068-1-roger.pau@citrix.com> References: <20221123154525.63068-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0089.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::29) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM4PR03MB6935:EE_ X-MS-Office365-Filtering-Correlation-Id: 64e3f350-ee96-4275-53c7-08dacd69cb36 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wKA6FqDO0O3m02ihKx/TH6DMrrisytEv4oqdRV+M4hjwrvjqJ7KkDXOHdipKFrHa+vpzSGbTMJ9J2S3VPp3gguauu8fvyQmhg2TosuPNU3xwd1/0L9RPpRMCtsx6YqwEKijdDBwxLtyK11M20vnlJXDcyzXmSlRcffSMb8W/4uXfR66RVq+kgrazSwZz7UPuXTibKwJEFtZviHzJ8l/X8fcJmCEps9GEDCFKvuGkTHDC6HVyhU+gNG72IKEf+qZY5TYjDYfCuFjTQ+b5jvqdDaPAXB8qNg5Yp1tJpDQDBo7lxurKjzunlo0kqIxE0X6J0Fa5Nctxp9kw1eeRDRw1eQTSk/fhLG1Rw3I04xoz15mJVZyyKu/BuXKCeZ44lgbcDX0PoHTqIqf/vi1/C0X1vOCKl39+yBc0NLwbARBMkKpqksraLoatFN8sJKOqjU9EeZgDNul9Z/O5mniwgrmxxtRo3m1qD+L/Mu4EH4Pyij14Z5fyFEEXzeCsF5jcd0PyAym+O5D3S9aThQ7yRJqCcLeunhK2rUchrX4Q4HuoCps98jQVFtzxPacoC8q3z7qK0Py9x2K0pITMGYXU/F7vgPiqtRvACWobahEcwPHabcmERYxPoP+aM1CfCYygYVxCHhTwGHVbysuYaBirGGbcvw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(346002)(366004)(451199015)(36756003)(86362001)(41300700001)(66556008)(66946007)(316002)(66476007)(4326008)(8676002)(82960400001)(38100700002)(6486002)(83380400001)(54906003)(6916009)(478600001)(186003)(2906002)(5660300002)(8936002)(6506007)(2616005)(1076003)(26005)(6512007)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWJWbHMwNGl0ZUVKMXdCcDFEYVdpYkZWZStINkt5bTlvVVErdzZPWlIrZzhK?= =?utf-8?B?eFpmUjMzend0dHVVRCtnN0lEY0M0aDRSOGFEcUs5OGhQTkZXaC84enowZEow?= =?utf-8?B?YTExU25WMEpWcDIzd0F0MEs0MkJBREFlMndNUnl6VHpVeDcrSnFuTXZtcE9s?= =?utf-8?B?N2doNXJhWlpiMnFKM2s0cnNUL2lUWS9XQjZRNWhzUVBucUxqRUhEUGFJNkd4?= =?utf-8?B?UVJIZ1laYm1YbGhTai9ESmZRMlEwQ3N5bjJtT0NMVVRta2xFVFhVSithdytv?= =?utf-8?B?VG5DN1hNOGRNUFF1NXJVdnRabW5nVk1CRE9vNmxiVkQxMWVHNGJxQ1VrQnVX?= =?utf-8?B?eGYvWm5RWGloYXhHa1BiNEhzM1o4SHVCa01qaVkxK0V6REJUN1NaSVFSbnpE?= =?utf-8?B?emRGS1RvQ29DcmtMR3BrVzVhQUxLSUlKSEJmN3ZmWkgvNGM1N3pZU0V0aWJN?= =?utf-8?B?SGpUUlh6dk9ic0J4ckdEQ1NkajVBanlkcktnZnRpTGRlSW9OcE15c3k2Mm5Z?= =?utf-8?B?QjV1QU9TUGRiaFM4Q2x3a0lUM2M5T0xDeGJ0Z3lEOFVwVUZKNGVNUGZKeGxV?= =?utf-8?B?TWwzc3ROajFMTmVpd0VHdmRWTVQ2NXFlWEFpeHZ6Z2FBRkVnWDU3OFNaNjBT?= =?utf-8?B?aFlZWVY2d3RjSFI2dlJHbzNjOU1UTjhwQUtaaElNRUpOaEtWQXNwY1B3WkFM?= =?utf-8?B?OGxoUlI1YkJkR3lxeHl5aXVPQkFQZzNqWnNsZWNTSTh6TkczOUErbGdqNHpu?= =?utf-8?B?UlcwT2RzYjIyVVFETWZvVEJVOEpPSFZISEJnVTZ5b1hieEZib2FpK2k5OGpu?= =?utf-8?B?Wnd1RkFwdkd3YVNrSnBDTWZLQ2d0NlFDdlc3ZHhLVUtMODVQanA4Z0MwNm5p?= =?utf-8?B?eFVqY292SW9URUFvaDJtRjlHWHkvTTNMWUZ5SXBqME1JMU9hcEdYUEswTWox?= =?utf-8?B?UllTZ1JvRXI1aXNEK2NDbUYxT1JCOVdFTWNCQmJpZEpROXNZQURYTXBhaS9D?= =?utf-8?B?MzRqSEw1YmV1M0ltc21qNUo1eDY2clNBWU5vaFFHejZuK2crZjBuaG5Xakxa?= =?utf-8?B?RmlZQU9VUXRXcURSUWdCek4wa3dSNzhUNHJiMm1xQVpDem1ycWJLQnhnUzlU?= =?utf-8?B?cWMvZGJUVk4wdjBjUWJUWG1LeXM0YnRRMnZoZEFOQk12YXptTk0rM1p3WjZR?= =?utf-8?B?VXRia1ZRbUF0bFNkVXFuNTc3c0NHa0dDT2J6QXhPN0JaSnZIQy9KTUcxNXF1?= =?utf-8?B?dVFHYThBT293bzdGaFBTcDdQVTE4NWNVTGRMdUFsTVoxdDFHNU9OQmRGdFBQ?= =?utf-8?B?U0Fpdi82U3p5R1FvMk0xTmtBbFJNUnFEV3ZGZmhIQUJ6RmwxNk04a3RSNkd2?= =?utf-8?B?dEdWN0dpSm1NYTBuMG5vTFRuck9zNVErcEliMXJLRk9CNTV5ZmtmUy9VQXhI?= =?utf-8?B?dnNEMEpGQlpTTnNuazNMdVVpVUk4SW5pNy9GeDZuQ2JZem52bnA5STA1T0tj?= =?utf-8?B?WEtlMjl2eU85ajNZSE5QajB1Z0pCdUJSWkRnMW10aXplL3puTzNTUk9vdzZn?= =?utf-8?B?MS9UcjM1VWp2NnhnNnlSVXhzTm5IVmZVL090ZnlnWjFBM0xYVHhzUksyYkVW?= =?utf-8?B?YXpCbGU3b3dWMEZ6Ynl3ZG5pOERrRTRzUzZFU1dMam56QUw4N2hsbE83bkFs?= =?utf-8?B?ajEvb09pQzlJYUtMdWF0NEJUQllsTzIzdExXa1lvM2F0WFlFdFowZ0pYVDk1?= =?utf-8?B?V20rOEwyL2Q4eW4wM3h1L25UVzVYZkVxUS85VFZPZ216dHEydFdveTFhWE1y?= =?utf-8?B?VjRFWnVjNzVyaFE2RUZMVGNvN1NqdmRUNnhpSmVVTVdQNTRUbjMzcWZFTUlC?= =?utf-8?B?VEU5RVVCVy84dzk5U1ZnRzJjVVdOWm5UOGw4RzVYeE45YmMzRThWaWwvcm10?= =?utf-8?B?MzQ3L2VtSFNETDA3d203cldkVVl2UitBUW1QazErZ2ErV2ozeDBVZW85VHNn?= =?utf-8?B?OUQ4NXJ4Q0l1TG0vWkxhbGl1N1RhZ09WS3hwdUJqWWErTGpZcDl2NHNyQXZv?= =?utf-8?B?RFp0TExUQlduYUhNTEdhZ0lMRU8yR1Vqc3hnTEJVQll6MUgwajA3WUh2Qm92?= =?utf-8?Q?qDJcLXqmILfITqbHssDvzhBP9?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 7GksLdGfk58sBZE6LAz7wMUOGiKsFnqhkcOfSDtL4spcNlQ5MB7Pv0SRhieBGlYRYj9kdq8nnMXlrqtdHvxvOIP9TgdUXyK+tJ/q6RfQ9g+dvVB9dKYGGDvudaF7yF4xO8kwPtvA4wLzfmUK6FceXWGVFgImTI51tS3MmmMfv/lX0Bc10J9MvyaQiq+42YGB4tlceo5pYM8tSDWMZavd65yNO4iPx/eRDYWAPqehdo6Fn0LYC2qB+FSwKOhP1XbxtjGvpaCez2epgY/ico2l9SQ+XPnA+4U7agyb+5YJeNRom1qq3lDFoM70WLTIppE1OjaQ1nvzyMPGeXUNzH9qJZMB3gT5awfKOSyHXOI3Nr6tfdjM1egrgz7gqyVd6BtPRNT58UKWmGezkURVFZdRwwBHs09gCwLVj4/waAMCqnMRAt/ScIEVE1ReXVoQ/US8jgl2xOfkJQbYLu6O4P0YdFKevGuEpBpDBh6zUDP9Sk6zYB5ri5oHR9Kp2hE2JRZtF2FwmgFVRwIl/Uych5xgZxJcKl0zBL6GXDJAfjrkIMZMaOMCCrb1ktSivApYt4qExTXD8BIRu3stL8l84wVXG9/g9RFdbOnuIy46gl5Ep2jvZkpDsCtvzLMwUfhMvAIh2RSUWjcbE74QWj58KxlGDMT9CWF4uUlS5jKA6pH9VwYiuMH+3aOtKnar4X8mwAgWaq56QroVIpXuojTAJFqDaoXBm0WuYJwKF3XSH+d3soEC6iAJFoduothZd6Ay6ifeIiOcCXUNhLeDpbG5F0SK0K8gCQBLAyVlbRO4V79vInBWatW7F0XITU/p3i/CiUvQAKaazVvPvCIIrfWaoqE8bzPlzuuYHOv/4WYqiiZaF6g= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64e3f350-ee96-4275-53c7-08dacd69cb36 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 15:45:49.3767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: egmCyMRRPyGKtezAP6wHPlO5nQWEluohaAGje5nYe050li5BJURyP070BVR0eMpA2/crBjCH0dX8FfWC9cmXxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6935 Modify efi_find_gop_mode() so that passing cols or rows as 0 is interpreted as a request to attempt to keep the currently set mode, and do so if the mode query for information is successful and the depth is supported. Signed-off-by: Roger Pau Monné --- xen/common/efi/boot.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 7e8a8b7857..b91a7179a9 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -864,6 +864,26 @@ static UINTN __init efi_find_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop_mode = ~0, info_size, size; unsigned int i; + if ( (!cols || !rows) && gop->Mode->Mode < gop->Mode->MaxMode ) + { + /* If no (valid) resolution suggested, try to use the current mode. */ + status = gop->QueryMode(gop, gop->Mode->Mode, &info_size, &mode_info); + if ( EFI_ERROR(status) ) + PrintErr(L"Invalid current graphics mode\r\n"); + else if ( mode_info->PixelFormat < PixelBltOnly ) + return gop->Mode->Mode; + else + { + /* + * Try to find a mode with the same resolution and a valid pixel + * format. + */ + cols = mode_info->HorizontalResolution; + rows = mode_info->VerticalResolution; + depth = 0; + } + } + for ( i = size = 0; i < gop->Mode->MaxMode; ++i ) { unsigned int bpp = 0; -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 15:46:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 15:46:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447636.704119 (Exim 4.92) (envelope-from ) id 1oxrwo-0001F9-R3; Wed, 23 Nov 2022 15:46:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447636.704119; Wed, 23 Nov 2022 15:46:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrwo-0001Ew-N9; Wed, 23 Nov 2022 15:46:02 +0000 Received: by outflank-mailman (input) for mailman id 447636; Wed, 23 Nov 2022 15:46:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrwn-0008Tb-7d for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 15:46:01 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec1a544e-6b45-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 16:45:59 +0100 (CET) Received: from mail-mw2nam04lp2168.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Nov 2022 10:45:56 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM4PR03MB6935.namprd03.prod.outlook.com (2603:10b6:8:47::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 15:45:54 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 15:45:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec1a544e-6b45-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669218359; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=UrpvtpZaeWpkhTDTGxJ8y1lv9LpWbxzT4fLSQ71R7qo=; b=dfpAgKsqAdVSrmoHu6XQFg1DfI1Uk9Gj33/LjIe0PFz1FLkJnkvL1PUN d4Onv2ZVRIq99vJNMuE6JDQuP//IWN+vHVywOG8zKOZOEJOMJJGgrPzBN BADnvsu1WZfl7RMfKCdQRDyNph+1scfyKip7yySCZMgBuzaXCRp2mJiX1 Q=; X-IronPort-RemoteIP: 104.47.73.168 X-IronPort-MID: 85444277 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jQqrQa46PrhZyfr1gISE9AxRtP7GchMFZxGqfqrLsTDasY5as4F+v mtND22FOK3fMDTwf4xxatmwoBtQuJLTm4NgSlBsqik0Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkR5weE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m8 9kdcGAcUSu619mI2Lu5VshvhMoSI5y+VG8fkikIITDxK98DGcyGZpqQoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Ml0oojuiF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efwH+nBNhNS9VU8NZIngC4yW4PNiQSemmGoOOfk3aFcMpAf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpbdU8scYsSD8C1 1mXnsjoDzhirL2UT32G8r6e6zi1PEA9L2UPeCsFRgst+MT4rcc4iRenZslnOL64iJvyAz6Y/ tyRhC03hrFWiNFR0ay+pQzDm2j1+MiPSRMp7ALKWG7j9hl+eIOue42v7x7c8OpEK4GaCFKGu RDohvSj0QzHNrnV/ATlfQnHNOjBCyqtWNEEvWNSIg== IronPort-HdrOrdr: A9a23:MqGD56CHgYC7yVblHejMsseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ++xoX5PwO080lKQFmrX5WI3PYOCIghrNEGgP1+vfKnjbalTDH41mpN hdmtZFebrN5DFB5K6VgTVQUexQuOVvmJrY+ds2pE0dKD2CBZsQjDuQXW2gYzBLrUR9dOwEPa vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOuIP6bQUADxsH7hDLqT+z8rb1HzWRwx9bClp0sP0f2F mAtza8yrSosvm9xBOZ/2jP765OkN+k5spfCNeKgs01LCyprgqzfoxuV5CLoThwiuCy71QBls XKvn4bTo9OwkKUWlvwjQrm2gHm3jprw3j+yWWAiX+mhcDiXjo1B+dImIocK3LimgIdleA59J gO83OStpJRAx+FtCPh5+LQXxUvskavu3ItncMaknQae4oDb716q5AZ4SpuYd49NRO/zLpiPP hlDcna6voTWVSGb0rBtm0q+9CoVmRbJGbyfmEy/uiulxRGlnFwyEUVgOYFmG0byZ47Q55Yo8 zZL6VBjth1P4ErRJM4IN1Ebdq8C2TLTx6JGnmVO07bGKYOPG+Ig4Lr4Y8y+PqhdPUzvdQPca z6IRNlXFMJCgHT4ZXk5uwIzvmNehTwYd3V8LAe23Aj0YeMAYYCMkW4OSITeoWb0rEi6/bgKo aO0aJtcoHexFTVaPd0NnXFKv9vwFklIbkoU4UAKiWzi/OODLHWncrmV9uWDIbRMF8fKxDC6z 04LXXOGPk= X-IronPort-AV: E=Sophos;i="5.96,187,1665460800"; d="scan'208";a="85444277" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L/KeZbFRiSnLUe9BC3VTc4e3xSQQZ7b+SScNopmXXn9wYsyvVNcyhNHMEOzHpKl+QpA9sVjbzTt42jYI5+t6iPPkGHbcjxZx7M1iPpGKanj10SElI2zGAyOSS0fWCKabbKL655BEYuj8RXWKiXVibHQe4vuUOEP14w2GcCvoLb7Tcoln94DGduT/Vq+wZLiyMp19C/MgaCf3X9VziAw1xX9vNSht9DCJdArRvHun6iELfYSr4hmTYKnuEEzjgZM8MIq90I8dE/BxPs13G1brWWh9BvtP/3fDWSMIXjQWBf36D3enCrgmiZm6UEKKPDG1DntRV8SKoTlfSz2wQBDfhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aga1YY/munjCHPbgajSJWWRT0kc52lET3HS0iDBN2nM=; b=BSCR+YFCYZJuoLaJPJB/nARdNDbWJQIedkq1UCRU1JkjlzAqdbNTt4Bmm1nsAWVsP+CpetyIAHN2yZwl7y0hsE8AkKiH2eeJbEDI3pKg/vFc0gjYpVK7pS6czK0EqlPU+fc/FWB/oueZ7SrYtoE2OvQJEVbGm/VjsBJdTEbNJNnJF9qaXcDUM6NyqrK9mYgb5oiQqWICs80AYkmI6SikqSLADiRJX3v19pVQSRZAaLjfWMFA4pRSr9euon992pdwITRkoDzLAIEUC7hFz1CEn/6ZeJ8gkTABuzeXW9l3XolVJNyJmfyW+zyAaF4dwsooF1Y0mCpV7DEha5Jt+yHBfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aga1YY/munjCHPbgajSJWWRT0kc52lET3HS0iDBN2nM=; b=Vz2pWkqEdIRaRUxNk7MknTJ9LFBteycWuRAkMN/qROtElL+9WyXm8z2Z+PcvY9mUkDHwAyqq4CwZtSHw/8PtpTRbfsrFV+A9fS3Y0XpuieBhn76EmZDIgUmzc7MAwvPbnYAmv/AWuzSuhUQRqenhGOPNyYe6cA4Nh5QQ3cVYYR8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: marmarek@invisiblethingslab.com, Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 4/5] multiboot2: parse console= option when setting GOP mode Date: Wed, 23 Nov 2022 16:45:23 +0100 Message-Id: <20221123154525.63068-5-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221123154525.63068-1-roger.pau@citrix.com> References: <20221123154525.63068-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0043.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::17) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM4PR03MB6935:EE_ X-MS-Office365-Filtering-Correlation-Id: 57a06453-8767-4139-bfb7-08dacd69ce55 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xFxqpbXkR9wGVTnTAAI7qL6lhGQX363BxkHt3GDRUDGiUD5e/x/A9DRVTu1ZHYHaFBOk3zTZkPLcYxwfuyksBsLrJznjeQUE3cD027LCnP6mp87FkHNcPvhRaDlWT4ct+izb8GTTqQjbyNfjpwa4VhiQFkjZZOUP3Ar/AbVterjaU0ciEmdDAZeEp3V+pAJOuMlhB1Bc7/rWMnszGDQw3XdBEryqriRt0dgOuvYMwkbkx4HFRd7a0suY136yxBniik+en7XGVXCN2WwV3v0gtIJ59bwunbbIdC1FgrD5vqsMeLFBtD6aUszZ8PqqVNLjBxlqBAQnhgKKdoZIGB2up967pQ3BVBGX4KAW/ZUTpTQgg+xPccbLLmMc030NY45BQkyMG1THm4LOJ6waOmWnmXXqP3QvweR0fbQK19c9D31qrhgMjeMD5e8HkBtzQoVxJkoOGF/yjkPsCdUaTRtP20VBWxHQ+JYxBRInLQnEtYLUIIl7SqAg9WRPQIy3BOGdkEX8Z25eWc8Xh98GAXXsxbpavNFhAOa8grAXz0GzrfejAYWi0EmdZ+sP5CdZlUe/jlo24ee5F+xTp97b67OkRnWB/dDBUlcseFhcbaPlws73VFMM14k+reorUnLljjRDB2kTKe+8In0kYVx6PbJ5Gw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(346002)(366004)(451199015)(36756003)(86362001)(41300700001)(66556008)(66946007)(316002)(66476007)(4326008)(8676002)(82960400001)(38100700002)(6486002)(83380400001)(54906003)(6916009)(478600001)(186003)(2906002)(5660300002)(8936002)(6506007)(2616005)(1076003)(26005)(6512007)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejlZaWcvc3EyZGxScm5oMVVyVnBTanBnY3VLdzFKVFl0Y3lRVnpEak1qYmta?= =?utf-8?B?VndxM3Y3dCtvQ2ZqalhESnBFTWZGTHExdE1yOGJJQnF3dHFCam9NK2tGOExH?= =?utf-8?B?TlBoZUlOMkk5d25FUHdycUdSNTFxanZjczMzQ0NIZm4yQVQxcVBlbWo1RzB0?= =?utf-8?B?M1I0a1VSOHlmUlNFa3pFZTdsQ2FPaTBsY05CWnZoWnMveGNvSmgySjhPbEVi?= =?utf-8?B?SVp0S21OZ0F4RWlNcFFLNUdUUFJ0RXRWZTBpZUNucHdQQUEvZXFzbUg2L3gv?= =?utf-8?B?Yktmc0UwTlJJeUEyWnpVVDN3eS9wV28rejNTSUhiUFhoVUdJaUdROEgyQXpS?= =?utf-8?B?R2h1OWtFZlc2STVyTXBTc1UxZld6U0RpazN6OGdPQnZCU3hrcmkrVXU2VWJM?= =?utf-8?B?NlVkZzBjSm52QUhieWdaK2pmSHE1bUNaeEdBY1FQUVYzRXIva0VDb01rWW94?= =?utf-8?B?bkZPUUpMeVJ1Kzl1Z0RtNTBLc2ZIN3EvdEQ5UHRjK3VmT0wvQmpsTXUwTHhL?= =?utf-8?B?b2xWRFFhV0FwQ2JwMENuaE1lWlUvN2lTWGx4bzVqVHpFWDFvOWRwSjZ1SG5J?= =?utf-8?B?ZndmZmpzOE1uMUtWTnVoQVM5TnQ2L1VmYXM2NnBYbjhkQnlEOXRndkVPQWs5?= =?utf-8?B?K0V4a0JENUt4NWlORWMrYkd0TnBPZE5YNUF6MUw4S2t2Kzd1Wnlnd2NUeWV3?= =?utf-8?B?WDBPMkQ0dzA2dVpXQVFpdjNYRlFRQjNlYkVDNGNFRGdWdnlsN3VFdFFRNGtu?= =?utf-8?B?dnlOT0dkLzRhQ1hJYThmQVUzM0gvS05oYXRmVGtBa01pZUxVbkxwWTZFT082?= =?utf-8?B?Y1lxaTZ6UTZRK2pCMU43M1VtYTQ3U3Jva05mcjh6QkR6MHRPOHhweDRwNVp5?= =?utf-8?B?RmJDSjZ2ZnBWK1FGT0V5YXJhUDZkNE4zY3RSMmx6cEcvK1dNbnNDOWQwSUZZ?= =?utf-8?B?L3FKNERPT1ZnTnUrQ2txSkUyYk9udjhmZWFaMk5rREl6dTRGcmxTSmJGUjZT?= =?utf-8?B?cDJYbmZGVEp4WW9pNmozOTlpM3pZMFhER2ZvVVJoUEFpcjlYUjdkR2FVNzZa?= =?utf-8?B?Mkp4cE5rUUNtdnVXeFVINUNWem9pZ1B3V05wSTJNWE9uZkovbENldEppdVV2?= =?utf-8?B?OFJFZmN5V2JONUJFRjFqSDRGcy9IRnloVkFhU28zVDBIZFVJTUF2aHFvWjIr?= =?utf-8?B?R1lTOG9KN0U2N0ZxNEoxRVpKdXZ3VFc5bEZVMVVDSzRwOGlNUFFSWUc1ZE1Q?= =?utf-8?B?UnhlT014ZjV1djlSeUZRSDdqbVM5N3NYdkE3ZG5ld3VUZXBLZjBuOVc3RklE?= =?utf-8?B?QXhpT1hIK1JuNmZsY3NoL1RMTk5NNm82R1g0Ujd1QjJiSzlyT0FDMUw2bFlO?= =?utf-8?B?Uy85RisyUFNydzZNdExkVEdaTnhLOVBjNG9rSHI1N3RIbkJwdGtUZ1BlbjhV?= =?utf-8?B?b0E5ZkovdHhQWEV1Q091QU00RUJhMDRMcmxFWEhHMzY0dStWckNCQmt6Ny80?= =?utf-8?B?SXphQ0o3SGJ4NmNIc3ZjNFJjcTFyNHF3OUxCbU9UZ2VXQktLK1M5RkswcGlj?= =?utf-8?B?VzFOY2hZbDJ5cnNMN0dCZFB6cTRqRlR1Yk5zdGQwU1ZwY0FId1NzaGRCWUk3?= =?utf-8?B?ZEYwSzI1OW1CMzFoeGtmU3YyeERBaEV5Ui9yeXhYaVYybEVZek5WUkRnVmMy?= =?utf-8?B?aXk2SzVwb3Z4QVpmaWxOanE5cDVqWjk0ZFJHYXpBL2JpYmN6ckEwbDRUQ1or?= =?utf-8?B?M1FRTGhvbkltR1p0R3pUMlA0U3JWYzVvTXVkMG5NVVFvVjltUFkxSmdGMUdJ?= =?utf-8?B?eU5qd3YrT2ZTMlFKZjFCS3RjSGswZW01UitGdC8yTjYyb240T1lTMCtGYjVk?= =?utf-8?B?ZTNuRzliOER6MlF4dTBUWC9LTDlXcGNZYkc4bEpWc1FkWFh1TmpKUWVVMnZi?= =?utf-8?B?TnhvYzhwTGNtTnR6aFhVdGtuNEJZb1Y5T3Q2K3hrWm9mY21LSmpIZzYzY2Jw?= =?utf-8?B?V3BHNDdOTE0wL1VESzB6dThCOGR2UzJRY0dqdGNtcysxazR4ZzNVY0RJaUdw?= =?utf-8?B?cXg5R2RsdEtBYjg0Q2VqQ0dxbm9teEVyaEVHZUtGcGlYOU40alNPTW50NGJI?= =?utf-8?Q?qAB6L2JBewmi5a8fU7vaLVHUe?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: gb5MDNE+BbBNrfzJy6US4OeW10Cl6oxvbFkfOC12Ye8Rd7rsF3wqgeMrgDhDQqD3OxMHoiW6GhObBcjWGzeQ7krf83n8rmlPqdjzc1bdWkOUtrx9T19/INO7ZS2Ovv0JLeyitdm7OvNmWxu/IuR5uln9SISkEQWwK1AlRP8V2ohod4H5hDkP7zqqokm8/zuaQc9iZL1s59Up7vWiw+CCSqN2Y64MMwD8TIbGbI64HHIUY5vu/HU6nvxKQ4s2tBysqQqvxNyBvXOVsa/ZGvrfAA2yc18rvMvrfo8uQi/JkspH5ldnX05GwEkqGhlb8QvmOuYn2Bqm2b4IWSxU+IWTY7IyjOuWeP0ceFRLSozdBetY5AFHSUN1IFMFqdhBANT4/ybmxnzjXBNt0/NE+3gfaMxeIbxCUoLZUzAOb1BWD63RHsZH2gpaIkZm0sbSREwVC459D2BoNDWiJQbqqZ/W+OIakStHCWy4dXW2NtP/0rrqKx7zrGRzwa8TrVojYp+VsZM8BMMSmmFCXY9O1wF3bhJaBGKevqlT815NM3e+B32obuXJHmbInpzx8Z9/KwawwUIP2U05ca4X+mpBS3pkGDiGIRu8UjsnzwiF6DyNv1KpPVtIxhnFhH+Uzy9W/K+IOmdoAmRri3PqHEChPHn5r9pWz9BQ8D3qvEsUgvC+4TI55pVN/WgEXg6HGOkLyt3PVtPIE7ne03HshR/ayOP2d1Nxc8+V3+YwU/3XyZgsyqIy2dEH2vkuBqmQA4YACtfTMRB7ssVdUweXl+KTGaryj4WkW3OXFPNYhcJvfLUhGD7iNVR6igycD5310hHuaDfjRLkmKD45GVsQzn+J5/5YzbL8N7Qr0flLbSioFzMLr6NQuazt0uM/B7XU8Sz7rLe9 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57a06453-8767-4139-bfb7-08dacd69ce55 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 15:45:54.5988 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 451QL4Jm0CowGmfOUnJRFhJRT1H84J+IRBNyWDzWiHtBv78TewFAytn6w26r8ssT5khRwZT4G5VkcPGGSsZqCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6935 Only set the GOP mode if vga is selected in the console option, otherwise just fetch the information from the current mode in order to make it available to dom0. Introduce support for passing the command line to the efi_multiboot2() helper, and parse the console= option if present. Signed-off-by: Roger Pau Monné --- I'm unsure why the parsing of the multiboot2 tags is done in assembly, it could very well be done in efi_multiboot2() in C, but I don't want to switch that code now. --- xen/arch/x86/boot/head.S | 15 ++++++++++++-- xen/arch/x86/efi/efi-boot.h | 33 +++++++++++++++++++++++++++++-- xen/arch/x86/x86_64/asm-offsets.c | 1 + 3 files changed, 45 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index 0fb7dd3029..6920ad08d1 100644 --- a/xen/arch/x86/boot/head.S +++ b/xen/arch/x86/boot/head.S @@ -221,9 +221,10 @@ __efi64_mb2_start: jmp x86_32_switch .Lefi_multiboot2_proto: - /* Zero EFI SystemTable and EFI ImageHandle addresses. */ + /* Zero EFI SystemTable, EFI ImageHandle addresses and cmdline. */ xor %esi,%esi xor %edi,%edi + xor %edx,%edx /* Skip Multiboot2 information fixed part. */ lea (MB2_fixed_sizeof+MULTIBOOT2_TAG_ALIGN-1)(%rbx),%ecx @@ -265,6 +266,15 @@ __efi64_mb2_start: cmpl $MULTIBOOT2_TAG_TYPE_END,MB2_tag_type(%rcx) je .Lrun_bs + /* + * Get command line from Multiboot2 information. + * Must be last parsed tag. + */ + cmpl $MULTIBOOT2_TAG_TYPE_CMDLINE,MB2_tag_type(%rcx) + jne .Lefi_mb2_next_tag + mov %rcx,%rdx + add $(MB2_tag_string),%rdx + .Lefi_mb2_next_tag: /* Go to next Multiboot2 information tag. */ add MB2_tag_size(%rcx),%ecx @@ -324,7 +334,8 @@ __efi64_mb2_start: /* * efi_multiboot2() is called according to System V AMD64 ABI: - * - IN: %rdi - EFI ImageHandle, %rsi - EFI SystemTable. + * - IN: %rdi - EFI ImageHandle, %rsi - EFI SystemTable, + * %rdx - MB2 cmdline */ call efi_multiboot2 diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 27f928ed3c..695491a5b7 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -786,7 +786,22 @@ static bool __init efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemTable) static void __init efi_arch_flush_dcache_area(const void *vaddr, UINTN size) { } -void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) +/* Return the last occurrence of opt in cmd. */ +static const char __init *get_option(const char *cmd, const char *opt) +{ + const char *s = cmd, *o = NULL; + + while ( (s = strstr(s, opt)) != NULL ) + { + s += strlen(opt); + o = s; + } + + return o; +} + +void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable, + const char *cmdline) { EFI_GRAPHICS_OUTPUT_PROTOCOL *gop; EFI_HANDLE gop_handle; @@ -807,7 +822,21 @@ void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable if ( gop ) { - gop_mode = efi_find_gop_mode(gop, 0, 0, 0); + const char *opt = get_option(cmdline, "console="); + bool vga = false; + + if ( opt ) + { + const char *s = strstr(opt, "vga"); + + if ( s && s < strpbrk(opt, " \0")) + vga = true; + } + + if ( vga ) + { + gop_mode = efi_find_gop_mode(gop, 0, 0, 0); + } efi_arch_edid(gop_handle); } diff --git a/xen/arch/x86/x86_64/asm-offsets.c b/xen/arch/x86/x86_64/asm-offsets.c index 287dac101a..fbd6c54188 100644 --- a/xen/arch/x86/x86_64/asm-offsets.c +++ b/xen/arch/x86/x86_64/asm-offsets.c @@ -175,6 +175,7 @@ void __dummy__(void) OFFSET(MB2_mem_lower, multiboot2_tag_basic_meminfo_t, mem_lower); OFFSET(MB2_efi64_st, multiboot2_tag_efi64_t, pointer); OFFSET(MB2_efi64_ih, multiboot2_tag_efi64_ih_t, pointer); + OFFSET(MB2_tag_string, multiboot2_tag_string_t, string); BLANK(); OFFSET(DOMAIN_vm_assist, struct domain, vm_assist); -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 15:46:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 15:46:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447637.704130 (Exim 4.92) (envelope-from ) id 1oxrws-0001gI-Ai; Wed, 23 Nov 2022 15:46:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447637.704130; Wed, 23 Nov 2022 15:46:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrws-0001fw-6k; Wed, 23 Nov 2022 15:46:06 +0000 Received: by outflank-mailman (input) for mailman id 447637; Wed, 23 Nov 2022 15:46:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrwq-0008Tc-NP for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 15:46:04 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eebdf757-6b45-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 16:46:03 +0100 (CET) Received: from mail-mw2nam04lp2169.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 Nov 2022 10:46:01 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM4PR03MB6935.namprd03.prod.outlook.com (2603:10b6:8:47::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 15:45:59 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 15:45:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eebdf757-6b45-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669218363; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=3IEGhNz5bpGOjKYHnrL7h9RWohXg8ACWsyu0F4mMgf0=; b=IyhSSVruvP/cmQVjwwIZpmzg5A8dSEzUo+YrnrVCok9RYYXYsVkH17XE 2wsRDQ5h/HAUjMf+Y87AT0Gt1WtKGhYL1Zqv3kcrSBVPVLyvY823tRkXh 2/MyLiJIqluCnqz992vcJyC+Nt/M7JACIp35bpTZVVkXuEJDaxmU2e7No E=; X-IronPort-RemoteIP: 104.47.73.169 X-IronPort-MID: 85425922 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:JdHIzq80Ok4JnDvsyf2uDrUDRn+TJUtcMsCJ2f8bNWPcYEJGY0x3x jQbWDuPOayDM2SheoolOtu390gFv5CBnIdqQAI6/308E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKoQ5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkly8 8w3ExUGcCqpvO2V7qLqc8dcvsUKeZyD0IM34hmMzBn/JNN+HdXmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTeIilUvgdABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prr+SwXmmCdhIfFG+3uRFnACW5Gs9MjoHalKArb7mu2y4UPsKf iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZEYcYjvdU7RhQr0 EGIhNLjATFzsLyTRmmZ/73SpjS3UQAXJ2IfYS4PTSMe/sLu5oo0i3rnUdJLAKOzyNrvFlnNL yuiqSE/g/AWkpQN3qDjoVTf2Wvy997OUxI/4RjRUiS99ARlaYW5Zouur1/G8fJHK4XfRV6E1 JQZp/WjACk1JcnlvESwrC8lRdlFO97t3OXgvGNS IronPort-HdrOrdr: A9a23:24ZmTaon2uJ4EcdT7KsYgqgaV5tLLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwI080kqQFm7X5XI3SJzUO3VHFEGgM1/qH/9SNIU3DH6tmpN 5dmstFeaLN5CZB/KHHCWCDer5PoeVvsprY/ds2p00dMT2CAJsQijuRZDzrcXGfE2J9dOcE/d enl7x6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDKw875BKIhTaI7qe/NxSDxB8RXx5G3L9nqA H+4kbEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJptkJJi7qggOIYp0kf7GZpjg6rMym9V5vut jRpBULOdh19hrqDyqIiCqo/zOl/Ccl6nfkx1PdqXz/ofbhTDZ/L8Zan4pWfjbQ9kJl5bhHoe p29lPck6ASIQLLnSz76dSNfxZ2lnCsqX5nteIIlXRQXaYXdbcUh40C+0F+FosGAUvBmckaOd grKPuZyOddcFucYXyclm5zwOa0VnB2JRuCSlhqgL3h7xFm2FRCi2cIzs0WmXkNsLgnTYNf2u jCOqN00JlTU84/d8tGdak8aPryLlaIbQPHMWqUL1iiProAIWjxp5n+56hwzP22eaYP0IA5lP 36IRxlXFYJCgLT4PC1rd52GkinehT+Yd2t8LAT23FBgMy8eFKxWhfzDWzHkKOb0oci64PgKr KO0altco/exFvVaPh0NjLFKuhvwAElIasoU/YAKiazS5HwW/rXn92eVsrvD5zQNhthcl/DIx I4LUvOzYN7nw2WZkM= X-IronPort-AV: E=Sophos;i="5.96,187,1665460800"; d="scan'208";a="85425922" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lKIpnEm50ROSlVG1uvI1R6yYmCbxqTGKv9wMFaqDoQXQUMPAjTi1JJCmD4KpSWOhWNL2TOceCcZLCInOgIpOXdYfwArAWEsbTBc+aHsOlgYkdwlm3/kfLcYuHNmAYJYYlVB3o02Dn/+WLsNKtcVqhm1Aq1uC8NCYeT2tnrJ7o92OiGn/SnCirZlUt04r4qPjO95EHpyFeUROTObpjIvyiIr5Anx0AOvUyFMSOOh/twQ5twwWcDSSwoYnLbxZXf9C8GE4+Yii6dOroANZo48mC599G0zGWae9OeY2ZM8uUO2TT47LNINF6I3Y0PhMV4GSnWGsbyz8q+EQiAI5CDAURg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zf502VoX9A12guSHyYKYXI0C23cUCFbnzBqkpMCisdc=; b=h6+imtFpwGnKWpECzLSNgYAxzU2uj4RU9Qb9z6u/WQjpyquQGn4oEdX4XsKuGkO2JsGIvOzhhAT6pd1sWzhkiqOsBnfPvUcP579Ggh/O1AJEFHfU1wg48PMa5jeZuGO43kWab+Brz0jZhyfQRmJZ+8IviV7HPRtGd28rcXNbOsb0q421ooIWR6Kff56WF4fV86ZBRO/zzbcbDmMjT1FokRoI64OyEG2GevAFTsTbzIQTl0kKspspfX6ZyNzSNE5zMG4FMgDfmlS2RdDNVrT81XtmyTWl0xhavSAa9+1R+uCLxAtplT+d3dypD+Mp/qFv328gbM9/LUJ33bdt0opuKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zf502VoX9A12guSHyYKYXI0C23cUCFbnzBqkpMCisdc=; b=nff6HDhegQ1LG3mE6aisggn0FX8/1VLBsHanuIvPozrBqBZifNftqYA8AswJpEZNR9E1G2JMZ7abE/AN7+ryf/S7gsu1fv8xZVt/f6sSgupHkq3fdn6PtJNGtSMxPODG7eng6OR5qcBKX8q618n3lGztnBRI1Ojfnezrko2olrQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: marmarek@invisiblethingslab.com, Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 5/5] multiboot2: parse vga= option when setting GOP mode Date: Wed, 23 Nov 2022 16:45:24 +0100 Message-Id: <20221123154525.63068-6-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221123154525.63068-1-roger.pau@citrix.com> References: <20221123154525.63068-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0111.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c3::11) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM4PR03MB6935:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f55f998-2f0c-4c8c-549d-08dacd69d16b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pc/m6AVaAeLOVtlPo+XXo6PnlyorZPyRwKgMys9jx3iwT+5NkTh3FcX0bgYo5wyZ67lBPiFkZbmmmKQaZjGmmmuXlEhVXM82zIBIjpxS+dGgjbTLrfbbIUEIc93FfXtNHRsLj9FQ3cVKf+X/ktudvhyqgZjdyvQRiMqnvqgGs6eOextFXVxdZ15XTeq9shZpTcboZB8UFEMpFn+WXQs3zXzxaDcPyNEsXgqo8vl44k6a0ohzrO8qPBXKCG6GdEINfeqAfQbFe9PrmvLbQNMzpC9ZvTRCz+pnznu+OSZXy95nrD81aOy/Dd1Q0DIeQlTPyDty9fdflWRUlIvzTR+uUeppS4DgUJFJ66HJ6RflzRk2G0MZdwxV8CPKSyJvj7nBkhRY5Zb7ShfAI4ZJEqD2c9MzhhJskbGLdwJIouwAViM5dSl2HDNikmI/ghv1JV/MhfsmEOejzIJWJEYFugXi2xBMLYP9ECGu25Ak29duVlaFcaf1sjyUMkd/8NOtmpbDb96/txnLDXAkKN/6Jtp/+U8V4nQu8rnufoUO8If7KJ9yHWmbg2OZpeSjhZOgdZYtbMKrBmc+xb2JNuA2BWv59XIcJ5SeCiy8M+4AbE9N66YaFD2Ikl8os6+sbC6MkiZ/oDHhHoCmkLLm6+FlfXP9EA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(346002)(366004)(451199015)(36756003)(86362001)(41300700001)(66556008)(66946007)(316002)(66476007)(4326008)(8676002)(82960400001)(38100700002)(6486002)(83380400001)(54906003)(6916009)(478600001)(186003)(2906002)(5660300002)(8936002)(6506007)(2616005)(1076003)(26005)(6512007)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WktXeDNlbElDRmxoZmovZk1manRFaEZXTEpTd2pLL3V5MW51Q2ZQV2lLdkRE?= =?utf-8?B?ZGRVUU1LWU5zMG1ydElwVVF6Q1gzRTA5SUF5TDFFdHVVTnRoUjUwK0d0RTV5?= =?utf-8?B?NjNseC9GdUgxYlpjWGh3RzZoNWtRN2NGSlNZeFo5bW5WZmtGQVVDTVJIK1BV?= =?utf-8?B?eExpUGhaRFVWY011YWVMSnZTZDJ4VnMyKzZwVjhZWmlhNkpxRlEwWTlXTTBL?= =?utf-8?B?R2diNUFiNUs2MlIydGYwNUdGZk5LK2FHYjNUdjlFVlIrZSt5Q1dUZkNFMDVT?= =?utf-8?B?WEFnYUxBWlcwcnNPS2xhNXMwYVpLTTRGSjVBTHV3R2svdm56NHp5S2Q4VmFH?= =?utf-8?B?bzhSSDRvMUZEV2NRWngxZ2poSzl4WStaamFabDl3ZFlYYlhyMnNZOXdvWk01?= =?utf-8?B?VTROR3BreWpEQndVY1pwMG1GUGs1aDRzN2t0elF2ZjlzNUlidHFDM3YvM0dO?= =?utf-8?B?OUtNMDAyaXRYaHlBZkFvb084NE5lZVpNMlpsRUVQNVlwRzVycWQ3WHlxaGFp?= =?utf-8?B?TWhRaFExeHR6bGt6Wm5GWlVsNlVISCtoR1J0QUFZcEZMN2JEQUFGTFBOQnF5?= =?utf-8?B?WjZ5SGhqWXk2K1djUmhoc2k2VG40UkJOOEtva3JVanBxbVQ1Si81M2lYSlM2?= =?utf-8?B?QVN6QkdSOFk4enk5YjJBdXNMRW5EN3NMQmdVTEMxaElGMkRoNGJwQzRNQ3FS?= =?utf-8?B?bUhvQnVYaEJnWGduVWhnKzhZY21hVTNyT2J1NWxhQWdtbEpKbHBPK0wxN29m?= =?utf-8?B?RzNVUDNXQURWMDdGN25KdHdsWDE3QjZDUnIzRUV0dE1pb3dTaGNVZkozMU1F?= =?utf-8?B?Slp6YUt5YS9pY2lJSSt6a09WcEN4QTlXUkJhbmFBbGZxWjRoZkU1aGNkTFZN?= =?utf-8?B?c1czc0JjZnBqTjAySmwzcCtKdG9OWmdvYlA2eVYwNDFLaytlR2tNcWpDTzZG?= =?utf-8?B?ZG1IYmpFUFRyWnVCMHAybmJkV2xEejZmZURmV0lCdXpyaXQrRDBkaXVnT0Fu?= =?utf-8?B?T3o2ZU5RZDdxUDltbmtIcW5kR24zMkQ0UDJBL01hUXNOSElEemY5aU1aZ3BW?= =?utf-8?B?c1JDV3lqb2V4b3l5WVpkK0crenZ0RVBIVi81elNuaTA5cFViN0V1WUR2Ujkx?= =?utf-8?B?VTYrK2t1Y29lS2ZNMU9RMFFMaHdseEhyRTA1ZTk5dGV4L0xKcGxqZVFZaDdI?= =?utf-8?B?VlFwaHFUMDhxOHJMMk5KUmkzT3dlQlZyRDFGZzZsb2lCZDdDUFIvRlhDYXpy?= =?utf-8?B?QXkwQjRiN0NFbFNOdFZWaDhBQW5yWkRoQzhkakppLzlXNy82M2RlVGhYYXBm?= =?utf-8?B?SGl1RXpyVmJWSUd4NU9tTDJ1c2hiRjZ3cllvUUdPN1Y5KzZXV0cxdkw3NStT?= =?utf-8?B?VGUzZHNKcVlqNlFveDVzL3R0WmJkemp4OUtkNFpFUTdPUG1NNStwK2pPVHc0?= =?utf-8?B?T052WXZ0UDRCQVhZWG1KVTg0eDZHTEJOUDZ0dUprRFh2bHhzRjdWdFZsbmcx?= =?utf-8?B?MlRkemlWM2R5OGkzQzJlenF4cEZuR0dqM29nUVUwYlBhUk5tZWduZ1V1enNj?= =?utf-8?B?TUwrQitBYjRNOGZFbWNRZFlPRG9hWXRJRmtiQWc5VXltRHMxaDI3VFlSRWVr?= =?utf-8?B?czlNM2VJdnVZRHdSY2NzWXovVTNETlhieDNxUzNuYWZMdHlaK2ZSYXZCckdB?= =?utf-8?B?cWljYUtSZXRJLzJobTYvc0ZCYzlHYmxNa0NGVUdkSlQzQld6OTU3aXBmWTlT?= =?utf-8?B?eDlEZThVT2ljbXJlM2NvVU82Mjl2dzZyOUE0WnlPcW1xdTU5cUZ3NlVheWdz?= =?utf-8?B?TU5QaWVQYzJRZnNhREVRVm1tMnBVNjFMQ3ZoWk9YeFJkeVJyYUZTemxwRU1I?= =?utf-8?B?T1RYbHkwd1h4a3RCb1NjYXRtM290WTkrRnRZS1FBNXRrTytSUjRjbldyRkVW?= =?utf-8?B?dXM5U1hxdHQzVGZ5UWtqdDdIUGRyakltNE02MUJOMUFLTytneE5xczFoYlpW?= =?utf-8?B?OGZBSm4xeDBSK1ZSQjNFZHNycG5kb25pRUNxMkRRQ21kaFFZeEVBSVdZQ213?= =?utf-8?B?dmd0RVFnbzNiN2p1aVFuUVZBSWVNa0xEdUF0NmFPbFBUWlFOQm0rWDdEL1o3?= =?utf-8?Q?XFu84tIjbeQTTQi3foOSGNUMS?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TvjOtGy14rGVM4fR29dJUdJeO7FT4bSPa3MegItj5/K9Nih5T2pbvFY0viMdjqkt1EkBQ7zMwV2S1FsHn1sM0UcRlQHBWrod+pFbPhht4UoyA4X78qQ4twPVFZrsx2CkzSb/l1tycY0zl9KN3tpBqS76EityR9ZHnaqrxjarG5wOQSCbCHMXv7zdKlCdEG+nC07uv5EJ2MQ1MiByRxBempIxtBHsltTgT3Yk6ie7kP5H+aR6r5LvZiWeo7Schx0CcmoIpfwHVvEeX44NHE1eo47Pco2bNTKCdloLf6YeSoK7bDOgWG7s827HaJZochue9eqWrGFOhTHQ/ggvnjdZG0mO9vUM5BGeLEDI4GLdzacWNyj7XEOeDRQa4+BAfc9A7HCmJ4Yh8hd8OqQEfGpXkDJcBCXTIh+zYZCRqkRhJikBuI8I5Bh6yHmjNofOoT9lfPVXXdWL7DoYPiez4PTDpn3E/nZ0xTPrE9oOuLFzW6ygp89qykXN62ArUS9hCk1xGez2kGqvl0ZO3YBAdJ6YUrM/5k6JBiqAEyAoHkffXy4J02p5+EpcC4oLDUypzFEb40HLLs4olNkvR9YFBGWq5DZOye5waaQcU8LL4/iXPx8RsmDi7ebwVdRuhRS4YiB/MJtT1+HaNR5r9z3vkClvN3q4tsv+KwRnLB5t/yGhlQzzYkY+cS8VUQAHLLuxYCwTPuspSLqZVzYwXXJUbfKDQIeggzu/s/3LmZxjtUUBdGAPbtDl8+dgYTUQrvUN07Nn2O3cMxYwQ/gQwe15rJa3U9gBu8eQYtUaO/nEYmDxnDEIf0nYoMDF5HmmK9F89IXylZK3PLPUzJHvNlVWGKabC6RCtFLSfl+ShGeya/gPTKd7Oq7Y1H9gJq9M9Vp0btSv X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f55f998-2f0c-4c8c-549d-08dacd69d16b X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 15:45:59.7578 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R6JO6RirB05AEEtXe1ZZPPuK8ZycnEVdTbZfHdhPBXhh5JwSWk3G6Sz8CPHv9lresc0JqpRb6Y4d+oZqVtiwaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6935 Currently the vga command line gfx- option is ignored when booted using multboot2 and EFI, as the setting of the GOP mode is done way before the command line is processed. Add support for parsing the vga gfx- selection if present in order to set the selected GOP mode. Signed-off-by: Roger Pau Monné --- xen/arch/x86/efi/efi-boot.h | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 695491a5b7..e791d65213 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -835,7 +835,22 @@ void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable if ( vga ) { - gop_mode = efi_find_gop_mode(gop, 0, 0, 0); + unsigned int width = 0, height = 0, depth = 0; + + opt = get_option(cmdline, "vga=gfx-"); + if ( opt ) + { + width = simple_strtoul(opt, &opt, 10); + if ( *opt == 'x' ) + height = simple_strtoul(opt + 1, &opt, 10); + if ( *opt == 'x' ) + depth = simple_strtoul(opt + 1, &opt, 10); + /* Allow depth to be 0 or unset. */ + if ( !width || !height ) + width = height = depth = 0; + } + + gop_mode = efi_find_gop_mode(gop, width, height, depth); } efi_arch_edid(gop_handle); -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 15:47:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 15:47:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447651.704141 (Exim 4.92) (envelope-from ) id 1oxrxz-0003Nv-MP; Wed, 23 Nov 2022 15:47:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447651.704141; Wed, 23 Nov 2022 15:47:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrxz-0003Nm-J6; Wed, 23 Nov 2022 15:47:15 +0000 Received: by outflank-mailman (input) for mailman id 447651; Wed, 23 Nov 2022 15:47:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrxy-0003Nc-0G; Wed, 23 Nov 2022 15:47:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrxx-0000JV-TC; Wed, 23 Nov 2022 15:47:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxrxx-0001PP-Fv; Wed, 23 Nov 2022 15:47:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxrxx-0006fj-FJ; Wed, 23 Nov 2022 15:47:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=b51LMzepna99QV2VVjwilYs+MOd4JGDNWrqwR53CkB8=; b=bAdqoBOeFSJ79de7X1Bed5A9Oc XUUh93pKJvQhKN6dSMGbznuBs7ke+9r1APM0L1dHZsUjhJsdzFcHKNZb/onJZujCenOX+G+7oW1d8 OPqk8FimJcPKd2KFFo6mBifTwAlD7MsHyW9xV6bdDneB9yBCYj5cpwy8ogSY0mWRwUVA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174935: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=7c09a7f6ae1770d15535980d15dffdb23f4d9786 X-Osstest-Versions-That: qemuu=16a550bdc0e49fcda0e6a6c55d648700ad33c8a4 From: osstest service owner Date: Wed, 23 Nov 2022 15:47:13 +0000 flight 174935 qemu-mainline real [real] flight 174945 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174935/ http://logs.test-lab.xenproject.org/osstest/logs/174945/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 19 guest-localmigrate/x10 fail pass in 174945-retest test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 174945-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174923 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174923 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174923 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174923 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174923 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail like 174923 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174923 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174923 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174923 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: qemuu 7c09a7f6ae1770d15535980d15dffdb23f4d9786 baseline version: qemuu 16a550bdc0e49fcda0e6a6c55d648700ad33c8a4 Last test of basis 174923 2022-11-22 17:38:29 Z 0 days Testing same since 174935 2022-11-23 03:11:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Peter Maydell Stefan Hajnoczi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 16a550bdc0..7c09a7f6ae 7c09a7f6ae1770d15535980d15dffdb23f4d9786 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Nov 23 15:55:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 15:55:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447665.704151 (Exim 4.92) (envelope-from ) id 1oxs5l-0005Ei-LL; Wed, 23 Nov 2022 15:55:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447665.704151; Wed, 23 Nov 2022 15:55:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxs5l-0005Eb-IY; Wed, 23 Nov 2022 15:55:17 +0000 Received: by outflank-mailman (input) for mailman id 447665; Wed, 23 Nov 2022 15:55:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxs5j-0005EV-Kk for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 15:55:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxs5h-0000SR-3F; Wed, 23 Nov 2022 15:55:13 +0000 Received: from [54.239.6.185] (helo=[192.168.17.134]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxs5g-0000W6-QT; Wed, 23 Nov 2022 15:55:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=2DU5FXefMwkpxT5iu9q9AFV/I8ZqbL11hribnK80jCI=; b=hGyF218PFjA015KXQz/iDoOFYK /NCIKJK8zm0mPhYqOBZ0bEVzE9RxUnpeG4mmTM/4ljsrbBkvU1uGZANVS6HncLXUcq8za84sLHqDo H+HsMzz1yKIxxHUVv27hBrQhw1k1wrn7HkqnmBJw+DbUv/3m1shYOuVsgjvewJ21KOSI=; Message-ID: Date: Wed, 23 Nov 2022 16:55:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] xen/arm: Fix unreachable panic for vpl011 vIRQ Content-Language: en-US To: Bertrand Marquis , Michal Orzel Cc: Xen developer discussion , Stefano Stabellini , Volodymyr Babchuk References: <20221123143913.6527-1-michal.orzel@amd.com> <29E29CB0-35F8-4961-9197-14E8CD7C43CA@arm.com> From: Julien Grall In-Reply-To: <29E29CB0-35F8-4961-9197-14E8CD7C43CA@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23/11/2022 15:22, Bertrand Marquis wrote: > Hi Michal, > >> On 23 Nov 2022, at 14:39, Michal Orzel wrote: >> >> When creating direct mapped domU, the vIRQ for vpl011 is taken from >> the SERHND_DTUART serial port using serial_irq. This function can return >> -1 (i.e. no interrupt found) in which case we should call a panic. >> However, vpl011_virq is defined as unsigned int which causes the panic >> to be unreachable, because less than zero comparison of an unsigned value >> can never be true. Fix it by defining vpl011_virq as int. >> >> Fixes: 3580c8b2dfc3 ("xen/arm: if direct-map domain use native UART address and IRQ number for vPL011") >> Signed-off-by: Michal Orzel > Reviewed-by: Bertrand Marquis > > >> --- >> To be considered to be taken for 4.17, although direct-map depends on >> CONFIG_STATIC_MEMORY which is marked as unsupported. > > At this stage I do not think we should back port it for the release. > We should consider this as candidate for 4.17.1 We don't usually backport fixes for tech preview feature. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Nov 23 16:02:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 16:02:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447669.704163 (Exim 4.92) (envelope-from ) id 1oxsCQ-0007N7-AC; Wed, 23 Nov 2022 16:02:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447669.704163; Wed, 23 Nov 2022 16:02:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxsCQ-0007N0-7X; Wed, 23 Nov 2022 16:02:10 +0000 Received: by outflank-mailman (input) for mailman id 447669; Wed, 23 Nov 2022 16:02:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxsCP-0007Mi-GZ for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 16:02:09 +0000 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2cbd76ff-6b48-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 17:02:07 +0100 (CET) Received: from dggpeml500023.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NHQq14xjjzRpDj; Thu, 24 Nov 2022 00:01:33 +0800 (CST) Received: from ubuntu1804.huawei.com (10.67.174.58) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 24 Nov 2022 00:02:03 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2cbd76ff-6b48-11ed-91b6-6bf2151ebd3b From: Xiu Jianfeng To: , , , , , , , CC: , , Subject: [PATCH v2 2/2] x86/xen: Fix memory leak in xen_init_lock_cpu() Date: Wed, 23 Nov 2022 23:58:58 +0800 Message-ID: <20221123155858.11382-3-xiujianfeng@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221123155858.11382-1-xiujianfeng@huawei.com> References: <20221123155858.11382-1-xiujianfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.174.58] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500023.china.huawei.com (7.185.36.114) X-CFilter-Loop: Reflected In xen_init_lock_cpu(), the @name has allocated new string by kasprintf(), if bind_ipi_to_irqhandler() fails, it should be freed, otherwise may lead to a memory leak issue, fix it. Fixes: 2d9e1e2f58b5 ("xen: implement Xen-specific spinlocks") Signed-off-by: Xiu Jianfeng --- arch/x86/xen/spinlock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c index 043c73dfd2c9..5c6fc16e4b92 100644 --- a/arch/x86/xen/spinlock.c +++ b/arch/x86/xen/spinlock.c @@ -75,6 +75,7 @@ void xen_init_lock_cpu(int cpu) cpu, per_cpu(lock_kicker_irq, cpu)); name = kasprintf(GFP_KERNEL, "spinlock%d", cpu); + per_cpu(irq_name, cpu) = name; irq = bind_ipi_to_irqhandler(XEN_SPIN_UNLOCK_VECTOR, cpu, dummy_handler, @@ -85,7 +86,6 @@ void xen_init_lock_cpu(int cpu) if (irq >= 0) { disable_irq(irq); /* make sure it's never delivered */ per_cpu(lock_kicker_irq, cpu) = irq; - per_cpu(irq_name, cpu) = name; } printk("cpu %d spinlock event irq %d\n", cpu, irq); @@ -98,6 +98,8 @@ void xen_uninit_lock_cpu(int cpu) if (!xen_pvspin) return; + kfree(per_cpu(irq_name, cpu)); + per_cpu(irq_name, cpu) = NULL; /* * When booting the kernel with 'mitigations=auto,nosmt', the secondary * CPUs are not activated, and lock_kicker_irq is not initialized. @@ -108,8 +110,6 @@ void xen_uninit_lock_cpu(int cpu) unbind_from_irqhandler(irq, NULL); per_cpu(lock_kicker_irq, cpu) = -1; - kfree(per_cpu(irq_name, cpu)); - per_cpu(irq_name, cpu) = NULL; } PV_CALLEE_SAVE_REGS_THUNK(xen_vcpu_stolen); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 16:02:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 16:02:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447670.704168 (Exim 4.92) (envelope-from ) id 1oxsCQ-0007PR-Id; Wed, 23 Nov 2022 16:02:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447670.704168; Wed, 23 Nov 2022 16:02:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxsCQ-0007Oo-EE; Wed, 23 Nov 2022 16:02:10 +0000 Received: by outflank-mailman (input) for mailman id 447670; Wed, 23 Nov 2022 16:02:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxsCP-0007Mj-P6 for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 16:02:09 +0000 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2cbf32f4-6b48-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 17:02:06 +0100 (CET) Received: from dggpeml500023.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NHQln6mVczJnhn; Wed, 23 Nov 2022 23:58:45 +0800 (CST) Received: from ubuntu1804.huawei.com (10.67.174.58) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 24 Nov 2022 00:02:02 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2cbf32f4-6b48-11ed-8fd2-01056ac49cbb From: Xiu Jianfeng To: , , , , , , , CC: , , Subject: [PATCH v2 0/2]x86/xen: Fix memory leak issue Date: Wed, 23 Nov 2022 23:58:56 +0800 Message-ID: <20221123155858.11382-1-xiujianfeng@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.174.58] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500023.china.huawei.com (7.185.36.114) X-CFilter-Loop: Reflected The new string allocated by kasprintf() is leaked on error paths v2: follow Juergen's suggestion. Xiu Jianfeng (2): x86/xen: Fix memory leak in xen_smp_intr_init{_pv}() x86/xen: Fix memory leak in xen_init_lock_cpu() arch/x86/xen/smp.c | 24 ++++++++++++------------ arch/x86/xen/smp_pv.c | 12 ++++++------ arch/x86/xen/spinlock.c | 6 +++--- 3 files changed, 21 insertions(+), 21 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 16:02:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 16:02:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447671.704185 (Exim 4.92) (envelope-from ) id 1oxsCR-0007rV-Se; Wed, 23 Nov 2022 16:02:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447671.704185; Wed, 23 Nov 2022 16:02:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxsCR-0007rO-N2; Wed, 23 Nov 2022 16:02:11 +0000 Received: by outflank-mailman (input) for mailman id 447671; Wed, 23 Nov 2022 16:02:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxsCQ-0007Mj-GW for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 16:02:10 +0000 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2d18bb36-6b48-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 17:02:07 +0100 (CET) Received: from dggpeml500023.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NHQq012txz15Mqg; Thu, 24 Nov 2022 00:01:32 +0800 (CST) Received: from ubuntu1804.huawei.com (10.67.174.58) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 24 Nov 2022 00:02:03 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d18bb36-6b48-11ed-8fd2-01056ac49cbb From: Xiu Jianfeng To: , , , , , , , CC: , , Subject: [PATCH v2 1/2] x86/xen: Fix memory leak in xen_smp_intr_init{_pv}() Date: Wed, 23 Nov 2022 23:58:57 +0800 Message-ID: <20221123155858.11382-2-xiujianfeng@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221123155858.11382-1-xiujianfeng@huawei.com> References: <20221123155858.11382-1-xiujianfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.174.58] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500023.china.huawei.com (7.185.36.114) X-CFilter-Loop: Reflected These local variables @{resched|pmu|callfunc...}_name saves the new string allocated by kasprintf(), and when bind_{v}ipi_to_irqhandler() fails, it goes to the @fail tag, and calls xen_smp_intr_free{_pv}() to free resource, however the new string is not saved, which cause a memory leak issue. fix it. Fixes: 9702785a747a ("i386: move xen") Signed-off-by: Xiu Jianfeng --- arch/x86/xen/smp.c | 24 ++++++++++++------------ arch/x86/xen/smp_pv.c | 12 ++++++------ 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c index c3e1f9a7d43a..4b0d6fff88de 100644 --- a/arch/x86/xen/smp.c +++ b/arch/x86/xen/smp.c @@ -32,30 +32,30 @@ static irqreturn_t xen_reschedule_interrupt(int irq, void *dev_id) void xen_smp_intr_free(unsigned int cpu) { + kfree(per_cpu(xen_resched_irq, cpu).name); + per_cpu(xen_resched_irq, cpu).name = NULL; if (per_cpu(xen_resched_irq, cpu).irq >= 0) { unbind_from_irqhandler(per_cpu(xen_resched_irq, cpu).irq, NULL); per_cpu(xen_resched_irq, cpu).irq = -1; - kfree(per_cpu(xen_resched_irq, cpu).name); - per_cpu(xen_resched_irq, cpu).name = NULL; } + kfree(per_cpu(xen_callfunc_irq, cpu).name); + per_cpu(xen_callfunc_irq, cpu).name = NULL; if (per_cpu(xen_callfunc_irq, cpu).irq >= 0) { unbind_from_irqhandler(per_cpu(xen_callfunc_irq, cpu).irq, NULL); per_cpu(xen_callfunc_irq, cpu).irq = -1; - kfree(per_cpu(xen_callfunc_irq, cpu).name); - per_cpu(xen_callfunc_irq, cpu).name = NULL; } + kfree(per_cpu(xen_debug_irq, cpu).name); + per_cpu(xen_debug_irq, cpu).name = NULL; if (per_cpu(xen_debug_irq, cpu).irq >= 0) { unbind_from_irqhandler(per_cpu(xen_debug_irq, cpu).irq, NULL); per_cpu(xen_debug_irq, cpu).irq = -1; - kfree(per_cpu(xen_debug_irq, cpu).name); - per_cpu(xen_debug_irq, cpu).name = NULL; } + kfree(per_cpu(xen_callfuncsingle_irq, cpu).name); + per_cpu(xen_callfuncsingle_irq, cpu).name = NULL; if (per_cpu(xen_callfuncsingle_irq, cpu).irq >= 0) { unbind_from_irqhandler(per_cpu(xen_callfuncsingle_irq, cpu).irq, NULL); per_cpu(xen_callfuncsingle_irq, cpu).irq = -1; - kfree(per_cpu(xen_callfuncsingle_irq, cpu).name); - per_cpu(xen_callfuncsingle_irq, cpu).name = NULL; } } @@ -65,6 +65,7 @@ int xen_smp_intr_init(unsigned int cpu) char *resched_name, *callfunc_name, *debug_name; resched_name = kasprintf(GFP_KERNEL, "resched%d", cpu); + per_cpu(xen_resched_irq, cpu).name = resched_name; rc = bind_ipi_to_irqhandler(XEN_RESCHEDULE_VECTOR, cpu, xen_reschedule_interrupt, @@ -74,9 +75,9 @@ int xen_smp_intr_init(unsigned int cpu) if (rc < 0) goto fail; per_cpu(xen_resched_irq, cpu).irq = rc; - per_cpu(xen_resched_irq, cpu).name = resched_name; callfunc_name = kasprintf(GFP_KERNEL, "callfunc%d", cpu); + per_cpu(xen_callfunc_irq, cpu).name = callfunc_name; rc = bind_ipi_to_irqhandler(XEN_CALL_FUNCTION_VECTOR, cpu, xen_call_function_interrupt, @@ -86,10 +87,10 @@ int xen_smp_intr_init(unsigned int cpu) if (rc < 0) goto fail; per_cpu(xen_callfunc_irq, cpu).irq = rc; - per_cpu(xen_callfunc_irq, cpu).name = callfunc_name; if (!xen_fifo_events) { debug_name = kasprintf(GFP_KERNEL, "debug%d", cpu); + per_cpu(xen_debug_irq, cpu).name = debug_name; rc = bind_virq_to_irqhandler(VIRQ_DEBUG, cpu, xen_debug_interrupt, IRQF_PERCPU | IRQF_NOBALANCING, @@ -97,10 +98,10 @@ int xen_smp_intr_init(unsigned int cpu) if (rc < 0) goto fail; per_cpu(xen_debug_irq, cpu).irq = rc; - per_cpu(xen_debug_irq, cpu).name = debug_name; } callfunc_name = kasprintf(GFP_KERNEL, "callfuncsingle%d", cpu); + per_cpu(xen_callfuncsingle_irq, cpu).name = callfunc_name; rc = bind_ipi_to_irqhandler(XEN_CALL_FUNCTION_SINGLE_VECTOR, cpu, xen_call_function_single_interrupt, @@ -110,7 +111,6 @@ int xen_smp_intr_init(unsigned int cpu) if (rc < 0) goto fail; per_cpu(xen_callfuncsingle_irq, cpu).irq = rc; - per_cpu(xen_callfuncsingle_irq, cpu).name = callfunc_name; return 0; diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c index 480be82e9b7b..6175f2c5c822 100644 --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -97,18 +97,18 @@ asmlinkage __visible void cpu_bringup_and_idle(void) void xen_smp_intr_free_pv(unsigned int cpu) { + kfree(per_cpu(xen_irq_work, cpu).name); + per_cpu(xen_irq_work, cpu).name = NULL; if (per_cpu(xen_irq_work, cpu).irq >= 0) { unbind_from_irqhandler(per_cpu(xen_irq_work, cpu).irq, NULL); per_cpu(xen_irq_work, cpu).irq = -1; - kfree(per_cpu(xen_irq_work, cpu).name); - per_cpu(xen_irq_work, cpu).name = NULL; } + kfree(per_cpu(xen_pmu_irq, cpu).name); + per_cpu(xen_pmu_irq, cpu).name = NULL; if (per_cpu(xen_pmu_irq, cpu).irq >= 0) { unbind_from_irqhandler(per_cpu(xen_pmu_irq, cpu).irq, NULL); per_cpu(xen_pmu_irq, cpu).irq = -1; - kfree(per_cpu(xen_pmu_irq, cpu).name); - per_cpu(xen_pmu_irq, cpu).name = NULL; } } @@ -118,6 +118,7 @@ int xen_smp_intr_init_pv(unsigned int cpu) char *callfunc_name, *pmu_name; callfunc_name = kasprintf(GFP_KERNEL, "irqwork%d", cpu); + per_cpu(xen_irq_work, cpu).name = callfunc_name; rc = bind_ipi_to_irqhandler(XEN_IRQ_WORK_VECTOR, cpu, xen_irq_work_interrupt, @@ -127,10 +128,10 @@ int xen_smp_intr_init_pv(unsigned int cpu) if (rc < 0) goto fail; per_cpu(xen_irq_work, cpu).irq = rc; - per_cpu(xen_irq_work, cpu).name = callfunc_name; if (is_xen_pmu) { pmu_name = kasprintf(GFP_KERNEL, "pmu%d", cpu); + per_cpu(xen_pmu_irq, cpu).name = pmu_name; rc = bind_virq_to_irqhandler(VIRQ_XENPMU, cpu, xen_pmu_irq_handler, IRQF_PERCPU|IRQF_NOBALANCING, @@ -138,7 +139,6 @@ int xen_smp_intr_init_pv(unsigned int cpu) if (rc < 0) goto fail; per_cpu(xen_pmu_irq, cpu).irq = rc; - per_cpu(xen_pmu_irq, cpu).name = pmu_name; } return 0; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 23 16:03:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 16:03:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447681.704196 (Exim 4.92) (envelope-from ) id 1oxsE6-0000Z7-6a; Wed, 23 Nov 2022 16:03:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447681.704196; Wed, 23 Nov 2022 16:03:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxsE6-0000Z0-3d; Wed, 23 Nov 2022 16:03:54 +0000 Received: by outflank-mailman (input) for mailman id 447681; Wed, 23 Nov 2022 16:03:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxsE4-0000Yd-MZ for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 16:03:52 +0000 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b20ca29-6b48-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 17:03:51 +0100 (CET) Received: from dggpeml500023.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NHQn54Mp3zqSV2; Wed, 23 Nov 2022 23:59:53 +0800 (CST) Received: from [10.67.110.112] (10.67.110.112) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 24 Nov 2022 00:03:49 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b20ca29-6b48-11ed-91b6-6bf2151ebd3b Subject: Re: [PATCH 0/2] x86/xen: Fix memory leak issue To: Juergen Gross , , , , , , , CC: , , References: <20221119085923.114889-1-xiujianfeng@huawei.com> <33b9d446-9907-ded6-114e-ce6c43cc3446@suse.com> From: xiujianfeng Message-ID: <22003e76-0aae-e699-f231-85f8313e4a36@huawei.com> Date: Thu, 24 Nov 2022 00:03:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <33b9d446-9907-ded6-114e-ce6c43cc3446@suse.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.112] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500023.china.huawei.com (7.185.36.114) X-CFilter-Loop: Reflected Hi, 在 2022/11/23 23:23, Juergen Gross 写道: > On 19.11.22 09:59, Xiu Jianfeng wrote: >> The new string allocated by kasprintf() is leaked on error path >> >> Xiu Jianfeng (2): >>    x86/xen: Fix memory leak in xen_smp_intr_init{_pv}() >>    x86/xen: Fix memory leak in xen_init_lock_cpu() >> >>   arch/x86/xen/smp.c      | 16 ++++++++++++---- >>   arch/x86/xen/smp_pv.c   |  8 ++++++-- >>   arch/x86/xen/spinlock.c |  3 ++- >>   3 files changed, 20 insertions(+), 7 deletions(-) >> > > Hmm, I think it would make more sense to always store the name generated > via kasprintf() in the percpu variable (independently from succeeding to > bind the irq), and in the related free function to always kfree() it and > set it to NULL again. > > This would result in less code. Thanks, It's good to me, already sent v2. > > > Juergen From xen-devel-bounces@lists.xenproject.org Wed Nov 23 17:04:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 17:04:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447692.704209 (Exim 4.92) (envelope-from ) id 1oxtA2-0007g4-I4; Wed, 23 Nov 2022 17:03:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447692.704209; Wed, 23 Nov 2022 17:03:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxtA2-0007fx-FS; Wed, 23 Nov 2022 17:03:46 +0000 Received: by outflank-mailman (input) for mailman id 447692; Wed, 23 Nov 2022 17:03:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxtA0-0007fr-CX for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 17:03:44 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c8aa8001-6b50-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 18:03:42 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F16CEB821D8; Wed, 23 Nov 2022 17:03:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84193C433B5; Wed, 23 Nov 2022 17:03:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8aa8001-6b50-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669223019; bh=m9XRdTo1RKmcs2mxaIv6FBSHv+6lgqotVqiNHoXrWdc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KIsPk3EyOIxwWCYLSnt73pV3xqGkyYI625biqcGf6DZOEwcTFpFfPyetoe4qgcmD0 9B/nQKKjGeOJznrCyFEEO1diQUnxBXnB1OS6/fbbMC/f2cbaKCEMACyE0zoK8+mYM0 XcAVCDy9AP+95u/VmUv7e9UOtIlbvf+lsM1MqifC9asQqh36Bv2oEQstSSVEA3Z1G0 NqWF28lvWXIWqsmuGepb4eM5KYVoRaDd8iFOwPKPYOCW3rWm7zxwikrcM5o1uVt5Kk V4K7KnlBJ+4e8mcPyqzJPxAZzmnpbtrI1trv1tOMUNdDliSVXHqCoY1aC08XKiGU7F voULg1tMcGajA== Date: Wed, 23 Nov 2022 09:03:37 -0800 From: Josh Poimboeuf To: Andrew Cooper Cc: Peter Zijlstra , "Paul E. McKenney" , "sfr@canb.auug.org.au" , "linux-kernel@vger.kernel.org" , "jgross@suse.com" , "sstabellini@kernel.org" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , Thomas Gleixner Subject: Re: objtool warning for next-20221118 Message-ID: <20221123170337.keacggyvn4ykbtsw@treble> References: <20221121040736.GA3738360@paulmck-ThinkPad-P17-Gen-1> <20221121145215.GF4001@paulmck-ThinkPad-P17-Gen-1> <20221122051605.4hcbslwxez2trdvt@treble> <20221123012350.kelmmadh65lyswqz@treble> <2255c45f-d8ba-3f32-9d99-737ad3040dd7@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2255c45f-d8ba-3f32-9d99-737ad3040dd7@citrix.com> On Wed, Nov 23, 2022 at 10:52:09AM +0000, Andrew Cooper wrote: > > Well, if you return from arch_cpu_idle_dead() you're back in the idle > > loop -- exactly where you would be if you were to bootstrap the whole > > CPU -- provided you have it remember the whole state (easier with a > > vCPU). play_dead() really needs sane semantics. Not only does it introduce a surprise to the offlining code in do_idle(), it also skips the entire hotplug state machine. Not sure if that introduces any bugs, but at the very least it's subtle and surprising. > > But maybe I'm missing something, lets add Xen folks on. > > Calling VCPUOP_down on oneself always succeeds, but all it does is > deschedule the vCPU. > > It can be undone at a later point by a different vcpu issuing VCPUOP_up > against the previously-downed CPU, at which point the vCPU gets rescheduled. > > This is why the VCPUOP_down hypercall returns normally.  All state > really is intact. > > As for what Linux does, this is how xen_pv_cpu_up() currently behaves.  > If you want to make Xen behave more everything else, then bug a BUG() > after VCPUOP_down, and adjust xen_pv_cpu_up() to skip its initialised > check and always use VCPUOP_initialise to bring the vCPU back online. Or we could do what sev_es_play_dead() does and just call start_cpu0() after the hypercall returns? Though, start_cpu0() seems very suspect, it just uses the stack of the idle task of whatever CPU happened to be last brought up via cpu_up(). Which means we now have two idle tasks sharing the same stack? How is start_cpu0() not broken??? -- Josh From xen-devel-bounces@lists.xenproject.org Wed Nov 23 17:09:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 17:09:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447697.704220 (Exim 4.92) (envelope-from ) id 1oxtFO-0008Ji-4c; Wed, 23 Nov 2022 17:09:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447697.704220; Wed, 23 Nov 2022 17:09:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxtFO-0008Jb-1z; Wed, 23 Nov 2022 17:09:18 +0000 Received: by outflank-mailman (input) for mailman id 447697; Wed, 23 Nov 2022 17:09:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxtFM-0008JV-Ve for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 17:09:17 +0000 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [2a00:1450:4864:20::22e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f204587-6b51-11ed-91b6-6bf2151ebd3b; Wed, 23 Nov 2022 18:09:15 +0100 (CET) Received: by mail-lj1-x22e.google.com with SMTP id r8so11493271ljn.8 for ; Wed, 23 Nov 2022 09:09:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f204587-6b51-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=k3ZmQCA06DghUmm4/08LgMrzJ9Jcm98zIeKuuGnYmnE=; b=Z3w2hDG+gD3kDBUDOTKXJiKkdYGarxhaa7IjKH0qdbpY71ZVkcDbJYapTe/6UN+bap h+VQjDuJKwCCu4AqiErj6uj3ro/k5ooGbEANq/uGQHiK38hbNlxnMCSpZFV7TfD5aES9 W4qlBd2ahS5ueBTlVBHxmoANBK2zGvvStCF+zUarDzP013T0Jbt0hlpWfSTEF9PEBGXZ cQODspNYYHb0aIUhb14/zAayPMNLsMjCX3Ii5z8Nn15s7dqyAPIvEdYvfy/Aaan88Zlb i6fp5YBXg862xT0+FO5DNH+NMC9YMmFgwXt8iHD2tdmopNULL2qiWKKN9qzd0+mgKat+ fCoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k3ZmQCA06DghUmm4/08LgMrzJ9Jcm98zIeKuuGnYmnE=; b=ELU5232YOyhz8rMQ0wv0N8VqtY6LSywJQTTy0UuwhDjdp5nxIHil3R/d+ere2wNCJL tZ6RIjMXvSBaTJS6Xe9786naCtvBo8tLhWYBeBj6sm3U8SV3vvvqYuLa4X5uSeFRXdCj aVVYWrK5+yuOSJ3IKs90XPu3mTDNhRRAuIAf6a3JybFf7f7a6S4C4ZxUNDHGJf2+AR5z gGOxn4DvdOlBps83I6SXJyHvjY/EhIoGGwjRXkUrmdzPalYY93eHli/HWH4ssh+y5NIf 4ch9jV/BTrMOhRBC0qVGO7IyTZv8Bh76X1atLVXcfjKJV6cXE52XMvR8JnfbnzjIZ+pV SaVw== X-Gm-Message-State: ANoB5pkx0BlcA7PQElyvo13EMHntAvcBhvRnzH/+KEiQjdnRn2jDK9P4 x0X7Ef4oNUul3G2qnclK1PHWEYCc6FmeYSVGetI= X-Google-Smtp-Source: AA0mqf4+wh3zmf6SqcU+g9RnG/X8Je08CCEtO5G2E9SpIQOlEkVftFtm9SKylmUdUnN1i8yl1Wi0ljK1OTofLYT9i14= X-Received: by 2002:a2e:be1c:0:b0:26e:6fb:4845 with SMTP id z28-20020a2ebe1c000000b0026e06fb4845mr4391642ljq.120.1669223355226; Wed, 23 Nov 2022 09:09:15 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Christopher Clark Date: Wed, 23 Nov 2022 09:09:01 -0800 Message-ID: Subject: Re: Ping: [PATCH] Argo: don't obtain excess page references To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" Content-Type: multipart/alternative; boundary="00000000000023a07805ee26597e" --00000000000023a07805ee26597e Content-Type: text/plain; charset="UTF-8" On Mon, Nov 21, 2022 at 4:41 AM Jan Beulich wrote: > On 11.10.2022 11:28, Jan Beulich wrote: > > find_ring_mfn() already holds a page reference when trying to obtain a > > writable type reference. We shouldn't make assumptions on the general > > reference count limit being effectively "infinity". Obtain merely a type > > ref, re-using the general ref by only dropping the previously acquired > > one in the case of an error. > > > > Signed-off-by: Jan Beulich > > Ping? > Message received -- I will look at this. Thanks. Christopher > > > --- > > I further question the log-dirty check there: The present P2M type of a > > page doesn't really matter for writing to the page (plus it's stale by > > the time it is looked at). Instead I think every write to such a page > > needs to be accompanied by a call to paging_mark_dirty(). > > > > --- a/xen/common/argo.c > > +++ b/xen/common/argo.c > > @@ -1429,10 +1429,11 @@ find_ring_mfn(struct domain *d, gfn_t gf > > ret = -EAGAIN; > > #endif > > else if ( (p2mt != p2m_ram_rw) || > > - !get_page_and_type(page, d, PGT_writable_page) ) > > + !get_page_type(page, PGT_writable_page) ) > > ret = -EINVAL; > > > > - put_page(page); > > + if ( unlikely(ret) ) > > + put_page(page); > > > > return ret; > > } > > > > --00000000000023a07805ee26597e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Nov 21, 2022 at 4:41 AM Jan B= eulich <jbeulich@suse.com> w= rote:
On 11.10.2= 022 11:28, Jan Beulich wrote:
> find_ring_mfn() already holds a page reference when trying to obtain a=
> writable type reference. We shouldn't make assumptions on the gene= ral
> reference count limit being effectively "infinity". Obtain m= erely a type
> ref, re-using the general ref by only dropping the previously acquired=
> one in the case of an error.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Ping?

Message received -- I will look a= t this. Thanks.

Christopher
=C2=A0
=

> ---
> I further question the log-dirty check there: The present P2M type of = a
> page doesn't really matter for writing to the page (plus it's = stale by
> the time it is looked at). Instead I think every write to such a page<= br> > needs to be accompanied by a call to paging_mark_dirty().
>
> --- a/xen/common/argo.c
> +++ b/xen/common/argo.c
> @@ -1429,10 +1429,11 @@ find_ring_mfn(struct domain *d, gfn_t gf
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ret =3D -EAGAIN;
>=C2=A0 #endif
>=C2=A0 =C2=A0 =C2=A0 else if ( (p2mt !=3D p2m_ram_rw) ||
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 !get_page_and_type(p= age, d, PGT_writable_page) )
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 !get_page_type(page,= PGT_writable_page) )
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ret =3D -EINVAL;
>=C2=A0
> -=C2=A0 =C2=A0 put_page(page);
> +=C2=A0 =C2=A0 if ( unlikely(ret) )
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 put_page(page);
>=C2=A0
>=C2=A0 =C2=A0 =C2=A0 return ret;
>=C2=A0 }
>

--00000000000023a07805ee26597e-- From xen-devel-bounces@lists.xenproject.org Wed Nov 23 19:26:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 19:26:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447704.704232 (Exim 4.92) (envelope-from ) id 1oxvNn-0007AP-Uc; Wed, 23 Nov 2022 19:26:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447704.704232; Wed, 23 Nov 2022 19:26:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxvNn-0007AI-Rp; Wed, 23 Nov 2022 19:26:07 +0000 Received: by outflank-mailman (input) for mailman id 447704; Wed, 23 Nov 2022 19:26:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxvNm-0007A8-Gw; Wed, 23 Nov 2022 19:26:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxvNm-0005av-FA; Wed, 23 Nov 2022 19:26:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxvNl-0001G3-Ud; Wed, 23 Nov 2022 19:26:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxvNl-0005Zx-UB; Wed, 23 Nov 2022 19:26:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=I9dibCTK9mZe658ycO2ABOIK1+QjLZkvCmDUyQbQ+p4=; b=Zb2lODb6a0L4ofQ5EcKppLcV1t ZmS5OdHW+ng5ue8+BAUAjcPSJRYMsfmjCYCTU5T23CK+Q8RsMHhu+ACQY4fnuxEuSR161djTdXP+4 JxM+3BcfXAfT0XEDXUfx82s2nCT9dF41UPQGYWaaDbikqZHuGHdKAzsVqPN4vb/PiNFY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174942: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 23 Nov 2022 19:26:05 +0000 flight 174942 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174942/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 47 days Failing since 173470 2022-10-08 06:21:34 Z 46 days 84 attempts Testing same since 174871 2022-11-21 00:40:59 Z 2 days 7 attempts ------------------------------------------------------------ 1802 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 171425 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Nov 23 19:51:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 19:51:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447710.704243 (Exim 4.92) (envelope-from ) id 1oxvm4-0002In-SB; Wed, 23 Nov 2022 19:51:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447710.704243; Wed, 23 Nov 2022 19:51:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxvm4-0002Ig-PU; Wed, 23 Nov 2022 19:51:12 +0000 Received: by outflank-mailman (input) for mailman id 447710; Wed, 23 Nov 2022 19:51:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxvm3-0002IW-FV; Wed, 23 Nov 2022 19:51:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxvm3-00069B-Cp; Wed, 23 Nov 2022 19:51:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxvm2-0001tZ-Vy; Wed, 23 Nov 2022 19:51:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxvm2-0002k0-VV; Wed, 23 Nov 2022 19:51:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Hd15cuIfceCXWMtQNc9tbtUMVwKHUpQ9VDXliUy+/4I=; b=2vD43Bchb7mQD0wAAGB4N3jvwX Iw5PlKnPio+9l02/omISQpoxtgj2veBnyF0+OkIZP02mnD+qd9XKng3MW0m09JDN/aUeHu2OAD39C wBNF+Tmfvej0/fsvJeYmcr7sZiiZXVTo2SDKhpxTZl4327JXImRKOUtKp+5M+DyxADdc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [seabios test] 174947: tolerable FAIL - PUSHED X-Osstest-Failures: seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: seabios=645a64b4911d7cadf5749d7375544fc2384e70ba X-Osstest-Versions-That: seabios=3208b098f51a9ef96d0dfa71d5ec3a3eaec88f0a From: osstest service owner Date: Wed, 23 Nov 2022 19:51:10 +0000 flight 174947 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/174947/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174943 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174943 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174943 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174943 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174943 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: seabios 645a64b4911d7cadf5749d7375544fc2384e70ba baseline version: seabios 3208b098f51a9ef96d0dfa71d5ec3a3eaec88f0a Last test of basis 174943 2022-11-23 08:40:13 Z 0 days Testing same since 174947 2022-11-23 16:41:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Qi Zhou jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/seabios.git 3208b09..645a64b 645a64b4911d7cadf5749d7375544fc2384e70ba -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Nov 23 20:08:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 20:08:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447718.704254 (Exim 4.92) (envelope-from ) id 1oxw2P-0004Fy-Ag; Wed, 23 Nov 2022 20:08:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447718.704254; Wed, 23 Nov 2022 20:08:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxw2P-0004Fr-7T; Wed, 23 Nov 2022 20:08:05 +0000 Received: by outflank-mailman (input) for mailman id 447718; Wed, 23 Nov 2022 20:08:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxw2N-0004Fh-87; Wed, 23 Nov 2022 20:08:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxw2N-0006V3-1W; Wed, 23 Nov 2022 20:08:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxw2M-0002GJ-J6; Wed, 23 Nov 2022 20:08:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oxw2M-0005WF-Id; Wed, 23 Nov 2022 20:08:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=McOozt/uREvGXx5Esx2hAh2hoTbA6GcwbMN0BVwwRC4=; b=Lb2cVbusKXaWJxxQ7wAcldHQhT qPA5o8Ih5yp3hnR5HNkVcn/kZ1p8okDELv7jWh5fpFrt4oWy+NmEJ0a29W+ev1Swo2d/klYSKB0NV hPHzn6ROHEXpiUEFOPEi4pRTPsDNO4Tdday0pbsyYRrF6Z4/ktAdO1aPwi9bn9eSxicw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174944: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-coresched-i386-xl:guest-start.2:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=345135942bf9632eba1409ba432cfcae3b7649c7 X-Osstest-Versions-That: xen=f5d56f4b253072264efc0fece698a91779e362f5 From: osstest service owner Date: Wed, 23 Nov 2022 20:08:02 +0000 flight 174944 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174944/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-coresched-i386-xl 23 guest-start.2 fail in 174930 pass in 174944 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail in 174930 pass in 174944 test-amd64-i386-xl 7 xen-install fail pass in 174930 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174930 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174797 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174797 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174797 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174797 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174797 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174797 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174797 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 345135942bf9632eba1409ba432cfcae3b7649c7 baseline version: xen f5d56f4b253072264efc0fece698a91779e362f5 Last test of basis 174797 2022-11-17 03:03:07 Z 6 days Failing since 174809 2022-11-18 00:06:55 Z 5 days 15 attempts Testing same since 174896 2022-11-21 20:43:42 Z 1 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Daniel P. Smith Jan Beulich Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f5d56f4b25..345135942b 345135942bf9632eba1409ba432cfcae3b7649c7 -> master From xen-devel-bounces@lists.xenproject.org Wed Nov 23 22:25:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 23 Nov 2022 22:25:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447736.704303 (Exim 4.92) (envelope-from ) id 1oxyBW-0003ZR-Eo; Wed, 23 Nov 2022 22:25:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447736.704303; Wed, 23 Nov 2022 22:25:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxyBW-0003ZK-CI; Wed, 23 Nov 2022 22:25:38 +0000 Received: by outflank-mailman (input) for mailman id 447736; Wed, 23 Nov 2022 22:25:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oxyBV-0003ZB-PC for xen-devel@lists.xenproject.org; Wed, 23 Nov 2022 22:25:37 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be43bc55-6b7d-11ed-8fd2-01056ac49cbb; Wed, 23 Nov 2022 23:25:34 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be43bc55-6b7d-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669242334; h=from:to:cc:subject:date:message-id:mime-version; bh=ss1D4ingsK86pl+VHuAvo8YZPZvL2G85Rxu9B0/DrhI=; b=DzH5TA7x0x6i5kKGhEZWxjQGQT50DnWt/xswhUgcEclt/AjU6CLC9CTu r5TYbf23UUs4fGfuPf7usi5JJ66PwRF1ZvQZfmInOftvPQppBmvmrVHoD j9mCx6T4cRZnJnbVTX7CNklR/aapSQNi+o9q8Kdah3fC0a4G8YHFENJ3n Y=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 87991771 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:yQxpZKkO2FyqLJGAzT2usY3o5gziJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIXWmqAOKncMGb3Lt0ga4u3/ElUvJeDzNBgSQc4/y4xFyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5gSGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 dsVDh0SdxGqvMez/ILqa7hDiNgyAeC+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsfYT/7C7pn9AusrlD5fydVtxS+oq0v7nKI5AdwzKLsIJzefdniqcB9zhnJ9 zuZoD2R7hcyF+zB5Cqf+2CQlMjsliD9aIM2DYyWz6s/6LGU7jNKU0BHPbehmtG1g1Czc8hSI EsV/mwpt6da3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQA5oiVpMYJ88pVsHHpzi wHPz4iB6SFTXKO9bn+726iNrBqJHC0pHT4jNAAKURooyoy2yG0stS7nQtFmGa+zq9T6HzDs3 jyHxBQDa6UvYd0jjPviow2e6964jt2QF1NuuF2LNo6wxlkhDLNJcbBE/rQyARxoCI+CBmeMs 3Ef8yR1xLBfVMrd/MBhrQhkIV1I2xpnGGeE6bKMN8N7n9hIx0NPhagKvFlDyL5Ba67puVbBO Sc/Qz956p5JJ2eNZqRqeY+3AMlC5fG+S4W/DKCIPooVOMAZmOq7EMZGPB744owQuBJ0zfFX1 WmzL65A8kr2+Yw4lWHrFo/xIJcgxzwkxHO7eHwI503P7FdfDVbLIYo43KymNLpmtvPd+F2Nm zudXuPToyhivCTFSnG/2eYuwZoidxDX2bieRxRrS9O+ IronPort-HdrOrdr: A9a23:zOFf/KvkWEaXFsm62Gi8xp4w7skDYtV00zEX/kB9WHVpmszxra +TdZUgpHvJYVkqOU3I9ersBEDiewK4yXcW2+ks1N6ZNWGM0ldARLsSj7cKqAePJ8SRzIJgPN 9bAstDNOE= X-IronPort-AV: E=Sophos;i="5.96,187,1665460800"; d="scan'208";a="87991771" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Christian Lindig , David Scott , Edwin Torok , Rob Hoes Subject: [PATCH] tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free Date: Wed, 23 Nov 2022 22:25:17 +0000 Message-ID: <20221123222517.12140-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain The binding for xc_interface_close() free the underlying handle while leaving the Ocaml object still in scope and usable. This would make it easy to suffer a use-after-free, if it weren't for the fact that the typical usage is as a singleton that lives for the lifetime of the program. Ocaml 5 no longer permits storing a naked C pointer in an Ocaml value. Therefore, use a Custom block. This allows us to use the finaliser callback to call xc_interface_close(), if the Ocaml object goes out of scope. Signed-off-by: Andrew Cooper --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes I've confirmed that Xenctrl.close_handle does cause the finaliser to be called, simply by dropping the handle reference. --- tools/ocaml/libs/xc/xenctrl.ml | 3 +-- tools/ocaml/libs/xc/xenctrl.mli | 1 - tools/ocaml/libs/xc/xenctrl_stubs.c | 43 ++++++++++++++++++++++--------------- 3 files changed, 27 insertions(+), 20 deletions(-) diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index aa650533f718..4b74e31c75cb 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -175,7 +175,6 @@ exception Error of string type handle external interface_open: unit -> handle = "stub_xc_interface_open" -external interface_close: handle -> unit = "stub_xc_interface_close" let handle = ref None @@ -183,7 +182,7 @@ let get_handle () = !handle let close_handle () = match !handle with - | Some h -> handle := None; interface_close h + | Some h -> handle := None | None -> () let with_intf f = diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index 5bf5f5dfea36..ddfe84dc22a9 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -146,7 +146,6 @@ type shutdown_reason = Poweroff | Reboot | Suspend | Crash | Watchdog | Soft_res exception Error of string type handle external interface_open : unit -> handle = "stub_xc_interface_open" -external interface_close : handle -> unit = "stub_xc_interface_close" (** [with_intf f] runs [f] with a global handle that is opened on demand * and kept open. Conceptually, a client should use either diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index f37848ae0bb3..4e1204085422 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -37,13 +37,28 @@ #include "mmap_stubs.h" -#define _H(__h) ((xc_interface *)(__h)) +#define _H(__h) (*((xc_interface **)Data_custom_val(__h))) #define _D(__d) ((uint32_t)Int_val(__d)) #ifndef Val_none #define Val_none (Val_int(0)) #endif +static void stub_xenctrl_finalize(value v) +{ + xc_interface_close(_H(v)); +} + +static struct custom_operations xenctrl_ops = { + .identifier = "xenctrl", + .finalize = stub_xenctrl_finalize, + .compare = custom_compare_default, /* Can't compare */ + .hash = custom_hash_default, /* Can't hash */ + .serialize = custom_serialize_default, /* Can't serialize */ + .deserialize = custom_deserialize_default, /* Can't deserialize */ + .compare_ext = custom_compare_ext_default, /* Can't compare */ +}; + #define string_of_option_array(array, index) \ ((Field(array, index) == Val_none) ? NULL : String_val(Field(Field(array, index), 0))) @@ -70,26 +85,20 @@ static void Noreturn failwith_xc(xc_interface *xch) CAMLprim value stub_xc_interface_open(void) { CAMLparam0(); - xc_interface *xch; - - /* Don't assert XC_OPENFLAG_NON_REENTRANT because these bindings - * do not prevent re-entrancy to libxc */ - xch = xc_interface_open(NULL, NULL, 0); - if (xch == NULL) - failwith_xc(NULL); - CAMLreturn((value)xch); -} - - -CAMLprim value stub_xc_interface_close(value xch) -{ - CAMLparam1(xch); + CAMLlocal1(result); + xc_interface *xch; caml_enter_blocking_section(); - xc_interface_close(_H(xch)); + xch = xc_interface_open(NULL, NULL, 0); caml_leave_blocking_section(); - CAMLreturn(Val_unit); + if ( !xch ) + failwith_xc(xch); + + result = caml_alloc_custom(&xenctrl_ops, sizeof(xch), 0, 1); + _H(result) = xch; + + CAMLreturn(result); } static void domain_handle_of_uuid_string(xen_domain_handle_t h, -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Nov 24 02:39:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 02:39:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447742.704315 (Exim 4.92) (envelope-from ) id 1oy29P-00050T-10; Thu, 24 Nov 2022 02:39:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447742.704315; Thu, 24 Nov 2022 02:39:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy29O-00050L-Ru; Thu, 24 Nov 2022 02:39:42 +0000 Received: by outflank-mailman (input) for mailman id 447742; Thu, 24 Nov 2022 02:39:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy29N-00050F-9R for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 02:39:41 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d1d5e6e-6ba1-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 03:39:39 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5D5EA61FC3; Thu, 24 Nov 2022 02:39:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54220C433C1; Thu, 24 Nov 2022 02:39:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d1d5e6e-6ba1-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669257576; bh=v/MVsTswqTV6pYQHqN9mCNsFiduQhw05EJKbm6J8B9Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dqnAV5JxjBhMTnqY+nsEdkJAdIqMvZR6VuuOrh2h8I9tTjoLWtiHgBBOY2p/LTeO5 3YNbf4WRvW0FihD+OMLoGtrv+IGs1wE9PkexlM6ybOshYiULCYuLx+FuabWE0Qn2VR tsZTzMZFV7QQGp3alstflhnff41Gqilqe4MxebM3kFf1PwF1ILeZMwVv1V3zrf1hBn yEpi21i7a8rhnjF21bqIGrM/b2+T1HTYE7U5KMWUw25bH9izmkcy2yVOVUenrEXXpL 6zOCT7RrE95YnQ7bEHjtOLm2IfSv2A+USxLAuH4UPXotiUB7Tm9MdiiIcF+nqu9aeR oJ9CfKu49phXA== Date: Wed, 23 Nov 2022 18:39:34 -0800 From: Josh Poimboeuf To: Andrew Cooper Cc: Peter Zijlstra , "Paul E. McKenney" , "sfr@canb.auug.org.au" , "linux-kernel@vger.kernel.org" , "jgross@suse.com" , "sstabellini@kernel.org" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , Thomas Gleixner Subject: Re: objtool warning for next-20221118 Message-ID: <20221124023934.nft3udxelth4lvai@treble> References: <20221121040736.GA3738360@paulmck-ThinkPad-P17-Gen-1> <20221121145215.GF4001@paulmck-ThinkPad-P17-Gen-1> <20221122051605.4hcbslwxez2trdvt@treble> <20221123012350.kelmmadh65lyswqz@treble> <2255c45f-d8ba-3f32-9d99-737ad3040dd7@citrix.com> <20221123170337.keacggyvn4ykbtsw@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221123170337.keacggyvn4ykbtsw@treble> On Wed, Nov 23, 2022 at 09:03:40AM -0800, Josh Poimboeuf wrote: > On Wed, Nov 23, 2022 at 10:52:09AM +0000, Andrew Cooper wrote: > > > Well, if you return from arch_cpu_idle_dead() you're back in the idle > > > loop -- exactly where you would be if you were to bootstrap the whole > > > CPU -- provided you have it remember the whole state (easier with a > > > vCPU). > > play_dead() really needs sane semantics. Not only does it introduce a > surprise to the offlining code in do_idle(), it also skips the entire > hotplug state machine. Not sure if that introduces any bugs, but at the > very least it's subtle and surprising. > > > > But maybe I'm missing something, lets add Xen folks on. > > > > Calling VCPUOP_down on oneself always succeeds, but all it does is > > deschedule the vCPU. > > > > It can be undone at a later point by a different vcpu issuing VCPUOP_up > > against the previously-downed CPU, at which point the vCPU gets rescheduled. > > > > This is why the VCPUOP_down hypercall returns normally.  All state > > really is intact. > > > > As for what Linux does, this is how xen_pv_cpu_up() currently behaves.  > > If you want to make Xen behave more everything else, then bug a BUG() > > after VCPUOP_down, and adjust xen_pv_cpu_up() to skip its initialised > > check and always use VCPUOP_initialise to bring the vCPU back online. > > Or we could do what sev_es_play_dead() does and just call start_cpu0() > after the hypercall returns? Something like so (untested). This is only the x86 bits. I think I convinced myself that start_cpu0() isn't buggy. I'm looking at other cleanups, e.g. converging cpu_bringup_and_idle() with start_secondary(). I can pick it up again next week, post-turkey. diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h index b4dbb20dab1a..e6d1d2810e38 100644 --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -93,9 +93,10 @@ static inline void __cpu_die(unsigned int cpu) smp_ops.cpu_die(cpu); } -static inline void play_dead(void) +static inline void __noreturn play_dead(void) { smp_ops.play_dead(); + BUG(); } static inline void smp_send_reschedule(int cpu) diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 26e8f57c75ad..8e2841deb1eb 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -700,7 +700,7 @@ EXPORT_SYMBOL(boot_option_idle_override); static void (*x86_idle)(void); #ifndef CONFIG_SMP -static inline void play_dead(void) +static inline void __noreturn play_dead(void) { BUG(); } diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 55cad72715d9..d8b12ac1a7c5 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1833,9 +1833,12 @@ void native_play_dead(void) play_dead_common(); tboot_shutdown(TB_SHUTDOWN_WFS); - mwait_play_dead(); /* Only returns on failure */ + mwait_play_dead(); /* Only returns if mwait is not supported */ + if (cpuidle_play_dead()) hlt_play_dead(); + + BUG(); } #else /* ... !CONFIG_HOTPLUG_CPU */ diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c index 480be82e9b7b..30dc904ca990 100644 --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -385,17 +385,9 @@ static void xen_pv_play_dead(void) /* used only with HOTPLUG_CPU */ { play_dead_common(); HYPERVISOR_vcpu_op(VCPUOP_down, xen_vcpu_nr(smp_processor_id()), NULL); - cpu_bringup(); - /* - * commit 4b0c0f294 (tick: Cleanup NOHZ per cpu data on cpu down) - * clears certain data that the cpu_idle loop (which called us - * and that we return from) expects. The only way to get that - * data back is to call: - */ - tick_nohz_idle_enter(); - tick_nohz_idle_stop_tick_protected(); - cpuhp_online_idle(CPUHP_AP_ONLINE_IDLE); + /* FIXME: converge cpu_bringup_and_idle() and start_secondary() */ + cpu_bringup_and_idle(); } #else /* !CONFIG_HOTPLUG_CPU */ diff --git a/include/linux/cpu.h b/include/linux/cpu.h index 314802f98b9d..7fbbd1572288 100644 --- a/include/linux/cpu.h +++ b/include/linux/cpu.h @@ -185,7 +185,7 @@ void arch_cpu_idle(void); void arch_cpu_idle_prepare(void); void arch_cpu_idle_enter(void); void arch_cpu_idle_exit(void); -void arch_cpu_idle_dead(void); +void __noreturn arch_cpu_idle_dead(void); int cpu_report_state(int cpu); int cpu_check_up_prepare(int cpu); diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c index f26ab2675f7d..097afe98e53e 100644 --- a/kernel/sched/idle.c +++ b/kernel/sched/idle.c @@ -71,7 +71,7 @@ static noinline int __cpuidle cpu_idle_poll(void) void __weak arch_cpu_idle_prepare(void) { } void __weak arch_cpu_idle_enter(void) { } void __weak arch_cpu_idle_exit(void) { } -void __weak arch_cpu_idle_dead(void) { } +void __weak __noreturn arch_cpu_idle_dead(void) { BUG(); } void __weak arch_cpu_idle(void) { cpu_idle_force_poll = 1; From xen-devel-bounces@lists.xenproject.org Thu Nov 24 02:50:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 02:50:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447747.704337 (Exim 4.92) (envelope-from ) id 1oy2KH-0007tn-5J; Thu, 24 Nov 2022 02:50:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447747.704337; Thu, 24 Nov 2022 02:50:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy2KH-0007td-2J; Thu, 24 Nov 2022 02:50:57 +0000 Received: by outflank-mailman (input) for mailman id 447747; Thu, 24 Nov 2022 02:50:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy2KG-0007dj-5y for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 02:50:56 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id d0afac72-6ba2-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 03:50:55 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EBE8823A; Wed, 23 Nov 2022 18:51:00 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 193623F587; Wed, 23 Nov 2022 18:50:50 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0afac72-6ba2-11ed-91b6-6bf2151ebd3b From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Andrew Cooper , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Community Manager , Julien Grall Subject: [PATCH v5 1/3] CHANGELOG: Add missing entries for work during the 4.17 release Date: Thu, 24 Nov 2022 10:50:39 +0800 Message-Id: <20221124025041.1540079-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221124025041.1540079-1-Henry.Wang@arm.com> References: <20221124025041.1540079-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Henry Wang Reviewed-by: Julien Grall --- v4 -> v5: - Add gitlab CI improvement following Michal's suggestion. - Add Julien's reviewed-by. v3 -> v4: - Use the corrected sentence for VIRT_SSBD and MSR_SPEC_CTRL - Clarify that the virtio-mmio toolstack for ARM is only creating the device-tree binding. - Remove the "initial" in i.MX entry. v2 -> v3: - Move the uncertain release date to patch #3. v1 -> v2: - Correct wording for two x86 entries (clock frequency calibration and SPR & ADL support) following Jan's suggestion. - Add missing Arm entries from Oleksandr. - Add missing i.MX entry following Stefano's suggestion. --- CHANGELOG.md | 32 ++++++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index adbbb216fa..55dd535e29 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,16 +4,44 @@ Notable changes to Xen will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) -## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD +## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) ### Changed - On x86 "vga=current" can now be used together with GrUB2's gfxpayload setting. Note that this requires use of "multiboot2" (and "module2") as the GrUB commands loading Xen. + - The "gnttab" option now has a new command line sub-option for disabling the + GNTTABOP_transfer functionality. + - The x86 MCE command line option info is now updated. ### Added / support upgraded + - Out-of-tree builds for the hypervisor now supported. + - The project has officially adopted 4 directives and 24 rules of MISRA-C, + added MISRA-C checker build integration, and defined how to document + deviations. - IOMMU superpage support on x86, affecting PV guests as well as HVM/PVH ones when they don't share page tables with the CPU (HAP / EPT / NPT). - - Support VIRT_SSBD feature for HVM guests on AMD. + - Support for VIRT_SSBD and MSR_SPEC_CTRL for HVM guests on AMD. + - Improved TSC, CPU, and APIC clock frequency calibration on x86. + - Add mwait-idle support for SPR and ADL on x86. + - Extend security support for hosts to 12 TiB of memory on x86. + - Add command line option to set cpuid parameters for dom0 at boot time on x86. + - Improved static configuration options on Arm. + - cpupools can be specified at boot using device tree on Arm. + - It is possible to use PV drivers with dom0less guests, allowing statically + booted dom0less guests with PV devices. + - On Arm, p2m structures are now allocated out of a pool of memory set aside at + domain creation. + - Improved mitigations against Spectre-BHB on Arm. + - Support VirtIO-MMIO devices device-tree binding creation in toolstack on Arm. + - Allow setting the number of CPUs to activate at runtime from command line + option on Arm. + - Grant-table support on Arm was improved and hardened by implementing + "simplified M2P-like approach for the xenheap pages" + - Add Renesas R-Car Gen4 IPMMU-VMSA support on Arm. + - Add i.MX lpuart and i.MX8QM support on Arm. + - Improved toolstack build system. + - Add Xue - console over USB 3 Debug Capability. + - gitlab-ci automation: Fixes and improvements together with new tests. ### Removed / support downgraded - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 24 02:50:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 02:50:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447746.704326 (Exim 4.92) (envelope-from ) id 1oy2KD-0007dw-Vq; Thu, 24 Nov 2022 02:50:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447746.704326; Thu, 24 Nov 2022 02:50:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy2KD-0007dp-Rs; Thu, 24 Nov 2022 02:50:53 +0000 Received: by outflank-mailman (input) for mailman id 447746; Thu, 24 Nov 2022 02:50:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy2KD-0007dj-11 for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 02:50:53 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ce0fb264-6ba2-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 03:50:50 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 822931FB; Wed, 23 Nov 2022 18:50:56 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 281ED3F587; Wed, 23 Nov 2022 18:50:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce0fb264-6ba2-11ed-91b6-6bf2151ebd3b From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Andrew Cooper , Stefano Stabellini , Julien Grall , Bertrand Marquis , Community Manager Subject: [PATCH v5 0/3] Populate entries for 4.17 Date: Thu, 24 Nov 2022 10:50:38 +0800 Message-Id: <20221124025041.1540079-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hello, The following changes are preparation work for the 4.17 release. Also collecting the changelog changes happened during the 4.17 dev phase. This is my first pass at the log for the release, it's likely missing more entries. Thanks, Henry v4 -> v5: - Add gitlab CI improvement following Michal's suggestion. - Add Julien's reviewed-by. v3 -> v4: - Use the corrected sentence for VIRT_SSBD and MSR_SPEC_CTRL - Clarify that the virtio-mmio toolstack for ARM is only creating the device-tree binding. - Remove the "initial" in i.MX entry. - Add my own sign-off in patch #2 because I changed the original wording. v2 -> v3: - Move the uncertain release date to patch #3. - Remove the "on x86" for __ro_after_init, as Arm also supports the __ro_after_init. - Take the opportunity in patch #3 to also adjust the 4.17 entry since this patch will be applied only after branching. v1 -> v2: - Pick other changelog patches happened during the 4.17 dev phase. - Correct wording for two x86 entries (clock frequency calibration and SPR & ADL support) following Jan's suggestion. - Add missing Arm entries from Oleksandr. - Add missing i.MX entry following Stefano's suggestion. Andrew Cooper (1): Changelog: Add __ro_after_init and CET Henry Wang (2): CHANGELOG: Add missing entries for work during the 4.17 release CHANGELOG: Start new "unstable" section CHANGELOG.md | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 24 02:51:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 02:51:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447748.704348 (Exim 4.92) (envelope-from ) id 1oy2KL-0008Cd-Ci; Thu, 24 Nov 2022 02:51:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447748.704348; Thu, 24 Nov 2022 02:51:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy2KL-0008CW-9R; Thu, 24 Nov 2022 02:51:01 +0000 Received: by outflank-mailman (input) for mailman id 447748; Thu, 24 Nov 2022 02:51:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy2KJ-0008Ay-Va for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 02:50:59 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d2792a7a-6ba2-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 03:50:58 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 968861FB; Wed, 23 Nov 2022 18:51:04 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 812673F587; Wed, 23 Nov 2022 18:50:55 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2792a7a-6ba2-11ed-8fd2-01056ac49cbb From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Henry Wang , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Julien Grall , Community Manager , Julien Grall Subject: [PATCH v5 2/3] Changelog: Add __ro_after_init and CET Date: Thu, 24 Nov 2022 10:50:40 +0800 Message-Id: <20221124025041.1540079-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221124025041.1540079-1-Henry.Wang@arm.com> References: <20221124025041.1540079-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Andrew Cooper Signed-off-by: Andrew Cooper Signed-off-by: Henry Wang Reviewed-by: Roger Pau Monné Reviewed-by: Julien Grall --- v4 -> v5: - Add Julien's reviewed-by. v3 -> v4: - Add my own sign-off because I changed the original wording. v2 -> v3: - Remove the "on x86" for __ro_after_init, as Arm also supports the __ro_after_init. v1 -> v2: - Include this patch in the series --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 55dd535e29..5d686a4258 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ### Added / support upgraded - Out-of-tree builds for the hypervisor now supported. + - __ro_after_init support, for marking data as immutable after boot. - The project has officially adopted 4 directives and 24 rules of MISRA-C, added MISRA-C checker build integration, and defined how to document deviations. @@ -22,6 +23,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) when they don't share page tables with the CPU (HAP / EPT / NPT). - Support for VIRT_SSBD and MSR_SPEC_CTRL for HVM guests on AMD. - Improved TSC, CPU, and APIC clock frequency calibration on x86. + - Support for Xen using x86 Control Flow Enforcement technology for its own + protection. Both Shadow Stacks (ROP protection) and Indirect Branch + Tracking (COP/JOP protection). - Add mwait-idle support for SPR and ADL on x86. - Extend security support for hosts to 12 TiB of memory on x86. - Add command line option to set cpuid parameters for dom0 at boot time on x86. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 24 02:51:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 02:51:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447749.704359 (Exim 4.92) (envelope-from ) id 1oy2KO-0008VX-QH; Thu, 24 Nov 2022 02:51:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447749.704359; Thu, 24 Nov 2022 02:51:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy2KO-0008VO-Lr; Thu, 24 Nov 2022 02:51:04 +0000 Received: by outflank-mailman (input) for mailman id 447749; Thu, 24 Nov 2022 02:51:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy2KN-0007dj-5c for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 02:51:03 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id d4f59c5e-6ba2-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 03:51:02 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0CCAF23A; Wed, 23 Nov 2022 18:51:08 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2C3C73F587; Wed, 23 Nov 2022 18:50:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4f59c5e-6ba2-11ed-91b6-6bf2151ebd3b From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Julien Grall , Jan Beulich , George Dunlap , Community Manager , Julien Grall Subject: [PATCH v5 3/3] CHANGELOG: Start new "unstable" section Date: Thu, 24 Nov 2022 10:50:41 +0800 Message-Id: <20221124025041.1540079-4-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221124025041.1540079-1-Henry.Wang@arm.com> References: <20221124025041.1540079-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Henry Wang Reviewed-by: Julien Grall --- v4 -> v5: - Add Julien's Reviewed-by. v3 -> v4: - No change. v2 -> v3: - Take the opportunity to also adjust the 4.17 entry since this patch will be applied only after branching. - Add 4.17 release date. - Drop Julien's acked-by because of the content change. v1 -> v2: - Add Julien's Acked-by. --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5d686a4258..c2bf26d524 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,9 @@ Notable changes to Xen will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) -## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) +## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD + +## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.17.0) - 2022-12-?? ### Changed - On x86 "vga=current" can now be used together with GrUB2's gfxpayload setting. Note that -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 24 03:57:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 03:57:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447767.704370 (Exim 4.92) (envelope-from ) id 1oy3Ml-00085Q-L0; Thu, 24 Nov 2022 03:57:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447767.704370; Thu, 24 Nov 2022 03:57:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy3Ml-00085J-I6; Thu, 24 Nov 2022 03:57:35 +0000 Received: by outflank-mailman (input) for mailman id 447767; Thu, 24 Nov 2022 03:57:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy3Mk-000859-J7; Thu, 24 Nov 2022 03:57:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy3Mk-0007d8-Gc; Thu, 24 Nov 2022 03:57:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy3Mj-0007f4-Vc; Thu, 24 Nov 2022 03:57:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oy3Mj-00023C-Te; Thu, 24 Nov 2022 03:57:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tcpCWxzbz72b2OZvhjRE9zfd704YDmklXyqhmf5cYmc=; b=xmmkcld2VDXKmzyran71MpLFZG EARC9pLNNWoXRCvwMVaefAx22JwVbrZsypE2lza0qufWv3x8zYI0ZI1v4UxbO6U/g0FXH2PobP5WP eMGX4CFosqsKtiFcxoR/gyezb22e2Lrus88ZgoxCT/aYKP9uqdI5fTp+kDS5uqJUXPIQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174948: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4312098baf37ee17a8350725e6e0d0e8590252d4 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 24 Nov 2022 03:57:33 +0000 flight 174948 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174948/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux 4312098baf37ee17a8350725e6e0d0e8590252d4 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 47 days Failing since 173470 2022-10-08 06:21:34 Z 46 days 85 attempts Testing same since 174948 2022-11-23 19:40:21 Z 0 days 1 attempts ------------------------------------------------------------ 1806 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 171821 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Nov 24 05:15:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 05:15:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447773.704381 (Exim 4.92) (envelope-from ) id 1oy4a6-0000yH-E4; Thu, 24 Nov 2022 05:15:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447773.704381; Thu, 24 Nov 2022 05:15:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy4a6-0000yA-Az; Thu, 24 Nov 2022 05:15:26 +0000 Received: by outflank-mailman (input) for mailman id 447773; Thu, 24 Nov 2022 05:15:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy4a5-0000y4-43 for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 05:15:25 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fe37c887-6bb6-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 06:15:22 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D35A35C00D5; Thu, 24 Nov 2022 00:15:20 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 24 Nov 2022 00:15:20 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Nov 2022 00:15:19 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe37c887-6bb6-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1669266920; x= 1669353320; bh=N4mgkDJMuEsjYD95MYifdN6mbV2R36yGwgOo4yfvF8c=; b=h Fb2rB0XQXk7qVIZmRjy+ZMZhpyAT5BMXgH29GTb17HYvjOekAik8oZQniM/fdIdO /Kf6FyTj7auQQP+nPDv3dl0OlCYgsrz8gq2tbI4Qf2BwnUj7PB2tIZutBq10SiQX msDUFFhyhNi8ugI+3c0BvOrxAv9lv8wdFgb6sOtrtM5zM4pSXbeAFqPVpbUhWWOC v9wD5a/QBBU3Hn5GLjnZTZ/ynBFslj1nfIE6DUtAkrbqe1PUH5fMDSoVPEvpWqks 9eR95CCaPpxlvlBb4yIo4caC74cW/1Few8DfAai4UIKui8HnoEs9AQqWTY1La5A7 jgUzPpAbLqJm2lgocx8Ow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1669266920; x=1669353320; bh=N4mgkDJMuEsjYD95MYifdN6mbV2R 36yGwgOo4yfvF8c=; b=dPeZ/mlY4OrUZPKsl2VqL2+xzZJ4OWRg1MGO0h9pR+Je ZhYq2Enz1fTOYgKQreVTMsfKV1SyhuuTRdLmAttfC2i8uCuGQUlVS5fW9lfLv9OX bEgz61Rt31/qQku9zo/7SQHpSSC+/4WF7mbFB8l0/p050KixtFEkvLUT3yuPaM6t JQSb8qJPYXGrpw6AsZtvlnkqsIssm8dTP5hcEFXavPsnZLIhFGUElKOJxLeTkOZf 4BKteIWD3OFmtLcaIoWY2rZtszWazdbCSahfduZoe+bfRmjo48zyGVOeuJ/+xGR2 UFD9n8Ll/ooUV2Kf9QlsCPnm8ChRcj4G494lqQIm/Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedriedvgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefhffff iefhgffgvddtledukeelteeiiefggeeftdfgvefgiefgjeeljefgleeigfenucffohhmrg hinheptghithhrihigrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 24 Nov 2022 06:15:15 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: Re: [PATCH 0/5] gfx: improvements when using multiboot2 and EFI + misc Message-ID: References: <20221123154525.63068-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uzfpZsZBiGb3GVj9" Content-Disposition: inline In-Reply-To: <20221123154525.63068-1-roger.pau@citrix.com> --uzfpZsZBiGb3GVj9 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 24 Nov 2022 06:15:15 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: Re: [PATCH 0/5] gfx: improvements when using multiboot2 and EFI + misc On Wed, Nov 23, 2022 at 04:45:19PM +0100, Roger Pau Monne wrote: > Marek: after this series using console=3D without the vga option should > result in Xen not attempting to touch the selected GOP mode and the > screen not getting cleared. Thanks, this seems to work mostly fine. There is one message printed from setup_efi_pci(): ... ROM ... bytes at ... I'm not sure what to do about this one (although for Qubes, I can simply patch it out ;) ). But to get dom0 display image from BGRT, it seems something else is needed too. Linux complains "Incorrect checksum in table [BGRT]". The only relevant google result I get is this: https://support.citrix.com/artic= le/CTX460227/citrix-hypervisor-acpi-warning-incorrect-checksum-in-table-bgrt It blames firmware. But then, it's suspicious that it's also about Xen. And also, native Linux on the same hw does not complain about the checksum. So, I think it's rather Xen to blame... The table lives in area marked as EfiACPIReclaimMemory in memory map, so I think it shouldn't be clobbered by Xen, at least in theory. I'll look into it later. It's getting off-topic for this thread anyway. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --uzfpZsZBiGb3GVj9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN+/eMACgkQ24/THMrX 1yymDwf9HEWHg0V/rEgq5bRglQHh22n0dIjzKO4m1YWL9zIeNhhR9Cd2BXrSwaDb tvCZw4i75mCZ6WkJs6aLZCWbf4YU51QvDQf2AlUmab2kMpT5Cns9+0bIEgkVRPHf z0FlNoZ9beAGEbD029ZmuKw9eGKakgD/Jpl5iH0CaniOEnHqQLl9daBMZ96FTKXv A+Fcj3bX+Rj5l7JG63pITF38B9KRL15bR/d195bRwiNe91R7zsXd6JRDIwGOptmF nr0GiP/X5Nfy0yMlU+oI47KoJD6ON5kOCOgA/Z1+aqOiYN2Gti2y2lY0VuBDgmuX DKfxvzzMsNQjujHPabzXHUh85vQffg== =SWfF -----END PGP SIGNATURE----- --uzfpZsZBiGb3GVj9-- From xen-devel-bounces@lists.xenproject.org Thu Nov 24 05:28:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 05:28:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447778.704392 (Exim 4.92) (envelope-from ) id 1oy4mp-0002dR-Gt; Thu, 24 Nov 2022 05:28:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447778.704392; Thu, 24 Nov 2022 05:28:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy4mp-0002dK-EF; Thu, 24 Nov 2022 05:28:35 +0000 Received: by outflank-mailman (input) for mailman id 447778; Thu, 24 Nov 2022 05:28:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy4mn-0002dE-JW for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 05:28:33 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d56e4107-6bb8-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 06:28:32 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 702EF1F8C3; Thu, 24 Nov 2022 05:28:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 236D213A8C; Thu, 24 Nov 2022 05:28:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2XE6B/8Af2MQHQAAMHmgww (envelope-from ); Thu, 24 Nov 2022 05:28:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d56e4107-6bb8-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669267711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GHC3QMVP2dsqBrw+ffIbZT5m5877WUh37XjX0QWQ5ak=; b=rO+c9lmCpMOtGtw+7P0W46Re0QQROu30ukdbJCu9QWj92N2f1wqh9tqm4vPWCqPd0XM05n od7qh9g0hr3vuAoWUwbauto9ZI+1eOa7AdEoby/aqwrSAGB4+LEPoVSqznpp1zdXynfymx bndPhxCnaLPWFSh17P+TRTDPKp3UzWE= Message-ID: <72a4871b-3ee8-42c1-912a-321a45690428@suse.com> Date: Thu, 24 Nov 2022 06:28:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: objtool warning for next-20221118 Content-Language: en-US To: Josh Poimboeuf , Andrew Cooper Cc: Peter Zijlstra , "Paul E. McKenney" , "sfr@canb.auug.org.au" , "linux-kernel@vger.kernel.org" , "sstabellini@kernel.org" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , Thomas Gleixner References: <20221121040736.GA3738360@paulmck-ThinkPad-P17-Gen-1> <20221121145215.GF4001@paulmck-ThinkPad-P17-Gen-1> <20221122051605.4hcbslwxez2trdvt@treble> <20221123012350.kelmmadh65lyswqz@treble> <2255c45f-d8ba-3f32-9d99-737ad3040dd7@citrix.com> <20221123170337.keacggyvn4ykbtsw@treble> <20221124023934.nft3udxelth4lvai@treble> From: Juergen Gross In-Reply-To: <20221124023934.nft3udxelth4lvai@treble> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------J91HyX3d0HxaiX4d5iHQildw" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------J91HyX3d0HxaiX4d5iHQildw Content-Type: multipart/mixed; boundary="------------Yb0O9WWgPtOpttubFCw3SqPU"; protected-headers="v1" From: Juergen Gross To: Josh Poimboeuf , Andrew Cooper Cc: Peter Zijlstra , "Paul E. McKenney" , "sfr@canb.auug.org.au" , "linux-kernel@vger.kernel.org" , "sstabellini@kernel.org" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , Thomas Gleixner Message-ID: <72a4871b-3ee8-42c1-912a-321a45690428@suse.com> Subject: Re: objtool warning for next-20221118 References: <20221121040736.GA3738360@paulmck-ThinkPad-P17-Gen-1> <20221121145215.GF4001@paulmck-ThinkPad-P17-Gen-1> <20221122051605.4hcbslwxez2trdvt@treble> <20221123012350.kelmmadh65lyswqz@treble> <2255c45f-d8ba-3f32-9d99-737ad3040dd7@citrix.com> <20221123170337.keacggyvn4ykbtsw@treble> <20221124023934.nft3udxelth4lvai@treble> In-Reply-To: <20221124023934.nft3udxelth4lvai@treble> --------------Yb0O9WWgPtOpttubFCw3SqPU Content-Type: multipart/mixed; boundary="------------m558gBsABmONjLYeX9VRc305" --------------m558gBsABmONjLYeX9VRc305 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjQuMTEuMjIgMDM6MzksIEpvc2ggUG9pbWJvZXVmIHdyb3RlOg0KPiBPbiBXZWQsIE5v diAyMywgMjAyMiBhdCAwOTowMzo0MEFNIC0wODAwLCBKb3NoIFBvaW1ib2V1ZiB3cm90ZToN Cj4+IE9uIFdlZCwgTm92IDIzLCAyMDIyIGF0IDEwOjUyOjA5QU0gKzAwMDAsIEFuZHJldyBD b29wZXIgd3JvdGU6DQo+Pj4+IFdlbGwsIGlmIHlvdSByZXR1cm4gZnJvbSBhcmNoX2NwdV9p ZGxlX2RlYWQoKSB5b3UncmUgYmFjayBpbiB0aGUgaWRsZQ0KPj4+PiBsb29wIC0tIGV4YWN0 bHkgd2hlcmUgeW91IHdvdWxkIGJlIGlmIHlvdSB3ZXJlIHRvIGJvb3RzdHJhcCB0aGUgd2hv bGUNCj4+Pj4gQ1BVIC0tIHByb3ZpZGVkIHlvdSBoYXZlIGl0IHJlbWVtYmVyIHRoZSB3aG9s ZSBzdGF0ZSAoZWFzaWVyIHdpdGggYQ0KPj4+PiB2Q1BVKS4NCj4+DQo+PiBwbGF5X2RlYWQo KSByZWFsbHkgbmVlZHMgc2FuZSBzZW1hbnRpY3MuICBOb3Qgb25seSBkb2VzIGl0IGludHJv ZHVjZSBhDQo+PiBzdXJwcmlzZSB0byB0aGUgb2ZmbGluaW5nIGNvZGUgaW4gZG9faWRsZSgp LCBpdCBhbHNvIHNraXBzIHRoZSBlbnRpcmUNCj4+IGhvdHBsdWcgc3RhdGUgbWFjaGluZS4g IE5vdCBzdXJlIGlmIHRoYXQgaW50cm9kdWNlcyBhbnkgYnVncywgYnV0IGF0IHRoZQ0KPj4g dmVyeSBsZWFzdCBpdCdzIHN1YnRsZSBhbmQgc3VycHJpc2luZy4NCj4+DQo+Pj4+IEJ1dCBt YXliZSBJJ20gbWlzc2luZyBzb21ldGhpbmcsIGxldHMgYWRkIFhlbiBmb2xrcyBvbi4NCj4+ Pg0KPj4+IENhbGxpbmcgVkNQVU9QX2Rvd24gb24gb25lc2VsZiBhbHdheXMgc3VjY2VlZHMs IGJ1dCBhbGwgaXQgZG9lcyBpcw0KPj4+IGRlc2NoZWR1bGUgdGhlIHZDUFUuDQo+Pj4NCj4+ PiBJdCBjYW4gYmUgdW5kb25lIGF0IGEgbGF0ZXIgcG9pbnQgYnkgYSBkaWZmZXJlbnQgdmNw dSBpc3N1aW5nIFZDUFVPUF91cA0KPj4+IGFnYWluc3QgdGhlIHByZXZpb3VzbHktZG93bmVk IENQVSwgYXQgd2hpY2ggcG9pbnQgdGhlIHZDUFUgZ2V0cyByZXNjaGVkdWxlZC4NCj4+Pg0K Pj4+IFRoaXMgaXMgd2h5IHRoZSBWQ1BVT1BfZG93biBoeXBlcmNhbGwgcmV0dXJucyBub3Jt YWxseS7CoCBBbGwgc3RhdGUNCj4+PiByZWFsbHkgaXMgaW50YWN0Lg0KPj4+DQo+Pj4gQXMg Zm9yIHdoYXQgTGludXggZG9lcywgdGhpcyBpcyBob3cgeGVuX3B2X2NwdV91cCgpIGN1cnJl bnRseSBiZWhhdmVzLg0KPj4+IElmIHlvdSB3YW50IHRvIG1ha2UgWGVuIGJlaGF2ZSBtb3Jl IGV2ZXJ5dGhpbmcgZWxzZSwgdGhlbiBidWcgYSBCVUcoKQ0KPj4+IGFmdGVyIFZDUFVPUF9k b3duLCBhbmQgYWRqdXN0IHhlbl9wdl9jcHVfdXAoKSB0byBza2lwIGl0cyBpbml0aWFsaXNl ZA0KPj4+IGNoZWNrIGFuZCBhbHdheXMgdXNlIFZDUFVPUF9pbml0aWFsaXNlIHRvIGJyaW5n IHRoZSB2Q1BVIGJhY2sgb25saW5lLg0KPj4NCj4+IE9yIHdlIGNvdWxkIGRvIHdoYXQgc2V2 X2VzX3BsYXlfZGVhZCgpIGRvZXMgYW5kIGp1c3QgY2FsbCBzdGFydF9jcHUwKCkNCj4+IGFm dGVyIHRoZSBoeXBlcmNhbGwgcmV0dXJucz8NCj4gDQo+IFNvbWV0aGluZyBsaWtlIHNvICh1 bnRlc3RlZCkuICBUaGlzIGlzIG9ubHkgdGhlIHg4NiBiaXRzLg0KPiANCj4gSSB0aGluayBJ IGNvbnZpbmNlZCBteXNlbGYgdGhhdCBzdGFydF9jcHUwKCkgaXNuJ3QgYnVnZ3kuICBJJ20g bG9va2luZw0KPiBhdCBvdGhlciBjbGVhbnVwcywgZS5nLiBjb252ZXJnaW5nIGNwdV9icmlu Z3VwX2FuZF9pZGxlKCkgd2l0aA0KPiBzdGFydF9zZWNvbmRhcnkoKS4NCj4gDQo+IEkgY2Fu IHBpY2sgaXQgdXAgYWdhaW4gbmV4dCB3ZWVrLCBwb3N0LXR1cmtleS4NCj4gDQo+IGRpZmYg LS1naXQgYS9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9zbXAuaCBiL2FyY2gveDg2L2luY2x1ZGUv YXNtL3NtcC5oDQo+IGluZGV4IGI0ZGJiMjBkYWIxYS4uZTZkMWQyODEwZTM4IDEwMDY0NA0K PiAtLS0gYS9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9zbXAuaA0KPiArKysgYi9hcmNoL3g4Ni9p bmNsdWRlL2FzbS9zbXAuaA0KPiBAQCAtOTMsOSArOTMsMTAgQEAgc3RhdGljIGlubGluZSB2 b2lkIF9fY3B1X2RpZSh1bnNpZ25lZCBpbnQgY3B1KQ0KPiAgIAlzbXBfb3BzLmNwdV9kaWUo Y3B1KTsNCj4gICB9DQo+ICAgDQo+IC1zdGF0aWMgaW5saW5lIHZvaWQgcGxheV9kZWFkKHZv aWQpDQo+ICtzdGF0aWMgaW5saW5lIHZvaWQgX19ub3JldHVybiBwbGF5X2RlYWQodm9pZCkN Cj4gICB7DQo+ICAgCXNtcF9vcHMucGxheV9kZWFkKCk7DQo+ICsJQlVHKCk7DQo+ICAgfQ0K PiAgIA0KPiAgIHN0YXRpYyBpbmxpbmUgdm9pZCBzbXBfc2VuZF9yZXNjaGVkdWxlKGludCBj cHUpDQo+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni9rZXJuZWwvcHJvY2Vzcy5jIGIvYXJjaC94 ODYva2VybmVsL3Byb2Nlc3MuYw0KPiBpbmRleCAyNmU4ZjU3Yzc1YWQuLjhlMjg0MWRlYjFl YiAxMDA2NDQNCj4gLS0tIGEvYXJjaC94ODYva2VybmVsL3Byb2Nlc3MuYw0KPiArKysgYi9h cmNoL3g4Ni9rZXJuZWwvcHJvY2Vzcy5jDQo+IEBAIC03MDAsNyArNzAwLDcgQEAgRVhQT1JU X1NZTUJPTChib290X29wdGlvbl9pZGxlX292ZXJyaWRlKTsNCj4gICBzdGF0aWMgdm9pZCAo Kng4Nl9pZGxlKSh2b2lkKTsNCj4gICANCj4gICAjaWZuZGVmIENPTkZJR19TTVANCj4gLXN0 YXRpYyBpbmxpbmUgdm9pZCBwbGF5X2RlYWQodm9pZCkNCj4gK3N0YXRpYyBpbmxpbmUgdm9p ZCBfX25vcmV0dXJuIHBsYXlfZGVhZCh2b2lkKQ0KPiAgIHsNCj4gICAJQlVHKCk7DQo+ICAg fQ0KPiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYva2VybmVsL3NtcGJvb3QuYyBiL2FyY2gveDg2 L2tlcm5lbC9zbXBib290LmMNCj4gaW5kZXggNTVjYWQ3MjcxNWQ5Li5kOGIxMmFjMWE3YzUg MTAwNjQ0DQo+IC0tLSBhL2FyY2gveDg2L2tlcm5lbC9zbXBib290LmMNCj4gKysrIGIvYXJj aC94ODYva2VybmVsL3NtcGJvb3QuYw0KPiBAQCAtMTgzMyw5ICsxODMzLDEyIEBAIHZvaWQg bmF0aXZlX3BsYXlfZGVhZCh2b2lkKQ0KPiAgIAlwbGF5X2RlYWRfY29tbW9uKCk7DQo+ICAg CXRib290X3NodXRkb3duKFRCX1NIVVRET1dOX1dGUyk7DQo+ICAgDQo+IC0JbXdhaXRfcGxh eV9kZWFkKCk7CS8qIE9ubHkgcmV0dXJucyBvbiBmYWlsdXJlICovDQo+ICsJbXdhaXRfcGxh eV9kZWFkKCk7CS8qIE9ubHkgcmV0dXJucyBpZiBtd2FpdCBpcyBub3Qgc3VwcG9ydGVkICov DQo+ICsNCj4gICAJaWYgKGNwdWlkbGVfcGxheV9kZWFkKCkpDQo+ICAgCQlobHRfcGxheV9k ZWFkKCk7DQo+ICsNCj4gKwlCVUcoKTsNCj4gICB9DQo+ICAgDQo+ICAgI2Vsc2UgLyogLi4u ICFDT05GSUdfSE9UUExVR19DUFUgKi8NCj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L3hlbi9z bXBfcHYuYyBiL2FyY2gveDg2L3hlbi9zbXBfcHYuYw0KPiBpbmRleCA0ODBiZTgyZTliN2Iu LjMwZGM5MDRjYTk5MCAxMDA2NDQNCj4gLS0tIGEvYXJjaC94ODYveGVuL3NtcF9wdi5jDQo+ ICsrKyBiL2FyY2gveDg2L3hlbi9zbXBfcHYuYw0KPiBAQCAtMzg1LDE3ICszODUsOSBAQCBz dGF0aWMgdm9pZCB4ZW5fcHZfcGxheV9kZWFkKHZvaWQpIC8qIHVzZWQgb25seSB3aXRoIEhP VFBMVUdfQ1BVICovDQo+ICAgew0KPiAgIAlwbGF5X2RlYWRfY29tbW9uKCk7DQo+ICAgCUhZ UEVSVklTT1JfdmNwdV9vcChWQ1BVT1BfZG93biwgeGVuX3ZjcHVfbnIoc21wX3Byb2Nlc3Nv cl9pZCgpKSwgTlVMTCk7DQo+IC0JY3B1X2JyaW5ndXAoKTsNCj4gLQkvKg0KPiAtCSAqIGNv bW1pdCA0YjBjMGYyOTQgKHRpY2s6IENsZWFudXAgTk9IWiBwZXIgY3B1IGRhdGEgb24gY3B1 IGRvd24pDQo+IC0JICogY2xlYXJzIGNlcnRhaW4gZGF0YSB0aGF0IHRoZSBjcHVfaWRsZSBs b29wICh3aGljaCBjYWxsZWQgdXMNCj4gLQkgKiBhbmQgdGhhdCB3ZSByZXR1cm4gZnJvbSkg ZXhwZWN0cy4gVGhlIG9ubHkgd2F5IHRvIGdldCB0aGF0DQo+IC0JICogZGF0YSBiYWNrIGlz IHRvIGNhbGw6DQo+IC0JICovDQo+IC0JdGlja19ub2h6X2lkbGVfZW50ZXIoKTsNCj4gLQl0 aWNrX25vaHpfaWRsZV9zdG9wX3RpY2tfcHJvdGVjdGVkKCk7DQo+ICAgDQo+IC0JY3B1aHBf b25saW5lX2lkbGUoQ1BVSFBfQVBfT05MSU5FX0lETEUpOw0KPiArCS8qIEZJWE1FOiBjb252 ZXJnZSBjcHVfYnJpbmd1cF9hbmRfaWRsZSgpIGFuZCBzdGFydF9zZWNvbmRhcnkoKSAqLw0K PiArCWNwdV9icmluZ3VwX2FuZF9pZGxlKCk7DQoNCkkgdGhpbmsgdGhpcyB3aWxsIGxlYWsg c3RhY2sgbWVtb3J5LiBNdWx0aXBsZSBjcHUgb2ZmbGluZS9vbmxpbmUgY3ljbGVzIG9mDQp0 aGUgc2FtZSBjcHUgd2lsbCBmaW5hbGx5IGV4aGF1c3QgdGhlIGlkbGUgc3RhY2suDQoNCg0K SnVlcmdlbg0K --------------m558gBsABmONjLYeX9VRc305 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------m558gBsABmONjLYeX9VRc305-- --------------Yb0O9WWgPtOpttubFCw3SqPU-- --------------J91HyX3d0HxaiX4d5iHQildw Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmN/AP4FAwAAAAAACgkQsN6d1ii/Ey/Q Nwf/bg+mAIdFoOngfKVrRQ7DSFDPz0mee5UTbQaYVLGutmhqzXxx4Bp/F5AvVxVkFxSZ89cvja+9 M82mcK9UuA4fqtzoXwePbViczV2DFgbPAQppnYxhNcUjHk4k6Z3BAzW73lDFbcXyxt+BXbQ40dRk OyjvSvJlxg4gXdUXBDrq0SqG7PjGNANKmwckhWFSXeBYywb16AI/B8RjcKvUGoTDIolKzVaPzJge 9ZIOJ/cdWp0K3De/siTGfsw421vN+txLywhLOcLTaqkSNnqLyflC5SQH3airfZtTEWNec1Y4bSYf WSSvNjil0Db2D5aO0z270VKWIHXGPLwQE/AjTdp9Mw== =pgVv -----END PGP SIGNATURE----- --------------J91HyX3d0HxaiX4d5iHQildw-- From xen-devel-bounces@lists.xenproject.org Thu Nov 24 06:44:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 06:44:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447786.704403 (Exim 4.92) (envelope-from ) id 1oy5yD-0003XX-76; Thu, 24 Nov 2022 06:44:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447786.704403; Thu, 24 Nov 2022 06:44:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy5yD-0003XQ-4O; Thu, 24 Nov 2022 06:44:25 +0000 Received: by outflank-mailman (input) for mailman id 447786; Thu, 24 Nov 2022 06:44:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy5yB-0003XG-SB; Thu, 24 Nov 2022 06:44:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy5yB-0003Oe-Pc; Thu, 24 Nov 2022 06:44:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy5yB-0002N0-DL; Thu, 24 Nov 2022 06:44:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oy5yB-0006uT-B1; Thu, 24 Nov 2022 06:44:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RyMADgVo+NGThEdw4nC3Sor2BlGKsjogVn8UhesIENE=; b=W35Z54PzzOmMGADYt5PF69SE37 zxSLly3vNIfENUhUBzkqhnUv60M/WxxvK1OnLmLSN/e6eynGpuGfAU+9tfDi1Tj78V4mXy0udONvG Y8KB+mfsU3MATzXvsGqH8JW4rXxQNCyPE3dIUQRn+hpEOY09DTukABYxW4Umfn034vxM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174949: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-credit2:debian-fixup:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=a33c25399f9bc3dcf83064adeba2a82e61bf4608 X-Osstest-Versions-That: qemuu=7c09a7f6ae1770d15535980d15dffdb23f4d9786 From: osstest service owner Date: Thu, 24 Nov 2022 06:44:23 +0000 flight 174949 qemu-mainline real [real] flight 174953 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174949/ http://logs.test-lab.xenproject.org/osstest/logs/174953/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 13 debian-fixup fail pass in 174953-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 174953 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 174953 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174935 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174935 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174935 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174935 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174935 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174935 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174935 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174935 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu a33c25399f9bc3dcf83064adeba2a82e61bf4608 baseline version: qemuu 7c09a7f6ae1770d15535980d15dffdb23f4d9786 Last test of basis 174935 2022-11-23 03:11:34 Z 1 days Testing same since 174949 2022-11-23 22:10:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Claudio Fontana Dongwon Kim Gerd Hoffmann Joelle van Dyne Ján Tomko Michael Tokarev Peter Maydell Philippe Mathieu-Daudé Stefan Hajnoczi Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 7c09a7f6ae..a33c25399f a33c25399f9bc3dcf83064adeba2a82e61bf4608 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Nov 24 07:48:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 07:48:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447794.704413 (Exim 4.92) (envelope-from ) id 1oy6xd-0002IH-P1; Thu, 24 Nov 2022 07:47:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447794.704413; Thu, 24 Nov 2022 07:47:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy6xd-0002IA-Lg; Thu, 24 Nov 2022 07:47:53 +0000 Received: by outflank-mailman (input) for mailman id 447794; Thu, 24 Nov 2022 07:47:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy6xc-0002I4-1s for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 07:47:52 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a3758c3-6bcc-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 08:47:50 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CED84218B5; Thu, 24 Nov 2022 07:47:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 78DE613AC9; Thu, 24 Nov 2022 07:47:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Dp9wG6Mhf2OKVQAAMHmgww (envelope-from ); Thu, 24 Nov 2022 07:47:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a3758c3-6bcc-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669276067; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=07IDGF5XNYz6e2lhof5UOYSdrqi1+SlQuw31h3/bGvY=; b=hI+7oq1tJtgVOex9ofwvOQPQ1Sn8dbuWfvCQEkkpkYtx/CTfDNFW8SMNoFYWUtCz/c6C4l pmI5D3gG/+V9YjLK3+c0crpWkH6GiFqz8e9QjUa5CXJVeoUMEWjrKQGHeuP6nkrUGrvRvW QFxORetabqfFv52RS1jqlej4VlnGEjQ= Message-ID: <68dc479a-6b61-0012-888d-c1b4cc513cdb@suse.com> Date: Thu, 24 Nov 2022 08:47:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: objtool warning for next-20221118 Content-Language: en-US From: Juergen Gross To: Josh Poimboeuf , Andrew Cooper Cc: Peter Zijlstra , "Paul E. McKenney" , "sfr@canb.auug.org.au" , "linux-kernel@vger.kernel.org" , "sstabellini@kernel.org" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , Thomas Gleixner References: <20221121040736.GA3738360@paulmck-ThinkPad-P17-Gen-1> <20221121145215.GF4001@paulmck-ThinkPad-P17-Gen-1> <20221122051605.4hcbslwxez2trdvt@treble> <20221123012350.kelmmadh65lyswqz@treble> <2255c45f-d8ba-3f32-9d99-737ad3040dd7@citrix.com> <20221123170337.keacggyvn4ykbtsw@treble> <20221124023934.nft3udxelth4lvai@treble> <72a4871b-3ee8-42c1-912a-321a45690428@suse.com> In-Reply-To: <72a4871b-3ee8-42c1-912a-321a45690428@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------eljA8Dt0yylIHwiYAZnuZFCA" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------eljA8Dt0yylIHwiYAZnuZFCA Content-Type: multipart/mixed; boundary="------------0IclpDUqLeC6ZzwUmVegATIk"; protected-headers="v1" From: Juergen Gross To: Josh Poimboeuf , Andrew Cooper Cc: Peter Zijlstra , "Paul E. McKenney" , "sfr@canb.auug.org.au" , "linux-kernel@vger.kernel.org" , "sstabellini@kernel.org" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , Thomas Gleixner Message-ID: <68dc479a-6b61-0012-888d-c1b4cc513cdb@suse.com> Subject: Re: objtool warning for next-20221118 References: <20221121040736.GA3738360@paulmck-ThinkPad-P17-Gen-1> <20221121145215.GF4001@paulmck-ThinkPad-P17-Gen-1> <20221122051605.4hcbslwxez2trdvt@treble> <20221123012350.kelmmadh65lyswqz@treble> <2255c45f-d8ba-3f32-9d99-737ad3040dd7@citrix.com> <20221123170337.keacggyvn4ykbtsw@treble> <20221124023934.nft3udxelth4lvai@treble> <72a4871b-3ee8-42c1-912a-321a45690428@suse.com> In-Reply-To: <72a4871b-3ee8-42c1-912a-321a45690428@suse.com> --------------0IclpDUqLeC6ZzwUmVegATIk Content-Type: multipart/mixed; boundary="------------EeNKth1XtNH0IGGGy8q3zBtC" --------------EeNKth1XtNH0IGGGy8q3zBtC Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjQuMTEuMjIgMDY6MjgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE9uIDI0LjExLjIy IDAzOjM5LCBKb3NoIFBvaW1ib2V1ZiB3cm90ZToNCj4+IE9uIFdlZCwgTm92IDIzLCAyMDIy IGF0IDA5OjAzOjQwQU0gLTA4MDAsIEpvc2ggUG9pbWJvZXVmIHdyb3RlOg0KPj4+IE9uIFdl ZCwgTm92IDIzLCAyMDIyIGF0IDEwOjUyOjA5QU0gKzAwMDAsIEFuZHJldyBDb29wZXIgd3Jv dGU6DQo+Pj4+PiBXZWxsLCBpZiB5b3UgcmV0dXJuIGZyb20gYXJjaF9jcHVfaWRsZV9kZWFk KCkgeW91J3JlIGJhY2sgaW4gdGhlIGlkbGUNCj4+Pj4+IGxvb3AgLS0gZXhhY3RseSB3aGVy ZSB5b3Ugd291bGQgYmUgaWYgeW91IHdlcmUgdG8gYm9vdHN0cmFwIHRoZSB3aG9sZQ0KPj4+ Pj4gQ1BVIC0tIHByb3ZpZGVkIHlvdSBoYXZlIGl0IHJlbWVtYmVyIHRoZSB3aG9sZSBzdGF0 ZSAoZWFzaWVyIHdpdGggYQ0KPj4+Pj4gdkNQVSkuDQo+Pj4NCj4+PiBwbGF5X2RlYWQoKSBy ZWFsbHkgbmVlZHMgc2FuZSBzZW1hbnRpY3MuwqAgTm90IG9ubHkgZG9lcyBpdCBpbnRyb2R1 Y2UgYQ0KPj4+IHN1cnByaXNlIHRvIHRoZSBvZmZsaW5pbmcgY29kZSBpbiBkb19pZGxlKCks IGl0IGFsc28gc2tpcHMgdGhlIGVudGlyZQ0KPj4+IGhvdHBsdWcgc3RhdGUgbWFjaGluZS7C oCBOb3Qgc3VyZSBpZiB0aGF0IGludHJvZHVjZXMgYW55IGJ1Z3MsIGJ1dCBhdCB0aGUNCj4+ PiB2ZXJ5IGxlYXN0IGl0J3Mgc3VidGxlIGFuZCBzdXJwcmlzaW5nLg0KPj4+DQo+Pj4+PiBC dXQgbWF5YmUgSSdtIG1pc3Npbmcgc29tZXRoaW5nLCBsZXRzIGFkZCBYZW4gZm9sa3Mgb24u DQo+Pj4+DQo+Pj4+IENhbGxpbmcgVkNQVU9QX2Rvd24gb24gb25lc2VsZiBhbHdheXMgc3Vj Y2VlZHMsIGJ1dCBhbGwgaXQgZG9lcyBpcw0KPj4+PiBkZXNjaGVkdWxlIHRoZSB2Q1BVLg0K Pj4+Pg0KPj4+PiBJdCBjYW4gYmUgdW5kb25lIGF0IGEgbGF0ZXIgcG9pbnQgYnkgYSBkaWZm ZXJlbnQgdmNwdSBpc3N1aW5nIFZDUFVPUF91cA0KPj4+PiBhZ2FpbnN0IHRoZSBwcmV2aW91 c2x5LWRvd25lZCBDUFUsIGF0IHdoaWNoIHBvaW50IHRoZSB2Q1BVIGdldHMgcmVzY2hlZHVs ZWQuDQo+Pj4+DQo+Pj4+IFRoaXMgaXMgd2h5IHRoZSBWQ1BVT1BfZG93biBoeXBlcmNhbGwg cmV0dXJucyBub3JtYWxseS7CoCBBbGwgc3RhdGUNCj4+Pj4gcmVhbGx5IGlzIGludGFjdC4N Cj4+Pj4NCj4+Pj4gQXMgZm9yIHdoYXQgTGludXggZG9lcywgdGhpcyBpcyBob3cgeGVuX3B2 X2NwdV91cCgpIGN1cnJlbnRseSBiZWhhdmVzLg0KPj4+PiBJZiB5b3Ugd2FudCB0byBtYWtl IFhlbiBiZWhhdmUgbW9yZSBldmVyeXRoaW5nIGVsc2UsIHRoZW4gYnVnIGEgQlVHKCkNCj4+ Pj4gYWZ0ZXIgVkNQVU9QX2Rvd24sIGFuZCBhZGp1c3QgeGVuX3B2X2NwdV91cCgpIHRvIHNr aXAgaXRzIGluaXRpYWxpc2VkDQo+Pj4+IGNoZWNrIGFuZCBhbHdheXMgdXNlIFZDUFVPUF9p bml0aWFsaXNlIHRvIGJyaW5nIHRoZSB2Q1BVIGJhY2sgb25saW5lLg0KPj4+DQo+Pj4gT3Ig d2UgY291bGQgZG8gd2hhdCBzZXZfZXNfcGxheV9kZWFkKCkgZG9lcyBhbmQganVzdCBjYWxs IHN0YXJ0X2NwdTAoKQ0KPj4+IGFmdGVyIHRoZSBoeXBlcmNhbGwgcmV0dXJucz8NCj4+DQo+ PiBTb21ldGhpbmcgbGlrZSBzbyAodW50ZXN0ZWQpLsKgIFRoaXMgaXMgb25seSB0aGUgeDg2 IGJpdHMuDQo+Pg0KPj4gSSB0aGluayBJIGNvbnZpbmNlZCBteXNlbGYgdGhhdCBzdGFydF9j cHUwKCkgaXNuJ3QgYnVnZ3kuwqAgSSdtIGxvb2tpbmcNCj4+IGF0IG90aGVyIGNsZWFudXBz LCBlLmcuIGNvbnZlcmdpbmcgY3B1X2JyaW5ndXBfYW5kX2lkbGUoKSB3aXRoDQo+PiBzdGFy dF9zZWNvbmRhcnkoKS4NCj4+DQo+PiBJIGNhbiBwaWNrIGl0IHVwIGFnYWluIG5leHQgd2Vl aywgcG9zdC10dXJrZXkuDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L2luY2x1ZGUv YXNtL3NtcC5oIGIvYXJjaC94ODYvaW5jbHVkZS9hc20vc21wLmgNCj4+IGluZGV4IGI0ZGJi MjBkYWIxYS4uZTZkMWQyODEwZTM4IDEwMDY0NA0KPj4gLS0tIGEvYXJjaC94ODYvaW5jbHVk ZS9hc20vc21wLmgNCj4+ICsrKyBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL3NtcC5oDQo+PiBA QCAtOTMsOSArOTMsMTAgQEAgc3RhdGljIGlubGluZSB2b2lkIF9fY3B1X2RpZSh1bnNpZ25l ZCBpbnQgY3B1KQ0KPj4gwqDCoMKgwqDCoCBzbXBfb3BzLmNwdV9kaWUoY3B1KTsNCj4+IMKg IH0NCj4+IC1zdGF0aWMgaW5saW5lIHZvaWQgcGxheV9kZWFkKHZvaWQpDQo+PiArc3RhdGlj IGlubGluZSB2b2lkIF9fbm9yZXR1cm4gcGxheV9kZWFkKHZvaWQpDQo+PiDCoCB7DQo+PiDC oMKgwqDCoMKgIHNtcF9vcHMucGxheV9kZWFkKCk7DQo+PiArwqDCoMKgIEJVRygpOw0KPj4g wqAgfQ0KPj4gwqAgc3RhdGljIGlubGluZSB2b2lkIHNtcF9zZW5kX3Jlc2NoZWR1bGUoaW50 IGNwdSkNCj4+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni9rZXJuZWwvcHJvY2Vzcy5jIGIvYXJj aC94ODYva2VybmVsL3Byb2Nlc3MuYw0KPj4gaW5kZXggMjZlOGY1N2M3NWFkLi44ZTI4NDFk ZWIxZWIgMTAwNjQ0DQo+PiAtLS0gYS9hcmNoL3g4Ni9rZXJuZWwvcHJvY2Vzcy5jDQo+PiAr KysgYi9hcmNoL3g4Ni9rZXJuZWwvcHJvY2Vzcy5jDQo+PiBAQCAtNzAwLDcgKzcwMCw3IEBA IEVYUE9SVF9TWU1CT0woYm9vdF9vcHRpb25faWRsZV9vdmVycmlkZSk7DQo+PiDCoCBzdGF0 aWMgdm9pZCAoKng4Nl9pZGxlKSh2b2lkKTsNCj4+IMKgICNpZm5kZWYgQ09ORklHX1NNUA0K Pj4gLXN0YXRpYyBpbmxpbmUgdm9pZCBwbGF5X2RlYWQodm9pZCkNCj4+ICtzdGF0aWMgaW5s aW5lIHZvaWQgX19ub3JldHVybiBwbGF5X2RlYWQodm9pZCkNCj4+IMKgIHsNCj4+IMKgwqDC oMKgwqAgQlVHKCk7DQo+PiDCoCB9DQo+PiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYva2VybmVs L3NtcGJvb3QuYyBiL2FyY2gveDg2L2tlcm5lbC9zbXBib290LmMNCj4+IGluZGV4IDU1Y2Fk NzI3MTVkOS4uZDhiMTJhYzFhN2M1IDEwMDY0NA0KPj4gLS0tIGEvYXJjaC94ODYva2VybmVs L3NtcGJvb3QuYw0KPj4gKysrIGIvYXJjaC94ODYva2VybmVsL3NtcGJvb3QuYw0KPj4gQEAg LTE4MzMsOSArMTgzMywxMiBAQCB2b2lkIG5hdGl2ZV9wbGF5X2RlYWQodm9pZCkNCj4+IMKg wqDCoMKgwqAgcGxheV9kZWFkX2NvbW1vbigpOw0KPj4gwqDCoMKgwqDCoCB0Ym9vdF9zaHV0 ZG93bihUQl9TSFVURE9XTl9XRlMpOw0KPj4gLcKgwqDCoCBtd2FpdF9wbGF5X2RlYWQoKTvC oMKgwqAgLyogT25seSByZXR1cm5zIG9uIGZhaWx1cmUgKi8NCj4+ICvCoMKgwqAgbXdhaXRf cGxheV9kZWFkKCk7wqDCoMKgIC8qIE9ubHkgcmV0dXJucyBpZiBtd2FpdCBpcyBub3Qgc3Vw cG9ydGVkICovDQo+PiArDQo+PiDCoMKgwqDCoMKgIGlmIChjcHVpZGxlX3BsYXlfZGVhZCgp KQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGhsdF9wbGF5X2RlYWQoKTsNCj4+ICsNCj4+ICvC oMKgwqAgQlVHKCk7DQo+PiDCoCB9DQo+PiDCoCAjZWxzZSAvKiAuLi4gIUNPTkZJR19IT1RQ TFVHX0NQVSAqLw0KPj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L3hlbi9zbXBfcHYuYyBiL2Fy Y2gveDg2L3hlbi9zbXBfcHYuYw0KPj4gaW5kZXggNDgwYmU4MmU5YjdiLi4zMGRjOTA0Y2E5 OTAgMTAwNjQ0DQo+PiAtLS0gYS9hcmNoL3g4Ni94ZW4vc21wX3B2LmMNCj4+ICsrKyBiL2Fy Y2gveDg2L3hlbi9zbXBfcHYuYw0KPj4gQEAgLTM4NSwxNyArMzg1LDkgQEAgc3RhdGljIHZv aWQgeGVuX3B2X3BsYXlfZGVhZCh2b2lkKSAvKiB1c2VkIG9ubHkgd2l0aCANCj4+IEhPVFBM VUdfQ1BVICovDQo+PiDCoCB7DQo+PiDCoMKgwqDCoMKgIHBsYXlfZGVhZF9jb21tb24oKTsN Cj4+IMKgwqDCoMKgwqAgSFlQRVJWSVNPUl92Y3B1X29wKFZDUFVPUF9kb3duLCB4ZW5fdmNw dV9ucihzbXBfcHJvY2Vzc29yX2lkKCkpLCBOVUxMKTsNCj4+IC3CoMKgwqAgY3B1X2JyaW5n dXAoKTsNCj4+IC3CoMKgwqAgLyoNCj4+IC3CoMKgwqDCoCAqIGNvbW1pdCA0YjBjMGYyOTQg KHRpY2s6IENsZWFudXAgTk9IWiBwZXIgY3B1IGRhdGEgb24gY3B1IGRvd24pDQo+PiAtwqDC oMKgwqAgKiBjbGVhcnMgY2VydGFpbiBkYXRhIHRoYXQgdGhlIGNwdV9pZGxlIGxvb3AgKHdo aWNoIGNhbGxlZCB1cw0KPj4gLcKgwqDCoMKgICogYW5kIHRoYXQgd2UgcmV0dXJuIGZyb20p IGV4cGVjdHMuIFRoZSBvbmx5IHdheSB0byBnZXQgdGhhdA0KPj4gLcKgwqDCoMKgICogZGF0 YSBiYWNrIGlzIHRvIGNhbGw6DQo+PiAtwqDCoMKgwqAgKi8NCj4+IC3CoMKgwqAgdGlja19u b2h6X2lkbGVfZW50ZXIoKTsNCj4+IC3CoMKgwqAgdGlja19ub2h6X2lkbGVfc3RvcF90aWNr X3Byb3RlY3RlZCgpOw0KPj4gLcKgwqDCoCBjcHVocF9vbmxpbmVfaWRsZShDUFVIUF9BUF9P TkxJTkVfSURMRSk7DQo+PiArwqDCoMKgIC8qIEZJWE1FOiBjb252ZXJnZSBjcHVfYnJpbmd1 cF9hbmRfaWRsZSgpIGFuZCBzdGFydF9zZWNvbmRhcnkoKSAqLw0KPj4gK8KgwqDCoCBjcHVf YnJpbmd1cF9hbmRfaWRsZSgpOw0KPiANCj4gSSB0aGluayB0aGlzIHdpbGwgbGVhayBzdGFj ayBtZW1vcnkuIE11bHRpcGxlIGNwdSBvZmZsaW5lL29ubGluZSBjeWNsZXMgb2YNCj4gdGhl IHNhbWUgY3B1IHdpbGwgZmluYWxseSBleGhhdXN0IHRoZSBpZGxlIHN0YWNrLg0KDQpUaGUg YXR0YWNoZWQgcGF0Y2ggc2VlbXMgdG8gd29yayBmaW5lLg0KDQpUaGUgX19ub3JldHVybiBh bm5vdGF0aW9uIHNlZW1zIHRvIHRyaWdnZXIgYW4gb2JqdG9vbCB3YXJuaW5nLCB0aG91Z2gs IGluDQpzcGl0ZSBvZiB0aGUgYWRkZWQgQlVHKCkgYXQgdGhlIGVuZCBvZiB4ZW5fcHZfcGxh eV9kZWFkKCk6DQoNCmFyY2gveDg2L3hlbi9zbXBfcHYubzogd2FybmluZzogb2JqdG9vbDog eGVuX3B2X3BsYXlfZGVhZCgpIGZhbGxzIHRocm91Z2ggdG8gDQpuZXh0IGZ1bmN0aW9uIHhl bl9wdl9jcHVfZGllKCkNCg0KDQpKdWVyZ2VuDQoNCg== --------------EeNKth1XtNH0IGGGy8q3zBtC Content-Type: text/x-patch; charset=UTF-8; name="0001-x86-xen-don-t-let-xen_pv_play_dead-return.patch" Content-Disposition: attachment; filename="0001-x86-xen-don-t-let-xen_pv_play_dead-return.patch" Content-Transfer-Encoding: base64 RnJvbSA3ZWJiNzZlYzBlZDMyYjY1N2NlZGE1MzBiNjIwZWY1NjNhYzBmMjEyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ CkRhdGU6IFRodSwgMjQgTm92IDIwMjIgMDg6MDk6NDUgKzAxMDAKU3ViamVjdDogW1BBVENI XSB4ODYveGVuOiBkb24ndCBsZXQgeGVuX3B2X3BsYXlfZGVhZCgpIHJldHVybgoKQSBmdW5j dGlvbiBjYWxsZWQgdmlhIHRoZSBwYXJhdmlydCBwbGF5X2RlYWQoKSBob29rIHNob3VsZCBu b3QgcmV0dXJuCnRvIHRoZSBjYWxsZXIuCgp4ZW5fcHZfcGxheV9kZWFkKCkgaGFzIGEgcHJv YmxlbSBpbiB0aGlzIHJlZ2FyZCwgYXMgaXQgY3VycmVudGx5IHdpbGwKcmV0dXJuIGluIGNh c2UgYW4gb2ZmbGluZWQgY3B1IGlzIGJyb3VnaHQgdG8gbGlmZSBhZ2Fpbi4gVGhpcyBjYW4g YmUKY2hhbmdlZCBvbmx5IGJ5IGRvaW5nIGJhc2ljYWxseSBhIGxvbmdqbXAoKSB0byBjcHVf YnJpbmd1cF9hbmRfaWRsZSgpLAphcyB0aGUgaHlwZXJjYWxsIGZvciBicmluZ2luZyBkb3du IHRoZSBjcHUgd2lsbCBqdXN0IHJldHVybiB3aGVuIHRoZQpjcHUgaXMgY29taW5nIHVwIGFn YWluLiBKdXN0IHJlLWluaXRpYWxpemluZyB0aGUgY3B1IGlzbid0IHBvc3NpYmxlLAphcyB0 aGUgWGVuIGh5cGVydmlzb3Igd2lsbCBkZW55IHRoYXQgb3BlcmF0aW9uLgoKU28gaW50cm9k dWNlIHhlbl9jcHVfYnJpbmd1cF9hZ2FpbigpIHJlc2V0dGluZyB0aGUgc3RhY2sgYW5kIGNh bGxpbmcKY3B1X2JyaW5ndXBfYW5kX2lkbGUoKSwgd2hpY2ggY2FuIGJlIGNhbGxlZCBhZnRl ciBIWVBFUlZJU09SX3ZjcHVfb3AoKQppbiB4ZW5fcHZfcGxheV9kZWFkKCkuCgpBbm5vdGF0 ZSB4ZW5fcHZfcGxheV9kZWFkKCkgYW5kIHhlbl9jcHVfYnJpbmd1cF9hZ2FpbigpIHdpdGgK Il9fbm9yZXR1cm4iLgoKU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuY29tPgotLS0KIGFyY2gveDg2L3hlbi9zbXAuaCAgICAgIHwgIDIgKysKIGFyY2gveDg2 L3hlbi9zbXBfcHYuYyAgIHwgMTcgKysrKy0tLS0tLS0tLS0tLS0KIGFyY2gveDg2L3hlbi94 ZW4taGVhZC5TIHwgIDcgKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25z KCspLCAxMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9hcmNoL3g4Ni94ZW4vc21wLmgg Yi9hcmNoL3g4Ni94ZW4vc21wLmgKaW5kZXggYmQwMmY5ZDUwMTA3Li4yMmZiOTgyZmY5NzEg MTAwNjQ0Ci0tLSBhL2FyY2gveDg2L3hlbi9zbXAuaAorKysgYi9hcmNoL3g4Ni94ZW4vc21w LmgKQEAgLTIxLDYgKzIxLDggQEAgdm9pZCB4ZW5fc21wX3NlbmRfcmVzY2hlZHVsZShpbnQg Y3B1KTsKIHZvaWQgeGVuX3NtcF9zZW5kX2NhbGxfZnVuY3Rpb25faXBpKGNvbnN0IHN0cnVj dCBjcHVtYXNrICptYXNrKTsKIHZvaWQgeGVuX3NtcF9zZW5kX2NhbGxfZnVuY3Rpb25fc2lu Z2xlX2lwaShpbnQgY3B1KTsKIAordm9pZCBfX25vcmV0dXJuIHhlbl9jcHVfYnJpbmd1cF9h Z2Fpbih1bnNpZ25lZCBsb25nIHN0YWNrKTsKKwogc3RydWN0IHhlbl9jb21tb25faXJxIHsK IAlpbnQgaXJxOwogCWNoYXIgKm5hbWU7CmRpZmYgLS1naXQgYS9hcmNoL3g4Ni94ZW4vc21w X3B2LmMgYi9hcmNoL3g4Ni94ZW4vc21wX3B2LmMKaW5kZXggNDgwYmU4MmU5YjdiLi41ODAx ZjkzZDU2N2MgMTAwNjQ0Ci0tLSBhL2FyY2gveDg2L3hlbi9zbXBfcHYuYworKysgYi9hcmNo L3g4Ni94ZW4vc21wX3B2LmMKQEAgLTM4MSwyMSArMzgxLDEyIEBAIHN0YXRpYyB2b2lkIHhl bl9wdl9jcHVfZGllKHVuc2lnbmVkIGludCBjcHUpCiAJfQogfQogCi1zdGF0aWMgdm9pZCB4 ZW5fcHZfcGxheV9kZWFkKHZvaWQpIC8qIHVzZWQgb25seSB3aXRoIEhPVFBMVUdfQ1BVICov CitzdGF0aWMgdm9pZCBfX25vcmV0dXJuIHhlbl9wdl9wbGF5X2RlYWQodm9pZCkgLyogdXNl ZCBvbmx5IHdpdGggSE9UUExVR19DUFUgKi8KIHsKIAlwbGF5X2RlYWRfY29tbW9uKCk7CiAJ SFlQRVJWSVNPUl92Y3B1X29wKFZDUFVPUF9kb3duLCB4ZW5fdmNwdV9ucihzbXBfcHJvY2Vz c29yX2lkKCkpLCBOVUxMKTsKLQljcHVfYnJpbmd1cCgpOwotCS8qCi0JICogY29tbWl0IDRi MGMwZjI5NCAodGljazogQ2xlYW51cCBOT0haIHBlciBjcHUgZGF0YSBvbiBjcHUgZG93bikK LQkgKiBjbGVhcnMgY2VydGFpbiBkYXRhIHRoYXQgdGhlIGNwdV9pZGxlIGxvb3AgKHdoaWNo IGNhbGxlZCB1cwotCSAqIGFuZCB0aGF0IHdlIHJldHVybiBmcm9tKSBleHBlY3RzLiBUaGUg b25seSB3YXkgdG8gZ2V0IHRoYXQKLQkgKiBkYXRhIGJhY2sgaXMgdG8gY2FsbDoKLQkgKi8K LQl0aWNrX25vaHpfaWRsZV9lbnRlcigpOwotCXRpY2tfbm9oel9pZGxlX3N0b3BfdGlja19w cm90ZWN0ZWQoKTsKLQotCWNwdWhwX29ubGluZV9pZGxlKENQVUhQX0FQX09OTElORV9JRExF KTsKKwl4ZW5fY3B1X2JyaW5ndXBfYWdhaW4oKHVuc2lnbmVkIGxvbmcpdGFza19wdF9yZWdz KGN1cnJlbnQpKTsKKwlCVUcoKTsKIH0KIAogI2Vsc2UgLyogIUNPTkZJR19IT1RQTFVHX0NQ VSAqLwpAQCAtNDA5LDcgKzQwMCw3IEBAIHN0YXRpYyB2b2lkIHhlbl9wdl9jcHVfZGllKHVu c2lnbmVkIGludCBjcHUpCiAJQlVHKCk7CiB9CiAKLXN0YXRpYyB2b2lkIHhlbl9wdl9wbGF5 X2RlYWQodm9pZCkKK3N0YXRpYyB2b2lkIF9fbm9yZXR1cm4geGVuX3B2X3BsYXlfZGVhZCh2 b2lkKQogewogCUJVRygpOwogfQpkaWZmIC0tZ2l0IGEvYXJjaC94ODYveGVuL3hlbi1oZWFk LlMgYi9hcmNoL3g4Ni94ZW4veGVuLWhlYWQuUwppbmRleCBmZmFhNjIxNjdmNmUuLmUzNmVh NDI2OGJkMiAxMDA2NDQKLS0tIGEvYXJjaC94ODYveGVuL3hlbi1oZWFkLlMKKysrIGIvYXJj aC94ODYveGVuL3hlbi1oZWFkLlMKQEAgLTc2LDYgKzc2LDEzIEBAIFNZTV9DT0RFX1NUQVJU KGFzbV9jcHVfYnJpbmd1cF9hbmRfaWRsZSkKIAogCWNhbGwgY3B1X2JyaW5ndXBfYW5kX2lk bGUKIFNZTV9DT0RFX0VORChhc21fY3B1X2JyaW5ndXBfYW5kX2lkbGUpCisKK1NZTV9DT0RF X1NUQVJUKHhlbl9jcHVfYnJpbmd1cF9hZ2FpbikKKwlVTldJTkRfSElOVF9GVU5DCisJbW92 CSVyZGksICVyc3AKKwlVTldJTkRfSElOVF9SRUdTCisJY2FsbAljcHVfYnJpbmd1cF9hbmRf aWRsZQorU1lNX0NPREVfRU5EKHhlbl9jcHVfYnJpbmd1cF9hZ2FpbikKIC5wb3BzZWN0aW9u CiAjZW5kaWYKICNlbmRpZgotLSAKMi4zNS4zCgo= --------------EeNKth1XtNH0IGGGy8q3zBtC Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------EeNKth1XtNH0IGGGy8q3zBtC-- --------------0IclpDUqLeC6ZzwUmVegATIk-- --------------eljA8Dt0yylIHwiYAZnuZFCA Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmN/IaMFAwAAAAAACgkQsN6d1ii/Ey+r swf/T9WKJWbux7ecy27njG8CCPiHBw+2eSS7C9o30PZ/EUs/cqGWcjnsZfo7D6dqhudFoucaqi72 KGFhDy9nw7iYJh1mnGMi5k4riT9OBljSUdeSSMEUaAUCu8l9Q3x213hMxbm6uAYilGOuiLXrtFKY AEWWXTtzpjE10Kfi4DVNEKbJzKEFiG+gd/f1MGMhyLJHNH1El6asJPTtiVlBa8rpORlZ1cGonsWH fz+nScpHxDYKNEK9cdnow4CirwdoZ9mi5JcFFrjc4ZGrE6c//2WkfAF9YVeKNKS9L7nOi/oHBqKi 2B/yVGyaf5cN8Nr21cJjjYo4J7/hIAI3eLXZQj/GeQ== =LCcO -----END PGP SIGNATURE----- --------------eljA8Dt0yylIHwiYAZnuZFCA-- From xen-devel-bounces@lists.xenproject.org Thu Nov 24 07:54:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 07:54:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447799.704425 (Exim 4.92) (envelope-from ) id 1oy741-0003xB-KC; Thu, 24 Nov 2022 07:54:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447799.704425; Thu, 24 Nov 2022 07:54:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy741-0003x4-Fe; Thu, 24 Nov 2022 07:54:29 +0000 Received: by outflank-mailman (input) for mailman id 447799; Thu, 24 Nov 2022 07:54:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy740-0003wu-Na; Thu, 24 Nov 2022 07:54:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy740-0004pH-GE; Thu, 24 Nov 2022 07:54:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy73z-0004ke-SX; Thu, 24 Nov 2022 07:54:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oy73z-0000Lu-S3; Thu, 24 Nov 2022 07:54:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8IHccSzQ1t98NyEXdH6dgfQ+9N4GXNdeGGqjFSkvUAg=; b=pOra+0SaEH5AGSSBbuMgbCD1iV 35JG7eBV1fWzujBRDbpQkAh9wO2F2yHFiHwxdqSrv2uTKN63sKEyazkphaJkc1KpzAB/lGFk54fZV bxavjZkUzqJOlVvi3GIKK0z/zpim/ntCsizdk9dvVm+m6z0H5Y/r0WELq8/o8QJ2gZsE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174950: regressions - FAIL X-Osstest-Failures: xen-unstable:build-arm64-pvops:kernel-build:fail:regression xen-unstable:test-amd64-i386-xl:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=345135942bf9632eba1409ba432cfcae3b7649c7 X-Osstest-Versions-That: xen=345135942bf9632eba1409ba432cfcae3b7649c7 From: osstest service owner Date: Thu, 24 Nov 2022 07:54:27 +0000 flight 174950 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174950/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 174944 Tests which are failing intermittently (not blocking): test-amd64-i386-xl 7 xen-install fail in 174944 pass in 174950 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 174944 pass in 174950 test-amd64-i386-xl-vhd 7 xen-install fail pass in 174944 test-amd64-i386-pair 11 xen-install/dst_host fail pass in 174944 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 174944 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 174944 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 174944 never pass test-arm64-arm64-xl 15 migrate-support-check fail in 174944 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 174944 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 174944 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 174944 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 174944 never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 174944 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 174944 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 174944 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 174944 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 174944 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 174944 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 174944 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 174944 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 174944 never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 174944 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 174944 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174944 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174944 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174944 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174944 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174944 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174944 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174944 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174944 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174944 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174944 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174944 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174944 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 345135942bf9632eba1409ba432cfcae3b7649c7 baseline version: xen 345135942bf9632eba1409ba432cfcae3b7649c7 Last test of basis 174950 2022-11-24 01:51:54 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Nov 24 07:59:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 07:59:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447805.704438 (Exim 4.92) (envelope-from ) id 1oy78x-0004aJ-8w; Thu, 24 Nov 2022 07:59:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447805.704438; Thu, 24 Nov 2022 07:59:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy78x-0004aC-6L; Thu, 24 Nov 2022 07:59:35 +0000 Received: by outflank-mailman (input) for mailman id 447805; Thu, 24 Nov 2022 07:59:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy78w-0004a6-KB for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 07:59:34 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70078.outbound.protection.outlook.com [40.107.7.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ee4f672c-6bcd-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 08:59:33 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8122.eurprd04.prod.outlook.com (2603:10a6:10:25d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Thu, 24 Nov 2022 07:59:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.019; Thu, 24 Nov 2022 07:59:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee4f672c-6bcd-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UKfM5pDEUMfewupfXXoG7TWQKw6sf5jaPh3qr1NfIglQDLAGPOkSK2R+YmO4bFZoG/8JY/ICPMUAYV4WJp9HTe/l8tkgJyyY48a88c0AsWadKi+8+PDiaKUt1DtDvXkBG3SpPO6wHXj9FcI+CUCS343Ffm5pI05rPnXW51hBPHBNz6tUWMkw6t6UlQvlMION9/H2dAeK7C7VMabsKTbPJyV2hJeohR8e6EoaRZwWbXUgKcjAy4C2H8zpEVpkrKvwNopqbv8j4V6d/0YJ968zsk/4FiDM51Ess9iWPVXddiUym2Jb6AwjYUFvMpa0YWYJhyIsHbs5jnK/tq2AXaTolA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/g0mthTgwGBQHAZGnHS8c+Z1/zECCof3xKXkMQyy7Qk=; b=FktN/+BfS3KxXgltZRqJXWAk39ydZD9ihoFndkbEvzYt75/EkofJzEXf+GgNyvHAkAMi/GBYDqR0wMRHkjjZleyJucdd4l/sh+trrmqPNxLBxMw4ZoOOej3zLk71onygpxlpk87KNKcfzwsmEmzHs6nvAbj/u1tvHX5x2Xr3eQDEi9UBRguhBcO7LA4nhm7G2zgd7qokGDOTaaWkdN4L978Duo22ayB1X/5zZa9EaiFkwHFhUdVSmO1mYw3ccs2dBYJTuMhmXj2HwlkbXLcdVxJArOPAWbfY2C1Jd7kGQkhf4ySY2OMtZO8/OxxisdOQ9YLp4pdtshsz+ceaQNej0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/g0mthTgwGBQHAZGnHS8c+Z1/zECCof3xKXkMQyy7Qk=; b=mvTohXiLr3nn/iOHTNA5+yd9U137psWo4p+4A3N1Mf12KIFO4YhOIykiCC7OltzyxgRiAuo6HIvIjrCaMSFH6j0sUy8xUsREoSG6DfNdMP+5GUYS4msbG9pZYBUOTck6oqaD006P9MBQhu2UIgDq7fv0cU1KfI+CX7yd+Ktodi4RXnPZyrqlP4MqVnYTTTYs/cApjAa/8ciM5dZ2teBpt2BUFs58WBN0JRWu1RRnvm6vEaLqePovkWjgZKP5Ybk3paqLiNVC2prh/m1KDdIczzTQ3/wyUZ/JWTrgrj2yVjmBMBx6ar//USPV2mmL6/7FSWOI7O1+jgOCndWNyzVrBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <351a6e54-8002-aef0-993a-c6b8bdcc1e8e@suse.com> Date: Thu, 24 Nov 2022 08:59:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> <5a2df843-1acd-ad78-baff-e47befd0703c@citrix.com> <878e635f-b116-3580-945f-f8acb711a5bc@suse.com> <69507b8d-1f31-39fb-7469-e240fbfdde44@citrix.com> <33a005bf-0596-c624-0e70-077a450ac2ae@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0177.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8122:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e07894c-5881-452c-d377-08dacdf1c030 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fcwOr/f8xFXY9aVrbmPTZWQYb8Nw7/8qdPdsyB4aThrE9yFLQATw4wy+VThLpsAsqjjK6a0H58lr8/qxYg1vZfhQMFen07yXXMR/c+Brq5OruVXgjeh0W+XTBSSPkm5jA3wL08OWgdl4Hktbr4qP+SR78OIxce1cImbg1+/hq0t4BqHaCQdQt8OBrxTIsoanAceu/IEtM+tr5EnW/Kpn6Tlh1Y229XgQKcSaZAyUBsSj04qPQW1BvRTDJ+HFniOxyX9tInK+qNLqaEA3U/2r/c/FXaSb2BgofR3Ks8mAAgXcVY7qh1U/jA3DGXQPtUV2Yndme7RtD4OQXvwOOOt2XMCGw4s1X6IWxmE31zQ+E/twSntRWwPnd6iyryj6imbX1xUD2bO1qxZhrAzqFNgv4rEACkVKx3TYiWdNfcyACB+UsU1ZNXsIUrNo/18XZ0xT1qsool6lYppNmnY2ne0PqtrasPMf7qLkGb6hX+F3gUc2Q50e+hXYDpyPS73k1GrETozkzkEraMbmhfKLAGR3fAmG3A0JWKCCRMLj41KDw4EIPeNtB07TULir1oBW+jZy4rRMv324HyGqUVfF5A9lmxxJtOYqqJXnRFKFzel+PqPkhdP7H5i6kzT/9yyhjNaPqkonysGszhsddwTMBqpFs5v5B1oTs1R4cZg/ylDwECO376axrN5kkXaRTqxRmX90nb2axpJsdHktx6ADXtLvTvVg4ynOARs8E/g4BryPvAY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(39860400002)(376002)(346002)(396003)(451199015)(86362001)(31696002)(38100700002)(8676002)(4326008)(41300700001)(66946007)(66476007)(66556008)(54906003)(316002)(6916009)(5660300002)(8936002)(6486002)(83380400001)(2906002)(478600001)(6506007)(186003)(2616005)(53546011)(26005)(6512007)(66899015)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dndFNzg4U0NaOS9RQ3hoTVlCM0YzMjJpcW9wVUtwL1NJYlBjRnFMT0QyamQ2?= =?utf-8?B?T3ZmVDMvUklDRHVkZnFsVU9aTEpuVGtCT05RUmdPK2pnZnp1RitDQzMyTDM4?= =?utf-8?B?UFR1YUh3TmVCcmhrTXFReVFlZjNjQk9oMkEwaWtDVXpZWlo2a05pK0ExWWRl?= =?utf-8?B?Z29nMU9ydEhaQUNCTmJyb1JWUUNTaVIwaGN5YmRuNnEzbDBiOC91V2FnY0RR?= =?utf-8?B?eWlQMSszZEZ1VzEvMW9IL3lUVEJPY3ZsMzlLUjR4VVppRVozQVNzdHZJRXVy?= =?utf-8?B?ZEpLdjczV09MZGxVTU8rV21FUlBsRGxSdmEvdmpNMWdQblN4UGFkU29IbDJZ?= =?utf-8?B?TVFBOXRQL1hlK0phQk9QclhyaFJkUUNMOG9vMHdkR1hKZHdWbG9ZSEM5SktF?= =?utf-8?B?SGFnOEp3L3ZqZzVtYVVTSHRmR0hCamlZcGQyd2xjeDRyVE9sQnQ2Ti9Lb05H?= =?utf-8?B?L2FOK0dLdEJncXpEVG5qK3BUY29jc0czYUlmK3ZwRDZnZjI2SUttaTIxSUIv?= =?utf-8?B?QjI4cWFiUWRJcVJ3T2xXK1pjL1V1SjBlZWx5cEU2ejIzdEVqMTQ3MldCcU9l?= =?utf-8?B?SHdoNkhibXpPdDlTUTI4VUFFVnFuNlU5S1ZGazZQRUMyRlozdzc5Ly8zS2ZF?= =?utf-8?B?eHVqUStSSjZKSDN1ODNQRHFOSERLUDFNL3lnOGRCMTVpeEkxRjRNaTVmdCtI?= =?utf-8?B?V0xacGE5Vm5JeVMzTElHWS92QkNxcW1vL1Yvc3FnNCt5cjJWK3hZUWt6QmZm?= =?utf-8?B?WmNDVFNwU1dVME1ncCs0WnZQazNISnpCcy9lL294cktGRDNwNUhMZ2xUQm1Q?= =?utf-8?B?R2htL0crMEp1RFhlN2tVcktiL0RBY0hGZEpMYmNsSnFLL284SURST1BDczdS?= =?utf-8?B?SHowOWhMMEhzR3NyT0M5WUdGajhrdS9qR0c5U2xrNGZkRDZnU0pKSjA5ZE1L?= =?utf-8?B?d0pkT25hb21vdzdXdE5JVWxiUlZTdFhqVFhaWG1KQi92Y0JWZmFiOUtBeS9S?= =?utf-8?B?eXZSUW1XOTRzRGRLc0dFaWJFaTlROUVsSCsrMDlDdXhmc2lrUFhFZmxRM2Zk?= =?utf-8?B?OUNDREJUc0VZMkNIa2VyNlcyQmsrUFBjSWtrU0tDZU1Bd0RTUURuRnBuWmlj?= =?utf-8?B?b21ReHJZNW1PTUlzcHNVaW10eWFjZEdzMUt4NDMzRjJRWGVBdUkxYUxudFh2?= =?utf-8?B?MWoyQkNTakFXOGYrcmZITzJuMmlWNFl5ZFZyOE1MZXp3QmlZZzdFcVFPakdw?= =?utf-8?B?Tk9qQk5mbzUwSW5SOXQxNVZTcUY3RGt6UVNXcXI3eDVGdnRmSE45WUw4OTBl?= =?utf-8?B?SC9zcGZHVkc2NkRFOVdCalpZak9yMW43ME9SRzMxbU8xcndmKytaZFR0K29h?= =?utf-8?B?R1B3U2ZPRDRDRXBEViswd3owZG1ob0doL24yTUkwTm53d0xsTHRwdkZIZ3dw?= =?utf-8?B?bGM1dlU2VXcybTZGV1pmRHdyU1hMK2l4V3ZVVjRBWEtkQ0U3ZlVLWC94T1c3?= =?utf-8?B?RHJEejEwa2dPNWVNQmk5MHkzZFhwYTh4bHpuQkFSOVkwVW1DZjIwVHd4bHlx?= =?utf-8?B?R2FYNlBDc3p1aDk4NXprdlZUbjA0cE1makVDNE1uS3BNSkhtMkZGbWVNaUE5?= =?utf-8?B?aWRLaTRBVkJld2N0aGZqUVpwTzZDVjNKaHpnaHB4NndXRlZXUjJEU3V2OXZq?= =?utf-8?B?MWN0NEsyVDhVT0szVjlPMzNEM3pCQlRXLzZTNVJheG5semMzRWlFb3hFenZU?= =?utf-8?B?a1REOEZTS1RWV3dYbG1UMXZuaTZPM1pnWDc1ZnVGY2xEMjdsTXhnNm1RaUI2?= =?utf-8?B?UjVxRkZacmRsQmVDaHMrd0JBalJWcEk3N1JQV0xSVmZ1V0x2ckZkbTBWSTIw?= =?utf-8?B?MzVtSDlFMXlRMithalIzeGxGYSs4Q09IL3BoazREWkNCMi9JV0k1a0RiOUs4?= =?utf-8?B?c3h1aU0wSzhhZS82ay9RanZ5czFDRjd3eTErdHJKM0pnN2liVmhmL25DZ1Z5?= =?utf-8?B?dkY4MjR6RmIzTTBGME1XS2M4QUVaVlRMTm1ibnRHTExsMTZYYXFRc2VNZUw0?= =?utf-8?B?Smlick9GZzcveUZZdUhkbGJCU3pZQnpCdEpCY01nSXBzck9PZ0h1TkN2bTRR?= =?utf-8?Q?aXQ2A4bijQ9ZekqLyVB8PwDlg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e07894c-5881-452c-d377-08dacdf1c030 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 07:59:02.2834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VYShplavFGFiphZLeISO5mjSMrea5buE2vtrM+0OIdhsqfUeFw8Kky3QQc340YMieEYnGQOUj+t2cNuMNm4LcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8122 On 23.11.2022 13:03, Roger Pau Monné wrote: > On Mon, Nov 21, 2022 at 01:34:38PM +0100, Jan Beulich wrote: >> On 21.11.2022 13:23, Andrew Cooper wrote: >>> On 21/11/2022 08:56, Jan Beulich wrote: >>>> On 18.11.2022 15:27, Andrew Cooper wrote: >>>>> I even got as far as writing that maybe leaving it as-is was the best >>>>> option (principle of least surprise for Xen developers), but our >>>>> "friend" apic acceleration strikes again. >>>>> >>>>> Xen doesn't always get a VMExit when the guest clears SW_DISABLE, >>>>> because microcode may have accelerated it. >>>> But as per "APIC-Write Emulation" in the SDM we'd still get an APIC-write >>>> VM exit. >>> >>> Intel isn't the only accelerated implementation, and there future >>> details not in the public docs. >>> >>> There will be an implementation we will want to support where Xen >>> doesn't get a vmexit for a write to SPIV. >> >> I see. >> >>>> If we didn't, how would our internal accounting of APIC enabled >>>> state (VLAPIC_SW_DISABLED) work? >>> >>> It doesn't. >>> >>> One of many problems on the "known errors" list from an incomplete >>> original attempt to get acceleration working. >>> >>> There's no good reason to cache those disables in the first place (both >>> are both trivially available from other positions in memory), and >>> correctness reasons not to. >>> >>>> And the neighboring (to where I'm adding >>>> the new code) pt_may_unmask_irq() call then also wouldn't occur. >>>> >>>> I'm actually pretty sure we do too much in this case - in particular none >>>> of the vlapic_set_reg() should be necessary. But we certainly can't get >>>> away with doing nothing, and hence we depend on that VM exit to actually >>>> occur. >>> >>> We must do exactly and only what real hardware does, so that the state >>> changes emulated by Xen are identical to those accelerated by microcode. >>> >>> Other than that, I really wouldn't make any presumptions about the >>> existing vLAPIC logic being correct. >>> >>> It is, at best, enough of an approximation to the spec for major OSes to >>> function, with multiple known bugs and no coherent testing. >> >> But can we leave resolving of the wider issue then separate, and leave >> the change here as it presently is? Yes, mimic-ing the same behavior >> later may be "interesting", but if we can't achieve consistent behavior >> with yet more advanced acceleration, maybe we simply can't use that >> (perhaps until a complete overhaul of everything involved in LAPIC >> handling, possibly including a guest side indicator that they're happy >> without the extra signaling, at which point that yet-more-advanced >> acceleration could then be enabled for that guest). >> >> Otherwise - do you have any suggestion as to alternative logic which I >> might use in this patch? > > Maybe the underlying issue is that we allow executing > HVMOP_set_evtchn_upcall_vector against remote vCPU. This could be > solved by only allowing HVMOP_set_evtchn_upcall_vector against the > current vCPU and with the LAPIC enabled, but I guess we are too late > for that. Allowing things like this ahead of bringing a vCPU online can be helpful for the OS side implementation, I think. > Actually, what about only injecting the spurious event if the vCPU is > online, ie: > > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index ae4368ec4b..4b84706579 100644 > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -4105,7 +4105,8 @@ static int hvmop_set_evtchn_upcall_vector( > printk(XENLOG_G_INFO "%pv: upcall vector %02x\n", v, op.vector); > > v->arch.hvm.evtchn_upcall_vector = op.vector; > - hvm_assert_evtchn_irq(v); > + if ( is_vcpu_online(v) ) > + hvm_assert_evtchn_irq(v); While this would match what hvm_set_callback_via() does, see my post- commit-message remark suggesting to key this to evtchn_upcall_pending. Tying the call to the vCPU being online looks pretty arbitrary to me, the more that this would continue to be - racy with the vCPU coming online, and perhaps already being past VCPUOP_initialise - after all VCPUOP_up is little more than clearing VPF_down, - problematic wrt evtchn_upcall_pending, once set, preventing event injection later on. As you may have inferred already, I'm inclined to suggest to drop the the is_vcpu_online() check from hvm_set_callback_via(). One related question here is whether vlapic_do_init() shouldn't have the non-architectural side effect of clearing evtchn_upcall_pending. While this again violates the principle of the hypervisor only ever setting that bit, it would deal with the risk of no further event injection once the flag is set, considering that vlapic_do_init() clears IRR (and ISR). Jan > I think that should fix the issue seen on Linux. We would > additionally need to fix hvm_assert_evtchn_irq() to only set the > vector if the vLAPIC is enabled. > > Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Nov 24 08:11:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 08:11:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447815.704450 (Exim 4.92) (envelope-from ) id 1oy7Ka-0007rf-Ow; Thu, 24 Nov 2022 08:11:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447815.704450; Thu, 24 Nov 2022 08:11:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy7Ka-0007rY-Lv; Thu, 24 Nov 2022 08:11:36 +0000 Received: by outflank-mailman (input) for mailman id 447815; Thu, 24 Nov 2022 08:11:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy7KZ-0007rS-0u for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 08:11:35 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20601.outbound.protection.outlook.com [2a01:111:f400:fe16::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b98be55-6bcf-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 09:11:33 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7448.eurprd04.prod.outlook.com (2603:10a6:10:1a6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.11; Thu, 24 Nov 2022 08:11:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.019; Thu, 24 Nov 2022 08:11:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b98be55-6bcf-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hnfLTYQt578ehPwOEp/7aOTjC7jzv6mtq7KDhc//ya1qXudm0kQLKa2GwKMu1qdjQZPtWpgGhAUk/7/myd2vym5c4yoH6FbQomejXo44njgNUxGx7Bz9Bm9ZtvEOUS+9Nnk8W6Oe+B9vJH7hk3bh4CEdV5rCVAi/ZLyf33195C/mx6kUz2mchqCQ8QRdfDYdOL7StOxpYcT1Ms6dBg/3c1RizF+PmKlN4IOhXw4/L/ZjAItUxl6ERDI0L4ySe1+v3FqVriKHAd9H0lq8H3T/qDQcZqKzeWKqpxa/0fvwERlTt0Pj7aUnW9rcMhMntNCwPRuWolxAtFzUth0rJfyzoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AhxdN6InsoJfoG/kuVh3/LIepQoDMEyRerJqb65wWJc=; b=jfmLN31FrK0ZjBfCwiDaFdcpg9GA1oDOZhEwUF3FhbMfCi1A8Hy6h1UMh881cPabnJ3xgzIbqbAmQmOUPjYj5Ut1qxIlzz5Rloew6E3YopGh9rUx2CU4P4eHe56knTNjbgvkB45Cyd2lRlucIEbvAnpe6a/QFJtS1lOr8arytSE0MnU/uhIQt7NaO3uA7+N6Ojy36mw50/u2emefLZ7byY3TroF0C4HLWtOWwCdBhvwYd2NIUzqSsDd0qYnNrplTAiz6DfKPMuJSuHcw25TPrDrygCTntTyfkIQd+KGz1b45dZgoaZCBM7ye6W7SP1ZJvoRk2lLLjEqYa2cyIXkeaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AhxdN6InsoJfoG/kuVh3/LIepQoDMEyRerJqb65wWJc=; b=qzc7kswK1aZCJC3MCuXfWtwKsr/dwG7qfU9JRxkilMYhNrmBE+MLPXImmS7E9jJxqlM4reo5sCOk7SmJ3LGKpQ34leRGKxy8rXFxetZ6k9EUKYo6S0gh/2GL5pPgBp0fTfp21wditjyVDUoNzsHwbo1X4Nem200TTISxKv7I7MJ1OacT+o3Fp/HJcau03QEPi8jdwlnl8tRzgt7yom7lA7gJDRlhV367PQSfDqcECFMrBiWW1K++u7DWfouQsL+pTwp4ZfTtW+Rjcpl1PIa08MIjOmVzfklaepl3zkB4vPWzAREJc8XJ6VTlADnR7KnCrCvOWBIXE6h4CFtSOZEXSQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <053527e1-f940-2e8a-c4fb-62d787c7c858@suse.com> Date: Thu, 24 Nov 2022 09:11:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 0/5] gfx: improvements when using multiboot2 and EFI + misc Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Roger Pau Monne References: <20221123154525.63068-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7448:EE_ X-MS-Office365-Filtering-Correlation-Id: eb478770-a272-4ba3-911f-08dacdf37ea3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RRrCY4Amr3uACoQcccwNSditStP+1oHz2EykeYnm43H0ATiXlLWbB913+bkcR4gf7BPKa5Kt65al9LA4Z0VcwqCRu7TxelC4oKzMya0djcj/wNcULBTfXQokjh/HBX3LbHb/l/nc9ObDcT2rLr1Gd2jrq9zpD7t4Mz8gUlQIgA1LoLsUu9dEPXXcfrDNmanTH4ZXD8HQQRYnYtEhPJWAs8jVcnrrDVV1MvM7uCKz9/XSAB6dV2n+uZkk+1+zVVqBR3gM9D+G1hFeu0j2I0Nludh8l83JpEuqoBOkb0LckGUUUH+Y66BFFAh5JyFfGpZnOTrMZroRh7IArdBvNVpX50omcIobY8KMu4UoKcEfR2FTNFn9SPOYhjuccKI827W5cjzUcMH1qFWcgjl1BHNf2xS05L36cgj9SqjGzwy7es/pWMmmQ4zUsdQNlIstfqj9LX+YhEuyb1ridJ11ZcpsngptleGH1BkqO1G5amccyFS8tkdNZxd4hT1vXr9hxLkBxAyb6b+3Y6Z8dupr6HOJjpDTPqyJXdIA/Mmi1FlVKxPIjgW+5kYhuMt6yXYIIEZYHVPKxlbdc4cR3zsyTaqpxv2WnuGMmtXT0Xs7iUY124FDT/lcQYM9bnywCQ/EYecT3VZve88TPXyhTGw1XXrRyCPTq1C7B4QDvBSO19phcYeDiAit4dI3ozOvGhCIFf0tX5gqsHc82p6ZFnOuIkW6BHmzfREnN1hSq6P4rACS6zc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(39860400002)(136003)(376002)(396003)(451199015)(31686004)(36756003)(31696002)(86362001)(26005)(38100700002)(5660300002)(6512007)(2906002)(54906003)(6916009)(186003)(4744005)(83380400001)(8936002)(6506007)(66556008)(53546011)(2616005)(478600001)(6486002)(41300700001)(8676002)(316002)(66476007)(66946007)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rk02QVBIZlhwSWlPNzlEMWwwMVVPYVZHWTlNU25zM3ZCZTk3a20xS3RGYi9z?= =?utf-8?B?MHBJUjY2VlBQbjU0NU05MWZRNXBiVHN5bHhsR2llbjExNmZpR0xSR2RqNzVG?= =?utf-8?B?VjM0SGVNT0NhMzh2Zk1PYnQ3azd2Syt1ZldxWXVidjhUcUZqTEdjckZ4OUJq?= =?utf-8?B?SlMwU0VKQTVlNm5Pd1daOUFuN2NxSUh0d0hzTUwyVk0weGZ1N0NmcmYwZ0Nx?= =?utf-8?B?L1hzbTdFejlKcS9iWkoycWdLWFc1b3VLNkxVMk51MUlMYkJVMUc0RHZMeFVR?= =?utf-8?B?L3FSTkEvTzZzNWZiZkEzbnRkZEx6MmhDbU1kVXpkMWtWL2plNXFId09GaE9J?= =?utf-8?B?ZXJoTTBDTEhDRnE2MkdPQ3RwdkFwRUxQK3B0MGZEN0p1a25uQnhGODl2REV2?= =?utf-8?B?Z2ZwRlhqRTh0UnF2SkdoWkRoZU9tcGdPWGVzaS9oSTZGY1Z3NjVQZkVlTm51?= =?utf-8?B?QzNrQ01NVzgxZXNJalZJY3hwZTNNeEhmSnNwMlN2QnZNK2ZYVWNPRGtxYnhN?= =?utf-8?B?TytNNm5vS3FsQmlLd2hreUZETGtkQmxiNk4vNjU4T2JqRW9mSjFFSjBZdE0r?= =?utf-8?B?QTdVMDg2OUxrV2FxZWwrS1NKSU1scUwzRmR2bGxFV1BNS0FNRGM0eGdzZUtr?= =?utf-8?B?OXNoQXBDSEtEVjM0VG1pVWsrSUVPTmk0TWhzbXRCNlBqdlJXNWxNNUlEZG9j?= =?utf-8?B?c3VVS2toY0FTRTNmNFNSNWxGS1pvRDNBTTRBYUNDRDFvdkh4Y3Rqbmp0WXUr?= =?utf-8?B?eEgrb241QnFPM0J2RldyTnhxTkRleG85N1dhYytOQVZ0Mm9SejNHVUt1Rlgv?= =?utf-8?B?aVVVMjNOVVRoRG45SklTOVozM3Y2QUtwYlFYOWtuZ1ZRb1IvMG9peDJONk1w?= =?utf-8?B?STQ3MExwMmE0NkFKNUFPcTd4VVJiNlNXdEhxM253WFlCcXVGYWlEY21VZEs3?= =?utf-8?B?cXRmWnZDS25vSHdlVFU1NFhlUURBTjVMUkdwekpuc05kZ0h1a3p4L2ZENG9s?= =?utf-8?B?STRuTDFyKzR0L0FRSVNWV21Vd0doNzhORm1icFN0OUd4U3FiMlRWaTBiK01i?= =?utf-8?B?WHVVd3o3MEcvanVHcDRnZ2NNNEZNdHk3bkVkT2JIREtpYTNrM0FGNE5pWHVI?= =?utf-8?B?WkZaVklMWGJnNkt3VUxEWmNVUHE3SUc2ZXQ0emdraks4cno3czk3c043RlBu?= =?utf-8?B?WVBOUnY5aHBkaXY0dHlxYXZiREx6UFVGUHh1Z1BxN21tZWgzSWZFQlkvaG54?= =?utf-8?B?OFZKN05aVEVIUnE3L3JWOXlLZ2JNdUxKUlE2dXZHSmxkOVozSWtqYXVjemdS?= =?utf-8?B?NWhlbWhQMXBSM2Zzb0VPcTlQQTJCa29RaEprOG11cnFWREcxWkhhOThUa1pO?= =?utf-8?B?dTludk1Wc0srU1ZpbWVVMnh4M0hzczNHNGFJL05tUFNGU3hEeWpEZzY4N2Vw?= =?utf-8?B?cUhxUDR6ZGlBZmZ2MTZmR0oyOVR1cndzOGY0MDl4UnE0VVUzelJ6aWRYYllJ?= =?utf-8?B?QUhvT013R3JwalpmQnA5WXhkTVZ6bTdxcSsvRWppeDdYTnJtVXdOQ256YVYv?= =?utf-8?B?V0lFNGhGK3pNbmV5VVIrUkNDUGZXNE1oa1lRWnVsdXNmWkxlekJ1bDNQRmlw?= =?utf-8?B?eHJPR2JubXl3L000MExJdkpaYll2bU9RWTN6b09LeEJCZVNIVjFlVVJqZ0c3?= =?utf-8?B?c1NrNld2bVFmbE5QTkxuSE01QjcvRERqazRGNUpmUEtTT25hWmptamM3ZUhH?= =?utf-8?B?M1IxYlUyU2JGaUtNa0RqcnVsSGxqYnVPN2JJUFh0RkRMNjJwSWFvMGlhMkxO?= =?utf-8?B?bHVNWXI0YVhHaUVoRWxwVDBlM0xqVGFINEcrMGR4QUFiZTlzc0tSR2UxVDQ5?= =?utf-8?B?Mmt1aFo1ZDQxdi9WRVVFRlFJeWtCSllSR0hzL2hSbFNHQ25naWt2ckNWL05K?= =?utf-8?B?Q25pOUpBN0VrbDVPQ0NzVXE0NmozZXpLTWhqMXBCZkVaVUtTMHI1ZFdXRU5Q?= =?utf-8?B?V003UkJyM3FEVXJ2QXhCcHdZR2x3UE5LQjhnL0lOU3drYVZSVTA0YkpPVks0?= =?utf-8?B?ZW1CdzlJRk5KT0hFS2d5Ui9URE1nTFNnZkg4dSsybUFlSVo3T3Y4M0YzQk5G?= =?utf-8?Q?gy4kE/2f55AhbwV+xa5Fto70+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb478770-a272-4ba3-911f-08dacdf37ea3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 08:11:31.2835 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: He+iwet75v01WTXUVVf5RLENv9mNaETLnR68t9jxZ0afPZGbTyeZ64CNX3HnQgeq//d2VwSKYqXq1pxJPibBAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7448 On 24.11.2022 06:15, Marek Marczykowski-Górecki wrote: > On Wed, Nov 23, 2022 at 04:45:19PM +0100, Roger Pau Monne wrote: >> Marek: after this series using console= without the vga option should >> result in Xen not attempting to touch the selected GOP mode and the >> screen not getting cleared. > > Thanks, this seems to work mostly fine. > There is one message printed from setup_efi_pci(): ... ROM ... bytes at ... > I'm not sure what to do about this one (although for Qubes, I can simply > patch it out ;) ). What's wrong with that message? It's not directly related to gfx devices anyway; it merely happens to be the case that gfx devices are the most common ones to come with a ROM. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 24 08:43:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 08:43:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447820.704461 (Exim 4.92) (envelope-from ) id 1oy7p4-0003Ga-41; Thu, 24 Nov 2022 08:43:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447820.704461; Thu, 24 Nov 2022 08:43:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy7p4-0003GT-14; Thu, 24 Nov 2022 08:43:06 +0000 Received: by outflank-mailman (input) for mailman id 447820; Thu, 24 Nov 2022 08:43:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy7p1-0003GN-PB for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 08:43:04 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ff4207ba-6bd3-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 09:43:00 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Nov 2022 03:42:55 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BL1PR03MB6071.namprd03.prod.outlook.com (2603:10b6:208:31b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Thu, 24 Nov 2022 08:42:46 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Thu, 24 Nov 2022 08:42:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff4207ba-6bd3-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669279380; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=0z4LmD34i12+UCVrk3eVM72ZarlKTHU7MChVujVRXaE=; b=dnk3g9VsBPIR9RCixG5VjvjJZ66MQyrub5+UKQLuYc1LCPGM4bhalcpX nj8ZBrMxfueC7ev2ca/sI5xT0T2QhVo+1na9AUyH5KigC8k6V52ZFH/GY 1WHVpdQsmuZY3cGByNxBNqsY6vreSQ8CHDnjf0ZgLNAPRIHzZsB6/8WA9 U=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 88016979 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:OiJxj6ADV3acPxVW/xziw5YqxClBgxIJ4kV8jS/XYbTApDwq0TRVz zMdCmyEOavcN2P9fdpxPoS+oUpTscTSz4Q2QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpC4gRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw3bopAEdWr dskCBcpQz67grq7zKKfRbw57igjBJGD0II3nFhFlGicJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9exuvTi7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLVoir12L6QzEsXXqocEeyF2MJjv2a1y0gcDBo1Fkq3q9aA3xvWt9V3b hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JPF8Uq5QfLzbDbiy6BD3UAZi5MbpohrsBebSwn0 BqFks3kARRrsaaJUjSN+7GMtzSwNCMJa2gYakc5oRAt5tDipMQ5iELJR9M6Saqt1ISrSXf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxode51knHpU KA4pvWj IronPort-HdrOrdr: A9a23:t5aFJaDSOYcWIrvlHejMsseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d enl7x6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDKw875BKIhTaI7qe/NxSDxB8RXx5G3L9nqA H+4kbEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJptkJJi7qggOIYp0kf7GZpjg6rMym9V5vut jRpBULOdh19hrqDyqIiCqo/zOl/Ccl6nfkx1PdqXz/ofbhTDZ/L8Zan4pWfjbQ9kJl5bhHoe p29lPck6ASIQLLnSz76dSNfxZ2lnCsqX5nteIIlXRQXaYXdbcUh40C+0F+FosGAUvBmckaOd grKPuZyOddcFucYXyclm5zwOa0VnB2JRuCSlhqgL3h7xFm2FRCi2cIzs0WmXkNsLgnTYNf2u jCOqN00JlTU84/d8tGdak8aPryLlaIbQPHMWqUL1iiProAIWjxp5n+56hwzP22eaYP0IA5lP 36IRxlXFYJCgLT4PC1rd52GkinehT+Yd2t8LAT23FBgMy8eFKxWhfzDWzHkKOb0oci64PgKr KO0altco/exFvVaPh0NjLFKuhvwFklIbkoU4UAKiWzi/OODLHWncrmV9uWDIbRMF8fKxDC6z 04LXXOGPk= X-IronPort-AV: E=Sophos;i="5.96,189,1665460800"; d="scan'208";a="88016979" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FNrOSjcYIUqsonhiiol863pV34s+JcwFjWecNje51fY/b1HSm5DR2b9ew9AfkZs3P84hk8p0W7Oidau1zs3u7p5yaea4PPPewQKK5UVgygQ1T3asQTEasOwWMHy0vEfJomNeu+4r28FNx+o+wV50TxYXe/vmxu44LGoBJrB0qmtAQxtIGUNbqx5JeNiN8gZVFwt3hR+Pvx40aSATGoPubBzHJSSx3HjkWVqOdAUBGsvqvW3pCVKjrKxctgtwldtjNsDUz8GTQ99jCUYKYbFkiE+zQexEms8P1qAAtOJvbYa35ITrqWeliiOCVrzg1591zXPWJSn9uU9CpKuEoTDAGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u8PUPNE2sewrawSxnsTAXyCLTgcWWuJXKdO2qWA8zXo=; b=Dd0pUXzjFYZQQJpaBhgKwUxUyr0YoKsjSmz8lNTKEtlg+TQQklmHwb9bsvAo3R3buxh2qmGWpTHOhajuRC+7zLGeLNzzl1URGmGS2AOOs0lRR77xBTgH+YBNd0ua3B8MCbmmvEmJOuokwmEJ8208zrJIBC1wsibv3vGFKfCMDvOgm03ubmXDDD513JL+PZgpgt+/ClP8JfGK48lX7WTcZI+/fFXmdwk/FEa4sRhRH3IxjCyoZ8gfL4E+OyDs1Kj7xD4/ol9ZONhb1apqpMlq6HNLpbzhqHUt2907Kcmw58lrV8q4Pwb9KKLDJdi9laz/D8OWnGWMNRcJCsfaUFcspg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u8PUPNE2sewrawSxnsTAXyCLTgcWWuJXKdO2qWA8zXo=; b=CMEwx8kByEh3jASq6jWPZrVQci1K7x5Us7l2kEpV/oZaD4gNORhynOlUInRY+buRwg157KLV34A+27NX/qCxR85SeE+PjOt56rwpNlere1yYotttd383kM/F2q+lFPz8f2CjAezSsmxvjF6Y90LsFEdiBHhWeGvRLSyYkQBkVlo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 24 Nov 2022 09:42:40 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Message-ID: References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> <5a2df843-1acd-ad78-baff-e47befd0703c@citrix.com> <878e635f-b116-3580-945f-f8acb711a5bc@suse.com> <69507b8d-1f31-39fb-7469-e240fbfdde44@citrix.com> <33a005bf-0596-c624-0e70-077a450ac2ae@suse.com> <351a6e54-8002-aef0-993a-c6b8bdcc1e8e@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <351a6e54-8002-aef0-993a-c6b8bdcc1e8e@suse.com> X-ClientProxiedBy: LO4P123CA0409.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::18) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB6071:EE_ X-MS-Office365-Filtering-Correlation-Id: 910430c5-3d86-49d1-1a90-08dacdf7dc15 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 72/1iZc4/U3oFWb+Ee1E+yZq+JiPYwwfPGvs43b48gu828iy66Dq3NjTP0u+gltAdndrllqt46wqKn4Nyf+kikW6rD8H3tvrkr6jEH+u4oltHE2iW3Epo91jx4WMRWSuM58STNHPJ4uTWuUVrKA1QJ0DBLz6deMcpxhHs3NeC3liTTffy4EOd2Tgs69FCLF6IxzstInVOoFH/bSIE5nWO8oH0tIIhU1ZSg+3j8ojzifg4mp1nt5Xow0nmzaBgAKntCYYa1gYY1V9ExtviFLLrESwaZ0q4FeU/x0XYNm/GbkGHBnw5mCss20r6yEHxfzkjpDWcTwfsiYn8ZYxIiTSW5OlEcGHkrfz/MZypGtn83iVhQUcN7QH2DN4ySTyXas73ZL01Gp+BXf/MTm+WiuAnD8fM6PTZsOFd9xrubC5L6wqUSJUuKnY2za+Pm3BtW+Gq3043FtdV7mVI8I42msV/KcVzj015nf/795Q9AIx2mbyzTJzUQSNH/SlbtyaYmZO2IH2qIHPCK2kPBcPgUKl0WLDVgs4FyECbe1HKp3Nr+uB26MN6NRSHJwdBYjDSz/X9qDuHxfA9xLRspj5l9sodeBzCWI/0uivr9IfDj36zvhJy3VxejiOh37v1s4SyRxj4wUcdZioM/yyD62YThiq8Ude/vJi36i0GnJnhKLWD9k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(346002)(366004)(376002)(39860400002)(396003)(451199015)(83380400001)(6512007)(26005)(9686003)(186003)(82960400001)(38100700002)(2906002)(5660300002)(8936002)(33716001)(966005)(6486002)(478600001)(6666004)(6506007)(53546011)(4326008)(66946007)(66476007)(66556008)(8676002)(41300700001)(316002)(6916009)(54906003)(66899015)(86362001)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUJNQUF3TThXNmVsRGZYd0pPZ2g4aHJXSkhVY3hEZ2h2d2p2Nm1KcTQ0STZN?= =?utf-8?B?NGVDcUh1SDhUckx2eExEcWF1L0Y3dW1SYkhpSVJacFprS2VMYUVLOUVuWGRU?= =?utf-8?B?cTJseTVMOUhxbHVXRXdrWktrR0VMYVhaNXpYOEo1dERKbUpKcTE2dUJhSDZz?= =?utf-8?B?Ymw5dlowM1FSZTlBOW5IUjRFWVBaaFg0MktCNkpIVWcxK2VlYW1zeHVSYUJI?= =?utf-8?B?MGF5U080RGhtV2dZOFlKZTl1c3NQUXNGNUE5Z0ZnZ0dST0Qvb3p5dVhXcVJG?= =?utf-8?B?clAyM3JmL1BLV0tTSWZoUXo3K2RYNXdWM0tRcGFOWnp4eUtYRkNNcklWTnow?= =?utf-8?B?YWl3YUxoVXZvaTZOV0NlTzh4eFZkVU9KVlRaMEtDdWpCK252QTNDanp2NTdm?= =?utf-8?B?em9Galp1cHpHZXV2bTVOQ2pjM0hFZ0Jzb3N2ZlJHMFRtNlF0VGVQK3dkNFZR?= =?utf-8?B?RW4rVjRyNXJxSkJnK1FBelgxUDJmMzR3UDdBc25SeHBqRVAwYVlZQ2piVXIr?= =?utf-8?B?emhWZS9JcnY5bUZldFRMZ29hMmdZOENmNnNNdmRGYS9aeFR0bStjZjFkQzJw?= =?utf-8?B?Z3EyeUszSzUvTWJIUTRoK3VNUmhaeTBiVEVIN3F4Sk82MG1sZTdkVEpUVHhv?= =?utf-8?B?S013c1BJeUdUdVV3bnFjRzhOMGQ1c0ZqeEVZcEs5b2QxTzErcWpvNnM5MkJO?= =?utf-8?B?U1EyOHFGNEhwbllreTdHaHZ4Q0M5Z3N5c2o1aVJlR0tPTEZsdGNHZ1pxOTVj?= =?utf-8?B?SjdvcVE4TUdlMHZiS1Rzc3lPdVloZWpJb2ZBaUpPR3VLN0ZEM0FYQndFSjAx?= =?utf-8?B?QjlST0M0d0xVOVo2NWd3aldrZXlOVWxmQ25GUDhIdjRNTUdOVjhrYVo5dlYw?= =?utf-8?B?QUs2WnJ2SVlUNFJTZXRVc3NkMDdDT0VSeUN1Umx5cWlkdE1uZ3Zyc0wrTWxo?= =?utf-8?B?SlA5UFJvYk1Wb0xTTUM2YjdaTGlhaU5pUWRDandxb21UUlpOdFA3YW11b1Bz?= =?utf-8?B?TUl2dCtSd1YrZ3g0c2QxOGVUUG9HNUhWTzdVTTJMWXBQY3BwUnlMWW9WV0Nn?= =?utf-8?B?bWhIeUY5S2xpUENCVkM5bVU1MFh3ZExRTVBzZHYrN1dhOW4vRGFZdWEyMCsz?= =?utf-8?B?MXk0MW5GdE1KalB0OW5lU3Y0VWJIakNuc1BYKzdZaTdOaXp6VFJWN0FnMlh2?= =?utf-8?B?VmpHYVZTY0w2SE1UM01jdk9OZERJRytlclBzRGg5R3pieUcrbjhmTWpwYTRN?= =?utf-8?B?cHZJYzlEelZRYzFxZ29EM05DT3NYdjlXTXNCaDNodk85bzUybEFsSXBCTDVv?= =?utf-8?B?eURUME9GQmdCNFcwNnBIQzNRMkNvNWpOejNQeCtnUm5sdjROU0xRYWFKVkRl?= =?utf-8?B?MExOaU5wb0dVTHdSNFczRFYrMWE1cDdvOW5KNWorUTlmMVBmVW04WW1zK3N6?= =?utf-8?B?dEFqdnhTZ3k0cHZiWWROaXJJWnFuL2pFTEFsYVlOWDViSEVHRFRSdk9pWkRh?= =?utf-8?B?RVhXbzBWR0JEdUVVdUFTb05vT2g3VnNZSm14STA0MFY4dFF5YmFuUGQ3SEp2?= =?utf-8?B?SXhvdHBNdTU1ZDJOU21KUTFPVlpHaGNCQTQ5WHYvOCtJK1VNMEJuSS9sWVFm?= =?utf-8?B?QVREMGo3OUx3SVJxRlBwaW5UeHB1dmFQbnZlcXc0dEVNeXJnMGFsV2dQby9X?= =?utf-8?B?b1RmaXkrQXJtTU5UdUxoVDljWHNjRlNNT0lZWHQwTERwZllNUlJRY1F4enM2?= =?utf-8?B?Ukl2aHNVOW04bTEzU2NZMUd4Q0dxNWVoWUhkYzVhcEFrT3ZzOHNyNytLcmdq?= =?utf-8?B?Z1Z6ekdDbG92aFZYb2twRFJreUhpSlNPM211OG5TWkNGb3JTMm5rQmxOenh2?= =?utf-8?B?REhIZXBzQUZZeER6TU1tbkg0bnIyZ2VXdGR4Q3NWV0ZYSSt3TjM2QzZTV2Ny?= =?utf-8?B?QjQvMHNJblRJTUMwd05vdDZmQVB5S1htRndjTzVVRVRZUWUwVVh1SHdXRDdN?= =?utf-8?B?R0xNZTFySUpRaVhrc3lESUo5QTJ0QjlybW1vekVPTGpjM2tVUnhPY1o5ZFV1?= =?utf-8?B?cGp2ZVh1THpvMThoN2R6RVN6UGZraDhsTCtPMDVOU1NhNk5IZWFMSTZ1RXR3?= =?utf-8?Q?IHynbHHopR0YNw0svMsqeJ81C?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: GmLRizlKOkKyYINPrBdc7OntDZWb1eYtFBlFQvyTazoJjSD3b6IsQyC8OVqyd92OGFkeCTj/q0CPTvHhwanTvAPNCzFoOiVXJx7g4HMAxpO1FMkjwXE7c6LSB5y1JmPyNPCi+r0oUlKEAcC3zIUX7ziHvTzqcNHRc4YflDiRuU48GUkgowdoBwVDsmO9bBBFzVaKNK7NX0HSagP0kL3lPo020OEdKWFhHYPgx7tXTa2jtCnNSW4KocD9/VUQ4a4CaRqydymkT4VW5iNPRZ33J+ir4rp16kYfOD9+V3VcOA7b2v02/YJloQcHArq5wWdZdpwXL99cwtzrIGNiKc8wPYY6rnSiebyMHYabr89/cqorC/lUjFeByB72o4M10ZygJaH2aW2jHECog71AkPebk3NCqpLjqmGzN1s7e/LNnNavfcVOvdhMUO9sosQKign6ORDcO+0iAiz4r34c0JC/LzpFCHFQrxkJGZzWe3aPUY+JhlHHBNk/MzR1/pNsCcM+bKoKNngc9BrVOBV9gwWuSPBL1Di/yNmH7nwpK0AxmxoHoV6UH3xWh177H6SAachYBDu9HVbZ8KFYVQwoJV+cpmWvxbBUY9hM4hJOyuQ+6GxOLcaMkfmpuJUGl3LZHGNX+b2pDzhSZAtK+a3+Yz+jp4rkO/WD5pyv+vAhvd5fHXMGdT4bTcZbNL82mkGIxVi1psvLOJnVcNdEI3mGlOEFs2fgkGf0jfJbye0zt4he6/zmjwQtlLFDdciCTN32hV2WOt2kRFf029O3Wb3rFBKGqBil7+91bBkpzvCeG1EJAC3t50g8Ig/UsUL7LO0crljsoh140yvMfz0sFeyLnzJBaPDse7r+iLveP3h0VdMGawI= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 910430c5-3d86-49d1-1a90-08dacdf7dc15 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 08:42:46.4332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F2WKkJcoIV/yZCLp6pdxRO1mp10Q3T+bYb3SBZVsNWWHsUvQMp5fJrSF91QR11GLLxu7YcbZ5ETrXTEM88vE7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6071 On Thu, Nov 24, 2022 at 08:59:00AM +0100, Jan Beulich wrote: > On 23.11.2022 13:03, Roger Pau Monné wrote: > > On Mon, Nov 21, 2022 at 01:34:38PM +0100, Jan Beulich wrote: > >> On 21.11.2022 13:23, Andrew Cooper wrote: > >>> On 21/11/2022 08:56, Jan Beulich wrote: > >>>> On 18.11.2022 15:27, Andrew Cooper wrote: > >>>>> I even got as far as writing that maybe leaving it as-is was the best > >>>>> option (principle of least surprise for Xen developers), but our > >>>>> "friend" apic acceleration strikes again. > >>>>> > >>>>> Xen doesn't always get a VMExit when the guest clears SW_DISABLE, > >>>>> because microcode may have accelerated it. > >>>> But as per "APIC-Write Emulation" in the SDM we'd still get an APIC-write > >>>> VM exit. > >>> > >>> Intel isn't the only accelerated implementation, and there future > >>> details not in the public docs. > >>> > >>> There will be an implementation we will want to support where Xen > >>> doesn't get a vmexit for a write to SPIV. > >> > >> I see. > >> > >>>> If we didn't, how would our internal accounting of APIC enabled > >>>> state (VLAPIC_SW_DISABLED) work? > >>> > >>> It doesn't. > >>> > >>> One of many problems on the "known errors" list from an incomplete > >>> original attempt to get acceleration working. > >>> > >>> There's no good reason to cache those disables in the first place (both > >>> are both trivially available from other positions in memory), and > >>> correctness reasons not to. > >>> > >>>> And the neighboring (to where I'm adding > >>>> the new code) pt_may_unmask_irq() call then also wouldn't occur. > >>>> > >>>> I'm actually pretty sure we do too much in this case - in particular none > >>>> of the vlapic_set_reg() should be necessary. But we certainly can't get > >>>> away with doing nothing, and hence we depend on that VM exit to actually > >>>> occur. > >>> > >>> We must do exactly and only what real hardware does, so that the state > >>> changes emulated by Xen are identical to those accelerated by microcode. > >>> > >>> Other than that, I really wouldn't make any presumptions about the > >>> existing vLAPIC logic being correct. > >>> > >>> It is, at best, enough of an approximation to the spec for major OSes to > >>> function, with multiple known bugs and no coherent testing. > >> > >> But can we leave resolving of the wider issue then separate, and leave > >> the change here as it presently is? Yes, mimic-ing the same behavior > >> later may be "interesting", but if we can't achieve consistent behavior > >> with yet more advanced acceleration, maybe we simply can't use that > >> (perhaps until a complete overhaul of everything involved in LAPIC > >> handling, possibly including a guest side indicator that they're happy > >> without the extra signaling, at which point that yet-more-advanced > >> acceleration could then be enabled for that guest). > >> > >> Otherwise - do you have any suggestion as to alternative logic which I > >> might use in this patch? > > > > Maybe the underlying issue is that we allow executing > > HVMOP_set_evtchn_upcall_vector against remote vCPU. This could be > > solved by only allowing HVMOP_set_evtchn_upcall_vector against the > > current vCPU and with the LAPIC enabled, but I guess we are too late > > for that. > > Allowing things like this ahead of bringing a vCPU online can be > helpful for the OS side implementation, I think. I thinks it's more natural to do the vector callback setup as part of the CPU bringup path, like any other CPU related setting that need to be applied, but I guess that's a question of taste. > > Actually, what about only injecting the spurious event if the vCPU is > > online, ie: > > > > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > > index ae4368ec4b..4b84706579 100644 > > --- a/xen/arch/x86/hvm/hvm.c > > +++ b/xen/arch/x86/hvm/hvm.c > > @@ -4105,7 +4105,8 @@ static int hvmop_set_evtchn_upcall_vector( > > printk(XENLOG_G_INFO "%pv: upcall vector %02x\n", v, op.vector); > > > > v->arch.hvm.evtchn_upcall_vector = op.vector; > > - hvm_assert_evtchn_irq(v); > > + if ( is_vcpu_online(v) ) > > + hvm_assert_evtchn_irq(v); > > While this would match what hvm_set_callback_via() does, see my post- > commit-message remark suggesting to key this to evtchn_upcall_pending. > Tying the call to the vCPU being online looks pretty arbitrary to me, > the more that this would continue to be > - racy with the vCPU coming online, and perhaps already being past > VCPUOP_initialise - after all VCPUOP_up is little more than clearing > VPF_down, If the OS attempts to setup the callback at the same time the CPU is being brought online all bets are off I think, and the OS gets to keep the pieces. > - problematic wrt evtchn_upcall_pending, once set, preventing event > injection later on. > As you may have inferred already, I'm inclined to suggest to drop the > the is_vcpu_online() check from hvm_set_callback_via(). > > One related question here is whether vlapic_do_init() shouldn't have > the non-architectural side effect of clearing evtchn_upcall_pending. > While this again violates the principle of the hypervisor only ever > setting that bit, it would deal with the risk of no further event > injection once the flag is set, considering that vlapic_do_init() > clears IRR (and ISR). That would seem sensible to me, and was kind of what I was suggesting in: https://lore.kernel.org/xen-devel/Y3eO0bMKRPYJc2yQ@Air-de-Roger/ Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Nov 24 08:59:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 08:59:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447824.704472 (Exim 4.92) (envelope-from ) id 1oy854-0004ya-Ds; Thu, 24 Nov 2022 08:59:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447824.704472; Thu, 24 Nov 2022 08:59:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy854-0004yT-B6; Thu, 24 Nov 2022 08:59:38 +0000 Received: by outflank-mailman (input) for mailman id 447824; Thu, 24 Nov 2022 08:59:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy852-0004yM-Dm for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 08:59:36 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4fcf2ba5-6bd6-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 09:59:34 +0100 (CET) Received: from mail-dm6nam11lp2172.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Nov 2022 03:59:31 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BY5PR03MB5000.namprd03.prod.outlook.com (2603:10b6:a03:1ee::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Thu, 24 Nov 2022 08:59:29 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Thu, 24 Nov 2022 08:59:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4fcf2ba5-6bd6-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669280373; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=aUAm85AP7F4TtH0SInje/cZasXEJJO5WCbO3yxakTSQ=; b=UTe3bv6yechVvRRqm5ThANqsu3ik4+kWeWPEkKHivKez3Bj93bCsWzMQ GR0TfJYWMVCbht42Cw6wmFQmALxNTzoFx2DyCLfA79COpPNFTjMf0Lli7 V5s/6KEh3jm2NFytHsjbjZN8pW20JeB6sd+249j8aY92K6Pl+zw6g9vdJ k=; X-IronPort-RemoteIP: 104.47.57.172 X-IronPort-MID: 88017872 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:cY16OKomQzQ6iCthq19qPO9uSZZeBmL2ZBIvgKrLsJaIsI4StFCzt garIBmGM/7ZNjakc9lxPYzgp04D7MWEyNNjGQRkpSE2FixGoJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzSVNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADomYSKqjPiu+uuqFcBJq+9kCOe7LrpK7xmMzRmBZRonabbqZvyToPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeeraYWPEjCJbZw9ckKwv GXJ8n6/GhgHHNee1SCE4jSngeqncSbTCNJKTeLoqaQCbFu7gV1LKz4zVkOHiuibumGFZNheJ UtL5X97xUQ13AnxJjXnZDW9qWSBtwQRWPJRFfM78wCHzqfI4wefCXMARzQHY9sj3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqTS0OQBYB4tLjiJoulR+JRdFmeIaqivXlFDe2x CqFxAA8mrESgMgjx6i9u1fdjFqEvYPVRwQ44gHWWGON7Q5jYoOhIYuy5jDmAe1oKY+YShyNu SYCks3HteQWV8jSzmqKXfkHG6yv67CdKjrAjFVzHp4nsTOw53qkeoMW6zZ7TKt0Dvs5lfbSS Be7kWtsCFV7ZRNGsYcfj1qNNvkX IronPort-HdrOrdr: A9a23:2DtKlKoCz25dMZls1U7fndUaV5tLLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/ Gnl7d6TnebCAIqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LoSK05KX8Gx242A5bdz9U278t/U XMjgS8v8yYwruG4y6Z81WWw4VdmdPnxNcGLMuQivINIjGpphe0aJ9nU7iiuilwhO208l4lnP TFvh9lFcVu7HH6eH2zvHLWqkLd+Qdrz0Wn5U6TgHPlr8C8bDUmC/BZjYYcVhfC8UIvsPx1za oOhguixtJqJCKFuB64y8nDVhlsmEbxiX0+kdQLh3gadYcFcrdeoaEW4UsQOpYdGyDR7pwhDY BVfYjhzccTVWnfQ2HSv2FpztDpdnMvHi2eSkxHgcCR2yg+pgEN82IogOgk2lsQ/pM0TJdJo8 7eNL5zqb1IRsgKKYpgGeYoW6KMeyLwaCOJFFjXDUXsFakBNX6IgYXw+q8J6Oajf4FN5Icuma 7GTEhTuQcJCg3T4PW1rd12Gy32MSaAtWyH8LAd23E5gMyxeFPTC1zDdLh0+PHQ5sn2AaXgKo SO0dxtcrvexFDVaPZ0Nj3FKudvwEYlIbwoU/YAKiazS5HwW/rXn92eVsrvD5zQNhthcl/DIx I4LUvOzYN7nw2WZkM= X-IronPort-AV: E=Sophos;i="5.96,190,1665460800"; d="scan'208";a="88017872" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZzugABqtD+ghIADzLz79sPn8IilRWo+sqFLxpwKlpzAQscIOnkeO+WQIKybih6hfibuLH/gOfcyDy93oChbbV8D2TZzuX+UYbw4umMtU/1D+F4VC8GLLRHI8Y+xoFHj74UqhR4JCK51ROx1ICNxSeohDuFwCoAduHtQVoKDANwwddW3ku+f/Jab3CLxvgjr3jhLAs1s3FVGA6LfpSI0LBQ5IoZ403VUdlr0SGpoGFAQCPSMYtKDiD38g6XyXH3BNHX461/k2x+mmk8j6Q0rgB+h+VFU352sfEvSIwOHeLySaMz+PdQ9KqLJ2sLhk0xm04IMhUIlwjpo27Mihaec9rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S7qlRv8DTdiiXdS1F4gRPtTOOlq5vl/LzIYkg3Wwdfg=; b=H+whRUY381YaKY381r9wP+qJ7nEXh/lJWD0Tbf2ryqOc79GHekqAxBkBWvQofJjbi94cKA8F+sAacIAlHw8q81WtmHCPe5eZQeZhxrYVdldH8f+5TFHq4sgyz801srV8NxCjksCRDjm60SJIOi5TNrq/wTqO5sogI7ClAykPcFs1Hja7ZXMB0FEZeN7jA6F+l8bwCT/Psl15uxZafQrZMtpmA6C3YyHnvaJEB8z8ccIsDa6/LGgDPfnkUPQ3rd5Wr/rBattr3Vem8+80vAJOaWqU+qih/KAzvW6ViQTlKqsdHF7Dr0pS/Sx1HzSCtc+Ya/jnb1CxMlNTYcXpdcm68g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S7qlRv8DTdiiXdS1F4gRPtTOOlq5vl/LzIYkg3Wwdfg=; b=fP9JZlVQqGYp72aYyjMJzEZwOEsBWnGXBrYKBLsXZKjEWjTv2XBz0gbEkDxFB+cO/I+51bifB8ESfMdu8QcPxoC1UWj+LL2Kllg55Kfmo+euTSHZ6Hq3KPcmDMgX5EHzXGEAneu5mS3cidlBthFt4fTTbkJsedACNFGG1255XzU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 24 Nov 2022 09:59:25 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: Re: [PATCH 0/5] gfx: improvements when using multiboot2 and EFI + misc Message-ID: References: <20221123154525.63068-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: BN9PR03CA0849.namprd03.prod.outlook.com (2603:10b6:408:13d::14) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BY5PR03MB5000:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f74047c-a230-4de8-da23-08dacdfa31fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oQ3zYnA0BEpkHzjn6+FGqyDTFj8bCS4GWyhxWuKuxUtaONvOewj/S2D8DVanzGifkC3GZ+NSleKzauZ8RjXqK9BSR+uJaKW1rKd904/wJtKianSPtdABwz9mDdyq57h/9U9KtONU+vUieYIBP181ulgycHzvOch/brj0JiEoATxg3G/NQIs6UcCWp69L18mlkKV8TBnHtazVGFVeUdlM7MZmoVsAmjogXVAkmO2GWUP5R+QraqivfHkSCvIRgUaCd8otuW+w40fIifbcUVzfcGPeomqnkFrcUKElD2UhZS7gIokWMy8Qo+Z/Xi4G4+BpMGuvz+0e8rH8LfP6JLM9cnA3SCfWks0TFKLBIBolyO0dDfvn7TqRNcaoU4mps5zsVIcfc1wPKBg11fkmHJlq1G1xKHU6qVrwSn0YduTuHhRLXxgxqsZH6qIAPKFEL+87zgJG8RqA0JuMLoRjHvEalvBxvQDIx67P+lDXflSRYYpUbA2hRk43Qpe3zppf2NOg3lZcbKVG4qC/uxl86aHM1JzNJplEKKUWB8ufPxkRAPawR2UlbsqsLHsTG+ow3jKCNp1+m+MDSR/tEIcGf1316oV4/hBaXkbF/+dT2AC+NO9kf/Oe3wEPiIFW1QBlPwFBjVxMC2xKn1HPc4QqMzHb4uv/Fh2uP8h9fFKA3HleeXc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(376002)(346002)(396003)(39850400004)(136003)(366004)(451199015)(6666004)(38100700002)(9686003)(82960400001)(26005)(6512007)(478600001)(85182001)(6486002)(6506007)(316002)(966005)(86362001)(66556008)(5660300002)(66946007)(8676002)(4326008)(66476007)(41300700001)(33716001)(6916009)(54906003)(8936002)(2906002)(186003)(83380400001)(66574015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SS9FS0FodHdLUnJoNkc3NTZGVXAyT0NWZG1QbUl3R25GWWZjUUFld1RsNG1p?= =?utf-8?B?SStob1gvNHQya1RWZHBqanBJL2ZUMXhBK25iVFQ0VHBoNGh5SWMzbFduT1Fy?= =?utf-8?B?cTN1aWU0dks0Z1lienRXMC9jZEphT2JSeWVyU3V0eFJYU2V0VWhpZlBuSWND?= =?utf-8?B?Q0FWS1RlMDhQUzEyb2V6ZnVuMGZodFhLS2FGWjhUd3prcjI2aXVpVUx5OFdo?= =?utf-8?B?OVUwOHBuNzNHM3pKQThIZmx1SzNubytmaWhqMEJ1dWRlVnlhNEEvRXNzWUVD?= =?utf-8?B?Q25oTldmM0FBOXNMKzJuc01oQkFtUFJTWXpHNFlrQ3UzeTdEY1lmZVJtQnZp?= =?utf-8?B?S3dSaE5rNjBRdVFMWW1KQkZKa2J6eDRlQUErUmxtUFVTR3pvTEhaNXlJY3h1?= =?utf-8?B?OWppRWI1T0JBb21uUmsvZjRueVFIL1BPaTdSbzZvenQ5U1BDTGpCdWt2YnJm?= =?utf-8?B?blRGdlRhWWg0dmp5UjJ6Y0RwUUJvRVQrNTg4VEpHWW81UWdlMTJTZzdpZmIz?= =?utf-8?B?SXZKRWx4bGJBdGo2Sm1UbHdWTDVQTVNmMC8ydXJWL2kwYlJZRHlIbnhGa2k3?= =?utf-8?B?Y1pTN0ZFT2svMU9GNE1aeFVpc29CeFcyc2gzWm1nSFhVb0FTcnB5bFlBQi8r?= =?utf-8?B?Z2JVd0VyN1UwL1VXdjlGNXZwVU9mb0pySjllaEdJYXNWc1JrYjhCcWx4ZCt3?= =?utf-8?B?T3p1SkRVa1VYWFhuNnpSM0VRSXpEaktmVW9aT2NoOGtsempkbEtoZnI3NENG?= =?utf-8?B?MTA2U0paRldXMnRORVVRcVc1QStWbnl4TzQrb3ZEbkJTQXlWaWhiZXB4NUJ0?= =?utf-8?B?bmdJTW1wYlZZeEJveUNFbVhoRkV2Y05LVDVYM0Rrd1NxYUFGV3B3TVlYaXpX?= =?utf-8?B?eHcrbWZtNVk3RStqRDZEZllpRFB4TFVVV1cza0hZZ3ptOTdOa2FiOCtINTh0?= =?utf-8?B?RzErTUNXb3k0NE12aFVMZllsdFVOZDFUamtsMTBjK3VDSjlJMTRYeGJYakhI?= =?utf-8?B?c1d4T2czeUxMUXd0Z3J0REliY1F2a0ZJMDZvWFJ0Q05LTERpWGxxdzMzY0cz?= =?utf-8?B?disxSkFpby94U1g3S1JidndxLzRLSEw5aXdSbGNYYi83SjlMcDRNRDJ6Wm5Z?= =?utf-8?B?VGErZDhVWTlJWjRyQ1VFYlBzU0hNbWxMNTM0M0hKbWJMU3hxRytyTGxWYU1X?= =?utf-8?B?SkV3dktBbHNLK3RPUXdmd3FLcEpkZlM3WGtQU2cxckFWanB0aW5SRWMzRE1x?= =?utf-8?B?REV3cnZONHdVOTVkYUpLY2RRZndEUGNjdDVCL1F5Y1hkakxoZll6Z2pOYzhn?= =?utf-8?B?NTB6UTNVUVVDZDdNRUpWdzBQNG40WkFDZ29ncTJUeEwvTVhxdGdtRFlRVWVv?= =?utf-8?B?UFdRb29WNUZ2WlMrQ3VWY09BcXBYdmdhRHcrVWthRlh1dWZhNzFRdGJKcGJW?= =?utf-8?B?STVrM3R1SFBBUVJwa2krdUV6UHJmNis5YlRiWlg5aFo4WFpWMElOdE9OZkJk?= =?utf-8?B?SXVtTTI1anNhanZkU1RDbmF0bFlKWFdQTkQ4dVJPVzNwNHBWMWFLb3pHaVJX?= =?utf-8?B?T3U2aFVZY2lFU0NIbkYzbExNdzE2czNHcCsyc2w5bjJDcm55b3RQdVUvaHdZ?= =?utf-8?B?bzZxVFpSQkdaa0NuQmh0bU5RY3I4bnRzS2JKZE5kTG9MMHM0SUU1cXBKZkdl?= =?utf-8?B?d0tNekRFcG04TnpWbC91NlR4Mmw5K2djSGdWRlB6UlFNSlVEblFxTnpaRGMv?= =?utf-8?B?Nis3WnM4dy8rUW40N0c2dzcrc0JNTjRMc3doMkxxSnpxVGIrb2J2Skc3UEgz?= =?utf-8?B?dTQwYWxHUDZtWlVhZVAxWXhwWUh5Y0QwMjN4NXQ3WVo1VHE3eEJWWmkxUjdr?= =?utf-8?B?cWdmdzBOdkRlTkZjV3BZQkNha1c4MDJYV0FsaDdkN2JRTnhjNjloZXJpSDhx?= =?utf-8?B?UWVyekFoOEw4MGd4ZVA1dHRyOTRCd3I2WlpRS2xZTmNPYmRxcFNKWjVOOUc1?= =?utf-8?B?dU5MM3ROdUVlM25XYkU0U0wzaThIZHJ1c3FiSlowWHVReWcyUXQwU2dqUmxs?= =?utf-8?B?cjhRd2JSMlhoaFQ5Wmdya3pxQ1cxcjBrYWZ5TFdDUU4vRDZoMTh5QzJnb2dr?= =?utf-8?B?QW50TTRiY3F2ZzdaYUdNQzREUjEvRXJnN2tHUjJpeFJ0MEE1ZmNCdGdFYXYv?= =?utf-8?B?aXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?OTdqYnJvaHRjVXRDLytaNkdrbW02bUJBTXBSbjZMUW9OeGlCZjZ6aStqdzk1?= =?utf-8?B?WHhXSit4bEsvc2lVM1ZIQk4zZXlsSzUwR29KWVVodnRFMlVnZGlMOWh0K1dx?= =?utf-8?B?ODlhVTZNVXJ3ZzYxSlUrd05ydGF6cWhSRzZPd0t6ZXErZG1kWFFTWE1lcTRi?= =?utf-8?B?UHl4Z3ZjSTVGSUtETWRUZzQzckRUdUVqcDMvOFVvVStBYnp3NnNONjlRd0Fh?= =?utf-8?B?Y2I3cmxVemh1eDZVNDVMWE9sSnpoUmNtUFN1TndZV1Q4VndwQXRYKzlpTGN5?= =?utf-8?B?TGkxRDhlWmhHbnVyU0pOakFNOTQwcGNWUXltVDRBdXUyYUYrbUYrODJSODl6?= =?utf-8?B?TUNVK2I2M1BJRklYc1lCR2ZxTUNBNWRRZVVIbXJXbDZiRjB4VFJ2WjRGK2hl?= =?utf-8?B?SDVudGsraWpsTW03a2RsRDdQYWNaZWZGODVWajNlT1FtSVNSdUdsczMyZlNp?= =?utf-8?B?Ymx6Z0tIb1gxZEdxSjgrd1NoaXBjc2UxQkFyR3VpY3EvRTZSR3JNbWhIcEJ3?= =?utf-8?B?SGk3a3lyanF0ZmFkYlF5VzJKSEE3Ky9ZdTVMeXdOUk00aGQ2a0hkenIybVFB?= =?utf-8?B?dVJCblU0OFh4ZjloLzB0a0pFZmNPenNUV0sxeENJbFRQcURWMnZaN0FTSzFt?= =?utf-8?B?YklKZlpNVlRieVNUYU9yRDRzbzhQenpGaldrR21BUWRucHRHL0dSWGg4ZjRS?= =?utf-8?B?NCtMOVVXNExEZThrMWlQeDVHeW1NN2hMaStzQUVSVkltdFJZQUs3VXVzMDFW?= =?utf-8?B?Z2N6Zm8ySUhua1F5TXcrOWZZbmw2MXBsQ3FLOU13RUZ3clQzdmdZbFhHQmw0?= =?utf-8?B?cjF5N2RvYkNUaklseDhKcG5jZW1yeEZTV3gvcXhWWW0ya2FEbGMrV2FXZ0ZE?= =?utf-8?B?RjNoV3Z4SjRnNGlDWE11TTQwNUxwYTJnMUg4K3Z4aGtsTWdJM2ZXb2pZVWJw?= =?utf-8?B?disvLzM4dUhZSk14SlhSQ3BHRXNOdmg5M0dXZnFQbFg0TUdkSVNaZDluWitY?= =?utf-8?B?VGJpTC8ydmhFcjV4K3EzVlZoWURNcmVrZVBPVEd1VDFkenF4cGN0WjdtK0hm?= =?utf-8?B?SnlpaGJsRVkzSDg3UHZ0MXZHVm9IM0FZZGhNY3JoTWRWS2d0Rk9ESkxHS1dP?= =?utf-8?B?SjBkVmhDYnNIMmJtdWNIUXo5dFgzanh3UmN6VWFLOUordXd0cTdwYm5ZZkkx?= =?utf-8?B?dG9WeWZXcDNmbjNGL0xxVGFvTUlSUW1jYUV1WFRFM0VudEpPUTV5YWJCbWJr?= =?utf-8?Q?JY3ti4OzKFwovjh?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f74047c-a230-4de8-da23-08dacdfa31fb X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 08:59:29.4060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tz1c0vGOmX15+dnEfZdnNXonMgBKeAfX6WM0tPyWWUqUt5mPz0H85KFopx2Walmw0EH0dpHgbmJpk7vmUPtytA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5000 On Thu, Nov 24, 2022 at 06:15:15AM +0100, Marek Marczykowski-Górecki wrote: > On Wed, Nov 23, 2022 at 04:45:19PM +0100, Roger Pau Monne wrote: > > Marek: after this series using console= without the vga option should > > result in Xen not attempting to touch the selected GOP mode and the > > screen not getting cleared. > > Thanks, this seems to work mostly fine. > There is one message printed from setup_efi_pci(): ... ROM ... bytes at ... > I'm not sure what to do about this one (although for Qubes, I can simply > patch it out ;) ). Hm, I'm unsure. As a starter they could be gated to debug hypervisor only builds. And then I'm unsure whether this information couldn't be printed later when the console option has been parsed, instead of printing it from the EFI console interface. > But to get dom0 display image from BGRT, it seems something else is > needed too. Linux complains "Incorrect checksum in table [BGRT]". The > only relevant google result I get is this: https://support.citrix.com/article/CTX460227/citrix-hypervisor-acpi-warning-incorrect-checksum-in-table-bgrt > It blames firmware. But then, it's suspicious that it's also about Xen. > And also, native Linux on the same hw does not complain about the > checksum. So, I think it's rather Xen to blame... > The table lives in area marked as EfiACPIReclaimMemory in memory map, so > I think it shouldn't be clobbered by Xen, at least in theory. I'll look > into it later. It's getting off-topic for this thread anyway. See commit 89238ef7797023f318f82f4f9dddef59c435b8bd. I wonder whether the BGRT image region is marked as EFI_MEMORY_RUNTIME, I will have to check on my system. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Nov 24 09:03:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 09:03:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447882.704483 (Exim 4.92) (envelope-from ) id 1oy896-0006mz-C6; Thu, 24 Nov 2022 09:03:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447882.704483; Thu, 24 Nov 2022 09:03:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy896-0006ms-9F; Thu, 24 Nov 2022 09:03:48 +0000 Received: by outflank-mailman (input) for mailman id 447882; Thu, 24 Nov 2022 09:03:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy894-0006mm-GJ for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 09:03:46 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e506ce48-6bd6-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 10:03:44 +0100 (CET) Received: from mail-dm6nam11lp2172.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Nov 2022 04:03:41 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by CH0PR03MB6018.namprd03.prod.outlook.com (2603:10b6:610:bd::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Thu, 24 Nov 2022 09:03:39 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%4]) with mapi id 15.20.5857.019; Thu, 24 Nov 2022 09:03:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e506ce48-6bd6-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669280624; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=zcCG5udjDTd60vGA0XtZJWIEXrmsY7jYl7XnL4B9Kus=; b=eVQPCwV6hI+BwoSE+Iq0m+4AKlkv22saBZNwRozUatoxt8rIpSDqp072 Ucz835HppMP87wgnFdgZd+M5FEbp28/wwc0Tp/0UHFr8Y52jtX+MZc5lS GVSpT2UVVVq4IZThY2kYVKd4gO+44nD3KsVm7NWp9rtsffyitwm8LhjRS k=; X-IronPort-RemoteIP: 104.47.57.172 X-IronPort-MID: 85902243 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:3g7W7aA8Gkn6vBVW/zriw5YqxClBgxIJ4kV8jS/XYbTApD4k0TFVz GcYXGCCMv+DMTCmeowjadvn/BhXsJbTm9VqQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpC4gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwy7x8GGFD6 sQkJS1RbwKPociP3birc7w57igjBJGD0II3nFhFlGicIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+uxuvDK7IA9ZidABNPLYdsKLQ4NJmVyfp UrN/njjAwFcP9uaodaA2iLx17eVx3+gMG4UPJ6H6NBHiVSi/WhJAhATe1CQo9e/0HfrDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAIRyBMQMYrv8g3QXotz FDhoj/yLTlmsbnQRXfD8L6R9Gq2IXJMcjVEYjIYRwwY5dWluJs0kh/EUtdkFuiyk8HxHjbzh TuNqUDSmokusCLC7I3jlXivvt5mjsGhotIdjukPYl+Y0w== IronPort-HdrOrdr: A9a23:uzhcPqPmmh4IB8BcT+n255DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDKw875BKIhTaI7qe/NxSDxB8RXx5G3L9nqA H+4k3Ez5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJptkJJi7qggOIYp0kf7GZpjg6rMym9V5vut jRpBULOdh19hrqDy+IiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ/+1U4e Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh77D3vXklVavoLhiKr7zPI9 MeSv00I8wmKG9yWkqp+lWHBubcBkjbUC32GXTq8fblrgS+1EoJs3fwgvZv3kvovahNNaVs9q DKNL9lm6pJSdJTZaVhBP0ZSc/yEWDVRwnQWVjiaGgOhMk8Sg3wQrPMkcIIDduRCeo15Yp3nI 6EXEJTtGY0dU6rAcqS3IdT+hSIRGmmRzzixsxX+pA849THNfHWGDzGTEprn9qrov0ZDMGeU/ GvOIhOC/umKWf1A45G0wD3RpEXI3gDV88evMo9Rju104r2A5yvsvaefOfYJbLrHzphUmTjAm EbVDy2P8lE5lDDYA6NvPEQYQKZRqXSx+MCLEGBxZlj9GEkDPw9jiEFzVKk+8qMNTpO9qQrYU oWGsKUrp+G X-IronPort-AV: E=Sophos;i="5.96,190,1665460800"; d="scan'208";a="85902243" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DVAjJ3SOKDILnR2kZUZpV2iDijU5K+EBQftX1nDXEJQ6iMLVJA1SdZL1iWHR+ohpQTc6+gTB6BOgYuhPtDtMkODNA+QuVmCpyIxfNHVl4a8gws8BxwXGRH+ewPsJ7F4YRQahm6260EKKmwPqjAb4T4S9k94uB2JaQYOjwasOViXrJPPqUOj2l4l6CZnFcDdUHH7Jzz5lkhJMe/tLJ8ZFmFiEdO/Uw95UVTxplin0oviBFh76YdlVWf05el0FXUzeZ/vkXZCTZqdkSk1SwJRbhQ3wyggDRYH/nW3cKe9wIatzMnZQResuForz1L1Pt9PQWBEjJTq9KbS4rbR7r6w/BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y4txyeginBu/kOfSvafDgkOYRjGPI7REkWR5lx6EyLY=; b=jCeY8Gsa6Hwg3cObmXB9QwYnw6a7sgmmgFaaqNRsbh1cdcFYEHnb7wkOp0TaipAYaLMlLYYt/TuzTe8aYZ3zjMp0U0QR2iUB3qdLi7CbVwy5CDj4ozRIXRgmazBF6uTE1uYXvsHCmBh0Ca08uQj2m+iPt3tE8nXSE/NDbn87FZ85SVNjUOtMOSAk1DcgdZkMp4fqHvs4O5hgkrPEzZJTKiSVod90Ebbhiv5h3AHwXhEOexhP3bXh1EkwGwB2J5wy14VtwpU+cAxPRcYDZ/H72HNnj4WDikNoLnrx2D/gABn8lwF1jNy/0FWQnhkZVWNRow2QYNcHeA0bDQcmV05eRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y4txyeginBu/kOfSvafDgkOYRjGPI7REkWR5lx6EyLY=; b=B07PIK9PiGPpGp7yuw+17MBSbSpP6qbGKYzrHDm9TINXFSXGZh2eAKkEEqvaong1bsNvrFgRUPyggRacZwPniJKxf/gJi6qYov7ZIQze96744YtWtGtvXllZ9towGVyp55BVvdWxzhXXtf6CQvyZjxdTSbKiX1WhWrIyh1PAVOQ= From: Edwin Torok To: Andrew Cooper CC: Xen-devel , Christian Lindig , David Scott , Rob Hoes Subject: Re: [PATCH] tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free Thread-Topic: [PATCH] tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free Thread-Index: AQHY/4p9nL2l64sg4kKJKi/wcWyqlK5NyCiA Date: Thu, 24 Nov 2022 09:03:39 +0000 Message-ID: References: <20221123222517.12140-1-andrew.cooper3@citrix.com> In-Reply-To: <20221123222517.12140-1-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|CH0PR03MB6018:EE_ x-ms-office365-filtering-correlation-id: e74c76ae-ca74-4578-3bcc-08dacdfac743 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PWnE6VQlHHW+gtT8yTVdawX4uxYbhUOYbunVsD09fY/puITDIvMenJvPUT2O3osvjebJshoS9XzBtljiDRtsP+btdc/55P9Aw3cKEwBkmEsIZUiSkuJaxnlSuDeCBiiu40ss3k7Jpeqa3zg/aEXo98laxMfptPoJ/GIWZE/mgwNeEWSpWaqyxCDq0rSnXAswaPvETeK8aZ0NAXelFUjUCtO+qOVqonTl/uBLC/Ay5mRVi4/SdP6MllyyRgd+WfkwHw7wnMRoYplPCnnA8Gi7bB/WKozUeSJfIjS494ct5abcItJbAYAYybsjxANdJXg0wDIDXWrNll97im19lT9GHBmWBZgPmfgpKZ3DRtahKwrrH322yo3SZ+I44lge34ww+bm+tK0Tn9jC/q+cPRknYx7Uv6nSZ/Mtk+GkpBVdMCphvyAZ3nrPSt/clOubFyaGLSlEmNU8dZCkUpl3IzcZIMAaIJJkN+m5BvhK2OqazvQEYxPEgdm5TjOKbEIYcpoDaE+urbKjXm7mf6BCMTHIIrys8WYWlvI/sjEAQJWgLurdN4RRoVQxa8Q/sshmHMeJrI7nQ8sgK1ZAC43+L4TwAFIxk/nDjai2lx/guatKPUA6chEoGnHvAFqS776Go0Os3S6FhhAOJZwlSoO7luBrDlVkaowoqa+3X7mhju+EaThNpxBs0sof190yEvHzlRIZluMFuHmzfFjwGxyS+PAk8UZzYfKaPJcKfrs9GgYF+SfHYhpDZilQ2YfWX1v1mCI+hvpDSr6kni5JrF68VGwKww== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199015)(186003)(6512007)(2616005)(5660300002)(53546011)(64756008)(83380400001)(38100700002)(82960400001)(2906002)(26005)(316002)(122000001)(8676002)(54906003)(41300700001)(966005)(37006003)(107886003)(6486002)(66476007)(4326008)(66446008)(6862004)(6636002)(71200400001)(66556008)(478600001)(8936002)(6506007)(91956017)(66946007)(76116006)(36756003)(33656002)(38070700005)(86362001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?av56NDAER26UcPYdPKzYKEw+wWPRQNKMTcIKdRNmoZccKLqzxgReNrNYEFyp?= =?us-ascii?Q?svi23R18r0bi2w9UrRZjPFaqMdhM6FFeSX2TNyIKa0l6b7qyXOb5UlvuuDk2?= =?us-ascii?Q?iD6RB36NUV4YyQsjwCtTliFwyEBvejBAiybNZTJvFV8ooQklhPRbtrAFQ+OU?= =?us-ascii?Q?oFK0uqztRb9BckQSkMWJ/+f1kUksw8QfcFNeZn+H1/6eAk8fZ/lYs/V27Bhr?= =?us-ascii?Q?vfKbyRv2yCSltozvvGQ3hZIatTMEzNL5qzEupCnHRABxrDmTY9K5uW47l2i9?= =?us-ascii?Q?4YMul4cSOubdEf6QvyOjiFLVj87XuMZ3W+LdeURgONWyuaTn0EJypk31Yfmh?= =?us-ascii?Q?MQ0xqDRRwSI1GRoJyrCpiQPam+FYv9qqWUkFPxLkn2SBZ4jklITZs318EXTh?= =?us-ascii?Q?BTW52GhemtKcE+AOha74bPlatUJEQ/9FVlq2RrBaI7eB8nMkNO8h3wdKWui+?= =?us-ascii?Q?8bw3pGpwkG+BdJDKdWdfHp+MyTlBerEEChidYzH1/KiALw9RV0mS3yAKPC+2?= =?us-ascii?Q?T5GokANhFumtMKyHSoOs6cRh2RrPbYCYYJY86NNj+j4w2ksNNSEFF/vXurxa?= =?us-ascii?Q?vBFC9fGcFNiqjsV8llo49WROKTeXLtEPfhK0eEO85K2Q82B1SLunpDjM0e/f?= =?us-ascii?Q?lYrUTOg6BdxqXB1lbVmhwsa5PUs0I1tp3QCjn0heIZI7L6K8HpGOT04j8NMZ?= =?us-ascii?Q?4Oso2Vxh5nwtQjZAtn4y0y819f9NCbt4Mlc7YocX+L1UD/f7dh+7OkR8nUc8?= =?us-ascii?Q?ZXWu6FS/EC04rtruf4llhT+WZLdUYWHHM8B0LzOH0/txr47g9S+RZqVj4Uuy?= =?us-ascii?Q?qG1Fw83BUWJJdr8gLh81RUNTRpSEq9qfCJVadfVD5ZWrupqzXCL7ZvCLqyUm?= =?us-ascii?Q?2Lia4KZbcXD5+KYjjdkkbmUo4n1RfY8FO+XUsuAm0kDUJVhwCsepzf6+0sa3?= =?us-ascii?Q?ExrrsOVZaEocpq8KUWZ37f2IOI5vA3hsgkgu2GrJh5ZfKqGTneCEvk3Rj/LI?= =?us-ascii?Q?VawPa5iyNUZm+n5MZQnj7K2d8F0279u6e4E07n7lbvOMRTHSpKS74tW2HErY?= =?us-ascii?Q?YTTHGM7sm+ovkGzoXiDe46PyxkAiOuz7aN0BmWf7iEHDNp7dNTC05vy+h0zZ?= =?us-ascii?Q?qDYhZAM7r3MTuTEGSc2zznBwuULjHXjB0s67NxxCmiEozccF22EUxqyK3fle?= =?us-ascii?Q?5Wkc1agAiUW8mFupqueH4iuDPZWfX1ZDLqeDlzZlO6fNvrnoZj0vrQmdGlK+?= =?us-ascii?Q?uc0unJapnD7J9juQko+60PWKRFLajHUqL/8x6kPIxJLPmLbzo8MFUZtOUsXH?= =?us-ascii?Q?iCDz2I0zbNjfkDmcnpVmvwVNswfMX0WhxfL+0A9iCrXSBA9vnE4REutu9hV8?= =?us-ascii?Q?jQ1mpl2crX6KyXZjzKX7mf6vVeWIlP7ZcwVkNLf5y1CcRIQe43kIGLp6AnDE?= =?us-ascii?Q?MTlt43Ox0xBH/mrZLExDSnsAgz2nxiOoc4F7AYC/F8xRnhh6tVypFH2TPmkZ?= =?us-ascii?Q?A7NLotnVpfQn72zC+qa5vgVLJ5YOKExkLbvApYE5IdCBnYn7KUZhRrpD+kYM?= =?us-ascii?Q?gABxZx+7asWwsuNrrAeWtD8LOsNfoecHH4mxO2+qmDG/De1GxyDvUpRAwLdl?= =?us-ascii?Q?VA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CaAbx8SSCukWWn85CRy+2pVcCv8aqQ+QdNBovsmfVO6A13Ly8evsosLaKG1xjgLz+X8b3XrI9qbKAMUldrQSC3Y5g8/QSH7SHMW+22TTv0sNQuOkhRMKKmPrCW9xz3CDJxyoOYvZhougYQP+AwaqY8CWM3ThNGIN0SE0UJAjuCodwFpB16BcHuI1GyJ/FKyn1QId0b8v0AWpIS2OB5C4R26D6SrCCoeLo+W147Sy6BOFhT2tyF3huCudxDWvnUsIQoFFjVZwYxYFyMmpQmadHNr7hKRDAgb+41xQHd7phZLmyc1j/8zRlQVgqpI/oi85/lQyWmwg4gCqVqADs2SMvIw26Lx7w71lFrxWstqdP9DssksyCh0vfNImfNpJbptNMft+BPco0npUMAqEMgw8siWCtQFCDypSZRtnm97H8TdIy/ycHwgV2JJreVwNCwBWs0ZpbWWDa1g3eS5Od4gHkzb3nj76lbNfHIMPqSQlkqq1QCTSz2mjMB2fSbUiHC6LzHL4PJyhfTUWzetVoAqMLvG9zGvMCpI6LoWmapdwcBcnnk8zyUXVGavJR1rcr/G29+wbdhHQpdotph5dTKil2oJSxVirDO6QzslkJUy5/48Z8XWmepK5n3n2DD/MQOoesOUmw1OAk8ergLh7ZQNj6oujGYhgcHNqUJgxQYpnh/bwsVayh4d73kohlTic/zQoOYPalx4QJclyFFz0CR5CYjDjJKD1LIvwtlIVNH4nU8Bnp+myEeCn5Tf+s5PqLFAEv/eMsTDnOi39mQYtO6r+DtIdRNjLrln02NR4kBwJNJrwowfq1C2w3btehxRfo/2v X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e74c76ae-ca74-4578-3bcc-08dacdfac743 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2022 09:03:39.4468 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BYl11Y60mN53IANArStQkaVuln6/KK0acFJ8fRRRzYPVYzWDmYn948h+BN1miVc4bW7F0j8Un3VVeFNLhPrpew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6018 > On 23 Nov 2022, at 22:25, Andrew Cooper wrote= : >=20 > The binding for xc_interface_close() free the underlying handle while lea= ving > the Ocaml object still in scope and usable. This would make it easy to s= uffer > a use-after-free, if it weren't for the fact that the typical usage is as= a > singleton that lives for the lifetime of the program. >=20 > Ocaml 5 no longer permits storing a naked C pointer in an Ocaml value. >=20 > Therefore, use a Custom block. This allows us to use the finaliser callb= ack > to call xc_interface_close(), if the Ocaml object goes out of scope. >=20 > Signed-off-by: Andrew Cooper > --- > CC: Christian Lindig > CC: David Scott > CC: Edwin Torok > CC: Rob Hoes >=20 > I've confirmed that Xenctrl.close_handle does cause the finaliser to be > called, simply by dropping the handle reference. Thanks, a good way to test this is with OCAMLRUNPARAM=3Dc, possible under v= algrind, which causes all finalisers to be called on exit (normally they are not because the program is exiting anyway) > --- > tools/ocaml/libs/xc/xenctrl.ml | 3 +-- > tools/ocaml/libs/xc/xenctrl.mli | 1 - > tools/ocaml/libs/xc/xenctrl_stubs.c | 43 ++++++++++++++++++++++----------= ----- > 3 files changed, 27 insertions(+), 20 deletions(-) >=20 > diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl= .ml > index aa650533f718..4b74e31c75cb 100644 > --- a/tools/ocaml/libs/xc/xenctrl.ml > +++ b/tools/ocaml/libs/xc/xenctrl.ml > @@ -175,7 +175,6 @@ exception Error of string > type handle >=20 > external interface_open: unit -> handle =3D "stub_xc_interface_open" > -external interface_close: handle -> unit =3D "stub_xc_interface_close" >=20 > let handle =3D ref None >=20 > @@ -183,7 +182,7 @@ let get_handle () =3D !handle >=20 > let close_handle () =3D > match !handle with > - | Some h -> handle :=3D None; interface_close h > + | Some h -> handle :=3D None > | None -> () >=20 > let with_intf f =3D > diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctr= l.mli > index 5bf5f5dfea36..ddfe84dc22a9 100644 > --- a/tools/ocaml/libs/xc/xenctrl.mli > +++ b/tools/ocaml/libs/xc/xenctrl.mli > @@ -146,7 +146,6 @@ type shutdown_reason =3D Poweroff | Reboot | Suspend = | Crash | Watchdog | Soft_res > exception Error of string > type handle > external interface_open : unit -> handle =3D "stub_xc_interface_open" > -external interface_close : handle -> unit =3D "stub_xc_interface_close" >=20 > (** [with_intf f] runs [f] with a global handle that is opened on demand > * and kept open. Conceptually, a client should use either > diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xe= nctrl_stubs.c > index f37848ae0bb3..4e1204085422 100644 > --- a/tools/ocaml/libs/xc/xenctrl_stubs.c > +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c > @@ -37,13 +37,28 @@ >=20 > #include "mmap_stubs.h" >=20 > -#define _H(__h) ((xc_interface *)(__h)) > +#define _H(__h) (*((xc_interface **)Data_custom_val(__h))) > #define _D(__d) ((uint32_t)Int_val(__d)) I think this requires an update in xenopsd too to match, otherwise it'll cr= ash: https://github.com/xapi-project/xenopsd/blob/master/c_stubs/xenctrlext_stub= s.c#L32 This wasn't an issue with the original patch which used Data_abstract_val h= ere, because that (currently) happens to boil down to just a cast (with some GC metadata= *before* it), so the old way of just casting OCaml value to C pointer still worked. However Data_custom_val boils down to accessing a value at +sizeof(value) o= ffset, so xenopsd would now read the wrong pointer. Perhaps it would've been better to have this _H defined in some header, oth= erwise extending Xenctrl the way xenopsd does it is quite brittle. Best regards, --Edwin >=20 > #ifndef Val_none > #define Val_none (Val_int(0)) > #endif >=20 > +static void stub_xenctrl_finalize(value v) > +{ > + xc_interface_close(_H(v)); > +} > + > +static struct custom_operations xenctrl_ops =3D { > + .identifier =3D "xenctrl", > + .finalize =3D stub_xenctrl_finalize, > + .compare =3D custom_compare_default, /* Can't compare */ > + .hash =3D custom_hash_default, /* Can't hash */ > + .serialize =3D custom_serialize_default, /* Can't serialize */ > + .deserialize =3D custom_deserialize_default, /* Can't deserialize */ > + .compare_ext =3D custom_compare_ext_default, /* Can't compare */ > +}; > + > #define string_of_option_array(array, index) \ > ((Field(array, index) =3D=3D Val_none) ? NULL : String_val(Field(Field(ar= ray, index), 0))) >=20 > @@ -70,26 +85,20 @@ static void Noreturn failwith_xc(xc_interface *xch) > CAMLprim value stub_xc_interface_open(void) > { > CAMLparam0(); > - xc_interface *xch; > - > - /* Don't assert XC_OPENFLAG_NON_REENTRANT because these bindings > - * do not prevent re-entrancy to libxc */ > - xch =3D xc_interface_open(NULL, NULL, 0); > - if (xch =3D=3D NULL) > - failwith_xc(NULL); > - CAMLreturn((value)xch); > -} > - > - > -CAMLprim value stub_xc_interface_close(value xch) > -{ > - CAMLparam1(xch); > + CAMLlocal1(result); > + xc_interface *xch; >=20 > caml_enter_blocking_section(); > - xc_interface_close(_H(xch)); > + xch =3D xc_interface_open(NULL, NULL, 0); > caml_leave_blocking_section(); >=20 > - CAMLreturn(Val_unit); > + if ( !xch ) > + failwith_xc(xch); > + > + result =3D caml_alloc_custom(&xenctrl_ops, sizeof(xch), 0, 1); > + _H(result) =3D xch; > + > + CAMLreturn(result); > } >=20 > static void domain_handle_of_uuid_string(xen_domain_handle_t h, > --=20 > 2.11.0 >=20 From xen-devel-bounces@lists.xenproject.org Thu Nov 24 09:06:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 09:06:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447885.704494 (Exim 4.92) (envelope-from ) id 1oy8BW-0007NF-PL; Thu, 24 Nov 2022 09:06:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447885.704494; Thu, 24 Nov 2022 09:06:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy8BW-0007N8-M6; Thu, 24 Nov 2022 09:06:18 +0000 Received: by outflank-mailman (input) for mailman id 447885; Thu, 24 Nov 2022 09:06:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy8BV-0007N0-Eg for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 09:06:17 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f3f483e-6bd7-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 10:06:16 +0100 (CET) Received: from mail-dm6nam10lp2108.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Nov 2022 04:06:13 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BY5PR03MB5061.namprd03.prod.outlook.com (2603:10b6:a03:1f1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Thu, 24 Nov 2022 09:06:11 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Thu, 24 Nov 2022 09:06:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f3f483e-6bd7-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669280775; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=t3EYvz1XTS+zQxJ7iA3STbW9/5xec6zWLHG0kcnaxNg=; b=bbGb+5eqmgAyjWw3JpLX56YNeueYGTDryqRI996EHb4UHrOwk5sRnE7a nJQuvZXwmMgot0WIDlu2rrMo/z0+4m0FLqCbMHYWEfzKkTlkmA1tyq6C6 stx12JSHt1EvNg5GH3EwaMVwYJ7vI0rmdYxtIq9DxDF9omg6wbvWhzWxk g=; X-IronPort-RemoteIP: 104.47.58.108 X-IronPort-MID: 85902443 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:yJtJIKxbBcaAlNA6l7p6t+cCxyrEfRIJ4+MujC+fZmUNrF6WrkVTn TBKXGjVPq6DZ2ejeookbouzphsAvp/XxoQ1SQtlpCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnP6wT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KXFw8 KwCdR41Vw6ao7K3xa/rac5DlO12eaEHPKtH0p1h5RfwKK9+BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjiVlVQhuFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE1rKexXmnBNl6+LuQ3+5xjG+Im0gpLCITVGaghtuTq36wYocKQ 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS9wWl2qfSpQGDCQAsVjdcbPQ2uclwQiYlv neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRt3jX4iIQ6jxaKQtM9Fqew14XxAWupm 2DMqzUijbIOi8JNz7+84V3MnzOroN7OUxIx4QLUGGmi62uVebKYWmBh0nCDhd4oEWpTZgDpU KQs8yRG0N0zMA== IronPort-HdrOrdr: A9a23:83zizKmQ27MjHzyHPEIww15usjfpDfNMiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH7KGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu1Xh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboX0Twk6n7WXdrWrooMT/Sj5/I81dhbhBeh+cz0Y7ptlz3I 9Cwmrc7vNsfFv9tRW4w+KNewBhl0Kyr3ZnuekPj0ZHWY9bTLNKt4QQ8G5cDZ9FNiPn74IMFv VoEajnlb9rWGLfS0qcknhkwdSqUHh2NhCaQnIassjQ6DRSlGAR9Tps+OUv2lM7sL4tQZhN4O rJdo5ykqtVc8MQZaVhQM8cXMqeEAX2MFzxGVPXBW6iOLAMOnrLpZKyyq4y/vuWdJsBy4Z3sI jdUWlfqXU5dyvVeIKzNaVwg1DwqViGLHfQIpk03ek6hlS8fsumDcS7ciFuryP6yM9vR/EyWJ 6ISeBr6rHYXC/T8L1yrn3DsqlpWAcjufIuy6cGsnK107b2w97Rx5vmWceWAobROhAZfU66Kk c/fVHIVbZ9BwaQKzLFvCQ= X-IronPort-AV: E=Sophos;i="5.96,190,1665460800"; d="scan'208";a="85902443" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SssJKId4VLsv0Hno69tlAay9NjZ8YFCKr6n8wGObNd0uJjDThjYAVXapgMp4dk+E3wlN3LNrc7IwYFd5+M9gjm/FcMaV9J1pdnoQIKB/X/MSxSjqh32TopMm0mqyxgrdt9TXUlSztQd29Q1bmcxym/hZMeQR5+SsKJscQpgJCR56TqCnTX9BERgMUqZu6PckOCT77l8/Xs8I+jQdGbTQrWRlObksVBIikFL5ORsItAoCyT2cg6VvWsdADHDB3U0RVQEalR4JOVj5Dp9AYSi1n084X/Ovm80B/WdPJWngZU0aPyveDLJcoyTeZudpihSTxlDMlr1kGtbeAHF2VSYWEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R3zLzs5t9KDnSrR2TlSiR/fAA72haEm1vpp5dLfJAKk=; b=LRoNgtvxw360a0FAokoblSG6MWGfkggL8U7FIrAsAYt5zLT18OijqYReRSSCQaudcOpiSmN1LiNiANz+jD7uemJsex4QUMfT7REmgkE6MP18aa3F/4m8PHqu82IX4fGE5n/R69KKQLtBmcquLHSmoglHh3HL3i5XUq5CN+Pub5z9+ZZua7yx417aUNIPaYjVMUDo7pfLTJq/jk6aF5PwWSzFaXPbQs++BvMMO/sWfkNBphNnS89LXIAs2zXWIzU5dOZZKYAjxemypYZTniSxi3O+8uV2634Q2j2X1NogbdF+47buZoMWNw1a+75pdjH2O9FteQ4XVwi5qIlgeXq9iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R3zLzs5t9KDnSrR2TlSiR/fAA72haEm1vpp5dLfJAKk=; b=X1jqNF3v+s/yk1QSrZxzPAPDMpIZUk3BYeGCKyISqH+x9BCnyeb0CnM06Pb7of0cWxwzDC4ur89yUrsUnLqRGQAqddTTjvHyAMJc3CYbFE6clG8uZ2ivAQ/Tl01khWpwpO25Ztst6ci7LkNp92J6nNcmED1q/J2yhvWpUScbsjs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 24 Nov 2022 10:06:06 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Message-ID: References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> <5a2df843-1acd-ad78-baff-e47befd0703c@citrix.com> <878e635f-b116-3580-945f-f8acb711a5bc@suse.com> <69507b8d-1f31-39fb-7469-e240fbfdde44@citrix.com> <33a005bf-0596-c624-0e70-077a450ac2ae@suse.com> <351a6e54-8002-aef0-993a-c6b8bdcc1e8e@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P265CA0044.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::23) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BY5PR03MB5061:EE_ X-MS-Office365-Filtering-Correlation-Id: b8400571-6668-45ad-00ee-08dacdfb21a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VZhYJjvoVfriiatgGqhrnhN5HP7tMzBOgtjRTK5F1gKYnDaoIPoAPUguyC4CxDiU+JVl93Ir6gLx+J9NFCLpTjpGbcMpX2OIktrrIaaJbSB2mhPSrHF9L43Z45rajl+KcmVIriJDhrqkG4WN1lQkU0WEV51qTQsjIjntuq5bhKU+Xe07zNo8NFu8xgRXIn2e27dRNVK7bi9MYr5wJfA08wJLnHrU+FZjO8K3ii1NKGu0vLrYnFpBd74nnXfWjj2Br05kJXg7tyyg3JkYG6EEaYlVqOwAVTGqmRWhJNDzmT7rEOAEic5KHM8Q9HjnZTm5GG9g00eabVOEODRUPci4lqZWLxT2opJRfE26zeACWD64SVclulnD98Bhvq72JKYV8YQhSqy0GZe/FDK3qh1e98ccKRHy4mCzrTDJ+/dtNyX2rYBKi2MyIiTUOqnJ2rhCeZzd9w6A0dD2GSVDnZgP5QQj1/8e4qndr6SVoZMLVj5+q3rkrzLCRTpEUeC6X8JjqJ14ppvJtZ2S5yrUYlY39AhPIshD0wOP7NteWDyNOCjSdz0JhG0bQ3ChrZDseVGP1kzaSAf+Jhn9AMG1z5adveMiAxK8dAw4bkfpi+mnzx6xjfV2ogQaiTi/qsaQNCd8IaHPwUgO/wi/eZBQOjgXjrOlTrm6VMr5t9i+jzTA3S0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(366004)(346002)(376002)(39850400004)(136003)(396003)(451199015)(8676002)(4326008)(66476007)(66556008)(66946007)(8936002)(5660300002)(82960400001)(83380400001)(85182001)(41300700001)(86362001)(26005)(6512007)(6506007)(6666004)(9686003)(33716001)(6486002)(966005)(478600001)(186003)(54906003)(316002)(6916009)(2906002)(66899015)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2trNmxnaElFcDMzbWhXYVBUak5qVjdsYXdRekp6ODlPa3haWkNaMzk4L2U2?= =?utf-8?B?elh6VDJoQmxBb1FCdzV4c2tpbXJ6TXplZ0E0V3ZVTFAzZ3VybjJCK0Q5Q1BG?= =?utf-8?B?MnczS0FUbGxQZlVpbUhGV1ZqK1NQTmNZbDdDRlgzcU9VY001WFVWaytueWNB?= =?utf-8?B?dzh4Y0hRQ2J1a21KdDhOd0F6SlE1YTBlSmVUN24vSSs2ajJXYk5Tb3dUL1FZ?= =?utf-8?B?YnpvSkEvQWc4TzI5TGVSUy9PaWZZR3kzdW9ydjBOWHhGNEl6R0lJaEN4dkg3?= =?utf-8?B?WCtYWkV4ajZnNFJIODJpbEkySkRYb1lYbDFsR29XbldZYzBoVGkraHZCdlZ6?= =?utf-8?B?TEdxYjRTRGNWQ1d6cWJiK0dHejFYSzJtcGRmYnZOVGkvZ0hiOHB3YkIwVWVN?= =?utf-8?B?cGY1VTFJcHpMZ1h6RDVGMlZvMTZGbHlma3puaitZd1ZyeVRJdlRGdWFmMmFL?= =?utf-8?B?MEJNanRaSVNQMk9VS0pXTG1MTlZxNG93b2d4K2VFNE53a2pBYStVZXgwQmNS?= =?utf-8?B?RDFsMW9pQ2pJaHpYRDVFeFBCMDAwdzdYQm0wNXUxdDNjS3p6NEpTeTlsaWJP?= =?utf-8?B?N2JFNElCQ1RFUGhKa3lTTmE5Z1phdjMwbVlkWlFqWnN5dkcvbTBQVzQwUXVQ?= =?utf-8?B?dnBKbUxIMFc5aTFiSXkzVmR1U0lHRkhvc3Y3RmduR0MzTmZwOEFPY0xhd2hM?= =?utf-8?B?SlVPTFF0c0xPM0h1ays5UTdrRDVPYTFlUUNkVUt6ejFnQzFaK3MxRmw1em4y?= =?utf-8?B?UnkvTmk4dXY1NHZpWFBZZlovSDBGZkFnNzJIUzJlTEJ3eEcyK1RHY3Q1OUtO?= =?utf-8?B?c3BGck9zTTB1L1FITkQ2cjY1bkJPMjVZSTg1SkJ3ekd3UnVucVNFWVgzTHZI?= =?utf-8?B?RHMwVHhwaG1WRTFyMU5vVlVEazYzSHpqKzBVY3JvUVpEdWltdFp6MzlFd2h6?= =?utf-8?B?QWZlY3N1b1NqNGVZSDhFcllYYjJ1ZlNQbzBLZkNnYXBEandUUTE5Z2IzRzBn?= =?utf-8?B?RU5PenBzRGI1NTVZYlIyeXRLRU5TRzdBY09RZnQvM2FNMUdnOXdwUkNQdjJD?= =?utf-8?B?TDlqOGJIWTJ4UjNxL1U5ZTdCTWQ3MFQ2ZzNnNDU3dmdsMzBSc3pyWGtiSmVv?= =?utf-8?B?WlR2M3F1SVlCSjduNUF0WDVzUEJoSGlGMVhzVkorYklrVmRIQTVVZThHRkMv?= =?utf-8?B?dnhMSGN4Unl1VXdialQ2alpjemRlNndlWDBjYVV2WE8vSjBJQlhnQSsva2tB?= =?utf-8?B?ajg4cm1Lb0tXMm5ia01odE9UalFnK1FxYzBlTWMvSmdTS2hRQXR1NkJ6MFd4?= =?utf-8?B?SHR4dGR5M0JMbGJsb1N3RGZDRDJpLzI2YWtrNUxrMEN4UzR4R0hOVTQ1eWZn?= =?utf-8?B?Nk9WNjBzVjQrcTFFYm1OVW1wZ3NOZ1c3K2tWbllUWUYvQk5GK1lHR2wyTmh1?= =?utf-8?B?KzdkK082WEJ3YlJua1BNcTdYcGV3bEdaak0xK0VHY2t3TFRjdXZENktxeHNl?= =?utf-8?B?dGxSSG5sQVdUN01peFRwQ2FpMEg3ZndHNFg3OUc2RjhhelJkWkN0c29HUmVS?= =?utf-8?B?VHRvRzhSc1RrNVpKb0xuUXoyQ0lyZmFMQ2M0RTV0ZTFKS1BpMDR4VHNxVXBx?= =?utf-8?B?amlVNTVqZ3dzNkFlNkZ4L0kzUXhwTEttYjAxTVNudk0zSUEzSmc3d0hYM3lE?= =?utf-8?B?NHRRM1RhQzc2NnJQTGtzb2wyMkVJQnZodUYyQVp2R3RtVXhRZnY1YU5uVGgy?= =?utf-8?B?NWI1RHU1SVRLbUhTeGhEejdoeWtZbzRjZjFFNlMrZXFaZjNNVVVzdkJJYUtM?= =?utf-8?B?Z0tTbmowSE9LYkpPelNKRU1adkRCUjhFNDFOT1BBYjd3Q1hNTWNIeks4MlFI?= =?utf-8?B?aC9kRXBiekNQRjkydnJyaURTeEdKd09TN3hBUFNCczduQUkxU25hNmJpQlVW?= =?utf-8?B?enNXZHRiZDlUQklXcFFXTjFMQ3ltcE0vNlBYeHQ4QzU4NUlmWXc3UllDOWFP?= =?utf-8?B?TTVkc2VWdmpGN2EzdmNGaXpEVE1oTzB5b3Nla0x3ZCszcTE3eTBIY1lzSElH?= =?utf-8?B?ZGRtMXIwSE5CNTkvNkZ1RkE2UkxOZWs0QXNYVkVKd3g3UzFMbXk5cW9GcHRH?= =?utf-8?B?WnoxYzdRMG8rdXhIdFBxb0hFNGJxeGJBb084cW9lREQra0pFUHFlQnVGQWZG?= =?utf-8?B?UWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: bNJ965KU1gX0TVcBpGrfMNJsGt1qQgLF4LMidA6fKmf60X3OhYBdNPkkoR0BZufcpgYmyQeUL7JUzolZxvWkMLjlCXeJ1suVvhqLK8jtbI6mu7vBGC0RwGOhXFj8jW2rKyuj9aTG5joUrXlsaaQFJxppM4tbrlc9hb5NE0ggLOSbnIdv5ZzP1BRbVrkUc2K/CfB/naJCpXdj3DRmnz1jQY/E79HGt/2DJY/LMqtzyOxZlZuJeIrJ/MX6a2t+iMIy/zR/NftgL5cZ2OaQDNNmxnmOogeV3zSr/cZzoJuC/9jfOqhJg8OP0C6B+FBLOPzC2bzTNT2fD4b1J1vDM+s2SU3QkSXLW+zhn9Zx2sgY5mFNJsFqkHtQ/wsKVPpZv0vAu0A+ZmtHeorG+9W2J4N6gfFZI99J83Uzk8TsFcqKxLaGAnOETUsEAnZ9wVLapJTW+7J3vJPX14nWVHuWzV+ZT5Hc5bvG2gmivnkl+tX9gESiqXJO5dcC/VwjQeTD1AX44Golxdf4PEW3wVZtBPqKJBT7FvM8j1FcjDw9wj/3mih8Ub6w/Kgq8eyvFvRmH1SI2GA/unsS09uBRGPhm1H0pxvxRSf+wP6ofkUup5/tA0V6NBkpd2fHpZS+wNPk3NXHN1OC5fBDu07aKLJ5SvEgqUdznS2Ytm2g7/mGHlSyc9WG5PNFis5LbYe4om+VcPbBdfb/sa0bGu7zOjSvKzc4qBPIMYce572jEUA04SR1Xc91JmW5CEo3Y+RvG5moIht2BvrxUp6qDV3h5t1wOPXoTCfSKYXVnrZK025HuOmTvc9/U0bRvoMgJsvqLLu8b3OHbKnIU7abMf3x6npZewWaP+1uUJ6UcO89q+NLLBkbEjM= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8400571-6668-45ad-00ee-08dacdfb21a4 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 09:06:11.3727 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gAbJu1CTWBfAsc+HK0bFfqkqBP59GZmJTUpvErGELMVkFbLa7U0IZ52tMW6IzcsCpC1fPNijiyV1r873OO0zsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5061 On Thu, Nov 24, 2022 at 09:42:40AM +0100, Roger Pau Monné wrote: > On Thu, Nov 24, 2022 at 08:59:00AM +0100, Jan Beulich wrote: > > - problematic wrt evtchn_upcall_pending, once set, preventing event > > injection later on. > > As you may have inferred already, I'm inclined to suggest to drop the > > the is_vcpu_online() check from hvm_set_callback_via(). > > > > One related question here is whether vlapic_do_init() shouldn't have > > the non-architectural side effect of clearing evtchn_upcall_pending. > > While this again violates the principle of the hypervisor only ever > > setting that bit, it would deal with the risk of no further event > > injection once the flag is set, considering that vlapic_do_init() > > clears IRR (and ISR). > > That would seem sensible to me, and was kind of what I was suggesting > in: > > https://lore.kernel.org/xen-devel/Y3eO0bMKRPYJc2yQ@Air-de-Roger/ Another option would be for vcpu_mark_events_pending() to unconditionally call hvm_assert_evtchn_irq() regardless of the state of evtchn_upcall_pending. This will create some spurious events. Regards, Roger. From xen-devel-bounces@lists.xenproject.org Thu Nov 24 09:06:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 09:06:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447888.704505 (Exim 4.92) (envelope-from ) id 1oy8C6-0007wx-4j; Thu, 24 Nov 2022 09:06:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447888.704505; Thu, 24 Nov 2022 09:06:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy8C6-0007wo-20; Thu, 24 Nov 2022 09:06:54 +0000 Received: by outflank-mailman (input) for mailman id 447888; Thu, 24 Nov 2022 09:06:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy8C5-0007vT-Ca for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 09:06:53 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20615.outbound.protection.outlook.com [2a01:111:f400:7d00::615]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5596d4e4-6bd7-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 10:06:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9392.eurprd04.prod.outlook.com (2603:10a6:102:2ab::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Thu, 24 Nov 2022 09:06:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.019; Thu, 24 Nov 2022 09:06:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5596d4e4-6bd7-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aF5jYbU7BD4Um5SCzIevs3VWhHp3a0LxvWuEOUbv0OlgDipSp2ltT0u+CtJxsgV0+pEdEoSXdQl1drS/xJdcPpGK7P3hzlMbGdywM5NZGQmlruKr7HFNqstmmDRtPczleTg9hFC5zhOi5zWsDfOlRLXzWahAbIDFPOBUVSdmAUN+XW9bhNThmMMVl97c8+y/ORdqT6TYXxvljdBdnsmfocrcXlJDvMogg7NrhKch7c1NM2H12sC1BmE0Nuo8YiWCkvwAxHRH8Eh9mlmYR1TjWenDxEnxQNm1fM7hp+r89RypmSFjpDku4HwWT2qvTmJIei8EnTq2vJys+RK8ebmssA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TlgS9y3dPfl/htubr3kT3GwI+dfAQ+fglh8R0sG3A+M=; b=dZiYU1wctHEuHZPuY5AebrPXrDpdRFGTnAHjlXLf5/SYwtdg4hpnevT4nI3gNXyIZCvu7ngkgU1fvnerdgSatLGaa0UWeoNeWoTscPTJ9bXteQOzQA3YoCoRIfXKON/6cc6VqTAu77gqOtzuLInfVg2BxwOXzGf+OCd/AByMSetdyX/Ev+iODA0oGbEoy3mgYp/lxrRYD07+wsZQ/31TYXy7roqpS9X03iNbhoCCNPEBfumAec6WtKhT4LSYxrR9xxWogS75ZW/uRoOQE4FpJ7tWflaqIbKlEiL5X5i/Z/gHPXvi5HU2/G5quEQQxWdxzGwGYKthwxmyEVQh9lsMuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TlgS9y3dPfl/htubr3kT3GwI+dfAQ+fglh8R0sG3A+M=; b=IiZqANoACA1S2HO2iB2ZbA5EYdBLTNPxQoOk9L7YKWDYkSPVJ+MsutijDcubFvLYySXng7nFkL3FUtyjQjcX/in+mOgyr6jdzqvOpSZ5jLS8oGWsuPatQI1ehnsnu1xgJyk4S4pJP/ANIxay6PewJUpdxEr8jbTuoRGgtRpagql7rN66MMJGYVbogUQIEMqQa4uRQexx0kHlj7lvehzSzPaDSPAjLV4s8dykcrXHVJ7pA3i2VHIl5cvOIYnGPHJo49PFNikCyWPoqY2MwjL3nC491rWeIt/YNBBhC0Qk96DU+yHSlW6JOjiBrXtykihs+lh3f04P6k3GmJlolj7VLA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 24 Nov 2022 10:06:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> <5a2df843-1acd-ad78-baff-e47befd0703c@citrix.com> <878e635f-b116-3580-945f-f8acb711a5bc@suse.com> <69507b8d-1f31-39fb-7469-e240fbfdde44@citrix.com> <33a005bf-0596-c624-0e70-077a450ac2ae@suse.com> <351a6e54-8002-aef0-993a-c6b8bdcc1e8e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0061.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9392:EE_ X-MS-Office365-Filtering-Correlation-Id: e2af263b-fd6f-4f87-c8cd-08dacdfb38a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1IgOly/CYCDPXQRdhtQuYcDtuwMwAjt16+qVBCn8dYTf0ckdZTbfe0aAv3XYFR84MsjsiNFmfd/+DO1EbUNao3lSuVrmQJVPYOlDU4n8PtJhxRcUdPsLevqRcBrnFcjmHT+eAHVVWGXu8ADv1EpTfn50w1FQX2MjNqsVDDSrOfAu2TIgaXqS/205znd0nBkVa8AqPaUmhnz7K0KWQYnHkXQhPl05w19VxIaF03KtOeu+BK/MrZzjWiYrMduHQKH9cfeqFba6hPhcUGGRxtnNQqPV31y9uev3wikdqwt2SNTVXvpc2caWg2m/GTKD7qlU1IamTXByu/ho+32MXwVKDlgBHCgOv/DovVJSXToaZg/9J7U1eG6Cvj47MXgm7WPwSeuxlRZnEjb650u7qJB2YAkcztF0uBgkcO78eg4JGs1oLnm6fJVfRw06zjglAFOpWJeLejpuj7ASwLGneWOd74PRko5OvJm5lb+ngHMerc0+2LjSPt4BMIXWkDhSUnmtiQcOW37H3+lTT8Crt7CJeoNrxxc40jJblEzYxJzDtCZ0n6MD7ctBesIGP0hRHiM3VsA1aRKR9/gCd2bL7wEln3PoKibfMdQ6p/pfKfEHkXMYpS+xZ+HCsHkrS2htGA3vwzX6GHB4gN6sgBFc/9lTbpIT1TjT/35nmok6zsLliCfzeQQ0t2XyqeWn5K4GmpDhQ7S4BVCqmI8iMcOTX/ILNBqfuGEW59NbfYNccPq8dBvbvMNg4oSklyQFbJoxVPWTuprbqKG7Yq+/M0wry9D5Jg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(346002)(396003)(39860400002)(366004)(451199015)(36756003)(6916009)(8676002)(2616005)(66946007)(6512007)(66556008)(4326008)(5660300002)(41300700001)(66476007)(6486002)(316002)(966005)(54906003)(26005)(53546011)(2906002)(8936002)(6506007)(478600001)(66899015)(186003)(31686004)(4744005)(38100700002)(83380400001)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWZKQ3pFVldqcjlraFc5cHhMcnZTNEtDcUlaUUp6bm1TeVZGaVBxRHQrejVl?= =?utf-8?B?Y2lCczlESm4rbEVqbEtEeXZiRnAwS0F5MHVVVG1ObndaUUFJd0FCQ0xXTGNz?= =?utf-8?B?NmplM2Q5MVI4OFJTWWlPREJweVYxZDNNU2V0aXBLc3VhNy91WHVuZFJQZndD?= =?utf-8?B?R1lZTkdmbXZTNFhZVFdBMVpxb3VmQnhUTlFCaHExTkZRTFRHRG5rSVNDbUlY?= =?utf-8?B?VmY2aFYrQnpDTWhxdGcremsydkZVYmY5dGRZOWxscGJkVkg2K2xlKy9GN2Iw?= =?utf-8?B?U3E0bWF2Mmd1NkRhVktxYUtIejV5elBTeVVJL2o0SWZka3dxeDFsZ1cvaFUy?= =?utf-8?B?dmVZSXFrTk95MVkyalFrWHdKeHhwRVlIakxwQ1NLMldHS3JzMzFoZXBtdGhu?= =?utf-8?B?MzZ5MytOVUg1b0plRnJBWDZxbXVxbUJKdUFFMnJnREFTRGZESS9lMjEweHdk?= =?utf-8?B?eUZHdExUcWZIM3EvVkdUd1k5aDVRYmhOYzBHdWNic24yZjV2bFJxR0s5cUM0?= =?utf-8?B?cGRhODE0VkZ5ajdRR094aHJOSlRwdStIbnU5K2Q0OUZSeXh4NVZVSjZIWVdH?= =?utf-8?B?ald3a0toUE1BRXlCajA3UGt0SEd5N29URUVRc1lnSXdJc1FhT0Y4K1RtWTU2?= =?utf-8?B?Z2Y1aDF2d3RjS085NWxrOEdaUnl3ZVRRU0t4Y0RhT2N3TzVibnM0bmpVQmhm?= =?utf-8?B?OUFTRnZMZk1SdFlSU1d0ZFZPSmxxNmhLUW8vVHljdzhDLzFmU0FXUVpsUlN6?= =?utf-8?B?RlNraGtKSE1ySVJkYWhXWDM2NHZaaVl4ZFVpSUN4WWdsaWU5Ny8ybDdSaUdQ?= =?utf-8?B?Z2NhSXhtaVpESFhieUEzNnVxck85SDhWZE5RK3dNWFZKWkpTYnVBNkMySHZN?= =?utf-8?B?NEUvSU40K3hqWnR5NC8vbUM1bGRjemtiQjZmazRrcTZ3UTUvQzJBVFlmeXRo?= =?utf-8?B?KzhiRTZjbUpSVis3RVFpUDZ5YWExRHNLdXVlb0RsQlVhYy9ZemFkM2RPSldQ?= =?utf-8?B?bFJzdkoyNUpaYThEejliWW5MREtqaUI4aUp0bVdiS2tWZGJPOForZ3NpL005?= =?utf-8?B?dXRZYXpMMDgrelhmTkFJUWxUblYwZk1KMnhKZ1IrMGtFUnlENVE0OHVBMWYw?= =?utf-8?B?L1ZvallxTXJxd1RIdkRFZmtmRE13MXN6T3ZyR3J3Ym5sVGJXOGpVU09iRkR0?= =?utf-8?B?dUswaGIyeCsxVHVRV1kyMm1ZeTAyVUU3VEFJdXZyVXd5S2hvcnNLbW84YVN4?= =?utf-8?B?RDZ3eGw2cjZLZFVGOVZqWGZGcEh6Sjh6TkgxVjRUSlRDRjUwZXhkMGpqaGVk?= =?utf-8?B?MzFtdVMxbjdvK2lUbng5K1o2cmZjbVJpUXF0N2pHNnV3emJMbFhDdjEvbEVQ?= =?utf-8?B?TmpzQmJERm1sS3g1dkdYRjJjZTB6R2M3bTB3ZDA2Q04xbExTVG1rOW42WHBx?= =?utf-8?B?dDZKaWhnLzVoTTZaVXBwTmVzOWF0Z2xyZ21ueDdBcjU3VVliK3lCYmdNektQ?= =?utf-8?B?RlJvMVJEY21SQXpJTnFtaGMxZW9CZjYyWUlSV0RNT25FN0pBaGpZeFRRZHZF?= =?utf-8?B?WkR1ZlgvV0t1Z0hxMGMrVG1JaG1sYW94YnQzOHFvRHJ5SDdmNlBIaGs0ZHYy?= =?utf-8?B?c242SjV4OWlhOC9UcTlOZlEwK20wa1dMYllaZ2IyWndtUElpcmpvUTBSRndu?= =?utf-8?B?ekxqVW96d1JsenlxcC8yYjAvd1pGU1RYbFFVL2JOdlNIdVdzNE1hY3R4eWtY?= =?utf-8?B?VWsvSkMrTUgrVi9Gcy9PV1FsVG5ORmszZ2tsZ09FTDJxWklaSWU1d3BIZzM4?= =?utf-8?B?eEdON1JpMTRXVGpESnI4T0piMGNIY2NKWkFkdHcva3lSWVdIMkt4aktzcVc1?= =?utf-8?B?cXFxbXo5U3NOUVAySHVzZCsrYjFjSXp1b2ZJck5SM0d3MTlqdU9tZytobVZM?= =?utf-8?B?MmlUQk1sVGtmaVF6SW1qL2hlTkt0L3VRTGhLeS93ZTZWVUh5MFQrM280aVJW?= =?utf-8?B?aFI1TWJlSTMrQjY1WXpQaHNMM2RGMncrK0MvdEZlYkpheGZRZVVRelJKZysw?= =?utf-8?B?Y0FTSEVGVkpXOWtVYzBETEsydHF3azZkWkpmMTh0ZXFLOW1QMXU5U3FoQ2ox?= =?utf-8?Q?/qWTUdaaaYxXtB/LJP9vbIO+T?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2af263b-fd6f-4f87-c8cd-08dacdfb38a6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 09:06:49.8223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FuQf5Tjz2CU3/lSKcBSY9C5hUkGu2CvcIJjmzpP3aEj5NJP7iY3qrE7PWfJhSzbgAzke5eqlO8D2ndZcxpn5pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9392 On 24.11.2022 09:42, Roger Pau Monné wrote: > On Thu, Nov 24, 2022 at 08:59:00AM +0100, Jan Beulich wrote: >> One related question here is whether vlapic_do_init() shouldn't have >> the non-architectural side effect of clearing evtchn_upcall_pending. >> While this again violates the principle of the hypervisor only ever >> setting that bit, it would deal with the risk of no further event >> injection once the flag is set, considering that vlapic_do_init() >> clears IRR (and ISR). > > That would seem sensible to me, and was kind of what I was suggesting > in: > > https://lore.kernel.org/xen-devel/Y3eO0bMKRPYJc2yQ@Air-de-Roger/ Oh, I didn't read it that way, as there you said "when it is enabled", whereas here I'm suggesting to do so when it is being (re)initialized. But, as said both above and in the reply, we'd need to be sure of the resulting behavioral change (kind of an ABI one) being acceptable. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 24 09:11:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 09:11:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447899.704516 (Exim 4.92) (envelope-from ) id 1oy8GE-0001Bd-Li; Thu, 24 Nov 2022 09:11:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447899.704516; Thu, 24 Nov 2022 09:11:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy8GE-0001BW-IS; Thu, 24 Nov 2022 09:11:10 +0000 Received: by outflank-mailman (input) for mailman id 447899; Thu, 24 Nov 2022 09:11:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy8GD-0001BQ-B8 for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 09:11:09 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0602.outbound.protection.outlook.com [2a01:111:f400:fe1f::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ee25d347-6bd7-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 10:11:08 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7805.eurprd04.prod.outlook.com (2603:10a6:102:c2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Thu, 24 Nov 2022 09:11:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.019; Thu, 24 Nov 2022 09:11:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee25d347-6bd7-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MWf+PNn9AIqM5kcmKoqs/+RCx3PWXoSQkMFT9zvXZbA40KqlArleyHLbeD32DRZJhZH63pROFRAPY59NAszJmHOk/hSd7WIFXRlQPkvil+592ZWYK//NTkyO9dmLbGJRFx+a56IipW1coovMMEfTSP0aG8QYHeZPNjiDbshrc2QrzSmcka9LwcwhnsX8WYc5qZjInLN4V4OVVqw74rE6nLQce4tx4fEXJh9Gntnt/vbgyJlmfafgWtMICJFrwUYw4Un0g5dXu17xFSsJHwjXRyATAU1eQKLwmRRSictjeQH1H+frHDWOt5HpFv83QIr1SKsg3tPXKmAcbvrjXMeHYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g0ov05lpmgHe2Wu0m2soH19Sh3osuAD12ntAahKDk4U=; b=lR2hJPozCI9kHr9IeZcdVDLn/zZI4cf3zAjUF/QjJSj0ImiktjWI9Akr71/7gCiQXhjZ9n3mNrew2O/UG0r152KA8CmPXWlK4S8tUIBk0YJj0i2IL2qYQMS1UTLjeI1KN84oQ2WDmMb9ypaCNZg9AV0UKwAYFCuKNPZO4XeqqUS3vTsfyUZZJ5RBnRx4szolyq9A4qG+WFNoTnvjXZhRNYngNvCaChcF9YUjVBz1404d4HW2UFZKqJbKqnu0dckTNAWvR9EVxyNTvR+M39qTp05CAbSsSZVMjInGLiAZYVuhMooYF605Y8MB2H/TVdrvVYsCDSzeUALlTjwloCuOeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g0ov05lpmgHe2Wu0m2soH19Sh3osuAD12ntAahKDk4U=; b=0Mon3d9FQvt7qwyjnkA2rxceKBb7aqVnncMgnFJ1NsK5fxrAWBkDzrGyJPck2/c7ETWz1gH6LwduJ7peOT/PHyAjec36iSNmfV9Xj/Sw+sNB03lC1Lw93jfhKj0xfwV1WzxwT+yBx08OmLg6NwGm8CbLaVP3hfQ45SQp/R3Zjz0xiuw0mPXWprK1ADxMwIvL+mpATpvWxTnLyStSssi44/d3yz8JhbV1NnM4icZn9MtdJ6TezzTpS6OKAz2lZMK60nXy9x5tLX53tH9fUM5Im4vdg7dVlj2TesHu7DkyulYvSaMGndsoFLxIi1E1m8kG/0285SNeTJ7nFLQfj3OsOg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 24 Nov 2022 10:11:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> <5a2df843-1acd-ad78-baff-e47befd0703c@citrix.com> <878e635f-b116-3580-945f-f8acb711a5bc@suse.com> <69507b8d-1f31-39fb-7469-e240fbfdde44@citrix.com> <33a005bf-0596-c624-0e70-077a450ac2ae@suse.com> <351a6e54-8002-aef0-993a-c6b8bdcc1e8e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0029.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7805:EE_ X-MS-Office365-Filtering-Correlation-Id: 04b587e9-9c0c-4f76-e5b2-08dacdfbd192 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8JKSvSvhc+1YsHGFZSGvBuF8mAja3XPqB477cSHQMwGDoi6L1etUSoAwmVnrA1Rc+tQMCA5OmNZ8YH02uKJ2rTUkckqUkPKhW/eYYfnc7NZkkcJ4Pb3LDLcTVYyXd+LMwyWa8qs4jjIyTGhEwmrVP294R8sFQ6Wt3kRSl5hrEOGmgrM9dhqqitdcux1O7PvZtgBRJxBH/RmLHUG9+adMh6gob2t0JK2t5Lpm2UiATYB7ddByzDNLBFXSpAn8TM9IfEI4UdmzT1iCADsp1dBFJK+klvuIWxdN71oq2g8Thn9MsJwAp9ctT12ErA0qdmAgVTk76UAmV8DZ6e4PH+g/E0/SF74XgxD1WSUUqohksPNgPLJZCay+u04z4TWZav6OAJOVf80uWg/ZNm/vPCHpdbyeChgukhdg0/Gn14CGVto2m0KVPw7BUU4YKMN20P9m70S/ekpUuBU1miWXf/7wAeEcgixuZiSToSO4IW41/EyO4HtuIM59w2kTyQ6di1vzLgni43hGRFd85jhy0zI1dJgGDtnwB9h2lLCCpz5Y+1wfEpYcDK7budapYuKkFlfsURRbeMgTOtGrXhVO3FyJyOxNDEtPt2ZPUJgHu+8PJxtiZ48ViBM2kMqJYQrDqbqn/RrrgN2HVduRUon8Dp9uiguXmTATk+btQB/aqZ0CswfN5/WWGg6tSm7ufESqKZUQe8MuqVQjR/1VN0a6TJgCbO2UlZWDiPN0+xm/WDMACunWhw8k1dD4cluubxTXFOBnNxiMI0L99uwkVGYk/jhKGg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(136003)(346002)(376002)(396003)(451199015)(66899015)(36756003)(31686004)(6506007)(86362001)(31696002)(53546011)(38100700002)(2906002)(83380400001)(8676002)(41300700001)(8936002)(66556008)(66946007)(6512007)(5660300002)(26005)(186003)(316002)(6486002)(478600001)(66476007)(4326008)(966005)(2616005)(6916009)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjVrak5BdUZXZkIwYkI0OUhCNmpKUkRSc1dOU0Q2enZhYmM3SnRZY1ZmNFE2?= =?utf-8?B?dTUwakxYeEhNZnArUmNWbHNDWG1vdzhBWnZkYTk2cW9mRWpBSTcxN0dPdTVB?= =?utf-8?B?OWNuOVl4TEkxRFRBbStBaWxhVnBmNGtXbnNaRzM4UHdjRFJFMisvR1lubzIv?= =?utf-8?B?NjRlWm9rRExPeUp1cFgvU0RXdmcyalI0RHBxSjRlZ1RZZWNZeHhIbG5SUkdy?= =?utf-8?B?TjNXdWw4SzdPSDFYV2VpNWR1SCtOdkFrVWRsVlk0TzEwSXZ4TmlURW5TV1pi?= =?utf-8?B?OFAwMkpZc25hZU9qQUdSWTdIU3ZRekY4OGlzbCs1VTVXWXZubDhNVFFmMDFt?= =?utf-8?B?T05GWnhHV0dZaUFyNit4V1NITEM0OUtZM01CSzlEZVlOdWpyT0tna0hjMHk2?= =?utf-8?B?REZSTnNsSjN5MUw1ZXVkWThRdXVBakZaeENYWjgyUkkyaW90RysrUEltOGI5?= =?utf-8?B?a1lQcHRyTTQ0TlNpVG1UcCtOem5HcmZFbmxESVNwZE5kek5qNVp0RFdpTS8v?= =?utf-8?B?QU9laEVZRlBvMnZxV3NKLzVVM1VHS3ErQmdjR2ZiTzVXNlVqSjNQSjJVWHJ6?= =?utf-8?B?cStUa1FzMFJnZWZsN3NKOXNLOHBBWGdDcmpQSGJWeCttNHREUW9yRWNoQldK?= =?utf-8?B?a3JJeTQvdzFLRHJRdTZ3M1UrTER6ZUlDTXh1NGxXYS9nQy9qZHZkMUlTYVY3?= =?utf-8?B?YUxwYnQzaWFQMENiVi9xdUNlZlprVjlac3M0R2NRK1JVbGNtR3FkR3VWbmFF?= =?utf-8?B?WmNuVjhOYXZaYkZFSURxQmp6d0VWQXdNSnZCczFwSWpmWUU3dEthL1FZSUxH?= =?utf-8?B?SFY5Y3c1UDFxQXZmelJ4b0tOSDJpV3E5ZHU5eC9yWWc5WjBtaG9jdkg5ZTJl?= =?utf-8?B?TFVDd2pHRm90L2xkbEgwNXN6U0pTRGxXSUFZUGh4SDNBQ2h3ZitLRmduWkdY?= =?utf-8?B?alNZUkpPUVl6VmdyamJaMDB3TDNZai90OVYyL1orY09Wd0tQM3BJRU13eldS?= =?utf-8?B?ZHdCZktIZmJvbkZUVmxYK3A2bDVOQUFUbXNGM0FzQkkza0VVTXhEcmdReU0z?= =?utf-8?B?QmcvWWFEZkdtdjNhTWNBby9Mb05uaU5oNUdrMmpQSWE1MEJSN05kM3RnLzhI?= =?utf-8?B?ZlpWa2dmdmdZOWoxd3U0aE1JRjQwcWViNXBOSTlnTUR4SmIzeExTL2pCd1p6?= =?utf-8?B?V01SSWxoUnZvSm9Lek5PZDk2K0Y1ZHZGRFpmNlVtY2QxVUVDY1F4VTVjUWFN?= =?utf-8?B?N0ZPRXFndmtYQzBoNnd1TmRMNE5jSzRKS3Z1M2gxdFlyWlp6Y09XZHA4V2dy?= =?utf-8?B?SEU4R0QycFRta0lYcU4yNStNSHRkdWJNcms4ZHRlV3hCcWhNbzJLOEJKbkc1?= =?utf-8?B?VTJMM1pLSjE0dVVEVmd5Y05rUjlHZVdSSnYvTlpoWEE3MTZkYW1FamJ2aXlJ?= =?utf-8?B?bWt0STIzWVhWQklvai80a2FsbnhUMXZyUk1ndmFUbEFBTGdkVEtQcUpsVkF2?= =?utf-8?B?YXE2SE9xekZIenNKeFNvNnZudFNOSVUwN05mbU9uNWpKL3ZOWnRxSGIzMnZi?= =?utf-8?B?YjR4S0RaQkJOZkl4RURVWU9qTEVkZFZ5MVZrclBPY2ZMc0N3THl3ek03VUpO?= =?utf-8?B?QnRET2E0Z2U4dGZQVlEzbDc4U01GV2ZVNk1MYjRrTUFIMHRESjNwVHFKZkRG?= =?utf-8?B?VHNMaG5YMFpPaks3SnNQNUdWQ1hybUIwcy85MElmZUZhMlVYMlZDTENuWmlG?= =?utf-8?B?ZksyY0JGOXJsdkV4MUNrdnhNanhjTHV1SEtPUkw3dFMrQXY2N29FRGlQblh2?= =?utf-8?B?NTlZbkNvdFQ0eWczeGhMRlJFMjY1NDdiZ2hHWGswSUdXQkJ3dFkvcExNNnNP?= =?utf-8?B?MnQwYkJXZlRTUkpieWRYcVlaWmM4N1J5YWt2Yjl6NHhoWHUreU1WRTJ4Wm5n?= =?utf-8?B?c0h2UnU2MWtjcVhsL0hWS1BFdjJ1Zy9YaEJoQmxLTUlhQlBMSVl5NXp1azBM?= =?utf-8?B?dkxlSHNBdElPNFJtc1hjTzRaUXlmVm50N0Zmc0dhZGpBbFhLMnphZXIvRUJx?= =?utf-8?B?TS9QaHc5WU1mZ0RsS0wrN0ExbUorZnlLY2lHU1pOZVdFWmwrRUlqS29uU1JS?= =?utf-8?Q?lIRzD5L7WfGy307i9unJUTvaj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04b587e9-9c0c-4f76-e5b2-08dacdfbd192 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 09:11:06.3834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 31Bexid5mBzauFud0tlBlWt25M0wIifZXBSACL8Jj/yB8Wl/0zoeo4Bs+Vj7NiTvQME3nTlK29+3EVnV1o86Wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7805 On 24.11.2022 10:06, Roger Pau Monné wrote: > On Thu, Nov 24, 2022 at 09:42:40AM +0100, Roger Pau Monné wrote: >> On Thu, Nov 24, 2022 at 08:59:00AM +0100, Jan Beulich wrote: >>> - problematic wrt evtchn_upcall_pending, once set, preventing event >>> injection later on. >>> As you may have inferred already, I'm inclined to suggest to drop the >>> the is_vcpu_online() check from hvm_set_callback_via(). >>> >>> One related question here is whether vlapic_do_init() shouldn't have >>> the non-architectural side effect of clearing evtchn_upcall_pending. >>> While this again violates the principle of the hypervisor only ever >>> setting that bit, it would deal with the risk of no further event >>> injection once the flag is set, considering that vlapic_do_init() >>> clears IRR (and ISR). >> >> That would seem sensible to me, and was kind of what I was suggesting >> in: >> >> https://lore.kernel.org/xen-devel/Y3eO0bMKRPYJc2yQ@Air-de-Roger/ > > Another option would be for vcpu_mark_events_pending() to > unconditionally call hvm_assert_evtchn_irq() regardless of the state > of evtchn_upcall_pending. I think you said so before, and ... > This will create some spurious events. ... I continue to be afraid of s/some/many/. This event delivery is meant to be kind of edge triggered, and I think it is a reasonable model to treat the flag going from 0 to 1 as the "edge". Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 24 09:34:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 09:34:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447905.704527 (Exim 4.92) (envelope-from ) id 1oy8cf-0003zJ-ED; Thu, 24 Nov 2022 09:34:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447905.704527; Thu, 24 Nov 2022 09:34:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy8cf-0003zC-BT; Thu, 24 Nov 2022 09:34:21 +0000 Received: by outflank-mailman (input) for mailman id 447905; Thu, 24 Nov 2022 09:34:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy8cd-0003z6-Px for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 09:34:20 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2a01a68a-6bdb-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 10:34:18 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Nov 2022 04:34:06 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA2PR03MB5945.namprd03.prod.outlook.com (2603:10b6:806:11c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Thu, 24 Nov 2022 09:34:04 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Thu, 24 Nov 2022 09:34:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a01a68a-6bdb-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669282458; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=c4IbSwzwTl0OoLd2aUTQuPhgcrA3NFgPYZWM8pjfb9o=; b=hxV1I0HYovlRkYV6uOy0IbwJ1A8yWREHu9sD3ZEt2Cnzc4Ds4f179Qls 3iTd1gt/2If1+FkfUXrzDtU9/jcDVvBAMpSVu/uUcUdC3dNlieZiHuOB4 osGRG9TVeZtGySFl++HpeEAJyfAHmJ4Fqs0y7cLMOt7Z9BTjEsTrUl34O 8=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 85057107 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:DYYajaLSm1WI3ncTFE+R5JQlxSXFcZb7ZxGr2PjKsXjdYENShjZWz WBNWTyGO/uMNGKhKtB1aNi2oUJUv8fdyIMxHFRlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wZiPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4oHDB+9 e42AQkVYzbdlb6yzbSWYddF05FLwMnDZOvzu1lG5BSAVLMMZ8CGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGNnGSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iLx3rKQxHukMG4UPK2EzPtvmAy9+mUSLCEuRWfrm/KotmfrDrqzL GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O/I+wBGAzOzT+QnxLnANUzppeNEg8sgsSlQCx lKP2t/kGzFrmLmUUm6GsKeZqyuoPioYJnNEYjULJTbp+PHmqYA3yxjJHtBqFffsisWvQG+gh TeXsCI5mrMfy9YR0Lm29kzGhDTqoYXVSgky5UPcWWfNAh5FWbNJrreAsTDzhcus5q7AJrVdl BDoQ/Sj0d0= IronPort-HdrOrdr: A9a23:sI3iW6zcuYSpmmFr8plnKrPxTOgkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu vg2iMLnUvXRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirCWekD+y77b+Mh6AmjMTSSlGz7sO+X XM11WR3NToj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhn8lwqyY4xlerua+BQ4uvum5loGmM TF5z0gI8NwwXXMeXzdm2qn5yDQlBIVr1Pyw16RhnXu5eT/WTIBEsJEwaZUaAHQ5UYMtMx1lP sj5RPQi7NnSTf72Ajt7dnBUB9n0mKyvHoZiOYWy1hSS5EXZrN9pZEWuGlVDJADNiTn751PKp gmMOjsoNJtNX+KZXHQuWdihPSqQ3QIBx+DBnMPv8SEugIm6UxR/g89/ogyj30A/JUyR91v/O LfKJllk7lIU4s/cb99LP1pe7r4NkX9BTb3dE6CK1XuE68Kf1jXrYTs3bkz7Oa2PLQV0ZoJno jbWl8wjx98R6vXM7zP4HR3yGGPfI3kNg6diP22pqIJ9oEUfYCbcBFqEzsV4o6dS/Z2OLyoZx /8AuMTPxbZFxqfJW945XyBZ3BsEwhubCQ0gKdOZ7vcmLO9FqTa8srmTd30GJ3BVR4ZZ0KXOA pxYNG0HrQM0nyW X-IronPort-AV: E=Sophos;i="5.96,190,1665460800"; d="scan'208";a="85057107" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KEHS/fVEsUekBGFOuLxckT5PenW4/8lUyuBuemZ6RaMVTyIeQNbNi+ymwm6Nof+WthJIbBbd+1fyEjtw7x8K3P7CSpk7ZN9sagb3dVdM9wR+BxR3CNDPUH86e06sg1mSYAO0zdxyPzihi4Z2Vfub0YQMyegQ1RJYZS8xLuIlZYKI8x/slnR7q6ZrTJex534TrrngCSJ0zbMVphTai9ykVqWf7xneILGKGe7gAgcnWZNj6cixPRYDUbb1c2iZcOgwmyOXEsc/VYLVmD0LKce3jtMHfMEMS1r3PX10kqAWkiPWRimY8Pax6jD+J3A1DEe1GTeTBasmyRbHRlwM25C61Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cbWtRUD6295XrWrZxbiIlgQl0Q7ZXI2GS91OHkIterU=; b=jyG2ev2HS/3tkrx5zrhmOrMNpgPN/2wy+P4Faxfn4G/IRCOpDzwhrkZNKF/sWSRqGLFloJjLFtiHmR1Q05/pbf0Oj6rpKiY8D+6Ar7BXeGn1HfyPdeApcBQYEihyd23Q87GQVXVgRP141sib6Qpd8f8X2K727bNi+3VdLrZEyHB1iv87gSaBbDXLHiUJvHOWzflCevQ6ZMShWjq2ihS+GfWpT3xGpIsfqtB9xz/nC8EQKGBRQNcsVpUINZ+NxxK9yDTpTwh2FIP4sy6BHIlIhUCrhI8uaVTSqGWigqI2FjgsSsnUXbl/oNNNkBof5EpRf1AxxlwlUFxYcj4HH57OrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cbWtRUD6295XrWrZxbiIlgQl0Q7ZXI2GS91OHkIterU=; b=NfR2B9sXASJBMqnyCMjRMpqyoUHewZePnaSHpXwhP0lJs7YfQ0xgSKWTqDb1LZtp84TJixBBHxZI1pLSZ6XLSfA7DMY4XbePthMUqxusxoBC18ZHVXp1nRF/zmJxl6sxLvwMFft6uf/+gz6Un41oZ42NErBVOefVLCnVTi339eg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 24 Nov 2022 10:33:58 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Message-ID: References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> <5a2df843-1acd-ad78-baff-e47befd0703c@citrix.com> <878e635f-b116-3580-945f-f8acb711a5bc@suse.com> <69507b8d-1f31-39fb-7469-e240fbfdde44@citrix.com> <33a005bf-0596-c624-0e70-077a450ac2ae@suse.com> <351a6e54-8002-aef0-993a-c6b8bdcc1e8e@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0191.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::16) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA2PR03MB5945:EE_ X-MS-Office365-Filtering-Correlation-Id: 05ec549f-b626-4446-fe90-08dacdff0695 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cqZ+9NDjwbUWx92y+UHnqhauE39+KEs6gFiFT48KAceGU1P0kRiyu9yswWD1+gcjcw/bHraWE6660J1B4PEbcqPAgoVX9ngTuE2Mie69k5TWCNlHduE/+J+DYaRDqXjl4yA5mx5IEXaHOeB9l/+EF3iNGsPwLu0pgTtkfmiriuFFogr4CT46NTQDaeS1KbRzuQdcRC2Cl1Pr11MOMmUpUvD5I4vV3yyy5BUHVv4SNougNkRl0oXczORPIQghjNXGHs7Cy/nofdR4M0Qw4kAH/2SLRkc+6VLoALNne5U09HP4uUi1NZcMdjrUI2AyBhAxzFmUrwU9ormatAusKBVtDBTugFtprj2vJQLTuEKmrVP4VvCm/DvaZpshzU5pnoI0XH4om78w79vnx2pFlP6gjJjT0cb4256xyvjDEz4BU/CktyBB9+I5kp3MbunrkBKXNZ3s1QS5ZRx8FmP0aPKzH7H8KxImmGxQPesJI5+FcI5qGI0a5CqLSn1VIf7fdOoCanm71jaLeTLe9G/bwf7vAEKm2toTjOF9Nl3pXk68vO3GcBVHk2OJU8hfTcrMwSlorLPNc2Q2/gRIVN2+Wi9Cc3wi5utozCz78mfAMptkW+gFJg8ZiScjp1oWb9LcQwfT/R3XwaiNhb2H9g16vVQKf7r/cCyhOjzt5yg341cuE4I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(39860400002)(366004)(396003)(136003)(346002)(376002)(451199015)(85182001)(38100700002)(41300700001)(2906002)(82960400001)(86362001)(6916009)(966005)(83380400001)(66476007)(66556008)(6512007)(186003)(9686003)(66946007)(66899015)(316002)(8676002)(5660300002)(4326008)(54906003)(26005)(6506007)(6666004)(6486002)(8936002)(33716001)(478600001)(53546011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFgwZUs5eTc0RTBlbzJtSHB5UjdNdlNuMzc4dEJpekpYbVdBcXhzbkgyckFm?= =?utf-8?B?MXBCcTJuOTZ3R3dHTFNQZk9EcDFJeFBtMDNQVUFFTWdsclF5S01rdVBQRjNV?= =?utf-8?B?cDlWTlFBdXZ6ZWJpcjNsYnNiMERyNnREK1NQbkdwQnRuTEExS2Nwa1pDN0JM?= =?utf-8?B?MGRoS1d5ZHhiQUZlK2xQeFRqd1lQSFpUUXcrS1Y3YkNuVkJlZmNoQU9vSzdz?= =?utf-8?B?U0ltZ0dCb1QycGFiU29ZM3RpZHVJL0xiTDdCaFNrODluMElXNlVtSnE1N2s0?= =?utf-8?B?OVEzT01PdWVWeXN0aFQzZnNHNWFxL0pKVEtmTXBidUFicGdxeTRvL05kM0pJ?= =?utf-8?B?SjdmL0l1UXNGRUFWYkQwZWpDV0pUOWhiNWYyVzVzKysvZ3RQZlUyZFhVd1U5?= =?utf-8?B?SkFGVHJEbEtZS2R1MC9mYkprQTJreXRjbVFXRUxJbVZmbjRtT2NZS0kzb3Nl?= =?utf-8?B?RHhQcUo2T2I1aldPeHo1OFlEbmhSTkVZM2NGeE1xY09rT1RJaDFiSnhNWUR4?= =?utf-8?B?UVdBUk9XL3ZBYm9zZHkxQTM5SCs0Ylh1RU8zMk5DVXFaZ3Q4ZzlielJLUWl5?= =?utf-8?B?ZXZXNHZmME5pbXZqMnNPZ1R5dWk3QmdpWmtzbUoyb3ZXeVBzOGtkMVpCWTNJ?= =?utf-8?B?RVpiTGNlUWlCY2dQVXk3NkVmUkt0clFxR1JnWFdWNWZRa1RtZklRbVpEbEZP?= =?utf-8?B?K3E2S1AxTDVlcU0yZFk3bU1WWVByYzVDMlFhWHY4VmxJUWljaWpsSDF3aEsy?= =?utf-8?B?NUd3UEhJaWFuQ2phTnhxaTFDMWtBTFhRcEhsdmJSY3FlYUVIbFZNL1RGa245?= =?utf-8?B?T3ZtckM5bXZWdnBnRm90VnBDV2NsdXY0bllXVGdOWWUzZno2dHl2d3pkTFVl?= =?utf-8?B?cEZMM2hsc0ZkYWFiVlZPQnRPVmI3MThSczR5aW92UWhNcEhzcksrZXE0cVQy?= =?utf-8?B?dEY3R2svaFFvT2FCcjdFYzF4RmlId2RidUJOazR2YmtqUktldFlXa3dhT3VX?= =?utf-8?B?bllxWmYyc0VQUzRWNUM3aHgrUHNXaFlrTS9EcHZHaGtnR3ZBOStieTVBVnZu?= =?utf-8?B?clpGQTE4aVpyM3l0OFR6Tmc2S2lONm5sd09YMmtiRElQRkZYQm9TZy9jeFVZ?= =?utf-8?B?RHF5K3Y5SlVxTTZNanM3RlZ3cVNKNnBKWWFzNjBOcjhQY0U3N0Q5S2Rja1Bj?= =?utf-8?B?TWZzZDF6RUU1d1BIRDRSTk9QckV1ZW5vQjBPVlBLY1l6N0dyVGlIeUZaN1VQ?= =?utf-8?B?eHlKUm9OaHhtd29OOVhyZW02ZWIvdzNZUDN3bG9hTXNYY1ZhNDREdU4xWFhq?= =?utf-8?B?aC9YZ3dBTWZMbXBleTJ1c2xFaEdKRHpBYzRyVjJsQzAzS056UUllMnFYYUdj?= =?utf-8?B?ZFJZcDNLcW1pODRuT1AzYXV1NStjamhsU0kzai9SN2xrMm1qUTVVWDh1bXR4?= =?utf-8?B?eTcxUDJsdmQ3bHJCQk5mSjdOTW1HSEN3NHNQR1RCc3E3Z1Zrc1M4dVhGdWQ2?= =?utf-8?B?eGJMaE1pUTlJVlpVS1dLZkNIcmRwZlJmNzdtWTZYK0ZoUjRYUDVtb1N6dlJY?= =?utf-8?B?ZHp0MGMwby8rcmgyakdGTUllMWtEanN2eS9zZytHNERGa2dGS0NPUElFMXQ2?= =?utf-8?B?UVJBU3JXckJ3bXFvT0Q3ZFpnODkwcURJdkFMR3o3T0ZaVS91ZVJFbW9HMW5U?= =?utf-8?B?QXY0N3lBZnZyYWV6N0pRZkxHUU1wZ3gvcy8xbVp3UkJTUENYdHl5bCtzQytK?= =?utf-8?B?UXJrZEFaVklyMUlqNlFiNlVTbFk5N3VmZWdYSDkwQm50QlN1M09CU3VHcklJ?= =?utf-8?B?SHhIZ29rS2V2T1dNSUFGNWhwZUMvQ1V4T05vLy9BVFpSZ0hGSmVhSktjZFB6?= =?utf-8?B?MGRLRExqenJKNGw0QXppQ1VWanpnNHJuOFp6Tm9CVGVmVUZTRU9BOWRnQkpQ?= =?utf-8?B?b2ZsM0FhTHlRRGltMUk5U1VpZzluOVN3MzF6SkdBSGxweUx1NHFiVE4xR2Vu?= =?utf-8?B?V0psaDVTNUNHQ1VNcitGcFhtYnlVTGZmS0lDY2FTL3Z1elFDNUc3WHh1UXA2?= =?utf-8?B?ekp4ZHlsOGZPY0ZISldUYkxZN0JEK0dqV2hFNUhjbWRkbmJFSEZPM2N0aTNy?= =?utf-8?Q?Yey5fa7Vl/jE4ds53WPNdoq9o?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: nT1nCoobnpUzcZkbyUgoLRqd3rVxrExNrzmcxnhV7ivSNyxVrPNlYZZWcX2WAP6DE/bIvi4QEdcw5av3NSOQrQ4EFbibkpolD2iLUAkdGxOMasYL0cqMsbgn5aTICsAt0IdfFxn0CnkaGNvodvA1FI8u1TycNL2dEMTY0QDP4xIO3U8OeXTXoyu5A3YhzOSqXc96b41Lckr6uUZTU4JCjL8m0l4NCyvaeUH297byMeA/YA7dEsd97cho4g89upSbPUS0em9E6OHTWh2P/kVR2GCeQ3RKPithylW5pRI4ZdDxE84C+BbO7o7z7FWyIIlbASmEXZt01DYjYoX6gH5RZLAApK8ZxPEXHHxXEtimW2WtANYmi5PV8V0NIrG3XkUbOWFRZx2gv16BDS/+6WaG2BMEWzzDTJKoYkqcsl0aplnhHQlwuURlCzd1DYU4Kz4QueTS0swz5lNFxQOJoHO8uw5+E1TULepV5pNJtv+suFuk9E+DB+jHd806Iq+Ssnqy+xNoOXOldfspJoiF1AW7JtPz38Ubwlq81iO76MYzpVblmORBfCjdDU95u4cE+IafDwU2zH+vvPF4CPlXfK6VQgkp5EOHLCp8mWZgQjcqhsT153kmolWxlGYC9smHB5h3ag2yWqcaFARMJpWp13sOpS2Y2EMlUmNY+z1XUVbc0gKuiV6d1KD6Ti5S+sxuXth5K92HNXUoW6ddzjnIMn6cq9XAkA0lGM/nyLflFHp27u9jQGqqWVlvS0xYBtFNrkPJZDdRYnCZLg2+Dl9lKIK7OiOr+agw5KC6emt4WjuZjxqG457he+f+7D3EmlVXlpaflhlrPUKJAzN6oFa5BFwOAKlxHqIZSW7dbHLcVlWPpZ0= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05ec549f-b626-4446-fe90-08dacdff0695 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 09:34:04.1724 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h8q9nXU7s/pieyIdwK0iezdJfiGxtesSQc9L6mnymfM35UqRSC0+3W4DEsQIDLcZalr3ayy0sDmxK3RfeJWpCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5945 On Thu, Nov 24, 2022 at 10:11:05AM +0100, Jan Beulich wrote: > On 24.11.2022 10:06, Roger Pau Monné wrote: > > On Thu, Nov 24, 2022 at 09:42:40AM +0100, Roger Pau Monné wrote: > >> On Thu, Nov 24, 2022 at 08:59:00AM +0100, Jan Beulich wrote: > >>> - problematic wrt evtchn_upcall_pending, once set, preventing event > >>> injection later on. > >>> As you may have inferred already, I'm inclined to suggest to drop the > >>> the is_vcpu_online() check from hvm_set_callback_via(). > >>> > >>> One related question here is whether vlapic_do_init() shouldn't have > >>> the non-architectural side effect of clearing evtchn_upcall_pending. > >>> While this again violates the principle of the hypervisor only ever > >>> setting that bit, it would deal with the risk of no further event > >>> injection once the flag is set, considering that vlapic_do_init() > >>> clears IRR (and ISR). > >> > >> That would seem sensible to me, and was kind of what I was suggesting > >> in: > >> > >> https://lore.kernel.org/xen-devel/Y3eO0bMKRPYJc2yQ@Air-de-Roger/ > > > > Another option would be for vcpu_mark_events_pending() to > > unconditionally call hvm_assert_evtchn_irq() regardless of the state > > of evtchn_upcall_pending. > > I think you said so before, and ... > > > This will create some spurious events. > > ... I continue to be afraid of s/some/many/. Not _that_ many I think, as we can only queue one pending interrupt in IRR. > This event delivery is meant > to be kind of edge triggered, and I think it is a reasonable model to treat > the flag going from 0 to 1 as the "edge". Hm, it's a weird interrupt model I would say. In some aspects it's similar to level (as the line stays asserted until it's cleared), but we don't get new interrupts injected into the APIC. Maybe the right mode would be to treat evtchn_upcall_pending as a level triggered line and keep injecting interrupts until the line is deasserted (ie: evtchn_upcall_pending == 0)? Sorry, I feel like I'm asking more questions that providing answers. Roger. From xen-devel-bounces@lists.xenproject.org Thu Nov 24 09:48:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 09:48:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447910.704538 (Exim 4.92) (envelope-from ) id 1oy8qR-0005l7-Qh; Thu, 24 Nov 2022 09:48:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447910.704538; Thu, 24 Nov 2022 09:48:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy8qR-0005ky-MJ; Thu, 24 Nov 2022 09:48:35 +0000 Received: by outflank-mailman (input) for mailman id 447910; Thu, 24 Nov 2022 09:48:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy8qQ-0005ks-Ov for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 09:48:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy8qL-0007s3-Vt; Thu, 24 Nov 2022 09:48:29 +0000 Received: from [54.239.6.186] (helo=[192.168.1.238]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oy8qL-0002gj-Ni; Thu, 24 Nov 2022 09:48:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:Subject:From:Cc:To: MIME-Version:Date:Message-ID; bh=tcVUoR4KbJwiz9hwZb+tr9FFKbd4IL+/0gkkHkNmrRA= ; b=7FJxCTlQrT4xbZm1s7d/DakEl20b1Uwkxs54NenNb49kr6ZITJMWZXbtTgyoVf8YK8yYvtwh5 ov8VbD4O7SLZNczYHmBCbZHkKNetstJdrY2AcTj8EVQNlH0UA9bMurQB4P83+lIfSMnDuk/l36lGM 2JMMMCY+W3RPMBN/DYSG8=; Message-ID: <3deaeaf4-dd5d-93cb-2ca5-3c22e2c19bff@xen.org> Date: Thu, 24 Nov 2022 10:48:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: "committers@xenproject.org" , Henry Wang Cc: "xen-devel@lists.xenproject.org" From: Julien Grall Subject: Commit moratorium Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi all, We will be branching the tree for Xen 4.17 in the next few days. Please avoid committing any new patches to staging until further notice. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Nov 24 09:56:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 09:56:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447914.704549 (Exim 4.92) (envelope-from ) id 1oy8yO-0007Pe-Hx; Thu, 24 Nov 2022 09:56:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447914.704549; Thu, 24 Nov 2022 09:56:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy8yO-0007PX-EL; Thu, 24 Nov 2022 09:56:48 +0000 Received: by outflank-mailman (input) for mailman id 447914; Thu, 24 Nov 2022 09:56:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy8yM-0007PR-7c for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 09:56:46 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4c37eb96-6bde-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 10:56:43 +0100 (CET) Received: from mail-sn1nam02lp2043.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Nov 2022 04:56:40 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA2PR03MB5721.namprd03.prod.outlook.com (2603:10b6:806:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Thu, 24 Nov 2022 09:56:39 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Thu, 24 Nov 2022 09:56:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c37eb96-6bde-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669283803; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=CMr5dIXXsXUxFLdjgkH7KyXgDdtkWRXsS4KPsec63cA=; b=Z5KPqekrvTcAGi0rruEQuPVXt3aw2E+pwgFlC8Gfi+xmMBv98kC8S2Vz lGxNShHnnJ60NKrawulkV7sClYMekAGJNtHf2Ap+WAkNMcd85ie25RY0V +ks6N4lfzIqQUelgesuFxFRa1kOMO2sAWahhw8JFIJ1t0o6QtFk7swPBI I=; X-IronPort-RemoteIP: 104.47.57.43 X-IronPort-MID: 85058349 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:+AcPn6kpfMRxGmz9fOz7B2no5gxvJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJLCmiAM/+OMGv3fNwlPIvj9hwD78LRzNVjTwE4qC8zQiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5gOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eQ+Mg9cZ0invL31z5LldMtl2sF8BfC+aevzulk4pd3YJdAPZMiZBp7svJpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVM3jOOF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efwHumCNlORdVU8NZY2m2r41Y3VyY9SHywsPaQhGCEY/Nmf hl8Fi0G6PJaGFaQZtz0RRixunOHlh8aRdtLEuc+5R2Ny6zb+AKQDC4PSTspQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkA9L2UPeCsFRgst+MT4rcc4iRenZslnOL64iJvyAz6Y6 zKXqCkzgZ0DgMhN0L+0lXjcmC6lrJXNSg8z5y3UU3ij4wc/Y5SqD7FE8nDe5PdEaZ2fF1+Iu SBen9DEtLxVS5aQiCaKXeMBWqmz4OqIOyHdhlgpGIQ98zOq+DioeoU4DCxCGXqF+/0sIVfBC HI/cysIvPe/4FPCgXdLXr+M IronPort-HdrOrdr: A9a23:ebvEYanvlbJAypFtu5lQIZNqF3npDfNMiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH7KGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu1Xh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboX0Twk6n7WXdrWrooMT/Sj5/I81dhbhBeh+cz0Y7ptlz3I 9Cwmrc7vNsfFv9tRW4w+KNewBhl0Kyr3ZnuekPj0ZHWY9bTLNKt4QQ8G5cDZ9FNiPn74IMFv VoEajnlb9rWGLfS0qcknhkwdSqUHh2NhCaQnIassjQ6DRSlGAR9Tps+OUv2lM7sL4tQZhN4O rJdo5ykqtVc8MQZaVhQM8cXMqeEAX2MFzxGVPXBW6iOLAMOnrLpZKyyq4y/vuWdJsBy4Z3sI jdUWlfqXU5dyvVeIKzNaVwg1DwqViGLHfQIpk03ek6hlS8fsumDcS7ciFuryP6yM9vR/EyWJ 6ISeBr6rHYXC/T8L1yrn3DsqlpWAcjufIuy6cGsnK107b2w97Rx5vmWceWAobROhAZfU66Kk c/fVHIVbZ9BwaQKzLFvCQ= X-IronPort-AV: E=Sophos;i="5.96,190,1665460800"; d="scan'208";a="85058349" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ALxt2gkS1TShh5eNx35E8SNs2wcjwFVDgK4EFDrGU4JjQnrUupGRSxuk9VZEr78sBJqxCJNc0rtBmD24rcYGgr9cJzFYRjUU4zGW5qSSqu6kW0pWH0srarSs4GmTCJicIqs8CQ5cMbJj0Sm/W+pbgMr4DRdivJEB3+YKzFXBmXeS/GrHaf/CTkQUCnXjSi2OXzeKAQ/P4YtbJqlA4+v/97LVxCt1rz6wMBq/AvjStncnDdwOVvbZk64dUu9OeD7tZiETQdHJCfILrMZ8b3amAHptMjtFgoEbINZG0BEfHjG0hfHJFv+9Ng6pYlnG3Dg1PKIjLScALIkKwTPAlPgeTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8jsLsQCrq0Picplk8ufZMvebnhipSQQ+qeftmyG23SI=; b=Ogo95xLM7omq3W9wS7a37AxKwj4sK7/a7gnosQfVPZ9BJric7nkgpTuL6BRbWlQ9PrjaGt6ryt+L2AeJ37zRz3etSMljsr/I5VpNQJ1uDV/nWEsv3LWteyYQsIERYLlktV0kEYYv5jjWpaNeDIDf+/Jc/b09JIqKreFCaF9UpccSR7s5jZbmoQG9Dyx/EisRe1Zd+wP234WxKfJ34A+SfxPADBMGR5I3w7wx5hFUBUmp/jfqwIojWRafCVsLNdz82rvt++LLkw6sZdTSRpp/LkCVjiPCbpQJGcejlqxtvJP5Ju5ZwUMkN7qaAQIcSMLmxVETS/7640jj/5/Gac+i1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8jsLsQCrq0Picplk8ufZMvebnhipSQQ+qeftmyG23SI=; b=TSCdIUPsNHN/opN2cVP96gn5sWbWxD1xeO/YbiI4x8yQM51cKksM3NSC/iDLOQdSkiuzjs65SBgo5WrfTybHNzbinyf66EPMZd8NWvZLvUEVbGaqiOOMNJHEwWGA//7k7/1zcaR5TH2S5yGGonoZyVDRJ93rVszVhEmX3PB/u3U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 24 Nov 2022 10:56:33 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: Re: [PATCH 0/5] gfx: improvements when using multiboot2 and EFI + misc Message-ID: References: <20221123154525.63068-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0264.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::17) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA2PR03MB5721:EE_ X-MS-Office365-Filtering-Correlation-Id: fbd07622-d658-47f2-f80b-08dace022e27 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bgT4tbuPiAFkWUYYJs7loZjXPuwsSR2pwyQmJa4tbj4j3G1ILNvTQDZtFwTpMywdLh26eH4K3wk2ym/GoirHD+tmUTqsA0shA3dRdmgBV8CnA0XJN7vmLN2s/xF4ZLf75VhQvVxypoiDOTqF0bAuFnU6uNn2KQ9XjF3dBs3g2+6mnj5b8BHIfSrBJLoOk/D3JE4AU8bm5cnyH3/YcriPL8w9JWsVtmAxso7MmsDXK9bduRri4u+2d16noDrzUspT28W3Zh3jY2xSLmndRsEMiTDF5Oni27nHx7RuuTYMeH7QVl3J0nYdQE3e9z6a17fA5EEy9bl+pmoE2XxW3h0+6eq4qdGhXa2khozXHWicsjj0UjGTI5N42Z8LJOXPqrR+hz3MkRdymnvuMrh7BqcQrc26TMo0naWso0aGd7zOP3P/zb2jk8KhZOV97NCNkFz9evwZDGmfB9IdoM0Hk5FX0i5aRUFxULWiCPjz3ylb10widsYrNTrQSsPq7S9PL9QoQeIVGDTRFRS1u3QUo9BYOUlMtUusjqfM7ll1A10cCbskuOC9eeNZnVzHbn2hfFWNF93V7QLltPGND2vgL0anNcCkyT8jM24OgN2Df3Ly+7LeaxHM+qDUCAXUyNNEieIrj7XWTWG4uukA5eB2g6FBRalpADtxD6LnBiKlSDNcLD8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(346002)(136003)(396003)(376002)(366004)(39860400002)(451199015)(6506007)(8936002)(26005)(41300700001)(83380400001)(2906002)(6916009)(54906003)(316002)(6512007)(6666004)(186003)(85182001)(4326008)(66946007)(5660300002)(66574015)(33716001)(66476007)(66556008)(8676002)(6486002)(966005)(9686003)(82960400001)(478600001)(38100700002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFdSTGJWY3kwdXVQSkJhU3hPV21xVFlYVEFoWk9KTHlWRk1nY1YrcjVXUmpL?= =?utf-8?B?bDJCbnU1YTV5RnZyRHdZOUxncEJEZkpUN3BiamFzSGd4T0pJanlLVDdXV0Mw?= =?utf-8?B?a3ZvcVY3NzZkMUNVU2ZtTGJuMVRoSFJvVnpCckxiRzh2aWxYdEdrWGtjSGtp?= =?utf-8?B?SVByV3NTcmV3YURiLzBtdDVjRktYRytjUU9BcGxVVDk3U1BKRkZ1d0p2Wmhx?= =?utf-8?B?T3JuYXYzK0tPZ2ZCSWpnRVlVZ2wzTjUySUpINzNXZHQ1RUxPbkxkREZ3Z0pu?= =?utf-8?B?N1lYYXRRMmxMcjdEWk45ZUl0UHdnR1RPaWQrQVBRTzMwL2d0RkZpRXc1dnVz?= =?utf-8?B?bVR2c1RmQU5IUHdhOUR0M3dsU3doTmp4VUxXSTR2cGQ4TVdjdnpRYXhkd3Ax?= =?utf-8?B?MWFDN3lBVkVudCt1aDNjVnpMaE0xdVpHWTFRQ2VNNGFXTUI4eGtTZXZiWmlt?= =?utf-8?B?dVNaMlpSenVSc3NHQWE2SW52eXJPeUhNdnByaE1TTXVLdWY1WlA4T3lkN1U3?= =?utf-8?B?N1A0TUdaM3NsUGd3WWdMOTN0aG03RlFyTWF5dGFubW5LNVkyd0hjSUhHZXR1?= =?utf-8?B?dXRvNG5ORjRlcDQrai93SjRDSTd4bGQ3ZzlaRHBEZ3IzdEFKa2djV002UUxJ?= =?utf-8?B?bmFvVjFrYWFLV3NnTmRJVFFEUnVUWm15MDRrQVU3N1RpcDJjNjZBNXljNW9i?= =?utf-8?B?ZkJKK3loSUpvOEhib2JFTHZzcjg0NEZuMXRMb2d0ZW1RQ2JyMkdBQUlaMStk?= =?utf-8?B?b09DbjZOZUFiZjRSNUM5czdiSlBMSnVmYjIwdmpwSU1WSm9mamdaWGkwMld2?= =?utf-8?B?NUwzdkpIaW5ka0E2ZzYrYmtOMDZFOGtIZk9SUWxoQy9DckMwS1MxcHBqQytM?= =?utf-8?B?d3Vpd2Z5MStSK3VPaWl4M241MFR1UC9KbUwvRGZYcjBrTmF0aGJmUHJHUTEz?= =?utf-8?B?MEplcldYU0lHVE1FN3ZuTEZkYkh3TXc3NGlxb2R4eTR6M21OZC9YTXVwc05P?= =?utf-8?B?N1FpSThyN2Z6dkVFVTJuZTFDL3lqOGNZMHA1SEhCcS95Tmd6elVKcTNZc0pG?= =?utf-8?B?Z3d0MHUyejRCWG5WakRQeS9ZM1d4VnZBOEMyUk5lOGkwUC9nWGJhbE9obTkv?= =?utf-8?B?MU9SNTJYOWd3UnR3WlA1S2ViRldnSi9uVVBMN3p3NVRBNXN2RHRiSG5tUFUy?= =?utf-8?B?YnJSZXg2VXJhcHlIWTZ0WmR2MDhFd3dmVE5QTHgxSnZhaVNkT1VsSjgrN1FY?= =?utf-8?B?T1FzdEdxSnhxZmtXL0w5UldVQXpFcnpuOFpXSXJkbk9GeU5CU2J3RXd4TmZj?= =?utf-8?B?Kys4ZHRtK0dsa3Z6TXRXWEQ2TitaV0I5bFFsc245dnd3RlFNSzBPUXNVdEFZ?= =?utf-8?B?WnlKS2E0UnR1V3JIdWxwTDN6NEdIZDlWYXEwK2hmMnlJSG1CWXQ4K29YY2gv?= =?utf-8?B?TU0vYnZBSzVDZ3hVMVNldEhKbzRYcmhpalY4a2J0SE1MOXhSZkxRY3UzWTFR?= =?utf-8?B?bUR6N09WUHFBeEpac1l6aUhuWWZ3YU5ZWFdhRUNwZzVjcEFrQ0h4RktIa3d0?= =?utf-8?B?am16UmVIRmpsNVExRjh4NzV3Y2NDZWtPUG9MMVRGY1VWMkhDd09XSGNWem1y?= =?utf-8?B?M3YxV3Q4ZjNxNjQ5TXBVOWZJNmdCRGt4MGVpWjc5YkhsYW1MUEh4bmRSbStG?= =?utf-8?B?d2pURVRDRXV4dXorbm4zTGFBOWo0UndvSzk5Vm1GZGE3RGR1VzZrc0FXclAx?= =?utf-8?B?TXZNZ1ZRMDR5MG00c3cyODNmWXVCL2tuTUR0TjlmSjNFc1JSMllmM1diK3Zy?= =?utf-8?B?eEJXMVpkRUtOTElxYkZxeGNnaWlmeDVjYzVZQzdETEpwak5iVWd1dVlKTSs4?= =?utf-8?B?TEg3QWppelhPZ1I3OSt2Mnl1WEtsdnVxVkFkNkdrYjJRNDZGUEgvMm96QW0y?= =?utf-8?B?K3hkUm1zSU1HQzhsSllISCtCTVFrK3FSUmtGTG4wdGpwVjFtT0IveHE0a3JT?= =?utf-8?B?dUliNnc4c0hlMnlCdWMrOWpqbVpmdnRvejVHQUdpdVhuT0JzSXdUZzgrMEVq?= =?utf-8?B?Q1N4NFRuVzc2eDc4UDMveFg2cXBGQ2VKaFdaQ2pkMjhDcmpIR3ZhVmZKazBO?= =?utf-8?B?SlBtaDVPMWwzenRmY1RzZjl4THJ1V1VscHdlM000MXpUS2RHQmNwZXdLcUZW?= =?utf-8?B?aWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?L2M4Tk5CTm1Nc2w5TEtRQ2E2S3J4UFVtMzVJaGZ2cTZEYWx0anhmSFIyTlMv?= =?utf-8?B?eUVmaWs0R3RCaXlSTEZZOWtyaDNockRidGwyMW04c0lxVGdMalREMDUwalFW?= =?utf-8?B?c3RLdHFhc1drS2pQaGdiVkZpZ0w3NlJ5bVh0SDd5YnQ4N2M4SURzYWI2VTEz?= =?utf-8?B?emIxY2pYamFUWXVNcWkxZE1NQndiMzl5OFdQMHNqNWZSbFpVeTlpaHFLZFdW?= =?utf-8?B?cC9zanlVT0JVbXpxVWxtUE54MVZUVE10UHViQXhJN2cwVjRlSWNjQUk1Mk9U?= =?utf-8?B?eUdGdC9BQ1RqUzhmT1UrbFB4SWJHNlo0TU9USHVTQ3F3dGdoR3hqUDZLVVRQ?= =?utf-8?B?VStKQllxbHovd1Ezd0wrR2xYd1VTSktKV0VrVERFbktBQTJHaS96UzQ1WUh4?= =?utf-8?B?SVNPN1dIdWVmSFgzZVVQTkFzL0o2SG9YbGs4WEJvdWU0cnp6TEJ3R0Zid0tO?= =?utf-8?B?R3RVdkkrcHg1TS9VSE5HSkZuSzB6a3BQL2Q0bGdaTTlwZ3BPMVdLUjRPZ2sr?= =?utf-8?B?OUpjYU8wTWxmQjRnbFBjdlpvV2E0UFFMZS9iZzR0c09ZdVo4RU5KazkvSXFq?= =?utf-8?B?OHc1OVNoOC8rUUttajlIY0IzdXNkVk1GQnZKRG0wQWVYd3hIRXlBbGxoaGF4?= =?utf-8?B?ZDh5M2poRmVJOWZxQ0MzOUx1ZVpSMEVHTmw5ZlBoYTIxSXN3TWxQbmI1N1hn?= =?utf-8?B?SlJyd21iRk45VEE3MXBRWDdPY29qYWZJQm9DeURHMDN5dlpSNVl1Nkl5TkhI?= =?utf-8?B?R21oejY3bXZvdG9NU2RESjhoSU04c0NadHUza3RsZnBkSU1pSExkb2I3SklH?= =?utf-8?B?MUs4TkxONVVKZ2hGQy9SYkZ6S3liUXlMUGYzU2VwdFdwMzk2KzlSa0dkMDFJ?= =?utf-8?B?SVlKRWd6YTNyTVlKVy9jbCtZN3pWNkxNUCtyYjN6SmJ5b1dJYXZ6NzExZlp2?= =?utf-8?B?d2hNalRTb0trS3NWOXdrTis0aXN5cTAvMnljYnZCaitsRjVGOEEva2xPaXRH?= =?utf-8?B?QjNKVWRiS2VaNGlsSnVXSDVwaWZHRzlSR2kxWm9BYWViRWU2dUNrbWVjSEpj?= =?utf-8?B?SkM4bzhYUHRTYUZOUEFSUiswc3V6TTJPNklsem84VXorbFBWL25pcW5pWU5i?= =?utf-8?B?bFhEZ1hFNTRHK0xTMFJnYWF2akRiOGdoUGJRaGcyTmtaVk9GWjhPVGxtTTkr?= =?utf-8?B?NHpaNGpkVVlYMHJyNk9jT0hlcURBMzJMenppVVZ2ZlJBcDlsK2hpZkRYeDJ6?= =?utf-8?Q?/0qjKEbGjIcjhvX?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbd07622-d658-47f2-f80b-08dace022e27 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 09:56:39.1926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oaPamEZy/Tbik2AykysvXeJ1ERmUfV5S5bZntaXQWwbBYohkPaq56TWNGKvjOy+OLbUyNyGJ03F/OWQ5SAW0XQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5721 On Thu, Nov 24, 2022 at 09:59:25AM +0100, Roger Pau Monné wrote: > On Thu, Nov 24, 2022 at 06:15:15AM +0100, Marek Marczykowski-Górecki wrote: > > But to get dom0 display image from BGRT, it seems something else is > > needed too. Linux complains "Incorrect checksum in table [BGRT]". The > > only relevant google result I get is this: https://support.citrix.com/article/CTX460227/citrix-hypervisor-acpi-warning-incorrect-checksum-in-table-bgrt > > It blames firmware. But then, it's suspicious that it's also about Xen. > > And also, native Linux on the same hw does not complain about the > > checksum. So, I think it's rather Xen to blame... > > The table lives in area marked as EfiACPIReclaimMemory in memory map, so > > I think it shouldn't be clobbered by Xen, at least in theory. I'll look > > into it later. It's getting off-topic for this thread anyway. > > See commit 89238ef7797023f318f82f4f9dddef59c435b8bd. I wonder whether > the BGRT image region is marked as EFI_MEMORY_RUNTIME, I will have to > check on my system. Just checked on my system, and the BGRT image is placed in a EfiBootServicesData section with no EFI_MEMORY_RUNTIME attribute. To fix this we would need to change efi_arch_process_memory_map() so it takes the BGRT image address into account and marks the region where it's placed as reserved. I'm not aware of anyway to get such address from EFI data, so we would likely need to parse the BGRT in efi_arch_process_memory_map(). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu Nov 24 10:55:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 10:55:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447918.704559 (Exim 4.92) (envelope-from ) id 1oy9sW-0006Ak-PQ; Thu, 24 Nov 2022 10:54:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447918.704559; Thu, 24 Nov 2022 10:54:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy9sW-0006Ad-MM; Thu, 24 Nov 2022 10:54:48 +0000 Received: by outflank-mailman (input) for mailman id 447918; Thu, 24 Nov 2022 10:54:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy9sV-0006AT-PI; Thu, 24 Nov 2022 10:54:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy9sV-0000tC-Mj; Thu, 24 Nov 2022 10:54:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oy9sV-0000b2-51; Thu, 24 Nov 2022 10:54:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oy9sV-0006jd-4Z; Thu, 24 Nov 2022 10:54:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=P4WQRGPM9QJBWBmjKvlDwgOuMWFxyDIrzB9iQL54BZM=; b=bK7grWdeUVn28/0vJc+gL6W7Ar WJezNzyB/ztaXUb2i2AcSJLBzXNutfyVDWhsn2JAp2ZC5ww5yfpcsEzcqDteaE5KvTw/nGpHaQmJY NbNaUdhZChIpJAvsMlbDcqgN0pbHrcKHwP1UHt/Gzw5buTAtqUb2yDlWTSgjiUW4lceI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174952: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=1a9ff7846d4f9f80dc86e0486503f86036cb3780 X-Osstest-Versions-That: libvirt=4b90adf65a80c33f3359ba9af01759a2551b51cc From: osstest service owner Date: Thu, 24 Nov 2022 10:54:47 +0000 flight 174952 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174952/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174937 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174937 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174937 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 1a9ff7846d4f9f80dc86e0486503f86036cb3780 baseline version: libvirt 4b90adf65a80c33f3359ba9af01759a2551b51cc Last test of basis 174937 2022-11-23 04:18:53 Z 1 days Testing same since 174952 2022-11-24 04:18:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Göran Uddeborg Lu Ke Lukas Ke nicelukas@hotmail.com Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 4b90adf65a..1a9ff7846d 1a9ff7846d4f9f80dc86e0486503f86036cb3780 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Nov 24 11:16:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 11:16:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447925.704571 (Exim 4.92) (envelope-from ) id 1oyADL-0000ZZ-Il; Thu, 24 Nov 2022 11:16:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447925.704571; Thu, 24 Nov 2022 11:16:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyADL-0000ZS-Fq; Thu, 24 Nov 2022 11:16:19 +0000 Received: by outflank-mailman (input) for mailman id 447925; Thu, 24 Nov 2022 11:16:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyADK-0000ZM-Va for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 11:16:19 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0610.outbound.protection.outlook.com [2a01:111:f400:fe0c::610]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a0b6ef8-6be9-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 12:16:17 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6905.eurprd04.prod.outlook.com (2603:10a6:10:113::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Thu, 24 Nov 2022 11:16:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.019; Thu, 24 Nov 2022 11:16:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a0b6ef8-6be9-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dunz+1tp/+zkCW7g90RJH7LIJ3/zvUMjvIw0n/wB4EfSy73wXrkcqP4OBvYwu57rhHGfWSzx26rmDmL+4oX7iD4INm7lGf7AQpyo5dowzmbljkFDgn5plRvRu7JrkL6I9s79MXUStzj81vTRlCSx8zVTxFX8lAa0TLIYZyigUqR8Y/dxKmJQBuEoELLKat3qmlHya7H6Rqx+yk6L8r83OYO8nMIC9aOHaZQtL33V8W5BKJvBKs8Al67bugHvFpuRysLxnggmkkcRfbhjynU3kDQABYWr3yZpxx2y3SDDhdF4YhBHbdr3aiqbKubdUxpe3IZ5sdi2WDpFzU/LzYIlYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IYLvJv8c1QzvbrN7mngdJKjyEXMyfKc3fLzObNB1AIU=; b=BrNBe32/f9gCum3QvokiO6WnF8CzRe+NOv3fCxQtapEGCwsq89NgArZW0w6ZN07koEE4fCoSXRbLFF+R43ivYW3dwk+gPgWeexxMFZ1Z560OH0RdzDa/yGzIlzcZ8PykzXQAf2QheZZ9IjlAJJCx95CWpcjrk6VCv6+1cGIp83lmfT/AFDJesvjVlQjG4RlXVrwT8olx2e7YziaiHDndr5q+puHvb+HZVF+9EMZuh4VMGBib7T/snww0+q3efhvJgRBsjIx+S4HuVI5LNP+SRUAvzbxffM/DEPrzdfUYIOs/tCLVn0UnbtbQeW25+Ri94W0NWTvhHyohZQQPEnJdTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IYLvJv8c1QzvbrN7mngdJKjyEXMyfKc3fLzObNB1AIU=; b=GzmufkjqG6KI9satukWBpBQyfjzeowCov4u036QT9AAo4DorEyepTRbg47KfrD1DbMz8Qybv8iTtP1zaJ2RRgnLjOI/QBunK0Q3eaIvBAFMn2G+cwPmC/7oNVqXhFktOIv/xeiEiRC5uCiNaKIx+mkTQrDXibcS6k7C7tvcSC94CkKgsDWRtkEoCdpRFC//MrTBBX7+aDaAbWwLszlFcIHxpxgD8gd4DC+9zk0A29huziTG1cOI2SCJ5MdVlIQ53MvLMWvCW0DcPvsH1FFB+FUwsDiPWRBSBguXlQ8GlxaypeuCANVGII8oNZfntTL8DAExHcXIAjrbal2fiHabYaw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3f3bced7-62e8-4ff2-655d-aed222f343a9@suse.com> Date: Thu, 24 Nov 2022 12:16:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" References: <9a1e9336-a3b4-530e-5ef5-abf193492380@suse.com> <5a2df843-1acd-ad78-baff-e47befd0703c@citrix.com> <878e635f-b116-3580-945f-f8acb711a5bc@suse.com> <69507b8d-1f31-39fb-7469-e240fbfdde44@citrix.com> <33a005bf-0596-c624-0e70-077a450ac2ae@suse.com> <351a6e54-8002-aef0-993a-c6b8bdcc1e8e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0155.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6905:EE_ X-MS-Office365-Filtering-Correlation-Id: d7e79c7f-9499-475a-cdbd-08dace0d4d1f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +o8QJJV1pGh3lUEUQd6MUU79wDOTNiiwyVU/+kOi6JMBZ0K5myMKJIWMZ5HFbfo2G480p131zxbw69tauER2StoReb2AI0giXfJGF6xXkdiPUiCrnIDtRmZQocoSMmsJK8UOcoc8VXNPI8IrlakphR2X7JnOCzn9E72re0xxToX4cOspKSzC3XzWSU2crAu/80Nlm/zZoliP3zG5ljwY7JFLBPGgT6ReS4ayEqKBapOAMrNL6JPqB/LBYSD6jATAVCnPtnYqX54rvdY806FLorGgDcEB23wn5w4G5TQ0XeAOHyr6yMxrgY4CDyuEAI7yYaY61B8wwlSor0+cX6LGsJhevfETccif4ptBSggO2fSheHvS6vgZ5y/eijO9JJdp5XXWLN7gr+wHqIs8xUJH/loGszZrwP0jQ4iPdGtMBUIqTs2EKJsOOYELv9AViYxjkMwIHBCUGxz30cCRG4ssnkJjeDGZi8n5E5gxvPhBBfdsqlobUo6lnXfna7EOc6HwwRZC0UfU5UzSuEkshM+jO7nFklJpzcT2kHrXpocVOEyWjEBU0YWkaA/0qmPBWV2s4e8qwzza9YtbjrPzc4b9EhxlA1guC5UNWInhzwNDGWhA2fqvV+PlHoW//4oVAkHDnnhvnGhbmMpJHM8x2f5vWIw/pqZLekcCBdV7Ha/HLrJL9O3GgMjlKRtFFr+Y1c5DpU64MysmW4eri5wGM4WlrnYQPHLWTSjgWwg0+ZwetWddVZlVOIEwLiPg906R4AlfW7YCH1CIcifvMFELneJ8bw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(396003)(39860400002)(346002)(136003)(451199015)(316002)(6916009)(966005)(6486002)(66899015)(54906003)(31686004)(53546011)(26005)(6506007)(6512007)(4326008)(66946007)(8676002)(478600001)(66556008)(66476007)(5660300002)(186003)(8936002)(83380400001)(36756003)(2616005)(41300700001)(2906002)(38100700002)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVVEMUdlV3FjNldndElUSnA2c0tQNGQzcmFla3RRaVhXa1JidzJQTndZQ1dn?= =?utf-8?B?TU9CdVdFczN2WVlCblRhSHpmaDh4dXNjcytlWFlHN0Z2aWpCdFczMkc4NFBs?= =?utf-8?B?eGxuUmlqQjNPVmVHK0pKNGdIOFE3eHk1Nmxqdm5FVStGVTl2UmpxNDJNaUI3?= =?utf-8?B?dmswYitOck5HcDhhd1FZd3RZY2t2Q1ZPZHYrMmlWN2wvOFU0T1MrenRNRVRN?= =?utf-8?B?U0IyZkJaWGU1UDlkcDRlRC9LYzAzamdrUnlMNzUwazRlZzVUUnI3ZDc2Nmly?= =?utf-8?B?N2dYUjNYU3RMKzdKNDlvQW00NDRVdDFKNElaM0FpQlFieFhuS0RNcmNDd01C?= =?utf-8?B?L2RiYlcxMmpjQjQrMSszZGo1MTc3WFltcXlLMWdVM0M4QmNsc0h4bHRiRTht?= =?utf-8?B?MlFxK0p2c3pyYW8wM2Vrd3c4RW1pSHUzRVY4cVNBVTVnVy9kVDJYaEprUEVp?= =?utf-8?B?SEV6Umo5Q2FZc2xNelkrSng2K01xenY5L09aZDdIMFZKbldCVmJYR3lkajZT?= =?utf-8?B?bk13MTRBbk1VSHlEM0xlVXhvb0lVUVdvdDA3andGdGVKcVlwYW9KTVQ3YlJz?= =?utf-8?B?bHF0bVgzQ0diVEs5RGliVmNyTk04dVE0QXVJSDVlcjFlcmJrVlRPL0lNbFRG?= =?utf-8?B?cnRuVWkwVmtsMERlcHpuYkl0T2JmS0tpUUJVcyt2Wjdla2JNVnVCOE5jbW9z?= =?utf-8?B?VzV5Y2xnSC9NQWVpR3ViN1BUc2VFWXhlRGlFVEp3bUVlRHdmaHJKMXBWRi90?= =?utf-8?B?VEl2VWFUSHFEcEViMEVLQURIdTN4azA0dFZFMVpJRDNYMytIdmNpbTR3SDdp?= =?utf-8?B?eFpxSW0ra1lTbU1xRkptb3psNDBMUXR5S25Ca3pEN1dFbmo5RURIRjJIV2tI?= =?utf-8?B?U3lHMjVHNDVDMkVJUnJmU09HSFN0c3VFTHlMQmE4THZoa1Jhcy80aXpidEov?= =?utf-8?B?bnJacDY2RUZLTmF3RG5SOUhNci9ESVpkVXZlUTJYLzZ1bUVUNnZtbHFuUjZs?= =?utf-8?B?MUlFZUs1bkNFUzF4S1laNjJ2R0lYRzlmb1NQeUM1Z1l1QTdPanFIci9FdU1X?= =?utf-8?B?VDFMNWlldlB4QUJjN3E4amdSdDBqZmhrTGlWU0RvUlk5WnFjOVc4N1Z4Wko3?= =?utf-8?B?SFQ5elRDMUE0WGpjWTFaYUtxS3BHemUveVpMc2tmaytZMjZZeWhsdWtLZ2pj?= =?utf-8?B?SDdxYmtzd1ZPWjR1V1VBS0I5cTkzY2JZWEs0cjAyM09mV21waUNvM01HUjJq?= =?utf-8?B?SnBNYmVzbmZkcFVOa25kMzljbStRTi9sUG5ucUVVYm1zK1RxSm9TbERqTkVY?= =?utf-8?B?aGpibE9ZRXd2TW9ybFVQRXp1TmtqQ1NRelhBemF0NE5naUVrQVI4OGtiUFZQ?= =?utf-8?B?V0k3MDRJQmtLQ2pMTkl6bTdtMlpBNmlFbkJqSWJpbWZ3dGlsazd3bnRPMjdQ?= =?utf-8?B?SlNZQjIwRllhZUJHNU1jZkNhdUNyTVVrRXhkY2ZKZkpnSVRjMUhLNlRZZ3da?= =?utf-8?B?NG9ZcVdBTEdUai84QVQvVFlkOE0vOTdXOG1URUh6RmI2Qml2c1J4Ylgzc1cx?= =?utf-8?B?Y3ZYMHBoelllQk5XdUtrZjZIeGxMZWpPWDBjYm9SUUdKVDBXQS82WmdDSk5K?= =?utf-8?B?VHhCYXExVkNHMkh3bkpQMi9nSXI0L29MUGRUeFdzekN6SDBLak9PUmZDRDkx?= =?utf-8?B?QUk1T3lGMGxqak81ZndweEhHR3VNOS9JajRIOUlUQ1RpVmtScENiZDB6bmlD?= =?utf-8?B?bE1reXpCbG1ISDRQUVRLVFJIVlB4clpWUlhkTFhSeWFKOEdQZmtxMW5DOEFD?= =?utf-8?B?M2JnRTArWkVDSUJVS2FFTlBwN05VcWRvY1NOWnIrNjZpSmtEU04zUktObWlR?= =?utf-8?B?VXg0QXpMVVBFbjRQemc0a2xEdjkvTGN3MWpqanVVRXdiWkt1bHJaaG1DVjBk?= =?utf-8?B?SUxFbTVJc1FnT09aYTlGWDM3ZFc3cTNjR1JxT3hvZCtlYkxDU2ViWDRveEFG?= =?utf-8?B?Yi85b3JxUXg1U1VSd1BDQmVJdGVhRitzUllaL1lpUTdMQ0cyeHpyOGNQalkv?= =?utf-8?B?cmFrZGlNNmdXbnZBYXhHSlpMV0UvcmdzVzlKQmhVeTNPTjE4VXdQVEFCcEdi?= =?utf-8?Q?Gya5kZf2NbQhh0F4zvRMo+7qg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7e79c7f-9499-475a-cdbd-08dace0d4d1f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 11:16:15.1891 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M35xIi1SYHj+sDK9Qtrbt2onDdWIiUlO06tI8hOyHEBJ0brqVmkZbV21K1/rdyDQX8vZM890TjlBiTlmaWx2wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6905 On 24.11.2022 10:33, Roger Pau Monné wrote: > On Thu, Nov 24, 2022 at 10:11:05AM +0100, Jan Beulich wrote: >> On 24.11.2022 10:06, Roger Pau Monné wrote: >>> On Thu, Nov 24, 2022 at 09:42:40AM +0100, Roger Pau Monné wrote: >>>> On Thu, Nov 24, 2022 at 08:59:00AM +0100, Jan Beulich wrote: >>>>> - problematic wrt evtchn_upcall_pending, once set, preventing event >>>>> injection later on. >>>>> As you may have inferred already, I'm inclined to suggest to drop the >>>>> the is_vcpu_online() check from hvm_set_callback_via(). >>>>> >>>>> One related question here is whether vlapic_do_init() shouldn't have >>>>> the non-architectural side effect of clearing evtchn_upcall_pending. >>>>> While this again violates the principle of the hypervisor only ever >>>>> setting that bit, it would deal with the risk of no further event >>>>> injection once the flag is set, considering that vlapic_do_init() >>>>> clears IRR (and ISR). >>>> >>>> That would seem sensible to me, and was kind of what I was suggesting >>>> in: >>>> >>>> https://lore.kernel.org/xen-devel/Y3eO0bMKRPYJc2yQ@Air-de-Roger/ >>> >>> Another option would be for vcpu_mark_events_pending() to >>> unconditionally call hvm_assert_evtchn_irq() regardless of the state >>> of evtchn_upcall_pending. >> >> I think you said so before, and ... >> >>> This will create some spurious events. >> >> ... I continue to be afraid of s/some/many/. > > Not _that_ many I think, as we can only queue one pending interrupt in > IRR. We need to be careful here - the kernel treating it as "edge" (like any other interrupt coming directly from the LAPIC), it ack-s it before calling the handler, i.e. before evtchn_upcall_pending would have a chance to be cleared. See Linux'es sysvec_xen_hvm_callback(). >> This event delivery is meant >> to be kind of edge triggered, and I think it is a reasonable model to treat >> the flag going from 0 to 1 as the "edge". > > Hm, it's a weird interrupt model I would say. In some aspects it's > similar to level (as the line stays asserted until it's cleared), but > we don't get new interrupts injected into the APIC. > > Maybe the right mode would be to treat evtchn_upcall_pending as a > level triggered line and keep injecting interrupts until the line is > deasserted (ie: evtchn_upcall_pending == 0)? As said above, and as also pointed out by Andrew on another sub- thread when discussing the (dis)similarity with IO-APIC connected interrupts, at the LAPIC there's no edge/level distinction anymore, as we're not dealing with "asserted" signals there, but just with messages sent on the bus. Jan From xen-devel-bounces@lists.xenproject.org Thu Nov 24 11:51:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 11:51:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447932.704582 (Exim 4.92) (envelope-from ) id 1oyAlP-0005Zh-C7; Thu, 24 Nov 2022 11:51:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447932.704582; Thu, 24 Nov 2022 11:51:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyAlP-0005Za-9L; Thu, 24 Nov 2022 11:51:31 +0000 Received: by outflank-mailman (input) for mailman id 447932; Thu, 24 Nov 2022 11:51:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyAlO-0005ZJ-BP; Thu, 24 Nov 2022 11:51:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyAlO-00029V-8o; Thu, 24 Nov 2022 11:51:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyAlN-0001oY-Kd; Thu, 24 Nov 2022 11:51:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oyAlN-0000xm-KC; Thu, 24 Nov 2022 11:51:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kxT7OqMp0Ca9fbAJUkEeTfQdZcbeaqXqsqVF9+tUPVw=; b=DS0gxynrVxqLcACuZMwOMlA1Fo WzVJsZpFiTNrEzc0Q5+StMo7hdGEpxj235kvhG9+xf4veCptPHdrp0LRBKvIDiEb80A/iQvl9QDds Ir+yBF2P5UweMRxoyhBZR+Gh73XunEXm8HGmpnJ2ezg9BPP9JpNxofdzERDxw0OF5S48=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174951: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c3eb11fbb826879be773c137f281569efce67aa8 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 24 Nov 2022 11:51:29 +0000 flight 174951 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174951/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-thunderx 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux c3eb11fbb826879be773c137f281569efce67aa8 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 47 days Failing since 173470 2022-10-08 06:21:34 Z 47 days 86 attempts Testing same since 174951 2022-11-24 04:02:04 Z 0 days 1 attempts ------------------------------------------------------------ 1806 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 171867 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Nov 24 13:28:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 13:28:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447942.704592 (Exim 4.92) (envelope-from ) id 1oyCHP-0007uV-8u; Thu, 24 Nov 2022 13:28:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447942.704592; Thu, 24 Nov 2022 13:28:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyCHP-0007uO-6O; Thu, 24 Nov 2022 13:28:39 +0000 Received: by outflank-mailman (input) for mailman id 447942; Thu, 24 Nov 2022 13:28:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyCHD-0007uC-Ny for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 13:28:37 +0000 Received: from mail.skyhub.de (mail.skyhub.de [2a01:4f8:190:11c2::b:1457]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ddee0518-6bfb-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 14:28:24 +0100 (CET) Received: from zn.tnic (p200300ea9733e75b329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e75b:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3032A1EC0495; Thu, 24 Nov 2022 14:28:22 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ddee0518-6bfb-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1669296502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=TaewtBDqu/25yf994GoEuh2zYLDng8qjigaVQ1a0K4s=; b=SbVhENhafFgnim1V36S6iVUKMezXbe45j39COpUhd1soYaGLp7QFv0k7XjQFy0RmES4RxU j5JjT1hwld9O5UxgxOdbN4h+IWSAzYsTIL+/dRqJiPnk0QngX+Nfx5c7y/bH4esqY4K1s4 rPW3eB3RyGATypLILLooN+oN8KNmlow= Date: Thu, 24 Nov 2022 14:28:18 +0100 From: Borislav Petkov To: Juergen Gross Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3] x86/boot: skip realmode init code when running as Xen PV guest Message-ID: References: <20221123114523.3467-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221123114523.3467-1-jgross@suse.com> On Wed, Nov 23, 2022 at 12:45:23PM +0100, Juergen Gross wrote: > When running as a Xen PV guest there is no need for setting up the > realmode trampoline, as realmode isn't supported in this environment. > > Trying to setup the trampoline has been proven to be problematic in > some cases, especially when trying to debug early boot problems with > Xen requiring to keep the EFI boot-services memory mapped (some > firmware variants seem to claim basically all memory below 1M for boot > services). > > Introduce new x86_platform_ops operations for that purpose, which can > be set to a nop by the Xen PV specific kernel boot code. > > Fixes: 084ee1c641a0 ("x86, realmode: Relocator for realmode code") This text and Fixes: tag sounds like this needs to go to Linus and stable now? > diff --git a/arch/x86/realmode/init.c b/arch/x86/realmode/init.c > index 41d7669a97ad..247aca9f8ed1 100644 > --- a/arch/x86/realmode/init.c > +++ b/arch/x86/realmode/init.c > @@ -200,14 +200,18 @@ static void __init set_real_mode_permissions(void) > set_memory_x((unsigned long) text_start, text_size >> PAGE_SHIFT); > } > > -static int __init init_real_mode(void) > +void __init init_real_mode(void) > { > if (!real_mode_header) > panic("Real mode trampoline was not allocated"); > > setup_real_mode(); > set_real_mode_permissions(); > +} > > +static int __init call_init_real_mode(void) > +{ > + x86_platform.realmode_init(); > return 0; > } > -early_initcall(init_real_mode); > +early_initcall(call_init_real_mode); I'll name that one "do_init_real_mode" as "call init" sounds weird. Otherwise, it is as straightforward as it gets. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Thu Nov 24 13:30:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 13:30:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447945.704603 (Exim 4.92) (envelope-from ) id 1oyCJQ-000110-Jo; Thu, 24 Nov 2022 13:30:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447945.704603; Thu, 24 Nov 2022 13:30:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyCJQ-00010t-HE; Thu, 24 Nov 2022 13:30:44 +0000 Received: by outflank-mailman (input) for mailman id 447945; Thu, 24 Nov 2022 13:30:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyCJP-00010n-AG for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 13:30:43 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3073196b-6bfc-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 14:30:42 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7E9D6218BB; Thu, 24 Nov 2022 13:30:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3667613B4F; Thu, 24 Nov 2022 13:30:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /PPHCwByf2OtKAAAMHmgww (envelope-from ); Thu, 24 Nov 2022 13:30:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3073196b-6bfc-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669296640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LNtLdszO3foiDTYSgvjJ6h1+flzm24yU1NLSZoWT7CI=; b=CPp9slZzK47sh8IIDmrE+Ezw924C4RpWd1/kluMqIxzZ5Js7dcBMtC9jjZuk6N8JvKwdJA f01XiCnXbySz0BpsHzItQqTBPU5otGfYzBfROszJJjddZCRZBG8QUL8BcHUu5iFM9f9TC2 NJapIpT7/9zYtSRvt8cFoFfhyJmHdzA= Message-ID: Date: Thu, 24 Nov 2022 14:30:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3] x86/boot: skip realmode init code when running as Xen PV guest Content-Language: en-US To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , xen-devel@lists.xenproject.org References: <20221123114523.3467-1-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------0VLKXo0fwrqmfGnX066jb0rg" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0VLKXo0fwrqmfGnX066jb0rg Content-Type: multipart/mixed; boundary="------------i6mFkV7gpV2Meh114x82itrq"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , xen-devel@lists.xenproject.org Message-ID: Subject: Re: [PATCH v3] x86/boot: skip realmode init code when running as Xen PV guest References: <20221123114523.3467-1-jgross@suse.com> In-Reply-To: --------------i6mFkV7gpV2Meh114x82itrq Content-Type: multipart/mixed; boundary="------------6t4UKZUx5RittVqXvsy08yw4" --------------6t4UKZUx5RittVqXvsy08yw4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjQuMTEuMjIgMTQ6MjgsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gV2VkLCBO b3YgMjMsIDIwMjIgYXQgMTI6NDU6MjNQTSArMDEwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN Cj4+IFdoZW4gcnVubmluZyBhcyBhIFhlbiBQViBndWVzdCB0aGVyZSBpcyBubyBuZWVkIGZv ciBzZXR0aW5nIHVwIHRoZQ0KPj4gcmVhbG1vZGUgdHJhbXBvbGluZSwgYXMgcmVhbG1vZGUg aXNuJ3Qgc3VwcG9ydGVkIGluIHRoaXMgZW52aXJvbm1lbnQuDQo+Pg0KPj4gVHJ5aW5nIHRv IHNldHVwIHRoZSB0cmFtcG9saW5lIGhhcyBiZWVuIHByb3ZlbiB0byBiZSBwcm9ibGVtYXRp YyBpbg0KPj4gc29tZSBjYXNlcywgZXNwZWNpYWxseSB3aGVuIHRyeWluZyB0byBkZWJ1ZyBl YXJseSBib290IHByb2JsZW1zIHdpdGgNCj4+IFhlbiByZXF1aXJpbmcgdG8ga2VlcCB0aGUg RUZJIGJvb3Qtc2VydmljZXMgbWVtb3J5IG1hcHBlZCAoc29tZQ0KPj4gZmlybXdhcmUgdmFy aWFudHMgc2VlbSB0byBjbGFpbSBiYXNpY2FsbHkgYWxsIG1lbW9yeSBiZWxvdyAxTSBmb3Ig Ym9vdA0KPj4gc2VydmljZXMpLg0KPj4NCj4+IEludHJvZHVjZSBuZXcgeDg2X3BsYXRmb3Jt X29wcyBvcGVyYXRpb25zIGZvciB0aGF0IHB1cnBvc2UsIHdoaWNoIGNhbg0KPj4gYmUgc2V0 IHRvIGEgbm9wIGJ5IHRoZSBYZW4gUFYgc3BlY2lmaWMga2VybmVsIGJvb3QgY29kZS4NCj4+ DQo+PiBGaXhlczogMDg0ZWUxYzY0MWEwICgieDg2LCByZWFsbW9kZTogUmVsb2NhdG9yIGZv ciByZWFsbW9kZSBjb2RlIikNCj4gDQo+IFRoaXMgdGV4dCBhbmQgRml4ZXM6IHRhZyBzb3Vu ZHMgbGlrZSB0aGlzIG5lZWRzIHRvIGdvIHRvIExpbnVzIGFuZA0KPiBzdGFibGUgbm93Pw0K DQpMb29raW5nIGF0IHRoZSBkYXRlIHdoZW4gMDg0ZWUxYzY0MWEwIHdlbnQgaW4gSSBkb24n dCB0aGluayBpdCBfbmVlZHNfDQp0byBnbyBpbiBub3csIGJ1dCBJIHdvdWxkbid0IGNvbXBs YWluIC4uLg0KDQo+IA0KPj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L3JlYWxtb2RlL2luaXQu YyBiL2FyY2gveDg2L3JlYWxtb2RlL2luaXQuYw0KPj4gaW5kZXggNDFkNzY2OWE5N2FkLi4y NDdhY2E5ZjhlZDEgMTAwNjQ0DQo+PiAtLS0gYS9hcmNoL3g4Ni9yZWFsbW9kZS9pbml0LmMN Cj4+ICsrKyBiL2FyY2gveDg2L3JlYWxtb2RlL2luaXQuYw0KPj4gQEAgLTIwMCwxNCArMjAw LDE4IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBzZXRfcmVhbF9tb2RlX3Blcm1pc3Npb25zKHZv aWQpDQo+PiAgIAlzZXRfbWVtb3J5X3goKHVuc2lnbmVkIGxvbmcpIHRleHRfc3RhcnQsIHRl eHRfc2l6ZSA+PiBQQUdFX1NISUZUKTsNCj4+ICAgfQ0KPj4gICANCj4+IC1zdGF0aWMgaW50 IF9faW5pdCBpbml0X3JlYWxfbW9kZSh2b2lkKQ0KPj4gK3ZvaWQgX19pbml0IGluaXRfcmVh bF9tb2RlKHZvaWQpDQo+PiAgIHsNCj4+ICAgCWlmICghcmVhbF9tb2RlX2hlYWRlcikNCj4+ ICAgCQlwYW5pYygiUmVhbCBtb2RlIHRyYW1wb2xpbmUgd2FzIG5vdCBhbGxvY2F0ZWQiKTsN Cj4+ICAgDQo+PiAgIAlzZXR1cF9yZWFsX21vZGUoKTsNCj4+ICAgCXNldF9yZWFsX21vZGVf cGVybWlzc2lvbnMoKTsNCj4+ICt9DQo+PiAgIA0KPj4gK3N0YXRpYyBpbnQgX19pbml0IGNh bGxfaW5pdF9yZWFsX21vZGUodm9pZCkNCj4+ICt7DQo+PiArCXg4Nl9wbGF0Zm9ybS5yZWFs bW9kZV9pbml0KCk7DQo+PiAgIAlyZXR1cm4gMDsNCj4+ICAgfQ0KPj4gLWVhcmx5X2luaXRj YWxsKGluaXRfcmVhbF9tb2RlKTsNCj4+ICtlYXJseV9pbml0Y2FsbChjYWxsX2luaXRfcmVh bF9tb2RlKTsNCj4gDQo+IEknbGwgbmFtZSB0aGF0IG9uZSAiZG9faW5pdF9yZWFsX21vZGUi IGFzICJjYWxsIGluaXQiIHNvdW5kcyB3ZWlyZC4NCg0KRmluZSB3aXRoIG1lLg0KDQo+IA0K PiBPdGhlcndpc2UsIGl0IGlzIGFzIHN0cmFpZ2h0Zm9yd2FyZCBhcyBpdCBnZXRzLg0KDQpU aGFua3MsDQoNCg0KSnVlcmdlbg0KDQo= --------------6t4UKZUx5RittVqXvsy08yw4 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------6t4UKZUx5RittVqXvsy08yw4-- --------------i6mFkV7gpV2Meh114x82itrq-- --------------0VLKXo0fwrqmfGnX066jb0rg Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmN/cf8FAwAAAAAACgkQsN6d1ii/Ey98 twf8CbDMNAfrpw7TxPRC2w32+D69rQq2LyrXAC8AmzYM+HXju0pd51kwTs40Tw3VO9rRRMIXKvQo u0FB+TKhlkUERVyFn36qNat11KrhhR7cDZmTKRjy32C658RPe6fL5zXoWk8PlKF9N570jVQVPk1g mP/hRpfAxG8RMpanxyaaFrCvOkHveSo3KNwjnZ/gPb0gmUUCKRmSJq+s9DySzwt1nR0tlAV5yWO1 qp5wycgReDaK+YL8lgnrxpORDMu1UYOBDpNeY4zAZucnIugR8rRyOwLLxgy6kykEmHVoGNxcmAmZ bmPB/cX8yOOZ32jIefDkJrN6LCRqKC0J36YArIw3gg== =hXrX -----END PGP SIGNATURE----- --------------0VLKXo0fwrqmfGnX066jb0rg-- From xen-devel-bounces@lists.xenproject.org Thu Nov 24 13:43:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 13:43:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447950.704615 (Exim 4.92) (envelope-from ) id 1oyCVm-0002k7-Nr; Thu, 24 Nov 2022 13:43:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447950.704615; Thu, 24 Nov 2022 13:43:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyCVm-0002k0-Ky; Thu, 24 Nov 2022 13:43:30 +0000 Received: by outflank-mailman (input) for mailman id 447950; Thu, 24 Nov 2022 13:43:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyCVk-0002jp-Le for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 13:43:28 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f74502b2-6bfd-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 14:43:25 +0100 (CET) Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Nov 2022 08:43:11 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5378.namprd03.prod.outlook.com (2603:10b6:208:292::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Thu, 24 Nov 2022 13:43:09 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5857.018; Thu, 24 Nov 2022 13:43:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f74502b2-6bfd-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669297405; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=a+QoXY/5fHziO2VRvrfw4vtsMfH0Pj9RY54Cnp3eip0=; b=CzbbnqKgPVKUXIDpZj5UtH+9R1vfFcKtvJIhDKACtF8jOp65spI8F9Rn lF5OnEFSqhXJb00Iq3mVihVRVz1dhYph1ZdlA2BoSgSJSx/cSfjxiBlnU PyO7K1b+VeTuwoi/vVdoViKNi6WBFYntYuJPkrV4n9/VFCjEbjbjYAppf Y=; X-IronPort-RemoteIP: 104.47.55.173 X-IronPort-MID: 84546413 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:nFDNCqgVY7ohwB9cKWuSuYJWX161fBEKZh0ujC45NGQN5FlHY01je htvD2vVafqOZjP1c9lxO9vk80wH7JXWnYAyHQtkrSFhH3gb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QWCzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQWCndWQjXewN6umui7crQvl+AvHszCadZ3VnFIlVk1DN4AaLWaGeDgw48d2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEsluGya7I5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6ROHlqqA22Qb7Kmo7FDMudUfl8OGAg3WDXO50M 2032CQQsv1nnKCsZpynN/Gim1aUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebTAjy FKhhd7iAj1r9rqPRhqgGqy8qDqzPW0fKz8EbCpdFw8duYC8+8c0kw7FSctlHOitlNrpFDrsw jeM6i8jm7EUis1N3KK+lbzavw+RSlHyZlZdzm3qsqiNt2uVuKbNi1SU1GXm IronPort-HdrOrdr: A9a23:r4PXT6gfuhKgxuO2ahP7ty8xgXBQX/J23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu17h/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboXgTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp9KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wXh4SqbpXVd WGPvuso8q+QmnqKUwxeVMfmeBEa05DWituhHJy4vB9nQImx0yRhHFoufD31k1wiK7VDaM0p9 gse54Y6o2nBKUtHN1ALfZETs2tBmPXRxXQdGqUPFT8DakCf2nAspjt/dwOlaiXkbEzvewPca 76ISVlnH93f1irBdyF3ZVN/ByISGKhXS71wsUb45RioLXzSLfiLCXGETkV4oCdiuRaBteeV+ e4OZpQDfOmJWzyGZxR1wm7X5VJM3ERXMAcp95+UVOTpcDALJHsq4XgAb7uDauoFSxhVnL0A3 MFUjS2LMJc7lqzUnu9mxTVU2OFQD2KwXuxKtmuwwE+8vl/CmQXiHlltb2Q3LD6FRRS9qorYU B5PLTr1qumuGjexxe701lU X-IronPort-AV: E=Sophos;i="5.96,190,1665460800"; d="scan'208";a="84546413" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eW7pUUemBlYZCtbMl2w1iwba7zqMDMvYpLls8p9mTqADqTGCb7xK0e5vZLITvaObyO9bA/NNTtMHyXZMwQ8d7vC5SqkwUXgQ5treMEd1W6yQTgfbiQw8iiYZi160FwAfnNqrnNESGlP2HITJuDaTIIvBkqMd9AJReFpsPFTsvSJLsMJJ9QMozy5kxVIJvU7x0Askyw9Isx8kJcJgQdqpUiFChfUhaAn55lMj0wTRJdDRGQwdw6Z8Dwimafh9NAEfa4IvGBogaLURORw+oWw8ootTb4YlyY8t9wv34vP8vFnMQ8JlRHD8i+tlb7X8JmAyhWUOSwwLh+sHRM7PkBlhXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a+QoXY/5fHziO2VRvrfw4vtsMfH0Pj9RY54Cnp3eip0=; b=Uau4eAiwbVe4lfuVdMhLVCx5rZcSdGkvt4K0hbDqFUlyJyspiXdFspod/9aHMIkZXbqeK3Xer5qMRlF+sVNcNwWL9P3YjmHNgN3ygF/+8riTMBFOSNpu0UARFrWXRf65mLBjkapej69A6aa7IHATvw3Ry5rO9EWfbbcEFY9jJe8vXrwMTpgSO35UBL8hUwo3tJqWFdjXbCt6so18qd1noP69hfWr1deVtFhh0Pgj1S9XIsePztZoOHFbUPbZ7J2jySFh6R9Ep+eDgP6JxP8+WZzjsUMUMZMjNprE3ZeZp57MJpK3wYF+GG48oF++7Dzdu45VohqKnsuEBWpw447sWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a+QoXY/5fHziO2VRvrfw4vtsMfH0Pj9RY54Cnp3eip0=; b=sZTP8hlWU/JumwPkW9/GeKfU3waaCJ3lxeSKNT9RX9bYic4N2pvJiYz7LiSZTW8AnwHq4qSLat4wmGHQ0TuTovQKPMhw06ZK3wpDRDhe5xue9G2w3mRz50kO41R4i89zexg3wT1sKpO5EDTJbU4pBF2Jk4/6ZKPBNET1yFivgoc= From: Andrew Cooper To: Edwin Torok CC: Xen-devel , Christian Lindig , David Scott , Rob Hoes Subject: Re: [PATCH] tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free Thread-Topic: [PATCH] tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free Thread-Index: AQHY/4p9GINVmjprlEGx5iAuzyYE1a5NyDSAgABOFgA= Date: Thu, 24 Nov 2022 13:43:09 +0000 Message-ID: References: <20221123222517.12140-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5378:EE_ x-ms-office365-filtering-correlation-id: 2233fbf5-c982-41e2-36b1-08dace21d2cf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b7vfFVNOnw+TAgQPZtj0j4S7BoCRWd3NmzNgViYpy33+/XWponDXtlesDw8fdI4TNlSPUCuaDEMfXiIopycXGTPA3dGNkzw6+pYTPl/7UZdH3BPhAJoAqjImczXhmgjlYIqfmZ6yeaVSixLM4QzvccLpAHVDQEeQSDi3rMJAAK5vDguz7VGczm16hXt/oaY3ZwbKt7QeEEUpjsurRcDQu8tOclbpTRtZkgceFWVFA4PI+ZLiGpDlYpwS8ji77HAdMYzuyGhLKdXMlHD7xb7AFllBJoEq70+5tpiv08a7ycyiH1WsRGimlhY1BbDKKZOnOXjGmaFvk0xKs4cUpP8JXuMWP5VAqv1umLs7/+8chqK/UV/t8mACAnVr6Krud1UK/fAmq249jpnmWFkVqlp+TOX0R2IK8o0LFBpMU3b1HA9/7iMlgkQrdNBmBxZ8Oo3focHrfvxmssG++bYR1k/1iWZ9+d9e3kYjU6C7BHPtu5n4TwH1wdK2yWdDg3L5xr4s93yS9Gnbwtq+O/Ha4pW2IwNa1GRt+gTP5U1fv6+X+6nGktPH6y9TQhkiZ3LbsYquvETONYAaQ1Os2hSRnHK9kZkOaWPKd2Yq04OrF2CBZLJVIOsHXbMYtnlYRrz+pC5zSykw0VsV0jkppbeGtglZFaYkJIitsRC6k7NteKAY5nuTSPARWcYYQaviaCfI++qq3YZXoxuO3+tUyiYFmLfRa+oeKxMECQy5tj489RyCNT4DdnuEwbUtLH6K0OxXDtiLqc8/VE5c4ZF8lkAxofRJnGrPwlVcb6s0Tibw5GK5pjc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(396003)(366004)(346002)(39860400002)(451199015)(2906002)(31696002)(86362001)(6512007)(83380400001)(37006003)(54906003)(6636002)(107886003)(53546011)(26005)(6506007)(6486002)(966005)(71200400001)(2616005)(186003)(478600001)(82960400001)(41300700001)(8936002)(6862004)(5660300002)(38070700005)(38100700002)(122000001)(4326008)(91956017)(76116006)(66556008)(66476007)(66446008)(64756008)(8676002)(66946007)(31686004)(316002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VElqaXRKd3FRbXY2UmlaZTRJaW9Nemthend1ay9QNkNMZ25mK1FTcDJEY2JY?= =?utf-8?B?UHZoSDV3R3pIOWsxZ29YLzhyQTBwWWJnQS91SDQwWnpQS2FZYTRUQjBvSFg4?= =?utf-8?B?eGZtVmpuTitIemJPanVCNmk5OVFYbitFRlJjbzJYZnIwNnhWdFhtNTRMU2kz?= =?utf-8?B?Si9jUEluK1dDdkUwVmRyVHZUbE82eitIT3dyRzlXb2lzSFNZbkJGNnI0aHBu?= =?utf-8?B?bUxLZUVCb1hRWWx0eGc1YllUUDZ5ZVVQNXRyQ1BuY0pvTVBPTWNicjBuQXdi?= =?utf-8?B?VjBDakFJM3RxYkd6SEUxTHhNU1FlR3UrUHRKaUJPZllpS2R0di9na2RNVysv?= =?utf-8?B?b1FYSGlXYjFYQ0ZGYlU5eVdqVDZwYkFNTFdGZlVLNmh5OW11SS9PUWZKbDlQ?= =?utf-8?B?SUFWcE5uc1VsQUlJVDVwTjZoQXRETmpnVmpCYU9QanNSRC96ZjFoa05MVVBY?= =?utf-8?B?emxya1NGd1VJU3c5OTVSais5a1IrVCthUWdlZEk4eGRXZi9JRjZ0b2doNkxC?= =?utf-8?B?V2JPRFZ3ekJHUllUZkhOSEY0Mk84QTBqeXdxQWZqUC9UZmdxL0dxZUlxR0Fp?= =?utf-8?B?VnZTc1NvR0Z6eXBPU3NEcDdLOGpjSmV5OHRQcUJtd0FzZkZOR041b0VCZUtN?= =?utf-8?B?RE8wbG9zUXJDNmFGeXdISnlZemFDSllKTkhNcVN3QldsbE9VV3pzR1lsNGl3?= =?utf-8?B?TldRbllLNGJQOWpNQ2tZNE4zZDVlK3VLNWxSU095K3UyaVBQT09rVmt6VWJu?= =?utf-8?B?NXBqWTl1Ulp5R3d2OEFtZ0wwdU1SVmpCWjFsMXM5aDlHTmVVQk9hZkg2SC9M?= =?utf-8?B?TkhNQUdMVnJja0g2aUkzMDR4bHJDNHNkK0VKZ2ZKYWtiYkhPcURuQUEwa0Fy?= =?utf-8?B?N0VHdkdIWjZRc2xQbXF0OStDSkdCNXUrZWhlNE5MUjd4KzM1aTcyclRJNll5?= =?utf-8?B?WWFPVDlMeGlsK1A5V0YyNTdzTnhwRDNWOGFLelUxMzc3YTducWZmODNhbHNU?= =?utf-8?B?VzlqRWF3UC90YXIwY1pDVDVFYnRidlhUNGhTLzRBRXptTTI4R2VvV0FIbERn?= =?utf-8?B?WHcwa05XVGtvNXdacHFtR2RPaGxKV3YvSS8xM01tSWxqMnlxTE8xb2lacXdQ?= =?utf-8?B?bXhteFpJRTRZNWpzLzI3dWlVS2p4Q3B3bjB3WHNZb01FMXlWdy9MU1RjM0VB?= =?utf-8?B?K1FHNlJtK1B2anZJaDZ2ejM3VjhEaXBLSmVqdElpNkNnMng3dE0zaE5adDNK?= =?utf-8?B?NlFlbDM4ZUhDdFFRYVVWQ3liSml4RXJVeU1VelNCRVZUdXgrUWlKS2JBaTc2?= =?utf-8?B?cmJWTjJDWnl6NDBvZXlFelNReHZ5K0djdEdhL0hyOEw4VGJML1pDdVVrWDlB?= =?utf-8?B?KzhEMU1iZ2doa29icTFVdjZvYTUyUkJaTk44TFgvV0Z3d0doZlBQUSswTjFp?= =?utf-8?B?bWZJN2VCVU5XUTRmWG5iOU90Ym1qeFoyMWU0R2FtdU9ZbERXTjZXdjhXcmUr?= =?utf-8?B?SjFTZkR6RGdSaGJEYmc5Q3o5Rkh0U1lHSHhYL29hSEMzbG1ubFRVMHY1OEJB?= =?utf-8?B?eUZqQU1CM205djdpaVlxM25jQm0xWGpLZHVLVnBCNkI1MkNRd2FEdXRWQmpN?= =?utf-8?B?SmcxdlA5SC9xT2I1aTJweG40VkNKMkpQaHY2cDZiWTkzS3Y5a2huNVh1VC9t?= =?utf-8?B?QXpTdSs4WlpmbTN1RG0vL0w0ZXRlcHBzZThVTVphN1FvU2p6dERiY1VRQ2Ix?= =?utf-8?B?TERmWk1ZeWpLWGN2M01PYW5xWDJ0bjZpdVIzY0pJNmQvemlGbERvUXh0TXIz?= =?utf-8?B?UjF5Mm5KYkp6cG9CTVllWUQ0Rmt0Z0YwcW9FK2ZQNHNWMUJub0QwemJnc1c3?= =?utf-8?B?UFpHbGMyb04zZGRFSXlrVHFGRHZBRDJhd3hqK0I2anR1QlFtRjN1NXNwWE9G?= =?utf-8?B?ejE3WEZoV2kwQk0zak02RWtIdEhPZktiRGFCYmRlL0t0alExTmx1V3d6Vi9t?= =?utf-8?B?cE9PZXhJMmQ1U1MxMUFCM2JsWmxibTdjREhqK2VidnRsVGJJL3NqUTRtMW1r?= =?utf-8?B?d1pOVkNKaEtvZ29WbmNnK1RKNDJlMitNQ0RmQmpOc29QdXRBS2pUYVU3TVZj?= =?utf-8?Q?k80ZTOPqnP6PAHFtXqTXBHEKM?= Content-Type: text/plain; charset="utf-8" Content-ID: <49DD2C4B6B22CA42BFF369FDE739A27B@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ELe+zKMrTG14Ko7xRrOrFfe0m7nNCpR1MLy7+lWL3gr7xowmdxKZ+MwA1HnQhaVmtIESG3M6dnjRtUutNB/nJ1vTrPdt5Gkc1BF+EEPCFCCLKFRXy+91BSjUW4JKwwwHdUCIjGizVspTcvZwlmghRg6/qRksvOccLcxJ0iOC442l/bcGTH8f3gnhhQmV9gA/Gv/8AajWYfd/7hPZK9qGA6BF/rbIELNxAWqI3DZTa3bQid6+5ATl+unhUGUyQrIAkFZV+O4MPA39zp4bPtakUUviVjXF2SJqHYlRc1e8HtOnB1UU/yrtyeugQwkpcUrXukqSETIHS/dIl3IFCy8d/dH6ob1b0RDOsH44+BMKO3lPPy4gZFl3DaUY2w6pRiOj5SOfYvr0xB4HkDH8dKfbtULu+4l8PGYeYlzQu+jlkFpokN7RvG7Mwr79I1zCSbT3JIopodJj6F5zg4VbaiZ1pHtZhP1417Gz+gdQ6W4X8+VxDh8SUlZZJp8/CqUnSKxzJDFURluu02ELaYOSa6iOtsybSZRyzobeKxGdbIQizX2EBfcZZRLFkd6myBc4TrOrR6gQw6fT6kVyyktLHN0rIBrMjW+g3w3LPwmSOhZsOYeWR0YJuyLnycDXBYZ4LOvWPXPDkBnQ3VigXlKMe/GXXx+hTpadSJW1BeoOPygGLEPZTyh4wh5QTgkmhS2ZdDRY8fkVzv6ZShxcgKsyF5VaM/pbqvBmiPnmy/+ankQFgarpBucscwgxuEGnj2vngAOuL+nfjMEzUxLnpPucJeG5rnLYd26zzD/b3PjhZy/NXKz2TjW0SnfTQ2QOdjunYgNi X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2233fbf5-c982-41e2-36b1-08dace21d2cf X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2022 13:43:09.1759 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Kl39EdkLVD/e1FOK+nCgSKykf2s2IIwo/UXHUA03DFfQdOWVmt8tP6AnRbWNdHbpgyYNEZB9r30wY+B3hvNNfHbejSmic3fl7MjlDNHJtUQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5378 T24gMjQvMTEvMjAyMiAwOTowMywgRWR3aW4gVG9yb2sgd3JvdGU6DQo+PiBPbiAyMyBOb3YgMjAy MiwgYXQgMjI6MjUsIEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+IHdy b3RlOg0KPj4NCj4+IFRoZSBiaW5kaW5nIGZvciB4Y19pbnRlcmZhY2VfY2xvc2UoKSBmcmVlIHRo ZSB1bmRlcmx5aW5nIGhhbmRsZSB3aGlsZSBsZWF2aW5nDQo+PiB0aGUgT2NhbWwgb2JqZWN0IHN0 aWxsIGluIHNjb3BlIGFuZCB1c2FibGUuICBUaGlzIHdvdWxkIG1ha2UgaXQgZWFzeSB0byBzdWZm ZXINCj4+IGEgdXNlLWFmdGVyLWZyZWUsIGlmIGl0IHdlcmVuJ3QgZm9yIHRoZSBmYWN0IHRoYXQg dGhlIHR5cGljYWwgdXNhZ2UgaXMgYXMgYQ0KPj4gc2luZ2xldG9uIHRoYXQgbGl2ZXMgZm9yIHRo ZSBsaWZldGltZSBvZiB0aGUgcHJvZ3JhbS4NCj4+DQo+PiBPY2FtbCA1IG5vIGxvbmdlciBwZXJt aXRzIHN0b3JpbmcgYSBuYWtlZCBDIHBvaW50ZXIgaW4gYW4gT2NhbWwgdmFsdWUuDQo+Pg0KPj4g VGhlcmVmb3JlLCB1c2UgYSBDdXN0b20gYmxvY2suICBUaGlzIGFsbG93cyB1cyB0byB1c2UgdGhl IGZpbmFsaXNlciBjYWxsYmFjaw0KPj4gdG8gY2FsbCB4Y19pbnRlcmZhY2VfY2xvc2UoKSwgaWYg dGhlIE9jYW1sIG9iamVjdCBnb2VzIG91dCBvZiBzY29wZS4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5 OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPj4gLS0tDQo+PiBD QzogQ2hyaXN0aWFuIExpbmRpZyA8Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPg0KPj4gQ0M6 IERhdmlkIFNjb3R0IDxkYXZlQHJlY29pbC5vcmc+DQo+PiBDQzogRWR3aW4gVG9yb2sgPGVkdmlu LnRvcm9rQGNpdHJpeC5jb20+DQo+PiBDQzogUm9iIEhvZXMgPFJvYi5Ib2VzQGNpdHJpeC5jb20+ DQo+Pg0KPj4gSSd2ZSBjb25maXJtZWQgdGhhdCBYZW5jdHJsLmNsb3NlX2hhbmRsZSBkb2VzIGNh dXNlIHRoZSBmaW5hbGlzZXIgdG8gYmUNCj4+IGNhbGxlZCwgc2ltcGx5IGJ5IGRyb3BwaW5nIHRo ZSBoYW5kbGUgcmVmZXJlbmNlLg0KPg0KPiBUaGFua3MsIGEgZ29vZCB3YXkgdG8gdGVzdCB0aGlz IGlzIHdpdGggT0NBTUxSVU5QQVJBTT1jLCBwb3NzaWJsZSB1bmRlciB2YWxncmluZCwgd2hpY2gg Y2F1c2VzIGFsbCBmaW5hbGlzZXJzIHRvIGJlIGNhbGxlZCBvbiBleGl0DQo+IChub3JtYWxseSB0 aGV5IGFyZSBub3QgYmVjYXVzZSB0aGUgcHJvZ3JhbSBpcyBleGl0aW5nIGFueXdheSkNCg0KSSBk byB0aGF0IGFueXdheSwgYnV0IGl0J3Mgbm90IHJlbGV2YW50IGhlcmUuDQoNCldoYXQgbWF0dGVy cyBpcyBjaGVja2luZyB0aGF0IGNhbGxpbmcgY2xvc2VfaGFuZGxlIHJlbGVhc2VzIHRoZSBvYmpl Y3QNCihhbGJlaXQgd2l0aCBhIGZvcmNlZCBHQyBzd2VlcCkgYmVmb3JlIHRoZSBwcm9ncmFtIGVu ZHMuDQoNCj4+IGRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1YnMu YyBiL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybF9zdHVicy5jDQo+PiBpbmRleCBmMzc4NDhh ZTBiYjMuLjRlMTIwNDA4NTQyMiAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveGMv eGVuY3RybF9zdHVicy5jDQo+PiArKysgYi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1 YnMuYw0KPj4gQEAgLTM3LDEzICszNywyOCBAQA0KPj4NCj4+ICNpbmNsdWRlICJtbWFwX3N0dWJz LmgiDQo+Pg0KPj4gLSNkZWZpbmUgX0goX19oKSAoKHhjX2ludGVyZmFjZSAqKShfX2gpKQ0KPj4g KyNkZWZpbmUgX0goX19oKSAoKigoeGNfaW50ZXJmYWNlICoqKURhdGFfY3VzdG9tX3ZhbChfX2gp KSkNCj4+ICNkZWZpbmUgX0QoX19kKSAoKHVpbnQzMl90KUludF92YWwoX19kKSkNCj4NCj4gSSB0 aGluayB0aGlzIHJlcXVpcmVzIGFuIHVwZGF0ZSBpbiB4ZW5vcHNkIHRvbyB0byBtYXRjaCwgb3Ro ZXJ3aXNlIGl0J2xsIGNyYXNoOg0KPiBodHRwczovL2dpdGh1Yi5jb20veGFwaS1wcm9qZWN0L3hl bm9wc2QvYmxvYi9tYXN0ZXIvY19zdHVicy94ZW5jdHJsZXh0X3N0dWJzLmMjTDMyDQoNClVyZ2gu wqAgSSdsbCB0YWtlIGEgbm90ZSB0byBkbyB0aGF0IHdoZW4gYnJpbmdpbmcgaW4gdGhlIGNoYW5n ZS4NCg0KPiBUaGlzIHdhc24ndCBhbiBpc3N1ZSB3aXRoIHRoZSBvcmlnaW5hbCBwYXRjaCB3aGlj aCB1c2VkIERhdGFfYWJzdHJhY3RfdmFsIGhlcmUsIGJlY2F1c2UNCj4gdGhhdCAoY3VycmVudGx5 KSBoYXBwZW5zIHRvIGJvaWwgZG93biB0byBqdXN0IGEgY2FzdCAod2l0aCBzb21lIEdDIG1ldGFk YXRhICpiZWZvcmUqIGl0KSwNCj4gc28gdGhlIG9sZCB3YXkgb2YganVzdCBjYXN0aW5nIE9DYW1s IHZhbHVlIHRvIEMgcG9pbnRlciBzdGlsbCB3b3JrZWQuDQo+DQo+IEhvd2V2ZXIgRGF0YV9jdXN0 b21fdmFsIGJvaWxzIGRvd24gdG8gYWNjZXNzaW5nIGEgdmFsdWUgYXQgK3NpemVvZih2YWx1ZSkg b2Zmc2V0LA0KPiBzbyB4ZW5vcHNkIHdvdWxkIG5vdyByZWFkIHRoZSB3cm9uZyBwb2ludGVyLg0K PiBQZXJoYXBzIGl0IHdvdWxkJ3ZlIGJlZW4gYmV0dGVyIHRvIGhhdmUgdGhpcyBfSCBkZWZpbmVk IGluIHNvbWUgaGVhZGVyLCBvdGhlcndpc2UgZXh0ZW5kaW5nIFhlbmN0cmwgdGhlIHdheSB4ZW5v cHNkIGRvZXMgaXQgaXMgcXVpdGUgYnJpdHRsZS4NCg0KRXhwb3J0aW5nIF9IIHdvbid0IGhlbHAg YmVjYXVzZSBldmVyeXRoaW5nIGlzIHN0YXRpY2FsbHkgYnVpbHQuwqAgSXQncw0KYnJpdHRsZSBi ZWNhdXNlIHhlbm9wc2QgaGFzIGdvdCBhIGxvY2FsIHBpZWNlIG9mIEMgcGxheWluZyBhcm91bmQg d2l0aA0KdGhlIGludGVybmFscyBvZiBzb21lb25lIGVsc2UncyBsaWJyYXJ5LsKgIFRoaXMgdmlv bGF0ZXMgbW9yZSBydWxlcyB0aGFuDQpJIGNhcmUgdG8gbGlzdC4NCg0KV2UgKFhlblNlcnZlcikg c2hvdWxkIGRlZmluaXRlbHkgd29yayB0byBpbXByb3ZlIHRoaW5ncywgYnV0IHRoaXMgaXMNCmVu dGlyZWx5IGEgeGVub3BzZCBwcm9ibGVtLCBub3QgYW4gdXBzdHJlYW0gWGVuIHByb2JsZW0uDQoN Cn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Thu Nov 24 14:04:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 14:04:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447955.704626 (Exim 4.92) (envelope-from ) id 1oyCpa-0005gI-H5; Thu, 24 Nov 2022 14:03:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447955.704626; Thu, 24 Nov 2022 14:03:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyCpa-0005gB-Co; Thu, 24 Nov 2022 14:03:58 +0000 Received: by outflank-mailman (input) for mailman id 447955; Thu, 24 Nov 2022 14:03:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyCpZ-0005g5-GX for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 14:03:57 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d46e05e9-6c00-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 15:03:55 +0100 (CET) Received: from mail-bn8nam12lp2170.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Nov 2022 09:03:52 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by CO1PR03MB5905.namprd03.prod.outlook.com (2603:10b6:303:9b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Thu, 24 Nov 2022 14:03:50 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%4]) with mapi id 15.20.5857.019; Thu, 24 Nov 2022 14:03:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d46e05e9-6c00-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669298635; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=GKm21m/ei8A8HZn4THt29obXo8gV8ogQzZOGz2qdL/M=; b=LTtheq9f5J4gU2co0bA8Zv7kWCTfj1Mmx5dLPVXwb94bNUpaojf8AgK/ +nDwTxUPPTGCWtJ0BkpY3WwapPt6qpbkgiomQ1sfJky5QOQ0pPPdWW5CP 5Vd5Okk1b21TaxCHlXOlvD/RFZejGcwRCEsUnScST3G1R9r+yGKia2Jlm 8=; X-IronPort-RemoteIP: 104.47.55.170 X-IronPort-MID: 85918850 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FQOAk6zGI5WfxU/H+dN6t+ckxyrEfRIJ4+MujC+fZmUNrF6WrkUAx 2IaCGiCaamPZDfwKIgia9iw/RsEvZ+EyIViG1RpriAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnP6wT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVNcr tEpJzMfVzSSqs2u0r+fYdV8nct2eaEHPKtH0p1h5RfwKK98BLrlE+DN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjWVlVMpuFTuGIO9ltiiSMlLn0Deu mXc+GfRCRAGLt2PjzGC9xpAg8efwHKiCNJPTNVU8NZLmFed5EMfIiY0amKS+MC3jXz5Qo5mf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpZNU4uecsSDct1 1vPmMnmbQGDq5WQQHOZs72S/TW7PHFPKXdYPHBcCwwY/9PkvYc/yArVScpuG7K0iduzHizsx zeNr241gLB7YdM36phXNGvv21qEzqUlhCZsjukLdgpJNj9EWbM= IronPort-HdrOrdr: A9a23:cCOA5a+XXYNpfhkOXN1uk+Hwdr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirCWekD+y77b+Mh6AmjMTSSlGz7sO+X XM11WR3NTjj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhn8lwqyY4xlerua+BQ4uvum5loGmM TF5z0gI8NwwXXMeXzdm2qi5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe F29lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQFo+dY7bWfHAbIcYa 5T5fLnlbBrmJShHinkV1xUsZiRt7IIb0+7qwY5y5eoOnNt7Q1EJgMjtbAidzE7hdIAotB/lp r5G7Utm7dUQsAMa6VhQO8HXMusE2TIBQnBKWSIPD3cZeg60+Kkke+J3FwZ3pDcRHUz9upFpL 3RFFdD8WIicUPnDsODmJVN7xDWWW24GTDg0NtX6ZR1sqD1AOODC1zJdHk+18+75/kPCMzSXP i+fJpQHv/4NGPrXYJExRf3VZVeIWQXFMcVptE4UVSTpd+jEPyjisXLNPLIYLb9GzctXW3yRn MFQTjoPc1FqlumX3fp6SKhL08FunaPiK6YPJKqjNT7krJ9R7GkmjJl+WiR94WMNSBItLAwcQ 93PK7n+5nL11WLwQ== X-IronPort-AV: E=Sophos;i="5.96,190,1665460800"; d="scan'208";a="85918850" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jLDQnGS7XajWKsfjoK5itYQF2tr5hNUQmnCW2IhFIRecnTituEHjJ/8yydwyCXzCqGsxKUsu6Ng+GnKCcRkhXVdcFXRI3DljLuMs2zdR641kY8Yc0eGrmotZSZiymBHHFjUAJc9Uytr/mtCXVsdR+8i3KMOHHCyC8ERo6nCpPiTNiXn6hK0n5iIxvZv1Ki/8DN7p7UE0DBdKuPv4CuZ2yvHHfouPPM3AJeI0St9oNLRHAEXI8h9ITDIWqwW3/7x7+ksx65RhJjttT756KSNf46iMY2e8UMqr0EHD1VzE7RffUk34u3uNjkCgBsQrI6XAMlW/3AcbFZAR7WPCb5cKgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=faxN35LKzPGT2r9ItmdavXbC1Ycc1lyFGQPJxy9f/+o=; b=RSpgsBTVdnTgQex5mrW217Dcvd1shAHgRjC6foJIwF8xfrifkrx2n3PeZMdTAQRmcBRFBMB81hQwS4LAAdfBjvXTw5CTfqrPicz3KhtAohxP7XgyY9wo8X/5L5emMO8ePtSrSJdCvhd89jV4mw96vmdA+yQtNGmkYmHNpn4DHSrzhdKAvVEQWm8r8vtHXFRPFtYXQSKZsOPnbe6IOCC7d4TXtwdEwkIDqTQCAoXc9pVOLDxQCR/4lXu2S7ovDByVzKgpeMUMWz9NRexFAc0i7OLN4vX+WIYz7IKm3JfDQl/i/ID99w/Z6VfBICfzBKkCHo7tvOF+569UndYz286fnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=faxN35LKzPGT2r9ItmdavXbC1Ycc1lyFGQPJxy9f/+o=; b=cFW0ZTnbJd2obEWzzQ/e3AATdC4mgEYzgrooJpDizV7FyO1dRDpJDr77DT0HEYDedDJrpftCdKkCz0v5i64ql9hfzlOgCs8P5AN1/b9lQOqMufv1llyJ4yFidAliUJJQslm+x4T0G/0cjbylV79RemobjNH1gHin8fMmg19rFqY= From: Edwin Torok To: Andrew Cooper CC: Xen-devel , Christian Lindig , David Scott , Rob Hoes Subject: Re: [PATCH] tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free Thread-Topic: [PATCH] tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free Thread-Index: AQHY/4p9nL2l64sg4kKJKi/wcWyqlK5NyCiAgABOI4CAAAW5AA== Date: Thu, 24 Nov 2022 14:03:49 +0000 Message-ID: References: <20221123222517.12140-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|CO1PR03MB5905:EE_ x-ms-office365-filtering-correlation-id: 876225bd-8e82-4b8f-c4b5-08dace24b641 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5EJRTw0la8A8l5ALjGynuoqB3urmKToMTovGOSNl3Uofxr+t3dA7q+7aaCTcxqNN/fT4bUKvfeRF3syiD2veyZ1jaf+qfcj/9BnAHXIb1QtgR6CQSzDgC2Gn+9SihthXQauAyGRReyjiN44J2rgoIUTS62fASA7gzC4AIR/W2jLUnHxGokLOvX6aLq5XfzfAeO7UGE6A19+rNL+3dpELhYZEUwI/baQHvhc/bFTGYdSIh5AOldfCpMtTvQm6NGjYXqJ8Vg52Sdnm43nh2iGDnFYzB6jPguaaq5XdmFS96gROtlvHOqJuGw5VcCOj/dGjbFNyUdT9GQru3IPQZSt7ohumo1S2A3iSQ1rZrg9vm8HIncNRPaCBalYPDlIX+UAYC1ee+qXP5s+B61iZEgd8XXE9P6eQhUKMu/Md/BbVbzImrgiPCY2VyEeB0M327cqmbARysGvIJZu6w7ipiST3Emlaqp3TXoZvPB6RQ3/Syu7AzFLaJ1tMRJBc2L49BDud2+PPxBziT+/r6cuLrzypwocd7aYQYTAF9YMQV98zmzaELWgZevqEalV1AGbxajCcgv894RnfUh6ZH3XYu6ZIU0QnPM5ji0mRxcGM5tmYJGBdSvIAVk3AFNuDNqPRhsa2g7T4DzHGhFEdm4ox18l5jafcAKkqmi0aX3ogJLTohbjMTO/bq0bzleEIlc+19K9R5+t9vzr/0zSdSABSVgk1c5NTQYLKq4+RmYaV4zzsnPF5jVeTqc+wZtdL6ymx7H42Dp6L/amgX6oMEzSS6MrT8A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(39860400002)(366004)(136003)(396003)(451199015)(122000001)(33656002)(82960400001)(86362001)(36756003)(38070700005)(66476007)(186003)(66556008)(316002)(54906003)(26005)(2616005)(66946007)(107886003)(91956017)(53546011)(6486002)(966005)(71200400001)(83380400001)(478600001)(37006003)(4326008)(41300700001)(76116006)(8676002)(6636002)(66446008)(6506007)(64756008)(8936002)(6512007)(2906002)(5660300002)(6862004)(38100700002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uWlpvmv+bnNCDJdMuMIyXzmhInLVR9djmVZwaj/KozOuKzwxsJom3DhyLgpX?= =?us-ascii?Q?iMdKp0EYVNsUSwxadkMx5uEPVZVZx8K+J/QtlPyWpYDrRSNiyxJe7k1RBUrJ?= =?us-ascii?Q?jLvjpfIESQmzXMltQRbrbAe6VJn7NYMpNZV95ZKH+daKV2hyT5cLqi0bJlfe?= =?us-ascii?Q?UraEoC9z4Hgb63kBn51EzjFNzMkBpPVYMFUekNpwuGjYieDap7eiwF2lV15g?= =?us-ascii?Q?x008LB9DM+Ef70bLc8ZmWHuBTitlhZHBpkKQmFyjcck8yPAczoycnqSmTx/E?= =?us-ascii?Q?7P5xFCHb6JKbyRqsPilVeQYeAQeNAtmuEAMRnvrJZ9xec3IJ/RebnhSzVd8x?= =?us-ascii?Q?E/tCpbF4142iX43Up5ySle1ndq1p1KFvUBpw3Ap0hJmix5abx5NyzDojpW5v?= =?us-ascii?Q?FO+7BJAcQiqDwXLngA0TqX7r5vWQr0zHSsiHOOlGWAzOiOw9EAs9slq+y71F?= =?us-ascii?Q?wM79E3P0n5DzDXUyvPQ/ep91w6WeE+/etiXvTz25Wl7UVJ+IVDwIEJt1bIGT?= =?us-ascii?Q?BzgfK7NSg3xQmTWQQLt3K98PJtjRSgu7J4cJ4hHJANmQU8eOTididuzxSRhM?= =?us-ascii?Q?7I14B1fzS4Yx0NeYuAU1944e7TLAG156BbNqp3HLVvtRd7njRRpmfoLZd58I?= =?us-ascii?Q?V6uJfYKqXpTaNb7diKLoWqKJojrlIc7EbPa8dU0FxbCihtqLwEpTVEiqFtZN?= =?us-ascii?Q?Syr9jz8ozgehYjFJw7HhRmqeet8EMKe4+Vkyf0wjsLu5sdm7SmUhwXBcQA0Z?= =?us-ascii?Q?NE2b4xo7YS9h4xPV6Ko1jdBU5j6LbzAeec11rGgs1/SW6V/U0mTnx0YtQ1xX?= =?us-ascii?Q?kNT01upC31UJtsF3qwyaBv6vfRB0rugzDanlOv46znNB/w4QjiyW5Opl7KfL?= =?us-ascii?Q?7lRHECtpkePb9SAd9UEhyyjzpxRQJpyGORl1Id+oPrhUy+g1aV2tjlIol11E?= =?us-ascii?Q?1hHJagcEiAQtxS2A1twZxHyROUWpSydABY8SAScYPBEIf18g+uJZ4dsO2Y+Y?= =?us-ascii?Q?LNwgp04s/FiPF30JHSlI0Kqphfo0CbUmIdg0nmzD2gVRXylRX3l9t+tp41EU?= =?us-ascii?Q?af7oFYj8PdGXJnU0+UWPsz8hgqRvMezlo86BjMXFW1HDvyjt+sViadJSwPEO?= =?us-ascii?Q?q+d0zeaEL28YFoNqpEWw/CoU3XvJ+zhvOlVwYNzFz2zoyyTwcJ0J7AFnuSLX?= =?us-ascii?Q?wUDwaS7cRyOSbfLH3xehPTuVbhQtxkrmeYKdzrPfqHPWdTmoWfDJkYAnJ+UR?= =?us-ascii?Q?mZzXRquQERhsxuAYf3mPqJs6JRPjzi8mATNOBwPSRwnhd7oFfJdgVZmaCokV?= =?us-ascii?Q?mZmvYNVlt5w3rFFs6h0KUeWyGRc65v8ZLGhMlgPHVIf/b5ov1FTnKa+chFjM?= =?us-ascii?Q?EYRKcWtRXh0pyw4gqoyt0JeEQJoIGz5pNQ8GNVfmxCjnlPmlS8HA6c+tSpNb?= =?us-ascii?Q?6ITo5CN+/7m06WxIeVnAMawANKWnQ5Po8BLfY9Ahzd0IVJ3BgYijgawj8lDO?= =?us-ascii?Q?nhpszI+4hhyVsf+KeMg5NkA2AsBcUZnrYFGGD6oOj+vE6cbFAfD3kP2ufEEZ?= =?us-ascii?Q?4yXNKBXdjQAcCcG2gk07DmDx98KFpIMl3vk9P5NamFB/Xi68KmDUECKTaCNN?= =?us-ascii?Q?DA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <78250622BA025E46869BA93F52A8F105@namprd03.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: zUVuxdNbk8gUgBejmX9RiM8YxttUKeLEMoCYyVXudy+gFM3UwCz3M2MhzOpZJpF51nQrxIT8lFUBMgrqiCkmmuGZc0jg99yz4tC93eIYOy5VvIxhiOW39tYknULSeCRETUfhrxWq+jkvVwaOVOWMPwCHcO4PLWH27wQZ6Yuu6I5/TwNNnteb/66QwfQYXwuXh0XN9fZWSmzAJ0TytxBqvD90c1MYCwvyCxoeLT2BAAwUbUGosBc2ubkj2XHV2BF2MqChLWioLLHmgADR8lAp2JkC0PTGI0qKL42tvOSMazfSXUncLTNF4aUIua538mMTjSXDATzntIOnKJ1A08CbOqMfSNaen7j9pMXoeG9d/UVUiajpLhdAZaNZ/3xm+ttsnsbwrmjRgLv28Jh9jy/qNCN4ganqgjlYhK4SMIRkEWTQhZIcosLM8d73JnwpyIQ99KE9mWW3RiIe4d2tRJ7bOW+XrMUR5sudf7e0j6NGJc/pTwraVZv3zFcS7tuOOjVc8lT2/fsMCzGLhxWER/zev0PqrM1K3K/RMTb4XI8i5EE4HmgpU9sknR4F75R/3fqpxUSM9vfEDGa479VFGKyzj5kSftfaKc2pzXvae1st3PmRPSZLctpKGqW/OHzwVGr6I9499BmzL6lqqaewf93mitPd2YxC7GnAQBisTA9WLmM6n0zOFvfg+hZ4DEujzIwLCYKDmH2wZZy8N+JVyLjukL8M40iasQv9HpZ4jvdjaM0F1LicGQRMLRWfM81e0uRpvlnaZ9rLGrN9SV7ygqJSC+kjbAeQeztCuHMv+ag4BKeYWJ0OXXAuOGAxl727h3/O X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 876225bd-8e82-4b8f-c4b5-08dace24b641 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2022 14:03:49.7942 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QBX0SYrjrRKhEqmyTc89WH0dsuy5H6W5r528OGHHZ/VPpKQiQIJD9oS5svwmh0d91EQLe+ZdBGuIGeIg6NvNzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5905 > On 24 Nov 2022, at 13:43, Andrew Cooper wrote= : >=20 > On 24/11/2022 09:03, Edwin Torok wrote: >>> On 23 Nov 2022, at 22:25, Andrew Cooper wro= te: >>>=20 >>> The binding for xc_interface_close() free the underlying handle while l= eaving >>> the Ocaml object still in scope and usable. This would make it easy to= suffer >>> a use-after-free, if it weren't for the fact that the typical usage is = as a >>> singleton that lives for the lifetime of the program. >>>=20 >>> Ocaml 5 no longer permits storing a naked C pointer in an Ocaml value. >>>=20 >>> Therefore, use a Custom block. This allows us to use the finaliser cal= lback >>> to call xc_interface_close(), if the Ocaml object goes out of scope. >>>=20 >>> Signed-off-by: Andrew Cooper >>> --- >>> CC: Christian Lindig >>> CC: David Scott >>> CC: Edwin Torok >>> CC: Rob Hoes >>>=20 >>> I've confirmed that Xenctrl.close_handle does cause the finaliser to be >>> called, simply by dropping the handle reference. >>=20 >> Thanks, a good way to test this is with OCAMLRUNPARAM=3Dc, possible unde= r valgrind, which causes all finalisers to be called on exit >> (normally they are not because the program is exiting anyway) >=20 > I do that anyway, but it's not relevant here. >=20 > What matters is checking that calling close_handle releases the object > (albeit with a forced GC sweep) before the program ends. >=20 >>> diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/= xenctrl_stubs.c >>> index f37848ae0bb3..4e1204085422 100644 >>> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c >>> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c >>> @@ -37,13 +37,28 @@ >>>=20 >>> #include "mmap_stubs.h" >>>=20 >>> -#define _H(__h) ((xc_interface *)(__h)) >>> +#define _H(__h) (*((xc_interface **)Data_custom_val(__h))) >>> #define _D(__d) ((uint32_t)Int_val(__d)) >>=20 >> I think this requires an update in xenopsd too to match, otherwise it'll= crash: >> https://github.com/xapi-project/xenopsd/blob/master/c_stubs/xenctrlext_s= tubs.c#L32 >=20 > Urgh. I'll take a note to do that when bringing in the change. >=20 >> This wasn't an issue with the original patch which used Data_abstract_va= l here, because >> that (currently) happens to boil down to just a cast (with some GC metad= ata *before* it), >> so the old way of just casting OCaml value to C pointer still worked. >>=20 >> However Data_custom_val boils down to accessing a value at +sizeof(value= ) offset, >> so xenopsd would now read the wrong pointer. >> Perhaps it would've been better to have this _H defined in some header, = otherwise extending Xenctrl the way xenopsd does it is quite brittle. >=20 > Exporting _H won't help because everything is statically built.=20 As long as you don't rebuilt xenopsd you will keep using the old C stubs th= at xenopsd got compiled with, the change in Xen will have no effect until x= enopsd is recompiled, at which point it could pick up the new _H if available, but I agree with y= our point below. > It's > brittle because xenopsd has got a local piece of C playing around with > the internals of someone else's library. This violates more rules than > I care to list. >=20 > We (XenServer) should definitely work to improve things, but this is > entirely a xenopsd problem, not an upstream Xen problem. It is a lot easier to add new xenctrl bindings and test them out in xenopsd= than it is to add them to Xen. We should try to either upstream all xenopsd xenctrl bindings to Xen, and m= ake it easier to add them to Xen going forward; or move all the Xenctrl bindings to xenopsd, then at least you only need to= rebuild the one piece you are changing. But to do the latter we first need to get everything that relies on xenctrl= to move to more stable interfaces (including oxenstored). There are some Mirage libraries as well that use xenctrl, when a more suita= ble stable interface exists in newer versions of Xen that they should use i= nstead. Perhaps a compromise between the 2 extremes would be for xenopsd to open an= d have its own xenctrl handle, even if that leads to some code duplication,= it would at least not rely on an undocumented and unstable internal detail= of an already unstable ABI. And that would still allow xenopsd to extend x= enctrl with bindings that are not (yet) present in Xen. What do you think? Best regards, --Edwin From xen-devel-bounces@lists.xenproject.org Thu Nov 24 14:13:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 14:13:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447959.704637 (Exim 4.92) (envelope-from ) id 1oyCyt-0007M7-DR; Thu, 24 Nov 2022 14:13:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447959.704637; Thu, 24 Nov 2022 14:13:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyCyt-0007M0-AB; Thu, 24 Nov 2022 14:13:35 +0000 Received: by outflank-mailman (input) for mailman id 447959; Thu, 24 Nov 2022 14:13:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyCys-0007Lu-55 for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 14:13:34 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c0a3e01-6c02-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 15:13:32 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Nov 2022 09:13:26 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO1PR03MB5796.namprd03.prod.outlook.com (2603:10b6:303:9a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Thu, 24 Nov 2022 14:13:24 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5857.018; Thu, 24 Nov 2022 14:13:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c0a3e01-6c02-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669299212; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=q9TIv+jBGRgt6msmGG+uhMUtu7e+mTwRPLnsSDmlyO0=; b=h/1UPQPxhpY4TM4cUhNw8opVTShGG+8aukrRoO1KljVXXcrs2Y76IDyP H7CvKk8/+NrD3ZERA75CnNEwPBjkliLtTAPGFismiLF29QG1xE4FMmTWR YbSiPqrargkxiv0MxKsNzp982799lqa0/X36E6qXG6OQlk5rHMfOfbIEE s=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 85071288 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:E8T8w68K6MRlibfya3JGDrUDnH+TJUtcMsCJ2f8bNWPcYEJGY0x3y 2pODDjQPv+IMGDzKo1xbYS+/RgHucfXnIJmG1Q6+Ho8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKoX5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklwq uwhcRYSbymohtqs0Z2JCflMo+cKeZyD0IM34hmMzBn/JNN/GNXpZfWP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUvgdABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCN9KS+Tipq4CbFu7+zQjNyEPRVWAi/ykpG2eXNFiK Fcyw397xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnMM/WzECz FKCmNLtQzt1v9WopWm1876VqXa4P3gTJGpbPCscF1Jbsp/kvZ05iQ/JQpB7Cqmpg9bpGDb2h TeXsCw5gLZVhskOv0mmwW36b/uXjsChZmYICs//BwpJMisRiFaZWrGV IronPort-HdrOrdr: A9a23:K23XRahaFAdC6XGVbmNFkW5OAnBQX/J23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu17h/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboXgTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp9KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wXh4SqbpXVd WGPvuso8q+QmnqKUwxeVMfmeBEa05DWituhHJy4vB9nQImx0yRhHFoufD31k1wiK7VDaM0p9 gse54Y6o2nBKUtHN1ALfZETs2tBmPXRxXQdGqUPFT8DakCf2nAspjt/dwOlaiXkbEzvewPca 76ISVlnH93f1irBdyF3ZVN/ByISGKhXS71wsUb45RioLXzSLfiLCXGETkV4oCdiuRaBteeV+ e4OZpQDfOmJWzyGZxR1wm7X5VJM3ERXMAcp95+UVOTpcDALJHsq4XgAb7uDauoFSxhVnL0A3 MFUjS2LMJc7lqzUnu9mxTVU2OFQD2KwXuxKtmuwwE+8vl/CmQXiHlltb2Q3LD6FRRS9qorYU B5PLTr1qumuGjexxe701lU X-IronPort-AV: E=Sophos;i="5.96,190,1665460800"; d="scan'208";a="85071288" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FhVUspRE4C3Fy2r1O4s3rI1mmDh6l1S1nolq7Wa6T0T1QRWptfhJdGTh2RckftYyJkENJL7WhDpqfWWX0D7cZ+HHAp6JJzzIF87JdTSwvk5cQzVAytnIRA7Djmsa68i/4PcYNu4XOykpLHUqe+Uaco6fTb80e05hid9aTwkmQCFcKMmpIeqbLT1p2jsfJV9+3VmkiXkr/hx6lMU2R5WoS/0faB2DMyYD2IyQSSg3JzuvbHVq8m6wT61PEUE38h+j5xI3sVGjpw27LPbLKDqfcQLgPKVAfrKbc71SJAjyd5ZiK5jxLhN03FGw+c/M1aecpy9012gf/volV4zrkCoI1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q9TIv+jBGRgt6msmGG+uhMUtu7e+mTwRPLnsSDmlyO0=; b=C/kHCjcrbJPEEzkCNpKpmA8L8JZKHXXLzobPG1J92dWtKieIEHulTR8WbLgWtFnzZv6KlVNNLe/sV7UeADJ/T6AxCbxaxzXN53tD+CaLcDwkKycPvf7rshFq7duF4PcJPxNG47Ndwz1NZ1yduuVf1b4UpM0CBcv+8zTsBQlYVpcroclS3rVwRH63d9DQTGzqjQnbDS63mdOArGV1IKfjcV83APSxinp84Z1GB8nJ/iDFE8wXm5FODSVIzWVQhgJTX8MUZ/NLvH9XKAxM9xG3ok6EgHvaCvRKa4DFK6dPBF96oHmb6paqeA/8lnuvNtfWSgs7HpT9tS50LmUb+G0R5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q9TIv+jBGRgt6msmGG+uhMUtu7e+mTwRPLnsSDmlyO0=; b=cFGfa4OThK2PrjNas/jfvYi9DMT6VIP3jztLaMdgT3sWdyU4lVr4QwWxVFj8HTKxj2huNNiGjcv12UQ8toGAIlCX40HBkhmC52XLiDwSvC4vGz0CMFrasZ7x0ygI/MDrW7hN2pCUpJHSVAp3MOaQ62uWlruZbj0UHuLGINW4WNY= From: Andrew Cooper To: Edwin Torok CC: Xen-devel , Christian Lindig , David Scott , Rob Hoes Subject: Re: [PATCH] tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free Thread-Topic: [PATCH] tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free Thread-Index: AQHY/4p9GINVmjprlEGx5iAuzyYE1a5NyDSAgABOFgCAAAXHgIAAAqyA Date: Thu, 24 Nov 2022 14:13:23 +0000 Message-ID: References: <20221123222517.12140-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CO1PR03MB5796:EE_ x-ms-office365-filtering-correlation-id: be514375-36d4-4a26-6631-08dace260c6a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 79djMSfgbY+9M1edXp2akG1cp9fhoCguLzMHIJaTXhVX1TfqBRJ5Z58YdSMfD9BYnPa+H73u94gkBHUKaTKMilz1xEaWOLT9fAircpgwKqXviRCHFcUbs8IzdU1UN0DRGufRNlBSfUjcBK4FslitiYqqOdkO8VUOU7Ln+mR7hfGCSCHyf3H3GMC7hlPBFtvyCuSiDUYBFvh3bWX9fsaMALn5t3tQWAQM2E0n1J/AlqBD6bWViTnbssE87+/5X/+tjp/b+IqGatx4gliSf9Tpuk32mLuUNVf2w0pxz7Chc4UM1rVUJfezbCgCX6dQ8aPUxbAYn36IiAquexTvZgivIkL5PvH3qvuT7y3iDdAzcnVsMFh1HE1hTJPpFfCuv9dg9smThQg70ebuOK1xOKGQFnRY5eBy1PAOM5FENcrK1GmkpQoYU2i0rhR/rrqug/4DCbcYIfLGu5aX4GDkaquxZuqvmekdNiadgRuvr7GEAFM+8GsGyfw2jPVHkw3AefWtWmi6X/2Ga/ihDmgjq8WTgUQGjXNZ3Vi3MFnkdo4tsj/EMV+sZ0vLZtDu9NhxRyZud/N2uBh9+0A7DLh8q8fBCMmDSzPDVM7EcFrqdbZACA/IBKaF7l7gGYtX1p0Ywfsp8G4lDxKqNtF7w6r51LTN1TaYNxvE82wdm5Diyzs/HxNj5cxfmxPckDEB176WXYiqFKViQFs5equJij5bRbMk0N7WF7y7Tdwpob4DBoGc5BM//QClzCPNP+qI0NqFINnAX50TRiDC1KloO5gY4eKBfISWg7LGBr7OaRnFKFIELno= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(366004)(346002)(376002)(136003)(451199015)(36756003)(31686004)(86362001)(26005)(31696002)(38070700005)(8676002)(71200400001)(66946007)(64756008)(66556008)(4326008)(66446008)(66476007)(6636002)(76116006)(91956017)(38100700002)(122000001)(82960400001)(478600001)(6506007)(83380400001)(107886003)(2616005)(53546011)(6512007)(2906002)(6862004)(41300700001)(37006003)(54906003)(316002)(5660300002)(186003)(6486002)(8936002)(966005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eXhjdjc1MUdUNko0T1lHMllHSGh1dzlxZmcwYjRXSFQrT0JXMFF2Z3ZUL1dp?= =?utf-8?B?d1lRcGdkNnNEekRkSjJpZlVLdHNyK3BsWmgzdEFpdGJ3d081MExvSXN2THZx?= =?utf-8?B?VDRyRkQ0UXZwWVI3TTRWN2lpMnRua2oyZ0lHYWRMRC9DaG9XMS9xZ0NsTXFW?= =?utf-8?B?SG5rOUZ1ai9JUGlEK1JGMDFGQUFxKzg2bkhYR1RHZnZacEJodmd2Q1dIckpT?= =?utf-8?B?WVZLL1hDMTh4SVdSeU80MG91bDk2dG5Rb29MOEpvYzh6OUt6aGxKUitZQ2Mr?= =?utf-8?B?WStIaFNLa3llblNUektpMmlyVVJSWGpHd011OWNmNlZ5blR3SEM3WG8vNW5j?= =?utf-8?B?QkphR3VoOUZtVEFUMmdURXZlaXhRZitKQU1Mc0VOODdhdTgrQTEwSEFqUDlx?= =?utf-8?B?V0kzSE9uaFV2SWoyQ3Q5UzBsVnAxS0NJRHZrZUcwTUdpSUVMc2hWY2NWUkJ0?= =?utf-8?B?TjRZWm1QVVVJdHc3ZXBWeVpaRXBrNWdEVTNIanFSMFJoMlBKSVBNVUF1aU9B?= =?utf-8?B?SFlxUURpNnRmS3hBR1BuNHFjVGpVODk3ellTRkRYbFUyY2t2RlVFNVlrK0Js?= =?utf-8?B?YjRiekFQK2VjOTNGOHBaTHlBbHQ2dTRaSjZ1S3NabEY1VEd6cjhtR3N3V29w?= =?utf-8?B?NFdFQVN5alZFMHRHRExvYUJwWEY1YWMvQ3RudjVZR3BOck5ERHp6NU1zenNk?= =?utf-8?B?UURMMERpbVBjQVNMZDJLdXJxZ3BiekQ5MTFZT3BrdEhNRkhhcjZ4RUxmelhu?= =?utf-8?B?SERhemZ2bHlvRmdBRXRrdmluR1g0ZFFRNzFSMFFHbUprUExvK3RPTS9xNFV5?= =?utf-8?B?VXhPY2xoUWhWMitNZklLV0hoWDBrZWJFOWgzUy9EeTNWZ2tLQW1iU3c5SHZI?= =?utf-8?B?OU9FdXhDVlpRUnh2OHBWM2trUndMbmhEZzh0SnRnRStYblB0elVDcG9pZnVq?= =?utf-8?B?eEZOZmdmWlhkRjNNT3pqK2NpTi9PMXBvd2ltRmdRSUtZT2hlNnhOL2NaUytU?= =?utf-8?B?WW9jTlptN3k2V0hTOEx4M3dsL2pOR1gwVmFHOXg1eFZzRXRnMkt6b0Zpc2Jo?= =?utf-8?B?a1NqN0tFSUJ0THR2M0h3MC84Q2RBU0lLWnJrckdrTWZEazZHSjZOMElpdU82?= =?utf-8?B?ZnBRVnZROVllZ1VXZ2dHU1BjU0M5dkxsWVN4ZVZtR3I2Ky82bko5UUlla2dy?= =?utf-8?B?TmFDbWM1MnY3MmV6VENRdFlFeUhIZDhRTERpVDQrZEFpOXg2WXpPUHNFNHhW?= =?utf-8?B?MFJjYUU0SndORHh2b05JbG52ZjJHVFFVVDRaSHZEWFUwaWJKRUkyaTY3THph?= =?utf-8?B?OXBJcTRweUxOSTRhMXBMRzc0Zlhya2hmU0JvOU1uNDUyUlNacUZ6eVgrVmsy?= =?utf-8?B?ZWlZa3hBeGx0cGl2R3dwU3dkRHcrbHJTNDhtTXVLOEc1ZEJVcVhvYy9FMTRl?= =?utf-8?B?VG0xakNZVlFZTm9qWk1yaTZyOGNKTmdKYk5iMFd5dmQzQ1V6ZGxna09OR2di?= =?utf-8?B?dHdybkVEM1pVWXpVZlhaL2JZQlNnUXNOSk1PTnMybWxtMlJoejJUOEQ2cTB5?= =?utf-8?B?Q3B5dlM4eUU2S1Bxb09iMW1FU3p3bWt0a2dWZkttUHB5MDdabENBU0xzaG13?= =?utf-8?B?SVZsa1ZqaU5za1ozSjVqdUR1d3R6WkQ4WXl3ay9CTjNKenlKbUVkNS9JbmYx?= =?utf-8?B?elJJWTQzOFEvUDIwV1RhNUF3WVVHcmlnSWdQN3lZWGNUbGhXWUNRWXh2Y0hN?= =?utf-8?B?Q1VneFNvZTVRYi85TVczVmlaVkN3elVWTzQ3ZHNtSHExYTdEMDNZL2c3NVYv?= =?utf-8?B?clNOR21YV1RjTURWY3BLenBNNlpJUE5Ba1RtcWJHQjcxL1B2UUpGVERaYjJE?= =?utf-8?B?czZENGlabUJ1dTVieDFBT1gxeHlwQnMxdEtESkZIcndnZ1pXOGxKWTQrSGZE?= =?utf-8?B?YWI5ME1MeVQ1TmFNQlZqNCtCaW1BUGlreUtXUFI5aVVzQm1kZU0rVnIvQjZS?= =?utf-8?B?a0piK05TODN6UFNTSG40bFlpaXVyTGgzZVdkMGpmMVJOcWNTbldJTFFOVnQ4?= =?utf-8?B?SmNIaUdtcG40V0FLd1NYRWloemlPWFhIT1JuTHoxVUYwOFprelJRTnRQdW1z?= =?utf-8?Q?1bLjRF054jf+CZgvqhAz9QNE8?= Content-Type: text/plain; charset="utf-8" Content-ID: <64927878DBF4F144BE99D009A6CE5CAB@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: nYhr3CNe271eL3am7aGnrV50EspZJ1KDW+i9S2VYWbb7d2mWG1Dd1RJ/cun0eU4uqesXgAbQM9UnvswYjOyXszrbWLfIt5PW8jamHt6nse5OTEhTR5Zbjuf9o7SC3fobyH6u6RRT0bJD0tdXsZNNnRK/GH5YbVMSUAtBLtId1dFLaqnU7OcGzJbQNmTsKONXg0T5qUxh2sAPxJdQ07dbcDh+4FqRsREd4MsHMtccw3rxtj/IvtGPsgZ/6cCFh6opA3H47C9CuYx+V1++7e6rIyZPmZdnJ0DA+JfoiDFyTSAJlXZp5tIJrTOw5CbFON012517ECY/+ugHY5TjT7S5NEe2yn7ytpzW2NFUPzGypn3vV2IcSUOBJNVFcy1W+JyT1QoMJKBSkw+BQBhiNkKcGXbpALhXKBdGedm122Ho9QhXLjzQlnc0SmURpNgTg7Ep2alFpE2fVc4glB6BO2yLBAfmyH2MiCRzQxED47o+slR2RisZKeb6IA6zeQ/iq8neAE7TT++HyubcyhYTt92AVaNXCwr/2RqypJT9wvyCyYor8F0DBUw88ujYcyeCP06+AItKLbUTVL6elaojK9jPZaDWLzXHDsPd5rBdRWHyEuLXtOMYCvTV3G6/r4uTvThIoD//P8GwXMHAsKfSt+OxwlR7RgapzjFxIn1UbPyUMbYy8CSuT/vd44CtB5eiDOEdZ4FKjYSepbVcwelsxewzPiwdgcvxvI2w9nNh9m0z6/znK1bZap1PeYOe1zvkMKFIAwVdh6sz/UB6QyVW+gwimSCblEEyCgJm6JddWZvKyJhx+9npPmTIZIgUk0ADI4x2 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be514375-36d4-4a26-6631-08dace260c6a X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2022 14:13:23.8412 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UpA6DetIiRCM5VcAXTptxSBou359UjfRoCZkAsdKajt3iDcjq9aRQRAPrCi5JXyL3OWOhO9Zq3l+9HWLSjqgQnfb8EGc58wepLePWk6RB/s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5796 T24gMjQvMTEvMjAyMiAxNDowMywgRWR3aW4gVG9yb2sgd3JvdGU6DQo+DQo+PiBPbiAyNCBOb3Yg MjAyMiwgYXQgMTM6NDMsIEFuZHJldyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+ IHdyb3RlOg0KPj4NCj4+IE9uIDI0LzExLzIwMjIgMDk6MDMsIEVkd2luIFRvcm9rIHdyb3RlOg0K Pj4+PiBPbiAyMyBOb3YgMjAyMiwgYXQgMjI6MjUsIEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29w ZXIzQGNpdHJpeC5jb20+IHdyb3RlOg0KPj4+Pg0KPj4+PiBUaGUgYmluZGluZyBmb3IgeGNfaW50 ZXJmYWNlX2Nsb3NlKCkgZnJlZSB0aGUgdW5kZXJseWluZyBoYW5kbGUgd2hpbGUgbGVhdmluZw0K Pj4+PiB0aGUgT2NhbWwgb2JqZWN0IHN0aWxsIGluIHNjb3BlIGFuZCB1c2FibGUuICBUaGlzIHdv dWxkIG1ha2UgaXQgZWFzeSB0byBzdWZmZXINCj4+Pj4gYSB1c2UtYWZ0ZXItZnJlZSwgaWYgaXQg d2VyZW4ndCBmb3IgdGhlIGZhY3QgdGhhdCB0aGUgdHlwaWNhbCB1c2FnZSBpcyBhcyBhDQo+Pj4+ IHNpbmdsZXRvbiB0aGF0IGxpdmVzIGZvciB0aGUgbGlmZXRpbWUgb2YgdGhlIHByb2dyYW0uDQo+ Pj4+DQo+Pj4+IE9jYW1sIDUgbm8gbG9uZ2VyIHBlcm1pdHMgc3RvcmluZyBhIG5ha2VkIEMgcG9p bnRlciBpbiBhbiBPY2FtbCB2YWx1ZS4NCj4+Pj4NCj4+Pj4gVGhlcmVmb3JlLCB1c2UgYSBDdXN0 b20gYmxvY2suICBUaGlzIGFsbG93cyB1cyB0byB1c2UgdGhlIGZpbmFsaXNlciBjYWxsYmFjaw0K Pj4+PiB0byBjYWxsIHhjX2ludGVyZmFjZV9jbG9zZSgpLCBpZiB0aGUgT2NhbWwgb2JqZWN0IGdv ZXMgb3V0IG9mIHNjb3BlLg0KPj4+Pg0KPj4+PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVy IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPj4+PiAtLS0NCj4+Pj4gQ0M6IENocmlzdGlh biBMaW5kaWcgPGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4NCj4+Pj4gQ0M6IERhdmlkIFNj b3R0IDxkYXZlQHJlY29pbC5vcmc+DQo+Pj4+IENDOiBFZHdpbiBUb3JvayA8ZWR2aW4udG9yb2tA Y2l0cml4LmNvbT4NCj4+Pj4gQ0M6IFJvYiBIb2VzIDxSb2IuSG9lc0BjaXRyaXguY29tPg0KPj4+ Pg0KPj4+PiBJJ3ZlIGNvbmZpcm1lZCB0aGF0IFhlbmN0cmwuY2xvc2VfaGFuZGxlIGRvZXMgY2F1 c2UgdGhlIGZpbmFsaXNlciB0byBiZQ0KPj4+PiBjYWxsZWQsIHNpbXBseSBieSBkcm9wcGluZyB0 aGUgaGFuZGxlIHJlZmVyZW5jZS4NCj4+PiBUaGFua3MsIGEgZ29vZCB3YXkgdG8gdGVzdCB0aGlz IGlzIHdpdGggT0NBTUxSVU5QQVJBTT1jLCBwb3NzaWJsZSB1bmRlciB2YWxncmluZCwgd2hpY2gg Y2F1c2VzIGFsbCBmaW5hbGlzZXJzIHRvIGJlIGNhbGxlZCBvbiBleGl0DQo+Pj4gKG5vcm1hbGx5 IHRoZXkgYXJlIG5vdCBiZWNhdXNlIHRoZSBwcm9ncmFtIGlzIGV4aXRpbmcgYW55d2F5KQ0KPj4g SSBkbyB0aGF0IGFueXdheSwgYnV0IGl0J3Mgbm90IHJlbGV2YW50IGhlcmUuDQo+Pg0KPj4gV2hh dCBtYXR0ZXJzIGlzIGNoZWNraW5nIHRoYXQgY2FsbGluZyBjbG9zZV9oYW5kbGUgcmVsZWFzZXMg dGhlIG9iamVjdA0KPj4gKGFsYmVpdCB3aXRoIGEgZm9yY2VkIEdDIHN3ZWVwKSBiZWZvcmUgdGhl IHByb2dyYW0gZW5kcy4NCj4+DQo+Pj4+IGRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hj L3hlbmN0cmxfc3R1YnMuYyBiL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybF9zdHVicy5jDQo+ Pj4+IGluZGV4IGYzNzg0OGFlMGJiMy4uNGUxMjA0MDg1NDIyIDEwMDY0NA0KPj4+PiAtLS0gYS90 b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYw0KPj4+PiArKysgYi90b29scy9vY2Ft bC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYw0KPj4+PiBAQCAtMzcsMTMgKzM3LDI4IEBADQo+Pj4+ DQo+Pj4+ICNpbmNsdWRlICJtbWFwX3N0dWJzLmgiDQo+Pj4+DQo+Pj4+IC0jZGVmaW5lIF9IKF9f aCkgKCh4Y19pbnRlcmZhY2UgKikoX19oKSkNCj4+Pj4gKyNkZWZpbmUgX0goX19oKSAoKigoeGNf aW50ZXJmYWNlICoqKURhdGFfY3VzdG9tX3ZhbChfX2gpKSkNCj4+Pj4gI2RlZmluZSBfRChfX2Qp ICgodWludDMyX3QpSW50X3ZhbChfX2QpKQ0KPj4+IEkgdGhpbmsgdGhpcyByZXF1aXJlcyBhbiB1 cGRhdGUgaW4geGVub3BzZCB0b28gdG8gbWF0Y2gsIG90aGVyd2lzZSBpdCdsbCBjcmFzaDoNCj4+ PiBodHRwczovL2dpdGh1Yi5jb20veGFwaS1wcm9qZWN0L3hlbm9wc2QvYmxvYi9tYXN0ZXIvY19z dHVicy94ZW5jdHJsZXh0X3N0dWJzLmMjTDMyDQo+PiBVcmdoLiAgSSdsbCB0YWtlIGEgbm90ZSB0 byBkbyB0aGF0IHdoZW4gYnJpbmdpbmcgaW4gdGhlIGNoYW5nZS4NCj4+DQo+Pj4gVGhpcyB3YXNu J3QgYW4gaXNzdWUgd2l0aCB0aGUgb3JpZ2luYWwgcGF0Y2ggd2hpY2ggdXNlZCBEYXRhX2Fic3Ry YWN0X3ZhbCBoZXJlLCBiZWNhdXNlDQo+Pj4gdGhhdCAoY3VycmVudGx5KSBoYXBwZW5zIHRvIGJv aWwgZG93biB0byBqdXN0IGEgY2FzdCAod2l0aCBzb21lIEdDIG1ldGFkYXRhICpiZWZvcmUqIGl0 KSwNCj4+PiBzbyB0aGUgb2xkIHdheSBvZiBqdXN0IGNhc3RpbmcgT0NhbWwgdmFsdWUgdG8gQyBw b2ludGVyIHN0aWxsIHdvcmtlZC4NCj4+Pg0KPj4+IEhvd2V2ZXIgRGF0YV9jdXN0b21fdmFsIGJv aWxzIGRvd24gdG8gYWNjZXNzaW5nIGEgdmFsdWUgYXQgK3NpemVvZih2YWx1ZSkgb2Zmc2V0LA0K Pj4+IHNvIHhlbm9wc2Qgd291bGQgbm93IHJlYWQgdGhlIHdyb25nIHBvaW50ZXIuDQo+Pj4gUGVy aGFwcyBpdCB3b3VsZCd2ZSBiZWVuIGJldHRlciB0byBoYXZlIHRoaXMgX0ggZGVmaW5lZCBpbiBz b21lIGhlYWRlciwgb3RoZXJ3aXNlIGV4dGVuZGluZyBYZW5jdHJsIHRoZSB3YXkgeGVub3BzZCBk b2VzIGl0IGlzIHF1aXRlIGJyaXR0bGUuDQo+PiBFeHBvcnRpbmcgX0ggd29uJ3QgaGVscCBiZWNh dXNlIGV2ZXJ5dGhpbmcgaXMgc3RhdGljYWxseSBidWlsdC4gDQo+DQo+IEFzIGxvbmcgYXMgeW91 IGRvbid0IHJlYnVpbHQgeGVub3BzZCB5b3Ugd2lsbCBrZWVwIHVzaW5nIHRoZSBvbGQgQyBzdHVi cyB0aGF0IHhlbm9wc2QgZ290IGNvbXBpbGVkIHdpdGgsIHRoZSBjaGFuZ2UgaW4gWGVuIHdpbGwg aGF2ZSBubyBlZmZlY3QgdW50aWwgeGVub3BzZCBpcyByZWNvbXBpbGVkLA0KPiBhdCB3aGljaCBw b2ludCBpdCBjb3VsZCBwaWNrIHVwIHRoZSBuZXcgX0ggaWYgYXZhaWxhYmxlLCBidXQgSSBhZ3Jl ZSB3aXRoIHlvdXIgcG9pbnQgYmVsb3cuDQo+DQo+DQo+PiBJdCdzDQo+PiBicml0dGxlIGJlY2F1 c2UgeGVub3BzZCBoYXMgZ290IGEgbG9jYWwgcGllY2Ugb2YgQyBwbGF5aW5nIGFyb3VuZCB3aXRo DQo+PiB0aGUgaW50ZXJuYWxzIG9mIHNvbWVvbmUgZWxzZSdzIGxpYnJhcnkuICBUaGlzIHZpb2xh dGVzIG1vcmUgcnVsZXMgdGhhbg0KPj4gSSBjYXJlIHRvIGxpc3QuDQo+Pg0KPj4gV2UgKFhlblNl cnZlcikgc2hvdWxkIGRlZmluaXRlbHkgd29yayB0byBpbXByb3ZlIHRoaW5ncywgYnV0IHRoaXMg aXMNCj4+IGVudGlyZWx5IGEgeGVub3BzZCBwcm9ibGVtLCBub3QgYW4gdXBzdHJlYW0gWGVuIHBy b2JsZW0uDQo+DQo+IEl0IGlzIGEgbG90IGVhc2llciB0byBhZGQgbmV3IHhlbmN0cmwgYmluZGlu Z3MgYW5kIHRlc3QgdGhlbSBvdXQgaW4geGVub3BzZCB0aGFuIGl0IGlzIHRvIGFkZCB0aGVtIHRv IFhlbi4NCj4gV2Ugc2hvdWxkIHRyeSB0byBlaXRoZXIgdXBzdHJlYW0gYWxsIHhlbm9wc2QgeGVu Y3RybCBiaW5kaW5ncyB0byBYZW4sIGFuZCBtYWtlIGl0IGVhc2llciB0byBhZGQgdGhlbSB0byBY ZW4gZ29pbmcgZm9yd2FyZDsNCj4gb3IgbW92ZSBhbGwgdGhlIFhlbmN0cmwgYmluZGluZ3MgdG8g eGVub3BzZCwgdGhlbiBhdCBsZWFzdCB5b3Ugb25seSBuZWVkIHRvIHJlYnVpbGQgdGhlIG9uZSBw aWVjZSB5b3UgYXJlIGNoYW5naW5nLg0KPg0KPiBCdXQgdG8gZG8gdGhlIGxhdHRlciB3ZSBmaXJz dCBuZWVkIHRvIGdldCBldmVyeXRoaW5nIHRoYXQgcmVsaWVzIG9uIHhlbmN0cmwgdG8gbW92ZSB0 byBtb3JlIHN0YWJsZSBpbnRlcmZhY2VzIChpbmNsdWRpbmcgb3hlbnN0b3JlZCkuDQo+IFRoZXJl IGFyZSBzb21lIE1pcmFnZSBsaWJyYXJpZXMgYXMgd2VsbCB0aGF0IHVzZSB4ZW5jdHJsLCB3aGVu IGEgbW9yZSBzdWl0YWJsZSBzdGFibGUgaW50ZXJmYWNlIGV4aXN0cyBpbiBuZXdlciB2ZXJzaW9u cyBvZiBYZW4gdGhhdCB0aGV5IHNob3VsZCB1c2UgaW5zdGVhZC4NCj4NCj4gUGVyaGFwcyBhIGNv bXByb21pc2UgYmV0d2VlbiB0aGUgMiBleHRyZW1lcyB3b3VsZCBiZSBmb3IgeGVub3BzZCB0byBv cGVuIGFuZCBoYXZlIGl0cyBvd24geGVuY3RybCBoYW5kbGUsIGV2ZW4gaWYgdGhhdCBsZWFkcyB0 byBzb21lIGNvZGUgZHVwbGljYXRpb24sIGl0IHdvdWxkIGF0IGxlYXN0IG5vdCByZWx5IG9uIGFu IHVuZG9jdW1lbnRlZCBhbmQgdW5zdGFibGUgaW50ZXJuYWwgZGV0YWlsIG9mIGFuIGFscmVhZHkg dW5zdGFibGUgQUJJLiBBbmQgdGhhdCB3b3VsZCBzdGlsbCBhbGxvdyB4ZW5vcHNkIHRvIGV4dGVu ZCB4ZW5jdHJsIHdpdGggYmluZGluZ3MgdGhhdCBhcmUgbm90ICh5ZXQpIHByZXNlbnQgaW4gWGVu Lg0KPiBXaGF0IGRvIHlvdSB0aGluaz8NCg0KTWFueSBvZiB0aGVzZSBwcm9ibGVtcyB3aWxsIGRp c2FwcGVhciB3aXRoIGEgc3RhYmxlIHRvb2xzIGludGVyZmFjZS7CoA0KQnV0IHllcywgaW4gdGhl IHNob3J0IHRlcm0sIHhjZXh0IG9wZW5pbmcgaXRzIG93biBoYW5kbGUgd291bGQNCmRlZmluaXRl bHkgaW1wcm92ZSB0aGluZ3MgYnkga2VlcGluZyB0aGUgdHdvIHNldHMgb2YgYmluZGluZ3Mgc2Vw YXJhdGUuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Thu Nov 24 14:23:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 14:23:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447964.704648 (Exim 4.92) (envelope-from ) id 1oyD8i-0000eP-Ge; Thu, 24 Nov 2022 14:23:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447964.704648; Thu, 24 Nov 2022 14:23:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyD8i-0000eI-Cj; Thu, 24 Nov 2022 14:23:44 +0000 Received: by outflank-mailman (input) for mailman id 447964; Thu, 24 Nov 2022 14:23:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyD8g-0000eC-Hf for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 14:23:42 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9738deb6-6c03-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 15:23:41 +0100 (CET) Received: from mail-mw2nam10lp2100.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Nov 2022 09:23:38 -0500 Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by CO1PR03MB5921.namprd03.prod.outlook.com (2603:10b6:303:96::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Thu, 24 Nov 2022 14:23:36 +0000 Received: from DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22]) by DM6PR03MB4172.namprd03.prod.outlook.com ([fe80::bca9:6c1e:de4c:fa22%5]) with mapi id 15.20.5834.015; Thu, 24 Nov 2022 14:23:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9738deb6-6c03-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669299820; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=MLitRt+OuYVvU+Z7wTGEFQj1aYGeuFAmjUJxA23086w=; b=Ig2uGTW0l2SokY3M7eTouC2uYexiQZcSzmUJGcD7n0zR/kSKkOSV4UIh NiQon8OfYSFPZEbqkpy3QaLYnHpy/KYs7joOaJtKOoTdTNym6ZsBEO5m7 Uvt0gNoIEhx1SWfuijs2GSzWJx+JypHKzPxAJ7Aar06e6THd63fyUOggl s=; X-IronPort-RemoteIP: 104.47.55.100 X-IronPort-MID: 85919966 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:tBX7Gqki8XmNwpmaUQ225fHo5gyfJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIfUDqAPamDM2ukeIonOoq0o0kE78LdmtdnHAI4rCtgRCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5gOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 aMbN29XXDKRvOX1+pzgdMZstOFyMvC+aevzulk4pd3YJdAPZMmbBoD1v5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3ieC1WDbWUoXiqcF9lUaCp 3na/m3/RBUbMtCexhKO8262h/+JliT+MG4XPO3lp6c70QPNroAVIDwdZVjrmueCsW+jed9/F WI62QUs9bdnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQm3 0GEt8nkDjtutPuSU331y1uPhTa7OCxQKHBYYyYBFFMB+4O6+Nl1iQ/TRNF+FqLzlsfyBTz73 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxl8RiFKND2Bw1WXm0A== IronPort-HdrOrdr: A9a23:m3m406m+2fqVr995BXutPu9yPPzpDfMEiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJLqDhSC2R8acjVXhZMv63 LMnQDV7riq96jT8G6c60bjq7Bt3PfxwNpKA8KBzuATNzXXkw6tIKhxRrGYuzgxgee3rHInis PFrRsMN9l6r1nRYma2ix3w3BSI6kdh11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza NixQuixtlqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bWDHAcEcYa xT5fPnlbFrmGChHjbkV65UsYWRt0EIb1O7q445y5SoOnZt7StEJgAjtbEidz87he4Aot9/lq T52+1T5c9zZ95TYqRnCOgbR8yrTmTLXBLXKWqXZU/qDacdJhv22tfKCCVc3pDURHUk9upEpH 36aiIviUciP0b1TcGe1pxC9R7ABG27QDT208lbo5x0oKf1SrbnOTCKDAlGqbrqn9wPRsnAH/ qjMpNfBPHuaWPoBIZSxgX7H51fM2MXXsEZsssyH1iOvsXIIIv3sfGzSoeaGJP9VTI/Hm/vCH oKWzb+YM1G80CwQ3f9xAPcXnv8E3aPia6Y0JKqitT75LJ9RbGk6DJl+GhRzvv7WQFqo+gxYF Z0Jq/hn+eyuXS2lFy4nVlUBg== X-IronPort-AV: E=Sophos;i="5.96,190,1665460800"; d="scan'208";a="85919966" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jxLd5Pea8YYJHmZBh3OAeag9hqgSSY/alxnYaz5JslQ3iZFr2SAaCkjV5+HnmNSxY361vqkuE7JOsjWS0W07g1fxCIbqy0B/qopqSR+ItKKk9d8FVTdPIxOaBVTZoIgkPJjOzVQWq8ceWSsWzp4pmjj+CU1NFBL6t34iNJvJvLbYi8lKFQc2QAUHA6C8ILFu+93oybU9KgsMnraQU2LyBx9hPrcE96lzZSfzeRH67j35zYyp7z1InFBorYEJfLC35nv/W8I7J9DqaNuDkOmN157yfrznJ7+1gL16b2qXN0O2/4THQNpZYmYFXojuVsD4A6Pa5umtlQ5Ufh4/h9K6lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MLitRt+OuYVvU+Z7wTGEFQj1aYGeuFAmjUJxA23086w=; b=hwKOYYgeHCYLdmUbGzD/T5NfsE2wFWbcsMg84peK0OIKmQAP7UIsDWFOS/PgObkMCcadisE/gbMp8VEQYYQu234i0to76feWNI5aJKz7PTwg8oBD3aEwg5jU0lGr6NoMReAuAzy+vRmiHXqim652cEAUcq5pb9jDfzt50Lsz+6VaD7j/FYlTG4VaM+8eauJ7LxE8CJhTFvcXWsRZL0BZdl2CUDmCS0EbJB7/zty7UK/WottMdiEzB1yHIs+j5aoHuLinL1BvOQypDVcfxaCB+R52jD0z4fEKyt52Os2vZCD1oPconnV3bBV01gfYzb8bGZN7HZTA+9PXMpQtxiYVjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MLitRt+OuYVvU+Z7wTGEFQj1aYGeuFAmjUJxA23086w=; b=WlclwvtIRagBbfdAGVLB7KInVjHebLgXIECjHUgEC7x+5UhsQAW4e5PcNZBFs3IENG4zX6RgMcTDVNPElEw4tRI1LZ7MBkSbWOcgMkUBVzYvvJwe+TnL1DB88G3cO/wgMYTzuxC2F156qUNVgXGayby7SjCW14EtZ3U89OiXOgo= From: Christian Lindig To: Andrew Cooper CC: Edwin Torok , Xen-devel , David Scott , Rob Hoes Subject: Re: [PATCH] tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free Thread-Topic: [PATCH] tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free Thread-Index: AQHY/4p+D/wPMbQAQkGOEHU/y0ZpLq5NyDSAgABOF4CAAAXGgIAAAqyAgAAC2oA= Date: Thu, 24 Nov 2022 14:23:36 +0000 Message-ID: <212D2A4B-9921-4072-8A1A-FCB111251E49@citrix.com> References: <20221123222517.12140-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|CO1PR03MB5921:EE_ x-ms-office365-filtering-correlation-id: e3a590b8-cb62-4fdf-4b15-08dace2779ad x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qfjBNWF6leipdqHYKdmluurDJzvBvA7Bjc02DHIO/b0qeyeGBHv2Ytt7aoSEwZyg2BZTQIXW9LLxlxH+5Ekq6iwu9XieHNwPkmyEYjtG3jC9jU76Ht9VBlNHXBxexIkvYEDuT8vnjcE9f4XjF4tIDImJ2DgiYAnONhrX1EX2R0Qd4gZBSrOZlGxOklRvLRslFN61tEV/g+hMLYiCl9ymyW5XZrqtq66iTHPQx8u3IYCIGUrVBvgVGm5S3FMMUTssTrLGFU5NlAt8X7zrXRp31E70/cORvZgh4OEOdpSTssWKEQnA39fGHnNRRWh0SkufbAnt91hO9GyxCMJh4qhzSph2nQM0i2PkDMZlGMHtqaN3fokxV2c31wb6Xgdxp/h+49ajO0zPAc9009WN5JxFT7WxuLnx86RgnShkf3LBWZ3plKHadHgWamtxYyglXxIXcsXavnM1be+m3Ie3IxeIonjMLxbCMNCUEaXqN1TYwvcf/R4qp7cdrYYqcv9OMeBLX97S5Ox5N1qm8uirIsIgKb5F0O4kCAO3Y4YghlBsJoo4czO8lbB+Fn63YUqJHXRJioQwyt4lcuhI6duryOAwqvGw03LuL/z/zq6L9n/wqq5hWE+iflbMlzuWjaMctJLRB4c+ucR7JS/HSc8m2zveYhRjv81Hqo/Cg+eMObiUYTiwwZAbUa5grzSkf4CoakF6+Bwf+RSfizh1YGk5jqQrqena1Jf2/O5hoNgt6YegCyE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199015)(36756003)(2616005)(41300700001)(5660300002)(2906002)(6862004)(44832011)(8936002)(186003)(38100700002)(33656002)(86362001)(122000001)(38070700005)(82960400001)(53546011)(6506007)(6512007)(26005)(6636002)(37006003)(6486002)(316002)(107886003)(54906003)(71200400001)(91956017)(4326008)(64756008)(66446008)(478600001)(66556008)(66476007)(76116006)(66946007)(8676002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QnhLZUh1MUNKTmJ4MW40RjUwY3dIWi93azFMRzdmQmFrU2lxSThneUxMMGlO?= =?utf-8?B?N0hTOVQreUZ2dlVuZ1ZiVzVWdnhScFllTEhETlQrVmkzRm9YeXJGaStYNGdP?= =?utf-8?B?dFpjTXh1aDRoSWc1RXJiR0ZOMkltc1pzYXNaaFdyMlpVV0h6aEdFTUNaWDg0?= =?utf-8?B?MEdTRko4RUwvbzMzeGd3cHRGUUJ0SGpvdmxBQmRUc1NlekRCcnJrN05VZTZt?= =?utf-8?B?MldkWDc2T3ErM1BsVUdNWGxXVU9PVU1TRFcvTSt1bXhUS1lXZnoraVdDOURs?= =?utf-8?B?c091VlF0dWxHR2V4eHZyK3VoMlJncXBWMGF6SnhzbEJ3ejB0NmgvTVRjY3hZ?= =?utf-8?B?UTBMTDVPOXlhYUVtR2FuQ0JIbFMyN2YxZ0hHVkJRVHpkcnlUQUdLYWVWMUM2?= =?utf-8?B?TkQ3Z2dXNGVpYjdhRDRvSjRBdkpzbDdZTGs2RHI1ajkzTlJZRDkzYnl4QW9p?= =?utf-8?B?QVZ0L2l1OTVOQmVEUENpR01DSDUvTEZrQTFDWGRRZTE2eFVNbFVhNEsyWDJJ?= =?utf-8?B?RFFoc3dmUlI2bUZpU1JwWUxEdWNKRytISGxkOUpiV3JRbnJaVlgrWmx0MWNn?= =?utf-8?B?MWQ5TnhsL2tXNFVpZFZpOERhd0lCZ0dQaUdId2FjYmVWd0Z3clZZbHlaRG1J?= =?utf-8?B?LzlxMFBQVlQrUzdHdGh4Zkdrb3lNcFQ5dU9CcmZJdlhEV0JMeXM5SENhdnZK?= =?utf-8?B?NnNnSHdsaU9SeFRiTnpETlVET1k3OHJHdlJvV2crYWpmSkJqQUl6YzYxSS9W?= =?utf-8?B?NjdBVlF0NitsY0I5dFJCVWRpa2JlRDJJTWFaaVFubmdkb3lmZ2ZzVkxxa2tj?= =?utf-8?B?RWV2elp1Vk1td1lTaHE5Y1dzNTJjNk55bGVDQkQvcjBSVXZZSmcyeG1tNHVn?= =?utf-8?B?YmlaelF1aHBjeHJFUU93My9tQmVQbVhSdDhNNDVKSUpDVE9reTM1bGhaNlNS?= =?utf-8?B?NE92ZTh0RjRFOVBmMzlzZ0FNOVZuWDVvUDBnc1NaL1QyU0FNa05odUhrNk1T?= =?utf-8?B?VkRUaTZmbDlMQ3NEcGJXZlVnU0RFaVpwNGV3eGtBbGs3UUVVR0NJWTNSQ1RG?= =?utf-8?B?ZXNaUkErRjQrODBGdjQxTDFYK2xYKy9nMjRCb3ArQkpnRTBMc0ZleWtyT1k3?= =?utf-8?B?cy91VTd4OVpsTVpuUmZnQUJ2SWFzTEJ4VWtHRkk1TTNsT21BQjdwVHp0Y3hv?= =?utf-8?B?OWNDemxTemJrQjlYQTdMaHJtUGFyVkdJcW9OZFhLZUJvNEF3UFFqVlVnMXF0?= =?utf-8?B?UmlvYW9od1pXTzV3Z2NuaVRSRUFhTEpwOEZpUWZSckowMkpXaHRabGcwQjRQ?= =?utf-8?B?a21DUnRoaTFIVnNtTUZBYjN0bFlZL2xzVUJVd0RaaFEwaFdFVlhSMGJ1RXR1?= =?utf-8?B?N0lPVS9HamxlVUpIQUtHUFBkTElZN2ZmUkVzMEtNaVhZRFlzbVBINDhIMlQw?= =?utf-8?B?bEFSNTYrdFVYeFRSNzdna1hBa2Y2UyswWHdJa1dibmF1aHJET09oWWdiN29t?= =?utf-8?B?Rk14SmFEbXg4QVNaUzNFSGVNbnFKUUdmV1ZSZDRsYVl4NFhDdCt5WTlPNXgy?= =?utf-8?B?YlFYcmJBeHZWSVI1aEVPc1lIOTNHaTJoanZDdFBuTWJncm1pT2Y0Q0UzZ1ZP?= =?utf-8?B?TVNtTHB1ajYzd3V0R0t4aUM1RWEyYzNyM0cyVkhsOUhYWkV2UDFIOS92bGxX?= =?utf-8?B?dnd0azJpd1BYbmRQcVN4RTFPZFMySDd1dVRxekZrUHhLNnJPQlBSUFp1dHFl?= =?utf-8?B?aWRNcUIvaHdTejk0S1FrRkN1YVpZMmxjVHgweUpKcTBYRlEzYytFcWpGZS9R?= =?utf-8?B?aVRpb05NVDl4Wk9BVFhvY0hwOFRhSTNkY2tOSXc5WFNBdDVvZk0zb1NaRWhW?= =?utf-8?B?cTluWXFTY3F2Nms5NWxJWkhJMDN2RitFMXRpcG1iMWhjYUtUSHdPSXNXbmgy?= =?utf-8?B?ZE1DWEJQTFhSaUEveTA4YnI5Y1ZnQ0Yya3pXWUV3NzRPSUkwVldoLzB2aGNW?= =?utf-8?B?bVNGaFBuUlplUEhIYW1BU1ZWbVhkYzdJRHpSMlJBVXJYVjhlTWhZWHNkbmZH?= =?utf-8?B?VFNKcG5LYi83OW5PdXF1VXUzcWdaTEVmMDBIMllwU2ZSQlgyNEorL3JHTDBI?= =?utf-8?B?anJ1VW9UM2xCSHhXRkhjazFEemNOd1JoTTcrZTdaR2kvYmtjTGltOW5qLzVp?= =?utf-8?Q?qE9syFjVnqK48Cmrn7Q63Z4=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <36ADA589759F0B4397A58C3995A6F497@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TKEwl1gRqkxX1e+zi1G3MMTBofRWnZIeErIeuxflImX2LYRjX3cLY75ykcUoM6KrnuXa1PwgII4vvdk/SIfxxhfq0b1fEiY1M72Tcinsx788S0uW/kFSGQaAdQiobZfs0QsMDdJhXDBCRmtzcPGthqi3ucA6VREO4eLwzzR/gFKvgX/zCaUR5bIj8MZ88UpaUqkusXJCEJylonS+d4HjZc780vKk17x94qt1lyNGmKeRocaBhOnD2U+BjA/l2N929ANWa8cI4RkQ0AYjLYzgYmnYdbahRCMOQygGHyyz5JGQ0+7HAKFnAv1V8yND4QGzz1iWI+3SBacZ/SiJ7FAhTr387GlStQVaGZZM62MLm+rsEHoskrg5qI2LYVHV+YdymP8Q7rqmfwrNISBdmWInupjGolK8m2W2EOfr9T0q6tyjO3JIaQinNlhD1G/iEby0Rd6grhyohdC9PC0d9tasLzs4ooiDZWCGIPnURN/HnzseyzjI0uiW+i2eOhmCiJ+PUvpKPbm3b3zw9gbqRdmfxBSWcj7/ZoU0Gs+8cgLUwUW1WoaQsRQW0hpP9UV7V3VySwzmg2Bkgktj8QMqrMaeepXZI9TdK/qegD/kTe5DLXPFrXVRAp9pkjxRD9p2jSxKWqXoPoa3lCsRzNSVeDyOVYlTOpPs675upovaWA3pqyja8laa3z8oDhPaDhaShuFoQOCbktZJ2pEANRIpv0yWMbFzFQu42+EqRaQ1pBEPiP78EwLFC/GZzZmlMcEcQLFcHIv+gcX3tIXFjzAQRhBTcudZpB7pckwEuY90uo32nEGRxOTakR/kohmQM4KMjh7b X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3a590b8-cb62-4fdf-4b15-08dace2779ad X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2022 14:23:36.6324 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: K0VkZ0yWFIXTt1gvVSDsAMafiaVNxFo2BJq1yG2S5sIcsQnhMlq9yzFeC9EYA9tUK+FCunzSf7Fwj1y5JCktqyPfbyKc58nsv4RWuc67z+A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5921 DQoNCj4gT24gMjQgTm92IDIwMjIsIGF0IDE0OjEzLCBBbmRyZXcgQ29vcGVyIDxBbmRyZXcuQ29v cGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IE9uIDI0LzExLzIwMjIgMTQ6MDMsIEVkd2lu IFRvcm9rIHdyb3RlOg0KPj4gDQo+Pj4gT24gMjQgTm92IDIwMjIsIGF0IDEzOjQzLCBBbmRyZXcg Q29vcGVyIDxBbmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4+PiANCj4+PiBPbiAy NC8xMS8yMDIyIDA5OjAzLCBFZHdpbiBUb3JvayB3cm90ZToNCj4+IFBlcmhhcHMgYSBjb21wcm9t aXNlIGJldHdlZW4gdGhlIDIgZXh0cmVtZXMgd291bGQgYmUgZm9yIHhlbm9wc2QgdG8gb3BlbiBh bmQgaGF2ZSBpdHMgb3duIHhlbmN0cmwgaGFuZGxlLCBldmVuIGlmIHRoYXQgbGVhZHMgdG8gc29t ZSBjb2RlIGR1cGxpY2F0aW9uLCBpdCB3b3VsZCBhdCBsZWFzdCBub3QgcmVseSBvbiBhbiB1bmRv Y3VtZW50ZWQgYW5kIHVuc3RhYmxlIGludGVybmFsIGRldGFpbCBvZiBhbiBhbHJlYWR5IHVuc3Rh YmxlIEFCSS4gQW5kIHRoYXQgd291bGQgc3RpbGwgYWxsb3cgeGVub3BzZCB0byBleHRlbmQgeGVu Y3RybCB3aXRoIGJpbmRpbmdzIHRoYXQgYXJlIG5vdCAoeWV0KSBwcmVzZW50IGluIFhlbi4NCj4+ IFdoYXQgZG8geW91IHRoaW5rPw0KPiANCj4gTWFueSBvZiB0aGVzZSBwcm9ibGVtcyB3aWxsIGRp c2FwcGVhciB3aXRoIGEgc3RhYmxlIHRvb2xzIGludGVyZmFjZS4gDQo+IEJ1dCB5ZXMsIGluIHRo ZSBzaG9ydCB0ZXJtLCB4Y2V4dCBvcGVuaW5nIGl0cyBvd24gaGFuZGxlIHdvdWxkDQo+IGRlZmlu aXRlbHkgaW1wcm92ZSB0aGluZ3MgYnkga2VlcGluZyB0aGUgdHdvIHNldHMgb2YgYmluZGluZ3Mg c2VwYXJhdGUuDQo+IA0KPiB+QW5kcmV3DQoNCkFja2VkLWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxj aHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+DQoNCkkgYWdyZWUgd2l0aCB0aGlzIGFwcHJvYWNo LiBXZSB3YW50IHRvIGtlZXAgdGhlIGZyaWN0aW9uIGxvdyBidXQgbm90IGhhdmluZyB0byBjb29y ZGluYXRlIHJlbGVhc2VzIGFuZCByZS1jb21waWxhdGlvbi4gQ2hhbmdlcyBpbiB4ZW5vcHNkIGFy ZSBwdWJsaWMgZm9yIGFueW9uZSBjdXJpb3VzIGFuZCBjb3VsZCBiZSB1cHN0cmVhbWVkIHRvIFhl biBsYXRlci4NCg0K4oCUIEMNCg0KQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlh bi5saW5kaWdAY2l0cml4LmNvbT4NCg0K From xen-devel-bounces@lists.xenproject.org Thu Nov 24 15:01:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 15:01:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447969.704658 (Exim 4.92) (envelope-from ) id 1oyDix-0005gE-8m; Thu, 24 Nov 2022 15:01:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447969.704658; Thu, 24 Nov 2022 15:01:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyDix-0005g7-68; Thu, 24 Nov 2022 15:01:11 +0000 Received: by outflank-mailman (input) for mailman id 447969; Thu, 24 Nov 2022 15:01:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyDiv-0005g1-6g for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 15:01:09 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf1900c9-6c08-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 16:01:02 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 89A605C0232; Thu, 24 Nov 2022 10:01:00 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 24 Nov 2022 10:01:00 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Nov 2022 10:00:58 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf1900c9-6c08-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1669302060; x= 1669388460; bh=7oFqqbC1mKV4rv+CQpx7kr5MCr1+PtHfYRd8xId+10c=; b=M KdBJGO4dKzdj9b6tw3P/phwtQGqwUSUh1SGMiTxrs3xCfnqV+9QbwPcg4cxD4QkG pIz28lu4QwWB2IodUN7CoKPf/75JOVp4wOCDl1Fo1rs9sWD+6Lx9qCixWAlZHJZB sXh8c+mZjndWsFjLr5e0r8uEY1KMFOEFe9SLgWOsgwX5FtNOawOxWChixUQQKAR/ P2ezLoy94pIUJPLAbIMZ5d3I8VhvvfC0CZewwOmCQU8+ePFzI5UbYBQ/lAKhDrCJ LdNDbi5YAvNOr6GbDJM+tQ4D4tEv30JpoyYLI9PJaOuFqU5C1daZxNswoDfbITIK 3viFiF0EbqYDJzO9+bemw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1669302060; x=1669388460; bh=7oFqqbC1mKV4rv+CQpx7kr5MCr1+ PtHfYRd8xId+10c=; b=qdIdG/dU5awifJfxaHZQdHZT+3MOcuqLOG5PISZgOYgM JGa43fXtJdegHPAcKE0X5KYCg4S9vF758DsMtK6CWurQ5xiaFmqGsRoXllGw0jKD p7wusoGb15PZDUvvWY/UdVTrfZje7dbF2uS6cRtXfFOqURIffVpsoMXpl7n6w8Zh i+cT9GoEtabSaZ9vkEdZOJBH08tx9lPL6wTO8vbq5gMzCEAf2JSKdu2UQyBunBjV VeW9tcgYq3YyxT0U4PPDO1iXz0Ff8J+B4QUN9fKXhGp7Kt8Qu7JsGR69BYwk6wJc 6n3l42hRyzWtxxHIYTJetemoSr8GNiXwT+zwumE0RA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieefgdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefhffff iefhgffgvddtledukeelteeiiefggeeftdfgvefgiefgjeeljefgleeigfenucffohhmrg hinheptghithhrihigrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 24 Nov 2022 16:00:55 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Roger Pau =?utf-8?B?TW9ubsOp?= Cc: xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: Re: [PATCH 0/5] gfx: improvements when using multiboot2 and EFI + misc Message-ID: References: <20221123154525.63068-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XdDvxGq+k/7Zofml" Content-Disposition: inline In-Reply-To: --XdDvxGq+k/7Zofml Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 24 Nov 2022 16:00:55 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Roger Pau =?utf-8?B?TW9ubsOp?= Cc: xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: Re: [PATCH 0/5] gfx: improvements when using multiboot2 and EFI + misc On Thu, Nov 24, 2022 at 10:56:33AM +0100, Roger Pau Monn=C3=A9 wrote: > On Thu, Nov 24, 2022 at 09:59:25AM +0100, Roger Pau Monn=C3=A9 wrote: > > On Thu, Nov 24, 2022 at 06:15:15AM +0100, Marek Marczykowski-G=C3=B3rec= ki wrote: > > > But to get dom0 display image from BGRT, it seems something else is > > > needed too. Linux complains "Incorrect checksum in table [BGRT]". The > > > only relevant google result I get is this: https://support.citrix.com= /article/CTX460227/citrix-hypervisor-acpi-warning-incorrect-checksum-in-tab= le-bgrt > > > It blames firmware. But then, it's suspicious that it's also about Xe= n. > > > And also, native Linux on the same hw does not complain about the > > > checksum. So, I think it's rather Xen to blame... > > > The table lives in area marked as EfiACPIReclaimMemory in memory map,= so > > > I think it shouldn't be clobbered by Xen, at least in theory. I'll lo= ok > > > into it later. It's getting off-topic for this thread anyway. > >=20 > > See commit 89238ef7797023f318f82f4f9dddef59c435b8bd. I wonder whether > > the BGRT image region is marked as EFI_MEMORY_RUNTIME, I will have to > > check on my system. >=20 > Just checked on my system, and the BGRT image is placed in a > EfiBootServicesData section with no EFI_MEMORY_RUNTIME attribute. Right, while the BGRT table itself is in EfiACPIReclaimMemory, the image it points to lives in EfiBootServicesData. And no EFI_MEMORY_RUNTIME attribute there either. > To fix this we would need to change efi_arch_process_memory_map() so > it takes the BGRT image address into account and marks the region > where it's placed as reserved. I'm not aware of anyway to get such > address from EFI data, so we would likely need to parse the BGRT in > efi_arch_process_memory_map(). Since Xen has code to do that already, moving it earlier shouldn't be too much issue. Can `acpi_boot_table_init()` be called that early? And then, it sounds very similar to the issue we have with the ESRT table. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --XdDvxGq+k/7Zofml Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmN/hygACgkQ24/THMrX 1yw8/wf/UMfVnytzmYbSzL+35d+kawSByy5Icl7RU5ZkNek6HmUUBKOvaFKrRHg3 tHKYP0bDyLTuWuttQ4aSQTBgTCVCLRFH2GFjoGm7JsvdyyL+GsRiT0iGXojpwNxL +VzqawsMyJCPZ8T53BegLGb8OD0BYeswY0Afz3cyPVtWKI1SM8qWPHG5ykfrTX1G hf5b16sZWKmL/DNyv+o6ZwZL02eZnv3WGAmZ/jUVDFN3cD3qcOB+1QBXdNz+WQQz boxs3EKqlFe1j6AzDiQRFfO94XdTEc1GN9jmtq4VlADYm75bqnI74U95x1VnJrs/ HYXaOkYvmYS54WU3V0fPpDDZB+ApWg== =ls6y -----END PGP SIGNATURE----- --XdDvxGq+k/7Zofml-- From xen-devel-bounces@lists.xenproject.org Thu Nov 24 15:12:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 15:12:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447974.704670 (Exim 4.92) (envelope-from ) id 1oyDth-0007MZ-9G; Thu, 24 Nov 2022 15:12:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447974.704670; Thu, 24 Nov 2022 15:12:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyDth-0007MS-6O; Thu, 24 Nov 2022 15:12:17 +0000 Received: by outflank-mailman (input) for mailman id 447974; Thu, 24 Nov 2022 15:12:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyDtg-0007MM-Im for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 15:12:16 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f634b3c-6c0a-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 16:12:14 +0100 (CET) Received: from mail-dm6nam12lp2170.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Nov 2022 10:12:08 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BL1PR03MB5989.namprd03.prod.outlook.com (2603:10b6:208:310::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Thu, 24 Nov 2022 15:12:06 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Thu, 24 Nov 2022 15:12:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f634b3c-6c0a-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669302734; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=+XnoetakotoxNEToJ5NHRWB+nW0pCFYgCH6tkgYpQxA=; b=ZWNqMhFxm69OnNG/33nhZKlCiNR4F9PpEsYwqfjXnj+Dx4v1cQ7Md/fg NIu67mz4HpCvcUFwqA4nGLlDuB53iJkaLiiQCfKYVFFPeFslj3xQ2AUR7 65+aG4jtoVm9suXe4Y7563u+cMyzBpB9pC6MyemJi/6MZJNBdMglFPt7/ k=; X-IronPort-RemoteIP: 104.47.59.170 X-IronPort-MID: 84551596 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Kmkd96i7B4cja4ASPOw0TQwFX161VREKZh0ujC45NGQN5FlHY01je htvXW/XOfaDYWr3fdB2PYvloBkOupKAmIcwQFNvrSAyQy0b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QWCzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ/DQ8dTQq/vtvt76q2G/ZCttsNDtfCadZ3VnFIlVk1DN4AaLWaGeDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEgluGyaLI5efTTLSlRtlyfq W/cuXzwHzkRNcCFyCrD+XWp7gPKtXOnBd9LSezmnhJsqHTLwHZKAyUpaXy6nPuAhGvncOp1D mVBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQMQvqcseVTEsk FiTkLvBFTFp9bGYV3+Z3rOVti+pfzgYK3cYYi0JRhdD5MPsyLzflTrKR9dnVaKw0Nv8HGiqx yjQ9XdmwbIOkcQMyqO3u0jdhC6hrYTISQhz4RjLWmWi7UVyY4vNi5GU1GU3JM1odO6xJmRtd lBd8yRCxIji1a2wqRE= IronPort-HdrOrdr: A9a23:GVKnOKzn/yGY1irmFuweKrPxTOgkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu vg2iMLnUvXRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirCWekD+y77b+Mh6AmjMTSSlGz7sO+X XM11WR3NToj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhn8lwqyY4xlerua+BQ4uvum5loGmM TF5z0gI8NwwXXMeXzdm2qn5yDQlBIVr1Pyw16RhnXu5eT/WTIBEsJEwaZUaAHQ5UYMtMx1lP sj5RPQi7NnSTf72Ajt7dnBUB9n0mKyvHoZiOYWy1hSS5EXZrN9pZEWuGlVDJADNiTn751PKp gmMOjsoNJtNX+KZXHQuWdihPSqQ3QIBx+DBnMPv8SEugIm6UxR/g89/ogyj30A/JUyR91v/O LfKJllk7lIU4s/cb99LP1pe7r4NkX9BTb3dE6CK1XuE68Kf1jXrYTs3bkz7Oa2PLQV0ZoJno jbWl8wjx98R6vXM7zP4HR3yGGPfI3kNg6diP22pqIJ9oEUfYCbcBFqEzsV4o6dS/Z2OLyoZx /8AuMTPxbZFxqfJW945XyBZ3BsEwhubCQ0gKdOZ7vcmLO9FqTa8srmTd30GJ3BVR4ZZ0KXOA pxYNG0HrQM0nyW X-IronPort-AV: E=Sophos;i="5.96,190,1665460800"; d="scan'208";a="84551596" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OLMbgPZxTC7UDMBnYaLs4C6F1jrX+KTD3w7Qaq8Kjla74h7fieNb0QeC7CpiQ3U8B27cMF9blcJw/phGbjjo9qedsqvVnCa2QNMJ34uvElsG80yqx6OCCTzo1isefgLjMbuOb+w8X7nLBCBagkOQ7ezNhJDqL+tIHokbNvXTOLmv6Ei5hHoLZHHbkGHo4k3D83wVoLbHKf84z7NU5ome1Fa+o8hrxmtXFtThwM3ef1uzbn35jop9w4MSzwBtacudpUY2eZhQ32bTK3nMGv9gHsl8N8ZZDKqm/SprlJiW6VmiGlVo4NzZzFez+DiYsGX8rCXfIVJYTnYvFez0U9jcZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=21OxjlFiUuit2SnAoDWdPFj7FvF+4J7Rk5F876MIRv4=; b=NG9vxLM2xBgL2dKPvHB2Z/63O8y7w2mXLiXB35K/0vfU/dK05Kn7sH7tMYs2NEr8zDET43C4VwuOSRFuemowJp4AweX3qF5Y4ynu5+WNiX7svPfR/B8SBvyFddxycosdvNfaXtykI3utBPShnkneRP3ZxyjL2Hn8IS38bTXUJauGII9q8MXRuxzslsHJpPQkSUCVMJHmODGXJeNgWmDMDeKLZ+BTbpAR3/fMFd5V3LUYlTRoq1Ma6DbVhyW22+RWb6byrS6PaLm29JSHmk4vu/T0U2YRuCd5X2XmvT+YnD2j0GgdxAN+wJ9ufcERDh0FjAkZ8wI8ekmRyYNgFpq24g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=21OxjlFiUuit2SnAoDWdPFj7FvF+4J7Rk5F876MIRv4=; b=MKSWIVKLMugkNF2SKu0NLmeu1btm/aQ2vRj9BfvFOBqTlvV6Kp0G2vYdFLoG3z9OJytfR0w+RpeBEBXF4H9U9rMz13EMZ/lRBcutyxME7LDqpM4VgB2B6AFt1fEsLRBqyb3VXVtYvvWX6+WSke5T7YEXq5xF9CloMoqE28sCSJQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 24 Nov 2022 16:12:00 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Message-ID: References: <878e635f-b116-3580-945f-f8acb711a5bc@suse.com> <69507b8d-1f31-39fb-7469-e240fbfdde44@citrix.com> <33a005bf-0596-c624-0e70-077a450ac2ae@suse.com> <351a6e54-8002-aef0-993a-c6b8bdcc1e8e@suse.com> <3f3bced7-62e8-4ff2-655d-aed222f343a9@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3f3bced7-62e8-4ff2-655d-aed222f343a9@suse.com> X-ClientProxiedBy: LO2P265CA0468.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::24) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB5989:EE_ X-MS-Office365-Filtering-Correlation-Id: 092c99f9-3cb9-4f61-50c9-08dace2e3f9d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bzw04FnPLdPtKEH5n/pKMGglZDeL7nnh/4wvkubXGc68m/K7A2LXBx5BKlxCg7lc1yXpdlq2yt+GOzWQDXHpw0V1g70we/f6INUPawkd2zJw9qVBuiE9gsBfOg0sEHvA81xhCpdeTmGe2w9DlWFjqh7SI8qX8OeuObqAwyUw9QFIhWvPOZnZk2O6t8b+3TCtm3nDZ433aBgLVw5OpSHcB9Pyhu5oc3DGQFQ1ACeHAFgAbY45tq8owTvg6QriHp3VMwKMMLCdUnKs4QbxOLqVZhLuTkVMinoqgXb/ORSGK9yfVnPPmlaH+yEAS/e60bcHDkuyLAxwh1LNK66z4IEOjmpKMTcy14EIfTgax9hN6wLkBB03nhGzEN+soyXv87+XBJChJ1kUb8BjVJx8tdLkQA1V6U2fspfGjzzlIfjP9Vsh8Gds44vwVFbQLVVrEEi574BprGujlzFckczu02GEHpoIXS2Aa2Y2JAHH0VF8C87fHUAeNOlYL2cM+dhm3b2MUCdpWiW2kEUzH2UVROd2ibDSzc7CS6wlOuEHq+ANVfhcBhR39jY4rLOL1e3AbMgIHiIP7JdT9PTroQ/u0RfFZKEBOn6tnL6B8TzpVkZYMN+wbmCgs2GQvV0ssdX0bl5fRnru5Tws+6vEzxFshqo0IlR4J13+H1g+QqCKuDOSOGkoB219VlHXfwwViUW+8AyzCkBQdvhjxxu/ZOm3D6M8nbWm8YcCnGwgnHUIQMz2ycE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(39860400002)(376002)(346002)(396003)(366004)(451199015)(6506007)(9686003)(186003)(53546011)(38100700002)(82960400001)(83380400001)(6512007)(26005)(5660300002)(2906002)(41300700001)(66946007)(54906003)(33716001)(966005)(6666004)(4326008)(6916009)(66556008)(8936002)(316002)(8676002)(478600001)(66476007)(6486002)(66899015)(85182001)(86362001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlJHd2g1cnpKenBNYjBGRE9aem9TcjVGeENwclNsQlcralV0L1RyWkdQcGZm?= =?utf-8?B?UTNaVGNIN2E2dHBLRmgzLzN3Zy9teW1KNG43K0UzbXhaVXRxSEpsSzU5cnBL?= =?utf-8?B?cy9xcGhzRCt2NWxFV21yM2YzUlBaamxXZW5CbVluVXhjOWJCNGNSRER1Rktq?= =?utf-8?B?WG4rcndrckJMeHA1M2R3a3l2Zkc4RFpBQ2dEeXBDM3FMU0lkUTBBZ3JjUnBF?= =?utf-8?B?MDB2ZC9EOXAvL0hnR0FVWTlQNk00bk5NV2xPV2JaNWJTdmp0RkoyYnBJUDF2?= =?utf-8?B?bUxHdHM2THhFZWRYVjBiTmg1S3VwbHZGRjdoWjd3TU5YVGxlSnkvVDI1ejEv?= =?utf-8?B?THV1MGMvRzRtVmlYbVhmK3RkeWRCWGFOS25vdGtrQkZEbHNMcWRFaGhhSWYr?= =?utf-8?B?bmxBSE1BT2RyTERkM0xyNCtIMWttZnZDRHhqcnB5VFRRK3JGNEp5M2JqZCts?= =?utf-8?B?T1h1R0tZVXRGeEtuQkdVTzdiVzZsSURyc3dBSkFaTStwbkM2amU2RXRwWWE0?= =?utf-8?B?R0pYbXYzUG5xaDZGNjVUOW5qcm1lTm05YWVuZTFweGdpaXlxMm4xdnc5K3U4?= =?utf-8?B?Y1QvdzJZam04ZXRtdXRNRXJrUS8zTkdwMEZCR1dMblhXQ3dwM05mV3R4K2hY?= =?utf-8?B?TTg4QXdLTjBLa0ZzWWt1SXVtYmtUWWFTNFpNdTBOQkpkd2lPTjRVSCsvcC82?= =?utf-8?B?YytCZHoxMUV5WUdBUkxzdGVoQloxQmtwN2RvODJUVWY2b3A2eXpEY0lXRXFC?= =?utf-8?B?akc5UXJFY0d6cjd5aHpjNkROd0ZWVUxKZ2Y0OG1kL0VScytSVTZJcHpaSmFt?= =?utf-8?B?ZFA4cGh5QmRMY3k2bHR1Q2JQMXFIc3Rqbnp1MURUUHUwRExuK2N2SFBTeTZa?= =?utf-8?B?bGp6ZGRFNzFvTXdaOGovV1B2SzArNmNpZ2llMDhSUnJ1N21VSjdsTlV0SmRX?= =?utf-8?B?SU1IdHFBdmNwMFBTYTI1b2o0eEFxSTVUYlJ6SXVjZTFiOEdNWFp0aFNsbzQ1?= =?utf-8?B?ZmFpOXN5ZFlaTGpGMU9heFJZZmphUG5OcUlwQ014YzV6MmpmUDNQS01tZzBG?= =?utf-8?B?R1lMcFZpbjNNdTZyZWMvcWxxY2NZS2RyQzE1WCsxWkRSdDNpLzB2NFpuSUtQ?= =?utf-8?B?c1ZORjJNQUFCUXhmdTlOKzRPQWtMRlp6SGxkNGFrY3U0dWlEblAxNFFrMHZE?= =?utf-8?B?QTBCTEJoeFZDeTlGYXJveXRiVllFbkVudWxyMmt2UEg0V25LUVZwZUtraHIv?= =?utf-8?B?QTJ6WDg3aXlXNHRuRW0rckxsTTdhNmM3dnJnMENFTkVUK2tBRFBvNU5CdDMx?= =?utf-8?B?SW00NmwrQVdUaG9ickRYYi8yUEV6b2t3dWtTWFN0bXhEa1FFNkN1aGJZc1cz?= =?utf-8?B?YjhzanBUNmlkaEd0a2JuUFRsSUdEUHhTS2o2NXRpaFJBVGliVGpBSlZUazZG?= =?utf-8?B?YVllc0dYRUIrK21UMVQ1REYxc0FHY0FVNTlXTXdhWWx3RldiV1VHMC9QMEFM?= =?utf-8?B?eEJmRS9rMmlHQ1l0YUhWdDczeGtjKy9NemVpb0QvUTdoNEtvS3hEbGVSTlJv?= =?utf-8?B?Q3lQSHo5cDlvdzRHZUloS0F2amt4MnA1V2ZlUUVmNjZOdFYySFNvRTFWOWIx?= =?utf-8?B?dmdCNEt2Uk50NFk0aG1iN2dxWUNkZmNEdERVNmZ2Z25CeFNucjJxSTJ5TDRV?= =?utf-8?B?Ti80U3JsMTRVS3g0YS9mdHVpdk5jTmhPaFRZeDlENTNUMjkwVXZCYk8wbHBo?= =?utf-8?B?YUVDVmZZcE10am5ieEtWVUN5SmpFbExpMjNsVjh5U21ZdlJBakZMa05SOHBw?= =?utf-8?B?OERaaFgxUFQrOEh1bTdHZGc0TklCKzB0N3B1MGZ5emd5ZTcxTmM5L1U2dTh4?= =?utf-8?B?ZE5YcnlWRXcxVGhrZmxMYm9WRE13bDRrcVEwQ3ZsUnF2dFljL2J0UU5DemNt?= =?utf-8?B?eW1CWmZUelJFamZtZzViKzcyLzk0cnpsQnhiZG00TVpHald5MDRRMDMzYVk5?= =?utf-8?B?YjFJWUliZWxYdUtEL0Vma2h1d0ZqaWFXaFFnWE1MZGpoa2N0K3RHTkxkWmxp?= =?utf-8?B?ZmM0UnYxcnhPWVJYZlNzRW1qTDlQaFFuYTFBMytMTW1kQnN4WG1hbUVHNmow?= =?utf-8?Q?99ul5HxdpCgziOKgIuKahaqma?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: W1+fPpRNnEt0zEKQZoQLT+Xemg7hjqtSpUthVimSdbP/Jdt0v5TTBM1urMTK1U4fJDkT+/kS5coWj5CvxA6DxxYX6A4LZ/j6fwc1k4HqWLmuINh6dKWyCHHRYTPMA8ZIiEyRlULsxCYFp1Tw3hoyKmcGRynkLCq3BgRkB3lwk6JrCt+RRmY7JiOGhiE9FUDgkxbXeqcAKAel79sxZPoWJtDgsU//+cojubYDmTfqYR20eyVbxRi8mOdEbyKgGFmND6XENZRHYFh6vXp3V6g918ZSBytascg/1BNc0025GfTBONaSNTZPboCG1fVvCYeMFusCQypZr9nxm7E5Rs/k8sRw7HoTz6hpwWpJlJ2xYaQRMoa7Oa2aKLyY0j7DYWFWcORHrS2H9oN/k0XcKd3GdmNdTk/nEAOvZ80Nc95zv/rasp5DX13kj765jqokRnh6jOjDdn+lgNYdvG+zwk0xIzJ8N3uSIZ35giJrCngRpQmC0rZfKwEdLYiKJv6OKqi4RyFaLuTcRlOdW1Xa3wlPQR+bn0Mv5VcAT8M4J1/fJGjBP03sKEVGytk2R6M4mfG+t43clo3BnOMGzSIYTmHL4rfGsvL7O1ApIVoLQwLuLCWoYrlOCXfC57CHWInXjQiy+KdpBWMmEA2MEbfwcMpFmsa4xSVJ4UGMmjIxWk6NKUCqQ5x4368LrHp+Nqb3XzSLp4dk8SLVf5fAvuNayc2sb/MgFWCu76ZYl3QiuExAwAjWYMa5jYLyTGpKcLMUf2EzAwiS/Z82+Rb6S+iR15om0pMx11rDkeTGqcM8r/G+kkN11DEbFVcsBO/41ZcguIEOj3oaG7B9ChwcKJt3VSSTZ1bXUYZvnhjGYc19a3vCrl0= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 092c99f9-3cb9-4f61-50c9-08dace2e3f9d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 15:12:05.9469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xXNb8QKZbpmRbT1FIeEz0Nwmwi+Lmm886K7BpboKYssV75b09QSkyh0+ft993Z/XvaOf0yJ3RAiIv88k+QwKTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB5989 On Thu, Nov 24, 2022 at 12:16:13PM +0100, Jan Beulich wrote: > On 24.11.2022 10:33, Roger Pau Monné wrote: > > On Thu, Nov 24, 2022 at 10:11:05AM +0100, Jan Beulich wrote: > >> On 24.11.2022 10:06, Roger Pau Monné wrote: > >>> On Thu, Nov 24, 2022 at 09:42:40AM +0100, Roger Pau Monné wrote: > >>>> On Thu, Nov 24, 2022 at 08:59:00AM +0100, Jan Beulich wrote: > >>>>> - problematic wrt evtchn_upcall_pending, once set, preventing event > >>>>> injection later on. > >>>>> As you may have inferred already, I'm inclined to suggest to drop the > >>>>> the is_vcpu_online() check from hvm_set_callback_via(). > >>>>> > >>>>> One related question here is whether vlapic_do_init() shouldn't have > >>>>> the non-architectural side effect of clearing evtchn_upcall_pending. > >>>>> While this again violates the principle of the hypervisor only ever > >>>>> setting that bit, it would deal with the risk of no further event > >>>>> injection once the flag is set, considering that vlapic_do_init() > >>>>> clears IRR (and ISR). > >>>> > >>>> That would seem sensible to me, and was kind of what I was suggesting > >>>> in: > >>>> > >>>> https://lore.kernel.org/xen-devel/Y3eO0bMKRPYJc2yQ@Air-de-Roger/ > >>> > >>> Another option would be for vcpu_mark_events_pending() to > >>> unconditionally call hvm_assert_evtchn_irq() regardless of the state > >>> of evtchn_upcall_pending. > >> > >> I think you said so before, and ... > >> > >>> This will create some spurious events. > >> > >> ... I continue to be afraid of s/some/many/. > > > > Not _that_ many I think, as we can only queue one pending interrupt in > > IRR. > > We need to be careful here - the kernel treating it as "edge" (like > any other interrupt coming directly from the LAPIC), it ack-s it > before calling the handler, i.e. before evtchn_upcall_pending would > have a chance to be cleared. See Linux'es sysvec_xen_hvm_callback(). Hm, that's not how I handle it on FreeBSD, where the vector is acked after calling the handler (evtchn_upcall_pending gets cleared before the EOI). Maybe there's some corner case I'm missing that requires the EOI to be performed before clearing evtchn_upcall_pending? > >> This event delivery is meant > >> to be kind of edge triggered, and I think it is a reasonable model to treat > >> the flag going from 0 to 1 as the "edge". > > > > Hm, it's a weird interrupt model I would say. In some aspects it's > > similar to level (as the line stays asserted until it's cleared), but > > we don't get new interrupts injected into the APIC. > > > > Maybe the right mode would be to treat evtchn_upcall_pending as a > > level triggered line and keep injecting interrupts until the line is > > deasserted (ie: evtchn_upcall_pending == 0)? > > As said above, and as also pointed out by Andrew on another sub- > thread when discussing the (dis)similarity with IO-APIC connected > interrupts, at the LAPIC there's no edge/level distinction anymore, > as we're not dealing with "asserted" signals there, but just with > messages sent on the bus. Right, we could likely fake the behavior I've listed above, but not sure it's worth it. We should likely have some of this documented in xen.h next to the declaration of evtchn_upcall_pending, at least to note that once evtchn_upcall_pending is set no further vector callbacks will get injected until the field is cleared. Roger. From xen-devel-bounces@lists.xenproject.org Thu Nov 24 15:22:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 15:22:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447979.704680 (Exim 4.92) (envelope-from ) id 1oyE39-0000fI-9U; Thu, 24 Nov 2022 15:22:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447979.704680; Thu, 24 Nov 2022 15:22:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyE39-0000fB-6g; Thu, 24 Nov 2022 15:22:03 +0000 Received: by outflank-mailman (input) for mailman id 447979; Thu, 24 Nov 2022 15:22:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyE37-0000f5-RT for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 15:22:01 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bc86227f-6c0b-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 16:22:00 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc86227f-6c0b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669303319; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Mzlr09z995zdUh6ynEFT2+xHtAeZpxOVWS5vpRPvMCE=; b=NuccLP9c8W6mWRwGOi5WIdda6EJXJI1j/w0eV/DxQpB9YUGd1O4Pdeup 038u2f1QxK4XpfggNewue3OvpHqzeux5EoRdM63ORpV8AlGp2H1q164Ys r8lW6mEDZG8Co/alkwGaG4VMy1NZAFbviV4vIEuf8WCmSzoeogQ5lEXSN A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85923034 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:q8wDT6JzTpAOsU8sFE+RK5UlxSXFcZb7ZxGr2PjKsXjdYENShTMEy GdJCmmGO/fZMGGjetwkat+xoEsHv8eAnYcySQRlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wZiPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4pOX1W8 +UiBgsVdwHS2LKwwfG6dMNz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUozXFJ8Oxh3Ez o7A11W6Ik8KH9m78Cec2W6Wq8/TpSjpBI1HQdVU8dY12QbOlwT/EiY+Sl+TsfS/zEmkVLp3L 1Ef/yslpqk13EOuR9j5GRa/pRasuxcGUN0WCOo+6QyXy4LR4gCUHHYNVS9aLsArv89ebT4lz FiShPvyGCdi9raSTBq15rqS6D+/JyURBWsDfjMfCxsI5cH5p4M+hQ6JScxseIa+h8fxHnf2x DaDsC8WgrQVgNQV3r6q5hbbjjmszrDASAIv6wyRVGu+8gR/ZaagZoql80bS9udbapqURVnpl H0NgcOZqvsJCZCAji2lXeMMGbaz6rCELFXhbUVHRsd7sW73ojj6IN4WsGoWyFpV3tgsJwf1e EnKgy1q/IZCbST6a640YrybFJF/pUT/LujNWvfRZ9tIR5F+cg6b4S1jDXKtM3DRfFsEyv9mZ 8rCGSq4JTNDUPk8kmLqLwsI+eVzrh3S018/UnwSI/6P9bOFLECYRr4eWLdlRrBotfjUyOk5H js2Cidr9/m9eLemCsU02dRJRbzvEUXX/bis96Rqmhere2KL2AgJUpc9O48JdY1/hLhynezV5 Hy7UUIw4AOh2yydc1XWOiA4MuuHsXNDQZUTZHxEALpV8yJ7PdbHAFk3KfPbgoXLBMQ8lKUpH pHpiu2LA+hVSySvxtjuRcCVkWGjHTz17T+z092NOmZgJ88+HVeTq7cJvGLHrUEzM8Z+juNmy 5XI6+8RacNrq9hKZCoOVM+S8g== IronPort-HdrOrdr: A9a23:czhVW6Dim9rlV1DlHemu55DYdb4zR+YMi2TC1yhKKCC9Vvbo8P xG/c5rsSMc5wx8ZJhNo7+90ey7MBXhHP1OkOws1NWZLWrbUQKTRekIh+bfKn/bak/DH4ZmpN 5dmsNFaOEYY2IVsfrH X-IronPort-AV: E=Sophos;i="5.96,190,1665460800"; d="scan'208";a="85923034" Date: Thu, 24 Nov 2022 15:21:48 +0000 From: Anthony PERARD To: Carlo Nonato CC: , , , , Wei Liu , Juergen Gross , Marco Solieri Subject: Re: [PATCH v3 4/9] tools/xl: add support for cache coloring configuration Message-ID: References: <20221022155120.7000-1-carlo.nonato@minervasys.tech> <20221022155120.7000-5-carlo.nonato@minervasys.tech> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221022155120.7000-5-carlo.nonato@minervasys.tech> On Sat, Oct 22, 2022 at 05:51:15PM +0200, Carlo Nonato wrote: > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in > index b2901e04cf..5f53cec8bf 100644 > --- a/docs/man/xl.cfg.5.pod.in > +++ b/docs/man/xl.cfg.5.pod.in > @@ -2880,6 +2880,16 @@ Currently, only the "sbsa_uart" model is supported for ARM. > > =back > > +=over 4 > + > +=item B Instead of COLORS_RANGE, maybe NUMBER_RANGE? Or just RANGE? > +Specify the LLC color configuration for the guest. B can be either > +a single color value or a hypen-separated closed interval of colors > +(such as "0-4"). Does "yellow-blue" works? Or "red-violet", to have a rainbow? :-) So, "colors" as the name of a new configuration option isn't going to work. To me, that would refer to VM managment, like maybe help to categorise VM in some kind of tools, and not a part of the configuration of the domain. Could you invent a name that is more specific? Maybe "cache_colors" or something, or "vcpu_cache_colors". > +=back > + > =head3 x86 > > =over 4 > diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c > index b9dd2deedf..94c511912c 100644 > --- a/tools/libs/light/libxl_create.c > +++ b/tools/libs/light/libxl_create.c > @@ -615,6 +615,7 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config, > struct xs_permissions rwperm[1]; > struct xs_permissions noperm[1]; > xs_transaction_t t = 0; > + DECLARE_HYPERCALL_BUFFER(unsigned int, colors); > > /* convenience aliases */ > libxl_domain_create_info *info = &d_config->c_info; > @@ -676,6 +677,16 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config, > goto out; > } > > + if (d_config->b_info.num_colors) { > + size_t bytes = sizeof(unsigned int) * d_config->b_info.num_colors; > + colors = xc_hypercall_buffer_alloc(ctx->xch, colors, bytes); Hypercall stuff is normally done in another library, libxenctrl (or maybe others like libxenguest). Is there a reason to do that here? > + memcpy(colors, d_config->b_info.colors, bytes); > + set_xen_guest_handle(create.arch.colors, colors); > + create.arch.num_colors = d_config->b_info.num_colors; > + create.arch.from_guest = 1; "arch" stuff is better dealt with in libxl__arch_domain_prepare_config(). (unless it isn't arch specific in the next revision of the series) > + LOG(DEBUG, "Setup %u domain colors", d_config->b_info.num_colors); > + } > + > for (;;) { > uint32_t local_domid; > bool recent; > @@ -922,6 +933,7 @@ retry_transaction: > rc = 0; > out: > if (t) xs_transaction_end(ctx->xsh, t, 1); > + if (colors) xc_hypercall_buffer_free(ctx->xch, colors); > return rc; > } > > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > index d634f304cd..642173af1a 100644 > --- a/tools/libs/light/libxl_types.idl > +++ b/tools/libs/light/libxl_types.idl > @@ -557,6 +557,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ > ("ioports", Array(libxl_ioport_range, "num_ioports")), > ("irqs", Array(uint32, "num_irqs")), > ("iomem", Array(libxl_iomem_range, "num_iomem")), > + ("colors", Array(uint32, "num_colors")), So the colors is added to arch specific config in xen_domctl_createdomain, maybe we should do the same here and move it to the "arch_arm" struct. Or if that is declared common in hypervisor, then it is file to leave it here. Also, "colors" needs to be rename to something more specific. > ("claim_mode", libxl_defbool), > ("event_channels", uint32), > ("kernel", string), > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index 1b5381cef0..e6b2c7acff 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -1220,8 +1220,9 @@ void parse_config_data(const char *config_source, > XLU_ConfigList *cpus, *vbds, *nics, *pcis, *cvfbs, *cpuids, *vtpms, > *usbctrls, *usbdevs, *p9devs, *vdispls, *pvcallsifs_devs; > XLU_ConfigList *channels, *ioports, *irqs, *iomem, *viridian, *dtdevs, > - *mca_caps; > - int num_ioports, num_irqs, num_iomem, num_cpus, num_viridian, num_mca_caps; > + *mca_caps, *colors; > + int num_ioports, num_irqs, num_iomem, num_cpus, num_viridian, num_mca_caps, > + num_colors; Please, add a new lines instead of increasing the number of declared variable on a single line. > int pci_power_mgmt = 0; > int pci_msitranslate = 0; > int pci_permissive = 0; > @@ -1370,6 +1371,53 @@ void parse_config_data(const char *config_source, > if (!xlu_cfg_get_long (config, "maxmem", &l, 0)) > b_info->max_memkb = l * 1024; > > + if (!xlu_cfg_get_list(config, "colors", &colors, &num_colors, 0)) { > + int k, p, cur_index = 0; > + > + b_info->num_colors = 0; > + /* Get number of colors based on ranges */ > + for (i = 0; i < num_colors; i++) { > + uint32_t start = 0, end = 0; > + > + buf = xlu_cfg_get_listitem(colors, i); > + if (!buf) { > + fprintf(stderr, > + "xl: Unable to get element %d in colors range list\n", i); > + exit(1); > + } > + > + if (sscanf(buf, "%u-%u", &start, &end) != 2) { > + if (sscanf(buf, "%u", &start) != 1) { I think you want %"SCNu32" instead of %u as both start and end are uint32_t. > + fprintf(stderr, "xl: Invalid color range: %s\n", buf); > + exit(1); > + } > + end = start; > + } > + else if (start > end) { Can you put the "else" on the same line as "}" ? > + fprintf(stderr, > + "xl: Start color is greater than end color: %s\n", buf); > + exit(1); > + } > + > + /* Check for overlaps */ > + for (k = start; k <= end; k++) { > + for (p = 0; p < b_info->num_colors; p++) { > + if (b_info->colors[p] == k) { > + fprintf(stderr, "xl: Overlapped ranges not allowed\n"); Why is that an issue? Could overlap just been ignored? > + exit(1); > + } > + } > + } > + > + b_info->num_colors += (end - start) + 1; > + b_info->colors = (uint32_t *)realloc(b_info->colors, > + sizeof(*b_info->colors) * b_info->num_colors); > + > + for (k = start; k <= end; k++) > + b_info->colors[cur_index++] = k; This `b_info->colors` feels like it could be a bitmap like for "vcpus" or other config that deal with ranges. libxl has plenty of functions to deal with bitmap that xl can use, starting with libxl_bitmap_alloc(), maybe it would make dealing with cache color easier, like no need to check for overlaps, but there doesn't seems to be a function to deal with a growing bitmap so one would have to find the highest cache value before allocating the bitmap are deal with realloc. I guess using bitmap or not kind of depend of the interface with the hypervisor, if it take a list of number, then a list of number is fine here too. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 24 15:35:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 15:35:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447983.704692 (Exim 4.92) (envelope-from ) id 1oyEFv-0002NU-Dg; Thu, 24 Nov 2022 15:35:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447983.704692; Thu, 24 Nov 2022 15:35:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyEFv-0002NN-Av; Thu, 24 Nov 2022 15:35:15 +0000 Received: by outflank-mailman (input) for mailman id 447983; Thu, 24 Nov 2022 15:35:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyEFu-0002NH-Ij for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 15:35:14 +0000 Received: from mail.skyhub.de (mail.skyhub.de [2a01:4f8:190:11c2::b:1457]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 95ae97d0-6c0d-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 16:35:13 +0100 (CET) Received: from zn.tnic (p200300ea9733e75b329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e75b:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8157A1EC0495; Thu, 24 Nov 2022 16:35:11 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95ae97d0-6c0d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1669304111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=uMdYplkUhfbHCUEJKpVOLbcUaHxlg1ZFtwfDCnP26Bg=; b=WIgJDIo+92EfSC2B053Gj/BryQ7+Y+NS138sgK/+xOVLE8AHeSHvMJvtcHBo1QIMUG6/xL kkKiZ2CObE7ZikcuycW7R3451oknrVPhB8NnY9vrnxKus9T15Bcxd01BfrN94x4zMdgLqF +BGpYYVLkK6KtrFXUA4+tmgrj88uFhM= Date: Thu, 24 Nov 2022 16:35:07 +0100 From: Borislav Petkov To: Juergen Gross Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3] x86/boot: skip realmode init code when running as Xen PV guest Message-ID: References: <20221123114523.3467-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Thu, Nov 24, 2022 at 02:30:39PM +0100, Juergen Gross wrote: > Looking at the date when 084ee1c641a0 went in I don't think it _needs_ > to go in now, but I wouldn't complain ... So if you don't have a particular and specific reason, I won't queue it for stable at all. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Thu Nov 24 15:36:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 15:36:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447985.704703 (Exim 4.92) (envelope-from ) id 1oyEGq-0002p4-N8; Thu, 24 Nov 2022 15:36:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447985.704703; Thu, 24 Nov 2022 15:36:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyEGq-0002ox-J0; Thu, 24 Nov 2022 15:36:12 +0000 Received: by outflank-mailman (input) for mailman id 447985; Thu, 24 Nov 2022 15:36:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyEGp-0002nb-GZ for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 15:36:11 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b6542c8d-6c0d-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 16:36:07 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6EDE321AB4; Thu, 24 Nov 2022 15:36:06 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 29B3013B4F; Thu, 24 Nov 2022 15:36:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IffBCGaPf2PibgAAMHmgww (envelope-from ); Thu, 24 Nov 2022 15:36:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6542c8d-6c0d-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669304166; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wKNi5deH4BoIskVZCgDsQzQoFbLRzsokztAH6oXCNrk=; b=BQhdgH4R+2aMiZMoj20bRKy1LmbIg/I+hE8wPh/4+hYACFWGwQE6m97ds6PMNqgQJrng1P iv1cmDdFh8Q6aLioEDSZy/XpDOj9hm9hlaKUt9xbCmqIBbtmkQxDC8usr7+JuZtcqQOvWw oKD+LiJu81BYWwo239arLn4XCdVfxzA= Message-ID: Date: Thu, 24 Nov 2022 16:36:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3] x86/boot: skip realmode init code when running as Xen PV guest Content-Language: en-US To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , xen-devel@lists.xenproject.org References: <20221123114523.3467-1-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------CpSuLEDiqmV6m0VZTCdrJczW" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------CpSuLEDiqmV6m0VZTCdrJczW Content-Type: multipart/mixed; boundary="------------0QEft5VLZuvNdepsITW01X4u"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Boris Ostrovsky , xen-devel@lists.xenproject.org Message-ID: Subject: Re: [PATCH v3] x86/boot: skip realmode init code when running as Xen PV guest References: <20221123114523.3467-1-jgross@suse.com> In-Reply-To: --------------0QEft5VLZuvNdepsITW01X4u Content-Type: multipart/mixed; boundary="------------bxSL8Rx0Pqxi7ireBdmCyZ1b" --------------bxSL8Rx0Pqxi7ireBdmCyZ1b Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjQuMTEuMjIgMTY6MzUsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gVGh1LCBO b3YgMjQsIDIwMjIgYXQgMDI6MzA6MzlQTSArMDEwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN Cj4+IExvb2tpbmcgYXQgdGhlIGRhdGUgd2hlbiAwODRlZTFjNjQxYTAgd2VudCBpbiBJIGRv bid0IHRoaW5rIGl0IF9uZWVkc18NCj4+IHRvIGdvIGluIG5vdywgYnV0IEkgd291bGRuJ3Qg Y29tcGxhaW4gLi4uDQo+IA0KPiBTbyBpZiB5b3UgZG9uJ3QgaGF2ZSBhIHBhcnRpY3VsYXIg YW5kIHNwZWNpZmljIHJlYXNvbiwgSSB3b24ndCBxdWV1ZSBpdA0KPiBmb3Igc3RhYmxlIGF0 IGFsbC4NCj4gDQoNClllcywgSSB0aGluayB0aGlzIGlzIGZpbmUuDQoNCg0KSnVlcmdlbg0K --------------bxSL8Rx0Pqxi7ireBdmCyZ1b Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------bxSL8Rx0Pqxi7ireBdmCyZ1b-- --------------0QEft5VLZuvNdepsITW01X4u-- --------------CpSuLEDiqmV6m0VZTCdrJczW Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmN/j2UFAwAAAAAACgkQsN6d1ii/Ey84 ZAgAhcKWf06iOffRhSIt2t/DqoRYFnETjfoOw1Swpb00p2sCECLDMJL6WUaOAsl+XsNb2ed+dztj p8cCEcOmeybTRfx7kOYyJm+ZY7GX470fjeH2nGgRKVzUTvUbLvJjB4O+RviUd1y4RDK0RmHU31+Y u2xJKOWUPAbVVbmCsA7KgVI9d2WIKG5ZHN1AoChNaC5npufm6ok06KJgIwVuLFAIRWty6bJkHeSc JlfO4SnqPHvCQIBJTldsCm2C97JyYvAh10N1So79zywqZ8nwrPO2PszO/9OzvxUh1iiRTQdwbViU Q5tN/q7FKa+60IUn7u+tddrzCZ2xLZoHa0YVWBbHbw== =vXBS -----END PGP SIGNATURE----- --------------CpSuLEDiqmV6m0VZTCdrJczW-- From xen-devel-bounces@lists.xenproject.org Thu Nov 24 15:39:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 15:39:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447991.704714 (Exim 4.92) (envelope-from ) id 1oyEKL-0003XA-5A; Thu, 24 Nov 2022 15:39:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447991.704714; Thu, 24 Nov 2022 15:39:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyEKL-0003X3-2O; Thu, 24 Nov 2022 15:39:49 +0000 Received: by outflank-mailman (input) for mailman id 447991; Thu, 24 Nov 2022 15:39:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyEKJ-0003Wx-UK for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 15:39:47 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 397dcd36-6c0e-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 16:39:47 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B4EB421116; Thu, 24 Nov 2022 15:39:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5E4A913B4F; Thu, 24 Nov 2022 15:39:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1oGOFUKQf2O0cAAAMHmgww (envelope-from ); Thu, 24 Nov 2022 15:39:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 397dcd36-6c0e-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669304386; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KVU414zfbUm2A5y1GOkaZ9BZzgZN37LCy+XUUBznaxY=; b=cYzDwpaI/9LjCBKGYfXmH3ZQkZ9vN3HHBWO7UR8awdBVreEAHQfsTz+AjL/uKmJ6uoQvXk JGoY96nQ6+G4+zjiLpg/N2HGyGGKawVBy36Ufjy5Ldkz5APSaTIDJMHt/1Id/X3c4LbBxY YRNJjOumJ1IWEJH+bbkhc5dS9engY7s= Message-ID: Date: Thu, 24 Nov 2022 16:39:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 1/2] x86/xen: Fix memory leak in xen_smp_intr_init{_pv}() Content-Language: en-US To: Xiu Jianfeng , boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, jeremy@goop.org Cc: x86@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20221123155858.11382-1-xiujianfeng@huawei.com> <20221123155858.11382-2-xiujianfeng@huawei.com> From: Juergen Gross In-Reply-To: <20221123155858.11382-2-xiujianfeng@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------S35eaZd0j89mmKCyPx08j3kb" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------S35eaZd0j89mmKCyPx08j3kb Content-Type: multipart/mixed; boundary="------------whnj3FRMM09BBjAxi0ZWTByg"; protected-headers="v1" From: Juergen Gross To: Xiu Jianfeng , boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, jeremy@goop.org Cc: x86@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH v2 1/2] x86/xen: Fix memory leak in xen_smp_intr_init{_pv}() References: <20221123155858.11382-1-xiujianfeng@huawei.com> <20221123155858.11382-2-xiujianfeng@huawei.com> In-Reply-To: <20221123155858.11382-2-xiujianfeng@huawei.com> --------------whnj3FRMM09BBjAxi0ZWTByg Content-Type: multipart/mixed; boundary="------------a9LCdkXEub1w0kVnalGgGY1q" --------------a9LCdkXEub1w0kVnalGgGY1q Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjMuMTEuMjIgMTY6NTgsIFhpdSBKaWFuZmVuZyB3cm90ZToNCj4gVGhlc2UgbG9jYWwg dmFyaWFibGVzIEB7cmVzY2hlZHxwbXV8Y2FsbGZ1bmMuLi59X25hbWUgc2F2ZXMgdGhlIG5l dw0KPiBzdHJpbmcgYWxsb2NhdGVkIGJ5IGthc3ByaW50ZigpLCBhbmQgd2hlbiBiaW5kX3t2 fWlwaV90b19pcnFoYW5kbGVyKCkNCj4gZmFpbHMsIGl0IGdvZXMgdG8gdGhlIEBmYWlsIHRh ZywgYW5kIGNhbGxzIHhlbl9zbXBfaW50cl9mcmVle19wdn0oKSB0bw0KPiBmcmVlIHJlc291 cmNlLCBob3dldmVyIHRoZSBuZXcgc3RyaW5nIGlzIG5vdCBzYXZlZCwgd2hpY2ggY2F1c2Ug YSBtZW1vcnkNCj4gbGVhayBpc3N1ZS4gZml4IGl0Lg0KPiANCj4gRml4ZXM6IDk3MDI3ODVh NzQ3YSAoImkzODY6IG1vdmUgeGVuIikNCj4gU2lnbmVkLW9mZi1ieTogWGl1IEppYW5mZW5n IDx4aXVqaWFuZmVuZ0BodWF3ZWkuY29tPg0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9z cyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg0K --------------a9LCdkXEub1w0kVnalGgGY1q Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------a9LCdkXEub1w0kVnalGgGY1q-- --------------whnj3FRMM09BBjAxi0ZWTByg-- --------------S35eaZd0j89mmKCyPx08j3kb Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmN/kEIFAwAAAAAACgkQsN6d1ii/Ey9A Ngf+JW1FpJQ3Q/U1OwyMpz6NnvZJ0UaaHX7PCntua7xqGOiSsrZor4jNe9JH92ieett/gs33m9wK DIY0qJSg7JqInXguaTMyxOOSfR2r2ziX+ce86Eo+ybaxO7UWIeFO0RmzstsRZq4tv/XQE2bvswF7 /KU+ZvCLLrvfp1+7TxMdAJEzRbgZF14Y74JuC9Z4F5BqxIr7EnGDIsSjthQgKnej4cBtQDXYyqhx 63zMbtzqqhOyTWfP3rHsiaoeXfuR8WUBzSdSVkUn3vrd4UY6XcRPS1NO/p0Jf5Am61mV8+RWUaA2 O1CfT0gWL9qe2rACNhWea6aLzStps6181AyUwltgbQ== =gyfQ -----END PGP SIGNATURE----- --------------S35eaZd0j89mmKCyPx08j3kb-- From xen-devel-bounces@lists.xenproject.org Thu Nov 24 15:40:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 15:40:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.447995.704725 (Exim 4.92) (envelope-from ) id 1oyEKu-0004tw-JT; Thu, 24 Nov 2022 15:40:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 447995.704725; Thu, 24 Nov 2022 15:40:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyEKu-0004tp-Fp; Thu, 24 Nov 2022 15:40:24 +0000 Received: by outflank-mailman (input) for mailman id 447995; Thu, 24 Nov 2022 15:40:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyEKt-0003Wx-KN for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 15:40:23 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4ec63146-6c0e-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 16:40:22 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 770ED1F854; Thu, 24 Nov 2022 15:40:22 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 275E313B4F; Thu, 24 Nov 2022 15:40:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MdjmB2aQf2MZcQAAMHmgww (envelope-from ); Thu, 24 Nov 2022 15:40:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ec63146-6c0e-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669304422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M43Sq4E5bN0CSI+TVPLNQU1qdDXk/NKQyKKWB2HL/b8=; b=LC+IBh4FSJytL4ZKN0kNCcivseNpaPNaEW8p+pDd+vOU4pueN9fjUcWBDNREBZ1mPeGXH3 ct77h/MrHb9AJbAun1Pt0CQpsc2HB6v9h1nTavlM5iMZ4pekVbTFqlSS4krPQnLWk2MTba OziTnjdI2zwq40zKlD4iI4e2grynR+E= Message-ID: <08829868-2c84-8ec9-936d-e6814edaf4c7@suse.com> Date: Thu, 24 Nov 2022 16:40:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 2/2] x86/xen: Fix memory leak in xen_init_lock_cpu() Content-Language: en-US To: Xiu Jianfeng , boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, jeremy@goop.org Cc: x86@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20221123155858.11382-1-xiujianfeng@huawei.com> <20221123155858.11382-3-xiujianfeng@huawei.com> From: Juergen Gross In-Reply-To: <20221123155858.11382-3-xiujianfeng@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------g71cZsF08Iq2xNN0ChTv5qHm" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------g71cZsF08Iq2xNN0ChTv5qHm Content-Type: multipart/mixed; boundary="------------zz8IykRPSugzkPiOuLEBOuZW"; protected-headers="v1" From: Juergen Gross To: Xiu Jianfeng , boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, jeremy@goop.org Cc: x86@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: <08829868-2c84-8ec9-936d-e6814edaf4c7@suse.com> Subject: Re: [PATCH v2 2/2] x86/xen: Fix memory leak in xen_init_lock_cpu() References: <20221123155858.11382-1-xiujianfeng@huawei.com> <20221123155858.11382-3-xiujianfeng@huawei.com> In-Reply-To: <20221123155858.11382-3-xiujianfeng@huawei.com> --------------zz8IykRPSugzkPiOuLEBOuZW Content-Type: multipart/mixed; boundary="------------chaXyuWdvybov2Rsq7Xk2SdP" --------------chaXyuWdvybov2Rsq7Xk2SdP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjMuMTEuMjIgMTY6NTgsIFhpdSBKaWFuZmVuZyB3cm90ZToNCj4gSW4geGVuX2luaXRf bG9ja19jcHUoKSwgdGhlIEBuYW1lIGhhcyBhbGxvY2F0ZWQgbmV3IHN0cmluZyBieSBrYXNw cmludGYoKSwNCj4gaWYgYmluZF9pcGlfdG9faXJxaGFuZGxlcigpIGZhaWxzLCBpdCBzaG91 bGQgYmUgZnJlZWQsIG90aGVyd2lzZSBtYXkgbGVhZA0KPiB0byBhIG1lbW9yeSBsZWFrIGlz c3VlLCBmaXggaXQuDQo+IA0KPiBGaXhlczogMmQ5ZTFlMmY1OGI1ICgieGVuOiBpbXBsZW1l bnQgWGVuLXNwZWNpZmljIHNwaW5sb2NrcyIpDQo+IFNpZ25lZC1vZmYtYnk6IFhpdSBKaWFu ZmVuZyA8eGl1amlhbmZlbmdAaHVhd2VpLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4g R3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQoNCg== --------------chaXyuWdvybov2Rsq7Xk2SdP Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------chaXyuWdvybov2Rsq7Xk2SdP-- --------------zz8IykRPSugzkPiOuLEBOuZW-- --------------g71cZsF08Iq2xNN0ChTv5qHm Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmN/kGUFAwAAAAAACgkQsN6d1ii/Ey8+ Ngf8CR1nYyQ6myrATb6TqeVL3tznFOZeNSwPZ95St0vd2ku2qoUpUsxNgEH/UJQjD8lllBQvkMS4 WWxLK0VfJ783ZKid4ropnDhNvaDLsAR983pgvvVM54CADN3frawJbUbv1qgf5OoDqIzntDONOXXT fGd82BcYCff0qZ4BgFjseMKiLROigoui4ciPw22+ENkShfmeHUVhfWp8Em9jQ8m7S3gyGy3Jp1Da TFX8svclJzTisPG72kXGsQGxD35PJR5mN+P6ePcIMsXRFBPtzNat55gfBG8NIvSEA2UtVoZezF35 5yLw+LebRCKQZx9AuizlR/6oKcEyQMmwO/ozOu+HSQ== =cjx7 -----END PGP SIGNATURE----- --------------g71cZsF08Iq2xNN0ChTv5qHm-- From xen-devel-bounces@lists.xenproject.org Thu Nov 24 16:39:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 16:39:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448001.704736 (Exim 4.92) (envelope-from ) id 1oyFGC-0003Wn-TZ; Thu, 24 Nov 2022 16:39:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448001.704736; Thu, 24 Nov 2022 16:39:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyFGC-0003Wg-Qw; Thu, 24 Nov 2022 16:39:36 +0000 Received: by outflank-mailman (input) for mailman id 448001; Thu, 24 Nov 2022 16:39:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyFGB-0003WZ-5g for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 16:39:35 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 93036ac4-6c16-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 17:39:33 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 363F0B82839; Thu, 24 Nov 2022 16:39:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A5C5C433C1; Thu, 24 Nov 2022 16:39:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93036ac4-6c16-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669307970; bh=OKXY4HOb6tjr1fLTcQMjreoqibQdHiqlX3XPx/NKo9c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FF5BWWm70I4oWNIABZDD5ZpFGtfi4xlErQuLbHrchom/bIyjGAbpEMOYVG8rmdXq2 6wd7icEHORG3GbzZLud50WsU3LCUvSdfENs1JIYho+TKFacLC+WjnL1qKGuIOziaV6 cr14plP3s5Mqnfve1ScQR/NMHdIfZXrlbW6pCyCBrO45F+TD2H29FP7OmVrMnmx+37 0pMTWSW3bm/1D/YVt6SapbZaIjNc/Zz8CFvYh3Fs5kmEv8gpsy4teGGd6pXgMcI9Nl spWVSqEETTY2dJ2LUJz7/jgvHdy33n1dmdw+EojgYr23nC6zfKtA1q+kezQE3v0DYe 8cBAfQH4M+MfA== Date: Thu, 24 Nov 2022 08:39:28 -0800 From: Josh Poimboeuf To: Juergen Gross Cc: Andrew Cooper , Peter Zijlstra , "Paul E. McKenney" , "sfr@canb.auug.org.au" , "linux-kernel@vger.kernel.org" , "sstabellini@kernel.org" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , Thomas Gleixner Subject: Re: objtool warning for next-20221118 Message-ID: <20221124163928.dof5ldfer6rswlnx@treble> References: <20221121145215.GF4001@paulmck-ThinkPad-P17-Gen-1> <20221122051605.4hcbslwxez2trdvt@treble> <20221123012350.kelmmadh65lyswqz@treble> <2255c45f-d8ba-3f32-9d99-737ad3040dd7@citrix.com> <20221123170337.keacggyvn4ykbtsw@treble> <20221124023934.nft3udxelth4lvai@treble> <72a4871b-3ee8-42c1-912a-321a45690428@suse.com> <68dc479a-6b61-0012-888d-c1b4cc513cdb@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <68dc479a-6b61-0012-888d-c1b4cc513cdb@suse.com> On Thu, Nov 24, 2022 at 08:47:47AM +0100, Juergen Gross wrote: > > > +++ b/arch/x86/xen/smp_pv.c > > > @@ -385,17 +385,9 @@ static void xen_pv_play_dead(void) /* used only > > > with HOTPLUG_CPU */ > > >   { > > >       play_dead_common(); > > >       HYPERVISOR_vcpu_op(VCPUOP_down, xen_vcpu_nr(smp_processor_id()), NULL); > > > -    cpu_bringup(); > > > -    /* > > > -     * commit 4b0c0f294 (tick: Cleanup NOHZ per cpu data on cpu down) > > > -     * clears certain data that the cpu_idle loop (which called us > > > -     * and that we return from) expects. The only way to get that > > > -     * data back is to call: > > > -     */ > > > -    tick_nohz_idle_enter(); > > > -    tick_nohz_idle_stop_tick_protected(); > > > -    cpuhp_online_idle(CPUHP_AP_ONLINE_IDLE); > > > +    /* FIXME: converge cpu_bringup_and_idle() and start_secondary() */ > > > +    cpu_bringup_and_idle(); > > > > I think this will leak stack memory. Multiple cpu offline/online cycles of > > the same cpu will finally exhaust the idle stack. Doh! Of course... I was actually thinking ahead, to where eventually xen_pv_play_dead() can call start_cpu0(), which can be changed to automatically reset the stack pointer like this: SYM_CODE_START(start_cpu0) ANNOTATE_NOENDBR UNWIND_HINT_EMPTY movq PER_CPU_VAR(pcpu_hot + X86_top_of_stack), %rax leaq -PTREGS_SIZE(%rax), %rsp jmp .Ljump_to_C_code SYM_CODE_END(start_cpu0) but that would only be possible be after more cleanups which converge cpu_bringup_and_idle() with start_secondary(). > The attached patch seems to work fine. The patch looks good to me. It doesn't solve Paul's original issue where arch_cpu_idle_dead() needs to be __noreturn. But that should probably be a separate patch anyway. > The __noreturn annotation seems to trigger an objtool warning, though, in > spite of the added BUG() at the end of xen_pv_play_dead(): > > arch/x86/xen/smp_pv.o: warning: objtool: xen_pv_play_dead() falls through to > next function xen_pv_cpu_die() You'll need to tell objtool that xen_cpu_bringup_again() is noreturn by adding "xen_cpu_bringup_again" to global_noreturns[] in tools/objtool/check.c. (Yes it's a pain, I'll be working an improved solution to the noreturn thing...) -- Josh From xen-devel-bounces@lists.xenproject.org Thu Nov 24 16:43:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 16:43:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448004.704747 (Exim 4.92) (envelope-from ) id 1oyFJu-00057E-E0; Thu, 24 Nov 2022 16:43:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448004.704747; Thu, 24 Nov 2022 16:43:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyFJu-000577-Ap; Thu, 24 Nov 2022 16:43:26 +0000 Received: by outflank-mailman (input) for mailman id 448004; Thu, 24 Nov 2022 16:43:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyFJt-000571-Em for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 16:43:25 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1b54ad42-6c17-11ed-91b6-6bf2151ebd3b; Thu, 24 Nov 2022 17:43:23 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b54ad42-6c17-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669308203; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=65nK8wEs6tGHvEng34CrzXajvfyLyoM+LOPRulqvbS0=; b=iJH75i424ImQi81hWX5Ch7TqUADRQ/pWM4bykvjZlehTp2oCZPSANafc 6itWbDyd7zq4EJctziWhiaZgyyS/Da/+0fDcpXq8fHIupHhGC3yTQAV3z yinolKpLuvIreV9T1MazhvI0jMDO0K96iVU2ZzVOrmnhjNvmNEfLOf8pv g=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85079088 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:BIXIAa4ZeYjVrrd7R2dARgxRtEvHchMFZxGqfqrLsTDasY5as4F+v mtOX27QOa2CNmGjfIp3YYvk/E5XuJSBmNFjT1Nl+XxnHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkR4AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m6 9E7ES0JShu5lu+K2byQTNU2oP8aFZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJU0UUrsUIMtWcOOAj3/jczpeuRSNqLA++WT7xw1tyrn9dtHSf7RmQO0Fwx7H9 zqWrwwVBDkQatq722GK0UuXodXzxyneYrxCFuOBo6sCbFq7mTVIVUx+uUGAiea9ol6zXZRYM UN80gojq7IjsnOiSNbVVge95nWDu3Y0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv mJlhPuwW2Yp6ufMDyvAqPHE9lteJBT5M0ccSAw9UA8h6OPyrb0qgDnJcoxFK5eM24id9S7L/ xiGqy03hrM2hMEN1rmm8V2vvw9AtqQlXSZuuFyJAzvNAhdRIdf8Otf2sQSzAeNodt7xc7WXg JQTdyFyBsgqBIrFqiGCSf5l8FqBt6fca220bbKC8vAcG9WRF5yLJ9g4DNJWfh0B3iM4RNMRS BWP0T69HbcKVJZqBIcuC25LN+wkzLL7CfPuXe3OY9xFb/BZLVHZrXs0NRLAjzu3yCDAdJ3T3 r/CIa6R4YsyU/w7nFJauc9DuVPU+szO7TyKHs2qp/hW+bGfeGSUWd843KimN4gEAWLtiFu9z uuzwOPQlUoHAbOkOXOGmWPRRHhTRUUG6VnNg5Q/Xoa+zsBOQQnN19e5LWsdRrFY IronPort-HdrOrdr: A9a23:1ISy96z6NEpYLabfbXPHKrPwIL1zdoMgy1knxilNoRw8SKKlfq eV7ZAmPH7P+VAssR4b+exoVJPtfZq+z+8R3WByB8bAYOCOggLBR+sO0WKL+UyGJ8SUzI9gPM lbHJSWcOeAb2RHsQ== X-IronPort-AV: E=Sophos;i="5.96,190,1665460800"; d="scan'208";a="85079088" From: Anthony PERARD To: CC: Henry Wang , Anthony PERARD , Wei Liu Subject: [XEN PATCH maybe for-4.17] tools/include: Fix clean and rework COPYING for installed Xen public header Date: Thu, 24 Nov 2022 16:42:54 +0000 Message-ID: <20221124164254.33476-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Use actual include directory used to install the public header in COPYING file. Also, move the input file out of "tools/include/xen/" because that directory is removed on `make clean`. We can't used ./configure because $includedir contain another variable, so the change is done in Makefile. Fixes: 4ea75e9a9058 ("Rework COPYING installed in /usr/include/xen/, due to several licences") Signed-off-by: Anthony PERARD --- Notes: For 4.17 inclusion: Doing `make clean && make` in the root dir is going to fail as make isn't going to find the COPYING file while trying to install the includes. If that patch is too much, we could replace the `sed` by `cp` and just move COPYING instead of changing it. tools/include/Makefile | 1 + tools/include/{xen/COPYING => xen.COPYING.in} | 2 +- tools/include/.gitignore | 1 + tools/include/xen/.gitignore | 2 -- 4 files changed, 3 insertions(+), 3 deletions(-) rename tools/include/{xen/COPYING => xen.COPYING.in} (93%) create mode 100644 tools/include/.gitignore delete mode 100644 tools/include/xen/.gitignore diff --git a/tools/include/Makefile b/tools/include/Makefile index f838171e8c..d69aeb54bf 100644 --- a/tools/include/Makefile +++ b/tools/include/Makefile @@ -24,6 +24,7 @@ xen-foreign: xen-dir: mkdir -p xen/libelf acpi find xen/ acpi/ -type l -exec rm '{}' + + sed -e 's#@includedir@#$(includedir)/xen#g' xen.COPYING.in > xen/COPYING ln -s $(XEN_ROOT)/xen/include/public/*.h xen/ ln -s $(XEN_ROOT)/xen/include/public/*/ xen/ ln -s ../xen-sys/$(XEN_OS) xen/sys diff --git a/tools/include/xen/COPYING b/tools/include/xen.COPYING.in similarity index 93% rename from tools/include/xen/COPYING rename to tools/include/xen.COPYING.in index fe3f9b7557..25513fe529 100644 --- a/tools/include/xen/COPYING +++ b/tools/include/xen.COPYING.in @@ -1,7 +1,7 @@ XEN NOTICE ========== -This licence applies to all files within this subdirectory ("/usr/include/xen") +This licence applies to all files within this subdirectory ("@includedir@") with the exception of "sys/" which may include headers under different licences. diff --git a/tools/include/.gitignore b/tools/include/.gitignore new file mode 100644 index 0000000000..be14e3632d --- /dev/null +++ b/tools/include/.gitignore @@ -0,0 +1 @@ +/xen/ diff --git a/tools/include/xen/.gitignore b/tools/include/xen/.gitignore deleted file mode 100644 index 0628b2daf1..0000000000 --- a/tools/include/xen/.gitignore +++ /dev/null @@ -1,2 +0,0 @@ -* -!COPYING -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Nov 24 17:11:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 17:11:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448009.704758 (Exim 4.92) (envelope-from ) id 1oyFlR-0000cx-Nb; Thu, 24 Nov 2022 17:11:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448009.704758; Thu, 24 Nov 2022 17:11:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyFlR-0000cq-Jd; Thu, 24 Nov 2022 17:11:53 +0000 Received: by outflank-mailman (input) for mailman id 448009; Thu, 24 Nov 2022 17:11:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyFlP-0000ck-9g for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 17:11:51 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 140ab812-6c1b-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 18:11:49 +0100 (CET) Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Nov 2022 12:11:39 -0500 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by SA2PR03MB5724.namprd03.prod.outlook.com (2603:10b6:806:113::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Thu, 24 Nov 2022 17:11:37 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::5d4b:6b1d:efc2:20e5]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::5d4b:6b1d:efc2:20e5%9]) with mapi id 15.20.5857.019; Thu, 24 Nov 2022 17:11:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 140ab812-6c1b-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669309909; h=from:to:subject:date:message-id:mime-version; bh=SpauniP90bNGEERF77jx0JZxgJVR2pFyJSDj9YcX99M=; b=eDFrygr11ItDxKxGIvkfaASo8kZIfW9+bXDVjigMgg251ff7FQ95ba9Z Q+cuY8YGVGlEAWaSj2t0mvY0SluRiFlEL61kqBH+IeGlUUbi5qd45Fwzj CBaaioW0vUmXGZWJ2sh/6YqHdfT3gyE5C01lIkZ6pxomyf4t20/jvM/+z I=; X-IronPort-RemoteIP: 104.47.66.44 X-IronPort-MID: 88043456 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:NfF0CKIerEfUyOB7FE+RO5AlxSXFcZb7ZxGr2PjLsTEM7AuW5UVEl zVBCC3DeKqUMyGmS21FGIux9BxUusPUy4dkQAttpSpnRHhD8sSeDoWScRr7Mn2YdJCbQRpqs ZlGN4TKcpE4H3GHq0z9Y+Do/Xd1jqvZG+WU5IIoQsxUbVYMpHAJ1UIz8wJAvrNVvDSZP++sk dj5r8DUZVH7gzB+aDNKtv3c9kJktq785D5EsA1vPq0b7QPSz3UbMskSdPq7R5fariu4PcbhH rqek+vplo/9101wYj9wuu+jKiXmepaLYU7VzCITA/L56vR7jnRa+r4hM/YBYltghTyMntRgo P1ArpX1QgoyVkH2sL11vyJwTmcvY8WqxJedeSLl6JXJkxWcG5fR664G4H8ebNVwFtlfWQmix dRAQBgRYxaKgf6Bwb7TYoGAUex6caEHlKtG0p1R5Wmx4cQOGPgvcI2TjTNs5x8ih9gmIBrrT 5FxhQyDzvj3S0Yn1l8/UPrSlQoz75X1W2UwRFm9/cLb74VPpeDYPXeE3Nf9I7S3qctpckmwh 0PF2HrWWg4mH/uBzj6ownaMibHggnauMG4SPOXQGv9CpnS2nzZWLSJMEFyxrL++l1K0XM9ZJ woM4C0yoKMu9UutCN7gQxm/p33CtRkZMzZSO7RitEfRleyKvUDFWgDoTRYYADAinOA7QiYl2 xmlgtXtDCRHu7yJU3ONsLyTqFtePABFfTdePnNZE2Pp5fHer4QrlknVS+x+ToqHpITeJijx4 m6z+X1Wa7I7yJRjO7+A1UDKhXegq4bESiYx5x7LRSS14wVhfomnaoe0r1/B4p5oLYCFQ13Er HUCs8mY8O0KS5qKkUSlTOwLHbytofWEKDDGqVl1FpIl+nKm/HvLVYtQ+jBlOEBxMssePyCva 0vaowB565paPX/sZqhyC6qpBt4xxLX6PdvgX/HQKNFJZ/BZdwKZ/ScofUOZxXvqlmAri706M JGQdsC3EHIGCKJoijGxQo8107AxwTsl7XjOXp29xBOiuZKGaGOPU74DLHOHa+kr66XCqwLQm /5dMMuMjRdeeOz4fiTTt4UUKDgiMXE+DIuwqIpTe+iMMwdiMG4kAv7Vh7gmfuRNkqhan/2O/ 365V1RZwUHXlXzDKAOaLHtkbdvHdIxjoHcMGD0jNFelxVAueY+qqqwYcvMfWLA76KpY1fNyR PQfU8yaB7JETTGv0w8BYIb0tpAkVBWviQ+EJSOjbBA2epImTAvMkvf6eQ/o+DgLHzCAv8I0q L291SvWWZMGAQ9lCa7+Sv+hwRWSoHIUg+lzXGPEJcNVdV/z95JpMGr6ifpfC9oXNRzJyz+e1 gCXKRQVv+/Ap8ky6tahraKZq4akFcNuE0wcGHPUhZ6sNCDc53eix4loX+OBfDSbX2TxkI24Y u9UybfmOfsLnF9VuqJ1CbMtxqU7j/Pjv6RfzxhkNHzTYk63F6h7JX2bwchIsLYLzbhc0SO9U 1iD/dRyMryTNMToVlUWIWINYvuGytkdnzDA6vJzK0K8+Swf1KSOS0xeMBCRlCVYBLRwOYIhh +wmvaY+4Ra+gxxsLdGBgjt852WIL3oQFa4gs/kyGojhzBYs1VdGbI30BSr/4ZXJYNJJWmEgJ TWelezPnLRYy0/LdVI8EHHM2axWgpFmkBtPzVkTLk6Fst/bh+Qr1Vta9jFfZgNRzwtG3vg1P mFuPUBvOY2Q9itln45NRQiEEhpBQh/f5U31x1oPm0XWSkCpUirGK2hVEdyE/F0dtVldeDdb1 LiCzSDuVjOCVMj03zcaWEhrsfXvQNV9sArYl6iPB8WCA4N8YiDihof1YGYFoV3sBsZZrEzBv vRw8+FYc6zgODMI5as2F+Gy0rAdSwuNImBYdvhn8LkUBmHXeDy02j+mJli4f4VGIPmi2Ui8B s91L8RDTSOixT2OpTAWA60LC7Jslftv790HEpvwLmkar6SThjVsuZPUsCP5gQcDSdhoucstL Z/YcTOfFyqRghN8nm7GrMBAfG2ic9QATAT50Ka+9+BhP5cKquoqbEc936C/v3SWLBBP4RuIs RiFabW+5/55yYlqt4b8FblKAQSpLJXyU4yg+hq+tdhHa9CUaJ/muAYcq12hNANTVZMbRs5ln LCKvNno1WvKub83VybSnJzpP4lE49+jGtVeNM3fJWNf2yCFXafRDwAr/mm5LdlMj4lb78z+H Q+gMpPsKZgSRstXw2BTZ25GCREBBq/rb6Dm4ySgs/CLDRtb2gvCRD+6yULUgahgXndgE/XD5 sXc4p5COvgwQFxwOSI5 IronPort-HdrOrdr: A9a23:892SR6/hOsHqYGs5aupuk+EGdr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKRcdcKO7SdC9qBLnhNdICOwqUYtKMzOW3FdAQLsC0WKA+UypJ8SdzJ876U 4IScEXZ7PN5DNB/KXHCXyDYrMdKa68gcKVbInlr0tFfEVPUeVN/g15AgGUHglfQxRHP4MwEN 6x99dKvD2pfFUQd4CeCmMeV+bOitXXnNa+CCR2TSIP2U2rt3eF+bT6Gx+X0lM3VC5O+64r9S zoghH0/aKqttC801v523XI55pbtdP9wp8abfb8x/Q9G3HJsEKFdY5hU7qNsHQcp/yu0k8jlJ 3hsgotJMN67lLWZyWQrQH20wft/T4y4zvJyEOeg1HkvcvlLQhKQPZptMZ8SF/0+kAgtNZz3O ZgxGSCradaChvGgWDU+8XIfwsCrDv6nVMS1cooy1BPW4oXb7Fc6aYF+llOLZsGFCXmrKg6De hVCt3G7vo+SyLVU5mZhBgv/DWfZAVxIv60eDlBhiVT6UkSoJlN9TpZ+CXYpAZFyHtycegC2w 2OCNURqFgHdL5sUUs6PpZMfSL/MB2xfTvcdG2VOljpD6cBJjbErIP2+qw84KWwdIUP14Zaou W0bLvJ3VRCAX4GJPf+rqGjyCq9NVmVTHDo0IVT9pJ5srrzSP7iNjCCUkknl4+lr+8ECsPWVv 6vMNYOasWTW1fGCMJMxUnzSpNSIX4RXIkcvcs6QUuHpobOJpfxvuLWff7PLP7mECoiWGn4Hn wfNQKDU/lo/wSuQDv1kRLRU3Tidgj2+o9xCrHT+6wJxI0EJuR3w3soYJSCl7G2wBF5w9ILlR FFUc/ae4uA1BaL1HeN6Xl1MRxACUsQ6Kn8Uhpx1H43D38= X-IronPort-AV: E=Sophos;i="5.96,190,1665460800"; d="asc'?scan'208";a="88043456" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X10qd/KreOGsySyDWH8v1PgvPPzpxW9CS+5VMOeqa41ee0SoCq+7LzFBbrNoiSkMqOHzuYeAkOBUo64OXStczJxFgKK1a4BQ1AQRJhiU0GqtFaQn+esP8gj2GVqR3JMwyPbvcKzRq2XQYTuSo5ycFOkSrivoTVkP8CQshdtD7x55+V/qP/Rc0FbZrDsBez6iKTQHWRdzsnqYZcw6/nOAiLZ17bKZWqh5Zq6FQi7kVfQbkhFYZllRcPDLoV2Uh4/lkO4K//GnBdPKkwl4yzzaVptLnO/S/CnS2Zu7XPvC8s/Fpk1fvog60a1KgXeaRVS5rphV3RWvljhrl1E5hXchZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XImXIQ4asoHg3TXnol27j2c0B7b9nSI0PRtzfKJWSDo=; b=Sw2pd1TTV4OnDodnr+4rqTnGe03pQRFEYlT4Y0/NGUhhDnvMtLS+7E8ZOhxGPA/mo1c6/PUbSh3r90QkPzvWw4ebET47ozQg2fgU8BJvKm9R1cD2UapgQudgEqH4+mEQW9ndZZ5+gPztDQd17ntp6BD9bxpSCpAG1G+d8dbCuW75mflb4T7Z48Prjgh2ITc4FubrG0g2rZFBa3gPhzw1TGONOArfi2uOlcN0IqluWStZAUTDcKKG7Qu0/tb+k3r7ZnmFikfJ7b32VM22Hgd/Bt2bbjQVaaB3Hb/hEzUK4dhKcA4u+FB9SDDTaKBts+Umimpck20SbJB0UqLl/m/fkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XImXIQ4asoHg3TXnol27j2c0B7b9nSI0PRtzfKJWSDo=; b=ZYwch3r8+92CJ7Zq7U9xgBUQ+md3R1jnFVWSc9H7f0rG1+GR6ZtuL6m4zOd5qSR8S1W0LbMRXv8uDicKQ5n///72C9wleHedbgrg9zeAT/2HGyd17GEMVD51Qgebxc4eU3/cyxsM83HhdsB8rEIKvdhdoUoosBY9HoV5BuODEbk= From: George Dunlap To: Xen-devel , Tamas K Lengyel , "intel-xen@intel.com" , "daniel.kiper@oracle.com" , Roger Pau Monne , Sergey Dyasli , Christopher Clark , Rich Persaud , Kevin Pearson , Juergen Gross , =?utf-8?B?UGF1bCBEdXJyYW50wqA=?= , "Ji, John" , "edgar.iglesias@xilinx.com" , "robin.randhawa@arm.com" , Artem Mygaiev , Matt Spencer , Stewart Hildebrand , Volodymyr Babchuk , Jeff Kubascik , Stefano Stabellini , Julien Grall , Rian Quinn , "Daniel P. Smith" , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLRG91ZyBHb2xkc3RlaW4=?= , George Dunlap , David Woodhouse , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQW1pdCBTaGFo?= , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLVmFyYWQgR2F1dGFt?= , Brian Woods , Robert Townley , Bobby Eshleman , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQ29yZXkgTWlueWFyZA==?= , Olivier Lambert , Andrew Cooper , Ash Wilding , Rahul Singh , =?utf-8?B?UGlvdHIgS3LDs2w=?= , Brendan Kerrigan , "Thierry Laurion (Insurgo)" , Oleksandr Andrushchenko , Oleksandr Tyshchenko , Scott Davis , Ben Boyd , Anthony Perard , Michal Orzel , Marc Ungeschikts , Zhiming Shen , Xenia Ragiadakou , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLSGVucnkgV2FuZw==?= Subject: [ANNOUNCE] Call for agenda items for 1 December Community Call @ 1600 UTC Thread-Topic: [ANNOUNCE] Call for agenda items for 1 December Community Call @ 1600 UTC Thread-Index: AQHZACfPUq+rZUBm3UiPhFR0+p7ldg== Date: Thu, 24 Nov 2022 17:11:36 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR03MB5669:EE_|SA2PR03MB5724:EE_ x-ms-office365-filtering-correlation-id: c08161cb-8bae-4f3b-5233-08dace3ef201 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tM/myLAWfWB1p0F2WB6SdRn6+qj/4z3TuoyQJ+auDF0tQh5YhB0oKb+AyxmbmrgxcBXOWsDIx0FIpiPbdVLveTzQWppI6OIxjI8kB0zqMwxNX7lYcSU4NoYRgXH4qWMZIAqHYpp0yKguormshpwAjJcqX0upmNX7H3zNrJ0jDaeGisTIlfM+pt/f3Gdue5rNldek05baAYg1ztbnYJxLVqCLSdcPaB9BWNx2H/6XfFLHOvWX92k90Q5sArvy0bFnSHwKtphbjXGBBAwpti4qd08CVA4UE7Pi2Jv4UfnXawYfuf9kubz5PpOrq6K2/xbGWTfRxOi607R1AxUQTkiCYvEwFDXjkKiCRU2FLMJuGS+mWsoXJ2BZ+XwRjodQyAgT2ISSJdkeyVBlgQcXuiMYAkeYfDSjXTMwBWr+JCIUsNHWRLNwfxE1B6bQy+gbfJpjrpKwyoQP6QIhwknNgv6ZT5hhIluik2guAB7x/u3FMq0i+AKSN5CbJbpSUCZ/b7ax8FZ40Cb/zkucTgeIkApRqEoUKr3K20gUgfaotysZSZOXQfbSrj5h/Q5lZxrqATzCbNTmMUPNpZ1AXXG6JfpmStQIiQynk+OEYEBt5lP6BgPwx7Ts34oheKJ6rMRLLYRBs0UWfFfeiAuRmrpoQ5IKrESBXRmlRBi8tRvSMlJrkmHKDDK35OuRoAw772ppRjSbh6mcsac0jHNORiMblzLvxb6WRA+vv6IRdSw2A6alMpVSXFfctV+jjfdlqKxsU8CsTgGHaHxyzrvHX1uBSrsxcYbguANYtZ+dE6034+m8Icg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(136003)(376002)(346002)(396003)(451199015)(122000001)(38100700002)(82960400001)(99936003)(38070700005)(921005)(6512007)(86362001)(91956017)(66946007)(71200400001)(76116006)(316002)(64756008)(66446008)(66476007)(8676002)(66556008)(110136005)(5660300002)(7416002)(7406005)(2906002)(41300700001)(186003)(8936002)(966005)(83380400001)(6486002)(6506007)(478600001)(2616005)(26005)(4743002)(36756003)(33656002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SXByS3Rsa1B6N2VROUcwTDdkUmFtaDZYNUo4RzNnT3JZTmVhTHhzbElpQWU0?= =?utf-8?B?ekhVb3luSnZBUmhURnhZOWErM1ljZ29TdXQycnVhY2MyTmFsNkRlaThpbExI?= =?utf-8?B?eGhCV2JnbDFHeGh4SGllOEd5R0E2ZmdQREptTzVxUGZmWVhLdWVtbVhRVmpN?= =?utf-8?B?Z0VIWXFLdnRNcjRZL2ppcnN2ZHpnM0FiYzNJNnZLcStnSjMzcmhmQ1hNK2M4?= =?utf-8?B?MVNWM0tuR2puNkRZUnN5YW1KbEhZS2UvWG10SkZYb2lxdlFYazRCdFd0dGRG?= =?utf-8?B?Tkx4WERsekhaL0NxK1lnUzNiTHkrdFA1T2d3bFJXdGJ2eXluOTlBUWVmVTA1?= =?utf-8?B?OFM4eU1GZ0VTa2krb2MwY1krVzFnYUdoTjBaWHc4eWZsRkw1Mzd5ck5xMW1B?= =?utf-8?B?SDNtdW9zamM4NnUzdlRUblo5YzhQQjhhbENZeHhYQzZpdHdoQVpwM0xKalJz?= =?utf-8?B?TXhDZmxIeEw5MFpVR1liZzJxRS9DVUJzT2NGMmhuNHhTc2QrQyt1djZCejI5?= =?utf-8?B?VUliZlIxb1NvZmdBWmpOdnlGNTFtQU0rbDJGOUo1UmVmOU1QVmxpTGtleE5B?= =?utf-8?B?eGxBVmM5MllqVzhZT3RmM2hQZUdKTGxBR09RSUJlM1AvMVVFRnA5VmZyREpM?= =?utf-8?B?bXMzZFEzQStCaGxxa1NWWUVzOGZqUlpjVHU3em8xUWdpdWpraldZVms1dWpq?= =?utf-8?B?bk0vOUtMd0lNQWtiMGhBT3NNNXVhMUl0RlJjTHJKeDlQQkp0TVdSaFg2eHA3?= =?utf-8?B?LzEySWlvTmtQdFZiTVlQVEFKZHRwSVJCaHFWVmk0YTlWRVhDamZoT2dzd1NM?= =?utf-8?B?WUxmOVVCcEl6RStGaWQzdXZHTHhMWmFES3VMY0Z1ZmVkT1BGMkF1Z1lZcGZS?= =?utf-8?B?M3hPNHhYNEd6eVpaeU41WE1RZTlwd3RPNGlhellnLzEydmZKSTk2QzM4VHpw?= =?utf-8?B?RXU5T3Y1cmdoNG05dWpGN0o1NTgySitCcUFOQWNETGUzSGlERGRpenlLcFFq?= =?utf-8?B?cnAzRWcvR0pOZjc0VmppREpjNmZuZGMyeENwWHJoY21hRTNKOCtzL3hOcGsx?= =?utf-8?B?NU1yQXI1R1hMa2JhYXROMlYrS0VaaHJ2TnBmUTd5SWU1K25tV1BWVXhmYXd0?= =?utf-8?B?WWJZVDM5VklTKzNRZzhTUjdhdG04QmRsOWdobFd1eFRTaExzRmdWN09CZFRu?= =?utf-8?B?TjVmVTlueVFXMlR0REdUOUYxN1VCNDA0L2VhTDEwdDhyUEFpbDZSNzRFUERz?= =?utf-8?B?UFZyd1VUMTVXdEwycXllTU5OZklhYW95THBqYzlqVi9XRmJjZXBkeEZKSml0?= =?utf-8?B?OGdSWUxQc1lZNWRLdG5WV0F5YjFxSzhscXZZUVdaMUpLRVYySGh2QmpFWUMw?= =?utf-8?B?dXFsOTRBWVNjMUZTMHJTWXBvTEU3eWFmZWZFR1lwdW1VVGNseXQ2MDd3UkFi?= =?utf-8?B?Vkl5WlNaT3c5NTFrL2xXbERwOTBiRG9VRmVtcW9yaGpUUUJHWC8rUzBCRktt?= =?utf-8?B?MVFrNWxOMFVRM2hLWTUrbG92MUhZZXpwd3JWY2JLSjhWdXBSWDlLa2ltVTNG?= =?utf-8?B?Q2FBWEdzK2VCTUxZamFwekpBc1RRZnUxQlFzbFVSdlgzNnU4YmRRVVl6blkr?= =?utf-8?B?b1RHUjgyaVVQNmFZekdsWjFDdWZFdmZ1THFJNmxTdUpheENKSzVGMGhkUEh1?= =?utf-8?B?V2R3STJ2TktVWGhsdTJjY0dtaEFrVDBvNmh5R2xxU1FkWHVIQmNnMXhnUlpu?= =?utf-8?B?N1pvUE5oaU5HVGxRdHhIN2xMWExZTmhKTnhTL29tTSt0MnZxRUtNWEI0eFdE?= =?utf-8?B?c0VvM3UyMittYXl5cDYyOVpQTmZFT0hMZ1RaRVg3eTJrbnBraDgyc3BQSWFa?= =?utf-8?B?NnRiSVF2T0JybVg1bUhSVEFJekNYa1ZPclkyQi93YjN4T25jYnFPTmQwMUtR?= =?utf-8?B?d1h6ZVBDZnMvQUwzRFVHQ1ZmbWk5SjR5N3pxN3BnQXZ1bFNHaDNYeVhETGtF?= =?utf-8?B?cEFMcUFtWXMySlBtbHR5Tzg2UTZYdU5BNVFIdUswSi93OFpsMTk3bndSbUxo?= =?utf-8?B?TksweENVSk5ldmhqY1JIR2JwaWNzdklkdm5UaGFLQkJjdFZvSVp5ekZVZUVO?= =?utf-8?B?WWs2MjRDSzZLdmZLcjZkUHFTcTJOTnloaDFMVlJpcG1YRGxzOTU4N3NBSmlY?= =?utf-8?B?Unc9PQ==?= Content-Type: multipart/signed; boundary="Apple-Mail=_5CDAE7DC-8A03-4679-96C0-7C6E3BC1598E"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?4noZzajqD3kOCcozo6JTedU3FC8qQI/ZgcVR7qlfZLf6i5mNyASOSpQ0ppxU?= =?us-ascii?Q?DOJ+uSx+DSeevxp6pbX1ZWU0wiM0kSLMS/NTo3msg4e8SRaOcbJKPYd9eL6i?= =?us-ascii?Q?l4wuj3W+K9B5AYvcGrT6dqkhjOm/iIhbZUwd1Y+ZofR8p/ZvvnWFcGNmNOet?= =?us-ascii?Q?iT9Q6w+5QZ75cz2nIXAhwbvCf7f1mHTStO4imqcssmaOHNV9waQxN9JXCkNy?= =?us-ascii?Q?fiyRACuSLCX+q5hnAcFz+6RJ0eEOIZdi466v+G3+3vbKWjGCpdRZGX6gqSqR?= =?us-ascii?Q?j5YrpU0fOJIwgvuTE6QHjQGSy4kYIKtmTg9jSNzvvxufJWh5xAK7goJLRAB4?= =?us-ascii?Q?ykxze6dEGVZQJLdOGCpctc6RnvidSmsunKWlqDtPlurmbhqIg5CiaIN0Vfvm?= =?us-ascii?Q?DCziHxUwbOr99zaFQ4Z1scIO5iLUhuuL5xmTcbtbR1S/LmBfI5ITH2vKlN1m?= =?us-ascii?Q?7W7MYEgfSnixZwR5b+iRNFBAtLGRqepgyJq3V8VUIHT9n3B+fK9n4d0f9KiN?= =?us-ascii?Q?1nTrXIh0lwH+SGdcL0Jt9+Lf2+IpVWQkanoryDyIo8uDr+w+C4nzQBSEMx/U?= =?us-ascii?Q?BhAm3BSr/Gdw+pPCUncDjobpJSPBHMEUh96PYoNA0BtD37rI1XM1RQQtpRNR?= =?us-ascii?Q?OaWR9TubkEip3+V7c1b0qs/wfjEbhxV5zqmdnS4nZ7xL0heSpxi/uMCeiKLZ?= =?us-ascii?Q?MHLGTaJa7qkWYUeWkaIphaQ+v4KST6DXHk8HxtTvtohN+KMDgv6IU+8cDHfS?= =?us-ascii?Q?XzhgHyyS2EvLCBMTkucU5cYuSe1t9SPXVZbmpVg8GqpOBJ/I/d5Oh5voDlGd?= =?us-ascii?Q?BSqD3Ytj87XyXjVhNUQfAiBaVCLaIUZgL4GWY4VYZZkMJnWdcacKoyMa4wUp?= =?us-ascii?Q?2HjGwePqfJDeowSFt81iEq/u1Y7BGmaht/CLlZkIYk5GQbshJbj3P+r4xdbB?= =?us-ascii?Q?/2aliH/vaXO99vwyMbR62c6ea0Doh7ZvmmEQRp7NCWcqsiVMts4obsfzWbDz?= =?us-ascii?Q?tPiGr1PI8/p5AgRClMe7AuInM4khATquD9wBmCrT7AHJ8l59JyMSUy8toeSC?= =?us-ascii?Q?gCcL6rCQrG6qM7/9gl3EA4vOLckHfm0Rlm6e+JiiRStTLK9sjwJs/+suAzCF?= =?us-ascii?Q?VOY3kFXo2j77yvhQ74xFj+ctTAaoGwP6CWu30qc1XkWKhEZp7Z2Y7Q48gPrI?= =?us-ascii?Q?5FxgxSYi9e7bajiZsn3zXCkriHN7RZ6pQEX4z+UJL0GFc5enjqKhZtr7/PnE?= =?us-ascii?Q?dSA3qDID4YXtE/hBZO+JwL+rDPYuBurr3AHtFLfENo3OF3og1X0Ol/X1MiIV?= =?us-ascii?Q?/w4aTgu8gWBp6aQA4JqmKQnHZ02uUKfsSzMk+2oi2V6fLPhlA14ggIDN92AX?= =?us-ascii?Q?J8wQTfYxZfZ8o4Gfpr+VFeaB3cRGYKUn5VnDeKj9eLou9Wmb8V7ePm20moyY?= =?us-ascii?Q?oeb7Qn4ZHP9DhauvP85ObK/xCBkwZJT5dBE7eKGBs/io8mL8RZV0tkCkropT?= =?us-ascii?Q?V0FIXW0Z7UNMMsJngoVnA1NBxv+epoOfl0QTP/Iawod3/waOnlmtzZZ7Fz7V?= =?us-ascii?Q?NL8G8lOcUT2PbncBlo/qmREla8ThpqPm6UFsePa0vKt1JJC6MbquSm+zialb?= =?us-ascii?Q?Rg6jZiuk3VLEi02CX1Cl2RDq2EAkp9UizTrRC4ZLH8eGLrvB6zVJ8xWqXUcW?= =?us-ascii?Q?Msh+vxCyIjkHqyUmtFBzNCOTtu1htm3iz3x75oa5z8sraqDu6AFXWs12haDQ?= =?us-ascii?Q?mIWJHIfGa3UCUFVWheTeL/z7LqpJinsVTzSgWdt3Uv9DOCWsflmKWFzEZWp7?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-1: TlIWba3vImJ1LzF+tebukS5DWBAXJLu9qMnXyk6iZI7vYoAY480JKXcJZpLaGNk5NpxPs8XUGhsneAhs7LvPcbyfF9x108DW29mFdvIO4Iu09q+CSq0WAcAUCX2UMpY+0v9uStozJKq6Ue8Ne9kkNG7nGa35NI8DC5XATWqMWqVPsbCcfSCsBsZkDZpFMEwpEReqtiIVo8wmEGjFO9ePxXBIJB/PJsbMMzQ= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c08161cb-8bae-4f3b-5233-08dace3ef201 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2022 17:11:36.9176 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: km2Hgd97FyA/vt70B2t7jDhkPvzL7kebvZDZ3o66+ztVzUhFHoDzPSegXkGjq0/8CR44inSiQDRF1OlciDiU3AZoPiMO8KwcscF1kTm6QOg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5724 --Apple-Mail=_5CDAE7DC-8A03-4679-96C0-7C6E3BC1598E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi all, The proposed agenda is in = https://cryptpad.fr/pad/#/2/pad/edit/zh4Ya2wW19fSnZe8L31fGM3K/ and you = can edit to add items. Alternatively, you can reply to this mail = directly. Agenda items appreciated a few days before the call: please put your = name besides items if you edit the document. Note the following administrative conventions for the call: * Unless, agreed in the pervious meeting otherwise, the call is on the = 1st Thursday of each month at 1600 British Time (either GMT or BST) * I usually send out a meeting reminder a few days before with a = provisional agenda * To allow time to switch between meetings, we'll plan on starting the = agenda at 16:05 sharp. Aim to join by 16:03 if possible to allocate = time to sort out technical difficulties &c * If you want to be CC'ed please add or remove yourself from the = sign-up-sheet at = https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/ Best Regards George =3D=3D Dial-in Information =3D=3D ## Meeting time 16:00 - 17:00 UTC Further International meeting times: = https://www.timeanddate.com/worldclock/meetingdetails.html?year=3D2022&mon= th=3D12&day=3D1&hour=3D16&min=3D0&sec=3D0&p1=3D1234&p2=3D37&p3=3D224&p4=3D= 179 ## Dial in details Web: https://meet.jit.si/XenProjectCommunityCall Dial-in info and pin can be found here: https://meet.jit.si/static/dialInInfo.html?room=3DXenProjectCommunityCall --Apple-Mail=_5CDAE7DC-8A03-4679-96C0-7C6E3BC1598E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmN/pcIACgkQshXHp8eE G+30kAf/eeC+PB68p+a+cxhTzhQt3jCIuSlTtqvPdev3do5VCrH9yqFlswbIspwy Fv0XBjV0HukcsnTuRMR0f7n4IFL/lIwUUN6qMT6aPl1KgUUslRsi2EN5zyJqKb0i CF9o07Q4+CdpH52h0cmYwNy59fJXp+YEmz/r7hvwppvNkCqaDGhWbkQS+WVualqv 3DnvVrc+SRKjAuFL9S3yeTlM1gYMwBN4wGRDpOstqnDmtGANGOvwdPCVky9uTmrf zbCEyFb0YKPOKfVYbSuRaROEb5bLoixOUtBjI6Q3rQbMbNLy+ebcWETYClnZJSdg ZA/2ppA70KaEhJR/ZpTynAc4cQ4hFg== =bCNa -----END PGP SIGNATURE----- --Apple-Mail=_5CDAE7DC-8A03-4679-96C0-7C6E3BC1598E-- From xen-devel-bounces@lists.xenproject.org Thu Nov 24 18:50:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 18:50:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448014.704769 (Exim 4.92) (envelope-from ) id 1oyHII-00033W-VG; Thu, 24 Nov 2022 18:49:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448014.704769; Thu, 24 Nov 2022 18:49:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHII-00033P-SE; Thu, 24 Nov 2022 18:49:54 +0000 Received: by outflank-mailman (input) for mailman id 448014; Thu, 24 Nov 2022 18:49:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHIH-00033J-Mc for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 18:49:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHIG-0003Nk-8X; Thu, 24 Nov 2022 18:49:52 +0000 Received: from [54.239.6.186] (helo=[192.168.1.238]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oyHIG-0006Cl-1m; Thu, 24 Nov 2022 18:49:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=I7QK9bQURq7cZDyBF41gqN4GR3AANlENWhJ7s/fmpbc=; b=LTgr58Skwm443A0wH/hNGTDP/M 6vHaC55Y/9XGwqz9yTXl8u/03NXJniaeH2WJ+0E229WwQiyUDVl3AoLL5LVAy6LXDW5JnXgp5K5mR tajr3Ta9pAyK3yV+6zYHcoAvrDlw45uHH3FCx/44UPevcERsh2k8XVlfNVtb+Vgly4LM=; Message-ID: <557ea713-ffc9-7117-460d-a21b2331d87a@xen.org> Date: Thu, 24 Nov 2022 19:49:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] xen/arm: Fix unreachable panic for vpl011 vIRQ Content-Language: en-US To: Bertrand Marquis , Michal Orzel Cc: Xen developer discussion , Stefano Stabellini , Volodymyr Babchuk References: <20221123143913.6527-1-michal.orzel@amd.com> <29E29CB0-35F8-4961-9197-14E8CD7C43CA@arm.com> From: Julien Grall In-Reply-To: <29E29CB0-35F8-4961-9197-14E8CD7C43CA@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 23/11/2022 16:22, Bertrand Marquis wrote: >> On 23 Nov 2022, at 14:39, Michal Orzel wrote: >> >> When creating direct mapped domU, the vIRQ for vpl011 is taken from >> the SERHND_DTUART serial port using serial_irq. This function can return >> -1 (i.e. no interrupt found) in which case we should call a panic. >> However, vpl011_virq is defined as unsigned int which causes the panic >> to be unreachable, because less than zero comparison of an unsigned value >> can never be true. Fix it by defining vpl011_virq as int. >> >> Fixes: 3580c8b2dfc3 ("xen/arm: if direct-map domain use native UART address and IRQ number for vPL011") >> Signed-off-by: Michal Orzel > Reviewed-by: Bertrand Marquis I have committed it in a branch for-next/4.18 which will be merged once the tree reopened. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Nov 24 18:50:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 18:50:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448017.704779 (Exim 4.92) (envelope-from ) id 1oyHIx-0004Ma-83; Thu, 24 Nov 2022 18:50:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448017.704779; Thu, 24 Nov 2022 18:50:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHIx-0004MT-5R; Thu, 24 Nov 2022 18:50:35 +0000 Received: by outflank-mailman (input) for mailman id 448017; Thu, 24 Nov 2022 18:50:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHIv-0004MN-JU for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 18:50:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHIv-0003OX-6L; Thu, 24 Nov 2022 18:50:33 +0000 Received: from [54.239.6.186] (helo=[192.168.1.238]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oyHIu-0006DP-W7; Thu, 24 Nov 2022 18:50:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=quuE02vogMuiDZiAXQUyR695Sh6wYPgHfrStJ3fHoo8=; b=ZaCDEi9/ZnMDe2wGmyGbW63DPc G58vOtqatJabvoLduBvGhfmLoFo1YWgwY/n1r2UDYsCn5W/DiJqMhNnTrMlHLSm4Je/NQUgvqA7vJ a4s24EZrKcjmWKi+UewCKHgEzjdzWX8VOBR02UcX+GLiEiB9zFPsPzne2qxjy80mS2pw=; Message-ID: Date: Thu, 24 Nov 2022 19:50:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN v3 02/12] xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32 Content-Language: en-US To: Michal Orzel , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, jgrall@amazon.com, burzalodowa@gmail.com References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-3-ayan.kumar.halder@amd.com> <8086e3ac-445b-17a1-bba3-078024ab2579@amd.com> <4045f91a-620a-98b0-d3c7-28af1b0ba4a8@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23/11/2022 10:35, Michal Orzel wrote: > Hi Julien, > > On 22/11/2022 21:31, Julien Grall wrote: >> >> >> On 17/11/2022 13:39, Michal Orzel wrote: >>> Hi Ayan, >>> >>> On 11/11/2022 15:17, Ayan Kumar Halder wrote: >>>> Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169 >>>> Affinity level 3 is not present in AArch32. >>>> Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106, >>>> Affinity level 3 is not present in Armv7 (ie arm32). >>>> Thus, any access to affinity level 3 needs to be guarded within >>>> "ifdef CONFIG_ARM_64". >>>> >>>> Signed-off-by: Ayan Kumar Halder >>> Reviewed-by: Michal Orzel >>> >>> although, IMO the commit msg does not reflect the change (i.e. you do nothing >>> related to accessing MPIDR, but instead you are just not taking the Aff3 into account for AArch32). >>> Also, I'm not sure why you used VMPIDR and not MPIDR. >> >> +1. Can one of you propose an improved commit message/title? > Title: "Do not calculate affinity level 3 for AArch32" Sounds good to me. > > I think the commit message can stay as it is. >> >> I would be happy to update the patch on commit if there are nothing else >> to update in this series. > The series requires re-spinning anyway so no need to update the patch on commit. Fine with that. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Nov 24 18:52:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 18:52:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448020.704791 (Exim 4.92) (envelope-from ) id 1oyHKX-0005AW-Jm; Thu, 24 Nov 2022 18:52:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448020.704791; Thu, 24 Nov 2022 18:52:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHKX-0005AP-Gg; Thu, 24 Nov 2022 18:52:13 +0000 Received: by outflank-mailman (input) for mailman id 448020; Thu, 24 Nov 2022 18:52:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHKW-0005AJ-83 for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 18:52:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHKV-0003QJ-Sk; Thu, 24 Nov 2022 18:52:11 +0000 Received: from [54.239.6.186] (helo=[192.168.1.238]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oyHKV-0006GZ-Lz; Thu, 24 Nov 2022 18:52:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=4hm5ltLUskAzu5oJuQnbEyKp5mV9SegUzVCWODnvs9U=; b=D/VR1u/tQG0Fb4Sm4J9+2lTukj 1zzEiKw8CbRprMx5Eb+t92i93EOooUlmQjZIn5XrfV3DuRUEq3RWQ9KbOmaJPIhrF+DYV5ROCU7VN R0w0BhTgxQ0s+4Qdj+834tGNnAF1zFYbrM6aI/dBOl0sySSokOiy6C13vihOixcbdtX8=; Message-ID: <4d50f93d-4811-ab44-0022-44d4832c6618@xen.org> Date: Thu, 24 Nov 2022 19:52:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 0/3] Early printk code cleanup Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221118114618.20754-1-michal.orzel@amd.com> From: Julien Grall In-Reply-To: <20221118114618.20754-1-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 18/11/2022 12:46, Michal Orzel wrote: > This patch series performs simple early printk code cleanup around PL011. > No functional changes has been made. > > Michal Orzel (3): > xen/arm: Drop early_uart_init macro from debug-meson.inc > xen/arm: debug-pl011.inc: Use macros instead of hardcoded values > xen/arm: Define WLEN_8 macro and use it in debug-pl011 I have committed everything in a branch for-next/4.18 which will be merged once the tree re-open. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Nov 24 18:57:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 18:57:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448026.704802 (Exim 4.92) (envelope-from ) id 1oyHPV-0005q2-76; Thu, 24 Nov 2022 18:57:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448026.704802; Thu, 24 Nov 2022 18:57:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHPV-0005pv-2S; Thu, 24 Nov 2022 18:57:21 +0000 Received: by outflank-mailman (input) for mailman id 448026; Thu, 24 Nov 2022 18:57:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHPS-0005pp-QU for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 18:57:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHPS-0003VV-Dr; Thu, 24 Nov 2022 18:57:18 +0000 Received: from [54.239.6.186] (helo=[192.168.1.238]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oyHPS-0006Ug-7S; Thu, 24 Nov 2022 18:57:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=yR+6Qol7h/zbe2k8iJ4QBQVvzuit0LZY6iElvEjKmpU=; b=jJZZhdLly97TW07FsvCRadJyhs WdMGww22ae4CQYuJJ8TziGG4UoojH6OjKoBb7qHoma2cMIrnx2bPM1MZIvFpRCxG/q/U8X1E9Rj1p qLo5nPYFvPuFiQ1tKCiZAfEisTkFcTwnMW67KW2tR9Z8L6gVn5XSTiXzaaZ2V+NO1Vts=; Message-ID: Date: Thu, 24 Nov 2022 19:57:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2] xen/arm: Do not route NS phys timer IRQ to Xen Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221028124937.27677-1-michal.orzel@amd.com> From: Julien Grall In-Reply-To: <20221028124937.27677-1-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 28/10/2022 14:49, Michal Orzel wrote: > At the moment, we route NS phys timer IRQ to Xen even though it does not > make use of this timer. Xen uses hypervisor timer for itself and the > physical timer is fully emulated, hence there is nothing that can trigger > such IRQ. This means that requesting/releasing IRQ ends up as a deadcode > as it has no impact on the functional behavior, whereas the code within > a handler ends up being unreachable. This is a left over from the early > days when the CNTHP IRQ was buggy on the HW model used for testing and we > had to use the CNTP instead. > > Remove the calls to {request/release}_irq for this timer as well as the > code within the handler. Since timer_interrupt handler is now only used > by the CNTHP, refactor it as follows: > - rename it to htimer_interrupt to reflect its purpose, > - remove the IRQ affiliation test, > - invert the condition to avoid indented code and use unlikely, > - improve readability by adding new lines \btw code and comments. > > Keep the calls to zero the CNTP_CTL_EL0 register for sanity and also > remove the corresponding perf counter definition. > > Signed-off-by: Michal Orzel Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Nov 24 19:09:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 19:09:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448030.704812 (Exim 4.92) (envelope-from ) id 1oyHah-0007Ze-6O; Thu, 24 Nov 2022 19:08:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448030.704812; Thu, 24 Nov 2022 19:08:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHah-0007ZX-3m; Thu, 24 Nov 2022 19:08:55 +0000 Received: by outflank-mailman (input) for mailman id 448030; Thu, 24 Nov 2022 19:08:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHag-0007ZR-3y for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 19:08:54 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHaf-0003iL-SV; Thu, 24 Nov 2022 19:08:53 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oyHaf-00074F-IJ; Thu, 24 Nov 2022 19:08:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=wblOyOaomIbApi0HQcEovhAkEWUwzbqG2eynKc7y0Q8=; b=vEVlTs 1jvN4aRnPZaIVvnj/EG3vLUncHFOgr5zowrlvePdC3Q76Q3g91LdmqNm9TMHvKRB76WNyqnJHZUFB BVneQy1Jw5fe+iB0ykeLnSaAlmgIOGJHn/8LkM9CJWO93Fb9yqfPM+FLJ6Tc8vCUyvp401YQ/K5rx jlOWRk3/sXo=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated Date: Thu, 24 Nov 2022 19:08:50 +0000 Message-Id: <20221124190850.35344-1-julien@xen.org> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Explain how the banner in README is generated and take the opportunity to mention what it should look like for RC. Signed-off-by: Julien Grall ---- Changes in v2: - Mention what the banner looks like for RC. --- docs/process/release-technician-checklist.txt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/process/release-technician-checklist.txt b/docs/process/release-technician-checklist.txt index 7515da202c92..5031d1bd2288 100644 --- a/docs/process/release-technician-checklist.txt +++ b/docs/process/release-technician-checklist.txt @@ -48,7 +48,12 @@ t=RELEASE-$r * consider bumping sonames of shlibs -* change xen-unstable README (should say "Xen 4.5" in releases and on stable branches, "Xen 4.5-unstable" on unstable) +* change xen-unstable README. Should say: + - "Xen 4.5" in releases and on stable branches + - "Xen 4.5-unstable" on unstable + - "Xen 4.5-rc" for release candidate + +* The banner is generated using figlet * change xen-unstable Config.mk # QEMU_UPSTREAM_REVISION, # QEMU_TRADITIONAL_REVISION -- 2.37.1 From xen-devel-bounces@lists.xenproject.org Thu Nov 24 19:19:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 19:19:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448034.704824 (Exim 4.92) (envelope-from ) id 1oyHkk-0000pj-6C; Thu, 24 Nov 2022 19:19:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448034.704824; Thu, 24 Nov 2022 19:19:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHkk-0000pc-33; Thu, 24 Nov 2022 19:19:18 +0000 Received: by outflank-mailman (input) for mailman id 448034; Thu, 24 Nov 2022 19:19:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHki-0000pW-RG for xen-devel@lists.xen.org; Thu, 24 Nov 2022 19:19:16 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e158948a-6c2c-11ed-8fd2-01056ac49cbb; Thu, 24 Nov 2022 20:19:15 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHke-00042F-22; Thu, 24 Nov 2022 19:19:12 +0000 Received: from [54.239.6.186] (helo=[192.168.1.238]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oyHkd-0007XS-RR; Thu, 24 Nov 2022 19:19:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e158948a-6c2c-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=7LkqjOngDsmt1vHQJQpK0c7MEk/z00Zc1oBFYxn4XeU=; b=62EHk/powPg0zY7vML0SxCL9MJ S5yl1Rk3ZSEbAExowDDgGp0Mn7u/1toaQS4m1Vn4qE5NSp3EGvrboVbEwY5pOg776gYKuJpMkzFDu oAGLWiJFrscHowwgBPPnovjVD1CNB+Z+l0zdLSTg2q4uKxKQzh+V82rHPtHtwsfLmRN0=; Message-ID: <4bb29058-3133-bc66-ea33-8077f91a473b@xen.org> Date: Thu, 24 Nov 2022 20:19:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH V6.1 3/3] libxl: arm: make creation of iommu node independent of disk device Content-Language: en-US From: Julien Grall To: Viresh Kumar , Anthony PERARD Cc: xen-devel@lists.xen.org, Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross References: <099616e1092409fceea4eb30590215310f8c091c.1662626550.git.viresh.kumar@linaro.org> <20220920102915.p55lt4ee5hbxiun2@vireshk-i7> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Viresh, On 04/10/2022 11:59, Julien Grall wrote: > On 20/09/2022 11:29, Viresh Kumar wrote: >> On 09-09-22, 16:02, Anthony PERARD wrote: >>> On Fri, Sep 09, 2022 at 08:13:28PM +0530, Viresh Kumar wrote: >>>> The iommu node will be required for other virtio device types too, not >>>> just disk device. >>>> >>>> Move the call to make_xen_iommu_node(), out of the disk device specific >>>> block and rename "iommu_created" variable to "iommu_needed", and set it >>>> to true for virtio disk device. >>>> >>>> Signed-off-by: Viresh Kumar >>> >>> Reviewed-by: Anthony PERARD >> >> I don't see these patches being applied yet, do I need to ping someone >> for that ? > > We are currently preparing to release Xen 4.17 (plan for November) and > have stopped accepting new code (other than bug fix) since the beginning > of September. > > Your series will be committed once the tree is re-opened (hopefully by > the beginning of November). Please ping me mid-november if this is still > not applied. Unfortunately, we had some delay for releasing 4.17. So I have pushed this series in a branch for-next/4.18. This will be applied to staging once the tree has re-opened. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Nov 24 19:38:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 19:38:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448038.704835 (Exim 4.92) (envelope-from ) id 1oyI3J-0003gh-NM; Thu, 24 Nov 2022 19:38:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448038.704835; Thu, 24 Nov 2022 19:38:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyI3J-0003ga-Jy; Thu, 24 Nov 2022 19:38:29 +0000 Received: by outflank-mailman (input) for mailman id 448038; Thu, 24 Nov 2022 19:38:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyI3I-0003gM-59; Thu, 24 Nov 2022 19:38:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyI3I-0004LP-2Z; Thu, 24 Nov 2022 19:38:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyI3H-0007An-KN; Thu, 24 Nov 2022 19:38:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oyI3H-00060t-Js; Thu, 24 Nov 2022 19:38:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=k75CTQywsSAL/8ImVL7QjO6Mff+dY55y/KPVofM28co=; b=SiDy+ZQzsgP9jhxGVa1C18JbdK /KKC7RggJRfVAU3JBpvx8dnzu0XNF+qGhBhFXl8eIXH/wk3w+wdJSQOTQkHFwT3zIeD4Cy9mkxVx0 lytPir27U/rd+3D3xXAPAdw/vR7h7YCqH/KN/NBcSWA9hUYhWqaZVymx0EyMmTa7HWX8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174955: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-multivcpu::broken:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:host-install(5):broken:heisenbug linux-linus:test-arm64-arm64-xl-thunderx:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c3eb11fbb826879be773c137f281569efce67aa8 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 24 Nov 2022 19:38:27 +0000 flight 174955 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174955/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu broken test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail in 174951 REGR. vs. 173462 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 5 host-install(5) broken pass in 174951 test-arm64-arm64-xl-thunderx 8 xen-boot fail in 174951 pass in 174955 test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail in 174951 pass in 174955 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux c3eb11fbb826879be773c137f281569efce67aa8 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 48 days Failing since 173470 2022-10-08 06:21:34 Z 47 days 87 attempts Testing same since 174951 2022-11-24 04:02:04 Z 0 days 2 attempts ------------------------------------------------------------ 1806 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu broken test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-multivcpu broken broken-step test-armhf-armhf-xl-multivcpu host-install(5) Not pushing. (No revision log; it would be 171867 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Nov 24 20:43:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 20:43:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448045.704846 (Exim 4.92) (envelope-from ) id 1oyJ4R-0003nF-Ba; Thu, 24 Nov 2022 20:43:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448045.704846; Thu, 24 Nov 2022 20:43:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyJ4R-0003n8-92; Thu, 24 Nov 2022 20:43:43 +0000 Received: by outflank-mailman (input) for mailman id 448045; Thu, 24 Nov 2022 20:43:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyJ4P-0003n1-SJ for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 20:43:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyJ4O-0005wx-SG; Thu, 24 Nov 2022 20:43:40 +0000 Received: from [54.239.6.186] (helo=[192.168.1.238]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oyJ4O-0002Hx-Df; Thu, 24 Nov 2022 20:43:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=2Ser2/vS9I1VzfOjq65CZnNQn7qaITtgLJHyw1zNUwM=; b=zFZVwFykNJaFxWYD8wZRds/dyF hqu1NNrnFf0VGRkV63sznnhQIaXdOQpcRU73GpLK/dPYAWPkOnf0PcOLaTJxO7s6vx6GxyfVdjksY KuhcMJ65j99n+FGX/cHP3fXFdKkRbssKO+uSMpJpcBvsuzQVJy3FZchUqLUzGDlSHhXo=; Message-ID: <0bb8ed7b-df73-48c1-350a-f067cd928d36@xen.org> Date: Thu, 24 Nov 2022 21:43:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 01/10] unify update_runstate_area() Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 19/10/2022 09:38, Jan Beulich wrote: > x86'es variant is a superset of Arm's, with CONFIG_COMPAT parts already > properly marked. The only other missing piece is > update_guest_memory_policy(): For the time being Arm simply gains an > empty struct and inline function. > > Signed-off-by: Jan Beulich Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Nov 24 21:30:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 24 Nov 2022 21:30:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448050.704858 (Exim 4.92) (envelope-from ) id 1oyJnA-0000XO-Pv; Thu, 24 Nov 2022 21:29:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448050.704858; Thu, 24 Nov 2022 21:29:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyJnA-0000XH-LP; Thu, 24 Nov 2022 21:29:56 +0000 Received: by outflank-mailman (input) for mailman id 448050; Thu, 24 Nov 2022 21:29:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyJn9-0000XB-Dx for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 21:29:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyJn7-0006s0-Lj; Thu, 24 Nov 2022 21:29:53 +0000 Received: from [54.239.6.186] (helo=[192.168.1.238]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oyJn7-0003w8-Ej; Thu, 24 Nov 2022 21:29:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=VxbrYK7WZDIG0H7Mg3eWIuTmq1Wga6d6EunaCC48low=; b=fHGP/RqIPY56bsNtl1f5fgShLz ZUSt0rnqMlnvmU5ij/hscOj+CCou0igRcPKlGU/Z1kcr934c0tr4vegDeibdFo+5X7HNtHWHg5/YK w5N1izH/Xd1vU0ZgSQxg3NtgWVGzhg6SQHt1EXY+cmLLCGSMG6UlVBoaqEIozOcjm8K8=; Message-ID: Date: Thu, 24 Nov 2022 22:29:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH RFC 07/10] domain: map/unmap GADDR based shared guest areas Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <5a571fd9-b0c2-216e-a444-102397a22ca0@suse.com> From: Julien Grall In-Reply-To: <5a571fd9-b0c2-216e-a444-102397a22ca0@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, I am still digesting this series and replying with some initial comments. On 19/10/2022 09:43, Jan Beulich wrote: > The registration by virtual/linear address has downsides: At least on > x86 the access is expensive for HVM/PVH domains. Furthermore for 64-bit > PV domains the areas are inaccessible (and hence cannot be updated by > Xen) when in guest-user mode. > > In preparation of the introduction of new vCPU operations allowing to > register the respective areas (one of the two is x86-specific) by > guest-physical address, flesh out the map/unmap functions. > > Noteworthy differences from map_vcpu_info(): > - areas can be registered more than once (and de-registered), > - remote vCPU-s are paused rather than checked for being down (which in > principle can change right after the check), > - the domain lock is taken for a much smaller region. > > Signed-off-by: Jan Beulich > --- > RFC: By using global domain page mappings the demand on the underlying > VA range may increase significantly. I did consider to use per- > domain mappings instead, but they exist for x86 only. Of course we > could have arch_{,un}map_guest_area() aliasing global domain page > mapping functions on Arm and using per-domain mappings on x86. Yet > then again map_vcpu_info() doesn't do so either (albeit that's > likely to be converted subsequently to use map_vcpu_area() anyway). > > RFC: In map_guest_area() I'm not checking the P2M type, instead - just > like map_vcpu_info() - solely relying on the type ref acquisition. > Checking for p2m_ram_rw alone would be wrong, as at least > p2m_ram_logdirty ought to also be okay to use here (and in similar > cases, e.g. in Argo's find_ring_mfn()). p2m_is_pageable() could be > used here (like altp2m_vcpu_enable_ve() does) as well as in > map_vcpu_info(), yet then again the P2M type is stale by the time > it is being looked at anyway without the P2M lock held. > > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -1563,7 +1563,82 @@ int map_guest_area(struct vcpu *v, paddr > struct guest_area *area, > void (*populate)(void *dst, struct vcpu *v)) > { > - return -EOPNOTSUPP; > + struct domain *currd = v->domain; > + void *map = NULL; > + struct page_info *pg = NULL; > + int rc = 0; > + > + if ( gaddr ) 0 is technically a valid (guest) physical address on Arm. > + { > + unsigned long gfn = PFN_DOWN(gaddr); This could be gfn_t for adding some type safety. > + unsigned int align; > + p2m_type_t p2mt; > + > + if ( gfn != PFN_DOWN(gaddr + size - 1) ) > + return -ENXIO; > + > +#ifdef CONFIG_COMPAT > + if ( has_32bit_shinfo(currd) ) > + align = alignof(compat_ulong_t); > + else > +#endif > + align = alignof(xen_ulong_t); > + if ( gaddr & (align - 1) ) > + return -ENXIO; > + > + rc = check_get_page_from_gfn(currd, _gfn(gfn), false, &p2mt, &pg); > + if ( rc ) > + return rc; > + > + if ( !get_page_type(pg, PGT_writable_page) ) > + { > + put_page(pg); > + return -EACCES; > + } > + > + map = __map_domain_page_global(pg); > + if ( !map ) > + { > + put_page_and_type(pg); > + return -ENOMEM; > + } > + map += PAGE_OFFSET(gaddr); > + } > + > + if ( v != current ) > + { > + if ( !spin_trylock(&currd->hypercall_deadlock_mutex) ) > + { > + rc = -ERESTART; > + goto unmap; > + } > + > + vcpu_pause(v); AFAIU, the goal of vcpu_pause() here is to guarantee that the "area" will not be touched by another pCPU. However, looking at the function context_switch() we have: sched_context_switched(prev, next); _update_runstate_area(); The first function will set v->is_running to false (see vcpu_context_saved()). So I think the "area" could be touched even afte vcpu_pause() is returned. Therefore, I think we will need _update_runstate_area() (or update_runstate_area()) to be called first. > + > + spin_unlock(&currd->hypercall_deadlock_mutex); > + } > + > + domain_lock(currd); > + > + if ( map ) > + populate(map, v); > + > + SWAP(area->pg, pg); > + SWAP(area->map, map); > + > + domain_unlock(currd); > + > + if ( v != current ) > + vcpu_unpause(v); > + > + unmap: > + if ( pg ) > + { > + unmap_domain_page_global(map); > + put_page_and_type(pg); > + } > + > + return rc; > } > > /* > @@ -1573,6 +1648,22 @@ int map_guest_area(struct vcpu *v, paddr > */ > void unmap_guest_area(struct vcpu *v, struct guest_area *area) > { > + struct domain *d = v->domain; > + void *map; > + struct page_info *pg; AFAIU, the assumption is the vCPU should be paused here. Should we add an ASSERT()? > + > + domain_lock(d); > + map = area->map; > + area->map = NULL; > + pg = area->pg; > + area->pg = NULL; > + domain_unlock(d); > + > + if ( pg ) > + { > + unmap_domain_page_global(map); > + put_page_and_type(pg); > + } > } > > int default_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg) > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Nov 25 03:41:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 03:41:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448056.704868 (Exim 4.92) (envelope-from ) id 1oyPaE-00017m-96; Fri, 25 Nov 2022 03:40:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448056.704868; Fri, 25 Nov 2022 03:40:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyPaE-00017e-3T; Fri, 25 Nov 2022 03:40:58 +0000 Received: by outflank-mailman (input) for mailman id 448056; Fri, 25 Nov 2022 03:40:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyPaD-00017U-9v; Fri, 25 Nov 2022 03:40:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyPaD-0005iD-7U; Fri, 25 Nov 2022 03:40:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyPaC-000634-O9; Fri, 25 Nov 2022 03:40:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oyPaC-00085b-NU; Fri, 25 Nov 2022 03:40:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fvpzs35cJz/wgDELuGPtTYjc3bH6TUVZlMc9gK7Zo/M=; b=0E6YX7uyrqVJTYnTMcCnELRBwH wnVxyTONA1xrc1kX4Nd5UZxkN2AaNyJ9eP2C3TTAG96DA025DeUtVOP8UXGluOSoFffIsesdaJXX+ sPoiu8QsJM1ExsXal7Ewo5uxquLUNH7/140xlcVOP++K/xx6KeMSVtQy8cH3sH4oCEBg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174957: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=08ad43d554bacb9769c6a69d5f771f02f5ba411c X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Fri, 25 Nov 2022 03:40:56 +0000 flight 174957 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174957/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux 08ad43d554bacb9769c6a69d5f771f02f5ba411c baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 48 days Failing since 173470 2022-10-08 06:21:34 Z 47 days 88 attempts Testing same since 174957 2022-11-24 20:12:25 Z 0 days 1 attempts ------------------------------------------------------------ 1854 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 175887 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Nov 25 05:30:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 05:30:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448062.704878 (Exim 4.92) (envelope-from ) id 1oyRIP-0006Nl-Nw; Fri, 25 Nov 2022 05:30:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448062.704878; Fri, 25 Nov 2022 05:30:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyRIP-0006Ne-LD; Fri, 25 Nov 2022 05:30:41 +0000 Received: by outflank-mailman (input) for mailman id 448062; Fri, 25 Nov 2022 05:30:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyRIO-0006NY-32 for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 05:30:40 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a2f3590-6c82-11ed-91b6-6bf2151ebd3b; Fri, 25 Nov 2022 06:30:38 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 264761FD75; Fri, 25 Nov 2022 05:30:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CDE9413A12; Fri, 25 Nov 2022 05:30:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TXt7MPtSgGMbWAAAMHmgww (envelope-from ); Fri, 25 Nov 2022 05:30:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a2f3590-6c82-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669354236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=88uKl92ebkgW4xCfynUJfJUKnkrtYfGljU1DfjG9VQg=; b=gNQhFWS9haTEh+HmH6jPevmBycsdYIiFCyyZGGwAriCT/BN40ORV440WmJ/gudbMIlVlln bzDpqqeeuaqaOlu66XlMLnr0f72brPPpbWCxK7oKNeHh9nT6Q5GdnDHXjLY7OvC/qdhWm9 t2kM9owU64e2UTc2LgqAbZ1/n/qqzpI= Message-ID: Date: Fri, 25 Nov 2022 06:30:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: objtool warning for next-20221118 Content-Language: en-US To: Josh Poimboeuf Cc: Andrew Cooper , Peter Zijlstra , "Paul E. McKenney" , "sfr@canb.auug.org.au" , "linux-kernel@vger.kernel.org" , "sstabellini@kernel.org" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , Thomas Gleixner References: <20221121145215.GF4001@paulmck-ThinkPad-P17-Gen-1> <20221122051605.4hcbslwxez2trdvt@treble> <20221123012350.kelmmadh65lyswqz@treble> <2255c45f-d8ba-3f32-9d99-737ad3040dd7@citrix.com> <20221123170337.keacggyvn4ykbtsw@treble> <20221124023934.nft3udxelth4lvai@treble> <72a4871b-3ee8-42c1-912a-321a45690428@suse.com> <68dc479a-6b61-0012-888d-c1b4cc513cdb@suse.com> <20221124163928.dof5ldfer6rswlnx@treble> From: Juergen Gross In-Reply-To: <20221124163928.dof5ldfer6rswlnx@treble> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------hAyibYhyr4A7ecLZFcdKC0Nj" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------hAyibYhyr4A7ecLZFcdKC0Nj Content-Type: multipart/mixed; boundary="------------sgBAI0d3A9g4VqHeAPIzWML0"; protected-headers="v1" From: Juergen Gross To: Josh Poimboeuf Cc: Andrew Cooper , Peter Zijlstra , "Paul E. McKenney" , "sfr@canb.auug.org.au" , "linux-kernel@vger.kernel.org" , "sstabellini@kernel.org" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , Thomas Gleixner Message-ID: Subject: Re: objtool warning for next-20221118 References: <20221121145215.GF4001@paulmck-ThinkPad-P17-Gen-1> <20221122051605.4hcbslwxez2trdvt@treble> <20221123012350.kelmmadh65lyswqz@treble> <2255c45f-d8ba-3f32-9d99-737ad3040dd7@citrix.com> <20221123170337.keacggyvn4ykbtsw@treble> <20221124023934.nft3udxelth4lvai@treble> <72a4871b-3ee8-42c1-912a-321a45690428@suse.com> <68dc479a-6b61-0012-888d-c1b4cc513cdb@suse.com> <20221124163928.dof5ldfer6rswlnx@treble> In-Reply-To: <20221124163928.dof5ldfer6rswlnx@treble> --------------sgBAI0d3A9g4VqHeAPIzWML0 Content-Type: multipart/mixed; boundary="------------sqdMXuE7w70eh96fVGaMpLu3" --------------sqdMXuE7w70eh96fVGaMpLu3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjQuMTEuMjIgMTc6MzksIEpvc2ggUG9pbWJvZXVmIHdyb3RlOg0KPiBPbiBUaHUsIE5v diAyNCwgMjAyMiBhdCAwODo0Nzo0N0FNICswMTAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K Pj4+PiArKysgYi9hcmNoL3g4Ni94ZW4vc21wX3B2LmMNCj4+Pj4gQEAgLTM4NSwxNyArMzg1 LDkgQEAgc3RhdGljIHZvaWQgeGVuX3B2X3BsYXlfZGVhZCh2b2lkKSAvKiB1c2VkIG9ubHkN Cj4+Pj4gd2l0aCBIT1RQTFVHX0NQVSAqLw0KPj4+PiAgwqAgew0KPj4+PiAgwqDCoMKgwqDC oCBwbGF5X2RlYWRfY29tbW9uKCk7DQo+Pj4+ICDCoMKgwqDCoMKgIEhZUEVSVklTT1JfdmNw dV9vcChWQ1BVT1BfZG93biwgeGVuX3ZjcHVfbnIoc21wX3Byb2Nlc3Nvcl9pZCgpKSwgTlVM TCk7DQo+Pj4+IC3CoMKgwqAgY3B1X2JyaW5ndXAoKTsNCj4+Pj4gLcKgwqDCoCAvKg0KPj4+ PiAtwqDCoMKgwqAgKiBjb21taXQgNGIwYzBmMjk0ICh0aWNrOiBDbGVhbnVwIE5PSFogcGVy IGNwdSBkYXRhIG9uIGNwdSBkb3duKQ0KPj4+PiAtwqDCoMKgwqAgKiBjbGVhcnMgY2VydGFp biBkYXRhIHRoYXQgdGhlIGNwdV9pZGxlIGxvb3AgKHdoaWNoIGNhbGxlZCB1cw0KPj4+PiAt wqDCoMKgwqAgKiBhbmQgdGhhdCB3ZSByZXR1cm4gZnJvbSkgZXhwZWN0cy4gVGhlIG9ubHkg d2F5IHRvIGdldCB0aGF0DQo+Pj4+IC3CoMKgwqDCoCAqIGRhdGEgYmFjayBpcyB0byBjYWxs Og0KPj4+PiAtwqDCoMKgwqAgKi8NCj4+Pj4gLcKgwqDCoCB0aWNrX25vaHpfaWRsZV9lbnRl cigpOw0KPj4+PiAtwqDCoMKgIHRpY2tfbm9oel9pZGxlX3N0b3BfdGlja19wcm90ZWN0ZWQo KTsNCj4+Pj4gLcKgwqDCoCBjcHVocF9vbmxpbmVfaWRsZShDUFVIUF9BUF9PTkxJTkVfSURM RSk7DQo+Pj4+ICvCoMKgwqAgLyogRklYTUU6IGNvbnZlcmdlIGNwdV9icmluZ3VwX2FuZF9p ZGxlKCkgYW5kIHN0YXJ0X3NlY29uZGFyeSgpICovDQo+Pj4+ICvCoMKgwqAgY3B1X2JyaW5n dXBfYW5kX2lkbGUoKTsNCj4+Pg0KPj4+IEkgdGhpbmsgdGhpcyB3aWxsIGxlYWsgc3RhY2sg bWVtb3J5LiBNdWx0aXBsZSBjcHUgb2ZmbGluZS9vbmxpbmUgY3ljbGVzIG9mDQo+Pj4gdGhl IHNhbWUgY3B1IHdpbGwgZmluYWxseSBleGhhdXN0IHRoZSBpZGxlIHN0YWNrLg0KPiANCj4g RG9oISAgT2YgY291cnNlLi4uDQo+IA0KPiBJIHdhcyBhY3R1YWxseSB0aGlua2luZyBhaGVh ZCwgdG8gd2hlcmUgZXZlbnR1YWxseSB4ZW5fcHZfcGxheV9kZWFkKCkNCj4gY2FuIGNhbGwg c3RhcnRfY3B1MCgpLCB3aGljaCBjYW4gYmUgY2hhbmdlZCB0byBhdXRvbWF0aWNhbGx5IHJl c2V0IHRoZQ0KPiBzdGFjayBwb2ludGVyIGxpa2UgdGhpczoNCj4gDQo+IFNZTV9DT0RFX1NU QVJUKHN0YXJ0X2NwdTApDQo+IAlBTk5PVEFURV9OT0VOREJSDQo+IAlVTldJTkRfSElOVF9F TVBUWQ0KPiAJbW92cQlQRVJfQ1BVX1ZBUihwY3B1X2hvdCArIFg4Nl90b3Bfb2Zfc3RhY2sp LCAlcmF4DQo+IAlsZWFxCS1QVFJFR1NfU0laRSglcmF4KSwgJXJzcA0KPiAJam1wCS5ManVt cF90b19DX2NvZGUNCj4gU1lNX0NPREVfRU5EKHN0YXJ0X2NwdTApDQo+IA0KPiBidXQgdGhh dCB3b3VsZCBvbmx5IGJlIHBvc3NpYmxlIGJlIGFmdGVyIG1vcmUgY2xlYW51cHMgd2hpY2gg Y29udmVyZ2UNCj4gY3B1X2JyaW5ndXBfYW5kX2lkbGUoKSB3aXRoIHN0YXJ0X3NlY29uZGFy eSgpLg0KPiANCj4+IFRoZSBhdHRhY2hlZCBwYXRjaCBzZWVtcyB0byB3b3JrIGZpbmUuDQo+ IA0KPiBUaGUgcGF0Y2ggbG9va3MgZ29vZCB0byBtZS4NCj4gDQo+IEl0IGRvZXNuJ3Qgc29s dmUgUGF1bCdzIG9yaWdpbmFsIGlzc3VlIHdoZXJlIGFyY2hfY3B1X2lkbGVfZGVhZCgpIG5l ZWRzDQo+IHRvIGJlIF9fbm9yZXR1cm4uICBCdXQgdGhhdCBzaG91bGQgcHJvYmFibHkgYmUg YSBzZXBhcmF0ZSBwYXRjaCBhbnl3YXkuDQoNCk9rYXksIEknbGwgc3BsaXQgdGhpcyBvZmYu DQoNCj4gDQo+PiBUaGUgX19ub3JldHVybiBhbm5vdGF0aW9uIHNlZW1zIHRvIHRyaWdnZXIg YW4gb2JqdG9vbCB3YXJuaW5nLCB0aG91Z2gsIGluDQo+PiBzcGl0ZSBvZiB0aGUgYWRkZWQg QlVHKCkgYXQgdGhlIGVuZCBvZiB4ZW5fcHZfcGxheV9kZWFkKCk6DQo+Pg0KPj4gYXJjaC94 ODYveGVuL3NtcF9wdi5vOiB3YXJuaW5nOiBvYmp0b29sOiB4ZW5fcHZfcGxheV9kZWFkKCkg ZmFsbHMgdGhyb3VnaCB0bw0KPj4gbmV4dCBmdW5jdGlvbiB4ZW5fcHZfY3B1X2RpZSgpDQo+ IA0KPiBZb3UnbGwgbmVlZCB0byB0ZWxsIG9ianRvb2wgdGhhdCB4ZW5fY3B1X2JyaW5ndXBf YWdhaW4oKSBpcyBub3JldHVybiBieQ0KPiBhZGRpbmcgInhlbl9jcHVfYnJpbmd1cF9hZ2Fp biIgdG8gZ2xvYmFsX25vcmV0dXJuc1tdIGluDQo+IHRvb2xzL29ianRvb2wvY2hlY2suYy4N Cg0KQWgsIG9rYXkuIFdpbGwgZG8gdGhhdC4NCg0KPiAoWWVzIGl0J3MgYSBwYWluLCBJJ2xs IGJlIHdvcmtpbmcgYW4gaW1wcm92ZWQgc29sdXRpb24gdG8gdGhlIG5vcmV0dXJuDQo+IHRo aW5nLi4uKQ0KDQpTaG91bGQgYmUgZmFpcmx5IGVhc3ksIG5vPw0KDQoiSnVzdCIgZXh0ZW5k IHRoZSBfX25vcmV0dXJuIG1hY3JvIHRvIHB1dCB0aGUgZnVuY3Rpb24gaW50byBhICIudGV4 dC5ub3JldHVybiINCnNlY3Rpb24sIHdoaWNoIGNhbiBiZSBoYW5kbGVkIGluIGEgc3BlY2lh bCB3YXkgYnkgb2JqdG9vbC4gVGhpcyB3b3VsZCBuZWVkDQphbiBfX2luaXRfbm9yZXR1cm4g bWFjcm8sIG9mIGNvdXJzZSwgZm9yIGEgIi5pbml0LnRleHQubm9yZXR1cm4iIHNlY3Rpb24u DQoNCg0KSnVlcmdlbg0K --------------sqdMXuE7w70eh96fVGaMpLu3 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------sqdMXuE7w70eh96fVGaMpLu3-- --------------sgBAI0d3A9g4VqHeAPIzWML0-- --------------hAyibYhyr4A7ecLZFcdKC0Nj Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmOAUvsFAwAAAAAACgkQsN6d1ii/Ey99 NQf7BmHH332gwhKhoHMmyH2fJlV2mW4kUysbTkREGK8MH5oXtlQqrDZ2fcUXajJg6v32QZvYPWoY d07a9Rsng2/dnajCUy7sHzlz25ZDTE4ICoRVlim8wWkp7bB70QOp4+PfZhq44cmzhm4k64QBl2NL nhRs4aFFLm6OadniJsaLt+Q+TC5yagRW/hVz5q6/vrcusx67jSpgMdHVULZUlXD+nkfynpK/hn1B PfeMLqsa98kqvCWRq/9MtnEZwznpgnK0nfIRb/JxXGTxlOHs+dmnZVtwnPzzWUJ9m0dr8QgiJxOq /3iDS2KMouZwD07YYxtCnPEJwhNHpuRTZKjDKLbdpw== =/tpz -----END PGP SIGNATURE----- --------------hAyibYhyr4A7ecLZFcdKC0Nj-- From xen-devel-bounces@lists.xenproject.org Fri Nov 25 05:45:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 05:45:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448067.704890 (Exim 4.92) (envelope-from ) id 1oyRWl-0008BU-3k; Fri, 25 Nov 2022 05:45:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448067.704890; Fri, 25 Nov 2022 05:45:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyRWk-0008BN-Vt; Fri, 25 Nov 2022 05:45:30 +0000 Received: by outflank-mailman (input) for mailman id 448067; Fri, 25 Nov 2022 05:45:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyRWi-0008BG-UZ for xen-devel@lists.xen.org; Fri, 25 Nov 2022 05:45:28 +0000 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [2607:f8b0:4864:20::42d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5cacda09-6c84-11ed-8fd2-01056ac49cbb; Fri, 25 Nov 2022 06:45:27 +0100 (CET) Received: by mail-pf1-x42d.google.com with SMTP id z26so3254267pff.1 for ; Thu, 24 Nov 2022 21:45:27 -0800 (PST) Received: from localhost ([122.172.85.60]) by smtp.gmail.com with ESMTPSA id b5-20020a170902650500b0018869119e37sm2328119plk.142.2022.11.24.21.45.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 21:45:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5cacda09-6c84-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7HZ8OUJUAq25bYOAIiGC3xhCTFKen4gp0/1QuhpI3ug=; b=vJXbU7afS6b52El5psHWXltrmjmnpXo50qDyOJ4aXP70VwW+DGoxRAdnyDIION2Joy NCqSRs+wDhWnE0Z/c64UI1dFQUqjYSjFSHdk5/JA6m/rSmtQN6mkkQT4SMRWm7yr2+BQ OGbFrNAf/j5wAuLtoquFn//dVBOZQDLGjdkaiQxwYxZkg/bkRP6+Qi1tVKu/YQnwCeVu W0EYqyx3Sgc/c813Q4eN69V1pIfxHaBdMxu4bu1cPuUux3fnsm5zqmzz+sx7DqT+ChC4 HyJ08lAUCnoKZbzIjAIVIc8gCb2Ro88ciunLPW+uubVlfwMO2wst3bi/NsIGs34B8tT4 0UyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7HZ8OUJUAq25bYOAIiGC3xhCTFKen4gp0/1QuhpI3ug=; b=F/rp28axO3+eWmdmakd1th/4NStEwfNypF25FMQESarqCB40bUz6q6HmBCV7MiHiQV CSYJA73o4W93gqlOhGMM2dcmGpzauYEjP25sWqG4xwooXmgMIPhSIR5mrTWr2rxlWmfa 87IQ8xQUclxY3PtDmCdooLQGaw1WHoWKPd/etJpUdpvkOOb+4rgPxgCdIaSWyABjyMWM SMSgrKNDMhpqb6+DLvFXFocT0zvUA3DHGEnZgDwgv8B8YgVKeGWWEuBZRQM5MVxQM3+W Y6Qh4CqJTPjuTtMITAYbz5D/aSmyb5oPDpHA2P0ZfBZWvvqc+Xfbsuu0li1cC9XtmeOk fmkA== X-Gm-Message-State: ANoB5pnrXmGUwICOTUJFQ+FU6MPAbB6MNcJYmQ3hqikC8cGonj/9tcVB wsdd198XFXwQO6KxAax6iesEEg== X-Google-Smtp-Source: AA0mqf4ymq5C33EZdr6vCJxDT/zQ7MTjvkv4t47ZDCpH7FHl4DrCIgNxPI2e1gulAK+aORL8EMn2ig== X-Received: by 2002:a65:6c11:0:b0:477:2bc0:f1b with SMTP id y17-20020a656c11000000b004772bc00f1bmr14735885pgu.566.1669355125810; Thu, 24 Nov 2022 21:45:25 -0800 (PST) Date: Fri, 25 Nov 2022 11:15:22 +0530 From: Viresh Kumar To: Julien Grall Cc: Anthony PERARD , xen-devel@lists.xen.org, Vincent Guittot , stratos-dev@op-lists.linaro.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross Subject: Re: [PATCH V6.1 3/3] libxl: arm: make creation of iommu node independent of disk device Message-ID: <20221125054522.wjsv3lcb5tdk2dd5@vireshk-i7> References: <099616e1092409fceea4eb30590215310f8c091c.1662626550.git.viresh.kumar@linaro.org> <20220920102915.p55lt4ee5hbxiun2@vireshk-i7> <4bb29058-3133-bc66-ea33-8077f91a473b@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4bb29058-3133-bc66-ea33-8077f91a473b@xen.org> On 24-11-22, 20:19, Julien Grall wrote: > Unfortunately, we had some delay for releasing 4.17. So I have pushed this > series in a branch for-next/4.18. Thanks. > This will be applied to staging once the > tree has re-opened. I don't see the branch here though. Is it not public yet ? Or should I be looking at a different tree ? https://github.com/xen-project/xen -- viresh From xen-devel-bounces@lists.xenproject.org Fri Nov 25 06:33:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 06:33:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448072.704912 (Exim 4.92) (envelope-from ) id 1oySGj-0006HE-Ss; Fri, 25 Nov 2022 06:33:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448072.704912; Fri, 25 Nov 2022 06:33:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oySGj-0006H7-Po; Fri, 25 Nov 2022 06:33:01 +0000 Received: by outflank-mailman (input) for mailman id 448072; Fri, 25 Nov 2022 06:33:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oySGj-0006Fz-2P for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 06:33:01 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ff7fcff1-6c8a-11ed-8fd2-01056ac49cbb; Fri, 25 Nov 2022 07:32:57 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8491D1FD78; Fri, 25 Nov 2022 06:32:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4120D13A08; Fri, 25 Nov 2022 06:32:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7omwDphhgGM2cgAAMHmgww (envelope-from ); Fri, 25 Nov 2022 06:32:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff7fcff1-6c8a-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669357976; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ziIK+rCoFeI7eY+iutr/3xmiOnoDvSfijRGI/bUo88Y=; b=E3Fu0Kx3qoRkBQP7xpdpuPfIY0XXiBlnHN2HzddWNJ01CNIBeFOmXue54a24INdZsrAsiU ek/AWAyMzXpzM4tipyL9lbaO5ZvFSpy1VhRiokrYjoEsm71TE+OD/AcGjq3k+9iGnc7p0t XWLO2MwgkHNNWCpTfSFuTbJ3wLM9sFQ= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org Subject: [PATCH 1/2] x86/xen: don't let xen_pv_play_dead() return Date: Fri, 25 Nov 2022 07:32:47 +0100 Message-Id: <20221125063248.30256-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221125063248.30256-1-jgross@suse.com> References: <20221125063248.30256-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A function called via the paravirt play_dead() hook should not return to the caller. xen_pv_play_dead() has a problem in this regard, as it currently will return in case an offlined cpu is brought to life again. This can be changed only by doing basically a longjmp() to cpu_bringup_and_idle(), as the hypercall for bringing down the cpu will just return when the cpu is coming up again. Just re-initializing the cpu isn't possible, as the Xen hypervisor will deny that operation. So introduce xen_cpu_bringup_again() resetting the stack and calling cpu_bringup_and_idle(), which can be called after HYPERVISOR_vcpu_op() in xen_pv_play_dead(). Signed-off-by: Juergen Gross --- arch/x86/xen/smp.h | 2 ++ arch/x86/xen/smp_pv.c | 13 ++----------- arch/x86/xen/xen-head.S | 7 +++++++ 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/arch/x86/xen/smp.h b/arch/x86/xen/smp.h index bd02f9d50107..6e90a312067b 100644 --- a/arch/x86/xen/smp.h +++ b/arch/x86/xen/smp.h @@ -21,6 +21,8 @@ void xen_smp_send_reschedule(int cpu); void xen_smp_send_call_function_ipi(const struct cpumask *mask); void xen_smp_send_call_function_single_ipi(int cpu); +void xen_cpu_bringup_again(unsigned long stack); + struct xen_common_irq { int irq; char *name; diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c index 480be82e9b7b..b40b24382fe3 100644 --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -385,17 +385,8 @@ static void xen_pv_play_dead(void) /* used only with HOTPLUG_CPU */ { play_dead_common(); HYPERVISOR_vcpu_op(VCPUOP_down, xen_vcpu_nr(smp_processor_id()), NULL); - cpu_bringup(); - /* - * commit 4b0c0f294 (tick: Cleanup NOHZ per cpu data on cpu down) - * clears certain data that the cpu_idle loop (which called us - * and that we return from) expects. The only way to get that - * data back is to call: - */ - tick_nohz_idle_enter(); - tick_nohz_idle_stop_tick_protected(); - - cpuhp_online_idle(CPUHP_AP_ONLINE_IDLE); + xen_cpu_bringup_again((unsigned long)task_pt_regs(current)); + BUG(); } #else /* !CONFIG_HOTPLUG_CPU */ diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S index ffaa62167f6e..e36ea4268bd2 100644 --- a/arch/x86/xen/xen-head.S +++ b/arch/x86/xen/xen-head.S @@ -76,6 +76,13 @@ SYM_CODE_START(asm_cpu_bringup_and_idle) call cpu_bringup_and_idle SYM_CODE_END(asm_cpu_bringup_and_idle) + +SYM_CODE_START(xen_cpu_bringup_again) + UNWIND_HINT_FUNC + mov %rdi, %rsp + UNWIND_HINT_REGS + call cpu_bringup_and_idle +SYM_CODE_END(xen_cpu_bringup_again) .popsection #endif #endif -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 25 06:33:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 06:33:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448071.704901 (Exim 4.92) (envelope-from ) id 1oySGb-00060L-K9; Fri, 25 Nov 2022 06:32:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448071.704901; Fri, 25 Nov 2022 06:32:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oySGb-00060E-HM; Fri, 25 Nov 2022 06:32:53 +0000 Received: by outflank-mailman (input) for mailman id 448071; Fri, 25 Nov 2022 06:32:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oySGb-000608-3r for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 06:32:53 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fc4e32b2-6c8a-11ed-91b6-6bf2151ebd3b; Fri, 25 Nov 2022 07:32:51 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D2DD61FD6A; Fri, 25 Nov 2022 06:32:50 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6DC2B13A08; Fri, 25 Nov 2022 06:32:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fllnGZJhgGMicgAAMHmgww (envelope-from ); Fri, 25 Nov 2022 06:32:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc4e32b2-6c8a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669357970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=fZrAaP9FxcQcpFDkMAFfQgOSXJ+0iWC8i07BQBQ2SXo=; b=qAMYWpJANmBzfUWnws2e+o51bVKp5OfZVCLdN1sqq6oUe7plzRkRxFH7v1ti+YPOfKqDij DeqpeP5zWgrZ+zlIuvzVqn/rGFayVzBoQ8uHZB36Zy2RxspaDt63/0Ry37qukLJfQslZGt m/vD0GB7HhzRyhYNuyATnQ0xKCggbNQ= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Josh Poimboeuf , Peter Zijlstra Subject: [PATCH 0/2] x86/xen: don't return from xen_pv_play_dead() Date: Fri, 25 Nov 2022 07:32:46 +0100 Message-Id: <20221125063248.30256-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit All play_dead() functions but xen_pv_play_dead() don't return to the caller. Adapt xen_pv_play_dead() to behave like the other play_dead() variants. Juergen Gross (2): x86/xen: don't let xen_pv_play_dead() return x86/xen: mark xen_pv_play_dead() as __noreturn arch/x86/xen/smp.h | 2 ++ arch/x86/xen/smp_pv.c | 17 ++++------------- arch/x86/xen/xen-head.S | 7 +++++++ tools/objtool/check.c | 1 + 4 files changed, 14 insertions(+), 13 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 25 06:33:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 06:33:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448073.704923 (Exim 4.92) (envelope-from ) id 1oySGn-0006YS-4g; Fri, 25 Nov 2022 06:33:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448073.704923; Fri, 25 Nov 2022 06:33:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oySGn-0006YL-1K; Fri, 25 Nov 2022 06:33:05 +0000 Received: by outflank-mailman (input) for mailman id 448073; Fri, 25 Nov 2022 06:33:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oySGl-0006Fz-C8 for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 06:33:03 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 02f2b2db-6c8b-11ed-8fd2-01056ac49cbb; Fri, 25 Nov 2022 07:33:02 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4FA8421ABF; Fri, 25 Nov 2022 06:33:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E857813A08; Fri, 25 Nov 2022 06:33:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pwBBN51hgGNAcgAAMHmgww (envelope-from ); Fri, 25 Nov 2022 06:33:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02f2b2db-6c8b-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669357982; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sjhgFpq3nYstNjfYRzieZLbVirxwSh2gasV8m6EaAKQ=; b=WDct/+NCNMhDQE3uXaBL1eSMquJ+aAJ6SOdEfs5IVwH8j5P+SVyd/tSR+tBqNwQ3iidDPA qPLL8VKJZ6WUWyuleQ3KgkLtaxQHEHncfn9DIQ4xJeQ4EfmNCi9HqoUZ/c1BxcyVk5gkh2 WQGx86OgKF1EFuwnDxgcDw86HtASnuk= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Josh Poimboeuf , Peter Zijlstra , xen-devel@lists.xenproject.org Subject: [PATCH 2/2] x86/xen: mark xen_pv_play_dead() as __noreturn Date: Fri, 25 Nov 2022 07:32:48 +0100 Message-Id: <20221125063248.30256-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221125063248.30256-1-jgross@suse.com> References: <20221125063248.30256-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Mark xen_pv_play_dead() and related to that xen_cpu_bringup_again() as "__noreturn". Signed-off-by: Juergen Gross --- arch/x86/xen/smp.h | 2 +- arch/x86/xen/smp_pv.c | 4 ++-- tools/objtool/check.c | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/x86/xen/smp.h b/arch/x86/xen/smp.h index 6e90a312067b..22fb982ff971 100644 --- a/arch/x86/xen/smp.h +++ b/arch/x86/xen/smp.h @@ -21,7 +21,7 @@ void xen_smp_send_reschedule(int cpu); void xen_smp_send_call_function_ipi(const struct cpumask *mask); void xen_smp_send_call_function_single_ipi(int cpu); -void xen_cpu_bringup_again(unsigned long stack); +void __noreturn xen_cpu_bringup_again(unsigned long stack); struct xen_common_irq { int irq; diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c index b40b24382fe3..5801f93d567c 100644 --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -381,7 +381,7 @@ static void xen_pv_cpu_die(unsigned int cpu) } } -static void xen_pv_play_dead(void) /* used only with HOTPLUG_CPU */ +static void __noreturn xen_pv_play_dead(void) /* used only with HOTPLUG_CPU */ { play_dead_common(); HYPERVISOR_vcpu_op(VCPUOP_down, xen_vcpu_nr(smp_processor_id()), NULL); @@ -400,7 +400,7 @@ static void xen_pv_cpu_die(unsigned int cpu) BUG(); } -static void xen_pv_play_dead(void) +static void __noreturn xen_pv_play_dead(void) { BUG(); } diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 43ec14c29a60..becdedc2de99 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -189,6 +189,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, "snp_abort", "stop_this_cpu", "usercopy_abort", + "xen_cpu_bringup_again", "xen_start_kernel", }; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Nov 25 08:10:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 08:10:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448090.704934 (Exim 4.92) (envelope-from ) id 1oyTnE-0002lx-HC; Fri, 25 Nov 2022 08:10:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448090.704934; Fri, 25 Nov 2022 08:10:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyTnE-0002lq-DK; Fri, 25 Nov 2022 08:10:40 +0000 Received: by outflank-mailman (input) for mailman id 448090; Fri, 25 Nov 2022 08:10:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyTnD-0002lg-Ib; Fri, 25 Nov 2022 08:10:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyTnD-00049K-G4; Fri, 25 Nov 2022 08:10:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyTnC-0004zv-UU; Fri, 25 Nov 2022 08:10:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oyTnC-0005W8-U2; Fri, 25 Nov 2022 08:10:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iFqicvkkY5Ya9MaFtpHOGWsvbiDVFmP75Cugyuf7oe8=; b=t3OnmMAONE3VDiVbFFwoPedP5o RTdPUAaOz/IuAOxifAmxhy8Y4CXWJFFN5w6Bq2d/xINdTpHQla0Wn7WeqLgObixEwEHUv9jWJ+2dR 11qQgeJHIiy75aFxdhOsAfyXtHbpgv8niqKmTikKoFU/YpTZbwUnwlNRk3Oa03OVW4z0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174958: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-amd64-migrupgrade::broken:regression xen-unstable:build-arm64-pvops:kernel-build:fail:regression xen-unstable:test-amd64-amd64-migrupgrade:host-install/dst_host(7):broken:heisenbug xen-unstable:test-amd64-i386-xl-vhd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-pair:xen-install/dst_host:fail:nonblocking xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=345135942bf9632eba1409ba432cfcae3b7649c7 X-Osstest-Versions-That: xen=345135942bf9632eba1409ba432cfcae3b7649c7 From: osstest service owner Date: Fri, 25 Nov 2022 08:10:38 +0000 flight 174958 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174958/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-migrupgrade broken build-arm64-pvops 6 kernel-build fail in 174950 REGR. vs. 174958 Tests which are failing intermittently (not blocking): test-amd64-amd64-migrupgrade 7 host-install/dst_host(7) broken pass in 174950 test-amd64-i386-xl-vhd 7 xen-install fail in 174950 pass in 174958 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 174950 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 174950 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 174950 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 174950 n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked in 174950 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 174950 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 174950 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 174950 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 174950 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 174950 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 174950 n/a test-amd64-i386-pair 11 xen-install/dst_host fail like 174950 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail like 174950 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174950 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174950 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174950 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174950 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174950 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174950 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174950 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174950 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174950 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174950 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174950 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174950 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 345135942bf9632eba1409ba432cfcae3b7649c7 baseline version: xen 345135942bf9632eba1409ba432cfcae3b7649c7 Last test of basis 174958 2022-11-25 01:53:14 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade broken test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-migrupgrade broken broken-step test-amd64-amd64-migrupgrade host-install/dst_host(7) Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri Nov 25 08:42:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 08:42:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448102.704945 (Exim 4.92) (envelope-from ) id 1oyUI1-0006uA-2h; Fri, 25 Nov 2022 08:42:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448102.704945; Fri, 25 Nov 2022 08:42:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUI0-0006u3-Vs; Fri, 25 Nov 2022 08:42:28 +0000 Received: by outflank-mailman (input) for mailman id 448102; Fri, 25 Nov 2022 08:42:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUHz-0006tx-C8 for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 08:42:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUHy-0004wg-Sp; Fri, 25 Nov 2022 08:42:26 +0000 Received: from [54.239.6.184] (helo=[192.168.1.18]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oyUHy-0006bX-JP; Fri, 25 Nov 2022 08:42:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=3w8RZjfjM7HOri5SFXtIlWFVQRX/ulTsNJ9C8cE5Ozc=; b=TEM4/TJyaJoMXxeCrG5UI+DIzw lzRKDC6pf5cm9vuV+iXI+JzWzI6etF6dZp4YSFOHhdyKZ1Sv+TvoSj4ubFyqaOxauZN6NlHl8a6Ar XZAgy+Iy7ehnBm/x0kuNS8NwuzaVZaQ++7kfrth5qxXfvftNLqEUoB2clfvQMPMikDtY=; Message-ID: Date: Fri, 25 Nov 2022 09:42:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN v3 12/12] xen/Arm: GICv3: Enable GICv3 for AArch32 Content-Language: en-US To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com, jgrall@amazon.com, burzalodowa@gmail.com References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-13-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: <20221111141739.2872-13-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 11/11/2022 15:17, Ayan Kumar Halder wrote: > One can now use GICv3 on AArch32 systems. However, ITS is not supported. > The reason being currently we are trying to validate GICv3 on an AArch32_v8R > system. Refer ARM DDI 0568A.c ID110520, B1.3.1, > "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE must not > implement LPI support." > > By default GICv3 is disabled on AArch32 and enabled on AArch64. > > Updated SUPPORT.md to state that GICv3 on Arm32 is not security supported. > > Signed-off-by: Ayan Kumar Halder > --- > > Changed from :- > v1 - 1. Remove "ARM_64 || ARM_32" as it is always true. > 2. Updated SUPPORT.md. > > v2 - 1. GICv3 is enabled by default only on ARM_64. > 2. Updated SUPPORT.md. > > SUPPORT.md | 7 +++++++ > xen/arch/arm/Kconfig | 9 +++++---- > xen/arch/arm/include/asm/cpufeature.h | 1 + > 3 files changed, 13 insertions(+), 4 deletions(-) > > diff --git a/SUPPORT.md b/SUPPORT.md > index ab71464cf6..3f16d83191 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -82,6 +82,13 @@ Extension to the GICv3 interrupt controller to support MSI. > > Status: Experimental > > +### ARM/GICv3 > + > +GICv3 is an interrupt controller specification designed by Arm. > + > + Status, Arm64: Security supported > + Status, Arm32: Supported, not security supported > + > ## Guest Type > > ### x86/PV > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 1fe5faf847..b90930955b 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -9,6 +9,7 @@ config ARM_64 > select 64BIT > select ARM_EFI > select HAS_FAST_MULTIPLY > + select GICV3 AFAIU "select" will force the GICV3 to be enabled. IOW, it would not be possible to disable it for Arm64 anymore. You want to remove the "select" and ... > > config ARM > def_bool y > @@ -41,16 +42,16 @@ config ARM_EFI > > config GICV3 > bool "GICv3 driver" > - depends on ARM_64 && !NEW_VGIC > - default y > + depends on !NEW_VGIC > + default n ... replace the "default n" with: default n if ARM_32 default y if ARM_64 > ---help--- > > Driver for the ARM Generic Interrupt Controller v3. > - If unsure, say Y > + If unsure, say N That's technically incorrect. For Arm64, we still want the user to select it by default. So I think we need to differentiate 32-bit vs 64-bit for the "If unsure" part. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Nov 25 08:44:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 08:44:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448105.704956 (Exim 4.92) (envelope-from ) id 1oyUJa-0007R7-EL; Fri, 25 Nov 2022 08:44:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448105.704956; Fri, 25 Nov 2022 08:44:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUJa-0007R0-BX; Fri, 25 Nov 2022 08:44:06 +0000 Received: by outflank-mailman (input) for mailman id 448105; Fri, 25 Nov 2022 08:44:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUJY-0007Qs-Ow for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 08:44:04 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0604.outbound.protection.outlook.com [2a01:111:f400:fe0e::604]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5022530a-6c9d-11ed-91b6-6bf2151ebd3b; Fri, 25 Nov 2022 09:44:03 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8563.eurprd04.prod.outlook.com (2603:10a6:20b:422::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Fri, 25 Nov 2022 08:44:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.020; Fri, 25 Nov 2022 08:44:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5022530a-6c9d-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l5WYWl++bdF2J7RukIjxz5pUjrDZ8F5L36dFLlrKmFmwdHOP4Tqvf6kfQRKHGHi4+AI368xZ98R1BlRsw6of3iLWrATKvkcnOWoiKzjrSVFJgO5eG17WiHu1yXdTYNgZCWHjId/Ji7FA2DrP51fHXOh1NZ0TXVO4hn2di/s/dwAWD21yynMYVDbXUDrg4bwmvM3pmqSForD7sIOsovStm0bxSUhs0sB0BjfWW2jPUiws4gwjs2jLGBv24SJ6n+17kBr1HoPb9V2KZSqWK5DebSA/k7G5WkCTfxvsUnnLi73wBXt3Zoczr9uVoTgTphYSpgGckS0WCuTOKa/NYn/bQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sNO0OoUqwmpTxsu+T5m5itKfKI+xNFgcstOiM5jmLIY=; b=hHmoI8zsWLF/WAqIBwJ1SgqcalYH/dpTjhTbBaWZ9I8XZI2VloVvQNlo+DuApq3qiuOBwVPVakh/d8NCPeY02Yfm/JfMETiBcUazZY058+FJH/K53T1fWsPcgCSgyWIIr2wkS9qhUJbKJ+eoP/x+gx+lKHTju/y/CoE7kZsOaQ63ytroxTlRJXR22Lbuwi52j/iFO5p2PvTicrxpVUzw9rQ3dLLtLAarj6zKFWMFBL6t2Bs4gy0izFRTZt7MzxdxEFNucvcF5AZfAWXrdC6QMEiiVFNwP/yO570hba0HBTC7c+oSkt2Nbtopjo/nZ8K1H/dlz+GcfjnLI3qklzejeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sNO0OoUqwmpTxsu+T5m5itKfKI+xNFgcstOiM5jmLIY=; b=bIPFFngm9Tybyq/IHc50lwxGm28LPg0y+LQs+d4r9VtorvQs+e9JkR6WbCa/beq+MLPwMibMRVA623LDjzaD9I93HID9nRdErpcD7O7f26R7s4gBGOtgdi4xBF0J+XeSqfws/uSOaGx2oxOZEHUjMp5PvbSujPIjYojE4EhtgaydBtBShylJV7dbK8SpuGLI8U1PLiuzi0XnClzZYri36bzcmYXwMwzqe6sGUTUS6RCXGvgqVUmPofohjYA2+9OKqbPhDEBrBcLGlenzU0AxYPDTg0DJOkzHE2y/HdXwR0ee5HgCzk4Ua6xL85daQzxLahbRILa2IuFlPhAJgZL89g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <516fb872-bc79-ad8a-233b-b821265c1911@suse.com> Date: Fri, 25 Nov 2022 09:43:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" References: <878e635f-b116-3580-945f-f8acb711a5bc@suse.com> <69507b8d-1f31-39fb-7469-e240fbfdde44@citrix.com> <33a005bf-0596-c624-0e70-077a450ac2ae@suse.com> <351a6e54-8002-aef0-993a-c6b8bdcc1e8e@suse.com> <3f3bced7-62e8-4ff2-655d-aed222f343a9@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0126.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8563:EE_ X-MS-Office365-Filtering-Correlation-Id: 96d5b1c9-6acb-43a1-f153-08dacec132d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GUhHsfh+6n3kVS8xMki2lu9CuoxMlcyBmjSVb6qBYvWfqfBy0Q0JWKYbeuOgSwOH6SoL8ahCBDoSs/9m6wMCld2NaY4hqJIUFPmKBd/IoGs/p/WDxygzo3lK8ZsX4o2JFguwMrd/DUV/1649r9gbV4SC8d3xqLZeOMrbktXwvUZLEayVW2H8YSJAqhcJLKP3p7KeUQF3adCIMDvQ9aitJ+9WDnXCv02Z4Bmyz6y0qrAThFygin5IYVKlzqadhrEwN3EN8O9UR2k9BoUiPPZmMQch7GJmLZFBm0SRXOFk/HUmaiiRs7DLpola8oi5/O+CHTBgvCYt9VL7Mc/Cl7qOk4rIpEsI7nJxRjoRmFvoQqZZqyrCIKYsUVwVI98O9wUX06rbAgk2bQHQ3CbviQ+/se6y79OSPx6yFOuH9JovioiLJfNMF/flHaP0VTuA0njlvPo5IHqHRXGZHvGlzIfII7jrUFhPPuS5axGCADMNvevN8Gr13wP45xQWXr7f5FA7OPIzenqe7dX+EiNMg2mnHHrs574APUw+G/2ItPiGKDuY0mclivyJ/2XdoIBamLHO1uYtYerpFNG6MNe85npI+eCqL+y9ECktWO915udt4ePAkYMUxGLiX4Mx7Y0vaQiqM4AM4ypnAThHrBi3o0nQ38iXoFLHu7cQORTyV4XYkVs9GL5qrbmkQI5WothTdJQwDz4GWGAIPqOdQezLAnO9vw6YeuwVK79mX1L4MsBX+C5BJOc5WNdtQ7ADqaHWr0sG790fqD9joXfRpVEiLV4iyw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(136003)(346002)(366004)(39860400002)(451199015)(36756003)(86362001)(31696002)(6486002)(478600001)(966005)(6506007)(53546011)(66556008)(5660300002)(41300700001)(4326008)(66946007)(8936002)(316002)(6916009)(8676002)(6512007)(2906002)(66476007)(54906003)(26005)(38100700002)(186003)(2616005)(83380400001)(31686004)(66899015)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXpYQXVoUk8raGhRRGlDQzNDMzB6bXZxTzBkUlNaQnpZTGxPK0wvd1lENUVr?= =?utf-8?B?Y1B1S0k3dE55djFFaTBsWTd6dWFOcEtKZUpiMW9vUkdaMlZRdDhHY1NaYXBi?= =?utf-8?B?V0VubVc2c0xMdjh4T1NjSUJKeVdkU3hsdjZHUXQwdjlHckZtdEZaYVhkQ2Zz?= =?utf-8?B?VU8vR2NTVVc0T2kzbVR0QXFaNWlWdEtWQXlrcDcvSkY0UjdtaXVCSXY1b3BR?= =?utf-8?B?N0J0QzVqVlFLN2d0bTgzOHVVTTQ2T3A5Y1BlUm1qQ3pleGppdXVoei9KK0w4?= =?utf-8?B?Z1RqSDlyeEJ4Qnp0SnRuSkJabGVzaklnTUhtTzE4MVlJSzRaa05FZGFqWEZm?= =?utf-8?B?bHB4aVdxWlk5MTlRcmpDMUNGald1Ky83Ukcrc1RPZ1RMQjZ5QjVaUFl0UzlT?= =?utf-8?B?TmdkWjluc1pNZXUrWUdJdlFobGNMMVRJaG1jS3JiTnV4VDcyLzd6c043SkEy?= =?utf-8?B?M3oza1JCWDI3YllPcGJ0dG9wZlBsYVU5aFhNY043bUFGTTc5OXRDcFA0dnJQ?= =?utf-8?B?ZE1INlo4bXNHeUdLZlBDczNNV0Vpdnc3YjV6Y1MrQVFGY25LMXVsamRhRkdH?= =?utf-8?B?RGI2QmpJVjhuK3ZKMmc1VjNFbkVjcHNsS3VYcFByWFV0UDVvdmlBWXZkaTB4?= =?utf-8?B?dnFkVzZFUnN3QjhTbVNNMmREYlRnK0tFcTZwWUJ6STMrdk9HVlZVMkJsSEh1?= =?utf-8?B?dXhxTGhaOEhPOVE1eUZXYVpNeGRiWUhvWnZGYi93SjJvNUt4eEQwNWU5RzhM?= =?utf-8?B?Q1BQejBwang1YTQ2c0U0T1p4bnJBM2VGQUptSldJODhPNk5BcTFWdU1kenV2?= =?utf-8?B?a1c1NHNKNGFhT29tSldXVDVJUENwZXU4MHZJdU5YTTN1Rmk1Y0p3M1c4amlh?= =?utf-8?B?am92THl5anFRZmFaMXJqRjA3YTREREVJN3F3R3ZyT3cxQysvbGVuZ3Btd3Zr?= =?utf-8?B?aVVNRmFxbmZGQnJiVkNuN3VsUmE2akVFVDRwSDVFS1RPM0ora2srM3VHZGNq?= =?utf-8?B?ODIwdkN5M3RkZkN4QVk4cUxURldkMkdGK0EwekZ1T0tzcU9yRTYxSlh4OHFz?= =?utf-8?B?WHVRNnI5ZjVOMDBwTmFQd0hRb2JCdnBBbVJkZVRldmJBeHlKbG1KN0NGMHJH?= =?utf-8?B?US93L0VSK2hLRFRnK3lqdlBoK01LODhSeVh0V0FEOWlwcTFBNDVaNndsd2FY?= =?utf-8?B?V0pBUlp3cnA5VVdUN2pEYjIrK3NkWTRtMDJxajd0cHlFZG5NdHJzWjBHQjFm?= =?utf-8?B?N0lnTzg2bVFocjNkeGsxMUpkbi9OYzJZck8zY1NFYmUrbXd3YTFiRHJNQ0RH?= =?utf-8?B?RGZXc2hMTk5ScjBjKzNnbERyYUVTbnYxS0xzQTYxaXdoLzdTSzNGNnpOcGQ2?= =?utf-8?B?MWFMV3pEdnJ1OTRpQXRSbUc3MmlxMGErbDJxZ0tWWlVqejR4QVRsa01aN2NG?= =?utf-8?B?MFVwaFJJT25kaG9GdFN5bWlHWWJtZGZOZmE3Zi8zSFRWbDZLaGVqSE4zL3Qz?= =?utf-8?B?ZmMwUVlmV3d0VEU0UGFXZllUa2RPTnN5R2pDNGg2dmt1OGorVEY2dWFYODJI?= =?utf-8?B?bldqWi9ZN2M0bGd5WHhkVFVYWXJXZUEwWWk1NEFuVXg3eFlWRGFrTjNibFBJ?= =?utf-8?B?akFuQ0F1ZXJLV2lMOVpLbCtINW9MYnFNZzhUOVN3bThXT3NjTkRjL2NZbDMv?= =?utf-8?B?ZUZBRGplYjBaVEdCVHVVNno0MjVOLzJRQ0xWZ0tCOUNjZGxTbUJGeXI1WUFw?= =?utf-8?B?TFRNTWszWnJlQSt0RUdkdlIxK1VsQ3R0czhlMU1MUzJYL1Q1Yjd5Zzcrbllx?= =?utf-8?B?akhzanBidnZaQTlvL3JFVmR1bUhQanR5OWtSSENnTS9pSTJUbW8zenN3ZlFB?= =?utf-8?B?Y0FrYWw2L2pvUm4yakt5TkxqdFFjaWZpdVlNK3RnRWJTK0gvZ2FTc2tidUV3?= =?utf-8?B?Y1dZM1g4UzA2Qy9QR0RzTmI5ZlR2aW1EcEthZWUza3RFUDN5aFRBT2lyVTJC?= =?utf-8?B?M0pOSEpyZGVHbHpXbjdwT2s5ditpQ2hXUVJML0ZLVDEzY0h4eW5qWUVNMEEz?= =?utf-8?B?YmJRQ2IxR2tDbkphVXR1MjAydVpnejBqZG9OUFlSaTN3S0g5TkxNL3YxQ0hF?= =?utf-8?Q?PNKEb5QPcd3KCKiMsWhE96MQV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96d5b1c9-6acb-43a1-f153-08dacec132d8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 08:44:00.5153 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YQDRb+Nr2rBbUegIDnEnIjW4aN7O0jwd234tM5KMQ5yHXhtukzihnB9x5yZkwqeJREHlp9y9Sv70NS9WYIqmXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8563 On 24.11.2022 16:12, Roger Pau Monné wrote: > On Thu, Nov 24, 2022 at 12:16:13PM +0100, Jan Beulich wrote: >> On 24.11.2022 10:33, Roger Pau Monné wrote: >>> On Thu, Nov 24, 2022 at 10:11:05AM +0100, Jan Beulich wrote: >>>> On 24.11.2022 10:06, Roger Pau Monné wrote: >>>>> On Thu, Nov 24, 2022 at 09:42:40AM +0100, Roger Pau Monné wrote: >>>>>> On Thu, Nov 24, 2022 at 08:59:00AM +0100, Jan Beulich wrote: >>>>>>> - problematic wrt evtchn_upcall_pending, once set, preventing event >>>>>>> injection later on. >>>>>>> As you may have inferred already, I'm inclined to suggest to drop the >>>>>>> the is_vcpu_online() check from hvm_set_callback_via(). >>>>>>> >>>>>>> One related question here is whether vlapic_do_init() shouldn't have >>>>>>> the non-architectural side effect of clearing evtchn_upcall_pending. >>>>>>> While this again violates the principle of the hypervisor only ever >>>>>>> setting that bit, it would deal with the risk of no further event >>>>>>> injection once the flag is set, considering that vlapic_do_init() >>>>>>> clears IRR (and ISR). >>>>>> >>>>>> That would seem sensible to me, and was kind of what I was suggesting >>>>>> in: >>>>>> >>>>>> https://lore.kernel.org/xen-devel/Y3eO0bMKRPYJc2yQ@Air-de-Roger/ >>>>> >>>>> Another option would be for vcpu_mark_events_pending() to >>>>> unconditionally call hvm_assert_evtchn_irq() regardless of the state >>>>> of evtchn_upcall_pending. >>>> >>>> I think you said so before, and ... >>>> >>>>> This will create some spurious events. >>>> >>>> ... I continue to be afraid of s/some/many/. >>> >>> Not _that_ many I think, as we can only queue one pending interrupt in >>> IRR. >> >> We need to be careful here - the kernel treating it as "edge" (like >> any other interrupt coming directly from the LAPIC), it ack-s it >> before calling the handler, i.e. before evtchn_upcall_pending would >> have a chance to be cleared. See Linux'es sysvec_xen_hvm_callback(). > > Hm, that's not how I handle it on FreeBSD, where the vector is acked > after calling the handler (evtchn_upcall_pending gets cleared before > the EOI). Maybe there's some corner case I'm missing that requires > the EOI to be performed before clearing evtchn_upcall_pending? I think for the purpose of the one vector doing the EOI late is okay, but aiui the goal of doing it early for edge triggered interrupts in general (and yet more generally as early as possible) is to unmask lower priority vectors as well. Of course that's useful only if IRQs as a whole are unmasked during (part of) the handling. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 25 08:51:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 08:51:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448110.704967 (Exim 4.92) (envelope-from ) id 1oyUQV-0000VG-5Y; Fri, 25 Nov 2022 08:51:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448110.704967; Fri, 25 Nov 2022 08:51:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUQV-0000V9-2i; Fri, 25 Nov 2022 08:51:15 +0000 Received: by outflank-mailman (input) for mailman id 448110; Fri, 25 Nov 2022 08:51:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUQT-0000V3-RH for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 08:51:14 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061f.outbound.protection.outlook.com [2a01:111:f400:7e1a::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f1ac72c-6c9e-11ed-91b6-6bf2151ebd3b; Fri, 25 Nov 2022 09:51:11 +0100 (CET) Received: from DB8P191CA0009.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::19) by AM0PR08MB5395.eurprd08.prod.outlook.com (2603:10a6:208:188::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.5; Fri, 25 Nov 2022 08:51:04 +0000 Received: from DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::f2) by DB8P191CA0009.outlook.office365.com (2603:10a6:10:130::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20 via Frontend Transport; Fri, 25 Nov 2022 08:51:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT028.mail.protection.outlook.com (100.127.142.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Fri, 25 Nov 2022 08:51:03 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Fri, 25 Nov 2022 08:51:03 +0000 Received: from 11c4c28e086e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D1547AF5-BE9F-4FD1-8391-D110C6426808.1; Fri, 25 Nov 2022 08:50:57 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 11c4c28e086e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 25 Nov 2022 08:50:57 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by GVXPR08MB8235.eurprd08.prod.outlook.com (2603:10a6:150:16::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Fri, 25 Nov 2022 08:50:55 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.5857.019; Fri, 25 Nov 2022 08:50:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f1ac72c-6c9e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4nP+m/L6sHPWBEZmBJ7Mw8glI3XTHHbCVjP9Ri68fLM=; b=2XQelEL35Z6YQvCzDUs9t7TANEIktG3fuHaVnKpTs6CCC4PlYjgCA1KLqMi99WCQPHItR1r+cwqtuYCvUJSC24z+IV5LR06ZB4rJmw62ugmtVPN78ZrHYCjIeoiSXsTe98Cfn6xF/ZyjpgQFiAUAO5S1E+2YjbjoSySCmbB125w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a1fe79e40b7fc69b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RI/aCIU3SxJDCM1a4+S/GVsCxsJQiKGXusVsUpHZeid/YGlYvIDeHvW5lZF/W8k2edU/q00ZYMuW98MwSZJZUVmFIOHZuI+BDQ3XW+Z+0HhPr3PhGnkCYqagEujpfQuxdN4EvD+O5sW+wtl5IfUosNjttqYEBEvmN+PbG8DvuUgkwJoCWkJxGgNHk1TBcfnlrUA367t8P1/tCcoUupi4x6hRt1N6LHNkVgGSMwg/Ai/6jciM1Vbel/cVl4avJPqLkP0c3WYsK6AGJeaMC3XK96H1kN8+74o2X00an6MX89IGh2YbRGOYaXtq8N/OdfYFQEqTn+z0NuvjW9aI4h0M+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4nP+m/L6sHPWBEZmBJ7Mw8glI3XTHHbCVjP9Ri68fLM=; b=oanuKr/uPLQmyDM9D01Q8jrWPANmGcWBBTICsL8sVXCxxMeQKbH9XOcKHJZYDFBPXIRMYtvru1MdwWbR1GKCLEAjeGe3hG2UPxQzJ68yZGCVyaglxsbeNfmCMmCE9IiT5ekpY1k8EWP06G1+IG8oFhHKO5FxICDw1coUmTWJ7USyvpkUD0PhmK1E4cVzHdxEWDnaJDTLFYImGAQ4s9x10PRGEe6QUbgTFBjLukkXdWo0Asr4mm3VGRrfWeZ5S2Py4uWqLBOZFyRpypXNq+l3Qi3tpEzgHKma8t/CypE6b1rzuRp73Y0lUFiKW3pp8WiiyNQzBPE1z9JIS8KtQhZfXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4nP+m/L6sHPWBEZmBJ7Mw8glI3XTHHbCVjP9Ri68fLM=; b=2XQelEL35Z6YQvCzDUs9t7TANEIktG3fuHaVnKpTs6CCC4PlYjgCA1KLqMi99WCQPHItR1r+cwqtuYCvUJSC24z+IV5LR06ZB4rJmw62ugmtVPN78ZrHYCjIeoiSXsTe98Cfn6xF/ZyjpgQFiAUAO5S1E+2YjbjoSySCmbB125w= From: Luca Fancellu To: Anthony PERARD CC: Xen-devel , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Thread-Topic: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair Thread-Index: AQHY8pZ008DS0BACDkyhs+OWN8Oan64+plGAgBDKjwA= Date: Fri, 25 Nov 2022 08:50:54 +0000 Message-ID: <804E4B68-A225-4D48-A7BA-F5DBBDFDA785@arm.com> References: <20221107104739.10404-1-luca.fancellu@arm.com> <20221107104739.10404-2-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|GVXPR08MB8235:EE_|DBAEUR03FT028:EE_|AM0PR08MB5395:EE_ X-MS-Office365-Filtering-Correlation-Id: d013d910-4509-4e09-cbef-08dacec22f13 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 5/j1RJi8HfjVry+lmKeXeiSHuRRkbR7t48MBzt72O//NOsMfCwU6iVerDRsymX8y/CHwtExIe1WCtus5I2FqH038sFHuaoowDhFZLzs6FWvNF0gR++rKVeW8HTbPyBnhd2qCRZSFHtqTbzuATX5d0dcfJTqMZxIPEy/84PLqc/Sv7/Wve5/AiOncSVQP1B6a9OG2TEQRV8Mem8ra1dxY6Xzq7pdWDKhQ1+HrG8J6F09Ggi/R5y+id9nf/JztLkh8gyEo6DEzxQ0wSFweB6wgu5i5HSv9YFoSysN8SS2C6ktsjzoOBSM/qZG4dZ0m5RvTThKmYPUjUXVjuQWLTkT+AKTmawBcA6uSPa7iCY754BAvct7w/2PqDJzTSTwhU4LXd2P2hJTHDUXYTm2IjeUVGZsVod+3tPcLqLCva/7Fvv+TML0lBwaV20tzpBLYthhumDgG3RVFGjFJ2gYcNgZ+OivXPz3y+iJymyg0GrDY6PIe3TIAJLkBYIFBd2UL1utlvl/VGBFbL9BW+0t23iMdKQqAzRXroN6LCzrJ9etfdzih6kOHRbxr/DdzDQbs1klcpOURaZ6W1QM04mI5vlaW9JE/hIdyZMrOZtPFkq4YRH589+PXGJH3ztjP8sqRyzi6mrhQhNY7D+6Z7QKCyemVvwgzyYh7CMZH4BWp6pUkBL0xF65md8RI1HPVrr8nW8JXda/LUn8oVa5RSCr7QSUsP+t5MfOOF/81T8E1NbfGBJw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(346002)(39860400002)(136003)(396003)(451199015)(6506007)(53546011)(316002)(6916009)(86362001)(38070700005)(54906003)(6486002)(71200400001)(33656002)(186003)(36756003)(2616005)(38100700002)(6512007)(8936002)(26005)(4326008)(478600001)(122000001)(91956017)(4744005)(41300700001)(76116006)(66446008)(64756008)(66556008)(2906002)(5660300002)(66476007)(8676002)(66946007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <57042E8A18C5944FB69BFAC57DF625FA@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB8235 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9f27289f-b6ce-4b26-5c87-08dacec229f1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M6MS7Xf3V4G6ykxAiT8V9j5M5cDFBDsly46QJvw+BldPS6lDGscUOBv63qpYS+dAPYj0awPPr3CgiB+8pDl41lGrgkiujk7So0EHMLXzM/nT3ZIljyrUqeChzkBc/8wSvnc4LpogTX9cPIMlO7lo2Eoz40C84c1Y2p1JP9VCzdrd8RkYyf7Ck5DnCJpmjUaMYSmkOa0XECzw5CDChbkMUbsIwS0Qkz5xW46ndqmipszdi7E11Lr5Jk0HhwrSgXcO/Fhiij7yYavuyksw2Ly/vX6DRkg4LTHjaPQ745njj1rkSenoX8JKXgRUmC4DZ7a+9tCZckmVmu01bCWkVDKd2nRk5buPpc13/M28jpu861QTXwS+hUkXa2B6HiBy6fVhgcwcZESp7N1z3Jk3zbpF894VF7CWBlF57qbR9A+sHwbaxxnO8tRVDDSj/xL5pGtULD5KfTfCEMmLVX4hzsHIVZRqLHt3o0+5l/zpCxasEVQt698IMuL8opEKCMD9mOScFCi5414dUCjFSkYDCQMCvvvcjcg2TOPIxFNe86MREn89wINCnEPNHqT1wZmAWiWDewNom/Gtonj0tqxpq/rN2bnoy/BQVxkbY7VIwov4/CQeOnaiiIRRCx+a65kCBhCUCyi40claVIyJeKzWlzMqHtq6kbrT67t/ghwe079O0qj0NsdHL/KeROIIvUAjzOyyFqmH8FqmbwCJ89UjsEUC2Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(346002)(451199015)(36840700001)(46966006)(40470700004)(70586007)(70206006)(36756003)(8936002)(6862004)(4744005)(33656002)(41300700001)(8676002)(4326008)(86362001)(5660300002)(36860700001)(82310400005)(26005)(6506007)(6512007)(53546011)(47076005)(2616005)(186003)(336012)(54906003)(81166007)(316002)(6486002)(478600001)(40480700001)(356005)(82740400003)(40460700003)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 08:51:03.4994 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d013d910-4509-4e09-cbef-08dacec22f13 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5395 > On 14 Nov 2022, at 16:25, Anthony PERARD wrot= e: >=20 > On Mon, Nov 07, 2022 at 10:47:36AM +0000, Luca Fancellu wrote: >> xen/Makefile | 50 ++++++- >=20 > Hi Luca, Hi, >=20 > Could you write a shell script which would probably be easier to > read/modify than this rather complicated looking set of Makefile rules? I admit the rules are a bit complicated >=20 > As I see it, a potential `analysis` shell script would have a single > interaction with make, it would just have to run `make build > CC=3Dcppcheck-gcc` or other. >=20 > Because I don't see how make is useful in this case. Or maybe you could > explain how writing this in make help? > Also non of this would work with out-of-tree builds, as you shouldn't > make modification to the source tree. They both are good points, I will rewrite the rules as a script. >=20 > Cheers, >=20 > --=20 > Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Nov 25 09:00:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 09:00:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448116.704978 (Exim 4.92) (envelope-from ) id 1oyUZc-0002T5-2C; Fri, 25 Nov 2022 09:00:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448116.704978; Fri, 25 Nov 2022 09:00:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUZb-0002Sy-VE; Fri, 25 Nov 2022 09:00:39 +0000 Received: by outflank-mailman (input) for mailman id 448116; Fri, 25 Nov 2022 09:00:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUZb-0002Ss-BW for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 09:00:39 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9fdfc865-6c9f-11ed-91b6-6bf2151ebd3b; Fri, 25 Nov 2022 10:00:37 +0100 (CET) Received: from mail-bn7nam10lp2105.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 Nov 2022 04:00:34 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SA1PR03MB6451.namprd03.prod.outlook.com (2603:10b6:806:1c2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20; Fri, 25 Nov 2022 09:00:31 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Fri, 25 Nov 2022 09:00:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fdfc865-6c9f-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669366837; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=gNdG5HqrIvHYi8D1uBXtYIgfnPWg14ZfjZprHOtTPrw=; b=ao+cApOhtFOHGhnuzSLyKQgkSeoMTSVT30YAlbbYAwr/ylNZVdrulCPH 9G8obpq/fJsnpILWHkYUoGaZ2AQU2GGL31T896SsPx6AVh/HmWXK5e+5i PC9j13YbFWvGnIFTpBPYMzh5B566yYESbBhFnnewObIfuOZ0k5BPuQygw s=; X-IronPort-RemoteIP: 104.47.70.105 X-IronPort-MID: 85537488 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:bnkTya442ELDFnwIaT2ECgxRtA3GchMFZxGqfqrLsTDasY5as4F+v mIdXWCOOfaDa2Skf91/ad7g/E0CsMeGnNNmSQE++C01Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkR4QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m/ uA7NHMvcA+/hMGEkeipe9BOj5sdFZy+VG8fkikIITDxK98DGMiGaYOVoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MlEooiOWF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8efwH6gB95CRNVU8NY1mAGShXU2WCdORFidreCWpR+PGOtAf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmSzoLE7gDfAXILJhZZYcEinN87Q3otz FDht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHeTJobixvOSpNpFvGzh9isQTXom WnS8W45mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5 hDoR+D2ADgyMKyw IronPort-HdrOrdr: A9a23:g6uW4qlsod2Jl0OmhI5QjoXw52DpDfNMiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH7KGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu1Xh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboX0Twk6n7WXdrWrooMT/Sj5/I81dhbhBeh+cz0Y7ptlz3I 9Cwmrc7vNsfFv9tRW4w+KNewBhl0Kyr3ZnuekPj0ZHWY9bTLNKt4QQ8G5cDZ9FNiPn74IMFv VoEajnlb9rWGLfS0qcknhkwdSqUHh2NhCaQnIassjQ6DRSlGAR9Tps+OUv2lM7sL4tQZhN4O rJdo5ykqtVc8MQZaVhQM8cXMqeEAX2MFzxGVPXBW6iOLAMOnrLpZKyyq4y/vuWdJsBy4Z3sI jdUWlfqXU5dyvVeIKzNaVwg1DwqViGLHfQIpk03ek6hlS8fsumDcS7ciFuryP6yM9vR/EyWJ 6ISeBr6rHYXC/T8L1yrn3DsqlpWAcjufIuy6cGsnK107b2w97Rx5vmWceWAobROhAZfU66Kk c/fVHIVbZ9BwaQKzLFvCQ= X-IronPort-AV: E=Sophos;i="5.96,193,1665460800"; d="scan'208";a="85537488" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U4MRf+qAgVGiBkBtiw45p+K9PGHBCq2IW4njJctJWb+NcJMrnbPWUdhsaELbc8u84Q4clRkE7mUszk5vsvsMvtEXHFk4dx90KUWhNJ1lsnuPkW0as3Gt3Q28Jk6O00lz600tyZxHE8vMbwDteCZbN7YSOtctFC8zOzgHB5JAXMhyfHFZ2A+pR4KjvJyEutmPpgHGozypqBcAL7BD8qJfDqsuzbJtKK39A5LMKOBwOO/BvP+rQSKCoMRg9zZxpKkt7KK8p7e05zyt3+MsBvMqyHML+obf1LmjMXtSveoKA8WV43+DoFMAEVTNx8OdHJ3koAGUQv5VDlmRmK8n9NwxAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4p6tzce+1DxiJcGf7pTS063w6g4APCAUros5JTau/CQ=; b=WzAMT2U/5vxxj1hVSw4klwRS2qrmMglqLArN5T55IvzyP64AVaFqf6bqYaXsSCcOfpQ8lI3wE02/2Mu5BVdFfTlFJSKE+ayIUEFD3o3JsnsfSnZJWGQRvJnNd7rqWe6BEwYidj3dxr+rgjuzrtufcFziIOVtoDevaSQ9Crp5iZ6LZtS7lcoJS20skEfeK0fM3dYnvYrzyApQS4EKDuwMIKGkgIwybWonaWl0Kpb1TPWYEIRW3XfVhxDN8Ucg6PNLVYqgKjbLwljnvg2P54IL/qdH5cJP/QoYFXh5FxZIHapYnVqZzpTi+bQsYHanPMdBpjpqkFQQaXLP2+Ol9kwvXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4p6tzce+1DxiJcGf7pTS063w6g4APCAUros5JTau/CQ=; b=sx/gakxF9L7HmxgRS2NYv54dyW4tHl9Cl8Qean38j7ngUuC3xDSaNHlUd5dzATjSI+VRdQ2uyz5/Xi7gnc6zT9GIjlMj5RY481VgnAF7uQ7LQ55o5PuVKYozyb39MhAigpsGi0aidg+Ieco+55lKg8f0Y4rWTEpEXSppAIJv4Z4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 25 Nov 2022 10:00:25 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Message-ID: References: <33a005bf-0596-c624-0e70-077a450ac2ae@suse.com> <351a6e54-8002-aef0-993a-c6b8bdcc1e8e@suse.com> <3f3bced7-62e8-4ff2-655d-aed222f343a9@suse.com> <516fb872-bc79-ad8a-233b-b821265c1911@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <516fb872-bc79-ad8a-233b-b821265c1911@suse.com> X-ClientProxiedBy: LO4P123CA0120.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::17) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6451:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e30596d-e6d0-4e23-b9ba-08dacec3811e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kJmV8k/cbIFOyiwzrLiHp0dtyE39In6ZFDoewIyqT0FA/Lbnkkze9B0Ck5DfyPCoulb2Al0uCvFtSgqoyu9jNq0ga8p1rP1ArefR1xt0KrgLDwia/QnGy4EFruqLs0IqyXaXUOga4N+bTDOiidIs8zn2bqkyFZ3ikE0cW+FEGy9iobdifwJyTz/dOUsfq6iKlOJaEqjmXibr3TgDC2Z0qVIvKBjf+1QJT6xMA48wa5bBraUEkQ08Zgx5p99RIdYsuiGTtk9AuZic6TndwecwdTS6FWFnuiSYXyBBO/p91dNFx2pdtES4MDeYW100ecADzvO0gq6T/jIsjfnwAi7a0H7aMWv6Qw9p25NFK8yneSb57YqFOY7eCviIVxyILgrQhVhLhxk9ZFHqImnPswannMGCCSofKAD6j0xqlejmLRk/NqDxUb8iOfeY0RlzHxppqnJZ2mgm725ekbrzQynXPJtJMIOlbiOQIqJ3LBIWbA0EHroOQ1Kf+B9xaftQOed3pc4190Pt88pDY3wfBzXEIk5vLSNxnQPpRgkFdx6GTPldAwDq6LY3p+/nHEWqlXYRBOhSfcNKTtTq78XlwfWhi3Ryvi/72+F4dseeEyZF647XbsDgyi+TqY4Ez4uQuE/jEfRqCsOgETiOj4uvrEjrfOW3NTyH3yJM+oZ4xbct7QGvOz1oHPJkiDl/hD+U5Lwo X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(39860400002)(346002)(366004)(396003)(376002)(136003)(451199015)(966005)(6486002)(478600001)(66899015)(186003)(33716001)(41300700001)(85182001)(316002)(6916009)(54906003)(38100700002)(82960400001)(6506007)(6666004)(53546011)(26005)(9686003)(6512007)(4326008)(86362001)(8676002)(66946007)(66476007)(66556008)(5660300002)(8936002)(2906002)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1g5dFhBRk0rZyt1Q1pvYnQ0Sm02elBUOUt2TmVFREdqM3k4aHZtbitxejlO?= =?utf-8?B?WUhUMVFNcENSOW53bEZMMHBRZnpXSlc3RWhra3FFbGFEQnZUSUNUMU00Vmll?= =?utf-8?B?MC9MMk5TaWM5eXFCbmNLaTE5Wnd1RUVXRU1SU1I4ZFZWQzI1V0hJaDNZa1pn?= =?utf-8?B?M2FyOHozK0xCVmEvcVQ4eWs4bmorZEhjZCtSVml2Zy8yRzFCVk5nZWo5N29i?= =?utf-8?B?QXM4MlU0RWFCV0luMGlTYUV0LzRYUkp6a3lXY29TOHhvRXdsUFI0WXc5V011?= =?utf-8?B?TllUNG56dUpTSENCbzhjcVlMU3p5YmhFR1p0N1Byd2JGK1g2NGpyS0lBc2t6?= =?utf-8?B?NVlQMnJQbzVEanpFK1pBbVhEL0lHZ3pPbGNSblBaL2lmU0lqNjNOcTVpeUFo?= =?utf-8?B?UGhxUUc4bWtGSnpKNEZBNTRkM0xScERZdnRIanl4ejUvYVZQKzFxemcwTU1O?= =?utf-8?B?eDIrN0Z1VENBTWRoQk55Qk5HbjNoVXE0ODVkU0NGRmRGalpEZlRaK3RYUDh3?= =?utf-8?B?SG9SZ3VwMUY2OUpMcFhITk90MUlFc1RCYnFOR2tRdzJMaGF1NGxOam5yV0Vn?= =?utf-8?B?SGo3a01Zc1hqR1JYSm9OSTA4QThvbllnVk80Y2JDSlJRU2lpZmNCYXdlMlJS?= =?utf-8?B?bDc0eGFsNXB4K1VyWERJYW9uVUFock9xMWxrN1RNWndyRllwU29iSWhJdTZ4?= =?utf-8?B?UjlHOCtWNnRFZDc2WFlzQlFUTEV0dnQ1S3pVUTZLUWJNRnZDZ2FxWWs5bzla?= =?utf-8?B?ZzhrK3BGT0FEVklWampLTGRCd3M4THRuLy80cC82WjlHL1Z5MDJ4cVhYclBy?= =?utf-8?B?ajBKV0pvRUVVbStJWjdVakJ0bEdKdks4SFVmYWpVL3RIaGh5Vzg1YUQ2NElD?= =?utf-8?B?QXBYN0J1c1JycEhCTlhQa3hkOGpZN1lRUzVFaDNBc1N1dTlHcmgzMFZTblJG?= =?utf-8?B?aVVqTFg0RndlNjNHNDBpelhFTXZLUjY1b2srZXVYMHlha2MvRk1mM0F1M3Jx?= =?utf-8?B?K1pKbmQ1Yy9aZlZqeVNHRmdwQ1B6Qmttb0wzTTRiTHFhZU5KZm5TRUtmSlQx?= =?utf-8?B?OXFjK3ErS01xNDBHSC8wUGlrZllnYm1iNTRTR1FGY2FEQ1Z5Z0VYQjZyK1dQ?= =?utf-8?B?dzQ1YVFJQ0tmUTd3eXBZMjdVQ2dRWjJhS21CNGZRV2N1Sk5xVlQ2M1hjbjNx?= =?utf-8?B?T3RXWWtiak9OOUp3Rnp1VS9QQzdqZ1pJNTRjVHJGa1B3WWdFclZjYWJ5aXR2?= =?utf-8?B?SGFzUktkRFU4MXVTQjhrR09YK3lhTXlFR05BOFlJc1MrSVVydWpUS2xVN1RK?= =?utf-8?B?YzNML3ZmQ0lmd0k2cm5nTlovdDJaN3FpNXRVb29QK1N3eTY1MkdiZk9kazhs?= =?utf-8?B?dlVPOG5PaHJkRm9Na25FU2k4NHBlRDFnTnhKaUczeXRmV2hnaks3SzRmQlRm?= =?utf-8?B?MFVXY3BiOWdqMGdhNUFMTmtnckdYQUk5RHRBbzlFbEtTb3loMzYyRmpCcDBU?= =?utf-8?B?WWl2a1NjUXBHVDRqRHUwaGpLTEdOeFRxcWVmZnZoa25YUi93aDVsOHBrMG5G?= =?utf-8?B?S2ozSm9aOUVOYmYyNDVnem5LOVlSanhwTUxPU3N4cVpZNmhYR2tJeFREQXg1?= =?utf-8?B?V0NmM04yYmxGeUo2UHV0alRCT0w2Z2kxUDRoZXppWmJDT053aGZ6MFVnSTRD?= =?utf-8?B?djl0REUrUzNhYnZhQ3U5TEhtV3ZHOE9JNm15OGRkYWZjS0hXWDl2QUVOMTI2?= =?utf-8?B?YzlML2U2VUMxbFF3Z2U2bjVYOEwyV3NEcmlQdS9vNG1XZTg0RE4rZzFEWC8v?= =?utf-8?B?TXEybm5nMklSZ2lHV3ZJTXIzREVsN1pmbUxvNmg5cGhLdG52cjJZTTFhQWl0?= =?utf-8?B?cHNtNmE4NnJjaS9NLzVJWlJ4QUtXN1BWTU9tc0Q4cnJFdUwyb3lvL2RPeEdP?= =?utf-8?B?SElFMk5xSlNMZFhWd283YWlVcXVKM2xkbUdUWGF4ZXg1TU5JSStwV2x3S1VL?= =?utf-8?B?N0pVMUk5V1FVTnhQN3NpYTZiRi9KcHlxcGxXTmVQN1ZiUTByd1UxYWM1RDho?= =?utf-8?B?c3ZZWHhUZ0xMRjU3YXluaDZhVWVqdlNEYjNsUWlhekI1NXdsNWl2bmVQcXo4?= =?utf-8?Q?Ao4Gg2hdef8q34qdXJBOGW9RZ?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /VN5zIOHsynKnYEEtkECtvRniHg6UmxFsEQI0nOihe+R8zid65LD/CN/W4n37YnHIowIJZ5dz7uQb/57nzhwP9rSqQnWHVBx4tbn+trHepWBxdGcjK6VYBCuNaQreb0b6eXVZQr298GZYLKEOqCsuH8dtfKrZz+nqQsb2pSOWXMQVGXRCtSFYav4cUpnDFiLyjjNxnP1ssvSvRlHOoKBApQiwNre9k2tbm7B2JqzCt3+naCuVZeBJwGgkkkDHsZeiKkYBBEyuRi33K8SsS1nQtQityPdg2AOWKiaHhJ2/oTrHiAlvBPnABNQ+tVGxajWQXogBgnqYtx7ZzhhBy2Se0uVPBQPisC6q9mNlUvol2VzB9klDaLYIBZgepYnkwxTmhuL//CmgsCSmCUzD9shTZzWRJ6867KHgP8ZAILgMWzCj7q2xZSaidIctp7SpGzpPtbnmmNkM7Z2zbgMqR5ef1NZbJ3n91CCocUWMIIRGod9yIKW2tBCyR/fMMuPtRfZq5xdxT3vVbyn/kJoCKjHrB7EVs9xx3S0MOLtFsMyI/jRroarRos+qm16KNCk2/Vr6B58h2xRS4bM/3QgFGfcEg2+9SdrGbEMNFEPoJCKdOj24YISiaYO80WH7gT5h+Bo59lLVmhIIcT9PRWgWyq6IEhbmXReBgZhAQEYGam/jgu4x/c34jKnk/owg1KMAZOQoZxwv0pbq8s//fk2N9bJSqsynIQPpmEShdsT/peVIwLAuQr13U+kGnO8sdGBzM4YPN9HEoryTdowlJTPWUWdltLyRcLhZmJxieE3AIUZlebq7HzJ1DBZvxaDIHTIXE8VOBGqlKk5V+3k8DFVeplz1kAYamAA0yKnOv+B+3D9Q38= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e30596d-e6d0-4e23-b9ba-08dacec3811e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 09:00:31.0158 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pbXZxKgu2Dgnp34bY37t0REDrpLKUuGICbQsdUSotmIJ7vX2zh7kXcrDbivFajthoxjNxGFqpcjgApiKRuia0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6451 On Fri, Nov 25, 2022 at 09:43:59AM +0100, Jan Beulich wrote: > On 24.11.2022 16:12, Roger Pau Monné wrote: > > On Thu, Nov 24, 2022 at 12:16:13PM +0100, Jan Beulich wrote: > >> On 24.11.2022 10:33, Roger Pau Monné wrote: > >>> On Thu, Nov 24, 2022 at 10:11:05AM +0100, Jan Beulich wrote: > >>>> On 24.11.2022 10:06, Roger Pau Monné wrote: > >>>>> On Thu, Nov 24, 2022 at 09:42:40AM +0100, Roger Pau Monné wrote: > >>>>>> On Thu, Nov 24, 2022 at 08:59:00AM +0100, Jan Beulich wrote: > >>>>>>> - problematic wrt evtchn_upcall_pending, once set, preventing event > >>>>>>> injection later on. > >>>>>>> As you may have inferred already, I'm inclined to suggest to drop the > >>>>>>> the is_vcpu_online() check from hvm_set_callback_via(). > >>>>>>> > >>>>>>> One related question here is whether vlapic_do_init() shouldn't have > >>>>>>> the non-architectural side effect of clearing evtchn_upcall_pending. > >>>>>>> While this again violates the principle of the hypervisor only ever > >>>>>>> setting that bit, it would deal with the risk of no further event > >>>>>>> injection once the flag is set, considering that vlapic_do_init() > >>>>>>> clears IRR (and ISR). > >>>>>> > >>>>>> That would seem sensible to me, and was kind of what I was suggesting > >>>>>> in: > >>>>>> > >>>>>> https://lore.kernel.org/xen-devel/Y3eO0bMKRPYJc2yQ@Air-de-Roger/ > >>>>> > >>>>> Another option would be for vcpu_mark_events_pending() to > >>>>> unconditionally call hvm_assert_evtchn_irq() regardless of the state > >>>>> of evtchn_upcall_pending. > >>>> > >>>> I think you said so before, and ... > >>>> > >>>>> This will create some spurious events. > >>>> > >>>> ... I continue to be afraid of s/some/many/. > >>> > >>> Not _that_ many I think, as we can only queue one pending interrupt in > >>> IRR. > >> > >> We need to be careful here - the kernel treating it as "edge" (like > >> any other interrupt coming directly from the LAPIC), it ack-s it > >> before calling the handler, i.e. before evtchn_upcall_pending would > >> have a chance to be cleared. See Linux'es sysvec_xen_hvm_callback(). > > > > Hm, that's not how I handle it on FreeBSD, where the vector is acked > > after calling the handler (evtchn_upcall_pending gets cleared before > > the EOI). Maybe there's some corner case I'm missing that requires > > the EOI to be performed before clearing evtchn_upcall_pending? > > I think for the purpose of the one vector doing the EOI late is okay, > but aiui the goal of doing it early for edge triggered interrupts in > general (and yet more generally as early as possible) is to unmask > lower priority vectors as well. My reasoning for doing it late was in order to avoid adding extra latency to things like the timer handling, as the EOI will likely trigger a vmexit. > Of course that's useful only if IRQs > as a whole are unmasked during (part of) the handling. What do you mean with IRQs as a whole? Are you referring to setting the interrupt flag? Thanks for the input, it's appreciated, and sorry for diverging the conversation so much. Roger. From xen-devel-bounces@lists.xenproject.org Fri Nov 25 09:09:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 09:09:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448121.704989 (Exim 4.92) (envelope-from ) id 1oyUiZ-0003Aw-2Z; Fri, 25 Nov 2022 09:09:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448121.704989; Fri, 25 Nov 2022 09:09:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUiY-0003Ap-VQ; Fri, 25 Nov 2022 09:09:54 +0000 Received: by outflank-mailman (input) for mailman id 448121; Fri, 25 Nov 2022 09:09:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUiY-0003Ai-2E for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 09:09:54 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70071.outbound.protection.outlook.com [40.107.7.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eb8550f6-6ca0-11ed-8fd2-01056ac49cbb; Fri, 25 Nov 2022 10:09:53 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8066.eurprd04.prod.outlook.com (2603:10a6:20b:3eb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Fri, 25 Nov 2022 09:09:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.020; Fri, 25 Nov 2022 09:09:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb8550f6-6ca0-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R8wolmveCHg78lKtgt3liFo0pDuJ2QzxU7KV7OAHhx3CbomRORU3GcJiLAa1gmjLiw6dNg2VhTMop84Kfnb1SchU/0miFXQuvGOadUlQBkoRTjHCgaNUWPl1z0GUu2gEaqpy5U/8awDZ3+iep2ba94GnvmLa7ezHgiUu5EiOc/m3goNQanIY766RBpKfQ18x6eJRMwcFk8zudbfsSjbsrXLk96GT6K1liZlX50mV93VF1nvznEPuxSmDIhKs7dF644LAZfEOhbMxf2Wl/w4MT3Y0ZeO6i2+zTOnmCmCG/NWho4zj2Zf7OWq1+nq8XAhW1LjLb40zWC3RNksxiqn+Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EkzG6vfyxgw8LTU7MRtKPm1Faxf1F4cCuwn/3h7f9WI=; b=esJNuMkcU2bVcpUAfkhI9Z3mWJOX/MKnYD6X5k0a51TYTBWQbvkgkOiJdW9QRDuwonMuhqYXxfuCF28TW0o9hJksVHU04R4MtrC1dbi2zJHW55Tpb2uRyJvQaz/ceeKpgg35PNl349+FNzJywNQ6/tKbM8a6m9pI7e4RRTSeH4v9W80A+4O19U3djSb+E3wbkBfmygwPeDIsKR9ACP7dhg5lPeno3mF+57PNWm4+iehw43/X1UhDRu3eAsBsSauHizGmO/H4TlAXgHT+h5YcprzBSba0+y2CBk/vBVZyxdd5YgFtpRG/rK9BUKlAxos2zxgQePrsQRiUI0z83Ipw4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EkzG6vfyxgw8LTU7MRtKPm1Faxf1F4cCuwn/3h7f9WI=; b=BmU7hKC9YulpJc/0iT+pHnvIDv/Dq8c4ImUeNmRQDc+i1dM3YEI2UIYN7TzrtnVGkTwSybqBNdm+C2EOZUxmVwqSULtlAv5TrvfuJSom9Cv2wTZIv0pDErJ5zEG83YFCqbNWYURPhajWUoKv82d7WrKRnE6gbfyLuvIkwRGXIry1e4cxJt7N+d36ALMhkGvt42/jHmWkI8nLEvQH3rYBTgpDYdW0MD4XKXNgYrV14guuH65ZaRE6aQzHSNe78ilPWhNtMfAwZDX5p85Bvrgz8HFmw/V0S9AYtYpayRBTey5If0J/teVHAA7Sh367ni5TGiSChD4jiC0uCKYqKCND3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 25 Nov 2022 10:09:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/HVM: don't mark evtchn upcall vector as pending when vLAPIC is disabled Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , Paul Durrant , "xen-devel@lists.xenproject.org" References: <33a005bf-0596-c624-0e70-077a450ac2ae@suse.com> <351a6e54-8002-aef0-993a-c6b8bdcc1e8e@suse.com> <3f3bced7-62e8-4ff2-655d-aed222f343a9@suse.com> <516fb872-bc79-ad8a-233b-b821265c1911@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0157.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8066:EE_ X-MS-Office365-Filtering-Correlation-Id: ac446ed6-77a9-4e9d-60bf-08dacec4bebe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VA7JUWyrs8tTxnN3LR/BSCB+AEe989nD3DOeHwlNSKbPsR65xtNTP1WqukeqX7mlqitwasbqTtcAl/AfbaGgNpny3JAfh+wVTYC6inOCEtws8YRsXWp86r5ToH309jBmZX4EgXtTasPklH5IgsaBporUkq/mPT/nlenxgQs5EqvsbbCSyl5J5pb+rfar5Mj/WJejqqvVnZ/rQOuGL/Ee94IQaEFAXlFeyRu/tN/V0vVT+kIRJ/Q38MF0Yd6POUiIQ6JIlWmigNpn070Gudj9MHnaAdaCQt8iJn8PKJ8IQWf/Zb3VqTwloz7hqkL0XA6vOR/6f7DHuoUiOiLUxpr/KBPW6cawCGtwx1t6xL/jwF2jjmKAIjJlDCBrojCuupjhmyDJzg0BfaH1f+tXEpzNlRAkHHyAGGHXd+TrWfo3D1FhjppKhQYvIc9Laeai1UHQudLEgCNAixkG4Iu3zCqiEYXzhvO1FnFF1b0XHg7jWSL9uZJplVejrDbQeMexvsdVoSVxRwQeXo+HcMJACXZzM4tdYCtSk/utjRvmoqWdTW4gqaSPMqZeAh2rz5IOwZVHuosFRuicsCWbdJLQrYXcWvK1/mfbvZnTZa3/c9o+sUvX5avLE6Lhxwt4bNVp9OkczUeXjkQt5x1JYFBEqZoq7dYluZ2Z51hYM2oyo6XfbpASSc28EUJIH5WYVVcutc9pDM7bcoZ4oceykxM72KVUlRCZXvZZxNGMFCAIVsPQY+U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(376002)(366004)(39860400002)(346002)(451199015)(41300700001)(86362001)(2616005)(6486002)(26005)(53546011)(6506007)(6512007)(4326008)(478600001)(8676002)(66556008)(36756003)(186003)(83380400001)(66476007)(6916009)(66946007)(54906003)(316002)(31686004)(66899015)(2906002)(38100700002)(31696002)(8936002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WktVeU11UklYSTdQQlpGYXRTS2Q3V0RVVHFncW4rNlZXTTFnSjlhUUVUV04r?= =?utf-8?B?cDlBWUU5azZmYXg4S2RndXBwQkNwZzBhbnBBM1JENDhtclFuRVdvWkYvL1g0?= =?utf-8?B?RFpnb1dmNXhQYVE0OEUzR01RM0RmSTEwWXZ2c0J1cWlYbE1SUnBSd3lXRjVO?= =?utf-8?B?b1dCemNQajJRcndBaEU2TUxZSDVscUo3VGR1djZPKytuY29idnRWUU1KMk1x?= =?utf-8?B?SDVZN0NLTjJTRUNOQWZmcitDRE9VV0ZUUE1kZHBqYXJEUGF4NFNiMGYwQjRB?= =?utf-8?B?cFVzVzZLaFFmRHJHQ3R3cHExVWw4YUlVcDE0TVVtQlNCY2NObUxvRmI3b2Rs?= =?utf-8?B?Y0ZabWxleFVrNy9wbkhMWlhzL085R2M3dEs0OXBidUJvYVpIcnNXT3VhMzRK?= =?utf-8?B?WjZZaGFnY2h4NmRvQ2NmRkYvbWVEWmZ3QUw3czBpR2tySFV5RlZ4MTZoK0Rr?= =?utf-8?B?TVlqRm9lZk1QS1Uza3BzdkdTN3gwcitENnRNK0o2eFo4UTErV01MaTRCN2tG?= =?utf-8?B?TFNTaHRaTHZMQUcyVFRkMm5wTjhack9EdGtWczZUT01oMTh0bEVHdEdhQk5y?= =?utf-8?B?MWlzMGZZNFNrZWMvbFAxY3ROUHkwcURncEtuYUpReWlBZGxpZFE4em42UGx2?= =?utf-8?B?dGIycExrZW8zS29VWVkxZlJ5U3VQTk0yOTc4Ykc3ZEhvMU5vTzF1STBJOGtK?= =?utf-8?B?UjdDK0dseDJVREhMbXA3Tm0vNDBPRmRPMEQ5MCtZTDZ6dDJTV1ZTMjFFZmxz?= =?utf-8?B?SjlTaUNtakV3cGtLdUNQWWpOQVFxTzN4YWZuTGxrOFFzYVFGRno5MWJ5MFdK?= =?utf-8?B?TUl5MCtaM0pDei9lSHhaMWtEcE1sV3FnVVNobFhiMG5ZWjZ5S1NjbEtOa0px?= =?utf-8?B?b0ZOcmU1YVp6NkNzZVBPSStHcllEK1lJM0VxOSt6Q0hybkRxYUFBSlJvdVZq?= =?utf-8?B?bVlXdFcvRUppajdDWVduaFlodXM3eEoveGI2VHAxejJ4Q1lTa3NSZlgzR0Uz?= =?utf-8?B?U3BQSW4yTEp4S2d5VjRNWnlwNkpQOElyVlBpaGJINHJVVlo3emFsOWVMOUIy?= =?utf-8?B?TkEwYUJnYytlNDZBQ1Avb3ZtK1V4SmVLelBkNG1vZlU0aHBjV3FiNkkzTUNz?= =?utf-8?B?TG9ZdkpVLzJIS2VNQVYrcU9MTEtkL2U4azRlZTBsQUl1UWZ2ckcwUnd4ZFhz?= =?utf-8?B?all4U1liTmtDOXN0TUtBVHdUNGtHMWUzWHBBNWtBMjdiUFMzejVGY2NxYVdM?= =?utf-8?B?VDNIbzMrVjd3bm9PUVF2YlZvN0xZdzNnTVpILy9WcEtySUF6QTh2eXoybnFw?= =?utf-8?B?WXd5M3A4UStKNU5yRmZYVU1ZeG00V1AyQ2R4ZjBBcDBDTS9zelpONlBlUkZM?= =?utf-8?B?WmxYY3dDTXVYa2ZKamp6UkR0d3J0K01vTm02VUh1NlhqVkJxcGZoY2p4VHA3?= =?utf-8?B?Y1ZpOWZZZ3Zjbm93ZHFRcWVPekF2cjI2VlZHcDNqM0hVOUVLTi9FejFzbVVz?= =?utf-8?B?MjdFK0lMUzQ2aytrVzV3NTRSUFRIMjA0UmJuaWszSUhUdGpOVXEzaXU4Qnc4?= =?utf-8?B?SmhMK0FkT05Rb2ZyT0RncVdOUHBMVmxINjk5S1ZlSXY0RFBadU82TTFkMHZ3?= =?utf-8?B?SVZSQTE3TTBEalE3eXBKeU05bUhickRFVFFLUGJQNDM4cko1RDZ4M040SEZE?= =?utf-8?B?d0JpUzRsSkFqTEk2SUNBa0M0VTVaeWIvajBtMWR1cVpYOFNUTDJWN0I4UHRZ?= =?utf-8?B?NXQwTXVZcjF1NzFxNTFzODhMeHN6d3ZDVzU3ZkdrdUtITEtoS2Y0SzZySjdu?= =?utf-8?B?b3YzbVptbndCdFF4aHhUUENEaGdxVzFDNXhSdXdYMkJZZENvY1lQY01reFg3?= =?utf-8?B?MzkrNTgrUVVwbU4wZXVOb1F3LysrYnk3WDhvdmdXVlZUcWJDSlNmWFZaZmZ4?= =?utf-8?B?UStlbDF5MUplS0xCNk9PWTUvTy9SOXFYdzRaNUF2clpBazdUM25aWmNtczY5?= =?utf-8?B?eS93UFVCc05nbHMvL0xWMWRwMmYrVVVnUWEyYS9aU2JRZTRMa000eVlSdmgw?= =?utf-8?B?MEhld01ONnkzRWFYR2pUeXRCQ2duTUxRZDhuYXJ6bW1TTm9KSVdqRG1xR1Rt?= =?utf-8?Q?atrmHB/0XEre36xqimqwJa1pU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac446ed6-77a9-4e9d-60bf-08dacec4bebe X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 09:09:23.6499 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9L3LqJo138MrFLtgpvCcnZIcL4B+Pjc3v8ovek+BcUYrRfqtKKdiSdr3zRCabv9rePm0g9UKstUC1LvGmqgAVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8066 On 25.11.2022 10:00, Roger Pau Monné wrote: > On Fri, Nov 25, 2022 at 09:43:59AM +0100, Jan Beulich wrote: >> On 24.11.2022 16:12, Roger Pau Monné wrote: >>> On Thu, Nov 24, 2022 at 12:16:13PM +0100, Jan Beulich wrote: >>>> We need to be careful here - the kernel treating it as "edge" (like >>>> any other interrupt coming directly from the LAPIC), it ack-s it >>>> before calling the handler, i.e. before evtchn_upcall_pending would >>>> have a chance to be cleared. See Linux'es sysvec_xen_hvm_callback(). >>> >>> Hm, that's not how I handle it on FreeBSD, where the vector is acked >>> after calling the handler (evtchn_upcall_pending gets cleared before >>> the EOI). Maybe there's some corner case I'm missing that requires >>> the EOI to be performed before clearing evtchn_upcall_pending? >> >> I think for the purpose of the one vector doing the EOI late is okay, >> but aiui the goal of doing it early for edge triggered interrupts in >> general (and yet more generally as early as possible) is to unmask >> lower priority vectors as well. > > My reasoning for doing it late was in order to avoid adding extra > latency to things like the timer handling, as the EOI will likely > trigger a vmexit. > >> Of course that's useful only if IRQs >> as a whole are unmasked during (part of) the handling. > > What do you mean with IRQs as a whole? Are you referring to setting > the interrupt flag? Yes (it being cleared). > Thanks for the input, it's appreciated, and sorry for diverging the > conversation so much. I think that's quite fine, because aspects like the one still in context are at least potentially relevant. Especially since here we're not dealing with architectural behavior, but with an extrapolation thereof. And views may (and apparently do) differ as to what the correct extrapolation would be, even if just for corner aspects. Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 25 09:18:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 09:18:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448125.705000 (Exim 4.92) (envelope-from ) id 1oyUqO-0004rP-RM; Fri, 25 Nov 2022 09:18:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448125.705000; Fri, 25 Nov 2022 09:18:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUqO-0004rI-OU; Fri, 25 Nov 2022 09:18:00 +0000 Received: by outflank-mailman (input) for mailman id 448125; Fri, 25 Nov 2022 09:17:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUqN-0004rC-Bi for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 09:17:59 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0602.outbound.protection.outlook.com [2a01:111:f400:fe0e::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0c7daccd-6ca2-11ed-91b6-6bf2151ebd3b; Fri, 25 Nov 2022 10:17:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8022.eurprd04.prod.outlook.com (2603:10a6:20b:28a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20; Fri, 25 Nov 2022 09:17:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.020; Fri, 25 Nov 2022 09:17:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c7daccd-6ca2-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VfxIXci+jt8fjNnj+h6PzRcXT1Z0btT5DClxEJgZlg89SWbif0wEAPBJPVxDImHX8f+9L2dAwgvHZEi9k650/PrH3Qtdp56AVA1dpMYBYPJvh4Ngu26268I48PiSAx1YqOM+ZwZVhRvW1Jj/bWFCQfmCDK7hzVTGWn4mzKq+8d2XSvyL+K1Mh19oZjE86awB9UnmeYTaMMAhDfUoXS0sxmlhmpQDrJne/s81amzXvYHH+uGwhbfyHQQ4rd6cCvZG9DNyqbM7zGuAl2QIRmBJ1aRgexgn86CkU4W0Bc6sfHN8I6AGORcecH7ebRy71bw5HqhZ743+oTdqG893mPfPgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d8Fx0aXdUkvYV9pxscOdGfz/m7b7C11B1FxCnhAwm24=; b=IHbF5/mrIa5IoERkXQntnEXNBt2uTuOTgf8uHWfcBomy3crcHHbHAVYzkxbvmPlpw7kmtdmTqojPsKbLqG6UEqpqAVMJMWjK7AB99qMG9/8G0fhG8ijo7fB5ngSShcfvXNlYiKfr3/xleC5NIZHZubeCtYdMxkxFj5OSg/QGLYGi/Ws9Mb8l75JY1cLsJ9cA2WlAPls6OHMZ5sa5chlEtEHXq0Q0HrHA/BNHYFMaZKagvbddXRCiLULWzQn9qIUvLqlfk8ivz9fk4mSJYO7hAAEq7GfUDnFCbITDc9DFxJskp+nP3o5daAQjRb+x0CnC1H4y+sG2UXossD+HWB5MGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d8Fx0aXdUkvYV9pxscOdGfz/m7b7C11B1FxCnhAwm24=; b=hlb/cNpx8wlTwlygbgooaOP/VoXyOxLovf4uVclSGVPYFYL8UGCHcuNe2znu/IotUyNQoGX9x5qEbyr+appzNgxpSAi9fgwz8FWV1jXC1Wd5/aqXzu3B65Yc13KE1THroHW8lh4x/kuY7+p0RpK43A261+xz3gYco7ZLcz9t5/UPmtx53FOgq4nYykZwLUE4T80zcu5l3z7i6Ab2mE7vIQcD1ipR7Ng80HQsDi0BvPot8Mng4zXd4hKZ+z8JHlqzqFmWnubsXqNGgA1gZztkrMZlW2xSbYPwVj9kh+v366ElKEcNCFB/w+wwphQoe3ydrnUeZTcHj0FVPURDkHCsEA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6819d05e-d1ab-fc3e-7795-bac650df3bc4@suse.com> Date: Fri, 25 Nov 2022 10:17:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated Content-Language: en-US To: Julien Grall Cc: Julien Grall , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20221124190850.35344-1-julien@xen.org> From: Jan Beulich In-Reply-To: <20221124190850.35344-1-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0134.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8022:EE_ X-MS-Office365-Filtering-Correlation-Id: 9bb405c7-84d8-493c-2093-08dacec5efa4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lF5gZUBXJUbfNZZ3zmNykzYxjKTTs1a0ver5DSmelMd61+TWzwvSYDdfJo2PWRE+L0gu5PLAyL1s0X6qXk9b4v/Q09Z76UBx4Lka1s40xl2YPB/mmwSIgMLG0wJFrmh8F812drT4FCtKM08+BJivRwa4w4TeDEYqBOZzZfgPf8MuKchjhg3642uY5gQsMsF/2s6DdA1D9hZqjwICCDf7j3nw+1dOQ9tTHbbDlBypZuqzKKDtDFq6Lgl6aXnsEWCnTMgBKY3Y0yHqDEB8HckoAMn284blx2A0eMNPYv8Ihwgx5I5zm0gx2EAr9FA2g8V6bWu5ebjppQ0f8nzZancppglE3unkREn/76j0S9jNoubo2x4L5GpAPSZdCW8wQTlZOsAXGHe7wrHZmT1gwmbtLwWVMVjyZbj3eH35Ab7N2ebXlE8inOWLAhOpbjr+8RYKQoKwPQGHR1aJfwvQyqwtegUJAoDt1li9slQa8nh8k7W4Xoq43Ehs/2oFzkeqX8mv9CJpcmmEMguLY8hAufFPwogGPBeAyAmBg1WPjdCmpZS1a/Xa7TbNIKkgZHvb/nizeXsBZDNKMJ34ZrPVFCnPZURY4iv3/gWKUZ/Li2VQR83ny6zYc+jGGcrNZUp3LdmXoySdQc66cE45g9ezSEseVY+50oGAF8O2Z1lQo7kn/3PS9DPJDWs/W1Kjr2Pda8SyC41Q4brhS+Fz2qBf8zZAAH/CyB0+/N22d8Sa4fobwfw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199015)(2906002)(31686004)(8676002)(4326008)(86362001)(5660300002)(31696002)(36756003)(66556008)(66476007)(66946007)(41300700001)(8936002)(316002)(6916009)(6486002)(478600001)(38100700002)(26005)(6512007)(6506007)(53546011)(186003)(54906003)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHZVbDdGR0FWSFBqRzB6Y3d5THc5b3FyekJOQ0plOUZ3U2JZRUhhdnoxTEdM?= =?utf-8?B?dVNscDJvTWd2R2FDbHdVdWVNUVc5T3E0UC9lSnBBMHBoazA4dUVGUTUxSWg0?= =?utf-8?B?YlE2UW9FL1EyZjBlL0Y4L25ldnVEMnNtOTE1dXBIS2lkUE5hWFhPZE1paE5s?= =?utf-8?B?TXFHV0xBZ2lLYUhBQ0lWdE5IV0N5Z1dOWDBzQ2RMNUg0QjNaQVA1NDNTWitM?= =?utf-8?B?VzBpTGZIa2I4eFo1UHU2Z0Q5TXpYL2JqaGdmaTJwTGZZZGR0Mk8xWkRRaENY?= =?utf-8?B?SldWcUh5N2Q0Y0kvZjJKV041TE9PLy9FRWZaU05PTE5obTBQZzFSWHFpOGNB?= =?utf-8?B?S1gvckJFSWNuQkdPOXlvSWUvcFBZb05nK0ZyQitadEFoRkZRVDh4Q2Zoc2dZ?= =?utf-8?B?WElaWjNVVm5CTnN3dXhUejhVd3pkemFxMU5FcmFUOFEySzZrVUV2K254T1Ba?= =?utf-8?B?SWFBWThmb0JZdW1SOE1pY2w3VDRTVmpGNU85N25uaitRZ1hNZUNoSnZ3RG8x?= =?utf-8?B?YXd1ZldxVEhlOEhXd0luYWhqMk9DRy9pL29OVFB5RzlKRGZIeFhuck1Sc2JH?= =?utf-8?B?Znhpa3VQUjk5OGVtNzBtRElNc0MzOXZYRjlsMlJhemt2YitOdWNBc0ZwV0U3?= =?utf-8?B?Q3pvVzFvRkxoaTVpc2FuRHZWWnlzRTlvNXpUNTB3UVVTT0RuZWF3L3ZkM3I0?= =?utf-8?B?UTN6cWFDVkxtUmlZNmZPTGQ4QnQ5SEhwMk5RNWdkTWE1SVJyeFdPQmtHMkFR?= =?utf-8?B?dHJSeC82bTYzWmJtdE12aUR3cko1Z0xMWk5tK2xsMDFYekxXUGZmY3NIUEZN?= =?utf-8?B?SzNlN0FiS3VQNXRNbUtnMldUSjJhVkg0djh0aElhSzAxbXovMjJ5WVRReVFa?= =?utf-8?B?Z2l3MHVDUDRiaVpKREpYR0FDZk9TQVlMMlFYelhzUEJIdlg4cGR5WDNseHI3?= =?utf-8?B?RExhUHorK3hOdW9yeEx3WnpkVGpoYmdHdVRUb3NHS0dzUytYcDBlUkdPZC9R?= =?utf-8?B?MEU4ciswYU9TTERDTkNEd0E1bEdzNmxKdytkSm10TUFiMWVlRCsrUnN2TkN4?= =?utf-8?B?SGpEMlVGWkdRcGV4cy85V2VjaVp3cS9JSWY5aTAwby9Ka1dKc0N6R0dGN1Zr?= =?utf-8?B?WFZLUUQ0K1VzcFdVcHRKZmt3NTdQajY5VXpQdDBXV0F2a2d2UEN6MDBQVGdF?= =?utf-8?B?cFZUTXVnUVlSa0NNb2lIZjc5bmY2NkVJM1J0djJuaWpJZGl0WjlxMUYvNEI4?= =?utf-8?B?WURwdWlmS1ZvUkZ6VUJ2U04xSk41aE5mZnA2WlNMU0NyNUxTNExtRlBvZ3RD?= =?utf-8?B?a1A1RU91UVAzU2VsT1huNUtpZTZ5cjdmU2V2c3A0dFFpWDhuaklUQzA0cDZ1?= =?utf-8?B?U0JMWk1KeHd0bUllNm5kRjNydmZJVE9jNGE0dW05bHRpeENoOVlFSWdyZmlT?= =?utf-8?B?SC9xd3M5aGdoM3hIMkVrQlVRMGZZL0VGRGtIbHo4SjlIemEzNTFMcTRzbHNl?= =?utf-8?B?NWd4Q1MxMVdPNGc0ekFvU1RyS0V2K0ZhVjVyY1pzT0RBSDF3dHZIbzVXL0da?= =?utf-8?B?MjdJdWNQOXBJRWQvWWFMaVNLb0hLUit2VitsQ2s1VS9zL09oWnJScmxiMjUz?= =?utf-8?B?REtTMGUrdkNHYndER3dkeGdudlUwR283QkdTcVA4RUVpRnBRZDJZdEVOajYy?= =?utf-8?B?SUlJYlhRSldSNHRlSE5RRDNrbE55TGRqSGtnYy83MTF2NDhITW5JMG5IY3JO?= =?utf-8?B?bkNTY2F1L1R4Nno1azc1OW1haUY3MlZJem9iNzVORUZGTTFzK0pBQWhUZUo0?= =?utf-8?B?NU5UZGx3RE40OTA4R2RONjI3VkFsSDRWNHVFd2l1Q2ZpSnJMbzVOK3VyaVQv?= =?utf-8?B?TTdROXRlSzBKazFYTFVwdGVGMjlNQlllQ3NtcDdGQ2FieFovc1RhdHdhSTMx?= =?utf-8?B?dWN6Ni9EZWZ3T2hVaHUxMlZZa2RibUtjNHBsUklDNjRrZUVhNHhSbmdKdTZM?= =?utf-8?B?U2RRWU9KL2t1cmVrTTY3SjRJeFN1WlRrbE9sS00rUFR6ak5abkQzNC9tSGs0?= =?utf-8?B?RUhQcy9QUU5XZk1xWWJGT2JyRlZ2K3EycmdUNnpVY2EvUVdGS3hUa3h6Wmpp?= =?utf-8?Q?Ro8av8rIaJ3x6sJ6f02uO76L1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9bb405c7-84d8-493c-2093-08dacec5efa4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 09:17:55.3705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ckqCEDuVM0ZEfgWpeaGRxsecfNmhrIaGC3rFXXELd2PDLubXmBp8lFsclLIEDsN2Qk7ujoBBxgniM58ZmJ2LFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8022 On 24.11.2022 20:08, Julien Grall wrote: > From: Julien Grall > > Explain how the banner in README is generated and take the opportunity > to mention what it should look like for RC. > > Signed-off-by: Julien Grall Acked-by: Jan Beulich albeit with a couple of nits: > --- a/docs/process/release-technician-checklist.txt > +++ b/docs/process/release-technician-checklist.txt > @@ -48,7 +48,12 @@ t=RELEASE-$r > > * consider bumping sonames of shlibs > > -* change xen-unstable README (should say "Xen 4.5" in releases and on stable branches, "Xen 4.5-unstable" on unstable) > +* change xen-unstable README. Should say: > + - "Xen 4.5" in releases and on stable branches > + - "Xen 4.5-unstable" on unstable > + - "Xen 4.5-rc" for release candidate > + > +* The banner is generated using figlet > * change xen-unstable Config.mk Perhaps insert another blank line between these two bullet points? Or, if they're deemed to belong together, remove the one you insert? The new bullet point you add also would likely want to match the others in style, both for the number of spaces after * and for not using a capital first letter (maybe "generate banner using figlet"). Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 25 09:21:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 09:21:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448128.705011 (Exim 4.92) (envelope-from ) id 1oyUu2-0006Hg-BP; Fri, 25 Nov 2022 09:21:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448128.705011; Fri, 25 Nov 2022 09:21:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUu2-0006HZ-8a; Fri, 25 Nov 2022 09:21:46 +0000 Received: by outflank-mailman (input) for mailman id 448128; Fri, 25 Nov 2022 09:21:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyUu0-0006HT-Da for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 09:21:44 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060a.outbound.protection.outlook.com [2a01:111:f400:7d00::60a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 92e5cc45-6ca2-11ed-8fd2-01056ac49cbb; Fri, 25 Nov 2022 10:21:42 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7716.eurprd04.prod.outlook.com (2603:10a6:20b:280::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20; Fri, 25 Nov 2022 09:21:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.020; Fri, 25 Nov 2022 09:21:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92e5cc45-6ca2-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j0AFjhYiVz/3ataw4kMTG4djMI6MFvsBStsdatNk2QfQr1tqvqWzDvyhHvplLNa3BQWtYNdqOf5EPnI/gi58ftSdX2gvALJ4aGrE4uQCNBwDI7rIq9f4Ab506bP+x1FgnvavGeCEJCGCy0F0vBU9TRsM4bck/u3KjLlNj7UVJix3IKThj/6aJlVM0MFmfVPQX16Z4EOwGD89dU08gTapMeK6l9JvjUPUCMb1QLn2WhDiSDPWCZtcxkIrH4fjkimpIHcRQ1LTPCEZt2yZvurr5qp9KvMXiNrjOKC74QHsHSkSN8vdeYhd3YzT0wiSyM7I94Pk7x0fo7BntGNtQzX0aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x36wMapdvsBO8qOoOwyv+jcZBZsrYD/cX/YnDitS7fU=; b=JZAZj+lrtx+hcoiE5rYo7kuZ8YS0pJdt2epfskoefqvJZNhRlDqJv14HGAT7iSoVrncfeN6VhtfpszTgVUJivJp1bqcur28CBkERT2AFVLg8iZ84EuojAyFQH8VkVfIAFke46r8ZNKJLSTIQJM5DqiUbvAbyRRkxvqZFmm7lqS4KdOcN9/hZ77rROPThWBm6XARG1bMyTozckBnJ7q6XdBnPJLFN+X2rgUhnqvjZZH2usD/XR6e+Z1f0g6ONkIj3t9GvsszkW6trHt4uV4tucsWbwcqOe4MAbMyC9RVk0srCxHzfx6cnYfq3GroxpfDVxrZZ3fR2kb9ygfo1a9Mr2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x36wMapdvsBO8qOoOwyv+jcZBZsrYD/cX/YnDitS7fU=; b=Q6k77pz5kth/q5dEHRuAf9HFm1DKKEhn9qewDlAMQ/5iXPrX/Vx+h9B5f+Lr4idnbSFeWJIB/MuuRKm/rmVQ9ZyFFbfB1M6wtP0sziNXmqwCeaxVAieyIMpvTa9FhRAW84mQfhA1N6McfHknGJJN7hMNSIL6WU3tmB/XsoL7/ubL6avDeOspRY+HNOqSmkObUcDmtN97t/rKC5ek1rka0PNYt2mmINlxcfsnELSaBel50SFn/SV+dOL4ATEIeoYRJpaEoL14pM4UGksSP/n6R/1jvLniPPdzgY56wiSwgOQ7mUJZ+zATPNsQoTZBq5RysvI50ZSo4jyHLG4tKBAkEQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 25 Nov 2022 10:21:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [xen-unstable test] 174958: regressions - trouble: broken/fail/pass Content-Language: en-US To: osstest service owner References: Cc: xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0011.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7716:EE_ X-MS-Office365-Filtering-Correlation-Id: b31f8e9e-6416-4434-dfaf-08dacec6755e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S4zCUFknVRmqfDw5mmTkN+Htsurzdz3Grs4KqeiVqxAP79jcquCwvwjF8ohwOpQ/8cSBGp7Bc2eMRoXt9Tk+wHE06KWglnFXZwhmr51Us7w9v0H7C0tBDbxVuHy9ebC7GC556b1w3ga/zcN9X5smgJrXygHAvO8tFo+WJjiKUXGq7a70GoY3UrG1PSVQ5xf7yKmdpVbf2B4pmAhCxsebEzPkvW3fuPQoqFGXpqJyIDVSwGO8u+b9G1MsLnhw8WlD0cOorbjpphXBRSfKc4GzEQcLa9kpJZodYKX7QJirRAa78fB8v3U2p8u5ISFaFSF9Wuozxbpff6jrpTzhax6ZKvtxk15T1oUBWRBmzr6xhxADT2nxOR4LdptZfqm190To8ckAjNQSe8n2YU7gUVT5T8ibJ2RW6AKTuUuO+ZA2fnvfXiiRKcnMnMzs5woO08iM9Tkz1Lmo+AhJRQc0ff+3qV2JTlCcabuuJy8iAF2efxfNdz4lbEHI0rKRe4AHUFSg0k/iAj/k2oHtrBaVr6fjZBzzZMutgdsUTSlZzpz6StQy/e6kRy7DNylJpsfynUr2GNvSkQET93s18aw+W4HHwJ7Xj3J4S2WYuI7HfS8Qyla+RE347FkuiyI5662XtpyBINCQzvpMtUDlzNdh9pyKX9vgqu/QapskGGjeJlTrq72SRjx8yy1Nz8P18tu32wrRDvnszQULOe6/ylNkYF+eFyl/sCdrIlbUwMSmdTn0G6EBg1rSUwh8Y3AOgchjcW9BIbZEZwyFA8eElFzqpekvcw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(366004)(396003)(39860400002)(346002)(451199015)(8936002)(4744005)(4326008)(8676002)(66946007)(66476007)(66556008)(2906002)(41300700001)(5660300002)(31686004)(6916009)(53546011)(966005)(6506007)(38100700002)(6486002)(36756003)(316002)(6512007)(2616005)(26005)(478600001)(186003)(83380400001)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VlNRNmtzQjlVOUdjRk5sOGhwbW5RTkZadm9yd3ZxVG9BcWtLbHBudDB6bE5R?= =?utf-8?B?a3grNkYzb1JLcUxPNmNxOHQ2TkY1aTNUZHFtYkU1QVdvZDBpTXhCVnpwL05q?= =?utf-8?B?bjFOeFJIbXNIbGtaT0FnQUdPWXV4UFpKNzNMcXNmLzc2S2E5NHZyM0FsMmZG?= =?utf-8?B?QzBIU2ZpU25WSzV5MlNYTllKQVE4UlVBb05YYm9Oc2J0d0Ywa2ZzM25iaXNM?= =?utf-8?B?ZVZyT3l1MysvNUh5UVpZOTRoa2E4cGg0YWlNejViemtjNGc4aURteGRNeC9Y?= =?utf-8?B?bmlqYzJMTVRFbUsrWEdCWXgxT2FlZEdISFdIRDFvMmdTbkpTODE1SGVhcWVZ?= =?utf-8?B?T1lQZ3k3SkRGVEY3NTQ2eFB2UmdESTlkQWkrV2pybVVYeW9QYVFkVFFPN1RF?= =?utf-8?B?U3lOR0toajhJaUxyZVc3UGhhWWRJZjlHOFV4emNkMHhNdklTS2d0b0VaekNo?= =?utf-8?B?Z25FNkRSSk1zQzBBbXBMSFdHUlQzRG1GZzM4bFZ1Ryt4dEJvWkdVQW5jRFNo?= =?utf-8?B?TEtBdlJTb1RtMzZ0NmdUSUZnMEgzNVpaRGlDVXlCUGhodC9RYlpBNlFaWk51?= =?utf-8?B?TUxnd2VwUDV2OHBqM1lUVUsrMFZQMWtyYkhBazdSODI1WU8yeklNbXo3MnEx?= =?utf-8?B?SmdoWWZjTlFVL0kzQVcxY0lHRTV6Ry9wVHpjRUF1WVNrSTVRTnZ5QmRYVFB3?= =?utf-8?B?aFZvYXArN2Q3RWhHZHZMZG1yUjNPNGZ2aHBzb3hhOWtsWS9qcW1XVXJ4ajMx?= =?utf-8?B?dFNpRWtML2NaNWFsRjhBeXVjVEVGOFpGdHJjSEJORnFua2dXZkMvTEVHOWxq?= =?utf-8?B?ZmQ2azAvd2tWM0ZQSUVxTGI1ZXlhRGcrM0R5TUo1bDRLQVdadC8yOHJaNWt6?= =?utf-8?B?eGlESGRHVkUvQ0VPTW5wcWt5YkpMUnNkQ1hWRW1NdS9qTG5NM3Q5UGM5N2hO?= =?utf-8?B?RXlkeVBlbmRidW8wVlBlUEZ5c3FwWGxLcmVmWXBOaFBtQk8xeEgyenlJVXh4?= =?utf-8?B?MUNCYTZjLzBwMlBXbkM1QkVrSE9wS3d4eVVSeFQrdkZBSDZIK1k4WEkyOWJm?= =?utf-8?B?ajBZbmMzRW40M0FDdFV1aU1uQ3ovdUVhclhtdkxkUnBrS3QyY3pmYjlEejhq?= =?utf-8?B?NXkxZXJjRkhUUFBMT2tCVnU2Q0VaWXNsblR0T1RiNWJpa2ROeG5BT29rOTh3?= =?utf-8?B?RTR2OG13d3AxcHVXcGJ4OGo3Nk9QallqcVNYSlpLVWdYazk0QnlDbmUvM1F2?= =?utf-8?B?cHhYYlZnU0x3WXdPYm42b1VYaXU2dGhTaklLYVFBRi9YUTBXbnY4SzVJaTcw?= =?utf-8?B?L0FuR3NPV28yUU5CQTU3QWUxYVVCcWpScnJtTUFoVW9XZ29BR3pWemM4N1I0?= =?utf-8?B?YWNaMEtrME4wWUszcE1nbEtxVk1hM0tSVGk5eTJXeHdWQzBJUVk5NUk2TGxz?= =?utf-8?B?amZ6aTFLSHpob1gyclVuQ3ZrR2hjL3ZFcG9FdWtSMWxrREFLcndoMXA2bHpo?= =?utf-8?B?M1VVNzd2L2hXSUdQbCtjeEtlK3FXVG5QM3A3N1ZkcXpkZVNVRFAzdkZrLzdt?= =?utf-8?B?ZVV6dzVTSGhJMVVNR2hNdStLeC9sanpaY1NiWG9jS01uREJrZUlKMHFkdVFU?= =?utf-8?B?enJIdHArN1ZDVkdCam1aaG9tUUZQcGZjbVVQQkZzMEdCWS82M3hsRlZTMm9G?= =?utf-8?B?Y0REZGFyM2RDZnJ0RVZ5Sjh2REpQQzhzNEozYjV1TnJnY1JyQ1dNejJkMjdC?= =?utf-8?B?dTYrOTgrYWYvTlI1U1JEZGIyOEt3WmdVOVNvVHlTZjRHckt6WXBNTG5nYy9S?= =?utf-8?B?SUZKSlZURFV0bjJ6U1Y2YzJYMDZUSXRGQWZrNnJrR25NZnU3em5DWUNIMVVG?= =?utf-8?B?SWROM0ZRdnNhOXFlS0VTSmtFQWMzNngrenYvR2RLZ0RYenBqN1U4VFoyWW5E?= =?utf-8?B?SlY3WUt4Um5DbnpjSndIUzE2Y0VuYURIS1NCQ0xGZW4zNmtrZjBQekl3TXFT?= =?utf-8?B?dVpTMVhsQWhrN2NRQ3R2K0pXeGN4aGhadHlyYXpxRUlNRkxZaDJyams3eHFT?= =?utf-8?B?Q3FoclRTVjBvTHkxZEszVjNLNUlOUWRNTVVWTXh6N01rTzVVaDVRK013R1FL?= =?utf-8?Q?3CT9jCcnJkP6cCy9UPgt0rLKq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b31f8e9e-6416-4434-dfaf-08dacec6755e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 09:21:39.5907 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B4mJLkSyqrS8GL4q/NIfFRIttfDcz0RD9d5xW8aMNOzWTUll833v7UH6oWD6qRmFHP3PXGlLzluIq8u+2dg3Kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7716 On 25.11.2022 09:10, osstest service owner wrote: > flight 174958 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/174958/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-amd64-migrupgrade broken > build-arm64-pvops 6 kernel-build fail in 174950 REGR. vs. 174958 Just out of curiosity: How can an older flight be a regression vs a newer one? Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 25 09:29:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 09:29:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448134.705022 (Exim 4.92) (envelope-from ) id 1oyV0z-0007Ct-6X; Fri, 25 Nov 2022 09:28:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448134.705022; Fri, 25 Nov 2022 09:28:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyV0z-0007Cm-3a; Fri, 25 Nov 2022 09:28:57 +0000 Received: by outflank-mailman (input) for mailman id 448134; Fri, 25 Nov 2022 09:28:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyV0y-0007Cg-8C for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 09:28:56 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0612.outbound.protection.outlook.com [2a01:111:f400:fe0c::612]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 945b391c-6ca3-11ed-91b6-6bf2151ebd3b; Fri, 25 Nov 2022 10:28:54 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7181.eurprd04.prod.outlook.com (2603:10a6:800:12a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Fri, 25 Nov 2022 09:28:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.020; Fri, 25 Nov 2022 09:28:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 945b391c-6ca3-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N7knIanIdZhIn5tyG55OIeGPHGxVOae0UINHrxnufLSv5KJTp9x0wCzIJpV0toVz92x0C29uouW+mWosx/ADvGMMJ2X5isKjKJ6SBYMFIyMEM6D7yDp5R7+B8j+KbXc1EXgCLin/n/k8qXdQgiGzZeWzGLuM+4ni4BTRuB3G+6rWBDCzXujxu1X84mCCLTUlcejIzaNQG/SWVvXty63Wonb9Ou2CIwbQ2uvghJEMHnO5Q8w5xobZ4Ve44pbkk/ikW0vqdbOCGxlMb4VqdMAuxmAZ6eyJM/a1dLz2jZhJYK+QoXZI6nu5hEL/ptbVbtEdA2a9WCrmEE17/PkpIa6YLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TPyue251BK+G2vemnLqNepnkO7/seUcFG+WjoH8+TZs=; b=mD8AEuZDqipoQyLKmywdRc7Y7kCf0RuKAqVScCz+BMWvdJaKll7LhZ11chk7qLGaGvZpK2jjEei6V0LdLeSVcSPYal4LjJcVvwiOQ5QZ/ewB//AeUG9ivULqEgWHXzLHP4Tw6HbmYFwvbGA9HV37XH4iwoJd3JMcFTDG6qubCiMzRfXEc9Cb9MMkOqIMsxRQEffmUVrgtQdR+uqHRWyNRnLMUzMh/63UpEA4mCOhqJI1CyTaFCOqGHto+ovrmVf3icV+0Df48W0iANUjUp/yOvEakZHOFaiUhklRuKsUi5mrV3hvB9+3cpa1N/Fua1vlexh+JEiuHmsHuxERG0+XMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TPyue251BK+G2vemnLqNepnkO7/seUcFG+WjoH8+TZs=; b=qkV5rcrgNCp/rzRATtPvkuwQW6G5xN5b0tAEnhjUOQaEMgnpqEmbOEZIhl5QRzxz2ADT2CH4xBAII75l0L7xmStnur5rQqL4BEsGj9eN1E0ve8oWco+87fKc+ZHxzVw6ftRNgQpvl0kAx7C14ujcL8DyxOzZFH5cTVdx3bizdHaS57yO4BXAph3yPDnOVJZ+sK/fbx12wqWQ6Baxggfyv7x37fXSTzCu6YbGjPVUpIfS7v0ZLbiboEr8hdg4KtMnaaQ1IgEmlOLrUGTOgU/ERXcwBIwykGjW36Siser7T/3qM6QXW4ySFaMVMqjH1gMnTi23LGKMLzE11YLa3Wqaiw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 25 Nov 2022 10:28:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN PATCH maybe for-4.17] tools/include: Fix clean and rework COPYING for installed Xen public header Content-Language: en-US To: Anthony PERARD Cc: Henry Wang , Wei Liu , xen-devel@lists.xenproject.org References: <20221124164254.33476-1-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: <20221124164254.33476-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7181:EE_ X-MS-Office365-Filtering-Correlation-Id: ee8de151-2e5f-4166-0713-08dacec77801 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q3TWV1vu85gBvb+4U9TRqDe9IU+M3rejJytveG17X96ZHPFs1GLa8d+5KczJ2V5tPxz/hrGDGgpxLWq5LEiJBMRfOhWpeNmhoMYriodExmpdbefTuccoYviPDS0IGJ+Te93WgZu6/v2Nd7RZ7ohyLw+hh4BVnhJ/QC3/1aEjO81rkGjaElDNeZQaP7zRHUAQBVJ98dTSHSuam+Sb3QdAmIJyxhaDPX/9ralMCm0kmJrm/nNXcdffsdeIur+NWRSU6GqznF0Shr8XF5ucbn/Z8mhqOaEVm7p7a/+AQscrQrSzBfINVj5N7ud0eF5/y6ZIxAY5vzLsgMb1f7cd/vv+Q3QWtYI88rJpqsgxfHHTyzBtFSOvne49svmimbENmjSUJmFxg/aeb0W2VgKcjS3HaXR4xX33F81Xu4W2mUf/VanzC1y0QN/Jyx9O+eFz3ZNYJeSrYMjoqIMm/VREPXLeEtuIiExObPbuZA4AcndK8A18g8eiYWSVXI36Vk2UnEPPjSy77a7KYdVt3LJPx8OKMn1yvhx8VOhM8sQRl9fUTJkM0CfGm+ygZMjoeQ6C8M8OUQm7KTrZQ9OCbUMc3JI+CdNyJrN9vzrRkq15OjJ0lbzVexeq3o6T9azA3jlBxpTpdCQFjk6U4PXAConIqwYUtvArI07iqKk8ruKjuS8p4sHbtPKfuDo26pNIZwwKnjTv496FXna2s4TpJD0hPWvFDB+kdfMADsblvrNQvehK6DI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(346002)(366004)(136003)(376002)(396003)(451199015)(2906002)(31686004)(54906003)(316002)(6916009)(36756003)(41300700001)(8936002)(66946007)(31696002)(86362001)(5660300002)(4326008)(66476007)(66556008)(8676002)(6486002)(478600001)(26005)(6506007)(6512007)(53546011)(38100700002)(2616005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXRRQWRsd2VYbUNET3VUMy9wZE43MmZIQWFMeU5qdlgwMEZzRWpBaXg0OEJy?= =?utf-8?B?ZUtObXJPSnZtSHVNUEdoWXVYeDFFV2lhM0pLRzhaL25MUUlJamEyTyt1cmlp?= =?utf-8?B?cXBoSW5odEcybUoyREJBa1hKeE1TbW0vWjNBNGZOZ2NsZVFMK2ZjTFV3RFBz?= =?utf-8?B?Rm1IYzAzazRqelBKNWRRL2xncUxzWnA0V3lmTSsrdlhmOG95RUhxa01NVkVT?= =?utf-8?B?elVjTFYxdmVlL2lsTmFmL2NyVXhma2lGZEpGa2lNYnRXOHhYTEo2bGxWRFNp?= =?utf-8?B?Z2k1bHNnN1p2cnk0dWlWb3FXSUwrWGZmc20zVDZMTVd6aVNEZjBKb0dNNlky?= =?utf-8?B?aGRrTWxGWkZSYWpZVGtKSnEvSk5zcWV5d0l3SXRhc3FkTWVXMmVNd1hKUkNw?= =?utf-8?B?Zm9RSm1xRW0rQ1RLZy9valJzR1lVckpZMUR6bm5Cejl0ZmxSYUhPdktwQjA2?= =?utf-8?B?czVaQ1gxK1Y1Yk96VXhYZEJnbHFnbGRSdC9oWVZjSkpoQWZPR0JQdVBjM1Js?= =?utf-8?B?WnkrOUd3MHZKVGZkNHl0WW5peno0aGJKUldQRGJLOXpYTnFVNTUySHZsRXE3?= =?utf-8?B?eVNXUG1tT1lRMDlJbGZha3YybzZsWWFKOHhEb0E4OFhCSmNueTUzcjYzTGU2?= =?utf-8?B?M0NuRFVtdFhpRnFrVVZxM05pcGJveEd4VDUyY29oTDRTakFwZTNHRzdrcjZ0?= =?utf-8?B?SjlFWXVzZjV3Zi8xb2hLT1kzSGRNeUxseHA4TGpaNEJlRURxMlZteW8xMmZo?= =?utf-8?B?NVZMTGRhSW52THpRT3hWeGxSRm55Ti91OC9xNUdiRWJJSUZvakwrRWpwd1lY?= =?utf-8?B?alltUHhiZ0VVSXZNcXFRSlBTZldqdEVBVk1FL1dTR3RYdlpJY1c1RVZWT1oz?= =?utf-8?B?SGVubUZJWFdvUnNvOXJFR2prd1R2dkl0M1BaTUJnTHRyNEFDbUYvV1N1QkNV?= =?utf-8?B?SEJWMTFFdGVyb2xwdHc5aEJSL0R2ajRlcHdQcUFsOVZuMTVTMC9rOVMxTWd3?= =?utf-8?B?LzQ5TE9MUHVmczQrUFh1dS9CU2tDMS9Wb1hyOS81MXBrSlo5S1J0WWZKd2E0?= =?utf-8?B?bDcyMmNwSy9icHZKZC84OFJZTkorNlM5bHlIV1dMblZGZHJUR29ZS2pZcFhX?= =?utf-8?B?T2pPV3JkaDFmMjJ6NzkwOHhSTGR2VSs4Wk5BYXVCMUZzVWFTaUVZTTRFbjgz?= =?utf-8?B?cndUMi9EYldQOEd1MnBDQTg4WERmN1A5MXE2Q05USk9UWTdaczZCTzZjN1pM?= =?utf-8?B?Vm93cU1yRTBVZHVlV1JmY2NSY3UzYks5RW5CN1ZEbVliYS83UlB0UDFqZU5F?= =?utf-8?B?MzZNaVYyZjJRbFB0WFcrdHpOUU1tWUZZS3loUlBYcVlYWWtBRk1SNkxFSVIy?= =?utf-8?B?bHlXQm5MME12V1NYVU1SYXNBTDBLcVJ2b0ZNN1VLS3czajI0MTErbDl1T1ox?= =?utf-8?B?a2RDbzBXL0lVTkhIdTBWbVBuQ01nUnpMaFpucGFtL3BheTRJcFRLMXBoWU1z?= =?utf-8?B?MlBrSiswUndNMGxJMU5oQlFCTVZoSkhkd0RvV1p6QUIrSksrdWxDT0VLR3N2?= =?utf-8?B?U3p1dFkrcWlEUE9wYS9LbGNFVkNpbXp1dFZOTkdBOVVURHo3TFVNbkI0RnAy?= =?utf-8?B?Vi9jQzZaT0U0ZlNXSlcyN2NzcHZMM3Vmb2kxanloZVZNVDQ0QjBjS2hiT1Ni?= =?utf-8?B?dzBycjJKWkg0UnB6RTVmbHAzQ0Y0YnlXcEZtOGluM09RcnE4OXVHa0V3NnBu?= =?utf-8?B?cFVRaGpqSjEyMGg2QlRGSnk4bU80eGxLdEZXYzdVSi9tdHZJdHUzUHd2aG04?= =?utf-8?B?QVowRE1kYWJSMFVVSU83MW8vd3QxbVJUV2s2TTZLU295TUwyM0NXMzNpYzZi?= =?utf-8?B?STlnY2t4S1FCYWVJVTNSa0JHSTFOTGJ3cFBqWi9RUlVYbUpTVFk4RTVRWEp4?= =?utf-8?B?MWFjbVQxYkNBTFlLWkJ1ek81UUxvSVAweDZ6eERDQVE1UUNJVkRUeWxSTnQv?= =?utf-8?B?bHloRk54NlFlU0xOL0hSeDlFQnNpRURlZThkSEZDVnA5M1g3NS9JMmk0QjZp?= =?utf-8?B?d0M5b2lESXJ5QXY0Ymt0dm9YdUR6alA0KzNnL0Zvc0xBNVVWRGI3b3E4WUNH?= =?utf-8?Q?3ZZFWehDYw7UGaJRFiWkWjBU3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee8de151-2e5f-4166-0713-08dacec77801 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 09:28:53.4743 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DaJ6qWKOPlgV5MY57vmCEUbDbeUw/9fnEMLcr/WYr1MdiEU3SGOfGFJ8Dafxo2KzflTYIjNpceoMvh6OUSUmTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7181 On 24.11.2022 17:42, Anthony PERARD wrote: > Use actual include directory used to install the public header in > COPYING file. > > Also, move the input file out of "tools/include/xen/" because that > directory is removed on `make clean`. > > We can't used ./configure because $includedir contain another > variable, so the change is done in Makefile. > > Fixes: 4ea75e9a9058 ("Rework COPYING installed in /usr/include/xen/, due to several licences") > Signed-off-by: Anthony PERARD Reviewed-by: Jan Beulich (with a question, perhaps just for my own education, at the end) > --- > > Notes: > For 4.17 inclusion: > > Doing `make clean && make` in the root dir is going to fail as make > isn't going to find the COPYING file while trying to install the > includes. I second this would better be fixed for the release. > --- a/tools/include/Makefile > +++ b/tools/include/Makefile > @@ -24,6 +24,7 @@ xen-foreign: > xen-dir: > mkdir -p xen/libelf acpi > find xen/ acpi/ -type l -exec rm '{}' + > + sed -e 's#@includedir@#$(includedir)/xen#g' xen.COPYING.in > xen/COPYING Any particular reason for using -e here? Jan From xen-devel-bounces@lists.xenproject.org Fri Nov 25 09:51:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 09:51:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448138.705033 (Exim 4.92) (envelope-from ) id 1oyVN3-0002V9-0K; Fri, 25 Nov 2022 09:51:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448138.705033; Fri, 25 Nov 2022 09:51:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyVN2-0002V2-Tp; Fri, 25 Nov 2022 09:51:44 +0000 Received: by outflank-mailman (input) for mailman id 448138; Fri, 25 Nov 2022 09:51:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyVN1-0002Uw-TA for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 09:51:43 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20606.outbound.protection.outlook.com [2a01:111:f400:fe16::606]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bda65b77-6ca6-11ed-8fd2-01056ac49cbb; Fri, 25 Nov 2022 10:51:32 +0100 (CET) Received: from DB7PR05CA0009.eurprd05.prod.outlook.com (2603:10a6:10:36::22) by PAVPR08MB9063.eurprd08.prod.outlook.com (2603:10a6:102:325::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Fri, 25 Nov 2022 09:51:36 +0000 Received: from DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:36:cafe::b1) by DB7PR05CA0009.outlook.office365.com (2603:10a6:10:36::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20 via Frontend Transport; Fri, 25 Nov 2022 09:51:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT004.mail.protection.outlook.com (100.127.142.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19 via Frontend Transport; Fri, 25 Nov 2022 09:51:35 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Fri, 25 Nov 2022 09:51:35 +0000 Received: from c54c13d571fc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4189312C-DE39-4DBA-A91D-51A838712D66.1; Fri, 25 Nov 2022 09:51:25 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c54c13d571fc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 25 Nov 2022 09:51:25 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DU0PR08MB8322.eurprd08.prod.outlook.com (2603:10a6:10:40d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Fri, 25 Nov 2022 09:51:21 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.5857.019; Fri, 25 Nov 2022 09:51:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bda65b77-6ca6-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0gWSvdJ+Y2FaDbPjXGlUOygDlEab3wuQ1RDDPbO0OgE=; b=7MN4b2/lRA1jrYHox+ww7S60ftklgwsBURNXdK2wBPHSl+IjAP4MkVKk3QzykqUSqaevTz3Ze+X2oxQ3qZ2ROlqyO/MeNxVzwYbSdQouypepn/Rzl13zDHSqRFsKb6trIvZOz/wQYl+64Py5ZIavSgciDrnw8S42JtbhYgxIpnA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 81a2d878a372757f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dJHstpDgJa1MIHgcqzfHmAdEBEM+nBadNWKCBeM0psNA9hNVh/Xj2gq5aH0e3dIHj6WuLsOQeGIaONnmAqrbpQH0iw85aUxcCoyAvTw0jehQhJgB1sNZKr/8lRkHPkN9esh7dBOk6CdrhKXVMWnNbNHJoBiE4ceD2rtO9JI7gpB0FPYTLcJzaDOo2vJnWN2MUfIy7IKZMMIUKRe2C0hx9fT8f5DmS1jvrPsIuiFQaD5UMChuQsCUtGi9/DUbqKe7A2mMEHs3QvxCXQhvtsTKgosBKd5Nxj3LI2oSjTo35FQxxpf/ZDoMONT0g8suPcxvpjKd+SbCoBBE7GW6m4MbRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0gWSvdJ+Y2FaDbPjXGlUOygDlEab3wuQ1RDDPbO0OgE=; b=SrTgjnvqys5ZLVgvylDezjeXP1GXKMEW//rtm4D6iErVCdXDVpLGyGyXmSNKKWKtCovwRfJ8FLX+XUORnQDEWR0EGjTidv8zRKRL9Tcx63I6ux3sLVQLtdyd4iFfO8sdqD201m31zfzp2QFDHCpWBwCw+n2zgzGTgvkzdvHmIYTL6lpprxZBskw/RWLg/Ey1WuIcbuz5JsNqfw/xQkI8cMFVkLWLWoH1htSCvkc85/7fIYAqzzMIQCzpfbkVEBqMsb+ry2Zlfvs1A1GsQDgokVd3tgTVaXDML/CdousgP/BTeeb2qdIY/SdfMt68OyPUdwdVTfiLXDK5v3B7zpM35w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0gWSvdJ+Y2FaDbPjXGlUOygDlEab3wuQ1RDDPbO0OgE=; b=7MN4b2/lRA1jrYHox+ww7S60ftklgwsBURNXdK2wBPHSl+IjAP4MkVKk3QzykqUSqaevTz3Ze+X2oxQ3qZ2ROlqyO/MeNxVzwYbSdQouypepn/Rzl13zDHSqRFsKb6trIvZOz/wQYl+64Py5ZIavSgciDrnw8S42JtbhYgxIpnA= From: Luca Fancellu To: Anthony PERARD CC: Xen-devel , Henry Wang , Wei Liu Subject: Re: [XEN PATCH maybe for-4.17] tools/include: Fix clean and rework COPYING for installed Xen public header Thread-Topic: [XEN PATCH maybe for-4.17] tools/include: Fix clean and rework COPYING for installed Xen public header Thread-Index: AQHZACPtPzSDrvGd206XhRT1bHCUjq5PZqgA Date: Fri, 25 Nov 2022 09:51:21 +0000 Message-ID: <08F48822-0178-41E0-AF12-6F30187FEC6E@arm.com> References: <20221124164254.33476-1-anthony.perard@citrix.com> In-Reply-To: <20221124164254.33476-1-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DU0PR08MB8322:EE_|DBAEUR03FT004:EE_|PAVPR08MB9063:EE_ X-MS-Office365-Filtering-Correlation-Id: 3cdb6e26-1df3-45c6-a57a-08dacecaa3e8 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bzNJtMXSlbG/7HFvXfEPmCV2Fs8e7Sb50Hvm9zR62DHKBXJ/KGjn9jqVAiUGA4C8sdBGGPlAGT+MYEEpTSoGxkvO75u8XyHFU2fh2Qm7PMcsftzXX749dz/FMHdmVECnCAfSwXsmwkQx+x8rHPWfv3TWYLMFMDsu9Rolq1e70VOVkq6vV3Rq8TePEHV8a/V7d8/vLFBuyFXU9xjTT4vZeonUCd0ZdqnIQeNzWZU4bmFnW6v4Kg/RxkoDbZoZreh2GeWfZBiQ6gLykID36Dlq4i6hWVUilUmyoQ7bBrpUM1eMDPd5idZDyyftanFHlRZctrJnRtq7aGjZqpAcmfyGcPwV5MpvNrmM+yx+EFQ0tFHMqtF5V8tzXSghtkugN0hF3lCEv5sf+Hx4PWjUZppQmI35unDnGa4JDzyIjSadW29y+ubR7Ik4Bq8xqk7lIvT9OVsLXIfXN4xiluMngREqLlIx8GP7z2TT9ZMog2Tjlh+1cAkfixTvzhEbB1r+7zcTkSw0C14m65iB/RMLk4SoDAyOC3ImSTJCQkMceiahH8MbKdAAcvloB2LnW1t+DtYs0BkJD6gP53ME1e6YBEAG3Ascqnq2eVhTmhvcAuhwnKMZl14DfvmT5SvXvA2SDKYDFI61pCJCf6ier2FjMBNH9BwdTw2zpRLNeuY66KTSjsg6cMNN8Hi9+ru9Z3WBHXfZNRPvLUSqdFvY7Y6FCux8SuW4id3KVQvAfV0ANExnhNg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(396003)(136003)(366004)(451199015)(2616005)(186003)(66446008)(53546011)(36756003)(5660300002)(41300700001)(6506007)(6512007)(26005)(38070700005)(6916009)(33656002)(54906003)(316002)(86362001)(478600001)(66476007)(6486002)(71200400001)(8676002)(66556008)(64756008)(4326008)(66946007)(91956017)(76116006)(38100700002)(8936002)(122000001)(2906002)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8322 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4e14b6ad-1069-4baf-77e4-08daceca9b75 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kHUnXvhYF8Wb7gHKHdMFZX5Ww+S5SQkJC+3ZuMpprv+aMiyHtjn+yOlBhqYf8B0yFF5W3Q5yn78MLinA6Ua9IiJDQ8xK6UYIzNriOl+7rvAuz3NMyYH2yfvBDMQZHe7uze2f6fr6XVCvUPnB09toKDUB7qeIcRieMfIVqWGWWdyrtceU/wpEyT03vaXNJzyL7Ioucxif7X9PPeRQfptgDNzkQl9d3TttMDAqFmq2zjibcpd05yhB4SuiS/BEFa79VtX2VIJTwLLZFfqzuyHm8pTqibBKyBu4GOvSEAfrLDJIxJF+Xsf7pKz8vjezs8uZsO2t1J+Vgq1YbqAiXX3JwhlBEOgvXFZFv4oO85LKqreotwtiNSa8oscsBFO1Gf2deGR6sCmt3JpFvNzowRsP5Un0LF+Djc7NRH0p5k+9BMuZM90r4Zpj6XBvIxwKtQ2CSLX6KQqZ8pHqRYN+d1hQKF/nKICU8rJq51FcZjaEX8iiawgkmZfEjKyAem7EH0q9ZCYzc3xEEF12Gfujs25MvPN2pX/sOQrGlYaTCgfJZUlgj/UDDHpLSh6SQcB+22ZkS64ztqEUSYpoCwRtq1X7aTI58aNSrDGI2RYEElTu2UmhQiBFrWPUJQI0KBIjPz43P0E+WD+BniN/Flyc/i2Gk7SlqMvpFY2Vz5Hn7pTkeCOSAHT5vxennBckJr3A9YBYyVT6iQjpu5kdvtDrAPKhVw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199015)(46966006)(40470700004)(36840700001)(70586007)(70206006)(6512007)(8676002)(82740400003)(186003)(26005)(36756003)(4326008)(53546011)(478600001)(83380400001)(41300700001)(336012)(316002)(5660300002)(33656002)(86362001)(6506007)(2616005)(40480700001)(54906003)(2906002)(40460700003)(6862004)(81166007)(356005)(8936002)(47076005)(82310400005)(6486002)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 09:51:35.4995 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3cdb6e26-1df3-45c6-a57a-08dacecaa3e8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9063 DQoNCj4gT24gMjQgTm92IDIwMjIsIGF0IDE2OjQyLCBBbnRob255IFBFUkFSRCA8YW50aG9ueS5w ZXJhcmRAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBVc2UgYWN0dWFsIGluY2x1ZGUgZGlyZWN0 b3J5IHVzZWQgdG8gaW5zdGFsbCB0aGUgcHVibGljIGhlYWRlciBpbg0KPiBDT1BZSU5HIGZpbGUu DQo+IA0KPiBBbHNvLCBtb3ZlIHRoZSBpbnB1dCBmaWxlIG91dCBvZiAidG9vbHMvaW5jbHVkZS94 ZW4vIiBiZWNhdXNlIHRoYXQNCj4gZGlyZWN0b3J5IGlzIHJlbW92ZWQgb24gYG1ha2UgY2xlYW5g Lg0KPiANCj4gV2UgY2FuJ3QgdXNlZCAuL2NvbmZpZ3VyZSBiZWNhdXNlICRpbmNsdWRlZGlyIGNv bnRhaW4gYW5vdGhlcg0KPiB2YXJpYWJsZSwgc28gdGhlIGNoYW5nZSBpcyBkb25lIGluIE1ha2Vm aWxlLg0KPiANCj4gRml4ZXM6IDRlYTc1ZTlhOTA1OCAoIlJld29yayBDT1BZSU5HIGluc3RhbGxl ZCBpbiAvdXNyL2luY2x1ZGUveGVuLywgZHVlIHRvIHNldmVyYWwgbGljZW5jZXMiKQ0KPiBTaWdu ZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4NCj4g UmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gLS0tDQo+IA0K PiBOb3RlczoNCj4gICAgRm9yIDQuMTcgaW5jbHVzaW9uOg0KPiANCj4gICAgRG9pbmcgYG1ha2Ug Y2xlYW4gJiYgbWFrZWAgaW4gdGhlIHJvb3QgZGlyIGlzIGdvaW5nIHRvIGZhaWwgYXMgbWFrZQ0K PiAgICBpc24ndCBnb2luZyB0byBmaW5kIHRoZSBDT1BZSU5HIGZpbGUgd2hpbGUgdHJ5aW5nIHRv IGluc3RhbGwgdGhlDQo+ICAgIGluY2x1ZGVzLg0KPiANCj4gICAgSWYgdGhhdCBwYXRjaCBpcyB0 b28gbXVjaCwgd2UgY291bGQgcmVwbGFjZSB0aGUgYHNlZGAgYnkgYGNwYCBhbmQganVzdA0KPiAg ICBtb3ZlIENPUFlJTkcgaW5zdGVhZCBvZiBjaGFuZ2luZyBpdC4NCj4gDQo+IHRvb2xzL2luY2x1 ZGUvTWFrZWZpbGUgICAgICAgICAgICAgICAgICAgICAgICB8IDEgKw0KPiB0b29scy9pbmNsdWRl L3t4ZW4vQ09QWUlORyA9PiB4ZW4uQ09QWUlORy5pbn0gfCAyICstDQo+IHRvb2xzL2luY2x1ZGUv LmdpdGlnbm9yZSAgICAgICAgICAgICAgICAgICAgICB8IDEgKw0KPiB0b29scy9pbmNsdWRlL3hl bi8uZ2l0aWdub3JlICAgICAgICAgICAgICAgICAgfCAyIC0tDQo+IDQgZmlsZXMgY2hhbmdlZCwg MyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQ0KPiByZW5hbWUgdG9vbHMvaW5jbHVkZS97 eGVuL0NPUFlJTkcgPT4geGVuLkNPUFlJTkcuaW59ICg5MyUpDQo+IGNyZWF0ZSBtb2RlIDEwMDY0 NCB0b29scy9pbmNsdWRlLy5naXRpZ25vcmUNCj4gZGVsZXRlIG1vZGUgMTAwNjQ0IHRvb2xzL2lu Y2x1ZGUveGVuLy5naXRpZ25vcmUNCj4gDQo+IGRpZmYgLS1naXQgYS90b29scy9pbmNsdWRlL01h a2VmaWxlIGIvdG9vbHMvaW5jbHVkZS9NYWtlZmlsZQ0KPiBpbmRleCBmODM4MTcxZThjLi5kNjlh ZWI1NGJmIDEwMDY0NA0KPiAtLS0gYS90b29scy9pbmNsdWRlL01ha2VmaWxlDQo+ICsrKyBiL3Rv b2xzL2luY2x1ZGUvTWFrZWZpbGUNCj4gQEAgLTI0LDYgKzI0LDcgQEAgeGVuLWZvcmVpZ246DQo+ IHhlbi1kaXI6DQo+IAlta2RpciAtcCB4ZW4vbGliZWxmIGFjcGkNCj4gCWZpbmQgeGVuLyBhY3Bp LyAtdHlwZSBsIC1leGVjIHJtICd7fScgKw0KPiArCXNlZCAtZSAncyNAaW5jbHVkZWRpckAjJChp bmNsdWRlZGlyKS94ZW4jZycgeGVuLkNPUFlJTkcuaW4gPiB4ZW4vQ09QWUlORw0KDQpJZiBJIHVu ZGVyc3RhbmQgY29ycmVjdGx5LCB0aGUgLWUgY2FuIGJlIGRyb3BwZWQgYXMgdGhpcyBpcyB0aGUg b25seSBjb21tYW5kIHdlIGFyZSBpc3N1aW5nIHRvIHNlZC4NCg0KVGhlIHBhdGNoIGxvb2tzIGdv b2QsIEnigJl2ZSB0ZXN0ZWQgaXQgd2l0aCBhbmQgd2l0aG91dCB0aGUgLWUgYW5kIGl0IHdvcmtz DQoNCkNoZWVycywNCkx1Y2ENCg0KDQo= From xen-devel-bounces@lists.xenproject.org Fri Nov 25 10:01:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 10:01:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448142.705043 (Exim 4.92) (envelope-from ) id 1oyVWS-0004Uv-UQ; Fri, 25 Nov 2022 10:01:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448142.705043; Fri, 25 Nov 2022 10:01:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyVWS-0004Uo-RX; Fri, 25 Nov 2022 10:01:28 +0000 Received: by outflank-mailman (input) for mailman id 448142; Fri, 25 Nov 2022 10:01:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyVWR-0004Ue-SQ; Fri, 25 Nov 2022 10:01:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyVWR-0006fe-Oo; Fri, 25 Nov 2022 10:01:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyVWR-00082p-C7; Fri, 25 Nov 2022 10:01:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oyVWR-00039H-Bi; Fri, 25 Nov 2022 10:01:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qhAAfIcjRnk79djYUS5EijPGb5giD0qjj7AunrJpJ3g=; b=Omj1aAFfFV5DnygD8tjzSzeV8a 54dcmKstOuHtHuSKU/ofEINZjBZbAEPcD1ARLUcT5DsxQotBUpFAJCsq70ROHYZJbFri8HYunqj1G 7Nx0hxwwg5gDHDtEd/hriUHntete9uzJobm251MOar6N6TryMVXKIS6msJIBmQP/5M0c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174960: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=d8cc655d3b0f1c2786b2bc374df12d9454c4b9f5 X-Osstest-Versions-That: libvirt=1a9ff7846d4f9f80dc86e0486503f86036cb3780 From: osstest service owner Date: Fri, 25 Nov 2022 10:01:27 +0000 flight 174960 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174960/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174952 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174952 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174952 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt d8cc655d3b0f1c2786b2bc374df12d9454c4b9f5 baseline version: libvirt 1a9ff7846d4f9f80dc86e0486503f86036cb3780 Last test of basis 174952 2022-11-24 04:18:52 Z 1 days Testing same since 174960 2022-11-25 04:18:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiri Denemark Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 1a9ff7846d..d8cc655d3b d8cc655d3b0f1c2786b2bc374df12d9454c4b9f5 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Nov 25 10:58:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 10:58:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448151.705055 (Exim 4.92) (envelope-from ) id 1oyWP6-0002Z5-5f; Fri, 25 Nov 2022 10:57:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448151.705055; Fri, 25 Nov 2022 10:57:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyWP6-0002Yy-2c; Fri, 25 Nov 2022 10:57:56 +0000 Received: by outflank-mailman (input) for mailman id 448151; Fri, 25 Nov 2022 10:57:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyWP4-0002Ys-E2 for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 10:57:54 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 00ba1499-6cb0-11ed-91b6-6bf2151ebd3b; Fri, 25 Nov 2022 11:57:52 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00ba1499-6cb0-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669373872; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Tm7rW6PWgwOdjKrjqgISOYUHk5pJ+R4i341Ww3r9px0=; b=GHHOwpPzEH+urVT1uj9YZX7n67+2Ka3+P8TJmA8u4WnDJuFfmfJQi1iO foIKUNCN0ZV+UiNRSwV/sy8nkUnX3zK7yTDjmHdZiK1Izo+/ChE4HvjK6 /X0MG8cCarisWvCx9vXE0FrtgvS/H+PuKsnyKradlC6RD7ZT495Jnpox0 w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 85559696 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:TePx36NPn9WIIGfvrR2ul8FynXyQoLVcMsEvi/4bfWQNrUon12YCz jYYWGuBOP6KYWShe9p0bYq2/UNS6sSAmIBhHQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5AFmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0somW0Jpy NoKEjMAUC7dgsjt7YvgbuY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w/N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9KoHXGJQLzxjwS mTu5TjcJUsjaMKkxyuVylan1uzehwjZR9dHfFG/3qEz2wDCroAJMzUJUXOrrP//jVSxM/pPJ kpR9icwoKwa8E2wUsK7TxC+uGSDvBMXR5xXCeJSwAOHx7fQ4g2ZLnMZVTMHY9sj3OcWSDowx xm2ltXmLTV1tfueTnf1y1uPhWrsY25PdzZEPHJaC1teizX+nG0tpj6eFPVELYintN74Jw+ux hrRgRFlo7pG2KbnyJ6H1VzAhjutoL3AQQg0+hjbUwqZ0+9pWGK2T9f2sAaGtJ6sOK7cFwDc5 yZcx6By+chUVfmweDqxrPLh9V1Dz9KMK3XijFFmBPHNHBz9qif4Lei8DNyTTXqF0/romxezO Cc/WisLvve/2UdGiocpC79d8+xwkcDd+S3ND5g5rrNmO/CdjjOv8iB0flK31GvwikUqmqxXE c7FL5f3VCpKVPU6lWDeqwIhPVgDn3BW+I8ubcqjk0TPPUS2OhZ5tovpwHPRN7tkvctoUS3e8 spFNtvi9vmseLSWX8QWmKZNRW03wY8TXMmq9ZIJK7XZf2KL2ggJUpfs/F/oQKQ994w9qwsC1 ijVtpNwoLYnuUD6FA== IronPort-HdrOrdr: A9a23:rQ6/q6Oisk3I4sBcTsGjsMiBIKoaSvp037Eqv3oedfVwSL39qy nOpoV/6faaslsssR0b9exofZPwJk80lqQFg7X5X43DYOCOggLBR+tfBMnZsl7d8kXFh4hgPM xbEpSWZueeMWRH X-IronPort-AV: E=Sophos;i="5.96,193,1665460800"; d="scan'208";a="85559696" Date: Fri, 25 Nov 2022 10:57:41 +0000 From: Anthony PERARD To: Jan Beulich CC: Henry Wang , Wei Liu , Subject: Re: [XEN PATCH maybe for-4.17] tools/include: Fix clean and rework COPYING for installed Xen public header Message-ID: References: <20221124164254.33476-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Fri, Nov 25, 2022 at 10:28:52AM +0100, Jan Beulich wrote: > On 24.11.2022 17:42, Anthony PERARD wrote: > > Use actual include directory used to install the public header in > > COPYING file. > > > > Also, move the input file out of "tools/include/xen/" because that > > directory is removed on `make clean`. > > > > We can't used ./configure because $includedir contain another > > variable, so the change is done in Makefile. > > > > Fixes: 4ea75e9a9058 ("Rework COPYING installed in /usr/include/xen/, due to several licences") > > Signed-off-by: Anthony PERARD > > Reviewed-by: Jan Beulich > (with a question, perhaps just for my own education, at the end) > > + sed -e 's#@includedir@#$(includedir)/xen#g' xen.COPYING.in > xen/COPYING > > Any particular reason for using -e here? No, I just often use it, even when unnecessary. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Nov 25 11:32:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 11:32:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448163.705066 (Exim 4.92) (envelope-from ) id 1oyWwA-0007ZR-Py; Fri, 25 Nov 2022 11:32:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448163.705066; Fri, 25 Nov 2022 11:32:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyWwA-0007ZK-MQ; Fri, 25 Nov 2022 11:32:06 +0000 Received: by outflank-mailman (input) for mailman id 448163; Fri, 25 Nov 2022 11:32:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyWw9-0007Yv-AE for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 11:32:05 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 80ea5c54-6cb4-11ed-8fd2-01056ac49cbb; Fri, 25 Nov 2022 12:30:04 +0100 (CET) Received: from mail-dm6nam12lp2176.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 Nov 2022 06:30:01 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by SJ0PR03MB5760.namprd03.prod.outlook.com (2603:10b6:a03:2d3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Fri, 25 Nov 2022 11:30:00 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%7]) with mapi id 15.20.5834.015; Fri, 25 Nov 2022 11:30:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80ea5c54-6cb4-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669375804; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=HjkCHBARGKytnEpsHY++QWGcGiGlNvtvKsy8tYsXbxE=; b=CHjueQqLCmBUgxw5P2biRL6TWX5c/jg1rm9GAgBDBiPeL1Y3+RxWPdpM N4obBrq9oGqX7Imsxnr5oAT4AI4XqIOpX3P28+86+oecoS0XOVKdLVRJF +uWcJNQ9IroP/+sqyRR/VSI7j2wngNXSnszkr4yVTMhOYzr3d95Zpb/qa 0=; X-IronPort-RemoteIP: 104.47.59.176 X-IronPort-MID: 85968259 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ccm5iaLoApQTFxzJFE+R4JQlxSXFcZb7ZxGr2PjKsXjdYENShjRVy 2NMXzyDPP6JNGWgfIh2PIrgp0oDsMKHnN82HFBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wZjPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5ZOXtiy fgEBQsTc06GnbiR2uKgFOpz05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMkmSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iLx17Gfx36qMG4UPIbjp6VvoAXC/3QCNDgfT3j4nOOcg0HrDrqzL GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O+oh8x2A0baR6gqcB24sXjNHcMYhtsI9WXotz FDht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHeTJobixvOSpNvFfCzh9isQzXom WnV8m45mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5 hDoR+D2ADgyMKyw IronPort-HdrOrdr: A9a23:WejjhKFqDS1pk3h6pLqE7seALOsnbusQ8zAXPidKOHhom62j5q WTdZsgpHzJYUkqME3I9ervBED4exnhHMdOjLX5Xo3MYOC8ggCVxehZhLcKpQeBJ8SUzJ8+6U 4PSclDIey1N2FZreuS2mWFL+o= X-IronPort-AV: E=Sophos;i="5.96,193,1665460800"; d="scan'208";a="85968259" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aWxuwX9fjuOFKbZV4xJ26UL1kg/lSRufN1J/9i9KQlkYpt0LuMSnWbFjSTAU6wOvemkLGyZBxoqwWKp3TTu+KIU8VjH2r1yeLLuW9LRMK49C6mGEshkUrNrLBtC0XdHHNNrQL827CH+QQdt/vAfDKHXR7Q0m09ByMpTOozWJGUUmazusxcw94QP0ky6RDvim4kqetgTwV0j/gc0s3j9+8XzUT3u08al0H9cGCuYjhrMSFfRtY5iWHuo3aIxSnKL+3MlzjDCHHpjIlb1wfuDT8Zfrj62RxtdU5SxyGF/1ofmevdYJjCezNJsOAtIcY7BFBSmEXOPpu2lIIxKBV5saag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N4EP1m6RqVfWDbdKKEMHXb2QJMYUuwVx9jUvhsHH95o=; b=X4RcUI/PIxZ2jsqusxbQ7WJB+i0QQ2H3Ulf7FepFqu4VfFVXACzxL0HDiJBBPCDt5Nie5wk2cZcWfpQp6l5JbAKaOjxKQZjzukPYvNxgYLv6wRzv1tsdqpXWZNDUxoV1ohZD2BN+ST+UjpPxAPr0TvmoR80ijMTa7upNGoSwOsR5vS+oWE+0pJLXcEUy00FXjV2a3vK/0mHPhJ89rMTYjyWmLyu8n0uXiPt+N9POrsToJ8qLYPHHF0bR82YMzm7/Vo8HoDgTC5vFQWIPBi2XdMzk33Zo97zPMXx+yQc/3efoZhBkAi2mfP3e373Nfbv1oVmeeyPrBUHb0cKbvSuiTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N4EP1m6RqVfWDbdKKEMHXb2QJMYUuwVx9jUvhsHH95o=; b=Wgq/26G7N+BtkxBTSox4fT27w4FhrfqYTze5pkvThSLeg2asoi4wg307wZxOo+UG0BZhgYzAhRhWHWBZlhzgcYqdmdpzymHPKNubSKgipSz+YT+VPGn/EIXovMYoofZ1KlzJl9g0j0SxNtDX0rF6ko6Y/uUX6jRgpqVsKUllRpc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 25 Nov 2022 12:29:55 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: osstest service owner , xen-devel@lists.xenproject.org Subject: Re: [xen-unstable test] 174958: regressions - trouble: broken/fail/pass Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0072.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::23) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5760:EE_ X-MS-Office365-Filtering-Correlation-Id: c85ee860-df52-4707-cc53-08daced86347 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GQiFNwP8jUoVBSO1SDCbkvDh/GkLL09g2ReBVb2TEbDO7clS9LV7fvGOULYoJGBU3v2w8GA2Wi/UJmYHjpV0t67P5WGmSAuMeO83JKcWYQDXsbejc9R+pJLNlD4oHWtjy2H86HPeV5ctyPrguxZMUl0MHze5aii0iEMA9/6gLJX6sE8eM7N6r3UG/a3MV44OfFpND7nnjos/us7AjpHuo/K0G4dbbms9yDeIyjgvvfYr9OQDFo6wf/el2qPeK/2qxUtWO8Fl+cZxyTsQuwxNMU2uL52L/kOob3CRuudlGFQs4DLWQTaJFgf5+y8EltnfsPbXYYUr4qU7aYQnc/XJyl9qd8MgWIiDuWFAs7Hq8gJRFCvXbxjNXra9KeZwR0wXT4xjERxQAXPRmQTOFH/t5MGPjyXaQbYtS3mpdiub2oHVlnQgXcmBgNnxiP4H8jhH96BviMfqu5WURlLtW9T4S7wh92UwkmzyMaclcA4aK71TQFBFjSbCqszB/qfaFD+3yBv1oB35A9LAoPXeUstWFyhPBGMbj7HMWPeGnLOWaNBWMzARAZ9nqxNF2oXVqInxPsmCTtXnU5VKd0H8fo0+6G8BVeu6K4E3SpL9r8v6Rqnjzc1tG1U4Sl/UBm7LRc65ZP7qMDInxpPTXyfj+tOfTh0Y6yvtPPQnZgTz+2O4o8ICYzCuTvtENqNgQeR4HMc8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(346002)(39860400002)(366004)(136003)(396003)(376002)(451199015)(316002)(82960400001)(8936002)(4744005)(5660300002)(2906002)(38100700002)(41300700001)(86362001)(66556008)(8676002)(4326008)(478600001)(66476007)(6916009)(66946007)(186003)(33716001)(83380400001)(966005)(6486002)(85182001)(53546011)(26005)(6666004)(6512007)(6506007)(9686003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGNHeERESnpZd3R3K01nb2pFMU5HTDhRamRyMGtGUWZKSW4rL2pEdGtpcDQz?= =?utf-8?B?b0Y4eHF2eUJhTjUrZDNyMTZDU3RyQjVDWTNOcjBFQ2g1aVBXNDBabERQdXZp?= =?utf-8?B?N1U4YVc5ZGlYeVpTV0lRUUNDVlpVVFZ3cUZtem5PaVJTZzRsdU9mNXUvd3gv?= =?utf-8?B?Z0lZRWVyMHNYeGdnUVVaZUoxTlNmSERKWWcvZllhN1BySkl5bHhLbVpPMGNy?= =?utf-8?B?YzYrTkZOVG50UEdjSGV6L0ZjaVpOUXN2L2hqNzgrdUYwQytseWw2ZSs5elcz?= =?utf-8?B?eHJtU1Q1MmN5WFAxMnhDYW5UM25KbitGa042bjNIZWtDYUJjaEJaQis0QmZ1?= =?utf-8?B?WTlXbTVVR1JYc2drWnJjOUNHd081ZE02R2lIZnZ3cjhjeC9MSmJ5ZHl4ZVRm?= =?utf-8?B?ZGpHZHZDS3NaMGdZcXA0Sy9RSWxiL2FPcHkxU2w5ZnZMZmN3MDhaY2ozdXg5?= =?utf-8?B?b2NrUUxpQ2ZhaDM0ZUIrWGpNYkFqWkwyUWlBZGhrTWxOaDU1Q01HY2NVZVl1?= =?utf-8?B?RmZCLzM2TFRyUjg4NGRab1FrbmwxRU4ySFkxbW9wMVFOZnIvWnJjUkc3WDM5?= =?utf-8?B?c0YraW1uY0ZLaHBydTNORzE2a0dlVTRaZ1g0LzY3Sm5zUHJmRXIrRWFOMXJ5?= =?utf-8?B?d2t2blJERml0SkwxL0ZDQlNEV2VTclNGM1dEU29FNC9MK3J0NWZMWlUvb3pX?= =?utf-8?B?YThYd0lyK2hrOE9MOWwxODR3TFFHUDM5TEkrRkJMQ1ptc2dKc21yU0xjc0tp?= =?utf-8?B?MVlhS2xISUd3YWI0TEV6TFRvZWl4aFIyWm1VVWdzaVVhVFBkT3padjZEZ3BJ?= =?utf-8?B?cHo0QlgvWTh1TE5DSWhBTmFKa2RKZkRIWVdYdlp0UWZ2VzJyKytPeUNZTjg1?= =?utf-8?B?ZzZ0aUVBSEdmaTNhSmxkSUpPd0VVRWJ0TVpMRVBCNEJrZFRVd2lTbnNMYjkz?= =?utf-8?B?M29qZkJVWENSaUtZUUh0RGpoSTZ0ZXdmc282Q24xZGIxaWdQWElLYldETzU2?= =?utf-8?B?Mlk2YTBuTyt3cFdwQ3h1RE5RNTRpd2NlbCtBdzc3VlhHV3dDWnRNaDZYZ2NP?= =?utf-8?B?KzdhalJzekQwSVJTNnl6R1NGTk9BTVNuSEorR0JNRDZHT3JhQy9VNHFwSzRq?= =?utf-8?B?UVRlUUlxcW81djRDTjNmTE9PWTQ1MFpMcGZhRGtoQ0w5aXcxdW1MbUc2Y2lG?= =?utf-8?B?QWgycXgwQnRiWUtEMGRjK3RuZkhmelRIUHZWOFdadDlxN3o0djhXUVQ5OEJw?= =?utf-8?B?ejBZR29FM3AyM3lla3JDVGF3czhISmpJb25SUEtKV1RONk85b0xxeHphR2hj?= =?utf-8?B?c0VmQkxHWHh1YmlaOEk1SEUrNkozeW4yQVd2SDFWTXpSb2czbVRYR2oxdGx3?= =?utf-8?B?aFp5cXdXWHNJODJxTlp4VWtteXdRNzA5bU5vdnBISTloTE4rRS9qeHR5bE1V?= =?utf-8?B?QkRWVExLc2Vham50K0dFL2taUW9kZUZacEpic2IyT2tMUkVUZnlLbXJvUzFW?= =?utf-8?B?QytnNXpOeGU4TzZ3OGthcWhEZWN4UXJ0ajV4SjlHYTMxU0FGZExKQVFKbEd4?= =?utf-8?B?RFJ0MFBkSnJOSmwxMFdoTHEyUW55aDVMdE9vME5Dd0k1MlJlaTEzcVE1Rzd5?= =?utf-8?B?TmNDckxlQzZvRWRDd09TTE5Sc056Vk12b2JzR1ZCU1lzSytld1AzblRKZVlu?= =?utf-8?B?Qlo3SG01dDNuZGZmS2hKVitXK0NCcldRQzBLK1RVbVhQWEkrd3pERXRKbTNH?= =?utf-8?B?YWZYK0QvYmxHNy84eXRMZDVPUSsrUHZ5bi9hSSt5Rk45RTNxaVB4a1locU9Y?= =?utf-8?B?ZCs2OElGQ0tNNy9FcXJUdWgyZzFVUm9DSzVlZDdaZjlnUFA3aEk5bjJHeFEz?= =?utf-8?B?cW9mU0J0NGZqVWoxenQxMU8xaUQ4b1phTzNPTmxUYUVVdEsyWDlQeWE4bW41?= =?utf-8?B?djlia1B0VUhmZmlRSDN2YThXQ1dPb2E4M3dGZ2twbm9vVDhpU3pyRjhoVHRq?= =?utf-8?B?YkJzeGhWS3cvSEtSSWJoNFdqd2o4a3poRWtHQjBvTGJsajFZZi9vWUNHVkQz?= =?utf-8?B?VVNMdk9PRWpvdmdjWDFSdXZKMDB2dVFNN1RxcDBvV3UwL2NEMTVZcmhPOExX?= =?utf-8?Q?3J4WzrF/ePbKfzkGHrkSHAw/N?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6tdp+EHR1NEQbksEtJC0JmG/svHT30xXg/BgHK4l4OzdH9FZqFZmEYudyQWGhI4rh508ewgt0QtmRps7pyAwn8Inar+hnjI01BvbGrtCF/bq+ZQGtc6a6SBRwpRaUWJPPM7T0d1OZ3ZhKhfBZvmnHscA8ZMugXckncEAqvqoqHtX84phK9PDkh3vs13NG9Yjeu4mA3vWzmCVvDjJdHVD88ZbS/cOIJQ583mAk/NI3lS/3TnfLh0Szs/EcLQ82mUggZe67Ed2O6P70XTMng8mLMCXdSYheWscRaOk3KGRa7t+pcukvgNQNv3hvWcx+0p7X3cFGM5OZXCYrmfpbxOyPqa2HoarUMfdwo7A761bNz8EzPWPuKM+yQQ0KWDtSderV2brXz8KmcMcLRsPq3xn7JWyTGml9l1Vy9jV8/OXLLYr0KfzoOweoKu3L37Ex+f/dId7fDknptZQRGaivbY0kiJ9cTPiwM1HAKGSzDnFk/cmWCQzPhv9uIeQx3ENhQScz/33LBxe8JQwHmGpHvJ8unPlDp+eFeT3Y5JLq6E/c7LlIgLeNtvhXPRi8qJjvkXDjoYJxjoC5G8w+kFxqgwrm98jAU9TeNSnokMaLQnenj+PeAua412MjoEIp+dYekwmVsM2fkQWWoWw9R3cJthVc+lrTf37dx2IDsH/E92Q84QdufWcKjf4RxtKLcB/jP3yUUspnIehmTIWfK++feMTE8wRHwMFaJW2FMGoiWGoCEBgLPzaSjzW6tjjWcGVlsR6IDQJBOSpFVVTyLMIgNT4yjb0nlGOJ3JE3t+jgCjRCMY2Usi0Ca2efW/YM+8/M1f6/7zagxDCPHbe5a/cXsHQM5cxYuzrGPA6cBQi5y3dmCA= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c85ee860-df52-4707-cc53-08daced86347 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 11:30:00.1972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AryeIinvksTvN1rVN7gHb16wWt4WxhgPXHTXAo7eUK0L90WijLKmhOg+eVHcgaN+wIClUK9xI7yVnkpRM22IZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5760 On Fri, Nov 25, 2022 at 10:21:38AM +0100, Jan Beulich wrote: > On 25.11.2022 09:10, osstest service owner wrote: > > flight 174958 xen-unstable real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/174958/ > > > > Regressions :-( > > > > Tests which did not succeed and are blocking, > > including tests which could not be run: > > test-amd64-amd64-migrupgrade broken > > build-arm64-pvops 6 kernel-build fail in 174950 REGR. vs. 174958 > > Just out of curiosity: How can an older flight be a regression vs a > newer one? I think Ian made regressions sticky (up to a degree) in order for us to not ignore heisenbugs. In this case this was compiler segfault while running on native, so nothing related to Xen AFAICT. Roger. From xen-devel-bounces@lists.xenproject.org Fri Nov 25 13:52:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 13:52:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448179.705076 (Exim 4.92) (envelope-from ) id 1oyZ7Q-0007SZ-OE; Fri, 25 Nov 2022 13:51:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448179.705076; Fri, 25 Nov 2022 13:51:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyZ7Q-0007SS-Lf; Fri, 25 Nov 2022 13:51:52 +0000 Received: by outflank-mailman (input) for mailman id 448179; Fri, 25 Nov 2022 13:51:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyZ7P-0007SI-Iv; Fri, 25 Nov 2022 13:51:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyZ7P-0003Dx-Fv; Fri, 25 Nov 2022 13:51:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyZ7O-0004bD-U0; Fri, 25 Nov 2022 13:51:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oyZ7O-0001EY-TT; Fri, 25 Nov 2022 13:51:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lVrO7mzRfqrz3pwofkSoLTqrZuFBcWjifYHiUrZjDHI=; b=0uNmXpbrQtauBL/j6njPHjsXcl +tg9xY0+qHutj6FbJO/i+TdWyi/uCKbRUl34m3+PyenEyRdbVs1Oa3Ezhx2tNmdYdSSjnbItSayCQ 3+GYxFYSzOEu7ec4qpTnzzAH4NrHnyOnc53f6Koa3NBpQJ+RhL36QxZNJcvt6ugVAEbE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174959: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=08ad43d554bacb9769c6a69d5f771f02f5ba411c X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Fri, 25 Nov 2022 13:51:50 +0000 flight 174959 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174959/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10 fail pass in 174957 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux 08ad43d554bacb9769c6a69d5f771f02f5ba411c baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 48 days Failing since 173470 2022-10-08 06:21:34 Z 48 days 89 attempts Testing same since 174957 2022-11-24 20:12:25 Z 0 days 2 attempts ------------------------------------------------------------ 1854 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 175887 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Nov 25 14:16:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 14:16:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448186.705087 (Exim 4.92) (envelope-from ) id 1oyZVE-0002E7-Oh; Fri, 25 Nov 2022 14:16:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448186.705087; Fri, 25 Nov 2022 14:16:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyZVE-0002E0-M9; Fri, 25 Nov 2022 14:16:28 +0000 Received: by outflank-mailman (input) for mailman id 448186; Fri, 25 Nov 2022 14:16:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyZVD-0002Du-5k for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 14:16:27 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bdd11c59-6ccb-11ed-91b6-6bf2151ebd3b; Fri, 25 Nov 2022 15:16:25 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bdd11c59-6ccb-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669385785; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=LZdooToHmw2SHxLUqVij15j9Jm3Upn7vZo/DVkK81SA=; b=HrP3Et47+S1MXIfbjISyVaJNL6J9plS0Wji9kZl5nYX+9uBJTuTwnxQg eSH+3eFuDhn/3UuMkWr7XKpogB/pUmmpYMd1OwCx4E3eqU4Z5Xa4BVYaR pxWD49xW6C2HmRzBikPksD8hsmtlFjLPBjTZwGWBFPt1H0N2rs78HdsX7 U=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 84605283 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:TKwoT6Ou9Q8hzWTvrR2hl8FynXyQoLVcMsEvi/4bfWQNrUol0WQOy WIaDGGCPf6LYjf9etgib4vnoUsP7cLRnYAyGQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5AFmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vd3JWVPs uJGEzZXSEmZjsOZ4OqjFPY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w/N3wsYDUWUrsTIKozhqGCh33kfhVTqU6PpLpx6G/WpOB0+OixboKIIIzRLSlTtkmDi W3H3kn5PkklFvjP9GCgriyKr8aayEsXX6pNTeblp5aGmma72Wg7GBAQE1yhrpGRiESzRtZeI Ew84Tc1oO4580nDZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpcNU7sOcmSDps0 UWG9+4FHhQ27ufTEyjEsO7J83XiYkD5MFPuewcVTS8B4p79/ro11DSWVN9CP47tloPqTGSYL y+xkAAygLAajMgu3qq9/Ezajz/EmqUlXjLZ9S2MADv7s1oRiJqNItXxtAOFtaoowJOxFAHpg ZQSpySJAAni57mpnTfFfugCFarBCx2tYGyF2g4H83XMGl2QF5+fkWJ4umkWyKRBaJxsldrVj Kj752tsCGd7ZifCUEOOS9vZ5gRD5fGI+S7Zfv7VdMFSRZN6aRWK+ipjDWbJgT68yxFwwfxuZ M7BGSpJMZr9If03pAdaus9HieN7rszA7T27qW/HI+SPjuPFOS/9pUYtO1qSdOEphJ5oUy2Mm +uy9qKilX1ibQEJSnSNqN5DcwxaRZX5bLivw/Fqmie4ClIOMAkc5zX5mNvNp6QNc3xpq9r1 IronPort-HdrOrdr: A9a23:+JDjsatDUKt0EiND1FVXMsHK7skDfNV00zEX/kB9WHVpmszxra +TdZMgpHrJYVcqKRYdcL+7WZVoLUmwyXcX2/hyAV7BZmnbUQKTRekIh7cKqweQfxEWndQy6U 4PScRD4aXLfDtHsfo= X-IronPort-AV: E=Sophos;i="5.96,193,1665460800"; d="scan'208";a="84605283" From: Per Bilse To: CC: Per Bilse , Paul Durrant , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] ioreq_broadcast(): accept partial broadcast success Date: Fri, 25 Nov 2022 14:15:57 +0000 Message-ID: <06ad4b3a67a15192fc986b35e3f2fcd35b2f4c2f.1669383767.git.per.bilse@citrix.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain A change to XAPI varstored causes an unnecessary error message to be logged in hypervisor.log whenever an RTC timeoffset update is broadcast. In extreme cases this could flood the log file. This patch modifies ioreq_broadcast() to allow partial success. Signed-off-by: Per Bilse --- xen/arch/x86/hvm/io.c | 2 +- xen/common/ioreq.c | 9 +++++---- xen/include/xen/ioreq.h | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c index 0309d05cfd..c4022bf7c2 100644 --- a/xen/arch/x86/hvm/io.c +++ b/xen/arch/x86/hvm/io.c @@ -60,7 +60,7 @@ void send_timeoffset_req(unsigned long timeoff) if ( timeoff == 0 ) return; - if ( ioreq_broadcast(&p, true) != 0 ) + if ( !ioreq_broadcast(&p, true, true) ) gprintk(XENLOG_ERR, "Unsuccessful timeoffset update\n"); } diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c index 4617aef29b..1d6ca4d1ac 100644 --- a/xen/common/ioreq.c +++ b/xen/common/ioreq.c @@ -54,7 +54,7 @@ void ioreq_signal_mapcache_invalidate(void) .data = ~0UL, /* flush all */ }; - if ( ioreq_broadcast(&p, false) != 0 ) + if ( !ioreq_broadcast(&p, false, false) ) gprintk(XENLOG_ERR, "Unsuccessful map-cache invalidate\n"); } @@ -1309,11 +1309,11 @@ int ioreq_send(struct ioreq_server *s, ioreq_t *proto_p, return IOREQ_STATUS_UNHANDLED; } -unsigned int ioreq_broadcast(ioreq_t *p, bool buffered) +bool ioreq_broadcast(ioreq_t *p, bool buffered, bool partial) { struct domain *d = current->domain; struct ioreq_server *s; - unsigned int id, failed = 0; + unsigned int id, sent = 0, failed = 0; FOR_EACH_IOREQ_SERVER(d, id, s) { @@ -1322,9 +1322,10 @@ unsigned int ioreq_broadcast(ioreq_t *p, bool buffered) if ( ioreq_send(s, p, buffered) == IOREQ_STATUS_UNHANDLED ) failed++; + sent++; } - return failed; + return failed == 0 || (partial && failed < sent); } void ioreq_domain_init(struct domain *d) diff --git a/xen/include/xen/ioreq.h b/xen/include/xen/ioreq.h index a26614d331..65457ca5ba 100644 --- a/xen/include/xen/ioreq.h +++ b/xen/include/xen/ioreq.h @@ -102,7 +102,7 @@ struct ioreq_server *ioreq_server_select(struct domain *d, ioreq_t *p); int ioreq_send(struct ioreq_server *s, ioreq_t *proto_p, bool buffered); -unsigned int ioreq_broadcast(ioreq_t *p, bool buffered); +bool ioreq_broadcast(ioreq_t *p, bool buffered, bool partial); void ioreq_request_mapcache_invalidate(const struct domain *d); void ioreq_signal_mapcache_invalidate(void); -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Fri Nov 25 15:51:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 15:51:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448210.705099 (Exim 4.92) (envelope-from ) id 1oyayN-0005p1-Jf; Fri, 25 Nov 2022 15:50:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448210.705099; Fri, 25 Nov 2022 15:50:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyayN-0005ou-Gv; Fri, 25 Nov 2022 15:50:39 +0000 Received: by outflank-mailman (input) for mailman id 448210; Fri, 25 Nov 2022 15:50:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyayL-0005ol-QA for xen-devel@lists.xenproject.org; Fri, 25 Nov 2022 15:50:38 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20603.outbound.protection.outlook.com [2a01:111:f400:7e1a::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e61319b2-6cd8-11ed-91b6-6bf2151ebd3b; Fri, 25 Nov 2022 16:50:35 +0100 (CET) Received: from DB9PR02CA0024.eurprd02.prod.outlook.com (2603:10a6:10:1d9::29) by AS8PR08MB8490.eurprd08.prod.outlook.com (2603:10a6:20b:567::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.5; Fri, 25 Nov 2022 15:50:30 +0000 Received: from DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::a2) by DB9PR02CA0024.outlook.office365.com (2603:10a6:10:1d9::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19 via Frontend Transport; Fri, 25 Nov 2022 15:50:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT021.mail.protection.outlook.com (100.127.142.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20 via Frontend Transport; Fri, 25 Nov 2022 15:50:30 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Fri, 25 Nov 2022 15:50:30 +0000 Received: from 48b9f45ef1c5.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1A7D2E96-80D3-4136-8F27-DE56F6E818A0.1; Fri, 25 Nov 2022 15:50:18 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 48b9f45ef1c5.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 25 Nov 2022 15:50:18 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by PA4PR08MB7409.eurprd08.prod.outlook.com (2603:10a6:102:2a1::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.5; Fri, 25 Nov 2022 15:50:09 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.5857.019; Fri, 25 Nov 2022 15:50:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e61319b2-6cd8-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8MrgEbLZWE8VLGcUb0mBrzk3xTtNJtTmq9OaRn7gMEY=; b=i0KIpCD5uwmhZpF0yDPBEZMG686PgnWH2Z6dxWLjkC6N4TX6K987f70FRBuI8HOwONmaopDJpB1e1q4K6WLlYQY3GytPu5bwqANf2jybMeY1FR4kZbIkKABpwDl4dDvd32Bk9VXfl1ZGByq4WaiHQrjrQCnzKxRZsuAEuO9A6j8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 122fa8aac16b0ab8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aaMTjXI2rQM7m0eAzpnI1czvE5yjWxTyN0MsM8vS09oAnJxj97c/FoL6l/2RNXwQwYjcTs7ixwXbuKIcLnYn/2Ocx0Nypr6qzS0AJZsm4hkHsWHjvPOwjwicEfYtAP7GGl2qV/YNI+xhYZRpJBqp++qFnok3Jc0mloU1dL28l4XhE+pwQfGXysvPAh9qZKFH7FI/ibDKp6pU4NI1bswRhLEpZ0Ycq17FUH2Fvbj90QlsF/lHmXNFKs31/cmj+2UXM+dPzdKy0YNwd6g3Jm7deBI1vyH6+s9OO5/+/zCg8rukReyFWfH1KYYFgj6oIsjj9VZggy7cJfq+U63KoX2oZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8MrgEbLZWE8VLGcUb0mBrzk3xTtNJtTmq9OaRn7gMEY=; b=KRXy7/v4oRXxAAfBlUQ1AbrkkqQ0iJbsSiJItbK8teaZeVVc/f+oaWdoQIVoW9kXRmdGDJxgZXLLtIvFLgWkykWIEXhAeETHMqPYwwEYnfJo7yqTWiCBe59Psc6Iuv5e9V9cc8XFICrnh7dr0OAClWVJCL4YD6sFyAII6wGnPRlPlX4VAq7knTWsT104AK9mWLCQRJNdZ5whLpW2CSDyEPXh+8CohlYOVttfoIi54MIj2zSokY1hIVjU7qUSx7ZnS3LuzEotUZm9zNZMZTqFguBRn5leb3hv2oWFz+G7UyZuAKgXzS8PEvxvZ4xYyDPiiwgEidWP41JBLZEeNjcsBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8MrgEbLZWE8VLGcUb0mBrzk3xTtNJtTmq9OaRn7gMEY=; b=i0KIpCD5uwmhZpF0yDPBEZMG686PgnWH2Z6dxWLjkC6N4TX6K987f70FRBuI8HOwONmaopDJpB1e1q4K6WLlYQY3GytPu5bwqANf2jybMeY1FR4kZbIkKABpwDl4dDvd32Bk9VXfl1ZGByq4WaiHQrjrQCnzKxRZsuAEuO9A6j8= From: Luca Fancellu To: Julien Grall CC: Xen-devel , "marco.solieri@minervasys.tech" , "lucmiccio@gmail.com" , "carlo.nonato@minervasys.tech" , Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [RFC v2 04/12] xen/arm32: head: Remove restriction where to load Xen Thread-Topic: [RFC v2 04/12] xen/arm32: head: Remove restriction where to load Xen Thread-Index: AQHY5iekhdeljnYaKUO3Ilpr3vGfIK4fBWIAgCSx6ACADEeWAA== Date: Fri, 25 Nov 2022 15:50:09 +0000 Message-ID: <62EDCEBA-B8B6-4869-99A3-3A430BF9D637@arm.com> References: <20221022150422.17707-1-julien@xen.org> <20221022150422.17707-5-julien@xen.org> <8624949e-6198-1aa3-152f-4294534d6d86@xen.org> In-Reply-To: <8624949e-6198-1aa3-152f-4294534d6d86@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|PA4PR08MB7409:EE_|DBAEUR03FT021:EE_|AS8PR08MB8490:EE_ X-MS-Office365-Filtering-Correlation-Id: fdcb9c41-eaee-43c4-9692-08dacefcc78c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Mc5neD9DftxauksaSD9d5uwkZfBzXkLjyD9CldAW1n6ZPPFGxxnOiUg26ED3CrabUr8PfPfhIUAXt6kc08CXCIMaGc2QwuUqANiZQE7FSKmMUgyh3tisgWvC+LbHcSjthIF/WetVbuer2AkL3086V22PHVQmWTixMuVcwAombaOLAhVSuIvICAIlLb7HD4oi1iEbCT4DRmuQC4TeGBJ6PZ5/N7n0A6pfPDl05hZ+tprCtqF01xOK0Z/SxpmXzR5dzzLUT1vtJCRV3gLQHnYkNf40judY/CnkpeE1Wf+Uc/G/yrVEW/bLoi/LD7CljlzPIwEISwv7r2PDYa1ztNyTYLpyv3mjtM/9OrKKW0khn9Xlpv4Z3bOunK/j7SeKNGSM7lzKoxq8XeWL/6o+57myr3AWu1iT3ZXLjWSkoXpyvpL3Vmjn4rhFVH64TY7HmLtr0M5UIl4uixGL89FXnQTBq4yXbCzaifF5M+k9lP21SAbIXb3fJ5dSQPNmh37d2WTNm+S/Vv0OflPSFGwubkLeD/UuChhguK9L9+Dt21xcAp+ma/sEHtvQL7Bp6WmKyyrmEgmsjS/kNSYph3sCsMMA/SUQC+bxmPqg6p0IAHusrcC2wFlVitBLzxojcisv/apH/ymPizCLC4BB4svTR75l55qKlyXWu64aP4pdNuUv/wJWHLBI4jYbRH9WE8Ekmz/4BWQLkNug09wk3ruuz+rihKtLh4b1uZv4GLZFxcEUxwQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(366004)(346002)(376002)(451199015)(71200400001)(186003)(8936002)(6512007)(6916009)(54906003)(26005)(316002)(53546011)(478600001)(6486002)(33656002)(6506007)(36756003)(86362001)(2616005)(41300700001)(8676002)(38100700002)(4326008)(5660300002)(66476007)(91956017)(66946007)(66556008)(64756008)(76116006)(66446008)(83380400001)(38070700005)(2906002)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7409 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 13de8e41-ba10-488f-2404-08dacefcbb1a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DcWL7fpGwd+CbIK2jom1vyXaOvpzx9P1NNRKFWRHt+M+sVhngM8EOX3ZEPqma7lgYcTwXYJ/vphFemmqIcvt+yAnHh8VGPqxTvZ3W0whSqrLyKOqqcCi/m7TBqjE10gjtF90eYOzVm0wRgvWdIAMemzGDmUUqIhxGaxEcUTj5GMdLFjFRprhWjLwONGcLlLqJJuXLBUrkWwtiXvKJggo/PLybYlpolebLhQjhMWu57/7kGShfuwACAq8voOg0Y4v+13vdEVwPWvKme+GHsYzXYUBdN/NThSFpHBXMRHk1Zz691snW3CYqapTYglmMdD8mRcPidSRs7EMnzYychxfz5/Pw75YVnaLZQU5/9H9zaCsPzYRaiQ6Fca1V6JMneXTnpvNI+eQ/F6BIvk/1s8Jr1Qo34cm1MfT0qskVZR4aA4Yq14mZk/2I6QHx1aKGhx8XVqfI1KNgBr3ibu0GAdmHuOXU2rimrEPOB7UhjlG+gGzodw/ZS0/Smh1dKIbhgwnAxwSqTZIhtExIoN2/dyT3xBDBj/5mkiX/VrIFKWMcHYuxMiK7ohTYE6nSG9yrBpfTqTMbwNEA+mxV3r0VKdB0mmdyt5LSMfsW5iiZlyO3o2kEGGNQ6swu8Mf1YW2TnhiMbQg7uUJ8/BAV5oCQSkrH1Y/7zLrTleAA3ovFr95/BM1Dup0EQ3RNdzudmosq0kqiaK8npvpYb28i3BMzlo8Yg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(70206006)(70586007)(36756003)(41300700001)(6862004)(8936002)(33656002)(40460700003)(82740400003)(4326008)(5660300002)(107886003)(86362001)(36860700001)(26005)(316002)(53546011)(6512007)(6506007)(83380400001)(82310400005)(2616005)(186003)(336012)(54906003)(47076005)(81166007)(478600001)(6486002)(40480700001)(356005)(8676002)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 15:50:30.1150 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fdcb9c41-eaee-43c4-9692-08dacefcc78c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8490 DQoNCj4gT24gMTcgTm92IDIwMjIsIGF0IDIwOjE4LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IEhpIEx1Y2EsDQo+IA0KPiBPbiAyNS8xMC8yMDIyIDEyOjU2LCBM dWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4+IE9uIDIyIE9jdCAyMDIyLCBhdCAxNjowNCwgSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4gDQo+Pj4gRnJvbTogSnVsaWVuIEdy YWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCj4+PiANCj4+PiBBdCB0aGUgbW9tZW50LCBib290bG9h ZGVycyBjYW4gbG9hZCBYZW4gYW55d2hlcmUgaW4gbWVtb3J5IGJ1dCB0aGUNCj4+PiByZWdpb24g Mk1CIC0gNE1CLiBXaGlsZSBJIGFtIG5vdCBhd2FyZSBvZiBhbnkgaXNzdWUsIHdlIGhhdmUgbm8g d2F5DQo+Pj4gdG8gdGVsbCB0aGUgYm9vdGxvYWRlciB0byBhdm9pZCB0aGF0IHJlZ2lvbi4NCj4+ PiANCj4+PiBJbiBhZGRpdGlvbiB0byB0aGF0LCBpbiB0aGUgZnV0dXJlLCBYZW4gbWF5IGdyb3cg b3ZlciAyTUIgaWYgd2UNCj4+PiBlbmFibGUgZmVhdHVyZSBsaWtlIFVCU0FOIG9yIEdDT1YuIFRv IGF2b2lkIHdpZGVuaW5nIHRoZSByZXN0cmljdGlvbg0KPj4+IG9uIHRoZSBsb2FkIGFkZHJlc3Ms IGl0IHdvdWxkIGJlIGJldHRlciB0byBnZXQgcmlkIG9mIGl0Lg0KPj4+IA0KPj4+IFdoZW4gdGhl IGlkZW50aXR5IG1hcHBpbmcgaXMgY2xhc2hpbmcgd2l0aCB0aGUgWGVuIHJ1bnRpbWUgbWFwcGlu ZywNCj4+PiB3ZSBuZWVkIGFuIGV4dHJhIGluZGlyZWN0aW9uIHRvIGJlIGFibGUgdG8gcmVwbGFj ZSB0aGUgaWRlbnRpdHkNCj4+PiBtYXBwaW5nIHdpdGggdGhlIFhlbiBydW50aW1lIG1hcHBpbmcu DQo+Pj4gDQo+Pj4gUmVzZXJ2ZSBhIG5ldyBtZW1vcnkgcmVnaW9uIHRoYXQgd2lsbCBiZSB1c2Vk IHRvIHRlbXBvcmFyaWx5IG1hcCBYZW4uDQo+Pj4gRm9yIGNvbnZlbmllbmNlLCB0aGUgbmV3IGFy ZWEgaXMgcmUtdXNpbmcgdGhlIHNhbWUgZmlyc3Qgc2xvdCBhcyB0aGUNCj4+PiBkb21oZWFwIHdo aWNoIGlzIHVzZWQgZm9yIHBlci1jcHUgdGVtcG9yYXJ5IG1hcHBpbmcgYWZ0ZXIgYSBDUFUgaGFz DQo+Pj4gYm9vdGVkLg0KPj4+IA0KPj4+IEZ1cnRoZXJtb3JlLCBkaXJlY3RseSBtYXAgYm9vdF9z ZWNvbmQgKHdoaWNoIGNvdmVyIFhlbiBhbmQgbW9yZSkNCj4+PiB0byB0aGUgdGVtcG9yYXJ5IGFy ZWEuIFRoaXMgd2lsbCBhdm9pZCB0byBhbGxvY2F0ZSBhbiBleHRyYSBwYWdlLXRhYmxlDQo+Pj4g Zm9yIHRoZSBzZWNvbmQtbGV2ZWwgYW5kIHdpbGwgaGVscGZ1bCBmb3IgZm9sbG93LXVwIHBhdGNo ZXMgKHdlIHdpbGwNCj4+PiB3YW50IHRvIHVzZSB0aGUgZml4bWFwIHdoaWxzdCBpbiB0aGUgdGVt cG9yYXJ5IG1hcHBpbmcpLg0KPj4+IA0KPj4+IExhc3RseSwgc29tZSBwYXJ0IG9mIHRoZSBjb2Rl IG5vdyBuZWVkcyB0byBrbm93IHdoZXRoZXIgdGhlIHRlbXBvcmFyeQ0KPj4+IG1hcHBpbmcgd2Fz IGNyZWF0ZWQuIFNvIHJlc2VydmUgcjEyIHRvIHN0b3JlIHRoaXMgaW5mb3JtYXRpb24uDQo+Pj4g DQo+Pj4gU2lnbmVkLW9mZi1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCj4+ PiAtLS0tDQo+Pj4gDQo+Pj4gICAgQ2hhbmdlcyBpbiB2MjoNCj4+PiAgICAgICAgLSBQYXRjaCBh ZGRlZA0KPj4+IC0tLQ0KPj4gSGkgSnVsaWVuLA0KPj4gSeKAmW0gaGl0dGluZyBhbiBhc3NlcnQg d2l0aCB0aGlzIG9uZSwgdGVzdGVkIG9uIHFlbXUgYW5kIGZ2cDoNCj4gDQo+IFRoYW5rcyBmb3Ig dGVzdGluZyB0aGUgc2VyaWVzIQ0KPiANCj4+IFhlbiA0LjE3LXJjDQo+PiAoWEVOKSBYZW4gdmVy c2lvbiA0LjE3LXJjICh1c2VyQGhvc3RuYW1lKSAoYXJtLXBva3ktbGludXgtZ251ZWFiaS1nY2Mg KEdDQykgMTEuMy4wKSBkZWJ1Zz15IFR1ZSBPY3QgMjUgMTA6NTE6MDYgVVRDIDIwMjINCj4+IChY RU4pIExhdGVzdCBDaGFuZ2VTZXQ6DQo+PiAoWEVOKSBidWlsZC1pZDogYWIxNDNiMTNmNDM5NGNl ZDUzMzFkNmZmMWNlZGViZGIyZmZhZGMwNw0KPj4gKFhFTikgUHJvY2Vzc29yOiA0MTJmYzBmMTog IkFSTSBMaW1pdGVkIiwgdmFyaWFudDogMHgyLCBwYXJ0IDB4YzBmLHJldiAweDENCj4+IChYRU4p IDMyLWJpdCBFeGVjdXRpb246DQo+PiAoWEVOKSAgIFByb2Nlc3NvciBGZWF0dXJlczogMDAwMDEx MzE6MDAwMTEwMDENCj4+IChYRU4pICAgICBJbnN0cnVjdGlvbiBTZXRzOiBBQXJjaDMyIEEzMiBU aHVtYiBUaHVtYi0yIFRodW1iRUUgSmF6ZWxsZQ0KPj4gKFhFTikgICAgIEV4dGVuc2lvbnM6IEdl bmVyaWNUaW1lcg0KPj4gKFhFTikgICBEZWJ1ZyBGZWF0dXJlczogMDIwMTA1NTUNCj4+IChYRU4p ICAgQXV4aWxpYXJ5IEZlYXR1cmVzOiAwMDAwMDAwMA0KPj4gKFhFTikgICBNZW1vcnkgTW9kZWwg RmVhdHVyZXM6IDEwMjAxMTA1IDIwMDAwMDAwDQo+PiAoWEVOKSAgICAgICAgICAgICAgICAgICAg ICAgICAgMDEyNDAwMDAgMDIxMDIyMTENCj4+IChYRU4pICAgSVNBIEZlYXR1cmVzOiAwMjEwMTEx MCAxMzExMjExMSAyMTIzMjA0MQ0KPj4gKFhFTikgICAgICAgICAgICAgICAgIDExMTEyMTMxIDEw MDExMTQyIDAwMDAwMDAwDQo+PiAoWEVOKSBVc2luZyBTTUMgQ2FsbGluZyBDb252ZW50aW9uIHYx LjANCj4+IChYRU4pIFVzaW5nIFBTQ0kgdjAuMg0KPj4gKFhFTikgU01QOiBBbGxvd2luZyA0IENQ VXMNCj4+IChYRU4pIEdlbmVyaWMgVGltZXIgSVJROiBwaHlzPTMwIGh5cD0yNiB2aXJ0PTI3IEZy ZXE6IDYyNTAwIEtIeg0KPj4gKFhFTikgR0lDdjJtIGV4dGVuc2lvbiByZWdpc3RlciBmcmFtZToN Cj4+IChYRU4pICAgICAgICAgZ2ljX3YybV9hZGRyPTAwMDAwMDAwMDgwMjAwMDANCj4+IChYRU4p ICAgICAgICAgZ2ljX3YybV9zaXplPTAwMDAwMDAwMDAwMDEwMDANCj4+IChYRU4pICAgICAgICAg Z2ljX3YybV9zcGlfYmFzZT04MA0KPj4gKFhFTikgICAgICAgICBnaWNfdjJtX251bV9zcGlzPTY0 DQo+PiAoWEVOKSBHSUN2MiBpbml0aWFsaXphdGlvbjoNCj4+IChYRU4pICAgICAgICAgZ2ljX2Rp c3RfYWRkcj0wMDAwMDAwMDA4MDAwMDAwDQo+PiAoWEVOKSAgICAgICAgIGdpY19jcHVfYWRkcj0w MDAwMDAwMDA4MDEwMDAwDQo+PiAoWEVOKSAgICAgICAgIGdpY19oeXBfYWRkcj0wMDAwMDAwMDA4 MDMwMDAwDQo+PiAoWEVOKSAgICAgICAgIGdpY192Y3B1X2FkZHI9MDAwMDAwMDAwODA0MDAwMA0K Pj4gKFhFTikgICAgICAgICBnaWNfbWFpbnRlbmFuY2VfaXJxPTI1DQo+PiAoWEVOKSBHSUN2Mjog Mjg4IGxpbmVzLCA0IGNwdXMgKElJRCAwMDAwMDAwMCkuDQo+PiAoWEVOKSBYU00gRnJhbWV3b3Jr IHYxLjAuMSBpbml0aWFsaXplZA0KPj4gKFhFTikgSW5pdGlhbGlzaW5nIFhTTSBTSUxPIG1vZGUN Cj4+IChYRU4pIFVzaW5nIHNjaGVkdWxlcjogU01QIENyZWRpdCBTY2hlZHVsZXIgcmV2MiAoY3Jl ZGl0MikNCj4+IChYRU4pIEluaXRpYWxpemluZyBDcmVkaXQyIHNjaGVkdWxlcg0KPj4gKFhFTikg IGxvYWRfcHJlY2lzaW9uX3NoaWZ0OiAxOA0KPj4gKFhFTikgIGxvYWRfd2luZG93X3NoaWZ0OiAz MA0KPj4gKFhFTikgIHVuZGVybG9hZF9iYWxhbmNlX3RvbGVyYW5jZTogMA0KPj4gKFhFTikgIG92 ZXJsb2FkX2JhbGFuY2VfdG9sZXJhbmNlOiAtMw0KPj4gKFhFTikgIHJ1bnF1ZXVlcyBhcnJhbmdl bWVudDogc29ja2V0DQo+PiAoWEVOKSAgY2FwIGVuZm9yY2VtZW50IGdyYW51bGFyaXR5OiAxMG1z DQo+PiAoWEVOKSBsb2FkIHRyYWNraW5nIHdpbmRvdyBsZW5ndGggMTA3Mzc0MTgyNCBucw0KPj4g KFhFTikgQWxsb2NhdGVkIGNvbnNvbGUgcmluZyBvZiAzMiBLaUIuDQo+PiAoWEVOKSBWRlAgaW1w bGVtZW50ZXIgMHg0MSBhcmNoaXRlY3R1cmUgNCBwYXJ0IDB4MzAgdmFyaWFudCAweGYgcmV2IDB4 MA0KPj4gKFhFTikgQ1BVMDogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxIHRpbWVzIGJlZm9yZSBw YXVzaW5nIHRoZSBkb21haW4NCj4+IChYRU4pIEJyaW5naW5nIHVwIENQVTENCj4+IChYRU4pIEFz c2VydGlvbiAnIWxwYWVfaXNfdmFsaWQoKmVudHJ5KScgZmFpbGVkIGF0IGFyY2gvYXJtL2RvbWFp bl9wYWdlLmM6NjkNCj4gDQo+IFNvIHRoaXMgaXMgYXNzZXJ0aW5nIGJlY2F1c2UsIHNvIGZhciwg Zm9yIHNlY29uZGFyeSBDUFVzLCB3ZSBhcmUgY29weWluZyB0aGUgY29udGVudCBvZiB0aGUgQ1BV MCByb290IHRhYmxlIHRvIHRoZSBzZWNvbmRhcnkgQ1BVIHJvb3QgdGFibGUgYW5kIHRoZW4gdXBk YXRlIHRoZSBlbnRyeS4NCj4gDQo+IFNvIHRoZSBlbnRyeSB3b3VsZCBsb2dpY2FsIGJlIHZhbGlk LiBUaGlzIGlzIGZpbmUgdG8gYmUgdmFsaWQgYmVjYXVzZSB0aGUgcm9vdCBhYmxlIGlzIG5vdCB5 ZXQgbGl2ZS4NCj4gDQo+IEkgaGF2ZSBmb2xsb3ctdXAgcGF0Y2hlcyAobm90IHlldCBzZW50KSB3 aGVyZSB0aGUgcm9vdCB0YWJsZSBmb3Igc2Vjb25kYXJ5IENQVXMgd291bGQgYWxzbyBiZSBsaXZl LiBJIHByb2JhYmx5IG1pc3Rha2VubHkgdGVzdGVkIHdpdGggdGhvc2UgcGF0Y2hlcy4NCj4gDQo+ IEFueXdheSwgdGhlIEFTU0VSVCgpIGhlcmUgZG9lc24ndCBtYWtlIHNlbnNlIGluIHRoZSBjb250 ZXh0IG9mIHRoaXMgcGF0Y2ggYmVjYXVzZSB3ZSBhcmUgc3RpbGwgc3dpdGNoaW5nIHRoZSBDUFUw IHJvb3QgdGFibGUuIFNvIEkgd2lsbCBkcm9wIHRoZSBBU1NFUlQoKSBmb3Igbm93Lg0KPiANCj4g SSB3aWxsIHJlLWludHJvZHVjZSBpdCBpbiBhIGZvbGxvdy11cCBzZXJpZXMuDQo+IA0KPiBCZWZv cmUgSSBzZW5kIGEgbmV3IHZlcnNpb24sIGRvIHlvdSBoYXZlIGFueSBjb21tZW50cyBmb3IgdGhl IHJlc3Qgb2YgdGhlIHBhdGNoZXM/DQoNCkhpIEp1bGllbiwNCg0KWWVzIGFzIHlvdSBwb2ludGVk IG91dCwgdGhlIGFzc2VydCB3YXMgbm90IHJpZ2h0IGluIHRoYXQgY29udGV4dCBhbmQgaXQgY2Fu IGJlIHJlbW92ZWQgd2l0aG91dCBpc3N1ZXMsIEnigJl2ZSBoYWQgYSBsb29rIG9uIHRoZSBzZXJp ZSBhbmQgdGhlIGNoYW5nZXMgbG9va3Mgb2sgdG8gbWUsIEnigJl2ZSBhbHNvIHRlc3RlZA0KdGhh dCBpdCB3b3JrcyBvbiBhcm02NCBhbmQgYXJtMzIgdXNpbmcgRlZQLg0KDQpDaGVlcnMsDQpMdWNh DQoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Fri Nov 25 21:41:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 25 Nov 2022 21:41:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448322.705146 (Exim 4.92) (envelope-from ) id 1oygRK-0006rS-4a; Fri, 25 Nov 2022 21:40:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448322.705146; Fri, 25 Nov 2022 21:40:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oygRK-0006rL-1L; Fri, 25 Nov 2022 21:40:54 +0000 Received: by outflank-mailman (input) for mailman id 448322; Fri, 25 Nov 2022 21:40:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oygRH-0006rB-Rn; Fri, 25 Nov 2022 21:40:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oygRH-0005PI-NN; Fri, 25 Nov 2022 21:40:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oygRH-0008M2-AM; Fri, 25 Nov 2022 21:40:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oygRH-0000NU-8W; Fri, 25 Nov 2022 21:40:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7HSfC1JIX2guDR9xy9fZzpIN3EL2MzMjaw71iYGjGYQ=; b=NS6EK/0CisOTdPbtvKVkmueM5A mq/4KZ6DX8baB9wiW9358mWMw+8A3ukdNFRvayl1Q8gOZ7Ma5oAYn/hLCal2cR8P5N2a63CMEP/cl 3dpVIbHlfAvr5aXB2Svhf84YkuTz5jQGgpsE05AS4L3HUrdBu2IItv27TYShUM+faEI4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174961: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=08ad43d554bacb9769c6a69d5f771f02f5ba411c X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Fri, 25 Nov 2022 21:40:51 +0000 flight 174961 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174961/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux 08ad43d554bacb9769c6a69d5f771f02f5ba411c baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 49 days Failing since 173470 2022-10-08 06:21:34 Z 48 days 90 attempts Testing same since 174957 2022-11-24 20:12:25 Z 1 days 3 attempts ------------------------------------------------------------ 1854 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 175887 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 26 01:14:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 26 Nov 2022 01:14:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448330.705157 (Exim 4.92) (envelope-from ) id 1oyjll-000544-LZ; Sat, 26 Nov 2022 01:14:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448330.705157; Sat, 26 Nov 2022 01:14:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyjll-00053x-Ij; Sat, 26 Nov 2022 01:14:13 +0000 Received: by outflank-mailman (input) for mailman id 448330; Sat, 26 Nov 2022 01:14:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyjlj-00053n-MZ; Sat, 26 Nov 2022 01:14:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyjlj-0000e9-In; Sat, 26 Nov 2022 01:14:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyjlj-00029M-5F; Sat, 26 Nov 2022 01:14:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oyjli-0004fA-Uy; Sat, 26 Nov 2022 01:14:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OtJnM1o2/PKI/3v9Heul9FhPZRe0lfmek0iARSjLGqA=; b=x8ImpcIDMRIebargE44rOSZkaa EDZHAnsiDVGMTkVR2T3E5tHXrQDSmG3iVcQbbuu7RjZeh+YlurGyAbOqYEjmJ4tHAYAeSRhIrA8ol DFb/pgwEWFcHmawI0D3q+g8K3NnRg3ey71Mw5y7C+OM4sJgq8eVyGVpZLiQ8ypK3awNs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 174962: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4d2a309b5c28a2edc0900542d22fec3a5a22243b X-Osstest-Versions-That: linux=771a8acbb84145b943bd608ba376e104ebfa9664 From: osstest service owner Date: Sat, 26 Nov 2022 01:14:11 +0000 flight 174962 linux-5.4 real [real] flight 174965 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174962/ http://logs.test-lab.xenproject.org/osstest/logs/174965/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 174965-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit1 14 guest-start fail like 174746 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174758 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 174758 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174765 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174765 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174765 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174765 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174765 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174765 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174765 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174765 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174765 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174765 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174765 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: linux 4d2a309b5c28a2edc0900542d22fec3a5a22243b baseline version: linux 771a8acbb84145b943bd608ba376e104ebfa9664 Last test of basis 174765 2022-11-14 06:31:36 Z 11 days Testing same since 174962 2022-11-25 17:13:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adam Ford Adrian Hunter Alex Barba Alexander Potapenko Alexander Schmidt Aman Kumar Anastasia Belova Andreas Gruenbacher Andrew G. Morgan Andrew Morton Andrew Price Andy Gospodarek Anna Schumaker Ard Biesheuvel Arend van Spriel Arnaldo Carvalho de Melo Athira Jajeev Athira Rajeev Baisong Zhong Benjamin Block Benjamin Coddington Benoît Monin Borislav Petkov Brian Foster Brian Norris Chandan Babu R Charles Keepax Chen Jun Chen Zhongjin chenxiaosong (A) Chevron Li Christophe JAILLET Chuang Wang Colin Ian King Cong Wang Damien Le Moal Dan Carpenter Dan Carpenter Daniel Borkmann Daniil Tatianin Darrick J. Wong Darrick J. Wong Dave Chinner David E. Box David S. Miller David Sterba Davide Tronchin Disha Goel Dmitry Torokhov Dominique Martinet Doug Brown Duoming Zhou Edwin Török Eric Dumazet Eric Sandeen Filipe Manana Gaosheng Cui Greg Kroah-Hartman Guenter Roeck Guo Ren Hans de Goede Hawkins Jiawei Hulk Robot Ilpo Järvinen Jakub Kicinski Jakub Sitnicki Jan Kara Jens Axboe Jiaxun Yang Jiri Benc Jiri Kosina Jisheng Zhang Johan Hovold Johan Hovold Johannes Berg John Fastabend Jon Hunter Jonathan Cameron Jorge Lopez Juergen Gross Jussi Laako Kees Cook Krzysztof Kozlowski Li Huafei Linus Torvalds Linus Walleij Linux Kernel Functional Testing Luiz Augusto von Dentz Maciej W. Rozycki Marc Kleine-Budde Marek Szyprowski Marek Vasut Mark Brown Martin K. Petersen Martin Schiller Masami Hiramatsu (Google) Matthew Auld Matthias Schiffer Mauro Lima Maxime Ripard Michael Chan Mika Westerberg Mike Snitzer Mikulas Patocka Mitja Spes Mushahid Hussain Nam Cao Nathan Chancellor Nathan Huckleberry Nicolas Dumazet Nicolas Ferre Oliver Hartkopp Palmer Dabbelt Paolo Abeni Paul Cercueil Paul Moore Philipp Zabel Reinhard Speyerer Ricardo Cañuelo Roger Pau Monné Roy Novich Ryusuke Konishi Saeed Mahameed Samuel Thibault Sasha Levin Schspa Shi Sean Anderson Serge Semin Shawn Guo Shawn Guo Shuah Khan Siarhei Volkau Srikanth Thokala Steve French Steven Rostedt (Google) Sudip Mukherjee Sudip Mukherjee syzbot syzbot+5f8dcabe4a3b2c51c607@syzkaller.appspotmail.com Takashi Iwai Tetsuo Handa Thinh Nguyen Thomas Bogendoerfer Tony Lindgren Tudor Ambarus Tvrtko Ursulin Ulf Hansson Vinod Koul Wang ShaoBo Wang Wensheng Wang Yufen Wei Yongjun Wolfram Sang xiafukun Xian Wang Xiaolei Wang Xin Long Xiongfeng Wang Xiu Jianfeng Yang Yingliang Yann Gautier Ye Bin Yuan Can Zeng Heng Zhang Qilong Zhang Xiaoxu ZhangPeng Zhengchao Shao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 771a8acbb841..4d2a309b5c28 4d2a309b5c28a2edc0900542d22fec3a5a22243b -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Sat Nov 26 04:59:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 26 Nov 2022 04:59:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448345.705168 (Exim 4.92) (envelope-from ) id 1oynHk-0005uG-7J; Sat, 26 Nov 2022 04:59:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448345.705168; Sat, 26 Nov 2022 04:59:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oynHk-0005u9-3j; Sat, 26 Nov 2022 04:59:28 +0000 Received: by outflank-mailman (input) for mailman id 448345; Sat, 26 Nov 2022 04:59:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oynHi-0005tz-G6; Sat, 26 Nov 2022 04:59:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oynHi-0005xI-CS; Sat, 26 Nov 2022 04:59:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oynHh-0005fY-Uq; Sat, 26 Nov 2022 04:59:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oynHh-0005KE-Tf; Sat, 26 Nov 2022 04:59:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RZvobTkZcnMlB3TC0DlemXc/lNHbl5toPFwaG1D6bYk=; b=gMc/TPIJdv8UYYNoDx3E/U4Aw/ WA5JcEGj4Loxb18I16mPQYjQfNe9C8kjXTS+4KffBWAc7oxIIxqTWOOAOyuC6pa17l13oxzaljrdP F6wJPmg3gqJS6ITqsKZcoR4CFSD5+k0UhwLoY/JADpVVcYPSqOoakr/iuqgP3xGoeYWo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174963: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=c23a95636622a32352b55a2f164a1fdf4ed34f60 X-Osstest-Versions-That: qemuu=a33c25399f9bc3dcf83064adeba2a82e61bf4608 From: osstest service owner Date: Sat, 26 Nov 2022 04:59:25 +0000 flight 174963 qemu-mainline real [real] flight 174967 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174963/ http://logs.test-lab.xenproject.org/osstest/logs/174967/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 174967-retest test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail pass in 174967-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174949 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174949 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174949 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174949 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174949 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174949 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174949 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174949 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu c23a95636622a32352b55a2f164a1fdf4ed34f60 baseline version: qemuu a33c25399f9bc3dcf83064adeba2a82e61bf4608 Last test of basis 174949 2022-11-23 22:10:03 Z 2 days Testing same since 174963 2022-11-25 21:08:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Marc Hartmayer Stefan Hajnoczi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git a33c25399f..c23a956366 c23a95636622a32352b55a2f164a1fdf4ed34f60 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat Nov 26 05:20:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 26 Nov 2022 05:20:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448354.705178 (Exim 4.92) (envelope-from ) id 1oynbu-0001QR-0F; Sat, 26 Nov 2022 05:20:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448354.705178; Sat, 26 Nov 2022 05:20:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oynbt-0001QK-Tz; Sat, 26 Nov 2022 05:20:17 +0000 Received: by outflank-mailman (input) for mailman id 448354; Sat, 26 Nov 2022 05:08:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oynQ5-0007uV-3J for xen-devel@lists.xenproject.org; Sat, 26 Nov 2022 05:08:05 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4d2a4e19-6d48-11ed-8fd2-01056ac49cbb; Sat, 26 Nov 2022 06:08:03 +0100 (CET) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AQ4uq8i011137; Sat, 26 Nov 2022 05:07:56 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3m3c7dg07b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 26 Nov 2022 05:07:56 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2AQ4jExv023572; Sat, 26 Nov 2022 05:07:54 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3m3c1q8p74-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 26 Nov 2022 05:07:54 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2AQ52vF1011626; Sat, 26 Nov 2022 05:07:54 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3m3c1q8p61-1; Sat, 26 Nov 2022 05:07:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d2a4e19-6d48-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=corp-2022-7-12; bh=hEdmssi73mdZJZby6VH83OA2wc6mC+NgmIbVOzmV8+8=; b=YRv/MbqsKUL00lc46HNMmHbRZN5nRNTAQSZErCmQ2JKouYF8lTgHw57IJg+gbcbUbFqd j/TK0X5TvVm+D17WWxIbHD5sXRrb0EQDkYT7HLk+f4wMyOHpW0UMMKIdc+AGmnF94kXY pCo1Pr5LKwMXHqCEwUM9EthDW3yd7Sh7MsHRsSjOzX0BKlDzISo74jDFDZc4mTCMHiVu znFxsXqHM9Q5kTfP4XJqoiVdVTZuyKDNB8v2tUI5u2agBmzDcSSQLsld1MHGaIemOh1K g3xsbZodojcNStcjzFzSsRZLSw67l4LmbjP2+Cwy4O0qqFAahDmoBZ7vboDmM0cvvmc9 nw== From: Harshit Mogalapalli To: Cc: harshit.m.mogalapalli@oracle.com, error27@gmail.com, harshit.m.mogalapalli@gmail.com, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Paul Durrant , Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: [PATCH] xen/privcmd: Fix a possible warning in privcmd_ioctl_mmap_resource() Date: Fri, 25 Nov 2022 21:07:45 -0800 Message-Id: <20221126050745.778967-1-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-26_04,2022-11-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211260040 X-Proofpoint-GUID: kO7OwKz7A5zcOQYmakxJLrTnzyx51z-5 X-Proofpoint-ORIG-GUID: kO7OwKz7A5zcOQYmakxJLrTnzyx51z-5 As 'kdata.num' is user-controlled data, if user tries to allocate memory larger than(>=) MAX_ORDER, then kcalloc() will fail, it creates a stack trace and messes up dmesg with a warning. Call trace: -> privcmd_ioctl --> privcmd_ioctl_mmap_resource Add __GFP_NOWARN in order to avoid too large allocation warning. This is detected by static analysis using smatch. Fixes: 3ad0876554ca ("xen/privcmd: add IOCTL_PRIVCMD_MMAP_RESOURCE") Signed-off-by: Harshit Mogalapalli --- drivers/xen/privcmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index fae50a24630b..1edf45ee9890 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -760,7 +760,7 @@ static long privcmd_ioctl_mmap_resource(struct file *file, goto out; } - pfns = kcalloc(kdata.num, sizeof(*pfns), GFP_KERNEL); + pfns = kcalloc(kdata.num, sizeof(*pfns), GFP_KERNEL | __GFP_NOWARN); if (!pfns) { rc = -ENOMEM; goto out; -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Sat Nov 26 08:08:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 26 Nov 2022 08:08:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448375.705189 (Exim 4.92) (envelope-from ) id 1oyqED-00047v-6n; Sat, 26 Nov 2022 08:08:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448375.705189; Sat, 26 Nov 2022 08:08:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyqED-00047o-4E; Sat, 26 Nov 2022 08:08:01 +0000 Received: by outflank-mailman (input) for mailman id 448375; Sat, 26 Nov 2022 08:08:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyqEC-00047e-EX; Sat, 26 Nov 2022 08:08:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyqEC-0002P8-BU; Sat, 26 Nov 2022 08:08:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyqEB-0004xL-Q4; Sat, 26 Nov 2022 08:07:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oyqEB-0006yO-Pb; Sat, 26 Nov 2022 08:07:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=loyUmBhEEVRAkIlNBFHq2MWjjp404Oegszcjh6FrljQ=; b=lhVmGajFEfY1Jjc3f8NbiCofXQ KPoXZlb2K+Ix9nGx2M3Hrk1+/0R8VcJKM7x5Kxzskn3n8DSgUZJkcGd4XnFX4UP248ymw54UZPTuI /DkqWAqSbQbi4PJ34pTX8U1TzWwVWMAo/vwJv7mlQapb5AashkQoBluIa7MjiXwexRuQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174964: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:guest-start/debian.repeat:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f10b439638e2482a89a1a402941207f6d8791ff8 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sat, 26 Nov 2022 08:07:59 +0000 flight 174964 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174964/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 19 guest-start/debian.repeat fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux f10b439638e2482a89a1a402941207f6d8791ff8 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 49 days Failing since 173470 2022-10-08 06:21:34 Z 49 days 91 attempts Testing same since 174964 2022-11-25 22:09:38 Z 0 days 1 attempts ------------------------------------------------------------ 1888 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 179445 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 26 08:49:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 26 Nov 2022 08:49:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448385.705201 (Exim 4.92) (envelope-from ) id 1oyqsf-0000qi-DW; Sat, 26 Nov 2022 08:49:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448385.705201; Sat, 26 Nov 2022 08:49:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyqsf-0000qb-9r; Sat, 26 Nov 2022 08:49:49 +0000 Received: by outflank-mailman (input) for mailman id 448385; Sat, 26 Nov 2022 08:49:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyqsd-0000qR-Ko; Sat, 26 Nov 2022 08:49:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyqsd-0003Lq-GV; Sat, 26 Nov 2022 08:49:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyqsc-0005vS-WD; Sat, 26 Nov 2022 08:49:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oyqsc-0003ru-Vm; Sat, 26 Nov 2022 08:49:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YOY1pXs9BYFPXLq6IDFxUDYVQZ9fRuf3kdXbdxWPNUo=; b=E2IYdJc0J8S7OioemD8N6BCrM6 4evhU8v5wb9ab15eoaY2/jWgQZAXCcb4I6XtiHlgCtuzc+937rDZIylQ7qJ4hZiu+SlWAY5knTEYW 0qxrbefYcWqZjqh7gZ/5LUuUeUYCSyt5D8UObTU53j0mIzs/iT2LfN8tuihGAKTtLQkk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174966: FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-migrupgrade::broken:regression xen-unstable:test-amd64-amd64-migrupgrade:host-install/dst_host(7):broken:heisenbug xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-amd64-i386-pair:xen-install/dst_host:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=345135942bf9632eba1409ba432cfcae3b7649c7 X-Osstest-Versions-That: xen=345135942bf9632eba1409ba432cfcae3b7649c7 From: osstest service owner Date: Sat, 26 Nov 2022 08:49:46 +0000 flight 174966 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174966/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-migrupgrade broken in 174958 Tests which are failing intermittently (not blocking): test-amd64-amd64-migrupgrade 7 host-install/dst_host(7) broken in 174958 pass in 174966 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 174958 pass in 174966 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 174958 Tests which did not succeed, but are not blocking: test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 174958 like 174950 test-amd64-i386-pair 11 xen-install/dst_host fail in 174958 like 174950 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174958 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174958 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174958 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174958 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174958 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174958 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174958 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174958 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174958 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174958 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174958 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174958 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 345135942bf9632eba1409ba432cfcae3b7649c7 baseline version: xen 345135942bf9632eba1409ba432cfcae3b7649c7 Last test of basis 174966 2022-11-26 01:54:48 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-migrupgrade broken Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Nov 26 16:07:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 26 Nov 2022 16:07:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448487.705212 (Exim 4.92) (envelope-from ) id 1oyxiA-0000oa-9K; Sat, 26 Nov 2022 16:07:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448487.705212; Sat, 26 Nov 2022 16:07:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyxiA-0000oT-6B; Sat, 26 Nov 2022 16:07:26 +0000 Received: by outflank-mailman (input) for mailman id 448487; Sat, 26 Nov 2022 16:07:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyxi9-0000oJ-Dw; Sat, 26 Nov 2022 16:07:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyxi9-0004lc-A8; Sat, 26 Nov 2022 16:07:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyxi8-0002K5-TF; Sat, 26 Nov 2022 16:07:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oyxi8-0001oo-Si; Sat, 26 Nov 2022 16:07:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NKtrpvPYP3wY/mGodpdxJHscl+MLlyKUad7x+gJPDxU=; b=Q7rEUd/c/G25l60wWL96LzNLvl Hv/G1CGVp/QD33t+Zv2E/wLAh1CsKFtRFfryHBriOD8WueYzJCV0LinmSRxIpM12EdDuRKzj0S/u3 goCgZtcsmXsxCRDK818YNXHhhUO41wGP/eWSzYVNfQ4IKTuYTKqhc1m0JeNJ/p+PPYko=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174968: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=644e9524388a5dbc6d4f58c492ee9ef7bd4ddf4d X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sat, 26 Nov 2022 16:07:24 +0000 flight 174968 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174968/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux 644e9524388a5dbc6d4f58c492ee9ef7bd4ddf4d baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 49 days Failing since 173470 2022-10-08 06:21:34 Z 49 days 92 attempts Testing same since 174968 2022-11-26 08:13:05 Z 0 days 1 attempts ------------------------------------------------------------ 1889 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 180125 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Nov 26 16:54:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 26 Nov 2022 16:54:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448499.705223 (Exim 4.92) (envelope-from ) id 1oyyRk-0006mL-Qu; Sat, 26 Nov 2022 16:54:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448499.705223; Sat, 26 Nov 2022 16:54:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyyRk-0006mE-OD; Sat, 26 Nov 2022 16:54:32 +0000 Received: by outflank-mailman (input) for mailman id 448499; Sat, 26 Nov 2022 16:54:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyyRj-0006m4-1f; Sat, 26 Nov 2022 16:54:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyyRi-0005nY-WB; Sat, 26 Nov 2022 16:54:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyyRi-0003VV-L5; Sat, 26 Nov 2022 16:54:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oyyRi-0003WX-Kg; Sat, 26 Nov 2022 16:54:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=W28/HACQ/NVtaqeqfum4fYaH4urBAhTxNHMZuuWk7/I=; b=hsTP6k55CSKCYs6lGO6JGIVVtZ tvgWR076jN3zjggs7Y5fGWokD8x31nFtw9hI/ND7Zo43tbh1ZujqRwcgo+ZgoXho/ofmgh7y7vQ2Y ZseZ+Yfrh0KS8EVxYmm6YvLkk+ZeE6R5eum/9KxtaJMb80WKEqoMFJRrZT7pnvwjJtvs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174969: all pass - PUSHED X-Osstest-Versions-This: ovmf=6ae2b6648eb4b42b5a133f3cde567f9765467bf6 X-Osstest-Versions-That: ovmf=fff6d81270b57ee786ea18ad74f43149b9f03494 From: osstest service owner Date: Sat, 26 Nov 2022 16:54:30 +0000 flight 174969 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174969/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6ae2b6648eb4b42b5a133f3cde567f9765467bf6 baseline version: ovmf fff6d81270b57ee786ea18ad74f43149b9f03494 Last test of basis 174796 2022-11-17 01:55:26 Z 9 days Testing same since 174969 2022-11-26 15:13:18 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Pierre Gondois jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git fff6d81270..6ae2b6648e 6ae2b6648eb4b42b5a133f3cde567f9765467bf6 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Nov 26 22:20:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 26 Nov 2022 22:20:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448525.705234 (Exim 4.92) (envelope-from ) id 1oz3WU-0000KC-7n; Sat, 26 Nov 2022 22:19:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448525.705234; Sat, 26 Nov 2022 22:19:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oz3WU-0000K5-5D; Sat, 26 Nov 2022 22:19:46 +0000 Received: by outflank-mailman (input) for mailman id 448525; Sat, 26 Nov 2022 22:19:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oz3WT-0000Jz-OE for xen-devel@lists.xenproject.org; Sat, 26 Nov 2022 22:19:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oz3WT-0004gv-Il; Sat, 26 Nov 2022 22:19:45 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oz3WT-0002M3-7B; Sat, 26 Nov 2022 22:19:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=eRS60oFGFi5pf4vDGiKPgDN7+VvXI+dqwYQ4NM8S5HY=; b=xQHAYCrha6jv32TM3dWqpybFSo nmjCkSqLn8RAaj8Mw4nNbQz8JsbqYfy9YJHAkeCuEOrZMqd/XHhcW/17dOxCMyDGi7IYDR/v1YmR+ iFSga+OrNP8NrtBH8r2OzPZfi3duDOpGB2EKx4XiQFsWS9Dma5lvtMujVqgHeFfBhSxA=; Message-ID: Date: Sat, 26 Nov 2022 22:19:42 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 To: Per Bilse , xen-devel@lists.xenproject.org Cc: Paul Durrant , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <06ad4b3a67a15192fc986b35e3f2fcd35b2f4c2f.1669383767.git.per.bilse@citrix.com> From: Julien Grall Subject: Re: [PATCH] ioreq_broadcast(): accept partial broadcast success In-Reply-To: <06ad4b3a67a15192fc986b35e3f2fcd35b2f4c2f.1669383767.git.per.bilse@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 25/11/2022 14:15, Per Bilse wrote: > A change to XAPI varstored causes For those unfamiliar with XAPI (like me), can you explain what was the change made? > an unnecessary error message > to be logged in hypervisor.log whenever an RTC timeoffset update > is broadcast. > In extreme cases this could flood the log file. Which should be ratelimited as this is using guest error loglevel. But I think this is irrelevant here. It would be more relevant to explain why it is OK to allow a partial broadcast. > This patch modifies ioreq_broadcast() to allow partial success. The commit message is quite vague, so it is hard to know what you are trying to solve exactly. AFAIU, there are two reasons for ioreq_broadcast to fails: 1) The IOREQ server didn't register the bufioreq 2) The IOREQ buffer page is full While I would agree that the error message is not necessary for 1) (the IOREQ server doesn't care about the event), I would disagree for 2) because it would indicate something went horribly wrong in the IOREQ server and there is a chance your domain may misbehave afterwards. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Nov 26 23:36:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 26 Nov 2022 23:36:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448537.705245 (Exim 4.92) (envelope-from ) id 1oz4iW-00014u-Te; Sat, 26 Nov 2022 23:36:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448537.705245; Sat, 26 Nov 2022 23:36:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oz4iW-00014n-PC; Sat, 26 Nov 2022 23:36:16 +0000 Received: by outflank-mailman (input) for mailman id 448537; Sat, 26 Nov 2022 23:36:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oz4iV-00014d-OO; Sat, 26 Nov 2022 23:36:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oz4iV-0006Np-KO; Sat, 26 Nov 2022 23:36:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oz4iV-0007UB-1m; Sat, 26 Nov 2022 23:36:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oz4iV-00039U-1M; Sat, 26 Nov 2022 23:36:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ypYVxp3PAIikuUa6Dsbyt/TB8YF5gKTGVgJ50iAE3OI=; b=ODYJAcVCXjvcE0wsu/bxM3c42i AaqrxE0zaBTwZFOQdFmFOca5PGZlhTK+zjlMtsr7cqlCEtkLBcpAf2kdz4SPQndYt/7PJlWqicTus +BSNFEDZdh6AV7fSsJpfsqjrCLmHpR8Ef2aqTCHOzfbRn44Jmq4q/EJjWUkMjIkrp3HM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174970: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=644e9524388a5dbc6d4f58c492ee9ef7bd4ddf4d X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sat, 26 Nov 2022 23:36:15 +0000 flight 174970 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174970/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174968 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux 644e9524388a5dbc6d4f58c492ee9ef7bd4ddf4d baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 50 days Failing since 173470 2022-10-08 06:21:34 Z 49 days 93 attempts Testing same since 174968 2022-11-26 08:13:05 Z 0 days 2 attempts ------------------------------------------------------------ 1889 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 180125 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 27 07:10:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 27 Nov 2022 07:10:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448561.705256 (Exim 4.92) (envelope-from ) id 1ozBnA-0007s0-Ed; Sun, 27 Nov 2022 07:09:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448561.705256; Sun, 27 Nov 2022 07:09:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozBnA-0007rt-Ao; Sun, 27 Nov 2022 07:09:32 +0000 Received: by outflank-mailman (input) for mailman id 448561; Sun, 27 Nov 2022 07:09:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozBn8-0007rj-Sl; Sun, 27 Nov 2022 07:09:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozBn8-0000KP-Q8; Sun, 27 Nov 2022 07:09:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozBn8-0003Re-CR; Sun, 27 Nov 2022 07:09:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozBn8-00051H-C2; Sun, 27 Nov 2022 07:09:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=u0ysIPa/iXA+2BkRFbuPDR5C/5oqy8SWMZ2Ph6PXDCQ=; b=d0UZyag3NOSVdWjw6qjA0sr1O4 Xvv8ariTtoNXvONX6AJSTEUlDT29nL0n0Eb4KfpTIndeUatzKeZ2EvPpMI3R6nDnAbsMG39OPKVay Gp+iPBJPuhGHcM3qwjEImO6QfBzq1USWhKZqGUHs2JnGidosxakNvk/QcAo8Z6UKrgfc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174971: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e5f3ec38c8496dd7f6ada8a5e8d4958ef46ddb3f X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sun, 27 Nov 2022 07:09:30 +0000 flight 174971 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174971/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux e5f3ec38c8496dd7f6ada8a5e8d4958ef46ddb3f baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 50 days Failing since 173470 2022-10-08 06:21:34 Z 50 days 94 attempts Testing same since 174971 2022-11-26 23:41:06 Z 0 days 1 attempts ------------------------------------------------------------ 1889 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 180154 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 27 08:31:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 27 Nov 2022 08:31:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448580.705267 (Exim 4.92) (envelope-from ) id 1ozD4M-0001gS-N6; Sun, 27 Nov 2022 08:31:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448580.705267; Sun, 27 Nov 2022 08:31:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozD4M-0001gL-Ja; Sun, 27 Nov 2022 08:31:22 +0000 Received: by outflank-mailman (input) for mailman id 448580; Sun, 27 Nov 2022 08:31:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozD4L-0001gB-L5; Sun, 27 Nov 2022 08:31:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozD4L-0002qT-Cg; Sun, 27 Nov 2022 08:31:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozD4L-0005Kl-01; Sun, 27 Nov 2022 08:31:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozD4K-0005RI-Vn; Sun, 27 Nov 2022 08:31:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mJ2wY5idI8hsxECV0gIgWFjsXM+fkzaKKp7rAlOQ3c0=; b=P7Kq0NapoEC6GLI42tiW1OS5fv eL/j1bcAbKG2riGcDdRNVs80IR2O1/qdT1+CDYoUaNYj3K8gsmKW+ukCBi2gNZ+FcW6zYpw9jhYYJ t0z8gSwVhZFds88j+0AV6S+bhR0m3H46UkD3WOizw5TFS8YHeGw0h9+R1f42G11gLIbY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174972: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=345135942bf9632eba1409ba432cfcae3b7649c7 X-Osstest-Versions-That: xen=345135942bf9632eba1409ba432cfcae3b7649c7 From: osstest service owner Date: Sun, 27 Nov 2022 08:31:20 +0000 flight 174972 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174972/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 174944 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174966 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174966 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174966 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174966 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174966 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174966 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174966 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174966 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174966 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174966 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174966 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174966 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 345135942bf9632eba1409ba432cfcae3b7649c7 baseline version: xen 345135942bf9632eba1409ba432cfcae3b7649c7 Last test of basis 174972 2022-11-27 01:53:30 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Nov 27 09:54:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 27 Nov 2022 09:54:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448612.705277 (Exim 4.92) (envelope-from ) id 1ozEMw-0002Sd-Oa; Sun, 27 Nov 2022 09:54:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448612.705277; Sun, 27 Nov 2022 09:54:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozEMw-0002SW-Lr; Sun, 27 Nov 2022 09:54:38 +0000 Received: by outflank-mailman (input) for mailman id 448612; Sun, 27 Nov 2022 09:54:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozEMu-0002SA-N8 for xen-devel@lists.xenproject.org; Sun, 27 Nov 2022 09:54:37 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7d49a027-6e39-11ed-8fd2-01056ac49cbb; Sun, 27 Nov 2022 10:54:33 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 6A9FF320055E; Sun, 27 Nov 2022 04:54:29 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 27 Nov 2022 04:54:29 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 27 Nov 2022 04:54:28 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d49a027-6e39-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1669542868; x=1669629268; bh=/nyVVkXYpc LUQ3I1Vv0EYGMVOOMOKOiSTDK26qoDx+E=; b=BaMQ/i9NyAg/HE+XcH5mwJlt6n ySmD4gLeNolVe+8M756wKMTpi1Ds9BxwkV3PctX+RBnKdVFTmK6V94j68ZE9JKRP G5aBsxYGBRcVl61aFPMJYiFqDe0ncncQfhQASB9H0r59KgThV4/Vd0RZhPFrVqP+ miYlfBa+/f7jw/Ct77t7HlKXTiXEAGJLuwKhxUdVyzgZSxQB7gO4hXPFltINQPHQ j2vsvqvD8OqrAKi02/bHiQtwMoJP6EBQ1L7cgR4RrIWUnvMf9MhSC0+tsdjJ+e1Y B90K0qFmvC5wAymY+3DN9Cu/mGCJoJ9za+u77eptfAwgKIrOOKcxHnf37f9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669542868; x= 1669629268; bh=/nyVVkXYpcLUQ3I1Vv0EYGMVOOMOKOiSTDK26qoDx+E=; b=X vP9zqvZXecROyVCg+SvYg2zYzBp7ysZx+B0LE7fv77lyaP/quIzwrnfQ42QLCrWA IOf8aJVQgNHQHtPGv+4UHlMqX2pE1xDYg2pjdYiOudBlluTe2A6VIyRVUe9l+rN/ 6cS66NH2qBlP6v3pZDbQDFyiIrARTpsqOJigI3gNFGOmZdAba/3FXvbMXY+4i8nA GHowoAGjOYbTOZvfwKlDstpC6MWK5jhtfpmdTXg5h7aOYoD6Dqh1GTST/CDy9vTA xrDHXtxg45xfujYf0Zt7N0RvY+cFQHd+YG/9AN/GPUIvRK2vRDdxnxTF26CB8sDR dqT5jYLfa5gHBcVhj1XnA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrjedtgddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfggtggusehgtderredttddvnecuhfhrohhmpeffvghmihcuofgr rhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrg gsrdgtohhmqeenucggtffrrghtthgvrhhnpeevleelvdekteelfeehhfelvdehuedtjefh hffgiefhteefvdejieefieekiedvveenucffohhmrghinhepkhgvrhhnvghlrdhorhhgpd hgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Sun, 27 Nov 2022 04:54:21 -0500 From: Demi Marie Obenour To: christian.koenig@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Xen developer discussion Subject: AMD GPU problems under Xen Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/dOlGWuXhLnYEtzK" Content-Disposition: inline --/dOlGWuXhLnYEtzK Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sun, 27 Nov 2022 04:54:21 -0500 From: Demi Marie Obenour To: christian.koenig@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Xen developer discussion Subject: AMD GPU problems under Xen Dear Christian: What is the status of the AMDGPU work for Xen dom0? That was mentioned in https://lore.kernel.org/dri-devel/b2dec9b3-03a7-e7ac-306e-1da024af8982@amd.= com/ and there have been bug reports to Qubes OS about problems with AMDGPU under Xen (such as https://github.com/QubesOS/qubes-issues/issues/7648). --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --/dOlGWuXhLnYEtzK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmODM9IACgkQsoi1X/+c IsFyBA//fSTtWGG9syzbN2dIq6XysSBSQgk/WUqfRDUHzHfCgceUchls8HEAy8wG nc95JrlwBPclJbepOWEpJBBD3OlMJqwga4XhIH/h9RP93hnPzEBpNNNP7zDiBqHX zi4+zE5ZepVJKbGMF0Yo5TNJIbbZp7XuGgmXwGCNf78eogUUjmqPcsAzR5FgqM0B UqDZwWy3yp8R/jxNgi5NAruZ+8p+1o3bKLVaAIzs6lKonGXqH1umqsEZuuKoL8K1 +TiOLlamCi+LwInsYPjwTYGYC8cvcrQ6ZIeaK4SslC96EXI/Z5SulTVkpxblw/br NYnvcDBSSpbI85b316UBFoLXiP6jlsznnV5VydqEJm8LHV1oGPLeqJ54DE7rFZQe AzrOSVgJKAPy4uB6JuzDZAWjhgYjHUbagwByuqujlijkqP7VN8F4CI4fEmseP1/a s2zes6k9h1hBKgNzHlGG8Sh/u5dZz6sMnvyPHFBNpvm1mXRTuTTmi3C4G5wZ3oID mPCoBd/SJHMPj9EW9wOEqV2AVCltxeEMgCqO1EYUkANhtVIShtvRwIZ26En1zYjv t/HykGEHYQuSGW+tInJ2Xbt449hSNtvy7TMQcp/2qKDXYFYPUgNcQtzBiTribJBH yoDKfepvU7ojv1cRs34/GHC3g2CV7mSEk4habNVv++rkr+Ip4Ac= =/WPx -----END PGP SIGNATURE----- --/dOlGWuXhLnYEtzK-- From xen-devel-bounces@lists.xenproject.org Sun Nov 27 13:33:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 27 Nov 2022 13:33:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448665.705288 (Exim 4.92) (envelope-from ) id 1ozHm8-0001Af-Di; Sun, 27 Nov 2022 13:32:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448665.705288; Sun, 27 Nov 2022 13:32:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozHm8-0001AY-B8; Sun, 27 Nov 2022 13:32:52 +0000 Received: by outflank-mailman (input) for mailman id 448665; Sun, 27 Nov 2022 13:32:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozHm6-0001AM-Iu for xen-devel@lists.xenproject.org; Sun, 27 Nov 2022 13:32:50 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eae::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id faf7e276-6e57-11ed-8fd2-01056ac49cbb; Sun, 27 Nov 2022 14:32:47 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by DS7PR12MB5720.namprd12.prod.outlook.com (2603:10b6:8:73::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.22; Sun, 27 Nov 2022 13:32:43 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57%4]) with mapi id 15.20.5857.022; Sun, 27 Nov 2022 13:32:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: faf7e276-6e57-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OnkpVN0hdm86QEfUMAz7+46VHO84Ff/w5undHcCdwkrKxwa2OXo95WH+JNV+vhZZqfcMMJqhWYqBruHLF3ZT57ElKxjcWZ12wIOkhI4D4rP0YUA5iDTqlD+/weGNNFvtjr9/+RnCzw3KznTWMMeEBN1l54fnoNsiMFBI87lessrk2Pwb7nIptFx4ZcP6s9Ke+DGtBagHonHQ7b3RmGi/Pd4zE0tURG5UqPsIa8zel0ppJ9UMqdpACP4NumlxTHe5RE/prD6nig1kemkIs4bcWXDAzVdR+fWAZKkIUVX87j2BW5Ju3hgK59SYEp+iMjvInaMDuEJB/wT3Qr3adiXXWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AI6Bpawt/zYRo2wBr5OsW0H21+PjSq4U8+j/r+iLFGs=; b=GkcJJIDIQHc0Dr6qJBEhagfrzTZJe88G9YFgpLHrbbj8oZ7xBy4z2PfO+Dph1+Se60D2ArfP8jCd/t/tYZmCXySE3RbI7oRiHd2DkTTvU/Fiqw/arXAeLgTygdqiNKOUpUPlSmpLaEg6xxLRUBEklt4COvDV7uBZYM42PdeiOgxdkdQ7DwChtgdCRo468w4ky6bsTE92qyzKZTiF5GtDWqbj4LuVIunnhIVQTSj7GChzXgZnUNmFMOGqSw2I61CxXE6Z8KjuKytTX1HmOPDJsmZLq8h6YYC0zQLJZYDsAak0r2bU9iEVZXN5TFXf6aCwAcHmxbIqeM58V53Q4yKh8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AI6Bpawt/zYRo2wBr5OsW0H21+PjSq4U8+j/r+iLFGs=; b=J/ppLClsECYymFVEn3XDqxmQJ4aYAzQIsbdysKcG4PqvUJ0U6K76PemUXWDPgErpu5uYdbT0IDpEmqC5BokyHZ921wu2qrh/uK8KSz8lXOFwVa+3Qve457/461TBPKB6z8Vr8rqEAe1A5KlZ4g1tT0kEZS5GEGrkQXuoP5TvtDA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <382e5e7d-5bb3-7d7f-913f-842407d9414b@amd.com> Date: Sun, 27 Nov 2022 13:32:31 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN v3 02/12] xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32 To: Michal Orzel , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, jgrall@amazon.com, burzalodowa@gmail.com References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-3-ayan.kumar.halder@amd.com> <8086e3ac-445b-17a1-bba3-078024ab2579@amd.com> From: Ayan Kumar Halder In-Reply-To: <8086e3ac-445b-17a1-bba3-078024ab2579@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0383.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::10) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DS7PR12MB5720:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d944c0e-5834-4daf-c99a-08dad07bdb19 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W433uVDrmXzaw9+nzg5MeFMZRJX2SCwhS8YGMzbcGVYamayfY+ORLNdwnhbsznmNGUOIJcuf1ky4L1mqKXHAi6HwzgRZmKT4GfJxG0tPAPT9pNzjUvlsfqo70wthQOkBQdkMQnZS323K/YzEpaM7VvAaKi6YBhqFktoGX9+sNX76YgeDtftRHxWZARbvIMAEAgT+67uyz3azUoMv0/N3q+ipXDOppnvE7HcqNqJrkZVVtHenatVT8FY9JTS1XkJOidgu8bKK8bNiZuM7e+ap2tW0AKfOxA4hWmYBYwt7F0Fw9HOFmfMcEy5S6zJJ2AXSR25LcgDcFcOM8/J+To7YV8zrzRyFgS1Fs3h+S7rAxKVgOI4bL8oj+c+rrdB3eG/25XAcLoa76Pbfb9r96w0zs2A1rCn2S8kyyhoebDfLHzPF8WdX04zMc+Hd2ThkCjUE8t7O7QQLOuvjn7HeqA4xkdSz/URR2KKE7yqAfo3n5H/d6+UQq6f5JOl9x3kmmrnDMqOD/kP/uxMAzgZPtlsANNU2yGllKHFHImU9on3TnfyxWQKOtdeLLA5ObJJGKrNMC5JXL+DrMm5dbVq1YOzRsFArGnFig2ZZzS45ZeypnHWZU1bEwS09ziAIGEHDer4PsGIAlFgnJh4Qf2+dUJEfhYhSEKe0Zp4s2J6G3xUk29oDS1XWse6zvLyQH1zm+arh0Qt2jb/JJIMnE44DV80JmUfUhjtX8oC2RztIOxj+GLs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(366004)(136003)(346002)(451199015)(478600001)(41300700001)(66476007)(66556008)(66946007)(8936002)(38100700002)(4326008)(6506007)(6666004)(5660300002)(6512007)(26005)(53546011)(8676002)(316002)(31696002)(110136005)(36756003)(6486002)(83380400001)(2906002)(31686004)(2616005)(186003)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WHdjSkdUS20wM0pOUWhVWTVDVXAvTk9jRkZsMmpiUE52RUdmR2Myb0dWOWJj?= =?utf-8?B?a0pYUHBmWC9HS2dGN0FxL1JYUWlnT3pVZDlUakE0RXlTSWVGazFkN3h3bVRX?= =?utf-8?B?VW9LeVJ4RmNmREhJNEZGWVgvc0dhNEthOGwyeWNYc1FSOXhlTUFIQWo1MlV1?= =?utf-8?B?VEQvZXIzYis0b2JDcVFoZU43eHJiT3oxVG5aV1VqcVhJWWdkSTFTa1l5MUVJ?= =?utf-8?B?dkFQRUU3UHRPL3BySlB2VWxGTzBPL01OTy9yWlpsbFhNZnVYQ3BEZGNhUGVk?= =?utf-8?B?bWJlNDVvUnZLZXpxKzdEbWxpd09UN3c0bHl1Z3JnOEd6bjVhaWswR1FCcXE2?= =?utf-8?B?NzdDcC9SN1BjalYzblFOQnBzbEZqT2xoTHFvZG1ReXBFWWk2UjlnektyekNS?= =?utf-8?B?b1JFZ2I4VlYyYll4aUdJc2l2ZFlIWks3M0hoWWM5TFVvaTVIeUJ1MVpZRzVC?= =?utf-8?B?M0d1SXY2Q01aTms4M01uZHFxSUFVa2dCdlN1NDh6Mjc2cWJZaml5MHFOSXZJ?= =?utf-8?B?RjN1NWUySzRVTGtSMUg0cGZ4OTFLczFLTlYxakZFZmZWL05JSkpHNEs4Y3R4?= =?utf-8?B?bVUyMGtDMWxlN3MxY1dkbWwrdWdaVis4QVVUUzE1TkE5ZUVBZi9LaWRtQll1?= =?utf-8?B?dVhJb2xwbDU2Q3lnL29QVlFuVU83ejJxc3VOd2lqdTJQQkZmUnNNVlNxMndU?= =?utf-8?B?UFY0bWlWOFFVdkpaRS82a1FYV0EveW05SHZIc3F6bXdwZnpMeWI3WGxZV0Rn?= =?utf-8?B?TitFZFpGYzZteHdMWE81cmdnUUtQV0twOWlhUDdlVmQxYkdrbFd1YzBROWND?= =?utf-8?B?UGl6Q21JN0h4ck1ER2hqMWtMcWF5Z0VqTXRYNWMxVFFDMy9HcGwxVjZGb1ZD?= =?utf-8?B?MGZScUNDK3IwUldoTVFNaElMYkkrQ0xsVVBjNTZJRHNRWVpQZ3pIWVJiV2p5?= =?utf-8?B?cWpYc1hZTWozdDhOZ1IzZ0NrNThEc25DbFV5M28rY2tmV2NLbHpSUDdFRllN?= =?utf-8?B?ekc0T2loZEZtZkpIK2hjdUd6WFgyamxxVWhHM2tyN3NIbnhvTGpDOTVteFNC?= =?utf-8?B?K1lMUkl6WXhwZ0daZTl1Zzg5MTBBVTlpZ3hiTHM2R0pQaHJkQml0ZmJZWjlB?= =?utf-8?B?Vzd4b0p6SkkybWhLRk9DSk1KdnFKQUVENkJHOGIwUEhJYlJtQjRsSUFnWUVP?= =?utf-8?B?aUZra2NVWDdJTzM2c2NMaFB6QWV0djFnVG85cnlPQlh5Q0d0K3l2TWE0YXE3?= =?utf-8?B?b0Z5L3A3b2VuaE1XeW1qcWxEVHh3aG8vLzVSUnhHL2UrSTk0SEdCL09XNmpz?= =?utf-8?B?NFQ3WWt0VDJGUW45RXEwbE9FK1E1K1Y3SlRTOUE3VXNTd1BBL2ZuTGpUdjE5?= =?utf-8?B?cUNJOHhOUmhjWVl6bkY4Nm9Da1BRelZlRzlaaFZHN0xKRHdZUGJnSjdVRGJC?= =?utf-8?B?M2swemlLa283SVRhVncxU0thOTcyYmE4N1BPZ3EvaVNwWHNibDY5T2pZa3hK?= =?utf-8?B?WFZPU2wwMEVmMzJYR0RiOE9HMWVsVDRiWHBSMEJMejh5Qmtta1hDSlo5Rllh?= =?utf-8?B?dVh1ZkpFYzNsTDVKTGxoa3JMa0ZyLzNNN1JBcXltRERVVTkzalRBdUdCNlcy?= =?utf-8?B?ZHdvVTcwNi9NRUx4Vk41M0hTMUV2NEZEd3o3WmVEdmovd2R2YUx5NEdJZFJu?= =?utf-8?B?OUhKL2VZbEtyZzFqUW1HaWtNeXE1SnRiOW5Eckx3T0JoQmludUJxRndoUVpT?= =?utf-8?B?amdrYXVaT3p6K0JtYXpqQVE2WEdhWWozaVJ1NDZ1ZHNVZjBwNGx4QzVzaVBa?= =?utf-8?B?eThrMWE0Z3o3RWtNWGVZRzVVekg3TmhBbG84bHdhd2pyb2xUOFBMQzAxTnVu?= =?utf-8?B?TnViZStFQm5HSGNvVTVtbTNzaE9vTXBvcmtvMGNsa1BrZHpXWjM4SWtZVTVC?= =?utf-8?B?bWpJVXh0c3V1YkNIOXoxa29HUTByWE14cklPRjdhMzdwZFE5Mk9Ed2JiNkNS?= =?utf-8?B?UmJEMGhtNGJza0RFakh4SlVJeEZBT2VQQ2UvZThKNHpuOG1yM2JTTkdtWWlH?= =?utf-8?B?UEJjdUZCQldLVS9WWS8rYis2cENwallZVnBRVHB6MmpRaW80VzMzTHBoNHJS?= =?utf-8?Q?QAvJilrnleGTOzAnObgq2NOsP?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d944c0e-5834-4daf-c99a-08dad07bdb19 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2022 13:32:40.5707 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RYV8JX5uHfENFrZrNfWFzvPYYMqm2VlQHfeI54mEvo8rwDe2JxDDENf5cB/2oJvsMQ8RO3fmru7OB0LTwtVCPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5720 On 17/11/2022 13:39, Michal Orzel wrote: > Hi Ayan, Hi Michal, > > On 11/11/2022 15:17, Ayan Kumar Halder wrote: >> Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169 >> Affinity level 3 is not present in AArch32. >> Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106, >> Affinity level 3 is not present in Armv7 (ie arm32). >> Thus, any access to affinity level 3 needs to be guarded within >> "ifdef CONFIG_ARM_64". >> >> Signed-off-by: Ayan Kumar Halder > Reviewed-by: Michal Orzel > > although, IMO the commit msg does not reflect the change (i.e. you do nothing > related to accessing MPIDR, but instead you are just not taking the Aff3 into account for AArch32). > Also, I'm not sure why you used VMPIDR and not MPIDR. Actually MPIDR in EL2 is known as VMPIDR. So I used this name. ReferARM DDI 0487I.aID081822, D17-6354,D17.2.152, VMPIDR_EL2, Virtualization Multiprocessor ID Register - Ayan > > ~Michal From xen-devel-bounces@lists.xenproject.org Sun Nov 27 15:29:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 27 Nov 2022 15:29:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448685.705300 (Exim 4.92) (envelope-from ) id 1ozJaq-0004we-3t; Sun, 27 Nov 2022 15:29:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448685.705300; Sun, 27 Nov 2022 15:29:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozJap-0004wX-WB; Sun, 27 Nov 2022 15:29:20 +0000 Received: by outflank-mailman (input) for mailman id 448685; Sun, 27 Nov 2022 15:29:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozJao-0004wN-Kf; Sun, 27 Nov 2022 15:29:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozJao-0003Sx-HN; Sun, 27 Nov 2022 15:29:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozJao-0001GV-3m; Sun, 27 Nov 2022 15:29:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozJao-0007ZO-3L; Sun, 27 Nov 2022 15:29:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HqYcEr/5GBfkMwJ9XHmgaFPKPnKQAlJQ336aakTJTY8=; b=LfgzExbFvEr1oCqmsudkj7HAf7 Xy5yiSDoDxdysLItsgqwoR0rIarH2RJ4mPOXvybmjoOBGLL2JgpfxFl0+NcVnu2IeAcRunHcuyqIC FMRrPux1eWbEcFQ33xc21gM6eSBGgkOS3MOo1HxW2l1nvId8RV+tbqc8gH2qdXeLHhgM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174973: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=faf68e3523c21d07c5f7fdabd0daf6301ff8db3f X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sun, 27 Nov 2022 15:29:18 +0000 flight 174973 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174973/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux faf68e3523c21d07c5f7fdabd0daf6301ff8db3f baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 50 days Failing since 173470 2022-10-08 06:21:34 Z 50 days 95 attempts Testing same since 174973 2022-11-27 07:13:53 Z 0 days 1 attempts ------------------------------------------------------------ 1890 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 180255 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Nov 27 23:29:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 27 Nov 2022 23:29:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448733.705311 (Exim 4.92) (envelope-from ) id 1ozR4t-0004wa-4y; Sun, 27 Nov 2022 23:28:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448733.705311; Sun, 27 Nov 2022 23:28:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozR4s-0004wR-Vu; Sun, 27 Nov 2022 23:28:50 +0000 Received: by outflank-mailman (input) for mailman id 448733; Sun, 27 Nov 2022 23:28:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozR4r-0004wH-WD; Sun, 27 Nov 2022 23:28:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozR4r-0005pd-T8; Sun, 27 Nov 2022 23:28:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozR4r-00070H-Cw; Sun, 27 Nov 2022 23:28:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozR4r-0008R5-CR; Sun, 27 Nov 2022 23:28:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BHExVzNIwR2EsA9f4M8mXzJMGibnX0sHKkv3aXu4x6w=; b=cf4JTFhk3rriAV/HZqueQORHHf L57yLrYDmmQMlTSIwyUsWCiiSL8dQb1dbmF92ISyEGjSWsJLbHTtEa4HDisYY5ctR+3gf/EYjYP3F PaLwKCEFchfc3owW9/d3kgpX+cev0THbJ1FPiaVeQGjLg8hepbi5t7Z5ygWbEJfeIE78=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174974: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=faf68e3523c21d07c5f7fdabd0daf6301ff8db3f X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sun, 27 Nov 2022 23:28:49 +0000 flight 174974 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174974/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail pass in 174973 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux faf68e3523c21d07c5f7fdabd0daf6301ff8db3f baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 51 days Failing since 173470 2022-10-08 06:21:34 Z 50 days 96 attempts Testing same since 174973 2022-11-27 07:13:53 Z 0 days 2 attempts ------------------------------------------------------------ 1890 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 180255 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Nov 28 08:22:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 08:22:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448772.705322 (Exim 4.92) (envelope-from ) id 1ozZPA-0002G1-4i; Mon, 28 Nov 2022 08:22:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448772.705322; Mon, 28 Nov 2022 08:22:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozZPA-0002Fu-0T; Mon, 28 Nov 2022 08:22:20 +0000 Received: by outflank-mailman (input) for mailman id 448772; Mon, 28 Nov 2022 08:22:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozZP8-0002Fo-KT for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 08:22:18 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2080.outbound.protection.outlook.com [40.107.7.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c3ebf7f2-6ef5-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 09:22:16 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8815.eurprd04.prod.outlook.com (2603:10a6:102:20e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Mon, 28 Nov 2022 08:21:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Mon, 28 Nov 2022 08:21:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3ebf7f2-6ef5-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d7LCkV+wna0NeuP1mD0eQQBXllPDzL/3ISZwcyZVRMGQI4h8RsTufkhBtgGoBggOSlw0/pivC8+1IJEvsiqafK8yQVoSk3qMHgw3wdC4LNXxre0gvwEdbhHPrlZWeD4QOArY38yRcZ5yr3wm02CCx08mbNowfp2iPp8rXeNFTN94hDZlCvVIPd4/x6w78MSendOD3SUdksEhpULJA4XR3xzdDov/625d0ETZkHK4qvg6HkhaDPSCmU1DZDnV8VhRFITKUx8hRWut3mgnuKRdY5l9F3qI7FnW9I1zMJ8g/FVzZCikCIQUfHuRMVkIAms6JPy53+vqxmixbaKnugtsNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hUMt+uhMEJiOxGAdTL1j8fORPcbsuFo+ih4nfw1jzyg=; b=isqp+CY7N+YODy1GCUDUJQ57OCm0H+K98geMwLdSfy5kCAJBnAzPOjEfD6Sy51VnHdYRuf8Z8iR5AAZ7XQ1+3torziTyJBit8a9rxLspOB/9n+bmen19Pqo+0DllbQFLFmHLXmL3p/OJExa9UQft5iTr/GTJoJP+p2Q2TubM8ETsm0nAab0uHmyRe5WFpUCimME9ORk/LhCok3kwg+9wDE4461/pccYey9CjoKchpz0by+ZYoPhwPezWUzQPT2ZzpeW4VJs/S6AXFRSeA5Gw7Efy9CPYYibegMmgAiOhzQiI0p3gIskvF12gkjMUI7GdtPX6igC5CpB5e1e6KHOPtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hUMt+uhMEJiOxGAdTL1j8fORPcbsuFo+ih4nfw1jzyg=; b=x9Z26caiQ3k//GXJ6KQz735jL4/nv6jADdRvQhAz8TpobicZJ8xsYARwJmwz44fU2VxOlPtdRdUQktAzbDWHwFKoZ5BJbooboqzOwyQD7sQG+5Hfji6XhhWZ2oIZCVpJraVtEnKAw70dAlIQSdCq7UbzRnCPK/H4HLzHiBAjEASmOoB2cnkXRCsJHkA8DUDCfKKlQH0yYhTegxY3GhbDV18sWmqBg/hnny/S/TRTyfvRg6iCuRouUXg6iAziB47cnC131bQ5z0sm8gSd8O9NOGStUdBBoiTPccBu2qNINuZ77MDzUgPw2v8F9NcNHdnauWcvFE3novZo5OIktXexxg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 28 Nov 2022 09:21:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] ioreq_broadcast(): accept partial broadcast success Content-Language: en-US To: Per Bilse Cc: Paul Durrant , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <06ad4b3a67a15192fc986b35e3f2fcd35b2f4c2f.1669383767.git.per.bilse@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8815:EE_ X-MS-Office365-Filtering-Correlation-Id: d7b50ef7-28b3-4c90-596c-08dad119964d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C/rbBZF8wr0l0Rm3Vw7f17+GkrjIgYNWmuNSCqMTN+dVX0nZC05Eyhzg6cXIqH7BzfroH3BDEjMMvnm/6L/QYw49WjFY2kce5BKCLB/qDUITGjXzy0cwvDXw0F82Hce5UgofIxHcs/98W4aHDe5vwTWhZchWT2rJrkaFsw4BfeZefJYLRnHZ6D6fbhI0nGPrkx04dfpUGmXegcNIVkalXhz0i1kuAfPyBImf/6GIZzn8yIdRnU0iimqiI8JtOeUsW6o7ufXDQbCToHYAOd/AJGedG/ojkKPPGQFGJWHtM+LNNFNnpT0+/ODbdLbJbd2KDVkK4xBn9q5fIo9pbFm41S0QMB18tvAWx+OlzhnHxr84QdTu+t+so5pXXuIg6xGn/nldAllVhJTmLU5HZb0LQHNRChXZaBD5oNv7cGckfsapuflpBngkBt5MVQ72BfCgJjpE+UYqCVcTilmhG6ie3iIiNWuFlys1xPtHHCd7BFYnnSofYgX72iA18e1F7aBNJKyqxxujZO8UHp6M5RbK/QbgPWJ/FGfdiJ2NXit/tq8ath8owuvP9gXxemg1Jg+7QFHffqYw2ELZiKMvG/z3dGxwENGqWzYGAApqokE+oFCILwPIQ+FsGdde2++swzMaBS+FyTmOI0BEFdR6DqyPaJ+q32OQBEJGljH8tdf+O5Z3doVRoFxKnw8t+7rOL0JVYVbCpP0qRDuowPChiPXOe2UNOh2NhF836v3YCQOCD5A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(136003)(366004)(39860400002)(376002)(451199015)(66946007)(66556008)(8936002)(66476007)(36756003)(8676002)(41300700001)(5660300002)(4326008)(86362001)(31696002)(53546011)(6506007)(6512007)(26005)(83380400001)(186003)(2616005)(54906003)(6916009)(316002)(6486002)(38100700002)(478600001)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2E0Mm5oZldaV0oyMW81UmhoNXgvTzhyM1ZJUUxZS0EyZG13a3Y3RWhuQUZy?= =?utf-8?B?ZWxqNm5WTUxuMko0RmZhTG4vNzUyOHJDSnh2akZnOTM5R0pLclZreXpYbXpt?= =?utf-8?B?S2RIOEdDVnJqU3VjcHdibVYxRjE2U210YTUzRkw1Uytpdi9YdHB1NzNGeWh0?= =?utf-8?B?bHVkazJYY0czazMwd3g0NmJ4NnhRS3lwMzl2aUFiQTNzcVFLRzRDejBoNXd4?= =?utf-8?B?Qy9hNUx6NnRubDlHTWk2QnFYUEpkUUpubXZ5NG5wbXZQdGRweVIyKzZwamR4?= =?utf-8?B?UTZHLzRTZWJGTERIcEFVRWVqbzN5MVZmQ1BLaDNYYXR0a1JwOUtXQVZWcnYw?= =?utf-8?B?aDJTN0M0ZFEzeXlBbVJYbFhRaEVJeDQ0WUhMMHN0K0hzS1MyTDdmejRGYUFN?= =?utf-8?B?Q3hjdmR4YlJzeUdqb21rbXJ1RWN4NFNlbGxPbndOSHd3L0dWMW5WblhIbjR4?= =?utf-8?B?YVlyWUtGVE00YWZWdStLWjAzQmQxUWU5SkEzWVk1RnZOaitGbXVvaTNpdHk1?= =?utf-8?B?ODl5bDR0dEZVVC9jc1NYajVvbU9maWdISUNML0RoZk9aMXdJcGR1TUVyeGEv?= =?utf-8?B?YXp1blk0bEVOcEdnd0k0eGZ6SlU2dWhKTUF4OHFqblBVQzQwcStiRDAvWE9V?= =?utf-8?B?eVJRbHV2TmpyT1NQc2djVmFpZzZMTG5HREppdStQcVVuNzNQNjNPZmd2dTdt?= =?utf-8?B?TTd5d3Fpak5zdkd3YjN1KzA5SmhtMHNPc2RySVp3RFI3bFZUbDVpM0NaYWUv?= =?utf-8?B?OGxJeGFNV1ZQRG1TNlRLajdRWDVLaHFJVjBtZ04yOHl4S1h1YlNWdEQwL2wv?= =?utf-8?B?SXdoQlZrd1MxSG9taC81RHpYdzd0OHpKZ05Lekl6K1h0U2hjZ0hYKzlmUjZt?= =?utf-8?B?WW0wemY2SE4rNzlNYWkvT1hMQW43UXlDcWVxem5MdE1KM2dFODAyYjNzYnVD?= =?utf-8?B?a0Q5MWEwNDlyQzM0K1VyUThQbFlWWXhZRUovY3lTRThJTXhqRjFZb0VKT3h5?= =?utf-8?B?bjNyQ3E3OVN0d1FqSWJEVnBjOS9tN2ZibFV5ZVZsTmcxd2dKTlJsVmlvcVhM?= =?utf-8?B?TlFrUHV4blZIdi9aYkZwajRWQ2x2SHpvVnZFMHdVTU1pZGhlbjZFZXN3bTND?= =?utf-8?B?ZXgrMG44VTNWTXRqMFB2RlBXNHlKeUtTcUFxOTF6QXBWK2lxVUVpeWRLbStW?= =?utf-8?B?bkhVSmRiYlF5WDFBbHlzSm1YSnlwbUgxajNPSVR6V21COG11OUlGVFlaVFMw?= =?utf-8?B?aFo3bEZ5MDl0NjNyaWVXZW5HSUdqcUYxc1ZFbEZSTU9wYkNseHNCLzcwZUQ4?= =?utf-8?B?WVFsUjV4WVhtV2M1Z0dZTWJ4QUZ6NnhQVDVlWFhlL0FoeVdNSXV4R0Zud1NF?= =?utf-8?B?YzlaL2s5VkQ4dG9GczN6ZWo0RXVobDZERjVzTVBrb1h5V2FhWGx0V3QwelVD?= =?utf-8?B?LzkyOWd3azBjaUFPbUcyUWVwZHZTRTAvZzBqQjBBTVczakkvaDBrZmhCYUs4?= =?utf-8?B?RlZ0eVVjd29Zd1BUWi96NWRoNEM3K2NMMjZZcCtZK2J5ckM0QnJMVkpOOUN0?= =?utf-8?B?VnArQU9scEhhNEZzb2JmN2lHVm43Y21GSjNtWlVpeGlxWE5TRUJiNUNjYjhE?= =?utf-8?B?ZDBTNDA2VUlxUlBic0FiM3hlMVkrTGFRREliWXJXVFJxZ09lV0p5MHNYdUwz?= =?utf-8?B?R0g1dnExUlZvL3FGa3FnSmc3VTBzTi9zSzBMVXFTSjdLdTB4VnZwU0EwMW1x?= =?utf-8?B?aTFFejJobGdkL3ppUkZlVS9zK015YjYxd2hSSHlJYWxYVUZmVlBleVpOcWpH?= =?utf-8?B?dHV6WmkyZVA5MXgrdjlESVdWSkUrQ09ZdzRQa1U3aXlPNFc5RTlqU053ZlBZ?= =?utf-8?B?U0VBVzM1NnJPS211UlZiaHFZU21KRUI3K0syellWejNRRi9ha3NSTDRja0pD?= =?utf-8?B?U09DUjdKcWFOR1FieGVBM0NqK2w4RTRxU3ZGV0F2cHlzV0E1WjRiNUsvWWdO?= =?utf-8?B?dnQ4Y0tMMU9QbzBqK3FKbytQaks0Z1g0Ynl0OVEvWWRWek5CUDh6RCtleGtl?= =?utf-8?B?T2wwRnRaVHVQdXNzZlg1NVdpYUNSZTFnanZsTXRPdmNzL2U5d0Frek42Zjd3?= =?utf-8?Q?JAPIqx+DAxB893VK8mfAZCyrM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7b50ef7-28b3-4c90-596c-08dad119964d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 08:21:45.4573 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LzBDfRu3UjbNUKW3XYHNKV48wfwAZZOrR2+zoCouuofJv2eEzUErSnTrvF6ewTQGl3mNYJkDXjTsdalojBfmug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8815 On 26.11.2022 23:19, Julien Grall wrote: > On 25/11/2022 14:15, Per Bilse wrote: >> A change to XAPI varstored causes > > For those unfamiliar with XAPI (like me), can you explain what was the > change made? > >> an unnecessary error message >> to be logged in hypervisor.log whenever an RTC timeoffset update >> is broadcast. >> In extreme cases this could flood the log file. > > Which should be ratelimited as this is using guest error loglevel. But I > think this is irrelevant here. It would be more relevant to explain why > it is OK to allow a partial broadcast. > >> This patch modifies ioreq_broadcast() to allow partial success. > > The commit message is quite vague, so it is hard to know what you are > trying to solve exactly. AFAIU, there are two reasons for > ioreq_broadcast to fails: > 1) The IOREQ server didn't register the bufioreq > 2) The IOREQ buffer page is full > > While I would agree that the error message is not necessary for 1) (the > IOREQ server doesn't care about the event), I would disagree for 2) > because it would indicate something went horribly wrong in the IOREQ > server and there is a chance your domain may misbehave afterwards. In addition I think ignoring failure (and, as said by Julien, only because of no bufioreq being registered) is (kind of implicitly) valid only for buffered requests. Hence I'm unconvinced of the need of a new boolean function parameter. Instead I think we need a new IOREQ_STATUS_... value representing the "not registered" case. And that could then be used by ioreq_broadcast() to skip incrementing of "failed". Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 28 08:35:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 08:35:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448778.705333 (Exim 4.92) (envelope-from ) id 1ozZbn-0003sh-7z; Mon, 28 Nov 2022 08:35:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448778.705333; Mon, 28 Nov 2022 08:35:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozZbn-0003sa-5L; Mon, 28 Nov 2022 08:35:23 +0000 Received: by outflank-mailman (input) for mailman id 448778; Mon, 28 Nov 2022 08:35:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozZbl-0003sP-L0; Mon, 28 Nov 2022 08:35:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozZbl-0001hV-Ia; Mon, 28 Nov 2022 08:35:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozZbl-0001YD-1z; Mon, 28 Nov 2022 08:35:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozZbl-00065U-1W; Mon, 28 Nov 2022 08:35:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Btek8MZpSL3+v2U+ZCGt60jXvq+SvSnX5P17PneTlVs=; b=Npi+X+JqnZHDPTt7PqUs6OSVK6 h0pV1RlW2fUsFL0Ic8wv0u1zg1223T88Vr9cakwYb2TI2+pRem1JORHkVJkoz29AEBq1S4g6v1baX XTAdXkX21OZfzQQhpdNuQGdKoj0H4GoJOIoNr30XupFin44Ds3JGf8uv+Xa40szVmyso=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174975: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b7b275e60bcd5f89771e865a8239325f86d9927d X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Mon, 28 Nov 2022 08:35:21 +0000 flight 174975 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174975/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux b7b275e60bcd5f89771e865a8239325f86d9927d baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 51 days Failing since 173470 2022-10-08 06:21:34 Z 51 days 97 attempts Testing same since 174975 2022-11-27 23:39:38 Z 0 days 1 attempts ------------------------------------------------------------ 1906 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 181680 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Nov 28 09:00:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 09:00:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448791.705343 (Exim 4.92) (envelope-from ) id 1ozZzr-0007K7-9b; Mon, 28 Nov 2022 09:00:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448791.705343; Mon, 28 Nov 2022 09:00:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozZzr-0007K0-75; Mon, 28 Nov 2022 09:00:15 +0000 Received: by outflank-mailman (input) for mailman id 448791; Mon, 28 Nov 2022 09:00:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozZzp-0007Jq-Hw; Mon, 28 Nov 2022 09:00:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozZzp-0002IS-G5; Mon, 28 Nov 2022 09:00:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozZzp-0002HD-3y; Mon, 28 Nov 2022 09:00:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozZzp-000515-3V; Mon, 28 Nov 2022 09:00:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Rs9NC+fGl3ic2JsQrc3EKCYBWYWSCCJuzG9cuwuHpEc=; b=vP0RAgk9pE5Idgr2grTG90tslR 1vuzKtCMDIvPv+NB+q/TnDw1GWKRHzUPxT64PKy2446s9piLlcpeuhjU3aS247N0a8M1xyWI9LKcl BFxFkryrya0m4aEaCZ4ksXQXoW3sYRK6uvBNY3wjW79B1JGFN6Sv81NK0Uv+o/ttD1/w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174978: all pass - PUSHED X-Osstest-Versions-This: ovmf=85d805ed3201de16c4dcbfc4b886a0d11ad5885c X-Osstest-Versions-That: ovmf=6ae2b6648eb4b42b5a133f3cde567f9765467bf6 From: osstest service owner Date: Mon, 28 Nov 2022 09:00:13 +0000 flight 174978 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174978/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 85d805ed3201de16c4dcbfc4b886a0d11ad5885c baseline version: ovmf 6ae2b6648eb4b42b5a133f3cde567f9765467bf6 Last test of basis 174969 2022-11-26 15:13:18 Z 1 days Testing same since 174978 2022-11-28 07:12:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: VictorX Hsu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 6ae2b6648e..85d805ed32 85d805ed3201de16c4dcbfc4b886a0d11ad5885c -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Nov 28 09:02:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 09:02:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448800.705355 (Exim 4.92) (envelope-from ) id 1oza1v-0007wS-Rh; Mon, 28 Nov 2022 09:02:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448800.705355; Mon, 28 Nov 2022 09:02:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oza1v-0007wL-OL; Mon, 28 Nov 2022 09:02:23 +0000 Received: by outflank-mailman (input) for mailman id 448800; Mon, 28 Nov 2022 09:02:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oza1t-0007vJ-K5 for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 09:02:21 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2041.outbound.protection.outlook.com [40.107.13.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5cfcdb6b-6efb-11ed-8fd2-01056ac49cbb; Mon, 28 Nov 2022 10:02:19 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB8043.eurprd04.prod.outlook.com (2603:10a6:10:1e7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.21; Mon, 28 Nov 2022 09:01:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Mon, 28 Nov 2022 09:01:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5cfcdb6b-6efb-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=caIBJf+thrHVzjZIP2HXAYsyX8fMDXvbPP7EOgfU0qHUhVBGpENu0RPoUZSTupURSzPaZ6pEMkbbkTQJxk0zy7GM/VZYbUHcCpET5XyrYli73OGCrUSsZ/rJ7EIdwKOdoqUePzbmhpyN0PTic6ktq7gNkKupv4K+0gtpACdSdPJCPaocIwUXADNj0UFl5xKHcGRWD8BHWu6ur2s61fLwxKkqhB6s526GTFoHVf00ld6WEbQHOCSXFZx5FjMQ+TOtHJwgowRyOpshUuncJuvAGiYSS7vQTQ//YyC3+1SD36qtxODTTfQwLMu/vjNJwAcA3rs7m10uKw/uA2qvJC2C6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XfzsaMtroem9sNXWRAgAQe2QVEJEa1tD8rIN8Lj/yw0=; b=Uij3GX8Ug2A3jCvO3uCgUZoPpjkRjyIo/kIP1IQMjq41CUlRtgH07kY2fjR7MyxwpnT2YKcRO2fOziTeWX6JlD7xIhnqUX8yZzXblMd5KMdAzOVTTUcy/NhBr7Vp+gUCpjFDF7A7HAhTcYW+5Up/LyKa7sBk0q/pzF/arXFVoHrrC8lxUMg2irmdbQmcFItb7cPaSxM0v8vTfvpIRXp+wnmK5xHNu7chxZgAkKoP0D0QBEQ1bSB+Aaq3sNbFYJ93G/vk7SbKilLVZ8bAt6iv/l3LtE6KK+Px8PbwlA/mjn41kEIEdQXuaKdPa+wVVOEChAEWbVwgTpg6Z7APuGGLGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XfzsaMtroem9sNXWRAgAQe2QVEJEa1tD8rIN8Lj/yw0=; b=1ydCeGTbFwKU9GH8T6RKUl7Fouprh++CU46CxyXCtD7QyPUUsWpTOWW8bPWE2C2GmleSpBCUGtD+X7AVUK5+Qp8Wb0+Zb6gqnzp8sljrW+yyoaRGLt1UDYC/wJ7h2PPb5rxPM5Cpur13zsHC9bdOgIvRBrnvmdC15iKfUOGx3vxXLjS3bgjiV2o6d3CLlzI9szZg1Urwo7GP94fWfWMIKBJwL8RPQu8TzN2cVARq+VUnlz5rM/1cJDM2af64hqaPec4QXk1or6QI5X0pLDNbQBokAkJkbegemC9timtefaXQOqT9mpjowNs4Ui1gH805orbJKE25UAWOnn23bEfCbw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 28 Nov 2022 10:01:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH RFC 07/10] domain: map/unmap GADDR based shared guest areas Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <5a571fd9-b0c2-216e-a444-102397a22ca0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0102.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB8043:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ba39a24-c850-4e84-ee5e-08dad11f2f94 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V/jUrHJ51bP4vC5go5MXhWpZwsefB4Lhsrc/sv1eSgbr3Ri4V5kHqQ0b5MmdUaR7jvmwsCCM3hUmSj/gCJItCIUTk086yENFjErB2hBnG/iIzValjrdpzlKn/djxB3Uwmd9YdfGGAE0BhlGY2pBnil7J2bxZjjkasd6bEoL/oYYVgBFVf5Pq82oLOiWUnWIrR1yAoclUx38GnU7OfM4RtoHXJJctcgWCz5Lxl+81zEjW6ze/sAY7R7uJHXNCVbZkwlF4yokFIyAaoaXfpmrTQ2MrvgKtueoIvjEYi117kuzesgbmBtx8QlW+hN01ITgX5ZvxzouTAex/yz9obucPatXgxEec4MvBYmSYX3GpTb82zQlxVJ9epD6yh29aboHYLJVwM+zu1loPpCoGkXJpOkIuxK6omiwjbG0LEWq34Wwtg+iaJtY6ayo5iMZYoxOfKqHNk4zuBXbvyixW6uN/tnjv4ibwYWuiOuIAHASfxMlME4Xt/oVc4i6pPjmKnORrCXO23y9nq071Gqyh/D5XmFyyD94ffxpsYMHVC6dLNnzb9BGz3KLGhZ+a+vPnwQLF2yA+zYeBmjwpQVLE5Mlv3wn6KKdLPUSkLXJcgSeBrK9dUpd3QFItzuzJh6Z2CnVs60Mx7SX8uZYSS8Yi9eAIFcKQRqRh/78ZOyE88PLhSjwJdcB3Dv/GAaR/CTMwJ2RiRc5CGTwIBCGaQ61EeUUGLblTmYEv7QsKdc/2tbp6glQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(136003)(396003)(366004)(376002)(451199015)(31686004)(38100700002)(6486002)(6916009)(54906003)(316002)(478600001)(8936002)(41300700001)(2906002)(83380400001)(6512007)(26005)(86362001)(2616005)(36756003)(6506007)(66476007)(66556008)(53546011)(186003)(8676002)(31696002)(4326008)(5660300002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGFBRTVnN1lUSjRRSFJCbjZ6YW80aDNLdmJIalJBVXJFK1VLeVg3a3M0MDVV?= =?utf-8?B?dzhLNVIvK1podkdGeGQ0WGs2VFZXeitGeFQ0ekNNK0daZlpQdW5HdEVUUWZ6?= =?utf-8?B?bjV1eWVZeEZvRm1QSTZ2RWlPc1FNb1pndjd0NS9TTlVnRDhkTE16ZjFIWEl5?= =?utf-8?B?d2ZJWm9Eenk2UHF5ejZwZmJyd2JvdkI2VnU2eDF0WFVRbklSL09LaDJncExO?= =?utf-8?B?c1ROWk4xb1U3aDhjZTl6c2RjSnNEeHp2ckh4QVQ4TWlnR01GOFM1SXAyTnZo?= =?utf-8?B?TDFtVjZ5MktBWitWc3FDZnhJc1JvblVuRGUvbmJIQ0dBYUV6U0pVYmhzSHgw?= =?utf-8?B?NWU3S3F5OEN6bnVFb2pvdWt2bG9ud25HSW4vUHR6ZlplTTlRbzkwNGFuV2Ri?= =?utf-8?B?SUxia0xGZXZYeThpNkhVeDlhTmt4Zml0c1hGRmFrdEJYWkZUYXgxQ0srUlYw?= =?utf-8?B?YmxieFR0SUFHZ2RhN0F3eitkSVpaOVdMdWhQU3JWeUFhUHlsY3IrTStnOUkw?= =?utf-8?B?M3ZxK2ZDWDhyWjc1UHJ3M0JXYWR5bU9mRWZDQjg3NnljZytGZ2lNM3RiSTVl?= =?utf-8?B?aG50d291d1NTWTNETUhMQmpKNkdhMnNqUWR1bE1CNkwrYUdFN29QVUxqVWtz?= =?utf-8?B?SXFSeWxPTzFiUjByNktHck4zV2FmQnZjdTBESGhHbXgrUnhXVXdzR0d0SmdB?= =?utf-8?B?eFNxNVFQeCthU2NyYmhRVnZoM3JEcXhGdFIwMzRVUFAxak9VRElnSVR6WTEy?= =?utf-8?B?azVVMGZIZDk0bSs0cUNWbGVBdUcvSHZoRW9UMTRPNFBHY0RzeVVES01LaStE?= =?utf-8?B?bndVc0VxMXhZT1l4QUxIMGJMemNlaytkVE80Z3hacldNS0dzVzRxMDZPVXFk?= =?utf-8?B?czU2cjRzR3dySXNyYytJOSt0ejN3dkxYRGZlY1Q5WDR0ZmxNTGxNaURBSEZl?= =?utf-8?B?eHFtUWR6YkFxVS9DajdZRXFXdERBc2hySys5VTY2emxTakJZSS9WTzNlbzg2?= =?utf-8?B?a0s1TDlHbTc1VnNvL0RRczhjUVloSmFjTmJOdERSRXZkazRXOEhJcHIrMmlN?= =?utf-8?B?RGM4NmtGSlpKM1cyY252UlBWOFJMMFhlamxWQlZka2QvajV0SGNobi9IVm9h?= =?utf-8?B?dEpsUG9rZms1Q1R5cmRydW5WeWJlWXgyRnd0MTVFdjRFMGprdDA5eEhaS21P?= =?utf-8?B?SGZseVF4NEg4MURjWVNHajI5ZzlmbWNWTjIrcS9IaG05ZVZoZXU3MDJKeGtD?= =?utf-8?B?UUwrMTFiN3BOeWhKUnVXb01IQmd1bWFxOVRYV1gzWENEOXg5QURCaFVQVWdM?= =?utf-8?B?RWFONjd4YTFOaFV6Y2tuZWNRMm1obFVaQ3RIRTIybUFlMTJwUmF2K29qbmlu?= =?utf-8?B?RGJ6dGJOb2lVbld2MUpBYlMyZzdPQ0NybmtIY1NFYWNSSWRXd2hWUEMwOVUx?= =?utf-8?B?Vy9wR3N3VmFqOTRwVGdpUjZLY3FTdkZNY1RLc09UNFdzN2s2K0tSbzYzeHNw?= =?utf-8?B?aC9Zc0JLZjlJWEZxcWIvYjZFMnpCUVJiSU1Wb3ZSakJzUnN0dHhCdGF2Y2Ev?= =?utf-8?B?T2RZYVozOG51ZzdxU2FwZUUwajN6b1p6a0Z4ZW9EcG0rVnIrLy9aNnZIVnJU?= =?utf-8?B?NU9vNlFkYzZ1MFppYm1EM0Z3VUs3R085bi9hSDFVVjVsN2JxY281eHRzbDJn?= =?utf-8?B?bTFvbTRKcmhYQi9objMrcGRlZHdaRXY4d1p1OXdpdFVHVGUwS1ZobHRkNFdE?= =?utf-8?B?SVlSdE9iRlJZeHliOEVtTkppT094a1JZTUx0bTBhYzJXMzc3bU92bVE4RHRj?= =?utf-8?B?OU83U1R5b1pmbGxrSkNhbElDNyt4aXVZTGJPSzBQbUQveW4zUlArazI5Rk1M?= =?utf-8?B?dVNab3JvTEloYW0wRGU5L2Y4N21qVGxSVGxxS25jNFNrcnVsU1hnVUhvaXhz?= =?utf-8?B?N2oxMjA1UVBJRENRRTBWZFF5dmd2M2NOczNZb0l6YjNDNC9UelhjaWgyWnYz?= =?utf-8?B?RlBkWnVkY3RQclY0YUd3N3ZkTmM5V1lmVnhITVR1QUl4Tmt6WmZSNmZGcWFz?= =?utf-8?B?T21vYjZMNlprUzJlMmpiTlVGeEFOZm8xRWpFT0Z3UTNod3dVMnloOExBM1dz?= =?utf-8?Q?eJFhdSceVxSseHx8BerZp7bHV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ba39a24-c850-4e84-ee5e-08dad11f2f94 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 09:01:50.0233 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WkQMq4Ad7bc25vVrlB24tlOZM5N5A8a89QID6imqcbfwmR5hvm9+XsnM2hEE5dnLaXapQFnyYtv2RoVLWyxcmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8043 On 24.11.2022 22:29, Julien Grall wrote: > On 19/10/2022 09:43, Jan Beulich wrote: >> --- a/xen/common/domain.c >> +++ b/xen/common/domain.c >> @@ -1563,7 +1563,82 @@ int map_guest_area(struct vcpu *v, paddr >> struct guest_area *area, >> void (*populate)(void *dst, struct vcpu *v)) >> { >> - return -EOPNOTSUPP; >> + struct domain *currd = v->domain; >> + void *map = NULL; >> + struct page_info *pg = NULL; >> + int rc = 0; >> + >> + if ( gaddr ) > > 0 is technically a valid (guest) physical address on Arm. I guess it is everywhere; it certainly also is on x86. While perhaps a little unfortunate in ordering, the public header changes coming only in the following patches was the best way I could think of to split this work into reasonable size pieces. There the special meaning of 0 is clearly documented. And I don't really see it as a meaningful limitation to not allow guests to register such areas at address zero. >> + { >> + unsigned long gfn = PFN_DOWN(gaddr); > > This could be gfn_t for adding some type safety. Indeed I did consider doing so, but the resulting code would imo be less legible. But this difference perhaps isn't significant enough for me to object to changing, in case you (or others) think the type safety is really a meaningful gain here. >> + unsigned int align; >> + p2m_type_t p2mt; >> + >> + if ( gfn != PFN_DOWN(gaddr + size - 1) ) >> + return -ENXIO; >> + >> +#ifdef CONFIG_COMPAT >> + if ( has_32bit_shinfo(currd) ) >> + align = alignof(compat_ulong_t); >> + else >> +#endif >> + align = alignof(xen_ulong_t); >> + if ( gaddr & (align - 1) ) >> + return -ENXIO; >> + >> + rc = check_get_page_from_gfn(currd, _gfn(gfn), false, &p2mt, &pg); >> + if ( rc ) >> + return rc; >> + >> + if ( !get_page_type(pg, PGT_writable_page) ) >> + { >> + put_page(pg); >> + return -EACCES; >> + } >> + >> + map = __map_domain_page_global(pg); >> + if ( !map ) >> + { >> + put_page_and_type(pg); >> + return -ENOMEM; >> + } >> + map += PAGE_OFFSET(gaddr); >> + } >> + >> + if ( v != current ) >> + { >> + if ( !spin_trylock(&currd->hypercall_deadlock_mutex) ) >> + { >> + rc = -ERESTART; >> + goto unmap; >> + } >> + >> + vcpu_pause(v); > > AFAIU, the goal of vcpu_pause() here is to guarantee that the "area" > will not be touched by another pCPU. Hmm, I find the way you put it a little confusing, but yes. I'd express it as "The purpose of the vcpu_pause() is to guarantee that the vCPU in question won't use its own area while the location thereof is being updated." This includes updates by Xen as well as guest side consumption of the data (with focus on the former, yes). > However, looking at the function context_switch() we have: > > sched_context_switched(prev, next); > _update_runstate_area(); With this really being _update_runstate_area(next); ... > The first function will set v->is_running to false (see > vcpu_context_saved()). So I think the "area" could be touched even afte > vcpu_pause() is returned. > > Therefore, I think we will need _update_runstate_area() (or > update_runstate_area()) to be called first. ... I don't see a need for adjustment. The corresponding _update_runstate_area(prev); sits quite a bit earlier in context_switch(). (Arm code is quite a bit different, but this particular aspect looks to apply there as well.) >> @@ -1573,6 +1648,22 @@ int map_guest_area(struct vcpu *v, paddr >> */ >> void unmap_guest_area(struct vcpu *v, struct guest_area *area) >> { >> + struct domain *d = v->domain; >> + void *map; >> + struct page_info *pg; > > AFAIU, the assumption is the vCPU should be paused here. Yes, as the comment ahead of the function (introduced by an earlier patch) says. > Should we add an ASSERT()? I was going from unmap_vcpu_info(), which had the same requirement, while also only recording it by way of a comment. I certainly could add an ASSERT(), but besides this being questionable as to the rules set forth in ./CODING_STYLE I also view assertions of "paused" state as being of limited use - the entity in question may become unpaused on the clock cycle after the check was done. (But yes, such are no different from e.g. the fair number of spin_is_locked() checks we have scattered around, which don't really provide guarantees either.) Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 28 09:16:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 09:16:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448818.705366 (Exim 4.92) (envelope-from ) id 1ozaFn-0001Gn-Ut; Mon, 28 Nov 2022 09:16:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448818.705366; Mon, 28 Nov 2022 09:16:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozaFn-0001Gg-Rz; Mon, 28 Nov 2022 09:16:43 +0000 Received: by outflank-mailman (input) for mailman id 448818; Mon, 28 Nov 2022 09:16:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozaFm-0001GW-4h; Mon, 28 Nov 2022 09:16:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozaFm-0002j2-27; Mon, 28 Nov 2022 09:16:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozaFl-0002fv-EB; Mon, 28 Nov 2022 09:16:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozaFl-0001zT-Dg; Mon, 28 Nov 2022 09:16:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ohUco2ASSAksgGd8brb2/LtfTOopZU3aO5IcA4v22Vs=; b=JvXXy71Mbtc76U3X7O+KyPVGKf +2smcYVVRA0mN6bBTh0g7TBuwRUzZ1mHe4fBbfc6CvWmvZOICYWuGAkw7fxOdAIJE8uv+DMw7We+Z jlEDPyPdhYPWYxMWhI6NFDsaEgEbUFrb/kzwu0N1FzN0ncF6857WKWaVJ2FB1acWGncg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174976: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=ac149498215809bfb5c0ddce1953519fbfda5004 X-Osstest-Versions-That: qemuu=c23a95636622a32352b55a2f164a1fdf4ed34f60 From: osstest service owner Date: Mon, 28 Nov 2022 09:16:41 +0000 flight 174976 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174976/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174963 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174963 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174963 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174963 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174963 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174963 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174963 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174963 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu ac149498215809bfb5c0ddce1953519fbfda5004 baseline version: qemuu c23a95636622a32352b55a2f164a1fdf4ed34f60 Last test of basis 174963 2022-11-25 21:08:44 Z 2 days Testing same since 174976 2022-11-28 01:08:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Laurent Vivier Stefan Hajnoczi Stefan Weil Stefan Weil via jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git c23a956366..ac14949821 ac149498215809bfb5c0ddce1953519fbfda5004 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Mon Nov 28 09:21:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 09:21:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448828.705378 (Exim 4.92) (envelope-from ) id 1ozaK6-0002pR-Kp; Mon, 28 Nov 2022 09:21:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448828.705378; Mon, 28 Nov 2022 09:21:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozaK6-0002pK-GU; Mon, 28 Nov 2022 09:21:10 +0000 Received: by outflank-mailman (input) for mailman id 448828; Mon, 28 Nov 2022 09:21:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozaK5-0002pE-63 for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 09:21:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozaK4-0002nv-PY; Mon, 28 Nov 2022 09:21:08 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ozaK4-0002lB-In; Mon, 28 Nov 2022 09:21:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=3ww8fGtytXPmltC7cOiENBggor30iFa/jfrKd95/wD8=; b=Tpu60dp6fGYa7CqHmH+fyr1vsE s0/qL0aKDIwOs1cLqPJb+KughH6oSD0n+iy5nUD3xNpz9eUDrExZw2BaBjTBZck+S01TgWRO8301A bnFO8Ic7nk28btNJPJeDbYU2qQUiXFgW5JMT4Ia7J8Fme4V5hrrDF/Bjkn/v+LuQ2wNU=; Message-ID: Date: Mon, 28 Nov 2022 10:21:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN v3 02/12] xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32 To: Ayan Kumar Halder , Michal Orzel , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, jgrall@amazon.com, burzalodowa@gmail.com References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-3-ayan.kumar.halder@amd.com> <8086e3ac-445b-17a1-bba3-078024ab2579@amd.com> <382e5e7d-5bb3-7d7f-913f-842407d9414b@amd.com> Content-Language: en-US From: Julien Grall In-Reply-To: <382e5e7d-5bb3-7d7f-913f-842407d9414b@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27/11/2022 14:32, Ayan Kumar Halder wrote: > > On 17/11/2022 13:39, Michal Orzel wrote: >> Hi Ayan, > Hi Michal, >> >> On 11/11/2022 15:17, Ayan Kumar Halder wrote: >>> Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169 >>> Affinity level 3 is not present in AArch32. >>> Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106, >>> Affinity level 3 is not present in Armv7 (ie arm32). >>> Thus, any access to affinity level 3 needs to be guarded within >>> "ifdef CONFIG_ARM_64". >>> >>> Signed-off-by: Ayan Kumar Halder >> Reviewed-by: Michal Orzel >> >> although, IMO the commit msg does not reflect the change (i.e. you do >> nothing >> related to accessing MPIDR, but instead you are just not taking the >> Aff3 into account for AArch32). >> Also, I'm not sure why you used VMPIDR and not MPIDR. > > Actually MPIDR in EL2 is known as VMPIDR. So I used this name. Quoting the Arm Arm: The VMPIDR, holds the value of the Virtualization Multiprocessor ID. This is the value returned by Non-secure EL1 reads of MPIDR. The code you are touching is looking a the pCPU information. Therefore, the correct name of the register is MPIDR. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 28 09:31:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 09:31:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448834.705387 (Exim 4.92) (envelope-from ) id 1ozaTy-0004OD-HU; Mon, 28 Nov 2022 09:31:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448834.705387; Mon, 28 Nov 2022 09:31:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozaTy-0004O6-Da; Mon, 28 Nov 2022 09:31:22 +0000 Received: by outflank-mailman (input) for mailman id 448834; Mon, 28 Nov 2022 09:31:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozaTx-0004O0-Gv for xen-devel@lists.xen.org; Mon, 28 Nov 2022 09:31:21 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 68cfd881-6eff-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 10:31:20 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozaTs-0002yr-Ap; Mon, 28 Nov 2022 09:31:16 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.95.125.41]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ozaTs-0003Bw-1t; Mon, 28 Nov 2022 09:31:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68cfd881-6eff-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=IGDiv+c+ACuI3R0Wyevr4mlLXEorQrRhTV1QEf/bils=; b=JR+vHUo985mOVrZovUmoColc7t UiPpK1eHiMRHPqMp/ZonrB9QJp3utiot6OoumhDNEot42NI5ntetPRaM/alm0ehNBMcX83Eifgokd 5oDURGFBbkxuV9bv40lLtRwTat+TabwglL5f4gUcHDlO6JUoTdyzjWjGHBip+EuIPDQE=; Message-ID: Date: Mon, 28 Nov 2022 09:31:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH V6.1 3/3] libxl: arm: make creation of iommu node independent of disk device Content-Language: en-US To: Viresh Kumar Cc: Anthony PERARD , xen-devel@lists.xen.org, Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross References: <099616e1092409fceea4eb30590215310f8c091c.1662626550.git.viresh.kumar@linaro.org> <20220920102915.p55lt4ee5hbxiun2@vireshk-i7> <4bb29058-3133-bc66-ea33-8077f91a473b@xen.org> <20221125054522.wjsv3lcb5tdk2dd5@vireshk-i7> From: Julien Grall In-Reply-To: <20221125054522.wjsv3lcb5tdk2dd5@vireshk-i7> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Viresh, On 25/11/2022 06:45, Viresh Kumar wrote: > On 24-11-22, 20:19, Julien Grall wrote: >> Unfortunately, we had some delay for releasing 4.17. So I have pushed this >> series in a branch for-next/4.18. > > Thanks. > >> This will be applied to staging once the >> tree has re-opened. > > I don't see the branch here though. Is it not public yet ? Or should I be > looking at a different tree ? The branch has been created in my personal tree for now: https://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=shortlog;h=refs/heads/for-next/4.18 Sorry I should have been clearer. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Nov 28 09:56:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 09:56:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448844.705398 (Exim 4.92) (envelope-from ) id 1ozasJ-000725-Dp; Mon, 28 Nov 2022 09:56:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448844.705398; Mon, 28 Nov 2022 09:56:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozasJ-00071y-B7; Mon, 28 Nov 2022 09:56:31 +0000 Received: by outflank-mailman (input) for mailman id 448844; Mon, 28 Nov 2022 09:56:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozasI-00071s-Hq for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 09:56:30 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062c.outbound.protection.outlook.com [2a01:111:f400:fe5a::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ecb263b1-6f02-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 10:56:28 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by PH8PR12MB6964.namprd12.prod.outlook.com (2603:10b6:510:1bf::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 09:56:23 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57%4]) with mapi id 15.20.5857.023; Mon, 28 Nov 2022 09:56:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecb263b1-6f02-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VHWLs3rUpJkfBZeiMUes2lqx9yriFePJib+jjAlFKUC31Hzh6egUNI5DlO8WwsS8FLOUvuRA5hQHpMdf2i4zVUrajubEUZIOFfCJSBhd9uV0BVRoc8P87zzbhZylVnO5jVgER1/r8+6Ql/RgE83FZz/HU1ao8R62oioPrp98Sgw3pV61oQ4NCoEA7q4OIDC8jQoTp9NivBzAuI9anlErD0ReLIqpoIm3k9kV8khES5Q7g5MXrGas+3pJ0N0YgvjIaN0qvWc7mjhjwd/FNxPQgq5oOZunDyIQlz21zaORgGxPITQzIV+jMvp1LXi+SZZin61X+t6guefGs+yiusyBAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WsZNMND5Nl7inyH0pKOhR0yFnlOgfOG790G2NUvqmPI=; b=cdpQ9onCN51z83ydq+zYtTkKHSr61GYxII0gn+3Oz1kfdzB/Z6Q/k6+OPP6eFESHsDFvTe8wvrN90T/aMbXNDlryRlnfZ2rSAem6ZmSIFL6TXsJc4B16XNknOpRTGpbIhTkwb2EYyE11ZFPSMgUS1YIxz22asFx2Pr4BfLeId4GEUdAjMlJMnKgSJvY/btYI6BkjcYcK8r7jBq23TmhL21e41iDc9OxmCSd2v40jcEKdaJ1Zpwtv1JaZ5G93AldDeopZQUAnVnIAu8YBz/mBp330nvKJM18u+xtru5gzJDflmng/kc1110QVxeGhiNEjLRDGO8E1Stqd9D1+Mw5b5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WsZNMND5Nl7inyH0pKOhR0yFnlOgfOG790G2NUvqmPI=; b=xpTW/bGZqL3DjBIgpFDFvtXWeAtDH14zE7Fvdp5e3GiEvxcX2SDgU5xgxoNezIwKWS2RqNmxiXt4Hq8PuMsuLUdWWSW5oIIQLlhpXhi9nTadfAIAEVGfFOYZUeY1LhyH5TbHOGDz7NobsfWyG8OapPEc0ap/wsoV62Yxu+ITZs0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Mon, 28 Nov 2022 09:56:15 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN v3 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32 To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com, jgrall@amazon.com, burzalodowa@gmail.com References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-5-ayan.kumar.halder@amd.com> <52e12805-169b-0ffe-ab7c-192d31320194@xen.org> From: Ayan Kumar Halder In-Reply-To: <52e12805-169b-0ffe-ab7c-192d31320194@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0448.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::28) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|PH8PR12MB6964:EE_ X-MS-Office365-Filtering-Correlation-Id: 3359be25-a648-47c5-5ad8-08dad126cd11 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rtWPf5BHZABboe/Q1Qubk4vcG54ABsgfIhDJyaXkBc3L2/P7DlC2ACeIviAFyQDSIUcdjW9tIOvS1nHL98t4HHDxXJ+WlW8SeY2yZzI6mlDxa+6rj7Zd+M/zEzl7x3Z5HLYQTG48A21OwTuyPQqMcC91WofE8t0cmsvyb9OBHNaHQM8q1x6lYu1ZDu8MeI1Z6F4zduX/5JwAqZY1KqPceJZ220aiPk1icA5oJg4HBjpfZd96QnWdyx2emIHQPnHvHXdEHwiAl+eugqv+p3N7LXqlE82thFPztTj5T/xDlZsrDxqAYgpuGLZdKPx+4uqWXi9VAEnomvcY0KqHd5k2sUBM56Tlll/467I1BXN+CgePhk6XVv2J/rn9+BORwdOzojaxuf3c7CRD3Qh81kfinWSZrNRZWm4Sx5tLYyXn6b9C+1MSDfy3VJ5kj46huSBUjim8lFwN0KycBqzK601mQCLcxyAYnh02ebAzPa4HiV3laUnDrgbrlw4ugXpOU/S//kDLTAYAh/nIrNBSmCpcvXhce+KeDvpoxf3/V25/z9UX9aS+jS1/clWcsWPcvIHXrZYX5/CSs/c7uBQpC1zfntUcon95AHylq43LWMKlXHoXg44QjD9uUz0spoC/gKoB6tN8gFRveC9Uhu7kiubsZYChdOgvmGfZo7E4E3qQa7D2lyukFAmuAwytnk5rbrRg2v/7aKtb2o1H3AiecNLgDRedmqQfMrwXwu+4xa6+nyk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(39860400002)(376002)(346002)(396003)(451199015)(5660300002)(6666004)(38100700002)(110136005)(6512007)(26005)(186003)(316002)(8936002)(36756003)(6506007)(4326008)(66556008)(66946007)(8676002)(66476007)(31696002)(2616005)(41300700001)(478600001)(31686004)(53546011)(6486002)(83380400001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0VPY0F2Rk4yVnJmNm5MTzlvWWdPd0VjZWlmY0tmZzlaVUM1NW00R3VOMDZK?= =?utf-8?B?VG9DNmRZcGRlNEczeTh0QUJSVldNSWRMVThXMldsSnUxYk0zaUFUcjIyVFdi?= =?utf-8?B?OUlsbUVQSW5oTUY3WklYNEtCSWN3K1FQSTJHYXFBTzd2Mm8rNW9rQmlFSU1r?= =?utf-8?B?STcwWGpzSVhNcmYrQWZWazNvVDJoQWQrYjVtc3NFeXFCNW01ZWZFb3BGa2Nl?= =?utf-8?B?MmFXQklleXlRaVdLWFJyQmwxZk9hMGVQRU82TkVMYXZKNFlxbTl4ZW1wV2Zu?= =?utf-8?B?R21jUHNiUE9RQ05FcEVXK2gzOU1qVWRqS25kWGxCZ2lFMGUrVlRVOTg5NDNS?= =?utf-8?B?ajVnL2l4VHRoVERsTGJwSFN5VjR4VXVvenBOTUdibnp1cVNVVm14WFRnNFNw?= =?utf-8?B?SnpuMEttcnM5dzdnekdwU1ZrYm5WcWxNem4zNHc1R1hIVXYrOC91WkM1dkh0?= =?utf-8?B?Z2t1V1FVRWJFM2RjdDdiMVVUbXh1ZlhPcE5RcGtGcFRkUmNlamlyR0M0WU5z?= =?utf-8?B?NGRjZlhGRk5XNFNZYmhCaXVUbS9hWFdJQVRremZZZFFzeVlIR3VBeUp5ck9G?= =?utf-8?B?ak9QVGRiS0tOSTVDOE0rU1VkRlVicjF6VExualQrbUJtRmNYdVE4cHFZNmxu?= =?utf-8?B?ZWRtYkpxNTgyK3N0ck9RbnZBbEkyWEVsZDQyMjczd1dtN0kzeGNWLzZQMTB3?= =?utf-8?B?SW5IaDlFVEt3UzUzYyt5UDJueG1yVFZYQi9QQkFCUWNybmVMeExpWk04ZVE3?= =?utf-8?B?NjdWNWEwNHFQK3ZVYlgwRU95WWs1L1NPaEFBa29ZL2Nlbll2TWs5L0FZSW0y?= =?utf-8?B?R0N3WTJ1RVBZQWhJRkd3cTZiNEJLMnhxRU55Y3FKeUloVCtDZGEvazNtS0Q0?= =?utf-8?B?TFZyWWNDazBCdnRnOEFmblJoNXJ2b3VTNVFZd3JJMlRyT2wrOW9rVFR0MFRu?= =?utf-8?B?YTYyZEhJaDhWMGgxWEp2aVd0VjA0R3FEaTArc3ZQZVlUbU5sMVJRSnFYaWI2?= =?utf-8?B?cG85a3ZSR0d6WHpKc0VPN21jQmRZMmdiWGJmcGNtdDhWcExIWXNlWEtvQWps?= =?utf-8?B?K25NN0tORHFzZWtuWEtQV0JVNXJjaEtSVVd3dkI3ZGZSZ3Q4MmxBc0ZNRm80?= =?utf-8?B?aE1JUzBPWjliUHRUSWxJWHVYRzZ6SDFmU01QQUt0UDVVOG5oNzlMY09NSTkr?= =?utf-8?B?cVVxUTEyUGJMTDE3ZmVCWlI5T0JUV1laNjI5dDBFc3kzSGEyWXJZWUREZVZX?= =?utf-8?B?aGtHY21uTUxJNzRDTjFIeHcxRzlWbVI0anJiMzJKczhlSnpETWYzd21yNTN4?= =?utf-8?B?RTBjTWk4UDh3cnpyRzdIZUhZY092OTJyMzVmT2h2OFhNemtuTTFXMnNUdjkv?= =?utf-8?B?c3BYZ24zRnJhaEdVaEhEdVhOa2JBRnJFRlFDci9oVjNJN05SWlpHYW1YbnNC?= =?utf-8?B?TFB1UDNMUUxkV0NsZDVHeGVJV1BXRVZXWm5tOW9aenpnTS9naDJtMW1Ed2tv?= =?utf-8?B?RTlzT2k0UW45Q3BvSG5uTDRxVnJ2U3RZZVd4SjQ0cVVETG5MSHRiOUtDdWZS?= =?utf-8?B?dGdzUjJqODUvVGVGYVpEUUZWdW02blo0ZEdjdlpCUndSOElyQ0E4TjhCLzNq?= =?utf-8?B?Wngrazd4Y05lRTdweVVJczRZWVBDN0NRb2xMcnAzMG1tN0ZwYlJ0aGlrZitY?= =?utf-8?B?dEdIRTFpZEtBV0IrSXZwWjUyMEJUZEMrZjJ0M1BFK3BmQXhvUjRnakllVktI?= =?utf-8?B?M3Noa0cwWW1wN0FLbTEyVEk2QU5CYU5wU1R2Ym5GaHRCNXI5Z2RMSEt5cTly?= =?utf-8?B?WlRENFl4RmZzNkUzbzU4WDNDVzNORVVpa2VVQmQvVlFLRG0wN1B5d0R2U2lO?= =?utf-8?B?aGxDbGJrbDR6WVVEa1YvZEp0dldOMFQweGNxalhwWjlYcXdVc0M1Y0hvM2Yx?= =?utf-8?B?bXZKWGh0YWJGZHE5TlVwamNwQWJTVlBDQy9KeXdnR3AwT0ZvTjBnWGNuVDhM?= =?utf-8?B?TnEyaUZMSVAyQkY5SjdHQURTazgxcTZ0YUVlSTQ3My9TUVFhUG1PVXJrdk92?= =?utf-8?B?UEtKQ3BYUm1nRE5jTXRBN2E2TWduU0dWNVlHRG5xS05QdDBuSmNTOXVsQWdD?= =?utf-8?Q?2KsyWvOo9EF4fk6Y+HkYHR4XK?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3359be25-a648-47c5-5ad8-08dad126cd11 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 09:56:20.7962 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bmsVtZ7JNS4Wh+zuwKjBj1FTuD35u1rvqTp3rivtyGUyxov68wVEblv2kq153KjFadoxZ/LDCidKqZFEhr9oTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6964 On 22/11/2022 20:37, Julien Grall wrote: > Hi Ayan, Hi Julien, I need a clarification. > > On 11/11/2022 14:17, Ayan Kumar Halder wrote: >> Refer ARM DDI 0487I.a ID081822, G8-9650, G8.2.113 >> Aff3 does not exist on AArch32. >> Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106 >> Aff3 does not exist on Armv7 (ie arm32). >> >> Thus, access to aff3 have been contained within "#ifdef CONFIG_ARM_64". >> Also, v->arch.vmpidr is a 32 bit register on AArch32. So, we have >> copied it to >> 'uint64_t vmpidr' to perform the shifts. >> >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changes from :- >> v1 - Assigned v->arch.vmpidr to "uint64_t vmpdir". Then, we can use >> MPIDR_AFFINITY_LEVEL macros to extract the affinity value. >> >> v2 - 1. "MPIDR_AFFINITY_LEVEL(vmpidr, 3)" is contained within >> "#ifdef CONFIG_ARM_64". >> 2. Updated commit message. >> >>   xen/arch/arm/vgic-v3.c | 12 ++++++++---- >>   1 file changed, 8 insertions(+), 4 deletions(-) >> >> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c >> index 3f4509dcd3..a7a935ff57 100644 >> --- a/xen/arch/arm/vgic-v3.c >> +++ b/xen/arch/arm/vgic-v3.c >> @@ -191,12 +191,16 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct >> vcpu *v, mmio_info_t *info, >>       case VREG64(GICR_TYPER): >>       { >>           uint64_t typer, aff; >> +        uint64_t vmpidr = v->arch.vmpidr; > > The type-widening here deserve an in-code comment. Otherwise, it would > be easier for someone to decide to open-code v->arch.vmpidr again. Does this comment look fine ?         /*          * This is to enable shifts greater than 32 bits which would have          * otherwise caused overflow (as v->arch.vmpidr is 32 bit on AArch32).          */         uint64_t vmpidr = v->arch.vmpidr; - Ayan > >>             if ( !vgic_reg64_check_access(dabt) ) goto bad_width; >> -        aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 | >> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 | >> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 | >> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32); >> +        aff = ( >> +#ifdef CONFIG_ARM_64 >> +               MPIDR_AFFINITY_LEVEL(vmpidr, 3) << 56 | >> +#endif >> +               MPIDR_AFFINITY_LEVEL(vmpidr, 2) << 48 | >> +               MPIDR_AFFINITY_LEVEL(vmpidr, 1) << 40 | >> +               MPIDR_AFFINITY_LEVEL(vmpidr, 0) << 32); >>           typer = aff; >>           /* We use the VCPU ID as the redistributor ID in bits[23:8] */ >>           typer |= v->vcpu_id << GICR_TYPER_PROC_NUM_SHIFT; > > Cheers, > From xen-devel-bounces@lists.xenproject.org Mon Nov 28 09:57:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 09:57:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448846.705410 (Exim 4.92) (envelope-from ) id 1ozasm-0007St-Mh; Mon, 28 Nov 2022 09:57:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448846.705410; Mon, 28 Nov 2022 09:57:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozasm-0007Sm-Jj; Mon, 28 Nov 2022 09:57:00 +0000 Received: by outflank-mailman (input) for mailman id 448846; Mon, 28 Nov 2022 09:56:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozasl-0007SN-Ag; Mon, 28 Nov 2022 09:56:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozasl-0003XX-6b; Mon, 28 Nov 2022 09:56:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozask-0004SV-Jr; Mon, 28 Nov 2022 09:56:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozask-0005ur-JI; Mon, 28 Nov 2022 09:56:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=w7Z38oFKK6LGbDyQPnzdpGeHH30Aj1xMW7omgTi2XR4=; b=dRVjzkyH3wZVA+PxeS4KFKsxtu dE/3SFEkir57guECL9DUYE+K+yQTiWajdi263KwZ8hDqJZnhiyEDmW3AtfSToQAVVOfk6BH1OoaJD NOkPvBcC8a/XRdtQAytm9zwTMn0+ADUCLRzxES4shcFVbQ3MSYycZMJ8thbbroK5y8lk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174977: trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-amd64-dom0pvh-xl-intel::broken:regression xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:host-install(5):broken:heisenbug xen-unstable:test-amd64-i386-examine:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=345135942bf9632eba1409ba432cfcae3b7649c7 X-Osstest-Versions-That: xen=345135942bf9632eba1409ba432cfcae3b7649c7 From: osstest service owner Date: Mon, 28 Nov 2022 09:56:58 +0000 flight 174977 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174977/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-intel broken Tests which are failing intermittently (not blocking): test-amd64-amd64-dom0pvh-xl-intel 5 host-install(5) broken pass in 174972 test-amd64-i386-examine 6 xen-install fail pass in 174972 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 174972 like 174944 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail like 174958 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail like 174958 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174972 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174972 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174972 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174972 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174972 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174972 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174972 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174972 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174972 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174972 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174972 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174972 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 345135942bf9632eba1409ba432cfcae3b7649c7 baseline version: xen 345135942bf9632eba1409ba432cfcae3b7649c7 Last test of basis 174977 2022-11-28 01:52:23 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel broken test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-dom0pvh-xl-intel broken broken-step test-amd64-amd64-dom0pvh-xl-intel host-install(5) Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Nov 28 10:17:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 10:17:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448862.705421 (Exim 4.92) (envelope-from ) id 1ozbCV-0001sh-Df; Mon, 28 Nov 2022 10:17:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448862.705421; Mon, 28 Nov 2022 10:17:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozbCV-0001sa-AO; Mon, 28 Nov 2022 10:17:23 +0000 Received: by outflank-mailman (input) for mailman id 448862; Mon, 28 Nov 2022 10:17:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozbCU-0001sT-1C for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 10:17:22 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d64ec2f5-6f05-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 11:17:19 +0100 (CET) Received: from mail-bn8nam04lp2047.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Nov 2022 05:16:59 -0500 Received: from BN6PR03MB3378.namprd03.prod.outlook.com (2603:10b6:405:42::30) by PH0PR03MB5862.namprd03.prod.outlook.com (2603:10b6:510:42::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 10:16:57 +0000 Received: from BN6PR03MB3378.namprd03.prod.outlook.com ([fe80::b136:4ba1:712f:cec4]) by BN6PR03MB3378.namprd03.prod.outlook.com ([fe80::b136:4ba1:712f:cec4%5]) with mapi id 15.20.5857.019; Mon, 28 Nov 2022 10:16:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d64ec2f5-6f05-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669630640; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=XI9KoTAeUO1ke64jAv3W7cYMqIp6oRzu/NVY/wNK59c=; b=BtisyCoYIR4agSYpunNS0am/1BhP6EyqPYXLkEZ2eeL+f0/AlGjNPnE2 D0QoT6rj1Qr8maIcwStd+sg1iS82UP7Y0bQV+FmMlPMDepmbWvZaWJ8gQ qCGA2Xn3chJdtNrm13KSe+3aTYxvlAFaCqhzUkHiTTP4Q6N1l+qSykX5Y g=; X-IronPort-RemoteIP: 104.47.74.47 X-IronPort-MID: 85229605 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:RiKYzKD/OmpxaBVW/xPiw5YqxClBgxIJ4kV8jS/XYbTApGx01DAGy zRKUWqOOqzeZzT2edklbYjl8B8EscKDx9ViQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpC7gRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw9+lJM1xUz +YjLRNKX1O7hNy08OnrY7w57igjBJGD0II3nFhFlW2cJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK+exrvAA/zyQouFTpGOLYYJqgRMFOk26Tp 37c/nS/CRYfXDCa4WrYqCj92LeS9c/9cNsdDq/hqtFnvHiS+0xJVC0wZGG6iubs3yZSXPoac ST44BEGr6I/6UiqRdnVRACjrTiPuRt0c8JZDukS+AyLjK3O7G6xGWwsXjNHLts8u6ceRyEu1 1KPt8PkA3poqrL9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5e/LWdi9T0HXT6x WCMpS1m27EL15ZXiOO84EzNhC+qqt7RVAkp6w7LX2WjqARkeIqiYI/u4l/ehRpdELukopC6l CBss6CjAComV/lhSATlrD0xIYyU IronPort-HdrOrdr: A9a23:yz5846/FjwxXE4kBVq9uk+Hpdr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFq7X5To3SJjUO31HYYb2KjLGSiAEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpodKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirCWekD+y77b+Mh6AmjMTSSlGz7sO+X XM11WR3NTsj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhn8lwqyY4xlerua+BQ4uvum5loGmM TF5z0gI8NwwXXMeXzdm2qj5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe J29lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQBo+dY7bWDHAbIcYa 1T5fLnlbFrmJShHjbkV1xUsZmRt7IIb067qwY5y5SoOnNt7Q1EJgMjtbAidzE7hdMAotB/lp v5G7Utm7dUQsAMa6VhQO8HXMusE2TIBQnBKWSIPD3cZdc60l/22urKCY8OlZaXUY1NyIF3lI XKUVteu2J3c0XyCdeW1JkO9hzWWm2yUTnk18kbvvFCy/XBbauuNTfGREElksOmrflaCsrHW+ yrMJYTB/P4N2PhFYtAwgW7UZhPLnsVVtETp78AKhuzi9OOLpevuv3Qcf7VKraoGTE4WnnnCn 9GRzT3LNUo1DHfZpY5ummiZ5rAQD2OwXsrKtmlwwE68vl9CqRc9g4IlF+++saHbTVfr61eRj oMHI/a X-IronPort-AV: E=Sophos;i="5.96,200,1665460800"; d="scan'208";a="85229605" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oe5OdqmJvWf8EMgRkZBJabEvIESwMpYWoznJYTOQJ8T9texW89Vp8Foyuo+IRm94iLZh/Q6eXn6h1zSvyRxbE3/IcsjRWy4WGt7/2poyYUFuGIvyubNAM4DsvV/gkWeEeBkt7Dz4A2718te23tXgkq2/n+ugZEzA8VZA1WLbkAMr0XsMNGRUkxCRUrj9j0IeEeisXjxHcZlYF7QFLTb9SfQYYr1EfiJ61l5lSNAwd1qaSQRUutx+2aqyg15/GoyOkpR9MlxzREvSt4tlPwBV/V5Al/0UwekjtrgYTCSKRouUFQTjwpUapOVqpVCsIxNsmi6fT6Kolyo2LtWzumoT4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XI9KoTAeUO1ke64jAv3W7cYMqIp6oRzu/NVY/wNK59c=; b=FRLlxzIB/f6E/7YHxy03CjMN4ZpE4YUxVFcvKusOgGbqlm8CeT4vCmYUzPsVgAcnCGwEXr6KrJ9wRz9tLNJC0rYyVdoLMy4+Ic58HTzpO5kWS70pgXgjqqti7tNxfST5cdZlD5K42a13Aj7st0+v9aSS7u2v9u9b4dyiH2YHOI9fpaSvXPehDQMLffr4nDPFKmu/Az62uJRl1P3gyN4b9gls3xtencZOc6y8/uI8fWhPqe6unELUpKEfF2WFaTqKDbbANPVhdw3MUbwE/ExaqOwCKt38s/OtKRYA3fTXE9UOLJlb+stcT0BYJJK9PcZPtA5TPHY7Q83pVXfz7/iYVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XI9KoTAeUO1ke64jAv3W7cYMqIp6oRzu/NVY/wNK59c=; b=fDme3mWhL2vPdGsboUh8NUGLmIy1DmQ5GFq3c2ivtx0mzqAOzVM2ZoyTJdlaw4loAXjrBFcSTNfGUHkS1RLoZsVoueM3MwbIwbMqER1AmAtjhBlJHnRitRQhzs32w5+u5CHOzKVjA2hbDFsF/3lKABnzYNu6ZJ1iTlLNLdic/kw= From: "Per Bilse (3P)" To: Jan Beulich CC: Paul Durrant , Andrew Cooper , Roger Pau Monne , Wei Liu , Julien Grall , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] ioreq_broadcast(): accept partial broadcast success Thread-Topic: [PATCH] ioreq_broadcast(): accept partial broadcast success Thread-Index: AQHZAxKKQ5gC8MSrQkutQViuEWIcyQ== Date: Mon, 28 Nov 2022 10:16:56 +0000 Message-ID: References: <06ad4b3a67a15192fc986b35e3f2fcd35b2f4c2f.1669383767.git.per.bilse@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN6PR03MB3378:EE_|PH0PR03MB5862:EE_ x-ms-office365-filtering-correlation-id: a623ccba-e1ed-4610-68cd-08dad129add9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZzfD7zOwNjppLwtg5Pc1ykA3fJg1Qz4CyhOm742SSboDkQTio1PI2FqY+Wcbk/0O+xVicUuJ6Zk8/IP4bk8u+wg+A/RBMXByUXNCqP3pB7NqkSftB4MtUtUjzjjiVvrgtJ/k0+eYC5dTHNxB3BROtihsW+TCo0zf+6IGH38pGNjNwMmHYiq2ab5rODqE/RZ3vkeSr6sooGYt6Zap185f54nWBCbGWGbXsz3CalFNc4RwiE2iTsxhN6k0exJ3hOv1O2GzapNyUvwPeqntgDpo94qeH16KqHChABQo7X5tCjzQrxpU+nTfnA+IcZOOuy+jAT3mXBFTOiXgGg1soEAZbufXAOCWkhainmthrqg0vliGxV9ZZzSItSazBoqKkEACZVfEXe5WUmqcWETp5bnUF5fwwGSQL29EAo8yACP4R7A27HnhbOTw2/RFtV1eRZipQU0rBgXAUjJ2LxnzZzOuS5692T/aqP92bQfsvEITsDbCs9pmEucJBCMKMji27ZSvFt82MyFo98f/e0ALdrdTnIPzQ9ubP+9svgjzg7oWoFQuoxwKO2poTiKVsBM+LdQ53CFOGThbrtp8UY/73CaaKSfezQ9o/ETTOp3knNNWGQMPEk89dFJl1awoFbvcCcNYszdnZUe6G0TVvKIzdzTSyY+z+9ae7o/9UtRS2Cfh8KzIkQPDC/X4DMNKY2r2ZDK50fFABGBOoMniNSsIz4PidAAXmDz/rwTsnZ+Mn5sk1N4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR03MB3378.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(366004)(396003)(376002)(346002)(451199015)(5660300002)(64756008)(4326008)(66556008)(66476007)(66446008)(8676002)(31686004)(41300700001)(8936002)(6486002)(6916009)(54906003)(71200400001)(66946007)(2906002)(478600001)(316002)(91956017)(36756003)(76116006)(86362001)(31696002)(6512007)(26005)(55236004)(6506007)(53546011)(186003)(2616005)(38070700005)(83380400001)(82960400001)(38100700002)(122000001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SURkYkJiNExPT1MzTjhCbFpLMEl6dXpCR1MzRTBic2tBQWxzSnhrRGZBR1NP?= =?utf-8?B?QTN6c1VUN0RlOGoyNUh2UUkzZkRRVGtSWXBjOVU1OFZMZGhwQ28wbHR4bHNL?= =?utf-8?B?Nk1xUG8weFpNRmR4b3RESGtGV1FNMVJaWVBsQTd2OUxQb2lwUVpRcFM3eTNa?= =?utf-8?B?cUxrejNaZ1pLV2pNL0Zoc3dzS1RRb2FDY0hWUXJpVlBqb080SUM0TXF4K2RJ?= =?utf-8?B?M2R5NWRCa3pGbzBFVUVSVTNGdWg3MDg0TThuZkZkRlZ4U1BIMUZWZlZhMVdX?= =?utf-8?B?aEIxdkFtQU9oYUkxbENrL3RpeXJTWjFsRkZjcWFxVjNrYTdQZXhRcEgrWUhB?= =?utf-8?B?Y3REcS9pUTNKUkRKZzd1dEhFRHRwOWl3S05JZk03cys3eFIyZVlyV0dETHh3?= =?utf-8?B?SktPMEU4YTA5bldKdG91Z3NSVFlFMlVnaTVHaEVLK2VpUmpCMjkwZmFpc0NQ?= =?utf-8?B?NWRQNVBTYVk2RHExM1k1Y2tqUk0yaVpUSTkwUnpYQklDNnJaM2h4alg0aEVP?= =?utf-8?B?NDRTMC9oZzQ2TVVyYmhUcDRlQXZOZERsdFFDRXFWS2ExeXBmYjZ1Yms2RnR4?= =?utf-8?B?dy8vVFNBYmlvcVZpb3RkblE0WUN0aW1jNzMrbmVHZ1Z5Vld4Zk53OUpDZStk?= =?utf-8?B?MUpSTU1jTHliYXpPSnhRR2x2ckc3QlJRTHI1dTdLb0JycDQrb0NuanBIcmNv?= =?utf-8?B?QnV2ck9nR2dLV0hFeDYvWXdYMkpZMGtuZmRQNnNCbzYvVWxWWHJ2WFo2MUt6?= =?utf-8?B?dWVKNzVFS2pTbitsSmpUOGJZaUJqSnFCUlUwSnZSN0hyWWxCbXVkUWN6QTJ6?= =?utf-8?B?Z1YzNlVDNC96d0pGL3I4L2Fmci9VOWtMS1NGckEreElJQm0zTUlDV3E4dDMx?= =?utf-8?B?K0dpZW1jNU1IQzdNZ3c0S1ZhR2haWGZVNFZOZWg5WFFCM3lxcTVZalZodmVQ?= =?utf-8?B?MkRFL05UQXdESFpaV3UxN2NMM254TTRTQ3BoYVF2aG1HWFA0WGRpM2ZhekUr?= =?utf-8?B?NzVDNllqUU9vWWpYV3RrM1hmY2xDbGowU0FQYWFhUGRBUVIyUmN6T0RpR1RK?= =?utf-8?B?Wis3MmhySFNaeVEwNGZjSzlaK2ZGbDRKQzVVTjNobWpCWWtVRWI0NExaQVdN?= =?utf-8?B?UkhOR00wa21adXY5eUE2V0JOUllwdlhNTmdabWt3aGVkS1RJc2NPQ2VmVUNY?= =?utf-8?B?WDhGV2Z5dVFiMXg2bkh2RzZib1ZXc2JINGZ1d0FVWm9UT1NPOEhlZ3ZXRjRZ?= =?utf-8?B?OENnK0IyKzdyL0IzRHlGeGFEWjBVdzh5cXNxdmxac2ZQVWJWTVdRK3dPS1dW?= =?utf-8?B?QnFDNVdja05jWXJXcllleW1YNHI1SEUrMkx2MDF3RFJ3MlZiOTNtM21ST0c3?= =?utf-8?B?bkxmNVpnVFdLN2Z3RGRxaFg5RmFPb3FSeWg2TlpZZ3I4VFJNNGsvZ0lEL3ZU?= =?utf-8?B?aGNlZ1k1NjQ2Y1BreTh0RGQrTFJnV1MzbGwvMVdNMVUwendiUlFJYk94a2dM?= =?utf-8?B?MWoxaC9DRFdlSjROYzdoTFRiS01mOXZ3cHJONmpweHJqREtMSWRKWTN5NVZj?= =?utf-8?B?RGo4SmlFNUdKSksrNWNDZVlHdHZBQjJpWXR6YTM4VVVBQ2FPL1laYVk3bkJO?= =?utf-8?B?REZiL0pqdFNsbEdBYWd1NXkyMzE4UzBqZldJY0tsU01oM0tvUk8xV2dtNUx6?= =?utf-8?B?bnNlN1NUQzhCOVpPdE0ycWtObXpYQ2pHUG1ZbFFqTjFiUkVqbjlJRTU1eG1G?= =?utf-8?B?SGZaQ0t6eVZmbU9uSGhyNXNXTnMzNStYWlVDZDFnNUFZcWhjdGNHK05FWEoz?= =?utf-8?B?N2RjeUd4S3lSK0tRQmEvdytvZjBnVlNjSWFEVVlUSVRINHBLVHNpSHFGMUhh?= =?utf-8?B?WXBWNVNqS1ZESElqMXhucDlNTnJiTzkwdlMwSFo2UlBvdUQ1eGdGQzlPdDgz?= =?utf-8?B?bGNaZ3BLRm5hdGRGNlB5Y2tpQWNFUjFyK2lZemNpa2IyRzBFclM4WnBjbUFa?= =?utf-8?B?b3RMZW5ERWNhL1NPbytmZC9HaUp6UXhLR2IzUWpabExpTjJRYTVhSkNMTkxm?= =?utf-8?B?WmZmMTBFL0FFY05UcjBHaFovWHlYU3N2K0hWWVdLZlA3OXJzSmlneFZhbHQx?= =?utf-8?Q?2fSGnErOOU1C6PF24IJMDuJ2s?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: rfKQOzuxzaCgv5H7L2uqvVLRnOCwMpWF3/ouqFxqIsVE2mUJ3q9vymoZTpNS4oKfR8JO6wlNbyZfeTjgKA5c9/tYw8xF0dLzY9WCbbUmh5Mn5z+PhyWWwgG1jbnNbkam8sMdw1DXehcEKcesiHrpEQVnuOrHi1cc2gNrnc+oz+d2HQFBntOfA+FcbXlmWSRbI/F7QxB/0B2RySi+As66acML/KxJs5VP1hySTzRKaGU0np7E5n3ag7SCdZJvKwxuKmcaTqEVsGgLCTKUnpDuitLamkmXkILqeqFZRx0bvfSZ4bKyCXvxNccJRPVnl+7wckb/0eYat5bOySQCKE8n8q2s2COE++2/jM+Jw/WU7WuR1qpGHPNYCT8tX2CzCVhX7sbaPph+fM5TObUvjvXtce3MZoabHq4dPfmU+h8HbhmmXiyqE9SIaVtnYlEv8ePEPUHIvKE4m7mB9mNgV7Zgh/YSFHwaN0ocQfRswTMQ4NPLRBNzAfHZLP/KVv2BVysHo9p7pcT8uzkyfqxqptn0X3Z5fZBJhn374NSfyG0YmQL2QmweZzqrrtLI7uUP2Cfmtae7nwi/wCXCLhX3d/PveDlokeoGrnNL4lgLjV4pkLIIX2P4UThaowXuDH8mHQ6HWcT3S+13MaTa0DIhWR0xMP9AWLRN/2GOS+gnzY0reqgiXVXz4nDJ+gqE0RSA5W5D//Oe5KP+uNSBAX3wHQ3GEBq98HanT49mvJNbJ6cKB88JGRuLPDrnpbcCyiG5laCN3SyWMxB9zWOXhDCodDMYA2vXgr1+ErcaVUlgb7qfy7lEH6oLsJyW08HpMkeDdF7e12aD4DWw8rCpMD92OUphKmI0ync4JBWcyv15TeSW/x0YlOwCaFGmYuzdGBW1hIxM X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR03MB3378.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a623ccba-e1ed-4610-68cd-08dad129add9 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2022 10:16:56.6604 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DbtcuZmdcgHI8mlpoe2WdKIa6DZsdnGJY7rnfvXg5ka8OgoHZ6ODRh06UHtB2tehVJ9XhklmCnxBsdfCIwCBJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5862 T24gMjgvMTEvMjAyMiAwODoyMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI2LjExLjIwMjIg MjM6MTksIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+DQo+PiBUaGUgY29tbWl0IG1lc3NhZ2UgaXMg cXVpdGUgdmFndWUsIHNvIGl0IGlzIGhhcmQgdG8ga25vdyB3aGF0IHlvdSBhcmUNCj4+IHRyeWlu ZyB0byBzb2x2ZSBleGFjdGx5LiBBRkFJVSwgdGhlcmUgYXJlIHR3byByZWFzb25zIGZvcg0KPj4g aW9yZXFfYnJvYWRjYXN0IHRvIGZhaWxzOg0KPj4gICAgMSkgVGhlIElPUkVRIHNlcnZlciBkaWRu J3QgcmVnaXN0ZXIgdGhlIGJ1ZmlvcmVxDQo+PiAgICAyKSBUaGUgSU9SRVEgYnVmZmVyIHBhZ2Ug aXMgZnVsbA0KPj4NCj4+IFdoaWxlIEkgd291bGQgYWdyZWUgdGhhdCB0aGUgZXJyb3IgbWVzc2Fn ZSBpcyBub3QgbmVjZXNzYXJ5IGZvciAxKSAodGhlDQo+PiBJT1JFUSBzZXJ2ZXIgZG9lc24ndCBj YXJlIGFib3V0IHRoZSBldmVudCksIEkgd291bGQgZGlzYWdyZWUgZm9yIDIpDQo+PiBiZWNhdXNl IGl0IHdvdWxkIGluZGljYXRlIHNvbWV0aGluZyB3ZW50IGhvcnJpYmx5IHdyb25nIGluIHRoZSBJ T1JFUQ0KPj4gc2VydmVyIGFuZCB0aGVyZSBpcyBhIGNoYW5jZSB5b3VyIGRvbWFpbiBtYXkgbWlz YmVoYXZlIGFmdGVyd2FyZHMuDQo+IA0KPiBJbiBhZGRpdGlvbiBJIHRoaW5rIGlnbm9yaW5nIGZh aWx1cmUgKGFuZCwgYXMgc2FpZCBieSBKdWxpZW4sIG9ubHkgYmVjYXVzZQ0KPiBvZiBubyBidWZp b3JlcSBiZWluZyByZWdpc3RlcmVkKSBpcyAoa2luZCBvZiBpbXBsaWNpdGx5KSB2YWxpZCBvbmx5 IGZvcg0KPiBidWZmZXJlZCByZXF1ZXN0cy4gSGVuY2UgSSdtIHVuY29udmluY2VkIG9mIHRoZSBu ZWVkIG9mIGEgbmV3IGJvb2xlYW4NCj4gZnVuY3Rpb24gcGFyYW1ldGVyLiBJbnN0ZWFkIEkgdGhp bmsgd2UgbmVlZCBhIG5ldyBJT1JFUV9TVEFUVVNfLi4uIHZhbHVlDQo+IHJlcHJlc2VudGluZyB0 aGUgIm5vdCByZWdpc3RlcmVkIiBjYXNlLiBBbmQgdGhhdCBjb3VsZCB0aGVuIGJlIHVzZWQgYnkN Cj4gaW9yZXFfYnJvYWRjYXN0KCkgdG8gc2tpcCBpbmNyZW1lbnRpbmcgb2YgImZhaWxlZCIuDQoN CkhpIGd1eXMsIGFuZCB0aGFuayB5b3UgdmVyeSBtdWNoIGZvciB0aGUgZmVlZGJhY2suICBBcyBJ J20gc3VyZSB5b3UndmUgDQpndWVzc2VkIEknbSBhIG5ld2JpZSBpbiBYZW4gdGVybXMsIHNvIGFw b2xvZ2llcyBmb3Igbm90IGdldHRpbmcgdGhpbmdzIA0KcXVpdGUgcmlnaHQuDQoNClZhcnN0b3Jl ZCBkcm9wcGVkIHN1cHBvcnQgZm9yIGJ1ZmZlcmVkIGlvcmVxcywgaGVuY2UgdGhlIHBlcnNpc3Rl bnQgDQplcnJvciBtZXNzYWdlKHMpLCBhbmQgdGhlIHByb3Bvc2VkIGZpeCB3YXMgZGVyaXZlZCBm cm9tIGRpc2N1c3Npb24gaW4gDQpDaXRyaXgncyBoeXBlcnZpc29yIHRlYW0uICBUaGUgJ3BhcnRp YWwnIHBhcmFtZXRlciBjb3VsZCBhcmd1YWJseSBiZSANCmNvbnNpZGVyZWQgYSBjYXNlIG9mICh1 bmRlc2lyYWJsZSkgc3BlY2lhbCBjYXNlIGhhbmRsaW5nLCBidXQgDQppb3JlcV9icm9hZGNhc3Qo KSBpcyBjYWxsZWQgZnJvbSBvbmx5IHR3byBwbGFjZXMgaW4gdGhlIGNvZGUsIHNvIHRoaXMgDQpz ZWVtZWQgdG8gYmUgdGhlIGxpZ2h0ZXN0IGFuZCBzaW1wbGVzdCBzb2x1dGlvbi4gIEknbGwgaGF2 ZSB0byBkZWZlciB0byANCm1vcmUga25vd2xlZGdlYWJsZSB0ZWFtIG1lbWJlcnMgZm9yIGZ1cnRo ZXIgdGhvdWdodHMgb24gdGhpcy4NCg0KQmVzdCwNCg0KICAgLS0gUGVyDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon Nov 28 10:50:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 10:50:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448869.705443 (Exim 4.92) (envelope-from ) id 1ozbis-0006tL-6a; Mon, 28 Nov 2022 10:50:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448869.705443; Mon, 28 Nov 2022 10:50:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozbis-0006tE-3I; Mon, 28 Nov 2022 10:50:50 +0000 Received: by outflank-mailman (input) for mailman id 448869; Mon, 28 Nov 2022 10:50:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozbiq-0006sm-VL; Mon, 28 Nov 2022 10:50:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozbiq-0004oE-Tr; Mon, 28 Nov 2022 10:50:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozbiq-0007cj-Hv; Mon, 28 Nov 2022 10:50:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozbiq-0006Hp-HP; Mon, 28 Nov 2022 10:50:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=f5L2nzLgIKf+oAurg5YRvimHBpjHyCi3AMrEUfGPaLU=; b=Bz8wmAIcY4ERpEaIOfpRe6exKG AKSBy/KDeoBAyVT1rjBRbenxGxrVzC+4ddaRiEPma+mbrpbVupSN8SkprMNDoA455LgwK4pTLMY7o RVS5xpBhPu12Wwk4Gbfu9w/cFSZ3OGXMsB+El4OT9SqR21QL4Dm1pdLbkj1QHkRy7SOQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174980: all pass - PUSHED X-Osstest-Versions-This: ovmf=d992163da6cb3c6e91c24938ad4b8804227eafd8 X-Osstest-Versions-That: ovmf=85d805ed3201de16c4dcbfc4b886a0d11ad5885c From: osstest service owner Date: Mon, 28 Nov 2022 10:50:48 +0000 flight 174980 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174980/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d992163da6cb3c6e91c24938ad4b8804227eafd8 baseline version: ovmf 85d805ed3201de16c4dcbfc4b886a0d11ad5885c Last test of basis 174978 2022-11-28 07:12:02 Z 0 days Testing same since 174980 2022-11-28 09:10:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: JuX Zhang Zhang, JuX jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 85d805ed32..d992163da6 d992163da6cb3c6e91c24938ad4b8804227eafd8 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Nov 28 10:50:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 10:50:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448868.705431 (Exim 4.92) (envelope-from ) id 1ozbig-0006bq-UC; Mon, 28 Nov 2022 10:50:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448868.705431; Mon, 28 Nov 2022 10:50:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozbig-0006bj-RS; Mon, 28 Nov 2022 10:50:38 +0000 Received: by outflank-mailman (input) for mailman id 448868; Mon, 28 Nov 2022 10:50:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozbif-0006ba-Cj for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 10:50:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20624.outbound.protection.outlook.com [2a01:111:f400:7e1a::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 791cd105-6f0a-11ed-8fd2-01056ac49cbb; Mon, 28 Nov 2022 11:50:29 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7140.eurprd04.prod.outlook.com (2603:10a6:208:192::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20; Mon, 28 Nov 2022 10:50:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Mon, 28 Nov 2022 10:50:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 791cd105-6f0a-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R03t4IviUH3fKxonQfzlCon5hbhNTugrK9eP1WYqI5eWdYdtkInFNlJWDWoyWcXNh9QeToSAo/Jd43HOBkrXwl7pnML1gMvEn5POpbRR+EhJswgWGphbkmMTolVMO5tSRCtive08i/ogJdTfFUrLJv1xyCilXw/temlVoDztx7CoOcYehJXC1+uZB6o3vCKNOVBV7QFafByenjnYPhuz0PdKlwAEUcwmeqmWxgFuq+Ad23FTlmVC9ETWi88ftUJ0TszUEFmnVSWzLdU+bRPAKOq+lM1gPFKP2BttYP8+ZCXZCYLuIcmHlgg3gYdP46ZX4rWLJ7TR0TmaV19p0JFnsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YmFUEpVACQD1Fe9TwDU4e3aRLKk5K/g+oMeR24yN3dg=; b=EwBOAf5udVmvsqJTvs3+rqrj4Gk+qJVKtMMJib5v3DyZWiifVhyVwKb3W7RKDne6shREFkb9c+GLJuL330RqfHMHc99wO/DSyOOHihKdH4pA4bForg4WLQWhL/JM83t2Kx+zKSfQdGw3D2JR7wOW1ZiE5EyyJw6zfheSNhuWclowTPvCc7vpY2pL+xCyOQZRc/ieeiphS8i46cftSS6HGxkOCc8ofFnzMir57rwpsm5s9RRx/lU6QExqNYtkV1Xi0e7gOHzRtZtHa8MLEjShFxk0Vlue0FfnoloKX6HhH0sbI324Zf8wN65QtYMBOwWi4/Obt2+H1HYK3EGJ3q6x0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YmFUEpVACQD1Fe9TwDU4e3aRLKk5K/g+oMeR24yN3dg=; b=mifkqRaImMdoqkAgJn/26csno4PTtqQoZwG+4io2SBBcGEIVBOfGB2VmXBanUWLMIdMwtZbG2OJf0rbIo0/wmCdd1ut5mJW0cLzya4GEzXnFQEylRUYX1Hd36RP6COYHveAgpnk+n/pYgYWA9MNkpv+07gLRsiFSgHJPeul9ZdLwxrTKBiAwK5TY7XBUtbcZJpAddMFm6er0USbzYrtLZ4h+dHCNCwqqecibVeGckheel3cuvENiXlFpUiSwX3gyWyExDhjNNn+kOW0RRa3ufiU6hguO5U/kHWhb1muYELl0vAbPR6NsFZ1pAohEU6q/AfX0G469ZPKclBIqMRORiQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2c4c605e-f8c5-abbb-db85-89465b7e10a6@suse.com> Date: Mon, 28 Nov 2022 11:50:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 From: Jan Beulich Subject: preparations for 4.16.3 To: "xen-devel@lists.xenproject.org" Cc: George Dunlap , Stefano Stabellini , Wei Liu , Anthony Perard , Julien Grall Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0103.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7140:EE_ X-MS-Office365-Filtering-Correlation-Id: adbe15b5-fcc9-4f96-76dd-08dad12e5c37 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BCLfWphFvLJHZZPlBN+R3CG+jVY0zeQiMSlfLTwwmQ1SFqLcnBrkb7qHVaTfisg4xgHnaJJJ3d0jB0oCGVNIEXrQ6rjPP0IwBgy9FBZSTmtU+kerd0sigprOiANxDRnYeprpVRhDkcTcPv0FMm6sd6G88n4iVjn9q1ficFyDK0+9ZUT684VJ7+I84J3QDFwSFn0Jt0uDzaM6Tlx0cBlEcOsMTVjZyaP73dk114TLfAg5o8pnxqfY2n8f+CedfpZ9zQ1e/p60qoa+KTBrfy7sIUAUOy4u5U0FTcoJrI7C6ZiXoSLzlShDz6uz23TosRsH+9rsRn51ZwdfUXwVr946mENWjVzd0SZgFqLuP8vyVAqoMsTs5oFId1jIucaY+n8BxTwdG9dhOxNaTq02SNGESkxiVip0I0llrY7EzeURl3QZFB97R2HXl+FpYNpc6qhj12doeQPyo/PiMqGR8r3nBjCtSXcNqqHTAeXlqMU3qgDusbpPh+VRibAJQTA5PYX7DN4PKYXyj/0ICpiGDbr6fMr3C2UuxKsklLBODbp45mGM3MJaCdm3nle+Iy7ko2aZ4cv+YNlJlkTIFWF4cu6XTb/pIrqQrz805e/WnWdEHz72mi9YK94z6Nz1YOzKriz1gQchCIRQYnv2V47+JcAnFB7w1bedz3e6f9H5TS6ASDdoUxEiAOiNfyfifksIyCAQSnD2gVWiPN3rSyhLlFcP9ZWZmzqE3L3gbrhnGbeg57A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(346002)(366004)(396003)(451199015)(31686004)(66899015)(6486002)(66946007)(6666004)(6506007)(66556008)(316002)(66476007)(41300700001)(54906003)(2616005)(8676002)(26005)(6512007)(8936002)(36756003)(5660300002)(4326008)(186003)(86362001)(38100700002)(478600001)(31696002)(558084003)(6916009)(2906002)(7116003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkR5RVRLY3FMdkNveGtkNm9BUUhTQ1Rnbm5BTzJES3VobXFnaFBIZGlNYk9a?= =?utf-8?B?M0hsQXVITzhERlNJdk9qTE5ybllhRzJhaVNMMStHSFp0UmtmNEV1eEhhd2s1?= =?utf-8?B?UjFRVmNBUk1jUVJTTjF6V3owZWJOUEhWdEpkZ0pTV2hNcWxybG1neVBKMlk1?= =?utf-8?B?KzlDQVc4K3FQdjZ2WmRZWjZBMjNFTHpTSkdCb2xXZldCL0tKZGpCSk81RW5R?= =?utf-8?B?ZytQRjROWmJSa0tSY0ZOVGZ1U1RwaDBod0IvYVVxaFViODByWGk1OU5jNUwy?= =?utf-8?B?OW9aRVVtMk9LeVI0Y1JlV3R3MTRTL0NhcXhJR1ZiT1UzZGdiSWRkMTZnVEMx?= =?utf-8?B?MmRMdHVsemlYemI3aUp0QkNEM09oZGpvcFpiUHlURTNZMkhDWU9JZHpNSkFj?= =?utf-8?B?M25PbWpEMFZJalV0cDRPRFFXVmZWaFVsSlNvTk45N0F0a1h4RzZaSVl1STR2?= =?utf-8?B?THp5SHNMRHRUclBtNVpyYVoxeUZObmtIZFV0NWJZb0lML2ZoSG5LNE41NUdz?= =?utf-8?B?dUtlc3hGL3E4eUR0dmdVUWlUUE1KZzhadXNGRkFaMlRwVmFrQlJVT1RIN0xs?= =?utf-8?B?R2xRWkxyK1dKQURyNG9Pa0tEenpVZVJWdUEwMUlPbGhxUGkvMGVGRnJDT1hR?= =?utf-8?B?c0lQOWZZTnlDWktlcWxyOGh1dmliM09tS2RDcUEvYzg2NzRpdFN2bUE2b2x4?= =?utf-8?B?dmlUNmEvcEw5cGduZXdVL2pudjlETEx5SlRibUROQmFiZWs2L1E0T0Q4dlNt?= =?utf-8?B?dnhkeS96ZzJZaW45RFdmZ3NFQVk2bUl3a09KQ3dJcDQ3bDJWZDZtZ3V6SFMw?= =?utf-8?B?U1crUFp2OUFQcU5qMS93aHg3U1pvVU5pQkRDbTZhRFp1OWxqTjd2cE5VTnh0?= =?utf-8?B?Q0JuaVZWOFN2MVVvdW9Ra202M1VRKzAxaEtmU3hqbHhyMEIwSWR3UUhienhP?= =?utf-8?B?UWoxZjh3SHV1c041cWJuMzgyVGROVEU5WVFtOHRDRU1LUENMQ1ZEeEt4b0F3?= =?utf-8?B?SHNTdFlFUTJmR2tDTkozN2hMbFNXc2V1MCtLOVlsREFzUkxNQUZIWlBSVzNG?= =?utf-8?B?d0E5Q3hDZlEzenYzczRNRGhtSTNKSmpESDdJSVczdHdpa0p0K3Q5N3QrZ2tV?= =?utf-8?B?TTgvam9JclUzQXZZdzZLelNldnE5anlFbUt4ZWFDNzBVNG1xNFEraTZRWE5S?= =?utf-8?B?UjJrNHRKcU5KRDB4YWtSZmVSeGhaTkI1YkRDWDVDMzJtTExSTVZjcC9wMzkx?= =?utf-8?B?MlpJVm5NZnozWnVXZUFZbEdqL3V2QlA3TkFiUXU3S1pNdklON2lnaGw5UVQ2?= =?utf-8?B?WUZJV1lacFluZjIwRGpMTHJoSnVGc2xkWmtzUmNtZnkwY0RFSHNRbHNEc0tO?= =?utf-8?B?ekgraExiWmtxU016N0FZR3ZzYzlKNnFvazgxMmdSc2lXUWJHamVyUFR2WTND?= =?utf-8?B?N045YnRCUSs3QktYcTVDejVpT1lCMURJRkhZU1F4cGZtcGFxbGNGanVHaHRZ?= =?utf-8?B?VW9SL2tQZVNTWGRmZ2cxeG5WVi81MjhjU2k4cWtjN2JiK1BZUDRpQWhDWkwr?= =?utf-8?B?aVpid2dFQitPajlLdkdCeUkzbTVDQi9BbWJCQ0cvb2hOUENENG8ySGtJcVBC?= =?utf-8?B?ZWFxbWgrOHA1QUdkUlBybWt3Z1d3MDI4SG9OWlFxaHdiaE9iK3o0SnV5QkJ1?= =?utf-8?B?ZjJZUXFzdmhhK2s4TmdBZjhNR0VXMFZNeFpJSzg3NUF4SklKUHp2OURUdjZj?= =?utf-8?B?VlhKVENxNnpBZTcxS29vbTg2RGVFNGd2TGpNdmhEN3VjaUFNRldFTXREY1hK?= =?utf-8?B?VmhqTStFUEd4ZHE3L3k1SlhYaXNMYXQ2SUZEVEgxQ05LdXgyZDNXSEFYZ1hp?= =?utf-8?B?YzVrM2FrTUZNNVREQ3QwdUZ5WnhCK213RUMxSEpyTG10WHAxZmNhUGdFYzRl?= =?utf-8?B?LzdHc3FVTlI2ckVvY0wyTUZmOWhnaFRBbUF1ODNFQVdodEo2bmN0SGRYOVZJ?= =?utf-8?B?RVF3Q1VDWGZOTHFHYUpwQ3JyNmVNczFnVUgwU1BpQjladXNuTnE2L296TFFI?= =?utf-8?B?MlVJWUlBRXE2dUV1VGp4U1MyWkJjeURrRytyMTRzT0F6YnRXN0hQYWFSUnd5?= =?utf-8?Q?E+7DlCUCMT4JayWhY2HghtnOC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: adbe15b5-fcc9-4f96-76dd-08dad12e5c37 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 10:50:27.4060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hOVA8I7v9NJPFDvRYRQrU82ULgU+8FPapJ3AHxduGkMHDhj9GNG3/3kiFHBz5/OEC4ZOAOF46CdPDPvUhms1cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7140 All, the release is due in a couple of weeks time; ideally we'd get it out before the year end break. Please point out backports you find missing from the respective staging branch, but which you consider relevant. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 28 11:07:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 11:07:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448884.705453 (Exim 4.92) (envelope-from ) id 1ozbyu-0000Pl-JT; Mon, 28 Nov 2022 11:07:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448884.705453; Mon, 28 Nov 2022 11:07:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozbyu-0000Pe-Gm; Mon, 28 Nov 2022 11:07:24 +0000 Received: by outflank-mailman (input) for mailman id 448884; Mon, 28 Nov 2022 11:07:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozbyt-0000PY-SV for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 11:07:24 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d4107717-6f0c-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 12:07:22 +0100 (CET) Received: from mail-dm6nam12lp2168.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Nov 2022 06:06:59 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by PH7PR03MB6969.namprd03.prod.outlook.com (2603:10b6:510:12c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.22; Mon, 28 Nov 2022 11:06:57 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%9]) with mapi id 15.20.5857.023; Mon, 28 Nov 2022 11:06:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4107717-6f0c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669633642; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Wo5sEsiSiluNWOP/bP2iU2KV4YvsdctqfUE2ywWuX0Q=; b=NxZe9zxzlhnjHkqv+09s+Aa/dRc3J+4sov+TgKf/7ghmYS6+gdrUH7N0 UybEslMfwg8MDDsUSxUrtnJ3Uz4ojCG12OuT3JcmNrMfn3at5t3194BIk o5vDDQwXyjzEDGsA4bNvZKWQks9/rVXc1Qink+L5IDeKR8j5yrUhJ7GOF w=; X-IronPort-RemoteIP: 104.47.59.168 X-IronPort-MID: 85232538 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:rqZHa6xxlSQfwQYhT6t6t+fyxyrEfRIJ4+MujC+fZmUNrF6WrkUHy mpNUWyGP62CZzajLtx0YI2w/BsHu8DUz9VrSFY//yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnP6AT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVxO6 cUjGTEuUg2OnfqS0bGAYOddjNt2eaEHPKtH0p1h5RfwKK98BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjmVlVIhuFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE1rKVxnmmA9J6+LuQysN2gHedl1UoEQA3CGKRrP6BgGOAcocKQ 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS8AiQzoLE7gDfAXILJhZebPQ2uclwQiYlv neLgtfoCDpHoLCTD3WH+d+8vT60fCQYM2IGTSsFVhcepcnuppkpiRDCRcolF7S65uAZAhn1y jGO6SQ72bMaiJdR073hpA6XxTWxupLOUwg5oB3NWX6o5R94Y4jjYJG07V/c7rBLK4PxokS9g UXoUvO2tIgmZaxhXgTdKAnRNNlFP8q4DQA= IronPort-HdrOrdr: A9a23:dTQBvKElrfbe9l+qpLqFgpLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHP9OkPAs1NKZMDUO11HJEGgP1/qA/9SkIVyEygc/79 YdT0EdMqyWMbESt6+TjmiF+pQbsb+6GciT9JrjJhxWPGVXgs9bnmVE4lHxKDwNeOAKP+tPKL Osou584xawc3Ueacq2QlEDQuj4vtXO0L72fBIcABYjyQ+WyRel8qTzHRS01goXF2on+8ZozU H11yjCoomzufCyzRHRk0fV8pRtgdPkjvdTGcCWjcARCzP0ziKlfp5oVbGutC085Muv9FEput /RpApIBbU611rhOkWO5Tf90Qjp1zgjr1fk1F+jmHPm5ej0XigzBcZtjZ9QNkKx0TtogPhMlI Zwm06JvZteCh3N2Az7+tjzThlv0m65u2Arn+I/h2FWFaEedLhSh4oC+149KuZ3IAvKrKQcVM V+BsDV4/hbNXuccnDip2FqhOehW3widy32MHQqi4iw6Xx7jXp5x0wXyIg0hXEb7q8wTJFC+q DtLrlovKsmdL5YUYtNQMM6BeenAG3ERhzBdEiIJ078Ka0BM3XR77bq/bQO4v2wcpBg9up/pH 34aiIYiYcOQTOvNSXXt6c7sSwlAV/NEAgF8/suqaSQ4dbHNfjW2S7qciFcryLvmYRbPiThYY fDBHtnOY6dEYLQI/c24+TfYegmFZBMarxghv8LH3Szn+nsFqrG8sTmTde7HsucLd9jYBK0Pk c+ X-IronPort-AV: E=Sophos;i="5.96,200,1665460800"; d="scan'208";a="85232538" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hZwevQZRQ8Kb+Dq0wQAxTP61h0Dq5Zq1UknEkIqxkkMjV+QGKiJgRPcM4azoXvpyqC+8TIb+bVZZ0jqMY0eY8qek9BXkhBVXGLKHfjBVyQRLxSHNmd6kJfGCAZv0b73jLzDS7kNWDVkSaGI2yCuo5T7fZCoaRgStgmE9M1LytR1YZ2hvflolzhCbWwkEb6nQ0yUoCxm5gl4fJ3EnUP2KZuN83kWMVSvK/ee32TDxtzRsNqEi6a55Una71i+dxVlzN+TlH1iCKTq/TMGEVz6r0D2DbCr+Vi1cTlMRAKaXqLq2IkBEMAH9oJUuF6zEwKJWJi1vsHX5p4vzxMoegJhMyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NYMcg9OfEUIYPH64Wy/RlaqryI1n+V9p+oLi3+s4AQg=; b=c4z0BIjyedZfqb8ck8aMwJWw6/1CUKUQUahgnKjxjq2kAwxka/pP0W6w/Q/iZqhQJKn5GUbBMQHnorrJtZSSbiBv/GaYH0jAboskXiicob27Gm3uk53rJH94bKgQYINNfcoiXzxhDJlsZZiFqlpKPjiOqXZbQfNZ6DOl8LGhXeYcpdxgKREVvhDCePDg2aGu7W9nMik1IypoR0LU46lh4Kmw0GpZQawAhVbSZ9ArBEFjC+NN3CC5+YEui/mA1XTak6w9innYyfU0SVLWuniVOLnGU08qHIrFsJzX3Xm6aUUgP4I1hWYTne9XYgkUuodlv8exXwSnCQ6PVwCROIgDkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NYMcg9OfEUIYPH64Wy/RlaqryI1n+V9p+oLi3+s4AQg=; b=Khr+w0qTUHJtGvonSWEFlKh9a0QXzVwNCoOD9m/PexcD4ZtY12e9SC7AvLlYltSZ/rLTTTwHECO1q0ZKFvPA8eT4DRd3AEVzj1Oui5rNZStlHB0fFhlOYQ0SYkzXBwMlRwQ6xS5qDjJ3hBv2s5CoJtOuVerS1TqfJCfXAEIVtUk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 28 Nov 2022 12:06:53 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Per Bilse , Paul Durrant , Andrew Cooper , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org Subject: Re: [PATCH] ioreq_broadcast(): accept partial broadcast success Message-ID: References: <06ad4b3a67a15192fc986b35e3f2fcd35b2f4c2f.1669383767.git.per.bilse@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BN0PR04CA0196.namprd04.prod.outlook.com (2603:10b6:408:e9::21) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH7PR03MB6969:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c1af4aa-62f5-40a9-78f4-08dad130aa06 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sprFEdglsMkgkapRfickn8OW+plXgR5e4yCCDN9QP09WOSHwkXOuK9SCdKUI6Qs9fIOv8ZNhyyPaKXhSfA1+YiZucwu/3/pCEcmn0PmDbxYnn4+amBEBLho3mGGK4R75B9XmvnXXzPuzm3cykdlRx36MrwwVcM0SXl94djHHA8W6Dw6b72W+cyYVcrbQcLragFda41++qgU+cLUcrTlikA8e+2HL5kGERtQX27yST/JtRgjz78A+RaD987kHwdJIU+OlSvhnj9pvzvslPvnbEiD1f0OD7pTIBLlWnqUthJ44/tVQCWJSuB2fayV181TStvFtAefm1eCyA6laS0h1QdsoZN9iNsvwelAbLnVWKVYqBvHohOuS/f2Bymu6tD5ehjcDdYSAxV3PTsxMm5vmxfZ7AbkUJKO/Z8ydSXtGEYUedQp8nqcRMxi6I9I1nSLeRluHlKBjhtAZDnEzxThrfHIoJZXCEehMqn1ZfLQaesfbztQdevLeN1+sid1bIXhoVT8wFU7qaDVqFcMGQM/V9J8C+IABoi1PwC2SrdGbHLwBtxNHeK+VlUpBDhCFIPy8Cdt8klKRC3CmCwra2vTFALxeNH8h36aFusRSvmS6GMVz4LLn4n4QoeSa6RDGdGbM+KNGPwc6dohO5QwL2IUF0w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(346002)(136003)(396003)(366004)(39860400002)(376002)(451199015)(41300700001)(6666004)(38100700002)(86362001)(82960400001)(26005)(316002)(6512007)(85182001)(6506007)(9686003)(6916009)(53546011)(66556008)(8676002)(54906003)(66476007)(66946007)(4326008)(2906002)(83380400001)(33716001)(5660300002)(8936002)(186003)(478600001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L25vSzNsWWUzZXBWSjRCSFRUdlJLYjhTQXREN2tXNWNUZllhQjk5YlpXaUUw?= =?utf-8?B?clJZV2RuZUZQZm45T3NPU1RMWk1TOEFkNmF2VlFtb0Q1aElNb1k5YkxZWGZq?= =?utf-8?B?cTE1WjBSOEF0YjRhN3E3RDBUYjJOVlpyZFJ2RUtOR1JZM2Z5T2VoVVZQcjAy?= =?utf-8?B?RCtrZ0ZHeSs0V20waU43Y0p6K2ZXSFludDduVWViMFhWR1ZIVHpOTHJFdVlT?= =?utf-8?B?U3JQQnVQRTM0OW11azFvRGxwcCtNcEdQSTZhSFhtaFNwSGpyUlFRV2hNN2Jr?= =?utf-8?B?SFlQNWVzRmRybDlzdGcvME5zSitDRDJpL01tT0w2Y0VXM2g5bitpM2tSdDlw?= =?utf-8?B?QUFLbUxQS2NTT3VoMWNCMVVHUE1ybmJ0Z1QwS3VVVEx3RDNmY2w1Wk1DVCsz?= =?utf-8?B?ZEtrOTlJWjI1STFlU01QSnErY0FsMnI0eEVGL0JsRXc4QWd0TUgrSnNzS2RU?= =?utf-8?B?UU5xcFJLVS90K2FYWE5sQXl4WHEzZ0UvSEhibWMzcDdnbmNwZk5IZUZmZHAy?= =?utf-8?B?S3RybjYyOXVpTTJWdW40ZGpENlp6K1k4dHFoL3RvTFRTNVN3WWxpcHZFUENx?= =?utf-8?B?QVAzTEZkR3REdXNZeUUrc2xMRFVpZTdINnhzQVVHMEcvQkdGR1dFaWdzR1Fa?= =?utf-8?B?ajRlN0ZqblhWamtoTFVVR210NFY5REhOZG9ZSnNvRFlZYjFzSm05YlFLcTJU?= =?utf-8?B?YnVWSUpvaDFLTzdzSzBpcjVZY21FZ0hhQlBPdVVURldCeWh4UVNZQlRIVHVG?= =?utf-8?B?ZUNzRE9MR0draXN2T2pBcHowY21rcGxFWjRJU1dwdUNZY3J1L0d1eVBDbG9l?= =?utf-8?B?eGt2L0FKd0NSY2hpY0JCb1hEbU50S0NaMDFCNHU5blZzRGdBRCs3My9HTU9Y?= =?utf-8?B?MzYrQXA3RUV1bUVXWm1yV21SOER2MzFHbXBFR0VBSW9keVd0cnRPSDRwSGtS?= =?utf-8?B?RFlSYU9QYW5yV3hqUnc3S0M1TUdXV3BjQzRYbVFUWlR0VnNwZitRSDVIc3dt?= =?utf-8?B?YTJpdCs2ZzQvOTFRYW5KSFJmSW9MVnVjMVpIblB4WEVJMlpsajdJSGtYQXYr?= =?utf-8?B?dHNhb0hSMHdySHJtOCtza0JZZXl5dzFjdkxFeUVWY094T2J6YmpFaVR0UnVl?= =?utf-8?B?S1p6cmVFelUxdnJYcWw3NS9BL21mTUFnM1JmQ09JeHk2bEN3WHNRQkQ3NS9y?= =?utf-8?B?K2d6RVFXMmZtTWltNHR6RU44cjVyLzZVVHJLQ3hNSG9rUUp3NFF5M3luaE9y?= =?utf-8?B?NWN0QnJ6ekFtZGlXNWJ1VjB1UTZlTDYvSS9CUVpCclRhZmpkZDRhUTlOQUtY?= =?utf-8?B?K2NRZ0NvdTBBa01YT1QzQXp3bENhNFZSWmVJdHd1bm9CRkExazNndWt0ejRn?= =?utf-8?B?TlZMeW9hakRKVlF2SSsrUjU2T3lyVkRRanN1TnE0cFJOUXd5ZnBHWGR4dnFM?= =?utf-8?B?eGhta3JQQmtqQWRWdXdDbE5yb3V4YUVLaU5Ta3hKaC9GNllqQjdZZzQwMFN0?= =?utf-8?B?a3RJRTR2V1QwTjNFa1RlNWg4alVDL3ZGeHAxSTc2NXpmcUR1OXZZT2lhNEk1?= =?utf-8?B?eXdjZXgwZERzYXhkdXl5YzdibHQxVHJ5RldGUUk5MmNpcTRuT3lPR05Sbmpi?= =?utf-8?B?b2t4bTR0Q3lNOTBPdVBuK3F2UGdLSFZlYTM2cEtnaWNpUDY4NlNNcU1ic2tz?= =?utf-8?B?NU9PNkZGZ1Y4dTlKSnhMdk9SSW96end6U1VuS0lnRUpneXpMaHcvdmlXcTlY?= =?utf-8?B?c3VqNHFySEw3ckEyNHlVYzZKQXc0SXVFdjZVdVVmZVJVRiszbWtyMTR5OWJI?= =?utf-8?B?M3U3RzlUTEZTN3p4aHhHYUNKRWVPQjA5c0VyT0ZBNFpDbWNubVlUWlQ3V002?= =?utf-8?B?NnJmNFRiblA0cmRqaUVud2g2Wkx0MzN0YVBkV01UdUoxY2puVnNDaFdLUHFP?= =?utf-8?B?dlNieVJtZkJRSG8xQWw4b0E5UDZLandBYlhyK1R6NG1kWi9UN05JdHkxVitn?= =?utf-8?B?emJwalhDU2FGcng4RDIvNHoyYllKL01HT3dJY1NhbW1ZV0Yxd09RV3VCOTkr?= =?utf-8?B?NFpCV2dtNUhOMHdkSkFqck1TWHRWM2d5U3lvb2JHODI3dHNsWmc1OHkvbVBB?= =?utf-8?Q?LWgYvfso7uH5bkwUImJ/P8VEa?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: SZ6tzgylAHzkjFrfIPsL1TQeOg7tFXJ/eiaZkKOHWlHV6BZExas+EKA9ZA/u32ZGZuiDh/qpvvKk4RDzuBx21ohTeEM6SE8jnqIRjQEmVWhgqa5hgIfNeFYbFbvOJhtPkDCDo8zms0AREmRntccMDuA26qHsWqbI6k05jNxFOrfO5w5aT4g83JMT8fVedC6qk2Lvg2aTRyYwTENR5p2nKM1EEk6IpcHrFUQeav8QQb3faTVlQ4Vh4vUbR6RqpoZaqDhPoJYzhL2sXk5yKhsfLF22z21u6HF56d8yWHp/GZ/pSLW04sSAxQQcTif6cQ/OsO+kxRe8xiXiAWY2or/f1gKkq+2VeXiJVNO+3E14mAWt4fGoH3KkRZxWk8USXfLL2E/bGsJXnTms63sPSktDyXcUAn2kkBzenwL1RjvUa1GpxrGbLD5bKe5DBAZG8HQHeP92+6bd9sCfjdE15IsGij3tTddxjtxAnFIxH1VTDUSPx30l3gqwDHCRmusWg4ghW1825SmXH7fWYqqF7YjsAblA3ubjUQnMKUFKPw6BATOw6XzdkIELDtTzQ8EfhPGTZ3VSk79T7Q6UvBaoU0Wsukg3SsQzK2xjuyV43c9jb3Gk4j+yO8FDFEx9YivT6xVST4bezM/EyaRpkWl0Xd0wWXzIclGxEXexf5+26vktgWh1u9tyjqOUYRdaPWhwy2fHoix/16hgwh+PKKrhG14wFpa1Xs2OWcwpAXJszfF1XItDpdMUIDaLWx6/n7OuThTDxeLaF/HYVrvs7o0Z7LWFMpUrODrGHtKad8DxMsclBXowZHo/sa6wxbpu5L24px1iB24gDdODsWRYYPixrNHJC1clAFwBPaRIJIgQseOE3cCV2+kEXUohk03ZyriW+cJF X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c1af4aa-62f5-40a9-78f4-08dad130aa06 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 11:06:56.9563 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: snL9Tm364yF61xMRNOiPzJKEHXQy2BTVtlmTnsGpQMhnETKlJGiE8NXzcJiJUbtZTfa5VJrbXv7a0/hQ25slJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB6969 On Mon, Nov 28, 2022 at 09:21:47AM +0100, Jan Beulich wrote: > On 26.11.2022 23:19, Julien Grall wrote: > > On 25/11/2022 14:15, Per Bilse wrote: > >> A change to XAPI varstored causes > > > > For those unfamiliar with XAPI (like me), can you explain what was the > > change made? One ioreq client used by XenServer doesn't handle buffered ioreqs, so the broadcasted TIMEOFFSET always triggers an error due to that ioreq not handling it. While not harmful, it's still annoying to get the messages on the hypervisor console for something that's not really an error. The description can indeed be reworded to not mention XenServer specific components, something like: "Avoid printing an error message when a broadcast buffered ioreq is not handled by all registered clients, as long as the failure is strictly because the client doesn't handle buffered ioreqs." > >> an unnecessary error message > >> to be logged in hypervisor.log whenever an RTC timeoffset update > >> is broadcast. > >> In extreme cases this could flood the log file. > > > > Which should be ratelimited as this is using guest error loglevel. But I > > think this is irrelevant here. It would be more relevant to explain why > > it is OK to allow a partial broadcast. > > > >> This patch modifies ioreq_broadcast() to allow partial success. > > > > The commit message is quite vague, so it is hard to know what you are > > trying to solve exactly. AFAIU, there are two reasons for > > ioreq_broadcast to fails: > > 1) The IOREQ server didn't register the bufioreq > > 2) The IOREQ buffer page is full > > > > While I would agree that the error message is not necessary for 1) (the > > IOREQ server doesn't care about the event), I would disagree for 2) > > because it would indicate something went horribly wrong in the IOREQ > > server and there is a chance your domain may misbehave afterwards. > > In addition I think ignoring failure (and, as said by Julien, only because > of no bufioreq being registered) is (kind of implicitly) valid only for > buffered requests. Hence I'm unconvinced of the need of a new boolean > function parameter. Instead I think we need a new IOREQ_STATUS_... value > representing the "not registered" case. And that could then be used by > ioreq_broadcast() to skip incrementing of "failed". So introduce an IOREQ_STATUS_UNREGISTERED return code and don't increase failed if buffered == true and UNREGISTERED is returned, would that be acceptable? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Nov 28 11:30:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 11:30:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448894.705464 (Exim 4.92) (envelope-from ) id 1ozcL6-0003sw-Fs; Mon, 28 Nov 2022 11:30:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448894.705464; Mon, 28 Nov 2022 11:30:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozcL6-0003sp-D1; Mon, 28 Nov 2022 11:30:20 +0000 Received: by outflank-mailman (input) for mailman id 448894; Mon, 28 Nov 2022 11:30:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozcL5-0003sj-A9 for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 11:30:19 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 043d602e-6f10-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 12:30:15 +0100 (CET) Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Nov 2022 06:30:08 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by PH0PR03MB5909.namprd03.prod.outlook.com (2603:10b6:510:41::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 11:30:06 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%9]) with mapi id 15.20.5857.023; Mon, 28 Nov 2022 11:30:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 043d602e-6f10-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669635015; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=fREfZ7mYeQLWN7bIoWAFEH/L7Cx+tHA9T9VqiNcRLGY=; b=fhrN1Zr/RlhFIlaOnQnkoSMlAUQlAsPwx++QO5SxZcRws2K0BjZbPpM5 +KX2CFwdZTU1Psi7FR9OoRvwZi7KzjKcxH8ApfUEwQrEy3aq58flHRfGB 0YdzV9PLzbXH5o8I1VjutB3kIjPVbbTbNrYZEhHXpuFG5LBjAiXbuKYC3 c=; X-IronPort-RemoteIP: 104.47.55.173 X-IronPort-MID: 85678556 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5z/YW61noqFm4fH4RfbD5fdwkn2cJEfYwER7XKvMYLTBsI5bpzBUm GIaWTzVM/mNMTagLYh3b4znpEkD68SHyoI2QAs5pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVkNagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfK1lF9 84XOWkxbzvY1v3onvWlZ/Rpr5F2RCXrFNt3VnBI6xj8VKxja7aTBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvi6Kk1cZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r827GQzX6mBur+EpWqz/pn2Fuo2FYoDSYHZQGgp9qfl1KxDoc3x 0s8v3BGQbIJ3EuwVcXwRAH9qXKBvxg0S9dWC/c96gyG1uzT+QnxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+pQSiaPCEUKSoIY38CRA5cud37+ths1VTIU8ppF7OzgpvtAzbsz juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslRP+ZJu6TABYDn0Mt9 IronPort-HdrOrdr: A9a23:OMiR5aNn4GBGe8BcT6H255DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa DskPZvln6FQzA6f867Dn4KU6zqoMDKrovvZVorFgMq8w6HiBKv8frfHwKD1hkTfjtTyfN6mF K12TDR1+GGibWW2xXc32jc49B/n8bg8MJKAIihm9UYMTLljyevfcBEV6eZtD44jemz4BIBkc XKoT0nI8NvgkmhNV2dkF/I4U3NwTwu43jtxRuxhmbim9XwQHYfB9BajYxUXxPF4w541esMmJ 5j7ia8jd56HBnAlCPy65zhUAxrrFO9pT4HnfQIh3JSfIMCYPt6rJAZ/mlSDJAcdRiKobwPIa 1LNoXx9fxWeVSVYzTwuXRu+sWlWjAJEhKPUiE5y7mo+gkTuEo841oTxcQZkHtF3ok6UYN46+ PNNbktvK1ST+cNBJgNStspcI+SMCjgUBjMOGWdLRDMD6ccIU/ArJbx/fEc+PyqQpoV15E/8a 6xH2+wjVRCO34GNPf+n6Giqnv2MSeAtHXWu41jDqFCy/zBrOGBC1zHdLgs+/HQ0cn3TPerH8 pbA6gmc8MLHVGeZ7qh4DeOKqW6CUNuJPH96exLLG6mk4bsFrDAkND9XbL6GIfNeAxUKV8XRE FzEQTOGA== X-IronPort-AV: E=Sophos;i="5.96,200,1665460800"; d="scan'208";a="85678556" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gr17hoRGMrFajIpCFSFFeIgBFGN0+pUZRHNVo7364Ob+z3hVyKVE1+2jtDmLa/vL6DZaznQ03u+9+P64ev+Cv7rR869igpJRx9mnemC48cwbUdn9iC+t9fcIou3RF4N5E4oLP7peqnFsBbElaERwkOC6Ml0xZsDwQSfAbVR7Rbb94ho9QNuWHu4tDcPRxjeKTYtm4IHR0lGjb2ZMvk1A09pRiZ/IbJnJv2BdCkatgw2lrihPc0wf/T7WZLPyi+cHE1GkAWrIMvocxIsNBD8BIgEnz4z8FmxODQH+7OpyAd45W8YskH7QdoiGIlAXPryMfzH0j2X4dMH22UKUjBTqew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RRyfX8tY7H4YikjH9ohBs/i+15HlgxmwkoggvtYDfqM=; b=CEk2sYaXp4cJlQHEpwbq2EvoumKpxwLeic/ksvW5Gmw65mtZVQT0JApTwO3BmbjsPeP04mskzrdDHJZL6f1ghQ/7WQExHCQeLgw3GZ5cp6+l5j+h61cIljL/SB5BjPlqiVWx+Wvwi2Wbd0qBwJfs/iihKvOKNJjJVFg2CSpd/8ax84BXoFg/o943ykKYtE4Bm8sRP/6KlLFRtyBnJxOvJddaaqjfO10Vy0LD75bmiwZ4S1I0wNYHrbJtxpASq8RbbagN6rjXcd5dTQIggTgFBNgIttZW+N/26sD4m0qN5tOVCrBBde2j9JV+7tAJBoyjDkhWa99szhOBAZqRc+ZY8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RRyfX8tY7H4YikjH9ohBs/i+15HlgxmwkoggvtYDfqM=; b=h6V+up113B9YYFM72f1auTo5y7wYmLrg5f7x0w3roz+cdNMXxEk7T9GaZFrNDhHMdk2OwjjSwJ3B3t3bzYiWADN47OC7WLxdHQpz7MXEP0rHC1sGgcQWg1EpZ5YG/kj2cevWiTnbKzHudH2NHUu9u0nMesoSPjwmvRnzobGGwfY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 28 Nov 2022 12:30:01 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: osstest service owner Cc: xen-devel@lists.xenproject.org Subject: Re: [xen-unstable test] 174977: trouble: broken/fail/pass Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-ClientProxiedBy: LO4P265CA0074.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::13) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB5909:EE_ X-MS-Office365-Filtering-Correlation-Id: ebf31690-23f4-4f5f-2ce5-08dad133e639 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dtR9cGB9V4ciFvBjyKDXQ3aUGTys2UE2WrMyn4UpSKKOxeXI+PaZDU8DL0z9+CY8VRmoaJb55QAfscue3TAp/QgiwwrPKjzTi/2Oy9C/tKyYHI9utks7HbY43TG4O4bK4msDqusRwQKsNzR5xJokiD09Lupi0EDtlAmqVq7kc7oi7IRWNal6MBTnENmMOXay3/e0ZH//JxvrbtkSvN3Xh3/ZsCD+bnsc+9ldmQU6U9PKAdRfc+RFGarrmcieRHcdc3b7sP+zVeCVCYni6WHP9I8ia4KPfnBQX4PZD7VDO58xgXLKEFt77DJ5ieOdLRAwJ4NJaEgSpOSSRGzYhvmxbu/wR3hJ+BCiFxmc3QxRGui8jnU5oeSrc5E1Vk+HGsQ/k31CxBwleO6vlL0i+fHHnKRZ5eSZxHA8pnw1968Q8GswHszcTvp71OtW2SM5eBj+J6P8vwIb8zpZy+6WL8HwPfKiIriBKIQJya7fcmb5GRMqaVwhjhbckf8+rqJf1yeZbSY+F1i4PWiINu6CZhIcIOPNtGfoGl7OMmizccztUDnQi1MqIoGdxh7nRiehIRiPuOUuG63oy1QhMK4hVxYbhzA1MM6SOWM80AT1HhRxwNaAGaVzPzRvZ5aTp36mrbLxLUXQktpc5fIDDzKWhuv5R/pnS7p3nO8t0/KbbS8Ny92w5Rn0xkMCtlY90IGsnDF2VEsXuGmM7fz+VcMJ08cs3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(39860400002)(376002)(366004)(396003)(346002)(451199015)(2906002)(4326008)(85182001)(41300700001)(6916009)(66476007)(8676002)(186003)(66946007)(66556008)(316002)(8936002)(5660300002)(33716001)(9686003)(26005)(6512007)(86362001)(6666004)(6486002)(478600001)(966005)(6506007)(83380400001)(38100700002)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UURhNmNBbnZhRUEycnhLQkE5Mm16SStBc2ZDM09QbGMreWc3V1V4SXdIL1d4?= =?utf-8?B?UVBYbEJZTHM0a0JCY3VvdWZHNFJibnp6ZTRESE5IUVJkSW5uT3RNaThzTDB6?= =?utf-8?B?K0NCQSt2Mm9NRkFPbHZBR1J0VEtOK3VSNUFqQklvOE0raW11QnlPWW9DUHZu?= =?utf-8?B?NWE2QUplMi9LMWt3Q2JxcDBiSlFKanoyM3ZMNEtvQTZtcEVkRldoajg1SWl3?= =?utf-8?B?U3pTamNjSUZ3WUVpbXE2allNeEUybzFNQkFHTWtIcjhnZm1Fc210ZjMyYmIz?= =?utf-8?B?a2VDamhqbWlEVEM1QVBRdEwvLzA3eGRRZlJSKzlydW13dEtZWWZOcXpuOWNV?= =?utf-8?B?Y0xWZ1l0bGt1VW90dTFSU1FsTVc0V1JEdnB6SUh5dk5IUEt5NTQ4TjZrTjVh?= =?utf-8?B?czNUQXFER0RIOEZTKzNiR3d2Wk9OV3RmZU9nZWNodFd5Q1l3TFp2bFVTQkE5?= =?utf-8?B?M1l4SjQwcDlpMkRlNklHSW1naEppV0tvWUhEeTJQT2ExTUE0UzA3eW1QeTJ3?= =?utf-8?B?R282RU4yQlhuQVc2NDlsN3pFTlBIWCtmTjc3MUNZZUN0TGZhSlVKYlNYa1pV?= =?utf-8?B?R0VNSWVrT1Y5YXpjeS9KUWVVWlpvV0hsZGlXWXVqd1htU3JTUElIU3JzZU0v?= =?utf-8?B?Z2thM1RDa3BqQ1REcGZLdWRENWRwb3NVRFNKQTFIZVRzOEVybXJ2TDJXcHdo?= =?utf-8?B?WkNkcVdGbjhFcXl4aUNUdnBCc2FYaDdqeWRWdXpyRFN2dTJrMDdYV3VXeCs2?= =?utf-8?B?Sm9SM3VLRzBOd1B2K3EvSDN3UlB3aGlYTkRkV1ZmdisrSHVaZVRJNXZKeGd2?= =?utf-8?B?cURpcHJBRmFnaFZIZVhYcDBibDZ5ZHUreG9ZWm1jQlZUUmtuSmQ5bVo3blJu?= =?utf-8?B?K0dMRXNSRnNKMWhzbHZpNnZDYjI3a2Y3WlZ0QVlxVS9iN2dzbUVlekh4R1N1?= =?utf-8?B?bzFkME1sV29QcHgyYzlYcVN3blY1VkxRdWFvZnhJU0hub3JYSnNOcGt2QlBv?= =?utf-8?B?YTlVWDB1TmhPV1RYT1ZyaTFJeGJZenM3TkpteHdlQVBPd1ljSW9PVDVkRlJo?= =?utf-8?B?NVpRMTBZTmMxT09qaXc1Smx3dm9HakJCb2RjM0dUYXVyZ2I0Q2lqd2JsUUpy?= =?utf-8?B?c05PSXhLMUFxOEtSNVh6aGpHOGRvN1Y1YVBjbUdVZmF3LzlHeVRFalljdU14?= =?utf-8?B?MmQ0WW1xSTNtZi9tbXFJa0J1STJ5dFF4UjExTG5PcnZSVktlaDRkYVJJbnc0?= =?utf-8?B?UjllUlFCaVlXZ1Q1QUdCMTBBWFcyY0tXUHVoTEp6UCtUb1dhNjluUHFraHM3?= =?utf-8?B?L2pyQWJJMTBBclcvK2U0WEhQU1ZFV0pYMHVkM3dXa0c0WTRLcGpFR3RTTXMx?= =?utf-8?B?U2VqY1hpMWkyNUVXZ3ZqQVJIRmRLVXFmZ0VzbGFIeTBUM1VjS05CZ3NTZUtm?= =?utf-8?B?RHNxOUV3cEs5dmQzM3hXMDRpeEMwYlpQb0NGeFhrQ01TaGxURjJzdWpTYlg2?= =?utf-8?B?ei9rZWtqSDhrMG91VXdWbXRhMFpvSXdyT0hWSWdSWmprWDBCMEFaV2lVUHoy?= =?utf-8?B?bVlCaVJSS3JVNU1HdElORjJlR1pjNjFuMVJZd0NKZG9ucGdySEE3cytmWERC?= =?utf-8?B?YzM5RzF2ZzBnV01BUkVSVE14K0lDNFV5QUFTbWhvczRhd2MwNGdkdXRmcm9H?= =?utf-8?B?SW1lcmVkSGhadXdLN3pCcnRsUnZYQVZSVDhJUG5NUWx4MUlYUjFqK1J6N3Zr?= =?utf-8?B?byt3RkduS2NKcXhTcjRaYmllMHNpQkdqWXJESWVyUncwNEcxWHhhSXRUTEY0?= =?utf-8?B?aENSWFZUd2hZcnpVczJtUHVzSi9ZYzl6TVJZUTFhUnp5KzByUXp3Uk1SMUFj?= =?utf-8?B?MnhSYnNOTWhrTjNwNEs2RVhWZURGbGV1eTI0VXNzQkFPNlVmN0V4QjRnd21Y?= =?utf-8?B?N2lnc3JTZzhsQmNVdTZaZ3RpYjUxWkFxSnErTCtCK21iU1pocUhDbFg1dFVn?= =?utf-8?B?VTBDWmhYS0l5cGU3eS9VKzYrZllkUXFmekFZalRNSUxDYno2dFNHTCtTYUxu?= =?utf-8?B?Mk1qUGk5YUJ5cE54ZDVpWDRteWdhMFFueE5rWmZtTHZDenNNRjhOS0pUM2Qr?= =?utf-8?Q?RpLwUdJNdHQ4MA4oHTmRoe3sL?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: WmUw2biLqTN3OZzMcISNaIcobveMs1kb5uUTeaX80KMW3H7MajdjlNzoS6914vNscQhVAq6nqQH1589fd/FzBnuA161f7lWtAywxwXL0Vhv20Vg03+hMHfSboevryl4PPdeSBx37298BRzZ8cG2fMDmSW45Y0lZQq6wnHhqHL9/AQhrFFbDHlFsVcaHEYL+hBfrHFn88JcgE47hOyJhIxnYKRxdncGc4GA3mv1yz5VFB4xZHcp14CzOlFnUj1pgB1jvRPl3u2jdP+TekyREpDAtymllgFznXZYd5JaZDXV+0PjL3NiMLg2KZzTJELfUOw5OLi8V5BlraGWlrIL7KUVnwASKk2b47/1U3qwCSO/zDyQEpmRPmccii0iew4UPZoSf/ZuSxMY9rnyzg9fRZ8kb0mPXc5qrkwqWk5xf+dpndqoQR40aCFCuW0KYYBaW/2Sa1DdCC+CQxxC2wWAL6f9QwEhDm9TgkU8H71a1m5g1EC+75Tilh1NJl7Vmm9a+7FO3TGHMsyyfwR6gsqx6JX6xTsp/n240V66KoQv20wqV1YDFHuHwfmbfDNTflfuiTAt9nVAmo1Cgjh4EQ9yJbbENvPXNeLwI9hyX32boRs+BuGGiK2MdjMD7LAm7UhoSnYR9EI9xewA8NfoCw/J6MNbKvSMGNQp/vQ+fBxyNN1Ytw8DfgsWiuxWZelhW6sunJ4mbGdxIZVah2Zh8GshOBaq3Gee0TY8WWj+ZK1aifVvSqFsbeCkYcAcod6IlE5AVqc8QvuHta28IAwrvdC2BPgf3jCHSbI7SHs+p0ymDKdnbc/8GJBIPqdn6D+rUMEPNk X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebf31690-23f4-4f5f-2ce5-08dad133e639 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 11:30:06.5046 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OheSoD/xcek94CHiU/sgbhfzVIyTdJI6Xc01zyHdQ1iubm6wN29zL1dqMMsKsUGR07lS/Kl+sedSzwhHGG3PgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5909 On Mon, Nov 28, 2022 at 09:56:58AM +0000, osstest service owner wrote: > flight 174977 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/174977/ >=20 > Failures and problems with tests :-( >=20 > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-amd64-dom0pvh-xl-intel broken Looking at this, it seems like the dhcp server failed to provide a lease to the host: Nov 28 03:25:58.963432 Waiting for link-local address... ... 16%... 25%...= 33%... 41%=1B[H=1B[7m=1B[m=1B[32m=1B[40m[ =1B[37m=1B[31m (=1B[37= m1*installer=1B[31m)=1B[37m 2 shell 3 shell 4- log =1B[32m][= =1B[34m Nov 28 =1B[37m 3:26 =1B[32m]=1B[11;64H=1B[0m... 50%... 66%... 75%..= . 83%... 91%... 100%=0D Nov 28 03:26:02.023435 Configuring the network with DHCP ... 10%... 20%...= 30%=1B[H=1B[7m=1B[m=1B[32m=1B[40m[ =1B[37m=1B[31m (=1B[37m1*inst= aller=1B[31m)=1B[37m 2 shell 3 shell 4- log =1B[32m][=1B[34m N= ov 28 =1B[37m 3:27 =1B[32m]=1B[13;57H=1B[0m... 40%... 50%... 60%... 70%=1B[= H=1B[7m=1B[m=1B[32m=1B[40m[ =1B[37m=1B[31m (=1B[37m1*installer=1B= [31m)=1B[37m 2 shell 3 shell 4- log =1B[32m][=1B[34m Nov 28 = =1B[37m 3:28 =1B[32m]=1B[14;5H=1B[0m... 80%... 90%... 100%=0D Nov 28 03:28:31.059429 Configure the network=0D Nov 28 03:28:31.059446 ---------------------=0D Nov 28 03:28:31.071469 Nov 28 03:28:31.071478 Network autoconfiguration fai= led=0D Nov 28 03:28:31.071489 Nov 28 03:28:31.071492 Your network is probably not = using the DHCP protocol. Alternatively, the DHCP =0D Nov 28 03:28:31.083456 server may be slow or some network hardware is not w= orking properly.=0D Further jobs on the box seem to be OK, so it looks like a transient issue: http://logs.test-lab.xenproject.org/osstest/results/host/sabro0.html Roger. From xen-devel-bounces@lists.xenproject.org Mon Nov 28 12:26:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 12:26:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448904.705476 (Exim 4.92) (envelope-from ) id 1ozdD8-0001IR-NM; Mon, 28 Nov 2022 12:26:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448904.705476; Mon, 28 Nov 2022 12:26:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozdD8-0001IK-KJ; Mon, 28 Nov 2022 12:26:10 +0000 Received: by outflank-mailman (input) for mailman id 448904; Mon, 28 Nov 2022 12:26:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozdD7-0001IE-FI for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 12:26:09 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20610.outbound.protection.outlook.com [2a01:111:f400:7e1a::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d4cbabda-6f17-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 13:26:06 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7652.eurprd04.prod.outlook.com (2603:10a6:20b:285::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Mon, 28 Nov 2022 12:26:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Mon, 28 Nov 2022 12:26:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4cbabda-6f17-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IumXXaJuvLPJz7iC47EfVr8769kEj2bx1wEFiz85znb3hJnyKk/aIYjQEsRq9ql4txlcLZj0ndw2+n+zbuluGy0ZEuoOcQCmozdgMUjYDRXhFBg1iyKbD7cd8chWylLoWD+TBtHN8a1XskB5q+jS6jSCZ+a8GhgXkpz9O/6aQ2yxSX89wJg2bzLUI2i/Z7OTtHZFrtDQuZ4AmzTnIx5tEjLr88+6Cxu05bDe7JwekaEQxzZCAby7lTVsXQdD1weMb/GEDiUK3zx0FT9Jtz7/nXYvsLMH5zls/BQ/AdPG1enDctTpJ3DcbShh6HoxwNz+vMOGmAMbIbS9aKouTTkPVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vlZuMzQLGditnpPksVUQOp27+Utz9sSvY1bMDqLL+dc=; b=kzuvL9wLcZXwhnVed3iYt2rciFdGmiEu0uOEWf9FgRNFV50HVaEhsudPz0kMjbORfEJr//3HbCbp1UQv5/a5qQ1nL0NxmSfP26AYUAIWl6zBpWW2EvD/4ZM1P2TfWTAVW1quggoFTHlg+vlw2L20Gl2AV0Jy4z35G+uGDVRBhZtQp70TgHwmvCENT1vOMLR2YHe7nNa/BV5O0A4HVjnqBs5H3lTX1N1vBQu5CAJqWG2ltmgk5Ny4Ix+MD7E0TEA7Y80fMa2F+mq9ImnYMYpK9F5D1fsUTtM2bUU98bIMLqhLSlvRU0wmVLqWArYpVAvyBUGrNw2XVMp2N4u7OZ8TJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vlZuMzQLGditnpPksVUQOp27+Utz9sSvY1bMDqLL+dc=; b=0ZnJA9kH9ZnzouPrK2JZ6ZgCRwrPq/VAEb4jMSQfrkWeMEPtgUgWV0C0Z4a0B7Fm6UpErtHylWNumimElob+0ctIJJfEtyc5D+WrZ3UKqr+D27aPPxcI2DcPzLwj/QsF4LpJCIey6UsOUqc0X8j4ts4+KFuS89a3GGQ+ko7eZ0+gvtB5x9m9xzLqWJznVORDsgmBYdtsZJGZQB8JNo/nUxHls+075lHvwlxzkzWJ57kMvJdioOdvA0IljZrc4ZEIAz5N89CDdFAYN7Vn5yZiLjOw19eRUR0gSIwdeSoyaZz5IVF9TTI+NfRuRn3TG0xtVSfDne5mi/0SJGsbm8RKMg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 28 Nov 2022 13:26:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] ioreq_broadcast(): accept partial broadcast success Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Per Bilse , Paul Durrant , Andrew Cooper , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <06ad4b3a67a15192fc986b35e3f2fcd35b2f4c2f.1669383767.git.per.bilse@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7652:EE_ X-MS-Office365-Filtering-Correlation-Id: be0de8ce-b5a9-4cfc-adf5-08dad13bb851 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EVjkVq9CgHbhPhAPauwO640SrjJ5LobXaBvkNZ3jbqapPo7A6Q3iP+SGtGgepipxfPg4g63HjwW4Omv+zINNRjBlGZQE9z6DT0Zl15H5tyxPoLFwEHNvpxzIL3CsiyPRiHcqSNyQ7MIKFpgrf2S1XFrmdP/otySBWSewxHgSq+eurnL6qf+vEDRAlV9MLnY2YLWonp4Huk4P2hZWhuAHpDS7qtflp6o/wLW/wSoSWTVtD037t574rjDjby6aLWnNIdiS4gc8oIOi2+BR8lVLx16T5OIpm3jzVLNh5gZr6/JD6P2Ghd7FWfpu269sN5SxMpNtYRkcF6rSoaYJ6V0RlO3ruL1QupTdDnFzPsen5iQPNMzEg4noV4ufFOKI8iGmwBzbO8tznU2aA0OEU4gloIYhfmy359da/YMGxNmvVshxWWtp1+peuM379aKc+AVJVCuqh3Ta94ZyAHkkKW2SrSCjLl9S1IvrqBxqjlC2Arv46B0lH86PqTmn6kl9UA6D92krM/8M0zGQdwWszaDDaGFi+lxhmOQAbtczvMGMs5cVHIGHWa9dQUTCdqRMHfhRwDb5Rf9BPoJnWt7yIqSTMMMCOJ8g0Dmms9ASazYC54ptkhp8xulrBlSA464+vbCARQMnRkqZPRLVjmnAN6rs0y2/xLoNFB0rdxlKqnftpBkPKlDKJqwo5YsbnJ+Q74srjeBGU4LkampKj7Ba7j0RoJMB2Ih3I7an4gdGLR/R1Os= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(39860400002)(376002)(366004)(346002)(451199015)(36756003)(2906002)(31696002)(86362001)(6486002)(478600001)(53546011)(6506007)(316002)(66946007)(41300700001)(5660300002)(26005)(54906003)(66556008)(8676002)(6916009)(4326008)(8936002)(66476007)(6512007)(38100700002)(83380400001)(186003)(2616005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUcrWm5QU2JCTW5HSGx6cFZIbnlyOEtPTGVrVzVEcm5iTUFUZXVycGpzVHhC?= =?utf-8?B?L3JKWEVKMTl1amY5cVFwaDY3SWJQa2dtdHhRMnFIOVMvTmUvNnpZUUMrcDBM?= =?utf-8?B?NVBNRllPV0NzYlJna0RTcEhXbmdHakNmOHh5L0JGU3A2OXY4VTZLY0xKdXZO?= =?utf-8?B?NG5UR3k0Q2Z0enFTMmQvSzhWRmwzUjk4UG9mQ29hQjVVbTVwbHFXdDE4b25x?= =?utf-8?B?Si9ZdGlSV2d5TjNQVkhIZ1R4MGh4T0RkNU1uNi84K0ZRYno3L0FMdks1U1ZK?= =?utf-8?B?cFc3SGNjQlYrSittMHVTaWREVXNDMDNCL2wzS3VKRUFIbFpKeTMrbUlRdy9t?= =?utf-8?B?aERuRDdBS3VncDFpS0lNSW41dkN4eXd5VXpacXhaZzhWRHJaNHBKcmxyalNC?= =?utf-8?B?aUFBR1kwSzhWNEYxTWM4Wi9BWEdUM1pKdGlHMFV5aE82ZnRlcTNOcDZzOEtE?= =?utf-8?B?azdSWU9BRWs4eWNxS2FmKzV5QW41OHk4UEV3cStWLzloMzFKZzAyN0NDMW9y?= =?utf-8?B?WW43MUhPU3NWNUVZK3hDVHFKOElHc2NKaVQ2cC8yOEF6MFFlMG1OQTRBN0U2?= =?utf-8?B?emFkOUpkZ0l3cFV5WlFZeUFXK3llQjVQTHhnUDhBa0kxbGQ3Z21DT3RxMlcr?= =?utf-8?B?dTJpcEM3YTNrcjN4ZHRWYzdMd1hRZHp4WjFSbHcrQ2dON2pqaFNoNEpsaXV3?= =?utf-8?B?aHd6TVlvZWt0bS9oZXdwdGFvM3NVRHRBN1U5WGdzNHpyV3pzMDV2aHJnb1Ir?= =?utf-8?B?YUNkSVNIYUpRdzFaVVduOTIrdVo3cXV1cThPTzg3Q3hJcWlaakh1UUlRajB2?= =?utf-8?B?ZllSek9nazZCQ2VmOS9qeDVTQm9pcHorZm94UjVGVDlDWGJUblNyTWx6VTlE?= =?utf-8?B?M1pKbjNZa3JpdXM3OTFUbzJtV3A5M0R3ZkN4T3VOODZnd0JJOTgxVWpNTnhZ?= =?utf-8?B?ZWR5dzVkVEJCcWJVRkZWNmNoekZheWprTlZ2SmVEYnBFcVJYSHhmeVlPOTUy?= =?utf-8?B?YnUvU3UyTVp5VExxM3QvMTY2MGtSY2Rya1hnQXJQbis2MGtlY3NPRHBwTzNa?= =?utf-8?B?RlB2WDRPSnh0bW5xQXVka2pzWmxBWGlwODJGT3k5T1ZNS25ETi9peEJCVUdO?= =?utf-8?B?L3pOZlltQ3UvVHBsSHZMNjJIS09OWVJoQ3hPcGpUK1lEenR4UmhOckVZdWJm?= =?utf-8?B?ajdkOHhaTm16NG1zRWkzUis5NHMzTGxBWm02RG1La3RxMElvRld6a1NzcUtn?= =?utf-8?B?SlpKL29ubUZTZkFCQ2VzdXU4NEt0a2xzZlhzcVBiOC93OC93UDNiSlN3ZDlr?= =?utf-8?B?clJ3NWVZNHBzaEx6WlhUclRzVHJXODNVSWFZNU1wQ1VoUXNCMXA3UU1tWkxZ?= =?utf-8?B?SDlYM0ZicWc0eHhaN05UL3U2d0tIZncyTW1KcHFkak5HSzlXaDNHaWdEOCtS?= =?utf-8?B?RnllZnZ5alZtekx4a3JqUS93d3N2R0xHaHFhUWlmYWhuUUFPRm1LUi9nakFC?= =?utf-8?B?UU9vaEk3RXJNMzQ0cklnMHVvd2FidFYyUVI5ekNGRUUxZnI1dnJuYTlORW1m?= =?utf-8?B?NjJrVHhJZldIVVJuZVp5VkpmZlNnbUdjYnRCSUh6ZGJhcEcyVGJuQnFGdjJr?= =?utf-8?B?U2tQTXpkL2J3bENHdnQ5bEg1M0F4a1lLMzdibTFvcHJBUnVvMTFTeTcvQzVL?= =?utf-8?B?YmJSSUF1b0NiZ2ZoNTd4UU9LQmhTdi8xb0RoNFJzQzNoUjhYcGxWNGNOYnI1?= =?utf-8?B?M0N3T0pzZllQaWloNmhTZlZXRVdoRGlEeXZKSndSeitoQmJlaTc0dVVUQVEv?= =?utf-8?B?RTdsUnpITExCQ2VDNnI0SmF1aFRIR1k2eVlKUnZ1djBEc1VadDNURkJhcGo4?= =?utf-8?B?SFpMbDRHR2F6L2daeUtBVGgzclBYenl0YjRTUSt5Z1pOVUZmbEJEeXY2SFN4?= =?utf-8?B?WXgwaU5pbGo4T0xpM1FmV2RqL3RRUG5kWWs3UEZaTDY4ZVMzZzNmbjViNW5w?= =?utf-8?B?ZGdxS1BZMTZkcG1mbVRsVXpnS2ZSQnptTWtHT3pVOWg1TllWV1dlVCthZmd2?= =?utf-8?B?dnFoZWhWODlrRkRtblE0WWc3UHQ1cXN4dERlNFBpSzNocURPUkdpYVhWRGVB?= =?utf-8?Q?NegRr3ZStbNhy057F2L/WSoHw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: be0de8ce-b5a9-4cfc-adf5-08dad13bb851 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 12:26:05.3388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UjJkx6uAOWSwV3cFdNX9Ryu5pc3zo2AFYqxTzdKF9QGZoE7ww7AxplPEYqGO1ksmM/V7syKdO9b+TyTbL1XnKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7652 On 28.11.2022 12:06, Roger Pau Monné wrote: > On Mon, Nov 28, 2022 at 09:21:47AM +0100, Jan Beulich wrote: >> On 26.11.2022 23:19, Julien Grall wrote: >>> On 25/11/2022 14:15, Per Bilse wrote: >>>> This patch modifies ioreq_broadcast() to allow partial success. >>> >>> The commit message is quite vague, so it is hard to know what you are >>> trying to solve exactly. AFAIU, there are two reasons for >>> ioreq_broadcast to fails: >>> 1) The IOREQ server didn't register the bufioreq >>> 2) The IOREQ buffer page is full >>> >>> While I would agree that the error message is not necessary for 1) (the >>> IOREQ server doesn't care about the event), I would disagree for 2) >>> because it would indicate something went horribly wrong in the IOREQ >>> server and there is a chance your domain may misbehave afterwards. >> >> In addition I think ignoring failure (and, as said by Julien, only because >> of no bufioreq being registered) is (kind of implicitly) valid only for >> buffered requests. Hence I'm unconvinced of the need of a new boolean >> function parameter. Instead I think we need a new IOREQ_STATUS_... value >> representing the "not registered" case. And that could then be used by >> ioreq_broadcast() to skip incrementing of "failed". > > So introduce an IOREQ_STATUS_UNREGISTERED return code and don't > increase failed if buffered == true and UNREGISTERED is returned, > would that be acceptable? Yes afaic, but Paul is the maintainer of this code. And of course the new error indicator shouldn't surprise any existing callers. Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 28 12:32:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 12:32:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448910.705487 (Exim 4.92) (envelope-from ) id 1ozdJZ-0002nh-Da; Mon, 28 Nov 2022 12:32:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448910.705487; Mon, 28 Nov 2022 12:32:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozdJZ-0002na-Al; Mon, 28 Nov 2022 12:32:49 +0000 Received: by outflank-mailman (input) for mailman id 448910; Mon, 28 Nov 2022 12:32:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozdJX-0002nU-Op for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 12:32:48 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2061c.outbound.protection.outlook.com [2a01:111:f400:7e88::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c233ae56-6f18-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 13:32:45 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by DS7PR12MB5863.namprd12.prod.outlook.com (2603:10b6:8:7a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 12:32:41 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57%4]) with mapi id 15.20.5857.023; Mon, 28 Nov 2022 12:32:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c233ae56-6f18-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XfhWh/x1r5V3qgGpLVLFm/8YmJtnmE3wAQFTpJuiyODukpeAIMbYCDWD/5pMTbekWd1Wa+S5j+lPWz6Yv+eqECVb5+EOvs23PN8s8jiEe/haFyLNG1ZGXzJ2C74Jtv2gc42dWPIOFKMFQcSEZE2jfYvIv9XFCWLWRw3j5vaOEG0UDlfax6bnbxR9oTEnYjxIi/zhHuK9r8hpMUgwke4gLJZkEBpePE3FKCx4lhi4egBcwQX/VicDCqogVmGFtthVttljeD9otG3IMPbxLs6X1+twLA+kUeQE/mzlgJ4AGkkGOpPikNNogNEgdRF4rSPxza5dHxl37IgE+0QXRlOowA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BoxEh5LRVcud7DCQK4+ASWl7mfl+zMSuSSEO7THBMhQ=; b=SCNLgGa3BtXZX08QrARcsNl119u5ttyHTodMam06Dqk5JMZc0vo2B/lP15KzE3muNpPT+NVBx+fsogBpcIwTpDq6gAIeaOYFUvGJN5topCnd9UPDxldfewD1fFNSm9mwQqkVlvN+yWLnlerwZGVo0C+wgAHY2EZcNLIvGH1O9hhb7sDoH5kLpgULEPhQqzrLq8+Y7vj0A8fc/fE/hdyjeQqfE+Pq/8cIx3rIzOhQVvzPSpt5RnPirV4HEb3/ZR/D3VzTSpFfzudwQw5YaVhMgAGR5+T7KFkwdlQW7ffmHe1gT3K2TV1qtPvwHWluB7md7jmxsYb1tro6xCU42QFP1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BoxEh5LRVcud7DCQK4+ASWl7mfl+zMSuSSEO7THBMhQ=; b=gNWNf0q/DMstAgjIy5LZC2VnDDKntdnzHNoIkAWh/Qh6MUJIrRBurG9wkPzcdXTaEuCdI7lCUW4DF/OjwT2jg+VM1DPiHkFO3l4ckvFkcRAfHOMs+ehrzJsc95vSCRRCKVKQpz+9ui5MqCAKeJyhFBa/YXhrdY+THQ/G+0lAIOo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <35b3367b-5651-69a9-9218-82c15bc9c043@amd.com> Date: Mon, 28 Nov 2022 12:32:34 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN v3 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit To: Julien Grall , Xenia Ragiadakou , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com, jgrall@amazon.com References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-12-ayan.kumar.halder@amd.com> <3ea29174-abb4-0fe9-fde8-28d4d62f2f67@gmail.com> <96e799be-fc98-3457-2243-c979162e8a79@amd.com> <36c7f27d-10c7-b4fd-c775-a247660ec125@xen.org> From: Ayan Kumar Halder In-Reply-To: <36c7f27d-10c7-b4fd-c775-a247660ec125@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0204.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::24) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DS7PR12MB5863:EE_ X-MS-Office365-Filtering-Correlation-Id: e883f459-aa9c-4f67-78e1-08dad13ca3fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0L5XDJJHHM0Zm0rT9+gMzzpDjmSJLz4mL3CX1J5hBCMrLfdczAv1srzk/mKJbdtFcrMVSkxtNlnDBK5Qvv+1Qvaau0Inn01ppzmiOvEBs2MypDo21rTgwobIog/s6Cj9XCrNJTMwPk4I/JNWMhFqu/JnoMeFMsL2wkQJBSTXWGfmd3FdbjgC+a5d79/X1N/JIpkImty4WGrQfFgt7ckWTQb7F0zXuXsyzkR6xUEvtDBBybAq36p/hLgTdTrpA/singsdVGI7WdOb96SFkKd/iQIMBEFSV80DXev4GosHvFow6cMjZhfYJdzyjHzVLF6wSHRdIFmVtmwi48m7+g2jO5MlkCN70gR0+FDeTB6j/Cefi2hitE+OWEdAIfq6BCgf5mCc/8XS5i5DENqRl0Sl0Py9iiuzJK/c0+KEuiyn0zo8GVYtgXdEgo6p3xBJXeMFyYdf7LSOVsqQCfJNwtZJHkdjiNcPKweTzd+4aSF0zOjn7Fva9acjlW1it+lFUBCOFEOpFxZNxQYbseTlqKjQATDrFUkKWiWmKfLyMJW8xN5MdnOMNlWDDLMaeDIqZiMjVlj9/WcKR+yA8yikoCd3jFnjgTZNCDmPlPHZRQn6KqRGTUXM78EdMQhW9Nk/RqVLYZFsyrHA3EGV4DmzdaRJrs8WNAuUFSIeafAvhh0FG7V0oiGONTh6WKn7QUe1a/nxH0pAgS4OvCeBEdNTztrpkuPrSidxa4qmFsuRj5IeXds= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(39860400002)(376002)(136003)(346002)(451199015)(31696002)(6506007)(186003)(66946007)(53546011)(6512007)(41300700001)(8676002)(26005)(66556008)(8936002)(4326008)(66476007)(316002)(2616005)(478600001)(6486002)(6666004)(110136005)(38100700002)(31686004)(2906002)(83380400001)(5660300002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWNLckJoMGdPSDJkVm1xU1E1cTMvN1llblpSYXQ1R0RQRlZHUEZSbW1aYU9h?= =?utf-8?B?bm95ajRGN1BnVXBxQ015RnFsR2QzdTdHMk1NQXU2R2U1QWFPSHFESW1hbnJM?= =?utf-8?B?NFVPckZQZmF0TGM5anZVYnlvd25SVVNJOW1OUm9qVW9uSDJvazltSHByaVk5?= =?utf-8?B?M1hYOHJpSFhwT0JISGRNak1mVHNGbHNnemxyN2pIbU5oYmdVQVdqT1Y0bG45?= =?utf-8?B?MDhvZW12Ykk1MDk2VFNJaGJpMTdqcC9VZlE2eXg5VjltRUs0d1k5b0I1RXZ0?= =?utf-8?B?TURDN21ZYmZFUlZPTUptb1NSMmNjRkw1ZXdrMXloV2RTRDdkWlQ5dFlQTktI?= =?utf-8?B?QWZYU1o3Mk4rVU42a1BObkRKbjdFbndPUTdaL3dIUXY4eng1OERnTHFsOEZG?= =?utf-8?B?ZEFZTU54U2JZTWs0c3FwcWpETGRoZjRyWnVraXgyM3psRUExdWFnd3JBcFZI?= =?utf-8?B?SzlSTERSK1RlTlcxUExFOXhObU5SSk5wc2JhOVNCKzZsRld5ZTlMMzQ5UGdr?= =?utf-8?B?WE1rN1VaVERoRHV3MnNtNDhjR3hNMmFZbVIvYXRtV2lncFViTC85OTJjZ28w?= =?utf-8?B?aVJEV2ZIdUR0N0kxSEJLdG11UmlBK3hBY055NVNOYnIzdGpLMVhuNDUrd1g4?= =?utf-8?B?Mk1ranpZNkNRNGtaVTZRSGEvVzJ0ZThORlpDbEhNYXVDMUVDQ1c0VEJHc2U4?= =?utf-8?B?Z3pNbXdBTVp5M2ZjRHRzYXVnNlkwMC9BN1VoMm03MXlmWDZudW9wYmloN3lV?= =?utf-8?B?V3dCbVVoUmlwd3lQRHZqYUxkRFpTRC9WemMyYUJWdFhhY2pNVVl4TzFHTXV2?= =?utf-8?B?c2FxOVBtNjlZRHVMMWlRallOVFVOQlhOTWU3SFROakZwN1p0VjExQzNYbUNq?= =?utf-8?B?eFZEc09FRyszZzZaeURQVEZjUkR4a0U3YmNXQS9UaytYU3M2TS8ySERxeHJh?= =?utf-8?B?NXdsL1E2VkpiN0RZZXB1YlhHN2JEb1ZkVFJuc3pDb0NQd1RrTVpoQUZNVkZF?= =?utf-8?B?NTFud21jKzdTV1N5MGhWY0o5Z3NERXc2RFpWZ3huR0tSTGs0cTgrOVFyZTdV?= =?utf-8?B?TDE0UDFrS3d0aVVsTVhkV2dCNWpzemZXMEFrd0ovUTVqc2FWeitVTkhPTDNr?= =?utf-8?B?N0QwM2dxSXZ1T0orVGNta2w5cTZJMmVrRDZ1Q2IwbWI5YjdaTWxRTXE5N1RM?= =?utf-8?B?Q3JRRXU1SDZyeHBUZkxnWktldWc1a3JJcTU5ckFIMzQ4N3JrQkM1WFEraWJZ?= =?utf-8?B?UFVZcnVZSmNCNkxIK1AzNXQxdU1ieHR0aDZHd1h0TWZDTXRwUHM0UVNJdUt1?= =?utf-8?B?Y2owNVhzM2dLL0pocjdPM1htM2NOTlNCdTVWZ1J3MVdzOHd3MUNNNndrT2pS?= =?utf-8?B?emlhZEF1VDBSUkRZdXlNVktsUEZqOGw2VXJBQlBpUGlHWDdHM0lIbDZnMHRi?= =?utf-8?B?S25paUFGdUJyNXQ1TUNYa1NXaWV2SG1DVmd1citUc3FETnJwUmluOWE2OGV5?= =?utf-8?B?eWNZaG9jQ2V3YU5FaU40VHd1U2pnYk5yMzZ4VjF3L21KRitQWEs5aldBMzcz?= =?utf-8?B?dklKV29sUEZjb3ZqVEc2MTBKdXByMWgvZ2h4ZWNYMnNyL3lFMGg1N1VuM3VV?= =?utf-8?B?cjM1aDRXQU5tYzByUWlkVEhybGNmZHh5QWFSUmZ0aTJDNlJDeEUwR3kxb01P?= =?utf-8?B?ajEwZmRMM1Aza3Z0OEN5cC9WVDMyVnJYVjBqWTVQVnQ4WDZUMk1HclhRL0Vu?= =?utf-8?B?UEZiVWNzWnVnWit0ZHF5VThEMnlWcDI3UVl5Z2lrUTh6NEZZbmRQdDAxU2Vk?= =?utf-8?B?NldsMG9yV3UzaE4xU2E1enFhblNIKzJhT2N3Mml2NXVsYTd0SUEvSUJERE1K?= =?utf-8?B?V2ZUUEZHLyt2RmpYSForWkJpSFluTTZqejEwbU8yejk3TVdwMlovdzdzWEpZ?= =?utf-8?B?LzJDZEp3OUhVN3dxTnFpRXNkTDBTMVYxcU5DM1h3cGdYTXgxblFXczdVMVdk?= =?utf-8?B?ZFROUDVSSkFDa2hTN21PY0JmVGtHcVRlUXh6dHVDcWVaYk83Q1R2NHVvK2Nh?= =?utf-8?B?SXhlVmoySGVVWkl0TUxVRS9kTm8zM2JOcEQ3M0duUFpDb1ZyNnd5a3dDa0to?= =?utf-8?Q?I5sYIYk8H/1KbK3ZaQLMGilk+?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e883f459-aa9c-4f67-78e1-08dad13ca3fc X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 12:32:40.9571 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7CL17WdpJsH/Cy8oA5wilkjkDIlU3Q4YVKHnsCD+ZU09zeois6TLQ/TxL8uqL9XcXHkCISzLQZSpN5ELM46L9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5863 On 11/11/2022 17:53, Julien Grall wrote: > Hi, Hi Julien, I need a clarification. > > On 11/11/2022 17:37, Ayan Kumar Halder wrote: >> >> On 11/11/2022 16:17, Xenia Ragiadakou wrote: >>> Hi Ayan, >> Hi Xenia, >>> >>> On 11/11/22 16:17, Ayan Kumar Halder wrote: >>>> On AArch32, ldrd/strd instructions are not atomic when used to >>>> access MMIO. >>>> Furthermore, ldrd/strd instructions are not decoded by Arm when >>>> running as >>>> a guest to access emulated MMIO region. >>>> Thus, we have defined >>>> readq_relaxed_non_atomic()/writeq_relaxed_non_atomic() >>>> which in turn calls readl_relaxed()/writel_relaxed() for the lower >>>> and upper >>>> 32 bits. >>>> As GICv3 registers (GICD_IROUTER, GICR_TYPER) can be accessed in a >>>> non atomic >>>> fashion, so we have used {read/write}q_relaxed_non_atomic() on Arm32. >>>> >>>> Signed-off-by: Ayan Kumar Halder >>>> --- >>>> >>>> Changes from :- >>>> v1 - 1. Use ldrd/strd for readq_relaxed()/writeq_relaxed(). >>>> 2. No need to use le64_to_cpu() as the returned byte order is >>>> already in cpu >>>> endianess. >>>> >>>> v2 - 1. Replace {read/write}q_relaxed with >>>> {read/write}q_relaxed_non_atomic(). >>>> >>>>   xen/arch/arm/gic-v3.c               | 12 ++++++++++++ >>>>   xen/arch/arm/include/asm/arm32/io.h |  9 +++++++++ >>>>   2 files changed, 21 insertions(+) >>>> >>>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c >>>> index 6457e7033c..a5bc549765 100644 >>>> --- a/xen/arch/arm/gic-v3.c >>>> +++ b/xen/arch/arm/gic-v3.c >>>> @@ -651,7 +651,11 @@ static void __init gicv3_dist_init(void) >>>>       affinity &= ~GICD_IROUTER_SPI_MODE_ANY; >>>>         for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i++ ) >>>> +#ifdef CONFIG_ARM_32 >>>> +        writeq_relaxed_non_atomic(affinity, GICD + GICD_IROUTER + >>>> i * 8); >>>> +#else >>>>           writeq_relaxed(affinity, GICD + GICD_IROUTER + i * 8); >>>> +#endif > > I would have been OK if there was one place needed a #ifdef. But 2 is > a bit too much. > > Please provide a wrapper writeq_relaxed_non_atomic() for arm64. The > implementation would call writeq(). The same stands for... For arm64, why shouldn't we invoke {read/write}q_relaxed() for {read/write}q_relaxed_non_atomic() ? As I understand, this will be less expensive than invoking readq()/writeq() (as it will introduce memory barriers). Also, the original code was invoking {read/write}q_relaxed() for arm64. Please let me know if I am missing something ? - Ayan > >>>>   } >>>>     static int gicv3_enable_redist(void) >>>> @@ -745,7 +749,11 @@ static int __init gicv3_populate_rdist(void) >>>>           } >>>>             do { >>>> +#ifdef CONFIG_ARM_32 >>>> +            typer = readq_relaxed_non_atomic(ptr + GICR_TYPER); >>>> +#else >>>>               typer = readq_relaxed(ptr + GICR_TYPER); >>>> +#endif > > ... here. > >>>>                 if ( (typer >> 32) == aff ) >>>>               { >>>> @@ -1265,7 +1273,11 @@ static void gicv3_irq_set_affinity(struct >>>> irq_desc *desc, const cpumask_t *mask) >>>>       affinity &= ~GICD_IROUTER_SPI_MODE_ANY; >>>>         if ( desc->irq >= NR_GIC_LOCAL_IRQS ) >>>> +#ifdef CONFIG_ARM_32 >>>> +        writeq_relaxed_non_atomic(affinity, (GICD + GICD_IROUTER + >>>> desc->irq * 8)); >>>> +#else >>>>           writeq_relaxed(affinity, (GICD + GICD_IROUTER + desc->irq >>>> * 8)); >>>> +#endif >>>>         spin_unlock(&gicv3.lock); >>>>   } >>>> diff --git a/xen/arch/arm/include/asm/arm32/io.h >>>> b/xen/arch/arm/include/asm/arm32/io.h >>>> index 73a879e9fb..4ddfbea5c2 100644 >>>> --- a/xen/arch/arm/include/asm/arm32/io.h >>>> +++ b/xen/arch/arm/include/asm/arm32/io.h >>>> @@ -80,17 +80,26 @@ static inline u32 __raw_readl(const volatile >>>> void __iomem *addr) >>>>                                           __raw_readw(c)); __r; }) >>>>   #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \ >>>>                                           __raw_readl(c)); __r; }) >>>> +#define readq_relaxed_non_atomic(c) \ >>>> +                         ({ u64 __r = (((u64)readl_relaxed((c) + >>>> 4)) << 32) | \ >>>> + readl_relaxed(c); __r; }) >>> >>> As Julien pointed out, the expression c will be evaluated twice and >>> if it produces side effects they will be performed twice. >>> To prevent this, you can either assign the expression to a local >>> variable and pass this one to readl_relaxed() >> >> Just to make sure I understand you correctly, you are suggesting this :- >> >> #define readq_relaxed_non_atomic(c) \ >> >>                          ({ void _iomem *__addr = (c); \ >> >>                              u64 __r = (((u64)readl_relaxed(__addr + >> 4)) << 32) | \ >> >> readl_relaxed(__addr); __r; }) >> >> #define writeq_relaxed_non_atomic(v,c) \ >> >>                         (( u64 __v = (v); \ >> >>                            void _iomem *__addr = (c); \ >> >>                            writel_relaxed((u32)__v, __addr); \ >> >>                            writel_relaxed((u32)((__v) >> 32), (__addr >> + 4); }) > > >> >> Is this correct understanding ? >> >>> or use a static inline function instead of a macro, for implementing >>> readq_relaxed_non_atomic(). >>> The latter is the MISRA C recommended (not strictly required) >>> approach according to Dir 4.9 "A function should be used in >>> preference to a function-like macro where >>>  they are interchangeable". >> >> I have mixed opinion about this. >> >> On one hand, there will be a performance penalty when invoking a >> function (compared to macro). > > Most of the compilers are nowadays clever enough to inline small > functions. But we can force the compiler with the attribute > always_inline. > >> >> On the other hand {readq/writeq}_relaxed_non_atomic() are called >> during init (gicv3 initialization, setting up the interrupt >> handlers), so the impact will not be bad. >> >> I am fine with whatever you and any maintainer suggest. > > Project wide, we are trying to use "static inline" whenever it is > possible because it adds a bit more type-safety (the error you made > wouldn't have happened) and the code is clearer (no slash). > > So my preference is to use static line. > > Cheers, > From xen-devel-bounces@lists.xenproject.org Mon Nov 28 13:45:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 13:45:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448920.705497 (Exim 4.92) (envelope-from ) id 1ozeRF-00024n-Ku; Mon, 28 Nov 2022 13:44:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448920.705497; Mon, 28 Nov 2022 13:44:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozeRF-00024g-IJ; Mon, 28 Nov 2022 13:44:49 +0000 Received: by outflank-mailman (input) for mailman id 448920; Mon, 28 Nov 2022 13:44:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozeRE-00024a-97 for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 13:44:48 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d09f925f-6f22-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 14:44:45 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7FA6B5C0136; Mon, 28 Nov 2022 08:44:43 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 28 Nov 2022 08:44:43 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Nov 2022 08:44:42 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d09f925f-6f22-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1669643083; x= 1669729483; bh=me2xJR9KwKVEE8ktVSM+nRFnWYDYu52Yxlt4XSskicY=; b=U TTF3+0y5QEh9eH+LuP/VNDq2iKlI7mS5r74wvlOCIjiPzgyU6/nT7420hiJ6t4ma EV6YNmoy4n4KAy/P3svfsw/q7OX0rTxX/toJpi4KCX4PZ/LiiAIpR7YN2toZLKC8 yOa56dF84TJqwt4+Q5L0ClwItRhUdRU3OxB4I/O3kPBhLqLV5DVReG82SEpOugkY jyvALZKIakZICYu1fIdYzXl2kASWWqIb6pVXnpX4sD5rTcaBdTw2vfeOlHb2GoPO 79bcI82YbOcYLsZNCMYd0mBSoEHH6A7wOeJS2VqLE36ugfOyGKQ18GZ82JK/yLWF 31MMyFby1Cl6HonQZKcnQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1669643083; x=1669729483; bh=me2xJR9KwKVEE8ktVSM+nRFnWYDY u52Yxlt4XSskicY=; b=xN2M/q4xDa1cSYUbAuKlhx+Uh4BZxc0Nulb5ZP7y49JN xFuBr9LtQybNzFW3ttFnH9nxvItGjdi8dwkcJFHeyDUpCyJxrosev52oL6faznJG fBsOfVgJUOUeP+OkQB3YTheC/z879+9Wr56wereGH/u8HlSk3qUYByTTOdJ+cP5a BhGTFdnE3IDIWsXBqZi1r+V2Pk4j9zvV3RamZrA3utQ6supI1oN1a4Q6DzeB6R8D iA6v8BorjyZMUidtu0I7/sznLffJ7pCJzMK4PPImUmZOA1Uomk13R/g4TldhC4JQ 1yvNwrU6uRJ6V1BRiYfsPrGAynpaNInKOiaFgX3y7w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrjedvgdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 28 Nov 2022 14:44:39 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jason Andryuk Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Subject: Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled Message-ID: References: <20221118154931.1928298-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aozQvSbj7iUV5V+i" Content-Disposition: inline In-Reply-To: --aozQvSbj7iUV5V+i Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 28 Nov 2022 14:44:39 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jason Andryuk Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Subject: Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled On Mon, Nov 21, 2022 at 05:16:37PM +0100, Marek Marczykowski-G=C3=B3recki w= rote: > On Mon, Nov 21, 2022 at 10:41:34AM -0500, Jason Andryuk wrote: > > On Sat, Nov 19, 2022 at 11:33 AM Marek Marczykowski-G=C3=B3recki > > wrote: > > > > > > On Sat, Nov 19, 2022 at 09:36:54AM -0500, Jason Andryuk wrote: > > > > Hi, Marek, > > > > > > > > On Fri, Nov 18, 2022 at 4:46 PM Marek Marczykowski-G=C3=B3recki > > > > wrote: > > > > > > > > > > On Fri, Nov 18, 2022 at 03:46:47PM -0500, Jason Andryuk wrote: > > > > > > I was trying to test your xen-pciback v3 patch, and I am having > > > > > > assignment fail consistently now. It is actually failing to > > > > > > quarantine to domIO in the first place, which matches the failu= re from > > > > > > the other day (when I more carefully read through the logs). I= t now > > > > > > consistently fails to quarantine on every boot unlike the other= day > > > > > > where it happened once. > > > > > > > > > > Does this include the very first assignment too, or only after do= main > > > > > reboot? If the latter, maybe some cleanup missed clearing MASKALL? > > > > > > > > It's the quarantine during dom0 boot that fails. Later assignment > > > > during VM boot fails. I tried warm reboots and cold boots and it > > > > happened both times. > > > > > > > > I also modified my initrd to halt in there and checked the config > > > > space. MASKALL wasn't set at that time. I need to double check - > > > > MASKALL may have been unset after dom0 booted in that case. > > > > > > > > I'll test more to figure when and how MASKALL is getting set. > >=20 > > I'm testing with a laptop without a battery. It seems MASKALL remains > > set when rebooting or when left plugged in. > >=20 > > From unplugged, a cold boot doesn't have MASKALL set and the network vm= boots. > >=20 > > After that, rebooting the laptop leaves MASKALL set on the NIC when > > the laptop reboots. NIC assignment fails. > >=20 > > Shutdown and later boot while left plugged in keeps MASKALL set. NIC > > assignment fails. I have only tested this scenario for short periods > > of time, so I don't know if it would eventually clear after a longer > > time. >=20 > That's interesting, seems like firmware is not resetting the device > properly. Maybe related to enabled wake on lan? >=20 > Anyway, resetting the device at domain create/destroy is AFAIR normally > done by pciback (at the instruction by the toolstack). Should it maybe > be done when assigning to pciback initially too? Or maybe in this > specific case, device reset doesn't properly clear MASKALL, so pciback > should clear it explicitly (after ensuring the MSI-X enable is cleared > too)? Can you check if `echo 1 > /sys/bus/pci/devices/$SBDF/reset` clears MASKALL on this device? I'm tempted to add libxl__device_pci_reset() as part of libxl__device_pci_assignable_add(). --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --aozQvSbj7iUV5V+i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmOEu0cACgkQ24/THMrX 1ywlKQgAjmX9f7oEMMKhPvTU9Cwer1pxYt/jaRfYJThGAZvH/4w7VkyNInSN2u6G 7obNR47Rju6OXU1j7JOO5uW6DDQ6oo4tyRzYUpJl3a0QVSRpTgSN32eisomrGSSB 1/TU7XFcKS+ZBXJaRqq6whhdiXwFRuPhuO96pd4JVcxRoL2ocGzS/3B01Vv4OF5N 0bamXgj9FFQvUcXHcQRWzwj/mjOShwe/dYeDjaAmCf4kKJBAX5TJg3mEu3e7yz3d MiKHnU0bLSOC38cW3/XMs16NH3cMYD48ickM7Eca5PmZAX7wQrAeCJiVBuH8IHPR ZlSWFUeLsMnImI4snXIT4aex+c/2Mw== =Yg9M -----END PGP SIGNATURE----- --aozQvSbj7iUV5V+i-- From xen-devel-bounces@lists.xenproject.org Mon Nov 28 14:10:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 14:10:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448935.705534 (Exim 4.92) (envelope-from ) id 1ozeqB-0006OR-Os; Mon, 28 Nov 2022 14:10:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448935.705534; Mon, 28 Nov 2022 14:10:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozeqB-0006NF-LM; Mon, 28 Nov 2022 14:10:35 +0000 Received: by outflank-mailman (input) for mailman id 448935; Mon, 28 Nov 2022 14:10:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozeqA-0005sM-H1 for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 14:10:34 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6c63401c-6f26-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 15:10:33 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 13D5ED6E; Mon, 28 Nov 2022 06:10:40 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 495643F73D; Mon, 28 Nov 2022 06:10:32 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c63401c-6f26-11ed-91b6-6bf2151ebd3b From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h Date: Mon, 28 Nov 2022 14:10:06 +0000 Message-Id: <20221128141006.8719-5-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128141006.8719-1-luca.fancellu@arm.com> References: <20221128141006.8719-1-luca.fancellu@arm.com> Eclair and Coverity found violation of the MISRA rule 8.6 for the symbols _start, _end, start, _stext, _etext, _srodata, _erodata, _sinittext, _einittext which are declared in xen/include/xen/kernel.h. All those symbols are defined by the liker script so we can deviate from the rule 8.6 for these cases. Signed-off-by: Luca Fancellu --- docs/misra/safe.json | 9 +++++++++ xen/include/xen/kernel.h | 4 ++++ 2 files changed, 13 insertions(+) diff --git a/docs/misra/safe.json b/docs/misra/safe.json index e079d3038120..e3c8a1d8eb36 100644 --- a/docs/misra/safe.json +++ b/docs/misra/safe.json @@ -3,6 +3,15 @@ "content": [ { "id": "SAF-0-safe", + "analyser": { + "eclair": "MC3R1.R8.6", + "coverity": "misra_c_2012_rule_8_6_violation" + }, + "name": "Rule 8.6: linker script defined symbols", + "text": "It is safe to declare this symbol because it is defined in the linker script." + }, + { + "id": "SAF-1-safe", "analyser": {}, "name": "Sentinel", "text": "Next ID to be used" diff --git a/xen/include/xen/kernel.h b/xen/include/xen/kernel.h index 8cd142032d3b..f1a7713784fc 100644 --- a/xen/include/xen/kernel.h +++ b/xen/include/xen/kernel.h @@ -65,24 +65,28 @@ 1; \ }) +/* SAF-0-safe */ extern char _start[], _end[], start[]; #define is_kernel(p) ({ \ char *__p = (char *)(unsigned long)(p); \ (__p >= _start) && (__p < _end); \ }) +/* SAF-0-safe */ extern char _stext[], _etext[]; #define is_kernel_text(p) ({ \ char *__p = (char *)(unsigned long)(p); \ (__p >= _stext) && (__p < _etext); \ }) +/* SAF-0-safe */ extern const char _srodata[], _erodata[]; #define is_kernel_rodata(p) ({ \ const char *__p = (const char *)(unsigned long)(p); \ (__p >= _srodata) && (__p < _erodata); \ }) +/* SAF-0-safe */ extern char _sinittext[], _einittext[]; #define is_kernel_inittext(p) ({ \ char *__p = (char *)(unsigned long)(p); \ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 14:10:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 14:10:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448933.705519 (Exim 4.92) (envelope-from ) id 1ozeqA-00064m-2y; Mon, 28 Nov 2022 14:10:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448933.705519; Mon, 28 Nov 2022 14:10:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozeq9-00064f-W9; Mon, 28 Nov 2022 14:10:34 +0000 Received: by outflank-mailman (input) for mailman id 448933; Mon, 28 Nov 2022 14:10:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozeq8-0005sM-H6 for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 14:10:32 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 69f9019d-6f26-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 15:10:29 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A9D9E1063; Mon, 28 Nov 2022 06:10:35 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C3CF53F73D; Mon, 28 Nov 2022 06:10:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69f9019d-6f26-11ed-91b6-6bf2151ebd3b From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 1/4] xen/scripts: add xen-analysis.py for coverity and eclair analysis Date: Mon, 28 Nov 2022 14:10:03 +0000 Message-Id: <20221128141006.8719-2-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128141006.8719-1-luca.fancellu@arm.com> References: <20221128141006.8719-1-luca.fancellu@arm.com> Add new script for coverity/eclair analysis tool that will enable the procedure to suppress findings when these tool are used. The procedure is documented in docs/misra/documenting-violations.rst and the script is documented in docs/misra/xen-static-analysis.rst. Add in docs/misra/ the files safe.json and false-positive-{coverity,eclair}.json that are JSON files containing the data structures for the justifications, they are used by the analysis script to link the Xen tags to the proprietary tool comment. Add docs/misra/documenting-violations.rst to explain how to add justifications. Add docs/misra/xen-static-analysis.rst to explain how to use the script to analyse Xen. Add analysis artifacts files to .gitignore. Signed-off-by: Luca Fancellu --- .gitignore | 1 + docs/misra/documenting-violations.rst | 191 +++++++++++++++++++ docs/misra/false-positive-coverity.json | 12 ++ docs/misra/false-positive-eclair.json | 12 ++ docs/misra/safe.json | 11 ++ docs/misra/xen-static-analysis.rst | 54 ++++++ xen/scripts/xen-analysis.py | 31 +++ xen/scripts/xen_analysis/__init__.py | 0 xen/scripts/xen_analysis/generic_analysis.py | 93 +++++++++ xen/scripts/xen_analysis/settings.py | 97 ++++++++++ xen/scripts/xen_analysis/tag_database.py | 109 +++++++++++ xen/scripts/xen_analysis/utils.py | 37 ++++ 12 files changed, 648 insertions(+) create mode 100644 docs/misra/documenting-violations.rst create mode 100644 docs/misra/false-positive-coverity.json create mode 100644 docs/misra/false-positive-eclair.json create mode 100644 docs/misra/safe.json create mode 100644 docs/misra/xen-static-analysis.rst create mode 100755 xen/scripts/xen-analysis.py create mode 100644 xen/scripts/xen_analysis/__init__.py create mode 100644 xen/scripts/xen_analysis/generic_analysis.py create mode 100644 xen/scripts/xen_analysis/settings.py create mode 100644 xen/scripts/xen_analysis/tag_database.py create mode 100644 xen/scripts/xen_analysis/utils.py diff --git a/.gitignore b/.gitignore index ea3243af9dde..f5a66f6194dd 100644 --- a/.gitignore +++ b/.gitignore @@ -10,6 +10,7 @@ *.c.cppcheck *.opic *.a +*.safparse *.so *.so.[0-9]* *.bin diff --git a/docs/misra/documenting-violations.rst b/docs/misra/documenting-violations.rst new file mode 100644 index 000000000000..1d23447556d2 --- /dev/null +++ b/docs/misra/documenting-violations.rst @@ -0,0 +1,191 @@ +.. SPDX-License-Identifier: CC-BY-4.0 + +Documenting violations +====================== + +Static analysers are used on the Xen codebase for both static analysis and MISRA +compliance. +There might be the need to suppress some findings instead of fixing them and +many tools permit the usage of in-code comments that suppress findings so that +they are not shown in the final report. + +Xen includes a tool capable of translating a specific comment used in its +codebase to the right proprietary in-code comment understandable by the selected +analyser that suppress its finding. + +In the Xen codebase, these tags will be used to document and suppress findings: + + - SAF-X-safe: This tag means that the next line of code contains a finding, but + the non compliance to the checker is analysed and demonstrated to be safe. + - SAF-X-false-positive-: This tag means that the next line of code + contains a finding, but the finding is a bug of the tool. + +SAF stands for Static Analyser Finding, the X is a placeholder for a positive +number that starts from zero, the number after SAF- shall be incremental and +unique, base ten notation and without leading zeros. + +Entries in the database shall never be removed, even if they are not used +anymore in the code (if a patch is removing or modifying the faulty line). +This is to make sure that numbers are not reused which could lead to conflicts +with old branches or misleading justifications. + +An entry can be reused in multiple places in the code to suppress a finding if +and only if the justification holds for the same non-compliance to the coding +standard. + +An orphan entry, that is an entry who was justifying a finding in the code, but +later that code was removed and there is no other use of that entry in the code, +can be reused as long as the justification for the finding holds. This is done +to avoid the allocation of a new entry with exactly the same justification, that +would lead to waste of space and maintenance issues of the database. + +The files where to store all the justifications are in xen/docs/misra/ and are +named as safe.json and false-positive-.json, they have JSON format, each +one has a different justification schema which shares some fields. + +Here is an example to add a new justification in safe.json:: + +|{ +| "version": "1.0", +| "content": [ +| { +| "id": "SAF-0-safe", +| "analyser": { +| "coverity": "misra_c_2012_rule_20_7_violation", +| "eclair": "MC3R1.R20.7" +| }, +| "name": "R20.7 C macro parameters not used as expression", +| "text": "The macro parameters used in this [...]" +| }, +| { +| "id": "SAF-1-safe", +| "analyser": {}, +| "name": "Sentinel", +| "text": "Next ID to be used" +| } +| ] +|} + +To document a finding in safe.json, just add another block {[...]} before the +sentinel block, using the id contained in the sentinel block and increment by +one the number contained in the id of the sentinel block. + +Here is an explanation of the fields inside an object of the "content" array: + - id: it is a unique string that is used to refer to the finding, many finding + can be tagged with the same id, if the justification holds for any applied + case. + It tells the tool to substitute a Xen in-code comment having this structure: + /* SAF-0-safe [...] \*/ + - analyser: it is an object containing pair of key-value strings, the key is + the analyser, so it can be coverity or eclair, the value is the proprietary + id corresponding on the finding, for example when coverity is used as + analyser, the tool will translate the Xen in-code coment in this way: + /* SAF-0-safe [...] \*/ -> /* coverity[misra_c_2012_rule_20_7_violation] \*/ + if the object doesn't have a key-value, then the corresponding in-code + comment won't be translated. + - name: a simple name for the finding + - text: a proper justification to turn off the finding. + + +Here is an example to add a new justification in false-positive-.json:: + +|{ +| "version": "1.0", +| "content": [ +| { +| "id": "SAF-0-false-positive-", +| "violation-id": "", +| "tool-version": "", +| "name": "R20.7 [...]", +| "text": "[...]" +| }, +| { +| "id": "SAF-1-false-positive-", +| "violation-id": "", +| "tool-version": "", +| "name": "Sentinel", +| "text": "Next ID to be used" +| } +| ] +|} + +To document a finding in false-positive-.json, just add another block +{[...]} before the sentinel block, using the id contained in the sentinel block +and increment by one the number contained in the id of the sentinel block. + +Here is an explanation of the fields inside an object of the "content" array: + - id: it has the same meaning as in the "safe" justification schema. + It tells the tool to substitute a Xen in-code comment having this structure: + /* SAF-0-false-positive- [...] \*/ + - violation-id: its value is a string containing the proprietary id + corresponding to the finding, for example when is coverity, the Xen + tool will translate the Xen in-code coment in this way: + /* SAF-0-false-positive-coverity [...] \*/ -> /* coverity[misra_c_2012_rule_20_7_violation] \*/ + if the object doesn't have a value, then the corresponding in-code comment + won't be translated. + - tool-version: the version of the tool affected by the false positive, if it + is discovered in more than one version, this string can be a range + (eg. 2.7 - 3.0) + - name, text: they have the same meaning as in the "safe" justification schema. + + +Justification example +--------------------- + +Here an example of the usage of the in-code comment tags to suppress a finding +for the Rule 8.6: + +Eclair reports it in its web report, file xen/include/xen/kernel.h, line 68: + +| MC3R1.R8.6 for program 'xen/xen-syms', variable '_start' has no definition + +Also coverity reports it, here is an extract of the finding: + +| xen/include/xen/kernel.h:68: +| 1. misra_c_2012_rule_8_6_violation: Function "_start" is declared but never + defined. + +The analysers are complaining because we have this in xen/include/xen/kernel.h +at line 68:: + +| extern char _start[], _end[], start[]; + +Those are symbols exported by the linker, hence we will need to have a proper +deviation for this finding. + +We will prepare our entry in the safe.json database:: + +|{ +| "version": "1.0", +| "content": [ +| { +| [...] +| }, +| { +| "id": "SAF-1-safe", +| "analyser": { +| "eclair": "MC3R1.R8.6", +| "coverity": "misra_c_2012_rule_8_6_violation" +| }, +| "name": "Rule 8.6: linker script defined symbols", +| "text": "It is safe to declare this symbol because it is defined in the linker script." +| }, +| { +| "id": "SAF-2-safe", +| "analyser": {}, +| "name": "Sentinel", +| "text": "Next ID to be used" +| } +| ] +|} + +And we will use the proper tag above the violation line:: + +| /* SAF-1-safe R8.6 linker defined symbols */ +| extern char _start[], _end[], start[]; + +This entry will fix also the violation on _end and start, because they are on +the same line and the same "violation ID". + +Also, the same tag can be used on other symbols from the linker that are +declared in the codebase, because the justification holds for them too. diff --git a/docs/misra/false-positive-coverity.json b/docs/misra/false-positive-coverity.json new file mode 100644 index 000000000000..462448414f80 --- /dev/null +++ b/docs/misra/false-positive-coverity.json @@ -0,0 +1,12 @@ +{ + "version": "1.0", + "content": [ + { + "id": "SAF-0-false-positive-coverity", + "violation-id": "", + "tool-version": "", + "name": "Sentinel", + "text": "Next ID to be used" + } + ] +} diff --git a/docs/misra/false-positive-eclair.json b/docs/misra/false-positive-eclair.json new file mode 100644 index 000000000000..1d6ea5d7f045 --- /dev/null +++ b/docs/misra/false-positive-eclair.json @@ -0,0 +1,12 @@ +{ + "version": "1.0", + "content": [ + { + "id": "SAF-0-false-positive-eclair", + "violation-id": "", + "tool-version": "", + "name": "Sentinel", + "text": "Next ID to be used" + } + ] +} diff --git a/docs/misra/safe.json b/docs/misra/safe.json new file mode 100644 index 000000000000..e079d3038120 --- /dev/null +++ b/docs/misra/safe.json @@ -0,0 +1,11 @@ +{ + "version": "1.0", + "content": [ + { + "id": "SAF-0-safe", + "analyser": {}, + "name": "Sentinel", + "text": "Next ID to be used" + } + ] +} diff --git a/docs/misra/xen-static-analysis.rst b/docs/misra/xen-static-analysis.rst new file mode 100644 index 000000000000..5b886474d4a0 --- /dev/null +++ b/docs/misra/xen-static-analysis.rst @@ -0,0 +1,54 @@ +.. SPDX-License-Identifier: CC-BY-4.0 + +Xen static analysis +=================== + +The Xen codebase integrates some scripts and tools that helps the developer to +perform static analysis of the code, currently Xen supports three analysis tool +that are eclair, coverity and cppcheck. +The Xen tree has a script (xen-analysis.py) available to ease the analysis +process and it integrates a way to suppress findings on these tools (only Eclair +and Coverity are currently supported by the script), please check the +documenting-violation.rst document to know more about it. + +Analyse Xen with Coverity or Eclair +----------------------------------- + +The xen-analysis.py script has two arguments to select which tool is used for +the analysis: + + - xen-analysis.py --run-coverity -- [optional make arguments] + - xen-analysis.py --run-eclair -- [optional make arguments] + +For example when using Coverity to analyse a Xen build obtained by passing these +arguments to the make system: XEN_TARGET_ARCH=arm64 +CROSS_COMPILE=aarch64-linux-gnu-, the optional make arguments passed to +xen-analysis.py must be the same and the command below should be passed to +Coverity in its build phase: + + - xen-analysis.py --run-coverity -- XEN_TARGET_ARCH=arm64 + CROSS_COMPILE=aarch64-linux-gnu- + +Which tells to the script to prepare the codebase for an analysis by Coverity +and forwards the make arguments to the make build invocation. + +When invoking the script, the procedure below will be followed: + + 1. Find which files among \*.c and \*.h has any in-code comment as + /* SAF-X-[...] \*/, the meaning of these comments is explained in + documenting-violation.rst. + Save the files obtained as .safparse and generate files where + the special in-code comments above are substituted with the proprietary + in-code comment used by the selected analysis tool. The safe.json and + false-positive-.json text file database are used to link each Xen tag + to the right proprietary in-code comment. + 2. Now Xen compilation starts using every supplied + at the script invocation. Coverity and Eclair are capable of intercepting + the compiler running from make to perform their analysis without + instrumenting the makefile. + 3. As final step every .safparse file are reverted back as and + every artifact related to the analysis will be cleaned. + This step is performed even in case any of the previous step fail, to skip + this step, call the script adding the --no-clean argument, but before + running again the script, call it with the --clean-only argument, that will + execute only this cleaning step. diff --git a/xen/scripts/xen-analysis.py b/xen/scripts/xen-analysis.py new file mode 100755 index 000000000000..b5d9ef1862c9 --- /dev/null +++ b/xen/scripts/xen-analysis.py @@ -0,0 +1,31 @@ +#!/usr/bin/env python3 + +import sys +from xen_analysis import settings, generic_analysis +from xen_analysis.generic_analysis import * + + +def main(argv): + ret_code = 0 + settings.parse_commandline(argv) + try: + if settings.step_parse_tags: + generic_analysis.parse_xen_tags() + if settings.step_build_xen: + generic_analysis.build_xen() + except (ParseTagPhaseError, BuildPhaseError) as e: + print("ERROR: {}".format(e)) + if hasattr(e, "errorcode"): + ret_code = e.errorcode + finally: + if settings.step_clean_analysis: + e = generic_analysis.clean_analysis_artifacts() + if e: + print("ERROR: {}".format(e)) + ret_code = 1 + + sys.exit(ret_code) + + +if __name__ == "__main__": + main(sys.argv[1:]) diff --git a/xen/scripts/xen_analysis/__init__.py b/xen/scripts/xen_analysis/__init__.py new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/xen/scripts/xen_analysis/generic_analysis.py b/xen/scripts/xen_analysis/generic_analysis.py new file mode 100644 index 000000000000..0b470c4ecf7d --- /dev/null +++ b/xen/scripts/xen_analysis/generic_analysis.py @@ -0,0 +1,93 @@ +#!/usr/bin/env python3 + +import os, subprocess +from . import settings, utils, tag_database + +class ParseTagPhaseError(Exception): + pass + +class BuildPhaseError(Exception): + pass + +class CleanPhaseError(Exception): + pass + + +def parse_xen_tags(): + # Load the database for the Xen tags + subs_list = tag_database.load_tag_database( + settings.analysis_tool, + [settings.repo_dir + "/docs/misra/safe.json"] + ) + subs_list = tag_database.load_tag_database( + settings.analysis_tool, + [settings.repo_dir + "/docs/misra/false-positive-{}.json" + .format(settings.analysis_tool)], + subs_list, + "false-positive" + ) + + # Create outdir if it doesn't exists + os.makedirs(settings.outdir, exist_ok=True) + + # The following lambda function will return a file if it contains lines with + # a comment containing "SAF--{safe|false-positive-}" on a + # single line. + grep_action = lambda x: utils.grep(x, + tag_database.get_xen_tag_comment_regex( + settings.analysis_tool) + ) + # Look for a list of .h/.c files that matches the condition above + parse_file_list = utils.recursive_find_file(settings.xen_dir, r'.*\.[ch]$', + grep_action) + + for entry in parse_file_list: + file = entry["file"] + bkp_file = file + ".safparse" + if os.path.isfile(bkp_file): + raise ParseTagPhaseError( + "Found {}, please check the integrity of {}" + .format(bkp_file,file) + ) + os.rename(file, bkp_file) + time_bkp_file = os.stat(bkp_file) + # Create from .safparse but with the Xen tag parsed + tag_database.substitute_tags(settings.analysis_tool, bkp_file, entry, + subs_list) + # Set timestamp for file equal to bkp_file, so that if the file is + # modified during the process by the user, we can catch it + os.utime(file, (time_bkp_file.st_atime, time_bkp_file.st_mtime)) + + +def build_xen(): + try: + subprocess.run( + "make -C {} {} build" + .format(settings.xen_dir, settings.make_forward_args), + shell=True, check=True + ) + except (subprocess.CalledProcessError, subprocess.SubprocessError) as e: + excp = BuildPhaseError( + "Build error occured when running:\n{}".format(e.cmd) + ) + excp.errorcode = e.returncode if hasattr(e, 'returncode') else 1 + raise excp + + +def clean_analysis_artifacts(): + safparse_files = utils.recursive_find_file(settings.xen_dir, + r'.*.safparse$') + for original_file in safparse_files: + # This commands strips the .safparse extension, leaving + parsed_file_path = os.path.splitext(original_file)[0] + mtime_original_file = os.stat(original_file).st_mtime + mtime_parsed_file = os.stat(parsed_file_path).st_mtime + if mtime_original_file != mtime_parsed_file: + return CleanPhaseError( + "The file {} was modified during the analysis " + "procedure, it is impossible now to restore from the " + "content of {}, please handle it manually" + .format(parsed_file_path, original_file) + ) + # Replace .safparse to + os.replace(original_file, parsed_file_path) diff --git a/xen/scripts/xen_analysis/settings.py b/xen/scripts/xen_analysis/settings.py new file mode 100644 index 000000000000..947dfa2d50af --- /dev/null +++ b/xen/scripts/xen_analysis/settings.py @@ -0,0 +1,97 @@ +#!/usr/bin/env python3 + +import sys, re, os + +module_dir = os.path.dirname(os.path.realpath(__file__)) +xen_dir = os.path.realpath(module_dir + "/../..") +repo_dir = os.path.realpath(xen_dir + "/..") +tools_dir = os.path.realpath(xen_dir + "/tools") + +step_parse_tags = True +step_build_xen = True +step_clean_analysis = True + +target_build = False +target_clean = False + +analysis_tool = "" +make_forward_args = "" +outdir = xen_dir + + +def help(): + msg=""" +Usage: {} [OPTION] ... [-- [make arguments]] + +This script runs the analysis on the Xen codebase. + +Options: + --build-only Run only the commands to build Xen with the optional make + arguments passed to the script + --clean-only Run only the commands to clean the analysis artifacts + -h, --help Print this help + --no-build Skip the build Xen phase + --no-clean Don\'t clean the analysis artifacts on exit + --run-coverity Run the analysis for the Coverity tool + --run-eclair Run the analysis for the Eclair tool +""" + print(msg.format(sys.argv[0])) + + +def parse_commandline(argv): + global analysis_tool + global make_forward_args + global outdir + global step_parse_tags + global step_build_xen + global step_clean_analysis + global target_build + global target_clean + forward_to_make = False + for option in argv: + if forward_to_make: + # Intercept outdir + outdir_regex = re.match("^O=(.*)$", option) + if outdir_regex: + outdir = outdir_regex.group(1) + # Forward any make arguments + make_forward_args = make_forward_args + " " + option + elif option == "--build-only": + target_build = True + elif option == "--clean-only": + target_clean = True + elif (option == "--help") or (option == "-h"): + help() + sys.exit(0) + elif option == "--no-build": + step_build_xen = False + elif option == "--no-clean": + step_clean_analysis = False + elif (option == "--run-coverity") or (option == "--run-eclair"): + analysis_tool = option[6:] + elif option == "--": + forward_to_make = True + else: + print("Invalid option: {}".format(option)) + help() + sys.exit(1) + + if target_build and target_clean: + print("--build-only is not compatible with --clean-only argument.") + sys.exit(1) + + if target_clean: + step_parse_tags = False + step_build_xen = False + step_clean_analysis = True + return + + if analysis_tool == "": + print("Please specify one analysis tool.") + help() + sys.exit(1) + + if target_build: + step_parse_tags = False + step_build_xen = True + step_clean_analysis = False diff --git a/xen/scripts/xen_analysis/tag_database.py b/xen/scripts/xen_analysis/tag_database.py new file mode 100644 index 000000000000..ca374bbb62dd --- /dev/null +++ b/xen/scripts/xen_analysis/tag_database.py @@ -0,0 +1,109 @@ +#!/usr/bin/env python3 + +import re, json + +class TagDatabaseError(Exception): + pass + +# This is the dictionary for the rules that translates to proprietary comments: +# - cppcheck: /* cppcheck-suppress[id] */ +# - coverity: /* coverity[id] */ +# - eclair: /* -E> hide id 1 "" */ +# Add entries to support more analyzers +tool_syntax = { + "cppcheck":"cppcheck-suppress[VID]", + "coverity":"coverity[VID]", + "eclair":"-E> hide VID 1 \"\"" +} + + +def get_xen_tag_index_type_regex(tool): + return r'^SAF-(\d+)-(safe|false-positive-' + tool + ')$' + + +def get_xen_tag_comment_regex(tool): + return r'^[ \t]*/\* +(SAF-\d+-(?:safe|false-positive-' + tool + ')).*\*/$' + + +# Returns a data structure containing dictionaries for safe and false-positive-* +# Xen tags, the key is the unique index of the tag and the content is the +# proprietary in-code comment to be used when the tag is found in the codebase +def load_tag_database(tool, input_files, data_struct = None, schema = "safe"): + ret = data_struct if data_struct is not None else { + "safe": {}, + "false-positive-" + tool: {} + } + database = [] + + # Open all input files + for file in input_files: + try: + with open(file, "rt") as handle: + content = json.load(handle) + database = database + content['content'] + except json.JSONDecodeError as e: + raise TagDatabaseError("JSON decoding error in file {}: {}" + .format(file, e)) + except Exception as e: + raise TagDatabaseError("Can't open file {}: {}" + .format(file, e)) + + for entry in database: + # If the false-positive schema is used, check the proprietary id in the + # 'violation-id' field, otherwise rely on the "safe" schema. + if schema == "false-positive": + proprietary_id = entry['violation-id'] + elif tool in entry['analyser']: + proprietary_id = entry['analyser'][tool] + else: + proprietary_id = "" + if proprietary_id != "": + comment=tool_syntax[tool].replace("VID",proprietary_id) + # Regex to capture the index of the Xen tag and the schema + xen_tag = re.compile(get_xen_tag_index_type_regex(tool))\ + .match(entry["id"]) + if xen_tag and xen_tag.group(1) and xen_tag.group(2): + # Save in safe or false-positive-* the key {#id: "comment"} + id_number = int(xen_tag.group(1)) + key = xen_tag.group(2) + ret[key][id_number] = "/* {} */\n".format(comment) + else: + raise TagDatabaseError( + "Error in database file, entry {} has unexpected " + "format.".format(entry["id"]) + ) + + return ret + + +def substitute_tags(tool, input_file, grep_struct, subs_rules): + try: + with open(grep_struct["file"], "wt") as outfile: + + try: + with open(input_file, "rt") as infile: + parsed_content = infile.readlines() + except Exception as e: + raise TagDatabaseError("Issue with reading file {}: {}" + .format(input_file, e)) + + # grep_struct contains the line number where the comments are, the + # line number starts from 1 but in the array the first line is zero. + # For every line where there is a Xen tag comment, get the Xen tag + # that is in the capture group zero, extract from the Xen tag the + # unique index and the type (safe, false-positive-*) and with those + # information access the subs_rules dictionary to see if there is + # a match + for line_number in grep_struct["matches"]: + xen_tag = grep_struct["matches"][line_number][0] + xen_tag_regex_obj = re.compile( + get_xen_tag_index_type_regex(tool)).match(xen_tag) + id_number = int(xen_tag_regex_obj.group(1)) + key = xen_tag_regex_obj.group(2) + if id_number in subs_rules[key]: + parsed_content[line_number-1] = subs_rules[key][id_number] + + outfile.writelines(parsed_content) + except Exception as e: + raise TagDatabaseError("Issue with writing file {}: {}" + .format(grep_struct["file"], e)) diff --git a/xen/scripts/xen_analysis/utils.py b/xen/scripts/xen_analysis/utils.py new file mode 100644 index 000000000000..a912d812c3df --- /dev/null +++ b/xen/scripts/xen_analysis/utils.py @@ -0,0 +1,37 @@ +#!/usr/bin/env python3 + +import os, re + + +def grep(filepath, regex): + regObj = re.compile(regex) + res = { "file": filepath, "matches": {} } + try: + with open(filepath, "rt") as f: + line_number = 1 + for line in f: + match = regObj.match(line) + if match: + res["matches"][line_number] = match.groups() + line_number = line_number + 1 + except Exception as e: + print("WARNING: Can't open {}: {}".format(filepath, e)) + + # Return filename and line matches if there are + return res if res["matches"] else {} + + +def recursive_find_file(path, filename_regex, action = None): + filename_reg_obj = re.compile(filename_regex) + res = [] + for root, dirs, fnames in os.walk(path): + for fname in fnames: + if filename_reg_obj.match(fname): + if action is None: + res.append(os.path.join(root, fname)) + else: + out = action(os.path.join(root, fname)) + if out: + res.append(out) + + return res -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 14:10:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 14:10:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448934.705531 (Exim 4.92) (envelope-from ) id 1ozeqB-0006Ko-Gs; Mon, 28 Nov 2022 14:10:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448934.705531; Mon, 28 Nov 2022 14:10:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozeqB-0006Kd-Bo; Mon, 28 Nov 2022 14:10:35 +0000 Received: by outflank-mailman (input) for mailman id 448934; Mon, 28 Nov 2022 14:10:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozeq9-0005sM-Hc for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 14:10:33 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6bb6a92b-6f26-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 15:10:32 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A07CB1424; Mon, 28 Nov 2022 06:10:38 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D5FC63F73D; Mon, 28 Nov 2022 06:10:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bb6a92b-6f26-11ed-91b6-6bf2151ebd3b From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 3/4] tools/misra: fix skipped rule numbers Date: Mon, 28 Nov 2022 14:10:05 +0000 Message-Id: <20221128141006.8719-4-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128141006.8719-1-luca.fancellu@arm.com> References: <20221128141006.8719-1-luca.fancellu@arm.com> Currently the script convert_misra_doc.py is using a loop through range(1,22) to enumerate rules that needs to be skipped, however range function does not include the stop counter in the enumeration ending up into list rules until 21.21 instead of including rule 22. Fix the issue using a dictionary that list the rules in misra c2012. Fixes: 57caa5375321 ("xen: Add MISRA support to cppcheck make rule") Signed-off-by: Luca Fancellu --- xen/tools/convert_misra_doc.py | 32 ++++++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/xen/tools/convert_misra_doc.py b/xen/tools/convert_misra_doc.py index caa4487f645f..13074d8a2e91 100755 --- a/xen/tools/convert_misra_doc.py +++ b/xen/tools/convert_misra_doc.py @@ -14,6 +14,34 @@ Usage: import sys, getopt, re +# MISRA rule are identified by two numbers, e.g. Rule 1.2, the main rule number +# and a sub-number. This dictionary contains the number of the MISRA rule as key +# and the maximum sub-number for that rule as value. +misra_c2012_rules = { + 1:4, + 2:7, + 3:2, + 4:2, + 5:9, + 6:2, + 7:4, + 8:14, + 9:5, + 10:8, + 11:9, + 12:5, + 13:6, + 14:4, + 15:7, + 16:7, + 17:8, + 18:8, + 19:2, + 20:14, + 21:21, + 22:10 +} + def main(argv): infile = '' outfile = '' @@ -142,8 +170,8 @@ def main(argv): skip_list = [] # Search for missing rules and add a dummy text with the rule number - for i in list(range(1,22)): - for j in list(range(1,22)): + for i in misra_c2012_rules: + for j in list(range(1,misra_c2012_rules[i]+1)): if str(i) + '.' + str(j) not in rule_list: outstr.write('Rule ' + str(i) + '.' + str(j) + '\n') outstr.write('No description for rule ' + str(i) + '.' + str(j) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 14:10:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 14:10:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448936.705553 (Exim 4.92) (envelope-from ) id 1ozeqD-0006rP-68; Mon, 28 Nov 2022 14:10:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448936.705553; Mon, 28 Nov 2022 14:10:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozeqD-0006qA-0u; Mon, 28 Nov 2022 14:10:37 +0000 Received: by outflank-mailman (input) for mailman id 448936; Mon, 28 Nov 2022 14:10:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozeqA-0005p8-Sg for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 14:10:35 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 6a97cd39-6f26-11ed-8fd2-01056ac49cbb; Mon, 28 Nov 2022 15:10:30 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 38CF3139F; Mon, 28 Nov 2022 06:10:37 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 537553F73D; Mon, 28 Nov 2022 06:10:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a97cd39-6f26-11ed-8fd2-01056ac49cbb From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 2/4] xen/scripts: add cppcheck tool to the xen-analysis.py script Date: Mon, 28 Nov 2022 14:10:04 +0000 Message-Id: <20221128141006.8719-3-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128141006.8719-1-luca.fancellu@arm.com> References: <20221128141006.8719-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change cppcheck invocation method by using the xen-analysis.py script using the arguments --run-cppcheck. Now cppcheck analysis will build Xen while the analysis is performed on the source files, it will produce a text report and an additional html output when the script is called with --cppcheck-html. With this patch cppcheck will benefit of platform configuration files that will help it to understand the target of the compilation and improve the analysis. To do so: - remove cppcheck rules from Makefile and move them to the script. - Update xen-analysis.py with the code to integrate cppcheck. - merge the script merge_cppcheck_reports.py into the xen-analysis script package and rework the code to integrate it. - add platform configuration files for cppcheck.. - add cppcheck-cc.sh script that is a wrapper for cppcheck and it's used as Xen compiler, it will intercept all flags given from the make build system and it will execute cppcheck on the compiled file together with the file compilation. - guarded hypercall-defs.c with CPPCHECK define because cppcheck gets confused as the file does not contain c code. - add false-positive-cppcheck.json file - update documentation. - update .gitignore Signed-off-by: Luca Fancellu --- .gitignore | 8 +- docs/misra/cppcheck.txt | 27 +- docs/misra/documenting-violations.rst | 7 +- docs/misra/false-positive-cppcheck.json | 12 + docs/misra/xen-static-analysis.rst | 42 ++- xen/Makefile | 116 +------- xen/include/hypercall-defs.c | 9 + xen/scripts/xen-analysis.py | 18 +- xen/scripts/xen_analysis/cppcheck_analysis.py | 272 ++++++++++++++++++ .../xen_analysis/cppcheck_report_utils.py | 130 +++++++++ xen/scripts/xen_analysis/generic_analysis.py | 21 +- xen/scripts/xen_analysis/settings.py | 77 ++++- xen/scripts/xen_analysis/utils.py | 21 +- xen/tools/cppcheck-cc.sh | 223 ++++++++++++++ xen/tools/cppcheck-plat/arm32-wchar_t4.xml | 17 ++ xen/tools/cppcheck-plat/arm64-wchar_t2.xml | 17 ++ xen/tools/cppcheck-plat/arm64-wchar_t4.xml | 17 ++ xen/tools/cppcheck-plat/x86_64-wchar_t2.xml | 17 ++ xen/tools/cppcheck-plat/x86_64-wchar_t4.xml | 17 ++ xen/tools/merge_cppcheck_reports.py | 86 ------ 20 files changed, 899 insertions(+), 255 deletions(-) create mode 100644 docs/misra/false-positive-cppcheck.json create mode 100644 xen/scripts/xen_analysis/cppcheck_analysis.py create mode 100644 xen/scripts/xen_analysis/cppcheck_report_utils.py create mode 100755 xen/tools/cppcheck-cc.sh create mode 100644 xen/tools/cppcheck-plat/arm32-wchar_t4.xml create mode 100644 xen/tools/cppcheck-plat/arm64-wchar_t2.xml create mode 100644 xen/tools/cppcheck-plat/arm64-wchar_t4.xml create mode 100644 xen/tools/cppcheck-plat/x86_64-wchar_t2.xml create mode 100644 xen/tools/cppcheck-plat/x86_64-wchar_t4.xml delete mode 100755 xen/tools/merge_cppcheck_reports.py diff --git a/.gitignore b/.gitignore index f5a66f6194dd..68566d0c2587 100644 --- a/.gitignore +++ b/.gitignore @@ -7,9 +7,11 @@ *.o *.d *.d2 -*.c.cppcheck +*.cppcheck.txt +*.cppcheck.xml *.opic *.a +*.c.json *.safparse *.so *.so.[0-9]* @@ -282,9 +284,11 @@ xen/arch/*/efi/efi.h xen/arch/*/efi/pe.c xen/arch/*/efi/runtime.c xen/arch/*/include/asm/asm-offsets.h +xen/build-dir-cppcheck/ xen/common/config_data.S xen/common/config.gz xen/cppcheck-htmlreport/ +xen/cppcheck-report/ xen/cppcheck-misra.* xen/include/headers*.chk xen/include/compat/* @@ -315,7 +319,7 @@ xen/xsm/flask/xenpolicy-* tools/flask/policy/policy.conf tools/flask/policy/xenpolicy-* xen/xen -xen/xen-cppcheck.xml +xen/suppression-list.txt xen/xen-syms xen/xen-syms.map xen/xen.* diff --git a/docs/misra/cppcheck.txt b/docs/misra/cppcheck.txt index 25d8c3050b72..f7b9f678b4d5 100644 --- a/docs/misra/cppcheck.txt +++ b/docs/misra/cppcheck.txt @@ -3,8 +3,7 @@ Cppcheck for Xen static and MISRA analysis Xen can be analysed for both static analysis problems and MISRA violation using cppcheck, the open source tool allows the creation of a report with all the -findings. Xen has introduced the support in the Makefile so it's very easy to -use and in this document we can see how. +findings. The minimum version required for cppcheck is 2.7. Note that at the time of writing (June 2022), the version 2.8 is known to be broken [1]. @@ -38,27 +37,7 @@ Dependencies are listed in the readme.md of the project repository. Use cppcheck to analyse Xen =========================== -Using cppcheck integration is very simple, it requires few steps: - - 1) Compile Xen - 2) call the cppcheck make target to generate a report in xml format: - make CPPCHECK_MISRA=y cppcheck - 3) call the cppcheck-html make target to generate a report in xml and html - format: - make CPPCHECK_MISRA=y cppcheck-html - - In case the cppcheck binaries are not in the PATH, CPPCHECK and - CPPCHECK_HTMLREPORT variables can be overridden with the full path to the - binaries: - - make -C xen \ - CPPCHECK=/path/to/cppcheck \ - CPPCHECK_HTMLREPORT=/path/to/cppcheck-htmlreport \ - CPPCHECK_MISRA=y \ - cppcheck-html - -The output is by default in a folder named cppcheck-htmlreport, but the name -can be changed by passing it in the CPPCHECK_HTMLREPORT_OUTDIR variable. - +To analyse Xen using cppcheck, please refer to the document +xen-static-analysis.rst, section "Analyse Xen with Cppcheck". [1] https://sourceforge.net/p/cppcheck/discussion/general/thread/bfc3ab6c41/?limit=25 diff --git a/docs/misra/documenting-violations.rst b/docs/misra/documenting-violations.rst index 1d23447556d2..31dafd5d4ece 100644 --- a/docs/misra/documenting-violations.rst +++ b/docs/misra/documenting-violations.rst @@ -51,6 +51,7 @@ Here is an example to add a new justification in safe.json:: | { | "id": "SAF-0-safe", | "analyser": { +| "cppcheck": "misra-c2012-20.7", | "coverity": "misra_c_2012_rule_20_7_violation", | "eclair": "MC3R1.R20.7" | }, @@ -77,9 +78,9 @@ Here is an explanation of the fields inside an object of the "content" array: It tells the tool to substitute a Xen in-code comment having this structure: /* SAF-0-safe [...] \*/ - analyser: it is an object containing pair of key-value strings, the key is - the analyser, so it can be coverity or eclair, the value is the proprietary - id corresponding on the finding, for example when coverity is used as - analyser, the tool will translate the Xen in-code coment in this way: + the analyser, so it can be cppcheck, coverity or eclair, the value is the + proprietary id corresponding on the finding, for example when coverity is + used as analyser, the tool will translate the Xen in-code coment in this way: /* SAF-0-safe [...] \*/ -> /* coverity[misra_c_2012_rule_20_7_violation] \*/ if the object doesn't have a key-value, then the corresponding in-code comment won't be translated. diff --git a/docs/misra/false-positive-cppcheck.json b/docs/misra/false-positive-cppcheck.json new file mode 100644 index 000000000000..5d4da2ce6170 --- /dev/null +++ b/docs/misra/false-positive-cppcheck.json @@ -0,0 +1,12 @@ +{ + "version": "1.0", + "content": [ + { + "id": "SAF-0-false-positive-cppcheck", + "violation-id": "", + "tool-version": "", + "name": "Sentinel", + "text": "Next ID to be used" + } + ] +} diff --git a/docs/misra/xen-static-analysis.rst b/docs/misra/xen-static-analysis.rst index 5b886474d4a0..2712255db1b0 100644 --- a/docs/misra/xen-static-analysis.rst +++ b/docs/misra/xen-static-analysis.rst @@ -7,9 +7,8 @@ The Xen codebase integrates some scripts and tools that helps the developer to perform static analysis of the code, currently Xen supports three analysis tool that are eclair, coverity and cppcheck. The Xen tree has a script (xen-analysis.py) available to ease the analysis -process and it integrates a way to suppress findings on these tools (only Eclair -and Coverity are currently supported by the script), please check the -documenting-violation.rst document to know more about it. +process and it integrates a way to suppress findings on these tools, please +check the documenting-violation.rst document to know more about it. Analyse Xen with Coverity or Eclair ----------------------------------- @@ -52,3 +51,40 @@ When invoking the script, the procedure below will be followed: this step, call the script adding the --no-clean argument, but before running again the script, call it with the --clean-only argument, that will execute only this cleaning step. + + +Analyse Xen with Cppcheck +------------------------- + +Cppcheck tool is integrated in xen-analysis.py script, when using the script, +the tool will be called on every source file compiled by the make build system. +Here how to start the analysis with Cppcheck: + + - xen-analysis.py --run-cppcheck [--cppcheck-misra] [--cppcheck-html] -- + [optional make arguments] + +The command above tells the script to prepare the codebase and use Cppcheck tool +for the analysis. +The optional argument --cppcheck-misra activates the analysis also for MISRA +compliance. +The optional argument --cppcheck-html instruct cppcheck to produce an additional +HTML report. + +When invoking the script for Cppcheck analysis, the followed procedure is +similar to the one above for Coverity or Eclair, but it has some additional +steps: + + 1. This step is the same as step 1 for Coverity/Eclair. + 2. The cppcheck dependency are created, build directory for cppcheck analysis + and an header file containing internal compiler macro + (include/generated/compiler-def.h) are generated + 3. Xen compilation starts using every supplied + at the script invocation, but because cppcheck is not able to intercept the + compiled files and flags on compiler invocation, a script (cppcheck-cc.sh) + is passed as CC to the make system, it is a wrapper for the compiler that + will also execute cppcheck on every compiled file. + 4. After the compilation and analysis, the cppcheck report will be created + putting together all the cppcheck report fragments for every analysed file. + Cppcheck will produce a text fragment and an additional XML report fragment + if the script is configured to produce the HTML output. + 5. This step is the same as step 3 for Coverity/Eclair. diff --git a/xen/Makefile b/xen/Makefile index 9d0df5e2c543..77926724bcd7 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -457,7 +457,7 @@ endif # need-config __all: build -main-targets := build install uninstall clean distclean MAP cppcheck cppcheck-html +main-targets := build install uninstall clean distclean MAP .PHONY: $(main-targets) ifneq ($(XEN_TARGET_ARCH),x86_32) $(main-targets): %: _% ; @@ -566,18 +566,16 @@ _clean: $(Q)$(MAKE) $(clean)=tools/kconfig find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \ -o -name ".*.o.tmp" -o -name "*~" -o -name "core" \ - -o -name '*.lex.c' -o -name '*.tab.[ch]' -o -name '*.c.cppcheck' \ - -o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \; + -o -name '*.lex.c' -o -name '*.tab.[ch]' -o -name "*.gcno" \ + -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \; rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET)-syms $(TARGET)-syms.map rm -f $(TARGET).efi $(TARGET).efi.map $(TARGET).efi.stripped rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h rm -f .banner .allconfig.tmp include/xen/compile.h - rm -f cppcheck-misra.* xen-cppcheck.xml .PHONY: _distclean _distclean: clean rm -f tags TAGS cscope.files cscope.in.out cscope.out cscope.po.out GTAGS GPATH GRTAGS GSYMS .config source - rm -rf $(CPPCHECK_HTMLREPORT_OUTDIR) $(TARGET).gz: $(TARGET) gzip -n -f -9 < $< > $@.new @@ -651,111 +649,9 @@ cloc: done; \ done | cloc --list-file=- -# What cppcheck command to use. -# To get proper results, it is recommended to build cppcheck manually from the -# latest source and use CPPCHECK to give the full path to the built version. -CPPCHECK ?= cppcheck - -# What cppcheck-htmlreport to use. -# If you give the full path to a self compiled cppcheck, this should be set -# to the full path to cppcheck-html in the htmlreport directory of cppcheck. -# On recent distribution, this is available in the standard path. -CPPCHECK_HTMLREPORT ?= cppcheck-htmlreport - -# By default we generate the report in cppcheck-htmlreport directory in the -# build directory. This can be changed by giving a directory in this variable. -CPPCHECK_HTMLREPORT_OUTDIR ?= cppcheck-htmlreport - -# By default we do not check misra rules, to enable pass "CPPCHECK_MISRA=y" to -# make command line. -CPPCHECK_MISRA ?= n - -# Compile flags to pass to cppcheck: -# - include directories and defines Xen Makefile is passing (from CFLAGS) -# - include config.h as this is passed directly to the compiler. -# - define CPPCHECK as we use to disable or enable some specific part of the -# code to solve some cppcheck issues. -# - explicitely enable some cppcheck checks as we do not want to use "all" -# which includes unusedFunction which gives wrong positives as we check file -# per file. -# -# Compiler defines are in compiler-def.h which is included in config.h -# -CPPCHECKFLAGS := -DCPPCHECK --max-ctu-depth=10 \ - --enable=style,information,missingInclude \ - --include=$(srctree)/include/xen/config.h \ - -I $(srctree)/xsm/flask/include \ - -I $(srctree)/include/xen/libfdt \ - $(filter -D% -I%,$(CFLAGS)) - -# We need to find all C files (as we are not checking assembly files) so -# we find all generated .o files which have a .c corresponding file. -CPPCHECKFILES := $(wildcard $(patsubst $(objtree)/%.o,$(srctree)/%.c, \ - $(filter-out $(objtree)/tools/%, \ - $(shell find $(objtree) -name "*.o")))) - -# Headers and files required to run cppcheck on a file -CPPCHECKDEPS := $(objtree)/include/generated/autoconf.h \ - $(objtree)/include/generated/compiler-def.h - -ifeq ($(CPPCHECK_MISRA),y) - CPPCHECKFLAGS += --addon=cppcheck-misra.json - CPPCHECKDEPS += cppcheck-misra.json -endif - -quiet_cmd_cppcheck_xml = CPPCHECK $(patsubst $(srctree)/%,%,$<) -cmd_cppcheck_xml = $(CPPCHECK) -v -q --xml $(CPPCHECKFLAGS) \ - --output-file=$@ $< - -quiet_cmd_merge_cppcheck_reports = CPPCHECK-MERGE $@ -cmd_merge_cppcheck_reports = $(PYTHON) $(srctree)/tools/merge_cppcheck_reports.py $^ $@ - -quiet_cmd_cppcheck_html = CPPCHECK-HTML $< -cmd_cppcheck_html = $(CPPCHECK_HTMLREPORT) --file=$< --source-dir=$(srctree) \ - --report-dir=$(CPPCHECK_HTMLREPORT_OUTDIR) --title=Xen - -PHONY += _cppcheck _cppcheck-html cppcheck-version - -_cppcheck-html: xen-cppcheck.xml - $(call if_changed,cppcheck_html) - -_cppcheck: xen-cppcheck.xml - -xen-cppcheck.xml: $(patsubst $(srctree)/%.c,$(objtree)/%.c.cppcheck,$(CPPCHECKFILES)) -ifeq ($(CPPCHECKFILES),) - $(error Please build Xen before running cppcheck) -endif - $(call if_changed,merge_cppcheck_reports) - -$(objtree)/%.c.cppcheck: $(srctree)/%.c $(CPPCHECKDEPS) | cppcheck-version - $(call if_changed,cppcheck_xml) - -cppcheck-version: - $(Q)if ! which $(CPPCHECK) > /dev/null 2>&1; then \ - echo "Cannot find cppcheck executable: $(CPPCHECK)"; \ - exit 1; \ - fi - $(Q)if [ "$$($(CPPCHECK) --version | awk '{print ($$2 < 2.7)}')" -eq 1 ]; then \ - echo "Please upgrade your cppcheck to version 2.7 or greater"; \ - exit 1; \ - fi - -# List of Misra rules to respect is written inside a doc. -# In order to have some helpful text in the cppcheck output, generate a text -# file containing the rules identifier, classification and text from the Xen -# documentation file. Also generate a json file with the right arguments for -# cppcheck in json format including the list of rules to ignore. -# -# convert_misra_doc.py, producing both targets at the same time, should be -# executed only once. Utilize a pattern rule to achieve this effect, with the -# stem kind of arbitrarily chosen to be "cppcheck". -.PRECIOUS: %-misra.json -%-misra.txt %-misra.json: $(XEN_ROOT)/docs/misra/rules.rst $(srctree)/tools/convert_misra_doc.py - $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $*-misra.txt -j $*-misra.json - -# Put this in generated headers this way it is cleaned by include/Makefile -$(objtree)/include/generated/compiler-def.h: - $(Q)$(CC) -dM -E -o $@ - < /dev/null +# Target used by xen-analysis.sh script to retrieve Xen build system variables +export-variable-%: + $(info $*=$($*)) endif #config-build endif # need-sub-make diff --git a/xen/include/hypercall-defs.c b/xen/include/hypercall-defs.c index 45b6f969d2ab..3d1eb7f04a73 100644 --- a/xen/include/hypercall-defs.c +++ b/xen/include/hypercall-defs.c @@ -60,6 +60,13 @@ * are possible. */ +/* + * Cppcheck thinks this file needs to be analysed because it is preprocessed by + * the compiler, but it gets confused because this file does not contains C + * code. Hence protect the code when CPPCHECK is used. + */ +#ifndef CPPCHECK + #ifdef CONFIG_HVM #define PREFIX_hvm hvm #else @@ -286,3 +293,5 @@ mca do do - - - #ifndef CONFIG_PV_SHIM_EXCLUSIVE paging_domctl_cont do do do do - #endif + +#endif /* !CPPCHECK */ diff --git a/xen/scripts/xen-analysis.py b/xen/scripts/xen-analysis.py index b5d9ef1862c9..8e50c27cd898 100755 --- a/xen/scripts/xen-analysis.py +++ b/xen/scripts/xen-analysis.py @@ -1,28 +1,42 @@ #!/usr/bin/env python3 import sys -from xen_analysis import settings, generic_analysis +from xen_analysis import settings, generic_analysis, cppcheck_analysis from xen_analysis.generic_analysis import * +from xen_analysis.cppcheck_analysis import * + +PhaseExceptions = (GetMakeVarsPhaseError, ParseTagPhaseError, + CppcheckDepsPhaseError, BuildPhaseError, + CppcheckReportPhaseError) def main(argv): ret_code = 0 settings.parse_commandline(argv) try: + if settings.step_get_make_vars: + cppcheck_analysis.get_make_vars() if settings.step_parse_tags: generic_analysis.parse_xen_tags() + if settings.step_cppcheck_deps: + cppcheck_analysis.generate_cppcheck_deps() if settings.step_build_xen: generic_analysis.build_xen() - except (ParseTagPhaseError, BuildPhaseError) as e: + if settings.step_cppcheck_report: + cppcheck_analysis.generate_cppcheck_report() + except PhaseExceptions as e: print("ERROR: {}".format(e)) if hasattr(e, "errorcode"): ret_code = e.errorcode finally: if settings.step_clean_analysis: + cppcheck_analysis.clean_analysis_artifacts() e = generic_analysis.clean_analysis_artifacts() if e: print("ERROR: {}".format(e)) ret_code = 1 + if settings.step_distclean_analysis: + cppcheck_analysis.clean_reports() sys.exit(ret_code) diff --git a/xen/scripts/xen_analysis/cppcheck_analysis.py b/xen/scripts/xen_analysis/cppcheck_analysis.py new file mode 100644 index 000000000000..e5c2f3be3e85 --- /dev/null +++ b/xen/scripts/xen_analysis/cppcheck_analysis.py @@ -0,0 +1,272 @@ +#!/usr/bin/env python3 + +import os, re, shutil +from . import settings, utils, cppcheck_report_utils + +class GetMakeVarsPhaseError(Exception): + pass + +class CppcheckDepsPhaseError(Exception): + pass + +class CppcheckReportPhaseError(Exception): + pass + +CPPCHECK_BUILD_DIR = "build-dir-cppcheck" +CPPCHECK_HTMLREPORT_OUTDIR = "cppcheck-htmlreport" +CPPCHECK_REPORT_OUTDIR = "cppcheck-report" +cppcheck_extra_make_args = "" +xen_cc = "" + +def get_make_vars(): + global xen_cc + invoke_make = utils.invoke_command( + "make -C {} {} export-variable-CC" + .format(settings.xen_dir, settings.make_forward_args), + True, GetMakeVarsPhaseError, + "Error occured retrieving make vars:\n{}" + ) + + cc_var_regex = re.search('^CC=(.*)$', invoke_make, flags=re.M) + if cc_var_regex: + xen_cc = cc_var_regex.group(1) + + if xen_cc == "": + raise GetMakeVarsPhaseError("CC variable not found in Xen make output") + + +def __generate_suppression_list(out_file): + # The following lambda function will return a file if it contains lines with + # a comment containing "cppcheck-suppress[*]" on a single line. + grep_action = lambda x: utils.grep(x, + r'^[ \t]*/\* cppcheck-suppress\[(.*)\] \*/$') + # Look for a list of .h files that matches the condition above + headers = utils.recursive_find_file(settings.xen_dir, r'.*\.h$', + grep_action) + + try: + with open(out_file, "wt") as supplist_file: + # Add this rule to skip every finding in the autogenerated + # header for cppcheck + supplist_file.write("*:*generated/compiler-def.h\n") + + for entry in headers: + filename = entry["file"] + try: + with open(filename, "rt") as infile: + header_content = infile.readlines() + except OSError as e: + raise CppcheckDepsPhaseError( + "Issue with reading file {}: {}" + .format(filename, e) + ) + header_lines_len = len(header_content) + # line_num in entry will be header_content[line_num-1], here we + # are going to search the first line after line_num that have + # anything different from comments or empty line, because the + # in-code comment suppression is related to that line then. + for line_num in entry["matches"]: + cppcheck_violation_id = "" + tmp_line = line_num + # look up to which line is referring the comment at + # line_num (which would be header_content[tmp_line-1]) + comment_section = False + while tmp_line < header_lines_len: + line = header_content[tmp_line] + # Matches a line with just optional spaces/tabs and the + # start of a comment '/*' + comment_line_starts = re.match('^[ \t]*/\*.*$', line) + # Matches a line with text and the end of a comment '*/' + comment_line_stops = re.match('^.*\*/$', line) + if (not comment_section) and comment_line_starts: + comment_section = True + if (len(line.strip()) != 0) and (not comment_section): + cppcheck_violation_id = entry["matches"][line_num][0] + break + if comment_section and comment_line_stops: + comment_section = False + tmp_line = tmp_line + 1 + + if cppcheck_violation_id == "": + raise CppcheckDepsPhaseError( + "Error matching cppcheck comment in {} at line {}." + .format(filename, line_num) + ) + # Write [error id]:[filename]:[line] + # tmp_line refers to the array index, so translated to the + # file line (that begins with 1) it is tmp_line+1 + supplist_file.write( + "{}:{}:{}\n".format(cppcheck_violation_id, filename, + (tmp_line + 1)) + ) + except OSError as e: + raise CppcheckDepsPhaseError("Issue with writing file {}: {}" + .format(out_file, e)) + + +def generate_cppcheck_deps(): + global cppcheck_extra_make_args + + # Compile flags to pass to cppcheck: + # - include config.h as this is passed directly to the compiler. + # - define CPPCHECK as we use it to disable or enable some specific part of + # the code to solve some cppcheck issues. + # - explicitely enable some cppcheck checks as we do not want to use "all" + # which includes unusedFunction which gives wrong positives as we check + # file per file. + # - Explicitly suppress warnings on compiler-def.h because cppcheck throws + # an unmatchedSuppression due to the rule we put in suppression-list.txt + # to skip every finding in the file. + # + # Compiler defines are in compiler-def.h which is included in config.h + # + cppcheck_flags=""" +--cppcheck-build-dir={}/{} + --max-ctu-depth=10 + --enable=style,information,missingInclude + --template=\'{{file}}({{line}},{{column}}):{{id}}:{{severity}}:{{message}}\' + --relative-paths={} + --inline-suppr + --suppressions-list={}/suppression-list.txt + --suppress='unmatchedSuppression:*generated/compiler-def.h' + --include={}/include/xen/config.h + -DCPPCHECK +""".format(settings.outdir, CPPCHECK_BUILD_DIR, settings.xen_dir, + settings.outdir, settings.xen_dir) + + invoke_cppcheck = utils.invoke_command( + "{} --version".format(settings.cppcheck_binpath), + True, CppcheckDepsPhaseError, + "Error occured retrieving cppcheck version:\n{}\n\n{}" + ) + + version_regex = re.search('^Cppcheck (.*)$', invoke_cppcheck, flags=re.M) + # Currently, only cppcheck version >= 2.7 is supported, but version 2.8 is + # known to be broken, please refer to docs/misra/cppcheck.txt + if (not version_regex) or (version_regex.group(1) != "2.7"): + raise CppcheckDepsPhaseError( + "Can't find cppcheck version or version is not 2.7" + ) + + # If misra option is selected, append misra addon and generate cppcheck + # files for misra analysis + if settings.cppcheck_misra: + cppcheck_flags = cppcheck_flags + " --addon=cppcheck-misra.json" + + utils.invoke_command( + "{}/convert_misra_doc.py -i {}/docs/misra/rules.rst" + " -o {}/cppcheck-misra.txt -j {}/cppcheck-misra.json" + .format(settings.tools_dir, settings.repo_dir, + settings.outdir, settings.outdir), + False, CppcheckDepsPhaseError, + "An error occured when running:\n{}" + ) + + # Generate compiler macros + os.makedirs("{}/include/generated".format(settings.outdir), exist_ok=True) + utils.invoke_command( + "{} -dM -E -o \"{}/include/generated/compiler-def.h\" - < /dev/null" + .format(xen_cc, settings.outdir), + False, CppcheckDepsPhaseError, + "An error occured when running:\n{}" + ) + + # Generate cppcheck suppression list + __generate_suppression_list( + "{}/suppression-list.txt".format(settings.outdir)) + + # Generate cppcheck build folder + os.makedirs("{}/{}".format(settings.outdir, CPPCHECK_BUILD_DIR), + exist_ok=True) + + cppcheck_cc_flags = """--compiler={} --cppcheck-cmd={} {} + --cppcheck-plat={}/cppcheck-plat --ignore-path=tools/ +""".format(xen_cc, settings.cppcheck_binpath, cppcheck_flags, + settings.tools_dir) + + if settings.cppcheck_html: + cppcheck_cc_flags = cppcheck_cc_flags + " --cppcheck-html" + + # Generate the extra make argument to pass the cppcheck-cc.sh wrapper as CC + cppcheck_extra_make_args = "CC=\"{}/cppcheck-cc.sh {} --\"".format( + settings.tools_dir, + cppcheck_cc_flags + ).replace("\n", "") + + +def generate_cppcheck_report(): + # Prepare text report + # Look for a list of .cppcheck.txt files, those are the txt report + # fragments + fragments = utils.recursive_find_file(settings.outdir, r'.*\.cppcheck.txt$') + text_report_dir = "{}/{}".format(settings.outdir, + CPPCHECK_REPORT_OUTDIR) + report_filename = "{}/xen-cppcheck.txt".format(text_report_dir) + os.makedirs(text_report_dir, exist_ok=True) + try: + cppcheck_report_utils.cppcheck_merge_txt_fragments(fragments, + report_filename, + [settings.xen_dir]) + except cppcheck_report_utils.CppcheckTXTReportError as e: + raise CppcheckReportPhaseError(e) + + # If HTML output is requested + if settings.cppcheck_html: + # Look for a list of .cppcheck.xml files, those are the XML report + # fragments + fragments = utils.recursive_find_file(settings.outdir, + r'.*\.cppcheck.xml$') + html_report_dir = "{}/{}".format(settings.outdir, + CPPCHECK_HTMLREPORT_OUTDIR) + xml_filename = "{}/xen-cppcheck.xml".format(html_report_dir) + os.makedirs(html_report_dir, exist_ok=True) + try: + cppcheck_report_utils.cppcheck_merge_xml_fragments(fragments, + xml_filename, + settings.xen_dir, + settings.outdir) + except cppcheck_report_utils.CppcheckHTMLReportError as e: + raise CppcheckReportPhaseError(e) + # Call cppcheck-htmlreport utility to generate the HTML output + utils.invoke_command( + "{} --file={} --source-dir={} --report-dir={}/html --title=Xen" + .format(settings.cppcheck_htmlreport_binpath, xml_filename, + settings.xen_dir, html_report_dir), + False, CppcheckReportPhaseError, + "Error occured generating Cppcheck HTML report:\n{}" + ) + # Strip src and obj path from *.html files + html_files = utils.recursive_find_file(html_report_dir, r'.*\.html$') + try: + cppcheck_report_utils.cppcheck_strip_path_html(html_files, + (settings.xen_dir, + settings.outdir)) + except cppcheck_report_utils.CppcheckHTMLReportError as e: + raise CppcheckReportPhaseError(e) + + +def clean_analysis_artifacts(): + clean_files = ("suppression-list.txt", "cppcheck-misra.txt", + "cppcheck-misra.json") + cppcheck_build_dir = "{}/{}".format(settings.outdir, CPPCHECK_BUILD_DIR) + if os.path.isdir(cppcheck_build_dir): + shutil.rmtree(cppcheck_build_dir) + artifact_files = utils.recursive_find_file(settings.outdir, + r'.*\.(?:c\.json|cppcheck\.txt|cppcheck\.xml)$') + for file in clean_files: + file = "{}/{}".format(settings.outdir, file) + if os.path.isfile(file): + artifact_files.append(file) + for delfile in artifact_files: + os.remove(delfile) + + +def clean_reports(): + text_report_dir = "{}/{}".format(settings.outdir, + CPPCHECK_REPORT_OUTDIR) + html_report_dir = "{}/{}".format(settings.outdir, + CPPCHECK_HTMLREPORT_OUTDIR) + if os.path.isdir(text_report_dir): + shutil.rmtree(text_report_dir) + if os.path.isdir(html_report_dir): + shutil.rmtree(html_report_dir) diff --git a/xen/scripts/xen_analysis/cppcheck_report_utils.py b/xen/scripts/xen_analysis/cppcheck_report_utils.py new file mode 100644 index 000000000000..02440aefdfec --- /dev/null +++ b/xen/scripts/xen_analysis/cppcheck_report_utils.py @@ -0,0 +1,130 @@ +#!/usr/bin/env python3 + +import os +from xml.etree import ElementTree + +class CppcheckHTMLReportError(Exception): + pass + +class CppcheckTXTReportError(Exception): + pass + + +def __elements_equal(el1, el2): + if type(el1) != type(el2): return False + + if el1.find('location') is None: return False + if el2.find('location') is None: return False + + el1_location = str(el1.find('location').attrib) + el2_location = str(el2.find('location').attrib) + + if el1_location != el2_location: return False + + return True + + +def __contain_element(new, lst): + for elem in lst: + if __elements_equal(new, elem): + return True + return False + + +def __get_xml_root_file(filename): + try: + result_xml_root = ElementTree.parse(filename).getroot() + except ElementTree.ParseError as e: + raise CppcheckHTMLReportError( + "XML parsing error in {}: {}".format(filename, e) + ) + return result_xml_root + + +def __sanitize_cppcheck_xml_path(xml_tree, src_path, obj_path): + # Some path are relative to the source tree but some others are generated + # in the obj tree, for cppcheck when using cppcheck-htmlreport we can pass + # only one source tree where the files will be fetched if relative path are + # found. So for every path that does not exists in src tree, we guess it + # comes from obj tree and we put explicit absolute path to it + error_item_root = xml_tree.findall("errors")[0] + for error_item in error_item_root: + for location_item in error_item.findall("location"): + path = location_item.attrib["file"] + new_obj_path = obj_path + "/" + path + new_src_path = src_path + "/" + path + if (path[0] != "/") and (not os.path.isfile(new_src_path)) \ + and os.path.isfile(new_obj_path): + location_item.attrib["file"] = new_obj_path + + +def cppcheck_merge_xml_fragments(fragments_list, out_xml_file, src_path, + obj_path): + + result_xml = __get_xml_root_file(fragments_list[0]) + insert_point = result_xml.findall("errors")[0] + for xml_file in fragments_list[1:]: + xml_root = __get_xml_root_file(xml_file) + curr_elem_list = list(insert_point) + new_elem_list = list(xml_root.findall("errors")[0]) + for xml_error_elem in new_elem_list: + if not __contain_element(xml_error_elem, curr_elem_list): + insert_point.insert(1, xml_error_elem) + + if result_xml is None: + return False + + __sanitize_cppcheck_xml_path(result_xml, src_path, obj_path) + + ElementTree.ElementTree(result_xml).write(out_xml_file) + + return True + + +def cppcheck_merge_txt_fragments(fragments_list, out_txt_file, strip_paths): + try: + with open(out_txt_file, "wt") as outfile: + # Using a set will remove automatically the duplicate lines + text_report_content = set() + for file in fragments_list: + try: + with open(file, "rt") as infile: + frag_lines = infile.readlines() + except OSError as e: + raise CppcheckTXTReportError( + "Issue with reading file {}: {}" + .format(file, e) + ) + text_report_content.update(frag_lines) + + # Back to modifiable list + text_report_content = list(text_report_content) + # Strip path from report lines + for i in list(range(0, len(text_report_content))): + for path in strip_paths: + text_report_content[i] = text_report_content[i].replace( + path + "/", "") + # Write the final text report + outfile.writelines(text_report_content) + except OSError as e: + raise CppcheckTXTReportError("Issue with writing file {}: {}" + .format(out_txt_file, e)) + + +def cppcheck_strip_path_html(html_files, strip_paths): + for file in html_files: + try: + with open(file, "rt") as infile: + html_lines = infile.readlines() + except OSError as e: + raise CppcheckHTMLReportError("Issue with reading file {}: {}" + .format(file, e)) + for i in list(range(0, len(html_lines))): + for path in strip_paths: + html_lines[i] = html_lines[i].replace(path + "/", "") + try: + with open(file, "wt") as outfile: + outfile.writelines(html_lines) + except OSError as e: + raise CppcheckHTMLReportError("Issue with writing file {}: {}" + .format(file, e)) diff --git a/xen/scripts/xen_analysis/generic_analysis.py b/xen/scripts/xen_analysis/generic_analysis.py index 0b470c4ecf7d..94122aebace0 100644 --- a/xen/scripts/xen_analysis/generic_analysis.py +++ b/xen/scripts/xen_analysis/generic_analysis.py @@ -1,7 +1,7 @@ #!/usr/bin/env python3 -import os, subprocess -from . import settings, utils, tag_database +import os +from . import settings, utils, tag_database, cppcheck_analysis class ParseTagPhaseError(Exception): pass @@ -60,18 +60,13 @@ def parse_xen_tags(): def build_xen(): - try: - subprocess.run( - "make -C {} {} build" - .format(settings.xen_dir, settings.make_forward_args), - shell=True, check=True + utils.invoke_command( + "make -C {} {} {} build" + .format(settings.xen_dir, settings.make_forward_args, + cppcheck_analysis.cppcheck_extra_make_args), + False, BuildPhaseError, + "Build error occured when running:\n{}" ) - except (subprocess.CalledProcessError, subprocess.SubprocessError) as e: - excp = BuildPhaseError( - "Build error occured when running:\n{}".format(e.cmd) - ) - excp.errorcode = e.returncode if hasattr(e, 'returncode') else 1 - raise excp def clean_analysis_artifacts(): diff --git a/xen/scripts/xen_analysis/settings.py b/xen/scripts/xen_analysis/settings.py index 947dfa2d50af..bd1faafe79a3 100644 --- a/xen/scripts/xen_analysis/settings.py +++ b/xen/scripts/xen_analysis/settings.py @@ -7,14 +7,23 @@ xen_dir = os.path.realpath(module_dir + "/../..") repo_dir = os.path.realpath(xen_dir + "/..") tools_dir = os.path.realpath(xen_dir + "/tools") +step_get_make_vars = False step_parse_tags = True +step_cppcheck_deps = False step_build_xen = True +step_cppcheck_report = False step_clean_analysis = True +step_distclean_analysis = False target_build = False target_clean = False +target_distclean = False analysis_tool = "" +cppcheck_binpath = "cppcheck" +cppcheck_html = False +cppcheck_htmlreport_binpath = "cppcheck-htmlreport" +cppcheck_misra = False make_forward_args = "" outdir = xen_dir @@ -26,29 +35,47 @@ Usage: {} [OPTION] ... [-- [make arguments]] This script runs the analysis on the Xen codebase. Options: - --build-only Run only the commands to build Xen with the optional make - arguments passed to the script - --clean-only Run only the commands to clean the analysis artifacts - -h, --help Print this help - --no-build Skip the build Xen phase - --no-clean Don\'t clean the analysis artifacts on exit - --run-coverity Run the analysis for the Coverity tool - --run-eclair Run the analysis for the Eclair tool + --build-only Run only the commands to build Xen with the optional + make arguments passed to the script + --clean-only Run only the commands to clean the analysis artifacts + --cppcheck-bin= Path to the cppcheck binary (Default: {}) + --cppcheck-html Produce an additional HTML output report for Cppcheck + --cppcheck-html-bin= Path to the cppcheck-html binary (Default: {}) + --cppcheck-misra Activate the Cppcheck MISRA analysis + --distclean Clean analysis artifacts and reports + -h, --help Print this help + --no-build Skip the build Xen phase + --no-clean Don\'t clean the analysis artifacts on exit + --run-coverity Run the analysis for the Coverity tool + --run-cppcheck Run the Cppcheck analysis tool on Xen + --run-eclair Run the analysis for the Eclair tool """ - print(msg.format(sys.argv[0])) + print(msg.format(sys.argv[0], cppcheck_binpath, + cppcheck_htmlreport_binpath)) def parse_commandline(argv): global analysis_tool + global cppcheck_binpath + global cppcheck_html + global cppcheck_htmlreport_binpath + global cppcheck_misra global make_forward_args global outdir + global step_get_make_vars global step_parse_tags + global step_cppcheck_deps global step_build_xen + global step_cppcheck_report global step_clean_analysis + global step_distclean_analysis global target_build global target_clean + global target_distclean forward_to_make = False for option in argv: + args_with_content_regex = re.match(r'^(--[a-z]+[a-z-]*)=(.*)$', option) + if forward_to_make: # Intercept outdir outdir_regex = re.match("^O=(.*)$", option) @@ -60,6 +87,18 @@ def parse_commandline(argv): target_build = True elif option == "--clean-only": target_clean = True + elif args_with_content_regex and \ + args_with_content_regex.group(1) == "--cppcheck-bin": + cppcheck_binpath = args_with_content_regex.group(2) + elif option == "--cppcheck-html": + cppcheck_html = True + elif args_with_content_regex and \ + args_with_content_regex.group(1) == "--cppcheck-html-bin": + cppcheck_htmlreport_binpath = args_with_content_regex.group(2) + elif option == "--cppcheck-misra": + cppcheck_misra = True + elif option == "--distclean": + target_distclean = True elif (option == "--help") or (option == "-h"): help() sys.exit(0) @@ -69,6 +108,11 @@ def parse_commandline(argv): step_clean_analysis = False elif (option == "--run-coverity") or (option == "--run-eclair"): analysis_tool = option[6:] + elif (option == "--run-cppcheck"): + analysis_tool = "cppcheck" + step_get_make_vars = True + step_cppcheck_deps = True + step_cppcheck_report = True elif option == "--": forward_to_make = True else: @@ -76,13 +120,23 @@ def parse_commandline(argv): help() sys.exit(1) - if target_build and target_clean: - print("--build-only is not compatible with --clean-only argument.") + if target_build and (target_clean or target_distclean): + print("--build-only is not compatible with --clean-only/--distclean " + "argument.") sys.exit(1) + if target_distclean: + # Implicit activation of clean target + target_clean = True + + step_distclean_analysis = True + if target_clean: + step_get_make_vars = False step_parse_tags = False + step_cppcheck_deps = False step_build_xen = False + step_cppcheck_report = False step_clean_analysis = True return @@ -95,3 +149,4 @@ def parse_commandline(argv): step_parse_tags = False step_build_xen = True step_clean_analysis = False + step_cppcheck_report = False diff --git a/xen/scripts/xen_analysis/utils.py b/xen/scripts/xen_analysis/utils.py index a912d812c3df..1193e3f4631e 100644 --- a/xen/scripts/xen_analysis/utils.py +++ b/xen/scripts/xen_analysis/utils.py @@ -1,6 +1,6 @@ #!/usr/bin/env python3 -import os, re +import os, re, subprocess def grep(filepath, regex): @@ -35,3 +35,22 @@ def recursive_find_file(path, filename_regex, action = None): res.append(out) return res + + +def invoke_command(command, needs_output, exeption_type = Exception, + exeption_msg = ""): + try: + pipe_stdout = subprocess.PIPE if (needs_output == True) else None + output = subprocess.run(command, shell=True, check=True, + stdout=pipe_stdout, stderr=subprocess.STDOUT, + encoding='utf8') + except (subprocess.CalledProcessError, subprocess.SubprocessError) as e: + if needs_output == True: + exeption_msg = exeption_msg.format(e.cmd, output.stdout) + else: + exeption_msg = exeption_msg.format(e.cmd) + excp = exeption_type(exeption_msg) + excp.errorcode = e.returncode if hasattr(e, 'returncode') else 1 + raise excp + + return output.stdout diff --git a/xen/tools/cppcheck-cc.sh b/xen/tools/cppcheck-cc.sh new file mode 100755 index 000000000000..e682f6b9d79d --- /dev/null +++ b/xen/tools/cppcheck-cc.sh @@ -0,0 +1,223 @@ +#!/usr/bin/env bash + +set -e + +function help() { + cat < + +This script is a wrapper for cppcheck that enables it to analyse the files that +are the target for the build, it is used in place of a selected compiler and the +make process will run it on every file that needs to be built. +All the arguments passed to the original compiler are forwarded to it without +modification, furthermore, they are used to improve the cppcheck analysis. + +Options: + --compiler= Use this compiler for the build + --cppcheck-cmd= Command line for the cppcheck analysis. + --cppcheck-html Prepare for cppcheck HTML output + --cppcheck-plat= Path to the cppcheck platform folder + --ignore-path= This script won't run cppcheck on the files having this + path, the compiler will run anyway on them. This argument + can be specified multiple times. + -h, --help Print this help +EOF +} + +CC_FILE="" +COMPILER="" +CPPCHECK_HTML="n" +CPPCHECK_PLAT_PATH="" +CPPCHECK_TOOL="" +CPPCHECK_TOOL_ARGS="" +FORWARD_FLAGS="" +IGNORE_PATH="n" +IGNORE_PATH_LIST="" +JDB_FILE="" +OBJTREE_PATH="" + +# Variable used for arg parsing +forward_to_cc="n" +sm_tool_args="n" +obj_arg_content="n" + +for OPTION in "$@" +do + if [ "${forward_to_cc}" = "y" ]; then + if [[ ${OPTION} == *.c ]] + then + CC_FILE="${OPTION}" + elif [ "${OPTION}" = "-o" ] + then + # After -o there is the path to the obj file, flag it + obj_arg_content="y" + elif [ "${obj_arg_content}" = "y" ] + then + # This must be the path to the obj file, turn off flag and save path + OBJTREE_PATH="$(dirname "${OPTION}")" + obj_arg_content="n" + fi + # Forward any argument to the compiler + FORWARD_FLAGS="${FORWARD_FLAGS} ${OPTION}" + continue + fi + case ${OPTION} in + -h|--help) + help + exit 0 + ;; + --compiler=*) + COMPILER="$(eval echo "${OPTION#*=}")" + sm_tool_args="n" + ;; + --cppcheck-cmd=*) + CPPCHECK_TOOL="$(eval echo "${OPTION#*=}")" + sm_tool_args="y" + ;; + --cppcheck-html) + CPPCHECK_HTML="y" + sm_tool_args="n" + ;; + --cppcheck-plat=*) + CPPCHECK_PLAT_PATH="$(eval echo "${OPTION#*=}")" + sm_tool_args="n" + ;; + --ignore-path=*) + IGNORE_PATH_LIST="${IGNORE_PATH_LIST} $(eval echo "${OPTION#*=}")" + sm_tool_args="n" + ;; + --) + forward_to_cc="y" + sm_tool_args="n" + ;; + *) + if [ "${sm_tool_args}" = "y" ]; then + CPPCHECK_TOOL_ARGS="${CPPCHECK_TOOL_ARGS} ${OPTION}" + else + echo "Invalid option ${OPTION}" + exit 1 + fi + ;; + esac +done + +if [ "${COMPILER}" = "" ] +then + echo "--compiler arg is mandatory." + exit 1 +fi + +function print_file() { + local text="${1}" + local init_file="${2}" + + if [ "${init_file}" = "y" ] + then + echo -e -n "${text}" > "${JDB_FILE}" + else + echo -e -n "${text}" >> "${JDB_FILE}" + fi +} + +function create_jcd() { + local line="${1}" + local arg_num=0 + local same_line=0 + + print_file "[\n" "y" + print_file " {\n" + print_file " \"arguments\": [\n" + + for arg in ${line}; do + # This code prevents to put comma in the last element of the list or on + # sequential lines that are going to be merged + [ "${arg_num}" -ne 0 ] && [ "${same_line}" -eq 0 ] && print_file ",\n" + if [ "${same_line}" -ne 0 ] + then + print_file "${arg}\"" + same_line=0 + elif [ "${arg}" = "-iquote" ] || [ "${arg}" = "-I" ] + then + # cppcheck doesn't understand -iquote, substitute with -I + print_file " \"-I" + same_line=1 + else + print_file " \"${arg}\"" + fi + arg_num=$(( arg_num + 1 )) + done + print_file "\n" + print_file " ],\n" + print_file " \"directory\": \"$(pwd -P)\",\n" + print_file " \"file\": \"${CC_FILE}\"\n" + print_file " }\n" + print_file "]\n" +} + + +# Execute compiler with forwarded flags +# Shellcheck complains about missing quotes on FORWARD_FLAGS, but they can't be +# used here +# shellcheck disable=SC2086 +${COMPILER} ${FORWARD_FLAGS} + +if [ -n "${CC_FILE}" ]; +then + for path in ${IGNORE_PATH_LIST} + do + if [[ ${CC_FILE} == *${path}* ]] + then + IGNORE_PATH="y" + echo "${0}: ${CC_FILE} ignored by --ignore-path matching *${path}*" + fi + done + if [ "${IGNORE_PATH}" = "n" ] + then + JDB_FILE="${OBJTREE_PATH}/$(basename "${CC_FILE}".json)" + + # Prepare the Json Compilation Database for the file + create_jcd "${COMPILER} ${FORWARD_FLAGS}" + + out_file="${OBJTREE_PATH}/$(basename "${CC_FILE%.c}".cppcheck.txt)" + + # Check wchar size + wchar_plat_suffix="t4" + # sed prints the last occurence of -f(no-)short-wchar which is the one + # applied to the file by the compiler + wchar_option=$(echo "${FORWARD_FLAGS}" | \ + sed -nre 's,.*(-f(no-)?short-wchar).*,\1,p') + if [ "${wchar_option}" = "-fshort-wchar" ] + then + wchar_plat_suffix="t2" + fi + + # Select the right target platform, ARCH is generated from Xen Makefile + platform="${CPPCHECK_PLAT_PATH}/${ARCH}-wchar_${wchar_plat_suffix}.xml" + if [ ! -f "${platform}" ] + then + echo "${platform} not found!" + exit 1 + fi + + # Shellcheck complains about missing quotes on CPPCHECK_TOOL_ARGS, but + # they can't be used here + # shellcheck disable=SC2086 + ${CPPCHECK_TOOL} ${CPPCHECK_TOOL_ARGS} \ + --project="${JDB_FILE}" \ + --output-file="${out_file}" \ + --platform=${platform} + + if [ "${CPPCHECK_HTML}" = "y" ] + then + # Shellcheck complains about missing quotes on CPPCHECK_TOOL_ARGS, + # but they can't be used here + # shellcheck disable=SC2086 + ${CPPCHECK_TOOL} ${CPPCHECK_TOOL_ARGS} \ + --project="${JDB_FILE}" \ + --output-file="${out_file%.txt}.xml" \ + --platform=${platform} \ + -q \ + --xml + fi + fi +fi diff --git a/xen/tools/cppcheck-plat/arm32-wchar_t4.xml b/xen/tools/cppcheck-plat/arm32-wchar_t4.xml new file mode 100644 index 000000000000..3aefa7ba5c98 --- /dev/null +++ b/xen/tools/cppcheck-plat/arm32-wchar_t4.xml @@ -0,0 +1,17 @@ + + + 8 + unsigned + + 2 + 4 + 4 + 8 + 4 + 8 + 8 + 4 + 4 + 4 + + diff --git a/xen/tools/cppcheck-plat/arm64-wchar_t2.xml b/xen/tools/cppcheck-plat/arm64-wchar_t2.xml new file mode 100644 index 000000000000..e345b934a986 --- /dev/null +++ b/xen/tools/cppcheck-plat/arm64-wchar_t2.xml @@ -0,0 +1,17 @@ + + + 8 + unsigned + + 2 + 4 + 8 + 8 + 4 + 8 + 16 + 8 + 4 + 2 + + diff --git a/xen/tools/cppcheck-plat/arm64-wchar_t4.xml b/xen/tools/cppcheck-plat/arm64-wchar_t4.xml new file mode 100644 index 000000000000..952b3640c91d --- /dev/null +++ b/xen/tools/cppcheck-plat/arm64-wchar_t4.xml @@ -0,0 +1,17 @@ + + + 8 + unsigned + + 2 + 4 + 8 + 8 + 4 + 8 + 16 + 8 + 4 + 4 + + diff --git a/xen/tools/cppcheck-plat/x86_64-wchar_t2.xml b/xen/tools/cppcheck-plat/x86_64-wchar_t2.xml new file mode 100644 index 000000000000..b2dc2fb2cc50 --- /dev/null +++ b/xen/tools/cppcheck-plat/x86_64-wchar_t2.xml @@ -0,0 +1,17 @@ + + + 8 + unsigned + + 2 + 4 + 8 + 8 + 4 + 8 + 16 + 8 + 8 + 2 + + diff --git a/xen/tools/cppcheck-plat/x86_64-wchar_t4.xml b/xen/tools/cppcheck-plat/x86_64-wchar_t4.xml new file mode 100644 index 000000000000..21d97b611505 --- /dev/null +++ b/xen/tools/cppcheck-plat/x86_64-wchar_t4.xml @@ -0,0 +1,17 @@ + + + 8 + unsigned + + 2 + 4 + 8 + 8 + 4 + 8 + 16 + 8 + 8 + 4 + + diff --git a/xen/tools/merge_cppcheck_reports.py b/xen/tools/merge_cppcheck_reports.py deleted file mode 100755 index 1c1b63ba56b8..000000000000 --- a/xen/tools/merge_cppcheck_reports.py +++ /dev/null @@ -1,86 +0,0 @@ -#!/usr/bin/env python - -""" -This script acts as a tool to merge XML files created by cppcheck. -Usage: - merge_cppcheck_reports.py [FILES] [OUTPUT] - - FILES - list of XML files with extension .cppcheck - OUTPUT - file to store results (with .xml extension). - If not specified, the script will print results to stdout. -""" - -import sys -from xml.etree import ElementTree - -def elements_equal(el1, el2): - if type(el1) != type(el2): return False - - if el1.find('location') is None: return False - if el2.find('location') is None: return False - - el1_location = str(el1.find('location').attrib) - el2_location = str(el2.find('location').attrib) - - if el1_location != el2_location: return False - - return True - -def contain_element(new, lst): - for elem in lst: - if elements_equal(new, elem): - return True - return False - -def merge(files): - try: - result_xml_root = ElementTree.parse(files[0]).getroot() - except: - print("Xml parsing error in %s\n" % (files[0])) - print("Please upgrade your cppcheck to version 2.7 or greater") - sys.exit(1) - insert_point = result_xml_root.findall("errors")[0] - curr = 1 - total = len(files) - numelem = len(insert_point) - for xml_file in files[1:]: - try: - xml_root = ElementTree.parse(xml_file).getroot() - except: - print("Xml parsing error in %s\n" % (xml_file)) - print("Please upgrade your cppcheck to version 2.7 or greater") - sys.exit(1) - curr_elem_list = list(insert_point) - new_elem_list = list(xml_root.findall("errors")[0]) - for xml_error_elem in new_elem_list: - if not contain_element(xml_error_elem, curr_elem_list): - insert_point.insert(1,xml_error_elem) - numelem = numelem + 1 - curr = curr + 1 - sys.stdout.write('\r') - sys.stdout.write(" %d / %d" % (curr,total)) - sys.stdout.flush() - - sys.stdout.write('\r\n') - print("Done: %d elements" % (numelem)) - return result_xml_root - -def run(): - files = [] - output = None - for i in sys.argv[1:]: - output = i if '.xml' in i else None - files.append(i) if '.cppcheck' in i else None - - result = merge(files) - - if result is None: - return - - if output is not None: - ElementTree.ElementTree(result).write(output) - else: - print(ElementTree.tostring(result).decode('utf-8')) - -if __name__ == '__main__': - run() -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 14:10:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 14:10:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448932.705509 (Exim 4.92) (envelope-from ) id 1ozeq7-0005pN-Rc; Mon, 28 Nov 2022 14:10:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448932.705509; Mon, 28 Nov 2022 14:10:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozeq7-0005pG-OY; Mon, 28 Nov 2022 14:10:31 +0000 Received: by outflank-mailman (input) for mailman id 448932; Mon, 28 Nov 2022 14:10:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozeq6-0005p8-7k for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 14:10:30 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 68c68464-6f26-11ed-8fd2-01056ac49cbb; Mon, 28 Nov 2022 15:10:28 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 27948D6E; Mon, 28 Nov 2022 06:10:34 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5BAC53F73D; Mon, 28 Nov 2022 06:10:26 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68c68464-6f26-11ed-8fd2-01056ac49cbb From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 0/4] Static analyser finding deviation Date: Mon, 28 Nov 2022 14:10:02 +0000 Message-Id: <20221128141006.8719-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 This serie introduces a way to suppress a static analyser finding providing a proper justification for it. The process is explained in the docs/misra/documenting-violations.rst document that this serie will provide. The tools currently supported are eclair, coverity and cppcheck, but the design is open to support many other static analysis tool. The changes are split between the first two patches to reduce the review effort, the first patch is introducing the deviation process for the eclair and coverity tools, this is because their analysis system is similar. The second patch is introducing the same deviation process for cppcheck, modifying the current way it is called from the makefile and improving its analysis. The third patch is a fix for a tool used for cppcheck and the fourth patch is an example of how a deviation can be applied for some MISRA findings. --- This serie was pushed as RFC and collected many feedbacks, thank you for the review. In this serie to analyse the codebase, a script is used instead of integrating the process into the makefile. --- Luca Fancellu (4): xen/scripts: add xen-analysis.py for coverity and eclair analysis xen/scripts: add cppcheck tool to the xen-analysis.py script tools/misra: fix skipped rule numbers xen: Justify linker script defined symbols in include/xen/kernel.h .gitignore | 9 +- docs/misra/cppcheck.txt | 27 +- docs/misra/documenting-violations.rst | 192 +++++++++++++ docs/misra/false-positive-coverity.json | 12 + docs/misra/false-positive-cppcheck.json | 12 + docs/misra/false-positive-eclair.json | 12 + docs/misra/safe.json | 20 ++ docs/misra/xen-static-analysis.rst | 90 ++++++ xen/Makefile | 116 +------- xen/include/hypercall-defs.c | 9 + xen/include/xen/kernel.h | 4 + xen/scripts/xen-analysis.py | 45 +++ xen/scripts/xen_analysis/__init__.py | 0 xen/scripts/xen_analysis/cppcheck_analysis.py | 272 ++++++++++++++++++ .../xen_analysis/cppcheck_report_utils.py | 130 +++++++++ xen/scripts/xen_analysis/generic_analysis.py | 88 ++++++ xen/scripts/xen_analysis/settings.py | 152 ++++++++++ xen/scripts/xen_analysis/tag_database.py | 109 +++++++ xen/scripts/xen_analysis/utils.py | 56 ++++ xen/tools/convert_misra_doc.py | 32 ++- xen/tools/cppcheck-cc.sh | 223 ++++++++++++++ xen/tools/cppcheck-plat/arm32-wchar_t4.xml | 17 ++ xen/tools/cppcheck-plat/arm64-wchar_t2.xml | 17 ++ xen/tools/cppcheck-plat/arm64-wchar_t4.xml | 17 ++ xen/tools/cppcheck-plat/x86_64-wchar_t2.xml | 17 ++ xen/tools/cppcheck-plat/x86_64-wchar_t4.xml | 17 ++ xen/tools/merge_cppcheck_reports.py | 86 ------ 27 files changed, 1557 insertions(+), 224 deletions(-) create mode 100644 docs/misra/documenting-violations.rst create mode 100644 docs/misra/false-positive-coverity.json create mode 100644 docs/misra/false-positive-cppcheck.json create mode 100644 docs/misra/false-positive-eclair.json create mode 100644 docs/misra/safe.json create mode 100644 docs/misra/xen-static-analysis.rst create mode 100755 xen/scripts/xen-analysis.py create mode 100644 xen/scripts/xen_analysis/__init__.py create mode 100644 xen/scripts/xen_analysis/cppcheck_analysis.py create mode 100644 xen/scripts/xen_analysis/cppcheck_report_utils.py create mode 100644 xen/scripts/xen_analysis/generic_analysis.py create mode 100644 xen/scripts/xen_analysis/settings.py create mode 100644 xen/scripts/xen_analysis/tag_database.py create mode 100644 xen/scripts/xen_analysis/utils.py create mode 100755 xen/tools/cppcheck-cc.sh create mode 100644 xen/tools/cppcheck-plat/arm32-wchar_t4.xml create mode 100644 xen/tools/cppcheck-plat/arm64-wchar_t2.xml create mode 100644 xen/tools/cppcheck-plat/arm64-wchar_t4.xml create mode 100644 xen/tools/cppcheck-plat/x86_64-wchar_t2.xml create mode 100644 xen/tools/cppcheck-plat/x86_64-wchar_t4.xml delete mode 100755 xen/tools/merge_cppcheck_reports.py -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 15:19:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 15:19:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448978.705564 (Exim 4.92) (envelope-from ) id 1ozfur-0006fA-92; Mon, 28 Nov 2022 15:19:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448978.705564; Mon, 28 Nov 2022 15:19:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozfur-0006f3-5Y; Mon, 28 Nov 2022 15:19:29 +0000 Received: by outflank-mailman (input) for mailman id 448978; Mon, 28 Nov 2022 15:19:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozfup-0006ex-OM for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:19:28 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0625.outbound.protection.outlook.com [2a01:111:f400:fe0e::625]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0ad82e59-6f30-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 16:19:25 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8147.eurprd04.prod.outlook.com (2603:10a6:20b:3e0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Mon, 28 Nov 2022 15:19:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Mon, 28 Nov 2022 15:19:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ad82e59-6f30-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oDqbld8BRHVog89MIek3yC27EM2NHX5FteJWrLcwzxGk5cxnZ2QCmNJnnpXQTVztZoV148oFHApItAOklhNqomnhZp7KvctVWhXMQTd8RaBQZmCse6lqQ2SHCWp+N1ZLppRVikjJSuryvkJg5hq9eQRqt0hFEu2FNDdwkIPs/Mo4/HRSRUPbIt+dKWgyePPi9w+ZHGGJFq4M96GMsx/F9oMKlv4AaJWJ/crYD0s2/OrX1v5iUWo/DRA5CZTXhhYKaOR27HxiLuRTXWgPpBNZeCC84C3qgAUR/x0RgQE/y9sa5W3YOsgVvDO0LL0NW+Arz/kFLn+flaC3MUJiVtq0wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AyhwHJWkwwebNwKOaPY6gXrxD5spEWmGxy/VhVWFRIM=; b=XTM6D4DAuke0wBQ/90EeZLxK8IhzYUNZvUMYClm/K57zMeuSLPY60aoea0H8FMPwIScdEEEl46u10PcbHXcdgf4khkVKq8E//vmZCqoXK68sDXB0xosmv5AvTxbmaRnTLCATozFro61xBysHcE5NAFmZ3eyvcETVqdEnOitk42D3Iy/Sa44oLSud18VOIc4dNKKmuneGFc807LJRUDOOmoMN+4q0c/jM0h0+OQiW0XNJkuYkcOBxPo6MmJhhYMWw5rJHzq07SBoc3NEgT0vV8jLSuioM7GRkzP1ekgA4eZZdWPdP3OmlqY6DdATHClsZV82eSobH+fFyhQsg+9xqgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AyhwHJWkwwebNwKOaPY6gXrxD5spEWmGxy/VhVWFRIM=; b=DVeR83RMGfsVPQXex/UljIci3MADTxEoWUeRLnVIdTxsgR+iyKKcXI/88X9ljoOxEiQyVdJ+u15JSWs8j+s95UmlhEKeCMpU/tGTtWaCZ2blTbSvXpqPLuv8+ExfDsFBDytJbNLsMmi/gQ/91kGBt5DFA0CzoEePMsC/HjdDcPwsP9XenE/NJ9fLtcAdfd6ukhGUOMXnIV7/l3+o0Sc7lCADIG0Z40bh1umjToJeFO/4JHyuWqD7K5Jutlspt6O6KABHUF2PgE5rIuWkKNDCVlnuXNN76AZKYiiWeMb6s8y0UPA0CUUj88Gb2mn4q+0zaRcujaMzMtAiXLehUvXhZA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1a0f27e6-1b0e-d5cb-7f3a-337b9664eb75@suse.com> Date: Mon, 28 Nov 2022 16:19:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/4] xen/scripts: add cppcheck tool to the xen-analysis.py script Content-Language: en-US To: Luca Fancellu Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20221128141006.8719-1-luca.fancellu@arm.com> <20221128141006.8719-3-luca.fancellu@arm.com> From: Jan Beulich In-Reply-To: <20221128141006.8719-3-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0178.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8147:EE_ X-MS-Office365-Filtering-Correlation-Id: eeca08a7-9587-4bb5-61f2-08dad153edf0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EA6ItVLSgw+hNJ74iYe3EVPnWOdXkjeDMi3Nko9epwEnH8BU9s8j/AqCPK9gvBKT67O21E7+Id/Qy1uNEDJv1XFabCZ7NYyK7NowXN9k/iiVnIkyp3QFfu+yvwMySVmiNM1kzIYyaLehYKoCtUSrgZ9/IFuEW5YVu/BVJgRoIKmmREq12sGm/hxb1beLpq1UMjpWhf+Xi4lbDLTCx/e3SU1fSjagqFnYe9AlEaU4HAMI3RrO2vfoXy6eVr6VnsGN49csVVI1z/kOR2UY2QAwmwo/PTzk+TttEdmSS1ZtcdLx2do3/GJy9qjaYz41KlOSND1Q/nu8KCxYjBvS+dpJpJjtQPi4TZ5PXW7FXtBBxF66Ztcu3UnzfzVl9XKroCJgcXm9xFuWZbKk7JIwVG9L0ScL6vT/5wFMWMTRDU8UkxJysc7NFs/FVEaHeDr7fUHzV1jzE7QgW9OHzCVjk+hXKhnVDhwX/0wUZbLJ+nJtzsdhAmji1XePLdTpgB5cegkOiEQktfUWwxx59/Tzt+h4QnfxBdpApVwHYkpF+HkleJ5AAYZMD5OvC9Qicw9BZb6ZW1xoC7IziRn9urwPMhfzZE03ZwIUkNbpsm0GFkkUSXS7FZJGyiAXqqskIeumFLFZduUaz8VwTPbIuCjew7ZK5QDEtVDJ00gij3C1bTfUjElGcHP/OU2YjQ0wTyslPFL0AhRGKWh/I9OunRpLtycsSe4G9xWwQUr/wV5b2LEVDVA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199015)(316002)(478600001)(66946007)(36756003)(2906002)(6916009)(54906003)(83380400001)(38100700002)(26005)(6506007)(53546011)(6512007)(86362001)(31696002)(186003)(2616005)(6486002)(5660300002)(31686004)(8676002)(41300700001)(8936002)(66556008)(66476007)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEFCRmppclhjTjFlelIxMVpiNzd4dHhVU0pWZWtGM1lHdnNUNnd5TmtPMFUv?= =?utf-8?B?VDJxaDNQSTdGNHBpMVU0eFhJVDg2UGpvcU5KM0JMWmtmbFBQdDZwclpzaUFM?= =?utf-8?B?ZEQ4dWIzNmxvQ3JrRGt6aGdpMnVrV29ucVNEYmRrUkllckxvaUg4WVFDWFpi?= =?utf-8?B?Z21XU0gzRGhKS01lRjZsa0tlV1VBN3hhZlh6Y1hQSkFvTFp5R1dGSnNOdk8v?= =?utf-8?B?VTg5MlIvU3Y5Y0xrQkhRSkxoQVN0d1pNcmFJd3p6b3czbHV0SkNBSUIweXpx?= =?utf-8?B?UkIrb0pka1VqdXlJZzJpWFR2UWo4eElQLzJBekpyWUxGT25vTDJiclduTjIz?= =?utf-8?B?MEJWTk12QVlQaHl1RlZGNE00dVdFa2xtMmxyU3ltRVI5SEdIZ0ZPbkM0cWZO?= =?utf-8?B?ZklrSXBmT2k3WnVhUnFJbWxlR3lkRmhKdStmZWNxZHFubE90Nk9sTFZaUlhC?= =?utf-8?B?MmhyQk1OdXZINUp6dVdOMER3MTB0VVJvbit2MnRhcVFyYTdvRnU4L0cyT2th?= =?utf-8?B?Y20zWlVUeFdHMkFCUEJRYUMwbFE0RVh0bFBubHZSbnB2SWJBK2FyaWQ2ZHB5?= =?utf-8?B?VW1IalIwQWdaemVCaU16SGZvZFk3TzhDenE4RytSb3F2VWFQVGtjcmF5blh0?= =?utf-8?B?MnptVk5QaXc2V1VkbnN6cVRmOUZlZTNSWXQ2NGJWS3ZlQzBRTEt5NC9vUlBH?= =?utf-8?B?MjgwdGQrUk1YK2FQZmdiYk1SY29MN24yMXhPREM0QVpBMEt1dWVvRXVoWGxj?= =?utf-8?B?eGFTT0J6czQxd3o3Z1d6N0ZPODVlekx1UW4wOWdNWXNqVklpK0VEeDZRR29F?= =?utf-8?B?S2JMM1VKY1BETEdoM3BuQnVEZnN1RU9ZNkhZUFJkK1ZoWk9rL0kxV2wzN3lN?= =?utf-8?B?UldiR1RhcUllS0szR0ZyRzBvWmxnNnp2R1I0cGRIeFJ0VTFOeVl2THpJWVpW?= =?utf-8?B?d0FFVjVxc0hNV3JvZ0Nsalp2UHhKVndGSy94dThpQXFkc1dkZmJqS1ZFbFFU?= =?utf-8?B?R0ZzU0doL2Q2ZnFqek9Kb0U0Y3JDMlBacE9ZOU5JUEVLT1dVS243RU96TWFZ?= =?utf-8?B?MlMwaW9FWUhjemhHQ1JzUnVqOWZqeDdrYktDQkZva2VoT1VVcEd2WGNBYTFJ?= =?utf-8?B?NkNhN0FNMFVwOFcrcFpUN2FtMFNENUZ3ci9VdnhadWp0aWhDVjU2SzZRSnlF?= =?utf-8?B?cDUrTG5qZ3c1SE9xL0UvOFpIWUZmZUVwNEppM2wwRDBJbm9iRUlMb3BxLzNr?= =?utf-8?B?Y1ZiK0NZMU0wV3M5NEVIZnQ5aHdZZDJEd1Q4VTdJY0tpUHgzV25MLzNacDZo?= =?utf-8?B?dEV6MEpGYTkySkhMbUZIZWJtT0ZtbEhVTnM2VC8ySlhST3BFYmEva3FVZXNY?= =?utf-8?B?Y0pDYWpJQ1kveVBML3FjeEFnUUQrdloreEROa2pONWNSUlgyYUtOR0tDWEZv?= =?utf-8?B?d3RHbVdzQmE0cnBkWnlpa1cyci9yYUFlc0pEQUtnUXQ5eVFKTXI0UUNZOXMy?= =?utf-8?B?RUNnUERLQ1VPY0x4U1lqSWVnZFIwTFFrSCsyZHA3b0NFbkVHMDJERVUzNUdy?= =?utf-8?B?VzY0a0o0ZGZZbDBsMk1kYkRVakR3bnMxWHl3QUx0OEVZWFdmemtlOTEvSmk5?= =?utf-8?B?YW9taWgwbURTRittSlNka2l3THhyVUR1Y0dDRHdRQkVhLzdXUllVamJVWThG?= =?utf-8?B?MXdjd2ZyQm1pTFZYM2NmdnBkd2hKRDZJbnhBU2ZtOGR4VE9xSU1wZ3VBNmxX?= =?utf-8?B?WGV1Z1o5WDVYaVEzbDZtRkpFbk1lZ2wvQmlMUjhmWFo3cmM5QjlIZUN4aVpS?= =?utf-8?B?NnlvYndEdFJ2Qkt0Ump3KzhwZmpnRWZMbE1CVVN1Y25VWGU2NERuTnVScmNM?= =?utf-8?B?MFhtMERxc2E1dUF1SFF5UUlBNjRhT1VTYzJqeGpPT0QrR2UvMk1IZGN0dUQ0?= =?utf-8?B?cnJ3Ky94TFMwOElvOVQvWGhFVVJVOVZVSmoxRDhYTFNCbTRjR201ZDNBaGRn?= =?utf-8?B?MmVZSW56SS9DZXNqNURUdHlBOWh0T2NBQ0txMFVSVWRKZWRhbUc4WlZPT1RL?= =?utf-8?B?VysvL3lkOHJEMnpDZmFGMHFqZnFVZjZCSGRnZDd6VFM0S3pheGJnZXRQcVJL?= =?utf-8?Q?6PFphDcqv6Hsk4Izogibggm/W?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: eeca08a7-9587-4bb5-61f2-08dad153edf0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 15:19:23.1884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rlO83mPFR0yt92UkzRIsJNzqdy1H8WE1jlTOQUoMZ/l3ppjHrN9x6aV0ILdf/x1RtkG3A9qyuT9StXt03zmjbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8147 On 28.11.2022 15:10, Luca Fancellu wrote: > Change cppcheck invocation method by using the xen-analysis.py > script using the arguments --run-cppcheck. > > Now cppcheck analysis will build Xen while the analysis is performed > on the source files, it will produce a text report and an additional > html output when the script is called with --cppcheck-html. > > With this patch cppcheck will benefit of platform configuration files > that will help it to understand the target of the compilation and > improve the analysis. > > To do so: > - remove cppcheck rules from Makefile and move them to the script. > - Update xen-analysis.py with the code to integrate cppcheck. > - merge the script merge_cppcheck_reports.py into the xen-analysis > script package and rework the code to integrate it. > - add platform configuration files for cppcheck.. > - add cppcheck-cc.sh script that is a wrapper for cppcheck and it's > used as Xen compiler, it will intercept all flags given from the > make build system and it will execute cppcheck on the compiled > file together with the file compilation. > - guarded hypercall-defs.c with CPPCHECK define because cppcheck > gets confused as the file does not contain c code. > - add false-positive-cppcheck.json file > - update documentation. > - update .gitignore > > Signed-off-by: Luca Fancellu Just two and a half questions, not a full review: > --- > .gitignore | 8 +- > docs/misra/cppcheck.txt | 27 +- > docs/misra/documenting-violations.rst | 7 +- > docs/misra/false-positive-cppcheck.json | 12 + > docs/misra/xen-static-analysis.rst | 42 ++- > xen/Makefile | 116 +------- > xen/include/hypercall-defs.c | 9 + > xen/scripts/xen-analysis.py | 18 +- > xen/scripts/xen_analysis/cppcheck_analysis.py | 272 ++++++++++++++++++ > .../xen_analysis/cppcheck_report_utils.py | 130 +++++++++ > xen/scripts/xen_analysis/generic_analysis.py | 21 +- > xen/scripts/xen_analysis/settings.py | 77 ++++- > xen/scripts/xen_analysis/utils.py | 21 +- > xen/tools/cppcheck-cc.sh | 223 ++++++++++++++ > xen/tools/cppcheck-plat/arm32-wchar_t4.xml | 17 ++ > xen/tools/cppcheck-plat/arm64-wchar_t2.xml | 17 ++ > xen/tools/cppcheck-plat/arm64-wchar_t4.xml | 17 ++ > xen/tools/cppcheck-plat/x86_64-wchar_t2.xml | 17 ++ > xen/tools/cppcheck-plat/x86_64-wchar_t4.xml | 17 ++ What are these last five files about? There's nothing about them in the description afaics. > --- /dev/null > +++ b/xen/scripts/xen_analysis/cppcheck_analysis.py > @@ -0,0 +1,272 @@ > +#!/usr/bin/env python3 > + > +import os, re, shutil > +from . import settings, utils, cppcheck_report_utils > + > +class GetMakeVarsPhaseError(Exception): > + pass > + > +class CppcheckDepsPhaseError(Exception): > + pass > + > +class CppcheckReportPhaseError(Exception): > + pass > + > +CPPCHECK_BUILD_DIR = "build-dir-cppcheck" > +CPPCHECK_HTMLREPORT_OUTDIR = "cppcheck-htmlreport" > +CPPCHECK_REPORT_OUTDIR = "cppcheck-report" > +cppcheck_extra_make_args = "" > +xen_cc = "" > + > +def get_make_vars(): > + global xen_cc > + invoke_make = utils.invoke_command( > + "make -C {} {} export-variable-CC" > + .format(settings.xen_dir, settings.make_forward_args), > + True, GetMakeVarsPhaseError, > + "Error occured retrieving make vars:\n{}" > + ) > + > + cc_var_regex = re.search('^CC=(.*)$', invoke_make, flags=re.M) > + if cc_var_regex: > + xen_cc = cc_var_regex.group(1) > + > + if xen_cc == "": > + raise GetMakeVarsPhaseError("CC variable not found in Xen make output") What use is CC without CFLAGS? Once again the description could do with containing some information on what's going on here, and why you need to export any variables in the first place. > +if [ -n "${CC_FILE}" ]; > +then > + for path in ${IGNORE_PATH_LIST} > + do > + if [[ ${CC_FILE} == *${path}* ]] > + then > + IGNORE_PATH="y" > + echo "${0}: ${CC_FILE} ignored by --ignore-path matching *${path}*" > + fi > + done > + if [ "${IGNORE_PATH}" = "n" ] > + then > + JDB_FILE="${OBJTREE_PATH}/$(basename "${CC_FILE}".json)" > + > + # Prepare the Json Compilation Database for the file > + create_jcd "${COMPILER} ${FORWARD_FLAGS}" > + > + out_file="${OBJTREE_PATH}/$(basename "${CC_FILE%.c}".cppcheck.txt)" > + > + # Check wchar size > + wchar_plat_suffix="t4" > + # sed prints the last occurence of -f(no-)short-wchar which is the one > + # applied to the file by the compiler > + wchar_option=$(echo "${FORWARD_FLAGS}" | \ > + sed -nre 's,.*(-f(no-)?short-wchar).*,\1,p') > + if [ "${wchar_option}" = "-fshort-wchar" ] > + then > + wchar_plat_suffix="t2" > + fi > + > + # Select the right target platform, ARCH is generated from Xen Makefile > + platform="${CPPCHECK_PLAT_PATH}/${ARCH}-wchar_${wchar_plat_suffix}.xml" Purely cosmetic, but still: Why is "t" part of the suffix rather than being part of the expression here (allowing e.g. a grep for "wchar_t" to hit here)? Jan From xen-devel-bounces@lists.xenproject.org Mon Nov 28 15:19:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 15:19:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448980.705575 (Exim 4.92) (envelope-from ) id 1ozfvL-000732-Ge; Mon, 28 Nov 2022 15:19:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448980.705575; Mon, 28 Nov 2022 15:19:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozfvL-00072v-DT; Mon, 28 Nov 2022 15:19:59 +0000 Received: by outflank-mailman (input) for mailman id 448980; Mon, 28 Nov 2022 15:19:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozfvK-0006y3-F2 for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:19:58 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20629.outbound.protection.outlook.com [2a01:111:f400:fe1a::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1dc8b5cc-6f30-11ed-8fd2-01056ac49cbb; Mon, 28 Nov 2022 16:19:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8147.eurprd04.prod.outlook.com (2603:10a6:20b:3e0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Mon, 28 Nov 2022 15:19:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Mon, 28 Nov 2022 15:19:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1dc8b5cc-6f30-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RGnl0TJn/wJXN6BPEaBPKyv+Xz1mZA50DHUc3sUMpzh2yEcpTdYmISjQh/Mm1Y+kdv60gDvu8l9f4shTu1JRW9qhit5k/j2IHEUGKrf70iL0Oa+jqnBewZXJYshMKnI9g1sNek31Fe57iAsgOP0ImVm6Lt5T8ZWqjI570SWSe0aeh7LTQnf4oX1i7zkk/aaipJq+PNvgiIYnmjZ85S+BsU2+DCVLFweRkyovXkiogFht0OIXyfeiaKKSZUyMOjRjMr2BK0rGjJNjxo4qxkWHB0ZItruZfnXBakE+gaFKXBwohZT0hFDPse1VhKQZKyWQwgHxx8INQqezNfExU43LPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GzVPwWMa89s+yehIoKdNhe5yT+pBINAK4y5HD1plJU0=; b=JEN8cklF4lwSu5mXlbzWerftyZZwGUCoo7becoAdF8u/z3v8Lfdul+Dv4cRgMC6m6hhzCueEGkwJ2SAgLvV4ss+x5onHzgEaB7HHtMOnRUqp0Onp3cWWUaf7rigBnsJyXkYocyCVIEPTQzOFKFoGdRvU50JZGiDn9lq3vcdm3fIyi86y4oMoj+WqzLyjcSDNdIsqAQmLLujyayx648d3rHUMLT6XBqiw60vle18x40fMFbgqq9+EQR8K6fAo1qbRStT8KZi6TyS4tHxTiy6oNidvlajXnbjsGi1C9rwJpHs+27WOchHGALAzqJSkdwrzlOgKt2ecQOfwWXOuO2HfXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GzVPwWMa89s+yehIoKdNhe5yT+pBINAK4y5HD1plJU0=; b=Wh8FaazTbOX/TC/xiZHltuJv7B8BquIfM5arWr3JSLzt0Vj13sS2hMT36ZT9jIE7vZrsC/wvi2iRli8nRQBkTcF0vW1FXUssTQuMOqn9ukHgvCy4OzVkoTa+I0Ye1x8Ctsp0U6cyj8ENJjhxsjBrJCODc1ek75DyQduTT6xvqLDgFd94ob1t5wnEO7aC22eXhsyzVZzDeW8dxl5yMhcJ6GpZFbFO7RrGDjzFzwz+I9dI13znaLILEdNtKRoqhSYYLQJOhLr9WRr6SEEeWqqaBkXGgcL0mcsXdeemjtE/gU4onopSXc+oHmIzXzmRSS7+ppwBukYBsI3eOD+SuAHtrQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <87000198-5aa2-35ed-6946-068eedb34f3d@suse.com> Date: Mon, 28 Nov 2022 16:19:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h Content-Language: en-US To: Luca Fancellu Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20221128141006.8719-1-luca.fancellu@arm.com> <20221128141006.8719-5-luca.fancellu@arm.com> From: Jan Beulich In-Reply-To: <20221128141006.8719-5-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8147:EE_ X-MS-Office365-Filtering-Correlation-Id: 81a50410-518d-4155-644b-08dad1540188 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gvNDm60GBhAE1iFTiPdRlWn6IefJeRqa1yQeToV86SvQz6X++Hn3CZ2DEQWq7+SHDcYf8apAz4gW7kExXBRZ+4N4tRbarNjn+SWF7fkolCaC8/AH2lyTB9d+ovMfIJ8JNdNT7qPZtLH8u9vUVaPUupkfC+x46BUOyDeeWw5fJmth/gnaBA/mxmO369f9PN8MZ45yyFqJOB1wTVPJSqLgIeqC66pQpKOiIT6/T6wwfOZXevGnOGUWF5jx11Sh8go5jdXrVUOD3z0Lfqs07BJXWTughhhtaFNTlij5bOSoEiNihGHeKF9N0xtLKJjeh/jTZbP2JP5ksOTOlLd+etuWQqeSy8qpi+s+n6wtOTfbzsZ6wXA5qykVWIVv0/1coKNwZ1TXoyZSzfVSuWYbR5h/X/JjFF0nU25XPlFvpVSTlWLdB1ELOUFloTI42ON29Kv7AxFhaQr5gbZjoOmOX1PSG7c9Z1B+5zRqsugVBzU8Dofl/vv/LsWAC5ZGycHq3JNUJdDl7oBveI96xDGtxkh/dBMF3ulFdTvSy82OQiupuqw8CKcDj4KVuP6qayICCw8zjN+T2m5cQnemWfENY7R9t+l5CDzqJzbeQKlk6TOL7aoDSYUOMXJqI5w4eM/gzM7erQ82nza6RfVwyyQ40z/gNd16t5Tdr6S8Ds4s6DYvC136ZYcRgpL7AD/VmiHc1Zlg9QYSOVUfPBJQYfc+eFztVu/PiDbZS9Q/WIGDB5sYyRk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199015)(316002)(478600001)(66946007)(36756003)(2906002)(6916009)(54906003)(38100700002)(26005)(6506007)(53546011)(6512007)(86362001)(31696002)(186003)(2616005)(6486002)(4744005)(5660300002)(31686004)(8676002)(41300700001)(8936002)(66556008)(66476007)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUVIeDFNTnFIbi9RdGpxM281NmVBMGdZb25ubzBuZ1pveG0ySTYzYlhNSENr?= =?utf-8?B?ajhiSFc5ZWViTFRNSjNnbElHZjl5ZzI4Mmc0dmZ1a0tjOFI3QkpqNUUwaElP?= =?utf-8?B?M0Rib29VSDZvekd6MEUvZEJ3Yk4xaFF5YXl5bUZGc0hwOUR2aVRwcUxIT0pp?= =?utf-8?B?aFRmWi9EV2w5ZjBsTkNLZjdneFE5ZlFLUmpDWnBJbFNTWlJtL1pxVVN5SEY3?= =?utf-8?B?TFExcEZVbFc5dzNiNlQ4UDhsMFI4aTBEdTN1WHIvUjBiMHQrc2ZFVUtkMkZl?= =?utf-8?B?WlhDSE1YOGx1WXpKcmNnNUd2TzljUDBHc29xa1RzQU8wK0JVcllEbk9hd2dv?= =?utf-8?B?UFNJTEs3L2xtZXdBeXRFWjBNK2x2QTB4QWJmWnVidGpwS1Jqb1Aza08xbWkx?= =?utf-8?B?T2FkdjkzeC9qTm8xTUd2ZG9vVGJaZlpFYzFWSXR0cU5EZGVnY2Qwcnp3UUNK?= =?utf-8?B?TjY5dnZzT1hSQk5oZDZhL2owYzdBbmx2VW1UdDc0VlFzeXlUd01TbEJoSXBD?= =?utf-8?B?S21VVCs0azllY1JLbTlkNUg1SS8yaU5ORlB5RXRvMFZjOUpKNDlCL2hvbkJP?= =?utf-8?B?T2hRSlZWVHQ4dEtuZVdCQU1UQmZjdnFFM3MyU3BjR3hua090eHVLQkE0aGwy?= =?utf-8?B?UGxUSExVRGxsZjJWdmxvMTRkSmZRTGJURlRVSE55aVdBdDdjVXJRWVFtYnpV?= =?utf-8?B?UE9FQzFqWXRvcTN0U2VEQlpCMmNNMUV4NGZVL3JMWjcva1ArVDF4K1NWNGVs?= =?utf-8?B?aHdZNjUxZDlveGlPY2p6K1MycXhIK1FBaUxGSmhlbEcxSnc3RmlFUUZQbFpP?= =?utf-8?B?MkxpbEFkaWRpcXlrVFk2OEdUUUovcncrM2Rwc09CR3l1SzVNeEF3QjQvaVVT?= =?utf-8?B?d0dUdU5wQ1d5bHVZK3g1TnNmcTF1YWJ4a0hDUjh2N051T20rWVBMcHkvK2tz?= =?utf-8?B?cmRwNW5VMldNR1l5UVBzaUZUeU9Wd1dhREovUml1UUpucW5odUZSejJUTSt5?= =?utf-8?B?ZExlNmR6MHp2WVYxcjU0MHk3NXdWNUIxYVk3VUYrYkNrSVZGdG5YWmdjTzkx?= =?utf-8?B?TDZPcUZMTjlyTUdoeEd1U0RHN2xHd3N5enR0bUNrdEFLMmJWWXN0TCtOUVNH?= =?utf-8?B?WnRDMDdLZzVsRGNEa3hCdlUzN3JFTHlaV1pqUFJ0SFZpdlhhWkxOZlpESTBB?= =?utf-8?B?SHp0ZzBXU1k2bmdRcWgyQnF1UFdGbWtUUTc5K0JHZjIyU0pwWjJQWk42VzZN?= =?utf-8?B?ZnFXVW9CVG1DeEZXS3pCRU92Zlk4emxpR2VKeGl1RHVDS0JndjdVVEhxMGJr?= =?utf-8?B?ME41L1BpM3F2eFdRN0NMY3VpNGsxaUpwQy9iWGZ1YmYwTE1CNnc4VEQ0bWNK?= =?utf-8?B?RmZKbUVBcHJNck53RU1JL0tIazlhVCt1QkRwblQ5NUk2ZGxXREE4Z05tNEhw?= =?utf-8?B?Y0dwUzZYb1dkdmdwTklSQk42MnVoTTRGMmlkeDJjQWhPdUN2dVRqTjFzU2hp?= =?utf-8?B?eFdQOExYUWUvTEFvWXI3NVpiNExCTDBsM05xL1pmM0dJQXlUYzVaRWQzVmw5?= =?utf-8?B?bllkVUVDQ3I5N0lYcnpPU3BBY3J5bHRHcVhka2k2KzBFTkljMVBtNkhMMVVU?= =?utf-8?B?RWI3WnZTTUxXVlV4Q0wrM3lyU0lZRDBBYXZnd1NINnAxbGxzNGNlTE5nTE8r?= =?utf-8?B?aTNDTTIrUU9RdWVTSmcwb01tejFUcitYUGd6dWRkYXZFYSt6WGR4YkJySUhU?= =?utf-8?B?Z1k4RTdxTWlhSTdMWkdpMEU4WjJEZ0V5dWtRemtjRlBrR3YreVVEamVzbmUx?= =?utf-8?B?aVdTY0hhWEJUR04wUFduUDlZbTJTMDN0MmkyY0lsOHZrL2tmU2VGejRDZi80?= =?utf-8?B?M21DS2pGdks4eGFnSFdWYnIySUJzaDVHWDZHMEwvVytueTFHTHFiRG9sWlFh?= =?utf-8?B?clpoNFlaVUo0ZHRPSGNDc0FXeU4rNzNBeXNucXcwTGlhcnBGU1VLRThpdEIr?= =?utf-8?B?cy9tcVZ3RU5XT09IdXBHQnFDOC85NUpGaHdPOTRra2s0OFFDNTNCQUxxVDQv?= =?utf-8?B?T3hMS05pVDBFdVVhMzFkTHZCT0ZGSW1Ed0xEN2JjaEVmNXdaZW03d1lsWTZt?= =?utf-8?Q?TM7nD0n+dWL98jXeS6x4P9o5m?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81a50410-518d-4155-644b-08dad1540188 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 15:19:56.0614 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eLASc+qgIEhR0fdJf6PT1lQvQNGDhVwZK+5YxLm9FkCmU6749ZwHeXqzCLsiCo2bhXdbe96dKicjNLc4w7Berg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8147 On 28.11.2022 15:10, Luca Fancellu wrote: > Eclair and Coverity found violation of the MISRA rule 8.6 for the > symbols _start, _end, start, _stext, _etext, _srodata, _erodata, > _sinittext, _einittext which are declared in > xen/include/xen/kernel.h. > All those symbols are defined by the liker script so we can deviate > from the rule 8.6 for these cases. > > Signed-off-by: Luca Fancellu Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Nov 28 15:37:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 15:37:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.448994.705586 (Exim 4.92) (envelope-from ) id 1ozgCQ-0001Nc-1M; Mon, 28 Nov 2022 15:37:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448994.705586; Mon, 28 Nov 2022 15:37:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgCP-0001NV-Sl; Mon, 28 Nov 2022 15:37:37 +0000 Received: by outflank-mailman (input) for mailman id 448994; Mon, 28 Nov 2022 15:37:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgCO-0001NP-Bu for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:37:36 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0611.outbound.protection.outlook.com [2a01:111:f400:fe0e::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 92e02579-6f32-11ed-8fd2-01056ac49cbb; Mon, 28 Nov 2022 16:37:32 +0100 (CET) Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS8PR08MB9120.eurprd08.prod.outlook.com (2603:10a6:20b:5c1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.6; Mon, 28 Nov 2022 15:37:29 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.5880.007; Mon, 28 Nov 2022 15:37:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92e02579-6f32-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DJXwwtiIT5PjxwygeXd7EaCUznWB6nmk98LnBRFL3aeUX9rgwjT/0cirZezor+THnB6PpT5f5j9rJ3ovAhlGj7WhMgfgvn77vd0Lgqd/oX8Uk66mYLcxvHp1Kqo9UdNbcjklkCeB+H1+38nxrCqIiXYG31pGeQ2GwyN7FKEEqQQ2HPnOGcSdUi1DRAdg7GTlk8swL5w6CJwPWxnqDD/wn4Wo3vFfyl01VvTvGsX2QceBbJ0Mikm+QdOVWJ15FwPamITNd3mTqO3Dm9FKCPztbQoRmBTk+RGuqY1wzDIBaBeNYnN7NqZPRoVwH3Mq2IAsNMyt8pMzJCHWgyWtPQWgog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M4QjFH9yuMK4wEyFobN9VZh9H2q40k4XUrfuAoS6jxE=; b=Jtye713Gw9BX66PhLdBqZtxZ1zSl1T9iFU0H+pPYszVJGgzzAlDD9/wvCzvVfRn3mHE0L0ipIEimXXGYyM53jMBtEaNlNfboOhTPCq3dEQsT8G0JYfvyRZ6veLNzwN+CKeQcRZGVcTvC+x800aNTfQ5BqYrM8s5+VEVnqgU1duOxe8dPn4mCXgN7K6/+iCHAVfTyUrFFN/FweTHpbxBN7sxGfueTHq6j+Bb0KohsvKoXNDPsS+rY87dHKkYa0yxtb+UbuQyvDouaz9Nrpu6vISB63PLYBg1cQTl8dChLdjtsQ1ZMDpYXzJOXYVmNZVUCas1nwZ9m+PcBTWS0rU5wbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M4QjFH9yuMK4wEyFobN9VZh9H2q40k4XUrfuAoS6jxE=; b=GIDfOLQCt4DuhfwPMlzgQawkhqPt7qDTscgErPXW/EeU12ubLPtfKFCWvy9Xxv31+RW40CzQ6kg7/w4yH1RF8NqExg4xq2pNsjnJcwYScAf1b0B8pczQNJNGBMHacoDdrJ7AFwggQc4ncNk580ZiEMktBaKNJ0R3/RfWGULz0ss= From: Luca Fancellu To: Jan Beulich CC: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 2/4] xen/scripts: add cppcheck tool to the xen-analysis.py script Thread-Topic: [PATCH 2/4] xen/scripts: add cppcheck tool to the xen-analysis.py script Thread-Index: AQHZAzNLrQ+cdSzeJ02hq/RTLwHjha5Ucy2AgAAFEAA= Date: Mon, 28 Nov 2022 15:37:29 +0000 Message-ID: <35743861-CF6F-4B80-AFE9-182D34678FC8@arm.com> References: <20221128141006.8719-1-luca.fancellu@arm.com> <20221128141006.8719-3-luca.fancellu@arm.com> <1a0f27e6-1b0e-d5cb-7f3a-337b9664eb75@suse.com> In-Reply-To: <1a0f27e6-1b0e-d5cb-7f3a-337b9664eb75@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS8PR08MB9120:EE_ x-ms-office365-filtering-correlation-id: 6137404e-40a6-4f61-8287-08dad15675b1 nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qyo8qIlI8jYA8JphmAWyB2JAJqzC9z3EEQU+gVVzPeb6ypNOTXCpdVlUhlRRPdN7dvfOzy9eFd8wVZAEQwaGfYJpY4P2cbP70qpMm8kZY2KO4s8u9U65jN1yT8J1OGZBikY2n3ejyALIHmrUrG1FJ879C0Df3NUx1A2sUqTLX0FmqamuJ8yx0bh9GN2Ae1xIG680WH9pwb2UCeLWL5VWNkjb04P9ra9ynspZ03SN0meHJ1GCVQ3nae51V6NM4xgRpLfWqezu9ySlyrf4+ddL8nqt/JNYKV6eXAioATFiU7vC9R29vqtypFOpIzTKnjL+MbJpAJC66XCfuWPXoRqPJqaC15Yld0tNYOp9NeUjmnXIiZDrnVOPOPrERVa+Ka0ZKVDMY0934MCfZRJswo5gwZrxRhouuF7mSZ7nKFKvVd6wWZoF2osXL0+cmsOtN++23LrtKvCXKcaiwF2IO+sq3we+nREmLyLkD/Ex6DBDi40JDruV88oYHgZRwUwV68recqQC7C8VeoJkLXhV/2TC+eQdUWOlAUOnpmoLVF7BMmzAyG8wER2g4OPEjklFRxAJGorsGutHBGZGfX9OFxgndl9Bd43dz8yvxqEpfItumYmamrsLzcnPd4WoPvarFrAVGq4Yp4rWHtijFYF5E/NB+w37tSLaLPWqrQEW6mzMBQw/TYPwIvj0x2LY7MVyJQ8KiW8DVPZoQPqgd1h6dyGtjPoSKaBRKunvgitUOPiK8ok= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(396003)(346002)(376002)(136003)(451199015)(8676002)(38070700005)(4326008)(2906002)(83380400001)(41300700001)(66946007)(91956017)(71200400001)(66556008)(6512007)(64756008)(76116006)(66446008)(66476007)(86362001)(26005)(6916009)(186003)(316002)(53546011)(5660300002)(36756003)(54906003)(33656002)(2616005)(8936002)(478600001)(6506007)(122000001)(6486002)(38100700002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WDEzbi9sWlhzOXY0Y0grZnpCd28rNkF1Mml1Y1grZHNvbGg4Sm9vTDVDNHRH?= =?utf-8?B?MWtpTGNPb1M3RGM5NWtYTGluOWxDZGQyQnduMktFemxxTUxDUWJrcE02N0I0?= =?utf-8?B?ZzVHMHdtK2I5aU96UHJrSFZLSUZ6NkZBWkpJd2JBZUNFTE5FdjJJeWp4WVhl?= =?utf-8?B?SlU0V1E2c0FVZGZlTHhtZU9KZ0poZUFnNlpmNjJoTnlZWGpDKzBCcDVqTFly?= =?utf-8?B?MDJlWCtyZU5FbE12NWRHRW1yM2hVTkVXR2tRelUrMGptTXBrZlpOWk1lTW5x?= =?utf-8?B?UWd0Y0xNQmZ2ZDR1aUxvRTFVY2RMOG9jN0Vtc1NhamU3WmJRVjI1MzNwbEtP?= =?utf-8?B?ek1pZUV1VWdRa3E4UW9MVW9yS2w0WWN3T2F4VzJGSEJBOEJURC9JbkZveXg2?= =?utf-8?B?a1NmM1loZjNWMUZrUG5WdkdlK1RvYXVyTkJmeHJCNUtmTVl4bmNQZUh6dms3?= =?utf-8?B?VnVxdzlpVDBsYWNCaHlxNlM4QnhEaVRuaDRuK21kWGhGd1ZadWZGUWtCZUVP?= =?utf-8?B?RXFJd2FsalgrcW5xVG8rQU44WUhBY0NycVl4RkdNRkltNmk2M2RoOHhwcEM3?= =?utf-8?B?YXdaUEh2c09aY1kzWXRlQ2drcmxVNFhYbXVONGUzWkZucEVraXZUVitGY29E?= =?utf-8?B?MnJiejRRbnozRVRqanRDY3BNSHJOdkxnSkRYYVRLR1VGZnByTGhkTDRYd0dD?= =?utf-8?B?NlBYNEZsd0xvbEM1Zk9lNm5vZE00cXBWVXJqSnZjQVVSQmcxWG1GaEZIQzdJ?= =?utf-8?B?U0QrTDBMNGd2VVlWNUZubkpiWERFaG5MbS9rZC9FY3NBaWxlTTFwNStCdVA1?= =?utf-8?B?TFNEUnVCWmxRc3FhVk4wQ0hvVmxiUWlUVjRWMzVVOEd3NzE5U2x0dmhkTUky?= =?utf-8?B?cUE2Zlh3UmV0c3lxYjM0anlvaXR4VHFQTVI1UWVJQWo5eEhiYzMvbURHYjRG?= =?utf-8?B?RFdjWkkwOEZjaFd2QzJvWG9XSlZNeEsrN1JWM2NHT1VKV2RZV3o0WVE4WmNX?= =?utf-8?B?ZE91cG1OYitqZHlUZ0NFR1dDVUVZR245SUdZdUxvYmRBcDdhb1drK1BMN0ZU?= =?utf-8?B?UHpOU09KeDFHZXN4VTlCWi9IeGRKZVJNMy82T3BLTWtoSVBpd21VTlZHNE1V?= =?utf-8?B?SG03TFZHdkUrN1dDQ0xHNFdZVDhyczJudUdwU3hLcjNoN2swbW94OFgvR1BG?= =?utf-8?B?S0thQkgvSWdEOTZiVGlzM3ViR0tXR25mLy8wdGcvZ20vRFJmYi9EL1lOdkV1?= =?utf-8?B?Tys4Q0VnTVB4K2d1elRFQjFSK2FVWGlxNlgwUGpaZnIxNnpGRU9UeDl1b3ZI?= =?utf-8?B?UC8zUGtkTmppVVJUVUZRMW1pT1hRRldXN3ZGZnRJaitLUDZOVjQ3NzBURmF4?= =?utf-8?B?WjMzTGNmT0xvUXMrVEd2dkZ3Rm9MMDVlZDRBL0REQkNTaFBlWmpOWExYR0li?= =?utf-8?B?TmNHRmhyT3hlS1pPWmV4TEpmWG1iR1BBejlIZHRLRjJJMVdIRVY1NGRZMGZs?= =?utf-8?B?N3EvcWlIcjlxY3lqdEY4ZUFZdTFrOVZGSVd5UmFwc0R6Sm1LOXBlV2FVRkh1?= =?utf-8?B?UU5iU2tsMlZ0TkRRWGJqc3d4SHJpSmQwc2lnL2UwVWgxbHVVUno1NEpKSlc5?= =?utf-8?B?TUVEbzhnbkVJdDF4b3B3RlE0eTNKYUh5Tk5JQWs2aHF4SnJDbkRBU3RTRVpP?= =?utf-8?B?aEVZUTNoY3F1R1JOUzRtd2lIS3FBdFBqSVA3VTAveW9jbmZ5cHhTSno5MUJh?= =?utf-8?B?dlhHakt5M2tJb0lpdk16eXI3bGxrTVpSTjJENnhqU1VrMFJrZ2pMK2tFcVNs?= =?utf-8?B?c1JlblFidWVMQjFmSlZ3STllY3hlcnVkUEtVVS8xcXJ0SGsvWTZ5SFdVREI0?= =?utf-8?B?eitObW9nMWRqcXFNb0ZjMElybnlHWWFLZ21DK1NnYmFVU0IwWlBiWlg3QzM3?= =?utf-8?B?eEwweUQ5NWFVYWdMRkd5amFTNlRQZVlsZ2c5N1VXcFBGOVNQR3d2U3d2eXV5?= =?utf-8?B?QnhTcWRkQ0lSN2V2bklRRjZKaEduby9pbFZaejJINnFQTDNIcllleU0waFRl?= =?utf-8?B?dG83MUpwd1JhbVVyQmZodHh1akw3VUdOZitCUDFSc2NrdmhkK1FDaVZXNTZl?= =?utf-8?B?bXJNY3RKeTlpbzB5SVFYajhPRXhVU2NyeVl4cmF3cFk0UGMvNEE4N3lIZGZq?= =?utf-8?B?RHc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <4961BE38CFC9DD43BE6168B8FAF26B3A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB3749.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6137404e-40a6-4f61-8287-08dad15675b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2022 15:37:29.7681 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lipTEFrp+dvdg44COr3BEQwrIdp+xpFP8cBx9Ql8DoCOS7d2FSorsNKFm9LjP9Ma3k93MJqfwl6bTaYcoCOunQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9120 DQoNCj4gT24gMjggTm92IDIwMjIsIGF0IDE1OjE5LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMjguMTEuMjAyMiAxNToxMCwgTHVjYSBGYW5jZWxsdSB3 cm90ZToNCj4+IENoYW5nZSBjcHBjaGVjayBpbnZvY2F0aW9uIG1ldGhvZCBieSB1c2luZyB0aGUg eGVuLWFuYWx5c2lzLnB5DQo+PiBzY3JpcHQgdXNpbmcgdGhlIGFyZ3VtZW50cyAtLXJ1bi1jcHBj aGVjay4NCj4+IA0KPj4gTm93IGNwcGNoZWNrIGFuYWx5c2lzIHdpbGwgYnVpbGQgWGVuIHdoaWxl IHRoZSBhbmFseXNpcyBpcyBwZXJmb3JtZWQNCj4+IG9uIHRoZSBzb3VyY2UgZmlsZXMsIGl0IHdp bGwgcHJvZHVjZSBhIHRleHQgcmVwb3J0IGFuZCBhbiBhZGRpdGlvbmFsDQo+PiBodG1sIG91dHB1 dCB3aGVuIHRoZSBzY3JpcHQgaXMgY2FsbGVkIHdpdGggLS1jcHBjaGVjay1odG1sLg0KPj4gDQo+ PiBXaXRoIHRoaXMgcGF0Y2ggY3BwY2hlY2sgd2lsbCBiZW5lZml0IG9mIHBsYXRmb3JtIGNvbmZp Z3VyYXRpb24gZmlsZXMNCj4+IHRoYXQgd2lsbCBoZWxwIGl0IHRvIHVuZGVyc3RhbmQgdGhlIHRh cmdldCBvZiB0aGUgY29tcGlsYXRpb24gYW5kDQo+PiBpbXByb3ZlIHRoZSBhbmFseXNpcy4NCj4+ IA0KPj4gVG8gZG8gc286DQo+PiAtIHJlbW92ZSBjcHBjaGVjayBydWxlcyBmcm9tIE1ha2VmaWxl IGFuZCBtb3ZlIHRoZW0gdG8gdGhlIHNjcmlwdC4NCj4+IC0gVXBkYXRlIHhlbi1hbmFseXNpcy5w eSB3aXRoIHRoZSBjb2RlIHRvIGludGVncmF0ZSBjcHBjaGVjay4NCj4+IC0gbWVyZ2UgdGhlIHNj cmlwdCBtZXJnZV9jcHBjaGVja19yZXBvcnRzLnB5IGludG8gdGhlIHhlbi1hbmFseXNpcw0KPj4g ICBzY3JpcHQgcGFja2FnZSBhbmQgcmV3b3JrIHRoZSBjb2RlIHRvIGludGVncmF0ZSBpdC4NCj4+ IC0gYWRkIHBsYXRmb3JtIGNvbmZpZ3VyYXRpb24gZmlsZXMgZm9yIGNwcGNoZWNrLi4NCj4+IC0g YWRkIGNwcGNoZWNrLWNjLnNoIHNjcmlwdCB0aGF0IGlzIGEgd3JhcHBlciBmb3IgY3BwY2hlY2sg YW5kIGl0J3MNCj4+ICAgdXNlZCBhcyBYZW4gY29tcGlsZXIsIGl0IHdpbGwgaW50ZXJjZXB0IGFs bCBmbGFncyBnaXZlbiBmcm9tIHRoZQ0KPj4gICBtYWtlIGJ1aWxkIHN5c3RlbSBhbmQgaXQgd2ls bCBleGVjdXRlIGNwcGNoZWNrIG9uIHRoZSBjb21waWxlZA0KPj4gICBmaWxlIHRvZ2V0aGVyIHdp dGggdGhlIGZpbGUgY29tcGlsYXRpb24uDQo+PiAtIGd1YXJkZWQgaHlwZXJjYWxsLWRlZnMuYyB3 aXRoIENQUENIRUNLIGRlZmluZSBiZWNhdXNlIGNwcGNoZWNrDQo+PiAgIGdldHMgY29uZnVzZWQg YXMgdGhlIGZpbGUgZG9lcyBub3QgY29udGFpbiBjIGNvZGUuDQo+PiAtIGFkZCBmYWxzZS1wb3Np dGl2ZS1jcHBjaGVjay5qc29uIGZpbGUNCj4+IC0gdXBkYXRlIGRvY3VtZW50YXRpb24uDQo+PiAt IHVwZGF0ZSAuZ2l0aWdub3JlDQo+PiANCj4+IFNpZ25lZC1vZmYtYnk6IEx1Y2EgRmFuY2VsbHUg PGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCj4gDQo+IEp1c3QgdHdvIGFuZCBhIGhhbGYgcXVlc3Rp b25zLCBub3QgYSBmdWxsIHJldmlldzoNCj4gDQo+PiAtLS0NCj4+IC5naXRpZ25vcmUgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgOCArLQ0KPj4gZG9jcy9taXNyYS9jcHBj aGVjay50eHQgICAgICAgICAgICAgICAgICAgICAgIHwgIDI3ICstDQo+PiBkb2NzL21pc3JhL2Rv Y3VtZW50aW5nLXZpb2xhdGlvbnMucnN0ICAgICAgICAgfCAgIDcgKy0NCj4+IGRvY3MvbWlzcmEv ZmFsc2UtcG9zaXRpdmUtY3BwY2hlY2suanNvbiAgICAgICB8ICAxMiArDQo+PiBkb2NzL21pc3Jh L3hlbi1zdGF0aWMtYW5hbHlzaXMucnN0ICAgICAgICAgICAgfCAgNDIgKystDQo+PiB4ZW4vTWFr ZWZpbGUgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxMTYgKy0tLS0tLS0NCj4+ IHhlbi9pbmNsdWRlL2h5cGVyY2FsbC1kZWZzLmMgICAgICAgICAgICAgICAgICB8ICAgOSArDQo+ PiB4ZW4vc2NyaXB0cy94ZW4tYW5hbHlzaXMucHkgICAgICAgICAgICAgICAgICAgfCAgMTggKy0N Cj4+IHhlbi9zY3JpcHRzL3hlbl9hbmFseXNpcy9jcHBjaGVja19hbmFseXNpcy5weSB8IDI3MiAr KysrKysrKysrKysrKysrKysNCj4+IC4uLi94ZW5fYW5hbHlzaXMvY3BwY2hlY2tfcmVwb3J0X3V0 aWxzLnB5ICAgICB8IDEzMCArKysrKysrKysNCj4+IHhlbi9zY3JpcHRzL3hlbl9hbmFseXNpcy9n ZW5lcmljX2FuYWx5c2lzLnB5ICB8ICAyMSArLQ0KPj4geGVuL3NjcmlwdHMveGVuX2FuYWx5c2lz L3NldHRpbmdzLnB5ICAgICAgICAgIHwgIDc3ICsrKystDQo+PiB4ZW4vc2NyaXB0cy94ZW5fYW5h bHlzaXMvdXRpbHMucHkgICAgICAgICAgICAgfCAgMjEgKy0NCj4+IHhlbi90b29scy9jcHBjaGVj ay1jYy5zaCAgICAgICAgICAgICAgICAgICAgICB8IDIyMyArKysrKysrKysrKysrKw0KPj4geGVu L3Rvb2xzL2NwcGNoZWNrLXBsYXQvYXJtMzItd2NoYXJfdDQueG1sICAgIHwgIDE3ICsrDQo+PiB4 ZW4vdG9vbHMvY3BwY2hlY2stcGxhdC9hcm02NC13Y2hhcl90Mi54bWwgICAgfCAgMTcgKysNCj4+ IHhlbi90b29scy9jcHBjaGVjay1wbGF0L2FybTY0LXdjaGFyX3Q0LnhtbCAgICB8ICAxNyArKw0K Pj4geGVuL3Rvb2xzL2NwcGNoZWNrLXBsYXQveDg2XzY0LXdjaGFyX3QyLnhtbCAgIHwgIDE3ICsr DQo+PiB4ZW4vdG9vbHMvY3BwY2hlY2stcGxhdC94ODZfNjQtd2NoYXJfdDQueG1sICAgfCAgMTcg KysNCj4gDQo+IFdoYXQgYXJlIHRoZXNlIGxhc3QgZml2ZSBmaWxlcyBhYm91dD8gVGhlcmUncyBu b3RoaW5nIGFib3V0IHRoZW0gaW4NCj4gdGhlIGRlc2NyaXB0aW9uIGFmYWljcy4NCg0KVGhleSBh cmUgY3BwY2hlY2sgcGxhdGZvcm0gY29uZmlndXJhdGlvbiBmaWxlcywgdGhleSBoZWxwIGNwcGNo ZWNrIHRvIHVuZGVyc3RhbmQNCnRoZSBzaXplIG9mIHRoZSB0eXBlcyBkZXBlbmRpbmcgb24gdGhl IHRhcmdldCBvZiB0aGUgY29tcGlsYXRpb24uDQoNClRoaXMgc2VjdGlvbiBpbiB0aGUgY29tbWl0 IG1lc3NhZ2UgaXMgdG8gaW50cm9kdWNlIHRoZW06DQoNCldpdGggdGhpcyBwYXRjaCBjcHBjaGVj ayB3aWxsIGJlbmVmaXQgb2YgcGxhdGZvcm0gY29uZmlndXJhdGlvbiBmaWxlcw0KdGhhdCB3aWxs IGhlbHAgaXQgdG8gdW5kZXJzdGFuZCB0aGUgdGFyZ2V0IG9mIHRoZSBjb21waWxhdGlvbiBhbmQN CmltcHJvdmUgdGhlIGFuYWx5c2lzLg0KDQpEbyB5b3UgdGhpbmsgSSBzaG91bGQgc2F5IGl0IGRp ZmZlcmVudGx5PyBPciBtYXliZSBzYXkgdGhhdCB0aGV5IHJlc2lkZSBpbiB4ZW4vdG9vbHMvY3Bw Y2hlY2stcGxhdC8gPw0KDQo+IA0KPj4gLS0tIC9kZXYvbnVsbA0KPj4gKysrIGIveGVuL3Njcmlw dHMveGVuX2FuYWx5c2lzL2NwcGNoZWNrX2FuYWx5c2lzLnB5DQo+PiBAQCAtMCwwICsxLDI3MiBA QA0KPj4gKyMhL3Vzci9iaW4vZW52IHB5dGhvbjMNCj4+ICsNCj4+ICtpbXBvcnQgb3MsIHJlLCBz aHV0aWwNCj4+ICtmcm9tIC4gaW1wb3J0IHNldHRpbmdzLCB1dGlscywgY3BwY2hlY2tfcmVwb3J0 X3V0aWxzDQo+PiArDQo+PiArY2xhc3MgR2V0TWFrZVZhcnNQaGFzZUVycm9yKEV4Y2VwdGlvbik6 DQo+PiArICAgIHBhc3MNCj4+ICsNCj4+ICtjbGFzcyBDcHBjaGVja0RlcHNQaGFzZUVycm9yKEV4 Y2VwdGlvbik6DQo+PiArICAgIHBhc3MNCj4+ICsNCj4+ICtjbGFzcyBDcHBjaGVja1JlcG9ydFBo YXNlRXJyb3IoRXhjZXB0aW9uKToNCj4+ICsgICAgcGFzcw0KPj4gKw0KPj4gK0NQUENIRUNLX0JV SUxEX0RJUiA9ICJidWlsZC1kaXItY3BwY2hlY2siDQo+PiArQ1BQQ0hFQ0tfSFRNTFJFUE9SVF9P VVRESVIgPSAiY3BwY2hlY2staHRtbHJlcG9ydCINCj4+ICtDUFBDSEVDS19SRVBPUlRfT1VURElS ID0gImNwcGNoZWNrLXJlcG9ydCINCj4+ICtjcHBjaGVja19leHRyYV9tYWtlX2FyZ3MgPSAiIg0K Pj4gK3hlbl9jYyA9ICIiDQo+PiArDQo+PiArZGVmIGdldF9tYWtlX3ZhcnMoKToNCj4+ICsgICAg Z2xvYmFsIHhlbl9jYw0KPj4gKyAgICBpbnZva2VfbWFrZSA9IHV0aWxzLmludm9rZV9jb21tYW5k KA0KPj4gKyAgICAgICAgICAgICJtYWtlIC1DIHt9IHt9IGV4cG9ydC12YXJpYWJsZS1DQyINCj4+ ICsgICAgICAgICAgICAgICAgLmZvcm1hdChzZXR0aW5ncy54ZW5fZGlyLCBzZXR0aW5ncy5tYWtl X2ZvcndhcmRfYXJncyksDQo+PiArICAgICAgICAgICAgVHJ1ZSwgR2V0TWFrZVZhcnNQaGFzZUVy cm9yLA0KPj4gKyAgICAgICAgICAgICJFcnJvciBvY2N1cmVkIHJldHJpZXZpbmcgbWFrZSB2YXJz Olxue30iDQo+PiArICAgICAgICApDQo+PiArDQo+PiArICAgIGNjX3Zhcl9yZWdleCA9IHJlLnNl YXJjaCgnXkNDPSguKikkJywgaW52b2tlX21ha2UsIGZsYWdzPXJlLk0pDQo+PiArICAgIGlmIGNj X3Zhcl9yZWdleDoNCj4+ICsgICAgICAgIHhlbl9jYyA9IGNjX3Zhcl9yZWdleC5ncm91cCgxKQ0K Pj4gKw0KPj4gKyAgICBpZiB4ZW5fY2MgPT0gIiI6DQo+PiArICAgICAgICByYWlzZSBHZXRNYWtl VmFyc1BoYXNlRXJyb3IoIkNDIHZhcmlhYmxlIG5vdCBmb3VuZCBpbiBYZW4gbWFrZSBvdXRwdXQi KQ0KPiANCj4gV2hhdCB1c2UgaXMgQ0Mgd2l0aG91dCBDRkxBR1M/IE9uY2UgYWdhaW4gdGhlIGRl c2NyaXB0aW9uIGNvdWxkIGRvDQo+IHdpdGggY29udGFpbmluZyBzb21lIGluZm9ybWF0aW9uIG9u IHdoYXQncyBnb2luZyBvbiBoZXJlLCBhbmQgd2h5DQo+IHlvdSBuZWVkIHRvIGV4cG9ydCBhbnkg dmFyaWFibGVzIGluIHRoZSBmaXJzdCBwbGFjZS4NCg0KV2UgZG9u4oCZdCBuZWVkIENGTEFHUyBo ZXJlLCB3ZSBuZWVkIG9ubHkgQ0MgdG8gZ2VuZXJhdGUgaW5jbHVkZS9nZW5lcmF0ZWQvY29tcGls ZXItZGVmLmggYW5kDQp0byBwYXNzIENDIHRvIHRoZSBjcHBjaGVjay1jYy5zaCAtLWNvbXBpbGVy IGFyZ3VtZW50Lg0KDQpXb3VsZCBhIGNvbW1lbnQgaW4gdGhlIGNvZGUgYmUgb2s/DQoNCg0KPiAN Cj4+ICtpZiBbIC1uICIke0NDX0ZJTEV9IiBdOw0KPj4gK3RoZW4NCj4+ICsgICAgZm9yIHBhdGgg aW4gJHtJR05PUkVfUEFUSF9MSVNUfQ0KPj4gKyAgICBkbw0KPj4gKyAgICAgICAgaWYgW1sgJHtD Q19GSUxFfSA9PSAqJHtwYXRofSogXV0NCj4+ICsgICAgICAgIHRoZW4NCj4+ICsgICAgICAgICAg ICBJR05PUkVfUEFUSD0ieSINCj4+ICsgICAgICAgICAgICBlY2hvICIkezB9OiAke0NDX0ZJTEV9 IGlnbm9yZWQgYnkgLS1pZ25vcmUtcGF0aCBtYXRjaGluZyAqJHtwYXRofSoiDQo+PiArICAgICAg ICBmaQ0KPj4gKyAgICBkb25lDQo+PiArICAgIGlmIFsgIiR7SUdOT1JFX1BBVEh9IiA9ICJuIiBd DQo+PiArICAgIHRoZW4NCj4+ICsgICAgICAgIEpEQl9GSUxFPSIke09CSlRSRUVfUEFUSH0vJChi YXNlbmFtZSAiJHtDQ19GSUxFfSIuanNvbikiDQo+PiArDQo+PiArICAgICAgICAjIFByZXBhcmUg dGhlIEpzb24gQ29tcGlsYXRpb24gRGF0YWJhc2UgZm9yIHRoZSBmaWxlDQo+PiArICAgICAgICBj cmVhdGVfamNkICIke0NPTVBJTEVSfSAke0ZPUldBUkRfRkxBR1N9Ig0KPj4gKw0KPj4gKyAgICAg ICAgb3V0X2ZpbGU9IiR7T0JKVFJFRV9QQVRIfS8kKGJhc2VuYW1lICIke0NDX0ZJTEUlLmN9Ii5j cHBjaGVjay50eHQpIg0KPj4gKw0KPj4gKyAgICAgICAgIyBDaGVjayB3Y2hhciBzaXplDQo+PiAr ICAgICAgICB3Y2hhcl9wbGF0X3N1ZmZpeD0idDQiDQo+PiArICAgICAgICAjIHNlZCBwcmludHMg dGhlIGxhc3Qgb2NjdXJlbmNlIG9mIC1mKG5vLSlzaG9ydC13Y2hhciB3aGljaCBpcyB0aGUgb25l DQo+PiArICAgICAgICAjIGFwcGxpZWQgdG8gdGhlIGZpbGUgYnkgdGhlIGNvbXBpbGVyDQo+PiAr ICAgICAgICB3Y2hhcl9vcHRpb249JChlY2hvICIke0ZPUldBUkRfRkxBR1N9IiB8IFwNCj4+ICsg ICAgICAgICAgICBzZWQgLW5yZSAncywuKigtZihuby0pP3Nob3J0LXdjaGFyKS4qLFwxLHAnKQ0K Pj4gKyAgICAgICAgaWYgWyAiJHt3Y2hhcl9vcHRpb259IiA9ICItZnNob3J0LXdjaGFyIiBdDQo+ PiArICAgICAgICB0aGVuDQo+PiArICAgICAgICAgICAgd2NoYXJfcGxhdF9zdWZmaXg9InQyIg0K Pj4gKyAgICAgICAgZmkNCj4+ICsNCj4+ICsgICAgICAgICMgU2VsZWN0IHRoZSByaWdodCB0YXJn ZXQgcGxhdGZvcm0sIEFSQ0ggaXMgZ2VuZXJhdGVkIGZyb20gWGVuIE1ha2VmaWxlDQo+PiArICAg ICAgICBwbGF0Zm9ybT0iJHtDUFBDSEVDS19QTEFUX1BBVEh9LyR7QVJDSH0td2NoYXJfJHt3Y2hh cl9wbGF0X3N1ZmZpeH0ueG1sIg0KPiANCj4gUHVyZWx5IGNvc21ldGljLCBidXQgc3RpbGw6IFdo eSBpcyAidCIgcGFydCBvZiB0aGUgc3VmZml4IHJhdGhlciB0aGFuDQo+IGJlaW5nIHBhcnQgb2Yg dGhlIGV4cHJlc3Npb24gaGVyZSAoYWxsb3dpbmcgZS5nLiBhIGdyZXAgZm9yICJ3Y2hhcl90Ig0K PiB0byBoaXQgaGVyZSk/DQoNCk5vIHJlYXNvbiwgSSBkb27igJl0IGhhdmUgYSBzdHJvbmcgb2Jq ZWN0aW9uIHRvIGNoYW5nZSBpdA0KDQo+IA0KPiBKYW4NCg0K From xen-devel-bounces@lists.xenproject.org Mon Nov 28 15:57:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 15:57:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449011.705608 (Exim 4.92) (envelope-from ) id 1ozgVW-0004Gz-VK; Mon, 28 Nov 2022 15:57:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449011.705608; Mon, 28 Nov 2022 15:57:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgVW-0004Go-RQ; Mon, 28 Nov 2022 15:57:22 +0000 Received: by outflank-mailman (input) for mailman id 449011; Mon, 28 Nov 2022 15:57:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgVU-0004G7-PP for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:57:20 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20628.outbound.protection.outlook.com [2a01:111:f400:7e8a::628]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5548100e-6f35-11ed-8fd2-01056ac49cbb; Mon, 28 Nov 2022 16:57:18 +0100 (CET) Received: from BN9PR03CA0193.namprd03.prod.outlook.com (2603:10b6:408:f9::18) by DM4PR12MB6279.namprd12.prod.outlook.com (2603:10b6:8:a3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 15:57:14 +0000 Received: from BN8NAM11FT048.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f9:cafe::64) by BN9PR03CA0193.outlook.office365.com (2603:10b6:408:f9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Mon, 28 Nov 2022 15:57:13 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT048.mail.protection.outlook.com (10.13.177.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Mon, 28 Nov 2022 15:57:13 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 09:57:13 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 07:57:12 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 28 Nov 2022 09:57:11 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5548100e-6f35-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M6dVD3rMT0wqr3FDqJnw0VknGPV7rGjDHpAGHQBwQDHRvna5mzfZMWrs22Wtsestr+QqlwnzRlcG0wgpamYK+rgQR+mjkirlHzlot1oJ+T755QBFEgxYVUmjrZrPepF3+UAqteKvF31RlsxeyifwVQaKDh4CWLHrm3lKuhb1/pUPyFQIyFJ4MkqSV6eBy2HVgl4kFmDLxUHixBaqY93srH4tklQ/VMEbu2HHArhD6KT45Z1OdGELkWsP52gnzFOm91eMncL+KJYk0va/l/PzybgJjVZ0t4Dqjw+I6OinF8nsD2aT6qEEls97iDeySNApiz0fwohzL4I/l0mZyx3ycw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m0n8FAPk7U+uUmU83VhWA4RfQh2mMZ9KZJGNylb/20U=; b=MVtgSFk+HMDwepQIivWUgxmAfxiYRsd9X0G6fpffvGA2fQXx70D+Zh+v+LlX6FPtoyaus0HvLgzOWdQ7q08s10SUiYd4aGy9nTkfa4e8rTIdq0+1etygcQDepPsIMAoLagycGjCUBwTEGNOGoF7YcSkSL69xW6Oh/0t8sSqAWnVECUN3PTBIPoEwcF3mJHjvhG4uj7eJFNLBRrYWVaUSg+5Bs7f50fxvRpXK5SFSKo0R6cKCpAfNif7uYTkBoExhLDhQisryWI0HQE/QJBVO/PxPUM0stwLQ1GGbVeq1uvmx1N3+LgZ4i3Bs8qDAgB10VDe4/8OpVcKHs3K9bxmZlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m0n8FAPk7U+uUmU83VhWA4RfQh2mMZ9KZJGNylb/20U=; b=yDshSf8Rt/4JIdJACNi3fci59D/GGoQ04lua2abcfMicleMNw2leerNFTbORlOLBNNFWZ+WRa9K0qp3ScxlJ3beJhxTlWfQCqkheSd2b8xNZNNHIsTtyCbBWy1OMMmNrFSv3c5dvwSowiMmSBd+o2Z4GCeyFAbLFzi57E8KWdu0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v4 01/11] xen/Arm: vGICv3: Sysreg emulation is applicable for AArch64 only Date: Mon, 28 Nov 2022 15:56:39 +0000 Message-ID: <20221128155649.31386-2-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128155649.31386-1-ayan.kumar.halder@amd.com> References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT048:EE_|DM4PR12MB6279:EE_ X-MS-Office365-Filtering-Correlation-Id: 48f81350-57a3-4e6c-998b-08dad1593741 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dsrFKWx5trY2zxNee7M8ArcQpyfamXnbfuyDNxa3enRHacXZIaHCZsAjNBTsVZnObJh1+KMApElxPLXoPJS72hCINu2B9crDoyE10zsAScTXbtu3OLBHhUwJv1jEDOwApXY6xTqZWXPaXbUMJhwlgPEwrIL1nIlKuiVYU+kSPcki7bPHflUb5/tXWmZj26DGqvDfG0+JsUDk04JlVQxFNCOEMCyNLyoKbry/u52H82r9w+NewgM/qilcC2ImXgpwTXUKPGfil35QKzLLxH51bogGJNhNUa0Q8sR5SxRKgzfinu+LDYEO0rIgM86HTyo42LcsX6FDC3AFV/HCL1DFchjFDgiFQdACLa2AlGW3yUjOd96Op3swEJdmdhJPQGcjfGLXqMw+LLkzepFKtQYxHmtPR9aq1wmv695ExSLJesBYdjke/Rb4eYc4Dq4r/K/fUrFCrBDMbel+QR4XTDjWmSmoUNS1T3TxLC+nu5AV0Q1Jg4ymAphI1Jf+K2dEHq9g3ZWoC1k+7VqJE+sfCPnJL7XvNEhDez67bKsR7S8iY83VKTFSm9wWlYry9AahqSnkHOP80qsMzwMNPwXjAAAYl+SEfqYkX2mMYhzZriM0GrX5JuVAvcSg+JYwJ6BM4wH6a6+sra93ICQqCUI0BaD6P/B9FL2k6SZnt94qH+YF2lNO1F8Vas/61j30BzKkiE4h1EI2tpBeP9I1YOgwgFnyMIVhjv+w0YOjyKHGdi7W6ws= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(396003)(451199015)(36840700001)(46966006)(40470700004)(426003)(47076005)(5660300002)(40480700001)(103116003)(54906003)(6916009)(26005)(82740400003)(316002)(2616005)(8936002)(336012)(40460700003)(41300700001)(1076003)(186003)(70586007)(36756003)(70206006)(4326008)(8676002)(82310400005)(81166007)(356005)(2906002)(36860700001)(86362001)(478600001)(83380400001)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 15:57:13.5218 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48f81350-57a3-4e6c-998b-08dad1593741 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT048.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6279 Sysreg emulation is 64-bit specific, so guard the calls to vgic_v3_emulate_sysreg() as well as the function itself with "#ifdef CONFIG_ARM_64". Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel Acked-by: Julien Grall --- Changes from - v1 - 1. Updated the commit message. v2 - 1. Updated the commit message (removed the reference to Arm ARM as it is not required). v3 - No changes. Added Rb and Ack. xen/arch/arm/vgic-v3.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index 015446be17..3f4509dcd3 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -1519,6 +1519,7 @@ static bool vgic_v3_emulate_sgi1r(struct cpu_user_regs *regs, uint64_t *r, } } +#ifdef CONFIG_ARM_64 static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr) { struct hsr_sysreg sysreg = hsr.sysreg; @@ -1539,6 +1540,7 @@ static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr) return false; } } +#endif static bool vgic_v3_emulate_cp64(struct cpu_user_regs *regs, union hsr hsr) { @@ -1562,8 +1564,10 @@ static bool vgic_v3_emulate_reg(struct cpu_user_regs *regs, union hsr hsr) { switch (hsr.ec) { +#ifdef CONFIG_ARM_64 case HSR_EC_SYSREG: return vgic_v3_emulate_sysreg(regs, hsr); +#endif case HSR_EC_CP15_64: return vgic_v3_emulate_cp64(regs, hsr); default: -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 15:57:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 15:57:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449010.705596 (Exim 4.92) (envelope-from ) id 1ozgVQ-00040j-MT; Mon, 28 Nov 2022 15:57:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449010.705596; Mon, 28 Nov 2022 15:57:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgVQ-00040c-Js; Mon, 28 Nov 2022 15:57:16 +0000 Received: by outflank-mailman (input) for mailman id 449010; Mon, 28 Nov 2022 15:57:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgVP-00040T-2z for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:57:15 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04hn20326.outbound.protection.outlook.com [2a01:111:f400:7e8c::326]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5238d421-6f35-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 16:57:13 +0100 (CET) Received: from BN9PR03CA0206.namprd03.prod.outlook.com (2603:10b6:408:f9::31) by SJ1PR12MB6124.namprd12.prod.outlook.com (2603:10b6:a03:459::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 15:57:09 +0000 Received: from BN8NAM11FT048.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f9:cafe::b8) by BN9PR03CA0206.outlook.office365.com (2603:10b6:408:f9::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.22 via Frontend Transport; Mon, 28 Nov 2022 15:57:09 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT048.mail.protection.outlook.com (10.13.177.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Mon, 28 Nov 2022 15:57:08 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 09:57:06 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 09:56:57 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 28 Nov 2022 09:56:56 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5238d421-6f35-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XNJq9DZYXkxNpVtvq/RJklP2NWsn0G7DkBU7IALUgkh58om8467skzVuIISwnG16ghlURBr8pYFVayPBpgaCmzGAMVXA3MPCl+Qy+Artu39csLi6oyP+mKQQPDIQzFaD2v/tm6Rs+h81WD1mLloOe/uUYNWnwkZ3Jwxe8219XUMhVa31FoqA/o7J8YUo2CHn+ItUgE/TitMAJSW+wzNsZieVMWa8qtVfs0gj2+nK5yzD9Z+b8KM4myr0P6SDpKOL94AM6l4IiC3s4iMfikc3ANiv/2Bb7Rljq9/c6vO38S40hHka5H5nFl6AnYr3sGwTo7+5fFHrsbBsCQRERoTz/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k3Kpz+bqPr4H3fE7oYGCI2F/ShLsT3xtGUUc8+3JBkA=; b=HWPn4QMjCZCM0/RLHHuD/I842X7rN/IX8UUt6lBl82Mnxs6iwLxUzwZrLj1ZoVe5B7FUktmfEFDe0tW5d1iuLmZogRWqOv7gJdTSd9YY2LpbAN8kTiDaEmzm7khmhUWYgXzOrXzWtzrdyPz4uC3RTf1XYcltnQX/DccsGShopIQ8/VC3yJULZJpO3bYxqIGq8ncoxcmL46sOxT6jIgVkFYbExcJPuCXVz3GRmvA5CW953N/Fmw21j4f9PdYR6i/U6onuWRwVzujitnIxKJhSQcKsamtC+dwaohOUuOlWOHffkn64Did0YPk9Sn/kIxLenyF5yH4dfrvBuNwWgBNt4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k3Kpz+bqPr4H3fE7oYGCI2F/ShLsT3xtGUUc8+3JBkA=; b=JrRSKKRTWwYQDub98i08Yn6lWnhMj60XTDLyuDnDd9DkgqkfFhPoRZyqyAs9FHsNY5QkjPlQVDbPtiR6QRD+WZvJaHb6eHzCd3af487hBHFjMfoaBeopDYCSGsNQxniJLfxT9G0jNO0n/X90LyTw5w1sdm728Beec8bmF9OKGoY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v4 00/11] Arm: Enable GICv3 for AArch32 Date: Mon, 28 Nov 2022 15:56:38 +0000 Message-ID: <20221128155649.31386-1-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT048:EE_|SJ1PR12MB6124:EE_ X-MS-Office365-Filtering-Correlation-Id: 38f9ba67-b6e6-44b2-069f-08dad159342a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?GDZsvz841AoWKcsAOdY6e7f4r3iicL6u7/ZyxyCa6nbkmCusN0/WR2idGaSY?= =?us-ascii?Q?F/P0fDcZzyysQ/lUhqrxRNWa9eqejycw94R3qmAjqKe9D/sKYtE+NS6L1BT7?= =?us-ascii?Q?lJZEero7jgt2il+gxwCcM8zn0id7kxtZDo353hfyo7PErtXlEjK1fNrmoZ/q?= =?us-ascii?Q?lFKZt75x1IImRw1eITvAxP+GAJc8jSND9BWZOma5z/gQH2WH2ThRSEb0UaWQ?= =?us-ascii?Q?rFKg5E1cmVqSf9DEZTrHKLIrVZCfmgElC36seMaeAprR73Gz4rfw7lizEakK?= =?us-ascii?Q?YNYkv0cEO0iZAMNb6Un7WmcVYI/aWpfW6IO696h+CpGj1Wc+I+lYb8WeZ3RH?= =?us-ascii?Q?3E32TbrhbtzysJEDmFnpsyK51KBXaIsUL+w2tXz5J9uzrtFO08G1LGKG8R83?= =?us-ascii?Q?/VtdiHG0HxCMEvufK9jFPSAyrsP0ts71b04QYBStFL1DbeYjkH1T/PHB4ncz?= =?us-ascii?Q?dWvmb9iv57SpX2EUjehleSQ/ulTi9gPdV9fQkAWyQ5LTYJPpMNPGuDu+6adH?= =?us-ascii?Q?q01uP2KrAQeKlxmuI2DAtYRg1DFlhWnYafein5ZicBq52E5AC08dMxA18BBu?= =?us-ascii?Q?6UmbISxFjXBnIIrBGA8M+M9UjII0CB3kwjUetyu9BLqHWqhiMNEoYryyvwyo?= =?us-ascii?Q?lqU7+83YlbXqsLG4QD3PaF22574z9nXB3iNbFv2A6Hs79+ospld9iWJqfQTS?= =?us-ascii?Q?HhLZ2ydqKHr+vrbGz0Qjc35YVrUJLgWlKv/ncpqBCKkqn7FeUtAgcIWCAEK3?= =?us-ascii?Q?3jvdsEzz1KGJxMCKHVFJWQWAruHrDDNBeeXjO7gKyCLgtZZd+z//BP1xxYMT?= =?us-ascii?Q?hCR8t2mBfpv2q4bhEWWWvxaEMJE0jeUu1Qgds6VE33giBRzTWpSW/9kgX3Hs?= =?us-ascii?Q?9taseeEjyiME9g+/JEX1O95njIr3hmNrW3QetcbaCh4ud2v8ZDWE541LIOzF?= =?us-ascii?Q?Xh7qkSvX3ZvS7otT/01RJ2kfi9P+erfIpcqffN+bm2hSfQLojLxZydcjH3qK?= =?us-ascii?Q?wJOCILDS7NE04JbeZNCR6MGVuv1nbsuEo1gilk81Kp7lfjHAiD1d8uDfv/rb?= =?us-ascii?Q?xVwHLS385cctH1nj05MghMM6P3ihm5IoER2K1C2TLFrXPsypdmYzv5gHxqgs?= =?us-ascii?Q?0OJ+FAVxD07S2ZAqC72wChv+La3vDuOvUb6yqBzir7CLDlXHdJ2haps=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:5;SRV:;IPV:CAL;SFV:SPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:OSPM;SFS:(13230022)(4636009)(376002)(346002)(136003)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(83380400001)(82310400005)(2906002)(336012)(478600001)(5660300002)(8936002)(47076005)(426003)(186003)(1076003)(6916009)(81166007)(6666004)(86362001)(2616005)(41300700001)(356005)(70206006)(70586007)(103116003)(36756003)(40480700001)(82740400003)(26005)(54906003)(316002)(8676002)(4326008)(40460700003)(36860700001)(36900700001)(11215385002);DIR:OUT;SFP:1501; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 15:57:08.3341 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 38f9ba67-b6e6-44b2-069f-08dad159342a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT048.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6124 Hi All, Please find the following patches to enable GICv3 for AArch32. This is a pre-requisite to support Xen on Cortex-R52 (AArch32-v8R system) Let me know your thoughts. Changes from - v1 :- 1. Updated in the changelog for each of the patches. v2 :- 1. Dropped "xen/Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32". The reason being aff3 does not exist on arm32. And aff0..2 is the same between arm32, AArch32 and AArch64. 2. Introduce a new patch "xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32". 3. For the new registers introduced, we have defined the arm32 name and then an alias. 4. Use 'AArch32' across all the patches. 5. Dropped the 'R-b' and 'Ack' in "[XEN v3 08/12] xen/Arm: GICv3: Define ICH_AP0R and ICH_AP1R for AArch32". v3 :- 1. "xen/Arm: GICv3: Use ULL instead of UL for 64bits" has been dropped. The change has been merged with "xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32". 2. I have marked the patches which have been Rb + Ack vs Rb only. 3. Dropped Rb from "xen/Arm: GICv3: Enable GICv3 for AArch32" Ayan Kumar Halder (11): xen/Arm: vGICv3: Sysreg emulation is applicable for AArch64 only (Rb + Ack) xen/Arm: GICv3: Do not calculate affinity level 3 for AArch32 (Rb) xen/Arm: vreg: Support vreg_reg64_* helpers on AArch32 (Rb + Ack) xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32 (Rb) xen/Arm: GICv3: Fix GICR_{PENDBASER, PROPBASER} emulation on 32-bit host (Rb + Ack) xen/Arm: vGICv3: Fix emulation of ICC_SGI1R on AArch32 (Rb + Ack) xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32 xen/Arm: GICv3: Define ICH_AP0R and ICH_AP1R for AArch32 xen/Arm: GICv3: Define remaining GIC registers for AArch32 xen/Arm: GICv3: Define macros to read/write 64 bit xen/Arm: GICv3: Enable GICv3 for AArch32 SUPPORT.md | 7 ++ xen/arch/arm/Kconfig | 9 +- xen/arch/arm/gic-v3.c | 153 ++++++++++++----------- xen/arch/arm/include/asm/arm32/io.h | 20 +++ xen/arch/arm/include/asm/arm32/sysregs.h | 19 +++ xen/arch/arm/include/asm/arm64/io.h | 2 + xen/arch/arm/include/asm/arm64/sysregs.h | 5 + xen/arch/arm/include/asm/cpregs.h | 136 ++++++++++++++++++++ xen/arch/arm/include/asm/cpufeature.h | 1 + xen/arch/arm/include/asm/gic_v3_defs.h | 24 ++-- xen/arch/arm/include/asm/vreg.h | 86 +++---------- xen/arch/arm/vgic-v3.c | 22 +++- 12 files changed, 324 insertions(+), 160 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 15:57:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 15:57:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449012.705619 (Exim 4.92) (envelope-from ) id 1ozgVY-0004XW-6B; Mon, 28 Nov 2022 15:57:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449012.705619; Mon, 28 Nov 2022 15:57:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgVY-0004XH-33; Mon, 28 Nov 2022 15:57:24 +0000 Received: by outflank-mailman (input) for mailman id 449012; Mon, 28 Nov 2022 15:57:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgVX-0004G7-5j for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:57:23 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20600.outbound.protection.outlook.com [2a01:111:f400:7eae::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 576c74cc-6f35-11ed-8fd2-01056ac49cbb; Mon, 28 Nov 2022 16:57:22 +0100 (CET) Received: from BN1PR12CA0005.namprd12.prod.outlook.com (2603:10b6:408:e1::10) by DM4PR12MB6565.namprd12.prod.outlook.com (2603:10b6:8:8c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 15:57:19 +0000 Received: from BN8NAM11FT052.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e1:cafe::ad) by BN1PR12CA0005.outlook.office365.com (2603:10b6:408:e1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Mon, 28 Nov 2022 15:57:18 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT052.mail.protection.outlook.com (10.13.177.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.21 via Frontend Transport; Mon, 28 Nov 2022 15:57:18 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 09:57:17 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 07:57:17 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 28 Nov 2022 09:57:15 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 576c74cc-6f35-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cYTqpSPvNl5BmK3oF1P+lwPdmU7fA5G8YpYF8CXER7t+c+3KaIziLMOl3xfUCY5WcZ01ul12ht8xhSK78B+0E31tRq97xPsCs2lBzgkTp/6CXam8lfKyl/Upik0FlCTF2M6cx3leNncuD+X+0OaZM/uEAaxfu27P6jlvcWvP/b9IrUK6tzTMj8ddTKHJF88x26+YxwyTsARRN2ei/l4uzzcbpedNnsLM+VxhP20Z+5Qb1NwG9ff9e/+7/xUgF1xnp9MkGDIoD5N0rYX7CRYsqnkNS9ydcjoRvhUtd/m1BMDolY6slwTTxts+KiFW28SeZZHSanke3D2a4A9JxEtknA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BFXp0sPs0JxcYqGLbqqhGHuasdeiZ8ZsSBnPbFyCZpE=; b=lQy6RkmtNH0J2FvFo3V8Iit0jFwKI988t8OXKs0mhay2erPJ21NLAvWr/euyK/HO1LReaxluNEBWbO03LWxREaCGYE1ck5gUgaggoGMy+7lTma07/n7Uot9LyjceA8K0bJbBIg9g2cQiOEbrYyXJFaOkO10WTjDEkCACbemBXin2Xi1kEm0ouL4PQSAIKMTgx+QSYr2tFEJdPYk5HupE4+Z44mP/KHJ85rCC0gQ1xa8I91F+FJN9HUpTDGGJ3SZhDuLL+UGReByfxGpswJqqIxPfaQIiG1Bf3CazUbg9SGvdUdNRDYchy0uPZ65QaN7i4uGoQuRGk7Akcqi/QUQlmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BFXp0sPs0JxcYqGLbqqhGHuasdeiZ8ZsSBnPbFyCZpE=; b=swkdUCW2Ze6G3VkbI5ez1ech2T3QHli5PGX36sxJE7mVl/2fdGHy0T75/bEplBCwRAhtL4XtGuwCEC8yVZgjnAEEjCIKubsCSG3OvWLUwya3kUQSWEaRqI5iK+AQiXKfnWGGH705igrXV3GXNcK9t4pgLKPJ16AdqtaHnFyTh04= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v4 02/11] xen/Arm: GICv3: Do not calculate affinity level 3 for AArch32 Date: Mon, 28 Nov 2022 15:56:40 +0000 Message-ID: <20221128155649.31386-3-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128155649.31386-1-ayan.kumar.halder@amd.com> References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT052:EE_|DM4PR12MB6565:EE_ X-MS-Office365-Filtering-Correlation-Id: 99eb87ab-513e-416c-6058-08dad1593a04 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nv45T+TL7UM60CxgCltUE+Vr17EVjxkwEpe8EPSvbBK3kEggQzUZ0USDTeDd+zOdGt8aRqJbhxQtUVQzMfQuUITKlGKlpizDP69tWndz7tD6Bs+1PR96aarp+FcE8lwPUts7n0ht7CP+tPrq16/syYA4RjjVqqGWNexyPAF76vrxnxtYwfTW1J8GFrNSchEMxyNizPN7olKyUBQSjUUf0HnF5Op11n2a3PIq8gwlub4Oyun24AzsFmfHDLp6moXvD5hvbPWmLOmm1gulUQN+uYI3UAN82Cdc91F5E5w4TuvUIYBpdlnFsSXbZZD7o9fLVV9ofFabsiHx2oP0Sqit1+oJOHfV49XGudgpe+cxwwrZXJ/dj7S6VKTNACfPKRg39QotKX1f038LUNtYuSU2hSEom95e/6fFWI4AhA+9sBq77MDdFX3rVS3D9mFTfnKeGgiMHs1qeNCt4rv75wNDL9TJRxCgIWBZAXKqWCYh1ZgpSIwa6n85Ju1I0Ivk3q1uC9tTxXOweIA9FU9dAq5jlyJPSg7iRu1SpsDr17tV9JpY7owBxbftDZf6+bAlWyi11rcZa1G48pbZ0sgfJjMiMkpspFUcoqLULAzawuydOCp9s/9GQb0BtBFhjL0GJ0F8ncL5F5vUnRLUrZfwC74CbrpsnAeUa8WhB3DFXBJIChdcDEHiCxFQu/yMMZNLvAD6Ge542GZdIvPiueFACmvG+U4UOUkkVaTSj4QU4IN7cls= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(346002)(136003)(451199015)(36840700001)(46966006)(40470700004)(83380400001)(478600001)(86362001)(36860700001)(6666004)(316002)(26005)(103116003)(54906003)(8936002)(6916009)(40460700003)(336012)(41300700001)(2616005)(426003)(47076005)(5660300002)(40480700001)(356005)(81166007)(2906002)(82740400003)(8676002)(4326008)(36756003)(70586007)(1076003)(186003)(70206006)(82310400005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 15:57:18.1537 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99eb87ab-513e-416c-6058-08dad1593a04 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT052.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6565 Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169 Affinity level 3 is not present in AArch32. Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106, Affinity level 3 is not present in Armv7 (ie arm32). Thus, any access to affinity level 3 needs to be guarded within "ifdef CONFIG_ARM_64". Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel --- Changes from - v1 - NA (as it is a new patch) v2 - NA (as it is a new patch) v3 - Modified the title. Added Rb. xen/arch/arm/gic-v3.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 018fa0dfa0..64a76307dd 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -527,7 +527,10 @@ static void gicv3_set_pending_state(struct irq_desc *irqd, bool pending) static inline uint64_t gicv3_mpidr_to_affinity(int cpu) { uint64_t mpidr = cpu_logical_map(cpu); - return (MPIDR_AFFINITY_LEVEL(mpidr, 3) << 32 | + return ( +#ifdef CONFIG_ARM_64 + MPIDR_AFFINITY_LEVEL(mpidr, 3) << 32 | +#endif MPIDR_AFFINITY_LEVEL(mpidr, 2) << 16 | MPIDR_AFFINITY_LEVEL(mpidr, 1) << 8 | MPIDR_AFFINITY_LEVEL(mpidr, 0)); @@ -720,7 +723,10 @@ static int __init gicv3_populate_rdist(void) * Convert affinity to a 32bit value that can be matched to GICR_TYPER * bits [63:32] */ - aff = (MPIDR_AFFINITY_LEVEL(mpidr, 3) << 24 | + aff = ( +#ifdef CONFIG_ARM_64 + MPIDR_AFFINITY_LEVEL(mpidr, 3) << 24 | +#endif MPIDR_AFFINITY_LEVEL(mpidr, 2) << 16 | MPIDR_AFFINITY_LEVEL(mpidr, 1) << 8 | MPIDR_AFFINITY_LEVEL(mpidr, 0)); @@ -972,7 +978,10 @@ static void gicv3_send_sgi_list(enum gic_sgi sgi, const cpumask_t *cpumask) * Prepare affinity path of the cluster for which SGI is generated * along with SGI number */ - val = (MPIDR_AFFINITY_LEVEL(cluster_id, 3) << 48 | + val = ( +#ifdef CONFIG_ARM_64 + MPIDR_AFFINITY_LEVEL(cluster_id, 3) << 48 | +#endif MPIDR_AFFINITY_LEVEL(cluster_id, 2) << 32 | sgi << 24 | MPIDR_AFFINITY_LEVEL(cluster_id, 1) << 16 | -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 15:57:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 15:57:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449013.705630 (Exim 4.92) (envelope-from ) id 1ozgVe-0004tQ-JQ; Mon, 28 Nov 2022 15:57:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449013.705630; Mon, 28 Nov 2022 15:57:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgVe-0004tJ-GZ; Mon, 28 Nov 2022 15:57:30 +0000 Received: by outflank-mailman (input) for mailman id 449013; Mon, 28 Nov 2022 15:57:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgVc-00040T-KA for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:57:28 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2060d.outbound.protection.outlook.com [2a01:111:f400:7e89::60d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5a816de2-6f35-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 16:57:27 +0100 (CET) Received: from DM6PR06CA0090.namprd06.prod.outlook.com (2603:10b6:5:336::23) by SJ1PR12MB6193.namprd12.prod.outlook.com (2603:10b6:a03:459::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.22; Mon, 28 Nov 2022 15:57:23 +0000 Received: from DM6NAM11FT105.eop-nam11.prod.protection.outlook.com (2603:10b6:5:336:cafe::4d) by DM6PR06CA0090.outlook.office365.com (2603:10b6:5:336::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Mon, 28 Nov 2022 15:57:22 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT105.mail.protection.outlook.com (10.13.173.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.18 via Frontend Transport; Mon, 28 Nov 2022 15:57:21 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 09:57:21 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 07:57:20 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 28 Nov 2022 09:57:19 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a816de2-6f35-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QV9RBHR5CCEwDJ5Ez3NA6enHDWUZEuhv56RtzPzGpYjVHPXmr09igoNL4SMmgF2lSAQaYpFW8RNJ7Rlt8z0JV6pErbWqZOcjAsoCoFNF6QzH88R3NWqW/ZzMk6xX5Tp0rop1mzH0CIz2tE59zVclhdn33nVu7oDM2qSzQLddlUuVeifns9ucQgs7A3V4kB+X9gZDaiqdXFDi7WYRFxm7D/CmMqVQZckjaE0G5+67BU6xC1+YJRGXukYgOjQMMJ72Z8Gxqs9kP9vIEziE4dogNSdWC97TJjsJm5YXzhQYfJCZLXde4VmPKx14Xzovwdm5ZY/L5Lknys8fCHz8VvCqcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wo2+sVo6LtAt5RMJpKRO/GdQYNQZj2Z4JvovHOpUzxI=; b=aYvc1Snsv/vCgvpMPP+OYWdEcjdvE85gSo6bIpvpgml4Z/CpiIwMh+/0mUfupETuxmhWBKW6PXuWajcQOFA8a3Ol0Sd7CUSaTW1KgUI1gGmlDkuVwWVxoQ3MMF4705skm2Bvs/Fh7OCNDUV+yonYB8xJTZ+zXtqHpA/Nb98PN6/S+nJbq+mpmrUKbULvrZEjaDhztkIDs7rW/KoDxL/bZ1cNmjDXWJo/K0W9+V1eeg/MmNSBPlrj2zvsVetAhpQNuTFJhdreUvQRrCXPuNceRLC277ETQh24N0pfHD0wN1nxc6pPw/QqgaI3NHfTRCF/6+aRrXKTikk9CEiU8CmS7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wo2+sVo6LtAt5RMJpKRO/GdQYNQZj2Z4JvovHOpUzxI=; b=p448bisrsPbOSTEnV1H8Ws314UgIryCzGL6Fqu6/ka2/53EGMCbSTKv5DxMX+CHVE8ZD4zzxIyiGEJE5W1mJ3U4uG/LO9NGuut1Vxe4/57QEltJk2GnSJzk1MABzm7Ujeap4pzQ0oyXr5hy1OigsFNf5qDuxcRvmWM+50DPar5c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v4 03/11] xen/Arm: vreg: Support vreg_reg64_* helpers on AArch32 Date: Mon, 28 Nov 2022 15:56:41 +0000 Message-ID: <20221128155649.31386-4-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128155649.31386-1-ayan.kumar.halder@amd.com> References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT105:EE_|SJ1PR12MB6193:EE_ X-MS-Office365-Filtering-Correlation-Id: c8bc0b8d-d4c3-4046-db0d-08dad1593c42 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NfG6yuKSlD3RysAjcQjOa9ReUPytDgLoiXSmyD6USL34nFcj9R7fX0g1s5dOtP5e225IkCyJTFYLpBgJBLQjdUygkXglOQssczrj4Z89vPbrNPr8cmwD7RQfwYi49XuRGAaMZCQLFkLbL0y8j1+urLl1sFXC0E2Z/8NIF4s1R+Nwj9wIqdZlSgDXV0oot5naaIbQ6eGW7lrvHYREgaRc1+Lj+zYRJg2c1T8dJNx6Rpp0mRtGFKBS2zMTB12ETrnlpLgDqKYYwVeAwDtCQRL/0awgGXZx+udHee82c+PvTNF9GklnOnKe0Jh0U3NiJXyKfWYzZI1pHZfVy54QetwEUr++J/5zgaPokCHjQ/3UL1y+uZt2qVlVfpGDud1M9p9aKKGsz+s1Wtb/w1Rhz5+ZR8VigyOyVZuGF7ZQaz2QxdtW+cf+SkpTKZeg485ZguOFb8p11FBCw+BxARtRdnB6pEGaBh1KzJuwOEm5/UWAc/eKnbH7ZqdRJ3m8VbvWkC6OJasns+MNE973DnLAOuPTz4Rky4GQZgoolFwdANDSGWLCXN5xuap4Jdf57u9KI7RCGsSsoBeIA+R1aHkbZsQ/5UL2TAmyTVzK22X9kg6USzglhRlUzt4fLVhtcvdntwcziFWUUcFmm7r/EPR1lxQt2OdeDlN1vXrjXOHpgaye2MlDC+kYcPrswwYPPgWkJJ75TsJCk4h0xeGbI6auW3kpb+jk9IUaqFP5Gas2eXAhK9w= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(346002)(451199015)(40470700004)(36840700001)(46966006)(1076003)(2616005)(41300700001)(6666004)(86362001)(26005)(36756003)(40460700003)(316002)(6916009)(70206006)(8676002)(54906003)(40480700001)(70586007)(4326008)(103116003)(82740400003)(2906002)(83380400001)(5660300002)(336012)(8936002)(186003)(36860700001)(356005)(478600001)(82310400005)(426003)(47076005)(81166007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 15:57:21.8874 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c8bc0b8d-d4c3-4046-db0d-08dad1593c42 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT105.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6193 In some situations (e.g. GICR_TYPER), the hypervior may need to emulate 64bit registers in AArch32 mode. In such situations, the hypervisor may need to read/modify the lower or upper 32 bits of the 64 bit register. In AArch32, 'unsigned long' is 32 bits. Thus, we cannot use it for 64 bit registers. While we could replace 'unsigned long' by 'uint64_t', it is not entirely clear whether a 32-bit compiler would not allocate register for the upper 32-bit. Therefore fold vreg_reg_* helper in the size specific one and use the appropriate type based on the size requested. Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel Acked-by: Julien Grall --- Changes from - v1 - 1. Remove vreg_reg_extract(), vreg_reg_update(), vreg_reg_setbits() and vreg_reg_clearbits(). Moved the implementation to vreg_reg##sz##_*. 'mask' and 'val' is now using uint##sz##_t. v2 - 1. Use 'unsigned int' for 'shift' variable. 2. Updated the commit message. v3 - 1. No changes. Added Rb and Ack. xen/arch/arm/include/asm/vreg.h | 86 ++++++++------------------------- 1 file changed, 19 insertions(+), 67 deletions(-) diff --git a/xen/arch/arm/include/asm/vreg.h b/xen/arch/arm/include/asm/vreg.h index f26a70d024..d92450017b 100644 --- a/xen/arch/arm/include/asm/vreg.h +++ b/xen/arch/arm/include/asm/vreg.h @@ -89,106 +89,58 @@ static inline bool vreg_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr * The check on the size supported by the register has to be done by * the caller of vreg_regN_*. * - * vreg_reg_* should never be called directly. Instead use the vreg_regN_* - * according to size of the emulated register - * * Note that the alignment fault will always be taken in the guest * (see B3.12.7 DDI0406.b). */ -static inline register_t vreg_reg_extract(unsigned long reg, - unsigned int offset, - enum dabt_size size) -{ - reg >>= 8 * offset; - reg &= VREG_REG_MASK(size); - - return reg; -} - -static inline void vreg_reg_update(unsigned long *reg, register_t val, - unsigned int offset, - enum dabt_size size) -{ - unsigned long mask = VREG_REG_MASK(size); - int shift = offset * 8; - - *reg &= ~(mask << shift); - *reg |= ((unsigned long)val & mask) << shift; -} - -static inline void vreg_reg_setbits(unsigned long *reg, register_t bits, - unsigned int offset, - enum dabt_size size) -{ - unsigned long mask = VREG_REG_MASK(size); - int shift = offset * 8; - - *reg |= ((unsigned long)bits & mask) << shift; -} - -static inline void vreg_reg_clearbits(unsigned long *reg, register_t bits, - unsigned int offset, - enum dabt_size size) -{ - unsigned long mask = VREG_REG_MASK(size); - int shift = offset * 8; - - *reg &= ~(((unsigned long)bits & mask) << shift); -} /* N-bit register helpers */ #define VREG_REG_HELPERS(sz, offmask) \ static inline register_t vreg_reg##sz##_extract(uint##sz##_t reg, \ const mmio_info_t *info)\ { \ - return vreg_reg_extract(reg, info->gpa & (offmask), \ - info->dabt.size); \ + unsigned int offset = info->gpa & (offmask); \ + \ + reg >>= 8 * offset; \ + reg &= VREG_REG_MASK(info->dabt.size); \ + \ + return reg; \ } \ \ static inline void vreg_reg##sz##_update(uint##sz##_t *reg, \ register_t val, \ const mmio_info_t *info) \ { \ - unsigned long tmp = *reg; \ + unsigned int offset = info->gpa & (offmask); \ + uint##sz##_t mask = VREG_REG_MASK(info->dabt.size); \ + unsigned int shift = offset * 8; \ \ - vreg_reg_update(&tmp, val, info->gpa & (offmask), \ - info->dabt.size); \ - \ - *reg = tmp; \ + *reg &= ~(mask << shift); \ + *reg |= ((uint##sz##_t)val & mask) << shift; \ } \ \ static inline void vreg_reg##sz##_setbits(uint##sz##_t *reg, \ register_t bits, \ const mmio_info_t *info) \ { \ - unsigned long tmp = *reg; \ - \ - vreg_reg_setbits(&tmp, bits, info->gpa & (offmask), \ - info->dabt.size); \ + unsigned int offset = info->gpa & (offmask); \ + uint##sz##_t mask = VREG_REG_MASK(info->dabt.size); \ + unsigned int shift = offset * 8; \ \ - *reg = tmp; \ + *reg |= ((uint##sz##_t)bits & mask) << shift; \ } \ \ static inline void vreg_reg##sz##_clearbits(uint##sz##_t *reg, \ register_t bits, \ const mmio_info_t *info) \ { \ - unsigned long tmp = *reg; \ - \ - vreg_reg_clearbits(&tmp, bits, info->gpa & (offmask), \ - info->dabt.size); \ + unsigned int offset = info->gpa & (offmask); \ + uint##sz##_t mask = VREG_REG_MASK(info->dabt.size); \ + unsigned int shift = offset * 8; \ \ - *reg = tmp; \ + *reg &= ~(((uint##sz##_t)bits & mask) << shift); \ } -/* - * 64 bits registers are only supported on platform with 64-bit long. - * This is also allow us to optimize the 32 bit case by using - * unsigned long rather than uint64_t - */ -#if BITS_PER_LONG == 64 VREG_REG_HELPERS(64, 0x7); -#endif VREG_REG_HELPERS(32, 0x3); #undef VREG_REG_HELPERS -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 15:57:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 15:57:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449014.705641 (Exim 4.92) (envelope-from ) id 1ozgVh-0005DG-Rb; Mon, 28 Nov 2022 15:57:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449014.705641; Mon, 28 Nov 2022 15:57:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgVh-0005Cj-Nq; Mon, 28 Nov 2022 15:57:33 +0000 Received: by outflank-mailman (input) for mailman id 449014; Mon, 28 Nov 2022 15:57:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgVf-0004G7-MB for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:57:31 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20615.outbound.protection.outlook.com [2a01:111:f400:7eaa::615]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c940f87-6f35-11ed-8fd2-01056ac49cbb; Mon, 28 Nov 2022 16:57:30 +0100 (CET) Received: from DM6PR06CA0008.namprd06.prod.outlook.com (2603:10b6:5:120::21) by IA1PR12MB6433.namprd12.prod.outlook.com (2603:10b6:208:3af::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 15:57:27 +0000 Received: from DM6NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:5:120:cafe::8) by DM6PR06CA0008.outlook.office365.com (2603:10b6:5:120::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.22 via Frontend Transport; Mon, 28 Nov 2022 15:57:27 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT056.mail.protection.outlook.com (10.13.173.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Mon, 28 Nov 2022 15:57:26 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 09:57:26 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 07:57:25 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 28 Nov 2022 09:57:22 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c940f87-6f35-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DISS9lSqQRUuF8OQlqH8/YFth4wCdGDvrf0wJgupzeLY523c6FcfVPqkVxfpD8+x2CrAFdAeWo6hK6CLV7KXwMDwhF1RoMjY9SPIP8YLUP+DHq63MInUJg3xv454Eqznrv0TgOcYjDRNJzlovBtgFMO7UHA2RlTseFzNrBtZYQ1PIxQ0GSDob4OKB80QUrdKgjIcosI3kEqlbJ2ey/5Pw33/DKCR9Q36RY3IwIBJ+H00cJCkMB5Cfj+MtyedAws+0ztZYc5k3/K8tZbtHqlqcDTI12dEY5Vtul8/GroR5G/8KbrdnbwlFZA8rqWl8PQJ47UyAve3a8kVEH08uIElNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kHPxMWUa29+xaFmCOEcfUOn2GgVi3+FD6m5d0NUuByk=; b=FbSniy5sECww9lVrWa1HDkws+N7nSxB17s934eKGmyBZz/r0WHl0UeZ0B0r4AUTK8qDDlyOmBFMWkYVsKCMzJ48dsclrBKGxhv0TTIswKWEDHpkwM8dnQS+pVxBiB7bjIhGxWuWWm2Xe1aNBM/aJyudQqRKDLLhG/lC43CZzxC1LVFcPYi1sZtUvOaOxGSMlin6oPIF4wltdrQpjhoZqbl8LqA8VhZK+qvNc0LSmzKOly7TOyO+qAfDQSLtNmHfRuYvEOHwLdPZLscwTsBerEruqPP85C2ihxP72yTOo7SQLJQqJjx1cWmAoxnpI2vuxO6iWY93njtaFboQZEua35A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kHPxMWUa29+xaFmCOEcfUOn2GgVi3+FD6m5d0NUuByk=; b=k124bvA3bLWuudYRHaHKJbGflJKtoabAjcaRM2C0kWSTID52yyTG7cSZRqgebruE26T+/aPn+5fmskrqWVmbP7tuL5XKlqufy+r1N8ILeM41Tms2pOF/0JT/V7YGzpe/EYxm+voiukn5gF4mOJ/w8jWgemun/bSvWTjjuCraxZI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v4 04/11] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32 Date: Mon, 28 Nov 2022 15:56:42 +0000 Message-ID: <20221128155649.31386-5-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128155649.31386-1-ayan.kumar.halder@amd.com> References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT056:EE_|IA1PR12MB6433:EE_ X-MS-Office365-Filtering-Correlation-Id: e894425c-f259-405c-2cbc-08dad1593f2e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PZbPl/MHJEHRog2yXZ/vi/TtA2GO2rX9NfslY4NxZEHXJvASCAYna/25hWV4dqPk2CiKmRb5mQ9/+6GWdGo23xTwpXwjh1lgyVFs8gketfuXM+BE0e0QwEMUdxtCIH5scqBY5qHj2XhQhG8nNZws1rZZcDL40srhlQhXGNn8/XtKOLCaF0vgUG0sjWCdrFvxDFpe0s8GwouZDQZGT5EIN45sCZxbU8NduhaCZzS6wpHjHzFgyqbmo+T2n6dJVgiFSDwFfF6ntfqKlcwVGYC46uhC4gWhO2O/P6GwXHuGurBcGtgJ5mIfcJi7tVE2Hu4WIIUtpU9rjmCm66Q0zSB1fAsNILHMfTsxhY7VO/VaXEtGJU53z6lS+yyL82puFhnjB53JLAc+L19LqZzlQoCMtcCXlzcVUEzjBMiE9ghvcH81b7p5xkfTyas0UUnNAitblEnxaECv5v0225lNskq4Ul/BDA0JP/GM+hDbKurw9LMcoDFCBCbez0Xp4IzYBhWBzLa5uKxqqEI5Z8UjgfA1A3VF3SbDbCbJNZIB8YBKyPrwKXUnt2bT10Y/51zTGFfkuJLKcercIiGcsE55UVfUh868V0059VgrTVWkVp+n9JFrggmCjQCMp4Xp9nByLQ5r3gM4s46r2xJJv4Fl04plYovIsRchLOrzmBDIYoVLSZGunsQemz0TO1WLN7JwPfWCCd3/xTRedmYON7v6b7UhExqtRYjv7uRrPtAfJ+4CGgY= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(376002)(396003)(451199015)(40470700004)(36840700001)(46966006)(47076005)(426003)(5660300002)(40480700001)(103116003)(6916009)(54906003)(8936002)(2616005)(316002)(26005)(40460700003)(41300700001)(336012)(1076003)(186003)(70586007)(36756003)(8676002)(4326008)(82310400005)(70206006)(81166007)(356005)(82740400003)(2906002)(83380400001)(36860700001)(86362001)(478600001)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 15:57:26.7225 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e894425c-f259-405c-2cbc-08dad1593f2e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6433 Refer ARM DDI 0487I.a ID081822, G8-9650, G8.2.113 Aff3 does not exist on AArch32. Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106 Aff3 does not exist on Armv7 (ie arm32). Thus, access to aff3 has been protected with "#ifdef CONFIG_ARM_64". Also, v->arch.vmpidr is a 32 bit register on AArch32. So, we have assigned it to 'uint64_t vmpidr' to perform the shifts. Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel --- Changes from :- v1 - Assigned v->arch.vmpidr to "uint64_t vmpdir". Then, we can use MPIDR_AFFINITY_LEVEL macros to extract the affinity value. v2 - 1. "MPIDR_AFFINITY_LEVEL(vmpidr, 3)" is contained within "#ifdef CONFIG_ARM_64". 2. Updated commit message. v3 - 1. Added an inline comment to explain type widening for v->arch.vmpidr. 2. Updated the commit message. Added Rb. xen/arch/arm/vgic-v3.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index 3f4509dcd3..e0b636b95f 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -191,12 +191,20 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info, case VREG64(GICR_TYPER): { uint64_t typer, aff; + /* + * This is to enable shifts greater than 32 bits which would have + * otherwise caused overflow (as v->arch.vmpidr is 32 bit on AArch32). + */ + uint64_t vmpidr = v->arch.vmpidr; if ( !vgic_reg64_check_access(dabt) ) goto bad_width; - aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 | - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 | - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 | - MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32); + aff = ( +#ifdef CONFIG_ARM_64 + MPIDR_AFFINITY_LEVEL(vmpidr, 3) << 56 | +#endif + MPIDR_AFFINITY_LEVEL(vmpidr, 2) << 48 | + MPIDR_AFFINITY_LEVEL(vmpidr, 1) << 40 | + MPIDR_AFFINITY_LEVEL(vmpidr, 0) << 32); typer = aff; /* We use the VCPU ID as the redistributor ID in bits[23:8] */ typer |= v->vcpu_id << GICR_TYPER_PROC_NUM_SHIFT; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 15:57:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 15:57:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449015.705652 (Exim 4.92) (envelope-from ) id 1ozgVl-0005dk-6G; Mon, 28 Nov 2022 15:57:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449015.705652; Mon, 28 Nov 2022 15:57:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgVl-0005dX-2D; Mon, 28 Nov 2022 15:57:37 +0000 Received: by outflank-mailman (input) for mailman id 449015; Mon, 28 Nov 2022 15:57:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgVj-00040T-JA for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:57:35 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20606.outbound.protection.outlook.com [2a01:111:f400:fe5a::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5eba205a-6f35-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 16:57:34 +0100 (CET) Received: from BN7PR06CA0061.namprd06.prod.outlook.com (2603:10b6:408:34::38) by SJ1PR12MB6313.namprd12.prod.outlook.com (2603:10b6:a03:458::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.21; Mon, 28 Nov 2022 15:57:31 +0000 Received: from BN8NAM11FT097.eop-nam11.prod.protection.outlook.com (2603:10b6:408:34:cafe::8c) by BN7PR06CA0061.outlook.office365.com (2603:10b6:408:34::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Mon, 28 Nov 2022 15:57:31 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT097.mail.protection.outlook.com (10.13.176.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.20 via Frontend Transport; Mon, 28 Nov 2022 15:57:29 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 09:57:29 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 28 Nov 2022 09:57:27 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5eba205a-6f35-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eZ5rZPyrnBy/sRZm1iWHr4foSonbs4ZHRq54MARnLXQyLdQ5AG1LZV2rYPs5Codmry1eC4N+5d68pqK4fSpXvi7/NimftBvPCVUCjoesCOLQ3QI3ubC2z39DMRAPg7jJ7pXiCAeXoO2SGRCmUMkx2soVBqrzrHPBHcWP3Dl/aTnHJVmte35q1CtDBsVfhSU39pjjJM0nYjt7jJeDCcJuAvuLGQPPtulX89ezaYqde4kqWAWaeQep7w412JOjtvOy413YfzkxBYPaHAHCm0he6wCiOc9v7pg95TIW3+Rin3geOrxDqcdVoVCIPQwZ1m9AhEtj/GxkxFp7yQX7uuJ4nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gTBusEydfO2ISdBhEpiWD6caKDOMEqvYCvIwqAcCI+g=; b=SG9QD/SY5+7MILfBHSbkcU57Nvmn5AS+8xNAAYxUvNJJgSpb1rhk01Ak0v/uC8u9ekgHExmcIiTV0l2GNs6FjdmgAW+NLo673ElFKdcxThET9apEZYatnpssnMm8oL32g3KFNrYaTrnz6OQqJfEuTl+EFKg1GbMJVCt+w7N0OZNEa4QQ1tg1HI4SJZvmrCzp4KzZ95tN3bpr8U6I43eaU98xHrJOSj5rTf1tboMRkr3oASxjQ7+oqZtd0LGFIhyEPni60RDkKZXX4lGjfrl39exRjKoGU3MCTAwGSadWVulhmMnB4Dg0eQ1bdIf/ToybgnlYbSrtRxlh4xLdgNovIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gTBusEydfO2ISdBhEpiWD6caKDOMEqvYCvIwqAcCI+g=; b=w9PSs9iJW32Q/gcho7nIItWWjbpOen8vm+/JN3Fawh0Jnk6ZAVAaxrkHN6Dmoqyz38ssNFHEZPgOgI8A7dYSNSS29gMYIFIR9PTUP+S0T/4SarOfHKuXGXztBz03h1swyumPpaH1gh9JyjSiKXha6dDluLtFXCX2EqFTryVkPVU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v4 05/11] xen/Arm: GICv3: Fix GICR_{PENDBASER, PROPBASER} emulation on 32-bit host Date: Mon, 28 Nov 2022 15:56:43 +0000 Message-ID: <20221128155649.31386-6-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128155649.31386-1-ayan.kumar.halder@amd.com> References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT097:EE_|SJ1PR12MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e48ecc8-166d-4124-4378-08dad15940ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SnJnLXPTFmcQVp9uXfKjMLyPxrW76McqcwJJWcsLDLajEafGG0JLdFSGMBpRhtqYVl1CfB8N5rQ9f++GnALgfh1mqtbItF3b5AR+late5pS8L41zT/Z/OdZNhJ91FN2+SOVRo/x3NO8Pj6OdVAPaZ82GlIKEZ/2aXoCwa+KwSFQLyoKFSq/L/pUM75syg2nVijhE2CybhAw9puiqaZ0AEKgrM58J9nPSadmf+JbSCNa0bbC6g4Jc8zuLsUqlIZVp40yM6c9kqiQzAoQPb89VzcXkSTYKZXWOFYVSHBJW030smbI/6IJlwyiaC3iyd0+nzywgYsy7hYFgrT7yYOSvM9L0hBsAtGEd7WYZmlEBK/k40AQWwoH8EZBw0eRWhnW+NWNuRnaL7WlgGeHNTzWAZCwF1sDV1hhATMcIttnAQJ8LsPuihLqBW81FeyKJ0ACIWjeEfOj4r7IaPO1ADbVkNvl8te4Sd5DfjLKJ9j1exW5ByzQd7jx98fFAjzYTh/3STN9AX8+An0qa7qqLGaB5wR8opw+n+L930rYObIbJxzSOlyhWs2bTqI84vyxduGRySRtT3mnkveBo5VXiNuXKrlE1jDWm02+JNBalMHq2vzIXh6B8dJjKVoVU7OpaQzk9ExA6uCQMNgY8J0PWyU8KInxPY1SqIl+UHgIn2s9QtAOPeqDfa2YenYo6i4ibHtazTATki2L45nzLZLZqUakNKilu6W/6iKpjTRCAI7yRidvrywk16zT3iOOLtWENDBB7ICb/5vGxBfrxuoen7K3hSA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199015)(46966006)(40470700004)(36840700001)(86362001)(36756003)(40460700003)(103116003)(2906002)(82740400003)(36860700001)(40480700001)(82310400005)(5660300002)(8936002)(41300700001)(4326008)(83380400001)(47076005)(81166007)(356005)(966005)(6916009)(54906003)(478600001)(186003)(316002)(26005)(70206006)(6666004)(8676002)(426003)(70586007)(2616005)(336012)(1076003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 15:57:29.7528 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4e48ecc8-166d-4124-4378-08dad15940ee X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT097.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6313 'unsigned long long' is defined as 64 bit across both AArch32 and AArch64. So, use 'ULL' for 64 bit word instead of UL which is 32 bits for AArch32. GICR_PENDBASER and GICR_PROPBASER both are 64 bit registers. Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel Acked-by: Julien Grall --- Changes from - v1 - 1. Extract the bug fix for incorrect bit clearing (GICR_PENDBASER_PTZ) into a separate patch fix. https://patchwork.kernel.org/project/xen-devel/patch/20221027185555.46125-1-ayankuma@amd.com/ v2 - No changes. v3 - No changes. xen/arch/arm/include/asm/gic_v3_defs.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h index 728e28d5e5..48a1bc401e 100644 --- a/xen/arch/arm/include/asm/gic_v3_defs.h +++ b/xen/arch/arm/include/asm/gic_v3_defs.h @@ -134,15 +134,15 @@ #define GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT 56 #define GICR_PROPBASER_OUTER_CACHEABILITY_MASK \ - (7UL << GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT) + (7ULL << GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT) #define GICR_PROPBASER_SHAREABILITY_SHIFT 10 #define GICR_PROPBASER_SHAREABILITY_MASK \ - (3UL << GICR_PROPBASER_SHAREABILITY_SHIFT) + (3ULL << GICR_PROPBASER_SHAREABILITY_SHIFT) #define GICR_PROPBASER_INNER_CACHEABILITY_SHIFT 7 #define GICR_PROPBASER_INNER_CACHEABILITY_MASK \ - (7UL << GICR_PROPBASER_INNER_CACHEABILITY_SHIFT) + (7ULL << GICR_PROPBASER_INNER_CACHEABILITY_SHIFT) #define GICR_PROPBASER_RES0_MASK \ - (GENMASK(63, 59) | GENMASK(55, 52) | GENMASK(6, 5)) + (GENMASK_ULL(63, 59) | GENMASK_ULL(55, 52) | GENMASK_ULL(6, 5)) #define GICR_PENDBASER_SHAREABILITY_SHIFT 10 #define GICR_PENDBASER_INNER_CACHEABILITY_SHIFT 7 @@ -152,11 +152,11 @@ #define GICR_PENDBASER_INNER_CACHEABILITY_MASK \ (7UL << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT) #define GICR_PENDBASER_OUTER_CACHEABILITY_MASK \ - (7UL << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT) -#define GICR_PENDBASER_PTZ BIT(62, UL) + (7ULL << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT) +#define GICR_PENDBASER_PTZ BIT(62, ULL) #define GICR_PENDBASER_RES0_MASK \ - (BIT(63, UL) | GENMASK(61, 59) | GENMASK(55, 52) | \ - GENMASK(15, 12) | GENMASK(6, 0)) + (BIT(63, ULL) | GENMASK_ULL(61, 59) | GENMASK_ULL(55, 52) | \ + GENMASK_ULL(15, 12) | GENMASK_ULL(6, 0)) #define DEFAULT_PMR_VALUE 0xff -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 15:57:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 15:57:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449023.705663 (Exim 4.92) (envelope-from ) id 1ozgVt-0006Mb-MY; Mon, 28 Nov 2022 15:57:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449023.705663; Mon, 28 Nov 2022 15:57:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgVt-0006MO-J3; Mon, 28 Nov 2022 15:57:45 +0000 Received: by outflank-mailman (input) for mailman id 449023; Mon, 28 Nov 2022 15:57:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgVs-00040T-LC for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:57:44 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20603.outbound.protection.outlook.com [2a01:111:f400:7e89::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 63a35b60-6f35-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 16:57:43 +0100 (CET) Received: from DM6PR12CA0007.namprd12.prod.outlook.com (2603:10b6:5:1c0::20) by DM6PR12MB4895.namprd12.prod.outlook.com (2603:10b6:5:1bc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 15:57:39 +0000 Received: from DM6NAM11FT077.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1c0:cafe::b) by DM6PR12CA0007.outlook.office365.com (2603:10b6:5:1c0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Mon, 28 Nov 2022 15:57:39 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT077.mail.protection.outlook.com (10.13.173.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.22 via Frontend Transport; Mon, 28 Nov 2022 15:57:38 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 09:57:38 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 07:57:38 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 28 Nov 2022 09:57:36 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63a35b60-6f35-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J8esFL0K/xFVRY+msOleT44SMjlUxipeGE0vvCAOgEL+XElp4XiqXiX3pe7NktIJCOo04TaCP7ZtVCh+LWKQhWi2ff5fcT+wD+NXAP+IcOW5FjR8Uua/DhGgRULoGdZW4wi5QEZYQP+PKo5bqZKlQjm1ozN1qYQq41BcSzcOld9XdAaYCKyO7ynTxHySLADIDwTsUKztJMwiTlhkKzPz+rKGAcbQcftBwLZP4RILjSfPDegBUB9LqBlHOa+rIHqtViWgfxZxz3Sk25GDzNf4OIbw1XhGtuQGS6xCdRvVFFxZwDY4MauJHZnAw7awgKUlnt5cQyNXdHd14zCXHQTCyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZWnmupfzzitApxD+hPh9hKT2gUvFQ71h9WJ/O2B/tL4=; b=VekTy9ztrqYP+G1ShiIfTccBTzqwT6APmor9AEaDWCL/w1YNp+FEaMqquD4vCcyPBhzIspyTVmYqGs0qoETsDkXbm/LAET+xnxe4EOna10k96a/atGVoqPm1whpn7Krn+c1FykZQ4jAQHnJYf2Juf6jfQbT4dJ2krimI2tGOB03KtJ25acBktXQED85Z6ABxumPYTZ1Ggadl8rf65b4KJtrrLUUT3rPG0IHjWhEiYtDfi3XlJXRRV0NYqePiFRsVU525OGb2jhSlBkPIMPiobA5PN2qzE2fEmY6jbRF0asiHne4b4bsw24H2D6m1NF5nhlc1TZFxiuDPFiwzPkvnrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZWnmupfzzitApxD+hPh9hKT2gUvFQ71h9WJ/O2B/tL4=; b=TecdKDIiGkJVYISCWX5fPUN/f2gLaprIDZbEDthnRFKv41p84FP6S3pcEj0A9GsTdc7+JtKCRYnA3KWLpEWEbIJMY5RDK9jb1grQDEtguBkklbSKnApIs8W8v7JRNH+VLyYfvsMnOZy5VdV/JmXfEA67CajUb68fTdTLXxGl594= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v4 06/11] xen/Arm: vGICv3: Fix emulation of ICC_SGI1R on AArch32 Date: Mon, 28 Nov 2022 15:56:44 +0000 Message-ID: <20221128155649.31386-7-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128155649.31386-1-ayan.kumar.halder@amd.com> References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT077:EE_|DM6PR12MB4895:EE_ X-MS-Office365-Filtering-Correlation-Id: 90d3af6e-94b9-4a21-9370-08dad1594658 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P/oH3VVmLde9UeMRcq/gB+2H9Tq873ugViYMeaiby1BDJCw0LihnnFK7ZxjO9D5GuqHnCYHq1x/IeS7pMvDSsGFbOiZE8niGeoUZgBRUClSP6YA08ORJV8ykFweAntmw4vuLiMxwgxBSv8Fqp3irn7Np6hAxz7A5hzc3J6eZQsAGtmRuPFpb/b9QxlGUKI4U84kKuIs5AniVLceTJqJyP6NQ/bD1nDM2PNuXoPenBI60brsBzqxCFZSJAgX9mqGhpsU/G5KwqQYulPCjp0mrl3v4qwewykSAWIQXJkhxy+tHlIKqnowYx8pRvmYFgP53nUpA8sfbMhJ+bcehPB/nKK330DAHZvNGmlxXJmT48wLRyuIcCIfTdim3vwmTp98nO7leMVK1znyV1amVMLoC02GJ7BhD3+a7YsvcUFnsyKhXgSdmwMq77kCaI+PE1Uz2c/8+BICJ1soewaqQe7mKjTSzNagrMdzDvvhGtiN8C2fFvhu/lAb+YuNphnSEgTEpeXxidGZY+YG2CWzCyVFZhbA67SGkH6M/Va2fq5KWEoOjVj6PH5p0l6Q6zmZvlJGsKs7LQuq73Ln8GQEV9demRrwfvGrqtem2NseIYbW/+8Mqcg9DObALCZQ5aSiM8j4jAWZWxDVT6bJCDw9uoFPIV8MyHMMR5zbo6DhzEU2vaQfMMaa+mgUVBL1dHjBt63XQwiLllIwwMiqd8A0Buz5aC7oUaG99dpchgDorgyp1lpk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(396003)(136003)(451199015)(46966006)(40470700004)(36840700001)(36756003)(81166007)(40480700001)(82740400003)(356005)(82310400005)(6666004)(26005)(478600001)(41300700001)(70586007)(8676002)(70206006)(40460700003)(86362001)(54906003)(4326008)(316002)(4744005)(6916009)(186003)(103116003)(8936002)(5660300002)(336012)(426003)(47076005)(1076003)(2616005)(83380400001)(2906002)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 15:57:38.8069 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90d3af6e-94b9-4a21-9370-08dad1594658 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT077.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4895 Refer Arm IHI 0069H ID020922, 12.5.23, ICC_SGI1R is a 64 bit register on AArch32 systems. Thus, the function needs to change to reflect this. The reason being 'register_t' is defined as 'u32' on AArch32. Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel Acked-by: Julien Grall --- Changes from :- v1 - 1. Updated the commit message. v2 - 1. No changes. v3 - 1. No changes. xen/arch/arm/vgic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index e0b636b95f..47575d4944 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -1483,7 +1483,7 @@ write_reserved: return 1; } -static bool vgic_v3_to_sgi(struct vcpu *v, register_t sgir) +static bool vgic_v3_to_sgi(struct vcpu *v, uint64_t sgir) { int virq; int irqmode; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 15:57:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 15:57:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449027.705674 (Exim 4.92) (envelope-from ) id 1ozgW2-00077I-0F; Mon, 28 Nov 2022 15:57:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449027.705674; Mon, 28 Nov 2022 15:57:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgW1-00076S-TR; Mon, 28 Nov 2022 15:57:53 +0000 Received: by outflank-mailman (input) for mailman id 449027; Mon, 28 Nov 2022 15:57:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgW0-0004G7-6C for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:57:52 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20615.outbound.protection.outlook.com [2a01:111:f400:fe59::615]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 68730767-6f35-11ed-8fd2-01056ac49cbb; Mon, 28 Nov 2022 16:57:50 +0100 (CET) Received: from BN9PR03CA0065.namprd03.prod.outlook.com (2603:10b6:408:fc::10) by SA1PR12MB7410.namprd12.prod.outlook.com (2603:10b6:806:2b4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.22; Mon, 28 Nov 2022 15:57:47 +0000 Received: from BN8NAM11FT067.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fc:cafe::8a) by BN9PR03CA0065.outlook.office365.com (2603:10b6:408:fc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Mon, 28 Nov 2022 15:57:46 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT067.mail.protection.outlook.com (10.13.177.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.22 via Frontend Transport; Mon, 28 Nov 2022 15:57:46 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 09:57:44 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 07:57:43 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 28 Nov 2022 09:57:42 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68730767-6f35-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mGFW6cPBE1ZdLsUH1LiW2ryf+Toxv3mECYZ1izfugv93zlpqwibm64QwcAsc/L/bLRw/keRFOKeRJsNQRZs/B3mKpPBKmGMS5yNzSpcatYCOw75PYLbQmY6z3fbv9ImzxUN8Ym0rSzlHW1WZ6Qpuw0tuwq5b0wNnLAfWi2wAM7ZzcTSOPa5J+u0nZNMOnycHtrHgCq+9E64ZHBtgCU6Goqqu2qhuiH6sHmbCmi2yMmq3BLIVHGN1lpg/Tk3f97fd3+TN/GPdSJYVNcgCh/HIAP8WHnwhsg/L0qoyvPsuvJoObxcw2b9mZAPwzNzlEP4CHCQOTaAuIhXDLFNSjkiaHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dqx0a48FA+ehf5uHjfytDEa1WxcEZ3LXfIN0HJxb6Ic=; b=I91UICcX+OIQowQBhtum2vez+G4M6qg0rzvR4JXcc/aGtA3YZP832WIY0+waRVek2zNheZ8L4sg+3eDo1j2Icsdb4DrB/DEHr7h085wnyLDkFsUDPOjnNPd7hu6qRd22zLNihLYY+8FL/aMn3IOcM7iuspGlWjS4l/fuWBkLFcY+wGHd4Cva2NfrbHxFi7zdXePbPufLs1ossNa5gd5/VhAZiXIWK1+XZr+qEZZ0BaG/U2hpB1K/e63FKa+FY99ogrum6Y6FseyarlHZpGPSKZZdC7E+UnJyZAI44f1Y3BomFG1PMYjzfnf8aurFDQZjCmJUw5arOgkkyW9it0ea6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dqx0a48FA+ehf5uHjfytDEa1WxcEZ3LXfIN0HJxb6Ic=; b=d6BPCxTU7bKWRa3TpoLjWQbzCotxNIZK6sk6PQq9XVLyWBmn+km1wWF1waZEDtZFnxSIH7JezMebsmu+AtfpsyYd3gjo0N3KNm3llwxGxwBStPh34Qyj9AhO5Mgxi/oxPAZBStB0Z7dT4MKTOvkfQG2wv6NY/1Nybo3NiOSCHJ4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v4 07/11] xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32 Date: Mon, 28 Nov 2022 15:56:45 +0000 Message-ID: <20221128155649.31386-8-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128155649.31386-1-ayan.kumar.halder@amd.com> References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT067:EE_|SA1PR12MB7410:EE_ X-MS-Office365-Filtering-Correlation-Id: 216a4860-0c59-4336-c0d1-08dad1594acd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0eNKKoBQ6wMnC4muG6I58lXc1wxPx4FmHi2O/nnLR0InFtTbS+529uPLeOAKJnrPyP36slvFXhG2IpHhpy+OeJGF0jqbMGMh6bHb/NOKjLw6/LOjbw6KlP0MhQs/to9tpxAuh42yeZnedEP7JlbXB1RsE7CWjIucWxhSKPGZ8UJWcvYYFYtpUGT8/07UEF8POX+Y4fYvOjHsbLDYxNQgLqzEoNmg6bSpjQgXugZOdNJZa1ngMYWq9pqwRT2jgpeXpu4KatN40Kb3u13JF4NYrCnRrf0PN6yRltUZLKb6oUt8dyhotrNVkP4WThNqu73tAKgpF+NFs9cSVA6EWM+EReTWwB6r7/3VRxwgiB5Gkec8mMQ+rf/Gk2JcSRlE/SMvRF2uNQyHuNbRIrvKA8bL+EIhO27bThwCa251I6kNcPoan2NKKspaOu3VUWQAvdhJOxvsHc8MbBx06V+DxtiC5/4euKIWHc7mEuBmMSZWnJ7rxGfZrlmAYc+1ZimUyEh3jc64Vz2Ta+c0ZFjMRckmkZcKhVF6+408EaOZOytcbXZeGG+O61R6Twb73nedd/wvafenBgeJJH69x55jBvL3P5Y/1NCrpzZ9Sb89DvaOsEqDFKMh4gQSX95TGoL1dhnmrda8cRoJO09bh15e7JLgsaXgoTXPRrO6ydTzbcVkgd63V/kb21mDJanx5edb3zX8nUXpDNQ1ll/GCBjKrjN51wRueM4ld2DOqEbvOLh8Ljs= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(82310400005)(356005)(36756003)(81166007)(40480700001)(478600001)(82740400003)(26005)(41300700001)(70586007)(8676002)(70206006)(40460700003)(86362001)(54906003)(6916009)(4326008)(316002)(30864003)(103116003)(8936002)(5660300002)(426003)(336012)(186003)(2616005)(1076003)(47076005)(83380400001)(2906002)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 15:57:46.3326 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 216a4860-0c59-4336-c0d1-08dad1594acd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT067.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7410 Refer "Arm IHI 0069H ID020922", 12.4.6, Interrupt Controller List Registers AArch64 System register ICH_LR_EL2 bits [31:0] are architecturally mapped to AArch32 System register ICH_LR[31:0]. AArch64 System register ICH_LR_EL2 bits [63:32] are architecturally mapped to AArch32 System register ICH_LRC[31:0]. Defined ICH_LR<0...15>_EL2 and ICH_LRC<0...15>_EL2 for AArch32. For AArch32, the link register is stored as :- (((uint64_t) ICH_LRC<0...15>_EL2) << 32) | ICH_LR<0...15>_EL2 Also, ICR_LR macros need to be modified as ULL is 64 bits for AArch32 and AArch64. Signed-off-by: Ayan Kumar Halder --- Changes from :- v1 - 1. Moved the coproc register definitions to asm/cpregs.h. 2. Use GENMASK(31, 0) to represent 0xFFFFFFFF 3. Use READ_CP32()/WRITE_CP32() instead of READ_SYSREG()/WRITE_SYSREG(). 4. Multi-line macro definitions should be enclosed within ({ }). v2 - 1. Use WRITE_SYSREG_LR(V, R) to make it consistent with before. 2. Defined the register alias. 3. Style issues. v3 - 1. Addressed style issues. xen/arch/arm/gic-v3.c | 132 +++++++++++------------ xen/arch/arm/include/asm/arm32/sysregs.h | 19 ++++ xen/arch/arm/include/asm/arm64/sysregs.h | 5 + xen/arch/arm/include/asm/cpregs.h | 76 +++++++++++++ xen/arch/arm/include/asm/gic_v3_defs.h | 8 +- 5 files changed, 170 insertions(+), 70 deletions(-) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 64a76307dd..6457e7033c 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -73,37 +73,37 @@ static inline void gicv3_save_lrs(struct vcpu *v) switch ( gicv3_info.nr_lrs ) { case 16: - v->arch.gic.v3.lr[15] = READ_SYSREG(ICH_LR15_EL2); + v->arch.gic.v3.lr[15] = READ_SYSREG_LR(15); case 15: - v->arch.gic.v3.lr[14] = READ_SYSREG(ICH_LR14_EL2); + v->arch.gic.v3.lr[14] = READ_SYSREG_LR(14); case 14: - v->arch.gic.v3.lr[13] = READ_SYSREG(ICH_LR13_EL2); + v->arch.gic.v3.lr[13] = READ_SYSREG_LR(13); case 13: - v->arch.gic.v3.lr[12] = READ_SYSREG(ICH_LR12_EL2); + v->arch.gic.v3.lr[12] = READ_SYSREG_LR(12); case 12: - v->arch.gic.v3.lr[11] = READ_SYSREG(ICH_LR11_EL2); + v->arch.gic.v3.lr[11] = READ_SYSREG_LR(11); case 11: - v->arch.gic.v3.lr[10] = READ_SYSREG(ICH_LR10_EL2); + v->arch.gic.v3.lr[10] = READ_SYSREG_LR(10); case 10: - v->arch.gic.v3.lr[9] = READ_SYSREG(ICH_LR9_EL2); + v->arch.gic.v3.lr[9] = READ_SYSREG_LR(9); case 9: - v->arch.gic.v3.lr[8] = READ_SYSREG(ICH_LR8_EL2); + v->arch.gic.v3.lr[8] = READ_SYSREG_LR(8); case 8: - v->arch.gic.v3.lr[7] = READ_SYSREG(ICH_LR7_EL2); + v->arch.gic.v3.lr[7] = READ_SYSREG_LR(7); case 7: - v->arch.gic.v3.lr[6] = READ_SYSREG(ICH_LR6_EL2); + v->arch.gic.v3.lr[6] = READ_SYSREG_LR(6); case 6: - v->arch.gic.v3.lr[5] = READ_SYSREG(ICH_LR5_EL2); + v->arch.gic.v3.lr[5] = READ_SYSREG_LR(5); case 5: - v->arch.gic.v3.lr[4] = READ_SYSREG(ICH_LR4_EL2); + v->arch.gic.v3.lr[4] = READ_SYSREG_LR(4); case 4: - v->arch.gic.v3.lr[3] = READ_SYSREG(ICH_LR3_EL2); + v->arch.gic.v3.lr[3] = READ_SYSREG_LR(3); case 3: - v->arch.gic.v3.lr[2] = READ_SYSREG(ICH_LR2_EL2); + v->arch.gic.v3.lr[2] = READ_SYSREG_LR(2); case 2: - v->arch.gic.v3.lr[1] = READ_SYSREG(ICH_LR1_EL2); + v->arch.gic.v3.lr[1] = READ_SYSREG_LR(1); case 1: - v->arch.gic.v3.lr[0] = READ_SYSREG(ICH_LR0_EL2); + v->arch.gic.v3.lr[0] = READ_SYSREG_LR(0); break; default: BUG(); @@ -120,37 +120,37 @@ static inline void gicv3_restore_lrs(const struct vcpu *v) switch ( gicv3_info.nr_lrs ) { case 16: - WRITE_SYSREG(v->arch.gic.v3.lr[15], ICH_LR15_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[15], 15); case 15: - WRITE_SYSREG(v->arch.gic.v3.lr[14], ICH_LR14_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[14], 14); case 14: - WRITE_SYSREG(v->arch.gic.v3.lr[13], ICH_LR13_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[13], 13); case 13: - WRITE_SYSREG(v->arch.gic.v3.lr[12], ICH_LR12_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[12], 12); case 12: - WRITE_SYSREG(v->arch.gic.v3.lr[11], ICH_LR11_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[11], 11); case 11: - WRITE_SYSREG(v->arch.gic.v3.lr[10], ICH_LR10_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[10], 10); case 10: - WRITE_SYSREG(v->arch.gic.v3.lr[9], ICH_LR9_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[9], 9); case 9: - WRITE_SYSREG(v->arch.gic.v3.lr[8], ICH_LR8_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[8], 8); case 8: - WRITE_SYSREG(v->arch.gic.v3.lr[7], ICH_LR7_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[7], 7); case 7: - WRITE_SYSREG(v->arch.gic.v3.lr[6], ICH_LR6_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[6], 6); case 6: - WRITE_SYSREG(v->arch.gic.v3.lr[5], ICH_LR5_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[5], 5); case 5: - WRITE_SYSREG(v->arch.gic.v3.lr[4], ICH_LR4_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[4], 4); case 4: - WRITE_SYSREG(v->arch.gic.v3.lr[3], ICH_LR3_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[3], 3); case 3: - WRITE_SYSREG(v->arch.gic.v3.lr[2], ICH_LR2_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[2], 2); case 2: - WRITE_SYSREG(v->arch.gic.v3.lr[1], ICH_LR1_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[1], 1); case 1: - WRITE_SYSREG(v->arch.gic.v3.lr[0], ICH_LR0_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[0], 0); break; default: BUG(); @@ -161,22 +161,22 @@ static uint64_t gicv3_ich_read_lr(int lr) { switch ( lr ) { - case 0: return READ_SYSREG(ICH_LR0_EL2); - case 1: return READ_SYSREG(ICH_LR1_EL2); - case 2: return READ_SYSREG(ICH_LR2_EL2); - case 3: return READ_SYSREG(ICH_LR3_EL2); - case 4: return READ_SYSREG(ICH_LR4_EL2); - case 5: return READ_SYSREG(ICH_LR5_EL2); - case 6: return READ_SYSREG(ICH_LR6_EL2); - case 7: return READ_SYSREG(ICH_LR7_EL2); - case 8: return READ_SYSREG(ICH_LR8_EL2); - case 9: return READ_SYSREG(ICH_LR9_EL2); - case 10: return READ_SYSREG(ICH_LR10_EL2); - case 11: return READ_SYSREG(ICH_LR11_EL2); - case 12: return READ_SYSREG(ICH_LR12_EL2); - case 13: return READ_SYSREG(ICH_LR13_EL2); - case 14: return READ_SYSREG(ICH_LR14_EL2); - case 15: return READ_SYSREG(ICH_LR15_EL2); + case 0: return READ_SYSREG_LR(0); + case 1: return READ_SYSREG_LR(1); + case 2: return READ_SYSREG_LR(2); + case 3: return READ_SYSREG_LR(3); + case 4: return READ_SYSREG_LR(4); + case 5: return READ_SYSREG_LR(5); + case 6: return READ_SYSREG_LR(6); + case 7: return READ_SYSREG_LR(7); + case 8: return READ_SYSREG_LR(8); + case 9: return READ_SYSREG_LR(9); + case 10: return READ_SYSREG_LR(10); + case 11: return READ_SYSREG_LR(11); + case 12: return READ_SYSREG_LR(12); + case 13: return READ_SYSREG_LR(13); + case 14: return READ_SYSREG_LR(14); + case 15: return READ_SYSREG_LR(15); default: BUG(); } @@ -187,52 +187,52 @@ static void gicv3_ich_write_lr(int lr, uint64_t val) switch ( lr ) { case 0: - WRITE_SYSREG(val, ICH_LR0_EL2); + WRITE_SYSREG_LR(val, 0); break; case 1: - WRITE_SYSREG(val, ICH_LR1_EL2); + WRITE_SYSREG_LR(val, 1); break; case 2: - WRITE_SYSREG(val, ICH_LR2_EL2); + WRITE_SYSREG_LR(val, 2); break; case 3: - WRITE_SYSREG(val, ICH_LR3_EL2); + WRITE_SYSREG_LR(val, 3); break; case 4: - WRITE_SYSREG(val, ICH_LR4_EL2); + WRITE_SYSREG_LR(val, 4); break; case 5: - WRITE_SYSREG(val, ICH_LR5_EL2); + WRITE_SYSREG_LR(val, 5); break; case 6: - WRITE_SYSREG(val, ICH_LR6_EL2); + WRITE_SYSREG_LR(val, 6); break; case 7: - WRITE_SYSREG(val, ICH_LR7_EL2); + WRITE_SYSREG_LR(val, 7); break; case 8: - WRITE_SYSREG(val, ICH_LR8_EL2); + WRITE_SYSREG_LR(val, 8); break; case 9: - WRITE_SYSREG(val, ICH_LR9_EL2); + WRITE_SYSREG_LR(val, 9); break; case 10: - WRITE_SYSREG(val, ICH_LR10_EL2); + WRITE_SYSREG_LR(val, 10); break; case 11: - WRITE_SYSREG(val, ICH_LR11_EL2); + WRITE_SYSREG_LR(val, 11); break; case 12: - WRITE_SYSREG(val, ICH_LR12_EL2); + WRITE_SYSREG_LR(val, 12); break; case 13: - WRITE_SYSREG(val, ICH_LR13_EL2); + WRITE_SYSREG_LR(val, 13); break; case 14: - WRITE_SYSREG(val, ICH_LR14_EL2); + WRITE_SYSREG_LR(val, 14); break; case 15: - WRITE_SYSREG(val, ICH_LR15_EL2); + WRITE_SYSREG_LR(val, 15); break; default: return; @@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v) if ( v == current ) { for ( i = 0; i < gicv3_info.nr_lrs; i++ ) - printk(" HW_LR[%d]=%lx\n", i, gicv3_ich_read_lr(i)); + printk(" HW_LR[%d]=%" PRIx64 "\n", i, gicv3_ich_read_lr(i)); } else { for ( i = 0; i < gicv3_info.nr_lrs; i++ ) - printk(" VCPU_LR[%d]=%lx\n", i, v->arch.gic.v3.lr[i]); + printk(" VCPU_LR[%d]=%" PRIx64 "\n", i, v->arch.gic.v3.lr[i]); } } diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h index 6841d5de43..22871999af 100644 --- a/xen/arch/arm/include/asm/arm32/sysregs.h +++ b/xen/arch/arm/include/asm/arm32/sysregs.h @@ -62,6 +62,25 @@ #define READ_SYSREG(R...) READ_SYSREG32(R) #define WRITE_SYSREG(V, R...) WRITE_SYSREG32(V, R) +/* Wrappers for accessing interrupt controller list registers. */ +#define ICH_LR_REG(index) ICH_LR ## index ## _EL2 +#define ICH_LRC_REG(index) ICH_LRC ## index ## _EL2 + +#define READ_SYSREG_LR(index) ({ \ + uint64_t _val; \ + uint32_t _lrc = READ_CP32(ICH_LRC_REG(index)); \ + uint32_t _lr = READ_CP32(ICH_LR_REG(index)); \ + \ + _val = ((uint64_t) _lrc << 32) | _lr; \ + _val; \ +}) + +#define WRITE_SYSREG_LR(v, index) ({ \ + uint64_t _val = (v); \ + WRITE_CP32(_val & GENMASK(31, 0), ICH_LR_REG(index)); \ + WRITE_CP32(_val >> 32, ICH_LRC_REG(index)); \ +}) + /* MVFR2 is not defined on ARMv7 */ #define MVFR2_MAYBE_UNDEFINED diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index 54670084c3..4638999514 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -472,6 +472,11 @@ #define READ_SYSREG(name) READ_SYSREG64(name) #define WRITE_SYSREG(v, name) WRITE_SYSREG64(v, name) +/* Wrappers for accessing interrupt controller list registers. */ +#define ICH_LR_REG(index) ICH_LR ## index ## _EL2 +#define WRITE_SYSREG_LR(v, index) WRITE_SYSREG(v, ICH_LR_REG(index)) +#define READ_SYSREG_LR(index) READ_SYSREG(ICH_LR_REG(index)) + #endif /* _ASM_ARM_ARM64_SYSREGS_H */ /* diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h index 6daf2b1a30..b85e811f51 100644 --- a/xen/arch/arm/include/asm/cpregs.h +++ b/xen/arch/arm/include/asm/cpregs.h @@ -8,6 +8,8 @@ * support 32-bit guests. */ +#define ___CP32(coproc, opc1, crn, crm, opc2) coproc, opc1, crn, crm, opc2 + #define __HSR_CPREG_c0 0 #define __HSR_CPREG_c1 1 #define __HSR_CPREG_c2 2 @@ -259,6 +261,48 @@ #define VBAR p15,0,c12,c0,0 /* Vector Base Address Register */ #define HVBAR p15,4,c12,c0,0 /* Hyp. Vector Base Address Register */ +/* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ +#define __LR0(x) ___CP32(p15, 4, c12, c12, x) +#define __LR8(x) ___CP32(p15, 4, c12, c13, x) + +#define ICH_LR0 __LR0(0) +#define ICH_LR1 __LR0(1) +#define ICH_LR2 __LR0(2) +#define ICH_LR3 __LR0(3) +#define ICH_LR4 __LR0(4) +#define ICH_LR5 __LR0(5) +#define ICH_LR6 __LR0(6) +#define ICH_LR7 __LR0(7) +#define ICH_LR8 __LR8(0) +#define ICH_LR9 __LR8(1) +#define ICH_LR10 __LR8(2) +#define ICH_LR11 __LR8(3) +#define ICH_LR12 __LR8(4) +#define ICH_LR13 __LR8(5) +#define ICH_LR14 __LR8(6) +#define ICH_LR15 __LR8(7) + +/* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ +#define __LRC0(x) ___CP32(p15, 4, c12, c14, x) +#define __LRC8(x) ___CP32(p15, 4, c12, c15, x) + +#define ICH_LRC0 __LRC0(0) +#define ICH_LRC1 __LRC0(1) +#define ICH_LRC2 __LRC0(2) +#define ICH_LRC3 __LRC0(3) +#define ICH_LRC4 __LRC0(4) +#define ICH_LRC5 __LRC0(5) +#define ICH_LRC6 __LRC0(6) +#define ICH_LRC7 __LRC0(7) +#define ICH_LRC8 __LRC8(0) +#define ICH_LRC9 __LRC8(1) +#define ICH_LRC10 __LRC8(2) +#define ICH_LRC11 __LRC8(3) +#define ICH_LRC12 __LRC8(4) +#define ICH_LRC13 __LRC8(5) +#define ICH_LRC14 __LRC8(6) +#define ICH_LRC15 __LRC8(7) + /* CP15 CR13: */ #define FCSEIDR p15,0,c13,c0,0 /* FCSE Process ID Register */ #define CONTEXTIDR p15,0,c13,c0,1 /* Context ID Register */ @@ -317,6 +361,38 @@ #define HCR_EL2 HCR #define HPFAR_EL2 HPFAR #define HSTR_EL2 HSTR +#define ICH_LR0_EL2 ICH_LR0 +#define ICH_LR1_EL2 ICH_LR1 +#define ICH_LR2_EL2 ICH_LR2 +#define ICH_LR3_EL2 ICH_LR3 +#define ICH_LR4_EL2 ICH_LR4 +#define ICH_LR5_EL2 ICH_LR5 +#define ICH_LR6_EL2 ICH_LR6 +#define ICH_LR7_EL2 ICH_LR7 +#define ICH_LR8_EL2 ICH_LR8 +#define ICH_LR9_EL2 ICH_LR9 +#define ICH_LR10_EL2 ICH_LR10 +#define ICH_LR11_EL2 ICH_LR11 +#define ICH_LR12_EL2 ICH_LR12 +#define ICH_LR13_EL2 ICH_LR13 +#define ICH_LR14_EL2 ICH_LR14 +#define ICH_LR15_EL2 ICH_LR15 +#define ICH_LRC0_EL2 ICH_LRC0 +#define ICH_LRC1_EL2 ICH_LRC1 +#define ICH_LRC2_EL2 ICH_LRC2 +#define ICH_LRC3_EL2 ICH_LRC3 +#define ICH_LRC4_EL2 ICH_LRC4 +#define ICH_LRC5_EL2 ICH_LRC5 +#define ICH_LRC6_EL2 ICH_LRC6 +#define ICH_LRC7_EL2 ICH_LRC7 +#define ICH_LRC8_EL2 ICH_LRC8 +#define ICH_LRC9_EL2 ICH_LRC9 +#define ICH_LRC10_EL2 ICH_LRC10 +#define ICH_LRC11_EL2 ICH_LRC11 +#define ICH_LRC12_EL2 ICH_LRC12 +#define ICH_LRC13_EL2 ICH_LRC13 +#define ICH_LRC14_EL2 ICH_LRC14 +#define ICH_LRC15_EL2 ICH_LRC15 #define ID_AFR0_EL1 ID_AFR0 #define ID_DFR0_EL1 ID_DFR0 #define ID_DFR1_EL1 ID_DFR1 diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h index 48a1bc401e..227533868f 100644 --- a/xen/arch/arm/include/asm/gic_v3_defs.h +++ b/xen/arch/arm/include/asm/gic_v3_defs.h @@ -185,9 +185,9 @@ #define ICH_LR_HW_SHIFT 61 #define ICH_LR_GRP_MASK 0x1 #define ICH_LR_GRP_SHIFT 60 -#define ICH_LR_MAINTENANCE_IRQ (1UL<<41) -#define ICH_LR_GRP1 (1UL<<60) -#define ICH_LR_HW (1UL<<61) +#define ICH_LR_MAINTENANCE_IRQ (1ULL << 41) +#define ICH_LR_GRP1 (1ULL << 60) +#define ICH_LR_HW (1ULL << 61) #define ICH_VTR_NRLRGS 0x3f #define ICH_VTR_PRIBITS_MASK 0x7 @@ -195,7 +195,7 @@ #define ICH_SGI_IRQMODE_SHIFT 40 #define ICH_SGI_IRQMODE_MASK 0x1 -#define ICH_SGI_TARGET_OTHERS 1UL +#define ICH_SGI_TARGET_OTHERS 1ULL #define ICH_SGI_TARGET_LIST 0 #define ICH_SGI_IRQ_SHIFT 24 #define ICH_SGI_IRQ_MASK 0xf -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 15:57:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 15:57:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449028.705679 (Exim 4.92) (envelope-from ) id 1ozgW2-0007AX-CA; Mon, 28 Nov 2022 15:57:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449028.705679; Mon, 28 Nov 2022 15:57:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgW2-0007A3-6y; Mon, 28 Nov 2022 15:57:54 +0000 Received: by outflank-mailman (input) for mailman id 449028; Mon, 28 Nov 2022 15:57:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgW0-0004G7-SA for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:57:52 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2060e.outbound.protection.outlook.com [2a01:111:f400:7e8b::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 68e0ab10-6f35-11ed-8fd2-01056ac49cbb; Mon, 28 Nov 2022 16:57:51 +0100 (CET) Received: from DM6PR21CA0017.namprd21.prod.outlook.com (2603:10b6:5:174::27) by SN7PR12MB7323.namprd12.prod.outlook.com (2603:10b6:806:29a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20; Mon, 28 Nov 2022 15:57:48 +0000 Received: from DM6NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:5:174:cafe::54) by DM6PR21CA0017.outlook.office365.com (2603:10b6:5:174::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5901.4 via Frontend Transport; Mon, 28 Nov 2022 15:57:48 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT047.mail.protection.outlook.com (10.13.172.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Mon, 28 Nov 2022 15:57:48 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 09:57:46 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 07:57:46 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 28 Nov 2022 09:57:44 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68e0ab10-6f35-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W22UNKO+lEQXdJvV4GbP4053myOO2XZCejyw5f2Mb614NkAmikR3y9FLXMheL8FwLXd+Q0ZBY2adokDSCbdDm0UR0IQ6JTZkpyYXl8gyifnLjg6FRrt1/tKo8gmVVmsFtlL0OI/RfsSh/6dxyNM8pqQloUOQo3fPTcS4BIVfVZlscYy197WLBIwgZikI8esOQHylUtAfJmmeJp19PTPSRkgjwJAdV/kWgMLhWabuo5TYG5qarQ+OT/gXqYsgJVKNcwq+oANqcByPEJh8/E+kFgF2XgafDkK9UsefmAYqCAfv/anoWaN3dGmaVFOfl/RBLbm7zu3l5Fvos+Ej5uzS4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xXnNv0uq417LusaPBljoTxWq5WZtI/zUljXoSS1VcT4=; b=RvvBot81qoceXPJfEyG5KRnK4fFwGt42T10RYfT5C2dYKwLzghlecAo2c9tgCB5C8WRNuYHcRDFtEXLO4DPVpv+oEvnQlFchFLIS6smm4gm+gfAKWgjsUlLGnzdgJOWqtbktqS0I4CmN7b3CLzu/OOrsJXzWhSOBMW8t1icvqnEKYhbKyjP6AJ0T8XTpahIc1YnqTy5L5mOdtZrXqEYhjNbfNGUn+H6JxnmC4c3a2awepXkVTk1oRGNhmdtiPRJZhzqiQAhce8hB8P2CC+fcTi8SZZdDI6FPpCbtqFE2QqXvBPj+1WOBiCwAJxebLaSVwh5f4qMDBg9r9C2weeCo0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xXnNv0uq417LusaPBljoTxWq5WZtI/zUljXoSS1VcT4=; b=3A0G3pEd/FWUW1v4c4dL3bQnEuf3LfZff8plqVsqW1sqhY3/U/ismjYwnyt52/9jwD/h+XHmMkuNkPyrqHlMyovrpEsCzcFh7Fe+Jad921loOceJvmjAa68zK7ibGasEA7mOIXi6n2EoG7APAM6FAeVmeAAzEVku5A/2gLIGXf0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v4 08/11] xen/Arm: GICv3: Define ICH_AP0R and ICH_AP1R for AArch32 Date: Mon, 28 Nov 2022 15:56:46 +0000 Message-ID: <20221128155649.31386-9-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128155649.31386-1-ayan.kumar.halder@amd.com> References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT047:EE_|SN7PR12MB7323:EE_ X-MS-Office365-Filtering-Correlation-Id: e9f2c3dc-42c3-4294-c6b6-08dad1594bdc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nvCOKBzCKPd6ZzslOWu4w156Zz/Pq34kLO5cZPyLe45p6aVZ1s3QjVmkq5+oc2PBDKi45d1JDIrmnQnAU7XKIQjA7oH7wh1NYkuFPtu1RcSG/gpu2CE4AIVetc+Hcg8LzdgVkewtQ1ee0AB45E2vWVeAAqa4CYcYpHrpj+FecbwXsNuVtve8jKOqeG0Qkl2YeJ7ERXXEBVFy/F96r+NQad98SKlZqv/YRgr9OZ293D3ADOAbU3RFvT3MTQB918v7blWalIPLDYo2P1gDROltHXdL02DeRcKun3NuNi1uABrGfWg3UfSCO4XSb76YszMz6eranQ8IBbLnnk2t5XKLP09JD3fvC7mWImdbb85YJZUePUSyILOuX9CfaJTJgpZBeX0IjdJJG7b5Xg7CHwt9IOVnKF7kaxKAp8NmgZtMSGwOP7OTXbnHNmoUya4DsZ3GwTIAXocEplMzYlGlso9mfjJ4JtEYEXXwQCcHPu5pmI7TYOVvkRk+YyQHnQZ7hnQUTi2TjsDRtHAPlGtZj7pLFL3qng++FKh/91gNZ173l2FJnq2h103IJlSvwtATTON5NRyuU50z7xKBJqxbPP7xvid+k6u4o3WffH8kfBTJi8xBjV1TkS6zmRQlvIfkGxy2OaC0e/VOkFMXIesijrFWzg1ruaWqpYeXwtlVMFVGEgqGQbXfWmOF/azhzTUX8TitDdw3Xl6vUNGdG3MBR0leXM07iIycqFauJwwWPx9My0k= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(39860400002)(346002)(451199015)(46966006)(40470700004)(36840700001)(2906002)(316002)(478600001)(186003)(336012)(36756003)(86362001)(4326008)(47076005)(426003)(8676002)(70206006)(83380400001)(70586007)(26005)(1076003)(2616005)(40460700003)(6916009)(54906003)(40480700001)(36860700001)(103116003)(41300700001)(8936002)(356005)(5660300002)(82740400003)(82310400005)(81166007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 15:57:48.0463 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9f2c3dc-42c3-4294-c6b6-08dad1594bdc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7323 Adapt save_aprn_regs()/restore_aprn_regs() for AArch32. For which we have defined the following registers:- 1. Interrupt Controller Hyp Active Priorities Group0 Registers 0-3 2. Interrupt Controller Hyp Active Priorities Group1 Registers 0-3 Signed-off-by: Ayan Kumar Halder --- Changes from :- v1 - 1. Moved coproc register definition to asm/cpregs.h. v2 - 1. Defined register alias. 2. Style issues. 3. Dropped R-b and Ack. v3 - 1. Style issues. xen/arch/arm/include/asm/cpregs.h | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h index b85e811f51..53142fc2b2 100644 --- a/xen/arch/arm/include/asm/cpregs.h +++ b/xen/arch/arm/include/asm/cpregs.h @@ -261,6 +261,26 @@ #define VBAR p15,0,c12,c0,0 /* Vector Base Address Register */ #define HVBAR p15,4,c12,c0,0 /* Hyp. Vector Base Address Register */ +/* + * CP15 CR12: Interrupt Controller Hyp Active Priorities Group 0 Registers, + * n = 0 - 3 + */ +#define __AP0Rx(x) ___CP32(p15, 4, c12, c8, x) +#define ICH_AP0R0 __AP0Rx(0) +#define ICH_AP0R1 __AP0Rx(1) +#define ICH_AP0R2 __AP0Rx(2) +#define ICH_AP0R3 __AP0Rx(3) + +/* + * CP15 CR12: Interrupt Controller Hyp Active Priorities Group 1 Registers, + * n = 0 - 3 + */ +#define __AP1Rx(x) ___CP32(p15, 4, c12, c9, x) +#define ICH_AP1R0 __AP1Rx(0) +#define ICH_AP1R1 __AP1Rx(1) +#define ICH_AP1R2 __AP1Rx(2) +#define ICH_AP1R3 __AP1Rx(3) + /* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ #define __LR0(x) ___CP32(p15, 4, c12, c12, x) #define __LR8(x) ___CP32(p15, 4, c12, c13, x) @@ -361,6 +381,14 @@ #define HCR_EL2 HCR #define HPFAR_EL2 HPFAR #define HSTR_EL2 HSTR +#define ICH_AP0R0_EL2 ICH_AP0R0 +#define ICH_AP0R1_EL2 ICH_AP0R1 +#define ICH_AP0R2_EL2 ICH_AP0R2 +#define ICH_AP0R3_EL2 ICH_AP0R3 +#define ICH_AP1R0_EL2 ICH_AP1R0 +#define ICH_AP1R1_EL2 ICH_AP1R1 +#define ICH_AP1R2_EL2 ICH_AP1R2 +#define ICH_AP1R3_EL2 ICH_AP1R3 #define ICH_LR0_EL2 ICH_LR0 #define ICH_LR1_EL2 ICH_LR1 #define ICH_LR2_EL2 ICH_LR2 -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 16:00:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 16:00:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449037.705696 (Exim 4.92) (envelope-from ) id 1ozgYW-00026Y-VG; Mon, 28 Nov 2022 16:00:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449037.705696; Mon, 28 Nov 2022 16:00:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgYW-00026R-R9; Mon, 28 Nov 2022 16:00:28 +0000 Received: by outflank-mailman (input) for mailman id 449037; Mon, 28 Nov 2022 16:00:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgWM-00040T-6l for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:58:14 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2060a.outbound.protection.outlook.com [2a01:111:f400:7ea9::60a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75c23569-6f35-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 16:58:13 +0100 (CET) Received: from DS7PR03CA0259.namprd03.prod.outlook.com (2603:10b6:5:3b3::24) by MW4PR12MB6875.namprd12.prod.outlook.com (2603:10b6:303:209::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 15:58:09 +0000 Received: from DM6NAM11FT039.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b3:cafe::db) by DS7PR03CA0259.outlook.office365.com (2603:10b6:5:3b3::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Mon, 28 Nov 2022 15:58:09 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT039.mail.protection.outlook.com (10.13.172.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.21 via Frontend Transport; Mon, 28 Nov 2022 15:58:09 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 09:58:08 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 07:57:51 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 28 Nov 2022 09:57:50 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75c23569-6f35-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M9T7F/LPlkDIczrp4r1Twm2rL8KTGKdaDFmpb0xF+rvZ99oNzq5jDtNop41T71tOSoDHenxZY+psqjqxqTiTFlFY4YkbUHclqJTwHHnq5ZPSxcIMcnLsP0byAlEZMbyrYWPVRBjzmTDyGuqTm8zPgNo3Q4aASPBokWjxfFGdH2DM3aHDnEFDsugFo3DDmrC2PsN6fGQt1E3VwaAgDC4LliYJhhJC60F8sFARb7hxDYhYq8rW6M4okwDh7wnGyd7leSxJmAPaKcXo/BvCmTeWh+q5rrqKJ9TquF2ag19BqaBVGcLNib+PGzpOREbF4DM0m3KPrafOIVf7NGOzw4890g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=emU0se7BL8VL+/8A4ZCKzlHP38dBgxnJ4wo1YN4RDW0=; b=Zlz+1hQAClhKGtHM5C2H5548SmvYKr2+ewwC+3D9EuFVgmjiZ5LCzp8JCV+RAawoxNfDff+1/deZGXLJTIXpTP6wuBgw5/oi0uy/9T//2gIAlbWFMshvHWp1y3VuculwRZ/GlYqdy9d2mFWsCTxjqMY5BeAAGdlT5Jc2IZQXyAk66kfUuN4qF5yAAjg/+h1cvOpNpm7OwRTw2Cmu3mJEnxjnvdhvDtbkBa3zafpkV6F5KiKR/oDRNxz6pyz1tRlbWm9ysqFpzTe4gAQy1F4jQ8sfyr6pwApMa8lk+jVUwVGAvzfuf2aEtPUS6mHis2oH8Ot2P4tTZk6Zg5eqaBD9qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=emU0se7BL8VL+/8A4ZCKzlHP38dBgxnJ4wo1YN4RDW0=; b=CJJzdqGbc/Xm0bWnGq9EbL/einXisqvImRDQ06/C17HhTkhmpG8Wr7iDYAIkd+4gU/KgW/AT+X165IE1wJUsRz3tN3Era9BhOSqv2Z34vwhQ4tbeEKnUefNTNVBN69YhlVwDINVNqPpj+UfXLIWuxPhbn/1j2F1L2j8wybMNN/0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v4 10/11] xen/Arm: GICv3: Define macros to read/write 64 bit Date: Mon, 28 Nov 2022 15:56:48 +0000 Message-ID: <20221128155649.31386-11-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128155649.31386-1-ayan.kumar.halder@amd.com> References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT039:EE_|MW4PR12MB6875:EE_ X-MS-Office365-Filtering-Correlation-Id: ef5bff14-7f5c-48a2-f3e6-08dad1595883 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DKXfLxXkqbF0CyPyN0I7j0KzRM0AB8MPdalhWzqhtMCdfjGFWlB1OBz9v12B8eEtlga58RVd6H+TnhPZJWZCLewMF90uRuFPJIrW64Vy/8rFj2tKRvHsnAhow/hLo3SLhvziHfCyEZ49uFgOH4JQchwA53ByT11rfHn+SM7KXWJDLpWz0GL8VFfoB834I3n7XN0AX98UQbW8EFy2KnQpDW1Yme9wVP02N4efozl47/C62fWySjYRZt7JX1rYEr8UIyMPK8msX9TjQnFd0hyL/sW8xbCYVo6fdPPLQCOub93h/LuvK4yWu/MpksvX4RhZ0oZhEeyZVHFGJEYXEiptIR1Hs2rEkWJM3bmqYbwrq7Ox3lzglD7E9tmn+a78dCjV8elMOjpR4VgPln+6kHzGbuV2Tx66kzCupaIQ3xrs2AZ92GWOK9uDP3roMZLdahBR1n2m4v0MR7DSneZvR7svFgZ9tiuorH/srT3z4y1XQdQrakTNYY8RfrqPuCfBubU8B/pjKyhvK03OPLrgKhInIvAslf9DDx99PJMqUn4/D76Ol9LiOGtKA0DZ141gvtVVf9YKabFYkQY1gk+c73NW4abFnKMYvbCmdx3KZ6I66uiESgnQ2QXh/cph//lMEcZ78hVhCX0RoJD8C0qEsDXSN9VnZxJGZMP/Zf0lxpXdqgo9EM5PBFQqce/0BkEcl5Ss1073Qnsi+eRAXImA9/1uz6ukCJZUd41F885uaIZQuXw= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(396003)(346002)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(2906002)(8936002)(36860700001)(82740400003)(70206006)(40480700001)(8676002)(40460700003)(4326008)(103116003)(86362001)(36756003)(81166007)(186003)(82310400005)(316002)(336012)(426003)(356005)(1076003)(5660300002)(83380400001)(54906003)(6916009)(41300700001)(47076005)(26005)(70586007)(2616005)(478600001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 15:58:09.2902 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef5bff14-7f5c-48a2-f3e6-08dad1595883 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT039.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6875 On AArch32, ldrd/strd instructions are not atomic when used to access MMIO. Furthermore, ldrd/strd instructions are not decoded by Arm when running as a guest to access emulated MMIO region. Thus, we have defined readq_relaxed_non_atomic()/writeq_relaxed_non_atomic() which in turn calls readl_relaxed()/writel_relaxed() for the lower and upper 32 bits. For AArch64, readq_relaxed_non_atomic()/writeq_relaxed_non_atomic() invokes readq_relaxed()/writeq_relaxed() respectively. As GICv3 registers (GICD_IROUTER, GICR_TYPER) can be accessed in a non atomic manner, so we have used readq_relaxed_non_atomic()/writeq_relaxed_non_atomic(). Signed-off-by: Ayan Kumar Halder --- Changes from :- v1 - 1. Use ldrd/strd for readq_relaxed()/writeq_relaxed(). 2. No need to use le64_to_cpu() as the returned byte order is already in cpu endianess. v2 - 1. Replace {read/write}q_relaxed with {read/write}q_relaxed_non_atomic(). v3 - 1. Use inline function definitions for {read/write}q_relaxed_non_atomic(). 2. For AArch64, {read/write}q_relaxed_non_atomic() should invoke {read/write}q_relaxed(). Thus, we can avoid any ifdef in gic-v3.c. xen/arch/arm/gic-v3.c | 6 +++--- xen/arch/arm/include/asm/arm32/io.h | 20 ++++++++++++++++++++ xen/arch/arm/include/asm/arm64/io.h | 2 ++ 3 files changed, 25 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 6457e7033c..3c5b88148c 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -651,7 +651,7 @@ static void __init gicv3_dist_init(void) affinity &= ~GICD_IROUTER_SPI_MODE_ANY; for ( i = NR_GIC_LOCAL_IRQS; i < nr_lines; i++ ) - writeq_relaxed(affinity, GICD + GICD_IROUTER + i * 8); + writeq_relaxed_non_atomic(affinity, GICD + GICD_IROUTER + i * 8); } static int gicv3_enable_redist(void) @@ -745,7 +745,7 @@ static int __init gicv3_populate_rdist(void) } do { - typer = readq_relaxed(ptr + GICR_TYPER); + typer = readq_relaxed_non_atomic(ptr + GICR_TYPER); if ( (typer >> 32) == aff ) { @@ -1265,7 +1265,7 @@ static void gicv3_irq_set_affinity(struct irq_desc *desc, const cpumask_t *mask) affinity &= ~GICD_IROUTER_SPI_MODE_ANY; if ( desc->irq >= NR_GIC_LOCAL_IRQS ) - writeq_relaxed(affinity, (GICD + GICD_IROUTER + desc->irq * 8)); + writeq_relaxed_non_atomic(affinity, (GICD + GICD_IROUTER + desc->irq * 8)); spin_unlock(&gicv3.lock); } diff --git a/xen/arch/arm/include/asm/arm32/io.h b/xen/arch/arm/include/asm/arm32/io.h index 73a879e9fb..782b564809 100644 --- a/xen/arch/arm/include/asm/arm32/io.h +++ b/xen/arch/arm/include/asm/arm32/io.h @@ -80,10 +80,30 @@ static inline u32 __raw_readl(const volatile void __iomem *addr) __raw_readw(c)); __r; }) #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \ __raw_readl(c)); __r; }) +/* + * ldrd instructions are not decoded by Arm when running as a guest to access + * emulated MMIO region. Thus, readq_relaxed_non_atomic() invokes readl_relaxed() + * twice to read the lower and upper 32 bits. + */ +static inline u64 readq_relaxed_non_atomic(const volatile void __iomem *addr) +{ + u64 val = (((u64)readl_relaxed(addr + 4)) << 32) | readl_relaxed(addr); + return val; +} #define writeb_relaxed(v,c) __raw_writeb(v,c) #define writew_relaxed(v,c) __raw_writew((__force u16) cpu_to_le16(v),c) #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c) +/* + * strd instructions are not decoded by Arm when running as a guest to access + * emulated MMIO region. Thus, writeq_relaxed_non_atomic() invokes writel_relaxed() + * twice to write the lower and upper 32 bits. + */ +static inline void writeq_relaxed_non_atomic(u64 val, volatile void __iomem *addr) +{ + writel_relaxed((u32)val, addr); + writel_relaxed((u32)(val >> 32), addr + 4); +} #define readb(c) ({ u8 __v = readb_relaxed(c); __iormb(); __v; }) #define readw(c) ({ u16 __v = readw_relaxed(c); __iormb(); __v; }) diff --git a/xen/arch/arm/include/asm/arm64/io.h b/xen/arch/arm/include/asm/arm64/io.h index 30bfc78d9e..2e2ab24f78 100644 --- a/xen/arch/arm/include/asm/arm64/io.h +++ b/xen/arch/arm/include/asm/arm64/io.h @@ -102,11 +102,13 @@ static inline u64 __raw_readq(const volatile void __iomem *addr) #define readw_relaxed(c) ({ u16 __v = le16_to_cpu((__force __le16)__raw_readw(c)); __v; }) #define readl_relaxed(c) ({ u32 __v = le32_to_cpu((__force __le32)__raw_readl(c)); __v; }) #define readq_relaxed(c) ({ u64 __v = le64_to_cpu((__force __le64)__raw_readq(c)); __v; }) +#define readq_relaxed_non_atomic(c) readq_relaxed((c)) #define writeb_relaxed(v,c) ((void)__raw_writeb((v),(c))) #define writew_relaxed(v,c) ((void)__raw_writew((__force u16)cpu_to_le16(v),(c))) #define writel_relaxed(v,c) ((void)__raw_writel((__force u32)cpu_to_le32(v),(c))) #define writeq_relaxed(v,c) ((void)__raw_writeq((__force u64)cpu_to_le64(v),(c))) +#define writeq_relaxed_non_atomic(v,c) writeq_relaxed((v),(c)) /* * I/O memory access primitives. Reads are ordered relative to any -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 16:01:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 16:01:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449050.705707 (Exim 4.92) (envelope-from ) id 1ozgZv-0002mD-BE; Mon, 28 Nov 2022 16:01:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449050.705707; Mon, 28 Nov 2022 16:01:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgZv-0002m6-6o; Mon, 28 Nov 2022 16:01:55 +0000 Received: by outflank-mailman (input) for mailman id 449050; Mon, 28 Nov 2022 16:01:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgWP-0004G7-El for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:58:17 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20622.outbound.protection.outlook.com [2a01:111:f400:fe5b::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 77f06e64-6f35-11ed-8fd2-01056ac49cbb; Mon, 28 Nov 2022 16:58:16 +0100 (CET) Received: from BN0PR02CA0037.namprd02.prod.outlook.com (2603:10b6:408:e5::12) by PH7PR12MB6763.namprd12.prod.outlook.com (2603:10b6:510:1ad::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 15:58:12 +0000 Received: from BN8NAM11FT039.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e5:cafe::3) by BN0PR02CA0037.outlook.office365.com (2603:10b6:408:e5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Mon, 28 Nov 2022 15:58:12 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT039.mail.protection.outlook.com (10.13.177.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.17 via Frontend Transport; Mon, 28 Nov 2022 15:58:12 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 09:58:09 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 07:57:56 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 28 Nov 2022 09:57:55 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77f06e64-6f35-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jW2Q9cKs+jrPVKxBDKZpd6DzqaPd+QRczDXCiI/PY036uNmX9sk2Pr3ilzyzGUal0pQ6PQTgKMu8eUqHaRvxFKb01fOKjRKoPn5vSN3fj0hThcPMWX02+jdoNRlwi9RH1DRq49tKx/Yn4jjz6bZ2ofbDuByA//0nxigctTvU+4qGquTCRwVG+e4sdrUg/27mqFWQGPt8QRV+6Lr2qvRzdU6ntL2LvLzWOJdRpuWw46ImmduVXGE0smf6YV0eKrXxVvu0ETArzU0LwSQ99DtLh100G7SM81TFIWhlPiv815gxwHDrrBDlez11kk4OcKlxKWerhuJuTDf5YleHPagZ3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nyGm/Jre0Q1vTiMJDNnpqCY6vDpCkDbPz7cU2mXLLdo=; b=XrSh6C9r5TBelA0jZX/LbwHAznBWqqJkSk+/RfL27TNTapmwPSTd97hpZVKZNYzTZ3kRwbzpXtSyra1J6P/ZR/9gQE1h4bW1Swx6rIfl7bBl4yDtoWLJzxMolV7YgwnyVSBXZZuopiNSA/2FNcPbSRhPEvfEFT09qL2FKaJfS9q+5NOv8f8eIgiHf/w1Lti216w3ELNIbAGu9S6MsLum2pogxqoR0hgpONTtesDgeABwTeWxhbiRVAmzYWsTpPsLkId/BK+Hgntj/907bO9XVhlxswa8WMpUofawUJ+ILn8h+ukUEV8nnwtsbYjloH/mRErJo1yCZXDLketOcKA7Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nyGm/Jre0Q1vTiMJDNnpqCY6vDpCkDbPz7cU2mXLLdo=; b=c7rnJGYlLXnQoZ5sHHqduup8LzaKj1Oyu9U8TggVQgFBP70zJ1K329zvtyoR667wg3u0G4oCtNsVzYWnEwr5YK1pqvR9dlGs62MNlvMsovbyAjNqLhedXPB8Ez8Qy6j4SNrmM7BReleaAaKCY6b3zBl+xbBs4Hrdp43lkD64PuQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v4 11/11] xen/Arm: GICv3: Enable GICv3 for AArch32 Date: Mon, 28 Nov 2022 15:56:49 +0000 Message-ID: <20221128155649.31386-12-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128155649.31386-1-ayan.kumar.halder@amd.com> References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT039:EE_|PH7PR12MB6763:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f6de3ce-d86f-4be6-7ea7-08dad1595a2f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N3XnHb5ypUHskx86nuoIycheq9vw0svu0UNkbNi6VFVcaroOEWoJWZjnOgLE2fSiUaHB23XkTBDFp/XsE/Mzd8RlHrX3oOiiNr9c4LgjsY/2l/BolOkUqRNLpxSPffmNj79zBMMcJdMjqp7UhSOeVLS0R3+3AN4AbyEfzPu0vOwjndbJJ6/B/lD6u4ZX3C7TGtMtWYkjoyuDzo11CnezeIdQQyocTeY/kjVQkinWyf7kposbRoB3b9aP/shW9Sp+uKPPehbhWhI6CUo2n22U/t3BfQKApM7KdYiPmcloKfgE7Ybl+Pq+DgYNpRPCK3cT2lxsM3rRImwe8M1facZNQLwbemaVaMz7mlzWJykTMpcgcbo56uBOLmOhkA0n9lyzFR2KReJKsd1NRpx5rdVXHJDByRTLHdfj6TooJtJdLm8+K2XiBxXhl1tOKDyFkhWULGUL6Gsv+g7h77ZzXTtkyxYkv31IWtbc9YF/43E69io5Rm8+UUI5EwcsvQpVTY/KBhlyb4PPR2UCDjEHB+amsxhpJeazcDUabv9b4iNhtrIp10Jhp1MumJMYzZ0xO2HxaMBOtf9FkxMwbrHg6y1BDXdQOaxKBoKR8p0tTDx6gnZvCzOsB4jUrMQkz3mUM47YviD9wI2Ul8IhpozUADWMwuNW8gmCQZGZyAmpvWFVb6NYjO8bp6dTegF/cdmgPFpGcMmqXZQ8l5s5an1fdSbKEoxWp7yYrHY989XnZESX7r4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(396003)(376002)(451199015)(46966006)(40470700004)(36840700001)(36756003)(82740400003)(356005)(82310400005)(81166007)(40480700001)(26005)(478600001)(6666004)(41300700001)(70206006)(70586007)(8676002)(40460700003)(86362001)(4326008)(316002)(54906003)(6916009)(5660300002)(103116003)(8936002)(186003)(336012)(426003)(47076005)(2616005)(1076003)(83380400001)(36860700001)(2906002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 15:58:12.1234 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f6de3ce-d86f-4be6-7ea7-08dad1595a2f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT039.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6763 One can now use GICv3 on AArch32 systems. However, ITS is not supported. The reason being currently we are trying to validate GICv3 on an AArch32_v8R system. Refer ARM DDI 0568A.c ID110520, B1.3.1, "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE must not implement LPI support." By default GICv3 is disabled on AArch32 and enabled on AArch64. Updated SUPPORT.md to state that GICv3 on Arm32 is not security supported. Signed-off-by: Ayan Kumar Halder --- Changed from :- v1 - 1. Remove "ARM_64 || ARM_32" as it is always true. 2. Updated SUPPORT.md. v2 - 1. GICv3 is enabled by default only on ARM_64. 2. Updated SUPPORT.md. v3 - 1. GICv3 is not selected by ARM_64. Rather, it is optionally enabled. 2. GICv3 is disabled by default on ARM_32. SUPPORT.md | 7 +++++++ xen/arch/arm/Kconfig | 9 +++++---- xen/arch/arm/include/asm/cpufeature.h | 1 + 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/SUPPORT.md b/SUPPORT.md index ab71464cf6..295369998e 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -76,6 +76,13 @@ For the Cortex A57 r0p0 - r1p1, see Errata 832075. Status, ARM SMMUv3: Tech Preview Status, Renesas IPMMU-VMSA: Supported, not security supported +### ARM/GICv3 + +GICv3 is an interrupt controller specification designed by Arm. + + Status, Arm64: Security supported + Status, Arm32: Supported, not security supported + ### ARM/GICv3 ITS Extension to the GICv3 interrupt controller to support MSI. diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 52a05f704d..9d0c45f892 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -41,16 +41,17 @@ config ARM_EFI config GICV3 bool "GICv3 driver" - depends on ARM_64 && !NEW_VGIC - default y + depends on !NEW_VGIC + default n if ARM_32 + default y if ARM_64 ---help--- Driver for the ARM Generic Interrupt Controller v3. - If unsure, say Y + If unsure, say N for ARM_32 and Y for ARM_64 config HAS_ITS bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED - depends on GICV3 && !NEW_VGIC + depends on GICV3 && !NEW_VGIC && !ARM_32 config HVM def_bool y diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h index c86a2e7f29..c62cf6293f 100644 --- a/xen/arch/arm/include/asm/cpufeature.h +++ b/xen/arch/arm/include/asm/cpufeature.h @@ -33,6 +33,7 @@ #define cpu_has_aarch32 (cpu_has_arm || cpu_has_thumb) #ifdef CONFIG_ARM_32 +#define cpu_has_gicv3 (boot_cpu_feature32(gic) >= 1) #define cpu_has_gentimer (boot_cpu_feature32(gentimer) == 1) /* * On Armv7, the value 0 is used to indicate that PMUv2 is not -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 16:03:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 16:03:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449063.705718 (Exim 4.92) (envelope-from ) id 1ozgbk-0003Sm-RM; Mon, 28 Nov 2022 16:03:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449063.705718; Mon, 28 Nov 2022 16:03:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgbk-0003Sf-NM; Mon, 28 Nov 2022 16:03:48 +0000 Received: by outflank-mailman (input) for mailman id 449063; Mon, 28 Nov 2022 16:03:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgW3-00040T-0R for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 15:57:55 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2061c.outbound.protection.outlook.com [2a01:111:f400:7e8c::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a1ff2a1-6f35-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 16:57:53 +0100 (CET) Received: from BN9PR03CA0365.namprd03.prod.outlook.com (2603:10b6:408:f7::10) by MN0PR12MB5858.namprd12.prod.outlook.com (2603:10b6:208:379::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 15:57:50 +0000 Received: from BN8NAM11FT110.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f7:cafe::5c) by BN9PR03CA0365.outlook.office365.com (2603:10b6:408:f7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Mon, 28 Nov 2022 15:57:49 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT110.mail.protection.outlook.com (10.13.176.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.17 via Frontend Transport; Mon, 28 Nov 2022 15:57:49 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 09:57:49 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 07:57:49 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 28 Nov 2022 09:57:47 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a1ff2a1-6f35-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C8cuTIvVdO6kD+1sPci9K92JgYlRCb5sAU6STs1IJLzDMlaqkh3yTRcCF4REi2DQiAl4WBK6mBl9JQ5kXgOCPL961nc7g0GhyXyq3ThJXPwvTWhV3iqewNVp0rMCuVuPm6nZo1JxXdHrElyxWNKq8r9DO8AsSX+kaS772CCtcCKMy85x4T8jQcWwNyosMIX3pDQWmubh5jzJA80LbY9PF8Q14EVDnskaKDJMAFQgXuDJybhyxUl7xUIDm+SajYj6F/XJ3beo/Y7AYJyzyeelJLCcgiQIZ9+av7DxBUR77oN4DS8uyyDnHtuFhNQwe7ICZgoaPx3sJCZJC68xOfwJlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4h0x9XQCxvEzC4QjfAxNWTYP+bl6E7uks7mQZY4p/RQ=; b=e0Yu+SGFYNH81peLAUVCmCN1yUDOmobxXV5S+J7cFHBm7DKey70OVDjOSTK8jJLmcZW03qQyVsydCI48kW+LdG3RnQ7u1L4ZKFRcUkjri5weMbPrCEnbPAAcnHJPgMDF1La/+0/1GTsuNA3aS6xbgyLKPVLPRdLxZ8jlbl8fpjp4yxvU4mskMcRbQ/Sqi1qTe+KpCUAfHDxTjdfCRNmGiUoyVzpF3O5Rirnq29bIST/uGtBghq0tPzYyI3BXRlaxFR+XTEzASXTtxF5QKPMIxpfiE1awE9Bq0ytYY/z29PoS5/slAsY7H4/EhVW1nN3X95VAwcv+040nCdlTK4fdSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4h0x9XQCxvEzC4QjfAxNWTYP+bl6E7uks7mQZY4p/RQ=; b=CtXa6RFB741zi+Pmp1Bm8fp9VyhslSvEDHcf8gIVdh/QyWPysYOt4ehljyQQlUXif+rU5F8oUKUOBYE1A+FsSKzCEcAa306zmPkc9VpUh6e8k3QhmDnbht6mZx1mKqk6gdFsqImM4RTF8WkpANuZ9nngCOAIslS/jt6+4M3NkaY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v4 09/11] xen/Arm: GICv3: Define remaining GIC registers for AArch32 Date: Mon, 28 Nov 2022 15:56:47 +0000 Message-ID: <20221128155649.31386-10-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128155649.31386-1-ayan.kumar.halder@amd.com> References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT110:EE_|MN0PR12MB5858:EE_ X-MS-Office365-Filtering-Correlation-Id: 36fa434f-7d6d-4c2b-4fa4-08dad1594cd7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: koI1ctxnp56Q6q2gVXnYDZ221J7xzH3mmIqel3xmhITZZkBKJSwJJ3iPNrl3jROvvEUPg2Q9CB0/js6wrZowDF4UvRfl9FZ7bbabYMPtAWvglxzztulAuo+2z6tlN2kqQWe0V0+U3SWewRGKwawF47h3BBkiIFBqKOCVN1jq+rNg2zjXZUaNqY5BBNyMFwqIC9NUS5xTLvduZ/2hPKJmkKyGY7d5rklDgMFWwm+zGI76r0+xCPhgroujESQG/+ZWkEPDZu4JKGwSKUy1DPtc49/O7aHDBfg9qNF4BDfsmEgFpTVLQ3xahjje3ciE/GKd9ZCInbv7MLsckJO+no1twRFT2NfcP80Ua6epwz4Jfz/em++hPav/hGm8yH1gGWc1WN2gHW9InouDx/56cF64PexMTdROsg1C+wyiewzmXTFPr5LUz/ZjYLdBy4VdurevTUZCOvQb9AkdUZYfWYouwiGWdeFE4+L2japKaiaD6tv1j9NAHc0z7Y0X88vv7Zut7H1e5NiORZpPGc77UfquiFeiM9ywTfBMMZ00gxwXMTdd0kvEAu3VBANkD0YZ7lrxCDKYJCbuS7E224y/aQ6xiXb5aBQbTwiiTf6Ph2G0S0yl3y3Kl39XjBZHVDPrmKICOEcDtTgMgq2OOQKRz94aUf3GU53hE8tJSweuVLiYKgR3H/Z1X2StfFm3cyBFwiE8QkqtjttZx+ON2JteITygWycFJcSRDIlrxg1CdwJN3f8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199015)(40470700004)(46966006)(36840700001)(54906003)(6916009)(316002)(356005)(2906002)(36860700001)(8936002)(41300700001)(5660300002)(83380400001)(70206006)(4326008)(70586007)(8676002)(86362001)(26005)(426003)(2616005)(186003)(1076003)(47076005)(82310400005)(81166007)(336012)(478600001)(40460700003)(103116003)(40480700001)(36756003)(82740400003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 15:57:49.7351 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 36fa434f-7d6d-4c2b-4fa4-08dad1594cd7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT110.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5858 Define missing assembly aliases for GIC registers on arm32, taking the ones defined already for arm64 as a base. Aliases are defined according to the GIC Architecture Specification ARM IHI 0069H. Defined the following registers:- 1. Interrupt Controller Interrupt Priority Mask Register 2. Interrupt Controller System Register Enable register 3. Interrupt Controller Deactivate Interrupt Register 4. Interrupt Controller End Of Interrupt Register 1 5. Interrupt Controller Interrupt Acknowledge Register 1 6. Interrupt Controller Binary Point Register 1 7. Interrupt Controller Control Register 8. Interrupt Controller Interrupt Group 1 Enable register 9. Interrupt Controller Maintenance Interrupt State Register 10. Interrupt Controller End of Interrupt Status Register 11. Interrupt Controller Empty List Register Status Register 12. Interrupt Controller Virtual Machine Control Register Signed-off-by: Ayan Kumar Halder --- Changes from :- v1 - 1. Moved coproc regs definition to asm/cpregs.h v2 - 1. Defined register alias. 2. Style issues. 3. Defined ELSR, MISR, EISR to make it consistent with AArch64. v3 - 1. Rectified some of the register names. xen/arch/arm/include/asm/cpregs.h | 32 +++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h index 53142fc2b2..8f4d097a15 100644 --- a/xen/arch/arm/include/asm/cpregs.h +++ b/xen/arch/arm/include/asm/cpregs.h @@ -163,6 +163,7 @@ #define DACR p15,0,c3,c0,0 /* Domain Access Control Register */ /* CP15 CR4: */ +#define ICC_PMR p15,0,c4,c6,0 /* Interrupt Priority Mask Register */ /* CP15 CR5: Fault Status Registers */ #define DFSR p15,0,c5,c0,0 /* Data Fault Status Register */ @@ -256,6 +257,7 @@ /* CP15 CR12: */ #define ICC_SGI1R p15,0,c12 /* Interrupt Controller SGI Group 1 */ +#define ICC_DIR p15,0,c12,c11,1 /* Interrupt Controller Deactivate Interrupt Register */ #define ICC_ASGI1R p15,1,c12 /* Interrupt Controller Alias SGI Group 1 Register */ #define ICC_SGI0R p15,2,c12 /* Interrupt Controller SGI Group 0 */ #define VBAR p15,0,c12,c0,0 /* Vector Base Address Register */ @@ -281,6 +283,20 @@ #define ICH_AP1R2 __AP1Rx(2) #define ICH_AP1R3 __AP1Rx(3) +#define ICC_IAR1 p15,0,c12,c12,0 /* Interrupt Controller Interrupt Acknowledge Register 1 */ +#define ICC_EOIR1 p15,0,c12,c12,1 /* Interrupt Controller End Of Interrupt Register 1 */ +#define ICC_BPR1 p15,0,c12,c12,3 /* Interrupt Controller Binary Point Register 1 */ +#define ICC_CTLR p15,0,c12,c12,4 /* Interrupt Controller Control Register */ +#define ICC_SRE p15,0,c12,c12,5 /* Interrupt Controller System Register Enable register */ +#define ICC_IGRPEN1 p15,0,c12,c12,7 /* Interrupt Controller Interrupt Group 1 Enable register */ +#define ICC_HSRE p15,4,c12,c9,5 /* Interrupt Controller Hyp System Register Enable register */ +#define ICH_HCR p15,4,c12,c11,0 /* Interrupt Controller Hyp Control Register */ +#define ICH_VTR p15,4,c12,c11,1 /* Interrupt Controller VGIC Type Register */ +#define ICH_MISR p15,4,c12,c11,2 /* Interrupt Controller Maintenance Interrupt State Register */ +#define ICH_EISR p15,4,c12,c11,3 /* Interrupt Controller End of Interrupt Status Register */ +#define ICH_ELRSR p15,4,c12,c11,5 /* Interrupt Controller Empty List Register Status Register */ +#define ICH_VMCR p15,4,c12,c11,7 /* Interrupt Controller Virtual Machine Control Register */ + /* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ #define __LR0(x) ___CP32(p15, 4, c12, c12, x) #define __LR8(x) ___CP32(p15, 4, c12, c13, x) @@ -381,6 +397,15 @@ #define HCR_EL2 HCR #define HPFAR_EL2 HPFAR #define HSTR_EL2 HSTR +#define ICC_BPR1_EL1 ICC_BPR1 +#define ICC_CTLR_EL1 ICC_CTLR +#define ICC_DIR_EL1 ICC_DIR +#define ICC_EOIR1_EL1 ICC_EOIR1 +#define ICC_IGRPEN1_EL1 ICC_IGRPEN1 +#define ICC_PMR_EL1 ICC_PMR +#define ICC_SGI1R_EL1 ICC_SGI1R +#define ICC_SRE_EL1 ICC_SRE +#define ICC_SRE_EL2 ICC_HSRE #define ICH_AP0R0_EL2 ICH_AP0R0 #define ICH_AP0R1_EL2 ICH_AP0R1 #define ICH_AP0R2_EL2 ICH_AP0R2 @@ -389,6 +414,10 @@ #define ICH_AP1R1_EL2 ICH_AP1R1 #define ICH_AP1R2_EL2 ICH_AP1R2 #define ICH_AP1R3_EL2 ICH_AP1R3 +#define ICH_EISR_EL2 ICH_EISR +#define ICH_ELRSR_EL2 ICH_ELRSR +#define ICH_HCR_EL2 ICH_HCR +#define ICC_IAR1_EL1 ICC_IAR1 #define ICH_LR0_EL2 ICH_LR0 #define ICH_LR1_EL2 ICH_LR1 #define ICH_LR2_EL2 ICH_LR2 @@ -421,6 +450,9 @@ #define ICH_LRC13_EL2 ICH_LRC13 #define ICH_LRC14_EL2 ICH_LRC14 #define ICH_LRC15_EL2 ICH_LRC15 +#define ICH_MISR_EL2 ICH_MISR +#define ICH_VMCR_EL2 ICH_VMCR +#define ICH_VTR_EL2 ICH_VTR #define ID_AFR0_EL1 ID_AFR0 #define ID_DFR0_EL1 ID_DFR0 #define ID_DFR1_EL1 ID_DFR1 -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 16:08:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 16:08:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449084.705728 (Exim 4.92) (envelope-from ) id 1ozggg-0004BJ-DV; Mon, 28 Nov 2022 16:08:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449084.705728; Mon, 28 Nov 2022 16:08:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozggg-0004BC-Ar; Mon, 28 Nov 2022 16:08:54 +0000 Received: by outflank-mailman (input) for mailman id 449084; Mon, 28 Nov 2022 16:08:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgge-0004B5-T9 for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 16:08:53 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20625.outbound.protection.outlook.com [2a01:111:f400:7e89::625]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f1bbd8c0-6f36-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 17:08:51 +0100 (CET) Received: from BN0PR02CA0043.namprd02.prod.outlook.com (2603:10b6:408:e5::18) by IA1PR12MB6017.namprd12.prod.outlook.com (2603:10b6:208:3d7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 16:08:46 +0000 Received: from BN8NAM11FT022.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e5:cafe::f8) by BN0PR02CA0043.outlook.office365.com (2603:10b6:408:e5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Mon, 28 Nov 2022 16:08:46 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT022.mail.protection.outlook.com (10.13.176.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.23 via Frontend Transport; Mon, 28 Nov 2022 16:08:46 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 10:08:39 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 28 Nov 2022 10:07:54 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 28 Nov 2022 10:07:50 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1bbd8c0-6f36-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AL//s1zEJKs7qkueN9ENWAsoZJlRe++gZqYBhwG5gPjzvWbfmGfOCjYQ2Z7h7lAC3LwNkw1vjLTXgEOzun7uVMJ6Y9h/8zi2aAqDtnsn5I00So2UA9KQ3aTPEtEy9Ztxss8l7SSec/Tr0GcncHKcsLjr/SggD369HB1b8ibdELEwbEkdUint0dkkk1gdB5OOXc5jRpEanvy/kzRI94l46qJB3q1joYlQyJzwi2Mvjd2VCNxBmpcEsqwm+fBOMpxhVAlrph7uuGTnHhH0culdioNFq7ZfPbP3cILBLqKerMpiKWjw+ritF6u991QqJo6OELwGCeoILhyiqkQXBTOx7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dqx0a48FA+ehf5uHjfytDEa1WxcEZ3LXfIN0HJxb6Ic=; b=ZCZG87/T8mPZYML2qhdZNUAgIlT7V7wDn5S7Ui8Xe6iSUxc09UevMtgWovmEzZ6KciW0UBVvNn7kWgj9UjAsEBWBaGc5YgNok4e/iuOjYlFsmzc4Wx0HzC1WKqzQmA/q58MEEGPJUtC9MTsexlDfK1ZC1NYImO+zkK/U2EDq0cS+ltuvC3lag8FT4FfeRmMSg0ToLEI47iXYsPmMIqgUfZ5l92kASEAb+a0CPZiR8Scbjat2NRWNaKKOB/VvSHuBHxSvSvcy/LsSpSjm4deQmoqBW8+23vOG8vttKNWC4eFvLQgiuY/luxpBlwbgwyeSvq/d9Sj4dRaR++D9YCO7Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dqx0a48FA+ehf5uHjfytDEa1WxcEZ3LXfIN0HJxb6Ic=; b=pTKS7zWPD/yXOH0e7ghGW4haHSAItIAtQw0px2BOHYB3ZxqERetC9eEXjDH8zwtLNWjcg6BGGkBpFWz2+RL4JNMyVUOtuQSsVqdl8ONnh5cY8qrUkAo7SCwIV1bJ9kJgXxdfKGbSogTzANhtHseDpP3MU3mbMNRG0sQb3N3RJGs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , "Ayan Kumar Halder" Subject: [XEN v4 07/11] xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32 Date: Mon, 28 Nov 2022 16:07:45 +0000 Message-ID: <20221128160745.43148-1-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT022:EE_|IA1PR12MB6017:EE_ X-MS-Office365-Filtering-Correlation-Id: 274ea12c-19bc-4e14-eb7a-08dad15ad44f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t87VaZgiuEodblh329COSEx4H27Ov6Zc+2JgWxZQ6C9Afgu/fk8/GvP92ug6DW8yafXYdughPGsz6Y7tCF6+nJGJ/udnRqll24urFWn7UPlDhq67gqq2M67K9qJv4gJq1NnoIHAM1gZLIfnyVJ1Xy9pvibCvkPlvbqMcAmHVMoo6OFsnvmY1osG3Y+KeZgMwx5uxoMvLajXVO66lr7qIZ32yeGKvM0hURP3MnSoVKpXAD4jw8ypG4zba5PSnJf30MdoJWJqDp9TlJBJZqfXQfTGUb+fUwLcgm2iNdzmHROr/3Cl1wEo9fXf8Nzw/yckwWaDQ7I8krF+2X+X7jyO4iDOZXPwXFFzneuWuYB469p6fKoW2JLhkekPi/IihZoWlN2Dg5gG7jN8LuwI1fcZGliOtS+Kzwf2pqlxKBE5Ck2xOFaVbp9NRoFJBQWo5Xq9STZdfxVx+nSPh2vu1G+9OQE2/o5EbqAJTIFrPCJ1jX8JhqmJptemmBkSnqYMIimAq6iij2ptfARh8hbE1eqi13thruIXYBxn2Tw/+565TcHJnEk5D4BDUC1UYEXQ09Q+H1mEI0ixA5yGOrDoFo24nSMkHfLkgBuD8vIF/WJ/jba1yOzeRH7j2hBsigY0s2+Y9AB25kFcgdH+KJld+iJ1TOUGE+aG75m5Y2CJWQFtJcWZJdBzmw0bMCBHSriVQNPtoB1gIqPy6q5TgWTOOKuvTAhef7H3D94BWSxILjBvJ2/c= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(136003)(396003)(451199015)(36840700001)(46966006)(40470700004)(2616005)(2906002)(36860700001)(83380400001)(82740400003)(26005)(41300700001)(70586007)(40460700003)(8676002)(70206006)(40480700001)(81166007)(356005)(36756003)(6666004)(478600001)(82310400005)(426003)(336012)(186003)(103116003)(8936002)(5660300002)(1076003)(47076005)(4326008)(86362001)(316002)(6916009)(30864003)(54906003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 16:08:46.5147 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 274ea12c-19bc-4e14-eb7a-08dad15ad44f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT022.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6017 Refer "Arm IHI 0069H ID020922", 12.4.6, Interrupt Controller List Registers AArch64 System register ICH_LR_EL2 bits [31:0] are architecturally mapped to AArch32 System register ICH_LR[31:0]. AArch64 System register ICH_LR_EL2 bits [63:32] are architecturally mapped to AArch32 System register ICH_LRC[31:0]. Defined ICH_LR<0...15>_EL2 and ICH_LRC<0...15>_EL2 for AArch32. For AArch32, the link register is stored as :- (((uint64_t) ICH_LRC<0...15>_EL2) << 32) | ICH_LR<0...15>_EL2 Also, ICR_LR macros need to be modified as ULL is 64 bits for AArch32 and AArch64. Signed-off-by: Ayan Kumar Halder --- Changes from :- v1 - 1. Moved the coproc register definitions to asm/cpregs.h. 2. Use GENMASK(31, 0) to represent 0xFFFFFFFF 3. Use READ_CP32()/WRITE_CP32() instead of READ_SYSREG()/WRITE_SYSREG(). 4. Multi-line macro definitions should be enclosed within ({ }). v2 - 1. Use WRITE_SYSREG_LR(V, R) to make it consistent with before. 2. Defined the register alias. 3. Style issues. v3 - 1. Addressed style issues. xen/arch/arm/gic-v3.c | 132 +++++++++++------------ xen/arch/arm/include/asm/arm32/sysregs.h | 19 ++++ xen/arch/arm/include/asm/arm64/sysregs.h | 5 + xen/arch/arm/include/asm/cpregs.h | 76 +++++++++++++ xen/arch/arm/include/asm/gic_v3_defs.h | 8 +- 5 files changed, 170 insertions(+), 70 deletions(-) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 64a76307dd..6457e7033c 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -73,37 +73,37 @@ static inline void gicv3_save_lrs(struct vcpu *v) switch ( gicv3_info.nr_lrs ) { case 16: - v->arch.gic.v3.lr[15] = READ_SYSREG(ICH_LR15_EL2); + v->arch.gic.v3.lr[15] = READ_SYSREG_LR(15); case 15: - v->arch.gic.v3.lr[14] = READ_SYSREG(ICH_LR14_EL2); + v->arch.gic.v3.lr[14] = READ_SYSREG_LR(14); case 14: - v->arch.gic.v3.lr[13] = READ_SYSREG(ICH_LR13_EL2); + v->arch.gic.v3.lr[13] = READ_SYSREG_LR(13); case 13: - v->arch.gic.v3.lr[12] = READ_SYSREG(ICH_LR12_EL2); + v->arch.gic.v3.lr[12] = READ_SYSREG_LR(12); case 12: - v->arch.gic.v3.lr[11] = READ_SYSREG(ICH_LR11_EL2); + v->arch.gic.v3.lr[11] = READ_SYSREG_LR(11); case 11: - v->arch.gic.v3.lr[10] = READ_SYSREG(ICH_LR10_EL2); + v->arch.gic.v3.lr[10] = READ_SYSREG_LR(10); case 10: - v->arch.gic.v3.lr[9] = READ_SYSREG(ICH_LR9_EL2); + v->arch.gic.v3.lr[9] = READ_SYSREG_LR(9); case 9: - v->arch.gic.v3.lr[8] = READ_SYSREG(ICH_LR8_EL2); + v->arch.gic.v3.lr[8] = READ_SYSREG_LR(8); case 8: - v->arch.gic.v3.lr[7] = READ_SYSREG(ICH_LR7_EL2); + v->arch.gic.v3.lr[7] = READ_SYSREG_LR(7); case 7: - v->arch.gic.v3.lr[6] = READ_SYSREG(ICH_LR6_EL2); + v->arch.gic.v3.lr[6] = READ_SYSREG_LR(6); case 6: - v->arch.gic.v3.lr[5] = READ_SYSREG(ICH_LR5_EL2); + v->arch.gic.v3.lr[5] = READ_SYSREG_LR(5); case 5: - v->arch.gic.v3.lr[4] = READ_SYSREG(ICH_LR4_EL2); + v->arch.gic.v3.lr[4] = READ_SYSREG_LR(4); case 4: - v->arch.gic.v3.lr[3] = READ_SYSREG(ICH_LR3_EL2); + v->arch.gic.v3.lr[3] = READ_SYSREG_LR(3); case 3: - v->arch.gic.v3.lr[2] = READ_SYSREG(ICH_LR2_EL2); + v->arch.gic.v3.lr[2] = READ_SYSREG_LR(2); case 2: - v->arch.gic.v3.lr[1] = READ_SYSREG(ICH_LR1_EL2); + v->arch.gic.v3.lr[1] = READ_SYSREG_LR(1); case 1: - v->arch.gic.v3.lr[0] = READ_SYSREG(ICH_LR0_EL2); + v->arch.gic.v3.lr[0] = READ_SYSREG_LR(0); break; default: BUG(); @@ -120,37 +120,37 @@ static inline void gicv3_restore_lrs(const struct vcpu *v) switch ( gicv3_info.nr_lrs ) { case 16: - WRITE_SYSREG(v->arch.gic.v3.lr[15], ICH_LR15_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[15], 15); case 15: - WRITE_SYSREG(v->arch.gic.v3.lr[14], ICH_LR14_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[14], 14); case 14: - WRITE_SYSREG(v->arch.gic.v3.lr[13], ICH_LR13_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[13], 13); case 13: - WRITE_SYSREG(v->arch.gic.v3.lr[12], ICH_LR12_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[12], 12); case 12: - WRITE_SYSREG(v->arch.gic.v3.lr[11], ICH_LR11_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[11], 11); case 11: - WRITE_SYSREG(v->arch.gic.v3.lr[10], ICH_LR10_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[10], 10); case 10: - WRITE_SYSREG(v->arch.gic.v3.lr[9], ICH_LR9_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[9], 9); case 9: - WRITE_SYSREG(v->arch.gic.v3.lr[8], ICH_LR8_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[8], 8); case 8: - WRITE_SYSREG(v->arch.gic.v3.lr[7], ICH_LR7_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[7], 7); case 7: - WRITE_SYSREG(v->arch.gic.v3.lr[6], ICH_LR6_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[6], 6); case 6: - WRITE_SYSREG(v->arch.gic.v3.lr[5], ICH_LR5_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[5], 5); case 5: - WRITE_SYSREG(v->arch.gic.v3.lr[4], ICH_LR4_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[4], 4); case 4: - WRITE_SYSREG(v->arch.gic.v3.lr[3], ICH_LR3_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[3], 3); case 3: - WRITE_SYSREG(v->arch.gic.v3.lr[2], ICH_LR2_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[2], 2); case 2: - WRITE_SYSREG(v->arch.gic.v3.lr[1], ICH_LR1_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[1], 1); case 1: - WRITE_SYSREG(v->arch.gic.v3.lr[0], ICH_LR0_EL2); + WRITE_SYSREG_LR(v->arch.gic.v3.lr[0], 0); break; default: BUG(); @@ -161,22 +161,22 @@ static uint64_t gicv3_ich_read_lr(int lr) { switch ( lr ) { - case 0: return READ_SYSREG(ICH_LR0_EL2); - case 1: return READ_SYSREG(ICH_LR1_EL2); - case 2: return READ_SYSREG(ICH_LR2_EL2); - case 3: return READ_SYSREG(ICH_LR3_EL2); - case 4: return READ_SYSREG(ICH_LR4_EL2); - case 5: return READ_SYSREG(ICH_LR5_EL2); - case 6: return READ_SYSREG(ICH_LR6_EL2); - case 7: return READ_SYSREG(ICH_LR7_EL2); - case 8: return READ_SYSREG(ICH_LR8_EL2); - case 9: return READ_SYSREG(ICH_LR9_EL2); - case 10: return READ_SYSREG(ICH_LR10_EL2); - case 11: return READ_SYSREG(ICH_LR11_EL2); - case 12: return READ_SYSREG(ICH_LR12_EL2); - case 13: return READ_SYSREG(ICH_LR13_EL2); - case 14: return READ_SYSREG(ICH_LR14_EL2); - case 15: return READ_SYSREG(ICH_LR15_EL2); + case 0: return READ_SYSREG_LR(0); + case 1: return READ_SYSREG_LR(1); + case 2: return READ_SYSREG_LR(2); + case 3: return READ_SYSREG_LR(3); + case 4: return READ_SYSREG_LR(4); + case 5: return READ_SYSREG_LR(5); + case 6: return READ_SYSREG_LR(6); + case 7: return READ_SYSREG_LR(7); + case 8: return READ_SYSREG_LR(8); + case 9: return READ_SYSREG_LR(9); + case 10: return READ_SYSREG_LR(10); + case 11: return READ_SYSREG_LR(11); + case 12: return READ_SYSREG_LR(12); + case 13: return READ_SYSREG_LR(13); + case 14: return READ_SYSREG_LR(14); + case 15: return READ_SYSREG_LR(15); default: BUG(); } @@ -187,52 +187,52 @@ static void gicv3_ich_write_lr(int lr, uint64_t val) switch ( lr ) { case 0: - WRITE_SYSREG(val, ICH_LR0_EL2); + WRITE_SYSREG_LR(val, 0); break; case 1: - WRITE_SYSREG(val, ICH_LR1_EL2); + WRITE_SYSREG_LR(val, 1); break; case 2: - WRITE_SYSREG(val, ICH_LR2_EL2); + WRITE_SYSREG_LR(val, 2); break; case 3: - WRITE_SYSREG(val, ICH_LR3_EL2); + WRITE_SYSREG_LR(val, 3); break; case 4: - WRITE_SYSREG(val, ICH_LR4_EL2); + WRITE_SYSREG_LR(val, 4); break; case 5: - WRITE_SYSREG(val, ICH_LR5_EL2); + WRITE_SYSREG_LR(val, 5); break; case 6: - WRITE_SYSREG(val, ICH_LR6_EL2); + WRITE_SYSREG_LR(val, 6); break; case 7: - WRITE_SYSREG(val, ICH_LR7_EL2); + WRITE_SYSREG_LR(val, 7); break; case 8: - WRITE_SYSREG(val, ICH_LR8_EL2); + WRITE_SYSREG_LR(val, 8); break; case 9: - WRITE_SYSREG(val, ICH_LR9_EL2); + WRITE_SYSREG_LR(val, 9); break; case 10: - WRITE_SYSREG(val, ICH_LR10_EL2); + WRITE_SYSREG_LR(val, 10); break; case 11: - WRITE_SYSREG(val, ICH_LR11_EL2); + WRITE_SYSREG_LR(val, 11); break; case 12: - WRITE_SYSREG(val, ICH_LR12_EL2); + WRITE_SYSREG_LR(val, 12); break; case 13: - WRITE_SYSREG(val, ICH_LR13_EL2); + WRITE_SYSREG_LR(val, 13); break; case 14: - WRITE_SYSREG(val, ICH_LR14_EL2); + WRITE_SYSREG_LR(val, 14); break; case 15: - WRITE_SYSREG(val, ICH_LR15_EL2); + WRITE_SYSREG_LR(val, 15); break; default: return; @@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v) if ( v == current ) { for ( i = 0; i < gicv3_info.nr_lrs; i++ ) - printk(" HW_LR[%d]=%lx\n", i, gicv3_ich_read_lr(i)); + printk(" HW_LR[%d]=%" PRIx64 "\n", i, gicv3_ich_read_lr(i)); } else { for ( i = 0; i < gicv3_info.nr_lrs; i++ ) - printk(" VCPU_LR[%d]=%lx\n", i, v->arch.gic.v3.lr[i]); + printk(" VCPU_LR[%d]=%" PRIx64 "\n", i, v->arch.gic.v3.lr[i]); } } diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h index 6841d5de43..22871999af 100644 --- a/xen/arch/arm/include/asm/arm32/sysregs.h +++ b/xen/arch/arm/include/asm/arm32/sysregs.h @@ -62,6 +62,25 @@ #define READ_SYSREG(R...) READ_SYSREG32(R) #define WRITE_SYSREG(V, R...) WRITE_SYSREG32(V, R) +/* Wrappers for accessing interrupt controller list registers. */ +#define ICH_LR_REG(index) ICH_LR ## index ## _EL2 +#define ICH_LRC_REG(index) ICH_LRC ## index ## _EL2 + +#define READ_SYSREG_LR(index) ({ \ + uint64_t _val; \ + uint32_t _lrc = READ_CP32(ICH_LRC_REG(index)); \ + uint32_t _lr = READ_CP32(ICH_LR_REG(index)); \ + \ + _val = ((uint64_t) _lrc << 32) | _lr; \ + _val; \ +}) + +#define WRITE_SYSREG_LR(v, index) ({ \ + uint64_t _val = (v); \ + WRITE_CP32(_val & GENMASK(31, 0), ICH_LR_REG(index)); \ + WRITE_CP32(_val >> 32, ICH_LRC_REG(index)); \ +}) + /* MVFR2 is not defined on ARMv7 */ #define MVFR2_MAYBE_UNDEFINED diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index 54670084c3..4638999514 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -472,6 +472,11 @@ #define READ_SYSREG(name) READ_SYSREG64(name) #define WRITE_SYSREG(v, name) WRITE_SYSREG64(v, name) +/* Wrappers for accessing interrupt controller list registers. */ +#define ICH_LR_REG(index) ICH_LR ## index ## _EL2 +#define WRITE_SYSREG_LR(v, index) WRITE_SYSREG(v, ICH_LR_REG(index)) +#define READ_SYSREG_LR(index) READ_SYSREG(ICH_LR_REG(index)) + #endif /* _ASM_ARM_ARM64_SYSREGS_H */ /* diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h index 6daf2b1a30..b85e811f51 100644 --- a/xen/arch/arm/include/asm/cpregs.h +++ b/xen/arch/arm/include/asm/cpregs.h @@ -8,6 +8,8 @@ * support 32-bit guests. */ +#define ___CP32(coproc, opc1, crn, crm, opc2) coproc, opc1, crn, crm, opc2 + #define __HSR_CPREG_c0 0 #define __HSR_CPREG_c1 1 #define __HSR_CPREG_c2 2 @@ -259,6 +261,48 @@ #define VBAR p15,0,c12,c0,0 /* Vector Base Address Register */ #define HVBAR p15,4,c12,c0,0 /* Hyp. Vector Base Address Register */ +/* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ +#define __LR0(x) ___CP32(p15, 4, c12, c12, x) +#define __LR8(x) ___CP32(p15, 4, c12, c13, x) + +#define ICH_LR0 __LR0(0) +#define ICH_LR1 __LR0(1) +#define ICH_LR2 __LR0(2) +#define ICH_LR3 __LR0(3) +#define ICH_LR4 __LR0(4) +#define ICH_LR5 __LR0(5) +#define ICH_LR6 __LR0(6) +#define ICH_LR7 __LR0(7) +#define ICH_LR8 __LR8(0) +#define ICH_LR9 __LR8(1) +#define ICH_LR10 __LR8(2) +#define ICH_LR11 __LR8(3) +#define ICH_LR12 __LR8(4) +#define ICH_LR13 __LR8(5) +#define ICH_LR14 __LR8(6) +#define ICH_LR15 __LR8(7) + +/* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ +#define __LRC0(x) ___CP32(p15, 4, c12, c14, x) +#define __LRC8(x) ___CP32(p15, 4, c12, c15, x) + +#define ICH_LRC0 __LRC0(0) +#define ICH_LRC1 __LRC0(1) +#define ICH_LRC2 __LRC0(2) +#define ICH_LRC3 __LRC0(3) +#define ICH_LRC4 __LRC0(4) +#define ICH_LRC5 __LRC0(5) +#define ICH_LRC6 __LRC0(6) +#define ICH_LRC7 __LRC0(7) +#define ICH_LRC8 __LRC8(0) +#define ICH_LRC9 __LRC8(1) +#define ICH_LRC10 __LRC8(2) +#define ICH_LRC11 __LRC8(3) +#define ICH_LRC12 __LRC8(4) +#define ICH_LRC13 __LRC8(5) +#define ICH_LRC14 __LRC8(6) +#define ICH_LRC15 __LRC8(7) + /* CP15 CR13: */ #define FCSEIDR p15,0,c13,c0,0 /* FCSE Process ID Register */ #define CONTEXTIDR p15,0,c13,c0,1 /* Context ID Register */ @@ -317,6 +361,38 @@ #define HCR_EL2 HCR #define HPFAR_EL2 HPFAR #define HSTR_EL2 HSTR +#define ICH_LR0_EL2 ICH_LR0 +#define ICH_LR1_EL2 ICH_LR1 +#define ICH_LR2_EL2 ICH_LR2 +#define ICH_LR3_EL2 ICH_LR3 +#define ICH_LR4_EL2 ICH_LR4 +#define ICH_LR5_EL2 ICH_LR5 +#define ICH_LR6_EL2 ICH_LR6 +#define ICH_LR7_EL2 ICH_LR7 +#define ICH_LR8_EL2 ICH_LR8 +#define ICH_LR9_EL2 ICH_LR9 +#define ICH_LR10_EL2 ICH_LR10 +#define ICH_LR11_EL2 ICH_LR11 +#define ICH_LR12_EL2 ICH_LR12 +#define ICH_LR13_EL2 ICH_LR13 +#define ICH_LR14_EL2 ICH_LR14 +#define ICH_LR15_EL2 ICH_LR15 +#define ICH_LRC0_EL2 ICH_LRC0 +#define ICH_LRC1_EL2 ICH_LRC1 +#define ICH_LRC2_EL2 ICH_LRC2 +#define ICH_LRC3_EL2 ICH_LRC3 +#define ICH_LRC4_EL2 ICH_LRC4 +#define ICH_LRC5_EL2 ICH_LRC5 +#define ICH_LRC6_EL2 ICH_LRC6 +#define ICH_LRC7_EL2 ICH_LRC7 +#define ICH_LRC8_EL2 ICH_LRC8 +#define ICH_LRC9_EL2 ICH_LRC9 +#define ICH_LRC10_EL2 ICH_LRC10 +#define ICH_LRC11_EL2 ICH_LRC11 +#define ICH_LRC12_EL2 ICH_LRC12 +#define ICH_LRC13_EL2 ICH_LRC13 +#define ICH_LRC14_EL2 ICH_LRC14 +#define ICH_LRC15_EL2 ICH_LRC15 #define ID_AFR0_EL1 ID_AFR0 #define ID_DFR0_EL1 ID_DFR0 #define ID_DFR1_EL1 ID_DFR1 diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h index 48a1bc401e..227533868f 100644 --- a/xen/arch/arm/include/asm/gic_v3_defs.h +++ b/xen/arch/arm/include/asm/gic_v3_defs.h @@ -185,9 +185,9 @@ #define ICH_LR_HW_SHIFT 61 #define ICH_LR_GRP_MASK 0x1 #define ICH_LR_GRP_SHIFT 60 -#define ICH_LR_MAINTENANCE_IRQ (1UL<<41) -#define ICH_LR_GRP1 (1UL<<60) -#define ICH_LR_HW (1UL<<61) +#define ICH_LR_MAINTENANCE_IRQ (1ULL << 41) +#define ICH_LR_GRP1 (1ULL << 60) +#define ICH_LR_HW (1ULL << 61) #define ICH_VTR_NRLRGS 0x3f #define ICH_VTR_PRIBITS_MASK 0x7 @@ -195,7 +195,7 @@ #define ICH_SGI_IRQMODE_SHIFT 40 #define ICH_SGI_IRQMODE_MASK 0x1 -#define ICH_SGI_TARGET_OTHERS 1UL +#define ICH_SGI_TARGET_OTHERS 1ULL #define ICH_SGI_TARGET_LIST 0 #define ICH_SGI_IRQ_SHIFT 24 #define ICH_SGI_IRQ_MASK 0xf -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Nov 28 16:18:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 16:18:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449096.705739 (Exim 4.92) (envelope-from ) id 1ozgpj-0005pf-Cq; Mon, 28 Nov 2022 16:18:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449096.705739; Mon, 28 Nov 2022 16:18:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgpj-0005pY-AK; Mon, 28 Nov 2022 16:18:15 +0000 Received: by outflank-mailman (input) for mailman id 449096; Mon, 28 Nov 2022 16:18:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozgpi-0005pS-FI for xen-devel@lists.xenproject.org; Mon, 28 Nov 2022 16:18:14 +0000 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [2607:f8b0:4864:20::22c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4198cfa0-6f38-11ed-91b6-6bf2151ebd3b; Mon, 28 Nov 2022 17:18:13 +0100 (CET) Received: by mail-oi1-x22c.google.com with SMTP id s206so12107734oie.3 for ; Mon, 28 Nov 2022 08:18:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4198cfa0-6f38-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dUmDKm1BpvIA6b7fg9TAsV7I3v/dDsa2Ew5AZiuOYPE=; b=nhYgjDRaG8GIB07OWuhluoflnp2AgXdKFYUlqJTAkGKb7OBUwRf5JaXc99kv5rIjzB XibHDK5QistPDLVZdQUldDUKgNxEvSutDoZZqK0kKp7RV07NZMTEQPbQe1wQb3y9Hel1 uL4o2thCCSgT17Vzp9QYA69pu/F2Q7rxd5HwKCcfIlVzMr7rsGnLk+i1rSeVPSGwF438 49ZNUQN/7ffCQId7bVcCc2XPQXdJjdUpK527oC86VDrn1zeybvep0YYkblwvbRrfKCB5 M2uireOApJqO6XIh6W1pk41FKOl9rEZVTIjfHHDDJ4SklUmvb6N7GNl4dxCXDg8/hiob MzJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dUmDKm1BpvIA6b7fg9TAsV7I3v/dDsa2Ew5AZiuOYPE=; b=64qW0mdFS2qODxuZHcZrmWjzfv/UERqeB3W1bsGDaRe6eUHRT7/QivrWbONzwHli/l nL6KqoZIw444Ej/Ye/yUiI+FbxsQRMn9xS6gwVoZfuyQx4M8zJ4opz/71cD/2NKbKSOt feOxP65yj9TiKiBiYDZ7O5ijPFK4aXVOGW0n9VNa6nDWT2FZksTrL+lQEZfpmK1lAolX DIwHkSp4u9HodVpqwbk3Ail4kVw/ei3V8Q3GqS7NkjP0eptAXm9OIQnHWjkcZVO1xnns qsUGZs5jCI16P0AGYr4pmLJHXULHj7bKQD5l8KZZ/Xh+dqpT+Qs9RV/onHDddcsBq9pR xT+g== X-Gm-Message-State: ANoB5pka86Z3ZdoqxY6W2gYTWu3hAjE0Anj8/d8V44vzbF9+bWeAWZw9 iU1lqLpB2VIpNo/a5Vo1HnCuoixFwKwLH9LeMzI= X-Google-Smtp-Source: AA0mqf43Ny6wktI/b9zIB2jtXO0sK5QhF8mG/bYbdBhNFrS7Wia5GSy7m9AunvQEeQE5S237dX5kciTIzTmPiM/Pgtk= X-Received: by 2002:a05:6808:9b8:b0:34f:97ea:14d with SMTP id e24-20020a05680809b800b0034f97ea014dmr15155644oig.96.1669652292076; Mon, 28 Nov 2022 08:18:12 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alex Deucher Date: Mon, 28 Nov 2022 11:18:00 -0500 Message-ID: Subject: Re: AMD GPU problems under Xen To: Demi Marie Obenour Cc: christian.koenig@amd.com, Xen developer discussion , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: text/plain; charset="UTF-8" On Mon, Nov 28, 2022 at 2:18 AM Demi Marie Obenour wrote: > > Dear Christian: > > What is the status of the AMDGPU work for Xen dom0? That was mentioned in > https://lore.kernel.org/dri-devel/b2dec9b3-03a7-e7ac-306e-1da024af8982@amd.com/ > and there have been bug reports to Qubes OS about problems with AMDGPU > under Xen (such as https://github.com/QubesOS/qubes-issues/issues/7648). I would say it's a work in progress. It depends what GPU you have and what type of xen setup you are using (PV vs PVH, etc.). In general, your best bet currently is dGPU add in boards because they are largely self contained. APUs and platforms with integrated dGPUs are a bit more complicated as they tend to have more platform dependencies like ACPI tables and methods in order for the driver to be able to initialize the hardware properly. Additionally, GPUs map a lot of system memory so bounce buffers aren't really viable. You'll really need IOMMU, Alex > -- > Sincerely, > Demi Marie Obenour (she/her/hers) > Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Mon Nov 28 18:09:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 18:09:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449110.705750 (Exim 4.92) (envelope-from ) id 1oziYk-0000jO-C5; Mon, 28 Nov 2022 18:08:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449110.705750; Mon, 28 Nov 2022 18:08:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oziYk-0000jH-9K; Mon, 28 Nov 2022 18:08:50 +0000 Received: by outflank-mailman (input) for mailman id 449110; Mon, 28 Nov 2022 18:08:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oziYi-0000j7-8D; Mon, 28 Nov 2022 18:08:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oziYi-0006TQ-3W; Mon, 28 Nov 2022 18:08:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oziYh-0000nV-Gv; Mon, 28 Nov 2022 18:08:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oziYh-0000d3-GL; Mon, 28 Nov 2022 18:08:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8CFhJN2d8MtYpsnNSVP3+Lk00zf5hbvCDw7sgVuhS04=; b=j2y8bXcNsCzsU5hLYBTWR35PSP QB4dCrd/CTeuiO22cDsocwZhRPJpv5IjFAZl+Yx12j0ZigUvqp7APzRqXHOEcGtUOB2ujDECYe2nz moiugCGY1uxyBoFtamAiGetSFwILQSHrgePmdD/yGOiZEXXOU+v5Pr+mGn3zEGqLp9cU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174979: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-intel::broken:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:host-install(5):broken:heisenbug linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b7b275e60bcd5f89771e865a8239325f86d9927d X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Mon, 28 Nov 2022 18:08:47 +0000 flight 174979 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174979/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-intel broken test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Tests which are failing intermittently (not blocking): test-amd64-amd64-dom0pvh-xl-intel 5 host-install(5) broken pass in 174975 test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail in 174975 pass in 174979 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux b7b275e60bcd5f89771e865a8239325f86d9927d baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 51 days Failing since 173470 2022-10-08 06:21:34 Z 51 days 98 attempts Testing same since 174975 2022-11-27 23:39:38 Z 0 days 2 attempts ------------------------------------------------------------ 1906 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel broken test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-dom0pvh-xl-intel broken broken-step test-amd64-amd64-dom0pvh-xl-intel host-install(5) Not pushing. (No revision log; it would be 181680 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Nov 28 18:48:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 28 Nov 2022 18:48:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449117.705761 (Exim 4.92) (envelope-from ) id 1ozjAp-0005OR-BA; Mon, 28 Nov 2022 18:48:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449117.705761; Mon, 28 Nov 2022 18:48:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozjAp-0005OK-8V; Mon, 28 Nov 2022 18:48:11 +0000 Received: by outflank-mailman (input) for mailman id 449117; Mon, 28 Nov 2022 18:48:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozjAn-0005OA-MD; Mon, 28 Nov 2022 18:48:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozjAn-0007Pn-H9; Mon, 28 Nov 2022 18:48:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozjAm-0001fu-TF; Mon, 28 Nov 2022 18:48:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozjAm-00031f-Sn; Mon, 28 Nov 2022 18:48:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=87hs1FMCb2i++MZ3hD9gcwNP5nXMriXxfAZODSoTvAs=; b=pA7PhUP/ZXsAHNwf2uz6jnG4Dw LuhwkVDgun1nRwl9qsVlxQ6g2+91itSkfGxOqDFNByimFMlvxrD9U1Hfw3vDBYXDXvND2mt9CtyDp JK9mAyweVZpworjUtuJBUwx4/4qFOpQYPy0qUDlKuAO0qdz8KAG4dUoyKDuvNq0f8kyQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 174981: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4320b31106efe4cf78867e1da379f7534e1c5c34 X-Osstest-Versions-That: xen=0d39a6d1ae3df67e11548dedfc8e1923a9002fcd From: osstest service owner Date: Mon, 28 Nov 2022 18:48:08 +0000 flight 174981 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/174981/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174767 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174767 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174767 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174767 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174767 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174767 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174767 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174767 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174767 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174767 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174767 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174767 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 4320b31106efe4cf78867e1da379f7534e1c5c34 baseline version: xen 0d39a6d1ae3df67e11548dedfc8e1923a9002fcd Last test of basis 174767 2022-11-14 11:07:52 Z 14 days Testing same since 174981 2022-11-28 11:09:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 0d39a6d1ae..4320b31106 4320b31106efe4cf78867e1da379f7534e1c5c34 -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Tue Nov 29 00:18:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 00:18:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449169.705784 (Exim 4.92) (envelope-from ) id 1ozoKZ-0006dX-F0; Tue, 29 Nov 2022 00:18:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449169.705784; Tue, 29 Nov 2022 00:18:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozoKZ-0006dQ-CE; Tue, 29 Nov 2022 00:18:35 +0000 Received: by outflank-mailman (input) for mailman id 449169; Tue, 29 Nov 2022 00:18:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozoKX-0006dK-GR for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 00:18:33 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5a082d06-6f7b-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 01:18:31 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A2DE761511; Tue, 29 Nov 2022 00:18:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC50BC433C1; Tue, 29 Nov 2022 00:18:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a082d06-6f7b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669681109; bh=YixsR12PJDn9xlCuW5VEiZORmlQGw6gVE3t4ZgP7BPw=; h=From:To:Cc:Subject:Date:From; b=m7P1FCjAmQWLPrrIwa0XOJqpHSGV/1K6/CiCAsgIoWJDIDAclPtr1DZ3dZtOsBjD6 OFwGgJDhYpjcRUAJEpPuimix8klC6pDieC0KzKPdzzYikuGZbPiF078n8bhyvZfE3F gaYAhPFnOMa0h9xNlBDPPUgtFz2sjWBqv1WekG8mTOr7kwXeIpCFjmX13THxfk3hGQ XYzYpPgzA3r1w0r9Bk3Klbff7ogLgXVr8WCTacXQatnH7cq1+diVQt03Vq7c6FTiy0 5wep67/VfVq0ZIS3GcwsT9vbfJa0i3T1Yq61nIQW18CVZbtrDIu/AKYLLui5jmh3Z4 /20Ri6KEoVhWA== From: Stefano Stabellini To: sstabellini@kernel.org Cc: xen-devel@lists.xenproject.org, george.dunlap@citrix.com, andrew.cooper3@citrix.com, jbeulich@suse.com, roger.pau@citrix.com, Bertrand.Marquis@arm.com, julien@xen.org, Stefano Stabellini Subject: [PATCH] Introduce more MISRA C rules to docs/misra/rules.rst Date: Mon, 28 Nov 2022 16:18:24 -0800 Message-Id: <20221129001824.2344912-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Add the new MISRA C rules agreed by the MISRA C working group to docs/misra/rules.rst. Add a comment for Rule 19.1 to explain that Eclair's findings are "caution" reports, not violations. Signed-off-by: Stefano Stabellini --- docs/misra/rules.rst | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst index 8a659d8d47..dcceab9388 100644 --- a/docs/misra/rules.rst +++ b/docs/misra/rules.rst @@ -77,11 +77,32 @@ existing codebase are work-in-progress. behaviour - + * - `Rule 2.6 `_ + - Advisory + - A function should not contain unused label declarations + - + + * - `Rule 3.1 `_ + - Required + - The character sequences /* and // shall not be used within a + comment + - + * - `Rule 3.2 `_ - Required - Line-splicing shall not be used in // comments - + * - `Rule 4.1 `_ + - Required + - Octal and hexadecimal escape sequences shall be terminated + - + + * - `Rule 4.2 `_ + - Advisory + - Trigraphs should not be used + - + * - `Rule 5.1 `_ - Required - External identifiers shall be distinct @@ -200,6 +221,21 @@ existing codebase are work-in-progress. have an explicit return statement with an expression - + * - `Rule 17.6 `_ + - Mandatory + - The declaration of an array parameter shall not contain the + static keyword between the [ ] + - + + * - `Rule 19.1 `_ + - Mandatory + - An object shall not be assigned or copied to an overlapping + object + - Be aware that the static analysis tool Eclair might report + several findings for Rule 19.1 of type "caution". These are + instances where Eclair is unable to verify that the code is valid + in regard to Rule 19.1. Caution reports are not violations. + * - `Rule 20.7 `_ - Required - Expressions resulting from the expansion of macro parameters -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 29 01:40:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 01:40:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449174.705796 (Exim 4.92) (envelope-from ) id 1ozpbR-0005h6-EW; Tue, 29 Nov 2022 01:40:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449174.705796; Tue, 29 Nov 2022 01:40:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozpbR-0005gI-8J; Tue, 29 Nov 2022 01:40:05 +0000 Received: by outflank-mailman (input) for mailman id 449174; Tue, 29 Nov 2022 01:40:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozpbP-0005KI-NJ for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 01:40:04 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bbb726eb-6f86-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 02:40:00 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E97566122E; Tue, 29 Nov 2022 01:39:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6535C433C1; Tue, 29 Nov 2022 01:39:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbb726eb-6f86-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669685997; bh=tJTHEaLdwV/8IXHe2yHypeCyiV5a6TBzw08venO46AU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=o6fkDcZC20ZCpvEVFbmOY5Ak+V8PZoUJMOqpM3ZjMeSYdmsR+oUMQq9Tqa+Zz9JRy gCYphHYuqmx11reid7ArFHEyg6hAmMHQjPe3BNio6UoqXiq1dEQdVVV1XS+R6nrVcy DCHbFJyQQiFo26orNK3jewwJJiKtJw8dGuz4YBBxZdGGkDuzl+HqhUVeQbKbW9azxH mCAE+NHJHqfqovA9Kq6QB3FCjLo0p9GtpXrGVIAEUKl4yle1ouu1R0gvtC5UK7042i LTyNYv8/OzwD10T4hXasbkymS/D9v1FMuGoCNxAXLv33WyDLubyc3Sf5V+AL8Y6Nhc SfIhgCrI+ZgrQ== Date: Mon, 28 Nov 2022 17:39:54 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH 1/4] xen/scripts: add xen-analysis.py for coverity and eclair analysis In-Reply-To: <20221128141006.8719-2-luca.fancellu@arm.com> Message-ID: References: <20221128141006.8719-1-luca.fancellu@arm.com> <20221128141006.8719-2-luca.fancellu@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 28 Nov 2022, Luca Fancellu wrote: > Add new script for coverity/eclair analysis tool that will enable > the procedure to suppress findings when these tool are used. > The procedure is documented in docs/misra/documenting-violations.rst > and the script is documented in docs/misra/xen-static-analysis.rst. > > Add in docs/misra/ the files safe.json and > false-positive-{coverity,eclair}.json that are JSON files containing > the data structures for the justifications, they are used by the > analysis script to link the Xen tags to the proprietary tool comment. > > Add docs/misra/documenting-violations.rst to explain how to add > justifications. > > Add docs/misra/xen-static-analysis.rst to explain how to use the > script to analyse Xen. > > Add analysis artifacts files to .gitignore. > > Signed-off-by: Luca Fancellu I would like to give my reviewed-by for all the docs and docs changes: docs/misra/documenting-violations.rst docs/misra/xen-static-analysis.rst docs/misra/safe.json docs/misra/false-positive-eclair.json docs/misra/false-positive-coverity.json I also checked that their conversion to html format works correctly. I think the docs could go in as is if moved to a separate patch. > --- > .gitignore | 1 + > docs/misra/documenting-violations.rst | 191 +++++++++++++++++++ > docs/misra/false-positive-coverity.json | 12 ++ > docs/misra/false-positive-eclair.json | 12 ++ > docs/misra/safe.json | 11 ++ > docs/misra/xen-static-analysis.rst | 54 ++++++ > xen/scripts/xen-analysis.py | 31 +++ > xen/scripts/xen_analysis/__init__.py | 0 > xen/scripts/xen_analysis/generic_analysis.py | 93 +++++++++ > xen/scripts/xen_analysis/settings.py | 97 ++++++++++ > xen/scripts/xen_analysis/tag_database.py | 109 +++++++++++ > xen/scripts/xen_analysis/utils.py | 37 ++++ > 12 files changed, 648 insertions(+) > create mode 100644 docs/misra/documenting-violations.rst > create mode 100644 docs/misra/false-positive-coverity.json > create mode 100644 docs/misra/false-positive-eclair.json > create mode 100644 docs/misra/safe.json > create mode 100644 docs/misra/xen-static-analysis.rst > create mode 100755 xen/scripts/xen-analysis.py > create mode 100644 xen/scripts/xen_analysis/__init__.py > create mode 100644 xen/scripts/xen_analysis/generic_analysis.py > create mode 100644 xen/scripts/xen_analysis/settings.py > create mode 100644 xen/scripts/xen_analysis/tag_database.py > create mode 100644 xen/scripts/xen_analysis/utils.py > > diff --git a/.gitignore b/.gitignore > index ea3243af9dde..f5a66f6194dd 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -10,6 +10,7 @@ > *.c.cppcheck > *.opic > *.a > +*.safparse > *.so > *.so.[0-9]* > *.bin > diff --git a/docs/misra/documenting-violations.rst b/docs/misra/documenting-violations.rst > new file mode 100644 > index 000000000000..1d23447556d2 > --- /dev/null > +++ b/docs/misra/documenting-violations.rst > @@ -0,0 +1,191 @@ > +.. SPDX-License-Identifier: CC-BY-4.0 > + > +Documenting violations > +====================== > + > +Static analysers are used on the Xen codebase for both static analysis and MISRA > +compliance. > +There might be the need to suppress some findings instead of fixing them and > +many tools permit the usage of in-code comments that suppress findings so that > +they are not shown in the final report. > + > +Xen includes a tool capable of translating a specific comment used in its > +codebase to the right proprietary in-code comment understandable by the selected > +analyser that suppress its finding. > + > +In the Xen codebase, these tags will be used to document and suppress findings: > + > + - SAF-X-safe: This tag means that the next line of code contains a finding, but > + the non compliance to the checker is analysed and demonstrated to be safe. > + - SAF-X-false-positive-: This tag means that the next line of code > + contains a finding, but the finding is a bug of the tool. > + > +SAF stands for Static Analyser Finding, the X is a placeholder for a positive > +number that starts from zero, the number after SAF- shall be incremental and > +unique, base ten notation and without leading zeros. > + > +Entries in the database shall never be removed, even if they are not used > +anymore in the code (if a patch is removing or modifying the faulty line). > +This is to make sure that numbers are not reused which could lead to conflicts > +with old branches or misleading justifications. > + > +An entry can be reused in multiple places in the code to suppress a finding if > +and only if the justification holds for the same non-compliance to the coding > +standard. > + > +An orphan entry, that is an entry who was justifying a finding in the code, but > +later that code was removed and there is no other use of that entry in the code, > +can be reused as long as the justification for the finding holds. This is done > +to avoid the allocation of a new entry with exactly the same justification, that > +would lead to waste of space and maintenance issues of the database. > + > +The files where to store all the justifications are in xen/docs/misra/ and are > +named as safe.json and false-positive-.json, they have JSON format, each > +one has a different justification schema which shares some fields. > + > +Here is an example to add a new justification in safe.json:: > + > +|{ > +| "version": "1.0", > +| "content": [ > +| { > +| "id": "SAF-0-safe", > +| "analyser": { > +| "coverity": "misra_c_2012_rule_20_7_violation", > +| "eclair": "MC3R1.R20.7" > +| }, > +| "name": "R20.7 C macro parameters not used as expression", > +| "text": "The macro parameters used in this [...]" > +| }, > +| { > +| "id": "SAF-1-safe", > +| "analyser": {}, > +| "name": "Sentinel", > +| "text": "Next ID to be used" > +| } > +| ] > +|} > + > +To document a finding in safe.json, just add another block {[...]} before the > +sentinel block, using the id contained in the sentinel block and increment by > +one the number contained in the id of the sentinel block. > + > +Here is an explanation of the fields inside an object of the "content" array: > + - id: it is a unique string that is used to refer to the finding, many finding > + can be tagged with the same id, if the justification holds for any applied > + case. > + It tells the tool to substitute a Xen in-code comment having this structure: > + /* SAF-0-safe [...] \*/ > + - analyser: it is an object containing pair of key-value strings, the key is > + the analyser, so it can be coverity or eclair, the value is the proprietary > + id corresponding on the finding, for example when coverity is used as > + analyser, the tool will translate the Xen in-code coment in this way: > + /* SAF-0-safe [...] \*/ -> /* coverity[misra_c_2012_rule_20_7_violation] \*/ > + if the object doesn't have a key-value, then the corresponding in-code > + comment won't be translated. > + - name: a simple name for the finding > + - text: a proper justification to turn off the finding. > + > + > +Here is an example to add a new justification in false-positive-.json:: > + > +|{ > +| "version": "1.0", > +| "content": [ > +| { > +| "id": "SAF-0-false-positive-", > +| "violation-id": "", > +| "tool-version": "", > +| "name": "R20.7 [...]", > +| "text": "[...]" > +| }, > +| { > +| "id": "SAF-1-false-positive-", > +| "violation-id": "", > +| "tool-version": "", > +| "name": "Sentinel", > +| "text": "Next ID to be used" > +| } > +| ] > +|} > + > +To document a finding in false-positive-.json, just add another block > +{[...]} before the sentinel block, using the id contained in the sentinel block > +and increment by one the number contained in the id of the sentinel block. > + > +Here is an explanation of the fields inside an object of the "content" array: > + - id: it has the same meaning as in the "safe" justification schema. > + It tells the tool to substitute a Xen in-code comment having this structure: > + /* SAF-0-false-positive- [...] \*/ > + - violation-id: its value is a string containing the proprietary id > + corresponding to the finding, for example when is coverity, the Xen > + tool will translate the Xen in-code coment in this way: > + /* SAF-0-false-positive-coverity [...] \*/ -> /* coverity[misra_c_2012_rule_20_7_violation] \*/ > + if the object doesn't have a value, then the corresponding in-code comment > + won't be translated. > + - tool-version: the version of the tool affected by the false positive, if it > + is discovered in more than one version, this string can be a range > + (eg. 2.7 - 3.0) > + - name, text: they have the same meaning as in the "safe" justification schema. > + > + > +Justification example > +--------------------- > + > +Here an example of the usage of the in-code comment tags to suppress a finding > +for the Rule 8.6: > + > +Eclair reports it in its web report, file xen/include/xen/kernel.h, line 68: > + > +| MC3R1.R8.6 for program 'xen/xen-syms', variable '_start' has no definition > + > +Also coverity reports it, here is an extract of the finding: > + > +| xen/include/xen/kernel.h:68: > +| 1. misra_c_2012_rule_8_6_violation: Function "_start" is declared but never > + defined. > + > +The analysers are complaining because we have this in xen/include/xen/kernel.h > +at line 68:: > + > +| extern char _start[], _end[], start[]; > + > +Those are symbols exported by the linker, hence we will need to have a proper > +deviation for this finding. > + > +We will prepare our entry in the safe.json database:: > + > +|{ > +| "version": "1.0", > +| "content": [ > +| { > +| [...] > +| }, > +| { > +| "id": "SAF-1-safe", > +| "analyser": { > +| "eclair": "MC3R1.R8.6", > +| "coverity": "misra_c_2012_rule_8_6_violation" > +| }, > +| "name": "Rule 8.6: linker script defined symbols", > +| "text": "It is safe to declare this symbol because it is defined in the linker script." > +| }, > +| { > +| "id": "SAF-2-safe", > +| "analyser": {}, > +| "name": "Sentinel", > +| "text": "Next ID to be used" > +| } > +| ] > +|} > + > +And we will use the proper tag above the violation line:: > + > +| /* SAF-1-safe R8.6 linker defined symbols */ > +| extern char _start[], _end[], start[]; > + > +This entry will fix also the violation on _end and start, because they are on > +the same line and the same "violation ID". > + > +Also, the same tag can be used on other symbols from the linker that are > +declared in the codebase, because the justification holds for them too. > diff --git a/docs/misra/false-positive-coverity.json b/docs/misra/false-positive-coverity.json > new file mode 100644 > index 000000000000..462448414f80 > --- /dev/null > +++ b/docs/misra/false-positive-coverity.json > @@ -0,0 +1,12 @@ > +{ > + "version": "1.0", > + "content": [ > + { > + "id": "SAF-0-false-positive-coverity", > + "violation-id": "", > + "tool-version": "", > + "name": "Sentinel", > + "text": "Next ID to be used" > + } > + ] > +} > diff --git a/docs/misra/false-positive-eclair.json b/docs/misra/false-positive-eclair.json > new file mode 100644 > index 000000000000..1d6ea5d7f045 > --- /dev/null > +++ b/docs/misra/false-positive-eclair.json > @@ -0,0 +1,12 @@ > +{ > + "version": "1.0", > + "content": [ > + { > + "id": "SAF-0-false-positive-eclair", > + "violation-id": "", > + "tool-version": "", > + "name": "Sentinel", > + "text": "Next ID to be used" > + } > + ] > +} > diff --git a/docs/misra/safe.json b/docs/misra/safe.json > new file mode 100644 > index 000000000000..e079d3038120 > --- /dev/null > +++ b/docs/misra/safe.json > @@ -0,0 +1,11 @@ > +{ > + "version": "1.0", > + "content": [ > + { > + "id": "SAF-0-safe", > + "analyser": {}, > + "name": "Sentinel", > + "text": "Next ID to be used" > + } > + ] > +} > diff --git a/docs/misra/xen-static-analysis.rst b/docs/misra/xen-static-analysis.rst > new file mode 100644 > index 000000000000..5b886474d4a0 > --- /dev/null > +++ b/docs/misra/xen-static-analysis.rst > @@ -0,0 +1,54 @@ > +.. SPDX-License-Identifier: CC-BY-4.0 > + > +Xen static analysis > +=================== > + > +The Xen codebase integrates some scripts and tools that helps the developer to > +perform static analysis of the code, currently Xen supports three analysis tool > +that are eclair, coverity and cppcheck. > +The Xen tree has a script (xen-analysis.py) available to ease the analysis > +process and it integrates a way to suppress findings on these tools (only Eclair > +and Coverity are currently supported by the script), please check the > +documenting-violation.rst document to know more about it. > + > +Analyse Xen with Coverity or Eclair > +----------------------------------- > + > +The xen-analysis.py script has two arguments to select which tool is used for > +the analysis: > + > + - xen-analysis.py --run-coverity -- [optional make arguments] > + - xen-analysis.py --run-eclair -- [optional make arguments] > + > +For example when using Coverity to analyse a Xen build obtained by passing these > +arguments to the make system: XEN_TARGET_ARCH=arm64 > +CROSS_COMPILE=aarch64-linux-gnu-, the optional make arguments passed to > +xen-analysis.py must be the same and the command below should be passed to > +Coverity in its build phase: > + > + - xen-analysis.py --run-coverity -- XEN_TARGET_ARCH=arm64 > + CROSS_COMPILE=aarch64-linux-gnu- > + > +Which tells to the script to prepare the codebase for an analysis by Coverity > +and forwards the make arguments to the make build invocation. > + > +When invoking the script, the procedure below will be followed: > + > + 1. Find which files among \*.c and \*.h has any in-code comment as > + /* SAF-X-[...] \*/, the meaning of these comments is explained in > + documenting-violation.rst. > + Save the files obtained as .safparse and generate files where > + the special in-code comments above are substituted with the proprietary > + in-code comment used by the selected analysis tool. The safe.json and > + false-positive-.json text file database are used to link each Xen tag > + to the right proprietary in-code comment. > + 2. Now Xen compilation starts using every supplied > + at the script invocation. Coverity and Eclair are capable of intercepting > + the compiler running from make to perform their analysis without > + instrumenting the makefile. > + 3. As final step every .safparse file are reverted back as and > + every artifact related to the analysis will be cleaned. > + This step is performed even in case any of the previous step fail, to skip > + this step, call the script adding the --no-clean argument, but before > + running again the script, call it with the --clean-only argument, that will > + execute only this cleaning step. > diff --git a/xen/scripts/xen-analysis.py b/xen/scripts/xen-analysis.py > new file mode 100755 > index 000000000000..b5d9ef1862c9 > --- /dev/null > +++ b/xen/scripts/xen-analysis.py > @@ -0,0 +1,31 @@ > +#!/usr/bin/env python3 > + > +import sys > +from xen_analysis import settings, generic_analysis > +from xen_analysis.generic_analysis import * > + > + > +def main(argv): > + ret_code = 0 > + settings.parse_commandline(argv) > + try: > + if settings.step_parse_tags: > + generic_analysis.parse_xen_tags() > + if settings.step_build_xen: > + generic_analysis.build_xen() > + except (ParseTagPhaseError, BuildPhaseError) as e: > + print("ERROR: {}".format(e)) > + if hasattr(e, "errorcode"): > + ret_code = e.errorcode > + finally: > + if settings.step_clean_analysis: > + e = generic_analysis.clean_analysis_artifacts() > + if e: > + print("ERROR: {}".format(e)) > + ret_code = 1 > + > + sys.exit(ret_code) > + > + > +if __name__ == "__main__": > + main(sys.argv[1:]) > diff --git a/xen/scripts/xen_analysis/__init__.py b/xen/scripts/xen_analysis/__init__.py > new file mode 100644 > index 000000000000..e69de29bb2d1 > diff --git a/xen/scripts/xen_analysis/generic_analysis.py b/xen/scripts/xen_analysis/generic_analysis.py > new file mode 100644 > index 000000000000..0b470c4ecf7d > --- /dev/null > +++ b/xen/scripts/xen_analysis/generic_analysis.py > @@ -0,0 +1,93 @@ > +#!/usr/bin/env python3 > + > +import os, subprocess > +from . import settings, utils, tag_database > + > +class ParseTagPhaseError(Exception): > + pass > + > +class BuildPhaseError(Exception): > + pass > + > +class CleanPhaseError(Exception): > + pass > + > + > +def parse_xen_tags(): > + # Load the database for the Xen tags > + subs_list = tag_database.load_tag_database( > + settings.analysis_tool, > + [settings.repo_dir + "/docs/misra/safe.json"] > + ) > + subs_list = tag_database.load_tag_database( > + settings.analysis_tool, > + [settings.repo_dir + "/docs/misra/false-positive-{}.json" > + .format(settings.analysis_tool)], > + subs_list, > + "false-positive" > + ) > + > + # Create outdir if it doesn't exists > + os.makedirs(settings.outdir, exist_ok=True) > + > + # The following lambda function will return a file if it contains lines with > + # a comment containing "SAF--{safe|false-positive-}" on a > + # single line. > + grep_action = lambda x: utils.grep(x, > + tag_database.get_xen_tag_comment_regex( > + settings.analysis_tool) > + ) > + # Look for a list of .h/.c files that matches the condition above > + parse_file_list = utils.recursive_find_file(settings.xen_dir, r'.*\.[ch]$', > + grep_action) > + > + for entry in parse_file_list: > + file = entry["file"] > + bkp_file = file + ".safparse" > + if os.path.isfile(bkp_file): > + raise ParseTagPhaseError( > + "Found {}, please check the integrity of {}" > + .format(bkp_file,file) > + ) > + os.rename(file, bkp_file) > + time_bkp_file = os.stat(bkp_file) > + # Create from .safparse but with the Xen tag parsed > + tag_database.substitute_tags(settings.analysis_tool, bkp_file, entry, > + subs_list) > + # Set timestamp for file equal to bkp_file, so that if the file is > + # modified during the process by the user, we can catch it > + os.utime(file, (time_bkp_file.st_atime, time_bkp_file.st_mtime)) > + > + > +def build_xen(): > + try: > + subprocess.run( > + "make -C {} {} build" > + .format(settings.xen_dir, settings.make_forward_args), > + shell=True, check=True > + ) > + except (subprocess.CalledProcessError, subprocess.SubprocessError) as e: > + excp = BuildPhaseError( > + "Build error occured when running:\n{}".format(e.cmd) > + ) > + excp.errorcode = e.returncode if hasattr(e, 'returncode') else 1 > + raise excp > + > + > +def clean_analysis_artifacts(): > + safparse_files = utils.recursive_find_file(settings.xen_dir, > + r'.*.safparse$') > + for original_file in safparse_files: > + # This commands strips the .safparse extension, leaving > + parsed_file_path = os.path.splitext(original_file)[0] > + mtime_original_file = os.stat(original_file).st_mtime > + mtime_parsed_file = os.stat(parsed_file_path).st_mtime > + if mtime_original_file != mtime_parsed_file: > + return CleanPhaseError( > + "The file {} was modified during the analysis " > + "procedure, it is impossible now to restore from the " > + "content of {}, please handle it manually" > + .format(parsed_file_path, original_file) > + ) > + # Replace .safparse to > + os.replace(original_file, parsed_file_path) > diff --git a/xen/scripts/xen_analysis/settings.py b/xen/scripts/xen_analysis/settings.py > new file mode 100644 > index 000000000000..947dfa2d50af > --- /dev/null > +++ b/xen/scripts/xen_analysis/settings.py > @@ -0,0 +1,97 @@ > +#!/usr/bin/env python3 > + > +import sys, re, os > + > +module_dir = os.path.dirname(os.path.realpath(__file__)) > +xen_dir = os.path.realpath(module_dir + "/../..") > +repo_dir = os.path.realpath(xen_dir + "/..") > +tools_dir = os.path.realpath(xen_dir + "/tools") > + > +step_parse_tags = True > +step_build_xen = True > +step_clean_analysis = True > + > +target_build = False > +target_clean = False > + > +analysis_tool = "" > +make_forward_args = "" > +outdir = xen_dir > + > + > +def help(): > + msg=""" > +Usage: {} [OPTION] ... [-- [make arguments]] > + > +This script runs the analysis on the Xen codebase. > + > +Options: > + --build-only Run only the commands to build Xen with the optional make > + arguments passed to the script > + --clean-only Run only the commands to clean the analysis artifacts > + -h, --help Print this help > + --no-build Skip the build Xen phase > + --no-clean Don\'t clean the analysis artifacts on exit > + --run-coverity Run the analysis for the Coverity tool > + --run-eclair Run the analysis for the Eclair tool > +""" > + print(msg.format(sys.argv[0])) > + > + > +def parse_commandline(argv): > + global analysis_tool > + global make_forward_args > + global outdir > + global step_parse_tags > + global step_build_xen > + global step_clean_analysis > + global target_build > + global target_clean > + forward_to_make = False > + for option in argv: > + if forward_to_make: > + # Intercept outdir > + outdir_regex = re.match("^O=(.*)$", option) > + if outdir_regex: > + outdir = outdir_regex.group(1) > + # Forward any make arguments > + make_forward_args = make_forward_args + " " + option > + elif option == "--build-only": > + target_build = True > + elif option == "--clean-only": > + target_clean = True > + elif (option == "--help") or (option == "-h"): > + help() > + sys.exit(0) > + elif option == "--no-build": > + step_build_xen = False > + elif option == "--no-clean": > + step_clean_analysis = False > + elif (option == "--run-coverity") or (option == "--run-eclair"): > + analysis_tool = option[6:] > + elif option == "--": > + forward_to_make = True > + else: > + print("Invalid option: {}".format(option)) > + help() > + sys.exit(1) > + > + if target_build and target_clean: > + print("--build-only is not compatible with --clean-only argument.") > + sys.exit(1) > + > + if target_clean: > + step_parse_tags = False > + step_build_xen = False > + step_clean_analysis = True > + return > + > + if analysis_tool == "": > + print("Please specify one analysis tool.") > + help() > + sys.exit(1) > + > + if target_build: > + step_parse_tags = False > + step_build_xen = True > + step_clean_analysis = False > diff --git a/xen/scripts/xen_analysis/tag_database.py b/xen/scripts/xen_analysis/tag_database.py > new file mode 100644 > index 000000000000..ca374bbb62dd > --- /dev/null > +++ b/xen/scripts/xen_analysis/tag_database.py > @@ -0,0 +1,109 @@ > +#!/usr/bin/env python3 > + > +import re, json > + > +class TagDatabaseError(Exception): > + pass > + > +# This is the dictionary for the rules that translates to proprietary comments: > +# - cppcheck: /* cppcheck-suppress[id] */ > +# - coverity: /* coverity[id] */ > +# - eclair: /* -E> hide id 1 "" */ > +# Add entries to support more analyzers > +tool_syntax = { > + "cppcheck":"cppcheck-suppress[VID]", > + "coverity":"coverity[VID]", > + "eclair":"-E> hide VID 1 \"\"" > +} > + > + > +def get_xen_tag_index_type_regex(tool): > + return r'^SAF-(\d+)-(safe|false-positive-' + tool + ')$' > + > + > +def get_xen_tag_comment_regex(tool): > + return r'^[ \t]*/\* +(SAF-\d+-(?:safe|false-positive-' + tool + ')).*\*/$' > + > + > +# Returns a data structure containing dictionaries for safe and false-positive-* > +# Xen tags, the key is the unique index of the tag and the content is the > +# proprietary in-code comment to be used when the tag is found in the codebase > +def load_tag_database(tool, input_files, data_struct = None, schema = "safe"): > + ret = data_struct if data_struct is not None else { > + "safe": {}, > + "false-positive-" + tool: {} > + } > + database = [] > + > + # Open all input files > + for file in input_files: > + try: > + with open(file, "rt") as handle: > + content = json.load(handle) > + database = database + content['content'] > + except json.JSONDecodeError as e: > + raise TagDatabaseError("JSON decoding error in file {}: {}" > + .format(file, e)) > + except Exception as e: > + raise TagDatabaseError("Can't open file {}: {}" > + .format(file, e)) > + > + for entry in database: > + # If the false-positive schema is used, check the proprietary id in the > + # 'violation-id' field, otherwise rely on the "safe" schema. > + if schema == "false-positive": > + proprietary_id = entry['violation-id'] > + elif tool in entry['analyser']: > + proprietary_id = entry['analyser'][tool] > + else: > + proprietary_id = "" > + if proprietary_id != "": > + comment=tool_syntax[tool].replace("VID",proprietary_id) > + # Regex to capture the index of the Xen tag and the schema > + xen_tag = re.compile(get_xen_tag_index_type_regex(tool))\ > + .match(entry["id"]) > + if xen_tag and xen_tag.group(1) and xen_tag.group(2): > + # Save in safe or false-positive-* the key {#id: "comment"} > + id_number = int(xen_tag.group(1)) > + key = xen_tag.group(2) > + ret[key][id_number] = "/* {} */\n".format(comment) > + else: > + raise TagDatabaseError( > + "Error in database file, entry {} has unexpected " > + "format.".format(entry["id"]) > + ) > + > + return ret > + > + > +def substitute_tags(tool, input_file, grep_struct, subs_rules): > + try: > + with open(grep_struct["file"], "wt") as outfile: > + > + try: > + with open(input_file, "rt") as infile: > + parsed_content = infile.readlines() > + except Exception as e: > + raise TagDatabaseError("Issue with reading file {}: {}" > + .format(input_file, e)) > + > + # grep_struct contains the line number where the comments are, the > + # line number starts from 1 but in the array the first line is zero. > + # For every line where there is a Xen tag comment, get the Xen tag > + # that is in the capture group zero, extract from the Xen tag the > + # unique index and the type (safe, false-positive-*) and with those > + # information access the subs_rules dictionary to see if there is > + # a match > + for line_number in grep_struct["matches"]: > + xen_tag = grep_struct["matches"][line_number][0] > + xen_tag_regex_obj = re.compile( > + get_xen_tag_index_type_regex(tool)).match(xen_tag) > + id_number = int(xen_tag_regex_obj.group(1)) > + key = xen_tag_regex_obj.group(2) > + if id_number in subs_rules[key]: > + parsed_content[line_number-1] = subs_rules[key][id_number] > + > + outfile.writelines(parsed_content) > + except Exception as e: > + raise TagDatabaseError("Issue with writing file {}: {}" > + .format(grep_struct["file"], e)) > diff --git a/xen/scripts/xen_analysis/utils.py b/xen/scripts/xen_analysis/utils.py > new file mode 100644 > index 000000000000..a912d812c3df > --- /dev/null > +++ b/xen/scripts/xen_analysis/utils.py > @@ -0,0 +1,37 @@ > +#!/usr/bin/env python3 > + > +import os, re > + > + > +def grep(filepath, regex): > + regObj = re.compile(regex) > + res = { "file": filepath, "matches": {} } > + try: > + with open(filepath, "rt") as f: > + line_number = 1 > + for line in f: > + match = regObj.match(line) > + if match: > + res["matches"][line_number] = match.groups() > + line_number = line_number + 1 > + except Exception as e: > + print("WARNING: Can't open {}: {}".format(filepath, e)) > + > + # Return filename and line matches if there are > + return res if res["matches"] else {} > + > + > +def recursive_find_file(path, filename_regex, action = None): > + filename_reg_obj = re.compile(filename_regex) > + res = [] > + for root, dirs, fnames in os.walk(path): > + for fname in fnames: > + if filename_reg_obj.match(fname): > + if action is None: > + res.append(os.path.join(root, fname)) > + else: > + out = action(os.path.join(root, fname)) > + if out: > + res.append(out) > + > + return res > -- > 2.17.1 > From xen-devel-bounces@lists.xenproject.org Tue Nov 29 01:55:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 01:55:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449181.705807 (Exim 4.92) (envelope-from ) id 1ozpqV-0007j8-PQ; Tue, 29 Nov 2022 01:55:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449181.705807; Tue, 29 Nov 2022 01:55:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozpqV-0007j1-MM; Tue, 29 Nov 2022 01:55:39 +0000 Received: by outflank-mailman (input) for mailman id 449181; Tue, 29 Nov 2022 01:55:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozpqU-0007is-1C for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 01:55:38 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea4fa95e-6f88-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 02:55:36 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2C3476152A; Tue, 29 Nov 2022 01:55:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0368C433C1; Tue, 29 Nov 2022 01:55:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea4fa95e-6f88-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669686934; bh=MNnASlWjTtEwJtaW9e2PM9nFxBupfJtU/G26N3CYWfY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=oYaA3edtkgnlSX4Jg78TRGJc1UOuK2BFteSQRsutglDzaEmoRcjeKMsPxKprMNeDt fY667ar8W2IRQ/lsPftt3fWg9KM97f+PNRWTLjpnYJCJHq985i2k8q9MBEQvS/mjgo ExDOAswtw8o+IWPPV8n6YjDtoYoJ3JsGJJI8Nve6dwAok6OgqFCRuetBP5YVFzQELk IHbSeDBmC0wId3ur+eFPb3GLIaMt7/WkGirjIf0ahrpDnSSMZQ8GbSeva/MkgP4Rb4 yArCnBWq3jXgnIHzynYZuWGbmKnmrnWiB1cKmc1fdzDbL75K9PiDkTtgICfUvhVYzE KqSIqYPLQrnZw== Date: Mon, 28 Nov 2022 17:55:31 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h In-Reply-To: <20221128141006.8719-5-luca.fancellu@arm.com> Message-ID: References: <20221128141006.8719-1-luca.fancellu@arm.com> <20221128141006.8719-5-luca.fancellu@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 28 Nov 2022, Luca Fancellu wrote: > Eclair and Coverity found violation of the MISRA rule 8.6 for the > symbols _start, _end, start, _stext, _etext, _srodata, _erodata, > _sinittext, _einittext which are declared in > xen/include/xen/kernel.h. > All those symbols are defined by the liker script so we can deviate > from the rule 8.6 for these cases. > > Signed-off-by: Luca Fancellu Reviewed-by: Stefano Stabellini > --- > docs/misra/safe.json | 9 +++++++++ > xen/include/xen/kernel.h | 4 ++++ > 2 files changed, 13 insertions(+) > > diff --git a/docs/misra/safe.json b/docs/misra/safe.json > index e079d3038120..e3c8a1d8eb36 100644 > --- a/docs/misra/safe.json > +++ b/docs/misra/safe.json > @@ -3,6 +3,15 @@ > "content": [ > { > "id": "SAF-0-safe", > + "analyser": { > + "eclair": "MC3R1.R8.6", > + "coverity": "misra_c_2012_rule_8_6_violation" > + }, > + "name": "Rule 8.6: linker script defined symbols", > + "text": "It is safe to declare this symbol because it is defined in the linker script." > + }, > + { > + "id": "SAF-1-safe", > "analyser": {}, > "name": "Sentinel", > "text": "Next ID to be used" > diff --git a/xen/include/xen/kernel.h b/xen/include/xen/kernel.h > index 8cd142032d3b..f1a7713784fc 100644 > --- a/xen/include/xen/kernel.h > +++ b/xen/include/xen/kernel.h > @@ -65,24 +65,28 @@ > 1; \ > }) > > +/* SAF-0-safe */ > extern char _start[], _end[], start[]; > #define is_kernel(p) ({ \ > char *__p = (char *)(unsigned long)(p); \ > (__p >= _start) && (__p < _end); \ > }) > > +/* SAF-0-safe */ > extern char _stext[], _etext[]; > #define is_kernel_text(p) ({ \ > char *__p = (char *)(unsigned long)(p); \ > (__p >= _stext) && (__p < _etext); \ > }) > > +/* SAF-0-safe */ > extern const char _srodata[], _erodata[]; > #define is_kernel_rodata(p) ({ \ > const char *__p = (const char *)(unsigned long)(p); \ > (__p >= _srodata) && (__p < _erodata); \ > }) > > +/* SAF-0-safe */ > extern char _sinittext[], _einittext[]; > #define is_kernel_inittext(p) ({ \ > char *__p = (char *)(unsigned long)(p); \ > -- > 2.17.1 > From xen-devel-bounces@lists.xenproject.org Tue Nov 29 01:56:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 01:56:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449183.705818 (Exim 4.92) (envelope-from ) id 1ozpqv-0008Ak-1u; Tue, 29 Nov 2022 01:56:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449183.705818; Tue, 29 Nov 2022 01:56:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozpqu-0008Ad-VJ; Tue, 29 Nov 2022 01:56:04 +0000 Received: by outflank-mailman (input) for mailman id 449183; Tue, 29 Nov 2022 01:56:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozpqt-0007is-BQ for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 01:56:03 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f9ff310d-6f88-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 02:56:02 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5BFF5B80F79; Tue, 29 Nov 2022 01:56:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B692FC433C1; Tue, 29 Nov 2022 01:55:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9ff310d-6f88-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669686960; bh=jO2TGb8lksfFf8FZVpiplTYgamp7/GweM3sCOVZHZGM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tHDskdqJUKdx9veIrdH7owuqlsP2/z3W272Mfb8yglc4IzqVzE//Qju4TGMyu4TVb 9vKqnfAKAjv3tNCPd1fE7bD/XmWNibO9Yz2PXBtGY4dEbssfs1PCh7JwuCQl4ZHoYh MsrV9EzMxaI4lgqgKrNcqJvy3Xhd74Fe0eUt91AO+AcmlxqToosre/bOryvJlYOPoA q5P9OMdofw+Sg5w8pcgZ4CN7bSkZhO1rIm3z3B4Gm0V/w2tedY7t1M7yAThIIO1MP+ TM1GfUOqUcafKRLuaCUBjcwD2wUr3yavsmMLwUB3VCoh7fLaAHA/0Z8a8rPP7KqTjV etBntbTlKZAmA== Date: Mon, 28 Nov 2022 17:55:57 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH 0/4] Static analyser finding deviation In-Reply-To: <20221128141006.8719-1-luca.fancellu@arm.com> Message-ID: References: <20221128141006.8719-1-luca.fancellu@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 28 Nov 2022, Luca Fancellu wrote: > This serie introduces a way to suppress a static analyser finding providing a > proper justification for it. > The process is explained in the docs/misra/documenting-violations.rst document > that this serie will provide. > The tools currently supported are eclair, coverity and cppcheck, but the design > is open to support many other static analysis tool. > > The changes are split between the first two patches to reduce the review effort, > the first patch is introducing the deviation process for the eclair and coverity > tools, this is because their analysis system is similar. > > The second patch is introducing the same deviation process for cppcheck, > modifying the current way it is called from the makefile and improving its > analysis. > > The third patch is a fix for a tool used for cppcheck and the fourth patch > is an example of how a deviation can be applied for some MISRA findings. I tried testing this series with: # scripts/xen-analysis.py --build-only --cppcheck-html --run-cppcheck --cppcheck-bin=/local/repos/cppcheck/cppcheck --cppcheck-html-bin=/local/repos/cppcheck/htmlreport/cppcheck-htmlreport But I get this error: ERROR: Can't find cppcheck version or version is not 2.7 Note that my cppcheck is 2.7.4: # ./cppcheck --version Cppcheck 2.7.4 After removing the version check in cppcheck_analysis.py, the process starts correctly. Also, where is the output html report created by cppcheck-html by default? From xen-devel-bounces@lists.xenproject.org Tue Nov 29 01:59:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 01:59:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449190.705829 (Exim 4.92) (envelope-from ) id 1ozpuN-0000Sw-IG; Tue, 29 Nov 2022 01:59:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449190.705829; Tue, 29 Nov 2022 01:59:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozpuN-0000Sp-F7; Tue, 29 Nov 2022 01:59:39 +0000 Received: by outflank-mailman (input) for mailman id 449190; Tue, 29 Nov 2022 01:59:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozpuM-0000Sj-GN for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 01:59:38 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78c8ebc8-6f89-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 02:59:35 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 470565C00C1; Mon, 28 Nov 2022 20:59:34 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 28 Nov 2022 20:59:34 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Nov 2022 20:59:33 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78c8ebc8-6f89-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1669687174; x= 1669773574; bh=bCzCW4/+DVi1mzJ0xQmcTMOHmu4kfPgKqlGu0numccY=; b=U RmYDHJ3F7x35fkfLBKI1Yo7XVUTRRsN45Ny5R/P3xVK3+G0SBNwwIHAcqpMuRKdQ oWxfudlkLYSzENGbXPCCcNO5ekFGmsd6aPoNy7AaMB9FqtCymC46XybioL8bgckH /6CIO84fjtTQ0nVg2Zh5FHy4ilJFX4eS0tv23Y5jorCPXWJdHfLjuzdwHw8JpiHP bLLQGV2pNBlVNdfg/EmDh3zO5I9VOM+YTjwSCm92rfLmegjIjh+MayTgjDDB03WS 5c4wUeb2wa9IX6pcPWYm8u1tBK1ismm0DPcot1aTE52IDMlslGQbsJoBOGJGR5/6 nnMcAfcYSVLJOvksNY69g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1669687174; x=1669773574; bh=bCzCW4/+DVi1mzJ0xQmcTMOHmu4k fPgKqlGu0numccY=; b=NIJS1wT1ugY8hKu5vKDZbYa4OE4PqOrDqCRC5w+GcxXq aFS2t6g9r87n2OeMeAhK01dyokuD8pPfNaNthqDB4oQMB92nLotQ3aPIWL4owj5h 7qeu9XOcv1WZRgo6uBMn00VmZENQAxl+NjPEpFSj3cVsOqlWnoX2AqBkoLKUy5mz Kl1cBr931HsTm4dyYvAaFbF9dQikX23UJQtAV3GMR+Z0DOa8OrTRegTKoNBtUijy hLyq3b0zMgctvuAA3O6adHmIvH3Xkz7dptacZ7QxI7rOmqpqDibR4j7ouVa6sET3 kRYGd91pkl7LX+1kW8YiKNuV9D2cIvTf+YMf4hIDQA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrjeefgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvvefhlefhhfetledvgefhvddukeet jeffvdeigeeiteetjefhjefgvdelveehgfenucffohhmrghinhepkhgvrhhnvghlrdhorh hgpdhgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtoh hm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Mon, 28 Nov 2022 20:59:28 -0500 From: Demi Marie Obenour To: Alex Deucher Cc: christian.koenig@amd.com, Xen developer discussion , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: AMD GPU problems under Xen Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wz46AtdtDi0AOdbm" Content-Disposition: inline In-Reply-To: --wz46AtdtDi0AOdbm Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 28 Nov 2022 20:59:28 -0500 From: Demi Marie Obenour To: Alex Deucher Cc: christian.koenig@amd.com, Xen developer discussion , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: AMD GPU problems under Xen On Mon, Nov 28, 2022 at 11:18:00AM -0500, Alex Deucher wrote: > On Mon, Nov 28, 2022 at 2:18 AM Demi Marie Obenour > wrote: > > > > Dear Christian: > > > > What is the status of the AMDGPU work for Xen dom0? That was mentioned= in > > https://lore.kernel.org/dri-devel/b2dec9b3-03a7-e7ac-306e-1da024af8982@= amd.com/ > > and there have been bug reports to Qubes OS about problems with AMDGPU > > under Xen (such as https://github.com/QubesOS/qubes-issues/issues/7648). >=20 > I would say it's a work in progress. It depends what GPU you have > and what type of xen setup you are using (PV vs PVH, etc.). The current situation is: - dom0 is PV. - VMs with assigned PCI devices are HVM and use a Linux-based stubdomain QEMU does not run in dom0. - Everything else is PVH. In the future, I believe the goal is to move away from PV and HVM in favor of PVH, though HVM support will remain for compatibility with guests (such as Windows) that need emulated devices. > In general, your best bet currently is dGPU add in boards because they > are largely self contained. The main problem is that for the trusted GUI to work, there needs to be at least one GPU attached to a trusted VM, such as the host or a dedicated GUI VM. That VM will typically not be running graphics- intensive workloads, so the compute power of a dGPU is largely wasted. SR-IOV support would help with that, but the only GPU vendor with open source SR-IOV support is Intel and it is still not upstream. I am also not certain if the support extends to Arc dGPUs. > APUs and platforms with integrated dGPUs > are a bit more complicated as they tend to have more platform > dependencies like ACPI tables and methods in order for the driver to > be able to initialize the hardware properly. Is Xen dom0/domU support for such GPUs being worked on? Is there an estimate as to when the needed support will be available upstream? This is mostly directed at Christian and other people who work for hardware vendors. > Additionally, GPUs map a > lot of system memory so bounce buffers aren't really viable. You'll > really need IOMMU, Qubes OS already needs an IOMMU so that is not a concern. =20 --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --wz46AtdtDi0AOdbm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmOFZ4MACgkQsoi1X/+c IsHybQ//VsSMy5gMOlPDvJX8SVGfDZwZ0OEKd3sBJjaGIsMRg4BtgxkDu1qH2oKw cV0ADVylb7KnBZtpGDeeAChhi7TQ8Jty8OKgzTuxQ/lkDOVJo1rZ5mxe70kVDfww 6Vyn9kWkG0P1ht0IZqpqwjTis0yrqvlmwauEcxmZtWMo/wL/EZwoPSCadF6ch3Mv JGvIbiXdNbVRVQAIU0wyl/jYvXDxGxgtcZWWChp6RoHZfu7zzjbUY5UirKtIRBbH q/lyplg3VjDkvd6iSwu7SbfgorjmFa/bIRL5JAL4QQGmyUYORjbsozXpTA8gzQt0 8dEZzD2NRcFX+6m10m45sQKjKY7FWoeWlOIRzag/5uYTpe0ay9gu5FNjVlLWzgQp Hyml5L8MutGMp0+Zy7dSwdrZXU4iAVMctNDSDIPKkKngXG2fcHgNc6QeaHbX075z FbjPyItnZt5XnUMkUpdvElJYvKJkzVb9WkzOUgnN8j9Nmm+h8T1sQFzNF4i/Mlv/ 9eywtNvN4jn9Qtb4DaRz3n4Gtactx3sjNcaaqK4MG6rYFKuW0FghEzdz2W1Sgoil kIVyuaTwcbq+SL+m8PlmTnL765/tKyV6pWWvaqiDsxm0Y8bSrvnumPCtnzADdn1F Eb71xoPQH8Idhrftp+DjU2O7TaOPogKg5e8iPkBUm8hQCSltDpE= =rqwd -----END PGP SIGNATURE----- --wz46AtdtDi0AOdbm-- From xen-devel-bounces@lists.xenproject.org Tue Nov 29 02:10:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 02:10:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449197.705839 (Exim 4.92) (envelope-from ) id 1ozq4O-0002Q2-G3; Tue, 29 Nov 2022 02:10:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449197.705839; Tue, 29 Nov 2022 02:10:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozq4O-0002Pv-DT; Tue, 29 Nov 2022 02:10:00 +0000 Received: by outflank-mailman (input) for mailman id 449197; Tue, 29 Nov 2022 02:09:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozq4N-0002Pl-AV; Tue, 29 Nov 2022 02:09:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozq4N-0007tG-6E; Tue, 29 Nov 2022 02:09:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozq4M-0006qH-K8; Tue, 29 Nov 2022 02:09:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozq4M-0004pO-HL; Tue, 29 Nov 2022 02:09:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zWbRD3G/NNSElmLbWZWdJZKWWYdOMyEz/51xLz8I62g=; b=do1xA0elq0osYQpBjFIzy+qTR4 cbJGfOmKd5S6tDp1Dkgsqtv4zKpZfY7oeauxrS5W6Zngzw3lCVW1arQdNAzQqKIFtLB4uLozee2WV 6d/C5DDW3UFcVTtdZ7sZ5Z3Q0QPl92/RSr7PTy++CXgT9SQXmM0GHP2WVFUFcMvB51wE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174982: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b7b275e60bcd5f89771e865a8239325f86d9927d X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 29 Nov 2022 02:09:58 +0000 flight 174982 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174982/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux b7b275e60bcd5f89771e865a8239325f86d9927d baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 52 days Failing since 173470 2022-10-08 06:21:34 Z 51 days 99 attempts Testing same since 174975 2022-11-27 23:39:38 Z 1 days 3 attempts ------------------------------------------------------------ 1906 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 181680 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Nov 29 02:24:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 02:24:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449206.705851 (Exim 4.92) (envelope-from ) id 1ozqIc-00051d-Th; Tue, 29 Nov 2022 02:24:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449206.705851; Tue, 29 Nov 2022 02:24:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozqIc-00051W-Qg; Tue, 29 Nov 2022 02:24:42 +0000 Received: by outflank-mailman (input) for mailman id 449206; Tue, 29 Nov 2022 02:24:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozqIb-00051M-On; Tue, 29 Nov 2022 02:24:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozqIb-0008GR-MD; Tue, 29 Nov 2022 02:24:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozqIb-0007E3-CW; Tue, 29 Nov 2022 02:24:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozqIb-0003lX-By; Tue, 29 Nov 2022 02:24:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rRLzofyZ9JGJ3EQ6zcv4b0aTywNOrkgWmN0xoBWHSO0=; b=hUOnt85b9ppDDv6KfD9JU58fc1 Mg/qvJjwL4ohQujUVVZZU+72OTVHhOPoixBuPDDH82OqKgK8/kdrewvPT2NT2fJkbEj/CiUs6aTM0 nl76yE845tEpgDEmEm0Ts7bGAx7mKjPPbM2s1x3tMuPkoMibDFmHvuvisVQG3QQjMRuo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174983: all pass - PUSHED X-Osstest-Versions-This: ovmf=ae3bc559f98e68983df0a4b223dad7afeb6eee2c X-Osstest-Versions-That: ovmf=d992163da6cb3c6e91c24938ad4b8804227eafd8 From: osstest service owner Date: Tue, 29 Nov 2022 02:24:41 +0000 flight 174983 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174983/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ae3bc559f98e68983df0a4b223dad7afeb6eee2c baseline version: ovmf d992163da6cb3c6e91c24938ad4b8804227eafd8 Last test of basis 174980 2022-11-28 09:10:22 Z 0 days Testing same since 174983 2022-11-29 00:43:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git d992163da6..ae3bc559f9 ae3bc559f98e68983df0a4b223dad7afeb6eee2c -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Nov 29 02:41:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 02:41:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449214.705873 (Exim 4.92) (envelope-from ) id 1ozqYD-0007pv-Fw; Tue, 29 Nov 2022 02:40:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449214.705873; Tue, 29 Nov 2022 02:40:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozqYD-0007po-DG; Tue, 29 Nov 2022 02:40:49 +0000 Received: by outflank-mailman (input) for mailman id 449214; Tue, 29 Nov 2022 02:40:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozqYB-0007ou-Tl for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 02:40:47 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 38b51b13-6f8f-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 03:40:45 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F2E7D6E; Mon, 28 Nov 2022 18:40:50 -0800 (PST) Received: from a015971.shanghai.arm.com (unknown [10.169.188.104]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 65A943F73B; Mon, 28 Nov 2022 18:40:41 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38b51b13-6f8f-11ed-8fd2-01056ac49cbb From: Jiamei Xie To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, jiamei.xie@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v3 1/2] xen/arm: vpl011: emulate non-SBSA registers as WI/RAZ Date: Tue, 29 Nov 2022 10:39:34 +0800 Message-Id: <20221129023935.1576133-2-jiamei.xie@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221129023935.1576133-1-jiamei.xie@arm.com> References: <20221129023935.1576133-1-jiamei.xie@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", Linux SBSA PL011 driver will access PL011 DMACR register in some functions. As chapter "B Generic UART" in "ARM Server Base System Architecture"[1] documentation describes, SBSA UART doesn't support DMA. In current code, when the kernel tries to access DMACR register, Xen will inject a data abort: Unhandled fault at 0xffffffc00944d048 Mem abort info: ESR = 0x96000000 EC = 0x25: DABT (current EL), IL = 32 bits SET = 0, FnV = 0 EA = 0, S1PTW = 0 FSC = 0x00: ttbr address size fault Data abort info: ISV = 0, ISS = 0x00000000 CM = 0, WnR = 0 swapper pgtable: 4k pages, 39-bit VAs, pgdp=0000000020e2e000 [ffffffc00944d048] pgd=100000003ffff803, p4d=100000003ffff803, pud=100000003ffff803, pmd=100000003fffa803, pte=006800009c090f13 Internal error: ttbr address size fault: 96000000 [#1] PREEMPT SMP ... Call trace: pl011_stop_rx+0x70/0x80 tty_port_shutdown+0x7c/0xb4 tty_port_close+0x60/0xcc uart_close+0x34/0x8c tty_release+0x144/0x4c0 __fput+0x78/0x220 ____fput+0x1c/0x30 task_work_run+0x88/0xc0 do_notify_resume+0x8d0/0x123c el0_svc+0xa8/0xc0 el0t_64_sync_handler+0xa4/0x130 el0t_64_sync+0x1a0/0x1a4 Code: b9000083 b901f001 794038a0 8b000042 (b9000041) ---[ end trace 83dd93df15c3216f ]--- note: bootlogd[132] exited with preempt_count 1 /etc/rcS.d/S07bootlogd: line 47: 132 Segmentation fault start-stop-daemon As discussed in [2], this commit makes the access to non-SBSA registers RAZ/WI as an improvement. [1] https://developer.arm.com/documentation/den0094/c/?lang=en [2] https://lore.kernel.org/xen-devel/alpine.DEB.2.22.394.2211161552420.4020@ubuntu-linux-20-04-desktop/ Signed-off-by: Jiamei Xie --- v2 -> v3 - emulate non-SBSA registers as WI/RAZ in default case - update commit message v1 -> v2 - print a message using XENLOG_G_DEBUG when it's write-ignore --- xen/arch/arm/vpl011.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c index 43522d48fd..1bf803fc1f 100644 --- a/xen/arch/arm/vpl011.c +++ b/xen/arch/arm/vpl011.c @@ -414,11 +414,19 @@ static int vpl011_mmio_read(struct vcpu *v, default: gprintk(XENLOG_ERR, "vpl011: unhandled read r%d offset %#08x\n", dabt.reg, vpl011_reg); - return 0; + goto read_as_zero; } return 1; +read_as_zero: + if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; + + VPL011_LOCK(d, flags); + *r = 0; + VPL011_UNLOCK(d, flags); + return 1; + bad_width: gprintk(XENLOG_ERR, "vpl011: bad read width %d r%d offset %#08x\n", dabt.size, dabt.reg, vpl011_reg); @@ -486,10 +494,11 @@ static int vpl011_mmio_write(struct vcpu *v, default: gprintk(XENLOG_ERR, "vpl011: unhandled write r%d offset %#08x\n", dabt.reg, vpl011_reg); - return 0; + goto write_ignore; } write_ignore: + if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; return 1; bad_width: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 29 02:41:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 02:41:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449213.705862 (Exim 4.92) (envelope-from ) id 1ozqY3-0007YV-AW; Tue, 29 Nov 2022 02:40:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449213.705862; Tue, 29 Nov 2022 02:40:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozqY3-0007YO-61; Tue, 29 Nov 2022 02:40:39 +0000 Received: by outflank-mailman (input) for mailman id 449213; Tue, 29 Nov 2022 02:40:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozqY2-0007YF-8U for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 02:40:38 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 33ba0003-6f8f-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 03:40:36 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DD0ABD6E; Mon, 28 Nov 2022 18:40:41 -0800 (PST) Received: from a015971.shanghai.arm.com (unknown [10.169.188.104]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E93C73F73B; Mon, 28 Nov 2022 18:40:32 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33ba0003-6f8f-11ed-91b6-6bf2151ebd3b From: Jiamei Xie To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, jiamei.xie@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v3 0/2] xen/arm: refine vpl011 Date: Tue, 29 Nov 2022 10:39:33 +0800 Message-Id: <20221129023935.1576133-1-jiamei.xie@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi all, This patch is the version 3 for "xen/arm: vpl011: Make access to DMACR write-ignore" [1]. [1] https://patchwork.kernel.org/project/xen-devel/patch/20221122054644.1092173-1-jiamei.xie@arm.com/ Thanks, Jiamei Xie v2 -> v3 - emulate non-SBSA registers as WI/RAZ in default case - update commit message - add a patch to drop redundancy in mmio_write/read v1 -> v2 - print a message using XENLOG_G_DEBUG when it's write-ignore Jiamei Xie (2): xen/arm: vpl011: emulate non-SBSA registers as WI/RAZ xen/arm: vpl011: drop redundancy in mmio_write/read xen/arch/arm/vpl011.c | 59 +++++++++++++++---------------------------- 1 file changed, 20 insertions(+), 39 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 29 02:41:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 02:41:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449223.705884 (Exim 4.92) (envelope-from ) id 1ozqYv-0008UR-Pa; Tue, 29 Nov 2022 02:41:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449223.705884; Tue, 29 Nov 2022 02:41:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozqYv-0008UK-Mm; Tue, 29 Nov 2022 02:41:33 +0000 Received: by outflank-mailman (input) for mailman id 449223; Tue, 29 Nov 2022 02:41:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozqYt-0007YF-OH for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 02:41:31 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 5458ae15-6f8f-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 03:41:30 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8FA52D6E; Mon, 28 Nov 2022 18:41:36 -0800 (PST) Received: from a015971.shanghai.arm.com (unknown [10.169.188.104]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A39943F73B; Mon, 28 Nov 2022 18:41:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5458ae15-6f8f-11ed-91b6-6bf2151ebd3b From: Jiamei Xie To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, jiamei.xie@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v3 2/2] xen/arm: vpl011: drop redundancy in mmio_write/read Date: Tue, 29 Nov 2022 10:39:35 +0800 Message-Id: <20221129023935.1576133-3-jiamei.xie@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221129023935.1576133-1-jiamei.xie@arm.com> References: <20221129023935.1576133-1-jiamei.xie@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit is to drop redundancy in the function vpl011_mmio_write and vpl011_mmio_read: - In vpl011_mmio_read switch block, all cases have a return. So the outside one can be removed. - Each switch case checks access by the same if statments. So we can just use one and put it before the switch block. - The goto label bad_width and read_as_zero is used only once, put the code directly Signed-off-by: Jiamei Xie --- xen/arch/arm/vpl011.c | 66 +++++++++++++------------------------------ 1 file changed, 19 insertions(+), 47 deletions(-) diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c index 1bf803fc1f..80b859baed 100644 --- a/xen/arch/arm/vpl011.c +++ b/xen/arch/arm/vpl011.c @@ -354,11 +354,15 @@ static int vpl011_mmio_read(struct vcpu *v, struct domain *d = v->domain; unsigned long flags; + if ( !vpl011_reg32_check_access(dabt) ) { + gprintk(XENLOG_ERR, "vpl011: bad read width %d r%d offset %#08x\n", + dabt.size, dabt.reg, vpl011_reg); + return 0; + } + switch ( vpl011_reg ) { case DR: - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; - if ( vpl011->backend_in_domain ) *r = vreg_reg32_extract(vpl011_read_data(d), info); else @@ -366,31 +370,23 @@ static int vpl011_mmio_read(struct vcpu *v, return 1; case RSR: - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; - /* It always returns 0 as there are no physical errors. */ *r = 0; return 1; case FR: - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; - VPL011_LOCK(d, flags); *r = vreg_reg32_extract(vpl011->uartfr, info); VPL011_UNLOCK(d, flags); return 1; case RIS: - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; - VPL011_LOCK(d, flags); *r = vreg_reg32_extract(vpl011->uartris, info); VPL011_UNLOCK(d, flags); return 1; case MIS: - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; - VPL011_LOCK(d, flags); *r = vreg_reg32_extract(vpl011->uartris & vpl011->uartimsc, info); @@ -398,40 +394,25 @@ static int vpl011_mmio_read(struct vcpu *v, return 1; case IMSC: - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; - VPL011_LOCK(d, flags); *r = vreg_reg32_extract(vpl011->uartimsc, info); VPL011_UNLOCK(d, flags); return 1; case ICR: - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; - /* Only write is valid. */ return 0; default: gprintk(XENLOG_ERR, "vpl011: unhandled read r%d offset %#08x\n", dabt.reg, vpl011_reg); - goto read_as_zero; - } - - return 1; - -read_as_zero: - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; - - VPL011_LOCK(d, flags); - *r = 0; - VPL011_UNLOCK(d, flags); - return 1; - -bad_width: - gprintk(XENLOG_ERR, "vpl011: bad read width %d r%d offset %#08x\n", - dabt.size, dabt.reg, vpl011_reg); - return 0; + /* Read as zero */ + VPL011_LOCK(d, flags); + *r = 0; + VPL011_UNLOCK(d, flags); + return 1; + } } static int vpl011_mmio_write(struct vcpu *v, @@ -446,14 +427,18 @@ static int vpl011_mmio_write(struct vcpu *v, struct domain *d = v->domain; unsigned long flags; - switch ( vpl011_reg ) + if ( !vpl011_reg32_check_access(dabt) ) { + gprintk(XENLOG_ERR, "vpl011: bad write width %d r%d offset %#08x\n", + dabt.size, dabt.reg, vpl011_reg); + return 0; + } + + switch ( vpl011_reg ) { case DR: { uint32_t data = 0; - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; - vreg_reg32_update(&data, r, info); data &= 0xFF; if ( vpl011->backend_in_domain ) @@ -464,8 +449,6 @@ static int vpl011_mmio_write(struct vcpu *v, } case RSR: /* Nothing to clear. */ - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; - return 1; case FR: @@ -474,8 +457,6 @@ static int vpl011_mmio_write(struct vcpu *v, goto write_ignore; case IMSC: - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; - VPL011_LOCK(d, flags); vreg_reg32_update(&vpl011->uartimsc, r, info); vpl011_update_interrupt_status(v->domain); @@ -483,8 +464,6 @@ static int vpl011_mmio_write(struct vcpu *v, return 1; case ICR: - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; - VPL011_LOCK(d, flags); vreg_reg32_clearbits(&vpl011->uartris, r, info); vpl011_update_interrupt_status(d); @@ -498,14 +477,7 @@ static int vpl011_mmio_write(struct vcpu *v, } write_ignore: - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; return 1; - -bad_width: - gprintk(XENLOG_ERR, "vpl011: bad write width %d r%d offset %#08x\n", - dabt.size, dabt.reg, vpl011_reg); - return 0; - } static const struct mmio_handler_ops vpl011_mmio_handler = { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 29 06:17:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 06:17:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449237.705895 (Exim 4.92) (envelope-from ) id 1oztve-0006CD-Qd; Tue, 29 Nov 2022 06:17:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449237.705895; Tue, 29 Nov 2022 06:17:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oztve-0006C6-Nv; Tue, 29 Nov 2022 06:17:14 +0000 Received: by outflank-mailman (input) for mailman id 449237; Tue, 29 Nov 2022 06:17:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oztvd-0006C0-2g for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 06:17:13 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 735e603e-6fad-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 07:17:09 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 735e603e-6fad-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669702629; h=from:to:cc:subject:date:message-id:mime-version; bh=bmlgSAtGbFtOdTc2GOvO2wyZBv0MSel48KWcSeby+RI=; b=Xw6i+O4cgrcWCHtarq0c5t+cW853QSNfZt/sgzan861QepPP77bM0j5P QTvTP6VbxBI+QcKvXhjfeSCBujz8C8ymMo0nkYUGTIKZ2gZkr8/zADzF7 H6fw4BjI1Fr7xgfTKCHXE+KVgKpKvnY4bHLgTsAw+4x5QgDrjgA7PWpPw I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 86155238 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:/wwzm67QmHsfLrdwyeQQXAxRtJ3HchMFZxGqfqrLsTDasY5as4F+v mIYWW6GafyJNmXwKY10aIu+9U0G6JGHxoNgG1dkrio9Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkR7QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5my cYxczAofhW5xMXsz5SLWMR8jdwKBZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJU0UUrsUIMtWcOOAgnj5NTlZtXqepLYt4niVxwt0uFToGIqLI4HXH54F9qqej m2Y7kPGWgsjDtya4CXC3X+0vf/MuQquDer+E5Xnr6U30TV/3Fc7EBQcWF26ieO0hk63R5RUL El80ikzp6Ea90GxSNT5GRqirxasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQu1 1mUj5bqCCZpvbm9V32Q7PGXoCm0NCxTKnUNDQcCQBcJ7sfLvo4+lFTMQ8xlHarzicf6cRn9z y2PpTozm50ciskE06j99lfC6xquqYLOVRUd/RjMUySu6QYRTJW+e4Wi5Fzf7PBBBIWUVF+Mu D4Dgcf2xOwHE5yIvCCEXugIGLan+7CDPSG0qVlrEpo6/jKh4Um/bJtQ6zFzIkRuGssccDqva 0jW0T69/7cKYiHsN/UuJdvsVYJ6lsAMCOgJSNjoVPMVYr1hcTXE23thQ36C8nDmiGEFxPRX1 YigTe6gCnMTCKJCxTWwRvsA3bJD+h3S1V8/VrigkU35jOP2iGq9DO5cbQDQNrxRALas+l29z jpJCyedJ/yzusXaazKfz4McJEtiwZMTVcGv8Jw/mgJuz2Nb9IAd5x35m+tJl29Nxf49egL0E paVBCdlJKLX3yGvFOlzQikLhXOGdc8XQYgHFSItJ020/HMofJyi6qwSH7NuI+d2qrI7lq8kE KZbEyllPhioYm2XkwnxkLGn9NAyHPhVrV3m09WZjMgXIMc7Gl2hFi7MdQrz7igeZhdbRuNny 4BNF2rzH/I+euiVJJ+OMK33kAvt5SN1dSAbdxKgH+S/sX7EqOBCQxEdRNdsSy3QAX0vHgen6 js= IronPort-HdrOrdr: A9a23:2Qpes6A5gwNlSHblHem455DYdb4zR+YMi2TC1yhKJiC9E/bo8/ xG88576faZslsssRIb6LW90cu7IU80nKQdieJ6AV7LZniFhILCFu9fBOXZrwEIYxeOldJg6Q == X-IronPort-AV: E=Sophos;i="5.96,202,1665460800"; d="scan'208";a="86155238" From: Lin Liu To: CC: Lin Liu , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "moderated list:XEN HYPERVISOR INTERFACE" , "open list:NETWORKING DRIVERS" , open list Subject: [PATCH] drivers/net/netfront: Fix NULL sring after live migration Date: Tue, 29 Nov 2022 06:17:02 +0000 Message-ID: <20221129061702.60629-1-lin.liu@citrix.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain A NAPI is setup for each network sring to poll data to kernel The sring with source host is destroyed before live migration and new sring with target host is setup after live migration. The NAPI for the old sring is not deleted until setup new sring with target host after migration. With busy_poll/busy_read enabled, the NAPI can be polled before got deleted when resume VM. [50116.602938] BUG: unable to handle kernel NULL pointer dereference at 0000000000000008 [50116.603047] IP: xennet_poll+0xae/0xd20 [50116.603090] PGD 0 P4D 0 [50116.603118] Oops: 0000 [#1] SMP PTI [50116.604624] Call Trace: [50116.604674] ? finish_task_switch+0x71/0x230 [50116.604745] ? timerqueue_del+0x1d/0x40 [50116.604807] ? hrtimer_try_to_cancel+0xb5/0x110 [50116.604882] ? xennet_alloc_rx_buffers+0x2a0/0x2a0 [50116.604958] napi_busy_loop+0xdb/0x270 [50116.605017] sock_poll+0x87/0x90 [50116.605066] do_sys_poll+0x26f/0x580 [50116.605125] ? tracing_map_insert+0x1d4/0x2f0 [50116.605196] ? event_hist_trigger+0x14a/0x260 ... [50116.613598] ? finish_task_switch+0x71/0x230 [50116.614131] ? __schedule+0x256/0x890 [50116.614640] ? recalc_sigpending+0x1b/0x50 [50116.615144] ? xen_sched_clock+0x15/0x20 [50116.615643] ? __rb_reserve_next+0x12d/0x140 [50116.616138] ? ring_buffer_lock_reserve+0x123/0x3d0 [50116.616634] ? event_triggers_call+0x87/0xb0 [50116.617138] ? trace_event_buffer_commit+0x1c4/0x210 [50116.617625] ? xen_clocksource_get_cycles+0x15/0x20 [50116.618112] ? ktime_get_ts64+0x51/0xf0 [50116.618578] SyS_ppoll+0x160/0x1a0 [50116.619029] ? SyS_ppoll+0x160/0x1a0 [50116.619475] do_syscall_64+0x73/0x130 [50116.619901] entry_SYSCALL_64_after_hwframe+0x41/0xa6 ... [50116.806230] RIP: xennet_poll+0xae/0xd20 RSP: ffffb4f041933900 [50116.806772] CR2: 0000000000000008 [50116.807337] ---[ end trace f8601785b354351c ]--- xen frontend should remove the NAPIs for the old srings before live migration as the bond srings are destroyed There is a tiny window between the srings are set to NULL and the NAPIs are disabled, It is safe as the NAPI threads are still frozen at that time Signed-off-by: Lin Liu --- drivers/net/xen-netfront.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 9af2b027c19c..dc404e05970c 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1862,6 +1862,12 @@ static int netfront_resume(struct xenbus_device *dev) netif_tx_unlock_bh(info->netdev); xennet_disconnect_backend(info); + + rtnl_lock(); + if (info->queues) + xennet_destroy_queues(info); + rtnl_unlock(); + return 0; } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 29 07:11:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 07:11:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449251.705905 (Exim 4.92) (envelope-from ) id 1ozum0-0004UA-Pb; Tue, 29 Nov 2022 07:11:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449251.705905; Tue, 29 Nov 2022 07:11:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozum0-0004U3-Mj; Tue, 29 Nov 2022 07:11:20 +0000 Received: by outflank-mailman (input) for mailman id 449251; Tue, 29 Nov 2022 07:11:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozulz-0004Tt-P1; Tue, 29 Nov 2022 07:11:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozulz-0006b8-JH; Tue, 29 Nov 2022 07:11:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozulz-00017x-4s; Tue, 29 Nov 2022 07:11:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozulz-0007Aj-4Q; Tue, 29 Nov 2022 07:11:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PZOrXvOi2RrOJs0w4nSLV2VkO+0juZUBBajHcTMoiok=; b=ZuV960wnw0EYWdCNGLr+YyFpvD FoLgelAxkzxQG4/V02/mjX9mlDh5YmA4SQefJEFlqNvdSCrO+d61FhvsfRncGThIX+jPm7IZxbJ+g LRqivz3x+vofhZpV1Rdp0jPSSx/2Wc/tF1Oa+HbIsWi55ZETi3jKH3A6RZ1WBbBeChIs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174984: FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-dom0pvh-xl-intel::broken:regression xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:host-install(5):broken:heisenbug xen-unstable:test-amd64-i386-examine:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=345135942bf9632eba1409ba432cfcae3b7649c7 X-Osstest-Versions-That: xen=345135942bf9632eba1409ba432cfcae3b7649c7 From: osstest service owner Date: Tue, 29 Nov 2022 07:11:19 +0000 flight 174984 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174984/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-intel broken in 174977 Tests which are failing intermittently (not blocking): test-amd64-amd64-dom0pvh-xl-intel 5 host-install(5) broken in 174977 pass in 174984 test-amd64-i386-examine 6 xen-install fail in 174977 pass in 174984 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail pass in 174977 Tests which did not succeed, but are not blocking: test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 174977 like 174958 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 174977 like 174958 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail in 174977 like 174972 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174977 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174977 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174977 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174977 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174977 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174977 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174977 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174977 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174977 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174977 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174977 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 345135942bf9632eba1409ba432cfcae3b7649c7 baseline version: xen 345135942bf9632eba1409ba432cfcae3b7649c7 Last test of basis 174984 2022-11-29 01:53:18 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-dom0pvh-xl-intel broken Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Nov 29 07:12:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 07:12:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449259.705917 (Exim 4.92) (envelope-from ) id 1ozuml-000543-9L; Tue, 29 Nov 2022 07:12:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449259.705917; Tue, 29 Nov 2022 07:12:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozuml-00053w-5o; Tue, 29 Nov 2022 07:12:07 +0000 Received: by outflank-mailman (input) for mailman id 449259; Tue, 29 Nov 2022 07:12:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozumj-00053m-C0; Tue, 29 Nov 2022 07:12:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozumj-0006br-AO; Tue, 29 Nov 2022 07:12:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozumi-0001AU-WA; Tue, 29 Nov 2022 07:12:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozumi-0007i5-Vj; Tue, 29 Nov 2022 07:12:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AJ0HKeH9jBjobCO1hTFhUL+84oIH7umEFnxebFU/PLg=; b=Kc9dXO6+gFhkIPnalsq8gu/RLi dr6uqxC4VgyBOj3GCIuEgRatqcn6JzJyuWyRlf87b5tDNc6+vsZvYUlTRv6ZsGrzdB/l9/kMHBKD+ 3Fs6+SsXSQd1ZjFin1EeuJjXStkBw3UmKZIwo8dhFphspMKHTUZETcRH5uKXsLzV+VUw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174986: all pass - PUSHED X-Osstest-Versions-This: ovmf=c8c978d32882413eeaf2b9917409af83af68cb5d X-Osstest-Versions-That: ovmf=ae3bc559f98e68983df0a4b223dad7afeb6eee2c From: osstest service owner Date: Tue, 29 Nov 2022 07:12:04 +0000 flight 174986 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174986/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c8c978d32882413eeaf2b9917409af83af68cb5d baseline version: ovmf ae3bc559f98e68983df0a4b223dad7afeb6eee2c Last test of basis 174983 2022-11-29 00:43:15 Z 0 days Testing same since 174986 2022-11-29 04:42:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: zhenhuay jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git ae3bc559f9..c8c978d328 c8c978d32882413eeaf2b9917409af83af68cb5d -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Nov 29 08:40:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 08:40:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449272.705927 (Exim 4.92) (envelope-from ) id 1ozwA2-0006uJ-4b; Tue, 29 Nov 2022 08:40:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449272.705927; Tue, 29 Nov 2022 08:40:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozwA2-0006uC-1k; Tue, 29 Nov 2022 08:40:14 +0000 Received: by outflank-mailman (input) for mailman id 449272; Tue, 29 Nov 2022 08:40:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozwA1-0006tP-1l for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 08:40:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozw9u-0000SK-OA; Tue, 29 Nov 2022 08:40:06 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[192.168.9.110]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ozw9u-00073G-Gt; Tue, 29 Nov 2022 08:40:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=7Y13d8yrr1Ogdj+wm9hfRbCedsWLRho3pNsD7M8gzeE=; b=OlRZC9zs8gK6hYOAzQB7IqmA8Y fxDs8AOOxnrAhd7w5oNvm44SIsjreE9IP3fOHkVW/Pm/EOLq7qERf5/VBkraNcg9y5F8467L9gJwT Cxbb7F0KZiTPGQyj6oD5wiRA2uIXc0EbM+T5tkQowZzsnEjkQ2d7LBIPqvIpor1TWdMY=; Message-ID: Date: Tue, 29 Nov 2022 08:40:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH RFC 07/10] domain: map/unmap GADDR based shared guest areas Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <5a571fd9-b0c2-216e-a444-102397a22ca0@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 28/11/2022 10:01, Jan Beulich wrote: > On 24.11.2022 22:29, Julien Grall wrote: >> On 19/10/2022 09:43, Jan Beulich wrote: >>> --- a/xen/common/domain.c >>> +++ b/xen/common/domain.c >>> @@ -1563,7 +1563,82 @@ int map_guest_area(struct vcpu *v, paddr >>> struct guest_area *area, >>> void (*populate)(void *dst, struct vcpu *v)) >>> { >>> - return -EOPNOTSUPP; >>> + struct domain *currd = v->domain; >>> + void *map = NULL; >>> + struct page_info *pg = NULL; >>> + int rc = 0; >>> + >>> + if ( gaddr ) >> >> 0 is technically a valid (guest) physical address on Arm. > > I guess it is everywhere; it certainly also is on x86. While perhaps a > little unfortunate in ordering, the public header changes coming only > in the following patches was the best way I could think of to split > this work into reasonable size pieces. There the special meaning of 0 > is clearly documented. And I don't really see it as a meaningful > limitation to not allow guests to register such areas at address zero. I would expect an OS to allocate the region using the generic physical allocator. This allocator may decide that '0' is a valid address and return it. So I think your approach could potentially complicate the OS implementation. I think it would be better to use an all Fs value as this cannot be valid for this hypercall (we require at least 4-byte alignment). > >>> + { >>> + unsigned long gfn = PFN_DOWN(gaddr); >> >> This could be gfn_t for adding some type safety. > > Indeed I did consider doing so, but the resulting code would imo be > less legible. But this difference perhaps isn't significant enough > for me to object to changing, in case you (or others) think the > type safety is really a meaningful gain here. In general, my preference is to always use the typesafe version because it reduces the number of "unsigned long". [...] >> The first function will set v->is_running to false (see >> vcpu_context_saved()). So I think the "area" could be touched even afte >> vcpu_pause() is returned. >> >> Therefore, I think we will need _update_runstate_area() (or >> update_runstate_area()) to be called first. > > ... I don't see a need for adjustment. The corresponding > > _update_runstate_area(prev); > > sits quite a bit earlier in context_switch(). (Arm code is quite a bit > different, but this particular aspect looks to apply there as well.) You are right. Sorry I misread the code. > >>> @@ -1573,6 +1648,22 @@ int map_guest_area(struct vcpu *v, paddr >>> */ >>> void unmap_guest_area(struct vcpu *v, struct guest_area *area) >>> { >>> + struct domain *d = v->domain; >>> + void *map; >>> + struct page_info *pg; >> >> AFAIU, the assumption is the vCPU should be paused here. > > Yes, as the comment ahead of the function (introduced by an earlier > patch) says. Ah, I missed that. Thanks! > >> Should we add an ASSERT()? > > I was going from unmap_vcpu_info(), which had the same requirement, > while also only recording it by way of a comment. I certainly could > add an ASSERT(), but besides this being questionable as to the rules > set forth in ./CODING_STYLE I also view assertions of "paused" state > as being of limited use - the entity in question may become unpaused > on the clock cycle after the check was done. That's correct. However, that race you mention is unlikely to happen *every* time. So there are a very high chance the ASSERT() will hit if miscalled. > (But yes, such are no > different from e.g. the fair number of spin_is_locked() checks we > have scattered around, which don't really provide guarantees either.) And that's fine to not provide the full guarantee. You are still probably going to catch 95% (if not more) of the callers that forgot to call it with the spin lock held. At least for me, those ASSERTs() were super helpful during development in more than a few cases. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 29 08:46:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 08:46:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449280.705939 (Exim 4.92) (envelope-from ) id 1ozwFx-0007er-Qs; Tue, 29 Nov 2022 08:46:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449280.705939; Tue, 29 Nov 2022 08:46:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozwFx-0007ek-Mn; Tue, 29 Nov 2022 08:46:21 +0000 Received: by outflank-mailman (input) for mailman id 449280; Tue, 29 Nov 2022 08:46:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozwFw-0007ee-4N for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 08:46:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozwFv-0000i0-QQ; Tue, 29 Nov 2022 08:46:19 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[192.168.9.110]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ozwFv-0007KB-Jl; Tue, 29 Nov 2022 08:46:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=VQeUPbLvW8N0BdpHppup9iMVHpNG69XXEtooMxp+5D8=; b=FFfzwGsuT4DO4Zbi315XoCGtIO tqADyUcMaknkb4Z8vR6Qalir9EcHQcDYRDqXcH6vT6gmUXjXQIxdaadM3A7I95fqC3CwnSu29u9tK 9Ai3dHMH9rjloc5BxD1rXdDQueWMQ5kFtIKl1gSNeHvaWHX7mMRu8fujRXGosdPjsc6A=; Message-ID: <44c8e3ec-e1af-013a-e83a-1495b1332587@xen.org> Date: Tue, 29 Nov 2022 08:46:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 1/2] xen/arm: vpl011: emulate non-SBSA registers as WI/RAZ Content-Language: en-US To: Jiamei Xie , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221129023935.1576133-1-jiamei.xie@arm.com> <20221129023935.1576133-2-jiamei.xie@arm.com> From: Julien Grall In-Reply-To: <20221129023935.1576133-2-jiamei.xie@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 29/11/2022 03:39, Jiamei Xie wrote: > When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", > Linux SBSA PL011 driver will access PL011 DMACR register in some > functions. As chapter "B Generic UART" in "ARM Server Base System > Architecture"[1] documentation describes, SBSA UART doesn't support > DMA. In current code, when the kernel tries to access DMACR register, > Xen will inject a data abort: > Unhandled fault at 0xffffffc00944d048 > Mem abort info: > ESR = 0x96000000 > EC = 0x25: DABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > FSC = 0x00: ttbr address size fault > Data abort info: > ISV = 0, ISS = 0x00000000 > CM = 0, WnR = 0 > swapper pgtable: 4k pages, 39-bit VAs, pgdp=0000000020e2e000 > [ffffffc00944d048] pgd=100000003ffff803, p4d=100000003ffff803, pud=100000003ffff803, pmd=100000003fffa803, pte=006800009c090f13 > Internal error: ttbr address size fault: 96000000 [#1] PREEMPT SMP > ... > Call trace: > pl011_stop_rx+0x70/0x80 > tty_port_shutdown+0x7c/0xb4 > tty_port_close+0x60/0xcc > uart_close+0x34/0x8c > tty_release+0x144/0x4c0 > __fput+0x78/0x220 > ____fput+0x1c/0x30 > task_work_run+0x88/0xc0 > do_notify_resume+0x8d0/0x123c > el0_svc+0xa8/0xc0 > el0t_64_sync_handler+0xa4/0x130 > el0t_64_sync+0x1a0/0x1a4 > Code: b9000083 b901f001 794038a0 8b000042 (b9000041) > ---[ end trace 83dd93df15c3216f ]--- > note: bootlogd[132] exited with preempt_count 1 > /etc/rcS.d/S07bootlogd: line 47: 132 Segmentation fault start-stop-daemon > > As discussed in [2], this commit makes the access to non-SBSA registers > RAZ/WI as an improvement. > > [1] https://developer.arm.com/documentation/den0094/c/?lang=en > [2] https://lore.kernel.org/xen-devel/alpine.DEB.2.22.394.2211161552420.4020@ubuntu-linux-20-04-desktop/ > > Signed-off-by: Jiamei Xie > --- > v2 -> v3 > - emulate non-SBSA registers as WI/RAZ in default case > - update commit message > v1 -> v2 > - print a message using XENLOG_G_DEBUG when it's write-ignore > --- > xen/arch/arm/vpl011.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c > index 43522d48fd..1bf803fc1f 100644 > --- a/xen/arch/arm/vpl011.c > +++ b/xen/arch/arm/vpl011.c > @@ -414,11 +414,19 @@ static int vpl011_mmio_read(struct vcpu *v, > default: > gprintk(XENLOG_ERR, "vpl011: unhandled read r%d offset %#08x\n", > dabt.reg, vpl011_reg); > - return 0; > + goto read_as_zero; > } > > return 1; > > +read_as_zero: > + if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; We don't know the registers and therefore I don't think we should check the size. > + > + VPL011_LOCK(d, flags); > + *r = 0; > + VPL011_UNLOCK(d, flags); There is no need to lock/unlock here. > + return 1; > + > bad_width: > gprintk(XENLOG_ERR, "vpl011: bad read width %d r%d offset %#08x\n", > dabt.size, dabt.reg, vpl011_reg); > @@ -486,10 +494,11 @@ static int vpl011_mmio_write(struct vcpu *v, > default: > gprintk(XENLOG_ERR, "vpl011: unhandled write r%d offset %#08x\n", > dabt.reg, vpl011_reg); > - return 0; > + goto write_ignore; > } > > write_ignore: > + if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; Same as for the read_as_zero, the size is unknown and shouldn't be checked. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 29 08:54:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 08:54:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449287.705949 (Exim 4.92) (envelope-from ) id 1ozwOE-0000mG-JP; Tue, 29 Nov 2022 08:54:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449287.705949; Tue, 29 Nov 2022 08:54:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozwOE-0000m9-Gk; Tue, 29 Nov 2022 08:54:54 +0000 Received: by outflank-mailman (input) for mailman id 449287; Tue, 29 Nov 2022 08:54:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozwOD-0000m2-Ba for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 08:54:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozwOC-0000qj-WB; Tue, 29 Nov 2022 08:54:52 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.9.110]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ozwOC-0007ms-Ps; Tue, 29 Nov 2022 08:54:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=FKpuNhwamOznxj+l8a+WVx+HIxpF2I3IgJaomIhb4U4=; b=bjcDkFuXQ0KgONv1hClCsj2kXA vLtxlvRHfQrHdeKdpVMX6gvG3UMyxiusrqC0ETfWS4waQofQzOdNjGCwEM+EvAGnWLVLnaOytkPy1 Qa2XOr3/UEBFOefgJRrbGp6baeWOQspRQAN1qlkMDWkw2wjslM6mMD+IKLROKh7ocZO0=; Message-ID: <5be1760a-fbbe-e9df-6752-4e73d7d963b8@xen.org> Date: Tue, 29 Nov 2022 08:54:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 2/2] xen/arm: vpl011: drop redundancy in mmio_write/read Content-Language: en-US To: Jiamei Xie , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221129023935.1576133-1-jiamei.xie@arm.com> <20221129023935.1576133-3-jiamei.xie@arm.com> From: Julien Grall In-Reply-To: <20221129023935.1576133-3-jiamei.xie@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 29/11/2022 03:39, Jiamei Xie wrote: > This commit is to drop redundancy in the function vpl011_mmio_write > and vpl011_mmio_read: > - In vpl011_mmio_read switch block, all cases have a return. So the > outside one can be removed. > - Each switch case checks access by the same if statments. So we can > just use one and put it before the switch block. > - The goto label bad_width and read_as_zero is used only once, put the > code directly > > Signed-off-by: Jiamei Xie > --- > xen/arch/arm/vpl011.c | 66 +++++++++++++------------------------------ > 1 file changed, 19 insertions(+), 47 deletions(-) > > diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c > index 1bf803fc1f..80b859baed 100644 > --- a/xen/arch/arm/vpl011.c > +++ b/xen/arch/arm/vpl011.c > @@ -354,11 +354,15 @@ static int vpl011_mmio_read(struct vcpu *v, > struct domain *d = v->domain; > unsigned long flags; > > + if ( !vpl011_reg32_check_access(dabt) ) { As I pointed out in the previous version, we don't know the size of the registers for the one not described in the SBSA UART. So I don't think this check should be consolidated. Also, coding style: if ( .... ) { > + gprintk(XENLOG_ERR, "vpl011: bad read width %d r%d offset %#08x\n", > + dabt.size, dabt.reg, vpl011_reg); > + return 0; > + } > + > switch ( vpl011_reg ) > { > case DR: > - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; > - > if ( vpl011->backend_in_domain ) > *r = vreg_reg32_extract(vpl011_read_data(d), info); > else > @@ -366,31 +370,23 @@ static int vpl011_mmio_read(struct vcpu *v, > return 1; > > case RSR: > - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; > - > /* It always returns 0 as there are no physical errors. */ > *r = 0; > return 1; > > case FR: > - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; > - > VPL011_LOCK(d, flags); > *r = vreg_reg32_extract(vpl011->uartfr, info); > VPL011_UNLOCK(d, flags); > return 1; > > case RIS: > - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; > - > VPL011_LOCK(d, flags); > *r = vreg_reg32_extract(vpl011->uartris, info); > VPL011_UNLOCK(d, flags); > return 1; > > case MIS: > - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; > - > VPL011_LOCK(d, flags); > *r = vreg_reg32_extract(vpl011->uartris & vpl011->uartimsc, > info); > @@ -398,40 +394,25 @@ static int vpl011_mmio_read(struct vcpu *v, > return 1; > > case IMSC: > - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; > - > VPL011_LOCK(d, flags); > *r = vreg_reg32_extract(vpl011->uartimsc, info); > VPL011_UNLOCK(d, flags); > return 1; > > case ICR: > - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; > - > /* Only write is valid. */ > return 0; > > default: > gprintk(XENLOG_ERR, "vpl011: unhandled read r%d offset %#08x\n", > dabt.reg, vpl011_reg); > - goto read_as_zero; > - } > - > - return 1; > - > -read_as_zero: In general, we don't want to introduce and remove the same code within a series. If you don't want to keep read_as_zero, then you should not introduce it. However... I think using the read_as_zero label could still be beneficial to reduce the numbers of lines where the registers are RAZ (e.g. default, RSR...). > - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; > - > - VPL011_LOCK(d, flags); > - *r = 0; > - VPL011_UNLOCK(d, flags); > - return 1; > - > -bad_width: > - gprintk(XENLOG_ERR, "vpl011: bad read width %d r%d offset %#08x\n", > - dabt.size, dabt.reg, vpl011_reg); > - return 0; > > + /* Read as zero */ > + VPL011_LOCK(d, flags); > + *r = 0; > + VPL011_UNLOCK(d, flags); > + return 1; > + } > } > > static int vpl011_mmio_write(struct vcpu *v, > @@ -446,14 +427,18 @@ static int vpl011_mmio_write(struct vcpu *v, > struct domain *d = v->domain; > unsigned long flags; > > - switch ( vpl011_reg ) > + if ( !vpl011_reg32_check_access(dabt) ) { > + gprintk(XENLOG_ERR, "vpl011: bad write width %d r%d offset %#08x\n", > + dabt.size, dabt.reg, vpl011_reg); > + return 0; > + } Same remarks as for the read part. > + > + switch ( vpl011_reg ) > { > case DR: > { > uint32_t data = 0; > > - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; > - > vreg_reg32_update(&data, r, info); > data &= 0xFF; > if ( vpl011->backend_in_domain ) > @@ -464,8 +449,6 @@ static int vpl011_mmio_write(struct vcpu *v, > } > > case RSR: /* Nothing to clear. */ > - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; > - > return 1; > > case FR: > @@ -474,8 +457,6 @@ static int vpl011_mmio_write(struct vcpu *v, > goto write_ignore; > > case IMSC: > - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; > - > VPL011_LOCK(d, flags); > vreg_reg32_update(&vpl011->uartimsc, r, info); > vpl011_update_interrupt_status(v->domain); > @@ -483,8 +464,6 @@ static int vpl011_mmio_write(struct vcpu *v, > return 1; > > case ICR: > - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; > - > VPL011_LOCK(d, flags); > vreg_reg32_clearbits(&vpl011->uartris, r, info); > vpl011_update_interrupt_status(d); > @@ -498,14 +477,7 @@ static int vpl011_mmio_write(struct vcpu *v, > } > > write_ignore: > - if ( !vpl011_reg32_check_access(dabt) ) goto bad_width; > return 1; > - > -bad_width: > - gprintk(XENLOG_ERR, "vpl011: bad write width %d r%d offset %#08x\n", > - dabt.size, dabt.reg, vpl011_reg); > - return 0; > - > } > > static const struct mmio_handler_ops vpl011_mmio_handler = { -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 29 09:42:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 09:42:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449313.705961 (Exim 4.92) (envelope-from ) id 1ozx8H-0006WO-G2; Tue, 29 Nov 2022 09:42:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449313.705961; Tue, 29 Nov 2022 09:42:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozx8H-0006WH-CC; Tue, 29 Nov 2022 09:42:29 +0000 Received: by outflank-mailman (input) for mailman id 449313; Tue, 29 Nov 2022 09:42:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozx8G-0006WB-6n for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 09:42:28 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0608.outbound.protection.outlook.com [2a01:111:f400:fe0c::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 201092b2-6fca-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 10:42:25 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9436.eurprd04.prod.outlook.com (2603:10a6:20b:4ec::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 09:42:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 09:42:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 201092b2-6fca-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LxlEmKA9m7mcyFP66DhBcyZNVUqIb5z+TSZGbSFO/e6Xm6dePzEwb/IVq7VXY1DKVBAGuWNOoslNRSLic7GTYzrdxu1/gw2jgnTrVC7liqd1WPhr+uMn7CTs53w18G95NOzJZyInahCT+KiUTE6N3RmJX3jYyytSfLiydzKNULcwmnGfjMGnbMBsdgQJvAp4l91QF8ACg6KHcrQNqb1uKhnY5kgofXeJI1gltvw5OM7OKmYwgYDyu7q4zGKlu3k6vepeJ8tcErQJt4mZ6pY98SLcggMa2GosIjBmJ2tdJM2J3GwUdAdF/15lqbdZZfN4V7PGuaSS4lPVISDzu83x0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dmgb0WJLW4ak4TGCs9NLhwpQvw06caLPzbln007chRo=; b=ar9C83iqwXTNyy1fDpiCxY30nAXcFSRPHXfhVZngTzj/VAgP3FKPYmGlU6UxL24sjCPzUjdMGwsjZ/u/PEtQAenKY6D6pxRJYFpNXW2w/de3CT+9TjzRmUNRwRfvBqbg7KeXOL3Wl0Kj5fv9bQeVHzvPB/rQEO/A7BniTYtFZZDkE160paDjVOFJaK3XJe1u6Gv8/njk2UkmAPzTIg26M0LlJ4NyuMdwrAi54mcAl6g7+oY+k6V+Gi/OwQRswVyHg/P879wA7Xwr3zNS1MTP036OHO6SAudauc+n3NbKkoA+sSDUB0/FTDbMbL6HhZvRaiu3bkic0v81dlHKGnWL6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dmgb0WJLW4ak4TGCs9NLhwpQvw06caLPzbln007chRo=; b=giuqLn12JPiLFxpEJfGN+ykwxW99qfXh5bFxDBYxAz7ZUxGJzZbxa3YMTalqKIOCEHSXNjAzfvdd7OpsznHt4SGNCA7wpslljklJS5RR4ltuq6CkCfQ4mdpjDf1XUpDAwAXeHBbr9o7DnycZ7jsLjFN4DkxPWbOR5cHCqZwjpSKj/mIGMNfdgmooTj39gSBKueCfzncrvNTnsvl27sSwsCJBI01NpP5M63QBzpxyq8XiiN4NgRdBxaRZ1ExnSJD14VeAnUB4W7cP34xsA96C0kBiP2aTCumj05aMS2BR1bZRF2eVa0y+h+TeVYVgOoP2AS8/a1g5wDHhDpR0X5E5FQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7da53010-56dd-8d91-fde3-9fde0d76125c@suse.com> Date: Tue, 29 Nov 2022 10:42:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/4] xen/scripts: add cppcheck tool to the xen-analysis.py script Content-Language: en-US To: Luca Fancellu Cc: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20221128141006.8719-1-luca.fancellu@arm.com> <20221128141006.8719-3-luca.fancellu@arm.com> <1a0f27e6-1b0e-d5cb-7f3a-337b9664eb75@suse.com> <35743861-CF6F-4B80-AFE9-182D34678FC8@arm.com> From: Jan Beulich In-Reply-To: <35743861-CF6F-4B80-AFE9-182D34678FC8@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0157.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9436:EE_ X-MS-Office365-Filtering-Correlation-Id: 9184327d-49e5-473c-5426-08dad1ee0367 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MIDA9qG+G/5sqFhRbhbmDr1YY7fvsFbw0vKCJ59h7Wn/q15ijY/oHu2snbOIP3/g+Xr7wGkbenm5PKQjz+WIpz0azHu4Ah3JnFo9s+RBcvbfko0ZQO310+I/yVok2IiAyL46uxgOqQeAASA3e6DhFrENe7pZuCQMEVi/PF9E2q+aVqVmjc0/sykK25yUPZDfcgV3BUojHOFv6CF93rJN58jgoiB7ZCJdX2Q7P7TjNod04UDfoUrtUFTtClKhCUwBG/mETeJcgJo/jjAm5+W9BshOyn95ngoZ7tAfXfOs8knPGLJ7/qnGJzEncsVGDCLvD4KfZrsmCKLqsRdoZPIOCYWEAb0GB2o+cfH8ZIgtUE5zg/au4xoIEz/xFSZOu+Ge7TmfCo2tXFPMUHHKqDkIOedNFfAsEbZCxW6R52iCa3A3aO4i6I+yFS3q45m1t1GK87XnP3K33Gtu/9Y2lBKfy/okyRI0iS278AO77sJkz5dBKOSd62KwPt92QqvSmsEG9wK4DSxbui+OrVDSQHxjEBhqeNLussZbOOs+r3N/uVd7vUJzyrzjmvBdKGCUOJcxCatutBpfyRdEX2Omi8YkUrFiTWmA5E2V8PXkvvgZ85q8eUJSDpeHVajaBcfOGGmsqBfJj2/1ed1HgyrV2FEhuoVr7qH3ywmFyv2QAdeawClqm7I2h636cEMQ4A/SXX4asaiTIt4wigbqdqhAMKgGsqRzxc08bqTo0/WMheEsQBM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(39860400002)(346002)(376002)(366004)(451199015)(2906002)(31686004)(4326008)(54906003)(41300700001)(6916009)(36756003)(66556008)(8676002)(66946007)(66476007)(8936002)(5660300002)(316002)(26005)(6512007)(86362001)(478600001)(6486002)(31696002)(6506007)(53546011)(2616005)(186003)(38100700002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWt4dzgzL3NXckxsNU41VGtUWGNnZXc0S0RjVkw2MnZ0VFFIcGs0WnR6QXlY?= =?utf-8?B?Q0Z1WFBVUzREUlFCY0xQZW05RkhTRXhCWUx4N1VSdE9OTFpVVVJrZ0hzNVY3?= =?utf-8?B?Zk42aHBCaEpjK0JwT3lkckM0a1BXOWZ0bGtueFM2TGFyaEhSN3M4d0RyMXVv?= =?utf-8?B?LzE5MitwbFBYbThnLzRGMUpNVEZWMlhtQVEvQ1AzS2lJYXRva1JWSnhpeDdJ?= =?utf-8?B?c2RMcC96R3gxajI4T1lGUmtDakUvVFRLT2hYckl3VS9GNmhBZG04UGcrRm5v?= =?utf-8?B?ZS9XRmg5VVdQVXRZbHNBMVUzRGxhaEJJaDNSYXF6aDRaSi9KUjAyVG9XZlNt?= =?utf-8?B?V1J6MzRaRHlQYzlRcjRQdjJaTWdwUGxBWU9zNi9mYzRvVnpjT0cvNkwxcHps?= =?utf-8?B?OXBqbTFrZ3hjZnR3KzJNbytFNzNUb2tUZXFnbVBqUGY0b1R2L05yaGx3dkVB?= =?utf-8?B?bGlOQjFtV3VxWjJNTDJxajB6MkVpdWthclVQakN0TDdPZHR2SDBlRWZHVDZJ?= =?utf-8?B?eVdreDhnc2xpUVZCVDNYS2ZCZVhoM0NDN0pONmpKUURRcTI0SytITzM1bzlC?= =?utf-8?B?ak82b1RPZ04vK0JjVHNTeTYrTlpCZ2lycEM5aVA5WXhwRCtqRURwdkhza043?= =?utf-8?B?M0RVVjl5TTRqRGpnTmlQaVR4OVhKb2l1c0NNMC9FZEtHZnFpc3QwaDM4VkJX?= =?utf-8?B?V0ZVRVgyVjBGMG0zYzNPb1Mwek9qbFlrc1JXNm0yTEMxSDJMWXpaQzhyVStK?= =?utf-8?B?SmdRT1lsdzlMS2JsVkNocHZXNHNHSkJLVXh4NU0rd2VYUjFtRUMvY1F2MjB1?= =?utf-8?B?S3dZUnVBUXR5ZkJwUFBnM3k3ZzUreUVoUmUyQUlUK1E5SFRhOVUxSnVWS3Mr?= =?utf-8?B?N2o3QVRCajRJaDdVWGpUOUZkK21OOEp1YlFNUGJuQTJDWXZMMkJPd2xicC90?= =?utf-8?B?TVJJU0tiMUh6SVlubldPMENUN1U5N1VHK29uZURJMG4yb1QzK0ZOTjY1d3NJ?= =?utf-8?B?UU5YdjZzaElUcEhLMUZTRFU2RzNjVGpBTklVMHNHd3hyNitYS3poTmxYcTFS?= =?utf-8?B?NlV3ZnNyUmF0YWJKT0Q0TWRvNDIzeGJOeUJOMmovR2xXOVViWVRuK2pRV2lO?= =?utf-8?B?QlpNZVRQUTZpd3ZPNnZ0emh5ZXhlMHVXb2J5eUNIVXNuTGtnYmo1NFBhQWlk?= =?utf-8?B?WWI1V0ZKems4dDRGbndlUjBuN3gzd0YyNWFJWE9KcFQ2Zm5USGlIZUJzN0JQ?= =?utf-8?B?eHJLRmVrVXFKQ05aT082SEk3enQ3aFJzRHNkV0tyZTRTQzFOTGlYOXhMZWpC?= =?utf-8?B?TUx6TW90TkYrQ1hxR0xwL3NNVHNiSG83MlZYS2hjb0N0Nyt6ZHE0YTV1NTk3?= =?utf-8?B?UDZiK2JxaGNnT09BSFZxZWowV0VlRXgvOXM2b0J6US9BeTJnMHV1cWZFODAz?= =?utf-8?B?NHpad09Lak9EenZSblQ2T002MGl3dUgxbGYxTWVOVFRQWlZYSk1PSUxxTkpk?= =?utf-8?B?Q0FCK1hMM3hTZEo0Z3FZRzFidXRKTUZDKzhldDFicDNjbjJYMWJLck9iZlpC?= =?utf-8?B?L21tNmdWd1ovcG9wQXFEcWQ4WnVFTlBVUjZpRUVRelZEY1p5M2VFWUpNZXlh?= =?utf-8?B?Z1d0TVdNSlR2T3g4b1Q4bFkzMmNKSXBSMjRNQ292eDJ6WkVVRWR0VThlR1Nx?= =?utf-8?B?QWlQbnNTKytubFcvME1vODRZb0JGUUpsVkNaalJaMGpzdzhWK0c5RERUTW00?= =?utf-8?B?L0RFTGF0WkZTcXMzcjltd2NqUFludVJIL1RnMzgveTI5ZXUrS0RTcjFvcVpM?= =?utf-8?B?NU0zcnUzR0ZCZFdUMXBocmVFT2dxOHhaZjdWWElxRjY3RzZiOHBpS2VaL3BE?= =?utf-8?B?bVRnRENvdVl3aFIwOWdmYWsrV0JMM1BpQzdjZlp2OTgzM1dNYW00UnNEV2hR?= =?utf-8?B?dHp0bzNteHdUcEVrQWNoaklUTExiTGNBeWhhcTdaMHZKZnIrN0wzVERoeEZj?= =?utf-8?B?TVZYTkpFRWpVZU5NenhIOHBEb2RKME9iMno5ampiNHVPaHBWMVRWREM0amg2?= =?utf-8?B?NTZ3b0o3R2U3S0ppNWhKR3JpNy83TTlJOTZTdzVvdGNHMTNrdXFibVh5UVZq?= =?utf-8?Q?Fk+WIQ0DoMQC2BsEAlCWsux4W?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9184327d-49e5-473c-5426-08dad1ee0367 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 09:42:21.6808 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Nu7LufalcNFmMCdZvDzqIK4F0716nVQ6fR14+jJZUM0bmE3EkW4ezOljz+J+NK7HdY8AP3cqZElm0xG2Hb+HAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9436 On 28.11.2022 16:37, Luca Fancellu wrote: >> On 28 Nov 2022, at 15:19, Jan Beulich wrote: >> On 28.11.2022 15:10, Luca Fancellu wrote: >>> Change cppcheck invocation method by using the xen-analysis.py >>> script using the arguments --run-cppcheck. >>> >>> Now cppcheck analysis will build Xen while the analysis is performed >>> on the source files, it will produce a text report and an additional >>> html output when the script is called with --cppcheck-html. >>> >>> With this patch cppcheck will benefit of platform configuration files >>> that will help it to understand the target of the compilation and >>> improve the analysis. >>> >>> To do so: >>> - remove cppcheck rules from Makefile and move them to the script. >>> - Update xen-analysis.py with the code to integrate cppcheck. >>> - merge the script merge_cppcheck_reports.py into the xen-analysis >>> script package and rework the code to integrate it. >>> - add platform configuration files for cppcheck.. >>> - add cppcheck-cc.sh script that is a wrapper for cppcheck and it's >>> used as Xen compiler, it will intercept all flags given from the >>> make build system and it will execute cppcheck on the compiled >>> file together with the file compilation. >>> - guarded hypercall-defs.c with CPPCHECK define because cppcheck >>> gets confused as the file does not contain c code. >>> - add false-positive-cppcheck.json file >>> - update documentation. >>> - update .gitignore >>> >>> Signed-off-by: Luca Fancellu >> >> Just two and a half questions, not a full review: >> >>> --- >>> .gitignore | 8 +- >>> docs/misra/cppcheck.txt | 27 +- >>> docs/misra/documenting-violations.rst | 7 +- >>> docs/misra/false-positive-cppcheck.json | 12 + >>> docs/misra/xen-static-analysis.rst | 42 ++- >>> xen/Makefile | 116 +------- >>> xen/include/hypercall-defs.c | 9 + >>> xen/scripts/xen-analysis.py | 18 +- >>> xen/scripts/xen_analysis/cppcheck_analysis.py | 272 ++++++++++++++++++ >>> .../xen_analysis/cppcheck_report_utils.py | 130 +++++++++ >>> xen/scripts/xen_analysis/generic_analysis.py | 21 +- >>> xen/scripts/xen_analysis/settings.py | 77 ++++- >>> xen/scripts/xen_analysis/utils.py | 21 +- >>> xen/tools/cppcheck-cc.sh | 223 ++++++++++++++ >>> xen/tools/cppcheck-plat/arm32-wchar_t4.xml | 17 ++ >>> xen/tools/cppcheck-plat/arm64-wchar_t2.xml | 17 ++ >>> xen/tools/cppcheck-plat/arm64-wchar_t4.xml | 17 ++ >>> xen/tools/cppcheck-plat/x86_64-wchar_t2.xml | 17 ++ >>> xen/tools/cppcheck-plat/x86_64-wchar_t4.xml | 17 ++ >> >> What are these last five files about? There's nothing about them in >> the description afaics. > > They are cppcheck platform configuration files, they help cppcheck to understand > the size of the types depending on the target of the compilation. > > This section in the commit message is to introduce them: > > With this patch cppcheck will benefit of platform configuration files > that will help it to understand the target of the compilation and > improve the analysis. > > Do you think I should say it differently? Or maybe say that they reside in xen/tools/cppcheck-plat/ ? Perhaps (I didn't read that paragraph as relating to _anything_ in tree), e.g.: With this patch cppcheck will benefit from platform configuration files that will help it to understand the target of the compilation and improve the analysis. These are XML files placed in xen/tools/cppcheck-plat/, describing ... (I don't know what to put here). Please write the description here such that people not familiar with cppcheck (or more generally with any external tool) can still follow what you're talking about and what the patch is doing. >>> --- /dev/null >>> +++ b/xen/scripts/xen_analysis/cppcheck_analysis.py >>> @@ -0,0 +1,272 @@ >>> +#!/usr/bin/env python3 >>> + >>> +import os, re, shutil >>> +from . import settings, utils, cppcheck_report_utils >>> + >>> +class GetMakeVarsPhaseError(Exception): >>> + pass >>> + >>> +class CppcheckDepsPhaseError(Exception): >>> + pass >>> + >>> +class CppcheckReportPhaseError(Exception): >>> + pass >>> + >>> +CPPCHECK_BUILD_DIR = "build-dir-cppcheck" >>> +CPPCHECK_HTMLREPORT_OUTDIR = "cppcheck-htmlreport" >>> +CPPCHECK_REPORT_OUTDIR = "cppcheck-report" >>> +cppcheck_extra_make_args = "" >>> +xen_cc = "" >>> + >>> +def get_make_vars(): >>> + global xen_cc >>> + invoke_make = utils.invoke_command( >>> + "make -C {} {} export-variable-CC" >>> + .format(settings.xen_dir, settings.make_forward_args), >>> + True, GetMakeVarsPhaseError, >>> + "Error occured retrieving make vars:\n{}" >>> + ) >>> + >>> + cc_var_regex = re.search('^CC=(.*)$', invoke_make, flags=re.M) >>> + if cc_var_regex: >>> + xen_cc = cc_var_regex.group(1) >>> + >>> + if xen_cc == "": >>> + raise GetMakeVarsPhaseError("CC variable not found in Xen make output") >> >> What use is CC without CFLAGS? Once again the description could do >> with containing some information on what's going on here, and why >> you need to export any variables in the first place. > > We don’t need CFLAGS here, we need only CC to generate include/generated/compiler-def.h and > to pass CC to the cppcheck-cc.sh --compiler argument. Hmm, I see that include/generated/compiler-def.h is generated already now without any use of CFLAGS. Which looks suspicious to me. Sadly the uses in xen/Makefile are lacking any details on what this is for, and Bertrand's commit introducing it doesn't explain its purpose either. Maybe again something entirely obvious to people knowing cppcheck sufficiently well ... > Would a comment in the code be ok? Not sure (yet). Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 29 09:47:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 09:47:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449319.705972 (Exim 4.92) (envelope-from ) id 1ozxCh-0007C3-6E; Tue, 29 Nov 2022 09:47:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449319.705972; Tue, 29 Nov 2022 09:47:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozxCh-0007Bw-3M; Tue, 29 Nov 2022 09:47:03 +0000 Received: by outflank-mailman (input) for mailman id 449319; Tue, 29 Nov 2022 09:47:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozxCf-0007Bo-Pf for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 09:47:01 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20610.outbound.protection.outlook.com [2a01:111:f400:7e1a::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c50166aa-6fca-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 10:47:00 +0100 (CET) Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS8PR08MB10025.eurprd08.prod.outlook.com (2603:10a6:20b:630::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Tue, 29 Nov 2022 09:46:57 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.5880.008; Tue, 29 Nov 2022 09:46:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c50166aa-6fca-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IY83BL5o1BUsi+LK4Xkq+zYGHzE/JL8a1aSRKari2WU1qXO4Q6ogiOn1dhJIiJIoWL8stwW0RTUG4jpIGOQ2EiwZcRWOpGoaATFOr7HE8X2mReXVA0UxW3Qz8Cq6FtYtDpev1iPAitjYuAM0ww+IbTscFdPcrNWlzwEB+CYeBr1EKuyvF82VgUBcBC2j5o9XvZFzdc90e9D/FkZUl6+6duBlu+DLLHow6XmH9/wwzDaTG3Bz/k5dlHvHa1TVhGLjhic0IVvEe06QHwjfuADE6LCqPMLKkLY+VWHwIK/JOeRrg8E9+uWKwLHvveoPKfc8iunvwYTnlvS/uE+/k8HvdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T7yKCOPmEG9Emy9mtL6aGpmL1ikd6wWhvDAVQ0KS8zA=; b=fSL6o/Fb/sBSZL5rX596dTTABz90PdgLZOrgPv8AlIoUmDSWYV1VlA48RNPSwQ+uQ/pXWUMezO9izrUjPMLlEcTzx+AmXFpQsJIRVjevhP7FQpO8/Fw5gShC7dFtAERx6zV0vW0YI6iofBgsIqCYsG68lOI3fV7LBFcVsICzEdIWlVI9Ay9/wdaGjGsYPc2h0Jk/swN1lxKwf+TG59ejB9wv77o2WcRQd5pRlLlYNBIn7qHyS9i2/+SRIH9AngulnuxyrdvOq+5ycO7I4Dozqx6eIj7MHCbvvOfs6SOQBrcFKrRqxmJUlJhi3o91wsKc6aLuWkC3Ertu5w9xXeApsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T7yKCOPmEG9Emy9mtL6aGpmL1ikd6wWhvDAVQ0KS8zA=; b=J8WYlWQ1oXpxFO4au7lR9xoFNg2A8QF55i8aedO+YNt8iZK0fvJBDTJwycJhhcAcem/28+F6cExv0kAjFK7yCLtDnnv6uGD9cUZrRYI72PQjdZYjeva2HOq3ladyVeW3eVnYkBqTTqlvsmPA8jTR+2T3XWbeKCZg7OAXT9iyr7M= From: Luca Fancellu To: Stefano Stabellini CC: Xen-devel , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH 0/4] Static analyser finding deviation Thread-Topic: [PATCH 0/4] Static analyser finding deviation Thread-Index: AQHZAzNMLbhXl7Jpp0uxGRE1XtEGda5VJQuAgACDlwA= Date: Tue, 29 Nov 2022 09:46:57 +0000 Message-ID: <92158E56-BB56-4CEB-BF5A-751F78E2351F@arm.com> References: <20221128141006.8719-1-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS8PR08MB10025:EE_ x-ms-office365-filtering-correlation-id: 65041d5c-b265-4fa4-7611-08dad1eea79d nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MwDt4kK3eCkUW19zpsLk8NpSurrlJ2ECiszvT90IIuZADDbg0ELNxwxWdAa79uNL4dtkwa/UqbCveAuF7ng3cfkg4ocTLzvpAAyyIvbf2qNtpD/h5jPZM394dHDwmxyc7/qcTkNmhlYvDq2GZrB7Q8LOYaNXoVol6oNbm1zgA+RdInR70nbDuDHKEHsBMT7l1FoPD6bxW2dO9SMcQKJwsyfN8HoDf4zurAEOs14A3zH5HOiXEyp+ZlGxkEOr22KfICaC/NXP+cwoaAodV2oCPpsfHMBNgXJa+9tPKpmhoLv48+ZMFaxGoi9JqK6lt4/3TLOKx8pphtODJ1bt3n5aGbwrasnzdOEvDdGJjFtBcQ2b6MPynWOwFfrjue4E1ypwJUlsCZQquotWHbH8ZQMsZOOcWHu61RB4n+0SK262Siaq/q4JYt2wyCUiQZMOmZ6uKE9tR8V13FpTSugSND2OSyl0Mgpq5XcRPXkacELHcdybvh691b4NCBfvXsaycuqHL+n4qMAV6Ya5BJjxlL9hGf9nNLe4OZElA23y411Zr1dCJdUtnBMeMPH6CaORQxK9EqvUWMFhYxILVOT+E0kGzDHtS0HREb+o9bqp07dGsgUQDxE5lxxZjPc5orb+YpfFdQo2Xib8m4coRPfob1Ew2P3f/w3k+VKf0mgLqRocIRLAUwZygwJZlnKmNb/mEk1eETUtbCq+/eDaDoc5Vb0spmbetwZmbjilGB7/ZkHXVg0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(346002)(39860400002)(396003)(376002)(451199015)(53546011)(6486002)(71200400001)(33656002)(6506007)(38070700005)(36756003)(86362001)(38100700002)(186003)(2616005)(122000001)(6916009)(54906003)(5660300002)(91956017)(6512007)(478600001)(26005)(66556008)(2906002)(316002)(76116006)(8676002)(66476007)(8936002)(66446008)(66946007)(64756008)(41300700001)(4326008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?b0RtMHhHWGhPNHV1dGtId2tUeWc0d3p1Y1FEM3FJRkI5SnVsY1hWdzJHOXY4?= =?utf-8?B?K25uNGFpM2JZUjMyOEtJTjdzVjJJSmMvMzNkQXFiWHgxeFhSb0RKWlhTRmJR?= =?utf-8?B?SVJ3YlB5blVxNFFSYm1UZlBHdXVodHRoWFFLR2dVS1hiRU9pUEJJUEgyVHYr?= =?utf-8?B?QUhSWTdQMFY0dDZOaUhnbWRmRGVSVzNmQyt6UHo5T0J6ZmZuRXg1RFlmL2l5?= =?utf-8?B?dkRvRVhiUWJyUFJ4b3J0TnhIaFFnUm9lMGpwT1EzUlRiaUhZb2VqdlVkdWxk?= =?utf-8?B?am4weWdsM0x6Qk4xaWxRMGxURWVWMXZBc3ozcEQwc0RETEtZcFVYNjYzdG5X?= =?utf-8?B?YXZYTWdUOVVpQmdESEdXK3Njd0xlTGVUQk9QU1BLWC9jUld6MHpjOVZtdE9z?= =?utf-8?B?L0pzKzBjaUJYNXM1VVNvcmJwTmR0eUxSZnFPVFNWWVhjU053RnRrWXVOWkJC?= =?utf-8?B?b1IxRzB6Q2NxbVVVRDlaWlZpRmFHNTFtYXBIYUVZQW9aOERIbjN3S3BSSTlC?= =?utf-8?B?U2M3THRIUHBMMmNIUFhBZnFYSE42SWovcG9XK0tuaXQrRmdWSnRzRTRoWG1U?= =?utf-8?B?cjVWRFdJQUtFMTJ5ZmplamlqbytWK3FOVzNiVzdyUzE1YllWdVhSODZNUll5?= =?utf-8?B?T0F4UVZWd2M1ZWFvdnBISzNjdE4vbEN1MDRBTkUxTTNKKzhOclpNcUhMdWJ6?= =?utf-8?B?NGRsRFBuL1VQa0diakxHNG84WDNoZzAzejU1aWErWDI2NHRnZE5yUjRkbGxN?= =?utf-8?B?SlNrc3B5TncvZW1SZHRFclRZYnE5KzRyemRTS1VEUmgzY3NNRGlsTzR4Zkdi?= =?utf-8?B?bDk4a3NpKzlQbm5za2JEZ0MzTjVyd016ckVZTFpJNUlOS3lkc2pjblpqakYx?= =?utf-8?B?SjZiUmM5UlJMTmtLWTNSNzhkYW9WQ2syaG94Y3M0dk9ib3VPYTRHK1JHczJH?= =?utf-8?B?a01OQStTd0xXV0lES1IyQVJ2Wkh4NndoRmVEbERkY1dNcHhpQ0NqV0NNek1a?= =?utf-8?B?Z0p1blVweTVicGdjNWRNVStrSTA1SWlBbndGNWp0dWU4cVBsT3hkM2ZFR0lR?= =?utf-8?B?bmZhWjY2NisrOHFFZ3RiYjBDdk03dStNSlpyc3ZkOW02WEptNjd4QWRrczh4?= =?utf-8?B?bkwwOHYrR1VhMXhDYTJXa2xDRlRRN01zOEVwamFEWHQxMmhMRnluQUVtcnND?= =?utf-8?B?cGZsWGhvOUlYOGk5R1lLcnl5bm44bWxyUzRMaWc5dEhyZGhJNGdCWUpQdUYy?= =?utf-8?B?dUpMRnh3ckUrWG9kTEhwcEM1NjN4M1dFRTM4VWlUYU1TSnRWano5ZHFub0FD?= =?utf-8?B?dWJKYit3K0VVQjZycjMyU3RCOUlJU3hzVUdPNnBpaXlJYWZlOVhWeURjWXBi?= =?utf-8?B?bk5WWXVteGwrb0RUa0JWMmhuN3lqUzAyY3g3elp4NkUyYUNiN1JKNXluWmgr?= =?utf-8?B?OUxuTmV6em1pRkdQVldXVnJJb3VoM1RUK1ZlU2lMZGtSZXFuVzJiT3ZFR2Fp?= =?utf-8?B?a0NpQWYzakZ6SVg5VUFnSEYwaC9sMWdpMW9mR1ltdTdEQ2VjZ1UxbkVDelpq?= =?utf-8?B?d1p5Z3J5b1ByV0FqODlIRWczWEVreXM3Z0ZPSnR1bERuUVBoaTFvOEsyTVI5?= =?utf-8?B?Z0kwVjNZVnpNcWVtMUNNalhRVVRBMDVNS0lNMUFpNzRCTklwY0p1Nk1hSVBa?= =?utf-8?B?QnhPeFpDdHh3NlEwSWhBVlBycmFTc3JFMG5BWHJWZzFKU2owekR2UDd5L2Rn?= =?utf-8?B?YmpjZzBMVUNZa20rTHg1VVdjVjlZQ0xuclFlT1RvWEtQL2Yxakw4RWM2bm1U?= =?utf-8?B?SDNOWE92eHZOTTRtSC90NmI5c3V4T1Z2bVloeThBRmh1U0tPdU9zRlU0UFp2?= =?utf-8?B?STgrVVZIdy9kWmZBMzZnNDQ5MG14M29MU2lhTlI0RVNMa1VRSEtZbThCWVlz?= =?utf-8?B?NEhJc2dDRFp2cUFISVpLZ0ViVnpHNHZHc1RzMi9YemI3eng4YTFvUUdSRUM5?= =?utf-8?B?aEZXUGtPdmpHSzBRckNIcE9uZUZWMndjeElBblp4dEdXV0dSdzZkR2JxbS9O?= =?utf-8?B?cFhQWWRUSE52YktRMXQrYkdCSWxHeGtzbzRCci9zdEdWVUZ6d0FQQlYwU0ph?= =?utf-8?B?enhwOE5FeDRHRlUvcWRzMGJ4VDNxYldsT21VRHJvOGhMbjdqRTkvb2Rac1Vk?= =?utf-8?B?aEE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB3749.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65041d5c-b265-4fa4-7611-08dad1eea79d X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 09:46:57.0257 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ocHeke6VGn/mB8tx75dD8DbWsdrKwNJXp7JLqhU3S1snFY+hadFDeoVRz8l0QBf0uTHDWIQKZP43sT0C+PgWpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10025 DQoNCj4gT24gMjkgTm92IDIwMjIsIGF0IDAxOjU1LCBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFi ZWxsaW5pQGtlcm5lbC5vcmc+IHdyb3RlOg0KPiANCj4gT24gTW9uLCAyOCBOb3YgMjAyMiwgTHVj YSBGYW5jZWxsdSB3cm90ZToNCj4+IFRoaXMgc2VyaWUgaW50cm9kdWNlcyBhIHdheSB0byBzdXBw cmVzcyBhIHN0YXRpYyBhbmFseXNlciBmaW5kaW5nIHByb3ZpZGluZyBhDQo+PiBwcm9wZXIganVz dGlmaWNhdGlvbiBmb3IgaXQuDQo+PiBUaGUgcHJvY2VzcyBpcyBleHBsYWluZWQgaW4gdGhlIGRv Y3MvbWlzcmEvZG9jdW1lbnRpbmctdmlvbGF0aW9ucy5yc3QgZG9jdW1lbnQNCj4+IHRoYXQgdGhp cyBzZXJpZSB3aWxsIHByb3ZpZGUuDQo+PiBUaGUgdG9vbHMgY3VycmVudGx5IHN1cHBvcnRlZCBh cmUgZWNsYWlyLCBjb3Zlcml0eSBhbmQgY3BwY2hlY2ssIGJ1dCB0aGUgZGVzaWduDQo+PiBpcyBv cGVuIHRvIHN1cHBvcnQgbWFueSBvdGhlciBzdGF0aWMgYW5hbHlzaXMgdG9vbC4NCj4+IA0KPj4g VGhlIGNoYW5nZXMgYXJlIHNwbGl0IGJldHdlZW4gdGhlIGZpcnN0IHR3byBwYXRjaGVzIHRvIHJl ZHVjZSB0aGUgcmV2aWV3IGVmZm9ydCwNCj4+IHRoZSBmaXJzdCBwYXRjaCBpcyBpbnRyb2R1Y2lu ZyB0aGUgZGV2aWF0aW9uIHByb2Nlc3MgZm9yIHRoZSBlY2xhaXIgYW5kIGNvdmVyaXR5DQo+PiB0 b29scywgdGhpcyBpcyBiZWNhdXNlIHRoZWlyIGFuYWx5c2lzIHN5c3RlbSBpcyBzaW1pbGFyLg0K Pj4gDQo+PiBUaGUgc2Vjb25kIHBhdGNoIGlzIGludHJvZHVjaW5nIHRoZSBzYW1lIGRldmlhdGlv biBwcm9jZXNzIGZvciBjcHBjaGVjaywNCj4+IG1vZGlmeWluZyB0aGUgY3VycmVudCB3YXkgaXQg aXMgY2FsbGVkIGZyb20gdGhlIG1ha2VmaWxlIGFuZCBpbXByb3ZpbmcgaXRzDQo+PiBhbmFseXNp cy4NCj4+IA0KPj4gVGhlIHRoaXJkIHBhdGNoIGlzIGEgZml4IGZvciBhIHRvb2wgdXNlZCBmb3Ig Y3BwY2hlY2sgYW5kIHRoZSBmb3VydGggcGF0Y2gNCj4+IGlzIGFuIGV4YW1wbGUgb2YgaG93IGEg ZGV2aWF0aW9uIGNhbiBiZSBhcHBsaWVkIGZvciBzb21lIE1JU1JBIGZpbmRpbmdzLg0KDQpIaSBT dGVmYW5vLA0KDQo+IA0KPiBJIHRyaWVkIHRlc3RpbmcgdGhpcyBzZXJpZXMgd2l0aDoNCj4gDQo+ ICMgc2NyaXB0cy94ZW4tYW5hbHlzaXMucHkgLS1idWlsZC1vbmx5IC0tY3BwY2hlY2staHRtbCAt LXJ1bi1jcHBjaGVjayAtLWNwcGNoZWNrLWJpbj0vbG9jYWwvcmVwb3MvY3BwY2hlY2svY3BwY2hl Y2sgLS1jcHBjaGVjay1odG1sLWJpbj0vbG9jYWwvcmVwb3MvY3BwY2hlY2svaHRtbHJlcG9ydC9j cHBjaGVjay1odG1scmVwb3J0DQo+IA0KPiBCdXQgSSBnZXQgdGhpcyBlcnJvcjoNCj4gDQo+IEVS Uk9SOiBDYW4ndCBmaW5kIGNwcGNoZWNrIHZlcnNpb24gb3IgdmVyc2lvbiBpcyBub3QgMi43DQo+ IA0KPiANCj4gTm90ZSB0aGF0IG15IGNwcGNoZWNrIGlzIDIuNy40Og0KPiANCj4gIyAuL2NwcGNo ZWNrIC0tdmVyc2lvbg0KPiBDcHBjaGVjayAyLjcuNA0KDQpZZXMgdGhpcyBpcyBhIGJ1ZywgSeKA mW0gc3RyaWN0bHkgY2hlY2tpbmcgZm9yIDIuNywgSSB3aWxsIG1vZGlmeSBpdCB0byAyLjcueCBp ZiB5b3UgYWdyZWUNCg0KPiANCj4gDQo+IEFmdGVyIHJlbW92aW5nIHRoZSB2ZXJzaW9uIGNoZWNr IGluIGNwcGNoZWNrX2FuYWx5c2lzLnB5LCB0aGUgcHJvY2Vzcw0KPiBzdGFydHMgY29ycmVjdGx5 Lg0KPiANCj4gQWxzbywgd2hlcmUgaXMgdGhlIG91dHB1dCBodG1sIHJlcG9ydCBjcmVhdGVkIGJ5 IGNwcGNoZWNrLWh0bWwgYnkNCj4gZGVmYXVsdD8NCg0KDQpUaGUgaHRtbCBvdXRwdXQgc2hvdWxk IGJlIGluIHRoZSB4ZW4gZm9sZGVyIFt4ZW5fcmVwb10veGVuL2NwcGNoZWNrLWh0bWxyZXBvcnQv aHRtbCBidXQgd2hlbiB5b3Ugc3BlY2lmeSAtLWJ1aWxkLW9ubHkgdGhlIHJlcG9ydHMgYXJlIG5v dCBnZW5lcmF0ZWQsIG9ubHkgdGhlIGJ1aWxkIHBoYXNlIGlzIGV4ZWN1dGVkLg0KDQpIYXZlIHlv dSB0cmllZCB3aXRob3V0IC0tYnVpbGQtb25seSB0byB0ZXN0IHRoZSByZXBvcnQgZ2VuZXJhdGlv bnM/DQoNCkNoZWVycywNCkx1Y2E= From xen-devel-bounces@lists.xenproject.org Tue Nov 29 09:47:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 09:47:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449324.705983 (Exim 4.92) (envelope-from ) id 1ozxDP-0007iQ-Gc; Tue, 29 Nov 2022 09:47:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449324.705983; Tue, 29 Nov 2022 09:47:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozxDP-0007iJ-D9; Tue, 29 Nov 2022 09:47:47 +0000 Received: by outflank-mailman (input) for mailman id 449324; Tue, 29 Nov 2022 09:47:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozxDN-0007Tu-Hn for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 09:47:45 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20626.outbound.protection.outlook.com [2a01:111:f400:7d00::626]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id df7a8942-6fca-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 10:47:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9576.eurprd04.prod.outlook.com (2603:10a6:20b:4fe::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Tue, 29 Nov 2022 09:47:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 09:47:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df7a8942-6fca-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vsq4Er78F93GLKHJWAkAHJROiJEOZhBSwas97unAkwuhvzJ4FjExfoKEPNwA505YII+CQA8GnA9n5+VL7Jt7RY9ccn1cXo27Ly7MZ2GL93IjYTTDPcCPjuGGDpfuXfNObUiGgRJ/1wgRSd039HzUt9il5Ias1+trLXrP1nyHWkSZ7VygQDGFdhFE97lpS0/FecyYG8dC8gtgQJnWx3rNMEUejou5uNx2QcLLWjhpRabWleuWVDKypfzoyA5I5VXqBmFGQXWJs4FWP1teQVhUWV/MJuXjalQ0G51Y5sv5nZquipdUJx2qJBBGmyNIpq/QChm6R0woL3EJZFMB5o20mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I02jI9rAj25nDe+zA7+o1uQNgJwgyXJpUo2Un710x+c=; b=kTkEs9+38De8eILTU+QIqSGnVPkBVkG/1nfzepbEz7k5tdIB1JI0qlJIbJ6C2o6gz7Zy4DUaZ1lKWvaedepmHfYKaBf85fe8rjmLyMruHy3nAL3YJO1SvY/iI6GPt39NqLr9bOhzY+NmO+ljt+BXzN9kVcg/faQv23cqROZSf+Vcl2NBVxwjhJYjHcph18kMRC/HfQlVuZS+vXgP+7FXrwXHeEMEz8cVDHOwg2wmOgr3WoBH6RBsrWUsigJrsY16Mg4s7x9LZpleujxJ/T4OyphQoziAhl+2X/qGat9a9W+xxgZdg3axw2aBwwq7XWXdsSmhDWHxWjoBUl3iEI0Siw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I02jI9rAj25nDe+zA7+o1uQNgJwgyXJpUo2Un710x+c=; b=3KWxuHk3DLqXiTx5uF4EVAl72zfiE1ZYkz5hK9GW/Mlx5G+zJYNf7sVPabj2KqizjvAIddV5dmbpeXTxsSu/hLkpGY2MUQAwcmrysNUuqm4lE5KEp/6UIGKyTyr/tLiqXDXo5keydkf/GL+BbpfY3h9r+PUWZT9p5VinvXLnLGMslY0i7W819mGmH6gdZBet07+bxeQ4RpzL4y19gNId/Z1X/EiO5fmeX5nFWni5/jiKV2JCodeoO4/DMXsa28MX+ZATrYQodch9qhLUKiAF40+QLtVNvrGgNiokxKEbDARHKZRmREmugMqEAnhwtXmTQz9xHAEVJCgfw6JJ66AoGA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 29 Nov 2022 10:47:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] Introduce more MISRA C rules to docs/misra/rules.rst Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, george.dunlap@citrix.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, Bertrand.Marquis@arm.com, julien@xen.org, Stefano Stabellini References: <20221129001824.2344912-1-sstabellini@kernel.org> From: Jan Beulich In-Reply-To: <20221129001824.2344912-1-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0134.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9576:EE_ X-MS-Office365-Filtering-Correlation-Id: cce8d379-6a42-42b8-cbed-08dad1eec273 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UzKzNlfh7nGt84TOH0Gh8yrOK78ciD3OqR/CuxB1GQeOsI6f/q6GZAqnwUzsKiEgmfPXlL5PJoXiayjsJp24CwiODdxw/40BqUYxTRZSvXw6qOG5hiy/5fmeyiuLR9Vt8mDpu8fAff1MZvnp6kqSK42scrJfTtNrn8T2/wrTpRT0AdJcLUetYhEQS8lxeYjiARzM7f4noYc2pGKH1NSbApVu9qSqlt17Z+OPol03kW9K7vYg/K9dw6SxHOQ6r9YbfilmO6IiVHH9RGwSJUzV+JwOvJGtSxJlgl/b7Pi6omvavznapW6pKYy2pD8V3yeVwcvWojxJ3FIL+Sy/XumsUchet8qVP0dEhxPQOHWcri8Ej+V1CBV3ZBJn3FmBxgSK2feVb9dPe06T+lV5f77VdxYKtfQI1zBCsvyzdFoWQjgoixd5CWJqzkrTF2JEZbGR8xEEj0huzelQTrHRfdPhXz+paO81SbZzkdI8mX9A0C/fuDPRLoN5+9J7lFyp0lkDpej9bPDMZ2+/o93BajaKosJx9iJtd+NvmmD9veasZcUn0vVQqIwElPgWZCdwFFYndvMvvsVeBTAUYnxJaG1J2ekTyXJ0CjX5piV+4tT1wslfLnt2bCj4A4Mw/IsE/rCHqWmECkbv5C9CWFyRP5kx7PU8LYwXkhOz3OfuR3lw1FJVIaJMZRVW40ZKvk6kVdTx+NFQVMD+05bhMDwTXXvLFnhJ+Q0e04bSlg9ZHQV8LyQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(376002)(39860400002)(136003)(346002)(451199015)(6486002)(31696002)(478600001)(6506007)(31686004)(6512007)(4326008)(36756003)(8676002)(41300700001)(2616005)(186003)(5660300002)(8936002)(316002)(26005)(53546011)(6916009)(2906002)(86362001)(4744005)(66556008)(66946007)(66476007)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVUvZE11ZVpHS1NzTitXME42ZHIvSVRJY0czdS81d0xJL2d1bFhyc3ZLRVFT?= =?utf-8?B?YWQ0K1NkRG9kTFBVSTBkWTNwR1Bhb29WVFV4Y242ZHlrRk1tVDF6ejh6RW5C?= =?utf-8?B?dHpiQ2o1RlFwa3VHSWhwbnNjdzEzS040Zkx6SmljTXJrZXJWaG43Z1dhRkUx?= =?utf-8?B?NlRIRmZjc2JQYVF6VWh4alRINnB4a1NUeFU1TXpqOGtnZGlBV20wTUtSdGp5?= =?utf-8?B?aThwMktXdUgxN3A3SG5YdUNzZzF0Vk5venU3RktyYnNaWVlyZTN5dmxBMFFT?= =?utf-8?B?b1hPLzdUeEJWaURxS2krWHhBbjM4cmlRWjFvd0FpYXovb0czbGVIc29TcnlY?= =?utf-8?B?eUNsallYYnJJNTAvSGFNMVYyT3NQZXY4M0pMRlIxL1hyRzZYTG5BT3crbjZ4?= =?utf-8?B?SnRkanRUQmJWVWZhM1lxdGgyVVVpYlVCKzFqUDkrckZ1Vm5RU1hNSGk1OG1r?= =?utf-8?B?eVZoSzN3WmNQUjhXZkpsN3liellDanZ4ekZiTDV6QnZaZEpGR1kvbkYyZHRw?= =?utf-8?B?M1BEdTVJVGYzcSsxU3RFMFBXcGYzUm1RR1VRY1R3Z2dRSHRXZHUxbTI0eFFk?= =?utf-8?B?THdzMjVIWFdobmJYNXRZbnFLSkpjOEJwVmpmYmR4NHVFMjhiMzZzd01EVlRK?= =?utf-8?B?NzJRM1BIc2VQR0E4UlQwd2JlbzhRVU1lWmJkT2tiNUF5aXhYb3M4UjN1K0NS?= =?utf-8?B?SmJsdGNnL2lQd2FUSVgrb3NLU1JiWkNxcExFempycnR6bGorVlhCbE1hdTUw?= =?utf-8?B?NFJDMnVxZmEvdU8xMUU4by80M1I4N25YazdUWEpha2RmelFmdGtUNiszSlRz?= =?utf-8?B?dXFUNjVvb2FTWmk0WjBJM2lIMnhDM29lb0k5ODM0MUJRZFl2U3RFcFpndDht?= =?utf-8?B?TXZVZ2lTWWc3TVg5amhsMnFIUFZRS1IyWEYxTnBTb1dZV00wdFVNSjNFblRH?= =?utf-8?B?cU8wTHZXWnhDY3Yxenh1VUlydFlRMnc5RStyb3Axc3d3RlFnblB1TXdLVWVj?= =?utf-8?B?dnV0TXRvV2VRdDBOcVVxUG9hN2VWQ1Bxa2U0THRVdGdqZ3k3VDcxZ285ZEJk?= =?utf-8?B?aGhGVGJuTHBZTVV3V3l3MmZzZDdmeVpSQU9aRVZkVEdzRTlORjBHUHN6RHdS?= =?utf-8?B?T2VHU0RSSkdGK2MxV0kyRDFGb2FVYTVpRmlBNkZpQnpBd2Z0M0J2V1p0Z3A2?= =?utf-8?B?MDEyOUMvTEpCT0UzNGxqRXRiUkV3TlJXY3JodHV1QU01d1J6c0p3U3BhWTBo?= =?utf-8?B?WHQvV0MzdkdPQm0vOE5mOHpvQlVWUUpvdDZyKzZEdUk1RzdZZC8wRHVTQzJP?= =?utf-8?B?Wk9vZGUyZ0dKeGpaek4xeW1PNElhaFJHTWZoYWtpaGdZVFRxUytWNm9xMG82?= =?utf-8?B?Sm5XOEt4VldPd0ZaeGxGWFpySENKaTZkcXVhK1IvcU1Yalo0ZDBTNkhHWUJ2?= =?utf-8?B?U1QrWCtPL3dhVFlWN3F0SW1USFUvcjAvTXZQQkVOMS90SzlhbjVlT0VkaHRH?= =?utf-8?B?d2RnMkZJNHdxV3Nzd213djl5YW9HbXJtdzRUNU4xU2oySDN0SkVnLy9rRUta?= =?utf-8?B?SjZYdTE2TmVHYmNJZExKbU5PK0tYNTJ0aUhrc2ZMdWtZT29MRTFEdmEyUDYw?= =?utf-8?B?WCtlcnYxNUcrWCtXUUJaQWxZVnkwQjJQWUNUcVB0R1ZKUExpbU8yTTYzZ08v?= =?utf-8?B?bnF5c1FsWHlBN01QcnZYT1MwcHdwaGk3WUVSTlFRaUFha0FZWFo2OFlSSE9q?= =?utf-8?B?dnVkZTAwUGhNS3hpbnhtUFBhekJOS3JHSStJeThMaFl5VUxaTDRwelNqUURn?= =?utf-8?B?MFIrR3hnZ1NSMnVDYXFPUERQZWFrRHg2bS83YTZZdHFteG11Wk5jTnNoU0RV?= =?utf-8?B?SlNyS3hKejZyc25tMXFqOEc4RS9XNGxHTnJUWUxDRUVhY1psS2NkWkJWQ3gy?= =?utf-8?B?aFZ3MWpCcDljME9tZzE4a3ErRDZYanRmZ1pxekJieWxVbzhmRWlwTS9Gb1ox?= =?utf-8?B?YzBXbVZiQXBQeVNKajBtOVNlckhNWFQ1bHBQRUE5WjMzaGpHektWajhPZXpv?= =?utf-8?B?bWxUMkxOUlBMN252cGVzNFB2SjNjdW9uMGtTTitTWVJsdTZQVWFLRHV1M0to?= =?utf-8?Q?MW9NbRfyGj4E7S8QmHsk4XxKW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cce8d379-6a42-42b8-cbed-08dad1eec273 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 09:47:42.3011 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GAIF/REjO0pZ9F7vJwLcim2YvfGCT6fzuT8+aLWYG6iCMl0vziguyAjMg4dqWvTbeuySfJC1xbH8nZlHg6Pl2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9576 On 29.11.2022 01:18, Stefano Stabellini wrote: > From: Stefano Stabellini > > Add the new MISRA C rules agreed by the MISRA C working group to > docs/misra/rules.rst. > > Add a comment for Rule 19.1 to explain that Eclair's findings are > "caution" reports, not violations. > > Signed-off-by: Stefano Stabellini Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Nov 29 09:49:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 09:49:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449328.705994 (Exim 4.92) (envelope-from ) id 1ozxEi-0008Ht-Rt; Tue, 29 Nov 2022 09:49:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449328.705994; Tue, 29 Nov 2022 09:49:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozxEi-0008Hm-PG; Tue, 29 Nov 2022 09:49:08 +0000 Received: by outflank-mailman (input) for mailman id 449328; Tue, 29 Nov 2022 09:49:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozxEg-0008HR-Og for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 09:49:06 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060e.outbound.protection.outlook.com [2a01:111:f400:7d00::60e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0f74efd3-6fcb-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 10:49:05 +0100 (CET) Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS8PR08MB8897.eurprd08.prod.outlook.com (2603:10a6:20b:5b8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Tue, 29 Nov 2022 09:49:02 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.5880.008; Tue, 29 Nov 2022 09:49:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f74efd3-6fcb-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eUsa4A6CkfFEOuaVMIUJQaz1N7HC2lZFsqzbpAzXBSnEuLgXCm1hRpnVeDSrEyYe/l+N4pwqHpE+VwBY7bp6PNpNKq7vPRPluP7/YdEjRuSpdatgM4TfMxo7TvRe1ox4ebijansPcHSXktAclajWySimxji453mZlfwvsJmG+X4cVOma+08uO8IzqiGcQLKrPSeyLA/3kE3vqeCnThx+iiIswix9LGCND8hYW1Rh/oNxc93TJKiEZJJI2WXF4CfczW1S+E3/7hrpQoBi+prnlMZTuc7vwFDIJjj1g55nm6ogvWlKGmeZwC1eyt6IQebbONbVYujXNHG57oux9aoZCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LY1A6ky9m0QgZs2sJRFR1OL0cmd8JIFgOo9/CEqG/ns=; b=AG9ahIyf/N0IcKxQPrFmTjpB3y+K+t9dE7MsZdhJSEL6lqS4thKdm8j0CTTnhhsQBkD1luAJygFvyRgAnX3qYQbDvD2PMvirfa5bLQN3OpvsyicXxxgzWztHkqwwZwE/bXDK/k74NTUbB3k6IR+NfAJEq0TMmGyYuSWnsrpsu30RNhWGR++GCuMqM6LTxZgR5IR4mGHCBGJhRr3gpnSd3rQyXArm4DfDRrqvZ37wzQNG+gyXR3SHfJh8Im2l7SGHzWgNzpGLJnKCJWhCy2nJX+ObTs//LmktA73IFIy/fLASxcd6WBm6BEF4+RjlugsXl5x3WdhbjEcZP5CbGXlwDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LY1A6ky9m0QgZs2sJRFR1OL0cmd8JIFgOo9/CEqG/ns=; b=Kzitrq+9wk8dWfozim7qY7ZMdhXi5RKVO15q2ACRFvyyXiLwsSDV+pZ58NH+yPywYZAlHj+1+4iFFiuz2I8ZvnrgVvyxzm/D/H6yS2SeyLIl3/ZORs91qPYBhipfx5PiGQy3+TrNApWwP7bGuppxEHXh/Ji5P4ITWa88lb9K5og= From: Luca Fancellu To: Jan Beulich CC: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 2/4] xen/scripts: add cppcheck tool to the xen-analysis.py script Thread-Topic: [PATCH 2/4] xen/scripts: add cppcheck tool to the xen-analysis.py script Thread-Index: AQHZAzNLrQ+cdSzeJ02hq/RTLwHjha5Ucy2AgAAFEACAAS8cAIAAAd6A Date: Tue, 29 Nov 2022 09:49:02 +0000 Message-ID: <901024B3-77F2-4510-8B04-4CD7FA2502D3@arm.com> References: <20221128141006.8719-1-luca.fancellu@arm.com> <20221128141006.8719-3-luca.fancellu@arm.com> <1a0f27e6-1b0e-d5cb-7f3a-337b9664eb75@suse.com> <35743861-CF6F-4B80-AFE9-182D34678FC8@arm.com> <7da53010-56dd-8d91-fde3-9fde0d76125c@suse.com> In-Reply-To: <7da53010-56dd-8d91-fde3-9fde0d76125c@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS8PR08MB8897:EE_ x-ms-office365-filtering-correlation-id: df641a5e-7185-4b0c-dd81-08dad1eef25d nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: En/W7ZuAAv/0Dw+wBFoxORehOqPGa8rQBiTNi/WBRzxs19Uz2qKq/HW1d1Ynj3XW31G6LAY8bqZTEEODn6Ew7SQnAu8LmEXvbZHu4xqkF53kTkXzzNAPbHhzstlYJA/s4EXsLPlAqH309mn+BZRsz99FEOLSjnhQIP0EVnuKhHNcbTrhk+e3386B3coXATrJYRUVfnMlstfxPUqEhoP5bjItZmLX4DPpo5MxJOHbUfuybzrwzpO9VGc+gZDKukGG4vhfB8rrpTdV8SoLwWzhQHz/MO8cS1yfWqZM4WxrZ06WoSE/G+TZo/eztO5S6exhd+5rlxGrIna35h8X9waQ8YU3nONS+j4Tr/xo6TCv39ZLZQkcoEmamhV/sRsu0EewN2E/Qvtw5ea5eLHbn+4ofiiLDAiPVOh2mzGk7zB3xnbLj6GDwyf9kv7kBiBPWnfZBZ4GlH0/mppn06cIKSYfjkKKWo+0qZKMBPamF58+nSvBxCrnV+Gtv71LCWA/Rli4lETx03ITzq3lUeXlH2/6t+YyVuQsqFfUXpZ92KcxdbL+Cdip1U7jnPeLl4Y0v9xaNUIUM1RssyEMPFq7Bu59SaVKDPrXoa6XjZpANYqu3Lk+o2hETdd15F7p8Hl45alaXZLwgxlH9ncHniqqrutrl5463ZW4IWQsf8gqv6yPeMhObH1vorkQG+wjJC2kVKIwGKpvBVl3qYEO6iDJj5O92Lky4dqwtE7lYNjdxRPNF4s= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(39860400002)(346002)(376002)(451199015)(76116006)(66946007)(64756008)(66556008)(66446008)(66476007)(8676002)(4326008)(36756003)(91956017)(38070700005)(5660300002)(54906003)(122000001)(6512007)(26005)(6916009)(316002)(86362001)(33656002)(83380400001)(2906002)(8936002)(41300700001)(186003)(2616005)(38100700002)(478600001)(6506007)(53546011)(6486002)(71200400001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cGpmNU5GTk5ueGtlVnRPZ0c1cy9tdHJmQ1RvMXhOWWNXNkE0N3U0czIwUlhU?= =?utf-8?B?WVlRd1BMeit4OHJURldjSlh3UFlJNzNCb3Fmd08xV2RXQUE2Nnd3aXBCdjVM?= =?utf-8?B?aDhpOGhXM21NakhSK3RPeitCU0JaM1lIY1BuRVRsNmt2bVhBVVg2T2p0dm9a?= =?utf-8?B?YmVaWmFmSUpkMU1QdnNRQ0tNMVdGam5WekNBQjdGWDZ6dWVPenM1VFNmb2xP?= =?utf-8?B?aGxybUJBN3A3TVNNR1Z6K0RUVU1hdU9nNGZYZnBXL0FWb3lzUGM2RXphNlRL?= =?utf-8?B?UEJ1cGJwelQ1ZWx4NWJMajFCVm5EQ1BRdExYa1NYUEd0dEVKdlhVeWhoTXpW?= =?utf-8?B?cjUvaHRXckxKckdYdEVjZ3BGeE9mcHVnMUQra0pLc0R2OTB6bnJyemdWOVhj?= =?utf-8?B?WkRPdDlRbm1xR2RhY25WditYVnQ3UEdHTXFnZmJCankycmQ3TkduNlJtTERJ?= =?utf-8?B?NHVuclRiaTljK2dVdGhJc1hxMmp5SmVUVzJ2Y2dzSXVHeFB5RytEd0tORWVv?= =?utf-8?B?Rk9PaXR3RHRRMmIzczhBdXJMdmE3R20rV2I0S3psWUtvakVKaDFFbVBNL09H?= =?utf-8?B?eCsxelIyYjBQbVRxam4rald6YVZUdnhySkJIUzNRTldSRFlZVEFiV1VPa0Z5?= =?utf-8?B?QVJIemhsdS8wcnNiVWpIMUJyeC8zUUVUMDZxNTFRRndpYTJ2dmpmcE8xOTdC?= =?utf-8?B?aTVqTmhtTSs2ZXBUVTBmV3dsRW5jZ1FBZnZEczlEREFqM28rTUd5Z1MwUGxP?= =?utf-8?B?ZjhoWFV1YkwzaTBMR0QzaDdPKzNGdXRQYjdoMEJpMXMwWEZ0cXFRT3QzNHdr?= =?utf-8?B?SllQT1o4Unlack8rNzk1RnBTR3plbmtnTVpEWFhkMzBSSFdXdFZSZlYvZU51?= =?utf-8?B?c1p6MDdEbnBnU3ZHUDExQmJ6L1d5WjEwVjVpK3RCZDZiK1htTTdKcUxHT2Rw?= =?utf-8?B?T2FBT2JKWXZWK0RzdVMzUkZCZ01DbXpGa3JVOWZQT3NMQkZvMWNkTDAzL0ho?= =?utf-8?B?eXloVDdHaDlIdjVLT2V6OU0veXh3ejhHRnBGeEN1dkZlNnZMNEw0US81Z0dR?= =?utf-8?B?TURPRGhKZWo2ckUvN1dlNlkzOERVd21ycEVVRjFNN3R0T29qUGNLa0dhWm1j?= =?utf-8?B?RnZVd3JYYTRrN2w1aTFRbmM4a1hqbWNjQnhZLzk5SjA3VVhEN0JtaURqWEhW?= =?utf-8?B?b200aEE1VktEQVRSWmRVdCtGUzE3dThlWG04OGpjbXpBNHdVRzlYMVFZOXJC?= =?utf-8?B?cEQwa1ZBYVZlREtjYytwdnRBZGNtamhVbG84V0J6bHMyTTlmek5OK1ZwWGhB?= =?utf-8?B?WFVjT1hmSFU2Q3RYUVh1ZDBtOFU0ZXdBWEVqMzdNWHlST0RFVmwvN2l2Zlpz?= =?utf-8?B?Y00xZTg2Z1pFNzd6M2xXT3l3K0xuaDhwa1dhWE5oZmlLUi9nT3hmWTNGUHN3?= =?utf-8?B?Slp5cUxaZVlqdExOeU9XWWFvVENlSnh2WkQrOW9rMnRlb0tTN3ljNEZBMDRF?= =?utf-8?B?SnVzZUtRUU1XV0l5SEszKzg4MWlEcjdNazhXTVJrQVN2KzUxcXVXK1YxZVZT?= =?utf-8?B?VWRpNGsrUGRWUEhwVmpLOXR6M1JpQm10aXBxU1VGSlNHa0o4SFdycHpsNGpr?= =?utf-8?B?L1QyUFUvMS9WRHhGZEg4WU92YWc0NmFTSk9md1AxaVJHZGVuSXQ3UDA0bk16?= =?utf-8?B?RDdBL1dNb2dodjhRZ3J1Tnc1SWRpYVowVzRLVE9Ed0o2bkxPSXk1cnIyUXMy?= =?utf-8?B?Y1lrdk96VllaTGhYR2QrK3RzN3lYREdrSWpZaWY2VURaMndDN2pRQjM1VGhw?= =?utf-8?B?MmNxSGJNVy83MUlmWEZ4SlBlOWxhSjdNckN4YnZLcGJRSWZMa1VRSGdHZFhx?= =?utf-8?B?Z2d2eitFNXVXK0JQRmcvdGgxVlJQK2lOQW5TRWtUbUFPWVAwMHdNc3VPWG5J?= =?utf-8?B?L1FxUWpZR0RqWGRqa3JsQWJ4Y1ZheSs0RmhwenRnbEJCYzh6WDhIY0xkbjBV?= =?utf-8?B?Q0x6UVFlUVBPaWRFTXQrRWJTb2daMW41KzNUMjBBcms4RkNQdjJsWmJCcERv?= =?utf-8?B?eThOVXNxRGdqajhnNE82ZlhzNEkvMWQzcURsWmVLS1lGSUptQ2NNQXVmVUZ0?= =?utf-8?B?MFljaWdPUWFxTnNBN2tmN2JxTkltcXJtTGJLaTJjQ0FGNndKaFNFQnJvM01T?= =?utf-8?B?Mmc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <094E385CB951E04ABDA146F9B5EF3E6D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB3749.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: df641a5e-7185-4b0c-dd81-08dad1eef25d X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 09:49:02.4849 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dRm5Iqyo7NEGOeNunXNNIusRkGQ3TLfJyIBEU0eCGycDW14Ihmd5ukMx18SYCOZaQhSkmHP+iTXOAPM3eBjwAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8897 DQoNCj4gT24gMjkgTm92IDIwMjIsIGF0IDA5OjQyLCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMjguMTEuMjAyMiAxNjozNywgTHVjYSBGYW5jZWxsdSB3 cm90ZToNCj4+PiBPbiAyOCBOb3YgMjAyMiwgYXQgMTU6MTksIEphbiBCZXVsaWNoIDxqYmV1bGlj aEBzdXNlLmNvbT4gd3JvdGU6DQo+Pj4gT24gMjguMTEuMjAyMiAxNToxMCwgTHVjYSBGYW5jZWxs dSB3cm90ZToNCj4+Pj4gQ2hhbmdlIGNwcGNoZWNrIGludm9jYXRpb24gbWV0aG9kIGJ5IHVzaW5n IHRoZSB4ZW4tYW5hbHlzaXMucHkNCj4+Pj4gc2NyaXB0IHVzaW5nIHRoZSBhcmd1bWVudHMgLS1y dW4tY3BwY2hlY2suDQo+Pj4+IA0KPj4+PiBOb3cgY3BwY2hlY2sgYW5hbHlzaXMgd2lsbCBidWls ZCBYZW4gd2hpbGUgdGhlIGFuYWx5c2lzIGlzIHBlcmZvcm1lZA0KPj4+PiBvbiB0aGUgc291cmNl IGZpbGVzLCBpdCB3aWxsIHByb2R1Y2UgYSB0ZXh0IHJlcG9ydCBhbmQgYW4gYWRkaXRpb25hbA0K Pj4+PiBodG1sIG91dHB1dCB3aGVuIHRoZSBzY3JpcHQgaXMgY2FsbGVkIHdpdGggLS1jcHBjaGVj ay1odG1sLg0KPj4+PiANCj4+Pj4gV2l0aCB0aGlzIHBhdGNoIGNwcGNoZWNrIHdpbGwgYmVuZWZp dCBvZiBwbGF0Zm9ybSBjb25maWd1cmF0aW9uIGZpbGVzDQo+Pj4+IHRoYXQgd2lsbCBoZWxwIGl0 IHRvIHVuZGVyc3RhbmQgdGhlIHRhcmdldCBvZiB0aGUgY29tcGlsYXRpb24gYW5kDQo+Pj4+IGlt cHJvdmUgdGhlIGFuYWx5c2lzLg0KPj4+PiANCj4+Pj4gVG8gZG8gc286DQo+Pj4+IC0gcmVtb3Zl IGNwcGNoZWNrIHJ1bGVzIGZyb20gTWFrZWZpbGUgYW5kIG1vdmUgdGhlbSB0byB0aGUgc2NyaXB0 Lg0KPj4+PiAtIFVwZGF0ZSB4ZW4tYW5hbHlzaXMucHkgd2l0aCB0aGUgY29kZSB0byBpbnRlZ3Jh dGUgY3BwY2hlY2suDQo+Pj4+IC0gbWVyZ2UgdGhlIHNjcmlwdCBtZXJnZV9jcHBjaGVja19yZXBv cnRzLnB5IGludG8gdGhlIHhlbi1hbmFseXNpcw0KPj4+PiAgc2NyaXB0IHBhY2thZ2UgYW5kIHJl d29yayB0aGUgY29kZSB0byBpbnRlZ3JhdGUgaXQuDQo+Pj4+IC0gYWRkIHBsYXRmb3JtIGNvbmZp Z3VyYXRpb24gZmlsZXMgZm9yIGNwcGNoZWNrLi4NCj4+Pj4gLSBhZGQgY3BwY2hlY2stY2Muc2gg c2NyaXB0IHRoYXQgaXMgYSB3cmFwcGVyIGZvciBjcHBjaGVjayBhbmQgaXQncw0KPj4+PiAgdXNl ZCBhcyBYZW4gY29tcGlsZXIsIGl0IHdpbGwgaW50ZXJjZXB0IGFsbCBmbGFncyBnaXZlbiBmcm9t IHRoZQ0KPj4+PiAgbWFrZSBidWlsZCBzeXN0ZW0gYW5kIGl0IHdpbGwgZXhlY3V0ZSBjcHBjaGVj ayBvbiB0aGUgY29tcGlsZWQNCj4+Pj4gIGZpbGUgdG9nZXRoZXIgd2l0aCB0aGUgZmlsZSBjb21w aWxhdGlvbi4NCj4+Pj4gLSBndWFyZGVkIGh5cGVyY2FsbC1kZWZzLmMgd2l0aCBDUFBDSEVDSyBk ZWZpbmUgYmVjYXVzZSBjcHBjaGVjaw0KPj4+PiAgZ2V0cyBjb25mdXNlZCBhcyB0aGUgZmlsZSBk b2VzIG5vdCBjb250YWluIGMgY29kZS4NCj4+Pj4gLSBhZGQgZmFsc2UtcG9zaXRpdmUtY3BwY2hl Y2suanNvbiBmaWxlDQo+Pj4+IC0gdXBkYXRlIGRvY3VtZW50YXRpb24uDQo+Pj4+IC0gdXBkYXRl IC5naXRpZ25vcmUNCj4+Pj4gDQo+Pj4+IFNpZ25lZC1vZmYtYnk6IEx1Y2EgRmFuY2VsbHUgPGx1 Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCj4+PiANCj4+PiBKdXN0IHR3byBhbmQgYSBoYWxmIHF1ZXN0 aW9ucywgbm90IGEgZnVsbCByZXZpZXc6DQo+Pj4gDQo+Pj4+IC0tLQ0KPj4+PiAuZ2l0aWdub3Jl ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDggKy0NCj4+Pj4gZG9jcy9t aXNyYS9jcHBjaGVjay50eHQgICAgICAgICAgICAgICAgICAgICAgIHwgIDI3ICstDQo+Pj4+IGRv Y3MvbWlzcmEvZG9jdW1lbnRpbmctdmlvbGF0aW9ucy5yc3QgICAgICAgICB8ICAgNyArLQ0KPj4+ PiBkb2NzL21pc3JhL2ZhbHNlLXBvc2l0aXZlLWNwcGNoZWNrLmpzb24gICAgICAgfCAgMTIgKw0K Pj4+PiBkb2NzL21pc3JhL3hlbi1zdGF0aWMtYW5hbHlzaXMucnN0ICAgICAgICAgICAgfCAgNDIg KystDQo+Pj4+IHhlbi9NYWtlZmlsZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8 IDExNiArLS0tLS0tLQ0KPj4+PiB4ZW4vaW5jbHVkZS9oeXBlcmNhbGwtZGVmcy5jICAgICAgICAg ICAgICAgICAgfCAgIDkgKw0KPj4+PiB4ZW4vc2NyaXB0cy94ZW4tYW5hbHlzaXMucHkgICAgICAg ICAgICAgICAgICAgfCAgMTggKy0NCj4+Pj4geGVuL3NjcmlwdHMveGVuX2FuYWx5c2lzL2NwcGNo ZWNrX2FuYWx5c2lzLnB5IHwgMjcyICsrKysrKysrKysrKysrKysrKw0KPj4+PiAuLi4veGVuX2Fu YWx5c2lzL2NwcGNoZWNrX3JlcG9ydF91dGlscy5weSAgICAgfCAxMzAgKysrKysrKysrDQo+Pj4+ IHhlbi9zY3JpcHRzL3hlbl9hbmFseXNpcy9nZW5lcmljX2FuYWx5c2lzLnB5ICB8ICAyMSArLQ0K Pj4+PiB4ZW4vc2NyaXB0cy94ZW5fYW5hbHlzaXMvc2V0dGluZ3MucHkgICAgICAgICAgfCAgNzcg KysrKy0NCj4+Pj4geGVuL3NjcmlwdHMveGVuX2FuYWx5c2lzL3V0aWxzLnB5ICAgICAgICAgICAg IHwgIDIxICstDQo+Pj4+IHhlbi90b29scy9jcHBjaGVjay1jYy5zaCAgICAgICAgICAgICAgICAg ICAgICB8IDIyMyArKysrKysrKysrKysrKw0KPj4+PiB4ZW4vdG9vbHMvY3BwY2hlY2stcGxhdC9h cm0zMi13Y2hhcl90NC54bWwgICAgfCAgMTcgKysNCj4+Pj4geGVuL3Rvb2xzL2NwcGNoZWNrLXBs YXQvYXJtNjQtd2NoYXJfdDIueG1sICAgIHwgIDE3ICsrDQo+Pj4+IHhlbi90b29scy9jcHBjaGVj ay1wbGF0L2FybTY0LXdjaGFyX3Q0LnhtbCAgICB8ICAxNyArKw0KPj4+PiB4ZW4vdG9vbHMvY3Bw Y2hlY2stcGxhdC94ODZfNjQtd2NoYXJfdDIueG1sICAgfCAgMTcgKysNCj4+Pj4geGVuL3Rvb2xz L2NwcGNoZWNrLXBsYXQveDg2XzY0LXdjaGFyX3Q0LnhtbCAgIHwgIDE3ICsrDQo+Pj4gDQo+Pj4g V2hhdCBhcmUgdGhlc2UgbGFzdCBmaXZlIGZpbGVzIGFib3V0PyBUaGVyZSdzIG5vdGhpbmcgYWJv dXQgdGhlbSBpbg0KPj4+IHRoZSBkZXNjcmlwdGlvbiBhZmFpY3MuDQo+PiANCj4+IFRoZXkgYXJl IGNwcGNoZWNrIHBsYXRmb3JtIGNvbmZpZ3VyYXRpb24gZmlsZXMsIHRoZXkgaGVscCBjcHBjaGVj ayB0byB1bmRlcnN0YW5kDQo+PiB0aGUgc2l6ZSBvZiB0aGUgdHlwZXMgZGVwZW5kaW5nIG9uIHRo ZSB0YXJnZXQgb2YgdGhlIGNvbXBpbGF0aW9uLg0KPj4gDQo+PiBUaGlzIHNlY3Rpb24gaW4gdGhl IGNvbW1pdCBtZXNzYWdlIGlzIHRvIGludHJvZHVjZSB0aGVtOg0KPj4gDQo+PiBXaXRoIHRoaXMg cGF0Y2ggY3BwY2hlY2sgd2lsbCBiZW5lZml0IG9mIHBsYXRmb3JtIGNvbmZpZ3VyYXRpb24gZmls ZXMNCj4+IHRoYXQgd2lsbCBoZWxwIGl0IHRvIHVuZGVyc3RhbmQgdGhlIHRhcmdldCBvZiB0aGUg Y29tcGlsYXRpb24gYW5kDQo+PiBpbXByb3ZlIHRoZSBhbmFseXNpcy4NCj4+IA0KPj4gRG8geW91 IHRoaW5rIEkgc2hvdWxkIHNheSBpdCBkaWZmZXJlbnRseT8gT3IgbWF5YmUgc2F5IHRoYXQgdGhl eSByZXNpZGUgaW4geGVuL3Rvb2xzL2NwcGNoZWNrLXBsYXQvID8NCj4gDQo+IFBlcmhhcHMgKEkg ZGlkbid0IHJlYWQgdGhhdCBwYXJhZ3JhcGggYXMgcmVsYXRpbmcgdG8gX2FueXRoaW5nXyBpbg0K PiB0cmVlKSwgZS5nLjoNCj4gDQo+IFdpdGggdGhpcyBwYXRjaCBjcHBjaGVjayB3aWxsIGJlbmVm aXQgZnJvbSBwbGF0Zm9ybSBjb25maWd1cmF0aW9uIGZpbGVzDQo+IHRoYXQgd2lsbCBoZWxwIGl0 IHRvIHVuZGVyc3RhbmQgdGhlIHRhcmdldCBvZiB0aGUgY29tcGlsYXRpb24gYW5kDQo+IGltcHJv dmUgdGhlIGFuYWx5c2lzLiBUaGVzZSBhcmUgWE1MIGZpbGVzIHBsYWNlZCBpbg0KPiB4ZW4vdG9v bHMvY3BwY2hlY2stcGxhdC8sIGRlc2NyaWJpbmcgLi4uIChJIGRvbid0IGtub3cgd2hhdCB0byBw dXQgaGVyZSkuDQo+IA0KPiBQbGVhc2Ugd3JpdGUgdGhlIGRlc2NyaXB0aW9uIGhlcmUgc3VjaCB0 aGF0IHBlb3BsZSBub3QgZmFtaWxpYXIgd2l0aA0KPiBjcHBjaGVjayAob3IgbW9yZSBnZW5lcmFs bHkgd2l0aCBhbnkgZXh0ZXJuYWwgdG9vbCkgY2FuIHN0aWxsIGZvbGxvdw0KPiB3aGF0IHlvdSdy ZSB0YWxraW5nIGFib3V0IGFuZCB3aGF0IHRoZSBwYXRjaCBpcyBkb2luZy4NCg0KT2sgSSBjYW4g bW9kaWZ5IHRoZSBkZXNjcmlwdGlvbiB0byBhZGQgbW9yZSBkZXRhaWxzDQoNCj4gDQo+Pj4+IC0t LSAvZGV2L251bGwNCj4+Pj4gKysrIGIveGVuL3NjcmlwdHMveGVuX2FuYWx5c2lzL2NwcGNoZWNr X2FuYWx5c2lzLnB5DQo+Pj4+IEBAIC0wLDAgKzEsMjcyIEBADQo+Pj4+ICsjIS91c3IvYmluL2Vu diBweXRob24zDQo+Pj4+ICsNCj4+Pj4gK2ltcG9ydCBvcywgcmUsIHNodXRpbA0KPj4+PiArZnJv bSAuIGltcG9ydCBzZXR0aW5ncywgdXRpbHMsIGNwcGNoZWNrX3JlcG9ydF91dGlscw0KPj4+PiAr DQo+Pj4+ICtjbGFzcyBHZXRNYWtlVmFyc1BoYXNlRXJyb3IoRXhjZXB0aW9uKToNCj4+Pj4gKyAg ICBwYXNzDQo+Pj4+ICsNCj4+Pj4gK2NsYXNzIENwcGNoZWNrRGVwc1BoYXNlRXJyb3IoRXhjZXB0 aW9uKToNCj4+Pj4gKyAgICBwYXNzDQo+Pj4+ICsNCj4+Pj4gK2NsYXNzIENwcGNoZWNrUmVwb3J0 UGhhc2VFcnJvcihFeGNlcHRpb24pOg0KPj4+PiArICAgIHBhc3MNCj4+Pj4gKw0KPj4+PiArQ1BQ Q0hFQ0tfQlVJTERfRElSID0gImJ1aWxkLWRpci1jcHBjaGVjayINCj4+Pj4gK0NQUENIRUNLX0hU TUxSRVBPUlRfT1VURElSID0gImNwcGNoZWNrLWh0bWxyZXBvcnQiDQo+Pj4+ICtDUFBDSEVDS19S RVBPUlRfT1VURElSID0gImNwcGNoZWNrLXJlcG9ydCINCj4+Pj4gK2NwcGNoZWNrX2V4dHJhX21h a2VfYXJncyA9ICIiDQo+Pj4+ICt4ZW5fY2MgPSAiIg0KPj4+PiArDQo+Pj4+ICtkZWYgZ2V0X21h a2VfdmFycygpOg0KPj4+PiArICAgIGdsb2JhbCB4ZW5fY2MNCj4+Pj4gKyAgICBpbnZva2VfbWFr ZSA9IHV0aWxzLmludm9rZV9jb21tYW5kKA0KPj4+PiArICAgICAgICAgICAgIm1ha2UgLUMge30g e30gZXhwb3J0LXZhcmlhYmxlLUNDIg0KPj4+PiArICAgICAgICAgICAgICAgIC5mb3JtYXQoc2V0 dGluZ3MueGVuX2Rpciwgc2V0dGluZ3MubWFrZV9mb3J3YXJkX2FyZ3MpLA0KPj4+PiArICAgICAg ICAgICAgVHJ1ZSwgR2V0TWFrZVZhcnNQaGFzZUVycm9yLA0KPj4+PiArICAgICAgICAgICAgIkVy cm9yIG9jY3VyZWQgcmV0cmlldmluZyBtYWtlIHZhcnM6XG57fSINCj4+Pj4gKyAgICAgICAgKQ0K Pj4+PiArDQo+Pj4+ICsgICAgY2NfdmFyX3JlZ2V4ID0gcmUuc2VhcmNoKCdeQ0M9KC4qKSQnLCBp bnZva2VfbWFrZSwgZmxhZ3M9cmUuTSkNCj4+Pj4gKyAgICBpZiBjY192YXJfcmVnZXg6DQo+Pj4+ ICsgICAgICAgIHhlbl9jYyA9IGNjX3Zhcl9yZWdleC5ncm91cCgxKQ0KPj4+PiArDQo+Pj4+ICsg ICAgaWYgeGVuX2NjID09ICIiOg0KPj4+PiArICAgICAgICByYWlzZSBHZXRNYWtlVmFyc1BoYXNl RXJyb3IoIkNDIHZhcmlhYmxlIG5vdCBmb3VuZCBpbiBYZW4gbWFrZSBvdXRwdXQiKQ0KPj4+IA0K Pj4+IFdoYXQgdXNlIGlzIENDIHdpdGhvdXQgQ0ZMQUdTPyBPbmNlIGFnYWluIHRoZSBkZXNjcmlw dGlvbiBjb3VsZCBkbw0KPj4+IHdpdGggY29udGFpbmluZyBzb21lIGluZm9ybWF0aW9uIG9uIHdo YXQncyBnb2luZyBvbiBoZXJlLCBhbmQgd2h5DQo+Pj4geW91IG5lZWQgdG8gZXhwb3J0IGFueSB2 YXJpYWJsZXMgaW4gdGhlIGZpcnN0IHBsYWNlLg0KPj4gDQo+PiBXZSBkb27igJl0IG5lZWQgQ0ZM QUdTIGhlcmUsIHdlIG5lZWQgb25seSBDQyB0byBnZW5lcmF0ZSBpbmNsdWRlL2dlbmVyYXRlZC9j b21waWxlci1kZWYuaCBhbmQNCj4+IHRvIHBhc3MgQ0MgdG8gdGhlIGNwcGNoZWNrLWNjLnNoIC0t Y29tcGlsZXIgYXJndW1lbnQuDQo+IA0KPiBIbW0sIEkgc2VlIHRoYXQgaW5jbHVkZS9nZW5lcmF0 ZWQvY29tcGlsZXItZGVmLmggaXMgZ2VuZXJhdGVkIGFscmVhZHkNCj4gbm93IHdpdGhvdXQgYW55 IHVzZSBvZiBDRkxBR1MuIFdoaWNoIGxvb2tzIHN1c3BpY2lvdXMgdG8gbWUuIFNhZGx5DQo+IHRo ZSB1c2VzIGluIHhlbi9NYWtlZmlsZSBhcmUgbGFja2luZyBhbnkgZGV0YWlscyBvbiB3aGF0IHRo aXMgaXMgZm9yLA0KPiBhbmQgQmVydHJhbmQncyBjb21taXQgaW50cm9kdWNpbmcgaXQgZG9lc24n dCBleHBsYWluIGl0cyBwdXJwb3NlDQo+IGVpdGhlci4gTWF5YmUgYWdhaW4gc29tZXRoaW5nIGVu dGlyZWx5IG9idmlvdXMgdG8gcGVvcGxlIGtub3dpbmcNCj4gY3BwY2hlY2sgc3VmZmljaWVudGx5 IHdlbGwgLi4uDQo+IA0KPj4gV291bGQgYSBjb21tZW50IGluIHRoZSBjb2RlIGJlIG9rPw0KPiAN Cj4gTm90IHN1cmUgKHlldCkuDQo+IA0KPiBKYW4NCg0K From xen-devel-bounces@lists.xenproject.org Tue Nov 29 09:51:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 09:51:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449335.706005 (Exim 4.92) (envelope-from ) id 1ozxGl-0001LV-A4; Tue, 29 Nov 2022 09:51:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449335.706005; Tue, 29 Nov 2022 09:51:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozxGl-0001LO-72; Tue, 29 Nov 2022 09:51:15 +0000 Received: by outflank-mailman (input) for mailman id 449335; Tue, 29 Nov 2022 09:51:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozxGj-0001LE-T7 for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 09:51:13 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2042.outbound.protection.outlook.com [40.107.13.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5be21da0-6fcb-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 10:51:13 +0100 (CET) Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB8611.eurprd08.prod.outlook.com (2603:10a6:20b:563::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Tue, 29 Nov 2022 09:50:39 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5880.008; Tue, 29 Nov 2022 09:50:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5be21da0-6fcb-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jm4aGdhhw52Jq2i4BHYUVbVkAALmGcZ+oDcxBjUYK5zIOdzF91YYNi0WCsi57kvZElkIXe8iTQrms3JfF7x2RRGXkVFWP6GGVA8zvHHngvtyk9ga1DX2Fz4ANrzHHt/0lM5hzqSj7K9oWsYU7tCxXO0cNnx7ILe43WTpTZFk+tyO+XvlktYTkpI4/hPk5wsILHHW0dj71PRISjbKyKKm6LB2llIo653NvLrfngfFVKqldPAX+AOpWvYUNEasFxVAh1wo2M1VqbWMwqXnbBsdpKOjhLX9iLRNsGdG45olgRYPbpEFRhwl4I99CtcmjcVKDaRNbe3mG3+boxFV+ZAVkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t5nIHmzlzR1OL4IKOJt+GMbsscZUl4pg5fcENDAO+QM=; b=F1K6dlK3O77LuSqIgQQ3q9uFqu5ofphSWNrdhQ/OUPBL/DoDT/4UTg//xte/vSC1xd4AV6CZWLRcrNGae+n9S3aEwfKpUOP9qVe7qzLAwq9Cu1A5zRL+ru6S0Xc9nd9DCAw38BkLgu8/isYQsCoDX18plfZTc4BeOlDLQIoIa7vKXJuFTG77GJtqbGks2U5ompL6HT1sDN+n49jja3L8Y6ji+PPyqI5e+pyJ7cnI9fhDnitJSep10NTcNq3lXO7ZvshegyLTLUvfDqWcQT58LOiI4jg5atEpUI0Fx6taCkunsThUsWEdCoknxdRiwT3eWLdK30rmeWWIBZ9+VYQfCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t5nIHmzlzR1OL4IKOJt+GMbsscZUl4pg5fcENDAO+QM=; b=OU8IQrA5NuQbRX0O44N+zTM+vL6yvNBYTiUuuac93RSGNtDWobApRdlixz2bQddPy7QnDraYHcb0qwS2zPuy4ZmRek9S8LNHOL/6MBDg4Z4BYfk5/7jyc1uXWJrC+0pQIAASdPc5MKEQejXnVSKKlf9KIWc0Y2l+/3sOYmey3po= From: Bertrand Marquis To: Stefano Stabellini CC: Xen developer discussion , George Dunlap , "andrew.cooper3@citrix.com" , "jbeulich@suse.com" , "roger.pau@citrix.com" , "julien@xen.org" , Stefano Stabellini Subject: Re: [PATCH] Introduce more MISRA C rules to docs/misra/rules.rst Thread-Topic: [PATCH] Introduce more MISRA C rules to docs/misra/rules.rst Thread-Index: AQHZA4gfi8O26GJwAkiNeMgx9oJ4ZK5VqQCA Date: Tue, 29 Nov 2022 09:50:38 +0000 Message-ID: <41BEA3DE-75E8-4E24-8F18-2DBBAE34822F@arm.com> References: <20221129001824.2344912-1-sstabellini@kernel.org> In-Reply-To: <20221129001824.2344912-1-sstabellini@kernel.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS8PR08MB8611:EE_ x-ms-office365-filtering-correlation-id: 92cd4628-a1c8-4c7c-d2e5-08dad1ef2b8f nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /U5HYhDL8cPW7NIfeJ22NssZiZwHu8Fqg2wF8/mVYlqds8RIgeQDjryNPmIMirPD5SJwS6fJkhQy9zea/mm0nSV7T5K4B9bU+U9YEC6mRdJQs7J9x39JQesH1N3y3f2CbslRoGYwm4INjomy+psCF/g0BJnOTK7s1P5qc61AH+nd777MY8rUyQlmuo2ipq74ej/TynXxSuP6QAuxVDzF4vXqZFD981OvkvJf60Wwf6BIqhWx9nOpAuHanjOOeGrIUt2HpWNA7n0r4mxeZomgpZeD5KRL6gPI7YoIP0zXprZ1+PdQAe73MLJMQ5I9vCPIugIZ9IxrR4e3NnJYoY5rGZBnfL7Qo+UQM4pZzg4czIfIkyqNj1IYQ/voEgpQDvPpvS8D3dZGPPnkJihQteqobV7AntUO5DTP03obsRay8NCj7b1FFKTqLYWI4ZGDnaSM4ZL8FQV+x0YVWYtrpQNZ7Iz/T/aZwEdUbFWpzbxoPmLSuHo4ng1gglF8jHpf8LVRxp2EEH7ZkpOTYno/AD63zClS9XMJq1oHurMY5khrcobXmcnCI/uFQyJmQmg3dMj1cnoi3LdRQTSl/Mmq5vSZNXaegbTDYoXj6316hMI2fRPh1gKFZWlhebY6DzeVpuE6rUESMhj1ZxHzyVld6KENdw231wxAgeZCBKnmQmBTVCrN0flrf31Ls2YSCwUqbu5MU9Rxk4NztlNnHVSTnM7mxtxYfDjfF9vJ/ErCIFjITSiezqCf4vY8xL+usA/iwjq3yTXBSuK79AUivAMQkDGr4l/RRCbWgq0f865vTlD7bGWUCsrSTTMnIxlfKJdEzr4a x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(366004)(451199015)(83380400001)(6512007)(26005)(53546011)(2906002)(6506007)(6486002)(38100700002)(86362001)(5660300002)(54906003)(38070700005)(6916009)(316002)(71200400001)(122000001)(478600001)(186003)(8676002)(76116006)(66476007)(91956017)(8936002)(66946007)(64756008)(66446008)(66556008)(2616005)(41300700001)(4326008)(36756003)(33656002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?InhYvf9+WiCmALpSIgTGVQKhEnvf78+wFGG3gynLFeLl1ngYxjkc1aHUgJDF?= =?us-ascii?Q?ne4nPziovStDWe3nsZ2e+/bnJABNzeVQFcM8PgA7Kg1rI/WULiijUngIjH87?= =?us-ascii?Q?atPp7HzhVF29HPKHJEJjESvvww/3QgVVZZePtAwU6XeXhHmW+Osrj5Ngca+j?= =?us-ascii?Q?ffwxHbK0iNBUM46HHgR7n0Po3A8mDeYTw1i4nAd3U/1rX0zYE5fRnd1EaZ+Y?= =?us-ascii?Q?dLhWjf/NUp/Lr0kqP5E1UfAyKv8yJHoJISy/Lcjg1NrEWatyS6E2rKMrDMLo?= =?us-ascii?Q?wilgxtSa3+VKUlZn80RpMrQtCAJx8avQoZ9p92tt3VJwp9oO6VdOb26Xq7l5?= =?us-ascii?Q?z50dIyr7niaTZPZ8AAfWc1PPlDZU0mYXQt6hmEOW/bPQ6yDpVvZ4RGB5BJso?= =?us-ascii?Q?xLbI9PiJapO2xyrDcAazMObT2mmF7efxJua7tOVVV9yyAzbqIQY9wWqjJ8OD?= =?us-ascii?Q?XWVI+ZfHZeRYt6QIBj3lJ+rMYkq9sOu7vuCzsHzz44ZYRKyKvGDSy6/LSlbj?= =?us-ascii?Q?dIzX7cbS/Xnku4pvh04f/kq5270uhWirJ6qGJQG79C+hBceSFyl9o4yxBZYn?= =?us-ascii?Q?cz8jvA3YH8dvtgBkFQKM2i01GT4Gn6YgW7oeOoa8vl684bVfIfoFkWB8LaIl?= =?us-ascii?Q?j+PbxXuTDymh+WTPfVTAp0n5ARQJjCrt3Mr+H0ZK3SZtYyyLbFnk3L2fbPTD?= =?us-ascii?Q?g0N92P5CAB3kRO4OKr5gny8w+p9d0wt54k/pbzr+4PSCkPcPt3WxwinbrkBv?= =?us-ascii?Q?H/y81OUbFDf4HPYun+XR19WsNL6Bw2pz9oukPD2zSefaw6/D/Qd2nZYyMhJ/?= =?us-ascii?Q?8zOQpGJWpgJ08PRkuPWQwPFoVe8liib3a8nmrNSUdLwFzdCERNOFs9JRtt2Y?= =?us-ascii?Q?mh2A5p9jgbDMsqs8cT+6wGBMVA0LcNkV9kE3R+SSvHBsRslVhDlLex1A9ee3?= =?us-ascii?Q?ThRiwnnzVFI7j+VKNkYwmAou2lmas24eDAdmzS0kQ+EguAtUgz6MT2WmSHlX?= =?us-ascii?Q?1WtiW/QcUiq5q+jFPlrdiF6jab1J9x8pPcYY6deqhmw2nA5cvyEONuXjuIxz?= =?us-ascii?Q?F/Jz5mliul18ULQVoMl7iWLtw4T1qVfyiAP5+yA4q4fIqiWg4OUtRBmmTZog?= =?us-ascii?Q?r4R4eE8uIL/rZy5vflQTKWscIwCMTQrukqrHPu4NJDjy4T3uUBLJQaLSwK1b?= =?us-ascii?Q?kpPBZr4Z1k6BRe8LZNBpdPqTjxgtfOMmpKfqeWV9jS08YfZWGj+4IrY13lF9?= =?us-ascii?Q?rKKLZYx2jAR9F6g0ZrwmNTxgao5pQxG+8euw1y2UGUrUmcv4XvRvP7C8rCpW?= =?us-ascii?Q?Pdaz1q1ytijjE0qMgwHqpRjQpNvGBH36llR4Ed/3hp4zcogLs6He7rGiQyu7?= =?us-ascii?Q?y01b0BIXjsfkoGfrFgJAGpYCBS/x0Qt6SEGAvp/UY0GW66NWe/j/BKdxjASa?= =?us-ascii?Q?KNM+yFgWYrrYD1raWqoPyE0O0J8TGBRReC6iYdzHNK3SUygc6iMyXRAPewMF?= =?us-ascii?Q?0kG9yXd04dSzIP+4FivxmXYpXYFbSfQHfA/nMxJvh0vvx4RhlI3za8qpbYFp?= =?us-ascii?Q?n5QhqQxFY/hw4OEpqTP8azpZOJ7cpyKRsVHVApxkG7BXV2GGp2up0ZANsxap?= =?us-ascii?Q?TQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB3784.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92cd4628-a1c8-4c7c-d2e5-08dad1ef2b8f X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 09:50:38.3956 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Jl2SbG0xWQiezOkohuAdFipQ/9DKxq0W1ga151E+hu9gn1qnnIqW11cgVampEXkBIivcy+BEG5WmzLY5qL1i8S+SASyb+O/LIyVxoKPXMKk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8611 Hi, > On 29 Nov 2022, at 00:18, Stefano Stabellini wro= te: >=20 > From: Stefano Stabellini >=20 > Add the new MISRA C rules agreed by the MISRA C working group to > docs/misra/rules.rst. >=20 > Add a comment for Rule 19.1 to explain that Eclair's findings are > "caution" reports, not violations. >=20 > Signed-off-by: Stefano Stabellini Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > docs/misra/rules.rst | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) >=20 > diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst > index 8a659d8d47..dcceab9388 100644 > --- a/docs/misra/rules.rst > +++ b/docs/misra/rules.rst > @@ -77,11 +77,32 @@ existing codebase are work-in-progress. > behaviour > - >=20 > + * - `Rule 2.6 `_ > + - Advisory > + - A function should not contain unused label declarations > + - > + > + * - `Rule 3.1 `_ > + - Required > + - The character sequences /* and // shall not be used within a > + comment > + - > + > * - `Rule 3.2 `_ > - Required > - Line-splicing shall not be used in // comments > - >=20 > + * - `Rule 4.1 `_ > + - Required > + - Octal and hexadecimal escape sequences shall be terminated > + - > + > + * - `Rule 4.2 `_ > + - Advisory > + - Trigraphs should not be used > + - > + > * - `Rule 5.1 `_ > - Required > - External identifiers shall be distinct > @@ -200,6 +221,21 @@ existing codebase are work-in-progress. > have an explicit return statement with an expression > - >=20 > + * - `Rule 17.6 `_ > + - Mandatory > + - The declaration of an array parameter shall not contain the > + static keyword between the [ ] > + - > + > + * - `Rule 19.1 `_ > + - Mandatory > + - An object shall not be assigned or copied to an overlapping > + object > + - Be aware that the static analysis tool Eclair might report > + several findings for Rule 19.1 of type "caution". These are > + instances where Eclair is unable to verify that the code is valid > + in regard to Rule 19.1. Caution reports are not violations. > + > * - `Rule 20.7 `_ > - Required > - Expressions resulting from the expansion of macro parameters > --=20 > 2.25.1 >=20 From xen-devel-bounces@lists.xenproject.org Tue Nov 29 12:01:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 12:01:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449353.706027 (Exim 4.92) (envelope-from ) id 1ozzJ2-0007OM-4I; Tue, 29 Nov 2022 12:01:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449353.706027; Tue, 29 Nov 2022 12:01:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozzJ2-0007OE-00; Tue, 29 Nov 2022 12:01:44 +0000 Received: by outflank-mailman (input) for mailman id 449353; Tue, 29 Nov 2022 12:01:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozzJ0-0007Cu-2w; Tue, 29 Nov 2022 12:01:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozzJ0-0004uV-15; Tue, 29 Nov 2022 12:01:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozzIz-0008So-IF; Tue, 29 Nov 2022 12:01:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ozzIz-0001tR-Hs; Tue, 29 Nov 2022 12:01:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xYWL4ykDZrc2ZoIYHBBjniCSPHRKoDfA9A/oh+c+8LA=; b=XC1mX4L/TLQmVHKp9glmI2o52q 2MHNyWfbZw1hysyx3YnS0WrKGHd0V8aWrvR7Q2qpEs/p/xyMqxVqgM+UGmkLFcLVy0iTIciErAo9I a35QWSn/7FitLAZtxDpaXF1M7apy65VBEknBtOK8Q+hacaVbbPzeGyDN7FdKoIWwuLzU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174987: all pass - PUSHED X-Osstest-Versions-This: ovmf=b92e0495221a3b298b069d9fb01e48fd2a0469f6 X-Osstest-Versions-That: ovmf=c8c978d32882413eeaf2b9917409af83af68cb5d From: osstest service owner Date: Tue, 29 Nov 2022 12:01:41 +0000 flight 174987 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174987/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b92e0495221a3b298b069d9fb01e48fd2a0469f6 baseline version: ovmf c8c978d32882413eeaf2b9917409af83af68cb5d Last test of basis 174986 2022-11-29 04:42:06 Z 0 days Testing same since 174987 2022-11-29 10:13:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Sunil V L Zhihao Li jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git c8c978d328..b92e049522 b92e0495221a3b298b069d9fb01e48fd2a0469f6 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Nov 29 12:01:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 12:01:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449352.706016 (Exim 4.92) (envelope-from ) id 1ozzIz-000790-SD; Tue, 29 Nov 2022 12:01:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449352.706016; Tue, 29 Nov 2022 12:01:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozzIz-00078t-Ok; Tue, 29 Nov 2022 12:01:41 +0000 Received: by outflank-mailman (input) for mailman id 449352; Tue, 29 Nov 2022 12:01:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ozzIy-00078n-1n for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 12:01:40 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8e353d47-6fdd-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 13:01:32 +0100 (CET) Received: from mail-mw2nam10lp2106.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.106]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2022 07:01:18 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by PH0PR03MB5814.namprd03.prod.outlook.com (2603:10b6:510:38::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 12:01:15 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%9]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 12:01:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e353d47-6fdd-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669723292; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=4ZdMAbNecvTCei3faS5kTz8Zm4XBHXYy66WOlASpKBU=; b=eAS+HAaJ8TTBbmQpAsUroXaGLheJ/mZQdNCTCyqH/G4bz585X0GjT1jr Nx1meqr2830gnk8Dzs9QjySsnzurYkMfj6VShFz6ZHziXA7xe/3vLEwAi e0VoJgaMEssEqSQae+FAFZ8GM+vIeCl4ckqovHH4faAUpJ7poC7ghMzF4 c=; X-IronPort-RemoteIP: 104.47.55.106 X-IronPort-MID: 84801930 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:0MoiKall8FY+mVM3IeqSiI3o5gz6JkRdPkR7XQ2eYbSJt1+Wr1Gzt xIWXzqFMvePZWPzKdkiaNi1pk4FusfcxoNhSAds+382FiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5g6GzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 dUBKxRSdw+Bu8aVwr2WEbNp1sA7Lda+aevzulk4pd3YJdAPZMmbBoD1v5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3ieCzWDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnzX+rANtDT+XQGvhCsGG23jdKMBMsDl6Hj8nliWyEUY9EJ BlBksYphe1onKCxdfH5XhulsDuHswQaVt54DeI38keOx7DS7gLfAXILJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaEScPIGABZQcATA0Y89fkvYc/hw7OSdAlF7S65vX3GCvx2 DSDpjkWhLgJi8MPkaKh8jjvgT22oYPSZhUo/QiRVWWghitzY5SkfMqv8kTB6uhbL5exSUOIt 3wJ3cOZ6YgmD5uAiSiMS+UlB6yy6rCONzi0qUV0A5Ar+jCp+niiVYNd+jdzIAFuKMlsUTjtZ 0H7vQJB45oVOna2BYdyYoS+DOwnybTtU9T4PtjfbsBPeYdZbwia52R1YkrW2Hri+GAokKciK Y+DeoOgAGgyDaV80CHwQPUZ2LUwgCckygvuqYvTyh2m1f+beySTQLJcaF+WNLlhsuWDvRnf9 MtZO42S0RJDXebiYy7Rt4kOMVQNKnt9DpfzwyBKStO+zsNdMDlJI5fsLXkJIeSJQ4w9ej/0w 0yA IronPort-HdrOrdr: A9a23:Hoy2K61hz+KYHPzJSd5H6QqjBcZxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjjfZq6z+8M3WBxB8baYOCCggeVxe5ZnO/fKlHbexEWldQtqJ uIDZIOb+EYZGIS5aia3ODRKadb/DDtytHMuQ6x9QYPcek8AJsQlDuRRzzrZnFedU1jP94UBZ Cc7s1Iq36JfmkWVN2yAj0oTvXOvNrCkbPheFojCwQ84AeDoDu04PqieiLolis2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv+/olbg9zoz/pEHYiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2e XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvHxUWDiXXujMTlTHZiYvAx875xQ1/80Q4Nrdt82K VE0yawsIdWNwrJmGDY68LTXx9nu0KoqT4JkPIVjVZYTYwCAYUh2rA3zQdwKtMtDSj64IcoHK 1HC9zd3u9fdRegY3XQrgBUsa+Rd0V2Oi3DblkJu8ST3TQTtmt+1VEkyMsWmWpF3I4hSrFfjt 60fphApfVrdIs7fKh9DOAOTY+cEWrWWy/BN2qUPBDOCLwHAXTQsJT6iY9Fqd1CQKZ4gqfapa 6xEW+x7QUJCgLT4Iy1rdd2Gyn2MSqAtW+H8LAc23B70oeMNIYDfxfzCmzGqPHQ3cn3MverJ8 pbB6gmfMMLVVGef7qh/zeOKaW6ekNuJfE9i5IcZ2+khP7tB8nDitH7GcyjVYYFVwxUEV/CPg == X-IronPort-AV: E=Sophos;i="5.96,203,1665460800"; d="scan'208";a="84801930" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pq0Lnsc/9DuGd4w0vSUiheNg2s7n0dEvkIe1Jk2D1q2YIag+eQ8s33GNeSSEIfENZZpoTkc0Nq43a+10fz8BgG1PyeGNdH+Z2FZzMS9D9wt4GP330rJn5nbNOZ8lR+MwPQdReKWBemLqCRxfx8f+fDMFIfw3h1vIbHkDLbSAxMn/7fGxEHQIspkRshDYX+PKChXOwPhxLutGWV9YPwc8jzUOMxynXktWvXoWihucYQGcjaEOD5rEa5Xy5OJMjKWIuA+TgAwpJfo0Ms65CfIPaDFpAayPRK5h1BTnsraAYD6E+DQqZmW7vED5ycjTBxbvPUtomLQpRNpbMmK28HYv5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+YG+AVQRkR+gMk3rt1cCpjwAw8FXJtTQTw3JF64p1vE=; b=TVYOGPUZJes9EANs5GIzGLJO6TRkJF2SAqT/nf1xfB9FXGYz/rfLFSZgQH/e6z42kkA8p73WMH4VKsUpIiQ0PyzcpJx/jUMDY3koLplmjnc7B3AKN4VzC3SLAxqT6hUenKq1No/3oygf++zXezuJIjO+OIj/Fl2WbnQMi9LSl93NJBuSYzgn5bFYqxwJrUwyypJaTxdDn10225jN4LeRR8MPbgaqFnzhCNQ0i7SyRskzgMhZekKPt21nGc+ieMoXKGBDwGdcBdYql8gL4hlidbeZ9vBVo0C1tdXtmMcOWkpEjLb8GPz1UgmmcD6DKGYImQtTuwUymEtaLwgp+Xl0Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+YG+AVQRkR+gMk3rt1cCpjwAw8FXJtTQTw3JF64p1vE=; b=FmmQMlNmEc7kjsndpbOU0UAbDpgt1GjxaQCL5kVVgyKAud4UGwPB2sStYM1EpDNik6wKjDEZ9i+XvgDK0sVDHzUdvT2H4lkVZC/o8cfcJIBjXURTduKj/JzTZf/x4RbMd4JEuklLy5v4oxzx5nILk4g5H1vDwsQ7H5CdBAjcq0M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, Roger Pau Monne , Greg Kroah-Hartman , Jiri Slaby , Juergen Gross , Boris Ostrovsky , Jan Beulich , Stefano Stabellini , Olof Johansson , Ingo Molnar , Jeremy Fitzhardinge , Chris Wright , linuxppc-dev@lists.ozlabs.org Subject: [PATCH] hvc/xen: prevent concurrent accesses to the shared ring Date: Tue, 29 Nov 2022 13:01:03 +0100 Message-Id: <20221129120107.2942-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0152.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::15) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB5814:EE_ X-MS-Office365-Filtering-Correlation-Id: eb8bed4c-2e98-4191-b0de-08dad2016aa9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IPA0hAf4G0qA0hHh5QeEguAzLSUDS9ZuSnIehxXnaqVDjTHZHQ+oK3EBasy//O8Ft9TnzztXPVlF4FbjA46SbX055+A/sdlEWIQw3EH+KtmWXnkVLtlelbsbTvq53beMSQWmZTzSInCMhYeix1QAst7U9zPGu4IzQR6Qd7Crn3oyVjQo58atYGnVfuQFpbeJc0nqflmie2npzKNCL0XJvN+tAeo73OJ9EG5XbaTbOcD6wRRe72oH4jJfP7nurvAgnGG6jJl9C04O1rBx+P6irvNmm779R/VLQ4avep6UUQus39jetrXUnqjKlDjgRN7qLoiw2JHdF1uPZYbTwfsCbK7hNW5VqTMmAQon7vBnLmlPOGrWqJV5gVB+HI4Xu49eS3nQQBJel2aGsjOj2K83a9KQYrc+P5uLNyHZq49iUo5NxkDJvxgIAQzPaWWXLUkPmKpMXHJRw3QnPjVSV5LOyTVXyvki0GzHNa6qSYaM/0waGM0TXgXpYWQdPArHO7TXqCJBGMxVeSoVNrXB/Vrd5dGfNp5/jcHeyO3u4EbrmuOSAOIYBPPjny5hEy7NnMqfNqrAlcXab/pA/fFLUQK+idGxnEAZ+Oigf6ENbEQHJhIhuQm5bGkcIdwhodf6xDXjOCDTrVb18gAAWHjUUPqtZw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(136003)(366004)(396003)(451199015)(5660300002)(7416002)(54906003)(316002)(6916009)(26005)(6512007)(82960400001)(41300700001)(2616005)(186003)(66476007)(36756003)(66946007)(8676002)(66556008)(4326008)(38100700002)(8936002)(1076003)(2906002)(83380400001)(86362001)(6506007)(6486002)(6666004)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTN0c3FSd2VDNEF3Y3orbnNvMnVsZmNyWW9UV2MrUUlnNTNJSmFwT3M3ME11?= =?utf-8?B?U0VMM3pWZFVYdzZ1MFpUeWUvS2J0M1JVUXZhSlBiN0o5N2ZVSFk1a1ZTRzdl?= =?utf-8?B?TkRxUnNlZk8zMGs4SHlyM3FpMStBQUNzOHRDSUltZVZzM2JDall1WklhWWZS?= =?utf-8?B?bWM0OHhNK29pYlhadmxKQW5lUkpvT0tjajlLdXRZdEVteDVicDZHTzlyKy9F?= =?utf-8?B?RGFwV2E3K2dHc0hPQnowaXdUc0dNV0NFZ1oxS3o0NVNTWlo4NTBoS0o4M2pj?= =?utf-8?B?VHdQTXZaNy9HblRmbkNMNnpWN0I3aUNtcjdwMXRGeVp4QlRHMUhRV1Uwd3B0?= =?utf-8?B?eEVENmM2bEc2Tk42VzFHc25jeWFDaUF4VTZzdE1uN0JWSStsY1BaeVpvMDRU?= =?utf-8?B?OUdTWDg2U0c0L0M3TU1aT1k3ZFBuRmZwNThnTlZnSUZlV3Foa29pL1U0K0Rm?= =?utf-8?B?YUhVQkQvcGYzRnFhREk2RVlYakdMaUszRG1NbVJQZnlIOUE5bU1wZzRpWGlQ?= =?utf-8?B?ZlhVbzdHUHNqSXZFWVFkSWQyQVAyL1FlczYyQUJub2tsdmlWanhIRGVVdjdr?= =?utf-8?B?L05tbjRkTzJZL1ZOdDh3THhDenBVOHR3MjhUbG45R3VURG45TXRYSGY0VDVp?= =?utf-8?B?SDdzQUs2RjRNVTVDbW5UT0l1YXZaMENnR1FtV2dvLzIyR0R6VlpET0dJR0t6?= =?utf-8?B?dVp6N0RMSkRaazAxcVM2V0ZTOFE1QlI1aUYxamxUQWZaYm1nWVRRZXNlZ3F0?= =?utf-8?B?NHE1TVNsNGE5aTRNVWkvdkVIcEdYT1VKSVhXdDBWdkpMNThvQ20xVmhDdzNt?= =?utf-8?B?bTJ6Yy9CL0ZjTGhHZW5DUlhqbHowOW5aY09Ra01oSDZUZUpPdnVtUHZJRWdx?= =?utf-8?B?bmp4Smh2OXRFalpIWjdRM3QxenBJOG5lUjR5dVZDTWhjbWEvN2h1cGF6R0xR?= =?utf-8?B?bi9ta0Y1akNYQzVURmdERVVNenpKRDdYSDBrTVlKeEVVcytIeXlhWEt3SmRI?= =?utf-8?B?dmJQN1dwdjd6eGtod1JsWFFsMlF4VExRTjlNUWxSUHdVeSs3QnVlQjRQS2hE?= =?utf-8?B?SERMSXlkSGVubG5jcFhDNzBVZjcvcUFCRUU1U3VnQU9PTWtwa3JVZzFNZTFv?= =?utf-8?B?MGhDLy9NY0ZsejMrWDJTRjNBNlpXbTdFQ1Q3eWFOcXEyWFhLaG1xcjB5T1dK?= =?utf-8?B?VGo4WmEyT0lHKzJRbHVEcUNtQlpLaGYzckRkWDZSRW84b2pucXEzU2QwNElq?= =?utf-8?B?Znp3b0VmKzVqeExoc2hPTC8yVW5HZ1ZSV0paYVZmZi9mN044Z2U2VHJ1SzB0?= =?utf-8?B?RzdSM3M1c1lReGFyWTIxT1J6WW5FM1hyR1psZTdRQ21EODlETkpBWHBmYURL?= =?utf-8?B?RnZCb0VNS2R0Y0hrUzhtTm5FVFpDdzdFOEdFdUU0cGtETjVybEZPRFkzY1BC?= =?utf-8?B?MjVRUVN6Q2x2WHBIbVJ3V04rNjI3U0swS2xhcmpHYkd6S1ZLQkJSNE1KSk5K?= =?utf-8?B?RlpxcGtBSitLOFk5Y1llMkorRWVGVmJ5OG0vOGoveWRVMXUweXFtZGYza3p5?= =?utf-8?B?U2ZsSjlZVVlOLzFhUWhLL2kwWllZUHpZWG1rWVR3UzQ2ZE5OTCtJV3RMcVhB?= =?utf-8?B?VktpN29kVEQ4ZEhhL1Z3M2htZnY5b0tTdXdqdzlUcFlHbi83UEd3czBBVFJB?= =?utf-8?B?dHViYlRpRkZVd3BsSlcwQk51ekdkUDZ1akdQOXB3THUwVEN1a3p5VDZXclc1?= =?utf-8?B?aDVSdUphZnZBdTZ2YVdNMkRPc3lxblZSTmNnUWp6WG9nVFVRKzR6SERGNDZE?= =?utf-8?B?aHhiWjJlR1V0RUthQjVRVldRQTVkY1lqUHFUbkFhUEZkcXZORlJVMjd0cUpD?= =?utf-8?B?VFVwL1N0WXFMRkFkTjZTSEdsQmVNYTlNdGxuc3VYam9YVVk2ME9yVUtmVUdD?= =?utf-8?B?N3BGeTg3VkliWllFdkpHcTlTUTF1TXk3emx2c0VER08zMG8ybFMxbjkxeHpK?= =?utf-8?B?ZS84Y3RSMFE1eTZKQmVNSFBYZTA4Q21tZUNIWmNaQmRHOVZHeHRJdU1oTXhh?= =?utf-8?B?NTQ0cWJwQWczdUZVK1FxYzhudjFDV3hrUjA2d1o1THFFbHpzZTZaUUFFVEJy?= =?utf-8?Q?m87IgA+BTp7I9mK5e9eoMUdVq?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?VFl5WVBkbHZGNEtRcDdwWFVjNXFoT21GZlVCZkdqRjdJR2xHZmhWL2FmVTh1?= =?utf-8?B?M2kvOENhWWlPYWc4TjZiWmx5TStXRDZpaEdyT2FsVllhdUwvSDY2MkV2c0hD?= =?utf-8?B?ZjlWL0FDeEpIMDMwWjZKcVh6R1ZHTWhtTkFZVjc2TVorRytCQmFWU0tQZGFF?= =?utf-8?B?YU1DK1RKRHFOSEpRRU52OUhYYkFnZlRRVXFrQytLTUV0bTBSd001aEZrUlZ6?= =?utf-8?B?YWl6OHBNKzJ5OUo3QkhVYTUrR2xnSHFiaXMyWHU4UHhlV0NaNWpWK0lGaE5X?= =?utf-8?B?YlJnbFAyL0FiVnZNaTVUcXJGem5aWmdacHZqeG5oYi91V2tsNFBKYW8zNzJY?= =?utf-8?B?cmZDVndWVVBMN3AxSUc1RGNIRU1wMUtPbDd6UnhaVUNYenNZbWVEOTlnTFhL?= =?utf-8?B?dFJ2Mld4RlpKSHhsbnB6NU1HY001ZCtMVFIrMTB2U09ic2JKZUNpVEd4a1d5?= =?utf-8?B?V3NRSFFkcGJ1VmIvdU92QzI2MjhCekNhQlhybGRBNm5QM3I1bGoyYm9VdWZt?= =?utf-8?B?VHlLVUQyNXkrblJsZkJlLzFXcDFQQlVaclV6b2RTcm8xbGJPdkFxUHFFZUd1?= =?utf-8?B?KzgxcG5mVVI4cVhUUVo5cUl4ankwSjRMZXh4Qyt6cHRkSkRoZEFsQlR4Wk5a?= =?utf-8?B?WXZ1cVR4MElNWkpnK1RRWllDMWNZVS94Z2VXVWJvOGVaRXczdVo3K2JRaVVL?= =?utf-8?B?UFJwZmp1WldNMi9DT1ZHUTBWZU1ZTEthTWx0TE5XRkY3TXZLRkxPVTZkdmhq?= =?utf-8?B?OWNNalB2VGlKcTBKdjM2MFJBNjJXYW53WFd6NFBNT25tRmtGcHpXTXYvTTRS?= =?utf-8?B?MVZrY0c0d2pOV0c0RHhRRFpzcS9ZYWduU1RzRDZNdnd6NmM2dmhMdHhBTm1v?= =?utf-8?B?cmw2YkRMcHA2Nnpvc2xyRDltbjNHckJIZHBMY0F0V0k4cURyN3QzYm9md2lh?= =?utf-8?B?aUFQSEo1ajRQQ1ltWHVYTlFUQTJJaVFLVC9BNnFvQVI0ZmJzY1VMNTJYMEdF?= =?utf-8?B?MTlTNzErTzV6c2VVVk41eWRjS3hINUtVMVJzUlRmUVhkbUtlWldhcUlsY1hm?= =?utf-8?B?MERHNElFNklSeE9ycmgwR2EvSnczMjBKa0tZUlR1SGhPblRjV1AzS3g1Qm5z?= =?utf-8?B?Yml0YXdxaVlDdHpDNXNPTkU1czRTUS9Nbi9scW9RQXNTUTZIZW5xTmNMblJX?= =?utf-8?B?UzRLZzhJNmRxT3pSY3d2bkFTUDlGR3VzcWUzNVpLSUVWNFE3MXJCZlJUSElY?= =?utf-8?B?RGxMdjhENXFpUld4VWRMM04zdHd0N29WMXovWDI0WUp3K0pBSE1FV0lIMjlk?= =?utf-8?B?SGlBaXZQNndUY0hmRDNhL2h5RkdEWjBjc3NUMytQUitMSmRKKzArVFZEcHZh?= =?utf-8?B?alhOTmFIM3VOMkhUYmlPVStvd2FrU3ptOTdLNVp5TTBhZ0cvZTVWd1gvWXNa?= =?utf-8?B?OWdISE8ybFJqYjQwRitsTHBqektqTTN2clhYREZJV2MvUWNhN1A5S3cyMjVz?= =?utf-8?B?ZGNHNWlndkRLdFM0bnR3Q3MyRTlTMmhkWjc2WWJFWWdwODJUZjE1SHFQYXFH?= =?utf-8?B?R1hYZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb8bed4c-2e98-4191-b0de-08dad2016aa9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 12:01:15.5464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ktgav4dLJYKN4nuK0T7205m95WqXQfH/XKmcrQPMr9JAjKPQQqd22t6mWoEBlFRUT0LBZ24o0fDBKxFI8F2fHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5814 The hvc machinery registers both a console and a tty device based on the hv ops provided by the specific implementation. Those two interfaces however have different locks, and there's no single locks that's shared between the tty and the console implementations, hence the driver needs to protect itself against concurrent accesses. Otherwise concurrent calls using the split interfaces are likely to corrupt the ring indexes, leaving the console unusable. Introduce a lock to xencons_info to serialize accesses to the shared ring. This is only required when using the shared memory console, concurrent accesses to the hypercall based console implementation are not an issue. Note the conditional logic in domU_read_console() is slightly modified so the notify_daemon() call can be done outside of the locked region: it's an hypercall and there's no need for it to be done with the lock held. Fixes: b536b4b96230 ('xen: use the hvc console infrastructure for Xen console') Signed-off-by: Roger Pau Monné --- While the write handler (domU_write_console()) is used by both the console and the tty ops, that's not the case for the read side (domU_read_console()). It's not obvious to me whether we could get concurrent poll calls from the poll_get_char tty hook, hence stay on the safe side also serialize read accesses in domU_read_console(). --- drivers/tty/hvc/hvc_xen.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c index 7c23112dc923..d65741983837 100644 --- a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c @@ -43,6 +43,7 @@ struct xencons_info { int irq; int vtermno; grant_ref_t gntref; + spinlock_t ring_lock; }; static LIST_HEAD(xenconsoles); @@ -84,12 +85,15 @@ static int __write_console(struct xencons_info *xencons, XENCONS_RING_IDX cons, prod; struct xencons_interface *intf = xencons->intf; int sent = 0; + unsigned long flags; + spin_lock_irqsave(&xencons->ring_lock, flags); cons = intf->out_cons; prod = intf->out_prod; mb(); /* update queue values before going on */ if ((prod - cons) > sizeof(intf->out)) { + spin_unlock_irqrestore(&xencons->ring_lock, flags); pr_err_once("xencons: Illegal ring page indices"); return -EINVAL; } @@ -99,6 +103,7 @@ static int __write_console(struct xencons_info *xencons, wmb(); /* write ring before updating pointer */ intf->out_prod = prod; + spin_unlock_irqrestore(&xencons->ring_lock, flags); if (sent) notify_daemon(xencons); @@ -141,16 +146,19 @@ static int domU_read_console(uint32_t vtermno, char *buf, int len) int recv = 0; struct xencons_info *xencons = vtermno_to_xencons(vtermno); unsigned int eoiflag = 0; + unsigned long flags; if (xencons == NULL) return -EINVAL; intf = xencons->intf; + spin_lock_irqsave(&xencons->ring_lock, flags); cons = intf->in_cons; prod = intf->in_prod; mb(); /* get pointers before reading ring */ if ((prod - cons) > sizeof(intf->in)) { + spin_unlock_irqrestore(&xencons->ring_lock, flags); pr_err_once("xencons: Illegal ring page indices"); return -EINVAL; } @@ -174,10 +182,13 @@ static int domU_read_console(uint32_t vtermno, char *buf, int len) xencons->out_cons = intf->out_cons; xencons->out_cons_same = 0; } + if (!recv && xencons->out_cons_same++ > 1) { + eoiflag = XEN_EOI_FLAG_SPURIOUS; + } + spin_unlock_irqrestore(&xencons->ring_lock, flags); + if (recv) { notify_daemon(xencons); - } else if (xencons->out_cons_same++ > 1) { - eoiflag = XEN_EOI_FLAG_SPURIOUS; } xen_irq_lateeoi(xencons->irq, eoiflag); @@ -576,6 +587,7 @@ static int __init xen_hvc_init(void) info = vtermno_to_xencons(HVC_COOKIE); info->irq = bind_evtchn_to_irq_lateeoi(info->evtchn); + spin_lock_init(&info->ring_lock); } if (info->irq < 0) info->irq = 0; /* NO_IRQ */ -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 29 13:03:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 13:03:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449366.706038 (Exim 4.92) (envelope-from ) id 1p00GZ-00062q-Kp; Tue, 29 Nov 2022 13:03:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449366.706038; Tue, 29 Nov 2022 13:03:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p00GZ-00062j-Gr; Tue, 29 Nov 2022 13:03:15 +0000 Received: by outflank-mailman (input) for mailman id 449366; Tue, 29 Nov 2022 13:03:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p00GX-00062d-Q6 for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 13:03:14 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20616.outbound.protection.outlook.com [2a01:111:f400:7d00::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c2ba2e7-6fe6-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 14:03:09 +0100 (CET) Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by PAVPR08MB9233.eurprd08.prod.outlook.com (2603:10a6:102:30a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Tue, 29 Nov 2022 13:02:58 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.5880.008; Tue, 29 Nov 2022 13:02:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c2ba2e7-6fe6-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J69l+jOPqW7cRA/CU6AS4R4FX3z+5x+kaD40Pnl5BGRT/CALnStzGmGFTts1rjpdVndBSvaRT9Yzkl4enJ1VXUqMbTSyurTRGkuJ47E84+46jAU2LmO2Hm8+PULidQngdW5+5c1Dn0nqpkg79bCLKt2QfZub+LeSbU1qA7CYO/4eVP7xAkC30Ltxags6/pa/FPZqiOUEdQLm3Een5pZkzWJgD7KdxjXafgnY2Xuh12wAbC/waNYKPsWPUfyquXEMVWEVm4mdLSzieCHc5pHfXD/N4uNqB4VmUFtvPZsa3GDXoiLzx0rQEhN+gGV/LI7fZz4H8a3f+b7sdpmbiqoICQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BwJxTQzCAK4Ik4PjUdgys7HuwYY4hrtUhi1z+4rd9G0=; b=hYrLQ1Q0TDhPwqvaFV/1GBIGIr83WqTvKEdgMCD1XZnkoKhnCVJHGW6FKTcS2sPEB3yJfdjJ8Hahd+9IZXBheBiyl37rphEP47oEe1lMQWSF3jXS0H2YK7wjPKMI5Su3NC6XJ4stplwv4cUR0mRK1N9E1gtj3x5QcI8DCjcvGiDAnwVN5KVHNq9LR3eDo6Gx1g5QD3aOJ4t3/kD4GSEPcYHdVsXVMAacCAKP/N+j/ZIhD/eNvJGmPGE/UhKJxBlVPrkMSnasypfVlzFIJWVZleHrfYcfjOcFPYqgAZlBMFcz0I7mtsvLu/35LE9J4akT0KXz4/uRAf464Uk9zWOT3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BwJxTQzCAK4Ik4PjUdgys7HuwYY4hrtUhi1z+4rd9G0=; b=bzZfZQteo5nAbcQidGRTglanv7o7iNSk2884Y6hCbs3QgEVOTPJfgDVcdMJzdMKvcoAvRSqFRjn+h6Es8iNJcUZPdq9qp3zK8g6t8T+PeCJfYHxViFsGKol0xRhcLm/pzVsolZ2E4w685tnO78eVm78LChorDVtsxatNeT4KWeM= From: Luca Fancellu To: Stefano Stabellini CC: Xen-devel , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH 0/4] Static analyser finding deviation Thread-Topic: [PATCH 0/4] Static analyser finding deviation Thread-Index: AQHZAzNMLbhXl7Jpp0uxGRE1XtEGda5VJQuAgACDlwCAADbEgA== Date: Tue, 29 Nov 2022 13:02:57 +0000 Message-ID: References: <20221128141006.8719-1-luca.fancellu@arm.com> <92158E56-BB56-4CEB-BF5A-751F78E2351F@arm.com> In-Reply-To: <92158E56-BB56-4CEB-BF5A-751F78E2351F@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|PAVPR08MB9233:EE_ x-ms-office365-filtering-correlation-id: e028f9bc-0f65-4557-867a-08dad20a09a5 nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pGWv3WND8BUds2X9goN2ZSG/HsBco6G4HBL0FqawBW15yBYmC+JEAr4I0bOoM3qtR0QhyeUFLVNKSA8c7TUO9kOMmNIeAOsTfDaX3DBGOv/8uHAWlRNYRo/LO/Q4BN/0PkrFu2dmoELlUDmUlrXVd2ZsCgCdRpXHy4qvaT03aEiaRs/eeB0HCfzdJIR14yWJZDhub3wcUMYcyVcPQBweuXm+51p+MhGX4/j7qWB3tKgNetvcYKUQS34lSxpXRFI4J1ioMxHTtr7p2o60G0vZKANMdITrNg7pr534xTQ5bZE1/otZTlET4qo5QTjHygL453iTxSQOTrrhOXfv9nwv7OVTxZhlDWlbSNKCGgCqqU+50WAzLU4ilIvE5ek2K/R0uOMTj2dx0r+4y7drGvqW+RFaFGeSC7BxWN0ciQ2EnBZxW3ISwOAEVb84GCFAzoNxOC8Nek7Ovkl7v3eoaoTh3tM11PvFeGQWAsNu6Q58qyJlu0/9Rby3BsRVbkSYxBQLp/NBsnJFODLl+OAcLvqy2+3HGr7KdtVEbDY2gX7i06CouaXrl+UDDyZx5IrAiqTXTYzeYxeBxNZpDOeZtZvccoeCGBsy3ejAXU4QbcmQ0TLSq7gmQdDuhvfBZR3iU72r9SDOJUTH1tiVi9r3XvSXaBHf4cpLnKVqhsvrRdfEbTZU3corXY+OBCO+svxxUjv5WwwmpUjG3WjMlV7zgAMNC+QMG41nU2pyirBpM07+nq8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(346002)(39860400002)(366004)(451199015)(38070700005)(33656002)(5660300002)(8676002)(86362001)(8936002)(53546011)(26005)(6512007)(6506007)(2616005)(66946007)(66476007)(66446008)(66556008)(64756008)(76116006)(186003)(91956017)(6916009)(316002)(54906003)(478600001)(6486002)(71200400001)(122000001)(41300700001)(38100700002)(4326008)(83380400001)(2906002)(36756003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eC9rSm1ucW9TQTg2RDFCb0NJSnhxZ1dLQjhiZzgyOStaNndYOVhqaEJpcnZh?= =?utf-8?B?RlJzQnF3NTFVTTkvcm1lcTRrUFRiQjRPV2s5U2JnYlNXc3I2d1dmVFFnY3J1?= =?utf-8?B?Mk54VU9uWGRFTGk1YWJtOEFYUHFvTmRQalVZK2ZINTlrck1QWnBVR3JZN1Nw?= =?utf-8?B?U29HQVMyNUlnWEtOUm5jNXNlM05DV3l2Qy9zdjFhN3d3RTJ1Y3R2OCt5T2hm?= =?utf-8?B?Mnc4SnBwcU40b1ZyTWZ4eVZ6THF0b21kdzBxQ2phL2w3QysrclM2eXQvU2k2?= =?utf-8?B?aE5LOENVa1Z5RjE1SlZMNVFCeG9rZnNVU0V5eWZTbVRYOGpPbk1zQm1UOHNp?= =?utf-8?B?c3RYNVpudmVVcVd5U1BDZUkvS2VmMGpFNHBEOWl3K1pxWllDWnlmekVRdlNy?= =?utf-8?B?UlV2YS94QStncEVwWkJCUUgrSURaamVIL2tLUTBXSWVXWEpoUUFzdUZaSVJ0?= =?utf-8?B?MFZqK0Vzd3BHTWpkdURrWDZLalZIQ1prSnl0NXZyRjJoc2ZrYlpWNlpWeEcx?= =?utf-8?B?K2dXWVZabVVydFozSzkxTWVWbHlLUjN2VE9DcW45SG5NSytOVW85OFRJTjU4?= =?utf-8?B?c1N3SWQxMFQ4NE1ZN3RudXRhYjRWdng0bWtpZTYzb052Y1pxRS9CM0FhVjRP?= =?utf-8?B?c2ZXNXpkR0c5bVVwUFQ3YUxXRjlHMG5OVG5VSkF5ZHF5b1BVbmRObHE5Y2Fl?= =?utf-8?B?NjNDei9lV2k5dW1uS0xDejgwNXV5Y2dTdFl6TFY0M0RPd3dsYkM5M3YvZER5?= =?utf-8?B?ODE5aE1jRkZmWE9Sc01QZTY2TitXTkk2Qi8zT01vWEV4dTNiMnNSRG4vYmY0?= =?utf-8?B?Vkd1bTU4WTA4dEkvUm1ISFBvMzIxclFOcW9oM01yZWc4aXBYenZ3bjUxOWhW?= =?utf-8?B?ZjVwaDNlbVJDNmRSWSttT3EwQ1JZSzhKQlY5MEpCaEErSnoxa1RHOEFtaGtw?= =?utf-8?B?cStiRDBDYlBVYWdMc0sya3lacjVwTEw1WlVJa05kSE9KVEVtRTBLbC9nU0di?= =?utf-8?B?SWlyOWtJVXcrSjRvMmdYbVA3ZmRGZ0hFamhxc2xEWXJ5bFF4NHY5LzMyOTc3?= =?utf-8?B?YzVQVE5GT08veWJqWFBpQmdEcHJTWkhHMW4zYTI0ZER2M1BDWTZ1OFRDMDBV?= =?utf-8?B?WFp0WTlGUHFnc0VIUDhWNWgyYVZNVGd3aEhmVG9kZzJ5VXNGcXZtYURuY1Zz?= =?utf-8?B?b0p0cFBma0duTWRKSDArbzVMREN1WVVFcXNHN3BTMUk0cEJLWXhTZFI0OFFm?= =?utf-8?B?cW9RYXZsbHBsakNBa1RJanhPeXQxeWZmNitQS0taNklpUE1SNjgxT2hjSWNV?= =?utf-8?B?cFAyVHR4emkzY1J6QWN3NEJCd0Q4QXNZZWtxVC9UTlJuTmF5S3VJcjJNaFVl?= =?utf-8?B?VUlaRW5ieXhON0Q2dzM5ekVJSmNJSit2UTFwRUU3dytNd2llM2FVdXh0dk15?= =?utf-8?B?WWpiZTg3VXVPejBIdmpiVnFoNGJoZGdoVGpMaXRJSlBhZkl4eXpWREg4ek5i?= =?utf-8?B?NkIxT1hNbEFOWTN6amFDcmlmMDg5K0xzTkRGTWprdWlhREl2VEtaNG1zRmZ1?= =?utf-8?B?MG5yZWF4MVBxTDhBaG4yZ2pDYTVwbTdON1FzNGFBWTl5eWdYWkludW9hd05C?= =?utf-8?B?eGZWZHY5UXkrSVdtR1lGQkhPNlRYOG9DOTFOQ0REYTNrc3YzQXlESmlHekVx?= =?utf-8?B?enhrRGc3Yzlod2pITWZMZUhjWVdCRVdPakRqT0lxQi95cEc1MFpqZG9lcExD?= =?utf-8?B?MnRuaDJUUXJELzI3RkV2ZkJVL3lnQXFvaFplZmZEVXhlajJZaXBVaUh5TGZ1?= =?utf-8?B?TkwycUFrb1o3NklsTkNSdWF4ZVNFZU80UE1tdktYdTNtL3p4YlZxV1JSMTVs?= =?utf-8?B?RWNySXg5NFBOdUdrRm9kOGRWUlFhS095Nm95WlhGZzF6TWVMZUJreW05djgy?= =?utf-8?B?UHlKM09kMmtNV0x6VFZXVTUxTVJNL1V3MkRTVTE1c1F4V0RoMFBqNWVySmNF?= =?utf-8?B?dURwM2JuN20xOUk1UHF3YkRRUXZYN3dmZ2J1d2ROc1JaZmRxNVRZeDlRQmVm?= =?utf-8?B?ZFRtMGNRNmdVY1hEQnJyWE5TTEFiM0pPbmExNThPRnVBOWw2bGZBMy9qL0hU?= =?utf-8?B?a21aUk5PalZqN0NTT1ZXZHREUVBxdElEOGNWUHlEWEZBOGM4VTBIU01xeFhW?= =?utf-8?B?QWc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <9C2CB340F602D347B43DB0E6E0EA08E7@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB3749.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e028f9bc-0f65-4557-867a-08dad20a09a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 13:02:57.9382 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9o/H78Wk2moUczs2dMbI5gMdSS3SfONQTD0ZV2w/ETycRbCN414/BJV/xd2VLkKd3TSkEOVoHjSNxzOutATewg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9233 DQoNCj4gT24gMjkgTm92IDIwMjIsIGF0IDA5OjQ2LCBMdWNhIEZhbmNlbGx1IDxMdWNhLkZhbmNl bGx1QGFybS5jb20+IHdyb3RlOg0KPiANCj4gDQo+IA0KPj4gT24gMjkgTm92IDIwMjIsIGF0IDAx OjU1LCBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+IHdyb3RlOg0K Pj4gDQo+PiBPbiBNb24sIDI4IE5vdiAyMDIyLCBMdWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4+IFRo aXMgc2VyaWUgaW50cm9kdWNlcyBhIHdheSB0byBzdXBwcmVzcyBhIHN0YXRpYyBhbmFseXNlciBm aW5kaW5nIHByb3ZpZGluZyBhDQo+Pj4gcHJvcGVyIGp1c3RpZmljYXRpb24gZm9yIGl0Lg0KPj4+ IFRoZSBwcm9jZXNzIGlzIGV4cGxhaW5lZCBpbiB0aGUgZG9jcy9taXNyYS9kb2N1bWVudGluZy12 aW9sYXRpb25zLnJzdCBkb2N1bWVudA0KPj4+IHRoYXQgdGhpcyBzZXJpZSB3aWxsIHByb3ZpZGUu DQo+Pj4gVGhlIHRvb2xzIGN1cnJlbnRseSBzdXBwb3J0ZWQgYXJlIGVjbGFpciwgY292ZXJpdHkg YW5kIGNwcGNoZWNrLCBidXQgdGhlIGRlc2lnbg0KPj4+IGlzIG9wZW4gdG8gc3VwcG9ydCBtYW55 IG90aGVyIHN0YXRpYyBhbmFseXNpcyB0b29sLg0KPj4+IA0KPj4+IFRoZSBjaGFuZ2VzIGFyZSBz cGxpdCBiZXR3ZWVuIHRoZSBmaXJzdCB0d28gcGF0Y2hlcyB0byByZWR1Y2UgdGhlIHJldmlldyBl ZmZvcnQsDQo+Pj4gdGhlIGZpcnN0IHBhdGNoIGlzIGludHJvZHVjaW5nIHRoZSBkZXZpYXRpb24g cHJvY2VzcyBmb3IgdGhlIGVjbGFpciBhbmQgY292ZXJpdHkNCj4+PiB0b29scywgdGhpcyBpcyBi ZWNhdXNlIHRoZWlyIGFuYWx5c2lzIHN5c3RlbSBpcyBzaW1pbGFyLg0KPj4+IA0KPj4+IFRoZSBz ZWNvbmQgcGF0Y2ggaXMgaW50cm9kdWNpbmcgdGhlIHNhbWUgZGV2aWF0aW9uIHByb2Nlc3MgZm9y IGNwcGNoZWNrLA0KPj4+IG1vZGlmeWluZyB0aGUgY3VycmVudCB3YXkgaXQgaXMgY2FsbGVkIGZy b20gdGhlIG1ha2VmaWxlIGFuZCBpbXByb3ZpbmcgaXRzDQo+Pj4gYW5hbHlzaXMuDQo+Pj4gDQo+ Pj4gVGhlIHRoaXJkIHBhdGNoIGlzIGEgZml4IGZvciBhIHRvb2wgdXNlZCBmb3IgY3BwY2hlY2sg YW5kIHRoZSBmb3VydGggcGF0Y2gNCj4+PiBpcyBhbiBleGFtcGxlIG9mIGhvdyBhIGRldmlhdGlv biBjYW4gYmUgYXBwbGllZCBmb3Igc29tZSBNSVNSQSBmaW5kaW5ncy4NCj4gDQo+IEhpIFN0ZWZh bm8sDQo+IA0KPj4gDQo+PiBJIHRyaWVkIHRlc3RpbmcgdGhpcyBzZXJpZXMgd2l0aDoNCj4+IA0K Pj4gIyBzY3JpcHRzL3hlbi1hbmFseXNpcy5weSAtLWJ1aWxkLW9ubHkgLS1jcHBjaGVjay1odG1s IC0tcnVuLWNwcGNoZWNrIC0tY3BwY2hlY2stYmluPS9sb2NhbC9yZXBvcy9jcHBjaGVjay9jcHBj aGVjayAtLWNwcGNoZWNrLWh0bWwtYmluPS9sb2NhbC9yZXBvcy9jcHBjaGVjay9odG1scmVwb3J0 L2NwcGNoZWNrLWh0bWxyZXBvcnQNCj4+IA0KPj4gQnV0IEkgZ2V0IHRoaXMgZXJyb3I6DQo+PiAN Cj4+IEVSUk9SOiBDYW4ndCBmaW5kIGNwcGNoZWNrIHZlcnNpb24gb3IgdmVyc2lvbiBpcyBub3Qg Mi43DQo+PiANCj4+IA0KPj4gTm90ZSB0aGF0IG15IGNwcGNoZWNrIGlzIDIuNy40Og0KPj4gDQo+ PiAjIC4vY3BwY2hlY2sgLS12ZXJzaW9uDQo+PiBDcHBjaGVjayAyLjcuNA0KPiANCj4gWWVzIHRo aXMgaXMgYSBidWcsIEnigJltIHN0cmljdGx5IGNoZWNraW5nIGZvciAyLjcsIEkgd2lsbCBtb2Rp ZnkgaXQgdG8gMi43LnggaWYgeW91IGFncmVlDQo+IA0KPj4gDQo+PiANCj4+IEFmdGVyIHJlbW92 aW5nIHRoZSB2ZXJzaW9uIGNoZWNrIGluIGNwcGNoZWNrX2FuYWx5c2lzLnB5LCB0aGUgcHJvY2Vz cw0KPj4gc3RhcnRzIGNvcnJlY3RseS4NCj4+IA0KPj4gQWxzbywgd2hlcmUgaXMgdGhlIG91dHB1 dCBodG1sIHJlcG9ydCBjcmVhdGVkIGJ5IGNwcGNoZWNrLWh0bWwgYnkNCj4+IGRlZmF1bHQ/DQo+ IA0KPiANCj4gVGhlIGh0bWwgb3V0cHV0IHNob3VsZCBiZSBpbiB0aGUgeGVuIGZvbGRlciBbeGVu X3JlcG9dL3hlbi9jcHBjaGVjay1odG1scmVwb3J0L2h0bWwgYnV0IHdoZW4geW91IHNwZWNpZnkg LS1idWlsZC1vbmx5IHRoZSByZXBvcnRzIGFyZSBub3QgZ2VuZXJhdGVkLCBvbmx5IHRoZSBidWls ZCBwaGFzZSBpcyBleGVjdXRlZC4NCj4gDQo+IEhhdmUgeW91IHRyaWVkIHdpdGhvdXQgLS1idWls ZC1vbmx5IHRvIHRlc3QgdGhlIHJlcG9ydCBnZW5lcmF0aW9ucz8NCg0KSG93ZXZlciBJ4oCZdmUg Zm91bmQgYW5vdGhlciBidWcsIHdoZW4gYnVpbGRpbmcgdXNpbmcgeW91ciBjb21tYW5kIGxpbmUg KGF0IGxlYXN0IG9uIG15IHg4NiBtYWNoaW5lKQ0KDQpJIGhhdmUgdGhhdCB4ZW4gaXMgbm90IGJ1 aWxkaW5nIGFuZCBpdOKAmXMgZW5kaW5nIHdpdGggdGhpczoNCg0KbGQgICAgLW1lbGZfeDg2XzY0 ICAtVCBhcmNoL3g4Ni94ZW4ubGRzIC1OIHByZWxpbmsubyAtLWJ1aWxkLWlkPXNoYTEgXA0KICAg IC4vY29tbW9uL3N5bWJvbHMtZHVtbXkubyAtbyAuLy54ZW4tc3ltcy4wDQpubSAtcGEgLS1mb3Jt YXQ9c3lzdiAuLy54ZW4tc3ltcy4wIFwNCgl8IC4vdG9vbHMvc3ltYm9scyAtLWFsbC1zeW1ib2xz IC0tc29ydC1ieS1uYW1lIC0tc3lzdiAtLXNvcnQgXA0KCT4uLy54ZW4tc3ltcy4wLlMNCm1ha2Ug LWYgLi9SdWxlcy5tayBvYmo9LiAuLy54ZW4tc3ltcy4wLm8NCiAgQ0MgICAgICAueGVuLXN5bXMu MC5vDQpsZCAgICAtbWVsZl94ODZfNjQgIC1UIGFyY2gveDg2L3hlbi5sZHMgLU4gcHJlbGluay5v IC0tYnVpbGQtaWQ9c2hhMSBcDQogICAgLi8ueGVuLXN5bXMuMC5vIC1vIC4vLnhlbi1zeW1zLjEN Cm5tIC1wYSAtLWZvcm1hdD1zeXN2IC4vLnhlbi1zeW1zLjEgXA0KCXwgLi90b29scy9zeW1ib2xz IC0tYWxsLXN5bWJvbHMgLS1zb3J0LWJ5LW5hbWUgLS1zeXN2IC0tc29ydCAtLWVycm9yLWR1cCBc DQoJPi4vLnhlbi1zeW1zLjEuUw0KbWFrZSAtZiAuL1J1bGVzLm1rIG9iaj0uIC4vLnhlbi1zeW1z LjEubw0KICBDQyAgICAgIC54ZW4tc3ltcy4xLm8NCmxkICAgIC1tZWxmX3g4Nl82NCAgLVQgYXJj aC94ODYveGVuLmxkcyAtTiBwcmVsaW5rLm8gLS1idWlsZC1pZD1zaGExIFwNCiAgICAtLW9ycGhh bi1oYW5kbGluZz13YXJuIC4vLnhlbi1zeW1zLjEubyAtbyB4ZW4tc3ltcw0Kbm0gLXBhIC0tZm9y bWF0PXN5c3YgLi94ZW4tc3ltcyBcDQoJfCAuL3Rvb2xzL3N5bWJvbHMgLS1hbGwtc3ltYm9scyAt LXhlbnN5bXMgLS1zeXN2IC0tc29ydCBcDQoJPi4veGVuLXN5bXMubWFwDQpybSAtZiAuLy54ZW4t c3ltcy5bMC05XSogLi8uLnhlbi1zeW1zLlswLTldKg0KICBIT1NUQ0MgIGFyY2gveDg2L2VmaS9t a3JlbG9jDQpDaGVja2luZyBhcmNoL3g4Ni9lZmkvbWtyZWxvYy5jIC4uLg0KQ2hlY2tpbmcgYXJj aC94ODYvZWZpL21rcmVsb2MuYzogQ1BQQ0hFQ0s9MTsuLi4NCm5tOiAnYXJjaC94ODYvZWZpL3Jl bG9jcy1kdW1teS5vJzogTm8gc3VjaCBmaWxlDQpubTogJ2FyY2gveDg2L2VmaS9yZWxvY3MtZHVt bXkubyc6IE5vIHN1Y2ggZmlsZQ0Kbm06ICdhcmNoL3g4Ni9lZmkvcmVsb2NzLWR1bW15Lm8nOiBO byBzdWNoIGZpbGUNCm5tOiAnYXJjaC94ODYvZWZpL3JlbG9jcy1kdW1teS5vJzogTm8gc3VjaCBm aWxlDQpubTogJ2FyY2gveDg2L2VmaS9yZWxvY3MtZHVtbXkubyc6IE5vIHN1Y2ggZmlsZQ0Kbm06 ICdhcmNoL3g4Ni9lZmkvcmVsb2NzLWR1bW15Lm8nOiBObyBzdWNoIGZpbGUNCm5tOiAnYXJjaC94 ODYvZWZpL3JlbG9jcy1kdW1teS5vJzogTm8gc3VjaCBmaWxlDQpubTogJ2FyY2gveDg2L2VmaS9y ZWxvY3MtZHVtbXkubyc6IE5vIHN1Y2ggZmlsZQ0Kbm06ICdhcmNoL3g4Ni9lZmkvcmVsb2NzLWR1 bW15Lm8nOiBObyBzdWNoIGZpbGUNCm5tOiAnYXJjaC94ODYvZWZpL3JlbG9jcy1kdW1teS5vJzog Tm8gc3VjaCBmaWxlDQpubTogJ2FyY2gveDg2L2VmaS9yZWxvY3MtZHVtbXkubyc6IE5vIHN1Y2gg ZmlsZQ0KZWNobyAiV2lsbCBzdHJpcCBkZWJ1ZyBpbmZvIGZyb20geGVuLmVmaSINCldpbGwgc3Ry aXAgZGVidWcgaW5mbyBmcm9tIHhlbi5lZmkNCmxkIC1taTM4NnBlcCAtLXN1YnN5c3RlbT0xMCAt LXN0cmlwLWRlYnVnIC0taW1hZ2UtYmFzZT0weCAtLXN0YWNrPTAsMCAtLWhlYXA9MCwwIC0tc2Vj dGlvbi1hbGlnbm1lbnQ9MHgyMDAwMDAgLS1maWxlLWFsaWdubWVudD0weDIwIC0tbWFqb3ItaW1h Z2UtdmVyc2lvbj00IC0tbWlub3ItaW1hZ2UtdmVyc2lvbj0xNyAtLW1ham9yLW9zLXZlcnNpb249 MiAtLW1pbm9yLW9zLXZlcnNpb249MCAtLW1ham9yLXN1YnN5c3RlbS12ZXJzaW9uPTIgLS1taW5v ci1zdWJzeXN0ZW0tdmVyc2lvbj0wIC0tYnVpbGQtaWQ9c2hhMSAtVCBhcmNoL3g4Ni9lZmkubGRz IC1OIHByZWxpbmsubyBhcmNoL3g4Ni9lZmkvcmVsb2NzLWR1bW15Lm8gLi9jb21tb24vc3ltYm9s cy1kdW1teS5vIC1iIHBlLXg4Ni02NCBhcmNoL3g4Ni9lZmkvYnVpbGRpZC5vIC1vIC4vLnhlbi5l ZmkuMHguMCAmJiAgbGQgLW1pMzg2cGVwIC0tc3Vic3lzdGVtPTEwIC0tc3RyaXAtZGVidWcgLS1p bWFnZS1iYXNlPTB4IC0tc3RhY2s9MCwwIC0taGVhcD0wLDAgLS1zZWN0aW9uLWFsaWdubWVudD0w eDIwMDAwMCAtLWZpbGUtYWxpZ25tZW50PTB4MjAgLS1tYWpvci1pbWFnZS12ZXJzaW9uPTQgLS1t aW5vci1pbWFnZS12ZXJzaW9uPTE3IC0tbWFqb3Itb3MtdmVyc2lvbj0yIC0tbWlub3Itb3MtdmVy c2lvbj0wIC0tbWFqb3Itc3Vic3lzdGVtLXZlcnNpb249MiAtLW1pbm9yLXN1YnN5c3RlbS12ZXJz aW9uPTAgLS1idWlsZC1pZD1zaGExIC1UIGFyY2gveDg2L2VmaS5sZHMgLU4gcHJlbGluay5vIGFy Y2gveDg2L2VmaS9yZWxvY3MtZHVtbXkubyAuL2NvbW1vbi9zeW1ib2xzLWR1bW15Lm8gLWIgcGUt eDg2LTY0IGFyY2gveDg2L2VmaS9idWlsZGlkLm8gLW8gLi8ueGVuLmVmaS4weC4wICYmIDoNCmxk OiBjYW5ub3QgZmluZCBhcmNoL3g4Ni9lZmkvcmVsb2NzLWR1bW15Lm86IE5vIHN1Y2ggZmlsZSBv ciBkaXJlY3RvcnkNCmxkOiBjYW5ub3QgZmluZCBhcmNoL3g4Ni9lZmkvYnVpbGRpZC5vOiBObyBz dWNoIGZpbGUgb3IgZGlyZWN0b3J5DQphcmNoL3g4Ni9NYWtlZmlsZToyMDc6IHJlY2lwZSBmb3Ig dGFyZ2V0ICd4ZW4uZWZpJyBmYWlsZWQNCm1ha2VbMl06ICoqKiBbeGVuLmVmaV0gRXJyb3IgMQ0K YnVpbGQubWs6OTA6IHJlY2lwZSBmb3IgdGFyZ2V0ICd4ZW4nIGZhaWxlZA0KbWFrZVsxXTogKioq IFt4ZW5dIEVycm9yIDINCk1ha2VmaWxlOjU4NTogcmVjaXBlIGZvciB0YXJnZXQgJ3hlbicgZmFp bGVkDQptYWtlOiAqKiogW3hlbl0gRXJyb3IgMg0KbWFrZTogTGVhdmluZyBkaXJlY3RvcnkgJy9k YXRhX3NkYzEvbHVjZmFuMDEva2lya3N0b25lX3hlbi94ZW4veGVuJw0KRVJST1I6IEJ1aWxkIGVy cm9yIG9jY3VyZWQgd2hlbiBydW5uaW5nOg0KbWFrZSAtQyAvZGF0YV9zZGMxL2x1Y2ZhbjAxL2tp cmtzdG9uZV94ZW4veGVuL3hlbiAgQ0M9Ii9kYXRhX3NkYzEvbHVjZmFuMDEva2lya3N0b25lX3hl bi94ZW4veGVuL3Rvb2xzL2NwcGNoZWNrLWNjLnNoIC0tY29tcGlsZXI9Z2NjIC0tY3BwY2hlY2st Y21kPWNwcGNoZWNrIC0tY3BwY2hlY2stYnVpbGQtZGlyPS9kYXRhX3NkYzEvbHVjZmFuMDEva2ly a3N0b25lX3hlbi94ZW4veGVuL2J1aWxkLWRpci1jcHBjaGVjayAtLW1heC1jdHUtZGVwdGg9MTAg LS1lbmFibGU9c3R5bGUsaW5mb3JtYXRpb24sbWlzc2luZ0luY2x1ZGUgLS10ZW1wbGF0ZT0ne2Zp bGV9KHtsaW5lfSx7Y29sdW1ufSk6e2lkfTp7c2V2ZXJpdHl9OnttZXNzYWdlfScgLS1yZWxhdGl2 ZS1wYXRocz0vZGF0YV9zZGMxL2x1Y2ZhbjAxL2tpcmtzdG9uZV94ZW4veGVuL3hlbiAtLWlubGlu ZS1zdXBwciAtLXN1cHByZXNzaW9ucy1saXN0PS9kYXRhX3NkYzEvbHVjZmFuMDEva2lya3N0b25l X3hlbi94ZW4veGVuL3N1cHByZXNzaW9uLWxpc3QudHh0IC0tc3VwcHJlc3M9J3VubWF0Y2hlZFN1 cHByZXNzaW9uOipnZW5lcmF0ZWQvY29tcGlsZXItZGVmLmgnIC0taW5jbHVkZT0vZGF0YV9zZGMx L2x1Y2ZhbjAxL2tpcmtzdG9uZV94ZW4veGVuL3hlbi9pbmNsdWRlL3hlbi9jb25maWcuaCAtRENQ UENIRUNLIC0tY3BwY2hlY2stcGxhdD0vZGF0YV9zZGMxL2x1Y2ZhbjAxL2tpcmtzdG9uZV94ZW4v eGVuL3hlbi90b29scy9jcHBjaGVjay1wbGF0IC0taWdub3JlLXBhdGg9dG9vbHMvIC0tY3BwY2hl Y2staHRtbCAtLeKAnCBidWlsZA0KDQoNCknigJl2ZSBpbnZlc3RpZ2F0ZWQgd2h5IGFuZCBpdCB0 dXJucyBvdXQgdGhhdCB0aGlzIGxpbmUgOTQgaW4geGVuL3hlbi9hcmNoL3g4Ni9hcmNoLm1rOg0K DQpYRU5fQlVJTERfRUZJIDo9ICQoY2FsbCBpZi1zdWNjZXNzLCQoQ0MpICQoQ0ZMQUdTKSAtYyAk KHNyY3RyZWUpLyQoZWZpLWNoZWNrKS5jIC1vICQoZWZpLWNoZWNrKS5vLHkpDQoNCmlzIGNhbGxp bmcgdGhlIGNvbXBpbGVyIG9uIGEgYyBmaWxlLCBzbyB0aGUgd3JhcHBlciBpcyB1c2luZyBjcHBj aGVjayBvbiBpdCwgYnV0IHNlZW1zIHRoYXQgJChBUkNIKSB2YXJpYWJsZSBpcyBub3Qgc2V0IGF0 IHRoaXMgcG9pbnQgc28gdGhlIGNhbGwgZmFpbHMgYW5kIHlvdSBkb27igJl0IHNlZSB3aHkgYmVj YXVzZSB0aGUgb3V0cHV0IGlzIHNpbGVuY2VkLg0KDQpUaGUgZml4IGlzIHNpbXBsZToNCg0KZGlm ZiAtLWdpdCBhL3hlbi9zY3JpcHRzL3hlbl9hbmFseXNpcy9jcHBjaGVja19hbmFseXNpcy5weSBi L3hlbi9zY3JpcHRzL3hlbl9hbmFseXNpcy9jcHBjaGVja19hbmFseXNpcy5weQ0KaW5kZXggZTVj MmYzYmUzZTg1Li42NDY4MjY4NTFmMGIgMTAwNjQ0DQotLS0gYS94ZW4vc2NyaXB0cy94ZW5fYW5h bHlzaXMvY3BwY2hlY2tfYW5hbHlzaXMucHkNCisrKyBiL3hlbi9zY3JpcHRzL3hlbl9hbmFseXNp cy9jcHBjaGVja19hbmFseXNpcy5weQ0KQEAgLTE4MSw2ICsxODEsNyBAQCBkZWYgZ2VuZXJhdGVf Y3BwY2hlY2tfZGVwcygpOg0KIA0KICAgICBjcHBjaGVja19jY19mbGFncyA9ICIiIi0tY29tcGls ZXI9e30gLS1jcHBjaGVjay1jbWQ9e30ge30NCiAgLS1jcHBjaGVjay1wbGF0PXt9L2NwcGNoZWNr LXBsYXQgLS1pZ25vcmUtcGF0aD10b29scy8NCisgLS1pZ25vcmUtcGF0aD1hcmNoL3g4Ni9lZmkv Y2hlY2suYw0KICIiIi5mb3JtYXQoeGVuX2NjLCBzZXR0aW5ncy5jcHBjaGVja19iaW5wYXRoLCBj cHBjaGVja19mbGFncywNCiAgICAgICAgICAgIHNldHRpbmdzLnRvb2xzX2RpcikNCiANClRoaXMg d2lsbCBpbnN0cnVjdCB0aGUgY3BwY2hlY2stY2Muc2ggd3JhcHBlciB0byBkb27igJl0IGNhbGwg dGhlIGNwcGNoZWNrIGNvZGUgb24gdGhlICphcmNoL3g4Ni9lZmkvY2hlY2suYyBmaWxlLg0KDQpJ IHdpbGwgYWRkIGl0IGluIHRoZSBuZXh0IHNlcmllIHZlcnNpb24gYXMgd2VsbCBhcyBhbGwgdGhl IGNvbW1lbnRzIGluIHRoZSBzZXJpZQ0KDQpDaGVlcnMsDQpMdWNhDQoNCj4gDQo+IENoZWVycywN Cj4gTHVjYQ0KDQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 29 13:22:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 13:22:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449373.706048 (Exim 4.92) (envelope-from ) id 1p00ZJ-0000Is-AL; Tue, 29 Nov 2022 13:22:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449373.706048; Tue, 29 Nov 2022 13:22:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p00ZJ-0000Il-7b; Tue, 29 Nov 2022 13:22:37 +0000 Received: by outflank-mailman (input) for mailman id 449373; Tue, 29 Nov 2022 13:22:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p00ZH-0000Ib-Nr; Tue, 29 Nov 2022 13:22:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p00ZH-0006hR-7N; Tue, 29 Nov 2022 13:22:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p00ZG-0001mZ-Mu; Tue, 29 Nov 2022 13:22:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1p00ZG-0001SB-MR; Tue, 29 Nov 2022 13:22:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3ERVFB1+Fd6NhwMhDwlzPITgkR68jIfpIijSRtQsQp0=; b=v5DvcYh1P/PhQ1Gj9S8Vx5oWPQ 8gFEjAog5/3WJ3nFqmMrvomMyvCL1PfkNrwyaucIwuCebnO6P7FqjEJviUgkmptpICmeBr4NEKne9 xpKkzm1yaUolmBCffGQslxS0G+fBEgMExAnkiSteMf/AjbSBNSwZyQ5Mi7XQNSolpHuM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174985: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b7b275e60bcd5f89771e865a8239325f86d9927d X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 29 Nov 2022 13:22:34 +0000 flight 174985 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174985/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux b7b275e60bcd5f89771e865a8239325f86d9927d baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 52 days Failing since 173470 2022-10-08 06:21:34 Z 52 days 100 attempts Testing same since 174975 2022-11-27 23:39:38 Z 1 days 4 attempts ------------------------------------------------------------ 1906 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 181680 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Nov 29 13:58:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 13:58:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449380.706060 (Exim 4.92) (envelope-from ) id 1p017Q-000409-Vr; Tue, 29 Nov 2022 13:57:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449380.706060; Tue, 29 Nov 2022 13:57:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p017Q-000402-Sl; Tue, 29 Nov 2022 13:57:52 +0000 Received: by outflank-mailman (input) for mailman id 449380; Tue, 29 Nov 2022 13:57:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p017P-0003zv-Cp for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 13:57:51 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20615.outbound.protection.outlook.com [2a01:111:f400:7eab::615]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cdeb65ec-6fed-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 14:57:48 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CH0PR12MB5185.namprd12.prod.outlook.com (2603:10b6:610:b8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 13:57:44 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 13:57:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cdeb65ec-6fed-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QnvSmyC8sDvgeikoa84SHXlXRbTgXvdYfXDAYW+YUa7NkAjluxGpftsfXKoceLrLqgIgnBmuylGGsbixmKLsdU4jTBQYH5BoOhhWazyBb8c3AKGzXRcyyhM2ugjnlI+VPq9TaIz+WXPIk0WgGzHSl98nqcqT5pHTAr6kxp62nviYCNtnkb4B7L1tzmIxaoZliyQch4UInOLaZ03LpFhIxEUpqNaREFByD8hCBnOySgCMeescknuhfExofms9e5P/UN4YIcb5QQPmulv5UnMEbRXXQhTCzBerkB5xM29B4NvsHozQLXWWSDL0CzT4SdGlLSeXlOJojZvWn0n4nw5oQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NAYn0sMBSm9zTuMkeKoKA4XncfcuRRaW7d+yEOLkMbQ=; b=Q7yskXpOx3JP3EvcW0RYSzkgpqqwfe0fhQJx+KfMSLRiHe4fmGpYgsk8gwksCfikXi8vI2GGZ3Vqk74lMJHy6bydMKpSR4+emK1z6ujpCAp6AuMIfir9M/zs3wXBevCmNmCxe6ASeU5gmWeFbYTP63B9L9Tkuukk7DEg6fA8zX4vG5pC0aa/SVSKeg3JVFLYtrS6fIg8DLltl/AWvthSGSvaUdzXtcX0NqLp8rtuYNuzyIhFJU2bStSaeHBtDrz3vdLWVYtKx4BT20xusRL/6m2A4BHqmEr19cjJhF5ptlKZ0MAGanwkY5REt1laQY87MdIbQghiFEBgWY96r5Porg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NAYn0sMBSm9zTuMkeKoKA4XncfcuRRaW7d+yEOLkMbQ=; b=davPU1lwv+2ywSrCcq1mhtskgN84MyWxyLTyWWpKa7S3RW7Glf/SPDE9MeU+oh04ZgFhwpyfdCUzdBreCCIqH6xFhAaevvAWvIWjYbe+nCfKvA7XMCOQvMxSR8vHKJheOktVJ6BfA/FweA7VYhhbMdsk3xQ4le8aZc4XqqDbsqE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <70651dbc-085d-706d-17d0-a419086a0700@amd.com> Date: Tue, 29 Nov 2022 13:57:38 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 From: Ayan Kumar Halder Subject: Arm: AArch32: Need suggestions to support 32 bit physical addresses To: "xen-devel@lists.xenproject.org" Cc: Julien Grall , Stefano Stabellini , "Stabellini, Stefano" , bertrand Marquis , Andre Przywara , "Volodymyr_Babchuk@epam.com" , Rahul Singh , Vladimir Murzin Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0075.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::15) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CH0PR12MB5185:EE_ X-MS-Office365-Filtering-Correlation-Id: 8742bfab-5435-441d-a91b-08dad211b08d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HFA//3rR50JhpTzquFQxRuiEmgAHeIS1naEJJHoyKNWcpWMP4svQ104df6+1rCMoFr8d+ItEio0hi9AHMohP5fIWvp6Yqbb1V7q4Nkd5XhxxXoXYXk6fjJ4r3jBz3u80wTobXZuQ6JNFGnhp9ffJ5c5ZyjyzgTkrKfqIHqiohIZ9U8v7qgCb3Zq87PGPX4BcGJI60nhXz3ofql8k/DFswETIToq7Cs7NydXPsf2ayzMI71qazq7STssek5tBSmrg9bIVhJMwfUZF8mLBXCLEcxjYoGowcUkAsIedta9Yjp/biz8E58zXl8cMNHuqa7rzoOrLn+T+TBYJ5OXXL9Cgm79EVtZY9sMl61eVxqXq4T8omq0xMrozA6eB6C1aDQgUi9GGf0dSBbRzLOKr1UP5N929/tU6vBxAWHIe++5lUd7qHwSiNTGg+Vn7/5SsPP9chIYaVoAfPsiJOLM31/3sN+89KumWw7jzsOY2Dg/0+HNp/g+N5sY3T/bohQGFtVdQ25Pu12y8lIRZd3SBYbqCI4Yflh3znBidajmJ+l+RA9VB7KZ8+nzUlYSOJbW6/1vKqt2WhfyLsLGeV92OEQ+2DBG2zC06pH15xdZ/PgMHqpyt/B20KCso4Dyj0u+ilAapK+ZPr5Dl33EU7veOSzPeF/ed1m6FUeVt2BBavwDlUUoqLE4CyjR/DVYazAFomydIXsBgeuavYGue8nFWGpGIJU/ubBDl14sZDZE8mmWkxNXJF8RIdm/Ye/hrf7DiknUNU8cO/mx18ftkRLSKba+dRYVdUsDQzKihfCIbS017TNY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(39860400002)(136003)(376002)(346002)(451199015)(966005)(31696002)(6666004)(36756003)(54906003)(6486002)(6512007)(6506007)(26005)(30864003)(478600001)(6916009)(8936002)(5660300002)(41300700001)(316002)(2906002)(66556008)(66946007)(8676002)(4326008)(66476007)(186003)(2616005)(83380400001)(38100700002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXVsdHVMSk1rM20vcS9vRWI1T0pmd2ZvM0t3Ykt3bndINWt6MnR5UEtqOW84?= =?utf-8?B?TXhITmtySG4rczZpc0xCejN6SkVnRmFybzN1QzdxQnp0dFh5eS9hOVhQd09F?= =?utf-8?B?dWh3MUJDYVlsZm9tUzJzZG5tT3o2QzJvbngvSjRLRi9razRjSyt5dE5DTngy?= =?utf-8?B?MTVLeWdMK2dsTVJIWms1dStWdVZKNCs1REkxOEswciswK1BJa1cwTGlHS3pL?= =?utf-8?B?UG94WkYxODFURDc1dXpuQXRZQ293K3BsZ0l4L2k0OUNoTHNid2VZTElMWmFk?= =?utf-8?B?RHBmYVIrblJneXovQmhmdDN3Q0o2RXRFK0pHR2x2eGNlMEVreUUrS3NGa0tP?= =?utf-8?B?RnBpSWYzM1I4VTF2b08wa3ZzTDhpSjhHUDliaWpvSW5EOUlkSHdxN3VIT2Zv?= =?utf-8?B?L3NRNDN4RVZtckYxejI5RDFzOFRaWEVhZnJWSmxwYTMrYUk5OU1UdXhLQVhj?= =?utf-8?B?b3BRREVlUzNWdTRCcnI1a3N0RlFRc2toSmRYeWtOTVZVNytGY3FDa0lLYXZQ?= =?utf-8?B?aFAza2tHWVc2TXNzblJ4OXJuZi9heUpGWU9CQUtnYm9Ha29SOERBYmNjWFlK?= =?utf-8?B?Ym84UzQ1ZUhXK3VieEdzWkZYdDUrM3RzcXhBVTA4SE9JOWJHQ0R1ZjdnYkFH?= =?utf-8?B?TThvbElQSEFndnZIQlBUY1VNTmN5Y05xSVQyU3U0R1dvVG9GSXRybjhWaHlh?= =?utf-8?B?MkFYaTRueVEzaWFma1pxQVRGYVhjM1kwZE5lZ2ZIelZEUWt5MU9CdWF4Q2dw?= =?utf-8?B?QzVjMmZrMDl1VnlxWmZ1TDV4ekFYUXZqRnVxZVlsZWpLb2RjWUw2emdram80?= =?utf-8?B?ZDVvci9YYUJnSlljZHZiZmY3ZjlrUW1nVnVsOXhwSm52YUtJMVhqU2VHRmtz?= =?utf-8?B?MGZHZWwyeU1sOXk2VjBnRWJJdVI0WEFONk93TllGOEtISm1lVWVxSjNmTHA5?= =?utf-8?B?cFk4ZWFDaGtiZ1Vuc0l5WkNPeWNOc1hnM09TT2R3ZWpVdVJtRVFRNnNtaG4r?= =?utf-8?B?am9pS3JMYTNRVG80VDluVDhtL213TEl1cEF0NXVvSitMd0pxeVFDNEFDcWhj?= =?utf-8?B?ZlVpUEVSRTNnUkJrNk9jNTBsWmNaS3A3OVlxU29XRTAvQkREVWVWNUVVQVQ1?= =?utf-8?B?VDBJdlJkZ1NOL3NqTkEyT1J6RkQveTVGbUlRSGUyRHZocTRtSmFJQXdzWStx?= =?utf-8?B?N1ZlaDZFemd4ZnJxK09tbWkyQXd1K2dpS3QzT3BGR2k0RXVadzd5M1BIUjdR?= =?utf-8?B?YVUzVXZwSEtmZjhKbHp4MmlVcnlKY1pDWTQ0MnZ5Q2dndnYxWmpDdTBoc0VJ?= =?utf-8?B?WE9hUG5KRUxzRHpBU0tabjdReitxSnFyamhuMnBqNXRrMGpOZ3dFQkdWR2Zw?= =?utf-8?B?MTlvWmZvSjR1MHZMVzBGM2d2bGpCbFV3bEVsRmlvQjNNTSs2RGd2N2dFY0Er?= =?utf-8?B?OEh6VjFlT0FUL1JYRFdxSlBKYTY2U3lBekx3Ymx1bE9iaHRYQjZ0K0pOei8x?= =?utf-8?B?aTRoM1NVR1R3UExFQnlRcFNoWjM0N3A0ZXhSeFYxNmpRRFp6WWhnN29ibkZZ?= =?utf-8?B?bWIvNmNlL0RiUk1Ec1RtTWZKUWZ1Y0o4Y0VFKzRtS2E3eFJCakcwYno1eUlr?= =?utf-8?B?Vy9uS0dOZlVWU3NHd1gzNmtxMm5LK1YxMmltWUQ5R0syTzhyYmdkVUZaRStk?= =?utf-8?B?Z3FaWmRyRmV2cVIxV05pUjk5aFZlNVY4S3huR3doVy9Jbk9FZmZuL0UvQVhh?= =?utf-8?B?aG9hMitXRGJ4NnZadkp6SlJuU2U5NCtvU05KNDcyRmxlalg0UytBV09yaDgv?= =?utf-8?B?V3RDdUdOVThlN2VDUDRMa2p4NkUzTFFiSWFtSG1temZFNFl4QTJlNTdGSTQ5?= =?utf-8?B?bnI4MGZ0MnlZTUdFVWtldmFIN2p2NllGb08xWFhTTEV6MGpFMnJoRTQ0UWNp?= =?utf-8?B?RGZsTnR0eHRCc21HaThFU0xLQXh1dlhVdUUwS2JnbEpLVm1tYk9XemdUdzVP?= =?utf-8?B?cDBJRGswdlRhSnFPZzhhaDAybnRrL3ozRGlqSGJGKzh4OFBLREpUOXM3QytM?= =?utf-8?B?TVJjYWVLWGFqNTQzRmcydVBoWVU2OW1mdUNBVWtOZ0FNNEZLMHZheWN5ZHc2?= =?utf-8?Q?vYDJX6HS0mra1S3DruLi7xP/C?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8742bfab-5435-441d-a91b-08dad211b08d X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 13:57:44.7509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8ZpNojkuhcWPF1FBeiDWfr8S8ktlTuLOGne9qGpKtiPlkFMLAlpJgA4MzKOTtqzZuACYAlg47ZuEW0nAOanJZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5185 Hi All, I am trying to gather opinions on how to support 32 bit physical addresses to enable Xen running on R52. Refer Cortex R52 TRM, Section 2.2.12 "Memory Model" "...This is because the physical address is always the same as the virtual address...The virtual and physical address can be treated as synonyms for Cortex-R52." Thus, I understand that R52 supports 32 bit physical address only. This is a bit different from Armv7 systems which supports Large Physical Address Extension (LPAE) ie 40 bit physical addresses. Please correct me if I misunderstand something. So currently, Xen supports 64 bit physical address for Arm_32 (ie Armv7) based system. My aim is to enable support for 32 bit physical address. To achieve this, I see two options :- 1. Make the changes in the specific functions for R52. https://gitlab.com/ayankuma/xen-integration/-/commit/5498cf74c2c8feadc32934b948ce5f72bd0809ee 2. Introduce a special macro (CONFIG_ARM_32_BIT_PA) to support 32 bit physical address. Thus, our change will look as follows :- diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 6014c0f852..4f8b5fc4be 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -56,10 +56,10 @@ static bool __init device_tree_node_compatible(const void *fdt, int node,  }  void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, -                                u32 size_cells, u64 *start, u64 *size) +                                u32 size_cells, paddr_t *start, paddr_t *size)  { -    *start = dt_next_cell(address_cells, cell); -    *size = dt_next_cell(size_cells, cell); +    *start = (paddr_t) dt_next_cell(address_cells, cell); +    *size = (paddr_t) dt_next_cell(size_cells, cell);  }  static int __init device_tree_get_meminfo(const void *fdt, int node, diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index bd30d3798c..3cbcf8f854 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1314,7 +1314,7 @@ static int __init make_memory_node(const struct domain *d,      dt_dprintk("Create memory node\n");      /* ePAPR 3.4 */ -    snprintf(buf, sizeof(buf), "memory@%"PRIx64, mem->bank[i].start); +    snprintf(buf, sizeof(buf), "memory@%"PRIpaddr, mem->bank[i].start);      res = fdt_begin_node(fdt, buf);      if ( res )          return res; @@ -1665,7 +1665,7 @@ static int __init find_memory_holes(const struct kernel_info *kinfo,      dt_for_each_device_node( dt_host, np )      {          unsigned int naddr; -        u64 addr, size; +        paddr_t addr, size;          naddr = dt_number_of_address(np); @@ -2444,7 +2444,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,      unsigned int naddr;      unsigned int i;      int res; -    u64 addr, size; +    paddr_t addr, size;      bool own_device = !dt_device_for_passthrough(dev);      /*       * We want to avoid mapping the MMIO in dom0 for the following cases: @@ -2718,7 +2718,7 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo)      /* Placeholder for interrupt-controller@ + a 64-bit number + \0 */      char buf[38]; -    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIx64, +    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIpaddr,               vgic_dist_base(&d->arch.vgic));      res = fdt_begin_node(fdt, buf);      if ( res ) @@ -2774,7 +2774,7 @@ static int __init make_gicv3_domU_node(struct kernel_info *kinfo)      char buf[38];      unsigned int i, len = 0; -    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIx64, +    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIpaddr,               vgic_dist_base(&d->arch.vgic));      res = fdt_begin_node(fdt, buf); @@ -2860,7 +2860,7 @@ static int __init make_vpl011_uart_node(struct kernel_info *kinfo)      /* Placeholder for sbsa-uart@ + a 64-bit number + \0 */      char buf[27]; -    snprintf(buf, sizeof(buf), "sbsa-uart@%"PRIx64, d->arch.vpl011.base_addr); +    snprintf(buf, sizeof(buf), "sbsa-uart@%"PRIpaddr, d->arch.vpl011.base_addr);      res = fdt_begin_node(fdt, buf);      if ( res )          return res; @@ -2940,9 +2940,9 @@ static int __init handle_passthrough_prop(struct kernel_info *kinfo,          if ( res )          {              printk(XENLOG_ERR "Unable to permit to dom%d access to" -                   " 0x%"PRIx64" - 0x%"PRIx64"\n", +                   " 0x%"PRIpaddr" - 0x%"PRIpaddr"\n",                     kinfo->d->domain_id, -                   mstart & PAGE_MASK, PAGE_ALIGN(mstart + size) - 1); +                   (paddr_t) (mstart & PAGE_MASK), (paddr_t) (PAGE_ALIGN(mstart + size) - 1));              return res;          } diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index ae5bd8e95f..839623c32e 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -1058,7 +1058,7 @@ static void __init gicv2_dt_init(void)      if ( csize < SZ_8K )      {          printk(XENLOG_WARNING "GICv2: WARNING: " -               "The GICC size is too small: %#"PRIx64" expected %#x\n", +               "The GICC size is too small: %#"PRIpaddr" expected %#x\n",                 csize, SZ_8K);          if ( platform_has_quirk(PLATFORM_QUIRK_GIC_64K_STRIDE) )          { @@ -1289,11 +1289,11 @@ static int __init gicv2_init(void)          gicv2.map_cbase += aliased_offset;          printk(XENLOG_WARNING -               "GICv2: Adjusting CPU interface base to %#"PRIx64"\n", +               "GICv2: Adjusting CPU interface base to %#"PRIpaddr"\n",                 cbase + aliased_offset);      } else if ( csize == SZ_128K )          printk(XENLOG_WARNING -               "GICv2: GICC size=%#"PRIx64" but not aliased\n", +               "GICv2: GICC size=%#"PRIpaddr" but not aliased\n",                 csize);      gicv2.map_hbase = ioremap_nocache(hbase, PAGE_SIZE); diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 3c5b88148c..322ed15e6c 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -1402,7 +1402,7 @@ static void __init gicv3_dt_init(void)      for ( i = 0; i < gicv3.rdist_count; i++ )      { -        uint64_t rdist_base, rdist_size; +        paddr_t rdist_base, rdist_size;          res = dt_device_get_address(node, 1 + i, &rdist_base, &rdist_size);          if ( res ) diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index fdbf68aadc..ddffffe44c 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -158,7 +158,7 @@ extern uint32_t hyp_traps_vector[];  void init_traps(void);  void device_tree_get_reg(const __be32 **cell, u32 address_cells, -                         u32 size_cells, u64 *start, u64 *size); +                         u32 size_cells, paddr_t *start, paddr_t *size);  u32 device_tree_get_u32(const void *fdt, int node,                          const char *prop_name, u32 dflt); diff --git a/xen/arch/arm/include/asm/types.h b/xen/arch/arm/include/asm/types.h index 083acbd151..a7466d65c2 100644 --- a/xen/arch/arm/include/asm/types.h +++ b/xen/arch/arm/include/asm/types.h @@ -37,9 +37,15 @@ typedef signed long long s64;  typedef unsigned long long u64;  typedef u32 vaddr_t;  #define PRIvaddr PRIx32 +#if defined(CONFIG_ARM_PA_32) +typedef u32 paddr_t; +#define PRIpaddr PRIx32 +#define INVALID_PADDR (~0UL) +#else  typedef u64 paddr_t;  #define PRIpaddr 016llx  #define INVALID_PADDR (~0ULL) +#endif  typedef u32 register_t;  #define PRIregister "08x"  #elif defined (CONFIG_ARM_64) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 6c9712ab7b..0c50b196b5 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -747,7 +747,7 @@ static const struct dt_bus *dt_match_bus(const struct dt_device_node *np)  }  static const __be32 *dt_get_address(const struct dt_device_node *dev, -                                    unsigned int index, u64 *size, +                                    unsigned int index, paddr_t *size,                                      unsigned int *flags)  {      const __be32 *prop; @@ -781,7 +781,7 @@ static const __be32 *dt_get_address(const struct dt_device_node *dev,          if ( i == index )          {              if ( size ) -                *size = dt_read_number(prop + na, ns); +                *size = (paddr_t) dt_read_number(prop + na, ns);              if ( flags )                  *flags = bus->get_flags(prop);              return prop; @@ -935,7 +935,7 @@ bail:  /* dt_device_address - Translate device tree address and return it */  int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, -                          u64 *addr, u64 *size) +                          paddr_t *addr, paddr_t *size)  {      const __be32 *addrp;      unsigned int flags; @@ -947,7 +947,7 @@ int dt_device_get_address(const struct dt_device_node *dev, unsigned int index,      if ( !addr )          return -EINVAL; -    *addr = __dt_translate_address(dev, addrp, "ranges"); +    *addr = (paddr_t) __dt_translate_address(dev, addrp, "ranges");      if ( *addr == DT_BAD_ADDR )          return -EINVAL; diff --git a/xen/common/libfdt/fdt_ro.c b/xen/common/libfdt/fdt_ro.c index 17584da257..a1e0e154c5 100644 --- a/xen/common/libfdt/fdt_ro.c +++ b/xen/common/libfdt/fdt_ro.c @@ -172,7 +172,7 @@ static const struct fdt_reserve_entry *fdt_mem_rsv(const void *fdt, int n)     return fdt_mem_rsv_(fdt, n);  } -int fdt_get_mem_rsv(const void *fdt, int n, uint64_t *address, uint64_t *size) +int fdt_get_mem_rsv(const void *fdt, int n, paddr_t *address, paddr_t *size)  {     const struct fdt_reserve_entry *re; diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c index be67242bc0..1f86443136 100644 --- a/xen/drivers/char/pl011.c +++ b/xen/drivers/char/pl011.c @@ -258,7 +258,7 @@ static int __init pl011_dt_uart_init(struct dt_device_node *dev,  {      const char *config = data;      int res; -    u64 addr, size; +    paddr_t addr, size;      if ( strcmp(config, "") )      { diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 0a514821b3..59b9a24099 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -73,8 +73,8 @@  /* Xen: Helpers to get device MMIO and IRQs */  struct resource  { -   u64 addr; -   u64 size; +   paddr_t addr; +   paddr_t size;     unsigned int type;  }; @@ -169,7 +169,7 @@ static void __iomem *devm_ioremap_resource(struct device *dev,     ptr = ioremap_nocache(res->addr, res->size);     if (!ptr) {         dev_err(dev, -           "ioremap failed (addr 0x%"PRIx64" size 0x%"PRIx64")\n", +           "ioremap failed (addr 0x%"PRIpaddr" size 0x%"PRIpaddr")\n",             res->addr, res->size);         return ERR_PTR(-ENOMEM);     } @@ -1179,10 +1179,12 @@ static void arm_smmu_init_context_bank(struct arm_smmu_domain *smmu_domain)     reg = (p2maddr & ((1ULL << 32) - 1));     writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBR0_LO); +#if !CONFIG_ARM_PA_32     reg = (p2maddr >> 32);     if (stage1)         reg |= ARM_SMMU_CB_ASID(cfg) << TTBRn_HI_ASID_SHIFT;     writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBR0_HI); +#endif     /*      * TTBCR diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index 1528ced509..20b4462fdd 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -466,8 +466,8 @@ typedef uint64_t xen_callback_t;  /* Largest amount of actual RAM, not including holes */  #define GUEST_RAM_MAX     (GUEST_RAM0_SIZE + GUEST_RAM1_SIZE)  /* Suitable for e.g. const uint64_t ramfoo[] = GUEST_RAM_BANK_FOOS; */ +#if !CONFIG_ARM_PA_32  #define GUEST_RAM_BANK_BASES   { GUEST_RAM0_BASE, GUEST_RAM1_BASE }  #define GUEST_RAM_BANK_SIZES   { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE } +#else +#define GUEST_RAM_BANK_BASES   { GUEST_RAM0_BASE } +#define GUEST_RAM_BANK_SIZES   { GUEST_RAM0_SIZE } +#endif  /* Current supported guest VCPUs */  #define GUEST_MAX_VCPUS 128 diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index a28937d12a..7f86af54b6 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -572,7 +572,7 @@ const struct dt_device_node *dt_get_parent(const struct dt_device_node *node);   * device-tree node. It returns 0 on success.   */  int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, -                          u64 *addr, u64 *size); +                          paddr_t *addr, paddr_t *size);  /**   * dt_number_of_irq - Get the number of IRQ for a device diff --git a/xen/include/xen/libfdt/libfdt.h b/xen/include/xen/libfdt/libfdt.h index c71689e2be..fabde78edf 100644 --- a/xen/include/xen/libfdt/libfdt.h +++ b/xen/include/xen/libfdt/libfdt.h @@ -444,7 +444,7 @@ int fdt_num_mem_rsv(const void *fdt);   *     -FDT_ERR_BADVERSION,   *     -FDT_ERR_BADSTATE, standard meanings   */ -int fdt_get_mem_rsv(const void *fdt, int n, uint64_t *address, uint64_t *size); +int fdt_get_mem_rsv(const void *fdt, int n, paddr_t *address, paddr_t *size);  /**   * fdt_subnode_offset_namelen - find a subnode based on substring 3. I am happy with any other suggestion. In linux source code (https://elixir.bootlin.com/linux/v6.1-rc1/source/include/linux/types.h#L152), CONFIG_PHYS_ADDR_T_64BIT is used for distinguish 64/32 bit physical address. Kind regards, Ayan From xen-devel-bounces@lists.xenproject.org Tue Nov 29 14:02:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:02:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449389.706071 (Exim 4.92) (envelope-from ) id 1p01CA-0005gw-Lw; Tue, 29 Nov 2022 14:02:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449389.706071; Tue, 29 Nov 2022 14:02:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01CA-0005gp-J5; Tue, 29 Nov 2022 14:02:46 +0000 Received: by outflank-mailman (input) for mailman id 449389; Tue, 29 Nov 2022 14:02:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01C9-0005gj-NR for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:02:45 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062d.outbound.protection.outlook.com [2a01:111:f400:7e1b::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7eeea099-6fee-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 15:02:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7225.eurprd04.prod.outlook.com (2603:10a6:102:83::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.22; Tue, 29 Nov 2022 14:02:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 14:02:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7eeea099-6fee-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oI80ImFgkzBlxGmhYwB21GpfUp3QIDEMHMQbPyUwytxw1IJMea6PnFBAinEOYO3nTCAA6JUXiUxKxz2eC5uE/h25mpJH4Ox8Nw63RTAUEPzPuuwCThYUJtkk4eDGra3gcncho47gJPWHmw+G0bAXBERzSA9eWTFd9TtJoXxCRtWFn8tzH4Vrrtb2SUYklBzGMX44teg2kRyN0YUiy1cAujNvvqiVqyVU2R1t/Z4/o3pmwbgI4JfyXC4FjP+zjAD5KuS35wSjkUomVTUUww1y5E0BYDE1iUwx/l8ejexs5gbCLUvYjFjdrpIWPJywhR5kKPhAsMAiMfgRwSimR/OY8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1JBDnqPUsTvbGHcqnR6za63c3nkQNslXxmMYUdoqv6c=; b=dLfF7PlVTo9XASWMKdOxywfDi5AQ7YiOfaEPSUQfmDFhCs+MImE9mkmylO5Yat/qBq3zVRZkMcY6VgP4eI4Gpgr1aZVWuFVMIEe/DCMryo/zRQy2dfKSF2ayzLuv8+cSFKfNx5wQKD11We0UxEnaixN+oO1pLSYFSof8ftMMHW7v0FA3AnUYWUUmNnwO5Wbe7MA2fjyOhPMDJAntNILZqRvgQP/mZoW6yyL/CU4n8lsoDHJkoDKl/2h0i/OMUUt10u4vbRtR8Xj00p/jQitpAfk2w119rp+MSFW7k8zyZDWg0EebErVBGByqjckwDa1N2QSq0ghHU6xJBFdfUfscDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1JBDnqPUsTvbGHcqnR6za63c3nkQNslXxmMYUdoqv6c=; b=46pXnte26TPdokThZUtAOcfa1MQOtnkRft+UN12LQlKttrCe2UjLULsYsJE5FW5F8VlgWMWB4Oc2i/s2rQj814xI1PX8JGbBDBOrcH/C/BrXq+loM/xv+EE+g+IdMK9KrBUSb0ThfKrv42DLuGnMef1983rY/eXkmJxHnJxOpX9W1tODSJUWQNol83KWw6OMzzg10Vy5p7ZfRWcU5mHEirzcjcssf9gNbPfXbk8Fi5Ew/IE1WcOSIcEiWTIfjAH9WS2OccAIX71apq7YKEsQXT6e5L5XHGsNQ1eA/R5BH+Xp4pkeGoX6G4/i0zyiRsmWZP0yBnkQIVobSB6KhgSZHw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 29 Nov 2022 15:02:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH RFC 07/10] domain: map/unmap GADDR based shared guest areas Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <5a571fd9-b0c2-216e-a444-102397a22ca0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7225:EE_ X-MS-Office365-Filtering-Correlation-Id: c1191dd2-a366-4d42-a969-08dad212620f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QGxoXp+s1LfW6rmtDGsb66sUhj9UbK+gZBGWeVcO2bIFuMBGgFXGcXxVX19yKbvLGHrGAdX/2cGwcu07xMNZi+S0D/1ft6zdDXiIxibb9xJIZr/QUSb2kl4G/2U16Hl+LvdW/r1lxCZN+/DTLbHNj2f+6TIEpg0UJqm0KcN6otriM/g5z3gNHnw+K9wwJVkVEdkIgekYof2L07YX81aM8NgFbZ0H73Ut0Cq8yk+DaiCGsK7+js8dEzgxWLyEPyQDBz/Dg9t/o3sVBfiFmQCrWiRm/tKJHTLlivNuJy6Y6XNPJjcA/UFbGJVU6kBkxwxQ2H5GQlc7GBXMGGgSdq/6pfUvRSwVE+1cvZxbKvEFxyjmikCFUHmMYFr/RuebrbuNLasnv2yN2uMgds0jzBVAlaXLUX0VmjJEVZU770RAM5iymzBep3X/ZSpK/XQua1XRNl9h06ooB4+vAKH4e35UfVpVfff/C8bueseauUV25cm5l0wIvUxKZFY95rZ9ngp3YgrB+ty+AjXIB4rRqjKJfuhb7KMk3VxvnOLAx15UFdAmVjMFsXiJ1P+a7xaz+ZkJQG1tqYdiV2ttFI+WaHoaBmpCCf3Wkp3gtCueQadtwC/elnwlFfNMRGQfKSUjE9WObu6AOCL9M9hEZnCv9rsd7YbG4/qcNokg2cLvmJhv9c0KBmN92n+Uv1Vy0YnM0iG/yY8S+Q7eDoyCUTXEpdw5zxiscgcdezFXdwoIntANEq0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(136003)(39860400002)(376002)(396003)(451199015)(186003)(6506007)(86362001)(54906003)(26005)(41300700001)(53546011)(66556008)(4326008)(66946007)(8936002)(31696002)(6486002)(478600001)(8676002)(2616005)(31686004)(6916009)(316002)(38100700002)(5660300002)(6512007)(2906002)(83380400001)(66476007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUtyNjFQRS9mVE9aT1RKb0syUmlrQm1nRnpBbnZndXRRYXlScmdZaHl6UlFw?= =?utf-8?B?R1RSRTBRS21yMVhaUWxOOE0rbmRMVHpNYlZXZUk3cGpFczZmWjJHQlc2d1Nq?= =?utf-8?B?L3lEellNQXBxeFJ1L3hBUis1ZUpFbnhPRGI4NjBZRmY0RnhPMW55V2xVMTZW?= =?utf-8?B?Szh1d1J0MHdDUlovbTRoYUJNRTMvRmlSQWpYdHZOVW0rcVRPUDNHVmQ1WmNp?= =?utf-8?B?RklXOXJFWW9SNC9tQVdDWUVCZjZtbm04NkQ4OW9BRGF0Z1lHL2ZIQkU0QU11?= =?utf-8?B?cmllTUc4RHhheFpoMENBUldYSjRVczdFaFoxeHV5T0JFR3dOZ0FDZWpDS0tj?= =?utf-8?B?UEs2TGEyWlZ2TC9SNmRSRXFuZnBUc3hLVXZwc2xUWkNIelBuRUt2UUcxai9t?= =?utf-8?B?SDJGd0NJVGdCR0dPT1VZSzJnZ1I1OGhvY29Uc3dmOXN5V21EbDVRS1EzaXh0?= =?utf-8?B?VDBBc1d6cEhRNjAyUmxOajlhUHJ1WXlHWTB4SVJHc0hvRGZMY2d4WEh6bVZE?= =?utf-8?B?c3pIZVh0cEFkKzMrWCszR0NmOG1PUXhRUDk0azBRdSs1QjFhYmZtcUdkT29V?= =?utf-8?B?Q3dmWnN6Rm8rN3d4YkNSYmpycHQ0QzJNdldwOCtwTzA2ZVEvMk9GSVZBSnY0?= =?utf-8?B?cnlESHpuWGx2aGhoYmNhRVBFbnB4ejY1RitlNk9LV25oTTRQcTB4RmRjOE9C?= =?utf-8?B?dTBCdVhNRXVqU0djeGZFOXAvdHFkQmQ1K2VpMlBaZUhQUHhTeStWR3lMRmZK?= =?utf-8?B?Y2xaSVRJb1ZybWJmbDJDYjIrSFlhRmh6aGRSeHBYRzVLblhTeW1ucTNJa09Q?= =?utf-8?B?eWd3bjFiN3FuQWpabm1kQzgrWWkzWUtMcndKUi9NR3kraCtGVzVOZzNnYmEv?= =?utf-8?B?SllNWmQ1dFI4bGdSSzh3UUFOcG45T3dvWjJzcWcwZWtTckE5Wnp1ZDZ2eEJ0?= =?utf-8?B?MThSL1FSTzdlSmN3dm8vMGlGZUZUcjdjTVpoWERicXpJQ0RSRzZjWWd6Vmow?= =?utf-8?B?OEpOUUdvTlZzNCs3MXRqZ2VJQ3dNYTRwSDlCWFV5L3lSRFpwSXoyZ0JQLzM1?= =?utf-8?B?UG9BbHU2aU1UczZZYitYNVZwU2RmOUhKNDY0L3B1NzZ4ZUVISkRIV2hoaG0x?= =?utf-8?B?L2w5VHQzR0xTaHBBVzF1UG5oM1I4OXBVbCsxczdVNGhZb3ZaTmNPdExzRVI0?= =?utf-8?B?Um9Qcm5NYzJYWnR3TE9GcHk1UTZ6bW9jWnpRSmJ6Y0tFS25QalNSQ2l0dzFO?= =?utf-8?B?MDNOcnB6YlkrbEgybnFmcU05dzY5OGVheEs4VmgySE5ibS9penRXaUVTTzAz?= =?utf-8?B?ZGVZSXBGak52a24wc29nUG5xMU5YRGNURHpudmxOeWNnWmZkaDFxbE9qc2Fj?= =?utf-8?B?eEtCUDlSazZvcmlCZ0JrWUpucFJ5TndVUHpZTzV6SkNRT3ZkWi9TeEpMakQv?= =?utf-8?B?SzJCTzZpTXU5NzVENWI5OGUxSDVHZTROM0NhNmJMNCt1NW1WbUIzc1NiWVZ3?= =?utf-8?B?QWhhMjVhUGxlUGRqWlJWZ1kweC9oRk91WTVTZndoK2FhMjNGRFNTc1FCNENT?= =?utf-8?B?Q0sweWJ1dGlJcEorbjkzMGdqYXpaWjZqVTJpME5STVh0cUorYlVlMlR0UVg4?= =?utf-8?B?NVh2OXBNNEZrRVVZTG8xUU01K3BLaE9IMHdZT0tPZU1qZmcwc284aFlqbmVh?= =?utf-8?B?Y2NJamVPOFBtVGt0UW9icGJXWHBOOGw5QVdqOWRaT3QwTk5MSCtqWTBJWVhI?= =?utf-8?B?bkpRTzA3NitZSEE3SEtFelptU1FCdEJYNVlPcGRBdnQxeWxjQzVlQUFRTlVl?= =?utf-8?B?eVh4WXR0SmhEd3JpemNKRGM4VW5vQUE0bE9seG9mdEVtMGZSa29mSlZMOUsz?= =?utf-8?B?UWRuRWp4SE9PZEdGKytNaW9VSHdJdDliRU56Skh5Z2YyUVV3VDh5V2JZYjE5?= =?utf-8?B?UkQ0UUM0WXdiTldEbXpJdDBudE9lektYMVF6R29GbTg4VUJVSHJiOG8vcTd4?= =?utf-8?B?T1JOVHFXY2w0SDVyN0xVM2VROHlnUGxVVG9BYXlJb245aTl1eVNocE9TU250?= =?utf-8?B?dC81d0grT1lGQk1mWnk3b1BwWWVCcjV4Y2lnWURDUmlYY2ZhRitUclNWN1Ew?= =?utf-8?Q?Y4zh5YOjdilxYN6t0znDoUc1I?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1191dd2-a366-4d42-a969-08dad212620f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 14:02:42.4815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tu1zYhyScgTs4hGeKKEiNZ88rcZ7yyyUE0ZLYizoSX38nj41wlrrANPvipqXsx9Re92T6B+jfV5YXTNZ7IHjRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7225 On 29.11.2022 09:40, Julien Grall wrote: > On 28/11/2022 10:01, Jan Beulich wrote: >> On 24.11.2022 22:29, Julien Grall wrote: >>> On 19/10/2022 09:43, Jan Beulich wrote: >>>> --- a/xen/common/domain.c >>>> +++ b/xen/common/domain.c >>>> @@ -1563,7 +1563,82 @@ int map_guest_area(struct vcpu *v, paddr >>>> struct guest_area *area, >>>> void (*populate)(void *dst, struct vcpu *v)) >>>> { >>>> - return -EOPNOTSUPP; >>>> + struct domain *currd = v->domain; >>>> + void *map = NULL; >>>> + struct page_info *pg = NULL; >>>> + int rc = 0; >>>> + >>>> + if ( gaddr ) >>> >>> 0 is technically a valid (guest) physical address on Arm. >> >> I guess it is everywhere; it certainly also is on x86. While perhaps a >> little unfortunate in ordering, the public header changes coming only >> in the following patches was the best way I could think of to split >> this work into reasonable size pieces. There the special meaning of 0 >> is clearly documented. And I don't really see it as a meaningful >> limitation to not allow guests to register such areas at address zero. > I would expect an OS to allocate the region using the generic physical > allocator. This allocator may decide that '0' is a valid address and > return it. > > So I think your approach could potentially complicate the OS > implementation. I think it would be better to use an all Fs value as > this cannot be valid for this hypercall (we require at least 4-byte > alignment). Valid point, yet my avoiding of an all-Fs value was specifically with compat callers in mind - the values would be different for these and native ones, which would make the check more clumsy (otherwise it could simply be "if ( ~gaddr )"). >>>> @@ -1573,6 +1648,22 @@ int map_guest_area(struct vcpu *v, paddr >>>> */ >>>> void unmap_guest_area(struct vcpu *v, struct guest_area *area) >>>> { >>>> + struct domain *d = v->domain; >>>> + void *map; >>>> + struct page_info *pg; >>> >>> AFAIU, the assumption is the vCPU should be paused here. >> >> Yes, as the comment ahead of the function (introduced by an earlier >> patch) says. > > Ah, I missed that. Thanks! > >> >>> Should we add an ASSERT()? >> >> I was going from unmap_vcpu_info(), which had the same requirement, >> while also only recording it by way of a comment. I certainly could >> add an ASSERT(), but besides this being questionable as to the rules >> set forth in ./CODING_STYLE I also view assertions of "paused" state >> as being of limited use - the entity in question may become unpaused >> on the clock cycle after the check was done. > > That's correct. However, that race you mention is unlikely to happen > *every* time. So there are a very high chance the ASSERT() will hit if > miscalled. > >> (But yes, such are no >> different from e.g. the fair number of spin_is_locked() checks we >> have scattered around, which don't really provide guarantees either.) > And that's fine to not provide the full guarantee. You are still > probably going to catch 95% (if not more) of the callers that forgot to > call it with the spin lock held. > > At least for me, those ASSERTs() were super helpful during development > in more than a few cases. Okay, I'll add one then, but in the earlier patch, matching the comment that's introduced there. Jan From xen-devel-bounces@lists.xenproject.org Tue Nov 29 14:32:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:32:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449396.706082 (Exim 4.92) (envelope-from ) id 1p01er-0000uN-0n; Tue, 29 Nov 2022 14:32:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449396.706082; Tue, 29 Nov 2022 14:32:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01eq-0000uG-U2; Tue, 29 Nov 2022 14:32:24 +0000 Received: by outflank-mailman (input) for mailman id 449396; Tue, 29 Nov 2022 14:32:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01ep-0000uA-Er for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:32:23 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a0efd40a-6ff2-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 15:32:21 +0100 (CET) Received: from mail-bn8nam04lp2042.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2022 09:32:16 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MW4PR03MB6634.namprd03.prod.outlook.com (2603:10b6:303:129::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 14:32:14 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%9]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 14:32:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0efd40a-6ff2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669732341; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=Wh+vv6jzx/wiXLzxnMC6K8zlJzUi+S1gkbHF618lS50=; b=dZNk52kh3fY+zsvTVGh1UaF0ABflJx0BZJgPqYkbhkM0SWWKspvvnxfh WhHMMuS9wrOKPp0ZdB7RmriqvwHn5kqBtPyPE93NR/7cHHDh6nTYsi6x5 CqVGB2EE0mN1fcsKuxpE8l64I0Sr14MBJTTvWZrU0o7w2nRuJw7XdviRS E=; X-IronPort-RemoteIP: 104.47.74.42 X-IronPort-MID: 85783463 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:GhxPraxsT9CLP1nFSPZ6t+dTxirEfRIJ4+MujC+fZmUNrF6WrkUPz DNOWzrUPqnbYGH8KYxwb4S+8EIAsJaEzddrG1c5rCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnP6ET5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KXxy9 fIqdwpSVRe41rKEm6DjFrVFvu12eaEHPKtH0p1h5RfwKK56BLrlE+DN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDSVkFYZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r827Cfxn+lA+r+EpWyzs5xpWTCyVBQKxcRXGumgqmLiEihDoc3x 0s8v3BGQbIJ3EiqSMTtGh61uniJujYCVNdKVe438geAzuzT+QnxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8oim/NisVBWsDYzIUQwwY5dXqvIA0iFTIVNkLOKy0lNzuHTj60 hiJoTI4irFVitQEv4258krAmCmEvYXSQ0g+4QC/dnm+8gpzaYqhZoqpwVvW9/BNKMCeVFbpl HIDgcmFqucVEYuKijeOUc0KBrii4/vDOzrZ6XZtFZQ88zWm+1a4YJtdpjp5IS9BMcECYzblJ lDSvQB544VaN3+nK6RwZuqZD8Us0Lj4Dd+gWv3KRt5PeYRqMgiV+ChkfgiXxW+FraQ3uaQ2O JPee8D8C38fUfhj1GDuG71b1qI3zCcjw2+VXYr80xmszbuZYjiSVKsBN1yNKOs+6ctovTnoz jqWDOPSoz03bQE0SnK/HVI7RbzSEUUGOA== IronPort-HdrOrdr: A9a23:/ouQ5q5hVuUvZRmErwPXwbyCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HjBEDmewKlyXcV2/hpAV7GZmXbUQSTXeVfBOfZowEIeBeOi9K1q5 0QFJSWYeeYZTYasS+T2njDLz9K+qjjzEnHv5a88587JjsaEJ2Ioj0JfjqzIwlTfk1rFJA5HJ 2T6o5uoCehQ20eaoCWF2QIRO/KovzMjdbDbQQdDxAqxQGShXfwgYSKWySw71M7aXdi0L0i+W /Kn0jQ4biiieiyzlvxxnLe9JNfnfrm059mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoWoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIL52X5wVGVrHP/qYihLQhKffZptMZ8SF/0+kAgtNZz3O Zi2H+YjYNeCVflkD7m79bFehl2ng6foGYkk8QUk3tDOLFuH4N5nMg6xgd4AZ0AFCX15MQOF/ RvNtjV4LJsfVaTfxnizxpS6e3pek52MgaNQ0AEtMDQ+SNRhmpFw0wRw9Fatmsc9bomIqM0q9 jsA+BNrvVjX8UWZaVyCKMqWs2sEFHARhrKLSa7PUnnLqcaIHjAwqSHrYnd3NvaNqDg8aFC2a goCDhjxC4PkgPVeIezNaRwg1/wqD7XZ0Wv9ilcj6IJyoEUCoCbcxFrc2pe7fdIk89vfvEzZM zDR66+e8WTS1cGObw5rTEWCKMiXEU2YYkyhusRfW6oj4biFrDK39arAco7YoCdWgoZZg== X-IronPort-AV: E=Sophos;i="5.96,203,1665460800"; d="scan'208";a="85783463" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QZKBCbiBTnCEogzgAqYo907pJGWx6+HgXe+ZP7tB8rvm5fEWqmrPxQ48tyOlrn1RZTvP+tyAaje8oLaEfX2Wi6fK4Zj412ZhjPoXuVxHyPj+L64dsqihx3PH0nBprxf6x59TBk8Lg00ttok1ip/65nJS4mirSziuaNGFxtITKAyRWuzsHUA0lXagjVAZW1vKW58dPeLEyHz55tp2i7oRiaqkWyF35cTIpgUBNsQ1tsdTvcxEsmlvY7EfFIDhkYxQtZN0Y9YLONm6wCs3ZaLA44GufPRdev/x2Ukz9KR8/ITppTZXqqdjXgrRsjDK/7oeeKiBMr9YFcs3FycsGhla/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OMIcbB390IYiCQeoKixgqUua7BwWYTILvEu0+nRR/V0=; b=AiOOum1J87fpNRaAuexpsUv+SF38lNHLAToHOT/tM1BnoZHonCHWgAjTNqS27upXv9R1k0K+tCgVf8OsXQlyuYXgZssmtqluzZ+P9A+k4RuotELtAy+TBomMEYBM6PVOursuQc2gjMwu5IEMeQDtncUTJpYwFOogdNCRLX26/60UeVYzcZ0muQutmcV7L2TmVwtHebx6CKARAxCU+lXW4E6/cJXLD56pMnrDuJytYSOkFliL8KxL4i03ROTzTkKrmnHYxqw5dSAqqOfv/qetUvYYfMN56T3iTjMNDN89PVVUX6hYwMxxV5jjM1hp9fIitzVWaqf9ZujFwgqGvGnHuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OMIcbB390IYiCQeoKixgqUua7BwWYTILvEu0+nRR/V0=; b=L2LTG9CLAMOc9u5GZr1jozAbAQ9F/42ins68MuD69tW/SfmL1GmA7AdqbIZI3fbbvJrsR93YjKs+Ps39vseSY8byPn2Jaoj+Yc9iOkvcowFqlcYJtByVBKI52501NTT4K3D3ic+eiUmbz0S8vnkAu3jd6jUp69wZMCHfRESp+tU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, Roger Pau Monne , Greg Kroah-Hartman , Jiri Slaby , Juergen Gross , Stefano Stabellini , Boris Ostrovsky , Jan Beulich , Konrad Rzeszutek Wilk , linuxppc-dev@lists.ozlabs.org Subject: [PATCH] hvc/xen: lock console list traversal Date: Tue, 29 Nov 2022 15:31:37 +0100 Message-Id: <20221129143145.4234-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0023.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::13) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6634:EE_ X-MS-Office365-Filtering-Correlation-Id: cefca828-24d2-42e2-bdcb-08dad21681d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: okwqNcAUnblGECZFShxXgbjuAeRi1jSmkX5kRFBmktWoeBNiTrmqSx0sj4Nipq1ZDHWX2cqEZ8YR/L8/wq37xb3ZBrlaPN/hg/a04BEwHByGY0aU/YkZo+/iS9x5VAAOrLS2eDVoWv+Fb7MBv6ViTfeqeqLed7sNcI3UDRTN7JyHffrA05lSOUa9S2iCEllwAkLmn0zWZfcxyiTC3QExxwjAJvzc4eUf/WPq2S0lhIuCimI+epKbJFLHg8xr46YrLJ8nh9vg2c0kAJWwKmNPz1HHRIolOct5uIbSBAuaDYtEFqYmwX9YxMd+6sJSgd9KHBx9pfQLGNosEtC6GQxkaJl95EqES5e0z8J/QsAKptwV3tbP3s9gMV7PUeputObC2/884RWzfIyyuW3z9gHxt/UVJLaob9k7zxUBn/zuvFSsJbVItTCNHGhzkkbe92o1z7mtG5zBML6TFWl4KsWviK7eUXzzsvNdghyCAG0zB7MAbkyTynGPzS7MXUL4z6ToNpb1hUwDDllcdt8TG4vS8cTuzkE9bS6s2nLP1z8SdW0wJVYTV02yvFaGpyBibpCMQKFThe4Hgm2LCYtB0qUuyVfjlJoccE41sv6veiSgEez7qg5JiqP/sMFlm/F1kPU9YzDZQW8IX+nJZOKZmWIkIA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(39860400002)(366004)(136003)(396003)(451199015)(66556008)(2906002)(82960400001)(41300700001)(7416002)(86362001)(83380400001)(8676002)(54906003)(2616005)(1076003)(6486002)(316002)(66946007)(6916009)(36756003)(478600001)(38100700002)(66476007)(4326008)(8936002)(5660300002)(6666004)(6506007)(186003)(26005)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czRWbHE5clAraDRIb0tIOUJ3Z0FpMEZNSHd3WTQyeTBEZzNDbk04Z3Z2V3pW?= =?utf-8?B?dVRTRkNaaG1Mdm9yUWFYUys2LzlFR3NhakJ4NTU1clBNbngrRkFIR0MyakJD?= =?utf-8?B?Nm5BemNkeDViUXZ4b1FtbDZOa2swZFUxTUtBYTVyM2VJUFRXcmN6UGkyaWg5?= =?utf-8?B?TXZHRENjT2N0VncrODhOZzdDQW85eVg5OHBWZ28za3RSeTk5NlJTNjdKU0hE?= =?utf-8?B?WTF5dEo2bUJKSEJQZ0pxcTZ5T2x5OFZSb1NuRDc0VkliYUhNendEUllSSjZp?= =?utf-8?B?eVExT0MwcWRKajFlMzVBcUI1TjBxbFpCNlZIMXdpSkhZZ3JxZzdmYjdFa3Mv?= =?utf-8?B?OHYxTm02NWVOM2ZieUxWSHBEenBzZ2ZhNzZzQitTaDlXKzJrV21iU1Q4dTUw?= =?utf-8?B?KzRHRktQMUd6bUQzZHU0RXY5WmUvY0JKempOUi83SjFaZFpVMHAxLzFPdFNF?= =?utf-8?B?bnFoaCtVSElhWGZGUGUzbGZXTXF4QVFFL3A1MVpsYWFNTkpGOFRuUGtVRyt3?= =?utf-8?B?MkF2aWU2a3FiMWJ1UE14R0tPMUFuQ0ZvREk3SHp1NjJBUG1IUlpIY2hkczdo?= =?utf-8?B?NmZocXZnUHZpWGZFYmhTeW1LTDEyTitBSnc0enlwVDNtRE5GYmcrRmhMa3NH?= =?utf-8?B?SytjRERKMmdNai90cHhuaUpkdUpKay8wbERWaXYzUHBXNjE3QXIxK1hpZ3Qv?= =?utf-8?B?YVRWUHJOdncxQVVFQzUrUHliQ0V1dFNmZHRRMmY5OHcrZmFVK3BmMUlmZ2pT?= =?utf-8?B?UU52MkZFR2JST1UzMWI3TkJlb3ZVQVRGcFhQYnNUbHNHNEFaaXlJSGVqKzRK?= =?utf-8?B?SmJYRVZIM0pZaUFoQ280ZW16Uk1kdkRsZDIwaGVIWVdBWlhCZ3NEbnQ4SjVZ?= =?utf-8?B?WVBmbHRFaERwVWtzM0hMN05OSk00WHMwaGdaaGZGWHYxa1g2SFZobHppYUk4?= =?utf-8?B?U1FGMFJSTjhLdzlnT0c1ejNJcEJKWXZBeTJCTUNhTUVDQUhHTUtuQzVnaHll?= =?utf-8?B?YXYycXlCNDV6Z0pDSWZFOWVPd3A1dlU1dTdqN25QYXNueUFBZjI2T0NQbU93?= =?utf-8?B?NGluOGkraW1WaEFXRzRSeHJEaGJ6OEZ2S0RDOElJemtYcW94Zm1wZUc3K0FM?= =?utf-8?B?dFBGS3dkVWFYcTZWRDZ5V1hLaVozeFpSeVBPWVRnc0FjeUVnMGsrU2FKYjZs?= =?utf-8?B?cWkwV2dEL21ra1JvQWVwWnIxV2xiWDlnQm5UakZZaTkyRndwSUlvcFZ6RWUw?= =?utf-8?B?TzdWbk5WV3IydHBhVjZITWF0SVh1T3JDbFhGWm03UFRMbCs2c05tSzNNeW4w?= =?utf-8?B?QVNrNzMydXFHNFg0ZUhnSElOdk1TUEwyaTdtQUVCeTZXaS9FbXJ4RXJleDhW?= =?utf-8?B?WDBjdG14aXh1VEJKdCtKMlg0bHJZOHgybGJZdmgzVkcvek01RmhUdkhrMTBs?= =?utf-8?B?RGwyZk80VFlZa0Y4cXVCekQzU0ZEcDQ2NTkreExDb1pqK1dnUk1JaDQwS0pQ?= =?utf-8?B?Y1RMcUZnNGpOMVd3WDRlQjVld3BFamQvd0Z2MnRGRy9HeFByMmMyVkgySkJa?= =?utf-8?B?TzhvU0NMY1ZHenVqVHRzeWNFVE15V0tBYjB3SUNka1FObllzNWkvRG11dzMv?= =?utf-8?B?SFBSQXZDQ09TUkRQVDRzeGhqb3lzWjloTHl6UG0wNlFSdmZZVTRXWkw3UE4r?= =?utf-8?B?VFJqOEJJRnVGOGJxd2RId1pvSjdhSjFHVVRNSjNKenZuMWw0MHRkZ1VNOFNz?= =?utf-8?B?d29JYjNuMUFGS2pUNlFNbHErVW1odlFhN2FlVmFRMFIzTW1DVHZFaThpQ09D?= =?utf-8?B?M1JWZ0lrR3ZPb0c0Q2FFNXFyK2hFWlcyRmR1R0Nhbmk0cC9jT2hQOUcyU0h1?= =?utf-8?B?L3BNWnFEc2prRWtZanZJcUhYQXRiVTQ4TFlueTRFMFhHTGJNUm5Ec1pJVUEz?= =?utf-8?B?N2VCK2tYK1J3b1N3SWF2ZmIrOXM4Wmw0bFppeFRQV3ZlZnpSblA0R0dTMC9R?= =?utf-8?B?UEpGVXd4bnFzeGI0OW5FUFJUNVB0WEM1YzJJeUthNzVDMkdNQklUWm1jMzJD?= =?utf-8?B?OGhoWXFsSmYrZk5UUURuSXNZQzNsa3ZyRExPNFlyRFFzeEtVVHdUNU9GdVRM?= =?utf-8?Q?OvSO33DP9Mn3Povhogwv59B7r?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?cXd0bTR3dFhTV2ZFdEhiRDBZcUx6alJzVnBMMmdtNmFyRWJEZ1pIWWJEK1N1?= =?utf-8?B?RWxVeDE3dTB4aTBEOW5tZXJPeHdjODIwM1pMOFkwVFhkZVl4Mi9nVmJodFVs?= =?utf-8?B?bXhjY28zTWV0QjZ1SXZTZUhic0sySWFRclhKZDR2aG81Z3pqeTlJMEM5MVhF?= =?utf-8?B?VExhTWhWbENQU2JLdzF5ZGxNazJRU0NMYzBKTUJzalhLWnV5MjlCVWN4a0FL?= =?utf-8?B?Ymh3S2FZelZNekRJVmtTSDFJb1JMRFNJM0c1MmMwdzZIUGVQZkJxQXBUcHk4?= =?utf-8?B?SG00RjhneWREUUdOMXZQQmJwVFFtK3pLR2UxTk16RkhVazRseVNxUGtKQmxR?= =?utf-8?B?RmdERENvOWtXcnJXajNDcm9TSy9SRkQ5ZVVtYlhQQ3RjV2dhSkxRa3NUVHhw?= =?utf-8?B?VEtYSmFmVFhualMrd2Rva09hWkNVYVRsODc4bVZrUGo5YVdXUkRQa1lUZ2V1?= =?utf-8?B?WHZkR3VJUGVydmE1SnF2OTFJSjZyRGtyaUpjYWxNa0VPQ0tzSG1IeXppU2lT?= =?utf-8?B?SW5EVUtXcFNuZW1kTUZXOFl0SnN1dWQzUUtvakdxb3hnZ3hZRjNNdW5UVU12?= =?utf-8?B?T3pYcGVIUE9tdWpDV1pVNVRTTFFHcEFyMCs1MjBtU1pnZGV0WHM2RHJUUUdp?= =?utf-8?B?Y3BaWmN3NWEzUVNkU0hwQ2Vmbi9Vc1UxZEZxSDhrZGlFajZMbUUra1NOVlpj?= =?utf-8?B?OE5ad1dFSUhKZUMvUVRicTVzUUR5aDJqbGI5SDAzRUo5Q1BaczI4ZDVWd1Fv?= =?utf-8?B?ZVlZcEJ5MW1VQ2xDQzU3TGlZK1QrcU9jdHNCMG9OKzFOV1JUamVVcXN4UkR3?= =?utf-8?B?QkxPYkNSNW1pUElmTHZVSWFMVmIxQmdOdWoxbHM1NFJva1B6SDVkMGhLMnZw?= =?utf-8?B?RjFkQnV6TzNXZTFzRmcrcEltejFXVlAyaGZwTkdDVFM1RENOeXdIZnltT0sz?= =?utf-8?B?ZC9ENkNQNEVmQW5QblJQOUpIQ09EemhLWitKZGR1SzZjVGdHb01sSXA4RlRT?= =?utf-8?B?ZzEwWjFCTzNORS81U1FxQVppekYycFNXNmhVWDlpVGVyVi9aVkxrQzR4LzVl?= =?utf-8?B?RFBnV25yZURSMGY4WlhLREVudkNrNy9Gak9NSjhHd2dCaEFYT0tjcG0rMmcx?= =?utf-8?B?NDRmQTdQN2xXb0owaDVDbzJnNGYxMDI3N0Q5VW5RRHhselFSc1pWd3BaZnpD?= =?utf-8?B?Y2xhZVFEVkNjRDIvMW9PSXZtaW5jYkl1OG1OK1VNTXFOcFNVN2pPVHpvN2py?= =?utf-8?B?ZUErTFFNTjlSZWJ0eWFqUDk2c1E5RHlHNkh0R0daNklwV2ZCYlJBNlRrcHFR?= =?utf-8?B?ZmVQekQyZHBKUWdlZEY2OU05NlozQTBqYnN0MXlXanRsazcwMTNST0kwWGln?= =?utf-8?B?MTFKYTRxd0lIUkhNU2pPOGJoNktoaEllUjl4aCtJYTF2Y1dObmFMR1dIaXBp?= =?utf-8?B?bFRkTW1GRitUcjNwa0FxTjgyWnRZcjZ6V2lVSmZRPT0=?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: cefca828-24d2-42e2-bdcb-08dad21681d1 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 14:32:13.8739 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZSuaPifVgTAUQTAwofZVKMDdVm1w0La5520lMfXK+398SYBh2VpCH8TaKd2RSJGG/atcnG2hTl5B9TWVWRcZ4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6634 The currently lockless access to the xen console list in vtermno_to_xencons() is incorrect, as additions and removals from the list can happen anytime, and as such the traversal of the list to get the private console data for a given termno needs to happen with the lock held. Note users that modify the list already do so with the lock taken. While there switch from using list_for_each_entry_safe to list_for_each_entry: the current entry cursor won't be removed as part of the code in the loop body, so using the _safe variant is pointless. Fixes: 02e19f9c7cac ('hvc_xen: implement multiconsole support') Signed-off-by: Roger Pau Monné --- drivers/tty/hvc/hvc_xen.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c index d65741983837..117dc48f980e 100644 --- a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c @@ -53,17 +53,22 @@ static DEFINE_SPINLOCK(xencons_lock); static struct xencons_info *vtermno_to_xencons(int vtermno) { - struct xencons_info *entry, *n, *ret = NULL; + struct xencons_info *entry, *ret = NULL; + unsigned long flags; - if (list_empty(&xenconsoles)) - return NULL; + spin_lock_irqsave(&xencons_lock, flags); + if (list_empty(&xenconsoles)) { + spin_unlock_irqrestore(&xencons_lock, flags); + return NULL; + } - list_for_each_entry_safe(entry, n, &xenconsoles, list) { + list_for_each_entry(entry, &xenconsoles, list) { if (entry->vtermno == vtermno) { ret = entry; break; } } + spin_unlock_irqrestore(&xencons_lock, flags); return ret; } -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Tue Nov 29 14:33:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:33:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449399.706093 (Exim 4.92) (envelope-from ) id 1p01fa-0001M8-C8; Tue, 29 Nov 2022 14:33:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449399.706093; Tue, 29 Nov 2022 14:33:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01fa-0001M1-9B; Tue, 29 Nov 2022 14:33:10 +0000 Received: by outflank-mailman (input) for mailman id 449399; Tue, 29 Nov 2022 14:33:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01fZ-0001I8-6V for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:33:09 +0000 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [2607:f8b0:4864:20::229]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bd8c5f8d-6ff2-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 15:33:07 +0100 (CET) Received: by mail-oi1-x229.google.com with SMTP id c129so15402939oia.0 for ; Tue, 29 Nov 2022 06:33:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd8c5f8d-6ff2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=AlmTEqK3obGypOIeoBM6UEH5n1+C5l9b9H7iWEpLH6A=; b=T/LZqpzYOLPC+SZBUJ97PsVPVerwBk1U08wSBBHEf59T/BeIJk7uDC6xo9oqgB+kk8 jKRa0UFcCdD0RXnXzE+hKzXSTggvAkErCA/ygSqBkdWPTBzdMA7lMTUI0ahU9ywh7fmv EMxzwIpJ4uMOzUXjIE7u+QeSNQBjIfVEYDMNYL796FCjAjgIxCNz6ejxPALDvqwK6hCZ vizWC3c+uMBTdBXWX1YdDSxogjWCFcJXqXTr1JkV7IY1Jp9PaOh/1ClELRuwDaUJvF7C Tq/j64LLphVJBbhZwuvpOQl8VNrDWHqFCAV0rIlLaai7wzmvgPYfjrPsMOjlasP2KBb7 SPtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AlmTEqK3obGypOIeoBM6UEH5n1+C5l9b9H7iWEpLH6A=; b=oYfh0xUH+tgX0mCUeZRTBnXT8OautSYjcKwIlXXnPMSWyfDXajMl2j0KNZUlXDqLBS vR//ldsFG9E51AMez6FFWvXbKTo4twWHttCPRZyGhPUArSW0/kXo5PDwK2DoXFKKSepY xxkBWOjDgEE1XXe6m8dXrxHDpkxj8w4UJCR1I9rifeRjGKxWdueJqc10bcmvsPObLHtE X2UdfL/UpNRwL/lG8KdT4hPhI1STWh4CIqZfXYOrbQUPIEVge4hQ3qAfiY1KZYejgs0X BdtOYzQWIQnQJsjVOJvlNLWfoczWlib5W0tD0pP4n5fDqsQcX6xlisIlxQUZGTQ/I1qw cVfQ== X-Gm-Message-State: ANoB5plcnvS7kyIY0c5t9ythBNKpt6ZoKjOKTz8PgI21kfqrKKBZJGAy 1+8Rok0eBdfH6w0SOa6wDNyQG7jPGpxEHCaanUk= X-Google-Smtp-Source: AA0mqf7wcKy4cktH/5nqgVCvLUDw6AoK1wuY7UTYnVx4X7TPkCjyyLY89WuLCnrPeXqUh/OBJXIaTNio8vMumqL4bVw= X-Received: by 2002:aca:d17:0:b0:35b:c9e7:b124 with SMTP id 23-20020aca0d17000000b0035bc9e7b124mr730939oin.46.1669732386601; Tue, 29 Nov 2022 06:33:06 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alex Deucher Date: Tue, 29 Nov 2022 09:32:54 -0500 Message-ID: Subject: Re: AMD GPU problems under Xen To: Demi Marie Obenour Cc: christian.koenig@amd.com, Xen developer discussion , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: text/plain; charset="UTF-8" On Mon, Nov 28, 2022 at 8:59 PM Demi Marie Obenour wrote: > > On Mon, Nov 28, 2022 at 11:18:00AM -0500, Alex Deucher wrote: > > On Mon, Nov 28, 2022 at 2:18 AM Demi Marie Obenour > > wrote: > > > > > > Dear Christian: > > > > > > What is the status of the AMDGPU work for Xen dom0? That was mentioned in > > > https://lore.kernel.org/dri-devel/b2dec9b3-03a7-e7ac-306e-1da024af8982@amd.com/ > > > and there have been bug reports to Qubes OS about problems with AMDGPU > > > under Xen (such as https://github.com/QubesOS/qubes-issues/issues/7648). > > > > I would say it's a work in progress. It depends what GPU you have > > and what type of xen setup you are using (PV vs PVH, etc.). > > The current situation is: > > - dom0 is PV. > - VMs with assigned PCI devices are HVM and use a Linux-based stubdomain > QEMU does not run in dom0. > - Everything else is PVH. > > In the future, I believe the goal is to move away from PV and HVM in > favor of PVH, though HVM support will remain for compatibility with > guests (such as Windows) that need emulated devices. > > > In general, your best bet currently is dGPU add in boards because they > > are largely self contained. > > The main problem is that for the trusted GUI to work, there needs to > be at least one GPU attached to a trusted VM, such as the host or a > dedicated GUI VM. That VM will typically not be running graphics- > intensive workloads, so the compute power of a dGPU is largely wasted. > SR-IOV support would help with that, but the only GPU vendor with open > source SR-IOV support is Intel and it is still not upstream. I am also > not certain if the support extends to Arc dGPUs. Can you elaborate on this? Why wouldn't you just want to pass-through a dGPU to a domU to use directly in the guest? Are you sure? I didn't think intel's GVT solution was actually SR-IOV. I think GVT is just a paravirtualized solution. That aside, we are working on enabling virtio gpu with our GPUs on xen in addition to domU passthrough. > > > APUs and platforms with integrated dGPUs > > are a bit more complicated as they tend to have more platform > > dependencies like ACPI tables and methods in order for the driver to > > be able to initialize the hardware properly. > > Is Xen dom0/domU support for such GPUs being worked on? Is there an > estimate as to when the needed support will be available upstream? This > is mostly directed at Christian and other people who work for hardware > vendors. Yes, there are some minor fixes in the driver required which we'll be sending out soon and we had to add some ACPI tables to the whitelist in xen, but unfortunately the ACPI tables are AMD platform specific so there has been pushback from the xen maintainers on accepting them because they are not an official part of the ACPI spec. Alex > > > Additionally, GPUs map a > > lot of system memory so bounce buffers aren't really viable. You'll > > really need IOMMU, > > Qubes OS already needs an IOMMU so that is not a concern. > -- > Sincerely, > Demi Marie Obenour (she/her/hers) > Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Tue Nov 29 14:33:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:33:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449406.706103 (Exim 4.92) (envelope-from ) id 1p01gM-0001zW-P2; Tue, 29 Nov 2022 14:33:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449406.706103; Tue, 29 Nov 2022 14:33:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01gM-0001zP-M0; Tue, 29 Nov 2022 14:33:58 +0000 Received: by outflank-mailman (input) for mailman id 449406; Tue, 29 Nov 2022 14:33:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01gL-0001I8-EX for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:33:57 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20620.outbound.protection.outlook.com [2a01:111:f400:7eab::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d92a82f8-6ff2-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 15:33:55 +0100 (CET) Received: from BN1PR12CA0030.namprd12.prod.outlook.com (2603:10b6:408:e1::35) by CY5PR12MB6480.namprd12.prod.outlook.com (2603:10b6:930:33::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 14:33:50 +0000 Received: from BN8NAM11FT028.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e1:cafe::58) by BN1PR12CA0030.outlook.office365.com (2603:10b6:408:e1::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Tue, 29 Nov 2022 14:33:49 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT028.mail.protection.outlook.com (10.13.176.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.17 via Frontend Transport; Tue, 29 Nov 2022 14:33:49 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 29 Nov 2022 08:33:49 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 29 Nov 2022 08:33:48 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 29 Nov 2022 08:33:46 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d92a82f8-6ff2-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l6L3omzARJElqOtz0m8eADgRyYIzy9FMwJUfBD7CawkNql6brSeNAVVP0ZSoLS+LtFs10qEGwiQDk2tcSvMF0cCQcrmDPOEgzHGSPbq44XLyGZICSTJTnW9nd0ShebhCuYblMJTTkg22fM6xFYl3rsv1gHTErdy9eGPgifFVAESDfPQAE6LgBb6uvYGGilu60s8+QvrziNf6OsTfkm37wfGg+1sYhggZn6ar6jpqZ35Illk5UEaKX/uk2NfMiIrBBwNl0IYIiuKaGir3soyBA+/n/ENRcDiieUl7AVfNLamhR6jFZVDqwwj6/aDmZc/2zDXY7eWwdvU7YY3UvB38XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IKD7/9QKUlN+Phqz34D8b8jThzHwXtg7mM5JR5dKw6U=; b=Z58ZvfYEE1fEI5WN9V6dNaP+y3NZCbZF3fEDa0NKiSbZ0lIdhseeUoDTwuZ+v07xUD2L8M5kuVmBFuAiKKgaZr6EZ4fZRug51s75jM+Hbkx+ybBAZ4Ci8NztRzJ2WPqkT5egAxW+dhklT9S2KdSoVv55EPZlqbO5rwBwteFw3hb9L97YZ9hreeNXTFZtm1DhZdBo9ZjNKaU9rRi/cNfD17IVz0fWSH2K+S8bGaPECwNZig0X3t2c9dhgrpTvo7rKx5CDnMgqsPhGTdWHGhDCervmzTBaMA5NOkUN56lS8XLheB5xR7FpGD7Uvpeu35XE81WM0WVW0hWN6GZw+YX3tQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IKD7/9QKUlN+Phqz34D8b8jThzHwXtg7mM5JR5dKw6U=; b=r1Pfbra0hl1gmjKot176VP2P/FsZozuFGbD3GXlT6nJysDOLlQx+irScDyUVkdhdNeTTkYu2wgPUBoZkUHjV70092aC1Q36kJMAeZyBQaHcyFdy+5KfC68HWOHB7uD4cdciiGxW7bpVhVsyGmPsV6X2AZz/7ezcu2Wh0jdaj9Ko= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <0ccfe5e6-960d-2f60-f782-e321c1ea7786@amd.com> Date: Tue, 29 Nov 2022 15:33:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN v4 07/11] xen/Arm: GICv3: Define ICH_LR_EL2 on AArch32 To: Ayan Kumar Halder , CC: , , , , , , References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> <20221128155649.31386-8-ayan.kumar.halder@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: <20221128155649.31386-8-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT028:EE_|CY5PR12MB6480:EE_ X-MS-Office365-Filtering-Correlation-Id: be81b9c5-947e-4f08-36fa-08dad216baf1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kp9+Zte7jrjF5o102XYZS/b3781BMnxha8dQmnFVPhZ0Va876LnSLs8SpJAdmkWBC2PwIDkHF87pLjwYPhdD0U6FGGGdmya9itFTnqg/n9Vqlm9XV/3+Q+KaOtpZUcAaTYxRRv0xj5eWVLR18quEXDgjTZ3g3QlDhRauEMuL9nW5U2ltGbW15jDTwgcB4a/9cL1RAjNdXjCfjAH9UFLqBoLvvyh6prHgNKxOLlPSBv4mU3NklETmylM8ubheADYBLdQRUDYiQakh/ofpaooJexcmQLG6WNPDqNlnlQ/vMm2IifzzwLBhjf5sREv5ezNCxxvmEkqzAjsvOn/jxlDqlFHGEYuLYlTU09SRfcuuDTXt+W3tkeGY2xPLloR24dm60USLu1HdTOP7w3jBLC1BuG7IHWbqb+MtD5SAa2DvymvG4UXv9F53GNmgqTy7zNcD03n2EoDi04PmjfgKgdD5IzUWwX801/oMxgYUF6+umo9KViINecxLkYhQofuWByjE56MiBhG4JFg8mszsDh2Rx2xZjLFEa3dgmHlgn7CygURkoBxkJfUkiTIuZ1O3EVyQFGPZrVXhNeWaPdRJPACL6bhogJ6s6BdXNWAKUoUfluzf6urzCJWWOdg9ymFN+zhY8yw87TFh9ZAupkBUTsulMSHHbjkAk31eYRohdsq3nvpsAu8COjtbVtiVqWoAEIRA456WPia5gI5sLM9U0giwiHfBj5t29/uIHVw8EnbBO+B7tQQ4YxmK20Wn56h496rF/r7E9gfGvEoxavcfFwtzHw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(39860400002)(346002)(451199015)(46966006)(40470700004)(36840700001)(83380400001)(31686004)(36860700001)(82310400005)(53546011)(2906002)(26005)(86362001)(81166007)(31696002)(30864003)(82740400003)(44832011)(5660300002)(110136005)(54906003)(16576012)(316002)(478600001)(356005)(70206006)(40460700003)(8676002)(186003)(8936002)(70586007)(2616005)(426003)(47076005)(336012)(41300700001)(40480700001)(4326008)(36756003)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 14:33:49.3361 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: be81b9c5-947e-4f08-36fa-08dad216baf1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT028.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6480 Hi Ayan, On 28/11/2022 16:56, Ayan Kumar Halder wrote: > > > Refer "Arm IHI 0069H ID020922", 12.4.6, Interrupt Controller List Registers > > AArch64 System register ICH_LR_EL2 bits [31:0] are architecturally > mapped to AArch32 System register ICH_LR[31:0]. > AArch64 System register ICH_LR_EL2 bits [63:32] are architecturally > mapped to AArch32 System register ICH_LRC[31:0]. > > Defined ICH_LR<0...15>_EL2 and ICH_LRC<0...15>_EL2 for AArch32. > For AArch32, the link register is stored as :- > (((uint64_t) ICH_LRC<0...15>_EL2) << 32) | ICH_LR<0...15>_EL2 > > Also, ICR_LR macros need to be modified as ULL is 64 bits for AArch32 and > AArch64. > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel , with two remarks (this is up to maintainers as these are rather cosmetic changes). > --- > > Changes from :- > v1 - 1. Moved the coproc register definitions to asm/cpregs.h. > 2. Use GENMASK(31, 0) to represent 0xFFFFFFFF > 3. Use READ_CP32()/WRITE_CP32() instead of READ_SYSREG()/WRITE_SYSREG(). > 4. Multi-line macro definitions should be enclosed within ({ }). > > v2 - 1. Use WRITE_SYSREG_LR(V, R) to make it consistent with before. > 2. Defined the register alias. > 3. Style issues. > > v3 - 1. Addressed style issues. > > xen/arch/arm/gic-v3.c | 132 +++++++++++------------ > xen/arch/arm/include/asm/arm32/sysregs.h | 19 ++++ > xen/arch/arm/include/asm/arm64/sysregs.h | 5 + > xen/arch/arm/include/asm/cpregs.h | 76 +++++++++++++ > xen/arch/arm/include/asm/gic_v3_defs.h | 8 +- > 5 files changed, 170 insertions(+), 70 deletions(-) > > diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c > index 64a76307dd..6457e7033c 100644 > --- a/xen/arch/arm/gic-v3.c > +++ b/xen/arch/arm/gic-v3.c > @@ -73,37 +73,37 @@ static inline void gicv3_save_lrs(struct vcpu *v) > switch ( gicv3_info.nr_lrs ) > { > case 16: > - v->arch.gic.v3.lr[15] = READ_SYSREG(ICH_LR15_EL2); > + v->arch.gic.v3.lr[15] = READ_SYSREG_LR(15); > case 15: > - v->arch.gic.v3.lr[14] = READ_SYSREG(ICH_LR14_EL2); > + v->arch.gic.v3.lr[14] = READ_SYSREG_LR(14); > case 14: > - v->arch.gic.v3.lr[13] = READ_SYSREG(ICH_LR13_EL2); > + v->arch.gic.v3.lr[13] = READ_SYSREG_LR(13); > case 13: > - v->arch.gic.v3.lr[12] = READ_SYSREG(ICH_LR12_EL2); > + v->arch.gic.v3.lr[12] = READ_SYSREG_LR(12); > case 12: > - v->arch.gic.v3.lr[11] = READ_SYSREG(ICH_LR11_EL2); > + v->arch.gic.v3.lr[11] = READ_SYSREG_LR(11); > case 11: > - v->arch.gic.v3.lr[10] = READ_SYSREG(ICH_LR10_EL2); > + v->arch.gic.v3.lr[10] = READ_SYSREG_LR(10); > case 10: > - v->arch.gic.v3.lr[9] = READ_SYSREG(ICH_LR9_EL2); > + v->arch.gic.v3.lr[9] = READ_SYSREG_LR(9); > case 9: > - v->arch.gic.v3.lr[8] = READ_SYSREG(ICH_LR8_EL2); > + v->arch.gic.v3.lr[8] = READ_SYSREG_LR(8); > case 8: > - v->arch.gic.v3.lr[7] = READ_SYSREG(ICH_LR7_EL2); > + v->arch.gic.v3.lr[7] = READ_SYSREG_LR(7); > case 7: > - v->arch.gic.v3.lr[6] = READ_SYSREG(ICH_LR6_EL2); > + v->arch.gic.v3.lr[6] = READ_SYSREG_LR(6); > case 6: > - v->arch.gic.v3.lr[5] = READ_SYSREG(ICH_LR5_EL2); > + v->arch.gic.v3.lr[5] = READ_SYSREG_LR(5); > case 5: > - v->arch.gic.v3.lr[4] = READ_SYSREG(ICH_LR4_EL2); > + v->arch.gic.v3.lr[4] = READ_SYSREG_LR(4); > case 4: > - v->arch.gic.v3.lr[3] = READ_SYSREG(ICH_LR3_EL2); > + v->arch.gic.v3.lr[3] = READ_SYSREG_LR(3); > case 3: > - v->arch.gic.v3.lr[2] = READ_SYSREG(ICH_LR2_EL2); > + v->arch.gic.v3.lr[2] = READ_SYSREG_LR(2); > case 2: > - v->arch.gic.v3.lr[1] = READ_SYSREG(ICH_LR1_EL2); > + v->arch.gic.v3.lr[1] = READ_SYSREG_LR(1); > case 1: > - v->arch.gic.v3.lr[0] = READ_SYSREG(ICH_LR0_EL2); > + v->arch.gic.v3.lr[0] = READ_SYSREG_LR(0); > break; > default: > BUG(); > @@ -120,37 +120,37 @@ static inline void gicv3_restore_lrs(const struct vcpu *v) > switch ( gicv3_info.nr_lrs ) > { > case 16: > - WRITE_SYSREG(v->arch.gic.v3.lr[15], ICH_LR15_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[15], 15); > case 15: > - WRITE_SYSREG(v->arch.gic.v3.lr[14], ICH_LR14_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[14], 14); > case 14: > - WRITE_SYSREG(v->arch.gic.v3.lr[13], ICH_LR13_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[13], 13); > case 13: > - WRITE_SYSREG(v->arch.gic.v3.lr[12], ICH_LR12_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[12], 12); > case 12: > - WRITE_SYSREG(v->arch.gic.v3.lr[11], ICH_LR11_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[11], 11); > case 11: > - WRITE_SYSREG(v->arch.gic.v3.lr[10], ICH_LR10_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[10], 10); > case 10: > - WRITE_SYSREG(v->arch.gic.v3.lr[9], ICH_LR9_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[9], 9); > case 9: > - WRITE_SYSREG(v->arch.gic.v3.lr[8], ICH_LR8_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[8], 8); > case 8: > - WRITE_SYSREG(v->arch.gic.v3.lr[7], ICH_LR7_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[7], 7); > case 7: > - WRITE_SYSREG(v->arch.gic.v3.lr[6], ICH_LR6_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[6], 6); > case 6: > - WRITE_SYSREG(v->arch.gic.v3.lr[5], ICH_LR5_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[5], 5); > case 5: > - WRITE_SYSREG(v->arch.gic.v3.lr[4], ICH_LR4_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[4], 4); > case 4: > - WRITE_SYSREG(v->arch.gic.v3.lr[3], ICH_LR3_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[3], 3); > case 3: > - WRITE_SYSREG(v->arch.gic.v3.lr[2], ICH_LR2_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[2], 2); > case 2: > - WRITE_SYSREG(v->arch.gic.v3.lr[1], ICH_LR1_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[1], 1); > case 1: > - WRITE_SYSREG(v->arch.gic.v3.lr[0], ICH_LR0_EL2); > + WRITE_SYSREG_LR(v->arch.gic.v3.lr[0], 0); > break; > default: > BUG(); > @@ -161,22 +161,22 @@ static uint64_t gicv3_ich_read_lr(int lr) > { > switch ( lr ) > { > - case 0: return READ_SYSREG(ICH_LR0_EL2); > - case 1: return READ_SYSREG(ICH_LR1_EL2); > - case 2: return READ_SYSREG(ICH_LR2_EL2); > - case 3: return READ_SYSREG(ICH_LR3_EL2); > - case 4: return READ_SYSREG(ICH_LR4_EL2); > - case 5: return READ_SYSREG(ICH_LR5_EL2); > - case 6: return READ_SYSREG(ICH_LR6_EL2); > - case 7: return READ_SYSREG(ICH_LR7_EL2); > - case 8: return READ_SYSREG(ICH_LR8_EL2); > - case 9: return READ_SYSREG(ICH_LR9_EL2); > - case 10: return READ_SYSREG(ICH_LR10_EL2); > - case 11: return READ_SYSREG(ICH_LR11_EL2); > - case 12: return READ_SYSREG(ICH_LR12_EL2); > - case 13: return READ_SYSREG(ICH_LR13_EL2); > - case 14: return READ_SYSREG(ICH_LR14_EL2); > - case 15: return READ_SYSREG(ICH_LR15_EL2); > + case 0: return READ_SYSREG_LR(0); > + case 1: return READ_SYSREG_LR(1); > + case 2: return READ_SYSREG_LR(2); > + case 3: return READ_SYSREG_LR(3); > + case 4: return READ_SYSREG_LR(4); > + case 5: return READ_SYSREG_LR(5); > + case 6: return READ_SYSREG_LR(6); > + case 7: return READ_SYSREG_LR(7); > + case 8: return READ_SYSREG_LR(8); > + case 9: return READ_SYSREG_LR(9); > + case 10: return READ_SYSREG_LR(10); > + case 11: return READ_SYSREG_LR(11); > + case 12: return READ_SYSREG_LR(12); > + case 13: return READ_SYSREG_LR(13); > + case 14: return READ_SYSREG_LR(14); > + case 15: return READ_SYSREG_LR(15); > default: > BUG(); > } > @@ -187,52 +187,52 @@ static void gicv3_ich_write_lr(int lr, uint64_t val) > switch ( lr ) > { > case 0: > - WRITE_SYSREG(val, ICH_LR0_EL2); > + WRITE_SYSREG_LR(val, 0); > break; > case 1: > - WRITE_SYSREG(val, ICH_LR1_EL2); > + WRITE_SYSREG_LR(val, 1); > break; > case 2: > - WRITE_SYSREG(val, ICH_LR2_EL2); > + WRITE_SYSREG_LR(val, 2); > break; > case 3: > - WRITE_SYSREG(val, ICH_LR3_EL2); > + WRITE_SYSREG_LR(val, 3); > break; > case 4: > - WRITE_SYSREG(val, ICH_LR4_EL2); > + WRITE_SYSREG_LR(val, 4); > break; > case 5: > - WRITE_SYSREG(val, ICH_LR5_EL2); > + WRITE_SYSREG_LR(val, 5); > break; > case 6: > - WRITE_SYSREG(val, ICH_LR6_EL2); > + WRITE_SYSREG_LR(val, 6); > break; > case 7: > - WRITE_SYSREG(val, ICH_LR7_EL2); > + WRITE_SYSREG_LR(val, 7); > break; > case 8: > - WRITE_SYSREG(val, ICH_LR8_EL2); > + WRITE_SYSREG_LR(val, 8); > break; > case 9: > - WRITE_SYSREG(val, ICH_LR9_EL2); > + WRITE_SYSREG_LR(val, 9); > break; > case 10: > - WRITE_SYSREG(val, ICH_LR10_EL2); > + WRITE_SYSREG_LR(val, 10); > break; > case 11: > - WRITE_SYSREG(val, ICH_LR11_EL2); > + WRITE_SYSREG_LR(val, 11); > break; > case 12: > - WRITE_SYSREG(val, ICH_LR12_EL2); > + WRITE_SYSREG_LR(val, 12); > break; > case 13: > - WRITE_SYSREG(val, ICH_LR13_EL2); > + WRITE_SYSREG_LR(val, 13); > break; > case 14: > - WRITE_SYSREG(val, ICH_LR14_EL2); > + WRITE_SYSREG_LR(val, 14); > break; > case 15: > - WRITE_SYSREG(val, ICH_LR15_EL2); > + WRITE_SYSREG_LR(val, 15); > break; > default: > return; > @@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v) > if ( v == current ) > { > for ( i = 0; i < gicv3_info.nr_lrs; i++ ) > - printk(" HW_LR[%d]=%lx\n", i, gicv3_ich_read_lr(i)); > + printk(" HW_LR[%d]=%" PRIx64 "\n", i, gicv3_ich_read_lr(i)); 1. We do not usually add spaces between " and PRIx. > } > else > { > for ( i = 0; i < gicv3_info.nr_lrs; i++ ) > - printk(" VCPU_LR[%d]=%lx\n", i, v->arch.gic.v3.lr[i]); > + printk(" VCPU_LR[%d]=%" PRIx64 "\n", i, v->arch.gic.v3.lr[i]); > } > } > > diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h > index 6841d5de43..22871999af 100644 > --- a/xen/arch/arm/include/asm/arm32/sysregs.h > +++ b/xen/arch/arm/include/asm/arm32/sysregs.h > @@ -62,6 +62,25 @@ > #define READ_SYSREG(R...) READ_SYSREG32(R) > #define WRITE_SYSREG(V, R...) WRITE_SYSREG32(V, R) > > +/* Wrappers for accessing interrupt controller list registers. */ > +#define ICH_LR_REG(index) ICH_LR ## index ## _EL2 > +#define ICH_LRC_REG(index) ICH_LRC ## index ## _EL2 > + > +#define READ_SYSREG_LR(index) ({ \ > + uint64_t _val; \ > + uint32_t _lrc = READ_CP32(ICH_LRC_REG(index)); \ > + uint32_t _lr = READ_CP32(ICH_LR_REG(index)); \ > + \ > + _val = ((uint64_t) _lrc << 32) | _lr; \ > + _val; \ > +}) > + > +#define WRITE_SYSREG_LR(v, index) ({ \ > + uint64_t _val = (v); \ > + WRITE_CP32(_val & GENMASK(31, 0), ICH_LR_REG(index)); \ > + WRITE_CP32(_val >> 32, ICH_LRC_REG(index)); \ > +}) > + > /* MVFR2 is not defined on ARMv7 */ > #define MVFR2_MAYBE_UNDEFINED > > diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h > index 54670084c3..4638999514 100644 > --- a/xen/arch/arm/include/asm/arm64/sysregs.h > +++ b/xen/arch/arm/include/asm/arm64/sysregs.h > @@ -472,6 +472,11 @@ > #define READ_SYSREG(name) READ_SYSREG64(name) > #define WRITE_SYSREG(v, name) WRITE_SYSREG64(v, name) > > +/* Wrappers for accessing interrupt controller list registers. */ > +#define ICH_LR_REG(index) ICH_LR ## index ## _EL2 > +#define WRITE_SYSREG_LR(v, index) WRITE_SYSREG(v, ICH_LR_REG(index)) > +#define READ_SYSREG_LR(index) READ_SYSREG(ICH_LR_REG(index)) > + > #endif /* _ASM_ARM_ARM64_SYSREGS_H */ > > /* > diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h > index 6daf2b1a30..b85e811f51 100644 > --- a/xen/arch/arm/include/asm/cpregs.h > +++ b/xen/arch/arm/include/asm/cpregs.h > @@ -8,6 +8,8 @@ > * support 32-bit guests. > */ > > +#define ___CP32(coproc, opc1, crn, crm, opc2) coproc, opc1, crn, crm, opc2 2. As you are using ___CP32 much later in this file, it could be moved... > + > #define __HSR_CPREG_c0 0 > #define __HSR_CPREG_c1 1 > #define __HSR_CPREG_c2 2 > @@ -259,6 +261,48 @@ > #define VBAR p15,0,c12,c0,0 /* Vector Base Address Register */ > #define HVBAR p15,4,c12,c0,0 /* Hyp. Vector Base Address Register */ ...here, before first use. The remark I gave in v3 was that the definition should occur before use, but it does not mean placing the macro at the top of the file. > > +/* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ > +#define __LR0(x) ___CP32(p15, 4, c12, c12, x) > +#define __LR8(x) ___CP32(p15, 4, c12, c13, x) > + > +#define ICH_LR0 __LR0(0) > +#define ICH_LR1 __LR0(1) > +#define ICH_LR2 __LR0(2) > +#define ICH_LR3 __LR0(3) > +#define ICH_LR4 __LR0(4) > +#define ICH_LR5 __LR0(5) > +#define ICH_LR6 __LR0(6) > +#define ICH_LR7 __LR0(7) > +#define ICH_LR8 __LR8(0) > +#define ICH_LR9 __LR8(1) > +#define ICH_LR10 __LR8(2) > +#define ICH_LR11 __LR8(3) > +#define ICH_LR12 __LR8(4) > +#define ICH_LR13 __LR8(5) > +#define ICH_LR14 __LR8(6) > +#define ICH_LR15 __LR8(7) > + > +/* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ > +#define __LRC0(x) ___CP32(p15, 4, c12, c14, x) > +#define __LRC8(x) ___CP32(p15, 4, c12, c15, x) > + > +#define ICH_LRC0 __LRC0(0) > +#define ICH_LRC1 __LRC0(1) > +#define ICH_LRC2 __LRC0(2) > +#define ICH_LRC3 __LRC0(3) > +#define ICH_LRC4 __LRC0(4) > +#define ICH_LRC5 __LRC0(5) > +#define ICH_LRC6 __LRC0(6) > +#define ICH_LRC7 __LRC0(7) > +#define ICH_LRC8 __LRC8(0) > +#define ICH_LRC9 __LRC8(1) > +#define ICH_LRC10 __LRC8(2) > +#define ICH_LRC11 __LRC8(3) > +#define ICH_LRC12 __LRC8(4) > +#define ICH_LRC13 __LRC8(5) > +#define ICH_LRC14 __LRC8(6) > +#define ICH_LRC15 __LRC8(7) > + > /* CP15 CR13: */ > #define FCSEIDR p15,0,c13,c0,0 /* FCSE Process ID Register */ > #define CONTEXTIDR p15,0,c13,c0,1 /* Context ID Register */ > @@ -317,6 +361,38 @@ > #define HCR_EL2 HCR > #define HPFAR_EL2 HPFAR > #define HSTR_EL2 HSTR > +#define ICH_LR0_EL2 ICH_LR0 > +#define ICH_LR1_EL2 ICH_LR1 > +#define ICH_LR2_EL2 ICH_LR2 > +#define ICH_LR3_EL2 ICH_LR3 > +#define ICH_LR4_EL2 ICH_LR4 > +#define ICH_LR5_EL2 ICH_LR5 > +#define ICH_LR6_EL2 ICH_LR6 > +#define ICH_LR7_EL2 ICH_LR7 > +#define ICH_LR8_EL2 ICH_LR8 > +#define ICH_LR9_EL2 ICH_LR9 > +#define ICH_LR10_EL2 ICH_LR10 > +#define ICH_LR11_EL2 ICH_LR11 > +#define ICH_LR12_EL2 ICH_LR12 > +#define ICH_LR13_EL2 ICH_LR13 > +#define ICH_LR14_EL2 ICH_LR14 > +#define ICH_LR15_EL2 ICH_LR15 > +#define ICH_LRC0_EL2 ICH_LRC0 > +#define ICH_LRC1_EL2 ICH_LRC1 > +#define ICH_LRC2_EL2 ICH_LRC2 > +#define ICH_LRC3_EL2 ICH_LRC3 > +#define ICH_LRC4_EL2 ICH_LRC4 > +#define ICH_LRC5_EL2 ICH_LRC5 > +#define ICH_LRC6_EL2 ICH_LRC6 > +#define ICH_LRC7_EL2 ICH_LRC7 > +#define ICH_LRC8_EL2 ICH_LRC8 > +#define ICH_LRC9_EL2 ICH_LRC9 > +#define ICH_LRC10_EL2 ICH_LRC10 > +#define ICH_LRC11_EL2 ICH_LRC11 > +#define ICH_LRC12_EL2 ICH_LRC12 > +#define ICH_LRC13_EL2 ICH_LRC13 > +#define ICH_LRC14_EL2 ICH_LRC14 > +#define ICH_LRC15_EL2 ICH_LRC15 > #define ID_AFR0_EL1 ID_AFR0 > #define ID_DFR0_EL1 ID_DFR0 > #define ID_DFR1_EL1 ID_DFR1 > diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h > index 48a1bc401e..227533868f 100644 > --- a/xen/arch/arm/include/asm/gic_v3_defs.h > +++ b/xen/arch/arm/include/asm/gic_v3_defs.h > @@ -185,9 +185,9 @@ > #define ICH_LR_HW_SHIFT 61 > #define ICH_LR_GRP_MASK 0x1 > #define ICH_LR_GRP_SHIFT 60 > -#define ICH_LR_MAINTENANCE_IRQ (1UL<<41) > -#define ICH_LR_GRP1 (1UL<<60) > -#define ICH_LR_HW (1UL<<61) > +#define ICH_LR_MAINTENANCE_IRQ (1ULL << 41) > +#define ICH_LR_GRP1 (1ULL << 60) > +#define ICH_LR_HW (1ULL << 61) > > #define ICH_VTR_NRLRGS 0x3f > #define ICH_VTR_PRIBITS_MASK 0x7 > @@ -195,7 +195,7 @@ > > #define ICH_SGI_IRQMODE_SHIFT 40 > #define ICH_SGI_IRQMODE_MASK 0x1 > -#define ICH_SGI_TARGET_OTHERS 1UL > +#define ICH_SGI_TARGET_OTHERS 1ULL > #define ICH_SGI_TARGET_LIST 0 > #define ICH_SGI_IRQ_SHIFT 24 > #define ICH_SGI_IRQ_MASK 0xf > -- > 2.17.1 > > ~Michal From xen-devel-bounces@lists.xenproject.org Tue Nov 29 14:35:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:35:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449410.706115 (Exim 4.92) (envelope-from ) id 1p01iF-0002dM-6i; Tue, 29 Nov 2022 14:35:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449410.706115; Tue, 29 Nov 2022 14:35:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01iF-0002dF-1w; Tue, 29 Nov 2022 14:35:55 +0000 Received: by outflank-mailman (input) for mailman id 449410; Tue, 29 Nov 2022 14:35:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01iD-0002d6-Mt for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:35:53 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20607.outbound.protection.outlook.com [2a01:111:f400:7e88::607]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1f2b3ef3-6ff3-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 15:35:52 +0100 (CET) Received: from DM6PR11CA0031.namprd11.prod.outlook.com (2603:10b6:5:190::44) by DM6PR12MB4073.namprd12.prod.outlook.com (2603:10b6:5:217::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 14:35:47 +0000 Received: from DM6NAM11FT021.eop-nam11.prod.protection.outlook.com (2603:10b6:5:190:cafe::98) by DM6PR11CA0031.outlook.office365.com (2603:10b6:5:190::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Tue, 29 Nov 2022 14:35:47 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT021.mail.protection.outlook.com (10.13.173.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.22 via Frontend Transport; Tue, 29 Nov 2022 14:35:46 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 29 Nov 2022 08:35:46 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 29 Nov 2022 06:35:46 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 29 Nov 2022 08:35:44 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f2b3ef3-6ff3-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kBXblZEm4mQBrX3TNylt5XnJ2AhEeZ2gBMbnTxLh6cfUTIi/pmENnRnYkgn2L5LBjqqQOOb4J/K7ayjov00AcrdBTfiH9Y6acPSDUZUdj53geYKrEBLYpo6CtYAGqiXnOBgSKaCTJxOyZc+h0fTp/SJEaQO45c1k3Shy1ASVjiMjreNUGNOB8epdSOxJ2/o5zHGjPCpGNUqdk7pMsa53dyATTMrPOX/qW4/0New/q+f1vIvghwmfbkCpnHU/gnq6aUQT8IxoTKF7BRJyBUHpRziUYu4KJYvD5na1NJm/EM79rRwtBkItEMA42NRzrDOOW1cik9il8O2IDEmWTvvMEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8SaO6BxjxVhpqpUkYC2eREnHIrzGVzLqh8S2ov/8Gg4=; b=UaQLSrirjsI+j8oC0fOn7nZs3juRHuEvOB5917DJPlRcarmxYR4AT5qQC1yoiS9U5s7GzKQx7yn4ZNyNt5YvHN9zkHgllRTlGowEpEYSb0qRE1J4xVYXHTQMsc/CLBbnrsN7N/8AFfaGwR3YtLGU9Cv1475UjyK84VpdPw2zMWqk5jTnT8yLA65C/ZU84M4U5tWHX5juBKTSJsQc424dGPQPMhFEjSm2LvFWm4WGnTkeeITQ+QpTCcg4EkGj2tiO7ymZPPasz3x8ZzTrcYPTXs3thgSj42+9vyERlKeF/L1I6aoh1yVJATNCPrvoJuz+BDdCiAC1FRRwwr4XHyREVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8SaO6BxjxVhpqpUkYC2eREnHIrzGVzLqh8S2ov/8Gg4=; b=V90V09fgacsvP/0uMAKbkKrWyxYjsB3HZvSnJmcmxuWdukmwPGPZpj4qiGa0iT+n12H3aa2cfBmp6a2CB+crmeSAEOSNq6r060+sPVquwudZUy94rZSUUH9BDAoPMV6tZlYNdPx1BlSRcqUVTMyemWMaS5LasA5aP5MQ7sRpi2M= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <16eafb2b-988a-4289-8660-ad5f764888d6@amd.com> Date: Tue, 29 Nov 2022 15:35:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN v4 08/11] xen/Arm: GICv3: Define ICH_AP0R and ICH_AP1R for AArch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> <20221128155649.31386-9-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20221128155649.31386-9-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT021:EE_|DM6PR12MB4073:EE_ X-MS-Office365-Filtering-Correlation-Id: 39aecda4-70a5-4c9a-6940-08dad21700f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zorjisd5E+8UjZI1TprkW8nH3QIkzpsExGsxH52KztfSEsUO00isIU5mvLX8NpSrmzDNCsbmnqkwGzPu+Q9eJyImX4ANjn4jhNvJArVrSNqx5w0QPzEExL/nKOO5FdifucmA2ePoMQNIkQSBpMb4owjB/dh5kkdoNWT/eJSqLAp/mpWiYamrnak3t8LbqAFp3jxwnFC1TXt8OsHKPyAoMXM/2ajv4fdoXJls0i4YQyDSHisK7vLZTI5FgeI0QjSaGnl1HrZjO1i35ga1zolQqro+ryAxH2JONTa8Hy7Q5ljaUOXExfu/eYOSpCUjqESFgV9AZPRp0yDUwjXXvIICPsSZEvnfgVYj5HunUb77KYMNHkhmVDgijlR5BPUKps2BQPeIqTRgMvdmAxmiivDnCAirz+9vBKQ91OCPC8+BO6sCIc+CtYMbMIQTd2SbY8b/zpExcKgQNTo4JbD3mV7heoWUTiaXnvcbMN0XICp2UE8mGzJQSzZas7UXyn2yAaiyhX1lKTll22ZfdcrUXzbV5poCJoPtczABHirRxRlKdXRWp0U5H5WDyRH/Vtd+V0Ucu+pjl8+iSuwwrX8+QMAba63cOS8d3+XPCwBVGDfhY2FsPBtryvprq48tSqiBLoUVj49oRY1VWgQnDp7DsTzC/ZHxTkeGIfbBTGyGsUyKwiZYhNivL/PUesaV0q+BTzlKh5lOihUFXZL8D6ewDGthQ2EjjYR1XixsC6HVxggFB4SL1zEdRSyPt5Cb1rNZeCMNFkAKdIWduB0Qu3t2kGB9uA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(346002)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(5660300002)(41300700001)(8936002)(44832011)(8676002)(4326008)(4744005)(31686004)(356005)(54906003)(110136005)(81166007)(40460700003)(478600001)(70586007)(316002)(2906002)(70206006)(16576012)(336012)(36756003)(86362001)(53546011)(31696002)(26005)(2616005)(186003)(83380400001)(36860700001)(82310400005)(47076005)(426003)(40480700001)(82740400003)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 14:35:46.7991 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 39aecda4-70a5-4c9a-6940-08dad21700f9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT021.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4073 Hi Ayan, On 28/11/2022 16:56, Ayan Kumar Halder wrote: > Adapt save_aprn_regs()/restore_aprn_regs() for AArch32. > > For which we have defined the following registers:- > 1. Interrupt Controller Hyp Active Priorities Group0 Registers 0-3 > 2. Interrupt Controller Hyp Active Priorities Group1 Registers 0-3 > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Tue Nov 29 14:36:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:36:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449413.706126 (Exim 4.92) (envelope-from ) id 1p01ig-00038r-Hj; Tue, 29 Nov 2022 14:36:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449413.706126; Tue, 29 Nov 2022 14:36:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01ig-00038k-Em; Tue, 29 Nov 2022 14:36:22 +0000 Received: by outflank-mailman (input) for mailman id 449413; Tue, 29 Nov 2022 14:36:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01ie-0002d6-MB for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:36:20 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20608.outbound.protection.outlook.com [2a01:111:f400:7d00::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3017bfa0-6ff3-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 15:36:19 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8864.eurprd04.prod.outlook.com (2603:10a6:102:20f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20; Tue, 29 Nov 2022 14:36:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 14:36:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3017bfa0-6ff3-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YN0ytvtAWYsO18d2ipOc0n9uiXHR6UmKLwXwWC7vvqoEegH+gM2JJCoo1DMJqIBUfdkIp7/jP9yAK5GPAxxDFwX9XZqDbhjEkhlJPTX8/9o/A9XY28Mo0cNs5pGL+Z6Rzq4UW2PA9a+dVThbhkndJ1oBR/fp9LcqYh6xb7ahWdDc+dHNej05yxc6trUfDlwoKjqaI4cgx/a0TgfU685Gk4Gd+sDd8Z62SNmkWcKis6RaFLwkCNFL9gUPf6XOLQjvGY5+PG/0boZTRSQeD2N552EUFmzMWSHcfHMm/DMI93oJjnIZrwByu/19GqI4JiRXNddQxUHR8ypcoXBfwm46gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7xsezOeytEYElDGXFOksgYsTvpYOo4tlT84ILzDSLPs=; b=ivGFj6psiOKRFJpHqb4eHAcUL8JL5LWls1jcvIorVe4bvNPm24CL37602pYtSwhDnCI0UJZYTrHvas+nfsmumtjaYgTzIRo3h1SMFGuL81GvLkR9bLoq322pVOFJYcJTFu78kC5ZYNQr8QU4b5uDfXRYq3X+klRUJ84lbELA02Q6y//yykkfBWWrXJnRYUxvvu1YzQcxQmWVzywjn4STV/Osrjywwq4hq0z+KZINckON3s13WFX0Wbxk1C0MDu0t+l2XST7PUBaAldxszvwZ1s25Dlovq3/uVR8/5y4jY274bIVe1KQqeeH1GDyX4daen6KPr3pc92MBZciA/YcSbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7xsezOeytEYElDGXFOksgYsTvpYOo4tlT84ILzDSLPs=; b=4jdT+y3GBKdNU/e6Jb6lNA7l5s+hFMyKG8puJdbjCHi4aUFaNFpxlqL4eWyTsQnZnVT+x1Gpl+yHZshsz2o7BfOD7GuPtvySfT6PZ/x+tXkbkBxWYDyHhTtYr5bOP+norGH7i/0AhUtW5rXRZBMQOEVbqFAiRCY1ka0ziE1S1yEa+ec9oG0NA7dijU1ioIkV0LaM7powqq2wyRnR2CE3M3Lv2zO+9fZJS4/qqJJ6Sb5blFoyDGrsVgTpRWuBR69V+9aVpchj5qqXtipWDPF2fFlvjbCPCUTDTzTVIUkNKD1gi9NyqcgRJ+4XSbuCC2wHxYwmArnvAktuk+fgFa46PA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <22d39f29-d87d-b3f6-d601-85fa1d4a72f7@suse.com> Date: Tue, 29 Nov 2022 15:36:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu From: Jan Beulich Subject: [PATCH] bump default SeaBIOS version to 1.16.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0179.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8864:EE_ X-MS-Office365-Filtering-Correlation-Id: f7886aed-6d13-41ee-2c6b-08dad217138a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7dbZyrXrvO3m40VH4a7XF3seJdRh8kcc1R8B0tcQV3lYph4NLj4sMgG1FkgZ0aNejVzgLzITRBUUu0Rx6kT9bKOzP9umVg8S7Aj3eiQx0C3Oowwifi8A9zR0xFpPqwAnmMCjqmO8fdDpyU27jzncNyTiaLY1bMmQLz1KZbCEkEEVolCPfqVcOMGjjO1aePC2kNsMzdg0FykbTPSkRaewMkFEurJgAr6XUStlJqgeUguRjeEoJrk6y9+JVPgdhPDMmR9p9bqO/r9sCEhymGv0AgTunltvXcCecyXKjRgwP3j9l2AeQ4CFSXjxPqsxM8K1L2ZV+UwygTVWs9TUZXSVNDS8wvWOVsl0vz9gqA2tCGLLKmM01ea1crk8+EzvfqCO6/9c7G/wirmHC5fD16dItPBDn25GsbPCePP5IjoEgCAwf/pH/VC02e2u/hSA/0Cj4geipsLBPbq8JaCnCxJCApzQ2LYB0p7AGJ6KZrCSgwe8pJy8CFru1gUzMXGY2clgLQBqXfWERluzSUTtTBPl/+q1sULTvFDJb3p/n+dFRBZMwXaCHr0ZNSr1SUVCEdxIuF8I26DzPdpl5eKJimriucRWKde/XyxcW5Lgui31jDiAB0cbwIDOzBEwiNkykf0ddFTI5CoB/nyQA/TTVRkKEWPZ8JloOUmNM8FvPKBcaw+dCGW07VKbyMm7dMahmGo4IxrB68vYqe2Xred9v777vFqE/cLN4GDjgnvSESvR2tY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(39860400002)(136003)(376002)(346002)(451199015)(2616005)(8676002)(5660300002)(26005)(36756003)(6512007)(8936002)(4326008)(316002)(186003)(41300700001)(66476007)(54906003)(4744005)(2906002)(6916009)(38100700002)(31696002)(86362001)(66556008)(6486002)(66946007)(478600001)(31686004)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUxBSEcwWUN4akx2UWQ4Ty9vRmt6N1VGRXcxa2RJWlR4Vm0xWUxkSGVrTVJD?= =?utf-8?B?dGIrMlRNdW45Q05BeEtranpLdzlqbmswaFQvMkxlbC8xckhjQjNvMDhzcjhD?= =?utf-8?B?aXpHZzVuUE1jQVU3Z1hISlBkcWJ6MXZpMENWK3dHNGd0cCtaODU4WWg2THcw?= =?utf-8?B?YXEzTVV6TUJrR1VZMDdvTm5FQ1lwdkZDVExwYjE5K3NRZHFPL284RjZvbDhh?= =?utf-8?B?c295ekQrSEExV0pUcS9qdHhwK0ZDTVBtK0d6S2FnS05EcjU5dHhJc056ZEtz?= =?utf-8?B?cUNzOVVwNTVIbGV4YXJoTG55OGhXUkRuK1ArNWRiNjI1M1BoT2VLa2xhQXRr?= =?utf-8?B?WlZqWm5DbnF4Vk9qRGIrM05sdkpISXZtaVBHTWwrWHV2WDVaT1dmUXVUZFp1?= =?utf-8?B?V2RFSGZtSGplMHMrRlNtRVRQY0hLUnFrY2QxaTV3SXdEZmI5QkdHWUV3WjhL?= =?utf-8?B?SDJ3RUM1REQ5RUxSaVJSTkZRTlJERDlZbmc3aG1OUExsaEFHNlRTTHRqdThn?= =?utf-8?B?cXhiWmdnVnpBbm5KbVpEeXBxdllIK0M5cE5KenVINm81OHkrQ1RvdTFZRVVh?= =?utf-8?B?UlJvb0FabnUrMDJuN1VRS3VBYWJOWjd2ak9VdjAvdzJ1YzZkekJidklKOTRl?= =?utf-8?B?dUM5MWxYMU5hV3VzdU1LMnBOWmNodnVaaXJLY0t3RnZKampQRDRMSTdiaWdV?= =?utf-8?B?Q05EWlhHZ0dqMXM2bkNrL1o0WWFvVlEvaG5pMDRhNDlWSmE3d29RSVplTDUz?= =?utf-8?B?azl4Um1ROHZhZlNFRjhOWGhPVVRnUXRHMFRhZXVxa3NGbEExMkcrUjlpeE1X?= =?utf-8?B?QmtrUnUyai9ldG5STG14OG1CR2QzU0c0TUlrYXUzVXM0MEhycnZUckdVMXR4?= =?utf-8?B?MWxTNEpWNi9XSExoSzBEZ2pkLzJXamIwVDE5YnM4NjBpMWU5ckNaVVZ2Y3I3?= =?utf-8?B?dHFSQi9SM1NtWnY5U0ZHZkh5T29sa0ZFbDdjTm1LbldIYU1vOHdNbnEyOG14?= =?utf-8?B?YWIxS2lWMmZQQ0VISkRoWVdYLzdNaU5lVTVzdmlMK1h4ZC9wUTg3cEpJRTUz?= =?utf-8?B?d0xBK1JTQThtQ1V3UVI0UFNIYitvWjdNNHREaUJwa2RpVm5vQ2Z1S3F4UVZN?= =?utf-8?B?bWRHYzZnSVVpcHMyQkxMWHFFMFhxMUNmK1ZZcWFiWnkzdUZPUWJNMXVDeFRh?= =?utf-8?B?TVErL1Bkb1h5dG1nOTdiRWFnbExNdnFQYzdRQ0FaZGt6RFpRT1I5OTVBUHB4?= =?utf-8?B?YWRUMHl5aVA5VEVCVVNubUlDR0dJL3R0cDdCSHdDU1BJdHE2clB5Tnh4UGU1?= =?utf-8?B?cENYc3JkUytZOS95dGdqQnMybXlOdHBWcmdXa1RXL2gwUjU1VXVCQ1JjMXNs?= =?utf-8?B?Kzl0YXFaY3IyOUN1aThxTmtMVGhGMkRNekNjTHl5ckJ3Y1JicGhGSDZDaEVY?= =?utf-8?B?MzJSVU9uVThjbkhoT2xSWFFheHo1QUJEd1pzK3FzSWx1WkpqcElNWTNLcXRR?= =?utf-8?B?OEpHRHI0alUxS21rSTFFQ1Z1T2JoSzUrRHJjN0F3MWQ1b0RVVDZwcTByTncw?= =?utf-8?B?SXJVRzdJSkxjZWsyTllkQm9RRDZmbmg3NnFHUWcwRXdmdFNpWnp4Qi9xT3ZQ?= =?utf-8?B?YkVTN2E4WnF0bi9jcGZxM040S2JKeFd2S012VkQzWXAwVUhqb3FublhTcXZv?= =?utf-8?B?bnFiUCtBeWpYY2JxVGdIR3h0Qi9ZSHFVNGdFSllkUmIrMWx0RUFIU1hIeHMy?= =?utf-8?B?V3IvdmVCR1JsV3Y5QzRHaktQMFE3VUx1TzVFRWpXRitocHh0RXdFYThQbjY1?= =?utf-8?B?U3pXZUJqU1JuVGVoYnBFelJJMHpPZk5yMjRDVm8vREErbDdNampZaU41aWhh?= =?utf-8?B?Qk1VMXN2UzZCcEhpUG1FRnhuM0VqbXVyb2F4bld5ZHNVMlZKdmt4S2w0RFJD?= =?utf-8?B?UTJvMy9DYWI0QTQ5Vjh4OHVQUTAvaXIwNGtOemdqcjBnbXMvdWdoSFZPN05J?= =?utf-8?B?dTJNL1dncDhwNkdCQUZYTWFJSGx0blFyVFI3dnFNeDllWEpVV1p0bEhWMmRi?= =?utf-8?B?SU9ibDlkblVwdHRkclR0eFBEYk54RytSZjZiem4yeUEwTXhkUEVjd1VRODJ4?= =?utf-8?Q?l7FHtnxRz9zKQQzy+skaC9nvT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7886aed-6d13-41ee-2c6b-08dad217138a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 14:36:18.1655 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YW7si0z6Qtqrge4tBIyzhG6gX9Nmz126GyJcyPrglNesiCEv2pXB4azsSgTipalq4NqzKrf6PpPGKDD/pFhlYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8864 Signed-off-by: Jan Beulich --- a/Config.mk +++ b/Config.mk @@ -232,7 +232,7 @@ OVMF_UPSTREAM_REVISION ?= 7b4a99be8a39c1 QEMU_UPSTREAM_REVISION ?= b746458e1ce1bec85e58b458386f8b7a0bedfaa6 MINIOS_UPSTREAM_REVISION ?= 5bcb28aaeba1c2506a82fab0cdad0201cd9b54b3 -SEABIOS_UPSTREAM_REVISION ?= rel-1.16.0 +SEABIOS_UPSTREAM_REVISION ?= rel-1.16.1 ETHERBOOT_NICS ?= rtl8139 8086100e From xen-devel-bounces@lists.xenproject.org Tue Nov 29 14:39:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:39:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449423.706137 (Exim 4.92) (envelope-from ) id 1p01lO-0003tb-Ve; Tue, 29 Nov 2022 14:39:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449423.706137; Tue, 29 Nov 2022 14:39:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01lO-0003tU-Sp; Tue, 29 Nov 2022 14:39:10 +0000 Received: by outflank-mailman (input) for mailman id 449423; Tue, 29 Nov 2022 14:39:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01lN-0003tK-Al for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:39:09 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7d00::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 94aa6f2c-6ff3-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 15:39:08 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8864.eurprd04.prod.outlook.com (2603:10a6:102:20f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20; Tue, 29 Nov 2022 14:39:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 14:39:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94aa6f2c-6ff3-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LQlETgz0hFhyPmHf4oxK2JSsanQdu48Q2bN4IxhLmPJ44C1t2yu2BAs/Iu0LYBONav0ejyl0xIumzRbewx9QS0m8nXY8XJ/A0y7LbKEYmphxGGOnvEcbG61umJ1yPAH4N/3C14ntP/x4rJJ+M+ha1fwAQ+agiYbwMfK07TGIK+I9ifJbdGbDdKyNXgeMen1GYMURjFKDS7Tq5LVtTd+m1PwHWr0OyDmEbShFqYtKtPr1R5KGkJdLEVjDFQZvKiMJBIvOPn/ZiZiPPZ8k9ifV8E8WQaMRtlPo+t+XpG+FVxjmvW82G/rVgCxkxF6X9K0VPoKvdT7yn/hgy/0xkJdEow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a3OpF1woK9VvvQNT661w/BfGQpJYfrcyi80/QATXGsc=; b=cNTCv03GkKGrecL1mwTxNBwkLNETAaK3cdtlmN5rT2LvtqMnurPP7aXxImqpRRn8AsXJlxMzcHQRjjIv28n1mHOHqemQO1C9Cq0oA2afFLu1D3oX7ucEOXy2ELptX1QG5LMm6EccyiSVozp8uocmb24pEUwPCuiqzXp9wRR8AoQIjzvPvyKD5HQcJVKKP4AnPTZLfMyVghM77yKSxAalPjGu2Am+iehCCKtQT6kwDHHdPPW9f/+tlJZS7HWoWznizFNoKnesO9MGR+9E1IWEVVEK3P1o0R64UwandqiCB+KDBEcLLjdR/O5VIUzzqTu9Oo4WoAOCb1eTN2lwpYxtzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a3OpF1woK9VvvQNT661w/BfGQpJYfrcyi80/QATXGsc=; b=CrkRaHFdx+a20xgMMHGaj304JWzSkxJFpNmQUpWv5/0cLAMiVOs143Q0GHR0NLjkSM4dbs0PqMNnXwkFz4qStD+NW1eautINFWuZMufE502icvl3wX0HQXgd20kAkHg738nTH+lJ4vBhyi/O203Jzv62VXbusqaR/5VE4KF5jsh5TGC44oQ0wqtfTs2wmh9j05J/CEjxhT0e7FGi76+z0n6NfKYUhZXeS39kD+gDTTO2PaDHduOiP6exJwcRbUEVux8RKQA4gqln8bzRt8SNZgI/fN0ZnP9LX1/X6uYqdWivoJ6YBjV0NJkiAIY3lM9yn7GMoTynTfS0JbVrFXAQog== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5a249b00-5467-1733-cab0-fd6d55765e20@suse.com> Date: Tue, 29 Nov 2022 15:39:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis From: Jan Beulich Subject: [PATCH] Arm64: make setup_virt_paging()'s pa_range_info[] static Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8864:EE_ X-MS-Office365-Filtering-Correlation-Id: e7b418bc-d9f1-4c9a-8582-08dad2177803 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vBy7WDwo/pJQFl8nAQHHiPwXTgdBXRg5IoOGpHD3kyWcCv74KZkf333fPsRkvIiq+y4/+WUf8KXvzmQCwShQ2cYwU5SUO9o/pESe/PeYwnrViDvloQh6dwTLACNtUWeCRZ+V5ubxU1LqoL34yQL5VOFsuW6rqN/4xRsQR043eX6midqO45JEvM6ZrG8FVS0Xgsl/h/aKhldhOi9Yb2a1SJUIfPM0YgCJo6d9ML3vU9MovxgACcSbEvwSTUehbN3Jz9q8jnNVI0/mKS8EcAGFsMCCKP5LRPykVJLWAkDP4MSeKLjKAmm0oHq9s3HC8UIv6o0bHm0lCHj3AIP037fwSShFxKcprn2IYIvToWLB2v3RpyTQmdzc8+QfctvAeFvkdf171zf21db49ZEzfGeLzHeDnGEZgTnxj0S+adaMfe3rxzI2fU4ZdafSQojwpqrP7eXDMaoQAlshYf72p867XCgMpRl/ME5gdz5jJKtuj9+VDFTGqU62OJfsKlr7ntrgyYF2zlvRop9Mi4DHzR7D+HcCtt4wOWB0f4GUoJetjf++UlP7yrvSGF/J7wtP8D9wes2hBBjwGI5UpMODJEF/35GqlGPFX1iaMvaoEJsieJtkhhCfAQrb2U/dOmuddeKQze3ypU/7KkRiMEJxVcPGjeOLmMgsiS5B6IZf4SJc1eNtPKYl0CpTuteLrDOux+iwh/L4YG97lGoIYZwRZaHbRGSYCvZ+yu1LmeWoy0+MUF8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(39860400002)(136003)(376002)(346002)(451199015)(2616005)(8676002)(5660300002)(26005)(36756003)(6512007)(8936002)(4326008)(316002)(186003)(41300700001)(66476007)(54906003)(2906002)(6916009)(38100700002)(31696002)(86362001)(83380400001)(66556008)(6486002)(66946007)(478600001)(31686004)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NS9XRmNlNWVab2hkcXZLcTd5Y3VjaXA1RDZEZ1VXaVJvVWJmUE0wckU1UllE?= =?utf-8?B?dTdZQWFlSWxYTlVWOStPZFNMMUNYVWk1TXJQNkVLYXBPVUcybXNTZENVanY4?= =?utf-8?B?U0tick1oQStvZEtXRWpxc1VVaW5BUlZGeTZtY3lsVFI1Y1NhTFB0eUxsRkgx?= =?utf-8?B?cEVWOFNOSmowMm53NXZBcFVFVWNBc0NOd09UTTNrdlYvblh6VEtoOW4zZ1VZ?= =?utf-8?B?ZFN2dHo5NEZRZWZDTmF4ODQvOHhTR0J0TVZjcHZ0N3QrekdicDE5UFY5Q294?= =?utf-8?B?d0FjcFM3UUQ0M2s2TjR2VlFhY2YwcVZXOXdNQUJTUk1WYlo0UFR0dWx6alFq?= =?utf-8?B?MVBveWFtNDdOOVROay9FaEpnR2R6NTUxemhyUlVjK09xWHR4U3dXOGYzeS9W?= =?utf-8?B?Mml0NlZPbzZvVGtVWWUyZGNLNTZCT2k4YjFxeFdHbXllTVZLWm5XV1drNTUz?= =?utf-8?B?UHJWeEJLUmY4TGhTY2tWaVNiQXVzVytZakErc3djRndzSUVKUmVMUHhTYzB6?= =?utf-8?B?Z3padzR4R3R1NTFscElyWlpkVEpXUWc5RExHbDhHelZPZzVTSWhaR0F0NUZu?= =?utf-8?B?c3pNMjVrWXZuSnRydVN1L2p1Y3FROGpXeVRiNjMyRkU1Ym5PVitxTzE0WTFS?= =?utf-8?B?bjZ4blZCdUN0d2tSbnBuUy9tcDdIU2E1dFN0SGp0TlErVDFHNy9nb0ZCZUti?= =?utf-8?B?UlRwVkEwOVFwNHBQTmYrVC9DSVZDdGs3SndIYjM1MXZGQkZxWjFtbGl4ZkFy?= =?utf-8?B?c0VycXZGbitiRHRoc1ZlZkhZSDcrak13aTk2K0lIeGhZZEIwcUYrdGM0STBN?= =?utf-8?B?Z0d6SWp2MTFuaXJLUXI4SVBiVDhUTzJEMGNHS3J6OGd3NkRmYkR6SG9UdEJT?= =?utf-8?B?VFF3MmJIWkxLQ0pVdUtCaTRvaVpkWjduNUwrK1hpRkRic3p6VGNYcnNQOXNP?= =?utf-8?B?RnAwZW04WGNnSC9NR2NNZ0dKVlpWZkx3c2kvYSs5cTdOeGpza01pM0lWTkpn?= =?utf-8?B?Y0tVUGZXODFNRDRJMTAvK2NHQTBOS2dqYzNFbnBRb1VLMXNrTWRWNjdzL25w?= =?utf-8?B?U2NUVVh1Y1BCRW1TbjBtZE5zUDJoMEhicGhXRllaYTdrSFg0T1FUY3lqVlR3?= =?utf-8?B?WFZwZ2d3WWJGQnZUR2Z6TGg3aE5GQVI3RmZnc0FLVzdEUTRTTjdIV2pOL1d2?= =?utf-8?B?YmFSSjNtZTRVY204TnFIaWVNdmZqczA4amJQZjYyM3p3MWxPTERlNi9ROWZE?= =?utf-8?B?ZE4zU0hNRnBSM3FuYno5YjdaaHdDUXJ3bmJoRDV5SitmU0I5V0JBQ3ZJUGR1?= =?utf-8?B?T2wvdCs0SW5lSVB0QlRQaVUrbndsdlNrQ2tQVGRtakI2RDJQQzJtZC84M0Ur?= =?utf-8?B?RGdrVU1UeTdzWDZEVGZZbG5jU1NqOHZSeVY2aEl3cjNyTGQ0RVk0aFVkZ2Rl?= =?utf-8?B?eWZ3cG0yU2JUNmtaWW02VXFmL2dRbTh4cGZ4Uk9nMWdxOENjdk5xcllGY21Q?= =?utf-8?B?cFlITXgvNzVVaWdlYndFOGwvQjI5aG1tUWovRTJRSmx4VHAxYmx3eG9EWTdV?= =?utf-8?B?b29hWHg5UVdmTXJ2ZExZZ0dTUjJrSlBmc2twYTJwV2R4dzlPb0Y4eENGMTlW?= =?utf-8?B?dXpML1FyTVI0YUVFNzNRTWFPRUtheEhpQThuSGJCUHQzaEcxM2lUb1B6eURL?= =?utf-8?B?UG5VdzJFVGNnNTJUY3VYRkZ5aDEvaXg1eWxGUnl1OFRvMVZGYllNR2c1ek5T?= =?utf-8?B?ZGl3QTlJNzF6dXNEMnZNcVBWU25mamhIYW5kTEVCdXRNVkNEWmVyVmY0UGZ5?= =?utf-8?B?QVU0M1I3RzhmL1B5SzhDaXNsTVh2NlZNTVlXK1Jqb25ETURia0RVNWNlSUs2?= =?utf-8?B?ak5kRUEzbmdEQytidDROTEtJYmJPTVM0TmhZVGt0a1RWTGN3TW03bFV5eFA4?= =?utf-8?B?YzRPUFVmTFcyU3pLbGJnMnpsbDE3SHpQL1A1VEVpUWhOQ2RpSXBhbWhYbmVP?= =?utf-8?B?OTlBZExhNVpvaXNPVk5kN1FDUlNZTGZwY0trTFIxUHM1MUZtVTNPRmx6dEZ6?= =?utf-8?B?NVRlT0pzYTJ0cTNFOW5COTJEcTI1Rk1KTGd3endYM0V0T3NuZ3NTSzR5SVpK?= =?utf-8?Q?DH73W2IHPDXuTs8pq2hveGlPQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7b418bc-d9f1-4c9a-8582-08dad2177803 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 14:39:06.7642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c5MblNbD/nWZPtyH2TEI3b8Werl/J/axf5rrXh9iIoCqjF0DN/0O5AAEwDpJ2JlyespXQeUKm5Ad35gLYiPzdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8864 While not as inefficient as it would be on x86 (due to suitable constant loading and register pair storing instructions being available to fill some of the fields), having the compiler construct an array of constants on the stack still looks odd to me. Signed-off-by: Jan Beulich --- Actual space savings could be had if further converting the field types to e.g. unsigned char (all of the values fit in that type). --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -2281,12 +2281,12 @@ void __init setup_virt_paging(void) val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ val |= VTCR_SL0(0x1); /* P2M starts at first level */ #else /* CONFIG_ARM_64 */ - const struct { + static const struct { unsigned int pabits; /* Physical Address Size */ unsigned int t0sz; /* Desired T0SZ, minimum in comment */ unsigned int root_order; /* Page order of the root of the p2m */ unsigned int sl0; /* Desired SL0, maximum in comment */ - } pa_range_info[] = { + } pa_range_info[] __initconst = { /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table D5-6 */ /* PA size, t0sz(min), root-order, sl0(max) */ [0] = { 32, 32/*32*/, 0, 1 }, From xen-devel-bounces@lists.xenproject.org Tue Nov 29 14:40:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:40:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449429.706148 (Exim 4.92) (envelope-from ) id 1p01mg-0005Nw-9G; Tue, 29 Nov 2022 14:40:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449429.706148; Tue, 29 Nov 2022 14:40:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01mg-0005Np-66; Tue, 29 Nov 2022 14:40:30 +0000 Received: by outflank-mailman (input) for mailman id 449429; Tue, 29 Nov 2022 14:40:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01me-0005M4-Q4 for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:40:28 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2045.outbound.protection.outlook.com [40.107.7.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c3e07841-6ff3-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 15:40:27 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6803.eurprd04.prod.outlook.com (2603:10a6:208:187::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 29 Nov 2022 14:39:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 14:39:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3e07841-6ff3-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SiQcVvRSDxqo9ugkci0oD/o+iiOkZg6N9kAzZ/mhsN+9CapGpBFVXu38mtU3SR/NYT+ndm+QGCG5JLdCzsFiFUN5wk2nwkr6Z5uD+mbo6SaPfq2x1Ed/rA1lMylfR9WCr4X+VDYlxBE4AGycX1blvS8LC/dnXjl6zgSiTu9x6hWOZws9ydmyWD1/uCKem4aZXGGipZ+hNyElbSrUClXAL25Ix5viLviFm8kClWQv51SUpPrdjK05goz1kmMZlePBXSOVmTwYiXBy7P02u5NqXZTdxL10F+U9NeZ1Pvn7DSAByf66nX8W4YtTmijihhoZRsswjA1wGrhF+7daCBajAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yvAci0YWhtZSwDYtSxfg7I4sW/keT/nE9BZRusa5KkU=; b=njUcrXm5hq0TqWitTwzJrNAC2L8pImbCCQhoNIr51nilBXz24nTA2hWue301LvvDcHj01NUOwj0jvI30Q950JlPIqkslmBGQaAP0py6/XeDu30A5yM2AtQ/Csb5YDcGex468TQsVQfJx4/VZEx95mbQrUq3xLiojVzUunhCfuZau+R+oLT72OJ4vxzjLKya5GjayqutQSO10fo9gSKt0UJUNTIn6kcdA3Ei4lh5RQXNPkMDtRut4So0rE0aLL3N41UhyX6bVMUgOpiEf2yTyo3ueTvw9gB9WhpBQlC7LIG7PPeTtvx8S6ZNpVtYyn1ihPs+mEaX8TtgVFTzWnp6sgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yvAci0YWhtZSwDYtSxfg7I4sW/keT/nE9BZRusa5KkU=; b=bvCWAYQ/1CTiTMfbdkGML0dBrJ6AKKmPCi4Sm3xAdquOiVDi6UEt1+7A38g8vmuOT0jKhN+PyZF2hRMWZ/SXu0jZw9BKgLI6bhPJ3kO7HrPvauqS/dcc5KPsezm+C1u/y9asBvKyCojAD146XvHDEtcYRksIbwyJWnceVwwMkV4LMW/GYq70uvpeNY/bGue9P7oA392Ml/ouvPsqKMz0/PAwBN7ne2tHK/lDyp/0zuJEri5DhvyzJI7qU71+Wl7IO8AY78rKBBERHX12K9bH9iaEQaA9XsEAT3pDSxhgLKpoxkOAsuiMBEfcLMBegrPPfgPhVW+OzrhY3piXLXxxTg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 29 Nov 2022 15:39:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis From: Jan Beulich Subject: [PATCH] Arm/P2M: reduce locking in p2m_{alloc,free}_page() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6803:EE_ X-MS-Office365-Filtering-Correlation-Id: 4073ba79-99a2-467a-362d-08dad21796e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: goXt26xbGLZ/APML71CZpAb87Yylv8gGMnVXX2vYDgK7EmSHOCxVnSNrHUx/1aQLBBvl6Qg3lNCpNqd0OsRG0mSgre7cxY81BudG2QIbc9vnJu+p9LfKCKi/1GfkmTeQQWwBvENDVfAA11ZyMusX4ncMZ6lSOnOIOdnJ0kOK31KB13YoNMgZyNj4b+CnGhlCoXiWYVZMmqmhf3bmQDD7ZUG6MuFKcb8R/QRQ2gtgNeg/y9x5452qUbN4+EclizEfHFYGxnUG86tSpEUsEqQE6jTQqHDIhzA0RzzgOLsXeeYoVIu7j8tbIQ0MFSEULNwz58jBwEZpcS8lmAVS1ZAim6pukLOBAQ6QQBtpEJPSmfZhuB+kRl2ieUfkSZ6R4Cwv5+nhNMtWPzOnyZ3ZW4lk/GNX+J+AzXoVTmiFy04mmQqdzLDrDs/LMsuhhpHxWTOp42BlW8fpsSYS6dsOgLtXVmvW9Vf/3zmCQWdgJ90R2ESoHO8WWMw7nlr0xXVkyCi6ThMDvvftKRiBolMKtCtJ39anLTMSUTJPDxS2uP35luIMLepPqhghceBLBhN9DiwccltRUT+91aTNUAcDD3BNoCCwXdgbXVQZa6SxS+WDofPfTwghhSb2H9dJbD577qRQ2GvqqWwTmAlx1myVjII/TdkT1f1oj6FKQeNxwEJ8yycjKbFZXE9Mh+8r+KwtV2/ZITnDnpCbehDJ6Fqp6Mu9XzpC2BtS09kyOfSeHRoTNME= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(346002)(39860400002)(136003)(376002)(451199015)(6486002)(6506007)(31696002)(83380400001)(86362001)(478600001)(31686004)(26005)(316002)(6916009)(6512007)(54906003)(41300700001)(2616005)(5660300002)(38100700002)(2906002)(8936002)(4326008)(66946007)(36756003)(66476007)(186003)(66556008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWkycnFKaWlzbUNRWTVCeWUwR1hrMEVDL2FPOWtiR2lCdEZJd0VmUkY2S3M0?= =?utf-8?B?Qk51dFptVitacnJGUlgvYWR0SzB3TE9WYmRjNFZuelJlTUxLRytVbzZlS0VC?= =?utf-8?B?QnpodzBoMXI2ZlkvMmJoQVFxdTdEZHIvSmp1QVdJTCtvL3hRLzRwc3huTm1N?= =?utf-8?B?Tm1uWnhLeEJILzM0d0pnMkJpU2g2YzNLZXpYSENYTmFEWDNmVGQza2dEdlMy?= =?utf-8?B?c1hFRlR6Zjd3dEVCb0xLNDg3R1A2M0Q5eGRHbUpSa0JrV3o3Z3QzZ2tPWFB2?= =?utf-8?B?dG4reGkzRWxFcDVtMlkrNlRWWXBvM3FsYnpwSU5LbXExRmZna3JjckZJYjdl?= =?utf-8?B?bWZBaStFRkJ0aWpvVTI3eTh0dThGUjdzSGYrTXBMZlZtZ09ScFB6V3pjdEdH?= =?utf-8?B?SmQxL3U5S3lPTEVnY24zTThYVGJpd0lVZG00QWlhMmJjWElwVCtBMUxTS05x?= =?utf-8?B?ZkZxc09yNGRnbkR5c2RpWlNibS9LQnFpeG16Z0krLzNDOVpKSmprcUNqSUhw?= =?utf-8?B?Z3VaM3JCaEdwelhIbzUxbjBURzNXV1gvS0h5VEVnbzhJek5CWldtcTcwTTZ3?= =?utf-8?B?R2VUUVBOejBMK2JNS3JmMjVlNDVoTGJRQksrWVNaRmdTakxlQmdrK0lZMnpX?= =?utf-8?B?cjdSMG9neWJ5THpBNEFTRk5kbXh4OWZOY3hybEtsc0wzMEpyek5odFB3S2VU?= =?utf-8?B?R2ZvbEx5Tzl2MDk3QVJVandnWDBSMCtjdStNRWprTW13ODB5dnoyekhOQUlt?= =?utf-8?B?QU1DOTRIclNydGVTR3BybnZuRlFqS1lFRHEvZHc2NVRRS2ppb0ZndG1QZ2w5?= =?utf-8?B?bnJGNlE3QVdtV29qN1FXR0w0ZkFHRlpzVExWb1k0bFE3eEFqRGIxU2dXdGJC?= =?utf-8?B?ZWxiRkJXYys1VFVCcVI2OHpkUWZLZTl0ZlZUUDE4RXIzT1Nnb1ZsRjNPdEc1?= =?utf-8?B?T0h4a2xBMk1tRXE0cHIxUEtpaDdFVXBZZXYxbVhTWUUxVE1mK0g4MmF1UEZ0?= =?utf-8?B?SVdjQ1FiUS9zc240eFVhbWxaZTZpeVR4L0ZhSGdWdDFjY2FZRTZLQnNJdk50?= =?utf-8?B?Y3ErZU1yL2JQczUzZlRGWk9vbnhtVE1Fa2ZFSTQvbGh0TUV4QnJpZkZwQ0ZO?= =?utf-8?B?K0k1UGRzQ0wyZTNMSjBuMGVTWC9nM1MzbE1WQ0xsN1IwZXYwRU9BQi9sdnFl?= =?utf-8?B?WE8rSjQvUy9XRytPaTUxeGYxb1ByYTAySEVmalhOcFhzRUgzQXNNQnhFdnZC?= =?utf-8?B?S0lWY2ZLRVJ3TEQ2K1NaZ1ZjSUt3QmxUQ0J2TTdQaXkzQWEwRFNtMUpCVUlG?= =?utf-8?B?aWtJQUNvZEF0c0F4eitybDVGdGxMWnNybjEvaVVVRlhsemFwR01vdC9relI0?= =?utf-8?B?SGVtWDFXSlFRdHk4WGRXbGJYRi9zM2hsTGVJUmI1U0FrdzV2U3hxYlI1Zllp?= =?utf-8?B?TitTdHVKUSt4RGowSjFCd1QvTjZSS3RWS1pmRDVwNVp1YU13TzlGVDRTZU1o?= =?utf-8?B?Nk5mNjNYNVROT28wZUJ3UXNCZWdRWDh0VlM3NGVWelRXUkYxTXVXK0FvWkVu?= =?utf-8?B?WmplSWFkK1F5alNXaG9tMjN2MXlOK0EyU1BhWkhuc2x3dTBmTTFXSFFIZ20z?= =?utf-8?B?K1AwVFNWTmdVSjlwK0dhTnA5c200QjJxb0FCZTZJbjY4Y2djNzdiWjhuTlVY?= =?utf-8?B?b0dnSkZzc05lMXBCMnZ6OXg1dDVWbmlGc1VuRktMZnp1V09tRm9lUWhNcTJo?= =?utf-8?B?RXQ4Z3lEWEtrTjM1b052MkNPbGl5RTd1VjdjYVNXTVNXRDdzVXQ0QWpUeUdB?= =?utf-8?B?NlBkN1lYQXlmV2pITjFZS2M0THZnU2ZnR2pTMHlsZUdzbmY2RXZKTG5FN0tQ?= =?utf-8?B?Q2JZTytDMkp4SzJSbDVpQ0Y0U2sxeUJXbzVnT1VJYU00cUpaQ2dtWlRTbnR1?= =?utf-8?B?QjRjQU8vbDZ0Yy9DVldDQnBHSlB3ZWdTQ0tGNHpCdHo2SGFjcWpKZWQ2RDN5?= =?utf-8?B?bDF2WURIbXg2SXVqbEJsWTR1K1pJbjdERktIUTQ5YXNpTGlOVmNZeHNxdEhx?= =?utf-8?B?UTdWUTV6TFJEU1pEZUR2QWpLUmpzWkxJWGxURDdsUDl5ZVBMdWlYeGdQb1RI?= =?utf-8?Q?tXeZ8zkNl31ski8ZEY8r1kwbM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4073ba79-99a2-467a-362d-08dad21796e0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 14:39:58.4797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kssug4apavp/EdaZACuymJg9iE+PaRCA4tekR6p0hm6dPwIe5jcDIZIClBUh05kOgRuU2kdsY/TR5G/3k0jl1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6803 It is generally preferable to not hold locks around allocation functions. And indeed in the hwdom case there's no point at all to hold the paging lock. Reduce the locked regions to the non-hwdom case, while at the same time arranging for p2m_alloc_page() to have just a single return point. Signed-off-by: Jan Beulich --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -48,7 +48,6 @@ static struct page_info *p2m_alloc_page( { struct page_info *pg; - spin_lock(&d->arch.paging.lock); /* * For hardware domain, there should be no limit in the number of pages that * can be allocated, so that the kernel may take advantage of the extended @@ -58,34 +57,28 @@ static struct page_info *p2m_alloc_page( { pg = alloc_domheap_page(NULL, 0); if ( pg == NULL ) - { printk(XENLOG_G_ERR "Failed to allocate P2M pages for hwdom.\n"); - spin_unlock(&d->arch.paging.lock); - return NULL; - } } else { + spin_lock(&d->arch.paging.lock); pg = page_list_remove_head(&d->arch.paging.p2m_freelist); - if ( unlikely(!pg) ) - { - spin_unlock(&d->arch.paging.lock); - return NULL; - } + spin_unlock(&d->arch.paging.lock); } - spin_unlock(&d->arch.paging.lock); return pg; } static void p2m_free_page(struct domain *d, struct page_info *pg) { - spin_lock(&d->arch.paging.lock); if ( is_hardware_domain(d) ) free_domheap_page(pg); else + { + spin_lock(&d->arch.paging.lock); page_list_add_tail(pg, &d->arch.paging.p2m_freelist); - spin_unlock(&d->arch.paging.lock); + spin_unlock(&d->arch.paging.lock); + } } /* Return the size of the pool, in bytes. */ From xen-devel-bounces@lists.xenproject.org Tue Nov 29 14:47:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:47:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449436.706159 (Exim 4.92) (envelope-from ) id 1p01t2-00068T-2z; Tue, 29 Nov 2022 14:47:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449436.706159; Tue, 29 Nov 2022 14:47:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01t1-00068M-WF; Tue, 29 Nov 2022 14:47:04 +0000 Received: by outflank-mailman (input) for mailman id 449436; Tue, 29 Nov 2022 14:47:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01t1-00068G-6m for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:47:03 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2079.outbound.protection.outlook.com [40.107.7.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aed82873-6ff4-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 15:47:01 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9488.eurprd04.prod.outlook.com (2603:10a6:102:2af::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 14:46:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 14:46:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aed82873-6ff4-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BKj35mhKFKOpZErM/DWLt14BcvquE6CqfMWApGnjSAvEvEbGGKpBeHdzhDNqVjv6YGIs6jiDb7XkyAoNA6tBS3wdMKaPRobcz2IAI4nvjw/8OXetfoIrkc2JAYgAJeVOwDyQRkCVH+HB09qzBpNEr/00yegvll27aqOsLk21jxiz1bubl2UHtZicon9tT5EIUq7NTZAb3zH3TmfyiiPI0El+rdb317sNIdSKpxpapJHpZ7cR4l+Fuim87f4+nPsVP9VpHVlyY0lSpPUoWFpQ+9rlhJ6O8jJichp6MRZ3TpMn+PKlsa+mxsbx5s/t+bKQ+adsOXQtxD82ArNgJIV20Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nkwFHbC0MWN5CvPtGpC2i6/DPJmntDCL5dGfW1ggJPE=; b=Fs/BrAeO6NyQjclIaJdzTgCmiFAVmEfYa3CCKpowpkoD7AT9gEUBj7a1mFqZfo2aogYS4Siwj1BH4eg4rEtSw1L7kskA/yKngeVkUbU1ayHNs/uDo+F+9valbdFU6W2Cx8IYdU25/j8nwRKXDcvPY1xHbr4d05jyhym2qxEIOy+AumpBOGeQ3ihS5UepPseGcmlGTZGz2QYY/WsDx/hS6uHSMYVFTA5HQxeVlIdhgRGVAno+rJIBRPR1DqL3EA0zzGlfqMck/eKOGV9hIwRZu28IUVuKlOCv23PK3zY33Av9k278Ao6QyFv9JlI89gVYaNuCEmo4klnwWZq7ihtGXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nkwFHbC0MWN5CvPtGpC2i6/DPJmntDCL5dGfW1ggJPE=; b=xBFpDIdqzhS9++NH2iC9t6vBJP76pIIqOk+UE18Ktqfxp2ch6ZjIEZw18O9m3eZZbG52TUQ3nNur3qSzuAS0LbsFVlEdypD8x82+gsDDEYcXdU9P9R2L9Lw8CuqtKwyEn3jHI+hou34e8glk/w/viSQbiM/mDfzGdyLbYNFe6zMKaQmGcZ3IwJXllkHnk1b1QPD4eLlqxaogc5YupFZq9LZdvFbZFitxUO4HIHI7IJwdkf5gpvwWDVhrbOvatapMmk/ht8QfbbaZ35LNiHHjWQ/FQlxA3OI895sM/pjBgH+IRy0I6Lqx/9xTK82OWtHHBcnUhKKLOc5tpyWm/4v0HA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <54ee1bd7-9b6a-efc7-8bad-50aa7d6d955b@suse.com> Date: Tue, 29 Nov 2022 15:46:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/APIC: make a few interrupt handler functions static Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0020.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9488:EE_ X-MS-Office365-Filtering-Correlation-Id: 288d22b6-8ced-49c6-df35-08dad21881ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NQ9OdSDjr7lx85f1Zl5mivIrB8gtrc/zdf623jw0knRnUGjPiVfnpZ/8toxjEwc3MtQdjwqgvj4AivMGMuqOfgZXih8J6SzxCPj+aaw2kFzHwS+gm1NRF7IxeojAvZlyp4bSgtZJ6h0pD22nuatONxX0zgS4mejMgtvtAlg4jgrh49f+8IbQIhreaxDEjvyWluLt15geVY+kPwmBybLqCuzy5NfOuTd46jVdfwWrLaFa03LIpz03oqSwcpXiEe3f+iwzuuCO2xNxfkarxXPALxPxDfYI676/UKogtxRgZDOywMqc/YF4ds3IxzoBaCohSCIbjyskcrw/u8DcRzOg4eEU3wfZJhH4GsuCdWrUvxNjhuU1y0HfC4dh429lDI0Ii2xIVfY/iqBJDPQBcELDn0wGiCtrK0KjTyoCAJHObLxiV5C9LTZvJYFIbMLqZMQNrJVDSFcPCYtVgj6Ywxi4MzNWt+b0neTeZhpE2PIazNaK4yfzh261FEYF06RZLwiI+XDpe4atAFC/8y+J40CYvj7ytnA9yi5EPWk3tsPNm1WFrd6NpREAvq5ErNCU9YfS3zc8e2soSX88HQPGoUAqSTe2UJLjqcazKXWxWk348D2znGkP/4R4cae3n4n0TJ9o9KMMVrCTYhwJAzXwqpKM6eoSz5GvqSYKHzKJmW3sYkr6mDuLh+9arQO0IB2xFwRT7uOqGl61z8W5Ou5V1ychfIfWbAcJQxxa7NtxiBkPHaU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(396003)(39860400002)(376002)(346002)(451199015)(478600001)(31696002)(6486002)(6506007)(31686004)(6512007)(4326008)(36756003)(66476007)(66556008)(8676002)(41300700001)(186003)(2616005)(5660300002)(8936002)(26005)(316002)(6916009)(54906003)(83380400001)(2906002)(86362001)(66946007)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3dKTXFlbkZYeUZUYlZmWWZBbTJMa0t6U0Y0T2xDUEd1ckk4NVlYdkQ5WkRE?= =?utf-8?B?L2sya2Z0bXJxZFpJcVQraHRxWEtUVjJhNHozS01VYVNXbHhSbW04MEU1MEZz?= =?utf-8?B?TjF3OW9ZRzAzYUFLTWQ2MTUvZlpKNDBwTW0rL251NFdNTEhYbkgyTnR4RHJB?= =?utf-8?B?UzRsQWUraXNIdkUzT1FocnNiMGMveTE5T0MzeTlBOFRLUFAyalBjWW9YOTdw?= =?utf-8?B?aVNwck1GR3pwY25qVW4xazFacXk3SlQxT2hhN2IxR2FEYnlLKzZhZVhyVEs0?= =?utf-8?B?RUZ5Mkhub1ZYVkllYWZjTzZaZDVTQXlSUnRzMGF1QVZIcDgvRzN4RXNZNnJY?= =?utf-8?B?NGM4aTVQZHY0bzBCNHNhRExSRTI1RVJZZm16ZjVwdXlJM1ZOcnBpSkIxYlhC?= =?utf-8?B?NWVrMHNSSU42aUlPaG52WEFZWTgyd3lTQXd1WEovNldDYVpwczNCbFhpUUJ2?= =?utf-8?B?cWptaTk5eXRpS1IyNVFFb1BYUVh1WWhPaW0wRTQvUG5QRzVOSlBWU1BTei9Z?= =?utf-8?B?UjBhZCtjaFkrb0dJc2ZuTGFyenQ5YXVBeFN3c0x3WHp2UnkyZnlKTXR3S3pQ?= =?utf-8?B?N3dLZ2NSVGlDMXNyVFBndGplb3V0Y05aRmVmK0Q1aGNlb0Fac1E5ZGROUHla?= =?utf-8?B?dXEyL3dZOVVacTE4QmNTNkVwYnFSVlI1RlVIbkkyNHZCWjM3VjU0a0YrbFla?= =?utf-8?B?Y1AvMS92dWlPbm9XUXJwMldsblFVSjAzdzhQdVgwbEIvK2xFeFhUYzdlMk9y?= =?utf-8?B?b2ExaWRYM3BOcnNCaktTQnRCSHZnYThTcGdJdWcremZTbGh5cnZYSjRMOTU3?= =?utf-8?B?em5OM3dCUzU4UXNHL3h4R0k1SDlrZFpWdVBjUWFPeDFHZS9DTGs0Q0tIenNT?= =?utf-8?B?TVhIbWM5K1JvbXFKT2s5OTdDU1J4aSs5NlhyU0UrNURsd1pMY3ROSllzVEgx?= =?utf-8?B?bzlhRzMxMkpFTWR2M1dHR3NWNkVSeDJDMjJvZVZrV2ZBWlBubGhKS202WHJ0?= =?utf-8?B?blNZalBjMnpZZWErMkYzL1U1U1V1Y3pHVXFCQWVKejlveDRWM3RIc3BYS0FR?= =?utf-8?B?M3lXRGNYZ1RNMVUzMStDbHNlM3MvcVl2N0ZiOUpGRlNKSnUwbU5IS0trMFJS?= =?utf-8?B?R2c1dWE4NWVZNGxPeFBtSG00eFVBbm9nZk1XbURrVmUyQkptdlp3SStzNHoy?= =?utf-8?B?U21GSnlXZVd3MVo2dFNpd3QydW8yYVNNbnZFMDJOWFpzMkFoMGpkdzVTTGJk?= =?utf-8?B?VjBkUTVFYnFvbFNMVVJvRlZoY2F5MnBzUUR3SE1rUEpKbXF5RWJvUVkrQjVs?= =?utf-8?B?YllIU0dvbG4vRzdnbHZ1MkFRS2F6SXlscUpJSy9tVmZQdGxXWWFRWitza0V5?= =?utf-8?B?dlZHQmdWZndpQTcyTnJkRUZKNjZES1hyNyt5MCtkQ3lTcHVSY3ZYaC9uMG4v?= =?utf-8?B?MzB1NVBGYXZ0YkgxUlhYWkJJMXFIQVd0d1VEU2JWWENVeCttYzdhNDdsU0JP?= =?utf-8?B?ZTJOUVpCajZwR2dXTUdiT2NyZjBDaFdac2RkMEIzaFlCSFZmdHliRFFjNk9Y?= =?utf-8?B?WFJSalB6N3hoTjBnT01DOE96dUxuSVRoWGZLQnVZWmIzSC9sS2tVRVJMTnVj?= =?utf-8?B?NlVYZkUvOE1XREp3SnFuQVVOaEVXeVpYMEVzQWlvUXV1NTNZQ3NTempHWFl2?= =?utf-8?B?anl1b3Rkdko3R1RDODFQeW9ra3hEbHk5RVF0T1QxV2RzcFQzc3AvWEUxN1NK?= =?utf-8?B?RHdjWTcxSjNZMC9pdVlBSmxOMWs3MGt1TUVKbWVrWGt0eFcwMUtrUTJsVFZh?= =?utf-8?B?cG84NHRiN1hJS0dsNnpCcUhKaVk5QjJYZDZHTm9iVSt6ZE1wanhiaW1Lc1hG?= =?utf-8?B?eWdjY29NTVk2RTNqOHVYVmNlUnBFUjRXR3VYZjdNcmtRM0xhbW1waXJ0Z3pj?= =?utf-8?B?UFRUYk1vbkxQVktNeXlwV0I4RVkrT2hSZ2FmRkZJSXd6cFpBQlp3Zk41TUtZ?= =?utf-8?B?ZTF5RGxvT3VJbUFRM3BjdXBMcDhsa2VaQ2NLaC85ODRDSndnTzZ4bllYS2ZI?= =?utf-8?B?TVVGM1JjcktDdlc2WFdLZDlpMEcyaE96enRoemFWMVplT29iUGhMTlk4L1hY?= =?utf-8?Q?vI4RYxfpW9ZnXAr+rKXSMzaJ8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 288d22b6-8ced-49c6-df35-08dad21881ac X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 14:46:32.4234 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y7JByF+8Pk5nRO+8lDFD0s6fPRwf4zbUPrC6S4FPv3wRFwC4J49kKknm/BP7wbzhTCgvR4glW9KpR69pXWlH3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9488 Four of them are used in apic.c only and hence better wouldn't be exposed to other CUs. To avoid the need for forward declarations, move apic_intr_init() past the four handlers. Signed-off-by: Jan Beulich --- a/xen/arch/x86/apic.c +++ b/xen/arch/x86/apic.c @@ -127,21 +127,6 @@ void ack_bad_irq(unsigned int irq) ack_APIC_irq(); } -void __init apic_intr_init(void) -{ - smp_intr_init(); - - /* self generated IPI for local APIC timer */ - set_direct_apic_vector(LOCAL_TIMER_VECTOR, apic_timer_interrupt); - - /* IPI vectors for APIC spurious and error interrupts */ - set_direct_apic_vector(SPURIOUS_APIC_VECTOR, spurious_interrupt); - set_direct_apic_vector(ERROR_APIC_VECTOR, error_interrupt); - - /* Performance Counters Interrupt */ - set_direct_apic_vector(PMU_APIC_VECTOR, pmu_apic_interrupt); -} - /* Using APIC to generate smp_local_timer_interrupt? */ static bool __read_mostly using_apic_timer; @@ -1363,7 +1348,7 @@ int reprogram_timer(s_time_t timeout) return apic_tmict || !timeout; } -void cf_check apic_timer_interrupt(struct cpu_user_regs *regs) +static void cf_check apic_timer_interrupt(struct cpu_user_regs *regs) { ack_APIC_irq(); perfc_incr(apic_timer); @@ -1382,7 +1367,7 @@ void smp_send_state_dump(unsigned int cp /* * Spurious interrupts should _never_ happen with our APIC/SMP architecture. */ -void cf_check spurious_interrupt(struct cpu_user_regs *regs) +static void cf_check spurious_interrupt(struct cpu_user_regs *regs) { /* * Check if this is a vectored interrupt (most likely, as this is probably @@ -1413,7 +1398,7 @@ void cf_check spurious_interrupt(struct * This interrupt should never happen with our APIC/SMP architecture */ -void cf_check error_interrupt(struct cpu_user_regs *regs) +static void cf_check error_interrupt(struct cpu_user_regs *regs) { static const char *const esr_fields[] = { "Send CS error", @@ -1446,12 +1431,27 @@ void cf_check error_interrupt(struct cpu * This interrupt handles performance counters interrupt */ -void cf_check pmu_apic_interrupt(struct cpu_user_regs *regs) +static void cf_check pmu_apic_interrupt(struct cpu_user_regs *regs) { ack_APIC_irq(); vpmu_do_interrupt(regs); } +void __init apic_intr_init(void) +{ + smp_intr_init(); + + /* self generated IPI for local APIC timer */ + set_direct_apic_vector(LOCAL_TIMER_VECTOR, apic_timer_interrupt); + + /* IPI vectors for APIC spurious and error interrupts */ + set_direct_apic_vector(SPURIOUS_APIC_VECTOR, spurious_interrupt); + set_direct_apic_vector(ERROR_APIC_VECTOR, error_interrupt); + + /* Performance Counters Interrupt */ + set_direct_apic_vector(PMU_APIC_VECTOR, pmu_apic_interrupt); +} + /* * This initializes the IO-APIC and APIC hardware if this is * a UP kernel. --- a/xen/arch/x86/include/asm/irq.h +++ b/xen/arch/x86/include/asm/irq.h @@ -96,10 +96,6 @@ static inline struct cpu_user_regs *set_ void cf_check event_check_interrupt(struct cpu_user_regs *regs); void cf_check invalidate_interrupt(struct cpu_user_regs *regs); void cf_check call_function_interrupt(struct cpu_user_regs *regs); -void cf_check apic_timer_interrupt(struct cpu_user_regs *regs); -void cf_check error_interrupt(struct cpu_user_regs *regs); -void cf_check pmu_apic_interrupt(struct cpu_user_regs *regs); -void cf_check spurious_interrupt(struct cpu_user_regs *regs); void cf_check irq_move_cleanup_interrupt(struct cpu_user_regs *regs); uint8_t alloc_hipriority_vector(void); From xen-devel-bounces@lists.xenproject.org Tue Nov 29 14:48:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:48:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449440.706169 (Exim 4.92) (envelope-from ) id 1p01tv-0006ew-CB; Tue, 29 Nov 2022 14:47:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449440.706169; Tue, 29 Nov 2022 14:47:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01tv-0006ep-9V; Tue, 29 Nov 2022 14:47:59 +0000 Received: by outflank-mailman (input) for mailman id 449440; Tue, 29 Nov 2022 14:47:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01tu-0006eh-3y for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:47:58 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20630.outbound.protection.outlook.com [2a01:111:f400:fe16::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cfa5837d-6ff4-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 15:47:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8126.eurprd04.prod.outlook.com (2603:10a6:102:1bc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.21; Tue, 29 Nov 2022 14:47:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 14:47:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfa5837d-6ff4-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fIqrW4ZHeuIWC0JSmzcIFJRTCyzMpG0aOjQ6FnGmCx0PHAEurUqwO4DZPhNyDk+SNz9uRiitoMPbTLqd+t28xQ4Zq4V94vlgKX5r6AGfXurQQbuYXj2D+CvcOfTlPGPIJItStmPv0ZUZgHZkFKg3dsnoNO9M+hxQyhc3wqgFIgzvI6Reye5LJsplIyI1WRlT/WuR2+UGMIsap7PVvUStuT4tR9+HBgclZN/4jldp3K/th6jn4QXIFpaSAnUldz0Qh45bqBZVKjOdU/TMEi86f7xXsE50WMNONfV9usEExJptMC+SRTQZJ8bSkKCeLau2uVQvQY/UQqw/b8kPn63Gew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KXqcNSjY1JBioDkQ9SEAT1phAWhY/M3WTiUf0zQqqQ8=; b=XenCGMvoxrUu9mgF2USc0TfNQuutCnIcCg9w5EHt4q0HLlSRLXVkZLE9vsPwHWoLrItjtDCyNqgLUZqnYsRMIrITE23DNv+WigJVfVVT9DqyKKO5e2JhWQreZ07zxcnNYG+EMdBspYJlFG1AZu/mlKKQbF1XrWbQk7soc24EflSXaFngj7RruBfQ6cvQL/3I93Kf6+5shFjemLRhmex9hYq3wr4RNCidq6t3zBbaBpdob4qCciiYDirx5WoH5rtEye/uKla99a9AEjZ/MfQa6Sdr5TQgQIf0q9oULqbxobpcTeZ18Jacx3Ag+2YlWxKcSEJrCz8LqVgSNz7pGGY1nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KXqcNSjY1JBioDkQ9SEAT1phAWhY/M3WTiUf0zQqqQ8=; b=PGxrinrF+6zddszchVRtRkr06YOMp/lsoMKD1TslAmfyJET2fFSk1G0BMawQpoZsAMbCasvN29loRnMB0ETBnPpJPydRwPP9ffIvQ6GSp9/JkFZMJFWl/X3xRBsD08VG4mIcxWwHS0CJENpDCsL7Tig03TQEIr6nkY3p8j11/pswATwSnBuTNwJ6Imj9qwJMZ1R5dHubdWb9YYocX4rNh7Vs5qL2KVhsq0Hy05vEtQ6i/oeXjCeTKoeiIi0xQbglVXCUQTmmfnlfB8iu9pJFgPktLgT+orxlYicaH89H14BMTM3UTS7kipSaq0jKLwPTXLvdSOPZTSKtyWV7F5WK/g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3876e026-2a98-b74e-2f49-4bed8fc0a224@suse.com> Date: Tue, 29 Nov 2022 15:47:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap From: Jan Beulich Subject: [PATCH] x86/p2m: don't calculate page owner twice in p2m_add_page() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0128.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8126:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d970489-dbe1-4b14-1fc7-08dad218b2a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3Hf4D2vvbk6VMR9plBRN/IY91h7nKO7HYfQLRA2V90bK2ErCx+3h72TJtxECicPUdBC9HvXZTWjs48lkbeglD/GheyXuSsHZLzwT/oIS25/x2e7BlPFsg3En2jw+Su6AcRXJfElVj17X+moqUI/x1NcvetVwbu7WVrSgSQyrsMXuthYtR/t6/TP02uQ/8dnEY2RTkNE0Gj/A5n3zx2BTC9T6bXGOLx3Bn6XguvCSVWY7HgL0inarfGzpZxWhjA2EP7ayVtobyD7eVipWiYNtFFQ2WISAJNLSnfAxk8h+8fu7nEkidVPPQh5db00cIxFNAUKZAZ/raGUcLSbjsDEiEVmZDZ6RZ3EZS6mMLztS80yHjHclOG8bQ+LfW4YKYL9hEc/ALVGM4DKkN9pAQEYRyWw7XOKU0eg8Sm0cn4bveyCB/OyPtWZ/ohHrXlaEfUIAbeoE5L2GiCwXM9uOXieRrORzIgn2lp+lve7MMCSNVkKji7EsN4c5GFJIMecZt+qpw+5F0mzJdwqVRVolVNo7saiBlrl2EiPllqDOkCsZzh9N7LLoXvAvG3V89FyfCgdpFYhoJtL916kCxMUjO8i6gZUOgnHl1t5yldh+PrjMOkZc64RCr+mDR1O2x3vHBBSD0ScedP9PNb6Mm8mPrY2szs18qWsOfW3/DaljKPG4sqreJOtbf/jH2mFbmYrgBuNb0oRRqXlxeoFOMQBd0CjDm6NyCqrqliTZi2511wC7ED0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(39860400002)(366004)(136003)(376002)(451199015)(31686004)(38100700002)(66899015)(6486002)(6916009)(54906003)(478600001)(316002)(8936002)(2906002)(41300700001)(83380400001)(6512007)(26005)(2616005)(86362001)(36756003)(6506007)(66476007)(66556008)(186003)(8676002)(31696002)(5660300002)(66946007)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTNRbWp0Mms5OWwxcUNqd0kzck15cG01MVlyanhBVEpFTE9DUDdObmc5VGdD?= =?utf-8?B?SmQ4YS9FbVh1dktxVGdNeWVGbnFuaExFNVI1RThtZzlEek1mZ2IrWE1aMFpY?= =?utf-8?B?aGRyQ1hNdFN3VW9pWDR4R1FWbzlJMjhQbnNGOWNCVXhDdldoS0Z1QzNQbjMv?= =?utf-8?B?RzFIbDZUUDNFZ2NXYVhzSlNMcUNXaCtPRDI3NWpQWnhsY1Q0RUVVUm1qS2R2?= =?utf-8?B?bDJmTWVGVDIvbXpmUnRwWEs0TFI5d2ZQam13T09KN3l6QlovWS83RmtuYldl?= =?utf-8?B?R2t0dmxsVDFNNGx1SFFrRUkwL0VCUmtJMTFvNmV0NlRoUERKek9tY0ZYWHF4?= =?utf-8?B?dVVzY1VkOHhSbkE2YjF0QlBWTDFEd2dEK29iV1pXTzdTQWdGeUZIYUVjTnJZ?= =?utf-8?B?TjA2YnB1cm1CaTdyOU51RVloUklULzJuRkp5aHVSd1piemZPZjdyUWpXL3Zh?= =?utf-8?B?VDF4SGhSZTgxbVBGWVJxS0FSajdFYkNVUlBtdFNuS1hjVGYxMnB5c3ZQV3Qx?= =?utf-8?B?eW1IaEl1RUxDOVRPNWxtdWpxbXhnUUZadlhmdWpoMGxOaE5zdGZpMmZtdlR1?= =?utf-8?B?U2FuaVZnb3lOcTFoWlQ4SXI0S0VRNlA1cDhJaHNNY3IrbmcxNk9hTUQ4bHZ5?= =?utf-8?B?ZER1YnZQeENHYk5OeXZVRU54M2ZrQUE0aDlwMHVnYTVVMW05UWhmNWY2N2Ev?= =?utf-8?B?SmVOak1MeUFqWEQxMTJBZ0xKTHFMRTFNQjVBRlRCUTcwOU9SZ2NZNnA0aUJJ?= =?utf-8?B?dXUrYklFSzFvcFl5MG1abENnN2FLQm5ERjYva3dxL2tMY2JyVFRNYXcwMVpS?= =?utf-8?B?THByTVZaR3g4MmhiQUdhN2RORUJ1bVlyTmtvTjI4cVZqUlB0Q0twU21XbG9U?= =?utf-8?B?OTJ2YVdKQ1FiaENDeWpSajhQUGNlcExhMmVic3RHL09ITWFYbWJLTTA2Q2d2?= =?utf-8?B?d3hhaElUdHJDdit5cVlJc0VmZ2IzTVVBVExQUlZWTG0wN05JRllTaGU3cDNl?= =?utf-8?B?cjU0MzV2L3BUVXZKSXdQeDVDblJ6QlYxS29GVGZadnZCM0Q2S016L0MyS1Yx?= =?utf-8?B?YkRWSkVZRXFseUtOZDdEOTJod3dreHQvdTRBdlVNaWNzUjNDaDRmVlJvSnVI?= =?utf-8?B?a2RjNll0UkJLcnlJRU1vKzJoSXNFQlhFYmdMcXNJME1BaDBNemZQOWZoVi84?= =?utf-8?B?cC9icjAvUjFlWnhhREJyS2Zma0paeEFPc2s3Z1hwYlpEVVRzcUxyVWd6YStD?= =?utf-8?B?S0xnbzdQSnRyRDViR0NERmJsa2tVbEFxYlRZSjliUGtDRThnQ1ZuRm5qT2JI?= =?utf-8?B?bHY1cmxEZEZFR1lVSCtEcm42RjVaV0FiVXBoTVVteHZicENBVmd6RDV1bzVF?= =?utf-8?B?bHhIL2JVaXNRMnpsZWNCLys2ZGVhV3p2eCs0dVFKb1hGR1VQMDBFcjk1V2dy?= =?utf-8?B?M1Y3dlhVZDJuTU1rWGs5KzdJT1F6WGFUSk4rMDNVTk8wYi9JYm1VMjlvY0kw?= =?utf-8?B?ckU4Wk9lNVlET0VCeFhmR2RDejh3MzAzTWVWbXJVR25BbWNVcUpYZEZYRWxF?= =?utf-8?B?RVgxM1N2S0NzTnNIMHUvSnVaaDZLS1BKT0QvSTRzSVlGaWlUUVpyc3BHaVZq?= =?utf-8?B?K0JSOVBaUEpqQ1F4amxDR0VCZjQweUVzSTZrVDVFcy9NVEx3YVhxYW1qZW5D?= =?utf-8?B?TW1ia0tPdTdDSm8yZ0hRaExPRStVSi9UTXhRQmkzY3ZYWGs1UkwyY2IzTE5y?= =?utf-8?B?WWd4NWdISTQ4b1F0ZHRJd0ZGVVFveWV0VDY2am9GMy85WWFYaHhnQUNJSDFj?= =?utf-8?B?U1lPbjV2WjhTSU40QTF6dWJpUEZRVi9BNE02RCtIOUk4QnIvTlA4eGFBOFQ0?= =?utf-8?B?a3FaY2oxc0VNYTFQR2s4QkZZbW5Na3piMVdqSGhTbnBXZ0t4WW9VWnZlamho?= =?utf-8?B?WHJnZGJjZUhhQ2dCWTZMbkhPc3dhbXIwR0oreTdXMlhZSWZZL1BKVWNGRmRW?= =?utf-8?B?NExTL2NsdWh5cXU3d0k0WFVjUVRtcHNXNThZYTZuRkFUSCtzdHVLakdMbmli?= =?utf-8?B?bWpyS2NWRndwQi9Vb3JJU0RFSjdONURMblNEazhZS1pEODlZdi9qdWF5VWdv?= =?utf-8?Q?N4TWGPt1nW4eWjqBOzwaFv3d5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d970489-dbe1-4b14-1fc7-08dad218b2a4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 14:47:54.5901 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zr6wCxR1/ufbQeKkHMp8CS7x6KHeSett/pNUfwImapsnjSZjblipvpJPLoROYu6mEMn2XEfsi+godNkiBo7NfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8126 Neither page_get_owner() nor mfn_to_page() are entirely trivial operations - don't do the same thing twice in close succession. Instead help CSE (when MEM_SHARING=y) by introducing a local variable holding the page owner. Signed-off-by: Jan Beulich --- According to my observations gcc12 manages to CSE mfn_to_page() but not (all of) page_get_owner(). The overall savings there are, partly due to knock-on effects, 64 bytes of code. While looking there, "mfn_eq(omfn, mfn_add(mfn, i))" near the end of the same loop caught my eye: Is that really correct? Shouldn't we fail the operation if the MFN which "ogfn" was derived from doesn't match the MFN "ogfn" maps to? Excluding grant mappings here is of course okay, but that's already taken care of by the enclosing p2m_is_ram(). --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -691,8 +691,10 @@ p2m_add_page(struct domain *d, gfn_t gfn /* Then, look for m->p mappings for this range and deal with them */ for ( i = 0; i < (1UL << page_order); i++ ) { - if ( dom_cow && - page_get_owner(mfn_to_page(mfn_add(mfn, i))) == dom_cow ) + const struct domain *owner = + page_get_owner(mfn_to_page(mfn_add(mfn, i))); + + if ( dom_cow && owner == dom_cow ) { /* This is no way to add a shared page to your physmap! */ gdprintk(XENLOG_ERR, "Adding shared mfn %lx directly to dom%d physmap not allowed.\n", @@ -700,7 +702,7 @@ p2m_add_page(struct domain *d, gfn_t gfn p2m_unlock(p2m); return -EINVAL; } - if ( page_get_owner(mfn_to_page(mfn_add(mfn, i))) != d ) + if ( owner != d ) continue; ogfn = mfn_to_gfn(d, mfn_add(mfn, i)); if ( !gfn_eq(ogfn, _gfn(INVALID_M2P_ENTRY)) && From xen-devel-bounces@lists.xenproject.org Tue Nov 29 14:50:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:50:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449443.706181 (Exim 4.92) (envelope-from ) id 1p01wJ-00087i-P9; Tue, 29 Nov 2022 14:50:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449443.706181; Tue, 29 Nov 2022 14:50:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01wJ-00087b-Lw; Tue, 29 Nov 2022 14:50:27 +0000 Received: by outflank-mailman (input) for mailman id 449443; Tue, 29 Nov 2022 14:50:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01wI-00087U-Cl for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:50:26 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2057.outbound.protection.outlook.com [40.107.7.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2856b883-6ff5-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 15:50:25 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8423.eurprd04.prod.outlook.com (2603:10a6:20b:3b5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.21; Tue, 29 Nov 2022 14:49:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 14:49:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2856b883-6ff5-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NSARZHG+SOWHxHpTrrlTvU1UhF1JvRmVverI4jC6cBlHwqspL7Vz+Nt2aORhE/vL7Sm9/M/hQTIGx17ZzARLmBX8ifA5Yx0qpjjlbFjOksq7DyxDn94iBiUryjTQb3iQJyv8U9KU0UlKTOrbSamrwmalI0/zmKPOTfVANPWnCOKSbpOlekl2STTbBhvR37AOcMFQKeHZr8zvveEkDvp0rSmP5G8Elju4AJeYb+JQLFUN2RLkCAWVdkrf4Koy74mP7gPVR9u17qLK/WLInouGzKMy83X1TOy/8+TgklMhuVj5OKMHzkVythtIPgLB31cGcnSK8Fc9oqwUrCKNNIjlsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/yZJ1LIts7VqeitQmCNVAh1vz5oW18vSF5fdrcLYBc=; b=Mxjw3oAYLp1dQFzQ9iRyqx9SMI9+QkSO3mFGNg6//pEjS186EjrHKmToor6gdS/fU65NoVz0h3PgJOaE1XzKs0+zigbwTZeL0ZCiVMuNtYsauo1fYRLYz7COvGcYuq4hHpZRofaOllQMAjSKmrhgHeZrqwv6+2nqA48qi/NSYXIdJhOoA5Rhd8fbeQSv6d4XdTkQITlCLl2Q90XcHcBbhZKp1XcyNkCQ3SGEAD1nnXzYLKhat+HKO3F+OtXFbaU/mDlBCatiwPNahYEq+Jl8Ste4laAFS+yZsvHnrQquh2mWHIN74pc4f06BRzG35ZrZZDEGsSScp3krH2jAlgNF4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s/yZJ1LIts7VqeitQmCNVAh1vz5oW18vSF5fdrcLYBc=; b=Two+XRkKcy28cwdOF4gXwpZqusTQnNs/rtpN26P5kLTG7++bRhXvipdsyQ8DgLIflytq1MA11zo7Q57iwztC44xvcrEI7Izt2oPs3toQK7rqeORG4YnmAt6Ss9zAmoLYTaAfLDGfwg6Ald4NAA7eSGAvtAd/El2qOXxO7mlu5MnfIc8PmHpirN1hspRVlhONaeNXPVdirAzxOM4ryFBkxUlA/pJiqYTyGwGfMc9DVxyhBcgAor5QPY12oPksAliB15q9wr4UVgMvBrEOjEf+mipVp3rS+hPVmd2D8eso/k006vGYsNmxUsUf0JMpu+RrlW8qDfgyD4sWvGQ+johGYg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 29 Nov 2022 15:49:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/MSR: use latched "current" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0087.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8423:EE_ X-MS-Office365-Filtering-Correlation-Id: 495fdccc-60c1-418b-085b-08dad218fb9b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mplTZQeW99QtqKWxwuBhYdMtenD1DlFuJHo8PPCPqYiuOBqxT1p4xIqNSLOAonBU7tmLxE43FKkWglKQjsaOMff4VQjpNE2SO03zH6XP4iewrqBo692DW/IffeNw2mW6DZoHiiyQvH9WFaEl1cHzn1/oK4CLrf7IPYDWh97pZJz9eJC4OvBe18c26JYQOaeQ/F+/b2Hkt42JANDHUuA9BDyUGI4jTB2zGkorjST6VXSx2ra2tn8J84nny4zUTh0N6PrspLhVsy+30lFF6sw3akveV5LjcScXIQlU5PbodMDSQ6xBl7S6s7adpEpX5VPQ6dXn3n2wvoZFV2BqJe9aYHuh2AjnoJaU+JU7Ai4AwCOw8kxZm8GaYO0XXWgkQTHUP5V/6Y3BPupEjHjOyL+BSoSSQEc7mUbI+5vnR+hOr6qN1sth745KSpZoXfnGWKBddAz3vKEHCtp4cqDb2ksT0Acg3mbEK0Cf2BPfQtwgZkMtulaEu5GHC0dTWRhIzMxHvs5sC7OhFULoFK8hbA6gdyX8wQohS1da1oO96uy8Yis817Ny21qYyXSyxMpSe+dIj0kJQtA2AJi7bTHSGQxyG8NyAfaQJkR0Ktb5rRQqMDXuB7VxhI3I3K5uRUQEIbiPS0aAWoYIt0mJ4U+neYmsRJUR2bJosmQUtezl0KQ6aUWOrNn6QCcv8OhYmHp9PuKjqKckNkI0eSi3A6ELl13JFS3+jbMRinRJzlnuConKeQg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(396003)(39860400002)(346002)(136003)(451199015)(2906002)(8936002)(4744005)(31686004)(316002)(41300700001)(54906003)(6916009)(478600001)(6486002)(5660300002)(4326008)(66556008)(36756003)(8676002)(66476007)(66946007)(2616005)(6506007)(26005)(6512007)(31696002)(86362001)(186003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFd6MWx4K2E4dy9JWVpRWHJRSU10a05oNHdlU2ZyMFY4eTZzeitrcjU4elV2?= =?utf-8?B?YW55dGFEeG8rUEh3QWUrVFN6dXdxZWxWYmR5UTFXcUMwVTU0ZnJXN05JenNh?= =?utf-8?B?d2ZxMUoyNXBVYnNscGs3d2tEUWNOcWIzRXBVU29mUkY2SEMyMTVydC9xalV6?= =?utf-8?B?TG0xRVJUaEp5bWN4RW0xODdLcE1sNGUyaUxaSWxMN3FOVHlPSm1ieFJPTDhs?= =?utf-8?B?KzdaV0w2MVZzaHkwSkNzbEt0YUFpV0x1YVQrOURUd2RRcVdVTXVtdnFsTXcy?= =?utf-8?B?RmNjTkcwSW8xOEFxNmkxUC9xM3E4UWN1OWJ0Q2U0ODdpUzdta2ljYjBkQy8v?= =?utf-8?B?OTBGQllNY0lDSTJBTjdpSC9IK0NZbWk5T1hGMmxWMFRVa2tXWUdoeDZRWVJG?= =?utf-8?B?bjUramxxdTdxWkhPNkYzSlg1cTViSkxZQ291alA1QTZKWWR4S1BkNWx5aHU0?= =?utf-8?B?Yk1zc0VST0JBK1VzdXFzQUxLVDJRMTZQc0NadkFEWlhoZ2xQQWV1MmRpVk5p?= =?utf-8?B?QkExak5YZk9kOFpVcnd4VGpEa21DNkY4YS9QVWxHbk01SzRDSEUwdHkvcGVi?= =?utf-8?B?bXI3Ri80UVRYMUllVGIzcjgva2FNS1E1bUJHejVDTURoakczM0EwQXYvV1JZ?= =?utf-8?B?amdhWW5SVmM0NE95bHhUVXk1SlpOdW9yNEFiZUU3dGlQcW8vdFJyZ09kWjdE?= =?utf-8?B?VXJ4WS9iaXJGRFVxd2hXS3VyY2pHRWN0Mmw3bVRxSU94K3JtRVpxZzlUY2tD?= =?utf-8?B?Y0Jkelh1REpqY2xTM3ZSYWloU2F5UU1ORlNLQkhJaUZBL0J4SGRmbXBwU0Fs?= =?utf-8?B?UU1XM05NTkhaUkhzRkN5bGRRRVJEa20wdWsxb2lRREVxaTQ1Z2hqVk0vWHpU?= =?utf-8?B?RFFUMGtxcEtzTUtod20zZzdqYUZMOTVONHlrNWpGNW1QUU5ZNDkwUERjM25M?= =?utf-8?B?dHcvVlFRK3czcnJjb280RTZwRnpZVlZJenJuTTArd3k2N2RvenowblNJUEZ4?= =?utf-8?B?MmZnZEVZRFMwanBYSVZ2RXpZTStpaGQyR29uN0d2blpEb2tuR1BvdGt0aW56?= =?utf-8?B?SkJiQlF5aUdXLzVyTjJwRDFmV2psTFZQL21BandBM0I2US9zd2xTZXk3OU1W?= =?utf-8?B?ZENRajRHQ3ZqSDNQYzZkZE5xOFZobE5sVWxYTFlRdCtpU1JvdnRKQVp2K3Fh?= =?utf-8?B?OE9uQ2xORS9ZKy9ndFVxbXJqa2s2cTRNMDZOb3Z6czlkeTBMbjhQVys2ZTZO?= =?utf-8?B?aFdwNnhWb3R0T3p2azZJaldPaHQxSlFwRGdPRUJqczRSSUorcGxYdVR6aVpU?= =?utf-8?B?YnZvNzFXZUNUNnlNcnhwaFdrSEhyWGlmZDVuY2t3VWxuckI0M2lTRkpxSTdh?= =?utf-8?B?eFN3WXNMYTRjRUFpYlI1TVQvQ0NFaDZ1alhGbmRYM3lCSmRmRVVWVzh6d2pk?= =?utf-8?B?eDV4eXhXaEdjZzZiS3RDUm83YkdkM3VWS2M4UnpySGdIRTlQYTk0cWVCaEgz?= =?utf-8?B?U29XVVRiSXp3OHlFSDA3Unk5V1IxK2FudFdZNkIxSmxSNjVFbjBkK3NKV2Vx?= =?utf-8?B?cWt5Njk2OGhUaTVaZnkybXJ4MWhwVmZKUHRGWnJtYWh1REdsM3NGRnkvYnVj?= =?utf-8?B?THRHaEpjKzNlRUNPZjhNY0g4RG5LV2JSL3FGNWxTRDNnbjYvQjlYMVVabDhO?= =?utf-8?B?TG02bGlrdXlVZHhnaGQ4aVBNZDBZRkZ0UzFPdC9tNkhjTzk2RkZCYkpkckpM?= =?utf-8?B?czRwN3p1dWR6b2w1bXpCaWFhd1VOZ0VqSWlOeDdEdnFicmFQTXpnSXVQeWpm?= =?utf-8?B?ODR0dkwwWEgycVFoNEFHeld1eDkxMERScDZ3d3lmSjZEcFRydC90SnZtUGdw?= =?utf-8?B?YjJVb2JhYmQ0bEFINlhNUGhIMjFYc2ZFZEdNS0JzeThKTkNFZ01HZFp5UWNJ?= =?utf-8?B?YUc1ZUIxM2NkQm1IUmFvL2ZLRFhlQTZnM3ZxLzJYWGdKSGxVc25JTFVOaEMw?= =?utf-8?B?dXZDZy9TbVN2NEQyaEw1dS9RQ29EZEpOZ1BUTWc1bEFTTHBOOWFNTmRyNXlG?= =?utf-8?B?YjgwUHA2Y2tVcE55RFlQZk9uZk9uL3dnQ3FtaEl6RS9tQW5PS0FWaE94Y1Fv?= =?utf-8?Q?sBOZltMnktRVLiGifCid+qNmU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 495fdccc-60c1-418b-085b-08dad218fb9b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 14:49:57.0042 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lf4ihBx8A0Hr3ZULAJqugf4115OOW4LO+lU+ZpVaW3M/mhVc2K0NS73OtqVQvyYNnt6jWgBxf0hqPId1H/ZE0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8423 There's no need to recalculate / refetch the value from the stack (pointer). Signed-off-by: Jan Beulich --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -417,7 +417,7 @@ int guest_rdmsr(struct vcpu *v, uint32_t * out of hardware. */ #ifdef CONFIG_HVM - if ( v == current && is_hvm_domain(d) && v->arch.hvm.flag_dr_dirty ) + if ( v == curr && is_hvm_domain(d) && v->arch.hvm.flag_dr_dirty ) rdmsrl(msr, *val); else #endif @@ -639,7 +639,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t { uint64_t xcr0 = get_xcr0(); - if ( v != current || + if ( v != curr || handle_xsetbv(XCR_XFEATURE_ENABLED_MASK, xcr0 | X86_XCR0_BNDREGS | X86_XCR0_BNDCSR) ) goto gp_fault; From xen-devel-bounces@lists.xenproject.org Tue Nov 29 14:51:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:51:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449450.706193 (Exim 4.92) (envelope-from ) id 1p01xU-0000KB-BC; Tue, 29 Nov 2022 14:51:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449450.706193; Tue, 29 Nov 2022 14:51:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01xU-0000K4-5j; Tue, 29 Nov 2022 14:51:40 +0000 Received: by outflank-mailman (input) for mailman id 449450; Tue, 29 Nov 2022 14:51:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01xT-0000Jh-0Z for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:51:39 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2078.outbound.protection.outlook.com [40.107.7.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 53511cea-6ff5-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 15:51:37 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8423.eurprd04.prod.outlook.com (2603:10a6:20b:3b5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.21; Tue, 29 Nov 2022 14:51:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 14:51:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53511cea-6ff5-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U+32Gj1PB7Ixdg1qC03zO+vCShEvDfMbIdvIDHX3QE8suu3dCSTzkjoHAscNVLt8kPYKeB89xpwbSurDmTrIPJAkI2J4dRszcDPpEzjYP2E8LTAIKkO1RqvWM1taQOFwEviXaaLWe03KD66SppElmLC74pRwBlxRSuLAxYM0sx67IANwGpOY1FTn3asH+gxNK9HRk3RaquI1YNF/f45L52pYYRxmn78xTE11891XiS5zmpVaqB+q4Eye55UVhCbymqTk7pdw2dbKNhlL2UTwbac9EbRocQTJ1QBNCN+m++pszQKPfq8bQg86v2g9NN8D83qQPsMOEL2xP8eXGh/ADg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wKflOQr2l2Ku3B3wa6fmhkMpxp8G8wXgKeSq/bg7zl4=; b=QEdRW1aQkqVip3DTjhG4Nv5AWucLbH1Y2rkKa3MGYHvv2Sy7niWgh8vhc8TA3JAFhclAm1M2PnmVuwGN+4DRbrnL25Uc8yqXjsm9zxEa2XFs2I70W2Ox7rblrpIjcwYlwqjh7M8Kte67LRF/XzguKlvNFeaj0PqVDpFEwYnzKuSzPfXmzutcNJVUKXPZdNGw7KfEV6+ys8nTI3IkbgRnD3wwJvj7TkpOEgfltazPmn9foITyFxrUqmU3us3PSjvWvGhNY9Yxr1Bksi/n03a/gFDnK2qMqLFdelc1HS05bj0l+QHamxJdpDQpZX28rv+dlzQ5IKAKzXPXSJFe8yMXrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wKflOQr2l2Ku3B3wa6fmhkMpxp8G8wXgKeSq/bg7zl4=; b=qPuPvTWjLH+aG6HLjz5nTp/OZ2ThB3AHr0CkBbtBBsUuSppHhkGr01hpz1bqV2c8lGhlcnmbWt/1mqPGwQf7T5paaj34w4vANs4BwiO6FU8UK5USqKahMSzeKNLxcSFf3h1RDapRInEUQ6Wq7iZczeKeSIqbFgSd8eIEOHp65ilONRIj7CN+2q961JlC0eyRMw5yOeHMv1gNuXzjM1CcH9b+wnrp8CRviEToylJ5OST09PR/vezDfdppe/AYqiW3iyEWDbon7YixAydTllp0EAeT+Sn0bKJwAYKeQlzgfgu6vO62F9meuTOdNTue+JxPP1VwEoCNEkj2H/T3i7Cyhg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 29 Nov 2022 15:51:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/HVM: drop stale check from hvm_load_cpu_msrs() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0158.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8423:EE_ X-MS-Office365-Filtering-Correlation-Id: 48ac0ace-0d35-4ed2-9157-08dad21926ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0pBuMUXsNMEz3d2E/tuYy4INZniYbF9QD1RZwmMP/fAyndOfRS24qUYAmbwaeUBkNaeQaAQgULe9n+Z78J2WzATSHRvx5Oh+rPX46mS3RLkCxtE05Sy4iwbHMP3+ghXUqkgQC6C8zTObVaeC5akLNyRW5U7eUW/NYXLMEb40QelgwGdmBoApNHWhxKfX/XBcq0zIkcYXZCveeUCK+3M9RS7GaeLjHpAU8/Lfr4SbYaTPPhjokTasu4Wv3hP05B/bormUrpTNCycD3t48hlJKYT4aQyyST13QSTzI4bvSyqjjGiViKGUJMBF+/cbE7oJRUHyxOJgExur81P+ysAZL6SeMfbXt5scD0PJcfT+orSDTb2afnhj1SxaD6Is6VwN/IN1wbsHlCOfLg1GCepDQAfajcFb01WMbSrsROuHtGH9yrZu+KbBougP8Dl/9LAAxlbBm3TBbuZlCgg0cL8D+1uOJJsiDr0JHiNdtGEKO4Kl+ojDzt+bZ11wXUi2Dbm2v4UsoW6jslIv4HeKMI5+9NKTrZ0TkBpzvBdjhRd9724heJ6fs7Z7+b8T4vETAxLg8girtFwEu4u8E2zjfEtIgLhIU4AEh9+GrPEl2DfeMupmfxtIFTI0Xy22q9fm7uH1k3fU8yQrzo5mElXGl7fYnfLXcNU371IpDUhVF1/5QNnAgUGqzDZZccmjFcHx16dMc1HobIck6UCf3jQUE1LqLNCq26NlsoXoR2UOCDc0eIjo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(396003)(39860400002)(346002)(136003)(451199015)(2906002)(8936002)(4744005)(31686004)(316002)(41300700001)(54906003)(6916009)(478600001)(6486002)(5660300002)(4326008)(66556008)(36756003)(8676002)(66476007)(66946007)(2616005)(6506007)(26005)(6512007)(31696002)(86362001)(186003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGl3UlN3Z0RmcUpycjcva2Q4OUFTOTZTNTFlYjNDU04xa21uUFVjUmg0K1lQ?= =?utf-8?B?U25XV0prWXZkVnhLWnhSc0Iwa2xnQW8xcTFOS3V6VlBJeCs1QStXbTBiZnpx?= =?utf-8?B?RnRGMFd5STNtOS9VK3NyNlBRbnVjSTlJcXR5UXBGVy9kSWU0U011M2tTeXZ2?= =?utf-8?B?T2ZYT2tXUGVoclk4VDRaSm10bVhvbkRQTXpxUG16TTlsNCtianRLb2Fvd3NZ?= =?utf-8?B?MDVYdHNJdktJei9tZDFSa1FHWVdyK1Q5YU91cld0Q3Evd0tmazBOWHJKVHEv?= =?utf-8?B?blJRM01TVDR6V0x5YmNadnJSeTRNN0trVkJHSVRSNEpYdzJpZ1NHdGgwVXVG?= =?utf-8?B?UHIvYXpNd2lMTjlJbnZ3ZW51ZjBKZ0pwN1BwUVlrTWI3K3ZMaEdvaTJ3K1BD?= =?utf-8?B?ckRlWXhmaVNTMituK2w3RmloSk9OQnBrY2dKQ0p0bXlxOFM5REFHWGxWbUw3?= =?utf-8?B?RXhOVkFlWjNqK2FxSlQ1b0lPcFpTeE82SjdybFN6UFJjcnJ0TS9Ram5Fbmo4?= =?utf-8?B?T0g0alQvaTFjVUNTbnlJZGdYdG5UYUlMSUVNMHVWYjE2WGx0ZzJIeEJGbWNl?= =?utf-8?B?OXZzSjhsL1BVZWpqY3pzdDRqL2ZmRm5YbWROQi9iVE41YW9xa2EzZnoxZk9a?= =?utf-8?B?K1BWNldFVzZJNlpTOVhhVkhvbk9pQTM5dWZ2ZXNEZVJsKy9TN1RMcGJKMzJi?= =?utf-8?B?bkx5ekZRL21zNjFhVks1ZVIvZlhlcVFFWWFLSjVVaDYvN3JkUG5nNjA2aE5Z?= =?utf-8?B?STRXUkt0MW94amRkQUNjVDFGVXpiTkJWSDRwbys0YTZoWmVNT1lJYnA2WGFK?= =?utf-8?B?TTdhbktwRlNhRktIV2tzVGhUcGoydHAwNVNNb3kxQ1Z6M3gvL0xLU1Bsd1No?= =?utf-8?B?Wm01Zm1WbHBRY0x5MXR1aDZmVVVxakpKNlQydkpSSlYwdnpkSjE1VURRblQ0?= =?utf-8?B?L2x6aTdLdVBSbHp5STRtZTBUZkl1c2xFbjdsWUoraWFRUTB5c1NRNlg3dTYv?= =?utf-8?B?NXRSY1hzeXk1OUhSczhBbklvWEFQL2hFZ3FVT25sNldqQ1lNQnlnS0k1bklH?= =?utf-8?B?U0sweTJHT1h1bzlXdUhqRFo2My9ZanhPMStYNW9JdnFoRmpnS3VnRlNJclMz?= =?utf-8?B?aElnTVArV1IzTzZnelpveTlyODdFTHhjTEk3Yk5mMjNZMyswdFVlMmx2U0ZQ?= =?utf-8?B?NnF2QTVmL1VHL281RFF0a1U1OVl6WlJBVEJ6YjJlcU1WU2NMM2UzZ0NLd0tj?= =?utf-8?B?Z3BRQmk2V0dPdDFhZExFb1AvNUNzQzdiRmR2cGlQaDBRUDl1NjZLZHlsUU95?= =?utf-8?B?VFZ2c3ROUHJ2SjNjc0piS2djcllGM2VFdEtyM1VvemExWnJUbC9XdW55UGZF?= =?utf-8?B?cWs0V0I5RFRvZnQ2UGpIem9rNzJyNlpHMmx3c0FsdjAwRENlMjY4SVRXZlN1?= =?utf-8?B?UThrZmFPMXpuSlJYOWtQUUxMTFVrZkVkb1plSk4ycWwzY1NNbnFmdGxyYnpt?= =?utf-8?B?Z0hsdjMzNE1rUVRlOFJhQjN6RnNwMTNoOFoyZzJKYzNlRHIrVWplQjFYaHpW?= =?utf-8?B?REdhWnJhVUlub1lBTTZFakJrTzA5bmMzdUFhTGhFK25iSmExa1BWTVZFaGVo?= =?utf-8?B?Y280SHpCa1RFUU42a3Jkd05lNGdRTkR2RjFTVjhCOWltWHB6NDB2eWxZVi9n?= =?utf-8?B?ZTFMTWJOQUdpbVY1ZzI1SC9QeXp2MGcrR2hwZHJTckgvL1ptcGk5WmdLOFZZ?= =?utf-8?B?NURDSkVtK1ZvOGpZcXlPVndKbUpYaUc0RkNHUnpYUTRoenc1eGM3dkY5QmlP?= =?utf-8?B?MGZ1elFaNEt3MUtTUTRUMFR3b1dLMFAyTFJ6NTQ3aG40bCtBVFVzTlNjSUlB?= =?utf-8?B?QTNhdnN5aEdFRVhBRm5wYUdCS0VSWktCWFBFbWJpZHFNUVFKZmZBQXBaZ21C?= =?utf-8?B?U0JUUG80eHc3cm9kMVVSL0tvOFZHbkdhZ2cvb2NtYzVKUFR4WEIwbnVlL2Zr?= =?utf-8?B?L2ZaQVAvR0V0NTdUV0hqbkxrajVzd1Y2VGdGd1NsbWRuYU50SEc0RFR6UXUx?= =?utf-8?B?N3EwWXcvKzVUL3Rnbm5IdGFTR2tJMzM2c0tXSWwxTFJQa3duRk5jMHFmcGxO?= =?utf-8?Q?Dj06bFnpCmZgIah/sz8cfkAN9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48ac0ace-0d35-4ed2-9157-08dad21926ce X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 14:51:09.4371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oeF10TgIQzB/FouiWXQQqf8Rh23KxckeKkToAaARTQLJ1mSZ+2BO9NkTF91S+nitG/PsHjGRmMz72l07LoRDxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8423 Up until f61685a66903 ("x86: remove defunct init/load/save_msr() hvm_funcs") the check of the _rsvd field served as an error check for the earlier hvm_funcs.save_msr() invocation. With that invocation gone the check makes no sense anymore. While dropping it also merge the two paths setting "err" to -ENXIO. Signed-off-by: Jan Beulich --- We could go further here, removing the local "err" variable altogether, by using "return -ENXIO". Thoughts. --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -1494,13 +1494,12 @@ static int cf_check hvm_load_cpu_msrs(st case MSR_AMD64_DR1_ADDRESS_MASK ... MSR_AMD64_DR3_ADDRESS_MASK: rc = guest_wrmsr(v, ctxt->msr[i].index, ctxt->msr[i].val); - if ( rc != X86EMUL_OKAY ) - err = -ENXIO; - break; + if ( rc == X86EMUL_OKAY ) + continue; + fallthrough; default: - if ( !ctxt->msr[i]._rsvd ) - err = -ENXIO; + err = -ENXIO; break; } } From xen-devel-bounces@lists.xenproject.org Tue Nov 29 14:52:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:52:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449452.706203 (Exim 4.92) (envelope-from ) id 1p01yP-0000x0-IQ; Tue, 29 Nov 2022 14:52:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449452.706203; Tue, 29 Nov 2022 14:52:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01yP-0000wt-FP; Tue, 29 Nov 2022 14:52:37 +0000 Received: by outflank-mailman (input) for mailman id 449452; Tue, 29 Nov 2022 14:52:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01yO-0000wn-Jf for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:52:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p01yO-0000Ir-2p; Tue, 29 Nov 2022 14:52:36 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.9.110]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1p01yN-00064Z-Ny; Tue, 29 Nov 2022 14:52:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=5GHRx9MS2VH0b3ZC3JgZuIlyB4uPGMSRWYLxSkzTJao=; b=sS5Y+GxutqygN0XkMrdE8Z6xZ1 7lFCnV2Du8bOiw1x6xiaCVXSd+xYBbWRHDDA14EG8AcGJihDpZ3uaM3nykLffhnwbgcERGurtJBNb JnhFMzgEANn9mCwcvtpwz4bkAugAN5/VUlVoTzRHXEjbmwyrek/gTWIu6rE2S7aQqaAM=; Message-ID: Date: Tue, 29 Nov 2022 14:52:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: Arm: AArch32: Need suggestions to support 32 bit physical addresses Content-Language: en-US To: Ayan Kumar Halder , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , "Stabellini, Stefano" , bertrand Marquis , Andre Przywara , "Volodymyr_Babchuk@epam.com" , Rahul Singh , Vladimir Murzin References: <70651dbc-085d-706d-17d0-a419086a0700@amd.com> From: Julien Grall In-Reply-To: <70651dbc-085d-706d-17d0-a419086a0700@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 29/11/2022 14:57, Ayan Kumar Halder wrote: > Hi All, Hi, > I am trying to gather opinions on how to support 32 bit physical > addresses to enable Xen running on R52. > > Refer Cortex R52 TRM, Section 2.2.12 "Memory Model" > > "...This is because the physical address is always the same as the > virtual address...The virtual and physical address can be treated as > synonyms for Cortex-R52." > > Thus, I understand that R52 supports 32 bit physical address only. This > is a bit different from Armv7 systems which supports Large Physical > Address Extension (LPAE) ie 40 bit physical addresses. > > Please correct me if I misunderstand something. > > So currently, Xen supports 64 bit physical address for Arm_32 (ie Armv7) > based system. Xen supports *up to* 64-bit physical address. This may be lower in the HW (not all the Armv7 HW supports 40-bit address). > My aim is to enable support for 32 bit physical address. Technically this is already supported because this is a subset of 64-bit. I can see a use case (even on non R* HW) where you may want to use 32-bit paddr_t to reduce the code size (and registers used). But I think that's more an optimization that rather than been necessary. > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index 6014c0f852..4f8b5fc4be 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -56,10 +56,10 @@ static bool __init device_tree_node_compatible(const > void *fdt, int node, >  } > >  void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, > -                                u32 size_cells, u64 *start, u64 *size) > +                                u32 size_cells, paddr_t *start, paddr_t > *size) This needs to stay uint64_t because the Device-Tree may contain 64-bit values and you... >  { > -    *start = dt_next_cell(address_cells, cell); > -    *size = dt_next_cell(size_cells, cell); > +    *start = (paddr_t) dt_next_cell(address_cells, cell); > +    *size = (paddr_t) dt_next_cell(size_cells, cell); ... don't want to always blindly cast it. That's up to the caller to check that the top 32-bit are zeroed and downcast it. >  } > >  static int __init device_tree_get_meminfo(const void *fdt, int node, > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index bd30d3798c..3cbcf8f854 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1314,7 +1314,7 @@ static int __init make_memory_node(const struct > domain *d, >      dt_dprintk("Create memory node\n"); > >      /* ePAPR 3.4 */ > -    snprintf(buf, sizeof(buf), "memory@%"PRIx64, mem->bank[i].start); > +    snprintf(buf, sizeof(buf), "memory@%"PRIpaddr, mem->bank[i].start); >      res = fdt_begin_node(fdt, buf); >      if ( res ) >          return res; > @@ -1665,7 +1665,7 @@ static int __init find_memory_holes(const struct > kernel_info *kinfo, >      dt_for_each_device_node( dt_host, np ) >      { >          unsigned int naddr; > -        u64 addr, size; > +        paddr_t addr, size; > >          naddr = dt_number_of_address(np); > > @@ -2444,7 +2444,7 @@ static int __init handle_device(struct domain *d, > struct dt_device_node *dev, >      unsigned int naddr; >      unsigned int i; >      int res; > -    u64 addr, size; > +    paddr_t addr, size; >      bool own_device = !dt_device_for_passthrough(dev); >      /* >       * We want to avoid mapping the MMIO in dom0 for the following cases: > @@ -2718,7 +2718,7 @@ static int __init make_gicv2_domU_node(struct > kernel_info *kinfo) >      /* Placeholder for interrupt-controller@ + a 64-bit number + \0 */ >      char buf[38]; > > -    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIx64, > +    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIpaddr, >               vgic_dist_base(&d->arch.vgic)); >      res = fdt_begin_node(fdt, buf); >      if ( res ) > @@ -2774,7 +2774,7 @@ static int __init make_gicv3_domU_node(struct > kernel_info *kinfo) >      char buf[38]; >      unsigned int i, len = 0; > > -    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIx64, > +    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIpaddr, >               vgic_dist_base(&d->arch.vgic)); > >      res = fdt_begin_node(fdt, buf); > @@ -2860,7 +2860,7 @@ static int __init make_vpl011_uart_node(struct > kernel_info *kinfo) >      /* Placeholder for sbsa-uart@ + a 64-bit number + \0 */ >      char buf[27]; > > -    snprintf(buf, sizeof(buf), "sbsa-uart@%"PRIx64, > d->arch.vpl011.base_addr); > +    snprintf(buf, sizeof(buf), "sbsa-uart@%"PRIpaddr, > d->arch.vpl011.base_addr); >      res = fdt_begin_node(fdt, buf); >      if ( res ) >          return res; > @@ -2940,9 +2940,9 @@ static int __init handle_passthrough_prop(struct > kernel_info *kinfo, >          if ( res ) >          { >              printk(XENLOG_ERR "Unable to permit to dom%d access to" > -                   " 0x%"PRIx64" - 0x%"PRIx64"\n", > +                   " 0x%"PRIpaddr" - 0x%"PRIpaddr"\n", What's wrong with printing using PRIx64? At least... >                     kinfo->d->domain_id, > -                   mstart & PAGE_MASK, PAGE_ALIGN(mstart + size) - 1); > +                   (paddr_t) (mstart & PAGE_MASK), (paddr_t) > (PAGE_ALIGN(mstart + size) - 1)); ... this would avoid adding explicit cast which I quite dislike. >              return res; >          } > > diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c > index ae5bd8e95f..839623c32e 100644 > --- a/xen/arch/arm/gic-v2.c > +++ b/xen/arch/arm/gic-v2.c > @@ -1058,7 +1058,7 @@ static void __init gicv2_dt_init(void) >      if ( csize < SZ_8K ) >      { >          printk(XENLOG_WARNING "GICv2: WARNING: " > -               "The GICC size is too small: %#"PRIx64" expected %#x\n", > +               "The GICC size is too small: %#"PRIpaddr" expected %#x\n", >                 csize, SZ_8K); >          if ( platform_has_quirk(PLATFORM_QUIRK_GIC_64K_STRIDE) ) >          { > @@ -1289,11 +1289,11 @@ static int __init gicv2_init(void) >          gicv2.map_cbase += aliased_offset; > >          printk(XENLOG_WARNING > -               "GICv2: Adjusting CPU interface base to %#"PRIx64"\n", > +               "GICv2: Adjusting CPU interface base to %#"PRIpaddr"\n", >                 cbase + aliased_offset); >      } else if ( csize == SZ_128K ) >          printk(XENLOG_WARNING > -               "GICv2: GICC size=%#"PRIx64" but not aliased\n", > +               "GICv2: GICC size=%#"PRIpaddr" but not aliased\n", >                 csize); > >      gicv2.map_hbase = ioremap_nocache(hbase, PAGE_SIZE); > diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c > index 3c5b88148c..322ed15e6c 100644 > --- a/xen/arch/arm/gic-v3.c > +++ b/xen/arch/arm/gic-v3.c > @@ -1402,7 +1402,7 @@ static void __init gicv3_dt_init(void) > >      for ( i = 0; i < gicv3.rdist_count; i++ ) >      { > -        uint64_t rdist_base, rdist_size; > +        paddr_t rdist_base, rdist_size; > >          res = dt_device_get_address(node, 1 + i, &rdist_base, > &rdist_size); >          if ( res ) > diff --git a/xen/arch/arm/include/asm/setup.h > b/xen/arch/arm/include/asm/setup.h > index fdbf68aadc..ddffffe44c 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -158,7 +158,7 @@ extern uint32_t hyp_traps_vector[]; >  void init_traps(void); > >  void device_tree_get_reg(const __be32 **cell, u32 address_cells, > -                         u32 size_cells, u64 *start, u64 *size); > +                         u32 size_cells, paddr_t *start, paddr_t *size); > >  u32 device_tree_get_u32(const void *fdt, int node, >                          const char *prop_name, u32 dflt); > diff --git a/xen/arch/arm/include/asm/types.h > b/xen/arch/arm/include/asm/types.h > index 083acbd151..a7466d65c2 100644 > --- a/xen/arch/arm/include/asm/types.h > +++ b/xen/arch/arm/include/asm/types.h > @@ -37,9 +37,15 @@ typedef signed long long s64; >  typedef unsigned long long u64; >  typedef u32 vaddr_t; >  #define PRIvaddr PRIx32 > +#if defined(CONFIG_ARM_PA_32) > +typedef u32 paddr_t; > +#define PRIpaddr PRIx32 > +#define INVALID_PADDR (~0UL) > +#else >  typedef u64 paddr_t; >  #define PRIpaddr 016llx >  #define INVALID_PADDR (~0ULL) > +#endif >  typedef u32 register_t; >  #define PRIregister "08x" >  #elif defined (CONFIG_ARM_64) > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c > index 6c9712ab7b..0c50b196b5 100644 > --- a/xen/common/device_tree.c > +++ b/xen/common/device_tree.c > @@ -747,7 +747,7 @@ static const struct dt_bus *dt_match_bus(const > struct dt_device_node *np) >  } > >  static const __be32 *dt_get_address(const struct dt_device_node *dev, > -                                    unsigned int index, u64 *size, > +                                    unsigned int index, paddr_t *size, Same as for the other dt helper. >                                      unsigned int *flags) >  { >      const __be32 *prop; > @@ -781,7 +781,7 @@ static const __be32 *dt_get_address(const struct > dt_device_node *dev, >          if ( i == index ) >          { >              if ( size ) > -                *size = dt_read_number(prop + na, ns); > +                *size = (paddr_t) dt_read_number(prop + na, ns); I strongly dislike adding unnecessary cast in C because they could hide away issue. In this case, this raise the question why always ignoring the top 32-bit is always fine? This remark is also valid for all the other changes in device_tree.c. >              if ( flags ) >                  *flags = bus->get_flags(prop); >              return prop; > @@ -935,7 +935,7 @@ bail: > >  /* dt_device_address - Translate device tree address and return it */ >  int dt_device_get_address(const struct dt_device_node *dev, unsigned > int index, > -                          u64 *addr, u64 *size) > +                          paddr_t *addr, paddr_t *size) >  { >      const __be32 *addrp; >      unsigned int flags; > @@ -947,7 +947,7 @@ int dt_device_get_address(const struct > dt_device_node *dev, unsigned int index, >      if ( !addr ) >          return -EINVAL; > > -    *addr = __dt_translate_address(dev, addrp, "ranges"); > +    *addr = (paddr_t) __dt_translate_address(dev, addrp, "ranges"); > >      if ( *addr == DT_BAD_ADDR ) >          return -EINVAL; > diff --git a/xen/common/libfdt/fdt_ro.c b/xen/common/libfdt/fdt_ro.c > index 17584da257..a1e0e154c5 100644 > --- a/xen/common/libfdt/fdt_ro.c > +++ b/xen/common/libfdt/fdt_ro.c Please don't change fdt_ro.c. This is a copy of libfdt and should stay as is. > @@ -172,7 +172,7 @@ static const struct fdt_reserve_entry > *fdt_mem_rsv(const void *fdt, int n) >     return fdt_mem_rsv_(fdt, n); >  } > > -int fdt_get_mem_rsv(const void *fdt, int n, uint64_t *address, uint64_t > *size) > +int fdt_get_mem_rsv(const void *fdt, int n, paddr_t *address, paddr_t > *size) >  { >     const struct fdt_reserve_entry *re; > > diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c > index be67242bc0..1f86443136 100644 > --- a/xen/drivers/char/pl011.c > +++ b/xen/drivers/char/pl011.c > @@ -258,7 +258,7 @@ static int __init pl011_dt_uart_init(struct > dt_device_node *dev, >  { >      const char *config = data; >      int res; > -    u64 addr, size; > +    paddr_t addr, size; > >      if ( strcmp(config, "") ) >      { > diff --git a/xen/drivers/passthrough/arm/smmu.c > b/xen/drivers/passthrough/arm/smmu.c > index 0a514821b3..59b9a24099 100644 > --- a/xen/drivers/passthrough/arm/smmu.c > +++ b/xen/drivers/passthrough/arm/smmu.c > @@ -73,8 +73,8 @@ >  /* Xen: Helpers to get device MMIO and IRQs */ >  struct resource >  { > -   u64 addr; > -   u64 size; > +   paddr_t addr; > +   paddr_t size; >     unsigned int type; >  }; > > @@ -169,7 +169,7 @@ static void __iomem *devm_ioremap_resource(struct > device *dev, >     ptr = ioremap_nocache(res->addr, res->size); >     if (!ptr) { >         dev_err(dev, > -           "ioremap failed (addr 0x%"PRIx64" size 0x%"PRIx64")\n", > +           "ioremap failed (addr 0x%"PRIpaddr" size 0x%"PRIpaddr")\n", >             res->addr, res->size); >         return ERR_PTR(-ENOMEM); >     } > @@ -1179,10 +1179,12 @@ static void arm_smmu_init_context_bank(struct > arm_smmu_domain *smmu_domain) > >     reg = (p2maddr & ((1ULL << 32) - 1)); >     writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBR0_LO); > +#if !CONFIG_ARM_PA_32 >     reg = (p2maddr >> 32); >     if (stage1) >         reg |= ARM_SMMU_CB_ASID(cfg) << TTBRn_HI_ASID_SHIFT; >     writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBR0_HI); > +#endif > >     /* >      * TTBCR > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > index 1528ced509..20b4462fdd 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -466,8 +466,8 @@ typedef uint64_t xen_callback_t; >  /* Largest amount of actual RAM, not including holes */ >  #define GUEST_RAM_MAX     (GUEST_RAM0_SIZE + GUEST_RAM1_SIZE) >  /* Suitable for e.g. const uint64_t ramfoo[] = GUEST_RAM_BANK_FOOS; */ > +#if !CONFIG_ARM_PA_32 CONFIG_ARM_PA_32 is not going to be defined for the tools and I don't think we should define it. If there are any restriction on which bank to use, then this should be done in the toolstack. >  #define GUEST_RAM_BANK_BASES   { GUEST_RAM0_BASE, GUEST_RAM1_BASE } >  #define GUEST_RAM_BANK_SIZES   { GUEST_RAM0_SIZE, GUEST_RAM1_SIZE } > +#else > +#define GUEST_RAM_BANK_BASES   { GUEST_RAM0_BASE } > +#define GUEST_RAM_BANK_SIZES   { GUEST_RAM0_SIZE } > +#endif > >  /* Current supported guest VCPUs */ >  #define GUEST_MAX_VCPUS 128 > diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h > index a28937d12a..7f86af54b6 100644 > --- a/xen/include/xen/device_tree.h > +++ b/xen/include/xen/device_tree.h > @@ -572,7 +572,7 @@ const struct dt_device_node *dt_get_parent(const > struct dt_device_node *node); >   * device-tree node. It returns 0 on success. >   */ >  int dt_device_get_address(const struct dt_device_node *dev, unsigned > int index, > -                          u64 *addr, u64 *size); > +                          paddr_t *addr, paddr_t *size); > >  /** >   * dt_number_of_irq - Get the number of IRQ for a device > diff --git a/xen/include/xen/libfdt/libfdt.h > b/xen/include/xen/libfdt/libfdt.h > index c71689e2be..fabde78edf 100644 > --- a/xen/include/xen/libfdt/libfdt.h > +++ b/xen/include/xen/libfdt/libfdt.h > @@ -444,7 +444,7 @@ int fdt_num_mem_rsv(const void *fdt); >   *     -FDT_ERR_BADVERSION, >   *     -FDT_ERR_BADSTATE, standard meanings >   */ > -int fdt_get_mem_rsv(const void *fdt, int n, uint64_t *address, uint64_t > *size); > +int fdt_get_mem_rsv(const void *fdt, int n, paddr_t *address, paddr_t > *size); > >  /** >   * fdt_subnode_offset_namelen - find a subnode based on substring > > 3. I am happy with any other suggestion. > > In linux source code > (https://elixir.bootlin.com/linux/v6.1-rc1/source/include/linux/types.h#L152), CONFIG_PHYS_ADDR_T_64BIT is used for distinguish 64/32 bit physical address. > > Kind regards, > > Ayan > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 29 14:55:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:55:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449459.706213 (Exim 4.92) (envelope-from ) id 1p021W-0001by-Vz; Tue, 29 Nov 2022 14:55:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449459.706213; Tue, 29 Nov 2022 14:55:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p021W-0001br-TM; Tue, 29 Nov 2022 14:55:50 +0000 Received: by outflank-mailman (input) for mailman id 449459; Tue, 29 Nov 2022 14:55:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p021W-0001bl-5r for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:55:50 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20614.outbound.protection.outlook.com [2a01:111:f400:7e1a::614]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e90591ef-6ff5-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 15:55:49 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8152.eurprd04.prod.outlook.com (2603:10a6:20b:3fb::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.21; Tue, 29 Nov 2022 14:55:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 14:55:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e90591ef-6ff5-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KqTH/2VgeLFnirpIYIBQQG2ejIvxnwcmW0jTf1Jc1dqBMVmbXJPsznBxmHGhYlx5Q5UZnhZ59sdeN763+Hrn57Sy4ZbzB2+W8PWBIsCMRPgJzUES7XuzG1BOwCI3eJONMaP+yhX4X1O6STYqoY9HYqS95f9BYlND+2uGRCNeV6GAiXPEuwPu/UJru6BgnSgB6ljI/1GECYHNmy1T/BVcYTNQYwMfHGfeXfXX1E0mhuN93IpLEtEMk8aCS6BRSjYb+3NUwKDZT2zzsavX105lW4aiXydmnrTXTXmED1CTiXUlm+bacidgvzXkwPVbdrBmIP5tNiihNKt3wTNEXl29jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E9e/K2ZxeIJXak06Lk356njAefBtPZNeUDKX9joG6ao=; b=fTdJ5dYRJeks4W+SiIXlAcQJHT0D72jyktfmjE+TJijZWsjsPiE9ny/tZo/vcbxBN07pXafu5rhiABDbimSp7+VBtMjg9qauF43iuaoUOClCQtmgnMCvQYM/FmvtxC/uDpRARAbEwYpx5xIhfYc0BqIayNrLbT55Qb+73S3AiF/r4RJ8dL5YDPCZt7gfujv2/R1vsUKhVCJZ4lSMX67qgwLwPfGtJVipnaFMhvv2yWb9QcTAkSjMnejbWThzLmdWGunuIadPzTqhNItpWITXD0QtZwgRLpH/af0xBCDkKTkfvWMow2rwtM6Ns6fYvOiUXyhjSMWoWUfhdXEyxJXrtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E9e/K2ZxeIJXak06Lk356njAefBtPZNeUDKX9joG6ao=; b=IFQ6LfOB4P2a+I/pRoGNdmr/DNyrunY73fO+bAu4R/X91yJKkxE+qv0P9e1lzFkoHHeP8yTMA8xGjmc4yjZ0xl0wWXk4vWITKN9+6XURKHQNYpJH5aYMayhu8zVVXIuKWVHGoXFT3Otiam2UNXpXOyd79EWyQKa8R6vz6835rprjnGwW4D0iyoBCkWLN3O3+iN2yctMxXyypKAbcljLyKC4MplROH7NG/0jMVbOXAMa5GMCG03s8/EcPwLlNR2/j+207/FUIWH7fYLUJlDNR5wsgD79XO6LocFCh0dVi/N9rC3+OFl4RCWE4TP+AzMOuVFffDLGNnphzIniIR+mUig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 29 Nov 2022 15:55:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/mm: PGC_page_table is used by shadow code only Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8152:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e53daca-9469-48b2-8ed3-08dad219cc3c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qUCenrb+ghLEICUPhv4Gz9vmizLaGG2UEUa7aG46YDavR4KRh+NwDk5YNnHfK8x5PVKD2yQBsLQLLvzOXkU/Wfo2ckohi4P3tpZBRkqOv656feA50eHGM+D7NdhDNm1uH9rGbmtaoxpNyNwIY2IFeM18oqYsECwsng/rNMieeLvozMy+X/LMP/YkL2y7VZhOVL3lVIDa3y47+Q5nskVLO0rlmRs1KloHNYBDgzCVnGtOdFswbAcWdhEatFZclipMjYKTsDNhDWnS9AZZlppJxuaLi5nwN+/kr9CbZ0mlt4rfekYNp24gkZoITaMWsHChszzaEB2mjiXMTUgvGjzpbBa3SIWb0rUnJlPqjfVs+EtBxgvEOlMScpIJEsqIWjiPCbq3yHq1tyuBDNWWLA4+nCIhMWWK2GYUT/7Xzw0ColBuC/Pl0geLte4O047kn3+ctku59OGnqN+M2i+FxNEACn6zdUzFdqM9sYQAzo1GJNhIh/f02yutfar7GHkyND2uz4QjvKJsXopsRxv4c2SMRpZU53eJbHUl4Ii11syIjKlHIeDbykqH1XDeA3J4mePvOQ4MINmjc1Ogv4IyKt7EImL13C9Yuk4132/rb2V8FXTxudHK+R6bt5FkbKVZClprbgnhCG4y5oC+aCMeY1Sn1Gs7ZZyNLTKlPLV0c1zHto6tF7jwPiT293FAt67Yrs5mEZ9KFeGDArahPBoPFdo9FRsL/RaN7Sy66db/sKbQT60= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(39860400002)(136003)(346002)(366004)(451199015)(66899015)(2906002)(31686004)(54906003)(5660300002)(41300700001)(8936002)(66556008)(316002)(6916009)(66476007)(66946007)(4326008)(8676002)(478600001)(6486002)(36756003)(26005)(6512007)(2616005)(186003)(6506007)(38100700002)(86362001)(31696002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzVHd0JieUlQQ0doSnM3cHdVZnVCTmsvQlhrYlBsUTJuZjk5aEpXSmQ2a3pw?= =?utf-8?B?a1BmaUhDWmpJK0lmYTVNRnA3UXJHbkJqVU9NZnBITXR2MFNERy9ZR1c2VFlo?= =?utf-8?B?V0VlaEczNnFVbmcwYm5zbFRPK2dvdllLR29PbXFXV2RkQnlSaEthSUtWMk9t?= =?utf-8?B?VDk1U2RrMEhFTURjUkxGZTJseWVJRktZcUdnZ3Yxc2pRQTJhNm5UMGExOTVi?= =?utf-8?B?NHRMVWhLWjlqTzYvRnU5SjZSSnBuNGFqV3RQL0Z2azFFZndpK3p3NzI3cDVo?= =?utf-8?B?OS9UNW9yRWFHK3A0OENuSnlxSFVjSXVnajVMVjUwUHZTeWhHRWs1M1Fod0dF?= =?utf-8?B?KzJYV2dOcVdlWjkzcnFqeDVYZmxxalZLNVhZbnFjUTI0aVRxNmp3Nk0rMkk5?= =?utf-8?B?aXNDR29GODlCK0EwdTlROTNWVzFZSllVWlJGRVJDV2JKZ3hCSjlFMzBSVmtP?= =?utf-8?B?UGpyUFdyRFErbFFRaTBMcFo0dW5qSUU0SDlpdGR5QXpxOU9IalNIZDVKR0Ur?= =?utf-8?B?TVFxSk9IRU9jSjJrWms5OTl5a2lzdVA5MnV6bWlxMVhXdUlxckxKYzhHWWNM?= =?utf-8?B?Y09qLzZNakRYc1IrOW1tT2c4TklBclZ5QUxldm5tTk1nVHU3M29BbVhXd0Na?= =?utf-8?B?RTVXZnMyQUNYU0FZNGo3TnErTFBIVzl4S2R2bHc3T1N5eDdNaklER1RFZEts?= =?utf-8?B?VjdRTDJGb0plaVRxMjc4SjZIdVJJMnh4cTEyMUN3dG82WUo0V01EWmxINHM0?= =?utf-8?B?NW90a1VuUzlHTnhIbzh5ZGw1dEJnZUhqWmFDNzRreUVXZndaU3lETkw1Um8v?= =?utf-8?B?cGlHSnZQNTl5WG1vSnM1WSs2dUhJWFZaRUwyU2l3TlNmenhWejZCS2hKQmMv?= =?utf-8?B?UjI3ZG1reTJFTWxUZWRsTytZeHVIWUZCWG1zQmxDeFRGTVdZWDBzZE14UDg2?= =?utf-8?B?UTU2ODJoMW42S3VXNUNEdHBBb3dmRTVxcElDanMzaHJXQVQwUWZaZUVQekdP?= =?utf-8?B?R0NwQ3pYVDVoaWlVS3liSUFIUHJIZlgzajVRbzkyTlVyMFNBeTBJd2RMTHl5?= =?utf-8?B?TE9PalNycUxHVWdxQ2hnY1JuY25DeEVhY0dybXRkYVZZeWdIdFV2bmw0WU5Y?= =?utf-8?B?bERLdGtyZElXL3NLSFpaY3BiV3VYSHJDMXVYY3lkbFdYQmxwb0dWWDhBbW1T?= =?utf-8?B?UzhJeVR1KzZMeHhLMllhblYrdjVuS0hWd1ZtREVWMVlKZmJqaHhyM1dYT0RF?= =?utf-8?B?WXgxM1Izd2FzYlNRN0trcUVsa2dOQ2wxUDBnaGI3MEhoRFNFbzRLZElOOFhD?= =?utf-8?B?UGkyZ09lMlp2SUlRcloxeFE3SVB1WkZRWDdaUGs2cm9aK2EvaHJCMTRJdnA0?= =?utf-8?B?YlprZjRrSU5rQWxsTU56MWVhbzdxTGRuOWozODZpYklwRVZKS2xsd25kMkN6?= =?utf-8?B?Sk5FWjlUazdOS1J5UXpjOThlRlJ6R2pWMFhhSEoxM1FGSW9Bek1kNkhiRndq?= =?utf-8?B?K2FtTlJhcEJHb2JQb2k1QmttYUtUenF4d242aStuRTR4M3pac2ZxSkUvY3pY?= =?utf-8?B?bnBNWFMvQ1NPZEJDYTFQdnJYcDBYa2RjR0xMZm9BaFE4QjB6T01Vd1l6blpG?= =?utf-8?B?NVIvUi9Ha1F5Qm4wbGs3a09iUmRJejVlU2c5QlNQTEpPZEhqQ2ZFRlpRT096?= =?utf-8?B?NmkrUEViM3IrSzQ5eEowZ0sycUp6cmVxdlh0NEE0TkEweFNzbEFHbFhnbnVv?= =?utf-8?B?QjBCeEhYOGVnS083TENtRjJ6N1I1TUpaTG9GVkhTOVB5QzVnQ2UwZmRFaXdv?= =?utf-8?B?T1krM2UzR0I5VHU2MUQwdERaVTJ2TmRxc1pOYUZmSllLZlJTdW5IZ255blpw?= =?utf-8?B?aUVJV0lNL3FxMjI3ZCs3SGQzdjVKV0MvSzg3dlBJYzdUUk5PNm1QV0RZTjZD?= =?utf-8?B?NXQvTThoa3NyMGZ3b1YxdWRuNElGN3A1R3IxRnY2aWFiV1hKK0hpSnh0ZTB3?= =?utf-8?B?R1FtUityTlFrSzNLdjZEQWQ3UTArMUg2ZDNlcVB0WXlBcU8yMjlzTVIrckxm?= =?utf-8?B?TWUzOGdRWE13YXpzMWVnRWtndldFQ2ZUaitYYnJ4Qlg5VTQzME5ialEyUUhO?= =?utf-8?Q?vhmp1SyvplYkOrDVqyFcO1XS1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e53daca-9469-48b2-8ed3-08dad219cc3c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 14:55:47.0288 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6584UM81BzdeddfXSdLrcu5W+mXOVQ9sd/giixj0qR2S7iyeLeW1G6zZSXMXFIx6lh+Qc/aVmttBNBoJMWZD5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8152 By defining the constant to zero when !SHADOW_PAGING we give compilers the chance to eliminate a little more dead code elsewhere in the tree. Plus, as a minor benefit, the general reference count can be one bit wider. (To simplify things, have PGC_page_table change places with PGC_extra.) Signed-off-by: Jan Beulich --- tboot.c's update_pagetable_mac() is suspicious: It effectively is a no-op even prior to this change when !SHADOW_PAGING, which can't be quite right. If (guest) page tables are relevant to include in the verification, shouldn't this look for PGT_l_page_table as well? How to deal with HAP guests there is entirely unclear. --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -70,9 +70,9 @@ /* Page is Xen heap? */ #define _PGC_xen_heap PG_shift(2) #define PGC_xen_heap PG_mask(1, 2) - /* Set when is using a page as a page table */ -#define _PGC_page_table PG_shift(3) -#define PGC_page_table PG_mask(1, 3) + /* Page is not reference counted */ +#define _PGC_extra PG_shift(3) +#define PGC_extra PG_mask(1, 3) /* Page is broken? */ #define _PGC_broken PG_shift(4) #define PGC_broken PG_mask(1, 4) @@ -83,12 +83,20 @@ #define PGC_state_offlined PG_mask(2, 6) #define PGC_state_free PG_mask(3, 6) #define page_state_is(pg, st) (((pg)->count_info&PGC_state) == PGC_state_##st) -/* Page is not reference counted */ -#define _PGC_extra PG_shift(7) -#define PGC_extra PG_mask(1, 7) +#ifdef CONFIG_SHADOW_PAGING + /* Set when is using a page as a page table */ +#define _PGC_page_table PG_shift(7) +#define PGC_page_table PG_mask(1, 7) +#else +#define PGC_page_table 0 +#endif /* Count of references to this frame. */ +#if PGC_page_table #define PGC_count_width PG_shift(7) +#else +#define PGC_count_width PG_shift(6) +#endif #define PGC_count_mask ((1UL< Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 14:57:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449466.706225 (Exim 4.92) (envelope-from ) id 1p023I-0002EV-Fk; Tue, 29 Nov 2022 14:57:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449466.706225; Tue, 29 Nov 2022 14:57:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p023I-0002EO-CW; Tue, 29 Nov 2022 14:57:40 +0000 Received: by outflank-mailman (input) for mailman id 449466; Tue, 29 Nov 2022 14:57:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p023G-0002EH-FU for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 14:57:38 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2060e.outbound.protection.outlook.com [2a01:111:f400:7e8a::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 28ef19ea-6ff6-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 15:57:36 +0100 (CET) Received: from BN0PR04CA0193.namprd04.prod.outlook.com (2603:10b6:408:e9::18) by BL1PR12MB5349.namprd12.prod.outlook.com (2603:10b6:208:31f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 14:57:31 +0000 Received: from BN8NAM11FT030.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e9:cafe::5c) by BN0PR04CA0193.outlook.office365.com (2603:10b6:408:e9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Tue, 29 Nov 2022 14:57:31 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT030.mail.protection.outlook.com (10.13.177.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.17 via Frontend Transport; Tue, 29 Nov 2022 14:57:31 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 29 Nov 2022 08:57:31 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 29 Nov 2022 08:57:29 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28ef19ea-6ff6-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ct89+vPn8YHn/Z+rysW82mxplGST0r1QHX8DeCE+1P5aQizUM1GycXrx6JQXiBaAqVVk4KxsYHz4/ludiPEDG2R7/ozmYChYbhC/BskPUlufQvOmIudVZYg/nBVKpFij+YGYIRsOB9nOqm3olLG2Pr5qTFhwS0x+GZcWf6CIpSClYeosgBxhlUVmPMEG97d2UY3vn5mNM3gXt58sMRxA5JcY3/mtOim+t0afoFGQlonOwVyNiR8iw+eG1PlNzFH2o0RLZWj7POh6G8KMxAYrD5JOtlWyvckcQsJroYzCyL8pAIG8FJZXfBMl90qch2J/Tr6+YVd2T1/9LWJVFzUV6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fQkHAGdo28qgEpOGbopxtEjLtVwwj8O3SB9N5LuZrpg=; b=m0CbcmdZwmnvWfi4E5TzEnFT4zTyQpvHacANu/uNtLykikwN9IzoIy9JDkmh0mv8NW9hv+sI4/lN+CMMpk0DO7U30ySIcfj2/5LOJvmG8fwShqu8nNOTUbL0nkWjfC6ifr0MGF0UKy4yUPafnbJCgN74jhmkvnMppjzWpwsePUN47nEXpuf1xztjYXTMue9XIwgLhh1ujGJnNArsDo8rWZWrHNpS679MM63No6KRdON6ufqGzVgzmLlfw9pzLw9q6GMbifB2SCARPlbeQHZQinR/DKvXKETSeHdrJ72bYxWyJ3R4qDYCAB1a0kV5GV5FLdoweKZs0vFRLoKlHsWb6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fQkHAGdo28qgEpOGbopxtEjLtVwwj8O3SB9N5LuZrpg=; b=Be0Ya+3yoWD4pE4krUC7gG9PnLj+OGgma2HOTwmRXxCxZqGtim33ndRPzxlHOeVj/b2qO7JRr2lYBcidOD4h+EBSsEt7stkD7gVfDkj8eh0IXIvxzOGpqSH8c0qRjS8N8HvcjmamKUVD7kyHrdlCG0yLjxQOs1w5O4TmBvrapro= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <4009fec8-4bd7-afe5-49d5-89deb4d132c4@amd.com> Date: Tue, 29 Nov 2022 15:57:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN v4 09/11] xen/Arm: GICv3: Define remaining GIC registers for AArch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> <20221128155649.31386-10-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20221128155649.31386-10-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT030:EE_|BL1PR12MB5349:EE_ X-MS-Office365-Filtering-Correlation-Id: 7aab5040-9e98-4972-9a51-08dad21a0aa2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YzKh/weJG0LhS8sdujZy5PQWwG1gyH264kILu4gBvcIIn1naX6zE18/88lrbgA4lbbYYnVEA11gqc597i0e5CCLM1s25Hc/udn6ZQJj5zGa4IU0JUuWA6z/CL6i0i3IY70ZGT3E4CcV1TpWnBVB+Fyo6ILUuv8W97WEXNEU3ia57QIxX76I4cvHisraBt/vI00CWdK71wZh6Y5P529EWfDNYa+5KwOPUvEMWNZlpT7SETmli3DAFEPU5KqHI41IVFf08OMTOSsFgl/3lCPfGk/gbzEAlIpY4c2naNrAmHA6Sbs2oWg6LEvGSdzvhOf3SGDfizgv2vf2gkHHGvqKCQD9u+ytpTEsCCarsX6qtwl06N/sec/pFrcScsA9O+4cX5FFbBrUPG79Emd3QSXDxsPhjQLa3Tl0THckj3uTXh3bJ5KAAYxaxNsOwtmY5/ZvstJ4JJAvK4MJZZqdNbfzpqx+fJg/IPxIPiOGuyoEg8nD2ux30aoIsOMTdWBZ5KPGDjDWn3ITeHzP/E8s1lukcW+nQoGxRrgOUY4ykw9HAdvqdkl8U5TjFYvARYqGrdSNbpCpjFb9fpShEKTPNNjvBoAV+2X9khxTYa6mGRb/1im9XjUOQC7kB6TbpmcT4NS3juANIqPuCg0eLX/NiZ2bKhNCs9i7J4KkWbPVUEosBbEqLHAxaWZvGNTOq9uKR+6wfWj6mLHvxkqalEq1WT7PF3xlQI7c/tHOvXuYS9lU6xz6m73JEneufSB1dIgRZ8Qh3DkeKQ45HkVemHTTkuKb/nQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(136003)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(5660300002)(44832011)(31686004)(4326008)(8676002)(8936002)(41300700001)(110136005)(40460700003)(81166007)(356005)(54906003)(2906002)(70586007)(70206006)(16576012)(316002)(478600001)(36756003)(336012)(86362001)(31696002)(53546011)(26005)(186003)(2616005)(36860700001)(83380400001)(82310400005)(426003)(82740400003)(47076005)(40480700001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 14:57:31.5288 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7aab5040-9e98-4972-9a51-08dad21a0aa2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT030.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5349 Hi Ayan, On 28/11/2022 16:56, Ayan Kumar Halder wrote: > Define missing assembly aliases for GIC registers on arm32, taking the ones > defined already for arm64 as a base. Aliases are defined according to the > GIC Architecture Specification ARM IHI 0069H. > > Defined the following registers:- > 1. Interrupt Controller Interrupt Priority Mask Register > 2. Interrupt Controller System Register Enable register > 3. Interrupt Controller Deactivate Interrupt Register > 4. Interrupt Controller End Of Interrupt Register 1 > 5. Interrupt Controller Interrupt Acknowledge Register 1 > 6. Interrupt Controller Binary Point Register 1 > 7. Interrupt Controller Control Register > 8. Interrupt Controller Interrupt Group 1 Enable register > 9. Interrupt Controller Maintenance Interrupt State Register > 10. Interrupt Controller End of Interrupt Status Register > 11. Interrupt Controller Empty List Register Status Register > 12. Interrupt Controller Virtual Machine Control Register > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel with one remark... > --- > > Changes from :- > v1 - 1. Moved coproc regs definition to asm/cpregs.h > > v2 - 1. Defined register alias. > 2. Style issues. > 3. Defined ELSR, MISR, EISR to make it consistent with AArch64. > > v3 - 1. Rectified some of the register names. > > xen/arch/arm/include/asm/cpregs.h | 32 +++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h > index 53142fc2b2..8f4d097a15 100644 > --- a/xen/arch/arm/include/asm/cpregs.h > +++ b/xen/arch/arm/include/asm/cpregs.h > @@ -163,6 +163,7 @@ > #define DACR p15,0,c3,c0,0 /* Domain Access Control Register */ > > /* CP15 CR4: */ > +#define ICC_PMR p15,0,c4,c6,0 /* Interrupt Priority Mask Register */ > > /* CP15 CR5: Fault Status Registers */ > #define DFSR p15,0,c5,c0,0 /* Data Fault Status Register */ > @@ -256,6 +257,7 @@ > > /* CP15 CR12: */ > #define ICC_SGI1R p15,0,c12 /* Interrupt Controller SGI Group 1 */ > +#define ICC_DIR p15,0,c12,c11,1 /* Interrupt Controller Deactivate Interrupt Register */ Shouldn't ICC_DIR be placed after VBAR? > #define ICC_ASGI1R p15,1,c12 /* Interrupt Controller Alias SGI Group 1 Register */ > #define ICC_SGI0R p15,2,c12 /* Interrupt Controller SGI Group 0 */ > #define VBAR p15,0,c12,c0,0 /* Vector Base Address Register */ > @@ -281,6 +283,20 @@ > #define ICH_AP1R2 __AP1Rx(2) > #define ICH_AP1R3 __AP1Rx(3) > > +#define ICC_IAR1 p15,0,c12,c12,0 /* Interrupt Controller Interrupt Acknowledge Register 1 */ > +#define ICC_EOIR1 p15,0,c12,c12,1 /* Interrupt Controller End Of Interrupt Register 1 */ > +#define ICC_BPR1 p15,0,c12,c12,3 /* Interrupt Controller Binary Point Register 1 */ > +#define ICC_CTLR p15,0,c12,c12,4 /* Interrupt Controller Control Register */ > +#define ICC_SRE p15,0,c12,c12,5 /* Interrupt Controller System Register Enable register */ > +#define ICC_IGRPEN1 p15,0,c12,c12,7 /* Interrupt Controller Interrupt Group 1 Enable register */ > +#define ICC_HSRE p15,4,c12,c9,5 /* Interrupt Controller Hyp System Register Enable register */ > +#define ICH_HCR p15,4,c12,c11,0 /* Interrupt Controller Hyp Control Register */ > +#define ICH_VTR p15,4,c12,c11,1 /* Interrupt Controller VGIC Type Register */ > +#define ICH_MISR p15,4,c12,c11,2 /* Interrupt Controller Maintenance Interrupt State Register */ > +#define ICH_EISR p15,4,c12,c11,3 /* Interrupt Controller End of Interrupt Status Register */ > +#define ICH_ELRSR p15,4,c12,c11,5 /* Interrupt Controller Empty List Register Status Register */ > +#define ICH_VMCR p15,4,c12,c11,7 /* Interrupt Controller Virtual Machine Control Register */ > + > /* CP15 CR12: Interrupt Controller List Registers, n = 0 - 15 */ > #define __LR0(x) ___CP32(p15, 4, c12, c12, x) > #define __LR8(x) ___CP32(p15, 4, c12, c13, x) > @@ -381,6 +397,15 @@ > #define HCR_EL2 HCR > #define HPFAR_EL2 HPFAR > #define HSTR_EL2 HSTR > +#define ICC_BPR1_EL1 ICC_BPR1 > +#define ICC_CTLR_EL1 ICC_CTLR > +#define ICC_DIR_EL1 ICC_DIR > +#define ICC_EOIR1_EL1 ICC_EOIR1 > +#define ICC_IGRPEN1_EL1 ICC_IGRPEN1 > +#define ICC_PMR_EL1 ICC_PMR > +#define ICC_SGI1R_EL1 ICC_SGI1R > +#define ICC_SRE_EL1 ICC_SRE > +#define ICC_SRE_EL2 ICC_HSRE > #define ICH_AP0R0_EL2 ICH_AP0R0 > #define ICH_AP0R1_EL2 ICH_AP0R1 > #define ICH_AP0R2_EL2 ICH_AP0R2 > @@ -389,6 +414,10 @@ > #define ICH_AP1R1_EL2 ICH_AP1R1 > #define ICH_AP1R2_EL2 ICH_AP1R2 > #define ICH_AP1R3_EL2 ICH_AP1R3 > +#define ICH_EISR_EL2 ICH_EISR > +#define ICH_ELRSR_EL2 ICH_ELRSR > +#define ICH_HCR_EL2 ICH_HCR > +#define ICC_IAR1_EL1 ICC_IAR1 > #define ICH_LR0_EL2 ICH_LR0 > #define ICH_LR1_EL2 ICH_LR1 > #define ICH_LR2_EL2 ICH_LR2 > @@ -421,6 +450,9 @@ > #define ICH_LRC13_EL2 ICH_LRC13 > #define ICH_LRC14_EL2 ICH_LRC14 > #define ICH_LRC15_EL2 ICH_LRC15 > +#define ICH_MISR_EL2 ICH_MISR > +#define ICH_VMCR_EL2 ICH_VMCR > +#define ICH_VTR_EL2 ICH_VTR > #define ID_AFR0_EL1 ID_AFR0 > #define ID_DFR0_EL1 ID_DFR0 > #define ID_DFR1_EL1 ID_DFR1 ~Michal From xen-devel-bounces@lists.xenproject.org Tue Nov 29 15:03:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 15:03:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449472.706235 (Exim 4.92) (envelope-from ) id 1p028L-0003q0-2m; Tue, 29 Nov 2022 15:02:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449472.706235; Tue, 29 Nov 2022 15:02:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p028K-0003pt-WA; Tue, 29 Nov 2022 15:02:52 +0000 Received: by outflank-mailman (input) for mailman id 449472; Tue, 29 Nov 2022 15:02:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p028J-0003pn-1O for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 15:02:51 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on20630.outbound.protection.outlook.com [2a01:111:f400:7e8b::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e3319eff-6ff6-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 16:02:49 +0100 (CET) Received: from BN0PR04CA0079.namprd04.prod.outlook.com (2603:10b6:408:ea::24) by MN2PR12MB4439.namprd12.prod.outlook.com (2603:10b6:208:262::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 15:02:45 +0000 Received: from BN8NAM11FT031.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ea:cafe::a7) by BN0PR04CA0079.outlook.office365.com (2603:10b6:408:ea::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Tue, 29 Nov 2022 15:02:45 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT031.mail.protection.outlook.com (10.13.177.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.17 via Frontend Transport; Tue, 29 Nov 2022 15:02:45 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 29 Nov 2022 09:02:45 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 29 Nov 2022 07:02:44 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 29 Nov 2022 09:02:43 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3319eff-6ff6-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=exfY5MBCZyuv8+pj2soR4sgdavnpwCgdOZeutj/KttthVzxSYubIt8JxcHcykH16xIkdPu8V586mDFh1SBkL4Ub8hbB9H4Q2W5ds1g1p7Q2OKjDoMe5JkU23eFVJafuxJmWZ7rc+Qqcv0IbWVIzXvCzdvQMwPz3Apiwm3Gv9gF0e3m+4+d7EUaOT7t9MgQRAPD+srfz9k4gb8pHjxAzTa/MV7sx9BFmvmFmElcx13lyb79uiIwnCTMj3R6C2s9SUOmxzBhYewQjIOSmODYlCbi8MWB+7pKy0M5zcOGdPPYwwgbeZPAFOao37+iafdvofHh357D8CAY7CEuuj0Hlk0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BoPvd3sa3RBD8P+HoEBR8TADvF00Wx35FeNQ6pJDlLA=; b=iXA8+6azqBH6LHPxgkzztKBSSTp+B/iWSUPs6PhhaCUDvU7lFRZTPdUMrv9AhlWyOTEDRWDPbRZbFAkeUjqPB3EsvnD90kJXLcBiU0aKjC1uhnzrAsRCVaDBpFeH12NnRgMPwR8NTbsdPm7IWFNYE1EpzJCbfQn8/DWuaNC/FP243k7NlfAqFFCcmo2PPlhA8kchFA4uZCBqNEGHG0Lm+I93kMIoSDkkWGJpzcuqHNkoP1wDebMxLhGluRtwjodmOMvXor02BkBQB/LFmBJ4IeXa/r6/DM+Jt68o+NLj7TQzmkBC4icIypuBiHq+BQF5D8LHlvYaqEQSyCnmCOFoZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BoPvd3sa3RBD8P+HoEBR8TADvF00Wx35FeNQ6pJDlLA=; b=BhvQPeCC+f4afmrZWgJr6EyHCiydh4uxO7n2AkXhZ2QDA7U0zwgCQYgglDy/NH1ZG9Fgj7+ZA3dThR9FrCZyqvCt9WmtDegLV5/GlE2yjdVUbdabrb4IM5JnjFTU3QLBuISn4wXkJet0m048u9Izu+lsKqJkg7m0HjY/Viox8wo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Tue, 29 Nov 2022 16:02:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN v4 11/11] xen/Arm: GICv3: Enable GICv3 for AArch32 Content-Language: en-US To: Ayan Kumar Halder , CC: , , , , , , References: <20221128155649.31386-1-ayan.kumar.halder@amd.com> <20221128155649.31386-12-ayan.kumar.halder@amd.com> From: Michal Orzel In-Reply-To: <20221128155649.31386-12-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT031:EE_|MN2PR12MB4439:EE_ X-MS-Office365-Filtering-Correlation-Id: fbfe2f5d-4477-48ce-01b8-08dad21ac5ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qnky/e8dNH+g2pBKRLc6/nc2nguLplkj/aBAb4LyaVxIJoTAN7JQdMPaGV3/aAyOiOKmQyrsYuVfmDXFQZvu32Cmbios8eih4HB30EpyTlcTua5XoS8+a+hnjYiZLrpd/FX1hhdv8PLCbp1JcnRkvP1aDjp5MMtbycDt8Uj82aGIVKYiv/7jAZUvnJOZegiDxqnW4LZi3NxMjE0wb6idJyKPIOK1ADVE5cIq4Nl7+MPN6OPP/zTk4XfDqF69Y6y+UTgYD6/MwkbxUUX24q5KLzrcqr8ww53/DzaCmdVCQ6LfcPFKTySl9/M54/kofY95xBf9IiRSDuAPLNLGvCKUxtiZ3I+G3n8BLYJNN/plPO6eeJg3ujTjPyI3f1pI2ikDPoUDRMzJM2iyP6/ak8CTD5iF/ZoCLNUln1D339KW+YZ5WTeav6YmE5JExjc5YTbFHD19wVjhneHz7gPDBmLWDhqwo9f6XfiM600/ERzE4VPQdJcoGbnNZxiC38+qfS28ZawRHxNCcUCZrqgf9n1sZi1tQIjaZc4c/F4Ke5Z1Rn6RdnkSsWJp0I4B2PFvigK/UKIVbLWWzGieEkLVgmw/Jwwb1Nz74/BVrT6sn/ZOqIXV+5T2MeKzSoBeoQ0CdmIthOOfC8989A15WVGzqDeSMIQsj5X7xNkA9LOlc/sjvQxr22fd73azMLvQa/5df9iPIleXov5mE37p8HERC5XtiyfRZ/xZCYcgb2GI2UCUiowlf20xfKLsucYdgKtNy5+amQ0eihgxS3GfNHbfu789NA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(39860400002)(376002)(451199015)(46966006)(40470700004)(36840700001)(2616005)(31686004)(36860700001)(2906002)(83380400001)(70206006)(356005)(70586007)(41300700001)(478600001)(8676002)(40460700003)(36756003)(82310400005)(53546011)(82740400003)(26005)(81166007)(40480700001)(186003)(336012)(426003)(8936002)(5660300002)(47076005)(31696002)(4326008)(86362001)(110136005)(54906003)(44832011)(4744005)(316002)(16576012)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 15:02:45.5210 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fbfe2f5d-4477-48ce-01b8-08dad21ac5ca X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT031.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4439 Hi Ayan, On 28/11/2022 16:56, Ayan Kumar Halder wrote: > One can now use GICv3 on AArch32 systems. However, ITS is not supported. > The reason being currently we are trying to validate GICv3 on an AArch32_v8R > system. Refer ARM DDI 0568A.c ID110520, B1.3.1, > "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE must not > implement LPI support." > > By default GICv3 is disabled on AArch32 and enabled on AArch64. > > Updated SUPPORT.md to state that GICv3 on Arm32 is not security supported. > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Tue Nov 29 15:12:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 15:12:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449480.706247 (Exim 4.92) (envelope-from ) id 1p02HA-0005TP-VS; Tue, 29 Nov 2022 15:12:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449480.706247; Tue, 29 Nov 2022 15:12:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02HA-0005TI-S3; Tue, 29 Nov 2022 15:12:00 +0000 Received: by outflank-mailman (input) for mailman id 449480; Tue, 29 Nov 2022 15:12:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02HA-0005TC-Ac for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 15:12:00 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29caf6a0-6ff8-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 16:11:58 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29caf6a0-6ff8-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669734718; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=FKAcdCfqcGrJYFfhNECxRdqUbzNbMUCLFKQUQIe3/uU=; b=OXU0NGo4VmiLgzd+iZwLE5+GDf2eu/yfHdmL0deZymzf6WCFogQE6Zkn 3TfJ2mo8QRCJuJSdZdqowRGx8qtwwFkrGy6CdsGhz8yQjqxjTIKLxc9NZ oceRq4Agy9nJd15tQZHqe9Lrpnzn06CyPPjeMqPMJYi9KUL9kfbNnBj9x I=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 88308420 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:sWt9j6354+v2TVIF5/bD5VVxkn2cJEfYwER7XKvMYLTBsI5bp2ZTy TMcDWqHb6zZNGb8Lot/bd6zo0MFvZXcmtNnTQtkpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVkNKgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfJnl/+ +AaDA43SwGC3dqKg4iCGulRv5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKkSbC/FMEg5/5JYWpOqywFP+dyZVgFmUubA28y7YywkZPL3FYIqOIozWH509ckCwq Wno8WX7WC0hNsHEyn3Y3nyPvtHItHauMG4VPOLhraM76LGJ/UQZDwcXTh28uuWjjVClWMN3L FYd8S4j66M18SSDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHt7mYSmmU8LuOmi+jIigeLWIEZigsQBMM5p/op4RbphbOSMtzVa24lNv4HRnuz D2Q6isznbMeiYgMzarT1VLImTW3vbDSUxU4oA7QWwqN9RhlbYSoY4ip71nz7vtaKoudCF6bs xA5d9O2tb5US8vXzWrUHbtLTOrBC+u53CP0pkZeEYUj0wqX3m+iJ7hsowtHdEdUC5NREdP2W 3P7tQRU7Z5VGXKla65rfo68Y/gXIbjc+cfNDa6NMIcXCnRlXErepXw1OxbMt4z4uBJ0+ZzTL 6t3ZipF4ZwyLa18hAS7SO4GuVPA7nBvnDiDLXwXIvnO7FZ/WJJ3Ye1dWLdtRrpjhE9hnOky2 4g3Cidy408DONASmwGOmWLpEXgELGIgGbf9oNFNe+iIL2JOQT9/WqGPmehwK9M6wcy5c9skG VnkCidlJKfX3yWbeW1mlFg8AF8QYXqPhS1iZnF9VbpZ83MifZyu/M8im2gfJNEaGBhY5acsF ZEtIpzQasmjvxybo1zxm7Gh9t09HPlq7CrSVxeYjM8XJcQ6GlSXpI+8I2MCNkAmV0KKiCf3m JX4viuzfHbJb1QzV646tNrHI4uNgEUg IronPort-HdrOrdr: A9a23:2/a/mqlzZccVWZBw3+DcwPBe/xjpDfIg3DAbv31ZSRFFG/Fxl6 iV8sjzsiWE7Ar5OUtQ/+xoV5PhfZqxz/JICOoqTNKftWvdyQiVxehZhOOIqVDd8kXFh4lgPM xbEpSWZueeMbEDt7eZ3DWF X-IronPort-AV: E=Sophos;i="5.96,203,1665460800"; d="scan'208";a="88308420" From: Per Bilse To: CC: Per Bilse , Juergen Gross , "Stefano Stabellini" , Oleksandr Tyshchenko , Boris Ostrovsky , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Subject: [PATCH] drivers/xen/hypervisor: Expose VM SIF flags to userspace Date: Tue, 29 Nov 2022 15:00:57 +0000 Message-ID: <20221129150058.266943-1-per.bilse@citrix.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain /proc/xen is a legacy pseudo filesystem which predates Xen support getting merged into Linux. It has largely been replaced with more normal locations for data (/sys/hypervisor/ for info, /dev/xen/ for user devices). We want to compile xenfs support out of the dom0 kernel. There is one item which only exists in /proc/xen, namely /proc/xen/capabilities with "control_d" being the signal of "you're in the control domain". This ultimately comes from the SIF flags provided at VM start. This patch exposes all SIF flags in /sys/hypervisor/properties/flags, which will coexist with /proc/xen while dependencies are being migrated. Possible values are "privileged", "initdomain", "multiboot", "mod_start_pfn", and "virtmap", with "initdomain" being the equivalent of "control_d". Signed-off-by: Per Bilse --- drivers/xen/sys-hypervisor.c | 26 ++++++++++++++++++++++++++ include/xen/interface/xen.h | 13 ++++++++----- 2 files changed, 34 insertions(+), 5 deletions(-) diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c index fcb0792f090e..7393e04bdb6d 100644 --- a/drivers/xen/sys-hypervisor.c +++ b/drivers/xen/sys-hypervisor.c @@ -379,6 +379,31 @@ static ssize_t buildid_show(struct hyp_sysfs_attr *attr, char *buffer) HYPERVISOR_ATTR_RO(buildid); +static ssize_t flags_show(struct hyp_sysfs_attr *attr, char *buffer) +{ + static char const *const sifstr[SIFN_NUM_SIFN] = { + [SIFN_PRIV] = "privileged", + [SIFN_INIT] = "initdomain", + [SIFN_MULTI] = "multiboot", + [SIFN_PFN] = "mod_start_pfn", + [SIFN_VIRT] = "virtmap" + }; + unsigned sifnum, sifmask; + ssize_t ret = 0; + + sifmask = ~(~0U << SIFN_NUM_SIFN); // ...0000111... + if (xen_domain() && (xen_start_flags & sifmask) != 0) { + for (sifnum = 0; sifnum != SIFN_NUM_SIFN; sifnum++) { + if ((xen_start_flags & (1<M making the 3 level tree obsolete? */ #define SIF_PM_MASK (0xFF<<8) /* reserve 1 byte for xen-pm options */ -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Tue Nov 29 15:15:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 15:15:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449485.706258 (Exim 4.92) (envelope-from ) id 1p02KO-00068R-G5; Tue, 29 Nov 2022 15:15:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449485.706258; Tue, 29 Nov 2022 15:15:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02KO-00068K-DH; Tue, 29 Nov 2022 15:15:20 +0000 Received: by outflank-mailman (input) for mailman id 449485; Tue, 29 Nov 2022 15:15:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02KN-00068E-2z for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 15:15:19 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a0ba39c5-6ff8-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 16:15:16 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 66EC55C00CF; Tue, 29 Nov 2022 10:15:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 29 Nov 2022 10:15:15 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 29 Nov 2022 10:15:12 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0ba39c5-6ff8-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1669734915; x= 1669821315; bh=Sselh9PMPp+YXx0b/8C6fFInUaOfP3jD6verSMjxhVM=; b=D SbZ+WdKDRP/8Ypqbx8RaSRttN5rGOWO/bLOlkeUbmzjI8JMMdgkk9WBc5xuFGmin dMUt0C/5vW3ZOkPLapoxIHRKZD6KVz9LXx3L5UKnQEDLx7HfsWB1VcBndcHVf9dH H4lXZPp0LrunYuxuaAkTvg/PLAXs441upTNf0cC9o7GT7EVqI5AS2RhxMyNt3RCO sgg5vTtt2DoBO4sPieGeVlxmwJB29PLkMY7SVDfocT4styC6lsXIT9Ngko9XeJxl PVMai/wQ+ikjL3RIflAX6GunDAd0qIlXj2dMha+DlsSiLCRl57xfB+2vzXLPCvGc ZM8rRMeCgGMi5sck4j2Qw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1669734915; x=1669821315; bh=Sselh9PMPp+YXx0b/8C6fFInUaOf P3jD6verSMjxhVM=; b=NQu39eszLsMlTbbZhV5nP6SPUjLTkF7cqZm3BjAcH9yA qx89mT1+eh3XNBPr3AHrkBncoJVrM1H2K7rxbnbP4V17uJNVJffDKuBtsuop9Aul dXpq3ozSWfbENecyWH1Btm78kVHbU1u1Bor9clnIKSq6LUMQnqfMJnjV2sQCHVto 7suWA2+qdkqDIRQ9lmYwugbfUDADCHsCujHzodkRCEETV7GZ0QpcMqX0PI0Hc17d FhNS/+O4+wzxX3Cku1iWLrMcKAdHvKF+yIyKlZcm/+Aew/VBMC2BBku8cvHgUhHJ jgIjTr0NHjqt0rUIpgUddBP46LpooqnwbRR9hM/cXw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtddtgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetueeg fefhffdvffetleeltdelkedvlefhkeehgfehhffhheehudeitdegheejleenucffohhmrg hinhepkhgvrhhnvghlrdhorhhgpdhgihhthhhusgdrtghomhenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhish hisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 29 Nov 2022 16:15:10 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Alex Deucher Cc: Demi Marie Obenour , christian.koenig@amd.com, Xen developer discussion , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: Re: AMD GPU problems under Xen Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ldwT7sa60O/uU5QD" Content-Disposition: inline In-Reply-To: --ldwT7sa60O/uU5QD Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 29 Nov 2022 16:15:10 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Alex Deucher Cc: Demi Marie Obenour , christian.koenig@amd.com, Xen developer discussion , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: Re: AMD GPU problems under Xen On Tue, Nov 29, 2022 at 09:32:54AM -0500, Alex Deucher wrote: > On Mon, Nov 28, 2022 at 8:59 PM Demi Marie Obenour > wrote: > > > > On Mon, Nov 28, 2022 at 11:18:00AM -0500, Alex Deucher wrote: > > > On Mon, Nov 28, 2022 at 2:18 AM Demi Marie Obenour > > > wrote: > > > > > > > > Dear Christian: > > > > > > > > What is the status of the AMDGPU work for Xen dom0? That was menti= oned in > > > > https://lore.kernel.org/dri-devel/b2dec9b3-03a7-e7ac-306e-1da024af8= 982@amd.com/ > > > > and there have been bug reports to Qubes OS about problems with AMD= GPU > > > > under Xen (such as https://github.com/QubesOS/qubes-issues/issues/7= 648). > > > > > > I would say it's a work in progress. It depends what GPU you have > > > and what type of xen setup you are using (PV vs PVH, etc.). > > > > The current situation is: > > > > - dom0 is PV. > > - VMs with assigned PCI devices are HVM and use a Linux-based stubdomain > > QEMU does not run in dom0. > > - Everything else is PVH. > > > > In the future, I believe the goal is to move away from PV and HVM in > > favor of PVH, though HVM support will remain for compatibility with > > guests (such as Windows) that need emulated devices. > > > > > In general, your best bet currently is dGPU add in boards because they > > > are largely self contained. > > > > The main problem is that for the trusted GUI to work, there needs to > > be at least one GPU attached to a trusted VM, such as the host or a > > dedicated GUI VM. That VM will typically not be running graphics- > > intensive workloads, so the compute power of a dGPU is largely wasted. > > SR-IOV support would help with that, but the only GPU vendor with open > > source SR-IOV support is Intel and it is still not upstream. I am also > > not certain if the support extends to Arc dGPUs. >=20 > Can you elaborate on this? Why wouldn't you just want to pass-through > a dGPU to a domU to use directly in the guest? You can do that, but if that's your only GPU in the system, you'll lose graphical interface for other guests. But yes, simply pass-through of a dGPU is enough in some setups. > Are you sure? I didn't think intel's GVT solution was actually > SR-IOV. I think GVT is just a paravirtualized solution. Yes, it's a paravirtualized solution, with device emulation done in dom0 kernel. This, besides being rather unusual approach in Xen world (emulators, aka IOREQ servers usually live in userspace) puts rather complex piece of code that interacts with untrusted data (instructions =66rom guests) in almost the most privileged system component, without ability to sandbox it in any way. We consider it too risky for Qubes OS, especially since the kernel patches were never accepted upstream and the Xen support is not maintained anymore. The SR-IOV approach Demi is talking about is newer development, supported since Adler Lake (technically, IGD in Tiger Lake presents SR-IOV capability too, but officially it's supported since ADL). The driver for managing it is in the process of upstreaming. Some links here: https://github.com/intel/linux-intel-lts/issues/33 (I have not tried it, yet) > That aside, > we are working on enabling virtio gpu with our GPUs on xen in addition > to domU passthrough. That's interesting development. Please note, Linux recently (part of 6.1) gained support to use grant tables with virtio. This allows having backends without full access to guest's memory. The work is done in generic way, so a driver using proper APIs (including DMA) should work out in such setup out of the box. Please try to not break it :) > > > > > APUs and platforms with integrated dGPUs > > > are a bit more complicated as they tend to have more platform > > > dependencies like ACPI tables and methods in order for the driver to > > > be able to initialize the hardware properly. > > > > Is Xen dom0/domU support for such GPUs being worked on? Is there an > > estimate as to when the needed support will be available upstream? This > > is mostly directed at Christian and other people who work for hardware > > vendors. >=20 > Yes, there are some minor fixes in the driver required which we'll be > sending out soon and we had to add some ACPI tables to the whitelist > in xen, but unfortunately the ACPI tables are AMD platform specific so > there has been pushback from the xen maintainers on accepting them > because they are not an official part of the ACPI spec. Can the driver work without them? Such dependency, as you noted above, make things rather complicated for pass-through (specific ACPI tables can probably be made available to the guest, but usually guest wouldn't see all the resources they talk about anyway). --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --ldwT7sa60O/uU5QD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmOGIf0ACgkQ24/THMrX 1ywEbQf+PEElPPxfmzpsF7KCl9us8eI4hUgwXur7ALf7DdhApavQOMgYmyMp47lO shMbFQygjqSJ4YCTvtRCWmEDIqmUduv/q6M69Hxv5bldxDx2qe/2/wwcUcQ4jKQB 34BJNGeLyuuxtgJ1Fw7EvmUVVm3TKTa57r5YqVpxmXkQ28or+2vbHmY8BGeQgYmn k6rJ24EDNfTs/fINw68+Rigvdt8tNKRvl69aHpwGMO1F6/k4EfBmqYUB6Al19xrY SIXSRI9skw/5UGR7fJ6ST7Cmm1FSOKWWkq/gmTMNy7qWbtSbelUouNPa+WAorBHr xBAtDguDGYb4pWCilHWOxHrC05G7Zw== =qLiG -----END PGP SIGNATURE----- --ldwT7sa60O/uU5QD-- From xen-devel-bounces@lists.xenproject.org Tue Nov 29 15:23:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 15:23:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449491.706269 (Exim 4.92) (envelope-from ) id 1p02Sc-0007jb-AM; Tue, 29 Nov 2022 15:23:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449491.706269; Tue, 29 Nov 2022 15:23:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02Sc-0007jU-6G; Tue, 29 Nov 2022 15:23:50 +0000 Received: by outflank-mailman (input) for mailman id 449491; Tue, 29 Nov 2022 15:23:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02Sb-0007jO-5H for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 15:23:49 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20625.outbound.protection.outlook.com [2a01:111:f400:fe5a::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d0b8a1b8-6ff9-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 16:23:47 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by MN2PR12MB4488.namprd12.prod.outlook.com (2603:10b6:208:24e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 15:23:41 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 15:23:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0b8a1b8-6ff9-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m8IIdCytrFE6bh88IMZ5jvkVlQO9sShi9xQO0sXo6X4S4un02NqU1V2GlBtffpjwUI0bvjkvK25Anm23IKd9/hF79FaMINgqSkoFQTSPJOJxpx1HuFBu4EBoYsLdoJLZagFn5Pdj+tJ8ahrE0K2uSWsrCbUZ9wKZrQFjhZTVnBlUFWmayxgU7JWBykoRBqBBI7q1QSG41DgsnxFSynHssnmRKZt1eJBLZX+wxLiEWsXogm/tNpiZGB4atmiOS8ZFC+SjF9bwQF4BvLVPp3W9MeHrSt7C4X3Ek9XSbH4/WhSzkLgiTzPJwoAOnGatKineBBjb2M1IWdyihl4lPriXSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fy9qUZEtCKNyCr9aWUDhk0VI5EFrCeZr6WdTaZrEWoM=; b=Msnuln7zhv4pPhpJzk54D1OKVOwXDbog3AcYZMvAqjnleBu+s5L9nFi2RN9fzFpfX9sLj9hnchDME3nsovXD854dVViPaqJegeCPnDeaqWNlkmk2ftrW7RC2sPLC6mdC4wFRAAPuZaPltNSytRWtZiU8s0PdMILyHm7jVg3cPoFjcLoVWnnhwuLbhnI+uX04PnkGaTsmyrZ2iNKuud+2v7FcoJN+dT0aODJzB/ifgJ0ne6wedx7piJc4o6GsPYOpcGcQ/gab6WGMEUMP7h1LG3vb3p/GBZvK2uQoh2qZkhLA4IZyZKsgjacMGQ94c8VYok3q5rlR1WpcEMaOwWJ4yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fy9qUZEtCKNyCr9aWUDhk0VI5EFrCeZr6WdTaZrEWoM=; b=Qe5evaOg6+e+JaTzCwQrzI1wJqjQPNXyoVHx91uUHUujld4fPF3LurtoL291B0xmrWOLGIW28WPsoqI17iKTTkCQLkJdDjmiNWTjwbTCDyPtLsVOXrRbfKztiiDu20Lp0xoBN+b3hczuuISnVoXYgO3Bhe4Qbots+GtxvjsV3TI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <65891843-db28-e5dd-6e9e-3fb003fcabc5@amd.com> Date: Tue, 29 Nov 2022 15:23:35 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Arm: AArch32: Need suggestions to support 32 bit physical addresses To: Julien Grall , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , "Stabellini, Stefano" , bertrand Marquis , Andre Przywara , "Volodymyr_Babchuk@epam.com" , Rahul Singh , Vladimir Murzin References: <70651dbc-085d-706d-17d0-a419086a0700@amd.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0230.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::6) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|MN2PR12MB4488:EE_ X-MS-Office365-Filtering-Correlation-Id: 3133e97d-e347-49de-2559-08dad21db204 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /NfxWQJG7wxVVhe3XQLpiE8BgWryZo7FNb7F+bKFq+ZqXqztrgo4Lf4qpLphprB7RR+TehJjOQVeNKn/j5HMKRMMV97CvXVliKyzHhMAxsV8vfKEiMNJDFSN2DMe0TTLfUGOvEAr6fUmWGGWUfjUlvidHu738bseieems3YYwMFc5ayQG6RHSHsmGsiO4OUF+aVCN7dFheZT4uJCL4k9ojcfHCVUpWVeHv1LhyoV/THbL6pjMKnAV7vHm9yecg09ZwrS+3Zo5+j98eWruirr3ym1JbDGYFSJ+PlEt0lq75yXzKGv+6/kIe3NHpW7ukUr6a2vLJAocIy4IuxgzYbJdVw+3jAz7OZPwuW0nEaHUde1GlmcKU8ix6aSBwX/nlgwVL3EcPSjdTYXBHd26fvdGPBRAs4a+SyJ+rCQsYqFMO98ejOKYyKhtNCZhFN58XxdM4XWYYMFqFt0RUigN3ffpvQWmK2Fv7YY13tx7hwe/M1EIwwKVZyunrKUHCJyXa5KfECYQyEYe/SMTrekqmzBD0IMC6EFhJ2ZF0Gtnuh0YZy85Nbc6qVUDcXtzx1yCeLaXOfmPEfOXx6y2RzO+tJu8NUbvl0krlurwe9G3834r4sTU1t8Q9SUJEydsBM94q8HbhlRQjFrN7aJpOgXmPaXdCo3Q4huy/I9EO4cM1wCRos7o125c6HGBW5EdBySxeYN5m2ky4KptWFds+xQoLHR8jre7xjc8vSY1vT41EuMHXs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(396003)(366004)(346002)(451199015)(2906002)(31686004)(4326008)(41300700001)(66476007)(66556008)(186003)(54906003)(8676002)(36756003)(316002)(110136005)(8936002)(5660300002)(26005)(6512007)(478600001)(6486002)(2616005)(6666004)(31696002)(66946007)(53546011)(6506007)(38100700002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXQ1dGE5TzBPTERrV0xBa3lyOTRGdC92bjZ3eVBHQ0cwNTVwQk9QM1AwL1R2?= =?utf-8?B?U21xV2NoejFlNDQyKzRITXp2ZnJVS0ZBWGRvRCsxS3RLdjg1NUh0RVpLWkpa?= =?utf-8?B?SFNpWFRVZEZ5eEtyaTBCdm1VWWZlNi9Ud3J0Y1lhWUdndkc1NXVkVXB1dEJ1?= =?utf-8?B?dFpwR0tJdjlaZnhXbmY5NWtZOVVxSmlFZ1dzSTVzYThSQnVadHpuZXNRajFw?= =?utf-8?B?czFPWXo0aThxemhJN29lVHlxYjNkRkx4Z3pKVnhxWVpFMG9aWGprRXZHaTdW?= =?utf-8?B?Z2lxMGxpRTVrZDJ1TDd5SnFkZkt2QjV1K01VRllwQjdHbmk1SXFXRVd3OHBv?= =?utf-8?B?YUlxS0N3bHJGZW9hbmhYb0JwekFySS9SbXZqdmlZZTRhUyt3ZFI2MkQ2SVFP?= =?utf-8?B?bEF1OERWdndzbDlrQnJQZGtqUDNDOW45YjlIVnA0KzFWTnp4SXJpczVnZlpz?= =?utf-8?B?WVBNVG5DZjEyMUdEOWQ3L01MZlhPVE9XWlRFZ1FlbFd5MExUa0w1aGJROTJw?= =?utf-8?B?SFhKallQQW9qSGl3MGpld3psc3VsSVI5OXZ0T3gvKzZoUHBsemxCUXNQeTdu?= =?utf-8?B?R24yUFBtNU9WdlNPWlNNMWlvTUxmdlZpQXRyclNLYUNGVTd2WDA5WHZaaW1Y?= =?utf-8?B?a0YrY3pDYjIwalBoa014MEVneUdTaGViSFZ0ZkRFQ3YwV3NwV0hTTFp6WUFj?= =?utf-8?B?YUxDaEoydExtOVl4Z3lySEwwN1RyZEsxNmQ4QVRXeElQMFNMT2Rkc3JZbkxj?= =?utf-8?B?dUNPWEtxT2tnbUk4MHErRXY2RFdmbTJqT21KWXNPMm1ScWhwc2ZpbWJEN0Ji?= =?utf-8?B?QXo4b3hOa3RQdmVLdVRTbjM2S0c3d2pVeEFOeW1kdHk0V052UG5YdjVUMGI3?= =?utf-8?B?TGdheXVkRXh4VkJheDI5UVNJOVYrMG55d3NwbGR6aDFqZ3NQNkRUMlZ5MkJo?= =?utf-8?B?aTVHSHc3b0Z2UTdROExUQktHWGRhby9TbmR4TDdONzg0ZVpNT3p2dnVBQ2c4?= =?utf-8?B?ZlJDVWVBZVM4MDR0Z0FIUmEvYWFWRWZrS1JBSUwxMDQvdDVVNlpQOTdSZmky?= =?utf-8?B?ZzFmUE52OUw2MG9ETDlVdmNDVm9KckJ6R2RvclkwYUhSWWxiMjQ0TVZraHdn?= =?utf-8?B?ZkZ5dG9rQzh6Ym4xYTdrdnltUnJzd0dBdDIwS3pEQnB4a3NNVzI5RWJnM2Va?= =?utf-8?B?WWpPeW93aVkyYWFWN1VyRmFLTFpYdnA5UWNvQmhDaG5iRFl3U3FqK0ZERGlB?= =?utf-8?B?cFI5bklPazVVSFdtd0tWa0RJQUlzcE9nRHpXZXdQMGl0UEF2Zkx0OUpyZ3N2?= =?utf-8?B?RHhCcEtoZVVzR0pWbysxNTdGdnd3UUVtWExCYVlQa0ZuVEc0YlEwMFJSRXBN?= =?utf-8?B?Z0pERzNjM2tZUEg3VFpORldGZCtzOEhwVWdEOFNiZnp0N3NFT0wvVStQVHBZ?= =?utf-8?B?cGxqMExkMHBMemlUcGVzcHcwV2ZDR1ZEeU1nU1hobkpzZzU1dXNkM3FvcEF3?= =?utf-8?B?eERWaXljaVVqd2pJTE9semgvWGswVE1sdmpUOERDUXZRN2hJM01BT3VyS0RD?= =?utf-8?B?M2tPUFluRUNrUExPQVFSWjlBVVhtRENpcXFzTE04LzZiaE54b3dUckFycXhx?= =?utf-8?B?VG1uWjZhTjAxNGc3cmpCZjdNODhURXZSekxUZVcyWlFkU1pPNlFLL0hxQW9R?= =?utf-8?B?VWlpbmpwY1lZNm5IbzllalpDY2ROc1JHN0d0Mms2eWw1RmNMcXdBQ200TVpa?= =?utf-8?B?NUJFU2dxQUh3anJLRTQvaVk0RnBSVi96UXNTR2t4YVdEWFQvU1VRVE1SdGdo?= =?utf-8?B?QWpCSzhzYXFsN2JuV3AwRGY1YWFxSUVheFhVWDk4VnA4eGJNMEZIbDVPNlFn?= =?utf-8?B?WEFqVkNrejJlaWNLYjhVZm4zL0JBL1NFK1hUS1FGT3pVZ2E2VEhuVGdBS2xZ?= =?utf-8?B?SkJjb3VZUUxScDBXaXY5aDUxNmZOc1FsTG1vQUhoa1BlamgyaTg0bVNSdkw4?= =?utf-8?B?YXIvN2xick9YYXpacmhQdE9ySTBTRnMyRkVSM3llNE9Nc1g1QUxISEx5eG84?= =?utf-8?B?L0ZmSzFPV3lVWVpzUTlLVTRpUnhkNVREUm1VNUVtK2JBcHFLNGZWY0liSElP?= =?utf-8?Q?OfyIg7gr6t0K5GuLWRhpk8JjO?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3133e97d-e347-49de-2559-08dad21db204 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 15:23:41.1503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: haBYtkZFAJO11BfUX7N8gdGg1dNYnVdCSKxhhvE3DQdmPSwaZt1p9bLTpzMgqq5wOm2TC/BXPyeNtw20rpHf4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4488 On 29/11/2022 14:52, Julien Grall wrote: > > > On 29/11/2022 14:57, Ayan Kumar Halder wrote: >> Hi All, > > Hi, Hi Julien, Many thanks for your inputs. > >> I am trying to gather opinions on how to support 32 bit physical >> addresses to enable Xen running on R52. >> >> Refer Cortex R52 TRM, Section 2.2.12 "Memory Model" >> >> "...This is because the physical address is always the same as the >> virtual address...The virtual and physical address can be treated as >> synonyms for Cortex-R52." >> >> Thus, I understand that R52 supports 32 bit physical address only. >> This is a bit different from Armv7 systems which supports Large >> Physical Address Extension (LPAE) ie 40 bit physical addresses. > >> Please correct me if I misunderstand something. > >> So currently, Xen supports 64 bit physical address for Arm_32 (ie >> Armv7) based system. > > Xen supports *up to* 64-bit physical address. This may be lower in the > HW (not all the Armv7 HW supports 40-bit address). > >> My aim is to enable support for 32 bit physical address. > > Technically this is already supported because this is a subset of > 64-bit. I can see a use case (even on non R* HW) where you may want to > use 32-bit paddr_t to reduce the code size (and registers used). > > But I think that's more an optimization that rather than been necessary. > >> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c >> index 6014c0f852..4f8b5fc4be 100644 >> --- a/xen/arch/arm/bootfdt.c >> +++ b/xen/arch/arm/bootfdt.c >> @@ -56,10 +56,10 @@ static bool __init >> device_tree_node_compatible(const void *fdt, int node, >>   } >> >>   void __init device_tree_get_reg(const __be32 **cell, u32 >> address_cells, >> -                                u32 size_cells, u64 *start, u64 *size) >> +                                u32 size_cells, paddr_t *start, >> paddr_t *size) > > This needs to stay uint64_t because the Device-Tree may contain 64-bit > values and you... Are you saying that the device tree may contain 64 bit addresses even though the platform is 32 bit ? I think then this approach (ie "typedef u32 paddr_t" for 32 bit system) is incorrect. Then, the other option would be to downcast 64 bit physical addresses to 32 bits, when we need to translate pa to va. Do you think this approach looks better ? Or any better suggestions ?     xen/Arm: AArch32_V8R: Use 32 bits for the physical address     In the case of MPU (unlike MMU), there is a 1-1 mapping of virtual address     to physical address (ie VA = PA).     However, the physical addresses defined for aarch32 is u64. This is a problem     for aarch32 mpu systems as the physical addresses = virtual addresses = 32 bits.     Thus, when the memory region for FDT is mapped, it returns the virtual address     (which is the same as physical address but truncated upto the lower 32 bits).     Similar logic has been used to convert machine address to virtual address and     for ioremap as well.     We do not support physical addresses beyond 32 bits.     As this logic will fail when FDT physical address is more than 32 bits, we have     added a BUG() to catch this.     Thus, the following functions has been adapted :-     early_fdt_map()     copy_from_paddr()     maddr_to_virt()     ioremap_attr()     Also disable "BUILD_BUG_ON(PADDR_BITS >= BITS_PER_LONG)" as PADDR_BITS = 40     and BITS_PER_LONG = 32.     Signed-off-by: Ayan Kumar Halder diff --git a/xen/arch/arm/include/asm/mm_mpu.h b/xen/arch/arm/include/asm/mm_mpu.h index 306a4c497c..f4f5ae1488 100644 --- a/xen/arch/arm/include/asm/mm_mpu.h +++ b/xen/arch/arm/include/asm/mm_mpu.h @@ -89,7 +89,18 @@ static inline paddr_t __virt_to_maddr(vaddr_t va)  static inline void *maddr_to_virt(paddr_t ma)  {      /* In MPU system, VA == PA. */ +#ifdef CONFIG_AARCH32_V8R +    /* +     * 64 bit physical addresses are not supported. +     * Raise a bug if one encounters 64 bit address. +     */ +    if (ma >> BITOP_BITS_PER_WORD) +        BUG(); + +    return (void *) ((uint32_t)(ma & GENMASK(31,0))); +#else      return (void *)ma; +#endif  }  /* diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index b3330cd584..3f4ac7f475 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -119,7 +119,11 @@ extern struct bootinfo bootinfo;  extern domid_t max_init_domid; +#ifdef CONFIG_AARCH32_V8R +void copy_from_paddr(void *dst, uint32_t paddr, unsigned long len); +#else  void copy_from_paddr(void *dst, paddr_t paddr, unsigned long len); +#endif  size_t estimate_efi_size(unsigned int mem_nr_banks); diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c index 04c05d7a05..7a7386f33a 100644 --- a/xen/arch/arm/kernel.c +++ b/xen/arch/arm/kernel.c @@ -46,7 +46,11 @@ struct minimal_dtb_header {   * @paddr: source physical address   * @len: length to copy   */ +#ifdef CONFIG_AARCH32_V8R +void __init copy_from_paddr(void *dst, uint32_t paddr, unsigned long len) +#else  void __init copy_from_paddr(void *dst, paddr_t paddr, unsigned long len) +#endif  {      void *src = (void *)(unsigned long)paddr; diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index df43621ee7..62774aebc6 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -29,7 +29,7 @@  #include  #endif -#ifdef CONFIG_AARCH32_ARMV8_R +#ifdef CONFIG_AARCH32_V8R  #include  #endif @@ -414,7 +414,18 @@ void *ioremap_attr(paddr_t pa, size_t len, unsigned int attributes)          return NULL;      } +#ifdef CONFIG_AARCH32_V8R +    /* +     * 64 bit physical addresses are not supported. +     * Raise a bug if one encounters 64 bit address. +     */ +    if (pa >> BITOP_BITS_PER_WORD) +        BUG(); + +    return (void *) ((uint32_t)(pa & GENMASK(31,0))); +#else      return (void *)pa; +#endif  }  static void clear_boot_mpumap(void) @@ -1007,7 +1018,19 @@ void * __init early_fdt_map(paddr_t fdt_paddr)      nr_xen_mpumap++;      /* VA == PA */ +#ifdef CONFIG_AARCH32_V8R + +    /* +     * 64 bit physical addresses are not supported. +     * Raise a bug if one encounters 64 bit address. +     */ +    if (fdt_paddr >> BITOP_BITS_PER_WORD) +        BUG(); + +    fdt_virt = (void *) ((uint32_t)(fdt_paddr & GENMASK(31,0))); +#else      fdt_virt = (void *)fdt_paddr; +#endif      if ( fdt_magic(fdt_virt) != FDT_MAGIC )          return NULL; @@ -1165,13 +1188,13 @@ void __init setup_protection_regions()          {              pr_t region;              access_protection_region(true, ®ion, NULL, i); -#ifdef CONFIG_AARCH32_ARMV8_R +#ifdef CONFIG_AARCH32_V8R              printk("Boot-time Xen MPU memory configuration. #%u : 0x%"PRIx32" - 0x%"PRIx32".\n",                     i, pr_get_base(®ion), pr_get_limit(®ion)); -#else /* CONFIG_AARCH32_ARMV8_R */ +#else              printk("Boot-time Xen MPU memory configuration. #%u : 0x%"PRIx64" - 0x%"PRIx64".\n",                     i, pr_get_base(®ion), pr_get_limit(®ion)); -#endif /* CONFIG_AARCH32_ARMV8_R */ +#endif          }  } @@ -1262,8 +1285,13 @@ static int __init relocate_xen_mpumap(void)      if ( !xen_mpumap )          return -EINVAL; +#ifdef CONFIG_AARCH32_V8R +    copy_from_paddr(xen_mpumap, (uint32_t)(pr_t *)boot_mpumap, +                    sizeof(pr_t) * next_xen_mpumap_index); +#else      copy_from_paddr(xen_mpumap, (paddr_t)(pr_t *)boot_mpumap,                      sizeof(pr_t) * next_xen_mpumap_index); +#endif      clear_boot_mpumap(); diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 62afb07bc6..a73bf7de01 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2245,7 +2245,9 @@ void __init xenheap_max_mfn(unsigned long mfn)  {      ASSERT(!first_node_initialised);      ASSERT(!xenheap_bits); +#ifndef CONFIG_AARCH32_V8R      BUILD_BUG_ON(PADDR_BITS >= BITS_PER_LONG); +#endif      xenheap_bits = min(flsl(mfn + 1) - 1 + PAGE_SHIFT, PADDR_BITS);      printk(XENLOG_INFO "Xen heap: %u bits\n", xenheap_bits);  } - Ayan From xen-devel-bounces@lists.xenproject.org Tue Nov 29 15:24:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 15:24:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449493.706279 (Exim 4.92) (envelope-from ) id 1p02TC-0008Ai-HE; Tue, 29 Nov 2022 15:24:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449493.706279; Tue, 29 Nov 2022 15:24:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02TC-0008Ab-Ec; Tue, 29 Nov 2022 15:24:26 +0000 Received: by outflank-mailman (input) for mailman id 449493; Tue, 29 Nov 2022 15:24:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02TB-0008AO-67 for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 15:24:25 +0000 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [2607:f8b0:4864:20::330]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e6ff0f5b-6ff9-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 16:24:24 +0100 (CET) Received: by mail-ot1-x330.google.com with SMTP id g51-20020a9d12b6000000b0066dbea0d203so9288419otg.6 for ; Tue, 29 Nov 2022 07:24:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6ff0f5b-6ff9-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=heqDo1SemRKJ38s2oaglUe868ZlxEolBPvviw9Bv8Jo=; b=ByQIRxoI3He+gK+MZv8IFgDJWmR5Vy19GBauIg6ZAFFTn2k58vHLYITHKDCP/V6V48 iNEzCxZsMFfeG7rVLCtY372wZs4jcMPu9IbFnx+Vw8CAdWA6b9Xq+OU5hzDszEoXamwG QHDgG6RhTU/Rl+kkwZ2KtaWPWZ5gAQGpv4QWvoG9ojp5tPEE+M1Z/BvuaCRTWJRWkCHT DtxODIxJ+GGQVTNAAOy6pE7KA3dSpsgoMaKvf6D5g6STOvc640L2G3nJuRZKtbKqFJWM RagRGTmBUUaxjm8twJOgZnoufya8CGo5chb9Sft4+8C9OOxi+WtmyHjBQ+7mv5O4FTRX hVZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=heqDo1SemRKJ38s2oaglUe868ZlxEolBPvviw9Bv8Jo=; b=tCkbkHiC+2t395MsD+Y7cu8OasqEg4u1ynyx5aP4iiqffBZv+YWnNrqsab0TkHA7My ceKhtg7GdgCnTj5Hr42HWjELhCADkq6hg4MAHINpbh68agw4v47jGHity6YzVx58e4Q7 EC+73V+QMtRQSlXZOKH5D7jWBu4R2gbUE3WSbx3cWvDxdN2iGaBVcj7BIiaG4Qnlrd9C yNfpZvlTaUMbyYH0LHn8Nf5Si7rF1tuSr1HhgI9auVJpbwlGFrsDUeNKVjPI9zAUU4ET cFn6UG2DuUmhhcUmswuaS938iMLPv4VobcOBGZW+7I/oYtiW5ze0m05gTRRcZJUSIzGU nXNg== X-Gm-Message-State: ANoB5pmkLPP0yxXMa+R48aIe7A0wp9edk4tydvvQTgRd7U/u2tFJyVNt L18O9Yd/1jZPwPLQmvtnGaRuRcg5uyt2yA2gJ9Q= X-Google-Smtp-Source: AA0mqf501V19/0cKPFiEfx+BFWiPWHLnpu61P98cAI4LEC+oEECnLTWdJ6qFeaJ1dtEeEtZIW3JlNl+8OtHDs2NicQA= X-Received: by 2002:a9d:628b:0:b0:66c:6afa:5006 with SMTP id x11-20020a9d628b000000b0066c6afa5006mr22125669otk.233.1669735462613; Tue, 29 Nov 2022 07:24:22 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alex Deucher Date: Tue, 29 Nov 2022 10:24:10 -0500 Message-ID: Subject: Re: AMD GPU problems under Xen To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: Demi Marie Obenour , christian.koenig@amd.com, Xen developer discussion , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 29, 2022 at 10:15 AM Marek Marczykowski-G=C3=B3recki wrote: > > On Tue, Nov 29, 2022 at 09:32:54AM -0500, Alex Deucher wrote: > > On Mon, Nov 28, 2022 at 8:59 PM Demi Marie Obenour > > wrote: > > > > > > On Mon, Nov 28, 2022 at 11:18:00AM -0500, Alex Deucher wrote: > > > > On Mon, Nov 28, 2022 at 2:18 AM Demi Marie Obenour > > > > wrote: > > > > > > > > > > Dear Christian: > > > > > > > > > > What is the status of the AMDGPU work for Xen dom0? That was men= tioned in > > > > > https://lore.kernel.org/dri-devel/b2dec9b3-03a7-e7ac-306e-1da024a= f8982@amd.com/ > > > > > and there have been bug reports to Qubes OS about problems with A= MDGPU > > > > > under Xen (such as https://github.com/QubesOS/qubes-issues/issues= /7648). > > > > > > > > I would say it's a work in progress. It depends what GPU you have > > > > and what type of xen setup you are using (PV vs PVH, etc.). > > > > > > The current situation is: > > > > > > - dom0 is PV. > > > - VMs with assigned PCI devices are HVM and use a Linux-based stubdom= ain > > > QEMU does not run in dom0. > > > - Everything else is PVH. > > > > > > In the future, I believe the goal is to move away from PV and HVM in > > > favor of PVH, though HVM support will remain for compatibility with > > > guests (such as Windows) that need emulated devices. > > > > > > > In general, your best bet currently is dGPU add in boards because t= hey > > > > are largely self contained. > > > > > > The main problem is that for the trusted GUI to work, there needs to > > > be at least one GPU attached to a trusted VM, such as the host or a > > > dedicated GUI VM. That VM will typically not be running graphics- > > > intensive workloads, so the compute power of a dGPU is largely wasted= . > > > SR-IOV support would help with that, but the only GPU vendor with ope= n > > > source SR-IOV support is Intel and it is still not upstream. I am al= so > > > not certain if the support extends to Arc dGPUs. > > > > Can you elaborate on this? Why wouldn't you just want to pass-through > > a dGPU to a domU to use directly in the guest? > > You can do that, but if that's your only GPU in the system, you'll lose > graphical interface for other guests. > But yes, simply pass-through of a dGPU is enough in some setups. > > > Are you sure? I didn't think intel's GVT solution was actually > > SR-IOV. I think GVT is just a paravirtualized solution. > > Yes, it's a paravirtualized solution, with device emulation done in dom0 > kernel. This, besides being rather unusual approach in Xen world > (emulators, aka IOREQ servers usually live in userspace) puts rather > complex piece of code that interacts with untrusted data (instructions > from guests) in almost the most privileged system component, without > ability to sandbox it in any way. We consider it too risky for Qubes OS, > especially since the kernel patches were never accepted upstream and the > Xen support is not maintained anymore. > > The SR-IOV approach Demi is talking about is newer development, > supported since Adler Lake (technically, IGD in Tiger Lake presents > SR-IOV capability too, but officially it's supported since ADL). The driv= er > for managing it is in the process of upstreaming. Some links here: > https://github.com/intel/linux-intel-lts/issues/33 > (I have not tried it, yet) > > > That aside, > > we are working on enabling virtio gpu with our GPUs on xen in addition > > to domU passthrough. > > That's interesting development. Please note, Linux recently (part of > 6.1) gained support to use grant tables with virtio. This allows having > backends without full access to guest's memory. The work is done in > generic way, so a driver using proper APIs (including DMA) should work > out in such setup out of the box. Please try to not break it :) > > > > > > > > APUs and platforms with integrated dGPUs > > > > are a bit more complicated as they tend to have more platform > > > > dependencies like ACPI tables and methods in order for the driver t= o > > > > be able to initialize the hardware properly. > > > > > > Is Xen dom0/domU support for such GPUs being worked on? Is there an > > > estimate as to when the needed support will be available upstream? T= his > > > is mostly directed at Christian and other people who work for hardwar= e > > > vendors. > > > > Yes, there are some minor fixes in the driver required which we'll be > > sending out soon and we had to add some ACPI tables to the whitelist > > in xen, but unfortunately the ACPI tables are AMD platform specific so > > there has been pushback from the xen maintainers on accepting them > > because they are not an official part of the ACPI spec. > > Can the driver work without them? Such dependency, as you noted above, > make things rather complicated for pass-through (specific ACPI tables > can probably be made available to the guest, but usually guest wouldn't > see all the resources they talk about anyway). Not really for APUs and dGPUs that are integrated into a platform. For some of them the ACPI tables are just data tables which contain a copy of the vbios image which the driver needs for enumerating board and platform specific data like the display connector topology, i2c buses, clocks and voltages, etc. However there are ACPI methods required for other things related to the platform like power budgets, GPU power, etc. If you don't set them up correctly the system may not operate correctly or you may not be able to put the device into its lowest power state. Alex From xen-devel-bounces@lists.xenproject.org Tue Nov 29 15:27:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 15:27:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449499.706291 (Exim 4.92) (envelope-from ) id 1p02WB-0000X8-2O; Tue, 29 Nov 2022 15:27:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449499.706291; Tue, 29 Nov 2022 15:27:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02WA-0000X1-Vj; Tue, 29 Nov 2022 15:27:30 +0000 Received: by outflank-mailman (input) for mailman id 449499; Tue, 29 Nov 2022 15:27:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02WA-0000Wv-Gx for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 15:27:30 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 55c96cfb-6ffa-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 16:27:29 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C12211FDDE; Tue, 29 Nov 2022 15:27:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8613113AF6; Tue, 29 Nov 2022 15:27:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id V+ETH+AkhmMzcwAAMHmgww (envelope-from ); Tue, 29 Nov 2022 15:27:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55c96cfb-6ffa-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669735648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rXlM+yvFockFzQWFJtuOywTcr68TPYdF51NVeHyrMC4=; b=ic12lZLyUebEjX1uRTMeugjus9W7CYPinxpKDtCtrjkhTsYeuE0mg11xX2lQRP+RvvrAlB v4TAHTB5A7rxopdhmvDeK2ydiD0s5/PPYYyae+KeRAJsZF5WB7S/7NLZQSF82iETqN0toX f78tSyWqwVfQmOvDPhB2Y9J6noNdpGo= Message-ID: <358e49fa-8ce7-67ce-8e0b-e523dee9ea19@suse.com> Date: Tue, 29 Nov 2022 16:27:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: Per Bilse , linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , Boris Ostrovsky , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" References: <20221129150058.266943-1-per.bilse@citrix.com> From: Juergen Gross Subject: Re: [PATCH] drivers/xen/hypervisor: Expose VM SIF flags to userspace In-Reply-To: <20221129150058.266943-1-per.bilse@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------bX2PESQviO3CpgKBjxM6PRjP" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------bX2PESQviO3CpgKBjxM6PRjP Content-Type: multipart/mixed; boundary="------------X8D0eoeDEr15NPcmqFQSmGVr"; protected-headers="v1" From: Juergen Gross To: Per Bilse , linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , Boris Ostrovsky , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Message-ID: <358e49fa-8ce7-67ce-8e0b-e523dee9ea19@suse.com> Subject: Re: [PATCH] drivers/xen/hypervisor: Expose VM SIF flags to userspace References: <20221129150058.266943-1-per.bilse@citrix.com> In-Reply-To: <20221129150058.266943-1-per.bilse@citrix.com> --------------X8D0eoeDEr15NPcmqFQSmGVr Content-Type: multipart/mixed; boundary="------------LNhIUa17THGTpfpqC5kv1FfE" --------------LNhIUa17THGTpfpqC5kv1FfE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjkuMTEuMjIgMTY6MDAsIFBlciBCaWxzZSB3cm90ZToNCj4gL3Byb2MveGVuIGlzIGEg bGVnYWN5IHBzZXVkbyBmaWxlc3lzdGVtIHdoaWNoIHByZWRhdGVzIFhlbiBzdXBwb3J0DQo+ IGdldHRpbmcgbWVyZ2VkIGludG8gTGludXguICBJdCBoYXMgbGFyZ2VseSBiZWVuIHJlcGxh Y2VkIHdpdGggbW9yZQ0KPiBub3JtYWwgbG9jYXRpb25zIGZvciBkYXRhICgvc3lzL2h5cGVy dmlzb3IvIGZvciBpbmZvLCAvZGV2L3hlbi8gZm9yDQo+IHVzZXIgZGV2aWNlcykuICBXZSB3 YW50IHRvIGNvbXBpbGUgeGVuZnMgc3VwcG9ydCBvdXQgb2YgdGhlIGRvbTAga2VybmVsLg0K PiANCj4gVGhlcmUgaXMgb25lIGl0ZW0gd2hpY2ggb25seSBleGlzdHMgaW4gL3Byb2MveGVu LCBuYW1lbHkNCj4gL3Byb2MveGVuL2NhcGFiaWxpdGllcyB3aXRoICJjb250cm9sX2QiIGJl aW5nIHRoZSBzaWduYWwgb2YgInlvdSdyZSBpbg0KPiB0aGUgY29udHJvbCBkb21haW4iLiAg VGhpcyB1bHRpbWF0ZWx5IGNvbWVzIGZyb20gdGhlIFNJRiBmbGFncyBwcm92aWRlZA0KPiBh dCBWTSBzdGFydC4NCj4gDQo+IFRoaXMgcGF0Y2ggZXhwb3NlcyBhbGwgU0lGIGZsYWdzIGlu IC9zeXMvaHlwZXJ2aXNvci9wcm9wZXJ0aWVzL2ZsYWdzLA0KPiB3aGljaCB3aWxsIGNvZXhp c3Qgd2l0aCAvcHJvYy94ZW4gd2hpbGUgZGVwZW5kZW5jaWVzIGFyZSBiZWluZyBtaWdyYXRl ZC4NCj4gUG9zc2libGUgdmFsdWVzIGFyZSAicHJpdmlsZWdlZCIsICJpbml0ZG9tYWluIiwg Im11bHRpYm9vdCIsDQo+ICJtb2Rfc3RhcnRfcGZuIiwgYW5kICJ2aXJ0bWFwIiwgd2l0aCAi aW5pdGRvbWFpbiIgYmVpbmcgdGhlIGVxdWl2YWxlbnQNCj4gb2YgImNvbnRyb2xfZCIuDQo+ IA0KPiBTaWduZWQtb2ZmLWJ5OiBQZXIgQmlsc2UgPHBlci5iaWxzZUBjaXRyaXguY29tPg0K PiAtLS0NCj4gICBkcml2ZXJzL3hlbi9zeXMtaHlwZXJ2aXNvci5jIHwgMjYgKysrKysrKysr KysrKysrKysrKysrKysrKysNCj4gICBpbmNsdWRlL3hlbi9pbnRlcmZhY2UveGVuLmggIHwg MTMgKysrKysrKystLS0tLQ0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygr KSwgNSBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9zeXMt aHlwZXJ2aXNvci5jIGIvZHJpdmVycy94ZW4vc3lzLWh5cGVydmlzb3IuYw0KPiBpbmRleCBm Y2IwNzkyZjA5MGUuLjczOTNlMDRiZGI2ZCAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy94ZW4v c3lzLWh5cGVydmlzb3IuYw0KPiArKysgYi9kcml2ZXJzL3hlbi9zeXMtaHlwZXJ2aXNvci5j DQo+IEBAIC0zNzksNiArMzc5LDMxIEBAIHN0YXRpYyBzc2l6ZV90IGJ1aWxkaWRfc2hvdyhz dHJ1Y3QgaHlwX3N5c2ZzX2F0dHIgKmF0dHIsIGNoYXIgKmJ1ZmZlcikNCj4gICANCj4gICBI WVBFUlZJU09SX0FUVFJfUk8oYnVpbGRpZCk7DQo+ICAgDQo+ICtzdGF0aWMgc3NpemVfdCBm bGFnc19zaG93KHN0cnVjdCBoeXBfc3lzZnNfYXR0ciAqYXR0ciwgY2hhciAqYnVmZmVyKQ0K PiArew0KPiArCXN0YXRpYyBjaGFyIGNvbnN0ICpjb25zdCBzaWZzdHJbU0lGTl9OVU1fU0lG Tl0gPSB7DQo+ICsJCVtTSUZOX1BSSVZdICA9ICJwcml2aWxlZ2VkIiwNCj4gKwkJW1NJRk5f SU5JVF0gID0gImluaXRkb21haW4iLA0KPiArCQlbU0lGTl9NVUxUSV0gPSAibXVsdGlib290 IiwNCj4gKwkJW1NJRk5fUEZOXSAgID0gIm1vZF9zdGFydF9wZm4iLA0KPiArCQlbU0lGTl9W SVJUXSAgPSAidmlydG1hcCINCj4gKwl9Ow0KPiArCXVuc2lnbmVkIHNpZm51bSwgc2lmbWFz azsNCj4gKwlzc2l6ZV90IHJldCA9IDA7DQo+ICsNCj4gKwlzaWZtYXNrID0gfih+MFUgPDwg U0lGTl9OVU1fU0lGTik7ICAvLyAuLi4wMDAwMTExLi4uDQo+ICsJaWYgKHhlbl9kb21haW4o KSAmJiAoeGVuX3N0YXJ0X2ZsYWdzICYgc2lmbWFzaykgIT0gMCkgew0KPiArCQlmb3IgKHNp Zm51bSA9IDA7IHNpZm51bSAhPSBTSUZOX05VTV9TSUZOOyBzaWZudW0rKykgew0KPiArCQkJ aWYgKCh4ZW5fc3RhcnRfZmxhZ3MgJiAoMTw8c2lmbnVtKSkgIT0gMCkNCj4gKwkJCQlyZXQg Kz0gc3ByaW50ZihidWZmZXIrcmV0LCAiJXMgIiwgc2lmc3RyW3NpZm51bV0pOw0KPiArCQl9 DQo+ICsJCWJ1ZmZlcltyZXQtMV0gPSAnXG4nOw0KPiArCX0NCj4gKwlyZXR1cm4gcmV0Ow0K PiArfQ0KPiArDQo+ICtIWVBFUlZJU09SX0FUVFJfUk8oZmxhZ3MpOw0KPiArDQo+ICAgc3Rh dGljIHN0cnVjdCBhdHRyaWJ1dGUgKnhlbl9wcm9wZXJ0aWVzX2F0dHJzW10gPSB7DQo+ICAg CSZjYXBhYmlsaXRpZXNfYXR0ci5hdHRyLA0KPiAgIAkmY2hhbmdlc2V0X2F0dHIuYXR0ciwN Cj4gQEAgLTM4Niw2ICs0MTEsNyBAQCBzdGF0aWMgc3RydWN0IGF0dHJpYnV0ZSAqeGVuX3By b3BlcnRpZXNfYXR0cnNbXSA9IHsNCj4gICAJJnBhZ2VzaXplX2F0dHIuYXR0ciwNCj4gICAJ JmZlYXR1cmVzX2F0dHIuYXR0ciwNCj4gICAJJmJ1aWxkaWRfYXR0ci5hdHRyLA0KPiArCSZm bGFnc19hdHRyLmF0dHIsDQo+ICAgCU5VTEwNCj4gICB9Ow0KPiAgIA0KPiBkaWZmIC0tZ2l0 IGEvaW5jbHVkZS94ZW4vaW50ZXJmYWNlL3hlbi5oIGIvaW5jbHVkZS94ZW4vaW50ZXJmYWNl L3hlbi5oDQo+IGluZGV4IDBjYTIzZWNhMmE5Yy4uNzYyYTM0OGFiZTNlIDEwMDY0NA0KPiAt LS0gYS9pbmNsdWRlL3hlbi9pbnRlcmZhY2UveGVuLmgNCj4gKysrIGIvaW5jbHVkZS94ZW4v aW50ZXJmYWNlL3hlbi5oDQo+IEBAIC02NDgsMTEgKzY0OCwxNCBAQCBzdHJ1Y3Qgc3RhcnRf aW5mbyB7DQo+ICAgfTsNCj4gICANCj4gICAvKiBUaGVzZSBmbGFncyBhcmUgcGFzc2VkIGlu IHRoZSAnZmxhZ3MnIGZpZWxkIG9mIHN0YXJ0X2luZm9fdC4gKi8NCj4gLSNkZWZpbmUgU0lG X1BSSVZJTEVHRUQgICAgICAoMTw8MCkgIC8qIElzIHRoZSBkb21haW4gcHJpdmlsZWdlZD8g Ki8NCj4gLSNkZWZpbmUgU0lGX0lOSVRET01BSU4gICAgICAoMTw8MSkgIC8qIElzIHRoaXMg dGhlIGluaXRpYWwgY29udHJvbCBkb21haW4/ICovDQo+IC0jZGVmaW5lIFNJRl9NVUxUSUJP T1RfTU9EICAgKDE8PDIpICAvKiBJcyBtb2Rfc3RhcnQgYSBtdWx0aWJvb3QgbW9kdWxlPyAq Lw0KPiAtI2RlZmluZSBTSUZfTU9EX1NUQVJUX1BGTiAgICgxPDwzKSAgLyogSXMgbW9kX3N0 YXJ0IGEgUEZOPyAqLw0KPiAtI2RlZmluZSBTSUZfVklSVF9QMk1fNFRPT0xTICgxPDw0KSAg LyogRG8gWGVuIHRvb2xzIHVuZGVyc3RhbmQgYSB2aXJ0LiBtYXBwZWQgKi8NCj4gKy8qIFRl eHQgc3RyaW5ncyBhcmUgcHJpbnRlZCBvdXQgaW4gc3lzLWh5cGVydmlzb3IuYywgd2UgZ3Vh cmQgICAqLw0KPiArLyogYWdhaW5zdCBtaXgtdXBzIGFuZCBlcnJvcnMgYnkgZW51bWVyYXRp bmcgdGhlIGZsYWdzLiAgICAgICAgICovDQo+ICtlbnVtIHsgU0lGTl9QUklWLCBTSUZOX0lO SVQsIFNJRk5fTVVMVEksIFNJRk5fUEZOLCBTSUZOX1ZJUlQsIFNJRk5fTlVNX1NJRk4gfTsN Cj4gKyNkZWZpbmUgU0lGX1BSSVZJTEVHRUQgICAgICAoMTw8U0lGTl9QUklWKSAgLyogSXMg dGhlIGRvbWFpbiBwcml2aWxlZ2VkPyAqLw0KPiArI2RlZmluZSBTSUZfSU5JVERPTUFJTiAg ICAgICgxPDxTSUZOX0lOSVQpICAvKiBJcyB0aGlzIHRoZSBpbml0aWFsIGNvbnRyb2wgZG9t YWluPyAqLw0KPiArI2RlZmluZSBTSUZfTVVMVElCT09UX01PRCAgICgxPDxTSUZOX01VTFRJ KSAvKiBJcyBtb2Rfc3RhcnQgYSBtdWx0aWJvb3QgbW9kdWxlPyAqLw0KPiArI2RlZmluZSBT SUZfTU9EX1NUQVJUX1BGTiAgICgxPDxTSUZOX1BGTikgICAvKiBJcyBtb2Rfc3RhcnQgYSBQ Rk4/ICovDQo+ICsjZGVmaW5lIFNJRl9WSVJUX1AyTV80VE9PTFMgKDE8PFNJRk5fVklSVCkg IC8qIERvIFhlbiB0b29scyB1bmRlcnN0YW5kIGEgdmlydC4gbWFwcGVkICovDQoNClBsZWFz ZSBkb24ndCBjaGFuZ2UgdGhpcyBoZWFkZXIsIGFzIGl0IGlzIGJhc2VkIG9uIGl0cyBtYXN0 ZXINCmxvY2F0ZWQgaW4gdGhlIFhlbiByZXBvc2l0b3J5Lg0KDQpBbiBhY2NlcHRhYmxlIHNv bHV0aW9uIHdvdWxkIGJlIHRvIHNlbmQgYSBYZW4gcGF0Y2ggZmlyc3QgZG9pbmcgdGhlDQp4 ZW4uaCBjaGFuZ2VzLCBhbmQgd2hlbiB0aGF0IHBhdGNoIGhhcyBiZWVuIHRha2VuIHRvIG1v ZGlmeSB0aGUNCnJlbGF0ZWQgTGludXggaGVhZGVyIGFjY29yZGluZ2x5Lg0KDQpJbiBjYXNl IHlvdSB3YW50IHRvIGdvIHRoYXQgcm91dGUsIHBsZWFzZSBhZGQgYSAiWEVOXyIgcHJlZml4 IHRvIHRoZQ0KZW51bSBtZW1iZXJzLg0KDQoNCkp1ZXJnZW4NCg== --------------LNhIUa17THGTpfpqC5kv1FfE Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------LNhIUa17THGTpfpqC5kv1FfE-- --------------X8D0eoeDEr15NPcmqFQSmGVr-- --------------bX2PESQviO3CpgKBjxM6PRjP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmOGJOAFAwAAAAAACgkQsN6d1ii/Ey/X Owf/aua5Zg2x6wG1EtP8f+LPoE4S7CXMbNsPRuJc3lrxAJy2A3cRWPRhcCxTD7Rhg5+Deg/hmK9F Kg9QZ/hn+OX8uRYWCe1drmegBHbZdzsN80+gj2sCLAiZ498b34yi+wsH+mLbqbxCH1On2FThaStv /Oo+GuuHTkBeUmfle6JSWWmaN6IHzo5O4R5JoUTjceSH8euhBxbBvPkQ7GzG+PxOfbk6P2LtdXGd oogYxsYxoVtnhvgEs7Tiw9V9DaeVTHN/aV5rqhAoFBC6HZ32i6W0CUFteW0+gLbHCqQ8ZD971aO7 Kr0yVPtS5wfiBF/FeTWC36Yd1pI1GGIb+aFimHJSyg== =3//U -----END PGP SIGNATURE----- --------------bX2PESQviO3CpgKBjxM6PRjP-- From xen-devel-bounces@lists.xenproject.org Tue Nov 29 15:53:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 15:53:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449509.706302 (Exim 4.92) (envelope-from ) id 1p02uX-0004Di-2k; Tue, 29 Nov 2022 15:52:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449509.706302; Tue, 29 Nov 2022 15:52:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02uW-0004Db-W6; Tue, 29 Nov 2022 15:52:40 +0000 Received: by outflank-mailman (input) for mailman id 449509; Tue, 29 Nov 2022 15:52:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02uV-0004DV-V4 for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 15:52:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02uV-0001ce-Dk; Tue, 29 Nov 2022 15:52:39 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[192.168.9.110]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1p02uV-0008Gk-4j; Tue, 29 Nov 2022 15:52:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=X+aui+FkEB8UVyBrf67Ons0+Mula1suZc8wR5AreFx4=; b=xYYaGpWK9aqHo7+IvHmEVWZ4WD Wy0Kk1WWwvQIl5ORr6DyWlfrsGsB8VtFC4yJVV/pDIpwORWKU3mWzPnrFGtep9Ivzb6FzR+RgoWvJ Etq/Ct5aqVtGxx4LlVlAmhcrw5ob/lgjc8qCvEsNoJgGTdaqrcGXVWaEnJS8S12QVT9A=; Message-ID: Date: Tue, 29 Nov 2022 15:52:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: Arm: AArch32: Need suggestions to support 32 bit physical addresses Content-Language: en-US To: Ayan Kumar Halder , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , "Stabellini, Stefano" , bertrand Marquis , Andre Przywara , "Volodymyr_Babchuk@epam.com" , Rahul Singh , Vladimir Murzin References: <70651dbc-085d-706d-17d0-a419086a0700@amd.com> <65891843-db28-e5dd-6e9e-3fb003fcabc5@amd.com> From: Julien Grall In-Reply-To: <65891843-db28-e5dd-6e9e-3fb003fcabc5@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 29/11/2022 16:23, Ayan Kumar Halder wrote: > > On 29/11/2022 14:52, Julien Grall wrote: >> >> >> On 29/11/2022 14:57, Ayan Kumar Halder wrote: >>> Hi All, >> >> Hi, > > Hi Julien, > > Many thanks for your inputs. > >> >>> I am trying to gather opinions on how to support 32 bit physical >>> addresses to enable Xen running on R52. >>> >>> Refer Cortex R52 TRM, Section 2.2.12 "Memory Model" >>> >>> "...This is because the physical address is always the same as the >>> virtual address...The virtual and physical address can be treated as >>> synonyms for Cortex-R52." >>> >>> Thus, I understand that R52 supports 32 bit physical address only. >>> This is a bit different from Armv7 systems which supports Large >>> Physical Address Extension (LPAE) ie 40 bit physical addresses. > >>> Please correct me if I misunderstand something. > >>> So currently, Xen supports 64 bit physical address for Arm_32 (ie >>> Armv7) based system. >> >> Xen supports *up to* 64-bit physical address. This may be lower in the >> HW (not all the Armv7 HW supports 40-bit address). >> >>> My aim is to enable support for 32 bit physical address. >> >> Technically this is already supported because this is a subset of >> 64-bit. I can see a use case (even on non R* HW) where you may want to >> use 32-bit paddr_t to reduce the code size (and registers used). >> >> But I think that's more an optimization that rather than been necessary. >> >>> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c >>> index 6014c0f852..4f8b5fc4be 100644 >>> --- a/xen/arch/arm/bootfdt.c >>> +++ b/xen/arch/arm/bootfdt.c >>> @@ -56,10 +56,10 @@ static bool __init >>> device_tree_node_compatible(const void *fdt, int node, >>>   } >>> >>>   void __init device_tree_get_reg(const __be32 **cell, u32 >>> address_cells, >>> -                                u32 size_cells, u64 *start, u64 *size) >>> +                                u32 size_cells, paddr_t *start, >>> paddr_t *size) >> >> This needs to stay uint64_t because the Device-Tree may contain 64-bit >> values and you... > > Are you saying that the device tree may contain 64 bit addresses even > though the platform is 32 bit ? There should not be any 32-bit address but you don't know what the device-tree is containing because this is user input. This is not the business of the Device-Tree parser to decide whether the value should be downcasted or rejected. That's the goal of the callers. > > I think then this approach (ie "typedef u32 paddr_t" for 32 bit system) > is incorrect. I am a bit surprised you came to this conclusion just based on the above. As I said before, there are benefits to allow Xen to be built with 32-bit (e.g. smaller code size and better use of the register). > > Then, the other option would be to downcast 64 bit physical addresses to > 32 bits, when we need to translate pa to va. > > Do you think this approach looks better ? Some of the changes you propose are questionable (see below). > Or any better suggestions ? Rework you previous approach by not touching the Device-Tree code. > diff --git a/xen/arch/arm/include/asm/mm_mpu.h > b/xen/arch/arm/include/asm/mm_mpu.h > index 306a4c497c..f4f5ae1488 100644 > --- a/xen/arch/arm/include/asm/mm_mpu.h > +++ b/xen/arch/arm/include/asm/mm_mpu.h > @@ -89,7 +89,18 @@ static inline paddr_t __virt_to_maddr(vaddr_t va) >  static inline void *maddr_to_virt(paddr_t ma) >  { >      /* In MPU system, VA == PA. */ > +#ifdef CONFIG_AARCH32_V8R > +    /* > +     * 64 bit physical addresses are not supported. > +     * Raise a bug if one encounters 64 bit address. > +     */ > +    if (ma >> BITOP_BITS_PER_WORD) > +        BUG(); I don't particularly like the runtime check when you should be able to sanitize the values before hand. > + > +    return (void *) ((uint32_t)(ma & GENMASK(31,0))); & GENMASK (...) is a bit pointless here given that you above confirmed the top 32-bit are zeroed. > +#else >      return (void *)ma; > +#endif >  } > >  /* > diff --git a/xen/arch/arm/include/asm/setup.h > b/xen/arch/arm/include/asm/setup.h > index b3330cd584..3f4ac7f475 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -119,7 +119,11 @@ extern struct bootinfo bootinfo; > >  extern domid_t max_init_domid; > > +#ifdef CONFIG_AARCH32_V8R > +void copy_from_paddr(void *dst, uint32_t paddr, unsigned long len); > +#else >  void copy_from_paddr(void *dst, paddr_t paddr, unsigned long len); > +#endif I don't understand why the probably needs to be changed here... > >  size_t estimate_efi_size(unsigned int mem_nr_banks); > > diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c > index 04c05d7a05..7a7386f33a 100644 > --- a/xen/arch/arm/kernel.c > +++ b/xen/arch/arm/kernel.c > @@ -46,7 +46,11 @@ struct minimal_dtb_header { >   * @paddr: source physical address >   * @len: length to copy >   */ > +#ifdef CONFIG_AARCH32_V8R > +void __init copy_from_paddr(void *dst, uint32_t paddr, unsigned long len) > +#else >  void __init copy_from_paddr(void *dst, paddr_t paddr, unsigned long len) > +#endif >  { >      void *src = (void *)(unsigned long)paddr; ... because the code should compile without any issue. If you were really concern about ignore the top 32-bit, then you could add a BUG_ON() (This is OK because this is init code). > > diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c > index df43621ee7..62774aebc6 100644 > --- a/xen/arch/arm/mm_mpu.c > +++ b/xen/arch/arm/mm_mpu.c > @@ -29,7 +29,7 @@ >  #include >  #endif > > -#ifdef CONFIG_AARCH32_ARMV8_R > +#ifdef CONFIG_AARCH32_V8R >  #include >  #endif > > @@ -414,7 +414,18 @@ void *ioremap_attr(paddr_t pa, size_t len, unsigned > int attributes) >          return NULL; >      } > > +#ifdef CONFIG_AARCH32_V8R > +    /* > +     * 64 bit physical addresses are not supported. > +     * Raise a bug if one encounters 64 bit address. > +     */ > +    if (pa >> BITOP_BITS_PER_WORD) > +        BUG(); Why not returning NULL? > + > +    return (void *) ((uint32_t)(pa & GENMASK(31,0))); > +#else >      return (void *)pa; > +#endif >  } > >  static void clear_boot_mpumap(void) > @@ -1007,7 +1018,19 @@ void * __init early_fdt_map(paddr_t fdt_paddr) >      nr_xen_mpumap++; > >      /* VA == PA */ > +#ifdef CONFIG_AARCH32_V8R > + > +    /* > +     * 64 bit physical addresses are not supported. > +     * Raise a bug if one encounters 64 bit address. > +     */ > +    if (fdt_paddr >> BITOP_BITS_PER_WORD) > +        BUG(); Same here question here. > + > +    fdt_virt = (void *) ((uint32_t)(fdt_paddr & GENMASK(31,0))); > +#else >      fdt_virt = (void *)fdt_paddr; > +#endif > >      if ( fdt_magic(fdt_virt) != FDT_MAGIC ) >          return NULL; > @@ -1165,13 +1188,13 @@ void __init setup_protection_regions() >          { >              pr_t region; >              access_protection_region(true, ®ion, NULL, i); > -#ifdef CONFIG_AARCH32_ARMV8_R > +#ifdef CONFIG_AARCH32_V8R >              printk("Boot-time Xen MPU memory configuration. #%u : > 0x%"PRIx32" - 0x%"PRIx32".\n", >                     i, pr_get_base(®ion), pr_get_limit(®ion)); > -#else /* CONFIG_AARCH32_ARMV8_R */ > +#else >              printk("Boot-time Xen MPU memory configuration. #%u : > 0x%"PRIx64" - 0x%"PRIx64".\n", >                     i, pr_get_base(®ion), pr_get_limit(®ion)); > -#endif /* CONFIG_AARCH32_ARMV8_R */ > +#endif >          } >  } > > @@ -1262,8 +1285,13 @@ static int __init relocate_xen_mpumap(void) >      if ( !xen_mpumap ) >          return -EINVAL; > > +#ifdef CONFIG_AARCH32_V8R > +    copy_from_paddr(xen_mpumap, (uint32_t)(pr_t *)boot_mpumap, > +                    sizeof(pr_t) * next_xen_mpumap_index); > +#else >      copy_from_paddr(xen_mpumap, (paddr_t)(pr_t *)boot_mpumap, >                      sizeof(pr_t) * next_xen_mpumap_index); > +#endif > >      clear_boot_mpumap(); > > diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c > index 62afb07bc6..a73bf7de01 100644 > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -2245,7 +2245,9 @@ void __init xenheap_max_mfn(unsigned long mfn) >  { >      ASSERT(!first_node_initialised); >      ASSERT(!xenheap_bits); > +#ifndef CONFIG_AARCH32_V8R >      BUILD_BUG_ON(PADDR_BITS >= BITS_PER_LONG); > +#endif BUILD_BUG_ON() are used to indicate that the code would fall over the check pass. I can't find the justification for this change in the commit message. It is also not clear why you are modifying this path because so far on Arm32 the xenheap and domheap are separated for good reason (i.e. lack of address space). Is this going to change with Armv8-R? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 29 15:53:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 15:53:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449514.706313 (Exim 4.92) (envelope-from ) id 1p02vX-0004mP-CY; Tue, 29 Nov 2022 15:53:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449514.706313; Tue, 29 Nov 2022 15:53:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02vX-0004mI-8d; Tue, 29 Nov 2022 15:53:43 +0000 Received: by outflank-mailman (input) for mailman id 449514; Tue, 29 Nov 2022 15:53:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02vW-0004m1-1W for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 15:53:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p02vV-0001df-Mt; Tue, 29 Nov 2022 15:53:41 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[192.168.9.110]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1p02vV-0008HQ-Go; Tue, 29 Nov 2022 15:53:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ilt3lKMFUm97J6gfNNDVmLkNJvhQNKtlk2lriTh3+Sk=; b=O+wuzDTjLfh6dJq7ma6yJdqYKK wYJ+goTyKI5gnBTO2kGmFUOwfdCZ0agFpM7/PAwc7JbscK512ZyEy1KB2RhEpDg4mcw7R0VZJ8gTD QN6/zPydvNXWQr/j5wSCsVr825HhwmaTPzOWwO3VQOrgbXma/5hLCyl+bU/B+que+miU=; Message-ID: <711bf14e-7059-6bf3-4337-c25d027cc532@xen.org> Date: Tue, 29 Nov 2022 15:53:39 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] Arm/P2M: reduce locking in p2m_{alloc,free}_page() Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 29/11/2022 15:39, Jan Beulich wrote: > It is generally preferable to not hold locks around allocation > functions. And indeed in the hwdom case there's no point at all to hold > the paging lock. Reduce the locked regions to the non-hwdom case, while > at the same time arranging for p2m_alloc_page() to have just a single > return point. > > Signed-off-by: Jan Beulich Reviewed-by: Julien Grall Cheers, > > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -48,7 +48,6 @@ static struct page_info *p2m_alloc_page( > { > struct page_info *pg; > > - spin_lock(&d->arch.paging.lock); > /* > * For hardware domain, there should be no limit in the number of pages that > * can be allocated, so that the kernel may take advantage of the extended > @@ -58,34 +57,28 @@ static struct page_info *p2m_alloc_page( > { > pg = alloc_domheap_page(NULL, 0); > if ( pg == NULL ) > - { > printk(XENLOG_G_ERR "Failed to allocate P2M pages for hwdom.\n"); > - spin_unlock(&d->arch.paging.lock); > - return NULL; > - } > } > else > { > + spin_lock(&d->arch.paging.lock); > pg = page_list_remove_head(&d->arch.paging.p2m_freelist); > - if ( unlikely(!pg) ) > - { > - spin_unlock(&d->arch.paging.lock); > - return NULL; > - } > + spin_unlock(&d->arch.paging.lock); > } > - spin_unlock(&d->arch.paging.lock); > > return pg; > } > > static void p2m_free_page(struct domain *d, struct page_info *pg) > { > - spin_lock(&d->arch.paging.lock); > if ( is_hardware_domain(d) ) > free_domheap_page(pg); > else > + { > + spin_lock(&d->arch.paging.lock); > page_list_add_tail(pg, &d->arch.paging.p2m_freelist); > - spin_unlock(&d->arch.paging.lock); > + spin_unlock(&d->arch.paging.lock); > + } > } > > /* Return the size of the pool, in bytes. */ -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 29 16:01:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 16:01:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449523.706324 (Exim 4.92) (envelope-from ) id 1p032m-000741-9g; Tue, 29 Nov 2022 16:01:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449523.706324; Tue, 29 Nov 2022 16:01:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p032m-00073u-67; Tue, 29 Nov 2022 16:01:12 +0000 Received: by outflank-mailman (input) for mailman id 449523; Tue, 29 Nov 2022 16:01:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p032k-00073o-U1 for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 16:01:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p032k-0002L8-Dg; Tue, 29 Nov 2022 16:01:10 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[192.168.9.110]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1p032k-0000I9-72; Tue, 29 Nov 2022 16:01:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=svQxUMSWfOExL3cPaeMnZg6XEheL7L8GNxXplaBauek=; b=i06g/gdK4Jbqmu9JcouK1zEgk9 cI3n40wuIaLpULkI9L2WAzFhfbp8aeVKaB0QuUZE1L/lYHGmZrJcaSKKkAiCh6pjg+gDySxRHij2f NIeIlqC5kHR/NLwL3s2YfbbQCqe2m9DRjsaYU6UBy0hC6edNZ8DDqVpW3WMdu4BMIcu4=; Message-ID: <4a93a89a-7d00-491d-766e-fd9a524d96c0@xen.org> Date: Tue, 29 Nov 2022 16:01:08 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] Arm64: make setup_virt_paging()'s pa_range_info[] static Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: <5a249b00-5467-1733-cab0-fd6d55765e20@suse.com> From: Julien Grall In-Reply-To: <5a249b00-5467-1733-cab0-fd6d55765e20@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 29/11/2022 15:39, Jan Beulich wrote: > While not as inefficient as it would be on x86 (due to suitable constant > loading and register pair storing instructions being available to fill > some of the fields), having the compiler construct an array of constants > on the stack still looks odd to me. The function is only called once at boot. So this seems more a micro-optimization than anything else. > > Signed-off-by: Jan Beulich Acked-by: Julien Grall > --- > Actual space savings could be had if further converting the field types > to e.g. unsigned char (all of the values fit in that type). This is a micro-optimization. If you want to send it then I will review it. > > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -2281,12 +2281,12 @@ void __init setup_virt_paging(void) > val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ > val |= VTCR_SL0(0x1); /* P2M starts at first level */ > #else /* CONFIG_ARM_64 */ > - const struct { > + static const struct { > unsigned int pabits; /* Physical Address Size */ > unsigned int t0sz; /* Desired T0SZ, minimum in comment */ > unsigned int root_order; /* Page order of the root of the p2m */ > unsigned int sl0; /* Desired SL0, maximum in comment */ > - } pa_range_info[] = { > + } pa_range_info[] __initconst = { > /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table D5-6 */ > /* PA size, t0sz(min), root-order, sl0(max) */ > [0] = { 32, 32/*32*/, 0, 1 }, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Nov 29 16:02:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 16:02:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449527.706335 (Exim 4.92) (envelope-from ) id 1p033s-0007aZ-LO; Tue, 29 Nov 2022 16:02:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449527.706335; Tue, 29 Nov 2022 16:02:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p033s-0007aS-Hn; Tue, 29 Nov 2022 16:02:20 +0000 Received: by outflank-mailman (input) for mailman id 449527; Tue, 29 Nov 2022 16:02:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p033r-0007aK-8G for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 16:02:19 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3119923f-6fff-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 17:02:16 +0100 (CET) Received: from mail-bn8nam04lp2046.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2022 11:02:00 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM6PR03MB5244.namprd03.prod.outlook.com (2603:10b6:5:249::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 16:01:55 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%9]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 16:01:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3119923f-6fff-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669737738; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=PrFm27z1zc0OwMZsL9ZXCzX0i1AqS6Wt1aNcTR+jTwA=; b=hShbwCB8Kq8lAvJLMAH0Y1/60AcM0ox8rDZbEmzSmdOLtQp4QtHrHLy4 WkFmJDOQ8cHUa4LbJl/PRdHzsaE+3Gyxkt+U49u6WSOs2w0MywQDur5YO lLNUueLjkwpGSWC05EnKapxF6K2gqsgmjAUe0MhU0i+m+cH+o7YbKaEOb 0=; X-IronPort-RemoteIP: 104.47.74.46 X-IronPort-MID: 84821706 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:GIHtg6jyEbRef41DEIXJ1eMDX161SRAKZh0ujC45NGQN5FlHY01je htvDDjXO6yINDDyeI93bIWy9RlV6pCHnN83QAZkqC1mRCMb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QWPzyJ94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQBcjRRfyDdoNmq0ZehVsY0i+YYdNbSadZ3VnFIlVk1DN4AaLWbH+Dgw48d2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilMtluSzWDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnzX+rAttNTOPQGvhCsG2W4Wc/MEQtV2CVqOurjxaye9RHN BlBksYphe1onKCxdfH5XhulsDuHswQaVt54DeI38keOx7DS7gLfAXILJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaESoaN2gZfgcfUBAIpdLkpekbhBXVT80lF7WplNrrAjLh6 zeQpSM6ivMYistj/7m0+UDvhzOqu4TTSQg09kPbUwqN6wJ/a4mNfYGk6VHHq/1HKe6xREGpt XwFls7OquwDZbmBnTKABuUEGqqk4d6BMTvBkRhuGYUs83Km/HvLVZAAvhl9KV1vP8JCfiXmC GfToQp59o5PO2HsZqhyC6qrAsojwKzIFtn/UP3QKN1UbfBZcAKB9gltaFSW0mSrl1Ij+Yk2M peaeMCjJXYCT69gyVKeWeob0rY3yzs+g3vaQZT61x2r0JKfYmKYTfEON17mRuQ46r6U5Qze6 9d3KcSH0VNcXff4by2R9pQcRW3mNlA+DJHy7sZRJuiKJ1I6HHl7U6OPh7Q8Z4ZigqJZ0P/S+ W2wUVNZz1y5gmDbLQKNaTZob7aHsYtDkE/X9BcEZT6As0XPq671hEvDX/PbpYUaydE= IronPort-HdrOrdr: A9a23:Cwpd36zQCMi0drvUTPQWKrPxTOgkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu vg2iMLnUvXRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirCWekD+y77b+Mh6AmjMTSSlGz7sO+X XM11WR3NToj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhn8lwqyY4xlerua+BQ4uvum5loGmM TF5z0gI8NwwXXMeXzdm2qn5yDQlBIVr1Pyw16RhnXu5eT/WTIBEsJEwaZUaAHQ5UYMtMx1lP sj5RPQi7NnSTf72Ajt7dnBUB9n0mKyvHoZiOYWy1hSS5EXZrN9pZEWuGlVDJADNiTn751PKp gmMOjsoNJtNX+KZXHQuWdihPSqQ3QIBx+DBnMPv8SEugIm6UxR/g89/ogyj30A/JUyR91v/O LfKJllk7lIU4s/cb99LP1pe7r4NkX9BTb3dE6CK1XuE68Kf1jXrYTs3bkz7Oa2PLQV0ZoJno jbWl8wjx98R6vXM7zP4HR3yGGPfI3kNg6diP22pqIJ9oEUfYCbcBFqEzsV4o6dS/Z2OLyoZx /8AuMTPxbZFxqfJW945XyBZ3BsEwhubCQ0gKdOZ7vcmLO9FqTa8srmTd30GJ3BVR4ZZ0KXOA pxYNG0HrQM0nyW X-IronPort-AV: E=Sophos;i="5.96,203,1665460800"; d="scan'208";a="84821706" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AvrwkeU1KKLrFVtFRShazNzuIgbpps74tarsGUo077rULOhYrgG/BDp8JUTGAAHwi5yonEOFET6w6agBRsV02D+UvlgBwOB7tuFfqQs6JBNokZVez8dOEEMxNaELvsLlfStlj/PMz+LwJcAJwRf+r9Au9afZqKKkf1OSz+1uiGzvaerHpAkxOFnOXQoUGhvewjjOyNbmCgRTCU5ZvI1Ajfe+vmDFcNGAreNo6eP5snzHb+J9ZsvBuVWPvKcRDPVSBqdMipJk9D6xhdR4I6VEbL9hAtCZGZGws0Wmrc+bwyoh8AuNPI05aoyF+rJenpzYB36WM2eNIuXnStxaZ3s2HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fq9Yk9+XavfdcBteaeRI2vnuzqi1nZvTGG84xVpeLXA=; b=UHiKlXVv4fd9PQbkvFkPvdwPUT7wzN0xi5FsJVF1nBy782GjEUsvilikqzEgcvXl+ACVxDmsz5gGlbn6b2tMiG8wy6UolxnE4Xlz9SNeK8vUR6+lnUWX6+x/rqCiODnZJfBKRbZmWIGloxLwCzmnybqPAGd/TjrQzSTDn8h1qZZeiCf1whRpRgjhPQSBhZ6igujcP8ksX94OV3+HJr3U4i6apWg1k7rWBL5N3F72aOwJ1dAYW3+eAu8QUQSn3h03pELVAU1UEyWkvxBjrhgGnygxkAhBnbkYXykvDxQl99J9bSphItgcH8U08Pu8NdJADaUPtk50eAr8spnSBwt+eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fq9Yk9+XavfdcBteaeRI2vnuzqi1nZvTGG84xVpeLXA=; b=cF1luohJt9+4TSL4IMn2mQDBseoyg1NliDTMG7tTJ5K/hPAmD7MT2vaRDON3E3aki5dhldmtOTKJsrK066j/HxkwvqoeFhh6ddt05a4WlJYuLyYqO6bg6kOWi5yNCI6vreRjiVBT5JnGD+p+n+2Jf9eEAm8kBokChkAQpyvxKig= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 29 Nov 2022 17:01:48 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, jgross@suse.com, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Alex Chiang , Venkatesh Pallipadi , linux-acpi@vger.kernel.org Subject: Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0 Message-ID: References: <20221121102113.41893-1-roger.pau@citrix.com> <20221121102113.41893-2-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221121102113.41893-2-roger.pau@citrix.com> X-ClientProxiedBy: LO4P123CA0182.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::7) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB5244:EE_ X-MS-Office365-Filtering-Correlation-Id: e8e615bd-9e8c-4010-1658-08dad223086d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HA7T8Wf1gDv3CN1nCTK4aKrdsbWF1i1yhBe7W3Opy97CmL+qqhFEpakYySBryLqPe2b2m2b7T0+UXTndNuuoIDFiwihyZYrvXXD2U4PgXLtD9uDwJsnApY9BqubhElQ3Uqq8DTwlF31NJE9VauFnKBxMfZmeU4EdjI/oAWiUVmqsSI00mHEisdWj1mZhfiwV2kp3A54HZDOAxpR/3JtUBHEX+lIJsU6JTzRLNp0yoM5W5Wxeh9XsuEScMe4qJU+RDEmhBqcVS8IDn8vHIeORzQxUH9qsKMQD1ZwS0R58/+BmuBihsLYnfdaAbKqHLVcKUx4ZKlrZWjc5Z8x0fKQw6Iuoi+e8jwC/PC2v8KRsvw9d4DK30UsLoHNlpzGFpjV6ero/Q+fOHKWQgmVXEMIZU5vTYSQbPBDn0p9AJ+9ADp8afIvKv27tz7dK0caLyEIZUZSC9fQj5eXVA895Mi8XHZPxNimsBWCLD439l1K+z+NSgFU9377EhtBaGdl/AuS/zv7DDUapYGBngbx4lFLAhuYyWhkGDTfLC39hQAL6sI+mnAyitFPjxKs+XV+Wr/MyfRIhV2rVG13PT8q2lB+jAMyE8dw3RFwfyfwaQ6nHKHmaXaEeDJ+nG5O18MhNmgSxrEl4ETGfh4t1d8+V8QwFJg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(376002)(39860400002)(366004)(346002)(396003)(451199015)(6506007)(82960400001)(38100700002)(85182001)(2906002)(6666004)(41300700001)(33716001)(8936002)(66556008)(66476007)(8676002)(4326008)(6916009)(54906003)(6512007)(9686003)(66946007)(83380400001)(478600001)(316002)(7416002)(6486002)(26005)(5660300002)(66899015)(186003)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UytGS1V2OU0yMS9hZmtKaFVTczlIOUZsNVp3Z2VabUVpQ0p3ZkxXU0dvb1N4?= =?utf-8?B?ZWpBUmpBaEpKN1V6Y3I1QmRpOFdyZ3VQZTJlYTBSVlRDL0FsR1ZwZjZHd0dB?= =?utf-8?B?cUlqY2luSzdTaGwvZTMrTVhjOUJ2cU80Q3VudStSL04vMStCOWJJTklmU3VC?= =?utf-8?B?SlZrTXBnS2lOTkdWVnhpdDBvNlh0RnRxMDRIcDVLSjRKWExYNFJmcFhrR08z?= =?utf-8?B?c3E0YjBMcThXZzlqdjJyQWJ0MmRzcWZrN0xnanU5UjB4bVhMQmswbmJGeGNP?= =?utf-8?B?c2M0V0JoYlRGeTg4Tnc0dG4wMVN0d0NWRUVPQTVIbkxhdjViblY2NEg0Ymhz?= =?utf-8?B?T0tpQ1Z2a3liVHhPeC9RLzJVZzlaSnVuVkFDRlh2THNjdk0wRFhzeGh4YWpS?= =?utf-8?B?UUNCR0NWOUtyUXFTTGxtekVjTGdHc0FkR21MZi9GNkMwckp2bjU5bkNxWnZZ?= =?utf-8?B?UU1OTVBnRFArZmVCNmo5T1BkRTh0aXVmTmhucHVHa3hnT2pyOFd5STV0TTZM?= =?utf-8?B?Q3pHWFlwLzQrUVZOT241eHo1dERPWGI4RVBEMElWY1FabzhWdGYxV1FzTWp0?= =?utf-8?B?aXM3Zk5wMHJnLzZvY1hKOElVZUEzbWxnRlFOOER4YmtHc1Y4WGdrYXFjMWJN?= =?utf-8?B?bnhDM0pVWGd0aEJQNm01SHNYMlVqMHArT3BHNTNndnpqbFRJdXprczdwVDFD?= =?utf-8?B?dU5UeXpkRmJ3M25DNU5FVG9uQjRzUnJiMXRYdC9PbU1udHE3UXVlWFdoZC96?= =?utf-8?B?dHU4SHBBQmlwRXg3Nk5Wemx0TzlxSmZ5Mm9UMFpyQURrT0xDYUM4eGN5OWFi?= =?utf-8?B?cFdpTWdWQzU1OHRjWDU5dm42L2xrQkJBNFBlSGs0azRCZWdZZFB5eHUvSWk3?= =?utf-8?B?dFBORkgwTzd5NnE4WVNCc29aanZZeUJOTkUvdmhHOXd4YTI0cnlhRVI1WDJa?= =?utf-8?B?VHFNUkVsSkFleE5QellpZXY5aUhjN1J4V2QvcndJQTNCbE5sLzFUclozWXlD?= =?utf-8?B?bnJPUVpYMnppNGU2TnpkdHlRdGJTLzdiUzhYb0RRbWdGQ0swa3Z6MEhYdmJl?= =?utf-8?B?TmM0OFN1T0VTeEhJTFFiUy9qbjFPbWZqOUdud0FJNy9HOXZZU0k0dlF1ZXdm?= =?utf-8?B?K2tYK3RPVDMzdU9Gc25TQUZoNDhkby84MWNFOWFwM0tML0V6WDRDcWtJbkFB?= =?utf-8?B?RmJXeG5JUndqbzNRbCtUaEExNmZuSUFPTEVYeGR2RkpUd1R4ek94Q1RuYmFk?= =?utf-8?B?RDB4L1JKalgwdlcrZmJMRllrVHFoTDl6QjVDdlE2QXFYQWxUdEhWY013Lzdi?= =?utf-8?B?WWxXSjhramJneGh4RXJJTksvd1FQaHpQeDh0T3ZwYXhSTjdMMFZqd3lNRDgy?= =?utf-8?B?YWtOR1NaN1IvT0NiYlRhdmhaNlVQakloSy9PQm0vOSs1T1pzYXM1ajMvUkNC?= =?utf-8?B?Sk1lakpzVGlkU09DQ2lyMi9ReTFpQnZmZzhiWE8xaUZXeEFPeExBRXNSUm9r?= =?utf-8?B?L3hmUkhsekR0QzBwdi9WTGdvWldWeUl6UDhlNFdvZzM3UDB1OTVFSEtmK0Fs?= =?utf-8?B?OHVJRnVPcEZBWXViSHluN2pDZ0VwM3NLWmR3T0U3bjlQTGdaZytjVk4xd1Bk?= =?utf-8?B?cTlmOUtPM0h6Sm9tMmMzS05NSndDU0QyVnF0czVhMU9lUUU1cDJxSnZ0MnYz?= =?utf-8?B?eHVwdi9vb2plMW1DdXBWdXpzWm9KZVhxWlhvNjhlb1BHUlRlWXlxVDUxT2FM?= =?utf-8?B?ZzAzeDJqYmtjN2VUQ2ZLcS9yZnZtQkxXWDV1UmRUTm1RNVQ2cVJZRm5XcWhr?= =?utf-8?B?L3hyRHpoa3lQUDJrL3hhK3RIOVR4R0cxUzVudjN5Tkk5NHl2a294MTl2UVd0?= =?utf-8?B?SkROZmltQ0N4QnJGRCtNSzlOdUQ5bm5YNmJld0ovTEhWSGFMeHFNMUVwUGhO?= =?utf-8?B?bi9oUEpoZkFSYlJ3MlNpYWhXT1M5a3dnR3ppNmcxM1M3UU80NUVRVkpCTFVN?= =?utf-8?B?VkFaSnZSYXhJeFU3dzhRT3pRckRBVVR4VmxnZHN1YVh1aGdraVRZanpPQ0U0?= =?utf-8?B?Mmd6NWlrMnBYSGl3N2hTTlhPT3FGbkxwVmZaMHZ6Y2ExQlFmQStSczJIeW1Z?= =?utf-8?Q?9ne2cgVqjQRCRBBaK3tyRaFqS?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?aWJ6dUIyckhtV2hJdTM3ZmxUWTBWaTRXelcwNGhVdXVjZlpiOFhiYzZTemlH?= =?utf-8?B?a2VhQTJTUzViNU5WMGFkYTNHM3JIVThxNnhkelhtbDhvcHYraUszbE0wVkZ2?= =?utf-8?B?Z09uOUpGSWh6Q2FjVG5SSTJCTjU5V0lpMFJFN2NYS29sb2NuSklKcndlaE5K?= =?utf-8?B?RTNpNzR1NU5jVGtpM2tUYmN1ckdIRXlXRTBKb0F4QUp0Zk1reXczNFI2eXFP?= =?utf-8?B?M3NwK0lNV0VtbTk1RWx1TDVkV2lvMUJKUTZwOXF4RVBnQVhjcWtNOTZ5TzhN?= =?utf-8?B?ZnpQMlFTSExselhZdk5HNVJlam01cDQ2cE5EZDRabHJNSDJWZkd1MmhKNmcw?= =?utf-8?B?enQ5WklDT0t6WE1PM1AyMFphYnhod3JHaDNvVmVlNk1IK0QxKy8zSndVRU8v?= =?utf-8?B?bDNoOEZ2WS9XblJsNGFkcmZwSVIvSWhKMXFaNzB1aG8zRXpVZjlQQ01nZ1lN?= =?utf-8?B?YWlEMjFTckVxVHNQZ3hxaXJEQlFBeDlUMVN2QWJzK3gyZDZkNzVKejd1Qncw?= =?utf-8?B?VjhSWld3NHdjMjZLWEFHU21tQ0RYSG11cHdMNHcvM1hGMXIyTUdPMW9YYThB?= =?utf-8?B?NEZ6SlcyMWxRcGRvakMrUEkycWkvbjNGVUlhS05FNXlMZmRQY1BJbCs4TkVS?= =?utf-8?B?amNBN0R6ekpFU0N3cS9NTEFwZ2VvWTQ4Y3RyZzFsd05paW83TU8vamlzVEpY?= =?utf-8?B?b1RjZUgwN1Z3WElleGt3b210bnROZHNIR0lKbDFNQ2xSNFZPZWlRK3FNTEZo?= =?utf-8?B?RXZza3o3M0VPd0VEMlJsYng4M2hkbThuMGlSQVRYTlZDcXN4a0tTNkphcjI5?= =?utf-8?B?ekNsMXVBTjl2UmlaZ1p1T1VtcWpZcG9aemF0RnJUbk51NysycmczcitMRGVE?= =?utf-8?B?b2N5NlVCVlF3UlZVanNydzRkUnJQY3lQa0tFVTluZVFvc0pXallibU1rT3l4?= =?utf-8?B?Y1R0ZlZzRnJwcXRDeGZ0MXhRL1JWandibU4xczlqRmdya1AzT3dyNTFxRkVl?= =?utf-8?B?R1FrS25ZMCtkOXBURnZuMkFxbWx5YUloYUpXb0hHQVFSZjBTMXVDNHVtaEc3?= =?utf-8?B?N3AwY1hCTjQ2c01MLys3cFVSdkg1dXZMKy9WTVA1L3FyWURpREM4N2lVZzB6?= =?utf-8?B?aUtxRmE4bmV5elNpWC9SNUtubEE1VVpWbW44REcva1FiY1ZzaVpGVngyaWV6?= =?utf-8?B?WEQ1eWhUWGlZTVp6YjJUT0FxaTBiV2xZVmkvUUpQL2EveVRwSXNycFNVODZK?= =?utf-8?B?SGlNZWNSb1QzeW5xMWwxSWhyYUl3ZERnMmZCY2t4Q1RHdVRXYkVNZ3F6ellp?= =?utf-8?B?dE80b0RaWW05YUZZRDVFOE92ZjVSeVEyUUxGaWhXRSsvUjNNZjJQN2JycGZl?= =?utf-8?B?OTVObGpOZlBzTTcyVWJBeHBMNzlQbzhJU0FTWW04Sy9kMlhHaU1mUHZUd0cw?= =?utf-8?B?bzNiUnZMZy83clRIOWI2a2lEYTRSQ1V5NUp4RWJPSVBUTXdTbnVIb0FXdEVa?= =?utf-8?B?U25GNUNRSm5QcXlzZ1NVcXdQTy9wMjRGUjBQWmkzNnF2M056ekdCS1BBcm9V?= =?utf-8?B?RUFrb0N0RXZNd0Z4RTdacUVRVVhhMFZNVWs3V3YxMEFwUnY0TS9oaVRScWI3?= =?utf-8?B?eXdRajNzcHZia2l1bC9SZVlzL0NmUkE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8e615bd-9e8c-4010-1658-08dad223086d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 16:01:55.7989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B+Ohft/lEiLlv+nC2UdjGvYOB2wWA8CbPqEAGiEhOf+0iPtPXy+DqnzhyyKr7H588AEViNl1oGKx3ttKH8fpUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5244 Ping? So far I've got some feedback from Jan which I've replied to, but I haven't got any more feedback. Both patches 1 and 2 are required in order for Xen dom0s to properly handle ACPI Processor related data to the hypervisor. Patch 3 can be deal with later. Thanks, Roger. On Mon, Nov 21, 2022 at 11:21:10AM +0100, Roger Pau Monne wrote: > When running as a Xen dom0 the number of CPUs available to Linux can > be different from the number of CPUs present on the system, but in > order to properly fetch processor performance related data _PDC must > be executed on all the physical CPUs online on the system. > > The current checks in processor_physically_present() result in some > processor objects not getting their _PDC methods evaluated when Linux > is running as Xen dom0. Fix this by introducing a custom function to > use when running as Xen dom0 in order to check whether a processor > object matches a CPU that's online. > > Fixes: 5d554a7bb064 ('ACPI: processor: add internal processor_physically_present()') > Signed-off-by: Roger Pau Monné > --- > arch/x86/include/asm/xen/hypervisor.h | 10 ++++++++++ > arch/x86/xen/enlighten.c | 27 +++++++++++++++++++++++++++ > drivers/acpi/processor_pdc.c | 11 +++++++++++ > 3 files changed, 48 insertions(+) > > diff --git a/arch/x86/include/asm/xen/hypervisor.h b/arch/x86/include/asm/xen/hypervisor.h > index 16f548a661cf..b9f512138043 100644 > --- a/arch/x86/include/asm/xen/hypervisor.h > +++ b/arch/x86/include/asm/xen/hypervisor.h > @@ -61,4 +61,14 @@ void __init xen_pvh_init(struct boot_params *boot_params); > void __init mem_map_via_hcall(struct boot_params *boot_params_p); > #endif > > +#ifdef CONFIG_XEN_DOM0 > +bool __init xen_processor_present(uint32_t acpi_id); > +#else > +static inline bool xen_processor_present(uint32_t acpi_id) > +{ > + BUG(); > + return false; > +} > +#endif > + > #endif /* _ASM_X86_XEN_HYPERVISOR_H */ > diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c > index b8db2148c07d..d4c44361a26c 100644 > --- a/arch/x86/xen/enlighten.c > +++ b/arch/x86/xen/enlighten.c > @@ -346,3 +346,30 @@ void xen_arch_unregister_cpu(int num) > } > EXPORT_SYMBOL(xen_arch_unregister_cpu); > #endif > + > +#ifdef CONFIG_XEN_DOM0 > +bool __init xen_processor_present(uint32_t acpi_id) > +{ > + unsigned int i, maxid; > + struct xen_platform_op op = { > + .cmd = XENPF_get_cpuinfo, > + .interface_version = XENPF_INTERFACE_VERSION, > + }; > + int ret = HYPERVISOR_platform_op(&op); > + > + if (ret) > + return false; > + > + maxid = op.u.pcpu_info.max_present; > + for (i = 0; i <= maxid; i++) { > + op.u.pcpu_info.xen_cpuid = i; > + ret = HYPERVISOR_platform_op(&op); > + if (ret) > + continue; > + if (op.u.pcpu_info.acpi_id == acpi_id) > + return op.u.pcpu_info.flags & XEN_PCPU_FLAGS_ONLINE; > + } > + > + return false; > +} > +#endif > diff --git a/drivers/acpi/processor_pdc.c b/drivers/acpi/processor_pdc.c > index 8c3f82c9fff3..18fb04523f93 100644 > --- a/drivers/acpi/processor_pdc.c > +++ b/drivers/acpi/processor_pdc.c > @@ -14,6 +14,8 @@ > #include > #include > > +#include > + > #include "internal.h" > > static bool __init processor_physically_present(acpi_handle handle) > @@ -47,6 +49,15 @@ static bool __init processor_physically_present(acpi_handle handle) > return false; > } > > + if (xen_initial_domain()) > + /* > + * When running as a Xen dom0 the number of processors Linux > + * sees can be different from the real number of processors on > + * the system, and we still need to execute _PDC for all of > + * them. > + */ > + return xen_processor_present(acpi_id); > + > type = (acpi_type == ACPI_TYPE_DEVICE) ? 1 : 0; > cpuid = acpi_get_cpuid(handle, type, acpi_id); > > -- > 2.37.3 > From xen-devel-bounces@lists.xenproject.org Tue Nov 29 16:06:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 16:06:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449531.706345 (Exim 4.92) (envelope-from ) id 1p037Z-0008F0-4C; Tue, 29 Nov 2022 16:06:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449531.706345; Tue, 29 Nov 2022 16:06:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p037Z-0008Et-1G; Tue, 29 Nov 2022 16:06:09 +0000 Received: by outflank-mailman (input) for mailman id 449531; Tue, 29 Nov 2022 16:06:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p037X-0008Ek-T1 for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 16:06:08 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b979c7c5-6fff-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 17:06:05 +0100 (CET) Received: from mail-dm6nam10lp2102.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2022 11:06:04 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MW4PR03MB6524.namprd03.prod.outlook.com (2603:10b6:303:127::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 16:06:00 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%9]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 16:06:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b979c7c5-6fff-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669737967; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=NgA/STj9ezoZwb+INqHgunJ3U0p4UEDJ0v8AQ1j1ZDs=; b=Urnk5dtWecCf4oMIXRXLyeXHVJVr2z0F6J1HPKxqTHBzaVN6Ku+POGJp kaYoGcf3uTLzwj3LRCIjsrP3FzyjgKNoBwoDXVJoSXMnc4aLKzc/1SHuL Mscn7rapFAzM/Ai/8Od8K09r1pzJiNJiYDVURz/tdJamrO1m3U7wWkQOI s=; X-IronPort-RemoteIP: 104.47.58.102 X-IronPort-MID: 84822302 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:MWCKoKzBwabz8Ip0v4J6t+cQxyrEfRIJ4+MujC+fZmUNrF6WrkUAm GtKWm6PO6uMNmH2LY0gPNy3pkNU6sDSztMwSwtt+SAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnP6ET5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KUdu1 fwiJSEvUkDZqNms7LOgZvZ2i+12eaEHPKtH0p1h5RfwKK9+BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjiVlVQruFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE1rOfx3mgANh6+LuQp9c6w1izwWIvMBgGUXG1haXm0h+BYocKQ 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRwtJWFRHTb8a2bxQ5eIgAQJG4GICMBEw0M5oC7pJlp10qVCNF+DKSyk9v5Xynqx CyHpzQ/gLNVitMX06K8/hbMhDfESoX1czPZLz7/BgqNhj6Vrqb8D2B0wTA3Ncp9Ebs= IronPort-HdrOrdr: A9a23:pN1mE6/EQCR3mnOC/E9uk+G4dr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpixBiSgSiu4LvaFQHd+hsFSTtAzZor7G CAymXCl++emsD+7iWZ+37Y7pxQltek4txfBPaUgsxQBiTwhh2ubIFBXaTHmDwuuumg5Hsjjd GJiRY9OMZY7W/XYwiO0FDQ8jil9Axrx27pyFeej3emicvlRAgiA84EoY5CaBPW52cpodk5ic twriqknqsSKSmFsDX25tDOWR0vvk2ooUA6mepWq3BES4MRZJJYsIRa1kJIF5UrGj789ekcYa BTJfCZwMwTXUKRbnjfsGUq6NuwXk4rFhPDeUQGstz96UkioFlJi28jgOAPlHYJ85wwD7Ne4f 7fD6hunLZSCucLcKNUHo46MIWKI12IZSiJHHOZIFzhGq1CEWnKsYTL7LI84/zvUIAUzaE1hI /KXDpjxCEPknrVeI2zNaBwg1PwqD3XZ0Wu9ige3ek0hlTEfsurDcXZI2pe1vdJoJ0kc7/msr iISdZr6sTYXBvT8LZyrnPDsqZpWAgjue0uy6IGsgG107X2A7yvkNDnW9DuA5eoOQoYewrEcw g+tX7IVYh90nw= X-IronPort-AV: E=Sophos;i="5.96,203,1665460800"; d="scan'208";a="84822302" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NPYmice7Tzb+zIYA4INp3laMyoRCkUzjok1mkzHLmwUvucfU7Fi4bSv5kfHraPC8AfpcllVmZ7BnOrAvTp7OB/cuTVFQDHz0ZA850m/TIpGidVayopUl10mwFwaMcwKfPMm+ZrLx5yXUNtlaujq/ogUli+GD/Jh0c3mT5bTQ8IoEJw197V4rjr6cumNipWhzatCtmOsanHG3vGA8AHT6Qmikyz2JrS9P6xWhW4J1Ye9o9l5IyM9sTP/6NE8ZLnRy0pki48oTjjBjrBR8odAlAZzpXYrK/76yjciG5BU7v1ue083lyc5Ej2fTfXQC5/BS5l6ISXMzIIxKCbXC7y3VQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fzbSsX3HDf7CfnUgJV7rp+sWAYeSupJsGqT9bocxve0=; b=Giyu8nzr96q6ZfjbqSYoSn5qRqCtZMgvUG+IVLv8O4ZVyloRuuMtvV1rFTZNWvBa/nwmljErCFIXi0jOtkgq0moRLotmV7Jdhst52rOPXNUAl7mCZWX8EzLHpLttg0usmTDRxE82AFuFvxjJ3QVLVyapc29c2bTZlwRX6iaf8cpLKSoTuOT+Cp56xDhvF8Xs0+9vQeqKf3g3dAxgLyDWWbgX9srExGEF+zb7fxROePScjiBTnwVAsASHCwxw4Tb3DBkH5nkaRhbNLupTE31BFN59ml5BY6yT1Zk6Rns+BCDVs9fi5EgrUm4eZ8vW7BqguC/cYXkSVkxmLs79tInXdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fzbSsX3HDf7CfnUgJV7rp+sWAYeSupJsGqT9bocxve0=; b=G61/WnGsfObQCCjBsv5in2rM5hI3EGpoRaTs7VkVSXfSpzpymDZLPhS4/V4aHWD+Trqr2U3LuSt5QSPLHHdy4BUzEL03Wrq+haIgwFSgVE0Z0SI/+G0AIrbABmMsRRL/O+kTzw5RBzjxexZrhBA3OYSduOyYscohFwNtaOMUOEg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 29 Nov 2022 17:05:55 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/APIC: make a few interrupt handler functions static Message-ID: References: <54ee1bd7-9b6a-efc7-8bad-50aa7d6d955b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54ee1bd7-9b6a-efc7-8bad-50aa7d6d955b@suse.com> X-ClientProxiedBy: LO4P265CA0260.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::11) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6524:EE_ X-MS-Office365-Filtering-Correlation-Id: 56a4cc9e-0823-4a93-3fae-08dad2239bbb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RoN+fHEi3ButdXSTrjZWaktWpQjIZVFK5v2q1M6hERw7VNekz+9Sl0OP4OYIHEF853bs5FwMwmTR44iTi8SpQ8wsMBKL5mOovcbCr64s+8ShGxhHJno33kS2KARCUnAqvwcQ7HInobk7Rw1XqbOI73j6AyIcVV+m20cKoi5O0v++YSv+CSKVa6iSgMU1DBUpbA0O8QStrxVrl3zZTNsxYdnAJ/B96HEIyILBRqvS/tC+Sd7wImQ+0nEaN4IjaAAIUfWP9nh2HIGuBEnEPU9c8409IhLD0o759XznxOz5zR91/ElyK3kCZPZEhLywOd61BeqBRKO23YnK0eD48UAwOqbaIwyAUppD26WnmE0qZmL0Feldn7G0qYk3bKighjij4WlA0ckttcagXRXUdN4QEKLlgeZ+TRY43FD5jtc18eqEP27YXN1UiaApO7W4dG7VAaydywat2KDIsXXn8RMGRr9Gc5z6I3wRxg6LEEGA9pxGWVowPl9rFV8Do9VZj/W1W1IfGvfcy+YCqw/fElCQ0b/FH8srWanqFk+SiPvhXDOmN2E8jah1/8/on+s8lhRMX2eOo6HjB2IZRl7oszkBjCdD9ijgVyk5YDPHQnHcjj/gb8OSfX4w1F92CB98PJCR+ifq8IHuuC5fpT4XhyktyQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(366004)(376002)(396003)(346002)(39860400002)(451199015)(2906002)(41300700001)(8676002)(4326008)(66946007)(66476007)(66556008)(316002)(85182001)(6916009)(8936002)(54906003)(5660300002)(33716001)(26005)(9686003)(478600001)(86362001)(6666004)(6512007)(6486002)(6506007)(186003)(38100700002)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUVwRjdSSmhIMVhSU1kvWFY1RWFLVm9UYmJ2em5IUkE3Nzk3UzFCNURTY1Rj?= =?utf-8?B?SkhqNFlPeXZrWHJKMDJvdmdOdW1OY0NYOXVSUjdkNzlCSzJzandKTk82ZWVx?= =?utf-8?B?M2RFWUJ1ZDgwS0YzZGpwV3Z1bWRnWnlKTDFRcHNTSDRybnZ4VWNVbVVMRHZu?= =?utf-8?B?SVN2VXBuVjJicXVVNHNGUEVRL1Z2cndqTDlQWTBGL3VzaTFOUWZtSWR6K29y?= =?utf-8?B?Q25qYVBBcmZ2cHNFSUtJazJSVFRCcVdvVGRZMkZLcXZzT3hFaEcramN3V0Rm?= =?utf-8?B?akpaMnloMmpOZzd6eEUvMGNIK1BOWVl1OGZoeTVEOWR2aFM1TzlwR3YzVkZC?= =?utf-8?B?Mm1lZTdSYnpHdS9GRUgzYks5aGlpZDh6dmRPOTA4NzB1VVFJZEhWVHhTeVla?= =?utf-8?B?Vm5uNENkMHNkNEpNOXlRcEVlMkt4MWU4cHQ3eDR3YWxNd3g5UGM3aFY2QnFo?= =?utf-8?B?K3prQ1FXQWpVTnhnQWY3blVyUzZEKy9NMEpBcXVXRk9tRU45QVRtall3VWFi?= =?utf-8?B?L1BZSGtVcVV0QWZ6OGd1elhNTkRnZHp6U2VvdzNXR1FVemF5UFZMc2orWEYw?= =?utf-8?B?VEY4VngzNlorT09aZHR1ZG1RRGs4VUpFVkpEMUd5K1o1K0xHZjVvVjZVZE0w?= =?utf-8?B?ekFHV2ZRelg4RmQ0VVNhMmFqM09CdUozdjVwY29zZVBMTmc3QVdIajVCYzg5?= =?utf-8?B?VnRQcWlTaE9Ya2pDdkc2TFY4ZDAxY3Nlb1U4K2prMmFQR3RCd0hBa2tqOWlp?= =?utf-8?B?dEkySnRMN09RaDZIV2Q5VUZnbUQ1MW5WRHV1aU9lS1o3cmF3cHhRc25ZbXdy?= =?utf-8?B?VHhlNkhJdGtKU3R5L0I5WjE5VmlpZTVtWk04aUxiSXlpcEpJNGJtZ0c5SDJU?= =?utf-8?B?QU96TUtLaWVETDRRSnZMNVkxZ2wvQ3RBc05HVnhJdVdGZWgyTW16QjdGeXhZ?= =?utf-8?B?SUZoT2JMMnlGenBhejg2QVYwTzlsV01jaTkvVTNNdTBZL0QxZHdzMUdFSmNp?= =?utf-8?B?TzhraUxtZjFtb1JzSGpnM3grLzc4eitFa1Qram80MmZlbkRDcS9aUEp5bjJo?= =?utf-8?B?ZC9uN3RVVFl6YjVIa3dKL3ZCK2F4d294ckZoY1VXM3dqaVpKd1F3SFUxY3lQ?= =?utf-8?B?UzU0SmxhMVRxdURCcjRDYkVZSjBQMkNSaXRodlFuOE5OR0o1UXppK0ZtUElz?= =?utf-8?B?RnJwZE8vejRTaHlhMUszQzJIRm1EQllHVStvekVONUg4WW5oVjFSUVB2d3JV?= =?utf-8?B?L0dITlJrdkFZSEFESCtoL09EM0FYSUNnRzZjUlNpZ1NhQ1o5a0VDN3J3V3h2?= =?utf-8?B?SGtwUHRhOWlZb0g5S083WVVpMmJGZWRvazczS2dUYm5YK09KS045UXhleGV6?= =?utf-8?B?SEhTZksxT0Ryc0VCRU9uWjQ5MXJYTkVwWHZ4L2JsTk9ZblZRaHZhc1hqTldq?= =?utf-8?B?a3U2TWdCVmRrTTZybUZTS3BSdnpKQTJZVGFWL2MreDFOQyt5c2hoakg5a01M?= =?utf-8?B?R0NjUzJYOC8zRk0veWpoZlhYVFlIL2VkOGFHMEtOMGhoN0ovTlhHZGxwb2lI?= =?utf-8?B?SFR0d29kVVpuWGxMdmxlODlxSkIvZDdYNmJJWHRjYStQZEMxVmhWWGN0REJC?= =?utf-8?B?emF6eGcrd1lsaTZHekdjcVgxNVB1NWMrSmp1NTlXZVBLaVhDd0Q4VDNGUkk4?= =?utf-8?B?UUVtT3hDQ04wUENySGpmUWI1bDFSbnd1d1g5dHB3Z1piSVlVb21BVnJWVHVR?= =?utf-8?B?YlBvNVd0RjVJbXkxbW9DSVFSekNwYlNaT0o1MjhLZ1I2ZTNCdjduN0JDcHpy?= =?utf-8?B?NTNwNTk5dVVhalA2aytpZGt4UERBRVpGaXR1aUNDVVZzeW1DN1Q1L2huR0xQ?= =?utf-8?B?Yk1PZmtldTBTYVc5alB6a3NUWkpzaFJmR0xWM2x4WFZKa1lndWNOOFNCUHB1?= =?utf-8?B?WGJqR2NzV3VMcmkvWUQ2SzRBUVBZRUJUNTNrbmovQVoyUFBDVzgyc2pSRjRK?= =?utf-8?B?ZkFxcjdwYUprcmplY0JsVmJ4bjBGa0NFcm44WSsyUlF1U1FkT0h1WVJrcVF5?= =?utf-8?B?SE5jUHpGb2FDUFdsZnkzeVUrRlJlcmNkeFpKOS9KNEhhM3BEREJsK2FicHpn?= =?utf-8?Q?RI60PH+QFAMxnhtLtPPRfUseN?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: wmwAOwjfk7mS5vkyFMna+ysacGUTMzF4cWT1GsKZOpuw9WtBS0iRFsPHY5yMx3hy/HMylXM1vza8gPXzq5UtxBGqxlQbB9AiHtI9uAGjKwJq8SLuNeYJxcpXg6fflZcHolnWsZVFKt43IQAhUuS1zQsbQqeQyIOVGxMQFLop7Nm21ZrwsTukb4C6dl+n3QtLMQ/LpI6au0BgNwfNkJHQWgbEbBClbb+xG3QeD7pR0zD3/iIDcQhUBFBLUf+P3FOQhQx3z13relKm0YuxB4MW6NL1S8j9btgzTXZrKmRWWaA0aUIRgPVIJOzfZMAqTpYM0TlhBBLbHuDOp1yhB0HhRXK/C6gtvnVKBkE0sS9ZiN2lWKV0X/+UnzY+uUx+DNyN7WxW1KcT5XhKbqmAizmWkb2P6j6dN/aQCpUhIqu9Xwrt0Wxr7axzYCCl+Fz3QF4bOWMwGNNKmtQD4/FWPQ1hy2dO1KI1LdpOT+vexVRPyAaSTpWnFxsHsPPk9C1X0Znqvrt3Ms4D9wbm2nJHQINi6PlbHBgcYq9KNCyM43qpG3iFYH2oKYVzupIKDJufwl9k/i9mal3kM9QQn+iv0Ud34dgNyswKnY/g6Ic0ZXMZCh9mwL95JwPv6w5n93YMm2C/j3pG2DA6/rgs9f9XmrxT1r7wYTYtRX7y8zXW8uO28OM3Lmsry3Elm8VJqpRyx0Cj9DXNlx9q6b5syxLwcDur2ryZVqlIReDZQW27jYQkKRtOs7PCFqXsoog0k436hVCOovPyyKKwJRGk3Nv+5di/e4+wx65OTObTdUrXfGjaIgGW9PZHqOfS4j7b/7GpmxFo8XTEkjK1kfufByFRdmBt5Q== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56a4cc9e-0823-4a93-3fae-08dad2239bbb X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 16:06:00.8211 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4ESWk5NzCyuCp8AHAYO/1Bb/IQoYHsOJDeYIjzdJPVqeupjnEgNdADqzsv86Znf/SVA/CjlAMWhOQmxxy1fnxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6524 On Tue, Nov 29, 2022 at 03:46:30PM +0100, Jan Beulich wrote: > Four of them are used in apic.c only and hence better wouldn't be > exposed to other CUs. To avoid the need for forward declarations, move > apic_intr_init() past the four handlers. > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné A nit below. > > --- a/xen/arch/x86/apic.c > +++ b/xen/arch/x86/apic.c > @@ -127,21 +127,6 @@ void ack_bad_irq(unsigned int irq) > ack_APIC_irq(); > } > > -void __init apic_intr_init(void) > -{ > - smp_intr_init(); > - > - /* self generated IPI for local APIC timer */ > - set_direct_apic_vector(LOCAL_TIMER_VECTOR, apic_timer_interrupt); > - > - /* IPI vectors for APIC spurious and error interrupts */ > - set_direct_apic_vector(SPURIOUS_APIC_VECTOR, spurious_interrupt); > - set_direct_apic_vector(ERROR_APIC_VECTOR, error_interrupt); > - > - /* Performance Counters Interrupt */ > - set_direct_apic_vector(PMU_APIC_VECTOR, pmu_apic_interrupt); > -} > - > /* Using APIC to generate smp_local_timer_interrupt? */ > static bool __read_mostly using_apic_timer; > > @@ -1363,7 +1348,7 @@ int reprogram_timer(s_time_t timeout) > return apic_tmict || !timeout; > } > > -void cf_check apic_timer_interrupt(struct cpu_user_regs *regs) > +static void cf_check apic_timer_interrupt(struct cpu_user_regs *regs) Given that the function is now not exported out of apic.c, wouldn't it be better to drop the apic_ prefix? The same would likely apply to pmu_apic_interrupt() then. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Nov 29 16:22:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 16:22:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449541.706357 (Exim 4.92) (envelope-from ) id 1p03Ms-0002ZC-IC; Tue, 29 Nov 2022 16:21:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449541.706357; Tue, 29 Nov 2022 16:21:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p03Ms-0002Z5-FZ; Tue, 29 Nov 2022 16:21:58 +0000 Received: by outflank-mailman (input) for mailman id 449541; Tue, 29 Nov 2022 16:21:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p03Mq-0002Yz-P3 for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 16:21:56 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id efc4751e-7001-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 17:21:55 +0100 (CET) Received: from mail-dm6nam04lp2043.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2022 11:21:52 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6473.namprd03.prod.outlook.com (2603:10b6:303:120::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 16:21:50 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 16:21:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efc4751e-7001-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669738915; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=MXW05O58NixGhXdhHN3mZrIM0EL887lxF/qHl1K1M4k=; b=Lisn2eW4KEieo6vTh3djCzsNIzgtdR+Pf8n95J2dgSNUFaFMa+8OUdwi 9SQN9wfc0rcORb29egzt608EZGSnngpgQV+uhMGeg3rqfB/omDx5Dd3O+ /SdVqafOuhlxue+VahGyF2eR8+blLDr6OjJyK8jeI/NV/qCP6v180FP0Z s=; X-IronPort-RemoteIP: 104.47.73.43 X-IronPort-MID: 84824054 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:HeUm660EchBNsGrBePbD5fBwkn2cJEfYwER7XKvMYLTBsI5bpzFTm jNNUD+FafiNZWD1KtlxPIWw9UoA7ZaAzoQyHlY6pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVkNKgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfMU1n7 u4kLAk2YS/errvuxuOLY9FKv5F2RCXrFNt3VnBI6xj8VapjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouC6Pl2Sd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzX+rAt5KSeHQGvhCr3adx0g2KT4tcEqXm8WzshKfZNlwJ BlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWKTVqN+7HSqim9URX5NkcHbC4ACAcAvd/qpdlvigqVFoo4VqmoktfyBDf8h SiQqzQzjKkSishN0Lin+VfAgHSnoZ2hohMJ2zg7l1mNtmtRDLNJraTygbQHxZ6s9Lqkc2Q= IronPort-HdrOrdr: A9a23:JWVQfKFrUlkcLDJUpLqFwJLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oK+RSDljSh7Z/9Cly90g0FWz1C7L8++S yd+jaJp5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjow4OyjhkQGhYaVmQvmnsCouqO+ixV42mJ 3nogsmPe5093TNF1vF7yfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqA+7I t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1cwKoVKuZEIMvJ0vFhLA BcNrCb2B+QSyLCU5nthBgq/DVrZAVqIv7JeDlYhiXf6UkqoJkw9Tpl+CVYpAZByHt1ceg72w yPWJ4Y641mX4sYa7lwC/wGRtbyAmvRQQjUOGbXOlj/ErobUki94qIfzY9Fk91CQqZ4uqcaid DEShdVpGQyc0XhBYmH24BK6AnERCG4US72ws9T6pBlsvmkLYCbehGrWRQriY+tsv8fCsrUV7 K6P49XGebqKS/rFZxS1wPzVpFOIT0VUdETuNw8R1WSy/i7YrHCp6jearLeNbDtGTErVif2BW YCRiH6IIFa4kWiShbD8WzssrPWCznCFL5LYdvnFrIoufkw36V3w3gooEX84N2XIjtftaFzdF diIdrc49GGmVU= X-IronPort-AV: E=Sophos;i="5.96,203,1665460800"; d="scan'208";a="84824054" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CwIMMPexHxXhVm+wkIKUJhx/f3kCnABi87kQOa3byXLHse1l6BHrHJuPWKNrmtFH+u7JgEaW+x21Z1lzupQpl4kqHYjHmQ29R7paN39XLnPD8aBfOQPZzj5fcoAneYIMpdU+otB8/iy7AnkxBWwmhK16H5pAyOa09KudSDZ1byVAYiibY4V2XXjeNL5uo2unMdW5QRI+XH+e9r9q2rSV+aCNKLXvorZWWPKZkSyAJ4HJeKZjROW5rBigSIENz1m3BzVnR9P75V6MLqPQNQCyRQ0iCJAzOn0OQENB5gPRgXUGRfc5rk5W3yUQIWgCVzJyjxleg3skrcVaSzTd7OHYNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MXW05O58NixGhXdhHN3mZrIM0EL887lxF/qHl1K1M4k=; b=irmwicbAe5m67efdnDDm+Nva6xQV2o4taSQFrLGAaZnZcznUcGlONxj9xeec05vZggVS6eYlH/TJa38M7kY+qfa30oKWvQK4wnBVjmSfDkvctshFjHz7CmkwTJdLEguDGzSo36BycY7vTzUhBT+MtrrwMEfWeXphmPKccAjx8ym67G7gfLJByWsOn1+56UDJ289Etx7I14UDsBRFjKmxkzkAHaHFo5yI0LR4EKC3WcKQ35S9U1jaE6/hqO7a+gdyFJS5DmmMr8f+35F1WuQ2/WPDEGDzf8ghsJ4wsnOL4aBP4xfVITwpp9Sk5ioBAT0PjP3WyWu2IBo1Ba461LXGiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MXW05O58NixGhXdhHN3mZrIM0EL887lxF/qHl1K1M4k=; b=u/9lKRVsJ73jE7hbUYXNXnitldAKBu77oxyiDXZzUfzDR8azm6Is+kLa2dUsqJk7YnOI5Hey5MlZVRy/4+/wEA+5mxUU+faasqeFMLvXsKQvxH/BxtjnBbE3x63nJ+QP1Wq+ggaUBHFCRVzHn3CLD2aa4qLdDk2LppeQTnBaocs= From: Andrew Cooper To: Roger Pau Monne , Jan Beulich CC: "xen-devel@lists.xenproject.org" , Wei Liu Subject: Re: [PATCH] x86/APIC: make a few interrupt handler functions static Thread-Topic: [PATCH] x86/APIC: make a few interrupt handler functions static Thread-Index: AQHZBAFkcdSZ5ocJ5UOIQIf8MA/Xq65WEOmAgAAEcgA= Date: Tue, 29 Nov 2022 16:21:50 +0000 Message-ID: References: <54ee1bd7-9b6a-efc7-8bad-50aa7d6d955b@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MW4PR03MB6473:EE_ x-ms-office365-filtering-correlation-id: 68fb6492-7d87-4634-1992-08dad225d215 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: p91ZmfsxWSqHltPWeqrg+JgsPMEyKF0Nt3hX4inAexwUISfKCRhv5uDT7xjiOrQT4LHVbTTNRpHfZB5V5GIRQm60/XRoj98hAE0SDxSlCPbQTWjhH4MlkpwVXw0qmL6O7Hv8stKmbWkQynow7qK7pk+NttFToUAj4+fHAN+cTUfTnlq59UKkOf0vUoeV0e+JjsdPiZRIol+j4ogn+kOrilZcK6Gcob8EQSXzMSM9kkar6dWchtxAvPGyVFaQZc6d0batd8KzCiWLt/afO078OV02UkHsk/pJDMf8Ozji4JETQsyGqtLaEbgpHXupZ9NlZrEh003CHyuMpg8AEYTaQ1NQFsKReMH5SgzfwDX0sIdixv4AtkAXL/tOkBeG/3Ap29bmSxwdvErVuS7oq9QnUXdlG6y+wXed9aRSogcCrb+iY1WK7aV1LpbDTGlmI0OBoKxDihVceIh+fgbVsK2H9xkGoFQFbxtETcVMetWa1BEqB3DjATBcW/kM1PyRWeV9drvG67OwDXNGqtN8tvbG7bJzW96JY9rdPaWnQRDJq1KTteG4/nT5k9K8ycZIa8R7rNXsXHGRmixo57UuWwkpf68f4lKqeBWuJezbLkbSX1SItsQ5qXOfnlNXY+JdmTCMevgVjRInJ2jfM2EnhVZPnTSqmRgFQio441yoq2po0VAilvWes775b27lPn/PEIW4oRbuxO1HhG3MzHTUS5QSZHbtVqtvWRdLeMCjvdYXoS5hZaNeC6qrCA+TkK1NVsyXSMhVjpyd9aNOlh5z1mI4ug== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(396003)(366004)(39860400002)(451199015)(82960400001)(31686004)(36756003)(110136005)(2906002)(38100700002)(8936002)(122000001)(38070700005)(86362001)(31696002)(6486002)(8676002)(76116006)(6512007)(64756008)(66556008)(4326008)(91956017)(71200400001)(186003)(316002)(66946007)(54906003)(478600001)(66446008)(41300700001)(5660300002)(66476007)(2616005)(26005)(53546011)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WnJDWWNhaUw0V2ZNd1M4V3NwT3JmNmxBMWd4U1JFbWtSUldTOXRXUEp5UDVw?= =?utf-8?B?b3RJbFZGWk4zSW9uL0I4QitiY1p2SFY2ek5rSWdCeFlNUE0xbzRBQ2RRdDZ2?= =?utf-8?B?dEoxMFNRZzg2ZEtkVTNDdXBDaVVmWXNPUlpHMHJ0WGdMWEhVckRIT0JoSUdE?= =?utf-8?B?N0pYNEw0Z0UrSERGRjN3VHNleDR3akR3OXJ2QUx5WXJHVDJSRlgyeEVVNEs2?= =?utf-8?B?b000VC9rRVNmUXdtQ2VMTnI1am05TS9SWXhMN2E0V1NwR3hublZsNFBkWE9m?= =?utf-8?B?YS9GeWF5QWRWTzJjQXRzVUt1OStBVnRuajJrSlIyUHdUTUNsdlF4K1k4K2FY?= =?utf-8?B?cHVqUUErenAxblhBWituZ2taZ3NEemZvajAyRGpYalpmL25rc2VHVEdUN1B6?= =?utf-8?B?MUNld2xoWVlIY3daV0l2ejdNRW5jN1B5UFg0aWpSZGtqUHZiM0hsMDFLUjgw?= =?utf-8?B?LzJuc1pvaGRQcW04eGttbkNZT0hLRlEwa1Y2WGZYQXNTbDFEM0FVc1YzMlRO?= =?utf-8?B?ZDFlNGVzS2J4bDQ2dkhMcHFqMHJUT0VLamhtTVVXU3pEWENFdXhOSkczMlAz?= =?utf-8?B?TkIvNFhLZTFxdHRnSzR3UlVUaW9zTEx0OWl2bDd5UVc4bU5FMlZxUlRrL29n?= =?utf-8?B?Z3lObXU1YjgxUjBkSkcwNmI3aWpUbi9xVjlOQnV0dVdOZWxRalBBUVBOakpx?= =?utf-8?B?REI3Q2paSWs4SzdBU3l6WTVqZTVEdTlNQmJidmZlc3gwUExRT2czL3dPWStt?= =?utf-8?B?RHpONzk1a2FZVVlNOUlNN25ZaGlVR1UvbktONTJ6STVUOGV4eXJIU1dWOGI0?= =?utf-8?B?eVl6WktSNmZEMzdlK1pMZUlUekduaXpMc2tHR2FkcUM5NDkyRjFXNVBsNk5k?= =?utf-8?B?eHF0K05sZzQ2L1pGeDdPeXF1WG9TakR6RVQ2VlBtdlZnekszYmFxT0c4SXRl?= =?utf-8?B?MFBPZ3R2c2hUNFpMSFFYU01ZWWFTVnhpY1crRzREUUZIN1BFQ3daWEMwZWs0?= =?utf-8?B?SEJXaFJ4enFVbTM4aWtUam5jYWUxSzY5YjhqdmdiSnRZMDZncTc4YWVBU2Qv?= =?utf-8?B?VTFvVUxEanc3Q0RHV00rbitNd25IN0tZMXBWYm1IQnNUSHV3cWh3WGNnV2Vz?= =?utf-8?B?RENXSEJlN1BKZE94a0NSbGRDM0o4K2J2VEMxOUpEU2VJS2RVNEV6ZUpJalNI?= =?utf-8?B?K2dSZTMxaDZvdEIyTk5nVnV0cjUvaWV6VnU5RDA3UlJxT09IR1ZzcnRrbjZ5?= =?utf-8?B?blNkeFRkbkZmVk45Z21VUGNRK1ltcjNGcVFsUCtaOCs4Z1ViMEdaak9DR1JQ?= =?utf-8?B?dkFqMk9SUm9IbmYyUmd0RGw3SXZLeUFBRnE0VVhscjBFUDdiVXFQMjRXQkRu?= =?utf-8?B?SkNMdWRlUjNJeDZKMVhjcEN5aGF5TFc0ZUtRTkEvcmtERytaVFBpbUpzNDEv?= =?utf-8?B?N1k0WXFxbDBDTW9jT1d0dTI0aUNkSVhXN28xdUtrL2M2cGRaemk2aEJ3ODVK?= =?utf-8?B?dFFZTVVoV2ZlempJN2VpeW5FN3pRMzI4U3dmYUs5R29qNzRDSVRhdHZBV3hO?= =?utf-8?B?UzdzenpGQjRRaDBxU0hOYisrKzBicFovMnE2bldsZ0VhOGw1MUI3NmVINE9K?= =?utf-8?B?ejlyRmF0RU9iaEVyb3A3ZVQvc05FUU5jZ2c2VW1FMjBmY1lvNHVOY1B6K3RV?= =?utf-8?B?a0YvNnRJTFNtV0l1azN5cmRPc1RlNGZwdjdxeHk1STQ0TC9uMG51dUN6dDFv?= =?utf-8?B?VTlRZWRnSVMrNWlxRGpaZ2ZMRzF3Z2s2QkRKQW5HNlFNZC9wRTE5cnExMmRT?= =?utf-8?B?cEw2ZWZwOVhmenJxb0k0L25Md2wvOTcxTXRRMklvRnE3TmxOTVVIVm8vUm1v?= =?utf-8?B?RXRzNzhOM2RFaWtFV3NtQ01tU2VCSjlGc3dTb005ZzN6V2hsWlc3Z2ZPdVU2?= =?utf-8?B?bTZDU1NYTERYVGduSXdQVUF1NGtRdCtyMmEvVmNJM0k3eFpwZkdYTE5JbS93?= =?utf-8?B?cFlZMVE2aUwzWVFOS1dkelRxc01uc000eVdiNlVJWU9sQjN3YTFFUTEyUmNQ?= =?utf-8?B?dThsTTFGTDVVL25JSzFDeTBOOUhXL0hVYkRub0tjZlZvVUlqSm1lMk42Vmdo?= =?utf-8?Q?qABBA3QrLArnrWjclAKLYrGHP?= Content-Type: text/plain; charset="utf-8" Content-ID: <9853507EC433F04BA2FC149951238052@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fi/2LeFcw4FuUwxh+JeA7I3lEx5unreuSlMGcilEkpijXaVMUCsB7ZlApzDaMBpP6aAvMWoRWQ9/Eh9me7qVbHtk9F8jK8nkldz2bA18Dx7KyBlQHpuQLGDEuH9DPrZq6e0osGlzognpISyBaif0POmM3/a6nDp8jEhvCkaNL93+x/N/FkYsYFyTT9+Frw4fdJl3RXYopPRFc9Eusbke8bDfFeIF9CcO8EKGb8gO55SZD7Bnbe3v6BprBHPSOMbZ0hSBkkFSq9f+SWQq/xIRQePh8ZCDLGgsbZrtn5u6vbRlAFQ2AouO1aGrh5oKQ12FidNf3aD1m12TWyMCB4/ue8dmp90ss9Tcajs8uYcxOIKlX9zS/fcW02Wr36YHvIS7pPReZW/E5ZtxQKg93NYVT5KiRZSQ0LGKAqtzGbRgdWZj66A4hEXBcxmzDHs83jINPGheiXPqDMaCz2KaiN6IZM33O/BzBBTRBHnks86lYwN8f7UhQZTJAZUejTAb2683dbJq9bIqjKWepQytjEYNIIAQfLcxRjs+BwD/6vDoPlYvGW6jj4r7oF7637Odyzll5e1TMp+NxyD4uZooqR7FxxiSrmmQH/YdPaieuVaBZYO4j55AO5ACjvWTka2Z08qs94F0VpIWpz6uP41D0G9magLjezaKn+z6w6txPRNfhNuqnr7ZSjUPs0k0RbAjxc5vunThuLQhUOQa6FhndAMEh2v+sYy6nzCP32ku0trBjqFpmDNrOCe6aOQ+CexN2aBmc5CFb4a+To31YJzRwI83KCe40ZFD+eqY62Fl8NOT7aHf6sA2eD16e806gN+mI7Jktwyzy22Y8EzlPIG9XBaq/Q== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68fb6492-7d87-4634-1992-08dad225d215 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 16:21:50.5942 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +vOU+OA6EZ0kWPNj2ReiPhsBY+MXAbFuliX1wg2vfdkPJ5DYROAx7sWYrRlh8y+vW8VrBqbAmMySP6V0aPH+8pvzsj/lsSZzyDZyOtyB50A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6473 T24gMjkvMTEvMjAyMiAxNjowNSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gT24gVHVlLCBO b3YgMjksIDIwMjIgYXQgMDM6NDY6MzBQTSArMDEwMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiBG b3VyIG9mIHRoZW0gYXJlIHVzZWQgaW4gYXBpYy5jIG9ubHkgYW5kIGhlbmNlIGJldHRlciB3b3Vs ZG4ndCBiZQ0KPj4gZXhwb3NlZCB0byBvdGhlciBDVXMuIFRvIGF2b2lkIHRoZSBuZWVkIGZvciBm b3J3YXJkIGRlY2xhcmF0aW9ucywgbW92ZQ0KPj4gYXBpY19pbnRyX2luaXQoKSBwYXN0IHRoZSBm b3VyIGhhbmRsZXJzLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj aEBzdXNlLmNvbT4NCj4gQWNrZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRy aXguY29tPg0KPg0KPiBBIG5pdCBiZWxvdy4NCj4NCj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9hcGlj LmMNCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9hcGljLmMNCj4+IEBAIC0xMjcsMjEgKzEyNyw2IEBA IHZvaWQgYWNrX2JhZF9pcnEodW5zaWduZWQgaW50IGlycSkNCj4+ICAgICAgICAgIGFja19BUElD X2lycSgpOw0KPj4gIH0NCj4+ICANCj4+IC12b2lkIF9faW5pdCBhcGljX2ludHJfaW5pdCh2b2lk KQ0KPj4gLXsNCj4+IC0gICAgc21wX2ludHJfaW5pdCgpOw0KPj4gLQ0KPj4gLSAgICAvKiBzZWxm IGdlbmVyYXRlZCBJUEkgZm9yIGxvY2FsIEFQSUMgdGltZXIgKi8NCj4+IC0gICAgc2V0X2RpcmVj dF9hcGljX3ZlY3RvcihMT0NBTF9USU1FUl9WRUNUT1IsIGFwaWNfdGltZXJfaW50ZXJydXB0KTsN Cj4+IC0NCj4+IC0gICAgLyogSVBJIHZlY3RvcnMgZm9yIEFQSUMgc3B1cmlvdXMgYW5kIGVycm9y IGludGVycnVwdHMgKi8NCj4+IC0gICAgc2V0X2RpcmVjdF9hcGljX3ZlY3RvcihTUFVSSU9VU19B UElDX1ZFQ1RPUiwgc3B1cmlvdXNfaW50ZXJydXB0KTsNCj4+IC0gICAgc2V0X2RpcmVjdF9hcGlj X3ZlY3RvcihFUlJPUl9BUElDX1ZFQ1RPUiwgZXJyb3JfaW50ZXJydXB0KTsNCj4+IC0NCj4+IC0g ICAgLyogUGVyZm9ybWFuY2UgQ291bnRlcnMgSW50ZXJydXB0ICovDQo+PiAtICAgIHNldF9kaXJl Y3RfYXBpY192ZWN0b3IoUE1VX0FQSUNfVkVDVE9SLCBwbXVfYXBpY19pbnRlcnJ1cHQpOw0KPj4g LX0NCj4+IC0NCj4+ICAvKiBVc2luZyBBUElDIHRvIGdlbmVyYXRlIHNtcF9sb2NhbF90aW1lcl9p bnRlcnJ1cHQ/ICovDQo+PiAgc3RhdGljIGJvb2wgX19yZWFkX21vc3RseSB1c2luZ19hcGljX3Rp bWVyOw0KPj4gIA0KPj4gQEAgLTEzNjMsNyArMTM0OCw3IEBAIGludCByZXByb2dyYW1fdGltZXIo c190aW1lX3QgdGltZW91dCkNCj4+ICAgICAgcmV0dXJuIGFwaWNfdG1pY3QgfHwgIXRpbWVvdXQ7 DQo+PiAgfQ0KPj4gIA0KPj4gLXZvaWQgY2ZfY2hlY2sgYXBpY190aW1lcl9pbnRlcnJ1cHQoc3Ry dWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MpDQo+PiArc3RhdGljIHZvaWQgY2ZfY2hlY2sgYXBpY190 aW1lcl9pbnRlcnJ1cHQoc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MpDQo+IEdpdmVuIHRoYXQg dGhlIGZ1bmN0aW9uIGlzIG5vdyBub3QgZXhwb3J0ZWQgb3V0IG9mIGFwaWMuYywgd291bGRuJ3Qg aXQNCj4gYmUgYmV0dGVyIHRvIGRyb3AgdGhlIGFwaWNfIHByZWZpeD8NCg0KVGhpcyBpcyB0aGUg aGFuZGxlciBmb3IgdGhlIGFwaWMgdGltZXIsIGFzIG9wcG9zZWQgdG8gdGhlIHBsZXRob3JhIG9m DQpvdGhlciB0aW1lciBpbnRlcnJ1cHRzIHdlIGhhdmUgZWxzZXdoZXJlLg0KDQpTaW1wbHkgInRp bWVyIGludGVycnVwdCIgaXMgdG9vIGdlbmVyaWMgYSBuYW1lLg0KDQo+IFRoZSBzYW1lIHdvdWxk IGxpa2VseSBhcHBseSB0byBwbXVfYXBpY19pbnRlcnJ1cHQoKSB0aGVuLg0KDQpUaGlzIG9uZSBj b3VsZCBsb3NlIHRoZSBpbmZpeC7CoCBBbGwgUE1VIGludGVycnVwdHMgYXJlIGZyb20gYW4gTFZU DQp2ZWN0b3IuwqAgSXQgbWF5IGhhdmUgbWFkZSBhIGRpZmZlcmVudCBiYWNrIGluIHRoZSBkYXlz IG9mIG5vbi1pbnRlZ3JhdGVkDQpBUElDcywgYnV0IHRob3NlIGRheXMgYXJlIGxvbmcgZ29uZS4N Cg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Tue Nov 29 16:30:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 16:30:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449547.706367 (Exim 4.92) (envelope-from ) id 1p03Uz-00041m-CJ; Tue, 29 Nov 2022 16:30:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449547.706367; Tue, 29 Nov 2022 16:30:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p03Uz-00041f-9h; Tue, 29 Nov 2022 16:30:21 +0000 Received: by outflank-mailman (input) for mailman id 449547; Tue, 29 Nov 2022 16:30:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p03Ux-00041Z-Np for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 16:30:19 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1aed08db-7003-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 17:30:16 +0100 (CET) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ATGNt7Q022642; Tue, 29 Nov 2022 16:30:05 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3m397ffaj1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Nov 2022 16:30:04 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2ATFY3kx031443; Tue, 29 Nov 2022 16:30:01 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2109.outbound.protection.outlook.com [104.47.55.109]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3m39876545-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Nov 2022 16:30:01 +0000 Received: from CH0PR10MB5020.namprd10.prod.outlook.com (2603:10b6:610:c0::22) by SJ0PR10MB4622.namprd10.prod.outlook.com (2603:10b6:a03:2d6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 16:29:59 +0000 Received: from CH0PR10MB5020.namprd10.prod.outlook.com ([fe80::1458:2f4e:91aa:5bc7]) by CH0PR10MB5020.namprd10.prod.outlook.com ([fe80::1458:2f4e:91aa:5bc7%9]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 16:29:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1aed08db-7003-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=mq2EyLheTw9mVWD65B0+V3EYuiw20r72c130RGNlN2Q=; b=snaYeasH0ZElEtTsW0CZMzVtqjxhR+Wzda675tZFoDFE9e+b+Q7MnU0hXT7Kxqb4p3SV eDbKwJS3HBTQlT4ZAfGld0HrrQbNw/ALR03j/JS+MoAneIu3phVtbJUffW1wiwBVNWmF V0D63uxGq40BlMMtX5O/yeLiQkBatkXUoFWWzEKzAqVNLnJoAREV73yhUZQLvcXOphAr yqx7nuJU8KZl5HLcE16ZKUrHPwA7tWdiHVRQK2FdhBRXv4JFXptm094PwCBY4ShnYhk3 7BMjZAgEbvFfBz65ug2dIaWF2rpFuFizjVMkgxhnfCjh7lYsYC1BU7jMQ84TXRfawus0 cw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HARGsOKu8jZHnVsmGeA4zYrAP9KBnsvp3XWFUsnzJXacNaQSQJaYE5v9bsxLJoTeVvQnb8qgnWC7Otzcepu+Tj5Du3lTSEb8fZbeoRn+X/qzXcW/gSOVhhyTCbc0Vs+ZFuF57zNdz53Ak+1ug4Bm0ja2Bjw9F+wlPlcdGyoHvE7pkYAFl5BR6yHJKLJzT4i0RChI0zqBC5YEXyE0k+ku9yra8u3IdISbkvQ+RN10y7Y5u1KBVAUTH9yxjEjiDbWTXSF78fPgAFMnmfdx9WkCD92jWbhlHC/7zw1iBDJbXyhbrlrliLpXqRuAeYnY+sCAwR3sY90M2wXtS31DpBGTxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mq2EyLheTw9mVWD65B0+V3EYuiw20r72c130RGNlN2Q=; b=eqsnxOm0AcZzAXJPOmF6mJLpJOjlJrn8eleHm6kj7tPr1/EnK8BSgUOeXr+ls9Nzc7+6IWfYIErbic5rzlyjMKymSMFmR6Dc6e+0FXkSmAViZBvtAzUa/MvHklTIivoLI+lSo7j1BGsR0mhBTYU1gvp7hKEy9mU74ZxFIzYkviPljbA9r3Vku5Zby9ZoXUz+TNtLnBwF7JF450QHXn9AVQPhBd4InMrwANngE4ppFlZP7UTORj+Du273htT3CKiEVSNqeViydc9ehzoO4zMuUTMm26WeogKyFFnWw7xyYphrBmKy+DL/cfsNy7jbBUR1DLmWt3lnzkuPzofO4BZl+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mq2EyLheTw9mVWD65B0+V3EYuiw20r72c130RGNlN2Q=; b=ERLKSi/nyJi1wVOGrF3X+2SEk0NEIo0sweAosTWLeBxf8K7MrnU5yp65XBbbQU5F7Bunf0Yl9jpziagwHdpzuefDp6CMEN0BU0RQZpb5U4UnF8qP0iP0MvdwBdD5LxdOjdktXccDWFyu6S1mWoNjybVGrAYJtKAbZ7A5npVdqXU= Message-ID: Date: Tue, 29 Nov 2022 11:29:56 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] drivers/xen/hypervisor: Expose VM SIF flags to userspace To: Per Bilse , linux-kernel@vger.kernel.org Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" References: <20221129150058.266943-1-per.bilse@citrix.com> Content-Language: en-US From: Boris Ostrovsky In-Reply-To: <20221129150058.266943-1-per.bilse@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DS7PR03CA0208.namprd03.prod.outlook.com (2603:10b6:5:3b6::33) To CH0PR10MB5020.namprd10.prod.outlook.com (2603:10b6:610:c0::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH0PR10MB5020:EE_|SJ0PR10MB4622:EE_ X-MS-Office365-Filtering-Correlation-Id: a7df1633-7b4d-4f76-9621-08dad226f563 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BPDE/o8HxuqqTh2rgqyjnZikHH9zNjVj2FDT/XIvs7eoxL2T0Q4w64DRsHwinfinQUyNOCpHAIipLqispkxsLYBZRbnXOn+ZZQzUW3K5Y7y+WLpaGKSMTNFRuUgzzwd69SnQ3Y1xno2kGHCLZAFu4lPZkuo4Xib84lGpPo2xySBXm6yULBsdwGAzV23eCpQJR+Z5T3KfUFQvc5Czdj4kk4cGK2tvGQ0nETqB7VVAR696afp7R1oFfpi1x/fj0o6C9b6M8ZyGHn8k1IqjMrdovohFDzgUikQHs+7cCuQZmtnSMXTB7aLTmGSfoagkrnzS5yoSOmEqiFQD0UynhNP8CdsTBZWoyKa0k8eKQjOSzAG8JYiP21umfsQeG5Ym9bMtV9Zmd9p3jf7r33zOpjwv1xSt5BmPmQA25wQuRHdjqV5xEM2qrvhtwv9tZs4CWf5AW8LeqD3Ud1r/ZDIPixjFibrncyYIe9Dgqfclw/swfYoHD9sIasSa9joG9BnIFoRh5I4c6iF8u46+A56pvemwiAcCd62Nohvua4kC+ebG9TfK1bT6GQMwY5Tmaf8eYL8JpNaKLbUibUvdhHCL8oc8qQJ7/6lFqBO3TimiAlaVIroNuikwOPgVxOO5rMIxnNpHvQ84CrOdiU6RG+tPuRE8eJj3ehCof0hd7UqfMyDxRoEFkfSLTCtuYrn8KZsyvG/XgqBvkSC5Dwllhrobywmrlg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH0PR10MB5020.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(39860400002)(366004)(346002)(136003)(451199015)(5660300002)(41300700001)(8936002)(44832011)(4326008)(66476007)(8676002)(66556008)(4744005)(31686004)(6486002)(54906003)(478600001)(316002)(66946007)(2906002)(36756003)(86362001)(53546011)(31696002)(6512007)(6506007)(26005)(2616005)(186003)(38100700002)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEJDUUIwbm5CZHdhNXNkQVFlQnc2SnVYMm5QNjJ1R1RyWHVTUUdOWXRjdHBD?= =?utf-8?B?aVFhTlpncVkxaHY3VGxHWDZwVTlaTXBncjlFQit3eHZDclQ4VlRaUHJpbUQ5?= =?utf-8?B?SktkcUxKUHFCa1NBRXpEYm5LaklKM0ZFaFNqYVllbkdhMmRDOE9VbG4veXhm?= =?utf-8?B?dEJ3ZDh3SnB2Njl4Sk5SSWN0U01lb2dBc3FlTkRiTTNXazlKb2l6ODVzZkxP?= =?utf-8?B?WGJXSzdkeWFsMnlYb3NFMjk2cmpIQkNKUTJSRWFTTVBvS1hIRjhBOXpEUGtK?= =?utf-8?B?Q2FUeXBMY1hBcnhrMHR4UHhXTitFVEdQR2FRUUd1c0Zaak0vdG43aU9Benpm?= =?utf-8?B?ZTkrTnlacDFxdVBPdGo3NWs5UkFhQzE2aGtrV0tXbUF4YUZXd011K3Vqc0VY?= =?utf-8?B?THpBbGlpM01mMHVnNHRFYy9zWThmT2hPa0ZvVjNqWFhLeitOYnhkSVZVWHhv?= =?utf-8?B?K2lYQzdSUGdQTDYrS1NOYjgzSnZkV2RuR01EM3lRT2RwaTE0TWlpTm85MVk2?= =?utf-8?B?MnhXQTVVN0VwZmxzMHR5K3RObncyS3Fsc3R6Y2lCWFZveDFqS3RjSS9IM08z?= =?utf-8?B?a2dJa2g0Sk5rT04wcFltSFFxdFJGaHBXU2YxOFM2R3djdFBETy9HK1lSeGtk?= =?utf-8?B?dHlpTlpkdE5iSUc2NzFVOVkxazY0VDlCMVg5cUZ2RUNzTmlKd3NLL0o3TE1T?= =?utf-8?B?RHFjOWZFTDI3VDBSVlFMMXBKa3VxWG5hODYybU12SjgvNkVrV1k4NWxsdWxW?= =?utf-8?B?c1NXL3ZiRzM3bDdKN1hnRkVjV3J0blhoa1FuZ2pMRDF6NWN0bUl4YWx4Umdi?= =?utf-8?B?eDlWdWVVbTkyenllRFBIVld3aWZLdTRjU2l6QWtZaFBrOXo0ZnMwdzl3alRC?= =?utf-8?B?QWM0YUZTblhaYUtKWkZpRExXNHQ2ZWtIdEltTzI4RXlKNmVNNGhmV2ZGb3ZU?= =?utf-8?B?NHlOSVhueU1NS2hlQ1pjUG5jdXg1T1pQcGF2OVFlS2tYN0cxbGRyWVcrTTRJ?= =?utf-8?B?YWhHNk1na1o0ckR2UkVSRUVFcGdDVUdTTi9BVU1RL3lrWUdEK2dMUnNFY2R0?= =?utf-8?B?SFBacXg4RVlLY3JhQ0tyS1gxVUxNWVFLako0ZHFMdi9kSlA0TXZUQS9PUjV5?= =?utf-8?B?STRzTFlTN1VBVUptT3czS252MDJnMStsYmtneGJ0OXdKdVNNTkF2VmR5azVz?= =?utf-8?B?aUt5NmdYa3Ewby95UFhqcTF3Q0E0UkVsYnBVdW1sdW1ta0p4dFdJc1ByWHRw?= =?utf-8?B?cUIwRkFiMWxHYmpaVmpxNW9PSUU0WEJMMnJGKzNmaU1PNjBRVk9QMk9xWld5?= =?utf-8?B?WkFWbVJybmMvSmtGeUFrZzVqSlRUMnhZTzByV2ZjL0NPWW8wVm5LdGxqcm9v?= =?utf-8?B?cUhBR1A1ZnhIa2hwOFBFaHNTSXk2ZzdUOTFORitvK3AxSmF5dERTcEJnSVVR?= =?utf-8?B?dFhjamY0VnhTcTYweXJYdWx3NGNUbGxvd2VkOUpWZ3k4T3dIMXM4SzJnOEFO?= =?utf-8?B?MThNUGYvSXQ5Y1BCWkdTVUFMaWk0RlVMM25qTXBCT2xtT1A0YStPb3pPWVdB?= =?utf-8?B?ZVlmRVVuVGplalltcU9SNWppV0tGZzg2ejRXV21jMThxLzcyMU5ZTk84M1hF?= =?utf-8?B?MmZuYlUyS1phM3lKMFFjb2ZwQk5wci9CU1YweG1HNldycEQrbkpLcHAzZ1Zo?= =?utf-8?B?LzVhS3FvdjMrc0psenB6ZHFtYXg3MWlJWGNwNzR1UEIzMC9YOWhyRXluRFNB?= =?utf-8?B?SG85SUNuRS8zaTNsTFROQ3FWQkZ2K2RVbzdZOGw5bWVVWHlqSHZnVWtiZDF5?= =?utf-8?B?NnhqNEhrdk1LRW1wUi9LNzU4dlJXdVhrRSs2VWxMSkhFZG1zQXZVOWwvdUN2?= =?utf-8?B?ZTJLMlF4QUc0MVBlaDF4cGhBaDQ1TUM1a1pJYzFyZC95bW1mU3RhUUpCY1kr?= =?utf-8?B?NHkvWUNHUDVmeFNQcVpXQ3k4dWd0L2NPQ25Ea3pLT29QdWlJdVFHSmZIbFdV?= =?utf-8?B?MTZsb2NJbGFKVjdOZTUyNW52ZWxxQWgySDloYzNEdmt0N3djT0RiMFpaSTFN?= =?utf-8?B?MDZBM1YzSDBJL1hoYnRkV2c4ajJsV05FR2tZd3ZDTzZzMDBhUVF5dng3WkJq?= =?utf-8?B?VzJsVHhISzZSUi9CVklHU1hLL3g4NDJCMGl6aE12Z1FRUmJrNHhxaHBkTUNy?= =?utf-8?B?aGc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?YmR1M2IyZXMrd2d4c3BjRWkrNEIwMmQ4QUd0RlNYMFRkOTQ2UWxxWW5qWEg0?= =?utf-8?B?OEpYdmd0WEFJUmFKczBZRVZBMGtNMXQ5dEVXVlpjcWVFMGdrcW5GQlcxaTVH?= =?utf-8?B?bVVrMG9ZYkN3cTFXV0hvQ1R2L1lrRVlVWXBkYVpsNHNFUlhxYlczRnNnM1R5?= =?utf-8?B?bkI3L2xDdWpLdEd5aGdMWXBvUGtIQTR0REhTeDluOTBZQmM0V2IvRWZFMHo1?= =?utf-8?B?cG1CVk5wSkZvOE9EM0Q3WHlpbWg0S1pNRmhtTkQ2TE9yMklRVWZOK1AwekhC?= =?utf-8?B?VHRveDVSbmVmQjNGRDhEaGZwSkZBZ3pvZVdQeC9oMndnaDVRK2RXcFd6TmJk?= =?utf-8?B?a0Z5emZHT05YVUhJUWN6Y1BlSGdzQkxLNFhvaWJyQUIrb29PVnkvRmZwSG5w?= =?utf-8?B?THlWTERPTmpqUFRGSUpxUE5vY2F6MFh6dDFEWXc1ZnNOc1BxUllYdDhIcFpv?= =?utf-8?B?L3laZXhMZE1lUEN6UjRiQVZJMFNPZlYwVWNhRHprdW5xbC9TR1RvNmc2NTVt?= =?utf-8?B?NmVsVUJJWU5SVzdHMkdlVERyTXVoV2RxREJGMmkwQmpEVnNNMTYxS09GdGRY?= =?utf-8?B?TWwrblUxZ2lxUkYxK0dJMDAxUWtRTWZELzBsa1dYNzllTXFhZnM3YUc4VThZ?= =?utf-8?B?L3NwZmt2MjN5ZzRxVkROOWdoNGVKdjdMcS9oL3owVTNkaGFPMEg4VkliQXN4?= =?utf-8?B?RWVsWUhKcnY3WkU1cVFabTlDb1pheFFmZFlNUzlCdTRpK1dSa0ZkMDZIWmhy?= =?utf-8?B?cktMdFpPUkpTV2Zxcm1CUllubWg5UUZxcDV3b1B4R3g3dzZtTm1Ud0ZQY1U3?= =?utf-8?B?L0REK1BEclluNnIvVXp3Y1U0S1lFT0hsWkgzMkN0YzVLN1RWYS9xajNhblFr?= =?utf-8?B?SkdudlhtdXBBSGczNTNIeDZpU3BYbmMrMkZJSE54OVFtZGs0Q2syUFVSd3U5?= =?utf-8?B?UUJqVDhWNE0vcEkvUnBKQlVzT2c0V3hlenNJNUhiL3RjR1dEYzNCZ1ZpZkMx?= =?utf-8?B?NGg4SDlseWhpTEx4YmNDTmpKVitDN01rK3RhRDJaam9BWmw1UkduM05NbVpV?= =?utf-8?B?djl5SmFicHFWR01oWXVxUHh0emRJWEFRZ2YxM001Q0NQcVVpMCt2YmpoYzhr?= =?utf-8?B?MjRDbjYvSThkOWxxOW11enhGSW0xa1VxOFQ1ZUIxTXcxajVLZTdHdDZsOWlj?= =?utf-8?B?OWZhL2lJYmFZekU0QWFMc1N6b2sySFZHYjhxam5RRjI0Z2FZRDg4aDdPd3Bk?= =?utf-8?Q?BJYxviPc8bgaN6B?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7df1633-7b4d-4f76-9621-08dad226f563 X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5020.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 16:29:59.5287 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3AYwm0SVCi5huqyD0tJcso79nlbmdGLHTzWV01XlPrRXR1bRfqaXRx07kPwhRyyd4IsK2Q7heI8v9ESXSAKvSzqnu2XnQFkgP82CQyzmcGg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4622 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-29_10,2022-11-29_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 phishscore=0 mlxscore=0 bulkscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211290091 X-Proofpoint-ORIG-GUID: Xiq5bDBWYPVZSA_n-EtBEML4M8ryGzXJ X-Proofpoint-GUID: Xiq5bDBWYPVZSA_n-EtBEML4M8ryGzXJ On 11/29/22 10:00 AM, Per Bilse wrote: > > +static ssize_t flags_show(struct hyp_sysfs_attr *attr, char *buffer) > +{ > + static char const *const sifstr[SIFN_NUM_SIFN] = { > + [SIFN_PRIV] = "privileged", > + [SIFN_INIT] = "initdomain", > + [SIFN_MULTI] = "multiboot", > + [SIFN_PFN] = "mod_start_pfn", > + [SIFN_VIRT] = "virtmap" > + }; > + unsigned sifnum, sifmask; > + ssize_t ret = 0; > + > + sifmask = ~(~0U << SIFN_NUM_SIFN); // ...0000111... > + if (xen_domain() && (xen_start_flags & sifmask) != 0) { > + for (sifnum = 0; sifnum != SIFN_NUM_SIFN; sifnum++) { > + if ((xen_start_flags & (1< + ret += sprintf(buffer+ret, "%s ", sifstr[sifnum]); > + } > + buffer[ret-1] = '\n'; > + } > + return ret; > +} Why not simply show unprocessed xen_start_flags as a hex value? -boris From xen-devel-bounces@lists.xenproject.org Tue Nov 29 16:42:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 16:42:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449555.706379 (Exim 4.92) (envelope-from ) id 1p03gM-0005vC-IZ; Tue, 29 Nov 2022 16:42:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449555.706379; Tue, 29 Nov 2022 16:42:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p03gM-0005v5-Er; Tue, 29 Nov 2022 16:42:06 +0000 Received: by outflank-mailman (input) for mailman id 449555; Tue, 29 Nov 2022 16:42:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p03gL-0005uz-Jx for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 16:42:05 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bf81eba1-7004-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 17:42:03 +0100 (CET) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2022 11:41:59 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6802.namprd03.prod.outlook.com (2603:10b6:510:119::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 16:41:56 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 16:41:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf81eba1-7004-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669740123; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Cz7h3YCNxkChMOYTsxVSzgklzua5NsObeP1HZOBZzQQ=; b=ByhrrrpYltOGGPKYW3tb4kWFwPF6Fi5hCmOe9dQsupqYTcrfmOPPii7B 7j/tSXZjExh8BwC5Ivh3XgREy5FCZddgXU18UZNtNwzeO1ZW/Wummg3ve h00qiVaPHeBtnuFX00qMCpekpJ+1Y9ClZ9mIJKZg6FFi6nYHe/YQYa39B o=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 86205258 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:nGwdZ6jjXfoY2ZGgrqvdrN1VX161+BEKZh0ujC45NGQN5FlHY01je htvXD/SbvyCazGnf9ElPdu2oENTvpLUzdZgGVQ+rH0xFigb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QWPzyJ94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQYDmggazKN1tuJ+6KVF9RK3Z8PCdDCadZ3VnFIlVk1DN4AaLWaGeDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEgluGyb7I5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6ROPirqMw3Q37Kmo7GkUOCmTh++CCkRSVWNNEB 3Q6/nMAlP1nnKCsZpynN/Gim1aGsQQbQMF4CPAh5UeGza+8ywKYAHUUCz1MctorsOcoSjEwk FyEhdXkAXpoqrL9YWmG6r6eoDe2OC4UBWwPfykJSU0C+daLiIY3gxHUR9BvCpmpn8b1EjH9x TONhCUmjrBVhskOv42x+krGmHSrvYTTSRAu5RT/WXis5Qd0IoWiYuSA61LW8PJBJ4axVUSas T4PnM32xPADC9SBmTKARM0JHaq1/LCVPTvEm1ltEpI9sTO39BaekZt45Th/IAJlN5gCcDqwO kvL41oOu9lUIWegarJxb8SpEcM2wKP8FNPjEPfJct5JZZs3fwiClM1zWXOtM6nWuBBEuckC1 V2zK65A0V5y5Xxb8QeL IronPort-HdrOrdr: A9a23:kCsogqyDf6H3RFjKfegQKrPxv+skLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBZpTnyAtj6fZq8z+893WB1B9uftWbdyQ+Vxe1ZjLcKhgeQYhEWldQtnZ uIEZIOb+EYZGIS5amV3OD7KadH/DDtytHKuQ6q9QYJcegcUdAD0+4WMGamO3wzYDMDKYsyFZ Ka6MYCjSGnY24rYsOyAWRAd/TfpvXQ/aiWKyIuNloC0k2jnDmo4Ln1H1yzxREFSQ5Cxr8k7C zsjxH53KO+qPu2oyWsmlM7rq4m1OcJ+OEzSvBkufJlawkETTzYJLiJbofy8wzdZtvfq2rC3u O84SvIdP4DkU85NlvF3CcFnTOQmwrGokWStWOwkD/tp9f0Syk9DNcEjYVFcgHB405lp91k1r lXtljpw6a/ICmw7hgV3eK4Ii1Chw6xuz4vgOQTh3tQXc8Xb6JQt5UW+AdQHI0bFCz35Yg7GK 02Zfusksp+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIgUn2sG9pg6V55Yjt 60RZhAhfVLVIsbfKh9DOAOTY++DXHMWwvFNCaILVHuBMg8SgHwQl7MkcUIDc2RCe01JcEJ6e v8uXtjxBAPR34= X-IronPort-AV: E=Sophos;i="5.96,203,1665460800"; d="scan'208";a="86205258" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j9S37xHtMm9JjfHWQRpn3RjWJC4nv5azbGvFEdJaGVW5dXa6bRBIU0AqsUWC+vRICFwDGvF8npQfFvieHd940Vs4wZYp3MSTRY8V+9DufQQ/Jl9VrwVgAPFu8irYEJ+mGHGqYguLuSLTSr97l5mj/MDoanTUdLhiU2Nk49ysIPLQuR5B7bsaQdmkCN5RwsJE2ryi+9QyEuWFhRshNsovfjcUBi2yOUMZL/KPtSVA6GzUP5T5FAwVktSLDpUKPXLSFZcxPicfIwfICrHRNR9OJZg+kOI3osIuNjlAHeYvoSyW2s13FFDoR2dnNVu14SztX50wu3523Bb8CmSa78Pwow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cz7h3YCNxkChMOYTsxVSzgklzua5NsObeP1HZOBZzQQ=; b=L3t04PbIY0K2teTf13lUzspbzyfpqKgpYqMGgyK+fHPmLiYGyyuC0n+DVQEoVKRho5TGfvvz3/NCCxp6mvN3dovC4tpNnxvgnwNDvqz/JPWaA7BTF3/CkzP5ooZAyiTl5tAE1jsjkjkcDAD/fSgb/RU37I5J3uxogzocwR3LLA92X8ln5M/4lnTmmflIAGlxRK+4fJQaYb2Ju102dWpd2v+4nUFpgHwAZuYSBrthFJDwy0zwYK9LgjJ9XCmwiwiQb+uD6Qo5OHfbSvAI5k5QMQwR4KdCyUdCpje09rp9aRaY35VRDbFDkoO0LE4XBymqZwfEqAtkEytiR+EGWIOkbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cz7h3YCNxkChMOYTsxVSzgklzua5NsObeP1HZOBZzQQ=; b=qqEJjL02vEIN4tS8PELKk4v/T3YFkTBD//8ryneBg8WdIPwbaBjFq3f8e3v6otfevpG6b4CVHo8oJSpiaKIk2Ss1GrTlo7X+K3w5iFuvid13WXYdAa6coL0MNakMEhRlMjJncU5R7zOoUG9P91nBexsi7XpHAy5NgD6Qt4NdIpk= From: Andrew Cooper To: Juergen Gross , "Per Bilse (3P)" , "linux-kernel@vger.kernel.org" CC: Stefano Stabellini , Oleksandr Tyshchenko , Boris Ostrovsky , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Subject: Re: [PATCH] drivers/xen/hypervisor: Expose VM SIF flags to userspace Thread-Topic: [PATCH] drivers/xen/hypervisor: Expose VM SIF flags to userspace Thread-Index: AQHZBAVaARHwkOAmUU2q2Cs+/8XQvK5WBiMAgAAUzgA= Date: Tue, 29 Nov 2022 16:41:56 +0000 Message-ID: <92300a81-b97b-f5d6-e3e8-363d8a7d3742@citrix.com> References: <20221129150058.266943-1-per.bilse@citrix.com> <358e49fa-8ce7-67ce-8e0b-e523dee9ea19@suse.com> In-Reply-To: <358e49fa-8ce7-67ce-8e0b-e523dee9ea19@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB6802:EE_ x-ms-office365-filtering-correlation-id: a0dd2379-d9a8-488b-df98-08dad228a0ea x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 550GLMgem7tmBJJoS7PSwqg0P2UEzD1jq9rPcRTz3TpHabzB7LxoplfVkmdMoDxYcCYLjTPrN5N6bdW+yvlaq/d4GoarzVULgsP+CYtTebybp/Ts9IJ1whbSecDiKk/CI3jGlF/BiiZ2tLdb1d9xn9WoS+clTpBeY6Xvog3x10BAgQFOfU7a2KJsfD90xecJD2W6SG9YQ4fC4f/rctDVOjbKz1NPoFxnAyfXnowJpmkDEj8Hdc/4/SVyD1cINemAU6Ifyi5FcvWl27MaKSPKNKe/rr9PzxCLd6Yb+AImm8+9QHN6D3Mvyz3ZECTF8m1TpfQ4DsnUT/CELKLaP0Q2w4f7SoD0QCHJ1998eazm8TKaCct323FxJl83dKRm+5HiA2bfuTwgQG60ILKACSMnispH4ftbwwDIsgVH7pyMZXKM7fVkp5XsEzKYpAeq5h96dqcZ1TbQzntXzLAvYtv9EeIS+BXr+adQhpuyzQTLyKUlaxckSNU/nHzr08LDsS1LWo+lG+PM/PAKlJqHlLJqERmQ5iV13iuuzaKOnnfmvoyAQ4eUnTclyoOg/+MjY36/iyDvfWwvIFMyAS74Niuz8qVoM0ObKukSPQ7PdT37vEO9yLWeSkOe+BhZi6dHpQtcK1gBRjpw+dH6gNVPnrZEzKBJLOpmmphIlNvMz7W5Z988JQxQbNvJcatJW8aMZnObXiCV6UEyV//46YdzbFBS4QNR0bvSTPG/0Yo8oXUFtYmEUsTo/uLekX0QngD4K9nwSHUXyQSoTHsdT/9JtcDezw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(346002)(366004)(396003)(451199015)(5660300002)(38070700005)(110136005)(54906003)(8936002)(316002)(6512007)(41300700001)(2616005)(186003)(76116006)(66946007)(66556008)(4326008)(122000001)(64756008)(36756003)(8676002)(91956017)(66476007)(66446008)(38100700002)(2906002)(82960400001)(26005)(86362001)(83380400001)(6506007)(71200400001)(478600001)(31696002)(6486002)(53546011)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RERrL1BuS2R0YWpxNW8xR292c0VvUGtvVkdLMHc3dWJsREJWTXl2eDA1aUNL?= =?utf-8?B?b0FRWlJjRTQxZWpJRUNmU1laSzhxRjd0ajZvZldETWZHVFVia2ZrWUl1RmdV?= =?utf-8?B?N3l6cEYyampOQ3NIdjlOQTlGV0lCNE1nQk1YSldLV1BpWGhUbWswVVcvMngv?= =?utf-8?B?RG4vQlE0TGhyVkZKd1ZIQ2Y0SEtKNHlGL3R1aUZYWDUwTkRlQ2dxVGN0V0hh?= =?utf-8?B?S05qZWlsRTlWY0FYMkloYU9PNnoxRHh4OENhUFVzcStRTFZRNU5IWUNySERW?= =?utf-8?B?eCt5NFNWWTdlTHlJczRUSGZOYWNpZ3BqTENzOCtaOFNRRWJWTTRqamphZXBR?= =?utf-8?B?UlM0VmQreU85Rld6akdSNktrMG9hVEMzb2V0ZlBKNlBOa24zZzNsVEJNa0da?= =?utf-8?B?bTUrQUVDU3o4SHVKNE5nMnpZcUthZG1TTnpqZytxdjNzV0RXbVhvcnJaNVpW?= =?utf-8?B?SEJQOXdTWWw5cTVDeHJnODZlWlVCODVtTjZMQWRTZ3BzY0ZVM0tWeklCVitK?= =?utf-8?B?VmxiMEUwV1U5T2VzK3p3TUE4ZG5xL0NzSks5Y1p2SzAvNG9HSVpKQWJiTEdY?= =?utf-8?B?THAwdjNibjJNdXpCS1V0aUkyaEhRWGpsUDVxTWowdzgzZXdkN0xDTHNrb0FR?= =?utf-8?B?blFTTEFNSFlLSXhOM0FYTTZEc3kzSmplamNJMDU4a09uNE1oNWg5ZVd4QWl4?= =?utf-8?B?ODk2dFVPK2g0bExsQ2VPdW5vQ3pBOU9Qa2NWNzZiVXJBd3JLa0cvWDNKYkVv?= =?utf-8?B?Tm15bmlPNEZLWU5RKzlhWS8rb05XU3cxazA5cm5MWW9KRjUrbGIwWWZ3bWg5?= =?utf-8?B?UXVIMXVCU2hSVEN5ZkZqaE9FQk1hcExXYU9nMjdGWEtWWFVMa0dQWEF0dGhD?= =?utf-8?B?WE0wR2IxeEFpWHZBbmFmWE03bGhLSlBXZkFFNjVEeTk0bHFodHJBMElseGFh?= =?utf-8?B?TXJ1RE9YYUtqeXptTmg5T3k3eVFZeHNGejQrQ0lTa09PY3pZNEE4VWdsRS93?= =?utf-8?B?b1FVekdXOUJpdHgvNkw0OFlZNjdYTFpzZllZOEkzTWh0dURSdnZhdk1WYnQ4?= =?utf-8?B?NmZBQm1GeWlvOW9OeHg5bnhsM05zTWdXVGsrZ0ZqUm4zTVByNVg1eElhZmta?= =?utf-8?B?L1RYN2VqQXZSTGRVcktmUDJLNG5IdjdCRDdSSzRDWFA3eDRJQXVob0tYQnk3?= =?utf-8?B?TGRsSmdwdm1KRFIxb1NwWDJaT0JrbXBJakM0emc2R0FrcCtWUEt5SklwZnpn?= =?utf-8?B?RllvQWhSZ2pPSVo1aExETlVqeFVKSHBnRnFncWdZWi9va2M0cUJoNnFXMXpv?= =?utf-8?B?d3E2Z2FaMDRJMCs4NTlmS2gxekdnYWpRMlQ5OXZxYWdxZC9mNWpHdVJrT1Jj?= =?utf-8?B?SFBQRjhqckZ2bm1IbytWbE9GOERHaEtRMzRvTnFHVEROYTdWTGVjdVBSM0hV?= =?utf-8?B?Y285WG5Wc3ZUZm1NVjdvaURpZ1JFNGE5UWdDRFpZVmdoNGF4bmxYSVlnT0VB?= =?utf-8?B?Y1ZFMEFIbEEySEh3UDdJdW00R3FPa1htMFVFS3kydTRnaFpYcmVqeXV2MVkz?= =?utf-8?B?dG1jQnEwb0Q5OGxhTzZQUDlEdjhMRlJYVEgzVmJSMXZrVW5DUk5qVjk4dUFs?= =?utf-8?B?TGJiRDVBeFgrNnRlUy9mSXVPWERyL3JtMkQ2cU4wemZoL2NBSzhZR1FzY3dq?= =?utf-8?B?TXpFT3FJWWxZVG9oWnc0cm9zZkRQRmFNWFZHUzgvS2V1NEFHZjhvazBrZ0M3?= =?utf-8?B?a1dtZURlaWhWTHg3L3JTT1c4T2dVM1A2akx4T0V0QU8rUnFxR09rbk1sclpK?= =?utf-8?B?UDZoZTF1UjlkQ2JpVE5qOWU4ZW85di9DbEViMWZHbEtKNGFtTTBUTjNhWE1D?= =?utf-8?B?d3FQUGNrMHFNdGJjK1F5elRpNkdoR0xPQU5GY2hVNG84MDJCQWJhWWhHZmhq?= =?utf-8?B?ZkphWHp6R2p4RVpZOXBsRkdjUEk4ZkVuYkhnWXNiVFNmajJZVWJ4QXR6dGY3?= =?utf-8?B?WDcySGU4My9qSzNiS2NwekovTWpzK0hFK1NXU3poWEdnMXRJbmQxVUNLa1JJ?= =?utf-8?B?SlhIeUlvL3RwZTBiSG1WbXhhc2lRL0FqTVVlbHQ5ZXhLNnpRZGVjdDBMV0RH?= =?utf-8?Q?lWYXhIgi5HgYB/6h0QZlZUQe6?= Content-Type: text/plain; charset="utf-8" Content-ID: <99168C812DDDB5448540D3B382343237@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?VGUzNzhGMlZzUWRxcmM3elAvai9abVMxYkF3TGk2RFJRa1VCRzdNcXZOVVBX?= =?utf-8?B?YWs0L0dYS0VCc0lVNGtPYUxqTGZDN1BFTGVQb1RRR0xOMkJNa0lsTEpKdnFj?= =?utf-8?B?ZEtWdnZ2am9JaVhwT2xWNkRBeXV0RjlFWmhSVG8rcE9Ic05XZ2VoSkNXYU90?= =?utf-8?B?V2c4OWdEWkg3em9ZUDd6STJVVzFRYXkzNDlNQk5UTkpXdUxpMU5oWjlzYng2?= =?utf-8?B?UE8rY3ZpR2FUL2ZCMnAvcHFRRUtpVnhEN3grc3BZc1VMM1d5Uk16aW8rdUpr?= =?utf-8?B?SDhkYStya0ZGYnZsOTQ3a0piZ3c0Z2tpSTRJaXZ1aytTbTBHcUlUMlk5T2Fu?= =?utf-8?B?QVQveXFSdjI2WGVNSnAyVlo3OXFxZlVEY3p2RHpuM3A1N0prUzEvakRYNTNh?= =?utf-8?B?ME11MzM1WXM2di9KQ0w4ZGl5NWEvKyszOGhzTHRCL2NGTVdRcHN0b243R0li?= =?utf-8?B?WFNvMVFOMERLNkRUVWNobFhVWmxpOFlnb29MeXBhNHBSRDBsMGUzRnZpV2Yx?= =?utf-8?B?V2tVbERBL2c5T2hQZEU3bThFd1RhdTNudWVhYWJlb0JGRXZsOTJqNXNxanhy?= =?utf-8?B?Mi9IUVlMamtsSmZKRzVoYXBGbVBOY2c3aFBqN3g3bXFWNDRqRlhQWEN6ZE00?= =?utf-8?B?YWpaYWpEM042NjRLT2UxWVI5WTlnbzVlbnhJS09uV1NhZEpETiswTTFpUUtK?= =?utf-8?B?MmozY21MTy9aWGFhbUhjVFRzbzk3dWdXT3RsT2t5MTJYT3BLV3BZZm5NbCtY?= =?utf-8?B?a2xGRk9Vc1pCYzlqcTM3ZjBMR3lxQ2ZwMWVWR29HQTR4aDlWUUozeWlUUjBk?= =?utf-8?B?TGJETEZLTnRnOUVTeTZXZmxaU0RyNHJrNlcvRUxKcUlKaEdmTVNYajRZK1kz?= =?utf-8?B?QlRyb1V1TGs5QWZUOG5rZHJoWnlJUTFQWit4QnZrT2tGbk1QMTNNL0EzU09N?= =?utf-8?B?cnFEaVlvNC8wWE5rQkJ5ZU1JRmxBU0NjalBHejF2dHg1a2FUWmRsclI0RzYv?= =?utf-8?B?MFJNbXBTZ1hycmIrcWtLMjA5UFJCRkcrY0RRM0ozMHl5Y1BEcjRVcjdXV1FU?= =?utf-8?B?SHZTYmtRdnltLzUyS2JWd2hNd282S2FPZ3dDNFJYRytGb3lkeE9OVmRBcThp?= =?utf-8?B?ZHRPSkFvcDZrbTN4RVkyUHU0dDdBdHNmTHJ0RzJQNytsWnF5dlJwbFp5bFhk?= =?utf-8?B?cGtqU0F3akxSejl0am1QS0FwbDh6TTRFZmhEMS9PWHk1OEw0V0pUSmJDdGli?= =?utf-8?B?ZFY3RUZpN2NzcjJud05yaCsyTjYxUzE2R2NzY3ZOTytoQm5SZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0dd2379-d9a8-488b-df98-08dad228a0ea X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 16:41:56.6306 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AselWAORgMynvfH2GmgSrcfO7QWM9y6zbct8EpzfDZvgSVf34Llk5sH2qCRb3ijfVZUsy2bJ6SZSLeMMYOckYs19ZlDvzns8qmGG/i5iK24= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6802 T24gMjkvMTEvMjAyMiAxNToyNywgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gT24gMjkuMTEuMjIg MTY6MDAsIFBlciBCaWxzZSB3cm90ZToNCj4+IC9wcm9jL3hlbiBpcyBhIGxlZ2FjeSBwc2V1ZG8g ZmlsZXN5c3RlbSB3aGljaCBwcmVkYXRlcyBYZW4gc3VwcG9ydA0KPj4gZ2V0dGluZyBtZXJnZWQg aW50byBMaW51eC7CoCBJdCBoYXMgbGFyZ2VseSBiZWVuIHJlcGxhY2VkIHdpdGggbW9yZQ0KPj4g bm9ybWFsIGxvY2F0aW9ucyBmb3IgZGF0YSAoL3N5cy9oeXBlcnZpc29yLyBmb3IgaW5mbywgL2Rl di94ZW4vIGZvcg0KPj4gdXNlciBkZXZpY2VzKS7CoCBXZSB3YW50IHRvIGNvbXBpbGUgeGVuZnMg c3VwcG9ydCBvdXQgb2YgdGhlIGRvbTAga2VybmVsLg0KPj4NCj4+IFRoZXJlIGlzIG9uZSBpdGVt IHdoaWNoIG9ubHkgZXhpc3RzIGluIC9wcm9jL3hlbiwgbmFtZWx5DQo+PiAvcHJvYy94ZW4vY2Fw YWJpbGl0aWVzIHdpdGggImNvbnRyb2xfZCIgYmVpbmcgdGhlIHNpZ25hbCBvZiAieW91J3JlIGlu DQo+PiB0aGUgY29udHJvbCBkb21haW4iLsKgIFRoaXMgdWx0aW1hdGVseSBjb21lcyBmcm9tIHRo ZSBTSUYgZmxhZ3MgcHJvdmlkZWQNCj4+IGF0IFZNIHN0YXJ0Lg0KPj4NCj4+IFRoaXMgcGF0Y2gg ZXhwb3NlcyBhbGwgU0lGIGZsYWdzIGluIC9zeXMvaHlwZXJ2aXNvci9wcm9wZXJ0aWVzL2ZsYWdz LA0KPj4gd2hpY2ggd2lsbCBjb2V4aXN0IHdpdGggL3Byb2MveGVuIHdoaWxlIGRlcGVuZGVuY2ll cyBhcmUgYmVpbmcgbWlncmF0ZWQuDQo+PiBQb3NzaWJsZSB2YWx1ZXMgYXJlICJwcml2aWxlZ2Vk IiwgImluaXRkb21haW4iLCAibXVsdGlib290IiwNCj4+ICJtb2Rfc3RhcnRfcGZuIiwgYW5kICJ2 aXJ0bWFwIiwgd2l0aCAiaW5pdGRvbWFpbiIgYmVpbmcgdGhlIGVxdWl2YWxlbnQNCj4+IG9mICJj b250cm9sX2QiLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IFBlciBCaWxzZSA8cGVyLmJpbHNlQGNp dHJpeC5jb20+DQo+PiAtLS0NCj4+IMKgIGRyaXZlcnMveGVuL3N5cy1oeXBlcnZpc29yLmMgfCAy NiArKysrKysrKysrKysrKysrKysrKysrKysrKw0KPj4gwqAgaW5jbHVkZS94ZW4vaW50ZXJmYWNl L3hlbi5owqAgfCAxMyArKysrKysrKy0tLS0tDQo+PiDCoCAyIGZpbGVzIGNoYW5nZWQsIDM0IGlu c2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv eGVuL3N5cy1oeXBlcnZpc29yLmMgYi9kcml2ZXJzL3hlbi9zeXMtaHlwZXJ2aXNvci5jDQo+PiBp bmRleCBmY2IwNzkyZjA5MGUuLjczOTNlMDRiZGI2ZCAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMv eGVuL3N5cy1oeXBlcnZpc29yLmMNCj4+ICsrKyBiL2RyaXZlcnMveGVuL3N5cy1oeXBlcnZpc29y LmMNCj4+IEBAIC0zNzksNiArMzc5LDMxIEBAIHN0YXRpYyBzc2l6ZV90IGJ1aWxkaWRfc2hvdyhz dHJ1Y3QNCj4+IGh5cF9zeXNmc19hdHRyICphdHRyLCBjaGFyICpidWZmZXIpDQo+PiDCoCDCoCBI WVBFUlZJU09SX0FUVFJfUk8oYnVpbGRpZCk7DQo+PiDCoCArc3RhdGljIHNzaXplX3QgZmxhZ3Nf c2hvdyhzdHJ1Y3QgaHlwX3N5c2ZzX2F0dHIgKmF0dHIsIGNoYXIgKmJ1ZmZlcikNCj4+ICt7DQo+ PiArwqDCoMKgIHN0YXRpYyBjaGFyIGNvbnN0ICpjb25zdCBzaWZzdHJbU0lGTl9OVU1fU0lGTl0g PSB7DQo+PiArwqDCoMKgwqDCoMKgwqAgW1NJRk5fUFJJVl3CoCA9ICJwcml2aWxlZ2VkIiwNCj4+ ICvCoMKgwqDCoMKgwqDCoCBbU0lGTl9JTklUXcKgID0gImluaXRkb21haW4iLA0KPj4gK8KgwqDC oMKgwqDCoMKgIFtTSUZOX01VTFRJXSA9ICJtdWx0aWJvb3QiLA0KPj4gK8KgwqDCoMKgwqDCoMKg IFtTSUZOX1BGTl3CoMKgID0gIm1vZF9zdGFydF9wZm4iLA0KPj4gK8KgwqDCoMKgwqDCoMKgIFtT SUZOX1ZJUlRdwqAgPSAidmlydG1hcCINCj4+ICvCoMKgwqAgfTsNCj4+ICvCoMKgwqAgdW5zaWdu ZWQgc2lmbnVtLCBzaWZtYXNrOw0KPj4gK8KgwqDCoCBzc2l6ZV90IHJldCA9IDA7DQo+PiArDQo+ PiArwqDCoMKgIHNpZm1hc2sgPSB+KH4wVSA8PCBTSUZOX05VTV9TSUZOKTvCoCAvLyAuLi4wMDAw MTExLi4uDQo+PiArwqDCoMKgIGlmICh4ZW5fZG9tYWluKCkgJiYgKHhlbl9zdGFydF9mbGFncyAm IHNpZm1hc2spICE9IDApIHsNCj4+ICvCoMKgwqDCoMKgwqDCoCBmb3IgKHNpZm51bSA9IDA7IHNp Zm51bSAhPSBTSUZOX05VTV9TSUZOOyBzaWZudW0rKykgew0KPj4gK8KgwqDCoMKgwqDCoMKgwqDC oMKgwqAgaWYgKCh4ZW5fc3RhcnRfZmxhZ3MgJiAoMTw8c2lmbnVtKSkgIT0gMCkNCj4+ICvCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0ICs9IHNwcmludGYoYnVmZmVyK3JldCwgIiVz ICIsIHNpZnN0cltzaWZudW1dKTsNCj4+ICvCoMKgwqDCoMKgwqDCoCB9DQo+PiArwqDCoMKgwqDC oMKgwqAgYnVmZmVyW3JldC0xXSA9ICdcbic7DQo+PiArwqDCoMKgIH0NCj4+ICvCoMKgwqAgcmV0 dXJuIHJldDsNCj4+ICt9DQo+PiArDQo+PiArSFlQRVJWSVNPUl9BVFRSX1JPKGZsYWdzKTsNCj4+ ICsNCj4+IMKgIHN0YXRpYyBzdHJ1Y3QgYXR0cmlidXRlICp4ZW5fcHJvcGVydGllc19hdHRyc1td ID0gew0KPj4gwqDCoMKgwqDCoCAmY2FwYWJpbGl0aWVzX2F0dHIuYXR0ciwNCj4+IMKgwqDCoMKg wqAgJmNoYW5nZXNldF9hdHRyLmF0dHIsDQo+PiBAQCAtMzg2LDYgKzQxMSw3IEBAIHN0YXRpYyBz dHJ1Y3QgYXR0cmlidXRlICp4ZW5fcHJvcGVydGllc19hdHRyc1tdID0gew0KPj4gwqDCoMKgwqDC oCAmcGFnZXNpemVfYXR0ci5hdHRyLA0KPj4gwqDCoMKgwqDCoCAmZmVhdHVyZXNfYXR0ci5hdHRy LA0KPj4gwqDCoMKgwqDCoCAmYnVpbGRpZF9hdHRyLmF0dHIsDQo+PiArwqDCoMKgICZmbGFnc19h dHRyLmF0dHIsDQo+PiDCoMKgwqDCoMKgIE5VTEwNCj4+IMKgIH07DQo+PiDCoCBkaWZmIC0tZ2l0 IGEvaW5jbHVkZS94ZW4vaW50ZXJmYWNlL3hlbi5oIGIvaW5jbHVkZS94ZW4vaW50ZXJmYWNlL3hl bi5oDQo+PiBpbmRleCAwY2EyM2VjYTJhOWMuLjc2MmEzNDhhYmUzZSAxMDA2NDQNCj4+IC0tLSBh L2luY2x1ZGUveGVuL2ludGVyZmFjZS94ZW4uaA0KPj4gKysrIGIvaW5jbHVkZS94ZW4vaW50ZXJm YWNlL3hlbi5oDQo+PiBAQCAtNjQ4LDExICs2NDgsMTQgQEAgc3RydWN0IHN0YXJ0X2luZm8gew0K Pj4gwqAgfTsNCj4+IMKgIMKgIC8qIFRoZXNlIGZsYWdzIGFyZSBwYXNzZWQgaW4gdGhlICdmbGFn cycgZmllbGQgb2Ygc3RhcnRfaW5mb190LiAqLw0KPj4gLSNkZWZpbmUgU0lGX1BSSVZJTEVHRUTC oMKgwqDCoMKgICgxPDwwKcKgIC8qIElzIHRoZSBkb21haW4gcHJpdmlsZWdlZD8gKi8NCj4+IC0j ZGVmaW5lIFNJRl9JTklURE9NQUlOwqDCoMKgwqDCoCAoMTw8MSnCoCAvKiBJcyB0aGlzIHRoZSBp bml0aWFsIGNvbnRyb2wNCj4+IGRvbWFpbj8gKi8NCj4+IC0jZGVmaW5lIFNJRl9NVUxUSUJPT1Rf TU9EwqDCoCAoMTw8MinCoCAvKiBJcyBtb2Rfc3RhcnQgYSBtdWx0aWJvb3QNCj4+IG1vZHVsZT8g Ki8NCj4+IC0jZGVmaW5lIFNJRl9NT0RfU1RBUlRfUEZOwqDCoCAoMTw8MynCoCAvKiBJcyBtb2Rf c3RhcnQgYSBQRk4/ICovDQo+PiAtI2RlZmluZSBTSUZfVklSVF9QMk1fNFRPT0xTICgxPDw0KcKg IC8qIERvIFhlbiB0b29scyB1bmRlcnN0YW5kIGENCj4+IHZpcnQuIG1hcHBlZCAqLw0KPj4gKy8q IFRleHQgc3RyaW5ncyBhcmUgcHJpbnRlZCBvdXQgaW4gc3lzLWh5cGVydmlzb3IuYywgd2UgZ3Vh cmTCoMKgICovDQo+PiArLyogYWdhaW5zdCBtaXgtdXBzIGFuZCBlcnJvcnMgYnkgZW51bWVyYXRp bmcgdGhlIGZsYWdzLsKgwqDCoMKgwqDCoMKgwqAgKi8NCj4+ICtlbnVtIHsgU0lGTl9QUklWLCBT SUZOX0lOSVQsIFNJRk5fTVVMVEksIFNJRk5fUEZOLCBTSUZOX1ZJUlQsDQo+PiBTSUZOX05VTV9T SUZOIH07DQo+PiArI2RlZmluZSBTSUZfUFJJVklMRUdFRMKgwqDCoMKgwqAgKDE8PFNJRk5fUFJJ VinCoCAvKiBJcyB0aGUgZG9tYWluDQo+PiBwcml2aWxlZ2VkPyAqLw0KPj4gKyNkZWZpbmUgU0lG X0lOSVRET01BSU7CoMKgwqDCoMKgICgxPDxTSUZOX0lOSVQpwqAgLyogSXMgdGhpcyB0aGUgaW5p dGlhbA0KPj4gY29udHJvbCBkb21haW4/ICovDQo+PiArI2RlZmluZSBTSUZfTVVMVElCT09UX01P RMKgwqAgKDE8PFNJRk5fTVVMVEkpIC8qIElzIG1vZF9zdGFydCBhDQo+PiBtdWx0aWJvb3QgbW9k dWxlPyAqLw0KPj4gKyNkZWZpbmUgU0lGX01PRF9TVEFSVF9QRk7CoMKgICgxPDxTSUZOX1BGTinC oMKgIC8qIElzIG1vZF9zdGFydCBhIFBGTj8gKi8NCj4+ICsjZGVmaW5lIFNJRl9WSVJUX1AyTV80 VE9PTFMgKDE8PFNJRk5fVklSVCnCoCAvKiBEbyBYZW4gdG9vbHMNCj4+IHVuZGVyc3RhbmQgYSB2 aXJ0LiBtYXBwZWQgKi8NCj4NCj4gUGxlYXNlIGRvbid0IGNoYW5nZSB0aGlzIGhlYWRlciwgYXMg aXQgaXMgYmFzZWQgb24gaXRzIG1hc3Rlcg0KPiBsb2NhdGVkIGluIHRoZSBYZW4gcmVwb3NpdG9y eS4NCj4NCj4gQW4gYWNjZXB0YWJsZSBzb2x1dGlvbiB3b3VsZCBiZSB0byBzZW5kIGEgWGVuIHBh dGNoIGZpcnN0IGRvaW5nIHRoZQ0KPiB4ZW4uaCBjaGFuZ2VzLCBhbmQgd2hlbiB0aGF0IHBhdGNo IGhhcyBiZWVuIHRha2VuIHRvIG1vZGlmeSB0aGUNCj4gcmVsYXRlZCBMaW51eCBoZWFkZXIgYWNj b3JkaW5nbHkuDQo+DQo+IEluIGNhc2UgeW91IHdhbnQgdG8gZ28gdGhhdCByb3V0ZSwgcGxlYXNl IGFkZCBhICJYRU5fIiBwcmVmaXggdG8gdGhlDQo+IGVudW0gbWVtYmVycy4NCg0KWW91IGNhbid0 IHVzZSBlbnVtcyBpbiB0aGUgcHVibGljIGhlYWRlcnMgYmVjYXVzZSB0aGV5IGhhdmUNCmltcGxl bWVudGF0aW9uIGRlZmluZWQgYmVoYXZpb3VyIChpbmNsdWRpbmcgdGhlIGNvbnN0YW50cyB0aGVt c2VsdmVzKS7CoA0KQWxzbywgeW91IGNhbnQganVzdCByZW5hbWUgdGhlbSB0byBYRU4gYmVjYXVz ZSB0aGUgQVBJIGlzIHN0YWJsZS4NCg0KRm9yIExpbnV4LCBqdXN0IHVzZSBpbG9nMigpIHdoZW4g Y29uc3RydWN0aW5nIHRoZSB0YWJsZSwgYW5kIGRvbid0DQptb2RpZnkgdGhlIGhlYWRlciBhdCBh bGwuDQoNCg0KQXMgZm9yIHRoZSBhY3R1YWwgZmxhZ3MgZXhwb3NlZCwgaXQgd291bGQgYmUgdmVy eSBiZW5lZmljaWFsIG5vdCB0byBjb3B5DQp0aGUgZXhpc3QgcHJvYyBpbnRlcmZhY2UuwqAgSXQg d291bGQgYmUgYmV0dGVyIHRvIGV4cG9zZSBhIHN1YmRpciB0aGF0DQpoYWQgZmlsZXMgY29udGFp bmluZyBib29sZWFucywgYmVjYXVzZSB0aGF0IGFsc28gZ2l2ZXMgdXNlcnNwYWNlIGFuIGVhc3kN CndheSB0byBmaWd1cmUgb3V0IGlmIHRoZSBwYXJ0aWN1bGFyIGZsYWcgaXMga25vd24gdG8gTGlu dXgsDQppbmRlcGVuZGVudGx5IG9mIHdoZXRoZXIgdGhlIGZsYWcgaXMgc2V0IGZvciBhIHNwZWNp ZmljIFZNLg0KDQpBbHNvLCBJIHRoaW5rIHlvdSBvbmx5IGNhcmUgYWJvdXQgZXhwb3NpbmcgUFJJ ViBhbmQgSU5JVERPTS7CoA0KTVVMVElCT09UX01PRCwgU1RBUlRfUEZOIGFuZCBWSVJUX1AyTV80 VE9PTFMgYXJlIGFsbCBkZXRhaWxzIHNwZWNpZmljIHRvDQp0aGUga2VybmVsIGl0c2VsZiwgYW5k IG5vdCByZWxldmFudCBmb3IgdXNlcnNwYWNlIHRvIGtub3cuDQoNCllvdSBhbHNvIGNhbid0IG1h a2UgYW55IGNhbGN1bGF0aW9uIFNJRk5fTlVNX1NJRk4gYmVjYXVzZSB0aGlzIHZlcnNpb24NCm9m IExpbnV4IG5lZWRzIHRvIHN1cHBvcnQgcnVubmluZyBvbiBhIG5ld2VyIFhlbiB3aGVuIG1vcmUg ZmxhZ3MgaGF2ZQ0KYmVlbiBzcGVjaWZpZWQuwqAgT3B0aW9ucyBhcmUgdG8gZWl0aGVyIGlnbm9y ZSB1bmtub3duIGJpdHMsIG9yIChzbGlnaHRseQ0KbW9yZSBoZWxwZnVsKSBleHBvc2UgdGhlbSBh cyAidW5rbm93biRCSVQiIGJvb2xlYW4gZmlsZXMuDQoNCkZpbmFsbHksIGFueSBjaGFuZ2VzIHRv IHRoZSBzeXMgQUJJIG5lZWRzIHRvIHBhdGNoDQpEb2N1bWVudGF0aW9uL0FCSS9zdGFibGUvc3lz ZnMtaHlwZXJ2aXNvci14ZW4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Tue Nov 29 16:45:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 16:45:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449559.706390 (Exim 4.92) (envelope-from ) id 1p03jL-0006UR-12; Tue, 29 Nov 2022 16:45:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449559.706390; Tue, 29 Nov 2022 16:45:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p03jK-0006UK-U7; Tue, 29 Nov 2022 16:45:10 +0000 Received: by outflank-mailman (input) for mailman id 449559; Tue, 29 Nov 2022 16:45:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p03jJ-0006UC-Cd for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 16:45:09 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2cddff23-7005-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 17:45:07 +0100 (CET) Received: from mail-mw2nam10lp2100.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2022 11:45:03 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by DM6PR03MB5177.namprd03.prod.outlook.com (2603:10b6:5:22b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 16:45:01 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%9]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 16:45:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2cddff23-7005-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669740307; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=rHiG1QXrJjEs6TI4JpojR7n91fraKAmeS1Qd7L8jACc=; b=DCz/3eMT1onfl+8WuxnnNb+9NwCCHkF2+ELYZrkgIbeVETqYSfO8ve92 p9/o26b06wyAMJlx49++SuIlaJNayczFlFu3h/OGD/uLLVrj/Ydc+4TmG fwgwrzDvVzdwNldDo+VWlpx8SqVUzGHQvQXtVr1+deXpxfKtf2USfhSsY k=; X-IronPort-RemoteIP: 104.47.55.100 X-IronPort-MID: 85798842 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:hyRiYKK+cBXxu0goFE+R9pQlxSXFcZb7ZxGr2PjKsXjdYENS0WBSx 2sXUG+HO/rbYGb2f9p2b9/lpkoBvZTdzoRnSAFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wZvPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5IBHNM7 8xAJQwkdyCIiuWLm5S+eK5F05FLwMnDZOvzu1lG5BSAVbMDfsqGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dqpTGLlGSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iLx2b6fzX+hMG4UPLOc1MZAnHev/WhJUSdRZXSC+cKLh1HrDrqzL GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k FiTkLvBGjhHoLCTD3WH+d+pQSiaPCEUKSoHenUCRA5cu937+thr1lTIU8ppF7OzgpvtAzbsz juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslRPuZJu6TABYDn0Mt9 IronPort-HdrOrdr: A9a23:KdqdTa00VrHx3ta5o+1VXAqjBdJxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6 Dsm/av6gDQD0g/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2jnC6l87nzFjmfx1M7XylUybkv3G DZm0ihj5/T+c2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHBmxulf4NoXpyFpXQQrPu04Fgnvd HQq1MLPth16VnWYmapyCGdkDXI4XIL0TvP2FWYiXzsrYjQQy87MdNIgcZ8fgHC40Qtkdlg2O YTtljp/6Z/PFflpmDQ9tLIXxZlmg6dpmcjq/caizh6XZEFYLFcgIQD9Ad+EYsGHgj99Ic7ed MeRf301bJzSxe3fnrZtm5gzJiFWWkyJA6PRgw4tsmcw1Ft7QVE5npd4PZasmYL9Zo7RZUBzf /DKL5UmLZHSdJTRb5hBc8aKPHHRFDlcFbpCia/MF7nHKYINzbmsJjs+og44+msZdgh0IYyop LcS1lV3FRCNH4GMff+nKGjzyq9A1lUBV/Wu4NjDtlCy/HBrYPQQGy+oAtEqbrknx0daverKc pbdqgmR8MLFlGeabqh7zeOJaW6FkNuIfH9muxLL25m8fi7XbHCh6j8TMv5AobLPHINZl7fa0 FzLwQbYv8wo3yWZg== X-IronPort-AV: E=Sophos;i="5.96,203,1665460800"; d="scan'208";a="85798842" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TqDXVbOVKOa2nuwLfszkdm+JFhuhORgNkfwS4A8x+ZiumSMxkEy3Uq885Ef6EyvBAsFaCg3qP3+ys/J6QEWdwnv6Q+RtmVw/HDgvFHCpui5YCHWf/bM9L/0K4/FGrw50vo+Q5qgjnotPVy59Bv8OPl0+1bxsC5gH1/a+kPVKTjLsMjCOIDSKoEIzjFSAuPB6kMI2oQ8iUUWEFEKdDFhz9HdPYn6VRxeaNPXD6Csze/NBXrPB7pwVRcyN0cAgvCdVWWLg4ITj6ZsbSkzwz0WRzS3oILSp1odzau2FFvMLs1Ew4yf0MCOimFJP4htxya/2M95K+lU825ixYPH2Iu3FhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d4IL8K7KB8uKCOf1ktcW//JXR37dQM3ALNhhjLMMZbY=; b=j80ilVhqZ6gXNDdm1ArA8K/2+lf+Ne6S7IA7lSci+UbPNIquGNiLCmRPbhwMVhXizXdRKM+ZV7sYjwk0d6EkGwSi+XYoRwGG4gXsnh1yiz4GzB5zHPAEHIKmYyvS+45k8vkDMdtar9pj3gVVrlF93JmftHj0nkcRIVBilB+GFWrVw7OqtwRL/l37WddpmAbQMjjMUmB2ohJitS5xaEeoOIUcJkijUN1JwDaiyAggY6FSDJKPHdZZIl2RnDXLFiD1ZALLuB6bTf3BWZ7EidhmayKsa1NSbdSpog7kxJCSglMLH4njRGjwm9qeMuf0XxGWIZ0bDks9rE4xczKrd4qUIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d4IL8K7KB8uKCOf1ktcW//JXR37dQM3ALNhhjLMMZbY=; b=j+cmPgqbap4GXgdiQC//7TnRkPY7g6IF1TIV86QwoNhpZrV3X5jNmsu8LufouX1rWeUsy8Y220hnpnBB+UVWhqgpFXMrINfdmt2sOm4RJ6s7VeAyyAhoteZy1SnNmoTz/w6Hy/BwxKQTFGk7C537uM9jkLLGpkHFurYUhINlnzA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 29 Nov 2022 17:44:55 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , George Dunlap Subject: Re: [PATCH] x86/p2m: don't calculate page owner twice in p2m_add_page() Message-ID: References: <3876e026-2a98-b74e-2f49-4bed8fc0a224@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3876e026-2a98-b74e-2f49-4bed8fc0a224@suse.com> X-ClientProxiedBy: LO2P265CA0489.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::14) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB5177:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f0d1ab0-3267-41de-3e2c-08dad2290e7f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QGjDAdPm11qgyY0Gb9dPuLZED94ahHUKsOHtauaj7s4SWqNLIKwANtQ6BdoV4wleQt98G1wUkhG6bbutGpax+S4SqnglnS4eFC3aQl60YOQzTQA9f6+yKb5kLOMfhkicdzxf6FosMYUBUlNZ2BZM4XYmvPVFWeD+TmclEr+c6iR9p7QyKix8YHWR4LSCAFAcEXcSl208Ma0VL31M+qtjsIxKYGwKHjv0AhV0jRH34MJrwXkq55Z4i93L1lIc1POSfmewpqZ3UkyrRRw8hWMeqL/dZfNAqY6zOaYtry0c8Sf7WjcjruPhgq7DV9nFO95gLuvXthfmRsRTM4krDJyaAnWVH9Jd0arfDtAv+GUeOF5vmMcCMVJgCT8iGnhEjwiXMJmWmSFokxRhDXfcM2/6Cwul34jLGK/EwLvvcwCAnXMw4L/E/kz84iN+pzIf/kW4M/BWL792DaNtmQu3dBU3rtCQ8rMA/iD9LTdZmI1G6WWrBOj72faZfUcT2ziCj5yupM796dN+es9yAPX41dSiCtPuoXeDgGTFVW0skBwTZ8KiHzNf2Yo0ZoEj+uRcFkLeuqSstx2y94SVSMAZW0ZSYvVYO2VGBLEZAYaOKmFJc8H/qZW11skl5ykKSPZOaJmLqwlfCTuHSgAVsYTZRbg+YQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(136003)(39860400002)(366004)(376002)(396003)(346002)(451199015)(316002)(2906002)(478600001)(85182001)(6486002)(6916009)(54906003)(66946007)(6666004)(33716001)(83380400001)(82960400001)(38100700002)(107886003)(26005)(6506007)(86362001)(6512007)(9686003)(186003)(5660300002)(41300700001)(8936002)(8676002)(66556008)(66476007)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?endzWENkdmNlcnZtMHB0QnNNTjhHYlFYQVVvQzN0a3lqcEsxQlM1N1NER3Rx?= =?utf-8?B?SjJ6eFZKbnoxN2dlZXFITnhNRHd5MEpyd2JuQmc3QkNnc0hOWnIyTHlQcmxL?= =?utf-8?B?Wk95RlFtMlNwZ0VlZlRRbVpPL041dlVrQVNSaDIxUEtMQktkc3hBb3FqcFgr?= =?utf-8?B?aEFWTHo5eGc4N3BhOXJlbFFubnA1UUpVZHNHd3Vmdm9pSmxVNG9mWlNzaG9m?= =?utf-8?B?dXNIRnF0ZWZkdVJvMFlxeHdoY2lNQ2I3WEpWcGNlbTR4dXNIRWFQV3plVUU0?= =?utf-8?B?c0t0RjhkYjJycVhRN3UyMXRPdi9WeklRaHNDTS9uYy9YbkFHb1hJejc2SXRq?= =?utf-8?B?ZUlzOEtVM1QrcHRhZ2w1dEI0V1VYam5RemFaQmdzZitLUVR2T0lQR1FKd3kx?= =?utf-8?B?YkZFWXhLamR5YVhXVllSVXZxVDBCU0VPQ0hTdThFZUNTazJVMlpTeXJhTTc5?= =?utf-8?B?ZnllWTlMVkVtSFNZaGRSYlcxcnFiWC9jZ3ZFQVJjWDZzWExxQStIdGlkbmxV?= =?utf-8?B?TU1ScEZVS2hjTkNUOEpqWHo3YnJCUXhocWRxcExXN2Q5dzcvZ1JwY3dVM1Fu?= =?utf-8?B?WTNENml3QW9VWkdTNzRoWEh6RHVFc0I0anFaWi8yVzk3bEUxRUkxbnVBeUZB?= =?utf-8?B?TDdtU0VCYmdZVS9nLytHVzJCRXdJYVpVYmt4VWFyUEpCQ2FkQU4vZnovN1lt?= =?utf-8?B?Z05aVUI2TDdkcVA1QVFJSmt1cFpZUTNFWm9NSjRNZFNxZm13eWQ4RnhwYWNS?= =?utf-8?B?cnlYbmZLcU9scHRZWkkyU3lRd3dKRVRyTHA5T3htR2QrVVFQNU94Y3h6TE44?= =?utf-8?B?QXl4aDF3dnBRWkhpalBKWTZwTVhUc2ZoWFNhNnFjTmsyWWx3cDZUOHIvdnJ5?= =?utf-8?B?TnpweFc0OXNOT3kva2RYSkhqYk9Gck10azFGam9FaWxYRTNZZ3dlbGhSOTR6?= =?utf-8?B?VVVSRjVDTW9iREFNTEhXTlBJTEtWVy9sWnhodmRWOEwvakZBYW1kMEJxWllu?= =?utf-8?B?djYyS3orQklKVjFqcVpuM3VWU2tFbXZVUlpYNXhseFNYZDgxM1pyYkZITVlU?= =?utf-8?B?MjhxMVlDL1dHcUxGUzMzUU1vaGxkRi9xRjdDMHJ5NWNqOG44bmEzQkZqa2R2?= =?utf-8?B?VDVsdjYvNENjUUFUY0FnVGVRNFZLaVNtVU9KNDVuVkJaenY1cWhFQUUxQlFS?= =?utf-8?B?OHpFNzFKZGxZekJQclFCdmlsOTBSTEdPenduMzdYbTRoTS9ZTFYrblBaR3NT?= =?utf-8?B?am5mZXFoNVUxQ0hjaEs0OCtqbTVVR0VxeUx0L2ZrcUVTU1ovaHFrQnl4aHVL?= =?utf-8?B?TnM1TFhORkVvZkZ1NFhNakRNTTBFbUVnYllWL2NoUFY3cW1KZHdmR0hRYnJ4?= =?utf-8?B?eUJpbTVEUjd4eEY1Ti8yRnl3NDMzKzVKN2hyWCsxK0tHcG1lajUzT1pQcGhZ?= =?utf-8?B?SENmZGcxblJoM3l2cmNCTENyWjBvNFJ5V1p4QTR6U3kwaU1wdmNXOVgyM3Rl?= =?utf-8?B?bkltdzNWaU11eCtCVVRtUjJrdEFyaDE5amlTd0g4WG56OEMreXpnSEdqTTF4?= =?utf-8?B?c1BqallSSms3eEhaYzJ6ZWlnODhyS2lFU0hoQnZzQlAzclhlVU1CTE9sclV1?= =?utf-8?B?SlNvVEtPVzg3dndNQzFBbWVNODRiMGpYVy9paXVWS3lyREJzUWpNbXdoVldY?= =?utf-8?B?WEwrNkROdFJDVmtHbG1NcGVqaTZNSEZTWTI5Um44NjhNalN5ekNzRmx3QnMy?= =?utf-8?B?Q28yMjE3NlkvSkx6NFYvRlhDWUZscy90cGo5RWpzL0d2aUs0aDZZY0dFbE04?= =?utf-8?B?LzhoQTlWSW1TUnlKNUgrRXlwT29xY3VndkdoN1JQbzl3SVlYejBxNjR3K3RZ?= =?utf-8?B?b1J4Y1FobVI5ZkkyOTdIeVpDQlZGekQ0L05vMG1UWVUyQjVsa3pJZklKcVpv?= =?utf-8?B?L0JQbnB4MkZXOVRsaUwxNm96bS9QUHNuRWdibmhSK1F4Vm0zR1ZzMzFCNzhD?= =?utf-8?B?YTM5Q0Rua2ZBNVE3UlJ6OUxyTWNCK2o5OGZreUhIYmRldW9oMTR3Nkx0SThK?= =?utf-8?B?Sjk2ZTRYaGNlQWRmTkpGYzBlakVPTUtWdmRNbGVNNXRjYTBjcjBCZTBUQkFI?= =?utf-8?Q?qR+JmIBt5jJDCEwpybEgHcX1J?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: EOFjrnpaubvqQgSFe1u0SJahcDHzRJEwPnbGXw9b0VOBOtCN3qMejtWo0oi6LEi+B4spIP6Pj7QrtHgzrltrlU2/itnwbEH40vywy7+Epn4acR/XA76oeNUI2DxQlWeJ5HDHVXbz3TpAVXJIo7jY/StJRE6Ht14TNG6lrGtSONbtjg17q7wuW3D+1DMyhMKTylYl3K0ngHaH396rudzhzJyvgIM8f2Cqx1bMo7664bLaf9Mb7rKpXoAMMzEON0jj8xUDLaH/GqZbcWFn4ZPgvbtI0x5qWbhaA0OxqBHUjRVQzFwMSsGna0qbTRxJGDdw7e5y3UmV/rZwfZMyhkY8/9y0kso04XBNLkroCFzqAB+quH0Qhur/JwMfgW7BHHWNeN8FamhjHBGcTON8RE26Ou64Rzb1w6TghTXotn/QL3pKiz+OqTGw3+aUc/MWW1OP43P6e6lX8ByDNtac/qfxTsD/uCEXyJ+I8+wWroFnv5H53FLY3tPgcOGcc/7DdkIXurolp6N+/Aq3audWuGN/pZo3KEZpIa2XrNYvV47Zf+tknnTXwhvztK1DJff3J7Dnf9B8Y+HpDq7ahDBcyM/cMEvfpC58xT9ldsc3fk1+R/siOmUb5mu63l6P2qV4U0KZk2ISlSA9Ij65xKMpkyE5USwGEy+7Y27l4paucctiqGemoshIV9TpbweYnMyatRF5dAYUaE4/UrPtXKRtwNSJ0fmU0jcmac//FWHm6hBJdDEchFB+o/eKfDvNJB7pGsKiUsTabiiJDmp6JcsQUveHDeZE1i00Mk5Jp0UbWPgeYyP2NEPEbfFbpWMjGfSWCgRTNb1cspyH75ood2QQWYJjfA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f0d1ab0-3267-41de-3e2c-08dad2290e7f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 16:45:00.8495 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vgBNe+q0bmN7dKXb7+2Vg1eLlKbvbjZnGm/MVJ4PwBbIhmdu/wVlNH1HktZYjHrxfNmCy4EGiyiK2SlQ4Q5xOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5177 On Tue, Nov 29, 2022 at 03:47:53PM +0100, Jan Beulich wrote: > Neither page_get_owner() nor mfn_to_page() are entirely trivial > operations - don't do the same thing twice in close succession. Instead > help CSE (when MEM_SHARING=y) by introducing a local variable holding > the page owner. > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné > --- > According to my observations gcc12 manages to CSE mfn_to_page() but not > (all of) page_get_owner(). The overall savings there are, partly due to > knock-on effects, 64 bytes of code. > > While looking there, "mfn_eq(omfn, mfn_add(mfn, i))" near the end of the > same loop caught my eye: Is that really correct? Shouldn't we fail the > operation if the MFN which "ogfn" was derived from doesn't match the MFN > "ogfn" maps to? Getting into that state possibly means something has gone wrong if we have rules out grants and foreign maps? So it should be: if ( !mfn_eq(omfn, mfn_add(mfn, i)) ) { /* Something has gone wrong, ASSERT_UNREACHABLE()? */ goto out; } rc = p2m_remove_entry(p2m, ogfn, omfn, 0) if ( rc ) goto out; but maybe I'm missing the point of the check there, I have to admit I sometimes find the p2m code difficult to follow. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue Nov 29 16:46:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 16:46:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449566.706401 (Exim 4.92) (envelope-from ) id 1p03kv-000792-F7; Tue, 29 Nov 2022 16:46:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449566.706401; Tue, 29 Nov 2022 16:46:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p03kv-00078v-Bm; Tue, 29 Nov 2022 16:46:49 +0000 Received: by outflank-mailman (input) for mailman id 449566; Tue, 29 Nov 2022 16:46:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p03kt-00078p-Ho for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 16:46:47 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 681429e9-7005-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 17:46:45 +0100 (CET) Received: from mail-mw2nam10lp2107.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2022 11:46:38 -0500 Received: from BN6PR03MB3378.namprd03.prod.outlook.com (2603:10b6:405:42::30) by SA2PR03MB5900.namprd03.prod.outlook.com (2603:10b6:806:11a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 16:46:36 +0000 Received: from BN6PR03MB3378.namprd03.prod.outlook.com ([fe80::b47b:e121:d2c1:1e4a]) by BN6PR03MB3378.namprd03.prod.outlook.com ([fe80::b47b:e121:d2c1:1e4a%5]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 16:46:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 681429e9-7005-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669740405; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=wiVejkUtTCvISePLPLgmBAkikBqZPO/chuk88Ngyh1w=; b=XkTPYausQ9HBtNKZqRvc1haMV2/9WoBJ1CTiuK0Br40yQ1amfHj1gt+M USGIkaHQ04KR8U0OczegMeC5NqN3z2SmP3YlP0n0cJMA1OswKn9nAB+TR pzIcr3O5DkPE8wIOjs08hHHwqGtQE/bQMtaHVRwSgaTyULzWovSe3f88i Y=; X-IronPort-RemoteIP: 104.47.55.107 X-IronPort-MID: 85351291 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Cf67aq57EkGG/HfEO8nutwxRtKXGchMFZxGqfqrLsTDasY5as4F+v mYdXj2FbqmLajDxedkgb9m+8U0BsZfVm9drHVFl+SE9Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkR7QeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m1 941ODMXTzC42+uMnp2eVulWpOIzM5y+VG8fkikIITDxK98DGMiGZpqQoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooiOeF3Nn9I7RmQe1tk1zej GPC5GnRCRAGLt2PjzGC9xpAg8efwHimAdhDTdVU8NYwuE+znm5MESQYfnuZuumyineTY/dmf hl8Fi0G6PJaGFaQZtP6RRyj5nmfogQbRcFTAsU98giGzqeS6AGcbkAATzhceJkludUwSDgCy FCEhZXqCCZpvbnTTmiSnp+Woim1IjM9NnIZaGkPSg5ty8L4vIg5gxbLT9BiOK24lNv4HXf32 T/ihC86irYIhMgHzZKn7EvHiDKhoJvOZgMt7wCRVWWghit7boO4Y42j6XDA8O1Nao2eSzGpr HUC3sST8u0KJZWMjzCWBvUAGqmz4PSIOyGahkRgd6TN7Byo8n+nOIVPujd3IR4xNt5eIGe2J kjOpQlW+ZlfemOwarN6aJ6wDMJsyrX8EdPiVbbfad8mjoVNSTJrNRpGPSa4t10BWmB2+U3jE f93qfqRMEs= IronPort-HdrOrdr: A9a23:GRcMLqjujDN9bXOBx+RDLE183XBQX+t23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8bpYOCUghrTEGgE1/qu/9SAIVy0ygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3vJxA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu1Hh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboXkTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp96Z/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wXx4SqbpXUt WGPvusoMq+QmnqKEwxeVMfhuBEa05DWytuhHJy4/B9nQImxEyRhHFoufD31k1wiK7VDaM0pt gse54Y641mX4sYa7lwC/wGRtbyAmvRQQjUOGbXOlj/ErobUki93aIfzY9FkN1CQqZ4u6caid DEShdVpGQyc0XhBYmH24BK6AnERCG4US72ws9T6pBlsvmkLYCbeRGrWRQriY+tsv8fCsrUV7 K6P49XGebqKS/rFZxS1wPzVpFOIT0VUdETuNw8R1WSy/i7Y7HCp6jearLeNbDtGTErVif2BW YCRiH6IIFa4kWiShbD8W3ssrPWCz7CFL5LYdjnFrIoufYw36V3w3kooEX84N2XIjtftaFzdF diIdrc49CGmVU= X-IronPort-AV: E=Sophos;i="5.96,203,1665460800"; d="scan'208";a="85351291" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ra0PhdrNkoj70ksSrOEqOBjEgCYywdihXyokdtfXowydJughc8V1Pm0aQ+ucRqWbRdHAXOYWFmNd7kLRBM1Iihh5HlCRMxdYWiQA13FuWv153G7VtcQfh/2+P3yTpUHQo31SQhuKmVhtBoDqYbzjRE1sa4d9LUHOqHOl/gTTt05ky8ev4CvJK19HuBs2vnPcCl2SyCVSIoT5pc5gEhFcWY7FMr4YCEtMQo8/ch8HK/OZVIRPM2GfGvwRLHdMzm0dOBA/aaHq/KmiZ+WId2s72tqixlF2RlIEIVxSdJpsCTQfvK+7AxF/VYykAi4qyjE3yVFj/7qufa4k09usFcLOHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wiVejkUtTCvISePLPLgmBAkikBqZPO/chuk88Ngyh1w=; b=B+++f5xjUoG84a/muAV5eIPMfVHMMoB3TTlZHAp7N84bhUGQG/3N9vTR9s1EVsdUGN4vi2Or/yCcwNU63pgD56PVaaxXwhXQAzyUAiiT+5mJaUAgPiB17NNp/FWGOQq5NwkU0UWDvkwIpdmURRFnoNfVRgN78fBWsGW/5Jp2s96fdhsKn+yTN/wnKNPPKYBn4LtZ2qo64xdC2z63chmkmu2xY2Lcpe6S2ReiFtZ6Yi/SZP9zjZ2yYzkpfwIaHEfor5/1yBlBDnVJoTRIf563WihGnlWgULK0Vh8h85ApOrTwepvBODBuram5NtxWAjz9LE9LhCqjsfYUuWOdKtWfVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wiVejkUtTCvISePLPLgmBAkikBqZPO/chuk88Ngyh1w=; b=OThitF3CVMcroS1w2EKTtyFrUUbE5vh/Si+bgVzQtV+TMrd0+e3EtLpTsCHruGr0Ev/DHTDf0Jqg8HTBxfJS6w82JhgvxDJqvdrtYpOuPYdqY2egWMGhwgyWuaViLI5VXF1ibIeR3dMRqzPBDNDwI3//lSBTmlGM59C2nW3Si3k= From: "Per Bilse (3P)" To: Boris Ostrovsky , "linux-kernel@vger.kernel.org" CC: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Subject: Re: [PATCH] drivers/xen/hypervisor: Expose VM SIF flags to userspace Thread-Topic: [PATCH] drivers/xen/hypervisor: Expose VM SIF flags to userspace Thread-Index: AQHZBBIkhmTXSR3gVkWwTyVOnEbYaw== Date: Tue, 29 Nov 2022 16:46:36 +0000 Message-ID: <34f726e7-461e-b4b5-96bb-5f934c4d9dbc@citrix.com> References: <20221129150058.266943-1-per.bilse@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN6PR03MB3378:EE_|SA2PR03MB5900:EE_ x-ms-office365-filtering-correlation-id: 6040e924-3510-4f58-4f9f-08dad2294791 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ShBcLV5UqlaL2tmVQomv3IGjwXuM/kx+3Pdmeo7H8LUgR2bAJKSLzPtDMurYaZhiEq2KTBk/yCqYIZoQWFC+NQase6S3TSiDqoahkYeFpBfGDJ/Yrh+5nwoOFenZuLG42xiuOQaw3D1rySQOIGRGdVkoLqQ2wcv/d4ogZJFo9W0vzSA3vSISPFUODb3FeUrp/WiaY88lqUEv1UzJ6AmZasuijClJiU4BzU//G487H18ApKxN4ecfY3uy/3IurDsNzzSWvw7TjpvEWu7nHvPKMqHTbTI9Y8zeBVndREtEVGQjNuwqCtcp0yMow6o7LOtFyz3G5IgzriCHk0KZPnLN8UuKC6p6sb208A6F2oZ3bdDX2F1BkAyAV7MFYc+KeKb0uKiD4CJrl8CpZC3CGCKpaeTe0JYV1MWCplrITkm5pm0ehks5V+8IfCITMCo3/G2jE7L0LydvnQD1d8dW3rM/+n/ZDxGHd5Ilki+XBIKbo+aqI4xH+Rcbllwhq747OmGBHdHXUDUrLDin0i2mXflQeUQQkq07smdI7x8yMlLE6bpJYKY8nCbuPg9uWQGYHvJSiUaL4mIVkf1Ub/6fstrLfIiXttwBIst6uPl3YQyeSYZRGXRCXIYWry/ca8jgfIzR3Yb7/tt7WLStsRYKs4z/8M55rRF2x2YJjl0eKAXIxnRLhSmcU7OgCws/8QlLYK40iHFjzZBZFEZ1/o+umnvh6BqzvX2LH+aUDdZRdIUGeuQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR03MB3378.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(376002)(366004)(346002)(451199015)(2906002)(82960400001)(31686004)(36756003)(4326008)(41300700001)(31696002)(86362001)(91956017)(4744005)(64756008)(66446008)(66946007)(76116006)(66476007)(8936002)(66556008)(5660300002)(8676002)(6486002)(38070700005)(316002)(38100700002)(478600001)(53546011)(122000001)(26005)(6512007)(71200400001)(110136005)(6506007)(2616005)(54906003)(186003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QW8wN0lJWDhicm1iV0U0ZGpzY2ViakFEMG5oSk40MSsyY3B3QVFKd0M0UVR3?= =?utf-8?B?Y0JsNDg4b0lpMkx5a3F3RDJSWW1saTNHK2ppbEwwUUN4MGNlRWxPRzdMeE5P?= =?utf-8?B?SzdSUzNvUmFVRmhpS21LZldRV3d5UUNuNm52dktyWlNickFzOVJ2YXRmbGdQ?= =?utf-8?B?RVEyU0M3UURmalNTbFVIMTJQQnBwSnBxbWJ2b1NUbG5ZdnVmUlpZWmxPa3VX?= =?utf-8?B?WW9HTGxlYmFZV1FzTDFwM21PdklwUDBIM0ZtdVBMcDdSQ2JQbnJhZ3FxYkNW?= =?utf-8?B?MVVETU9GRFZEbnRnS3hIZ3BlSjZVcjVzNHN0RlNUQ24yQ3VDSmh2NDBwR3pu?= =?utf-8?B?bFZ6ZVNCdFRPQ1ozMWxjZWUxZTNRaVZ2Y2pET3QwZktyS0NEamFPbG5Cc2xF?= =?utf-8?B?alF2RmpNNmEzU1VydVp2UTVpbVBlSDNJY3RhZjVwb2JmYzJJTzg0a2dKYllJ?= =?utf-8?B?NUlIdXM1cEZ1NVhBZzQ0Yy9zcDJHNHY0ZHcramZqajlQVE0xU0l3V3VXdlhU?= =?utf-8?B?N2hlUUtVK1lsODE5TnN5T01FeU84eU1XLzJneWZEMEQ5czE4Ulh3LzRxUkds?= =?utf-8?B?UFVubzhIVm95TEZSai96Tm05d2RXYUFBbDlmY2s4Q2VTZ0NJdk9xTFhnVkNB?= =?utf-8?B?Kzd2R1FmdE5DV1QzOGY2dzJ0QnIxaWp1N01hT2hGVzViOGY2QTdack03SFF4?= =?utf-8?B?N2IzQk1ldWtqV3hiZ3R0dWpacUlIWjgzekZFR3Qya2ttWmRKd2JrVmlEMUFR?= =?utf-8?B?N280OXZUdFUxY1pFdmxNckJ1aDRyOFEvUkhIN2VGUTZpdndrZVNkZHB4L2hs?= =?utf-8?B?NDFzSXNDNzl1STFHVFpZdG5Cbit5L1dEU0pWOWpWL1RUTFA2T0FhT2szc2Vl?= =?utf-8?B?WUFuaEpEMDdJckhEWWhydW5EbGlGRnBoUkZJSjNWTGZrb3dweEJhNWg3T2dU?= =?utf-8?B?UkthNEVuTWpkam5rRkpHejRMampkTm9hU0kzcDlaNXgyb2ZGSUNwS2w5aEJ3?= =?utf-8?B?cTJIU0VscGYzdTRRWDVZUmhMVWVDUE5GMTlGbW85V3J4Ym5IN01uSGJWUmFj?= =?utf-8?B?bWhwMzBrTEg3bS9WaFpVL0hJYVNsR1RDaTVXd2xDckh1WWFFWFdpY0VCai9B?= =?utf-8?B?c2dEKzEwTENMRDl0QUl0SHlGNXhjU1pIaFJuWTVNN21SWVdlcHErMlUrbS9u?= =?utf-8?B?R0cxZXZ3UWVUeXU2N1Y0QWQ1SU56MXJCejdOcURaUktmNzBEMHc0VFFQRGtP?= =?utf-8?B?TzlqZ24vOXVORlZ2dTN0aDRQQllRSUk0bFBmZFhBaVY0TjUzcWxrdU9OMHZU?= =?utf-8?B?SjVvbVl4LzJma2VmZXJIemdPOHMzMjZMbUNQdEhkSmxVVFZPRXdINDZwSWt5?= =?utf-8?B?dlZ5N21BVHU3U2gzSEN5Vy9oZXdnUDFmSEZqSk1tcEJuSWpOQ0JlZW9kYUsx?= =?utf-8?B?eEF4bEw2ZGNHSTY2NjBPYkVaWUh2UThHM0NyUm1rcG9oZkpJZWRXYjNMQVc0?= =?utf-8?B?Y1lIVnNnN3d2YmJQbjdPTEJHVWhMMjF4SCtzZTlEOVIrNHFMcGxKb0xtWGhM?= =?utf-8?B?UnQrRjdkd1VEU05lVnV2b1FPZ25GcUE5MzJQSHdxaTc5c0t3eHQ2Z3dQNmJK?= =?utf-8?B?VUYvaW4rOUU2LzI0M1hqQkVMT1lPNlRxOFY0M1o1U1JFVlU3ZGM2NWxxZGFm?= =?utf-8?B?c2dLaTlnTzczWm50U215b1h4VFdRbmpXQkE2MWxaTmt4L0MvckQ3Y0ZqM1Ay?= =?utf-8?B?cXhHckRuNFBYZlY0RDF2dUhaTUs0ZGtQTUxUakxUQ1pMRkYvcndtcjBFQVQ0?= =?utf-8?B?bjNQUmIrZnlPOVI0ZUdadGFuWEpndmY4bjBnb043djVlRmFmRjIxTFg0djgy?= =?utf-8?B?R1JMOUd0RjhuMHRxSThZNCtKM29wNU9MeXl4WmVEUUxzdVBNdCtwSnJQbFRR?= =?utf-8?B?TWdtcHlzQ0NNRklJWTNGUTgwWUtOeXBGV3R0N3ZyUFVPQWtadnRxWHBnTGVi?= =?utf-8?B?eG5NL3Y2RHgwbmQ4SHdhTlFGemF1RTR1T25XcGRJdHFMV2crNFBmRHNnU0Y1?= =?utf-8?B?NWJUMGdzWlJ5NlJvanZtSnVLSlowdURnZ0tEZDBWNTNsZjlzYU9tNFBQVEFJ?= =?utf-8?Q?GsyB8T4SppGY7Ae2lROo6tbsx?= Content-Type: text/plain; charset="utf-8" Content-ID: <8CE434CA1CDD314EB40B057AE335BC2B@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?Ni9pam1Gb0hwdUpYS0JkaWVKQ2d2TkVDbWJSSHZxLzUzWTZVMTk4U1dCSEdh?= =?utf-8?B?Q0FjQUlJbnY4QmtBK3NHdWRYVVNwYjRxaytHQVE0NFI2S0JmZ29oQWdJdlB4?= =?utf-8?B?YktRQ1A3a3NZY1JkY3JNcEV5RmZNYm5pc1pBemY4SUI2cE5QSkNLT2V3cXY0?= =?utf-8?B?L0FoSHRpSnBUWFlGU0haWW15T2E4RUdLbTc5ZUNienNDcGdpQXdYclVaOEhP?= =?utf-8?B?RnlRMFhRd2lPY0V4QnJZbkJXZzJKb29QVGNmR29HRUhyT0FvemVzVzZrMHZT?= =?utf-8?B?dFBLb2JiOXhHV0ZDYS9tRzdkOXVSSHZEZVlHeWRNYjE0SktXVHFBN05vSldH?= =?utf-8?B?OWNVVmxlOWRBbGFaZ0VBRzR1Sm92VzkybnJ0emtJSStFUlVOODMvb3lFSXRX?= =?utf-8?B?ckpwRW1jNUpPZTZTSWJuQ0MvMmwyczJVZkc2ZlhZUXQyREU1NkJpblNIVXdW?= =?utf-8?B?dGtqclkxSlBITktWMVFxQTdmYmk0TTRJWHlBditCZFpEYmRPbFZxZFZwUDh5?= =?utf-8?B?L0FJdUwyenNkam1OT1Zza09iTzcraHUyRDFod3FRVlpIT0YxdjRQK1d4bExQ?= =?utf-8?B?MmljR05telJQQTY5bFZwOTg0Z05HSnBYZzFLSXJpVEFrQ0xmejVuanJjajd6?= =?utf-8?B?dFZkZ3hMVjlZdzhieUpHMjNBaHdIdmxTM0JCUkpYQ2swODh6NHpFb21nTUp2?= =?utf-8?B?cnd1L2NQaXVidGdNWkdJY0ViVW9SV09qNnkzbWhGeXk1eWIyVUNoc3p0bXpk?= =?utf-8?B?T2VTNE02azdKQm82M0JNcTVJSEtHdFlPYzdwdkNsdWVrNWhUYlNyU1BGaEhk?= =?utf-8?B?MFRTSksvK1R4YXQvV2pwUmdnMmtVV0JyeEhEeFhsR1BwUDdPcXYyc1ZMNk5i?= =?utf-8?B?c2RwN2RtZTl5YityV1V1S3hVZGEwNjdFcG5KbHpHNmIyd2VOZDViTGExVUMv?= =?utf-8?B?bE9ZbUhLbWVaT0RUeHQwYjc2Qnk5T3ZlK25tREVjamVXc3NJYzNVMWhlQnJu?= =?utf-8?B?TkNaM1haR25XZTZsZjV0UVVJSUhvNk9xaUZzWW12RHJGL0d0dEZhQmJoR3N0?= =?utf-8?B?RmNtSDZFYWxJZ2JvVkZmT1FQYUpaOHhiSXVneUtvQVNCOGJPQTcwVEZMYnJw?= =?utf-8?B?Rnh3NE9zcmx3aW9qNDdFTTUzdkh4dzVhaUJzTWo2cUFYMDBNUzJHTUx1T2Fs?= =?utf-8?B?NEpOZUowTXpMSjhHaHVIazI0Mnk4aThnSWZIZENUVzBlWUdyT2RNQ1BxOWZW?= =?utf-8?B?d2wwSzRGSWZVU0NkZ3JMdjFObmQwQXpCNGpTMkxvbTB5bUlUZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR03MB3378.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6040e924-3510-4f58-4f9f-08dad2294791 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 16:46:36.2231 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D4uvJ+Yz14acIsz+Jpi6I+f3zqG8DZ5Dr6v77RbWB/P/dhEEXOfAMhbmHs1mU+IJS5WlQoC+7FTemvh4kDSUhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5900 T24gMjkvMTEvMjAyMiAxNjoyOSwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0KPiBXaHkgbm90IHNp bXBseSBzaG93IHVucHJvY2Vzc2VkIHhlbl9zdGFydF9mbGFncyBhcyBhIGhleCB2YWx1ZT8NCg0K UHJvdmlkaW5nIGEgdGV4dCByZXByZXNlbnRhdGlvbiBmb2xsb3dzIHdoYXQgaXMgY3VycmVudGx5 IHRoZSBjYXNlOg0KDQpbcm9vdEBsY3kyLWR0MTI4IC9wcm9jL3hlbl0jIGNhdCBjYXBhYmlsaXRp ZXMNCmNvbnRyb2xfZA0KW3Jvb3RAbGN5Mi1kdDEyOCAvcHJvYy94ZW5dIw0KDQpUaGUgbWlncmF0 ZWQgZm9ybSB3b3VsZCB5aWVsZDoNCg0Kcm9vdEBkdDkwOi9zeXMvaHlwZXJ2aXNvci9wcm9wZXJ0 aWVzIyBjYXQgZmxhZ3MNCnByaXZpbGVnZWQgaW5pdGRvbWFpbiBtb2Rfc3RhcnRfcGZuDQpyb290 QGR0OTA6L3N5cy9oeXBlcnZpc29yL3Byb3BlcnRpZXMjDQoNClRoZXJlIGlzIGdvb2QgcHJlY2Vk ZW5jZSBmb3IgYmVpbmcgbW9yZSBoZWxwZnVsIHRoYW4gcHJpbnRpbmcgaGV4IA0KdmFsdWVzLCBi dXQgSSBoYXZlIG5vIG9iamVjdGlvbnMgaWYgdGhlcmUgaXMgY29uc2Vuc3VzIHRoYXQgYSBoZXgg dmFsdWUgDQppcyBiZXR0ZXIuDQoNCkJlc3QsDQoNCiAgIC0tIFBlcg0K From xen-devel-bounces@lists.xenproject.org Tue Nov 29 17:38:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 17:38:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449573.706412 (Exim 4.92) (envelope-from ) id 1p04Yj-0004mK-8L; Tue, 29 Nov 2022 17:38:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449573.706412; Tue, 29 Nov 2022 17:38:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p04Yj-0004mD-4u; Tue, 29 Nov 2022 17:38:17 +0000 Received: by outflank-mailman (input) for mailman id 449573; Tue, 29 Nov 2022 17:38:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p04Yh-0004lo-4s for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 17:38:15 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 97ad0e32-700c-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 18:38:12 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2022 12:38:08 -0500 Received: from BN6PR03MB3378.namprd03.prod.outlook.com (2603:10b6:405:42::30) by PH0PR03MB6479.namprd03.prod.outlook.com (2603:10b6:510:bb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 17:38:06 +0000 Received: from BN6PR03MB3378.namprd03.prod.outlook.com ([fe80::b47b:e121:d2c1:1e4a]) by BN6PR03MB3378.namprd03.prod.outlook.com ([fe80::b47b:e121:d2c1:1e4a%5]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 17:38:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97ad0e32-700c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669743491; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=uG/FEATAhOMNZcQ2jF0SvGGRkIGOUT6OcTPQ3NjN2Ck=; b=O6c9xAQ6M3J0slL9Q7adFJlNVgwa/Rkxo3/p3KspdBEy+8fzdjjryFSP IwWY7Eg39ezdBdQ5QvpJtuckgivdtfwdjEX+YZnddHI2ff6ivG/bApogk eCvAcWTXBGhUSM/I7oGAUlRzQ08CvcvdWU98HG6sppZ0Q8Oal3Sgsf1cz s=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 85789444 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:tF9Gk6I+4p5U9TzhFE+RTJQlxSXFcZb7ZxGr2PjKsXjdYENShjZUy TceWm/Sa/aIamT1fNsiYNy19xkA7JKHytZqTVFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wZvPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4tEzoX8 /g7AQopazWOlqWc0ujlcMRz05FLwMnDZOvzu1lG5BSAVLMMZ8CGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGNnGSd05C0WDbRUuSHX4N/n0KDq 0rN/njjAwFcP9uaodaA2iLx2b+ewX+nMG4UPLbmxKBYp3GY/EseCA8wWQe1/qGn2mfrDrqzL GRRoELCt5Ma71e3R9PwWxm5pn+svRMGXddUVeog52mlza7Z4B2QAGQeeSJQc9wttMIwRjsC2 0eAmpXiAjkHmLeSU3OGsLCPsSm1JzMWPEcFfyYPSQZD6N7myKkxhB/SStdoEIauk8b4Xzr3x liivCU4wrkek8MP/6G65kzcxSKhoIDTSQw47RmRWXiqhit7a5SifJeA8kXA4LBLK4PxZl2Au mUU3suT9uYDCbmTmyGXBuYABrek47CCKjK0vLJ0N5wo9jDo8Xjze4lVuWh6PB0wbJZCfiL1a kjOvw8X/IVUIHahca5wZcS2Ftguyq/jU9/iU5g4c+ZzX3S4TyfflAkGWKJa9zmFfJQE+U3nB aqmTA== IronPort-HdrOrdr: A9a23:nJyRvarraP6t3PGUrREtnWsaV5saLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhd4tKLzOWwldAS7sSoLcKogeQUBEWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZW6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyR+49bLgFBCc/xEGFxdC260r/2 TpmxHwovzLiYD09jbsk0voq7hGktrozdVOQOSKl8guMz3pziq4eYh7XLWGnTYt5MWi8kwjnt Xgqwope+5z93TSVGeopgaF4Xiu7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twriKknqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYdQ99WPBmcIa+d tVfYXhDcVtABSnhrfizy9SKemXLzEO99G9MxE/U4KuomBrdTtCvjYlLYQk7ws9HdQGOth5Dq 3/Q9tVvaALQckMYa1nAuAdBcOxF2zWWBrJdHmfOFL9Ccg8SgTwQrPMkcEIDduRCes15Yp3nI 6EXEJTtGY0dU6rAcqS3IdT+hSIRGmmRzzixsxX+pA849THNfLWGDzGTEprn9qrov0ZDMGeU/ GvOIhOC/umKWf1A45G0wD3RpEXI3gDV88evMo9Rju104v2A5yvsvaefOfYJbLrHzphUmTjAm EbVDy2P8lE5lDDYA6MvPEQYQKeRqXSx+MBLEGBxZls9GEkDPw8jiEFzVKk+8qMNTpO9qQrYU oWGsKVrp+G X-IronPort-AV: E=Sophos;i="5.96,203,1665460800"; d="scan'208";a="85789444" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C9bk4lOKIoaxVbUP3Tg6l5dvbICf3c5mfzpRodLd7OQoZiyMsbBbnY5Llw0ttU9OZhHugTOnAxxz+N/cpGzRC8GsJGqBXPxiEEtGxUjSym2L/mokhbpHKyT3KP5YH4Z3oK0iMwjn+DW8umrbXi4LOMamK44mTsmF4UWVuO++lD3Huf+wsbNJiMzCVmh7j0g+5qVrHiHpKdPFvuKidbHcMSEaeadefr2brS4S0sBE5bxW48oMHHMdwu8oXrMKRJgLAngX0hMbIKCfamBXG6Px+ZBD2WNqWT6wzASn9LXJfM2sBJCLWx/JJp1aXXV8/exI7eOXH/HKfwt0f06GSKocXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uG/FEATAhOMNZcQ2jF0SvGGRkIGOUT6OcTPQ3NjN2Ck=; b=emFR/TzMPrZ0REFYQ8/Xeu8eWkCdueB9BM5PNrJo+Q118mYloQusZMshMNRTqdlta0yNevuL3So6KI8oF+2tdluWW3f6VUaq4lApDhl3Q/uDEFtwt0C3vowYZnDX5v2zh+oS97Rxn4AW8gltXh0eg/vbJraPhQ64MRd2WjdWJjqkDJEcxghfaJAxPIjlapRHh5Xu+Gl5NwtLrB7HlOlGJlVtKhyCHj1tZ9rlMlRI20hv04EOYhsvLnjeF8HfBmwwf41Ur4nBY5jscNYNUf6wmAMRCVBkfWc3nE3y+/u1FlD4ih1MQPhrBNXtlHTyrAQMrBgGJanwlOOkrMOChDzhzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uG/FEATAhOMNZcQ2jF0SvGGRkIGOUT6OcTPQ3NjN2Ck=; b=iqiqNM1FqJAWCdk2oAL+dRYZBV+WKqKIUJZSZabTPB+5WRLUQkeI+IKtXvhQo/GdE5WLcptUcmW/dHRqFdo5rarxweUZf0o8XguJzz/sDu8kSGG3r5C63FXnKdXmTOX6SdukLqNILQ6LUFNsS/PuFXEovJHvQC32ib2bASDcE2g= From: "Per Bilse (3P)" To: Andrew Cooper CC: Stefano Stabellini , Oleksandr Tyshchenko , Boris Ostrovsky , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" , Juergen Gross , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] drivers/xen/hypervisor: Expose VM SIF flags to userspace Thread-Topic: [PATCH] drivers/xen/hypervisor: Expose VM SIF flags to userspace Thread-Index: AQHZBBlWhmTXSR3gVkWwTyVOnEbYaw== Date: Tue, 29 Nov 2022 17:38:06 +0000 Message-ID: References: <20221129150058.266943-1-per.bilse@citrix.com> <358e49fa-8ce7-67ce-8e0b-e523dee9ea19@suse.com> <92300a81-b97b-f5d6-e3e8-363d8a7d3742@citrix.com> In-Reply-To: <92300a81-b97b-f5d6-e3e8-363d8a7d3742@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN6PR03MB3378:EE_|PH0PR03MB6479:EE_ x-ms-office365-filtering-correlation-id: de35167e-fbfa-4ed9-ba2c-08dad2307958 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wVVTxUkHWuCmYY4e4IgHqGcsI9kfuGtk/LttqDjVIDtVZMsuUZ9RdBI4zFzUOv6meLFB08aHEKxLw4PVO5WhrDvOahoF17DzCu8KWidt4BMdSikRWl1p93kameNrCvUwTZ6S+ZXdKWBv6jNP+JdiEbtYLypt4zA61om1iyvam6f3b4s4qRKgAMs+iIXxK/L5z4s4HKer6t+aJxFIUnAdHKu6/F12cAQ1dbtj8YKeYJYHQge9HS86g652DiHFJQn+VSPmI8LxUWvnWgo8ydb4rbejSr5YYgMpLohTtyDamjGvi5VhLTBfq9tA8p8xkeAr9xA11gKT+NN9cuoSW065wIxDJYyxcFKFN1N64drXA1AQIl7YJc0mQyEuQoYliNZdRI1anSI8Jyf5AkWK3FneeiTaClN6buaJpxIlH2ZTntEeh6OJdpkJ/G2k9aKvLw1uXtPO0KUtT0aRntRRDVzr9FJZo5of1mGxT56DnFlxmUQXSAKQu6LoUt6NUCcdHw2Upvzggy+39Wzyfoezf4crsImzjANWpLOq2ghljzwZGe9opgLOcaQDLbz4EyBdKyVSWyhYN9DIs8UfabxcpidQ/E/A3X855Wfu2kSvAXfxwF1DeXmjOGQEn1luqLp1rYKblhcoDscllPQ/uoLrzs99s+q7BbKONqCxbFlcBoOgBcSja21/csQJ6CKFULtHQhAMHtDyTEfIosHZLilHOvVIPRMW8JF16EaQLZbZ2vghrn4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR03MB3378.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(136003)(39860400002)(376002)(346002)(451199015)(316002)(122000001)(82960400001)(38100700002)(6486002)(478600001)(37006003)(6636002)(54906003)(6862004)(66946007)(4744005)(186003)(31696002)(53546011)(26005)(6506007)(38070700005)(2906002)(71200400001)(8936002)(41300700001)(5660300002)(31686004)(91956017)(2616005)(66446008)(4326008)(36756003)(66556008)(66476007)(64756008)(8676002)(86362001)(6512007)(76116006)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?S3RFZDhYcjdVQzRHb2pJaE9SYmxPZGJZRlppZU1oSDY1UytkVklxaU5nY2xh?= =?utf-8?B?V1JBWWc3Rlc4TSttMjZiZWdFZEpvSjROb0ZBWXYvb1BWZTN2RU5lK3pGeEZa?= =?utf-8?B?NHkxTjZKbHdpVHhsL0xoV0NZQWJURmQ4OXE4eW8zYzdSYzJPQVlKTkRnZ0l3?= =?utf-8?B?ZWxLNzNXWjdDaFZCOGtjZGpFLy9GL05GZzlWRlFCM3ZJNWxVeEc4K2tqOW9o?= =?utf-8?B?Rnphbk5IZExhNnZCemZqTWE2RUZ3bzFVZWMzaW5qaW5IVVU3U1ozZE9LaVRw?= =?utf-8?B?eGhSOUlPL21EcjZsNEtLVTF0ZG1POVlPanN3cEsrRCtjdW05VW5MMDdTYkhM?= =?utf-8?B?blZXdGVYS041NFlESXJ4bEZYQmRocHNGQ1ZObitzSDE5UUlnNWxLYkhVNVky?= =?utf-8?B?ZVFMblRhZmVvUFVkSlBycElxaGw3K0tVcnV2aUN6cnhiTVI5ZXM3VlQvNW1m?= =?utf-8?B?dnRKUEJzK2s1ay8veFlpTlJDelowc2I3REo2VVdWUVVHbWliTERzRkxxa3V4?= =?utf-8?B?OVpUWUpZOHJTMVBYMUxFeXhXRXZIejMyc3dlUUFNTU9NaWRKREZSMXVWemZS?= =?utf-8?B?Q2Zkd0dremg3L2hPS1l6dDczM3VEbXZua01LcDB0dFVOYjladlFkRlVPMjFL?= =?utf-8?B?UUI2WXhqaFprdmg5TVBibU1qT0s5anQ0N05kSGdXQnhjZGZ1Q044OWJ1VTBq?= =?utf-8?B?Y0Q0OHB3eVh3QW9ObGlicHhDT1RQQ2NrWFptZmlIZE0vNmREdGpOb29QWlBM?= =?utf-8?B?eVl1SHVMWlVwZ2ovNnVzdlVtVkZYd3h0N0Yvb0FIN1dDSzZLM1BCN1RNdUsv?= =?utf-8?B?RE1YbWZXazlsQnYzOXhtWmh3d2V0Z3B3WVFVQTMyQ3VxbCs1UC9kbmFuTHBB?= =?utf-8?B?S000QUMwVmpWaStFZTFhZ0JKRHNiN01MWjlJZUEvelVCNXJBMzdCU24yZmd2?= =?utf-8?B?Znczc1lHSmI0MEkvMVVnYzZISkpNejZlRE5vckEvYXRKenhxeWdDRGFFWFBq?= =?utf-8?B?QmJyTmlLNUNpaG1TQ3Qra3ZLWnlJZHpnVUdGVmRNeFNIbm00b0FYWlJOTTdi?= =?utf-8?B?UjRVWlphRkN2eVhPWkdaZXVTNGhjK25OUXZCWFhPakF3elRlRm0vYnZ0dTI5?= =?utf-8?B?cVoyRzhIaG80YmdnajRCY1dOcXJIWmhmUHJxL2Uxd2lsYTFIcC92TTNwZVV3?= =?utf-8?B?RlZDWCtwNHpmRmw3alhoa1VrWjRjZUpPcG1Tb1RKTHMybDM4K3NVMXBwQlBF?= =?utf-8?B?UjlaaWhYOEZXUHVtNUJuK3NwTk5OK2ZtcU02UUZhdzJzRXF0cXc0Ykl1UEJt?= =?utf-8?B?d3Jlejl2Y001N1NyQnp2eTVkNFMwL1RQREgrU0QvMGEvbkhCTlZQWEpLb29K?= =?utf-8?B?QVpudHI1ZGlNR2E3ZElwQmdNQ1h0SlNybzJrcVd6Y2ZtQlY1Vk9OUmFFc1Nm?= =?utf-8?B?L3RibXozRFBZOElqbXB4ZzAzd0JkcEFHQzBKV2dmZU5XNGxiOXVVdVR2VVlG?= =?utf-8?B?RGl4cUptRk5IN0dCOTZzY00xUjlqS1NWclQ0bUhxNzNqZU1kWlBRNU42Sk5p?= =?utf-8?B?Z0M0OTlJWVN3dmt4V2ppcUZ1aTNkaGVKUThqUDdJTFB3N3Q3TU95bEJHUVM0?= =?utf-8?B?bmMyWU5PWkwyeDh5RnM0M1FkSzMwZjc2bHhtUHJzZjFldityMW9kb1M4TVM2?= =?utf-8?B?Zjk0MmdHY05kM0V2VG40eUs4Z0RRS0ZtOWk4c2tkNFVqSmpxQTdDMXZpK3V1?= =?utf-8?B?MzB6TmZObnFHQ2hhUW4vNjY3dXJ6WUVHWXA5c0dsUzRmcDZZNGY4V3pSUEJx?= =?utf-8?B?TUM3WlkyR05CQk5ySmhGSXhxUFYzZ1VXSzRSYTJkVWk2cHRjTnprNWV0ZGho?= =?utf-8?B?S043YnR2eVVYQXF6WTBLdlFlSS9aZXkrYnVhbjVWY2tIcVE3VGIrVHZGTTJ5?= =?utf-8?B?TnZDRmlUYnYxWnZvK3F3TkxqUmNUUXc0ejBGbGZtSjB3M3NUd21tR2NCWWxW?= =?utf-8?B?ZlFnOFNabHdicjFTcHJiUFV2OWJZNnFiWndCZ0Y3TW9PbXZObG5XTWI3ZE53?= =?utf-8?B?VnFEcU9aYjJGa0lxWmNRSXZKVUlybTZRdUJhOFF6UURjdktmN05LL0gydkdy?= =?utf-8?Q?pP42STxCmaHRNt5eR/vtSTn1Q?= Content-Type: text/plain; charset="utf-8" Content-ID: <4BC79FA58A7F5348BF3490F3CE9F589D@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?aDFtZHVXWGQxTXFLa2dmdGZBU1BZSTM5eDFwMTlpQndnMlJGbUwxb2tYaEdS?= =?utf-8?B?M2MwMG5xdVhiVGJic21WWkJ6UWp2NEZTd2dJemt6d3lXM21oMjFjRXpheGRh?= =?utf-8?B?ZjNtTEt4NHdtZzNhbnJiQTRSUzlrcUJwOGQ5NjFMZEVMa1R4ZmJESmU3MHdD?= =?utf-8?B?S1YwNjRDRm5GWmtYNGd1NlVPMGNZZFRGcEFPd1p5Z2VHQWlBckp1dFc5emVz?= =?utf-8?B?eGZseXN2ZWlvcnMrR2RVV0U1NGMrSVo2S042eVRwcVhHZnM2TURmalgrOCth?= =?utf-8?B?dUlVUW1tb2JmOXM0WTVOWDBmRDRKWDlpc2ZYc2pyOFpIRkJ6RERQUDYvZUNJ?= =?utf-8?B?cVFrOGNLeHRkU0M3dWRmWDdISlJISzNTT1hibUZCUVZoZ3FzL2FSaWJabDMr?= =?utf-8?B?ZGFWMWRscHZ0cVFkODhaKysrZDVDNjVTK2JITlZEem5qOGxJR0xXZWJtZkF2?= =?utf-8?B?V2laZk0wc0dYSW5OMi9XRmRLQzYzWUUvY0ZvclYvWWJxeUdrbWkySzhWOTRM?= =?utf-8?B?N1BiWVRvakQraElSSnVTVm50cGpGVFY3ZXcwUFhJM1MvK3A0KzE4b1FqQWsz?= =?utf-8?B?S1JIRE51Ri9tanNZcG1Cdm83ZWlFS1Rpdk5nWnhBVWJ5MmczVHZRM3dGeXlT?= =?utf-8?B?QkZFdHBvTyttZG00WEFFck5tVFRRMTdncUo0ZnNUSkNOSHZPOGRyWm1LUzk1?= =?utf-8?B?SzFINElVemgzWFh3bkpZSExlVzZ0SkM4NFRhUlpUWDNMeHlXa2M1MjlIbmFj?= =?utf-8?B?cFNBa1JuZHYwRUc2WkZOa1F5T21uc2dTbk9qdktXWHBLRnlDZDZzVUZKN1NE?= =?utf-8?B?Vitkc0dyanR3enB2ZzI0QWpWcXJUeThzVW1Xc0RBMHhLOW80UEp1ZWFteGJk?= =?utf-8?B?UHdHakJwTEtQU2dBWTQ3ZkY5ME1XM1hXNW5idHFzUlhkVDc5czlxWVRXTjNZ?= =?utf-8?B?U2FnRFphVEwrc05QSk5kUG43ek5uZjFmRmdWMHNvQ0krbWVGSjZpa04xVi8z?= =?utf-8?B?dFV6N1pTMVNLbElVM2tNY0FkdzhFV2EzWjNIYzRLMXZNenJFZTJnSWR2NTNC?= =?utf-8?B?bm0yOERsYWhiQ0tITVpabzBPQld5amZPM2RVdmF6emxsQUFGR3hETUVXQk8r?= =?utf-8?B?cE0zNUpKc1RLdkh6VUtmWVhjWkpwZFB3RkYrRDRuc3ZOZ043Mi9NK1VVbkhn?= =?utf-8?B?MzY0VW53aUpLQTFGRHV4aktLT0JJdHhqam9ERUd5c2NWTVgzU084OWpNYmZY?= =?utf-8?B?WTUzQmtqZ1dYNTBvSWlHTTg2V1llUEV6MzlOQzh5dGZ0bGZRZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR03MB3378.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de35167e-fbfa-4ed9-ba2c-08dad2307958 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 17:38:06.2311 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qOfrg8Xwfc2S7bNXPAGzZfglcxcLVDQBqaqQqojYNmygJ7nlKyJzbUidL3km5ZaZhW7Pmjbkqd4YX21GsgX39Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6479 T24gMjkvMTEvMjAyMiAxNjo0MSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gQXMgZm9yIHRoZSBh Y3R1YWwgZmxhZ3MgZXhwb3NlZCwgaXQgd291bGQgYmUgdmVyeSBiZW5lZmljaWFsIG5vdCB0byBj b3B5DQo+IHRoZSBleGlzdCBwcm9jIGludGVyZmFjZS7CoCBJdCB3b3VsZCBiZSBiZXR0ZXIgdG8g ZXhwb3NlIGEgc3ViZGlyIHRoYXQNCj4gaGFkIGZpbGVzIGNvbnRhaW5pbmcgYm9vbGVhbnMsIGJl Y2F1c2UgdGhhdCBhbHNvIGdpdmVzIHVzZXJzcGFjZSBhbiBlYXN5DQo+IHdheSB0byBmaWd1cmUg b3V0IGlmIHRoZSBwYXJ0aWN1bGFyIGZsYWcgaXMga25vd24gdG8gTGludXgsDQo+IGluZGVwZW5k ZW50bHkgb2Ygd2hldGhlciB0aGUgZmxhZyBpcyBzZXQgZm9yIGEgc3BlY2lmaWMgVk0uDQoNCk9L LCBJJ2xsIGRvIHRoYXQgaW5zdGVhZDsgSSB0aG91Z2h0IGl0IHdhcyB0aGUgc2luZ2xlICJjb250 cm9sX2QiIHRoYXQgDQpzaG91bGRuJ3QgYmUgcGVycGV0dWF0ZWQuDQoNCkJlc3QsDQoNCiAgIC0t IFBlcg0KDQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 29 17:54:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 17:54:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449580.706423 (Exim 4.92) (envelope-from ) id 1p04oT-0007Z8-Pt; Tue, 29 Nov 2022 17:54:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449580.706423; Tue, 29 Nov 2022 17:54:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p04oT-0007Z1-Ma; Tue, 29 Nov 2022 17:54:33 +0000 Received: by outflank-mailman (input) for mailman id 449580; Tue, 29 Nov 2022 17:54:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p04oS-0007Yv-QY for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 17:54:33 +0000 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id de083b81-700e-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 18:54:29 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2022 09:43:54 -0800 Received: from wteng-mobl1.gar.corp.intel.com (HELO [10.209.83.194]) ([10.209.83.194]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2022 09:43:53 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de083b81-700e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669744468; x=1701280468; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=lKETQwm8/AYRbtudWQgvt+s2fE4xcmiG++pU4pE+d6w=; b=NrGHt9hmVH34l1gobtYnuPPw9Lmy1ow5L98bzjwwI5f0QYoxCqk95X0c L863JL5RsSTAIeK5TXg/Fpo0x3HN0fQB9TKTgk2zjUT9Fi/fuL07i6rQq +9t/QT8r41O8gdhcNJWN6oAiwoZqEnL+T9QGKbsmTah15Tzx1t8dATULK 3nxwFQ2eDa57HVM0Ei4nz5VGHlH1CDqxPVDGpH9oi/B19wODmymusbeR+ X5P+PxWXs49ohxFWxXZfAGBTJSgPGVzaUw2Fb0qEhq7Si1aW+Ydwv8QDB VaD4SiSh883mm3BAiGlHOho+XCPf1egVYUEg9pivFqeeo9Te2XbX63PCK Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="316335762" X-IronPort-AV: E=Sophos;i="5.96,204,1665471600"; d="scan'208";a="316335762" X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="768512573" X-IronPort-AV: E=Sophos;i="5.96,203,1665471600"; d="scan'208";a="768512573" Message-ID: <6b212148-4e3f-3ef6-7922-901175746d44@intel.com> Date: Tue, 29 Nov 2022 09:43:53 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0 Content-Language: en-US To: Roger Pau Monne , linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, jgross@suse.com, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Alex Chiang , Venkatesh Pallipadi , linux-acpi@vger.kernel.org References: <20221121102113.41893-1-roger.pau@citrix.com> <20221121102113.41893-2-roger.pau@citrix.com> From: Dave Hansen In-Reply-To: <20221121102113.41893-2-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/21/22 02:21, Roger Pau Monne wrote: > When running as a Xen dom0 the number of CPUs available to Linux can > be different from the number of CPUs present on the system, but in > order to properly fetch processor performance related data _PDC must > be executed on all the physical CPUs online on the system. How is the number of CPUs available to Linux different? Is this a result of the ACPI tables that dom0 sees being "wrong"? > The current checks in processor_physically_present() result in some > processor objects not getting their _PDC methods evaluated when Linux > is running as Xen dom0. Fix this by introducing a custom function to > use when running as Xen dom0 in order to check whether a processor > object matches a CPU that's online. What is the end user visible effect of this problem and of the solution? From xen-devel-bounces@lists.xenproject.org Tue Nov 29 18:18:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 18:18:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449594.706439 (Exim 4.92) (envelope-from ) id 1p05Bm-0002CJ-Oz; Tue, 29 Nov 2022 18:18:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449594.706439; Tue, 29 Nov 2022 18:18:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p05Bm-0002CC-M1; Tue, 29 Nov 2022 18:18:38 +0000 Received: by outflank-mailman (input) for mailman id 449594; Tue, 29 Nov 2022 18:18:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p05Bl-0002C6-E8 for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 18:18:37 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20615.outbound.protection.outlook.com [2a01:111:f400:fe5a::615]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3bd6884c-7012-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 19:18:35 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by BY5PR12MB5013.namprd12.prod.outlook.com (2603:10b6:a03:1dc::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 18:18:30 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 18:18:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3bd6884c-7012-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IEs47kX7k/cyjaihOFqdxGx3irDJFi/acXPAchc5crg+RzXOCHO49JCypdCBFQBFg6Y4NRSScyFhKmQ7YAsVB9Iu6SRTcYaT413OVsCSZiksfBO6suNV9xgo4Nwj86AVT3pyYTc1QTM4MdU7nqZIgyAKtv1/KNmWs9VE2f+wY05YFq9rXhd6+J2XBGBTP8aVWOOKo4IxGpc7Wklx/ubnx8KUz9WKOy3hR4C0P+LEqsAB+s9PQMoqIOj//+HOvVpklm2kMKPTFS7cAGAuEX5HRhNzz1UA5t2yzzfbtU01gLEhYZExfO8+o/ngFdJeRnlvIQEFRGbisiPGZGWxzRCFaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OLEchdli/7COZ67EyDB2QksOehcQuNWimF4IRF+xfTo=; b=WAcx3NKL0WcLvKzBy6B/I0dm3xWriJEVRnasX7Bk1tvRGX2rD9f1g81hNrDnR8vGwosGplxNLqJ4NsyL70WZ+LkFFr0PZ8Yhaa8fVOrK/biSITZOf8iArSmLbYfCHT478rKvsoZ3ZlLKGpk2/ZgPxDYmW4sBLuZDI4xNyK74lRUmB821RSXXvLdGeeoNwsjP+UNfqC84SWQUdExD8aPFrucegRlmMIBMFE1J9ZUweENxfO7tIHfRGmWmq3vLCmkgyUh1cefu/m6q2CwWJkSjouubj1ng/f7wLop33cV5sdEH/CZ8H5XCc/p4AIVBJ/iLljw//hjV3XfTq3f3HgFD+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OLEchdli/7COZ67EyDB2QksOehcQuNWimF4IRF+xfTo=; b=L20EPAhFgMrOygNT4UZI9bm2F+xvp8fhdTqF8oIfiUtKPU5eU+4yJ59mVLtfaHAJRQ1RPNccjeZkBckuo1mjhFYZdpHO/x1UjJDgtIMfkiDLY+ciG4bd9EnVkIpgs0lCns/rgXV+BAW+vIHBq+MpzcMktxEYz7nzYrfp/Q7n+d0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <105a0d45-5b3d-7986-92c1-9a13eb803bd8@amd.com> Date: Tue, 29 Nov 2022 18:18:24 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Arm: AArch32: Need suggestions to support 32 bit physical addresses To: Julien Grall , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , "Stabellini, Stefano" , bertrand Marquis , Andre Przywara , "Volodymyr_Babchuk@epam.com" , Rahul Singh , Vladimir Murzin References: <70651dbc-085d-706d-17d0-a419086a0700@amd.com> <65891843-db28-e5dd-6e9e-3fb003fcabc5@amd.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0008.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::20) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|BY5PR12MB5013:EE_ X-MS-Office365-Filtering-Correlation-Id: d1562149-2135-427c-b0e3-08dad2361e0d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h+sSEd7OhC0dGu7u1tPtV175mE+Y7NjIxE177n/ZTgP4lqGscigMLUoVqQ9FF16ebYngvHES7/S+zPBZjYnxfPvIS0cfCOYtR0a6F2iisfua1N7QTQ/UL4+x4zPeer+zudBx1+zUBFEezjfGiVyLpKRUo+89w7bGuFN3Iz7G58jleWaPhlsYP/FZonc6EZ0qeQ3hXCCOZlDnk7AD9YAdLz3Xt85UQYRLbrjBq1K2Ive/aaTCIDwDaDJ2iXd7mQovqS8vFyyS+/4u3KUEK6yF86Rqj5Z3A+f9LISK634peSlZrBdHkUcf20TeiK9Q2fR663SoDXA/t1nLeqCUXQdEkx8WWE9Ue+Nr4rNJw/ZSvRA/2izINKsaGtAoPh88bzXhn1eC218rMI0KOSuZWsFWVSfJ4drK+JISkEknf+JzvL1V4S4v7rRwjKuP89dU1z0ROvzljgQAfVYVt3q1nwX2jLC2WGA0LKnE8LQzz20OInCNdXzZEv4iw09dXlkaCX+Dqxd6+H81N8eXfcd7ZpG0OAew+VW/ZwARwig7yLpTijoLwrE6IXRG6l4nWNgOQSpdYTHJNY9WH0Mdd/cBrL3BKJ76R5tYRLi+lp1FDPrDUh9fd9eOAlgFMm0It3eVaeaghu3x61BBCv2UrwZEPXFE4Z2j0CAO2oJ7kEGNUmWpY4uescsvRgHNd4GV1pu3ZLKY04JxOWsHBMrT7xb+s6l0m5mafhnYus5UEBcpKqcULgk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(136003)(376002)(346002)(396003)(451199015)(6486002)(6506007)(31696002)(83380400001)(478600001)(31686004)(53546011)(6666004)(26005)(316002)(110136005)(6512007)(54906003)(41300700001)(2616005)(5660300002)(38100700002)(2906002)(8936002)(4326008)(66946007)(66476007)(36756003)(186003)(66556008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkZlWFVNZEdEeG13VUF4Q1NiTEtKZllvcHljenNmNnkyWkNuaHhnOVJpUjB1?= =?utf-8?B?VWRMVWZ2Nkwwb2gvRHJ0RDZkamhaSFFOVElxUDZSUDMrNlJMNGJkbFFmdGNR?= =?utf-8?B?azYxZkh2NzdYNnhQMTRudHJrMW85cmJXMjJ6MEFqS3Z2NVJTZU9zV2lUS1VH?= =?utf-8?B?emtsa1lYQUhLbU9XUEVCQ0lmR0JlU1c0UElZUzJwSGVLQ2hMNzJBTXNBK3ZZ?= =?utf-8?B?eFlEY21XWUpNNlV6VFExUm1VMGJDbWdZYzc3NkpWc0o5Y09mL1ZINTZIRjdG?= =?utf-8?B?M3lLVzVDazZ5UFg4cjdSWWgzQVpVdHZIa3g3Q2hoMStvVHV6QWtHOE5vdVJw?= =?utf-8?B?WVlOWWZjWm10SnVudnR2Wk5VSnE5TllHYUlWWVdjS3E2bTRyeHB4SjdKWTVa?= =?utf-8?B?dzg3cDBMbTZzdWlVY2E1aFFyNDM5djlpcHFjSVNxdDQ1WWcrZTlqY2NQdkxS?= =?utf-8?B?Q3hLU3hoMWFHdWNvY1NOWVFPMHRuRjYvSGMyWGJFY0pOMXBhN29iSVBTK2xS?= =?utf-8?B?VHcrbUMyenZsTHpyQUhNNlEvMHNDbEcyUW1kUkxJNHp6S3JGa1d2MmlxbzVl?= =?utf-8?B?TzY4aXlDblFCbDdsRkRoNysrOW4xS0U0K1pGY1RaSkFZSHlMUlJzQ3lLK0VI?= =?utf-8?B?M0Fmd1hUVDdMZXg0Q0Z3YzFzclBXbEVuQ0hySWVxcHVheTFLUHY4bEZramov?= =?utf-8?B?VGc2T2NCOUVHV0tEd2hmT2oyVWpCRC84WGE4bDJ6WVZKblVxanduTVFRTzlE?= =?utf-8?B?SFJWdEtod1RsZWNkYzlIWUZhR1ZDckdjcUpOQmZKam5BQTh1ckhuOFlUeXBq?= =?utf-8?B?UmdQM2tKSjltY1VNZmRCZ1Rsc3pRUUg3QXpmajd6S3hvamNET2FQM3ZLRnVm?= =?utf-8?B?aWZ5SzlxNjJNbGFHbFJkYmg2aFhPTnRCeGhLbVFWR1J3V29paUZqMTRXMjlK?= =?utf-8?B?ajljQWZDeWlUanFoTUx6R01GeWlpc05uVDIvVSs3ZjhQMFp6QW9HcEFZOFlo?= =?utf-8?B?dVp4ZVdLbFlGb0J2ODNRalRrcXRrSjZraFhSbllyYVJFemxNRC9GYUgxVTYx?= =?utf-8?B?ckVsaGFrL2tSZkVsZXh5eUdmS01uUUJydDNhZG9JZlRkMFZXU1JkUWQ3c1dZ?= =?utf-8?B?aFQxT2pHUitGL1I1QUZoN0FuR2Y2RUtZdGlhb3UrTFRBQS9PbmVrSnBSdGJj?= =?utf-8?B?czJYYTNFNDdwaEw1UHp5bzNVd3lqSGNBY1loVFJaVm1WNkc4a1ZZZUtCazZ2?= =?utf-8?B?VEErTVNSdmtPajZlNlEzOWV6dUYwVlFtMDF2d0xaYjF3Y21YbWsxeGM1SUo3?= =?utf-8?B?T2VDR1BlSldxVzE5ZEdqYmFhcVkvUzYyVTlPT016MkU2ZXNFbVZ5NVRmSFFV?= =?utf-8?B?NDhaWVA3NDJCNWdEMmJtMzc4YktDKysrN1AwR0tNb2h4MkVIa2cvYzdrLzgr?= =?utf-8?B?Wm1UaVcrMnRFTGpibCtQQmtaQ3o0MGN6dm40VzFybzVPVHkvNnhsL0VKZ1hP?= =?utf-8?B?Y0pyNmxzV1dZTXZxMHNBUUxHNTR6bzdydEtmd1RpU1BIYm9IWTdTKzBYdTl4?= =?utf-8?B?UGV5aDBuZ3V0OGNad291UmR4VTBjMlBqdlMrdUlPQXdxdlBDU3RDRDNCVWhy?= =?utf-8?B?Y2dGYnp5eVNmY3g0VS9FekE2akMvTFVKWFJCcnBvMm96UkFnTWRHNVFoSTUz?= =?utf-8?B?QzRzOUVSL1EvUXNiWUx6QmpRYUpVdkJXR2ZrU0lqWlFQTEIwcnMvd2J5WEdt?= =?utf-8?B?V21SdG44U3NqK2x3YUV5Q2ZiYVQ3ZW5GajhPZ2RUSXEydkVxd2FSdnRuOXNJ?= =?utf-8?B?ckFNcTV4a1hKKzdocG9vMTFIdzljMTIxWG9Ub0NJOFlVMlBzRHRPbFgwMnJG?= =?utf-8?B?L1NwVXROTzZMbHU4QlpQKy84NE9IeldyVU1PYytZS1E4QUVteEg3cGpaWTI0?= =?utf-8?B?d2pmVkMrRm55UGNFN1RDNFJ5U1g5RjNRSWZIU1EwWitPRkhOOU9EZUw4WE1k?= =?utf-8?B?dEYyNm5CWWFra2NUT1daWXh0VVZqRmhKbTc3RGFUTXQ1UlZnZUxOaHoycUc5?= =?utf-8?B?Z2hBbi9RWlBYQTlPTWlueEJIaDZUQVJycngxN1hrZlVOSE0yUGNHMWQzMVFl?= =?utf-8?Q?kTVtRLMYRFNXZ6+zV0fjTG0eC?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1562149-2135-427c-b0e3-08dad2361e0d X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 18:18:30.3751 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +PYInTNxF2CUZHISAwK5BYAWDfFQTPGBBATZ6Kpg7EXvkPA7sicVvcMWL9FhC7Y3tRTdz/Thv+oG3oQrzekTjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB5013 On 29/11/2022 15:52, Julien Grall wrote: > > > On 29/11/2022 16:23, Ayan Kumar Halder wrote: >> >> On 29/11/2022 14:52, Julien Grall wrote: >>> >>> >>> On 29/11/2022 14:57, Ayan Kumar Halder wrote: >>>> Hi All, >>> >>> Hi, Hi Julien, >> >> Hi Julien, >> >> Many thanks for your inputs. >> >>> >>>> I am trying to gather opinions on how to support 32 bit physical >>>> addresses to enable Xen running on R52. >>>> >>>> Refer Cortex R52 TRM, Section 2.2.12 "Memory Model" >>>> >>>> "...This is because the physical address is always the same as the >>>> virtual address...The virtual and physical address can be treated >>>> as synonyms for Cortex-R52." >>>> >>>> Thus, I understand that R52 supports 32 bit physical address only. >>>> This is a bit different from Armv7 systems which supports Large >>>> Physical Address Extension (LPAE) ie 40 bit physical addresses. > >>>> Please correct me if I misunderstand something. > >>>> So currently, Xen supports 64 bit physical address for Arm_32 (ie >>>> Armv7) based system. >>> >>> Xen supports *up to* 64-bit physical address. This may be lower in >>> the HW (not all the Armv7 HW supports 40-bit address). >>> >>>> My aim is to enable support for 32 bit physical address. >>> >>> Technically this is already supported because this is a subset of >>> 64-bit. I can see a use case (even on non R* HW) where you may want >>> to use 32-bit paddr_t to reduce the code size (and registers used). >>> >>> But I think that's more an optimization that rather than been >>> necessary. >>> >>>> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c >>>> index 6014c0f852..4f8b5fc4be 100644 >>>> --- a/xen/arch/arm/bootfdt.c >>>> +++ b/xen/arch/arm/bootfdt.c >>>> @@ -56,10 +56,10 @@ static bool __init >>>> device_tree_node_compatible(const void *fdt, int node, >>>>   } >>>> >>>>   void __init device_tree_get_reg(const __be32 **cell, u32 >>>> address_cells, >>>> -                                u32 size_cells, u64 *start, u64 >>>> *size) >>>> +                                u32 size_cells, paddr_t *start, >>>> paddr_t *size) >>> >>> This needs to stay uint64_t because the Device-Tree may contain >>> 64-bit values and you... >> >> Are you saying that the device tree may contain 64 bit addresses even >> though the platform is 32 bit ? > > There should not be any 32-bit address but you don't know what the > device-tree is containing because this is user input. > > This is not the business of the Device-Tree parser to decide whether > the value should be downcasted or rejected. That's the goal of the > callers. > >> >> I think then this approach (ie "typedef u32 paddr_t" for 32 bit >> system) is incorrect. > I am a bit surprised you came to this conclusion just based on the > above. As I said before, there are benefits to allow Xen to be built > with 32-bit (e.g. smaller code size and better use of the register). > >> >> Then, the other option would be to downcast 64 bit physical addresses >> to 32 bits, when we need to translate pa to va. >> >> Do you think this approach looks better ? > > Some of the changes you propose are questionable (see below). > >> Or any better suggestions ? > > Rework you previous approach by not touching the Device-Tree code. > >> diff --git a/xen/arch/arm/include/asm/mm_mpu.h >> b/xen/arch/arm/include/asm/mm_mpu.h >> index 306a4c497c..f4f5ae1488 100644 >> --- a/xen/arch/arm/include/asm/mm_mpu.h >> +++ b/xen/arch/arm/include/asm/mm_mpu.h >> @@ -89,7 +89,18 @@ static inline paddr_t __virt_to_maddr(vaddr_t va) >>   static inline void *maddr_to_virt(paddr_t ma) >>   { >>       /* In MPU system, VA == PA. */ >> +#ifdef CONFIG_AARCH32_V8R >> +    /* >> +     * 64 bit physical addresses are not supported. >> +     * Raise a bug if one encounters 64 bit address. >> +     */ >> +    if (ma >> BITOP_BITS_PER_WORD) >> +        BUG(); > I don't particularly like the runtime check when you should be able to > sanitize the values before hand. I think we can replace BUG() with ASSERT(). This is similar to what is being done today. > >> + >> +    return (void *) ((uint32_t)(ma & GENMASK(31,0))); > > & GENMASK (...) is a bit pointless here given that you above confirmed > the top 32-bit are zeroed. > >> +#else >>       return (void *)ma; >> +#endif >>   } >> >>   /* >> diff --git a/xen/arch/arm/include/asm/setup.h >> b/xen/arch/arm/include/asm/setup.h >> index b3330cd584..3f4ac7f475 100644 >> --- a/xen/arch/arm/include/asm/setup.h >> +++ b/xen/arch/arm/include/asm/setup.h >> @@ -119,7 +119,11 @@ extern struct bootinfo bootinfo; >> >>   extern domid_t max_init_domid; >> >> +#ifdef CONFIG_AARCH32_V8R >> +void copy_from_paddr(void *dst, uint32_t paddr, unsigned long len); >> +#else >>   void copy_from_paddr(void *dst, paddr_t paddr, unsigned long len); >> +#endif > > I don't understand why the probably needs to be changed here... > >> >>   size_t estimate_efi_size(unsigned int mem_nr_banks); >> >> diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c >> index 04c05d7a05..7a7386f33a 100644 >> --- a/xen/arch/arm/kernel.c >> +++ b/xen/arch/arm/kernel.c >> @@ -46,7 +46,11 @@ struct minimal_dtb_header { >>    * @paddr: source physical address >>    * @len: length to copy >>    */ >> +#ifdef CONFIG_AARCH32_V8R >> +void __init copy_from_paddr(void *dst, uint32_t paddr, unsigned long >> len) >> +#else >>   void __init copy_from_paddr(void *dst, paddr_t paddr, unsigned long >> len) >> +#endif >>   { >>       void *src = (void *)(unsigned long)paddr; > > ... because the code should compile without any issue. If you were > really concern about ignore the top 32-bit, then you could add a > BUG_ON() (This is OK because this is init code). Yes, the code compiles fine without the change. I can put a BUG_ON() here. > >> >> diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c >> index df43621ee7..62774aebc6 100644 >> --- a/xen/arch/arm/mm_mpu.c >> +++ b/xen/arch/arm/mm_mpu.c >> @@ -29,7 +29,7 @@ >>   #include >>   #endif >> >> -#ifdef CONFIG_AARCH32_ARMV8_R >> +#ifdef CONFIG_AARCH32_V8R >>   #include >>   #endif >> >> @@ -414,7 +414,18 @@ void *ioremap_attr(paddr_t pa, size_t len, >> unsigned int attributes) >>           return NULL; >>       } >> >> +#ifdef CONFIG_AARCH32_V8R >> +    /* >> +     * 64 bit physical addresses are not supported. >> +     * Raise a bug if one encounters 64 bit address. >> +     */ >> +    if (pa >> BITOP_BITS_PER_WORD) >> +        BUG(); > > Why not returning NULL? Ack > >> + >> +    return (void *) ((uint32_t)(pa & GENMASK(31,0))); >> +#else >>       return (void *)pa; >> +#endif >>   } >> >>   static void clear_boot_mpumap(void) >> @@ -1007,7 +1018,19 @@ void * __init early_fdt_map(paddr_t fdt_paddr) >>       nr_xen_mpumap++; >> >>       /* VA == PA */ >> +#ifdef CONFIG_AARCH32_V8R >> + >> +    /* >> +     * 64 bit physical addresses are not supported. >> +     * Raise a bug if one encounters 64 bit address. >> +     */ >> +    if (fdt_paddr >> BITOP_BITS_PER_WORD) >> +        BUG(); > > Same here question here. > >> + >> +    fdt_virt = (void *) ((uint32_t)(fdt_paddr & GENMASK(31,0))); >> +#else >>       fdt_virt = (void *)fdt_paddr; >> +#endif >> >>       if ( fdt_magic(fdt_virt) != FDT_MAGIC ) >>           return NULL; >> @@ -1165,13 +1188,13 @@ void __init setup_protection_regions() >>           { >>               pr_t region; >>               access_protection_region(true, ®ion, NULL, i); >> -#ifdef CONFIG_AARCH32_ARMV8_R >> +#ifdef CONFIG_AARCH32_V8R >>               printk("Boot-time Xen MPU memory configuration. #%u : >> 0x%"PRIx32" - 0x%"PRIx32".\n", >>                      i, pr_get_base(®ion), pr_get_limit(®ion)); >> -#else /* CONFIG_AARCH32_ARMV8_R */ >> +#else >>               printk("Boot-time Xen MPU memory configuration. #%u : >> 0x%"PRIx64" - 0x%"PRIx64".\n", >>                      i, pr_get_base(®ion), pr_get_limit(®ion)); >> -#endif /* CONFIG_AARCH32_ARMV8_R */ >> +#endif >>           } >>   } >> >> @@ -1262,8 +1285,13 @@ static int __init relocate_xen_mpumap(void) >>       if ( !xen_mpumap ) >>           return -EINVAL; >> >> +#ifdef CONFIG_AARCH32_V8R >> +    copy_from_paddr(xen_mpumap, (uint32_t)(pr_t *)boot_mpumap, >> +                    sizeof(pr_t) * next_xen_mpumap_index); >> +#else >>       copy_from_paddr(xen_mpumap, (paddr_t)(pr_t *)boot_mpumap, >>                       sizeof(pr_t) * next_xen_mpumap_index); >> +#endif >> >>       clear_boot_mpumap(); >> >> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c >> index 62afb07bc6..a73bf7de01 100644 >> --- a/xen/common/page_alloc.c >> +++ b/xen/common/page_alloc.c >> @@ -2245,7 +2245,9 @@ void __init xenheap_max_mfn(unsigned long mfn) >>   { >>       ASSERT(!first_node_initialised); >>       ASSERT(!xenheap_bits); >> +#ifndef CONFIG_AARCH32_V8R >>       BUILD_BUG_ON(PADDR_BITS >= BITS_PER_LONG); >> +#endif > > BUILD_BUG_ON() are used to indicate that the code would fall over the > check pass. I can't find the justification for this change in the > commit message. I had a look at the following commit which introduced this, but I couldn't get the explaination for this. commit 88e3ed61642bb393458acc7a9bd2f96edc337190 Author: Jan Beulich Date:   Tue Sep 1 14:02:57 2015 +0200 @Jan :- Do you know why BUILD_BUG_ON() was introduced ? > > It is also not clear why you are modifying this path because so far on > Arm32 the xenheap and domheap are separated for good reason (i.e. lack > of address space). Is this going to change with Armv8-R? > See this comment  * CONFIG_SEPARATE_XENHEAP=y  *  *   The xen heap is maintained as an entirely separate heap.  *  *   Arch code arranges for some (perhaps small) amount of physical  *   memory to be covered by a direct mapping and registers that  *   memory as the Xen heap (via init_xenheap_pages()) and the  *   remainder as the dom heap.  *  *   This mode of operation is most commonly used by 32-bit arches  *   where the virtual address space is insufficient to map all RAM. This is not true for R52 as the memory is mapped 1-1. Thus "VA == PA". I don't think the lack of virtual address space applies to R52. Thus, CONFIG_SEPARATE_XENHEAP=N - Ayan > Cheers, > From xen-devel-bounces@lists.xenproject.org Tue Nov 29 19:57:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 19:57:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449605.706450 (Exim 4.92) (envelope-from ) id 1p06j3-0005Iy-W6; Tue, 29 Nov 2022 19:57:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449605.706450; Tue, 29 Nov 2022 19:57:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p06j3-0005Ir-RQ; Tue, 29 Nov 2022 19:57:05 +0000 Received: by outflank-mailman (input) for mailman id 449605; Tue, 29 Nov 2022 19:57:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p06j0-0005Ik-T4 for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 19:57:03 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fb58440e-701f-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 20:56:58 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4FD37B818FA; Tue, 29 Nov 2022 19:56:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF8EBC433C1; Tue, 29 Nov 2022 19:56:55 +0000 (UTC) Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 889C95C0584; Tue, 29 Nov 2022 11:56:55 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb58440e-701f-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669751816; bh=iVPFSoAi7N2z9tvogNn084+/tpD32p8Km3465/86GcA=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=tJLJvJcqsM8LTLUvVoyhoi/6+/rCv+JPPeLzJUYWJ0eGKnscBYdeZ2Od2A1KZq0Z9 8/x35OfefuiTQTptsAMLXJpc5j+tByWuA2P1uflQG60kP6UTpHFY1eeakAJhFxH3sZ O9OKnpWpuk9HSGaV5fTt1v20AOWs+vao7oTnfEg2S2rcOE7DtnWKsjqk5rAIYPEQ56 uPqbI7Mknc4gNiKvatNym8n/HGfi9Wgf8d6iAbuVdk2/zBiYHS7BSNqDqMNh0x0ZIA +p9pSoH8vUaRrolkWC/z2WZeN4AQjBC70yW5syju3eIlEit4OkN+BdmFIv00nJm40I R804wocREstPA== Date: Tue, 29 Nov 2022 11:56:55 -0800 From: "Paul E. McKenney" To: Juergen Gross Cc: Josh Poimboeuf , Andrew Cooper , Peter Zijlstra , "sfr@canb.auug.org.au" , "linux-kernel@vger.kernel.org" , "sstabellini@kernel.org" , "boris.ostrovsky@oracle.com" , "xen-devel@lists.xenproject.org" , Thomas Gleixner Subject: Re: objtool warning for next-20221118 Message-ID: <20221129195655.GA826794@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20221123012350.kelmmadh65lyswqz@treble> <2255c45f-d8ba-3f32-9d99-737ad3040dd7@citrix.com> <20221123170337.keacggyvn4ykbtsw@treble> <20221124023934.nft3udxelth4lvai@treble> <72a4871b-3ee8-42c1-912a-321a45690428@suse.com> <68dc479a-6b61-0012-888d-c1b4cc513cdb@suse.com> <20221124163928.dof5ldfer6rswlnx@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Nov 25, 2022 at 06:30:35AM +0100, Juergen Gross wrote: > On 24.11.22 17:39, Josh Poimboeuf wrote: > > On Thu, Nov 24, 2022 at 08:47:47AM +0100, Juergen Gross wrote: > > > > > +++ b/arch/x86/xen/smp_pv.c > > > > > @@ -385,17 +385,9 @@ static void xen_pv_play_dead(void) /* used only > > > > > with HOTPLUG_CPU */ > > > > > { > > > > > play_dead_common(); > > > > > HYPERVISOR_vcpu_op(VCPUOP_down, xen_vcpu_nr(smp_processor_id()), NULL); > > > > > - cpu_bringup(); > > > > > - /* > > > > > - * commit 4b0c0f294 (tick: Cleanup NOHZ per cpu data on cpu down) > > > > > - * clears certain data that the cpu_idle loop (which called us > > > > > - * and that we return from) expects. The only way to get that > > > > > - * data back is to call: > > > > > - */ > > > > > - tick_nohz_idle_enter(); > > > > > - tick_nohz_idle_stop_tick_protected(); > > > > > - cpuhp_online_idle(CPUHP_AP_ONLINE_IDLE); > > > > > + /* FIXME: converge cpu_bringup_and_idle() and start_secondary() */ > > > > > + cpu_bringup_and_idle(); > > > > > > > > I think this will leak stack memory. Multiple cpu offline/online cycles of > > > > the same cpu will finally exhaust the idle stack. > > > > Doh! Of course... > > > > I was actually thinking ahead, to where eventually xen_pv_play_dead() > > can call start_cpu0(), which can be changed to automatically reset the > > stack pointer like this: > > > > SYM_CODE_START(start_cpu0) > > ANNOTATE_NOENDBR > > UNWIND_HINT_EMPTY > > movq PER_CPU_VAR(pcpu_hot + X86_top_of_stack), %rax > > leaq -PTREGS_SIZE(%rax), %rsp > > jmp .Ljump_to_C_code > > SYM_CODE_END(start_cpu0) > > > > but that would only be possible be after more cleanups which converge > > cpu_bringup_and_idle() with start_secondary(). > > > > > The attached patch seems to work fine. > > > > The patch looks good to me. > > > > It doesn't solve Paul's original issue where arch_cpu_idle_dead() needs > > to be __noreturn. But that should probably be a separate patch anyway. > > Okay, I'll split this off. > > > > > > The __noreturn annotation seems to trigger an objtool warning, though, in > > > spite of the added BUG() at the end of xen_pv_play_dead(): > > > > > > arch/x86/xen/smp_pv.o: warning: objtool: xen_pv_play_dead() falls through to > > > next function xen_pv_cpu_die() > > > > You'll need to tell objtool that xen_cpu_bringup_again() is noreturn by > > adding "xen_cpu_bringup_again" to global_noreturns[] in > > tools/objtool/check.c. > > Ah, okay. Will do that. > > > (Yes it's a pain, I'll be working an improved solution to the noreturn > > thing...) > > Should be fairly easy, no? > > "Just" extend the __noreturn macro to put the function into a ".text.noreturn" > section, which can be handled in a special way by objtool. This would need > an __init_noreturn macro, of course, for a ".init.text.noreturn" section. And in last night's -next run, that diagnostic was gone! But of course another appeared in its place: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: check_relocations+0xd1: stack state mismatch: cfa1=4+32 cfa2=-1+0 The .config file is shown below. Thoughts? Thanx, Paul ------------------------------------------------------------------------ # # Automatically generated file; DO NOT EDIT. # Linux/x86 6.1.0-rc1 Kernel Configuration # CONFIG_CC_VERSION_TEXT="Ubuntu clang version 11.1.0-++20211011094159+1fdec59bffc1-1~exp1~20211011214622.5" CONFIG_GCC_VERSION=0 CONFIG_CC_IS_CLANG=y CONFIG_CLANG_VERSION=110100 CONFIG_AS_IS_LLVM=y CONFIG_AS_VERSION=110100 CONFIG_LD_IS_BFD=y CONFIG_LD_VERSION=23400 CONFIG_LLD_VERSION=0 CONFIG_CC_CAN_LINK=y CONFIG_CC_CAN_LINK_STATIC=y CONFIG_CC_HAS_ASM_GOTO_OUTPUT=y CONFIG_CC_HAS_ASM_INLINE=y CONFIG_PAHOLE_VERSION=0 CONFIG_IRQ_WORK=y CONFIG_BUILDTIME_TABLE_SORT=y CONFIG_THREAD_INFO_IN_TASK=y # # General setup # CONFIG_BROKEN_ON_SMP=y CONFIG_INIT_ENV_ARG_LIMIT=32 # CONFIG_COMPILE_TEST is not set CONFIG_WERROR=y CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y CONFIG_BUILD_SALT="" CONFIG_HAVE_KERNEL_GZIP=y CONFIG_HAVE_KERNEL_BZIP2=y CONFIG_HAVE_KERNEL_LZMA=y CONFIG_HAVE_KERNEL_XZ=y CONFIG_HAVE_KERNEL_LZO=y CONFIG_HAVE_KERNEL_LZ4=y CONFIG_HAVE_KERNEL_ZSTD=y CONFIG_KERNEL_GZIP=y # CONFIG_KERNEL_BZIP2 is not set # CONFIG_KERNEL_LZMA is not set # CONFIG_KERNEL_XZ is not set # CONFIG_KERNEL_LZO is not set # CONFIG_KERNEL_LZ4 is not set # CONFIG_KERNEL_ZSTD is not set CONFIG_DEFAULT_INIT="" CONFIG_DEFAULT_HOSTNAME="(none)" CONFIG_SYSVIPC=y CONFIG_SYSVIPC_SYSCTL=y CONFIG_SYSVIPC_COMPAT=y CONFIG_POSIX_MQUEUE=y CONFIG_POSIX_MQUEUE_SYSCTL=y # CONFIG_WATCH_QUEUE is not set CONFIG_CROSS_MEMORY_ATTACH=y # CONFIG_USELIB is not set CONFIG_AUDIT=y CONFIG_HAVE_ARCH_AUDITSYSCALL=y CONFIG_AUDITSYSCALL=y # # IRQ subsystem # CONFIG_GENERIC_IRQ_PROBE=y CONFIG_GENERIC_IRQ_SHOW=y CONFIG_HARDIRQS_SW_RESEND=y CONFIG_IRQ_DOMAIN=y CONFIG_IRQ_DOMAIN_HIERARCHY=y CONFIG_GENERIC_MSI_IRQ=y CONFIG_GENERIC_MSI_IRQ_DOMAIN=y CONFIG_IRQ_MSI_IOMMU=y CONFIG_GENERIC_IRQ_MATRIX_ALLOCATOR=y CONFIG_GENERIC_IRQ_RESERVATION_MODE=y CONFIG_IRQ_FORCED_THREADING=y CONFIG_SPARSE_IRQ=y # CONFIG_GENERIC_IRQ_DEBUGFS is not set # end of IRQ subsystem CONFIG_CLOCKSOURCE_WATCHDOG=y CONFIG_ARCH_CLOCKSOURCE_INIT=y CONFIG_CLOCKSOURCE_VALIDATE_LAST_CYCLE=y CONFIG_GENERIC_TIME_VSYSCALL=y CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST=y CONFIG_GENERIC_CMOS_UPDATE=y CONFIG_HAVE_POSIX_CPU_TIMERS_TASK_WORK=y CONFIG_POSIX_CPU_TIMERS_TASK_WORK=y # # Timers subsystem # CONFIG_TICK_ONESHOT=y CONFIG_NO_HZ_COMMON=y # CONFIG_HZ_PERIODIC is not set CONFIG_NO_HZ_IDLE=y CONFIG_NO_HZ=y CONFIG_HIGH_RES_TIMERS=y CONFIG_CLOCKSOURCE_WATCHDOG_MAX_SKEW_US=100 # end of Timers subsystem CONFIG_BPF=y CONFIG_HAVE_EBPF_JIT=y CONFIG_ARCH_WANT_DEFAULT_BPF_JIT=y # # BPF subsystem # # CONFIG_BPF_SYSCALL is not set # CONFIG_BPF_JIT is not set # end of BPF subsystem CONFIG_PREEMPT_NONE_BUILD=y CONFIG_PREEMPT_NONE=y # CONFIG_PREEMPT_VOLUNTARY is not set # CONFIG_PREEMPT is not set CONFIG_PREEMPT_COUNT=y # CONFIG_PREEMPT_DYNAMIC is not set # # CPU/Task time and stats accounting # CONFIG_TICK_CPU_ACCOUNTING=y # CONFIG_VIRT_CPU_ACCOUNTING_GEN is not set # CONFIG_IRQ_TIME_ACCOUNTING is not set CONFIG_BSD_PROCESS_ACCT=y # CONFIG_BSD_PROCESS_ACCT_V3 is not set CONFIG_TASKSTATS=y CONFIG_TASK_DELAY_ACCT=y CONFIG_TASK_XACCT=y CONFIG_TASK_IO_ACCOUNTING=y # CONFIG_PSI is not set # end of CPU/Task time and stats accounting # # RCU Subsystem # CONFIG_TINY_RCU=y # CONFIG_RCU_EXPERT is not set CONFIG_TINY_SRCU=y # end of RCU Subsystem # CONFIG_IKCONFIG is not set # CONFIG_IKHEADERS is not set CONFIG_LOG_BUF_SHIFT=18 CONFIG_PRINTK_SAFE_LOG_BUF_SHIFT=13 # CONFIG_PRINTK_INDEX is not set CONFIG_HAVE_UNSTABLE_SCHED_CLOCK=y # # Scheduler features # # end of Scheduler features CONFIG_ARCH_SUPPORTS_NUMA_BALANCING=y CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH=y CONFIG_CC_HAS_INT128=y CONFIG_GCC12_NO_ARRAY_BOUNDS=y CONFIG_ARCH_SUPPORTS_INT128=y CONFIG_CGROUPS=y CONFIG_PAGE_COUNTER=y # CONFIG_CGROUP_FAVOR_DYNMODS is not set # CONFIG_MEMCG is not set CONFIG_BLK_CGROUP=y CONFIG_CGROUP_SCHED=y CONFIG_FAIR_GROUP_SCHED=y # CONFIG_CFS_BANDWIDTH is not set # CONFIG_RT_GROUP_SCHED is not set CONFIG_CGROUP_PIDS=y CONFIG_CGROUP_RDMA=y CONFIG_CGROUP_FREEZER=y CONFIG_CGROUP_HUGETLB=y CONFIG_CGROUP_DEVICE=y CONFIG_CGROUP_CPUACCT=y CONFIG_CGROUP_PERF=y CONFIG_CGROUP_MISC=y CONFIG_CGROUP_DEBUG=y CONFIG_SOCK_CGROUP_DATA=y CONFIG_NAMESPACES=y CONFIG_UTS_NS=y CONFIG_TIME_NS=y CONFIG_IPC_NS=y # CONFIG_USER_NS is not set CONFIG_PID_NS=y CONFIG_NET_NS=y # CONFIG_CHECKPOINT_RESTORE is not set # CONFIG_SCHED_AUTOGROUP is not set # CONFIG_SYSFS_DEPRECATED is not set CONFIG_RELAY=y CONFIG_BLK_DEV_INITRD=y CONFIG_INITRAMFS_SOURCE="/home/git/linux-build/tools/testing/selftests/rcutorture/initrd" CONFIG_INITRAMFS_ROOT_UID=0 CONFIG_INITRAMFS_ROOT_GID=0 CONFIG_RD_GZIP=y CONFIG_RD_BZIP2=y CONFIG_RD_LZMA=y CONFIG_RD_XZ=y CONFIG_RD_LZO=y CONFIG_RD_LZ4=y CONFIG_RD_ZSTD=y CONFIG_INITRAMFS_COMPRESSION_GZIP=y # CONFIG_INITRAMFS_COMPRESSION_BZIP2 is not set # CONFIG_INITRAMFS_COMPRESSION_LZMA is not set # CONFIG_INITRAMFS_COMPRESSION_XZ is not set # CONFIG_INITRAMFS_COMPRESSION_LZO is not set # CONFIG_INITRAMFS_COMPRESSION_LZ4 is not set # CONFIG_INITRAMFS_COMPRESSION_ZSTD is not set # CONFIG_INITRAMFS_COMPRESSION_NONE is not set # CONFIG_BOOT_CONFIG is not set CONFIG_INITRAMFS_PRESERVE_MTIME=y CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE=y # CONFIG_CC_OPTIMIZE_FOR_SIZE is not set CONFIG_LD_ORPHAN_WARN=y CONFIG_SYSCTL=y CONFIG_HAVE_UID16=y CONFIG_SYSCTL_EXCEPTION_TRACE=y CONFIG_HAVE_PCSPKR_PLATFORM=y # CONFIG_EXPERT is not set CONFIG_UID16=y CONFIG_MULTIUSER=y CONFIG_SGETMASK_SYSCALL=y CONFIG_SYSFS_SYSCALL=y CONFIG_FHANDLE=y CONFIG_POSIX_TIMERS=y CONFIG_PRINTK=y CONFIG_BUG=y CONFIG_ELF_CORE=y CONFIG_PCSPKR_PLATFORM=y CONFIG_BASE_FULL=y CONFIG_FUTEX=y CONFIG_FUTEX_PI=y CONFIG_EPOLL=y CONFIG_SIGNALFD=y CONFIG_TIMERFD=y CONFIG_EVENTFD=y CONFIG_SHMEM=y CONFIG_AIO=y CONFIG_IO_URING=y CONFIG_ADVISE_SYSCALLS=y CONFIG_MEMBARRIER=y CONFIG_KALLSYMS=y CONFIG_KALLSYMS_ALL=y CONFIG_KALLSYMS_BASE_RELATIVE=y CONFIG_ARCH_HAS_MEMBARRIER_SYNC_CORE=y CONFIG_KCMP=y CONFIG_RSEQ=y # CONFIG_EMBEDDED is not set CONFIG_HAVE_PERF_EVENTS=y # # Kernel Performance Events And Counters # CONFIG_PERF_EVENTS=y # CONFIG_DEBUG_PERF_USE_VMALLOC is not set # end of Kernel Performance Events And Counters CONFIG_SYSTEM_DATA_VERIFICATION=y CONFIG_PROFILING=y CONFIG_TRACEPOINTS=y # end of General setup CONFIG_64BIT=y CONFIG_X86_64=y CONFIG_X86=y CONFIG_INSTRUCTION_DECODER=y CONFIG_OUTPUT_FORMAT="elf64-x86-64" CONFIG_LOCKDEP_SUPPORT=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_MMU=y CONFIG_ARCH_MMAP_RND_BITS_MIN=28 CONFIG_ARCH_MMAP_RND_BITS_MAX=32 CONFIG_ARCH_MMAP_RND_COMPAT_BITS_MIN=8 CONFIG_ARCH_MMAP_RND_COMPAT_BITS_MAX=16 CONFIG_GENERIC_ISA_DMA=y CONFIG_GENERIC_BUG=y CONFIG_GENERIC_BUG_RELATIVE_POINTERS=y CONFIG_ARCH_MAY_HAVE_PC_FDC=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_ARCH_HAS_CPU_RELAX=y CONFIG_ARCH_HIBERNATION_POSSIBLE=y CONFIG_ARCH_NR_GPIO=1024 CONFIG_ARCH_SUSPEND_POSSIBLE=y CONFIG_AUDIT_ARCH=y CONFIG_HAVE_INTEL_TXT=y CONFIG_ARCH_SUPPORTS_UPROBES=y CONFIG_FIX_EARLYCON_MEM=y CONFIG_PGTABLE_LEVELS=5 CONFIG_CC_HAS_SANE_STACKPROTECTOR=y # # Processor type and features # # CONFIG_SMP is not set CONFIG_X86_FEATURE_NAMES=y # CONFIG_X86_X2APIC is not set CONFIG_X86_MPPARSE=y # CONFIG_GOLDFISH is not set # CONFIG_X86_CPU_RESCTRL is not set CONFIG_X86_EXTENDED_PLATFORM=y # CONFIG_X86_GOLDFISH is not set # CONFIG_X86_INTEL_MID is not set # CONFIG_X86_INTEL_LPSS is not set # CONFIG_X86_AMD_PLATFORM_DEVICE is not set CONFIG_IOSF_MBI=y # CONFIG_IOSF_MBI_DEBUG is not set CONFIG_X86_SUPPORTS_MEMORY_FAILURE=y CONFIG_SCHED_OMIT_FRAME_POINTER=y CONFIG_HYPERVISOR_GUEST=y CONFIG_PARAVIRT=y # CONFIG_PARAVIRT_DEBUG is not set CONFIG_X86_HV_CALLBACK_VECTOR=y # CONFIG_XEN is not set CONFIG_KVM_GUEST=y CONFIG_ARCH_CPUIDLE_HALTPOLL=y # CONFIG_PVH is not set # CONFIG_PARAVIRT_TIME_ACCOUNTING is not set CONFIG_PARAVIRT_CLOCK=y # CONFIG_JAILHOUSE_GUEST is not set # CONFIG_ACRN_GUEST is not set # CONFIG_MK8 is not set # CONFIG_MPSC is not set # CONFIG_MCORE2 is not set # CONFIG_MATOM is not set CONFIG_GENERIC_CPU=y CONFIG_X86_INTERNODE_CACHE_SHIFT=6 CONFIG_X86_L1_CACHE_SHIFT=6 CONFIG_X86_TSC=y CONFIG_X86_CMPXCHG64=y CONFIG_X86_CMOV=y CONFIG_X86_MINIMUM_CPU_FAMILY=64 CONFIG_X86_DEBUGCTLMSR=y CONFIG_IA32_FEAT_CTL=y CONFIG_X86_VMX_FEATURE_NAMES=y CONFIG_CPU_SUP_INTEL=y CONFIG_CPU_SUP_AMD=y CONFIG_CPU_SUP_HYGON=y CONFIG_CPU_SUP_CENTAUR=y CONFIG_CPU_SUP_ZHAOXIN=y CONFIG_HPET_TIMER=y CONFIG_HPET_EMULATE_RTC=y CONFIG_DMI=y # CONFIG_GART_IOMMU is not set CONFIG_NR_CPUS_RANGE_BEGIN=1 CONFIG_NR_CPUS_RANGE_END=1 CONFIG_NR_CPUS_DEFAULT=1 CONFIG_NR_CPUS=1 CONFIG_UP_LATE_INIT=y CONFIG_X86_LOCAL_APIC=y CONFIG_X86_IO_APIC=y CONFIG_X86_REROUTE_FOR_BROKEN_BOOT_IRQS=y CONFIG_X86_MCE=y # CONFIG_X86_MCELOG_LEGACY is not set CONFIG_X86_MCE_INTEL=y CONFIG_X86_MCE_AMD=y CONFIG_X86_MCE_THRESHOLD=y # CONFIG_X86_MCE_INJECT is not set # # Performance monitoring # CONFIG_PERF_EVENTS_INTEL_UNCORE=y CONFIG_PERF_EVENTS_INTEL_RAPL=y CONFIG_PERF_EVENTS_INTEL_CSTATE=y # CONFIG_PERF_EVENTS_AMD_POWER is not set CONFIG_PERF_EVENTS_AMD_UNCORE=y # CONFIG_PERF_EVENTS_AMD_BRS is not set # end of Performance monitoring CONFIG_X86_16BIT=y CONFIG_X86_ESPFIX64=y CONFIG_X86_VSYSCALL_EMULATION=y CONFIG_X86_IOPL_IOPERM=y CONFIG_MICROCODE=y CONFIG_MICROCODE_INTEL=y CONFIG_MICROCODE_AMD=y # CONFIG_MICROCODE_LATE_LOADING is not set CONFIG_X86_MSR=y CONFIG_X86_CPUID=y CONFIG_X86_5LEVEL=y CONFIG_X86_DIRECT_GBPAGES=y # CONFIG_X86_CPA_STATISTICS is not set # CONFIG_AMD_MEM_ENCRYPT is not set CONFIG_ARCH_SPARSEMEM_ENABLE=y CONFIG_ARCH_SPARSEMEM_DEFAULT=y CONFIG_ARCH_PROC_KCORE_TEXT=y CONFIG_ILLEGAL_POINTER_VALUE=0xdead000000000000 # CONFIG_X86_PMEM_LEGACY is not set CONFIG_X86_CHECK_BIOS_CORRUPTION=y CONFIG_X86_BOOTPARAM_MEMORY_CORRUPTION_CHECK=y CONFIG_MTRR=y # CONFIG_MTRR_SANITIZER is not set CONFIG_X86_PAT=y CONFIG_ARCH_USES_PG_UNCACHED=y CONFIG_X86_UMIP=y CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS=y CONFIG_X86_INTEL_TSX_MODE_OFF=y # CONFIG_X86_INTEL_TSX_MODE_ON is not set # CONFIG_X86_INTEL_TSX_MODE_AUTO is not set CONFIG_EFI=y CONFIG_EFI_STUB=y CONFIG_EFI_MIXED=y # CONFIG_HZ_100 is not set # CONFIG_HZ_250 is not set # CONFIG_HZ_300 is not set CONFIG_HZ_1000=y CONFIG_HZ=1000 CONFIG_SCHED_HRTICK=y CONFIG_KEXEC=y # CONFIG_KEXEC_FILE is not set CONFIG_CRASH_DUMP=y # CONFIG_KEXEC_JUMP is not set CONFIG_PHYSICAL_START=0x1000000 CONFIG_RELOCATABLE=y CONFIG_RANDOMIZE_BASE=y CONFIG_X86_NEED_RELOCS=y CONFIG_PHYSICAL_ALIGN=0x200000 CONFIG_DYNAMIC_MEMORY_LAYOUT=y CONFIG_RANDOMIZE_MEMORY=y CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING=0x0 # CONFIG_COMPAT_VDSO is not set CONFIG_LEGACY_VSYSCALL_XONLY=y # CONFIG_LEGACY_VSYSCALL_NONE is not set # CONFIG_CMDLINE_BOOL is not set CONFIG_MODIFY_LDT_SYSCALL=y # CONFIG_STRICT_SIGALTSTACK_SIZE is not set CONFIG_HAVE_LIVEPATCH=y # end of Processor type and features CONFIG_SPECULATION_MITIGATIONS=y CONFIG_PAGE_TABLE_ISOLATION=y CONFIG_RETPOLINE=y CONFIG_CPU_IBPB_ENTRY=y CONFIG_CPU_IBRS_ENTRY=y CONFIG_ARCH_HAS_ADD_PAGES=y CONFIG_ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE=y # # Power management and ACPI options # CONFIG_ARCH_HIBERNATION_HEADER=y CONFIG_SUSPEND=y CONFIG_SUSPEND_FREEZER=y CONFIG_HIBERNATE_CALLBACKS=y CONFIG_HIBERNATION=y CONFIG_HIBERNATION_SNAPSHOT_DEV=y CONFIG_PM_STD_PARTITION="" CONFIG_PM_SLEEP=y # CONFIG_PM_AUTOSLEEP is not set # CONFIG_PM_USERSPACE_AUTOSLEEP is not set # CONFIG_PM_WAKELOCKS is not set CONFIG_PM=y CONFIG_PM_DEBUG=y # CONFIG_PM_ADVANCED_DEBUG is not set # CONFIG_PM_TEST_SUSPEND is not set CONFIG_PM_SLEEP_DEBUG=y CONFIG_PM_TRACE=y CONFIG_PM_TRACE_RTC=y # CONFIG_WQ_POWER_EFFICIENT_DEFAULT is not set CONFIG_ARCH_SUPPORTS_ACPI=y CONFIG_ACPI=y CONFIG_ACPI_LEGACY_TABLES_LOOKUP=y CONFIG_ARCH_MIGHT_HAVE_ACPI_PDC=y CONFIG_ACPI_SYSTEM_POWER_STATES_SUPPORT=y # CONFIG_ACPI_DEBUGGER is not set CONFIG_ACPI_SPCR_TABLE=y # CONFIG_ACPI_FPDT is not set CONFIG_ACPI_LPIT=y CONFIG_ACPI_SLEEP=y CONFIG_ACPI_REV_OVERRIDE_POSSIBLE=y # CONFIG_ACPI_EC_DEBUGFS is not set CONFIG_ACPI_AC=y CONFIG_ACPI_BATTERY=y CONFIG_ACPI_BUTTON=y CONFIG_ACPI_VIDEO=y CONFIG_ACPI_FAN=y # CONFIG_ACPI_TAD is not set CONFIG_ACPI_DOCK=y CONFIG_ACPI_CPU_FREQ_PSS=y CONFIG_ACPI_PROCESSOR_CSTATE=y CONFIG_ACPI_PROCESSOR_IDLE=y CONFIG_ACPI_PROCESSOR=y # CONFIG_ACPI_PROCESSOR_AGGREGATOR is not set CONFIG_ACPI_THERMAL=y CONFIG_ARCH_HAS_ACPI_TABLE_UPGRADE=y CONFIG_ACPI_TABLE_UPGRADE=y # CONFIG_ACPI_DEBUG is not set # CONFIG_ACPI_PCI_SLOT is not set CONFIG_ACPI_CONTAINER=y CONFIG_ACPI_HOTPLUG_IOAPIC=y # CONFIG_ACPI_SBS is not set # CONFIG_ACPI_HED is not set # CONFIG_ACPI_CUSTOM_METHOD is not set CONFIG_ACPI_BGRT=y # CONFIG_ACPI_NFIT is not set CONFIG_HAVE_ACPI_APEI=y CONFIG_HAVE_ACPI_APEI_NMI=y # CONFIG_ACPI_APEI is not set # CONFIG_ACPI_DPTF is not set # CONFIG_ACPI_CONFIGFS is not set # CONFIG_ACPI_PFRUT is not set CONFIG_ACPI_PCC=y # CONFIG_PMIC_OPREGION is not set CONFIG_ACPI_PRMT=y CONFIG_X86_PM_TIMER=y # # CPU Frequency scaling # CONFIG_CPU_FREQ=y CONFIG_CPU_FREQ_GOV_ATTR_SET=y CONFIG_CPU_FREQ_GOV_COMMON=y # CONFIG_CPU_FREQ_STAT is not set # CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE is not set # CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE is not set CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE=y # CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND is not set # CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE is not set CONFIG_CPU_FREQ_GOV_PERFORMANCE=y # CONFIG_CPU_FREQ_GOV_POWERSAVE is not set CONFIG_CPU_FREQ_GOV_USERSPACE=y CONFIG_CPU_FREQ_GOV_ONDEMAND=y # CONFIG_CPU_FREQ_GOV_CONSERVATIVE is not set # # CPU frequency scaling drivers # CONFIG_X86_INTEL_PSTATE=y # CONFIG_X86_PCC_CPUFREQ is not set # CONFIG_X86_AMD_PSTATE is not set # CONFIG_X86_AMD_PSTATE_UT is not set CONFIG_X86_ACPI_CPUFREQ=y CONFIG_X86_ACPI_CPUFREQ_CPB=y # CONFIG_X86_POWERNOW_K8 is not set # CONFIG_X86_AMD_FREQ_SENSITIVITY is not set # CONFIG_X86_SPEEDSTEP_CENTRINO is not set # CONFIG_X86_P4_CLOCKMOD is not set # # shared options # # end of CPU Frequency scaling # # CPU Idle # CONFIG_CPU_IDLE=y # CONFIG_CPU_IDLE_GOV_LADDER is not set CONFIG_CPU_IDLE_GOV_MENU=y # CONFIG_CPU_IDLE_GOV_TEO is not set # CONFIG_CPU_IDLE_GOV_HALTPOLL is not set CONFIG_HALTPOLL_CPUIDLE=y # end of CPU Idle # CONFIG_INTEL_IDLE is not set # end of Power management and ACPI options # # Bus options (PCI etc.) # CONFIG_PCI_DIRECT=y CONFIG_PCI_MMCONFIG=y CONFIG_MMCONF_FAM10H=y CONFIG_ISA_DMA_API=y CONFIG_AMD_NB=y # end of Bus options (PCI etc.) # # Binary Emulations # CONFIG_IA32_EMULATION=y # CONFIG_X86_X32_ABI is not set CONFIG_COMPAT_32=y CONFIG_COMPAT=y CONFIG_COMPAT_FOR_U64_ALIGNMENT=y # end of Binary Emulations CONFIG_HAVE_KVM=y CONFIG_VIRTUALIZATION=y # CONFIG_KVM is not set CONFIG_AS_AVX512=y CONFIG_AS_SHA1_NI=y CONFIG_AS_SHA256_NI=y CONFIG_AS_TPAUSE=y # # General architecture-dependent options # CONFIG_CRASH_CORE=y CONFIG_KEXEC_CORE=y CONFIG_GENERIC_ENTRY=y CONFIG_KPROBES=y CONFIG_JUMP_LABEL=y # CONFIG_STATIC_KEYS_SELFTEST is not set # CONFIG_STATIC_CALL_SELFTEST is not set CONFIG_OPTPROBES=y CONFIG_UPROBES=y CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y CONFIG_ARCH_USE_BUILTIN_BSWAP=y CONFIG_KRETPROBES=y CONFIG_KRETPROBE_ON_RETHOOK=y CONFIG_HAVE_IOREMAP_PROT=y CONFIG_HAVE_KPROBES=y CONFIG_HAVE_KRETPROBES=y CONFIG_HAVE_OPTPROBES=y CONFIG_HAVE_KPROBES_ON_FTRACE=y CONFIG_ARCH_CORRECT_STACKTRACE_ON_KRETPROBE=y CONFIG_HAVE_FUNCTION_ERROR_INJECTION=y CONFIG_HAVE_NMI=y CONFIG_TRACE_IRQFLAGS_SUPPORT=y CONFIG_TRACE_IRQFLAGS_NMI_SUPPORT=y CONFIG_HAVE_ARCH_TRACEHOOK=y CONFIG_HAVE_DMA_CONTIGUOUS=y CONFIG_GENERIC_SMP_IDLE_THREAD=y CONFIG_ARCH_HAS_FORTIFY_SOURCE=y CONFIG_ARCH_HAS_SET_MEMORY=y CONFIG_ARCH_HAS_SET_DIRECT_MAP=y CONFIG_HAVE_ARCH_THREAD_STRUCT_WHITELIST=y CONFIG_ARCH_WANTS_DYNAMIC_TASK_STRUCT=y CONFIG_ARCH_WANTS_NO_INSTR=y CONFIG_HAVE_ASM_MODVERSIONS=y CONFIG_HAVE_REGS_AND_STACK_ACCESS_API=y CONFIG_HAVE_RSEQ=y CONFIG_HAVE_RUST=y CONFIG_HAVE_FUNCTION_ARG_ACCESS_API=y CONFIG_HAVE_HW_BREAKPOINT=y CONFIG_HAVE_MIXED_BREAKPOINTS_REGS=y CONFIG_HAVE_USER_RETURN_NOTIFIER=y CONFIG_HAVE_PERF_EVENTS_NMI=y CONFIG_HAVE_HARDLOCKUP_DETECTOR_PERF=y CONFIG_HAVE_PERF_REGS=y CONFIG_HAVE_PERF_USER_STACK_DUMP=y CONFIG_HAVE_ARCH_JUMP_LABEL=y CONFIG_HAVE_ARCH_JUMP_LABEL_RELATIVE=y CONFIG_MMU_GATHER_TABLE_FREE=y CONFIG_MMU_GATHER_RCU_TABLE_FREE=y CONFIG_MMU_GATHER_MERGE_VMAS=y CONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG=y CONFIG_ARCH_HAS_NMI_SAFE_THIS_CPU_OPS=y CONFIG_HAVE_ALIGNED_STRUCT_PAGE=y CONFIG_HAVE_CMPXCHG_LOCAL=y CONFIG_HAVE_CMPXCHG_DOUBLE=y CONFIG_ARCH_WANT_COMPAT_IPC_PARSE_VERSION=y CONFIG_ARCH_WANT_OLD_COMPAT_IPC=y CONFIG_HAVE_ARCH_SECCOMP=y CONFIG_HAVE_ARCH_SECCOMP_FILTER=y CONFIG_SECCOMP=y CONFIG_SECCOMP_FILTER=y # CONFIG_SECCOMP_CACHE_DEBUG is not set CONFIG_HAVE_ARCH_STACKLEAK=y CONFIG_HAVE_STACKPROTECTOR=y CONFIG_STACKPROTECTOR=y CONFIG_STACKPROTECTOR_STRONG=y CONFIG_ARCH_SUPPORTS_LTO_CLANG=y CONFIG_ARCH_SUPPORTS_LTO_CLANG_THIN=y CONFIG_LTO_NONE=y CONFIG_ARCH_SUPPORTS_CFI_CLANG=y CONFIG_HAVE_ARCH_WITHIN_STACK_FRAMES=y CONFIG_HAVE_CONTEXT_TRACKING_USER=y CONFIG_HAVE_CONTEXT_TRACKING_USER_OFFSTACK=y CONFIG_HAVE_VIRT_CPU_ACCOUNTING_GEN=y CONFIG_HAVE_IRQ_TIME_ACCOUNTING=y CONFIG_HAVE_MOVE_PUD=y CONFIG_HAVE_MOVE_PMD=y CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE=y CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD=y CONFIG_HAVE_ARCH_HUGE_VMAP=y CONFIG_HAVE_ARCH_HUGE_VMALLOC=y CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y CONFIG_HAVE_ARCH_SOFT_DIRTY=y CONFIG_HAVE_MOD_ARCH_SPECIFIC=y CONFIG_MODULES_USE_ELF_RELA=y CONFIG_HAVE_IRQ_EXIT_ON_IRQ_STACK=y CONFIG_HAVE_SOFTIRQ_ON_OWN_STACK=y CONFIG_SOFTIRQ_ON_OWN_STACK=y CONFIG_ARCH_HAS_ELF_RANDOMIZE=y CONFIG_HAVE_ARCH_MMAP_RND_BITS=y CONFIG_HAVE_EXIT_THREAD=y CONFIG_ARCH_MMAP_RND_BITS=28 CONFIG_HAVE_ARCH_MMAP_RND_COMPAT_BITS=y CONFIG_ARCH_MMAP_RND_COMPAT_BITS=8 CONFIG_HAVE_ARCH_COMPAT_MMAP_BASES=y CONFIG_PAGE_SIZE_LESS_THAN_64KB=y CONFIG_PAGE_SIZE_LESS_THAN_256KB=y CONFIG_HAVE_OBJTOOL=y CONFIG_HAVE_JUMP_LABEL_HACK=y CONFIG_HAVE_NOINSTR_HACK=y CONFIG_HAVE_NOINSTR_VALIDATION=y CONFIG_HAVE_UACCESS_VALIDATION=y CONFIG_HAVE_STACK_VALIDATION=y CONFIG_HAVE_RELIABLE_STACKTRACE=y CONFIG_OLD_SIGSUSPEND3=y CONFIG_COMPAT_OLD_SIGACTION=y CONFIG_COMPAT_32BIT_TIME=y CONFIG_HAVE_ARCH_VMAP_STACK=y CONFIG_VMAP_STACK=y CONFIG_HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET=y CONFIG_ARCH_HAS_STRICT_KERNEL_RWX=y CONFIG_STRICT_KERNEL_RWX=y CONFIG_ARCH_HAS_STRICT_MODULE_RWX=y CONFIG_STRICT_MODULE_RWX=y CONFIG_HAVE_ARCH_PREL32_RELOCATIONS=y CONFIG_ARCH_USE_MEMREMAP_PROT=y # CONFIG_LOCK_EVENT_COUNTS is not set CONFIG_ARCH_HAS_MEM_ENCRYPT=y CONFIG_HAVE_STATIC_CALL=y CONFIG_HAVE_STATIC_CALL_INLINE=y CONFIG_HAVE_PREEMPT_DYNAMIC=y CONFIG_HAVE_PREEMPT_DYNAMIC_CALL=y CONFIG_ARCH_WANT_LD_ORPHAN_WARN=y CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y CONFIG_ARCH_SUPPORTS_PAGE_TABLE_CHECK=y CONFIG_ARCH_HAS_ELFCORE_COMPAT=y CONFIG_ARCH_HAS_PARANOID_L1D_FLUSH=y CONFIG_DYNAMIC_SIGFRAME=y CONFIG_ARCH_HAS_NONLEAF_PMD_YOUNG=y # # GCOV-based kernel profiling # CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y # end of GCOV-based kernel profiling CONFIG_HAVE_GCC_PLUGINS=y # end of General architecture-dependent options CONFIG_RT_MUTEXES=y CONFIG_BASE_SMALL=0 CONFIG_MODULES=y # CONFIG_MODULE_FORCE_LOAD is not set CONFIG_MODULE_UNLOAD=y CONFIG_MODULE_FORCE_UNLOAD=y # CONFIG_MODULE_UNLOAD_TAINT_TRACKING is not set # CONFIG_MODVERSIONS is not set # CONFIG_MODULE_SRCVERSION_ALL is not set # CONFIG_MODULE_SIG is not set CONFIG_MODULE_COMPRESS_NONE=y # CONFIG_MODULE_COMPRESS_GZIP is not set # CONFIG_MODULE_COMPRESS_XZ is not set # CONFIG_MODULE_COMPRESS_ZSTD is not set # CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS is not set CONFIG_MODPROBE_PATH="/sbin/modprobe" CONFIG_MODULES_TREE_LOOKUP=y CONFIG_BLOCK=y CONFIG_BLOCK_LEGACY_AUTOLOAD=y CONFIG_BLK_RQ_ALLOC_TIME=y CONFIG_BLK_DEV_BSG_COMMON=y # CONFIG_BLK_DEV_BSGLIB is not set # CONFIG_BLK_DEV_INTEGRITY is not set # CONFIG_BLK_DEV_ZONED is not set # CONFIG_BLK_DEV_THROTTLING is not set # CONFIG_BLK_WBT is not set CONFIG_BLK_CGROUP_IOLATENCY=y CONFIG_BLK_CGROUP_IOCOST=y CONFIG_BLK_CGROUP_IOPRIO=y CONFIG_BLK_DEBUG_FS=y # CONFIG_BLK_SED_OPAL is not set # CONFIG_BLK_INLINE_ENCRYPTION is not set # # Partition Types # # CONFIG_PARTITION_ADVANCED is not set CONFIG_MSDOS_PARTITION=y CONFIG_EFI_PARTITION=y # end of Partition Types CONFIG_BLOCK_COMPAT=y CONFIG_BLK_MQ_PCI=y CONFIG_BLK_MQ_VIRTIO=y CONFIG_BLK_PM=y CONFIG_BLOCK_HOLDER_DEPRECATED=y CONFIG_BLK_MQ_STACKING=y # # IO Schedulers # CONFIG_MQ_IOSCHED_DEADLINE=y CONFIG_MQ_IOSCHED_KYBER=y # CONFIG_IOSCHED_BFQ is not set # end of IO Schedulers CONFIG_ASN1=y CONFIG_UNINLINE_SPIN_UNLOCK=y CONFIG_ARCH_SUPPORTS_ATOMIC_RMW=y CONFIG_ARCH_USE_QUEUED_SPINLOCKS=y CONFIG_ARCH_USE_QUEUED_RWLOCKS=y CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE=y CONFIG_ARCH_HAS_SYNC_CORE_BEFORE_USERMODE=y CONFIG_ARCH_HAS_SYSCALL_WRAPPER=y CONFIG_FREEZER=y # # Executable file formats # CONFIG_BINFMT_ELF=y CONFIG_COMPAT_BINFMT_ELF=y CONFIG_ELFCORE=y CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS=y CONFIG_BINFMT_SCRIPT=y CONFIG_BINFMT_MISC=y CONFIG_COREDUMP=y # end of Executable file formats # # Memory Management options # CONFIG_SWAP=y # CONFIG_ZSWAP is not set # # SLAB allocator options # # CONFIG_SLAB is not set CONFIG_SLUB=y CONFIG_SLAB_MERGE_DEFAULT=y # CONFIG_SLAB_FREELIST_RANDOM is not set # CONFIG_SLAB_FREELIST_HARDENED is not set # CONFIG_SLUB_STATS is not set # end of SLAB allocator options # CONFIG_SHUFFLE_PAGE_ALLOCATOR is not set # CONFIG_COMPAT_BRK is not set CONFIG_SPARSEMEM=y CONFIG_SPARSEMEM_EXTREME=y CONFIG_SPARSEMEM_VMEMMAP_ENABLE=y CONFIG_SPARSEMEM_VMEMMAP=y CONFIG_HAVE_FAST_GUP=y CONFIG_EXCLUSIVE_SYSTEM_RAM=y CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=y # CONFIG_MEMORY_HOTPLUG is not set CONFIG_SPLIT_PTLOCK_CPUS=4 CONFIG_ARCH_ENABLE_SPLIT_PMD_PTLOCK=y CONFIG_COMPACTION=y CONFIG_COMPACT_UNEVICTABLE_DEFAULT=1 # CONFIG_PAGE_REPORTING is not set CONFIG_MIGRATION=y CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION=y CONFIG_PHYS_ADDR_T_64BIT=y CONFIG_MMU_NOTIFIER=y # CONFIG_KSM is not set CONFIG_DEFAULT_MMAP_MIN_ADDR=4096 CONFIG_ARCH_SUPPORTS_MEMORY_FAILURE=y # CONFIG_MEMORY_FAILURE is not set CONFIG_ARCH_WANT_GENERAL_HUGETLB=y CONFIG_ARCH_WANTS_THP_SWAP=y # CONFIG_TRANSPARENT_HUGEPAGE is not set CONFIG_NEED_PER_CPU_KM=y CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y CONFIG_HAVE_SETUP_PER_CPU_AREA=y # CONFIG_CMA is not set CONFIG_GENERIC_EARLY_IOREMAP=y # CONFIG_IDLE_PAGE_TRACKING is not set CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y CONFIG_ARCH_HAS_CURRENT_STACK_POINTER=y CONFIG_ARCH_HAS_PTE_DEVMAP=y CONFIG_ZONE_DMA=y CONFIG_ZONE_DMA32=y CONFIG_VMAP_PFN=y CONFIG_ARCH_USES_HIGH_VMA_FLAGS=y CONFIG_ARCH_HAS_PKEYS=y CONFIG_VM_EVENT_COUNTERS=y # CONFIG_PERCPU_STATS is not set # CONFIG_GUP_TEST is not set CONFIG_ARCH_HAS_PTE_SPECIAL=y CONFIG_SECRETMEM=y # CONFIG_ANON_VMA_NAME is not set # CONFIG_USERFAULTFD is not set # CONFIG_LRU_GEN is not set # # Data Access Monitoring # # CONFIG_DAMON is not set # end of Data Access Monitoring # end of Memory Management options CONFIG_NET=y CONFIG_NET_INGRESS=y CONFIG_NET_EGRESS=y CONFIG_SKB_EXTENSIONS=y # # Networking options # CONFIG_PACKET=y # CONFIG_PACKET_DIAG is not set CONFIG_UNIX=y CONFIG_UNIX_SCM=y CONFIG_AF_UNIX_OOB=y # CONFIG_UNIX_DIAG is not set # CONFIG_TLS is not set CONFIG_XFRM=y CONFIG_XFRM_ALGO=y CONFIG_XFRM_USER=y # CONFIG_XFRM_USER_COMPAT is not set # CONFIG_XFRM_INTERFACE is not set # CONFIG_XFRM_SUB_POLICY is not set # CONFIG_XFRM_MIGRATE is not set # CONFIG_XFRM_STATISTICS is not set CONFIG_XFRM_AH=y CONFIG_XFRM_ESP=y # CONFIG_NET_KEY is not set CONFIG_INET=y CONFIG_IP_MULTICAST=y CONFIG_IP_ADVANCED_ROUTER=y # CONFIG_IP_FIB_TRIE_STATS is not set CONFIG_IP_MULTIPLE_TABLES=y CONFIG_IP_ROUTE_MULTIPATH=y CONFIG_IP_ROUTE_VERBOSE=y CONFIG_IP_PNP=y CONFIG_IP_PNP_DHCP=y CONFIG_IP_PNP_BOOTP=y CONFIG_IP_PNP_RARP=y # CONFIG_NET_IPIP is not set # CONFIG_NET_IPGRE_DEMUX is not set CONFIG_NET_IP_TUNNEL=y CONFIG_IP_MROUTE_COMMON=y CONFIG_IP_MROUTE=y # CONFIG_IP_MROUTE_MULTIPLE_TABLES is not set CONFIG_IP_PIMSM_V1=y CONFIG_IP_PIMSM_V2=y CONFIG_SYN_COOKIES=y # CONFIG_NET_IPVTI is not set # CONFIG_NET_FOU is not set # CONFIG_NET_FOU_IP_TUNNELS is not set # CONFIG_INET_AH is not set # CONFIG_INET_ESP is not set # CONFIG_INET_IPCOMP is not set CONFIG_INET_TUNNEL=y # CONFIG_INET_DIAG is not set CONFIG_TCP_CONG_ADVANCED=y # CONFIG_TCP_CONG_BIC is not set CONFIG_TCP_CONG_CUBIC=y # CONFIG_TCP_CONG_WESTWOOD is not set # CONFIG_TCP_CONG_HTCP is not set # CONFIG_TCP_CONG_HSTCP is not set # CONFIG_TCP_CONG_HYBLA is not set # CONFIG_TCP_CONG_VEGAS is not set # CONFIG_TCP_CONG_NV is not set # CONFIG_TCP_CONG_SCALABLE is not set # CONFIG_TCP_CONG_LP is not set # CONFIG_TCP_CONG_VENO is not set # CONFIG_TCP_CONG_YEAH is not set # CONFIG_TCP_CONG_ILLINOIS is not set # CONFIG_TCP_CONG_DCTCP is not set # CONFIG_TCP_CONG_CDG is not set # CONFIG_TCP_CONG_BBR is not set CONFIG_DEFAULT_CUBIC=y # CONFIG_DEFAULT_RENO is not set CONFIG_DEFAULT_TCP_CONG="cubic" CONFIG_TCP_MD5SIG=y CONFIG_IPV6=y # CONFIG_IPV6_ROUTER_PREF is not set # CONFIG_IPV6_OPTIMISTIC_DAD is not set CONFIG_INET6_AH=y CONFIG_INET6_ESP=y # CONFIG_INET6_ESP_OFFLOAD is not set # CONFIG_INET6_ESPINTCP is not set # CONFIG_INET6_IPCOMP is not set # CONFIG_IPV6_MIP6 is not set # CONFIG_IPV6_ILA is not set # CONFIG_IPV6_VTI is not set CONFIG_IPV6_SIT=y # CONFIG_IPV6_SIT_6RD is not set CONFIG_IPV6_NDISC_NODETYPE=y # CONFIG_IPV6_TUNNEL is not set # CONFIG_IPV6_MULTIPLE_TABLES is not set # CONFIG_IPV6_MROUTE is not set # CONFIG_IPV6_SEG6_LWTUNNEL is not set # CONFIG_IPV6_SEG6_HMAC is not set # CONFIG_IPV6_RPL_LWTUNNEL is not set # CONFIG_IPV6_IOAM6_LWTUNNEL is not set CONFIG_NETLABEL=y # CONFIG_MPTCP is not set CONFIG_NETWORK_SECMARK=y CONFIG_NET_PTP_CLASSIFY=y # CONFIG_NETWORK_PHY_TIMESTAMPING is not set CONFIG_NETFILTER=y # CONFIG_NETFILTER_ADVANCED is not set # # Core Netfilter Configuration # CONFIG_NETFILTER_INGRESS=y CONFIG_NETFILTER_EGRESS=y CONFIG_NETFILTER_SKIP_EGRESS=y CONFIG_NETFILTER_NETLINK=y CONFIG_NETFILTER_NETLINK_LOG=y CONFIG_NF_CONNTRACK=y CONFIG_NF_LOG_SYSLOG=m CONFIG_NF_CONNTRACK_SECMARK=y # CONFIG_NF_CONNTRACK_PROCFS is not set # CONFIG_NF_CONNTRACK_LABELS is not set CONFIG_NF_CONNTRACK_FTP=y CONFIG_NF_CONNTRACK_IRC=y # CONFIG_NF_CONNTRACK_NETBIOS_NS is not set CONFIG_NF_CONNTRACK_SIP=y CONFIG_NF_CT_NETLINK=y # CONFIG_NETFILTER_NETLINK_GLUE_CT is not set CONFIG_NF_NAT=y CONFIG_NF_NAT_FTP=y CONFIG_NF_NAT_IRC=y CONFIG_NF_NAT_SIP=y CONFIG_NF_NAT_MASQUERADE=y # CONFIG_NF_TABLES is not set CONFIG_NETFILTER_XTABLES=y CONFIG_NETFILTER_XTABLES_COMPAT=y # # Xtables combined modules # CONFIG_NETFILTER_XT_MARK=m # # Xtables targets # CONFIG_NETFILTER_XT_TARGET_CONNSECMARK=y CONFIG_NETFILTER_XT_TARGET_LOG=m CONFIG_NETFILTER_XT_NAT=m # CONFIG_NETFILTER_XT_TARGET_NETMAP is not set CONFIG_NETFILTER_XT_TARGET_NFLOG=y # CONFIG_NETFILTER_XT_TARGET_REDIRECT is not set CONFIG_NETFILTER_XT_TARGET_MASQUERADE=m CONFIG_NETFILTER_XT_TARGET_SECMARK=y CONFIG_NETFILTER_XT_TARGET_TCPMSS=y # # Xtables matches # CONFIG_NETFILTER_XT_MATCH_ADDRTYPE=m CONFIG_NETFILTER_XT_MATCH_CONNTRACK=y CONFIG_NETFILTER_XT_MATCH_POLICY=y CONFIG_NETFILTER_XT_MATCH_STATE=y # end of Core Netfilter Configuration # CONFIG_IP_SET is not set # CONFIG_IP_VS is not set # # IP: Netfilter Configuration # CONFIG_NF_DEFRAG_IPV4=y # CONFIG_NF_SOCKET_IPV4 is not set # CONFIG_NF_TPROXY_IPV4 is not set # CONFIG_NF_DUP_IPV4 is not set CONFIG_NF_LOG_ARP=m CONFIG_NF_LOG_IPV4=m CONFIG_NF_REJECT_IPV4=y CONFIG_IP_NF_IPTABLES=y CONFIG_IP_NF_FILTER=y CONFIG_IP_NF_TARGET_REJECT=y CONFIG_IP_NF_NAT=m CONFIG_IP_NF_TARGET_MASQUERADE=m CONFIG_IP_NF_MANGLE=y # CONFIG_IP_NF_RAW is not set # end of IP: Netfilter Configuration # # IPv6: Netfilter Configuration # # CONFIG_NF_SOCKET_IPV6 is not set # CONFIG_NF_TPROXY_IPV6 is not set # CONFIG_NF_DUP_IPV6 is not set CONFIG_NF_REJECT_IPV6=y CONFIG_NF_LOG_IPV6=m CONFIG_IP6_NF_IPTABLES=y CONFIG_IP6_NF_MATCH_IPV6HEADER=y CONFIG_IP6_NF_FILTER=y CONFIG_IP6_NF_TARGET_REJECT=y CONFIG_IP6_NF_MANGLE=y # CONFIG_IP6_NF_RAW is not set # end of IPv6: Netfilter Configuration CONFIG_NF_DEFRAG_IPV6=y # CONFIG_NF_CONNTRACK_BRIDGE is not set # CONFIG_BPFILTER is not set # CONFIG_IP_DCCP is not set # CONFIG_IP_SCTP is not set # CONFIG_RDS is not set # CONFIG_TIPC is not set # CONFIG_ATM is not set # CONFIG_L2TP is not set # CONFIG_BRIDGE is not set # CONFIG_NET_DSA is not set # CONFIG_VLAN_8021Q is not set # CONFIG_LLC2 is not set # CONFIG_ATALK is not set # CONFIG_X25 is not set # CONFIG_LAPB is not set # CONFIG_PHONET is not set # CONFIG_6LOWPAN is not set # CONFIG_IEEE802154 is not set CONFIG_NET_SCHED=y # # Queueing/Scheduling # # CONFIG_NET_SCH_CBQ is not set # CONFIG_NET_SCH_HTB is not set # CONFIG_NET_SCH_HFSC is not set # CONFIG_NET_SCH_PRIO is not set # CONFIG_NET_SCH_MULTIQ is not set # CONFIG_NET_SCH_RED is not set # CONFIG_NET_SCH_SFB is not set # CONFIG_NET_SCH_SFQ is not set # CONFIG_NET_SCH_TEQL is not set # CONFIG_NET_SCH_TBF is not set # CONFIG_NET_SCH_CBS is not set # CONFIG_NET_SCH_ETF is not set # CONFIG_NET_SCH_TAPRIO is not set # CONFIG_NET_SCH_GRED is not set # CONFIG_NET_SCH_DSMARK is not set # CONFIG_NET_SCH_NETEM is not set # CONFIG_NET_SCH_DRR is not set # CONFIG_NET_SCH_MQPRIO is not set # CONFIG_NET_SCH_SKBPRIO is not set # CONFIG_NET_SCH_CHOKE is not set # CONFIG_NET_SCH_QFQ is not set # CONFIG_NET_SCH_CODEL is not set # CONFIG_NET_SCH_FQ_CODEL is not set # CONFIG_NET_SCH_CAKE is not set # CONFIG_NET_SCH_FQ is not set # CONFIG_NET_SCH_HHF is not set # CONFIG_NET_SCH_PIE is not set # CONFIG_NET_SCH_INGRESS is not set # CONFIG_NET_SCH_PLUG is not set # CONFIG_NET_SCH_ETS is not set # CONFIG_NET_SCH_DEFAULT is not set # # Classification # CONFIG_NET_CLS=y # CONFIG_NET_CLS_BASIC is not set # CONFIG_NET_CLS_TCINDEX is not set # CONFIG_NET_CLS_ROUTE4 is not set # CONFIG_NET_CLS_FW is not set # CONFIG_NET_CLS_U32 is not set # CONFIG_NET_CLS_RSVP is not set # CONFIG_NET_CLS_RSVP6 is not set # CONFIG_NET_CLS_FLOW is not set CONFIG_NET_CLS_CGROUP=y # CONFIG_NET_CLS_BPF is not set # CONFIG_NET_CLS_FLOWER is not set # CONFIG_NET_CLS_MATCHALL is not set CONFIG_NET_EMATCH=y CONFIG_NET_EMATCH_STACK=32 # CONFIG_NET_EMATCH_CMP is not set # CONFIG_NET_EMATCH_NBYTE is not set # CONFIG_NET_EMATCH_U32 is not set # CONFIG_NET_EMATCH_META is not set # CONFIG_NET_EMATCH_TEXT is not set # CONFIG_NET_EMATCH_IPT is not set CONFIG_NET_CLS_ACT=y # CONFIG_NET_ACT_POLICE is not set # CONFIG_NET_ACT_GACT is not set # CONFIG_NET_ACT_MIRRED is not set # CONFIG_NET_ACT_SAMPLE is not set # CONFIG_NET_ACT_IPT is not set # CONFIG_NET_ACT_NAT is not set # CONFIG_NET_ACT_PEDIT is not set # CONFIG_NET_ACT_SIMP is not set # CONFIG_NET_ACT_SKBEDIT is not set # CONFIG_NET_ACT_CSUM is not set # CONFIG_NET_ACT_MPLS is not set # CONFIG_NET_ACT_VLAN is not set # CONFIG_NET_ACT_BPF is not set # CONFIG_NET_ACT_SKBMOD is not set # CONFIG_NET_ACT_IFE is not set # CONFIG_NET_ACT_TUNNEL_KEY is not set # CONFIG_NET_ACT_GATE is not set # CONFIG_NET_TC_SKB_EXT is not set CONFIG_NET_SCH_FIFO=y # CONFIG_DCB is not set CONFIG_DNS_RESOLVER=y # CONFIG_BATMAN_ADV is not set # CONFIG_OPENVSWITCH is not set # CONFIG_VSOCKETS is not set # CONFIG_NETLINK_DIAG is not set # CONFIG_MPLS is not set # CONFIG_NET_NSH is not set # CONFIG_HSR is not set # CONFIG_NET_SWITCHDEV is not set # CONFIG_NET_L3_MASTER_DEV is not set # CONFIG_QRTR is not set # CONFIG_NET_NCSI is not set CONFIG_CGROUP_NET_PRIO=y CONFIG_CGROUP_NET_CLASSID=y CONFIG_NET_RX_BUSY_POLL=y CONFIG_BQL=y # # Network testing # # CONFIG_NET_PKTGEN is not set # CONFIG_NET_DROP_MONITOR is not set # end of Network testing # end of Networking options # CONFIG_HAMRADIO is not set # CONFIG_CAN is not set # CONFIG_BT is not set # CONFIG_AF_RXRPC is not set # CONFIG_AF_KCM is not set # CONFIG_MCTP is not set CONFIG_FIB_RULES=y CONFIG_WIRELESS=y CONFIG_CFG80211=y # CONFIG_NL80211_TESTMODE is not set # CONFIG_CFG80211_DEVELOPER_WARNINGS is not set CONFIG_CFG80211_REQUIRE_SIGNED_REGDB=y CONFIG_CFG80211_USE_KERNEL_REGDB_KEYS=y CONFIG_CFG80211_DEFAULT_PS=y # CONFIG_CFG80211_DEBUGFS is not set CONFIG_CFG80211_CRDA_SUPPORT=y # CONFIG_CFG80211_WEXT is not set CONFIG_MAC80211=y CONFIG_MAC80211_HAS_RC=y CONFIG_MAC80211_RC_MINSTREL=y CONFIG_MAC80211_RC_DEFAULT_MINSTREL=y CONFIG_MAC80211_RC_DEFAULT="minstrel_ht" # CONFIG_MAC80211_MESH is not set CONFIG_MAC80211_LEDS=y # CONFIG_MAC80211_DEBUGFS is not set # CONFIG_MAC80211_MESSAGE_TRACING is not set # CONFIG_MAC80211_DEBUG_MENU is not set CONFIG_MAC80211_STA_HASH_MAX_SIZE=0 CONFIG_RFKILL=y CONFIG_RFKILL_LEDS=y CONFIG_RFKILL_INPUT=y CONFIG_NET_9P=y CONFIG_NET_9P_FD=y CONFIG_NET_9P_VIRTIO=y # CONFIG_NET_9P_DEBUG is not set # CONFIG_CAIF is not set # CONFIG_CEPH_LIB is not set # CONFIG_NFC is not set # CONFIG_PSAMPLE is not set # CONFIG_NET_IFE is not set # CONFIG_LWTUNNEL is not set CONFIG_DST_CACHE=y CONFIG_GRO_CELLS=y CONFIG_NET_SELFTESTS=y CONFIG_FAILOVER=y CONFIG_ETHTOOL_NETLINK=y # # Device Drivers # CONFIG_HAVE_EISA=y # CONFIG_EISA is not set CONFIG_HAVE_PCI=y CONFIG_PCI=y CONFIG_PCI_DOMAINS=y CONFIG_PCIEPORTBUS=y # CONFIG_HOTPLUG_PCI_PCIE is not set # CONFIG_PCIEAER is not set CONFIG_PCIEASPM=y CONFIG_PCIEASPM_DEFAULT=y # CONFIG_PCIEASPM_POWERSAVE is not set # CONFIG_PCIEASPM_POWER_SUPERSAVE is not set # CONFIG_PCIEASPM_PERFORMANCE is not set CONFIG_PCIE_PME=y # CONFIG_PCIE_PTM is not set CONFIG_PCI_MSI=y CONFIG_PCI_MSI_IRQ_DOMAIN=y CONFIG_PCI_QUIRKS=y # CONFIG_PCI_DEBUG is not set # CONFIG_PCI_STUB is not set CONFIG_PCI_ATS=y CONFIG_PCI_LOCKLESS_CONFIG=y # CONFIG_PCI_IOV is not set CONFIG_PCI_PRI=y CONFIG_PCI_PASID=y CONFIG_PCI_LABEL=y CONFIG_VGA_ARB=y CONFIG_VGA_ARB_MAX_GPUS=16 CONFIG_HOTPLUG_PCI=y # CONFIG_HOTPLUG_PCI_ACPI is not set # CONFIG_HOTPLUG_PCI_CPCI is not set # CONFIG_HOTPLUG_PCI_SHPC is not set # # PCI controller drivers # # CONFIG_VMD is not set # # DesignWare PCI Core Support # # CONFIG_PCIE_DW_PLAT_HOST is not set # CONFIG_PCI_MESON is not set # end of DesignWare PCI Core Support # # Mobiveil PCIe Core Support # # end of Mobiveil PCIe Core Support # # Cadence PCIe controllers support # # end of Cadence PCIe controllers support # end of PCI controller drivers # # PCI Endpoint # # CONFIG_PCI_ENDPOINT is not set # end of PCI Endpoint # # PCI switch controller drivers # # CONFIG_PCI_SW_SWITCHTEC is not set # end of PCI switch controller drivers # CONFIG_CXL_BUS is not set CONFIG_PCCARD=y CONFIG_PCMCIA=y CONFIG_PCMCIA_LOAD_CIS=y CONFIG_CARDBUS=y # # PC-card bridges # CONFIG_YENTA=y CONFIG_YENTA_O2=y CONFIG_YENTA_RICOH=y CONFIG_YENTA_TI=y CONFIG_YENTA_ENE_TUNE=y CONFIG_YENTA_TOSHIBA=y # CONFIG_PD6729 is not set # CONFIG_I82092 is not set CONFIG_PCCARD_NONSTATIC=y # CONFIG_RAPIDIO is not set # # Generic Driver Options # CONFIG_AUXILIARY_BUS=y # CONFIG_UEVENT_HELPER is not set CONFIG_DEVTMPFS=y CONFIG_DEVTMPFS_MOUNT=y # CONFIG_DEVTMPFS_SAFE is not set CONFIG_STANDALONE=y CONFIG_PREVENT_FIRMWARE_BUILD=y # # Firmware loader # CONFIG_FW_LOADER=y CONFIG_EXTRA_FIRMWARE="" # CONFIG_FW_LOADER_USER_HELPER is not set # CONFIG_FW_LOADER_COMPRESS is not set CONFIG_FW_CACHE=y # CONFIG_FW_UPLOAD is not set # end of Firmware loader CONFIG_ALLOW_DEV_COREDUMP=y # CONFIG_DEBUG_DRIVER is not set CONFIG_DEBUG_DEVRES=y # CONFIG_DEBUG_TEST_DRIVER_REMOVE is not set # CONFIG_TEST_ASYNC_DRIVER_PROBE is not set CONFIG_GENERIC_CPU_AUTOPROBE=y CONFIG_GENERIC_CPU_VULNERABILITIES=y CONFIG_REGMAP=y CONFIG_DMA_SHARED_BUFFER=y # CONFIG_DMA_FENCE_TRACE is not set # end of Generic Driver Options # # Bus devices # # CONFIG_MHI_BUS is not set # CONFIG_MHI_BUS_EP is not set # end of Bus devices CONFIG_CONNECTOR=y CONFIG_PROC_EVENTS=y # # Firmware Drivers # # # ARM System Control and Management Interface Protocol # # end of ARM System Control and Management Interface Protocol # CONFIG_EDD is not set CONFIG_FIRMWARE_MEMMAP=y CONFIG_DMIID=y # CONFIG_DMI_SYSFS is not set CONFIG_DMI_SCAN_MACHINE_NON_EFI_FALLBACK=y # CONFIG_ISCSI_IBFT is not set # CONFIG_FW_CFG_SYSFS is not set # CONFIG_SYSFB_SIMPLEFB is not set # CONFIG_GOOGLE_FIRMWARE is not set # # EFI (Extensible Firmware Interface) Support # CONFIG_EFI_ESRT=y CONFIG_EFI_RUNTIME_MAP=y # CONFIG_EFI_FAKE_MEMMAP is not set CONFIG_EFI_DXE_MEM_ATTRIBUTES=y CONFIG_EFI_RUNTIME_WRAPPERS=y CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER=y # CONFIG_EFI_BOOTLOADER_CONTROL is not set # CONFIG_EFI_CAPSULE_LOADER is not set # CONFIG_EFI_TEST is not set # CONFIG_APPLE_PROPERTIES is not set # CONFIG_RESET_ATTACK_MITIGATION is not set # CONFIG_EFI_RCI2_TABLE is not set # CONFIG_EFI_DISABLE_PCI_DMA is not set CONFIG_EFI_EARLYCON=y CONFIG_EFI_CUSTOM_SSDT_OVERLAYS=y # CONFIG_EFI_DISABLE_RUNTIME is not set # CONFIG_EFI_COCO_SECRET is not set # end of EFI (Extensible Firmware Interface) Support # # Tegra firmware driver # # end of Tegra firmware driver # end of Firmware Drivers # CONFIG_GNSS is not set # CONFIG_MTD is not set # CONFIG_OF is not set CONFIG_ARCH_MIGHT_HAVE_PC_PARPORT=y # CONFIG_PARPORT is not set CONFIG_PNP=y CONFIG_PNP_DEBUG_MESSAGES=y # # Protocols # CONFIG_PNPACPI=y CONFIG_BLK_DEV=y # CONFIG_BLK_DEV_NULL_BLK is not set # CONFIG_BLK_DEV_FD is not set CONFIG_CDROM=y # CONFIG_BLK_DEV_PCIESSD_MTIP32XX is not set CONFIG_BLK_DEV_LOOP=y CONFIG_BLK_DEV_LOOP_MIN_COUNT=8 # CONFIG_BLK_DEV_DRBD is not set # CONFIG_BLK_DEV_NBD is not set # CONFIG_BLK_DEV_RAM is not set # CONFIG_CDROM_PKTCDVD is not set # CONFIG_ATA_OVER_ETH is not set CONFIG_VIRTIO_BLK=y # CONFIG_BLK_DEV_RBD is not set # CONFIG_BLK_DEV_UBLK is not set # # NVME Support # # CONFIG_BLK_DEV_NVME is not set # CONFIG_NVME_FC is not set # CONFIG_NVME_TCP is not set # end of NVME Support # # Misc devices # # CONFIG_AD525X_DPOT is not set # CONFIG_DUMMY_IRQ is not set # CONFIG_IBM_ASM is not set # CONFIG_PHANTOM is not set # CONFIG_TIFM_CORE is not set # CONFIG_ICS932S401 is not set # CONFIG_ENCLOSURE_SERVICES is not set # CONFIG_HP_ILO is not set # CONFIG_APDS9802ALS is not set # CONFIG_ISL29003 is not set # CONFIG_ISL29020 is not set # CONFIG_SENSORS_TSL2550 is not set # CONFIG_SENSORS_BH1770 is not set # CONFIG_SENSORS_APDS990X is not set # CONFIG_HMC6352 is not set # CONFIG_DS1682 is not set # CONFIG_SRAM is not set # CONFIG_DW_XDATA_PCIE is not set # CONFIG_PCI_ENDPOINT_TEST is not set # CONFIG_XILINX_SDFEC is not set # CONFIG_C2PORT is not set # # EEPROM support # # CONFIG_EEPROM_AT24 is not set # CONFIG_EEPROM_LEGACY is not set # CONFIG_EEPROM_MAX6875 is not set # CONFIG_EEPROM_93CX6 is not set # CONFIG_EEPROM_IDT_89HPESX is not set # CONFIG_EEPROM_EE1004 is not set # end of EEPROM support # CONFIG_CB710_CORE is not set # # Texas Instruments shared transport line discipline # # end of Texas Instruments shared transport line discipline # CONFIG_SENSORS_LIS3_I2C is not set # CONFIG_ALTERA_STAPL is not set # CONFIG_INTEL_MEI is not set # CONFIG_INTEL_MEI_ME is not set # CONFIG_INTEL_MEI_TXE is not set # CONFIG_INTEL_MEI_HDCP is not set # CONFIG_INTEL_MEI_PXP is not set # CONFIG_VMWARE_VMCI is not set # CONFIG_GENWQE is not set # CONFIG_ECHO is not set # CONFIG_BCM_VK is not set # CONFIG_MISC_ALCOR_PCI is not set # CONFIG_MISC_RTSX_PCI is not set # CONFIG_MISC_RTSX_USB is not set # CONFIG_HABANA_AI is not set # CONFIG_UACCE is not set # CONFIG_PVPANIC is not set # end of Misc devices # # SCSI device support # CONFIG_SCSI_MOD=y # CONFIG_RAID_ATTRS is not set CONFIG_SCSI_COMMON=y CONFIG_SCSI=y CONFIG_SCSI_DMA=y CONFIG_SCSI_PROC_FS=y # # SCSI support type (disk, tape, CD-ROM) # CONFIG_BLK_DEV_SD=y # CONFIG_CHR_DEV_ST is not set CONFIG_BLK_DEV_SR=y CONFIG_CHR_DEV_SG=y CONFIG_BLK_DEV_BSG=y # CONFIG_CHR_DEV_SCH is not set CONFIG_SCSI_CONSTANTS=y # CONFIG_SCSI_LOGGING is not set # CONFIG_SCSI_SCAN_ASYNC is not set # # SCSI Transports # CONFIG_SCSI_SPI_ATTRS=y # CONFIG_SCSI_FC_ATTRS is not set # CONFIG_SCSI_ISCSI_ATTRS is not set # CONFIG_SCSI_SAS_ATTRS is not set # CONFIG_SCSI_SAS_LIBSAS is not set # CONFIG_SCSI_SRP_ATTRS is not set # end of SCSI Transports CONFIG_SCSI_LOWLEVEL=y # CONFIG_ISCSI_TCP is not set # CONFIG_ISCSI_BOOT_SYSFS is not set # CONFIG_SCSI_CXGB3_ISCSI is not set # CONFIG_SCSI_CXGB4_ISCSI is not set # CONFIG_SCSI_BNX2_ISCSI is not set # CONFIG_BE2ISCSI is not set # CONFIG_BLK_DEV_3W_XXXX_RAID is not set # CONFIG_SCSI_HPSA is not set # CONFIG_SCSI_3W_9XXX is not set # CONFIG_SCSI_3W_SAS is not set # CONFIG_SCSI_ACARD is not set # CONFIG_SCSI_AACRAID is not set # CONFIG_SCSI_AIC7XXX is not set # CONFIG_SCSI_AIC79XX is not set # CONFIG_SCSI_AIC94XX is not set # CONFIG_SCSI_MVSAS is not set # CONFIG_SCSI_MVUMI is not set # CONFIG_SCSI_ADVANSYS is not set # CONFIG_SCSI_ARCMSR is not set # CONFIG_SCSI_ESAS2R is not set # CONFIG_MEGARAID_NEWGEN is not set # CONFIG_MEGARAID_LEGACY is not set # CONFIG_MEGARAID_SAS is not set # CONFIG_SCSI_MPT3SAS is not set # CONFIG_SCSI_MPT2SAS is not set # CONFIG_SCSI_MPI3MR is not set # CONFIG_SCSI_SMARTPQI is not set # CONFIG_SCSI_HPTIOP is not set # CONFIG_SCSI_BUSLOGIC is not set # CONFIG_SCSI_MYRB is not set # CONFIG_SCSI_MYRS is not set # CONFIG_VMWARE_PVSCSI is not set # CONFIG_SCSI_SNIC is not set # CONFIG_SCSI_DMX3191D is not set # CONFIG_SCSI_FDOMAIN_PCI is not set # CONFIG_SCSI_ISCI is not set # CONFIG_SCSI_IPS is not set # CONFIG_SCSI_INITIO is not set # CONFIG_SCSI_INIA100 is not set # CONFIG_SCSI_STEX is not set # CONFIG_SCSI_SYM53C8XX_2 is not set # CONFIG_SCSI_IPR is not set # CONFIG_SCSI_QLOGIC_1280 is not set # CONFIG_SCSI_QLA_ISCSI is not set # CONFIG_SCSI_DC395x is not set # CONFIG_SCSI_AM53C974 is not set # CONFIG_SCSI_WD719X is not set # CONFIG_SCSI_DEBUG is not set # CONFIG_SCSI_PMCRAID is not set # CONFIG_SCSI_PM8001 is not set CONFIG_SCSI_VIRTIO=y # CONFIG_SCSI_LOWLEVEL_PCMCIA is not set # CONFIG_SCSI_DH is not set # end of SCSI device support CONFIG_ATA=y CONFIG_SATA_HOST=y CONFIG_PATA_TIMINGS=y CONFIG_ATA_VERBOSE_ERROR=y CONFIG_ATA_FORCE=y CONFIG_ATA_ACPI=y # CONFIG_SATA_ZPODD is not set CONFIG_SATA_PMP=y # # Controllers with non-SFF native interface # CONFIG_SATA_AHCI=y CONFIG_SATA_MOBILE_LPM_POLICY=0 # CONFIG_SATA_AHCI_PLATFORM is not set # CONFIG_AHCI_DWC is not set # CONFIG_SATA_INIC162X is not set # CONFIG_SATA_ACARD_AHCI is not set # CONFIG_SATA_SIL24 is not set CONFIG_ATA_SFF=y # # SFF controllers with custom DMA interface # # CONFIG_PDC_ADMA is not set # CONFIG_SATA_QSTOR is not set # CONFIG_SATA_SX4 is not set CONFIG_ATA_BMDMA=y # # SATA SFF controllers with BMDMA # CONFIG_ATA_PIIX=y # CONFIG_SATA_DWC is not set # CONFIG_SATA_MV is not set # CONFIG_SATA_NV is not set # CONFIG_SATA_PROMISE is not set # CONFIG_SATA_SIL is not set # CONFIG_SATA_SIS is not set # CONFIG_SATA_SVW is not set # CONFIG_SATA_ULI is not set # CONFIG_SATA_VIA is not set # CONFIG_SATA_VITESSE is not set # # PATA SFF controllers with BMDMA # # CONFIG_PATA_ALI is not set CONFIG_PATA_AMD=y # CONFIG_PATA_ARTOP is not set # CONFIG_PATA_ATIIXP is not set # CONFIG_PATA_ATP867X is not set # CONFIG_PATA_CMD64X is not set # CONFIG_PATA_CYPRESS is not set # CONFIG_PATA_EFAR is not set # CONFIG_PATA_HPT366 is not set # CONFIG_PATA_HPT37X is not set # CONFIG_PATA_HPT3X2N is not set # CONFIG_PATA_HPT3X3 is not set # CONFIG_PATA_IT8213 is not set # CONFIG_PATA_IT821X is not set # CONFIG_PATA_JMICRON is not set # CONFIG_PATA_MARVELL is not set # CONFIG_PATA_NETCELL is not set # CONFIG_PATA_NINJA32 is not set # CONFIG_PATA_NS87415 is not set CONFIG_PATA_OLDPIIX=y # CONFIG_PATA_OPTIDMA is not set # CONFIG_PATA_PDC2027X is not set # CONFIG_PATA_PDC_OLD is not set # CONFIG_PATA_RADISYS is not set # CONFIG_PATA_RDC is not set CONFIG_PATA_SCH=y # CONFIG_PATA_SERVERWORKS is not set # CONFIG_PATA_SIL680 is not set # CONFIG_PATA_SIS is not set # CONFIG_PATA_TOSHIBA is not set # CONFIG_PATA_TRIFLEX is not set # CONFIG_PATA_VIA is not set # CONFIG_PATA_WINBOND is not set # # PIO-only SFF controllers # # CONFIG_PATA_CMD640_PCI is not set # CONFIG_PATA_MPIIX is not set # CONFIG_PATA_NS87410 is not set # CONFIG_PATA_OPTI is not set # CONFIG_PATA_PCMCIA is not set # CONFIG_PATA_RZ1000 is not set # # Generic fallback / legacy drivers # # CONFIG_PATA_ACPI is not set # CONFIG_ATA_GENERIC is not set # CONFIG_PATA_LEGACY is not set CONFIG_MD=y CONFIG_BLK_DEV_MD=y CONFIG_MD_AUTODETECT=y # CONFIG_MD_LINEAR is not set # CONFIG_MD_RAID0 is not set # CONFIG_MD_RAID1 is not set # CONFIG_MD_RAID10 is not set # CONFIG_MD_RAID456 is not set # CONFIG_MD_MULTIPATH is not set # CONFIG_MD_FAULTY is not set # CONFIG_BCACHE is not set CONFIG_BLK_DEV_DM_BUILTIN=y CONFIG_BLK_DEV_DM=y # CONFIG_DM_DEBUG is not set # CONFIG_DM_UNSTRIPED is not set # CONFIG_DM_CRYPT is not set # CONFIG_DM_SNAPSHOT is not set # CONFIG_DM_THIN_PROVISIONING is not set # CONFIG_DM_CACHE is not set # CONFIG_DM_WRITECACHE is not set # CONFIG_DM_EBS is not set # CONFIG_DM_ERA is not set # CONFIG_DM_CLONE is not set CONFIG_DM_MIRROR=y # CONFIG_DM_LOG_USERSPACE is not set # CONFIG_DM_RAID is not set CONFIG_DM_ZERO=y # CONFIG_DM_MULTIPATH is not set # CONFIG_DM_DELAY is not set # CONFIG_DM_DUST is not set # CONFIG_DM_INIT is not set # CONFIG_DM_UEVENT is not set # CONFIG_DM_FLAKEY is not set # CONFIG_DM_VERITY is not set # CONFIG_DM_SWITCH is not set # CONFIG_DM_LOG_WRITES is not set # CONFIG_DM_INTEGRITY is not set # CONFIG_DM_AUDIT is not set # CONFIG_TARGET_CORE is not set # CONFIG_FUSION is not set # # IEEE 1394 (FireWire) support # # CONFIG_FIREWIRE is not set # CONFIG_FIREWIRE_NOSY is not set # end of IEEE 1394 (FireWire) support CONFIG_MACINTOSH_DRIVERS=y CONFIG_MAC_EMUMOUSEBTN=y CONFIG_NETDEVICES=y CONFIG_MII=y CONFIG_NET_CORE=y # CONFIG_BONDING is not set # CONFIG_DUMMY is not set # CONFIG_WIREGUARD is not set # CONFIG_EQUALIZER is not set # CONFIG_NET_FC is not set # CONFIG_NET_TEAM is not set # CONFIG_MACVLAN is not set # CONFIG_IPVLAN is not set # CONFIG_VXLAN is not set # CONFIG_GENEVE is not set # CONFIG_BAREUDP is not set # CONFIG_GTP is not set # CONFIG_AMT is not set # CONFIG_MACSEC is not set CONFIG_NETCONSOLE=y CONFIG_NETPOLL=y CONFIG_NET_POLL_CONTROLLER=y # CONFIG_TUN is not set # CONFIG_TUN_VNET_CROSS_LE is not set # CONFIG_VETH is not set CONFIG_VIRTIO_NET=y # CONFIG_NLMON is not set # CONFIG_ARCNET is not set CONFIG_ETHERNET=y CONFIG_NET_VENDOR_3COM=y # CONFIG_PCMCIA_3C574 is not set # CONFIG_PCMCIA_3C589 is not set # CONFIG_VORTEX is not set # CONFIG_TYPHOON is not set CONFIG_NET_VENDOR_ADAPTEC=y # CONFIG_ADAPTEC_STARFIRE is not set CONFIG_NET_VENDOR_AGERE=y # CONFIG_ET131X is not set CONFIG_NET_VENDOR_ALACRITECH=y # CONFIG_SLICOSS is not set CONFIG_NET_VENDOR_ALTEON=y # CONFIG_ACENIC is not set # CONFIG_ALTERA_TSE is not set CONFIG_NET_VENDOR_AMAZON=y # CONFIG_ENA_ETHERNET is not set CONFIG_NET_VENDOR_AMD=y # CONFIG_AMD8111_ETH is not set # CONFIG_PCNET32 is not set # CONFIG_PCMCIA_NMCLAN is not set # CONFIG_AMD_XGBE is not set CONFIG_NET_VENDOR_AQUANTIA=y # CONFIG_AQTION is not set CONFIG_NET_VENDOR_ARC=y CONFIG_NET_VENDOR_ASIX=y CONFIG_NET_VENDOR_ATHEROS=y # CONFIG_ATL2 is not set # CONFIG_ATL1 is not set # CONFIG_ATL1E is not set # CONFIG_ATL1C is not set # CONFIG_ALX is not set # CONFIG_CX_ECAT is not set CONFIG_NET_VENDOR_BROADCOM=y # CONFIG_B44 is not set # CONFIG_BCMGENET is not set # CONFIG_BNX2 is not set # CONFIG_CNIC is not set CONFIG_TIGON3=y CONFIG_TIGON3_HWMON=y # CONFIG_BNX2X is not set # CONFIG_SYSTEMPORT is not set # CONFIG_BNXT is not set CONFIG_NET_VENDOR_CADENCE=y CONFIG_NET_VENDOR_CAVIUM=y # CONFIG_THUNDER_NIC_PF is not set # CONFIG_THUNDER_NIC_VF is not set # CONFIG_THUNDER_NIC_BGX is not set # CONFIG_THUNDER_NIC_RGX is not set # CONFIG_CAVIUM_PTP is not set # CONFIG_LIQUIDIO is not set # CONFIG_LIQUIDIO_VF is not set CONFIG_NET_VENDOR_CHELSIO=y # CONFIG_CHELSIO_T1 is not set # CONFIG_CHELSIO_T3 is not set # CONFIG_CHELSIO_T4 is not set # CONFIG_CHELSIO_T4VF is not set CONFIG_NET_VENDOR_CISCO=y # CONFIG_ENIC is not set CONFIG_NET_VENDOR_CORTINA=y CONFIG_NET_VENDOR_DAVICOM=y # CONFIG_DNET is not set CONFIG_NET_VENDOR_DEC=y CONFIG_NET_TULIP=y # CONFIG_DE2104X is not set # CONFIG_TULIP is not set # CONFIG_WINBOND_840 is not set # CONFIG_DM9102 is not set # CONFIG_ULI526X is not set # CONFIG_PCMCIA_XIRCOM is not set CONFIG_NET_VENDOR_DLINK=y # CONFIG_DL2K is not set # CONFIG_SUNDANCE is not set CONFIG_NET_VENDOR_EMULEX=y # CONFIG_BE2NET is not set CONFIG_NET_VENDOR_ENGLEDER=y # CONFIG_TSNEP is not set CONFIG_NET_VENDOR_EZCHIP=y CONFIG_NET_VENDOR_FUJITSU=y # CONFIG_PCMCIA_FMVJ18X is not set CONFIG_NET_VENDOR_FUNGIBLE=y # CONFIG_FUN_ETH is not set CONFIG_NET_VENDOR_GOOGLE=y # CONFIG_GVE is not set CONFIG_NET_VENDOR_HUAWEI=y # CONFIG_HINIC is not set CONFIG_NET_VENDOR_I825XX=y CONFIG_NET_VENDOR_INTEL=y CONFIG_E100=y CONFIG_E1000=y CONFIG_E1000E=y CONFIG_E1000E_HWTS=y # CONFIG_IGB is not set # CONFIG_IGBVF is not set # CONFIG_IXGB is not set # CONFIG_IXGBE is not set # CONFIG_IXGBEVF is not set # CONFIG_I40E is not set # CONFIG_I40EVF is not set # CONFIG_ICE is not set # CONFIG_FM10K is not set # CONFIG_IGC is not set CONFIG_NET_VENDOR_WANGXUN=y # CONFIG_NGBE is not set # CONFIG_TXGBE is not set # CONFIG_JME is not set CONFIG_NET_VENDOR_LITEX=y CONFIG_NET_VENDOR_MARVELL=y # CONFIG_MVMDIO is not set # CONFIG_SKGE is not set CONFIG_SKY2=y # CONFIG_SKY2_DEBUG is not set # CONFIG_OCTEON_EP is not set CONFIG_NET_VENDOR_MELLANOX=y # CONFIG_MLX4_EN is not set # CONFIG_MLX5_CORE is not set # CONFIG_MLXSW_CORE is not set # CONFIG_MLXFW is not set CONFIG_NET_VENDOR_MICREL=y # CONFIG_KS8842 is not set # CONFIG_KS8851_MLL is not set # CONFIG_KSZ884X_PCI is not set CONFIG_NET_VENDOR_MICROCHIP=y # CONFIG_LAN743X is not set CONFIG_NET_VENDOR_MICROSEMI=y CONFIG_NET_VENDOR_MICROSOFT=y CONFIG_NET_VENDOR_MYRI=y # CONFIG_MYRI10GE is not set # CONFIG_FEALNX is not set CONFIG_NET_VENDOR_NI=y # CONFIG_NI_XGE_MANAGEMENT_ENET is not set CONFIG_NET_VENDOR_NATSEMI=y # CONFIG_NATSEMI is not set # CONFIG_NS83820 is not set CONFIG_NET_VENDOR_NETERION=y # CONFIG_S2IO is not set CONFIG_NET_VENDOR_NETRONOME=y # CONFIG_NFP is not set CONFIG_NET_VENDOR_8390=y # CONFIG_PCMCIA_AXNET is not set # CONFIG_NE2K_PCI is not set # CONFIG_PCMCIA_PCNET is not set CONFIG_NET_VENDOR_NVIDIA=y CONFIG_FORCEDETH=y CONFIG_NET_VENDOR_OKI=y # CONFIG_ETHOC is not set CONFIG_NET_VENDOR_PACKET_ENGINES=y # CONFIG_HAMACHI is not set # CONFIG_YELLOWFIN is not set CONFIG_NET_VENDOR_PENSANDO=y # CONFIG_IONIC is not set CONFIG_NET_VENDOR_QLOGIC=y # CONFIG_QLA3XXX is not set # CONFIG_QLCNIC is not set # CONFIG_NETXEN_NIC is not set # CONFIG_QED is not set CONFIG_NET_VENDOR_BROCADE=y # CONFIG_BNA is not set CONFIG_NET_VENDOR_QUALCOMM=y # CONFIG_QCOM_EMAC is not set # CONFIG_RMNET is not set CONFIG_NET_VENDOR_RDC=y # CONFIG_R6040 is not set CONFIG_NET_VENDOR_REALTEK=y # CONFIG_8139CP is not set CONFIG_8139TOO=y CONFIG_8139TOO_PIO=y # CONFIG_8139TOO_TUNE_TWISTER is not set # CONFIG_8139TOO_8129 is not set # CONFIG_8139_OLD_RX_RESET is not set CONFIG_R8169=y CONFIG_NET_VENDOR_RENESAS=y CONFIG_NET_VENDOR_ROCKER=y CONFIG_NET_VENDOR_SAMSUNG=y # CONFIG_SXGBE_ETH is not set CONFIG_NET_VENDOR_SEEQ=y CONFIG_NET_VENDOR_SILAN=y # CONFIG_SC92031 is not set CONFIG_NET_VENDOR_SIS=y # CONFIG_SIS900 is not set # CONFIG_SIS190 is not set CONFIG_NET_VENDOR_SOLARFLARE=y # CONFIG_SFC is not set # CONFIG_SFC_FALCON is not set # CONFIG_SFC_SIENA is not set CONFIG_NET_VENDOR_SMSC=y # CONFIG_PCMCIA_SMC91C92 is not set # CONFIG_EPIC100 is not set # CONFIG_SMSC911X is not set # CONFIG_SMSC9420 is not set CONFIG_NET_VENDOR_SOCIONEXT=y CONFIG_NET_VENDOR_STMICRO=y # CONFIG_STMMAC_ETH is not set CONFIG_NET_VENDOR_SUN=y # CONFIG_HAPPYMEAL is not set # CONFIG_SUNGEM is not set # CONFIG_CASSINI is not set # CONFIG_NIU is not set CONFIG_NET_VENDOR_SYNOPSYS=y # CONFIG_DWC_XLGMAC is not set CONFIG_NET_VENDOR_TEHUTI=y # CONFIG_TEHUTI is not set CONFIG_NET_VENDOR_TI=y # CONFIG_TI_CPSW_PHY_SEL is not set # CONFIG_TLAN is not set CONFIG_NET_VENDOR_VERTEXCOM=y CONFIG_NET_VENDOR_VIA=y # CONFIG_VIA_RHINE is not set # CONFIG_VIA_VELOCITY is not set CONFIG_NET_VENDOR_WIZNET=y # CONFIG_WIZNET_W5100 is not set # CONFIG_WIZNET_W5300 is not set CONFIG_NET_VENDOR_XILINX=y # CONFIG_XILINX_EMACLITE is not set # CONFIG_XILINX_AXI_EMAC is not set # CONFIG_XILINX_LL_TEMAC is not set CONFIG_NET_VENDOR_XIRCOM=y # CONFIG_PCMCIA_XIRC2PS is not set # CONFIG_FDDI is not set # CONFIG_HIPPI is not set # CONFIG_NET_SB1000 is not set CONFIG_PHYLIB=y CONFIG_SWPHY=y # CONFIG_LED_TRIGGER_PHY is not set CONFIG_FIXED_PHY=y # # MII PHY device drivers # # CONFIG_AMD_PHY is not set # CONFIG_ADIN_PHY is not set # CONFIG_ADIN1100_PHY is not set # CONFIG_AQUANTIA_PHY is not set # CONFIG_AX88796B_PHY is not set # CONFIG_BROADCOM_PHY is not set # CONFIG_BCM54140_PHY is not set # CONFIG_BCM7XXX_PHY is not set # CONFIG_BCM84881_PHY is not set # CONFIG_BCM87XX_PHY is not set # CONFIG_CICADA_PHY is not set # CONFIG_CORTINA_PHY is not set # CONFIG_DAVICOM_PHY is not set # CONFIG_ICPLUS_PHY is not set # CONFIG_LXT_PHY is not set # CONFIG_INTEL_XWAY_PHY is not set # CONFIG_LSI_ET1011C_PHY is not set # CONFIG_MARVELL_PHY is not set # CONFIG_MARVELL_10G_PHY is not set # CONFIG_MARVELL_88X2222_PHY is not set # CONFIG_MAXLINEAR_GPHY is not set # CONFIG_MEDIATEK_GE_PHY is not set # CONFIG_MICREL_PHY is not set # CONFIG_MICROCHIP_PHY is not set # CONFIG_MICROCHIP_T1_PHY is not set # CONFIG_MICROSEMI_PHY is not set # CONFIG_MOTORCOMM_PHY is not set # CONFIG_NATIONAL_PHY is not set # CONFIG_NXP_C45_TJA11XX_PHY is not set # CONFIG_NXP_TJA11XX_PHY is not set # CONFIG_QSEMI_PHY is not set CONFIG_REALTEK_PHY=y # CONFIG_RENESAS_PHY is not set # CONFIG_ROCKCHIP_PHY is not set # CONFIG_SMSC_PHY is not set # CONFIG_STE10XP is not set # CONFIG_TERANETICS_PHY is not set # CONFIG_DP83822_PHY is not set # CONFIG_DP83TC811_PHY is not set # CONFIG_DP83848_PHY is not set # CONFIG_DP83867_PHY is not set # CONFIG_DP83869_PHY is not set # CONFIG_DP83TD510_PHY is not set # CONFIG_VITESSE_PHY is not set # CONFIG_XILINX_GMII2RGMII is not set # CONFIG_PSE_CONTROLLER is not set CONFIG_MDIO_DEVICE=y CONFIG_MDIO_BUS=y CONFIG_FWNODE_MDIO=y CONFIG_ACPI_MDIO=y CONFIG_MDIO_DEVRES=y # CONFIG_MDIO_BITBANG is not set # CONFIG_MDIO_BCM_UNIMAC is not set # CONFIG_MDIO_MVUSB is not set # CONFIG_MDIO_THUNDER is not set # # MDIO Multiplexers # # # PCS device drivers # # end of PCS device drivers # CONFIG_PPP is not set # CONFIG_SLIP is not set CONFIG_USB_NET_DRIVERS=y # CONFIG_USB_CATC is not set # CONFIG_USB_KAWETH is not set # CONFIG_USB_PEGASUS is not set # CONFIG_USB_RTL8150 is not set # CONFIG_USB_RTL8152 is not set # CONFIG_USB_LAN78XX is not set # CONFIG_USB_USBNET is not set # CONFIG_USB_HSO is not set # CONFIG_USB_IPHETH is not set CONFIG_WLAN=y CONFIG_WLAN_VENDOR_ADMTEK=y # CONFIG_ADM8211 is not set CONFIG_WLAN_VENDOR_ATH=y # CONFIG_ATH_DEBUG is not set # CONFIG_ATH5K is not set # CONFIG_ATH5K_PCI is not set # CONFIG_ATH9K is not set # CONFIG_ATH9K_HTC is not set # CONFIG_CARL9170 is not set # CONFIG_ATH6KL is not set # CONFIG_AR5523 is not set # CONFIG_WIL6210 is not set # CONFIG_ATH10K is not set # CONFIG_WCN36XX is not set CONFIG_WLAN_VENDOR_ATMEL=y # CONFIG_ATMEL is not set # CONFIG_AT76C50X_USB is not set CONFIG_WLAN_VENDOR_BROADCOM=y # CONFIG_B43 is not set # CONFIG_B43LEGACY is not set # CONFIG_BRCMSMAC is not set # CONFIG_BRCMFMAC is not set CONFIG_WLAN_VENDOR_CISCO=y # CONFIG_AIRO is not set # CONFIG_AIRO_CS is not set CONFIG_WLAN_VENDOR_INTEL=y # CONFIG_IPW2100 is not set # CONFIG_IPW2200 is not set # CONFIG_IWL4965 is not set # CONFIG_IWL3945 is not set # CONFIG_IWLWIFI is not set CONFIG_WLAN_VENDOR_INTERSIL=y # CONFIG_HOSTAP is not set # CONFIG_HERMES is not set # CONFIG_P54_COMMON is not set CONFIG_WLAN_VENDOR_MARVELL=y # CONFIG_LIBERTAS is not set # CONFIG_LIBERTAS_THINFIRM is not set # CONFIG_MWIFIEX is not set # CONFIG_MWL8K is not set CONFIG_WLAN_VENDOR_MEDIATEK=y # CONFIG_MT7601U is not set # CONFIG_MT76x0U is not set # CONFIG_MT76x0E is not set # CONFIG_MT76x2E is not set # CONFIG_MT76x2U is not set # CONFIG_MT7603E is not set # CONFIG_MT7615E is not set # CONFIG_MT7663U is not set # CONFIG_MT7915E is not set # CONFIG_MT7921E is not set # CONFIG_MT7921U is not set CONFIG_WLAN_VENDOR_MICROCHIP=y CONFIG_WLAN_VENDOR_PURELIFI=y # CONFIG_PLFXLC is not set CONFIG_WLAN_VENDOR_RALINK=y # CONFIG_RT2X00 is not set CONFIG_WLAN_VENDOR_REALTEK=y # CONFIG_RTL8180 is not set # CONFIG_RTL8187 is not set CONFIG_RTL_CARDS=y # CONFIG_RTL8192CE is not set # CONFIG_RTL8192SE is not set # CONFIG_RTL8192DE is not set # CONFIG_RTL8723AE is not set # CONFIG_RTL8723BE is not set # CONFIG_RTL8188EE is not set # CONFIG_RTL8192EE is not set # CONFIG_RTL8821AE is not set # CONFIG_RTL8192CU is not set # CONFIG_RTL8XXXU is not set # CONFIG_RTW88 is not set # CONFIG_RTW89 is not set CONFIG_WLAN_VENDOR_RSI=y # CONFIG_RSI_91X is not set CONFIG_WLAN_VENDOR_SILABS=y CONFIG_WLAN_VENDOR_ST=y # CONFIG_CW1200 is not set CONFIG_WLAN_VENDOR_TI=y # CONFIG_WL1251 is not set # CONFIG_WL12XX is not set # CONFIG_WL18XX is not set # CONFIG_WLCORE is not set CONFIG_WLAN_VENDOR_ZYDAS=y # CONFIG_USB_ZD1201 is not set # CONFIG_ZD1211RW is not set CONFIG_WLAN_VENDOR_QUANTENNA=y # CONFIG_QTNFMAC_PCIE is not set # CONFIG_PCMCIA_RAYCS is not set # CONFIG_PCMCIA_WL3501 is not set # CONFIG_MAC80211_HWSIM is not set # CONFIG_USB_NET_RNDIS_WLAN is not set # CONFIG_VIRT_WIFI is not set # CONFIG_WAN is not set # # Wireless WAN # # CONFIG_WWAN is not set # end of Wireless WAN # CONFIG_VMXNET3 is not set # CONFIG_FUJITSU_ES is not set # CONFIG_NETDEVSIM is not set CONFIG_NET_FAILOVER=y # CONFIG_ISDN is not set # # Input device support # CONFIG_INPUT=y CONFIG_INPUT_LEDS=y CONFIG_INPUT_FF_MEMLESS=y CONFIG_INPUT_SPARSEKMAP=y # CONFIG_INPUT_MATRIXKMAP is not set CONFIG_INPUT_VIVALDIFMAP=y # # Userland interfaces # # CONFIG_INPUT_MOUSEDEV is not set # CONFIG_INPUT_JOYDEV is not set CONFIG_INPUT_EVDEV=y # CONFIG_INPUT_EVBUG is not set # # Input Device Drivers # CONFIG_INPUT_KEYBOARD=y # CONFIG_KEYBOARD_ADP5588 is not set # CONFIG_KEYBOARD_ADP5589 is not set CONFIG_KEYBOARD_ATKBD=y # CONFIG_KEYBOARD_QT1050 is not set # CONFIG_KEYBOARD_QT1070 is not set # CONFIG_KEYBOARD_QT2160 is not set # CONFIG_KEYBOARD_DLINK_DIR685 is not set # CONFIG_KEYBOARD_LKKBD is not set # CONFIG_KEYBOARD_TCA6416 is not set # CONFIG_KEYBOARD_TCA8418 is not set # CONFIG_KEYBOARD_LM8323 is not set # CONFIG_KEYBOARD_LM8333 is not set # CONFIG_KEYBOARD_MAX7359 is not set # CONFIG_KEYBOARD_MCS is not set # CONFIG_KEYBOARD_MPR121 is not set # CONFIG_KEYBOARD_NEWTON is not set # CONFIG_KEYBOARD_OPENCORES is not set # CONFIG_KEYBOARD_STOWAWAY is not set # CONFIG_KEYBOARD_SUNKBD is not set # CONFIG_KEYBOARD_TM2_TOUCHKEY is not set # CONFIG_KEYBOARD_XTKBD is not set # CONFIG_KEYBOARD_CYPRESS_SF is not set CONFIG_INPUT_MOUSE=y CONFIG_MOUSE_PS2=y CONFIG_MOUSE_PS2_ALPS=y CONFIG_MOUSE_PS2_BYD=y CONFIG_MOUSE_PS2_LOGIPS2PP=y CONFIG_MOUSE_PS2_SYNAPTICS=y CONFIG_MOUSE_PS2_SYNAPTICS_SMBUS=y CONFIG_MOUSE_PS2_CYPRESS=y CONFIG_MOUSE_PS2_LIFEBOOK=y CONFIG_MOUSE_PS2_TRACKPOINT=y # CONFIG_MOUSE_PS2_ELANTECH is not set # CONFIG_MOUSE_PS2_SENTELIC is not set # CONFIG_MOUSE_PS2_TOUCHKIT is not set CONFIG_MOUSE_PS2_FOCALTECH=y # CONFIG_MOUSE_PS2_VMMOUSE is not set CONFIG_MOUSE_PS2_SMBUS=y # CONFIG_MOUSE_SERIAL is not set # CONFIG_MOUSE_APPLETOUCH is not set # CONFIG_MOUSE_BCM5974 is not set # CONFIG_MOUSE_CYAPA is not set # CONFIG_MOUSE_ELAN_I2C is not set # CONFIG_MOUSE_VSXXXAA is not set # CONFIG_MOUSE_SYNAPTICS_I2C is not set # CONFIG_MOUSE_SYNAPTICS_USB is not set CONFIG_INPUT_JOYSTICK=y # CONFIG_JOYSTICK_ANALOG is not set # CONFIG_JOYSTICK_A3D is not set # CONFIG_JOYSTICK_ADI is not set # CONFIG_JOYSTICK_COBRA is not set # CONFIG_JOYSTICK_GF2K is not set # CONFIG_JOYSTICK_GRIP is not set # CONFIG_JOYSTICK_GRIP_MP is not set # CONFIG_JOYSTICK_GUILLEMOT is not set # CONFIG_JOYSTICK_INTERACT is not set # CONFIG_JOYSTICK_SIDEWINDER is not set # CONFIG_JOYSTICK_TMDC is not set # CONFIG_JOYSTICK_IFORCE is not set # CONFIG_JOYSTICK_WARRIOR is not set # CONFIG_JOYSTICK_MAGELLAN is not set # CONFIG_JOYSTICK_SPACEORB is not set # CONFIG_JOYSTICK_SPACEBALL is not set # CONFIG_JOYSTICK_STINGER is not set # CONFIG_JOYSTICK_TWIDJOY is not set # CONFIG_JOYSTICK_ZHENHUA is not set # CONFIG_JOYSTICK_AS5011 is not set # CONFIG_JOYSTICK_JOYDUMP is not set # CONFIG_JOYSTICK_XPAD is not set # CONFIG_JOYSTICK_PXRC is not set # CONFIG_JOYSTICK_QWIIC is not set # CONFIG_JOYSTICK_FSIA6B is not set # CONFIG_JOYSTICK_SENSEHAT is not set CONFIG_INPUT_TABLET=y # CONFIG_TABLET_USB_ACECAD is not set # CONFIG_TABLET_USB_AIPTEK is not set # CONFIG_TABLET_USB_HANWANG is not set # CONFIG_TABLET_USB_KBTAB is not set # CONFIG_TABLET_USB_PEGASUS is not set # CONFIG_TABLET_SERIAL_WACOM4 is not set CONFIG_INPUT_TOUCHSCREEN=y # CONFIG_TOUCHSCREEN_AD7879 is not set # CONFIG_TOUCHSCREEN_ATMEL_MXT is not set # CONFIG_TOUCHSCREEN_BU21013 is not set # CONFIG_TOUCHSCREEN_BU21029 is not set # CONFIG_TOUCHSCREEN_CHIPONE_ICN8505 is not set # CONFIG_TOUCHSCREEN_CY8CTMA140 is not set # CONFIG_TOUCHSCREEN_CYTTSP_CORE is not set # CONFIG_TOUCHSCREEN_CYTTSP4_CORE is not set # CONFIG_TOUCHSCREEN_DYNAPRO is not set # CONFIG_TOUCHSCREEN_HAMPSHIRE is not set # CONFIG_TOUCHSCREEN_EETI is not set # CONFIG_TOUCHSCREEN_EGALAX_SERIAL is not set # CONFIG_TOUCHSCREEN_EXC3000 is not set # CONFIG_TOUCHSCREEN_FUJITSU is not set # CONFIG_TOUCHSCREEN_HIDEEP is not set # CONFIG_TOUCHSCREEN_HYCON_HY46XX is not set # CONFIG_TOUCHSCREEN_ILI210X is not set # CONFIG_TOUCHSCREEN_ILITEK is not set # CONFIG_TOUCHSCREEN_S6SY761 is not set # CONFIG_TOUCHSCREEN_GUNZE is not set # CONFIG_TOUCHSCREEN_EKTF2127 is not set # CONFIG_TOUCHSCREEN_ELAN is not set # CONFIG_TOUCHSCREEN_ELO is not set # CONFIG_TOUCHSCREEN_WACOM_W8001 is not set # CONFIG_TOUCHSCREEN_WACOM_I2C is not set # CONFIG_TOUCHSCREEN_MAX11801 is not set # CONFIG_TOUCHSCREEN_MCS5000 is not set # CONFIG_TOUCHSCREEN_MMS114 is not set # CONFIG_TOUCHSCREEN_MELFAS_MIP4 is not set # CONFIG_TOUCHSCREEN_MTOUCH is not set # CONFIG_TOUCHSCREEN_IMAGIS is not set # CONFIG_TOUCHSCREEN_INEXIO is not set # CONFIG_TOUCHSCREEN_MK712 is not set # CONFIG_TOUCHSCREEN_PENMOUNT is not set # CONFIG_TOUCHSCREEN_EDT_FT5X06 is not set # CONFIG_TOUCHSCREEN_TOUCHRIGHT is not set # CONFIG_TOUCHSCREEN_TOUCHWIN is not set # CONFIG_TOUCHSCREEN_PIXCIR is not set # CONFIG_TOUCHSCREEN_WDT87XX_I2C is not set # CONFIG_TOUCHSCREEN_USB_COMPOSITE is not set # CONFIG_TOUCHSCREEN_TOUCHIT213 is not set # CONFIG_TOUCHSCREEN_TSC_SERIO is not set # CONFIG_TOUCHSCREEN_TSC2004 is not set # CONFIG_TOUCHSCREEN_TSC2007 is not set # CONFIG_TOUCHSCREEN_SILEAD is not set # CONFIG_TOUCHSCREEN_ST1232 is not set # CONFIG_TOUCHSCREEN_STMFTS is not set # CONFIG_TOUCHSCREEN_SX8654 is not set # CONFIG_TOUCHSCREEN_TPS6507X is not set # CONFIG_TOUCHSCREEN_ZET6223 is not set # CONFIG_TOUCHSCREEN_ROHM_BU21023 is not set # CONFIG_TOUCHSCREEN_IQS5XX is not set # CONFIG_TOUCHSCREEN_ZINITIX is not set CONFIG_INPUT_MISC=y # CONFIG_INPUT_AD714X is not set # CONFIG_INPUT_BMA150 is not set # CONFIG_INPUT_E3X0_BUTTON is not set # CONFIG_INPUT_PCSPKR is not set # CONFIG_INPUT_MMA8450 is not set # CONFIG_INPUT_APANEL is not set # CONFIG_INPUT_ATLAS_BTNS is not set # CONFIG_INPUT_ATI_REMOTE2 is not set # CONFIG_INPUT_KEYSPAN_REMOTE is not set # CONFIG_INPUT_KXTJ9 is not set # CONFIG_INPUT_POWERMATE is not set # CONFIG_INPUT_YEALINK is not set # CONFIG_INPUT_CM109 is not set # CONFIG_INPUT_UINPUT is not set # CONFIG_INPUT_PCF8574 is not set # CONFIG_INPUT_DA7280_HAPTICS is not set # CONFIG_INPUT_ADXL34X is not set # CONFIG_INPUT_IMS_PCU is not set # CONFIG_INPUT_IQS269A is not set # CONFIG_INPUT_IQS626A is not set # CONFIG_INPUT_IQS7222 is not set # CONFIG_INPUT_CMA3000 is not set # CONFIG_INPUT_IDEAPAD_SLIDEBAR is not set # CONFIG_INPUT_DRV2665_HAPTICS is not set # CONFIG_INPUT_DRV2667_HAPTICS is not set # CONFIG_RMI4_CORE is not set # # Hardware I/O ports # CONFIG_SERIO=y CONFIG_ARCH_MIGHT_HAVE_PC_SERIO=y CONFIG_SERIO_I8042=y CONFIG_SERIO_SERPORT=y # CONFIG_SERIO_CT82C710 is not set # CONFIG_SERIO_PCIPS2 is not set CONFIG_SERIO_LIBPS2=y # CONFIG_SERIO_RAW is not set # CONFIG_SERIO_ALTERA_PS2 is not set # CONFIG_SERIO_PS2MULT is not set # CONFIG_SERIO_ARC_PS2 is not set # CONFIG_USERIO is not set # CONFIG_GAMEPORT is not set # end of Hardware I/O ports # end of Input device support # # Character devices # CONFIG_TTY=y CONFIG_VT=y CONFIG_CONSOLE_TRANSLATIONS=y CONFIG_VT_CONSOLE=y CONFIG_VT_CONSOLE_SLEEP=y CONFIG_HW_CONSOLE=y # CONFIG_VT_HW_CONSOLE_BINDING is not set CONFIG_UNIX98_PTYS=y # CONFIG_LEGACY_PTYS is not set CONFIG_LDISC_AUTOLOAD=y # # Serial drivers # CONFIG_SERIAL_EARLYCON=y CONFIG_SERIAL_8250=y CONFIG_SERIAL_8250_DEPRECATED_OPTIONS=y CONFIG_SERIAL_8250_PNP=y # CONFIG_SERIAL_8250_16550A_VARIANTS is not set # CONFIG_SERIAL_8250_FINTEK is not set CONFIG_SERIAL_8250_CONSOLE=y CONFIG_SERIAL_8250_DMA=y CONFIG_SERIAL_8250_PCI=y CONFIG_SERIAL_8250_EXAR=y # CONFIG_SERIAL_8250_CS is not set CONFIG_SERIAL_8250_NR_UARTS=32 CONFIG_SERIAL_8250_RUNTIME_UARTS=4 CONFIG_SERIAL_8250_EXTENDED=y CONFIG_SERIAL_8250_MANY_PORTS=y CONFIG_SERIAL_8250_SHARE_IRQ=y CONFIG_SERIAL_8250_DETECT_IRQ=y CONFIG_SERIAL_8250_RSA=y CONFIG_SERIAL_8250_DWLIB=y # CONFIG_SERIAL_8250_DW is not set # CONFIG_SERIAL_8250_RT288X is not set CONFIG_SERIAL_8250_LPSS=y CONFIG_SERIAL_8250_MID=y CONFIG_SERIAL_8250_PERICOM=y # # Non-8250 serial port support # # CONFIG_SERIAL_UARTLITE is not set CONFIG_SERIAL_CORE=y CONFIG_SERIAL_CORE_CONSOLE=y # CONFIG_SERIAL_JSM is not set # CONFIG_SERIAL_LANTIQ is not set # CONFIG_SERIAL_SCCNXP is not set # CONFIG_SERIAL_SC16IS7XX is not set # CONFIG_SERIAL_ALTERA_JTAGUART is not set # CONFIG_SERIAL_ALTERA_UART is not set # CONFIG_SERIAL_ARC is not set # CONFIG_SERIAL_RP2 is not set # CONFIG_SERIAL_FSL_LPUART is not set # CONFIG_SERIAL_FSL_LINFLEXUART is not set # end of Serial drivers CONFIG_SERIAL_NONSTANDARD=y # CONFIG_MOXA_INTELLIO is not set # CONFIG_MOXA_SMARTIO is not set # CONFIG_SYNCLINK_GT is not set # CONFIG_N_HDLC is not set # CONFIG_N_GSM is not set # CONFIG_NOZOMI is not set # CONFIG_NULL_TTY is not set CONFIG_HVC_DRIVER=y # CONFIG_SERIAL_DEV_BUS is not set CONFIG_VIRTIO_CONSOLE=y # CONFIG_IPMI_HANDLER is not set CONFIG_HW_RANDOM=y # CONFIG_HW_RANDOM_TIMERIOMEM is not set # CONFIG_HW_RANDOM_INTEL is not set # CONFIG_HW_RANDOM_AMD is not set # CONFIG_HW_RANDOM_BA431 is not set CONFIG_HW_RANDOM_VIA=y # CONFIG_HW_RANDOM_VIRTIO is not set # CONFIG_HW_RANDOM_XIPHERA is not set # CONFIG_APPLICOM is not set # # PCMCIA character devices # # CONFIG_SYNCLINK_CS is not set # CONFIG_CARDMAN_4000 is not set # CONFIG_CARDMAN_4040 is not set # CONFIG_SCR24X is not set # CONFIG_IPWIRELESS is not set # end of PCMCIA character devices # CONFIG_MWAVE is not set CONFIG_DEVMEM=y CONFIG_NVRAM=y CONFIG_DEVPORT=y CONFIG_HPET=y # CONFIG_HPET_MMAP is not set # CONFIG_HANGCHECK_TIMER is not set # CONFIG_TCG_TPM is not set # CONFIG_TELCLOCK is not set # CONFIG_XILLYBUS is not set # CONFIG_XILLYUSB is not set CONFIG_RANDOM_TRUST_CPU=y CONFIG_RANDOM_TRUST_BOOTLOADER=y # end of Character devices # # I2C support # CONFIG_I2C=y CONFIG_ACPI_I2C_OPREGION=y CONFIG_I2C_BOARDINFO=y CONFIG_I2C_COMPAT=y # CONFIG_I2C_CHARDEV is not set # CONFIG_I2C_MUX is not set CONFIG_I2C_HELPER_AUTO=y CONFIG_I2C_SMBUS=y CONFIG_I2C_ALGOBIT=y # # I2C Hardware Bus support # # # PC SMBus host controller drivers # # CONFIG_I2C_ALI1535 is not set # CONFIG_I2C_ALI1563 is not set # CONFIG_I2C_ALI15X3 is not set # CONFIG_I2C_AMD756 is not set # CONFIG_I2C_AMD8111 is not set # CONFIG_I2C_AMD_MP2 is not set CONFIG_I2C_I801=y # CONFIG_I2C_ISCH is not set # CONFIG_I2C_ISMT is not set # CONFIG_I2C_PIIX4 is not set # CONFIG_I2C_NFORCE2 is not set # CONFIG_I2C_NVIDIA_GPU is not set # CONFIG_I2C_SIS5595 is not set # CONFIG_I2C_SIS630 is not set # CONFIG_I2C_SIS96X is not set # CONFIG_I2C_VIA is not set # CONFIG_I2C_VIAPRO is not set # # ACPI drivers # # CONFIG_I2C_SCMI is not set # # I2C system bus drivers (mostly embedded / system-on-chip) # # CONFIG_I2C_DESIGNWARE_PCI is not set # CONFIG_I2C_OCORES is not set # CONFIG_I2C_PCA_PLATFORM is not set # CONFIG_I2C_SIMTEC is not set # CONFIG_I2C_XILINX is not set # # External I2C/SMBus adapter drivers # # CONFIG_I2C_DIOLAN_U2C is not set # CONFIG_I2C_CP2615 is not set # CONFIG_I2C_PCI1XXXX is not set # CONFIG_I2C_ROBOTFUZZ_OSIF is not set # CONFIG_I2C_TAOS_EVM is not set # CONFIG_I2C_TINY_USB is not set # # Other I2C/SMBus bus drivers # # CONFIG_I2C_MLXCPLD is not set # CONFIG_I2C_VIRTIO is not set # end of I2C Hardware Bus support # CONFIG_I2C_STUB is not set # CONFIG_I2C_SLAVE is not set # CONFIG_I2C_DEBUG_CORE is not set # CONFIG_I2C_DEBUG_ALGO is not set # CONFIG_I2C_DEBUG_BUS is not set # end of I2C support # CONFIG_I3C is not set # CONFIG_SPI is not set # CONFIG_SPMI is not set # CONFIG_HSI is not set CONFIG_PPS=y # CONFIG_PPS_DEBUG is not set # # PPS clients support # # CONFIG_PPS_CLIENT_KTIMER is not set # CONFIG_PPS_CLIENT_LDISC is not set # CONFIG_PPS_CLIENT_GPIO is not set # # PPS generators support # # # PTP clock support # CONFIG_PTP_1588_CLOCK=y CONFIG_PTP_1588_CLOCK_OPTIONAL=y # # Enable PHYLIB and NETWORK_PHY_TIMESTAMPING to see the additional clocks. # CONFIG_PTP_1588_CLOCK_KVM=y # CONFIG_PTP_1588_CLOCK_IDT82P33 is not set # CONFIG_PTP_1588_CLOCK_IDTCM is not set # CONFIG_PTP_1588_CLOCK_VMW is not set # end of PTP clock support # CONFIG_PINCTRL is not set # CONFIG_GPIOLIB is not set # CONFIG_W1 is not set # CONFIG_POWER_RESET is not set CONFIG_POWER_SUPPLY=y # CONFIG_POWER_SUPPLY_DEBUG is not set CONFIG_POWER_SUPPLY_HWMON=y # CONFIG_PDA_POWER is not set # CONFIG_IP5XXX_POWER is not set # CONFIG_TEST_POWER is not set # CONFIG_CHARGER_ADP5061 is not set # CONFIG_BATTERY_CW2015 is not set # CONFIG_BATTERY_DS2780 is not set # CONFIG_BATTERY_DS2781 is not set # CONFIG_BATTERY_DS2782 is not set # CONFIG_BATTERY_SAMSUNG_SDI is not set # CONFIG_BATTERY_SBS is not set # CONFIG_CHARGER_SBS is not set # CONFIG_BATTERY_BQ27XXX is not set # CONFIG_BATTERY_MAX17040 is not set # CONFIG_BATTERY_MAX17042 is not set # CONFIG_CHARGER_MAX8903 is not set # CONFIG_CHARGER_LP8727 is not set # CONFIG_CHARGER_LTC4162L is not set # CONFIG_CHARGER_MAX77976 is not set # CONFIG_CHARGER_BQ2415X is not set # CONFIG_BATTERY_GAUGE_LTC2941 is not set # CONFIG_BATTERY_GOLDFISH is not set # CONFIG_BATTERY_RT5033 is not set # CONFIG_CHARGER_BD99954 is not set # CONFIG_BATTERY_UG3105 is not set CONFIG_HWMON=y # CONFIG_HWMON_DEBUG_CHIP is not set # # Native drivers # # CONFIG_SENSORS_ABITUGURU is not set # CONFIG_SENSORS_ABITUGURU3 is not set # CONFIG_SENSORS_AD7414 is not set # CONFIG_SENSORS_AD7418 is not set # CONFIG_SENSORS_ADM1021 is not set # CONFIG_SENSORS_ADM1025 is not set # CONFIG_SENSORS_ADM1026 is not set # CONFIG_SENSORS_ADM1029 is not set # CONFIG_SENSORS_ADM1031 is not set # CONFIG_SENSORS_ADM1177 is not set # CONFIG_SENSORS_ADM9240 is not set # CONFIG_SENSORS_ADT7410 is not set # CONFIG_SENSORS_ADT7411 is not set # CONFIG_SENSORS_ADT7462 is not set # CONFIG_SENSORS_ADT7470 is not set # CONFIG_SENSORS_ADT7475 is not set # CONFIG_SENSORS_AHT10 is not set # CONFIG_SENSORS_AQUACOMPUTER_D5NEXT is not set # CONFIG_SENSORS_AS370 is not set # CONFIG_SENSORS_ASC7621 is not set # CONFIG_SENSORS_AXI_FAN_CONTROL is not set # CONFIG_SENSORS_K8TEMP is not set # CONFIG_SENSORS_K10TEMP is not set # CONFIG_SENSORS_FAM15H_POWER is not set # CONFIG_SENSORS_APPLESMC is not set # CONFIG_SENSORS_ASB100 is not set # CONFIG_SENSORS_ATXP1 is not set # CONFIG_SENSORS_CORSAIR_CPRO is not set # CONFIG_SENSORS_CORSAIR_PSU is not set # CONFIG_SENSORS_DRIVETEMP is not set # CONFIG_SENSORS_DS620 is not set # CONFIG_SENSORS_DS1621 is not set # CONFIG_SENSORS_DELL_SMM is not set # CONFIG_SENSORS_I5K_AMB is not set # CONFIG_SENSORS_F71805F is not set # CONFIG_SENSORS_F71882FG is not set # CONFIG_SENSORS_F75375S is not set # CONFIG_SENSORS_FSCHMD is not set # CONFIG_SENSORS_FTSTEUTATES is not set # CONFIG_SENSORS_GL518SM is not set # CONFIG_SENSORS_GL520SM is not set # CONFIG_SENSORS_G760A is not set # CONFIG_SENSORS_G762 is not set # CONFIG_SENSORS_HIH6130 is not set # CONFIG_SENSORS_I5500 is not set # CONFIG_SENSORS_CORETEMP is not set # CONFIG_SENSORS_IT87 is not set # CONFIG_SENSORS_JC42 is not set # CONFIG_SENSORS_POWR1220 is not set # CONFIG_SENSORS_LINEAGE is not set # CONFIG_SENSORS_LTC2945 is not set # CONFIG_SENSORS_LTC2947_I2C is not set # CONFIG_SENSORS_LTC2990 is not set # CONFIG_SENSORS_LTC4151 is not set # CONFIG_SENSORS_LTC4215 is not set # CONFIG_SENSORS_LTC4222 is not set # CONFIG_SENSORS_LTC4245 is not set # CONFIG_SENSORS_LTC4260 is not set # CONFIG_SENSORS_LTC4261 is not set # CONFIG_SENSORS_MAX127 is not set # CONFIG_SENSORS_MAX16065 is not set # CONFIG_SENSORS_MAX1619 is not set # CONFIG_SENSORS_MAX1668 is not set # CONFIG_SENSORS_MAX197 is not set # CONFIG_SENSORS_MAX31730 is not set # CONFIG_SENSORS_MAX31760 is not set # CONFIG_SENSORS_MAX6620 is not set # CONFIG_SENSORS_MAX6621 is not set # CONFIG_SENSORS_MAX6639 is not set # CONFIG_SENSORS_MAX6642 is not set # CONFIG_SENSORS_MAX6650 is not set # CONFIG_SENSORS_MAX6697 is not set # CONFIG_SENSORS_MAX31790 is not set # CONFIG_SENSORS_MCP3021 is not set # CONFIG_SENSORS_TC654 is not set # CONFIG_SENSORS_TPS23861 is not set # CONFIG_SENSORS_MR75203 is not set # CONFIG_SENSORS_LM63 is not set # CONFIG_SENSORS_LM73 is not set # CONFIG_SENSORS_LM75 is not set # CONFIG_SENSORS_LM77 is not set # CONFIG_SENSORS_LM78 is not set # CONFIG_SENSORS_LM80 is not set # CONFIG_SENSORS_LM83 is not set # CONFIG_SENSORS_LM85 is not set # CONFIG_SENSORS_LM87 is not set # CONFIG_SENSORS_LM90 is not set # CONFIG_SENSORS_LM92 is not set # CONFIG_SENSORS_LM93 is not set # CONFIG_SENSORS_LM95234 is not set # CONFIG_SENSORS_LM95241 is not set # CONFIG_SENSORS_LM95245 is not set # CONFIG_SENSORS_PC87360 is not set # CONFIG_SENSORS_PC87427 is not set # CONFIG_SENSORS_NCT6683 is not set # CONFIG_SENSORS_NCT6775 is not set # CONFIG_SENSORS_NCT6775_I2C is not set # CONFIG_SENSORS_NCT7802 is not set # CONFIG_SENSORS_NCT7904 is not set # CONFIG_SENSORS_NPCM7XX is not set # CONFIG_SENSORS_NZXT_KRAKEN2 is not set # CONFIG_SENSORS_NZXT_SMART2 is not set # CONFIG_SENSORS_PCF8591 is not set # CONFIG_PMBUS is not set # CONFIG_SENSORS_SBTSI is not set # CONFIG_SENSORS_SBRMI is not set # CONFIG_SENSORS_SHT21 is not set # CONFIG_SENSORS_SHT3x is not set # CONFIG_SENSORS_SHT4x is not set # CONFIG_SENSORS_SHTC1 is not set # CONFIG_SENSORS_SIS5595 is not set # CONFIG_SENSORS_DME1737 is not set # CONFIG_SENSORS_EMC1403 is not set # CONFIG_SENSORS_EMC2103 is not set # CONFIG_SENSORS_EMC2305 is not set # CONFIG_SENSORS_EMC6W201 is not set # CONFIG_SENSORS_SMSC47M1 is not set # CONFIG_SENSORS_SMSC47M192 is not set # CONFIG_SENSORS_SMSC47B397 is not set # CONFIG_SENSORS_SCH5627 is not set # CONFIG_SENSORS_SCH5636 is not set # CONFIG_SENSORS_STTS751 is not set # CONFIG_SENSORS_SMM665 is not set # CONFIG_SENSORS_ADC128D818 is not set # CONFIG_SENSORS_ADS7828 is not set # CONFIG_SENSORS_AMC6821 is not set # CONFIG_SENSORS_INA209 is not set # CONFIG_SENSORS_INA2XX is not set # CONFIG_SENSORS_INA238 is not set # CONFIG_SENSORS_INA3221 is not set # CONFIG_SENSORS_TC74 is not set # CONFIG_SENSORS_THMC50 is not set # CONFIG_SENSORS_TMP102 is not set # CONFIG_SENSORS_TMP103 is not set # CONFIG_SENSORS_TMP108 is not set # CONFIG_SENSORS_TMP401 is not set # CONFIG_SENSORS_TMP421 is not set # CONFIG_SENSORS_TMP464 is not set # CONFIG_SENSORS_TMP513 is not set # CONFIG_SENSORS_VIA_CPUTEMP is not set # CONFIG_SENSORS_VIA686A is not set # CONFIG_SENSORS_VT1211 is not set # CONFIG_SENSORS_VT8231 is not set # CONFIG_SENSORS_W83773G is not set # CONFIG_SENSORS_W83781D is not set # CONFIG_SENSORS_W83791D is not set # CONFIG_SENSORS_W83792D is not set # CONFIG_SENSORS_W83793 is not set # CONFIG_SENSORS_W83795 is not set # CONFIG_SENSORS_W83L785TS is not set # CONFIG_SENSORS_W83L786NG is not set # CONFIG_SENSORS_W83627HF is not set # CONFIG_SENSORS_W83627EHF is not set # CONFIG_SENSORS_XGENE is not set # # ACPI drivers # # CONFIG_SENSORS_ACPI_POWER is not set # CONFIG_SENSORS_ATK0110 is not set # CONFIG_SENSORS_ASUS_WMI is not set # CONFIG_SENSORS_ASUS_EC is not set CONFIG_THERMAL=y # CONFIG_THERMAL_NETLINK is not set # CONFIG_THERMAL_STATISTICS is not set CONFIG_THERMAL_EMERGENCY_POWEROFF_DELAY_MS=0 CONFIG_THERMAL_HWMON=y CONFIG_THERMAL_WRITABLE_TRIPS=y CONFIG_THERMAL_DEFAULT_GOV_STEP_WISE=y # CONFIG_THERMAL_DEFAULT_GOV_FAIR_SHARE is not set # CONFIG_THERMAL_DEFAULT_GOV_USER_SPACE is not set # CONFIG_THERMAL_GOV_FAIR_SHARE is not set CONFIG_THERMAL_GOV_STEP_WISE=y # CONFIG_THERMAL_GOV_BANG_BANG is not set CONFIG_THERMAL_GOV_USER_SPACE=y # CONFIG_THERMAL_EMULATION is not set # # Intel thermal drivers # # CONFIG_INTEL_POWERCLAMP is not set CONFIG_X86_THERMAL_VECTOR=y CONFIG_X86_PKG_TEMP_THERMAL=m # CONFIG_INTEL_SOC_DTS_THERMAL is not set # # ACPI INT340X thermal drivers # # CONFIG_INT340X_THERMAL is not set # end of ACPI INT340X thermal drivers # CONFIG_INTEL_PCH_THERMAL is not set # CONFIG_INTEL_TCC_COOLING is not set # CONFIG_INTEL_MENLOW is not set # CONFIG_INTEL_HFI_THERMAL is not set # end of Intel thermal drivers CONFIG_WATCHDOG=y # CONFIG_WATCHDOG_CORE is not set # CONFIG_WATCHDOG_NOWAYOUT is not set CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED=y CONFIG_WATCHDOG_OPEN_TIMEOUT=0 # CONFIG_WATCHDOG_SYSFS is not set # CONFIG_WATCHDOG_HRTIMER_PRETIMEOUT is not set # # Watchdog Pretimeout Governors # # # Watchdog Device Drivers # # CONFIG_SOFT_WATCHDOG is not set # CONFIG_WDAT_WDT is not set # CONFIG_XILINX_WATCHDOG is not set # CONFIG_ZIIRAVE_WATCHDOG is not set # CONFIG_CADENCE_WATCHDOG is not set # CONFIG_DW_WATCHDOG is not set # CONFIG_MAX63XX_WATCHDOG is not set # CONFIG_ACQUIRE_WDT is not set # CONFIG_ADVANTECH_WDT is not set # CONFIG_ALIM1535_WDT is not set # CONFIG_ALIM7101_WDT is not set # CONFIG_EBC_C384_WDT is not set # CONFIG_EXAR_WDT is not set # CONFIG_F71808E_WDT is not set # CONFIG_SP5100_TCO is not set # CONFIG_SBC_FITPC2_WATCHDOG is not set # CONFIG_EUROTECH_WDT is not set # CONFIG_IB700_WDT is not set # CONFIG_IBMASR is not set # CONFIG_WAFER_WDT is not set # CONFIG_I6300ESB_WDT is not set # CONFIG_IE6XX_WDT is not set # CONFIG_ITCO_WDT is not set # CONFIG_IT8712F_WDT is not set # CONFIG_IT87_WDT is not set # CONFIG_HP_WATCHDOG is not set # CONFIG_SC1200_WDT is not set # CONFIG_PC87413_WDT is not set # CONFIG_NV_TCO is not set # CONFIG_60XX_WDT is not set # CONFIG_CPU5_WDT is not set # CONFIG_SMSC_SCH311X_WDT is not set # CONFIG_SMSC37B787_WDT is not set # CONFIG_TQMX86_WDT is not set # CONFIG_VIA_WDT is not set # CONFIG_W83627HF_WDT is not set # CONFIG_W83877F_WDT is not set # CONFIG_W83977F_WDT is not set # CONFIG_MACHZ_WDT is not set # CONFIG_SBC_EPX_C3_WATCHDOG is not set # CONFIG_NI903X_WDT is not set # CONFIG_NIC7018_WDT is not set # # PCI-based Watchdog Cards # # CONFIG_PCIPCWATCHDOG is not set # CONFIG_WDTPCI is not set # # USB-based Watchdog Cards # # CONFIG_USBPCWATCHDOG is not set CONFIG_SSB_POSSIBLE=y # CONFIG_SSB is not set CONFIG_BCMA_POSSIBLE=y # CONFIG_BCMA is not set # # Multifunction device drivers # # CONFIG_MFD_AS3711 is not set # CONFIG_PMIC_ADP5520 is not set # CONFIG_MFD_BCM590XX is not set # CONFIG_MFD_BD9571MWV is not set # CONFIG_MFD_AXP20X_I2C is not set # CONFIG_MFD_MADERA is not set # CONFIG_PMIC_DA903X is not set # CONFIG_MFD_DA9052_I2C is not set # CONFIG_MFD_DA9055 is not set # CONFIG_MFD_DA9062 is not set # CONFIG_MFD_DA9063 is not set # CONFIG_MFD_DA9150 is not set # CONFIG_MFD_DLN2 is not set # CONFIG_MFD_MC13XXX_I2C is not set # CONFIG_MFD_MP2629 is not set # CONFIG_HTC_PASIC3 is not set # CONFIG_LPC_ICH is not set # CONFIG_LPC_SCH is not set # CONFIG_MFD_INTEL_LPSS_ACPI is not set # CONFIG_MFD_INTEL_LPSS_PCI is not set # CONFIG_MFD_INTEL_PMC_BXT is not set # CONFIG_MFD_IQS62X is not set # CONFIG_MFD_JANZ_CMODIO is not set # CONFIG_MFD_KEMPLD is not set # CONFIG_MFD_88PM800 is not set # CONFIG_MFD_88PM805 is not set # CONFIG_MFD_88PM860X is not set # CONFIG_MFD_MAX14577 is not set # CONFIG_MFD_MAX77693 is not set # CONFIG_MFD_MAX77843 is not set # CONFIG_MFD_MAX8907 is not set # CONFIG_MFD_MAX8925 is not set # CONFIG_MFD_MAX8997 is not set # CONFIG_MFD_MAX8998 is not set # CONFIG_MFD_MT6360 is not set # CONFIG_MFD_MT6370 is not set # CONFIG_MFD_MT6397 is not set # CONFIG_MFD_MENF21BMC is not set # CONFIG_MFD_VIPERBOARD is not set # CONFIG_MFD_RETU is not set # CONFIG_MFD_PCF50633 is not set # CONFIG_MFD_SY7636A is not set # CONFIG_MFD_RDC321X is not set # CONFIG_MFD_RT4831 is not set # CONFIG_MFD_RT5033 is not set # CONFIG_MFD_RT5120 is not set # CONFIG_MFD_RC5T583 is not set # CONFIG_MFD_SI476X_CORE is not set # CONFIG_MFD_SM501 is not set # CONFIG_MFD_SKY81452 is not set # CONFIG_MFD_SYSCON is not set # CONFIG_MFD_TI_AM335X_TSCADC is not set # CONFIG_MFD_LP3943 is not set # CONFIG_MFD_LP8788 is not set # CONFIG_MFD_TI_LMU is not set # CONFIG_MFD_PALMAS is not set # CONFIG_TPS6105X is not set # CONFIG_TPS6507X is not set # CONFIG_MFD_TPS65086 is not set # CONFIG_MFD_TPS65090 is not set # CONFIG_MFD_TI_LP873X is not set # CONFIG_MFD_TPS6586X is not set # CONFIG_MFD_TPS65912_I2C is not set # CONFIG_TWL4030_CORE is not set # CONFIG_TWL6040_CORE is not set # CONFIG_MFD_WL1273_CORE is not set # CONFIG_MFD_LM3533 is not set # CONFIG_MFD_TQMX86 is not set # CONFIG_MFD_VX855 is not set # CONFIG_MFD_ARIZONA_I2C is not set # CONFIG_MFD_WM8400 is not set # CONFIG_MFD_WM831X_I2C is not set # CONFIG_MFD_WM8350_I2C is not set # CONFIG_MFD_WM8994 is not set # CONFIG_MFD_ATC260X_I2C is not set # end of Multifunction device drivers # CONFIG_REGULATOR is not set # CONFIG_RC_CORE is not set # # CEC support # # CONFIG_MEDIA_CEC_SUPPORT is not set # end of CEC support # CONFIG_MEDIA_SUPPORT is not set # # Graphics support # CONFIG_APERTURE_HELPERS=y CONFIG_AGP=y CONFIG_AGP_AMD64=y CONFIG_AGP_INTEL=y # CONFIG_AGP_SIS is not set # CONFIG_AGP_VIA is not set CONFIG_INTEL_GTT=y # CONFIG_VGA_SWITCHEROO is not set CONFIG_DRM=y CONFIG_DRM_MIPI_DSI=y # CONFIG_DRM_DEBUG_MM is not set CONFIG_DRM_KMS_HELPER=y # CONFIG_DRM_LOAD_EDID_FIRMWARE is not set CONFIG_DRM_DISPLAY_HELPER=y CONFIG_DRM_DISPLAY_DP_HELPER=y CONFIG_DRM_DISPLAY_HDCP_HELPER=y CONFIG_DRM_DISPLAY_HDMI_HELPER=y # CONFIG_DRM_DP_AUX_CHARDEV is not set # CONFIG_DRM_DP_CEC is not set CONFIG_DRM_TTM=y CONFIG_DRM_BUDDY=y CONFIG_DRM_GEM_SHMEM_HELPER=y # # I2C encoder or helper chips # # CONFIG_DRM_I2C_CH7006 is not set # CONFIG_DRM_I2C_SIL164 is not set # CONFIG_DRM_I2C_NXP_TDA998X is not set # CONFIG_DRM_I2C_NXP_TDA9950 is not set # end of I2C encoder or helper chips # # ARM devices # # end of ARM devices # CONFIG_DRM_RADEON is not set # CONFIG_DRM_AMDGPU is not set # CONFIG_DRM_NOUVEAU is not set CONFIG_DRM_I915=y CONFIG_DRM_I915_FORCE_PROBE="" CONFIG_DRM_I915_CAPTURE_ERROR=y CONFIG_DRM_I915_COMPRESS_ERROR=y CONFIG_DRM_I915_USERPTR=y CONFIG_DRM_I915_REQUEST_TIMEOUT=20000 CONFIG_DRM_I915_FENCE_TIMEOUT=10000 CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND=250 CONFIG_DRM_I915_HEARTBEAT_INTERVAL=2500 CONFIG_DRM_I915_PREEMPT_TIMEOUT=640 CONFIG_DRM_I915_MAX_REQUEST_BUSYWAIT=8000 CONFIG_DRM_I915_STOP_TIMEOUT=100 CONFIG_DRM_I915_TIMESLICE_DURATION=1 # CONFIG_DRM_VGEM is not set # CONFIG_DRM_VKMS is not set # CONFIG_DRM_VMWGFX is not set # CONFIG_DRM_GMA500 is not set # CONFIG_DRM_UDL is not set # CONFIG_DRM_AST is not set # CONFIG_DRM_MGAG200 is not set # CONFIG_DRM_QXL is not set CONFIG_DRM_VIRTIO_GPU=y CONFIG_DRM_PANEL=y # # Display Panels # # CONFIG_DRM_PANEL_RASPBERRYPI_TOUCHSCREEN is not set # end of Display Panels CONFIG_DRM_BRIDGE=y CONFIG_DRM_PANEL_BRIDGE=y # # Display Interface Bridges # # CONFIG_DRM_ANALOGIX_ANX78XX is not set # end of Display Interface Bridges # CONFIG_DRM_ETNAVIV is not set # CONFIG_DRM_BOCHS is not set # CONFIG_DRM_CIRRUS_QEMU is not set # CONFIG_DRM_GM12U320 is not set # CONFIG_DRM_SIMPLEDRM is not set # CONFIG_DRM_VBOXVIDEO is not set # CONFIG_DRM_GUD is not set # CONFIG_DRM_SSD130X is not set # CONFIG_DRM_LEGACY is not set CONFIG_DRM_PANEL_ORIENTATION_QUIRKS=y CONFIG_DRM_NOMODESET=y # # Frame buffer Devices # CONFIG_FB_CMDLINE=y # CONFIG_FB is not set # end of Frame buffer Devices # # Backlight & LCD device support # # CONFIG_LCD_CLASS_DEVICE is not set CONFIG_BACKLIGHT_CLASS_DEVICE=y # CONFIG_BACKLIGHT_APPLE is not set # CONFIG_BACKLIGHT_QCOM_WLED is not set # CONFIG_BACKLIGHT_SAHARA is not set # CONFIG_BACKLIGHT_ADP8860 is not set # CONFIG_BACKLIGHT_ADP8870 is not set # CONFIG_BACKLIGHT_LM3639 is not set # CONFIG_BACKLIGHT_LV5207LP is not set # CONFIG_BACKLIGHT_BD6107 is not set # CONFIG_BACKLIGHT_ARCXCNN is not set # end of Backlight & LCD device support CONFIG_HDMI=y # # Console display driver support # CONFIG_VGA_CONSOLE=y CONFIG_DUMMY_CONSOLE=y CONFIG_DUMMY_CONSOLE_COLUMNS=80 CONFIG_DUMMY_CONSOLE_ROWS=25 # end of Console display driver support # end of Graphics support CONFIG_SOUND=y CONFIG_SND=y CONFIG_SND_TIMER=y CONFIG_SND_PCM=y CONFIG_SND_HWDEP=y CONFIG_SND_SEQ_DEVICE=y CONFIG_SND_JACK=y CONFIG_SND_JACK_INPUT_DEV=y # CONFIG_SND_OSSEMUL is not set CONFIG_SND_PCM_TIMER=y CONFIG_SND_HRTIMER=y # CONFIG_SND_DYNAMIC_MINORS is not set CONFIG_SND_SUPPORT_OLD_API=y CONFIG_SND_PROC_FS=y CONFIG_SND_VERBOSE_PROCFS=y # CONFIG_SND_VERBOSE_PRINTK is not set CONFIG_SND_CTL_FAST_LOOKUP=y # CONFIG_SND_DEBUG is not set # CONFIG_SND_CTL_INPUT_VALIDATION is not set CONFIG_SND_VMASTER=y CONFIG_SND_DMA_SGBUF=y CONFIG_SND_SEQUENCER=y CONFIG_SND_SEQ_DUMMY=y CONFIG_SND_SEQ_HRTIMER_DEFAULT=y CONFIG_SND_DRIVERS=y # CONFIG_SND_PCSP is not set # CONFIG_SND_DUMMY is not set # CONFIG_SND_ALOOP is not set # CONFIG_SND_VIRMIDI is not set # CONFIG_SND_MTPAV is not set # CONFIG_SND_SERIAL_U16550 is not set # CONFIG_SND_MPU401 is not set CONFIG_SND_PCI=y # CONFIG_SND_AD1889 is not set # CONFIG_SND_ALS300 is not set # CONFIG_SND_ALS4000 is not set # CONFIG_SND_ALI5451 is not set # CONFIG_SND_ASIHPI is not set # CONFIG_SND_ATIIXP is not set # CONFIG_SND_ATIIXP_MODEM is not set # CONFIG_SND_AU8810 is not set # CONFIG_SND_AU8820 is not set # CONFIG_SND_AU8830 is not set # CONFIG_SND_AW2 is not set # CONFIG_SND_AZT3328 is not set # CONFIG_SND_BT87X is not set # CONFIG_SND_CA0106 is not set # CONFIG_SND_CMIPCI is not set # CONFIG_SND_OXYGEN is not set # CONFIG_SND_CS4281 is not set # CONFIG_SND_CS46XX is not set # CONFIG_SND_CTXFI is not set # CONFIG_SND_DARLA20 is not set # CONFIG_SND_GINA20 is not set # CONFIG_SND_LAYLA20 is not set # CONFIG_SND_DARLA24 is not set # CONFIG_SND_GINA24 is not set # CONFIG_SND_LAYLA24 is not set # CONFIG_SND_MONA is not set # CONFIG_SND_MIA is not set # CONFIG_SND_ECHO3G is not set # CONFIG_SND_INDIGO is not set # CONFIG_SND_INDIGOIO is not set # CONFIG_SND_INDIGODJ is not set # CONFIG_SND_INDIGOIOX is not set # CONFIG_SND_INDIGODJX is not set # CONFIG_SND_EMU10K1 is not set # CONFIG_SND_EMU10K1X is not set # CONFIG_SND_ENS1370 is not set # CONFIG_SND_ENS1371 is not set # CONFIG_SND_ES1938 is not set # CONFIG_SND_ES1968 is not set # CONFIG_SND_FM801 is not set # CONFIG_SND_HDSP is not set # CONFIG_SND_HDSPM is not set # CONFIG_SND_ICE1712 is not set # CONFIG_SND_ICE1724 is not set # CONFIG_SND_INTEL8X0 is not set # CONFIG_SND_INTEL8X0M is not set # CONFIG_SND_KORG1212 is not set # CONFIG_SND_LOLA is not set # CONFIG_SND_LX6464ES is not set # CONFIG_SND_MAESTRO3 is not set # CONFIG_SND_MIXART is not set # CONFIG_SND_NM256 is not set # CONFIG_SND_PCXHR is not set # CONFIG_SND_RIPTIDE is not set # CONFIG_SND_RME32 is not set # CONFIG_SND_RME96 is not set # CONFIG_SND_RME9652 is not set # CONFIG_SND_SE6X is not set # CONFIG_SND_SONICVIBES is not set # CONFIG_SND_TRIDENT is not set # CONFIG_SND_VIA82XX is not set # CONFIG_SND_VIA82XX_MODEM is not set # CONFIG_SND_VIRTUOSO is not set # CONFIG_SND_VX222 is not set # CONFIG_SND_YMFPCI is not set # # HD-Audio # CONFIG_SND_HDA=y CONFIG_SND_HDA_INTEL=y CONFIG_SND_HDA_HWDEP=y # CONFIG_SND_HDA_RECONFIG is not set # CONFIG_SND_HDA_INPUT_BEEP is not set # CONFIG_SND_HDA_PATCH_LOADER is not set # CONFIG_SND_HDA_CODEC_REALTEK is not set # CONFIG_SND_HDA_CODEC_ANALOG is not set # CONFIG_SND_HDA_CODEC_SIGMATEL is not set # CONFIG_SND_HDA_CODEC_VIA is not set # CONFIG_SND_HDA_CODEC_HDMI is not set # CONFIG_SND_HDA_CODEC_CIRRUS is not set # CONFIG_SND_HDA_CODEC_CS8409 is not set # CONFIG_SND_HDA_CODEC_CONEXANT is not set # CONFIG_SND_HDA_CODEC_CA0110 is not set # CONFIG_SND_HDA_CODEC_CA0132 is not set # CONFIG_SND_HDA_CODEC_CMEDIA is not set # CONFIG_SND_HDA_CODEC_SI3054 is not set # CONFIG_SND_HDA_GENERIC is not set CONFIG_SND_HDA_POWER_SAVE_DEFAULT=0 # CONFIG_SND_HDA_INTEL_HDMI_SILENT_STREAM is not set # end of HD-Audio CONFIG_SND_HDA_CORE=y CONFIG_SND_HDA_COMPONENT=y CONFIG_SND_HDA_I915=y CONFIG_SND_HDA_PREALLOC_SIZE=0 CONFIG_SND_INTEL_NHLT=y CONFIG_SND_INTEL_DSP_CONFIG=y CONFIG_SND_INTEL_SOUNDWIRE_ACPI=y CONFIG_SND_USB=y # CONFIG_SND_USB_AUDIO is not set # CONFIG_SND_USB_UA101 is not set # CONFIG_SND_USB_USX2Y is not set # CONFIG_SND_USB_CAIAQ is not set # CONFIG_SND_USB_US122L is not set # CONFIG_SND_USB_6FIRE is not set # CONFIG_SND_USB_HIFACE is not set # CONFIG_SND_BCD2000 is not set # CONFIG_SND_USB_POD is not set # CONFIG_SND_USB_PODHD is not set # CONFIG_SND_USB_TONEPORT is not set # CONFIG_SND_USB_VARIAX is not set CONFIG_SND_PCMCIA=y # CONFIG_SND_VXPOCKET is not set # CONFIG_SND_PDAUDIOCF is not set # CONFIG_SND_SOC is not set CONFIG_SND_X86=y # CONFIG_HDMI_LPE_AUDIO is not set # CONFIG_SND_VIRTIO is not set # # HID support # CONFIG_HID=y # CONFIG_HID_BATTERY_STRENGTH is not set CONFIG_HIDRAW=y # CONFIG_UHID is not set CONFIG_HID_GENERIC=y # # Special HID drivers # CONFIG_HID_A4TECH=y # CONFIG_HID_ACCUTOUCH is not set # CONFIG_HID_ACRUX is not set CONFIG_HID_APPLE=y # CONFIG_HID_APPLEIR is not set # CONFIG_HID_ASUS is not set # CONFIG_HID_AUREAL is not set CONFIG_HID_BELKIN=y # CONFIG_HID_BETOP_FF is not set # CONFIG_HID_BIGBEN_FF is not set CONFIG_HID_CHERRY=y CONFIG_HID_CHICONY=y # CONFIG_HID_CORSAIR is not set # CONFIG_HID_COUGAR is not set # CONFIG_HID_MACALLY is not set # CONFIG_HID_PRODIKEYS is not set # CONFIG_HID_CMEDIA is not set # CONFIG_HID_CREATIVE_SB0540 is not set CONFIG_HID_CYPRESS=y # CONFIG_HID_DRAGONRISE is not set # CONFIG_HID_EMS_FF is not set # CONFIG_HID_ELAN is not set # CONFIG_HID_ELECOM is not set # CONFIG_HID_ELO is not set CONFIG_HID_EZKEY=y # CONFIG_HID_FT260 is not set # CONFIG_HID_GEMBIRD is not set # CONFIG_HID_GFRM is not set # CONFIG_HID_GLORIOUS is not set # CONFIG_HID_HOLTEK is not set # CONFIG_HID_VIVALDI is not set # CONFIG_HID_GT683R is not set # CONFIG_HID_KEYTOUCH is not set # CONFIG_HID_KYE is not set # CONFIG_HID_UCLOGIC is not set # CONFIG_HID_WALTOP is not set # CONFIG_HID_VIEWSONIC is not set # CONFIG_HID_VRC2 is not set # CONFIG_HID_XIAOMI is not set CONFIG_HID_GYRATION=y # CONFIG_HID_ICADE is not set CONFIG_HID_ITE=y # CONFIG_HID_JABRA is not set # CONFIG_HID_TWINHAN is not set CONFIG_HID_KENSINGTON=y # CONFIG_HID_LCPOWER is not set # CONFIG_HID_LED is not set # CONFIG_HID_LENOVO is not set # CONFIG_HID_LETSKETCH is not set CONFIG_HID_LOGITECH=y # CONFIG_HID_LOGITECH_DJ is not set # CONFIG_HID_LOGITECH_HIDPP is not set CONFIG_LOGITECH_FF=y # CONFIG_LOGIRUMBLEPAD2_FF is not set # CONFIG_LOGIG940_FF is not set CONFIG_LOGIWHEELS_FF=y # CONFIG_HID_MAGICMOUSE is not set # CONFIG_HID_MALTRON is not set # CONFIG_HID_MAYFLASH is not set # CONFIG_HID_MEGAWORLD_FF is not set CONFIG_HID_REDRAGON=y CONFIG_HID_MICROSOFT=y CONFIG_HID_MONTEREY=y # CONFIG_HID_MULTITOUCH is not set # CONFIG_HID_NINTENDO is not set # CONFIG_HID_NTI is not set CONFIG_HID_NTRIG=y # CONFIG_HID_ORTEK is not set CONFIG_HID_PANTHERLORD=y CONFIG_PANTHERLORD_FF=y # CONFIG_HID_PENMOUNT is not set CONFIG_HID_PETALYNX=y # CONFIG_HID_PICOLCD is not set # CONFIG_HID_PLANTRONICS is not set # CONFIG_HID_PXRC is not set # CONFIG_HID_RAZER is not set # CONFIG_HID_PRIMAX is not set # CONFIG_HID_RETRODE is not set # CONFIG_HID_ROCCAT is not set # CONFIG_HID_SAITEK is not set CONFIG_HID_SAMSUNG=y # CONFIG_HID_SEMITEK is not set # CONFIG_HID_SIGMAMICRO is not set CONFIG_HID_SONY=y # CONFIG_SONY_FF is not set # CONFIG_HID_SPEEDLINK is not set # CONFIG_HID_STEAM is not set # CONFIG_HID_STEELSERIES is not set CONFIG_HID_SUNPLUS=y # CONFIG_HID_RMI is not set # CONFIG_HID_GREENASIA is not set # CONFIG_HID_SMARTJOYPLUS is not set # CONFIG_HID_TIVO is not set CONFIG_HID_TOPSEED=y # CONFIG_HID_TOPRE is not set # CONFIG_HID_THINGM is not set # CONFIG_HID_THRUSTMASTER is not set # CONFIG_HID_UDRAW_PS3 is not set # CONFIG_HID_U2FZERO is not set # CONFIG_HID_WACOM is not set # CONFIG_HID_WIIMOTE is not set # CONFIG_HID_XINMO is not set # CONFIG_HID_ZEROPLUS is not set # CONFIG_HID_ZYDACRON is not set # CONFIG_HID_SENSOR_HUB is not set # CONFIG_HID_ALPS is not set # end of Special HID drivers # # USB HID support # CONFIG_USB_HID=y CONFIG_HID_PID=y CONFIG_USB_HIDDEV=y # end of USB HID support # # I2C HID support # # CONFIG_I2C_HID_ACPI is not set # end of I2C HID support # # Intel ISH HID support # # CONFIG_INTEL_ISH_HID is not set # end of Intel ISH HID support # # AMD SFH HID Support # # CONFIG_AMD_SFH_HID is not set # end of AMD SFH HID Support # end of HID support CONFIG_USB_OHCI_LITTLE_ENDIAN=y CONFIG_USB_SUPPORT=y CONFIG_USB_COMMON=y # CONFIG_USB_LED_TRIG is not set # CONFIG_USB_ULPI_BUS is not set CONFIG_USB_ARCH_HAS_HCD=y CONFIG_USB=y CONFIG_USB_PCI=y CONFIG_USB_ANNOUNCE_NEW_DEVICES=y # # Miscellaneous USB options # CONFIG_USB_DEFAULT_PERSIST=y # CONFIG_USB_FEW_INIT_RETRIES is not set # CONFIG_USB_DYNAMIC_MINORS is not set # CONFIG_USB_OTG is not set # CONFIG_USB_OTG_PRODUCTLIST is not set # CONFIG_USB_LEDS_TRIGGER_USBPORT is not set CONFIG_USB_AUTOSUSPEND_DELAY=2 CONFIG_USB_MON=y # # USB Host Controller Drivers # # CONFIG_USB_C67X00_HCD is not set CONFIG_USB_XHCI_HCD=y # CONFIG_USB_XHCI_DBGCAP is not set CONFIG_USB_XHCI_PCI=y # CONFIG_USB_XHCI_PCI_RENESAS is not set # CONFIG_USB_XHCI_PLATFORM is not set CONFIG_USB_EHCI_HCD=y # CONFIG_USB_EHCI_ROOT_HUB_TT is not set CONFIG_USB_EHCI_TT_NEWSCHED=y CONFIG_USB_EHCI_PCI=y # CONFIG_USB_EHCI_FSL is not set # CONFIG_USB_EHCI_HCD_PLATFORM is not set # CONFIG_USB_OXU210HP_HCD is not set # CONFIG_USB_ISP116X_HCD is not set # CONFIG_USB_FOTG210_HCD is not set CONFIG_USB_OHCI_HCD=y CONFIG_USB_OHCI_HCD_PCI=y # CONFIG_USB_OHCI_HCD_PLATFORM is not set CONFIG_USB_UHCI_HCD=y # CONFIG_USB_SL811_HCD is not set # CONFIG_USB_R8A66597_HCD is not set # CONFIG_USB_HCD_TEST_MODE is not set # # USB Device Class drivers # # CONFIG_USB_ACM is not set CONFIG_USB_PRINTER=y # CONFIG_USB_WDM is not set # CONFIG_USB_TMC is not set # # NOTE: USB_STORAGE depends on SCSI but BLK_DEV_SD may # # # also be needed; see USB_STORAGE Help for more info # CONFIG_USB_STORAGE=y # CONFIG_USB_STORAGE_DEBUG is not set # CONFIG_USB_STORAGE_REALTEK is not set # CONFIG_USB_STORAGE_DATAFAB is not set # CONFIG_USB_STORAGE_FREECOM is not set # CONFIG_USB_STORAGE_ISD200 is not set # CONFIG_USB_STORAGE_USBAT is not set # CONFIG_USB_STORAGE_SDDR09 is not set # CONFIG_USB_STORAGE_SDDR55 is not set # CONFIG_USB_STORAGE_JUMPSHOT is not set # CONFIG_USB_STORAGE_ALAUDA is not set # CONFIG_USB_STORAGE_ONETOUCH is not set # CONFIG_USB_STORAGE_KARMA is not set # CONFIG_USB_STORAGE_CYPRESS_ATACB is not set # CONFIG_USB_STORAGE_ENE_UB6250 is not set # CONFIG_USB_UAS is not set # # USB Imaging devices # # CONFIG_USB_MDC800 is not set # CONFIG_USB_MICROTEK is not set # CONFIG_USBIP_CORE is not set # CONFIG_USB_CDNS_SUPPORT is not set # CONFIG_USB_MUSB_HDRC is not set # CONFIG_USB_DWC3 is not set # CONFIG_USB_DWC2 is not set # CONFIG_USB_CHIPIDEA is not set # CONFIG_USB_ISP1760 is not set # # USB port drivers # # CONFIG_USB_SERIAL is not set # # USB Miscellaneous drivers # # CONFIG_USB_EMI62 is not set # CONFIG_USB_EMI26 is not set # CONFIG_USB_ADUTUX is not set # CONFIG_USB_SEVSEG is not set # CONFIG_USB_LEGOTOWER is not set # CONFIG_USB_LCD is not set # CONFIG_USB_CYPRESS_CY7C63 is not set # CONFIG_USB_CYTHERM is not set # CONFIG_USB_IDMOUSE is not set # CONFIG_USB_FTDI_ELAN is not set # CONFIG_USB_APPLEDISPLAY is not set # CONFIG_APPLE_MFI_FASTCHARGE is not set # CONFIG_USB_SISUSBVGA is not set # CONFIG_USB_LD is not set # CONFIG_USB_TRANCEVIBRATOR is not set # CONFIG_USB_IOWARRIOR is not set # CONFIG_USB_TEST is not set # CONFIG_USB_EHSET_TEST_FIXTURE is not set # CONFIG_USB_ISIGHTFW is not set # CONFIG_USB_YUREX is not set # CONFIG_USB_EZUSB_FX2 is not set # CONFIG_USB_HUB_USB251XB is not set # CONFIG_USB_HSIC_USB3503 is not set # CONFIG_USB_HSIC_USB4604 is not set # CONFIG_USB_LINK_LAYER_TEST is not set # CONFIG_USB_CHAOSKEY is not set # # USB Physical Layer drivers # # CONFIG_NOP_USB_XCEIV is not set # CONFIG_USB_ISP1301 is not set # end of USB Physical Layer drivers # CONFIG_USB_GADGET is not set # CONFIG_TYPEC is not set # CONFIG_USB_ROLE_SWITCH is not set # CONFIG_MMC is not set # CONFIG_SCSI_UFSHCD is not set # CONFIG_MEMSTICK is not set CONFIG_NEW_LEDS=y CONFIG_LEDS_CLASS=y # CONFIG_LEDS_CLASS_FLASH is not set # CONFIG_LEDS_CLASS_MULTICOLOR is not set # CONFIG_LEDS_BRIGHTNESS_HW_CHANGED is not set # # LED drivers # # CONFIG_LEDS_APU is not set # CONFIG_LEDS_LM3530 is not set # CONFIG_LEDS_LM3532 is not set # CONFIG_LEDS_LM3642 is not set # CONFIG_LEDS_PCA9532 is not set # CONFIG_LEDS_LP3944 is not set # CONFIG_LEDS_PCA955X is not set # CONFIG_LEDS_PCA963X is not set # CONFIG_LEDS_BD2802 is not set # CONFIG_LEDS_INTEL_SS4200 is not set # CONFIG_LEDS_TCA6507 is not set # CONFIG_LEDS_TLC591XX is not set # CONFIG_LEDS_LM355x is not set # CONFIG_LEDS_IS31FL319X is not set # # LED driver for blink(1) USB RGB LED is under Special HID drivers (HID_THINGM) # # CONFIG_LEDS_BLINKM is not set # CONFIG_LEDS_MLXCPLD is not set # CONFIG_LEDS_MLXREG is not set # CONFIG_LEDS_USER is not set # CONFIG_LEDS_NIC78BX is not set # CONFIG_LEDS_TI_LMU_COMMON is not set # # Flash and Torch LED drivers # # # RGB LED drivers # # # LED Triggers # CONFIG_LEDS_TRIGGERS=y # CONFIG_LEDS_TRIGGER_TIMER is not set # CONFIG_LEDS_TRIGGER_ONESHOT is not set # CONFIG_LEDS_TRIGGER_DISK is not set # CONFIG_LEDS_TRIGGER_HEARTBEAT is not set # CONFIG_LEDS_TRIGGER_BACKLIGHT is not set # CONFIG_LEDS_TRIGGER_CPU is not set # CONFIG_LEDS_TRIGGER_ACTIVITY is not set # CONFIG_LEDS_TRIGGER_DEFAULT_ON is not set # # iptables trigger is under Netfilter config (LED target) # # CONFIG_LEDS_TRIGGER_TRANSIENT is not set # CONFIG_LEDS_TRIGGER_CAMERA is not set # CONFIG_LEDS_TRIGGER_PANIC is not set # CONFIG_LEDS_TRIGGER_NETDEV is not set # CONFIG_LEDS_TRIGGER_PATTERN is not set # CONFIG_LEDS_TRIGGER_AUDIO is not set # CONFIG_LEDS_TRIGGER_TTY is not set # # Simple LED drivers # # CONFIG_ACCESSIBILITY is not set # CONFIG_INFINIBAND is not set CONFIG_EDAC_ATOMIC_SCRUB=y CONFIG_EDAC_SUPPORT=y CONFIG_RTC_LIB=y CONFIG_RTC_MC146818_LIB=y CONFIG_RTC_CLASS=y # CONFIG_RTC_HCTOSYS is not set CONFIG_RTC_SYSTOHC=y CONFIG_RTC_SYSTOHC_DEVICE="rtc0" # CONFIG_RTC_DEBUG is not set CONFIG_RTC_NVMEM=y # # RTC interfaces # CONFIG_RTC_INTF_SYSFS=y CONFIG_RTC_INTF_PROC=y CONFIG_RTC_INTF_DEV=y # CONFIG_RTC_INTF_DEV_UIE_EMUL is not set # CONFIG_RTC_DRV_TEST is not set # # I2C RTC drivers # # CONFIG_RTC_DRV_ABB5ZES3 is not set # CONFIG_RTC_DRV_ABEOZ9 is not set # CONFIG_RTC_DRV_ABX80X is not set # CONFIG_RTC_DRV_DS1307 is not set # CONFIG_RTC_DRV_DS1374 is not set # CONFIG_RTC_DRV_DS1672 is not set # CONFIG_RTC_DRV_MAX6900 is not set # CONFIG_RTC_DRV_RS5C372 is not set # CONFIG_RTC_DRV_ISL1208 is not set # CONFIG_RTC_DRV_ISL12022 is not set # CONFIG_RTC_DRV_X1205 is not set # CONFIG_RTC_DRV_PCF8523 is not set # CONFIG_RTC_DRV_PCF85063 is not set # CONFIG_RTC_DRV_PCF85363 is not set # CONFIG_RTC_DRV_PCF8563 is not set # CONFIG_RTC_DRV_PCF8583 is not set # CONFIG_RTC_DRV_M41T80 is not set # CONFIG_RTC_DRV_BQ32K is not set # CONFIG_RTC_DRV_S35390A is not set # CONFIG_RTC_DRV_FM3130 is not set # CONFIG_RTC_DRV_RX8010 is not set # CONFIG_RTC_DRV_RX8581 is not set # CONFIG_RTC_DRV_RX8025 is not set # CONFIG_RTC_DRV_EM3027 is not set # CONFIG_RTC_DRV_RV3028 is not set # CONFIG_RTC_DRV_RV3032 is not set # CONFIG_RTC_DRV_RV8803 is not set # CONFIG_RTC_DRV_SD3078 is not set # # SPI RTC drivers # CONFIG_RTC_I2C_AND_SPI=y # # SPI and I2C RTC drivers # # CONFIG_RTC_DRV_DS3232 is not set # CONFIG_RTC_DRV_PCF2127 is not set # CONFIG_RTC_DRV_RV3029C2 is not set # CONFIG_RTC_DRV_RX6110 is not set # # Platform RTC drivers # CONFIG_RTC_DRV_CMOS=y # CONFIG_RTC_DRV_DS1286 is not set # CONFIG_RTC_DRV_DS1511 is not set # CONFIG_RTC_DRV_DS1553 is not set # CONFIG_RTC_DRV_DS1685_FAMILY is not set # CONFIG_RTC_DRV_DS1742 is not set # CONFIG_RTC_DRV_DS2404 is not set # CONFIG_RTC_DRV_STK17TA8 is not set # CONFIG_RTC_DRV_M48T86 is not set # CONFIG_RTC_DRV_M48T35 is not set # CONFIG_RTC_DRV_M48T59 is not set # CONFIG_RTC_DRV_MSM6242 is not set # CONFIG_RTC_DRV_BQ4802 is not set # CONFIG_RTC_DRV_RP5C01 is not set # CONFIG_RTC_DRV_V3020 is not set # # on-CPU RTC drivers # # CONFIG_RTC_DRV_FTRTC010 is not set # # HID Sensor RTC drivers # # CONFIG_RTC_DRV_GOLDFISH is not set CONFIG_DMADEVICES=y # CONFIG_DMADEVICES_DEBUG is not set # # DMA Devices # CONFIG_DMA_ENGINE=y CONFIG_DMA_VIRTUAL_CHANNELS=y CONFIG_DMA_ACPI=y # CONFIG_ALTERA_MSGDMA is not set # CONFIG_INTEL_IDMA64 is not set # CONFIG_INTEL_IDXD is not set # CONFIG_INTEL_IDXD_COMPAT is not set # CONFIG_INTEL_IOATDMA is not set # CONFIG_PLX_DMA is not set # CONFIG_AMD_PTDMA is not set # CONFIG_QCOM_HIDMA_MGMT is not set # CONFIG_QCOM_HIDMA is not set CONFIG_DW_DMAC_CORE=y # CONFIG_DW_DMAC is not set # CONFIG_DW_DMAC_PCI is not set # CONFIG_DW_EDMA is not set # CONFIG_DW_EDMA_PCIE is not set CONFIG_HSU_DMA=y # CONFIG_SF_PDMA is not set # CONFIG_INTEL_LDMA is not set # # DMA Clients # # CONFIG_ASYNC_TX_DMA is not set # CONFIG_DMATEST is not set # # DMABUF options # CONFIG_SYNC_FILE=y # CONFIG_SW_SYNC is not set # CONFIG_UDMABUF is not set # CONFIG_DMABUF_MOVE_NOTIFY is not set # CONFIG_DMABUF_DEBUG is not set # CONFIG_DMABUF_SELFTESTS is not set # CONFIG_DMABUF_HEAPS is not set # CONFIG_DMABUF_SYSFS_STATS is not set # end of DMABUF options # CONFIG_AUXDISPLAY is not set # CONFIG_UIO is not set # CONFIG_VFIO is not set # CONFIG_VIRT_DRIVERS is not set CONFIG_VIRTIO_ANCHOR=y CONFIG_VIRTIO=y CONFIG_VIRTIO_PCI_LIB=y CONFIG_VIRTIO_PCI_LIB_LEGACY=y CONFIG_VIRTIO_MENU=y CONFIG_VIRTIO_PCI=y CONFIG_VIRTIO_PCI_LEGACY=y # CONFIG_VIRTIO_BALLOON is not set CONFIG_VIRTIO_INPUT=y # CONFIG_VIRTIO_MMIO is not set CONFIG_VIRTIO_DMA_SHARED_BUFFER=y # CONFIG_VDPA is not set CONFIG_VHOST_MENU=y # CONFIG_VHOST_NET is not set # CONFIG_VHOST_CROSS_ENDIAN_LEGACY is not set # # Microsoft Hyper-V guest support # # CONFIG_HYPERV is not set # end of Microsoft Hyper-V guest support # CONFIG_GREYBUS is not set # CONFIG_COMEDI is not set # CONFIG_STAGING is not set # CONFIG_CHROME_PLATFORMS is not set # CONFIG_MELLANOX_PLATFORM is not set CONFIG_SURFACE_PLATFORMS=y # CONFIG_SURFACE_3_POWER_OPREGION is not set # CONFIG_SURFACE_GPE is not set # CONFIG_SURFACE_PRO3_BUTTON is not set CONFIG_X86_PLATFORM_DEVICES=y CONFIG_ACPI_WMI=y CONFIG_WMI_BMOF=y # CONFIG_HUAWEI_WMI is not set # CONFIG_MXM_WMI is not set # CONFIG_PEAQ_WMI is not set # CONFIG_NVIDIA_WMI_EC_BACKLIGHT is not set # CONFIG_XIAOMI_WMI is not set # CONFIG_GIGABYTE_WMI is not set # CONFIG_YOGABOOK_WMI is not set # CONFIG_ACERHDF is not set # CONFIG_ACER_WIRELESS is not set # CONFIG_ACER_WMI is not set # CONFIG_AMD_PMF is not set # CONFIG_AMD_PMC is not set # CONFIG_AMD_HSMP is not set # CONFIG_ADV_SWBUTTON is not set # CONFIG_APPLE_GMUX is not set # CONFIG_ASUS_LAPTOP is not set # CONFIG_ASUS_WIRELESS is not set # CONFIG_ASUS_WMI is not set CONFIG_EEEPC_LAPTOP=y # CONFIG_X86_PLATFORM_DRIVERS_DELL is not set # CONFIG_AMILO_RFKILL is not set # CONFIG_FUJITSU_LAPTOP is not set # CONFIG_FUJITSU_TABLET is not set # CONFIG_GPD_POCKET_FAN is not set # CONFIG_HP_ACCEL is not set # CONFIG_WIRELESS_HOTKEY is not set # CONFIG_HP_WMI is not set # CONFIG_IBM_RTL is not set # CONFIG_IDEAPAD_LAPTOP is not set # CONFIG_SENSORS_HDAPS is not set # CONFIG_THINKPAD_ACPI is not set # CONFIG_THINKPAD_LMI is not set # CONFIG_INTEL_ATOMISP2_PM is not set # CONFIG_INTEL_SAR_INT1092 is not set # CONFIG_INTEL_PMC_CORE is not set # # Intel Speed Select Technology interface support # # CONFIG_INTEL_SPEED_SELECT_INTERFACE is not set # end of Intel Speed Select Technology interface support # CONFIG_INTEL_WMI_SBL_FW_UPDATE is not set # CONFIG_INTEL_WMI_THUNDERBOLT is not set # # Intel Uncore Frequency Control # # CONFIG_INTEL_UNCORE_FREQ_CONTROL is not set # end of Intel Uncore Frequency Control # CONFIG_INTEL_HID_EVENT is not set # CONFIG_INTEL_VBTN is not set # CONFIG_INTEL_OAKTRAIL is not set # CONFIG_INTEL_PUNIT_IPC is not set # CONFIG_INTEL_RST is not set # CONFIG_INTEL_SMARTCONNECT is not set # CONFIG_INTEL_VSEC is not set # CONFIG_MSI_LAPTOP is not set # CONFIG_MSI_WMI is not set # CONFIG_SAMSUNG_LAPTOP is not set # CONFIG_SAMSUNG_Q10 is not set # CONFIG_TOSHIBA_BT_RFKILL is not set # CONFIG_TOSHIBA_HAPS is not set # CONFIG_TOSHIBA_WMI is not set # CONFIG_ACPI_CMPC is not set # CONFIG_COMPAL_LAPTOP is not set # CONFIG_LG_LAPTOP is not set # CONFIG_PANASONIC_LAPTOP is not set # CONFIG_SONY_LAPTOP is not set # CONFIG_SYSTEM76_ACPI is not set # CONFIG_TOPSTAR_LAPTOP is not set # CONFIG_MLX_PLATFORM is not set # CONFIG_INTEL_IPS is not set # CONFIG_INTEL_SCU_PCI is not set # CONFIG_INTEL_SCU_PLATFORM is not set # CONFIG_SIEMENS_SIMATIC_IPC is not set # CONFIG_WINMATE_FM07_KEYS is not set CONFIG_P2SB=y # CONFIG_COMMON_CLK is not set # CONFIG_HWSPINLOCK is not set # # Clock Source drivers # CONFIG_CLKEVT_I8253=y CONFIG_I8253_LOCK=y CONFIG_CLKBLD_I8253=y # end of Clock Source drivers CONFIG_MAILBOX=y CONFIG_PCC=y # CONFIG_ALTERA_MBOX is not set CONFIG_IOMMU_IOVA=y CONFIG_IOASID=y CONFIG_IOMMU_API=y CONFIG_IOMMU_SUPPORT=y # # Generic IOMMU Pagetable Support # CONFIG_IOMMU_IO_PGTABLE=y # end of Generic IOMMU Pagetable Support # CONFIG_IOMMU_DEBUGFS is not set # CONFIG_IOMMU_DEFAULT_DMA_STRICT is not set CONFIG_IOMMU_DEFAULT_DMA_LAZY=y # CONFIG_IOMMU_DEFAULT_PASSTHROUGH is not set CONFIG_IOMMU_DMA=y CONFIG_AMD_IOMMU=y # CONFIG_AMD_IOMMU_V2 is not set CONFIG_DMAR_TABLE=y CONFIG_INTEL_IOMMU=y # CONFIG_INTEL_IOMMU_SVM is not set # CONFIG_INTEL_IOMMU_DEFAULT_ON is not set CONFIG_INTEL_IOMMU_FLOPPY_WA=y CONFIG_INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON=y # CONFIG_IRQ_REMAP is not set # CONFIG_VIRTIO_IOMMU is not set # # Remoteproc drivers # # CONFIG_REMOTEPROC is not set # end of Remoteproc drivers # # Rpmsg drivers # # CONFIG_RPMSG_QCOM_GLINK_RPM is not set # CONFIG_RPMSG_VIRTIO is not set # end of Rpmsg drivers # CONFIG_SOUNDWIRE is not set # # SOC (System On Chip) specific Drivers # # # Amlogic SoC drivers # # end of Amlogic SoC drivers # # Broadcom SoC drivers # # end of Broadcom SoC drivers # # NXP/Freescale QorIQ SoC drivers # # end of NXP/Freescale QorIQ SoC drivers # # fujitsu SoC drivers # # end of fujitsu SoC drivers # # i.MX SoC drivers # # end of i.MX SoC drivers # # Enable LiteX SoC Builder specific drivers # # end of Enable LiteX SoC Builder specific drivers # # Qualcomm SoC drivers # # end of Qualcomm SoC drivers # CONFIG_SOC_TI is not set # # Xilinx SoC drivers # # end of Xilinx SoC drivers # end of SOC (System On Chip) specific Drivers # CONFIG_PM_DEVFREQ is not set # CONFIG_EXTCON is not set # CONFIG_MEMORY is not set # CONFIG_IIO is not set # CONFIG_NTB is not set # CONFIG_PWM is not set # # IRQ chip support # # end of IRQ chip support # CONFIG_IPACK_BUS is not set # CONFIG_RESET_CONTROLLER is not set # # PHY Subsystem # # CONFIG_GENERIC_PHY is not set # CONFIG_USB_LGM_PHY is not set # CONFIG_PHY_CAN_TRANSCEIVER is not set # # PHY drivers for Broadcom platforms # # CONFIG_BCM_KONA_USB2_PHY is not set # end of PHY drivers for Broadcom platforms # CONFIG_PHY_PXA_28NM_HSIC is not set # CONFIG_PHY_PXA_28NM_USB2 is not set # CONFIG_PHY_INTEL_LGM_EMMC is not set # end of PHY Subsystem # CONFIG_POWERCAP is not set # CONFIG_MCB is not set # # Performance monitor support # # end of Performance monitor support # CONFIG_RAS is not set # CONFIG_USB4 is not set # # Android # # CONFIG_ANDROID_BINDER_IPC is not set # end of Android # CONFIG_LIBNVDIMM is not set # CONFIG_DAX is not set CONFIG_NVMEM=y CONFIG_NVMEM_SYSFS=y # CONFIG_NVMEM_RMEM is not set # # HW tracing support # # CONFIG_STM is not set # CONFIG_INTEL_TH is not set # end of HW tracing support # CONFIG_FPGA is not set # CONFIG_TEE is not set # CONFIG_SIOX is not set # CONFIG_SLIMBUS is not set # CONFIG_INTERCONNECT is not set # CONFIG_COUNTER is not set # CONFIG_PECI is not set # CONFIG_HTE is not set # end of Device Drivers # # File systems # CONFIG_DCACHE_WORD_ACCESS=y # CONFIG_VALIDATE_FS_PARSER is not set CONFIG_FS_IOMAP=y # CONFIG_EXT2_FS is not set # CONFIG_EXT3_FS is not set CONFIG_EXT4_FS=y CONFIG_EXT4_USE_FOR_EXT2=y CONFIG_EXT4_FS_POSIX_ACL=y CONFIG_EXT4_FS_SECURITY=y # CONFIG_EXT4_DEBUG is not set CONFIG_JBD2=y # CONFIG_JBD2_DEBUG is not set CONFIG_FS_MBCACHE=y # CONFIG_REISERFS_FS is not set # CONFIG_JFS_FS is not set # CONFIG_XFS_FS is not set # CONFIG_GFS2_FS is not set # CONFIG_BTRFS_FS is not set # CONFIG_NILFS2_FS is not set # CONFIG_F2FS_FS is not set CONFIG_FS_POSIX_ACL=y CONFIG_EXPORTFS=y # CONFIG_EXPORTFS_BLOCK_OPS is not set CONFIG_FILE_LOCKING=y # CONFIG_FS_ENCRYPTION is not set # CONFIG_FS_VERITY is not set CONFIG_FSNOTIFY=y CONFIG_DNOTIFY=y CONFIG_INOTIFY_USER=y # CONFIG_FANOTIFY is not set CONFIG_QUOTA=y CONFIG_QUOTA_NETLINK_INTERFACE=y # CONFIG_PRINT_QUOTA_WARNING is not set # CONFIG_QUOTA_DEBUG is not set CONFIG_QUOTA_TREE=y # CONFIG_QFMT_V1 is not set CONFIG_QFMT_V2=y CONFIG_QUOTACTL=y CONFIG_AUTOFS4_FS=y CONFIG_AUTOFS_FS=y # CONFIG_FUSE_FS is not set # CONFIG_OVERLAY_FS is not set # # Caches # CONFIG_NETFS_SUPPORT=y # CONFIG_NETFS_STATS is not set # CONFIG_FSCACHE is not set # end of Caches # # CD-ROM/DVD Filesystems # CONFIG_ISO9660_FS=y CONFIG_JOLIET=y CONFIG_ZISOFS=y # CONFIG_UDF_FS is not set # end of CD-ROM/DVD Filesystems # # DOS/FAT/EXFAT/NT Filesystems # CONFIG_FAT_FS=y CONFIG_MSDOS_FS=y CONFIG_VFAT_FS=y CONFIG_FAT_DEFAULT_CODEPAGE=437 CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1" # CONFIG_FAT_DEFAULT_UTF8 is not set # CONFIG_EXFAT_FS is not set # CONFIG_NTFS_FS is not set # CONFIG_NTFS3_FS is not set # end of DOS/FAT/EXFAT/NT Filesystems # # Pseudo filesystems # CONFIG_PROC_FS=y CONFIG_PROC_KCORE=y CONFIG_PROC_VMCORE=y # CONFIG_PROC_VMCORE_DEVICE_DUMP is not set CONFIG_PROC_SYSCTL=y CONFIG_PROC_PAGE_MONITOR=y # CONFIG_PROC_CHILDREN is not set CONFIG_PROC_PID_ARCH_STATUS=y CONFIG_KERNFS=y CONFIG_SYSFS=y CONFIG_TMPFS=y CONFIG_TMPFS_POSIX_ACL=y CONFIG_TMPFS_XATTR=y # CONFIG_TMPFS_INODE64 is not set CONFIG_HUGETLBFS=y CONFIG_HUGETLB_PAGE=y CONFIG_ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP=y CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP=y # CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON is not set CONFIG_MEMFD_CREATE=y CONFIG_ARCH_HAS_GIGANTIC_PAGE=y # CONFIG_CONFIGFS_FS is not set CONFIG_EFIVAR_FS=m # end of Pseudo filesystems CONFIG_MISC_FILESYSTEMS=y # CONFIG_ORANGEFS_FS is not set # CONFIG_ADFS_FS is not set # CONFIG_AFFS_FS is not set # CONFIG_ECRYPT_FS is not set # CONFIG_HFS_FS is not set # CONFIG_HFSPLUS_FS is not set # CONFIG_BEFS_FS is not set # CONFIG_BFS_FS is not set # CONFIG_EFS_FS is not set # CONFIG_CRAMFS is not set # CONFIG_SQUASHFS is not set # CONFIG_VXFS_FS is not set # CONFIG_MINIX_FS is not set # CONFIG_OMFS_FS is not set # CONFIG_HPFS_FS is not set # CONFIG_QNX4FS_FS is not set # CONFIG_QNX6FS_FS is not set # CONFIG_ROMFS_FS is not set # CONFIG_PSTORE is not set # CONFIG_SYSV_FS is not set # CONFIG_UFS_FS is not set # CONFIG_EROFS_FS is not set CONFIG_NETWORK_FILESYSTEMS=y CONFIG_NFS_FS=y CONFIG_NFS_V2=y CONFIG_NFS_V3=y CONFIG_NFS_V3_ACL=y CONFIG_NFS_V4=y # CONFIG_NFS_SWAP is not set # CONFIG_NFS_V4_1 is not set CONFIG_ROOT_NFS=y # CONFIG_NFS_USE_LEGACY_DNS is not set CONFIG_NFS_USE_KERNEL_DNS=y CONFIG_NFS_DISABLE_UDP_SUPPORT=y # CONFIG_NFSD is not set CONFIG_GRACE_PERIOD=y CONFIG_LOCKD=y CONFIG_LOCKD_V4=y CONFIG_NFS_ACL_SUPPORT=y CONFIG_NFS_COMMON=y CONFIG_SUNRPC=y CONFIG_SUNRPC_GSS=y # CONFIG_SUNRPC_DEBUG is not set # CONFIG_CEPH_FS is not set # CONFIG_CIFS is not set # CONFIG_SMB_SERVER is not set # CONFIG_CODA_FS is not set # CONFIG_AFS_FS is not set CONFIG_9P_FS=y # CONFIG_9P_FS_POSIX_ACL is not set # CONFIG_9P_FS_SECURITY is not set CONFIG_NLS=y CONFIG_NLS_DEFAULT="utf8" CONFIG_NLS_CODEPAGE_437=y # CONFIG_NLS_CODEPAGE_737 is not set # CONFIG_NLS_CODEPAGE_775 is not set # CONFIG_NLS_CODEPAGE_850 is not set # CONFIG_NLS_CODEPAGE_852 is not set # CONFIG_NLS_CODEPAGE_855 is not set # CONFIG_NLS_CODEPAGE_857 is not set # CONFIG_NLS_CODEPAGE_860 is not set # CONFIG_NLS_CODEPAGE_861 is not set # CONFIG_NLS_CODEPAGE_862 is not set # CONFIG_NLS_CODEPAGE_863 is not set # CONFIG_NLS_CODEPAGE_864 is not set # CONFIG_NLS_CODEPAGE_865 is not set # CONFIG_NLS_CODEPAGE_866 is not set # CONFIG_NLS_CODEPAGE_869 is not set # CONFIG_NLS_CODEPAGE_936 is not set # CONFIG_NLS_CODEPAGE_950 is not set # CONFIG_NLS_CODEPAGE_932 is not set # CONFIG_NLS_CODEPAGE_949 is not set # CONFIG_NLS_CODEPAGE_874 is not set # CONFIG_NLS_ISO8859_8 is not set # CONFIG_NLS_CODEPAGE_1250 is not set # CONFIG_NLS_CODEPAGE_1251 is not set CONFIG_NLS_ASCII=y CONFIG_NLS_ISO8859_1=y # CONFIG_NLS_ISO8859_2 is not set # CONFIG_NLS_ISO8859_3 is not set # CONFIG_NLS_ISO8859_4 is not set # CONFIG_NLS_ISO8859_5 is not set # CONFIG_NLS_ISO8859_6 is not set # CONFIG_NLS_ISO8859_7 is not set # CONFIG_NLS_ISO8859_9 is not set # CONFIG_NLS_ISO8859_13 is not set # CONFIG_NLS_ISO8859_14 is not set # CONFIG_NLS_ISO8859_15 is not set # CONFIG_NLS_KOI8_R is not set # CONFIG_NLS_KOI8_U is not set # CONFIG_NLS_MAC_ROMAN is not set # CONFIG_NLS_MAC_CELTIC is not set # CONFIG_NLS_MAC_CENTEURO is not set # CONFIG_NLS_MAC_CROATIAN is not set # CONFIG_NLS_MAC_CYRILLIC is not set # CONFIG_NLS_MAC_GAELIC is not set # CONFIG_NLS_MAC_GREEK is not set # CONFIG_NLS_MAC_ICELAND is not set # CONFIG_NLS_MAC_INUIT is not set # CONFIG_NLS_MAC_ROMANIAN is not set # CONFIG_NLS_MAC_TURKISH is not set CONFIG_NLS_UTF8=y # CONFIG_UNICODE is not set CONFIG_IO_WQ=y # end of File systems # # Security options # CONFIG_KEYS=y # CONFIG_KEYS_REQUEST_CACHE is not set # CONFIG_PERSISTENT_KEYRINGS is not set # CONFIG_TRUSTED_KEYS is not set # CONFIG_ENCRYPTED_KEYS is not set # CONFIG_KEY_DH_OPERATIONS is not set # CONFIG_SECURITY_DMESG_RESTRICT is not set CONFIG_SECURITY=y CONFIG_SECURITY_WRITABLE_HOOKS=y # CONFIG_SECURITYFS is not set CONFIG_SECURITY_NETWORK=y # CONFIG_SECURITY_NETWORK_XFRM is not set # CONFIG_SECURITY_PATH is not set # CONFIG_INTEL_TXT is not set CONFIG_LSM_MMAP_MIN_ADDR=65536 CONFIG_HAVE_HARDENED_USERCOPY_ALLOCATOR=y # CONFIG_HARDENED_USERCOPY is not set # CONFIG_STATIC_USERMODEHELPER is not set CONFIG_SECURITY_SELINUX=y CONFIG_SECURITY_SELINUX_BOOTPARAM=y CONFIG_SECURITY_SELINUX_DISABLE=y CONFIG_SECURITY_SELINUX_DEVELOP=y CONFIG_SECURITY_SELINUX_AVC_STATS=y CONFIG_SECURITY_SELINUX_CHECKREQPROT_VALUE=0 CONFIG_SECURITY_SELINUX_SIDTAB_HASH_BITS=9 CONFIG_SECURITY_SELINUX_SID2STR_CACHE_SIZE=256 # CONFIG_SECURITY_SMACK is not set # CONFIG_SECURITY_TOMOYO is not set # CONFIG_SECURITY_APPARMOR is not set # CONFIG_SECURITY_LOADPIN is not set # CONFIG_SECURITY_YAMA is not set # CONFIG_SECURITY_SAFESETID is not set # CONFIG_SECURITY_LOCKDOWN_LSM is not set # CONFIG_SECURITY_LANDLOCK is not set CONFIG_INTEGRITY=y # CONFIG_INTEGRITY_SIGNATURE is not set CONFIG_INTEGRITY_AUDIT=y # CONFIG_IMA is not set # CONFIG_IMA_SECURE_AND_OR_TRUSTED_BOOT is not set # CONFIG_EVM is not set CONFIG_DEFAULT_SECURITY_SELINUX=y # CONFIG_DEFAULT_SECURITY_DAC is not set CONFIG_LSM="landlock,lockdown,yama,loadpin,safesetid,integrity,selinux,smack,tomoyo,apparmor,bpf" # # Kernel hardening options # # # Memory initialization # CONFIG_CC_HAS_AUTO_VAR_INIT_PATTERN=y CONFIG_CC_HAS_AUTO_VAR_INIT_ZERO_ENABLER=y CONFIG_CC_HAS_AUTO_VAR_INIT_ZERO=y # CONFIG_INIT_STACK_NONE is not set # CONFIG_INIT_STACK_ALL_PATTERN is not set CONFIG_INIT_STACK_ALL_ZERO=y # CONFIG_INIT_ON_ALLOC_DEFAULT_ON is not set # CONFIG_INIT_ON_FREE_DEFAULT_ON is not set # end of Memory initialization CONFIG_RANDSTRUCT_NONE=y # end of Kernel hardening options # end of Security options CONFIG_CRYPTO=y # # Crypto core or helper # CONFIG_CRYPTO_ALGAPI=y CONFIG_CRYPTO_ALGAPI2=y CONFIG_CRYPTO_AEAD=y CONFIG_CRYPTO_AEAD2=y CONFIG_CRYPTO_SKCIPHER=y CONFIG_CRYPTO_SKCIPHER2=y CONFIG_CRYPTO_HASH=y CONFIG_CRYPTO_HASH2=y CONFIG_CRYPTO_RNG=y CONFIG_CRYPTO_RNG2=y CONFIG_CRYPTO_RNG_DEFAULT=y CONFIG_CRYPTO_AKCIPHER2=y CONFIG_CRYPTO_AKCIPHER=y CONFIG_CRYPTO_KPP2=y CONFIG_CRYPTO_ACOMP2=y CONFIG_CRYPTO_MANAGER=y CONFIG_CRYPTO_MANAGER2=y # CONFIG_CRYPTO_USER is not set CONFIG_CRYPTO_MANAGER_DISABLE_TESTS=y CONFIG_CRYPTO_GF128MUL=y CONFIG_CRYPTO_NULL=y CONFIG_CRYPTO_NULL2=y # CONFIG_CRYPTO_CRYPTD is not set CONFIG_CRYPTO_AUTHENC=y # CONFIG_CRYPTO_TEST is not set # end of Crypto core or helper # # Public-key cryptography # CONFIG_CRYPTO_RSA=y # CONFIG_CRYPTO_DH is not set # CONFIG_CRYPTO_ECDH is not set # CONFIG_CRYPTO_ECDSA is not set # CONFIG_CRYPTO_ECRDSA is not set # CONFIG_CRYPTO_SM2 is not set # CONFIG_CRYPTO_CURVE25519 is not set # end of Public-key cryptography # # Block ciphers # CONFIG_CRYPTO_AES=y # CONFIG_CRYPTO_AES_TI is not set # CONFIG_CRYPTO_ARIA is not set # CONFIG_CRYPTO_BLOWFISH is not set # CONFIG_CRYPTO_CAMELLIA is not set # CONFIG_CRYPTO_CAST5 is not set # CONFIG_CRYPTO_CAST6 is not set # CONFIG_CRYPTO_DES is not set # CONFIG_CRYPTO_FCRYPT is not set # CONFIG_CRYPTO_SERPENT is not set # CONFIG_CRYPTO_SM4_GENERIC is not set # CONFIG_CRYPTO_TWOFISH is not set # end of Block ciphers # # Length-preserving ciphers and modes # # CONFIG_CRYPTO_ADIANTUM is not set # CONFIG_CRYPTO_CHACHA20 is not set CONFIG_CRYPTO_CBC=y # CONFIG_CRYPTO_CFB is not set CONFIG_CRYPTO_CTR=y # CONFIG_CRYPTO_CTS is not set # CONFIG_CRYPTO_ECB is not set # CONFIG_CRYPTO_HCTR2 is not set # CONFIG_CRYPTO_KEYWRAP is not set # CONFIG_CRYPTO_LRW is not set # CONFIG_CRYPTO_OFB is not set # CONFIG_CRYPTO_PCBC is not set # CONFIG_CRYPTO_XTS is not set # end of Length-preserving ciphers and modes # # AEAD (authenticated encryption with associated data) ciphers # # CONFIG_CRYPTO_AEGIS128 is not set # CONFIG_CRYPTO_CHACHA20POLY1305 is not set CONFIG_CRYPTO_CCM=y CONFIG_CRYPTO_GCM=y CONFIG_CRYPTO_SEQIV=y CONFIG_CRYPTO_ECHAINIV=y # CONFIG_CRYPTO_ESSIV is not set # end of AEAD (authenticated encryption with associated data) ciphers # # Hashes, digests, and MACs # # CONFIG_CRYPTO_BLAKE2B is not set CONFIG_CRYPTO_CMAC=y CONFIG_CRYPTO_GHASH=y CONFIG_CRYPTO_HMAC=y # CONFIG_CRYPTO_MD4 is not set CONFIG_CRYPTO_MD5=y # CONFIG_CRYPTO_MICHAEL_MIC is not set # CONFIG_CRYPTO_POLY1305 is not set # CONFIG_CRYPTO_RMD160 is not set # CONFIG_CRYPTO_SHA1 is not set CONFIG_CRYPTO_SHA256=y CONFIG_CRYPTO_SHA512=y # CONFIG_CRYPTO_SHA3 is not set # CONFIG_CRYPTO_SM3_GENERIC is not set # CONFIG_CRYPTO_STREEBOG is not set # CONFIG_CRYPTO_VMAC is not set # CONFIG_CRYPTO_WP512 is not set # CONFIG_CRYPTO_XCBC is not set # CONFIG_CRYPTO_XXHASH is not set # end of Hashes, digests, and MACs # # CRCs (cyclic redundancy checks) # CONFIG_CRYPTO_CRC32C=y # CONFIG_CRYPTO_CRC32 is not set # CONFIG_CRYPTO_CRCT10DIF is not set # end of CRCs (cyclic redundancy checks) # # Compression # # CONFIG_CRYPTO_DEFLATE is not set # CONFIG_CRYPTO_LZO is not set # CONFIG_CRYPTO_842 is not set # CONFIG_CRYPTO_LZ4 is not set # CONFIG_CRYPTO_LZ4HC is not set # CONFIG_CRYPTO_ZSTD is not set # end of Compression # # Random number generation # # CONFIG_CRYPTO_ANSI_CPRNG is not set CONFIG_CRYPTO_DRBG_MENU=y CONFIG_CRYPTO_DRBG_HMAC=y # CONFIG_CRYPTO_DRBG_HASH is not set # CONFIG_CRYPTO_DRBG_CTR is not set CONFIG_CRYPTO_DRBG=y CONFIG_CRYPTO_JITTERENTROPY=y # end of Random number generation # # Userspace interface # # CONFIG_CRYPTO_USER_API_HASH is not set # CONFIG_CRYPTO_USER_API_SKCIPHER is not set # CONFIG_CRYPTO_USER_API_RNG is not set # CONFIG_CRYPTO_USER_API_AEAD is not set # end of Userspace interface CONFIG_CRYPTO_HASH_INFO=y # # Accelerated Cryptographic Algorithms for CPU (x86) # # CONFIG_CRYPTO_CURVE25519_X86 is not set # CONFIG_CRYPTO_AES_NI_INTEL is not set # CONFIG_CRYPTO_BLOWFISH_X86_64 is not set # CONFIG_CRYPTO_CAMELLIA_X86_64 is not set # CONFIG_CRYPTO_CAMELLIA_AESNI_AVX_X86_64 is not set # CONFIG_CRYPTO_CAMELLIA_AESNI_AVX2_X86_64 is not set # CONFIG_CRYPTO_CAST5_AVX_X86_64 is not set # CONFIG_CRYPTO_CAST6_AVX_X86_64 is not set # CONFIG_CRYPTO_DES3_EDE_X86_64 is not set # CONFIG_CRYPTO_SERPENT_SSE2_X86_64 is not set # CONFIG_CRYPTO_SERPENT_AVX_X86_64 is not set # CONFIG_CRYPTO_SERPENT_AVX2_X86_64 is not set # CONFIG_CRYPTO_SM4_AESNI_AVX_X86_64 is not set # CONFIG_CRYPTO_SM4_AESNI_AVX2_X86_64 is not set # CONFIG_CRYPTO_TWOFISH_X86_64 is not set # CONFIG_CRYPTO_TWOFISH_X86_64_3WAY is not set # CONFIG_CRYPTO_TWOFISH_AVX_X86_64 is not set # CONFIG_CRYPTO_ARIA_AESNI_AVX_X86_64 is not set # CONFIG_CRYPTO_CHACHA20_X86_64 is not set # CONFIG_CRYPTO_AEGIS128_AESNI_SSE2 is not set # CONFIG_CRYPTO_NHPOLY1305_SSE2 is not set # CONFIG_CRYPTO_NHPOLY1305_AVX2 is not set # CONFIG_CRYPTO_BLAKE2S_X86 is not set # CONFIG_CRYPTO_POLYVAL_CLMUL_NI is not set # CONFIG_CRYPTO_POLY1305_X86_64 is not set # CONFIG_CRYPTO_SHA1_SSSE3 is not set # CONFIG_CRYPTO_SHA256_SSSE3 is not set # CONFIG_CRYPTO_SHA512_SSSE3 is not set # CONFIG_CRYPTO_SM3_AVX_X86_64 is not set # CONFIG_CRYPTO_GHASH_CLMUL_NI_INTEL is not set # CONFIG_CRYPTO_CRC32C_INTEL is not set # CONFIG_CRYPTO_CRC32_PCLMUL is not set # end of Accelerated Cryptographic Algorithms for CPU (x86) CONFIG_CRYPTO_HW=y # CONFIG_CRYPTO_DEV_PADLOCK is not set # CONFIG_CRYPTO_DEV_ATMEL_ECC is not set # CONFIG_CRYPTO_DEV_ATMEL_SHA204A is not set # CONFIG_CRYPTO_DEV_CCP is not set # CONFIG_CRYPTO_DEV_QAT_DH895xCC is not set # CONFIG_CRYPTO_DEV_QAT_C3XXX is not set # CONFIG_CRYPTO_DEV_QAT_C62X is not set # CONFIG_CRYPTO_DEV_QAT_4XXX is not set # CONFIG_CRYPTO_DEV_QAT_DH895xCCVF is not set # CONFIG_CRYPTO_DEV_QAT_C3XXXVF is not set # CONFIG_CRYPTO_DEV_QAT_C62XVF is not set # CONFIG_CRYPTO_DEV_NITROX_CNN55XX is not set # CONFIG_CRYPTO_DEV_VIRTIO is not set # CONFIG_CRYPTO_DEV_SAFEXCEL is not set # CONFIG_CRYPTO_DEV_AMLOGIC_GXL is not set CONFIG_ASYMMETRIC_KEY_TYPE=y CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE=y CONFIG_X509_CERTIFICATE_PARSER=y # CONFIG_PKCS8_PRIVATE_KEY_PARSER is not set CONFIG_PKCS7_MESSAGE_PARSER=y # CONFIG_PKCS7_TEST_KEY is not set # CONFIG_SIGNED_PE_FILE_VERIFICATION is not set # CONFIG_FIPS_SIGNATURE_SELFTEST is not set # # Certificates for signature checking # CONFIG_SYSTEM_TRUSTED_KEYRING=y CONFIG_SYSTEM_TRUSTED_KEYS="" # CONFIG_SYSTEM_EXTRA_CERTIFICATE is not set # CONFIG_SECONDARY_TRUSTED_KEYRING is not set # CONFIG_SYSTEM_BLACKLIST_KEYRING is not set # end of Certificates for signature checking CONFIG_BINARY_PRINTF=y # # Library routines # # CONFIG_PACKING is not set CONFIG_BITREVERSE=y CONFIG_GENERIC_STRNCPY_FROM_USER=y CONFIG_GENERIC_STRNLEN_USER=y CONFIG_GENERIC_NET_UTILS=y # CONFIG_CORDIC is not set # CONFIG_PRIME_NUMBERS is not set CONFIG_RATIONAL=y CONFIG_GENERIC_PCI_IOMAP=y CONFIG_GENERIC_IOMAP=y CONFIG_ARCH_USE_CMPXCHG_LOCKREF=y CONFIG_ARCH_HAS_FAST_MULTIPLIER=y CONFIG_ARCH_USE_SYM_ANNOTATIONS=y # # Crypto library routines # CONFIG_CRYPTO_LIB_UTILS=y CONFIG_CRYPTO_LIB_AES=y CONFIG_CRYPTO_LIB_ARC4=y CONFIG_CRYPTO_LIB_BLAKE2S_GENERIC=y # CONFIG_CRYPTO_LIB_CHACHA is not set # CONFIG_CRYPTO_LIB_CURVE25519 is not set CONFIG_CRYPTO_LIB_POLY1305_RSIZE=11 # CONFIG_CRYPTO_LIB_POLY1305 is not set # CONFIG_CRYPTO_LIB_CHACHA20POLY1305 is not set CONFIG_CRYPTO_LIB_SHA1=y CONFIG_CRYPTO_LIB_SHA256=y # end of Crypto library routines CONFIG_CRC_CCITT=y CONFIG_CRC16=y # CONFIG_CRC_T10DIF is not set # CONFIG_CRC64_ROCKSOFT is not set # CONFIG_CRC_ITU_T is not set CONFIG_CRC32=y # CONFIG_CRC32_SELFTEST is not set CONFIG_CRC32_SLICEBY8=y # CONFIG_CRC32_SLICEBY4 is not set # CONFIG_CRC32_SARWATE is not set # CONFIG_CRC32_BIT is not set # CONFIG_CRC64 is not set # CONFIG_CRC4 is not set # CONFIG_CRC7 is not set # CONFIG_LIBCRC32C is not set # CONFIG_CRC8 is not set CONFIG_XXHASH=y # CONFIG_RANDOM32_SELFTEST is not set CONFIG_ZLIB_INFLATE=y CONFIG_ZLIB_DEFLATE=y CONFIG_LZO_COMPRESS=y CONFIG_LZO_DECOMPRESS=y CONFIG_LZ4_DECOMPRESS=y CONFIG_ZSTD_COMMON=y CONFIG_ZSTD_DECOMPRESS=y CONFIG_XZ_DEC=y CONFIG_XZ_DEC_X86=y CONFIG_XZ_DEC_POWERPC=y CONFIG_XZ_DEC_IA64=y CONFIG_XZ_DEC_ARM=y CONFIG_XZ_DEC_ARMTHUMB=y CONFIG_XZ_DEC_SPARC=y # CONFIG_XZ_DEC_MICROLZMA is not set CONFIG_XZ_DEC_BCJ=y # CONFIG_XZ_DEC_TEST is not set CONFIG_DECOMPRESS_GZIP=y CONFIG_DECOMPRESS_BZIP2=y CONFIG_DECOMPRESS_LZMA=y CONFIG_DECOMPRESS_XZ=y CONFIG_DECOMPRESS_LZO=y CONFIG_DECOMPRESS_LZ4=y CONFIG_DECOMPRESS_ZSTD=y CONFIG_GENERIC_ALLOCATOR=y CONFIG_INTERVAL_TREE=y CONFIG_XARRAY_MULTI=y CONFIG_ASSOCIATIVE_ARRAY=y CONFIG_HAS_IOMEM=y CONFIG_HAS_IOPORT_MAP=y CONFIG_HAS_DMA=y CONFIG_DMA_OPS=y CONFIG_NEED_SG_DMA_LENGTH=y CONFIG_NEED_DMA_MAP_STATE=y CONFIG_ARCH_DMA_ADDR_T_64BIT=y CONFIG_SWIOTLB=y # CONFIG_DMA_API_DEBUG is not set # CONFIG_DMA_MAP_BENCHMARK is not set CONFIG_SGL_ALLOC=y CONFIG_CHECK_SIGNATURE=y CONFIG_DQL=y CONFIG_GLOB=y # CONFIG_GLOB_SELFTEST is not set CONFIG_NLATTR=y CONFIG_CLZ_TAB=y # CONFIG_IRQ_POLL is not set CONFIG_MPILIB=y CONFIG_OID_REGISTRY=y CONFIG_UCS2_STRING=y CONFIG_HAVE_GENERIC_VDSO=y CONFIG_GENERIC_GETTIMEOFDAY=y CONFIG_GENERIC_VDSO_TIME_NS=y CONFIG_FONT_SUPPORT=y CONFIG_FONT_8x16=y CONFIG_FONT_AUTOSELECT=y CONFIG_SG_POOL=y CONFIG_ARCH_HAS_PMEM_API=y CONFIG_ARCH_HAS_UACCESS_FLUSHCACHE=y CONFIG_ARCH_HAS_COPY_MC=y CONFIG_ARCH_STACKWALK=y CONFIG_STACKDEPOT=y CONFIG_SBITMAP=y # end of Library routines # # Kernel hacking # # # printk and dmesg options # CONFIG_PRINTK_TIME=y # CONFIG_PRINTK_CALLER is not set # CONFIG_STACKTRACE_BUILD_ID is not set CONFIG_CONSOLE_LOGLEVEL_DEFAULT=7 CONFIG_CONSOLE_LOGLEVEL_QUIET=4 CONFIG_MESSAGE_LOGLEVEL_DEFAULT=4 # CONFIG_BOOT_PRINTK_DELAY is not set # CONFIG_DYNAMIC_DEBUG is not set # CONFIG_DYNAMIC_DEBUG_CORE is not set CONFIG_SYMBOLIC_ERRNAME=y CONFIG_DEBUG_BUGVERBOSE=y # end of printk and dmesg options CONFIG_DEBUG_KERNEL=y CONFIG_DEBUG_MISC=y # # Compile-time checks and compiler options # CONFIG_DEBUG_INFO=y CONFIG_AS_HAS_NON_CONST_LEB128=y # CONFIG_DEBUG_INFO_NONE is not set CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y # CONFIG_DEBUG_INFO_DWARF4 is not set # CONFIG_DEBUG_INFO_DWARF5 is not set # CONFIG_DEBUG_INFO_REDUCED is not set # CONFIG_DEBUG_INFO_COMPRESSED is not set # CONFIG_DEBUG_INFO_SPLIT is not set # CONFIG_GDB_SCRIPTS is not set CONFIG_FRAME_WARN=2048 # CONFIG_STRIP_ASM_SYMS is not set # CONFIG_HEADERS_INSTALL is not set CONFIG_SECTION_MISMATCH_WARN_ONLY=y CONFIG_OBJTOOL=y # CONFIG_DEBUG_FORCE_WEAK_PER_CPU is not set # end of Compile-time checks and compiler options # # Generic Kernel Debugging Instruments # CONFIG_MAGIC_SYSRQ=y CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE=0x1 CONFIG_MAGIC_SYSRQ_SERIAL=y CONFIG_MAGIC_SYSRQ_SERIAL_SEQUENCE="" CONFIG_DEBUG_FS=y CONFIG_DEBUG_FS_ALLOW_ALL=y # CONFIG_DEBUG_FS_DISALLOW_MOUNT is not set # CONFIG_DEBUG_FS_ALLOW_NONE is not set CONFIG_HAVE_ARCH_KGDB=y # CONFIG_KGDB is not set CONFIG_ARCH_HAS_UBSAN_SANITIZE_ALL=y # CONFIG_UBSAN is not set CONFIG_HAVE_ARCH_KCSAN=y CONFIG_HAVE_KCSAN_COMPILER=y CONFIG_KCSAN=y CONFIG_KCSAN_VERBOSE=y CONFIG_KCSAN_SELFTEST=y CONFIG_KCSAN_EARLY_ENABLE=y CONFIG_KCSAN_NUM_WATCHPOINTS=64 CONFIG_KCSAN_UDELAY_TASK=80 CONFIG_KCSAN_UDELAY_INTERRUPT=20 CONFIG_KCSAN_DELAY_RANDOMIZE=y CONFIG_KCSAN_SKIP_WATCH=4000 CONFIG_KCSAN_SKIP_WATCH_RANDOMIZE=y CONFIG_KCSAN_INTERRUPT_WATCHER=y CONFIG_KCSAN_REPORT_ONCE_IN_MS=100000 CONFIG_KCSAN_REPORT_RACE_UNKNOWN_ORIGIN=y CONFIG_KCSAN_STRICT=y CONFIG_KCSAN_WEAK_MEMORY=y # end of Generic Kernel Debugging Instruments # # Networking Debugging # # CONFIG_NET_DEV_REFCNT_TRACKER is not set # CONFIG_NET_NS_REFCNT_TRACKER is not set # CONFIG_DEBUG_NET is not set # end of Networking Debugging # # Memory Debugging # # CONFIG_PAGE_EXTENSION is not set # CONFIG_DEBUG_PAGEALLOC is not set CONFIG_SLUB_DEBUG=y # CONFIG_SLUB_DEBUG_ON is not set # CONFIG_PAGE_OWNER is not set # CONFIG_PAGE_TABLE_CHECK is not set # CONFIG_PAGE_POISONING is not set # CONFIG_DEBUG_PAGE_REF is not set # CONFIG_DEBUG_RODATA_TEST is not set CONFIG_ARCH_HAS_DEBUG_WX=y CONFIG_DEBUG_WX=y CONFIG_GENERIC_PTDUMP=y CONFIG_PTDUMP_CORE=y # CONFIG_PTDUMP_DEBUGFS is not set # CONFIG_DEBUG_OBJECTS is not set # CONFIG_SHRINKER_DEBUG is not set CONFIG_HAVE_DEBUG_KMEMLEAK=y # CONFIG_DEBUG_KMEMLEAK is not set CONFIG_DEBUG_STACK_USAGE=y # CONFIG_SCHED_STACK_END_CHECK is not set CONFIG_ARCH_HAS_DEBUG_VM_PGTABLE=y # CONFIG_DEBUG_VM is not set # CONFIG_DEBUG_VM_PGTABLE is not set CONFIG_ARCH_HAS_DEBUG_VIRTUAL=y # CONFIG_DEBUG_VIRTUAL is not set CONFIG_DEBUG_MEMORY_INIT=y CONFIG_ARCH_SUPPORTS_KMAP_LOCAL_FORCE_MAP=y # CONFIG_DEBUG_KMAP_LOCAL_FORCE_MAP is not set CONFIG_HAVE_ARCH_KASAN=y CONFIG_HAVE_ARCH_KASAN_VMALLOC=y CONFIG_CC_HAS_KASAN_GENERIC=y CONFIG_CC_HAS_KASAN_SW_TAGS=y CONFIG_CC_HAS_WORKING_NOSANITIZE_ADDRESS=y # CONFIG_KASAN is not set CONFIG_HAVE_ARCH_KFENCE=y # CONFIG_KFENCE is not set CONFIG_HAVE_ARCH_KMSAN=y # end of Memory Debugging # CONFIG_DEBUG_SHIRQ is not set # # Debug Oops, Lockups and Hangs # # CONFIG_PANIC_ON_OOPS is not set CONFIG_PANIC_ON_OOPS_VALUE=0 CONFIG_PANIC_TIMEOUT=0 # CONFIG_SOFTLOCKUP_DETECTOR is not set CONFIG_HARDLOCKUP_CHECK_TIMESTAMP=y # CONFIG_HARDLOCKUP_DETECTOR is not set # CONFIG_DETECT_HUNG_TASK is not set # CONFIG_WQ_WATCHDOG is not set # CONFIG_TEST_LOCKUP is not set # end of Debug Oops, Lockups and Hangs # # Scheduler Debugging # # CONFIG_SCHED_DEBUG is not set CONFIG_SCHED_INFO=y CONFIG_SCHEDSTATS=y # end of Scheduler Debugging # CONFIG_DEBUG_TIMEKEEPING is not set # # Lock Debugging (spinlocks, mutexes, etc...) # CONFIG_LOCK_DEBUGGING_SUPPORT=y CONFIG_PROVE_LOCKING=y # CONFIG_PROVE_RAW_LOCK_NESTING is not set # CONFIG_LOCK_STAT is not set CONFIG_DEBUG_RT_MUTEXES=y CONFIG_DEBUG_SPINLOCK=y CONFIG_DEBUG_MUTEXES=y CONFIG_DEBUG_WW_MUTEX_SLOWPATH=y CONFIG_DEBUG_RWSEMS=y CONFIG_DEBUG_LOCK_ALLOC=y CONFIG_LOCKDEP=y CONFIG_LOCKDEP_BITS=15 CONFIG_LOCKDEP_CHAINS_BITS=16 CONFIG_LOCKDEP_STACK_TRACE_BITS=19 CONFIG_LOCKDEP_STACK_TRACE_HASH_BITS=14 CONFIG_LOCKDEP_CIRCULAR_QUEUE_BITS=12 # CONFIG_DEBUG_LOCKDEP is not set CONFIG_DEBUG_ATOMIC_SLEEP=y # CONFIG_DEBUG_LOCKING_API_SELFTESTS is not set # CONFIG_LOCK_TORTURE_TEST is not set # CONFIG_WW_MUTEX_SELFTEST is not set # CONFIG_SCF_TORTURE_TEST is not set # CONFIG_CSD_LOCK_WAIT_DEBUG is not set # end of Lock Debugging (spinlocks, mutexes, etc...) CONFIG_TRACE_IRQFLAGS=y CONFIG_TRACE_IRQFLAGS_NMI=y # CONFIG_DEBUG_IRQFLAGS is not set CONFIG_STACKTRACE=y # CONFIG_WARN_ALL_UNSEEDED_RANDOM is not set # CONFIG_DEBUG_KOBJECT is not set # # Debug kernel data structures # # CONFIG_DEBUG_LIST is not set # CONFIG_DEBUG_PLIST is not set # CONFIG_DEBUG_SG is not set # CONFIG_DEBUG_NOTIFIERS is not set # CONFIG_BUG_ON_DATA_CORRUPTION is not set # CONFIG_DEBUG_MAPLE_TREE is not set # end of Debug kernel data structures # CONFIG_DEBUG_CREDENTIALS is not set # # RCU Debugging # CONFIG_PROVE_RCU=y CONFIG_TORTURE_TEST=y # CONFIG_RCU_SCALE_TEST is not set CONFIG_RCU_TORTURE_TEST=y # CONFIG_RCU_REF_SCALE_TEST is not set # CONFIG_RCU_TRACE is not set # CONFIG_RCU_EQS_DEBUG is not set # end of RCU Debugging # CONFIG_DEBUG_WQ_FORCE_RR_CPU is not set # CONFIG_LATENCYTOP is not set CONFIG_USER_STACKTRACE_SUPPORT=y CONFIG_NOP_TRACER=y CONFIG_HAVE_RETHOOK=y CONFIG_RETHOOK=y CONFIG_HAVE_FUNCTION_TRACER=y CONFIG_HAVE_DYNAMIC_FTRACE=y CONFIG_HAVE_DYNAMIC_FTRACE_WITH_REGS=y CONFIG_HAVE_DYNAMIC_FTRACE_WITH_DIRECT_CALLS=y CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS=y CONFIG_HAVE_DYNAMIC_FTRACE_NO_PATCHABLE=y CONFIG_HAVE_FTRACE_MCOUNT_RECORD=y CONFIG_HAVE_SYSCALL_TRACEPOINTS=y CONFIG_HAVE_FENTRY=y CONFIG_HAVE_OBJTOOL_MCOUNT=y CONFIG_HAVE_C_RECORDMCOUNT=y CONFIG_HAVE_BUILDTIME_MCOUNT_SORT=y CONFIG_TRACE_CLOCK=y CONFIG_RING_BUFFER=y CONFIG_EVENT_TRACING=y CONFIG_CONTEXT_SWITCH_TRACER=y CONFIG_PREEMPTIRQ_TRACEPOINTS=y CONFIG_TRACING=y CONFIG_GENERIC_TRACER=y CONFIG_TRACING_SUPPORT=y CONFIG_FTRACE=y # CONFIG_BOOTTIME_TRACING is not set # CONFIG_FUNCTION_TRACER is not set # CONFIG_STACK_TRACER is not set # CONFIG_IRQSOFF_TRACER is not set # CONFIG_SCHED_TRACER is not set # CONFIG_HWLAT_TRACER is not set # CONFIG_OSNOISE_TRACER is not set # CONFIG_TIMERLAT_TRACER is not set # CONFIG_MMIOTRACE is not set # CONFIG_FTRACE_SYSCALLS is not set # CONFIG_TRACER_SNAPSHOT is not set CONFIG_BRANCH_PROFILE_NONE=y # CONFIG_PROFILE_ANNOTATED_BRANCHES is not set # CONFIG_PROFILE_ALL_BRANCHES is not set CONFIG_BLK_DEV_IO_TRACE=y CONFIG_KPROBE_EVENTS=y CONFIG_UPROBE_EVENTS=y CONFIG_DYNAMIC_EVENTS=y CONFIG_PROBE_EVENTS=y # CONFIG_SYNTH_EVENTS is not set # CONFIG_HIST_TRIGGERS is not set # CONFIG_TRACE_EVENT_INJECT is not set # CONFIG_TRACEPOINT_BENCHMARK is not set # CONFIG_RING_BUFFER_BENCHMARK is not set # CONFIG_TRACE_EVAL_MAP_FILE is not set # CONFIG_FTRACE_STARTUP_TEST is not set # CONFIG_RING_BUFFER_STARTUP_TEST is not set # CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS is not set # CONFIG_PREEMPTIRQ_DELAY_TEST is not set # CONFIG_KPROBE_EVENT_GEN_TEST is not set # CONFIG_RV is not set CONFIG_PROVIDE_OHCI1394_DMA_INIT=y # CONFIG_SAMPLES is not set CONFIG_HAVE_SAMPLE_FTRACE_DIRECT=y CONFIG_HAVE_SAMPLE_FTRACE_DIRECT_MULTI=y CONFIG_ARCH_HAS_DEVMEM_IS_ALLOWED=y CONFIG_STRICT_DEVMEM=y # CONFIG_IO_STRICT_DEVMEM is not set # # x86 Debugging # CONFIG_EARLY_PRINTK_USB=y CONFIG_X86_VERBOSE_BOOTUP=y CONFIG_EARLY_PRINTK=y CONFIG_EARLY_PRINTK_DBGP=y # CONFIG_EARLY_PRINTK_USB_XDBC is not set # CONFIG_EFI_PGT_DUMP is not set # CONFIG_DEBUG_TLBFLUSH is not set CONFIG_HAVE_MMIOTRACE_SUPPORT=y # CONFIG_X86_DECODER_SELFTEST is not set CONFIG_IO_DELAY_0X80=y # CONFIG_IO_DELAY_0XED is not set # CONFIG_IO_DELAY_UDELAY is not set # CONFIG_IO_DELAY_NONE is not set CONFIG_DEBUG_BOOT_PARAMS=y # CONFIG_CPA_DEBUG is not set # CONFIG_DEBUG_ENTRY is not set # CONFIG_DEBUG_NMI_SELFTEST is not set CONFIG_X86_DEBUG_FPU=y # CONFIG_PUNIT_ATOM_DEBUG is not set CONFIG_UNWINDER_ORC=y # CONFIG_UNWINDER_FRAME_POINTER is not set # end of x86 Debugging # # Kernel Testing and Coverage # # CONFIG_KUNIT is not set # CONFIG_NOTIFIER_ERROR_INJECTION is not set CONFIG_FUNCTION_ERROR_INJECTION=y # CONFIG_FAULT_INJECTION is not set CONFIG_ARCH_HAS_KCOV=y CONFIG_CC_HAS_SANCOV_TRACE_PC=y # CONFIG_KCOV is not set CONFIG_RUNTIME_TESTING_MENU=y # CONFIG_LKDTM is not set # CONFIG_TEST_MIN_HEAP is not set # CONFIG_TEST_DIV64 is not set # CONFIG_BACKTRACE_SELF_TEST is not set # CONFIG_TEST_REF_TRACKER is not set # CONFIG_RBTREE_TEST is not set # CONFIG_REED_SOLOMON_TEST is not set # CONFIG_INTERVAL_TREE_TEST is not set # CONFIG_PERCPU_TEST is not set # CONFIG_ATOMIC64_SELFTEST is not set # CONFIG_TEST_HEXDUMP is not set # CONFIG_STRING_SELFTEST is not set # CONFIG_TEST_STRING_HELPERS is not set # CONFIG_TEST_STRSCPY is not set # CONFIG_TEST_KSTRTOX is not set # CONFIG_TEST_PRINTF is not set # CONFIG_TEST_SCANF is not set # CONFIG_TEST_BITMAP is not set # CONFIG_TEST_UUID is not set # CONFIG_TEST_XARRAY is not set # CONFIG_TEST_RHASHTABLE is not set # CONFIG_TEST_SIPHASH is not set # CONFIG_TEST_IDA is not set # CONFIG_TEST_LKM is not set # CONFIG_TEST_BITOPS is not set # CONFIG_TEST_VMALLOC is not set # CONFIG_TEST_USER_COPY is not set # CONFIG_TEST_BPF is not set # CONFIG_TEST_BLACKHOLE_DEV is not set # CONFIG_FIND_BIT_BENCHMARK is not set # CONFIG_TEST_FIRMWARE is not set # CONFIG_TEST_SYSCTL is not set # CONFIG_TEST_UDELAY is not set # CONFIG_TEST_STATIC_KEYS is not set # CONFIG_TEST_KMOD is not set # CONFIG_TEST_MEMCAT_P is not set # CONFIG_TEST_MEMINIT is not set # CONFIG_TEST_FREE_PAGES is not set # CONFIG_TEST_FPU is not set # CONFIG_TEST_CLOCKSOURCE_WATCHDOG is not set CONFIG_ARCH_USE_MEMTEST=y # CONFIG_MEMTEST is not set # end of Kernel Testing and Coverage # # Rust hacking # # end of Rust hacking # end of Kernel hacking From xen-devel-bounces@lists.xenproject.org Tue Nov 29 20:37:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 20:37:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449613.706461 (Exim 4.92) (envelope-from ) id 1p07Li-0001rw-AA; Tue, 29 Nov 2022 20:37:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449613.706461; Tue, 29 Nov 2022 20:37:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07Li-0001rp-6k; Tue, 29 Nov 2022 20:37:02 +0000 Received: by outflank-mailman (input) for mailman id 449613; Tue, 29 Nov 2022 20:37:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07Lg-0001rj-9i for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 20:37:00 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 908a7d81-7025-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 21:36:58 +0100 (CET) Received: from mail-dm6nam12lp2174.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2022 15:36:54 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6707.namprd03.prod.outlook.com (2603:10b6:510:112::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 20:36:51 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 20:36:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 908a7d81-7025-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669754217; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=vfFTvcCL7i8yJifALi+r/OXeZZHyFf98VXEdnY/QKU8=; b=IB/KitgDpEBRZ0H3oJVHBtZ8bY03kIQN2uLbVURcc538ahhrJ3PgAcjK xiPVURHlmIIWO9oOdFvmFmpMgff0Pz7Jze+d8+rZQas1/9dgdykFCFZ5M Cf18SIjLMb9F+n/zJAOI3FQyKK/zJoz+ChkEO0ik6Q9gZr7rs+R2BBwP0 o=; X-IronPort-RemoteIP: 104.47.59.174 X-IronPort-MID: 85803730 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:1cQeNq74gQLq2vM9NtVwAQxRtBrGchMFZxGqfqrLsTDasY5as4F+v mFMXDqHP/uPMGX1ct8gYN6/90wBuZeHy9ZnTws4qS1jHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkR7QeA/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5my O4fKxMJNy2/i92zmYOnFtNvnc8MI5y+VG8fkikIITDxK98DGMqGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnUooj+SF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJPROXjqaUy6LGV7msXFxETbAOSndmC1VKaVeIOA XYy9SV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgc/iTQsSAIE55zvpd81hxeWFNJ7Svfq0pvyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLztJ6s8K7xooG9g UU5 IronPort-HdrOrdr: A9a23:fgTc8qMiZN8cqsBcT+n255DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDKw875BKIhTaI7qe/NxSDxB8RXx5G3L9nqA H+4k3Ez5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJptkJJi7qggOIYp0kf7GZpjg6rMym9V5vut jRpBULOdh19hrqDy+IiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ/+1U4e Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh77D3vXklVavoLhiKr7zPI9 MeSv00I8wmKG9yWkqp+lWHBubcBkjbUC32GXTq8fblrgS+1EoJs3fwgvZv3kvovahNNaWtrY 7/Q9tVvaALQckMYa1nAuAdBcOxF2zWWBrJdHmfOFL9Ccg8SjvwQrPMkcIIDduRCeo15Yp3nI 6EXEJTtGY0dU6rAcqS3IdT+hSIRGmmRzzixsxX+pA849THNfHWGDzGTEprn9qrov0ZDMGeU/ GvOIhOC/umKWf1A45G0wD3RpEXI3gDV88evMo9Rju104r2A5yvsvaefOfYJbLrHzphUmTjAm EbVDy2P8lE5lDDYA6NvPEQYQKZRqXSx+MCLEGBxZlj9GEkDPw9jiEFzVKk+8qMNTpO9qQrYU oWGsKUrp+G X-IronPort-AV: E=Sophos;i="5.96,204,1665460800"; d="scan'208";a="85803730" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S4JTvS5QD5p3TQ6O6tfwKteyWIYOTd8fv2bO1ytMiyih+C6xeY3Y1xcUGpBe0Uthe+9WoVuBeCyO9kA3KR+kfUnsJ8tSQoKgE/Un11HwqOMAj5EFdz23eJqAgf6wczxNNYOR0U0+OSyDjvh1Fdwc57OhO06GUbmGbwEU3uArJ7H1EfsOee0NBDLuJq51kOqW7Bf0zjXEEOB+H1olXurY2ropxh5NeUI0/AN+DG22ew6EFN3JXvYsSIoEGu8EI1sUJ2gqzLVE3V1ESa3rwgfWAMaUhQR76yxAMiB3s7mYQmqMwbWttiWYFUnCv/fOupPcjK2oTBSljqQFx9A6rY0A4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vfFTvcCL7i8yJifALi+r/OXeZZHyFf98VXEdnY/QKU8=; b=kFbgxOW+j3VvOpBWSjLfK0sOpyEGgqwXTKpUEh7A1V8aC1Q8EsiVkL2niuOkb9voWV5PK/ZZg+LCkh1jv30K5nwX9BQikH8627UG8RftEVOfSm5Y+y2nGFIFzVLjaQ649Q8kQo4H4sWvo2PO9h+HdlPLqmgQXllPU7xTVz+JPLN0mhNzPpfy9kqn+nGacC+f3DAtFnnBBHLKlSzU6LI0ewXhu2tjivB4L6erMFRfZChiwwyfxloXDvIRT5lVkQP+e8rJFHkWI1NjJ8HHuIyIxwhZIVIZ3pDlDzh2pbuPcihzA8WYU7g2sfz2GoN9RmFVKmZIRk8LH4FXDqarOMKjZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vfFTvcCL7i8yJifALi+r/OXeZZHyFf98VXEdnY/QKU8=; b=T4l5mEeMcTGyzP6jTjpnUpt+5xFFR2zRSbxuMtqQwSuI+t9Xdh9pvUPafAhk2gBHswqpsX0nFjOKtQiYhR4mEI4u7frPxVylSDskzujqYP/qLOmfVDI4xsw0W6rpVisd6NDKperQ6GW+eljVVHxIuFd52jApRCsUe7YJRHHOC/8= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH] x86/HVM: drop stale check from hvm_load_cpu_msrs() Thread-Topic: [PATCH] x86/HVM: drop stale check from hvm_load_cpu_msrs() Thread-Index: AQHZBAII9yW//UkOVUmtKXeE7HsILK5WXJkA Date: Tue, 29 Nov 2022 20:36:50 +0000 Message-ID: <48ace255-8b9f-84e0-cdbe-00c4fba309bd@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB6707:EE_ x-ms-office365-filtering-correlation-id: ffd49f22-0664-495a-5bde-08dad24971aa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5pNuZvgo90OnYYHnvSBffiAokzpFpokLk2A2urzAeyGjmOdLDdcmbHXR8rrfGMhDgsXdTc4+vcLGmmcPWJsWyiTv0XlmL5sEopGOgLriTlc/q5psdl5nHiKj0uci4huQsGSXOXZjKys72vaATn9K7n+B6peEN/Q/smVhnMvZuST2HBP/vcLWHLZGDmW3vIhLI//n9JwBih1Rn1g5AnYH/iVctSqo4PQ43tdwIyWK4/FP2exFq0hoGdqQf3G5EnKr3nxcMpovH1p1GetvXqjePUOv8HnWOzHBXVD6unJLQJnkEtO6HqD3Dwl/6ig8QH4KPmDChmtbUePCGcGjqXXhjBfwUnTrJNg/QwJd3JNhHfO+z38mRBw9NYMYnwVyadhfOGoEI6Iw4tHdgTE0/bQtGjaOoYgJ6C7b9fOaqNWi4IRs8V+zYJ6iRPgqtjM6FfZmYJYOu/7Q5fgZkNs57x+7wi87J5y+7HUd40Ws7676dUf+2v+bmaZF7UniHK3DAHcXspcz1q1hSIQ3Gd8Xw6+23JxP3SUohyNBbkk+Nx3YqMuAxGfJJdRanTnchbXZLdgTfprER/Q+QL9KcqlMHHLqYayCIuzqf/9KdphVxK5uu08/PzFtVb2Ao4hSIVQ6bxRZuxOoyjt3xNMrbJ8+UVOvFjl0pfn+/TJywIhotLvoXYmnCv+RzUrWC1qtcyJwkocaS//wbP7577AaORCAUlMTUITHQnxbuL718GbZ1bG8KhLYK8az7Hw/DLium9uWpPu/Rw3e8ksDz77xwu1caHiKyg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(39860400002)(376002)(136003)(451199015)(71200400001)(54906003)(66446008)(110136005)(8676002)(8936002)(64756008)(4326008)(91956017)(36756003)(41300700001)(66476007)(5660300002)(316002)(66556008)(66946007)(76116006)(38100700002)(122000001)(82960400001)(38070700005)(86362001)(6486002)(478600001)(107886003)(53546011)(6512007)(6506007)(26005)(2616005)(186003)(31696002)(2906002)(31686004)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RTdrTmZrbm9xNnhRVXYwVjZNeGNtZFJUNGtlaStsVHd1Rm5MRDJEb0RzMEJB?= =?utf-8?B?L1VTK0JKdjBycW1sd0plZWdlSkt0REFnY0cwb0lHbEZ0L1dtUHYrd3A0TnY5?= =?utf-8?B?b2R3dTBidWRyQW1GeTFQVWdIZ1JCQkwwOGxDclJRN3BCeGQ0TXk4T01xd1Bh?= =?utf-8?B?U09MWmlJWUtleGN3QXZwYTk3WVgyWlAydWFGKzBOMEVXM1luTGN6bHVPeDVC?= =?utf-8?B?OXg3MVdNbHlyYkg1Vnc3YnZyYTJOcC9Yc3UwdFRzRUpaU2xiQktBeHU2TjR6?= =?utf-8?B?Z3BsUmU0dEprZ3h0R0VtRUZrTlhGSCs4L1FzblgzY0pZWkdDUFgxREhnblN1?= =?utf-8?B?ZGUvSGdmbEdubE9PdHJidFpBOWR4eTV4VUNMUTN4ejYyaDVrNkVtQ3BIcUpp?= =?utf-8?B?bmNFYmJ4dWFOSHJFTi9hR0lWTUc4Q2NBRXM0cDAxU1R1NXh2Rmc1TmN6eTRm?= =?utf-8?B?STdERDV6S1pyaCtCcDhsYWJVNWRHaFJuL3hkVTkwWmxlcUdHdjhkeGMvVWlp?= =?utf-8?B?ZjJVUCtZM1FoU1FyL1BWb3Z4enorSkF4UDlpU0RWSFFuRTBHa1A4MzExNGcy?= =?utf-8?B?bmxjNm9hMnZOaTRIa2FEZFpsZFJvWGk3bUQyMTI3Nm9CRnVKamJzb0JUOXNj?= =?utf-8?B?bGtJOUxWRjNBRldFbnR4MWxXOUlsamZUclp4NERBMExRbVF0MmsrSVdqaUZ1?= =?utf-8?B?aU10YTRkZW9TTWtqK0JVQVJyb1UzeTNvOEZlVmFqVXZpb294VUhjSEZZamQ5?= =?utf-8?B?RHkweTFxMVI3NHhWVGdGNFlzRmdZWlV3OFJtRmUyVVNCalpvTzJ0Wi80aEc2?= =?utf-8?B?eE5QUSt2NEZWQ0FRYkJ0T2dlOGhUVkJoOTRnekFuQmJqMlBhanBzVDZGdGc0?= =?utf-8?B?bkxvMkxQRTlHaE5GdDJTVi9BVVg1SVZaTzVOcUxFMm9LTzdlUzBhUDEyRDht?= =?utf-8?B?VUt6Nm9BK24xWG9lM1A3UVNlZ2RCZ0xTcFQ4NTVCTDUwNldzb2htT3JST2tv?= =?utf-8?B?VzVOcDNVSmE3YUdjRWlSMHIxUW1CMzRoYXpDNE9tOXJ4WlkvQ2V6dDFHb1Zw?= =?utf-8?B?YVJIdFR1RW1heU1pcjFoNjF3amJrTlcwbGZuOTlTYUlDM0RGQi9IY3V0K3BM?= =?utf-8?B?ZmhjbmhOZzNncUY1KytyMXZ2ZmtBV2sxaEpRQ0xaNDlhZlBUYWtoUlZGQ0ky?= =?utf-8?B?LzE5TElHWlZLSENha2dtM1NjSHpVZUlqVUsvdkwxZlFoVVlMeFVjVmEyWXNh?= =?utf-8?B?NU5TVVh3bEJQSk5SdzYzZ3NRQ0dLNFNTSzJqR203K2QwMGxNanZvenNjUmd1?= =?utf-8?B?SkpRYWZramtZZEV2bkYxMk9FbGQrV29zSlBxZDA2cVdTbjNtS2tHSzhPa29Q?= =?utf-8?B?R0R2YWlLZ1BhUVZteFI4cHdVcm5TaTRkNmp3SXVXOGRySTIvWGNSU3NFTGhF?= =?utf-8?B?THlESnc2NFU2MFJlVFR6TGtwUE8vY252TE9SOUZGZW5lU0tmRTlZM2xJMjhV?= =?utf-8?B?dldwMHBEd1pBYmwzWVdXVW4zVit6WFFqbGhhZmpVaXorNjA5b0RQYTdMV09C?= =?utf-8?B?K0dibENOTUEwM21uM3RLQTFMMEhGNVJvZWdJUWJRMFFQRmErc3NTMXViQjNL?= =?utf-8?B?djJqclZUSU4xS1dqL0gxUFBuUVZta0dGQmlORmFrQTJsa05qemkvdlpwSThh?= =?utf-8?B?djZEOW0wbllHQ2RyQU1IK2JaRVBoZmZpQ0JXcHE0QmIyYnpxNG13bElNTk1p?= =?utf-8?B?ZlZUTjVkOVpzck9SU3QxaFBvd09Td1dWWHM3eHFIdG5QQkYraHpWQ3h2UU9z?= =?utf-8?B?Rm9yaitVMnUwZ21VOVZhUHNQaVlpdUNybisyd0syMTA4dE12aUxaWTdMaE9Y?= =?utf-8?B?SjdFZHBjdU02dS9tRkpyQmJ6UkNBZ25MQ1cxN2JiTXJqbGFwdytXdGJKbHFT?= =?utf-8?B?SHFaN3VnZnB2dHY4RWprYmF5eWdYZlEwMitJb2xoQS9IRVhBRXZXYnJ4OERQ?= =?utf-8?B?R3QwQ1lnREN0eGorN0FtbWVpVU9QNWJ5SGpnZ2J6Y2Z6K1F0MzlZeWZXRUdJ?= =?utf-8?B?ZCsrYWlCb25XRUY5KzlPUjVHTzFIaWhOaEFLZU4xMzFCQUk4VXA1L2RVdmtP?= =?utf-8?Q?42bgrq5QlAl6aSjTMpnehaHsI?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Wx/RTwEAFuxRSgI6ezVMJZJY6mIoNw56W+U+SJCpuUO/5FbmljQAZ36NLLklJTanvNrJERh1qqev42C2opbiAhjXA4cjPRT47SS0XjqTmO5Z6fKJQEX0Z6aTmMNXt+e0oV5urMEH8cHWfEzQyZDr86xySkKFG6iKQ8lhrwwf2IjdcD4nQ/noVTJl2tKWt1f2kxEy0K4Gj8Re6KIEZ1BfAMOH/iHlt6LMc4mfx22FutAjsjF3Ls1m6ALezkkjQnl2lLjB7Y66XDxvUvN4L/qtPyxWdwUWdm5Meouw1D+oL/2vJIfOqah9M8mjOfyxaZKAILcxq8wxO80TmqgFbZrx4dgQyKRCCkIhFspr7gcxZEAwJ38XpPUv/ot4q16xvI5xhj5lBPiEfRV19JyeuY4uQ9PI+j1np8w3kHVjDpU4p5CgoyQjgSi3oJVvrpvC7mVE3AIoXiWWj4gBV8f1ZETrtHinpbsD4kpLuhxF9KJSWcVr8IC4hIJp+RdYBoES4qOZRdkeivulpN/Vw+LUfyerP54iajVCfG1lkDYgkEv1DQye6uGHCB8mnmBPakUpd5AZOBcQ29HuFTY4Ur4pdZgoO5Ma4CiAqDHAq4l97DN9HcSPhzK5jBCRwYIFFuvTQkqaLRIHHWyNhEgcBdhAjrUqZc3sczCurqFjwHMBPekPJOi659mHXkyy1YsSgxqFJLxRWDuDZ5a3yimVOtwOVFxkbR1Fc+RFhs1ThSOTxLo+RF7lkVyzXZBt1TPiMaxEK8vRqA/5oJP2zptI14OdCqWgQT3LgK680hkXp+pcQCMvFFd4XsO2v6DjyqsHhUMWtJ4xk7ldF8LemHS3ZuoY0B4m8w== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffd49f22-0664-495a-5bde-08dad24971aa X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 20:36:50.7313 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FTOGpDeW2vYl7McnhFNfzB8W+tQHXpVJX1P6KRFrXvtGej9l7fyT1GU9nc3nn7fMUxLrq12UDek30vkNUMLO0pq2HCnztRdh4LxtZNXJZ78= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6707 T24gMjkvMTEvMjAyMiAxNDo1MSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFVwIHVudGlsIGY2MTY4 NWE2NjkwMyAoIng4NjogcmVtb3ZlIGRlZnVuY3QgaW5pdC9sb2FkL3NhdmVfbXNyKCkNCj4gaHZt X2Z1bmNzIikgdGhlIGNoZWNrIG9mIHRoZSBfcnN2ZCBmaWVsZCBzZXJ2ZWQgYXMgYW4gZXJyb3Ig Y2hlY2sgZm9yDQo+IHRoZSBlYXJsaWVyIGh2bV9mdW5jcy5zYXZlX21zcigpIGludm9jYXRpb24u IFdpdGggdGhhdCBpbnZvY2F0aW9uIGdvbmUNCj4gdGhlIGNoZWNrIG1ha2VzIG5vIHNlbnNlIGFu eW1vcmUuIFdoaWxlIGRyb3BwaW5nIGl0IGFsc28gbWVyZ2UgdGhlIHR3bw0KPiBwYXRocyBzZXR0 aW5nICJlcnIiIHRvIC1FTlhJTy4NCj4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpi ZXVsaWNoQHN1c2UuY29tPg0KPiAtLS0NCj4gV2UgY291bGQgZ28gZnVydGhlciBoZXJlLCByZW1v dmluZyB0aGUgbG9jYWwgImVyciIgdmFyaWFibGUgYWx0b2dldGhlciwNCj4gYnkgdXNpbmcgInJl dHVybiAtRU5YSU8iLiBUaG91Z2h0cy4NCg0KJ2VycicgaXMgYSBub24tc3RhbmRhcmQgdmFyaWFi bGUgbmFtZSwgc28geWVhaCwgd2h5IG5vdC4NCg0KVGhhdCBzYWlkLCB0aGUgY3VycmVudCBjb2Rl IGhhcyBhIHNwbGl0IGxvb3AgY2hlY2tpbmcgdGhlIGluY29taW5nIF9yc3ZkDQpmaWVsZHMgaW4g YSBmaXJzdCBwYXNzLCBhbmQgdGhlbiBjYWxsaW5nIGd1ZXN0X3dybXNyKCkgb24gdGhlIHNlY29u ZA0KcGFzcy7CoCBUaGlzIHdhcyBhbHNvIG1hZGUgcG9pbnRsZXNzIGJ5IHRoZSBpZGVudGlmaWVk IGNoYW5nZXNldCwgc28gdGhlDQp0d28gbG9vcHMgb3VnaHQgdG8gYmUgbWVyZ2VkLg0KDQp+QW5k cmV3DQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 29 20:37:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 20:37:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449614.706472 (Exim 4.92) (envelope-from ) id 1p07Lv-0002AK-Jj; Tue, 29 Nov 2022 20:37:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449614.706472; Tue, 29 Nov 2022 20:37:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07Lv-0002AA-GL; Tue, 29 Nov 2022 20:37:15 +0000 Received: by outflank-mailman (input) for mailman id 449614; Tue, 29 Nov 2022 20:37:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07Lt-00029b-EG for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 20:37:13 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 984df6cc-7025-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 21:37:11 +0100 (CET) Received: from mail-dm6nam12lp2174.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2022 15:37:08 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6707.namprd03.prod.outlook.com (2603:10b6:510:112::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 20:37:06 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 20:37:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 984df6cc-7025-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669754231; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=bDxCvA9XjZ5o06K2B75AnszirJXU/O38c/CsMBuH8KM=; b=Cp2hPsWm6XsZwfhveY//1cBiHtijQWx8tIN+20uzMiOdMBZFgxWq8tG5 NTl/aixtjI5jpydbWpV3x7z5/ZGkoD3rhtcAouBUwp/WA2I3JGfGhVmx1 4nVS3OPbhas+8x8jvCZ7Q/kK1J9uI1PzW/9cD25B34rpWrw7BO74Cd9vd w=; X-IronPort-RemoteIP: 104.47.59.174 X-IronPort-MID: 86224706 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xZ0JXa3xcXwWD+6O0/bD5fFwkn2cJEfYwER7XKvMYLTBsI5bp2MHm 2EcD2uDOa6NM2Chet91b9yw9h8GvJbdmNBjSFQ+pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVkNKgV1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfMEVKz r8mFBE0aiup19nxzu6cVLY2v5F2RCXrFNt3VnBI6xj8VKxjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsi6Kk1AZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXOlAthOS+XmnhJsqGOY514RCx8xbkaYoMGmjUXkfvNZB FNBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9W9Vna15rqS6zSoNkAowXQqYCYFSU4J5oflqYRq1BbXFI88TOiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAsjA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:rQIFn66EbUykzPgb8wPXweCCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpixBiSgSiu4LvaFQHd+hsFSTtAzZor7G CAymXCl+SemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQBiTwhh2ubIFBXaTHmDwuuumg5Hsjjd GJiRY9OMZY7W/XYwiO0FXQ8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMk5 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvvn+9Ua1wWR4S2rpXV9 WGP/usosq+tmnqNkwxi1MfhOBEmE5DRituDHJy4fB9mAIm4UyRh3FouPD32E1wtK7VAqM0md gteM5T5c5zZ95TYqRnCOgbR8yrTmTLXBLXKWqXZU/qDacdJhv22tfKCZgOlZaXkaYzve0PsY WEVEkduX85ekroB8HL1JpX8grVSGH4WTj20MlR65Vwp7W5HdPQQGa+YUFrl9Hlr+QUA8XdVf r2MJVKA+X7JW+rHYpSxQXxV5RbNHFbWswIvdQwXU6Iv6vwW8XXn/2edOyWKKvmED4iVG+6Cn wfXCLrLMEF9UyvUm+QummkZ5osQD2LwXtdKtmowwFI8vl9CmRliHlktX2poseWNDZFrqs6OE NjPbKPqNLImVWL X-IronPort-AV: E=Sophos;i="5.96,204,1665460800"; d="scan'208";a="86224706" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UjcWyQQUZenznn/phKAuySi/Ptg53WXXb6WCnq7Mz0cf5jLMFU3Yx+gX+MVZlYqgsMAn+ifLjU/svBRyqjobv/B4WJlENvKJzr+qaNkOXmBao6c8ET+gCMRoV4deqmF4d3tvQqHK6s0leEZc6MWxwLfwY51ultZI9c8qs4Oz8Z6Iw0n6sk7F9w5pnimUlXlrlPVPOfuEmGDAMUqiCN9Mk/N7m2Pcfiu2qlh/1gU8YU2q/DbdsRtf3leFzyBZB9U9RXGECsPPdhCBVqu09O7AxhoJt1eO+Z/ONZJfwj3JpG2ZlgkdNnxSm3wvEoOHOg74SzcMDootTCYHulx6/cma/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bDxCvA9XjZ5o06K2B75AnszirJXU/O38c/CsMBuH8KM=; b=BAovEXU+VmO1TUs0WIBnk3QM89oxkzihSRWIXMx82LneJL86jja4ostXcEHwHyDToZHbsR2HhmfBablqFF1CwbtVCiu6+Amqeo3Qr2nUR0TmMVcBkK3qjZwlFer/21+0eqd6407Rzi62O06k0fedFvFy5LDsU86WlnRDKRGHqJa/+pFq9pFZyUsQNNDFL1tpFKKK4EfSJmDhJmy6vAOgJZu19GIrDIkRtetDEMQtsYcQhtC6evH6R16lsuGsAJWLkXiBCaAdk3c33XEu/OAJsPZOewlsGItrUrJqueM5hFHcrz81ldKFNu2yPyXTKz9om6UU5XQHnO2mfA5vSYlUZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bDxCvA9XjZ5o06K2B75AnszirJXU/O38c/CsMBuH8KM=; b=WHtTKqrzVxzVt3FRMoQueeJhIIHq5I/fahwnX/jIXXNuGTGx9rEYgYb7C3FUIdOn1UFcSz0hZssEs0tHYBNwsb6wiFAISbYN4s+UF5xseQU0kvAPtIvTsnlo6GX+g3WGzTqaADB2s7AY3gUrwYVwAg6WzT9gRbyI6ZPz/QXDzyA= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH] x86/MSR: use latched "current" Thread-Topic: [PATCH] x86/MSR: use latched "current" Thread-Index: AQHZBAHfUTfAg3OK4U608Se22l8Hja5WXKwA Date: Tue, 29 Nov 2022 20:37:06 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB6707:EE_ x-ms-office365-filtering-correlation-id: ceeba72b-1c26-47a3-5e4b-08dad2497afa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pED6DMKtsFQUtvI0Cv8TrAsg3kbVXmzBLu51JL8X8K2Xy2DoXRLtEuMU76yMjurWshL9tobUoKkK/0hV3H5E7Uwxe/pcw+qHTrSGS9ThGG92y/8hTcn9A74Wkh5V25nfrX+i5E4DABmzyhmdfelXkUfysja3DiY5L8dxsz/0lEPL//QWNZTWEyF3RlRfpnIpjpmOQXC2orDl6IJSG4ETBKdoIyetkPZNTaqOr5a2ngOgzWIpb4GKYglcv7v2ysY2+JELmMR7khio2lP/qAmUccO3iZX/T3ki+SYP0bCodcEIHXuwfDi5OfsT0TDP1KEUm27hQGiCY+A5DNG1nNRXRMRO+V8WmD6llONeVLd/JuIK8hiHF+4DZ2q5fXZ1y5Ga1lbXipXOlbqUY8RypM+cLnIbF5jjflEzGGlcbgw/QRgfPlA1dLyz5cPTURzEaE3MB/T3imi1T6JVHW57H5aI7EFR0D3G0BR53kM9lXQInMu3pzc1WB/e726XdZRdcEsGDuWHlt1fByccrr6fCArbpOgdX3vt32jx7V7koWC12jfGoqlaMENejywr/s5Edsw+ejweDbG7V13nYDNnTkk66Pl+jXWPsC1tNp+FOKBd1R1N8YmL3bxcQYmgq6FQK34z4A9fz7ELLaNMqJA+n/wKHipIWyfMp3JZdxlL2a5Lk9pgJ9Xv0fHN+sg0zddmFfUzCBhv4UygoFdAzqxiMjYGesS1caorBIBhokOXroh5vUaUIplrufUK/95wYfo2GLlwQQOSXS8lPPNGWqt+CV72GA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(39860400002)(376002)(136003)(451199015)(71200400001)(54906003)(66446008)(558084003)(110136005)(8676002)(8936002)(64756008)(4326008)(91956017)(36756003)(41300700001)(66476007)(5660300002)(316002)(66556008)(66946007)(76116006)(38100700002)(122000001)(82960400001)(38070700005)(86362001)(6486002)(478600001)(107886003)(53546011)(6512007)(6506007)(26005)(2616005)(186003)(31696002)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bXFBU0Z6TDMyQm9MY3AvdVNTYzZuZUhtWlFFbGp2MW1wUDZiQ2VMTFJ1TzlH?= =?utf-8?B?Si8zVnU1eUZER2huQjgrYVM4V3pwc01vSDlVOWR5TzgwNEpQZkxpdm9XZjho?= =?utf-8?B?QkJTelFMKzFqdXYrWFZNNitoOEgyNDA2UFU0Q3ZwazFoc3dGS0dob3BHWTZs?= =?utf-8?B?eEVHZ29iZllEMmZ1a3FqMk9SQk5wK2pPaGpuY3M0MmZOM1FLMlVRblBrdnlN?= =?utf-8?B?TWVpVW9odGlRTjJHcm53Y2FvdzcvU0xHSVRVVGg1UzR6azk4bytNVFVvakdJ?= =?utf-8?B?dnE0bGlkd3FVQjVzKzhibHhMZWZ6TUV2cEVhYnBYZDlvamZtV012UWFobk1Q?= =?utf-8?B?MmFraExqTkYvdnArZmhNVFptVkxKbkRBVkQyOGloMWR4dUcxMHV3NW9SMW5k?= =?utf-8?B?bGV1S1NLaTJ4TUpVakJxVDRIN2ZFR0NLdEJsaVZKMVl5Z0JiSlVsZU54OGdV?= =?utf-8?B?dnIxQVF4TWZJL2c2OFJodEtNaGtnLzlJMGRhcWFndm52dWFuN1BOZGRnS0dG?= =?utf-8?B?bzIyenk0TkVRRUhpQkdKc2tuN0ZabDZnWkRFMkFzaWQxOEJPT0ZHUXpZMUlq?= =?utf-8?B?cktTYk4yLy9oWkRJb2hPWHVXUjNyRlhSZitzSXd4eWo0akttV3NUdVdjYy9F?= =?utf-8?B?bE1iUjErVDBSM05CdmZKSnV2dDNQNVczcEpFcnlVMDQrNHhOa2Qrd2wxUHh3?= =?utf-8?B?em03MEY1ZlRFZXkzYmdYWWs4RW5VTndMaFBVNm9LeHlqNURKNVIramJsbVll?= =?utf-8?B?R2h2U0ZYV3dCZTRidHBxNHVIbnVhQUp3ajV4aFZxRXM3Vi9UOXU1RTFsVk9l?= =?utf-8?B?RStIWVNWdS80MjdJMExVaFo5YU8yY3pjZmZIMUJyclBYdDAzN3h6MEkrUWJH?= =?utf-8?B?ZGxJbFZ0ZzVMQ1VmeXAwY1ZHeC8wbytmbUtkbStaZ1Q5NVFObGFxM2dnRW1C?= =?utf-8?B?T3c4L0VEMGN6bkhPMjVMdjRSRGFVeEQzNTdYbVdGUTBJQmx6THBnM0V4NTlI?= =?utf-8?B?b2RKUnU2OEl0ZnlCTTdFMUpUYm03OHNWYWk0SDdBSXNVdVJjay9yK243QW1B?= =?utf-8?B?NGk5RXo1aGMzRW5IOVlLZjRuZEJtYjZwVWJqK3YwZHBEK2RiNzhXRHlKV1ZY?= =?utf-8?B?TnR4UGEvZ3A5bXkrZEpUMGVVelVBU2RIamI5ZDVLcUZQNGNVTkFWalgzRzlH?= =?utf-8?B?MG9zZFdQQUFZdUtDZmNSM3gzd0RreHdsWTJwVlBINkVhTVNHUnJEZ3o0alFC?= =?utf-8?B?QS9PdWhjbnpxN0JGMzdtVXlpMkxUQVhkM2pTTzNLYUdoNW1TQlpCZjlWTG1i?= =?utf-8?B?RmZBSVdsam14Y0pIcnNVTUJ3ZTcvK1dxNEdldTZCc3BiaWFjdHlFa2QrS2t0?= =?utf-8?B?UjlJeGdIU1dOZyt6aFliR2ZERHNQUEJtbHcwa0ZHdHhSK3dDSXgrWHZRU05E?= =?utf-8?B?MVBua0FhQmF1UEVscE4zWjI0b01zekUyMXB6RnFqdytEWEQ5bE52WE9kc05T?= =?utf-8?B?SXVCSDRHbXZibzB5VXU4TUk0Tm9pVHFFOWN2QXJkRC9zN3MxNkVSbUpKeFdE?= =?utf-8?B?allUd2VncStNOWZFbXJIU2pNYllzNmM5cTk0L3RjQjJzdnUyVkVuckFHRUhC?= =?utf-8?B?dWc2TzU3UUFPeXRjeW01aTFuZXpRYnVyUnM0WHNzMDZzK1NzRlRacUJMbmRt?= =?utf-8?B?b3VHOVUzTHkveGg1aERnOU1BVDRWY0RvZDZBMmFseWlESWpLbFJZZHIxLy9p?= =?utf-8?B?MVlGK0s5TjhBWDhmVitOREptVGdQelQ1RHlQODZiVDgybUlaM0EwdzhTRTV0?= =?utf-8?B?L2c2RjVFUUJEN2pzT3Ivek5XOWpGNGQ5QTdvY2tqVmcxTW5QUFpQdittWWgy?= =?utf-8?B?SElzRFBQQitoR3dWaUFIYkJNT1Fuaktnck1Yc2xmTEY1NXVLUTN2Z3UwZnhS?= =?utf-8?B?cjFoZ1VDeUY4SDdJRzcrMERSbytUWExVVThZVzVaL0V5bVUzS2x1NnJkeW96?= =?utf-8?B?SDZnak5EU3JpVS9RSitnWHJJSjZIQjBDRHhzOHBlR0M1NVFCeUlRZ2Q2Mlht?= =?utf-8?B?aGhJaHZMdGx5Q3c3K0o4RTFseGVQaE5DQWZ1R3J0Z3lXTHNRWHgwQjVnVnF5?= =?utf-8?Q?G/kKQvolrEpqkWlgVH6C0GzgI?= Content-Type: text/plain; charset="utf-8" Content-ID: <482BB4205EE0C040AFEEA031A6100B9A@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1/099edI7rXDt3N+EZAkeeJpy2rkTE9eKR/cZKYb8tYbVf44RpkwuSyqqc3T3BAKNeGweDsWsm66OLyvUhFisj44IZuvT61lmyxbPVQpDgwkhWjencSA5JuO/Av1nRaSjowOTzDxiQSckIJnU98Bim0gTi1qmhpw8xlNP7qKYzrNQnv8XWDBgjQ31L1Le+Yp/gxeJ/5hFMNmAT/S3nqnUBW+wiwb1159pFhmuMvdUJgsC/zIu7+zTn03y1tqoEIHGNvAeys0eOcVkKSGVur8QarURIA9RgDthEgMtuX3eM9Pg4y78yiWfmt2uF87fIz2lvoeI0DvKdz6g2fs3oqdlct6GG+tafqTFP177r/jJ7F44LSldLbCgiyCOKw2bQuEGLdL3iw1O4d3H8iAu4bWZ6+KIzLrHfGdgWqm9NY3mtfAHYD98BhVhph+19qMZja+TY/jjuEgR0S+setlk+56+1CkoThXchDWY8XwvEor24HVWMeVXPPbXqQxwpsJeCkJZHAaZRKNwdM4QR2tMAlBRn9iUHEQVbUUJsEhEp4B6uu7nNSMcjvi++Inl3WDOjpohcelOJ6palY/xf8fFWSgELUZeYP2yhUGt4GD4hQQFELkKRtla9bYunxaydPzlS00YeN4yfLIPhFtc2BCIQusq3NaOQgMu7koMZ2uPx3sKGUbHIOct4D2pBwge99JPbYUfXC/cIXbNIn5RlVoKpI3cKxBdGzXPvrDIt+0/vo+FlXwfCN+rCG3u9qmGJk7OXp+7WzQ19/mQgxsOF/IHlr6V0Yu8ilQKzzwkHh2QyVpwafDvNF2PSM3n20viU9gauHEKenbl9Os1eJMsGyoG3ePgw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ceeba72b-1c26-47a3-5e4b-08dad2497afa X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 20:37:06.3395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +VgivARiMED3uzULRZELwJOiwsWZl3bxF15WynyaaESAkddC12WMpuLZN4DXLKKzAHYOfhprKhaUsYJRibSs6BC+6VwEVD6eaepUUrNTYxI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6707 T24gMjkvMTEvMjAyMiAxNDo0OSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFRoZXJlJ3Mgbm8gbmVl ZCB0byByZWNhbGN1bGF0ZSAvIHJlZmV0Y2ggdGhlIHZhbHVlIGZyb20gdGhlIHN0YWNrDQo+IChw b2ludGVyKS4NCj4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu Y29tPg0KDQpBY2tlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4NCg== From xen-devel-bounces@lists.xenproject.org Tue Nov 29 20:37:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 20:37:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449618.706483 (Exim 4.92) (envelope-from ) id 1p07MJ-0002le-Rl; Tue, 29 Nov 2022 20:37:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449618.706483; Tue, 29 Nov 2022 20:37:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07MJ-0002lX-Oo; Tue, 29 Nov 2022 20:37:39 +0000 Received: by outflank-mailman (input) for mailman id 449618; Tue, 29 Nov 2022 20:37:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07MI-00029b-AC for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 20:37:38 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a7dc250b-7025-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 21:37:37 +0100 (CET) Received: from mail-dm6nam12lp2171.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2022 15:37:27 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6707.namprd03.prod.outlook.com (2603:10b6:510:112::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 20:37:26 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 20:37:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7dc250b-7025-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669754256; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=ydn3GwldrFnYARz4l62QS0t6WNVic/vs/te3E0tkNm8=; b=NGXKtxncIkTW8P23nDLmXu3NaDJq0CqP6abCEkyRnpyY5ZLmTje+zpml ptcufiEKg91AsjTXliDrIo3ARXReAofwEEPg/iVO7w3o8cjECIBzSkGtR 4h4Z8vsTHM589dVg6KZ3tedvVMO3M4E8nxL9rHXlpyTJAjEInHY9d6tfJ M=; X-IronPort-RemoteIP: 104.47.59.171 X-IronPort-MID: 88337397 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Z9+afqvvDA27d3WYJqr+spGygefnVJxfMUV32f8akzHdYApBsoF/q tZmKW3XbvmLazSnfd10PYzg9x8CvcLSz95kSgts+S89RXhB+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaExiFLZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwdS9SMza6m8aMz4mVUq5PhvYha5f0I9ZK0p1g5Wmx4fcOZ7nmGv+PyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgf60b4O9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPO3oraU12wzMroAVIBAQeFCBuKaTsW27fO0HF EsVq3UWrLdnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8ry62OCUTBX8PY2kDVwRty8L4vIg5gxbLT9BiOK24lNv4HXf32 T/ihDc6r6Uei4gMzarTwLzcqzelp5yMQgtr4AzSBzih9lkgO9fjYJG041/G6/oGNJyeUlSKo HkDnY6Z8fwKCpaO0ieKRY3hAY2U2hpMCxWE6XYHInXr323FF6KLFWyI3AxDGQ== IronPort-HdrOrdr: A9a23:49JDWaiYEECTo8t7s5lcdzZaXXBQX/J23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu17h/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboXgTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp9KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wXh4SqbpXVd WGPvuso8q+QmnqKUwxeVMfmeBEa05DWituhHJy4vB9nQImx0yRhHFoufD31k1wiK7VDaM0p9 gse54Y6o2nBKUtHN1ALfZETs2tBmPXRxXQdGqUPFT8DakCf2nAspjt/dwOlaiXkbEzvewPca 76ISVlnH93f1irBdyF3ZVN/ByISGKhXS71wsUb45RioLXzSLfiLCXGETkV4oCdiuRaBteeV+ e4OZpQDfOmJWzyGZxR1wm7X5VJM3ERXMAcp95+UVOTpcDALJHsq4XgAb7uDauoFSxhVnL0A3 MFUjS2LMJc7lqzUnu9mxTVU2OFQD2KwXuxKtmuwwE+8vl/CmQXiHlltb2Q3LD6FRRS9qorYU B5PLTr1qumuGjexxe701lU X-IronPort-AV: E=Sophos;i="5.96,204,1665460800"; d="scan'208";a="88337397" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GKwai/A221NuoZnKGboUsr5Tx3pwJzHGClky6nVPuZazxHf3i5V/jzyjwafzYSRscbbyt+LOz/pheG0dEX0rPDofGOK5EaEJmYasLxwc4O2vMmvy6SUPkuSVyzsc2dN6IdR39rQj3ChBtgWIwThQcB+FfZ6f13HUTFg6gw8LtZzbP/I/x63Sppy4j+6SeQZQuDIQOfZAO8byDUGafKBig9Txze5AMYrFLQcpioXMJ9x/DOOnnjGQnf70dNoAfZG2bEgqRo1KOOMdPvM6bXhYJS64THkWCI65daVgeV3x0UyUIJg9ZTtT8gf2wzTIFJLZcAmDypRZd6mmSQqydzchDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ydn3GwldrFnYARz4l62QS0t6WNVic/vs/te3E0tkNm8=; b=HTqQdtKx5lmne6byAs/WvKG2QBthcVYRXtvSkjnKaV+0NELmqPJqwa+lSZg7KB/B38YwIO9sjCojFB2pwfIuT1iqxqjC0AlTcRPE9lKRpWVfTcKccFJiD0a2GXRQn+WomDr30ZpS6FBrPPvgtRsgskQELHfA7BeM4SzKXHhaxSLrLf/bmRatj2FVKjYfX4yMRNMsnboYfZ8vK7FHMI5dwskAj64ud7L+pCAAaJtAhq/WTPwTTXc0hQdaPC+sfPMBr8d58tUUoh+RETfLyz1O/ugio3MtZBBwNLKXCapsh37rE2fzo6sKw3nmeaZtj2nVPL8E5jto2FLQWjIfZVoOuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ydn3GwldrFnYARz4l62QS0t6WNVic/vs/te3E0tkNm8=; b=n9vfBJK7GZxY7Ql9iHAAvhPyMkGnpoNaRBqYc8ZtF7i0+LCOXuBetVVLmMLTjLJ3aPrIhTk7HhEDVe2amGPSYgx1cqjC7361X1PfSsKTpdRUcJWyymQ9zdHuF9zagD/+BbQNAh8dHOsWmnGZ+3Y3+CoayJ9uNuTRMDSxV1uZkzI= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH] bump default SeaBIOS version to 1.16.1 Thread-Topic: [PATCH] bump default SeaBIOS version to 1.16.1 Thread-Index: AQHZA//5sKDKhmJOE0WyLAXwID/W5K5WXMYA Date: Tue, 29 Nov 2022 20:37:25 +0000 Message-ID: References: <22d39f29-d87d-b3f6-d601-85fa1d4a72f7@suse.com> In-Reply-To: <22d39f29-d87d-b3f6-d601-85fa1d4a72f7@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB6707:EE_ x-ms-office365-filtering-correlation-id: 57b03aa3-343c-4e64-af16-08dad24986ac x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KsIMWrYjKTIsN6oavAIxs+TJ7rSOB8aj0S7ryRqhEpY+OOzO3MqXEVE6HVpvWlKRPhXk0Iubj+ii1Boy8SEcZsTHZ0JVw6h3KRZAqV1t2rpq1vASlNsfu6SU85ODSlqNuR/ho6cTO91lxNCvkT1ERFZNwH8+9sJIrlD8n63gREvdhRsgtxJj+5CPE0DYAcI8e3d9LgUhYOnGs/IK48Omc6Ddiy+SIQbZI3z6+ynD9ERyN8GGFos3hxfss+INwFe4IfRYTEUxYo/sw9WOnO2c+xceiNZWdhs1ZduF6CgBXCf2UTCQtiSaxp3/PH/m9pfuYQzmL9QS7kHG48RiODJ0EqWDwUDXFZrSP/YwJmbaL5TdVaxoEV498Qn+crbyT2zwQLsgBNgkXqpq5ve+h8XxsDSMgHPgBFcaVr7+XGn+DwVA2/NxpZvumUssNhLSENo1hgkcuVa8bO0oydBYT8B8MaoTDwpxlpz/A5O7EDSJo0t4c8vHOU1ORdbNwVXE+YlKtHkBDaLyXUAP7IiJVh/WqH4o3GJCcAp9zmCyrkV7RFR09e2eiRetJ90ceIHr8aieaeP5WOebhgwIYSV7TVZxBkvBiUaMdL7D3T3am7Af4S/CUOY4pPSZgO6KQ5ePp/AApHaT3JANuh9KkLKYROp/JqcGbYzKqYAyr6CPV5PF/wiebqBPv9D0mgNuQIi8p0sXc2aHYJU9Z3xu0JY6yxuqnxTteivtZel7MRiDfAqlcD4XvJDUcLfSKOYihMivGLr/oVOfCOqApjqSNhfMKlikLQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(39860400002)(376002)(136003)(451199015)(71200400001)(54906003)(66446008)(558084003)(110136005)(8676002)(8936002)(64756008)(4326008)(91956017)(36756003)(41300700001)(66476007)(5660300002)(316002)(66556008)(66946007)(76116006)(38100700002)(122000001)(82960400001)(38070700005)(86362001)(6486002)(478600001)(53546011)(6512007)(6506007)(26005)(2616005)(186003)(31696002)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OXA5TkZsUWxCU2h3WmlLblZSQmRlcTEzL1FBemdQY0JjNEIrMXAwUkFRN0Ry?= =?utf-8?B?KzJyWThQNG9XUmsycFpMZEVlVXZZTzRzbGRHSjR6cXlpWlZyemtsa1lzeHda?= =?utf-8?B?R09jOGh0aGxMNnpHNXVyRTVhM2t6MGMxMWFsM2pJTTdhL2tWOXByc2ljMEFX?= =?utf-8?B?cU9NdzVsRTJXaExVRWlKYmtUbkcwQXlCbkltOXN4ZjY3NTBqN2xCTmJ3VkhU?= =?utf-8?B?ekZWcTJPSW9xRVc3YWlGVlU2ajI1SlZRZjhCZEl0YjFrSURXc05FWUhjVFlr?= =?utf-8?B?ZUZ1aTFaclJ0NEV1dXZGSk9ZWkt1dnd1S2VpemVCcGNKUnh4bDlvUHg5a09O?= =?utf-8?B?MHRnQjFqTFdkQzRKZFFUUnJmelRhbjZJRjlCSDZNcHlVc3QrTGRGNnlyZ3Vh?= =?utf-8?B?MVQxdWRBcEhrSkViczdicTJrZkUyeCs4ekxSaUd1U1VYVWFZQ1NHbXhRbW9P?= =?utf-8?B?U1lldTQrUmhoZlNaKzZ3ZGR0N21FWHlCWC8rVnUzakJWaDNQOGJ5T2FkZU5x?= =?utf-8?B?czJ1TkwvNEFSY2h6RmhRaHdoSDZtbXBycW5oSkQyTmJXeW9wbVpRd3Nnblo5?= =?utf-8?B?MmMxZ0dNWXVTc05uRjJqbk5YVkNkU2p5Wmo4amVXTzhndmN6UlZYNTNrK1pn?= =?utf-8?B?UXNyQzZmUU9oVERNcmp3YWMwT2ZqRDNWRWFwWWk0REpFTkJzVGg2LzBwclBz?= =?utf-8?B?YWg2TVpZYmVxK3lQQzhqL0IrWXBhVXYwZCtwL294QVE3UmQ0emY4aUJVT2g3?= =?utf-8?B?TU5NUURqc3RFejdxU0dKSE4wY1l1a05EZFRpOHIzS3hsai80Y2xiOEFrUXpH?= =?utf-8?B?UkZaTkhvMkU0L2l0bW1RV0JxUkFXRkttRFNNZHRPY0Y4TmVnSHRJOStCV0Mr?= =?utf-8?B?Qm5tSjU1OFRWVmlyaTJta2pzdEtQR0FUYkNGL2J0b3dENWgyZ1hmaDNrcHAv?= =?utf-8?B?Yno0RkJBa0JXSnYrREZDNVlUNVFpeGpDOThWeGozNWw0VjkvL216SWY5YWN2?= =?utf-8?B?d1lHUy9GMUxCWkR4RjdCbklpZUhGM1VXUTAyT3oxRXJkNThRSTlhcFlEUUFW?= =?utf-8?B?cWVQOFE4ZDEzclpQY3VQU3czdTArQTV6OVNpTldyRmhhbmtncHFCdUFLQ3c2?= =?utf-8?B?OUNBSXdtdWc2aHNlRHgxd28xUzh0VHRNVEIzNjBzV3ZVaVZzTTROQzRBTEor?= =?utf-8?B?NllTV3d0K004dmtrbCsvTXBIZ00yWmR4ZWdwbUd0cFJpTjcwWnpFVTY0Z2J1?= =?utf-8?B?ZzlETTN2ZFZFTmFxTkNtSGNaaDFqbi9BYm9iQWRia296cjhYYkwyNDZwQUhO?= =?utf-8?B?bFJla1p3TVFyTlhuS285STE0Z09KUW1pRDJvZTBkMVNNTXEvMDN5VTV5Z1hD?= =?utf-8?B?VWxjVXJaWWsvRFI4QldEVEVFTG91ZVhzMTRBU1Y1UlBqamN3WkthWjJLM1RZ?= =?utf-8?B?MWVmU0hQcU9TWUIrQWhrdklJUEloVnFNcHU1RW1Qb0p0ZE04c2g0aWdGUHV6?= =?utf-8?B?YklvOFhzb01UWWZESjhhNmFBRmloN2d3WDJoT2xLZldzbVVPWWZ4c1podTd4?= =?utf-8?B?UFdvTkZZNHVsOUkyMDBFcHRtRFpwMUdXYllqd0xTSzJGTEJNTjFPMGNjaXI3?= =?utf-8?B?amFldDhOazZ1RFA5L256KzdFaGFpQkI3TzVhOEN4c2xEOWowdDQ5RnNsNmgr?= =?utf-8?B?V1N5cVNzUjZHdnhranZjOW9ZWVl6ZTZBdFB6dG1TWnNRUVdhV0ROVmg5WHE5?= =?utf-8?B?Z1BlNUJKSGlTK1F1L1NHdVpVaTJ3R0UxUW1pN1lRNjdqellFdjBCSFJ4N3pS?= =?utf-8?B?bkZFcFJFR3VPeE5VQThYaU50VHl6eTZLeXlXc0F1UUdPSnhIZnFCdmlhUTl3?= =?utf-8?B?cWdTUDhxcnRVS2FKaE4wR1pHbnVJYkZSZmhSZE52T0pFVUN1QU5weVVHeHMy?= =?utf-8?B?VVFaSlZYNmEwSVlRaTBWNndvOEt3VjVwVVBHM3hiM2d6ZXFwK2JIQlkwQlBY?= =?utf-8?B?SWYxTmFwcUg4aGRsemRmTmxnTVlxYUx6c2lHUFVpTUpHVnVvOUY1SnBZd3dF?= =?utf-8?B?VmVYcWMvUmRnMk1RN3NkaXU1K1JiMTliVm45N01PbDdCWDlIRDF5Tk1SYjJS?= =?utf-8?Q?FmRLqIGcJCf6oakX1OUB/EXsz?= Content-Type: text/plain; charset="utf-8" Content-ID: <0C1BDB09808C6242A0904B99A75D094B@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: nhf+0sp7AhGgiST2Rx+j1aW27k+RYHiu1LuyuBeSvsMz1x0ERaZLsF0Sk+1woih4470VEhCW69IGqmSdDELfkDmNglx90kbpw3ZOWg6HopHFqoJIBehTNPOm7v3iDHT0o4Sz2UyE2iV2JV+sJY47heiqkFqRDNq1UOJHFVvfI85kooe4Y8DbGvjuPkjcRR8jl7azlrU44GXfVbKCJg88BB96hnPDVKXP0Gk+k2KSkZSaVT2rvqtShOEpRYZA/gi0Kf+fSV5hWX82XKTYC20AoramXZRQrVx+ZlXj+IJg6uT3GkalIw24gKzMYgqWllhADpTS5ZImpiRLgbT+YGvqYmHSibNzM4epKtvYtoQef1ozz9CH7mVzxjLBw+EwGZdOLUtJP17cWhDG4iUVRSFeTwN1NiDMBGBpCCyLKH1SF5zvz8iuw7SkmMZk5hzgdRtttdPTlQKx0kKtIVUfbsSS7slVSx3zYpAWtlkm7U29kXHFKrlOCXz69V1GpHBzgl3l/AYxt296M9KiTQdXmC9rHO13re5jEkWVZG9RN2h2hHk5MJ+EsaGilR/2Wvirep5BHHN2wDTdUV0djv6Z7RtkJ04ATnY3ewdCm0d834Sv/us8ROR0d+QkOZvw/1TPAiOAX+rtSfNg7ntWmka69GRpl8P5EBawN6zphYI24aI8iTks1LMH2w5+l/vutdPUJ4vb4Mtsu3PBM6/AhJzSCMoOZkzG9ZC+jiiJQnkJFWyDwV5ovhjRhVVFxfI8s/zCZjvVRk4I+s2IMljKs7CQQtk+qzfUu8Wbtvu09DBTe7x83mtgTX0rZYvk0dA/Zu7j8qc1CcvwjZtMeuiIIYSuPbbFlkZVaGTLNEJ4OaYXyEIuwbuVW9zx9klF1hkElsG565aN X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57b03aa3-343c-4e64-af16-08dad24986ac X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 20:37:25.9787 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mPYOFNeDrZ7Lr4ZKunQmbQY7HK2o+BHukAJJPc5g8cvZ+2F3R2LIYK+tnGEjzyBkijHpUiUfCHSW+gZrhA3JtZqkTdsns5FAtCZ/i7Sv3iQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6707 T24gMjkvMTEvMjAyMiAxNDozNiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFNpZ25lZC1vZmYtYnk6 IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KQWNrZWQtYnk6IEFuZHJldyBDb29w ZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 29 20:54:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 20:54:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449630.706494 (Exim 4.92) (envelope-from ) id 1p07ci-0005w0-Dj; Tue, 29 Nov 2022 20:54:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449630.706494; Tue, 29 Nov 2022 20:54:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07ci-0005vt-AQ; Tue, 29 Nov 2022 20:54:36 +0000 Received: by outflank-mailman (input) for mailman id 449630; Tue, 29 Nov 2022 20:54:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07cg-0005vm-RB for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 20:54:34 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 06cdea99-7028-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 21:54:33 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ADBDDB81912; Tue, 29 Nov 2022 20:54:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11017C433C1; Tue, 29 Nov 2022 20:54:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06cdea99-7028-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669755271; bh=E/t7LbbL28l1GWStEPbOEvjgfse4bDYrePnSOE3a1PU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=lmhpVXVRBaUQQtmd9HiwC7TdGz0QpJi4bQnSRQXjq90VMn9rauFShDShAj21ZDdea SpjkY4jnKnMYf2T9YYf1aFLtgpwNVHUnxEKHuLjE0X94DlyWMhE0RBdBEt6ojOhemT n8fBYssNgDMTp5UI2DB5IkamXwY2k0meYDcMg9nuxiBjjY/NogmgKdoUsUrY4bdCR5 kG0ahS/T7rh3YygCar01SlokelMYInzErwhchkXzSEYaNpjo1zjCVbD3RdWQSRT8Mt ADq/dEX0f1D/Y/YHJhuIEjmZx8P0OsJVbStjz3YTSK7by3ASigLDQYT5Z6P0z/+UP6 PaGqbUF0UcyJA== Date: Tue, 29 Nov 2022 12:54:28 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: "xen-devel@lists.xenproject.org" , JulienGrall , Andrew Cooper , Ian Jackson , George Dunlap , Stefano Stabellini , Konrad Wilk , Tim Deegan , Wei Liu Subject: Re: [PATCH 1/2 RESEND] CODING_STYLE: explicitly call out label indentation In-Reply-To: <7072cc5e-8137-762b-53a1-c4a80d19ff08@suse.com> Message-ID: References: <7072cc5e-8137-762b-53a1-c4a80d19ff08@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 19 Jul 2019, Jan Beulich wrote: > Since the behavior of "diff -p" to use an unindented label as context > identifier often makes it harder to review patches, make explicit the > requirement for labels to be indented. > > Signed-off-by: Jan Beulich Acked-by: Stefano Stabellini > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -31,6 +31,10 @@ void fun(void) > } > } > > +Due to the behavior of GNU diffutils "diff -p", labels should be > +indented by at least one blank. Non-case labels inside switch() bodies > +are preferred to be indented the same as the block's case labels. > + > White space > ----------- > > > From xen-devel-bounces@lists.xenproject.org Tue Nov 29 20:54:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 20:54:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449632.706505 (Exim 4.92) (envelope-from ) id 1p07d4-0006KZ-LR; Tue, 29 Nov 2022 20:54:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449632.706505; Tue, 29 Nov 2022 20:54:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07d4-0006KQ-Il; Tue, 29 Nov 2022 20:54:58 +0000 Received: by outflank-mailman (input) for mailman id 449632; Tue, 29 Nov 2022 20:54:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07d3-0005vm-Bf for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 20:54:57 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 13ebe199-7028-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 21:54:56 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DB3E0B81911; Tue, 29 Nov 2022 20:54:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 440ECC433D6; Tue, 29 Nov 2022 20:54:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13ebe199-7028-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669755293; bh=LbuJtK1K4cStF+SJ7QUPzeBsbntOqYZ0jHDRVQN/y94=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tvrVOwAJSuunX08TNkPN58lU+meZeOLUnA6XNbUvo01DeYHrEVleyUx/EhjcF9jj9 LnI6VMGJEdj96WLo/0BjL551KZHlzDGimxtLlhu61eLVVPIUKNrl8w87CwgcMNQg0I +swQn0K1iLaESjH+wJmpEbetmpOyovGeyt6Bffz5XZJSUA0BA0xXrmg+SOU2ETRsXD KQVtH8dwEfUFQAR+eLQDPVI2fA8h+PEvTn5ESa1CZUQcB59asLOy1hW+SP0+YfZtMi OHGnwZL8kvCoHFBEUaOZllIUyFOKi8DEDKuNkfq5FnA4PN0hiyOMPKCq5xUzMVxkYT LxP9djf8xZWcg== Date: Tue, 29 Nov 2022 12:54:50 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: "xen-devel@lists.xenproject.org" , JulienGrall , Andrew Cooper , Ian Jackson , George Dunlap , Stefano Stabellini , Konrad Wilk , Tim Deegan , Wei Liu Subject: Re: [PATCH 2/2] CODING_STYLE: list further brace placement exceptions In-Reply-To: <29b489fe-d7ad-68b8-b555-2a6381a28829@suse.com> Message-ID: References: <29b489fe-d7ad-68b8-b555-2a6381a28829@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 19 Jul 2019, Jan Beulich wrote: > For easy spotting of struct/union/enum definitions we already commonly > place the opening braces on the initial line of such a definition. > > We also often don't place the opening brace of an initializer on a > separate line. > > And finally for compound literals placing the braces on separate lines > often makes the code more difficult to read, so it should (and in > practice does) typically go on the same line as well. The placement of > the closing brace often depends on how large such a compound literal is. > > Signed-off-by: Jan Beulich Acked-by: Stefano Stabellini > --- > TBD: We may want to make explicit that for initializers both forms are > fine. > > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -64,8 +64,13 @@ Bracing > ------- > > Braces ('{' and '}') are usually placed on a line of their own, except > -for the do/while loop. This is unlike the Linux coding style and > -unlike K&R. do/while loops are an exception. e.g.: > +for > +- the do/while loop > +- the opening brace in definitions of enum, struct, and union > +- the opening brace in initializers > +- compound literals > +This is unlike the Linux coding style and unlike K&R. do/while loops > +are one exception. e.g.: > > if ( condition ) > { > > From xen-devel-bounces@lists.xenproject.org Tue Nov 29 20:56:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 20:56:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449638.706516 (Exim 4.92) (envelope-from ) id 1p07eS-00072v-0D; Tue, 29 Nov 2022 20:56:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449638.706516; Tue, 29 Nov 2022 20:56:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07eR-00072o-Sn; Tue, 29 Nov 2022 20:56:23 +0000 Received: by outflank-mailman (input) for mailman id 449638; Tue, 29 Nov 2022 20:56:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07eQ-00072i-K0 for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 20:56:22 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46346cda-7028-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 21:56:21 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2022 15:56:07 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6252.namprd03.prod.outlook.com (2603:10b6:510:e6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 20:56:02 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 20:56:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46346cda-7028-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669755381; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=LTmFTHcwAtvjl/r0aHSO93RhTAYtQeVD5U97Z2P3nWQ=; b=RSnm4ucckbgJbLfAXxj5rBAgeAHbBQ7thggDTGNq65WqH4XWSOxOxJj7 BkSN7cdszLgrFMrlbeQ41oAtwOHSsmMtWyv1/eKz4VIEehHDJLn2g0nzf cNKpKwJSL4qDDQQQh0FhEDFn+uwxeC8sNErTYZcRdxaRJR08MWAKCTUbj c=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 84845013 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:n/joIanJ94fVl6w8UUtxJUjo5gyjJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIXXDzUaK2JNjHxftp1b9y/pEIHucfXyINhSgdlrS0xEiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5g6GyRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 aEhJh40U0+vu6X13pT8c/g1jJ4jMMa+aevzulk4pd3YJdAPZMmaBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3iea8WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapCSO3kq6Yz2zV/wEQoWDIZRAGQusWIiw27X9ZCE 1UQ9BUx+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313qiQhSO/P24SN2BqWMMfZQ4M4t2mqodjiBvKF49nCPTs0IyzHizsy TeXqiR4n68UkcMAy6S8+xbAni6ooZ/KCAUy4207Q16Y0++wX6b9D6TA1LQRxaYowFqxJrVZg EU5pg== IronPort-HdrOrdr: A9a23:1LaVzqN3v1VWGsBcT+n255DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDKw875BKIhTaI7qe/NxSDxB8RXx5G3L9nqA H+4k3Ez5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJptkJJi7qggOIYp0kf7GZpjg6rMym9V5vut jRpBULOdh19hrqDy+IiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ/+1U4e Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh77D3vXklVavoLhiKr7zPI9 MeSv00I8wmKG9yWkqp+lWHBubcBkjbUC32GXTq8fblrgS+1EoJs3fwgvZv3kvovahNNaWtrY 7/Q9tVvaALQckMYa1nAuAdBcOxF2zWWBrJdHmfOFL9Ccg8SjvwQrPMkcIIDduRCeo15Yp3nI 6EXEJTtGY0dU6rAcqS3IdT+hSIRGmmRzzixsxX+pA849THNfHWGDzGTEprn9qrov0ZDMGeU/ GvOIhOC/umKWf1A45G0wD3RpEXI3gDV88evMo9Rju104r2A5yvsvaefOfYJbLrHzphUmTjAm EbVDy2P8lE5lDDYA6NvPEQYQKZRqXSx+MCLEGBxZlj9GEkDPw9jiEFzVKk+8qMNTpO9qQrYU oWGsKUrp+G X-IronPort-AV: E=Sophos;i="5.96,204,1665460800"; d="scan'208";a="84845013" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YO0YKzovH4VXg7drbLVCnSXldlE6kAiXKqu1t014/Z1vs3wVX65Gx2/XEacSklryEeUhmOOLuJjB2rUd5Ms+RST8V9BNvDGH2K11vk9d6tmoZ8/N8Xnx1hekc4JuDnPRnFPkroDBeeYgHIeH4y5sleFa7D0MgdmG8GQuxLTvy2NRrf3yiTydDlNT0pxiIHf9IBxdUg9PsrsB6bTVkyRjTqeypCHoqKbAqp/8nu1NwF1Id9t4jVkNLL09Zi59hihN8gwAw3Zn8vsSZVOBg7b8OFV6d7M/MwTBgkE15PoTnlyibMn67y7cfEN1vuiuRzaHQwqTEWFjAap3QGN7BFTHVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LTmFTHcwAtvjl/r0aHSO93RhTAYtQeVD5U97Z2P3nWQ=; b=J+4KWH4PAExB6j6S+qGCdQca/ljHysF9UJhr33v2jDQXs1lOgGJY3Nzo6uzA+0amQ1q9xJ1BKCj0Mb9R2xpn9uHgJVnEw4keSwMoO5jDMSPvfv/dX75MRJ8vgF4iIdrfj3s0FkgOIEurC9/epw4VSntKSTqrM48iITNZaIgxkWyCo8Nq9KM7uxAzfPB6Ugna/SW4wP1QcdxwrCC77FhGg1Lsm7nyfnea8M+MN1Hi8UQSaQpXueExyWExunjyZ9Cv8ehMu2ZC92Gat+fMav8wQzeBc93imi9mAyMcrjP402Ugd2MpTfFUGuDLix/3l1flSeqMZbgYjySLljqJfNOIrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LTmFTHcwAtvjl/r0aHSO93RhTAYtQeVD5U97Z2P3nWQ=; b=fKjr7rPKsmQWPuhT6rHGpG+8fr93vk02s7GbcJ4kKeVu/DwNaHRpqRW6IKnTfz3+btlPitbZqSwLSXgq+WbuBQROxzVrgR7q0qBczWJWBK6xgNEvzQFSJ46AUsOcQDh7kO30Cr1i7RuqdurNv1AX0y8Z0rq2eQinOV/QEk91ySs= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH] x86/mm: PGC_page_table is used by shadow code only Thread-Topic: [PATCH] x86/mm: PGC_page_table is used by shadow code only Thread-Index: AQHZBAKvvRJ2heCKJ0SiESCucWQuIK5WYfSA Date: Tue, 29 Nov 2022 20:56:02 +0000 Message-ID: <4fef5b0c-4463-cd6f-15fc-47268505517b@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB6252:EE_ x-ms-office365-filtering-correlation-id: 2de3d3d5-48e4-4528-a252-08dad24c1fea x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i1XCKv9+3dnmIImwY2SJM1m3A0VzQtSGcoP/bcu1lMKJrWb4MAK9jN2lA+NHtkyRpR/cHH9yNNhSBqiTc1qq8U9iwcCFLsxcni6Ei5FYgQ0BaLR5fVcMigJkW+frmfGNen4vYTs6QdWIH9ScjDa2uj7obkT3Noh020kCLRHKzdLbzDQ3AnKI5waQczkMNG1bQGyi2/08CWl5nog5CorAHFXINEFTAOtPHZTfbpZDmlw5ZTfAhZAowcTmEs6/ELX1rD8B7KTHfv3sM0Av1rn4enCBhR3zR6LVfytc4GMgOzFxPDRjpVvlnHUtlav0YP8EU2vhVhNWxlmTr+b9ghlB0rKjIAoR0JBuD3GBvuxfC9gv4se+sd3jkiI9f5d5tMILqccmzROV7+qXA4MHH5ycmU2ZDao6ra1RXKho3ElT2BzYjHE3v6lF1DDfy/ekO+NRIENR2uF+nVhHG5jajNmMQWiUSOVDNfs5+tmn9TvfJ4FvFosRbI4rvNYclaJqKs/SGHM675LVKyvJccNXnkP8GKaYNH3Qg62SJ9zVE5wcePdisu2oBH90LINTAR2v6ETMk05JnEqDhAm1d8o5oA4Qg26E28QvgPasuX3PfHOczl0q7HVOH8pzihhh++k2aPmKT/+RDyP5E2bhUoN0Pt0fSHGHBGEEaSHCSDK2wLSaOQRoWFqSyk4TP+lSXrpOM2SBh4SFoFMwSmwiLxCDi5TYX34gGLH5XDG3R0/KRsxZ0uDZJskDk/0mtPbqQQ0aDQ5EnfW23orLchuLaUGdig35Rg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(376002)(346002)(366004)(451199015)(83380400001)(31696002)(86362001)(8936002)(38100700002)(122000001)(2906002)(110136005)(38070700005)(5660300002)(66476007)(66446008)(41300700001)(107886003)(53546011)(6506007)(2616005)(26005)(71200400001)(186003)(6512007)(64756008)(6486002)(8676002)(91956017)(76116006)(66556008)(316002)(4326008)(478600001)(66946007)(54906003)(82960400001)(31686004)(66899015)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cFhIWmVLbkZRa3JSNWVtY1B5NWg5UmczSzBQeFNMN1RxTm1VeGhJUFFIbitv?= =?utf-8?B?RmNkL0IyVXZqWmhRMWxoS0NhamdhVGNZM1o2dGU4TzlrOHpmaFRKWmhmSDhu?= =?utf-8?B?TVBud2FqTW52VUFaSldWdHZQN0ZWTDdxUGJ0YVJyOW5iK0NTVVQxQ3lmcUhk?= =?utf-8?B?bWJCVjJoTkZIK2RMSVc0ZzAySlAwU0xEak9NejRZaHFscjVVTXJEMUFTcDVw?= =?utf-8?B?Uk5HTjNiNWEwU0Z4V3U3WGRocDBXVkxyb0tzZHpnaVdWT05TbGE5KzVXZzNF?= =?utf-8?B?Uk5iQ1prM0l5NFd2bGcyOCs0UitaKzdKQnlobG85UXQ4QWk3dkpBM0FkUUd3?= =?utf-8?B?MXJyd3pxMHpINkU3NlIrckdMV08yRUppVEY4YWR6MExEbmJTbno1TndyRUxM?= =?utf-8?B?NkJiVUgxdDFOSW5iNmozaDVjbWdDYlVVYVBCMmNEb0pnMDMzYURNaWxjcmts?= =?utf-8?B?Yk5VcklPaVE4Ky85VXg4TitmTGJZOXRHV3o1eWEyL3JRVlF6L0NGcmFYZ3ZG?= =?utf-8?B?bmRkNzF0UDVLQ25IcU5ITnZNcDNTQytzRTdkdnBWaTFrbGVGRzVLZ1g0bnF3?= =?utf-8?B?UHg0eGhZWUpmOVpMMmRvUXAvekhxN0VGK1UzKytEczlsOWs5RTNCemg3VTdK?= =?utf-8?B?c0ZaOUFyQ1p2Y2daRUtZSlBxQ3RIZmFKd0oySi9memxXcVdBMHd5Z1BSdmF4?= =?utf-8?B?dXhCTkZnaUx0SmZ1ai9iRXNGZTlEa0hCZzNGWnlJL2l3cWFJYmlvZHV6ajIx?= =?utf-8?B?aVFVVHVZOWVZNmYvdEE3ZUhML0Z3Mi9odGQveFR4NnJJWEhsdHQrZ3R0NUpx?= =?utf-8?B?UWh6eDNZcTN1L2tBUlIvK0wza2x6RmRzUGZxTWdsV01NUkRnY0p3TmNzeFJy?= =?utf-8?B?d1NTU29heEpoSDhLK0FlM2ZYWDdadk5GTXI0N3dvajZwemRmejRHbkJRL3Zh?= =?utf-8?B?UmRmbGg1dTFsSHBkMzFZZEJIaGRsTjhCVUxVcjJFdjhGYXp4b0VnbGlxYjMv?= =?utf-8?B?aVdkY0ZHWnAyL25FcVZHYXN4cUcrNEt4SFJ4UXBMTDJsay9STW1IZjlsYXVQ?= =?utf-8?B?S2cydlFTQkhtRGJaNmtvVFN0OGszaTVRcUdXOUxzOUcrd210RmhvS2FHaXcz?= =?utf-8?B?cWhzRWI0TWxEWlBuZi9IM0c3cnNicHBBREcwSzcyOUU0c3N6UmMxYUcvc0Zt?= =?utf-8?B?ZWlad1RjM0NMS2N3b2JxYTgzVGVTRVhvSzdoZk1mWENnQ3M5bE81Q0U2Y2pv?= =?utf-8?B?SStzYWwrOEpiRUg1WWZHN2s5OXg0OXNFazRiL1JGVmZ6b0o1OERmUyt5ZDVI?= =?utf-8?B?K05FRlVkR2pWdjd5dk1ObGM5clFKZDJld1F4Y2xJL0hRbmZ4UUJjSzhUYkxX?= =?utf-8?B?eFdsREJJYThTVnNPNUVBNUVDSjhRVlVJTUxibFRxMXF1QVozTEd6MmxPWXNl?= =?utf-8?B?R1JBTHQ0a3cxSXNaSzl6dmJWQkZKVjlGdlY2ellNMkEvSEEyRUZGcVlPbXky?= =?utf-8?B?Ykk0S2k2azNFUGlXbzh3MnpuNmMzNk5pT29mWDlBWjBEbjdYTFBNcVVBTkNi?= =?utf-8?B?eUhZd2RhWE1TbnpNWUEvYnYwb3h6OEZXc2tkWFdPWU9vS0VrNG1abU5QNWFo?= =?utf-8?B?K3BNVzlwMGgxZVVIQVBRc3FVNk9ZS2pFUmRER05lZTZ2OWxrU2hZNG5FcUlG?= =?utf-8?B?R2ZSRVlHNHNkVHpxTG0wYXNBRDBPMlZtVUhRWHBnaDRyZmRBdFFhN3pEWUdy?= =?utf-8?B?TE5nUG16Q2ZiTXI5MnlNVWdQUExQR0hvcDdjTEN4WUMzMndwNzdpRzU2U2Rr?= =?utf-8?B?MFd1RHpIdzhCQjkyaDBZcTIzQ2RBazhIUDVDY0ZyVXBmZUlTSGxZRGVFbkdh?= =?utf-8?B?RFQ3aHhFMW5Bek1XSFU1N1NqYXdrVjFTTWt0MHlaa0ZJWlRzeFo0VTJ4V3hj?= =?utf-8?B?NGFob2dIQVl1d2IwZGQwNlVWQURhdXJWTWdkMjdYOWRGWm5uRVptZUhHb1NI?= =?utf-8?B?QWFoY3IzaHRsczAxVGF6WGdZK2Fsc1hqYU9MV3RsVTBTZkMrei9oQlVSc3Qv?= =?utf-8?B?WUdia1RuTCt6Y2R6c1dQNTdxR1RRblJ2aXl2ZmZUcWxlUERlV1RyMjlqSlho?= =?utf-8?Q?81yu2F7lvxPycdb5xbeRhe44W?= Content-Type: text/plain; charset="utf-8" Content-ID: <181339373DFEB04782D10284F3CF8947@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hDNM/8grL/mEilJchrHqqkIsnLxVmwyMnNnxhzkZfvohDPEqDPtXDJt2+DU3mLaHzgBkrF+Sh9zaF8SiwRAwx6PgJaLYXZSHrPDHYfL//siiRaKe8RRSc7eyE9Jriv1tjQbDE1QWjtu/C67U2C0T+hqYBu+Nxv6lxiGdDMltA3ryRfousRfTQDjdK0jQ8oR7r/OC9DSzYxoHcjtVnct6f64UXsLD51TsMsyB5MsvbLPUScXCbwiIW1c+UCteDuHjzfnX7IlJIQ48mb9UMS5ZafRshPk1iljujDuaP2F2H4oUiHN8vg2kGtEbhKICuTe3uDchYbj4yp7KjZHjG2fWr0Wo583N0X8bGwBUnAsZZpBrKXxXRbp6msYA7oQiy4tpbJTZtStQY9xTpWOrEJHuoN+fqKTP8XzJMjhlKTA2dUcksM50ExWl8hLa/JK9TsoLpTorJ68EBznFGrjcO97G5tKbuSqtJ+c6PoM17RL4Lbg9VDW5dOEki/TABmPQSqh3etLFb0jv+rs147XR2NaE+UNsolHVeUxMRnCmz5K9x0Hf5AOMuh2gbbs/3EGu7ZtMUvH7kHz/ze7Idj99Uepdpz7Rywq6xuj+6Ji8PZaN6tLom5As+n32HBFXVxZFo2shbNpi4frpbm1WvdeGQw0+MjdR9Z8CCeFq7KTotUj+7lz9HOjc2nabIcZlGvye2zlCPB1tXMwUVa2S4d4/eWs0WOE851ZgkhONQ9WBvvYEtHUnnodMff6ZNvSfNlJRk3+foMSjE6pLiYYCusI7l5cCL3UNdjofX7eATHwfNHpPuuEbnOFxyVOy44ci7VOrWIeTJgmR8j5dvMaRRg0Nl/5/+Q== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2de3d3d5-48e4-4528-a252-08dad24c1fea X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 20:56:02.0852 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gYsPs7Ri44HGSKxxDJoZ/Tb0m2jH3ERadd0rR81afls6thQrA3Co7RJNJq+woQBGnwlPJc0FeEtrWBGGsMb53jlLs/zYQ9u63PmDl768GaU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6252 T24gMjkvMTEvMjAyMiAxNDo1NSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEJ5IGRlZmluaW5nIHRo ZSBjb25zdGFudCB0byB6ZXJvIHdoZW4gIVNIQURPV19QQUdJTkcgd2UgZ2l2ZSBjb21waWxlcnMN Cj4gdGhlIGNoYW5jZSB0byBlbGltaW5hdGUgYSBsaXR0bGUgbW9yZSBkZWFkIGNvZGUgZWxzZXdo ZXJlIGluIHRoZSB0cmVlLg0KPiBQbHVzLCBhcyBhIG1pbm9yIGJlbmVmaXQsIHRoZSBnZW5lcmFs IHJlZmVyZW5jZSBjb3VudCBjYW4gYmUgb25lIGJpdA0KPiB3aWRlci4gKFRvIHNpbXBsaWZ5IHRo aW5ncywgaGF2ZSBQR0NfcGFnZV90YWJsZSBjaGFuZ2UgcGxhY2VzIHdpdGgNCj4gUEdDX2V4dHJh LikNCj4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0K DQpBaGVhZCBvZiBtYWtpbmcgdGhpcyBjaGFuZ2UsIGNhbiB3ZSBwbGVhc2UgcmVuYW1lIGl0IHRv IHNvbWV0aGluZyBsZXNzDQpjb25mdXNpbmcsIGFuZCBmaXggaXQncyBjb21tZW50IHdoaWNoIGlz IHdyb25nLg0KDQpQR0Nfc2hhZG93ZWRfcHQgaXMgdGhlIGJlc3QgSSBjYW4gdGhpbmsgb2YuDQoN Cj4gLS0tDQo+IHRib290LmMncyB1cGRhdGVfcGFnZXRhYmxlX21hYygpIGlzIHN1c3BpY2lvdXM6 IEl0IGVmZmVjdGl2ZWx5IGlzIGENCj4gbm8tb3AgZXZlbiBwcmlvciB0byB0aGlzIGNoYW5nZSB3 aGVuICFTSEFET1dfUEFHSU5HLCB3aGljaCBjYW4ndCBiZQ0KPiBxdWl0ZSByaWdodC4gSWYgKGd1 ZXN0KSBwYWdlIHRhYmxlcyBhcmUgcmVsZXZhbnQgdG8gaW5jbHVkZSBpbiB0aGUNCj4gdmVyaWZp Y2F0aW9uLCBzaG91bGRuJ3QgdGhpcyBsb29rIGZvciBQR1RfbDxOPl9wYWdlX3RhYmxlIGFzIHdl bGw/IEhvdw0KPiB0byBkZWFsIHdpdGggSEFQIGd1ZXN0cyB0aGVyZSBpcyBlbnRpcmVseSB1bmNs ZWFyLg0KDQpDb25zaWRlcmluZyB0aGUgY2FsbGVyLCBpdCBNQUNzIGV2ZXJ5IGRvbWhlYXAgcGFn ZSBmb3IgZG9tYWlucyB3aXRoDQpDREZfczNfaW50ZWdyaXR5Lg0KDQpUaGUgdGJvb3QgbG9naWNh bCBhbHNvIGJsaW5kbHkgYXNzdW1lcyB0aGF0IGFueSBub24taWRsZSBkb21haW4gaGFzIGFuDQpJ bnRlbCBJT01NVSBjb250ZXh0IHdpdGggaXQuwqAgVGhpcyBvbmx5IGRvZXNuJ3QgKHRyaXZpYWxs eSkgZXhwb3NlDQpiZWNhdXNlIHN0cnVjdCBkb21haW5faW9tbXUgaXMgZW1iZWRkZWQgaW4gc3Ry dWN0IGRvbWFpbiAocmF0aGVyIHRoYW4NCmFsbG9jYXRlZCBzZXBhcmF0ZWx5KSwgYW5kIHJlYWNo aW5nIGludG8gdGhlIHdyb25nIHBhcnQgb2YgdGhlIGFyY2gNCnVuaW9uIGlzIG9ubHkgbWl0aWdh dGVkIGJ5IHRoZSB0Ym9vdCBsb2dpYyBub3QgYmVpbmcgaW52b2tlZCBvbg0Kbm9uLWludGVsIHN5 c3RlbXMuwqAgKEFsc28gdGhlIGlkbGUgZG9tYWluIGNoZWNrIGlzIHVzZWxlc3MsIGdpdmVuIHRo YXQNCml0J3MgaW4gYSBmb3JfZWFjaF9kb21haW4oKSBsb29wKS4NCg0KSXQgZG9lcyBsb29rIGEg bGl0dGxlIGxpa2UgdGhlIGNhbGxlciBpcyB3YW50aW5nIHRvIE1BQyBhbGwgWGVuIGRhdGENCnRo YXQgZGVzY3JpYmVzIHRoZSBndWVzdCwgYnV0IGRvaW5nIHRoaXMgdW5pbGF0ZXJhbGx5IGZvciBh bGwgc2hhZG93ZWQNCmd1ZXN0cyBzZWVtcyB3cm9uZyBiZXNpZGUgdGhlIHBlci1kb21haW4gczNf aW50ZWdyaXR5IHNldHRpbmcuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Tue Nov 29 21:09:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 21:09:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449652.706527 (Exim 4.92) (envelope-from ) id 1p07qu-0000Op-2s; Tue, 29 Nov 2022 21:09:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449652.706527; Tue, 29 Nov 2022 21:09:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07qt-0000Oi-Vg; Tue, 29 Nov 2022 21:09:15 +0000 Received: by outflank-mailman (input) for mailman id 449652; Tue, 29 Nov 2022 21:09:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07qr-0000OY-SF; Tue, 29 Nov 2022 21:09:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07qr-0000io-PP; Tue, 29 Nov 2022 21:09:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07qr-0008M9-8E; Tue, 29 Nov 2022 21:09:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1p07qr-0005po-7W; Tue, 29 Nov 2022 21:09:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fecEH6tPwr+Ylf3QOpECoBPygN1UKXXSg1T2c96Q6Ik=; b=Zk8TtJptYUpRqrnrJtt14rSeNh dp+gHV6L+ZpE1AUUWXTs+6v3RwJAILjAk0so0rtUdDj1CHlxPpWmmpe/iwSmnqHKyD8oFCsnrDtEP d5mClSvn8A6XgUdCXGGbOFu2MqEcbl4+GRomkzeEK3GvFMGeSxnkJAy8k5mn/hLmd8Ic=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174988: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=ca57f02295f188d6c65ec02202402979880fa6d8 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 29 Nov 2022 21:09:13 +0000 flight 174988 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174988/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux ca57f02295f188d6c65ec02202402979880fa6d8 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 53 days Failing since 173470 2022-10-08 06:21:34 Z 52 days 101 attempts Testing same since 174988 2022-11-29 13:41:02 Z 0 days 1 attempts ------------------------------------------------------------ 1907 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 182064 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Nov 29 21:10:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 21:10:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449660.706537 (Exim 4.92) (envelope-from ) id 1p07sM-0001ow-Gj; Tue, 29 Nov 2022 21:10:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449660.706537; Tue, 29 Nov 2022 21:10:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07sM-0001op-Dq; Tue, 29 Nov 2022 21:10:46 +0000 Received: by outflank-mailman (input) for mailman id 449660; Tue, 29 Nov 2022 21:10:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p07sL-0001of-9t for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 21:10:45 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 476f93c2-702a-11ed-8fd2-01056ac49cbb; Tue, 29 Nov 2022 22:10:42 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2022 16:10:33 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN8PR03MB5042.namprd03.prod.outlook.com (2603:10b6:408:da::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 21:10:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 21:10:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 476f93c2-702a-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669756242; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=PlGqb52dA8lZLkSPjJBw29aiaLI8MDFflDevWPQuSpo=; b=iHTu+koLZLui3zxUHUqZIBd0HNBP6S8Wc7nlxWf11h/q/8ZWSJ1dnuCV Giqmw1/z8oSeZumedcLjhWakIgfY5KwtkVK1CsfpaUFRhPIvNdyJbxo+Z SExDgyhFRFazWcs6QdzfZUSc9tA+xoQRBiQXnG0JrOZCW7jED/5G1LYqv I=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 85805743 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:L0ulRKlEEMSAQsIfoKZZnsDo5gysJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIeWzqBO6mNMWCheo1+Ptjj/B8PvpaDy4VrSVE5rS00QyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5g6GyRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eMgNTUzXz7TvuGvmZObEtd9vvYqLOC+aevzulk4pd3YJdAPZMmaBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3iea8WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapCSe3gq6E22zV/wEQsNAczCF67/sCH1Fe5ROMEK VQsoiwh+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313qiQhSO/P24SN2BqWMMfZQ4M4t2mqodjiBvKF49nCPTs0IyzHizsy TeXqiR4n68UkcMAy6S8+xbAni6ooZ/KCAUy4207Q16Y0++wX6b9D6TA1LQRxawaRGpFZjFtZ EQ5pvU= IronPort-HdrOrdr: A9a23:AVzafauVEwopO5lH+2TX9cTM7skCXoAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeF+aP3CB+R2zYZSndqza05+W bIvgTl7uH72svLiyP05iv21dB7idHhwtxMCIiljdUUECzljkKFdZlsQLqLuREyuaWK5EwxmN fBjh88N4BY6m/XfEuyvRzxsjOQngoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L gj5RPbi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZDIMu60vFjLA BdNrCa2B9kSyLdU5kfhBg3/DWYZAV2Iv5BeDlbhiXa6UkMoJkz9Tpk+CVWpAZ9yHt6cegF2w 2MCNUXqFkFJPVmEp5VFaMPR9C6BXfKRg+JOGWOIU7/HKVCIH7VrYXriY9Frd1CVaZ4u6faoq 6xJm9wpCo3YQbjGMeO1JpE/lTER3i8Ry3kzoVb64JisrPxSbL3OWnbIWpe2PeIsrEaGInWSv yzMJVZD7vqKnbvA59A20n7V4NJIXcTXcUJspIwWk6IoMjMNor239arOMr7Nf7oC3IpS2n/Cn wMUHz6I9hB9FmiXjvijB3YSxrWCzjCFFJLYd3nFsQoufsw39d3w3koYHyCl7G2ACwHtLAqd0 1jJ76imr+npACNjBT101k= X-IronPort-AV: E=Sophos;i="5.96,204,1665460800"; d="scan'208";a="85805743" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RoK9spwmSKWtFboYe2TWf9LbE1KCZlwTcAt0rN8KNVVKzRMHjnXc3samdFuwEfDaIaEhUXCk2hoCJPaxZOfXHVOhhR8Y9DV707loWF8L1En3Q7bHHUT1bxy1+zegGliybZlvnwqMVyZ8dDQX8TVp7eJ2wljCNtMfnCC2vNdyVh5WS2VcsXm6JzDvzFsXI89W8c8gDLH0aiIUBot8G+IAqVnB/0vv04Zvs0tjE4XNExdjI8NhWk882qQpquWkazS12gJK3e/sySX7H5WDpa/rCytKXmSKc5+mx0NaCeRWedfr7VvZb8opHHGM4wNzQPoZyYDVG0Wuy0IckBwBddD9Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PlGqb52dA8lZLkSPjJBw29aiaLI8MDFflDevWPQuSpo=; b=CfzaWEp9+XCiPQcm51X3mitR+kPoTz+yVl7DF7+Ikr1/Qj+xoifkj0kkBe4vPq3pOQu3vWlkAz7noVOshiQyVpbLH8APbwB/kPyIZKYpEKIzOUp2+RVL3pGpWNsHlzDuHW/eUQODL4wme1UE5XSQYj6LyutW/Vq5wkZvJzqjNmooiBpShqRbhzcjMeEWleRLGU/Im2uIranI6mPdUhV/zo9Bj32zLg73OZ2KnJnxHjjbELqbIz0dcI7veGzpOiOyHOClrD7VCrZbJ7Dn/as6EtdTKXkLZu/Ro45chmG4HdJBFdzByIlPg4Z/dSdf+PYN9vVNp58Vo5sUmLXYibmxPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PlGqb52dA8lZLkSPjJBw29aiaLI8MDFflDevWPQuSpo=; b=F1Cz+frqUUsb9qsAL3+wnrMfNGzAAgwIL+KrSoOKdSlQ4/XCD75JKRDGsjMwpmmcttXibwmRlnhYxVBsT8yzPl77x4xILZ69cQaxHGLpjJrgV7U47msjINcO81rF2QgOy/DkyXTG2VWKyg42fAyIfobR49IBUFdm9MGK3zQED9s= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH] x86/mm: PGC_page_table is used by shadow code only Thread-Topic: [PATCH] x86/mm: PGC_page_table is used by shadow code only Thread-Index: AQHZBAKvvRJ2heCKJ0SiESCucWQuIK5WYfSAgAAEDYA= Date: Tue, 29 Nov 2022 21:10:31 +0000 Message-ID: References: <4fef5b0c-4463-cd6f-15fc-47268505517b@citrix.com> In-Reply-To: <4fef5b0c-4463-cd6f-15fc-47268505517b@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BN8PR03MB5042:EE_ x-ms-office365-filtering-correlation-id: 24041e29-75dc-428f-67f6-08dad24e263e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nhJaCmlaoB3haNGbPFQqPwiNGwnb9RO/OWCK+Xh0+6F2xRVgzhE9AK1tRsFNFNVuaP725YlmMgjKKukhcPUXjKP/0Zop7ROeGFD8kMouhmE1VJ6F2cjVEg4JnoZSoIdRDHiW07WonNyVLTBpOrCJJnOzQfQPL/iYsM0MciVfY/ODBGO2RdfBPf1R/GBEhGzZGpLCUh3yXuDpiG52unePuEUinrLbdaIM7kkRenS+Wi+FdQaYH/8nPcp6HO/MPnfhP+NyLFX3a8p2E/+I8ouG39z1kwEwRcS32Xd683x9b00J9TReI3OtCNg1Z4ESSkiTKhINV7z7Yba1+SL6Y+jjlS8Yw+hR2mP9lNuZKz1AH3u/mIw3iNjZEQI3AUDIqgwWv4IdMVO8EKgdmVMQWkfDt4Jiety+Jxkj1Z16ImMYapOFGqSLUR+XqxC2eOOXE/n9FS7pJ7B+nhYTsi4rAjEqulNQP5b8HAnDgcfJcPzgZbMw33NxE4iC7I+YWvf2CtUkO2tnPK/AKZeFzYDWFqgMx7+mD7Qr5s+vYzOacoS2E+y+CIAwRsFacFoMo7DU6ne352WhTypAcbLYDla7LdwZ9CKuiIiJpuNX/AaNOyjZDYjuhFSr/EWPDxEJUy2DfWhlLDjKLKiUTkp6EZjYHe58d4UlSdY6NLoy8B1/MhZC+zm2WMIfsLmXomb6T9EAE905nvHhOemFKXzgl7CMSUJpnzl/jqKNui6Pp8nCIUQeb0Iy3zZgTZBIiddE6YM7Qu4LpxEvoN/BFNalxuKnW7bSww== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(346002)(376002)(136003)(451199015)(478600001)(66899015)(31686004)(71200400001)(107886003)(6486002)(82960400001)(6506007)(5660300002)(53546011)(316002)(54906003)(26005)(122000001)(6512007)(110136005)(36756003)(66946007)(8676002)(76116006)(91956017)(66476007)(4326008)(64756008)(66556008)(66446008)(38070700005)(41300700001)(186003)(8936002)(38100700002)(2616005)(31696002)(86362001)(2906002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OUZDTXlROEd5OFg4WGg2L29MY25PWE9MU0hTb1pTTDl4MEllWFVYNmxTaGMy?= =?utf-8?B?R0FnQUpTcU1jT2dWQUppM2RpR3ZCbE5ZSUFOUEZ6MzN4T1hFSXRxbUwvbmoz?= =?utf-8?B?VlhMSjkyRk1vNng0amdHT3ljSTl2L0VlQUNxNEtRVVFPamYyeDFOL0xaS0JV?= =?utf-8?B?S1VzZWlRQWMyMEZiTDBzTjJqRDQzKzhzMWpSNHU0WDI2RHVKZnNOZ0drTUlr?= =?utf-8?B?anlRM1J1ODNJNy9QMnFDSlZmVFdxemZKRWhOeStWTEs2SGthbXRSUy91ai9u?= =?utf-8?B?ZFI0MkZYVzNZNURrQmZQZVhFZytLQ3lzVU9XdHhpYXlDT3cxSVlwTVFSbVB6?= =?utf-8?B?S3BJTURyaFFyZUFGS2ZkZ3hhWEsxcnNRd25TRDIwOHk1Rlk4RnpXUmVwU1U1?= =?utf-8?B?cmhnNFF4RkJwdGptOVM4U0VBL28vcCs1NW90Q3I3dW9MOGVGR2xQYzZrOThl?= =?utf-8?B?UUltNVpCRGtBeWwyVXYwTmpwcDlXbTg4M013RldHUEovdUREZjUzTTd2ckxq?= =?utf-8?B?aXNZb01Sazlmb1RXUkNkRVNRdzd5aDhLdnp0VWd2YW9WQ3VLUjgwMHJNeTAr?= =?utf-8?B?SHdzZW9UTHVuMHFOemtsVCtod2xwbG91OWwwUEU5WTJrN1dETTU0a2hWSVRv?= =?utf-8?B?VW1nSTdzU2JKZXVXUkF4LzFBMjdMcUNPaHhUZktsaENFeHoreEc4Y2FBaElm?= =?utf-8?B?ZGl4RnJSaEREQnM0V2ZGdUhDRS9Wd3NqTCtBRCtJeWRZR0FXOUovNXoxdlky?= =?utf-8?B?emxZVXlwOE9rUzRpaStUTGh0RVRFU3VVQmNPQ2J2U1pVNUM0WjdLQUsrc2VX?= =?utf-8?B?S01HM0E4VlhZWUpmTHNRSmNRTHl4U3c3Q2pNMlZDamxVcVpLaXBWWjVKeFBt?= =?utf-8?B?cnpRQzZ3UVcyNGt3eXZGSXlVSWJIN0UvZyt5Y3F3SGN6eHNpWjc5Z2pzUnBW?= =?utf-8?B?WXZaZHF2N1Zua1lQSi9nQnljNDBqdkdicUhLa0huOTJnOFlQM3Z5RzVoUEhx?= =?utf-8?B?S2dpbDJjTDh0UVNPQ2RzcjRlcU11WVpZOXpjRWV4aWlUejNtRFA3NlEzamxS?= =?utf-8?B?dXlpMTYrQW83MStxbnpGNDJXL3dPYzFNMFovOS90U1Y5b1JKdDlPMnVOUjdp?= =?utf-8?B?clFnQ3I1dkVyZWY1U2t2QVNRbElXaEFLbVIrOXo3NjdXV1k0MGpiSDN3eVA3?= =?utf-8?B?dktDOGYzYnBjOFZvcnNHMDBKcXJqa2lmbnVVcUxIOCswVE9tM0VoeHZFSU13?= =?utf-8?B?K0k1WlV4SUNMQ0NNYldpcjZuQUNHMkhWempkaTUvRHd5MEJzNldNVU5hTFRW?= =?utf-8?B?THdyZCtMUkk5ZHhvQm1aOUdaZm1JSVBhenhJVDhQeXMzR2lBUWh6cGY0WWxR?= =?utf-8?B?RjFzemNpMDRDSmNCdW5YN1hhbW05dlVBc1ovODZ0WWk3d0IzWFhEQ3Naa1FM?= =?utf-8?B?blREdHRuZWVnRDNDYys1NlZaV2hGT3dSY2ZxMWMwUHdrMFV1K0c4Y2N5WnE0?= =?utf-8?B?ajVwTFVTdWEzWElTcGxrN2N0UlJqOEhmTVhPVHJ1OWVxaGNvNzNrd3F4NC8w?= =?utf-8?B?KzdsNGpUVFRIZ3RnUHZkdjFDWC84YzArMVZ5SnlheFg4M2dRbVhhd2ZCUk9Y?= =?utf-8?B?THZkbGViZ1J2M1UrMTJZZnNwbW9mMmxaaWgxQXZVYm5oZnRlQ2FCMURjclZK?= =?utf-8?B?UkhWZC81YnhDYW41clhod3Rid24rL0JuS2JPU0JYcjRNak4wdXRGY3FzT0o2?= =?utf-8?B?THNBQnR1WlAyMGJjTFBwMmtaRzdsdmE2bGVXdXlJZ3JveUJkTk05NlRManhh?= =?utf-8?B?R2xQNXNBc1UxTW9RZzR4L3NMZEdIR2RCZUV3M1ZPaWFHcWg4NjdhT3owVEts?= =?utf-8?B?dXVINFFMU2NPclBlM09rTTV4ZnErZFlUTU9wcHlVcElxWGZOaStMMW8ycXhx?= =?utf-8?B?dkJXOUVOVVJUbzlyaHhmLzhmOXNlWXF3RXYxVGFWRlI5eUYyTWFIbG1EenRp?= =?utf-8?B?THQ1SXpsSW1JSlJQR1ZsSVU3SDVlTHlTYmFGeHBkODdBT3l6SkFaVkVpU2Ro?= =?utf-8?B?MGpHbThyVWZHWGc4K0x3dng0WGFIbjllSFMzM1dySlNVS2l3bEdFQXdvZXJT?= =?utf-8?Q?4e/kpyDcFIZU/6F3kJdu8lX2n?= Content-Type: text/plain; charset="utf-8" Content-ID: <10C72A8D23E09840AB05E60B3E3A190F@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Av6eW+aA2WnPSGtBXDfzxcEcQlqL3v1MdijE+/EK/AtxrFliu4XJXJpNkMO2FS5A0tPhlo4FpEmzl8XHeTYaeTQG8WREFfOXfvYXuT76Jb91+dCnqk9OlbaEgPBnnz1G3irf8VRrLI2dgdtPdKZSAMenbrfEk6MEZcKJhrKmkVp99UbO2stIq+TCEqeB1v4YW3rgEsGuWzmjntYGODXtIAIOxnDWs6GQHqXPU5yU0gRaTkbwOS/Q9P2vB2Hb3lZ0XdJEe5PJ+rLQMSEXc3f+T+z4lCnWdmrVd4q1RwsVozmgyxvfqBGv0sSmyP8mjNJmHS4whSdAv0Z7pXyzrfOZC2Zws0UKJy6NfLaqjJzaigko6mRYt/bhwjQCFtiRJb3EVT1rd+KHanu4mydyOJPi+VjEFgP5P2987Pdl7buvQg7pRMEL4VXdHgAmVIxncJnizMwM29MDFQTEPGyYt6uNqocjkyAigYlZP6+tZD7QsSACJvYvOPnnyOvrTndE6cDUqUtqsIYTlA5qSfJcw43CZqpXitBoxjD4g7ZFuWa7Uxfymc2i5l89g1W3UkjuKDVfjRbKOnQ/ATAi7UUtGnOLBmOBx3cMzO3VKcp8889ftBpof9jpsnFdWGlhJET2VWfG96NhvS5UXRZBQd25SgQSfQcX67bnOuThsNQSPb3Pr1aZFHCodH3hbJjPwyhPwHrAf5g87v4mSeZXh8ft2YVmJWv/A78pTTGKN7l3hZzTl5f2zmhEMmF3d7qBR2ew5OSgMOwXx6LxNRuAWBme8LebxUELn4fih4dRVr01Hn1uDatJkCI+CHX0eMbQ/2ep1aZFb1xWgRM0N5r79sXHXLEHzA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24041e29-75dc-428f-67f6-08dad24e263e X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 21:10:31.7096 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JA8341/Xa+iDWpc3pZLvvf7Of5N0wbC++wL6e63NYh0wiYjo5kJGGDQUZM+9EQ99gwZhXLIDAiVecZa0RxsAng/BkqA7/oIGCPSNz8h+ttQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5042 T24gMjkvMTEvMjAyMiAyMDo1NiwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMjkvMTEvMjAy MiAxNDo1NSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiBCeSBkZWZpbmluZyB0aGUgY29uc3RhbnQg dG8gemVybyB3aGVuICFTSEFET1dfUEFHSU5HIHdlIGdpdmUgY29tcGlsZXJzDQo+PiB0aGUgY2hh bmNlIHRvIGVsaW1pbmF0ZSBhIGxpdHRsZSBtb3JlIGRlYWQgY29kZSBlbHNld2hlcmUgaW4gdGhl IHRyZWUuDQo+PiBQbHVzLCBhcyBhIG1pbm9yIGJlbmVmaXQsIHRoZSBnZW5lcmFsIHJlZmVyZW5j ZSBjb3VudCBjYW4gYmUgb25lIGJpdA0KPj4gd2lkZXIuIChUbyBzaW1wbGlmeSB0aGluZ3MsIGhh dmUgUEdDX3BhZ2VfdGFibGUgY2hhbmdlIHBsYWNlcyB3aXRoDQo+PiBQR0NfZXh0cmEuKQ0KPj4N Cj4+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gQWhl YWQgb2YgbWFraW5nIHRoaXMgY2hhbmdlLCBjYW4gd2UgcGxlYXNlIHJlbmFtZSBpdCB0byBzb21l dGhpbmcgbGVzcw0KPiBjb25mdXNpbmcsIGFuZCBmaXggaXQncyBjb21tZW50IHdoaWNoIGlzIHdy b25nLg0KPg0KPiBQR0Nfc2hhZG93ZWRfcHQgaXMgdGhlIGJlc3QgSSBjYW4gdGhpbmsgb2YuDQo+ DQo+PiAtLS0NCj4+IHRib290LmMncyB1cGRhdGVfcGFnZXRhYmxlX21hYygpIGlzIHN1c3BpY2lv dXM6IEl0IGVmZmVjdGl2ZWx5IGlzIGENCj4+IG5vLW9wIGV2ZW4gcHJpb3IgdG8gdGhpcyBjaGFu Z2Ugd2hlbiAhU0hBRE9XX1BBR0lORywgd2hpY2ggY2FuJ3QgYmUNCj4+IHF1aXRlIHJpZ2h0LiBJ ZiAoZ3Vlc3QpIHBhZ2UgdGFibGVzIGFyZSByZWxldmFudCB0byBpbmNsdWRlIGluIHRoZQ0KPj4g dmVyaWZpY2F0aW9uLCBzaG91bGRuJ3QgdGhpcyBsb29rIGZvciBQR1RfbDxOPl9wYWdlX3RhYmxl IGFzIHdlbGw/IEhvdw0KPj4gdG8gZGVhbCB3aXRoIEhBUCBndWVzdHMgdGhlcmUgaXMgZW50aXJl bHkgdW5jbGVhci4NCj4gQ29uc2lkZXJpbmcgdGhlIGNhbGxlciwgaXQgTUFDcyBldmVyeSBkb21o ZWFwIHBhZ2UgZm9yIGRvbWFpbnMgd2l0aA0KPiBDREZfczNfaW50ZWdyaXR5Lg0KPg0KPiBUaGUg dGJvb3QgbG9naWNhbCBhbHNvIGJsaW5kbHkgYXNzdW1lcyB0aGF0IGFueSBub24taWRsZSBkb21h aW4gaGFzIGFuDQo+IEludGVsIElPTU1VIGNvbnRleHQgd2l0aCBpdC7CoCBUaGlzIG9ubHkgZG9l c24ndCAodHJpdmlhbGx5KSBleHBvc2UNCj4gYmVjYXVzZSBzdHJ1Y3QgZG9tYWluX2lvbW11IGlz IGVtYmVkZGVkIGluIHN0cnVjdCBkb21haW4gKHJhdGhlciB0aGFuDQo+IGFsbG9jYXRlZCBzZXBh cmF0ZWx5KSwgYW5kIHJlYWNoaW5nIGludG8gdGhlIHdyb25nIHBhcnQgb2YgdGhlIGFyY2gNCj4g dW5pb24gaXMgb25seSBtaXRpZ2F0ZWQgYnkgdGhlIHRib290IGxvZ2ljIG5vdCBiZWluZyBpbnZv a2VkIG9uDQo+IG5vbi1pbnRlbCBzeXN0ZW1zLsKgIChBbHNvIHRoZSBpZGxlIGRvbWFpbiBjaGVj ayBpcyB1c2VsZXNzLCBnaXZlbiB0aGF0DQo+IGl0J3MgaW4gYSBmb3JfZWFjaF9kb21haW4oKSBs b29wKS4NCg0KV293IEkgcmVhbGx5IGZhaWxlZCBhdCB0eXBpbmcgaGVyZS7CoCAiVGhlIHRib290 IGxvZ2ljIiwgYW5kICJkb2Vzbid0DQoodHJpdmlhbGx5KSBleHBsb2RlIi4NCg0KfkFuZHJldw0K DQo+DQo+IEl0IGRvZXMgbG9vayBhIGxpdHRsZSBsaWtlIHRoZSBjYWxsZXIgaXMgd2FudGluZyB0 byBNQUMgYWxsIFhlbiBkYXRhDQo+IHRoYXQgZGVzY3JpYmVzIHRoZSBndWVzdCwgYnV0IGRvaW5n IHRoaXMgdW5pbGF0ZXJhbGx5IGZvciBhbGwgc2hhZG93ZWQNCj4gZ3Vlc3RzIHNlZW1zIHdyb25n IGJlc2lkZSB0aGUgcGVyLWRvbWFpbiBzM19pbnRlZ3JpdHkgc2V0dGluZy4NCj4NCj4gfkFuZHJl dw0KDQo= From xen-devel-bounces@lists.xenproject.org Tue Nov 29 22:12:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 22:12:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449668.706548 (Exim 4.92) (envelope-from ) id 1p08pu-0000m1-Sn; Tue, 29 Nov 2022 22:12:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449668.706548; Tue, 29 Nov 2022 22:12:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p08pu-0000lu-Q7; Tue, 29 Nov 2022 22:12:18 +0000 Received: by outflank-mailman (input) for mailman id 449668; Tue, 29 Nov 2022 22:12:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p08pt-0000lV-KK for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 22:12:17 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e1728be7-7032-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 23:12:15 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5B7F8B8196F; Tue, 29 Nov 2022 22:12:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E382C433C1; Tue, 29 Nov 2022 22:12:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1728be7-7032-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669759934; bh=4RuzJ7BL/FNTfCIqwW3Nd0sZ43y1DcZWKvFgBlC79Bk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=e+713zTdnBG5bqmBw1GuwUkAD9XOWKXqxw7XYNHaRrqoT3BkU+ZEivAGBOEtpdtJr uJYLYoMCoGj18nBRzGXNQv7KnWVdcW6xxrqttiseiOt9JoG6m9tOGsRDWUC7rIXN/L 3G0vCXtbgPs7zaQ9E1J7nNu7Gm2etSc7PUpWrDc0aeYo4/9AgGTZd+/bkPkKUj4soQ J2HhcACKyzKeAWP5jn+Q2MiBLP5kEJXgwEVxif1RJRHnshOZ8mEAQ0UcPIXtukdkB5 hr2elIJAs/xUjmkN991e7/bLC2EFVaUeZBsayv5rbJAJluKTwmWVcimvi+hL+LvbM2 RROj9X2TqT19g== Date: Tue, 29 Nov 2022 14:12:10 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Roger Pau Monne cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Greg Kroah-Hartman , Jiri Slaby , Juergen Gross , Boris Ostrovsky , Jan Beulich , Stefano Stabellini , Olof Johansson , Ingo Molnar , Jeremy Fitzhardinge , Chris Wright , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] hvc/xen: prevent concurrent accesses to the shared ring In-Reply-To: <20221129120107.2942-1-roger.pau@citrix.com> Message-ID: References: <20221129120107.2942-1-roger.pau@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1290527983-1669759303=:4039" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1290527983-1669759303=:4039 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Tue, 29 Nov 2022, Roger Pau Monne wrote: > The hvc machinery registers both a console and a tty device based on > the hv ops provided by the specific implementation. Those two > interfaces however have different locks, and there's no single locks > that's shared between the tty and the console implementations, hence > the driver needs to protect itself against concurrent accesses. > Otherwise concurrent calls using the split interfaces are likely to > corrupt the ring indexes, leaving the console unusable. > > Introduce a lock to xencons_info to serialize accesses to the shared > ring. This is only required when using the shared memory console, > concurrent accesses to the hypercall based console implementation are > not an issue. > > Note the conditional logic in domU_read_console() is slightly modified > so the notify_daemon() call can be done outside of the locked region: > it's an hypercall and there's no need for it to be done with the lock > held. > > Fixes: b536b4b96230 ('xen: use the hvc console infrastructure for Xen console') > Signed-off-by: Roger Pau Monné > --- > While the write handler (domU_write_console()) is used by both the > console and the tty ops, that's not the case for the read side > (domU_read_console()). It's not obvious to me whether we could get > concurrent poll calls from the poll_get_char tty hook, hence stay on > the safe side also serialize read accesses in domU_read_console(). I think domU_read_console doesn't need it. struct hv_ops and struct console are both already locked although independently locked. I think we shouldn't add an unrequired lock there. > --- > drivers/tty/hvc/hvc_xen.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c > index 7c23112dc923..d65741983837 100644 > --- a/drivers/tty/hvc/hvc_xen.c > +++ b/drivers/tty/hvc/hvc_xen.c > @@ -43,6 +43,7 @@ struct xencons_info { > int irq; > int vtermno; > grant_ref_t gntref; > + spinlock_t ring_lock; > }; > > static LIST_HEAD(xenconsoles); > @@ -84,12 +85,15 @@ static int __write_console(struct xencons_info *xencons, > XENCONS_RING_IDX cons, prod; > struct xencons_interface *intf = xencons->intf; > int sent = 0; > + unsigned long flags; > > + spin_lock_irqsave(&xencons->ring_lock, flags); > cons = intf->out_cons; > prod = intf->out_prod; > mb(); /* update queue values before going on */ > > if ((prod - cons) > sizeof(intf->out)) { > + spin_unlock_irqrestore(&xencons->ring_lock, flags); > pr_err_once("xencons: Illegal ring page indices"); > return -EINVAL; > } > @@ -99,6 +103,7 @@ static int __write_console(struct xencons_info *xencons, > > wmb(); /* write ring before updating pointer */ > intf->out_prod = prod; > + spin_unlock_irqrestore(&xencons->ring_lock, flags); > > if (sent) > notify_daemon(xencons); > @@ -141,16 +146,19 @@ static int domU_read_console(uint32_t vtermno, char *buf, int len) > int recv = 0; > struct xencons_info *xencons = vtermno_to_xencons(vtermno); > unsigned int eoiflag = 0; > + unsigned long flags; > > if (xencons == NULL) > return -EINVAL; > intf = xencons->intf; > > + spin_lock_irqsave(&xencons->ring_lock, flags); > cons = intf->in_cons; > prod = intf->in_prod; > mb(); /* get pointers before reading ring */ > > if ((prod - cons) > sizeof(intf->in)) { > + spin_unlock_irqrestore(&xencons->ring_lock, flags); > pr_err_once("xencons: Illegal ring page indices"); > return -EINVAL; > } > @@ -174,10 +182,13 @@ static int domU_read_console(uint32_t vtermno, char *buf, int len) > xencons->out_cons = intf->out_cons; > xencons->out_cons_same = 0; > } > + if (!recv && xencons->out_cons_same++ > 1) { > + eoiflag = XEN_EOI_FLAG_SPURIOUS; > + } > + spin_unlock_irqrestore(&xencons->ring_lock, flags); > + > if (recv) { > notify_daemon(xencons); > - } else if (xencons->out_cons_same++ > 1) { > - eoiflag = XEN_EOI_FLAG_SPURIOUS; > } > > xen_irq_lateeoi(xencons->irq, eoiflag); > @@ -576,6 +587,7 @@ static int __init xen_hvc_init(void) > > info = vtermno_to_xencons(HVC_COOKIE); > info->irq = bind_evtchn_to_irq_lateeoi(info->evtchn); > + spin_lock_init(&info->ring_lock); Don't we also need a call to spin_lock_init in xencons_connect_backend and xen_cons_init and xenboot_console_setup ? > } > if (info->irq < 0) > info->irq = 0; /* NO_IRQ */ > -- > 2.37.3 > --8323329-1290527983-1669759303=:4039-- From xen-devel-bounces@lists.xenproject.org Tue Nov 29 22:25:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 22:25:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449673.706560 (Exim 4.92) (envelope-from ) id 1p092W-0002fh-1X; Tue, 29 Nov 2022 22:25:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449673.706560; Tue, 29 Nov 2022 22:25:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p092V-0002fa-Uw; Tue, 29 Nov 2022 22:25:19 +0000 Received: by outflank-mailman (input) for mailman id 449673; Tue, 29 Nov 2022 22:25:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p092U-0002fU-SQ for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 22:25:18 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b3accec4-7034-11ed-91b6-6bf2151ebd3b; Tue, 29 Nov 2022 23:25:17 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 66E00B8197E; Tue, 29 Nov 2022 22:25:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEBD4C433D6; Tue, 29 Nov 2022 22:25:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3accec4-7034-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669760715; bh=MTi3eCesRlzQNLX++3E0N9zK19ByIHxrBbpWGeJzPsc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=bcuwe4011W1EV7m7lqiLQCoubqhZSBuRQ4IFeHON2n+irELW9/XO4T1BNRrd3sFQG C8iloTFvWqOLLjrasPmVZmRvL21w4m6XgrxeaQN0n4oMWpI5BcMR7N1pRcEDfOKd6l qXAWhElGrrP2DeS840ArAoGgl089SvzMDKI7/ex75BkDHXInBDU4I0NddEENZLVRQv iicP73qxnn1g0HG4cOdXTIzzhHBtWPP3wYxFDpAREURYvnonHpJ2DMGLPlUgEZrEnZ 1AFf1zpagYRmQrVpTa5kXCcEa1QdfAR0C2uN9O1uzX9dqGVrTqTYdfMPg4D8nRlPOF ycJ+Oe2l21X8A== Date: Tue, 29 Nov 2022 14:25:12 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Roger Pau Monne cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Greg Kroah-Hartman , Jiri Slaby , Juergen Gross , Stefano Stabellini , Boris Ostrovsky , Jan Beulich , Konrad Rzeszutek Wilk , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] hvc/xen: lock console list traversal In-Reply-To: <20221129143145.4234-1-roger.pau@citrix.com> Message-ID: References: <20221129143145.4234-1-roger.pau@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-503985613-1669760387=:4039" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-503985613-1669760387=:4039 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Tue, 29 Nov 2022, Roger Pau Monne wrote: > The currently lockless access to the xen console list in > vtermno_to_xencons() is incorrect, as additions and removals from the > list can happen anytime, and as such the traversal of the list to get > the private console data for a given termno needs to happen with the > lock held. Note users that modify the list already do so with the > lock taken. > > While there switch from using list_for_each_entry_safe to > list_for_each_entry: the current entry cursor won't be removed as > part of the code in the loop body, so using the _safe variant is > pointless. > > Fixes: 02e19f9c7cac ('hvc_xen: implement multiconsole support') > Signed-off-by: Roger Pau Monné > --- > drivers/tty/hvc/hvc_xen.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c > index d65741983837..117dc48f980e 100644 > --- a/drivers/tty/hvc/hvc_xen.c > +++ b/drivers/tty/hvc/hvc_xen.c > @@ -53,17 +53,22 @@ static DEFINE_SPINLOCK(xencons_lock); > > static struct xencons_info *vtermno_to_xencons(int vtermno) > { > - struct xencons_info *entry, *n, *ret = NULL; > + struct xencons_info *entry, *ret = NULL; > + unsigned long flags; > > - if (list_empty(&xenconsoles)) > - return NULL; > + spin_lock_irqsave(&xencons_lock, flags); If xencons_lock requires irqsave then we need to change all the xencons_lock spinlocks to call irqsave, including the ones in xen_hvm_console_init if they can happen at runtime. > + if (list_empty(&xenconsoles)) { > + spin_unlock_irqrestore(&xencons_lock, flags); > + return NULL; > + } > > - list_for_each_entry_safe(entry, n, &xenconsoles, list) { > + list_for_each_entry(entry, &xenconsoles, list) { > if (entry->vtermno == vtermno) { > ret = entry; > break; > } > } > + spin_unlock_irqrestore(&xencons_lock, flags); > > return ret; > } > -- > 2.37.3 > --8323329-503985613-1669760387=:4039-- From xen-devel-bounces@lists.xenproject.org Tue Nov 29 23:00:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 23:00:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449678.706571 (Exim 4.92) (envelope-from ) id 1p09aH-0007ST-PG; Tue, 29 Nov 2022 23:00:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449678.706571; Tue, 29 Nov 2022 23:00:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p09aH-0007SM-LG; Tue, 29 Nov 2022 23:00:13 +0000 Received: by outflank-mailman (input) for mailman id 449678; Tue, 29 Nov 2022 23:00:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p09aG-0007Qf-4C; Tue, 29 Nov 2022 23:00:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p09aF-00039r-VI; Tue, 29 Nov 2022 23:00:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p09aF-0004u6-Kc; Tue, 29 Nov 2022 23:00:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1p09aF-0007MH-KA; Tue, 29 Nov 2022 23:00:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XZbDTAlknhiV3OYbpCa1lvokiswmM18NH0LPC8EvNDU=; b=1BLMacGMKLSI0sGPv9WPyO3pUO q4ylD+m2W9+TOfPqCEOYUqvDffuSWt3COjnrzHSTAJgl+91ATj7OqX0qHkPPkoTQQ1nmcem5bs2fw IIl3wu1GEOBjZhbNEnuE3rkhglXay33vD01/PLGErzsWrzBJ5zw7mFWK70P+R5mO+z8U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174990: all pass - PUSHED X-Osstest-Versions-This: ovmf=8aff08c817728092fda5707ae27cfa6321108980 X-Osstest-Versions-That: ovmf=b92e0495221a3b298b069d9fb01e48fd2a0469f6 From: osstest service owner Date: Tue, 29 Nov 2022 23:00:11 +0000 flight 174990 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174990/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8aff08c817728092fda5707ae27cfa6321108980 baseline version: ovmf b92e0495221a3b298b069d9fb01e48fd2a0469f6 Last test of basis 174987 2022-11-29 10:13:15 Z 0 days Testing same since 174990 2022-11-29 19:40:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b92e049522..8aff08c817 8aff08c817728092fda5707ae27cfa6321108980 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Nov 29 23:52:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 29 Nov 2022 23:52:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449687.706582 (Exim 4.92) (envelope-from ) id 1p0ANx-0005NR-OB; Tue, 29 Nov 2022 23:51:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449687.706582; Tue, 29 Nov 2022 23:51:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0ANx-0005NK-LN; Tue, 29 Nov 2022 23:51:33 +0000 Received: by outflank-mailman (input) for mailman id 449687; Tue, 29 Nov 2022 23:51:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0ANw-0005NE-0o for xen-devel@lists.xenproject.org; Tue, 29 Nov 2022 23:51:32 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be144469-7040-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 00:51:29 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 31C4FB817BB; Tue, 29 Nov 2022 23:51:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D48AC433C1; Tue, 29 Nov 2022 23:51:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be144469-7040-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669765886; bh=C75V34+Ow/44DJ3mf/LUmPvzrLRJ7RgB01JL25nL5zQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=huDVbi1COqsyzNEkafLwb2vTCg/Ykovahb/x2bBlk6ASmgVGKlntuPx2tzJ+wAWXl 8Aw32qLBduG1aJZIfw71iyPQGY1TDhv2t6bzsvL43JBB/0dBvA21UW0Bc0TCti08KB B/sk7LWj+8yfzkpNhvXmKD0aHmtK+MV2VYJh50S15zExPBuEiRO6nJrjcxVy18zcl1 kICiOQQX0awoAbZRAoizVvLYuzdvTKBI/EqdVox4ujpEU2pwwvB1KDpCPhi8TFJGJR jrxVhmlRxr5ZZLPn8laAF2TbIZbZcKbzPIFSm9U0eCfYjHmchhKkaPzlK70AJzsSvo v1obuoUjjC23Q== Date: Tue, 29 Nov 2022 15:51:24 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH 3/4] tools/misra: fix skipped rule numbers In-Reply-To: <20221128141006.8719-4-luca.fancellu@arm.com> Message-ID: References: <20221128141006.8719-1-luca.fancellu@arm.com> <20221128141006.8719-4-luca.fancellu@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 28 Nov 2022, Luca Fancellu wrote: > Currently the script convert_misra_doc.py is using a loop through > range(1,22) to enumerate rules that needs to be skipped, however > range function does not include the stop counter in the enumeration > ending up into list rules until 21.21 instead of including rule 22. > > Fix the issue using a dictionary that list the rules in misra c2012. I think I understand the problem you are trying to solve with this patch. But I am confused about the proposed solution. The original code is trying to list all the possible MISRA C rules that are not in docs/misra/rules.rst. Instead of list(range(1,22)) now we have a dictionary: misra_c2012_rules. But misra_c2012_rules doesn't have all the possible MISRA C rules missing from docs/misra/rules.rst. As an example Rule 13.1 is missing from docs/misra/rules.rst but it is also missing from misra_c2012_rules. Can you please help me understand why misra_c2012_rules has only a small subset of MISRA C rules to be skipped? > Fixes: 57caa5375321 ("xen: Add MISRA support to cppcheck make rule") > Signed-off-by: Luca Fancellu > --- > xen/tools/convert_misra_doc.py | 32 ++++++++++++++++++++++++++++++-- > 1 file changed, 30 insertions(+), 2 deletions(-) > > diff --git a/xen/tools/convert_misra_doc.py b/xen/tools/convert_misra_doc.py > index caa4487f645f..13074d8a2e91 100755 > --- a/xen/tools/convert_misra_doc.py > +++ b/xen/tools/convert_misra_doc.py > @@ -14,6 +14,34 @@ Usage: > > import sys, getopt, re > > +# MISRA rule are identified by two numbers, e.g. Rule 1.2, the main rule number > +# and a sub-number. This dictionary contains the number of the MISRA rule as key > +# and the maximum sub-number for that rule as value. > +misra_c2012_rules = { > + 1:4, > + 2:7, > + 3:2, > + 4:2, > + 5:9, > + 6:2, > + 7:4, > + 8:14, > + 9:5, > + 10:8, > + 11:9, > + 12:5, > + 13:6, > + 14:4, > + 15:7, > + 16:7, > + 17:8, > + 18:8, > + 19:2, > + 20:14, > + 21:21, > + 22:10 > +} > + > def main(argv): > infile = '' > outfile = '' > @@ -142,8 +170,8 @@ def main(argv): > skip_list = [] > > # Search for missing rules and add a dummy text with the rule number > - for i in list(range(1,22)): > - for j in list(range(1,22)): > + for i in misra_c2012_rules: > + for j in list(range(1,misra_c2012_rules[i]+1)): > if str(i) + '.' + str(j) not in rule_list: > outstr.write('Rule ' + str(i) + '.' + str(j) + '\n') > outstr.write('No description for rule ' + str(i) + '.' + str(j) > -- > 2.17.1 > From xen-devel-bounces@lists.xenproject.org Wed Nov 30 01:02:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 01:02:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449692.706592 (Exim 4.92) (envelope-from ) id 1p0BUS-00040i-7P; Wed, 30 Nov 2022 01:02:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449692.706592; Wed, 30 Nov 2022 01:02:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0BUS-00040b-4Z; Wed, 30 Nov 2022 01:02:20 +0000 Received: by outflank-mailman (input) for mailman id 449692; Wed, 30 Nov 2022 01:02:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0BUQ-000408-3a; Wed, 30 Nov 2022 01:02:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0BUP-0004iF-WC; Wed, 30 Nov 2022 01:02:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0BUP-0003F3-L6; Wed, 30 Nov 2022 01:02:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1p0BUP-0002W7-JI; Wed, 30 Nov 2022 01:02:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vfMyxHkYwmrqhP9KXomRtdlMAzgLUpCnQ9NDTTrl4qg=; b=cHRdRh6ApvL9tMS5G28mM9nENL 2sTuKerVMtHHL1OadMYR02emgvU8iVUH9nixvcZUk4FDzbDXpfr0qYZYA75AFyhlfzb6fZpIpe6f6 ygkfg+AqylLIMY0BAOQPnFrOaKAsdya6GtydKL+66oAV4l02FvHmg+xK+9mzDX/7MJmY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 174992: all pass - PUSHED X-Osstest-Versions-This: ovmf=dd3ba82d31a6d3cc4564dc83c9229e13773b55da X-Osstest-Versions-That: ovmf=8aff08c817728092fda5707ae27cfa6321108980 From: osstest service owner Date: Wed, 30 Nov 2022 01:02:17 +0000 flight 174992 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174992/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf dd3ba82d31a6d3cc4564dc83c9229e13773b55da baseline version: ovmf 8aff08c817728092fda5707ae27cfa6321108980 Last test of basis 174990 2022-11-29 19:40:43 Z 0 days Testing same since 174992 2022-11-29 23:10:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 8aff08c817..dd3ba82d31 dd3ba82d31a6d3cc4564dc83c9229e13773b55da -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Nov 30 01:05:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 01:05:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449698.706604 (Exim 4.92) (envelope-from ) id 1p0BXr-0004b9-OI; Wed, 30 Nov 2022 01:05:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449698.706604; Wed, 30 Nov 2022 01:05:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0BXr-0004b2-L1; Wed, 30 Nov 2022 01:05:51 +0000 Received: by outflank-mailman (input) for mailman id 449698; Wed, 30 Nov 2022 01:05:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0BXo-0004aw-Tw for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 01:05:49 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d9ffc34-704b-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 02:05:45 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 673E76198D; Wed, 30 Nov 2022 01:05:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E7D9C433D6; Wed, 30 Nov 2022 01:05:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d9ffc34-704b-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669770342; bh=gRNP/yqsG3TfQZCOaw+/fk3TlAKPe6HQXqlwEMzH53A=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=jQegLzCHBHH2GO2nOWzIkEaJ7nEdFHUBXiNmitqv5PfYnHfDuCN6nNxs6AKNYHzcw uOKajNvcPIIpeKYV57jrlJBigvPpY7pKgl5WKvH795ngTBXH9fb7c7xVjS0WxDT8rq pydOXXj9oEnTmRmhECJw92Ci/V10KszjDTL9KZjtUmf8nbi1ffULFVz7N/UBdlz9lg RM35wSrlV07smV1MJ1CgQI3egG7t3avl+t7DmJDTmNZ6H4t/PboEX3mu5qrPso39wL FTIU56B31l67KHRKR4I3yy4OFbpIXw6p7ml0sUf0uc7XzSHH5n4ipDjJF52xZiyTGk Gn/vCpHC/RnyQ== Date: Tue, 29 Nov 2022 17:05:39 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH 2/4] xen/scripts: add cppcheck tool to the xen-analysis.py script In-Reply-To: <20221128141006.8719-3-luca.fancellu@arm.com> Message-ID: References: <20221128141006.8719-1-luca.fancellu@arm.com> <20221128141006.8719-3-luca.fancellu@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1378908238-1669767075=:4039" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1378908238-1669767075=:4039 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Mon, 28 Nov 2022, Luca Fancellu wrote: > Change cppcheck invocation method by using the xen-analysis.py > script using the arguments --run-cppcheck. > > Now cppcheck analysis will build Xen while the analysis is performed > on the source files, it will produce a text report and an additional > html output when the script is called with --cppcheck-html. > > With this patch cppcheck will benefit of platform configuration files > that will help it to understand the target of the compilation and > improve the analysis. > > To do so: > - remove cppcheck rules from Makefile and move them to the script. > - Update xen-analysis.py with the code to integrate cppcheck. > - merge the script merge_cppcheck_reports.py into the xen-analysis > script package and rework the code to integrate it. > - add platform configuration files for cppcheck.. > - add cppcheck-cc.sh script that is a wrapper for cppcheck and it's > used as Xen compiler, it will intercept all flags given from the > make build system and it will execute cppcheck on the compiled > file together with the file compilation. > - guarded hypercall-defs.c with CPPCHECK define because cppcheck > gets confused as the file does not contain c code. > - add false-positive-cppcheck.json file > - update documentation. > - update .gitignore > > Signed-off-by: Luca Fancellu I think the revert of the cppcheck integration in xen/Makefile and xen/tools/merge_cppcheck_reports.py could be a separate patch. There is no need to make sure cppcheck support in the xen Makefile is "bisectable". That patch could have my acked-by already. Also the document changes introduced in this patch have my reviewed-by: - docs/misra/cppcheck.txt - docs/misra/documenting-violations.rst - docs/misra/false-positive-cppcheck.json - docs/misra/xen-static-analysis.rst More below > --- > .gitignore | 8 +- > docs/misra/cppcheck.txt | 27 +- > docs/misra/documenting-violations.rst | 7 +- > docs/misra/false-positive-cppcheck.json | 12 + > docs/misra/xen-static-analysis.rst | 42 ++- > xen/Makefile | 116 +------- > xen/include/hypercall-defs.c | 9 + > xen/scripts/xen-analysis.py | 18 +- > xen/scripts/xen_analysis/cppcheck_analysis.py | 272 ++++++++++++++++++ > .../xen_analysis/cppcheck_report_utils.py | 130 +++++++++ > xen/scripts/xen_analysis/generic_analysis.py | 21 +- > xen/scripts/xen_analysis/settings.py | 77 ++++- > xen/scripts/xen_analysis/utils.py | 21 +- > xen/tools/cppcheck-cc.sh | 223 ++++++++++++++ > xen/tools/cppcheck-plat/arm32-wchar_t4.xml | 17 ++ > xen/tools/cppcheck-plat/arm64-wchar_t2.xml | 17 ++ > xen/tools/cppcheck-plat/arm64-wchar_t4.xml | 17 ++ > xen/tools/cppcheck-plat/x86_64-wchar_t2.xml | 17 ++ > xen/tools/cppcheck-plat/x86_64-wchar_t4.xml | 17 ++ > xen/tools/merge_cppcheck_reports.py | 86 ------ > 20 files changed, 899 insertions(+), 255 deletions(-) > create mode 100644 docs/misra/false-positive-cppcheck.json > create mode 100644 xen/scripts/xen_analysis/cppcheck_analysis.py > create mode 100644 xen/scripts/xen_analysis/cppcheck_report_utils.py > create mode 100755 xen/tools/cppcheck-cc.sh > create mode 100644 xen/tools/cppcheck-plat/arm32-wchar_t4.xml > create mode 100644 xen/tools/cppcheck-plat/arm64-wchar_t2.xml > create mode 100644 xen/tools/cppcheck-plat/arm64-wchar_t4.xml > create mode 100644 xen/tools/cppcheck-plat/x86_64-wchar_t2.xml > create mode 100644 xen/tools/cppcheck-plat/x86_64-wchar_t4.xml > delete mode 100755 xen/tools/merge_cppcheck_reports.py > > diff --git a/.gitignore b/.gitignore > index f5a66f6194dd..68566d0c2587 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -7,9 +7,11 @@ > *.o > *.d > *.d2 > -*.c.cppcheck > +*.cppcheck.txt > +*.cppcheck.xml > *.opic > *.a > +*.c.json > *.safparse > *.so > *.so.[0-9]* > @@ -282,9 +284,11 @@ xen/arch/*/efi/efi.h > xen/arch/*/efi/pe.c > xen/arch/*/efi/runtime.c > xen/arch/*/include/asm/asm-offsets.h > +xen/build-dir-cppcheck/ > xen/common/config_data.S > xen/common/config.gz > xen/cppcheck-htmlreport/ > +xen/cppcheck-report/ > xen/cppcheck-misra.* > xen/include/headers*.chk > xen/include/compat/* > @@ -315,7 +319,7 @@ xen/xsm/flask/xenpolicy-* > tools/flask/policy/policy.conf > tools/flask/policy/xenpolicy-* > xen/xen > -xen/xen-cppcheck.xml > +xen/suppression-list.txt > xen/xen-syms > xen/xen-syms.map > xen/xen.* > diff --git a/docs/misra/cppcheck.txt b/docs/misra/cppcheck.txt > index 25d8c3050b72..f7b9f678b4d5 100644 > --- a/docs/misra/cppcheck.txt > +++ b/docs/misra/cppcheck.txt > @@ -3,8 +3,7 @@ Cppcheck for Xen static and MISRA analysis > > Xen can be analysed for both static analysis problems and MISRA violation using > cppcheck, the open source tool allows the creation of a report with all the > -findings. Xen has introduced the support in the Makefile so it's very easy to > -use and in this document we can see how. > +findings. > > The minimum version required for cppcheck is 2.7. Note that at the time of > writing (June 2022), the version 2.8 is known to be broken [1]. > @@ -38,27 +37,7 @@ Dependencies are listed in the readme.md of the project repository. > Use cppcheck to analyse Xen > =========================== > > -Using cppcheck integration is very simple, it requires few steps: > - > - 1) Compile Xen > - 2) call the cppcheck make target to generate a report in xml format: > - make CPPCHECK_MISRA=y cppcheck > - 3) call the cppcheck-html make target to generate a report in xml and html > - format: > - make CPPCHECK_MISRA=y cppcheck-html > - > - In case the cppcheck binaries are not in the PATH, CPPCHECK and > - CPPCHECK_HTMLREPORT variables can be overridden with the full path to the > - binaries: > - > - make -C xen \ > - CPPCHECK=/path/to/cppcheck \ > - CPPCHECK_HTMLREPORT=/path/to/cppcheck-htmlreport \ > - CPPCHECK_MISRA=y \ > - cppcheck-html > - > -The output is by default in a folder named cppcheck-htmlreport, but the name > -can be changed by passing it in the CPPCHECK_HTMLREPORT_OUTDIR variable. > - > +To analyse Xen using cppcheck, please refer to the document > +xen-static-analysis.rst, section "Analyse Xen with Cppcheck". > > [1] https://sourceforge.net/p/cppcheck/discussion/general/thread/bfc3ab6c41/?limit=25 > diff --git a/docs/misra/documenting-violations.rst b/docs/misra/documenting-violations.rst > index 1d23447556d2..31dafd5d4ece 100644 > --- a/docs/misra/documenting-violations.rst > +++ b/docs/misra/documenting-violations.rst > @@ -51,6 +51,7 @@ Here is an example to add a new justification in safe.json:: > | { > | "id": "SAF-0-safe", > | "analyser": { > +| "cppcheck": "misra-c2012-20.7", > | "coverity": "misra_c_2012_rule_20_7_violation", > | "eclair": "MC3R1.R20.7" > | }, > @@ -77,9 +78,9 @@ Here is an explanation of the fields inside an object of the "content" array: > It tells the tool to substitute a Xen in-code comment having this structure: > /* SAF-0-safe [...] \*/ > - analyser: it is an object containing pair of key-value strings, the key is > - the analyser, so it can be coverity or eclair, the value is the proprietary > - id corresponding on the finding, for example when coverity is used as > - analyser, the tool will translate the Xen in-code coment in this way: > + the analyser, so it can be cppcheck, coverity or eclair, the value is the > + proprietary id corresponding on the finding, for example when coverity is > + used as analyser, the tool will translate the Xen in-code coment in this way: > /* SAF-0-safe [...] \*/ -> /* coverity[misra_c_2012_rule_20_7_violation] \*/ > if the object doesn't have a key-value, then the corresponding in-code > comment won't be translated. > diff --git a/docs/misra/false-positive-cppcheck.json b/docs/misra/false-positive-cppcheck.json > new file mode 100644 > index 000000000000..5d4da2ce6170 > --- /dev/null > +++ b/docs/misra/false-positive-cppcheck.json > @@ -0,0 +1,12 @@ > +{ > + "version": "1.0", > + "content": [ > + { > + "id": "SAF-0-false-positive-cppcheck", > + "violation-id": "", > + "tool-version": "", > + "name": "Sentinel", > + "text": "Next ID to be used" > + } > + ] > +} > diff --git a/docs/misra/xen-static-analysis.rst b/docs/misra/xen-static-analysis.rst > index 5b886474d4a0..2712255db1b0 100644 > --- a/docs/misra/xen-static-analysis.rst > +++ b/docs/misra/xen-static-analysis.rst > @@ -7,9 +7,8 @@ The Xen codebase integrates some scripts and tools that helps the developer to > perform static analysis of the code, currently Xen supports three analysis tool > that are eclair, coverity and cppcheck. > The Xen tree has a script (xen-analysis.py) available to ease the analysis > -process and it integrates a way to suppress findings on these tools (only Eclair > -and Coverity are currently supported by the script), please check the > -documenting-violation.rst document to know more about it. > +process and it integrates a way to suppress findings on these tools, please > +check the documenting-violation.rst document to know more about it. > > Analyse Xen with Coverity or Eclair > ----------------------------------- > @@ -52,3 +51,40 @@ When invoking the script, the procedure below will be followed: > this step, call the script adding the --no-clean argument, but before > running again the script, call it with the --clean-only argument, that will > execute only this cleaning step. > + > + > +Analyse Xen with Cppcheck > +------------------------- > + > +Cppcheck tool is integrated in xen-analysis.py script, when using the script, > +the tool will be called on every source file compiled by the make build system. > +Here how to start the analysis with Cppcheck: > + > + - xen-analysis.py --run-cppcheck [--cppcheck-misra] [--cppcheck-html] -- > + [optional make arguments] > + > +The command above tells the script to prepare the codebase and use Cppcheck tool > +for the analysis. > +The optional argument --cppcheck-misra activates the analysis also for MISRA > +compliance. > +The optional argument --cppcheck-html instruct cppcheck to produce an additional > +HTML report. > + > +When invoking the script for Cppcheck analysis, the followed procedure is > +similar to the one above for Coverity or Eclair, but it has some additional > +steps: > + > + 1. This step is the same as step 1 for Coverity/Eclair. > + 2. The cppcheck dependency are created, build directory for cppcheck analysis > + and an header file containing internal compiler macro > + (include/generated/compiler-def.h) are generated > + 3. Xen compilation starts using every supplied > + at the script invocation, but because cppcheck is not able to intercept the > + compiled files and flags on compiler invocation, a script (cppcheck-cc.sh) > + is passed as CC to the make system, it is a wrapper for the compiler that > + will also execute cppcheck on every compiled file. > + 4. After the compilation and analysis, the cppcheck report will be created > + putting together all the cppcheck report fragments for every analysed file. > + Cppcheck will produce a text fragment and an additional XML report fragment > + if the script is configured to produce the HTML output. > + 5. This step is the same as step 3 for Coverity/Eclair. > diff --git a/xen/Makefile b/xen/Makefile > index 9d0df5e2c543..77926724bcd7 100644 > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -457,7 +457,7 @@ endif # need-config > > __all: build > > -main-targets := build install uninstall clean distclean MAP cppcheck cppcheck-html > +main-targets := build install uninstall clean distclean MAP > .PHONY: $(main-targets) > ifneq ($(XEN_TARGET_ARCH),x86_32) > $(main-targets): %: _% ; > @@ -566,18 +566,16 @@ _clean: > $(Q)$(MAKE) $(clean)=tools/kconfig > find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \ > -o -name ".*.o.tmp" -o -name "*~" -o -name "core" \ > - -o -name '*.lex.c' -o -name '*.tab.[ch]' -o -name '*.c.cppcheck' \ > - -o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \; > + -o -name '*.lex.c' -o -name '*.tab.[ch]' -o -name "*.gcno" \ > + -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \; > rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET)-syms $(TARGET)-syms.map > rm -f $(TARGET).efi $(TARGET).efi.map $(TARGET).efi.stripped > rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h > rm -f .banner .allconfig.tmp include/xen/compile.h > - rm -f cppcheck-misra.* xen-cppcheck.xml > > .PHONY: _distclean > _distclean: clean > rm -f tags TAGS cscope.files cscope.in.out cscope.out cscope.po.out GTAGS GPATH GRTAGS GSYMS .config source > - rm -rf $(CPPCHECK_HTMLREPORT_OUTDIR) > > $(TARGET).gz: $(TARGET) > gzip -n -f -9 < $< > $@.new > @@ -651,111 +649,9 @@ cloc: > done; \ > done | cloc --list-file=- > > -# What cppcheck command to use. > -# To get proper results, it is recommended to build cppcheck manually from the > -# latest source and use CPPCHECK to give the full path to the built version. > -CPPCHECK ?= cppcheck > - > -# What cppcheck-htmlreport to use. > -# If you give the full path to a self compiled cppcheck, this should be set > -# to the full path to cppcheck-html in the htmlreport directory of cppcheck. > -# On recent distribution, this is available in the standard path. > -CPPCHECK_HTMLREPORT ?= cppcheck-htmlreport > - > -# By default we generate the report in cppcheck-htmlreport directory in the > -# build directory. This can be changed by giving a directory in this variable. > -CPPCHECK_HTMLREPORT_OUTDIR ?= cppcheck-htmlreport > - > -# By default we do not check misra rules, to enable pass "CPPCHECK_MISRA=y" to > -# make command line. > -CPPCHECK_MISRA ?= n > - > -# Compile flags to pass to cppcheck: > -# - include directories and defines Xen Makefile is passing (from CFLAGS) > -# - include config.h as this is passed directly to the compiler. > -# - define CPPCHECK as we use to disable or enable some specific part of the > -# code to solve some cppcheck issues. > -# - explicitely enable some cppcheck checks as we do not want to use "all" > -# which includes unusedFunction which gives wrong positives as we check file > -# per file. > -# > -# Compiler defines are in compiler-def.h which is included in config.h > -# > -CPPCHECKFLAGS := -DCPPCHECK --max-ctu-depth=10 \ > - --enable=style,information,missingInclude \ > - --include=$(srctree)/include/xen/config.h \ > - -I $(srctree)/xsm/flask/include \ > - -I $(srctree)/include/xen/libfdt \ > - $(filter -D% -I%,$(CFLAGS)) > - > -# We need to find all C files (as we are not checking assembly files) so > -# we find all generated .o files which have a .c corresponding file. > -CPPCHECKFILES := $(wildcard $(patsubst $(objtree)/%.o,$(srctree)/%.c, \ > - $(filter-out $(objtree)/tools/%, \ > - $(shell find $(objtree) -name "*.o")))) > - > -# Headers and files required to run cppcheck on a file > -CPPCHECKDEPS := $(objtree)/include/generated/autoconf.h \ > - $(objtree)/include/generated/compiler-def.h > - > -ifeq ($(CPPCHECK_MISRA),y) > - CPPCHECKFLAGS += --addon=cppcheck-misra.json > - CPPCHECKDEPS += cppcheck-misra.json > -endif > - > -quiet_cmd_cppcheck_xml = CPPCHECK $(patsubst $(srctree)/%,%,$<) > -cmd_cppcheck_xml = $(CPPCHECK) -v -q --xml $(CPPCHECKFLAGS) \ > - --output-file=$@ $< > - > -quiet_cmd_merge_cppcheck_reports = CPPCHECK-MERGE $@ > -cmd_merge_cppcheck_reports = $(PYTHON) $(srctree)/tools/merge_cppcheck_reports.py $^ $@ > - > -quiet_cmd_cppcheck_html = CPPCHECK-HTML $< > -cmd_cppcheck_html = $(CPPCHECK_HTMLREPORT) --file=$< --source-dir=$(srctree) \ > - --report-dir=$(CPPCHECK_HTMLREPORT_OUTDIR) --title=Xen > - > -PHONY += _cppcheck _cppcheck-html cppcheck-version > - > -_cppcheck-html: xen-cppcheck.xml > - $(call if_changed,cppcheck_html) > - > -_cppcheck: xen-cppcheck.xml > - > -xen-cppcheck.xml: $(patsubst $(srctree)/%.c,$(objtree)/%.c.cppcheck,$(CPPCHECKFILES)) > -ifeq ($(CPPCHECKFILES),) > - $(error Please build Xen before running cppcheck) > -endif > - $(call if_changed,merge_cppcheck_reports) > - > -$(objtree)/%.c.cppcheck: $(srctree)/%.c $(CPPCHECKDEPS) | cppcheck-version > - $(call if_changed,cppcheck_xml) > - > -cppcheck-version: > - $(Q)if ! which $(CPPCHECK) > /dev/null 2>&1; then \ > - echo "Cannot find cppcheck executable: $(CPPCHECK)"; \ > - exit 1; \ > - fi > - $(Q)if [ "$$($(CPPCHECK) --version | awk '{print ($$2 < 2.7)}')" -eq 1 ]; then \ > - echo "Please upgrade your cppcheck to version 2.7 or greater"; \ > - exit 1; \ > - fi > - > -# List of Misra rules to respect is written inside a doc. > -# In order to have some helpful text in the cppcheck output, generate a text > -# file containing the rules identifier, classification and text from the Xen > -# documentation file. Also generate a json file with the right arguments for > -# cppcheck in json format including the list of rules to ignore. > -# > -# convert_misra_doc.py, producing both targets at the same time, should be > -# executed only once. Utilize a pattern rule to achieve this effect, with the > -# stem kind of arbitrarily chosen to be "cppcheck". > -.PRECIOUS: %-misra.json > -%-misra.txt %-misra.json: $(XEN_ROOT)/docs/misra/rules.rst $(srctree)/tools/convert_misra_doc.py > - $(Q)$(PYTHON) $(srctree)/tools/convert_misra_doc.py -i $< -o $*-misra.txt -j $*-misra.json > - > -# Put this in generated headers this way it is cleaned by include/Makefile > -$(objtree)/include/generated/compiler-def.h: > - $(Q)$(CC) -dM -E -o $@ - < /dev/null > +# Target used by xen-analysis.sh script to retrieve Xen build system variables > +export-variable-%: > + $(info $*=$($*)) > > endif #config-build > endif # need-sub-make > diff --git a/xen/include/hypercall-defs.c b/xen/include/hypercall-defs.c > index 45b6f969d2ab..3d1eb7f04a73 100644 > --- a/xen/include/hypercall-defs.c > +++ b/xen/include/hypercall-defs.c > @@ -60,6 +60,13 @@ > * are possible. > */ > > +/* > + * Cppcheck thinks this file needs to be analysed because it is preprocessed by > + * the compiler, but it gets confused because this file does not contains C > + * code. Hence protect the code when CPPCHECK is used. > + */ > +#ifndef CPPCHECK > + > #ifdef CONFIG_HVM > #define PREFIX_hvm hvm > #else > @@ -286,3 +293,5 @@ mca do do - - - > #ifndef CONFIG_PV_SHIM_EXCLUSIVE > paging_domctl_cont do do do do - > #endif > + > +#endif /* !CPPCHECK */ > diff --git a/xen/scripts/xen-analysis.py b/xen/scripts/xen-analysis.py > index b5d9ef1862c9..8e50c27cd898 100755 > --- a/xen/scripts/xen-analysis.py > +++ b/xen/scripts/xen-analysis.py > @@ -1,28 +1,42 @@ > #!/usr/bin/env python3 > > import sys > -from xen_analysis import settings, generic_analysis > +from xen_analysis import settings, generic_analysis, cppcheck_analysis > from xen_analysis.generic_analysis import * > +from xen_analysis.cppcheck_analysis import * > + > +PhaseExceptions = (GetMakeVarsPhaseError, ParseTagPhaseError, > + CppcheckDepsPhaseError, BuildPhaseError, > + CppcheckReportPhaseError) > > > def main(argv): > ret_code = 0 > settings.parse_commandline(argv) > try: > + if settings.step_get_make_vars: > + cppcheck_analysis.get_make_vars() > if settings.step_parse_tags: > generic_analysis.parse_xen_tags() > + if settings.step_cppcheck_deps: > + cppcheck_analysis.generate_cppcheck_deps() > if settings.step_build_xen: > generic_analysis.build_xen() > - except (ParseTagPhaseError, BuildPhaseError) as e: > + if settings.step_cppcheck_report: > + cppcheck_analysis.generate_cppcheck_report() > + except PhaseExceptions as e: > print("ERROR: {}".format(e)) > if hasattr(e, "errorcode"): > ret_code = e.errorcode > finally: > if settings.step_clean_analysis: > + cppcheck_analysis.clean_analysis_artifacts() > e = generic_analysis.clean_analysis_artifacts() > if e: > print("ERROR: {}".format(e)) > ret_code = 1 > + if settings.step_distclean_analysis: > + cppcheck_analysis.clean_reports() > > sys.exit(ret_code) > > diff --git a/xen/scripts/xen_analysis/cppcheck_analysis.py b/xen/scripts/xen_analysis/cppcheck_analysis.py > new file mode 100644 > index 000000000000..e5c2f3be3e85 > --- /dev/null > +++ b/xen/scripts/xen_analysis/cppcheck_analysis.py > @@ -0,0 +1,272 @@ > +#!/usr/bin/env python3 > + > +import os, re, shutil > +from . import settings, utils, cppcheck_report_utils > + > +class GetMakeVarsPhaseError(Exception): > + pass > + > +class CppcheckDepsPhaseError(Exception): > + pass > + > +class CppcheckReportPhaseError(Exception): > + pass > + > +CPPCHECK_BUILD_DIR = "build-dir-cppcheck" > +CPPCHECK_HTMLREPORT_OUTDIR = "cppcheck-htmlreport" > +CPPCHECK_REPORT_OUTDIR = "cppcheck-report" > +cppcheck_extra_make_args = "" > +xen_cc = "" > + > +def get_make_vars(): > + global xen_cc > + invoke_make = utils.invoke_command( > + "make -C {} {} export-variable-CC" > + .format(settings.xen_dir, settings.make_forward_args), > + True, GetMakeVarsPhaseError, > + "Error occured retrieving make vars:\n{}" > + ) > + > + cc_var_regex = re.search('^CC=(.*)$', invoke_make, flags=re.M) > + if cc_var_regex: > + xen_cc = cc_var_regex.group(1) > + > + if xen_cc == "": > + raise GetMakeVarsPhaseError("CC variable not found in Xen make output") > + > + > +def __generate_suppression_list(out_file): > + # The following lambda function will return a file if it contains lines with > + # a comment containing "cppcheck-suppress[*]" on a single line. > + grep_action = lambda x: utils.grep(x, > + r'^[ \t]*/\* cppcheck-suppress\[(.*)\] \*/$') > + # Look for a list of .h files that matches the condition above > + headers = utils.recursive_find_file(settings.xen_dir, r'.*\.h$', > + grep_action) > + > + try: > + with open(out_file, "wt") as supplist_file: > + # Add this rule to skip every finding in the autogenerated > + # header for cppcheck > + supplist_file.write("*:*generated/compiler-def.h\n") > + > + for entry in headers: > + filename = entry["file"] > + try: > + with open(filename, "rt") as infile: > + header_content = infile.readlines() > + except OSError as e: > + raise CppcheckDepsPhaseError( > + "Issue with reading file {}: {}" > + .format(filename, e) > + ) > + header_lines_len = len(header_content) > + # line_num in entry will be header_content[line_num-1], here we > + # are going to search the first line after line_num that have > + # anything different from comments or empty line, because the > + # in-code comment suppression is related to that line then. > + for line_num in entry["matches"]: > + cppcheck_violation_id = "" > + tmp_line = line_num > + # look up to which line is referring the comment at > + # line_num (which would be header_content[tmp_line-1]) > + comment_section = False > + while tmp_line < header_lines_len: > + line = header_content[tmp_line] > + # Matches a line with just optional spaces/tabs and the > + # start of a comment '/*' > + comment_line_starts = re.match('^[ \t]*/\*.*$', line) > + # Matches a line with text and the end of a comment '*/' > + comment_line_stops = re.match('^.*\*/$', line) > + if (not comment_section) and comment_line_starts: > + comment_section = True > + if (len(line.strip()) != 0) and (not comment_section): > + cppcheck_violation_id = entry["matches"][line_num][0] > + break > + if comment_section and comment_line_stops: > + comment_section = False > + tmp_line = tmp_line + 1 > + > + if cppcheck_violation_id == "": > + raise CppcheckDepsPhaseError( > + "Error matching cppcheck comment in {} at line {}." > + .format(filename, line_num) > + ) > + # Write [error id]:[filename]:[line] > + # tmp_line refers to the array index, so translated to the > + # file line (that begins with 1) it is tmp_line+1 > + supplist_file.write( > + "{}:{}:{}\n".format(cppcheck_violation_id, filename, > + (tmp_line + 1)) > + ) > + except OSError as e: > + raise CppcheckDepsPhaseError("Issue with writing file {}: {}" > + .format(out_file, e)) > + > + > +def generate_cppcheck_deps(): > + global cppcheck_extra_make_args > + > + # Compile flags to pass to cppcheck: > + # - include config.h as this is passed directly to the compiler. > + # - define CPPCHECK as we use it to disable or enable some specific part of > + # the code to solve some cppcheck issues. > + # - explicitely enable some cppcheck checks as we do not want to use "all" > + # which includes unusedFunction which gives wrong positives as we check > + # file per file. > + # - Explicitly suppress warnings on compiler-def.h because cppcheck throws > + # an unmatchedSuppression due to the rule we put in suppression-list.txt > + # to skip every finding in the file. > + # > + # Compiler defines are in compiler-def.h which is included in config.h > + # > + cppcheck_flags=""" > +--cppcheck-build-dir={}/{} > + --max-ctu-depth=10 > + --enable=style,information,missingInclude > + --template=\'{{file}}({{line}},{{column}}):{{id}}:{{severity}}:{{message}}\' > + --relative-paths={} > + --inline-suppr > + --suppressions-list={}/suppression-list.txt > + --suppress='unmatchedSuppression:*generated/compiler-def.h' > + --include={}/include/xen/config.h I noticed that some of the includes we used to have like xsm/flask/include are missing here. Is that intended? > + -DCPPCHECK > +""".format(settings.outdir, CPPCHECK_BUILD_DIR, settings.xen_dir, > + settings.outdir, settings.xen_dir) > + > + invoke_cppcheck = utils.invoke_command( > + "{} --version".format(settings.cppcheck_binpath), > + True, CppcheckDepsPhaseError, > + "Error occured retrieving cppcheck version:\n{}\n\n{}" > + ) > + > + version_regex = re.search('^Cppcheck (.*)$', invoke_cppcheck, flags=re.M) > + # Currently, only cppcheck version >= 2.7 is supported, but version 2.8 is > + # known to be broken, please refer to docs/misra/cppcheck.txt > + if (not version_regex) or (version_regex.group(1) != "2.7"): > + raise CppcheckDepsPhaseError( > + "Can't find cppcheck version or version is not 2.7" > + ) > + > + # If misra option is selected, append misra addon and generate cppcheck > + # files for misra analysis > + if settings.cppcheck_misra: > + cppcheck_flags = cppcheck_flags + " --addon=cppcheck-misra.json" > + > + utils.invoke_command( > + "{}/convert_misra_doc.py -i {}/docs/misra/rules.rst" > + " -o {}/cppcheck-misra.txt -j {}/cppcheck-misra.json" > + .format(settings.tools_dir, settings.repo_dir, > + settings.outdir, settings.outdir), > + False, CppcheckDepsPhaseError, > + "An error occured when running:\n{}" > + ) > + > + # Generate compiler macros > + os.makedirs("{}/include/generated".format(settings.outdir), exist_ok=True) > + utils.invoke_command( > + "{} -dM -E -o \"{}/include/generated/compiler-def.h\" - < /dev/null" > + .format(xen_cc, settings.outdir), > + False, CppcheckDepsPhaseError, > + "An error occured when running:\n{}" > + ) > + > + # Generate cppcheck suppression list > + __generate_suppression_list( > + "{}/suppression-list.txt".format(settings.outdir)) > + > + # Generate cppcheck build folder > + os.makedirs("{}/{}".format(settings.outdir, CPPCHECK_BUILD_DIR), > + exist_ok=True) > + > + cppcheck_cc_flags = """--compiler={} --cppcheck-cmd={} {} > + --cppcheck-plat={}/cppcheck-plat --ignore-path=tools/ > +""".format(xen_cc, settings.cppcheck_binpath, cppcheck_flags, > + settings.tools_dir) > + > + if settings.cppcheck_html: > + cppcheck_cc_flags = cppcheck_cc_flags + " --cppcheck-html" > + > + # Generate the extra make argument to pass the cppcheck-cc.sh wrapper as CC > + cppcheck_extra_make_args = "CC=\"{}/cppcheck-cc.sh {} --\"".format( > + settings.tools_dir, > + cppcheck_cc_flags > + ).replace("\n", "") > + > + > +def generate_cppcheck_report(): > + # Prepare text report > + # Look for a list of .cppcheck.txt files, those are the txt report > + # fragments > + fragments = utils.recursive_find_file(settings.outdir, r'.*\.cppcheck.txt$') > + text_report_dir = "{}/{}".format(settings.outdir, > + CPPCHECK_REPORT_OUTDIR) > + report_filename = "{}/xen-cppcheck.txt".format(text_report_dir) > + os.makedirs(text_report_dir, exist_ok=True) > + try: > + cppcheck_report_utils.cppcheck_merge_txt_fragments(fragments, > + report_filename, > + [settings.xen_dir]) > + except cppcheck_report_utils.CppcheckTXTReportError as e: > + raise CppcheckReportPhaseError(e) > + > + # If HTML output is requested > + if settings.cppcheck_html: > + # Look for a list of .cppcheck.xml files, those are the XML report > + # fragments > + fragments = utils.recursive_find_file(settings.outdir, > + r'.*\.cppcheck.xml$') > + html_report_dir = "{}/{}".format(settings.outdir, > + CPPCHECK_HTMLREPORT_OUTDIR) > + xml_filename = "{}/xen-cppcheck.xml".format(html_report_dir) > + os.makedirs(html_report_dir, exist_ok=True) > + try: > + cppcheck_report_utils.cppcheck_merge_xml_fragments(fragments, > + xml_filename, > + settings.xen_dir, > + settings.outdir) > + except cppcheck_report_utils.CppcheckHTMLReportError as e: > + raise CppcheckReportPhaseError(e) > + # Call cppcheck-htmlreport utility to generate the HTML output > + utils.invoke_command( > + "{} --file={} --source-dir={} --report-dir={}/html --title=Xen" > + .format(settings.cppcheck_htmlreport_binpath, xml_filename, > + settings.xen_dir, html_report_dir), > + False, CppcheckReportPhaseError, > + "Error occured generating Cppcheck HTML report:\n{}" > + ) > + # Strip src and obj path from *.html files > + html_files = utils.recursive_find_file(html_report_dir, r'.*\.html$') > + try: > + cppcheck_report_utils.cppcheck_strip_path_html(html_files, > + (settings.xen_dir, > + settings.outdir)) > + except cppcheck_report_utils.CppcheckHTMLReportError as e: > + raise CppcheckReportPhaseError(e) > + > + > +def clean_analysis_artifacts(): > + clean_files = ("suppression-list.txt", "cppcheck-misra.txt", > + "cppcheck-misra.json") > + cppcheck_build_dir = "{}/{}".format(settings.outdir, CPPCHECK_BUILD_DIR) > + if os.path.isdir(cppcheck_build_dir): > + shutil.rmtree(cppcheck_build_dir) > + artifact_files = utils.recursive_find_file(settings.outdir, > + r'.*\.(?:c\.json|cppcheck\.txt|cppcheck\.xml)$') > + for file in clean_files: > + file = "{}/{}".format(settings.outdir, file) > + if os.path.isfile(file): > + artifact_files.append(file) > + for delfile in artifact_files: > + os.remove(delfile) > + > + > +def clean_reports(): > + text_report_dir = "{}/{}".format(settings.outdir, > + CPPCHECK_REPORT_OUTDIR) > + html_report_dir = "{}/{}".format(settings.outdir, > + CPPCHECK_HTMLREPORT_OUTDIR) > + if os.path.isdir(text_report_dir): > + shutil.rmtree(text_report_dir) > + if os.path.isdir(html_report_dir): > + shutil.rmtree(html_report_dir) > diff --git a/xen/scripts/xen_analysis/cppcheck_report_utils.py b/xen/scripts/xen_analysis/cppcheck_report_utils.py > new file mode 100644 > index 000000000000..02440aefdfec > --- /dev/null > +++ b/xen/scripts/xen_analysis/cppcheck_report_utils.py > @@ -0,0 +1,130 @@ > +#!/usr/bin/env python3 > + > +import os > +from xml.etree import ElementTree > + > +class CppcheckHTMLReportError(Exception): > + pass > + > +class CppcheckTXTReportError(Exception): > + pass > + > + > +def __elements_equal(el1, el2): > + if type(el1) != type(el2): return False > + > + if el1.find('location') is None: return False > + if el2.find('location') is None: return False > + > + el1_location = str(el1.find('location').attrib) > + el2_location = str(el2.find('location').attrib) > + > + if el1_location != el2_location: return False > + > + return True > + > + > +def __contain_element(new, lst): > + for elem in lst: > + if __elements_equal(new, elem): > + return True > + return False > + > + > +def __get_xml_root_file(filename): > + try: > + result_xml_root = ElementTree.parse(filename).getroot() > + except ElementTree.ParseError as e: > + raise CppcheckHTMLReportError( > + "XML parsing error in {}: {}".format(filename, e) > + ) > + return result_xml_root > + > + > +def __sanitize_cppcheck_xml_path(xml_tree, src_path, obj_path): > + # Some path are relative to the source tree but some others are generated > + # in the obj tree, for cppcheck when using cppcheck-htmlreport we can pass > + # only one source tree where the files will be fetched if relative path are > + # found. So for every path that does not exists in src tree, we guess it > + # comes from obj tree and we put explicit absolute path to it > + error_item_root = xml_tree.findall("errors")[0] > + for error_item in error_item_root: > + for location_item in error_item.findall("location"): > + path = location_item.attrib["file"] > + new_obj_path = obj_path + "/" + path > + new_src_path = src_path + "/" + path > + if (path[0] != "/") and (not os.path.isfile(new_src_path)) \ > + and os.path.isfile(new_obj_path): > + location_item.attrib["file"] = new_obj_path > + > + > +def cppcheck_merge_xml_fragments(fragments_list, out_xml_file, src_path, > + obj_path): > + > + result_xml = __get_xml_root_file(fragments_list[0]) > + insert_point = result_xml.findall("errors")[0] > + for xml_file in fragments_list[1:]: > + xml_root = __get_xml_root_file(xml_file) > + curr_elem_list = list(insert_point) > + new_elem_list = list(xml_root.findall("errors")[0]) > + for xml_error_elem in new_elem_list: > + if not __contain_element(xml_error_elem, curr_elem_list): > + insert_point.insert(1, xml_error_elem) > + > + if result_xml is None: > + return False > + > + __sanitize_cppcheck_xml_path(result_xml, src_path, obj_path) > + > + ElementTree.ElementTree(result_xml).write(out_xml_file) > + > + return True > + > + > +def cppcheck_merge_txt_fragments(fragments_list, out_txt_file, strip_paths): > + try: > + with open(out_txt_file, "wt") as outfile: > + # Using a set will remove automatically the duplicate lines > + text_report_content = set() > + for file in fragments_list: > + try: > + with open(file, "rt") as infile: > + frag_lines = infile.readlines() > + except OSError as e: > + raise CppcheckTXTReportError( > + "Issue with reading file {}: {}" > + .format(file, e) > + ) > + text_report_content.update(frag_lines) > + > + # Back to modifiable list > + text_report_content = list(text_report_content) > + # Strip path from report lines > + for i in list(range(0, len(text_report_content))): > + for path in strip_paths: > + text_report_content[i] = text_report_content[i].replace( > + path + "/", "") > + # Write the final text report > + outfile.writelines(text_report_content) > + except OSError as e: > + raise CppcheckTXTReportError("Issue with writing file {}: {}" > + .format(out_txt_file, e)) > + > + > +def cppcheck_strip_path_html(html_files, strip_paths): > + for file in html_files: > + try: > + with open(file, "rt") as infile: > + html_lines = infile.readlines() > + except OSError as e: > + raise CppcheckHTMLReportError("Issue with reading file {}: {}" > + .format(file, e)) > + for i in list(range(0, len(html_lines))): > + for path in strip_paths: > + html_lines[i] = html_lines[i].replace(path + "/", "") > + try: > + with open(file, "wt") as outfile: > + outfile.writelines(html_lines) > + except OSError as e: > + raise CppcheckHTMLReportError("Issue with writing file {}: {}" > + .format(file, e)) > diff --git a/xen/scripts/xen_analysis/generic_analysis.py b/xen/scripts/xen_analysis/generic_analysis.py > index 0b470c4ecf7d..94122aebace0 100644 > --- a/xen/scripts/xen_analysis/generic_analysis.py > +++ b/xen/scripts/xen_analysis/generic_analysis.py > @@ -1,7 +1,7 @@ > #!/usr/bin/env python3 > > -import os, subprocess > -from . import settings, utils, tag_database > +import os > +from . import settings, utils, tag_database, cppcheck_analysis > > class ParseTagPhaseError(Exception): > pass > @@ -60,18 +60,13 @@ def parse_xen_tags(): > > > def build_xen(): > - try: > - subprocess.run( > - "make -C {} {} build" > - .format(settings.xen_dir, settings.make_forward_args), > - shell=True, check=True > + utils.invoke_command( > + "make -C {} {} {} build" > + .format(settings.xen_dir, settings.make_forward_args, > + cppcheck_analysis.cppcheck_extra_make_args), > + False, BuildPhaseError, > + "Build error occured when running:\n{}" > ) > - except (subprocess.CalledProcessError, subprocess.SubprocessError) as e: > - excp = BuildPhaseError( > - "Build error occured when running:\n{}".format(e.cmd) > - ) > - excp.errorcode = e.returncode if hasattr(e, 'returncode') else 1 > - raise excp > > > def clean_analysis_artifacts(): > diff --git a/xen/scripts/xen_analysis/settings.py b/xen/scripts/xen_analysis/settings.py > index 947dfa2d50af..bd1faafe79a3 100644 > --- a/xen/scripts/xen_analysis/settings.py > +++ b/xen/scripts/xen_analysis/settings.py > @@ -7,14 +7,23 @@ xen_dir = os.path.realpath(module_dir + "/../..") > repo_dir = os.path.realpath(xen_dir + "/..") > tools_dir = os.path.realpath(xen_dir + "/tools") > > +step_get_make_vars = False > step_parse_tags = True > +step_cppcheck_deps = False > step_build_xen = True > +step_cppcheck_report = False > step_clean_analysis = True > +step_distclean_analysis = False > > target_build = False > target_clean = False > +target_distclean = False > > analysis_tool = "" > +cppcheck_binpath = "cppcheck" > +cppcheck_html = False > +cppcheck_htmlreport_binpath = "cppcheck-htmlreport" > +cppcheck_misra = False > make_forward_args = "" > outdir = xen_dir > > @@ -26,29 +35,47 @@ Usage: {} [OPTION] ... [-- [make arguments]] > This script runs the analysis on the Xen codebase. > > Options: > - --build-only Run only the commands to build Xen with the optional make > - arguments passed to the script > - --clean-only Run only the commands to clean the analysis artifacts > - -h, --help Print this help > - --no-build Skip the build Xen phase > - --no-clean Don\'t clean the analysis artifacts on exit > - --run-coverity Run the analysis for the Coverity tool > - --run-eclair Run the analysis for the Eclair tool > + --build-only Run only the commands to build Xen with the optional > + make arguments passed to the script > + --clean-only Run only the commands to clean the analysis artifacts > + --cppcheck-bin= Path to the cppcheck binary (Default: {}) > + --cppcheck-html Produce an additional HTML output report for Cppcheck > + --cppcheck-html-bin= Path to the cppcheck-html binary (Default: {}) > + --cppcheck-misra Activate the Cppcheck MISRA analysis > + --distclean Clean analysis artifacts and reports > + -h, --help Print this help > + --no-build Skip the build Xen phase > + --no-clean Don\'t clean the analysis artifacts on exit > + --run-coverity Run the analysis for the Coverity tool > + --run-cppcheck Run the Cppcheck analysis tool on Xen > + --run-eclair Run the analysis for the Eclair tool > """ > - print(msg.format(sys.argv[0])) > + print(msg.format(sys.argv[0], cppcheck_binpath, > + cppcheck_htmlreport_binpath)) > > > def parse_commandline(argv): > global analysis_tool > + global cppcheck_binpath > + global cppcheck_html > + global cppcheck_htmlreport_binpath > + global cppcheck_misra > global make_forward_args > global outdir > + global step_get_make_vars > global step_parse_tags > + global step_cppcheck_deps > global step_build_xen > + global step_cppcheck_report > global step_clean_analysis > + global step_distclean_analysis > global target_build > global target_clean > + global target_distclean > forward_to_make = False > for option in argv: > + args_with_content_regex = re.match(r'^(--[a-z]+[a-z-]*)=(.*)$', option) > + > if forward_to_make: > # Intercept outdir > outdir_regex = re.match("^O=(.*)$", option) > @@ -60,6 +87,18 @@ def parse_commandline(argv): > target_build = True > elif option == "--clean-only": > target_clean = True > + elif args_with_content_regex and \ > + args_with_content_regex.group(1) == "--cppcheck-bin": > + cppcheck_binpath = args_with_content_regex.group(2) > + elif option == "--cppcheck-html": > + cppcheck_html = True > + elif args_with_content_regex and \ > + args_with_content_regex.group(1) == "--cppcheck-html-bin": > + cppcheck_htmlreport_binpath = args_with_content_regex.group(2) > + elif option == "--cppcheck-misra": > + cppcheck_misra = True > + elif option == "--distclean": > + target_distclean = True > elif (option == "--help") or (option == "-h"): > help() > sys.exit(0) > @@ -69,6 +108,11 @@ def parse_commandline(argv): > step_clean_analysis = False > elif (option == "--run-coverity") or (option == "--run-eclair"): > analysis_tool = option[6:] > + elif (option == "--run-cppcheck"): > + analysis_tool = "cppcheck" > + step_get_make_vars = True > + step_cppcheck_deps = True > + step_cppcheck_report = True > elif option == "--": > forward_to_make = True > else: > @@ -76,13 +120,23 @@ def parse_commandline(argv): > help() > sys.exit(1) > > - if target_build and target_clean: > - print("--build-only is not compatible with --clean-only argument.") > + if target_build and (target_clean or target_distclean): > + print("--build-only is not compatible with --clean-only/--distclean " > + "argument.") > sys.exit(1) > > + if target_distclean: > + # Implicit activation of clean target > + target_clean = True > + > + step_distclean_analysis = True > + > if target_clean: > + step_get_make_vars = False > step_parse_tags = False > + step_cppcheck_deps = False > step_build_xen = False > + step_cppcheck_report = False > step_clean_analysis = True > return > > @@ -95,3 +149,4 @@ def parse_commandline(argv): > step_parse_tags = False > step_build_xen = True > step_clean_analysis = False > + step_cppcheck_report = False > diff --git a/xen/scripts/xen_analysis/utils.py b/xen/scripts/xen_analysis/utils.py > index a912d812c3df..1193e3f4631e 100644 > --- a/xen/scripts/xen_analysis/utils.py > +++ b/xen/scripts/xen_analysis/utils.py > @@ -1,6 +1,6 @@ > #!/usr/bin/env python3 > > -import os, re > +import os, re, subprocess > > > def grep(filepath, regex): > @@ -35,3 +35,22 @@ def recursive_find_file(path, filename_regex, action = None): > res.append(out) > > return res > + > + > +def invoke_command(command, needs_output, exeption_type = Exception, > + exeption_msg = ""): > + try: > + pipe_stdout = subprocess.PIPE if (needs_output == True) else None > + output = subprocess.run(command, shell=True, check=True, > + stdout=pipe_stdout, stderr=subprocess.STDOUT, > + encoding='utf8') > + except (subprocess.CalledProcessError, subprocess.SubprocessError) as e: > + if needs_output == True: > + exeption_msg = exeption_msg.format(e.cmd, output.stdout) > + else: > + exeption_msg = exeption_msg.format(e.cmd) > + excp = exeption_type(exeption_msg) > + excp.errorcode = e.returncode if hasattr(e, 'returncode') else 1 > + raise excp > + > + return output.stdout > diff --git a/xen/tools/cppcheck-cc.sh b/xen/tools/cppcheck-cc.sh > new file mode 100755 > index 000000000000..e682f6b9d79d > --- /dev/null > +++ b/xen/tools/cppcheck-cc.sh > @@ -0,0 +1,223 @@ > +#!/usr/bin/env bash > + > +set -e > + > +function help() { > + cat < +Usage: ${0} [OPTION] ... -- > + > +This script is a wrapper for cppcheck that enables it to analyse the files that > +are the target for the build, it is used in place of a selected compiler and the > +make process will run it on every file that needs to be built. > +All the arguments passed to the original compiler are forwarded to it without > +modification, furthermore, they are used to improve the cppcheck analysis. > + > +Options: > + --compiler= Use this compiler for the build > + --cppcheck-cmd= Command line for the cppcheck analysis. > + --cppcheck-html Prepare for cppcheck HTML output > + --cppcheck-plat= Path to the cppcheck platform folder > + --ignore-path= This script won't run cppcheck on the files having this > + path, the compiler will run anyway on them. This argument > + can be specified multiple times. > + -h, --help Print this help > +EOF > +} > + > +CC_FILE="" > +COMPILER="" > +CPPCHECK_HTML="n" > +CPPCHECK_PLAT_PATH="" > +CPPCHECK_TOOL="" > +CPPCHECK_TOOL_ARGS="" > +FORWARD_FLAGS="" > +IGNORE_PATH="n" > +IGNORE_PATH_LIST="" > +JDB_FILE="" > +OBJTREE_PATH="" > + > +# Variable used for arg parsing > +forward_to_cc="n" > +sm_tool_args="n" > +obj_arg_content="n" > + > +for OPTION in "$@" > +do > + if [ "${forward_to_cc}" = "y" ]; then > + if [[ ${OPTION} == *.c ]] > + then > + CC_FILE="${OPTION}" > + elif [ "${OPTION}" = "-o" ] > + then > + # After -o there is the path to the obj file, flag it > + obj_arg_content="y" > + elif [ "${obj_arg_content}" = "y" ] > + then > + # This must be the path to the obj file, turn off flag and save path > + OBJTREE_PATH="$(dirname "${OPTION}")" > + obj_arg_content="n" > + fi > + # Forward any argument to the compiler > + FORWARD_FLAGS="${FORWARD_FLAGS} ${OPTION}" > + continue > + fi > + case ${OPTION} in > + -h|--help) > + help > + exit 0 > + ;; > + --compiler=*) > + COMPILER="$(eval echo "${OPTION#*=}")" This can be: COMPILER="${OPTION#*=}" and same for all the other below > + sm_tool_args="n" > + ;; > + --cppcheck-cmd=*) > + CPPCHECK_TOOL="$(eval echo "${OPTION#*=}")" > + sm_tool_args="y" > + ;; > + --cppcheck-html) > + CPPCHECK_HTML="y" > + sm_tool_args="n" > + ;; > + --cppcheck-plat=*) > + CPPCHECK_PLAT_PATH="$(eval echo "${OPTION#*=}")" > + sm_tool_args="n" > + ;; > + --ignore-path=*) > + IGNORE_PATH_LIST="${IGNORE_PATH_LIST} $(eval echo "${OPTION#*=}")" > + sm_tool_args="n" > + ;; > + --) > + forward_to_cc="y" > + sm_tool_args="n" > + ;; > + *) > + if [ "${sm_tool_args}" = "y" ]; then > + CPPCHECK_TOOL_ARGS="${CPPCHECK_TOOL_ARGS} ${OPTION}" > + else > + echo "Invalid option ${OPTION}" > + exit 1 It doesn't look like sm_tool_args is really needed? It is only set to 'y' in the case of --cppcheck-cmd, and in that case we also set CPPCHECK_TOOL. CPPCHECK_TOOL is the variable used below. Am I missing something? > + fi > + ;; > + esac > +done > + > +if [ "${COMPILER}" = "" ] > +then > + echo "--compiler arg is mandatory." > + exit 1 > +fi > + > +function print_file() { > + local text="${1}" > + local init_file="${2}" > + > + if [ "${init_file}" = "y" ] > + then > + echo -e -n "${text}" > "${JDB_FILE}" > + else > + echo -e -n "${text}" >> "${JDB_FILE}" > + fi The >> can be used to create a file if the file is not already present. So why the need for this if? In fact, we don't need print_file at all and we can just echo -e -n "something" >> "${JDB_FILE}" directly from create_jcd. If you are concerned about a preexisting file, then at the beginning of create_jcd you can: rm "${JDB_FILE}" > +} > + > +function create_jcd() { > + local line="${1}" > + local arg_num=0 > + local same_line=0 > + > + print_file "[\n" "y" > + print_file " {\n" > + print_file " \"arguments\": [\n" > + > + for arg in ${line}; do > + # This code prevents to put comma in the last element of the list or on > + # sequential lines that are going to be merged > + [ "${arg_num}" -ne 0 ] && [ "${same_line}" -eq 0 ] && print_file ",\n" > + if [ "${same_line}" -ne 0 ] > + then > + print_file "${arg}\"" > + same_line=0 > + elif [ "${arg}" = "-iquote" ] || [ "${arg}" = "-I" ] > + then > + # cppcheck doesn't understand -iquote, substitute with -I > + print_file " \"-I" > + same_line=1 > + else > + print_file " \"${arg}\"" > + fi > + arg_num=$(( arg_num + 1 )) > + done > + print_file "\n" > + print_file " ],\n" > + print_file " \"directory\": \"$(pwd -P)\",\n" > + print_file " \"file\": \"${CC_FILE}\"\n" > + print_file " }\n" > + print_file "]\n" > +} > + > + > +# Execute compiler with forwarded flags > +# Shellcheck complains about missing quotes on FORWARD_FLAGS, but they can't be > +# used here > +# shellcheck disable=SC2086 > +${COMPILER} ${FORWARD_FLAGS} > + > +if [ -n "${CC_FILE}" ]; > +then > + for path in ${IGNORE_PATH_LIST} > + do > + if [[ ${CC_FILE} == *${path}* ]] > + then > + IGNORE_PATH="y" > + echo "${0}: ${CC_FILE} ignored by --ignore-path matching *${path}*" > + fi > + done > + if [ "${IGNORE_PATH}" = "n" ] > + then > + JDB_FILE="${OBJTREE_PATH}/$(basename "${CC_FILE}".json)" > + > + # Prepare the Json Compilation Database for the file > + create_jcd "${COMPILER} ${FORWARD_FLAGS}" > + > + out_file="${OBJTREE_PATH}/$(basename "${CC_FILE%.c}".cppcheck.txt)" > + > + # Check wchar size > + wchar_plat_suffix="t4" > + # sed prints the last occurence of -f(no-)short-wchar which is the one > + # applied to the file by the compiler > + wchar_option=$(echo "${FORWARD_FLAGS}" | \ > + sed -nre 's,.*(-f(no-)?short-wchar).*,\1,p') > + if [ "${wchar_option}" = "-fshort-wchar" ] > + then > + wchar_plat_suffix="t2" > + fi This seems a bit unnecessary: we should be able to find the right platform file from XEN_TARGET_ARCH alone. No need to reverse engineer the compiler command line? > + > + # Select the right target platform, ARCH is generated from Xen Makefile > + platform="${CPPCHECK_PLAT_PATH}/${ARCH}-wchar_${wchar_plat_suffix}.xml" > + if [ ! -f "${platform}" ] > + then > + echo "${platform} not found!" > + exit 1 > + fi > + > + # Shellcheck complains about missing quotes on CPPCHECK_TOOL_ARGS, but > + # they can't be used here > + # shellcheck disable=SC2086 > + ${CPPCHECK_TOOL} ${CPPCHECK_TOOL_ARGS} \ > + --project="${JDB_FILE}" \ > + --output-file="${out_file}" \ > + --platform=${platform} > + > + if [ "${CPPCHECK_HTML}" = "y" ] > + then > + # Shellcheck complains about missing quotes on CPPCHECK_TOOL_ARGS, > + # but they can't be used here > + # shellcheck disable=SC2086 > + ${CPPCHECK_TOOL} ${CPPCHECK_TOOL_ARGS} \ > + --project="${JDB_FILE}" \ > + --output-file="${out_file%.txt}.xml" \ > + --platform=${platform} \ > + -q \ > + --xml This is showing my ignorance in cppcheck, but does it actually need to be called twice in the html generation case? Actually three times if we count the extra cppcheck-htmlreport call? > + fi > + fi > +fi > diff --git a/xen/tools/cppcheck-plat/arm32-wchar_t4.xml b/xen/tools/cppcheck-plat/arm32-wchar_t4.xml > new file mode 100644 > index 000000000000..3aefa7ba5c98 > --- /dev/null > +++ b/xen/tools/cppcheck-plat/arm32-wchar_t4.xml > @@ -0,0 +1,17 @@ > + > + > + 8 > + unsigned usually in C the default is actually "signed" not "unsigned". If you write: int i; i is signed > + > + 2 > + 4 > + 4 > + 8 > + 4 > + 8 > + 8 > + 4 > + 4 > + 4 > + > + > diff --git a/xen/tools/cppcheck-plat/arm64-wchar_t2.xml b/xen/tools/cppcheck-plat/arm64-wchar_t2.xml > new file mode 100644 > index 000000000000..e345b934a986 > --- /dev/null > +++ b/xen/tools/cppcheck-plat/arm64-wchar_t2.xml > @@ -0,0 +1,17 @@ > + > + > + 8 > + unsigned > + > + 2 > + 4 > + 8 > + 8 > + 4 > + 8 > + 16 > + 8 > + 4 Isn't size_t 8 bytes on arm64? > + 2 > + > + --8323329-1378908238-1669767075=:4039-- From xen-devel-bounces@lists.xenproject.org Wed Nov 30 01:11:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 01:11:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449706.706615 (Exim 4.92) (envelope-from ) id 1p0Bcz-0006HG-Fs; Wed, 30 Nov 2022 01:11:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449706.706615; Wed, 30 Nov 2022 01:11:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Bcz-0006H9-Cz; Wed, 30 Nov 2022 01:11:09 +0000 Received: by outflank-mailman (input) for mailman id 449706; Wed, 30 Nov 2022 01:11:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Bcy-0006Gz-G2; Wed, 30 Nov 2022 01:11:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Bcy-00051W-C3; Wed, 30 Nov 2022 01:11:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Bcx-0003m1-Q7; Wed, 30 Nov 2022 01:11:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1p0Bcx-0005Km-Pd; Wed, 30 Nov 2022 01:11:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GxttnWgIZl3Ws1L3QgZ0EUG94zjDGDGUiCnkag7BrU0=; b=Jv3MX8pYDpotQIiRydnHTayo0s knlUQc2s0aiWvZbEf5sB5VM3qz8N3Rjyg6WaWYZgfuMQViBkmYnix4YS4fV/qOJZCf4BmYTI/Zr5U qyOR7ZG/LmIUpNSB2M7r6bsTLMTvomhEv3DacOAFNhWFyfXG4eRGDo8tTAEj+pP7qJOo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174989: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=ecbb6bd865d23ec412b9f2b715be784e45389f91 X-Osstest-Versions-That: qemuu=ac149498215809bfb5c0ddce1953519fbfda5004 From: osstest service owner Date: Wed, 30 Nov 2022 01:11:07 +0000 flight 174989 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174989/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174976 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174976 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174976 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174976 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174976 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174976 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174976 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174976 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu ecbb6bd865d23ec412b9f2b715be784e45389f91 baseline version: qemuu ac149498215809bfb5c0ddce1953519fbfda5004 Last test of basis 174976 2022-11-28 01:08:46 Z 1 days Testing same since 174989 2022-11-29 19:38:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Richard Henderson Stefan Hajnoczi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git ac14949821..ecbb6bd865 ecbb6bd865d23ec412b9f2b715be784e45389f91 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Nov 30 07:05:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 07:05:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449722.706626 (Exim 4.92) (envelope-from ) id 1p0HA1-00035d-Gf; Wed, 30 Nov 2022 07:05:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449722.706626; Wed, 30 Nov 2022 07:05:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0HA1-00035W-Dy; Wed, 30 Nov 2022 07:05:37 +0000 Received: by outflank-mailman (input) for mailman id 449722; Wed, 30 Nov 2022 07:05:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0H9z-00035M-Lu; Wed, 30 Nov 2022 07:05:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0H9z-00053w-Hy; Wed, 30 Nov 2022 07:05:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0H9z-0006jg-3w; Wed, 30 Nov 2022 07:05:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1p0H9z-0005pg-3O; Wed, 30 Nov 2022 07:05:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=peB3wX1ysL57E5qqj7AYuFIWECIO5AgZAB6dZv4NvPA=; b=DQNWa/IGUb/K4N3QG8lDwxWxGy 0WySQr4pHjOUaiWcm7jakCUSD/n/q/W4uv7oGVSmdEDju4esfF/630Ccrj/4TQL/IhJxppkKWUPgn uoneDauBnrJbK9SRqqj4dtk3bUF3u4ubWvcxKPNG7LMT/sY3PbElt114CX3mlglUBoDE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174991: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=01f856ae6d0ca5ad0505b79bf2d22d7ca439b2a1 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 30 Nov 2022 07:05:35 +0000 flight 174991 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174991/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux 01f856ae6d0ca5ad0505b79bf2d22d7ca439b2a1 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 53 days Failing since 173470 2022-10-08 06:21:34 Z 53 days 102 attempts Testing same since 174991 2022-11-29 21:43:19 Z 0 days 1 attempts ------------------------------------------------------------ 1924 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 184155 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Nov 30 07:10:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 07:10:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449730.706637 (Exim 4.92) (envelope-from ) id 1p0HEH-0003jN-7w; Wed, 30 Nov 2022 07:10:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449730.706637; Wed, 30 Nov 2022 07:10:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0HEH-0003j5-3x; Wed, 30 Nov 2022 07:10:01 +0000 Received: by outflank-mailman (input) for mailman id 449730; Wed, 30 Nov 2022 07:09:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0HEF-0003iv-J4 for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 07:09:59 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2060f.outbound.protection.outlook.com [2a01:111:f400:fe12::60f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ff128d46-707d-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 08:09:58 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7344.eurprd04.prod.outlook.com (2603:10a6:800:1a1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20; Wed, 30 Nov 2022 07:09:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 07:09:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff128d46-707d-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZHxEnU+/E5zCMFZd7Od1BV1Ch6nTd7HclqIKC2D/O/+7PztoRpU5o2/wsMCK7m58e7Lz+H2yGht9BAb7ASHXEdku2xCsQz+gooOCHymekjo3FVrUTeFHgThDoa6mTwCALdoZo/ArgCoXdrb+hiI+WDKsENWvXWKiLo6Q2/VgXgfTVgz5m73vq7syeHv0TifZj4QCANqu9nflvNwuvc5sjsT1Ij7Y03stz/A8tob4cVLGLCZy94epBSfl8OrMyPeap42NxvwLPtFEhpg32B9xPXlbggkECQA3LNHMJAEME/Asw6ZjraRmOTkbHenovHf1gmtOBicfqVVLf5ObUVU2Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xpyK08Vqk6dONHsWeVR2ow6OIUp6q0mwqG7BsJwv2po=; b=J3NCgH+z2nOtaGsupPs/yi3L+tc58g3dqk1fobVBUaNb1B+/OFq6M3O8YnW2kk1cDl7Y+Bd9j7ayFA7CLauW7NQaUXWb8GD7TAXiUnV1Xm8V5sdMPylSQK9IU2Or73hWz4lNjC2Cem7QAXgNWEGcccYFG1Vx/ErsfpuMZ345DD/DKm06UyCQp4CIdeXl09Tjzv8ch+RtDc5AtXC+0wRO6RZPpRj4T6eDgbSI3xMH72Igg6WgkyExboERMeH4CAx0xIecZQV9eWNr4wm3IvBY1uADjbaSxC4CdPrHD3WVkbdgtJg5PuvylH/uBofSfEz0n8bRvzrq7G03fAz67Uirlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xpyK08Vqk6dONHsWeVR2ow6OIUp6q0mwqG7BsJwv2po=; b=378mGQ9naG7K7iybiaSOvVMdrXVmbrha0AnAq3w4R1R6vism+Me8QRej0F2S6dRW4YmzR0osCZTvH3IeGg1M42Y/FK5ZmJjR3717/zrf4XRrXCLCH76x1FDokMUAkMm/5fAVL+Ov/tTY1tqdTLsM7wK+L1rJr79s/EfddzqWSafYWdbkl8dRaw7+Y/x0wzKdGWhKZWgWo6U1PnVhDMydD1AaQixsUnOca1QOVqTqEX6mcWtrnVZ6K2rEqgyfjZ8SPMV092EJjbGJ1GsTE2/1w3+LTCnOZZaewj8f6TXuAmQOR+iRc7gMoRvK/0Vetgc1AtT7H3oWT9E2cGJ2uC+tXQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <22d28805-8889-25e9-6d18-c868bf5e51bb@suse.com> Date: Wed, 30 Nov 2022 08:09:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: Arm: AArch32: Need suggestions to support 32 bit physical addresses Content-Language: en-US To: Ayan Kumar Halder Cc: Stefano Stabellini , "Stabellini, Stefano" , bertrand Marquis , Andre Przywara , "Volodymyr_Babchuk@epam.com" , Rahul Singh , Vladimir Murzin , Julien Grall , "xen-devel@lists.xenproject.org" References: <70651dbc-085d-706d-17d0-a419086a0700@amd.com> <65891843-db28-e5dd-6e9e-3fb003fcabc5@amd.com> <105a0d45-5b3d-7986-92c1-9a13eb803bd8@amd.com> From: Jan Beulich In-Reply-To: <105a0d45-5b3d-7986-92c1-9a13eb803bd8@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0168.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7344:EE_ X-MS-Office365-Filtering-Correlation-Id: c782e178-8f28-4851-6600-08dad2a1e222 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vnac9Z2+nUSAjOCYkX6lQNkhhx5aoWYRxjOW98eP1lM540bzYMdvkyPkP7a+20l3sxGduNXFbz5TDIdTnzshxggWgMvFpHt3/Qy6xWkq3avz0aPeLdfBj3sC18zA4CWKQDk4HV6QjC7lma3jgngJGkIYUT/uRm6ISeoCmZYucm/dm0SsSC7o3fYTaLDmoe8eanbrk0fl5j1nSYv+XGuOnptB1SA+aOaL9cFVMN8eg0GcZaMxlBj85AALd327kQZDM5ttAHWL1aKGW8stQdEJFy6pRvB6SDI9PMAQqwQ9ztzfYCgaG8QcoB8i86HpZ+YFxtAtnxug6xI3/TXETNgsxkGEo2N8VpZWVihBb8LgpH07E2kfiIgtpJmw51dqsurU4gtkAmgm0kxXfW28rF5rWxIxOWfyZqApw1fg2qAZBr/lhdXvAcKGSd6NxSNR0S2Mi1jm9RqG5689TI0j5gkJHgQ8YD2l/RBX7+GKvYjTre2tIlSbHYhXh/RLb2pLqyq8CxUeWjtzJsJrWie3dYwxiHUOUbuDEu/6HgPR2tU6Hb8B/8EQXzh/p2viWYQw6hhkyH16uIMHlvq/72S9GrIi4z7De6leRfr+37TsluaA25S7LAsmu1oZgddhIttebErn7YecuPJcjpaMQnsrv2C3Zn9lFCQ0oy4Lr9SLqvXUxUXrJRpk6AqtySJqjrwWDGmclC84vpx0dBnktIW5uUMuuokju+ipRcRKShWC568D2qA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(366004)(346002)(376002)(136003)(451199015)(86362001)(83380400001)(66476007)(31696002)(2906002)(41300700001)(7416002)(6506007)(8936002)(4326008)(5660300002)(26005)(53546011)(6512007)(186003)(316002)(6486002)(54906003)(8676002)(38100700002)(478600001)(6916009)(2616005)(66946007)(36756003)(66556008)(66899015)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXFVMERJREZmZXFFMmRDTzJDeURMdDdiL0lXWjV1WU9Sd0xOTGUxL2tmekJP?= =?utf-8?B?MHVzZ2pCUGZUM0lQSWhoSFFLeVdoK3pYRC9KMzJ4Qi9JOEFyWmkxR3BLVTdY?= =?utf-8?B?d093T0NHaDZrOHlwcFRrMlZEZnd1Qk5oZDRrYThBQXZSVC9HR2tLenRjVWdO?= =?utf-8?B?bXd6aGd1bTJOWFg4MkFVNGJrRExCNHNRRTc2cXVEZCszQkVpRzNNR1lvR0E5?= =?utf-8?B?b2tuVXE3OU13R21ZeGFQV1N2OCtxZm1tQ0sxWWh5ekFQNXR5TkZJTHgxK1du?= =?utf-8?B?b3dCK201eDc1bzVHVU9KZzVDL1BlN2x3R1B5TjlUejArVEZSRXVBeU1mb01L?= =?utf-8?B?K1pjcDRhVWIza3JZTjdxZEhzaFlaaGhCaW9wNTB4YW5aV1NBM05nNnNDc3U0?= =?utf-8?B?UEpNY2F4bVpJTk9XenAzaHMrQ3I0dmR4dVRTMzAwclZ6UXh5dHRaekRtTXRO?= =?utf-8?B?ZmdTNURNdnR1SFMrUG54SElqK2h1R0pmeEs1OVhVdStJVEhpK1dSaXFsZE81?= =?utf-8?B?R2JScm95bm5JSWJqOUJ5b2N4aFo4ZGw3MDVyOS9hb2Y2T1duZVNzb0k4TEhl?= =?utf-8?B?djZpRXEvZlJTcUdVdDZRVFpWdWV4YVVmbzZNNVR2b1RpejczcTlOR1c0dHpE?= =?utf-8?B?NFBOZnF4MHFtVnVubG1KN0VwOE93WnBJYk1xcDh4TEhTK0tSMEF0LzdZRjlL?= =?utf-8?B?WG5ZUm01ZHRDRVVCaFUrOXFNT0NpMTR5YXh5Qy9CV0RKcmlvYlYxYVlaeFk5?= =?utf-8?B?R0tJKytaZlBtS0J2VGh2aWVtM1VpSGRoTi93TVJlam9RWm01WG4yT01aUjFr?= =?utf-8?B?SWY4R0xkQkJTUlFaNDBxUnA2NFUyUm5ucDArTTJFMUlCSmRzRnZJTVFFZWJp?= =?utf-8?B?dlpjWms2cVNaLzYrV1BiRCtZdSs0K1UwL051YzRIRGtHRHRucUhlQjI2UERM?= =?utf-8?B?a0JQTDY3ZVhtMTdiSXNqTU5xK0lnR3kzVzJUL2ExaTF2NzZBYVFSRUtROE8w?= =?utf-8?B?YWxCaDZmMkJhRUxlL3c2ZnEwZ01YM2lLdGhpZFRPbDVMS01sTmpCYmNHVEhR?= =?utf-8?B?SlJpbmk5aFVZQlpReG9mUTdSVXhqTmQzQVNja2lHWjJSQkEzbWR1TFZnT3ZD?= =?utf-8?B?VUpCVUU1dlNZTVVwM0Z3MkJTamJtVmJYK2F1dkVkQXhneE5pYUV0aUVvVFJv?= =?utf-8?B?WEVPbzlRRG0zbTE5UWQyRnZvZFg0YjlOWlY0Sk5VRi9GdVpTalRMUG9Rb2s1?= =?utf-8?B?RDZIRW44dUdpUjlPL3FRODZHQlZvSlQ3NmU0VWpGWW9HaC9hMjQyQ2JzbWRS?= =?utf-8?B?QWNydzEyMW9nWElUZFlDbXdWOVdzSVMyMXRxSyt1R1NJWGJjaXNRbndrSVFn?= =?utf-8?B?Mk9RTFp6Zk1Ia0E1bmxBekZJUkNwWFhSV1JzNmEyWkt4cTI0VkNJREV0QU0z?= =?utf-8?B?TzFZWFZOYWdzbFVmZmpsOTVkclh1YTU3T056Zzk3d0xvWHpGTVNqTUZjRDM4?= =?utf-8?B?TENGVTRkYndYY2dTTHpXQTJYUDJoeTkrcVd5dW43WW83OW5BMmJjMDFCZ3pN?= =?utf-8?B?ek1OK2hwOTNCQmo4bmxRMVpIZUJYUDNZV3ZSUG5CK05rYnc5SzF6OFd2T0dY?= =?utf-8?B?Yk0yMmVFQTYwWkk5L2kwMmI1R25UNHJ2dnpjR1UxZTBKWDVMenhXKzVVM0hS?= =?utf-8?B?MTY2MmtJR1J1ckxTTEJtdFZrNWRZSk16WmNPa2hTZHNsYWQwOE1qQUVOV2xZ?= =?utf-8?B?S0duR3RMTndRemk5Vmh0VXVnQzdTbDFnZWtkakk4N1FlcHh1cHZFeXNPTUh4?= =?utf-8?B?UmlGdjhpSFBRazkyUyt1ZTJqTHlWbGNvdzRWTXlYZ1JKY3JrQXh2bDRyaVBY?= =?utf-8?B?UVJNQXNlZlZ2M0ZrRWl2VlM2dlhrUmtROXIzNUx3QjY1WEhOOVZGc2NROFhj?= =?utf-8?B?MzNxVGI5OXAyb2hNdmZoUG5uOFRoSG41S3NLTUg4OGFGTUpuUm8vYlF1Vm1H?= =?utf-8?B?V21qUFRydFUvbnFTVDRpSGt5SSttTUsyUmgrb0s0M3BJTGZYelE2QmVlMzZa?= =?utf-8?B?WC9EKzM0eTI0b1dha0JPOHR5Sm5HZllGS2ZMbU1KL1FJeGoyUUlKTkV4OTkv?= =?utf-8?Q?Tiiw4FAIJwSfdFwGxhK9onMPB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c782e178-8f28-4851-6600-08dad2a1e222 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 07:09:55.2756 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L2XylXvk4XCBTSy4ZDuMjbnwom+2Smcvox/jsPSSGfXp4kJeDMiar+RjNi1sctQSKjSDGtXmhb20p6i6mlY2cA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7344 On 29.11.2022 19:18, Ayan Kumar Halder wrote: > On 29/11/2022 15:52, Julien Grall wrote: >> On 29/11/2022 16:23, Ayan Kumar Halder wrote: >>> On 29/11/2022 14:52, Julien Grall wrote: >>>> On 29/11/2022 14:57, Ayan Kumar Halder wrote: >>> --- a/xen/common/page_alloc.c >>> +++ b/xen/common/page_alloc.c >>> @@ -2245,7 +2245,9 @@ void __init xenheap_max_mfn(unsigned long mfn) >>>   { >>>       ASSERT(!first_node_initialised); >>>       ASSERT(!xenheap_bits); >>> +#ifndef CONFIG_AARCH32_V8R >>>       BUILD_BUG_ON(PADDR_BITS >= BITS_PER_LONG); >>> +#endif >> >> BUILD_BUG_ON() are used to indicate that the code would fall over the >> check pass. I can't find the justification for this change in the >> commit message. > > I had a look at the following commit which introduced this, but I > couldn't get the explaination for this. > > commit 88e3ed61642bb393458acc7a9bd2f96edc337190 > Author: Jan Beulich > Date:   Tue Sep 1 14:02:57 2015 +0200 > > @Jan :- Do you know why BUILD_BUG_ON() was introduced ? You've cut too much context - the next line explains this all by itself, I think:     xenheap_bits = min(flsl(mfn + 1) - 1 + PAGE_SHIFT, PADDR_BITS); Clearly addresses used for the Xen heap need to be representable in an unsigned long (which we assume to be the same size as void *). But I'm afraid there's further context missing for your question: Why would that construct be a problem in your case? Is it just that you'd need it to be > rather than the >= that's used presently? If so, why do you add an #ifdef rather than dealing with the (apparent) off-by-1? (I say "apparent" because I haven't checked whether the >= is really depended upon anywhere.) Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 30 07:14:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 07:14:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449734.706647 (Exim 4.92) (envelope-from ) id 1p0HI6-0005I9-NP; Wed, 30 Nov 2022 07:13:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449734.706647; Wed, 30 Nov 2022 07:13:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0HI6-0005I2-KR; Wed, 30 Nov 2022 07:13:58 +0000 Received: by outflank-mailman (input) for mailman id 449734; Wed, 30 Nov 2022 07:13:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0HI5-0005Hu-FP for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 07:13:57 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0605.outbound.protection.outlook.com [2a01:111:f400:fe0c::605]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8d81553e-707e-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 08:13:56 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8765.eurprd04.prod.outlook.com (2603:10a6:102:20c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Wed, 30 Nov 2022 07:13:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 07:13:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d81553e-707e-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GZpGl8cZDdLaSXCOH1zD6N/7kXH3tAn4YdkwVcbrjSII07L8/xcw5Jg+t7d4vhe2jBeX+ThBRIiRGYs+iuH3NVOCGFmTOgizxVBuLhsB+Lh0vX4LKc8spu9orQsH+uUhZ0JWzMw6eVc7MZZ30qlaTLaJzYSVPYgPkupv8YNNFvcLKh/ewNuqemfsV2nVZli7jW39WHp0co8zuH6WvkYzE530H3MOab6mt91LG7MRugbj5qJglGt0NEtQUOIpr0zCgWaipRfqySfbLLJiJckhCa/0MaKVS8mH4J+LdSNzKk+uscXVS5JXly0q+IPefyp3e7FtSttCHQFlNGTSDbu//A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nC8kG7822CvfUwgpiXQ97BriLBn2mJ5fFfA/1em2LJM=; b=n3H2FtVMtTIHNz4on9XzQ+kb1il5K89qBzl6JkCB+KAVEICsTUo/AX3yzQ5MXg4DzPmgc2+ibCX/bBDt1/kBshLngnKbDuCDPlYZXC5kOGdv03PjhFTcvwfjNwdOHgeVjJXj5OmOTK9QCHAaZG7ynOFRqWV0FQhchxlhhJIoijtYgrb7PFygWGDeXoOOpD2x/HPm7iZyfFUyvGDnzEtWQwSnERUOskEUStRuFgV6c8Di6X88FOCb3qVNmXUlCNGxbYNUTnJQ15UuI6QRlZf3Y/PVips0GS+faOXDhb3nIrA6Wwxbbuc3Vm73j+g6EhKFMq0lQt5eHhva6lb8Zi3SAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nC8kG7822CvfUwgpiXQ97BriLBn2mJ5fFfA/1em2LJM=; b=GZ/tZdAEWVUZLY2j5iFNupQyuvJpRo2YhxEO6ao66deTVIMS5ayGEtJj6YQuA1XZXTMiauJCwuOFDt+JvMyPMwSr9ETP0tbUNYp6z1+74THigi2sb6PnMf3ixnGHAqvErkMMkhCDS9OF2AvPCJX0uA/r0W7YweSFzu/+E+1+wn/6QTN6XemuJL654LWoaZYDx8tPpaM5N8fmOpXNcGLGbSylGI8CpapbhwMEjPRYkL8I5dCZpDcXkyKrzeoocfXH1roQPZuzhDATmzby6N9q7m8hceVX/JYuR2t+mIMbAw338YDNlFWUuLhL7/Xyuj4fUtFrFgS9BJwF36iL7FxJ/g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 30 Nov 2022 08:13:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] Arm64: make setup_virt_paging()'s pa_range_info[] static Content-Language: en-US To: Julien Grall Cc: Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , "xen-devel@lists.xenproject.org" References: <5a249b00-5467-1733-cab0-fd6d55765e20@suse.com> <4a93a89a-7d00-491d-766e-fd9a524d96c0@xen.org> From: Jan Beulich In-Reply-To: <4a93a89a-7d00-491d-766e-fd9a524d96c0@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8765:EE_ X-MS-Office365-Filtering-Correlation-Id: c8e8830b-2df2-47e9-cb78-08dad2a270ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7UoqNrQIdXUavk7xLBJP4xVois12tpbNtAi/b9h/6dDUpTCx4XoDWNmLAkRcjFvBc3D/WYAlK4+PaSBIvyiZQgaFE9G+Oi0I80u/jBCsX+QTCBPTI5pTEC1wYV6667ivm4jOjfWrbvbi+ab6/dLi5HnyPvjMi9DsnqvVpSxvzKizZrF4OvYBA5Bj3MY1c2tjgQgLvDf2fBgGZJGy81HeaEM7otfawwD8ZjVcFL/p6HzdaVIjozGNY4++0pDEiJhtavtwPLQUCEnjUZgttWBvQGI1b/MCk0FXhaStQoeWVUEcOMspdWdZymIblq8W/t9W/tsFP2VcXVwpt4sm6010gxnge9hLMAzJRxTO0HSGRXkHQ04xPkDzTtzZ8TjPZ7/xIQAvFk8hWP++52MwE7PYNG0rOBizFQm2ZbEtJbYRnrNN/T7wo07RtJdDKTlaIfZs5Ru+HQ3r+Ka/icAN9U7XNcDGuinP6564OeHsfw2lIf2PvqQJRJaOKGBwEgTfoyvxT+vPHgS/D7aHl7hQy3umtKkRs81O4fwfhlmnYkmcMSqYRdnUj1V9lm1UWVFBN/lzoo0JCiwLHkemnrLg2y3aRLbvQoszdsryYHzlPeIAv6Twzuaibc7ITt6rAYbAA18QIgMP8diFy4i7sL6RQ/G380a/rzMHYgSt5QyVbM8WEvnvgC7v1gMJH8CGmRvZvPvZMz2CFJOHCrUMrI28+EOlzNBn9cqgGfbKwgQ08C1/ps0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199015)(2616005)(31686004)(2906002)(6512007)(186003)(6506007)(38100700002)(8676002)(66946007)(478600001)(66476007)(41300700001)(6486002)(36756003)(53546011)(66556008)(26005)(8936002)(5660300002)(4326008)(86362001)(54906003)(6916009)(316002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3BFakJWSmN1emhKbnlkMG14WjhaUFhacEVRRElqV2dVUWFYdnBhbm9jTHl5?= =?utf-8?B?bkQ3MTUwRzFJbVplMzR3TDlaNkNlWWpybHBzK3hQLzBvYW5BWHVTMXpzVllB?= =?utf-8?B?N003cFFRTndmblNmYUNLU2M5L3lkVDczTnloZnZONlUwYW9leDhrL2l5MUZh?= =?utf-8?B?ZkE4K0FVN2I0a251OTlITE8vVzdzU3cwQ1QyUjJDVWM2ZFlVeVNrQzdkOUpj?= =?utf-8?B?RnFsRUVRckxoSG56WXB2b0h6cWlQemZNM2I2QjRDNlloVFFoY05SOVdKdUxE?= =?utf-8?B?bUtqUlY0cjJTVXg2ZW5VMlVnUXhYMlExd21ld2l2eGJCNUtLczl4RVNOeUt4?= =?utf-8?B?MWxNOVVLNExZdUlsK3ZPMmhxL0Z6dlZLMmhsbDBVOE9YRXVMTlRYbDZBT01o?= =?utf-8?B?NzRtVzh2SUZRaXkxWHc4eEdRZElpM0psWnJGMjFJcjF4RUNLbFpCV2ZSVWZw?= =?utf-8?B?aG80QksyU0lYVmpMUHI2dmg4SHcyK2pjNWNSS1ZDRnpqOXZJYjExUjgycjJZ?= =?utf-8?B?eFM4dnc4ak96eW9ROGs5alN1TStPYmJLSU5JdjlQdTd6WUx2V000R1pJak53?= =?utf-8?B?Q0JkMDVMOUVGUGRucHo4Y0xadThPQU1qSkxQYitqTnlET0k2TVV4ZkQzc25i?= =?utf-8?B?Z1lXam02QlR4NmY5cWRGNDBMZWRqdkV4OW1WT3NiNi9jN3p1eU0rc3pKWGpP?= =?utf-8?B?M25xaE15am5rdXptYjZhSWZPdWRsOVBLVzlTMVJvbFp1MWxGV2thTG1HNHZw?= =?utf-8?B?U0hYa0hzTUptZE4zaFNqNU0ycWxDeVRqVDhVdlB4VytsRlhqSmYzVDNuSGZm?= =?utf-8?B?VnZoM1hJNWIyeitpMW9mbmRFeWFHOUpGTTFFZW51cU1iMGJGSGZyWi9mRk9z?= =?utf-8?B?anlOcStLMFFpYXd1QTZFVjRYVWJmL3BONUhDVFI4YmxkWVE2WmJuWlhIWEgw?= =?utf-8?B?dWZYT0xWWDVMbCswS3R0ck1LNkRNK3dydGkzMFBqVGhPank4bjBabEl1WE82?= =?utf-8?B?Qk8wMGRORjJmY2xkRUtuZ1BlSHlsQlpDc2YwWjBSSlE2L096OWJFWVVCZlY3?= =?utf-8?B?Tm5lOUl5Zk51VVk4VVBtL2hLaFlSSTRFQ3dxcW9QSjVsVDUyemxuSklFaTlJ?= =?utf-8?B?YmErVThIRTJiN254STBUTytGaW5tYndvVjJMeGVCMlpWNU0wNDJSUjdTdHRR?= =?utf-8?B?YVRCT2pKVlJORnEyL1h1Q0dDdnVYRWtFamtCOFd2WXovZkQ2THltVWw2ZVZj?= =?utf-8?B?QnN2WWUvQW5LQzRiZHVvUjRySDFUU3BLc1A3b3gyeE90QUh2dW9GL1BpVUp1?= =?utf-8?B?RkUwTXQ3UllvZE5rVDBVYTIrNUtIcEcwamJKYThtc3hsb2E3bmRHTjJEay9p?= =?utf-8?B?NFBCQWVMK3NUdkVENm5QWjFCdU9ycEREMWUzdk1tb3pCWXJQRXk5WjVmNENu?= =?utf-8?B?eThGY2t0bXRrWVJRU2p1MU1nOW9LNkd1SjFPcWtZTzhqSkpCekpnOU1kS0Rp?= =?utf-8?B?RW53MkExSlB0Sm9qL0lvcHZ1cmRFeFNPRDl0bzcwVk4xdDZ2UUtoZEJMSDh0?= =?utf-8?B?aUxMc0s2b1N0YVdxT2hta3RFVVhnN0N3d2NrOGJNbC9kZFBJeC9wck9NLytn?= =?utf-8?B?S25YLzliQ2lqekF2RFhWVlVSVzNHYnhNbC81aTNjLzBFV1V1UzdNYklmbFJT?= =?utf-8?B?ZTdFS2RPSkZic3J5MHN6a1VOa29TYzNhSWk4WVNjcFRoK0NNNmRLMXhGZGtw?= =?utf-8?B?RGRSYXZtWjdtb0htNEUwWVVwWHJjM2VNSlZEYmpveE9vMmNoa2c2NkZlNUlQ?= =?utf-8?B?Ni91VVBGcFpTZ3BhSCtsK1A3Vjk2bWlTMHI5alhlRFp1QlRuNTBrajlaZTBH?= =?utf-8?B?UmMwV3FvZXJ0cVJucEYzbWhCT05mMkd2cHRlaEljL2c3T0h0TnVBdlBVaGRi?= =?utf-8?B?Q2hkUkNadStWM2JQSXI4NGZsUFZUNXlPL090a0ExcytzcW0vYy9yUnVibmx6?= =?utf-8?B?bDFTT2gzSGdTRmNGV29Yc2k2akhaeE9iYlJrWjNnckZRdUdJYmUreGxnR0JD?= =?utf-8?B?T3pJMXRhcXdUOWdaTGFlTGNWdTk1dU9RdzFQdzY4NUx6b2hLcmZUWko2bElp?= =?utf-8?Q?QgQNRMDYV6f7wQlZ17vhL89h2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8e8830b-2df2-47e9-cb78-08dad2a270ae X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 07:13:54.5259 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W/xM1wZj1/nqPOYYO+q5U6RxFocMw378TBsMDBQPyATENTEXwf7fUIy+rNoO/gkFgD4wg5PYbM2dqu0JAiZKmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8765 On 29.11.2022 17:01, Julien Grall wrote: > On 29/11/2022 15:39, Jan Beulich wrote: >> While not as inefficient as it would be on x86 (due to suitable constant >> loading and register pair storing instructions being available to fill >> some of the fields), having the compiler construct an array of constants >> on the stack still looks odd to me. > > The function is only called once at boot. So this seems more a > micro-optimization than anything else. Well, yes - hence the "looks odd" as a justification, not performance or anything. >> Signed-off-by: Jan Beulich > > Acked-by: Julien Grall Thanks. >> --- >> Actual space savings could be had if further converting the field types >> to e.g. unsigned char (all of the values fit in that type). > > This is a micro-optimization. If you want to send it then I will review it. I probably won't bother; I've pointed this out largely in case actual space savings would be made a requirement to accept this change. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 30 07:25:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 07:25:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449741.706658 (Exim 4.92) (envelope-from ) id 1p0HTL-0006xl-P1; Wed, 30 Nov 2022 07:25:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449741.706658; Wed, 30 Nov 2022 07:25:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0HTL-0006xe-MO; Wed, 30 Nov 2022 07:25:35 +0000 Received: by outflank-mailman (input) for mailman id 449741; Wed, 30 Nov 2022 07:25:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0HTK-0006xY-Oy for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 07:25:34 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20624.outbound.protection.outlook.com [2a01:111:f400:7d00::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2cb1369e-7080-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 08:25:33 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7067.eurprd04.prod.outlook.com (2603:10a6:10:12a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Wed, 30 Nov 2022 07:25:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 07:25:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2cb1369e-7080-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ke1AO1CO3Sq/PGZbdGg/a7YPnFUsqEXTRZr1+D7NsXjNUgcI35f/KcbSSKt83cfSh3F4Mkm59qU133pU5/jET1A1Pse3p2PT1xTewM/Pltxl5bR3T70cpW6cQQ+9qNTSScaBb7SJs9lcLWXbO2Rhgv3+Wq0XvcakKBZpvy2Rnp6jbXt9XsjvSJzBoxwDhTKz384URNZFSeg45QKXXs/4tbWfzi8B8NTQDHh67/MbND3l2fhrptrmPC9ePvNZZIa00CQlihxfCUuJjBze09DXjNv7zGK99+znYXPz1nyYH1k139QuzcAIvGLhsQXFhRTQnuV+6jh5l2HgtO4oMtBXqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dJ9PrBSkrW2ppIwtgQz1wrj1/Q0AikNZTBIKhY0dmNQ=; b=iVlOJu5dz+2GFQWLjmSTThvIYGm6k3QFTuQPPFKJO8hKfrIh9LtMr8c5AjnVvX9c62SsRYh7KRKaNAR+35poNA9s7bPpv8t68fvAuLfvKGB5JKhLbQULFcdKg97pOtuM1XXIJFGgtURJvtqpP+GzGNLhGGXtCbkzBo7i5rtQGU7+uWa7TaphNS81fefWnQi2nuzGaMZQpU0SFReTSQUtr0HaJTd8c007Px/4VQrlNCQupasJYXQw1drU+8uarF2bTibAqEchUFQ2cBG/a4UBKSL4Cb91axCFxM3Fxfe7cDHPRTOt37Sw4Y5M9EprwnAJRiGmnQWvj+H/sS17bPbCBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dJ9PrBSkrW2ppIwtgQz1wrj1/Q0AikNZTBIKhY0dmNQ=; b=HALlrnnNAtdmSSEHnQyyzwd4iAfLK77CznNJn8HX9Mu0baw4LB2zlwhQXUPvCdZNLJD1ZJRC1lHxis2S+l4vYYDplQZvCZGrLEL8YOMjJ1yPPcUgIKdcwJQmNBXnXLscYp98Qv3+Bp4o/SAwsqhYXbjAvVFBjAlrRERv1LqH0L4htHiNvUtrt6qJmPZwA9imNs4wfHVI8ZD+JeGOmb7tQtOK5Rw6sxX6hoWC7aiFRnaRPWiVQfoa5u1G3wfbLRsAHB4ubN9C308Y5IpOYCXpMJR1kbYZclQNmwDBcFSLSQS0t6cPcRy2h8AZYL+fMSrAjFexoqEWFmXlHuHV6sGUKQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 30 Nov 2022 08:25:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/p2m: don't calculate page owner twice in p2m_add_page() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , George Dunlap References: <3876e026-2a98-b74e-2f49-4bed8fc0a224@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0124.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7067:EE_ X-MS-Office365-Filtering-Correlation-Id: b2bebbcb-55f9-4f1d-75e3-08dad2a40f1f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6/ls7qPKLPImIUu2hMDy3E01uXakA5PKdwE7wpUHGxkRz2pe90WV4tUt5UJqnSUYUbkAlCo2sb4RiGw/C8r7tlN5Qh1QNJwyB8gq3LULILJ2dHBDmrZ67CCV4LUeylGy11KrbXg1IMStcY+jbos4OLO/OLR+/Z9xKFp3MDqkeL3VglomKpN21MKvfLbT8nbVueuUtnT4flLXe85xtiXrSTvJbdtG2I7o19KujdyvdgcQtNdl4awT2x1j3wY/BV067hk3mrT02C8AI3DEP3uGz45MoxnGnGoDyEU5catO52UvDt9ihsHl7jmr6KjOEQ5htjcDuZUHYVwHuZAUumnz6XUzqk4v1tSKNL8v/JLOJ71dFvw2YNTGEcxErqOi7lIX5yz5SbMQLIXyfpxroaNLm6ix8BMxLwPGs02J4Iqx5JVoIg2slLvvxa2Hv53Rn0ptywWAATKDIAhxwl3pkknujfHwwrEXYnt1hza+mGgkVAzkiOhk+huXkJj5XYMdGAFI3WtYjsGS+FdL7Gtl3gkhzSdHweQAklGQmiDP7wCL6BUoNH63hXA9CSP4xOhchqwQXWVUmuRHFfRLFG6vt8N3afJPBT0Yr91JSqbOoXBPiYR/ta4AincGp4LMT+gDP5IKijloVuJ6OQdRWWIwgkhUjthNRYk63+xIyeS+sQ5kU4mBB9DokT8XboqzLn+bAI2USKrRmc12DONrHmMr/TGqFF8bQ0iRSSdDANI31c1fPpc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(376002)(346002)(366004)(396003)(451199015)(36756003)(8936002)(41300700001)(53546011)(2616005)(66946007)(478600001)(66476007)(6486002)(316002)(4326008)(26005)(8676002)(31696002)(6506007)(86362001)(6512007)(31686004)(2906002)(66556008)(186003)(5660300002)(83380400001)(6916009)(54906003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R28rTjNOcExCbjBSb1lHbmpqV3V0L2g1a0dJNUFodnk5Q2xva0JSMWNUOVNU?= =?utf-8?B?Q3lTZTlzOEZnSk52U0hKZFdyazcvQ3dUellaZnlSNm1ObmUxVE5iOGU4bTN5?= =?utf-8?B?M0hRdHlGN21xQ1dUR0hxMFFib2dDSUU1TVB1YW1MdXBFdldCTGtzQUFTVHJ0?= =?utf-8?B?b2ZTb0g1VVJ5RjZiQ1VUK0lmZzdycG1BSEFQUXlWenVKY0RsVEF4MUNmN1Zn?= =?utf-8?B?TGJJZXN0dnJ5TFRudVhtTnRsMko1Ymk3RWNmbm4wQUdCTTBLNURvWTZBa2oz?= =?utf-8?B?WU1pMkxweFZEbVVBLzdHQmZyVGlNM2J5Tkl6L3hvbTdsKzROODZDbkpqc0Z1?= =?utf-8?B?QzNDNTFvSWxZYytGZEtzYnl2QjBNVk53dTVjUWpuWlNrbklBT0Z6eVg5SUVW?= =?utf-8?B?dUhyZkhhTTZibmNwTzlNRERjVnE3VXl0bDI1ZkhmcEUzdFlNTkZLT3oxcWgw?= =?utf-8?B?NG5qUVpOVXhGMWZHVWNCWlRrM2RkMXBiRW5mdzBVOXVqUkpMQnBNVnVrLytD?= =?utf-8?B?dFpzczVKZGpjOG41MDBTekg3TnMxVEd2QlZwb1Q0YVBBRkh5MFFSa1VEdzNm?= =?utf-8?B?azRJaGpsRG56N3hiUEhhaitzMkhZUEdza2ZnMTU0cW9mNk5haXVpcUI5YXcv?= =?utf-8?B?N1VoVElXaDVSZDBOR0phNUFsaFBvcGRWZTZ2SjF3ZjdJc3BxNFJlWTlpQW5Z?= =?utf-8?B?Sy9iM3VsZU10SDdPWW40WVR1WHkrR3VlZGVmaFJTMkdUN2EvOXdjQ1d2cDVj?= =?utf-8?B?VUs3cFZHMXlHbkdKUDhPMk1wSEp2bUE0UlEwSWFoOFRKbWkxRDV6NEZHVld0?= =?utf-8?B?K29WcmJweHVwcTBOUHI3VC80aVY2OEJZSzRUNTMwdDJGd1N4S21jWE5qRWFk?= =?utf-8?B?b3JZUm9CR0QyZjRPWW5vd0dYMnVvZE5xL2pXSXlhNGJ3bXo0QWxOUDlXT0tu?= =?utf-8?B?akZRZzFRZkVqTVYrMzEwdTRXcEZYVE81NnBLK25tR205ejVVeGVPYm10eDYx?= =?utf-8?B?b3FCWi9HVU5vWDZBTEhkQVV6YVN6NEpJTUFrV1ZwaURZaE5NZCsxUTVDTjB3?= =?utf-8?B?Ymtra3IrRnI0OENWSCsvOVBqckxhSE1BSk9qUVhzS3dIU05odkp5eEpUaWhU?= =?utf-8?B?YVlvNTJBTkVEdTk1SHFmZk93SXpXWWF3QlNqQWVUaVhOTXEwWDhLcHpnbm9Z?= =?utf-8?B?Vm1lN3ppb3lTd09mNi9LOVlnUjdjVHpWRU1RbW5Wb29JbmROR3AreUNZMy9o?= =?utf-8?B?MVdPNFltd3FwQmhnbHlUcW1pcE0xK1VJU2dRTm5PQUNWYzRONC9sc25VY2tX?= =?utf-8?B?TnltZWc1OExXbjUybEdrdFJuSlR5dHRvOEM0NFhJT2puVWwwSDhrcHdCN0k2?= =?utf-8?B?Z0xScXpOQmhiUnNLVTBnQ1Z2L1BCRG80TVd2OWRSUi9vM2hhUmlqTEpDaE5j?= =?utf-8?B?SzRMSDV1bzV2V3FETmRIeEkybU5UQ04yYktLOU5tZmMyZnJHNk93UVlTNnZO?= =?utf-8?B?OHFXTVJJb3VYbFhuZGpPalk0S0M4dTUrZGJTbGlXaTA3NkhJSS9kNmNVYllx?= =?utf-8?B?U2NlUU1rcGVXMzhtdGgya2JONlBjZDROV0ZUR1hSWDhIelRDOVVaUXhiZUQz?= =?utf-8?B?cHduK1lQQ1U2VmhyRkNCNW1UZWFEOHhTLzFOdzNmRjF3YjNqYTl3d1FiUExS?= =?utf-8?B?QXk1S3pjSnI4bk00aWF0UXRpRzBHMytQQWNpN00vVkYzc2ZXbnFoS0hMM0Nu?= =?utf-8?B?MnYzclFQMVlXQkxIR0lzNkc4ZlcvZXY0SzVQVjM4QUNKejBxWTdTVXI4QTZJ?= =?utf-8?B?NHczY01ETnl2aDRoV2RvRGVvWlVUVHU0K1kyOStpMzA0R1RPSlZjVTdDa3pC?= =?utf-8?B?YzV1Q3BZVUtkN0J0bFdORUNURGFPYnM0eWZBOU14dFlhdG1LSXRFQ2x6eEF2?= =?utf-8?B?eng0eXR1NDExbjRNOFZDQ1Y3Z2JsSVZHRGROR3ZPMWM3SHk1YkdBdDg4NXZJ?= =?utf-8?B?Q2lseEt4Zng2RWQ5UFFZZXRWeFFzTnZMeHVPeXRybnlmUWRDSTF5SkM3WnJm?= =?utf-8?B?dDNFSXRZR0paSGJLdWVoOXg5VkRQWkJSYlpiRVJaYW5ydkgrZ1lTRjFvOFBG?= =?utf-8?Q?ywGV6wh2sIVSg612QgW/LXiXX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2bebbcb-55f9-4f1d-75e3-08dad2a40f1f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 07:25:29.8254 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xbEFUcZdx+SZ/lwLrBkes0Wum7vhetP3wI5WDuHJPaxPxTKRY3ZhbtjM8bQZ5nbKHOPM1+kCI/8H1ig7i5kYYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7067 On 29.11.2022 17:44, Roger Pau Monné wrote: > On Tue, Nov 29, 2022 at 03:47:53PM +0100, Jan Beulich wrote: >> Neither page_get_owner() nor mfn_to_page() are entirely trivial >> operations - don't do the same thing twice in close succession. Instead >> help CSE (when MEM_SHARING=y) by introducing a local variable holding >> the page owner. >> >> Signed-off-by: Jan Beulich > > Acked-by: Roger Pau Monné Thanks. >> --- >> According to my observations gcc12 manages to CSE mfn_to_page() but not >> (all of) page_get_owner(). The overall savings there are, partly due to >> knock-on effects, 64 bytes of code. >> >> While looking there, "mfn_eq(omfn, mfn_add(mfn, i))" near the end of the >> same loop caught my eye: Is that really correct? Shouldn't we fail the >> operation if the MFN which "ogfn" was derived from doesn't match the MFN >> "ogfn" maps to? > > Getting into that state possibly means something has gone wrong if we > have rules out grants and foreign maps? > > So it should be: > > if ( !mfn_eq(omfn, mfn_add(mfn, i)) ) > { > /* Something has gone wrong, ASSERT_UNREACHABLE()? */ > goto out; > } > rc = p2m_remove_entry(p2m, ogfn, omfn, 0) > if ( rc ) > goto out; > > but maybe I'm missing the point of the check there, Hence my question, rather than making a patch right away. I was hoping that maybe someone might see or recall why such a check would have been put there. I'm not certain enough to put ASSERT_UNREACHABLE() there, though. I might make it a one-time warning instead. > I have to admit I > sometimes find the p2m code difficult to follow. You're not the only one. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 30 07:39:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 07:39:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449748.706670 (Exim 4.92) (envelope-from ) id 1p0Hgm-0000E7-1z; Wed, 30 Nov 2022 07:39:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449748.706670; Wed, 30 Nov 2022 07:39:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Hgl-0000Dz-VE; Wed, 30 Nov 2022 07:39:27 +0000 Received: by outflank-mailman (input) for mailman id 449748; Wed, 30 Nov 2022 07:39:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Hgk-0000Dt-Ny for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 07:39:26 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on060a.outbound.protection.outlook.com [2a01:111:f400:fe0c::60a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d0e8f90-7082-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 08:39:25 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6782.eurprd04.prod.outlook.com (2603:10a6:803:139::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Wed, 30 Nov 2022 07:39:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 07:39:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d0e8f90-7082-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bDgnuEn8WwwnKFMQjf7zNSX6ccaz6Z1PSP7j/WcUdwvFXRYHE/QO+W1S4dZwLYg2+lmpSSz6G3p2ARvcItIcGeEqZWRHpvGmyakJS+a4lWLcgaug5WDksKPT0235rsf4tnD6vfV2hx7JA+Em0xFizaenBnL9K6wUOXZBmrdMkc6FWI36OsZtgU8Om06qQuCDT/7JvASwxEWQkdfiUteauT+YajZj/SekMcOv7jWb+A6Mgs1tFNb8slF67PVEh1tfVWoCH4LDJ28XEnm+4IYG67DZcdKgd1gwijFkdl8mVuZb9pmxzasPeHRYf+VWlN6JFODMDUXsBHW1O8mII9VkMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O/iYO3t+Q/vFu0QfApUI8gLnIPZc/JYavzXO2OLqJlY=; b=VzsEVg13pju5uFGw/U73enNg7uSSJad14boejVXAwHmqMKbw9wymXUM1f/wU1PUFX2FtJvYLhDrs+g8bUrOXr42TAfQ/QutgCWhtrR8Z1bj3yu7s+/YCBz60Mwn2ecajKOW/CXmav/2gp9SbRkliGIP3VHywOlErUPjC/xgdEH8RzKAe4Xisl4ASOySEZJ3zGhXdtOLrw3nEkP5LKU6mHYvReSu9OZmwadX+dyR/cwWVrisREmpyRMu/VgEcEoWxTmii5Sfb9vyNixnv4lw4B+d/ScS0pknFznXmzUndTYcP/CyRvMVOShw02bSot8kt2ARxGDllJpm1IPTMpz6cuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O/iYO3t+Q/vFu0QfApUI8gLnIPZc/JYavzXO2OLqJlY=; b=iZFeTU0dKHiSEtAyL0HpogUrl91SSMBbEwM4QZKlFSx7LWhvnk+ChP+jkWEjKiYgBywziGK0qgUju4S27hHFnmSI1qx5F0+sjjG8rnbx/y5tw6XHRQCbu8yknm7ZMijLT72tJnJP4LTErzjzXTmq606T5wDeAWoqv3CVXpaJ7hSyJVDnHjCOSfFlR2pbICCtBqmEXQepS6GIGSyQ7jb8HD7tUszkcMAxfcyJFxu90Yj3+5mV288TU9WpC/u3uaunIRdS48juAYoyvqCEJBcId8UV9kAsBP8JGAnozN1DbYqy+0/t55MEl0fL07VxjwnnOdbdpcpriJZTjwvbAIJFdw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 30 Nov 2022 08:39:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/HVM: drop stale check from hvm_load_cpu_msrs() Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <48ace255-8b9f-84e0-cdbe-00c4fba309bd@citrix.com> From: Jan Beulich In-Reply-To: <48ace255-8b9f-84e0-cdbe-00c4fba309bd@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0084.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6782:EE_ X-MS-Office365-Filtering-Correlation-Id: ff467525-cf5e-4188-f631-08dad2a60001 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mZR9EF5XDw2IytNMVDU75u/mGAnjpHpXW0zD4ZDA27n5HnzZtTtzJiwtXNMTTlhBDB2kV13kaEk3B7y9gz6y4KZi+bZbD6+fI01OQ0OBHvVw/fs7LrYPI5Wu+G26sqEes5lDY98UtvGgPF1UHyCtMk6+DO0XhQ+6yvzni03iEinN+9Chv0jnJhyzBQnAkxR3hzplAn8xrwLZKS6RL/o3HdEUhHOe8CFY6RHb5VlfVUVb5mHHML1UFigHtjL2vaUB4EQl83rG9+4De1kofGzwMJvORGtgg2XZJuqGnIYceu8Rt7ntJ7jrHU3HkI/GYMQdctMLJ5jHUsuhs1mqXTXWAtp2cBjd62hD5DhgM2WZPJYzJVLcOWs8CE894TWmstO+tLj3ftCHxOXMkEh2lR7oNdxaEPXbA/1DNAwh8ULiI/obtGZhwXo2kUFXRk1yxGY0Rj5CShcn7OMYKh7xKIsOhX2VN5xNEoyScWbssf+T4s3hqA8hjEeFRmVWjSgAi6ElR4XKCS7aQM79fymcckzHit6Q78IF7funnpzhcvdNEU8jcY3A60FXLL3N6oMgMr59XdS5oQGgZWLV5QqEoJfz8nc2u8i8vMPEDZ0J7SIKawpgBG625WQbLJp/1zKTeV0vS4gypag+/VitgVGQQNBggF/r4pLTPRpk/hV19R0QUDVlHJkSOpP/j23D5lOMtDdhAB+DFLil6vr7ACzltT8Z78+30gsTpdu5PauJBPH828c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(346002)(396003)(366004)(136003)(451199015)(31686004)(316002)(8676002)(36756003)(4326008)(83380400001)(66556008)(66476007)(66946007)(2616005)(86362001)(31696002)(54906003)(6916009)(186003)(8936002)(5660300002)(2906002)(41300700001)(38100700002)(6486002)(478600001)(53546011)(6512007)(26005)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1B2QWRZRTYvK093WUdobCtnSmxIOXFQMitZZmlyUG5aNWJnQWNDMmc4Vldn?= =?utf-8?B?SERCWnk1K3hHbzBNanoxWlgyaUtMT0dYOSt6N0gxZmNqcWlodC9kZ1FMTGNE?= =?utf-8?B?V0pZelRObkovTEVmaGNISS9WaDh5VkdjWUZNUVFTQ2dQMnl6ZElGdXhUdFRW?= =?utf-8?B?MzBxc2ZsRjFvaHY5YVJXMklZMEhNdXNiYk41WExVUkZXanJpZW5xTzVIR01T?= =?utf-8?B?Qi9NaVRVMTQyN0xFQ3BGejlIbjRaVy92Z1NCZDNLaEVocWVMN09BR2xZM1FV?= =?utf-8?B?endCeFNCMjUwSnJLUXBBUVBTemU1YzI3WXU3SW1pTU0rN0hvd3dFMWRqaFV5?= =?utf-8?B?V1oya011SUt6dktGOWVVaVN2YlZRQUJXNmpXMTBDcEdXQTd4OHA3ek9ES1Q0?= =?utf-8?B?NGRVNjl6U0FWOGdyc1U3YmZlV2pnVXFSR1ZHVzlySXE0bmcrZm04azdHQkpy?= =?utf-8?B?REJYQmNaa09XTE0vYUxaU2c0anB6STlHN2JEQUg1amsyWVNteDljdGlieEpt?= =?utf-8?B?b3pzTkorS0o5alplWnQvekh2R2ZTWkRMc0RFRk9jUTErMW1heWRGZ0tZRkww?= =?utf-8?B?aUhqRFNHNDNrVjNIc2dCZkllVWhmUnpDQlpFY3lVdFluT0lxUFVyU2EzTnZo?= =?utf-8?B?VmQvaGZzYTYxeW5uTzd3d2dldWlsT2xJM21RblM3cjNLcEVCa3Baa0FnUlJw?= =?utf-8?B?N1dQb2JIczVYZ0h3R3ZQcGhON0ZWTXFTMVEzckxlRW95ZEtGaWFnd01FVHlF?= =?utf-8?B?UDhuWDRGNVVuM2o4RVJpczZaSDJvTTVKQVI2SDlkUGMwejJNTEhEVHBuSzM0?= =?utf-8?B?YWgrTE9QVFV0MVJ5S3Q4d25tWnpYYldQcms0Q2xHa2V5Z0M3SVdiYkZKdmEy?= =?utf-8?B?bmZzZEhsMHlBdlF0UXlvWmFLbFk1YXBLZ2c5WkVDVDhrSjIvU0J4UWFwMWNi?= =?utf-8?B?QTc0b2FLMGpnc2ZDZ09YU1l6aU4vY1hieVlXZm92N2oxai9rOXNQV2taSnJH?= =?utf-8?B?ZENULzdRYTZ5ZUF3RHloVE1TOFhwaWhhN0hTZWYvaXRMSTZhb2t1alA2cVBD?= =?utf-8?B?ZHErWTJqUXJjNWxCYXRXeXB3UEVwbzVYL0VBQ2pFeHUxNlBKREYxOUVKYmN4?= =?utf-8?B?S3ZVVU56bnRpR2xhT05xWFZaRHVOUkhvek5iYmFKaW1DTVBUVjJXZlhkNnI3?= =?utf-8?B?STNmVThiZFpIUGxNb1ZaQTd6Q0t4NExFQkczdXcybVpCbWhtR01OY0NTV1l3?= =?utf-8?B?b1AzM2EyaStOVkZWSCtJZjBScnlkWWdOSzM0UjE1Sm9HL0cwb25DTFNiNkNt?= =?utf-8?B?RXlSNDQwMGpXMXQ3RkdKN3RXNzI1RFRDNGR0MXNTRTB0SEViZ3VIREFLRmpl?= =?utf-8?B?NVA2cGVwdmxCNHlmdEJsU2h2SFdnaW1DblhjQ0xlb3JROHFYK1VQZmFlZEpX?= =?utf-8?B?aTB0UVQxQW9yWitoMXdub1B2dVF5R2Ztekh1NVdnSWlLeE5BRWwydkl5T2wz?= =?utf-8?B?Y2tnQnQ0RzZ0N29rREIyZFpNSzRLQVhxbFJKaHoxRUpGb2NiQktJbDVOWnRT?= =?utf-8?B?SjVrQVVaemlabWR2UlZSNjQ0QzlNMUN4NlVTOXBvZ096Yjc3Y1JvK0FZUjMy?= =?utf-8?B?ZlZ3M1N0RGNNb0hKVmxMMmliY2xzaStSb1Q2cFluNlYvcDNJWFNocGlBT0du?= =?utf-8?B?djlFWHFNbXRHRVJheitlMENoU3Z6U3VSUEM5bFBiZ2NZbk5LN0JWR2VJUVpn?= =?utf-8?B?SEJoZWpha3BydldVcXNXV2RoLzZOUytnN2c5QTVhNHNPanlod0dpcVI5cUV6?= =?utf-8?B?dUwzQW9ZS1dxU1pCaVNFUEFtNEM2bkc2OXlPMlJaRUNEcHNGNnIrTVcya2RZ?= =?utf-8?B?SmR4UmFQZXkwd0tFcHJpNGM0YUhQc1g5SE1xT2JmcUdRdjFCUXFhdnlqSFhj?= =?utf-8?B?UTYyUU5JcUN1OVFWSjFaM3luS0IxS0ZEK0xWNWx1blRCbWlPQncrRlo3cjYr?= =?utf-8?B?NE5xcTBCNWFkWW95bTJDb054VXJIUlJ1dkljNEQvUit5dUxmSjB6WFlaYkpZ?= =?utf-8?B?MjlIeE85a2p2cnFHSDNsR3NJcmdwQ05VVEN0dlIwM1I2WDdqbFRrTyttb1Jm?= =?utf-8?Q?Nusq/QvbAc4pXhdTObweKcRBg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff467525-cf5e-4188-f631-08dad2a60001 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 07:39:23.4285 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oyc11uoEH39XVXqWMmY+rysEt8xjdF8Nhn4ulfnG6sExeQOi8Rvm3lU4LGw8gI9z91J+SGv905Xjsz7WEsh9qQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6782 On 29.11.2022 21:36, Andrew Cooper wrote: > On 29/11/2022 14:51, Jan Beulich wrote: >> Up until f61685a66903 ("x86: remove defunct init/load/save_msr() >> hvm_funcs") the check of the _rsvd field served as an error check for >> the earlier hvm_funcs.save_msr() invocation. With that invocation gone >> the check makes no sense anymore. While dropping it also merge the two >> paths setting "err" to -ENXIO. >> >> Signed-off-by: Jan Beulich >> --- >> We could go further here, removing the local "err" variable altogether, >> by using "return -ENXIO". Thoughts. > > 'err' is a non-standard variable name, so yeah, why not. Okay, I'll make a v2 for this. > That said, the current code has a split loop checking the incoming _rsvd > fields in a first pass, and then calling guest_wrmsr() on the second > pass.  This was also made pointless by the identified changeset, so the > two loops ought to be merged. Not really, no - it would violate the "Checking finished" comment (but of course we could also delete that one), but I'd also prefer to keep checking for all errors we can check for early _before_ starting to make any changes to the guest. Therefore if you really wanted that, I guess you'd need to make a follow-on change yourself, with a convincing justification (I wouldn't outright object to such a change, but I probably also wouldn't ack it, leaving that to someone else). Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 30 07:52:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 07:52:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449753.706680 (Exim 4.92) (envelope-from ) id 1p0Ht2-0002pG-4z; Wed, 30 Nov 2022 07:52:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449753.706680; Wed, 30 Nov 2022 07:52:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Ht2-0002p9-2L; Wed, 30 Nov 2022 07:52:08 +0000 Received: by outflank-mailman (input) for mailman id 449753; Wed, 30 Nov 2022 07:52:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Ht0-0002p3-IL for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 07:52:06 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20601.outbound.protection.outlook.com [2a01:111:f400:7d00::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e19e218b-7083-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 08:52:05 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7621.eurprd04.prod.outlook.com (2603:10a6:20b:299::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 30 Nov 2022 07:52:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 07:52:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e19e218b-7083-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TfOSLqzt4SWYpmZvOPaM+jItZHVdmI7E/WJdzRaGmssF/wXxQW52hHzxk+DLWN56x7LMwVNtIg7l8kn7BGDc2T8HHe9hOS5rM/lyK9CrsgnvrF9IqVFVlHNMKUHy3juqwcCsJxdqxLWTWzwXayCZPad4F45JY9HfNR7hKUGXVzorrUoefwlWl/NT5G+75MNzHPEzK5wv/XNB9slykxJ5Q11aVwNGQB7pCvZcQGtadTSGLfEw3dbHmJKje8hWP7LOR1O7+6noiwnVXFEoi9MTHQL+C/EM3G5VMhHpjjP3w7YjOWCmHXs0at0l+3giSHwYoanCem1mJDh7n/I4soQyKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BWkEif/iI22c/TAUGZodiUuNY9qaYUJEnQ/zVbZeWnI=; b=kFudLWNS2Uy6u2/wEAEUHgeP+diUhxJwGhWLdQkP+/FWE5nB2+LSOv3B04qALTqIFZfJd4c+Q2+D6YEhPlp2Vu/DdbAWcXYXRRBAmy3WUpYexMVKk9oDV0J8BPviBQ4VerTvBhOV8pbISsKufxxJFyqL2hcmuzxG2vf5hFdyC0Pg2p4t2aDN05gIbRdLJaAngh5VebFwimeMwgIi4F0lWMv0wKhylTmiPN4WPFK+A7DIaNopxGFnjQlNkllvBkdM2wqIAlUMr1tLAOltShM5r8JMSmb/DwnaCWWmlsN9ZKHZU5semx9xgSyFHuGfMAqXSBTlwK+edsrtyfvHkrKMmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BWkEif/iI22c/TAUGZodiUuNY9qaYUJEnQ/zVbZeWnI=; b=AbFjBUVyyvwqpPmTGzo9I5nPBi7n9oMJhDtoxyX/FG2dHWFst//8QtVvHg3yg2/gcGwzLM5wbE+IhtgP2RZvqPUy7RV6nC1bxynIRkKm4lhhnx68SRAveEZ/wE2GIoCRlmgjaRPNzeIUMF7lKYrRgUi4hq84YwZUDEGdWy2cZCyAGzNlp8i68OmCo2djoy6RsiVmosV5EdMUitjh2G+OKwULBnz3EG+IQ8dlM1amErqn7kzLrAW1fLv/XC6kl2U0SOB40O0RgDg0Z3Dvln5GJOUWv8ckclGMeZLQOCWhOHuePsd9yDmyVE6Go0HEcF4kMh+Iu4pfReFrt4v9FuLYBg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <96f6a943-0e1e-7399-fe83-56a550d47bf6@suse.com> Date: Wed, 30 Nov 2022 08:52:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/mm: PGC_page_table is used by shadow code only Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <4fef5b0c-4463-cd6f-15fc-47268505517b@citrix.com> From: Jan Beulich In-Reply-To: <4fef5b0c-4463-cd6f-15fc-47268505517b@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0038.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7621:EE_ X-MS-Office365-Filtering-Correlation-Id: af9afe3a-85e6-4ce1-458c-08dad2a7c4c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YMqFMIrrLU2lKCq9PCpJvc1ocanWNd1rXbko14vhBltdPNLI+jDCPsk2NLCNuf4+t5mEsySkDGHYtXtiOyJ7GBXK63soOjQfMNmT4E0QcQZGoy7Ad9zpoTx3BjQdWIEWw41uzvRj8SYeQNYzsGlTJ48WmuJtdX8gYdMwvNF+TkLnUn9FCKY6yBT86BgguRCNyUOxqrIMzGyBqKX4tTSgIebQEHQi3W0f67AhIrHJ+hQR3oycUakBi13AubAFMyVm7DAelD+XVIlcYa5IgvSrWTjgwLGqgqvEx3X/bJMH/qc7+RdDKWjw+Ft0GPtu2H3TEfM0o3WGvWkuYKT3zqoBEk5/CvPk9vG35AsE8VkTglivh8xOiftgOrcK8WBzEnmtJlEdvm/skrGJucyE751j/hFRPMq9CNC9QQdSCXVpI0h7Dyhxyji04S+JXGrJGqAGm11qaa7JPEJhQoYy/lhBSOp6OsbIvV7SHy8hNnE/GvtUvojzy1JYb5tMfAIBNChWo9ij9EZJ8tfNoSP/GLNViGL5C2xvx5iQVfBV7W/YRGc3kjAx9lmkqsVBTnxXTUwO6d0Yv3phC2GQjg2tZPEzjtjN9ychOIzHbpz7gPRKPV100kkd9UNwJN+Fumv0tG4aAZKzyTeHFGjFr8aVP7anwIR3ZcqGZEHJlhF9HEHYMXF6NqoIuUfXd4WdJypTEh4ynXUEO1TyOV/TkDYpoFGzjxEZeYkMYqiVn36ziSz206A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(396003)(376002)(39860400002)(136003)(451199015)(41300700001)(66946007)(66556008)(4326008)(31686004)(54906003)(8676002)(2906002)(66476007)(8936002)(6486002)(5660300002)(6512007)(478600001)(26005)(6506007)(186003)(31696002)(2616005)(86362001)(83380400001)(53546011)(6916009)(36756003)(316002)(66899015)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkNkVWtmVHpua1FHV0ZycXZmOUxzdHNyWUxIa0lSYTE0YVhXTVo5MjVabDhT?= =?utf-8?B?aDdKYXZRTFVCWmdUNHFyRVVvRkl5dWUvVTZleU4xUXdrbkVpZU4yK3FnOXhS?= =?utf-8?B?VE42N0JiNlN3cG53WEowWXRBSkJkRUxoKzJpSThsV1doODkvYjJjb2lRMmZH?= =?utf-8?B?MGt5c2R3bXZuS2E0VVdCK2FoNFUrQW9kN1djbVVRMFlVRlNESlkxN3d0OWVh?= =?utf-8?B?bmo3YlI5UHRBYUhvd0tXR0RSUDZyWXFaOWI1S1ZDTWdZVHVrNTFpdms0NkhE?= =?utf-8?B?TndZM1VaVWJUL3p6Q1pOWC9QUDNFaVIxMGw3UU9sdldUMDc0Q3l2NElxV1Bn?= =?utf-8?B?d0xIei84b3NDOUZyVXZvd0t6SC9UVm92dms4WmVXT3E5aVI1T3RJMzJENzhT?= =?utf-8?B?Y0tKQnZQT3JYVE5YaWtjMmFWLy9zMzQrQ1JOUG1rRmtnKzlkT1NZNjJuSXVW?= =?utf-8?B?MldOblNYWDdtN3NRUUZuZzMyL3RnMDNUOFgzS2x4L3J0V0hTa3oyV2ZNOFJ5?= =?utf-8?B?eDhDcUc3cVJDTjgzQ1NNNDhZV0FyczlqUXNQSVFQRmZhRmxmL0xKK2czN3p6?= =?utf-8?B?dnMybUxrN2RMQ1lJampPUit2dktuRmJxTDVQYk83bjVIZjBxZTFzZnNLcmRr?= =?utf-8?B?dXdkVGQ1dURsTU1uM1pTL3QxNjZsaVIydENZelF5L05DSndDWnZ0aWZQVlp2?= =?utf-8?B?alU2TjErSC9BdG14M2hZa3AyazJJb0p1VjdrVEtwT2pYMmJOVmJQMGRtcnE3?= =?utf-8?B?OHN6eDNMQnJWZFlCVmZqVkNZajBna21xUEVKZWNiTE5zdDBtRzdabzN5UDl3?= =?utf-8?B?NGx5ZU9DSi9Qa1pBRVc4bFZHUERtQThQclA2OXc2cWpMWTFuUXRCVDNRMWh6?= =?utf-8?B?UW1aaGRSMThjaTA2VVJYUWYzN1lpNlJsN1Z6UGEzajNwQVJhMFJiS2R5NG5K?= =?utf-8?B?Ly96UTVjZnVoKytuVlhNeGhsQ0hZMkFYYzRUL3NjOFpQdmR2MlRaOElRNENz?= =?utf-8?B?dHBuY3BZKzVYSkliUU1JR0hkakxVNFVRNzk3VThLd0lnVjQySXM4cDc3eVRP?= =?utf-8?B?SkZreHpZbDE0SlBnTUhKcjJYdktDd0lXUFY3dWpjTDBsWHFhUFBacFZZTE9I?= =?utf-8?B?dGFHekpVcE43TUk1aWtkMWpnMVRhVVc4Q1FUSlRTNmxSRlF5cktBK0pReGc0?= =?utf-8?B?NDNEeWVkazMycjVMQ2NIclpuV3dJMGx6L1hGNU5yZFVra3VnR2pYdzliRys5?= =?utf-8?B?KzgzWWpPdFhRQ0g5UHBsazYzc0d2OWdwajhENVdHb3NZcEpnaStEOXNwbmNE?= =?utf-8?B?ai9Gdno0RnJ5K3FDclB6cjBJRS9ybUFjMXVCcXZJc2NSaUk1QkwzbVNjVlBr?= =?utf-8?B?aWF0K2VLdDc4NHJvRjR0anc2S2VadDlHb3pabi9JVDBaWExZSjMxVGc5MmNs?= =?utf-8?B?VnZYeElIUjBLdGpqYXZTMXUrUkxKRTRLd1IzdlNaRWZzalZkQ3l6NzAwU1hL?= =?utf-8?B?S3VLY1lSQ2duRXZQS3dXTmtJYk9pZ2RpYzhOVHVnT2I3bHZoWURHbDdTLzNq?= =?utf-8?B?RkRIZDRCNXdJVHlRZlI5OUF0cDhyd0dGVFEzbmVkejdzYUw1TUsxUnhCcUFW?= =?utf-8?B?azV5T2hpeU9VdmJhU3lGTkgzUVNMK2FuVyt4Y2tZNThnVis2bFZxZlJVWHQv?= =?utf-8?B?a1NSdFd4YzVLUkxPeE13UEpNZkFScW5WVkl5TFJESEM4cGVlNXJ1S25iRVZU?= =?utf-8?B?eTRmUVB6ditjUW4xTTVUS0RYRkJnTXY0VllCaGVYQit6U3hSTVN1eTVtSUp2?= =?utf-8?B?VW9wYzRhUVQ3Z0ZJeXkwVkQ0V2xINEtLMnFpSEtkS3B2bW1Dak5yK3o4d3NK?= =?utf-8?B?bWY4V1Q0d0wvZ2hSUU5GZS9DNkZZOTFvU05rTEI2QTdMM2VEZWk2UHVxNm1n?= =?utf-8?B?enN4REh3b0Z1N21OZm4waW1aaHdaeTNjcXlZQ081NFhWMmpWSW9FNXdBUndT?= =?utf-8?B?ZitqWTFjTVBkL01tbm9WQzBhYzFRemx2Q09mZDhaeUdOS2RsTXJaTUJEZHhq?= =?utf-8?B?ckEvUnlycEVLaTdBYWVYQjk0SkNsZ2ZMcFZGWHc3Vk5lK1BZTGt5WFNmblRG?= =?utf-8?Q?M+xEg984WHOjww98/mA0AxliV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: af9afe3a-85e6-4ce1-458c-08dad2a7c4c7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 07:52:03.0361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5A53z4XiTrTYWZmRK/E+ShlkbkfovIwmtV/KFwoPqdEmz830fQuP0cYZcUls9Bua/YNZ91UJxflMbVRoD7ZBzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7621 On 29.11.2022 21:56, Andrew Cooper wrote: > On 29/11/2022 14:55, Jan Beulich wrote: >> By defining the constant to zero when !SHADOW_PAGING we give compilers >> the chance to eliminate a little more dead code elsewhere in the tree. >> Plus, as a minor benefit, the general reference count can be one bit >> wider. (To simplify things, have PGC_page_table change places with >> PGC_extra.) >> >> Signed-off-by: Jan Beulich > > Ahead of making this change, can we please rename it to something less > confusing, and fix it's comment which is wrong. > > PGC_shadowed_pt is the best I can think of. Can do, sure. >> --- >> tboot.c's update_pagetable_mac() is suspicious: It effectively is a >> no-op even prior to this change when !SHADOW_PAGING, which can't be >> quite right. If (guest) page tables are relevant to include in the >> verification, shouldn't this look for PGT_l_page_table as well? How >> to deal with HAP guests there is entirely unclear. > > Considering the caller, it MACs every domheap page for domains with > CDF_s3_integrity. > > The tboot logical also blindly assumes that any non-idle domain has an > Intel IOMMU context with it.  This only doesn't (trivially) expose > because struct domain_iommu is embedded in struct domain (rather than > allocated separately), and reaching into the wrong part of the arch > union is only mitigated by the tboot logic not being invoked on > non-intel systems.  (Also the idle domain check is useless, given that > it's in a for_each_domain() loop). > > It does look a little like the caller is wanting to MAC all Xen data > that describes the guest, but doing this unilaterally for all shadowed > guests seems wrong beside the per-domain s3_integrity setting. Question is - do we care about addressing this (when, as said, it's unclear how to deal with HAP domains; maybe their actively used p2m pages would need including instead)? Or should we rather consider ripping out tboot support? Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 30 07:59:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 07:59:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449758.706692 (Exim 4.92) (envelope-from ) id 1p0Hzy-0003TL-Si; Wed, 30 Nov 2022 07:59:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449758.706692; Wed, 30 Nov 2022 07:59:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Hzy-0003TE-Pv; Wed, 30 Nov 2022 07:59:18 +0000 Received: by outflank-mailman (input) for mailman id 449758; Wed, 30 Nov 2022 07:59:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Hzw-0003T8-ND for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 07:59:16 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20607.outbound.protection.outlook.com [2a01:111:f400:fe16::607]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e238e27f-7084-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 08:59:15 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 07:59:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 07:59:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e238e27f-7084-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=blgb+1t8CNOJR/POjq6ex61A3Ky1ADYKegOOaGWGQVHIM5c//W85e9+GYELINJ3k0EGxkL7/e7WocEXQB/ko8rZ3gI48m9Ssia3TrfmUJBcwlD96X4j4GO6BjftD2exmU298EHusL2o0yo4+Rj1+NmAAgPJp6eQ4Ss9Ox3hOGYnTkiHu0Y/llo6l619ndVMtjKcEjeAoR78/eSfWN749HhmhkhmRhJ8Ir7ykUmqpBh/3jaU276OhwS1Sdm0z26ehdrHG/UA1ZWw0+fHNLKOcGilagR5pkd05qOZalzYqnbolXmXWK9WXn/05eutrht3Z/FjyBuGjo9veEpEs3skjJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bgPKsdLcbxqD2OHRzaIQxIQ1pW2Esfntfw9/qZIIVdg=; b=dh2Gk9QVkyI/UWbd1S0ip+ScoBOudqAOmK2gLIP7GW2UInsXX/6wCMa03Cb84vk2GZ/sUmVyuInyTeGXsgZ3hG/GfzWGaYZ7GFD+R98h9DZksYr6Z2gAhfYmYyPrB4dil7LeGX2UUZNLQtBjFcPSJZtO8LZKfxGnKtfTDaTS5Qy0zw2AZ7C30gTb5hj+jGQOs8WqOuqlcWp7FvslSOI+dVW3/hz0N5dLIMEgX2zVN9NqKqeDcf4HZuDIcvlT07myCfEMN5+YVRwB/13yJnJyNw6rDqi7R7PbOZ8aaJAjCZ4+gq9j+NpgZPbCRhg5myXsWeEgpNBXIbWCJwggq7+Z/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bgPKsdLcbxqD2OHRzaIQxIQ1pW2Esfntfw9/qZIIVdg=; b=K4yeoxNPdWmnExIZZ7cgUpgSWusg0qTCpZQqZEwdCfc+hFwb4YeEcRsDhl8k79hQpIYf7E5flMTTx3qV9fUEpfNrtBPoWXvgbavdvCrXgkhibLxqiWUY7RnyBQ6MTmZkMv990dq2VOQKvmeHLs1tD02sta52r7ISytvwnIWdmFJOQJn/q8BeE936/F6Tf63YJGhQVlOI1nkozNRBlDXpb7CS+XYAf0NSKOZwMX/HsFoZrrSMsEAi5NNRil6aCmAbhXVQAnMVUsKYvO+sDe4+yLANJk8c+pRTK7tlZa/+4L91IFizEv5iK+U2ydIdwEccVnbsUr0JosUzYciSvSf5NQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 30 Nov 2022 08:59:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/APIC: make a few interrupt handler functions static Content-Language: en-US To: Andrew Cooper , Roger Pau Monne Cc: "xen-devel@lists.xenproject.org" , Wei Liu References: <54ee1bd7-9b6a-efc7-8bad-50aa7d6d955b@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0046.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9422:EE_ X-MS-Office365-Filtering-Correlation-Id: 65034982-5d3e-4404-595b-08dad2a8c544 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yw5VrPbVkaQN//hv29VShCM+gvqmw5XY8jaWSIaMLwAzz9cDU8eFGV3P1OZUWU9NGlw2Hp09/V5o4bZl4kUBqhDBkz6byfI2kpS4Brl5RO+eKsSiBDDY5qEYbMkl6eqSyq8LErf8N4rhyYgNpnvMUCoeL28YTeAXtpwSoOVx49v7j/H818yhjOXFH6UlT4m9ylX0yIyT+t8ifd4owRTTTBWN3cTvTkpmm64HLC+GwhYz4rkCcyEcMBDT+BLbvU4CNhEJRho1Wzghhp4Rzg3vscMA5tEuyWwWyAbmkbj+/vEKdLhki/abnl3+LBbYICKFwZlHuczLRC27V5b45ONfiwm6URSgjov0Q7uC65Hwzw9cKrP6o4gdnu3z0ho94lZchWbfHfVl9OqPA9CcjmS3GCNntu39ez46sGjzwCntHodyyEJib4DPI5OBEf3/GNRWAvViY/OHu1GpuuQOgJWDn6lApmOME1KvHu7itgbykLnZqno+hmhehLXRFbyCyTexsNmUwOgaGjLApR3ggyhBnpH7sZQyXQfsqdNE72NwfX3Xy5E0XL8E37XJAcUf2Fh/c8UhHWAMQg6QJMvB/vVZQnNXIn0RliQbgaZocQO+lAJVulgtJElqGbA5+f6Ebo3b3kWJR+fRkR0m3wh8vThBZqKbegGbfLmr6Es0Vm28A6KDZjG6D3AbMGv1jOnOVNe0J+iimfXghzloXpeuzWK62C3Fy7Mw3uPPbI1Oxq97QKg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(39860400002)(376002)(396003)(346002)(451199015)(36756003)(38100700002)(31696002)(86362001)(2906002)(66946007)(66476007)(66556008)(4326008)(8676002)(8936002)(110136005)(478600001)(186003)(316002)(2616005)(54906003)(31686004)(6486002)(41300700001)(5660300002)(26005)(6512007)(6506007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2tlaXcwSEtZeWZ4YkNPczNENFhvZFZ2TzdsbmoxRFFJTlZNSDFFVTFWNlYr?= =?utf-8?B?WFkreWFWOFc4b2g1U2ZmaEFTblcxaTl0cHhmeDAvS3gzRDlkdlRxbTZ6aGRE?= =?utf-8?B?cUFxWGZJMzRSTjEyNktJYm9LT0o4bmYralFxblI4b0Qrajg1VTdMbFNSRnpr?= =?utf-8?B?aHJKc1B0dHVoQVJJcmsrMjNUSzVIeGlvT1MzbTIyTXRKYlU0ZDJEZE5XUFJr?= =?utf-8?B?cHlDeEp4OWcwRjZiclBmQ0IzZndrcDgvdnI2SlRob25KR1BDaE5jMUw5TDI2?= =?utf-8?B?amVDSFB0cWJNRHpRNXFLdGc0YllMaHpxbzIvZFlBZlJkTmpjNmVEK1pFaG83?= =?utf-8?B?cHI2NXJqN2tZTE14dnRGUUlQYWFxVUxjY0o5R2tNUTlTeWlNZDdaa2w5VUx5?= =?utf-8?B?ZGFkTWRwQ3ZHRENrR2lFeTNWUjVjajZZMXNNOVlJNnc5TmJua3NRekF6SHNT?= =?utf-8?B?dGFqUHBNT0RrOEd3c3EyelRRdjJqdnlkYWtPWFR0M3ZuR1Uvdk95eWd2ODRi?= =?utf-8?B?Vk4wc2V6VkRkalU5MS9CaU1UM0t2VWgxQzdLaDM3L3JmaUlGUVV1eXdnZ0I3?= =?utf-8?B?YmxrN01IRXRiSDJyZEg1RzBBMDBKOW9kZ2txdjBXY2JmZEJGZEIrd1pMcFBQ?= =?utf-8?B?NzROY2lzZklHemhERHRmUExrWk8wNCs1Y2lySUFNWFJzT2lFNmJnWGVUNG03?= =?utf-8?B?Z0dKdytud0h0dHpNMDU5S1d2amh0RGdiUWRKT2x3U1czNmJyeWV6Zmk3YVFn?= =?utf-8?B?MEFJeFZzc2M0bFVGNisyVVVMV0owUjI2T2NiRE12RlFsenJHckpsbFVCQnBC?= =?utf-8?B?ZTVOdW9CZE1XSWZSUmJpRThlM2JESGlrelZOYWQyQWx2SmZnejd0MThJa1dp?= =?utf-8?B?TGc5cVdKS1AxZ0NGZGpDT212MmJhdFJsM2E0cWxrZFQzOWZBNmZJYUUwMzlk?= =?utf-8?B?UVFXeGdUb0IzdUxDaWI1QllnU04vU3lFMDd2K2tQT1E5Y011cjVnaHpmdmRC?= =?utf-8?B?MDZFUnM5aHJlT3ZYZ0c5NWI4d2locDVoQUkrTzFBNDhSR3FubllMWWdkUkRv?= =?utf-8?B?SDNVTit0R1h0SUdxY040ejRyQ25adGgwcjdlenZxTFFPeFkvVXRoTkJaYm5m?= =?utf-8?B?a0F3S3NlVDhKejNZdGg0dit0anZobitxK3p6bDR5TjB6RE1iRUhTY0VnbXZD?= =?utf-8?B?VXEwL3ZrcXViWXdKVkJPMGVrVlNRTW1Ib0F6ckV2dDJoNmtZMi9weFRtOTd5?= =?utf-8?B?YmJJWGxqUlQ1TU43OVErdXRpZW1Mcjk2Mms1dVZ4cVRUdVVqUFpmMzY1K29H?= =?utf-8?B?c1FZQlFNODlDV1B3OWpGWTJtejdUcUFsbUtkTXZRZDdXNGFRdFBrWDNDOHh1?= =?utf-8?B?R3pySXN0Z1NoYVVZYXl2V2lPVTh2UksxdFo1bVlUNGwxbWFESjY3YVVoTnd4?= =?utf-8?B?Zk54RkNQbzFWVHFCWUVleVVMYXhQbmxobXNoZWh0SjhoNzZzekxucERjU2oz?= =?utf-8?B?Y05FbnBYV08yVHVDd0pnZDdwR1Evc2MzUlROUXc5YWlFVm1GZ1BRMlhBc1Vl?= =?utf-8?B?YlNOekJQclNlZ0ZrWkdUUC9wNTNKYVNaWmQ3elNCSmhlV0dxdlppL0U0Z2hn?= =?utf-8?B?R2VmUWc5SWRtcm14N0dEcnlidFZVRlhpSElOeFAvVmlSN0pvTTBqWGZRNlNl?= =?utf-8?B?RFBrU0wrV24wM3I4VHJKYkhiRnRRU1NIR2NSaEI5WVpzTE9pNFFzN1VOR3Fi?= =?utf-8?B?bWIrM0tnbXBSS3l1eDJ4NWtVd0VDYmdmaEpPcE1jSkM3TXhzTFMzc0EweWVR?= =?utf-8?B?NnphVjJjMldSc1kxamFHTWtVcXRJeUJFZzJBNmU0bmoxb2ZjUnlYQmdEdTdQ?= =?utf-8?B?dXp3aXpuYkhBOXZMRktETFd3a2Znc2pYSmhRbnZObVdvVFNqUnJuQ1VuZTVC?= =?utf-8?B?cjk3bnVhYTJ6YzI1dURrbFdRbm1aUWJrQkNNcEJCdXZYVDgwR3U3dUVKWVlQ?= =?utf-8?B?YXVQZ1JhS3NPNEVpemdHU3dvVGh4T3J1SFI2NTBnaWF6Y0dhUTdIdWN3bEFE?= =?utf-8?B?WTg3MVhrQjE3UGZ0czJaaVQzWWFVSHBkSjIwNnZIeVVuSE5UcTR2MCtBSURB?= =?utf-8?Q?4SJiLlee13mZX+rJV/rTTsQhT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65034982-5d3e-4404-595b-08dad2a8c544 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 07:59:13.3994 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fXMneCGce+ByNtRIpWnuMcMaiVebgEnxefFKipJdB22ldxxEiByuBs6L6Xr7Lzcymdhaxq6VTYcaLyQrNnCyaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9422 On 29.11.2022 17:21, Andrew Cooper wrote: > On 29/11/2022 16:05, Roger Pau Monné wrote: >> On Tue, Nov 29, 2022 at 03:46:30PM +0100, Jan Beulich wrote: >>> Four of them are used in apic.c only and hence better wouldn't be >>> exposed to other CUs. To avoid the need for forward declarations, move >>> apic_intr_init() past the four handlers. >>> >>> Signed-off-by: Jan Beulich >> Acked-by: Roger Pau Monné Thanks. >> A nit below. >> >>> --- a/xen/arch/x86/apic.c >>> +++ b/xen/arch/x86/apic.c >>> @@ -127,21 +127,6 @@ void ack_bad_irq(unsigned int irq) >>> ack_APIC_irq(); >>> } >>> >>> -void __init apic_intr_init(void) >>> -{ >>> - smp_intr_init(); >>> - >>> - /* self generated IPI for local APIC timer */ >>> - set_direct_apic_vector(LOCAL_TIMER_VECTOR, apic_timer_interrupt); >>> - >>> - /* IPI vectors for APIC spurious and error interrupts */ >>> - set_direct_apic_vector(SPURIOUS_APIC_VECTOR, spurious_interrupt); >>> - set_direct_apic_vector(ERROR_APIC_VECTOR, error_interrupt); >>> - >>> - /* Performance Counters Interrupt */ >>> - set_direct_apic_vector(PMU_APIC_VECTOR, pmu_apic_interrupt); >>> -} >>> - >>> /* Using APIC to generate smp_local_timer_interrupt? */ >>> static bool __read_mostly using_apic_timer; >>> >>> @@ -1363,7 +1348,7 @@ int reprogram_timer(s_time_t timeout) >>> return apic_tmict || !timeout; >>> } >>> >>> -void cf_check apic_timer_interrupt(struct cpu_user_regs *regs) >>> +static void cf_check apic_timer_interrupt(struct cpu_user_regs *regs) >> Given that the function is now not exported out of apic.c, wouldn't it >> be better to drop the apic_ prefix? > > This is the handler for the apic timer, as opposed to the plethora of > other timer interrupts we have elsewhere. > > Simply "timer interrupt" is too generic a name. I agree with Andrew here. >> The same would likely apply to pmu_apic_interrupt() then. > > This one could lose the infix.  All PMU interrupts are from an LVT > vector.  It may have made a different back in the days of non-integrated > APICs, but those days are long gone. I'm happy to drop the infix. Won't bother sending a v2 just for this, though - I'll simply put the adjusted patch in soon after the tree has reopened. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 30 08:54:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 08:54:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449772.706703 (Exim 4.92) (envelope-from ) id 1p0Iqj-0002UW-Bg; Wed, 30 Nov 2022 08:53:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449772.706703; Wed, 30 Nov 2022 08:53:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Iqj-0002UP-8n; Wed, 30 Nov 2022 08:53:49 +0000 Received: by outflank-mailman (input) for mailman id 449772; Wed, 30 Nov 2022 08:53:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Iqh-0002UI-Mm for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 08:53:48 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20631.outbound.protection.outlook.com [2a01:111:f400:fe12::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7ed7db36-708c-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 09:53:44 +0100 (CET) Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DB9PR08MB9755.eurprd08.prod.outlook.com (2603:10a6:10:460::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Wed, 30 Nov 2022 08:53:40 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.5880.008; Wed, 30 Nov 2022 08:53:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ed7db36-708c-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QdRzY6p7b9IfT4WnpzVLeJf4bUAU1PpHmrIaUA330bTIm+ogfwb0wbW1TRl4/gLy2pcWmDNvTKP2P7vCorKfzEvPCxMmTf4jQ+6GY8oVWczSAoZwGbJdpWX/VocqxctF9g0f/gNcBXTsz4HIWGHUM/GYw5exR7xjiip/YGzsR6Cvso3Z8hE+Sba6lJx48Ekm/G5yKIeOVn/v2XDJw5FLj3rsK/crlU30Vp/ceSblvZ9xFhL+Dd7Ii0+VV7tyexfZDpW9ARKiORok8xrX9rPHZTyh5QEapOD/HYn1SWspyNfUOgnk40jixQc4RLOieDjSO5KOccpZUPyETnzDB9N5Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CFnbZWJFUp0sAzawbJ6JmnR+WoHSTi35d13YUqDmStE=; b=Njz7WuZonqX9Y//GltoV9lfRCWebjEQ7Y2MGurTY8FmKl63BuTtFUrSooKmNlm6CMCEGeMwErZg7PcaBdz7wk35eHC61zzOxsctLrwQuavancTFKi2wPPtY23yQ7KUxsNXPVprLgLjwACnfRrjtBOyNBxpzzRJMMm8JezLPcXsYUnuBS7BrA5cNhZ37PVk/gQZFS0/kIvKEhc7qnr/dTOnVTpll5kJw+KdxO/d0ls6AaXjwlLZb0U+fr8rFVZZ7K2qqdtKVtfZTSSTclTt8g6dovHHfQfr45oE7NxHcO+sOe7xyftVom/wXSQuBu8aPyo+kPdjdW3SFQP5xpf6rEvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CFnbZWJFUp0sAzawbJ6JmnR+WoHSTi35d13YUqDmStE=; b=ltPdw+TB4d5rVQL68GocmQzJPEhhf/Anbv2Yoi52gnvIqTFrcOytbw4Ye5cuCcZWcdgkXlCU1WyUP3+Ajo9fKR05bHsDONr2KWyW0H6RlhIjqse46L7Ik8esUlcX1H3MbeZ2+M4P0AqKUgsJDY6IgVItQWA+xFHAVEgq1zJpph4= From: Luca Fancellu To: Stefano Stabellini CC: Xen-devel , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH 3/4] tools/misra: fix skipped rule numbers Thread-Topic: [PATCH 3/4] tools/misra: fix skipped rule numbers Thread-Index: AQHZAzNHmn5ClVb9v0W1JXlG6nXFZ65WlJMAgACXfQA= Date: Wed, 30 Nov 2022 08:53:40 +0000 Message-ID: <21F6A61B-1476-49A7-8726-7F94BBA627F6@arm.com> References: <20221128141006.8719-1-luca.fancellu@arm.com> <20221128141006.8719-4-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DB9PR08MB9755:EE_ x-ms-office365-filtering-correlation-id: 2ddff6ea-a5f9-4606-3307-08dad2b0609f nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UnxYQGkwvIpJix0A0HjxSxlCsvm3KMbWLvZArO+CZ++6CeaVToCZ0t6nXAgUZZ8m8fgMRN6y5eOdEuMpWlI7OFY9W8F5ZZM5k3FJiw1FpKZD6ic9LQgHC4kl8QoQSWr+Sb+0hmdD5ULJUtCnAsZjtX8S3+u3nmhyI2P0JLh7DrW/EWz/KugbFJh8n4tlHn2LCM7IWSM0Aw7VNHF6uFmur0V4dQTYZgPCWI/HBWKTzwhiQCu6A1RiuWDt4waJfWKmHkurzAx041gne0hn97rZrhlw+Lwbwr+GuHB2HKWPxCuszzbSp8ng1qEwdFrPCgIcr6sZLNf1MXTvsSVGMK+f4hO0LmiIW+EKrm9XnKpvq0m7P0uYf8aNaN6+FG8Wgp2XIUC0W6aDDo4NZFHpoayP4XKWb7YZyTZJxEZz80KCOYQmHGuZY530CIeKUy2F8gU9iBbehsTeVstQQHvLfNfo2vMSwaUZ5ENctZGyLQjP7kq+yqC+xnefVNA4eZp4fQKOEirgwgqqFJ7q6Cgrb6p/1benActsX/VrVfvuYxWOnyRRjWLiLFUOehAP15Xxbh4ZvU+UA5c+lnZrUXDNtiQuGDD1Tkn3GR9irPqH2k7Ps759K044uH1qQDXbVonPN/Ovk/sDyx1+AD/tjNM29vdPG/ddPbBR5G2LcJXmyavxqg1Py21AxjS3UxZPijTznhLlJ8JBkai10oXJ6oHJ95zlFPQaa33xCv7+jU3gv7/GzsA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199015)(91956017)(122000001)(41300700001)(8936002)(83380400001)(5660300002)(66476007)(66946007)(86362001)(2906002)(2616005)(4326008)(186003)(38070700005)(8676002)(6506007)(33656002)(54906003)(6916009)(316002)(64756008)(38100700002)(66446008)(66556008)(76116006)(478600001)(6486002)(71200400001)(53546011)(36756003)(26005)(6512007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SohzbvRdW76RVXLe9P0o4iVdvycRsFRzb2hucUh7gTl4eDl0FIWkYS3sleHQ?= =?us-ascii?Q?es0A1FmD+adFSIwsmR5ZbzmTIdL8vfMGuSD+bCY1a9vrMQpu8f/y9/g+ULxT?= =?us-ascii?Q?Fi0uvvhNSoePTUWDvSVTcTiA5CEQ51Q7+kNdZ5DOesP5N9lrBa5Su961XSY2?= =?us-ascii?Q?1kiWfaffyFGInxlEfz0cfBdeEkq/aBuWOXmjwQ/RKxi6XRb/ibWyDqZAIXRq?= =?us-ascii?Q?pXkJl11Kgy3zP8J5r4U+imyPpDN9fnepeg3rwbywwIkazZczarWyB6zC4RI+?= =?us-ascii?Q?f3zIKzFTdMP33bl+wo5lj8seq4vqCCEbtS3vB4VGEbuVL9TzdxCqv4x+7HpE?= =?us-ascii?Q?I64aXhGssSs2lRMZvJ8/hdnco5tDfDmZxTxq+d2+n2CKWfJybFEDZq39BEVE?= =?us-ascii?Q?QcKalxW2xOJcHkjyEdHXwx82KJsX9udMRTlUq5dfSH8XlYSMr9doq1mETxuA?= =?us-ascii?Q?FCVEU6MsCBabmpWBfSBlqnj4vdwdAWcTaSiHssQwRb10E831pUc/eBMuOAZv?= =?us-ascii?Q?6TwxOlWXTkOuQPHIBadKXseVzlXUQAfakYLnKRogGG286KIkWmNwg+1uR6Sa?= =?us-ascii?Q?GVo1+dML8LjtL+CF7ey3iBwWdMIRP8r8y7BPz5cGZHXFtcJCZsBDCPzKpZTv?= =?us-ascii?Q?jGmGTT0lGNHUUznoOgYRdrSL8MipjUf7rOgfoU6RY200qHVtjkbodBONSThB?= =?us-ascii?Q?4JhT7qebYiQwZdeDMLqNes7sIYYr/e8dDdLa+GnyAaOWO57CdcAoLuJAhHY1?= =?us-ascii?Q?RBUWznaJstyHBp6OKKeu0AZDcPNeCU6Xf231O1q/BA8fiZ3m5fDdHnp4K8NZ?= =?us-ascii?Q?cgOUlwYYlacAIb5AKx4/GMejvJ/4vF3qz+9Nzo3ckVZMphf2vK0x1tJrlEUN?= =?us-ascii?Q?U9yrzXR6jp1KWLx5+tEx0ETalFT6aL1FAwgX3+PEsJcKHPqdrooV/KCt6vgC?= =?us-ascii?Q?bnOWFU66m6tzn1msW3gQdXj5T0idzqUUVikEaHEOhf5UzFTuH7UeZDYsB2sJ?= =?us-ascii?Q?RuMQd1y5dOEYogYnTk8ImaEYR/FdilSHWChLNbVP0TlWmeNsQy82lhSwcxQg?= =?us-ascii?Q?GsLAL+Y1kMqCrgyj/zCMzLMPj/AFhk/CuzVNSTrXPqHHO5cKoGTY+RVKAKda?= =?us-ascii?Q?rPOhlquplaJy/CO9GdXZvQjyj6x2NwPjBPXccQA1ZfMntjGSMWADau7St3wU?= =?us-ascii?Q?l0TmaRL3f8JJbbJK0mRCqjMH3K8oCZFZLexW4OQv+Sk8FNyVOmS1P+ehTQL+?= =?us-ascii?Q?Tx7zpcapjS39Bk8044vQh5mGaCcwXEfBptQvPsBMrDzqL82OQyfijGy43ke+?= =?us-ascii?Q?u5XWxYgKfv0TD3rwBzw8jSnLEpxtXZKQWCzQ7L8E9oqaa+DqXGbEkPEv3RGB?= =?us-ascii?Q?vr/HU3vMgRpYWehA+zim26vjd7619N5KeIKEdT9HBQv886sDeaK6hr+ifL5O?= =?us-ascii?Q?lHw4ywLtnvpQVKf/O2pS0i6YSNn8hBPVFwzZz2Uam96UdiOVcJUqD2JLHByy?= =?us-ascii?Q?gHeoEAFgm7d5G97TE2m8J5Fa4BPuoKrJgAiRwK/XIhpPBXp5ODX/VS4njkNs?= =?us-ascii?Q?VXdvcrhXcTWKaBTQue2XMBQVL4UPlrnNin9VT12wi3cY+CMQl8fg8hOIbOUp?= =?us-ascii?Q?ug=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB3749.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ddff6ea-a5f9-4606-3307-08dad2b0609f X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 08:53:40.3000 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cvFhx0ESTmYvncbX/WT2VobVbDl+WvtMhHr0AjzEr4QKhJ2tGJkK//HfZXo5INZtfyKn9B3cZYNUTtOLhvhgpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9755 > On 29 Nov 2022, at 23:51, Stefano Stabellini wro= te: >=20 > On Mon, 28 Nov 2022, Luca Fancellu wrote: >> Currently the script convert_misra_doc.py is using a loop through >> range(1,22) to enumerate rules that needs to be skipped, however >> range function does not include the stop counter in the enumeration >> ending up into list rules until 21.21 instead of including rule 22. >>=20 >> Fix the issue using a dictionary that list the rules in misra c2012. >=20 > I think I understand the problem you are trying to solve with this > patch. But I am confused about the proposed solution. >=20 > The original code is trying to list all the possible MISRA C rules that > are not in docs/misra/rules.rst. Instead of list(range(1,22)) now we > have a dictionary: misra_c2012_rules. But misra_c2012_rules doesn't have > all the possible MISRA C rules missing from docs/misra/rules.rst. >=20 > As an example Rule 13.1 is missing from docs/misra/rules.rst but it is > also missing from misra_c2012_rules. >=20 > Can you please help me understand why misra_c2012_rules has only a small > subset of MISRA C rules to be skipped? Hi Stefano, MISRA rules are in this format X.Y, misra_c2012_rules is a dictionary where= the key is=20 X and the value is the maximum number that Y can have. For example rule 13.Y goes from 13.1 to 13.6 (in the dictionary misra_c2012= _rules[13] =3D=3D 6), so the code can now check which among (13.1 .. 13.6) is not in the rule_lis= t and add it to the list of skipped rules. Here an example: { "script": "misra.py", "args": [ "--rule-texts=3D/path/to/cppcheck-misra.txt", "--suppress-rules=3D1.1,1.2,1.4,2.2,2.3,2.4,2.5,2.6,2.7,3.1,4.1,4.2,5= .5,5.6,5.7,5.8,5.9,6.1,7.1,7.2,7.3,7.4,8.2,8.3,8.7,8.9,8.11,8.13,8.14,9.3,9= .4,9.5,10.1,10.2,10.3,10.4,10.5,10.6,10.7,10.8,11.1,11.2,11.3,11.4,11.5,11.= 6,11.7,11.8,11.9,12.1,12.2,12.3,12.4,12.5,13.1,13.2,13.3,13.4,13.5,14.2,14.= 3,14.4,15.1,15.2,15.3,15.4,15.5,15.6,15.7,16.1,16.2,16.3,16.4,16.5,16.6,17.= 1,17.2,17.5,17.6,17.7,17.8,18.1,18.2,18.3,18.4,18.5,18.6,18.7,18.8,19.1,19.= 2,20.1,20.2,20.3,20.4,20.5,20.6,20.8,20.9,20.10,20.11,20.12,21.1,21.2,21.3,= 21.4,21.5,21.6,21.7,21.8,21.9,21.10,21.11,21.12,21.13,21.14,21.15,21.16,21.= 17,21.18,21.19,21.20,21.21,22.1,22.2,22.3,22.4,22.5,22.6,22.7,22.8,22.9,22.= 10" ] } So this patch is solving two issues, the first one was that rule 22.Y was n= ever included in the suppressed list because range(1,22) produces a range in [1..21], the second issue is t= hat the code was producing Invalid MISRA C 2012 rules, for example 1.21 and so on. >=20 >=20 >> Fixes: 57caa5375321 ("xen: Add MISRA support to cppcheck make rule") >> Signed-off-by: Luca Fancellu >> --- >> xen/tools/convert_misra_doc.py | 32 ++++++++++++++++++++++++++++++-- >> 1 file changed, 30 insertions(+), 2 deletions(-) >>=20 >> diff --git a/xen/tools/convert_misra_doc.py b/xen/tools/convert_misra_do= c.py >> index caa4487f645f..13074d8a2e91 100755 >> --- a/xen/tools/convert_misra_doc.py >> +++ b/xen/tools/convert_misra_doc.py >> @@ -14,6 +14,34 @@ Usage: >>=20 >> import sys, getopt, re >>=20 >> +# MISRA rule are identified by two numbers, e.g. Rule 1.2, the main rul= e number >> +# and a sub-number. This dictionary contains the number of the MISRA ru= le as key >> +# and the maximum sub-number for that rule as value. >> +misra_c2012_rules =3D { >> + 1:4, >> + 2:7, >> + 3:2, >> + 4:2, >> + 5:9, >> + 6:2, >> + 7:4, >> + 8:14, >> + 9:5, >> + 10:8, >> + 11:9, >> + 12:5, >> + 13:6, >> + 14:4, >> + 15:7, >> + 16:7, >> + 17:8, >> + 18:8, >> + 19:2, >> + 20:14, >> + 21:21, >> + 22:10 >> +} >> + >> def main(argv): >> infile =3D '' >> outfile =3D '' >> @@ -142,8 +170,8 @@ def main(argv): >> skip_list =3D [] >>=20 >> # Search for missing rules and add a dummy text with the rule number >> - for i in list(range(1,22)): >> - for j in list(range(1,22)): >> + for i in misra_c2012_rules: >> + for j in list(range(1,misra_c2012_rules[i]+1)): >> if str(i) + '.' + str(j) not in rule_list: >> outstr.write('Rule ' + str(i) + '.' + str(j) + '\n') >> outstr.write('No description for rule ' + str(i) + '.' += str(j) >> --=20 >> 2.17.1 >>=20 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 09:26:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 09:26:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449777.706714 (Exim 4.92) (envelope-from ) id 1p0JME-0006JU-Vw; Wed, 30 Nov 2022 09:26:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449777.706714; Wed, 30 Nov 2022 09:26:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0JME-0006JN-Rw; Wed, 30 Nov 2022 09:26:22 +0000 Received: by outflank-mailman (input) for mailman id 449777; Wed, 30 Nov 2022 09:26:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0JMD-0006JH-9V for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 09:26:21 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0a31b87e-7091-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 10:26:18 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Nov 2022 04:26:15 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BN8PR03MB4929.namprd03.prod.outlook.com (2603:10b6:408:79::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 09:26:13 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%9]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 09:26:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a31b87e-7091-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669800379; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=a1tGRui2dX+2fniVTma8dS61MXBhNt7lFsSo8yvmmPs=; b=LF8Tzy9n8bt8s4VNCgSLYKlUTLKF0aqx/wJut35gUmULonUZhFyoFUis TBp48uiMQRBAAsTrZUor92KlQkFI+1tPcJWMh1/HhnGV+bAiu9QhwmfyX Pqyp6Fwz5u2D6h9EsP5aLOETKnI23mQHMS9Zyi3yDB6uAgElyKD8aN5Pc M=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 85842101 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:VB20q60by8+5IVB2c/bD5ahxkn2cJEfYwER7XKvMYLTBsI5bpzwFy 2BKD2zTaPmMZWOhLtAnbom0oxsDsJLcz9ZnSlM6pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVlPagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfHGV// t48IRc2awmbieW86rP4UvNAr5F2RCXrFNt3VnBI6xj8VK9ja7aTBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6Kkl0ZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r827+Tx3qjAer+EpXkqdR0q0LJ91YwGS0tDVGf/NWCpm6xDoc3x 0s8v3BGQbIJ3FewUtD3Uhm8oXiFlh0RQdxdF6s98g7l4q7V5RuJQ2sJVDhMbPQ4u8IsAz8nz FmEm5XuHzMHmK2YTzeR+6mZqRu2ODMJNikSaCkcVwwH7tL/5oYpgXrnQcxuH621ptn0Hyzgz TeXqiQ3m7QUi4gMzarT1VLGmTO3opHDXyY26x/RU2bj6Rl2DKanaJav8kPz9utbIcCSSVzpl HIDgcmFqucVEYuKijeOUc0KBrii4/vDOzrZ6XZtFZQ88zWm+1a4YJtdpjp5IS9BNcIDdxftY V/UvEVX6YM7FH6ra6BwS4+1F8lszbWIPd/lTPHPcfJVZYVqMRSA+Gdpf0H492TsllU8ibk0f JuWb+6oDG0GEuJg3j6/Tfxb1qUkrh3S3kvWTJH/ih6hgbyXYSfMTa9faQXfKOck8KmDvQPZt c5FMNeHwAleV+u4ZTTL9YkULhYBKn1T6Y3KlvG7v9WremJOcFzNwdeIqV/9U+SJR5hoq9o= IronPort-HdrOrdr: A9a23:KmIqBqyGuaRbmbOWOHBeKrPxTOgkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu vg2iMLnUvXRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirCWekD+y77b+Mh6AmjMTSSlGz7sO+X XM11WR3NToj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhn8lwqyY4xlerua+BQ4uvum5loGmM TF5z0gI8NwwXXMeXzdm2qn5yDQlBIVr1Pyw16RhnXu5eT/WTIBEsJEwaZUaAHQ5UYMtMx1lP sj5RPQi7NnSTf72Ajt7dnBUB9n0mKyvHoZiOYWy1hSS5EXZrN9pZEWuGlVDJADNiTn751PKp gmMOjsoNJtNX+KZXHQuWdihPSqQ3QIBx+DBnMPv8SEugIm6UxR/g89/ogyj30A/JUyR91v/O LfKJllk7lIU4s/cb99LP1pe7r4NkX9BTb3dE6CK1XuE68Kf1jXrYTs3bkz7Oa2PLQV0ZoJno jbWl8wjx98R6vXM7zP4HR3yGGPfI3kNg6diP22pqIJ9oEUfYCbcBFqEzsV4o6dS/Z2OLyoZx /8AuMTPxbZFxqfJW945XyBZ3BsEwhubCQ0gKdOZ7vcmLO9FqTa8srmTd30GJ3BVR4ZZ0KXOA pxYNG0HrQM0nyW X-IronPort-AV: E=Sophos;i="5.96,205,1665460800"; d="scan'208";a="85842101" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mem0jsJxVYcRnfsmc+k/2LMZTuFHuUdkWiyD1lPHwlvAPUU3cLbfwVRy0UPUm7G5IA/j9dxAHBHui+TcBCEYoGWCMx8Lqqm3sLY5qOWNHQjAvWo66r4jywrXnBo7FUGTegelcFyjDgrR30KIsZ10u0B0XlhRGHwNtKyhdplR47ewU8jXXf+NEstGJIzIIbOr8T/zrCRUaU+sk+jCqRZ5P5gggV/ssUI+5y0FI0U2gZau/r83C2R6YNd2J0eOxfcWcEFJ6/z3jXXc2TGNciWWgrvQdPbYR2MqxqtVtmKg+AnBuCt+Fsz5XBsu91f0EtDWWkUikeHBc7f7Ec4CEeL7eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2TzLxx3p+XBF6obhIGVlm//r/ntLl/f7S09/Az1T3TE=; b=C8ArNvCUME4TFpdm1A/YLoQigcFu3maxdghz98L3OmfkVx9K3BT7dAxQZTT+giL3DOKQrRPMj09wKgDBtI/Co0HOugYHtfPu58CssyjokS438oxJ8zcg+WwvPxsv2ML80vGnmmm3cuSIxtDc5A9TivyIhp0AeuDkM6m0HUMA2twCPRymrWvPbeASoKN2E0ml7n1B0w8GJGQsplhG1l4+cTQaIfdx82bIRY2CZyfhPi6U5rdpo1G1G+6CMnvAgbf96bPRt3yDj2WQifZJWjrvs7Dt6RiZCtvLeMrFoQSOClD3OReouQsUR+p9L6joAXh/mvp9xw/nBdaOU4WegaqHug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2TzLxx3p+XBF6obhIGVlm//r/ntLl/f7S09/Az1T3TE=; b=XWefflSB3yZkrI96wQwG1WHr36WZTTdeCbQOi1u/oUrEQo0A/upjFe8NiaXUH3d5E/CvNEPOD+9HaXs0OBofK7kH8oXpmcv6nKWmSEqYYKUeVEAYAFysOkG/0c9fqajDZrzk93XvhcxHSUTIVnRDxO3zHoxmJ3km7UZffrh3UCM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 30 Nov 2022 10:26:07 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Stefano Stabellini Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Greg Kroah-Hartman , Jiri Slaby , Juergen Gross , Boris Ostrovsky , Jan Beulich , Olof Johansson , Ingo Molnar , Jeremy Fitzhardinge , Chris Wright , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] hvc/xen: prevent concurrent accesses to the shared ring Message-ID: References: <20221129120107.2942-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0158.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::19) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN8PR03MB4929:EE_ X-MS-Office365-Filtering-Correlation-Id: d2a09d31-8abe-4e4c-9fb5-08dad2b4ec2b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: coUehJfqy0sK2s+0FBuo5dxZM22si/edpRVXAPbmY1Wr/POFPn5poWbLM8H59YpeIHrco97iuLybc3UivQX1NWOYGbBgA61Ae8lvlWAZ9twTTLcu45R9pggulOcin+psboATNCq90R7U/eHQDkzF5eFATbC14hmyfsIb9RiFC28TOnNDeA/Kx4rNiASMtjHYrANi0bEBCIQH5SC5faWUjc+GNNpCVyxzTol7kmZNOiWKK5O1pgUzFMpoK+QZAss84mqZlUtn6gQ/nr/kdk2jnYcbSaWGG3nkf/yNPJGotzdq6GCt1hRLVGiGBsQaYJ5fiEKUK3+mNqRGaup4KoRjycC1igOQQVhwEjq0fo+lDPanxGlM7q69TSfE0eiOc/9iDtDqZrgFvOfOLYekPxn2KAIMLWRi6TvDbEhbmWdA1vKS/yG2tjsuH2OhblQzoCu1JFq/EIiXRwTlz1IfbaSMwCPK91lsQPkGV9PrJ+D3S+34tx78wzHQQOxiLj7e3TjETXMlSjcxamvGGBoGheaLqWlzcUys7BTv6nsX2OE3bn/vl1PTAUQWU5kN96si0aI2NiIgJCxT78sLTgvH8rHO63iUEiaXDlY8QzT/um0kLgNTvFMleo0PeOr7v9lHSqlnRLQNpcU4ghSuXs22nJHhsA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(396003)(366004)(39860400002)(376002)(136003)(346002)(451199015)(6506007)(86362001)(9686003)(66946007)(8936002)(41300700001)(26005)(8676002)(4326008)(66476007)(478600001)(6666004)(316002)(6486002)(6916009)(82960400001)(38100700002)(83380400001)(54906003)(2906002)(7416002)(6512007)(5660300002)(66556008)(186003)(33716001)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0FEb3hzd3hRUkw3N2VjM3Z3S0pLQ0wxVG90TW9nK2p3ZHJzRk5nM2JnZWRO?= =?utf-8?B?T0gxRlNwM0NNWStoWDA2QnpoeDcySHRqQ25BNThhKzYxTmlmTWxyRXZ5RDA2?= =?utf-8?B?YjRmOHkxMzhSckZPWk42aVFUV291eDl4U0hEc1U3WTRkcG1ZNUxxT2I1RVJN?= =?utf-8?B?STJaR0E2Mmg3S1FmcXBpMHBPK2dxSmZkMWRreVI4amRJQUxrV0w3TXNiZUNt?= =?utf-8?B?L3p6eEhDc0hQVkZBTFVnUmIyQ2orcDliZlh5ZTlYTTBNY2JtT2FoN0pBN215?= =?utf-8?B?VzhqdEJTVlp0WGRLcERxU0Q4TnFkbGxadlFXYnY4TVhoUEJDdjdSNU9mQ1dh?= =?utf-8?B?d2hmdXd2aEs5ekJnSnRia0dsemVGdVNVMkZXY2haNlVUWFlGL1BxYlZlRnNp?= =?utf-8?B?WENvSUFaWVB2YjJkTTd3Q2RBVW50RVlJeGtTcnBhUGZJakUvelgvQUFyYWxv?= =?utf-8?B?cERndG9XUmNJYldCdEY4N0JDK0xHcmdURlpaaE9UUG1KbUwyUWNNQ2JCYWEx?= =?utf-8?B?M2w1ZmdrRGFEUlBpN2syRkNoQm5KVW91RUFGRUV1dGs3ZzNFQ0c2RGVJTXlE?= =?utf-8?B?b05ZQ0ZBUGhkckpTcWdhNVQ4cy81ZlBicmdadE16cnlPeWl6OW5mSFQxOTVw?= =?utf-8?B?cEVaaCt3dEtqN1U2S0plZ3BUWDhkRWZPaGhqSzRZZTFlbFM0TDVuRUxCclRt?= =?utf-8?B?NUhxWkhQTVpPUGVwcEtSeDBIRmllUVNvNVRpbEJLQVZPUTBUNk02a01IblFZ?= =?utf-8?B?cGo4N1JpUDRRVXptT3g2UUMra1IxaFJWV08wVUZRN2JCNzFJLytkM0l6bGor?= =?utf-8?B?WDZGWnRYSFUrNnZMNVVVaDNkbnFtQkllbWZ0VlJDZEpROFpBckgycitxb1pV?= =?utf-8?B?VmRvOXhFTC9ac25Wclc0amVJOTJRUVFLMTBjUEdJTURKdlJhVUovR3M1aXZE?= =?utf-8?B?TEZCQ0RMaFdKZHUzNG9DRUVYSEYycENuaGJDYlJRVDRWN3FnRXlMcG1rMXFx?= =?utf-8?B?cmZJeEJPS0UwbVBkYi9YUU5Zd1FRcGg3dHE4ZUJSdlVCMU9oU200TkxncUlN?= =?utf-8?B?ampxYnRwUjZyREl3Vmw2KzN2RENkN2dYdFVPdTRNRzlHaGcxNmExS0NTa0V0?= =?utf-8?B?STIzN3dmY3R3ei8vR3A1bUhKd1IwbjJ1dmxja2dDZmlvZ0dvTFNCdVdkVGgz?= =?utf-8?B?Qk5JQ2wvajhRczR3SnJmanozMDhwSUV1YlhRZXFNOEtIcGgxaVZzSEg2RHZw?= =?utf-8?B?WUJ5UGJnRWtRZ3BTV1pQVjRZeXpYM3lPWFZzT3BrSk1STlQ1VVJodXIzOU5E?= =?utf-8?B?L2RPV0dUTTdwSGw5TW55MUlORlZkOG02Ly9tcXlpRi8rUW1hYzdVbm53eElF?= =?utf-8?B?dTZySnBMdVdoK3VOTGxLT2FlVENCdTJMbmkrSWVSaDZjQlpQRTZTSWVUYWlU?= =?utf-8?B?SEVRU2JIWG9WWGVOWm42cGdyRTJ2SS8wK1pydGVGNmFuZzRjajR1NXdnYlpk?= =?utf-8?B?YStyQ0l4Y2VwU2lYZjd4RDBIL3pwTjYwWmdxUTduWWxKcEszaE9TazZUWEhU?= =?utf-8?B?c3V3RzJobFNyclpyaDR5cm5zTEFzQUh3dkNhOTRkYzNWUkh5SWoxS2h2eUVv?= =?utf-8?B?ajFtSWtuOU9WekJlM3ZiQVl2NzJYM21Bc1QzVWM0STVwY09PUVRDWENWbXFT?= =?utf-8?B?cjliTUQ2ZlY4TDlDYUZGc1l0R1hNS05OVFhNVFYzU3VoNTdzZjlZcVREZExs?= =?utf-8?B?UllnbnJsYnhjNFFORUJ3enhMMEtBMFY1aXpKeU84OVVXQXFJRnpESDVRQlZl?= =?utf-8?B?Q2dqRHNScWozUmxiN2RXL3NKZnJRMXhrRXNyM0s1blBNam0zNDFFc21WOFFJ?= =?utf-8?B?dHJkdWMySTFwV2Q1eFNYZTdJVVdRYnBaMklsc2lLdEFRcmRzbjc0S2c0bXFL?= =?utf-8?B?L25ISG9SRGV1eDJFdTZvMmJxV2N3eis2VnFkTjFQOFZOWS8vNHdRR3Vhc1c1?= =?utf-8?B?VUhIS1NJbm1McS85d1BMR2QxN1ZHN2FjdUJ4U2U1dDNINExFTlpCTTM0TW9p?= =?utf-8?B?cFZLazZKZm13N2FETmhmZnpSbG11T0tMMHI1S1F1L1VlazNyV2xTajF6dVlC?= =?utf-8?Q?wlFkFsIIcDYuTqlryEjVvVZt/?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?SXJnclNNamoxUCthZDNsUXBmVTB5TlVlQnFDQlBwS3J6NjZ6K0lNMlpGc3Rs?= =?utf-8?B?MmRZcjNqajFOemo5eGRLWHpNa1BSNXRBTy9SVDRBWkFhSlh1Z25IeWNJLzZW?= =?utf-8?B?SEpqM3VQUkg5RUg4ZHRmT2ZJK1VlVlJBTTRzSzNkc0F5YTNtNEswaEU2alpS?= =?utf-8?B?RVRtTWQ4Z3h0V3R3UllnNFc2ZnN6aDNLem0ySlQ1VFZWWjVxS2IveXo0UklC?= =?utf-8?B?Y3prVWlNeDhpOEVrUEYrM0t0RC9NNGdIeHg5alNQVFZENTFOZ1ZMdGFhcGV0?= =?utf-8?B?SnVZVmtPM0o0dFpvUmpDV25HbXpFUGFrdjVLS1JVRDY3SWFWTkp5ZXptUlVj?= =?utf-8?B?ZVVOZ2htcDdrT0NhdCtqUWIwdDE3SWx3NnV4Z2ViZExSUm93a3FMWnJmczVo?= =?utf-8?B?bCs4YWxMdWRXR2ZiMWRoSFVDL1daMTh3TjJnYW1DS0RxNWxaZndsNC8xK0Js?= =?utf-8?B?ZUwrcEU1OUZWZXE2MllXS0JhY0ZDdkJyL3pRTzl0R1FoK1VJTFdHTlM2Nmdn?= =?utf-8?B?YnplckJYSmdrTEFZN0xOdWFML0Y3cWlzeFNNdVF5YmpBOW43RXhTRnA0Zm5M?= =?utf-8?B?dnNVREFxaTJuSkVDQ0ZMd1g5akczZU1IbXBlck1NWGJMcVlRbFArV2RhYmMw?= =?utf-8?B?TGtSS2labHVBcWtSbXJNM200TVJuUHd1RUF2WU1Rc2VIYUxxKzNxSlNYb0R4?= =?utf-8?B?SDF3N3Q3U2lrSmZmRjR2WGFLU2oraGJzd2ZmOTJRNmNPRGZCTWFBUlhaVnJa?= =?utf-8?B?ZHRzTzU5WUNpZSsyeGZQdjNaR3E2Rk9MUVlabzF3MDg1ZDNWNDk4dFkzWVpD?= =?utf-8?B?VFRTSk56WktsRmpuSVBrOHNrOVJiT2tKSWJQNFZKREFQbXppZkRiTjhtN1hR?= =?utf-8?B?aXhBdkFzV3pvNytnbXhIcy9DT0p0TmxYb3lyV1daKzd0a2JYeFdzcUFRZmZW?= =?utf-8?B?c2MxY0dadjNzdjhLc3ZjSFpGVVhxUnZwOGhOL3dMMld0b0VYYlVuaS9GWW12?= =?utf-8?B?dWg1TVNMTGt1aUpZdjBqdDV4dk5JTGlpT3BhVVhERVhNdHFKTVltMDg0L1cy?= =?utf-8?B?R083T2lVZ2VlbXdZVG5Fd0Z5alNBMlVuLy9SL01uR2diRW9WMGVnNm04WDFY?= =?utf-8?B?eW1XY0tydkVBL3ZMazdibklMWm1oUUptSTBzdi9DRDM2NVBTMnFLTkpscTZq?= =?utf-8?B?LzhqMzZFT3lzSU9zMk9XblhLTGwzSWN3R3RYK0pIZy8rbkxvL2EvRXYzSGdy?= =?utf-8?B?MjhVdDVWdEN4NHpoV0I1MVN6VWZsUEhIV0tzRXp1OE9KSnlzV21TYzYveUZU?= =?utf-8?B?OEpuVm1CTHh2M0xmbmtIQTNtNHdrWHVrNkI4Vy9TRDQvUW8vWGk3MHUvVURY?= =?utf-8?B?Y1o0YkkrY3dMTjdEZkg4V3FRUmhoMVdnVjRDdnV4aTYzb2dnWE9rcFFscUJr?= =?utf-8?B?d2d2RXhibHJJTmJMSUFLMVY0Vmk2a2JoWEVFWkhnVGdwTWV1aDNRQXY3cUM1?= =?utf-8?Q?08gSesWchXBN/CujSB2xTuVK+JF?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2a09d31-8abe-4e4c-9fb5-08dad2b4ec2b X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 09:26:12.7387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OW5FLAOYTNltQyc9kLF10SYk0a+UDEwl0NE8tLjVFsj+1cqAzVBEeNai075jRGkvp9WEFp1r3dLrSDtYrv2LwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4929 On Tue, Nov 29, 2022 at 02:12:10PM -0800, Stefano Stabellini wrote: > On Tue, 29 Nov 2022, Roger Pau Monne wrote: > > The hvc machinery registers both a console and a tty device based on > > the hv ops provided by the specific implementation. Those two > > interfaces however have different locks, and there's no single locks > > that's shared between the tty and the console implementations, hence > > the driver needs to protect itself against concurrent accesses. > > Otherwise concurrent calls using the split interfaces are likely to > > corrupt the ring indexes, leaving the console unusable. > > > > Introduce a lock to xencons_info to serialize accesses to the shared > > ring. This is only required when using the shared memory console, > > concurrent accesses to the hypercall based console implementation are > > not an issue. > > > > Note the conditional logic in domU_read_console() is slightly modified > > so the notify_daemon() call can be done outside of the locked region: > > it's an hypercall and there's no need for it to be done with the lock > > held. > > > > Fixes: b536b4b96230 ('xen: use the hvc console infrastructure for Xen console') > > Signed-off-by: Roger Pau Monné > > --- > > While the write handler (domU_write_console()) is used by both the > > console and the tty ops, that's not the case for the read side > > (domU_read_console()). It's not obvious to me whether we could get > > concurrent poll calls from the poll_get_char tty hook, hence stay on > > the safe side also serialize read accesses in domU_read_console(). > > I think domU_read_console doesn't need it. struct hv_ops and struct > console are both already locked although independently locked. > > I think we shouldn't add an unrequired lock there. Not all accesses are done using the tty lock. There's a path using tty_find_polling_driver() in kgdboc.c that directly calls into the ->poll_get_char() hook without any locks apparently taken. > > > --- > > drivers/tty/hvc/hvc_xen.c | 16 ++++++++++++++-- > > 1 file changed, 14 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c > > index 7c23112dc923..d65741983837 100644 > > --- a/drivers/tty/hvc/hvc_xen.c > > +++ b/drivers/tty/hvc/hvc_xen.c > > @@ -43,6 +43,7 @@ struct xencons_info { > > int irq; > > int vtermno; > > grant_ref_t gntref; > > + spinlock_t ring_lock; > > }; > > > > static LIST_HEAD(xenconsoles); > > @@ -84,12 +85,15 @@ static int __write_console(struct xencons_info *xencons, > > XENCONS_RING_IDX cons, prod; > > struct xencons_interface *intf = xencons->intf; > > int sent = 0; > > + unsigned long flags; > > > > + spin_lock_irqsave(&xencons->ring_lock, flags); > > cons = intf->out_cons; > > prod = intf->out_prod; > > mb(); /* update queue values before going on */ > > > > if ((prod - cons) > sizeof(intf->out)) { > > + spin_unlock_irqrestore(&xencons->ring_lock, flags); > > pr_err_once("xencons: Illegal ring page indices"); > > return -EINVAL; > > } > > @@ -99,6 +103,7 @@ static int __write_console(struct xencons_info *xencons, > > > > wmb(); /* write ring before updating pointer */ > > intf->out_prod = prod; > > + spin_unlock_irqrestore(&xencons->ring_lock, flags); > > > > if (sent) > > notify_daemon(xencons); > > @@ -141,16 +146,19 @@ static int domU_read_console(uint32_t vtermno, char *buf, int len) > > int recv = 0; > > struct xencons_info *xencons = vtermno_to_xencons(vtermno); > > unsigned int eoiflag = 0; > > + unsigned long flags; > > > > if (xencons == NULL) > > return -EINVAL; > > intf = xencons->intf; > > > > + spin_lock_irqsave(&xencons->ring_lock, flags); > > cons = intf->in_cons; > > prod = intf->in_prod; > > mb(); /* get pointers before reading ring */ > > > > if ((prod - cons) > sizeof(intf->in)) { > > + spin_unlock_irqrestore(&xencons->ring_lock, flags); > > pr_err_once("xencons: Illegal ring page indices"); > > return -EINVAL; > > } > > @@ -174,10 +182,13 @@ static int domU_read_console(uint32_t vtermno, char *buf, int len) > > xencons->out_cons = intf->out_cons; > > xencons->out_cons_same = 0; > > } > > + if (!recv && xencons->out_cons_same++ > 1) { > > + eoiflag = XEN_EOI_FLAG_SPURIOUS; > > + } > > + spin_unlock_irqrestore(&xencons->ring_lock, flags); > > + > > if (recv) { > > notify_daemon(xencons); > > - } else if (xencons->out_cons_same++ > 1) { > > - eoiflag = XEN_EOI_FLAG_SPURIOUS; > > } > > > > xen_irq_lateeoi(xencons->irq, eoiflag); > > @@ -576,6 +587,7 @@ static int __init xen_hvc_init(void) > > > > info = vtermno_to_xencons(HVC_COOKIE); > > info->irq = bind_evtchn_to_irq_lateeoi(info->evtchn); > > + spin_lock_init(&info->ring_lock); > > Don't we also need a call to spin_lock_init in xencons_connect_backend > and xen_cons_init and xenboot_console_setup ? Not in xencons_connect_backend(), as that's called on resume. Will fix the missing lock init, didn't realize the console init paths are so convoluted. Early PV console on the shared ring worked fine, I wonder why that didn't explode. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Nov 30 09:35:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 09:35:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449784.706724 (Exim 4.92) (envelope-from ) id 1p0JUN-0007yc-To; Wed, 30 Nov 2022 09:34:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449784.706724; Wed, 30 Nov 2022 09:34:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0JUN-0007yV-R5; Wed, 30 Nov 2022 09:34:47 +0000 Received: by outflank-mailman (input) for mailman id 449784; Wed, 30 Nov 2022 09:34:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0JUM-0007yP-Vp for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 09:34:47 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2060e.outbound.protection.outlook.com [2a01:111:f400:fe13::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 38e88168-7092-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 10:34:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8535.eurprd04.prod.outlook.com (2603:10a6:10:2d6::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Wed, 30 Nov 2022 09:34:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 09:34:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38e88168-7092-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QEBAIyzbkqJUNUb/Yh1urlHZcevN+g0usnzuRZ+YU1pKFoDfIR+uFGCsSblw9mmqhiZmTvlZd9jLFf/bSI8FiSfVwIp8MIvxpyF5qLwcfRWkRiN8Z1pxQNDMJtYL2FVCWLo+4xbsPkcxpLVL2JF5H28jFZALi8v+U6PYY6co7S7eiLyS78nwVM/rSpz7XKeuBXaz5+NxqTEYImVSJPIw7D+B0299uioDVqOufIABXmgvxqhqmudro0N+fui2jWKBjcSx6AWkFvUTatnWy/AZO/MRLCpATPJR1GLy7Relomzxd3D9RMKih2f7bjTD64PLZsVXe5VprRePfW9Fh+pddQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P7OasLtRjEnTQ4HsfFqZktftoC39064067NPmSIxSYY=; b=F+efMSguwg6LtYDyeX0LPNpHwzbluiWaTYRJuaxrLpGDB1KRTpNJKBtyVTX89EcZBby+uG7E40FHmD2tbnO9rHWL3HUHMLmXCcCR0Z2LV7VJn5zPqsoS/TFJRNhbI9lEMKYc5ndeBkFADfc8Sa3IwXZpqB9iprNzVqTz2vhPyx3DxTKu+mYGFBZsXTB8TItYwEXKzUiEjJAwaXua58nMWovSRGRLvEdkrUZFXOobGCYZeT8vGh31PDEbVjX54+zXcLCC/JKG4TXFGWbxqVjS5TsRFIszgGh4CGkzBQkLnxMU7ZmV9lpw4dhyon4C9fxVy2ptVjaOb4UEQGziTRy9wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P7OasLtRjEnTQ4HsfFqZktftoC39064067NPmSIxSYY=; b=Uhyq2ix1uznqp9c3leUJoJAYS0vF3rjm4+W2RTe0LrZl08Is/FooWE/+B95GhLlmadXwoLi8a5NjzfXP1Mfmx7tT2qy9nXpefcTjUs6kE0OzD4t5Cqn6SCkwTGLTzELaGTlq5VgZQ+pEbQCb04mMvQlhD5p43b1syRKBM+kus/aWO2DDv0xF9EOVBHohSguXN5aEXw9TCgjagkqt0Z2OMgU2t/kRHnGWFr/GonmHe7g4gtl91SPRGK6nHgMwJ4kFtWWy0H2B0g/Nw3Yzra9c5YSv27ZBmR8sq6rdBPYzAW/q7ZJdQGJINyVU1jq/fCtfmWXQQgXHMKM4d0nV4mHOIQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8d8f8c11-6ca5-5770-989c-704f76436cc4@suse.com> Date: Wed, 30 Nov 2022 10:34:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] hvc/xen: prevent concurrent accesses to the shared ring Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Greg Kroah-Hartman , Jiri Slaby , Juergen Gross , Boris Ostrovsky , Olof Johansson , Ingo Molnar , Chris Wright , linuxppc-dev@lists.ozlabs.org, Stefano Stabellini References: <20221129120107.2942-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8535:EE_ X-MS-Office365-Filtering-Correlation-Id: 74c3cc18-2753-4f49-67d2-08dad2b61c9c X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H3JLn9U9+sNh3gFuknwzvx2PhlFNSPTBCeu05NyMAPvLjax1hsbevh9KZQu8VFG8EqzgZti0wXNGJLEcjrDESdWvQnXT+Z0ZNmqFbsM/1XaA1gRXEjjcyA5aijMgHJxgZ3gkEonJjnR2MEpR9e+3AToAd2c0W8A/z92nEEusCwcBchikYdimJF7YnoPUmwOA86MPCm0/yNIZuMFSk26cOupOCQIYrbJ17syTBzcI9C/sCbGbzmZwskn3alD4qeomq6ybfi6qv5InheyOpy0v7lMqp9c0cVSmGrYXpRyCV9+uL0JiEoTd4OEgcabTAK2lkRH0oJVmh9yeKU6VD5kBaq7mh1GY23NzcNAifo5j4pvwAU/GeHVHMXVLa1ezNHHbWwGqrkG8Igd4gc926pIQVYtDEWDNAxUenB263goVXKH7jPyF6Xq7Gcz36yHYGHA79kDQf12k1esQtEq8/UC55atK0efCCmQix499c0qY4LPJGemMOWvQUg7hbDChN17voaDG4qAKL/pKSHusIznmddrIQmrC0Ly1cW74UkrLw2Kozoj6RqXT/6XX4YamLaFiJIiF+Fc6jgxGa4VgQRgSOPKO8aSW64A8VGJ3ahh03JQA+MKME+UGMsg3vZ1rRz+PY2946mfLfy1JyvEHTE6P8VopjfX6Fd+xVTAu9K4OgXcPo4YZy01lOXUt1pZzcQBiZF1YDho7glZtqidb26xRMzVtoB897pIH7zD98YViYAo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(39860400002)(346002)(376002)(136003)(451199015)(31696002)(6512007)(26005)(316002)(6506007)(54906003)(8936002)(86362001)(66946007)(2616005)(36756003)(5660300002)(8676002)(6916009)(7416002)(4326008)(66556008)(66476007)(41300700001)(38100700002)(53546011)(6486002)(478600001)(186003)(31686004)(2906002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEtqby9vZDZSK3hCQ3RSendydkZLcGdPUDVOZk1lbUNVc09Na1hMOXB3TjJS?= =?utf-8?B?YmYyL2pMN1ZtYkFsdkwxVG1ERDFFa1pLVFQrWERrMmVFQ3QrMFBYaEpCcFM4?= =?utf-8?B?cjlXNVRudmg4YW9YTXk1WDRpdmgwZ3pCSUZBQ2g0NkZkcnBPWFVmbStaMWRt?= =?utf-8?B?U05mK2RHc216V0ZjZlJsaGkvL2NXSjRzVHE4NG9vZURwemtITGRUa2t4UmdX?= =?utf-8?B?OGQzRXJLVHRKWk9zRmNCdkZ0bkw0M0E0S3JSRnkwSk54OHo3bEs5Z3lBZnlz?= =?utf-8?B?ZjByNkEwbmN0WWRhT2RBUUNGejZDaWdVU3IwQUczZUhsZUtIdFRocWdiUUN1?= =?utf-8?B?dGk2eUI3MWx6c0FmandVblY1Q0ZieXA0S25JejdGamRVS2czVk9Ud1NFaEJi?= =?utf-8?B?YVl5c1U2TCtOakVEZW4yNVM3bmdpQVlpV1Z6QnBNRUFsRmFyOEJnOUZVYTQ1?= =?utf-8?B?T0FLRngydzlKUlJkVGlQcFpnV2JMQURJVUhBWnNOWWM1ekNEaU1vckFwTkVF?= =?utf-8?B?SmU3SHdEaU1vL1NWUG83Ykc3WHYxYWtXVDJLU0c5SkJGdWFKL3FZcmZGNG01?= =?utf-8?B?UkZzaWRqR1dERW5yZWhDUk10M3hFVk44T2tEWENtZmRQa29qZ1l1alI4cUlw?= =?utf-8?B?aWxaMFNCYUNDam1WaVh5bFhJK1JwYzZMQ1ZRcHptalQ5cmRLeEEvYXVxbTJ4?= =?utf-8?B?ZGVRRnNvemE4SEFXZ1ZMUzRvakxiTWtMWE1GY29yK1VJKzQ5RklNUytKdWRF?= =?utf-8?B?R2RVMHY4WWc4R3plQ1NnYXBOT0YyWW9KN2lUT2FESXRJOWE5cWxOTlNpUGts?= =?utf-8?B?TW9TQythcDVsZGE3b05qU0pxY0k0YzRoNCt6VkRTZTYrSUE2NmhYSEV3SW1W?= =?utf-8?B?cGt3K2F3L3N0UUlzbE82R2Z4ZzBiWXdueHZyMllITTkyeW91SkFnbTFETE1U?= =?utf-8?B?b0ZjL2NBY1diV1RMTi9xUDYzdCtHVmVmNWlRRmppZDlJbERtbzdrMXFPNzVR?= =?utf-8?B?eUFGWHZMVi8rRUF5S0xYbzZ0djEzUjhTbVhvZ1IwRzAySGpBeXhiMVgyd0hq?= =?utf-8?B?bjhqZVEvR2lYMGE1aXV6akVNNW9CWGN1WUViTVFrRGtpOE9odlZ5MWtwTko2?= =?utf-8?B?dktqWVk5QURPQkkvdlJoMGpmU1lZSy9kdzgwMHpBZTdyQ1ovbFpYNm1zMWpo?= =?utf-8?B?cDZOZzZvdmFaWlBGVHUxbHRIRGNZUktVdmh3b1lCeFBIMnFTZ1BtY3pXaWd6?= =?utf-8?B?QTFZb2xZM054NHpmYTdpanNCZXNVakhSYmllaUhTQ1V2STkvcTFvYjN5dnNX?= =?utf-8?B?SjZhQmRSR29Tb2VRVXM5UVA4VFIxeU9SYXkrWEVpell3em9DeUpSVDd1QURL?= =?utf-8?B?dnJxZDBuVWwvcWYxaGxZMm1WOWplM1Jjd2NnQW0zdlp1cE5CcnhIVTV3RG85?= =?utf-8?B?M25VQVRzWnNqeGQvNnhpVmNwanBXejF2SThXUGJsaTU1QUVFMy9xdmt1UHFz?= =?utf-8?B?WlpwT1Z1RVdPd0kyNURCaGVHR1EyVy8yUHVWanZvQ1pwdFNWUlJCK2NtVlVr?= =?utf-8?B?U3g5M1dyczdrWFliTi9NUlFRRnUrVmpZUEdsTldQaXVTcmg1azM5WlBYd0J3?= =?utf-8?B?VTZCem93My9xMGthMTBjeTJtN1FBanNtVUZrN1ArMzFaanRaeGp0ejJhL2NV?= =?utf-8?B?VDc5T0wwMVd6aGxBN2NyanlkbFdNcmtKTFBuQTFIaER4dUFodTROQ0pQUGEy?= =?utf-8?B?SzlId1IyTjVMZ21sdmhxblcreU1Xbjd5MUtJNU02UWtObURUaU85d3JLNjVE?= =?utf-8?B?S3pHeGZFUENPeTN5Wm1MSDBIRDJWYVVNWjl2LzV0WFQ1T0NibU4wV01zYTdF?= =?utf-8?B?dVFIMkprU3FJa2VEeHptUWl6bTYrN3Y1ZU1TbmpCb1haS3g3RDJDTXBLbFZw?= =?utf-8?B?bmVLK2FyckxxbmZqUnNXTzNxVFh3NFprcHpZZHJBbk9vdklGK3F5N0I5ZDVG?= =?utf-8?B?OC9XeEFrOEZWamV3dHdKeFp3bGF2SVYxSGlWaEhYYmZHY0JTYitFTE5EZmRp?= =?utf-8?B?ZXRnVjdGdWc1KzRSanBBK1E1QlJwY3hFN0ZPMnRwdTJta3dRZHNzQTcvRmtF?= =?utf-8?Q?z/IdkW6c5+RN5ZytWV4IF+HjQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74c3cc18-2753-4f49-67d2-08dad2b61c9c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 09:34:43.3801 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4LVrTgK2wnni4jBSNaCsK7u25Wt84dlMzymOvuL1FRnZyBfDknM05VZqulWqpqZu/MSgmweHQ7HePkM0XxZ37A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8535 On 30.11.2022 10:26, Roger Pau Monné wrote: > On Tue, Nov 29, 2022 at 02:12:10PM -0800, Stefano Stabellini wrote: >> On Tue, 29 Nov 2022, Roger Pau Monne wrote: >>> The hvc machinery registers both a console and a tty device based on >>> the hv ops provided by the specific implementation. Those two >>> interfaces however have different locks, and there's no single locks >>> that's shared between the tty and the console implementations, hence >>> the driver needs to protect itself against concurrent accesses. >>> Otherwise concurrent calls using the split interfaces are likely to >>> corrupt the ring indexes, leaving the console unusable. >>> >>> Introduce a lock to xencons_info to serialize accesses to the shared >>> ring. This is only required when using the shared memory console, >>> concurrent accesses to the hypercall based console implementation are >>> not an issue. >>> >>> Note the conditional logic in domU_read_console() is slightly modified >>> so the notify_daemon() call can be done outside of the locked region: >>> it's an hypercall and there's no need for it to be done with the lock >>> held. >>> >>> Fixes: b536b4b96230 ('xen: use the hvc console infrastructure for Xen console') >>> Signed-off-by: Roger Pau Monné >>> --- >>> While the write handler (domU_write_console()) is used by both the >>> console and the tty ops, that's not the case for the read side >>> (domU_read_console()). It's not obvious to me whether we could get >>> concurrent poll calls from the poll_get_char tty hook, hence stay on >>> the safe side also serialize read accesses in domU_read_console(). >> >> I think domU_read_console doesn't need it. struct hv_ops and struct >> console are both already locked although independently locked. >> >> I think we shouldn't add an unrequired lock there. > > Not all accesses are done using the tty lock. There's a path using > tty_find_polling_driver() in kgdboc.c that directly calls into the > ->poll_get_char() hook without any locks apparently taken. Simply by the name of the file I'm inclined to say that debugger code not respecting locks may be kind of intentional (but would then need to be accompanied by certain other precautions there). Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 30 10:11:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 10:11:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449789.706736 (Exim 4.92) (envelope-from ) id 1p0K3E-0004Oc-My; Wed, 30 Nov 2022 10:10:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449789.706736; Wed, 30 Nov 2022 10:10:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0K3E-0004OV-K9; Wed, 30 Nov 2022 10:10:48 +0000 Received: by outflank-mailman (input) for mailman id 449789; Wed, 30 Nov 2022 10:10:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0K3D-0004OP-F4 for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 10:10:47 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f20bcbd-7097-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 11:10:44 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Nov 2022 05:10:39 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BY5PR03MB4917.namprd03.prod.outlook.com (2603:10b6:a03:1e9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 10:10:37 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%9]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 10:10:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f20bcbd-7097-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669803044; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=UH4or9v6W4G1BQ9Ha9K2Tded3QFAg1mp3HDjiohAk/I=; b=Fl03S+5fFrEHgc1YgqDogNT1TgDH1wf+9vdUwO85H39kOH6k5REz1VoF COwjHj98asMCL6VILFxRYgCmu0blc7e1u7N7NgK7KqTil0597Rq/Ck7db eJv08B7tdhxxrRLOgnLj5r9MGX7nHxdwPfd6zk3izG3BCu2RBRZanYsiw A=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 85844826 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:PzltvqM0wtnI1k/vrR3el8FynXyQoLVcMsEvi/4bfWQNrUok3z1Vy mdOC22Caa7cazehKN9/atm/9h4BuZ+AmIcwHAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5QRmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uYqBEVVx aFGEmBTcD+BtfOb5e6eVcA506zPLOGzVG8ekldJ6GiASNwAEdXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PpxujaCpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+toi/82rOfx32TtIQ6E7aq9KNXgH+v9jZKNg8SDVC+naeIlRvrMz5YA wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4F+w89RHIyafO5QudLnYLQyQHa9E8ssIyAzsw2 Tehj97vQDBirrCRYXac7auP6yO/PzAPKm0PbjNCShEKi/Hsuow8jRLnStdlDb67icDzFTjsw jeM6i8kiN07j88R1r6/9FrWqzGhvJ7ESkgy/Aq/dmCq9ARif6a+epelr1Pc6J5oJoGDT0LHu 2MYgc+A9+MfJZaXnSeJTaMGG7TBz/GBNzP0hV9/GJxn8Tmxk1amfIZf5xlzIFtkdMYZERfiY FXSohx5/5hOJz6xaqsxZJi+Y+wuzK79Bcz9XbXYY8RmZplqaBTB+zNqbESLmWf3nyAEirojM J2WdcKtC3cyCql9yjeyAeAH3tcWKjsWwGrSQdXxyUSh2L/HPXqNE+5bYR2Jc/wz676CrEPN6 dFDOsCWyhJZFurjfi3Q9o1VJlcPRZQmOa3LRwVsXrbrCmJb9KsJUpc9HZtJl1RZoplo IronPort-HdrOrdr: A9a23:JXa0zK8mLkkVg0jRR8huk+D1I+orL9Y04lQ7vn2ZESYlC/Bw5P rEoB1773XJYVMqNU3I9urwXZVoLUmzyXcx2/h2AV7AZniahILLFvAH0WKK+VSJd0LDH6xmpM BdmsNFaOEYeGIK7/oSlzPIcOrIruPnzEniv5an854kd3AQV0hP1XYCNjqm X-IronPort-AV: E=Sophos;i="5.96,206,1665460800"; d="scan'208";a="85844826" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CZSxt/gR2W64BWQZ5+oqJDk0093zuxW+2EKC8/QLcNfPWHu/dyU3dIe2D8cjYiZEmLwOzl/fq6SWEfbTkUtuI6mzAWUsIdym2RSmw30SWfcdyCBSVNPxY7ozbVxQrH3EJrUuXB0l/UZQku70IF2UUDeq75zi0P375wyjNxNnCF3yDw7T2FqDyx/W5CHUiMnsxlMSiGjGeyDlqp8HUzTD2k85AeZXuN1HvxSfmE5ctUQIz8U/fd1pp00Yuq1ZFHmOM6LK9qMheSRgCW+4ibdlMLg8NXWLdZxnazDIgnkDkckhaIGGBzSxfP08gY1h6Y3zrnPRMdiyCa1KG3qYSiUNfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DTzxxCZ+Kq9uX93zQZa8I0RFtDAt2genjXSVBUCq8JI=; b=jW14PKRD+ei8o+EnK+KZ8NJ61DMQedOBQl6RMMV5aeiYgPFhnWIrmldy4Svk6o3gVCV86yZrstAwBd1VhZIJLDEE0iIhh+BxPuLtKpL+Mo6pV6q2TugLDanQHZvX1JM9uZWFzWjjO5wiq82MIGUqTvOrO34muTwMKkX4rvNbQS18xYk0fsWKDImHQKargVJegNa6r8RWjm4HsyOzV2x0Gvdh5dcpva0faCUYUfpU0sBR7USm/wiCo8nsNyLV3IR0BbW/Lr/tjs1HDfDwrJRN73w+aCVGkq8/21W9qmnK+9I4Ne08ZmT4gWvtC7dn0UE/VOI268bTaX5BuVOa4pLOjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DTzxxCZ+Kq9uX93zQZa8I0RFtDAt2genjXSVBUCq8JI=; b=Q2yUYqW5+SrMrgen2TCJu2hiqqgb54ILAY5gwnz82mE6vslKuhhr3kB2WTNPTgUD0oCJ1Il/pqsgePvQBmxhhhJGxaLWHZi3loxxcMij+bz2sd8BThjEvE9tGY3eG6rCixW71t/nJFAWeBjvhu+gdZ/XUZmaCIKZ2ZHMsGAoLVQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 30 Nov 2022 11:10:32 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Greg Kroah-Hartman , Jiri Slaby , Juergen Gross , Boris Ostrovsky , Olof Johansson , Ingo Molnar , Chris Wright , linuxppc-dev@lists.ozlabs.org, Stefano Stabellini Subject: Re: [PATCH] hvc/xen: prevent concurrent accesses to the shared ring Message-ID: References: <20221129120107.2942-1-roger.pau@citrix.com> <8d8f8c11-6ca5-5770-989c-704f76436cc4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8d8f8c11-6ca5-5770-989c-704f76436cc4@suse.com> X-ClientProxiedBy: LO4P123CA0684.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::17) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BY5PR03MB4917:EE_ X-MS-Office365-Filtering-Correlation-Id: 218b030f-6491-4270-4bd4-08dad2bb2035 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iZII7XY7lkWei01KyrpuVq55aGJ9PG2UK+JdyIfHANucu7yM9RM5Xq2llq2ezsRVTerZkrELJ+TKTff90SYqEZlz321mrzrIUcFP7mZT6gFEvELfmYHP5elGzNLhOwstHFy45um8Z/XaLI6wMqsTv2+WwTSKvwsYKas8BMxUoEKGN7wuq5MjgFs/8ZqJLt+BNQqy0Sd8xHl9K5zCPvTZg0AFh59+YBXq7lNAhWvoL18UIFopI0iWW6bbpJdYFXSQSaqDn2lRUhjoENTi/qGyMScd1qZl63tfdQrZZqI3V+07jgJPhjwYnHFK/HJKijMMZ3kQLD0rbgUXDwTu5acEgypbPgeIaN/d6XZa5h2oqlwlpqoLoHgL+NaP2nMjBnp6sqbNsqoUsTjW9RoCEeGN3OvvwvHUCcQPG4RyXX8GXLe6HrMN+/Xoradi64VQY5Oyeh0SPWaPytLfhpq4iJcxb4xg7CF93+beEIKw4d7V2OQv8CVed7hU7AOsFaF/zMuKywXwMfifX8P42b1KzKaRf/qN6ImxtWzC1bSqpbPsDAWw89RNqIP0pPvZleEK/oefQ+vhUePxMW0VI5tHeBTtGQaXeH+MIKPdFhlXULnSU/S1Up6TGwxWOtuZz9hTh4nbtdznL8krzTuYf02XkGxd0w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(136003)(39860400002)(346002)(376002)(396003)(366004)(451199015)(7416002)(5660300002)(33716001)(186003)(8936002)(54906003)(6916009)(26005)(6512007)(316002)(9686003)(41300700001)(66946007)(8676002)(66476007)(4326008)(85182001)(82960400001)(66556008)(38100700002)(2906002)(86362001)(83380400001)(478600001)(6506007)(6486002)(6666004)(53546011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHFZODFtY0tLcTliNDV6MFM4SkpvbkR0dVNSbXY2TmdTVHYvT3lRcVRvSWhW?= =?utf-8?B?UkkvakpTbGpPdGpRb2JpZVdIbVVxdkdTVjRtZVlCZHRRcGlyK1Jka0xMcE1a?= =?utf-8?B?dkpkcnJQckVvWHFUZFZTTDFscCtFR2p0alpRcnJoSW1Qd2JGeENocjRTSXdo?= =?utf-8?B?dVN0N0VFRVliNDBzeEdvZmRIQmhSQnZRcHIzWkE1MytlZmxacUprTmFYRzBG?= =?utf-8?B?ZERXWDRLSGNUa0NDMGV1SnRwSk8zc2xYUDVBUDhoMXFXZWRNNTBPZTlCLzc5?= =?utf-8?B?ZnRJZzRIZG1ZVTJvd0NVb0tSRzBQOVdsWWViNUpnSGdyNEFaZC9BMkV2YlRN?= =?utf-8?B?aHNDeVhvUWFCT0hlanM5QXpFRjBFamppeVllanhDNUlXWHIxNXZaK1M0OTNh?= =?utf-8?B?MnJtTmZyYmpmem0yd1FaOEpQU1VoWGdVRC9DOHlRUExpeHcxY0h0UnNRd2x1?= =?utf-8?B?NFBsZVRHZFh6eDBCdjFZL0kzSFZoMWNLQ1E1a1ZvRFJLd05sN1BMSVpYSEJZ?= =?utf-8?B?Q2s5VUZuUW45Q1loeVVxK0hiQmdTeW5MbklaOXBKbVU5eGI5ZVZoUS9rRWVO?= =?utf-8?B?L3dxN3RLMndGaG41bWRjSElxN0wxSFVDUnNQVUxaVFd6VXZYSlRnbjJBa0VZ?= =?utf-8?B?bklxdnJMZ3o0L3ZqN2toY3pVZUFNc0JpR1lxRzF4SUw0bUFCWmZDR0dicmRi?= =?utf-8?B?YUpNVlo4d0dScVlUd09mN1NpdmRyZTZ3YXp6MWFKc3RDcnZ3QzM0NitRVEpk?= =?utf-8?B?MnB1RjRYOTEzbDJDSHo2blhkTEFYZ1hxRkNuaVdXU05pWEFpMEhEdjdtSHZ3?= =?utf-8?B?dDZiQTVuYU9SUUUwaXZSNCtHd0VnZC9QY2VhTTkwN1MvaWI0R0E5bVFRSVJX?= =?utf-8?B?cm9TT1dhczIyR0ZpTTRqV29NRURJTTdSWHpkQXRiTEE4MURMcm5laXYyY0Ix?= =?utf-8?B?dGEwTkpKK3R0T0RqUWRkcU9udzA5Q0FoTlF4L3NWZjY3M0xYYStjYUxEZkV4?= =?utf-8?B?a2IyTXB0TEluVWhXUTVMOUxBM0FsbFV0dG1CeGRPV2xiMzhscnZuMk84UDV3?= =?utf-8?B?RjVzMm0zdmNYVE93UDd3all3Y1YxaUpPOU11ZkYwY1ZtWDd0TUxPZVJ4c3Jz?= =?utf-8?B?Z3JyR1J0eXUwbTR1MTRoNFhaQmFzY21kdlpUM0RZeFQ3T3VmUllkbzRUUit4?= =?utf-8?B?eHZpK3AzV29Vc3Z1K0RnNnhsL2UxQTgwbVlLSmxPMTYvalFkTlFwUlR5YjN5?= =?utf-8?B?N1VwTUJkMXVLdVVuTmhjbWhweVBEYUpBVHpnZ3pNb1hYdG1MeHNyb0xPL21I?= =?utf-8?B?cnU2ZWtWZHhseFRaazVKWDdlYW9nTTFSSEc2RXR1dzJzT3JHeWg5K1l2Nnh1?= =?utf-8?B?WDVWZmdUd3VxMUg0d0tXRzcyaTBoTkJEZW5ER2xyQzlRSzNNTnhIeVk1U2Vp?= =?utf-8?B?MjJmTm90TmkxQXpqeVlXWVpISkUvR3EwNnYvYVFweFROQWxVeFJWSTIyd29N?= =?utf-8?B?M0swMnl2bThCZ0Rkakdzb0UwTGVRYnk2VFZXY3ptRUJzbHFDbzFhRWZZQVBL?= =?utf-8?B?UG51aEt3cUFSYnVkd1VHSmNXT0lHbVhHT0FMdkVGY2JXQjVlWi9GL3hLcUc5?= =?utf-8?B?dkxLY2d0Qnc2cHlqdk93bzFIcU8wcjE3TlZueDg3S1ZteWZqeVBHc3gyeER0?= =?utf-8?B?NHlFNnZmbXVZbFZLOFB4dkRNVkV4NzJLYWF4MXBGQ210Z0JVbDBUN3VsUEpp?= =?utf-8?B?cncvM09hc1k0U21SNkM0QjN3bGdBUzM4cFFHWkFsYXdzdTI2eld2NmRwWFpy?= =?utf-8?B?YTBsdlFlU2E1WGVDSzNEVnpDZ29DQVc1ZjJ3dlV2UVBSSW1vRTcrc3BaUnJM?= =?utf-8?B?ejlaOXZKYnFYc2YzVndlWFV5cDdyVkhoaXV5a1dadTFSeHJKNGR1em91UTFX?= =?utf-8?B?QXJGN0hVRXo0S2RUcDgxVzNNQ3dEbUxBWkc4VHVXOW1Cb1NqSmozemRCeDJW?= =?utf-8?B?eVNsSk44VzZrSkJzdXFzdTdsQUhMdXRGMjVacU1RVGhIbk1uRDN0Z05HdWFn?= =?utf-8?B?NkIwNEZlSUNiKzVOTGplK0VRUjNVa1lyK3ludjFZcWhxRVBEdXlwajdmTm1O?= =?utf-8?Q?OQVPfUEDmO9aY/jVEfIwTk677?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?RGt1VjNVTFdyQ3o3a05vK1RkY29RMWNqbEdReCtWcjlHWGphVllLck11SnA3?= =?utf-8?B?bTdwYWhCSmxSNFhFOTdXK0FlUnVaeUFVa0Y2WE05NWRGUHhZdDZyZDFDeUN5?= =?utf-8?B?R2dDUlhxVE1SUjJWTkt3QVNqNDhRSkxjSDJPV2pWQ09aMUlFUXFxSFdBbXNV?= =?utf-8?B?T3ZOS09uUTR4Y0xwMThudEJaRzRsVkhnd2lEUW5GSm5yemhvTC8zUkQ4enhK?= =?utf-8?B?bEZYb1dsRC9TQ1NWQnVQdlVZR2IyVXQ1R0luUmxqeU9SUDBDTmtDR3YwWjcz?= =?utf-8?B?bDhYZVJHYVgrMEtJRld2UGx5bEc3QStTNi9oUTFZZ1YvMWE0MDlWTkplaFpp?= =?utf-8?B?amlyd1lrV1NoVmN3SWo0REpVNHpPeHFrWFgyYVBkdlU2bUhkMkw2MHpZVlpX?= =?utf-8?B?MVFKTjZrWDRvUDF0QkdjQkdaOFdkSHhWcVN3RVN5Rm1VYmdHZG45YlR1UnZD?= =?utf-8?B?VTNYZUk4UUlPRnNzTXBQU0Y0WXZhcFFkZG83S21KWU5WVWlDWlVNVVY2RHRN?= =?utf-8?B?WFo0NFNsbUM5ZXBCcWxhTTFHYjh3M3lvNUZVZlAvOEhrZ1k2cGdEWXk3RUhx?= =?utf-8?B?cjhjN0pDL0VxM1FIdFpRVTVjaVZ5RzY0a1ErRTV6dTdDU0xPRTR2MWwrbXBo?= =?utf-8?B?eXUyT29KV211cW5IVm5kV0NyZi9jY2VEMTN4WEdGK1M2NXA0OUJNWC85b3or?= =?utf-8?B?K3ZyK2ZUeUVRZGdNNmZLejRVbnVRQzBERG9ZRUM2ZHFtbGxzNE9qNFlsY0ZI?= =?utf-8?B?dXFUVFpualVxd2gyRGUzS2cxT20ydDJvOWJOTzN3ZlBOR0RiaG03QitSSm9h?= =?utf-8?B?bi9iVEwrbEdnMi9MbHR1OG9RTUpqNnlCZk9hejgwRE9wVUwvV2h1Z1ljS2tG?= =?utf-8?B?b1NOaFhnTjU5VU5YbmNLRkwwaGZCWFlnbkRrbHpxOWRDOG5RWGtDM3c4Qjh4?= =?utf-8?B?ZTFwTGlHdUZkNi9GUGhYWWdLa2luaUU3TktlbVd3RnN6T3g4RWEvVmhQYXl1?= =?utf-8?B?UGNJcVF4NFBaS3UraSt0UlBNRVlpQWlVdVVrRFhXNTBLeFhwd2tpTlNJc2Y1?= =?utf-8?B?dnpnM21tcVl1MUJuS3Y5aWw2VEpFYXpZSk9JM1duV1VvNDVqRE8weWRCV1cw?= =?utf-8?B?Q0VYbkJFUkZkMkMzQmhyMWV3MVd4cXB4SzFERUNOSWpjSlp3Nys3Qy9qUGVw?= =?utf-8?B?aU9qdlJYdkV4TnBKOFVGcFFIdXhLKzVVWDdibmhTUjI0eFhrd3NNcytWcWZZ?= =?utf-8?B?ZjF2R1BaMXhRSUxVWTdnbXAycjVGcy9zRUZ6UEhvc3l4a3RkMDZ6UUErcG1X?= =?utf-8?B?R0hTQ2tBbFhXQXRiUDlQSEE2MlcwaHFUaXFNditZWWJDMVczcHBkY3BLT2FV?= =?utf-8?B?cXhNV3lDQUkvZWtVOGRQb1M3N1Y1cmt4WTByOEo5WC9pVUtKeU9wMWNRNzNJ?= =?utf-8?B?cjFXZE9rRVNOU1BxRzZLbjY4VmFkWXJ3ODYzZG5DTlJUa1grajIzMXhSaTVZ?= =?utf-8?B?dFMzZ1pSUStMc1paaW04dENHWDRML3dKOEZYRGFYUUtLU0kxN0tqL0R4SEJY?= =?utf-8?B?bkNqZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 218b030f-6491-4270-4bd4-08dad2bb2035 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 10:10:36.9771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sO3aWRPMgiNDbxJtskb1SrKt8m1sNGkLCbh5TPw8NK8W86RlbpbuTenmfz6nl69jlekO797Q8dWapuEUn90Vdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4917 On Wed, Nov 30, 2022 at 10:34:41AM +0100, Jan Beulich wrote: > On 30.11.2022 10:26, Roger Pau Monné wrote: > > On Tue, Nov 29, 2022 at 02:12:10PM -0800, Stefano Stabellini wrote: > >> On Tue, 29 Nov 2022, Roger Pau Monne wrote: > >>> The hvc machinery registers both a console and a tty device based on > >>> the hv ops provided by the specific implementation. Those two > >>> interfaces however have different locks, and there's no single locks > >>> that's shared between the tty and the console implementations, hence > >>> the driver needs to protect itself against concurrent accesses. > >>> Otherwise concurrent calls using the split interfaces are likely to > >>> corrupt the ring indexes, leaving the console unusable. > >>> > >>> Introduce a lock to xencons_info to serialize accesses to the shared > >>> ring. This is only required when using the shared memory console, > >>> concurrent accesses to the hypercall based console implementation are > >>> not an issue. > >>> > >>> Note the conditional logic in domU_read_console() is slightly modified > >>> so the notify_daemon() call can be done outside of the locked region: > >>> it's an hypercall and there's no need for it to be done with the lock > >>> held. > >>> > >>> Fixes: b536b4b96230 ('xen: use the hvc console infrastructure for Xen console') > >>> Signed-off-by: Roger Pau Monné > >>> --- > >>> While the write handler (domU_write_console()) is used by both the > >>> console and the tty ops, that's not the case for the read side > >>> (domU_read_console()). It's not obvious to me whether we could get > >>> concurrent poll calls from the poll_get_char tty hook, hence stay on > >>> the safe side also serialize read accesses in domU_read_console(). > >> > >> I think domU_read_console doesn't need it. struct hv_ops and struct > >> console are both already locked although independently locked. > >> > >> I think we shouldn't add an unrequired lock there. > > > > Not all accesses are done using the tty lock. There's a path using > > tty_find_polling_driver() in kgdboc.c that directly calls into the > > ->poll_get_char() hook without any locks apparently taken. > > Simply by the name of the file I'm inclined to say that debugger code > not respecting locks may be kind of intentional (but would then need > to be accompanied by certain other precautions there). I'm also confused because hvc_poll() which calls get_chars() does so while holding an hvc lock, while hvc_poll_get_char() calls get_chars() without holding any lock. The call to get_chars() being done with a lock held in hvc_poll() might just be a side-effect of the lock being hold to keep consistency in the hvc_struct struct. I also wonder whether new users of tty_find_polling_driver() and ->poll_get_char() could start appearing and assuming that the underlying implementation would already take the necessary locks for consistency. Just looking at hvc_vio.c it does take a lock in its get_chars() implementation to serialize accesses to the buffer. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Nov 30 10:31:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 10:31:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449794.706747 (Exim 4.92) (envelope-from ) id 1p0KNT-0006wc-Eg; Wed, 30 Nov 2022 10:31:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449794.706747; Wed, 30 Nov 2022 10:31:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0KNT-0006wV-Bj; Wed, 30 Nov 2022 10:31:43 +0000 Received: by outflank-mailman (input) for mailman id 449794; Wed, 30 Nov 2022 10:31:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0KNS-0006w5-1V; Wed, 30 Nov 2022 10:31:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0KNR-0001hX-TM; Wed, 30 Nov 2022 10:31:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0KNR-0007BA-GX; Wed, 30 Nov 2022 10:31:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1p0KNR-0000yE-Fc; Wed, 30 Nov 2022 10:31:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pXzqrdHVOz6lITrLc511Wf1amu0r+OaGuZq9P2DnmLU=; b=Flxvnvht2nJkjTWQKV3CkjdF+M e6lvKNWcON+iZeRcA0FieWZgGyYDeFcRbLbAeceQFkz0cx3eoxYLIYvW7aUiIg9eKHyXDpAJ1Q2aB J28hcPSKyV2qHppDmpJIUa3ATfDpiJu5xk6fEIkxuX48YC6DPtle01VG1G6i6XLBR8/k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 174993: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=c4ffd91aba1c3d878e99a3e7ba8aad4826728ece X-Osstest-Versions-That: qemuu=ecbb6bd865d23ec412b9f2b715be784e45389f91 From: osstest service owner Date: Wed, 30 Nov 2022 10:31:41 +0000 flight 174993 qemu-mainline real [real] flight 174997 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174993/ http://logs.test-lab.xenproject.org/osstest/logs/174997/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 174997-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174989 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174989 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174989 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174989 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174989 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174989 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174989 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174989 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu c4ffd91aba1c3d878e99a3e7ba8aad4826728ece baseline version: qemuu ecbb6bd865d23ec412b9f2b715be784e45389f91 Last test of basis 174989 2022-11-29 19:38:28 Z 0 days Testing same since 174993 2022-11-30 01:41:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Evgeny Ermakov Gerd Hoffmann Philippe Mathieu-Daudé Richard Henderson Stefan Hajnoczi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git ecbb6bd865..c4ffd91aba c4ffd91aba1c3d878e99a3e7ba8aad4826728ece -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Nov 30 10:40:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 10:40:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449803.706758 (Exim 4.92) (envelope-from ) id 1p0KVP-0007of-CZ; Wed, 30 Nov 2022 10:39:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449803.706758; Wed, 30 Nov 2022 10:39:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0KVP-0007oY-9g; Wed, 30 Nov 2022 10:39:55 +0000 Received: by outflank-mailman (input) for mailman id 449803; Wed, 30 Nov 2022 10:39:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0KVN-0007oR-P6 for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 10:39:54 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 500e3c30-709b-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 11:39:49 +0100 (CET) Received: from mail-mw2nam04lp2171.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Nov 2022 05:39:46 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5347.namprd03.prod.outlook.com (2603:10b6:a03:218::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 10:39:44 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 10:39:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 500e3c30-709b-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669804792; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=LW/gcqgvEAMtOnusw6tnumETsxIkCPFe7qKpDO8QD/Q=; b=gHJE2RcyNzzXX0Z5ML7B01JME3JPT1n2Pvr71NZWi3hguXAzVOWSVK9C lXUW4lmZMFmtTDSMXvjODTU00g6dpk0iA8yYY1kTQzGJdq83FnGmJl8Hf ZppigzM8NGA8KSCk5l3qbWiVMiqsoz5Wkkep0u1QPQoY8LvWL30hNdU7y c=; X-IronPort-RemoteIP: 104.47.73.171 X-IronPort-MID: 84886035 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:w6UfMq8paxozra/FhnLTDrUDon+TJUtcMsCJ2f8bNWPcYEJGY0x3y mUeCG6EOq2LZzf0edp/b4SxoRsPsZaDy4I1HAtppHw8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKsT5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkSr sIeDRtUSyrb3fCMka2YF+w1geMaeZyD0IM34hmMzBn/JNN+HdXmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTeIilUuidABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCN5CROPgraMCbFu7/U1JJ0A3CkSCvvTj1H6EVuBEC BQT5X97xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L8/AKxFmUCCDlbZ7QOpMIwADAny FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRVLufgcBRAoBptz8+oc6i0qTSs45SfHsyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CBhRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:dcUeK6vu/TKhXQk8Y+CUB9H97skCXoAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeF+aP3CB+R2zYZSndqza05+W bIvgTl7uH72svLiyP05iv21dB7idHhwtxMCIiljdUUECzljkKFdZlsQLqLuREyuaWK5EwxmN fBjh88N4BY6m/XfEuyvRzxsjOQngoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L gj5RPbi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZDIMu60vFjLA BdNrCa2B9kSyLdU5kfhBg3/DWYZAV2Iv5BeDlbhiXa6UkMoJkz9Tpk+CVWpAZ9yHt6cegF2w 2MCNUXqFkFJPVmEp5VFaMPR9C6BXfKRg+JOGWOIU7/HKVCIH7VrYXriY9Frd1CVaZ4u6faoq 6xJm9wpCo3YQbjGMeO1JpE/lTER3i8Ry3kzoVb64JisrPxSbL3OWnbIWpe2PeIsrEaGInWSv yzMJVZD7vqKnbvA59A20n7V4NJIXcTXcUJspIwWk6IoMjMNor239arOMr7Nf7oC3IpS2n/Cn wMUHz6I9hB9FmiXjvijB3YSxrWCzjCFFJLYd3nFsQoufsw39d3w3koYHyCl7G2ACwHtLAqd0 1jJ76imr+npACNjBT101k= X-IronPort-AV: E=Sophos;i="5.96,206,1665460800"; d="scan'208";a="84886035" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GooTNwjJEZ1Wook78mEUHLRmuFMyubLYibmVYDEHs6yc7I0vck8vAEeQRUj4qW3apf0VrGVYY1RA5UHr4gEUbYxKmQH2N2O5NMyTBLqULH+gsjsnzZ2Te7yXRDB6ZiLj3JxP+2Qu2VBUkfeXM134Al/nAoQov8siUFNtVUNTbxyVsVYUR9Dz+Spo4hq8NgU8bEOSfJbP5wG5NWeEwXkrXuoZkLyXRUp/MG2zJgzHl+9BNspn9NIozJYINdBg7AeFq3FRq3sjSE08OyIMul6B66C1hnSHmef40HpKuBARq6L8nmf3yILOK4+Vl1cNCMpFYS2ujnVl8tmU0N/0oZJBIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LW/gcqgvEAMtOnusw6tnumETsxIkCPFe7qKpDO8QD/Q=; b=RA+5mlj+LpJltBS9mjZKk/koYOyPbDAl5ldz8m83bJetrvlNiR5bhThiXlLCvK9b+6s/Um2Mg3/nAOAYt+UlKsQh7akDYS388fCJaTy+Lo6CCCBmWL4w/SrHZ/OnxQVnNWMPg/11DdEINHI30Ifla6kNr9IUyQX18bTPlzqwpBW6EMMhLhD2I6XcoLuY5EGpKU4wT0ljjAVY6THtws/gw53dY8WgFX/MZww9zSfTN6OPOUwV2mkSL293KUyErKqNnZzCxSQhV6gh9piLYs156SFLZg6HIblIoVQq91rIWOiKuNsfymlCbikwcjGb0g5inJhMWgpU4Tvr0+sKt9MTlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LW/gcqgvEAMtOnusw6tnumETsxIkCPFe7qKpDO8QD/Q=; b=N2vUOz5PZHeT1cWjtfGQ1rQ0k95i65VBHnmIxJw0RIi9GsRxG11/KUIuwc5O6UaseEJuIA9a2erW+dsDO3X85tRE3Xj0AIPt3sHhfoXCDeGX//ib34NtNbYxJhJLV5O6RdzC9G2v5f5C4o56u9SsgpWt8ZVzbR0NT2HnLuIzQjc= From: Andrew Cooper To: Jan Beulich CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/mm: PGC_page_table is used by shadow code only Thread-Topic: [PATCH] x86/mm: PGC_page_table is used by shadow code only Thread-Index: AQHZBAKvvRJ2heCKJ0SiESCucWQuIK5WYfSAgAC3SICAAC7bgA== Date: Wed, 30 Nov 2022 10:39:43 +0000 Message-ID: References: <4fef5b0c-4463-cd6f-15fc-47268505517b@citrix.com> <96f6a943-0e1e-7399-fe83-56a550d47bf6@suse.com> In-Reply-To: <96f6a943-0e1e-7399-fe83-56a550d47bf6@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BY5PR03MB5347:EE_ x-ms-office365-filtering-correlation-id: a03c46d4-f274-4c25-5f4d-08dad2bf31a3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Uw+SpsFOUZwSL/TbnO9lrkkjDYMgAk8h8jwgtjPeUinaFlxjFrevr+sYMKeXr+2ODjYFst/trV6vAlLfLWfUXuXjgp35uv7iOXGH+UBhvZ39oArrInMsR8PardZPvZA7yUOYkAUZv0RxRO/qgXW/2nWJCVqzjukFuNxKTswB69gLFZhZBWsb0sX5OaNpeIW5kCpnEAjsS9uXP5q9GNlf+jIJQQbA/Y43x7m3AqDbLnJXqXo/xmEwhoT7g63Hu/ZSw9yHIeVTNuBAa/iG0ET7eIw3+L98P6uSGnR5iZHdveh/CidKrQNaUXSFZCIlzqZRkp/0p5w1RZAfT4l8OpJWgOEvBu5YbwXpH6CW68stZttYqNSIsvYWEsep2LA8uCB2pGkxrMrvbQjU95PELo2AbxFSDjUFb83CLmVbRemnbH5eNM3T9Ki8YHMbN35SknKsMALCzS0woOrEKcjEUCGqRkgL/TLPKgSszlEHsOXT2u9KIkTl5x4vYPArXRtODSjIXghUohhfwTYuEV2orI4KEG/ZWGTYMmRzhVVtE01ZbsmpijYbuIhQE+1T6T3itYXvfNkfStNq/cYRV6QH2Ca+JPieFzMH7RzpJYsaF2JgwlxqyS67iy8BaNVDV4PpuunqHzOAf6JItl+z1YOqwfbyl38d/zkWZR+HhyOnMLS+wrNJVSgzcP74ykd32ZvYzu1JYFTq3TulNIMErJYdPS3czknW8GGz5h0OYt+w3V8FRrs+yzGLqCzr0as0HqRUfFweE1UNxis7moFLpumUYIJFOQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(376002)(366004)(451199015)(66899015)(8936002)(31686004)(41300700001)(36756003)(64756008)(8676002)(66476007)(66446008)(66946007)(91956017)(38100700002)(82960400001)(4326008)(316002)(76116006)(54906003)(6486002)(71200400001)(2906002)(478600001)(6916009)(66556008)(83380400001)(5660300002)(38070700005)(31696002)(53546011)(6506007)(86362001)(186003)(26005)(6512007)(2616005)(122000001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YXkwNEozRkNYV0E5a0VtMStudXJBOUs0YWthSTBGcjFaeDFlOGdHdE4xcXZp?= =?utf-8?B?Nm9WL0dQcVpiUWxTZW9WbEJFa2RzdWpDY1VzWjhrY2VHQi9HNVNISW5HUk5y?= =?utf-8?B?SXNHZE5HSlh6MHlQRnJmdjVhb3dnVVQ2K1l0U1NHblQ1YVlZclBBdUdhOUls?= =?utf-8?B?ekhzMjJjL0o5MWNlSWVYbGx6c3dVS2c1alYwd1h3V0Y5eE5tU0txRHBFZnNP?= =?utf-8?B?Sm9qTzVkeUp5QXlydlJzazlNZC9DYmtJNFltRTlSdk5Qa3lsSWx6b2g3NHRD?= =?utf-8?B?em9TSGhnZ3lIK0srVEpDODlDbW5iajdPQnFVM1JnanIrVWtDUFZuWEdqWk8v?= =?utf-8?B?MTRlY2loWm83czlXVEw2M05WMjVWblJPM0MwenhFeGFlSFNNd3ZaWS9ETHVV?= =?utf-8?B?NUZwbnVHTTNMdEpUbCtMT1FxZDN4cGFZKytWalJwNnFhYzQ5b1cvblBGYWFL?= =?utf-8?B?TldpdVNUWENzUmZ4cVpzb0JIakNyczBKMlB4TytGS0VCNEwveDZsbjZ6bitM?= =?utf-8?B?VHBsbXpxNEpQOHVXSkEyRDhSTnhTMk15bXM0Qy8yc0RqSmlNOElPYS9pckNo?= =?utf-8?B?UFRFY1IyQjBxeEgrR1phT0xSWDhlekk3ZGNCVGVaaTgxSnhjd2tkZ2dwNEw2?= =?utf-8?B?QWw0aTllUzgrcDFReWsvVm0wSE81eWI5QVlZM0pQY0xwbWx3NEZESlljd085?= =?utf-8?B?VXVxaHhvQU1IQzhobC9OK1o4SmNtYzkxazE5RFhtMStCZldtT0wyZ2ZpZTEv?= =?utf-8?B?QUo1K25rZjBGTjNUZjRGOFZ1aCtBd3FsOEt6RW12NEdLMVRXWkhadmlxWGla?= =?utf-8?B?RHgxbXhyU3lFWUdOaDZoR0hPMDM1dUp0T0JlOWVMUnphZ0VmWnVqTXM2MWJ6?= =?utf-8?B?VzhBTTdOZ2FXdHlSVFJLaUF1eVRYUVJQNlc0Tm1ObVZtRjVjckh1TFdLb3lM?= =?utf-8?B?aFlXU2t3OFBHdFVBNGowTncrZDBqZG4vNnFXb1BaM3k3REY2emtIckt2VGhX?= =?utf-8?B?cmRmKzVaR0wvSi8zQXU3UXVaZmdENXlKb2RuVURqT1puTk0zamNJbW52ZGhl?= =?utf-8?B?dXdSWW9vRHhOUFRoWnRoTWM0OEFvVnRFM2xDekhMK0FKUmdFY2cvUXpJK1dO?= =?utf-8?B?dENHR1RScmxaZGRNZFVqZWpaVnFHU3QvbmdtRHV0ZDEzcTBSUm1WTHRWNDRZ?= =?utf-8?B?MmhXeHFtV3YzNXJmcURBWXU0OFBVM2duYTFqWWVYUXoxcGdNZGdJVUFLeC9o?= =?utf-8?B?eS8rcTc4SFlWMERHU3d3THdWbWQ4YjhxdEMreURsZURwei9HeHQzdnFCczBE?= =?utf-8?B?VnJJS1lNbzM0WGlVT2tMa3dLczVkM2dnZm9RMXREYVcvc2VDeDU1SjFRVnFp?= =?utf-8?B?NEJaTzZ1SFU4QitpKzY5Zys0QllzVGl5WDZLNnRabFNQSG1WcWJJdFVGZzFS?= =?utf-8?B?RFlUZVF0YXpVdE1kWE5Ta1ZIZ3hCaEhKNm5vSTRSV051R3V0KzYvZ0tvV3dL?= =?utf-8?B?b2JpN1ltT3l1T0R2VEV3LzB3b1l4RkdRSUpWUzE4dWp0ZVFwMTNWWnlCeVpo?= =?utf-8?B?dFJzMnBBSTZpREhWYzN3cUtmeENIQXRMY1RoUXhkN2E4MEI5b010cmcxbFlk?= =?utf-8?B?M2hWUFlYaGVHRkVDSCsrbk80a1IrTWRJTnhVMWM5czcvK0NZSW5JdGhHd1Z1?= =?utf-8?B?b2cvYndodnV5SUN6ZzVNUzBTR2pWMFU4UHJEckZmU2VFK0NxekgydGNJbG5k?= =?utf-8?B?OWQ1Q2Rwb3FJMXNra201bk9vL2ttTnhJaE1jZDgydC9wLzZTMmg3b3M4YlUz?= =?utf-8?B?cEFiSndjblRkUWgvMklPOU0vMFFLd29Jd1BsMUk3MjNhSEtKNUxXUkN1dlBQ?= =?utf-8?B?ZHY2VDhDam9kZUpzVmNjc2JVM2crZndlTEN2Y2JQckcxMWhQSWFLYmFIR3o1?= =?utf-8?B?aExjSGQ3cHpGSnBBM1Y1ZGhNY0NQTFlFVE1GZlFlSWpPZkRrRGxKZmVLb3Fv?= =?utf-8?B?N3JjNnlZQXc5dE9lNDY2UWZ2VmxzWmtlRVl1aWMyZnJ2Q1N5U0xIVlNRWUtT?= =?utf-8?B?NDAxTkU0TlZESytxVTR4MXpjYmZqWlRhMytMa2YrUHQvWDlvUFUxSVhmZHJT?= =?utf-8?B?WkVvY2dVUGFJQ1ZqUnk2enVQc0F2c3FST2xsZkx5S1VrclZ0Wk5tQnhnbmZk?= =?utf-8?B?Y0E9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <68723E609C67DD499112DD390DFCD582@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: txlxjY51vClBv2IJxY4j+9hjtkXTzlgrwNk87MbIJ+lWhXG01KDQ/BaGLBZwdz0yCIa1CwOymg6hQZSNuGTmhK4RGryinIVHcd0wKN3Dzq6g5dt/Iynz5HhWH5kCK5VKHHuhzgCN6NvO8DNQAShmafaJO1ZnHeurCqWfg2SO7UD34JZidaVb3vJ7tARbPELoqOJB1nqB3VZhD6lZl5q4FGUkm7Xzl/4XDEz0bSUvGMG+1wV3u2TmSg61nM08yCcpbJG/4neL+OsAUwUloQWUDrkNU/ObL5Oti16mB/oeWCKKKudjF2DTWA8waChOFHxDFcFfgEc9ORuxIoIH/F29B/Y9durVfSSis7zng44+hzk3vuout/nuvTgweWMT2qDnJ9ldUc5M46UXOuHzjDXUvk/5Chc2BZosoVvo3YPsMaD2OwdOgbCyFZRoajAPRiGSHcGghafiDhAMnlpl9eg68LCwrJbNzLIgE+u7sdpnwIvwooAQTsHTY2u7ATgxkWi/32OHdhbTRqysSbiVparetbabwaPMpYAwXfL6/x904gqiKFXVuipNxF5NiqIQ2qG3gmAm6OYFERlOj+B2ZbCI6dIxdEk+TBIrfH+uZTbeUW54lzwapTJuT/mUB/lrIAJFU+0Sh3bi3pH3js2ygHkXvwAjzxPLoevIBJDd9TBzwh5V5fRPgEv0GIot5zKRhblaPBqMUkTsTp22hUfLgouLCsplRCGrofiuaLBVIyvX3VpFq77qG5CP7+d/wilrI+m0e/AxXlHWnnPZUSZzP4zlhbL6p99yP1Sv0D3z12oCFIyVobpuZ7tvozC6vH3q8K7MGUJBBEsPDCWVh5NsgdlrPw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a03c46d4-f274-4c25-5f4d-08dad2bf31a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 10:39:43.9252 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5pqlgAazEb7UnpA09xm2Bw7IZu5vweLmSCM8jc4xuFcHiwNKotdJmnC+EPRymKsFqSpghVknWbNro/SY994yu+D6BSFWkIZ454QPX4ogKog= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5347 T24gMzAvMTEvMjAyMiAwNzo1MiwgSmFuIEJldWxpY2ggd3JvdGU6T24gMjkuMTEuMjAyMiAyMTo1 NiwgQW5kcmV3DQpDb29wZXIgd3JvdGU6DQo+PiBPbiAyOS8xMS8yMDIyIDE0OjU1LCBKYW4gQmV1 bGljaCB3cm90ZToNCj4+PiBCeSBkZWZpbmluZyB0aGUgY29uc3RhbnQgdG8gemVybyB3aGVuICFT SEFET1dfUEFHSU5HIHdlIGdpdmUgY29tcGlsZXJzDQo+Pj4gdGhlIGNoYW5jZSB0byBlbGltaW5h dGUgYSBsaXR0bGUgbW9yZSBkZWFkIGNvZGUgZWxzZXdoZXJlIGluIHRoZSB0cmVlLg0KPj4+IFBs dXMsIGFzIGEgbWlub3IgYmVuZWZpdCwgdGhlIGdlbmVyYWwgcmVmZXJlbmNlIGNvdW50IGNhbiBi ZSBvbmUgYml0DQo+Pj4gd2lkZXIuIChUbyBzaW1wbGlmeSB0aGluZ3MsIGhhdmUgUEdDX3BhZ2Vf dGFibGUgY2hhbmdlIHBsYWNlcyB3aXRoDQo+Pj4gUEdDX2V4dHJhLikNCj4+Pg0KPj4+IFNpZ25l ZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4+IEFoZWFkIG9mIG1h a2luZyB0aGlzIGNoYW5nZSwgY2FuIHdlIHBsZWFzZSByZW5hbWUgaXQgdG8gc29tZXRoaW5nIGxl c3MNCj4+IGNvbmZ1c2luZywgYW5kIGZpeCBpdCdzIGNvbW1lbnQgd2hpY2ggaXMgd3JvbmcuDQo+ Pg0KPj4gUEdDX3NoYWRvd2VkX3B0IGlzIHRoZSBiZXN0IEkgY2FuIHRoaW5rIG9mLg0KPiBDYW4g ZG8sIHN1cmUuDQo+DQo+Pj4gLS0tDQo+Pj4gdGJvb3QuYydzIHVwZGF0ZV9wYWdldGFibGVfbWFj KCkgaXMgc3VzcGljaW91czogSXQgZWZmZWN0aXZlbHkgaXMgYQ0KPj4+IG5vLW9wIGV2ZW4gcHJp b3IgdG8gdGhpcyBjaGFuZ2Ugd2hlbiAhU0hBRE9XX1BBR0lORywgd2hpY2ggY2FuJ3QgYmUNCj4+ PiBxdWl0ZSByaWdodC4gSWYgKGd1ZXN0KSBwYWdlIHRhYmxlcyBhcmUgcmVsZXZhbnQgdG8gaW5j bHVkZSBpbiB0aGUNCj4+PiB2ZXJpZmljYXRpb24sIHNob3VsZG4ndCB0aGlzIGxvb2sgZm9yIFBH VF9sPE4+X3BhZ2VfdGFibGUgYXMgd2VsbD8gSG93DQo+Pj4gdG8gZGVhbCB3aXRoIEhBUCBndWVz dHMgdGhlcmUgaXMgZW50aXJlbHkgdW5jbGVhci4NCj4+IENvbnNpZGVyaW5nIHRoZSBjYWxsZXIs IGl0IE1BQ3MgZXZlcnkgZG9taGVhcCBwYWdlIGZvciBkb21haW5zIHdpdGgNCj4+IENERl9zM19p bnRlZ3JpdHkuDQo+Pg0KPj4gVGhlIHRib290IGxvZ2ljYWwgYWxzbyBibGluZGx5IGFzc3VtZXMg dGhhdCBhbnkgbm9uLWlkbGUgZG9tYWluIGhhcyBhbg0KPj4gSW50ZWwgSU9NTVUgY29udGV4dCB3 aXRoIGl0LsKgIFRoaXMgb25seSBkb2Vzbid0ICh0cml2aWFsbHkpIGV4cG9zZQ0KPj4gYmVjYXVz ZSBzdHJ1Y3QgZG9tYWluX2lvbW11IGlzIGVtYmVkZGVkIGluIHN0cnVjdCBkb21haW4gKHJhdGhl ciB0aGFuDQo+PiBhbGxvY2F0ZWQgc2VwYXJhdGVseSksIGFuZCByZWFjaGluZyBpbnRvIHRoZSB3 cm9uZyBwYXJ0IG9mIHRoZSBhcmNoDQo+PiB1bmlvbiBpcyBvbmx5IG1pdGlnYXRlZCBieSB0aGUg dGJvb3QgbG9naWMgbm90IGJlaW5nIGludm9rZWQgb24NCj4+IG5vbi1pbnRlbCBzeXN0ZW1zLsKg IChBbHNvIHRoZSBpZGxlIGRvbWFpbiBjaGVjayBpcyB1c2VsZXNzLCBnaXZlbiB0aGF0DQo+PiBp dCdzIGluIGEgZm9yX2VhY2hfZG9tYWluKCkgbG9vcCkuDQo+Pg0KPj4gSXQgZG9lcyBsb29rIGEg bGl0dGxlIGxpa2UgdGhlIGNhbGxlciBpcyB3YW50aW5nIHRvIE1BQyBhbGwgWGVuIGRhdGENCj4+ IHRoYXQgZGVzY3JpYmVzIHRoZSBndWVzdCwgYnV0IGRvaW5nIHRoaXMgdW5pbGF0ZXJhbGx5IGZv ciBhbGwgc2hhZG93ZWQNCj4+IGd1ZXN0cyBzZWVtcyB3cm9uZyBiZXNpZGUgdGhlIHBlci1kb21h aW4gczNfaW50ZWdyaXR5IHNldHRpbmcuDQo+IFF1ZXN0aW9uIGlzIC0gZG8gd2UgY2FyZSBhYm91 dCBhZGRyZXNzaW5nIHRoaXMgKHdoZW4sIGFzIHNhaWQsIGl0J3MNCj4gdW5jbGVhciBob3cgdG8g ZGVhbCB3aXRoIEhBUCBkb21haW5zOyBtYXliZSB0aGVpciBhY3RpdmVseSB1c2VkIHAybQ0KPiBw YWdlcyB3b3VsZCBuZWVkIGluY2x1ZGluZyBpbnN0ZWFkKT8gT3Igc2hvdWxkIHdlIHJhdGhlciBj b25zaWRlcg0KPiByaXBwaW5nIG91dCB0Ym9vdCBzdXBwb3J0Pw0KDQpIYXZpbmcgY29udGVtcGxh dGVkIHRoaXMgYSBiaXQgbG9uZ2VyLi4uDQoNClRoZSBwcmluY2lwbGUgb2YgTUFDLWluZyBwYWdl dGFibGVzIGlzIGluY29tcGF0aWJsZSB3aXRoIEEvRCB1cGRhdGVzLsKgDQpJT01NVXMgaGF2ZSBB L0Qgc3VwcG9ydCBzdXBwb3J0IHRoZXNlIGRheXMsIGFuZCBvbGRlciBJbnRlbCBDUFVzIGhhdmUN CmVycmF0YSB3aGVyZSB0aGV5IGNhbiBzZXQgdGhlIEQgYml0IG9uIGEgcmVhZC1vbmx5IG1hcHBp bmcuwqAgVGhlIHRoaW5ncw0Kd2hpY2ggYXJlIE1BQ2VkIGNhbiBsZWdhbGx5IGJlIGNoYW5nZWQg YnkgaGFyZHdhcmUgYWZ0ZXIgdGhlIE1BQyBpcyB0YWtlbi4NCg0KVGhlIGN1cnJlbnQgbG9naWMg aXMgY2xlYXJseSBub3QgZG9pbmcgc2Vuc2libGUgdGhpbmdzLsKgIEl0IGxpa2VseQ0KcHJlZGF0 ZXMgSEFQIHN1cHBvcnQsIGJ1dCBJIGhhdmVuJ3QgZ29uZSBsb29raW5nLg0KDQpBbHNvLCB0Ym9v dCBpc24ndCBsb25nIGZvciB0aGlzIHdvcmxkLsKgIFRyZW5jaGJvb3QgaXMgcHJvZ3Jlc3NpbmcN CihzbG93bHkpIGJ1dCB0aGUgZW5kIHJlc3VsdCB3aWxsIGJlIHNvbWV0aGluZyB0aGF0IGZ1bmN0 aW9ucywgaXMNCnN1cHBvcnRlZCwgYW5kIGRvZXNuJ3Qgc3VmZmVyIGZyb20gc2V2ZXJhbCBDVkVz IHdoaWNoIEludGVsIGhhdmUgZWxlY3RlZA0Kbm90IHRvIGZpeCBpbiB0aGVpciAicmVmZXJlbmNl IFRYVCBpbXBsZW1lbnRhdGlvbiIuDQoNCkkndmUgZGViYXRlZCBzZXZlcmFsIHRpbWVzIGFib3V0 IHJlbW92aW5nIHRoZSB0Ym9vdCBpbXBsZW1lbnRhdGlvbiwgYnV0DQpoYXZlIGNob3NlbiBub3Qg dG8gZG8gc28gdGh1cyBmYXIgYmVjYXVzZSB0aGVyZSdzIGFsbW9zdCBjZXJ0YWlubHkgYml0cw0K b2YgaW5mcmFzdHJ1Y3R1cmUgdGhhdCB0cmVuY2hib290IHdpbGwgd2FudCB0byByZXVzZS4NCg0K QnV0IGFzIGZhciBhcyB0aGlzIGdvZXMsIEkgdGhpbmsgd2UgY2FuIHJlYXNvbmFibHkgcmVtb3Zl IHRoZQ0KY2xlYXJseS1qdW5rIGFzcGVjdHMgd2hpbGUgY2xlYW5pbmcgdXAgLyBmaXhpbmcgb3Ro ZXIgYXJlYXMgb2YgWGVuLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Nov 30 11:20:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 11:20:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449808.706769 (Exim 4.92) (envelope-from ) id 1p0L8b-0005DV-GV; Wed, 30 Nov 2022 11:20:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449808.706769; Wed, 30 Nov 2022 11:20:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0L8b-0005DO-Cc; Wed, 30 Nov 2022 11:20:25 +0000 Received: by outflank-mailman (input) for mailman id 449808; Wed, 30 Nov 2022 11:20:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0L8a-0005DE-3N; Wed, 30 Nov 2022 11:20:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0L8a-0002oa-0C; Wed, 30 Nov 2022 11:20:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0L8Z-0000J7-9U; Wed, 30 Nov 2022 11:20:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1p0L8Z-0006Sj-98; Wed, 30 Nov 2022 11:20:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5840rVNJ3DNwDp2z6eJWOnJ0o4vN0one1OFUpLXHs+A=; b=ekRY60+H09lyuCXewQ99V1CmEw Bg++Wc0omGGyCEOpc+CrFbF65w5INbg/mLrkLDgSoYot6umIHx83OJOCsv4vpXBwHoJLwm66JtGaK RGL8000zAg3Od7TfLxvPkoe8R+YsYiujl8eVnn24RK91JhSfy/Vyco5tU9VtCRnqTcPk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 174994: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=345135942bf9632eba1409ba432cfcae3b7649c7 X-Osstest-Versions-That: xen=345135942bf9632eba1409ba432cfcae3b7649c7 From: osstest service owner Date: Wed, 30 Nov 2022 11:20:23 +0000 flight 174994 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174994/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail in 174984 pass in 174994 test-armhf-armhf-libvirt-raw 8 xen-boot fail pass in 174984 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 174984 like 174977 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 174984 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174977 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174984 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174984 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174984 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174984 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174984 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174984 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174984 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174984 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174984 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174984 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen 345135942bf9632eba1409ba432cfcae3b7649c7 baseline version: xen 345135942bf9632eba1409ba432cfcae3b7649c7 Last test of basis 174994 2022-11-30 01:51:52 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed Nov 30 11:28:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 11:28:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449817.706780 (Exim 4.92) (envelope-from ) id 1p0LG2-0005vt-Bj; Wed, 30 Nov 2022 11:28:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449817.706780; Wed, 30 Nov 2022 11:28:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0LG2-0005vm-8q; Wed, 30 Nov 2022 11:28:06 +0000 Received: by outflank-mailman (input) for mailman id 449817; Wed, 30 Nov 2022 11:28:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0LG1-0005vg-SF for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 11:28:06 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20621.outbound.protection.outlook.com [2a01:111:f400:7e8a::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0d65c895-70a2-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 12:28:03 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by IA1PR12MB6065.namprd12.prod.outlook.com (2603:10b6:208:3ef::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 11:28:00 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57%4]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 11:28:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d65c895-70a2-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=leRHd6ivGq+Y8YSu2PL7E826dMf9xZYlIq/DxgWwgbD+blGAHB/gGNbT3Tr4jFjAWLrk5jyJsr9oEWKAZ2Ns19qsxCElsILiGkc9dO7DgPdIjjOIjkcKlQzZnyGTUJW3ADYd9oOJ/TBMZhr9IUvSJtucsFLhTpu6QobVLWpQDNMPcn47fIhKu6/7YTDQlqxBS0tXRIDSi9ds+e2lZKVjGi6s3T+/l0rcS5oGzz9x1StVBWbcZ3jTEEl4zEV9sYrkjJyg6K7UkMFlMhLCOmuo/U2hW0cVtNjjaRw5/dcGn3bfRhSCFr5ervNpnTZyxhm/SE14egWxubBBgCLHky7yJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5xrXrsj/7NgSQSbDpJMBlak7v0PWein6jZNCxYllDEY=; b=cfyaQliPkid6I2soaI+bsDh0ataN0j/ece79x+maTOWM4RWsiwRwPUC0aMcALZsIH0sLy7UInQi9KEbdzBupBgv5fc/tIsdKOXqdtk17SuSVHDhn8JqzLUp3VhjDpyJbL7fpEOOH4iIAsIcEAPGW+KyWb4SwVBhztWGhidTDpHsWQxJRmi8YHLjQQ8LyywuruNGNNdhg/MztOXOCGrkSAVH2iZAno7Kud2PuDkjsHxfn6Uk4bYLwrI7gsYGFizvu5oPKulVvc4XleqgY4oxmCL0R2n2iFKtNMXAuhV7QQUhuviB7hiOUT/4qT8eHxkx6hxhMt4J4mtTey1Kyl9yXGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5xrXrsj/7NgSQSbDpJMBlak7v0PWein6jZNCxYllDEY=; b=wPDagYF6s/ZzMmMAq/1w8xazfVYy/UhhEgpAd0l15Kl8O6mdb31jdSykPaMqUUKLlBkDFIfbEMbXj027TqP/zpJj4cEKwqdgfaQH/6bqlAWlCUX7UurrEbZc31NkZvrfpLyJy84pMUAycG9n4LkaZv6IDcO3VIpUrmVwwqi50/Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <21ae8452-167c-88d3-1604-162018408ea6@amd.com> Date: Wed, 30 Nov 2022 11:27:54 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Arm: AArch32: Need suggestions to support 32 bit physical addresses To: Jan Beulich Cc: Stefano Stabellini , "Stabellini, Stefano" , bertrand Marquis , Andre Przywara , "Volodymyr_Babchuk@epam.com" , Rahul Singh , Vladimir Murzin , Julien Grall , "xen-devel@lists.xenproject.org" References: <70651dbc-085d-706d-17d0-a419086a0700@amd.com> <65891843-db28-e5dd-6e9e-3fb003fcabc5@amd.com> <105a0d45-5b3d-7986-92c1-9a13eb803bd8@amd.com> <22d28805-8889-25e9-6d18-c868bf5e51bb@suse.com> From: Ayan Kumar Halder In-Reply-To: <22d28805-8889-25e9-6d18-c868bf5e51bb@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0309.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::8) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|IA1PR12MB6065:EE_ X-MS-Office365-Filtering-Correlation-Id: c4937a55-5f3c-4599-e1de-08dad2c5efef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6Lfq+aAwmoADXIoq2Mmc4l2QQrhFXG23ZXe0LRSQnTkr9TMx5pA+hkAJzG9WdHhGb/htS7W57prl0p1NdT2U6rwhOEBAAUDsIJmLY6Cw0GxnIEtXmhyf3wZGHMQy4JRTD2rCysvk9bvthAxRw/ax6peB4bqmNQPPcIQfLKkIgi8nB+UCb73KOIqBd+mfHlZR8CXxxYrrfHQCBgkn1h0DlgH0ednbicQzF2XxLVdJBrT3HuRz2FK5bijFxiIhK9zbI7i+BeFRXRAaDilNi+NA3w6+UYwTARVpLhxjEt9HwIk6CQrbI9mTSfO38QSUJQ7Fr82MSWzwul4E33STDgTGOLXhR5+++Rk8O7K4qmf3nZyimVazKQ+IZVvGLFyIg8LoUSRiLyBsVTAzxkP2pO+E8A6OIgFmBrm9k71hnZqQrJOsf3dbje/lWYBYMYZwcAmXbIGIposmeddiM1TLYtSJOBmv+CU84U24T6NiDExZb6rc9z7/6oHsi4dy6HUW33Z8iBUg6D36MIxi0BadSVrZBkvuhnCqlfru97KqefiTlhnUiTfxuwxBoG7KbmcL/0jD8X3fmvRchCu49BT1LnbLfhA7q6lVdy+VAD9uWFIVBeIkRTFfnaq4vP9g+spmGUNOa58poYcUZ2TyAbMXLXCfuPakpwx3fvsQcVmyT7N5NIpdkKKWX2s4MizqS68In1AQn72jpPDkhYYUaQZ2Yd5NLHAXloutxlC4aiACF9ZvnZE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(39860400002)(396003)(366004)(451199015)(31696002)(66556008)(6512007)(66946007)(26005)(8936002)(4326008)(8676002)(478600001)(6486002)(6666004)(6506007)(2616005)(316002)(38100700002)(5660300002)(2906002)(83380400001)(54906003)(53546011)(66476007)(41300700001)(6916009)(31686004)(66899015)(186003)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDNUVmpBWUJoMGlsTWFoZzNKOGhqSnd4VUQwWWtvK2tOQ2JsTll5UUVTaCtq?= =?utf-8?B?cjFmcnpXZW9zOFJlcndkOTI4akh0MEIvVTVaYzhYbktFamZaOExSSVFCeGpu?= =?utf-8?B?Z0xZQXlmRlR6ZFlLMjgxM0g1TmFTYkpkUkxCNUdWN2lQR2xHemN5dE1Pd2c5?= =?utf-8?B?bVNjczFzTE1tMFNDajdwQTV4c3lDZTRlNG5uV3d6Wk5CTm1obDc3UVFuVkgr?= =?utf-8?B?SWJ2bkszTHdhQnF6OGhUMDYxS0RVWVNwdlU2Q1VtMmFoUjFzZUw0MFlqMzN1?= =?utf-8?B?aVFLdUlhUElVNTBPeUFwUDNuanlsVFdaZ1B3SnNWa0dPMkVRV3RGbFVSUG9i?= =?utf-8?B?MXBwcFpuYW4xWVZFRmM4V1JFVXBsamRKM1lkakFzRW1JVUpIL0d1bXRUYkMr?= =?utf-8?B?cjZoTGZzeTQva3gzb21XdjhKQXVjQjdWVHJCK0IvTk1wLzYvdVhRQVhsMVVS?= =?utf-8?B?dVlIWSszZVJsdytuRHdxelV0aGp2WU1NVjdmWFlMdjVOUk1CRUtjelN2MWhz?= =?utf-8?B?REwzZWhkVTA2ZGM5V3N4bVVhWGVkSFJ6NHUrcUE0VzFuaHVDNWZSZjVsZGFQ?= =?utf-8?B?R3JkeklEZ0VoeTN5VEQ1T1ZNbTNNaVBCTzBXMCtLYW5YdHN5SmlaZGVjWlJl?= =?utf-8?B?QmJjMnFGNUhaMkk3eWJtYmUwU1lOd2lKOXFXTEVmdGcwWXM1QTFvdlJDM3Fv?= =?utf-8?B?SWM0bnpCTkREcklUWWV1ZCtSYlpVUU5ja3p4V2tuNW15TkRGUkkxMXpmb0hE?= =?utf-8?B?RkgzVllNbVpwTytVUHNOY0QvMFZyczJhZzFKQjRIWnBMam5qeXoyUXl2YWV4?= =?utf-8?B?RDhUZlU2bFJ4V25qblBqa1MyMk5rT0ljemxSRlU5aEMxeXhjYUl5Q3d3ZnRC?= =?utf-8?B?Si9kd2wrN0tPV1ptZmFLeDNIMjR5LzFWQWJEaTZyMlVrRWcveWNaZTArZFhr?= =?utf-8?B?VUpUTnJGUnM0Qiszd0FwZjRrOXNBVTVoSFJEWWR4U2tIUkdqdzdyMXVnUjEw?= =?utf-8?B?QjlBeHFMbURMYmVJaktvc0FJRmtkaEI2RkZwR0NyT3NSS3AreGZ5SzVCUk54?= =?utf-8?B?Y1REb29sckFrRUdlekt6Q0J4dy9jL3VTU1loN1ZiNlMrRFFraEhLWDRwTHc1?= =?utf-8?B?ZlRQSmlSTTdUOFBPZmRvV3BmaDJma1lZMlJxVG5ic1V5SnhlYjQyNU1Gd2RZ?= =?utf-8?B?S21Yamo4bjZtd1pOdXJBNms3T1Vma0VLU1FNdUNZTDhTdThIK0s2QXZ4VTZB?= =?utf-8?B?ZlBnU05EWFJjdUZPbklybVBxQmVjY3RlYmFzTS9LZENjWU9RNmZvdXAwTktv?= =?utf-8?B?YXRoeDlFMGJOSjZINEtPNU9KR2NIaVdhcmp2L29QTVFkZnd3MVptdGx1dTU1?= =?utf-8?B?NitBZFJtZGFoV1VDeXZ2MDB4anlCKyszYjl4SjBabmJYeUc5SVREYy83SFJ3?= =?utf-8?B?M3oxZm1WbHExY2FZL1VSQmNWa3FEaGc4UXk0ejBTVlVYbGRkSExEMlVwNG90?= =?utf-8?B?R0lqUlhlWHd3UGJxMGdpYmVIUDNoZHdHYXZSc0MzeGlQS2JHTW9WMk1XL0li?= =?utf-8?B?QkpOQUZiRmdTNHZMaGpvY1l4eHJSZ05kSlk2RUVSQjZyY3NIOWdtVllBUGov?= =?utf-8?B?VlVkd29IUmZueFAyM3FQaUNLbTJTbmNZUUNmS0E5N29MTldjbDFIMFFSMjky?= =?utf-8?B?Y21TYldzQUp1Z3UwMGFQWEdpVDAvVkpwekNFL2g3OGl1UmFiYVVoS2JSN2Zm?= =?utf-8?B?aDdrWmMrRUViRWRwSnRyUzVPQy9jNzhTdC9QQ3dJL0IxODZVWHBYOVhVaVNO?= =?utf-8?B?V2hVOEEyTmxZQkduanQ4ckpWc0ZYQzk5emZVYVFST3BrQzBmOHJjWm1rNVh5?= =?utf-8?B?MDNQTmh1V0pqWmhiSjdWQ0JFK3hrcU1qeWlCUm9ab3lvRHh6bCtoTklqNklS?= =?utf-8?B?a1RNTFoxcW1vT3FNdjU0ZFdKOUVoSE5UbGhhd2Vhb1JVTHVkT0wra3J3dFdy?= =?utf-8?B?SzV0Nmx1c0lYZFNvdXRxbE9YcW5La0ZBRUxnWFZiYmY5d2xYNTZneWxMSGRN?= =?utf-8?B?d2hmYWJwc3l5WDVHQTlZa0JwcjY3OUovbjR3aG8xTUJZWDB0RzdHdmcrcEJa?= =?utf-8?Q?ccOoqBa9RZLu3Z39SefMovkVR?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4937a55-5f3c-4599-e1de-08dad2c5efef X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 11:28:00.4555 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MaxMDdU5Mtni78sDIiWe4SzMzkMukRaaL0gH4DNInGD0rg/75H77Rkt6o79wpY1kjMU0U3H7HbSHAAzatAvfJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6065 On 30/11/2022 07:09, Jan Beulich wrote: > On 29.11.2022 19:18, Ayan Kumar Halder wrote: >> On 29/11/2022 15:52, Julien Grall wrote: >>> On 29/11/2022 16:23, Ayan Kumar Halder wrote: >>>> On 29/11/2022 14:52, Julien Grall wrote: >>>>> On 29/11/2022 14:57, Ayan Kumar Halder wrote: >>>> --- a/xen/common/page_alloc.c >>>> +++ b/xen/common/page_alloc.c >>>> @@ -2245,7 +2245,9 @@ void __init xenheap_max_mfn(unsigned long mfn) >>>>   { >>>>       ASSERT(!first_node_initialised); >>>>       ASSERT(!xenheap_bits); >>>> +#ifndef CONFIG_AARCH32_V8R >>>>       BUILD_BUG_ON(PADDR_BITS >= BITS_PER_LONG); >>>> +#endif >>> BUILD_BUG_ON() are used to indicate that the code would fall over the >>> check pass. I can't find the justification for this change in the >>> commit message. >> I had a look at the following commit which introduced this, but I >> couldn't get the explaination for this. >> >> commit 88e3ed61642bb393458acc7a9bd2f96edc337190 >> Author: Jan Beulich >> Date:   Tue Sep 1 14:02:57 2015 +0200 >> >> @Jan :- Do you know why BUILD_BUG_ON() was introduced ? > You've cut too much context - the next line explains this all by itself, > I think: > >     xenheap_bits = min(flsl(mfn + 1) - 1 + PAGE_SHIFT, PADDR_BITS); > > Clearly addresses used for the Xen heap need to be representable in an > unsigned long (which we assume to be the same size as void *). > > But I'm afraid there's further context missing for your question: Why > would that construct be a problem in your case? Is it just that you'd > need it to be > rather than the >= that's used presently? In my case (for Cortex-R52 build) :- PADDR_BITS = 32 BITS_PER_LONG = 32 Thus, "BUILD_BUG_ON(PADDR_BITS >= BITS_PER_LONG)" gets triggered. I think the physical adresses are representable using "unsigned long". Yes, using "BUILD_BUG_ON(PADDR_BITS > BITS_PER_LONG)" looks correct to me. > If so, why > do you add an #ifdef rather than dealing with the (apparent) off-by-1? > (I say "apparent" because I haven't checked whether the >= is really > depended upon anywhere.) The only callers of xenheap_max_mfn() are from xen/arch/x86/setup.c as follows :- 1. xenheap_max_mfn(PFN_DOWN(highmem_start - 1)); 2. xenheap_max_mfn(limit); Looking at "min(flsl(mfn + 1) - 1 + PAGE_SHIFT, PADDR_BITS);", I do not understand the reason for "... -1" (ie subtracting by 1). Do you know the reason ? - Ayan > > Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 30 11:38:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 11:38:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449823.706794 (Exim 4.92) (envelope-from ) id 1p0LQQ-0007bG-Bq; Wed, 30 Nov 2022 11:38:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449823.706794; Wed, 30 Nov 2022 11:38:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0LQQ-0007b9-7m; Wed, 30 Nov 2022 11:38:50 +0000 Received: by outflank-mailman (input) for mailman id 449823; Wed, 30 Nov 2022 11:38:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0LQP-0007b3-Oo for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 11:38:49 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8e1c6afc-70a3-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 12:38:48 +0100 (CET) Received: by mail-wr1-x42f.google.com with SMTP id m14so2676146wrh.7 for ; Wed, 30 Nov 2022 03:38:48 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e1c6afc-70a3-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=0JOkjIEjkYcQCxG5mqdn9pw+dCfwIS62pE4v/xVB4bQ=; b=JDFGu9dMz6Fd+DD1gbS38i9mSAPKOnpMluE2pafIpTIXrd8DQ5hZpa30vxDS1JzWl9 r+wQrxv1IPkO2whh4X+wu4XBV8sJ3hl8IIIv7bfXgHvfC7WkuqvMrm3gkMMl/RQwRR0I 8uiFT3H6mD9EXuE979dZcDynl0+TKKXAGvGMq25hPD594hFvGSvi3Z9N66bLVfBJVh6B KPpLWM9i4+OvorjHP5t+xpdJDb9MnBjRZf12SqrQUyWI7GNdDatU42MoWmHl/LjE8GE6 oLbROU5DnZFpgZm1+qS7xF7rrcU/oyUNbn3JCB43nyMjreTvvFQ98CMHk3ktvODoLXQP KMbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0JOkjIEjkYcQCxG5mqdn9pw+dCfwIS62pE4v/xVB4bQ=; b=ehMWF40k1k9yx4vnYJGMsbU5AR+Cs0j7Px14hIyJcEjUW9ImsXFuguwyHdkkL7i0cd SWDYgbEv4Xq1v8vP56HMXCG8FGusIgjYf3v2b/R63oKqr2iBMhw1/dRyQUIbGv3pABgD jF74dm9jir58s0Rakrn5dU9LZcAxBPxtjhFqdS82RHdNtsk9HyTq7iZaQkvfe4k81ihg uAyD4VMYEYPOHyXW7BCDqcYX+KfFfM3HeMLuH9VFXM9u0ZK8BLSCIODHg4uqEguiWeJn aHZdfOWT3L4GuOZnJRUi/fC+J24QWLTFVNWguUh/HtsinAVOtuGv49q800FUz7dJ3tpX 5Z1A== X-Gm-Message-State: ANoB5pnBRg8DbYgIWU7EQfk5ajejyoasVXVQdjP3Ed0Y3q7H3/tcX5IN et+ZZ+IELGus2QhejjlHirCX1+2T/WrOdptgUniat3i+yxI= X-Google-Smtp-Source: AA0mqf5P/WDPUMYA398x6f9AKyYCjuaRzllO6lkdagWlqPE+7lDs+05H1QVtRYBkvGrRocnFmESGrGliysS8QwGeI8w= X-Received: by 2002:a5d:5387:0:b0:236:86f2:b444 with SMTP id d7-20020a5d5387000000b0023686f2b444mr37791801wrv.58.1669808327735; Wed, 30 Nov 2022 03:38:47 -0800 (PST) MIME-Version: 1.0 From: dega kiran Date: Wed, 30 Nov 2022 17:08:26 +0530 Message-ID: Subject: Guest Display issue on Xen To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , ulien Grall Content-Type: multipart/alternative; boundary="00000000000037bce905eeae8cb2" --00000000000037bce905eeae8cb2 Content-Type: text/plain; charset="UTF-8" Hi, I am porting Xen Hypervisor on raspberry pi4. I could port xen minimal image as host & wayland based GUI image as guest. Now I am trying to bring up guest Display (using vncviewer) which is not coming up, even I could see xen-fbfront driver on guest and Debugged xen-fbfront.c Xenbusprobe_backend.c Xenbusprobe_frontend.c But not sure where is the actual issue. Let me know which part of code will help us more for better understanding the issue. --00000000000037bce905eeae8cb2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hi,

I am porting Xen Hypervisor on raspberry pi4. I= could port xen minimal image as host & wayland based GUI image as guest. Now I am = trying to bring up guest Display (using vncviewer) which is not coming up, even I = could see xen-fbfront driver on guest and Debugged

xen-fbfront.c

Xenbusprobe_backend.c

Xenbusprobe_frontend.c

But not sure where is the actual issue.<= /span>

Let me know which part of code will help us mor= e =C2=A0for better understanding the issue.

--00000000000037bce905eeae8cb2-- From xen-devel-bounces@lists.xenproject.org Wed Nov 30 12:01:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 12:01:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449833.706808 (Exim 4.92) (envelope-from ) id 1p0Lm2-00032z-6h; Wed, 30 Nov 2022 12:01:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449833.706808; Wed, 30 Nov 2022 12:01:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Lm2-00032s-3N; Wed, 30 Nov 2022 12:01:10 +0000 Received: by outflank-mailman (input) for mailman id 449833; Wed, 30 Nov 2022 12:01:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Lm0-0002lj-Sl for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 12:01:09 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0613.outbound.protection.outlook.com [2a01:111:f400:fe0e::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6fb517a-70a6-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 13:00:59 +0100 (CET) Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by GV1PR08MB8214.eurprd08.prod.outlook.com (2603:10a6:150:5d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Wed, 30 Nov 2022 11:59:32 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.5880.008; Wed, 30 Nov 2022 11:59:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6fb517a-70a6-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X/h9vc+YomeXYZyKpFEYuaCBY0jWdbY7CzOtU5dAsy+6sQzqiHg3WBfWGpAjMaZ+UI4Utnlh9nOCooAVSIGgsagA1eSYFsaYlDnyRHYVg3nPeRTZJZtZCVt+pTs9nGbN2V5TyB4bzkQOupXdITu02YXqz4DMD0iMpNXavTzBy7T9PuZI1R89W+syw05gLX9fY+NliRuf+RHpD1jjidF2jZBKYLAw1Y6HitqV31OvITGLyBgBcG4JWyZu306OuhSiuLYROcdC2SHvjFe1SHQiu8xvGfJ7qO7UASi6X/IFGi64rbXfS+0gcbWpqgpy2H+zIlRkAR4ZVrugv50Fh2Z88A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K0ojdY2up5dX1+6nF32AO7FJS3tHAvAaMV63VVhAdzI=; b=ISFNcgfGWglk/w5869O+cC4p/YsvpPt54p0zz2sB6nagPX7SwxzuW9vGjbD9utZRAETLCtNDB4hSMDSLdQpJdCba9o27aa2BrWEEUqhYeNDpdhiQG7vzsyukvLL6KpFWCOkTprHEMCDcgk5M9sRtTU+4a4MqU/ugjYNzMaqHv8HXRThCUyKhhhi5OvsK11rwnYAdGTQgylZzz1jOTrArB0p61f583EBdzsXQ3QnIZTwHt46XXCCrk4ndHwy+ejb9UqsTT1TqEZog/WlE9S5VOVFFdSZb7IXJ/Y5v9gAI7ZFKNJwujhSnfYSgBCpqDaQA8impZLBapOd8ijCsA0dW1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K0ojdY2up5dX1+6nF32AO7FJS3tHAvAaMV63VVhAdzI=; b=fbFFD9VWqtT+uzG5Pi2c1p/69pX0ai5i0R6ELQKaQlg8I8O94u+om4s1mk3Yi+qi5GaKb4seBDOMu9EKxCLilmsw00axCU6ErJH3V7jUHgmbtyWbr0PkVyEneoDu+g+DRS00G+ygcHTX+xq1CNonYPku0Qn2KoOEAy3Ygw63B8Q= From: Luca Fancellu To: Stefano Stabellini CC: Xen-devel , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH 2/4] xen/scripts: add cppcheck tool to the xen-analysis.py script Thread-Topic: [PATCH 2/4] xen/scripts: add cppcheck tool to the xen-analysis.py script Thread-Index: AQHZAzNLrQ+cdSzeJ02hq/RTLwHjha5WqVKAgAC2sIA= Date: Wed, 30 Nov 2022 11:59:32 +0000 Message-ID: References: <20221128141006.8719-1-luca.fancellu@arm.com> <20221128141006.8719-3-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|GV1PR08MB8214:EE_ x-ms-office365-filtering-correlation-id: 41022a09-ae82-4bcd-7ec3-08dad2ca57ee nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NrNKBUvSNSlUPQnAbZNUanvY7KbZfo3+wlAiH/IrHgli9eNFs4F4KKlogQvh5rI2ScDBnIc96wE4ItsIKOql3NtUaDIam8mFKIilJhSc4gymeYAU2uUh8ih/nVqSQ/TFp/iIybIBT8TPscnK0wucvb5wq7FcgJol4LtKy+pHklwcaVm0pk+p2YO2KQzx4OdCG0qEudb80DqqiIP1RykDqSkw7S144Sn7yprSDXd8yMBIwBc5RgMTwD/83UoQEPh4yS4gKzXiuh3+cpiPtwgpZ7LrYIVdqnjLJK9q50Fh3EauAxTcogGkMlx2lD8zdGH4Z7vYV5AKzcHyX5Mlhv/ulpE7Xz++SWdP0J94Kd0oZsm/Shp1CcBIRimCPS/9onlZFKjwlAfVbfQ/MAi1/5EOyt4lbF9x5CgCHVtHf1dGKExpbMLPN0IeKlXVIhsbcIENpb+SrArl0yL/Cu9Vhd1ONX9ZhwvYa9YPABoN1ZCgBfsNZAyaPekBIB68hJYc1iVa75pJcSTfJ6/R7I1Oti4INEYqjPislLtEJU07juUAVF06Mz/nb4FWr0KfhS2lGPLyNQ+l+z/kfF/2gMhE9VGTO01drP7ryCxIe0j0iHrxaEv0HAvkZIIdYfRuF0R3ZFxLeZyJfqEPwUg7NN+4bG46VLwseGXtFgIYLV94py2pu10D5DZsd5SSk6QRUNK/fwt0LPADMc2s2uRV/vJpL25apOLGPxBo0KlZAI1Wu7nvCx5LePHV5/2Y7URhGFm1cafrqoYpWg0yuHGxJGYoRBJDow== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(136003)(396003)(346002)(376002)(451199015)(66556008)(66476007)(8936002)(76116006)(91956017)(66946007)(4326008)(64756008)(66446008)(8676002)(2906002)(5660300002)(41300700001)(122000001)(38100700002)(2616005)(6916009)(6506007)(54906003)(316002)(966005)(6486002)(36756003)(26005)(478600001)(6512007)(186003)(71200400001)(33656002)(83380400001)(38070700005)(86362001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?S3B1WWo2eWxYbnFCeS9mVWhXMDh1MzB0OW5hRE12Z1h5SDJ0ZzJ6NmUrUmJC?= =?utf-8?B?Q09KalN4NUg4RVc2TWlRUTEvNDVheFkzcStIU1NwazUvMHZCYnU1V3V2SEZu?= =?utf-8?B?NFJDUWhXR3VsajFoMGdPZFd4UnAxV2FrZS9QZG1ZclJFYnZkUHg0Y2VUNFpl?= =?utf-8?B?WlRoZ2hMaWpNbDYzSWQzaHV4Q3l6QTBXemhSZjR6aTY3b0dDVi9KMzZOcTA2?= =?utf-8?B?Skg4NTQzUjZYNTJLczRHRXFTOEs2bkhqMW9MMUlMaFl4dHQ5ZEE0QkkyaWZl?= =?utf-8?B?U2pZWXlzdkQ1YXBML21MdTBod2V5alV0M3lVQTVoU3VEbjY0cEFYckZ5VUFQ?= =?utf-8?B?VHVubnB1NWsvOTdwcERadzdhN3N5S3hiRmdRNXpUeXZ2UkhhUkZRKzlITXFH?= =?utf-8?B?dFpQeXNKVU5jM1hwTnJxdFd5eU9XaXBFaUJTV2VZMjMvc0lKS1VEUDFhbkZP?= =?utf-8?B?SW9UV3M0d3g5YndCcXZjRGdkanFvRW1JeGJxOGpCbWs5VTBWc0FaeWpTdUJK?= =?utf-8?B?V3d0Qk5BNXV3aFM4MlFZSi9KZTVxOWE2cndHQ1FBRENMSWhoTDRoYzV6R1ky?= =?utf-8?B?MTNaVTBxU090U01JRmFRMnJxTTBZaEFKVXQrRDNKeXdjaWlYcStmSUNKQzNS?= =?utf-8?B?bEx0djFMT0xtbjF0RUwvdTJ0a0xlK0NSR1hVeXJJNWFHTmV6MlArUkNCOVZC?= =?utf-8?B?L2ZIbW9pNTIvWnlESy9QZFFyNVpzS0RRYWlFQnZTckFzSGZGWVRvQ1krRUg4?= =?utf-8?B?U0YvWENpMVhjQWVrcDRrUXRCdzdMMUs2QlZxSkRwc1RnZi9XckczTW0vdGlN?= =?utf-8?B?SUp0LzF4YTZBMnJIamVIWkR1SzVCWlY0QmZGM3cxM3ExZEZqTjJ0M1lycExr?= =?utf-8?B?K2N4b3lLTHRFYUtDZGFyMVh1ZHdvWFFTeWk1K29IaU1Nb3VRY0tSOTNmSDhY?= =?utf-8?B?S2tCUnp4dmQyS1BtZ1hyb0p4a0RMWWtEcElCOWxPMGEwUUduVEFEVW1qYzQ0?= =?utf-8?B?Q21WVHhuWlR5MXR4V1VYWVdoOEU2bkIyRHVCampBZWxrR2xXT3VKVzlqRTZL?= =?utf-8?B?V2VmdjdWaElCUlRsSFNIZllCWGtxeUpiRFc5K3NnVWMrV3N0UVRFY3JYM29F?= =?utf-8?B?c0ZHOGQ0MjFKMjdMSzNTcGRZZlBWeElJLzhPMjVSL1QvbUs1QW8wNDdqRmNz?= =?utf-8?B?NU1yaEVGZlc5Vm8yaXBYRko3R2huZ1VyRDFaajVEOWFaZ0IzVEdZcFlHY21Z?= =?utf-8?B?OGFZRGlHdzJ0QlhZdUthVDRJbzNiVmp0Zk9UZDJMY1U2Z2ViRGNLbTNHNjhm?= =?utf-8?B?aGNWTE1XUklrdk1ReG0yQkl4MXFsUmttZm9pL1c0YnhLcWdRVm1zbzJtVith?= =?utf-8?B?NW5GdXpTSWVjM3BuYTNUeVZ1a0VZL1JlTURhekRVMzcvQUlFTTZpVHNwYk1l?= =?utf-8?B?d2ZsM0E0MU9oQmYwV0JzTHY4ZnFqNWo5WER6ODZ2Sk40dFdZaHE3MEIrTys2?= =?utf-8?B?b0xYZ3d4a1dFdGFxUkZRZUVEZTc4cXpCY01STzNlazF6M2k4ZERZdWxQMFly?= =?utf-8?B?YUpUSWtNZHZ6QUM4M0J4YTZlZC90azBXSnp2aW96dDR3NStaTlBKM3FEYnZP?= =?utf-8?B?SmtaM1U0Z1ZyY1YwdDlBT3JXOFZBcXEzU0VIeGlNRmpkams1SDJnMmZmanRw?= =?utf-8?B?YlU4YWkzTnZSdzl1M3lzMG9aV1FmaENmZC93OEVneHUrOWsrT3FOQm5nc0k1?= =?utf-8?B?MkswUmpUSTI2bTYrTTdFc3ZGVHB5d2ZKNzNiY3pJeXlpSE9lM3VIY0JUVjBr?= =?utf-8?B?eEZsY1dGVmI4QjRRb0FBbVl1SnpjTE9DcE80L1ZZalhJTHZGMnR1STcvVFNl?= =?utf-8?B?Y0o0TFJiWVFBQnhYV3F4K24rYXB1TmlsSGxOczB3VUszQTB3S2lCYTc4TUE4?= =?utf-8?B?MWpxTEZ0VE44NnVRYlQwRlpEOUpIT0ZlSThkUG0xM0g3M3kxa2twb0JyYXQ5?= =?utf-8?B?Z0xPckVjNWVDVmpVamQyL2RadG9kcExRNzVJSDF2SHIvTy9HTElsSE1vYkxm?= =?utf-8?B?eG9ING1jWU1GajhhNHBlNU02NE9rbHVMWkhDRUhGNExCb2FxaE1nTVBsNWJC?= =?utf-8?B?N1E1OUJ1Y01iSXR1cVhJK09UcjJVbWZjOVVvMktndWFjRkw3R2pseUJSVHJt?= =?utf-8?B?ZkE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB3749.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41022a09-ae82-4bcd-7ec3-08dad2ca57ee X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 11:59:32.6664 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EYT6dCVlT0W9+vj+qLw6InFM2rMpe0zpuBi3OwP0UmpXIbRWfGESqQ/Huiyl6cfi3+VLGQcDdKSwuQnieJw9kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8214 SGkgU3RlZmFubywNCg0KPiBJIHRoaW5rIHRoZSByZXZlcnQgb2YgdGhlIGNwcGNoZWNrIGludGVn cmF0aW9uIGluIHhlbi9NYWtlZmlsZSBhbmQNCj4geGVuL3Rvb2xzL21lcmdlX2NwcGNoZWNrX3Jl cG9ydHMucHkgY291bGQgYmUgYSBzZXBhcmF0ZSBwYXRjaC4gVGhlcmUgaXMNCj4gbm8gbmVlZCB0 byBtYWtlIHN1cmUgY3BwY2hlY2sgc3VwcG9ydCBpbiB0aGUgeGVuIE1ha2VmaWxlIGlzDQo+ICJi aXNlY3RhYmxlIi4gVGhhdCBwYXRjaCBjb3VsZCBoYXZlIG15IGFja2VkLWJ5IGFscmVhZHkuDQoN Ck9rIEkgd2lsbCBzcGxpdCB0aGVzZSBjaGFuZ2VzIGluIGEgZm9sbG93aW5nIHBhdGNoDQoNCj4g DQo+IEFsc28gdGhlIGRvY3VtZW50IGNoYW5nZXMgaW50cm9kdWNlZCBpbiB0aGlzIHBhdGNoIGhh dmUgbXkgcmV2aWV3ZWQtYnk6DQo+IC0gZG9jcy9taXNyYS9jcHBjaGVjay50eHQNCj4gLSBkb2Nz L21pc3JhL2RvY3VtZW50aW5nLXZpb2xhdGlvbnMucnN0DQo+IC0gZG9jcy9taXNyYS9mYWxzZS1w b3NpdGl2ZS1jcHBjaGVjay5qc29uDQo+IC0gZG9jcy9taXNyYS94ZW4tc3RhdGljLWFuYWx5c2lz LnJzdA0KDQpUaGFuayB5b3UsIHNob3VsZCBJIHB1dCB0aG9zZSBmaWxlcyBpbiBhIHNlcGFyYXRl IHBhdGNoIHdpdGggeW91ciByZXYtYnkgYmVmb3JlDQp0aGlzIHBhdGNoIG9yIHRoaXMgaXMganVz dCBhIGNvbW1lbnQgZm9yIHlvdSB0byByZW1lbWJlciB3aGljaCBmaWxlIHlvdSBhbHJlYWR5DQpy ZXZpZXdlZD8NCg0KPj4gDQo+PiArDQo+PiArZGVmIGdlbmVyYXRlX2NwcGNoZWNrX2RlcHMoKToN Cj4+ICsgICAgZ2xvYmFsIGNwcGNoZWNrX2V4dHJhX21ha2VfYXJncw0KPj4gKw0KPj4gKyAgICAj IENvbXBpbGUgZmxhZ3MgdG8gcGFzcyB0byBjcHBjaGVjazoNCj4+ICsgICAgIyAtIGluY2x1ZGUg Y29uZmlnLmggYXMgdGhpcyBpcyBwYXNzZWQgZGlyZWN0bHkgdG8gdGhlIGNvbXBpbGVyLg0KPj4g KyAgICAjIC0gZGVmaW5lIENQUENIRUNLIGFzIHdlIHVzZSBpdCB0byBkaXNhYmxlIG9yIGVuYWJs ZSBzb21lIHNwZWNpZmljIHBhcnQgb2YNCj4+ICsgICAgIyAgIHRoZSBjb2RlIHRvIHNvbHZlIHNv bWUgY3BwY2hlY2sgaXNzdWVzLg0KPj4gKyAgICAjIC0gZXhwbGljaXRlbHkgZW5hYmxlIHNvbWUg Y3BwY2hlY2sgY2hlY2tzIGFzIHdlIGRvIG5vdCB3YW50IHRvIHVzZSAiYWxsIg0KPj4gKyAgICAj ICAgd2hpY2ggaW5jbHVkZXMgdW51c2VkRnVuY3Rpb24gd2hpY2ggZ2l2ZXMgd3JvbmcgcG9zaXRp dmVzIGFzIHdlIGNoZWNrDQo+PiArICAgICMgICBmaWxlIHBlciBmaWxlLg0KPj4gKyAgICAjIC0g RXhwbGljaXRseSBzdXBwcmVzcyB3YXJuaW5ncyBvbiBjb21waWxlci1kZWYuaCBiZWNhdXNlIGNw cGNoZWNrIHRocm93cw0KPj4gKyAgICAjICAgYW4gdW5tYXRjaGVkU3VwcHJlc3Npb24gZHVlIHRv IHRoZSBydWxlIHdlIHB1dCBpbiBzdXBwcmVzc2lvbi1saXN0LnR4dA0KPj4gKyAgICAjICAgdG8g c2tpcCBldmVyeSBmaW5kaW5nIGluIHRoZSBmaWxlLg0KPj4gKyAgICAjDQo+PiArICAgICMgQ29t cGlsZXIgZGVmaW5lcyBhcmUgaW4gY29tcGlsZXItZGVmLmggd2hpY2ggaXMgaW5jbHVkZWQgaW4g Y29uZmlnLmgNCj4+ICsgICAgIw0KPj4gKyAgICBjcHBjaGVja19mbGFncz0iIiINCj4+ICstLWNw cGNoZWNrLWJ1aWxkLWRpcj17fS97fQ0KPj4gKyAtLW1heC1jdHUtZGVwdGg9MTANCj4+ICsgLS1l bmFibGU9c3R5bGUsaW5mb3JtYXRpb24sbWlzc2luZ0luY2x1ZGUNCj4+ICsgLS10ZW1wbGF0ZT1c J3t7ZmlsZX19KHt7bGluZX19LHt7Y29sdW1ufX0pOnt7aWR9fTp7e3NldmVyaXR5fX06e3ttZXNz YWdlfX1cJw0KPj4gKyAtLXJlbGF0aXZlLXBhdGhzPXt9DQo+PiArIC0taW5saW5lLXN1cHByDQo+ PiArIC0tc3VwcHJlc3Npb25zLWxpc3Q9e30vc3VwcHJlc3Npb24tbGlzdC50eHQNCj4+ICsgLS1z dXBwcmVzcz0ndW5tYXRjaGVkU3VwcHJlc3Npb246KmdlbmVyYXRlZC9jb21waWxlci1kZWYuaCcN Cj4+ICsgLS1pbmNsdWRlPXt9L2luY2x1ZGUveGVuL2NvbmZpZy5oDQo+IA0KPiBJIG5vdGljZWQg dGhhdCBzb21lIG9mIHRoZSBpbmNsdWRlcyB3ZSB1c2VkIHRvIGhhdmUgbGlrZQ0KPiB4c20vZmxh c2svaW5jbHVkZSBhcmUgbWlzc2luZyBoZXJlLiBJcyB0aGF0IGludGVuZGVkPw0KDQpZZXMgaXQg aXMsIG5vdyB0aGF0IGNwcGNoZWNrIGlzIHVzaW5nIHRoZSBKU09OIGNvbXBpbGF0aW9uIGRhdGFi YXNlLCBpdCBjYW4gdW5kZXJzdGFuZA0KYnkgdGhlIGNvbXBpbGF0aW9uIGFyZ3VtZW50IOKAnC1J 4oCdIHdoYXQgaW5jbHVkZSBwYXRoIGl0IG5lZWRzIHRvIGFkZCwgYmVmb3JlIHdlIHdlcmUNCmFk ZGluZyBpdCB0byBldmVyeSBmaWxlLCByZXN1bHRpbmcgaW4gc29tZSBmYWxzZSBwb3NpdGl2ZSBm cm9tIHRoZSB0b29sLg0KSnVzdCAtLWluY2x1ZGU9e30vaW5jbHVkZS94ZW4vY29uZmlnLmggaXMg bmVlZGVkIGJlY2F1c2UgaW4gdGhlIFhlbiBtYWtlZmlsZSB3ZSBhcmUgZG9pbmcNCnRoZSBzYW1l LCBwYXNzaW5nIHRoZSBvcHRpb24gdG8gdGhlIGNvbXBpbGVyLCByZXN1bHRpbmcgaW4gZXZlcnkg Y29tcGlsZWQgZmlsZSB0byBoYXZlIHRoYXQNCmhlYWRlciBpbmNsdWRlZC4NCg0KPj4gDQo+PiAr ICAgIGNhc2UgJHtPUFRJT059IGluDQo+PiArICAgICAgICAtaHwtLWhlbHApDQo+PiArICAgICAg ICAgICAgaGVscA0KPj4gKyAgICAgICAgICAgIGV4aXQgMA0KPj4gKyAgICAgICAgICAgIDs7DQo+ PiArICAgICAgICAtLWNvbXBpbGVyPSopDQo+PiArICAgICAgICAgICAgQ09NUElMRVI9IiQoZXZh bCBlY2hvICIke09QVElPTiMqPX0iKSINCj4gDQo+IFRoaXMgY2FuIGJlOg0KPiANCj4gQ09NUElM RVI9IiR7T1BUSU9OIyo9fSINCj4gDQo+IGFuZCBzYW1lIGZvciBhbGwgdGhlIG90aGVyIGJlbG93 DQoNCk9rIEnigJlsbCBmaXggdGhhdA0KDQo+IA0KPiANCj4+ICsgICAgICAgICAgICBzbV90b29s X2FyZ3M9Im4iDQo+PiArICAgICAgICAgICAgOzsNCj4+ICsgICAgICAgIC0tY3BwY2hlY2stY21k PSopDQo+PiArICAgICAgICAgICAgQ1BQQ0hFQ0tfVE9PTD0iJChldmFsIGVjaG8gIiR7T1BUSU9O Iyo9fSIpIg0KPj4gKyAgICAgICAgICAgIHNtX3Rvb2xfYXJncz0ieSINCj4+ICsgICAgICAgICAg ICA7Ow0KPj4gKyAgICAgICAgLS1jcHBjaGVjay1odG1sKQ0KPj4gKyAgICAgICAgICAgIENQUENI RUNLX0hUTUw9InkiDQo+PiArICAgICAgICAgICAgc21fdG9vbF9hcmdzPSJuIg0KPj4gKyAgICAg ICAgICAgIDs7DQo+PiArICAgICAgICAtLWNwcGNoZWNrLXBsYXQ9KikNCj4+ICsgICAgICAgICAg ICBDUFBDSEVDS19QTEFUX1BBVEg9IiQoZXZhbCBlY2hvICIke09QVElPTiMqPX0iKSINCj4+ICsg ICAgICAgICAgICBzbV90b29sX2FyZ3M9Im4iDQo+PiArICAgICAgICAgICAgOzsNCj4+ICsgICAg ICAgIC0taWdub3JlLXBhdGg9KikNCj4+ICsgICAgICAgICAgICBJR05PUkVfUEFUSF9MSVNUPSIk e0lHTk9SRV9QQVRIX0xJU1R9ICQoZXZhbCBlY2hvICIke09QVElPTiMqPX0iKSINCj4+ICsgICAg ICAgICAgICBzbV90b29sX2FyZ3M9Im4iDQo+PiArICAgICAgICAgICAgOzsNCj4+ICsgICAgICAg IC0tKQ0KPj4gKyAgICAgICAgICAgIGZvcndhcmRfdG9fY2M9InkiDQo+PiArICAgICAgICAgICAg c21fdG9vbF9hcmdzPSJuIg0KPj4gKyAgICAgICAgICAgIDs7DQo+PiArICAgICAgICAqKQ0KPj4g KyAgICAgICAgICAgIGlmIFsgIiR7c21fdG9vbF9hcmdzfSIgPSAieSIgXTsgdGhlbg0KPj4gKyAg ICAgICAgICAgICAgICBDUFBDSEVDS19UT09MX0FSR1M9IiR7Q1BQQ0hFQ0tfVE9PTF9BUkdTfSAk e09QVElPTn0iDQo+PiArICAgICAgICAgICAgZWxzZQ0KPj4gKyAgICAgICAgICAgICAgICBlY2hv ICJJbnZhbGlkIG9wdGlvbiAke09QVElPTn0iDQo+PiArICAgICAgICAgICAgICAgIGV4aXQgMQ0K PiANCj4gSXQgZG9lc24ndCBsb29rIGxpa2Ugc21fdG9vbF9hcmdzIGlzIHJlYWxseSBuZWVkZWQ/ IEl0IGlzIG9ubHkgc2V0IHRvDQo+ICd5JyBpbiB0aGUgY2FzZSBvZiAtLWNwcGNoZWNrLWNtZCwg YW5kIGluIHRoYXQgY2FzZSB3ZSBhbHNvIHNldA0KPiBDUFBDSEVDS19UT09MLiBDUFBDSEVDS19U T09MIGlzIHRoZSB2YXJpYWJsZSB1c2VkIGJlbG93LiBBbSBJIG1pc3NpbmcNCj4gc29tZXRoaW5n Pw0KDQpXZSB1c2Ugc21fdG9vbF9hcmdzIHRvIGZpbGwgQ1BQQ0hFQ0tfVE9PTF9BUkdTLCBiYXNp Y2FsbHkgaXTigJlzIGEgc3RhdGUgbWFjaGluZSB3aGVyZQ0Kd2hlbiB3ZSBmaW5kIC0tY3BwY2hl Y2stY21kPTx4eHg+IHdlIGV4cGVjdCB0aGF0IGV2ZXJ5IG90aGVyIHNwYWNlIHNlcGFyYXRlZCBh cmd1bWVudHMNCnBhc3NlZCBhZnRlcndhcmRzIGFyZSB0aGUgYXJncyBmb3IgY3BwY2hlY2ssIHNv IHdlIGFwcGVuZCB0byBDUFBDSEVDS19UT09MX0FSR1MNCnVudGlsIHdlIGZpbmQgYW4gYXJndW1l bnQgdGhhdCBpcyBzdXBwb3NlZCB0byBiZSBvbmx5IGZvciB0aGlzIHNjcmlwdC4NCg0KPiANCj4g DQo+PiArICAgICAgICAgICAgZmkNCj4+ICsgICAgICAgICAgICA7Ow0KPj4gKyAgICBlc2FjDQo+ PiArZG9uZQ0KPj4gKw0KPj4gK2lmIFsgIiR7Q09NUElMRVJ9IiA9ICIiIF0NCj4+ICt0aGVuDQo+ PiArICAgIGVjaG8gIi0tY29tcGlsZXIgYXJnIGlzIG1hbmRhdG9yeS4iDQo+PiArICAgIGV4aXQg MQ0KPj4gK2ZpDQo+PiArDQo+PiArZnVuY3Rpb24gcHJpbnRfZmlsZSgpIHsNCj4+ICsgICAgbG9j YWwgdGV4dD0iJHsxfSINCj4+ICsgICAgbG9jYWwgaW5pdF9maWxlPSIkezJ9Ig0KPj4gKw0KPj4g KyAgICBpZiBbICIke2luaXRfZmlsZX0iID0gInkiIF0NCj4+ICsgICAgdGhlbg0KPj4gKyAgICAg ICAgZWNobyAtZSAtbiAiJHt0ZXh0fSIgPiAiJHtKREJfRklMRX0iDQo+PiArICAgIGVsc2UNCj4+ ICsgICAgICAgIGVjaG8gLWUgLW4gIiR7dGV4dH0iID4+ICIke0pEQl9GSUxFfSINCj4+ICsgICAg ZmkNCj4gDQo+IFRoZSA+PiBjYW4gYmUgdXNlZCB0byBjcmVhdGUgYSBmaWxlIGlmIHRoZSBmaWxl IGlzIG5vdCBhbHJlYWR5IHByZXNlbnQuDQo+IFNvIHdoeSB0aGUgbmVlZCBmb3IgdGhpcyBpZj8g SW4gZmFjdCwgd2UgZG9uJ3QgbmVlZCBwcmludF9maWxlIGF0IGFsbA0KPiBhbmQgd2UgY2FuIGp1 c3QgDQo+IA0KPiAgZWNobyAtZSAtbiAic29tZXRoaW5nIiA+PiAiJHtKREJfRklMRX0iDQo+IA0K PiBkaXJlY3RseSBmcm9tIGNyZWF0ZV9qY2QuIElmIHlvdSBhcmUgY29uY2VybmVkIGFib3V0IGEg cHJlZXhpc3RpbmcgZmlsZSwNCj4gdGhlbiBhdCB0aGUgYmVnaW5uaW5nIG9mIGNyZWF0ZV9qY2Qg eW91IGNhbjoNCj4gDQo+ICBybSAiJHtKREJfRklMRX0iDQoNCk9rIEnigJlsbCByZW1vdmUgdGhl IGZpbGUgaW4gdGhlIHRvcCBvZiBjcmVhdGVfamNkIGFuZCB1c2UgZWNobyAtZSAtbiAic29tZXRo aW5nIiA+PiAiJHtKREJfRklMRX3igJ0NCg0KPj4gDQo+PiArDQo+PiArICAgICAgICAjIENoZWNr IHdjaGFyIHNpemUNCj4+ICsgICAgICAgIHdjaGFyX3BsYXRfc3VmZml4PSJ0NCINCj4+ICsgICAg ICAgICMgc2VkIHByaW50cyB0aGUgbGFzdCBvY2N1cmVuY2Ugb2YgLWYobm8tKXNob3J0LXdjaGFy IHdoaWNoIGlzIHRoZSBvbmUNCj4+ICsgICAgICAgICMgYXBwbGllZCB0byB0aGUgZmlsZSBieSB0 aGUgY29tcGlsZXINCj4+ICsgICAgICAgIHdjaGFyX29wdGlvbj0kKGVjaG8gIiR7Rk9SV0FSRF9G TEFHU30iIHwgXA0KPj4gKyAgICAgICAgICAgIHNlZCAtbnJlICdzLC4qKC1mKG5vLSk/c2hvcnQt d2NoYXIpLiosXDEscCcpDQo+PiArICAgICAgICBpZiBbICIke3djaGFyX29wdGlvbn0iID0gIi1m c2hvcnQtd2NoYXIiIF0NCj4+ICsgICAgICAgIHRoZW4NCj4+ICsgICAgICAgICAgICB3Y2hhcl9w bGF0X3N1ZmZpeD0idDIiDQo+PiArICAgICAgICBmaQ0KPiANCj4gVGhpcyBzZWVtcyBhIGJpdCB1 bm5lY2Vzc2FyeTogd2Ugc2hvdWxkIGJlIGFibGUgdG8gZmluZCB0aGUgcmlnaHQNCj4gcGxhdGZv cm0gZmlsZSBmcm9tIFhFTl9UQVJHRVRfQVJDSCBhbG9uZS4gTm8gbmVlZCB0byByZXZlcnNlIGVu Z2luZWVyDQo+IHRoZSBjb21waWxlciBjb21tYW5kIGxpbmU/DQoNClRoZSBlZmkgY29kZSBpcyBj b21waWxlZCB3aXRoIC1mc2hvcnQtd2NoYXIsIGJ1dCB0aGUgcmVzdCBvZiB0aGUgZmlsZSB1c2Vz IGRlZmF1bHQgbGVuZ3RoIHdjaGFyLA0Kbm93IG1heWJlIGl0IHdhcyBhIGJpdCBvZiBvdmVydGhp bmtpbmcgYmVjYXVzZSBJIGd1ZXNzIHdlIGhhdmUgb25seSB0aGVzZSBjYXNlczoNCg0KYXJtNjQ6 ICAgYXJtNjQtd2NoYXJfdDIgKGVmaSBjb2RlIHVzZXMgLWZzaG9ydC13Y2hhcikNCmFybTMyOiAg IGFybTMyLXdjaGFyX3Q0IChlZmkgY29kZSBpcyBub3QgaW4sIGJ1dCBjb21tb24tc3R1YiBjb21w aWxlZCB3aXRoIC1mLW5vLXNob3J0LXdjaGFyKQ0KeDg2XzY0OiB4ODZfNjQtd2NoYXJfdDIgKGVm aSBjb2RlIHVzZXMgLWZzaG9ydC13Y2hhcikNCg0KQW0gSSByaWdodD8gDQoNCj4gDQo+IA0KPj4g Kw0KPj4gKyAgICAgICAgIyBTZWxlY3QgdGhlIHJpZ2h0IHRhcmdldCBwbGF0Zm9ybSwgQVJDSCBp cyBnZW5lcmF0ZWQgZnJvbSBYZW4gTWFrZWZpbGUNCj4+ICsgICAgICAgIHBsYXRmb3JtPSIke0NQ UENIRUNLX1BMQVRfUEFUSH0vJHtBUkNIfS13Y2hhcl8ke3djaGFyX3BsYXRfc3VmZml4fS54bWwi DQo+PiArICAgICAgICBpZiBbICEgLWYgIiR7cGxhdGZvcm19IiBdDQo+PiArICAgICAgICB0aGVu DQo+PiArICAgICAgICAgICAgZWNobyAiJHtwbGF0Zm9ybX0gbm90IGZvdW5kISINCj4+ICsgICAg ICAgICAgICBleGl0IDENCj4+ICsgICAgICAgIGZpDQo+PiArDQo+PiArICAgICAgICAjIFNoZWxs Y2hlY2sgY29tcGxhaW5zIGFib3V0IG1pc3NpbmcgcXVvdGVzIG9uIENQUENIRUNLX1RPT0xfQVJH UywgYnV0DQo+PiArICAgICAgICAjIHRoZXkgY2FuJ3QgYmUgdXNlZCBoZXJlDQo+PiArICAgICAg ICAjIHNoZWxsY2hlY2sgZGlzYWJsZT1TQzIwODYNCj4+ICsgICAgICAgICR7Q1BQQ0hFQ0tfVE9P TH0gJHtDUFBDSEVDS19UT09MX0FSR1N9IFwNCj4+ICsgICAgICAgICAgICAtLXByb2plY3Q9IiR7 SkRCX0ZJTEV9IiBcDQo+PiArICAgICAgICAgICAgLS1vdXRwdXQtZmlsZT0iJHtvdXRfZmlsZX0i IFwNCj4+ICsgICAgICAgICAgICAtLXBsYXRmb3JtPSR7cGxhdGZvcm19DQo+PiArDQo+PiArICAg ICAgICBpZiBbICIke0NQUENIRUNLX0hUTUx9IiA9ICJ5IiBdDQo+PiArICAgICAgICB0aGVuDQo+ PiArICAgICAgICAgICAgIyBTaGVsbGNoZWNrIGNvbXBsYWlucyBhYm91dCBtaXNzaW5nIHF1b3Rl cyBvbiBDUFBDSEVDS19UT09MX0FSR1MsDQo+PiArICAgICAgICAgICAgIyBidXQgdGhleSBjYW4n dCBiZSB1c2VkIGhlcmUNCj4+ICsgICAgICAgICAgICAjIHNoZWxsY2hlY2sgZGlzYWJsZT1TQzIw ODYNCj4+ICsgICAgICAgICAgICAke0NQUENIRUNLX1RPT0x9ICR7Q1BQQ0hFQ0tfVE9PTF9BUkdT fSBcDQo+PiArICAgICAgICAgICAgICAgIC0tcHJvamVjdD0iJHtKREJfRklMRX0iIFwNCj4+ICsg ICAgICAgICAgICAgICAgLS1vdXRwdXQtZmlsZT0iJHtvdXRfZmlsZSUudHh0fS54bWwiIFwNCj4+ ICsgICAgICAgICAgICAgICAgLS1wbGF0Zm9ybT0ke3BsYXRmb3JtfSBcDQo+PiArICAgICAgICAg ICAgICAgIC1xIFwNCj4+ICsgICAgICAgICAgICAgICAgLS14bWwNCj4gDQo+IFRoaXMgaXMgc2hv d2luZyBteSBpZ25vcmFuY2UgaW4gY3BwY2hlY2ssIGJ1dCBkb2VzIGl0IGFjdHVhbGx5IG5lZWQg dG8NCj4gYmUgY2FsbGVkIHR3aWNlIGluIHRoZSBodG1sIGdlbmVyYXRpb24gY2FzZT8gQWN0dWFs bHkgdGhyZWUgdGltZXMgaWYgd2UNCj4gY291bnQgdGhlIGV4dHJhIGNwcGNoZWNrLWh0bWxyZXBv cnQgY2FsbD8NCg0KQ3BwY2hlY2sgaXMgbm90IGFibGUgdG8gb3V0cHV0IGEgdGV4dCByZXBvcnQg YW5kIGFuIFhNTCByZXBvcnQgYXQgdGhlIHNhbWUgdGltZSwNCmhlbmNlIHdlIG5lZWQgdG8gY2Fs bCBpdCB0d2ljZSwgYnV0IHRoZSBzZWNvbmQgY2FsbCB3aWxsIHVzZSB0aGUgY3BwY2hlY2sgYnVp bGQgZGlyZWN0b3J5DQpBcyBhIOKAnGNhY2hl4oCdIHRvIGdlbmVyYXRlIHRoZSByZXN1bHRzIHNv IGl0IHdpbGwgYmUgbXVjaCBtb3JlIGZhc3RlciB0aGFuIHRoZSBmaXJzdCBvbmUuDQoNCj4gDQo+ IA0KPj4gKyAgICAgICAgZmkNCj4+ICsgICAgZmkNCj4+ICtmaQ0KPj4gZGlmZiAtLWdpdCBhL3hl bi90b29scy9jcHBjaGVjay1wbGF0L2FybTMyLXdjaGFyX3Q0LnhtbCBiL3hlbi90b29scy9jcHBj aGVjay1wbGF0L2FybTMyLXdjaGFyX3Q0LnhtbA0KPj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4+ IGluZGV4IDAwMDAwMDAwMDAwMC4uM2FlZmE3YmE1Yzk4DQo+PiAtLS0gL2Rldi9udWxsDQo+PiAr KysgYi94ZW4vdG9vbHMvY3BwY2hlY2stcGxhdC9hcm0zMi13Y2hhcl90NC54bWwNCj4+IEBAIC0w LDAgKzEsMTcgQEANCj4+ICs8P3htbCB2ZXJzaW9uPSIxLjAiPz4NCj4+ICs8cGxhdGZvcm0+DQo+ PiArICA8Y2hhcl9iaXQ+ODwvY2hhcl9iaXQ+DQo+PiArICA8ZGVmYXVsdC1zaWduPnVuc2lnbmVk PC9kZWZhdWx0LXNpZ24+DQo+IA0KPiB1c3VhbGx5IGluIEMgdGhlIGRlZmF1bHQgaXMgYWN0dWFs bHkgInNpZ25lZCIgbm90ICJ1bnNpZ25lZCIuIElmIHlvdQ0KPiB3cml0ZToNCj4gDQo+ICBpbnQg aTsNCj4gDQo+IGkgaXMgc2lnbmVkDQoNCkl0IHRvb2sgbWUgYSBiaXQgdG8gdW5kZXJzdGFuZCB0 aGlzIGZpZWxkLCBhcyB0aGUgZG9jdW1lbnRhdGlvbiBpcyBub3QgY2xlYXIgYXQgYWxsLCB0aGUg ZGVmYXVsdC1zaWduIGlzIHJlZmVycmluZw0KdG8gdGhlIGRlZmF1bHQgY2hhciBzaWduLCB3aGlj aCBzaG91bGQgYmUgdW5zaWduZWQgZm9yIGFybSwgcmlnaHQ/DQoNCkhlcmUgdGhlIGNvZGUgdG8g Y3BwY2hlY2sgdGhhdCBjbGFyaWZpZXMgdGhlIGZpZWxkOg0KDQpodHRwczovL2dpdGh1Yi5jb20v ZGFubWFyL2NwcGNoZWNrL2Jsb2IvMi43LjUvbGliL3BsYXRmb3JtLmNwcA0KDQpBdCBsaW5lIDIw NCwgZGVmYXVsdFNpZ24gaXMgdGFraW5nIHRoZSB2YWx1ZSBvZiA8ZGVmYXVsdC1zaWduPiwgYXQg bGluZSA2NCwgd2hlbiB0aGUgcGxhdGZvcm0gaXMgTmF0aXZlLA0KZGVmYXVsdFNpZ24gPSAoc3Rk OjpudW1lcmljX2xpbWl0czxjaGFyPjo6aXNfc2lnbmVkKSA/ICdzJyA6ICd1JzsNCg0KSeKAmXZl IGRvbmUgc29tZSB0ZXN0cyB3aXRoIHRoaXMgY29kZSBpbiBhcm0vYXJtNjQveDg2XzY0Og0KDQog ICAjZGVmaW5lIGlzX3R5cGVfc2lnbmVkKG15X3R5cGUpICgoKG15X3R5cGUpLTEpIDwgMCkNCiAg IGlmIChpc190eXBlX3NpZ25lZChjaGFyKSkNCiAgICAgICAgcHJpbnRmKCJzaWduZWRcbiIpOw0K ICAgIGVsc2UNCiAgICAgICAgcHJpbnRmKCJ1bnNpZ25lZFxuIik7DQoNCkFuZCBJIGhhdmUgdW5z aWduZWQgZm9yIGFybS9hcm02NCBhbmQgc2lnbmVkIGZvciB4ODZfNjQgKHdoaWNoIEkgd2lsbCBj aGFuZ2UgYXMgaXQgaXMgd3JvbmcgaW4gdGhpcyBwYXRjaCkNCg0KQ2FuIHlvdSBjb25maXJtIG15 IHJlc3VsdHMgYXJlIHJpZ2h0Pw0KDQo+PiANCj4+ICsrKyBiL3hlbi90b29scy9jcHBjaGVjay1w bGF0L2FybTY0LXdjaGFyX3QyLnhtbA0KPj4gQEAgLTAsMCArMSwxNyBAQA0KPj4gKzw/eG1sIHZl cnNpb249IjEuMCI/Pg0KPj4gKzxwbGF0Zm9ybT4NCj4+ICsgIDxjaGFyX2JpdD44PC9jaGFyX2Jp dD4NCj4+ICsgIDxkZWZhdWx0LXNpZ24+dW5zaWduZWQ8L2RlZmF1bHQtc2lnbj4NCj4+ICsgIDxz aXplb2Y+DQo+PiArICAgIDxzaG9ydD4yPC9zaG9ydD4NCj4+ICsgICAgPGludD40PC9pbnQ+DQo+ PiArICAgIDxsb25nPjg8L2xvbmc+DQo+PiArICAgIDxsb25nLWxvbmc+ODwvbG9uZy1sb25nPg0K Pj4gKyAgICA8ZmxvYXQ+NDwvZmxvYXQ+DQo+PiArICAgIDxkb3VibGU+ODwvZG91YmxlPg0KPj4g KyAgICA8bG9uZy1kb3VibGU+MTY8L2xvbmctZG91YmxlPg0KPj4gKyAgICA8cG9pbnRlcj44PC9w b2ludGVyPg0KPj4gKyAgICA8c2l6ZV90PjQ8L3NpemVfdD4NCj4gDQo+IElzbid0IHNpemVfdCA4 IGJ5dGVzIG9uIGFybTY0Pw0KDQpZZXMgeW91IGFyZSByaWdodCwgSSB3aWxsIGZpeCBpdA0KDQo+ IA0KPiANCj4+ICsgICAgPHdjaGFyX3Q+Mjwvd2NoYXJfdD4NCj4+ICsgIDwvc2l6ZW9mPg0KPj4g KzwvcGxhdGZvcm0+DQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 30 12:02:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 12:02:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449837.706819 (Exim 4.92) (envelope-from ) id 1p0Lmu-0003Wq-IR; Wed, 30 Nov 2022 12:02:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449837.706819; Wed, 30 Nov 2022 12:02:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Lmu-0003Wj-E1; Wed, 30 Nov 2022 12:02:04 +0000 Received: by outflank-mailman (input) for mailman id 449837; Wed, 30 Nov 2022 12:02:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Lmt-0003RW-0L for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 12:02:03 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0631.outbound.protection.outlook.com [2a01:111:f400:fe02::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c99e6c9f-70a6-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 13:01:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7595.eurprd04.prod.outlook.com (2603:10a6:10:20d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Wed, 30 Nov 2022 12:01:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 12:01:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c99e6c9f-70a6-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z2TQgGMkUCFeWM0NTOy+QTXn1sc2EWau9YIkZOD4k3eEWPReYBXBW9wcQJbIhaev5Lbxol/x/b1TmQWmXQgPJ1h79UXxuL6llGbd/jyV+lZ1K2Wo6i7GpTrWKiROlMh+pV1eJUJmzzAKQHLIZEqoOvp0NuknLtw/9HNWF/uxas98fi3VzgJHEFaJLwb+oRGCdjCmTH8U56Hq3jIDZ2DYxoEMrWA2F4ounf5rmFq+KbkY+T4lP4WXlVvnIY0e24RQ/EawsPGxUjWUzdY0aGlrQYFW0QcCCbmHKuTnhe2FBUcKohRjz1k0m4N7cGiwvlV0DCyD03wL5GaWb9896fqvRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jxGDAiMsGhspSjRoO+ViyEmOjq0u3fEicMhhyFsshd8=; b=fGMdhEqwmQGziYoZ9Bu6peGSQDiVeZ8YssAlrDmTu9z5h6Z3p7mbBb77+t6UYP6T+Ii4DuwhK5VkjUO61aIZ/v6S/kJX6Vdo1V1g43+g209Z7dS035//MEdWDm42fJ1Vzr6ssN/2hs0+ZKm5A9U19hPhcwbupix91fHiwBXuz21APSksHEmYEpWOxkfg+btXB5vqgg5A6fBvcrV85EYxGCBYFa05wjtQ+Q/oQa94MRBp106/NW8nP9d0qp3/k1CvKKz/HKX82Frai53F02kB9X4TJ2/WZl5cpEi+L55FW8jR1Jl4EgUINg6nQujUlLHJF3Djq1aqdzfYhVszYqgllQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jxGDAiMsGhspSjRoO+ViyEmOjq0u3fEicMhhyFsshd8=; b=h8Gkret/0HEZcwq3qehg//iJl+1pqWSzW9nniBkEBRsGz+5bwOIZyfwj6P7D4RCz275R0bXcgJkMlHyGKX/8oPBRZbPg8i12uIfyebqxknrNx6oAsi1eEtiwIll5nA1sWibIhX90jE3cDvzxfm0qk/xecBzZ8IFRw5bNbCyso9qrIlQabuBgSATjaYDzknQ9MN88kqxjMdpd2/yxthAbIVpEZo0Py/aW0wcYCQTb4M7Hr0batyMlT9qI66kliWT+EL99l1oIqmsUwU216BmraXS0XmnIUQD34YC5MGBoBzuGyZolxN43JWQAVKkz5iPNr1MIw0bVNZmA2DVlcIn+Ew== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 30 Nov 2022 13:01:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: Arm: AArch32: Need suggestions to support 32 bit physical addresses Content-Language: en-US To: Ayan Kumar Halder Cc: Stefano Stabellini , "Stabellini, Stefano" , bertrand Marquis , Andre Przywara , "Volodymyr_Babchuk@epam.com" , Rahul Singh , Vladimir Murzin , Julien Grall , "xen-devel@lists.xenproject.org" References: <70651dbc-085d-706d-17d0-a419086a0700@amd.com> <65891843-db28-e5dd-6e9e-3fb003fcabc5@amd.com> <105a0d45-5b3d-7986-92c1-9a13eb803bd8@amd.com> <22d28805-8889-25e9-6d18-c868bf5e51bb@suse.com> <21ae8452-167c-88d3-1604-162018408ea6@amd.com> From: Jan Beulich In-Reply-To: <21ae8452-167c-88d3-1604-162018408ea6@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7595:EE_ X-MS-Office365-Filtering-Correlation-Id: ae4d96f3-0435-4e40-7568-08dad2caaefd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 16KUo2HSsD6S2WMextSk99OAmJY9d2qlnsmBdcZzrGDu/DJfHXUcc+o0x0Qaa7He+3g+S+6YwHVEQZgT9Xp20vJwVNyeCiQ66RwiiLb9os4wPvymZ83i/zX84KVFMpeQkO05iG3Va4AgJDSqHxVfwJaGzGvVevEBKJ1S+tSfkMt1KcensqURO+4XlqDXUDjs8GwDGYfn9OMMSY8nO/3FaLUqNAoWYVaysZ5BKppEyBZVmuDiaTS5rB+cAwJlNCUNt53T5E8hYpP+p5ILsCrlwht23otcZJ00nAtjCYlfGnGW1dC1tkaOQFtB3vTr4rSCuRjIwZyk9NjpoUtqPkTw78yEFQKNHLwE76DdbW1sbw91YB5uBZKO+uxauQwCGh+yg/hekMTHBptzhkz4/9te5tG+fAMnqSfvzaGjystdcD+cEDC2VvPbFHPwgzzQfip5UegfM6T/wHgcw+9VKCdj3xgt3HOmPdXup3qepwYTufA5T6z2zY3Vgs0OekRiBx6GGlZixjnTm3wtt6hW+Or4SQLb/q4zCobvBCNrWTzjohehn8dNd9JUTaDs+perSSbxaVB4HEy7CBXUO2DX7RaHAnj6RCr/NnuNi8dUufTCYcLnQ2a8DSZuh2QZVXovWLvKgfsLY4975qe97aykDY+AQauZsO9euJRHYjmVrQL3IApy37aGrMMqpaFIZQJOgLJAU41vc5Yo1hTvWmW0L+PHw3KJBNCdneJlwteQDrQB7wk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(39860400002)(346002)(376002)(136003)(451199015)(316002)(6916009)(54906003)(7416002)(478600001)(38100700002)(5660300002)(86362001)(31696002)(41300700001)(36756003)(4326008)(66946007)(8936002)(66476007)(4744005)(66556008)(8676002)(186003)(6486002)(2616005)(31686004)(53546011)(6506007)(26005)(6512007)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXE1Q1VoVGdGeW9VaGgwOVBOaGpaTGQvVjRrSGZ1WnRUcmJicHFrRVV3aTVI?= =?utf-8?B?TGwvRjlOdll4VDBVd1BwVlB2dU1LdGlpZHR2d0NCTW1Ydi8rRTRlbk5VWEZH?= =?utf-8?B?UE9GYW90QXAzM1RJekNqa1ZDRjVXZVBKTGdTTXdkNER4S2w4Z2VpVm4wM1k2?= =?utf-8?B?SVNjUGpuZExKRTRMK1N4Q0xUeEZndndBU2hZaW96VlE1cDVleXdkZ3JvdURZ?= =?utf-8?B?QXA2VGl6RzR5MHowQkRycllRUEQvS2oxajZ3VEhzSlZXdHl4amJBZ29hb1Er?= =?utf-8?B?VVJibUl6WTdhTXRnd1BmdGpDc2VFeHFpT0c0cWFTY2RubFFMV0VLc2hudnY2?= =?utf-8?B?d05ld0JDV2x5NG5IQ1B5dW1RbUxzU0xISk5QdUVQbkZGNzFwdlRSVWVjb3B1?= =?utf-8?B?L0M1aXJuTUpQRDRLMzBIbmRqVUJkSEYvSTBCbGV4R0pYYThvK2NIaitsd0Ro?= =?utf-8?B?dEo5U2dJc2gwaDU3UDJJdHNoRUgrTDhKRnh3bTlEZm13Z2xlS1JxenIzZnp0?= =?utf-8?B?NUZqcmtiUjJ6NlpvTnk5U1VnZXFjNzYxc1N4N3FrYWl6TzVFVzQrMWlyUUhE?= =?utf-8?B?dGJ3MnU0aHFuVjlSdEh4Qm1iMkRhVjhZNlBEbzg2SmZaNEp5NzNyOTFSdGlZ?= =?utf-8?B?ZGNML2hSb3hrdjZza0pPZitlaDNPWHFhUC8xQnZnMUpvWU84bHNySllaa3V3?= =?utf-8?B?Z1VOTm9nbnFOOGZjdURHcjVmcUJQUE5aNkdCNExxcC9QeTRPNzVUSXZyVVNM?= =?utf-8?B?MHZrQ2lDL1hyQi9RYktHdk1xZy82NkMvYmhkb0VtWGFDb25FVlJiMTFheEJa?= =?utf-8?B?bUFuOU1MQjlsVEZyVFppMXp6U0s1RkdjdkJLTzVySEoxaitvK2hRLzhXYWtV?= =?utf-8?B?WjhiODIwNjlkL2lIa0tOOUtLaTkwamxhb3lGb0RUQXh5TEhRaE4yY3dCWHlD?= =?utf-8?B?QzBvVkpkWHR1MGFPYk1KbFFIWmozZks4WStkYkRHT01vSHYzeHJEUDRDZGp1?= =?utf-8?B?ZlhHeERGc2x6TUZrNTRjWG1GTkUvWTB2cU9HQktRbkJzSjN6STE3MFdLWTNR?= =?utf-8?B?c1ZmN3lTU2h6VitVZFBWZ1phdDVDbUhuL2lydTEzOTFXdEtreUZPN2JtREJu?= =?utf-8?B?R0l3TXdSSHFETjRkb25BcjYrQVRSZjRTZHkyUFB6dlJxS0g4dU5uTTg0Nzh4?= =?utf-8?B?bDhTWTdtblVqU0U0bVNlaEt6UXFWVXRyeVZkWHVjTFArYWpzU3ZzQ1A3QWt2?= =?utf-8?B?S2dTSFV1bWNUVHhRZmlpMWFqcUttOVVnRnI3bVpEWGs3d0YxUXVCVDJ2U1hn?= =?utf-8?B?cVlvbjNNUmJLRklHN21SbVl5UzZra1NmaHVTZkpsOEYzMDkwTWxUY1VvVExk?= =?utf-8?B?cEQwUnpqOGw1elg4RDhMWk5Bdzg3elVuMTRFZG9rQUlLNlI0ZnRZeWxWNUR3?= =?utf-8?B?QjAxNDFuRDMyWHhCcmxNb2ZraDY3dkp6aW8wcE5iNURBZHR6OHVXRUdVTFl1?= =?utf-8?B?aVh6MndHb1N1MjFQSXRTMVo1OW9vUHczZEhXR1dyamdUL1IweDRydmlZVmx2?= =?utf-8?B?c1BFTlgyTDczSTlOUVhIcUsrQ29oTlRaclhvTUNhSWVxSTJpZXpITTVLY1Y2?= =?utf-8?B?QjdGa1RqZDZESzBiM1ZaN3QvRGVUbGF5NXBIdTZRSHNmVUZ2WWpKVGdJL0pH?= =?utf-8?B?SFMyTUtLQ01kQ1VtVml3WjUrQlR6UmUxV0J0NWU0YnQxbXlzT0Y1OEhEcmpj?= =?utf-8?B?R1k4QmNSOEJhcVQ0d0RnWmNOV3lsb3U3ZjZDUFNncitReEpJbEZyWTIvOUJV?= =?utf-8?B?T3ZpZnoyT3NGQ3Q5RWxsMDgvdytaNWVCOTBxdG93NVZqNC9FVGlCVkl6NGh6?= =?utf-8?B?cGFsN0ExKzNkUnhiS0ZQV1JEWmc1RW0zNHl5QzNtOUh5cWFFVURsNE9sdGJq?= =?utf-8?B?NlpuR0VSdXFOK2dzcHVuRHVwclFTNmhzVGNjZ3Qya2NYdktnUk5hR1plb1ZS?= =?utf-8?B?QVplWG8zUFBHYVZkbkFNR0xTVE5sWTBGZ3FkWU80Mm5xVE5qUTlPNWFsRkFs?= =?utf-8?B?ZnJtMVNyeEhvQm5UTzJ3bkNaNk5QNjNZMTcrZkZrQituOGMxL3ZIbktRRUZ2?= =?utf-8?Q?fi/A4V9mqRksdLNVMFBVJOPaJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae4d96f3-0435-4e40-7568-08dad2caaefd X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 12:01:59.0231 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X7mJ9BDLQNDtm2oBBEfOub1MPmmHPMlLaCn+YjnAcos6o6nANPFZXnLkEOLfIQaWNpAiK9o0wJdktbq6LjfAvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7595 On 30.11.2022 12:27, Ayan Kumar Halder wrote: > Looking at "min(flsl(mfn + 1) - 1 + PAGE_SHIFT, PADDR_BITS);", I do not > understand the reason for "... -1" (ie subtracting by 1). > > Do you know the reason ? That's because fls() and flsl() and friends return 1-based bit indexes (with 0 being returned when the input was zero), when we need 0-based values here. Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 30 12:15:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 12:15:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449845.706830 (Exim 4.92) (envelope-from ) id 1p0M04-0005Ox-RX; Wed, 30 Nov 2022 12:15:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449845.706830; Wed, 30 Nov 2022 12:15:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0M04-0005Oq-Oq; Wed, 30 Nov 2022 12:15:40 +0000 Received: by outflank-mailman (input) for mailman id 449845; Wed, 30 Nov 2022 12:15:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0M04-0005Ok-Bz for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 12:15:40 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id b0933d39-70a8-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 13:15:34 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B68F4D6E; Wed, 30 Nov 2022 04:15:44 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 740693F73D; Wed, 30 Nov 2022 04:15:37 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0933d39-70a8-11ed-8fd2-01056ac49cbb From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: michal.orzel@amd.com, Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 0/3] Yocto Gitlab CI Date: Wed, 30 Nov 2022 12:15:06 +0000 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series is a first attempt to check if we could use Yocto in gitlab ci to build and run xen on qemu for arm, arm64 and x86. The first patch is introducing a container template from which container files can be generated for all combinations we want to support (qemu arm, arm64 and x86 targets and hosts x86_64 and arm64). It is also introducing a generic build script (build-yocto.sh) that is used to create, build and run a Yocto project. The second patch is adding a way to easily clean locally created containers. The third patch is introducing some gitlab CI templates and jobs so that we can test a Xen source tree in gitlab-CI using Yocto. This has been tested on a x86 host machine and on an arm host machine (with mk_dsdt.c fix). Changes in v5: - automatic cleanup of generated docker files using INTERMEDIATE - typo fixes - rebase on Stefano's next branch - remove clean rule cleaning all containers Changes in v4: - rework the container generation to support multiple hosts - rework the container generation to use a single template for all docker files (make process is generating the docker files). Changes in v3: - limit number of jobs in yocto - do not copy build script inside container - add patch from Michal to create gitlab jobs Changes in v2: - remove gitignore patch which was merged - add a --dump-log support in build-yocto.sh script and use it during container creation to see the error logs. Bertrand Marquis (2): automation: Create Yocto docker images automation: Add a clean rule for containers Michal Orzel (1): automation: Add CI test jobs for Yocto automation/build/Makefile | 24 +- automation/build/yocto/build-yocto.sh | 351 +++++++++++++++++++++ automation/build/yocto/yocto.dockerfile.in | 114 +++++++ automation/build/yocto/yocto.inc | 42 +++ automation/gitlab-ci/test.yaml | 43 +++ 5 files changed, 572 insertions(+), 2 deletions(-) create mode 100755 automation/build/yocto/build-yocto.sh create mode 100644 automation/build/yocto/yocto.dockerfile.in create mode 100644 automation/build/yocto/yocto.inc -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 12:15:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 12:15:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449846.706841 (Exim 4.92) (envelope-from ) id 1p0M0F-0005h0-3Y; Wed, 30 Nov 2022 12:15:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449846.706841; Wed, 30 Nov 2022 12:15:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0M0F-0005gq-0E; Wed, 30 Nov 2022 12:15:51 +0000 Received: by outflank-mailman (input) for mailman id 449846; Wed, 30 Nov 2022 12:15:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0M0D-0005Ok-FF for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 12:15:49 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id b6834992-70a8-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 13:15:44 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B1039D6E; Wed, 30 Nov 2022 04:15:54 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 533EF3F73D; Wed, 30 Nov 2022 04:15:47 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6834992-70a8-11ed-8fd2-01056ac49cbb From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: michal.orzel@amd.com, Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 1/3] automation: Create Yocto docker images Date: Wed, 30 Nov 2022 12:15:07 +0000 Message-Id: <18861c0c9c547959900532e38df11b2d67f0a1cc.1669810269.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add containers suitable to run yocto kirkstone build based on ubuntu 22.04. It contains all packages required by Yocto and a checkout of the layers required to build Xen with Yocto. Add a generic docker image template to be used to automatically generate docker files for different configurations: - specific yocto version - different targets (qemu arm, arm64 and x86) - different host platforms (x86 or arm64) During a call to 'make all', only the images for the host platform we run it on in the CI is generated. If needed, images for an other host platform can be generated manually by calling the right make target (see make help). Add a build script to build and run xen on qemu using Yocto. The script supports arm32, arm64 and x86_64 and checks that dom0 is properly booting. At this stage this does not run any guest on top of dom0. The script is to be executed in one of the docker images to build and run a system using a Xen source tree. Signed-off-by: Bertrand Marquis --- Changes in v5: - typo fixes - add INTERMEDIATE to remove intermediate dockerfile - use container architecture - use full words in foreach loops - fix shellcheck findings in build-yocto.sh - rebase on sstabellini next branch Changes in v4: - Rework the system to have one dockerfile template from which make will generate the required dockerfiles for the wanted configuration - add support for different host architectures - Merge the generation system into one single dockerfile - Merge patches 1 and 2 in a single patch - Introduce CONTAINERS_EXTRA to have extra containers not built by default (for those not used by CI but useful to users) Changes in v3: - limit number of jobs in yocto by default to 8 and add --num-jobs option to the script to set a custom number of jobs - do not copy anymore the build-yocto.sh script inside the main image so that the current one in the repository is used when running Changes in v2: - add a --dump-log command line option to build-yocto.sh script to dump the logs if an error occurs. Changes in v1: - add --image command line argument to build-yocto.sh to allow building something different than xen-image-minimal. - modify dockerfile to have one layer per line and make it easier to add other. I kept the for loop to keep the number of docker steps lower - update commit message to warn that no guest are tested. - fix build-yocto script to properly return with an error if expect script ends up in timeout or EOF. --- automation/build/Makefile | 14 +- automation/build/yocto/build-yocto.sh | 351 +++++++++++++++++++++ automation/build/yocto/yocto.dockerfile.in | 114 +++++++ automation/build/yocto/yocto.inc | 42 +++ 4 files changed, 519 insertions(+), 2 deletions(-) create mode 100755 automation/build/yocto/build-yocto.sh create mode 100644 automation/build/yocto/yocto.dockerfile.in create mode 100644 automation/build/yocto/yocto.inc diff --git a/automation/build/Makefile b/automation/build/Makefile index a4b2b85178cf..72a5335baec1 100644 --- a/automation/build/Makefile +++ b/automation/build/Makefile @@ -1,13 +1,18 @@ # the base of where these containers will appear REGISTRY := registry.gitlab.com/xen-project/xen -CONTAINERS = $(subst .dockerfile,,$(wildcard */*.dockerfile)) +CONTAINERS = $(filter-out yocto/%,$(subst .dockerfile,,$(wildcard */*.dockerfile))) +CONTAINERS_EXTRA = DOCKER_CMD ?= docker +include yocto/yocto.inc + help: @echo "Builds containers for building Xen based on different distros" @echo "To build one run 'make DISTRO/VERSION'. Available containers:" @$(foreach file,$(sort $(CONTAINERS)),echo ${file};) + @echo "Extra containers (not built using make all):" + @$(foreach file,$(sort $(CONTAINERS_EXTRA)),echo ${file};) @echo "To push container builds, set the env var PUSH" %: %.dockerfile ## Builds containers @@ -16,5 +21,10 @@ help: $(DOCKER_CMD) push $(REGISTRY)/$(@D):$(@F); \ fi -.PHONY: all +.PHONY: all clean all: $(CONTAINERS) + +# Remove generated dockerfiles for yocto +clean: + rm -f yocto/*.dockerfiles + diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh new file mode 100755 index 000000000000..f42fdf72d964 --- /dev/null +++ b/automation/build/yocto/build-yocto.sh @@ -0,0 +1,351 @@ +#!/bin/bash +# +# Yocto meta virtualization build and run script +# +# This script is building Yocto xen-image-minimal for qemu targets and run +# them using runqemu inside yocto to check that dom0 is booting properly. +# The build is using a local xen source tree so that specific patches can be +# tested. +# In order to optimize the build time, a build cache is used so that only xen +# packages and its dependencies are rebuilt (qemu and final image mainly). +# +# get command error even when piped. +set -o pipefail + +# Directories +YOCTODIR="$HOME/yocto-layers" +CACHEDIR="$HOME/yocto-cache" +LOGDIR="$HOME/logs" +XENDIR="$HOME/xen" +BUILDDIR="$HOME/build" + +# what yocto bsp we support +TARGET_SUPPORTED="qemuarm qemuarm64 qemux86-64" +VERBOSE="n" +TARGETLIST="" +BUILDJOBS="8" + +# actions to do +do_clean="n" +do_build="y" +do_run="y" +do_localsrc="n" +do_dump="n" +build_result=0 + +# layers to include in the project +build_layerlist="poky/meta poky/meta-poky poky/meta-yocto-bsp \ + meta-openembedded/meta-oe meta-openembedded/meta-python \ + meta-openembedded/meta-filesystems \ + meta-openembedded/meta-networking meta-virtualization" + +# yocto image to build +build_image="xen-image-minimal" + +function print_progress() { + echo -n "$(date +%T) $*" +} + +function run_task() { + local task_name="$1" + local task_target="$2" + + task_log="${task_name//project_}-${task_target}" + + mkdir -p "${LOGDIR}" + print_progress + echo -n "${task_name//project_} ${task_target}: " + if [ "${VERBOSE}" = "n" ]; then + "$@" > "${LOGDIR}/${task_log}.log" 2>&1 + else + "$@" 2>&1 | tee "${LOGDIR}/${task_log}.log" + fi + + if [ ${?} -ne 0 ]; then + echo "Error" + build_result=$((build_result+1)) + if [ "${do_dump}" = "y" ]; then + echo + echo "############ LOGS-START ############" + cat "${LOGDIR}/${task_log}.log" + echo "############ LOGS-END ############" + echo + fi + return 1 + else + echo "OK" + return 0 + fi +} + +function project_create() { + target="${1:?}" + destdir="${BUILDDIR}/${target}" + + ( + # init yocto project + source "${YOCTODIR}/poky/oe-init-build-env" "${destdir}" + + # add needed layers + for layer in ${build_layerlist}; do + bitbake-layers add-layer "${YOCTODIR}/${layer}" || exit 1 + done + ) || return 1 + + # customize project configuration + cat <> "${destdir}/conf/local.conf" +# Yocto BSP +MACHINE = "${target}" + +# Use local cache to reuse previous builds results +SSTATE_DIR = "${CACHEDIR}/sstate-cache" +DL_DIR = "${CACHEDIR}/downloads" + +# Enable xen and virtualization +DISTRO_FEATURES = " virtualization xen ipv4" + +# Speed up run by not generating ssh host keys +IMAGE_INSTALL:append:pn-xen-image-minimal = " ssh-pregen-hostkeys" + +# Save some disk space +INHERIT += "rm_work" + +# Reduce number of jobs +BB_NUMBER_THREADS="${BUILDJOBS}" + +EOF + + if [ "${do_localsrc}" = "y" ]; then + XENVERS=$(grep -e "^XEN_REL" \ + "${YOCTODIR}"/meta-virtualization/recipes-extended/xen/xen_*.bb \ + 2> /dev/null | tr -d ' ' | tr -d '?' | tr -d '"' \ + | sed -e "s/.*=//" | sort -V | tail -n 1) + + XENBASE=$(dirname "$(realpath -m "${XENDIR}")") + XENSUB=$(basename "$(realpath -m "${XENDIR}")") + + cat <> "${destdir}/conf/local.conf" +# Use local sources for xen and xen-tools +FILESEXTRAPATHS:prepend:pn-xen := "${XENBASE}:" +FILESEXTRAPATHS:prepend:pn-xen-tools := "${XENBASE}:" + +SRC_URI:pn-xen = "file://${XENSUB}/;subdir=local-xen/" +SRC_URI:pn-xen-tools = "file://${XENSUB}/;subdir=local-xen/" + +PREFERRED_VERSION:pn-xen = "${XENVERS}%" +PREFERRED_VERSION:pn-xen-tools = "${XENVERS}%" + +S:pn-xen = "\${WORKDIR}/local-xen/${XENSUB}" +S:pn-xen-tools = "\${WORKDIR}/local-xen/${XENSUB}" + +SRCREV:pn-xen = "\${AUTOREV}" +SRCREV:pn-xen-tools = "\${AUTOREV}" + +SRCPV:pn-xen = "1" +SRCPV:pn-xen-tools = "1" + +# Disable all QA errors as the recipe is not up to date with changes in Xen +# when we use local sources +ERROR_QA:pn-xen = "arch" +ERROR_QA:pn-xen-tools = "arch" + +EOF + fi +} + +function project_build() { + target="${1:?}" + destdir="${BUILDDIR}/${target}" + + ( + source "${YOCTODIR}/poky/oe-init-build-env" "${destdir}" + + bitbake "${build_image}" || exit 1 + ) || return 1 +} + +function project_clean() { + target="${1:?}" + destdir="${BUILDDIR}/${target}" + + rm -rf "${destdir}" +} + +function project_run() { + target="${1:?}" + destdir="${BUILDDIR}/${target}" + ( + source "${YOCTODIR}/poky/oe-init-build-env" "${destdir}" > /dev/null 2>&1 + + /usr/bin/expect < $$@ + +endef + +$(eval $(foreach version,$(YOCTO_VERSION),\ + $(foreach target,$(YOCTO_TARGETS),\ + $(foreach arch,$(YOCTO_ARCHS),\ + $(call GEN_DOCKER,$(version),$(target),$(arch),$(if $(filter amd64,$(arch)),,-$(arch))))))) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 12:15:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 12:15:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449847.706852 (Exim 4.92) (envelope-from ) id 1p0M0G-0005xO-C7; Wed, 30 Nov 2022 12:15:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449847.706852; Wed, 30 Nov 2022 12:15:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0M0G-0005xD-97; Wed, 30 Nov 2022 12:15:52 +0000 Received: by outflank-mailman (input) for mailman id 449847; Wed, 30 Nov 2022 12:15:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0M0F-0005h2-Gx for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 12:15:51 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ba6cb99f-70a8-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 13:15:50 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 75BCB12FC; Wed, 30 Nov 2022 04:15:56 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 348A93F73D; Wed, 30 Nov 2022 04:15:49 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba6cb99f-70a8-11ed-91b6-6bf2151ebd3b From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: michal.orzel@amd.com, Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 3/3] automation: Add CI test jobs for Yocto Date: Wed, 30 Nov 2022 12:15:09 +0000 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Michal Orzel Populate test jobs for Yocto based tests using the provided containers. Due to the size restrictions, it is currently not possible to split the build and run tasks, therefore everything is done in a single step. Test jobs for the supported Yocto targets are generic to avoid the necessity to add new ones after each Yocto release. The only thing required to be changed after updating the containers is the variable YOCTO_VERSION stored in a .yocto-test template. Signed-off-by: Michal Orzel --- Changes in v5: - none Changes in v4: - add .yocto-test for arm64 and x86 - make yocto jobs use arm64 version Changes in v3: - patch added --- automation/gitlab-ci/test.yaml | 43 ++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index c7e0078e04f1..6ce2fd63eee6 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -54,6 +54,33 @@ tags: - x86_64 +.yocto-test: + extends: .test-jobs-common + script: + - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` ${YOCTO_BOARD} + variables: + YOCTO_VERSION: kirkstone + CONTAINER: yocto:${YOCTO_VERSION}-${YOCTO_BOARD}-${YOCTO_HOST} + artifacts: + paths: + - 'logs/*' + when: always + needs: [] + +.yocto-test-arm64: + extends: .yocto-test + variables: + YOCTO_HOST: arm64v8 + tags: + - arm64 + +.yocto-test-x86-64: + extends: .yocto-test + variables: + YOCTO_HOST: amd64 + tags: + - x86_64 + # Test jobs build-each-commit-gcc: extends: .test-jobs-common @@ -188,3 +215,19 @@ qemu-smoke-x86-64-clang-pvh: - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE} needs: - debian-unstable-clang-debug + +# Yocto test jobs +yocto-qemuarm64: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemuarm64 + +yocto-qemuarm: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemuarm + +yocto-qemux86-64: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemux86-64 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 12:15:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 12:15:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449848.706863 (Exim 4.92) (envelope-from ) id 1p0M0H-0006E6-Kr; Wed, 30 Nov 2022 12:15:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449848.706863; Wed, 30 Nov 2022 12:15:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0M0H-0006Dr-HN; Wed, 30 Nov 2022 12:15:53 +0000 Received: by outflank-mailman (input) for mailman id 449848; Wed, 30 Nov 2022 12:15:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0M0G-0005h2-8z for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 12:15:52 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id b9e5904a-70a8-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 13:15:50 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 932D21042; Wed, 30 Nov 2022 04:15:55 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 51D583F73D; Wed, 30 Nov 2022 04:15:48 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9e5904a-70a8-11ed-91b6-6bf2151ebd3b From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: michal.orzel@amd.com, Doug Goldstein , Stefano Stabellini Subject: [PATCH v5 2/3] automation: Add a clean rule for containers Date: Wed, 30 Nov 2022 12:15:08 +0000 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add make clean support to remove the containers from the local docker registry. make clean- must be called to remove an image: make clean-yocto/kirkstone-qemuarm: remove yocto kirkstone for qemuarm image Signed-off-by: Bertrand Marquis --- Changes in v5: - remove cleaning of all images using make clean Changes in v4: - also generate clean rule for CONTAINERS_EXTRA Changes in v3: - none Changes in v2: - none Changes in v1: - patch added --- automation/build/Makefile | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/automation/build/Makefile b/automation/build/Makefile index 72a5335baec1..4cbb1365f94e 100644 --- a/automation/build/Makefile +++ b/automation/build/Makefile @@ -28,3 +28,13 @@ all: $(CONTAINERS) clean: rm -f yocto/*.dockerfiles +define CLEAN_RULE +.PHONY: clean-$(1) +clean-$(1): +ifneq ($$(shell docker image ls -q $(REGISTRY)/$(subst /,:,$(1))),) + docker image rm $(REGISTRY)/$(subst /,:,$(1)) +endif + +endef + +$(eval $(foreach img,$(CONTAINERS) $(CONTAINERS_EXTRA),$(call CLEAN_RULE,$(img)))) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 12:43:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 12:43:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449871.706874 (Exim 4.92) (envelope-from ) id 1p0MQt-0002UU-Uq; Wed, 30 Nov 2022 12:43:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449871.706874; Wed, 30 Nov 2022 12:43:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0MQt-0002UN-Ru; Wed, 30 Nov 2022 12:43:23 +0000 Received: by outflank-mailman (input) for mailman id 449871; Wed, 30 Nov 2022 12:43:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0MQs-0002UH-0R for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 12:43:22 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20610.outbound.protection.outlook.com [2a01:111:f400:7e88::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 908c28b9-70ac-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 13:43:19 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by SN7PR12MB7449.namprd12.prod.outlook.com (2603:10b6:806:299::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 12:43:16 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57%4]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 12:43:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 908c28b9-70ac-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dQzXxcwvTaAD6CcjUBbeFt5wnrWfr6RLvbvJCDSVhsQ3vYuKxTxDiruD1N33/NI22XGv6uanXCvTWSt7UxyrKeIN32+QixBbACa7pCXBE2yjRwLQIw9pvXK/ox0XY8CMaX5NGkWWVlGjmEXUiKf4AWtJWyoNePfVXPb3T9LLxDnUdgOwU64h0FtI8jIh8Hl4kCO2C2d/quEL/FylQ7rOYUKjnA41YteUeue2eTYdeFGprJgMm/CtsRSvoD0eQYwTml3vmnRA8gQRhTP5/7HHNmvU5QX2Xgis229w5AAML1XM/PIP7okNd8DEZvO6B/brb5UrxraYJ2lNdwcJuiJxrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YwnZRvaQilf5sgrXXdNIkyArvMuVhp1jNizG2R1Qvk0=; b=BLAL2D1maGAtTKXiB0cE9I+XvJYWNlCoSdNKhuhrCDkbDHRkNyREWbQGPqivSbItdDJR9RZyOiY5GB5QWj/L3dWxzFBLb1FemHTSj8WPvvKX7imG+xX1jqqRpgyg/l6XOFQ/GFxaHt8f5gWBJaijUPAiZhE8dRvn9QUTRjP+F3GoOaLnbIY8zwF0qm33FU2Nx5PB03Te7UW6IuVRZ6hUYnO3hp2HxuN56vTpzi3PSByXSy/uAKcmR2tNWQY5PgRNxXbMt3bO6sWfKwrkvr/oUPhgGu0GGl3rNXJE+gTmu0cVCluR6znuP3K6reYKmex9DrE+sa4JfIpwZJGUwSBikQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YwnZRvaQilf5sgrXXdNIkyArvMuVhp1jNizG2R1Qvk0=; b=iGUUXXClvKXpcCJVeJfWFHK8soDCd0c3F8ik3S54/7YKzFeE8AC8WqdzAknub6TQwxZCFu9+uaYXlshPfFAuq7U+YjhRUoAGB5+Xw01urLgQY13+uLN+//LElUELPZOfyscblf8/+0xFDe8IfPN2CmD5LAA4gMKZzVTTcUsOQPw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <60f34cf8-0b24-9b1e-c515-194b46615f35@amd.com> Date: Wed, 30 Nov 2022 12:43:09 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Arm: AArch32: Need suggestions to support 32 bit physical addresses To: Jan Beulich Cc: Stefano Stabellini , "Stabellini, Stefano" , bertrand Marquis , Andre Przywara , "Volodymyr_Babchuk@epam.com" , Rahul Singh , Vladimir Murzin , Julien Grall , "xen-devel@lists.xenproject.org" References: <70651dbc-085d-706d-17d0-a419086a0700@amd.com> <65891843-db28-e5dd-6e9e-3fb003fcabc5@amd.com> <105a0d45-5b3d-7986-92c1-9a13eb803bd8@amd.com> <22d28805-8889-25e9-6d18-c868bf5e51bb@suse.com> <21ae8452-167c-88d3-1604-162018408ea6@amd.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0118.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::8) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|SN7PR12MB7449:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b922012-ae40-4e1b-a71c-08dad2d0734e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FWWBR+xIHMrohdx6tPakVEEouwfxS9DWE/pzObHn/6IGzprkD2RoRD2E+/PDNA71DEjIqW+MOwsGBwjTOE1k3+wAXDJ8ZpNhi5pSJFJbeRfhlok/LgPMb9g+LPYyDkjTRSKhH+dqkOGO5BtDNB7/yzmGedJhJrX/7xCURMsJ8Wvao69JAqj9pTxTJApS3a4k5BqB8zTvCfkrpAFcx5UakmpbcGZgrVIk8GhG5dgbHtOmDqaRTjtO9lEfH55Vyunf4HFvXp73rGsZy4i1KLAFYNXKsVdIwYw1tQQtULIW2/iDgbZU3dWlheU8vBc+LX/G0eAUMIjQgJrHXS3eh+4wleQFTFILv4Ig85uPjoBdbJvMOtCbgc2dpmY271Nmg+h7Gq+jYRLOkjzbmnIpiFGhY/9eUUTvt1selH7mV0aQ3c5v29/EBZJ253NZdAwUZ+wPyZIqSqpwuwIffJg0oM4ZV41uFyQYnVdOCIQHitA90DeYEqG4Tum3gA59ta8xa83X5NYaI4tjEGuRIgpT2TEGaHA2gnHwina2xUwInglk1h96yo2s9xEduWhYooblIngXBMt8nnjXBxHAOy/XnfaWVhkjVl7HT7K9ftHw7I8u1p29JsFALWszN+pgrHgAaNsDJ9rzoJ/t/wvdMSQXRs3RtOO9Jlp0w6EesKbMLkdtbwsvhFo+5F1S0n5lduF2Rpkw/RBctMtbzNrHjXnILKEBWqUWHRNT9ltwDXbi+IBxdCs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(366004)(396003)(451199015)(66556008)(66946007)(31696002)(66476007)(2906002)(4326008)(8676002)(41300700001)(54906003)(316002)(6916009)(5660300002)(8936002)(6486002)(53546011)(6512007)(186003)(2616005)(6506007)(36756003)(26005)(478600001)(6666004)(38100700002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2NHakdmZ0ZDTktHYjNEUjgrRkUzWndZblV5dXRLV0ZYTC9GdEpkRUZuV3Yz?= =?utf-8?B?OWE2aHdNQlIraDYwckVvR1RvLzB0SkttQWRjdUFuNXhxNlZ0YmhXaTIxNllS?= =?utf-8?B?TlNKNFNucitaNG1zek9MakxvbUY0ME5zOXpLOUsvUUVxSzF2eFY0RHR1SFpy?= =?utf-8?B?alpCeWpLVnVwQ3dDUnYwN3B5Vm1DWGNNbUhjRElHNHk0N2piTTNzUlNMdzFL?= =?utf-8?B?bk12MlBIMG9ESU5ERlRyREZwUmZjcy9xand4VkZsTHkzbnBzb0J4VHRmMURH?= =?utf-8?B?RVB2dUEzNTc3eXQxTkxSYndRL1VuNURiQ29NSlZQOE1LVHl2SGJ5K1k2aXhC?= =?utf-8?B?S3BqdythM2RhWjB6SFFMQWtBcDZDQW9EOFM5Y2trUXJYLzlGNWNIVHVnUWFm?= =?utf-8?B?ZjdDc0hkSzVPdFNwRmdwK0tsaHRGWms0bDVJdXFXQzA5UmU5aG44WURqQStG?= =?utf-8?B?RjZWNUJHREhTUnlKVkRrRXJZRUxYVUlDZlJ3OEZOWkc0ZzdXWWJZYTI1c0Qx?= =?utf-8?B?REFKK2k3L2J2SjR4K0xCOENJRHpEZXFwcTQ1aytrLzBFSkJUOUJRSm1ab1M3?= =?utf-8?B?QXJsNW8xSGc4aU5zdlZBbXhQWStOc0l5UForN2xHZVc0czI4QnFWeGJOV3Y5?= =?utf-8?B?R3BRTHhTSDFPbEV5L0Nab201SXFIZzBhUkNrRGhwK0E4K1BNdkZDdEU4Y1Zk?= =?utf-8?B?djRFMWd5cVIvMXNDMy9pUG1DdXQrY2oxalhXVjNZSitmKzZ5c3Z5eS85RzNH?= =?utf-8?B?NG1SS2JlcU9LQ2NYbFFRMThlWStXdEVzZCtYZmxyb2wwRnVHdlJhcW5QdGQ3?= =?utf-8?B?SUtuWVhSYXFsZnNvTTc2M3pGMHR1YjFvRVJuZm05c1pINCtqdVhnQ2ZTN0xN?= =?utf-8?B?aE5MWWQ0RHFackdUM08wMzlFblkxMDIzZEVvUGpkOXhrVGdzdk1yV0RjbFdW?= =?utf-8?B?V1JkbnNuU0hUcFl1OVV0eU1FL1g1ZzRCSlVaUG5GaERZdEdvOENZbkZqamRZ?= =?utf-8?B?WGtUeFdFQzZGY3FURDJHUnNSeTRUZnpRK016VHhrOTZpajVhOEhvR1pKMDUr?= =?utf-8?B?VDlMVkY4RzBWOWRRUDlJTDFYci9LeFJTcFdydUtYWUxvMG1VZHZaazJjdEh4?= =?utf-8?B?UC9CWm5MTVFWUno2TXVaM2M5bDdTd0VKUmZSL2V6T3VYeWdNQzNuVGVXalZr?= =?utf-8?B?SDRnTUdHS0VsbHRQWDFia0RIaW9PNG14M3d3dVVJTUkrLy9MemEreEJraWxM?= =?utf-8?B?Skoxcnl2TVlVVElsVHdZVVFBQ1JYbmhDN3FLK21Pc0dvQmFxWGpocUZtUFRy?= =?utf-8?B?ZFdZTTQzTXRucHhuSDRWdnljV0dhQmJGcEh0WUNhUHVNU1U2MWR2YWV2N2xV?= =?utf-8?B?dk1PdFMwWFYwK3FHSXYxZlJwcVZwU0FuREx4Uk1nR2drVi8xbjQ5STYrK2ky?= =?utf-8?B?K3MyQjdLd2JXWkdId3R2VEFXMkdQSWVJT0Q2YjRTdnlmQTZScmcyUDhuUHUr?= =?utf-8?B?aGNtYUxwTmpzLzNjRWxQalRTRE1xcWlacUp5allzeFR5b1pnTkdlUUo4TllF?= =?utf-8?B?aFN2SGViZjhydEM1THBlekdWQlYxcTcxaklRamNnbHRSMUF1aWJFRXZYVE80?= =?utf-8?B?RDJseUR4N0xuRkMxeUtrZUVLOGFuYmF2Zkh2Z0ttbnhRSEJwR1hpeVZta0tx?= =?utf-8?B?R1hBbWxvZjRaL0ovOCtxcHB1Z1NDT2hTOEVhMUdpeFhHdmhXdnhyRUVhRWJX?= =?utf-8?B?TnU2Rm1wQjlFdGVIMkk3VDJTQ2VJZi83VWpSalh5ZlZzRmp4bUZ4TWdnYVo3?= =?utf-8?B?V0tTRlVmWDZ5VyswbmF1bkRCUC9PdWpScEJRNDFIMXV2WDI3WVV6eHhKdmJz?= =?utf-8?B?bVIwUG42aTI0Y1plenFsdkNucTZCQ0IyeWdjcGxic2J2M0NvT1ErZnM3VE9M?= =?utf-8?B?R3RhS050NG1aRnAwSU1FN05HVnNUdzR2KzRieE5hcGFVM0haS1RDWnVmUHFK?= =?utf-8?B?WWYyZXdPV2hMMVZpYmNDNE9mbExWZHhvV0Zud3FlMFBQYXhBK0VrcnRORjh3?= =?utf-8?B?TVRaRFRLSzJPZUhFaDVqRWNPL3NtM1BIY1drK2ZMK0FGaSt5N1BIZGs0eThs?= =?utf-8?Q?fvw28xoVlmgN9deIBNv+g2lIZ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b922012-ae40-4e1b-a71c-08dad2d0734e X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 12:43:15.8567 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LPm0t1zInJ8aHf92V4pSnX6x+1xQ5MzJ/JAEgUrLJ7iNLleGLbp/JC6ZjxIN4QWu3+xzkrqSVOYGvevemDt6GA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7449 On 30/11/2022 12:01, Jan Beulich wrote: > On 30.11.2022 12:27, Ayan Kumar Halder wrote: >> Looking at "min(flsl(mfn + 1) - 1 + PAGE_SHIFT, PADDR_BITS);", I do not >> understand the reason for "... -1" (ie subtracting by 1). >> >> Do you know the reason ? > That's because fls() and flsl() and friends return 1-based bit indexes > (with 0 being returned when the input was zero), when we need 0-based > values here. IIUC, you are comparing the count of bits here (not bit indexes). PADDR_BITS = 52 (x86), 48 (arm64) and 40 (armv7 arm32). Also fls() returning 0 is correct as none of the bits are set. In this case "flsl(mfn + 1)" will return 1 when mfn == 0(min value), so I think you are subtracting by 1. Should I send a patch to fix the below ? diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 62afb07bc6..cd390a0956 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2245,7 +2245,7 @@ void __init xenheap_max_mfn(unsigned long mfn)  {      ASSERT(!first_node_initialised);      ASSERT(!xenheap_bits); -    BUILD_BUG_ON(PADDR_BITS >= BITS_PER_LONG); +    BUILD_BUG_ON(PADDR_BITS > BITS_PER_LONG);      xenheap_bits = min(flsl(mfn + 1) - 1 + PAGE_SHIFT, PADDR_BITS);      printk(XENLOG_INFO "Xen heap: %u bits\n", xenheap_bits);  } - Ayan > > Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 30 12:47:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 12:47:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449875.706885 (Exim 4.92) (envelope-from ) id 1p0MUw-00036G-Ft; Wed, 30 Nov 2022 12:47:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449875.706885; Wed, 30 Nov 2022 12:47:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0MUw-000369-Cx; Wed, 30 Nov 2022 12:47:34 +0000 Received: by outflank-mailman (input) for mailman id 449875; Wed, 30 Nov 2022 12:47:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0MUv-00035z-35; Wed, 30 Nov 2022 12:47:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0MUu-0004iN-W0; Wed, 30 Nov 2022 12:47:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0MUu-0003Yp-MI; Wed, 30 Nov 2022 12:47:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1p0MUu-000467-Lq; Wed, 30 Nov 2022 12:47:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=66JJA4/10+gm6SPGhtfwIzvpEapKYNgskMXaZ9oLj6s=; b=Khmye4PD+m1u3oWz7eUmrqbTnV 27JnImNstgtR8qRm5sYQHQcGcdmFX6/ppLs8paXwXT5+LP//aVX4muZwt7iWaq8qx1VLbF5ydyLGn 0voxBcHBY0g7PfoPgLhsSYz3aafqMc1y6SXG0B4xxRS+A5Cgo/zDxvu0aehtAuhYaro4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 174995: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=4ff500364d3be497dc68c0c97adb347b3bc05c03 X-Osstest-Versions-That: libvirt=d8cc655d3b0f1c2786b2bc374df12d9454c4b9f5 From: osstest service owner Date: Wed, 30 Nov 2022 12:47:32 +0000 flight 174995 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174995/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 174960 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 174960 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 174960 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: libvirt 4ff500364d3be497dc68c0c97adb347b3bc05c03 baseline version: libvirt d8cc655d3b0f1c2786b2bc374df12d9454c4b9f5 Last test of basis 174960 2022-11-25 04:18:52 Z 5 days Testing same since 174995 2022-11-30 04:20:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Fedora Weblate Translation Göran Uddeborg Michal Privoznik Peter Krempa Weblate Yuri Chornoivan 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git d8cc655d3b..4ff500364d 4ff500364d3be497dc68c0c97adb347b3bc05c03 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Nov 30 13:03:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 13:03:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449883.706896 (Exim 4.92) (envelope-from ) id 1p0Mjn-0005o1-RI; Wed, 30 Nov 2022 13:02:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449883.706896; Wed, 30 Nov 2022 13:02:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Mjn-0005nu-Ns; Wed, 30 Nov 2022 13:02:55 +0000 Received: by outflank-mailman (input) for mailman id 449883; Wed, 30 Nov 2022 13:02:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Mjm-0005no-F9 for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 13:02:54 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2060f.outbound.protection.outlook.com [2a01:111:f400:7e88::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 48ee58f2-70af-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 14:02:48 +0100 (CET) Received: from BN9PR03CA0153.namprd03.prod.outlook.com (2603:10b6:408:f4::8) by MN2PR12MB4063.namprd12.prod.outlook.com (2603:10b6:208:1dc::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 13:02:49 +0000 Received: from BN8NAM11FT008.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f4:cafe::62) by BN9PR03CA0153.outlook.office365.com (2603:10b6:408:f4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Wed, 30 Nov 2022 13:02:49 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT008.mail.protection.outlook.com (10.13.177.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.21 via Frontend Transport; Wed, 30 Nov 2022 13:02:48 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 07:02:48 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 30 Nov 2022 07:02:47 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48ee58f2-70af-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hpa1TJsrRvBxkZ3lR4SNp12RUTyhmSZinI2MKzdqMPpvHtExHLWq53Tk/rrYlun0jiigMygnE8HbCODQtcdG8/l0FOCgpGGcTPsKN/2FCRXHlzuozU96tqR2ORMmzzHoLbuk4NVi15cKLWOeTFGZJmI8lqeS6uljg30kgiNGdHsky3LAGPK8ZjACWjF4+D7vBZh3FK8/AVhx8odfasvcIZ+KlQA+NdO1iB7yYOZiIv6mH7fwb0/S/L5qDG+xcrJsHF//vZ4BrOy52x9j3VNSVrd0jE+/3nk/XSXxJrUqlLCvUEt9zWl9WHHUOpAhq3EwydARK0cC/zczGmI/v/7NQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3vs+oKPzHUs3Mex4OBPW8UTub7EPTQmjC5OS++U2WE0=; b=D81RkqtqGecZvT0sJ4+ymkOMkJ2WMwVoskqShEMCoMsSxG+iC5gVOY0mEtCsaR9bEG7x3yb2UqMdVyQtxOXxSiarQBcOcXFtwThu3nxmZcwpQk0Uxl3LTX5fW0UM5YNHI38CidjOhPnPmQdogThZ3E8WhgE1gZ+ALm3d2FHCEcfo0x8EVHZucxrW9BG5HxT1LwDfXt3rAb0UvF3hiARxePF6yXO3VX94dpOhu4iV7OSLMaq2D+6XNaYbsYICZXZQprY59cU2O2P8VJOnvfg4/B4Zf7r4ob7OQXh5k90Y40WW92E/pw6F8xjwTzAoMI/gHQnhCLbxDnDeHF7DOaG1/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3vs+oKPzHUs3Mex4OBPW8UTub7EPTQmjC5OS++U2WE0=; b=VibMFQJqEcyPn0aLUAJiqNTy4g/EVK88zwuR77bR7kzFbx0hpnDNKndy8MUerysnA/DUZ6bVwvqKtZ0jqIo24L7rjnScstW5pfF2PVO0JhsTYE+SijAixTVCSo7wZQQWofGiO4e/Bh/jkBIw8xo/4yEPmrFBrMsUhw5U9H54GvQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Wed, 30 Nov 2022 14:02:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v5 3/3] automation: Add CI test jobs for Yocto To: Bertrand Marquis , CC: Doug Goldstein , Stefano Stabellini References: Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT008:EE_|MN2PR12MB4063:EE_ X-MS-Office365-Filtering-Correlation-Id: 71e37b0a-ccce-42fd-9324-08dad2d32e9d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nnwZ5poR41rzz2fSAj+ZczhcpAUKsoGg85PjoQkqerezzL5LIMeKWb9l2QmkG9UQULmXb7EMzibtunW1wwdRKdy4PKFj5Q5Ubew1h1mwA7A1e2XKqSAcgrG92XiUfheqcvEtwi6eDcEIesQGzcxx/RUcaJosuxSWDTjiiV5IZPnZkdq11JqsPVji6dRY84jc1dgi2Cq3i2zQnBL0o3AZQWAmGRd5Unb2EV/b2+GZdRqbwGAQ9sTyVeAWoMeBFjzP9KHmnuXGsqJvF3PRg7h5MxMOGr15ssySJXlmBcxpe4edncbJqGdW0OTXbZAhCAY96zMCB+xJrjiZJs+OzF/8k4d6hm7uaYx3r6xZe/npZP+wZwh7WJVFgNKVyOP19JGOl3su1WSOWJ8p2Sj1F4CGgkeZO15S1K3N0sc4fc5pgtrHozZ6PAVkVCbQD87kIE3x4X1mzeGdnLbJLGQWXb3sCtuxInw08OMPzQSLF3RmeSKgYcay5lgvytdp2ueK2OMdlIiihyeo/CmltpqEWCmgOK0dxgaA1Ogvtn0kfEj4JbZZPOkSUpMgsJEgv+hy13YYy1YNfiW3rgFiEbNEihPKcbfq1c7ugrNO6ks8wg11HNKJ/qISQUc96FPs2FHe8fDVJfDDsPQ/9BNPMhLQhi84iFQKwrOUHKlVRWZBFqHwU8+ofgqB+W6wl0N2W7aK6rVSnpalpdQNHaglhC04WuSMNGQcL6j97ipZuPL70/PPwClizmPJNxY9EWIyxNd9RGLxf2QUiCtjfOe4URlpNa2WPg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(356005)(2906002)(40480700001)(36756003)(40460700003)(81166007)(86362001)(31696002)(478600001)(44832011)(41300700001)(26005)(316002)(70586007)(36860700001)(5660300002)(70206006)(54906003)(8676002)(8936002)(4326008)(16576012)(110136005)(82740400003)(2616005)(186003)(336012)(53546011)(82310400005)(47076005)(426003)(31686004)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 13:02:48.7888 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71e37b0a-ccce-42fd-9324-08dad2d32e9d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT008.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4063 Hi Bertrand, On 30/11/2022 13:15, Bertrand Marquis wrote: > > > From: Michal Orzel > > Populate test jobs for Yocto based tests using the provided containers. > Due to the size restrictions, it is currently not possible to split the > build and run tasks, therefore everything is done in a single step. > > Test jobs for the supported Yocto targets are generic to avoid the > necessity to add new ones after each Yocto release. The only thing > required to be changed after updating the containers is the variable > YOCTO_VERSION stored in a .yocto-test template. > > Signed-off-by: Michal Orzel > --- > Changes in v5: > - none > Changes in v4: > - add .yocto-test for arm64 and x86 > - make yocto jobs use arm64 version > Changes in v3: > - patch added > --- > automation/gitlab-ci/test.yaml | 43 ++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index c7e0078e04f1..6ce2fd63eee6 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -54,6 +54,33 @@ > tags: > - x86_64 > > +.yocto-test: > + extends: .test-jobs-common > + script: > + - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` ${YOCTO_BOARD} > + variables: > + YOCTO_VERSION: kirkstone > + CONTAINER: yocto:${YOCTO_VERSION}-${YOCTO_BOARD}-${YOCTO_HOST} > + artifacts: > + paths: > + - 'logs/*' > + when: always > + needs: [] > + > +.yocto-test-arm64: > + extends: .yocto-test > + variables: > + YOCTO_HOST: arm64v8 > + tags: > + - arm64 > + > +.yocto-test-x86-64: > + extends: .yocto-test > + variables: > + YOCTO_HOST: amd64 > + tags: > + - x86_64 This hidden job is not used by any yocto test job and as such can be misleading to others working on this file. So we can either remove it (can be easily reintroduced once we will find more x86 resources) or add a comment explaining why is it here. > + > # Test jobs > build-each-commit-gcc: > extends: .test-jobs-common > @@ -188,3 +215,19 @@ qemu-smoke-x86-64-clang-pvh: > - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE} > needs: > - debian-unstable-clang-debug > + > +# Yocto test jobs > +yocto-qemuarm64: > + extends: .yocto-test-arm64 > + variables: > + YOCTO_BOARD: qemuarm64 > + > +yocto-qemuarm: > + extends: .yocto-test-arm64 > + variables: > + YOCTO_BOARD: qemuarm > + > +yocto-qemux86-64: > + extends: .yocto-test-arm64 > + variables: > + YOCTO_BOARD: qemux86-64 > -- > 2.25.1 > ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 30 13:04:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 13:04:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449889.706906 (Exim 4.92) (envelope-from ) id 1p0Mkt-0006Ny-8c; Wed, 30 Nov 2022 13:04:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449889.706906; Wed, 30 Nov 2022 13:04:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Mkt-0006Nr-5l; Wed, 30 Nov 2022 13:04:03 +0000 Received: by outflank-mailman (input) for mailman id 449889; Wed, 30 Nov 2022 13:04:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Mkr-0006Dm-Gg for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 13:04:01 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on20613.outbound.protection.outlook.com [2a01:111:f400:7e8d::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 71ac933c-70af-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 14:03:55 +0100 (CET) Received: from MW2PR16CA0020.namprd16.prod.outlook.com (2603:10b6:907::33) by DM6PR12MB4123.namprd12.prod.outlook.com (2603:10b6:5:21f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 13:03:57 +0000 Received: from CO1NAM11FT015.eop-nam11.prod.protection.outlook.com (2603:10b6:907:0:cafe::1d) by MW2PR16CA0020.outlook.office365.com (2603:10b6:907::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19 via Frontend Transport; Wed, 30 Nov 2022 13:03:57 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT015.mail.protection.outlook.com (10.13.175.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.18 via Frontend Transport; Wed, 30 Nov 2022 13:03:57 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 07:03:56 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 05:03:56 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 30 Nov 2022 07:03:54 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71ac933c-70af-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QHUo04o/Yvy9ICJ51vr0LLpqQTrfMxLDlqHzBwWfF8aMcEx5UEG2wIEFL8nAndp52b6IyY/K2r8Lu23vDENyva2ELMCg6m6Yqu1p7OA8cXwoNe/Eja94XKbG4yw6RDM1KcXyK4E2eYAqPLsYVcplpgxxhUBD5XO7pJDLlQrPYLkWR78j0eGoXrnSs0jSUkUYgd3wcAedgPjikrpSINFKPR2xuFr0XHoJlZXQEiavh0aNO5F651XQqMgyk+N0xJScZMy1aW1hyUfdM8hLzy3gaJMaZ44IoAWchK76Wm2XKBxfuQMBn4BZ+XHd61WEeNdU9GS1M8S1IKbaQKKflTgZhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wTzPXVFlihTMkRLvYxpy6qV8ssb43VZ4yz0SOUYVC84=; b=L1GTBzcYpiFLxh5Kz1z+ii7OR4MvJAdjkyR2vDh3+hxU1e29MFAaW13tFnZamyg3Z/Cl4sJ/ypm7P3Hw8VGJA9XG2bH1maQFw4Nl7xdJwCtiWy/cDPxyInEa1nd0jzCMAgQSaFbsWPq3SnFPxUODWWs5Oesh5wmJq0bYRoAm8D6Ao7Lxf3/ITp+WZLWQNEPMuQzhqSOV8STk8xtWvrvarqvZfUTD3JGkCEDFoZrdVbsLQLpPZY7oV5DBDcZRwwVUf1BzrQ5XB4hcp9FnF8kjPfGio9px62pwBCIJj2ysrfu0WBF1pJOdh7raU+AQ025HpX7+TNZQ4erZHdG9ANPj9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wTzPXVFlihTMkRLvYxpy6qV8ssb43VZ4yz0SOUYVC84=; b=kXzJeOUpdew0jmstSCcZ2nIXQaKkPe1fPzB7yDpBs1Lr3PKob1GDMpTlS5PtgqKCT6exrYi9sn2fTZZR9lxqpt5pXhzicPIhoJo3xorxZ0LigHPR+WbRCqrS13xZPO2TAbPUgDYMH7C64kETcddZ2jTpdWy16O0r1PQsA+iccuY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Wed, 30 Nov 2022 14:03:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v5 2/3] automation: Add a clean rule for containers Content-Language: en-US To: Bertrand Marquis , CC: Doug Goldstein , Stefano Stabellini References: From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT015:EE_|DM6PR12MB4123:EE_ X-MS-Office365-Filtering-Correlation-Id: d4b261ac-2f02-4655-9ba3-08dad2d35759 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ax7x78+Y8AVSNyLLBa5nfjpA5Mj59f4ZRLjNCTPpG190/li+daWXCNBi1itZn+JjZ0J6u+eRt98DbcgnMn57stBsdZgHj7++3kefBt46RoauEPovpHQAl8qaZuEgYUc7F2XupLnw1tkVySzy01561AoAcBGgiFubPCBwSro+fezcwfz9dxTgD/ccxKq9kFyWLEWsZEvHh5ORzRB9PxLB0H8JZjOHSQvbcyC1dOAdPtcXWJ5PPELwiJvjQa4GkjtVTa4VbJLbl+CiqEq2jmUmefmsRRqgr51Mpi7c4AQCG67btXWv7/M4oUWcoY0U0/Exf2vlEEh/UZBPwivWt2PpY5fhsAgQwiS8F9eCq1pNPl/dqwEg07bhL3uJ5EVzIismWQgjvY5bUDNNl7iJMurnT2GsnOtHjnQ8k1RXeGoRRrrJVghmBvlBNv9dxhM1kmtgjE5ruF/6Eq2njcg+SASF6F1RSajjGNOUSvcanFFZrOKi4RMPni6+n1RPheHk992VzYBeUAO2T6EMukXO1Gz9JAgG8xgLTR9hC2GDzspi5u+bqI9TJrQJcxP1JF+qiPLOBMPpk7m47giB1oYRmK9968Lo9OyuiqgCGNnqIY+xty6FSJtyqgVTQFfiMsJFRpx7JQjS7NUWJPfP62kcqee1eN3zqzIycRtujwcv6X5CKPkihVQa9x2p0oVr5Lff6DwXiq6dCizzjIbExmzDIv05kgwhdIm86kG8ptAdIzFNHOBIn70q6e+fWwywTxY90Wo6SQKcSlRADSecDKomDCYBdQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(356005)(2906002)(40480700001)(36756003)(40460700003)(81166007)(86362001)(31696002)(478600001)(44832011)(41300700001)(26005)(4744005)(316002)(70586007)(36860700001)(5660300002)(70206006)(54906003)(8676002)(8936002)(4326008)(16576012)(110136005)(82740400003)(2616005)(186003)(336012)(53546011)(82310400005)(47076005)(426003)(31686004)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 13:03:57.0206 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4b261ac-2f02-4655-9ba3-08dad2d35759 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT015.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4123 Hi Bertrand, On 30/11/2022 13:15, Bertrand Marquis wrote: > > > Add make clean support to remove the containers from the local docker > registry. > make clean- must be called to remove an image: > make clean-yocto/kirkstone-qemuarm: remove yocto kirkstone for qemuarm > image > > Signed-off-by: Bertrand Marquis Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 30 13:13:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 13:13:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449895.706917 (Exim 4.92) (envelope-from ) id 1p0Mtx-00087x-4O; Wed, 30 Nov 2022 13:13:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449895.706917; Wed, 30 Nov 2022 13:13:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Mtx-00087q-1r; Wed, 30 Nov 2022 13:13:25 +0000 Received: by outflank-mailman (input) for mailman id 449895; Wed, 30 Nov 2022 13:13:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Mtv-00087k-Nn for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 13:13:23 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id c0aa23b9-70b0-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 14:13:17 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AC101D6E; Wed, 30 Nov 2022 05:13:27 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B0FDE3F73D; Wed, 30 Nov 2022 05:13:19 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0aa23b9-70b0-11ed-8fd2-01056ac49cbb Date: Wed, 30 Nov 2022 13:13:16 +0000 From: Andre Przywara To: Jan Beulich Cc: Ayan Kumar Halder , Stefano Stabellini , "Stabellini, Stefano" , bertrand Marquis , "Volodymyr_Babchuk@epam.com" , Rahul Singh , Vladimir Murzin , Julien Grall , "xen-devel@lists.xenproject.org" Subject: Re: Arm: AArch32: Need suggestions to support 32 bit physical addresses Message-ID: <20221130131316.13ebf9d1@donnerap.cambridge.arm.com> In-Reply-To: <22d28805-8889-25e9-6d18-c868bf5e51bb@suse.com> References: <70651dbc-085d-706d-17d0-a419086a0700@amd.com> <65891843-db28-e5dd-6e9e-3fb003fcabc5@amd.com> <105a0d45-5b3d-7986-92c1-9a13eb803bd8@amd.com> <22d28805-8889-25e9-6d18-c868bf5e51bb@suse.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 30 Nov 2022 08:09:53 +0100 Jan Beulich wrote: Hi Ayan, > On 29.11.2022 19:18, Ayan Kumar Halder wrote: > > On 29/11/2022 15:52, Julien Grall wrote: =20 > >> On 29/11/2022 16:23, Ayan Kumar Halder wrote: =20 > >>> On 29/11/2022 14:52, Julien Grall wrote: =20 > >>>> On 29/11/2022 14:57, Ayan Kumar Halder wrote: =20 > >>> --- a/xen/common/page_alloc.c > >>> +++ b/xen/common/page_alloc.c > >>> @@ -2245,7 +2245,9 @@ void __init xenheap_max_mfn(unsigned long mfn) > >>> =C2=A0=C2=A0{ > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ASSERT(!first_node_initialised); > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ASSERT(!xenheap_bits); > >>> +#ifndef CONFIG_AARCH32_V8R > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 BUILD_BUG_ON(PADDR_BITS >=3D BITS_PER_= LONG); > >>> +#endif =20 > >> > >> BUILD_BUG_ON() are used to indicate that the code would fall over the= =20 > >> check pass. I can't find the justification for this change in the=20 > >> commit message. =20 > >=20 > > I had a look at the following commit which introduced this, but I=20 > > couldn't get the explaination for this. > >=20 > > commit 88e3ed61642bb393458acc7a9bd2f96edc337190 > > Author: Jan Beulich > > Date:=C2=A0=C2=A0 Tue Sep 1 14:02:57 2015 +0200 > >=20 > > @Jan :- Do you know why BUILD_BUG_ON() was introduced ? =20 >=20 > You've cut too much context - the next line explains this all by itself, > I think: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0xenheap_bits=C2=A0=3D=C2=A0min(flsl(mfn=C2=A0+=C2= =A01)=C2=A0-=C2=A01=C2=A0+=C2=A0PAGE_SHIFT,=C2=A0PADDR_BITS); >=20 > Clearly addresses used for the Xen heap need to be representable in an > unsigned long (which we assume to be the same size as void *). So I am wondering why you hit that code for your port in the first case? If you check, then ARM32 won't pass this, because PADDR_BITS is 40, while a long is still 32 bits. So digging deeper this is code for the case when we want to map the entire physical memory into Xen (the Xen heap, or direct map in Linux terms). Which we cannot do for ARM32, and that's why the code is protected by !CONFIG_SEPARATE_XENHEAP, which is forced to 1 for CONFIG_ARM_32 (in a hacked up way, btw). So I think you must just force the same thing for your port, then this code will never be compiled. Does that make sense? Cheers, Andre > But I'm afraid there's further context missing for your question: Why > would that construct be a problem in your case? Is it just that you'd > need it to be > rather than the >=3D that's used presently? If so, why > do you add an #ifdef rather than dealing with the (apparent) off-by-1? > (I say "apparent" because I haven't checked whether the >=3D is really > depended upon anywhere.) >=20 > Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 30 13:28:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 13:28:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449901.706928 (Exim 4.92) (envelope-from ) id 1p0N8C-0001PS-Ds; Wed, 30 Nov 2022 13:28:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449901.706928; Wed, 30 Nov 2022 13:28:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0N8C-0001PL-BD; Wed, 30 Nov 2022 13:28:08 +0000 Received: by outflank-mailman (input) for mailman id 449901; Wed, 30 Nov 2022 13:28:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0N8A-0001PF-Io for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 13:28:06 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062a.outbound.protection.outlook.com [2a01:111:f400:7eaa::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cb2762b5-70b2-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 14:27:54 +0100 (CET) Received: from BL0PR02CA0043.namprd02.prod.outlook.com (2603:10b6:207:3d::20) by PH0PR12MB5631.namprd12.prod.outlook.com (2603:10b6:510:144::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 13:28:01 +0000 Received: from BL02EPF0000EE3D.namprd05.prod.outlook.com (2603:10b6:207:3d:cafe::9a) by BL0PR02CA0043.outlook.office365.com (2603:10b6:207:3d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Wed, 30 Nov 2022 13:28:00 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0000EE3D.mail.protection.outlook.com (10.167.241.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.17 via Frontend Transport; Wed, 30 Nov 2022 13:27:59 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 07:27:59 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 07:27:59 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 30 Nov 2022 07:27:58 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb2762b5-70b2-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mk/jtjsirDy8H5khh3QPeR+sjBrBPf6Ci+Qb1tSNeN4C2VjkhEq5vY87aGxZG+ZzWpjqiJ/kLr96nfLD8FJzIOZBPKTc/roIoNZPSABZOb86VXWT+Xn/QOJQ0T9Ji0hb52OO9uY5HQ7Txzf04m8W+YpD5afnh3K3ryqf9KUwPY19gmBjGU/9H7+pXUxbLBLBezUdFMbGsQBsA2EKAAvHGz8AEA6q1d3a3tUI0buLQzyJrfHGqE69G9M1WTeoM2YT94q6pMlQZAPqFh7GhWVI3F63fQ22xj30fFlnTyFZmFQ3Y2ChXWbSHcz3defEENBKbflX7CN2NBkrLBn5CC1fYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1n9ry9VIO9lf5oOJla12j4isMFEfHv3L6ob+WUJPElM=; b=Apg9n/04EzVfCGv06AZmXQ0Nmx2gnTOGEFEw3ihli/lDiYhTbsd4DM3nb0tTzDhZ/bNNKC+E4egSf5WcmmwTdSdMnEGfpdpIhKWlepSwddghftkV1DmhWUBQJh8WiWexW3sK4QYHG20LoOlnSU3A8sbmt8Wsa+MpAVsvX4xE8R+mxdx7inW/wQ3JDjVz/rCQEowg10C3kvFPPmXUS/dX/Jb4vtBL73LsYXWRHMTFctV2Dyxm4dBbEDnRm6WXI9iJumD58uLabGXEmGTQmmWcYMQJbYdftrF3V5v2HzmvU4yVgchOjhKleagbzktnryUaZRxYctXzC5yclLeeA0EVKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1n9ry9VIO9lf5oOJla12j4isMFEfHv3L6ob+WUJPElM=; b=rNHYQd2W90ZruPRPZfGl4UWoFUe2b0zuaOixr+cpx/yyEweADpcyc848awtaTP0CnNwkBfkCHuhuDj++CyRNgzfOBixoAGilyLX5aOO0yqwX3pAWvvf8exCmub2OuL3v1PY7V6ziWzmCrdocaoHhgvjfxkLGUO6HSZmD2EN2M0M= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <49d4c5e3-d853-605c-a87f-c90ccba1ab5d@amd.com> Date: Wed, 30 Nov 2022 14:27:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v5 1/3] automation: Create Yocto docker images Content-Language: en-US To: Bertrand Marquis , CC: Doug Goldstein , Stefano Stabellini References: <18861c0c9c547959900532e38df11b2d67f0a1cc.1669810269.git.bertrand.marquis@arm.com> From: Michal Orzel In-Reply-To: <18861c0c9c547959900532e38df11b2d67f0a1cc.1669810269.git.bertrand.marquis@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0000EE3D:EE_|PH0PR12MB5631:EE_ X-MS-Office365-Filtering-Correlation-Id: a060b0c9-1484-4630-98ee-08dad2d6b31c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: olXpmWnd9Kcf41sQRoXZTGS2tWExo3mUlsCwJGvQ+LxZt2rcYsWPMVjRXjJzyvykG+0x2OjaDyN6hXzX9bj28cSUY9smGrXyaJRSXCRLs12/gMn1LQ99Cxdo6L+67zcCuM6SUeG0KRE8kMXFZP3qgLdLYmJZdi8vGDFXoPVHR83IAswpFdWPAXSk1pKkfnphEex78777zkMat1OiqySbARpMmwWw7gA7MKxnESmsp4tHYT9m7HSciHKMAw2atdHNQ6a8cnA8KNnvFehaRK7ZHWeYtkTqPuDcyWhYghVPnP5JqmxM2EjVxsZrQhfIIfRpDpsiEJHDhppHF5Wmclo8zZjxv/kfL76u2zs/0hFOSTJSLYEHF3qDvPKArzNj+zy6fs9bdux2DqNmVRUwsClyvseSlP0jbdoTAAq+/KIzV905zNxBUkNPBX3uxPVcUpu/gB5e/IW3PasuAdwy21qv4sPFXlPxsGn1wjoA7+YZa0KzlvcvRXQ46OuHd92boZgUAVFSrqeyi1AkcTVbx2xET10renhgsc8yTKwrcT4pcVHmoplvnRqpLk7tEWztOuJBMDIVPdr6mS47F7LRM+iZY+LitticS7YVqa1vaJotPE+wVfKSZkmF6yAiQtFLpVD+jpLqpUPL/R0tOt7OU7pvT9NTHuw0YjrhmXKSQx6RGKRZ+iEbAoo5czIJAb4P3oYOV6PV/WvBER/1Ht/3qWcNw9Hq5uu2gwUTLVqGmeGEa0KBJ1xO+1DXWIvd57TciIs6SFflcrTmOE4iYWXORO/FLSDTLavN21zop46wxdM1BV0= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(396003)(136003)(451199015)(46966006)(36840700001)(40470700004)(36860700001)(44832011)(83380400001)(82740400003)(31686004)(84970400001)(31696002)(86362001)(36756003)(82310400005)(426003)(53546011)(5660300002)(26005)(2616005)(336012)(186003)(47076005)(2906002)(41300700001)(478600001)(81166007)(70206006)(70586007)(8936002)(8676002)(356005)(40460700003)(16576012)(4326008)(54906003)(40480700001)(110136005)(316002)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 13:27:59.5707 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a060b0c9-1484-4630-98ee-08dad2d6b31c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0000EE3D.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5631 Hi Bertrand, I will try to build and run the yocto containers for a test. In the meantime I just spotted one thing. On 30/11/2022 13:15, Bertrand Marquis wrote: > > > Add containers suitable to run yocto kirkstone build based on ubuntu > 22.04. It contains all packages required by Yocto and a checkout of the > layers required to build Xen with Yocto. > > Add a generic docker image template to be used to automatically generate > docker files for different configurations: > - specific yocto version > - different targets (qemu arm, arm64 and x86) > - different host platforms (x86 or arm64) > > During a call to 'make all', only the images for the host platform we > run it on in the CI is generated. > If needed, images for an other host platform can be generated manually > by calling the right make target (see make help). > > Add a build script to build and run xen on qemu using Yocto. > The script supports arm32, arm64 and x86_64 and checks that dom0 is > properly booting. At this stage this does not run any guest on top of > dom0. The script is to be executed in one of the docker images to build > and run a system using a Xen source tree. > > Signed-off-by: Bertrand Marquis > --- > Changes in v5: > - typo fixes > - add INTERMEDIATE to remove intermediate dockerfile > - use container architecture > - use full words in foreach loops > - fix shellcheck findings in build-yocto.sh > - rebase on sstabellini next branch > Changes in v4: > - Rework the system to have one dockerfile template from which make will > generate the required dockerfiles for the wanted configuration > - add support for different host architectures > - Merge the generation system into one single dockerfile > - Merge patches 1 and 2 in a single patch > - Introduce CONTAINERS_EXTRA to have extra containers not built by > default (for those not used by CI but useful to users) > Changes in v3: > - limit number of jobs in yocto by default to 8 and add --num-jobs > option to the script to set a custom number of jobs > - do not copy anymore the build-yocto.sh script inside the main image so > that the current one in the repository is used when running > Changes in v2: > - add a --dump-log command line option to build-yocto.sh script to dump > the logs if an error occurs. > Changes in v1: > - add --image command line argument to build-yocto.sh to allow building > something different than xen-image-minimal. > - modify dockerfile to have one layer per line and make it easier to add > other. I kept the for loop to keep the number of docker steps lower > - update commit message to warn that no guest are tested. > - fix build-yocto script to properly return with an error if expect > script ends up in timeout or EOF. > --- > automation/build/Makefile | 14 +- > automation/build/yocto/build-yocto.sh | 351 +++++++++++++++++++++ > automation/build/yocto/yocto.dockerfile.in | 114 +++++++ > automation/build/yocto/yocto.inc | 42 +++ > 4 files changed, 519 insertions(+), 2 deletions(-) > create mode 100755 automation/build/yocto/build-yocto.sh > create mode 100644 automation/build/yocto/yocto.dockerfile.in > create mode 100644 automation/build/yocto/yocto.inc > > diff --git a/automation/build/Makefile b/automation/build/Makefile > index a4b2b85178cf..72a5335baec1 100644 > --- a/automation/build/Makefile > +++ b/automation/build/Makefile > @@ -1,13 +1,18 @@ > > # the base of where these containers will appear > REGISTRY := registry.gitlab.com/xen-project/xen > -CONTAINERS = $(subst .dockerfile,,$(wildcard */*.dockerfile)) > +CONTAINERS = $(filter-out yocto/%,$(subst .dockerfile,,$(wildcard */*.dockerfile))) > +CONTAINERS_EXTRA = > DOCKER_CMD ?= docker > > +include yocto/yocto.inc Because this appears before help, when calling make without any target like: make -C automation/build the previous behavior of printing help by default is no longer true (the default target is taken from yocto.inc in this case). Instead we're getting: make: Entering directory... rm yocto/kirkstone-qemuarm64.dockerfile make: Leaving directory... This include can be easily moved after help to stick to the current behavior and still achieve what we want (i.e. make will still first evaluate include and then call the first target which is help, so CONTAINERS and CONTAINERS_EXTRA will contain correct data). > + > help: > @echo "Builds containers for building Xen based on different distros" > @echo "To build one run 'make DISTRO/VERSION'. Available containers:" > @$(foreach file,$(sort $(CONTAINERS)),echo ${file};) > + @echo "Extra containers (not built using make all):" > + @$(foreach file,$(sort $(CONTAINERS_EXTRA)),echo ${file};) > @echo "To push container builds, set the env var PUSH" > > %: %.dockerfile ## Builds containers > @@ -16,5 +21,10 @@ help: > $(DOCKER_CMD) push $(REGISTRY)/$(@D):$(@F); \ > fi > > -.PHONY: all > +.PHONY: all clean > all: $(CONTAINERS) > + > +# Remove generated dockerfiles for yocto > +clean: > + rm -f yocto/*.dockerfiles > + ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 30 13:57:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 13:57:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449906.706940 (Exim 4.92) (envelope-from ) id 1p0NZw-0005GF-Lo; Wed, 30 Nov 2022 13:56:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449906.706940; Wed, 30 Nov 2022 13:56:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0NZw-0005G8-IB; Wed, 30 Nov 2022 13:56:48 +0000 Received: by outflank-mailman (input) for mailman id 449906; Wed, 30 Nov 2022 13:56:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0NZv-0005G2-4h for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 13:56:47 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cc86d7fe-70b6-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 14:56:33 +0100 (CET) Received: by mail-wm1-x32d.google.com with SMTP id ay27-20020a05600c1e1b00b003d070f4060bso1454085wmb.2 for ; Wed, 30 Nov 2022 05:56:44 -0800 (PST) Received: from [192.168.23.148] (54-240-197-225.amazon.com. [54.240.197.225]) by smtp.gmail.com with ESMTPSA id g8-20020a5d46c8000000b0023662d97130sm1673991wrs.20.2022.11.30.05.56.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 05:56:43 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc86d7fe-70b6-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=JJCTMIqF448FJLyxITwgMGZvlQGJ1mGh31rovw0F9WE=; b=UkOYn5dkaxHV8op/sI1h8z338WQK7lhezmBhf/ENNFoPhN7Ir5TwMjUHd3PU3UqaPA /RX9ixfy3iwJIDrNBSKjZIL5EfVPRmt2dL2KwqQi5NAwfuZeBc5Zg5sGu2a3ioOo2KHx AcUcm4GjTSy6xv0p5IFsyHTPOuu3T3lg49P5KsehgKTxrbpm2m9VIEOPiL/I6oJCq8hh ot72Ht8mueCy9VK2r8HbE1WXlTPbISpJPMVb9z0R0MulEMrp3f23wXJ95+BHBugl6Vkd ImytgSI6MwvrD1/uhb/YCpQJTmwos5oB15L0Uk8NY+d2pA1qTbZdObPtTPt/2V2HZd6s 0O9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JJCTMIqF448FJLyxITwgMGZvlQGJ1mGh31rovw0F9WE=; b=Z60C9RweU2Zh8hn4Ant1M384G1BxF2uJhn2cG0IxuIJNPDxNY9UgQm5rQoXNpfVWc6 41P8WuRu+N+O8Dj5/iM2c6IlxYO2hpm8wcRgy4I0Grm1vghTXWej07hOWlskk59W9+Ci 3FNWbxB4zjzUb3s5ohbg8uE3d/4ov22Jg76iG0GavtrowddZb86dVaAeGrdYZkzlSwZJ Z6Z53bhLfRYwdJ5WVkNpXLTPtkwcxpiAYQ6cmL6H3pby4Kak+KmmeULfiz1xXr5I0tX+ dV89ZX42oXa5ZhneMG0PJKjsbhGsVX/fEgiXw+4LSbxN91W9z6FeYWq2rvy5MsCwzIsE vLWQ== X-Gm-Message-State: ANoB5pmm5pRdF392z1DXxyeNsgec/uZX30HMXWAeAK6tCdt293iugv/d zR0fGz+xLLfheFfVnM9Fvik= X-Google-Smtp-Source: AA0mqf5RuqhW7TvmQbTm1OmbDzH2pQ04E1xdPZA6bRiGZp6y7j10d09oNV9zrk3znAgW5yQw/PaL5A== X-Received: by 2002:a05:600c:2302:b0:3cf:a3c4:59b3 with SMTP id 2-20020a05600c230200b003cfa3c459b3mr37573664wmo.198.1669816603925; Wed, 30 Nov 2022 05:56:43 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: Date: Wed, 30 Nov 2022 13:56:42 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] ioreq_broadcast(): accept partial broadcast success To: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Per Bilse , Andrew Cooper , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <06ad4b3a67a15192fc986b35e3f2fcd35b2f4c2f.1669383767.git.per.bilse@citrix.com> Content-Language: en-US Organization: Xen Project In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28/11/2022 12:26, Jan Beulich wrote: > On 28.11.2022 12:06, Roger Pau Monné wrote: >> On Mon, Nov 28, 2022 at 09:21:47AM +0100, Jan Beulich wrote: >>> On 26.11.2022 23:19, Julien Grall wrote: >>>> On 25/11/2022 14:15, Per Bilse wrote: >>>>> This patch modifies ioreq_broadcast() to allow partial success. >>>> >>>> The commit message is quite vague, so it is hard to know what you are >>>> trying to solve exactly. AFAIU, there are two reasons for >>>> ioreq_broadcast to fails: >>>> 1) The IOREQ server didn't register the bufioreq >>>> 2) The IOREQ buffer page is full >>>> >>>> While I would agree that the error message is not necessary for 1) (the >>>> IOREQ server doesn't care about the event), I would disagree for 2) >>>> because it would indicate something went horribly wrong in the IOREQ >>>> server and there is a chance your domain may misbehave afterwards. >>> >>> In addition I think ignoring failure (and, as said by Julien, only because >>> of no bufioreq being registered) is (kind of implicitly) valid only for >>> buffered requests. Hence I'm unconvinced of the need of a new boolean >>> function parameter. Instead I think we need a new IOREQ_STATUS_... value >>> representing the "not registered" case. And that could then be used by >>> ioreq_broadcast() to skip incrementing of "failed". >> >> So introduce an IOREQ_STATUS_UNREGISTERED return code and don't >> increase failed if buffered == true and UNREGISTERED is returned, >> would that be acceptable? > > Yes afaic, but Paul is the maintainer of this code. And of course the > new error indicator shouldn't surprise any existing callers. > A new status code does indeed seem like the cleanest way forward. Paul From xen-devel-bounces@lists.xenproject.org Wed Nov 30 14:25:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 14:25:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449913.706950 (Exim 4.92) (envelope-from ) id 1p0O1n-0000p0-0S; Wed, 30 Nov 2022 14:25:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449913.706950; Wed, 30 Nov 2022 14:25:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0O1m-0000ot-U9; Wed, 30 Nov 2022 14:25:34 +0000 Received: by outflank-mailman (input) for mailman id 449913; Wed, 30 Nov 2022 14:25:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0O1l-0000on-E8 for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 14:25:33 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d7721899-70ba-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 15:25:31 +0100 (CET) Received: from [10.10.1.154] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1669818321344846.5741021890385; Wed, 30 Nov 2022 06:25:21 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7721899-70ba-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; t=1669818323; cv=none; d=zohomail.com; s=zohoarc; b=DAiV77C3l9KkiRJXUqaVkHfs09E+z81dGBZbmpxlu3OTtTPFSCV0R4iJIliHdctNwO7uc1jWn/+99rZrrGuc2eDk81Y9Sx9V78f4KOgPH/xb8zOxNWydKmMArtnN/Hyhi2V78QEmuc9L4Ro5nXRLwVK3eWd28HfgiQd+ayZlaiY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669818323; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=g7TipV0I7Gy5yDaSXWreS2VrBfDhMbzklK2sAAD97W4=; b=FmXE7edscpaY07Qt29BCtzKXHuhRQqRTWeo8fdGb4Bn+8zAkrtW8pQLiB33HOPfYKT2OSdz4GzElLw18zfQLpDKJrCHPQXhNaqaF/qd1Cgg8eT7a2Mw4BPE2qvlYK065BoYd/nI1jeW6GTKk2xQ36ISGNnXEqF6Tj2i+WpOurW0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1669818323; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=g7TipV0I7Gy5yDaSXWreS2VrBfDhMbzklK2sAAD97W4=; b=qnCrwdHaCBfvSYWE/E+32aJmd3ybYLF1EAev1sWMe/0PcD5jKGBgNcotqmjpWUel 59+CtaN21VfD+upTotZQAjPVQNpBllKGjnRqNvEwTe5SXEBBloTbQNZB0Fw19CEeGYS fMkKxJoFfOENMxnVHHyvepK4Oevbf4jkLWFNFGJQ= Message-ID: Date: Wed, 30 Nov 2022 09:25:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] x86/mm: PGC_page_table is used by shadow code only Content-Language: en-US To: Jan Beulich , Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <4fef5b0c-4463-cd6f-15fc-47268505517b@citrix.com> <96f6a943-0e1e-7399-fe83-56a550d47bf6@suse.com> From: "Daniel P. Smith" In-Reply-To: <96f6a943-0e1e-7399-fe83-56a550d47bf6@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 11/30/22 02:52, Jan Beulich wrote: > On 29.11.2022 21:56, Andrew Cooper wrote: >> On 29/11/2022 14:55, Jan Beulich wrote: >>> By defining the constant to zero when !SHADOW_PAGING we give compilers >>> the chance to eliminate a little more dead code elsewhere in the tree. >>> Plus, as a minor benefit, the general reference count can be one bit >>> wider. (To simplify things, have PGC_page_table change places with >>> PGC_extra.) >>> >>> Signed-off-by: Jan Beulich >> >> Ahead of making this change, can we please rename it to something less >> confusing, and fix it's comment which is wrong. >> >> PGC_shadowed_pt is the best I can think of. > > Can do, sure. > >>> --- >>> tboot.c's update_pagetable_mac() is suspicious: It effectively is a >>> no-op even prior to this change when !SHADOW_PAGING, which can't be >>> quite right. If (guest) page tables are relevant to include in the >>> verification, shouldn't this look for PGT_l_page_table as well? How >>> to deal with HAP guests there is entirely unclear. >> >> Considering the caller, it MACs every domheap page for domains with >> CDF_s3_integrity. >> >> The tboot logical also blindly assumes that any non-idle domain has an >> Intel IOMMU context with it.  This only doesn't (trivially) expose >> because struct domain_iommu is embedded in struct domain (rather than >> allocated separately), and reaching into the wrong part of the arch >> union is only mitigated by the tboot logic not being invoked on >> non-intel systems.  (Also the idle domain check is useless, given that >> it's in a for_each_domain() loop). >> >> It does look a little like the caller is wanting to MAC all Xen data >> that describes the guest, but doing this unilaterally for all shadowed >> guests seems wrong beside the per-domain s3_integrity setting. > > Question is - do we care about addressing this (when, as said, it's > unclear how to deal with HAP domains; maybe their actively used p2m > pages would need including instead)? Or should we rather consider > ripping out tboot support? This would break a significant number of production deployed OpenXT derivative solutions. I would respectively request that a middle ground be found that will allow the capability to remain until TrenchBoot has had time to build a Secure Launch for Xen that mirrors Secure Launch for Linux. NB: I have a long list of changes for the tboot code but have opted thus far to let them lie. Mainly as they would be hole patching that would mostly be tossed with the clean room implementation that will come from TB. v/r, dps From xen-devel-bounces@lists.xenproject.org Wed Nov 30 14:57:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 14:57:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449926.706965 (Exim 4.92) (envelope-from ) id 1p0OWA-0004kj-GJ; Wed, 30 Nov 2022 14:56:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449926.706965; Wed, 30 Nov 2022 14:56:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0OWA-0004kc-DH; Wed, 30 Nov 2022 14:56:58 +0000 Received: by outflank-mailman (input) for mailman id 449926; Wed, 30 Nov 2022 14:56:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0OW8-0004kW-R9 for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 14:56:56 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062a.outbound.protection.outlook.com [2a01:111:f400:fe0c::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3b6e5bfa-70bf-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 15:56:56 +0100 (CET) Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAVPR08MB9529.eurprd08.prod.outlook.com (2603:10a6:102:315::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Wed, 30 Nov 2022 14:56:53 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5880.008; Wed, 30 Nov 2022 14:56:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b6e5bfa-70bf-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=icGpsjTqIKB+KrJmOw1U417Hnh/gVwPSUG84sxeM6b7NCByt57IuTXICnJ1pH8JiD9q2/NlqSbvCGBsbORBoRxnHr/MfITFCtnnh21CdEkponPzM+tIATruRFXuKXdvGlSYj6ixZpM14r8u/jzyIKQM5ALocxMxeIJFu8gqtm0Txi+YpZHRU67nk4mw2liSU7X4PNXs8F3JNQubllDpGMWmpIkEnrmq6uTJBtq54XOSKk8npKsJW1Ti4PO/gAFkTq8PzlftIx1JufjHKp1UNPYsgsl2E9ZRgTbyQF4nUhjBarU0KVqRMoCjjdrbvYamvOay3pbBpqd40p05C1okxUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PguNgRSJ73OSGU8nhMLC8EDFZ7GLXldEzRQtaMlxTRM=; b=U/tmSY/iDGUa8ToAa6SqxxmPo4ldHuqKbG3e/6BRe/z6hIPlv4AXc6gRs1KNKsZPsa1Zuz1gAI/JMcW2gtBJLocPYIxElQ0U1Ai5iSyw49PCXVvOZ8xfinT88PL0z2+vRGJnmMIheIOLzH5nndfByef9iknUumgKa0bNL/yAdEeSx/JSDCyDk+fOAJtPqIGlG1actwAU9we9z3fnIAj1EH9MdzZoYFje8jyVgFZaJLw81ptQUgfetqdi6M0p4nSWtoAoG4Stlld89GJwEUnh+juWwADOvWwE0UAX+SZ4CTecoocqjnR8O/Bw3XpHaqkBp2eQXlXYwVXn8GxSA74/VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PguNgRSJ73OSGU8nhMLC8EDFZ7GLXldEzRQtaMlxTRM=; b=ZkkMrflk4L9xhyH9PwQ563geADMInhN8FLuvDqCKJ713D0WaWyoFKwBoRr8fFeyTJscrWneVG1z38Lud7R/tGW8GiQN5NZGdwxSzcFRIY5HOszaiWNjWR+IL77KqreyxYboH2+O+JikbREKsWqNkP1u++YkrXzbeOdFFIgJ0sFU= From: Bertrand Marquis To: Michal Orzel CC: "xen-devel@lists.xenproject.org" , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v5 1/3] automation: Create Yocto docker images Thread-Topic: [PATCH v5 1/3] automation: Create Yocto docker images Thread-Index: AQHZBLWFmb3GO0y8oEy6bIpMhPppa65XdbOAgAAY1oA= Date: Wed, 30 Nov 2022 14:56:52 +0000 Message-ID: <913CFB76-C7DB-4CC6-A1C1-4DDA0556FEC0@arm.com> References: <18861c0c9c547959900532e38df11b2d67f0a1cc.1669810269.git.bertrand.marquis@arm.com> <49d4c5e3-d853-605c-a87f-c90ccba1ab5d@amd.com> In-Reply-To: <49d4c5e3-d853-605c-a87f-c90ccba1ab5d@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|PAVPR08MB9529:EE_ x-ms-office365-filtering-correlation-id: 60b9773c-9e1a-49a6-6986-08dad2e31dcd nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZTtZDxmOK79G7fzp6nOt9TbS6KU00wnSESTspodepk8mEexVTr5sONHQZyvm48rdA8K2ubB9i18sohiyPzPhycGaCAlI/h8HH1dg9HCOYnXFT81nSZXHoUbZ0o01kpjwATqDLjEZhvmUq5Rx06Uev8++ydjmzLqQ/AwHlaimQw2/AbHWaWWztHBXGdKOSsk/JfQLWKPcGh6GLK5D/IuTayuWtX67G5qmVdx2M574Z6awcXqURrJIxKR195WyJtUh4XzrDouS0VP1NAxs0SWbHCazd+68JRfRCmpt/YVS5Q+ntw3dbH6/blLbieT9Gu1+bYtlntHkYILS5XUe+oiA/yI01RM09d5NaE6kUVlYesSVbakKEBjm1OcNP6o6w24yWlhj6DFBP/G8KsxhjTxweMe5CKJo4Xa2luKTa5Klrv/LYLJ8UFYJIox8SrscPlq4TfRcP0fmN+BZ8kXErgK57U2wP/q5x2AgVa+6+8xafcfZ/L0sMGyCwfpgPLiTmyjPpo0nvfDFBy4FwIBENs5NmMqIokHtgbfzX4RNuh/VDYwcwHIaiY2+aB7AoYdvBHFYS/N9aRL+ePw0NVwBZddYSmIrooAvkaMKAqOVTueHKmmFEYb+zBTklrqmLl1ehAhxUQyAcF9KKchdTKIMIqJHnv3uBMekO/6nt3oZtpYn90+NQhqYtVyJwLkxMh8RTwMpA7fkcj86jZD8xsFzHEaFL8NgvMXHsySy7TaJZ7ZhPuwyemfPB0tSwZba2Vy0qIvoRwQEg4b3UYrYxJyo/zN6ew== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199015)(53546011)(36756003)(478600001)(6506007)(122000001)(6486002)(71200400001)(41300700001)(38100700002)(66946007)(66556008)(33656002)(66446008)(8676002)(64756008)(26005)(6512007)(66476007)(91956017)(76116006)(86362001)(4326008)(316002)(6916009)(54906003)(38070700005)(5660300002)(8936002)(186003)(2616005)(83380400001)(2906002)(84970400001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xsLmpkljxpYJ/eITF0WSEnrm8GwcvpaMRNo3aOcJUTviqygvXXvKyX7HvSbK?= =?us-ascii?Q?T634krT2jrZW4HU53m9mN8KWV5l9WZ+xvyMeMkTgW1K70hSNWT3c3OaaTXsj?= =?us-ascii?Q?wFD3e7F0l6VZgiH3a6hI/Du7yIuOCDobTrj++JR1uUPNgD0hbVVBvXM4x+AU?= =?us-ascii?Q?pBS92NusjdZOivLrZSsREC39TGe0qo/KUj7nbyDatq3xWLbKS0EhSHidExx9?= =?us-ascii?Q?QHA4hNc0dJdXPM9N+JWWhPHL1Ct9jNmP3hTVQSryr1VW+3v2nExu96Zp9jHY?= =?us-ascii?Q?PZASySwIX2Y7kn/YEkWrjtSdAPIEdVdOi/giJX0TrDzCpsjJyz6q03x99T4m?= =?us-ascii?Q?jF6RBebUkdX2i2fY5pou8SEMEOPxZrnjw5DWoM2hyFp+sKzCQPOdnGznG8PP?= =?us-ascii?Q?/2DayuLqh2kziHGhhH8W3EsjPfiB14WjWmiMs6lbITTNG5+KHH/gxIQvV5BR?= =?us-ascii?Q?Vcml3pDeXpJxi92xkj+cXXW4xzYTly5sbosfecvwq/ZXEqD/DGQXMufj7TXl?= =?us-ascii?Q?Ea00KwqkWLvOJgn4P0ait2f/oWBmaKU3XJSROQKqcjridtp52iOeu8ZG9qoa?= =?us-ascii?Q?PSbmuUEH+eQTFquS40NiCWL+0NUnSzkRk6Di0CWAyQ3OH2ib1kM/K6Zvk8/5?= =?us-ascii?Q?P4Fy0K2kDqFSo9jmq+JHVOBioSSBp4vsdZyo+VmV5k4FZgD8NFdNHx+EVrHH?= =?us-ascii?Q?bXCxDyl/BNhMfhBFaCwAoWmND+iON3atcbs48nOpX9JD8DmFuG7X7wjxmwZG?= =?us-ascii?Q?UPPRt6YZxqIkwGKthUmvMhNjRLZyLdFy6GeWyzZfr/eWytvinYgKwjgiXbAV?= =?us-ascii?Q?C9dpjAxwEvRkp8BxyvZiWeZpQu4D23zYjOcci6yW30Q8A3ySHn7fF3PZyJpC?= =?us-ascii?Q?6ClEprD2ySNrOysHdRunVzU3bQ1U3aW9EeYJNumEqT3vnLgYh4DyPk4d8xJF?= =?us-ascii?Q?Gbi9IgC6QgXnMPm26XOLfjeVPkgFe9EjLnB1S3d1przBFjb2+fKJKKvVV798?= =?us-ascii?Q?vYYMq4OoP+CIesHbAmuoCurX55SW8B+KCvRxq2FsRtktGSQPYynRKckX7WTM?= =?us-ascii?Q?ZYRTOCMoz6noEguKMz0hk0cGo3resoufPdo/9g53YfjntmOpFv+A7BkNO0X6?= =?us-ascii?Q?xPm+CUlhFnsEqidmxZkSN4p9CBukmUykhVXdEcar+2U54NjNbHVmQeEAC4jA?= =?us-ascii?Q?gMpzdXL3BLzyt2p+E0bDptpJA0HXxleW4nLeencT36jSdf0hFxBeRN79vkLk?= =?us-ascii?Q?8D8P0WWfYL25ElkbYOgtQmhrZFX0d31kdtUn7b73RE8G37pTP/O+vj8OvSJO?= =?us-ascii?Q?Nh9TyuBqs3ra3uzGg5j9Dw+0l0WHmZ5BOrTZMIBITqPbLft1S8b0nUKv16EV?= =?us-ascii?Q?kp68A2lBjLdL+za4cvRaC0YeUIFV0+15OjyscplpRgARHMDOpaAgHOfhKQXl?= =?us-ascii?Q?Mfvd882FTakdfcuWSeen+0aSzOnCW+uJ9tVd1RM5OyNdY4vTw9QZ8Oc4GCtE?= =?us-ascii?Q?d7iRIlTzccSleCBqpcpr7cHUp/7uQ4uMp0yhroffl7aTfT3hTvs6+RCr4n9E?= =?us-ascii?Q?6fNq1Rg00CyQNWAg9CFGOVi90n2KRljsXDyOldBYHDvoHMzjvtz04ij/g51l?= =?us-ascii?Q?Qg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <44FA011292083741804DE259D0D245FE@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB3784.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60b9773c-9e1a-49a6-6986-08dad2e31dcd X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 14:56:52.5288 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dFgodnUOAJycdDPB7lgqyLVOyo/LnI1Y6rMCE/uKjue+CSvHoluf9dOIVvmTi7XvxyptGSJy9AK3wkKqk4HI/NbyZ7hJkf6ltot+KksSyCE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9529 Hi Michal, > On 30 Nov 2022, at 13:27, Michal Orzel wrote: >=20 > Hi Bertrand, >=20 > I will try to build and run the yocto containers for a test. > In the meantime I just spotted one thing. I will wait until tomorrow for a v6 in case you find issues. >=20 > On 30/11/2022 13:15, Bertrand Marquis wrote: >>=20 >>=20 >> Add containers suitable to run yocto kirkstone build based on ubuntu >> 22.04. It contains all packages required by Yocto and a checkout of the >> layers required to build Xen with Yocto. >>=20 >> Add a generic docker image template to be used to automatically generate >> docker files for different configurations: >> - specific yocto version >> - different targets (qemu arm, arm64 and x86) >> - different host platforms (x86 or arm64) >>=20 >> During a call to 'make all', only the images for the host platform we >> run it on in the CI is generated. >> If needed, images for an other host platform can be generated manually >> by calling the right make target (see make help). >>=20 >> Add a build script to build and run xen on qemu using Yocto. >> The script supports arm32, arm64 and x86_64 and checks that dom0 is >> properly booting. At this stage this does not run any guest on top of >> dom0. The script is to be executed in one of the docker images to build >> and run a system using a Xen source tree. >>=20 >> Signed-off-by: Bertrand Marquis >> --- >> Changes in v5: >> - typo fixes >> - add INTERMEDIATE to remove intermediate dockerfile >> - use container architecture >> - use full words in foreach loops >> - fix shellcheck findings in build-yocto.sh >> - rebase on sstabellini next branch >> Changes in v4: >> - Rework the system to have one dockerfile template from which make will >> generate the required dockerfiles for the wanted configuration >> - add support for different host architectures >> - Merge the generation system into one single dockerfile >> - Merge patches 1 and 2 in a single patch >> - Introduce CONTAINERS_EXTRA to have extra containers not built by >> default (for those not used by CI but useful to users) >> Changes in v3: >> - limit number of jobs in yocto by default to 8 and add --num-jobs >> option to the script to set a custom number of jobs >> - do not copy anymore the build-yocto.sh script inside the main image so >> that the current one in the repository is used when running >> Changes in v2: >> - add a --dump-log command line option to build-yocto.sh script to dump >> the logs if an error occurs. >> Changes in v1: >> - add --image command line argument to build-yocto.sh to allow building >> something different than xen-image-minimal. >> - modify dockerfile to have one layer per line and make it easier to add >> other. I kept the for loop to keep the number of docker steps lower >> - update commit message to warn that no guest are tested. >> - fix build-yocto script to properly return with an error if expect >> script ends up in timeout or EOF. >> --- >> automation/build/Makefile | 14 +- >> automation/build/yocto/build-yocto.sh | 351 +++++++++++++++++++++ >> automation/build/yocto/yocto.dockerfile.in | 114 +++++++ >> automation/build/yocto/yocto.inc | 42 +++ >> 4 files changed, 519 insertions(+), 2 deletions(-) >> create mode 100755 automation/build/yocto/build-yocto.sh >> create mode 100644 automation/build/yocto/yocto.dockerfile.in >> create mode 100644 automation/build/yocto/yocto.inc >>=20 >> diff --git a/automation/build/Makefile b/automation/build/Makefile >> index a4b2b85178cf..72a5335baec1 100644 >> --- a/automation/build/Makefile >> +++ b/automation/build/Makefile >> @@ -1,13 +1,18 @@ >>=20 >> # the base of where these containers will appear >> REGISTRY :=3D registry.gitlab.com/xen-project/xen >> -CONTAINERS =3D $(subst .dockerfile,,$(wildcard */*.dockerfile)) >> +CONTAINERS =3D $(filter-out yocto/%,$(subst .dockerfile,,$(wildcard */*= .dockerfile))) >> +CONTAINERS_EXTRA =3D >> DOCKER_CMD ?=3D docker >>=20 >> +include yocto/yocto.inc > Because this appears before help, when calling make without any target li= ke: > make -C automation/build > the previous behavior of printing help by default is no longer true (the = default target is > taken from yocto.inc in this case). Instead we're getting: >=20 > make: Entering directory... > rm yocto/kirkstone-qemuarm64.dockerfile > make: Leaving directory... >=20 > This include can be easily moved after help to stick to the current behav= ior and still > achieve what we want (i.e. make will still first evaluate include and the= n call the first > target which is help, so CONTAINERS and CONTAINERS_EXTRA will contain cor= rect data). Complete right. I will fix that in v6. Cheers Bertrand >=20 >> + >> help: >> @echo "Builds containers for building Xen based on different dist= ros" >> @echo "To build one run 'make DISTRO/VERSION'. Available containe= rs:" >> @$(foreach file,$(sort $(CONTAINERS)),echo ${file};) >> + @echo "Extra containers (not built using make all):" >> + @$(foreach file,$(sort $(CONTAINERS_EXTRA)),echo ${file};) >> @echo "To push container builds, set the env var PUSH" >>=20 >> %: %.dockerfile ## Builds containers >> @@ -16,5 +21,10 @@ help: >> $(DOCKER_CMD) push $(REGISTRY)/$(@D):$(@F); \ >> fi >>=20 >> -.PHONY: all >> +.PHONY: all clean >> all: $(CONTAINERS) >> + >> +# Remove generated dockerfiles for yocto >> +clean: >> + rm -f yocto/*.dockerfiles >> + >=20 > ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 30 15:07:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 15:07:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449931.706976 (Exim 4.92) (envelope-from ) id 1p0Ogi-0006SW-Fy; Wed, 30 Nov 2022 15:07:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449931.706976; Wed, 30 Nov 2022 15:07:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Ogi-0006SP-DM; Wed, 30 Nov 2022 15:07:52 +0000 Received: by outflank-mailman (input) for mailman id 449931; Wed, 30 Nov 2022 15:07:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Ogh-0006SJ-U3 for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 15:07:51 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20607.outbound.protection.outlook.com [2a01:111:f400:7e1a::607]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c1db9a93-70c0-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 16:07:51 +0100 (CET) Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAWPR08MB9637.eurprd08.prod.outlook.com (2603:10a6:102:2ec::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Wed, 30 Nov 2022 15:07:48 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5880.008; Wed, 30 Nov 2022 15:07:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1db9a93-70c0-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M+vlgsQRUMwtw+KpGh3Z3iF2B5CZMSpXmLZmI+68qP1Ffs/JirsQ411cWBOe27y3DRhiD3o1muwZJ6SBm0N1OeqJH+k7UOid8rlcc5kJ/w8AYiALAefE5PL0iTuAt5LXK4xOW8x2PStIYNWn8Ap/VP1W5XL6f2YWtQ95SLbh0Cp0F0qwXqRjrD1Seqofj8X6RtHR3vSLr2gBUlQMMxxJxbgpPL/mXg+L5hbSK65o8kFIuIJDGAMQABRjDeyAWK2QlKNR7SuQNqRSgyTqZuXGVqMQHXD3vdV2X/DS3QZ0Vdv5U0iiTc/juQoMVcS4+Xsng6rNnr6jCKkNldW5x96kmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8JSPBRv0xEMLWnES3R8tpiE0sel0x7eSYx7MrZeuS3w=; b=NLiiUls2IDBCw6Kyvgup29fQB5pNzA5PnZk48ZsESGTmsUXC2C7w9FOAxIGcZzsYTc1ZrDQ3vXHGQ4Q6+Qv9OZztR1ALVIsxXH7+ICs43e7wzZgsK620K7bUtEPVI6W1kc59noCKz9KMvbuNY/q7HHPSSFbQrci68D94sSnibxomlMuicvwD/UZncWD+7C1EbVaRJCbGR6RqCdU5sZ4OUCP+sv8JYBCzYzD/JPi8cBTAiWYGNfnkzJNi2QPk5hqNb5YcvMbnelCr8FBXvh/+gDN39yTWsCDEvhECXTPBhWVy4TteafMDh8b+/OrCqqc7bkL7He3FkSXxnQzjtJp0xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8JSPBRv0xEMLWnES3R8tpiE0sel0x7eSYx7MrZeuS3w=; b=sQd07KovlTwfNYmahJlKQpmgw7n7x391ErxDZV1CL6zgLG7Vx42ymns/ZiiNfIDiervcQoopYHDPaYYfoezZ1eD1lKhQ93DcXRhbcUxEWgjJ9Prd/FvH76xttXYKrnnAJ58Bh9JSQkdU3sjXNHVoRmDlqtpIiwxBrnLAXgyNPU4= From: Bertrand Marquis To: Michal Orzel CC: "xen-devel@lists.xenproject.org" , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v5 3/3] automation: Add CI test jobs for Yocto Thread-Topic: [PATCH v5 3/3] automation: Add CI test jobs for Yocto Thread-Index: AQHZBLWHjw1n6cWydUSV320FMd2tla5XbqkAgAAi7oA= Date: Wed, 30 Nov 2022 15:07:48 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|PAWPR08MB9637:EE_ x-ms-office365-filtering-correlation-id: 11ab807c-4f71-479b-62b1-08dad2e4a4ee nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: J/jUNrx2NtGj7gQjba4tW0utQjrv6C+LksQXur3qh5GfBpYngrPfO6Gfq1NWqA76XM1q0ynCCLK/1JqKtfgwFngbPfvUwaggOdEeKmVQ0D00c9dcOaXyFOn2ML+rl+CQ+8KD9sjF0lra6IYTuHu3g2mtCG/NFGjqaNDqNXbL0bemNatAwHtKTTI4FBb230ftd+uL6EHrBCTz9FrmZRkQ1f+YuS0nIGuKRqf9LqHsSTq+gz9MwPpOzKzCCanowsBmbyOPq78qOUpMVYp0akqTRqX/8b1LGTtrNN4FlQtRo/2Qsd/5UvMG8+RKNc8sHNJD+27VpafI7NaZEW7iXN0Shiw+VXVUie+dyjn+q2S+DJZaceSH2qw/iy5E51eyK5ntCGyP2UYZcKzI70VNVBR85mJu5I/XV3N6GqQPaaXOiiyHWhIUFQtw2CtcID/ffP9x6WjWrKmKrOWhzuWZU0cty+hfcOBRADVVYI67+gRgBF3hvlLz8dt7/Bqy2XKW8010993tM4KJeBbsG9DExbG6duzlud4VbW4wdsvQUd1NYszVeI/BrouDIhjmyl7HVU2KqJlsNqNQtfrzIDhEuVWGmoWHAF25zR0tRzmuwC9/tmkIzvi1UTIfWAXjCiQjuuUTwhF+p7dgljrlixi1reEdqRFpbRaFYK0AK9Muegh88FUz8W9OMwDWDJVwUyTKY5/Ube4Pv7erkQyElOY1mTwN2nzKBb2aONGKaosJrhkxhjE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(39860400002)(366004)(136003)(451199015)(91956017)(5660300002)(36756003)(33656002)(2616005)(76116006)(6916009)(6512007)(54906003)(41300700001)(8936002)(316002)(8676002)(66476007)(66446008)(4326008)(186003)(66946007)(122000001)(66556008)(38070700005)(38100700002)(64756008)(26005)(2906002)(6506007)(86362001)(6486002)(71200400001)(478600001)(53546011)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Qq6EPgTcv2zuVsAXAcblbGQe2HvRD44odatQqRK0Hrm26Mv/lIsDuzVqAvnp?= =?us-ascii?Q?TmMJGfTrGIYu2oaSAN4YNL8pum1n3FI9yGWGPwA5BSCGydQWFRnDnhSUirmp?= =?us-ascii?Q?fa+Kt8a8HKNav03Kuf0BNKLuVuaamA8S4ylI6dHnmJoEx5BLg2GdW2b8aS4n?= =?us-ascii?Q?LC1oapFYuszfGrqYK/HFXtFtMpv7lc/u1zAV1/xc3HAx8UxHx8vSy5AULpeJ?= =?us-ascii?Q?zoMA+04p3Fx3/tQZbHUyL0yAc4m944xhPszdL0eiI0ghH2jtUWG1aItfZjTy?= =?us-ascii?Q?AZe4rPQ5+kljJ1iDRxk6F2przU6t6fBRmk+eXfCkRhsrf1L8RfhPfLBSSQes?= =?us-ascii?Q?5EQg2FSUOjQd++wRlUtVSCYdxnFiMTz0m8Qv3BYtTLv360EZUWSToLmNIrbK?= =?us-ascii?Q?+8egdPFh3onMp8mvgILPN+07CC3i8VBuyS/+Sct67GAVQO3zl971Yh+0STIV?= =?us-ascii?Q?2golNrU+H1KY0twTaNq4kccCLyxVBV2Zp/LvbsSdBN3CcMOkYfIoISzJUnBt?= =?us-ascii?Q?NhC4kz2NUBmAxAMz5gIUngXQ+SvPAT9+YR0yjM+fYib5fx5DjHRy0mR1cAY8?= =?us-ascii?Q?v37dO+SL4PMZVja7PNfILA4ziR3hl6kDy7OPS7PAjrEy4YeUjHHhji8U2nCR?= =?us-ascii?Q?aR9aqWh1vsKZQzWltD4lw588rjY4Qllwwrvv+7uimZsm6xPLHgp4rzxCvRHT?= =?us-ascii?Q?F7I4+E3WOKwCk/sDokyACmsiBSsRklk+uJK/xtExWgC5s2kHdjaJHmWkWryI?= =?us-ascii?Q?UjMiM3HfleEGqCAMICDhY84NnDlvmxboC92bAoj6JyVLTuWv+xAk35lZ3M71?= =?us-ascii?Q?n2Gw30QhrGjZ50Kp4mF16yF8WMz6DixtWfuAQjW1lllsMuHscQc2hj5q9hyK?= =?us-ascii?Q?snTvxl0e29EZs1ySofRJju9ovD/e2HCFVoElPcjcUcuW2evIovnuefvwpjyR?= =?us-ascii?Q?CmT7btZ+06T1+yq5m8nQ2gVzrASsIi1wPVA7TM+BjK5M8UCBGGCiDrZksefC?= =?us-ascii?Q?KJiMZNRY1RqEpMXBxqS890H6/oA95mWrdn3HQ1n+nhgcO0ohERF6EHRXfne/?= =?us-ascii?Q?IyTQHP2xkYARm9e3mPbu6glhuYpD/fUjVpbKOH1cyATU1coomaCsjeLJ8mSz?= =?us-ascii?Q?wmAe9u7llinLD8KzC+h/V/8pDTYR+JlYeUVyMqxjsmliqqv0/Fh+3+22Iz3e?= =?us-ascii?Q?W1lHoQQbI7hCRErfROaJm1/u4cUfTldHWcMLj7LUyH9opGM9lWYOkWS0hZhx?= =?us-ascii?Q?RMMkrEL35KiZO2KBmYtjkIi54XTPZqWenHKJS8reio1h8vFCsq8NSeg8xXLz?= =?us-ascii?Q?zaY+NRI2rgNN14JEqbEhbnBfPonnL2e+ZGD0lXst1BvR59dvzItaZgLVV0dX?= =?us-ascii?Q?wt5cVT/aBBLW7qg6sfrWY4ndw7JbhsQnI48pIlsM7OffSuzphqXQsPCJJwlo?= =?us-ascii?Q?/1AWhzLzqpxQZaivCXkTOhQqBEMrTpMS0ooLoPRqRIq/bxOABwyMYfZ9QOoL?= =?us-ascii?Q?MTalfAhdvEuFvijEFRPv8rLqJqOrgdO6s/J2LdRjIZXWtn44xL7niZFxmcJe?= =?us-ascii?Q?TY7Bg7qCPo3jSqMDhX7Zith5Aoi7wBBAn72Yu+SG4zF+WPldLEgwoy7aGz84?= =?us-ascii?Q?Ow=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <73E203669D91384B87BDC107F946AAE8@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB3784.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11ab807c-4f71-479b-62b1-08dad2e4a4ee X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 15:07:48.7652 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ToK04SHBPWY0yxT8Kts9MW/R7SKKjspvQwnxRMqnIzySjstUQBu7YILtItql1/BJpG7wMMgeBXXov6ylhCFGBpM64xKK5S0AWpG3ZpvTWk4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9637 Hi Michal, > On 30 Nov 2022, at 13:02, Michal Orzel wrote: >=20 > Hi Bertrand, >=20 > On 30/11/2022 13:15, Bertrand Marquis wrote: >>=20 >>=20 >> From: Michal Orzel >>=20 >> Populate test jobs for Yocto based tests using the provided containers. >> Due to the size restrictions, it is currently not possible to split the >> build and run tasks, therefore everything is done in a single step. >>=20 >> Test jobs for the supported Yocto targets are generic to avoid the >> necessity to add new ones after each Yocto release. The only thing >> required to be changed after updating the containers is the variable >> YOCTO_VERSION stored in a .yocto-test template. >>=20 >> Signed-off-by: Michal Orzel >> --- >> Changes in v5: >> - none >> Changes in v4: >> - add .yocto-test for arm64 and x86 >> - make yocto jobs use arm64 version >> Changes in v3: >> - patch added >> --- >> automation/gitlab-ci/test.yaml | 43 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 43 insertions(+) >>=20 >> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.= yaml >> index c7e0078e04f1..6ce2fd63eee6 100644 >> --- a/automation/gitlab-ci/test.yaml >> +++ b/automation/gitlab-ci/test.yaml >> @@ -54,6 +54,33 @@ >> tags: >> - x86_64 >>=20 >> +.yocto-test: >> + extends: .test-jobs-common >> + script: >> + - ./automation/build/yocto/build-yocto.sh -v --log-dir=3D./logs --x= en-dir=3D`pwd` ${YOCTO_BOARD} >> + variables: >> + YOCTO_VERSION: kirkstone >> + CONTAINER: yocto:${YOCTO_VERSION}-${YOCTO_BOARD}-${YOCTO_HOST} >> + artifacts: >> + paths: >> + - 'logs/*' >> + when: always >> + needs: [] >> + >> +.yocto-test-arm64: >> + extends: .yocto-test >> + variables: >> + YOCTO_HOST: arm64v8 >> + tags: >> + - arm64 >> + >> +.yocto-test-x86-64: >> + extends: .yocto-test >> + variables: >> + YOCTO_HOST: amd64 >> + tags: >> + - x86_64 > This hidden job is not used by any yocto test job and as such can be misl= eading to others working on this file. > So we can either remove it (can be easily reintroduced once we will find = more x86 resources) or add a comment explaining why is it here. If I remove it then there is not reason to have something separated for arm= 64. I will keep and add the following comment on top: # This is not used by any test job as we only run Yocto on arm based machin= es # Keep it here so that someone having x86 hardware can easily add jobs Would you be ok with that ? Cheers Bertrand >=20 >> + >> # Test jobs >> build-each-commit-gcc: >> extends: .test-jobs-common >> @@ -188,3 +215,19 @@ qemu-smoke-x86-64-clang-pvh: >> - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE= } >> needs: >> - debian-unstable-clang-debug >> + >> +# Yocto test jobs >> +yocto-qemuarm64: >> + extends: .yocto-test-arm64 >> + variables: >> + YOCTO_BOARD: qemuarm64 >> + >> +yocto-qemuarm: >> + extends: .yocto-test-arm64 >> + variables: >> + YOCTO_BOARD: qemuarm >> + >> +yocto-qemux86-64: >> + extends: .yocto-test-arm64 >> + variables: >> + YOCTO_BOARD: qemux86-64 >> -- >> 2.25.1 >>=20 > ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 30 15:11:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 15:11:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449937.706988 (Exim 4.92) (envelope-from ) id 1p0Ojo-00081M-5d; Wed, 30 Nov 2022 15:11:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449937.706988; Wed, 30 Nov 2022 15:11:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Ojo-00081F-0y; Wed, 30 Nov 2022 15:11:04 +0000 Received: by outflank-mailman (input) for mailman id 449937; Wed, 30 Nov 2022 15:11:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Ojm-000819-Jz for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 15:11:02 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2b938db5-70c1-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 16:10:50 +0100 (CET) Received: from mail-co1nam11lp2174.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Nov 2022 10:10:56 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by MN2PR03MB5149.namprd03.prod.outlook.com (2603:10b6:208:1a4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 15:10:54 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%9]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 15:10:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b938db5-70c1-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669821060; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=yRZuZYESRTpPHJ5S0tLdmAUG8W1yOwAN/mIDBKSAHgo=; b=ejoS/M0vQCTcvEhWNjY8GEY5cKq+JRjNVFXgBBQUkE4HpoiA0t7Zb6Vr H9B8cD//ADmkaisegWi88zhaWkCouh5onqUXWo+Qf5cprzritnycDVXZE VCFxDt13j95rzoloklHO6Thp7UpXdfzGZx/00b+bwvMRryjyUTmVamsQa E=; X-IronPort-RemoteIP: 104.47.56.174 X-IronPort-MID: 85866557 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8F70CaryVtnMDWlj9TV6lxdbeydeBmJjZRIvgKrLsJaIsI4StFCzt garIBnUPv/eMDbzKYp3b9+1pkoF7cXRmN9qGQpvpXo3FngUpZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzCFNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACkNSQm8uaXs+ZiYGutrhON9C/Tue4xK7xmMzRmBZRonabbqZvyToPR/hXI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jearaYWJEjCJbZw9ckKwv GXJ8n6/GhgHHNee1SCE4jSngeqncSbTCN9CSuPlq6ECbFu74StLLSwwFniCiPiohnXuZe9wM WEI5X97xUQ13AnxJjXnZDW8oXiZrlsfVsBWHukS9g6A0OzX7hyfC2xCSSROAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9BWAYaCAHTSMB4t/+sI80kxTDR8piF6jzicf6cRnyw iqLtyw3jaQ7jsMR0ai/u1fdjFqEpJfTSRUuzh7KRW/j5QR8DKanbYG17VnQ7d5bMZ2UCFKGu RAskc+E7ftICoqRjiuTW+YcNLaz7v2BPXvXhlsHN4I66z2n9nqnfIZRyDJzPkFkNoADYzCBS ETTowJK+7dIO2axKLRwZ8S2EctC5a3hE9vifv3QctcIYoUZXAiD+y9GYU+A2GWrlkUw+Yk7O JGGYd60BjMWBLpPyDutW/xb1q0vzyolg2TJSvjGIw+P1LOfYDueTu4DOV7XN+Qhtvrb/EPS7 spVMNaMx1NHSuribyLL8IkVa1cXMXw8ApOwoMtSHgKeHjdb9KgaI6e56dscl0ZNxsy5Ss+gE qmBZ3Jl IronPort-HdrOrdr: A9a23:wN1koKmTrUoItLas/FvBjALTOpbpDfNYiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0msl6KdhrNhRYtKPTOWwVdASbsP0WKM+UyFJ8STzI5gPM RbAtVD4aPLfD9HZK/BiWHXcurIqOP3ipxA7t2uqkuFIzsaCJ2JuGxCe32m+wBNNX17LKt8MK DZyttMpjKmd3hSRsOnBkMdV+yGi8zXmIngaRsmAQdizAWVlzun5JPzDhDdh34lInty6IZn1V KAvx3y562lvf3+4hjA11XL55ATtMr9xsBFDMmsjNFQDjn3kA6naKloRrXHljEop+OE7kosjb D30l4dFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdpXf4u8T2SB8zFsIE3OtiA23kwntlmOs5/L NA3mqfuZYSJRTcnB7l79yNcx1xjEK7rVcrjOZWpX1CVok1bqNXsOUkjTRoOaZFOBi/xJEsEe FoAs2ZzPFKcWmCZ3SchWVryMzEZAVBIj62Bmw5/uCF2Tlfm350i2ECwtYEo3sG/JUhD7FZ+u XtKM1T5f1zZ/5TSZg4KPYKQMOxBGCIawnLKniuLVPuE7xCE27RqqTw/K4+6IiRCdE1JaMJ6d r8uW5jxC8PkxqEM7zP4HQLyGGGfIyFZ0Wj9ikEjKIJ+YEVR9LQQF2+oR4V4omdSs4kc7Pmss aISe5r6sDYXBTT8P5yrmvDsrlpWAsjuZ4uy6MGcmPLhP73AavXkcGeWMrvBdPWYEcZsyXEcz A+YAQ= X-IronPort-AV: E=Sophos;i="5.96,206,1665460800"; d="scan'208";a="85866557" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iH6HN18S03N5HgH1+Xrwa4laecsxw3iaWyUrJ/lvEXPEzmY5Ji75NzxT5/dBswF3I4WEY5oTdeIhF0X0fuMTXOwqK1TbnS6cLYNwTxWf7gyq8Bpubn1FcDnDXAoqm7pml81kXMVghXxEXZXyRO+Qusn+n3iDIeXEbbyHD/kOpvFswRXzx36tlJVlNmJV7xRu5RNt1lXDd0D52ISBYosMPjIkSaVsVmKg3YIgRW4BiOsGvPNB678157Zk5GawF7iY5ezlSAdDDPlmf1zf3lLbdQzuNVztrcSxeO2KuGG0LIqU8sK/1NoQJZornOgHylHxWyg7dWU4BEw6ubmCsC2+Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uZu0f4REIMCta0o/FGi0CGBdzmQ6cRIU6CKr6+ow/1Y=; b=EyD6nnK3skT+cN6Q+NToM6zFo3rYbZqFon/sHq80w2R79EhLSdexUNpBdSTgfLYjqy1fZRhwF3yKkJwnAa71nzSg+dOOGVQ3Oe/8Ms+9A13NW1kHBY0M5gv7ZAR6DiuTTQHNm4B/hIHI+ewm1Ni4hby0iUCM+WIZpblMXLpKIEpAxErcWOg5agCinGRwujLs7LqTDFm8jnXL1SfQP7BeqfexuBGNzukmZ42cAJ8TRVsw8bXtKqtBepv6wYiX7qCRz4LT8bIV8EUPHJbu5C5EBC8y1AvOl5JJ4yATsrEvdhIATP7GRowsudqR0wPDS8t4IT8KDLjcg1zrZC0fCHlDpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uZu0f4REIMCta0o/FGi0CGBdzmQ6cRIU6CKr6+ow/1Y=; b=ugTRHSsa6sG4ugzi1rgO4E425SdSnniU6A/gWXpN9+Xxwnvg8dhibb8yz4+8TxCciXuCWMTc/gXpzSbNgtJyqsP9FtrztIhYX/iQMliHh8syHSpjh7qsOBzEHRJFHw/jAfgtzhQA45tQJUfSQ1sSc6AZnBjcG80f3egciADXf/E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, Roger Pau Monne , Greg Kroah-Hartman , Jiri Slaby , Juergen Gross , Jan Beulich , Boris Ostrovsky , Stefano Stabellini , Chris Wright , Ingo Molnar , Jeremy Fitzhardinge , Olof Johansson , linuxppc-dev@lists.ozlabs.org Subject: [PATCH v2] hvc/xen: prevent concurrent accesses to the shared ring Date: Wed, 30 Nov 2022 16:09:11 +0100 Message-Id: <20221130150919.13935-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0165.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::33) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB5149:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b9baf0c-59ea-4337-3e39-08dad2e51343 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xo2ptJEmCY92/7dFY1PDP/VqgTLmRrQjLa5z1qS6qluoSkcstOK2PjaoDlXUcOUrnab6qi1GPw4sjgxVCdK5iUjV59IDEnL68v6Kb0LcdKwxsyTj0svMXeAzYdz7p8LwAf0rIFTb14O160KeTBUHHEQYlF/9G0my1Cegc7jIQMPMCaCbcHOpi63ItTqwM2pUwAr2Ni0nq+/1zBMt69pJoWeFR/b3vWr9962uNJbi9xP/JzOmvmmkI/JGC+amM9xF84pFbyeySM1d+yygbU7MWbwabXJNAI4mlS4LJyAVmZSDsmBMu1hqt8EpiR7VDQHxiSynpT21JvDm+T4N4ffHxPtbb9f/BzBNvK33ErEmp/IKRKtzB5m0WlyExjFg3QnhF1JqhD4b3ST1JxKtyrk9a4oaYvcdDrb0L24HFL9YDTSRIsImyJXnP4D+oUrsoUmdoo1dT6OJ1EmJGp9ne28U85ac/3Lp2Vm6OY3L/SUM7p4PpAFEHKw3/9teMKWpciOspqffOAWXxWKa8lBQNVGmWlJjBR8gSyQ8wYWXFbLmm4PSBQb1M1sUp2wV1rbqYliN1eH6E2ArhApjlc6RsCjpCEPJ2pWbnkZgmMjo1GmhP+phYY8YdwN4yhPkeUnLI7avSWF6DmcGLEUbgVqAgbr0HA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(346002)(396003)(366004)(451199015)(36756003)(7416002)(86362001)(6506007)(478600001)(6486002)(186003)(2906002)(316002)(66476007)(41300700001)(66556008)(6666004)(4326008)(66946007)(5660300002)(8676002)(8936002)(54906003)(6916009)(2616005)(38100700002)(26005)(1076003)(83380400001)(6512007)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUxlOHp1OUUxdnowS3pqTEhib2RuL1hPaGZCUDlRbGxrV1BzcnZPcXVCSDNM?= =?utf-8?B?NmQvTXNmTi9PVUpUZGY2M2FVN3hReTFpYVlSK3V1c3R3cHBJdU80eWlsVUdD?= =?utf-8?B?ZWxUNkt6QXdZdFhOa0RtM2NTUW41RkFtRnd5cWQ5bXpEZ2lTWkFiQklsWU8z?= =?utf-8?B?VzhyTmRLWksvTk93Z0ZMb0QvZXlJcTdJSjdseGpwSk9kNStPZjU1WGFQWHhq?= =?utf-8?B?S05WeDBFOHF5NS94czNoYVZaZHd1NmVtVlAybDQxalc3cXJra1QweWRTd250?= =?utf-8?B?T1ZMQ1FmTHNJY1ZIUmNCWWdvdDd0aG1CTm1tcVo3WWcvcWh1am1mMEtnT2Rs?= =?utf-8?B?NnNNN2l5Z2lkVFBneXJiME9URHBEUFA2UWlpU3R5U2xZdzNZWTVhbmpTR05a?= =?utf-8?B?VmRMRldvWkkyU3lzV2pBZU54UmJ6b21adlA0bzV5dENwTUk2V0pJUVNPMnVj?= =?utf-8?B?OFM3TUVlYlRSREdCOHBydDYvdWp2aUpteHA0RE9qM0dlNS9JTWoyMUk0WWpK?= =?utf-8?B?SVpSL0F6eHBIcVFkblFEck5Hc21UbG81WE9rS2dSOHR4dk9pbHhqcEh5ZFVF?= =?utf-8?B?YVplRE51UDhncEcyK1lPUXFUOFJXYk1qM1d6dWVrK01jZnNFTFhBWEpWTW0z?= =?utf-8?B?QnFNOHZ2QUlyQ3Jkdkl1NUtSWGNjQ0N5TlJrbFhTVFJ0UDFZblYyaHJ4RHg4?= =?utf-8?B?NTdBeVRSL0RXVlZ2R0tCUHRTeHlZa3BZQkh4TWRpMXNET25LWDlEdi9saEc4?= =?utf-8?B?aUdkMW1KMWNvM0NhTkZtd0RiMm5yaUdLb0VQdVpaTUVyTTR2TG1nbC9CdWlq?= =?utf-8?B?ZUJyR2pSM2k1Ry9yMWlUcXJVUklXdDVhQ0MrdHV3WFg2ZUd4ankyb1Jkd0ht?= =?utf-8?B?Rk03R29yeENFYkJxWTR3OWxaVTdsQXFDZUlXbWFvc28rZUg3ZmsvSjZPUzE5?= =?utf-8?B?b052VVFPdmZjbW1RamxkdVpwMTdJN1pQOExxTWd3aExkcytMYlRLTTNxTnpR?= =?utf-8?B?eHhucmVkNlJPVlZNWDZhVnJxdUtHMjY4bDZvMEFMQTE1blBLL0tyOFQ2SjQ5?= =?utf-8?B?N2loYW1sVzhEU0JKS1NxdldKYU53aWMvR0tQWS94NlNGRUU2VFZKZ0pBOUUw?= =?utf-8?B?b0xZb21meVpTMWkyS3JiY1grMDA1UldpZ3piVEVWWVREblFIRVVaUFBPaW43?= =?utf-8?B?TzNRaThZRW1Ib3JDcXlKQURQay92czZwVlA2ekQva2V6cjNvQXJkQzVwOGly?= =?utf-8?B?V3cwMkRNM0V0UjhGZUFSWnBURUR1dG9BT2kvdzRBYzZZek1zOUdJanNLZm5m?= =?utf-8?B?ZCt4WC8zNWtacGl1YWY5YkhqNm9jenBQOXdIdUczanErZDF4eUVZNFVwd0c3?= =?utf-8?B?SHBaY1BiU0YvVUltNlQwRCtrQXZCUEFzRDQyVUhmNDZlb2JtakIvRUtIRjNX?= =?utf-8?B?Ri82SGFrMUlrSVRSQUczRmlPSVJkOWw5QUtyN28yLzNjZzJHeTRhZnNkM29J?= =?utf-8?B?QnIrWEFOWERRS2dYOHdCWXdxUmxEWGNHTURKUE0wM3ZDY3V2dVhpNkdQSk1w?= =?utf-8?B?TmNQcnMwOGVoeEZHcmhvWWdyUkVyQy9DaG1udTZjejBFZUdBcWRCM2FQMTli?= =?utf-8?B?d3JCTXVuTDljWXZBWUNtZmc1Wld2ZnVoL0VKSml0eUpmdk1jeURRTFBLTkdK?= =?utf-8?B?b1FvUHJjZHZUazdXd0I0NVV3MXFzcG95RTBaTDZURmVzVE9xR3gzUnFJNkFs?= =?utf-8?B?b1c4RmpQbmJTTTVlaURLYytQYnNBSndyMkJnZW55azV1Mlc1Tk1OT0dJdnIy?= =?utf-8?B?eGw1d3g0cWZ6WWRoYlp5dEl5T0daMDZ0NGhqNjBXVE5JMHJUd2UxbXkrcnZi?= =?utf-8?B?NnhLTTFneFBNanpybXlHdkNVZ2JOUVhlOS8rd2Y4QkZjanRxb1RPYjZCQTJJ?= =?utf-8?B?MmNkaHYySEVtQkVtT0RTVHNjNkNhbGxhUW8vQnFmVHFMai9WTDVBQVVWSkRp?= =?utf-8?B?c2RzU2tXMDZVM3E4VnBzdWdPTjFDR0Niay9VaXFIYVZlZzNveEtaUUIvc0NW?= =?utf-8?B?dXlJdXNOVlBnME8wNzdXSXFWWXVXN1d5aTllN0xEb29lb3dxVVR4cndhRzNH?= =?utf-8?Q?fAWR8cQ9vVuXwqFgGgPiIseIa?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?VER2Y3F0SkdwMi9LMkxaWTgxVXMzazFoVld1czdjZkZhbmpiQWVtRWZEcVZx?= =?utf-8?B?VjJNeXkrVUFpL0h6ZmxhanZDODJ5MmpZVTRkMEhUdzZrNlBhSmg4MnZvZEd5?= =?utf-8?B?d1dpU2pDcTZFWThLcWZYSFFKYmVTT0Q0V1hQUVF2YWhybjV1MUU3Q1k1RDgv?= =?utf-8?B?cGhpTzFhejhiVkRSaCtUMDNQenpuNXNxNUxVN1VKWGU0dXdHQWROQjVmSWpH?= =?utf-8?B?WXh1UEZlRko2eWM0RnlubnZKWFR5aUNHblFHTUFBTnZZeCtKbkEyekNZVGhK?= =?utf-8?B?dS8wRFJ0RExvWmtlbVBYeEFGYTRYS2dDdDJwNjVrVkRWOTAwTzQwek1yMVJB?= =?utf-8?B?cisyb1RnemZBdkhaZDJmaHlFTGpDTCtXSFpFUUxRWDNnMUlGOWYwMEtxS0VX?= =?utf-8?B?aG9FN3Bnb2ZXWVp2amFmaTJjbEgvWkp5czd4MnZkMlBJaDVYeVhYYkpYUmNX?= =?utf-8?B?YS9pN3B5aGFNMjJrS1k4ODB4eC9LU2RTb2hjbzNZdm1xUS9LSVZhMVdEaFE3?= =?utf-8?B?VFlZNGk1VzQ1akFNakFEVWpDODBDWkdkOGVKcWlpbjNUSzhDYTFaSXlvN04w?= =?utf-8?B?K2k5eDFDVjc1ajRlVy9FNmFVTDJtbWhyS25oNHMzZEMvU3ZkSVg5WmNYR1Rt?= =?utf-8?B?bEQ1Qzc2cjY5VWY1MHZxd0dkUGQ1UlZ6RUxPT2dzaHV2SVJXdytXRnpXb2Nr?= =?utf-8?B?SFNoWFYzN0FKWFRzR2ljNThYU2RJYVl5OEIwbUVGck1XYkg4OE5Rby9VWTdv?= =?utf-8?B?N2ZrR3RJSHNFRlRSUkhkbUFuZHNUNnR5SVN2SGxKM1pkZ2lYYWpZRXBIcGNU?= =?utf-8?B?cGJtcnRNR1lIT1NxdnhpeHR3eEl5WFlHc00zdXRGY2VyUGlUbE8zZE9TTkJz?= =?utf-8?B?NXNpWTMxa08yd3lxYm1oQmZ4YXpvU0I2VHVzNTlVV0lqaEVNSEU4Vjg3dGhP?= =?utf-8?B?VjB1MlFzajFSaVorRitwdWVQangzWGpvdUtEZURRaVY1N3pKUGNyZHEvMUJi?= =?utf-8?B?a1FNVUc5SlFubTNWc1hPVDZLS2tHdmdoanEyU1ZERk5rYXdMc295b1hKeVhJ?= =?utf-8?B?bHVNMS9VMkpQMCtodGJzM090S1pvcCtOREFDclB5emJzNEhIREpod0Mrck1j?= =?utf-8?B?c1ZmV1lDRkFNa1FROHc5R3dZcWErYkM2VkRCM0lnc3Zhb2h5em5va2kweS9i?= =?utf-8?B?a3pBcU9UMnQxRU1VN2RCdngvcWM4M2pFZVpvZzhTYmZManZLb3pMZUtZN3Fy?= =?utf-8?B?YkVPTUlta0ZEMy9vVkJ5SUxpWTJHalZYSEFsSU93Mk9zTy9TeHJhWmZHV0F1?= =?utf-8?B?eWJSbzVUV3dOb3pzeUt2cTV2QnExV0FpaTlaMUpUUGJtbTVPY2hiK1lOdmxN?= =?utf-8?B?cTVXZVVXTkxvMEVoMzMyR3NFNTgvcXVSODVIUElPcnNQNW5zZjZla21NOUQ1?= =?utf-8?B?S0pKblhWUm4vV0xZNWo4eVpSMy9RczZZZk1yNjdNb3NWa3BGd0JGckl1NFVF?= =?utf-8?Q?FpEufFxKZvcLWBjWVJ+VhHRBfSi?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b9baf0c-59ea-4337-3e39-08dad2e51343 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 15:10:54.2457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kiSLTWgBuEIhT9ho2XTv3uD1zByPNmYi7F6/DFCgKhYnHhFRg6Mot9jZzwLlKe7eFRKujLMY5Kou2msvnGpXFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5149 The hvc machinery registers both a console and a tty device based on the hv ops provided by the specific implementation. Those two interfaces however have different locks, and there's no single locks that's shared between the tty and the console implementations, hence the driver needs to protect itself against concurrent accesses. Otherwise concurrent calls using the split interfaces are likely to corrupt the ring indexes, leaving the console unusable. Introduce a lock to xencons_info to serialize accesses to the shared ring. This is only required when using the shared memory console, concurrent accesses to the hypercall based console implementation are not an issue. Note the conditional logic in domU_read_console() is slightly modified so the notify_daemon() call can be done outside of the locked region: it's an hypercall and there's no need for it to be done with the lock held. Fixes: b536b4b96230 ('xen: use the hvc console infrastructure for Xen console') Signed-off-by: Roger Pau Monné --- Changes since v1: - Properly initialize the introduced lock in all paths. --- drivers/tty/hvc/hvc_xen.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c index 7c23112dc923..e63c1761a361 100644 --- a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c @@ -43,6 +43,7 @@ struct xencons_info { int irq; int vtermno; grant_ref_t gntref; + spinlock_t ring_lock; }; static LIST_HEAD(xenconsoles); @@ -84,12 +85,15 @@ static int __write_console(struct xencons_info *xencons, XENCONS_RING_IDX cons, prod; struct xencons_interface *intf = xencons->intf; int sent = 0; + unsigned long flags; + spin_lock_irqsave(&xencons->ring_lock, flags); cons = intf->out_cons; prod = intf->out_prod; mb(); /* update queue values before going on */ if ((prod - cons) > sizeof(intf->out)) { + spin_unlock_irqrestore(&xencons->ring_lock, flags); pr_err_once("xencons: Illegal ring page indices"); return -EINVAL; } @@ -99,6 +103,7 @@ static int __write_console(struct xencons_info *xencons, wmb(); /* write ring before updating pointer */ intf->out_prod = prod; + spin_unlock_irqrestore(&xencons->ring_lock, flags); if (sent) notify_daemon(xencons); @@ -141,16 +146,19 @@ static int domU_read_console(uint32_t vtermno, char *buf, int len) int recv = 0; struct xencons_info *xencons = vtermno_to_xencons(vtermno); unsigned int eoiflag = 0; + unsigned long flags; if (xencons == NULL) return -EINVAL; intf = xencons->intf; + spin_lock_irqsave(&xencons->ring_lock, flags); cons = intf->in_cons; prod = intf->in_prod; mb(); /* get pointers before reading ring */ if ((prod - cons) > sizeof(intf->in)) { + spin_unlock_irqrestore(&xencons->ring_lock, flags); pr_err_once("xencons: Illegal ring page indices"); return -EINVAL; } @@ -174,10 +182,13 @@ static int domU_read_console(uint32_t vtermno, char *buf, int len) xencons->out_cons = intf->out_cons; xencons->out_cons_same = 0; } + if (!recv && xencons->out_cons_same++ > 1) { + eoiflag = XEN_EOI_FLAG_SPURIOUS; + } + spin_unlock_irqrestore(&xencons->ring_lock, flags); + if (recv) { notify_daemon(xencons); - } else if (xencons->out_cons_same++ > 1) { - eoiflag = XEN_EOI_FLAG_SPURIOUS; } xen_irq_lateeoi(xencons->irq, eoiflag); @@ -234,6 +245,7 @@ static int xen_hvm_console_init(void) info = kzalloc(sizeof(struct xencons_info), GFP_KERNEL); if (!info) return -ENOMEM; + spin_lock_init(&info->ring_lock); } else if (info->intf != NULL) { /* already configured */ return 0; @@ -270,6 +282,7 @@ static int xen_hvm_console_init(void) static int xencons_info_pv_init(struct xencons_info *info, int vtermno) { + spin_lock_init(&info->ring_lock); info->evtchn = xen_start_info->console.domU.evtchn; /* GFN == MFN for PV guest */ info->intf = gfn_to_virt(xen_start_info->console.domU.mfn); @@ -318,6 +331,7 @@ static int xen_initial_domain_console_init(void) info = kzalloc(sizeof(struct xencons_info), GFP_KERNEL); if (!info) return -ENOMEM; + spin_lock_init(&info->ring_lock); } info->irq = bind_virq_to_irq(VIRQ_CONSOLE, 0, false); @@ -472,6 +486,7 @@ static int xencons_probe(struct xenbus_device *dev, info = kzalloc(sizeof(struct xencons_info), GFP_KERNEL); if (!info) return -ENOMEM; + spin_lock_init(&info->ring_lock); dev_set_drvdata(&dev->dev, info); info->xbdev = dev; info->vtermno = xenbus_devid_to_vtermno(devid); -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 15:23:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 15:23:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449952.707004 (Exim 4.92) (envelope-from ) id 1p0Ovk-0001aB-AD; Wed, 30 Nov 2022 15:23:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449952.707004; Wed, 30 Nov 2022 15:23:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Ovk-0001a4-7I; Wed, 30 Nov 2022 15:23:24 +0000 Received: by outflank-mailman (input) for mailman id 449952; Wed, 30 Nov 2022 15:23:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Ovi-0001Zy-4z for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 15:23:22 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2062a.outbound.protection.outlook.com [2a01:111:f400:fe5b::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eb5e2f33-70c2-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 16:23:20 +0100 (CET) Received: from MW4PR04CA0116.namprd04.prod.outlook.com (2603:10b6:303:83::31) by PH8PR12MB7159.namprd12.prod.outlook.com (2603:10b6:510:229::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 15:23:17 +0000 Received: from CO1NAM11FT038.eop-nam11.prod.protection.outlook.com (2603:10b6:303:83:cafe::ac) by MW4PR04CA0116.outlook.office365.com (2603:10b6:303:83::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Wed, 30 Nov 2022 15:23:17 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT038.mail.protection.outlook.com (10.13.174.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.17 via Frontend Transport; Wed, 30 Nov 2022 15:23:16 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 09:23:16 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 30 Nov 2022 09:23:15 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb5e2f33-70c2-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gIzyGvJb79n6F90RHYpA8cDBTZtOY9MBtREw5AddjMk0qgNiHrAxKYXoroxIIJE1tqdkkWsv5g+fjDm0ng6M2fMsFRyeDzOMj0ERqBqoj5P2yyExUHC09jC7aTW3SnBAq1gmgpjC8Vsnqu3chBoYushoJkCFbJIvzBE+ke5Sxl5xvz5HASVk6/uuWJ25M/Gq0suKZF3JgflZQM+y6wqggZTrweK+IIe9hpwGgQm6Y76Bat2ZRpzQZqlhzrrVPuV990OG/hRm3Oqr5UC2Vh1uqp3rRBxL7lPQzyCCgym20J+LJ7kOx6x6bm0bOGv5rB2/Zeb6DmsFHnhCJwjgAiHXSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/LZiTT/etiwKJz8NHGkNsH5Q2Ru8GDkp4OT0oxH0eIw=; b=B6s9Nfgpw9g31pLt27ZAbMDAcvaPDdUUJmbwBo2njuO2u6yg9uUjWlNSOJmizjtKAa2gT29GFIhRw9yjF9iTaxuGek7xYbTwU6wpMxeUkvdRhF7TiW8BLk7P0z+p6hyZ4ookWd3esDATh6NPN96eUfS9y/T+m8L9G7jAjZt/cqaKjNWV5QSRpmaHfqS1cbjcW0w+1lSU237GCDoQjcHDncKlmI1zU0dYcH2pSIp9twmMZ2SiyeLlbxrsmB8rcLy0enM7Xtyrmr7O7jhER8K6OdKEfoyW2pQneZIjy1IhWYLKcCR0c34LPgdG4O31b3JVFWHMKhjdZqapYUmg0fVPsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/LZiTT/etiwKJz8NHGkNsH5Q2Ru8GDkp4OT0oxH0eIw=; b=KT6ccQNrIgDHsGD+NvSD1S0t7c1w5Lh9GKF/0iGPaRx2V3YIbryEa3KGp2BT/YJPbVv6Eyg2Ja0t3cacvP/qjyZw7rGWKUnVh1gPLpWAIY5B8hND7Q5R3na/AKqviKJx7fm2giHKAgsvpSpf1ZKuQklpw7zftZZ9vXqBov5X8sw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <7310c943-4402-745e-c012-077f7c520c2a@amd.com> Date: Wed, 30 Nov 2022 16:23:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v5 3/3] automation: Add CI test jobs for Yocto Content-Language: en-US To: Bertrand Marquis CC: "xen-devel@lists.xenproject.org" , Doug Goldstein , Stefano Stabellini References: From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT038:EE_|PH8PR12MB7159:EE_ X-MS-Office365-Filtering-Correlation-Id: c142893c-6a2d-4780-4241-08dad2e6ce49 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K31A6+JRacld3zvqlwCFnaoKDuLj9DosWVTG3UHfnHZyJaJqbMfkFU7Itu+Bzy0YUYQunJXVAsRV9x6O8TsO8T0NSlB6IfMMLUaFmn37xnLMf22s+ZkTq5QTOt1wyvg0dpJRP3tZvnlclPygXnr13H5UFMjCme402fIzwzdAJ41xlz608xk9TB05Vt3rydlZ6R9gQLJlVxK8t4R153PH1F4Dx0mU+Cxzk/8tJybsdRmWBEF3xVAg699IiGI1XMHUq9DgMmaQSuBvUA+kByM/5fvffEBAPUa1jkbtbrwqoFIQOMIZDMrT+2afEm8xn5a8DLAHtUB/DnfFn0icN310vJv+s9CWYcO/c8qYZ95HhtJoJJHslSUmXZ3HqgBhMR6VC0dHInsCEUh9VSuF8/WWGEfnt7kLDm++hwM8vBZH4hdsDYI3d7mjLwb3fogRnvHBURPt/3lLnihWGOyRj9wlIJBHgD/4MvZhYH0tQ6KSRiw2hXNkzam7ngjYI0SmHv77Q9p7NCw3HsSOHgyE0fSMvbPFbe+BnaFJueCDm0I9XPtWHm7WdykI0yZVsbj9EBgNcAUCUZRDhYfEOw7uy9UHdUbNBtBCfHOrEPaso0NuYRPnR1hfAvYHNZhHTmRaE65NUMKxeTJ13WE9OyZgoCEkSyLYS3yDpiQcAOQOp0UPxnPLM3EoLquQ4iQLYfCJqMF3oKDCJ6aNwXUqTGFgzoeXefnYyq1r/zNTqUUIsu7vp1i3gu21sp39E3HRmUJBfmjEVs1L/8GaF0KKdGS+6FcCDw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199015)(46966006)(36840700001)(40470700004)(316002)(70586007)(478600001)(70206006)(2906002)(16576012)(81166007)(356005)(40460700003)(6916009)(54906003)(36756003)(336012)(36860700001)(82740400003)(426003)(53546011)(47076005)(26005)(82310400005)(40480700001)(2616005)(86362001)(31696002)(186003)(44832011)(5660300002)(41300700001)(8936002)(4326008)(31686004)(8676002)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 15:23:16.9846 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c142893c-6a2d-4780-4241-08dad2e6ce49 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT038.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7159 Hi Bertrand, On 30/11/2022 16:07, Bertrand Marquis wrote: > > > Hi Michal, > >> On 30 Nov 2022, at 13:02, Michal Orzel wrote: >> >> Hi Bertrand, >> >> On 30/11/2022 13:15, Bertrand Marquis wrote: >>> >>> >>> From: Michal Orzel >>> >>> Populate test jobs for Yocto based tests using the provided containers. >>> Due to the size restrictions, it is currently not possible to split the >>> build and run tasks, therefore everything is done in a single step. >>> >>> Test jobs for the supported Yocto targets are generic to avoid the >>> necessity to add new ones after each Yocto release. The only thing >>> required to be changed after updating the containers is the variable >>> YOCTO_VERSION stored in a .yocto-test template. >>> >>> Signed-off-by: Michal Orzel >>> --- >>> Changes in v5: >>> - none >>> Changes in v4: >>> - add .yocto-test for arm64 and x86 >>> - make yocto jobs use arm64 version >>> Changes in v3: >>> - patch added >>> --- >>> automation/gitlab-ci/test.yaml | 43 ++++++++++++++++++++++++++++++++++ >>> 1 file changed, 43 insertions(+) >>> >>> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml >>> index c7e0078e04f1..6ce2fd63eee6 100644 >>> --- a/automation/gitlab-ci/test.yaml >>> +++ b/automation/gitlab-ci/test.yaml >>> @@ -54,6 +54,33 @@ >>> tags: >>> - x86_64 >>> >>> +.yocto-test: >>> + extends: .test-jobs-common >>> + script: >>> + - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` ${YOCTO_BOARD} >>> + variables: >>> + YOCTO_VERSION: kirkstone >>> + CONTAINER: yocto:${YOCTO_VERSION}-${YOCTO_BOARD}-${YOCTO_HOST} >>> + artifacts: >>> + paths: >>> + - 'logs/*' >>> + when: always >>> + needs: [] >>> + >>> +.yocto-test-arm64: >>> + extends: .yocto-test >>> + variables: >>> + YOCTO_HOST: arm64v8 >>> + tags: >>> + - arm64 >>> + >>> +.yocto-test-x86-64: >>> + extends: .yocto-test >>> + variables: >>> + YOCTO_HOST: amd64 >>> + tags: >>> + - x86_64 >> This hidden job is not used by any yocto test job and as such can be misleading to others working on this file. >> So we can either remove it (can be easily reintroduced once we will find more x86 resources) or add a comment explaining why is it here. > > If I remove it then there is not reason to have something separated for arm64. > I will keep and add the following comment on top: > # This is not used by any test job as we only run Yocto on arm based machines > # Keep it here so that someone having x86 hardware can easily add jobs > > Would you be ok with that ? Yes, sure (+ add comma after end of sentence in multi line comments) > > Cheers > Bertrand > ~Michal From xen-devel-bounces@lists.xenproject.org Wed Nov 30 15:36:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 15:36:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449957.707015 (Exim 4.92) (envelope-from ) id 1p0P8K-0003IT-El; Wed, 30 Nov 2022 15:36:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449957.707015; Wed, 30 Nov 2022 15:36:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0P8K-0003IM-BL; Wed, 30 Nov 2022 15:36:24 +0000 Received: by outflank-mailman (input) for mailman id 449957; Wed, 30 Nov 2022 15:36:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0P8I-0003IG-Dk for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 15:36:22 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20626.outbound.protection.outlook.com [2a01:111:f400:fe1a::626]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bca3f97a-70c4-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 16:36:20 +0100 (CET) Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB8899.eurprd08.prod.outlook.com (2603:10a6:20b:5b6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Wed, 30 Nov 2022 15:36:18 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5880.008; Wed, 30 Nov 2022 15:36:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bca3f97a-70c4-11ed-8fd2-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kSoTiLcoIkt1NMCLEwtwt1lv4pKil5mTv96diNvMKFqSpUvEO6oVw+yNJtxDgAxk2RQXAKOvdNzF0l39mGlO4KoFCFVH3WgaEbiZc5kkYMUSzAoVzvpQ5kGo+eoEKNxA8xaMQMl2Swgmm6JSFrGq8dpJJr40aVIbZ+gJxCTo1CODm4tdOsnV/+AfqUo75zgaqr/8akrMUsNZ1rTfmuTOOifEGOOY/bxYVZ+qaqnHR2Bf9SV+ljN963pYIBKvwsNCPZFT9e1Hc+co2+ew3b4dalAbL+f0eM+GgSu83IWvoe73ph0SWTjUX3q8ozyg+vGFYICOPXSLEYiK3pk+9kkd6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bepxMMEEnDWs2olTHgnFgMjnFmMkMh2OKKHr5pkSSzM=; b=huBTy8jimj9cjb95EOhxgT3KMYHRctO+vCfOuNc3V0sBzo1vxaeTc9MVZHAW5x3IKbUufOhriE6Ppd7E4f6l+VWkeEH1zXwPqFw4TKBejvrUOjQlDmlRw6NrXD+iq7O8sh4VEk3fl6392u/PBCcAAkZw7EJGPC5GHFgeBiJWeE+Q8b3XmiHcyEk/9PSaujOfJbK1wbweZZLLlpDIiaukb3ASMw9g3XVMYKidwiInWHbBpRtOxp1fFu50GKg1dzvX5Q3aOWnjvbDxGQ7vrULptzuuaYXrHFYcwpmwuX/KLBcy6r1/RADMzkIOe7O+gn0dSPjHtyX9jYTvGx2yZcLxvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bepxMMEEnDWs2olTHgnFgMjnFmMkMh2OKKHr5pkSSzM=; b=yJYXKS01e5Ymw4KytnDIrlh95zcGuqnsskdnN8HL8TfSHHNqnVeyxRf4BMhEREHqDjpsNrSKR1b1s0SRcg+q73h58KR9PP+9SEdEoOq2iMpCEzgs9TVE2FAeqaO5nRD0rsEIH8QCORzPHGwL4UGsXEWxDHKmiLVPM/a2vzSVEkk= From: Bertrand Marquis To: Michal Orzel CC: "xen-devel@lists.xenproject.org" , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v5 3/3] automation: Add CI test jobs for Yocto Thread-Topic: [PATCH v5 3/3] automation: Add CI test jobs for Yocto Thread-Index: AQHZBLWHjw1n6cWydUSV320FMd2tla5XbqkAgAAi7oCAAARRAIAAA6UA Date: Wed, 30 Nov 2022 15:36:17 +0000 Message-ID: References: <7310c943-4402-745e-c012-077f7c520c2a@amd.com> In-Reply-To: <7310c943-4402-745e-c012-077f7c520c2a@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS8PR08MB8899:EE_ x-ms-office365-filtering-correlation-id: 1dde8047-276a-4756-e3e4-08dad2e89f76 nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9KKtdtKjdPNTYgzKT1RdASuSWYSHlfqSj58X/ap6ZkVdsKIbTu3dpMUqG4YFMfLWl88j7E5Ou9z0ekHlvJ3MT3oLHI1bPB2R3t3sycAWCASnCcxP9ZcqbPGzS6+qumXcostCvl3xneGkJgMp6nCqO1ECdeYyiRWgKuJxJCoLZBXJRftLUORSG5ZAFduzPh0/f7mxaMQnOFYcztf6mQOfzRZKsN+eV99II+ujxj2wxL8oKp7ltHPlgMKrFzBthu/Xrx0SVQW+UYrDz8GC4NA49LHK557QcEPTFLswmzCIebeQDWOO2zVSWGwKIM1RunbDxZTBlGpI+AqBcHneC5IZecEv0x094CfSQMXwB2ibXXGtYJ/1RInsuNbeiKmiH2voxWuDxLWBdDdTCo/g69iy/PusXjwjLwyaaVO+zNAW2R8S62sc3TeIwWPJOHwOr1s3P0KdcgRRZZQEPgwzGCA+Dc7lxJbUr/tfy7C19bv9M1PrmthC3VmD8EINYK95xKLcHg19iA/C0UzYGW6HhJ7JhDp1fZYsnfGSUzvj3tx/J2pd118u2pcYHyzXVD27s9XqotWsvy4kLG7SPa5Z057ByT6/s0gHF9AoSX5eQiWZ08ih6IIhIbZIunQ6vaRRj7y6eLPxL3iC0I7GYOh+K/UJdwxkWi8cBg7+yFaSEmvLRqzJGGJXJGl9B9dAJX9dptX6XZoZgLywAmruvMaMgLHcWf+YUrKfq0XTwHaqWtAaFuQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(366004)(451199015)(38070700005)(33656002)(36756003)(86362001)(6916009)(54906003)(316002)(6486002)(71200400001)(478600001)(91956017)(2906002)(66556008)(66476007)(76116006)(66946007)(64756008)(41300700001)(8676002)(5660300002)(66446008)(4326008)(8936002)(38100700002)(122000001)(6506007)(53546011)(26005)(6512007)(186003)(2616005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yG/L0XLrpzh3ZQ8rI1lwH/jhOcPY6o82gFZwz8KMckT8ota2221WOB50BO4a?= =?us-ascii?Q?ZKvHjpPuJf9WmR9qN6ieopzoJMHwU6gRcwS2rwAO1x7V+a2BpJoEP0tGGLbR?= =?us-ascii?Q?t44XjZmFYSuqv78DAB0mmqFSga9hIZP5hwSkNglIJ1+g1c+BMamdS70L6KmC?= =?us-ascii?Q?NVx/FIvzYijOvMJNd8cZPoaoVE6hAEeG1OCeK5SnInKnPqJ4GRfLfzZpZMHJ?= =?us-ascii?Q?lRe9evU4nMnn/MNxI27lecRQFDuGtVrlr2qRJeFVr2lt3FMTHIgqFVUuhPS6?= =?us-ascii?Q?15lI4w2R5Ib9PxfitFvwvvHj67gg8BlwYzNpfMiQKXaQocgjC2N0SiJdkuAQ?= =?us-ascii?Q?SeHnI93zGEZFEzkaNDTX4NOqKbWCFxciCEOsqwJrTGbYCfjib14/0KgkAGg8?= =?us-ascii?Q?aDHHgLQg1bImCZvb7WxR7U4NJiNpqgzP3No6M38/MTXx4RgFpUMX0fhM+Qn3?= =?us-ascii?Q?x2zAkyJC60DoD3jzWPDok3ZNqwPwLR3KsoV2kGrvHlBBqO75pGHW/rAXPEKH?= =?us-ascii?Q?O0MQylFvgc8H2ryFt0Jij4sPI71hy+MjHkBXaCw1RUYuPATiZC9gv3q6wvw8?= =?us-ascii?Q?eloob17US6BKcb9o3CMQ1egcw070aN8NdW5VQprewiwmovO2ZLVnc6qZ4L93?= =?us-ascii?Q?2gCbcjxofm8f86nM10DqWT3+aUo98tn5gHohkqpIxb9IakOybJ6hwHdWygz4?= =?us-ascii?Q?zw7uCseK7X38zwBGDerEvldrMsv5h3+fRJNqLuwy8LE74a4rAdzlE+vVsJYg?= =?us-ascii?Q?Tbid+d6BinIH5mEmGHoEtH97qTJT97h1cigBh5jCjbdCbBO5po89OB5zz1Ew?= =?us-ascii?Q?+LyGEZ1G0qGchYa+2HYUknvN3MfHiLATRbuAREa1KwKvC996can13zLCLXqz?= =?us-ascii?Q?0y6UWM9i8bs5qzNA29kSWnDcjWrkdnS/SbMR6U3uW9PEGBq+M/Fh9Gos9wSb?= =?us-ascii?Q?vg1BQFJPkoulEzRDt3rxO66Ad0W1dzP6p7PqRr8k4//C10nbENRUMLJeSP0e?= =?us-ascii?Q?Ij4VC/MkBzGTYuMaf0mPWnCQRMXlWlCeeCayqmmQ1XBryazAnLUwWlxSpMSi?= =?us-ascii?Q?KKRWgrNhMAryCYARD8TJR+LhdzMR29kEkaodnD4jJWZRIhuyfyC+xzVspK+/?= =?us-ascii?Q?lzpMN/hZ3jRwPPJRoUWP8MnL3lR1L2WEpBQw8z5wR3AefzN8vrUwsmU3vF2O?= =?us-ascii?Q?iERkQwwF2F7GAV4wJfemkwjJtBT4YvFVwmzeC7Z9/xwA95jbFTuz+IeDLaMP?= =?us-ascii?Q?bjbaJtBd24voomnR5RctvK/E7ibjMcPhcGBXI4tZ+4E2Qta7KoWqQvE27wiq?= =?us-ascii?Q?Wj8wlz79rqj6deyAuJegLpq1qaaR73AfPScnl2VlbZqBmGCo22QYLu5pcUK0?= =?us-ascii?Q?a+sazl4kMXuSqVne+ELcXc50UI9TW0KsmEfUI3fTfrv50tGVSkGa1+I1JkaF?= =?us-ascii?Q?aiw4vJEKHaMOKbkWHzR3hFtFQM5yK49dmBjMf0TdVKlWmEMZUIHaJTUxHG59?= =?us-ascii?Q?E0ZXl1xxZ3R0tjobJpMUA+OOmvNR5URPewZ2M/XTVq+MX/wwQ5fYYzvao/7e?= =?us-ascii?Q?JDP8Rg2Se1svUyiE5ilJc4dYbBwIJx747QpJkbChsJM6ssG38BLDmVqtLCw2?= =?us-ascii?Q?DA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <6A9A2FED89D51143869A2BA322F92540@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB3784.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1dde8047-276a-4756-e3e4-08dad2e89f76 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 15:36:17.5336 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: X+HwLURCvGmiEz+v53gP03fDlLN/hQisDtlN4Ygrz03jBoz3hsie09TcUF9FbDiatcLW8eOEGzNDcp0ujMVrNZHJ5voFmXukB46GSA9ng4U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8899 Hi Michal > On 30 Nov 2022, at 15:23, Michal Orzel wrote: >=20 > Hi Bertrand, >=20 > On 30/11/2022 16:07, Bertrand Marquis wrote: >>=20 >>=20 >> Hi Michal, >>=20 >>> On 30 Nov 2022, at 13:02, Michal Orzel wrote: >>>=20 >>> Hi Bertrand, >>>=20 >>> On 30/11/2022 13:15, Bertrand Marquis wrote: >>>>=20 >>>>=20 >>>> From: Michal Orzel >>>>=20 >>>> Populate test jobs for Yocto based tests using the provided containers= . >>>> Due to the size restrictions, it is currently not possible to split th= e >>>> build and run tasks, therefore everything is done in a single step. >>>>=20 >>>> Test jobs for the supported Yocto targets are generic to avoid the >>>> necessity to add new ones after each Yocto release. The only thing >>>> required to be changed after updating the containers is the variable >>>> YOCTO_VERSION stored in a .yocto-test template. >>>>=20 >>>> Signed-off-by: Michal Orzel >>>> --- >>>> Changes in v5: >>>> - none >>>> Changes in v4: >>>> - add .yocto-test for arm64 and x86 >>>> - make yocto jobs use arm64 version >>>> Changes in v3: >>>> - patch added >>>> --- >>>> automation/gitlab-ci/test.yaml | 43 ++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 43 insertions(+) >>>>=20 >>>> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/tes= t.yaml >>>> index c7e0078e04f1..6ce2fd63eee6 100644 >>>> --- a/automation/gitlab-ci/test.yaml >>>> +++ b/automation/gitlab-ci/test.yaml >>>> @@ -54,6 +54,33 @@ >>>> tags: >>>> - x86_64 >>>>=20 >>>> +.yocto-test: >>>> + extends: .test-jobs-common >>>> + script: >>>> + - ./automation/build/yocto/build-yocto.sh -v --log-dir=3D./logs -= -xen-dir=3D`pwd` ${YOCTO_BOARD} >>>> + variables: >>>> + YOCTO_VERSION: kirkstone >>>> + CONTAINER: yocto:${YOCTO_VERSION}-${YOCTO_BOARD}-${YOCTO_HOST} >>>> + artifacts: >>>> + paths: >>>> + - 'logs/*' >>>> + when: always >>>> + needs: [] >>>> + >>>> +.yocto-test-arm64: >>>> + extends: .yocto-test >>>> + variables: >>>> + YOCTO_HOST: arm64v8 >>>> + tags: >>>> + - arm64 >>>> + >>>> +.yocto-test-x86-64: >>>> + extends: .yocto-test >>>> + variables: >>>> + YOCTO_HOST: amd64 >>>> + tags: >>>> + - x86_64 >>> This hidden job is not used by any yocto test job and as such can be mi= sleading to others working on this file. >>> So we can either remove it (can be easily reintroduced once we will fin= d more x86 resources) or add a comment explaining why is it here. >>=20 >> If I remove it then there is not reason to have something separated for = arm64. >> I will keep and add the following comment on top: >> # This is not used by any test job as we only run Yocto on arm based mac= hines >> # Keep it here so that someone having x86 hardware can easily add jobs >>=20 >> Would you be ok with that ? > Yes, sure (+ add comma after end of sentence in multi line comments) Will do. Bertrand >=20 >>=20 >> Cheers >> Bertrand >>=20 > ~Michal >=20 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 15:40:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 15:40:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449963.707026 (Exim 4.92) (envelope-from ) id 1p0PBz-0004jO-36; Wed, 30 Nov 2022 15:40:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449963.707026; Wed, 30 Nov 2022 15:40:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0PBy-0004jH-W0; Wed, 30 Nov 2022 15:40:10 +0000 Received: by outflank-mailman (input) for mailman id 449963; Wed, 30 Nov 2022 15:40:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0PBy-0004jB-D3 for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 15:40:10 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on20613.outbound.protection.outlook.com [2a01:111:f400:7e8d::613]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44273ee9-70c5-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 16:40:08 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by DM6PR12MB4122.namprd12.prod.outlook.com (2603:10b6:5:214::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 15:40:05 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::62cc:47ae:a750:8f57%4]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 15:40:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44273ee9-70c5-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aA/4V+R096bOZw7VP6c6KTnvid8j2iOZXqGW/dAQdxRC1s3QM2ftb5z8MXETNS8YrCOx5VgIthmRthcVr8g4GTOPJKAhJl/Auv+sQnyJxupIGRezrwOYPj21HnQiQ4fLDskg8OcUQ9532e8p1Bi396Te+k48nEw4r1elyuCZaJM5tO42n/qJK8yAs7Phx+osv3bvIEjiu31jdzjlCZP1kps/WOGvViJv/Iguo+gq/XLI6z6Fg1VGJagFVCD2+TXjn8yXesZXSThN0dScLbGOCujHk47CcnaGolSZLbFs/h4awJVn1guPtS/RuscChlNL9pcoCURuE8/DfUE0h9MFlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VBPPbwHQ/BQhnGWLh/VK0JmYCz9NG3kdBrOefXvuwQs=; b=l7G0OCo7d//lRCaPY2TwWYmUM0DEBivegW8bB/z6PYv1D+vbt0sNTwOJc3m2USasb7k/omMla4prX1GKCf0+XPgwQnpaGTJht01wKyZiwPxXDmZ7na36EKEoQ+pdGaIdTfzBRaNzCwAlibkQTVwySyjUOCdcnsQkVd2J+0B6lLzbP0ZPLTbdFFcfWKHRRA9Tt9xTmIAc4OrExFqDeEwvjO58j2cOt8wYQm4RYwJCbucI0sEDemTdjfgQk+Eccd82FrMkDDsyoRg3vgQfn/nlqDqutLof/4PA8tumKbepi93L5qTKnYco3sPHT5uAkT8wJEN4tmXtturE6LQxgcumCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VBPPbwHQ/BQhnGWLh/VK0JmYCz9NG3kdBrOefXvuwQs=; b=c6VK0+nAt5OrsA1v1sqATv4925HLZsDBTJCJHlJr1fYq9tthicSPMaYyguCcMjXA4gusK8sq72Yb9HQm2XhMtkce29xgb/rMK3XpPn0WbjzOp+eGO18xKb3J+ZIr9IpH78peHnDZxpybuHv/zXPOdLL9oAOuxmF2ph+8D+Lz0gU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <4e84c85c-7e2f-38b1-a235-5323a77738e7@amd.com> Date: Wed, 30 Nov 2022 15:39:56 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Arm: AArch32: Need suggestions to support 32 bit physical addresses To: Andre Przywara , Jan Beulich Cc: Stefano Stabellini , "Stabellini, Stefano" , bertrand Marquis , "Volodymyr_Babchuk@epam.com" , Rahul Singh , Vladimir Murzin , Julien Grall , "xen-devel@lists.xenproject.org" References: <70651dbc-085d-706d-17d0-a419086a0700@amd.com> <65891843-db28-e5dd-6e9e-3fb003fcabc5@amd.com> <105a0d45-5b3d-7986-92c1-9a13eb803bd8@amd.com> <22d28805-8889-25e9-6d18-c868bf5e51bb@suse.com> <20221130131316.13ebf9d1@donnerap.cambridge.arm.com> From: Ayan Kumar Halder In-Reply-To: <20221130131316.13ebf9d1@donnerap.cambridge.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0226.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::15) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM6PR12MB4122:EE_ X-MS-Office365-Filtering-Correlation-Id: b1778186-3545-4291-16cd-08dad2e926d6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8Nu/T9ZdtKp8b58mQDV/Z+LkL8Uw3Cyj5WZCV5OTQq2UkGJBEmeREh+VpMuEOgjpIf5ihEVuBUWKFEHMZNzo2Th7bvNTRSUDIn89A+AoAXRiFfGvpvRXEOs+81Q+WZqX42dUVu/OxRmGYm6fE5+DHVxAyupg63E6CEhYotAgk47EGz2W68jARZVbYM4kdUHeuXUuJNA/pY2IEWKHAzJTkN7+ZvOzN+EgA92IOZ3lckkKIAi9L5RHqockBj5YjlbiSA9N46I5UcPIFAAFVAgZVYNqyID3XaeDseTPAJEl4IUAQ6FSp+eFyjHxPJlGATzoW39YZuWzSW6X14gTZp0pnQgT2dwea5O4PqV1n2aMDF4JEP0r/JyjTrXfpcpbaP+/uuff7VAWkOmiSzItSf17+9uVfNM+Ecv+w18bsNknOEjKVE6z/JGghx+pdC4elkkkqYQLQ2L7YC3G1hzSbff+V4EGCjkvUMaETeDSrXzAOzhRJP9FifvQBypWa74xJ0XVP+Ajb4L2K3623GvUuFXYwEYimD+UxCgLDKcbAOfHtzklHXefEGrxZnMHJVKM3GZh1lYVNrjABN9mujE2NwW/UF7hqZ5JREogW0eIuctGyjOZL0mmnczCT6uxFDO3F6PyOJqSoSztV4omUjMKL16v4gDudg4AtkKnv26WuxVWQNhqagSEms0ntxHlFxkQ/qVEuZNKdQ++m0ZLba+zzarFmwCFuaxiLJQsQ63ZwGPnWNk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(39860400002)(366004)(376002)(451199015)(6506007)(2906002)(31686004)(66899015)(66476007)(4326008)(66556008)(41300700001)(54906003)(186003)(36756003)(316002)(8676002)(110136005)(8936002)(5660300002)(478600001)(26005)(66946007)(6486002)(2616005)(6512007)(6666004)(31696002)(53546011)(38100700002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ry83T3hta2hsSjFCckpMR09IN3BkK3RLeFl3TDJoSmdjaU4xdStyeE1BSzFO?= =?utf-8?B?WjltQUUwRXlaVmhQd2ljdE1MQWp1R1RQcDRvU3ZCcmZvemxMVWx5Sk44aFdP?= =?utf-8?B?TTl2NVpZVHpaMTRoZFQrNzVTbCtBRjM5bHFBZjByK08rWXJuZHJsZlluRWI2?= =?utf-8?B?T0crUWpKVStxNks4aFdnZll1bDI0T2ZZZGp0UmU5eUlXaG1wYzRuZm9zeXFC?= =?utf-8?B?dDlMUmRPa05LcDZvYm1UYzhYQ3l2SXNENTZrTGpaZ2tIUTAxR1lZelp4YkJv?= =?utf-8?B?YlJOdWJhNzArcFBPdzNRNmN4Y2UzUlRtc056SGQ3bmNvTWQ5QVhpa1VyYjJ2?= =?utf-8?B?RDNqOWZOZVZKVlFkd1hxWTlWUDBMWXBQM3VNRzkzcGpyd1h5M09rb2RsdHho?= =?utf-8?B?cXBLc25HcTRBQWtaRThiTEtLbHNUSGRKS2F2M3I4YitwY3JidTB0MGUyNE1J?= =?utf-8?B?a1JHT3VHYTNQcktzdFdqSXBMMzhwU0RWMVpMbGFFVExhZFBqNG1GK0VTRXJk?= =?utf-8?B?Z2E2RWs5YjJyYWU2MDB1WXByNHc3UDFRTmpFSEROaURzQ3Y4dGtLSmhmVmtv?= =?utf-8?B?S0FsU0NKZWNBMC9HZEd5M0VyTFpPUHNqVkRzU3ZybGtOaEpoWGRpbE15aUc0?= =?utf-8?B?QUVTLzAwdC82ZVgyUWtzdHcrajJwcUJyZEh5QnVoUzVxNFlMMFU0S2VlL0tR?= =?utf-8?B?SzlVNkpLb2VoOE15UFZyKzcrYnZvazBzcEljMFhXZEFNYy80cUpiVnFkMzgv?= =?utf-8?B?OVhtYUhRQkw3eW56VmJSRnQrenN0K1l4aklxUjk5NVdHTmE1SHdTRnFuRmpz?= =?utf-8?B?cDNvU1JEblhXZUFjNEhwa3J1R0draTliZU9MWWtDdU9EN1hjRjhwbzhjZ0xu?= =?utf-8?B?R1UxUDNWVms3eDZUb1Z5ZWcwdTBpRWR1MjB5dWdOREt5a1VqbndlSW95S1FP?= =?utf-8?B?Q3dYUUE4bGdVVnF4MGRiZUVUN09iV25JL2V1cnFLT0dWdW52SU4yZGRGdVpK?= =?utf-8?B?c2R3QmNEV1lvN1hRaVE3S1phRkI2NXYrZWFTRTI0RU5QUUlJaEZkeE9sMDQy?= =?utf-8?B?eEp3RG1EckN5dE5RQ2ZuZHZwK1FkYlNwWHhHZjdmR0xmUkRBcHMwM0lCUjRI?= =?utf-8?B?aDkxbEk3VllFN1JtRk1RZkYwR2dhRkxlSExyY0loNFdHVEFCb1c3SzRGRHRH?= =?utf-8?B?cXBjYVdJVWhDM2tQQnUxclpkNTNrOG1UZjl4aTVHOVZSNmVuSTM0WGFiSy9F?= =?utf-8?B?VnR4bDFoVWYxZnZWTGNFUDF6Vm0xQ3VUQkkvb0xHUk5UWGxFTUdNWEg4THMv?= =?utf-8?B?ZElqam52WkFWdzRjQ3dyRUJoWjhQcGhUWTUxYVpLTzJ4UnliazBreWpDU0pN?= =?utf-8?B?bWwwa3pjSVpoandGS0hZT1hWM3F0NzluVU1SNjFwRXJLY2VpYnRHbW8yS2Fy?= =?utf-8?B?YTdGZ3Vaa0YyYlFtbkhaK1h3ZVdwRzlnUXI0ek80YzE1ekhYNC9ya0NTcHQ5?= =?utf-8?B?MVowK1I2aktyYWRjNnh1ZnBGZUdGMXhYNllRaEZiQ0JYSHpqTUxGTGgwMnFw?= =?utf-8?B?bDRjaTl2UGplWTUxTGpPYnB2a1hXeDVSTkhrejJvSVhObFJoUzM0VS9VSXVm?= =?utf-8?B?NnVDT3pieXFvY05MNXg0d05PYThDRTJVMWFrS3UyOTJGRjRGS05TSHNZOERx?= =?utf-8?B?dUJGOVpjWUJMU2lxVUh3QkU1aCtaL2t0QzNtdGdWVG1KRVZkeXNKL3RrczhR?= =?utf-8?B?OU84Z3VWV2lWWENJMkNMR2twd3BMRHp5L2pvVmtoZFB5ckVFdVVYMmxKWXZQ?= =?utf-8?B?NmtPU0U2QmlHRWRLMVA5elF5eGdMNkV6eXJiUyt4QnZyaXRxYXoyckdhWlQx?= =?utf-8?B?NlRRbzZuenpqZFJocWpxQnZDSDUzWHJnMUVNQzJIaGhGN3hMSlg4NnVKREhl?= =?utf-8?B?VnBCOGJ0cVRUcTRGaExUeGZRZlluYVFhek9Ha0sxYzVhSk5oR25UeGg2RnRT?= =?utf-8?B?ZTJFTGd3N2NnQ3Y2bXc3WFB0SnIwSXJOUmNRWVl2OTFwSnAzRzFOYTZSZnUz?= =?utf-8?B?QTZqS1pnVm8yRkh5NTkzRXlDUkhMY2plbytrL0c0cHMybWhKZ1JkeTNwbHJz?= =?utf-8?Q?KGhT1vQS+BM/SlHdNclM4Lfp+?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1778186-3545-4291-16cd-08dad2e926d6 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 15:40:04.8999 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 04p0IdkmzzaAGXyJ+cQEDvqgJ3L5MQFINjWaSEYzN9LFvz52spazchQCUj9/BlPqc39DY1cnYQzzzfsov+21/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4122 On 30/11/2022 13:13, Andre Przywara wrote: > On Wed, 30 Nov 2022 08:09:53 +0100 > Jan Beulich wrote: > > Hi Ayan, Hi Andre, > >> On 29.11.2022 19:18, Ayan Kumar Halder wrote: >>> On 29/11/2022 15:52, Julien Grall wrote: >>>> On 29/11/2022 16:23, Ayan Kumar Halder wrote: >>>>> On 29/11/2022 14:52, Julien Grall wrote: >>>>>> On 29/11/2022 14:57, Ayan Kumar Halder wrote: >>>>> --- a/xen/common/page_alloc.c >>>>> +++ b/xen/common/page_alloc.c >>>>> @@ -2245,7 +2245,9 @@ void __init xenheap_max_mfn(unsigned long mfn) >>>>>   { >>>>>       ASSERT(!first_node_initialised); >>>>>       ASSERT(!xenheap_bits); >>>>> +#ifndef CONFIG_AARCH32_V8R >>>>>       BUILD_BUG_ON(PADDR_BITS >= BITS_PER_LONG); >>>>> +#endif >>>> BUILD_BUG_ON() are used to indicate that the code would fall over the >>>> check pass. I can't find the justification for this change in the >>>> commit message. >>> I had a look at the following commit which introduced this, but I >>> couldn't get the explaination for this. >>> >>> commit 88e3ed61642bb393458acc7a9bd2f96edc337190 >>> Author: Jan Beulich >>> Date:   Tue Sep 1 14:02:57 2015 +0200 >>> >>> @Jan :- Do you know why BUILD_BUG_ON() was introduced ? >> You've cut too much context - the next line explains this all by itself, >> I think: >> >>     xenheap_bits = min(flsl(mfn + 1) - 1 + PAGE_SHIFT, PADDR_BITS); >> >> Clearly addresses used for the Xen heap need to be representable in an >> unsigned long (which we assume to be the same size as void *). > So I am wondering why you hit that code for your port in the first case? > If you check, then ARM32 won't pass this, because PADDR_BITS is 40, while > a long is still 32 bits. But, PADDR_BITS should be equal to 32 for R52. Refer Cortex R52 TRM, Section 2.2.12 "Memory Model" "...This is because the physical address is always the same as the  virtual address...The virtual and physical address can be treated as  synonyms for Cortex-R52." From this, I understood that as virtual address is 32 bits for AArch32, so physical address will also be 32 bits. Please correct me if I am misunderstanding ? If this is correct, then ... > So digging deeper this is code for the case when we want to map the entire > physical memory into Xen (the Xen heap, or direct map in Linux terms). > Which we cannot do for ARM32, and that's why the code is protected by > !CONFIG_SEPARATE_XENHEAP, which is forced to 1 for CONFIG_ARM_32 (in a > hacked up way, btw). we can map entire physical memory into Xen as VA == PA. - Ayan > > So I think you must just force the same thing for your port, then this > code will never be compiled. > > Does that make sense? > > Cheers, > Andre > >> But I'm afraid there's further context missing for your question: Why >> would that construct be a problem in your case? Is it just that you'd >> need it to be > rather than the >= that's used presently? If so, why >> do you add an #ifdef rather than dealing with the (apparent) off-by-1? >> (I say "apparent" because I haven't checked whether the >= is really >> depended upon anywhere.) >> >> Jan From xen-devel-bounces@lists.xenproject.org Wed Nov 30 15:49:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 15:49:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449969.707036 (Exim 4.92) (envelope-from ) id 1p0PKf-0005cZ-VT; Wed, 30 Nov 2022 15:49:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449969.707036; Wed, 30 Nov 2022 15:49:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0PKf-0005cS-Sm; Wed, 30 Nov 2022 15:49:09 +0000 Received: by outflank-mailman (input) for mailman id 449969; Wed, 30 Nov 2022 15:49:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0PKf-0005cM-0x for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 15:49:09 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 828bb275-70c6-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 16:49:06 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 828bb275-70c6-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669823346; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=L/pergYOW0+Pg6MTUynuvlmE5E/HZqjlLKr/hQOnzTE=; b=XGJ9SFsbsvWN1Ew5lpefXHsMQ9YBFqXcd0rMfFMBKs/1AzDhycqFXIGP k/uf5bIvk2KUe/jbaWh+EbPMJnQO2Ws78VKN//zpE5dRFFgovCnHA6NQR 7y5llYbmdiFSHnvdWpuC8F1Gh51YG7t3Ji/IEzwfuNDICTpfBBA52FXEt Q=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 88405427 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:mIRASqgH2WPbhb2ugpUoO9LhX161thAKZh0ujC45NGQN5FlHY01je htvUGmAb/zZa2f8eIwibt7i90pTvJPSyt5gTFdlqHtgFSIb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QSGzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ9EBsdPg2siN6y55TgZcJBjfg+LeTCadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglH2dSFYr1SE47I6+WHJwCR60aT3McqTcduPLSlQthbI+ jqboz6mav0cHNyR7iqk+EyCusT0h2DxWr8XSbGj7+E/1TV/wURMUUZLBDNXu8KRgUekV9VSA 0cd4CYpoO4580nDZsLmQxSyrXqAvxgdc9ldCes37EeK0KW8ywOYDWgNSnhGcs4rsOc/QDBs3 ViM9/vjCCZzqrSTRTSY/62NsDKpESEPKCkJYipsZRsI5ZzvrZ8+ijrLT81/C+ilg9vtAzbyz juW6i8kiN0uYdUjjvvhuwqd2nT1+8aPHlVdChjrsnyNyztSdN64SIOU7X/9ttlrAY2lU1isl S1R8ySB19wmAZaInS2LZewCGrC1+vqIWAHhbU5T84oJrGr0pSP6FWxEyHQnfRoybJ5YEdP8S BWL0T698qO/K5dDgUVfR4uqQ/onwqH7fTgOfqCFN4EeCnSdmeLuwc2PWaJy9zq1+KTPuftlU Xt+TSpLJShyNEif5GDqL9rxKJdyrszE+UvdRIrg0zOs2qeEaXieRN8taQXQP79lsv3Z/lmJr b6z0vdmLT0FCIUShQGOoeYuwa0idyBnVfgaVeQIHgJ8HuaWMD54UKKAqV/QU4dkg75Uho/1E oKVAydlJK7ErSSfc22iMykzAI4DqL4j9RrXywRwZwf3s5XiCK7zhJoim2wfJ+Z/qbI7naUoE 5HouayoW5xyd9gOwBxFBbGVkWCoXEnz7e5SF0JJuAQCQqM= IronPort-HdrOrdr: A9a23:XfQfjK7MH/kOq6Mk/wPXwY2BI+orL9Y04lQ7vn2ZKCYlB/Bw8v rE8sjzuiWVtN9vYgBdpTntAsi9qBDnhO1ICPcqTNWftWDd0QPDEGgI1/qA/9SPIVyaygZXvZ 0QDJSXYLfLYWST5qzBjzVR3LwbreWvweSQoaP78l8odAdtbshbnnVE4sTwKDwJeOGDb6BJZK Z1I6B81kudkA8sH6CGL0hAZfHHu9rI0Lr+eHc9dmcawTjLtyqs9Ln5VzOF3hISOgk/vIsKwC z+ignk4afmlPm+xnbnpgjuxqUTosLl1txAQOqTjcQPQw+c7DqAVcBaQrifuzJwmsGDgWxa6O XkklMbJsFu7HGURG2vvhf3/AHl3F8VmgTf4G7du2Lnvcv6AA03ENBAg4UxSGqi13Yd X-IronPort-AV: E=Sophos;i="5.96,206,1665460800"; d="scan'208";a="88405427" Date: Wed, 30 Nov 2022 15:48:32 +0000 From: Anthony PERARD To: Bertrand Marquis CC: , , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v5 2/3] automation: Add a clean rule for containers Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Wed, Nov 30, 2022 at 12:15:08PM +0000, Bertrand Marquis wrote: > --- a/automation/build/Makefile > +++ b/automation/build/Makefile > @@ -28,3 +28,13 @@ all: $(CONTAINERS) > clean: > rm -f yocto/*.dockerfiles > > +define CLEAN_RULE > +.PHONY: clean-$(1) > +clean-$(1): > +ifneq ($$(shell docker image ls -q $(REGISTRY)/$(subst /,:,$(1))),) Please, don't use "ifneq" in a rule's recipe, especially when running a shell command. That shell command is evaluated every time make parse the makefile, so we are going to run `docker image ls` 23 times! Just write the call to `docker image ls` and evaluate the result in shell. I guess something like: [ "$(docker image ls -q ...)" ] && docker image rm ... Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Nov 30 15:53:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 15:53:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449974.707048 (Exim 4.92) (envelope-from ) id 1p0POy-0007Ep-HW; Wed, 30 Nov 2022 15:53:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449974.707048; Wed, 30 Nov 2022 15:53:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0POy-0007Ei-Cv; Wed, 30 Nov 2022 15:53:36 +0000 Received: by outflank-mailman (input) for mailman id 449974; Wed, 30 Nov 2022 15:53:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0POw-0007Ea-LH for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 15:53:34 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2394b3a7-70c7-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 16:53:33 +0100 (CET) Received: from mail-co1nam11lp2174.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Nov 2022 10:53:29 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BLAPR03MB5540.namprd03.prod.outlook.com (2603:10b6:208:296::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 15:53:27 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%9]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 15:53:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2394b3a7-70c7-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669823613; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=a7N9wPMOMr2sNCn2rA2lvjvQIPVeaiEtt+iCAfSNPZs=; b=WUgSP2gN6G1VdeYFSf4yIPDesGsazV8dZHKXtt/fU/AnpKFMogovUpL9 p+QQAekXNRtqZNduvaBNjbeb2SuaigrXoJA/F81OB5XgQUPF4TABhITXJ veFGGXY1Uf6zuAFSW0zg6KGntJmDfeuIco6bPzp4xH4tnRt9yK2AOLEc9 s=; X-IronPort-RemoteIP: 104.47.56.174 X-IronPort-MID: 85872101 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:B76eHKOSO309ESnvrR1kl8FynXyQoLVcMsEvi/4bfWQNrUoh3mFRx 2QeXWHXPKvcZzahfdB0bIm29EMBusfXzIBlHQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5QRmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vwqAkxfr dw5FBoiVw2pgOOph5iFdOY506zPLOGzVG8ekldJ6GiASN0BGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PRxujePpOBy+OGF3N79YNuFSN8Thk+Fj mnH4374ElcRM9n3JT+toi/82bWWxXqTtIQ6D6eZ6P10sU2qlzZPBTYPEmn8k/rghRvrMz5YA wlOksY0loA+/VKmCNn0WQa1plaFuAIRX5xbFOhSwAWMzLfEpgWUHG4JShZfZ9E88sw7Xzon0 hmOhdyBLSxitviZRGyQ8p+QrCiuIm4FIGkafygGQAAZpd75r+kbjB3VSc14OLWoldCzEjb1q xiAqzI/nPMUltIR0Lug/kHvhCilrZzECAUy423/Qm2h/it9ZYi4e5av71nLq/pNRK6cT1+Ou 1AelsSe5fxIBpaI/ASHWM0EGLCk4abDPDC0qVJmAZRn9z2r4HOlVYRR5ixuYkZvLssAPzTuZ Sf7qVMPzJxeJn2naelweY3ZI8QyxIDyBMjiTLbfad8mSoJ4egaK+AltaFSW0mSrl1Ij+Yk7N JGRWcWhF3AXDeJg1jXeb+4W0b4iwC8WxXuVTpf+pzy53LydbWKYUrdDKFKKauEh5a+FiATT7 9tbccCNzn13VOz4fzmS+IULLHgUInUhQ5P7scpacqiEOAUOJY06I/rYwLdkcIs8ma1Qz77M5 ivkBRMez0fjj3raLwnMcmpkdL7kQZd4qzQ8IDAoOlGrnXMkZO5D8ZsiSnf+RpF/nMQL8BK+Z 6BtlxmoahiXdgn6xg== IronPort-HdrOrdr: A9a23:GYpfFq6pKb8Fuyy+BQPXwMbXdLJyesId70hD6qkRc3Bom6mj/P xG88516faZslgssRMb+exoSZPgfZq0z/cci+Qs1NyZLWrbUQWTXeRfxLqn7zr8GzDvss5xvJ 0QF5SW0eeAb2RHsQ== X-IronPort-AV: E=Sophos;i="5.96,206,1665460800"; d="scan'208";a="85872101" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BYRErKLL23Yh6x27XuVYhgl3YEym+OZQjffwMqkR+usgtV+v88RxFT6fne8Aq6ZalGdsXBWIt39KwNXfbaaCNuDWa7seteRJ4A0ZqthCtkZFR276dMo3cn07YBM8kOc2KQct3xlcwjdJmVJw9+XBpK+3oh0apO/po8aONuDF05MqCPhCMHhdefrmA7EVeNxKly8LFeLGAtOcL9qbmL7KiZJtMz8YWK8WGxeJgYfNVqBdS+S2VTPntHt2b5WiANQXLM8+YSQYHreeeVbKqguVgfHJRcNOuWSYFuYKrjYpzew7YXUv69Q7tnboOHoS5ZYYANHyypIj9qco2a57W9UcbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZYrjI+mj72gHPgjYoTrTatGSS29LclN24rgtT/SiE08=; b=fhTJgSTl4/KtHqPjFEXh+a4uldxoN/rRtU9k3M1YB+Y7WOZIYuK1hBA3hmiP5I0g5wnpi4JeMGLBp1k1nLygAzQfH2aKwtxxP+t5fVvEACTgWj7nNJxDgJOqZLx+xM2/WtyLWIGwBVGi3jCxHBTlvdcfl5iBV+EDqDoqPAJ/+y/qYJlY3iPhcVy4nOIu7yIvGEqkASRgBcA/zULYgqu/5JfdzmWyzJZKIlEQOybMq3DmxM7dFqjUAeKxW3Ex0dAVc/8YH/B1kxPK3ywpnXUbItoO/KsTws//Cz9BGDDd3BOrF3BYf0uONSHOo2XcqL44re/gupsuLBu85dcuUx/b2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZYrjI+mj72gHPgjYoTrTatGSS29LclN24rgtT/SiE08=; b=ECQI5/zCvF5VS3jYOVGHyO+KvYlASrJpl2WTuSr4DI62j+1LWNlEdPYEOcnoNraURGQLR17UgW80A5R0mzYBcIMHRMFRF8z1NTKkW19GOQcbnQIFwoIqQS/gc3p7cwhgXKj3ct48TXbh5/nMN/Zi/wtG+f/Poeec5Ro6U+xus3I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 30 Nov 2022 16:53:22 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Dave Hansen Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, jgross@suse.com, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Alex Chiang , Venkatesh Pallipadi , linux-acpi@vger.kernel.org Subject: Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0 Message-ID: References: <20221121102113.41893-1-roger.pau@citrix.com> <20221121102113.41893-2-roger.pau@citrix.com> <6b212148-4e3f-3ef6-7922-901175746d44@intel.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6b212148-4e3f-3ef6-7922-901175746d44@intel.com> X-ClientProxiedBy: LO2P265CA0075.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::15) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BLAPR03MB5540:EE_ X-MS-Office365-Filtering-Correlation-Id: 50ffce67-8271-416d-6ffa-08dad2eb04fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wg0a4rL1NK6t3duO2rCnIsuAvfLQj71zFWm6Q/O0wrvlAlYsTrWhPa3TK4GPfJ2xuOyaSayZnNanFW0vAB+/XvJdOm9V35hQl1p9yiB/tCefc8y8P9vGREODDLYFgwm2UFQFU5UBgM5W5rRaW4oS8PpG7c+y7cMvfoNXK+c9hZmow+aL5BaDxIrtLVZtEc6Eu0m+A6sziRisgPacj91ag3Zpb0EXYtQjINrNCfXRXv5Ud4p0YOtyUF2HtcqpCstGCnkJnbpyvaxC0lM98QDcF2xzW9Df3hIe5WnCx0SBUBJqJ7zGd26oCO8HffPEfqW5lsIDmLCUuCLuEWbABbp/166jjvPTHF1j+nN0tbmmTe+jRD7IaPutFWMHM6Do4oRZXgJZbBa5cu/sfI+AHT+JoDOXv4zFqsakjJ4AUiiLVYP9euPy4DFWJsn3uHJgD190UHROJOwC9g19u4Jtp2O1StwBXfAD4IRUp3/lGMl4tVkQgA6zGx0YG3uNb8yfGjoXZsrCkDfuoFAOFurbdXIZjDukINM2XQNEljW1bq6qrCKO8b+XBh536+uIUwAKLKBVAZmQ8DrgBXKYIaafm39MeE06iN9ShjIapyJeIUoiDWzzGJd6kQ8NLjUFpSTa7qyxy/ULdQnH0LLL/BVKIWVpYg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(376002)(39860400002)(396003)(346002)(366004)(451199015)(33716001)(85182001)(66476007)(6506007)(53546011)(66946007)(186003)(6512007)(8676002)(8936002)(4326008)(316002)(41300700001)(478600001)(86362001)(6666004)(6486002)(66556008)(6916009)(9686003)(7416002)(26005)(83380400001)(2906002)(5660300002)(54906003)(82960400001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDdRd2NtZnJybnRKTC9aRWpORENwdXMxUTVkN0JEWlRYd2l0OEtURUlmUHhS?= =?utf-8?B?aDd0Q3R2eFlQUVlPT3dQdHJtZjcySWZZMG5LRlVJQmlGYSt4aC9xTGlZQUFR?= =?utf-8?B?d3Z2b1o5aW55NHdwR3d3R2V0T3VRTGlLeXVjSFFEaEhHSG1KMDkwaTdyNkp4?= =?utf-8?B?SjYxaVRiTW5qRDA3eGZTY3hTVDB4QW1GZkYyclZBZndYc2NmWGpJTjBMZ1hY?= =?utf-8?B?MG9OMzFlLzhQeHhIMWZ6cHJCODZsam9oWkNlencyUHZNZ0lBNmVTWDEyU3k5?= =?utf-8?B?ekRjMDlzV0NraC9FSzJMek5KRUdpNnZkOWhuTlhtaE5BbldxYXhOMCtpNWJ5?= =?utf-8?B?ZEhvRTBkK3pHb1lrYmpLZUZmSUN5ejA2ZFpRZFFrUjFLUWQyVVhINkplNVJu?= =?utf-8?B?R1ErUURYN1R6amdEekpLTEo2b0JiTHFVbHdicENabnEwRDByYWVoRWpyYlJJ?= =?utf-8?B?NEFaZEZUZVh6OG5jWW42anAraG1IN1NTVHZUOStQN21iU1RJamJFUnFEcllr?= =?utf-8?B?djY5YjNYakZ1RVhHaG5tNlVQZmRSNERrU1ZhazQvSUVYSGhPTWhBb3JneC9Q?= =?utf-8?B?QjNGSmJHRWt6L24xWW5NUTh2SG1JSGJFZ3MrK1BCalpDK3N6WGV6czdvbVFS?= =?utf-8?B?NElTa2Z5UmpMZllBVDFYZ0x2ZVZzZVZpYzVsQ2xJOFlZLzhyaGUyblZNdkt1?= =?utf-8?B?ZjFhZ3ZIbTk5K3dYSUVQWUM1WDVSeUx0RDlNODBNUnAzMVhqcDhteEkralFH?= =?utf-8?B?K0hXR3I4eG1pc0ZKc3NaYXVYdEJDbWZyMjFmNmVhMVFjN0dlNUZWeGhxZFhw?= =?utf-8?B?eWxjZkFpaG8zSGpPQlFVcHBhZW52SitQYXpuaTVkTDMxc1VYLzRPQlVQcGpw?= =?utf-8?B?aHJUcUxCbzNFOUVXbVRucnQ3MEdReU1LSHR0TWxFRjh6eHBzY1YxUGViMVgy?= =?utf-8?B?SnkrSXllRnA1OWFMbXlZd1Zicm9senVhNTgxcWlhRDNTSXhMS2JLaU54LzlJ?= =?utf-8?B?SWM1MVVKZjlFcG5sV0N6Ly9POHhsSGxqakFYZEZ0THdoNEx2YXpvRTBjVTY2?= =?utf-8?B?WmR1T2c5dWVVaFI4c3YxVytJU3lyUEtmelBGTXpnUVJKVW5RZ2tSVDRReEpx?= =?utf-8?B?NlFHMEpkRnY4MGl3MjlsU09MZzd1czZOdTlUcmpFY0V6cjZRODdES1ZrdTJY?= =?utf-8?B?ZWI4QmVQSVhjMFhXMk4xZ1htaG5ManpmN2VTMkk1ekxMbnp3UUpRNk5nWlNk?= =?utf-8?B?M3NoS0szWEZRYnQ1cmduM05TeXJNVEY4M0N1eVRzM3NMbExsbmJLZXEwYjVH?= =?utf-8?B?MTBDclFGeFNMZ1lGUTJZZVZReXZPNFhuY2lOYy94RmFCL0xrVUc1djBaUmli?= =?utf-8?B?NlYrM3FyRi9MeFEveVhOdzFaQ3B0aHBCblJVSnlWL2FaUHpmcUNxUEpUSWV5?= =?utf-8?B?dTVzMEdpeFd5Yi90UW9RTVJHOTllbXdSdFEvMzRidUxOd2dma0NmT1ZrOWl3?= =?utf-8?B?ZXZOMXNQcDViM1J2bzZOUUh1VzRZRFZrM3FOTkc0ZmZ1U2syWWVseGJHVXFD?= =?utf-8?B?dzVYcVJVSnVSejBRVnJMMUNjcDVUOWRZUHZEZ2RRVHJZc09LK1ptN3hPbDRj?= =?utf-8?B?cDhGSWhRWG9iZjloZGNKQUpLNEZzTm44SEs2anhiZjhpTjlkOURUS2JxalpJ?= =?utf-8?B?aW5iK2VyeHR4cnozWGxQQkgvU1BGVFpCbWxEYTdxVkpLeTVzMkxqczdKV0Vo?= =?utf-8?B?NWJRcEcvRkRCSDVqcXJnTkhPRVhjOU0yb0t5Rmo2V0dIT0Z2SmIyb1hzMjBI?= =?utf-8?B?S3lxNUJuSklld01ia01kaUE1bHk1c05OQXB6SWFYUmFpUUtHM2ZjL2Jvd1NO?= =?utf-8?B?V3JjZ1RTWVlSZklsSXVLVmE0WEJNa3ArQ09HUFNBcDFnY1JoR29aTWNzbUhq?= =?utf-8?B?QkwwcHA5Zm5aQ0p1elRYY1d5YlhvcE1wVDd6VWcwalQ4VnNaOWo0M3k5dUxR?= =?utf-8?B?eHZ1bTJRZ2J2RTliclJLTDlIOTNaTExnZUJBZngxbVpuYStaRlhSSFBkQXYy?= =?utf-8?B?WVJVOEJGaFNiUEZ1bU1ObThSUW1LVkxYdHVwajZPam1QU0lJVXBnV1VxSUcx?= =?utf-8?Q?yCCahd+4j0NzCObp/BuVT6Bb3?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?UnEzTkFENDhTLzduZFBsZ0g4Y2lOdFRlZVZraTNrVlBXWUljMElHOXM0N3RP?= =?utf-8?B?eFNRTCtGUFgvVTEzTkcvTlRCcjZ6dklkYmZiQ1Q3UGhGTzRCUWVjVHYyMDNB?= =?utf-8?B?cHM4R3ZPK2xKQkNLU0UwL0VUVDRYTWt5MUEyTStLd250OGRGU0JJRVpUcnJR?= =?utf-8?B?SFJWRlc0QThpQ21iWStzRHlCS3FHVEtuU2x2S2JJRVJOb2M5WTl6L2ZReFpW?= =?utf-8?B?ekIvSk5ka0tpbStIQU5Ebk9zeEI1aGZjSFM2T0s0UXV3eXRTTGovalNRL1F5?= =?utf-8?B?bmJpSTlXNFRjYnUvZWdQWHQzcDBZVlpiRFAwQjJZOXBuTG1QRjQ1V0hpZjNu?= =?utf-8?B?QnYxNVhLcmVYT3VBT0FGL1lxRTZJZ1Z5NTI1UG8vTncvN0JZSFFqcmsxeG9W?= =?utf-8?B?blJJVXNHRTcrSWRiYWVhZVlsVnlpNVFUQlhxaVFBTGVBMThsbUdIbzFMbWlk?= =?utf-8?B?WTdFSkpvUktpR2hxTVpUOEx3NGNLVE1aVkNsUTFnZjY2ZGR4b2wrQWVQSGY5?= =?utf-8?B?MW42VXNkdlFNM3hUMENIeEpRS0Zzb0ZYMUtlL3VqSkk5ZjdhWmwrazBFWFpQ?= =?utf-8?B?R1JRd0FyVEVpa0g5RVpSbmZ2SDVjTjJPYnRBak5jUHVkWUxNNkdoRWNDd2xC?= =?utf-8?B?bGFzcDM0c2xIY0NnSFVESWZnbXZNbW1QY3V3aFd6bytuc3BhanMxOWxiYVFN?= =?utf-8?B?MUNpK1R2ZXBWNHdmV2hsT2NwbHVzOVBuTk02bWF3eExtUG9ITFIzVE5Xazlk?= =?utf-8?B?Y1VKNy9GS0F5bkZCMVAzenZLU1pXMWZTVUV4UXYwVEdjY2hKUGFNWmgwV25T?= =?utf-8?B?NFRvUTAveUNGVUJ2ZlcvemNwN2QyMG1YdWxzeGJTTmNiQ0JTNEpZWW9VeHhq?= =?utf-8?B?d2ZPWm9NVDBiT2l1LzNTdVhZSjZYZVlvYjljTnJwSDJsSXpwdVJpSXQ2MytW?= =?utf-8?B?RTJ3T2VzdlZybG02OVh4UUJzUmFLaTA5a2xqWm1RYmRjN3c4QXR6NU1wdnJ0?= =?utf-8?B?YUY3NUNIaFFyVGk2Z3V4M3hQN3NnY1NxbzdjbFlyS0h2eTJpTHV2QVZLK284?= =?utf-8?B?K1NHSXRxTkluYmhha29MYkk3SElvV1ppZGk3OTJCUFU2RGxMdnNNQXlVSmc5?= =?utf-8?B?djVjNzRTa0luUkdBUFVvRzlBY3dYbzlvTFJjQ29iL3RkcU5tclpya012WDhN?= =?utf-8?B?SVJvZHVWSGZ6T3ZDQ3VtUGUwY3NrbUE5WEtjakwvbDc3R2dlUG5WbGhtLzVW?= =?utf-8?B?dWNBQ2NRRmpsdTFRajdKN2lXOHRYOStIVmJBU1VxU1h1dnBOTldiMllxY3pW?= =?utf-8?B?OWhRNXAxOUljM1NabXpsZmVDa1BYUFl4ZTlmTEZjVncrYStrNEtjclJhYXJ4?= =?utf-8?B?aEg4NjRVVUdIUGwyWFhiMW9DNlVVNnl3ZnBWcTRFZ284eGNOVWNlSWEraS9r?= =?utf-8?B?MHZMZUszbk51K3V5TzdDZG50SnpaOVp4ZStZNGVwZXN0NnY1djFUVGFKWVBU?= =?utf-8?B?bEF6dUoxdW42NjRDRUtRZVZoNnE3Q1RBdDlNK0NUU0tDRHVoeVd1OGdIYlpm?= =?utf-8?B?Y2k3RklFekI1SS9Dd0VORkJpVDQxQ3RGTWJOYmZKdTAwU2djY2JiVzFtYWZX?= =?utf-8?Q?mBLvLpYiW5HVw1ExmuDRw1UjEgPQxfvRKYdCMcgn2yPA=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50ffce67-8271-416d-6ffa-08dad2eb04fe X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 15:53:27.2245 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Jua25Nl6bPzqdI0WvJnIcA8zYiDYV4YnlYyrmw0O4hXpqev7HXSKYKp0y5RR2ydLNEDtdBIJ9gCuXAgt6nNeyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5540 On Tue, Nov 29, 2022 at 09:43:53AM -0800, Dave Hansen wrote: > On 11/21/22 02:21, Roger Pau Monne wrote: > > When running as a Xen dom0 the number of CPUs available to Linux can > > be different from the number of CPUs present on the system, but in > > order to properly fetch processor performance related data _PDC must > > be executed on all the physical CPUs online on the system. > > How is the number of CPUs available to Linux different? > > Is this a result of the ACPI tables that dom0 sees being "wrong"? Depends on the mode. This is all specific to Linux running as a Xen dom0. For PV dom0 the ACPI tables that dom0 sees are the native ones, however available CPUs are not detected based on the MADT, but using hypercalls, see xen_smp_ops struct and the x86_init.mpparse.get_smp_config hook used in smp_pv.c (_get_smp_config()). For a PVH dom0 Xen provides dom0 with a crafted MADT table that does only contain the CPUs available to dom0, and hence is likely different from the native one present on the hardware. In any case, the dynamic tables dom0 sees where the Processor objects/devices reside are not modified by Xen in any way, so the ACPI Processors are always exposed to dom0 as present on the native tables. Xen cannot parse the dynamic ACPI tables (neither should it, since then it would act as OSPM), so it relies on dom0 to provide same data present on those tables for Xen to properly manage the frequency and idle states of the CPUs on the system. > > The current checks in processor_physically_present() result in some > > processor objects not getting their _PDC methods evaluated when Linux > > is running as Xen dom0. Fix this by introducing a custom function to > > use when running as Xen dom0 in order to check whether a processor > > object matches a CPU that's online. > > What is the end user visible effect of this problem and of the solution? Without this fix _PDC is only evaluated for the CPUs online from dom0 point of view, which means that if dom0 is limited to 8 CPUs but the system has 24 CPUs, _PDC will only get evaluated for 8 CPUs, and that can have the side effect of the data then returned by _PSD method or other methods being different between CPUs where _PDC was evaluated vs CPUs where the method wasn't evaluated. Such mismatches can ultimately lead to for example the CPU frequency driver in Xen not initializing properly because the coordination methods between CPUs on the same domain don't match. Also not evaluating _PDC prevents the OS (or Xen in this case) from notifying ACPI of the features it supports. IOW this fix attempts to make sure all physically online CPUs get _PDC evaluated, and in order to to that we need to ask the hypervisor if a Processor ACPI ID matches an online CPU or not, because Linux doesn't have that information when running as dom0. Hope the above makes sense and allows to make some progress on the issue, sometimes it's hard to summarize without getting too specific, Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Nov 30 16:14:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 16:14:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449981.707059 (Exim 4.92) (envelope-from ) id 1p0Piy-00021u-7s; Wed, 30 Nov 2022 16:14:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449981.707059; Wed, 30 Nov 2022 16:14:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Piy-00021n-4N; Wed, 30 Nov 2022 16:14:16 +0000 Received: by outflank-mailman (input) for mailman id 449981; Wed, 30 Nov 2022 16:14:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Pix-00021h-AN for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 16:14:15 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0621.outbound.protection.outlook.com [2a01:111:f400:fe02::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 072478e7-70ca-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 17:14:13 +0100 (CET) Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS2PR08MB9975.eurprd08.prod.outlook.com (2603:10a6:20b:62c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Wed, 30 Nov 2022 16:14:10 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5880.008; Wed, 30 Nov 2022 16:14:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 072478e7-70ca-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JR78n9GxYOr+AYVpn461UIDQb/Bo5buCVXSUg2ak1AlZqQVWNtbXVBmrscqw+8Ff1mmuz6xeMYMMBYjm8rQ8cLoq8qyG1b12yxfW/+LC2dZ9pUn2U5puFee591KR+zsLU90jy/bpp06W4xQ2xLv+FZCZs5W09nD/LdsE9LDMBvn6wKIKIYIwv8K1B0P3FpCLSehOjltI3MaJyBW1XXzejHaeTv3IsAJdfmFIkIraHwO9Zih38ZLP4x910EGOw5of5i3zos2AvRPxZXrf3vLc15uspx5Dp92elU7rFyjruekGiZnxpbESO2I2262I3U2X3NoGDpDemuCDTUzZ3bGh5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zdLrt8oGwGedd9qds9SmzNqss5hiRtG6YsnpTrVKvSY=; b=C+Y19OWOnZHZcMC4bROIBrkMnAj4f+psYJZwjvgUwW9z+4Z8wReokKsKY5RhnL4rv6w1fJruPvKaN60R2uDFAe0A0jgCc/8YP6sy3VlWtaBCa0BTloBACnN3Nh/JPersIFFBm49nelef5AByRkGKD7IuSOCT0o1MhVX49gjHPwheaRix+ZSCY8/joCLiT4rk3V6s+X/6d9ugp208VfGCWmXL9W1rYEt7qFQVE/p70l+/6I7exB6cCmRgy3vId4kLMPyaBpWINgoqfqLmWl1t0VWyxFiH5h8SGCfWWExMBKJLaYkGAlmYwufZtM6px4xw800ofwAYg8qt0bM3FV8HjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zdLrt8oGwGedd9qds9SmzNqss5hiRtG6YsnpTrVKvSY=; b=koO745ndzlXYf1wCA79WKBE01yNE3XOmcTZXfyNnnHOV2WygPvm9anfjAoaERlRAqMd1ZirVlaNTUJtUbs5I3ykiqjnkQL5XKdYj+h/GCyMSRfaIraYEgEnghPzVMMQMkWpkSm4ORFA86cYITNZ654iLFr3mL/fZF1wMoE349KY= From: Bertrand Marquis To: Anthony PERARD CC: "xen-devel@lists.xenproject.org" , "michal.orzel@amd.com" , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v5 2/3] automation: Add a clean rule for containers Thread-Topic: [PATCH v5 2/3] automation: Add a clean rule for containers Thread-Index: AQHZBLWCwuaJdzRhgku5EuukHQuC4a5XnPoAgAAHJwA= Date: Wed, 30 Nov 2022 16:14:09 +0000 Message-ID: <81A8B56D-B3EA-420A-9A40-8D98407ACAEA@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS2PR08MB9975:EE_ x-ms-office365-filtering-correlation-id: 8e945f28-1acd-49fc-1d83-08dad2ede998 nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jWzI30MyvC6dZ5/V2FxzUBT297UTTPtMraFvRDn1ZATAfxESrpek1sGqcFOK/eCofWZRGgOxGw1MyZ5Km4V3eHepzYrR6gkNdhVl2UND8FRy4hbwrHsOXrnXc2BytehUT7dJdXAfdPSoVJm49mUHgaOzVLkewGed7l6deHj909bW+Dc9AN6JmaY9lGHrfqmhToVJFRG/4PTmu29pCCZZcpCuHvuCGWN3gzFMPluAqRCQVU+ihyZ3IIuX7US9cEGAOPiF1FpWIBXVRCuQLgiv0CNwpwpylrMPOQKjM4lOKyTHJC7uICXO15jLRVzZpmuEnWj76+aV8mgtaKZg6Z/HbAbGKZ6lFoDAlZfBewEurwYOUSBE6sVZtU4HxRNq/NBhF9JJvrhfBa68Qd1Juu2+3Ylubt4DB6eYIeM7UnmIHreRVAM2goi6Rb3d7tf1p3gyocZk4N9uvN7mOiaScQDtST7M4x6NXxV6PBFFpkqdZBwmTzO2tFnSdY6uH9+4VKD8Q/yc8+MwXKvAhnYu3QmpDbm0KFRJf1xGkbyLhWKomKYPftNOFwycx1H7+fFDMRu+oAAKizJ2nWq11i/gZWsiymKgOTznKL4hw74b03obljr+x/a+QxUt/h3CRu9ONcutkKISiJpeRenCMC5cFr3MGLSpFdYCwqDobAO3MXb0Vt4SFfrjIs+KkLfggdJz+BIa12YV1BrykOiQz2PIluEl05neJ6jV8z16a1H00VbvtiE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(39860400002)(366004)(376002)(451199015)(122000001)(36756003)(33656002)(41300700001)(478600001)(2906002)(38070700005)(4744005)(38100700002)(86362001)(66556008)(76116006)(91956017)(316002)(54906003)(8676002)(71200400001)(6486002)(6916009)(66446008)(64756008)(66946007)(2616005)(8936002)(5660300002)(66476007)(26005)(186003)(53546011)(6512007)(6506007)(4326008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aH525uwNyhVkar9iARUTazElK85g+N6SDJg5EB0nB+nz66vA7YKjErVzw22x?= =?us-ascii?Q?mugzqeCgPFqVMhOcMM3kJcYzFwMzBlvqAOfv1Uk17euAC3ibjBKMVxZ5Exl3?= =?us-ascii?Q?o804Uce2jtItDGSJka+qsNtT0ExGUCtr96SnbEMaajZtfjQyr5WtRf7C8/Vh?= =?us-ascii?Q?2cF9Wm7u0fAMzIKa9efwIrwO4Ec1bf+ewaJLwvP0OMpTZnkwJG+XqwzG2cEI?= =?us-ascii?Q?5jOzOovaOJIIjW7YCp99vpvm/cJwZlyejlPIuPtahJASvyVm2dBIIHUsZAKu?= =?us-ascii?Q?sKLys0rI4XC8+qrezCRp8xTy9HAOsdJu0/8dzlynC/nwen/ZS2M7uvqmwR1j?= =?us-ascii?Q?eDOBPM2ci3L9B0/Ilz3rwwKLIaHchv+CwOADNZP1GRdnDrzaEPMmiWPrLEHw?= =?us-ascii?Q?P5Htj4uPa1fPUBbYXyj9/mrhM+z9aq0FkYDgijyG5b6txDYsK6Ymb2BQ+18d?= =?us-ascii?Q?nrDxpf8klElqF98y4bnXt0x2MxcXwEwZm8L8KGMTZFOschkE1WbJYtPx4SFm?= =?us-ascii?Q?naf6s4ApnGtvNNsjAvfsPnGXMaM9rgYWw3geV1OHJKwq1PV7egYdcGEwLdv/?= =?us-ascii?Q?uyqNWSbvUI0JiEanzSWjARe160gdp/+LNAYyZ7C/Rtan9Iceh9dby+AAEnL6?= =?us-ascii?Q?6k/+NQmsZc6Bw27PW7xryHE4uirJIPBNNUv1sd/DCva+ZImPPYDJxWzgBbmv?= =?us-ascii?Q?LQpzvlDfgaM4x/tknAhZrsVA16YFbHIRQg7OSHPQ+fZq8V0TT5obnBVaE0xV?= =?us-ascii?Q?yEgETX1YbVdsgZvBcEBilg6QUl801W4MosoWrPzbFPYYxj+EshTiZMAR3tYJ?= =?us-ascii?Q?KhhBYva50uJaFV5SvATHuCk67aeDOJtsZBrKZzF1+JJfrSx3IR6HdT+gtEz0?= =?us-ascii?Q?iXF6Avl7v9xaHileiiq9qcT+g6GKZgswIPLC1xU8uSe8b3o9ksf+qnnghaTj?= =?us-ascii?Q?T9yHJV96u74fceKnH8fH9M4PzFuJ0QTEiT47/q/nCVI5Sgm/tU5j0FMg8Xp+?= =?us-ascii?Q?DFk1xc/kEgfa4JK+RNLZ0i9btBn+Q1jeLe6I38ymrcvH37knA4xq9bZJukvA?= =?us-ascii?Q?HDZ3G0FfTobXGDa/ZgI4zmParHsm74PF8igKiP+Uky6P3spXMbf0UFHdw/Ed?= =?us-ascii?Q?R2QKgJVs3OaCWk3IiGzPT7mUegAv4B7ZX1ALAiWmi+YgrFA8wtrNi4PD0kSb?= =?us-ascii?Q?P0HmmHowZH5HdGabakGlcTyTeVWV1lbLXnABdx/ldBSGOw1FeNNQ4V1MuZF3?= =?us-ascii?Q?SYMoLPeMftaqcoWjwJU0umGRQOXutEuADn7wVL8VpdDmc9EfTBtSBTABw5B1?= =?us-ascii?Q?6bi1SP8p1pNXu8DmFsKVMSXNN7LnzzRs9hid36UGaIo170cCAjZ2MewSzbUZ?= =?us-ascii?Q?6vkAQLtoXwHurAJ55uzEZ4D7wG7hTKFsQuezSX6rYUkFosqvOOJFufnF7RRy?= =?us-ascii?Q?0Qv0qHL2dMWJg+mEoQXm/+tdE/6He6vCpcGexPjBU4MAzD7jH+Hi0+mRpvD0?= =?us-ascii?Q?6+trl6jtD8p92H7PlvKHGn4nlTGAA0c4MLpEZFLp5KnlclzSrDBq5fLqMoZp?= =?us-ascii?Q?3jGLoWh+Rc9lOud83ab70lztg+OwnsH4/MS0FZYxLLAO66KeHo20fNHD3tqJ?= =?us-ascii?Q?mg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <15773CBC3587614E876EF6142C65D15C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB3784.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e945f28-1acd-49fc-1d83-08dad2ede998 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 16:14:09.4176 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YTlThql1YBI/xe4ydphD79yItsdT2iGVuC4sean2d7m+khi11TpVY54V03BgCyBU+1Nra+OWD3k3q228n5whSVW3Mc7iK7ZTg0zICb/9018= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9975 Hi Anthony, > On 30 Nov 2022, at 15:48, Anthony PERARD wrot= e: >=20 > On Wed, Nov 30, 2022 at 12:15:08PM +0000, Bertrand Marquis wrote: >> --- a/automation/build/Makefile >> +++ b/automation/build/Makefile >> @@ -28,3 +28,13 @@ all: $(CONTAINERS) >> clean: >> rm -f yocto/*.dockerfiles >>=20 >> +define CLEAN_RULE >> +.PHONY: clean-$(1) >> +clean-$(1): >> +ifneq ($$(shell docker image ls -q $(REGISTRY)/$(subst /,:,$(1))),) >=20 > Please, don't use "ifneq" in a rule's recipe, especially when running a > shell command. That shell command is evaluated every time make parse the > makefile, so we are going to run `docker image ls` 23 times! >=20 > Just write the call to `docker image ls` and evaluate the result in > shell. I guess something like: > [ "$(docker image ls -q ...)" ] && docker image rm ... Very good point, I will fix that in v6. Cheers Bertrand >=20 >=20 > Cheers, >=20 > --=20 > Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Nov 30 16:22:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 16:22:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449988.707070 (Exim 4.92) (envelope-from ) id 1p0PqW-0003r9-0J; Wed, 30 Nov 2022 16:22:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449988.707070; Wed, 30 Nov 2022 16:22:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0PqV-0003r2-SX; Wed, 30 Nov 2022 16:22:03 +0000 Received: by outflank-mailman (input) for mailman id 449988; Wed, 30 Nov 2022 16:22:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0PqU-0003qw-HN for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 16:22:02 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 1df101fa-70cb-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 17:22:00 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 55AEFD6E; Wed, 30 Nov 2022 08:22:06 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 66FCC3F67D; Wed, 30 Nov 2022 08:21:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1df101fa-70cb-11ed-8fd2-01056ac49cbb Date: Wed, 30 Nov 2022 16:21:56 +0000 From: Andre Przywara To: Ayan Kumar Halder Cc: Jan Beulich , Stefano Stabellini , "Stabellini, Stefano" , bertrand Marquis , "Volodymyr_Babchuk@epam.com" , Rahul Singh , Vladimir Murzin , Julien Grall , "xen-devel@lists.xenproject.org" Subject: Re: Arm: AArch32: Need suggestions to support 32 bit physical addresses Message-ID: <20221130162156.28b51eb8@donnerap.cambridge.arm.com> In-Reply-To: <4e84c85c-7e2f-38b1-a235-5323a77738e7@amd.com> References: <70651dbc-085d-706d-17d0-a419086a0700@amd.com> <65891843-db28-e5dd-6e9e-3fb003fcabc5@amd.com> <105a0d45-5b3d-7986-92c1-9a13eb803bd8@amd.com> <22d28805-8889-25e9-6d18-c868bf5e51bb@suse.com> <20221130131316.13ebf9d1@donnerap.cambridge.arm.com> <4e84c85c-7e2f-38b1-a235-5323a77738e7@amd.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 30 Nov 2022 15:39:56 +0000 Ayan Kumar Halder wrote: Hi Ayan, > On 30/11/2022 13:13, Andre Przywara wrote: > > On Wed, 30 Nov 2022 08:09:53 +0100 > > Jan Beulich wrote: > > > > Hi Ayan, =20 > Hi Andre, > > =20 > >> On 29.11.2022 19:18, Ayan Kumar Halder wrote: =20 > >>> On 29/11/2022 15:52, Julien Grall wrote: =20 > >>>> On 29/11/2022 16:23, Ayan Kumar Halder wrote: =20 > >>>>> On 29/11/2022 14:52, Julien Grall wrote: =20 > >>>>>> On 29/11/2022 14:57, Ayan Kumar Halder wrote: =20 > >>>>> --- a/xen/common/page_alloc.c > >>>>> +++ b/xen/common/page_alloc.c > >>>>> @@ -2245,7 +2245,9 @@ void __init xenheap_max_mfn(unsigned long mfn) > >>>>> =C2=A0=C2=A0{ > >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ASSERT(!first_node_initialised); > >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ASSERT(!xenheap_bits); > >>>>> +#ifndef CONFIG_AARCH32_V8R > >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 BUILD_BUG_ON(PADDR_BITS >=3D BITS_P= ER_LONG); > >>>>> +#endif =20 > >>>> BUILD_BUG_ON() are used to indicate that the code would fall over the > >>>> check pass. I can't find the justification for this change in the > >>>> commit message. =20 > >>> I had a look at the following commit which introduced this, but I > >>> couldn't get the explaination for this. > >>> > >>> commit 88e3ed61642bb393458acc7a9bd2f96edc337190 > >>> Author: Jan Beulich > >>> Date:=C2=A0=C2=A0 Tue Sep 1 14:02:57 2015 +0200 > >>> > >>> @Jan :- Do you know why BUILD_BUG_ON() was introduced ? =20 > >> You've cut too much context - the next line explains this all by itsel= f, > >> I think: > >> > >> =C2=A0=C2=A0=C2=A0=C2=A0xenheap_bits=C2=A0=3D=C2=A0min(flsl(mfn=C2=A0= +=C2=A01)=C2=A0-=C2=A01=C2=A0+=C2=A0PAGE_SHIFT,=C2=A0PADDR_BITS); > >> > >> Clearly addresses used for the Xen heap need to be representable in an > >> unsigned long (which we assume to be the same size as void *). =20 > > So I am wondering why you hit that code for your port in the first case? > > If you check, then ARM32 won't pass this, because PADDR_BITS is 40, whi= le > > a long is still 32 bits. =20 >=20 > But, PADDR_BITS should be equal to 32 for R52. >=20 > Refer Cortex R52 TRM, Section 2.2.12 "Memory Model" > "...This is because the physical address is always the same as the > =C2=A0virtual address...The virtual and physical address can be treated = as > =C2=A0synonyms for Cortex-R52." >=20 > From this, I understood that as virtual address is 32 bits for AArch32,= =20 > so physical address will also be 32 bits. >=20 > Please correct me if I am misunderstanding ? This is correct, but it's also a big distraction, as no VMSA means that most of the traditional Xen code becomes irrelevant, since you cannot map anything anyways. You have to check how the v8-R64 code handles this, I guess it uses separate code paths? > If this is correct, then ... >=20 > > So digging deeper this is code for the case when we want to map the ent= ire > > physical memory into Xen (the Xen heap, or direct map in Linux terms). > > Which we cannot do for ARM32, and that's why the code is protected by > > !CONFIG_SEPARATE_XENHEAP, which is forced to 1 for CONFIG_ARM_32 (in a > > hacked up way, btw). =20 >=20 > we can map entire physical memory into Xen as VA =3D=3D PA. We cannot map anything to begin with, since we have no tables. So without mapping, indeed the whole physical memory naturally fits into the CPU address space. But in any case you must not use this code, as this tries to *map* something, which we do not support on R-class. Again check what the v8-R64 code has to say on this topic. Cheers, Andre > > So I think you must just force the same thing for your port, then this > > code will never be compiled. > > > > Does that make sense? > > > > Cheers, > > Andre > > =20 > >> But I'm afraid there's further context missing for your question: Why > >> would that construct be a problem in your case? Is it just that you'd > >> need it to be > rather than the >=3D that's used presently? If so, why > >> do you add an #ifdef rather than dealing with the (apparent) off-by-1? > >> (I say "apparent" because I haven't checked whether the >=3D is really > >> depended upon anywhere.) > >> > >> Jan =20 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 16:25:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 16:25:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449994.707080 (Exim 4.92) (envelope-from ) id 1p0Ptq-0004TP-EJ; Wed, 30 Nov 2022 16:25:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449994.707080; Wed, 30 Nov 2022 16:25:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Ptq-0004TI-Ba; Wed, 30 Nov 2022 16:25:30 +0000 Received: by outflank-mailman (input) for mailman id 449994; Wed, 30 Nov 2022 16:25:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Pto-0004Sv-Rf for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 16:25:28 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 988cbdf4-70cb-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 17:25:27 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 988cbdf4-70cb-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669825527; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8ga+gI1mDKVulqMUXPWmUjyJ8WnmzxiTH6hZr9qJ6ac=; b=IZiQNSx1kDBvwKOVUUnOyy7GdZRCxDTkHjae07EL33z7xHlV2eHZ0vFg Dh4EsyUTbL2/8ba9kjF2pobrO1ThJ2OTP931DMPeteml3BPbqFnq+w6Af 1L9DTDDu0WbAGDvyo+Bp9J/X7teMO2bxposaZ4T9CMSdE6YGkI/r1HjQu 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 88412782 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:RgkRoKA6FcRjYhVW//7jw5YqxClBgxIJ4kV8jS/XYbTApDkggmYGx mQcWD+OOPreZWP3Kd50O4zk8BkBsZLVzYNqQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpD5gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw3/dNC25N9 aIjKDkHcRqKrOSrmryYRbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/AZQinOCulz/nfidRsl69rqsr+WnDigd21dABNfKFKoDTH5oFxC50o Erj8W6jUyM6EeCD1DuA/VmP2uHdswHSDdd6+LqQqacx3Qz7KnYoIBYfT1e8rNGyg1SyXN8ZI EsRkgI1trQ7/kGvStj7XjW7rWSCsxpaXMBfe8U/6QqNw66S5ByLC2wsRztNLtchsaceTzEwy kWAmd+vADV1qaCUUlqU7LLSpjS3UQAFIGlHaSIaQA8t59j4vJp1nh/JVsxkEqO+kpvyAz6Y/ tyRhHFg3fNJ15dNjvjluwCc696xmnTXZisk3A/YXWL71QNwbpGvbqeu9ALVzvkVee51UWK9l HQDnsGf6sUHApeMiDGBTY0xIV252xqWGGaC2AAyRvHN4xzooif+Jt4IvFmSMW8zaq45lSnVj Fg/UO+7zLtaJzOUYKB+eOpd4Ox6nPG7RbwJuh05B+eig6SdlifdpEmChmbKhQgBdXTAdolhU ap3ie72UR4n5V1PlVJavds1374x3TwZzmjOX539xBnP+ePAOi/KFelbbQXSMr5RAEa4TOP9q Y432yyikkU3bQEDSnOPrd57wa4ichDX+qwaW+QIL7Xec2KK6UkqCuPLwKNJRmCWt/09qws8x VnkAhUw4AOm1RX6xfCiNigLhEXHAcwu8hrW/EUEYT6V5pTUSdzwtPpBL8tsIeVPGS4K5accc sTpsv6oWpxnIgkrMRxHBXUhhOSOrCiWuD8= IronPort-HdrOrdr: A9a23:l2CC+KqCrdc5WIVk9edn4qQaV5oReYIsimQD101hICG9JPbo8P xG+85rtiMc6QxwZJhOo7u90cW7K080lqQV3WByB9iftVLdyQ+VxehZhOPfKlvbdhEWndQy6U 4PScRD4HKbNykdsS5XijPIcerJYbO8gcWVuds= X-IronPort-AV: E=Sophos;i="5.96,206,1665460800"; d="scan'208";a="88412782" Date: Wed, 30 Nov 2022 16:25:14 +0000 From: Anthony PERARD To: Bertrand Marquis CC: , , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v5 1/3] automation: Create Yocto docker images Message-ID: References: <18861c0c9c547959900532e38df11b2d67f0a1cc.1669810269.git.bertrand.marquis@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <18861c0c9c547959900532e38df11b2d67f0a1cc.1669810269.git.bertrand.marquis@arm.com> On Wed, Nov 30, 2022 at 12:15:07PM +0000, Bertrand Marquis wrote: > diff --git a/automation/build/Makefile b/automation/build/Makefile > index a4b2b85178cf..72a5335baec1 100644 > --- a/automation/build/Makefile > +++ b/automation/build/Makefile > @@ -1,13 +1,18 @@ > > # the base of where these containers will appear > REGISTRY := registry.gitlab.com/xen-project/xen > -CONTAINERS = $(subst .dockerfile,,$(wildcard */*.dockerfile)) > +CONTAINERS = $(filter-out yocto/%,$(subst .dockerfile,,$(wildcard */*.dockerfile))) Nit: while there, could you use ":=" instead of "=" ? The value of CONTAINERS is always going to be evaluated by make because it's used as a prerequisite of "all", so we can at least tell make to evaluate the value right away. > +CONTAINERS_EXTRA = > DOCKER_CMD ?= docker > > +include yocto/yocto.inc > + > help: > @echo "Builds containers for building Xen based on different distros" > @echo "To build one run 'make DISTRO/VERSION'. Available containers:" > @$(foreach file,$(sort $(CONTAINERS)),echo ${file};) > + @echo "Extra containers (not built using make all):" > + @$(foreach file,$(sort $(CONTAINERS_EXTRA)),echo ${file};) I wonder why the help syntax uses both ${} and $() for make variables, is it to confuse people? :-) You can write $(file) instead of ${file}, I think this would be less confusing. I rarely see ${} been used in make, so seen ${} can be confusing. I've learned (relearned?) this alternative syntax only a few weeks ago as it's used by automake or autoconf. > @echo "To push container builds, set the env var PUSH" > > %: %.dockerfile ## Builds containers > @@ -16,5 +21,10 @@ help: > $(DOCKER_CMD) push $(REGISTRY)/$(@D):$(@F); \ > fi > > -.PHONY: all > +.PHONY: all clean > all: $(CONTAINERS) > + > +# Remove generated dockerfiles for yocto > +clean: > + rm -f yocto/*.dockerfiles There's an extra 's', I guess you want to remove "*.dockerfile" instead of "*.dockerfiles". You could also add those to a .gitignore, even if there are likely to be removed by make. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Nov 30 16:37:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 16:37:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.449999.707092 (Exim 4.92) (envelope-from ) id 1p0Q5H-00069m-Gy; Wed, 30 Nov 2022 16:37:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 449999.707092; Wed, 30 Nov 2022 16:37:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Q5H-00069f-CS; Wed, 30 Nov 2022 16:37:19 +0000 Received: by outflank-mailman (input) for mailman id 449999; Wed, 30 Nov 2022 16:37:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Q5F-00069Z-No for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 16:37:17 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3df5e99d-70cd-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 17:37:14 +0100 (CET) Received: from mail-co1nam11lp2168.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Nov 2022 11:37:11 -0500 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) by BL1PR03MB5974.namprd03.prod.outlook.com (2603:10b6:208:313::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 16:37:09 +0000 Received: from SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1]) by SJ0PR03MB6360.namprd03.prod.outlook.com ([fe80::740b:4e0a:7de4:5ab1%9]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 16:37:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3df5e99d-70cd-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669826235; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=aLK/4rYA/lP/TxDJxKDrnon9y4jvbOFcMo7+a78jTvc=; b=ZXxosR3hKjLa966T18i0uMEVDusu+HPaZjq6nUhMx5eB1oFUeVMs6SDe t7PCD/i19TeoDzoKlWBVXBbNJrB1pba5QeFfMTHV1yjoi5aYf40JpMG4H FHmMkHQovI1p4l+Ttd/AG2ZqUJZedjgcrNm5MkKnSgEbt7Yebm5ln3MTX o=; X-IronPort-RemoteIP: 104.47.56.168 X-IronPort-MID: 86302173 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gJeZBK1xsdz1zXPmt/bD5bRxkn2cJEfYwER7XKvMYLTBsI5bpzMOy 2NLCG/UOv2IMzT2LoxyYYy+ox4HvpXSzoQ3SVNppC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVlPagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfAV9tz /cxFBo2YFORodqtkIyiFORnv5F2RCXrFNt3VnBI6xj8VK9jareaBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvS6KklwZPLvFabI5fvSQQspYhACAr 3/u9GXlGBAKcteYzFJp91r82LSXx3qkA+r+EpXj/Ll4jWGO2VUWIx8bU2HrnamyhnaxDoc3x 0s8v3BGQbIJ3EiqSMTtGh61uniJujYCVNdKVe438geAzuzT+QnxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8oim/NisVBWsDYzIUQwwY5dXqvIA0iFTIVNkLOKy0lNzuHTj60 hiJoTI4irFVitQEv4258krAmCmEvYXSQ0g+4QC/dmii9AJiIom+e5av90PY/N5HNo+SSlTHt 38B8+Cc5u0TCZCGlASWXf4AWrqu4p6tKybAiFRiG50g8TWF+HO5e41UpjZkKy9BMcECYzblJ lDSvQB544VaN3+nK6RwZuqZD8Us0Lj4Dd+gWv3KRt5PeYRqMgiV+ChkfgiXxW+FraQ3uaQ2O JPeesH1C38fUP1j1GDvGbdb1qI3zCcjw2+VXYr80xmszbuZYjiSVKsBN1yNKOs+6ctovTnoz jqWDOPSoz03bQE0SnC/HVI7RbzSEUUGOA== IronPort-HdrOrdr: A9a23:ZPSbV6NantNhHMBcTgajsMiBIKoaSvp037By7TEJdfRUGvb4qy ncpoVi6faUskduZJhOo6HkBEDtexzhHNtOkO8s1NSZLXjbUQmTXeVfBOLZqlWKcUCTygce79 YGT0EUMr3N5C1B/KTHCX6DYrUdKbe8npxAzt2utEuFBTsaEZ1I/kN1AhuSCU1tRgNCDYAiFJ Wd7MJbpzymEE5nE/hTKEN1INQqELfw5e7bXSI= X-IronPort-AV: E=Sophos;i="5.96,206,1665460800"; d="scan'208";a="86302173" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c209cZJox8fbDBdJi9CeYWU6m7FTrqY3+WhVSsoFPei1/P1qXtDAN2+bajTlphWPlN2Y0/VNUTnxYtC8T6UQ2PaqxXxFbjmLC7Eu2bPJ6hhpw5mOGSbLz8OscRH29d6cGGLoP0rHds30c/FJ/xz0Bnbr78NNUn4kiTA9BPmkZxjX+TlHqNylGkVUCVds8oLmydZPP/mDJUmBGHG2MwjpAGcz7TMXfXykNlljcocz6NRP8kHVeTVxsdj7jx3Nv3W7ZRyAPt4qmUUnGzKMjfdrUrtniWf5KAaPPCayUChXireV8En/rhq60ZAtxHessSriLhExXNXqD4K48WK42PvoAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TEk6iK5GvuVMLVelUUxiis8clwrCKUaO8K0CKeMME58=; b=Fql3cSUfTvkH2EgyWXKoe7FKwby3AyLKSyFj8eO5vlSCljT2Amck684NgwfbOVCPTvOT3OLoFAVz5vPW/ECMLpQ4/zPq9ziJtd1smXVK+XAaXFld26UkAMSVgDAecQZWd+uCfT7YXljp4sHz14ReicalHzJnykXpTbEr7bud+HiNvyHsqDdLjsMXTBUqsRZvPQ0gjjDpQ4UWubht963WYsGewQqCGedBNVUigI77CyohzTy45TagM3ZfIERfrw+VNzfWx2Qsjl7jDUxB6XJmOC1jVSc3IkalMIQGMOGCFJtVngFgu6n45n18FGnsoBbXuF/uoi6nC14mXnPioQHhmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TEk6iK5GvuVMLVelUUxiis8clwrCKUaO8K0CKeMME58=; b=Ausfw2FzzLP1btz4wMGE1I6CVvRmf7/DID/hd4bWHQqmechomyuxqVGdyFVyDCSVD4gch7FfE+RMLskPtgUxllbbhEX8dGT7Sb0KG7CHDpmoL33OfoKi+j+oqTCMfW39FLThJ4lv7NWbMcBatKit+3ZNO4N4OagCipihqksINks= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, Roger Pau Monne , Greg Kroah-Hartman , Jiri Slaby , Juergen Gross , Boris Ostrovsky , Jan Beulich , Stefano Stabellini , Konrad Rzeszutek Wilk , linuxppc-dev@lists.ozlabs.org Subject: [PATCH v2] hvc/xen: lock console list traversal Date: Wed, 30 Nov 2022 17:36:02 +0100 Message-Id: <20221130163611.14686-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0028.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::20) To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB5974:EE_ X-MS-Office365-Filtering-Correlation-Id: 2401b07c-0811-4c4d-b529-08dad2f11f9e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TtSWEofdWbLjERcNpzjf0HSLJev25IVXtnHHdxF+ZQbFUPTX+FZOhpG7M4kJEtChu7e+4w8a10KbdwETY8IWS0tZDJveXowiuQxozCYyR9HO5AJT/AAhiqO+zh2mcNCf2qgOGa662jwbIPXPuWWwE8bhMfipSDBk5+23/WZGJwHfQn/NLpKrXGAT4WIlLvMzmqR5u6y0gSGq9pt3/6GmQlCko21Pb980JL8Dc/h4RCEgzRmQP3LGxvvwjCz/8h0xV0cZVMIv9JGXKaEzLdjn/7QGwWh1IzRdQs9heO/RA6zn4voLSIEyy2W4/fyprSfJvC5aSxMqbq0c60YwJqiaVYIAMSaRUIzKGWPZVzYrvtIfHsrG1PFw8JQMvSWb+tggmAf1J0TAwhkhP5JMiYDcT/7JQJUwKkL5JWGU49zGii672DDhzPGRp/e7xOm1kK7kF120mQuKIXSg1+tRsWh9fxVlz0Hdu8Aqo0s8tj2aYWdyNi4hE44brKTTtVk9tXRfQqSp3NBOimH2V0uSIao2wQjqqMncN1+nRJDsEMlpD61duNvqJ9o4BHm6tM1KkRUTJnJKgwMyDMzm+Bhe+4VYmTujcu3+gTU9geb+SSxrghTcT9xFrkX5LXXkEI60aUbonTw4/FLRZw3r9MGbfecMgg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(136003)(376002)(396003)(346002)(451199015)(83380400001)(38100700002)(6916009)(86362001)(6506007)(6666004)(6486002)(54906003)(36756003)(6512007)(26005)(82960400001)(1076003)(2616005)(186003)(8676002)(66476007)(5660300002)(478600001)(41300700001)(66946007)(4326008)(8936002)(2906002)(316002)(66556008)(7416002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGZJSHhHZklOUVFhWWFST2dTbWR5OVJhU21QYzQ0MU5PYWpKZmF6QVkrZWRh?= =?utf-8?B?WmZIRDlFUTQ0K1ZuaTM4NkhvMUFqTURrUVU1ZlIrTEk2Qm1WV2ZaaGRDM1Ax?= =?utf-8?B?MFRsVVJEblNzdFc3Tm5wcDAxOGFoZEg1RElPSzBXcW9ETDhvTi9xSjQreng2?= =?utf-8?B?dVBPT0Jyem9oMVBNNnY4OTdaUSt0Q0xEMVREZmxlWU53OWxmWVpENGtySGNa?= =?utf-8?B?VzNXSGZhOHNDZlZlSSt1cHhlTGxnODNndUFibmFUMG00dUJ3dWpOeCtlU01o?= =?utf-8?B?SDVyWjIyS1lSRW4xRVRYSHRvc3lHMWkwR2lVcmJhRTBhNjZMOEZ1TzJsRGgx?= =?utf-8?B?K3BQNWhoR1dwKzh3YTFEVHRJR3hzcHptT29nRENuVHFUa0l5ZTJNc2FZNUhl?= =?utf-8?B?LzhuaGhSZTVCOCtid3ZqWkRqcDQzc1UrNDB2Wi8xdHNyYUNnVWt5WGE1dXhq?= =?utf-8?B?WUtyYW9IRzYwU3RuRk1uMEs4OEUwRWxpV3FjUzMyQ3pUM2thZTNhV1hXR2NB?= =?utf-8?B?c2JhWWIxd1lUUThaTVhWUkNFMzNIMngxY3grU2dZRVhmQlpudWd3cW4vcDlF?= =?utf-8?B?cHRyMDRwNWZiY0tXaXhRYVF2SFVyUlJpS3JFZnd2MjY5ZDBpbXhVTjlwU09l?= =?utf-8?B?anhSYythQ3U0NHNjRzRXZVVGckVUdlVPNWM1VWMyVzhZNXNiWEdORzlmRTIz?= =?utf-8?B?ZGt6RUNtV05PUE9GRGlLMFBFSmliRUE3ckhNWlhkSnBpRlZ5K2lpN001QnU0?= =?utf-8?B?dUZ5YzRCSWJVT0lucEVhSURWRm1OTkJzeTNGeXIyalAxZC9ZSy8rR0lZN1B6?= =?utf-8?B?K2hUZVZvcXdzc2xUUVM5Z3kxWGIyQlRjQ2YxVnQzTGM4R0d0WHFwdjlIUDZM?= =?utf-8?B?Zy9xUjNYNHRBVmNMZTNQeHhpb2JVVW1nS1o1ekJ4ZVJCWitFUHN5OWxKRGdW?= =?utf-8?B?YU9OR28rMGNVQnRCc3pDN2QyZ0ZOUGRIR3psYk16WWFzc0FtNGc4amlxMnh5?= =?utf-8?B?TTdvQXFJQnFmVnBrbjNZenJKKzlETVkwazNtRE9aNGt1MGZwUExmYWFwbXg1?= =?utf-8?B?RlhEdi9HQ2pTalJVRm1xWllzTjZpSFVvL0lrMzUyT3hMZVpQeEt2dDBOK0Vh?= =?utf-8?B?emEvRGMyc1NBRlZGLzUxakVUL1pQSVA3TFRNOGhWZndTc3JpVXRMbjU0cExp?= =?utf-8?B?Y0cva3lHM2dub2o4SlYvL3dOd1JTSHI5OHMrNDM2REtqUmVtU1EwTUNrZ3dw?= =?utf-8?B?bmRWZmtBRVhybHpaUU1nSW0xNTdpaXVNb1RHWUVUNkdUbGZiTEFqdG85SmJm?= =?utf-8?B?N0F2RzZXa1k2cktmZXRrZHRKcStKcnhBOVFDZU9OdW5pb3F1RmxWT2xPdlFu?= =?utf-8?B?eitLaDk4UzJXMGhRMzJnQWQ1cUZSYkc4bXc1WVh4ZUlBRkJuZVgvam5nNHdN?= =?utf-8?B?MG96bXI4MmhZaFdRdmNoTHdxeDVHUTBTMVUzemMxNXB5Z0ZxV0VUekc3VXk3?= =?utf-8?B?aW5UUFlQb2F5WTBtTVlFMU8rTEc2MDM3YnFuanEzSVV4L1RCa3JOM2Q2aHBn?= =?utf-8?B?emVrSmxPbkZTTmJya1hReUpCRGltM0FvN3FHaGJpNkRUOHE2NFUvOXFDOFNx?= =?utf-8?B?QTV6M2xYeTc0MjZnc1dqVmFGS2Z5Z1Zqd000RHR6QnJaREpxY3hQYi9WbUpz?= =?utf-8?B?Y3EwR09ZM0xwQllFRkwvZkN6OEhIUUFXVnFtcW90dmx3Z0N4eHYyU1B1blhF?= =?utf-8?B?Tk9QZUxua2V2eGV5MW5iMnhMVFhaVjBNaGs1a0dpSzlLZnRPMnhFOVp2alRB?= =?utf-8?B?NnBYRkhQVittS1RUMVhKRS9sZ0VHTTNvSWFaQkZiNC9OdVBNd1NxanVSL2FF?= =?utf-8?B?OG5nclJWd2xDeW5GNzZUTFhLRUM2ZGczRzFtTklGMGVLOE9ua3QvM0xJaEtH?= =?utf-8?B?UFQwR3BENlNqWTd3Z3FDOEJaSnFyUU0vcHBXa0szVWhNVHVtZU80Vzg5UnZr?= =?utf-8?B?dVBObmpEQXNIdXl6bitEMzcweXRzbzVaM3c2NnhEcDVrcEpmMnFFczhFRkh5?= =?utf-8?B?bWhyVWFzcFVHZjdsb2svUG5ZUFlKWFd2Q3FTNTYrclloTyttR1N1ZERwYUI4?= =?utf-8?Q?jumEieS/po16dcq/iVcgElH86?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?Wkg5ZWlmZU9tczBuTHBXV0NOMEVSUHlJdyt0YVI0Qm55Y2lXZTlmaVRsNXcy?= =?utf-8?B?bVUybVpsWGNaSXhsM1VLNXJsUzBvdlUrYnpkU1IwUndXS1AxQ0FHZXNqamV3?= =?utf-8?B?SHBXSDFkMGhnRm9EOExEbExpUkpFMkxQSXJWZm1ad2EyNHl5MlJZbzM3UXBp?= =?utf-8?B?MWVEVFF6Um9xdHFpTXFnZ1lIMmhHZEIzVjFhTVJKWnVzazBEUU5tVms2Qnp5?= =?utf-8?B?RVdYeVZGajdQb3FrQjdXRy80dVUrUmEzVVplWWdYVE93dVNod2Z5dHdPVUht?= =?utf-8?B?SjdDelhLZUpYd0VoODFUQ2kvSzVwYjQrc0FDVTJRUDNnMlJKOGs4Mml2QzZQ?= =?utf-8?B?NzFpNTJNT0RyMk1RZkhTOXVwVmpFMjlQRXdOWHJGa01weTlmWjdCUWNMTk56?= =?utf-8?B?Umk0ZXFOeDh2NlpGN0pvMGQ1M2JSL09hQjNyS1R6bE8zT0RiUlBtNnVLNitR?= =?utf-8?B?bE16blZ1czdPVW5VUjlJckZiMUJ1TzBDV09nZlFWU1paVVgwaGZHZzRNbXlv?= =?utf-8?B?RVlnRCt0NWZ1anFqb2RkNFFQQjNtK1UrOURLeFNMMllSQ2pLWVBEdk1zbmh4?= =?utf-8?B?My9TTkFQeDYweDdicERKdVk3K2dhUUlWa0VJeGMvZklmRXhuR2NNOG9wSEpQ?= =?utf-8?B?V2R0Z0Zqdlc4dDZVN1FxV0JyQlI3Q3QzVk9KMG45VUZhUGdkTkU0ZmtMTzI3?= =?utf-8?B?RWFEcjZVaWZQVU96NmhMNjVjU0JHRkhjc0pCU0lqZWVmVTdGTUZOb0UyL1lm?= =?utf-8?B?aFFlSTl2NllFRlVNa3hhYzZOWXJDdm9lRCsrNzJzdHV0QTY0R25obGQvVG82?= =?utf-8?B?RXNkV0dXT3VDSFZoUEl0S3U3MXArd3RSb0FsMTA5cTl5cVh6Y0E3ZVlYUDdO?= =?utf-8?B?UTNxNlYrZjRSdHRJU0k5cHRlbmRWQTVaQ3FSRG5pMHB1SlJ5ajZ3Q1F3b3lJ?= =?utf-8?B?bVo4YzNDaGJ3cU1ISW9TZlp2NDdTU1MxbGhGcW45SW11bkl1VlJ2VnN2Tnc4?= =?utf-8?B?dGNxbDBVb2hUbnVZK2JGTnNMcEhNTlJ3empvZ2hFUVk1cXhoYUtGaVJVdjlJ?= =?utf-8?B?bGlLZmk1R2R4TW1UNXRRdkl0S2ZYeGxEY1Nrc1BLRDU0L0hlVE1UbG5pajJW?= =?utf-8?B?ZHYvamhWNjhQSnRTN2VFZ3JhekFLenlUZnVhSnQ4aUFSQzJGaWUwcDU3UXNq?= =?utf-8?B?VGYyZ1lHU1V1aDNnd1lYVUl0d0s5RTRpSUhxODRDZGc1K0RWMjBQanRlUUxP?= =?utf-8?B?cDZ2NXBVRGN5Yi92QmtmeFFZQy9jQUNPd09aZlIrWmJWM21SaDN0T3lPbHBN?= =?utf-8?B?Y1JqK0NTRGJEeEl1TTR6UEIrUk5rdjR6V1hkQm4vV0tzdnFCTzA1dUpKdXd4?= =?utf-8?B?UEx3N014MEgweFpma0wyWDRMSCt0Y2VTYTllYXc3Z2JZTUVRdlJIdmdGVjdP?= =?utf-8?B?Ym54enF3MlhSbEd5U1VCQUJVREptc3RYTUlTdTRRPT0=?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2401b07c-0811-4c4d-b529-08dad2f11f9e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 16:37:08.8135 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T0qVeVlYhH2uO0F3jAoPrY6g7geZegC9mApJURMivRMKFataV/8DoY+S9XjZgAeiq55A9RxPgfcm8YzUugABXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB5974 The currently lockless access to the xen console list in vtermno_to_xencons() is incorrect, as additions and removals from the list can happen anytime, and as such the traversal of the list to get the private console data for a given termno needs to happen with the lock held. Note users that modify the list already do so with the lock taken. Adjust current lock takers to use the _irq{save,restore} helpers, since the context in which vtermno_to_xencons() is called can have interrupts disabled. Use the _irq{save,restore} set of helpers to switch the current callers to disable interrupts in the locked region. I haven't checked if existing users could instead use the _irq variant, as I think it's safer to use _irq{save,restore} upfront. While there switch from using list_for_each_entry_safe to list_for_each_entry: the current entry cursor won't be removed as part of the code in the loop body, so using the _safe variant is pointless. Fixes: 02e19f9c7cac ('hvc_xen: implement multiconsole support') Signed-off-by: Roger Pau Monné --- Changes since v1: - Switch current lock users to disable interrupts in the locked region. --- drivers/tty/hvc/hvc_xen.c | 46 ++++++++++++++++++++++++--------------- 1 file changed, 29 insertions(+), 17 deletions(-) diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c index e63c1761a361..d9d023275328 100644 --- a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c @@ -53,17 +53,22 @@ static DEFINE_SPINLOCK(xencons_lock); static struct xencons_info *vtermno_to_xencons(int vtermno) { - struct xencons_info *entry, *n, *ret = NULL; + struct xencons_info *entry, *ret = NULL; + unsigned long flags; - if (list_empty(&xenconsoles)) - return NULL; + spin_lock_irqsave(&xencons_lock, flags); + if (list_empty(&xenconsoles)) { + spin_unlock_irqrestore(&xencons_lock, flags); + return NULL; + } - list_for_each_entry_safe(entry, n, &xenconsoles, list) { + list_for_each_entry(entry, &xenconsoles, list) { if (entry->vtermno == vtermno) { ret = entry; break; } } + spin_unlock_irqrestore(&xencons_lock, flags); return ret; } @@ -234,7 +239,7 @@ static int xen_hvm_console_init(void) { int r; uint64_t v = 0; - unsigned long gfn; + unsigned long gfn, flags; struct xencons_info *info; if (!xen_hvm_domain()) @@ -270,9 +275,9 @@ static int xen_hvm_console_init(void) goto err; info->vtermno = HVC_COOKIE; - spin_lock(&xencons_lock); + spin_lock_irqsave(&xencons_lock, flags); list_add_tail(&info->list, &xenconsoles); - spin_unlock(&xencons_lock); + spin_unlock_irqrestore(&xencons_lock, flags); return 0; err: @@ -296,6 +301,7 @@ static int xencons_info_pv_init(struct xencons_info *info, int vtermno) static int xen_pv_console_init(void) { struct xencons_info *info; + unsigned long flags; if (!xen_pv_domain()) return -ENODEV; @@ -312,9 +318,9 @@ static int xen_pv_console_init(void) /* already configured */ return 0; } - spin_lock(&xencons_lock); + spin_lock_irqsave(&xencons_lock, flags); xencons_info_pv_init(info, HVC_COOKIE); - spin_unlock(&xencons_lock); + spin_unlock_irqrestore(&xencons_lock, flags); return 0; } @@ -322,6 +328,7 @@ static int xen_pv_console_init(void) static int xen_initial_domain_console_init(void) { struct xencons_info *info; + unsigned long flags; if (!xen_initial_domain()) return -ENODEV; @@ -337,9 +344,9 @@ static int xen_initial_domain_console_init(void) info->irq = bind_virq_to_irq(VIRQ_CONSOLE, 0, false); info->vtermno = HVC_COOKIE; - spin_lock(&xencons_lock); + spin_lock_irqsave(&xencons_lock, flags); list_add_tail(&info->list, &xenconsoles); - spin_unlock(&xencons_lock); + spin_unlock_irqrestore(&xencons_lock, flags); return 0; } @@ -394,10 +401,12 @@ static void xencons_free(struct xencons_info *info) static int xen_console_remove(struct xencons_info *info) { + unsigned long flags; + xencons_disconnect_backend(info); - spin_lock(&xencons_lock); + spin_lock_irqsave(&xencons_lock, flags); list_del(&info->list); - spin_unlock(&xencons_lock); + spin_unlock_irqrestore(&xencons_lock, flags); if (info->xbdev != NULL) xencons_free(info); else { @@ -478,6 +487,7 @@ static int xencons_probe(struct xenbus_device *dev, { int ret, devid; struct xencons_info *info; + unsigned long flags; devid = dev->nodename[strlen(dev->nodename) - 1] - '0'; if (devid == 0) @@ -497,9 +507,9 @@ static int xencons_probe(struct xenbus_device *dev, ret = xencons_connect_backend(dev, info); if (ret < 0) goto error; - spin_lock(&xencons_lock); + spin_lock_irqsave(&xencons_lock, flags); list_add_tail(&info->list, &xenconsoles); - spin_unlock(&xencons_lock); + spin_unlock_irqrestore(&xencons_lock, flags); return 0; @@ -599,10 +609,12 @@ static int __init xen_hvc_init(void) info->hvc = hvc_alloc(HVC_COOKIE, info->irq, ops, 256); if (IS_ERR(info->hvc)) { + unsigned long flags; + r = PTR_ERR(info->hvc); - spin_lock(&xencons_lock); + spin_lock_irqsave(&xencons_lock, flags); list_del(&info->list); - spin_unlock(&xencons_lock); + spin_unlock_irqrestore(&xencons_lock, flags); if (info->irq) unbind_from_irqhandler(info->irq, NULL); kfree(info); -- 2.37.3 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 16:42:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 16:42:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450006.707103 (Exim 4.92) (envelope-from ) id 1p0Q9p-0007qi-4k; Wed, 30 Nov 2022 16:42:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450006.707103; Wed, 30 Nov 2022 16:42:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Q9p-0007qb-1e; Wed, 30 Nov 2022 16:42:01 +0000 Received: by outflank-mailman (input) for mailman id 450006; Wed, 30 Nov 2022 16:41:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Q9n-0007qV-2a for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 16:41:59 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2061a.outbound.protection.outlook.com [2a01:111:f400:fe13::61a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e7e82e81-70cd-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 17:41:58 +0100 (CET) Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB5PR08MB10255.eurprd08.prod.outlook.com (2603:10a6:10:4a5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Wed, 30 Nov 2022 16:41:56 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5880.008; Wed, 30 Nov 2022 16:41:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7e82e81-70cd-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mI22q9HUpJ2FWnmifpt5/qV0DX+dGluLMnNza9xxyXgs9K2AWm3Xjyhh5BmMgECSSjFbM3Ob6QMfmGq3o1to3iAEM7YB+gue0eayCsuGVGEPzntjScwac9b6uOdAt0zwJU2I1ftiVgIufHYMs7lluaAwkBCsnu4JvKqZucpxzKgXGrcQY8uJ+Ohb9/KtAH+2QAvdeJhDLVuXNfjmRoLFOXI5CIeALtCnjyWgMYCLpcm/GhaRkYyyq7HTgqQZ5FpJ9r+XqgN/R7kswrSY2E3Du06MThHNo7Z2UT3Auth8fg3E+w/HPcvhgI3gI+FtiC+VHhkpTv92oD/UDPkHG4DytQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v7E+yrdO2pVsYu+qCoQa2KfdQIXmZQ0ArivRQAXTY/s=; b=C1rxVXmIfEV7gcb4Zo4Ypy8j0fajo5DDl19i5y0dKD1HKTUmZza6rZ3ziB0CE0pMUpVycL3zpKGvt5gLTFBAGKfQnV1oLU8ZDfDGgaYE+ULMoHFI7MFOBMH3o3A3zkuuxa7lw2oblU8jwz2vlsrU+QjADmIo/iW6BaKjlV4jB1UlbQFiVg07HuVD338+V6JmIEuMBfbFLHguz4aJR9r48+SDevKshAvQwKavJutZGZNwVY0jicsdEsiQIx9Wkvu7TLoxjeJ8QGt7WmgXXOEXBi+BZhCLOpMNHejU2wNc9CQEDJhM9ynFpJBc6JTaj0IS5576hFVsVpaLb6F8uaz6wA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v7E+yrdO2pVsYu+qCoQa2KfdQIXmZQ0ArivRQAXTY/s=; b=EN5eqdVlc/mIaOiZHwC4MvtqU87b0GOqcyVJrx6sPx1hPQJBndLCPPTjPTvxML4R+LxCyHRK+1jPFmfhNU0aPKVyz0QlKFFo2vxR+izYkbanJw0uWC8+9tg83kAxumNhPZKPjD6uwoC/qahNpHiOphnup7zMyPVV0eXSRBSWqgw= From: Bertrand Marquis To: Anthony PERARD CC: "xen-devel@lists.xenproject.org" , "michal.orzel@amd.com" , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v5 1/3] automation: Create Yocto docker images Thread-Topic: [PATCH v5 1/3] automation: Create Yocto docker images Thread-Index: AQHZBLWFmb3GO0y8oEy6bIpMhPppa65XpzsAgAAEqYA= Date: Wed, 30 Nov 2022 16:41:56 +0000 Message-ID: <67AC127C-F59E-49ED-8C45-4615208EC1F4@arm.com> References: <18861c0c9c547959900532e38df11b2d67f0a1cc.1669810269.git.bertrand.marquis@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DB5PR08MB10255:EE_ x-ms-office365-filtering-correlation-id: aaa72f0c-c8e0-41d5-9956-08dad2f1cb2d nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: psawSKQQQ2lMO2dq0hRs+wccZY6K07afrhMfcEkFIIAoWjg/jYdPkr4HECUZJioiCJLsY+7bIZ85HNEI40Ea9xod/qpLxBz6BGofAD9At7zBa5e2sxnnTjttcBa2ntcAMqc8xKifcc8+fR56b1rzeH75C9OeSRN/51m/MeINI5+wDWqUapZx22tpa1+Jmh4w4ysAMCCngkX4q3oIErsUMlTwztM3pe0JNq55pIbFy3o5/R69bQ/+MzIgwumzY3i5Uxtq3IEGpocmdagQI+7vp1N5HFFCFeB7s5dPzR7bCVX8KkVZfpRBXZ7GP5iJLTVvNNk3VEetWTiP5LpGVOR6EYH8sItUGKmaPGKATe+3Q9GBsoRG99FLp5CKhu97V8XpxeEGm783NELJa3aGobAxzAEHd3Ho9O1iEkRxcxPPjwznFE9VesWCZ5pRgxEss6jMWFJNi4V8c2VvysjPahsUUz+IZlfkeA5xhr8TUfGXwFXs0ou+t1yjMSjwXNyTdRk6yOQo6saGMqq4xTyAEVz/nrPrbClmEvMBj9TL9/SypH62Z0Dspirmkg8/nY6GWPptrxjxBn6TLP3xwAMjFTpLXluKgVtaioTawbkqMXrngcrzyvFSguZCs2QrKMPIDfEpZwxyZf/hezjgOGLeYrfEL3wjCfx8DbWy52Mjnvr/cPsVAwfOIYK9OGbzu2tnbLKgdhQtyahb8zdie+zB3l/GTomMO1qUSU06+ihickUZIRI9jN1ppmXh1EgtEJoj+9vK/k/70zOxC0otmMEyas1EPA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(396003)(136003)(376002)(346002)(451199015)(2616005)(84970400001)(2906002)(83380400001)(38100700002)(41300700001)(91956017)(76116006)(8676002)(66446008)(66946007)(66556008)(6512007)(66476007)(33656002)(64756008)(26005)(53546011)(6506007)(478600001)(71200400001)(122000001)(6486002)(36756003)(186003)(5660300002)(8936002)(4326008)(316002)(86362001)(54906003)(38070700005)(6916009)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a6MZ2EAfl+eqTM1Fk5I198EcH+rwa/gDX0PNQ7FUEnuPbMK88fNh9zsKsFIT?= =?us-ascii?Q?bABwyZ4RcXLrJ0C81lrsIIEHtp5KLCtmcADmL08PJIcmzXhURTccySRSBGNT?= =?us-ascii?Q?Y63/mnybT68g3n1zvlVFHUUICb+xquv4XMsvAKBeJtykuJOMJ0jUeJlKuKYe?= =?us-ascii?Q?c0OYySy4A46Jb1a/Yte0J8fDUKVPRNKvjYEb4YxfQGE8jG62KkYo40n7FFm1?= =?us-ascii?Q?5IMRyOxvpPdd2UfdYlZHGz9FVbECiTjFm9mMarHGzckI8IUGeZCp5ijrG0+m?= =?us-ascii?Q?3ADO3gul4DH18V3jfFsBWTZasVRS3iF8pxl8E765bolQeGKuuqrzBmgJR/rm?= =?us-ascii?Q?PhQur/MwUA659uhc9i2vRzWvymNMh1QxLoNtH7B/ymzFT8sM5Tj8LSFHC1nj?= =?us-ascii?Q?NdGcIxkBs3BJSo2IqS585ZJlOrgN7FyEcRJ4DB/+z3wF4+cLsyezNMmATnho?= =?us-ascii?Q?C/pP3d6gGa/gXMh/h8F327/nGP2F1ME2vEppqdz9C0EHzsWGhusYEWZNHZYV?= =?us-ascii?Q?b5TVaAv4qloq11gs3mepN8pAfK6nCxbgv7rLf2WNaooWWG8+zYg1XZDh4c6i?= =?us-ascii?Q?H7L+x8Y11l/YL/MekOpVYqH++5yauDkIulMhonlbKQCDcM/a6FvhSROBWVR9?= =?us-ascii?Q?z3W/ja6Sgw9/eLXDOohdD8RTdoP4S+0NW0USyX4Xk4Fz/r5OUo9k8tSfMkVh?= =?us-ascii?Q?n26T3mfQzavB+MPbJkbewHCPFfDWlDz/B4ep8dW7T32IGgng0qJ8ka8s5v/b?= =?us-ascii?Q?Lhh+rANi8Bzz8z9P4w7i0UA/mmY2MSjvKPRJoeCJYk48BC3tabm26whbMpj/?= =?us-ascii?Q?hCcmF0dREGFowDBlJ0T2M+EddQXZeRRun/tBwbQezPpcZVNTKsdIhcom906P?= =?us-ascii?Q?5BUGu5+PPDa/Py36VR7P/cgD6Gad3RDk064wuLiMbR0+/1PFSeDIJKjGYGRd?= =?us-ascii?Q?C8PLCOaBw51l6LTGf9OEKWOYIw6vVKgfn8FSFHqT0dcA2P5b98o1y3f3tLV3?= =?us-ascii?Q?REaByjX718D0CHPNIr5UqGKh7vcfhZEAHsd29j1PjXYE+lI9tU/2eQiT12Cv?= =?us-ascii?Q?rjl2HzAmBoETVYk0HW5n+Xz6Aed7CEYihDTRYJzGjt40zAbjHhzTOAX8sU68?= =?us-ascii?Q?tTpN7fK8H+pDpKOdq3tH0ytj0+PnkFvCPXphWQCmHm8o4ijqHNjotz/3cpQF?= =?us-ascii?Q?WCvVtSCam5nE+0cr412pQs/8hoBhFBLtdovztTv2T9VPtl9VdB20ch/vlYzq?= =?us-ascii?Q?+lUjASp8MjVNZ0hunHqtR65RMYNufBuAYv3UC5YhuDzz5AJDCgly8VqUIB29?= =?us-ascii?Q?i2aTCuQ9t7VOWwxil4Oveg0cSWd0I8RPU66ikiHXvc9xgMHyAj+TYTe3dk2j?= =?us-ascii?Q?CY89J3P93LQXbftOcNswUbsFlgv7EtXu5rvnQGnKJOwNOxyWDk7/Q8YaNg7U?= =?us-ascii?Q?1HNMggVpoWZrkSuXVsd0lB8AOdrl5X4Y/2MT9D1sWb/iKf183II3c1fKJSA/?= =?us-ascii?Q?8FmKcLuwqPTqq6ruQLl1+EeRw9wVvNfmjIvtiZGnbqStsuqW4XR+anuIRr5x?= =?us-ascii?Q?E/BLCV85IIb2EAcuAq3ofObivk3SIGxTLVR+ompx7QzFVc0mS0jHshtGOZ2E?= =?us-ascii?Q?NA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <7EB2A28BFDF6FB4DA7715BBF61071D12@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB3784.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aaa72f0c-c8e0-41d5-9956-08dad2f1cb2d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 16:41:56.3592 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LJlOHReFqRSSDJ20bnoNHswoRi9RongsKeVeQr8W8mGpJ0MmrohCexXGzficmm29gA5izpQVSwWgAyg5agyz5P2ciEOXwRGPI3niOaojooE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10255 Hi Anthony, > On 30 Nov 2022, at 16:25, Anthony PERARD wrot= e: >=20 > On Wed, Nov 30, 2022 at 12:15:07PM +0000, Bertrand Marquis wrote: >> diff --git a/automation/build/Makefile b/automation/build/Makefile >> index a4b2b85178cf..72a5335baec1 100644 >> --- a/automation/build/Makefile >> +++ b/automation/build/Makefile >> @@ -1,13 +1,18 @@ >>=20 >> # the base of where these containers will appear >> REGISTRY :=3D registry.gitlab.com/xen-project/xen >> -CONTAINERS =3D $(subst .dockerfile,,$(wildcard */*.dockerfile)) >> +CONTAINERS =3D $(filter-out yocto/%,$(subst .dockerfile,,$(wildcard */*= .dockerfile))) >=20 > Nit: while there, could you use ":=3D" instead of "=3D" ? The value of > CONTAINERS is always going to be evaluated by make because it's used as > a prerequisite of "all", so we can at least tell make to evaluate the > value right away. Will do >=20 >> +CONTAINERS_EXTRA =3D >> DOCKER_CMD ?=3D docker >>=20 >> +include yocto/yocto.inc >> + >> help: >> @echo "Builds containers for building Xen based on different distros" >> @echo "To build one run 'make DISTRO/VERSION'. Available containers:" >> @$(foreach file,$(sort $(CONTAINERS)),echo ${file};) >> + @echo "Extra containers (not built using make all):" >> + @$(foreach file,$(sort $(CONTAINERS_EXTRA)),echo ${file};) >=20 > I wonder why the help syntax uses both ${} and $() for make variables, is > it to confuse people? :-) >=20 > You can write $(file) instead of ${file}, I think this would be less > confusing. I rarely see ${} been used in make, so seen ${} can be > confusing. I've learned (relearned?) this alternative syntax only a few > weeks ago as it's used by automake or autoconf. Definitely a typo, I will fix that in v6 (you have good eyes) >=20 >> @echo "To push container builds, set the env var PUSH" >>=20 >> %: %.dockerfile ## Builds containers >> @@ -16,5 +21,10 @@ help: >> $(DOCKER_CMD) push $(REGISTRY)/$(@D):$(@F); \ >> fi >>=20 >> -.PHONY: all >> +.PHONY: all clean >> all: $(CONTAINERS) >> + >> +# Remove generated dockerfiles for yocto >> +clean: >> + rm -f yocto/*.dockerfiles >=20 > There's an extra 's', I guess you want to remove "*.dockerfile" instead > of "*.dockerfiles". Ack >=20 > You could also add those to a .gitignore, even if there are likely to be > removed by make. Sure Thanks for the review Bertrand >=20 >=20 > Cheers, >=20 > --=20 > Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Nov 30 16:48:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 16:48:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450011.707114 (Exim 4.92) (envelope-from ) id 1p0QFz-0008Ua-Pz; Wed, 30 Nov 2022 16:48:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450011.707114; Wed, 30 Nov 2022 16:48:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QFz-0008UT-N5; Wed, 30 Nov 2022 16:48:23 +0000 Received: by outflank-mailman (input) for mailman id 450011; Wed, 30 Nov 2022 16:48:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QFy-0008UN-Tt for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 16:48:23 +0000 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cabdb18d-70ce-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 17:48:20 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 08:48:17 -0800 Received: from xwang-mobl1.amr.corp.intel.com (HELO [10.212.177.221]) ([10.212.177.221]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 08:48:16 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cabdb18d-70ce-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669826900; x=1701362900; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=uTrgL6k/pta00i+eT2v7N/wL/p9QjJsL21ekxDAFN/o=; b=D5LeVIK1DANp9O2XJGJ9P8HStbjxbeex6Je4MgKovO7PVj4PAMAd5+hz 3WRH1CdoWlGrg0Wl7KlQSc+Kk4/aMLEb2SD7Bc5rMWsYjkFTsh2R04sit xaReRcYDEsI/ZxtTT1GH/3aOseu7Ag60zklVJacswFSTm7w1u8EsjItD5 lNkZDQ7kkTJLhshlz4zRRtLfH0FFpYgYKUO3cMSrIWpVV9ByBUAHosYsM k1JSMgdR33YEchPXsNq2L7C+JQMT3suMoED+DUixDxWMRSpM1DtYrHG5t Etmml0MU7YF8Tfm/+a6wq7BCdB4PIPkxdyGHOWdsspoqaFPyMDZhwgQc7 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="314141269" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="314141269" X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="973170182" X-IronPort-AV: E=Sophos;i="5.96,207,1665471600"; d="scan'208";a="973170182" Message-ID: <4a0e9f91-8d8b-84bc-c9db-7265f5b65b63@intel.com> Date: Wed, 30 Nov 2022 08:48:14 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, jgross@suse.com, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Alex Chiang , Venkatesh Pallipadi , linux-acpi@vger.kernel.org References: <20221121102113.41893-1-roger.pau@citrix.com> <20221121102113.41893-2-roger.pau@citrix.com> <6b212148-4e3f-3ef6-7922-901175746d44@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/30/22 07:53, Roger Pau Monné wrote: > On Tue, Nov 29, 2022 at 09:43:53AM -0800, Dave Hansen wrote: >> On 11/21/22 02:21, Roger Pau Monne wrote: >>> When running as a Xen dom0 the number of CPUs available to Linux can >>> be different from the number of CPUs present on the system, but in >>> order to properly fetch processor performance related data _PDC must >>> be executed on all the physical CPUs online on the system. >> >> How is the number of CPUs available to Linux different? >> >> Is this a result of the ACPI tables that dom0 sees being "wrong"? > > Depends on the mode. This is all specific to Linux running as a Xen > dom0. > > For PV dom0 the ACPI tables that dom0 sees are the native ones, > however available CPUs are not detected based on the MADT, but using > hypercalls, see xen_smp_ops struct and the > x86_init.mpparse.get_smp_config hook used in smp_pv.c > (_get_smp_config()). > > For a PVH dom0 Xen provides dom0 with a crafted MADT table that does > only contain the CPUs available to dom0, and hence is likely different > from the native one present on the hardware. > > In any case, the dynamic tables dom0 sees where the Processor > objects/devices reside are not modified by Xen in any way, so the ACPI > Processors are always exposed to dom0 as present on the native > tables. > > Xen cannot parse the dynamic ACPI tables (neither should it, since > then it would act as OSPM), so it relies on dom0 to provide same data > present on those tables for Xen to properly manage the frequency and > idle states of the CPUs on the system. > >>> The current checks in processor_physically_present() result in some >>> processor objects not getting their _PDC methods evaluated when Linux >>> is running as Xen dom0. Fix this by introducing a custom function to >>> use when running as Xen dom0 in order to check whether a processor >>> object matches a CPU that's online. >> >> What is the end user visible effect of this problem and of the solution? > > Without this fix _PDC is only evaluated for the CPUs online from dom0 > point of view, which means that if dom0 is limited to 8 CPUs but the > system has 24 CPUs, _PDC will only get evaluated for 8 CPUs, and that > can have the side effect of the data then returned by _PSD method or > other methods being different between CPUs where _PDC was evaluated vs > CPUs where the method wasn't evaluated. Such mismatches can > ultimately lead to for example the CPU frequency driver in Xen not > initializing properly because the coordination methods between CPUs on > the same domain don't match. > > Also not evaluating _PDC prevents the OS (or Xen in this case) > from notifying ACPI of the features it supports. > > IOW this fix attempts to make sure all physically online CPUs get _PDC > evaluated, and in order to to that we need to ask the hypervisor if a > Processor ACPI ID matches an online CPU or not, because Linux doesn't > have that information when running as dom0. > > Hope the above makes sense and allows to make some progress on the > issue, sometimes it's hard to summarize without getting too > specific, Yes, writing changelogs is hard. :) Let's try though. I was missing some key pieces of background here. Believe it or not, I had no idea off the top of my head what _PDC was or why it's important. the information about _PDC being required on all processors was missing, as was the information about the dom0's incomplete concept of the available physical processors. == Background == In ACPI systems, the OS can direct power management, as opposed to the firmware. This OS-directed Power Management is called OSPM. Part of telling the firmware that the OS going to direct power management is making ACPI "_PDC" (Processor Driver Capabilities) calls. These _PDC calls must be made on every processor. If these _PDC calls are not completed on every processor it can lead to inconsistency and later failures in things like the CPU frequency driver. In a Xen system, the dom0 kernel is responsible for system-wide power management. The dom0 kernel is in charge of OSPM. However, the Xen hypervisor hides some processors information from the dom0 kernel. This is presumably done to ensure that the dom0 system has less interference with guests that want to use the other processors. == Problem == But, this leads to a problem: the dom0 kernel needs to run _PDC on all the processors, but it can't always see them. == Solution == In dom0 kernels, ignore the existing ACPI method for determining if a processor is physically present because it might not be accurate. Instead, ask the hypervisor for this information. This ensures that ... ---- Is that about right? From xen-devel-bounces@lists.xenproject.org Wed Nov 30 16:55:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 16:55:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450017.707136 (Exim 4.92) (envelope-from ) id 1p0QMX-0001wj-NX; Wed, 30 Nov 2022 16:55:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450017.707136; Wed, 30 Nov 2022 16:55:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QMX-0001wa-Kk; Wed, 30 Nov 2022 16:55:09 +0000 Received: by outflank-mailman (input) for mailman id 450017; Wed, 30 Nov 2022 16:55:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QMW-0001h8-Gm for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 16:55:08 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bd83c3e6-70cf-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 17:55:07 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd83c3e6-70cf-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669827307; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=mzelpp6BGU6o/XUMBaOnSaYdaYXaC5D7r7SG8hFEgRM=; b=iP9CtfXsTZQCMSs5Jf87J60B6MgimTwM3YnkRyHTVQnhHKfKEGTgqG1I z0UzQRlx0ulMt6XN2rlfdlpynf6FTzCPVSg1f30CAUih1B0WJHHlMRbpe 1Q9qrT1rR3f1q2mMgwwmQV/rKyTF2m0eYzPfYmTrGodCuxgGiwGsyn388 s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 86305928 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:QoajPqIRyYI7XtnQFE+R3JUlxSXFcZb7ZxGr2PjKsXjdYENS1WMEz 2IfXT+Eb//fajH8fd5/Ot61pk0GvcDRyoJrHFNlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wdmPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5+GVlq3 MQEOAorQQGoieWLnIuASLNz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLoXmuuyi2a5WDpfsF+P/oI84nTJzRw327/oWDbQUozUHp0IzxzIz o7A11rgLj8gFJuO8CrG1W+Bp+LAp3nRdKtHQdVU8dY12QbOlwT/EiY+WVKlrNGjh0W5WtYZL FYbkgI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW83uqCLjFaFHgbMoVg7ZJoA2xxv rOUoz/3LTV3iJm8cW6NzJG7vBi8PhVJFFQAPzBRGGPp/OLfiI00ixvOSPNqH6i0ksD5FFnM/ tyakMQtr+5N1JBWjs1X6XiC2mvx/caREmbZ8y2NBgqYAhVFiJlJjmBCwXzS9r5+IYmQVTFtV 1BUypHFvIji4Xxg/RFhodnh/pnzv55p0xWG2zaD+qXNEBzzk0NPhagKvFlDyL5Ba67ogwPBb k7Joh9275ROJnasZqIfS9vvVZV1kfa+SIq5Cq68gj9yjn5ZLlfvEMZGPB744owQuBJ0zfFX1 WmzLq5A8kr2+Yw4lWHrFo/xIJcgxzwkxHO7eHwI503P7FZqX1bMEe1tGALXPogEAFas/F29H yB3a5HblH2ykYTWPkHqzGLkBQlRfCJiWsCr85U/myzqClMOJVzNwsT5mdsJE7GJVYwP/gsU1 hlRgnNl9Wc= IronPort-HdrOrdr: A9a23:3f9LKqgEOMqhZWJZVPiYILU51XBQXusji2hC6mlwRA09TyXBrb HLoB1p726StN9xYgBZpTnuAsm9qB/nmKKdpLNhWItKPzOWw1dATrsSjrcKqgeIc0aVygce79 YDT0EUMrLN5C1B7PoSlzPXLz9P+rW6GeuT9IHjJj9WPHhXV50= X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="86305928" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Christian Lindig , David Scott , Edwin Torok , Rob Hoes Subject: [PATCH v2 3/6] tools/oxenstored: Rename some 'port' variables to 'remote_port' Date: Wed, 30 Nov 2022 16:54:52 +0000 Message-ID: <20221130165455.31125-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221130165455.31125-1-andrew.cooper3@citrix.com> References: <20221130165455.31125-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain This will make the logic clearer when we plumb local_port through these functions. While changing this, simplify the construct in Domains.create0 to separate the remote port handling from the interface. Signed-off-by: Andrew Cooper --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes v2: * New. --- tools/ocaml/xenstored/domains.ml | 26 ++++++++++++-------------- tools/ocaml/xenstored/process.ml | 12 ++++++------ tools/ocaml/xenstored/xenstored.ml | 8 ++++---- 3 files changed, 22 insertions(+), 24 deletions(-) diff --git a/tools/ocaml/xenstored/domains.ml b/tools/ocaml/xenstored/domains.ml index 17fe2fa25772..26018ac0dd3d 100644 --- a/tools/ocaml/xenstored/domains.ml +++ b/tools/ocaml/xenstored/domains.ml @@ -122,9 +122,9 @@ let cleanup doms = let resume _doms _domid = () -let create doms domid mfn port = +let create doms domid mfn remote_port = let interface = Xenctrl.map_foreign_range xc domid (Xenmmap.getpagesize()) mfn in - let dom = Domain.make domid mfn port interface doms.eventchn in + let dom = Domain.make domid mfn remote_port interface doms.eventchn in Hashtbl.add doms.table domid dom; Domain.bind_interdomain dom; dom @@ -133,18 +133,16 @@ let xenstored_kva = ref "" let xenstored_port = ref "" let create0 doms = - let port, interface = - ( - let port = Utils.read_file_single_integer !xenstored_port - and fd = Unix.openfile !xenstored_kva - [ Unix.O_RDWR ] 0o600 in - let interface = Xenmmap.mmap fd Xenmmap.RDWR Xenmmap.SHARED - (Xenmmap.getpagesize()) 0 in - Unix.close fd; - port, interface - ) - in - let dom = Domain.make 0 Nativeint.zero port interface doms.eventchn in + let remote_port = Utils.read_file_single_integer !xenstored_port in + + let interface = + let fd = Unix.openfile !xenstored_kva [ Unix.O_RDWR ] 0o600 in + let interface = Xenmmap.mmap fd Xenmmap.RDWR Xenmmap.SHARED (Xenmmap.getpagesize()) 0 in + Unix.close fd; + interface + in + + let dom = Domain.make 0 Nativeint.zero remote_port interface doms.eventchn in Hashtbl.add doms.table 0 dom; Domain.bind_interdomain dom; Domain.notify dom; diff --git a/tools/ocaml/xenstored/process.ml b/tools/ocaml/xenstored/process.ml index 72a79e9328dd..b2973aca2a82 100644 --- a/tools/ocaml/xenstored/process.ml +++ b/tools/ocaml/xenstored/process.ml @@ -558,10 +558,10 @@ let do_transaction_end con t domains cons data = let do_introduce con t domains cons data = if not (Connection.is_dom0 con) then raise Define.Permission_denied; - let (domid, mfn, port) = + let (domid, mfn, remote_port) = match (split None '\000' data) with - | domid :: mfn :: port :: _ -> - int_of_string domid, Nativeint.of_string mfn, int_of_string port + | domid :: mfn :: remote_port :: _ -> + int_of_string domid, Nativeint.of_string mfn, int_of_string remote_port | _ -> raise Invalid_Cmd_Args; in let dom = @@ -569,18 +569,18 @@ let do_introduce con t domains cons data = let edom = Domains.find domains domid in if (Domain.get_mfn edom) = mfn && (Connections.find_domain cons domid) != con then begin (* Use XS_INTRODUCE for recreating the xenbus event-channel. *) - edom.remote_port <- port; + edom.remote_port <- remote_port; Domain.bind_interdomain edom; end; edom else try - let ndom = Domains.create domains domid mfn port in + let ndom = Domains.create domains domid mfn remote_port in Connections.add_domain cons ndom; Connections.fire_spec_watches (Transaction.get_root t) cons Store.Path.introduce_domain; ndom with _ -> raise Invalid_Cmd_Args in - if (Domain.get_remote_port dom) <> port || (Domain.get_mfn dom) <> mfn then + if (Domain.get_remote_port dom) <> remote_port || (Domain.get_mfn dom) <> mfn then raise Domain_not_match let do_release con t domains cons data = diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml index 55071b49eccb..1f11f576b515 100644 --- a/tools/ocaml/xenstored/xenstored.ml +++ b/tools/ocaml/xenstored/xenstored.ml @@ -167,10 +167,10 @@ let from_channel_f chan global_f socket_f domain_f watch_f store_f = global_f ~rw | "socket" :: fd :: [] -> socket_f ~fd:(int_of_string fd) - | "dom" :: domid :: mfn :: port :: []-> + | "dom" :: domid :: mfn :: remote_port :: []-> domain_f (int_of_string domid) (Nativeint.of_string mfn) - (int_of_string port) + (int_of_string remote_port) | "watch" :: domid :: path :: token :: [] -> watch_f (int_of_string domid) (unhexify path) (unhexify token) @@ -209,10 +209,10 @@ let from_channel store cons doms chan = else warn "Ignoring invalid socket FD %d" fd in - let domain_f domid mfn port = + let domain_f domid mfn remote_port = let ndom = if domid > 0 then - Domains.create doms domid mfn port + Domains.create doms domid mfn remote_port else Domains.create0 doms in -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 16:55:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 16:55:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450016.707125 (Exim 4.92) (envelope-from ) id 1p0QMW-0001hO-HY; Wed, 30 Nov 2022 16:55:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450016.707125; Wed, 30 Nov 2022 16:55:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QMW-0001hH-Cp; Wed, 30 Nov 2022 16:55:08 +0000 Received: by outflank-mailman (input) for mailman id 450016; Wed, 30 Nov 2022 16:55:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QMU-0001h8-VT for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 16:55:07 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bb6406d4-70cf-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 17:55:05 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb6406d4-70cf-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669827304; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=z/izcCZYLALenFQZc+ciAhdGz2w/UXtld5npiWlVuFM=; b=Is2DDria1i3/f5QVBpl0lXRZsUP1aLpd3ze/2RYCWwu2cS5uykoC81sl wR4+5CKW+jvuz1+aRUKxJ/AYS/ySvVxZ+Dx0rUxdeL+nwjfvx3vk1/Toi 6F+b7q89NvC/uRBjWkKKlBrTbkfrMbYuo4r26F4YEfUylzs06Yebwo3jq U=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 85899572 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:rw8Izay4JRXhP7MlDNZ6t+c6xirEfRIJ4+MujC+fZmUNrF6WrkUOz 2MfWGCDOfaINmbwLdEjaYvg9h8Fu8WBzIIxTgo/pCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPqgT5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KU9s9 80aIShcVTGotse4/6+/b9BNr/12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiFZgFzxfF+ TiuE2LRHQ4nKN2SmTW/ryi8g/3kjCHYCaE4LejtnhJtqALKnTFCYPEMbnO3qOe0olSzUNVeL woT4CVGhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6k6nMsF2AbLoZ87YlvGGJsh gThc87V6SJHnp+XeHCU7uavjBiDHCYqMGsnXA4tdF5QizX8m70bghXKR9dlNae6iNzpBD39q wy3QDgCa6Y71pBSifjilbzTq3f1/8WSEFZpjunCdjj9hj6VcrJJcGBBBbLzyf9bZLiUQVCa1 JTvs5jPtbteZX1hecHkfQnsIF1Lz6zdWNE/qQQ1d3XEy9hK0yDLQGyoyGsiTHqFy+5dEdMTX GfduBlK+LhYN2awYKl8buqZUpp0nPe8S4q4CKyIMLKih6SdkifdpEmCgmbJjwjQfLUEy/lja f93j+7zZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjGI+ePiNKjiIquYe5dajOmN7lphJ5oVS2Jq 76zwePWkUQAOAA/CwGLmbMuwacidCNqX8mp+5EPL4Zu4GNOQQkcNhMY+pt5E6QNokifvrqgE q2VMqOA9GfCuA== IronPort-HdrOrdr: A9a23:oRJkH6y0SElKDWwFRqXxKrPwLL1zdoMgy1knxilNoRw8SKOlfq GV7ZImPHDP6Qr5NEtMpTnEAtjjfZq+z+8T3WByB9eftWDd0QPCRr2Kr7GSpgEIcxeOktK1vp 0PT0ERMrHN5CBB/KXH3DU= X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="85899572" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Christian Lindig , David Scott , Edwin Torok , Rob Hoes Subject: [PATCH v2 1/6] tools/oxenstored: Style fixes to Domain Date: Wed, 30 Nov 2022 16:54:50 +0000 Message-ID: <20221130165455.31125-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221130165455.31125-1-andrew.cooper3@citrix.com> References: <20221130165455.31125-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain This file has some style problems so severe that they interfere with the readability of the subsequent bugfix patches. Fix these issues ahead of time, to make the subsequent changes more readable. No functional change. Signed-off-by: Andrew Cooper --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes v2: * New --- tools/ocaml/xenstored/domain.ml | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/tools/ocaml/xenstored/domain.ml b/tools/ocaml/xenstored/domain.ml index 81cb59b8f1a2..ab08dcf37f62 100644 --- a/tools/ocaml/xenstored/domain.ml +++ b/tools/ocaml/xenstored/domain.ml @@ -57,17 +57,16 @@ let is_paused_for_conflict dom = dom.conflict_credit <= 0.0 let is_free_to_conflict = is_dom0 let string_of_port = function -| None -> "None" -| Some x -> string_of_int (Xeneventchn.to_int x) + | None -> "None" + | Some x -> string_of_int (Xeneventchn.to_int x) let dump d chan = fprintf chan "dom,%d,%nd,%d\n" d.id d.mfn d.remote_port -let notify dom = match dom.port with -| None -> - warn "domain %d: attempt to notify on unknown port" dom.id -| Some port -> - Event.notify dom.eventchn port +let notify dom = + match dom.port with + | None -> warn "domain %d: attempt to notify on unknown port" dom.id + | Some port -> Event.notify dom.eventchn port let bind_interdomain dom = begin match dom.port with @@ -84,8 +83,7 @@ let close dom = | None -> () | Some port -> Event.unbind dom.eventchn port end; - Xenmmap.unmap dom.interface; - () + Xenmmap.unmap dom.interface let make id mfn remote_port interface eventchn = { id = id; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 16:55:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 16:55:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450018.707147 (Exim 4.92) (envelope-from ) id 1p0QMb-0002FV-4i; Wed, 30 Nov 2022 16:55:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450018.707147; Wed, 30 Nov 2022 16:55:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QMb-0002FN-0R; Wed, 30 Nov 2022 16:55:13 +0000 Received: by outflank-mailman (input) for mailman id 450018; Wed, 30 Nov 2022 16:55:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QMY-00028d-Ux for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 16:55:10 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be61cc1a-70cf-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 17:55:09 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be61cc1a-70cf-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669827309; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=m3N373zQMCSuoA562ubDzuK9w6uDDTqYPMgngEFce1I=; b=fms+vslK6IKOD+vkSNBLLioGfyhTLfrwEvxo1CvEI/Igfp9Ls6mRBysg BFEp+i0wA0dK0Erm4Dw0L21L6cIYrmk0oZ8SZsCX41VEDIneOv7jZKJJc d7WTL4GfUtoR0XFnl1Ex9m+GsErQGTlxk+b/oCFZUfr2tLCNRvyg1BU+N k=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 85447238 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:q9OwQK/7JjS3R8cTsVQoDrUDjX6TJUtcMsCJ2f8bNWPcYEJGY0x3z 2dMXziFPPiIZzegeY12YYvioUsA6MPWzoViSgdkr3o8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKsT5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklw1 dwgKxpQbyytnqWP0qyDesI1g9YaeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGM0Yn1lQ/UfrSmM+BgHXlfiIeg1WSvactuEDYzRBr0airO93QEjCPbZUIwhrH/ DmWl4j/Kk8/b+SG0TGXyGK1h6zdjD/2dK42BaLto5aGh3XMnzdOWXX6T2CTrfCnh2akVtlYK khS/TAhxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxO4QfZmcfMpp87pZwHGF0k A/S9z/0OdBxmIO1aUqe3OqVkR2rfhEHM1cyTnYBXzJQtrEPv7oPph7IS99iFou8gdv0BSz8z li2kcQuu1kApZVVjvvmpDgrlxrp/8GUFVBtum07S0r/tmtEiJiZi5tEALQxxdJJN86nQ1aIp xDocODOvblVXflheMFgKdjh/Y1FBd7faFUwYnY1RfHNEghBHFb9Fb28GBkkeC9U3j8sIFcFm nP7twJL/4N0N3C3d6JxaI/ZI510k/m/SYq7C66IMoQmjn1NmOmvpnkGiam4hjCFraTRuftnZ cfznTiEUh729piLPBLpHrxAgNfHNwg1xH/JRICT8vhU+eP2WZJhcp9caAHmRrlgvMu5TPD9r 4432z2il08OD4UTo0D/reYuELz9BSFgVMqv9JwKLrfrz8gPMDhJNsI9CIgJI+RN95m5XM+Ul p1hcie0EGbCuEA= IronPort-HdrOrdr: A9a23:y9w/SqAHcX70Ak3lHemd55DYdb4zR+YMi2TDj3oBLSC9Afbo8P xG/c5rrSMc5wxwZJhNo7290ey7MBbhHP1OkPIs1NWZLWrbUQKTRekIh7cKgQeQeREWndQz6U 4USclD4arLY2SS4/yX3ODyKadH/DDOytHQudvj X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="85447238" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Christian Lindig , David Scott , Edwin Torok , Rob Hoes Subject: [PATCH v2 2/6] tools/oxenstored: Bind the DOM_EXC VIRQ in in Event.init() Date: Wed, 30 Nov 2022 16:54:51 +0000 Message-ID: <20221130165455.31125-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221130165455.31125-1-andrew.cooper3@citrix.com> References: <20221130165455.31125-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Xenstored always needs to bind the DOM_EXC VIRQ. Instead of doing it shortly after the call to Event.init(), do it in the init() call itself. This removes the need for the field to be a mutable option. It will also simplify a future change to restore both parts from the live update record, rather than re-initialising them from scratch. Rename the field from virq_port (which could be any VIRQ) to it's proper name. Signed-off-by: Andrew Cooper --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes v2: * New. --- tools/ocaml/xenstored/event.ml | 9 ++++++--- tools/ocaml/xenstored/xenstored.ml | 4 +--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tools/ocaml/xenstored/event.ml b/tools/ocaml/xenstored/event.ml index ccca90b6fc4f..a3be296374ff 100644 --- a/tools/ocaml/xenstored/event.ml +++ b/tools/ocaml/xenstored/event.ml @@ -17,12 +17,15 @@ (**************** high level binding ****************) type t = { handle: Xeneventchn.handle; - mutable virq_port: Xeneventchn.t option; + domexc: Xeneventchn.t; } -let init () = { handle = Xeneventchn.init (); virq_port = None; } +let init () = + let handle = Xeneventchn.init () in + let domexc = Xeneventchn.bind_dom_exc_virq handle in + { handle; domexc } + let fd eventchn = Xeneventchn.fd eventchn.handle -let bind_dom_exc_virq eventchn = eventchn.virq_port <- Some (Xeneventchn.bind_dom_exc_virq eventchn.handle) let bind_interdomain eventchn domid port = Xeneventchn.bind_interdomain eventchn.handle domid port let unbind eventchn port = Xeneventchn.unbind eventchn.handle port let notify eventchn port = Xeneventchn.notify eventchn.handle port diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml index c5dc7a28d082..55071b49eccb 100644 --- a/tools/ocaml/xenstored/xenstored.ml +++ b/tools/ocaml/xenstored/xenstored.ml @@ -397,7 +397,6 @@ let _ = if cf.restart && Sys.file_exists Disk.xs_daemon_database then ( let rwro = DB.from_file store domains cons Disk.xs_daemon_database in info "Live reload: database loaded"; - Event.bind_dom_exc_virq eventchn; Process.LiveUpdate.completed (); rwro ) else ( @@ -413,7 +412,6 @@ let _ = if cf.domain_init then ( Connections.add_domain cons (Domains.create0 domains); - Event.bind_dom_exc_virq eventchn ); rw_sock ) in @@ -451,7 +449,7 @@ let _ = let port = Event.pending eventchn in debug "pending port %d" (Xeneventchn.to_int port); finally (fun () -> - if Some port = eventchn.Event.virq_port then ( + if port = eventchn.Event.domexc then ( let (notify, deaddom) = Domains.cleanup domains in List.iter (Store.reset_permissions store) deaddom; List.iter (Connections.del_domain cons) deaddom; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 16:55:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 16:55:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450019.707151 (Exim 4.92) (envelope-from ) id 1p0QMb-0002I2-Dr; Wed, 30 Nov 2022 16:55:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450019.707151; Wed, 30 Nov 2022 16:55:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QMb-0002HO-8e; Wed, 30 Nov 2022 16:55:13 +0000 Received: by outflank-mailman (input) for mailman id 450019; Wed, 30 Nov 2022 16:55:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QMZ-00028d-Mj for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 16:55:11 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be64cd28-70cf-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 17:55:09 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be64cd28-70cf-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669827309; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=162zeh5jE/ckxoWntMvVQlDX4NJ4oVXrRVjHrDWZ9Fo=; b=ZmlZbCuLr9JKIWLrjn16+ZwiuTusmAgXC+WjrxoJN6Ygzou40y/jPGrJ Uu6gBiZ1PAVLXSDNty7cC8ucUka65gcHzCL0IHZxGWoRYlsPsf/hg6+xK qkRP/2px2gOEIb/nO+ZIkovUNa5isoZSF6bIdYotQNTSuFw69BuF2hzTl w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 84923297 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:bhMNHqwae0FXQQaN3Al6t+c6xirEfRIJ4+MujC+fZmUNrF6WrkVWm GIZCjyPOP2DamGmfY13PIWzpkJSsJWHzIJkSgdlryAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPqgT5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KSJA0 c0neCsGUhqO2N2Kmb+0bdEzrf12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiFZkExB3C9 z2uE2LRHDZDJte64iO8yCyd3/DDh3rndI01PejtnhJtqALKnTFCYPEMbnO3qOe0olSzUNVeL woT4CVGhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6k6nMsF2AbLoZ87YlvGGJsh gThc87V6SJH87OxeE3N7byopz7tBhRMIGAlXXAvdF5QizX8m70bghXKR9dlNae6iNzpBD39q wy3QDgCa6Y71pBSifjilbzTq3f1/8WSEFZpjunCdjj9hj6VcrJJcGBBBbLzyf9bZLiUQVCa1 JTvs5jPtbteZX1hecHkfQnsIF1Lz6zdWNE/qQQ1d3XEy9hK0yDLQGyoyGsiTHqFy+5dEdMTX GfduBlK+LhYN2awYKl8buqZUpp0nPe8S4q4CKyIMLKih6SdkifdpEmCgmbJjwjQfLUEy/lja f93j+7zZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjGI+ePiNKjiIquYe5dajOmN7lphJ5oVS2Jq 76zwePWkUQAOAA/CwGLmbMuwacidCNqX8mp+5EPL4Zu4GNOQQkcNhMY+pt5E6QNokifvr6gE q2VMqOA9GfCuA== IronPort-HdrOrdr: A9a23:PePzL60PPY1Kd+Mz3f+a+gqjBJokLtp133Aq2lEZdPUzSKOlfq GV8sjzsCWetN9/YgBCpTntAtjjfZq+z/9ICPcqTNCftWDd0QPFEGgI1/qH/9SPIVyaygck78 ddWpk7MvvWLXI/oOTbxE2DM/gGqePszImYwd3ZyHdmCSVEApsM0ztE X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="84923297" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Christian Lindig , David Scott , Edwin Torok , Rob Hoes Subject: [PATCH v2 0/6] More Oxenstored live update fixes Date: Wed, 30 Nov 2022 16:54:49 +0000 Message-ID: <20221130165455.31125-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Patch 6 is already acked and queued for 4.18, but testing has identified it was incomplete. Specifically, the DOM_EXC virq needs handling across live update, otherwise domain shutdown events go awry. Therefore, this v2 series is presented with 5 patches of refactoring, leading up to the virq correction in patch 6. Andrew Cooper (5): tools/oxenstored: Style fixes to Domain tools/oxenstored: Bind the DOM_EXC VIRQ in in Event.init() tools/oxenstored: Rename some 'port' variables to 'remote_port' tools/oxenstored: Implement Domain.rebind_evtchn tools/oxenstored: Rework Domain evtchn handling to use port_pair Edwin Török (1): tools/oxenstored: Keep /dev/xen/evtchn open across live update tools/ocaml/xenstored/connections.ml | 9 +--- tools/ocaml/xenstored/domain.ml | 86 ++++++++++++++++++++-------------- tools/ocaml/xenstored/domains.ml | 31 ++++++------- tools/ocaml/xenstored/event.ml | 20 ++++++-- tools/ocaml/xenstored/process.ml | 16 +++---- tools/ocaml/xenstored/xenstored.ml | 89 +++++++++++++++++++++++------------- 6 files changed, 149 insertions(+), 102 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 16:55:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 16:55:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450020.707157 (Exim 4.92) (envelope-from ) id 1p0QMb-0002NR-Qp; Wed, 30 Nov 2022 16:55:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450020.707157; Wed, 30 Nov 2022 16:55:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QMb-0002Kg-JF; Wed, 30 Nov 2022 16:55:13 +0000 Received: by outflank-mailman (input) for mailman id 450020; Wed, 30 Nov 2022 16:55:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QMZ-0001h8-TM for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 16:55:12 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bffddb96-70cf-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 17:55:10 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bffddb96-70cf-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669827310; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=dD1YNLn+pJ3fr6aL1kBtVoehn7b49zfM4pfTGJrb8DE=; b=heBqp1BQSb8OnPyyurxJ0kIzfDRfUz7j2czMhN4ywcmQdozdkU6OMvqP 3qPKp0KGfkl72LToYz8Jzo5FPeqyGHnOAutHtyIXWHjbCo04JLoUXPx25 zEuucMzaSO1VXtrD//8zC9fGB5KV7KbKrFMmfnTogJhcyYTSYuzWlu25j o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 85899597 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:y0M+66lAKnZxRRQmg86dt07o5gyMJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIWCzjSa/rcNzH3Lt9+aYq38xsCv5XcyYdmSwI+rHw8QiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5weGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 f4EGS8PSiibvuOzx761DbNco/59cMa+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsfYT/7C7pn9AusrlD5fydVtxS+oq0v7nKI5AdwzKLsIJzefdniqcB9zhvI9 zObrjuR7hcyBtODkzu8zG6XvfaUsHrRRqYgNrGx+as/6LGU7jNKU0BHPbehmtG1g1Czc8hSI EsV/mwpt6da3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQA5oiVpMYJ88pVsHHpzi wHPz4iB6SFTXKO9S26s6bWwlSuLOC0SIWFFPx8hd1VZ7Iy2yG0stS7nQtFmGa+zq9T6HzDs3 jyHxBQDa6UvYd0jjPviow2e6964jt2QF1NuuF2LNo6wxlkhDLNJcbBE/rQyARxoCI+CBmeMs 3Ef8yR1xLBfVMrd/MBhrQhkIV1I2xpnGGeE6bKMN8N7n9hIx5JEVd443d2GDB01WvvogBewC KMphStf5YVIIFyhZrJtboS6BqwClPa+RIu5CK6JMIYSPPCdkTNrGgk0PSZ8OEi0wCARfVwXY 8/HIa5A815FYUiY8NZGb7hEiuJ6rszP7WjSWYr633yaPUm2PRaopUM+GALWNIgRtfrUyDg5B v4Db6NmPT0DCryhCsQWmKZPRW03wY8TXMun8ZUIJrPbe2KL2ggJUpfs/F/oQKQ994w9qwsC1 i3VtpNwoLYnuUD6FA== IronPort-HdrOrdr: A9a23:YlkT2KobVUVd3nNO11rWDYMaV5oZeYIsimQD101hICG9E/bo9f xG+c5x6faaslsssR0b9exoQZPwOU80lqQFgrX5X43CYOCOggLBRr2Ki7GM/9SKIU3DH4Bmu5 uIPJIObOEYSWIK6/oT3WGDYrMdKObuytHQuQ/9p00dKj1XVw== X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="85899597" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Christian Lindig , David Scott , Edwin Torok , Rob Hoes Subject: [PATCH v2 5/6] tools/oxenstored: Rework Domain evtchn handling to use port_pair Date: Wed, 30 Nov 2022 16:54:54 +0000 Message-ID: <20221130165455.31125-6-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221130165455.31125-1-andrew.cooper3@citrix.com> References: <20221130165455.31125-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Inter-domain event channels are always a pair of local and remote ports. Right now the handling is asymmetric, caused by the fact that the evtchn is bound after the associated Domain object is constructed. First, move binding of the event channel into the Domain.make() constructor. This means the local port no longer needs to be an option. It also removes the final callers of Domain.bind_interdomain. Next, introduce a new port_pair type to encapsulate the fact that these two should be updated together, and replace the previous port and remote_port fields. This refactoring also changes the Domain.get_port interface (removing an option) so take the opportunity to name it get_local_port instead. Also, this fixes a use-after-free risk with Domain.close. Once the evtchn has been unbound, the same local port number can be reused for a different purpose, so explicitly invalidate the ports to prevent their accidental misuse in the future. This also cleans up some of the debugging, to always print a port pair. Signed-off-by: Andrew Cooper --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes v2: * New --- tools/ocaml/xenstored/connections.ml | 9 +---- tools/ocaml/xenstored/domain.ml | 75 ++++++++++++++++++------------------ tools/ocaml/xenstored/domains.ml | 2 - 3 files changed, 39 insertions(+), 47 deletions(-) diff --git a/tools/ocaml/xenstored/connections.ml b/tools/ocaml/xenstored/connections.ml index 7d68c583b43a..a80ae0bed2ce 100644 --- a/tools/ocaml/xenstored/connections.ml +++ b/tools/ocaml/xenstored/connections.ml @@ -48,9 +48,7 @@ let add_domain cons dom = let xbcon = Xenbus.Xb.open_mmap ~capacity (Domain.get_interface dom) (fun () -> Domain.notify dom) in let con = Connection.create xbcon (Some dom) in Hashtbl.add cons.domains (Domain.get_id dom) con; - match Domain.get_port dom with - | Some p -> Hashtbl.add cons.ports p con; - | None -> () + Hashtbl.add cons.ports (Domain.get_local_port dom) con let select ?(only_if = (fun _ -> true)) cons = Hashtbl.fold (fun _ con (ins, outs) -> @@ -97,10 +95,7 @@ let del_domain cons id = let con = find_domain cons id in Hashtbl.remove cons.domains id; (match Connection.get_domain con with - | Some d -> - (match Domain.get_port d with - | Some p -> Hashtbl.remove cons.ports p - | None -> ()) + | Some d -> Hashtbl.remove cons.ports (Domain.get_local_port d) | None -> ()); del_watches cons con; Connection.close con diff --git a/tools/ocaml/xenstored/domain.ml b/tools/ocaml/xenstored/domain.ml index d59a9401e211..ecdd65f3209a 100644 --- a/tools/ocaml/xenstored/domain.ml +++ b/tools/ocaml/xenstored/domain.ml @@ -19,14 +19,31 @@ open Printf let debug fmt = Logging.debug "domain" fmt let warn fmt = Logging.warn "domain" fmt +(* An event channel port pair. The remote port, and the local port it is + bound to. *) +type port_pair = +{ + local: Xeneventchn.t; + remote: int; +} + +(* Sentinal port_pair with both set to EVTCHN_INVALID *) +let invalid_ports = +{ + local = Xeneventchn.of_int 0; + remote = 0 +} + +let string_of_port_pair p = + sprintf "(l %d, r %d)" (Xeneventchn.to_int p.local) p.remote + type t = { id: Xenctrl.domid; mfn: nativeint; interface: Xenmmap.mmap_interface; eventchn: Event.t; - mutable remote_port: int; - mutable port: Xeneventchn.t option; + mutable ports: port_pair; mutable bad_client: bool; mutable io_credit: int; (* the rounds of ring process left to do, default is 0, usually set to 1 when there is work detected, could @@ -41,8 +58,8 @@ let is_dom0 d = d.id = 0 let get_id domain = domain.id let get_interface d = d.interface let get_mfn d = d.mfn -let get_remote_port d = d.remote_port -let get_port d = d.port +let get_remote_port d = d.ports.remote +let get_local_port d = d.ports.local let is_bad_domain domain = domain.bad_client let mark_as_bad domain = domain.bad_client <- true @@ -56,54 +73,36 @@ let is_paused_for_conflict dom = dom.conflict_credit <= 0.0 let is_free_to_conflict = is_dom0 -let string_of_port = function - | None -> "None" - | Some x -> string_of_int (Xeneventchn.to_int x) - let dump d chan = - fprintf chan "dom,%d,%nd,%d\n" d.id d.mfn d.remote_port + fprintf chan "dom,%d,%nd,%d\n" d.id d.mfn d.ports.remote let rebind_evtchn d remote_port = - begin match d.port with - | None -> () - | Some p -> Event.unbind d.eventchn p - end; + Event.unbind d.eventchn d.ports.local; let local = Event.bind_interdomain d.eventchn d.id remote_port in - debug "domain %d rebind (l %s, r %d) => (l %d, r %d)" - d.id (string_of_port d.port) d.remote_port - (Xeneventchn.to_int local) remote_port; - d.remote_port <- remote_port; - d.port <- Some (local) + let ports = { local; remote = remote_port } in + debug "domain %d rebind %s => %s" + d.id (string_of_port_pair d.ports) (string_of_port_pair ports); + d.ports <- ports let notify dom = - match dom.port with - | None -> warn "domain %d: attempt to notify on unknown port" dom.id - | Some port -> Event.notify dom.eventchn port - -let bind_interdomain dom = - begin match dom.port with - | None -> () - | Some port -> Event.unbind dom.eventchn port - end; - dom.port <- Some (Event.bind_interdomain dom.eventchn dom.id dom.remote_port); - debug "bound domain %d remote port %d to local port %s" dom.id dom.remote_port (string_of_port dom.port) - + Event.notify dom.eventchn dom.ports.local let close dom = - debug "domain %d unbound port %s" dom.id (string_of_port dom.port); - begin match dom.port with - | None -> () - | Some port -> Event.unbind dom.eventchn port - end; + debug "domain %d unbind %s" dom.id (string_of_port_pair dom.ports); + Event.unbind dom.eventchn dom.ports.local; + dom.ports <- invalid_ports; Xenmmap.unmap dom.interface -let make id mfn remote_port interface eventchn = { +let make id mfn remote_port interface eventchn = + let local = Event.bind_interdomain eventchn id remote_port in + let ports = { local; remote = remote_port } in + debug "domain %d bind %s" id (string_of_port_pair ports); +{ id = id; mfn = mfn; - remote_port = remote_port; + ports; interface = interface; eventchn = eventchn; - port = None; bad_client = false; io_credit = 0; conflict_credit = !Define.conflict_burst_limit; diff --git a/tools/ocaml/xenstored/domains.ml b/tools/ocaml/xenstored/domains.ml index 26018ac0dd3d..2ab0c5f4d8d0 100644 --- a/tools/ocaml/xenstored/domains.ml +++ b/tools/ocaml/xenstored/domains.ml @@ -126,7 +126,6 @@ let create doms domid mfn remote_port = let interface = Xenctrl.map_foreign_range xc domid (Xenmmap.getpagesize()) mfn in let dom = Domain.make domid mfn remote_port interface doms.eventchn in Hashtbl.add doms.table domid dom; - Domain.bind_interdomain dom; dom let xenstored_kva = ref "" @@ -144,7 +143,6 @@ let create0 doms = let dom = Domain.make 0 Nativeint.zero remote_port interface doms.eventchn in Hashtbl.add doms.table 0 dom; - Domain.bind_interdomain dom; Domain.notify dom; dom -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 16:55:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 16:55:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450021.707164 (Exim 4.92) (envelope-from ) id 1p0QMc-0002Xj-Cy; Wed, 30 Nov 2022 16:55:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450021.707164; Wed, 30 Nov 2022 16:55:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QMc-0002Vl-76; Wed, 30 Nov 2022 16:55:14 +0000 Received: by outflank-mailman (input) for mailman id 450021; Wed, 30 Nov 2022 16:55:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QMa-00028d-Mr for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 16:55:12 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c03f4542-70cf-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 17:55:10 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c03f4542-70cf-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669827310; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=5iFdPLx5Ne+VS5VelIwx4FrDJLK/XUFQknR4+A17ij0=; b=YqGvEO7i6oa3ke2P3GX4m7jo/8fokxWZxbtK/AFGJQbTa+d7qYULTwda eVzsOn7RkHAL226qlXwS1OAacL7yx/OuP5txnMgRdQ5AXpu0zzyaepwSN hAR+y5iVFpKMe0A2xj1LCmX/xmHCzmk95SYpwKe4uQqboCiu5W3yf7jJ7 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 85447248 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:U5sKI62u7wZwXFuKhvbD5d5xkn2cJEfYwER7XKvMYLTBsI5bpzUFm GEaWTiGO/fZZDSnLYskaonn9xwE6JHTmNZqGgJlpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVlPagQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfAnlV1 qEZAS80aBXS3bmPwI2lYdl2v5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKkSbC/FMEg5/5JYWteGknHTgNRZfr0qYv/Ef6GnP1g1hlrPqNbI5f/TaGJkJwRzE9 goq+UzyHDNDFuHB4wCH43mTmsnskSH6B9I7QejQGvlC3wTImz175ActfVeyv/SRkEO1XNNbb UsO9UIGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbizt1HUBdEGQHMoZ/8pZrG3p6j Tdlgu8FGxRsqKa2FHO06Y6SqGLoYhEVEnEpVTU9GF5tD8bYnKk/iRfGT9BGGaGzj8HoFTyY/ w1mvBTSlJ1I05dVivzTEUTvxmv1+8OXFlJdChD/BDrN0+9vWGKyi2VEA3D/5O0IEouWR0LpU JMsy5nHt7Bm4X1geUWwrAQx8FOBva7t3N702wQH83wdG9OFpRaekXh4um0WGauQGp9slcXVS EHSoxhNw5RYIWGna6R6C6roVZp7kvS+S4m7CqyKBjarXnSXXFXflM2JTRfAt10BbWB2yf1vU XtlWZnE4Ykm5VRPk2PtGrZ1PU4DzSEi32LDLa0XPDz+uYdykEW9EO9fWHPXN7BR0U9xiFmNm zqpH5fQmko3vSyXSnW/zLP/2nhTdilhXM+m9pQOHgNBSyI/cFwc5zbq6etJU+RYc259z48kI lnVtpdk9WfC IronPort-HdrOrdr: A9a23:B5XRNaO4lEXGs8BcTvCjsMiBIKoaSvp037By7TEUdfUnSL3+qy nOpoVi6faaslYssR0b9OxofZPwJE80lqQFmrX5X43SPzUO0VHAROoJ0WKh+UyDJ8SUzIFgPN JbEpSWf+efMbEVt6rHCUKDYrAdKZG8gdmVuds= X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="85447248" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Christian Lindig , David Scott , Edwin Torok , Rob Hoes Subject: [PATCH v2 4/6] tools/oxenstored: Implement Domain.rebind_evtchn Date: Wed, 30 Nov 2022 16:54:53 +0000 Message-ID: <20221130165455.31125-5-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221130165455.31125-1-andrew.cooper3@citrix.com> References: <20221130165455.31125-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Generally speaking, the event channel local/remote port is fixed for the lifetime of the associated domain object. The exception to this is a secondary XS_INTRODUCE (defined to re-bind to a new event channel) which pokes around at the domain object's internal state. We need to refactor the evtchn handling to support live update, so start by moving the relevant manipulation into Domain. No practical change. Signed-off-by: Andrew Cooper --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes Note: This change deliberately doesn't reuse Domain.bind_interdomain, which is removed by the end of the refactoring. v2: * New. --- tools/ocaml/xenstored/domain.ml | 12 ++++++++++++ tools/ocaml/xenstored/process.ml | 6 ++---- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/tools/ocaml/xenstored/domain.ml b/tools/ocaml/xenstored/domain.ml index ab08dcf37f62..d59a9401e211 100644 --- a/tools/ocaml/xenstored/domain.ml +++ b/tools/ocaml/xenstored/domain.ml @@ -63,6 +63,18 @@ let string_of_port = function let dump d chan = fprintf chan "dom,%d,%nd,%d\n" d.id d.mfn d.remote_port +let rebind_evtchn d remote_port = + begin match d.port with + | None -> () + | Some p -> Event.unbind d.eventchn p + end; + let local = Event.bind_interdomain d.eventchn d.id remote_port in + debug "domain %d rebind (l %s, r %d) => (l %d, r %d)" + d.id (string_of_port d.port) d.remote_port + (Xeneventchn.to_int local) remote_port; + d.remote_port <- remote_port; + d.port <- Some (local) + let notify dom = match dom.port with | None -> warn "domain %d: attempt to notify on unknown port" dom.id diff --git a/tools/ocaml/xenstored/process.ml b/tools/ocaml/xenstored/process.ml index b2973aca2a82..2ea940d7e2d5 100644 --- a/tools/ocaml/xenstored/process.ml +++ b/tools/ocaml/xenstored/process.ml @@ -567,11 +567,9 @@ let do_introduce con t domains cons data = let dom = if Domains.exist domains domid then let edom = Domains.find domains domid in - if (Domain.get_mfn edom) = mfn && (Connections.find_domain cons domid) != con then begin + if (Domain.get_mfn edom) = mfn && (Connections.find_domain cons domid) != con then (* Use XS_INTRODUCE for recreating the xenbus event-channel. *) - edom.remote_port <- remote_port; - Domain.bind_interdomain edom; - end; + Domain.rebind_evtchn edom remote_port; edom else try let ndom = Domains.create domains domid mfn remote_port in -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 16:55:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 16:55:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450022.707191 (Exim 4.92) (envelope-from ) id 1p0QMh-0003RT-Ps; Wed, 30 Nov 2022 16:55:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450022.707191; Wed, 30 Nov 2022 16:55:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QMh-0003RI-Lp; Wed, 30 Nov 2022 16:55:19 +0000 Received: by outflank-mailman (input) for mailman id 450022; Wed, 30 Nov 2022 16:55:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QMg-00028d-MN for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 16:55:18 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c2e3d686-70cf-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 17:55:16 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2e3d686-70cf-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669827316; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4h8p5ZL96QWbBFw35D5N8A/MjngJvTY0xr47198+Zqo=; b=K1CwKvxzDkmhSMgUwTNfPqbwjMf6/d3Zvsglj0NiM/ncTYhpi7qknguk v7G5Rg9UUFkwL88d0zIP0LrDajyuIeGSLjLyo0Mc+AfWtNEoUTX1yHcXV C4GpTFE+RRPhFRekUNJUqQkZzRPno/k1nsaspWr3lgJQBp5jvlHh9apkS Q=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 88419233 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:klQNaaOKBZGGsdfvrR2ol8FynXyQoLVcMsEvi/4bfWQNrUoj1WYPm zEcXG2EPanbNjGnfNEnOY7ip05U7MfTztU1Twto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5QRmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0stzGEMVq cQgETcmdwumwLiH+ZKkSOY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w/N3wsYDUWUrsTILs4kP2lmT/UdDpApUjOjaE2/3LS3Ep6172F3N/9KozWHJQPxR3wS mTu1lXUCUoLDuSmzBmgrni3hrbxrwL8R9dHfFG/3qEz2wDCroAJMzUaXEW2ieO0gUm/X5RYM UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcLpDx2xXzZeCGQbMZp/6ZFwFWdCO kK1c83BKDh2kubJcUqk8ZyNthb1YxksDXAAanpRJeca2OXLrIY2hxPJa99sFq+pk9H4cQ3NL yC2QDsW3OtK05NSv0mv1RWe2m/3+MCVJuIgzl+PNl9J+D+Vc2JMi2aAzVHApchNI4+CJrVql ChVwpPOhAzi4HzkqcBsfAnvNOvxjxpmGGeG6bKKI3XG32rFxpJbVdoMiAyS3W8wWir+RRfnY VXIpSRa74JJMX2hYMdfOtzvWpt2k/a9S4i5CJg4i+aihLArLGdrGwk3NSatM53FyhBwwcnTx 7/EGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvuqWPTlnyaPU6lTCfNE98taQLeBt3VGYvY+G05B f4DbZrVo/ieOcWiChTqHXk7dAtbdyFkVc2u8qS6tIere2JbJY3oMNeJqZtJRmCvt/09ejvgl p1lZnJl9Q== IronPort-HdrOrdr: A9a23:X3nigaiwbQqmKpLzJgOaLmQ1h3BQXvIji2hC6mlwRA09TyX+ra +TdZUguyMc7Qx7ZJhOo6HiBEDtewK/yXcX2+gs1MmZLW7bUQKTRekP0WKI+UyFJ8SRzJ856U 4ZSchDIey1N35crey/zSuZN5Ib4PehmZrDuc7ui01qSgFhL4VOhj0VNjqm X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="88419233" From: Andrew Cooper To: Xen-devel CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Andrew Cooper" , Christian Lindig , David Scott , Rob Hoes Subject: [PATCH v2 6/6] tools/oxenstored: Keep /dev/xen/evtchn open across live update Date: Wed, 30 Nov 2022 16:54:55 +0000 Message-ID: <20221130165455.31125-7-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20221130165455.31125-1-andrew.cooper3@citrix.com> References: <20221130165455.31125-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Edwin Török Closing the evtchn handle will unbind and free all local ports. The new xenstored would need to rebind all evtchns, which is work that we don't want or need to be doing during the critical handover period. However, it turns out that the Windows PV drivers also rebind their local port too across suspend/resume, leaving (o)xenstored with a stale idea of the remote port to use. In this case, reusing the established connection is the only robust option. Therefore: * Have oxenstored open /dev/xen/evtchn without CLOEXEC at start of day. * Extend the handover information with the evtchn fd, domexc virq local port, and the local port number for each domain connection. * Have (the new) oxenstored recover the open handle using Xeneventchn.fdopen, and use the provided local ports rather than trying to rebind them. When this new information isn't present (i.e. live updating from an oxenstored prior to this change), the best-effort status quo will have to do. Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper --- CC: Christian Lindig CC: David Scott CC: Edwin Torok CC: Rob Hoes v2: * Bind DOM_EXC virq for non-LU starts. (Regression introduced between v2 and v3 of the original series) * Rebase over previous Evtchn.init() virq cleanup * Preserve the DOM_EXC virq local port too --- tools/ocaml/xenstored/domain.ml | 13 ++++-- tools/ocaml/xenstored/domains.ml | 9 ++-- tools/ocaml/xenstored/event.ml | 20 +++++++-- tools/ocaml/xenstored/process.ml | 2 +- tools/ocaml/xenstored/xenstored.ml | 85 +++++++++++++++++++++++++------------- 5 files changed, 90 insertions(+), 39 deletions(-) diff --git a/tools/ocaml/xenstored/domain.ml b/tools/ocaml/xenstored/domain.ml index ecdd65f3209a..c196edf6a059 100644 --- a/tools/ocaml/xenstored/domain.ml +++ b/tools/ocaml/xenstored/domain.ml @@ -74,7 +74,8 @@ let is_paused_for_conflict dom = dom.conflict_credit <= 0.0 let is_free_to_conflict = is_dom0 let dump d chan = - fprintf chan "dom,%d,%nd,%d\n" d.id d.mfn d.ports.remote + fprintf chan "dom,%d,%nd,%d,%d\n" + d.id d.mfn d.ports.remote (Xeneventchn.to_int d.ports.local) let rebind_evtchn d remote_port = Event.unbind d.eventchn d.ports.local; @@ -93,8 +94,14 @@ let close dom = dom.ports <- invalid_ports; Xenmmap.unmap dom.interface -let make id mfn remote_port interface eventchn = - let local = Event.bind_interdomain eventchn id remote_port in +(* On clean start, local_port will be None, and we must bind the remote port + given. On Live Update, the event channel is already bound, and both the + local and remote port numbers come from the transfer record. *) +let make ?local_port ~remote_port id mfn interface eventchn = + let local = match local_port with + | None -> Event.bind_interdomain eventchn id remote_port + | Some p -> Xeneventchn.of_int p + in let ports = { local; remote = remote_port } in debug "domain %d bind %s" id (string_of_port_pair ports); { diff --git a/tools/ocaml/xenstored/domains.ml b/tools/ocaml/xenstored/domains.ml index 2ab0c5f4d8d0..b6c075c838ab 100644 --- a/tools/ocaml/xenstored/domains.ml +++ b/tools/ocaml/xenstored/domains.ml @@ -56,6 +56,7 @@ let exist doms id = Hashtbl.mem doms.table id let find doms id = Hashtbl.find doms.table id let number doms = Hashtbl.length doms.table let iter doms fct = Hashtbl.iter (fun _ b -> fct b) doms.table +let eventchn doms = doms.eventchn let rec is_empty_queue q = Queue.is_empty q || @@ -122,16 +123,16 @@ let cleanup doms = let resume _doms _domid = () -let create doms domid mfn remote_port = +let create doms ?local_port ~remote_port domid mfn = let interface = Xenctrl.map_foreign_range xc domid (Xenmmap.getpagesize()) mfn in - let dom = Domain.make domid mfn remote_port interface doms.eventchn in + let dom = Domain.make ?local_port ~remote_port domid mfn interface doms.eventchn in Hashtbl.add doms.table domid dom; dom let xenstored_kva = ref "" let xenstored_port = ref "" -let create0 doms = +let create0 ?local_port doms = let remote_port = Utils.read_file_single_integer !xenstored_port in let interface = @@ -141,7 +142,7 @@ let create0 doms = interface in - let dom = Domain.make 0 Nativeint.zero remote_port interface doms.eventchn in + let dom = Domain.make ?local_port ~remote_port 0 Nativeint.zero interface doms.eventchn in Hashtbl.add doms.table 0 dom; Domain.notify dom; dom diff --git a/tools/ocaml/xenstored/event.ml b/tools/ocaml/xenstored/event.ml index a3be296374ff..629dc6041bb0 100644 --- a/tools/ocaml/xenstored/event.ml +++ b/tools/ocaml/xenstored/event.ml @@ -20,9 +20,18 @@ type t = { domexc: Xeneventchn.t; } -let init () = - let handle = Xeneventchn.init () in - let domexc = Xeneventchn.bind_dom_exc_virq handle in +(* On clean start, both parameters will be None, and we must open the evtchn + handle and bind the DOM_EXC VIRQ. On Live Update, the fd is preserved + across exec(), and the DOM_EXC VIRQ still bound. *) +let init ?fd ?domexc_port () = + let handle = match fd with + | None -> Xeneventchn.init ~cloexec:false () + | Some fd -> fd |> Utils.FD.of_int |> Xeneventchn.fdopen + in + let domexc = match domexc_port with + | None -> Xeneventchn.bind_dom_exc_virq handle + | Some p -> Xeneventchn.of_int p + in { handle; domexc } let fd eventchn = Xeneventchn.fd eventchn.handle @@ -31,3 +40,8 @@ let unbind eventchn port = Xeneventchn.unbind eventchn.handle port let notify eventchn port = Xeneventchn.notify eventchn.handle port let pending eventchn = Xeneventchn.pending eventchn.handle let unmask eventchn port = Xeneventchn.unmask eventchn.handle port + +let dump e chan = + Printf.fprintf chan "evtchn-dev,%d,%d\n" + (Utils.FD.to_int @@ Xeneventchn.fd e.handle) + (Xeneventchn.to_int e.domexc) diff --git a/tools/ocaml/xenstored/process.ml b/tools/ocaml/xenstored/process.ml index 2ea940d7e2d5..ad2e0fa70f4a 100644 --- a/tools/ocaml/xenstored/process.ml +++ b/tools/ocaml/xenstored/process.ml @@ -572,7 +572,7 @@ let do_introduce con t domains cons data = Domain.rebind_evtchn edom remote_port; edom else try - let ndom = Domains.create domains domid mfn remote_port in + let ndom = Domains.create ~remote_port domains domid mfn in Connections.add_domain cons ndom; Connections.fire_spec_watches (Transaction.get_root t) cons Store.Path.introduce_domain; ndom diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml index 1f11f576b515..f526f4fb2310 100644 --- a/tools/ocaml/xenstored/xenstored.ml +++ b/tools/ocaml/xenstored/xenstored.ml @@ -144,7 +144,7 @@ exception Bad_format of string let dump_format_header = "$xenstored-dump-format" -let from_channel_f chan global_f socket_f domain_f watch_f store_f = +let from_channel_f chan global_f evtchn_f socket_f domain_f watch_f store_f = let unhexify s = Utils.unhexify s in let getpath s = let u = Utils.unhexify s in @@ -165,12 +165,19 @@ let from_channel_f chan global_f socket_f domain_f watch_f store_f = (* there might be more parameters here, e.g. a RO socket from a previous version: ignore it *) global_f ~rw + | "evtchn-dev" :: fd :: domexc_port :: [] -> + evtchn_f ~fd:(int_of_string fd) + ~domexc_port:(int_of_string domexc_port) | "socket" :: fd :: [] -> socket_f ~fd:(int_of_string fd) - | "dom" :: domid :: mfn :: remote_port :: []-> - domain_f (int_of_string domid) - (Nativeint.of_string mfn) - (int_of_string remote_port) + | "dom" :: domid :: mfn :: remote_port :: rest -> + let local_port = match rest with + | [] -> None (* backward compat: old version didn't have it *) + | local_port :: _ -> Some (int_of_string local_port) in + domain_f ?local_port + ~remote_port:(int_of_string remote_port) + (int_of_string domid) + (Nativeint.of_string mfn) | "watch" :: domid :: path :: token :: [] -> watch_f (int_of_string domid) (unhexify path) (unhexify token) @@ -189,10 +196,21 @@ let from_channel_f chan global_f socket_f domain_f watch_f store_f = done; info "Completed loading xenstore dump" -let from_channel store cons doms chan = +let from_channel store cons domains_init chan = (* don't let the permission get on our way, full perm ! *) let op = Store.get_ops store Perms.Connection.full_rights in let rwro = ref (None) in + let doms = ref (None) in + + let require_doms () = + match !doms with + | None -> + warn "No event channel file descriptor available in dump!"; + let domains = domains_init @@ Event.init () in + doms := Some domains; + domains + | Some d -> d + in let global_f ~rw = let get_listen_sock sockfd = let fd = sockfd |> int_of_string |> Utils.FD.of_int in @@ -201,6 +219,10 @@ let from_channel store cons doms chan = in rwro := get_listen_sock rw in + let evtchn_f ~fd ~domexc_port = + let evtchn = Event.init ~fd ~domexc_port () in + doms := Some(domains_init evtchn) + in let socket_f ~fd = let ufd = Utils.FD.of_int fd in let is_valid = try (Unix.fstat ufd).Unix.st_kind = Unix.S_SOCK with _ -> false in @@ -209,12 +231,13 @@ let from_channel store cons doms chan = else warn "Ignoring invalid socket FD %d" fd in - let domain_f domid mfn remote_port = + let domain_f ?local_port ~remote_port domid mfn = + let doms = require_doms () in let ndom = if domid > 0 then - Domains.create doms domid mfn remote_port + Domains.create ?local_port ~remote_port doms domid mfn else - Domains.create0 doms + Domains.create0 ?local_port doms in Connections.add_domain cons ndom; in @@ -229,8 +252,8 @@ let from_channel store cons doms chan = op.Store.write path value; op.Store.setperms path perms in - from_channel_f chan global_f socket_f domain_f watch_f store_f; - !rwro + from_channel_f chan global_f evtchn_f socket_f domain_f watch_f store_f; + !rwro, require_doms () let from_file store cons doms file = info "Loading xenstore dump from %s" file; @@ -238,7 +261,7 @@ let from_file store cons doms file = finally (fun () -> from_channel store doms cons channel) (fun () -> close_in channel) -let to_channel store cons rw chan = +let to_channel store cons (rw, evtchn) chan = let hexify s = Utils.hexify s in fprintf chan "%s\n" dump_format_header; @@ -248,6 +271,9 @@ let to_channel store cons rw chan = Utils.FD.to_int fd in fprintf chan "global,%d\n" (fdopt rw); + (* dump evtchn device info *) + Event.dump evtchn chan; + (* dump connections related to domains: domid, mfn, eventchn port/ sockets, and watches *) Connections.iter cons (fun con -> Connection.dump con chan); @@ -367,7 +393,6 @@ let _ = | None -> () end; let store = Store.create () in - let eventchn = Event.init () in let next_frequent_ops = ref 0. in let advance_next_frequent_ops () = next_frequent_ops := (Unix.gettimeofday () +. !Define.conflict_max_history_seconds) @@ -375,16 +400,8 @@ let _ = let delay_next_frequent_ops_by duration = next_frequent_ops := !next_frequent_ops +. duration in - let domains = Domains.init eventchn advance_next_frequent_ops in + let domains_init eventchn = Domains.init eventchn advance_next_frequent_ops in - (* For things that need to be done periodically but more often - * than the periodic_ops function *) - let frequent_ops () = - if Unix.gettimeofday () > !next_frequent_ops then ( - History.trim (); - Domains.incr_conflict_credit domains; - advance_next_frequent_ops () - ) in let cons = Connections.create () in let quit = ref false in @@ -393,14 +410,15 @@ let _ = List.iter (fun path -> Store.write store Perms.Connection.full_rights path "") Store.Path.specials; - let rw_sock = + let rw_sock, domains = if cf.restart && Sys.file_exists Disk.xs_daemon_database then ( - let rwro = DB.from_file store domains cons Disk.xs_daemon_database in + let rw, domains = DB.from_file store domains_init cons Disk.xs_daemon_database in info "Live reload: database loaded"; Process.LiveUpdate.completed (); - rwro + rw, domains ) else ( info "No live reload: regular startup"; + let domains = domains_init @@ Event.init () in if !Disk.enable then ( info "reading store from disk"; Disk.read store @@ -413,9 +431,18 @@ let _ = if cf.domain_init then ( Connections.add_domain cons (Domains.create0 domains); ); - rw_sock + rw_sock, domains ) in + (* For things that need to be done periodically but more often + * than the periodic_ops function *) + let frequent_ops () = + if Unix.gettimeofday () > !next_frequent_ops then ( + History.trim (); + Domains.incr_conflict_credit domains; + advance_next_frequent_ops () + ) in + (* required for xenstore-control to detect availability of live-update *) let tool_path = Store.Path.of_string "/tool" in if not (Store.path_exists store tool_path) then @@ -430,8 +457,10 @@ let _ = Sys.set_signal Sys.sigusr1 (Sys.Signal_handle (fun _ -> sigusr1_handler store)); Sys.set_signal Sys.sigpipe Sys.Signal_ignore; + let eventchn = Domains.eventchn domains in + if cf.activate_access_log then begin - let post_rotate () = DB.to_file store cons (None) Disk.xs_daemon_database in + let post_rotate () = DB.to_file store cons (None, eventchn) Disk.xs_daemon_database in Logging.init_access_log post_rotate end; @@ -593,7 +622,7 @@ let _ = live_update := Process.LiveUpdate.should_run cons; if !live_update || !quit then begin (* don't initiate live update if saving state fails *) - DB.to_file store cons (rw_sock) Disk.xs_daemon_database; + DB.to_file store cons (rw_sock, eventchn) Disk.xs_daemon_database; quit := true; end with exc -> -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 17:15:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 17:15:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450065.707206 (Exim 4.92) (envelope-from ) id 1p0Qfj-0008HG-O6; Wed, 30 Nov 2022 17:14:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450065.707206; Wed, 30 Nov 2022 17:14:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Qfj-0008H9-LW; Wed, 30 Nov 2022 17:14:59 +0000 Received: by outflank-mailman (input) for mailman id 450065; Wed, 30 Nov 2022 17:14:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Qfh-0008H3-Ht for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 17:14:57 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8185a50c-70d2-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 18:14:55 +0100 (CET) Received: from mail-mw2nam10lp2106.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.106]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Nov 2022 12:14:52 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by PH0PR03MB6771.namprd03.prod.outlook.com (2603:10b6:510:122::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 17:14:49 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%5]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 17:14:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8185a50c-70d2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669828495; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=cNo3kbzVMLSvEx/qQJP97hBtjOe56k8Itj3k/ZkIiN8=; b=Nu2Og/C9KaWPQWW0jUP/k1g0D6BW5mMuR/yobmr063FLkgbkjarqBffa k02GOv1IogpPXN7TT+tK2iI5FLBJFpnD/a4zxEH87jG7JZVUjQGAoFVYM VE1OC252DqozvYJhAwQeX++5ztux7K8VKLd66CmSnJB6fKFzpV+dojT9/ A=; X-IronPort-RemoteIP: 104.47.55.106 X-IronPort-MID: 86309856 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:lvY8caqlozAXVPCkgOIWmR6nq49eBmILZBIvgKrLsJaIsI4StFCzt garIBmBMvmMNGvyf4wgOti1p08OvZ7Rz9JlTQNlrXg9QShAoJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHzCFNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAA5Rbx2qvM2Z/J22V+dngPkBIerUF4xK7xmMzRmBZRonabbqZvySoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeWraYKLEjCJbZw9ckKwq 27Y/mK/HhYAM9+3wjuZ6HO8wOTImEsXXapCSubgp6433jV/wEQiWTE5dVCQvMW/1EjuW9BNb F4l+HIx+P1aGEuDC4OVsweDiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceSTU02 3eTktjuBDgpt6eaIU9x7Z+RpDK2fC0Kd2kLYHZcSRNfuoG95oYukhjIU9BvVravicH4Ei3xx DbMqzUig7IUjogA0KDTEU37vg9Ab6PhFmYdjjg7lEr/hu+lTOZJv7CV1GU= IronPort-HdrOrdr: A9a23:xsAJxK26dpwIy/OqnQXlywqjBLskLtp133Aq2lEZdPU1SL36qy nKpp4mPHDP5Qr5NEtNpTniAsm9qBHnm6KdiLN5VdyftWHdyQ6VxepZjLcKrQeOJ8W0ntQtsZ uJGcJFeb/NMWQ= X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="86309856" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SBmLWmaa6f5lONW5/cJKLhmP66peH3Miz9tpHwuTZvOCAyPGS+0WzxXbsFV6KVT6+PE5F1Dl9cHCKlEIEhi1yEgOOEm135FmGGOs9DuMIP+2TkboUsSEYufOR10iY8I2/uUjNFWBEPW6gsaarTiurZKZoc48wq+i6w8CDmewGEhhDMqEqW2xNb0IMvLDxUrquQB3jAHnmq6P68fy9X0+iLrdXu/roCVej0ljtiSde9AWhABXwzgoCszFnXmDghQAKq3j+RDj6avUIYofPVO436Nb3i4OC9JJ/trsU61vxNWrB1AjNgCm2oXDhKeHwxurH4onJjF/5ndkHza+P+kUKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cNo3kbzVMLSvEx/qQJP97hBtjOe56k8Itj3k/ZkIiN8=; b=j/xWCzfNANlHh+C4fZaG+xSd9XB3TGZ644QGWlHGkSS6oaZ2/qd2gLNf8QHYbSaVFKNSXaoYz6iLaO1/FLVgErQ++byTueP66hpnjFeUYw0oYniYN/NuFCMnEk7AjGU5Qa7V5kaLUGJkktYYpxl51Z/8y1BhUXVNEqm9/z/iCNzmlvXBKqItMhA4LVwoCIyMTPYVprttNvpRO0nHuJcx/0Jz5WLiM4aHuuqw5zImM3v5g949bE2yU5qhfu7O69UHw8BAfYKc+w9cFS1qcRO4oJW8VJ8ou5yxYTQzc0dBXxLpt33NtGBt66o0ifv+9mQ8bsXQG7woy4em4347LIXjqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cNo3kbzVMLSvEx/qQJP97hBtjOe56k8Itj3k/ZkIiN8=; b=kvJuXWraeb2SuB1/W/gNVyLVv9liqKkKRrsNx8NIQ4eix5+qupP9KEZcBFdLjBcG7w6B42qRBhxnpRqNllxZrwh9CzGfGOq4YW3sU+EWgHp/fY14OGDqFrfnQpFzoYiErzzjCUG7/g2oPB2AKBrNQsWBmi+E77HpXKCKbhf1vDo= From: Edwin Torok To: Andrew Cooper CC: Xen-devel , Christian Lindig , David Scott , Rob Hoes Subject: Re: [PATCH v2 1/6] tools/oxenstored: Style fixes to Domain Thread-Topic: [PATCH v2 1/6] tools/oxenstored: Style fixes to Domain Thread-Index: AQHZBNx/46jv4MYnYEmbfJm7DDYZZK5XtLyA Date: Wed, 30 Nov 2022 17:14:49 +0000 Message-ID: <4EF34CCE-E2C6-4367-A514-D205C7233496@citrix.com> References: <20221130165455.31125-1-andrew.cooper3@citrix.com> <20221130165455.31125-2-andrew.cooper3@citrix.com> In-Reply-To: <20221130165455.31125-2-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|PH0PR03MB6771:EE_ x-ms-office365-filtering-correlation-id: de128317-1738-41a0-5b64-08dad2f66357 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SBk+Zp6dtAT8YsBJxDy04fIVcgVMPxPjQkwHwDL5jTRt0s8BSyYO38drL/YNPoRCxo3jP5QtCP4/LGbLj706vwCfaBAcB/4m5WlPysKAxxMxv4t4MupPHoAkkpZ08NVNOZAvEh3p/CsZgdPIj6xHvZBW821oj+MH9ow9F8o24vEymF1vVavJQhNknCKoynJRR1PTIM1VBuCoPIzjacIhajtzkE88W69etMDEgRiYc9a6qnX/8/AEFj3tCRvcwtY2DTyjJMf4ai4qTOJslvxKy9zxI2D9k/XJDzIiStaBXS8D792Uv+3CnTyEngYKXhi8Q2sNm1bQJ3fqO8smPd+fa4975viaeOylmMp3qyFhEW+YBfy1zzW2RgPQCmGFo7DRtTX6rtDBQVtZZoFWEHYYOzwbKdsIthwKbAF+Jcb1kvbxxMtGKwkYrnA+fff9IE42SmW1nPlSHbVoKDEYD77nZtkClIDPPtJEDgy4sR8csfqmnMntR9utGy/7YypwOh50S3vC6V6vPNHKkMzBzZk2sZQhL8NLDXYJ22v1mt1Tp8AtQs6+TVBJKy+eTbyXS3nM9mSkhzAnr4wZ0oyaG6CtKHSyc8+RbSoYMNQWEffnO5jUQzgGcE44+tV1/ye9FXnFfr8v+meTpHDQupL66DcHG6aQY74mpO4Xk8RlShaniHaI+0KxwwTCgjndpO0YZOOFhbFgQHRBUGouapelGgC1Zf4oGx2AyWCFyhP309ATk6Q= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(451199015)(478600001)(83380400001)(6486002)(2906002)(53546011)(82960400001)(71200400001)(107886003)(6636002)(37006003)(54906003)(38100700002)(5660300002)(66574015)(38070700005)(122000001)(66946007)(6862004)(41300700001)(26005)(36756003)(8936002)(2616005)(66476007)(66556008)(64756008)(4326008)(86362001)(66446008)(6506007)(8676002)(6512007)(91956017)(186003)(33656002)(316002)(76116006)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SXJCRG9vR0tMYzB1bDQxRFRmNGR4aTVYeThBTy9Rc3VXaUcwVmFhdTlkN3d4?= =?utf-8?B?T29lemxqWllDZjdCZENQQ3RmOFpWeXVmNElmZW9laG1FTWVRbVBDamJuaHAv?= =?utf-8?B?Rm5IK3Yxb053bVVjRS96MloxTFVoMVI0QVpzYjAzRE1yeGJoK3o1ODBYL04r?= =?utf-8?B?SldyVzFmMkdCZVZOTXNGTlJ1ZEtzRjdvZVQxbzZVcDI2eFBCQy9MaUJJWjBs?= =?utf-8?B?dzloWng4T3BYNjA4S20yV2FTOEc2a2V5czB4SW9salBkZG1PWWVzbXVxNUxS?= =?utf-8?B?cTNDN3pBblRNR1hXU01jVTZUTjRYRUhkY1NrYmZSb3k4anNzT0JPejlkelhR?= =?utf-8?B?YXBxeWJqVGptaVlrMXQvbWpSRnRDNEp5K0lYd3grNE1PcFUrWTdVcVlpbWVk?= =?utf-8?B?M244M3JVMlp3U3Nza2pBWm1oejRsdVc2Z3N3Q3QwMFJvNmpPQlAwWlZVR0dO?= =?utf-8?B?QkxGWjVuWU41RVl3VUZVK3J2eFVkK0RFOHU4bEJ2alVEZkUwVVdYaUViUEhZ?= =?utf-8?B?Nm5PQVF5SkxRWXhBYTlZc25YTXVTdnl4WjI5Ym9wS2JpTjlCOFk2S25rbUNk?= =?utf-8?B?eHNoSDJqU2lXZ2JPR21EUTNJT2NPK3d3ZkszZlNoK1NxaDNmM3plNlVRN1Uy?= =?utf-8?B?L0tKNFR5NE02YS9UV0FvdXlldi90amhaZ2JZQ2QxNlM3R0J6K2d6bkNBZHla?= =?utf-8?B?Zm8ybTh0N2Q4ZldlYUwvRSsyRG1pTTJscU85WDVtQW9GOWlJQ2FTYzNpdk1F?= =?utf-8?B?NHRPc0dKTzByQUgwMU1DL3dIU3NmMDl5Wi91ZjN2Wlg5RWc3cks2VzNqdnMv?= =?utf-8?B?RU9ZemFWQUc3Y3ZQSnlFVERyQjVmRktTNUlEbld6QlhFditEWDc0OG80RDJX?= =?utf-8?B?M2xpK2kyNGVtYTE4Ulo2Y09EblpDcCtaUFpoeXoyLzk0K1Q4ZDVDWlI2bVEy?= =?utf-8?B?bEkzdkhuOGtVOUpoWjlFQk5xc0xCZ085bHNLbFhuaW1sQlI2aWZhRXhDejZl?= =?utf-8?B?WjVVUmVxeWo0bVFxbk5ldlNzK1dnTmhKSlB0bTJ3SkoreVRlMjNQU2VEbzQr?= =?utf-8?B?WVM4eWVUTlNNVXBPWUhSMlNiWnk3WXQvVzBlUjRWVWNZTnR0NlJEb2VUR0cv?= =?utf-8?B?MUFJbnhDaXIycGlCcmVXNE0rOWs3bTI4VHhodWJ1RTdYOGFyS1FQWGdLL2tZ?= =?utf-8?B?L001VEJvcnh5cFJuZlMzSjBiWUJYbzJXQ2pWcXRXTFozK1hkT05YenhBbDVn?= =?utf-8?B?Q28vT0hsSHp4elFCbDhuT1Uxcjd3YzF5WFMxVE5adXNiWDhiK3o2VHlmWnpD?= =?utf-8?B?UE9Yd1RIeldaZGc1ZzRCNUJEcHhvT2dKYUovNnVyc3VjN2FzVjdSUnhucEMy?= =?utf-8?B?aEo0eWdlTUZwZTFGaEdiUUJtYUhzS0JYNGdYdCtoSjdnaFpFSUhNZmozMUhN?= =?utf-8?B?YU9xdmtTeWhOd2RUemN5RnhwYlQxSHFwaEFWTjQ0L1BEMGF2dEdyUnpQOXh2?= =?utf-8?B?UXZVUUFpYXVOY0VIVjlnS3VURFN3dFpiOGJFUTd2amJsVVpGbFNyR3M4b0tw?= =?utf-8?B?SHBaTGRYVXJteklBTUxZUkZ2blhSYURtQXBtZkUrV3N5ZnZnUitObGY4QWNG?= =?utf-8?B?WmpIWDBoK3N0aVp4d1c3Zi9zWWwvUk16eUN3SVhqbVp0RFlTdVBXbWZqajFK?= =?utf-8?B?aTZRN1R2QXVuMloxcXRib05ydS9mei90S3M4WThtSVg4K1ZXVTVsQ3NxTVA1?= =?utf-8?B?SjNjb1JVaG94aVYwclN2azhaeXI5QVlWYmMwazdBVmFzODQwNnkzR1hWTHl3?= =?utf-8?B?VzVXM2poZ1RYamJ4N0tIZ0ZoVGVuelBFdFpDQlVtbENxYWF4RURWYnRLcEU5?= =?utf-8?B?djV4NkNHRlRESmd0cHcyTjlLZUx1dGwrQVNxM1Y5M2pGbG1WVlQxOGZLZ0p2?= =?utf-8?B?bmJHR1NaVGFyVTl5VlQ0ZEVQdC9CLzAwM3diRFk3VU41NG5laXdPNkNSZ21L?= =?utf-8?B?YUN3SkpZMFRZeDE0a2Jtb0loR1F0MlVMZlVkQnhyZmdSQUFPK00vbktSc2hL?= =?utf-8?B?M2lGMklxblBWdklXWXVRSmtkZXNJOE9Wc2JJYS9lcHBTRElwMjJaTmtPd1N0?= =?utf-8?B?cHhuaXUrRC8rMFVyRERBZ0t0bWpiaGl1QzJkejdmVlNBd2RIOHkzNysrdm9l?= =?utf-8?B?L3c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <7C7B5EA2D070434387B3C3DB96F0D103@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 38be0geFg9NYJkKAgNeyl7Y7uMbZkjT1FVpSeM28lSVoVfGBzN5kJZ+F/G0Imcw57EilWwRzCjTFh0DYwa8ucCog0p/W8894nSsZw2xOS2pm2niUb+g+B0DYvQeEvV+phmD1ruP4K0S1sC190RfKnZmLfGctRkz6WzePQTA9V+R4yqzl4vP52BPUFjgpjkn1sVAq94j76kgwEQ7IsU4bydTeJmsiG9CpP+e6oUgvUmrjqEf3JR7W0gvNl9392H2aCKZsHepl7PG9kDM0xlFsY00GPw1xLVQgKhrm8zKaTPQRjSPMasp9V+igjpFvo7lVgE9OPMSgYJz4Rbsycm9an2wyPk/ES0y2W+LY9Dqpv8Jt+Rq0dkdoBPvNf849GYYfBdGPDxdrows+BaF9TFeWUFQ38QvlvDH7XZt0FYvpkMHZxKcojiIQcIzaCWsGYQRClOcNaFMgso00PJqLgJHj/WyEzN+6TER/qJeAOnuWtpBXBLFqqwPAgf1egclbUiXx6FDFEwv04HfXkWYttW5gEXKvPeuhplc2VBiSS3418FTnTkNWmTn0VR+HWGSQv5ZHVItbOKvDua66SfgyP48VcSm0q8Ye7epOjKwBOJjtWmazq2hZZf71RBTDDqi4Vf+0nDSbwN3319UhvM/P6eizmivEtSy9pVM+Z8VUP1ZJ1oim0EoBFr1X09P1jStlk3KagNc5vIaWdREuIsHkOmRBcDsTuenkmepeFouSDuF8luErfpGgj5a/hX+EgyXLcY69z/yQPTF1L72U6RhMFFpK9D0g21CuBOrJlp2Y9wipIBVyDdENk2gmUILE1exsa++Z X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de128317-1738-41a0-5b64-08dad2f66357 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 17:14:49.6491 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hEnfiWfALa04P1kS8DkHOi0fjwGP9YnSYtBEayVZ2eTBa3l3/22f1i2GQfBWIKSeg2G7WRCBv6sRN9NUkX4h2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6771 DQoNCj4gT24gMzAgTm92IDIwMjIsIGF0IDE2OjU0LCBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29v cGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IFRoaXMgZmlsZSBoYXMgc29tZSBzdHlsZSBw cm9ibGVtcyBzbyBzZXZlcmUgdGhhdCB0aGV5IGludGVyZmVyZSB3aXRoIHRoZQ0KPiByZWFkYWJp bGl0eSBvZiB0aGUgc3Vic2VxdWVudCBidWdmaXggcGF0Y2hlcy4NCj4gDQo+IEZpeCB0aGVzZSBp c3N1ZXMgYWhlYWQgb2YgdGltZSwgdG8gbWFrZSB0aGUgc3Vic2VxdWVudCBjaGFuZ2VzIG1vcmUg cmVhZGFibGUuDQo+IA0KPiBObyBmdW5jdGlvbmFsIGNoYW5nZS4NCj4gDQo+IFNpZ25lZC1vZmYt Ynk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+IC0tLQ0KPiBD QzogQ2hyaXN0aWFuIExpbmRpZyA8Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPg0KPiBDQzog RGF2aWQgU2NvdHQgPGRhdmVAcmVjb2lsLm9yZz4NCj4gQ0M6IEVkd2luIFRvcm9rIDxlZHZpbi50 b3Jva0BjaXRyaXguY29tPg0KPiBDQzogUm9iIEhvZXMgPFJvYi5Ib2VzQGNpdHJpeC5jb20+DQoN Cg0KUmV2aWV3ZWQtYnk6IEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+DQoN Cj4gDQo+IHYyOg0KPiAqIE5ldw0KPiAtLS0NCj4gdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RvbWFp bi5tbCB8IDE2ICsrKysrKystLS0tLS0tLS0NCj4gMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9u cygrKSwgOSBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5z dG9yZWQvZG9tYWluLm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RvbWFpbi5tbA0KPiBpbmRl eCA4MWNiNTliOGYxYTIuLmFiMDhkY2YzN2Y2MiAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvb2NhbWwv eGVuc3RvcmVkL2RvbWFpbi5tbA0KPiArKysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvZG9tYWlu Lm1sDQo+IEBAIC01NywxNyArNTcsMTYgQEAgbGV0IGlzX3BhdXNlZF9mb3JfY29uZmxpY3QgZG9t ID0gZG9tLmNvbmZsaWN0X2NyZWRpdCA8PSAwLjANCj4gbGV0IGlzX2ZyZWVfdG9fY29uZmxpY3Qg PSBpc19kb20wDQo+IA0KPiBsZXQgc3RyaW5nX29mX3BvcnQgPSBmdW5jdGlvbg0KPiAtfCBOb25l IC0+ICJOb25lIg0KPiAtfCBTb21lIHggLT4gc3RyaW5nX29mX2ludCAoWGVuZXZlbnRjaG4udG9f aW50IHgpDQo+ICsgfCBOb25lIC0+ICJOb25lIg0KPiArIHwgU29tZSB4IC0+IHN0cmluZ19vZl9p bnQgKFhlbmV2ZW50Y2huLnRvX2ludCB4KQ0KDQpJIHdvdWxkJ3ZlIGV4cGVjdGVkIG9jcC1pbmRl bnQgdG8gYWxyZWFkeSBkbyB0aGUgcmlnaHQgdGhpbmcgb24gdGhpcyBwYXJ0Lg0KDQo+IA0KPiBs ZXQgZHVtcCBkIGNoYW4gPQ0KPiBmcHJpbnRmIGNoYW4gImRvbSwlZCwlbmQsJWRcbiIgZC5pZCBk Lm1mbiBkLnJlbW90ZV9wb3J0DQo+IA0KPiAtbGV0IG5vdGlmeSBkb20gPSBtYXRjaCBkb20ucG9y dCB3aXRoDQo+IC18IE5vbmUgLT4NCj4gLSB3YXJuICJkb21haW4gJWQ6IGF0dGVtcHQgdG8gbm90 aWZ5IG9uIHVua25vd24gcG9ydCIgZG9tLmlkDQo+IC18IFNvbWUgcG9ydCAtPg0KPiAtIEV2ZW50 Lm5vdGlmeSBkb20uZXZlbnRjaG4gcG9ydA0KPiArbGV0IG5vdGlmeSBkb20gPQ0KPiArIG1hdGNo IGRvbS5wb3J0IHdpdGgNCj4gKyB8IE5vbmUgLT4gd2FybiAiZG9tYWluICVkOiBhdHRlbXB0IHRv IG5vdGlmeSBvbiB1bmtub3duIHBvcnQiIGRvbS5pZA0KPiArIHwgU29tZSBwb3J0IC0+IEV2ZW50 Lm5vdGlmeSBkb20uZXZlbnRjaG4gcG9ydA0KDQpidXQgeWVzIGZvciB0aGlzIHdlJ2QgbmVlZCBv Y2FtbGZvcm1hdCwgbm90IG9jcC1pbmRlbnQuDQoNCj4gDQo+IGxldCBiaW5kX2ludGVyZG9tYWlu IGRvbSA9DQo+IGJlZ2luIG1hdGNoIGRvbS5wb3J0IHdpdGgNCj4gQEAgLTg0LDggKzgzLDcgQEAg bGV0IGNsb3NlIGRvbSA9DQo+IHwgTm9uZSAtPiAoKQ0KPiB8IFNvbWUgcG9ydCAtPiBFdmVudC51 bmJpbmQgZG9tLmV2ZW50Y2huIHBvcnQNCj4gZW5kOw0KPiAtIFhlbm1tYXAudW5tYXAgZG9tLmlu dGVyZmFjZTsNCj4gLSAoKQ0KPiArIFhlbm1tYXAudW5tYXAgZG9tLmludGVyZmFjZQ0KPiANCj4g bGV0IG1ha2UgaWQgbWZuIHJlbW90ZV9wb3J0IGludGVyZmFjZSBldmVudGNobiA9IHsNCj4gaWQg PSBpZDsNCj4gLS0gDQo+IDIuMTEuMA0KPiANCg0K From xen-devel-bounces@lists.xenproject.org Wed Nov 30 17:15:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 17:15:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450066.707217 (Exim 4.92) (envelope-from ) id 1p0Qg4-0000Dc-W9; Wed, 30 Nov 2022 17:15:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450066.707217; Wed, 30 Nov 2022 17:15:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Qg4-0000DV-TR; Wed, 30 Nov 2022 17:15:20 +0000 Received: by outflank-mailman (input) for mailman id 450066; Wed, 30 Nov 2022 17:15:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Qg4-0008H3-09 for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 17:15:20 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f8d631f-70d2-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 18:15:18 +0100 (CET) Received: from mail-dm6nam11lp2175.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Nov 2022 12:15:16 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by PH0PR03MB6771.namprd03.prod.outlook.com (2603:10b6:510:122::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 17:15:14 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%5]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 17:15:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f8d631f-70d2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669828518; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=OXe9CxqgeX86lv66pzeEKIeBDPTOOvbZh4zRdLyGH+4=; b=hR/cEiu/HfZkERNNo9edE2zjBxa0dlCYJQTsQsLGyacL0Y9k8wTWGwFg 4E28bavoMmpZxPnHMeASyErtNxlC1uYdJ8U6ioMC2zTi7lfjrRScEVVJO KBM4mvmsLi4724B/u+mFaN/jlfGfL7Id7xJ/17D2shky1IMwJSE9b3H6J o=; X-IronPort-RemoteIP: 104.47.57.175 X-IronPort-MID: 86309945 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:C6b9Dql3PmHbj8Hp966MBYbo5gySJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJJWDuBb/eCYzfyL95xOoi/px5Q75WGz4UyT1Q5/Hw1FCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5weGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 fMfKh8IfzDZvMSV8rvnR+RomvU4fca+aevzulk4pd3YJdAPZMmaBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVM3ieewWDbWUoXiqcF9k0qGp 2SA42PjBRIyP92D0zuVtHmrg4cjmAurBtlKRezkq5aGhnWOzXcQNh4pe2G7rOG1iBCVUoIHK RQbr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOuMYoSBQw2 1SOntevAiZg2IB5UlqY/7aQ6D+3Zy4cKDZbYTdeFFRYpd7+vIs0kxTDCM55F7K4hcH0Hje2x C2WqC85hPMYistjO7iHwG0rSgmE/vDhJjPZLC2NNo55xmuVvLKYWrE= IronPort-HdrOrdr: A9a23:fS6bPa3vTjozxwh/sKajuAqjBWlxeYIsimQD101hICG9Lfbo9P xGzc566farslcssSkb6Ky90KnpewK5yXcH2/hvAV7CZnirhILMFupfBOTZskXd8kHFh4xgPO JbAtVD4b7LfBdHZKTBkXKF+r8bqbHozEnrv5al854Ed3AwV0gK1XYfNu/vKDwOeOAwP+teKH Pz3Lsjm9J9EU5nM/hTAENrYwE5nbD2fWjdCyIuNloG8w+IlDWy9frQFRWJ5BcMX1p0rYsKwC zgqUjU96+ju/a0xlv10HLS1Y1fnJ/M28ZOH8uFj+kSM3HJhhyzbIpsdrWetHRtydvfqWoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HID+mLv0liRhFrkuIjcSCghA8RMqIpFel/y6lYmvvt7zK VXtljp+aZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRhZZ3xjIULL4wWAbBrKw3Gu hnC8/RoNxMd0mBUnzftm5zhPSxQ3UIGAucSERqgL3X79EWpgE686Ir/r1aop4yzuN7d3CC3Z WDDk1crsAKcibRV9MlOA5Oe7ruNoWHe2OzDIvbGyWXKEhAAQOWl3e/2sRE2Mi6PJMP15c8g5 LHTRdRsnMzYVvnDYmU0IRM6Q2lehT3Yd1D8LAr23FVgMy0eFPQC1zKdHk+18+75/kPCMzSXP i+fJpQHv/4NGPrXYJExRf3VZVeIWQXFJR9gKd3Z3ue5sbQboH6vO3Sd/jeYLLrDDY/Q2v6Rn 8ORiL6KslM5l2iHnX4nB/SUXXwfVGXx+M7LIHKu+wIjIQdPIxFtQYYzVy/+8GQMDVH9rc7eU NvSYmX5J9TZVPGilogw18ZTya1VHwlk4kIe0k61zM3Dw== X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="86309945" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SgZuTdmwe3UP+X3W6UXpQSK7+Guj2hyBgumWG957OvnaIUlvtnVcDzyhiHz/guhg0Vz1LBrdruqM+y8QfQGlwe2RZgFEgkbnllQDjjuJctqmsJJlNZVricj0tuwYLxAyoJvdK1RGFwboaQFFq7+T5L4WacOlWNKm4xl0aoiTpPHIWGulspud2mfAj4BMpQRok7Q3MTY023xgRRIfhjKtZ0xz0e36+kz2/0UGsuiLdc7Ug8QRirjk5vApOKG3lHymFWTXyWKl+pdLnF8kpiR0lFtpN5nWTPy7J7yuqI3rPyR8rgCq6R/Bd0VwdjNoNDp2g0Je9N0NwdkHBwTwsGFNuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OXe9CxqgeX86lv66pzeEKIeBDPTOOvbZh4zRdLyGH+4=; b=kDONjoVCNm1vchVKqEBKne7XTr6fvNBAr8zOlSN/BwWTFcdiVhvA1Qrl2DTWkAGcLvXqjIiHUbmvLWvjIoXr2p0wv2JBU875u6mmueJrMQiPJWv7CQhGxBXZWwmHYNNolqqsBU00o58eCoWFcjpZG4Dm5cEjxZWDxRKHCBhbgo4irQKKU2M73xoL2CVr0A5IsxGdoymtlX4SfxLFgtd/mAmkJLpgIXMcH3BDwl/SfCmMAQVTLWJsb3XCMkRyGbLh0dB1kNw+6GREgd52Wi6T94h+YEar5ZVBEnezVXuyfITMv9ZmrcPtjgLozyi2OI2sug6tQE9a9CTasbC3S49z6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OXe9CxqgeX86lv66pzeEKIeBDPTOOvbZh4zRdLyGH+4=; b=rS9NVVyATolfXEvWxtunhdh5JWfms+WaCHuixdz4BKDnrorzAS/aBVmYWUA23GDpwbUU4EGZI5MKN8TFWtNxPJ26d34PBXv2MWL9+jXk90AYJo/i92jlh7bkNiR+kwY8+ivyiRgIvgqnAQtO8xLxm25ynfSftU0IjictnF5qnnA= From: Edwin Torok To: Andrew Cooper CC: Xen-devel , Christian Lindig , David Scott , Rob Hoes Subject: Re: [PATCH v2 4/6] tools/oxenstored: Implement Domain.rebind_evtchn Thread-Topic: [PATCH v2 4/6] tools/oxenstored: Implement Domain.rebind_evtchn Thread-Index: AQHZBNyC07UMyecyUU6qY7XFpbA+Qq5XtNiA Date: Wed, 30 Nov 2022 17:15:14 +0000 Message-ID: <13A3294D-DF32-4F51-81B0-C92DFBF8977E@citrix.com> References: <20221130165455.31125-1-andrew.cooper3@citrix.com> <20221130165455.31125-5-andrew.cooper3@citrix.com> In-Reply-To: <20221130165455.31125-5-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|PH0PR03MB6771:EE_ x-ms-office365-filtering-correlation-id: 90b9935d-660e-48f8-cdfe-08dad2f67203 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rK3sOq86G+HcywCdj2yyqTpfy+RZ/H+ObAtMD0Q3Dns/Pa8L1IqYRaVDENqB1uyNrVFtrNie8YE1TAUS4OWbK9AOzDQsUNrxXjF6f+jxlQB24jOsrwtsVIPH/oBM6q7GoVaTVpYd1ywzwBONBNtvQNr8/0I5KjdskTrYXx4EzZa252SIFvS/jWgQOjBRZdVH7H6aQX6z5v4UdfhpP8XtGgoTfs1vRxY28pHkg/tlwUP58uszeIzQwArfoLcWKXfSoACBCUSU9O5KQL2242tnizcKsxk+w6/43otyi4UdiDAWkaHr624dw7zs8wAYylOedHs/MfRIMsDqzPDMafA42oWKL2kvxrIfrB+xmaOBceyvXvft14nLWaa1MtDdTMGA/CmyTyczPsIk+yl1ay2JksNjSVxsDD02xwmjvsWGkXF7xU4nSaoEt2AzrPujZBigwI1EzWzUAJ/THhTKgdKHqH6g0QTob6FGk8+NZeh5jTm1ZWSs/nTk8ZeSoBSCnCn9JgoKoxUeU8nT4aDwviYhT/+6vz5LH5lR7bBkVE4bO4LjBJ/Ry9F2G984NtF3ZZ8TauajLc33qu9isLlSLcoEnpeEGbgzUdvaY9kVb3jK4lB9rBJhVADZ3ZFsSSzmg3T+2c5umiOsfmhb3kQcQ4G+7V2QAI26ROR2DgFKFDAiLUV/URQ6XRhNCxhydw4nQ71tZzj7f0tbP6a2EWhFLiyR7f+J7U3DhkAmGXdsNezwbnw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(451199015)(478600001)(83380400001)(6486002)(2906002)(53546011)(82960400001)(71200400001)(107886003)(6636002)(37006003)(54906003)(38100700002)(5660300002)(66574015)(38070700005)(122000001)(66946007)(6862004)(41300700001)(26005)(36756003)(8936002)(2616005)(66476007)(66556008)(64756008)(4326008)(86362001)(66446008)(6506007)(8676002)(6512007)(91956017)(186003)(33656002)(316002)(76116006)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NDdEZzJwTWh6NlMwdmh5aVZqV0VuQTh0SXRTTU5CQXg2L1A1aUZUU3ZHM1ZP?= =?utf-8?B?WnNkM29SY3BsY2x0dlNhSksydjdrQW04eHdQbVFjVXhvQUFsVU5pMzZpWnJ6?= =?utf-8?B?TG03VG8wU1dMYTViZVRrNUNUUlBWc1dNK3JmKzJBUktpSitzWE8zN0RxRnJv?= =?utf-8?B?TXB6VHAxN0txMTBKR0M1YU1nZjg0U1ZqM3pRUTYxWHZraWFNQzd5K092b1dT?= =?utf-8?B?Y3NUOHRtZDRraFpGZTAvSnNVWHR6UW1OZzRlT0Y1Umw4NmZnQytCZmpyUXpL?= =?utf-8?B?SVlNZVAxWCtLM014a3NnRzhaMmFLYVhadEJYOWZ1Q2paZldQd2o0dnBtU1hp?= =?utf-8?B?N3JieGtuMUI1RURxS2I0YmNHTWNFcHpZYUNhbnk0MmpPOUJwZHpiMURkczZo?= =?utf-8?B?WWxhSjFHcUk2ZFdOKzVXQ0h6UzlOMjVUc1ErNTI4K1FXNzVUMG1wcE4xWm9p?= =?utf-8?B?MUF6RjNEMjFSYW4xOGlLMm5GTEdCNXdyVHRCOFlVTzVubHJ6MkVJbC8wLzRm?= =?utf-8?B?dzF2WFJBVWkzWGNTMnNRT2hyVGR4V0d3Qzh2eHJRelRLdi8xcEwxVTk0M0N5?= =?utf-8?B?aDZ3cnd0MnBPT1orcUlMWHozMW5hbXJOOWt0WEphVXVaOUhMSDd5c05FSDhx?= =?utf-8?B?R0s0V0NoSi8vdGIyZ3pJZDYrQ0IxZDZUWTRSQVg3RlpHaWNSbGZiRWpjSi9i?= =?utf-8?B?NC9IR3diSGxhVy8vc1VpV3owTDZ2bUNNbERBSUxSQUphbjBpTkpNKytCNklu?= =?utf-8?B?bzYzSGNlMS9GUXVldktpMFlRKzFMaGhYYVlYTE93bmgvOWg0YTA1eXlISVdu?= =?utf-8?B?Z2dTYm1mbUJrS2gzc2MvTmVscnU0ZW1tb2V2NjNwZ2N5elE0aUFjQng4RU0x?= =?utf-8?B?NzNYY2pJN3RJVWd2a003V0FwTXU5QWN0TG9SWHA0QTlJaFJHSzU1YnJWa3o0?= =?utf-8?B?Wk9JQkdvUTk5dUsyZWdSUkg1VDFCY2FjU2g5dkhjNEl6aFk2eDRWMmtrMWI4?= =?utf-8?B?ei9VZkRQZEtLQmE3YXJzczgyU2ZXOWlqVFFDMjlIOE5mT0hXR09EclVKUXRQ?= =?utf-8?B?VG9yelU5YWlMYjBnaUxuM3JpaklCc09lNTg5MnpqV1NhNU1aY0R0Y2JSRXlx?= =?utf-8?B?R3piUmtlSjh1ZnRQcXhVWmd0SHE1TzBRNTJHUHh6WXlIbGdVa2lCUmcxaTkw?= =?utf-8?B?cnJWTFhpQUs1M2duNHdqQ3Ztcys0NFpaZXg1WU9RTWRuQ0k1YS9BMDlvZFJt?= =?utf-8?B?TVVLMDVuQjIwMXRpRmVwU1RxeWdzbFdTdkhvODZTNU5IM05jUndRMnRBUWlp?= =?utf-8?B?R1c1M0hKcmFZajdvM0pFM3doZG1oMFNodGVMMVo2SWd3SEhlTmxlL3dwYmFy?= =?utf-8?B?YTYrM2FOb29aYlRURWkwSUtQakdWUDNMdm1FODZIcXdLT05RTllYSUhTTE9k?= =?utf-8?B?ZXJ5blI1eEtjSkI4ZHZWYXl1eXJFTkpaUGVTeFlpSVRnWGpoUGdjemt6bmpU?= =?utf-8?B?UmtQalMvdHgrd1UvYmk4QTdmb2ViaC9pQXFIQ1RHS3FTYm9KQzlBL21wNmRx?= =?utf-8?B?enkzeG1pRkExQXBvc0d0eC9HNDJRTzUzMU1KUnhqYTNQWll4cGVkY0N4aVpD?= =?utf-8?B?V3VTekR2Q05SdEhJTGNhQmtOc2FrbkI2UGYrWFFicWUzU0VGT1NaTmowRnVU?= =?utf-8?B?VXhqK1RSRUFscnY1NWVMdlNnR1R4ckFPNWMxRERsWll1bDdWU0ZTdFlZVndp?= =?utf-8?B?VC9IdUdnYjAvcjVVem9tN01JZmhTY1Z2Y2t5alJFaWJyOVdZTlBvRkU4NS9u?= =?utf-8?B?OXJXTVc2bzJYc1haOHUrUkhWNjJTNXpoVG1uK2Fob21zMExlQ0hicUR2d1py?= =?utf-8?B?ZE5rQkVINFZOK1hucGFFYWI0SFlmK2t4VHJabkVLc3ZGelJqQ0RQTkVDSEh2?= =?utf-8?B?QjM2Zjd2NTNNcForSG5WR2pjQytoYlhwK05heGZTbkVWK1JtT1hMSWVZWXV3?= =?utf-8?B?TWkvVGwvbncyekFQa2RPRkFEaGNuTGxKVFpZRDJiUFhaSFNZQ3VoQ2k0M0hC?= =?utf-8?B?emhoRXl6VmdXb20waDVvTlh2YmRqbXcreWI4b1JHWmxGWFE1SERjcG96REFw?= =?utf-8?B?c2JGUThTbTI1UHNiOTRBMDFhNEFVZjJVTTRGSnlHSkRlOXZ6alNFQWhKby9s?= =?utf-8?B?b3c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: JIEbq+NVRWetLuFllSb9sIQnsgFY55ZuZALjQLWMcKzaR3Td7SMp6HgjQ3OlN/39Voe/9tHXulpTNA1eF1Iu9vkCRgL9xax+FBZ+2GF68pTnOgYiS9RdLnazH2rYiiRgzwPno2Ldg+lh9dmt2/zLnKnVBpVpGIVbCe5j33oJZzGBHrQCCGtdwj8j01tVQLdNyflJY4D+BwBWnKrUZlQ/S/HkzJVxCzOMA+OZSp56gC9nSVJGDACmELhrDOw2yp/lEdUqJX+kDRtARd5Qj9/kScC+1/ZmunTknbYy8JDMO3N/9ZvevWOzdOyfYsOg1+tXb7cu6WuTmZ3trA6/Nl9TGH1w4YvJMnafxQzyAj1a4fvjrTzJ+Oe1NOBcBe55ORa1WnkxahLhZysIgaXEBVOQlvCcC+w0Jx2NIbf59LCfVN3A+44VJe1o0qdKWqEeBkKAhnbCxSsqf8sDkc2jVL7SRUWCnkbioG+doDpBFHUTMnMKlT4slRKm4tzYcQIk12gBpyu4uO7Drxo3OtaJWbFg6Q9WQ8jr8pSSFfb0PbopbeiYQcpU2Gd/FP5gV6wPcw4Vg6EayGnivvYYmS79pZS8x0UjR2ZfrrIMlsLIKChmw1YqFCCvBczs3RXR956LOkGQxdj61vBXBzCe/3bSPPAPcBK6fIicKq5WvtNe0qqjWOLccwUnr+Bg1Ronr6qV9GG7jz5CMDAeWXWrubu+mgZTHQeVgKuNlwEP1YrLiFHUUfTmu0W2vtoe2KE3xynE4FbTFvaDl2bYDLDO6lLhNweoCnz5g8XFR0JmBf96HVYGJNuOVxZWjf1/hceqF9MWBrES X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90b9935d-660e-48f8-cdfe-08dad2f67203 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 17:15:14.2361 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HtSOeQy7KFdxnAyRkfUN997gvBHyehdRfJCNeWHzf/tRjiZNAoS2kx5cV+T1WfnaJ88g1Ik0qQHRbmFAoPMXeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6771 DQoNCj4gT24gMzAgTm92IDIwMjIsIGF0IDE2OjU0LCBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29v cGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IEdlbmVyYWxseSBzcGVha2luZywgdGhlIGV2 ZW50IGNoYW5uZWwgbG9jYWwvcmVtb3RlIHBvcnQgaXMgZml4ZWQgZm9yIHRoZQ0KPiBsaWZldGlt ZSBvZiB0aGUgYXNzb2NpYXRlZCBkb21haW4gb2JqZWN0LiAgVGhlIGV4Y2VwdGlvbiB0byB0aGlz IGlzIGENCj4gc2Vjb25kYXJ5IFhTX0lOVFJPRFVDRSAoZGVmaW5lZCB0byByZS1iaW5kIHRvIGEg bmV3IGV2ZW50IGNoYW5uZWwpIHdoaWNoIHBva2VzDQo+IGFyb3VuZCBhdCB0aGUgZG9tYWluIG9i amVjdCdzIGludGVybmFsIHN0YXRlLg0KPiANCj4gV2UgbmVlZCB0byByZWZhY3RvciB0aGUgZXZ0 Y2huIGhhbmRsaW5nIHRvIHN1cHBvcnQgbGl2ZSB1cGRhdGUsIHNvIHN0YXJ0IGJ5DQo+IG1vdmlu ZyB0aGUgcmVsZXZhbnQgbWFuaXB1bGF0aW9uIGludG8gRG9tYWluLg0KPiANCj4gTm8gcHJhY3Rp Y2FsIGNoYW5nZS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5j b29wZXIzQGNpdHJpeC5jb20+DQo+IC0tLQ0KPiBDQzogQ2hyaXN0aWFuIExpbmRpZyA8Y2hyaXN0 aWFuLmxpbmRpZ0BjaXRyaXguY29tPg0KPiBDQzogRGF2aWQgU2NvdHQgPGRhdmVAcmVjb2lsLm9y Zz4NCj4gQ0M6IEVkd2luIFRvcm9rIDxlZHZpbi50b3Jva0BjaXRyaXguY29tPg0KPiBDQzogUm9i IEhvZXMgPFJvYi5Ib2VzQGNpdHJpeC5jb20+DQo+IA0KPiBOb3RlOiBUaGlzIGNoYW5nZSBkZWxp YmVyYXRlbHkgZG9lc24ndCByZXVzZSBEb21haW4uYmluZF9pbnRlcmRvbWFpbiwgd2hpY2ggaXMN Cj4gcmVtb3ZlZCBieSB0aGUgZW5kIG9mIHRoZSByZWZhY3RvcmluZy4NCg0KDQpSZXZpZXdlZC1i eTogRWR3aW4gVMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4NCg0KPiANCj4gdjI6DQo+ ICogTmV3Lg0KPiAtLS0NCj4gdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RvbWFpbi5tbCAgfCAxMiAr KysrKysrKysrKysNCj4gdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3MubWwgfCAgNiArKy0t LS0NCj4gMiBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQ0K PiANCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kb21haW4ubWwgYi90b29s cy9vY2FtbC94ZW5zdG9yZWQvZG9tYWluLm1sDQo+IGluZGV4IGFiMDhkY2YzN2Y2Mi4uZDU5YTk0 MDFlMjExIDEwMDY0NA0KPiAtLS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQvZG9tYWluLm1sDQo+ ICsrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9kb21haW4ubWwNCj4gQEAgLTYzLDYgKzYzLDE4 IEBAIGxldCBzdHJpbmdfb2ZfcG9ydCA9IGZ1bmN0aW9uDQo+IGxldCBkdW1wIGQgY2hhbiA9DQo+ IGZwcmludGYgY2hhbiAiZG9tLCVkLCVuZCwlZFxuIiBkLmlkIGQubWZuIGQucmVtb3RlX3BvcnQN Cj4gDQo+ICtsZXQgcmViaW5kX2V2dGNobiBkIHJlbW90ZV9wb3J0ID0NCj4gKyBiZWdpbiBtYXRj aCBkLnBvcnQgd2l0aA0KPiArIHwgTm9uZSAtPiAoKQ0KPiArIHwgU29tZSBwIC0+IEV2ZW50LnVu YmluZCBkLmV2ZW50Y2huIHANCj4gKyBlbmQ7DQo+ICsgbGV0IGxvY2FsID0gRXZlbnQuYmluZF9p bnRlcmRvbWFpbiBkLmV2ZW50Y2huIGQuaWQgcmVtb3RlX3BvcnQgaW4NCj4gKyBkZWJ1ZyAiZG9t YWluICVkIHJlYmluZCAobCAlcywgciAlZCkgPT4gKGwgJWQsIHIgJWQpIg0KPiArICAgICAgZC5p ZCAoc3RyaW5nX29mX3BvcnQgZC5wb3J0KSBkLnJlbW90ZV9wb3J0DQo+ICsgICAgICAoWGVuZXZl bnRjaG4udG9faW50IGxvY2FsKSByZW1vdGVfcG9ydDsNCj4gKyBkLnJlbW90ZV9wb3J0IDwtIHJl bW90ZV9wb3J0Ow0KPiArIGQucG9ydCA8LSBTb21lIChsb2NhbCkNCj4gKw0KPiBsZXQgbm90aWZ5 IGRvbSA9DQo+IG1hdGNoIGRvbS5wb3J0IHdpdGgNCj4gfCBOb25lIC0+IHdhcm4gImRvbWFpbiAl ZDogYXR0ZW1wdCB0byBub3RpZnkgb24gdW5rbm93biBwb3J0IiBkb20uaWQNCj4gZGlmZiAtLWdp dCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9wcm9jZXNzLm1sIGIvdG9vbHMvb2NhbWwveGVuc3Rv cmVkL3Byb2Nlc3MubWwNCj4gaW5kZXggYjI5NzNhY2EyYTgyLi4yZWE5NDBkN2UyZDUgMTAwNjQ0 DQo+IC0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9wcm9jZXNzLm1sDQo+ICsrKyBiL3Rvb2xz L29jYW1sL3hlbnN0b3JlZC9wcm9jZXNzLm1sDQo+IEBAIC01NjcsMTEgKzU2Nyw5IEBAIGxldCBk b19pbnRyb2R1Y2UgY29uIHQgZG9tYWlucyBjb25zIGRhdGEgPQ0KPiBsZXQgZG9tID0NCj4gaWYg RG9tYWlucy5leGlzdCBkb21haW5zIGRvbWlkIHRoZW4NCj4gbGV0IGVkb20gPSBEb21haW5zLmZp bmQgZG9tYWlucyBkb21pZCBpbg0KPiAtIGlmIChEb21haW4uZ2V0X21mbiBlZG9tKSA9IG1mbiAm JiAoQ29ubmVjdGlvbnMuZmluZF9kb21haW4gY29ucyBkb21pZCkgIT0gY29uIHRoZW4gYmVnaW4N Cj4gKyBpZiAoRG9tYWluLmdldF9tZm4gZWRvbSkgPSBtZm4gJiYgKENvbm5lY3Rpb25zLmZpbmRf ZG9tYWluIGNvbnMgZG9taWQpICE9IGNvbiB0aGVuDQo+ICgqIFVzZSBYU19JTlRST0RVQ0UgZm9y IHJlY3JlYXRpbmcgdGhlIHhlbmJ1cyBldmVudC1jaGFubmVsLiAqKQ0KPiAtIGVkb20ucmVtb3Rl X3BvcnQgPC0gcmVtb3RlX3BvcnQ7DQo+IC0gRG9tYWluLmJpbmRfaW50ZXJkb21haW4gZWRvbTsN Cj4gLSBlbmQ7DQo+ICsgRG9tYWluLnJlYmluZF9ldnRjaG4gZWRvbSByZW1vdGVfcG9ydDsNCj4g ZWRvbQ0KPiBlbHNlIHRyeQ0KPiBsZXQgbmRvbSA9IERvbWFpbnMuY3JlYXRlIGRvbWFpbnMgZG9t aWQgbWZuIHJlbW90ZV9wb3J0IGluDQo+IC0tIA0KPiAyLjExLjANCj4gDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 30 17:16:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 17:16:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450074.707229 (Exim 4.92) (envelope-from ) id 1p0Qgt-0000wo-CU; Wed, 30 Nov 2022 17:16:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450074.707229; Wed, 30 Nov 2022 17:16:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Qgt-0000wg-9M; Wed, 30 Nov 2022 17:16:11 +0000 Received: by outflank-mailman (input) for mailman id 450074; Wed, 30 Nov 2022 17:16:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Qgr-0000ky-Ls for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 17:16:09 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aaf9137b-70d2-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 18:16:04 +0100 (CET) Received: from mail-co1nam11lp2176.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Nov 2022 12:16:02 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by SJ0PR03MB5774.namprd03.prod.outlook.com (2603:10b6:a03:2da::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 17:16:00 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%5]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 17:16:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aaf9137b-70d2-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669828564; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=BANwaHqhI6IT2cJctozGMKaowGCYQ4FuCE6XMZprALA=; b=JssyTUmQabAyAZyV8hYw7bNx8Eo949YDOMF9d3vnRFsKGuaOUP/Ro5Rj V2PAx2ZHJaUNiY/c8ocZLDf1Z/UYoGf71vHFlAGZ7+pfh8EbjdBmYoAaT 6nD+rzaZqXBfjxSLXMP9mhSyMUlqUq3LOTXVkvzq1LiEtjYps6Z2CD7AK Y=; X-IronPort-RemoteIP: 104.47.56.176 X-IronPort-MID: 85904097 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ugEXd6DHflgwqhVW/zriw5YqxClBgxIJ4kV8jS/XYbTApDMr1TAEx 2pJXG/XM/bcNmbyKY0jPdy38UgHvpbTx9I3QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpD5gRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwyL9GKG1Ty M4jFjlQXii/juaM7bSjVbw57igjBJGD0II3nFhFlGicJtF/BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI++xuvDa7IA9ZidABNPLYdsKLQ4NJmVyfp UrN/njjAwFcP9uaodaA2iLx17eTxXKkMG4UPLmgyNBXqlio/W4eGEQ9RVSguMe11UHrDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAIRyBMQMYrv8g3QXotz FDhoj/yLTlmsbnQQnXE8L6R9Gq2IXJMcjFEYjIYRwwY5dWluJs0kh/EUtdkFuiyk8HxHjbzh TuNqUDSmokusCLC7I3jlXivvt5mjsGhotIdjukPYl+Y0w== IronPort-HdrOrdr: A9a23:C/HPda7hh/JzHA6/zwPXwROCI+orL9Y04lQ7vn2ZFiYlEfBwxv rPoB1E737JYW4qKQ0dcdDpAtjlfZquz+8L3WBxB8bvYOCCggCVxe5ZnPPfKlHbak/DH6tmpN pdmstFeZLN5DpB/L3HCWCDer5P/DDEytHTuQ639QY3cegAUdAG0+4NMHfjLqQAfnghOXNWLu v42iKazwDQJEj/aP7VOpD/ZYX+Tifw/q7OUFonHBgh8Q+UkHeC7rPrKRiK0n4lPw9n8PMHyy zoggb57qKsv7WSzQLd7Xba69B7icbs0dxKAe2Lk4wwJi/3ggilSYx9U/na1QpF4d2H2RIPqp 3hsh0gN8N85zf4eXy0mwLk303NwSsj8HjrzH6fmD/GrdbiTDw3JsJdjcZycwff6WAnoNZguZ g7kV6xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeQKU5l/1ewGplVLM7WA7q4oEuF+ djSOvG4uxNTF+cZ3fF+kFy3d2XWGgpFBvueDlAhiXV6UkVoJlK9Tpd+CUtpAZGyHv7cegD2w 3wCNUsqFiJdL5OUUsyPpZYfSL9MB2yffuFChPiHb2gLtBcB5uFke+G3JwloO6tY5AG1500hd DIV05Zr3c7fwb0BdSJx4AjyGGHfIwTZ0WY9ihy3ekxhlTHfsuiDQSTDFQ118ewqfQWBcPWH/ 61JZJNGvfmaW/jA5xA0QHyU4RbbSB2arxZhv8rH1aV5s7bIIzjseLWNP7VObr2CD4hHmfyGG EKUjT/LNhJqkqrRnj7ih7MXG6FQD20wbtgVKzBu+QDwokEMYNB9gATlFSi/8mObSZPt6QnFX EOVo8PUpnL0lVe0Vy4mlmBYCAtfXq9yI+QIU93mQ== X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="85904097" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dkMwq18vhR0CPDBsUc3Y8kcFz5cwnX6G+E0+VZdqudohpH+3ZAmiZQnwdzAfwshq5TMlaMfCB5VvB+riC58qrcz1sSd/R5J8GVhzpCHHNswtuX5dHD5+SEqk+BYxUyEI78SxbM3BkDWxIG21niizgusBjRl6CBgvsleVp2cULDzju7z9kGfafuTAZUrfyqXq+WvvoeZeU2ilxHfiEc9ejXKls7RIMoSqwhnIf2pfshpTrM1j/jPV9vwigSWJl6oyP0k+E5lHaLvlZcM19/sNQsxT2/Iue7+vGEnrR3ChS5/uW6nHklhsWVhdCZT2YIehNcF9oT//Jvvuxy3wXuvgSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BANwaHqhI6IT2cJctozGMKaowGCYQ4FuCE6XMZprALA=; b=OXd8g35VTnrCtNcTShlPvqgRb5zWken590MGL10tnhadf+iY14a9wmatEZPCKtRoKO9rj1ok+p1tWpREI64n9dHpzJMGCaPEckqS+xZWrETtdACZHerqbcFunXkgIuT6fmIHHV78tI/AucngnMFPYp8OeSneuNwh4UgFLMU4lB9LI7nOnPYmCcTh8U5CrzCt2DsGnlG3OcdxDmbT5jkNeoTOi1EhVVnpyvne1TolERkxeDmFh1xzo/qyirILVo+/k9EGaA16kCI6IjtTv2jQCaOGHMD3zaHtGDQJ9qp5PmaQdqlLfwj6Pa7Us9F+Cky/x3Q3hd6assJDtbhj6Fcduw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BANwaHqhI6IT2cJctozGMKaowGCYQ4FuCE6XMZprALA=; b=lMowBhCzSVC4dwl04mGk+vXKKEYGt4iiKKcdc9W85Y7SUnm6Afu6JChvRXJi359lmRyqgV1eJHtMEoKdPbniRHObCUSBqwQ7Nem27mYSsCYnXGBTgMwZxyexSNc2UA3WJYXqAeRb8qzo8mYCZe8V7aNAVAzU7PUvdFD2hMLX7ZU= From: Edwin Torok To: Andrew Cooper CC: Xen-devel , Christian Lindig , David Scott , Rob Hoes Subject: Re: [PATCH v2 3/6] tools/oxenstored: Rename some 'port' variables to 'remote_port' Thread-Topic: [PATCH v2 3/6] tools/oxenstored: Rename some 'port' variables to 'remote_port' Thread-Index: AQHZBNyGOuNzAC/NjkO7rxn7kxYOVa5XtQ+A Date: Wed, 30 Nov 2022 17:16:00 +0000 Message-ID: <63924CC6-CACB-402F-AF7D-87F243DE0585@citrix.com> References: <20221130165455.31125-1-andrew.cooper3@citrix.com> <20221130165455.31125-4-andrew.cooper3@citrix.com> In-Reply-To: <20221130165455.31125-4-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|SJ0PR03MB5774:EE_ x-ms-office365-filtering-correlation-id: 45472641-8abb-4178-07f3-08dad2f68d7a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sp3L3mnw/+Xrny/dQDWMZdmRxPAmxuEpi3scOaB1XWI6iq8c3d559SbzFRUkYB5lk+K2Q0XW/2QtTElX6qefG85PIryZCFaD5YjLpRHCp9w93OnOb1hkbQHlCubiCr5QXJxzVUf7BKDp3G9p6ygQbofQgU3Q7mNjIggTE2v4lAaphIhjjtccY28uJZb+jRdKmPuj0y12fTSOayJUogciHhCZbUaHNTaytFD7Klh6tYH40zNRKV5JMCDFxOeXRCHIbqq2jhuPg8dzCzvolzMHZMcv5/G8dXjlQJDABU9qW8CDxM5Pk7ROxJQh71H2JMdm+Z2LZdfBkKoJyMiXxUGz4iTj+DYu0DGRfJdco8akCRadocioi5WcUJMAUtJyCCMXAxDJUQu/V8jG80KrrMvP9iBCt84ikhIp9f4O+iKq36wLxMwfVdVdRzFdbQ+MMIdVXfOfRkkm8Wkjb1Rv+iSfnC54CDKFvQlJR8sfEMFLIdlmG4CZJ3NBRmy/zMdVlmB2kVXQyRpEp5wnHh4uSHtuF70jm7GypKJBRPG2WlHVHSzkO79DC/HytwvbBMdCOfJyVHjD66oWJD2yjGCuVgOV+HQIE0YZck8+8BcHqoaOk6hggSms+60L8xLdyY2yNqqjCzAbyzyUXsbG14FSQvpsZyI5/n6l6kmjyIUleb2z1vWB8piZoqrDdEhO2MhdSBY9vom9J2OEb/bhCz4WS0zcFl57pAj8hE97lu2UpIgeY3Y= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(366004)(346002)(136003)(451199015)(66574015)(83380400001)(2616005)(53546011)(6506007)(6512007)(186003)(26005)(71200400001)(478600001)(41300700001)(36756003)(107886003)(2906002)(6636002)(122000001)(316002)(8676002)(54906003)(4326008)(76116006)(37006003)(91956017)(38100700002)(82960400001)(6486002)(66476007)(66946007)(66446008)(66556008)(33656002)(86362001)(64756008)(8936002)(6862004)(38070700005)(5660300002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UEVYeFNGNVBseUU4SUhVODZQNTZRSWZMUlNTZFI1M3c5SWNKSXVnYkdzZWk1?= =?utf-8?B?TjBEZlowcDRVVU9SdTJnclh6OEZGVjlQNWpPVlFyTitDL0MxWUtpM1k0Y2pw?= =?utf-8?B?ZEllMnFLQjhrWCswQm5RVERMY0kvS0lpVlNZNnJzOHRYZldTMHByV3FGUGhm?= =?utf-8?B?Q3dOcG1zZ1VmSncra3ZGYklCQUx2dm5MREw4YzBBRktqd253Y2dEUms0blMr?= =?utf-8?B?L1FTR2dLWmJxM1FvNS9RcU81OHZJbU5aOHk0UHNaN0dmQ3B3Z2F4Z2RYeFZq?= =?utf-8?B?Y3BWbUJkYTZuNkMyQksrZy80TzU2N3FpaGUzZjNlcjZzRmE0OVdnMnZGaFFx?= =?utf-8?B?dUVyc1AyZEdOODR1OCt6S2tPL3R2QjZyNkVzU1U2VVpkYnJMYkVEa0Iza2Iv?= =?utf-8?B?ZXZBd3NvbkVFVURUVy9WM0gwY1pvc3FUa1piaGF4YVh6Zk1wWDNPbjdMRzFu?= =?utf-8?B?NnNGcVFkL3dLMW44YUJYUDBHVy82Vk9vT3huY0Y0K3JFdGlNYVF6Q0V2R2ha?= =?utf-8?B?Uzd3aW1wRnFDaW9Kem1nWnFSVUJPL21RWDlnbXRiVCtlNzFjdTUzVXRINEtw?= =?utf-8?B?MlZBS1E5Zjd0bUp6WEd1MUYzNE1oK2dLQnBDYkJKR09RM3F1ZUF5VTVmR2pG?= =?utf-8?B?ak5uU3MyVFEyS1E1bXJHZjN1VjV6T3dsQmRqN1BEQkN6aEl3MFZpREF6MFdV?= =?utf-8?B?WStMY3ZVTk5IalB0bkM4dGpla1ZhaXAwRXBoQ1JWVzBjeHViQTZOWnVaZ1hi?= =?utf-8?B?ZWRvQ2YyR0hWc3UzQVhWWnFCcGFYQzV2K3ZENHlDNTZjdTY0aEgzSjFlaDFE?= =?utf-8?B?SHVQcEFVaEpmTExHajFndWg1UTZPSWhRaUxleUFMTE1VRllIMDlBWHdyYUhz?= =?utf-8?B?ZDRPRGpQY1IraFRydUJ1UXhsTnBFQVNySGt0ZWxycHdKSXRSeW9FUnhxalVn?= =?utf-8?B?ZWNnbWZ3UWRETldldXU3TVpkOEt0R0ZlWkc5WktoYnlDaGZrR2dURVEydVNu?= =?utf-8?B?NUF3TGpydDRyYkx3Y2VtYlJYUSthVXR2aXNjdm15cnRQVHA4ZGNmc242NmFC?= =?utf-8?B?STRsUHZQNy9tTkJadUdad1NwRnJrRHlsQnhPdEgyK0hwK3BZVUZwcTdTNmRo?= =?utf-8?B?VHlVZWY5UEhGV0Y5dXZ6aVZ1dGJIOUV0NXVwTHZRamRtamZ5UjJKVXhDdFpj?= =?utf-8?B?TmdhRm9hcG56WkhsbERPUjU4NjMvMVdqQ3RvQnc1YXU2VXVhdk1YYzBkVVgr?= =?utf-8?B?cjdaWXp0elF5dEdqN2dSdlNnTVZnNGtQTmdKY0taMWNxOEZHOUdKTHR3SWJw?= =?utf-8?B?TTRqWFBFb21kQnhGQWwwYkxVVU1lZUFtamNiU2p4dGZxdjRvL2M3ZW5CVGJU?= =?utf-8?B?WkpiUm0vQmJDOTFqR2tUaFZQUnRsS3E3U2k0WU05dXQvY0dSS0RaN0RrajZ3?= =?utf-8?B?QU5mWmJ1ZUdPUGNtTzB5a1p1b3MxVjJXVER2dHFGaHVzSHNyaEVSVk55VnFD?= =?utf-8?B?cXdwWkNCMnU3UWx0RUFYWWVKTjFEa2JPWEdLMHNiYmVWM1EyanBsd002a0lX?= =?utf-8?B?NlhERGNrb2pic0QwVFYrM3pHbmFRS3c5SFZUcU9vSlFuZlQ5K2xIZVFIUkNI?= =?utf-8?B?em1CUEZ6TFI1dk5yYW02d3V1WFVhVkN0MXpLV2lXVW14eU1hUjZzd3VOU0k3?= =?utf-8?B?TXdCRThDcWxwWGFkb2RnNU9FNkpodk1yS0NIaGtsVXZZRnN2OWxBVHYwU1Q1?= =?utf-8?B?TU85U3EzaUZFMFZBZk9PdTBPbHNwRm9XSFJ0Um55UWRTSFE1bUFMSUJOWXJt?= =?utf-8?B?WGFMd01TV0RCR20vdWxWWWUxeDhXUjB3Q3dsYTBHcTFJRWNEelExYjYvTmQ0?= =?utf-8?B?RENFakhPNnV4ZkZmVHpPRUZLWHNydnczYnNqWkVQeE9DSndMdG9McGtPdDdF?= =?utf-8?B?M2dtU2pNNVdXckhIMVM3bGZTUm8vLzFiTUhoWC9CWStkdUVGMkFxeXRPQm43?= =?utf-8?B?a0F0QmlPQm0zZHJxZ1htbHNSeW04NitBYVhEbkdoWlhNTzFIQjYyUUlPKzBn?= =?utf-8?B?T2dvOXVnZzNPbDFPQkhiM2tTQm9oNUtUcGZsTFBVekZ0NG1EaGlVL2hyb2l3?= =?utf-8?B?bTNaYUtTN2J1OGJjSS9wOHJ4OUpOVkJxNDNwVjlyN3IwWWtMRlVHQXBLYmZJ?= =?utf-8?B?bHc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DlnhHjjKfs32TKtoAoHDd9oldd5N0FGqxOmfqotJomS+cz1rcMgUZ5ASThZmAGmSFT8+tCo3T4Pk85reSK+n26amES6kUItSUjURfER2B5E3PKKEUBs1rPqyZhM7UuXlzLXHT6HnPi0o4pxm9RH5k2IOlH1aWPj6PtNCq2yr0MtTYEfZ478GxjH51uW2OJizSFk9wTWfcqdvGZAu9mB2d1yMtk4jOzg6SnOb+1hDaZiK5+WazqxI+eE/0l5HUm17RQ/6OfB4XrGylisjFhYhTK+te6PbxMNuZRi8xHuqcpuGfzUHPk3Br6sSmOXZrTWRwCkBssEYTwLQeV3Opm2+476CDPmPCO4ZU9ZV4+Co4/ryE9XujtRuUwNhXcOQd3J9kvR3IWcjmbt94lBCJgk7TQp3YAeEyOQh4WjI2eK7C+Prn3Zhuc0rmPRsrNeYoFgtpNfeTHV+WqPhkfAsQl1NkEdj0YJuK6UduS4ly3TKoPr6JRIoLg1CKHlr6eCoF5ZXCp4J1P8BoBXqvI+LjoVKtuQpay23NFcNHnMDxzoYCbjVwe/tgLGsp7CAGwRNUpdVE9B1N1tBJwknLb04QoIeIQY5/6xUejuJQ90Xkm6yoXSL26PtrxxgbPgrUQQTeWAwTN2uxYW9cyFCNxYJbkylCI0oM7wtVwuUiUY7ua/WydgRPDjzMOGginzZ1ZjZJmfoO1RZh76PyyJWpG4HuGFFe2UaluYwMaLiCRWn5rz7zP863hIJjZ/iMmCqBGuPFBojMTS+VqA2c29OGUCe8RJtm9lcXnGNWu3Dnzu0E9wqspTxO8TRkKUeBE6yluk10Zzu X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45472641-8abb-4178-07f3-08dad2f68d7a X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 17:16:00.3562 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Su/yK/HDqU06pW26bJ36oHzIxRq3nkSkUHQjop3EF4Fdo1OdTN3pu5eefijA/NXzyvBS22M0ldNw8Kui7ZX+fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5774 DQoNCj4gT24gMzAgTm92IDIwMjIsIGF0IDE2OjU0LCBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29v cGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IFRoaXMgd2lsbCBtYWtlIHRoZSBsb2dpYyBj bGVhcmVyIHdoZW4gd2UgcGx1bWIgbG9jYWxfcG9ydCB0aHJvdWdoIHRoZXNlDQo+IGZ1bmN0aW9u cy4NCj4gDQo+IFdoaWxlIGNoYW5naW5nIHRoaXMsIHNpbXBsaWZ5IHRoZSBjb25zdHJ1Y3QgaW4g RG9tYWlucy5jcmVhdGUwIHRvIHNlcGFyYXRlIHRoZQ0KPiByZW1vdGUgcG9ydCBoYW5kbGluZyBm cm9tIHRoZSBpbnRlcmZhY2UuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxh bmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiAtLS0NCj4gQ0M6IENocmlzdGlhbiBMaW5kaWcg PGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4NCj4gQ0M6IERhdmlkIFNjb3R0IDxkYXZlQHJl Y29pbC5vcmc+DQo+IENDOiBFZHdpbiBUb3JvayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4NCj4g Q0M6IFJvYiBIb2VzIDxSb2IuSG9lc0BjaXRyaXguY29tPg0KDQpXZSd2ZSByZXZpZXdlZCB0aGlz IGNoYW5nZSBpbi1wZXJzb246DQpSZXZpZXdlZC1ieTogRWR3aW4gVMO2csO2ayA8ZWR2aW4udG9y b2tAY2l0cml4LmNvbT4NCg0KDQo+IA0KPiB2MjoNCj4gKiBOZXcuDQo+IC0tLQ0KPiB0b29scy9v Y2FtbC94ZW5zdG9yZWQvZG9tYWlucy5tbCAgIHwgMjYgKysrKysrKysrKysrLS0tLS0tLS0tLS0t LS0NCj4gdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3MubWwgICB8IDEyICsrKysrKy0tLS0t LQ0KPiB0b29scy9vY2FtbC94ZW5zdG9yZWQveGVuc3RvcmVkLm1sIHwgIDggKysrKy0tLS0NCj4g MyBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkNCj4gDQo+ IGRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvZG9tYWlucy5tbCBiL3Rvb2xzL29j YW1sL3hlbnN0b3JlZC9kb21haW5zLm1sDQo+IGluZGV4IDE3ZmUyZmEyNTc3Mi4uMjYwMThhYzBk ZDNkIDEwMDY0NA0KPiAtLS0gYS90b29scy9vY2FtbC94ZW5zdG9yZWQvZG9tYWlucy5tbA0KPiAr KysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvZG9tYWlucy5tbA0KPiBAQCAtMTIyLDkgKzEyMiw5 IEBAIGxldCBjbGVhbnVwIGRvbXMgPQ0KPiBsZXQgcmVzdW1lIF9kb21zIF9kb21pZCA9DQo+ICgp DQo+IA0KPiAtbGV0IGNyZWF0ZSBkb21zIGRvbWlkIG1mbiBwb3J0ID0NCj4gK2xldCBjcmVhdGUg ZG9tcyBkb21pZCBtZm4gcmVtb3RlX3BvcnQgPQ0KPiBsZXQgaW50ZXJmYWNlID0gWGVuY3RybC5t YXBfZm9yZWlnbl9yYW5nZSB4YyBkb21pZCAoWGVubW1hcC5nZXRwYWdlc2l6ZSgpKSBtZm4gaW4N Cj4gLSBsZXQgZG9tID0gRG9tYWluLm1ha2UgZG9taWQgbWZuIHBvcnQgaW50ZXJmYWNlIGRvbXMu ZXZlbnRjaG4gaW4NCj4gKyBsZXQgZG9tID0gRG9tYWluLm1ha2UgZG9taWQgbWZuIHJlbW90ZV9w b3J0IGludGVyZmFjZSBkb21zLmV2ZW50Y2huIGluDQo+IEhhc2h0YmwuYWRkIGRvbXMudGFibGUg ZG9taWQgZG9tOw0KPiBEb21haW4uYmluZF9pbnRlcmRvbWFpbiBkb207DQo+IGRvbQ0KPiBAQCAt MTMzLDE4ICsxMzMsMTYgQEAgbGV0IHhlbnN0b3JlZF9rdmEgPSByZWYgIiINCj4gbGV0IHhlbnN0 b3JlZF9wb3J0ID0gcmVmICIiDQo+IA0KPiBsZXQgY3JlYXRlMCBkb21zID0NCj4gLSBsZXQgcG9y dCwgaW50ZXJmYWNlID0NCj4gLSAoDQo+IC0gbGV0IHBvcnQgPSBVdGlscy5yZWFkX2ZpbGVfc2lu Z2xlX2ludGVnZXIgIXhlbnN0b3JlZF9wb3J0DQo+IC0gYW5kIGZkID0gVW5peC5vcGVuZmlsZSAh eGVuc3RvcmVkX2t2YQ0KPiAtICAgICAgIFsgVW5peC5PX1JEV1IgXSAwbzYwMCBpbg0KPiAtIGxl dCBpbnRlcmZhY2UgPSBYZW5tbWFwLm1tYXAgZmQgWGVubW1hcC5SRFdSIFhlbm1tYXAuU0hBUkVE DQo+IC0gIChYZW5tbWFwLmdldHBhZ2VzaXplKCkpIDAgaW4NCj4gLSBVbml4LmNsb3NlIGZkOw0K PiAtIHBvcnQsIGludGVyZmFjZQ0KPiAtICkNCj4gLSBpbg0KPiAtIGxldCBkb20gPSBEb21haW4u bWFrZSAwIE5hdGl2ZWludC56ZXJvIHBvcnQgaW50ZXJmYWNlIGRvbXMuZXZlbnRjaG4gaW4NCj4g KyBsZXQgcmVtb3RlX3BvcnQgPSBVdGlscy5yZWFkX2ZpbGVfc2luZ2xlX2ludGVnZXIgIXhlbnN0 b3JlZF9wb3J0IGluDQo+ICsNCj4gKyBsZXQgaW50ZXJmYWNlID0NCj4gKyBsZXQgZmQgPSBVbml4 Lm9wZW5maWxlICF4ZW5zdG9yZWRfa3ZhIFsgVW5peC5PX1JEV1IgXSAwbzYwMCBpbg0KPiArIGxl dCBpbnRlcmZhY2UgPSBYZW5tbWFwLm1tYXAgZmQgWGVubW1hcC5SRFdSIFhlbm1tYXAuU0hBUkVE IChYZW5tbWFwLmdldHBhZ2VzaXplKCkpIDAgaW4NCj4gKyBVbml4LmNsb3NlIGZkOw0KPiArIGlu dGVyZmFjZQ0KPiArIGluDQo+ICsNCj4gKyBsZXQgZG9tID0gRG9tYWluLm1ha2UgMCBOYXRpdmVp bnQuemVybyByZW1vdGVfcG9ydCBpbnRlcmZhY2UgZG9tcy5ldmVudGNobiBpbg0KPiBIYXNodGJs LmFkZCBkb21zLnRhYmxlIDAgZG9tOw0KPiBEb21haW4uYmluZF9pbnRlcmRvbWFpbiBkb207DQo+ IERvbWFpbi5ub3RpZnkgZG9tOw0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVk L3Byb2Nlc3MubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbA0KPiBpbmRleCA3 MmE3OWU5MzI4ZGQuLmIyOTczYWNhMmE4MiAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvb2NhbWwveGVu c3RvcmVkL3Byb2Nlc3MubWwNCj4gKysrIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3Mu bWwNCj4gQEAgLTU1OCwxMCArNTU4LDEwIEBAIGxldCBkb190cmFuc2FjdGlvbl9lbmQgY29uIHQg ZG9tYWlucyBjb25zIGRhdGEgPQ0KPiBsZXQgZG9faW50cm9kdWNlIGNvbiB0IGRvbWFpbnMgY29u cyBkYXRhID0NCj4gaWYgbm90IChDb25uZWN0aW9uLmlzX2RvbTAgY29uKQ0KPiB0aGVuIHJhaXNl IERlZmluZS5QZXJtaXNzaW9uX2RlbmllZDsNCj4gLSBsZXQgKGRvbWlkLCBtZm4sIHBvcnQpID0N Cj4gKyBsZXQgKGRvbWlkLCBtZm4sIHJlbW90ZV9wb3J0KSA9DQo+IG1hdGNoIChzcGxpdCBOb25l ICdcMDAwJyBkYXRhKSB3aXRoDQo+IC0gfCBkb21pZCA6OiBtZm4gOjogcG9ydCA6OiBfIC0+DQo+ IC0gaW50X29mX3N0cmluZyBkb21pZCwgTmF0aXZlaW50Lm9mX3N0cmluZyBtZm4sIGludF9vZl9z dHJpbmcgcG9ydA0KPiArIHwgZG9taWQgOjogbWZuIDo6IHJlbW90ZV9wb3J0IDo6IF8gLT4NCj4g KyBpbnRfb2Zfc3RyaW5nIGRvbWlkLCBOYXRpdmVpbnQub2Zfc3RyaW5nIG1mbiwgaW50X29mX3N0 cmluZyByZW1vdGVfcG9ydA0KPiB8IF8gICAgICAgICAgICAgICAgICAgICAgICAgLT4gcmFpc2Ug SW52YWxpZF9DbWRfQXJnczsNCj4gaW4NCj4gbGV0IGRvbSA9DQo+IEBAIC01NjksMTggKzU2OSwx OCBAQCBsZXQgZG9faW50cm9kdWNlIGNvbiB0IGRvbWFpbnMgY29ucyBkYXRhID0NCj4gbGV0IGVk b20gPSBEb21haW5zLmZpbmQgZG9tYWlucyBkb21pZCBpbg0KPiBpZiAoRG9tYWluLmdldF9tZm4g ZWRvbSkgPSBtZm4gJiYgKENvbm5lY3Rpb25zLmZpbmRfZG9tYWluIGNvbnMgZG9taWQpICE9IGNv biB0aGVuIGJlZ2luDQo+ICgqIFVzZSBYU19JTlRST0RVQ0UgZm9yIHJlY3JlYXRpbmcgdGhlIHhl bmJ1cyBldmVudC1jaGFubmVsLiAqKQ0KPiAtIGVkb20ucmVtb3RlX3BvcnQgPC0gcG9ydDsNCj4g KyBlZG9tLnJlbW90ZV9wb3J0IDwtIHJlbW90ZV9wb3J0Ow0KPiBEb21haW4uYmluZF9pbnRlcmRv bWFpbiBlZG9tOw0KPiBlbmQ7DQo+IGVkb20NCj4gZWxzZSB0cnkNCj4gLSBsZXQgbmRvbSA9IERv bWFpbnMuY3JlYXRlIGRvbWFpbnMgZG9taWQgbWZuIHBvcnQgaW4NCj4gKyBsZXQgbmRvbSA9IERv bWFpbnMuY3JlYXRlIGRvbWFpbnMgZG9taWQgbWZuIHJlbW90ZV9wb3J0IGluDQo+IENvbm5lY3Rp b25zLmFkZF9kb21haW4gY29ucyBuZG9tOw0KPiBDb25uZWN0aW9ucy5maXJlX3NwZWNfd2F0Y2hl cyAoVHJhbnNhY3Rpb24uZ2V0X3Jvb3QgdCkgY29ucyBTdG9yZS5QYXRoLmludHJvZHVjZV9kb21h aW47DQo+IG5kb20NCj4gd2l0aCBfIC0+IHJhaXNlIEludmFsaWRfQ21kX0FyZ3MNCj4gaW4NCj4g LSBpZiAoRG9tYWluLmdldF9yZW1vdGVfcG9ydCBkb20pIDw+IHBvcnQgfHwgKERvbWFpbi5nZXRf bWZuIGRvbSkgPD4gbWZuIHRoZW4NCj4gKyBpZiAoRG9tYWluLmdldF9yZW1vdGVfcG9ydCBkb20p IDw+IHJlbW90ZV9wb3J0IHx8IChEb21haW4uZ2V0X21mbiBkb20pIDw+IG1mbiB0aGVuDQo+IHJh aXNlIERvbWFpbl9ub3RfbWF0Y2gNCj4gDQo+IGxldCBkb19yZWxlYXNlIGNvbiB0IGRvbWFpbnMg Y29ucyBkYXRhID0NCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC94ZW5zdG9y ZWQubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQveGVuc3RvcmVkLm1sDQo+IGluZGV4IDU1MDcx YjQ5ZWNjYi4uMWYxMWY1NzZiNTE1IDEwMDY0NA0KPiAtLS0gYS90b29scy9vY2FtbC94ZW5zdG9y ZWQveGVuc3RvcmVkLm1sDQo+ICsrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC94ZW5zdG9yZWQu bWwNCj4gQEAgLTE2NywxMCArMTY3LDEwIEBAIGxldCBmcm9tX2NoYW5uZWxfZiBjaGFuIGdsb2Jh bF9mIHNvY2tldF9mIGRvbWFpbl9mIHdhdGNoX2Ygc3RvcmVfZiA9DQo+IGdsb2JhbF9mIH5ydw0K PiB8ICJzb2NrZXQiIDo6IGZkIDo6IFtdIC0+DQo+IHNvY2tldF9mIH5mZDooaW50X29mX3N0cmlu ZyBmZCkNCj4gLSB8ICJkb20iIDo6IGRvbWlkIDo6IG1mbiA6OiBwb3J0IDo6IFtdLT4NCj4gKyB8 ICJkb20iIDo6IGRvbWlkIDo6IG1mbiA6OiByZW1vdGVfcG9ydCA6OiBbXS0+DQo+IGRvbWFpbl9m IChpbnRfb2Zfc3RyaW5nIGRvbWlkKQ0KPiAgICAgICAgIChOYXRpdmVpbnQub2Zfc3RyaW5nIG1m bikNCj4gLSAgICAgICAgIChpbnRfb2Zfc3RyaW5nIHBvcnQpDQo+ICsgICAgICAgICAoaW50X29m X3N0cmluZyByZW1vdGVfcG9ydCkNCj4gfCAid2F0Y2giIDo6IGRvbWlkIDo6IHBhdGggOjogdG9r ZW4gOjogW10gLT4NCj4gd2F0Y2hfZiAoaW50X29mX3N0cmluZyBkb21pZCkNCj4gICAgICAgICh1 bmhleGlmeSBwYXRoKSAodW5oZXhpZnkgdG9rZW4pDQo+IEBAIC0yMDksMTAgKzIwOSwxMCBAQCBs ZXQgZnJvbV9jaGFubmVsIHN0b3JlIGNvbnMgZG9tcyBjaGFuID0NCj4gZWxzZQ0KPiB3YXJuICJJ Z25vcmluZyBpbnZhbGlkIHNvY2tldCBGRCAlZCIgZmQNCj4gaW4NCj4gLSBsZXQgZG9tYWluX2Yg ZG9taWQgbWZuIHBvcnQgPQ0KPiArIGxldCBkb21haW5fZiBkb21pZCBtZm4gcmVtb3RlX3BvcnQg PQ0KPiBsZXQgbmRvbSA9DQo+IGlmIGRvbWlkID4gMCB0aGVuDQo+IC0gRG9tYWlucy5jcmVhdGUg ZG9tcyBkb21pZCBtZm4gcG9ydA0KPiArIERvbWFpbnMuY3JlYXRlIGRvbXMgZG9taWQgbWZuIHJl bW90ZV9wb3J0DQo+IGVsc2UNCj4gRG9tYWlucy5jcmVhdGUwIGRvbXMNCj4gaW4NCj4gLS0gDQo+ IDIuMTEuMA0KPiANCg0K From xen-devel-bounces@lists.xenproject.org Wed Nov 30 17:16:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 17:16:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450075.707240 (Exim 4.92) (envelope-from ) id 1p0Qh8-0001JE-Jw; Wed, 30 Nov 2022 17:16:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450075.707240; Wed, 30 Nov 2022 17:16:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Qh8-0001J7-H1; Wed, 30 Nov 2022 17:16:26 +0000 Received: by outflank-mailman (input) for mailman id 450075; Wed, 30 Nov 2022 17:16:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Qh7-0000ky-Al for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 17:16:25 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b6995734-70d2-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 18:16:24 +0100 (CET) Received: from mail-co1nam11lp2169.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Nov 2022 12:16:22 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by SJ0PR03MB5774.namprd03.prod.outlook.com (2603:10b6:a03:2da::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 17:16:20 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%5]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 17:16:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6995734-70d2-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669828584; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=8XuEESIUVAf3nFKmdhUjcwz2VcWpkX6PfwwH39adzto=; b=Nj3oz1ufSUjlJp7FiUntbwO9KyKyVZwkX/Jr55IhzdkP++sqYFWRP4A6 Pp9j6M9Kqek2ykeihnagOZu5/mdTtcXp82ppiYSJZuLKrvgY1mPu/fx8D ptGbB/Q7fpYLwLlyyduHR1y1JJwrfkqir6Sgu54opQhNi+sV0k+ug6EHm o=; X-IronPort-RemoteIP: 104.47.56.169 X-IronPort-MID: 85904162 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:hQvC7qstBsDgNGlALXjKipYTUefnVEVfMUV32f8akzHdYApBsoF/q tZmKWiCPPmONjHyKox0PI22/UoHvsTRz9VnSAdsrn1kRS0Q+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaFzyFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwBQ8SMEinlqWN0K+EE/FjgO14HNvWFdZK0p1g5Wmx4fcOZ7nmGvyPzvgBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjv60bou9lt+iHK25mm6Vq nzH+SLlBQsdN/SUyCaf82LqjejK9c/+cNJPReXkr6Aw6LGV7mMjVTIVe3CZm+aou0+3UtV9d nxIxgN7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3Oc6TCIn/ kWElNToAXpoqrL9dJ6G3rKdrDf3Mi9MK2YHPHYAVVFcvYilp5wvhBXSSNolCLSyktD+BTD3x XaNsTQ6gLIQy8UM0s1X4Gz6vt5lnbCRJiZd2+kddjvNAt9RDGJ9W7GV1A== IronPort-HdrOrdr: A9a23:Qgfc+qPTKcewZ8BcTxr255DYdb4zR+YMi2TDiHoBKiC9I/b5qy nxppUmPEfP+UossHFJo6HlBEDyewKiyXcV2/hcAV7GZmLbUQSTXflfBOfZsl/d8mjFh5NgPM RbAudD4b/LfCNHZK/BiWHXLz9j+qj8zEnBv5aE854Hd3AMV0gU1XYBNu/tKDwReOApP+tdKH JBjvA3+gZIf055Ui1BPBQ4thL4zeHjpdbHehgAHhg99U2kiz650r7oH3Gjsis2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv+/olbg9zoz/pEHYiphtIOIjvhpw60bMA5Mofy/QwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/AyhTtyzEn7l7l0Bu9jWH4qcL0aTomA45qhJ5fcDHe90081esMnp 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2FfeZF2Us4QkaUvuGduVLsQFiPz744qVM N0CtvH2fpQeVSGK1jEo2hUxsC2VHhbJGbEfqFCgL3W79FlpgE886Iq/r1Zop7GzuN6d3Bw3Z WADk2vrsAWciZZV9MkOA5Le7rINoWEe2O8DIvVGyW8KEhPAQO8l7fnpLoy/+2kY5oO0d87n4 nASkpRsSood1vpEtDm5uwBzvljehTIYd3B8LAW23FCgMy1eJP7dSmYDFw+mcqppPsSRsXdRv aoIZpTR/vuN3HnF4pF1xD3H8A6EwhSbOQF/tIgH16eqMPCLYPn8uTdbfbIPbLoVTIpQHn2DH cPVCX6YM9A8keoUHnlhwW5YQKmRmXvuZZrVKTK9ekaz4YAcoVKrwgOkFy8otqGLDVT25ZGCn eW4ImX5Z9TiVPGiFogtV8ZSSa1Jnwlkondbw== X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="85904162" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pc8PL864qek7RdU0y6hnx01evzvvcZc6WKUuN3iUbITZVTpAXVQSAMd+HJ0aQt9tuL9xQcSLsHFaLGvX+xV+izmt4tAQHZTWhAk+P/rWKsSc4UOWb09wPDspgL1i1qYVduEArkZ6ylZ+P0wcvGeFUB0TMc/3l3CwzScjxq3EtK08dNrKJyZkBlpJNEL/X75zsaR/E66ZqaBOvXtXnz3+m+Wk4yGZ04JIBGWwnrx1ZclFUmpsMan1RQ7sFAYlDzjYjmbIhKUbe63fxKSr2VGuiFxB2bzJ6SHumD654O7yG3PM/B4GC6f4o8x0MMr73kH6udBA7KQNc8pCS1grm2juPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8XuEESIUVAf3nFKmdhUjcwz2VcWpkX6PfwwH39adzto=; b=Vt72nIl8bJUZMu1Y+QUIFPjiImvBSvyrMIndXvfNQekwQbonBmGFmktk54cwkskENGd6TyT5YBPKIjg4GTdgIZTQx3vYCr45oWlCZaND4VRWC6zZWnfjXGFM8JUDk2tyUmZZl7hfkGDInm1jlcveQDrBKLzzhVOc5khnmIUYre52h3OWBjLzwDtfcNuW9lwYjNkOTV7SQzYSZLsfrNxQaOCzAyNy5/DgLeJszEKauKS1EL+0p4UV2L9P2/01Ftro2XX2IBg5wVpk6Hpnu2e/rmpyL+AVL2cgeI30xFZFxtA6Cckh2RxzPxLnS7nDLHFKdntXrrxdQgaYFc177eqyvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8XuEESIUVAf3nFKmdhUjcwz2VcWpkX6PfwwH39adzto=; b=MoSE7SvMXfdXsprBEoxQ8HXcVtbPObIEZJHL7E0RepbsVQt6XnCRAC05mO4t7XM6F+lViWnVLtQKW8PBTwljyQTxUENz8E33aSq5xica4MrA/FaTgcDpqNZ2qiMj9OJ4jD/r76M566Hjy9cEN+OEXzaTkbZUUIBWzuMIyLP3FU8= From: Edwin Torok To: Andrew Cooper CC: Xen-devel , Christian Lindig , David Scott , Rob Hoes Subject: Re: [PATCH v2 2/6] tools/oxenstored: Bind the DOM_EXC VIRQ in in Event.init() Thread-Topic: [PATCH v2 2/6] tools/oxenstored: Bind the DOM_EXC VIRQ in in Event.init() Thread-Index: AQHZBNyFjTFW7WdVpk6WP9HBQn+OQa5XtSgA Date: Wed, 30 Nov 2022 17:16:20 +0000 Message-ID: References: <20221130165455.31125-1-andrew.cooper3@citrix.com> <20221130165455.31125-3-andrew.cooper3@citrix.com> In-Reply-To: <20221130165455.31125-3-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|SJ0PR03MB5774:EE_ x-ms-office365-filtering-correlation-id: 561ca59c-3d30-4524-edbc-08dad2f69996 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: is0wTqZnOb/xhmIz1GgPLK7ntGK8433K52DkiLjb3Mku2qtaETRPegkxvIkgO0qUpNKw0/oPDTqlI2yITIwZM7lRWmrjT5x708OzUvn1BPVlg+xyfZvdJxNF7p6yL6oLc153la+OskzKUavBpbFROBdVVXmf3yjxotMMOE5XAtpnDcB1hfb9WGerp4roBBTqNn4YZITF1k6JQMCUam0z1RH0QJ8ZmKy2NN2QDmOwFbdFCLNp4Cx6YZ9JiW6nJfDuIB/MxoVj6DvARI1tnZ9G/zcJ45WcvzPTbLSeXgVN6DNoFFD2BktdA+PfwEnNcpRyBG7FF68yVrDkLSWu3HidfhTyzyb4Z0ISwSHxgxVhtxwDDskOKNlHXLO9EMVln6GCbuJdTRv9qjdFklkxVSf2fk/SGSaMuhIFPFdS7VSqfZcmQMT0DRkPWAhwUvrPAXetVblfmzL1kgmCbLX7pV7lPouuR4oq2kl1N8Q9TC8RabYLMPXwywMicgOpDKnIwjLtKA78doz2DLraJd7YPLTbLuqfjW5gCXuoKgyB9zZ+x7+KS8T2who538u99a/vDrsKd5Q5ceP4hKrAK/5NVw1YxsvBZdt/MCRzdIMLkFE0syhV7G8ZmMJkvBdlqvNYv0JTDBdKta53qZdEDF6+Hi1xKUYob9GyBhFg9Yh28yaXvjXhurtWnDy48v25O3UgFndX5FdgN9kUE10E3fH8JlEIguTUDbimUXkQtgVeP7MP9Zo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(366004)(346002)(136003)(451199015)(66574015)(83380400001)(2616005)(53546011)(6506007)(6512007)(186003)(26005)(71200400001)(478600001)(41300700001)(36756003)(107886003)(2906002)(6636002)(122000001)(316002)(8676002)(54906003)(4326008)(76116006)(37006003)(91956017)(38100700002)(82960400001)(6486002)(66476007)(66946007)(66446008)(66556008)(33656002)(86362001)(64756008)(8936002)(6862004)(38070700005)(5660300002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UFlMYStHNU5uY1ZVQmdPZ3FFeFI4c2VhMDloZjJpN2J6VVZPaE9iWiswOFVv?= =?utf-8?B?YlkwbndrZGNWTm9vK1A0eXJ0UW8ycStXdURLVkx4T0IwTkZRTWRNVUFiQnQx?= =?utf-8?B?VzdXbXZSRS94TmpocHExUTFVcXFsRVFwN1RKc0ZaUE1vTjVGMUF6bFBKcWlk?= =?utf-8?B?ZC9qTzVyYlBpK0gyVTFwQml4YktpYjJEV05RS2FORWZmZEFFYmtGb2psNkZs?= =?utf-8?B?N3RPQnc0T01QdStSNHFIMjZLbnpuSWlSQ3N2R2pXUm1qNUkrRnVxcVA3aHkv?= =?utf-8?B?aHpCWmJiK0hTUzNTWVllR3BlUjhqQTRXK2xYTzVSMVRFZlNvakJCblVzdndm?= =?utf-8?B?Q2tpOGRZWVNZRXBXMWxsZW9RaUh1RTlnMWZqRXVPMWQxblA1Q0JXeWJ3eDZ6?= =?utf-8?B?MFdHeUlDSUxxYmFmek80aG80aXR2WjN0dVZFek5Wd2pVV3lvR0ZvU2ZMejkv?= =?utf-8?B?M251SmdSWkdDS2JONGQ5OTZoT2sySElLZW9SM0RyZk8vV254VlcrY1EwdStG?= =?utf-8?B?Q2NkRFg0cjkvbzBJY3RINEs0TjNJQkprdE9wWGZpSHkwYXF2dGxUVGRPOFY0?= =?utf-8?B?enlXdFVoVUFpL3RMc3htTFA0TXl5ODFLQ1dCd3pkQVpaZ2c1c3dVbC8xazNO?= =?utf-8?B?NEdlYmNqeTE4SjBsSlNzbWhFWTNzNlNNRWwyZUtjeldteWZDNGhpalVMMVQ0?= =?utf-8?B?dWZKV3h5dGtrbVFJWnM4QU1xay81ckVHUmhmeTI4aFVyb3dKWWhISStmajlE?= =?utf-8?B?SW1CSCsyZ0x6cGdHZXFjUDRNVGMyMG9KSXlUY2lTTk9XRFJWb2xIVFVnVXpT?= =?utf-8?B?c0UrY1lQczF5NmxDZ1JORCs1Ymx6TmJibHhScm9vZ3pCT3RtM2wzRElvRlpn?= =?utf-8?B?RWF4UnVFK2FzRnl6Zlg3bEVjamFudGlNaFhBcWw4aG95Z0tNMzRyRXd3NVo2?= =?utf-8?B?SlZuSHdVQ2ZxQUlQeHZSbDU0Slg5THlZbVNIQm9tZzVhUUlzY0FpWS9jV0JZ?= =?utf-8?B?eGNPbGVWdFZHVE03eHp6UHB6MFdTbGR1ZXdiaCtKbVJDZWVMTkpmTCtPaHBr?= =?utf-8?B?WThHd1NGZTFWT2ZqZm5TVTJlSFU5R0lDSnE1RTZuNElOTk92V0hNU1pIOG1z?= =?utf-8?B?TzRCaGlhMHE0clQ1WHpTeXZxRTUvUUErL0xYQVgwdklNQ1d3Rk4vWHVHSEVE?= =?utf-8?B?aWRUMmdrRVZSVk1VQ1pGckJsaTN0TnN0ZDYzWFlQZGxqQVFTWi9OTHNXWHps?= =?utf-8?B?alJGZS82WFc5ZUdRdThyay83QXRyRFZuQnlLY0VTc0pWM1RmendpMk9SYUhN?= =?utf-8?B?bW9FcHd3NXZtbThwd2txN28zTm1JZGx2YytEZS9uUUdmeW14NjFqUDhyZFkz?= =?utf-8?B?bUU0bm5VZ3UyZ1hpNFRKMEc2cVorOGdmUURZVEdFYTMrSUJVZ0xIdkhJN1F1?= =?utf-8?B?c0JWOWpaWjJBMTJaY3lVcGM4b25uSThZNDN2ckFOOGZGbHFDNi9BVzFLdE9N?= =?utf-8?B?RkZ6bWE0Ri8yVnpDd3NWMVlUVHhjQXZ5S1daYTgyRDNLQUJOZmhQRU0vU05M?= =?utf-8?B?S0lCSjFmM1BnSnM2Smpqc3FFQVFiWFFpM2FPQWxaQ3hjVWVxcTU3MWE5TGZt?= =?utf-8?B?dW1BWVlNQ3QzSWUveFN0aVJWS2I4S05qTU0xdE9pc1FPVkdBNXdnRFV2YkJP?= =?utf-8?B?N0phWnNReVpYZXZnZys1NTZ5dmdWb0VmdTVNNnVsWm5BSWZ4U0c3bFhwdFZt?= =?utf-8?B?YTBqcVdnaTBIWERsR1lKQVc2N0t6UnRNVVhWYnJhUng1bkpMU01udHlEZ2pV?= =?utf-8?B?Ynl3am9BSGpJTTZ0TkFPU0JQQ1liNEFTVDlOdWFObmdSeWhUZlJoSE9na2hT?= =?utf-8?B?WmFpaFlmTUtBRmZNZXdzVExTTDF5ZzdPdkFac1RQODZzbzJYVE1KR0gySGwy?= =?utf-8?B?cy9OZCtqUDhjMXFjK1h6YVR4SnJuNGF3cS9WNzlHc1o0ay9HbGJ2U1NsRFZC?= =?utf-8?B?eGZ6eXFCQUZjMXB5R2ZiMHdVaGFaMGdhM0M0TklZeHFyTjZ3QXBwWmJsalNO?= =?utf-8?B?V05GTWl1aTNHZkhrS0JBT1ltbTRsa0tWRFYrNW55UER3Y2tSSjNIUjNrRTEz?= =?utf-8?B?VFJjdkRUS2dHemVCYSsvOXVoRHZ2NXhOWjJrMVAwQWhDZDc1cjd5aTd0RUE0?= =?utf-8?B?eWc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kxxqgNS2XmxmTyHh4Ko6If9yD2eqwZ81iyoA4UrtK1yoyuHMFKijroZhQnr9xMSu9zWxPDhFYiaU8r3Alr3PHvyHHFQy5d6CIL95qItykJqyXo0yHtDGMqJmdVAuahcWrXH/Tr1oBR4MsImRXX4iwapxqcVVMH1G02Kefl91lm1kSF3BSm/gHLgJycz/t4KMT4w2sGSyw2CcFcOptOqGLeXCgUmJuVerqcjSBrCdGYL1tIhJCjluO/mSx8WsRPhLCINyDmbJ7ZkpY1i4gG1s8yephgTQi9VDXgneoqff/gMOu+hmxw09BWrq4Y3uwWDr1cZBTxatlbYw2hN6utZnpktkr1cRvOZiNDNPi2vWU5QXY8KdakeymN5Wojj1dnfawXoxvQkqCGUkfpXnp3/NG3cp1XFHGbNkR55+mGLHykJp6Pze58A62OG7syGe1d97pOWbDtsra6x/HbHIFsfNKeL9SuG/wSHgh3a3po0kfwYunUhVEwwqN6l6Ap+/v5LWDP4tjoICSmfmjg04Blfkk3Rsxse0DGqeImJTsG4okQVkxuhNNGuhqSzh49vzA/nwUm+4dyZA2f0BNn2btJRw23lsN+Yz4Hulp2mCIxY8vEQaVuh44HfxEUDjZ/VeIfbd8H0Qm9awvDooXVlpjNi2iG6CjVhy8k8x9vXoaDvgXZhr+VzVDYFP2W78zGDEMwqAIc5H2Mg9lV33/ji1XQMMmmyMDxLLTknClNi3+oZnMzlHm+F4nuZ7mlNCGQ9fSA5kAALExP+CNI5uGnSssgPNyeuIlyE14dOwzF1NzQxaGMX3WBw3JIzYNxUkjgkdXfRi X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 561ca59c-3d30-4524-edbc-08dad2f69996 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 17:16:20.6627 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6rL6b1+Y+uNRnjoZ7vWJxHil8LPtFM4/ZC8egzUe9N2/A40DcOT6aoAWsiP9R6K7qTbEF7uXUC8OZCEIaOS6EQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5774 DQoNCj4gT24gMzAgTm92IDIwMjIsIGF0IDE2OjU0LCBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29v cGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IFhlbnN0b3JlZCBhbHdheXMgbmVlZHMgdG8g YmluZCB0aGUgRE9NX0VYQyBWSVJRLg0KPiANCj4gSW5zdGVhZCBvZiBkb2luZyBpdCBzaG9ydGx5 IGFmdGVyIHRoZSBjYWxsIHRvIEV2ZW50LmluaXQoKSwgZG8gaXQgaW4gdGhlDQo+IGluaXQoKSBj YWxsIGl0c2VsZi4gIFRoaXMgcmVtb3ZlcyB0aGUgbmVlZCBmb3IgdGhlIGZpZWxkIHRvIGJlIGEg bXV0YWJsZQ0KPiBvcHRpb24uDQo+IA0KPiBJdCB3aWxsIGFsc28gc2ltcGxpZnkgYSBmdXR1cmUg Y2hhbmdlIHRvIHJlc3RvcmUgYm90aCBwYXJ0cyBmcm9tIHRoZSBsaXZlDQo+IHVwZGF0ZSByZWNv cmQsIHJhdGhlciB0aGFuIHJlLWluaXRpYWxpc2luZyB0aGVtIGZyb20gc2NyYXRjaC4NCj4gDQo+ IFJlbmFtZSB0aGUgZmllbGQgZnJvbSB2aXJxX3BvcnQgKHdoaWNoIGNvdWxkIGJlIGFueSBWSVJR KSB0byBpdCdzIHByb3BlciBuYW1lLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3Bl ciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4gLS0tDQo+IENDOiBDaHJpc3RpYW4gTGlu ZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+DQo+IENDOiBEYXZpZCBTY290dCA8ZGF2 ZUByZWNvaWwub3JnPg0KPiBDQzogRWR3aW4gVG9yb2sgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+ DQo+IENDOiBSb2IgSG9lcyA8Um9iLkhvZXNAY2l0cml4LmNvbT4NCg0KDQpyZXZpZXdkIGluIHBl cnNvbjoNCg0KUmV2aWV3ZWQtYnk6IEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5j b20+DQoNCj4gDQo+IHYyOg0KPiAqIE5ldy4NCj4gLS0tDQo+IHRvb2xzL29jYW1sL3hlbnN0b3Jl ZC9ldmVudC5tbCAgICAgfCA5ICsrKysrKy0tLQ0KPiB0b29scy9vY2FtbC94ZW5zdG9yZWQveGVu c3RvcmVkLm1sIHwgNCArLS0tDQo+IDIgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA2 IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9l dmVudC5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9ldmVudC5tbA0KPiBpbmRleCBjY2NhOTBi NmZjNGYuLmEzYmUyOTYzNzRmZiAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvb2NhbWwveGVuc3RvcmVk L2V2ZW50Lm1sDQo+ICsrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9ldmVudC5tbA0KPiBAQCAt MTcsMTIgKzE3LDE1IEBADQo+ICgqKioqKioqKioqKioqKioqIGhpZ2ggbGV2ZWwgYmluZGluZyAq KioqKioqKioqKioqKioqKQ0KPiB0eXBlIHQgPSB7DQo+IGhhbmRsZTogWGVuZXZlbnRjaG4uaGFu ZGxlOw0KPiAtIG11dGFibGUgdmlycV9wb3J0OiBYZW5ldmVudGNobi50IG9wdGlvbjsNCj4gKyBk b21leGM6IFhlbmV2ZW50Y2huLnQ7DQo+IH0NCj4gDQo+IC1sZXQgaW5pdCAoKSA9IHsgaGFuZGxl ID0gWGVuZXZlbnRjaG4uaW5pdCAoKTsgdmlycV9wb3J0ID0gTm9uZTsgfQ0KPiArbGV0IGluaXQg KCkgPQ0KPiArIGxldCBoYW5kbGUgPSBYZW5ldmVudGNobi5pbml0ICgpIGluDQo+ICsgbGV0IGRv bWV4YyA9IFhlbmV2ZW50Y2huLmJpbmRfZG9tX2V4Y192aXJxIGhhbmRsZSBpbg0KPiArIHsgaGFu ZGxlOyBkb21leGMgfQ0KPiArDQo+IGxldCBmZCBldmVudGNobiA9IFhlbmV2ZW50Y2huLmZkIGV2 ZW50Y2huLmhhbmRsZQ0KPiAtbGV0IGJpbmRfZG9tX2V4Y192aXJxIGV2ZW50Y2huID0gZXZlbnRj aG4udmlycV9wb3J0IDwtIFNvbWUgKFhlbmV2ZW50Y2huLmJpbmRfZG9tX2V4Y192aXJxIGV2ZW50 Y2huLmhhbmRsZSkNCj4gbGV0IGJpbmRfaW50ZXJkb21haW4gZXZlbnRjaG4gZG9taWQgcG9ydCA9 IFhlbmV2ZW50Y2huLmJpbmRfaW50ZXJkb21haW4gZXZlbnRjaG4uaGFuZGxlIGRvbWlkIHBvcnQN Cj4gbGV0IHVuYmluZCBldmVudGNobiBwb3J0ID0gWGVuZXZlbnRjaG4udW5iaW5kIGV2ZW50Y2hu LmhhbmRsZSBwb3J0DQo+IGxldCBub3RpZnkgZXZlbnRjaG4gcG9ydCA9IFhlbmV2ZW50Y2huLm5v dGlmeSBldmVudGNobi5oYW5kbGUgcG9ydA0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVu c3RvcmVkL3hlbnN0b3JlZC5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC94ZW5zdG9yZWQubWwN Cj4gaW5kZXggYzVkYzdhMjhkMDgyLi41NTA3MWI0OWVjY2IgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xz L29jYW1sL3hlbnN0b3JlZC94ZW5zdG9yZWQubWwNCj4gKysrIGIvdG9vbHMvb2NhbWwveGVuc3Rv cmVkL3hlbnN0b3JlZC5tbA0KPiBAQCAtMzk3LDcgKzM5Nyw2IEBAIGxldCBfID0NCj4gaWYgY2Yu cmVzdGFydCAmJiBTeXMuZmlsZV9leGlzdHMgRGlzay54c19kYWVtb25fZGF0YWJhc2UgdGhlbiAo DQo+IGxldCByd3JvID0gREIuZnJvbV9maWxlIHN0b3JlIGRvbWFpbnMgY29ucyBEaXNrLnhzX2Rh ZW1vbl9kYXRhYmFzZSBpbg0KPiBpbmZvICJMaXZlIHJlbG9hZDogZGF0YWJhc2UgbG9hZGVkIjsN Cj4gLSBFdmVudC5iaW5kX2RvbV9leGNfdmlycSBldmVudGNobjsNCj4gUHJvY2Vzcy5MaXZlVXBk YXRlLmNvbXBsZXRlZCAoKTsNCj4gcndybw0KPiApIGVsc2UgKA0KPiBAQCAtNDEzLDcgKzQxMiw2 IEBAIGxldCBfID0NCj4gDQo+IGlmIGNmLmRvbWFpbl9pbml0IHRoZW4gKA0KPiBDb25uZWN0aW9u cy5hZGRfZG9tYWluIGNvbnMgKERvbWFpbnMuY3JlYXRlMCBkb21haW5zKTsNCj4gLSBFdmVudC5i aW5kX2RvbV9leGNfdmlycSBldmVudGNobg0KPiApOw0KPiByd19zb2NrDQo+ICkgaW4NCj4gQEAg LTQ1MSw3ICs0NDksNyBAQCBsZXQgXyA9DQo+IGxldCBwb3J0ID0gRXZlbnQucGVuZGluZyBldmVu dGNobiBpbg0KPiBkZWJ1ZyAicGVuZGluZyBwb3J0ICVkIiAoWGVuZXZlbnRjaG4udG9faW50IHBv cnQpOw0KPiBmaW5hbGx5IChmdW4gKCkgLT4NCj4gLSBpZiBTb21lIHBvcnQgPSBldmVudGNobi5F dmVudC52aXJxX3BvcnQgdGhlbiAoDQo+ICsgaWYgcG9ydCA9IGV2ZW50Y2huLkV2ZW50LmRvbWV4 YyB0aGVuICgNCj4gbGV0IChub3RpZnksIGRlYWRkb20pID0gRG9tYWlucy5jbGVhbnVwIGRvbWFp bnMgaW4NCj4gTGlzdC5pdGVyIChTdG9yZS5yZXNldF9wZXJtaXNzaW9ucyBzdG9yZSkgZGVhZGRv bTsNCj4gTGlzdC5pdGVyIChDb25uZWN0aW9ucy5kZWxfZG9tYWluIGNvbnMpIGRlYWRkb207DQo+ IC0tIA0KPiAyLjExLjANCj4gDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Nov 30 17:18:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 17:18:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450084.707250 (Exim 4.92) (envelope-from ) id 1p0QjH-0002CP-5B; Wed, 30 Nov 2022 17:18:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450084.707250; Wed, 30 Nov 2022 17:18:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QjH-0002CI-29; Wed, 30 Nov 2022 17:18:39 +0000 Received: by outflank-mailman (input) for mailman id 450084; Wed, 30 Nov 2022 17:18:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QjF-0002C8-AS for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 17:18:37 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 03c9cca6-70d3-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 18:18:35 +0100 (CET) Received: from mail-bn8nam04lp2048.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Nov 2022 12:18:02 -0500 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by SJ0PR03MB5599.namprd03.prod.outlook.com (2603:10b6:a03:285::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 17:17:56 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::fc0e:731b:b539:94b%5]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 17:17:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03c9cca6-70d3-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669828715; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=+kPvdRIp/BCVyTsWdh18yPqvaSv1t5MyKKgj2Bm3k7Q=; b=WT3hcMMzrGhjd7Nwte5oYndBKr1m2BQ3CLJM0QOOh0UegsllGtj7UOS9 bvQd3lVyd/PnS3LTq+Ib31DPNqR+hh6tshbLA/Mh7HKAOoEqFQshsJBAd nLreI3qU++uPmd5FYipZ2LUU2d/2Z2A9MEis4q+J2BM24HEGK6aPbcp8L Q=; X-IronPort-RemoteIP: 104.47.74.48 X-IronPort-MID: 84927984 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:bvUwYqke5xHSPa8GanXMt9bo5gySJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIfXGCPM67fYGL1ed8nPIy/p0wB6paAz9FiSQo/+Xs8QyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5weGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eQVKWEUNEmcvLOz4IjrZedUp9s9POC+aevzulk4pd3YJdAPZMifBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVk1A3jOiF3Nn9I7RmQe1YkliZo CTa+H7+ATkRNcCFyCrD+XWp7gPKtXOnCdhNRe3knhJsqFiJ11I4EiMub0uAnqDnm26HQPFaD UNBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQqvdE7bSYn3 ViIm5XuHzMHjVGOYXeU97PRpzXiPyEQdTMGfXVcEVtD5MT/qoYuiB6JVsxkDKO+ktzyH3f33 iyOqy89wb4UiKbnypmGwLwOuBr0zrChc+L/zlWJNo55xmuVvLKYWrE= IronPort-HdrOrdr: A9a23:WhqbfajPf7LEVMOABiTzSnE+4XBQX/J23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu17h/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboXgTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp9KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wXh4SqbpXVd WGPvuso8q+QmnqKUwxeVMfmeBEa05DWituhHJy4vB9nQImx0yRhHFoufD31k1wiK7VDaM0p9 gse54Y6o1mX4sYa7lwC/wGRtbyAmvRQQjUOGbXOlj/ErobUki94qIecN0OlZ6XkbEzvewPca 76ISVlnH93f1irBdyF3ZVN/ByISGKhXS71wsUb45RioLXzSLfiLCXGETkV4oCdiuRaBteeV+ e4OZpQDfOmJWzyGZxR1wm7X5VJM3ERXMAcp95+UVOTpcDALJHsq4XgAb7uDauoFSxhVnL0A3 MFUjS2LMJc7lqzUnu9mxTVU2OFQD2KwXuxKtmuwwE+8vl/CmQXiHlltb2Q3LD6FRRS9qorYU B5PLTr1qumuGjexxe701lU X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="84927984" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QWKWHY0sz5/BaHEk31lxYTKcRDr2aV1/rJGjkZDe7kCPpRWo9K/Cp4t/dM9rR32GuP4DqVKxVTCx5EOptdYKrEp1C2EahFPjmik0cYie2tGrpfi36yGiT3FcUmPogYnTa92Ps/tzSFbOg17q+HPfzf1bKzYRH/v4GTBUFnSI7Bt39By1QfM2R0Uqe/5zqH0e2qGSfWL39ucb4SFh0ctLjf6mcbSTfYrHJ63d8nn7MzU9vPNdwE4uv2JSznnKgzcUAiL1rYiAdwO3U1z85psCO18Ey4kbM7sojVeJ/jjpRe2zxc15/K97qZJTPCpE2sZRMe2T2XOuRw+veshcNI+FtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+kPvdRIp/BCVyTsWdh18yPqvaSv1t5MyKKgj2Bm3k7Q=; b=Tt+cjCzDRQCJrTymklBBai4RGqjxzC+Axwp+2V9lQ1qlr0emVp5tBzu3wmChJ5hBcUX/FVxdNJjWOEiIlyj3ounBgWfCu6ITI5aIS0aI7xtNZG5MPzaC/2VlKxiqR+FY9IjZjxW72SLyKruUwJlyJ2wkKnI2CeuN0o0iiiD8ya35iOCLAwe+PZNhZgQDHdotfgv6yl8sj5D+4lGpC7GZWaP63qX8x+/4wqLu5YbADvTd410x7DBCivxmBFejeeR3SoxbLfTPRNI3DrdQTw7tykT7b2VHMGy9b0lEUhj0fqboapfX1MufpNNAdVX+jQjSPm7hMkhl8Kh8nZdzX0fI3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+kPvdRIp/BCVyTsWdh18yPqvaSv1t5MyKKgj2Bm3k7Q=; b=gXiCrKp0kTUtxyNdEXaSLKJPpmAE/uxg+0geR5T4iqWcpAghkM4zPdGvuxWy6OBfCZu3aE1yoO/AFPAPwj9B4igM/fD5ICL4qIMZRJoAw49NSXUABUz0od/GEMXAoY3S1NDGGGg7LLuGRqRm81ZB2pcClDl8RClp8v+Yw91uaTk= From: Edwin Torok To: Andrew Cooper CC: Xen-devel , Christian Lindig , David Scott , Rob Hoes Subject: Re: [PATCH v2 5/6] tools/oxenstored: Rework Domain evtchn handling to use port_pair Thread-Topic: [PATCH v2 5/6] tools/oxenstored: Rework Domain evtchn handling to use port_pair Thread-Index: AQHZBNyG3A7uJdJD7k6750yETnX6R65XtZoA Date: Wed, 30 Nov 2022 17:17:56 +0000 Message-ID: References: <20221130165455.31125-1-andrew.cooper3@citrix.com> <20221130165455.31125-6-andrew.cooper3@citrix.com> In-Reply-To: <20221130165455.31125-6-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.200.110.1.12) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|SJ0PR03MB5599:EE_ x-ms-office365-filtering-correlation-id: 2ee512a9-3093-4912-64f3-08dad2f6d2e5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JZ6UDjTZiYpuz7kj0W5xdTJuPYuMLmCLXN21GpD+l7KgpoX0W4nACumJZaMRmE/pgz4ZCudlN3QHWl4fQKmF184qm1HrzJ2yJs5xxa+xTwuGDTvvsWIYwBER/WetNnEs2rU8bCPmSXQwo6ZBCTTpsUmkUX5iANpJsOlgkCLWjoN+1VBrHEa/WEyjj+wKQCskoAAOJ58t2r/KEVu9jbGdtlKbwClPSRSE4odvdYiIq00z76AjKgf3YlNGZjsOWZY+0rDQdUZceYOVZerBnieDkdorqN47TXT/1Ph2flvC2GQX/PjlJZASdPloui4geVLLrPqDg8VzrZ1fylH0HscQVBoQBy2zyppq+kaCukdY5afdwIkkO/Jpw4eVe6yAj6t2BIH/oJwwbtFVas4EC4Shh+bioae2P9wZ9nIg4qjvMDR60dzr3iqDFpGthhMEpRtIaaySORfaklR82iNn+1gnDHTeR+7zyNZqQYvqSeBI7yRdJ9zDtrMo4vWhfTkGgrWVmOgKfl6QcHb0Z4+E7FsOz3dhXyauU1sLi3cpkXKAmpPWNOfiZkFBVklmb4lnNPjET9cAJ4hmJSDLqTOR0mHhr5q/+nUVhs16CKMuljGhBenMv372+99Y7flOZzebVSr6lyNv0UsMAmLkaVp3MfHmArpF0LFejMIVOZMmpqfqHhDauioFo5IpMtquiiuB4idfSGE5oxfreaYy9g7zu7f2xHLAqFreH3quJIYkjUEjUnA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(136003)(346002)(39860400002)(376002)(451199015)(71200400001)(33656002)(6506007)(53546011)(478600001)(107886003)(6486002)(37006003)(54906003)(26005)(6512007)(36756003)(41300700001)(91956017)(8936002)(6862004)(76116006)(8676002)(66556008)(66476007)(66446008)(2616005)(66946007)(186003)(64756008)(4326008)(38100700002)(66574015)(38070700005)(82960400001)(2906002)(83380400001)(5660300002)(316002)(6636002)(86362001)(122000001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QXVUeE9XaEhvdFE3aHJXdXVyUUQ1Y3luRXNwRDVFOWg3S2U0S0ZzeWx6S0E2?= =?utf-8?B?QkF0TGthS2VGNVBtSVpYUmtxMUlCa0ptWDNFV2V4OUtEVDU3aUVjd3NVR1lQ?= =?utf-8?B?ZitLdzJZYWVvR2NmU3F6b3daVzlrekNhbENPSGUveVZvV0ZCZzZrU3lVaWhB?= =?utf-8?B?dHlMMHN4ejVacHRHQTIyQ3djdkZTRmVJMGZ3QlJmSUE2Nm11WlBTbE9Uanly?= =?utf-8?B?TExSdWVWdHRnSlZveWNNNzdWKzByR1hGNHhveWcxeDQybEpOR3V1eFpBbm5j?= =?utf-8?B?TVF4UGhCVEZFbmR1SUhuaGVYeGZaZHlKMVh4QVR5Y0ZUZjVrMExOSVNaS2Za?= =?utf-8?B?cC9PVnZsTlZMY2NSQk9iNjlXYzNaVkFTSjE0aFJYRmRSOFBsMHB6NTFjSVI0?= =?utf-8?B?MGc5TndxUmd2d1JPNXhQOE1LK2FTMEJNU0VEdFRvNmxGVTFTTVZDSEtRZ29v?= =?utf-8?B?SW9lMURCellnaGx4RTZlNytvR0tLbGpkZFZidmR0VWd6eElzZmhUZ0E4eUcx?= =?utf-8?B?cnIxSFdHQXFrL3kvN3p0MHRLRGFHSk1oVzlzeEFmbzU5WEg0TjludXJ0MHBF?= =?utf-8?B?TGFtQlltK0RoSU1wMC9wZnZzWkRPYUhYc0pBSE50cTMxeHhWNkVZVXduVDR2?= =?utf-8?B?dEVMbnRZNTNRbjRvM3A5VjJ0dlZrNW92clNYWkwrTkVSM2hDUTRoemFBV0dS?= =?utf-8?B?ZWloajMveWtCampOeEZKSDkrNFRRNElqa0ttalhBTFQ1Q3JpeCtvSHBKMmRm?= =?utf-8?B?RkxFZXNLSERVbXZQRkFXM01GSmt5a0tERnV4ZVFYYjJuVTFkMWJ5ZWZ1dTVJ?= =?utf-8?B?SGo2YmRpK3AyKzRKbkw0SXA4YndKSVlWMmMyeVFPU3dYWmtSeFc5WkNyYlFj?= =?utf-8?B?V20wbDZQYnFkZ3JNNEtrRHlCVW4xd0x5SmRYYTY0MWJJUS8wQ2drS1pMVXZ4?= =?utf-8?B?MWhGZWFJakNzbXIvQmsxei9HOVpwZE1zdVpLTHBMMmdaWmQzVkVvZWxwQzR5?= =?utf-8?B?RnpuaUdVZHA4dTdqOXp2YWhUNWxwemVMellLSlljU2c0cFVzc01NdXVEQ0hM?= =?utf-8?B?UGZuOXRJTXdQc0UwelozSmorUTNRc1lIbG1Cdks5Y3M5Y1BaYUt2eGE5OEJi?= =?utf-8?B?bzZoWDFUVW1UUTVrNm50NlVYb0FpejBUdmVZRDhPRGkwck1YR1RYdWNMSTlC?= =?utf-8?B?dVRuNUNnU3RxSWRVMk8zSWdSREJhZzJUY2k2UkVqOGx3NkIyTGIxOWpoQ1E4?= =?utf-8?B?YjA5WnFvM1FkOXZDVENlR3M5OVVIVDN6b2dYZFIrSGhtMW0xY2VvbmdpK0hU?= =?utf-8?B?YnpBa1lmdTVsOUNtaldIVkVTVnN1WWlVQmFlcHIrVjJORlFIN3VxUEg4c2RE?= =?utf-8?B?Y2ltZU40ZFI3NWlmMnRDM29TdnJzZjd3dG4wK2hjaGQ4V2Q0Ymo5SjhZNURI?= =?utf-8?B?MW9VUzI4cHltT2hKOXhkZE45Z0o3dzlYWE1CeFlBM1RJWFl3dmtWRDNiOCtz?= =?utf-8?B?enpuSlFMN25ueWtGQ2U2QnpveG1XVnk0WVFNUEhKRWdNSTBObnIyTnBmejI5?= =?utf-8?B?UVlOb05IMnBDZlJZTW9CT0Fwd3pXenlXTnhFY1hNQkQrUW1sdkc0d1hJMm8z?= =?utf-8?B?aVZtbktwaWJrdG93WXkrdXJuUTFiV0ZaL21TdkNSMFZkcHcxUGVNS0JlMGhK?= =?utf-8?B?T3RnTUZFd2xmc2tZWDduVjBMUnh3OEFsY0lUR3FpOElKZDZtVHZ0WE5aV2VN?= =?utf-8?B?Ny9hT200Z2tHZHZld1ZOaVNEWDhrU2xMNThmQTNyVDI1bHdjSWl5SmpzK1ly?= =?utf-8?B?a0dHeEM0TWJMWitBUFVmZGhnbjg2MGtubm44U0FQaTRJME03amU5dysyeWZh?= =?utf-8?B?dkdXRGNFc0wzNjVCQkxsajRBV3gxWm95dVg4Ym1GS1JMZENkaEpHN2l3Qlh0?= =?utf-8?B?M1BkclR4cGRKb0JNTzJ3cGQ1UlZWOVp2bmVGd3ZXbDZsMTl6aTdYMWpSNXg5?= =?utf-8?B?ajJTNTlzNmVybmJPZW5kelhqVDh3bmtvbkdncVVZUTVYTjFvK3VQbkdBckdE?= =?utf-8?B?a3BaNE8xcTFBSHJGRDR4QTE2cktFWlU3b2JKYWxEWjR1ejcrWGVYNnRHRm4w?= =?utf-8?B?UE9mS2VWUTc3WHd3Tk11Z2R5QlUxYTNjNVhMbFFaMmJ6SityTHN1WkRrNExR?= =?utf-8?B?K2c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <2234F98F86AE8041844A11739DBCEB1C@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 4OL0Vt3WfmoLxQr4eskLZ7DvcBfhPESWHRo04s1f5GMBZNaQtrO4w+UOf9Gq5t49iqv+W3qbjT61/B+bBHUgR9e3rkZEFJOQSX6KjrICnuSbRWp/yRxoOPGX58gxn0OekARlVmDzfseKbwvqyWDuSZZFHqXGBnCGgm/0x0jz4TfNBDQ0c3plHtBXti5hevYN5/TTQq7ltKlvaqdWX7BRa9UqMxKllpNuQ2XGZGAlqYmI6Nle594lTuThFGLog0du9drIOrpBNQ4sKOvOfBrOCfdNnuXeQUncgSY3l9nRa0ckmgs9MPJPc7Z7rwcHiV0tH99gevql7Sb/3Q01N2OcrZ5Td8WLQjyo3OigjA4iCT6h5kvH/6mHaBHonWTFe2ywotBba5yohmXI2E1HzCRNh8lAo1hruw3fMHYVcgDD8O7dA3Fc7SnN59/9yWQ4RQwYzcYXlhEHi+zi4isdPU6Skr3PSKQWB40csuxlEI1HtbzDEVTJQcbPwQAgb0qSEoY+oORw2orugUHZO9uhazUobISsle7EOEA2dYym5e8aVJ0w0TyUR1JFQejCHvy5z3XHYGxqyeOpjZO1N4xx5Z4LbpwNJc7C/4OgUGDMpVIJdgOCG0AsoaPVOMdZRQ8BWDvOwK/j87/14RH7m09hPwPSXrU19xCrhcM6nNNBxchXf7ZlVlO1t7ASibzpvaky0m7auESMhYJITc1l8vHeA9r5yMsSBaB8nRCDFhgKvOWmvpaWtSoxZ4DStuZErMuANz0e7PmTkVUoojXL5mKrwznb6B0ILKw+t3m5sqWgIePcXc6i7vwbEwLlnl4Fxb7dtBRf X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ee512a9-3093-4912-64f3-08dad2f6d2e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 17:17:56.8227 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r7tYy+mw4UDgdxJYuo00Zy59cNefNVh2MXmzl4VjiS/pM9fGhrEfoYHtF6S4WHb7GmqxTfj1hCCsMMOvEZi/hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5599 DQoNCj4gT24gMzAgTm92IDIwMjIsIGF0IDE2OjU0LCBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29v cGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IEludGVyLWRvbWFpbiBldmVudCBjaGFubmVs cyBhcmUgYWx3YXlzIGEgcGFpciBvZiBsb2NhbCBhbmQgcmVtb3RlIHBvcnRzLg0KPiBSaWdodCBu b3cgdGhlIGhhbmRsaW5nIGlzIGFzeW1tZXRyaWMsIGNhdXNlZCBieSB0aGUgZmFjdCB0aGF0IHRo ZSBldnRjaG4gaXMNCj4gYm91bmQgYWZ0ZXIgdGhlIGFzc29jaWF0ZWQgRG9tYWluIG9iamVjdCBp cyBjb25zdHJ1Y3RlZC4NCj4gDQo+IEZpcnN0LCBtb3ZlIGJpbmRpbmcgb2YgdGhlIGV2ZW50IGNo YW5uZWwgaW50byB0aGUgRG9tYWluLm1ha2UoKSBjb25zdHJ1Y3Rvci4NCj4gVGhpcyBtZWFucyB0 aGUgbG9jYWwgcG9ydCBubyBsb25nZXIgbmVlZHMgdG8gYmUgYW4gb3B0aW9uLiAgSXQgYWxzbyBy ZW1vdmVzDQo+IHRoZSBmaW5hbCBjYWxsZXJzIG9mIERvbWFpbi5iaW5kX2ludGVyZG9tYWluLg0K PiANCj4gTmV4dCwgaW50cm9kdWNlIGEgbmV3IHBvcnRfcGFpciB0eXBlIHRvIGVuY2Fwc3VsYXRl IHRoZSBmYWN0IHRoYXQgdGhlc2UgdHdvDQo+IHNob3VsZCBiZSB1cGRhdGVkIHRvZ2V0aGVyLCBh bmQgcmVwbGFjZSB0aGUgcHJldmlvdXMgcG9ydCBhbmQgcmVtb3RlX3BvcnQNCj4gZmllbGRzLiAg VGhpcyByZWZhY3RvcmluZyBhbHNvIGNoYW5nZXMgdGhlIERvbWFpbi5nZXRfcG9ydCBpbnRlcmZh Y2UgKHJlbW92aW5nDQo+IGFuIG9wdGlvbikgc28gdGFrZSB0aGUgb3Bwb3J0dW5pdHkgdG8gbmFt ZSBpdCBnZXRfbG9jYWxfcG9ydCBpbnN0ZWFkLg0KPiANCj4gQWxzbywgdGhpcyBmaXhlcyBhIHVz ZS1hZnRlci1mcmVlIHJpc2sgd2l0aCBEb21haW4uY2xvc2UuICBPbmNlIHRoZSBldnRjaG4gaGFz DQo+IGJlZW4gdW5ib3VuZCwgdGhlIHNhbWUgbG9jYWwgcG9ydCBudW1iZXIgY2FuIGJlIHJldXNl ZCBmb3IgYSBkaWZmZXJlbnQNCj4gcHVycG9zZSwgc28gZXhwbGljaXRseSBpbnZhbGlkYXRlIHRo ZSBwb3J0cyB0byBwcmV2ZW50IHRoZWlyIGFjY2lkZW50YWwgbWlzdXNlDQo+IGluIHRoZSBmdXR1 cmUuDQo+IA0KPiBUaGlzIGFsc28gY2xlYW5zIHVwIHNvbWUgb2YgdGhlIGRlYnVnZ2luZywgdG8g YWx3YXlzIHByaW50IGEgcG9ydCBwYWlyLg0KDQpSZXZpZXdlZCBpbi1wZXJzb24sIEkndmUgc3Vn Z2VzdGVkIHRvIHVzZSBleHBsaWNpdCBsYWJlbGVkIGFyZ3VtZW50cyBmb3IgdGhlIGNhc2Ugd2hl cmUgbXVsdGlwbGUgaW50ZWdlcnMgd2l0aCB2ZXJ5IGNsb3NlIHNlbWFudGljIG1lYW5pbmcgYXJl IHBhc3NlZCBhcyBhcmd1bWVudHMsDQplLmcuIGxvY2FsIHZzIHJlbW90ZSBwb3J0LCBpdCdkIGJl IHF1aXRlIGVhc3kgdG8gYWNjaWRlbnRhbGx5IHN3YXAgdGhlbSBpbiB0aGUgY2FsbGVyLCBsZWFk aW5nIHRvIGJ1Z3MuDQoNCg0KUmV2aWV3ZWQtYnk6IEVkd2luIFTDtnLDtmsgPGVkdmluLnRvcm9r QGNpdHJpeC5jb20+DQoNCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJl dy5jb29wZXIzQGNpdHJpeC5jb20+DQo+IC0tLQ0KPiBDQzogQ2hyaXN0aWFuIExpbmRpZyA8Y2hy aXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPg0KPiBDQzogRGF2aWQgU2NvdHQgPGRhdmVAcmVjb2ls Lm9yZz4NCj4gQ0M6IEVkd2luIFRvcm9rIDxlZHZpbi50b3Jva0BjaXRyaXguY29tPg0KPiBDQzog Um9iIEhvZXMgPFJvYi5Ib2VzQGNpdHJpeC5jb20+DQo+IA0KPiB2MjoNCj4gKiBOZXcNCj4gLS0t DQo+IHRvb2xzL29jYW1sL3hlbnN0b3JlZC9jb25uZWN0aW9ucy5tbCB8ICA5ICstLS0tDQo+IHRv b2xzL29jYW1sL3hlbnN0b3JlZC9kb21haW4ubWwgICAgICB8IDc1ICsrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLS0tLS0tLQ0KPiB0b29scy9vY2FtbC94ZW5zdG9yZWQvZG9tYWlucy5tbCAg ICAgfCAgMiAtDQo+IDMgZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgNDcgZGVsZXRp b25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Nvbm5lY3Rp b25zLm1sIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Nvbm5lY3Rpb25zLm1sDQo+IGluZGV4IDdk NjhjNTgzYjQzYS4uYTgwYWUwYmVkMmNlIDEwMDY0NA0KPiAtLS0gYS90b29scy9vY2FtbC94ZW5z dG9yZWQvY29ubmVjdGlvbnMubWwNCj4gKysrIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2Nvbm5l Y3Rpb25zLm1sDQo+IEBAIC00OCw5ICs0OCw3IEBAIGxldCBhZGRfZG9tYWluIGNvbnMgZG9tID0N Cj4gbGV0IHhiY29uID0gWGVuYnVzLlhiLm9wZW5fbW1hcCB+Y2FwYWNpdHkgKERvbWFpbi5nZXRf aW50ZXJmYWNlIGRvbSkgKGZ1biAoKSAtPiBEb21haW4ubm90aWZ5IGRvbSkgaW4NCj4gbGV0IGNv biA9IENvbm5lY3Rpb24uY3JlYXRlIHhiY29uIChTb21lIGRvbSkgaW4NCj4gSGFzaHRibC5hZGQg Y29ucy5kb21haW5zIChEb21haW4uZ2V0X2lkIGRvbSkgY29uOw0KPiAtIG1hdGNoIERvbWFpbi5n ZXRfcG9ydCBkb20gd2l0aA0KPiAtIHwgU29tZSBwIC0+IEhhc2h0YmwuYWRkIGNvbnMucG9ydHMg cCBjb247DQo+IC0gfCBOb25lIC0+ICgpDQo+ICsgSGFzaHRibC5hZGQgY29ucy5wb3J0cyAoRG9t YWluLmdldF9sb2NhbF9wb3J0IGRvbSkgY29uDQo+IA0KPiBsZXQgc2VsZWN0ID8ob25seV9pZiA9 IChmdW4gXyAtPiB0cnVlKSkgY29ucyA9DQo+IEhhc2h0YmwuZm9sZCAoZnVuIF8gY29uIChpbnMs IG91dHMpIC0+DQo+IEBAIC05NywxMCArOTUsNyBAQCBsZXQgZGVsX2RvbWFpbiBjb25zIGlkID0N Cj4gbGV0IGNvbiA9IGZpbmRfZG9tYWluIGNvbnMgaWQgaW4NCj4gSGFzaHRibC5yZW1vdmUgY29u cy5kb21haW5zIGlkOw0KPiAobWF0Y2ggQ29ubmVjdGlvbi5nZXRfZG9tYWluIGNvbiB3aXRoDQo+ IC0gfCBTb21lIGQgLT4NCj4gLSAgIChtYXRjaCBEb21haW4uZ2V0X3BvcnQgZCB3aXRoDQo+IC0g ICAgfCBTb21lIHAgLT4gSGFzaHRibC5yZW1vdmUgY29ucy5wb3J0cyBwDQo+IC0gICAgfCBOb25l IC0+ICgpKQ0KPiArIHwgU29tZSBkIC0+IEhhc2h0YmwucmVtb3ZlIGNvbnMucG9ydHMgKERvbWFp bi5nZXRfbG9jYWxfcG9ydCBkKQ0KPiB8IE5vbmUgLT4gKCkpOw0KPiBkZWxfd2F0Y2hlcyBjb25z IGNvbjsNCj4gQ29ubmVjdGlvbi5jbG9zZSBjb24NCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9kb21haW4ubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvZG9tYWluLm1sDQo+ IGluZGV4IGQ1OWE5NDAxZTIxMS4uZWNkZDY1ZjMyMDlhIDEwMDY0NA0KPiAtLS0gYS90b29scy9v Y2FtbC94ZW5zdG9yZWQvZG9tYWluLm1sDQo+ICsrKyBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9k b21haW4ubWwNCj4gQEAgLTE5LDE0ICsxOSwzMSBAQCBvcGVuIFByaW50Zg0KPiBsZXQgZGVidWcg Zm10ID0gTG9nZ2luZy5kZWJ1ZyAiZG9tYWluIiBmbXQNCj4gbGV0IHdhcm4gIGZtdCA9IExvZ2dp bmcud2FybiAgImRvbWFpbiIgZm10DQo+IA0KPiArKCogQW4gZXZlbnQgY2hhbm5lbCBwb3J0IHBh aXIuICBUaGUgcmVtb3RlIHBvcnQsIGFuZCB0aGUgbG9jYWwgcG9ydCBpdCBpcw0KPiArICAgYm91 bmQgdG8uICopDQo+ICt0eXBlIHBvcnRfcGFpciA9DQo+ICt7DQo+ICsgbG9jYWw6IFhlbmV2ZW50 Y2huLnQ7DQo+ICsgcmVtb3RlOiBpbnQ7DQo+ICt9DQo+ICsNCj4gKygqIFNlbnRpbmFsIHBvcnRf cGFpciB3aXRoIGJvdGggc2V0IHRvIEVWVENITl9JTlZBTElEICopDQo+ICtsZXQgaW52YWxpZF9w b3J0cyA9DQo+ICt7DQo+ICsgbG9jYWwgPSBYZW5ldmVudGNobi5vZl9pbnQgMDsNCj4gKyByZW1v dGUgPSAwDQo+ICt9DQo+ICsNCj4gK2xldCBzdHJpbmdfb2ZfcG9ydF9wYWlyIHAgPQ0KPiArIHNw cmludGYgIihsICVkLCByICVkKSIgKFhlbmV2ZW50Y2huLnRvX2ludCBwLmxvY2FsKSBwLnJlbW90 ZQ0KPiArDQo+IHR5cGUgdCA9DQo+IHsNCj4gaWQ6IFhlbmN0cmwuZG9taWQ7DQo+IG1mbjogbmF0 aXZlaW50Ow0KPiBpbnRlcmZhY2U6IFhlbm1tYXAubW1hcF9pbnRlcmZhY2U7DQo+IGV2ZW50Y2hu OiBFdmVudC50Ow0KPiAtIG11dGFibGUgcmVtb3RlX3BvcnQ6IGludDsNCj4gLSBtdXRhYmxlIHBv cnQ6IFhlbmV2ZW50Y2huLnQgb3B0aW9uOw0KPiArIG11dGFibGUgcG9ydHM6IHBvcnRfcGFpcjsN Cj4gbXV0YWJsZSBiYWRfY2xpZW50OiBib29sOw0KPiBtdXRhYmxlIGlvX2NyZWRpdDogaW50OyAo KiB0aGUgcm91bmRzIG9mIHJpbmcgcHJvY2VzcyBsZWZ0IHRvIGRvLCBkZWZhdWx0IGlzIDAsDQo+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgdXN1YWxseSBzZXQgdG8gMSB3aGVuIHRoZXJlIGlz IHdvcmsgZGV0ZWN0ZWQsIGNvdWxkDQo+IEBAIC00MSw4ICs1OCw4IEBAIGxldCBpc19kb20wIGQg PSBkLmlkID0gMA0KPiBsZXQgZ2V0X2lkIGRvbWFpbiA9IGRvbWFpbi5pZA0KPiBsZXQgZ2V0X2lu dGVyZmFjZSBkID0gZC5pbnRlcmZhY2UNCj4gbGV0IGdldF9tZm4gZCA9IGQubWZuDQo+IC1sZXQg Z2V0X3JlbW90ZV9wb3J0IGQgPSBkLnJlbW90ZV9wb3J0DQo+IC1sZXQgZ2V0X3BvcnQgZCA9IGQu cG9ydA0KPiArbGV0IGdldF9yZW1vdGVfcG9ydCBkID0gZC5wb3J0cy5yZW1vdGUNCj4gK2xldCBn ZXRfbG9jYWxfcG9ydCBkID0gZC5wb3J0cy5sb2NhbA0KPiANCj4gbGV0IGlzX2JhZF9kb21haW4g ZG9tYWluID0gZG9tYWluLmJhZF9jbGllbnQNCj4gbGV0IG1hcmtfYXNfYmFkIGRvbWFpbiA9IGRv bWFpbi5iYWRfY2xpZW50IDwtIHRydWUNCj4gQEAgLTU2LDU0ICs3MywzNiBAQCBsZXQgaXNfcGF1 c2VkX2Zvcl9jb25mbGljdCBkb20gPSBkb20uY29uZmxpY3RfY3JlZGl0IDw9IDAuMA0KPiANCj4g bGV0IGlzX2ZyZWVfdG9fY29uZmxpY3QgPSBpc19kb20wDQo+IA0KPiAtbGV0IHN0cmluZ19vZl9w b3J0ID0gZnVuY3Rpb24NCj4gLSB8IE5vbmUgLT4gIk5vbmUiDQo+IC0gfCBTb21lIHggLT4gc3Ry aW5nX29mX2ludCAoWGVuZXZlbnRjaG4udG9faW50IHgpDQo+IC0NCj4gbGV0IGR1bXAgZCBjaGFu ID0NCj4gLSBmcHJpbnRmIGNoYW4gImRvbSwlZCwlbmQsJWRcbiIgZC5pZCBkLm1mbiBkLnJlbW90 ZV9wb3J0DQo+ICsgZnByaW50ZiBjaGFuICJkb20sJWQsJW5kLCVkXG4iIGQuaWQgZC5tZm4gZC5w b3J0cy5yZW1vdGUNCj4gDQo+IGxldCByZWJpbmRfZXZ0Y2huIGQgcmVtb3RlX3BvcnQgPQ0KPiAt IGJlZ2luIG1hdGNoIGQucG9ydCB3aXRoDQo+IC0gfCBOb25lIC0+ICgpDQo+IC0gfCBTb21lIHAg LT4gRXZlbnQudW5iaW5kIGQuZXZlbnRjaG4gcA0KPiAtIGVuZDsNCj4gKyBFdmVudC51bmJpbmQg ZC5ldmVudGNobiBkLnBvcnRzLmxvY2FsOw0KPiBsZXQgbG9jYWwgPSBFdmVudC5iaW5kX2ludGVy ZG9tYWluIGQuZXZlbnRjaG4gZC5pZCByZW1vdGVfcG9ydCBpbg0KPiAtIGRlYnVnICJkb21haW4g JWQgcmViaW5kIChsICVzLCByICVkKSA9PiAobCAlZCwgciAlZCkiDQo+IC0gICAgICBkLmlkIChz dHJpbmdfb2ZfcG9ydCBkLnBvcnQpIGQucmVtb3RlX3BvcnQNCj4gLSAgICAgIChYZW5ldmVudGNo bi50b19pbnQgbG9jYWwpIHJlbW90ZV9wb3J0Ow0KPiAtIGQucmVtb3RlX3BvcnQgPC0gcmVtb3Rl X3BvcnQ7DQo+IC0gZC5wb3J0IDwtIFNvbWUgKGxvY2FsKQ0KPiArIGxldCBwb3J0cyA9IHsgbG9j YWw7IHJlbW90ZSA9IHJlbW90ZV9wb3J0IH0gaW4NCj4gKyBkZWJ1ZyAiZG9tYWluICVkIHJlYmlu ZCAlcyA9PiAlcyINCj4gKyAgICAgIGQuaWQgKHN0cmluZ19vZl9wb3J0X3BhaXIgZC5wb3J0cykg KHN0cmluZ19vZl9wb3J0X3BhaXIgcG9ydHMpOw0KPiArIGQucG9ydHMgPC0gcG9ydHMNCj4gDQo+ IGxldCBub3RpZnkgZG9tID0NCj4gLSBtYXRjaCBkb20ucG9ydCB3aXRoDQo+IC0gfCBOb25lIC0+ IHdhcm4gImRvbWFpbiAlZDogYXR0ZW1wdCB0byBub3RpZnkgb24gdW5rbm93biBwb3J0IiBkb20u aWQNCj4gLSB8IFNvbWUgcG9ydCAtPiBFdmVudC5ub3RpZnkgZG9tLmV2ZW50Y2huIHBvcnQNCj4g LQ0KPiAtbGV0IGJpbmRfaW50ZXJkb21haW4gZG9tID0NCj4gLSBiZWdpbiBtYXRjaCBkb20ucG9y dCB3aXRoDQo+IC0gfCBOb25lIC0+ICgpDQo+IC0gfCBTb21lIHBvcnQgLT4gRXZlbnQudW5iaW5k IGRvbS5ldmVudGNobiBwb3J0DQo+IC0gZW5kOw0KPiAtIGRvbS5wb3J0IDwtIFNvbWUgKEV2ZW50 LmJpbmRfaW50ZXJkb21haW4gZG9tLmV2ZW50Y2huIGRvbS5pZCBkb20ucmVtb3RlX3BvcnQpOw0K PiAtIGRlYnVnICJib3VuZCBkb21haW4gJWQgcmVtb3RlIHBvcnQgJWQgdG8gbG9jYWwgcG9ydCAl cyIgZG9tLmlkIGRvbS5yZW1vdGVfcG9ydCAoc3RyaW5nX29mX3BvcnQgZG9tLnBvcnQpDQo+IC0N Cj4gKyBFdmVudC5ub3RpZnkgZG9tLmV2ZW50Y2huIGRvbS5wb3J0cy5sb2NhbA0KPiANCj4gbGV0 IGNsb3NlIGRvbSA9DQo+IC0gZGVidWcgImRvbWFpbiAlZCB1bmJvdW5kIHBvcnQgJXMiIGRvbS5p ZCAoc3RyaW5nX29mX3BvcnQgZG9tLnBvcnQpOw0KPiAtIGJlZ2luIG1hdGNoIGRvbS5wb3J0IHdp dGgNCj4gLSB8IE5vbmUgLT4gKCkNCj4gLSB8IFNvbWUgcG9ydCAtPiBFdmVudC51bmJpbmQgZG9t LmV2ZW50Y2huIHBvcnQNCj4gLSBlbmQ7DQo+ICsgZGVidWcgImRvbWFpbiAlZCB1bmJpbmQgJXMi IGRvbS5pZCAoc3RyaW5nX29mX3BvcnRfcGFpciBkb20ucG9ydHMpOw0KPiArIEV2ZW50LnVuYmlu ZCBkb20uZXZlbnRjaG4gZG9tLnBvcnRzLmxvY2FsOw0KPiArIGRvbS5wb3J0cyA8LSBpbnZhbGlk X3BvcnRzOw0KPiBYZW5tbWFwLnVubWFwIGRvbS5pbnRlcmZhY2UNCj4gDQo+IC1sZXQgbWFrZSBp ZCBtZm4gcmVtb3RlX3BvcnQgaW50ZXJmYWNlIGV2ZW50Y2huID0gew0KPiArbGV0IG1ha2UgaWQg bWZuIHJlbW90ZV9wb3J0IGludGVyZmFjZSBldmVudGNobiA9DQo+ICsgbGV0IGxvY2FsID0gRXZl bnQuYmluZF9pbnRlcmRvbWFpbiBldmVudGNobiBpZCByZW1vdGVfcG9ydCBpbg0KPiArIGxldCBw b3J0cyA9IHsgbG9jYWw7IHJlbW90ZSA9IHJlbW90ZV9wb3J0IH0gaW4NCj4gKyBkZWJ1ZyAiZG9t YWluICVkIGJpbmQgJXMiIGlkIChzdHJpbmdfb2ZfcG9ydF9wYWlyIHBvcnRzKTsNCj4gK3sNCj4g aWQgPSBpZDsNCj4gbWZuID0gbWZuOw0KPiAtIHJlbW90ZV9wb3J0ID0gcmVtb3RlX3BvcnQ7DQo+ ICsgcG9ydHM7DQo+IGludGVyZmFjZSA9IGludGVyZmFjZTsNCj4gZXZlbnRjaG4gPSBldmVudGNo bjsNCj4gLSBwb3J0ID0gTm9uZTsNCj4gYmFkX2NsaWVudCA9IGZhbHNlOw0KPiBpb19jcmVkaXQg PSAwOw0KPiBjb25mbGljdF9jcmVkaXQgPSAhRGVmaW5lLmNvbmZsaWN0X2J1cnN0X2xpbWl0Ow0K PiBkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RvbWFpbnMubWwgYi90b29scy9v Y2FtbC94ZW5zdG9yZWQvZG9tYWlucy5tbA0KPiBpbmRleCAyNjAxOGFjMGRkM2QuLjJhYjBjNWY0 ZDhkMCAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RvbWFpbnMubWwNCj4g KysrIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL2RvbWFpbnMubWwNCj4gQEAgLTEyNiw3ICsxMjYs NiBAQCBsZXQgY3JlYXRlIGRvbXMgZG9taWQgbWZuIHJlbW90ZV9wb3J0ID0NCj4gbGV0IGludGVy ZmFjZSA9IFhlbmN0cmwubWFwX2ZvcmVpZ25fcmFuZ2UgeGMgZG9taWQgKFhlbm1tYXAuZ2V0cGFn ZXNpemUoKSkgbWZuIGluDQo+IGxldCBkb20gPSBEb21haW4ubWFrZSBkb21pZCBtZm4gcmVtb3Rl X3BvcnQgaW50ZXJmYWNlIGRvbXMuZXZlbnRjaG4gaW4NCj4gSGFzaHRibC5hZGQgZG9tcy50YWJs ZSBkb21pZCBkb207DQo+IC0gRG9tYWluLmJpbmRfaW50ZXJkb21haW4gZG9tOw0KPiBkb20NCj4g DQo+IGxldCB4ZW5zdG9yZWRfa3ZhID0gcmVmICIiDQo+IEBAIC0xNDQsNyArMTQzLDYgQEAgbGV0 IGNyZWF0ZTAgZG9tcyA9DQo+IA0KPiBsZXQgZG9tID0gRG9tYWluLm1ha2UgMCBOYXRpdmVpbnQu emVybyByZW1vdGVfcG9ydCBpbnRlcmZhY2UgZG9tcy5ldmVudGNobiBpbg0KPiBIYXNodGJsLmFk ZCBkb21zLnRhYmxlIDAgZG9tOw0KPiAtIERvbWFpbi5iaW5kX2ludGVyZG9tYWluIGRvbTsNCj4g RG9tYWluLm5vdGlmeSBkb207DQo+IGRvbQ0KPiANCj4gLS0gDQo+IDIuMTEuMA0KPiANCg0K From xen-devel-bounces@lists.xenproject.org Wed Nov 30 17:33:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 17:33:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450098.707283 (Exim 4.92) (envelope-from ) id 1p0QxV-0005Z7-3f; Wed, 30 Nov 2022 17:33:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450098.707283; Wed, 30 Nov 2022 17:33:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QxV-0005Yu-0s; Wed, 30 Nov 2022 17:33:21 +0000 Received: by outflank-mailman (input) for mailman id 450098; Wed, 30 Nov 2022 17:33:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QxT-00053d-7P for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 17:33:19 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 12ca3d45-70d5-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 18:33:17 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12ca3d45-70d5-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669829597; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=R8tS9VgTmZCKkVg8mid7m3tdzdgd3LVHFCyxaU4xcZE=; b=FjvBuq5NbV1i4ABe7mZQ3MtfUW7glSdeysPyITmSFAksVJgPbf5BvIT7 EMmqN7V8No+ebD5WZ4VqjPgJ4cE/WEd3iwCwc0cN/NRQ/EPd68cMdBGf3 ZTAzUnAwARkO7BTYIKvLp+UKfmbNMLFXEuiBtEqMYyBIJdROpLInrRS5t I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 85454980 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:CghTFam5DW/h/esGzeJ12fHo5gyVJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJMUDyEa/yOYmejKdtzPduwphlVsZeDzNBlHgQ4rC9kQSMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5weGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eRJGTlSU0ynvMX12bGZVe5ulMAKCNa+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsfYT/7C7pn9AusrnTzbTxe7k6Sv600y2PS0BZwwP7mN9+9ltmiFZgJwxrJ9 jquE2LRAxAdbdq17CW/8nf2uNbdmXv1WsEWC+jtnhJtqALKnTFCYPEMbnOrrP/8hkOgVtZ3L 00P5jFovaU07FasTNT2Q1u/unHslhIVRdd4CeAx7wCJjK3O7G6xGWwsXjNHLts8u6cLqScCj wHT2YmzXHo27ePTGSn1GqqoQS2aIXkkJDA/OQs/akgc4Pv8p4MhijvrUYM2eEKqteHdFTb1y jGMiSExgbQPkMIGv5mGEUD7byGE/caQEFNsjunDdif8t14iOtb5D2C9wQKDhcusOrp1WbVoU JIsv8GFpN4DApiW/MBmaLVcRer5jxpp3dC1vLKOI3XD3271k5JAVdoKiN2bGKuOGphsRNMRS BWP0T69HbcKVJdQUYd5YpiqF+MhxrX6GNLuW5j8N4QQM8ctKlHaon0yOyZ8OlwBdmB2ycnT3 r/CIa6R4YsyU/w7nFJauc9CuVPU+szO7TyKHs2qp/hW+bGfeGSUWd843KimN4gEAFe/iFyNq b53bpLaoyizpcWiOkE7B6ZPdwFVRZX6bLiqw/Fqmhmre1E3Qjh+W6KJmNvMueVNxsxoqwsBx VnlMmcw9bY1rSevxdmiApy7VI7SYA== IronPort-HdrOrdr: A9a23:qeUwlqE+62/8kLzupLqELMeALOsnbusQ8zAXPiBKJCC9E/bo8v xG+c5w6faaslkssR0b9+xoW5PwI080l6QU3WB5B97LMDUO0FHCEGgI1/qA/9SPIUzDHu4279 YbT0B9YueAcGSTW6zBkXWF+9VL+qj5zEix792uq0uE1WtRGtldBwESMHf9LmRGADNoKLAeD5 Sm6s9Ot1ObCA8qhpTSPAhiYwDbzee77a7bXQ== X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="85454980" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH v1 5/5] CODING_STYLE: add .clang-format Date: Wed, 30 Nov 2022 17:32:37 +0000 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Add a .clang-format configuration that tries to match CODING_STYLE where possible. I was not able to express the special casing of braces after 'do' though, this can only be controlled generally for all control statements. It is imperfect, but should be better than the existing bindings, which do not follow Xen coding style. Add this to tools/ocaml first because: * there are relatively few C files here, and it is a good place to start with * it'd be useful to make these follow Xen's CODING_STYLE (which they currently do not because they use tabs for example) * they change relatively infrequently, so shouldn't cause issues with backporting security fixes (could either backport the reindentation patch too, or use git cherry-pick with `-Xignore-space-change`) Once this is used it'll need inserting some '#include ', otherwise xs_wire.h fails to compile due to the missing uint32_t define. Does not yet reformat any code. No functional change. Signed-off-by: Edwin Török --- tools/ocaml/.clang-format | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 tools/ocaml/.clang-format diff --git a/tools/ocaml/.clang-format b/tools/ocaml/.clang-format new file mode 100644 index 0000000000..7ff88ee043 --- /dev/null +++ b/tools/ocaml/.clang-format @@ -0,0 +1,9 @@ +BasedOnStyle: GNU +IndentWidth: 4 + +# override GNU to match Xen ../../CODING_STYLE more closely +AlwaysBreakAfterDefinitionReturnType: None +AlwaysBreakAfterReturnType: None +SpacesInConditionalStatement: true +SpaceBeforeParens: ControlStatements +BreakBeforeBraces: Allman -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 17:33:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 17:33:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450096.707262 (Exim 4.92) (envelope-from ) id 1p0QxS-00053l-FY; Wed, 30 Nov 2022 17:33:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450096.707262; Wed, 30 Nov 2022 17:33:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QxS-00053e-C2; Wed, 30 Nov 2022 17:33:18 +0000 Received: by outflank-mailman (input) for mailman id 450096; Wed, 30 Nov 2022 17:33:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QxR-00053X-3v for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 17:33:17 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 114a107b-70d5-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 18:33:15 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 114a107b-70d5-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669829595; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=B7XrV77otQZr2bmIK7huqRctxQtLlsxHZQUaKQ7Y7q8=; b=Q8h72x2uc8i0RjasTKe/N1jTVHdJjnRcmE+gxN+9AEIxIxWr5LmBRbfm QdE9oaZRSTps4Cdb3wpe69LgLiZYfhxRdppoEGgtdfuYefFIsLukuwxMO 64yVQQMPo0pHk/UzOg7eJCfToBgtqUSmpiOxEU5osEHTSCHUPPI4z0Y6k 8=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 86313610 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Lg4mnqjZUi/+DKrXzquvOEBpX161dBAKZh0ujC45NGQN5FlHY01je htvWzyAMv+Iazb3eogkYYrg9h5T78TRytZnHgFrpCkwFn4b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QSGzyJ94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQSMjMOMw6AlduHwZ6KWMVAjJ9zFe3kadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglHyfyNZrhSJorAw4EDYzRBr0airO93QEjCPbZULxR/D+ Duel4j/Kjc/G9GT2Tekzn2tq8bErRPxZpMoE4Tto5aGh3XMnzdOWXX6T2CTvv2RmkO4HdVFJ CQ89iMwoIAo+UesT927WAe3yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBeeNAx/ gbXxZWzX2Up6eDLDyLGnluJkd+sESIPLmxfeywWdDoEz+jxjK051UL2atk2RcZZkebJMT33x jmLqg03iLMSkdMH2s2HwLzXv96/jsOXF1Bov207Skrgt1okP9D9O+RE/HCBtZ59wJClok5tV ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFRz3oxZPnqgKulmSwXuF1e5aEQIFm GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPMkuKFHZoX8yORD4M4XRfK4Ey/lX1 XCzKJbEMJrnIf4/kGreqxk1jtfHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrlR0U9wmy2Mq 4w3H5LTm31ivBjWPnG/HXg7cQpbchDWxPne96RqSwJ0ClM9STt4VK+MmepJlk4Mt/09q9okN 0qVAidwoGcTT1WdQelWQhiPsI/SYKs= IronPort-HdrOrdr: A9a23:gs2GP6tklA7/7iaOstds2vAr7skDctV00zEX/kB9WHVpm6uj+/ xG/c516faQsl0ssR4b9+xoVJPgfZq/z+8X3WBhB9eftWDd0QPDQb2KhrGSoQEIdReOktJ15O NNdLV/Fc21LXUSt7ec3OBgKadE/OW6 X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="86313610" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Christian Lindig" , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH v1 3/5] tools/ocaml/libs/xc: add hvm_param_get binding Date: Wed, 30 Nov 2022 17:32:35 +0000 Message-ID: <63240681327af995df64b773945406b097a31d4b.1669829264.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Not to be confused which hvm_get_param, which also exists and has a different, more error-prone interface. This one always returns a 64-bit value, and that is retained in the OCaml binding as well, returning 'int64' (and not int, or nativeint which might have a different size). The integer here is unsigned in the C API, however OCaml only has signed integers. No bits are lost, it is just a matter of interpretation when printing and for certain arithmetic operations, however in the cases where the MSB is set it is very likely that the value is an address and no arithmetic should be performed on the OCaml side on it. (this is not a new problem with this binding, but worth mentioning given the difference in types) Signed-off-by: Edwin Török --- tools/ocaml/libs/xc/xenctrl.ml | 44 ++++++++++++++++++++++++++++ tools/ocaml/libs/xc/xenctrl.mli | 45 +++++++++++++++++++++++++++++ tools/ocaml/libs/xc/xenctrl_stubs.c | 16 ++++++++++ 3 files changed, 105 insertions(+) diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index c21e391f98..1f8d927b0c 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -298,6 +298,50 @@ external map_foreign_range: handle -> domid -> int -> nativeint -> Xenmmap.mmap_interface = "stub_map_foreign_range" +type hvm_param = + | HVM_PARAM_CALLBACK_IRQ + | HVM_PARAM_STORE_PFN + | HVM_PARAM_STORE_EVTCHN + | HVM_PARAM_UNDEFINED_3 + | HVM_PARAM_PAE_ENABLED + | HVM_PARAM_IOREQ_PFN + | HVM_PARAM_BUFIOREQ_PFN + | HVM_PARAM_UNDEFINED_7 + | HVM_PARAM_UNDEFINED_8 + | HVM_PARAM_VIRIDIAN + | HVM_PARAM_TIMER_MODE0 + | HVM_PARAM_HPET_ENABLED1 + | HVM_PARAM_IDENT_PT2 + | HVM_PARAM_UNDEFINED_13 + | HVM_PARAM_ACPI_S_STATE4 + | HVM_PARAM_VM86_TSS5 + | HVM_PARAM_VPT_ALIGN6 + | HVM_PARAM_CONSOLE_PFN7 + | HVM_PARAM_CONSOLE_EVTCHN8 + | HVM_PARAM_ACPI_IOPORTS_LOCATION9 + | HVM_PARAM_MEMORY_EVENT_CR00 + | HVM_PARAM_MEMORY_EVENT_CR31 + | HVM_PARAM_MEMORY_EVENT_CR42 + | HVM_PARAM_MEMORY_EVENT_INT33 + | HVM_PARAM_NESTEDHVM4 + | HVM_PARAM_MEMORY_EVENT_SINGLE_STEP5 + | HVM_PARAM_UNDEFINED_26 + | HVM_PARAM_PAGING_RING_PFN7 + | HVM_PARAM_MONITOR_RING_PFN8 + | HVM_PARAM_SHARING_RING_PFN9 + | HVM_PARAM_MEMORY_EVENT_MSR0 + | HVM_PARAM_TRIPLE_FAULT_REASON1 + | HVM_PARAM_IOREQ_SERVER_PFN2 + | HVM_PARAM_NR_IOREQ_SERVER_PAGES3 + | HVM_PARAM_VM_GENERATION_ID_ADDR4 + | HVM_PARAM_ALTP2M5 + | HVM_PARAM_X87_FIP_WIDTH6 + | HVM_PARAM_VM86_TSS_SIZED7 + | HVM_PARAM_MCA_CAP8 + +external hvm_param_get: handle -> domid -> hvm_param -> int64 + = "stub_xc_hvm_param_get" + external domain_assign_device: handle -> domid -> (int * int * int * int) -> unit = "stub_xc_domain_assign_device" external domain_deassign_device: handle -> domid -> (int * int * int * int) -> unit diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index 60e7902e66..f6c7e5b553 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -236,6 +236,51 @@ external map_foreign_range : handle -> domid -> int -> nativeint -> Xenmmap.mmap_interface = "stub_map_foreign_range" +(* needs to be sorted according to its numeric value, watch out for gaps! *) +type hvm_param = + | HVM_PARAM_CALLBACK_IRQ + | HVM_PARAM_STORE_PFN + | HVM_PARAM_STORE_EVTCHN + | HVM_PARAM_UNDEFINED_3 + | HVM_PARAM_PAE_ENABLED + | HVM_PARAM_IOREQ_PFN + | HVM_PARAM_BUFIOREQ_PFN + | HVM_PARAM_UNDEFINED_7 + | HVM_PARAM_UNDEFINED_8 + | HVM_PARAM_VIRIDIAN + | HVM_PARAM_TIMER_MODE0 + | HVM_PARAM_HPET_ENABLED1 + | HVM_PARAM_IDENT_PT2 + | HVM_PARAM_UNDEFINED_13 + | HVM_PARAM_ACPI_S_STATE4 + | HVM_PARAM_VM86_TSS5 + | HVM_PARAM_VPT_ALIGN6 + | HVM_PARAM_CONSOLE_PFN7 + | HVM_PARAM_CONSOLE_EVTCHN8 + | HVM_PARAM_ACPI_IOPORTS_LOCATION9 + | HVM_PARAM_MEMORY_EVENT_CR00 + | HVM_PARAM_MEMORY_EVENT_CR31 + | HVM_PARAM_MEMORY_EVENT_CR42 + | HVM_PARAM_MEMORY_EVENT_INT33 + | HVM_PARAM_NESTEDHVM4 + | HVM_PARAM_MEMORY_EVENT_SINGLE_STEP5 + | HVM_PARAM_UNDEFINED_26 + | HVM_PARAM_PAGING_RING_PFN7 + | HVM_PARAM_MONITOR_RING_PFN8 + | HVM_PARAM_SHARING_RING_PFN9 + | HVM_PARAM_MEMORY_EVENT_MSR0 + | HVM_PARAM_TRIPLE_FAULT_REASON1 + | HVM_PARAM_IOREQ_SERVER_PFN2 + | HVM_PARAM_NR_IOREQ_SERVER_PAGES3 + | HVM_PARAM_VM_GENERATION_ID_ADDR4 + | HVM_PARAM_ALTP2M5 + | HVM_PARAM_X87_FIP_WIDTH6 + | HVM_PARAM_VM86_TSS_SIZED7 + | HVM_PARAM_MCA_CAP8 + +external hvm_param_get: handle -> domid -> hvm_param -> int64 + = "stub_xc_hvm_param_get" + external domain_assign_device: handle -> domid -> (int * int * int * int) -> unit = "stub_xc_domain_assign_device" external domain_deassign_device: handle -> domid -> (int * int * int * int) -> unit diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index 67f3648391..b2df93d4f8 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -1176,6 +1176,22 @@ CAMLprim value stub_xc_domain_irq_permission(value xch, value domid, CAMLreturn(Val_unit); } +CAMLprim value stub_xc_hvm_param_get(value xch, value domid, value param) +{ + CAMLparam3(xch, domid, param); + uint64_t result; + int ret; + + caml_enter_blocking_section(); + ret = xc_hvm_param_get(_H(xch), _D(domid), Int_val(param), &result); + caml_leave_blocking_section(); + + if ( ret ) + failwith_xc(_H(xch)); + + CAMLreturn(caml_copy_int64(result)); +} + static uint32_t encode_sbdf(int domain, int bus, int dev, int func) { return ((uint32_t)domain & 0xffff) << 16 | -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 17:33:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 17:33:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450097.707272 (Exim 4.92) (envelope-from ) id 1p0QxT-0005JN-SH; Wed, 30 Nov 2022 17:33:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450097.707272; Wed, 30 Nov 2022 17:33:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QxT-0005JG-PW; Wed, 30 Nov 2022 17:33:19 +0000 Received: by outflank-mailman (input) for mailman id 450097; Wed, 30 Nov 2022 17:33:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0QxS-00053d-Es for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 17:33:18 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 124fa896-70d5-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 18:33:17 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 124fa896-70d5-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669829597; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Kvmroc4UWt6I3gO1OX/SxhaVKAh4s5W8paVaKox+rwU=; b=FQz3h5nVOWo208fSSwDlzo/0MF7T7PKxzO8Xxlrm4RCT0evwNg5xp6FF i8e9emupr6hgeLGpv+gcS/bCf8uNMPbVXEtrqXYLG1qKzUKjP/ZXhLcft QS6z2CB2vtUEQYmMgaPDZJI6GKpe5JhvPJEKSutffFCcNX6fREBI2bj7/ 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 85454977 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:+mcOrqy7MRCREOvezwh6t+cJxirEfRIJ4+MujC+fZmUNrF6WrkUCz DNNXDjXPfaONjSnc9p3YNu39h8C65bQzIVnTVNuqCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPqgT5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KUV29 vkgMi00VSiojemsmvXge8lV2/12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tOqkmHj5NSFfslWWjaE2/3LS3Ep6172F3N/9KoHWGJkEwRnwS mTu/G7TXQkFLP2jyGCU/EiovOPd2g/ER9dHfFG/3qEz2wDCroAJMzUUSF+6rP+RmkO4HdVFJ CQ85S4GvaU0skuxQbHVRAakqXSJuhodXdt4EOAg7gyJjK3O7G6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+Wpz6vPSkeLUcZeDQJCwAC5rHeTJob10yVCIw5Sejs04OzSWqYL y22QDYWo40QiPYRypyAxXvNiCj24cP4bjdo31CCNo661T9RaImgbo2uzFHU6/dcMYqUJmW8U Gg4d9u2t75XU8zU/MCZaKBURezyua7ZWNHJqQQ3d6TN4QhB7JJKkWp4xDhlbHlkPc8fEdMCS B+C4FgBjHO/0ZbDUEOWX25TI55ypUQDPY6/PhwxUjapSsYZSeN/1HsyDXN8Jki0+KTWrYkxO I2AbeGnBmsABKJswVKeHrlDgOB3mH5jmz+PG/gXKihLN5LEPBZ5rp9cYDOzgh0RtvvY8G05D f4AXyd19/mveLKnOXSGmWLiBVsLMWI6FfjLRz9/L4a+zv5dMDh5UZf5mOpxE7GJaowJzo8kC FnhAB4HoLc+7FWbQTi3hodLMei+B88g/S9jZETB/z+AghAeXGpm149HH7NfQFXt3LULISJcJ xXdR/i9Pw== IronPort-HdrOrdr: A9a23:q/St6qBmJ7YcpE/lHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="85454977" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Andrew Cooper" , George Dunlap , Jan Beulich , Julien Grall , "Stefano Stabellini" , Wei Liu Subject: [PATCH v1 1/5] CODING-STYLE: add .editorconfig to clarify indentation uses spaces Date: Wed, 30 Nov 2022 17:32:33 +0000 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Add an .editorconfig to make it easier to keep patches compatible with Xen's coding style, and to reemphasize what Xen's coding style is. I thought that Xen demands tabs rather than spaces (which is more difficult with OCaml because indentation tools use spaces, and the use of tabs requires changing editor settings), however CODING-STYLE says it is spaces. Document this explicitly by adding a .editorconfig file (see editorconfig.org), which is an editor agnostic format for specifying basic style properties like indentation, either with native support in editors or via plugins. It is safer than modelines because it only supports controlling a restricted set of editor properties and not arbitrary commands as Vim modelines would have, and works with editors other than Vim too. (Vim has a deny list for modeline sandboxing, which is error-prone because every time a new command gets added it needs to be added to the deny list, which has been the source of a few CVEs in the past and I disable Vim modelines everywhere as a precaution). This file is added as a convenience for those who might have an editor that supports it, and its presence should have no impact on those that do not (want to) use it. It also won't cause re-indentation of existing files when edited, only newly added lines would follow the convention. No functional change. Signed-off-by: Edwin Török --- .editorconfig | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .editorconfig diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 0000000000..cb2f27c581 --- /dev/null +++ b/.editorconfig @@ -0,0 +1,20 @@ +# See ./CODING_STYLE +root = true + +[*] +end_of_line = lf +indent_style = space +charset = utf-8 +max_line_length = 79 +trim_trailing_whitespace = true +insert_final_newline = true + +# Makefiles must use tabs, otherwise they don't work +[{Makefile,*.mk,Makefile.rules}] +indent_style = tabs + +[*.{c,h}] +indent_size = 4 + +[*.{ml,mli}] +indent_size = 2 -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 17:33:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 17:33:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450101.707295 (Exim 4.92) (envelope-from ) id 1p0Qxj-00062Z-Ch; Wed, 30 Nov 2022 17:33:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450101.707295; Wed, 30 Nov 2022 17:33:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Qxj-00062S-9E; Wed, 30 Nov 2022 17:33:35 +0000 Received: by outflank-mailman (input) for mailman id 450101; Wed, 30 Nov 2022 17:33:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Qxi-00053d-5S for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 17:33:34 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1b1b3528-70d5-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 18:33:32 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b1b3528-70d5-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669829612; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TdKFY6xa4RIITGrxxK+ZLNUPhd54yxmI6+a2nMfKmA8=; b=L49WcI1jrgPpJEY1DqI0oCe5rOyLycD4qHceuyracvW8SakXApyzvhHl fxt3M2SYw4wC1qEpSGh6+lydzyboxDBSnWtguE4PSbyOHLn9lkMPacFjj IlhK+qbcT4S6mYNc/JJOJ5Nmk5zBt8WLwxxnGwvjszXP3ktbsVpMQFQm7 s=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 84930615 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:B+zHVaxNFohiJwWmSs56t+cgxirEfRIJ4+MujC+fZmUNrF6WrkUAm zcZXm6HaP+PMDfzLoolaoWwoEgBu5GEyNMyGlRspCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPqgT5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KU0Qr MIKBBcBVFOCg8OQ0fGna/JDn9t2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tOqkmHj5NSFfslWWjaE2/3LS3Ep6172F3N/9KoDbHp0LxxvwS mTu0Wi6XwoxJsGjzmCM6Xj9huL0uDzcV9dHfFG/3qEz2wDCroAJMzUGWF3+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQiHKNoBM0QddbFOw+rgaXxcL8/AKxFmUCCDlbZ7QbWNQeHGJwk AXTxpWwWGIp4Ob9pW+hGqm8gW3rBzo5CmM4Ji4AbC0UoMXCu64qkUeaJjp8K5KdgtrwEDD25 jmFqikimrke5fI2O7WHEUPv2Gz1+MWQJuIhzkCOBz/+sFslDGKwT9bwgWU3+8qsO2pworOpm HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKNN8N5n9hO0yT5FWy13N2ZDBkBDyr8UWW1C HI/QCsIjHOpAFOkbLVsf6W6ANkwwK7rGLzND66KP4USPMYsKlPbokmCgHJ8OUi3yCDAdolma f+mnTuEVy5GWcyLMhLpLwvi7VPb7n9nnj6CLXwK5x+mzaCfdBaopUQtaTOzghQCxPrc+m39q o8PX/ZmPj0DCIUSlAGLq99MRb3LRFBnba3LRzt/L7XSeFM5SDx5Upc8A9oJIuRYokicrc+Ql lnVZ6OS4ACg7ZEbAW1mskxeVY4= IronPort-HdrOrdr: A9a23:Asj1Y6ijO415SD9gjhfNZBmGcXBQXuIji2hC6mlwRA09TySZ// rBoB19726MtN9xYgBHpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5 0QF5SWYOeAdWSS5vya3ODXKbkdKaG8gcKVuds= X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="84930615" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH v1 2/5] tools/ocaml/libs/xc: add binding to xc_evtchn_status Date: Wed, 30 Nov 2022 17:32:34 +0000 Message-ID: <4daa8daa6398774e5cb0a90c30648c970faed6af.1669829264.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit There is no API or ioctl to query event channel status, it is only present in xenctrl.h The C union is mapped to an OCaml variant exposing just the value from the correct union tag. Querying event channel status is useful when analyzing Windows VMs that may have reset and changed the xenstore event channel port number from what it initially got booted with. The information provided here is similar to 'lstevtchn', but rather than parsing its output it queries the underlying API directly. Signed-off-by: Edwin Török --- tools/ocaml/libs/xc/xenctrl.ml | 14 +++++++ tools/ocaml/libs/xc/xenctrl.mli | 15 +++++++ tools/ocaml/libs/xc/xenctrl_stubs.c | 65 +++++++++++++++++++++++++++++ 3 files changed, 94 insertions(+) diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 2ed7454b16..c21e391f98 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -267,6 +267,20 @@ external evtchn_alloc_unbound: handle -> domid -> domid -> int = "stub_xc_evtchn_alloc_unbound" external evtchn_reset: handle -> domid -> unit = "stub_xc_evtchn_reset" +type evtchn_interdomain = { dom: domid; port: int} + +type evtchn_stat = + | EVTCHNSTAT_unbound of domid + | EVTCHNSTAT_interdomain of evtchn_interdomain + | EVTCHNSTAT_pirq of int + | EVTCHNSTAT_virq of int + | EVTCHNSTAT_ipi + +type evtchn_status = { vcpu: int; status: evtchn_stat } + +external evtchn_status: handle -> domid -> int -> evtchn_status option = + "stub_xc_evtchn_status" + external readconsolering: handle -> string = "stub_xc_readconsolering" external send_debug_keys: handle -> string -> unit = "stub_xc_send_debug_keys" diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index 0f80aafea0..60e7902e66 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -206,6 +206,21 @@ external shadow_allocation_get : handle -> domid -> int external evtchn_alloc_unbound : handle -> domid -> domid -> int = "stub_xc_evtchn_alloc_unbound" external evtchn_reset : handle -> domid -> unit = "stub_xc_evtchn_reset" + +type evtchn_interdomain = { dom: domid; port: int} + +type evtchn_stat = + | EVTCHNSTAT_unbound of domid + | EVTCHNSTAT_interdomain of evtchn_interdomain + | EVTCHNSTAT_pirq of int + | EVTCHNSTAT_virq of int + | EVTCHNSTAT_ipi + +type evtchn_status = { vcpu: int; status: evtchn_stat } + +external evtchn_status: handle -> domid -> int -> evtchn_status option = + "stub_xc_evtchn_status" + external readconsolering : handle -> string = "stub_xc_readconsolering" external send_debug_keys : handle -> string -> unit = "stub_xc_send_debug_keys" external physinfo : handle -> physinfo = "stub_xc_physinfo" diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index d30585f21c..67f3648391 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -641,6 +641,71 @@ CAMLprim value stub_xc_evtchn_reset(value xch, value domid) CAMLreturn(Val_unit); } +CAMLprim value stub_xc_evtchn_status(value xch, value domid, value port) +{ + CAMLparam3(xch, domid, port); + CAMLlocal4(result, result_status, stat, interdomain); + xc_evtchn_status_t status; + int rc; + + memset(&status, 0, sizeof(status)); + status.dom = _D(domid); + status.port = Int_val(port); + + caml_enter_blocking_section(); + rc = xc_evtchn_status(_H(xch), &status); + caml_leave_blocking_section(); + + if ( rc < 0 ) + failwith_xc(_H(xch)); + + if ( status.status == EVTCHNSTAT_closed ) + result = Val_none; + else + { + switch ( status.status ) + { + case EVTCHNSTAT_unbound: + stat = caml_alloc(1, 0); /* 1st non-constant constructor */ + Store_field(stat, 0, Val_int(status.u.unbound.dom)); + break; + + case EVTCHNSTAT_interdomain: + interdomain = caml_alloc_tuple(2); + Store_field(interdomain, 0, Val_int(status.u.interdomain.dom)); + Store_field(interdomain, 1, Val_int(status.u.interdomain.port)); + stat = caml_alloc(1, 1); /* 2nd non-constant constructor */ + Store_field(stat, 0, interdomain); + break; + case EVTCHNSTAT_pirq: + stat = caml_alloc(1, 2); /* 3rd non-constant constructor */ + Store_field(stat, 0, Val_int(status.u.pirq)); + break; + + case EVTCHNSTAT_virq: + stat = caml_alloc(1, 3); /* 4th non-constant constructor */ + Store_field(stat, 0, Val_int(status.u.virq)); + break; + + case EVTCHNSTAT_ipi: + stat = Val_int(0); /* 1st constant constructor */ + break; + + default: + caml_failwith("Unkown evtchn status"); + } + result_status = caml_alloc_tuple(2); + Store_field(result_status, 0, Val_int(status.vcpu)); + Store_field(result_status, 1, stat); + + /* Tag_some and caml_alloc_some are missing in older versions of OCaml + */ + result = caml_alloc_small(1, 0); + Store_field(result, 0, result_status); + } + + CAMLreturn(result); +} CAMLprim value stub_xc_readconsolering(value xch) { -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 17:33:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 17:33:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450102.707299 (Exim 4.92) (envelope-from ) id 1p0Qxj-00066g-Ov; Wed, 30 Nov 2022 17:33:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450102.707299; Wed, 30 Nov 2022 17:33:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Qxj-00065O-J0; Wed, 30 Nov 2022 17:33:35 +0000 Received: by outflank-mailman (input) for mailman id 450102; Wed, 30 Nov 2022 17:33:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Qxi-00053d-OK for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 17:33:34 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1be97799-70d5-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 18:33:33 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1be97799-70d5-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669829613; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nRNYjN3h3CCOcy1einFYCiePqE0uvjAOH9wR0gDEFwk=; b=L8Fy8iTrQkDNdIthMQhwTx5EjiLbnU5vGWHMYkVElTqvwOx49SA6yIT5 JUwZvrDzr6nSoEMY0w/2wEh8Krx9800ba1gP0gqh6mvUZ1LmGaWrNettm YbWYiPuyZjb7FYiBjGwOYBR6QBMJONZa5vYW9NArFNcNpfd3JciS88U9x 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 84930607 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:VRU5qKLn40two+x+FE+RxpUlxSXFcZb7ZxGr2PjKsXjdYENSg2cOz GMWC2rXOKyLNDCnKYp/atjko0sBvJbRndVrSAdlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wdmPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c59OUwSx aQ7dAwXYzCN3biTwJGSGu5z05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLozkPmpgD/jdCdfq3qepLYt4niVxwt0uFToGIqJK4fSG50K9qqej mfXzlTJIB0FDuCkyjq9tVmDmOSVzRquDer+E5Xnr6U30TV/3Fc7Fxk+RVa95/6jhSaWV9tBJ mQO9yEprKx081akJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpVTA9nJZoH3pwj AbPxo63Q2w02FGIdZ6D3r2sgG+CYQtJEXUPRSFeFy4FwPCzp55m23ojUe1fOKKyi9T0HxT5z DaLsDUyit0vsCIb60mo1QuZ2mzx//AlWiZwv1yKBTz9smuVcab/P+SVBU7nAeGsxWpzZn2Ip zA6lseX94ji5rndxXXWEI3h8FxEjstp0QEwY3Y1R/HNFBz3oRZPmLy8BxkgTHqFyu5eJVfUj Lb74Gu9HqN7MnqwdrNQaImsEcksxqWIPY27CKGLMoQQP8YtKFHvEMRSiai4hTiFfK8EyPFXB HtmWZz0USZy5VpPk1JauNvxIZd0n3tjlAs/tLjwzgi90Kr2WZJmYe5tDbd6VchgtPnsiFyMo 75i2z6il003vBvWPnOGrub+7DkicRAGOHwBg5UMJ7TafVo7QDhJ5j246epJRrGJVp99zo/gl kxRkGcDlzITWVWvxd22V01e IronPort-HdrOrdr: A9a23:4k4Kzqq9ZxEBJIM7mHsaWaUaV5oReYIsimQD101hICG8cqSj9v xG+85rrCMc6QxhI03I9urwW5VoLUmyyXcx2/h0AV7AZniBhILLFvAB0WKK+VSJcEeSmtK1l5 0QFJSWYOeAdWSS5vyb3ODXKbgdKaG8gcWVuds= X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="84930607" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Christian Lindig" , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH v1 4/5] tools/ocaml/libs/xb: add missing stdint.h Date: Wed, 30 Nov 2022 17:32:36 +0000 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain xs_wire.h fails to compile without this, and a slight rearrangement of header includes (e.g. by clang-format) could cause the file to fail to compile. Be more robust and include the needed header file. --- tools/ocaml/libs/xb/xenbus_stubs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/ocaml/libs/xb/xenbus_stubs.c b/tools/ocaml/libs/xb/xenbus_stubs.c index e5206f64d4..ce6d33b23e 100644 --- a/tools/ocaml/libs/xb/xenbus_stubs.c +++ b/tools/ocaml/libs/xb/xenbus_stubs.c @@ -15,6 +15,7 @@ */ #include +#include #include #include #include -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 17:33:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 17:33:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450104.707316 (Exim 4.92) (envelope-from ) id 1p0Qxl-0006Y0-5e; Wed, 30 Nov 2022 17:33:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450104.707316; Wed, 30 Nov 2022 17:33:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Qxk-0006Wx-Ve; Wed, 30 Nov 2022 17:33:36 +0000 Received: by outflank-mailman (input) for mailman id 450104; Wed, 30 Nov 2022 17:33:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Qxj-00053d-OM for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 17:33:35 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1cf9c908-70d5-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 18:33:33 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cf9c908-70d5-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1669829613; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=1DtJVEJDuLs3FUpxmGPE7DJyqdoBc05y8Jvs9j/LnvE=; b=fMZ9hJ1QkRo8MZM28UC277p+pvl1EpZI5sz1aAkdhgzP/BJvNz3hAGjM ZkqMhYIEAgMe678iuARGqgS3EEX0WcEoruxnmqG2JFifm2ZMJ8VOUS6no Gpq9NYc9vZmQpVD+E3OnEkvtMdV4jA48j5aMIyRfAEv8bna4/x0Lo0pH6 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 84930632 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:g3UpkaAHq4F/ixVW/+Hjw5YqxClBgxIJ4kV8jS/XYbTApDJ30WEEz jYWXD2EPa2DM2X0eI8jPt+39x9TvZ+BxoJmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpD5gRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw3+NKDDt1y 80hLHMTNxG7nfyn6r2iY7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/BZ4gneHumn7ldD5wo1OJv6snpWPUyWSd1ZC9bIuOIoLRH625mG7Gh SHZvE6nWysxNYaB1gqf7W2CxermyHaTtIU6S+Tjq68CbEeo7mAaFhA+T1awpvi9zEmkVLp3K UYZ5y4vpqga71GwQ5/2WBjQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceXic23 1WEm9foAz1Hs7CPT3+ZsLCOoluaJiw9PWIEIygeQmMt4cTnoYw1pgLCSJBkCqHdszHuMWium XbQ9nF43uhNy55Qv0mmwbzZqxepm5WTdTAE3wGUQDuk1hlndaSqfqX9vDA38s18BIqeS1CAu l0NlM6f8P0CAPmxqcCdfAkeNOr3vqjYaVUwlXYqRsB8rGr1pxZPaKgKuFlDyFFV3tHokNMDS Gvaoktv6ZBaJxNGhocnMtvqW6zGIUUNfOkJt8w4jPIUOvCdlyfdpkmCgHJ8OEiz+HXAaYllZ f+mnT+EVB7285hPwjusXPs62rQ23C04zm67bcmlkUX4jeTAOSDJFelt3L6yggYRtvvsTOL9q oY3Cid3408HDL2Wjtf/rub/0mzm3VBkXMur+qS7h8aIIxZ8GXFJNhMi6epJRmCRpIwMzr2g1 ijkCidlJK/X2SWvxfOiNioyN9sCnP9X8RoGAMDbFQ/ziiJ6PtbytP53mlleVeBPydGPBMVcF 5EtE/hsyNweFFwrJxx1gUHBkbFf IronPort-HdrOrdr: A9a23:dVHzEa9bABD2WhQuQeluk+AcI+orL9Y04lQ7vn2ZKSY5TiX4rb HKoB1/73XJYVkqN03I9ervBEDiewK/yXcW2+ks1N6ZNWGLhILBFupfBODZsl7d8kPFl9K01c 1bAtJD4N+bNykGsS4tijPIb+rJw7O8gd+Vbf+19QYIcenzAZsQlzuQDGygYypLbTgDP7UVPr yG6PFKojKxEE5nFfhSVhE+Lo7+T8SgruOeXSI7 X-IronPort-AV: E=Sophos;i="5.96,207,1665460800"; d="scan'208";a="84930632" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Christian Lindig , David Scott , Anthony PERARD Subject: [PATCH v1 0/5] OCaml bindings for hvm_param_get and xc_evtchn_status Date: Wed, 30 Nov 2022 17:32:32 +0000 Message-ID: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Add bindings to xc_evtchn_status and hvm_param_get, useful for xenopsd and for recovery from failed live updates. .editorconfig helps me format the source code with the desired Xen coding style (now that the reindent patch has switched it to spaces as desired by the Xen project). If you don't have an editor set up to use editorconfig this is a no-op. .clang-format is an experiment for the OCaml subtree in slowly moving its code to be closer to the Xen coding style. There is no Xen coding style as such in clang-format, this takes GNU as a base and tweaks it to be as close to CODING_STYLE as possible (there is just one different in handling of do/while as far as I can tell). It should be an improvement over the current situation where the OCaml C bindings do not follow Xen coding style, and further bindings added that follow the style of the code around them would not follow it either. It doesn't yet reformat anything with it, just allows someone that submits patches to use it if desired (e.g. on new code). Edwin Török (5): CODING-STYLE: add .editorconfig to clarify indentation uses spaces tools/ocaml/libs/xc: add binding to xc_evtchn_status tools/ocaml/libs/xc: add hvm_param_get binding tools/ocaml/libs/xb: add missing stdint.h CODING_STYLE: add .clang-format .editorconfig | 20 +++++++ tools/ocaml/.clang-format | 9 ++++ tools/ocaml/libs/xb/xenbus_stubs.c | 1 + tools/ocaml/libs/xc/xenctrl.ml | 58 +++++++++++++++++++++ tools/ocaml/libs/xc/xenctrl.mli | 60 +++++++++++++++++++++ tools/ocaml/libs/xc/xenctrl_stubs.c | 81 +++++++++++++++++++++++++++++ 6 files changed, 229 insertions(+) create mode 100644 .editorconfig create mode 100644 tools/ocaml/.clang-format -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Nov 30 18:44:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 18:44:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450130.707328 (Exim 4.92) (envelope-from ) id 1p0S3j-0008IR-Le; Wed, 30 Nov 2022 18:43:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450130.707328; Wed, 30 Nov 2022 18:43:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0S3j-0008IK-IC; Wed, 30 Nov 2022 18:43:51 +0000 Received: by outflank-mailman (input) for mailman id 450130; Wed, 30 Nov 2022 18:43:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0S3i-0008IA-Ls; Wed, 30 Nov 2022 18:43:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0S3i-0004kZ-JI; Wed, 30 Nov 2022 18:43:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0S3i-0002ql-2f; Wed, 30 Nov 2022 18:43:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1p0S3i-0007JR-2D; Wed, 30 Nov 2022 18:43:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=f3iLq5hPsjxnHfFnuQxoDCk7Sgc8hWDciwPQIB1H5yU=; b=2Yh2Fc4kZKNgMF5z/70JGK+VLq EfuEZ4cbi9WIxLqqoi5l8atB5cp3C7LVcs3FZGvgD0OYObizepEwugAbGxIXvQWAoKL0xEY4GJAXz N6JOhjZrrxk/tLanFQ2M1HOysKDR+AocI+Pt6M2AlUpvDiWqjKDInlUUb8Fo6HrItUcs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 174996: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=01f856ae6d0ca5ad0505b79bf2d22d7ca439b2a1 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 30 Nov 2022 18:43:50 +0000 flight 174996 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174996/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-thunderx 14 guest-start fail pass in 174991 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 174991 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 174991 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: linux 01f856ae6d0ca5ad0505b79bf2d22d7ca439b2a1 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 53 days Failing since 173470 2022-10-08 06:21:34 Z 53 days 103 attempts Testing same since 174991 2022-11-29 21:43:19 Z 0 days 2 attempts ------------------------------------------------------------ 1924 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 184155 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Nov 30 19:40:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 19:40:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450138.707342 (Exim 4.92) (envelope-from ) id 1p0SwN-00076d-R8; Wed, 30 Nov 2022 19:40:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450138.707342; Wed, 30 Nov 2022 19:40:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0SwN-00076W-OL; Wed, 30 Nov 2022 19:40:19 +0000 Received: by outflank-mailman (input) for mailman id 450138; Wed, 30 Nov 2022 19:40:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0SwM-00076P-Iv for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 19:40:18 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d11e5440-70e6-11ed-8fd2-01056ac49cbb; Wed, 30 Nov 2022 20:40:17 +0100 (CET) Received: by mail-ed1-x534.google.com with SMTP id a16so3970402edb.9 for ; Wed, 30 Nov 2022 11:40:17 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d11e5440-70e6-11ed-8fd2-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=98zeIMBH0W3RLt+Fp+Yzmkk0Rvjajs1ZMHuz47k0oRk=; b=Ej83uBVjcRpD5UMAKZObwpQ+PbJQqifAenDMDyDJhsQQEAFwXSgoAmInrktMFeGd1D Rv37aNrcfm737NzSpBzLM1sJq1PAAfSnoX3sjRKqvltRncMZ9JAzuAtensm0R1G4OS9t A4UDBse0+A1tcd5cRgGiYMfw/WHKCkw8R9UF6EYsgjMG+uwji0j4Alsow++jCKWAprJj Dgdb7OCIdBGGvkN4Cynnzt3B2Yui8aPMsQCFYgBJoWbh2twnpWZdPXeH63IfDePWmY3V Y57XS+CGlS6hWJ8VNZ+aqksM3X7kt7v52P4x+pb32c8qFHWdxMssrnCz9xF292/dHujg oXfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=98zeIMBH0W3RLt+Fp+Yzmkk0Rvjajs1ZMHuz47k0oRk=; b=BHfMXTbFX/wJ0+SOkSrKEoHl7FJEjFODn4sJanm1MvsJHXztjGEE1J+GkFR58ugYLD S6m7sDRegNcz5VLRwpYgOamHeDDCgboCe+h6RsBZe9rlxOiJm27V21CaglSlXx8i3hPd QpyHyu/LPCLvQqlOtuCiGGArUo9r5RJ0UFyMHILUZoVS+wYRur09J29RiLtQufqhX4Nr xkpP4O9FsgRvHxl3uULHA4PY3nIMDg99rV5E8BYgZ22LKI0wXEyvTMDl5FicGoJgDNui hqxlVnmBkCLLdArB4xEhAgGe4MQko4HczlquBk+q6Scejzo5a5wJ2NJiHVwG+uaXKDz8 LMVA== X-Gm-Message-State: ANoB5pnYrrwFQ0/+eEAaiRp5XXurcSW5kE9umhdp57NVjASJO1f5ZA3Y RV76VxBj/YKvyWTdmgWeX/Vi4pSKNBtWPxfZugc= X-Google-Smtp-Source: AA0mqf6QZLf6o6EcgkGaIDNmKKDe9Lkj9iL8O1A+Bf/LH1MNOzf2XqAfYKusTY0yAUnSF68weHxz5zqocd9jwOA/bHY= X-Received: by 2002:a05:6402:4284:b0:461:8156:e0ca with SMTP id g4-20020a056402428400b004618156e0camr2609018edc.271.1669837216769; Wed, 30 Nov 2022 11:40:16 -0800 (PST) MIME-Version: 1.0 References: <20221118154931.1928298-1-marmarek@invisiblethingslab.com> In-Reply-To: From: Jason Andryuk Date: Wed, 30 Nov 2022 14:40:04 -0500 Message-ID: Subject: Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "moderated list:XEN HYPERVISOR INTERFACE" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Nov 28, 2022 at 8:44 AM Marek Marczykowski-G=C3=B3recki wrote: > > On Mon, Nov 21, 2022 at 05:16:37PM +0100, Marek Marczykowski-G=C3=B3recki= wrote: > > On Mon, Nov 21, 2022 at 10:41:34AM -0500, Jason Andryuk wrote: > > > On Sat, Nov 19, 2022 at 11:33 AM Marek Marczykowski-G=C3=B3recki > > > wrote: > > > > > > > > On Sat, Nov 19, 2022 at 09:36:54AM -0500, Jason Andryuk wrote: > > > > > Hi, Marek, > > > > > > > > > > On Fri, Nov 18, 2022 at 4:46 PM Marek Marczykowski-G=C3=B3recki > > > > > wrote: > > > > > > > > > > > > On Fri, Nov 18, 2022 at 03:46:47PM -0500, Jason Andryuk wrote: > > > > > > > I was trying to test your xen-pciback v3 patch, and I am havi= ng > > > > > > > assignment fail consistently now. It is actually failing to > > > > > > > quarantine to domIO in the first place, which matches the fai= lure from > > > > > > > the other day (when I more carefully read through the logs). = It now > > > > > > > consistently fails to quarantine on every boot unlike the oth= er day > > > > > > > where it happened once. > > > > > > > > > > > > Does this include the very first assignment too, or only after = domain > > > > > > reboot? If the latter, maybe some cleanup missed clearing MASKA= LL? > > > > > > > > > > It's the quarantine during dom0 boot that fails. Later assignmen= t > > > > > during VM boot fails. I tried warm reboots and cold boots and it > > > > > happened both times. > > > > > > > > > > I also modified my initrd to halt in there and checked the config > > > > > space. MASKALL wasn't set at that time. I need to double check = - > > > > > MASKALL may have been unset after dom0 booted in that case. > > > > > > > > > > I'll test more to figure when and how MASKALL is getting set. > > > > > > I'm testing with a laptop without a battery. It seems MASKALL remain= s > > > set when rebooting or when left plugged in. > > > > > > From unplugged, a cold boot doesn't have MASKALL set and the network = vm boots. > > > > > > After that, rebooting the laptop leaves MASKALL set on the NIC when > > > the laptop reboots. NIC assignment fails. > > > > > > Shutdown and later boot while left plugged in keeps MASKALL set. NIC > > > assignment fails. I have only tested this scenario for short periods > > > of time, so I don't know if it would eventually clear after a longer > > > time. > > > > That's interesting, seems like firmware is not resetting the device > > properly. Maybe related to enabled wake on lan? > > > > Anyway, resetting the device at domain create/destroy is AFAIR normally > > done by pciback (at the instruction by the toolstack). Should it maybe > > be done when assigning to pciback initially too? Or maybe in this > > specific case, device reset doesn't properly clear MASKALL, so pciback > > should clear it explicitly (after ensuring the MSI-X enable is cleared > > too)? > > Can you check if `echo 1 > /sys/bus/pci/devices/$SBDF/reset` clears > MASKALL on this device? `echo 1 > ..../reset` did not clear MASKALL. After shutting down the domain with the iwlwifi card, lspci from dom0 shows= : MSI-X: Enable+ Count=3D16 Masked+ Hmm, Xen logged: (XEN) cannot disable IRQ 137: masking MSI-X on 0000:00:14.3 Oh, looking back, I see that was logged during my earlier testing of this patch set, but I missed it. It seems like Xen set Enable and Masked itself in __pci_disable_msix() since memory decoding is not enabled. I'm still investigating, but I wanted to give an update. It seems like Xen should clear MASKALL when booting. Something like clearing MASKALL in pdev_msi_init() when !ENABLE & MASKALL. However, I have seen the system boot with both Enable and Maskall set on the iwlwifi nic. Is it risky to just unilaterally clear both of those when enumerating PCI devices? It doesn't seem appropriate to leave them set without a driver controlling them. -Jason From xen-devel-bounces@lists.xenproject.org Wed Nov 30 20:27:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 20:27:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450143.707353 (Exim 4.92) (envelope-from ) id 1p0TfK-0004Ek-63; Wed, 30 Nov 2022 20:26:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450143.707353; Wed, 30 Nov 2022 20:26:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0TfK-0004Ed-3H; Wed, 30 Nov 2022 20:26:46 +0000 Received: by outflank-mailman (input) for mailman id 450143; Wed, 30 Nov 2022 20:26:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0TfI-0004EW-2o for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 20:26:44 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4cdf04b9-70ed-11ed-91b6-6bf2151ebd3b; Wed, 30 Nov 2022 21:26:42 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 42D35B81CB6; Wed, 30 Nov 2022 20:26:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEF67C433D6; Wed, 30 Nov 2022 20:26:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4cdf04b9-70ed-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669840000; bh=hTA7WgHQABTbX7zcxAmm6zaSiv0uvJEgBF8pD79miy4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=M+vhsJ9pcR4zzihPovnTvwLKv7Rt6Lm5y3Nyue6OLRpsJKj+2uI5aEdnCrZTzWT6O IM9HJNRJIFu+HlDZRy3Oi/KElAdXDuh+Dnddx2qUK2kCaSkO0Juos3K+mqNCQp25qv Y7XlPWp9lDydt6MVUUkhl4kjiWwOIQF+QWRriSpMtDLntUPd6dpvftEHtKhLVHN6HK 7oFiMCunV4jaIQwpvjjmEPxEUznVYPiHRgTMmaTuY/iO9q5KMJexvDgPkmoDAYeQ5+ HdKliRi4weTOyqydD62nQ2i0acJ+ynebp3W/pA1uS/0M7zVjFPSJyuty8lUmufrtjd VHa1meRgmhrRQ== Date: Wed, 30 Nov 2022 12:26:37 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Stefano Stabellini , Xen-devel , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH 2/4] xen/scripts: add cppcheck tool to the xen-analysis.py script In-Reply-To: Message-ID: References: <20221128141006.8719-1-luca.fancellu@arm.com> <20221128141006.8719-3-luca.fancellu@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-271742979-1669837606=:4039" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-271742979-1669837606=:4039 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Wed, 30 Nov 2022, Luca Fancellu wrote: > Hi Stefano, > > > I think the revert of the cppcheck integration in xen/Makefile and > > xen/tools/merge_cppcheck_reports.py could be a separate patch. There is > > no need to make sure cppcheck support in the xen Makefile is > > "bisectable". That patch could have my acked-by already. > > Ok I will split these changes in a following patch > > > > > Also the document changes introduced in this patch have my reviewed-by: > > - docs/misra/cppcheck.txt > > - docs/misra/documenting-violations.rst > > - docs/misra/false-positive-cppcheck.json > > - docs/misra/xen-static-analysis.rst > > Thank you, should I put those files in a separate patch with your rev-by before > this patch or this is just a comment for you to remember which file you already > reviewed? If Jan and the other reviewers are OK, I think you could split them out in a separate patch and add my reviewed-by. If Jan prefers to keep it all together in one patch, then I wrote it down so that I remember what I have already acked :-) > >> + > >> +def generate_cppcheck_deps(): > >> + global cppcheck_extra_make_args > >> + > >> + # Compile flags to pass to cppcheck: > >> + # - include config.h as this is passed directly to the compiler. > >> + # - define CPPCHECK as we use it to disable or enable some specific part of > >> + # the code to solve some cppcheck issues. > >> + # - explicitely enable some cppcheck checks as we do not want to use "all" > >> + # which includes unusedFunction which gives wrong positives as we check > >> + # file per file. > >> + # - Explicitly suppress warnings on compiler-def.h because cppcheck throws > >> + # an unmatchedSuppression due to the rule we put in suppression-list.txt > >> + # to skip every finding in the file. > >> + # > >> + # Compiler defines are in compiler-def.h which is included in config.h > >> + # > >> + cppcheck_flags=""" > >> +--cppcheck-build-dir={}/{} > >> + --max-ctu-depth=10 > >> + --enable=style,information,missingInclude > >> + --template=\'{{file}}({{line}},{{column}}):{{id}}:{{severity}}:{{message}}\' > >> + --relative-paths={} > >> + --inline-suppr > >> + --suppressions-list={}/suppression-list.txt > >> + --suppress='unmatchedSuppression:*generated/compiler-def.h' > >> + --include={}/include/xen/config.h > > > > I noticed that some of the includes we used to have like > > xsm/flask/include are missing here. Is that intended? > > Yes it is, now that cppcheck is using the JSON compilation database, it can understand > by the compilation argument “-I” what include path it needs to add, before we were > adding it to every file, resulting in some false positive from the tool. > Just --include={}/include/xen/config.h is needed because in the Xen makefile we are doing > the same, passing the option to the compiler, resulting in every compiled file to have that > header included. OK, good to hear the process is improving > >> > >> + case ${OPTION} in > >> + -h|--help) > >> + help > >> + exit 0 > >> + ;; > >> + --compiler=*) > >> + COMPILER="$(eval echo "${OPTION#*=}")" > > > > This can be: > > > > COMPILER="${OPTION#*=}" > > > > and same for all the other below > > Ok I’ll fix that > > > > > > >> + sm_tool_args="n" > >> + ;; > >> + --cppcheck-cmd=*) > >> + CPPCHECK_TOOL="$(eval echo "${OPTION#*=}")" > >> + sm_tool_args="y" > >> + ;; > >> + --cppcheck-html) > >> + CPPCHECK_HTML="y" > >> + sm_tool_args="n" > >> + ;; > >> + --cppcheck-plat=*) > >> + CPPCHECK_PLAT_PATH="$(eval echo "${OPTION#*=}")" > >> + sm_tool_args="n" > >> + ;; > >> + --ignore-path=*) > >> + IGNORE_PATH_LIST="${IGNORE_PATH_LIST} $(eval echo "${OPTION#*=}")" > >> + sm_tool_args="n" > >> + ;; > >> + --) > >> + forward_to_cc="y" > >> + sm_tool_args="n" > >> + ;; > >> + *) > >> + if [ "${sm_tool_args}" = "y" ]; then > >> + CPPCHECK_TOOL_ARGS="${CPPCHECK_TOOL_ARGS} ${OPTION}" > >> + else > >> + echo "Invalid option ${OPTION}" > >> + exit 1 > > > > It doesn't look like sm_tool_args is really needed? It is only set to > > 'y' in the case of --cppcheck-cmd, and in that case we also set > > CPPCHECK_TOOL. CPPCHECK_TOOL is the variable used below. Am I missing > > something? > > We use sm_tool_args to fill CPPCHECK_TOOL_ARGS, basically it’s a state machine where > when we find --cppcheck-cmd= we expect that every other space separated arguments > passed afterwards are the args for cppcheck, so we append to CPPCHECK_TOOL_ARGS > until we find an argument that is supposed to be only for this script. That seems a bit unnecessary: if the user wants to pass arguments to cppcheck, the user would do --cppcheck-cmd="cppcheck arg1 arg2" with "" quotes. Doing that should make --cppcheck-cmd="cppcheck arg1 arg2" be seen as a single argument from this script point of view. CPPCHECK_TOOL would end up being set to "cppcheck arg1 arg2" which is what we want anyway? And if we need to distinguish between the cppcheck binary and its argument we could use "cut" to extract "cppcheck", "arg1", and "arg2" from CPPCHECK_TOOL. Would that work? > > > >> + fi > >> + ;; > >> + esac > >> +done > >> + > >> +if [ "${COMPILER}" = "" ] > >> +then > >> + echo "--compiler arg is mandatory." > >> + exit 1 > >> +fi > >> + > >> +function print_file() { > >> + local text="${1}" > >> + local init_file="${2}" > >> + > >> + if [ "${init_file}" = "y" ] > >> + then > >> + echo -e -n "${text}" > "${JDB_FILE}" > >> + else > >> + echo -e -n "${text}" >> "${JDB_FILE}" > >> + fi > > > > The >> can be used to create a file if the file is not already present. > > So why the need for this if? In fact, we don't need print_file at all > > and we can just > > > > echo -e -n "something" >> "${JDB_FILE}" > > > > directly from create_jcd. If you are concerned about a preexisting file, > > then at the beginning of create_jcd you can: > > > > rm "${JDB_FILE}" > > Ok I’ll remove the file in the top of create_jcd and use echo -e -n "something" >> "${JDB_FILE}” > > >> > >> + > >> + # Check wchar size > >> + wchar_plat_suffix="t4" > >> + # sed prints the last occurence of -f(no-)short-wchar which is the one > >> + # applied to the file by the compiler > >> + wchar_option=$(echo "${FORWARD_FLAGS}" | \ > >> + sed -nre 's,.*(-f(no-)?short-wchar).*,\1,p') > >> + if [ "${wchar_option}" = "-fshort-wchar" ] > >> + then > >> + wchar_plat_suffix="t2" > >> + fi > > > > This seems a bit unnecessary: we should be able to find the right > > platform file from XEN_TARGET_ARCH alone. No need to reverse engineer > > the compiler command line? > > The efi code is compiled with -fshort-wchar, but the rest of the file uses default length wchar, > now maybe it was a bit of overthinking because I guess we have only these cases: > > arm64: arm64-wchar_t2 (efi code uses -fshort-wchar) > arm32: arm32-wchar_t4 (efi code is not in, but common-stub compiled with -f-no-short-wchar) > x86_64: x86_64-wchar_t2 (efi code uses -fshort-wchar) > > Am I right? Yes I think so too > > > >> + > >> + # Select the right target platform, ARCH is generated from Xen Makefile > >> + platform="${CPPCHECK_PLAT_PATH}/${ARCH}-wchar_${wchar_plat_suffix}.xml" > >> + if [ ! -f "${platform}" ] > >> + then > >> + echo "${platform} not found!" > >> + exit 1 > >> + fi > >> + > >> + # Shellcheck complains about missing quotes on CPPCHECK_TOOL_ARGS, but > >> + # they can't be used here > >> + # shellcheck disable=SC2086 > >> + ${CPPCHECK_TOOL} ${CPPCHECK_TOOL_ARGS} \ > >> + --project="${JDB_FILE}" \ > >> + --output-file="${out_file}" \ > >> + --platform=${platform} > >> + > >> + if [ "${CPPCHECK_HTML}" = "y" ] > >> + then > >> + # Shellcheck complains about missing quotes on CPPCHECK_TOOL_ARGS, > >> + # but they can't be used here > >> + # shellcheck disable=SC2086 > >> + ${CPPCHECK_TOOL} ${CPPCHECK_TOOL_ARGS} \ > >> + --project="${JDB_FILE}" \ > >> + --output-file="${out_file%.txt}.xml" \ > >> + --platform=${platform} \ > >> + -q \ > >> + --xml > > > > This is showing my ignorance in cppcheck, but does it actually need to > > be called twice in the html generation case? Actually three times if we > > count the extra cppcheck-htmlreport call? > > Cppcheck is not able to output a text report and an XML report at the same time, > hence we need to call it twice, but the second call will use the cppcheck build directory > As a “cache” to generate the results so it will be much more faster than the first one. OK > > > >> + fi > >> + fi > >> +fi > >> diff --git a/xen/tools/cppcheck-plat/arm32-wchar_t4.xml b/xen/tools/cppcheck-plat/arm32-wchar_t4.xml > >> new file mode 100644 > >> index 000000000000..3aefa7ba5c98 > >> --- /dev/null > >> +++ b/xen/tools/cppcheck-plat/arm32-wchar_t4.xml > >> @@ -0,0 +1,17 @@ > >> + > >> + > >> + 8 > >> + unsigned > > > > usually in C the default is actually "signed" not "unsigned". If you > > write: > > > > int i; > > > > i is signed > > It took me a bit to understand this field, as the documentation is not clear at all, the default-sign is referring > to the default char sign, which should be unsigned for arm, right? OK > Here the code to cppcheck that clarifies the field: > > https://github.com/danmar/cppcheck/blob/2.7.5/lib/platform.cpp > > At line 204, defaultSign is taking the value of , at line 64, when the platform is Native, > defaultSign = (std::numeric_limits::is_signed) ? 's' : 'u'; > > I’ve done some tests with this code in arm/arm64/x86_64: > > #define is_type_signed(my_type) (((my_type)-1) < 0) > if (is_type_signed(char)) > printf("signed\n"); > else > printf("unsigned\n"); > > And I have unsigned for arm/arm64 and signed for x86_64 (which I will change as it is wrong in this patch) > > Can you confirm my results are right? It looks like this is compiler specific. Yes, surprisingly with gcc I got the same results as you. --8323329-271742979-1669837606=:4039-- From xen-devel-bounces@lists.xenproject.org Wed Nov 30 23:35:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 23:35:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450152.707364 (Exim 4.92) (envelope-from ) id 1p0WbP-0001Xm-Mf; Wed, 30 Nov 2022 23:34:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450152.707364; Wed, 30 Nov 2022 23:34:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0WbP-0001Xf-Jo; Wed, 30 Nov 2022 23:34:55 +0000 Received: by outflank-mailman (input) for mailman id 450152; Wed, 30 Nov 2022 23:34:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0WbO-0001XY-7i for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 23:34:54 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9626366d-7107-11ed-91b6-6bf2151ebd3b; Thu, 01 Dec 2022 00:34:51 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 13BB1B81D4C; Wed, 30 Nov 2022 23:34:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78A26C433D7; Wed, 30 Nov 2022 23:34:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9626366d-7107-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669851289; bh=sH7yawajOhxCWBy5ixMt2NF23DQGDiZ8jFNwV5R6bv0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=HdoQBgwvj1hmsNlaI0u5Vbc3Y1BbUvjlUBFL5a0Q2Y6fNDRWKnuVGuQJnfoxzjaY+ g3YP+cw0Bk0UqY2njfp2Ga+jRVqzZQ6aRk+0jNfewX57u2RFZOl/usrloqQy7Szf60 kU5TH0z5nyab+bfow56q7I8whx5X597bXR2qbaUjLzASi3lAvSC/aEVjSzDX97PG11 6SOcqU6UgWzDEqNl36giF4w/XR+7NWBc0XLgZ+SuTQgIDA4mnTpxQHmDJLXnOb/6XA Co4Qzs0foCeKFGxWyX5pblF4DlQMIaC/wrG/3xNuDAJ02JfOYB9P/XMlh4otAl0Nnb ofMkQjps4tNbg== Date: Wed, 30 Nov 2022 15:34:47 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Stefano Stabellini , Xen-devel , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH 3/4] tools/misra: fix skipped rule numbers In-Reply-To: <21F6A61B-1476-49A7-8726-7F94BBA627F6@arm.com> Message-ID: References: <20221128141006.8719-1-luca.fancellu@arm.com> <20221128141006.8719-4-luca.fancellu@arm.com> <21F6A61B-1476-49A7-8726-7F94BBA627F6@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 30 Nov 2022, Luca Fancellu wrote: > > On 29 Nov 2022, at 23:51, Stefano Stabellini wrote: > > > > On Mon, 28 Nov 2022, Luca Fancellu wrote: > >> Currently the script convert_misra_doc.py is using a loop through > >> range(1,22) to enumerate rules that needs to be skipped, however > >> range function does not include the stop counter in the enumeration > >> ending up into list rules until 21.21 instead of including rule 22. > >> > >> Fix the issue using a dictionary that list the rules in misra c2012. > > > > I think I understand the problem you are trying to solve with this > > patch. But I am confused about the proposed solution. > > > > The original code is trying to list all the possible MISRA C rules that > > are not in docs/misra/rules.rst. Instead of list(range(1,22)) now we > > have a dictionary: misra_c2012_rules. But misra_c2012_rules doesn't have > > all the possible MISRA C rules missing from docs/misra/rules.rst. > > > > As an example Rule 13.1 is missing from docs/misra/rules.rst but it is > > also missing from misra_c2012_rules. > > > > Can you please help me understand why misra_c2012_rules has only a small > > subset of MISRA C rules to be skipped? > > Hi Stefano, > > MISRA rules are in this format X.Y, misra_c2012_rules is a dictionary where the key is > X and the value is the maximum number that Y can have. > > For example rule 13.Y goes from 13.1 to 13.6 (in the dictionary misra_c2012_rules[13] == 6), > so the code can now check which among (13.1 .. 13.6) is not in the rule_list and add it to the > list of skipped rules. > > Here an example: > { > "script": "misra.py", > "args": [ > "--rule-texts=/path/to/cppcheck-misra.txt", > "--suppress-rules=1.1,1.2,1.4,2.2,2.3,2.4,2.5,2.6,2.7,3.1,4.1,4.2,5.5,5.6,5.7,5.8,5.9,6.1,7.1,7.2,7.3,7.4,8.2,8.3,8.7,8.9,8.11,8.13,8.14,9.3,9.4,9.5,10.1,10.2,10.3,10.4,10.5,10.6,10.7,10.8,11.1,11.2,11.3,11.4,11.5,11.6,11.7,11.8,11.9,12.1,12.2,12.3,12.4,12.5,13.1,13.2,13.3,13.4,13.5,14.2,14.3,14.4,15.1,15.2,15.3,15.4,15.5,15.6,15.7,16.1,16.2,16.3,16.4,16.5,16.6,17.1,17.2,17.5,17.6,17.7,17.8,18.1,18.2,18.3,18.4,18.5,18.6,18.7,18.8,19.1,19.2,20.1,20.2,20.3,20.4,20.5,20.6,20.8,20.9,20.10,20.11,20.12,21.1,21.2,21.3,21.4,21.5,21.6,21.7,21.8,21.9,21.10,21.11,21.12,21.13,21.14,21.15,21.16,21.17,21.18,21.19,21.20,21.21,22.1,22.2,22.3,22.4,22.5,22.6,22.7,22.8,22.9,22.10" > ] > } > > So this patch is solving two issues, the first one was that rule 22.Y was never included in the suppressed > list because range(1,22) produces a range in [1..21], the second issue is that the code was producing > Invalid MISRA C 2012 rules, for example 1.21 and so on. I see, that makes sense. Please improve the commit message with this information and add Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Wed Nov 30 23:59:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 30 Nov 2022 23:59:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.450159.707375 (Exim 4.92) (envelope-from ) id 1p0Wyx-0004Rs-JO; Wed, 30 Nov 2022 23:59:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 450159.707375; Wed, 30 Nov 2022 23:59:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Wyx-0004Rl-GS; Wed, 30 Nov 2022 23:59:15 +0000 Received: by outflank-mailman (input) for mailman id 450159; Wed, 30 Nov 2022 23:59:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1p0Wyw-0004Rf-GI for xen-devel@lists.xenproject.org; Wed, 30 Nov 2022 23:59:14 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fd2a8f93-710a-11ed-91b6-6bf2151ebd3b; Thu, 01 Dec 2022 00:59:13 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A5557B81AD6; Wed, 30 Nov 2022 23:59:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBFDBC433C1; Wed, 30 Nov 2022 23:59:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd2a8f93-710a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669852750; bh=+jdLgipg+i8X1zSuiLJPQdlQIKwcTqe9BIBIVU0hRZM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=iOOvY6FpXTo4Gfp2g+C0xCA1v9jzVcR655gqWsnEVrPElJcikD7Xq2sfHleEd5ec9 wt/F0mp+SUm9jf67UwXPcCUKGCTb+npNkqSUldNfvCC7Pge1aG3Cy3gcKoI4xNEruv FQSnzvhzpAXFH5w4bAhssBWPWbS4nKekE2JOIEDS+NXpQelXcllvBN8FXkbnSysfqa 0ByTpwWaUEAGZ0c0UhGfVvp6d7LJwLmb2OC810DTR/ELskZdPKc/OM+vNZpepkeD/4 bScSWRZPI6+WBRvubvOAlmH0quoFlSnpmceNHtija6JUGMwjIaWt3GD5jt03l42wS0 W+ulzli19uqJg== Date: Wed, 30 Nov 2022 15:59:08 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: dega kiran cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand.Marquis@arm.com, vsuneja63@gmail.com Subject: Re: Guest Display issue on Xen In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-806537791-1669852520=:4039" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-806537791-1669852520=:4039 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: +Vipul Hi Dega, Vipul recently found a similar issue. He is using "vfb" in the xl config file, the guest is created but he is getting a black screen. We checked the xenstore output and frontend and backend seem to be properly initialized and connected. I am not sure how to proceed if not by adding printf and printk in the relevant frontend and backend code in Linux and QEMU to figure out where things go wrong: drivers/video/fbdev/xen-fbfront.c in Linux hw/display/xenfb.c in QEMU I also suggested a workaround to Vipul [1]: do not use "vfb" at all and instead setup a normal network connection with the domU using "vif". Then run a vncserver in the domU and connect to it over the network using vnclient in dom0. Cheers, Stefano [1] https://marc.info/?l=xen-devel&m=166916188230575 On Wed, 30 Nov 2022, dega kiran wrote: > Hi, > > I am porting Xen Hypervisor on raspberry pi4. I could port xen minimal image as host & wayland based GUI image as guest. Now I am trying to > bring up guest Display (using vncviewer) which is not coming up, even I could see xen-fbfront driver on guest and Debugged > > xen-fbfront.c > > Xenbusprobe_backend.c > > Xenbusprobe_frontend.c > > But not sure where is the actual issue. > > Let me know which part of code will help us more  for better understanding the issue. > > > --8323329-806537791-1669852520=:4039--